Problem using chef for upgrade

Hi,
During the last year I've had the possibility to use chef for installing AGE on a couple of customers sites; after a deep learning curve I've managed to do it correctly.
Now I want to upgrade a system from 10.6.1 to 107.1 using cookbooks 3.5.0.
To a large extent it works as expected - changing references in the original recipes to new install media and updating version field.
I've got two problems:
1.
On one server with portal, server and data store - server is acting as hosting server -, upgrade runs as expected including upgrading webadaptor (named portal and server).
The same server contains a webadaptor referencing an server located on another machine - this server is federated with portal.
The webadaptor is named arcgis and trying to upgrade it fails - it claims already existing.
In another words: chef are able to upgrade webadaptors portal and server, but not arcgis.
2.
On a separate server we've installed a stand alone server and webdaptor. Trying to upgrade this server responds with error 28809. Could not validate the credentials for account ...... Confirm the credentials are correct and attempt the installation again.
I've checked and double checked the account - it's correct.
Any ideas on this ?
Thank you.
Best regards,
Peter Kusk

Hello @peterkusk,
For the first issue, how was the third Web Adaptor (arcgis) installed and configured (Manually, or with a separate chef json file)?
I suspect the issue could be related to Chef supporting the installation of two Web Adaptors (one for portal and one for AGS, the context name shouldn't matter). We only list two product codes for each version of the Web Adaptor:
https://github.com/Esri/arcgis-cookbook/blob/master/cookbooks/arcgis-enterprise/attributes/webadaptor.rb#L55
So if neither of these product codes are found in the registry then Chef will likely not recognized that its installed (so uninstall is skipped), and will attempt to install which throws the error that the Web Adaptor with name 'arcgis' already exists.
The product codes for the installed Web Adaptors can be found in HKEY_LOCAL_MACHINE -> SOFTWARE -> Wow6432Node->ESRI. Check to see if the 'arcgis' Web Adaptor contains a different product code that doesn't exist in
https://github.com/Esri/arcgis-cookbook/blob/master/cookbooks/arcgis-enterprise/attributes/webadaptor.rb#L55
And for the second issue, error 28809, is the ArcGIS Server service run-as account a local or domain account? Perhaps try a password reset on the account.

Hi @cameronkroeker,
Thank you very much for your answer.
Your answer for problem 1 describes exactly whats happening.
I couldn't wait for your answer and removed my problem webadaptor manually followed by install using chef.
Now I've got three webadaptors on my portal server - all version 10.7.11595.
Productcodes for these wa's are:
{5ECEF84F-592C-47D1-B7C5-9F3D7E2AB7CE}
{5F1D01EA-296E-4226-A704-6A90E2916782}
{7368D3C8-F13B-4786-AE38-B51952F43867}
From this it's obvious that the third one can't b recognized by chef according to your list of product codes.
That's OK with me - know I do know about this limitation.
We do in general install many webadaptors on one server - portal, hosting, reference one, reference two, geoevent, ...
Regarding problem two it's a domain account. I'll give your answer a try and if it doesn't help I'll run the update manually.
Thank you.
Best regards,
Peter Kusk


Add Homebrew install to readme

https://formulae.brew.sh/formula/ldpl

This is wonderful! Thank you very much for your contribution!

I want to ask you something; starting with LDPL 4.5 (still in development), when you build LDPL using make it installs some library files (.cpp) in /usr/local/lib/ldpl. Do you know if this could work as well with Homebrew, once we release it?

I'm not 100% certain but we should be able to get it to work
I might suggest changing this line https://github.com/Lartu/ldpl/blob/master/makefile#L48 to:
LDPLLIBLOCATION = "$(PREFIX)/lib/ldpl"

Ah! Yes! There, changed. Thank you very, very much! :smile:


Delay time dilation so users see the checkbox

Fixes https://github.com/flutter/flutter/issues/5066

LGTM


Fix pipeline builds

/lgtm

Is the bot broke?

Is the bot broke?

Interesting... One of the presubmits failed to run, but prow says it passed anyway... Even though it clearly timedout.
Let's try this...
/retest

/test all
Trying this since prow thinks things passed that didn't.


Migrate neli-proc-macros to syn 2.0.x

The transition to syn 2.x involved addressing several breaking changes from syn 1.x. Some of these changes were straightforward, such as the replacement of Tokens Add with Plus, Colon2 with PathSep, and the renaming of LifeTimeDef struct to LifeTimeParam. However, some changes required modifications to our structures. For instance, we now retrieve .meta from an Attribute instead of using .parse_meta(). Additionally, Paths now support .is_ident(), which simplifies their comparison.
The removal of NestedMeta necessitated a new approach to parsing nested elements from Paths using TokenTree tokens. These tokens can be Groups, Idents, Puncts, or Literals, enabling us to determine their purpose.

Hello, next week works well for me if there are any tweaks needed on this code. Just please let me know if anything comes up!

Hi @duMagnus, I'm currently reviewing this PR and will have a few comments to post a little bit later today.

Hi @jbaublitz, this is currently blocking my packaging request for Fedora, https://bugzilla.redhat.com/show_bug.cgi?id=2329411#c6, which I would need in turn to use neli in https://github.com/AsahiLinux/muvm/pull/111.
I tested @duMagnus' changes and they work for me. Is there any other way I can help with this?

Would you rather get this out sooner rather than later and I can work on addressing the bugs in the background?

Looking at the current tickets, for my (muvm's) usage, I'd say yes, that's my preference, as we wouldn't be affected by those bugs, and otherwise we can't use neli at all.

Okay sounds good! I'll try to prioritize code review of this and putting out a new release candidate.

Thanks a lot! For this, and for the great crate itself, of course. I wrote a small DHCP client with it in a couple of hours, tops.

Hi @jbaublitz, this is currently blocking my packaging request for Fedora, https://bugzilla.redhat.com/show_bug.cgi?id=2329411#c6, which I would need in turn to use neli in AsahiLinux/muvm#111.

Note that I didn't intend to block the package review on this (and explicitly didn't say so), but if possible, new packages should not pull in old syn v1. :) Reading this thread, it looks like porting from v1 to v2 is not trivial here (unlike most derive-macro crates I've looked at before), so I don't think using syn v1 should prevent this from being packaged for Fedora.

Hi @jbaublitz, this is currently blocking my packaging request for Fedora, https://bugzilla.redhat.com/show_bug.cgi?id=2329411#c6, which I would need in turn to use neli in AsahiLinux/muvm#111.

Note that I didn't intend to block the package review on this (and explicitly didn't say so)

Oops, my bad, I misinterpreted that. On the other hand it looks like @jbaublitz is kind of close to completing this one...

Hi @jbaublitz, this is currently blocking my packaging request for Fedora, https://bugzilla.redhat.com/show_bug.cgi?id=2329411#c6, which I would need in turn to use neli in AsahiLinux/muvm#111.

Note that I didn't intend to block the package review on this (and explicitly didn't say so)

Oops, my bad, I misinterpreted that. On the other hand it looks like @jbaublitz is kind of close to completing this one...

Since I haven't heard from the author due to my original delay, I'll pick this up tomorrow.

Since I haven't heard from the author due to my original delay, I'll pick this up tomorrow.

Let me chime in from the sidelines :) Eduardo did the porting from syn v1 to v2 during his internship at Intra2net. He has since returned to university. So far the port works fine, we put it into production a few months ago and didn't encounter any problems.
So feel free to make any changes you like and thanks for maintaining neli.

Okay sounds good! I'll try to push my changes soon and get this out.


com.google.cloud.tools.eclipse.appengine.localserver.server.CloudSdkServerStartupChecker should use Job instead of Thread

In com.google.cloud.tools.eclipse.appengine.localserver.server.CloudSdkServerStartupChecker a thread is used to ping the server to see if it has started yet. Instead of a thread, we should use a Job that can reschedule itself if necessary to wait longer for the server startup.

custom runtime is gone


Add saslStart stub

Description
Closes #1593.
We cannot enable authorization to run both FerretDB and MongoDB with PLAIN authorization mechanism because it is not available for MongoDB. Implemented stub was tested locally with FerretDB.
To test it locally you need:

checkout into this branch;
execute bin/task run
execute in another terminal docker compose exec mongodb mongosh 'mongodb://username:password@host.docker.internal:27018/test?tls=true&tlsCAFile=/etc/certs/rootCA.pem&heartbeatFrequencyMS=300000&authMechanism=PLAIN'

In the FerretDB output check for the saslStart string. FerretDB will respond with ok, MongoDB will respond with MechanismUnavailable error.

Readiness checklist

[ ] I added tests for new functionality or bugfixes.
[x] I ran task all, and it passed.
[x] I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
[ ] I checked comments rendering with task godocs.
[x] I ensured that the title is good enough for the changelog.
[x] (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
[x] I marked all done items in this checklist.

Implemented stub was tested locally with FerretDB.

Please describe how it can be tested by reviewers

Added to the PR description.

I think it is available but you still have to enable SCRAM-SHA-1 because the server doesn't store the passwords in plain text. I was able to verify this myself.
The server parameters need to be --setParameter authenticationMechanisms=PLAIN,SCRAM-SHA-1 --auth. And the instance needs to be restarted after enabling auth.
Client connection:
"msg":"Authentication succeeded","attr":{"mechanism":"PLAIN" . . .

We cannot enable authorization to run both FerretDB and MongoDB with PLAIN authorization mechanism because it is not available for MongoDB.

I think it is available but you still have to enable SCRAM-SHA-1 because the server doesn't store the passwords in plain text. I was able to verify this myself.
The server parameters need to be --setParameter authenticationMechanisms=PLAIN,SCRAM-SHA-1 --auth. If you enable auth via a adminCommand then the instance needs to be restarted I believe.
Client connection log:
"msg":"Authentication succeeded","attr":{"mechanism":"PLAIN" . . .

Yeah, it's working with those mechanisms enabled, combined with that checkMongoDBURI function @AlekSi added.

I got some weird test errors now that I need to check.

I don't think 2cfa8186dd23e52853f479c4b7de75be4cceda43 does anything.
$ env GOFLAGS='-v -run=TestCommandsFreeMonitoringSetFreeMonitoring' task test-integration-mongodb

task: [test-integration-mongodb] go test -count=1 -race=true -tags=ferretdb_tigris -shuffle=on
-coverpkg=../... -coverprofile=integration-mongodb.txt . -records-dir=../records -target-port=37017
-target-tls -compat-port=0

-test.shuffle<PHONE_NUMBER>344326000
=== RUN   TestCommandsFreeMonitoringSetFreeMonitoring
=== PAUSE TestCommandsFreeMonitoringSetFreeMonitoring
=== CONT  TestCommandsFreeMonitoringSetFreeMonitoring
2022-12-20T10:08:52.345+0400	INFO	setup/common.go:312	Target system: port 37017.
2022-12-20T10:08:52.345+0400	INFO	setup/common.go:316	Compat system: none, compatibility tests will be skipped.
2022-12-20T10:08:52.346+0400	INFO	debug	debug/debug.go:61	Starting debug server on http://<IP_ADDRESS>:64592/
    commands_freemonitoring_test.go:55: checkMongoDBURI: mongodb://username:password@<IP_ADDRESS>:37017/?authMechanism=PLAIN&tls=true&tlsCAFile=..%2Fbuild%2Fcerts%2FrootCA.pem:
        connection() error occurred during connection handshake:
        auth error: unable to authenticate using mechanism "PLAIN":
        (MechanismUnavailable) Unsupported mechanism 'PLAIN' on authentication database '$external'
    commands_freemonitoring_test.go:55: checkMongoDBURI: mongodb://username:password@<IP_ADDRESS>:37017/?tls=true&tlsCAFile=..%2Fbuild%2Fcerts%2FrootCA.pem: connected

So tests work due to trying both authMechanisms, not due to enabling PLAIN in the configuration file.
@b1ron Please check. We might miss something.

I added an option for specifying the authentication database here.
"ctx":"conn3","msg":"Authentication succeeded","attr":{"mechanism":"PLAIN","speculative":false,"principalName":"username","authenticationDatabase":"admin","remote":"<IP_ADDRESS>:48994","extraInfo":{}

The root cause seems to be behavior in the driver, that's what made my testing confusing. It seems to always connect to an $external database for PLAIN in the driver.
See https://jira.mongodb.org/browse/TOOLS-2358.

<EMAIL_ADDRESS>David Golden added a comment - Sep 04 2019 03:22:28 AM GMT+0000 Got it.  The Go driver is stricter about interpreting auth parameters as a request to authenticate.  We could restore the legacy behavior on the tools side, but I'm not sure if this is essential, as saying "PLAIN" seems like a request to auth and should be an error if no username is provided.  seth.payne, what do you think?

This short explanation for this failure is that authenticated queries seem to return a different error. They return the InvalidNamespace error.
The count command will return an InvalidNamespace error regardless, see https://jira.mongodb.org/browse/SERVER-23136.

This short explanation for this failure is that authenticated queries seem to return a different error. They return the InvalidNamespace error.

But why?

But why? And why not all authenticated queries, but only a few of them?

My initial hypothesis was that it is used to enforce access control on views as views require possibly more than one namespace.
However, it could just be a simple way to check if an authenticated client connection has authorization for read-only commands. All read-only commands call this which returns the error we're seeing.

This short explanation for this failure is that authenticated queries seem to return a different error. They return the InvalidNamespace error.

But why? And why not all authenticated queries, but only a few of them?

That check for isAuthorizedToParseNamespaceElement would be executed only for count, distinct, listIndexes and find.
It seems that the error returned only when some bad value was provided for the collection name. We have that test only for find. Added one for count. distinct, and listIndexes are not implemented yet.


Tweaks: Ultimate Performance Profile - Add Use Profile

Currently you have only 2 options regarding Performance Plans:

[x] Add Ultimate Performance Profile
[x] Remove Ultimate Performance Profile

My suggestion is to add a third option:

[ ] Use Ultimate Performance Profile

Or a better solution would be to apply the Ultimate Performance Profile after adding it.
Edit: Could be also nice if that Ultimate Performance Profile could include powercfg /change /monitor-timeout-ac 0 which won't turn off the screen after 15minutes

Fixed in latest commit db1acb0


preconfigureCallback: Allow Env Vars for Credentials Validation

In order to ensure that the user doesn't need to add anything to
state to skip a credentials validation or to skip the metadata api
check, we now allow a user to set the value via environment variables.
The order of operations is that we check for provider configuration
first and if we can't find it, we check for the environment variable
Therefore, a person who wants to skip the credentials validation can
now set:
AWS_SKIP_CREDENTIALS_VALIDATION=true when running pulumi up

@viveklak this pr opens a fix for https://github.com/pulumi/pulumi-kubernetes-operator/issues/291


Add metadata to savegame: Date Created, FileSize, Entiy Count...

also add ability to save in memory


fix ui/popupbase.js

Ignore deactivate events from partner elements in IE.

https://bozuman.cybozu.com/k/#/space/3709/thread/32176/2190298

Internal issue http://b/146525538 created


Expose 'add' in git extension API

This PR fixes #124066

Closing this PR in favour of f0f5baffb914af0046d6376b01a72990876d7bcf


Psalm not working with Laravel Aliases  for Facades

> ./vendor/bin/psalm --show-info=false
Scanning files...

   Psalm\Exception\ConfigException

  Failed to load plugin Psalm\LaravelPlugin\Plugin

  at vendor/vimeo/psalm/src/Psalm/Config.php:1216
    1212|                  */
    1213|                 $plugin_object = new $plugin_class_name;
    1214|                 $plugin_object($socket, $plugin_config);
    1215|             } catch (\Throwable $e) {
  > 1216|                 throw new ConfigException('Failed to load plugin ' . $plugin_class_name, 0, $e);
    1217|             }
    1218|
    1219|             $project_analyzer->progress->debug('Loaded plugin ' . $plugin_class_name . ' successfully' . PHP_EOL);
    1220|         }

I'm using these packages:
"php": "7.3.*"
"laravel/framework": "^7.24"
"psalm/plugin-laravel": "1.4.0"
"vimeo/psalm": "3.16"

Hi @pvsaintpe
Could you please share a way to reproduce this? Aliases are working in the unit tests, so would love to see what is breaking this

Sorry to interject, but I've got similar issue. Here's the step to reproduce:
composer create-project --prefer-dist laravel/laravel blog
cd blog
composer update
composer require --dev vimeo/psalm
./vendor/bin/psalm --init
composer require --dev psalm/plugin-laravel
./vendor/bin/psalm-plugin enable psalm/plugin-laravel
cp /my-project/Api.php app/Api.php
vendor/bin/psalm app/Api.php
...
ERROR: UndefinedClass - app/Api.php:11:3 - Class or interface Log does not exist (see https://psalm.dev/019)
                Log::debug("test");
...

Attached you'll find the said app/Api.php
[Api.txt](https://github.com/psalm/psalm-plugin-laravel/files/5517329/Api.txt)

I'm going  to close this until I can get more information


Adding <-loopback> to the exceptions list

With this change, IE and Edge will route the traffic through the proxy. For Chrome, this setting was not needed as it worked without it.

Hi @PeterJausovec, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (peterj). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


is_to_stringable is ignored for base classes

Hello!
For one of my projets, I'm using an external library. The problem is that this library defines a templated to_string function. In that case, sol3 tries to automagically add a to_string meta function for every class. This behaviour can be deactivated by using sol::is_to_stringable. However, when I add the base classes of a class, sol3 ignores the is_to_stringable overrides.
Here is a short example:
#include <sstream>
#include <sol/sol.hpp>

class A {
};

class B : public A {
};

template<typename T>
std::string to_string(T value) {
	std::ostringstream oss;
	oss << value;
	return oss.str();
}

namespace sol {
	template<>
	struct is_to_stringable<A> : std::false_type {};

	template<>
	struct is_to_stringable<B> : std::false_type {};
}

int main() {
	sol::state lua;
	lua.open_libraries(sol::lib::base);

	lua.new_usertype<A>("A"	);

	lua.new_usertype<B>("B",
		sol::base_classes, sol::bases<A>()
	);
}

I compile this main.cpp file with:
g++ -std=c++17 -I/path/to/sol/single/include -I/usr/include/lua5.3 -L/usr/lib/x86_64-linux-gnu -llua5.3 main.cpp

I join the full error message. It basically says g++ can not find an appropriate operator<< for A. When the line with sol::bases is removed, the program compiles.
Is there something I'm missing or doing wrong?
Technical details:

OS: Debian Bullseye
Sol version: 3.0.3
Compiler: g++ 9.2.1 (the bug also happens with clang++ 8.0.1)

If you just deleted your entirely unconstrained, ADL-infecting free function to_string and instead relied on what sol2 did, your code would have just worked out of the box...

As I said, I use a library I have no control over. The example is, well, just an example of what's going wrong.

At least put it in a goddamn namespace.... FFS.

In the library, the function is in a namespace...

Still, I patched out this specific case. I'm sure it'll come up again. And again. And again....

Thanks and sorry that this issue made you so angry.

Don't worry. I totally understand how a recurring bug can be frustrating.


Create a user authentication demo in Ruby on Rails framework

Need to create a small user authentication demo using LoginRadius solution, Check our Demo Guidelines for how to make the authentication demo and Contributing Guidelines to know about the contribution flow.
Language - Ruby (latest stable  version)
Framework - Rails (latest stable version)
Code Folder - https://github.com/LoginRadius/developer-authentication-demos/tree/master/demos/ruby/rails

Hey @puneetsingh24 could you please assign this one to me? I'd like to take this one :)
Thanks!

@lucasqueiroz Sure. Also do check out our hacktoberfest page to become eligible for swags from LoginRadius.

Hey @pareek-narendra , sorry I haven't had much time since then to start on the project. If you can please unassign it to me so someone else can claim it :) Thanks


Trailing Blank Pages [iOS WKWebView using readium-shared-js library]

Whenever going from page to page and approaching the end of a chapter in a subset of ePubs, the chapter will display extra blank pages.  These blank pages will increase in numbers as the chapters progressed within a book (i.e.:  Chapter 2 would have 5 blank pages, Chapter 3 would have 7 blank pages, Chapter 4 would have 12 blank pages, etc., etc.)
This is noticeable on ePubs which would have a structure above the chapter level (i.e.:  Part 1, Part 2)
This issue is a Bug
Related issue(s) and/or pull request(s)
Expected Behaviour
No blank pages at the end of a chapter.
Observed behaviour
Readium shows blank pages in WKWebView under iOS 10.x and iOS 11.x
Steps to reproduce

Load book into WKWebView using the Readium shared JS libraries (readium-shared-js)
Move through the ePub from page to page until approaching end of the chapter.
Blank pages will appear right after the actual last page for the chapter (number of blank pages will vary)

Test file(s)
Please, contact<EMAIL_ADDRESS>for ePub to use.
Product

readium-shared-js library on iOS.

Additional information

Hello,
are you using the iOS ReadiumSDK "launcher app"? ( https://github.com/readium/SDKLauncher-iOS )
Are you able to reproduce this bug in the cloud reader? ( https://readium.firebaseapp.com ) You can drag+drop your EPUB file into the browser window, as long as the file isn't too large (as it will be entirely loaded in memory).

Hi!
We are not using the iOS ReadiumSDK "launcher app." We are currently using the Readium library "readium-shared-js" for iOS.
The ePub is much too large to be used on the Cloud reader which you have suggested; however, if you would like to take a look at the ePub, we will be more than willing to share the ePub as well as our iOS code for you to look at it via Box.

@milonghetto  Can you give us an idea of how you are deploying your Reader?  Not sure it is critical, but any additional information may be useful.
I also sent an email to jtablada.


Refactor metrics API to prepare for additional metrics

[x] Move Metrics to new package
[x] Add thresholding strategies to allow usage of threshold-based metrics (PRECISION, RANGE_RECALL, ...)
[x] Improve Metrics documentation
[ ] Add standard classification metrics

This is a preparation to add additional metrics to TimeEval, e.g. #26, #30

Codecov Report

Merging #31 (3d24c5f) into main (052ddb4) will decrease coverage by 0.35%.
The diff coverage is 90.99%.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   89.75%   89.40%   -0.36%
==========================================
  Files          56       55       -1
  Lines        2744     2746       +2
==========================================
- Hits         2463     2455       -8
- Misses        281      291      +10

Flag
Coverage Δ

unittests
89.40% <90.99%> (-0.36%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

timeeval/metrics/auc_metrics.py
82.92% <82.92%> (ø)

timeeval/metrics/thresholding.py
84.52% <84.52%> (ø)

timeeval/metrics/metric.py
94.00% <94.00%> (ø)

timeeval/metrics/range_metrics.py
95.65% <95.65%> (ø)

timeeval/metrics/other_metrics.py
97.56% <97.56%> (ø)

timeeval/core/experiments.py
99.37% <100.00%> (-0.01%)
:arrow_down:

timeeval/timeeval.py
97.20% <100.00%> (ø)

timeeval/adapters/docker.py
77.41% <0.00%> (-0.15%)
:arrow_down:

timeeval/datasets/dataset.py
96.66% <0.00%> (-0.11%)
:arrow_down:

timeeval/datasets/metadata.py
95.90% <0.00%> (-0.10%)
:arrow_down:

... and 10 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


pkg/trace/api: revert change in #3214

This change reverts the PR #3214 due to an error in the benchmark.

I'm going to add the benchmark back in a better form in a subsequent PR.

@AlexJF the benchmark's copy of the agent's loop here didn't match the fact that I've copied the normalization logic into the actual loop here.
That was a nasty way of me to write a benchmark anyway, and there should be no copying of logic involved. I will try to add the benchmark back in a better form.


[PhpUnit90] Return null on no change on ExplicitPhpErrorApiRector

The applied change return null already in line 98 under loop
https://github.com/rectorphp/rector-phpunit/blob/3b48901693f0d960790af65f73b36b36436badd0/rules/PHPUnit90/Rector/MethodCall/ExplicitPhpErrorApiRector.php#L95-L98

see why it should return null, it show on the list even no change based on requirement
https://getrector.com/demo/26ffe9ca-8ee4-4f0a-a107-774128315061

PHPStan notice seems unrelated as it happen on main branch as well
https://github.com/rectorphp/rector-phpunit/actions/runs/5902201371/job/16009773664#step:5:19

Looks good, let's merge it :+1:
I'll finish up the fix on main soon so we'll be green :)


Running tiller in namespace other than kube-system

The kubernetes cluster we are using has special authorization built in that restricts access to the kubernetes API to another namespace. I was able to manually deploy tiller by generating a manifest and changing the namespace, but now when I run helm commands it says it cannot find tiller. Is there a way to configure the namespace when doing helm init?

In Helm 2.2.0, see the --tiller-namespace flag and $TILLER_NAMESPACE environment variable.

:100: thanks!


Inconsistent page layout in docs

@raytalks has highlighted that the two different layouts for components docs pages can cause confusion, and it's frustrating to have to dig into the React tab to find the component's status labels (maturity and a11y review status)

Unified page Page with tabs

Speaking to @rezrah, highlighting the component labels outside the tabbed area (matching the unified page) would be inappropriate because they refer specifically to the React implementation. In the future each component will also have a Figma tab (matching Primer), so removing the tabbed style and unifying each page is not the solution.
Ideally every component will move towards the tabbed view, where the Overview page covers interface guidelines. This needs to be done in collaboration with Primer Design. I will discuss with them how we can prioritise this work.
Adding interface guidelines to every component would resolve the issue with inconsistent layouts but would bury the component status information deeper within the site, reducing the visibility of this info. I propose we create a component status page (like in primer.style) to highlight the status of each component and its a11y review status.
We could also add a column for whether interface guidelines have been written (and possibly Figma docs?) so we have a clear overview of work that needs to be done for a more mature system, although I appreciate that's not relevant to the implementation so may not be appropriate to include here.
Minor inconsistencies

[x] The source and Storybook links being right-aligned in the React tab and left-aligned in the unified view is frustrating. I considered whether we could left-align them in the tab view, but on primer.style the only links in that label bar are in the figma tabs and they're right-aligned, so I wouldn't want to contradict that pattern.
[ ] On AnchorNav and SubdomainNavBar pages the content is wider than elsewhere, I'll see if a little CSS tweak can fix this.
https://github.com/primer/doctocat/pull/739

@emilybrick I hear you're the person to chat about primer.style with! How do you feel about us copying your component status page for Primer Brand? I'm unsure whether it's worth trying to package up the components/styles you use for the status table or whether I can just copy them to this repo, I guess that depends on what your longterm plans are for docs infra. Perhaps we could have a call to check I'm going in the right direction with this docs work?

Hey @pouretrebelle!
Love this issue and so happy to see this work happening.
Component page tabs
Some quick backstory - we are planning to update our component pages on primer.style.

The "default" (first) tab will include the code examples. Code is the default. Since we no longer need to include Rails in the docs, the default tab will be the PRC components. The name of the default tab is TBD, but it might just become overview.

The secondary tab would be guidelines, and this would include interface guidelines

Third tab would be Accessibility guidelines

I don't have a mock handy, but essentially:
Overview (code examples, brief description) | Guidelines (interface guidelines) | Accessibility  (a11y guidelines)

Component status table
Unfortunately, @dipree and I were thinking of removing the component status table, since we don't think folks are getting a ton of use out of this (or rather, the level of granularity is lost on folks. they just want to know if they can use the component or not).
We need to do more research, but the idea was to instead lean on highlighting the status on the individual component pages. Publicly, on the component pages, it should be Draft or Ready only. Internal states for quality tracking purposes is fine
Happy to chat anytime since there are a lot of moving pieces right now, but also curious if @dipree wants to chime in.
Was there a specific need to showcase the status table on primer.style/brand?

Speaking to Emily earlier this week we've agreed on the path forward - updating the tabs as suggested in her comment, and not pursuing a component status table, but possibly creating some internal reporting to raise visibility of component statuses. Technically this poses some issues though.
Current technical setup for tabbed view

There is an MDX file each for the existing index (guidelines) and react tabs
They each render a custom layout component which conditionally renders the status, table of contents, and includes a hard-coded tabbed nav (using current page location to determine the active tab)
Title and description have to be duplicated in the frontmatter of each MDX file

The drawbacks of this are the content duplication, and having no flexibility of tabs - adding a third tab with this setup would be impossible without a lot more hard-coding and code+content duplication.
Proposed solution
Use a single MDX file for each component, using H1s to define tabs. A custom Gatsby plugin and custom layout component will turn the content into tabs within the page.
Advantages:

No duplication of frontmatter
Easy to define additional tabs as needed
Leveraging Gatsby's in-built table of contents data to build tabs and ToCs
No custom components in the MDX to make the layout changes possible, making this content more portable to whatever system we use next
Remove the directory hierarchy between component pages with guidelines and those without (e.g. Bento.mdx and Avatar/index.mdx, removing the two levels of directories will make it easier to scan components)

Cons:

Each tab won't have its own url, but we can use hash links to link directly to tabs (since we'd be changing the /react path anyway this isn't a huge loss)

We'd want the hash links for H2s to still work as expected, so it'll be a bit of work to e.g. jump to the guidelines tab if you load at #usage

Need to write some custom Gatsby middleware to parse the page contents and wrap each section in a tab panel. I've done similar things before so it's definitely possible, but may be a bit messy
Introducing H1s causes heading hierarchy headaches, because for good a11y each heading should be downgraded a level, but I don't want to mess with their appearance. I think for the MVP I'll leave it with multiple H1s and come back to this later.

I'm going to work on a spike to check the viability of this solution, but I feel reasonably confident it's the right direction to go in given no viable alternatives. This is a fair bit of work for what would seem like a simple layout switch, but will leave us with a flexible system so a11y guidelines can be slotted in easily, and it could be a testbed for primer.style interface developments until we do away with Gatsby.
Thoughts/opinions welcome! @raytalks @emilybrick @dipree @rezrah

@pouretrebelle thanks for this! I'd like us to invest time in working together with Primer Engineering to focus on Nextocat rather than fixing Gatsby.
I'm in conversation with @joelhawksley to plan for this work.
In the mean time I'd recommend to focus on low hanging fruit within our Primer Brand documentation and Story book.

Closing this out as we're not prioritising any significant Gatsby changes since Nextocat is ramping up in priority.
https://github.com/primer/doctocat/pull/739 will be completed though as it's a layout bug rather than UX change.


Enable CodeCov

@jcoupey, I'd like to set up code coverage for the pyvroom project on codecov.io.
Do you mind going in there and enable coverage for pyvroom?
In addition, I'd also appriciated if you placed the generate token in repo's secrets under the name CODECOV_TOKEN. It is not a hard requirement for public repos, but I've had some trouble without it in the past.
That might be all I need, but its been a while since I set it up, and it is a first for me with something where C++ code is involved. So we'll see where this goes.

I've registered on codecov and added the CODECOV_TOKEN secret for this repo. It should activate automatically once you upload a report. Let me know if anything else is needed on my side.

It works now, thank you.

I've tried it out a little bit and the results are flaky. Many commits do not process.
Looks like some recommed installing the codecov github app. Do you mind giving that a try, @jcoupey?

I just followed the steps from the notification I got after your request. It should be installed for the pyvroom repo, let me know if more actions are required on my side.

Excellent. Now it looks like it behaves as it should. :)


[Designer] Bug 33490110: [Food Order.json]: Keyboard tab focus is not shifted to newly opened dialog after activating “Steak" button on 'FoodOrder.json' card.

Problem Description
Bug 33490110: [Food Order.json]: Keyboard tab focus is not shifted to newly opened dialog after activating “Steak" button on 'FoodOrder.json' card.
Test Environment:
Application: Adaptive Cards
OS version: Dev (OS Build 21387.1)
Application Version: 2.7.2105.11001
Repro steps:

Launch the Adaptive Card application.

Adaptive Card UWP Visualizer screen starts appearing.

Navigate to FoodOrder.Json button by using Tab key and activate it.

FoodOrder adaptive card will be appeared on right sight of the pane.

Navigate to FoodOrder card by using Tab key.

Navigate to "Steak" button and activate it.

Observe the keyboard issue.

Actual Result:
Keyboard tab focus is not shifted to newly opened dialog after pressing “Steak" button.
Expected Result:
Keyboard tab focus should be shifted to the next interactive element i.e., "Rare" radio button present under newly opened dialog after pressing “Steak"  button.
User Experience:
Keyboard Users might get affected as keyboard focus is moving to the next button "Chicken" when “Steak" button is selected. Due to this behavior, user are getting impacted as they have to press more tabs to reach back the newly opened dialog.
Note:
Same issue is also repro with "Steak", "Chiken" and "Tofu buttons on Food order with Validation card.
Same issue is also repro with "Chicken" and "Tofu" buttons on 'FoodOrder.json' card.
Card JSON
Designer Bug. Repro on UWP Adaptive Card visualizer

Screenshot
No response

Hi @anna-dingler,
Could you please provide us update on this issue? As issue is still repro and after activating the steak control focus should be land on the activated control.


[stable/grafana] Add sidecar options for env and useCurrentNamespace

Adding values for configuring the sidecar with additional envs or use the current namespace of the pods for configmap lookups.
Related to: https://github.com/kiwigrid/k8s-sidecar/issues/2

CLA signed

It would be good to downgrade the ClusterRole and ClusterRoleBinding to a Role and RoleBinding when using this feature, as the sidecar shouldn't need to be able to read ConfigMaps across the entire cluster.

The sidecar would not be able to get ConfigMaps from the Kubernetes API without a permitting RoleBinding or ClusterRoleBinding.
If it's working, you may have some leftover object from a previous installation.
It's also common misadvice to bind very permissive roles to the default ServiceAccount.
If you've modified the default SA in the namespace you're testing in, this may be where your API permissions are coming from.

@stealthybox
thanks for clarification but i'm not that familiar with the rbac concept.
i hope my changes are going into the correct way to fit your needs ;)

@stealthybox okay i've adapted my PR

/lgtm
@mattfarina would you mark this as /ok-to-test ?
I'm not in the Helm org since we moved things over.

/assign @linki
got a sec for this one @linki ? :)

@eloo thanks for the effort!
The k8s-sidecar now supports lookup in the current namespace "natively", and AFAIK, there is no need to make the chart more complex by adding RBAC and ClusterRole resources because the pod no longer needs them to get the namespace information.
Take a look at #7702. IMHO, I think this PR should perhaps drop that part of the changes. However, the additonal envs feature can still go as part of this PR 👍

@giacomoguiulfo okay so i will close this PR

@stealthybox You are correct, my bad 😞. We should have this changes in, (ping @eloo). Perhaps, the only modification will be the use of useCurrentNamespace, depending on what do you guys think is the most appropiate way for configuring that (either letting the sidecar figure it out by not passing an env variable or by setting NAMESPACE to fieldPath: metadata.namespace).
However, for the case of using the current namespace, the RBAC resources can still be optional since the default ServiceAccount is enough for the task. This doesn't affect the changes though.

We should explicitly define the Role.
We shouldn't rely on a namespace's configured default SA, as it's managed outside the chart.
(It may be modified by a user/operator or another chart)
The Role for the current namespace use-case would also be more specific than most default SA's.
( can only read configmaps )

@stealthybox so whats the plan?

@eloo I think your patch is good and can be merged right now. (cc @davidkarlsen)
#7702 needs some edits and could benefit from your work.

@eloo see instructions for signing off on your commits: https://github.com/helm/charts/pull/7060/checks?check_run_id=18506998

something went wrong with the signoff step.. i will reopen this PR


feat: suggest new interfaces

So my main idea is to make usage of async pipe optional, making it possible to completely not use rxjs when it is not really needed

Thank you very much for sharing your idea!
It sounds interesting. But I think a lot about the principle of Occam‘s razor. The additional functionality in API can increase the complexity of understanding the idea. For me, as a developer, the simpler and shorter the API for solving the current problem, the more convenient.
Also, I think that increasing complexity in html (stored | stored) is not the best benefit. For example, I prefer the approach when templates for the components are 'stupid' as possible, ideally, with no logic in it at all. But with this combination of pipes, it seems that template starts to know more than it can in a more simple way.
Can you explain, please, why do you think it is a good idea to refuse RxJS? It is really a necessary attribute of development for angular, isn't it? The suggested solution under the hood still uses AsyncPipe and RxJS.
Despite I do not sure that pipe really would be better I appreciate your idea to keep working on API’s convenience. I continue to think about how we can improve it.

Regards simplicity i am 100% agree and my thought we could deprecate old way since there is a helper observeStore.
stored | stored is not a good example, in most cases you just want the value, so it supposed to be used once for single store. Therefore, it is still possible if rxjs is not an option for you. Also, if there will be some thing as computedMap in the future in nanostores itself it will just work.

why do you think it is a good idea to refuse RxJS
That is not refusing but making it possible not to use it in simple cases. While you're using rxjs that increases mental complexity.

Aslo, at first, my solution was not using rxjs underhood, but i realised the pupe is almost a duplicate of built-in async.
Since you already agreed that pipe is a good idea, the question is if observeStore is better that service-way.
Obviously, you should not inject anything.
Also, current implementations of useStore has a memory leak, and not good DX (because you need to provide the token, otherwise you'll get one more memory leak there). The only advantage is in case you still proved the token in the component and after fixing the memory leak you probably could finally omit untilDestroyed operator but only in some cases (I mean if you switch on other observable that is infinite). These cases are hard to catch on code-review and hard to maintain.
Common way of destroying observables is use untilDestroyed just before you called a subscribe. That is easy to maintain and check on codereview. Also, all other rxjs libraries going same way: the user should be the one who destroies observables.

Since you already agreed that pipe is a good idea, the question is if observeStore is better that service-way.

Well, I agreed that it is an interesting idea, but I didn't agree that the new pipe, in this case, would be better than one standard approach — my point about simplicity was that we don't need two different approaches in API (like new pipe and observeStore) for the same purposes if we can go with just single thing.

Also, current implementations of useStore has a memory leak, and not good DX (because you need to provide the token, otherwise you'll get one more memory leak there).

I checked the implementation of useStore on the subject of memory leaks, and they wouldn't occur if you apply a common and recommended practice when you unsubscribe in ngOnDestroy() in your component.
You can check it easily: create two components with useStore in initialization, log the content of nanostoresService each second, and then destroy one of the components with unsubscription. You would see that length of the observables' array reduce from two to one, that's because we don't use the destroyed one anywhere and we do not store it anymore. So there is no memory leak.

The only advantage is in case you still proved the token in the component

Because of what I described above, you need to inject the token only one time in AppModule. It's a common one-line approach with most part of the Angular services.

Sorry, just misclicked when I wanted to comment :)

Since you already agreed that pipe is a good idea, the question is if observeStore is better that service-way.

Well, I agreed that it is an interesting idea, but I didn't agree that the new pipe, in this case, would be better than one standard approach — my point about simplicity was that we don't need two different approaches (like pipe and observeStore) for the same purposes if we can go with the just single one.

Also, current implementations of useStore has a memory leak, and not good DX (because you need to provide the token, otherwise you'll get one more memory leak there).

I checked the implementation of useStore on the subject of memory leaks, and they wouldn't occur if you apply a common and recommended practice when you unsubscribe in ngOnDestroy() in your component.
You can check it easily: create two components with useStore, log the content of nanostoresService each second, for example, and then destroy one of the components with unsubscription. You would see that length of the observables' array reduce from two to one, that's because we don't use the destroyed one anywhere and we do not store it anymore. So there is no memory leak.

The only advantage is in case you still proved the token in the component

Because of what I described above, you need to inject the token only one time in AppModule. It's a common one-line approach with most part of the Angular services.

About the pipe:
I think you've missed the point that rxjs is not always necessary, especially when you have computed function in nanostores itself.
If we would have an alternative pipe for simple cases it will cost us nothing but in ppl minds would be easy to think of it as store. Forcing developers to use rxjs for all the stores is overhead and overengineering, because in most cases you just need to read the value and that's it.
About memory leak:
The main issue is not in the Subject but in the unbind function. If you call useStore twice your unbind function will be overwritten.
The second issue is since service is provided to root or could be actually provided anywhere outside component you still may get memory leak because you have no any errors when you are not following the guideline.

you need to inject the token only one time in AppModule.
You're wrong in your approach, if you will inject your token in the appModule, you will still get the singleton and you ngOnDestroy will be never called.

The main issue is not in the Subject but in the unbind function. If you call useStore twice your unbind function will be overwritten.

Overwriting this function doesn't cause a memory leak, we don't even use it in components.

you still may get memory leak because you have no any errors when you are not following the guideline.

Maybe we just need to follow the common guideline? 🙂

You're wrong in your approach, if you will inject your token in the appModule, you will still get the singleton and you ngOnDestroy will be never called.

It could be rare cases when we need to turn down the service because we don't need it anymore. Then we can replace the provider with another object, for example. And if there would be no unsubscription in the service for function, then it is a possible memory leak.
I think we just have very different points of view on using RxJS and what makes the API's interfaces more convenient. Maybe you publish your own solution as an alternative option? It is an open source, people always can choose which approach is better for them 🙂

Overwriting this function doesn't cause a memory leak, we don't even use it in components.

Of cause it causes! As soon as you subscribe on store changes you create and store one more function. If you don't remove it from the store internals you'll get the memory leak. (because when you create a new component the function get stored in nanostores  and not removed).

It could be rare cases

The thing is the services cares about unsubscriptions but covers not all cases, so developers should every time think if their case is covered. Instead, i suggest developers to just not think and unsubscribe every time.
You may say that they may also do this on current implementation, but while the service is a singleton it still may be used wrong.

Maybe you publish your own solution as an alternative option?

No way people will be choosing unknown publisher instead of official package from the same maintainers. Because it's an opensource i've brought all that here with a think that my arguments are strong enough to change the API.
Since you didn't feel that my API would work better here, I give up.

@ninaTorgunakova FYI last commit fixes one of the possible memory leaks in the service

@infodusha Thank you! I will check it tomorrow 🙂

Also what i've thought is it worth to use observeStore implementation inside service because BehaviourSubject you're creating inside useStore is not completed.

As soon as you subscribe on store changes you create and store one more function.

When function unbind is overwritten when we subscribe to one more store, we don't create and store one more function, it is the single function from singleton, but different than the previous one.
But I agree with you that it is really better to store unbind in useStore function, and I also like the pointing generic type for the function, thanks for the suggestion! Would it be convenient for you to commit your changes in the file nanostores.service.ts from this commit into another PR so we can merge it to main?

Anyway, it supposed to be cleaned but it does not feel good.

Yes, it supposed to be cleaned and it exists only as a constant inside the function, not the service. So when the component will be unsubscribed no memory should be used for the BehaviourSubject.

Going to open another PR tomorrow

So i moved few ideas to the #2 while that thing is going to the history


dns/bind: move to primary/secondary

As per the conversation here: https://github.com/opnsense/plugins/pull/3222#issuecomment-1357428183 this finishes renaming all the master components to primary and slave to secondary.
The changes from PR #3224 are also included since it became really messy if I started renaming the values that are removed there. I will rebase this PR after it is merged.
I've tested the following things to ensure they still work:

Add/Remove/Edit both Primary/Secondary zones
Add/Edit/Remove records on Primary zones
Migrate from old format to new for both Primary and Secondary zones

Looks like some conflicts exist now... Can you address these and chain the function calls for the old controller actions? Also move to 1.26 now I want to release 1.25 in 23.1 first :)

I've tested that this works on my test machine, all the settings seems to have transferred over without any data loss. I did it 4-5 times and each time the migration worked successfully.

Merged, thanks!


HBASE-22364 Fixed remaining Checkstyle issue in hbase-hadoop2-compat

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
222
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
265
master passed

+1
compile
17
master passed

+1
checkstyle
12
master passed

+1
shadedjars
263
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
25
master passed

+1
javadoc
13
master passed

_ Patch Compile Tests _

+1
mvninstall
226
the patch passed

+1
compile
15
the patch passed

+1
javac
15
the patch passed

+1
checkstyle
10
hbase-hadoop2-compat: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
243
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
497
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
34
the patch passed

+1
javadoc
14
the patch passed

_ Other Tests _

+1
unit
33
hbase-hadoop2-compat in the patch passed.

+1
asflicense
12
The patch does not generate ASF License warnings.

1969

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-218/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/218

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 20b3af103a32 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / e884a25f8d

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-218/1/testReport/

Max. process+thread count
288 (vs. ulimit of 10000)

modules
C: hbase-hadoop2-compat U: hbase-hadoop2-compat

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-218/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.


Animate TextPath when usePathValue is used

Description
I have an array of points where each point's x and y value is a SharedValue<number>.
I use the points within usePathValue to create my path. This path is consumed by a <TextPath /> and a <Path />.
When I update the path values from within my GestureDetector, the <Path /> is updated but the <TextPath /> does not seem to handle the updates. Only after updating the text property on <TextPath />, the new path is adapted.
const linePath = usePathValue((path) => {
  "worklet";
  ...
  path.cubicTo(
    points[1].x.value,
    ...
  );
  ...
});

return (
  <Group>
    <TextPath path={linePath} ... />
    <Path path={linePath} ... />
    ...
  </Group>
);

@wcandillon does this help?
The <TextPath /> does not re-render with an updated path from usePathValue, whereas the <Path /> component re-renders as expected.


Multiple scrolls

Hello,
I had to scroll through several containers, but because of the shared global variables like __containerElement  it didn't work. In this PR, I suggest to keep all private fields in the options.data object as a possible solution of the problem.
I'm not sure about cancelEvents thing and would be happy to get feedback at this point.

Thanks for the PR, let me check it out later today.

Tested and working like a charm. Thank you both.

@fisshy Can you merge it, please?

Will check it out today and then hopefully merge it if all tests pass :) @doochik

Published in v1.7.0.


Undefine yet another macro from Windows headers

For some reason, MONO_FONT from Win32 has started conflicting with rich_text_label.h's DefaultFont::MONO_FONT for me.
So I'd like to get rid of the issue.

Someone please go back to 1985 and force MS to use namespaces for all their generic and completely random defines...

Just for information, many projects wrap windows headers to prevent this kind of namespace collision (and increased compile time), so the include <windows.h> is confined to a single cpp file.
Sometimes this is not possible, but 99% of the common defines can be safely redefined locally (FILE is a common example if I remember right, it's a while since I did any windows).

Just for information, many projects wrap windows headers to prevent this kind of namespace collision (and increased compile time), so the include <windows.h> is confined to a single cpp file.

The main difficulty with this approach is that we're not the only users of the code, and folks who have custom forks or C++ modules which consume our API may not have the same discipline. So as far as possible, we need to strive to make our code compile despite too early includes of windows.h.

Thanks!

Cherry-picked for 4.2.2.
Cherry-picked for 4.1.4.


Patch 3

Added support for RTR bits in can packet as well as another tested transceiver.

I downloaded the patch3 when it was commited but i have a problem.
As soon as i start "CANbus1.begin(myMask1);" the program freezes.
Nothing goes on.
Any Idea what it could be?

Hopefully that is it.
Make sure you download the current one on my list as I made some changes earlier today.


[WIP] bootstrapper: Support NugetSource app-setting key

Options like PreferNuget, ForceNuget and NugetSource often go together (for instance to force a specific internal NuGet server for CI). Added one that I wanted.
Tests are still missing, but is this otherwise OK?

is this ready?

thanks!


No bones displayed when trying to edit

When I open Customize+ and create a new template, no bones are displayed. When I go to older templates, the only bones that are displayed are the bones that were previously edited.

I have noticed that a lot of people been complaining about that. Will do some tests when I finish MSQ.
Right now it seems like the fix for this is to restart your game.

Just wanted to let you know, after restarting my game I still don't see any of the bones.

Hello, i have the same problem listed above is there any fix or reason its happening? i tried restarting and still have the same issue.

I don't have anything to add to this at this point, I have not been able to reproduce this so far.

I don't really have anything to add, only adding my voice to the "I am also having this issue" crowd. Only previously edited bones appear in the list on old templates, new templates have no bones at all. Restarting doesn't fix it. I actually don't know where to find the "reset plugin data and reload" function Enantiomorph mentioned to see if that fixes it for me.

If you guys have nothing to add just don't comment. Those comments do nothing but add clutter.

I can that add I was able to fix it by toggling off Brio and Mare, but weirdly after i enabled them back C+ continued working from then on just fine, so i couldn't narrow it down further. Maybe the issue is related to plugin loading order then?
Also when this was happening it couldn't find any armature in the debug info

This might be fixed in current testing build.


[1.10.2] Connection leak detection

Randomly it spams the console with:
[23:50:00] [luckperms housekeeper/WARN] [me.lucko.luckperms.lib.hikari.pool.ProxyLeakTask]: Connection leak detection triggered for me.lucko.luckperms.lib.mysql.jdbc.JDBC4Connection@5fd73187, stack trace follows
java.lang.Exception: Apparent connection leak detected
        at me.lucko.luckperms.common.storage.methods.MySQLDatastore.getConnection(MySQLDatastore.java:139) ~[MySQLDatastore.class:?]
        at me.lucko.luckperms.common.storage.methods.MySQLDatastore.runQuery(MySQLDatastore.java:114) ~[MySQLDatastore.class:?]
        at me.lucko.luckperms.common.storage.methods.SQLDatastore.runQuery(SQLDatastore.java:97) ~[SQLDatastore.class:?]
        at me.lucko.luckperms.common.storage.methods.SQLDatastore.loadAllGroups(SQLDatastore.java:309) ~[SQLDatastore.class:?]
        at me.lucko.luckperms.common.storage.methods.MySQLDatastore.loadAllGroups(MySQLDatastore.java:36) ~[MySQLDatastore.class:?]
        at me.lucko.luckperms.common.storage.SplitDatastore.loadAllGroups(SplitDatastore.java:106) ~[SplitDatastore.class:?]
        at me.lucko.luckperms.common.runnables.UpdateTask.run(UpdateTask.java:44) ~[UpdateTask.class:?]
        at org.spongepowered.api.scheduler.Task$Builder.lambda$execute$0(Task.java:138) ~[Task$Builder.class:1.10.2-2098-5.1.0-BETA-1814]
        at org.spongepowered.common.scheduler.SchedulerBase.lambda$startTask$0(SchedulerBase.java:177) ~[SchedulerBase.class:1.10.2-2098-5.1.0-BETA-1814]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_91]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_91]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_91]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_91]
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_91]

Running LuckPermsSponge-2.12.20, on a 1.10.2 Sponge server.
SpongeForge version: 1.10.2-2098-5.1.0-BETA-1814
Forge version: 1.10.2-<IP_ADDRESS>7
Another error:
 java.sql.SQLTransientConnectionException: luckperms - Connection is not available, request timed out after 30000ms.
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at me.lucko.luckperms.lib.hikari.pool.HikariPool.createTimeoutException(HikariPool.java:548)
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at me.lucko.luckperms.lib.hikari.pool.HikariPool.getConnection(HikariPool.java:186)
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at me.lucko.luckperms.lib.hikari.pool.HikariPool.getConnection(HikariPool.java:145)
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at me.lucko.luckperms.lib.hikari.HikariDataSource.getConnection(HikariDataSource.java:83)
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at me.lucko.luckperms.common.storage.methods.MySQLDatastore.getConnection(MySQLDatastore.java:139)
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at me.lucko.luckperms.common.storage.methods.MySQLDatastore.runQuery(MySQLDatastore.java:114)
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at me.lucko.luckperms.common.storage.methods.SQLDatastore.runQuery(SQLDatastore.java:97)
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at me.lucko.luckperms.common.storage.methods.SQLDatastore.loadAllTracks(SQLDatastore.java:407)
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at me.lucko.luckperms.common.storage.methods.MySQLDatastore.loadAllTracks(MySQLDatastore.java:36)
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at me.lucko.luckperms.common.storage.SplitDatastore.loadAllTracks(SplitDatastore.java:131)
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at me.lucko.luckperms.common.runnables.UpdateTask.run(UpdateTask.java:51)
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at org.spongepowered.api.scheduler.Task$Builder.lambda$execute$0(Task.java:138)
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at org.spongepowered.common.scheduler.SchedulerBase.lambda$startTask$0(SchedulerBase.java:177)
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[23:51:29] [pool-2-thread-37/INFO] [STDERR]: [me.lucko.luckperms.common.storage.methods.MySQLDatastore:runQuery:125]:   at java.lang.Thread.run(Thread.java:745)

Could you please pastebin your entire latest.log?

fml-server-3.txt

Happened when i tried setup default permissions of Nucleus, using /nucleus setupperms ADMIN admin, this could have overloaded the MySQL connection. You could add a delay and a cache for the permissions requests, or push to the database only in like 1 minute...

Yeah. The logs would suggest that.
[23:59:25] [pool-2-thread-6/INFO] [me.lucko.luckperms.lib.hikari.pool.ProxyLeakTask/luckperms]: Previously reported leaked connection me.lucko.luckperms.lib.mysql.jdbc.JDBC4Connection@53ebefc9 was returned to the pool (unleaked)
[23:59:25] [pool-2-thread-8/INFO] [me.lucko.luckperms.lib.hikari.pool.ProxyLeakTask/luckperms]: Previously reported leaked connection me.lucko.luckperms.lib.mysql.jdbc.JDBC4Connection@4dd787d5 was returned to the pool (unleaked)
[23:59:25] [pool-2-thread-4/INFO] [me.lucko.luckperms.lib.hikari.pool.ProxyLeakTask/luckperms]: Previously reported leaked connection me.lucko.luckperms.lib.mysql.jdbc.JDBC4Connection@5c3b866d was returned to the pool (unleaked)
[23:59:26] [pool-2-thread-9/INFO] [me.lucko.luckperms.lib.hikari.pool.ProxyLeakTask/luckperms]: Previously reported leaked connection me.lucko.luckperms.lib.mysql.jdbc.JDBC4Connection@39a11e78 was returned to the pool (unleaked)
[23:59:26] [pool-2-thread-10/INFO] [me.lucko.luckperms.lib.hikari.pool.ProxyLeakTask/luckperms]: Previously reported leaked connection me.lucko.luckperms.lib.mysql.jdbc.JDBC4Connection@59d28cda was returned to the pool (unleaked)
[23:59:26] [pool-2-thread-12/INFO] [me.lucko.luckperms.lib.hikari.pool.ProxyLeakTask/luckperms]: Previously reported leaked connection me.lucko.luckperms.lib.mysql.jdbc.JDBC4Connection@487b7cf was returned to the pool (unleaked)
[23:59:26] [pool-2-thread-11/INFO] [me.lucko.luckperms.lib.hikari.pool.ProxyLeakTask/luckperms]: Previously reported leaked connection me.lucko.luckperms.lib.mysql.jdbc.JDBC4Connection@2bc1097e was returned to the pool (unleaked)
[23:59:26] [pool-2-thread-17/INFO] [me.lucko.luckperms.lib.hikari.pool.ProxyLeakTask/luckperms]: Previously reported leaked connection me.lucko.luckperms.lib.mysql.jdbc.JDBC4Connection@79b04134 was returned to the pool (unleaked)
[23:59:26] [pool-2-thread-15/INFO] [me.lucko.luckperms.lib.hikari.pool.ProxyLeakTask/luckperms]: Previously reported leaked connection me.lucko.luckperms.lib.mysql.jdbc.JDBC4Connection@5fd73187 was returned to the pool (unleaked)

However, they were returned a good 10 minutes later?? (not good)
I have one other user who is also having similar issues. I cannot work out why the hell it's happening.
Where is your MySQL server located? Same DC as your server, or on the other side of the world? Is it a rubbish(y) shared hosting one, or is it reliable?

Either way, I'll definitely implement your suggestion RE: waiting before saving.
If you're just using commands, there shouldn't be an issue, however I can understand there may be issues when other plugins set things automatically.

I have a dedicated server for my hosting stuff (website, web scripts, MySQL) and a game server for run my minecraft servers and heavy stuff. both dedicated. The Sponge server is running in the game server, and I use the external IP to connect with the MySQL server.
I can reproduce it easily. When I restarted the server, I can use the normal commands, and the stuff is written to the database, but when I use /nucleus setupperms ADMIN admin, the error happes. In that first log, it returned 10 minutes after because that was the time that the server took to create the admin group. Once created and tried setup the perms, It throws the errors instantly.

Can I test that new build?

Okay.
Well, I've cleaned up the #loadAllGroups / #loadAllTracks methods. There could have been some issues there. The logs you sent didn't actually suggest that there was any sort of issue with saving groups, it was the #loadAllGroups method that was mentioned in the stacktrace.
(Although that method does actually get called https://github.com/lucko/LuckPerms/blob/master/sponge/src/main/java/me/lucko/luckperms/sponge/service/LuckPermsSubjectData.java#L62)
Anyway, you've raised some really good points, so thank you for doing so. I'll look into these issues as a matter of priority.
My thoughts are:

Whether by command or through an API, whenever a user/group gets saved, they get put into a queue to be saved in 5 seconds time.
If they're already in the queue, the save time just gets extended to 5 seconds
When the queue time reaches 0, they get saved to the datastore.

That should prevent any issues with automated modifications, etc. :)

I have a really crappy MySQL server which I use to test the plugin on. (my thoughts being if this server can handle it, anything can.)
So I'll try to reproduce the issue on that, using the Nucleus auto setup feature.
Anyway, I'll look into this tomorrow. (it's pretty late here.) Thanks again for your help.

Okay, thank you by your help!

I've made a bit of progress. (I'm probably like 70% done.)
The root cause of the issue is actually much harder to solve than you might think. Hopefully I'll have it done at some point tomorrow. 🙂

Seems stable. Feel free to reopen if you have any problems.

It's working flawlessly now, thanks! Tested in a production server

Excellent! Good to hear. :)


[firebase_messaging 📚] Inconsistency between the documentation and the example

This step: https://firebase.flutter.dev/docs/messaging/usage/#web-tokens under 2. describes that firebase-messaging-sw.js should be created and included into index.html.
The example has nothing like that: https://github.com/FirebaseExtended/flutterfire/blob/master/packages/firebase_messaging/firebase_messaging/example/web/index.html
Is it not required anymore with the latest automatic initialization? or is this an oversight?
Should I open a pull request to fix this or that?

Created the issue accidentally before adding the description, should be correct now.

I think
  <!-- ...other html setup. -->
  <script>
    if ("serviceWorker" in navigator) {
      window.addEventListener("load", function () {
        navigator.serviceWorker.register("/firebase-messaging-sw.js");
      });
    }
  </script>
  <!-- ...put the script at the bottom of the enclosing body tags. -->
</body>

is not required but the web/firebase-messaging-sw.js file is, so the example is correct.
How I came to this conclusion:
I added the script tag from above but changed the path and the filename ("/firebase-messaging-sw.js").
This resulted in the following error:
Error: [firebase_messaging/failed-service-worker-registration] Messaging: We are unable to register the default service worker. Failed to register a ServiceWorker for scope ('http://localhost:57181/firebase-cloud-messaging-push-scope') with script ('http://localhost:57181/firebase-messaging-sw.js'): The script has an unsupported MIME type ('text/html'). .
    at Object.throw_ [as throw] (http://localhost:57181/dart_sdk.js:5063:11)
    at http://localhost:57181/packages/firebase_core/src/internals.dart.lib.js:81:63
    at _RootZone.runUnary (http://localhost:57181/dart_sdk.js:40062:59)
    at _FutureListener.catchError.handleError (http://localhost:57181/dart_sdk.js:34996:33)
    at handleError (http://localhost:57181/dart_sdk.js:35567:51)
    at Function._propagateToListeners (http://localhost:57181/dart_sdk.js:35593:17)
    at _Future.new.[_completeError] (http://localhost:57181/dart_sdk.js:35443:23)
    at async._AsyncCallbackEntry.new.callback (http://localhost:57181/dart_sdk.js:35479:31)
    at Object._microtaskLoop (http://localhost:57181/dart_sdk.js:40330:13)
    at _startMicrotaskLoop (http://localhost:57181/dart_sdk.js:40336:13)
    at http://localhost:57181/dart_sdk.js:35811:9

The error persisted even after removing the script tag.
The error was solved after moving the file to specified path and using the specified name.

@atoka93
Check this issue and see if it helps.

@darshankawar everything is working for me, the issue is about documentation.
In the example project neither this
  <!-- ...other html setup. -->
  <script>
    if ("serviceWorker" in navigator) {
      window.addEventListener("load", function () {
        navigator.serviceWorker.register("/firebase-messaging-sw.js");
      });
    }
  </script>
  <!-- ...put the script at the bottom of the enclosing body tags. -->
</body>

shown here: https://firebase.flutter.dev/docs/messaging/usage/#web-tokens
nor this
  <!-- ...other html setup. -->
  <script>
    if ("serviceWorker" in navigator) {
      window.addEventListener("load", function () {
        navigator.serviceWorker.register("/firebase-messaging-sw.js");
      });
    }
  </script>
  <!-- ...put the script at the bottom of the enclosing body tags. -->
</body>

shown here under the Web tab https://firebase.flutter.dev/docs/messaging/usage/#background-messages
is not included.
Neither in my project and both are working correctly for me.
My question is: is that part actually required?

if yes the example project (and my project) should be updated
if not the documentation should be updated

Does that make sense?

Yes, thanks for the update.

Hey @atoka93, good catch! I've updated the example 👍


fix releases email if no release is available

don't render upcoming or recent releases in email if there is no release available

 ReleasesEmail has problems with one empty list


docs: fix blink.cmp example

Why this change?
When adding blink.cmp completion with codecompanion to my config, I noticed the docs showed an outdated setup example.
What was changed?
I replaced the lua code snippet with a complete example.

Awesome thanks for this. Hard to keep up with Blink's changes at the minute. It's on fire.

@olimorris I know, it's moving really fast, breaking often. I've been waiting for cmdline support, and since that's in now - I'll just refer from updating in a while now, I think. 😅


[Bug] TC_RR_1_1：Failed test due to lack of access to acl.

Describe the bug
Automated Test Case Failure
Steps to reproduce the behavior
No response
Expected behavior
No response
Log files
TC-RR-1-1_2024_08_16_10_51_39.log
PICS file
No response
Screenshots
No response
Environment
TH:v2.10.1+spring2024
matter:v1.3
Additional Information
No response

@ccruzagralopes pls help


Running slidev with pnpm 9 fails

Describe the bug
After creating a new slidev project with pnpm, it fails when opening it with the following error:
Error: Cannot find package 'D:\dev\\test\node_modules\.pnpm\@slidev+cli@0.49.0-beta.4_@babel+parser@7.24.5_@nuxt+kit@3.11.2_rollup<EMAIL_ADDRESS>imported from D:\dev\test\node_modules\.pnpm\@slidev+cli@0.49.0-beta.4_@babel+parser@7.24.5_@nuxt+kit@3.11.2_rollup@4.17.2__<EMAIL_ADDRESS>Did you mean to import "markdown-it-link-attributes/index.js"?
    at legacyMainResolve (node:internal/modules/esm/resolve:215:26)
    at packageResolve (node:internal/modules/esm/resolve:841:14)
    at moduleResolve (node:internal/modules/esm/resolve:927:18)
    at defaultResolve (node:internal/modules/esm/resolve:1157:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:390:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:359:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:234:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:87:39)
    at link (node:internal/modules/esm/module_job:86:36) {
  code: 'ERR_MODULE_NOT_FOUND'

Using npm it works fine.  However with pnpm there seem to be an issue with a dependency and I can't solve it.
To Reproduce
Steps to reproduce the behavior:

Create a new project using pnpm create slidev
Follow the wizard to install dependencies and launch the slides
See the error

Desktop (please complete the following information):

OS: Windows
Browser: Edge
Slidev version: 0.49.0-beta.4
pnpm version: 9.0.6

It seems to be linked to pnpm version 9.0.6. It works fine with pnpm 8.15.7

We've removed markdown-it-link-attributes in the latest version. I tested in v0.49.0-beta.5 and it works fine.


Handling multiple http methods and routes for a single function.

How does flasgger handle multiple http methods in a single route? It seems that there is no way to have two different sets of documentation for view function that has a GET and POST. Also I have view functions that have multiple routes such as /events and events/:id. How can I produce two separate definition objects?

It is possible to have different sets of docs, but it is handled by swagger not flasgger.
the http method have to be checked, did you testes it?

I am working on making this available

@swag_from('filename', methods=['POST'])
@swag_from('another_filename', endpoints=['test'])  # all methods
@swag_from('another_filename', endpoints=['another'], methods=['GET')
@route('/', endpoint='test')
@route('/<test>', endpoint='another')
def view():
    ...


Build fails on node v4.x

Issue
node-gyp fails to build odbc_result.cpp on node v4.x.
Cause
#93 Seems to identify part of the problem, v4.x NAN changes are not supported yet, although there may be other breaking changes.
Expected Behavior
The node engine version should be configured in package.json to prevent npm from trying build and to generate a useful error message.

Added node < 4.0.0 restriction in package.json in v1.1.8 on npm.
Thank you.


refactor repository manager

motivation: apply learning from implementing registry downloads maanger to repository manager
changes:

remove the use of state file, rely on well-known storage path instead
add method to RepositoryProvider to check if a path contains a valid repository
replace use of RepositorySpecifier::fileSystemIdentifier (String)  with RepositorySpecifier::storagePath() -> RelativePath
refactor repository manger delegate to use clearer terminology, and align it with registry downloads manager delegate
update repository manager tests to use more modern testing techniques and improve its concurrency handling
adjust mocking facilities and tests

@swift-ci please smoke test

@swift-ci please smoke test


fix(empty-state): moved basic example

fixes #2469

PatternFly-Next preview: https://patternfly-next-pr-2499.surge.sh

@mcoker updated

:tada: This PR is included in version 2.45.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add disallowedFor to forbid-component-props and allowedFor to forbid-dom-props

My use case is component props: I am using a component system (Antd) and want to disallow the required parameter on Form.Item to avoid confusion with a require parameter in HOCs that we create.
I found #3422 already existing, so this is a PR to solve that, as well as adding allowList to forbid-dom-props for symmetry.
I haven't yet figured out what the best way is to raise configuration issues, right now I'm just throwing an error, let me know if there's a better way!
(Motivation details: in Antd require only controls styling, and doesn't actually validate, in our HOCs I want it to validate, but don't want that confusion to bleed over into using require in the base (non-HOC) Form.Items)

Sigh, okay, so I just realized that this is largely a duplicate of #3416, which I missed because it wasn't tagged on #3422 becuase that issue started as a discussion on #2946.
The discussion on #3416 also states:

In the future, please do not send PRs for changes you're not sure are wanted.

If there is some sort of policy here, it should be stated in CONTRIBUTING.md - there was an existing issue without neither satisfying resolution nor refusal, thus I created a PR.

I'm going to pull your changes into #3417, but i'll drop the forbid-dom-props changes, since that needs to happen in another PR.


cli coap example does not seem to work

make -f examples/Makefile-posix
In one terminal window:
$ ./ot-cli-ftd 1
>
> networkname foobar
Done
> panid 0x3333
Done
> channel 21
Done
> ifconfig up
Done
> thread start
Done
> state
child
Done
> ipaddr
fdde:ad00:beef:0:0:ff:fe00:c01
fdde:ad00:beef:0:2f58:72b1:818a:8ef3
fe80:0:0:0:10af:5b24:f29c:2c79
Done
>
> coap server name Foo
Changing resource name to 'Foo': Done
> coap server start
Server started with resource 'Foo': Done
> Received CoAP request from [fe80:0:0:0:10af:5b24:f29c:2c79]: GET
CoAP response sent successfully!
Received CoAP request from [fe80:0:0:0:10af:5b24:f29c:2c79]: PUT with payload: 48 69 4d 6f 6d
CoAP response sent successfully!
Received CoAP request from [fe80:0:0:0:10af:5b24:f29c:2c79]: GET
CoAP response sent successfully!

In a second terminal window
$ ./ot-cli-ftd 2

>
> networkname foobar
Done
> panid 0x3333
Done
> channel 21
Done
> ifconfig up
Done
> thread start
Done
> state
leader
Done
>
> ipaddr
fdde:ad00:beef:0:0:ff:fe00:fc00
fdde:ad00:beef:0:0:ff:fe00:c00
fdde:ad00:beef:0:44ff:f203:bed5:dd89
fe80:0:0:0:bc4c:f66:3bb4:9c00
Done
>
> coap client get fe80:0:0:0:10af:5b24:f29c:2c79 Foo
Sending CoAP message: Done
> Error receiving CoAP response message: 28

Note: Over the air, using real hardware and a sniffer, I see the CoAP response.
I also tried other variants.
> coap client put fe80:0:0:0:10af:5b24:f29c:2c79 Foo con HiMom
Sending CoAP message: Done
>
> coap client get fe80:0:0:0:10af:5b24:f29c:2c79 Foo con
Sending CoAP message: Done
>
> Error receiving CoAP response message: 28
Error receiving CoAP response message: 28

This contradicts the example in the documentation.
coap client get fdde:ad00:beef:0:dbaa:f1d0:8afb:30dc test
Sending CoAP message: Done
Received CoAP request from [fdde:ad00:beef:0:dbaa:f1d0:8afb:30dc]: GET
CoAP response sent successfully!

Am I missing something?

This was first reported here: https://groups.google.com/forum/#!topic/openthread-users/YHw1DqGynmQ
I'm actively working on a fix for this.


[BugFix] Fix paimon jni reader may explore the hive metastore

Why I'm doing:
What I'm doing:
Fixes #issue
#35750
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[ ] 3.0
[ ] 2.5

Thanks for your contribution.
What problem does this pr mainly solve and can you describe it?

Thanks for your contribution.
What problem does this pr mainly solve and can you describe it?

Thanks for your reply, this pr mainly solve the problem mentioned in following issue: https://github.com/StarRocks/starrocks/issues/35750
We have met the problem in our product env when using starrocks to query a paimon table with thousands of files, and it made our hive metastore down, no more connections to hive metastore can be used by other programs, since all the connections occupied by starrocks.

Thanks for your contribution.
What problem does this pr mainly solve and can you describe it?

Thanks for your reply, this pr mainly solve the problem mentioned in following issue: #35750
We have met the problem in our product env when using starrocks to query a paimon table with thousands of files, and it made our hive metastore down, no more connections to hive metastore can be used by other programs, since all the connections occupied by starrocks.

Good job~

@Mergifyio backport branch-3.2


Binary and template file version does not match

After updating to the latest version, I'm getting the same error as posted here: https://github.com/gogits/gogs/issues/833

Nm, found the gogs upgrade guide: https://futurestud.io/blog/how-to-upgrade-gogs-step-by-step-guide/


Doc update for v1.4.0

Doc updates for v1.4.0 -

Update helm version number to 1.4.0
Update image version to v1.4.0
Add some instructions for NIC upgrade, which specify using the latest helm chart
Add info for NSG, tagging, and delete protection support
Update manifest files

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.407%

Totals

Change from base Build<PHONE_NUMBER>7:
0.0%

Covered Lines:
2700

Relevant Lines:
4128

💛  - Coveralls


[ssh] Add support to "Microsoft.ConnectedVMwarevSphere/virtualMachines" resource type

Refactored how we check the resource type of the target to facilitate adding support for more resource types in the future.
Changed how we check the OS of the target resources to make it optional in the future.
Added connectedvmware sdk
Fixed the supported resource types names. (Extension was using resource provider names as resource types). Not a breaking change, we still support resource providers.

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[x] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

ssh

/azp run

@vthiebaut10 Please resolve those conflicts


Use a more modern and optimized version of antlr4ts

Hey, thanks for the great lib, it gave me great hope in a NestJS project where i attempt to use Ory permissions.
Still i noticed some issues at runtime and they are related to antlr4ts, notably this one.
Since this lib is not maintained i looked for alternatives and found antlr4g which acts like a drop in replacement… except that is built and published as an ES module.
So it would involve producing an ESM lib as well…

Hey, you are welcome :) Sorry for responding late.
Thanks for your work and PR. It is really cool that you found a drop-in replacement 👍
Unfortunately I already started replacing antlr with an custom parser, which is several times faster for this simple syntax. You can see the result in #22 . Apparently I didn't merge it 🙈.
Maybe I find some time in the near future to finish the work and merge the changes made there.

Thanks for the reply.
Yes I get why you are going that path.
I started to work on a Regexp to parse tuple with a bit more flexibility (allow namespace | namespace:object | namespace:object#relation only) and the performance tests are quite surprising.
the result gives Regex winner apparently ... ;)

method
elements
time

antlr
100 w/ subject
12.93383ms

antlr
100 w/ subjectSet
12.521252ms

regex
100 w/ subject
0.318202ms

regex
100 w/ subjectSet
0.121128ms

I was not yet able to correctly isolate parentheses in subject segment so it's still WIP.


gci: init at 0.9.0

Description of changes
gci is a tool written in go that controls golang package import order and makes it always deterministic.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

One last thing to fix. The commit should be split into two:

maintainers: add krostar
gci: init at 0.9.0


clean up empty white/black list patterns

Here is a quick fix for https://github.com/mehcode/atom-project-plus/issues/21
don't know how to write a test for it, other than run on a Windows machine

Hm.. Makes sense. Thanks for investigating and fixing it. :+1:


Directory User class's list properties have "object" type since v<IP_ADDRESS>0

In v<IP_ADDRESS>0 of the Directory client the User class's Addresses, Emails, ExternalIds, Ims, Organizations, Phones, Relations, and Websites properties were strongly typed as IList<T>, but starting in v<IP_ADDRESS>0 those properties are of type object in the class definition and end up actually being Newtonsoft.Json objects representing the serialized JSON of the lists.
This was a breaking change because code written using the strongly typed properties no longer works with the object properties without resorting to kludgy workarounds.
According to a Stack Overflow comment in May 2015 from Google developer Eric Koleda:

A change to the backend had the unintended consequence of changing the discovery document for the service, making the addresses field (and others) being marked as type=any. This causes problems for strongly types languages like .NET, as you've found. The team is aware of the issue but it's unclear when a fix will be available.

PS: This was previously reported in Issue #479, but that was recently closed and it was requested I resubmit this as a new issue.

Also see #846:

The Aliases collection on the Users.aliases (https://developers.google.com/admin-sdk/directory/v1/reference/users/aliases/list) endpoint is not being parsed into a collection of Alias objects. The (incorrect) type of the collection is IList<Newtonsoft.Json.Linq.JObject>. The code reads:
public virtual System.Collections.Generic.IList AliasesValue { get; set; }
Wheras it should read:
public virtual System.Collections.Generic.IList AliasesValue { get; set; }

The upstream discovery-doc is incorrect here: https://www.googleapis.com/discovery/v1/apis/admin/directory_v1/rest
I'll see if I can contact the team responsible and ask for a fix. This is unlikely to be quick.

Fixed using a discovery-document patcher, because the upstream team within Google has stated that they are not able to fix the typing in the discovery-document.
Note that this will be a breaking change for code that has already worked-round the problem; however, it's more of an "unbreaking" change, in that it fixes a previous breaking change ;)

Can you please tell me how to "clear" the list of existing entries of phone/website/im... on a specific user now?

Patching the user with an empty List<..> won't work.
Updating the user with an empty List<..> won't work.
Setting the Properties to null means "ignore them"

before 1.18 when these properties still where of type "object" (JArray)
updating the user with the fields to clear set to JValue.CreateNull() did the trick.
Maybe same problem : how do i reset UserAddress.CountryCode to "null" representation?
passing null means "ignore when updating" passing "" will throw an invalid value exception.

As I understand it, updating with an empty list is meant to clear the list. Although if you were using JValue.CreateNull(), then it sounds like an explicit null value also cleared the list.
I wonder if the request-object to JSON conversion is doing something like removing empty lists from the resulting JSON.
I'll try to have a look today or tomorrow to see if anything like this is happening.
I've created a new issue to track this: #861

@homiDev Please see #861 for a solution to the problem that it wasn't possible to clear a list of existing entries.

Thx for the update.
One question is still left. How to reset UserAddress.CountryCode to "null"?
This could also be done before 1.18 by sending a Json.Null representation.


Spec updates 3

For review before updating external EIP.
ERC Changelog:

Updated shared components diagram to more accurately depict modular functions and their relationship to plugins.
Added "native function" definition under Terms.
Added the IPlugin interface that describes the functions a plugin must implement.

Plugins must implement ERC-165 and support this interface.
Associated functions in the interface take a uint8 function identifier to support multiple implementations of the same type of associated function.

Removed the FunctionReference custom type, as function identifiers do not represent function selectors.
Removed the hook group concept and its associated types.
Replaced the IPluginUpdate interface with the IPluginManager interface.

The function updatePlugins has been replaced by the functions installPlugin and uninstallPlugin.

Updated the IPluginLoupe interface to reflect the above changes.
Added the IPluginExecutor interface, which introduces new functions executeFromPlugin and executeFromPluginExternal that allow plugins to interact with execution functions on the modular account as well as external contracts.
Standard execution functions and executeFromPluginExternal should not allow calls to contracts that implement the IPlugin interface to maintain the integrity of account and plugin configuration.
Added a section describing the plugin manifest, and the expected behavior for installPlugin and uninstallPlugin.
Added a section describing the expected behavior for calls made from plugins.
Style updates and typo fixes.

Closing due to underlying merge


More recent household transmission data

Have you seen this study? It seems to me to be more recent and more comprehensive than the one you are referencing for activity risk. It also disaggregates by type of interaction.
https://www.medrxiv.org/content/10.1101/2<IP_ADDRESS>64590v1

Cool paper, thanks for sharing! I think we'd want to wait for it to be peer reviewed before putting weight on the results.
Some top-level numbers:

Spouse transmission rate 43%
Household transmission rate 18%
Close contact transmission rate 5%

But the household transmission rate is all over the place - up to 60% in some studies.
Also interesting is that this sums up a lot of info on children (<18) who seem to be about half as susceptible. (Although splitting at 18 isn't super helpful if we think that body mass is the greatest determinant of respiratory volume and therefor susceptibility; 18 year olds are just about full grown, so this doesn't tell us much about susceptibility of younger/smaller children)

The study you are currently referencing has the same message at the top, and it's older.

Good point!


Remove double spaces in reprs

This PR changes  |  (double spaces) to | (single spaces) in various reprs to make them consistent with the recently changed reprs for Annotation, Info, and Raw.

Thanks @cbrnr


405 method not allowed

Error:

"message": "Client error: SETKEY http://dev.bembras.api/75247b51bd97d93cd0094978a29b194e resulted in a 405 Method Not Allowed

web.php

TusServiceProvider.php

UploadController.php
public function UploadTus()
{
    $client = new \GuzzleHttp\Client(['base_uri'=>'http://dev.bembras.api', 'debug'=> true]);
    // Alert: Sanitize all inputs properly in production code
    if (! empty($_FILES)) {
        $fileMeta  = $_FILES['tus_file'];
        $uploadKey = hash_file('md5', $fileMeta['tmp_name']);

        try {
            $client->setKey($uploadKey)->file($fileMeta['tmp_name'], time() . '_' . $fileMeta['name']);
            $bytesUploaded = $client->upload(5000000); // Chunk of 5 mb
            echo json_encode([
                'status' => 'uploading',
                'bytes_uploaded' => $bytesUploaded,
                'upload_key' => $uploadKey
            ]);
        } catch (ConnectionException | FileException | TusException $e) {
            echo json_encode([
                'status' => 'error',
                'bytes_uploaded' => -1,
                'upload_key' => '',
                'error' => $e->getMessage(),
            ]);
        }
    } else {
        echo json_encode([
            'status' => 'error',
            'bytes_uploaded' => -1,
            'error' => 'No input!',
        ]);
    }
}

The Verify method is responding ok, the problem is only on upload.
Sorry for my bad English

@jammersonf I see you are using Guzzle client to send the request to tus server. While that will work if you follow the protocol properly, it is recommended to use one of the already available clients.
You can check basic example implementation if you want to use tus-php client.

@ankitpokhrel i changed for $client = new \TusPhp\Tus\Client('http://dev.bembras.api') and has passed. But i'm still in error
Client error: POST http://dev.bembras.api/filesresulted in a404 Not Found response:\nNo input file specified.\n\n",
I already put the /files on virtualhost

Also put this on route, for test, but not worked