Update Context middleware

Saw you also support the new Laravel Context feature now.
Noticed that a variable was not re-used and that no tests were added for this feature.
Hope you don't mind me submitting a PR for that 👍

It looks like the beforeEach runs before the skip is resolved... interesting. But anyway, should have fixed my mistake there.
It also looks like there are a massive amount of other tests failing because of missing .env and such, can't think of how any of my changes triggered that? But maybe I'm overlooking something.

Thanks!


Add load_latest_results()

It would be handy to load the latest result set found in a given a directory/path:
rs = ADRIA.load_latest_results("some path")

@ConnectedSystems what would be the difference between this and ADRIA.load_results()? What would this function do/return?

In discussion it was determined that a function that displays a list of result sets in a given folder that matches some user provided criteria (time/date range run, number of scenarios, etc) is more useful.
Closing in favour of the above.


Travis: oraclejdk10 > openjdk10

Closes #1251.
Oracle :heart: license agreements. If you try and download from the URL that Travis is trying to use, you get this error:

Travis may come up with a solution but in case they don't it's simple enough to switch from Oracle's to OpenJDK's build for JDK 10.

Thanks!

What do you think of just going for open in all three builds?

Yep, lets go with everything open!


Enhancement: Focus on image when open destination folder

After saving image in Preview window, when you press "Destination folder" should not just open this folder, but open this folder AND focus on that image, otherwise it is pointless try to find that image in folder with tons of pics...

How it works now:

How it should work:

I agree, This is how chrome does it when you select open folder.

Not all work properly. Need to reopen with "bug" label.
new version of grabber, win7 64.
I faced with an unexpected behavior: if image in preview window "ignored" then when you press "Destination folder"  looks like that it open your windows profile folder with focus on "my documents" folder  instead of folder with file.

What do you mean "ignored"?

i mean this situation.

Here I get a some issues with this in 5.2.0
with empty search request after saving image via preview window, it saves well in right folder, but when you press "destination folder" button in preview window, insdtead of folder with focused image in it, grabbr just opens your windows profil folder -_____-


Space between charts on zoomed histogram is wrong

@javierarce @piensaenpixel would need some help with the svg changes needed

Also, please note that the alignement is buggy.

Fix the margins in 176-fix_histogram
I'll talk with @javierarce about the height


Android: Fix TextAlignment regression

Fixes https://github.com/fusetools/fuselibs-public/issues/197
Regressed in f791ebbc8a20b0d53b6d94a0ae392eab5cfa96ee
This PR contains:

[x] Changelog
[ ] Documentation
[ ] Tests

@kusma maybe this should go on release-1.1 if we are doing a patch release?

@nekronos: There's still a long time until we release 1.2, so yeah, I think we should prepare it for a 1.1 patch-release.


Updatign to Android O and updating FCM libraries

Build failing due to license;
FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring project ':library'.

You have not accepted the license agreements of the following SDK components:
[Android SDK Platform 26].
Before building your project, you need to accept the license agreements and complete the installation of the missing components using the Android Studio SDK Manager.
Alternatively, to learn how to transfer the license agreements from one workstation to another, go to http://d.android.com/r/studio-ui/export-licenses.html

@damienomurchu it happening because you probably don't have the SDK 26, platform-tools or something like that and the Gradle is auto installing it without accepting the license
See: https://developer.android.com/studio/intro/update.html#download-with-gradle

@danielpassos yeah, that's just the CircleCI failing (my local build is fine) - was this the issue we were having with Travis also?

@damienomurchu No in travis-ci we had problem with start the emulator. If there is a problem in circle-ci, problem we are not set it correctly => https://github.com/aerogear/aerogear-android-push/blob/master/circle.yml#L4-L9

@secondsun Can you also update the circle-ci? :kissing_heart:

@danielpassos  Done!

@secondsun Build still failing because you forgot to update the buildToolsVersion see my comments above :wink:


better split of the naming of the two resourcegroups

@bartjanson commented on Wed Jul 17 2019
paragraph Why are two resource groups created with AKS?
describes two, but at the 1) it talks about the first AND the second group:
An example of the second resource group is MC_myResourceGroup_myAKSCluster_eastus. For information on how to specify the name of this second resource group, see the next section.
This should be moved to 2).

Documentdetails
⚠ Dit gedeelte niet bewerken. Het is vereist om problemen te koppelen tussen docs.microsoft.com en GitHub.

ID: d501ff67-9208-8bcb-e8df-f09e9b16a802
Version Independent ID: e3fc3851-ddc4-d26c-251d-6ae53d714081
Content: Veelgestelde vragen voor Azure Kubernetes Service (AKS)
Content Source: articles/aks/faq.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@srvbpigh commented on Wed Jul 17 2019
Hello, @bartjanson
Thank you for your feedback.
We are actively reviewing your comments and will get back to you soon.
Kind regards,
Microsoft DOCS International Team

Hi team,
I'm moving this here since the user is refering to the original documentation
best regards

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

At this point we have decided to leave the doc as is. However, your comment will remain on the doc so if others feel the same they can comment and we can always consider reopening and updating the doc.


Only show the create, edit buttons and forms if the user is a Content Editor

Need
Currently, the create and edit buttons and forms for atlas and source datasets show if the user is logged in but not registered. Instead, we need to show these forms only if the user has the role CONTENT_ADMIN.
Approach

Call the new /me endpoint to determine the user's role after login.
Only show the create/update atlas and source dataset buttons if the user is a CONTENT_ADMIN.

User has view access only
View Atlases

View / Edit Atlas (view only)

View Source Datasets

View / Edit Source Dataset (view only)

Create Atlas (user can only access this page via address bar)


Inside Measurement

https://docs.google.com/spreadsheets/d/1Xl_XM_VXwKhqEfVrRQLTYFuKCx0O5Jq9VTvANYw6dLM/edit#gid=0

Buildings Left to do:
Hill Hall
London Hall
Tucker Hall
Townsend Hall


refactor: distinguish Slice from Chunk

Codecov Report

Merging #2397 (55edf77) into main (43fe728) will decrease coverage by 0.05%.
The diff coverage is 78.94%.

@@            Coverage Diff             @@
##             main    #2397      +/-   ##
==========================================
- Coverage   61.60%   61.54%   -0.06%
==========================================
  Files         137      137
  Lines       25503    25530      +27
==========================================
+ Hits        15711    15713       +2
- Misses       7954     7972      +18
- Partials     1838     1845       +7

Impacted Files
Coverage Δ

cmd/mdtest.go
28.48% <0.00%> (ø)

pkg/meta/interface.go
51.61% <ø> (ø)

pkg/object/hdfs.go
66.66% <ø> (-2.12%)
:arrow_down:

pkg/vfs/internal.go
60.18% <0.00%> (ø)

cmd/fsck.go
65.68% <33.33%> (ø)

pkg/object/redis.go
50.95% <48.00%> (-1.50%)
:arrow_down:

cmd/gc.go
78.26% <54.54%> (ø)

cmd/objbench.go
63.01% <58.82%> (-0.12%)
:arrow_down:

pkg/meta/sql.go
65.34% <72.91%> (-0.33%)
:arrow_down:

pkg/meta/base.go
71.36% <75.00%> (ø)

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 421cee7...55edf77. Read the comment docs.


Vercel : Cannot connect to the socket server

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
I build it based on Vercel, it successfully built. But when I open the domain,it shows that cannot connect to the socket server

How to config can I use it on vercel
Thanks!
Build logs are given below
Build Logs.txt
🐻 Uptime-Kuma Version
Latest (forked from repo)
💻 Operating System and Arch
Vercel Server ?
🌐 Browser
Edge 103.0.1264.62
🐋 Docker Version
No response
🟩 NodeJS Version
No response

Vercel doesn't support serverless function with socket

kzc


Getting an error after running

https://image.prntscr.com/image/HGegj5BhR6WKRdOu2vBvYQ.png

Nvm fixed it.

how did you fix this problem, I am facing a similar one.

i forgot but try making sure your bearer and userid is correct and do python3 instead

I'm also getting this error. Not sure how to go about solving it...


Add decryption route

Remove hardcoded keyBuffer to decipher database
Redirect from index to this route if key is not set


Configuration error Missing required option 'device' in TubesZB TI CC2652 FW Flasher

I can't start/configure the the addon, since it requires a 'device' which I am unable to select, since none is shown:

When I try to use the YAML configuration and just enter any device, I get different validation errors.
When using /dev/null it says the value does not match the filter:

When I try with "tty" it says the device does not exist.

I also tried /dev/ttyS0 to /dev/ttyS9 and /dev/USB0 to /dev/USB9 but all are giving the same error.
Any suggestions how to solve this?

what kind of system are you running HAOS on? are there really no /dev/tty devices?

It is installed on an RPi4 with the installation type HAOS:

Searching for "tty" I did not find any device that matches:

Using any other device gives me the "filter subsystem=tty!" error.

Anyone ideas what else I could do?
Would it be possible to skip the validation somehow, since I use network flashing anyway?

you can always use the command line tool.
I don't understand how you do not have any serial devices that show by default, every system/vm I've tried this on has had something there. I'll look at building an addon that is network only as a work around.

When referring to the "command line tool" do you mean the CLI addon?
https://github.com/tube0013/tubeszb_addons/blob/main/tzb-zigpy-cli-tools/DOCS.md
If so: how am I able to run an update using the tool?
The documentation does not mention any update command nor is it shown in the dropdown:

no I mean the actual command line tool that the addon uses for flashing:
https://github.com/JelmerT/cc2538-bsl


Hardcoded gitconfig path

Currently /Users/${::boxen_user}/.gitconfig isn't a parameter that can be overwritten.
Can git::config::global take path as a parameter besides value and just default to the above if not specified?

It definitely could. My only concern would be ensuring that the path is reused for all the values you pass in. It wouldn't be global if you pointed it elsewhere.
Happy to review a PR if you'd like to get this going.

Something like this:
Git::Config::Global<| |> {
  path => "/Users/${::boxen_user}/.gitconfig.user
}


Wrap map close btn in clickable div

This moves the 'close map' click event to a wrapper around the btn so the map closes when user clicks anywhere above or below the btn.

:+1:


Fix issue with callback marshalling

Callback lifetime should be the same as WebView main object.

Does this change still guarantee that the callback is not moved by the GC for the lifetime of the window? How does this change the lifetime of the object? Previously it would be kept alive by the GCHandle right?

I'm having a very annoying problem, can't run any of the examples and i think this PR fixes it
Tried Console app and AspNetCore host app
Exception thrown: 'System.Exception' in Webview.Core.dll
An unhandled exception of type 'System.Exception' occurred in Webview.Core.dll
Could not allocate webview

Yes that change guarantee that callback will not be collected by GC. Actually lifetime of the callback is the same as lifetime of the "Webview" instance. Callback instance is cretaed in theheap and reference to it is saved in the object.
I was trying original version with .net core and it never works - no callbacks was called on  windows and linux. I don't try Mono or .NET Framework.
Actually calling "GCHandle.Alloc" on object that is allocated on stack it always not good idea.

Actually calling "GCHandle.Alloc" on object that is allocated on stack it always not good idea.

The invoke callback is always heap allocated. It's a reference type not a value type. Both of the following lines would be equivalent:

> Yes that change guarantee that callback will not be collected by GC. Actually lifetime of the callback is the same as lifetime of the "Webview" instance. Callback instance is created in the heap and reference to it is saved in the object.

From what I can see the change shouldn't affect the GC lifetime of the callback delegate. It should be referenced either through the `GCHandle` we store inn a field or via the direct field reference in your change. What _does_ change is that without the `GCHandle` how can we be sure the delegate isn't moved in memory by the GC? If that happens then the address we took of it and passed to `webview_alloc` won't be valid any more.

Apologies if I'm missing something here. I just know that without the GCHandle to pin the object I did see problems when the delegate got moved by the GC.

I wonder if the actual issue here is that the GCHandle isn't pinned?


Does this work with

Im looking for a solution to ignore error or declare in prettierrc that
when they see {{ }} and a $ or a . dot they will just know its from go template
Ive tried your plugins seems not working my usecase still getting an error
this error only happens if used inside an IF statement or using :=  , functions eq ne ,etc..
Seems like prettier is using  the its default for javascript...
Since {} is a javascript  entity i think its the main issue there

Hi, thanks for creating the issue!
It would be nice if you could give one (or mulitple) code examples on which is the actual behavior, and on which behavior you would expect :)
The {{}} inside JS is a tricky thing, because it is also just valid JS 👀

I'll close this for now, as there has been no reply.


Just a Thank You!

Not really an issue, just wanted to say thanks for such an awesome game! Burned through it in a few days and absolutely loved it! Is there any way to throw a few dollars at the contributes in thanks? Crypto address, Patreon, or anything like that?

Thanks a lot for your comment! Glad that you like the game.
No, I'm afraid there is no possibility of leaving money. At least at the moment, maybe I should think about it ... no, seriously: This is just a hobby project, and if people have fun playing, I'm really happy. And besides, I have played a lot of games in my life that someone has provided for free, so I feel I could give something in return.

+1 to this. Just discovered it on F-droid, and have been enjoying playing through the levels. Thanks for creating it.


Support for updating licenses

Currently the API calls listed below are not supported. Adding these functions would be useful to update a license after receiving a registration failed without recreating the whole device which can take a lot of time. This is the current behavior if it is created from the portal. They are also necessary to renew expired licenses without having to create a new device.

Update License File
Update License Token/ID/Code

After some test it seems this functionality is not working properly neither from the API / portal. This shouldn't be implemented while the API is not ok


https:// disappears on container restart for plex hostname

After entering the Overseerr plex.direct URL with https:// at the start and saving it (connecting successfully to plex) it works great. If I restart the Maintainerr container in docker the preceding https:// disappears and plex is inaccessible. to Maintainerr and I have to readd the https:// save and reconnect.
Maintainerr>Settings>Plex>Hostname or IP
Device (please complete the following information):

OS: Windows 11 (WSL2)
Docker version 24.0.7, build afdd53b

Hey!
It's normal for the 'https://' portion to disappear from the field. When 'https://' is added during configuration, it triggers a change in the plex_ssl flag in the database. This flag is then utilized to enforce the connection over https. Simply refreshing the browser should also cause the 'https://' portion to disappear.
The reason it suddenly stops working after a container restart is puzzling. You might want to try opening the maintainerr.sqlite database file with an SQL editor to ensure the plex_ssl flag (in the settings table) remains consistent between container restarts.

Hey! It's normal for the 'https://' portion to disappear from the field. When 'https://' is added during configuration, it triggers a change in the plex_ssl flag in the database. This flag is then utilized to enforce the connection over https. Simply refreshing the browser should also cause the 'https://' portion to disappear.
The reason it suddenly stops working after a container restart is puzzling. You might want to try opening the maintainerr.sqlite database file with an SQLite editor to ensure the plex_ssl flag (in the settings table) remains consistent between container restarts.

The problem doesn't appear to be occurring any longer. I don't know why it did that. Everything is running well. Thanks.

Hey! It's normal for the 'https://' portion to disappear from the field. When 'https://' is added during configuration, it triggers a change in the plex_ssl flag in the database. This flag is then utilized to enforce the connection over https. Simply refreshing the browser should also cause the 'https://' portion to disappear.
The reason it suddenly stops working after a container restart is puzzling. You might want to try opening the maintainerr.sqlite database file with an SQLite editor to ensure the plex_ssl flag (in the settings table) remains consistent between container restarts.

The problem doesn't appear to be occurring any longer. I don't know why it did that. Everything is running well. Thanks.

Great, thanks for letting me know!


Use a canonical URL

Since we serve this site at multiple URLs (sometimes intentionally, others just by virtue of the way we build and deploy it -- e.g., "www-*", public buckets URLs, etc.), we should specify that the "real" URL is always, ultimately, https://www.pulumi.com. This change makes that clear in the HEAD, sitemap and RSS templates.

@chrsmith That's right. Since baseURL is necessarily overridden in various places, it doesn't quite fit for this case. I did look into whether Hugo offered more direct support for this, but their canonicalization appears to use baseURL also, so this seemed like an okay solution in that light.


Refactor to use Operator SDK

Refactoring this project from Kubebuilder to OperatorSDK would enable improved operator packaging and deployment.

Created new project using operator-sdk. Now hand merging original susql mods into new project.


Files downloaded from website fail to upload without showing error

Describe the bug
A file, such as a PDF, downloaded from a website when then uploaded via FileGator fails to upload and shows no error in any log or in the browser console. This appears to be security related in some way, the files are downloaded with the flag that they were downloaded from the web and "may present a security risk".
A workaround for this is to open it in Adobe Reader and then re-save it as a new name and upload that version.
The main bug here is that there is no error message when this happens.
Using Google Chrome
To Reproduce
Steps to reproduce the behavior:

Drag file in... everything seems to work as expected

Expected behavior
An error window should show up if a file is not working for some reason.
Logs
No errors present in php, app, or console.
Environment (please complete the following information):

FileGator Version [e.g. 7.0.0]
Server: IIS
PHP Version- 7.2.7
Browser - Chrome

Additional context
Add any other context about the problem here.

Hi,
Thanks for reporting this.
Are you using (or have you tried with) the latest filegator version 7.4.4?

7.4.3 actually. Let me see about getting an update done on that.

Unfortunately, I am not able to reproduce this yet.
Is anyone else getting this bug?

Hi,
Even I tired, pdf uploads fine. Couldn't reproduce this.
Thanks


Docker build broken due to haskell failure

I cloned this repo and ran the command:
sudo nix-build -A dockerImages.submitApi --no-out-link --show-trace -v

Which eventually failed with the error:
building '/nix/store/5sz692kbg6m4i5cjia8d7gnam6rb8vns-semigroups-0.18.5-1.cabal.drv'...

trying https://hackage.haskell.org/package/semigroups-0.18.5/revision/1.cabal
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5828    0  5828    0     0  41928      0 --:--:-- --:--:-- --:--:-- 41628
building '/nix/store/dfs5rm0gj37pawp4lv5mra3dp8g4sv2w-alex-3.2.4-exe-alex.drv'...
unpacking sources
unpacking source archive /nix/store/53v9acwjkyif77klwx2x7cqa34v5jaan-alex-3.2.4-src
source root is alex-3.2.4-src
patching sources
configuring
Configure flags:
--prefix=/nix/store/d3aqqq16pjx1bg29gmqi3l4rri016znp-alex-3.2.4-exe-alex exe:alex --package-db=clear --package-db=/nix/store/1nlsf3g0v62fys4l2sw2klqa7ndq8x5v-alex-3.2.4-exe-alex-config/lib/ghc-8.4.4/package.conf.d --flags=small_base --exact-configuration --with-ghc=ghc --with-ghc-pkg=ghc-pkg --with-hsc2hs=hsc2hs --with-gcc=cc --with-ld=ld.gold --ghc-option=-optl-fuse-ld=gold --ld-option=-fuse-ld=gold --with-ar=ar --with-strip=strip --disable-executable-stripping --disable-library-stripping --disable-library-profiling --disable-executable-profiling --enable-static --enable-shared --enable-split-sections
Configuring executable 'alex' for alex-3.2.4..
Warning: The flag --disable-executable-profiling is deprecated. Please use
--disable-profiling instead.
Setup: Encountered missing dependencies:
base <5

builder for '/nix/store/dfs5rm0gj37pawp4lv5mra3dp8g4sv2w-alex-3.2.4-exe-alex.drv' failed with exit code 1

It appears to be related to something like https://github.com/haskell/cabal/issues/6327 but I'm not sure. Maybe the build files in this repo need to get working binary versions specified in a build script somewhere, or maybe you can provide a working Dockerfile?

@maxogden we're working on this today. Thanks for reporting

@maxogden We've tried to reproduce this without success. Please try again, and reopen if it's still happening on a more recent commit. Please supply OS information and a git commit hash if you do find the same result.


el[0].hasAttribute is not a function

Hi,
I have a problem when you receive a nodeName :#comment, nodeValue:  ngIf: isOpen "
That give me an error el[0].hasAttribute is not a function
Stack :
TypeError: el[0].hasAttribute is not a function
at shouldValidateElement (jcs-auto-validate.js:847)
at Object.validateElement (jcs-auto-validate.js:892)
at jcs-auto-validate.js:1265
at jcs-auto-validate.js:494
at angular.js:17782
at completeOutstandingRequest (angular.js:5490)
at angular.js:5762(anonymous function) @ angular.js:12416$get @ angular.js:9203(anonymous function) @ angular.js:17785completeOutstandingRequest @ angular.js:5490(anonymous function) @ angular.js:5762
Thanks you!

Hi, could you do a plunker which reproduces the error then I can fix it.
You can use this plunker as a template.
http://plnkr.co/edit/pITG8H4mbLLl9B8YdOkY?p=preview

Fixed in the latest release (v1.18.16)

wow so fast! I love your module!

Thanks!
On Fri, 4 Sep 2015 10:46 kefran06<EMAIL_ADDRESS>wrote:

wow so fast! I love your module!
—
Reply to this email directly or view it on GitHub
https://github.com/jonsamwell/angular-auto-validate/issues/88#issuecomment-137612372
.

Wow, that was awesome.
I just faced the same issue and you fixed that in no time.
Thank you for the fix on that one. Your module is amazing!


chore(package): remove v0.8 from engines list

We don't really guarantee our stuff works on v0.8, since travis doesn't run on that version (this is because jshint requires v0.10+). So this just removes it from package.json. This doesn't prevent v0.8 users from using shelljs, just removes the promise of support.
See #307 for a discussion about this.

I don't think we support anything less than <0.12, do we? (I think travis only builds 0.12 and up)

@ariporad the travis config uses nvm to install the version of node. nvm supports each of those versions.
This can be verified by looking at the travis output where it says node --version.

@nfischer: no, I know, but is our build set up to build on node 0.10? (Sorry, on mobile, so I can't check)

@ariporad Yeah, our travis config uses v0.10, 0.11, 0.12, 4, and 5

Ok then. LGTM!


[Bug]: Mechanic "Damage Lore" does not work with items created with prorpgitems

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When creating a sword with prorpgitems, regardless of the damage the sword has, when I use a SkillApi ability using the Damage lore mechanic, the damage done is not what it should.
For example, create a sword using Rpgitems with 20 damage, and an ability using the damage lore mechanic that should do 50% of the weapon's damage equivalent to 10 damage, but instead when using the ability it deals 20 damage as if it were taking 100% of the weapon's damage...
It is ruled out that it is due to my regular expression, Since my ability works perfectly if instead of using an item made with rpgitems I grab a vanilla item and add a lore with the /lore add command, when doing this the ability does 50% of the damage correctly. In turn, this problem occurs with skills that use higher values such as 150% or 200% of weapon damage.

This is an item generated with prorpgitems
\u2694 Daño: {value}
This is the regex that I use, I have tried without \u2694 but it does not work either, in turn I tried removing the color codes and it still does not work
Expected Behavior
I suppose it is a problem directly related to Prorpgitems, since as mentioned in the above, the Damage lore mechanic works perfectly if a vanilla item is used with a custom lore

Steps To Reproduce

Create a skill with the mechanic of Damage lore
Create an item with prorpgitems
In engine.yml change:

In Damage.yml change:

Everything else is by default, the only changes I made was to translate the names
Attachments file of my item and skill:
Skill 1.txt
espada_comun.txt

Environment
- Server Software: Paper Spigot 1.17.1
- ProSkillAPI Version: <IP_ADDRESS>-ALPHA
- ProMCCore Version: <IP_ADDRESS>-ALPHA
- Plugins:
ItemMods, LuckPerms, custom-ore-generator, PlaceholderAPI, ClearLag, KnokkoCore, ProtocolLib, LibsDisguises, CustomItems, Vault, eRankUP, WorldEdit, Essentials, RiseCore, HolographicDisplays, WorldGuard, Multiverse-Core, Citizens, MythicMobs, EconomyShopGUI, ModelEngine, Terra, ProMCUtilities, ProRPGCrafting, ProMCCore, Kingdoms, ProRPGItems, ProSkillAPI, BeautyQuests

latest.log
No response
Anything else?
No response

I have verified that if I use a sword or any vanilla item and use the /qrpg set damage command, the same thing happens, the skill's damage is not applied correctly, so it is most likely that it is a problem with the damage of the items created with prorpgitems or the compatibility it has with proskillapi

Hi again, I found perhaps the source of the error, as the damage lore mechanics could not be solved, I used the Value lore mechanics as a substitute and I directly used the Damage mechanics, but I found that if in the Damage mechanics I left the active knockback option:

The damage is bug and happens the same as with Damage lore, the damages with multipliers greater than 1 (1.5 = 150% for example) go very high, so they do much more damage than they should and if less damage is used a 1 (0.5 = 50%) the damage is not applied and instead takes the total damage of the item (If I have a weapon with 10 damage and I do a skill with 50% weapon damage, the 10 total damage of the weapon is applied instead of 50% so it ignores the multiplier entirely).

This is not just the issue for your values, I have the dame probem in issue 177.

This might be related to a similar issue I noticed.
Prorpgitems does extra damage when using skillapi skills based on damage in the lore of the item. (even without using damage lore mechanic)
it adds the values in the lore to whatever damage is set in skillapi skills, if skillapi has no damage set, then whatever is the target takes damage based on the lore of the rpg item.

My thoughts here are that it's actually firing damage events through RPGItems, causing it's damage system to inflict damage, overriding the skill damage in a way. This'll be an interesting bug to figure out.

an easy test is to make a skillapi skill that has a cast trigger and any target
then make an rpgitem with some physical damage on it
hold the rpgitem in your hand and then do /class cast

So I'm currently working on a fix to this... but there's a bit of a caveat. I have it mostly working. I'm just trying to decide if it's a good thing to have RPGItems' crit chance/modifier apply for skills being cast or not. Right now it's modifying the damage done based on equipped items, but I did get it to stop adding the equipped item's damage to the skill damage. Thoughts on crit damage and possibly other modifiers being applied when skill damage is done? Or should it just be skill damage?

I would prefer that only the damage of the ability be done, that of giving critical I prefer to control it separately, if it is not a mess then balancing the damage of the abilities, or what could be done if that "critical" is required is to use Value multiply or some mechanics to simulate that critical damage


log4j and UTF and rename var

dependency log4j 1.2.17 changed to log4j api 2.16
UTF-8 encoding added
renamed a variable suggested in #814

There's a test failure
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project google-cloud: Compilation failure
[ERROR] /tmp/cdap-e2e-tests/cdap-e2e-tests/plugin/src/e2e-test/java/io/cdap/plugin/gcp/stepsdesign/GCSBasicDemo.java:[162,56] cannot find symbol
[ERROR]   symbol:   variable myObj
[ERROR]   location: class stepsdesign.BeforeActions

There's a test failure
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project google-cloud: Compilation failure
[ERROR] /tmp/cdap-e2e-tests/cdap-e2e-tests/plugin/src/e2e-test/java/io/cdap/plugin/gcp/stepsdesign/GCSBasicDemo.java:[162,56] cannot find symbol
[ERROR]   symbol:   variable myObj
[ERROR]   location: class stepsdesign.BeforeActions

yeah, i have raised another PR for the same : https://github.com/data-integrations/google-cloud/pull/861

please squash commits

done @rmstar


Meta sections landing pages

Tagging @hyrodium to get a second opinion before implementing the rest: Do you find that adding landing pages for the meta-sections such as this is useful? I found it disorienting every time I click a meta section and ended up on a specific page.

Great work!
But there already is a feature for the meta section page. You can just add index.md to the meta section directories. See comparisons/interoperability/index.md for example.

Oh wow, that makes more sense and is much better. Thanks!

I will wrap up this PR here, as I quicly found myself significantly rewriting the pages for which I added a landing page. Further additions of meta section landing pages should be part of the general rework that most sections still need.


Added Dice Roller in Python

Fix to  Issue #148
===============================
I have added a Python script by which we can roll two dice to get random numbers.
===============================
Checklist

[ yes] I read the contributing guidelines
[yes ] I structured my project as stated in the contributing guidelines
[yes] My project uses dependencies
[ yes] I starred the repo
[ yes] I had fun contributing!

Project reviewed and merged.
Thank you @asryan11
Feel free to add more projects.


New namespace, kong resource processing failed: failed to fetch the secret

I've just created a new namespace in the cluster where I have other instances running kong and having ingresses working just fine.
If i create a new ingress in any of the other namespaces it works but in the new namespace i get the error in kong logs:
ingress-controller time="2023-11-28T08:17:48Z" level=error msg="resource processing failed: failed to fetch the secret (sandbox/partner-sandbox-xxx-app)" GVK="networking.k8s.io/v1, Kind=Ingress" name=partner-api namespace=sandbox │
The ingress is defined in helm so it is pretty much the same with a different name.
The namespace and the google DNS zone where created new.
Not really sure why it's not fetching the secret. The secret is create by the cert-manager

Does the Secret actually exist? I'm unsure whether you meant that cert-manager actually created it and you can kubectl get -n sandbox partner-sandbox-xxx-app successfully or if cert-manager is just configured to create it.
Which KIC version are you using, and does the issue persist if you make some trivial update to the Ingress (add a garbage annotation or similar). We start tracking Secrets based on their attachment to an Ingress, so I'm curious if there was maybe some race condition bug that failed to start tracking it--updating the Ingress forces a rescan of it and any attached resources.
Namespace-related issues shouldn't happen unless you've manually created RBAC configuration for your KIC service account and forgotten Secret read access in a namespace. There is also the --watch-namespaces feature, but that applies to all resources--if it was misconfigured, the controller would not see the Ingress either.

Hi @rainest
I am using a cert for mtls inside a Service resource with:
  annotations:
    konghq.com/client-cert: my-service-secret
    konghq.com/protocol: https

Im getting the same error:
level=error msg="resource processing failed: failed to fetch secret 'my-service/my-service-secret': Secret my-service/my-service-secret not found" GVK="/v1, Kind=Service" name=my-service namespace=my-service

The Secret is there in the cluster and things are working fine. However once is deleted and recreated (renewed) by cert manager, the Ingress controller goes into the above error and the upstream service that is expecting the cert is receiving none.
Steps to reproduce:
1- Setup a working mtla cert
2- Delete the secret containing the cert
3- cert manager will renew the mtls cert, recreating the Secret (same name, just new uid and resourceVersion and the cert content is changed)
4- The above error starts and that route to that Service doesn't send the new mtls cert to the upstream
Steps to solve currently is to add a dummy change to some annotation to the Service resource. Then as you suspected the issue goes away and the cert is reloaded correctly . Or to restart the Kong and kong ingress controller pods. That also loads teh new cert.
In effect the hot reload of this cert is broken.


#15244 fix error notifications for script tasks

The only way to determine if that type of task had any error is to look for stderr.

Use constants but weird hardcoded "Error Message" strings.
You can't put error message in properties. It has to be placed in a separate variable in tool handler.
Why Object errorMessage? And then cast it to string 👎


Precising clearly the node version needed for building + other things

Hello.
Thanks for your amazing project, I just have some kind of suggestion / problem / idk.
First, I'm a total noob about js/nodejs/yarn so if I said or ask something dumb, sorry. Yet, I searched on google and wasn't able to find about this, so here I am.
I like to build from source some programs, for fun / testing mainly. I checked your dev' instructions but it's not very clear for which version of node I need to use for building extraterm. It's seem that extraterm is using electron 2.0.0, and I read on the electron releases notes that electron 2.0.0 was updated to node v8.9.3, but since when I run yarn install / run build / etc I got some resolution fields errors I'm not really sure that I'm using the right version.
The package.json file is updated since ~ 1 week but the build instructions seems to haven't been updated since one year.
So it would be great if you could precise the node version used, perhaps in the package.json with a simple comment and updating the build instructions when you have the time.
Also, it would be nice if you could give instructions for building the complete package, there is the build_package.js script but it needs some kind of modifications, for cloning the git for example (it tries to ssh I think ?), theses scripts are kinda uniquely runnable by you, it seems (+ it packages for every distribution)
Thanks in advance, sry if I wasn't clear or anything !

I'm using node version 8.9.3 and the commands you need after cloning it down with git are:
yarn install
yarn run electron-rebuild
yarn run build
and finally
yarn run run
That should be enough to get it running from source.
You are right about the package scripts only working for me. They could work for others but it has only been tested on Linux by myself. I've got some work to do with updating the dev docs and the build scripts now that more people are interested in building and running the project.
If you have any other problems then just ask back here.

@GabrielAnca  thanks. I've updated the dev doc.


FEAT: Backend: codecov implemented

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@027f91b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #54   +/-   ##
==========================================
  Coverage           ?   91.50%
==========================================
  Files              ?       57
  Lines              ?      659
  Branches           ?        0
==========================================
  Hits               ?      603
  Misses             ?       56
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 027f91b...6e1e799. Read the comment docs.


Colliders don't work without rigid body

I only need colliders and none of the other physics stuff. It the correct way to get child colliders working to use a fixed rigid body? Or can it be made so child colliders still work without the parent having a rigid body component? The old version handled this as far as I can tell.

Hi! Colliders without parents attached should still work. Did you set the proper ActiveCollisionTypes?

Hmmm, no I didn't use ActiveCollisionTypes. Should we be using STATIC_STATIC maybe?
BTW, I'm not quite sure what you mean by "without parents attached." This is the code we're using:
    commands
        .spawn()
        .insert(MAIN_BAG_COLLIDER.clone())
        .insert(Sensor(true))
        .insert(BAG_COLLIDER_GROUP)
        .insert(RigidBody::Fixed) // Adding this line makes the with_children colliders work. Otherwise, they don't seem to do anything.
        .with_children(|parent| {
            parent
                .spawn()
                .insert(BOUNDARY_BAG_COLLIDER.clone())
                .insert(Sensor(true))
                .insert(BAG_BOUNDARY_COLLIDER_GROUP);

            parent
                .spawn()
                .insert(LID_BAG_COLLIDER.clone())
                .insert(Sensor(true))
                .insert(BAG_LID_COLLIDER_GROUP);
        })

That's correct: STATIC_STATIC is the one.
By no parent attached I meat no rigid-body attached. I did not mean "parent" as in the Bevy parent entity.

Ok, just tried insert(ActiveCollisionTypes::STATIC_STATIC) on all my colliders but no dice.

Ah, that’s unfortunate. Perhaps we have a bug then. Do you have a minimal piece of code to reproduce the problem (your code above does show how the colliders are initialized, but not what you expect them to do)?
Also: if you enable the debug-renderer, with  .add_plugin(RapierDebugRenderPlugin::default()), do you see that these colliders are rendered or not?

We've been using the colliders like this:
 let foo = rapier_context
        .intersection_with_shape(
            collider_transform.translation,
            collider_transform.rotation,
            collider,
            BAG_BOUNDARY_COLLIDER_GROUP.into(),
            None,
        );

Unfortunately I can't check the debug renderer because of #157 presumably (we're using the OrthographicCameraBundle::new_2d()).

For reference, I'm also getting this issue. Without adding a RigidBody::Dynamic to at least one of the colliders, nothing shows up in the intersection graph for a Sensor or the contact graph for non-Sensor colliders. Events don't show up at all.


"notificationToken" required

I did the setup in the documentation and placed the necessary data. But I am getting 'notificationToken' required error. I tried giving the notificationToken data null and null but the result did not change

.
    let deviceId = getUniqueId();
    RNDesk360.getInstance().initialize({
      appID:
        'pILqrvLynTfOKblGO3wKWRb2TBFX9PRwud3UWowsVmo4ppWsoFhms1A0OEcyX0aC92SHxxtgzsjTPYtX',
      deviceID: deviceId,
      appVersion: '1.0.0',
      languageCode: 'en',
      environment: Desk360Environment.SANDBOX,
      platform: Desk360Platform.GOOGLE,
      countryCode: 'tr',
      notificationToken: '',
      bypassCreateTicketIntro: true,
      name: 'Faruk',
      jsonInfo: {
        key: '2',
      },
    });
  };

I m not sure if you are using Firebase Notification. but you should pass Firebase messaging token to  notificationToken
messaging()
      .getToken()
      .then((token) => {


wallet_addEthereumChain doesn't get redirect to Metamask

Describe the bug
Some of my users has this issue that when they try to add chain network, they are not taken back to Metamask from my Game, instead it throws error:
Fatal Exception: java.lang.Exception: WalletConnectException : No matching key with tag: {tag}
       at WalletConnectSharp.Sign.Engine.IsValidSessionTopic(WalletConnectSharp.Sign.Engine)
       at WalletConnectSharp.Sign.Engine.Request[T,TR](WalletConnectSharp.Sign.Engine)
       at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[TResult].Start[TStateMachine](System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[TResult])
       at WalletConnectSharp.Sign.Engine.Request[T,TR](WalletConnectSharp.Sign.Engine)
       at WalletConnectSharp.Sign.WalletConnectSignClient.Request[T,TR](WalletConnectSharp.Sign.WalletConnectSignClient)
       at WalletConnectUnity.Core.WalletConnect.RequestAsync[TRequestData,TResponse](WalletConnectUnity.Core.WalletConnect)

To Reproduce
Steps to reproduce the behavior:

I connect metamask and Unity Game on Android
I came back to my game after authorization and then I click Unity button to add new network on Metamask
It doesn't take me back to Metamask application

Expected behavior
It should take me to Metamask application where a popup appears to add new network chain
Screenshots
Environment

OS: Build on Windows 10 game running on Android 10
Unity version 2022.3.20
WalletConnectUnity Modal v1.1.5

Is this happening in Unity Editor or on a player like Android, iOS, Windows?
Android 10
Wallets used for testing
Metamask
Additional context
None

It sounds like your query would be best dealt with by the support team.
Please see the link below to our dedicated support line:
Support :Help center
Note: Click on the live chat icon at the bottom corner of the page to start a conversation

Hey @ammarvohra, could you please upgrade to v1.1.6 and let me know if the issue persists?

Sure, I'll do it and will update you.
Thanks

@skibitsky still no luck of working, even worse, in this version sometimes users are not getting back to the game after connection is successful. They need to comeback to the game close the Modal view and open and do connection again

@ammarvohra

in this version sometimes users are not getting back to the game after connection is successful. They need to comeback to the game close the Modal view and open and do connection again

Could you please describe the exact steps so I could reproduce them? What version of MetaMask do you have?

I haven't changed anything related to the redirection in the last release; that may be an issue on the MetaMask side.

... Opened my game from app stack -> Closed the WalletConnectModal -> Clicked on connect ->  ...

What happens if you keep the modal open for 5-8 seconds after you open the game instead of closing it immediately?

I haven't changed anything related to the redirection in the last release; that may be an issue on the MetaMask side.

Idk but what I noticed was this that 1.1.4 was having some similar issue, while 1.1.5 was smooth and 1.1.6 got that issue.

What happens if you keep the modal open for 5-8 seconds after you open the game instead of closing it immediately?

Doesn't do anything just keep saying trying to connect or try again.
But the thing I couldn't understand is some people can open the Metamask when they click on Add chain network, but even after waiting for some 10-15 seconds on Metamask the option/popup to add chain doesn't come up.

But the thing I couldn't understand is some people can open the Metamask when they click on Add chain network, but even after waiting for some 10-15 seconds on Metamask the option/popup to add chain doesn't come up.

MetaMask fixed that in the latest release

User's phone configuration:
Brand: Samsung
Model: Galaxy S20 5G
Android Version: Android 13
Metamask version: 7.21.0
Still no luck

User's phone configuration:
Brand: Samsung
Model: Galaxy S20 5G
Android Version: Android 13
Metamask version: 7.21.0
Location: Europe/London

A few more questions 🙏

Just to make sure I got it right. This user gets WalletConnectException : No matching key with tag: {tag} when sending wallet_addEthereumChain?
Do they have WalletConnectUnity Modal v1.1.6 or older version?
In your game, how exactly do you resume session after restart? Do you use WalletConnect.Instance.TryResumeSessionAsync() directly or have ResumeSessionOnInit option enabled in the WalletConnectModal component? Or do you use another approach?
Have they tried to reinstall the game? Does the issue persist?

Just to make sure I got it right. This user gets WalletConnectException : No matching key with tag: {tag} when sending wallet_addEthereumChain?

No this uesr doesn't get exception as when clicking on Add chain it take him back to Metamask but Metamask does nothing

Do they have WalletConnectUnity Modal v1.1.6 or older version?

1.1.6

In your game, how exactly do you resume session after restart? Do you use WalletConnect.Instance.TryResumeSessionAsync() directly or have ResumeSessionOnInit option enabled in the WalletConnectModal component? Or do you use another approach?

ResumeSessionOnInit  option is enabled in the WalletConnectModal

Have they tried to reinstall the game? Does the issue persist?

Yeap, same issue

Have they tried to disconnect wallet and connect again? Does the issue persist?

Yeap they reinstall the application everytime, so the previous session get's expired so they need to make a new connection

Okay, it's good that they don't get the exception.
Could you please share a code snippet demonstrating how you detect the need to add a new chain to MetaMask and how you add and switch the chain?

Here is the code:
public async void OnExternalWalletConnected()
{
    while (!WalletConnect.Instance.IsConnected)
        await Task.Delay(25);

    var chainNew = new WalletConnectUnity.Core.Evm.EthereumChain
    {
        chainIdHex = "0x" + web3Params.ChainID.ToString("X").ToLower(),
        blockExplorerUrls = new string[] { web3Params.BlockExplorerURL },
        name = web3Params.NetworkName,
        nativeCurrency = new Currency(web3Params.CurrencySymbol, web3Params.CurrencySymbol, 18),
        rpcUrls = new string[] { web3Params.NetworkURL }
    };
    WalletConnectUnity.Core.Evm.WalletAddEthereumChain walletAddEthereumChain = new WalletConnectUnity.Core.Evm.WalletAddEthereumChain
    {
        chainNew
    };
    var connectNetwork = await WalletConnect.Instance.RequestAsync<WalletConnectUnity.Core.Evm.WalletAddEthereumChain, string>(walletAddEthereumChain);
    Debug.LogError(connectNetwork);

}

Same issue! I was trying to switching the chain after user successfully connected to session. @skibitsky @ammarvohra
GOT THE ERROR - User disapproved requested chains
Below is my function code to change the chain -
    private async Task CheckAndChange_ChainAsync()
    {
        string activeChain = WalletConnect.Instance.ActiveChainId;
        Debug.Log("Active chain: " + activeChain);

        Chain to_add_chain = ChainConstants.Chains.Arbitrum;
        try
        {
            Debug.Log("Switching chain...");
            Chain newChain = ChainConstants.Chains.Amoy;
            await WalletConnect.Instance.SwitchEthereumChainAsync(new EthereumChain(to_add_chain));

            Debug.Log("Chain switched!");
        }
        catch (System.Exception e)
        {
            Debug.Log("error: " + e.Message);
        }
    }

Below is the code for extention method provided by WalletConnectUnity.Core.Evm i.e SwitchEthereumChainAsync
        public static async Task SwitchEthereumChainAsync(this IWalletConnect walletConnect, EthereumChain ethereumChain)
        {
            if (ethereumChain == null)
                throw new ArgumentNullException(nameof(ethereumChain));

            var ciap2ChainId = $"eip155:{ethereumChain.chainIdDecimal}";
            if (!walletConnect.ActiveSession.Namespaces.TryGetValue("eip155", out var @namespace)
                || !@namespace.Chains.Contains(ciap2ChainId))
            {
                var request = new WalletAddEthereumChain(ethereumChain);
                try
                {
                    await walletConnect.RequestAsync<WalletAddEthereumChain, string>(request);
                }
                catch (WalletConnectException e)
                {
                    Debug.Log("Error inside: " + e.Message);
                }
            }

            var data = new WalletSwitchEthereumChain(ethereumChain.chainIdHex);
            await walletConnect.RequestAsync<WalletSwitchEthereumChain, string>(data);
        }

and below is my namespace from which i am creating the session
var requiredNamespaces = new RequiredNamespaces
        {
            {
                "eip155", new ProposedNamespace
                {
                    Methods = new[]
                    {
                        "eth_sendTransaction",
                        "eth_signTransaction",
                        "eth_sign",
                        "personal_sign",
                        "eth_signTypedData",
                        "wallet_addEthereumChain",
                        "wallet_switchEthereumChain"
                    },
                    Chains = new[]
                    {
                        "eip155:1"
                    },
                    Events = new[]
                    {
                        "chainChanged",
                        "accountsChanged"
                    }
                }
            }
        };

@deveshbeniwal could you please open a new issue with the bug report template? The error message you're getting is different than the one reported here.

@deveshbeniwal could you please open a new issue with the bug report template? The error message you're getting is different than the one reported here.

Added - https://github.com/WalletConnect/WalletConnectUnity/issues/232#issue-2323323352

It is holding us back from doing full rollout and marketing please help us to resolve this.

It is holding us back from doing full rollout and marketing please help us to resolve this.


Legal Chisel 2 code breaks

Type of issue: bug report
Following Chisel 2 code:
  val rdAddr = Wire(UInt())

  // default
  rdAddr := Cat(UInt(0, 1), nextPC)
  switch(stateReg) {
    is(fetch) {
...
      when(rdData(7) === Bits(0)) {
        rdAddr(8, 4) := UInt(0x10)
        rdAddr(3, 0) := rdData

breaks with
firrtl.passes.CheckGenders$WrongGender:  @[Lipsi.scala<EMAIL_ADDRESS>[module Lipsi]  Expression _T_74 is used as a FEMALE but can only be used as a MALE.
[error] firrtl.passes.CheckGenders$WrongGender:  @[Lipsi.scala<EMAIL_ADDRESS>[module Lipsi]  Expression _T_76 is used as a FEMALE but can only be used as a MALE.
If the current behavior is a bug, please provide the steps to reproduce the problem:

If possible, please directly provide the FIRRTL file or a relevant fragment if the file is large
node _T_74 = bits(rdAddr, 8, 4) @[Lipsi.scala 127:15]
_T_74 <= UInt<5>("h010") @[Lipsi.scala 127:22]
node _T_76 = bits(rdAddr, 3, 0) @[Lipsi.scala 128:15]
_T_76 <= mem.io.rdData @[Lipsi.scala 128:22]

Please tell us about your environment:
(examples)

version: 3.1.2
OS: macOS

What is the use case for changing the behavior?
Porting Chisel 2 code to Chisel 3

rdAddr(8, 4) := UInt(0x10)

I think the issue here is that subwork assignment is illegal in Chisel3/FIRRTL, no?

On 6 Mar, 2019, at 21:39, edwardcwang<EMAIL_ADDRESS>wrote:
rdAddr(8, 4) := UInt(0x10)
I think the issue here is that subwork assignment is illegal in Chisel3/FIRRTL, no?

Ok, but this was legal Chisel 2 code.
Martin

Did chisel2 ever work with FIRRTL though? I thought chisel2 generated its Verilog directly as this was pre-FIRRTL days. Chisel3 has a "Chisel2 compatibility layer" but I'm not sure they can handle this case, which is why I CC'ed Richard above.

This does not really matter when one ports Chisel 2 code to Chisel 3. It breaks. I am using the Chisel 2 compatibility mode.

On 6 Mar, 2019, at 21:42, edwardcwang<EMAIL_ADDRESS>wrote:
Did chisel2 ever work with FIRRTL though? I thought chisel2 generated its Verilog directly as this was pre-FIRRTL days. Chisel3 has a "Chisel2 compatibility layer" but I'm not sure they can handle this case, which is why I CC'ed Richard above.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/freechipsproject/firrtl/issues/1047#issuecomment-470268484, or mute the thread https://github.com/notifications/unsubscribe-auth/AAntmE9gwBltKJl5AWn64X5D_p7pF1FIks5vUCg8gaJpZM4bhxGr.

In that case, let's ask @ducky64 for his opinion on how the Chisel 2 compatibility mode should handle this.

chisel2 compatibility mode isn't perfect (and I don't think this is the only example of code that breaks), though we typically try to at least generate informative error messages.
That this isn't generating a good diagnostic error (something more like "subword assignment not supported, you should do X or Y instead, see Z for details") is potentially a bug. The chisel3 binding system should catch this before it gets to FIRRTL.
There's more context in freechipsproject/chisel3#244 and freechipsproject/chisel3#878
We can always discuss adding back this feature, though all the previous rounds of discussion on that have led to a resounding no.

Is it really a compatibility mode issue? With Chisel 3 I get following error:
[error] (run-main-0) chisel3.internal.ChiselException: Cannot reassign to read-only chisel3.core.UInt@d6
Does this mean that it has been decided that Chisel 2 subword assignment is not supported in Chisel 3? If so, we can simply close the issue.
Although, this is not a so uncommon pattern in hardware description.
Cheers,
Martin

On 6 Mar, 2019, at 22:33, Richard Lin<EMAIL_ADDRESS>wrote:
chisel2 compatibility mode isn't perfect (and I don't think this is the only example of code that breaks), though we typically try to at least generate informative error messages.
That this isn't generating a good diagnostic error (something more like "subword assignment not supported, you should do X or Y instead, see Z for details") is potentially a bug. The chisel3 binding system should catch this before it gets to FIRRTL.
There's more context in freechipsproject/chisel3#244 https://github.com/freechipsproject/chisel3/issues/244 and freechipsproject/chisel3#878 https://github.com/freechipsproject/chisel3/issues/878
We can always discuss adding back this feature, though all the previous rounds of discussion on that have led to a resounding no.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/freechipsproject/firrtl/issues/1047#issuecomment-470285694, or mute the thread https://github.com/notifications/unsubscribe-auth/AAntmKeffjesjqoc9s0uES7VLP_cuLFGks5vUDQngaJpZM4bhxGr.

Yes, that is the case - subword assignment is not supported in Chisel3. Issues freechipsproject/chisel3#244 and freechipsproject/chisel3#878 contain more discussion and rationale.
If you've got new use cases that have not been brought up before, we can certainly discuss them, but you should also be aware of the prior conversations including suggested alternate paths.

Thanks for the pointers. Looks like I am stumbling over this not the first time ;-)


implement SchemaMappingImpl

@SHSenpai this one is for you. See the new class SchemaMappingImpl as added in commit https://github.com/LiUSemWeb/HeFQUIN/commit/45695d6f4387db072d1af3e77e71eec8c83b48d0 This class needs to be implemented (there are several TODOs in the class), including a corresponding test class with some unit tests SchemaMappingImpl.
To this after addressing #198

Is SchemaMappingImpl dependent on EntityMappingImpl? SchemaMapping.java mentions "(i.e., applying this entity mapping to the solution mapping does not have any effect)", is this a typo from copying over the definitions of EntityMapping's methods?
Also, what exactly is SchemaMapping? The brief description I see in SchemaMapping.java doesn't give me a clear view of what the methods in the class are supposed to do when fully implemented.

Is SchemaMappingImpl dependent on EntityMappingImpl?

No.

SchemaMapping.java mentions "(i.e., applying this entity mapping to the solution mapping does not have any effect)", is this a typo from copying over the definitions of EntityMapping's methods?

Yes, that was a typical copy-paste error. I have fixed it in commit https://github.com/LiUSemWeb/HeFQUIN/commit/4ad03d7866c93dd33faedaad8bcb1ef4232e0e7e

Also, what exactly is SchemaMapping?

As you may remember, RDF vocabularies / ontologies introduce classes and properties which can be used in RDF triples that represent statements about instances of the classes. For instance, the FOAF vocabulary contains the class of persons for which it introduces the URI http://xmlns.com/foaf/0.1/Person (or, foaf:Person for short if we assume that the prefix name foaf is declared for the URI prefix http://xmlns.com/foaf/0.1/). Now, we can use that URI in a triple to state that something identified by the URI http://example.org/Bob is a person:
 (http://example.org/Bob, rdf:type, foaf:Person)

The properties that RDF vocabulary define can be used in the predicate position of triples. For instance:
 (http://example.org/Bob, foaf:name, "Robert")
 (http://example.org/Bob, foaf:knows, http://example.org/Ali)

Now, entity mappings are about the URIs for the things that we can describe using such vocabularies (e.g., http://example.org/Bob and http://example.org/Ali in the example). Schema mappings are about the properties and the classes defined in the vocabularies. For instance, a schema mapping may define that the class denoted by the URI foaf:Person is equivalent to the class denoted by the URI http://example.org/HumanBeing or that the class with URI foaf:Person is a subclass of the class with URI foaf:Agent. Juliette's thesis draft covers several such types of relationships between classes and also between properties. A schema mapping may contain all of them (except for the owl:sameAs relationships, which are for entity mappings).
Unfortunately, the VocabularyMapping class that we currently have in HeFQUIN mixes both (i.e., it represents both a schema mapping and an entity mapping). I would like these two things to be separated. That's why the new interfaces EntityMapping and SchemaMapping. So, in that sense, the functions of the SchemaMapping should do what the corresponding functions of the VocabularyMapping are currently doing except for the parts that are based on owl:sameAs relationships between URIs of entities.
Does this help? Let me know if you have further questions.

Yeah, this helps quite a bit.
I have some further questions, first off: The implementation's TODO wants me to define 'TermMapping' and implement classes. After looking at the page you linked to, I still don't know what 'Term' means in this context.
What relationships between classes exist, which the SchemaMappingImpl should be aware of (if any)? I see "equivalent to" and "subclass of" as two examples, are there more?
Furthermore, assuming that foaf:Person is a subclass of foaf:Agent, how do I apply this to a solution mapping? Same for the inverse.
Given  (http://example.org/Bob, rdf:type, foaf:Person) as a triple pattern, what sort of result can I expect applyToTriplePattern to produce given the knowledge that foaf:Person is a subclass of foaf:Agent? They're not equivalent, so (http://example.org/Bob, rdf:type, foaf:Agent) as a result by itself doesn't seem like a fully-obvious output, but at the same time I also don't see any alternative outputs.
I see that the TODO states that Node should be the key value in g2lMap - just like in EntityMappingImpl. Can Node be anything? A literal? A URI? Furthermore regarding the g2lMap, should an l2gMap in the same vein as EntityMappingImpl also be created? If so, is applyInverseToSolutionMapping the 'mirror image' as it is in EntityMappingImpl, or something else? If not, I assume the applyInverseToSolutionMapping would work as a 'any of these locals are renamed to this global', but I'm not sure because this isn't a Node-to-Node mapping as it was in EntityMappingImpl.
From what I can see on the FOAF webpage, I have a hint that these foaf-classes are pre-defined and finite. Is this correct? As in, the classes listed on the FOAF webpage are all FOAF classes which exist and they have set properties which can be specified - and also seems like not all properties have to be specified.
What is the difference between domain and range in the context of FOAF? My current hunch is that 'range' are properties which establish a relationship between one class to another class, whereas 'domain' are properties that do not involve other classes.

I have some further questions, first off: The implementation's TODO wants me to define 'TermMapping' and implement classes. After looking at the page you linked to, I still don't know what 'Term' means in this context.

By "terms" I mean the URIs that identify classes and properties as introduced by the vocabularies. For instance, foaf:Person is a term, and so is foaf:knows. In the Jena API, such terms are objects of the Java class Node.
Now, regarding TermMapping, please note that I have not thought through in detail how SchemaMappingImpl can be implemented. However, broadly the idea was to capture the different types of relationships that can exist between terms in the global and in the local vocabulary by different Java classes that implement TermMapping (i.e., one such Java class per type of relationship). An object of such a Java class would represent the instance of the corresponding type of relationships for a particular term of the global vocabulary.
For example, the "equivalent to" relationships that can exists between classes would be captured as one such Java class that implements TermMapping. Let's call this Java class EquivalentClassMapping. Then, continuing my earlier example about the class with URI foaf:Person being equivalent to the class with URI http://example.org/HumanBeing, you would need to create an EquivalentClassMapping object that represents this particular instance of the "equivalent to" relationship. Further, assuming foaf:Person is in the global vocabulary, this EquivalentClassMapping object needs to be put into the g2lMap under the key for foaf:Person (i.e., the Jena Node object for the URI foaf:Person).
What function declarations the TermMapping interface needs to contain in order to be able to use TermMapping objects for the rewriting of triple patterns (function applyToTriplePattern of SchemaMappingImpl) and for the rewriting of solution mappings (function applyToSolutionMapping) is something that I have not yet thought about. Maybe you have a proposal?

What relationships between classes exist, which the SchemaMappingImpl should be aware of (if any)? I see "equivalent to" and "subclass of" as two examples, are there more?

This is in Juliette's thesis report. I will email you a recent draft that she just sent yesterday. In that one, the relevant section for your question here is Section 4.2.2.

Furthermore, assuming that foaf:Person is a subclass of foaf:Agent, how do I apply this to a solution mapping?

Short answer, that still needs to be defined.
Longer answer: Remember that both your and Juliette's thesis work considers only the cases in which solution mappings need to be translated from the local vocabulary of a federation member to the global vocabulary. That would be applying the inverse of a schema mapping to such solution mappings (which your next question was about---answer below). In other words, for both your theses, you are not considering cases in which solution mappings that contain terms of the global vocabulary need to be translated by applying our global-to-local schema mappings to them. That's why this part is still undefined. Creating this definition is perhaps not too difficult because it would be similar to how the schema mappings are applied to triple patterns. However, I suggest to ignore this part for the moment and, instead, first focus on implementing the functions of SchemaMappingImpl for which we have definitions (i.e., the functions applyToTriplePattern and applyInverseToSolutionMapping).

Same for the inverse. [...]

See Section 4.4 in the latest draft of Juliette's thesis report that I will email you.
Remember, however, that Juliette's notion of "vocabulary mapping" mixes the concept of a schema mapping with the concept of an entity mapping. Hence, for the schema mapping, you can ignore the parts of Juliette's description that are about owl:sameAs.

Given (http://example.org/Bob, rdf:type, foaf:Person) as a triple pattern, what sort of result can I expect applyToTriplePattern to produce given the knowledge that foaf:Person is a subclass of foaf:Agent? They're not equivalent, so (http://example.org/Bob, rdf:type, foaf:Agent) as a result by itself doesn't seem like a fully-obvious output, but at the same time I also don't see any alternative outputs.

The rewriting of triple patterns is defined in Section 4.3 of Juliette's latest draft (also here, ignore the parts that are about owl:sameAs).
For your given example, assuming that foaf:Person is in the global vocabulary and foaf:Agent in the local one, there is no way to correctly rewrite your given triple pattern and, thus, by the definition, the triple pattern would remain as is.
An alternative example would be a triple pattern (?x, rdf:type, foaf:Agent) with foaf:Agent in the global vocabulary and foaf:Person in the local one. In this case, the triple pattern would be rewritten to (?x, rdf:type, foaf:Person). Informally, you can think of this rewriting as follows: the given triple pattern wants to retrieve all agents and, by the schema mapping, we know that persons are agents; therefore, we can retrieve all persons from the federation member that uses the local vocabulary with foaf:Person and return all these persons as solutions for the given triple pattern.

I see that the TODO states that Node should be the key value in g2lMap - just like in EntityMappingImpl. Can Node be anything? A literal? A URI?

In general, yes. The Jena class Node represents literals, URIs, etc. However, in the particular case, you would create such Node objects only for the URIs that identify terms in the vocabularies, as I explained above.

Furthermore regarding the g2lMap, should an l2gMap in the same vein as EntityMappingImpl also be created?

I think yes.

If so, is applyInverseToSolutionMapping the 'mirror image' as it is in EntityMappingImpl, or something else? If not, I assume the applyInverseToSolutionMapping would work as a 'any of these locals are renamed to this global', but I'm not sure because this isn't a Node-to-Node mapping as it was in EntityMappingImpl.

applyInverseToSolutionMapping is not exactly a "mirror image" in this case. As I mention above, the desired effect of applyInverseToSolutionMapping is defined in Section 4.4 of Juliette's latest draft.

From what I can see on the FOAF webpage, I have a hint that these foaf-classes are pre-defined and finite. Is this correct? As in, the classes listed on the FOAF webpage are all FOAF classes which exist and they have set properties which can be specified - and also seems like not all properties have to be specified.

Yes. However, please do not get hung up too much on the FOAF vocabulary. That was just an example.

What is the difference between domain and range in the context of FOAF? [...]

domain and range are general concepts for RDF vocabularies. In other words, there is nothing specific about them in the context of FOAF. As a reminder what these concepts mean, you can take a look again at Section 4 of the RDF primer document I pointed you to much earlier: https://www.w3.org/TR/rdf11-primer/#section-vocabulary


Switch to own CI

Travis CI is too slow

Also, we need to create separate .sh with commands for ci, so everybody will be able to see them and we will be able to change them directly in repository
And, we can disable pre-dexing and enable gradle daemon on CI


Comparator support appears missing

I need to be able to specify a custom comparator to be able to read data that is not stored in lexical order.
LevelDB's JNI interface has this, and I didn't spot that there's no apparent equivalent in LMDB JNI until just now :(

I think its possible to expose this functionality. I'll have a closer look later today.

Thanks very much! :)

Didn't find time to deliver a fix tonight but the solution seems straight forward.
One thing to note is that the comparator is called a huge number of times in any db operation which will  degrade performance substantially. So using a non-native comparator may not be a good idea... depending on your use case of course :-)
http://www.openldap.org/lists/openldap-technical/201502/msg00117.html

I get Howard's point, but leveldb's JNI has it, and LMDB's not having it is a bit of a deal breaker for my using LMDB with Java.  In my case it's not particularly performance sensitive - I only need to do a single seek call to find the closest matching key and then iterate from that point onwards.  Thanks again :)

Sorry about the delay. I haven't been able to find time to work on this yet. Hopefully next week.

Thanks for the update :)

My initial idea was to let users provide a class which has a method signature which looks like this. The arguments are MDB_val pointers as specified by the LMDB API.
public static int compare(long ptr1, long ptr2) {
  return 1;
}

A pointer to this method can fetched using the following new method in JNI.java.
@JniMethod(flags={MethodFlag.JNI, MethodFlag.POINTER_RETURN}, cast="jmethodID")
public static final native long GetStaticMethodID(
      @JniArg(cast="jclass", flags={POINTER_ARG}) Class clazz,
      String name,
      String signature);

Users would register their comparator method/class using this new method on Database.java.
public void setComparator(Transaction tx, Class comparatorClass) {
    JNI.mdb_set_compare(tx.pointer(), this.pointer(), JNI.GetStaticMethodID(comparator, "compare", "(JJ)I"));
  }

However, LMDB crashes as soon as a second item is inserted into the database and I haven't figured out why this happens yet. I'm gonna read up a bit more on JNI.

It's possible that LMDB simply doesn't like a comparator that always returns 1.    Did you happen to look at the levelDB JNI implementation?  I suspect that it's very similar to what would be required for LMDB.  Thanks again...

The comparator is not called at all so there is something missing I think. I did have a look at LevelDB implementation but they do some C++ stuff which seems unnecessary if I understand correctly.
Thanks for your tips. I'll investigate further.

Good news. I managed to get LMDB to call a comparator using hawtjni-callback which seems like the right way to go. I haven't tested it too much yet but it looks promising :-)
Give a few more days to nail this.

Great - thanks again for your help on this.  I'm very happy to help test it when I get back to the office on Monday if you put it on a branch.

No problem. What OS are you using?

I'm using OS X and Linux.

A first commit suggestion. This is not final. I will do more testing myself, just wanted to put it out in the open. Please try it out and feel free to provide any feedback you have.

The compare callback from LMDB provide memory addresses which is the wrong level of abstraction for users. My initial suggestion is to provide DirectBuffers to the comparator. However, this is also risky since  users may screw up byte ordering, SIGSEGV memory addresses and thinking the implementation is buggy etc. One suggestion is to provide something safer similar to the BufferCursor.
What's your thoughts on this?

For my own use case I'd be happy with a pair of byte[], although longer term I guess something that doesn't involve a copy would be preferable.

Good call. A pair of byte arrays is the safest way to go. If we want to go faster we can always pull out zero-copy. I'll add a byte array method.

That looks perfect, thanks!  I'll give it a thorough test on Monday :)

Sweet! Let me know how it goes. I'll test our supported platforms in the meantime and if everything is green i'll make a release end of next week.

Initial tests look good, but I have another issue that I'll raise a new ticket on that's impeding my debugging :+1:

This is working fine to me, thanks! :+1:


Remove defaultLocale from the Hydrogen Config

Description
Remove defaultLocale from the Hydrogen Config and instead add defaultCountryCode and defaultLangugeCode
Additional context

Before submitting the PR, please make sure you do the following:

[X] Read the Contributing Guidelines
[X] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
[X] Update docs in this repository according to your change
[X] Run yarn changeset add if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning

@mcvinci FYI we are going to merge this with docs changes