Add emptyOutputOnRebuild flag

This adds an emptyOutputOnRebuild flag that would clear the OG image directory when Eleventy rebuilds. I haven't had a chance to test this yet--gonna do that tonight.
If you want, I can change this to default to true.

The rmDir implementation was adapted from here

First of all, thank you thank you for your contribution!
Can you elaborate a bit what's the use case, why is this behavior desirable? Cleanup during development, because there are always new files when changing anything in the template? Or more preventing to deploy old/not anymore used og images?

Both, but mostly the first. I have found myself opening the OG folder in my editor to see how it looks, and having to either delete the old ones and trigger a fresh rebuild or just click through all the images to find the new ones has been really inconvenient.
Thank you for this awesome plugin, by the way! It's so nice.

Yeah, development process is currently quite a mess 😅. Curious if there would be even better alternatives than cleaning the directory. I will look into it later.

There may be. I'm fine even if this is rejected--I realized I can put this same logic directly into my site's config, so I did that and it works great. 😅 But, to me, not keeping both old and new images does seem like the ideal behavior for the plugin.

(Also, apologies for not linting my code before submitting the PR 🙈 )

Had to apply some force to change the commit message after GitHub mobile didn't ask me how the merge commit should be name 🙈 – anyways it's released now! Thanks for your help 🙏


Update Charter: add link to current code of conduct

This pull requests links to the code of conduct from the charter. We did not have a code of conduct when we wrote the charter but now we do.
partly replaces #71

The change was reviewed and approved by Mike Dolan from the LF. The Governing Board accepted this change on 2019-03-15.


Apply email validation in the footer to accept only approved domains like .com, .in, etc

There is no email validation function in the footer which can accept only registered domain emails like .com, .in, .org, etc.

It would be great of you if you assign me this issue.


Use password to unlock keychain

Thanks for this! We should be releasing 2.3 to the Supermarket later today.


background_fetch SDK needed to  reload the app

https://pub.dev/packages/https://pub.dev/packages/background_fetch
above integration needed to enable background to reload the app when app in the killed state, platform level handling needed to continuing the events created for proceeding tracking

@LOG-TAG could you, plz, provide more context for this? On Android we don't use background tracking, so I've never seen SDK been killed without customer action (via settings or power-saving software). As for the iOS, after been killed app becomes active if there were more or less significant displacement of the phone.
Based on the written above, I don't see any value in adding this dependency.
@aashsub90 @tulushev FYI


add exception handling for RessourceException

under some circumstances if a host is reachable but not working properly
a RessourceException can occur if we query the qemu or LXC details.
This can lead to missing metrics for all other nodes so pass forward to
the next node if this happens. should fix #55

Thanks for filing a pull request and sorry for not answering sooner here.
If I'm reading the proposed changes correctly, then this will lead to exceptions being ignored. To be honest, I prefer to have my programs spectacularly go up in flames instead. Because that gives us a chance to detect when things go wrong. If you are interested on reading up on that particular antipattern, real python has a pretty good article on exactly that issue.

I know that it would be an antipattern but I only catch the specific RessourceException to prevent that one failing host is failing the whole scrape. If you want I can add some logging or anything else. But leaving the program crashing if you could handle an exception is also not a good pattern. I would rather get some data than nothing.

pve_exporter only connects to one single host during a scrape. When that connection fails, then no metrics will be reported no matter whether or not scraping continues after an exception has been caught / ignored. Unless I'm completely mistaken, this PR does not change that situation, instead it introduces risk that exceptions and errors go unnoticed.
I suggest that we continue the discussion in #55 and try to find the root cause over there.


Update drop-related stuff based on improvements to the language

ManuallyDrop now exists 🎉
needs_drop is a thing (soon)
drop check has changed considerably

there is now a section dedicated to the eyepatch (warning against its use)

most references to drop check have been eliminated, as it's no longer an opt-out concern
Unique replaced with Shared and *mut, as Unique is unlikely to be stabilized and unnecessary for safety
misc drive-by cleanups

CC @aturon @nmatsakis @pnkfelix @arielb1
I SUMMON THEE, COUNCIL OF DROPCK

Rebased, for #32

Hey thanks for the feedback! It seems like concepts from non-lexical lifetimes will be important here, so I'm gonna sit on correcting this until that's further along, and I have a better understanding.

@Gankro whats up with this PR?

wow i don't remember this pr very well!
uhh I think I'm still waiting on NLL's to get more well-defined?

I'm going to close this PR until nll stuff is ready to go. Thanks!


Combining interactivity levels: point + touch

So hello, it's me again with another use case deviating from the intended standard: Combined pointer and touch input.
The use case for this would be having pointer interaction for convenient remote pickup of objects, while at the same time having standard intuitive touch controls.
An example would be the default interaction model of Oculus Home, where you can pick up objects with the laser pointer (object stays position-anchored to the pointer ray at original pickup distance, rotation stays at its original value) and then use analog stick down to move it into your hand where the interaction model switches to touch/grab (object strictly constrained to hand pose, both position and rotation).
From what the readme makes me believe this should not be possible with super-hands in its current form, the example of using pointer mode with 6DOF controllers mentions specifically limiting the maximum interaction level to 3DOF.
Would there currently be a workaround for such a dual input model? From my current (novice) understanding of A-Frame multiple components of the same type are not supported, so just slapping 2 instances of super-hands (with different max levels) on an entity would probably not work. Does super-hands/A-Frame allow multiple instances of hand controllers on different entities, or would these interfere with each other?
PS: From preliminary testing trying to add multiple super-hands instances to the scene results in all kinds of interesting artifacts. Definitely not working out of the box.

What the brilliant folks as Mozilla Hubs did to implement this is to have one super-hands on the controller entity configured for touch collisions, and a child of the controller with the pointer/raycaster and another super-hands. They aren't using progressive-controls, though, they handle the controller detection and setup themselves.
A single super-hands wouldn't have any problem handling events coming in from both touch colliders and raycasters all on the same entity, except that the colliders and raycasters all use different events so a single config won't catch them all. I'd thought about modifying it to accept an array of potential collider events, but I'd also hoped the various components out there would settle on a common interface and remove the need.

That is very interesting, i didn't realize the hubs source was on github. Thanks for the link 👍 I kind of figured that doing a custom mix setup without progressive-controls would probably be the way to go. Good to have something sophisticated for reference.
Having a standard set of events for something basic like collisions would certainly help, really unfortunate that we are not there yet.


[Keyvault] Merging keyvault_preview into master for 7.0 / 2018-02-14 release

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-node

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-java

    AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.
File: specification/keyvault/data-plane/readme.md

:warning:0 new Warnings.(0 total)

:x:0 new Errors.(0 total)

File: specification/keyvault/resource-manager/readme.md

:warning:0 new Warnings.(8 total)

:x:0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback
Thanks for your co-operation.

    AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.
File: specification/keyvault/data-plane/readme.md

:warning:0 new Warnings.(0 total)

:x:0 new Errors.(30 total)

File: specification/keyvault/resource-manager/readme.md

:warning:0 new Warnings.(15 total)

:x:0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback
Thanks for your co-operation.

Automation for azure-sdk-for-go

Reassigning not very well versed with data plane specs


Windows packaging error

I recently made an electron project with a sample code as mentioned below...
`
//============================= nfc begin============================
// 'use strict';
      var _nfcPcsc = require('nfc-pcsc');

      var _nfcPcsc2 = _interopRequireDefault(_nfcPcsc);

      function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

      var nfc = new _nfcPcsc2.default();

      // var mod=require('nfc-pcsc');
      // var nfc=new mod.NFC();

      nfc.on('reader', reader => {

          // console.log(`${reader.reader.name}  device attached`);

          // needed for reading tags emulated with Android HCE
          // custom AID, change according to your Android for tag emulation
          // see https://developer.android.com/guide/topics/connectivity/nfc/hce.html
          reader.aid = 'F222222222';

          reader.on('card', card => {
              console.log("==================================================");
              var cardid=card.uid;
              console.log(cardid);

              mainWindow.loadURL('http://localhost/AA-EMR/interface/main/card_dashboard.php?card_id='+cardid);

          });

          reader.on('error', err => {
              console.log(`${reader.reader.name}  an error occurred`, err);
          });

          reader.on('end', () => {
              console.log(`${reader.reader.name}  device removed`);
          });

      });

      nfc.on('error', err => {
          console.log('an error occurred', err);
      });
      //============================= nfc end============================`

Packaging the project for liniux seems to be okay but when I package it for windows, I get the following error...
Error X A JavaScript error occurred in the main process Uncaught Exception: Error: %1 is not a valid Win32 application. MCAUsers \ Dell \ Desktop \ DMS_Releasa\ DMS-win32-x64 resourca\ app\ nod..Apcsclite.node at Error (native) at process.module.(anonymous function) [as dlopen] (ELECTRON_ASARjs:173:20) at Object.Module„ectensions..node (modulejs:583:18) at Object.module.(anonymous function) [as .node] (ELECTRON_ASARjs:173:20) at Module.load (modulejs:473:32) at tryModuleLoad (modulejs:432:12) at Function.Module,load (modulejs:424:3) at Module.require (modulejs:483:17) at require (internaVmodulejs:20:19) at bindings (C: \ Users\ Dell \ Desktop\ DMS_Releases\ DMS-win32-x64\resources\app modules\bi...:44)
Any help would be really helpful..
Thank You
Hari

Hi @haribabu500
You are building your Electron app for Windows on Windows machine and you are getting error, right?
What about running your app (without building), does it work?
I am using nfc-pcsc in my own Electron project and it builds and runs well on Windows and also on macOS.
Can you send me your code? I could try to build it by myself and find out find out the cause of error.
You can join here https://discord.gg/bg3yazg and we can solve this problem faster using chat.

No sir I am building electron project in linux machine. when I try to package it for windows, I get this error...

Hi @haribabu500
The problem is that you have to build Node native modules (which nfc-pcsc uses) on platform (os and arch), where the app will run.
You can't do cross-build with native modules (to tell the truth, you can, but you must have prebuilt binaries and most libraries don't offer it and it is very complicated).
Also, if you want build your app for Windows, you have to do it on Windows, for macOS, on macOS and so on.
Common solution is to use CI/CD server to build your app. You can connect it to your repo and it will watch branch for new commits and it will build automatically.
For Windows builds, I highly recommend you to use AppVeyor. It is Continuous Delivery service for Windows and it works pretty well.
Hope, it helps.


CUDA vs Naive Speedup?

@d-li14 hi, thanks for your contributions and for this amazing idea!
I'd like to try your involution() module in a non-mmdetection repo (YOLOv5), and was trying to figure out the best technical way to do this using your existing code here:

det/mmdet/models/utils/involution_cuda.py
det/mmdet/models/utils/involution_naive.py

The naive implementation seems easier to integrate into new works, so I'd like to use that, and my main question is:
How much of a speed change do you see in training (and inference) when moving from naive to cuda? Thanks!

Thanks for your feedback!
We have not tried involution with the YOLO framework. Moreover, the practical change may depend on specific platforms and test settings. For reference, we consider another one-stage detector RetinaNet in our work. The inference speedup on a single NVIDIA V100 GPU is roughly 40%.
Another major drawback of the naive implementation is that it costs much GPU memory due to the harmful unfold operation.


[flutter_tools] Add the NoProfile parameter to the PowerShell execution statement

Use the NoProfile parameter of pwsh.exe/PowerShell.exe to start PowerShell without a profile to avoid executing the scripts in the user profile
I fixed the issue mentioned by #120785 by adding the NoProfile parameter.
This parameter is mentioned in Microsoft's Powershell documentation: The NoProfile parameter in pwsh or The NoProfile parameter in Powershell.

@christopherfujino This change looks good to me and I verified it doesn't break anything on my machine.
Should we get a test exemption for this? We could modify the bots' Powershell profile to print something and then add a devicelab test that verifies the console output of flutter upgrade.

Should we get a test exemption for this? We could modify the bots' Powershell profile to print something and then add a devicelab test that verifies the console output of flutter upgrade.

I wouldn't stop you from doing this, but I would recommend requesting a test exemption, because:

I'm not sure how to automate provisioning all our devicelab bots with a custom profile
I suspect editing that profile may break other things?

I could go either way on this. Testing it is the right thing to do in principle, but testing this kind of low-level stuff can end up being more trouble than it's worth, and we already have enough troubles with our testing infrastructure.
I would probably establish a time box of 1 hour, try to write a test, and if it proves more difficult than is reasonably possible to do in one hour, move on without a test.
test-exempt: pragmatism

With regards to testing, I'd feel a lot better about adding a test if we could do it in a hermetic way (that is, not just editing global profile on the physical machines). Not sure if that's possible, however.

I completely agree. Right now the best solution I can think of:

Update the bot's PowerShell profile to source the file pointed by FLUTTER_POWERSHELL_PROFILE_INJECT, if the environment variable is set
Create a new devicelab test that:

Sets FLUTTER_POWERSHELL_PROFILE_INJECT to point to a PowerShell script that prints something
Runs flutter upgrade
Verifies that the Powershell script's output isn't present

I suspect this is not a 1 hour job (though feel free to prove me wrong!)

Thank you for your understanding.😊👍


Cannot invoke when

I am returning a void promise in this code:
private func autoDetectTransactedTokensImpl(wallet: Address, erc20: Bool) -> Promise<Void> {         return Promise<Void> { seal in             GetContractInteractions().getContractList(address: wallet.eip55String, server: session.server, erc20: erc20) { [weak self] contracts in                 defer {                     seal.fulfill(())                 } ...     }
And in another file, I use the when function to wait for its completion:
override func main() {             let fetchErc20Tokens = coordinator?.autoDetectTransactedTokensImpl(wallet: wallet, erc20: true)             let fetchNonErc20Tokens = coordinator?.autoDetectTransactedTokensImpl(wallet: wallet, erc20: false)             when(fulfilled: fetchErc20Tokens, fetchNonErc20Tokens).isFulfilled {                 guard let strongSelf = self else { return }                 strongSelf.willChangeValue(forKey: "isExecuting")                 strongSelf.willChangeValue(forKey: "isFinished")                 strongSelf.coordinator?.isAutoDetectingTransactedTokens = false                 strongSelf.didChangeValue(forKey: "isExecuting")                 strongSelf.didChangeValue(forKey: "isFinished")             }         }
I get back the error:

Error:(532, 13) cannot invoke 'when' with an argument list of type '(fulfilled: Promise?, Promise?)'

I thought that this might be caused by having optional types, but making them solid gives the same error.
Thanks

Yes, you need real promises here, not optionals.
I'm not sure this is the root of your problem, but you probably intend done rather than isFulfilled. isFulfilled just returns a bool indicating whether the promise has already been fulfilled; it doesn't take a closure argument.
There are versions of when that might return either a Promise<Void> or a Promise<(Void, Void)> when the arguments are two void promises. Seeing a done for which the closure doesn't expect an argument allows the compiler to disambiguate.
Try fixing that and see if it resolves the problem.

@GarthSnyder it works when I change it to done and make the variables strong. Thank you for your help.


feat: add MEV earned per epoch in the ValidatorHistoryAccount

I took a stab at #6 , saw it's been open for a few weeks
mainly out of wanting to learn, this is my first experience w/ Anchor, solana programs, instructions etc etc
I'd love a review to see if I thought about the issue correctly, but i'm happy to close it out or collaborate w/ the assignee of #6 to get this in

Since we're doing more than just setting mev_commission in this instruction, I think we should also rename the instruction to copy_tip_distribution_account

done - UpdateMevComission -> CopyTipDistributionAccount

@0xprames looks great, once all tests and checks are passing I'll approve


image! require error

Firstly thank you for this, it's great!
The only problem I've had is requiring images via Image.xcassets.  Is there currently a way to handle this?

Let me know if this works for you: https://github.com/willpiers/react-native-image-loader

There doesn't appear to be documentation there, but I imagine you would have to rewrite the require statement in your code to something like:
require('my_image.png');

And in your webpack config:
modules: {
  loaders: [
    {test: /\.png$/, loaders: ['react-native-image']}
  ]
}

The loader would transform your code to:
require('image!my_image');

@boyswan, your issue sounds familiar. If @mjohnston's suggestion isn't what you need, would you mind giving my changes in #7 a spin?

@mjohnston thanks, has no compile errors however doesn't display the image. @colinhicks #7 works perfectly! Thanks

@mjohnston I am currently looking for a react native like webpack loader for image since I use react-native-web but your previous link https://github.com/willpiers/react-native-image-loader is a 404 for me. Any idea where I can find this thing?


about decoding topk_masking

Hi
Thanks for your excellent work. I have a question about the rate schedule for topk_masking.
As described in the appendix, "To ensure that the degree of noise decreases as the generation process proceeds, we schedule k to increase from 1 to N monotonically as the diffusion step t goes from T to 1." However, in the code (https://github.com/HKUNLP/reparam-discrete-diffusion/blob/26ee286b281edc6284d74f809465b3e6d42507a6/discrete_diffusion/discrete_diffusions/discrete_diffusion_base.py#L177), the masked k tokens with the lowest confidence instead of the highest. Are there any inconsistencies here?
Best regards

Hi there,
Thanks for reaching out! In https://github.com/HKUNLP/reparam-discrete-diffusion/blob/26ee286b281edc6284d74f809465b3e6d42507a6/discrete_diffusion/discrete_diffusions/utils.py#L20-L24, the topk_masking function actually returns a mask to indicate the unselected elements. This is essentially the inverse of selecting the highest elements; we implement this way to simplify subsequent calculations for denoising tokens.
Hope this clears things up!


[GH-103]  Saving blockchain and chainstate data to disk on shutdown

General description

Persistence worker was introduced.
Saved the blockchain and chainstate data to disk on graceful shutdown.
Exposed endpoint for restoring the saved data.

Example of graceful shutdown
:init.stop()

closes #103

can you update the child specs, to match #108


Review Key implementation

Now that SessionKey is gone, the class Key could probably be simplified

It seems to me, that we could get rid of getId and leave in place the getGroup method. Furthermore it could become a simple interface.


[Help] Dynamic height as the number of Rows of the table

How do I ensure that PlutoGrid gets dynamic height as much as the row in the table?

this package is not maintained https://github.com/bosskmk/pluto_grid/issues/968 there is a fork taking over it with a lot of commits ahead, may be you want to ask there https://github.com/doonfrs/pluto_grid_plus

have you tried using layoutbuilder?
I havent tried but i think that would work


KAFKA-16531: calculate check-quorum when leader is not in voter set

In the check-quorum calculation, the leader should not assume that it is part of the voter set. This may happen when the leader is removing itself from the voter set. This PR improves it by checking if leader is in the voter set or not, and decide how many follower fetches required. Also add tests.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@chia7712 , thanks for the review. PR updated in this commit: https://github.com/apache/kafka/pull/16211/commits/7db45c2e8f08b4a381717b4c6b7f466bd116cd4e . Thanks.

@showuon can you update the description?

@showuon can you update the description?

PR description updated. Thanks.

@showuon could you please fix the build error?

Failed tests are unrelated


#203 add sqoop task

What is the purpose of the pull request
This pull request adds sqoop task.
Brief change log

Add sqoop source type : mysql,hive,hdfs.
Add sqoop target type : mysql,hive,hdfs.
Add sqoop task ui.

Verify this pull request
This change added tests and can be verified as follows:

Added SqoopTaskTest to verify the change.

Codecov Report

Merging #1974 into dev will decrease coverage by 0.71%.
The diff coverage is 0.55%.

@@             Coverage Diff             @@
##               dev    #1974      +/-   ##
===========================================
- Coverage     30.3%   29.59%   -0.72%
  Complexity    1368     1368
===========================================
  Files          294      311      +17
  Lines        14999    15359     +360
  Branches      1806     1854      +48
===========================================
  Hits          4546     4546
- Misses       10002    10363     +361
+ Partials       451      450       -1

Impacted Files
Coverage Δ
Complexity Δ

...common/task/sqoop/targets/TargetHiveParameter.java
0% <0%> (ø)
0 <0> (?)

...common/task/sqoop/targets/TargetHdfsParameter.java
0% <0%> (ø)
0 <0> (?)

...nscheduler/server/worker/task/sqoop/SqoopTask.java
0% <0%> (ø)
0 <0> (?)

.../sqoop/generator/targets/MysqlTargetGenerator.java
0% <0%> (ø)
0 <0> (?)

...inscheduler/common/task/sqoop/SqoopParameters.java
0% <0%> (ø)
0 <0> (?)

...ommon/task/sqoop/sources/SourceMysqlParameter.java
0% <0%> (ø)
0 <0> (?)

...lphinscheduler/server/worker/task/TaskManager.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...pache/dolphinscheduler/common/enums/QueryType.java
0% <0%> (ø)
0 <0> (?)

...k/sqoop/generator/sources/HdfsSourceGenerator.java
0% <0%> (ø)
0 <0> (?)

...k/sqoop/generator/targets/HiveTargetGenerator.java
0% <0%> (ø)
0 <0> (?)

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc2ef5...cf7f896. Read the comment docs.

1 add license
2 add the test class to pom

please make sure code have been checked by ali style plugin.

@break60  please review front-end~

+1


Create an option to select when the us4oem sequence reprogramming starts.

The option should be set in the us4r session configuration file.

Resolved by #226


tmp.plugin is not a function

I am trying to use jquery treeview for multiple selection for my product but when my code come to jstree the code gives me an error
$('#TreeViewPopup').click(function (f) {
debugger;
$('#TreeViewShow').modal('toggle');
$('#tree').jstree({
plugins: ['sort', 'types', 'checkbox'],
'core': {
'data': {
"url": function () {
return '@Url.Content("~/TechnicalService/RegisterProduct/TreeViewFull")' + '?ProductID=' + $("#SelectProductMainID").val();
}, "dataType": "json",
}
}
});
I have problem jstree
it gives me  tmp.plugin is not a function error . I search google but I couldnt solve it. Pls help me to get rid of this problem . Do you have any idea to solve this?

Please provide more information (which version of jstree are you using) and a demo of the issue, as I can not reproduce it. Here is a starting point for a demo:
http://jsfiddle.net/2kwkh2uL/12206/
I will reopen when a way to reproduce is available.

Firstly Thank you so much for your response Vakata really.
I have ;

Please use the jsfiddle above so that I can reproduce the issue.
If that is asking too much - then at least:

make sure you are using the latest uncompressed version of jstree
let me know which line the error is on


Update check periodically

Change update check to check every 7 days instead of once when master starts.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/7961/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/7964/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/7966/
Test PASSed.

alluxio-bot, merge this please.


Add a custom variable format-all-show-errors-on-success

Error output is often ignorable if you are using a lint tool purely as a formatter.  This new tunable prevents informative messages and warnings from distracting you.

Thanks for the PR. The feature is good!
Let's name the option format-all-always-show-errors with default value nil. OK?

That sounds good! 👍✨

I've altered the commit as you said.

Thank you very much!

The current implementation of format-all--show-or-hide-errors hides the error buffer if its contents are empty. Should we show it anyway if format-all-always-show-errors is t? It would be more consistent, but then again there would be no contents to show. I don't have a clear opinion on this one; what do you think?

I feel there is no need to open a window if there is nothing to show, but I don’t think strongly.

OK, let's have it that way :)
I'll merge this and refactor format-all--show-or-hide-errors a bit for clarity.


Contradictory info?

In response to "Why can’t I set a policy on client apps, like Word or Outlook?...", isn't this in contradiction with what's described here: https://docs.microsoft.com/en-us/azure/active-directory/conditional-access/technical-reference#approved-client-app-requirement? Please clarify the issue.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2b7832d3-260c-66c8-f145-c25d568dcbcd
Version Independent ID: 077385e1-5d33-99ac-14c3-2f373840e2f7
Content: Azure Active Directory Conditional Access FAQs
Content Source: articles/active-directory/conditional-access/faqs.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@mcurko
Thanks for your feedback! We will investigate and update as appropriate.

They are talking about two different things. This article is talking about conditional access policies in general. "The policy is not set directly on a client application. Instead, it is applied when a client calls a service. For example, a policy set on SharePoint applies to clients calling SharePoint. A policy set on Exchange applies to Outlook." The other doc , however, is talking specifically about the "Require approved client app setting."
I made a pull request to the FAQ to change the wording to "Why can't I set a policy directly on client apps, like Word or Outlook?"
CC: @MicrosoftGuyJFlo

https://github.com/MicrosoftDocs/azure-docs-pr/pull/95093

I am closing this out but if you have further questions or think additional clarity should be added, feel free to tag me or @MicrosoftGuyJFlo in the comments and we will gladly continue the discussion.


Vignette compile error

> install_github('neurodata/mgc', build_vignettes=TRUE)  # install mgc with the vignettes
Downloading GitHub repo neurodata/mgc@master
from URL https://api.github.com/repos/neurodata/mgc/zipball/master
Installing mgc
'/Library/Frameworks/R.framework/Resources/bin/R' --no-site-file --no-environ  \
  --no-save --no-restore --quiet CMD build  \
  '/private/var/folders/86/9fl8lvp11yn2lhwjd58y_z780000gn/T/RtmpVSIi57/devtools267cfa7e1e/neurodata-mgc-835d139'  \
  --no-resave-data --no-manual

* checking for file ‘/private/var/folders/86/9fl8lvp11yn2lhwjd58y_z780000gn/T/RtmpVSIi57/devtools267cfa7e1e/neurodata-mgc-835d139/DESCRIPTION’ ... OK
* preparing ‘mgc’:
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ... ERROR
Quitting from lines 51-54 (Discriminability.Rmd)
Error: processing vignette 'Discriminability.Rmd' failed with diagnostics:
could not find function "TeX"
Execution halted
Installation failed: Command failed (1)

I ran into this when making the vignettes on my mac.  Not sure if it's a mac thing.
I seemed to fix it by changing TeX("$dist(x, y)$") to ("$dist(x, y)$") in line 53 of Discriminability.Rmd

Never mind, I needed the latex2expr package.

Still, eric, let’s remove that dependency?
On Mon, Apr 2, 2018 at 11:03 PM Jesse Leigh Patsolic <
<EMAIL_ADDRESS>wrote:

Never mind, I needed the latex2expr package.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/neurodata/mgc/issues/23#issuecomment-378113331, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACjctFwWfAIpNs2Hf-w_p7jj2paugj5ks5tkuYNgaJpZM4TEX6s
.

--
the glass is all full:  half water, half air.
neurodata.io
ps - i am committed to responding to my emails,
it often takes about a week.  thank you for understanding.


Add pydocstyle to static analysis

This can standardize our docstrings, e.g. missing periods.
https://www.pydocstyle.org/en/stable/usage.html#in-file-configuration

Here's an example. Maybe we can configure it to ignore D401.
./setup.py:1 at module level:
        D100: Missing docstring in public module
./prefect_dbt/__init__.py:1 at module level:
        D104: Missing docstring in public package
./prefect_dbt/cli/credentials.py:1 at module level:
        D400: First line should end with a period (not 'I')
./prefect_dbt/cli/credentials.py:101 in public method `get_profile`:
        D401: First line should be in imperative mood (perhaps 'Return', not 'Returns')
./prefect_dbt/cli/__init__.py:1 at module level:
        D104: Missing docstring in public package
./prefect_dbt/cli/commands.py:1 at module level:
        D400: First line should end with a period (not 'I')
./prefect_dbt/cli/configs/bigquery.py:1 at module level:
        D400: First line should end with a period (not 's')
./prefect_dbt/cli/configs/bigquery.py:18 in public class `BigQueryTargetConfigs`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cli/configs/bigquery.py:18 in public class `BigQueryTargetConfigs`:
        D400: First line should end with a period (not 'd')
./prefect_dbt/cli/configs/bigquery.py:88 in public method `get_configs`:
        D401: First line should be in imperative mood (perhaps 'Return', not 'Returns')
./prefect_dbt/cli/configs/__init__.py:1 at module level:
        D104: Missing docstring in public package
./prefect_dbt/cli/configs/snowflake.py:1 at module level:
        D400: First line should end with a period (not 's')
./prefect_dbt/cli/configs/snowflake.py:20 in public class `SnowflakeTargetConfigs`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cli/configs/snowflake.py:20 in public class `SnowflakeTargetConfigs`:
        D400: First line should end with a period (not 'd')
./prefect_dbt/cli/configs/snowflake.py:72 in public method `get_configs`:
        D401: First line should be in imperative mood (perhaps 'Return', not 'Returns')
./prefect_dbt/cli/configs/postgres.py:1 at module level:
        D400: First line should end with a period (not 's')
./prefect_dbt/cli/configs/postgres.py:18 in public class `PostgresTargetConfigs`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cli/configs/postgres.py:18 in public class `PostgresTargetConfigs`:
        D400: First line should end with a period (not 'd')
./prefect_dbt/cli/configs/postgres.py:63 in public method `get_configs`:
        D401: First line should be in imperative mood (perhaps 'Return', not 'Returns')
./prefect_dbt/cli/configs/base.py:1 at module level:
        D400: First line should end with a period (not 's')
./prefect_dbt/cli/configs/base.py:29 in private method `_populate_configs_json`:
        D200: One-line docstring should fit on one line with quotes (found 3)
./prefect_dbt/cli/configs/base.py:65 in public method `get_configs`:
        D401: First line should be in imperative mood (perhaps 'Return', not 'Returns')
./prefect_dbt/cli/configs/base.py:75 in public class `TargetConfigs`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cli/configs/base.py:75 in public class `TargetConfigs`:
        D400: First line should end with a period (not 'd')
./prefect_dbt/cli/configs/base.py:107 in public class `GlobalConfigs`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cli/configs/base.py:107 in public class `GlobalConfigs`:
        D400: First line should end with a period (not 't')
./prefect_dbt/cli/configs/base.py:162 in public class `MissingExtrasRequireError`:
        D101: Missing docstring in public class
./prefect_dbt/cli/configs/base.py:163 in public method `__init__`:
        D107: Missing docstring in __init__
./prefect_dbt/cloud/models.py:1 at module level:
        D400: First line should end with a period (not 'd')
./prefect_dbt/cloud/models.py:9 in public function `default_cause_factory`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cloud/models.py:9 in public function `default_cause_factory`:
        D400: First line should end with a period (not 'n')
./prefect_dbt/cloud/models.py:9 in public function `default_cause_factory`:
        D401: First line should be in imperative mood; try rephrasing (found 'Factory')
./prefect_dbt/cloud/models.py:28 in public class `TriggerJobRunOptions`:
        D200: One-line docstring should fit on one line with quotes (found 3)
./prefect_dbt/cloud/credentials.py:1 at module level:
        D400: First line should end with a period (not 'd')
./prefect_dbt/cloud/credentials.py:63 in public method `get_administrative_client`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cloud/credentials.py:63 in public method `get_administrative_client`:
        D400: First line should end with a period (not 'd')
./prefect_dbt/cloud/credentials.py:63 in public method `get_administrative_client`:
        D401: First line should be in imperative mood (perhaps 'Return', not 'Returns')
./prefect_dbt/cloud/__init__.py:1 at module level:
        D104: Missing docstring in public package
./prefect_dbt/cloud/jobs.py:1 at module level:
        D400: First line should end with a period (not 's')
./prefect_dbt/cloud/jobs.py:47 in public function `get_dbt_cloud_job_info`:
        D401: First line should be in imperative mood; try rephrasing (found 'A')
./prefect_dbt/cloud/jobs.py:100 in public function `trigger_dbt_cloud_job_run`:
        D401: First line should be in imperative mood; try rephrasing (found 'A')
./prefect_dbt/cloud/jobs.py:196 in public function `get_run_id`:
        D400: First line should end with a period (not ',')
./prefect_dbt/cloud/jobs.py:421 in private function `_build_trigger_job_run_options`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cloud/jobs.py:421 in private function `_build_trigger_job_run_options`:
        D400: First line should end with a period (not 'b')
./prefect_dbt/cloud/jobs.py:552 in public function `retry_dbt_cloud_job_run_subset_and_wait_for_completion`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cloud/jobs.py:552 in public function `retry_dbt_cloud_job_run_subset_and_wait_for_completion`:
        D400: First line should end with a period (not ',')
./prefect_dbt/cloud/utils.py:1 at module level:
        D400: First line should end with a period (not 'I')
./prefect_dbt/cloud/utils.py:12 in public function `extract_user_message`:
        D401: First line should be in imperative mood (perhaps 'Extract', not 'Extracts')
./prefect_dbt/cloud/utils.py:28 in public function `extract_developer_message`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cloud/utils.py:28 in public function `extract_developer_message`:
        D400: First line should end with a period (not 'd')
./prefect_dbt/cloud/utils.py:28 in public function `extract_developer_message`:
        D401: First line should be in imperative mood (perhaps 'Extract', not 'Extracts')
./prefect_dbt/cloud/utils.py:63 in public function `call_dbt_cloud_administrative_api_endpoint`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cloud/utils.py:63 in public function `call_dbt_cloud_administrative_api_endpoint`:
        D400: First line should end with a period (not 's')
./prefect_dbt/cloud/clients.py:1 at module level:
        D400: First line should end with a period (not 'I')
./prefect_dbt/cloud/clients.py:21 in public method `__init__`:
        D107: Missing docstring in __init__
./prefect_dbt/cloud/clients.py:84 in public method `trigger_job_run`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cloud/clients.py:84 in public method `trigger_job_run`:
        D400: First line should end with a period (not ')')
./prefect_dbt/cloud/clients.py:84 in public method `trigger_job_run`:
        D401: First line should be in imperative mood (perhaps 'Send', not 'Sends')
./prefect_dbt/cloud/clients.py:111 in public method `get_run`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cloud/clients.py:111 in public method `get_run`:
        D400: First line should end with a period (not ')')
./prefect_dbt/cloud/clients.py:111 in public method `get_run`:
        D401: First line should be in imperative mood (perhaps 'Send', not 'Sends')
./prefect_dbt/cloud/clients.py:133 in public method `list_run_artifacts`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cloud/clients.py:133 in public method `list_run_artifacts`:
        D400: First line should end with a period (not ')')
./prefect_dbt/cloud/clients.py:133 in public method `list_run_artifacts`:
        D401: First line should be in imperative mood (perhaps 'Send', not 'Sends')
./prefect_dbt/cloud/clients.py:155 in public method `get_run_artifact`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cloud/clients.py:155 in public method `get_run_artifact`:
        D400: First line should end with a period (not ')')
./prefect_dbt/cloud/clients.py:155 in public method `get_run_artifact`:
        D401: First line should be in imperative mood (perhaps 'Send', not 'Sends')
./prefect_dbt/cloud/clients.py:176 in public method `__aenter__`:
        D105: Missing docstring in magic method
./prefect_dbt/cloud/clients.py:188 in public method `__aexit__`:
        D105: Missing docstring in magic method
./prefect_dbt/cloud/runs.py:1 at module level:
        D400: First line should end with a period (not 's')
./prefect_dbt/cloud/runs.py:15 in public class `DbtCloudGetRunFailed`:
        D400: First line should end with a period (not 'n')
./prefect_dbt/cloud/runs.py:19 in public class `DbtCloudListRunArtifactsFailed`:
        D400: First line should end with a period (not 's')
./prefect_dbt/cloud/runs.py:23 in public class `DbtCloudGetRunArtifactFailed`:
        D400: First line should end with a period (not 't')
./prefect_dbt/cloud/runs.py:27 in public class `DbtCloudJobRunFailed`:
        D400: First line should end with a period (not 's')
./prefect_dbt/cloud/runs.py:31 in public class `DbtCloudJobRunCancelled`:
        D400: First line should end with a period (not 'd')
./prefect_dbt/cloud/runs.py:35 in public class `DbtCloudJobRunTimedOut`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cloud/runs.py:35 in public class `DbtCloudJobRunTimedOut`:
        D400: First line should end with a period (not 'x')
./prefect_dbt/cloud/runs.py:53 in public method `is_terminal_status_code`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cloud/runs.py:53 in public method `is_terminal_status_code`:
        D401: First line should be in imperative mood (perhaps 'Return', not 'Returns')
./prefect_dbt/cloud/runs.py:74 in public function `get_dbt_cloud_run_info`:
        D401: First line should be in imperative mood; try rephrasing (found 'A')
./prefect_dbt/cloud/runs.py:127 in public function `list_dbt_cloud_run_artifacts`:
        D401: First line should be in imperative mood; try rephrasing (found 'A')
./prefect_dbt/cloud/runs.py:181 in public function `get_dbt_cloud_run_artifact`:
        D202: No blank lines allowed after function docstring (found 1)
./prefect_dbt/cloud/runs.py:181 in public function `get_dbt_cloud_run_artifact`:
        D205: 1 blank line required between summary line and description (found 0)
./prefect_dbt/cloud/runs.py:181 in public function `get_dbt_cloud_run_artifact`:
        D400: First line should end with a period (not 't')
./prefect_dbt/cloud/runs.py:181 in public function `get_dbt_cloud_run_artifact`:
        D401: First line should be in imperative mood; try rephrasing (found 'A')
./prefect_dbt/cloud/runs.py:272 in public function `wait_for_dbt_cloud_job_run`:
        D401: First line should be in imperative mood (perhaps 'Wait', not 'Waits')
./tests/conftest.py:1 at module level:
        D100: Missing docstring in public module
./tests/conftest.py:10 in public function `dbt_cloud_credentials`:
        D103: Missing docstring in public function
./tests/conftest.py:15 in public function `prefect_db`:
        D103: Missing docstring in public function
./tests/conftest.py:21 in public function `dbt_cli_profile`:
        D103: Missing docstring in public function
./tests/conftest.py:60 in public function `dbt_cli_profile_bare`:
        D103: Missing docstring in public function
./docs/gen_ref_pages.py:1 at module level:
        D300: Use """triple double quotes""" (found "-quotes)


Make tsdbwriter work with dependency injection (avoid actor interface)

The tsdbwriter currently takes a m3 client (an actor) as input argument. Since Acton doesn't implement interfaces / protocols for actors, we must feed it an instance of the m3 client actor. I would like to be able to test the tsdbwriter actor with no external dependencies, thus we want to be able to mock the m3 client. Given the actor interface constraint, the only way is to replace it with references to the methods to call.
so like instead of
actor TSDBWriter(m3c: tsdb.m3.Client):

we give it an action (a type of function with a particular effect)
actor TSDBWriter(send_metric: action(arg, foo, bar) -> None):

Since the only use of m3c in the code is currently to do m3c.send_metric(), this should be fine.
Now with the ability to inject a mocker, we can do tests much more easily, like we can build a mock that expects to receive a list of certain metrics and this way we can do like unit testing (uh a little more than a small unit maybe, but you get the point).
actor test_tsdb():
    var expected = [
        (some-definition-of-an-expected-metric1),
        (some-definition-of-an-expected-metric2),
        (some-definition-of-an-expected-metric3),
    ]

    def send_metric(metric):
        exp_metric = expected.pop(0)
        if metric != exp_metric:
            raise ValueError("Unexpected metric bla bla")

We can also do a nullwriter that just discards the data, or counts it, which would be useful for a benchmarking app.

We have solved this in other places by encapsulating the actor with an object, for example https://github.com/telemetrify-collector/telemetrify/blob/1f47d5d440c2e4d2bae81a0628766cdf0deb8e67/src/telemetrify/main/sink/mock.act#L29 so we always just return a generic Sink object.
The TSDBWriter requires a schema to work, so in order to test it, we also must have a schema, which @ciaran2 is already working on being able to express as static Acton code (or rather, to generate Acton source code from a generated schema, which is sort of necessary since manually creating it would be a royal PITA). Once we have some schemas as acton source code, we can and should write tests for the TSDBWriter so it can be tested independently of other things.


Disabling OpenAI API connection results in API errors such as "invalid model ID" for other connections depending on order in which the connections were added.

Bug Report
Installation Method
Installed with Docker Compose on Linux kernel 6.11.5-zen1
Environment

Open WebUI Version: v0.4.2

Operating System: NixOS 25.05 (Warbler)

Browser (if applicable): Firefox 132.0.2

Confirmation:

[x] I have read and followed all the instructions provided in the README.md.
[x] I am on the latest version of both Open WebUI and Ollama.
[ ] I have included the browser console logs.
[x] I have included the Docker container logs.
[x] I have provided the exact steps to reproduce the bug in the "Steps to Reproduce" section below.

Expected Behavior:
Disabling OpenAI API connections should not interfere with other connections.
If I add an OpenAI connection and then an Openrouter connection, disabling the former should have no effect on the latter.
Actual Behavior:
Disabling a connection interferes with the other, depending on the order of a connections.
A connection placed at the top of the list will interfere with connections below it if disabled. This applies even if the connection itself is valid, still resulting in an inability to use any connection below it.
As an example, I have two OpenAI API connections: OpenAI and Openrouter. OpenAI was added first so it is at the top of the list, while OpenRouter is below it. Disabling OpenAI results in the invalid model ID error for Openrouter when chatting with any model.
Oddly enough, having OpenAI as a connection below a disabled Openrouter connection does not lead to an error. But having a disabled invalid URL as a connection at the top of the list does cause issues. I don't have the time to really look into that, but I will update if I see anything else.
Description
Bug Summary:
Disabled connections can cause issues for other connections, somewhat dependent on the order in which they were added.
Reproduction Details
Steps to Reproduce:

Add two connections (in my case, OpenAI and Openrouter)
Disable the top one
Speak to any model on the connection below it
Witness the API error.
Reenable the top one
Reorder the list to swap the positions of the two connections
Now disable the top connection (which should differ from previously)
There is now an API error for the other connection.

Logs and Screenshots
INFO  [open_webui.apps.openai.main] get_all_models()
INFO  [open_webui.apps.openai.main] get_all_models()
ERROR [open_webui.apps.openai.main] 400, message='Bad Request', url='https://api.openai.com/v1/chat/completions'
Traceback (most recent call last):
  File "/app/backend/open_webui/apps/openai/main.py", line 630, in generate_chat_completion
    r.raise_for_status()
  File "/usr/local/lib/python3.11/site-packages/aiohttp/client_reqrep.py", line 1121, in raise_for_status
    raise ClientResponseError(
aiohttp.client_exceptions.ClientResponseError: 400, message='Bad Request', url='https://api.openai.com/v1/chat/completions'

Above is disabling OpenAI connection with an Openrouter connection below it (and speaking to an Openrouter connection.)

Pushed a potential fix to dev, testing wanted here!


feat: improve mana cost calculation error

Closes #8486
Summary

Please summarize your changes, describing what they are and why they were made.

...
Changelog
- Please write a list of changes

Testing
Platforms

Please select any platforms where your changes have been tested.

Desktop

[ ] MacOS
[ ] Linux
[ ] Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...
Checklist

Please tick the following boxes that are relevant to your changes.

[ ] I have followed the contribution guidelines for this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or modified tests that prove my changes work as intended
[ ] I have verified that new and existing unit tests pass locally with my changes
[ ] I have verified that my latest changes pass CI workflows for testing and linting
[ ] I have made corresponding changes to the documentation

 Xdd

try to reload ctrl + r :pray:


New ExecutionConfig API

What do these changes do?
This PR introduces the ExecutionConfig API to execution. With the ExecutionConfig, we can pass the cluster params to the execution backend.

[x] New ExecutionConfig, the executor accepts an ExecutionConfig instance instead of a bare dict.
[x] Rename the task_executor_config to execution_config.
[x] Remove the ClusterAPI usage from Ray executor.
[x] Move the logic of building band resources to mars/resource.py.
[x] When using Ray backend, the Mars cluster does not start the workers.

Related issue number

https://github.com/mars-project/mars/issues/2893
Check code requirements

[ ] tests added / passed (if needed)
[ ] Ensure all linting tests pass, see here for how to run them

How do I set default config which only ray backend need but mars doesn't with this API in rayconfig.yml

How do I set default config which only ray backend need but mars doesn't with this API in rayconfig.yml

The default config can be put in the rayconfig.yml like this,
task:
  execution_config:
    backend: mars
    ray:
        subtask_max_retries: 5

Then we can add some APIs in the RayExecutionConfig to read the subtask_max_retries value from self._execution_config:
{
  "backend": "ray",
  "ray": {
    "subtask_max_retries": 5
  }
}


”Runcșor”, ”Ulieș”, ”Vica” are listed in the drop-down menu

Description:
When user writes ”Runcșor”, ”Ulieș”, ”Vica” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Runcșor"

Expected results
The location appears in the drop-down menu as "Sat Runcșor, HUNEDOARA (Gurasada)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Ulieș"

Expected results
The location appears in the drop-down menu as "Sat Ulieș, HUNEDOARA (Gurasada)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Vica"

Expected results
The location appears in the drop-down menu as "Sat Vica, HUNEDOARA (Gurasada)".


Please provide am MySQL Demo-Database-Dump

@takama
Dear Igor,
Would be really helpful, if you can provide a MySQL Demo-Database-Dump (+ eventually the corresponding mapping.json File).

OK, figured out how to do it with mysql.

@gunnarhaslinger
Dear Gunnar, sorry for my late response. I didn't develop mysql module, it was contributed by community. If your issue is actual I will try to make the dump. We used ElasticSearch.


Having trouble installing mpf monitor (0.57 dev)

Updating my mpf to the 0.57 dev (Thanks, crew!)
mpf game engine and media controller work great, but monitor doesn't seem to run! Attaching error message.

Very nice
integration_google-1.0.9 2.tar.gz


python310Packages.aioslimproto: 1.0.1 -> 2.0.0

Description of changes
https://github.com/home-assistant-libs/aioslimproto/releases/tag/2.0.0

enable tests

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 171434 run on x86_64-linux 1

2 packages built:

python310Packages.aioslimproto
python39Packages.aioslimproto


Change exclude-newer behavior to include indexes missing upload-time

Summary
Currently, when --exclude-newer is given, all indexes that are missing it are treated entirely as unavailable. This makes it impossible to use this flag in combination with many indexes.
The new behavior warns about the missing field, but treats the distribution as available when the upload date it unknown.
This makes it possible to use this flag while still using packages from indexes that don't support upload-time.
Rationale
If any extra-indexes are incompatible with exclude-newer, it would be more useful to have a best-effort attempt instead of ignoring the extra indexes and likely failing the solve.
Test Plan
I'm going to see what CI says about this.

I'm a little unsure about the "correctness" of this behavior, but have felt this pain as well. Maybe we'll want to toggle this with a configuration option so it's opt-in?

Yeah I'm not sure this is the right behavior either. To me, if you're using --exclude-newer, then it's a very intentional opt-in to only wanting packages before a specific date. It's a kind of hack to get a semblance of reproducibility for example. And if packages without a timestamp are allowed even when --exclude-newer is used, then it somewhat defeats the purpose for at least some use cases.


cartesian sampling operator can't be created for trajectory already on gpu

This could also be an issue for other operators.
It should be possible to create them even after moving data to cuda.
Currently, you would have to move to CPU, create, move to GPU again..

Could be solved with kx_idx = repeat(torch.arange(....**, device=ktraj_tensor.device)**.... and also in ky and kz_idx in CartesianSamplingOp


Is there any way to reset page number to 1, dynamically?

Hi, I am using ornamentum grid for my data to display. I am facing an issue with resetting page number to 1, when I refresh the data. I am using only client side pagination.
Also, I want to know about 'ID' property of table and how it can be effectively used to control table, programatically.
When I try to import "DataTableEventStateService" from 'ornamentum' , "I am getting error "Module not found: Error: Can't resolve 'ornamentum"

For the first question, this will work

Get the ref to the ornamentum table element
this.tableRef.config.offset = 0;
this.eventStateService?.dataFetchStream.emit(DataFetchMode.SOFT_LOAD);

eventStateService is "DataTableEventStateService"


validate_tapos occasionally fails

Occasionally, validate_tapos fails in distributed-transactions-remote-test.py during validate_tapos.
see https://jenkins.eos.io/blue/organizations/jenkins/eosio/detail/PR-2424/1/pipeline (if it is still stored)

This is OBE (Overcome By Events)


Update Cloudflare Workers Nodejs guide

Based on the new Cloudflare Workers project template and the official explanation of .dev.var, like
https://developers.cloudflare.com/workers/configuration/secrets/
https://github.com/cloudflare/workers-sdk/issues/5756#issuecomment-2094930088
update the relevant paragraphs in the guide regarding the definition of Env type.

Gonna get back to this soon, sorry for the delay

Oof it's been almost 2 months, that's much slower than what I wanted it to be ………

Oof it's been almost 2 months, that's much slower than what I wanted it to be ………

Closing due to inactivity.

@theWorkFsz feel free to reopen if you want to pick this up again


Trailing newline on requirements.txt

Fixes gh-48, I hope

Closing as it appears we need pip 7 anyway, and in that case, this isn't an issue.


onNodesDelete/onEdgesDelete triggered everytime deleteKeyCode is pressed

Describe the Bug
The callbacks onNodesDelete and onEdgesDelete in Uncontrolled mode are triggered not only when some nodes/edges are selected and user press the deleteKeyCode (Backspace for example) but also when there aren't elements selected so basically everytime deleteKeyCode is pressed with focus on  component
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Press on  to have focus on it, then press the key set to delete elements (default is Backspace). You will receive as callback value for onNodesDelete/onEdgesDelete an empty array
Expected behavior
No callback events should be triggered if no elements are deleted
Screenshots or Videos
No response
Platform

OS: macOS
Browser: Chrome
Version: v10

Additional context
No response

On version 10, pressing the backspace key also fires onEdgesChange multiple times and if you hold down backspace, triggers
Warning: Maximum update depth exceeded. This can happen when a component calls setState inside useEffect, but useEffect either doesn't have a dependency array, or one of the dependencies changes on every render.
    at StoreUpdater (webpack-internal:///./node_modules/react-flow-renderer/dist/esm/index.js:1027:20)

thanks for the report @alessandropisu ! This is fixed in v10.0.5


Consider allowing permissions to be set on a per-field basis

Although I'm an avid user of GraphQL Shield - thank you for creating such a simple means of implementing permissions! - something that has always irked me is that when you implement permissions on a by-type basis, you effectively lose the relational power of GraphQL. Perhaps I'm wrong on this, but this is the issue I see, illustrated with an example:

Developer of a social & eCommerce website implements a query to allow fetching user details for a user profile page , something like this:

{
  user (input: UserWhereUniqueInput) {
    name
    age
  }
}

Developer sets a basic isAuthenticated permission on the query to ensure that only logged in users can run this query, but adds no permissions beyond that

A malicious user pokes around the publicly available schema, and finds out that the website stores payment information as CreditCard nodes that have one-to-one relations with User nodes

Malicious user simply edits the query to the following, and can now steal people's credit cards:

{
  user (input: UserWhereUniqueInput) {
    name
    age
    creditCard {
      number
      securityCode
    }
  }
}

I see two solutions to this:

Forcibly set the info of the query to return a pre-determined result
Create a permissions system that parses info, compares it to one of several templates based on the user's permissions level, and either throws an error or lets the query through

Since the first solution effectively turns GraphQL into a regular REST endpoint, thereby defeating the purpose, I ended up rolling my own solution that implements #2 using graphql-fields. It even allows for functions to be passed in that can evaluate the input at runtime, and determine whether to authorize the operation or not based on the actual query input. Here's an example with a mutation:
export default {
  Mutation: {
    createCollectionAsPartner: rule()(
      async (parent, { collectionCreateInput }, ctx: Context, info) => {

        const permissionFunction: PermissionFunction = (): boolean => {
          return collectionCreateInput.collectionVersions.create.deleted !== false;
        };

        const permissionDefinition: PermissionDefinition = {
          collectionVersions: {
            create: {
              name: true,
              deleted: permissionFunction,
              externalFiles: {
                create: {
                  applicationType: true,
                },
              },
            },
          },
        };

        const verified = verifyMutationPermissions(
          collectionCreateInput,
          permissionDefinition,
          'createCollectionAsPartner'
        );

        return verified;
      }
    ),
  },
};

Using this definition, this mutation would work, because name is defined as true in the PermissionDefinition object:
mutation {
  createCollectionAsPartner(collectionCreateInput: {collectionVersions: {create: { name: "12345"}}})
}

While this one would not, because approvedManually is not defined in the PermissionDefinition object:
mutation {
  createCollectionAsPartner(collectionCreateInput: {collectionVersions: {create: { approvedManually:true}}})
}

This example is based on typings generated by Prisma, and limits what kind of input can be passed in when creating this type to the ones defined and equal to true in the PermissionDefinition object. If a field is not defined in the object, or is defined but as either false or a sync/async function that resolves to false at runtime, the operation is denied. The end result is extremely granular control over what is and isn't allowed, without sacrificing the ability to query/mutate by relations, the greatest strength in GraphQL.
Although I wouldn't necessarily expect this to make it into the native library, I'd love to hear everyone's thoughts on this approach! I was surprised to see how little attention this critical security issue is getting within the GraphQL community, but it's possible that I'm just doing something totally wrong and this isn't a problem with a correct setup.

Hey @artemzakharov 👋!
First, thank you for such a warm feedback. It's one of the things that drive me when making open source.
I think your question is very relevant. Therefore I think we should consider posting it in Prisma Forum as well!
It would be beneficial if you could provide your schema as well, as we can better understand your issue with such context.
Could you provide that? 🙂

Hi @maticzav,
Unfortunately I can't provide my full schema since it's (ironically) a proprietary project that will have to deal with issues just like the one above, and I don't want to compromise security, but I would be happy to post snippets to clarify any questions about why I took the approach that I did.
I also can't exactly post the full schema even if I wanted to, because I don't have one per se... it's broken down by query/mutation and individual files, and assembled at runtime for a more modular development experience 🙂
My organizational structure looks like this:

And the GraphQL schema for this particular mutation looks like this:
type Mutation {
  createCollectionAsPartner(
    collectionCreateInput: CollectionCreateInput!
  ): Boolean
}

I wouldn't mind crossposting this to the official Prisma forum, but I'm not sure if I would have the time to oversee it. I'll consider doing it later this week, I just wanted to post it here first since it's a more thematic place to do so, but I'm glad (or not? 😅 ) to hear that this is in fact a real issue.

@artemzakharov I see! I am currently on a short vacation and will be posting an in detail answer to your question in a couple of days.
Hope it's not urgent! 🙂

Thanks for the highly detailed answer, @maticzav!
I wanted to clarify a couple of things:

My model doesn't actually look like that, that was more of an example 😄
I'm not actually modifying the info object in any way - I'm only interpreting it to see what information is being requested, and then comparing to a predefined list of allowed fields

Looking at your approach, however, it almost seems like an inversion of my way; instead of defining a template for a query - something like, in written form,  "If you are running a User query, and are an Admin, you can access fields x, y, and z" - you instead say "if your query is asking for field x, you must satisfy criteria a, b, and c". It's a very interesting comparison, and I'm not sure which is better, or more applicable in more situations. I think mine is definitely simpler to implement, but I can see some future issues with scaling if the number of queries and mutations grows substantially while the number of types remains relatively fixed.
Definitely something to think about some more 😄

@maticzav Thanks for the great explanation. I was with you right up until "relations are in a way still lost due to this approach". I'm not sure I understand how/why this is the case.
If I'm using Prisma and on my "application server" I implement resolvers for every field of every schema type (most of which just forward to the Prisma Docker container), relations remain intact, no?
Or are you just saying that a permissions scheme that blocks access to creditCard essentially breaks the client-server contract defined by your schema?

Hey @colinmcd94, 👋
Sorry for the confusion. What I had in mind with "losing relations" is that there's no "direct" connection between values. Every field gets resolved on its own in a way.
A follow up to your second point; GraphQL always finds a way to stay true to your schema. Therefore, I wouldn't say permission could break the contract. It just changes the result.
Is that what you had in mind? 🙂

@maticzav Been reading a bunch of issues lately, thanks for your awesome clarity! you're good at explaining graphql.

is there any way I can have the resolver query to be executed but excludes the fields with deny rule?
so for example in my invoices query im getting the invoices but based on the user role I'm limiting the total field from being viewed by non-admins. and it works by throwing an error on the whole query. Is there a way I can let the query be executed but only exclude the total field from it? (or automatically exclude all the fields that have a deny rule on them)??


Interpret testing

The final goal of the interpreter will to build up tests written in Pentagram. Then once those tests are passing and the compiler is self-compiling, the interpreter can be retired.
This could be a special mode written using watchdog. Pure custom, for better latency and to start experimenting with output format. (And to more easily gradually move the test framework into Pentagram code.)
Tasks

[x] Make asciinema of gen 2 JVM REPL
[x] Make asciinema of Outerline tests
[x] Update testing ideas
[x] Switch to pip-tools with hashes
[x] Set up internal-use CLI

[x] Precommit
[x] Freeze
[x] Check

[x] Style, lint, etc.
[x] Frozen deps

[x] Set up Github Actions
[ ] Convert typing usages to use PEP 585 and PEP 604
[ ] Automatically convert Python method names and parameters
[ ] Rename all "Tacit" references
[ ] Update syntax and data structures to current thinking

[ ] Use cat-arr instead of blob?

[ ] Collect and run tests
[ ] Trigger a crash on assertion failure
[ ] Watch for changes
[ ] Display advanced live test results
[ ] Allow basic test execution/introspection control

            "pytest-watch",


Fix packaging

Hello,
Looks like there is a syntax error in the pyproject.toml, this fails the documentation build with error
pip._vendor.tomli.TOMLDecodeError: Unclosed array (at line 7, column 21)
You can even see the issue in github:

Also it seems that both setup.py and pyproject.toml are used to provide package information and metadata, this is an inconsistent setup. Either the pyproject.toml file should be removed or the setup.py should only contain a simple setup() call without any arguments.

Thank you for pointing this out. I have fixed it.


⚠ DBA1 has degraded performance

In 722a47b, DBA1 (https://dba1.jenshamann.solutions) experienced degraded performance:

HTTP code: 200
Response time: 6729 ms

Resolved: DBA1 performance has improved in 8c22b64 after 9 minutes.


add hash implementations for time_point and duration

So here goes my try at it!
I wanted to make a is_primitive_type trait similar to is_string, but since both duration and time_point expose rep and period it resulted in partial template specialization ambiguous resolution. So I ended up with is_convertible.

Hi @alexandrebourlon, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.msopentech.com.

TTYL, MSOTBOT;

@alexandrebourlon, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSOTBOT;

Seems like most implementations don't support chrono_literals suffixes.


[V1alpha2] Refactor the Makefile targets

now deploy examples by running for example
make deploy; make deploy-examples
The deployment of the CRDs and controllers is not included in the
examples anymore

/cc jbrette

/assign kashifest

I think this is still wrong for two reasons:

baremetal is back to one of kind behavior because all the other providers implements the installation of the capi and capbk through generate.sh. kustomize build  is extremely limited and boggus and should not be used. This is why the other components are doing wget, curl...to deal with that bug in kustomize.

but mainly: You can't configure anymore the capi nor cabpk operators behavior, pullPolicy or images. Your stuck to latest version of whatever has been tagged. This is the main purpose of that line.

kustomize build "${SOURCE_DIR}/provider-components" | envsubst > "${PROVIDER_COMPONENTS_GENERATED_FILE}"

because you can change the images, pullpolicy from that kustomization.yaml.
At minimum, the Makefile should invoke the kustomize build of the provider-components directory.

Comments from @jbrette fixed.

/lgtm


Amplitude.setSongPlayedPercentage does not work in Chrome or Safari.

Issue description
Basically, Amplitude.setSongPlayedPercentage does not work. It always causes the track to jump to the beginning in Chrome. The call is totally ignored by Safari, without any error message (even though setDebug is true).
Aside: setDebug does not seem to do anything, ever.
The function works correctly in FireFox.
Before trying to set up the progress bar, I had tried to use a tracking slider, but whenever I moved the slider, as I let go off the little circle you drag around it would jump to the left end, and the track would restart. I'm pretty sure this is related to the issue with Amplitude.setSongPlayedPercentage.
Environment

Browser: whatsmybrowser.org/b/ACF8WXD (Chrome 67).
Amplitude.js Version: 3.3.0

Steps to reproduce the issue

Play a track
Run Amplitude.setSongPlayedPercentage(50) in the console.

What is expected?
The track should jump to the point expressed by the percentage.

Thanks for the detailed bug report. I am going to assign this to @danpastori for review.

I think this may not be a problem with Amplitude after all. Chrome apparently requires Content-Range HTTP headers to stream the content, but FireFox doesn't.
I tested this using your example code (in Chrome), and it worked from when your server served it, but the same code doesn't work when served by my local App Engine dev server.
I'll fix the headers on my server and make sure that was the issue. You guys may just need a minor update to the docs to let people know about this.

Thanks for being an awesome dude @carlsmith! If you want, you can submit a PR on the documentation to update it (so you get the contrib credit) on this file: https://github.com/521dimensions/amplitudejs/blob/master/docs/DOCUMENTATION.md
Or we can have @danpastori update this too. Whatever is easiest. Thanks for researching this and contributing a solution. You rock 👍
I'll flag this as "needs documentation" until it's complete.

Thanks @jaydrogers. I just got my server sorted and it was the HTTP headers (not Amplitude) that wasn't working.
I'll submit a PR on the docs tomorrow evening, no problem. Just glad to have caught it before anyone put a bunch of time into looking for a bug that wasn't there.
Thanks again, and for Amplitude. It's an awesome library.

Sorry. I forgot to get this done yesterday, but am starting now.

Closed by #272


Testng xml file running classes out of order with

I have a testng file that acts differently sometimes even though nothing has changed inside the file.  I am running it grouped by classes with preserve-order set to true.  For some reason it will sometimes run out of class order and based on the priority inside the tests instead.  For instance, the tests below will run com.test.termsOfService first and then skip to com.test.addCategory rather than running com.test.billPayEnrollment.
Shouldn't the tests run by class first and then by the priority within the class order?
<suite name="Company Smoke Tests" verbose="2">
<parameter name="WebdriverTimeout" value="30"></parameter>
<parameter name="baseConsumerUrl" value="http://local.test.url/"></parameter>
    <test name="Smoke Tests" preserve-order="true">
        <groups>
            <run>
                <include name='smoke'/>
            </run>
        </groups>
        <classes>
            <class name="com.test.termsOfService"></class>
            <class name="com.test.billPayEnrollment"></class>
            <class name="com.test.addSubcategory"></class>
            <class name="com.test.addCategory"></class>
                    <class name="com.test.changeCategory"></class>
            <class name="com.test.changeCategorySaveChanges"></class>
            <class name="com.test.deleteCategory"></class>
        </classes>
    </test>
</suite>

Do you mean the priority field in the @Test annotation? Is the interaction between preserve-order and priority documented?

Yep, so the priorities within the classes start at 1 every time since they should be running in class order, but sometimes the tests will run based on priority instead of the class order.
When you say is the interaction between preserve-order and priority documented what do you mean?  I have the reports that show the order running differently despite the file being the same, if that's what you mean.
@Test(priority = 39, groups = {"smoke"}

In my experience so far, the only way to be certain that the methods inside a class run in the designated order is to mandate that order via dependencies. Or rather, in fiddling with preserve-order, I found that it provided not guarantee that the order of the functions would be, in fact, preserved.
That said, I may just be misunderstanding the way the preserve-order arg is supposed to work.

I am facing the same problem for my project. The preserve-order works sometime and sometimes it doesn't. Its been over a year for this issue. Is there a fix for this ?

From a purist perspective, test order shouldn't matter. In practice, I think I ended up using Requires/DependsOn in my tests to make it work.

It should be fixed in the next release: https://github.com/cbeust/testng/pull/1158
And it is already available in the snapshot version if you want to try it.

@dbrusilovsky  I know the order should not matter, but when the sign-in and sign-up are themselves testcases, then the order matters. PS: Am i doing it right ?
@juherr  Thankyou for quick response.

I was having the same problem. It's a bug in TestNG. But when I used version 7.0.0-beta3 it worked fine.

org.testng
testng
7.0.0-beta3
test


Feature: Mention & Reply Notification Support

I could take care about the API fetching etc. and i can do it with the redux-toolkit RTK Query ( this could lead to the auto polling with https://redux-toolkit.js.org/rtk-query/usage/polling fron #106 ) and could give you an example how the toolkit createAPI works.


Handle network timeouts

Catch twisted.internet.error.TimeoutError and restart connection instead of letting the bot commit suicide.

Not occuring anymore


disabled a visual unit test which fails most of the time so travis su…

…ccess/fail will be more useful. increasing timeout for test that failed on timeout on travis. changed .travis.yml to make it run properly and also run unit tests and pod lib lint (mostly from swift .travis.yml)

LGTM!


fix issue with not switching theme after the initial build

@iamvivekkaushik Do you need any additional infos ?


Feature: Prompt overrides

Is your feature request related to a problem? Please describe.
My team doesn't use conventional commits, so overriding the title or other prompts would be nice to have.
Describe the solution you'd like
Something like gptcommit eject-prompt {PROMPT_NAME} which would write a file into the repo (.gptcommit/prompts/{PROMPT_NAME}.tera) with the default contents of that prompt, allowing a user to customize it.
Describe alternatives you've considered
This could be on a per-repo basis, or they could be stored in the ~/.config/gptcommit directory, even both with a chain of precendence (default -> dotfiles -> repo)
Additional context
This would allow users to customize their prompts to be better tailored to their workflow, voice, or company requirements.

Or is this already achievable using the prompt settings?
https://github.com/zurawiki/gptcommit/blob/c622fef4faf61c17ad47012fdcedaf1ec3513da9/src/summarize.rs#L34-L42

Hey @nickradford,
The features you describe should be available already. We could definitely benefit from more thought-out naming.

My team doesn't use conventional commits...

gptcommit config set output.conventional_commit false  will disable the conventional commit globally.
gptcommit config set output.conventional_commit false  --local will disable the conventional commit format for the current repo.

Something like gptcommit eject-prompt {PROMPT_NAME} which would write a file into the repo

If you want a repo-local override, run the command,
gptcommit config set output.conventional_commit false  --local
and a file will be added at .git/gptcommit.toml assuming .git is at the root of your git checkout. This toml file has all the prompts written there for you to edit.
gptcommit config list --save will write out all the prompts to your local home folder.
From there, you can edit the TOML file at ~/.config/gptcommit/config.toml
If you find any better prompts, we'd love to add them back to this repo


set useNativeDriver: true in defaultProps

improves perceived performance

closing in favour of #344 since it has more traction perhaps?


Ensure that tmpfs mounts do not have symlinks

When mounting a tmpfs, runc attempts to make the directory it will be mounted at. Unfortunately, Golang's os.MkdirAll deals very poorly with symlinks being part of the path. I looked into fixing this in runc, but it's honestly much easier to just ensure we don't trigger the issue on our end.
Fixes BZ #1686610

LGTM

One nit for consideration, otherwise LGTM if you can tame the tests.  The issues there don't appear related.

Bind mounts don't appear to use the same directory creation logic as tmpfs
mounts, at least in runc, so they don't seem to have issues. I could add
them easily enough, but I was a bit concerned with performance b
implications - we usually only have 3 or so tmpfs mounts, but a lot more
bind mounts
On Sat, Mar 9, 2019, 06:31 Daniel J Walsh<EMAIL_ADDRESS>wrote:

@rhatdan commented on this pull request.
In libpod/container_internal_linux.go
https://github.com/containers/libpod/pull/2593#discussion_r263929014:

@@ -366,6 +367,18 @@ func (c *Container) generateSpec(ctx context.Context) (*spec.Spec, error) {
// For private volumes any root propagation value should work.
rootPropagation := ""
for _, m := range mounts {

// We need to remove all symlinks from tmpfs mounts.

// Runc and other runtimes may choke on them.

// Easy solution: use securejoin to do a scoped evaluation of

// the links, then trim off the mount prefix.

if m.Type == "tmpfs" {

Why only on a tmpfs? Would this also happen on a bind mount?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/containers/libpod/pull/2593#pullrequestreview-212478411,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHYHCIhP0MkarH65w8PA0njgRgBcY6Kzks5vU5upgaJpZM4bmFi4
.

@mheon Ok fix @TomSweeneyRedHat Comment and then we can merge.

Tests green, should be good to merge

/lgtm


feat(Tooltip): handle hover-over on tooltip

Closes #669.
Refs carbon-design-system/carbon-components#266.
This PR is for preventing tooltip from being closed when the mouse is on the open tooltip.
Changelog
New

Code to detect if the mouse is is on the open tooltip
Code to debounce event handlers that open/close tooltip (Moving mouse cursor from the trigger button to the open tooltip causes mouse pointer to go to another element between them, and thus detecting mouse position right after the mouse cursor goes out of the trigger button will detect another element)

@asudoh
@tw15egan
is it possible we get this in today? I have dependency needs to finish before end of this week https://github.com/carbon-design-system/carbon-components-react/issues/669
Thanks!

Thanks @tw15egan for trying out the fix! Added some code to detect the context menu.

@tw15egan is there any ETA on the merge/publish?
Thanks!


A message should be displayed when the ranking list is empty

Actual result.
A list of users without recommendations appear on the ranking list
Expected result.
A message should be displayed when there aren't any user with a recommendation.

Actual result is not accurate, please add more details :)

Fixed even reporter confused actual result (@Gladislao 😝 ) https://github.com/belatrix/BackendAllStars/commit/d66fdf55b4888bf8d95963b1d904605c69485c5c


Overlay Diagrams: Add the ability to sort diagram cells according to the data driven position

Description
Measurables can be assigned a position, would be good to have a builder control to support ordering by this. Consider groups on a diagram can be composed of multiple entity kinds / categories.
Resourcing
We would like to add this request to the Waltz team's feature backlog

Plan:

Need to update the builder code in waltz-ng/client/entity-diagrams/components/entity-overlay-diagrams
Add a button to sort the direct children of a group by position (if available), falling back to name

Challenges:

Position may not be available as it may deal with simple refs
Position not supported across all entity kinds
Groups could contain a pick-n-mix selection of children, therefore auto sorting may yield odd results

Noticed the initial name for the starting group implies it is the diagram title, which is misleading.  Updating to Initial Group.

By adding a bit of code in the EditItemsPanel::addChildren method we can see that the directChildren variable is used to propulate the child entries.   This variable is, in turn, loaded from the MeasurableEndpoint::findByParentId endpoint.  If we make the associated DAO method do a sort then this should fix the problem:

We've added sorting to the person and data type children selector.  Though these only work off name as they have no position field.


Templates directive breaks HTML MIME type

1. What version of Caddy are you running (caddy -version)?
Caddy 0.9.5
2. What are you trying to do?
Access a static webpage page (GET /index.html)
3. What is your entire Caddyfile?
<IP_ADDRESS>:8000 {
	root .
	templates
}

4.  What did you expect to see?
MIME type text/html
6. What did you see instead (give full error messages and/or log)?
MIME type text/plain
7. How can someone who is starting from scratch reproduce this behavior as minimally as possible?
curl https://getcaddy.com | bash
wget http://example.org/ -O index.html
# Don't forget to add Caddyfile to the current folder
caddy

Forum discussion:
https://forum.caddyserver.com/t/templates-directive-causes-html-to-lose-mime-type/1426

I've attempted to reproduce the problem from scratch (point 7), but I couldn't replicate again. Curiously, I've managed to solve the issue by running dos2unix on the HTML files 😮


Add assets API to Data Node V2

Task Overview
In order to migrate the Data Node to v2
We will add the existing Asset API to the proto service definition for Data Node v2
So that the same functionality is available in the Data Node v2 service
Specs

368

This is not required as we're only adding new functionality to the data node v2 service. I misunderstood.


Turn Component.MetadataTab into a proper halogen component

This change turns Component.MetadataTab tab into a halogen component (using hooks + output actions). I've dropped the idea of moving MetaData into the global Store because the impact of such a change was really broad and I've found a way to transition into a component by just reusing output of the component and already existing MetadataAction type.
Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[ ] Relevant tickets are mentioned in commit messages
[x] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[x] Self-reviewed the diff
[x] Useful pull request description
[x] Reviewer requested

Compiling Main
[1/1 UnusedExplicitImport] src/Component/MetadataTab/Types.purs:4:1

  4  import Marlowe.Extended.Metadata (NumberFormat, MetaData)
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  The import of module Marlowe.Extended.Metadata contains the following unused references:

    MetaData

  It could be replaced with:

    import Marlowe.Extended.Metadata (NumberFormat)

           Src   Lib     All
Warnings   0     0/424   0/424
Errors     1     0       1
builder for '/nix/store/gagpl7nxibqrq1qfn9208lspfxiyz45l-marlowe-playground-client.drv' failed with exit code 1
error: build of '/nix/store/8s3llm6axw5dr3149pbfvv4amwap6md8-purs-tidy-check.drv', '/nix/store/alixhw4qwzyn5ckhkyzjydkcaq1fzqna-vm-test-run-all.drv', '/nix/store/f2qnw64nz1rrjkfi5ik8vx0jw3z3hdg9-nixpkgs-fmt.drv', '/nix/store/gagpl7nxibqrq1qfn9208lspfxiyz45l-marlowe-playground-client.drv' failed

@palas Sorry about this missed warning. Do you think that we can merge it now?


Add support for MacOS agent

[ ] module changes

[ ] spec tests

[ ] vagrant support

Is there a service we can use to test this on a mac?

Support is only for sensuctl, not the agent.
https://docs.sensu.io/sensu-go/5.7/getting-started/platforms/#sensuctl-command-line-tool


fix(orchestrator): fixes v2/instances endpoint

The start and end fields are annotated as strings instead of Date.
Addresses:

https://issues.redhat.com/browse/FLPATH-1111

/lgtm cancel

I'll wait for Gloria's approval.


Feature/master state in dag

Addressing #6 and #7
Still need to go from py -> daghandler, after that will probably raise a seperate PR to add an endpoint and FE functionality

Needs a lot more unit testing on Py -> DagHandler, but  valid.py <-> Valid.wml is done now


[PROPOSAL] Collect detailed info about Spark job and application

Purpose:
Currently events produced by OpenLineage integration for Spark are using command names:

With spark.openlineage.jobName.appendDatasetName:false:

But in SparkUI jobs have different names:

How user can track that some job in SparkUI is corresponding to OpenLineage run event?
Especially when user set custom job description using spark.sparkContext.setJobDescription or spark.sparkContext.setJobGroup:

Proposed implementation
My proposal is to add new option for OpenLineage Spark integation, e.g.:
spark.openlineage.jobName.useSparkName: true

Setting this option to true will use Spark job description as a source for OpenLineage job names.
Another way is to add Spark jobId (0, 1, 2, 3 on screenshots above) as prefix for OpenLineage job name.

If tracking is a problem, one can add Spark dedicated facet to contain: jobId and job group and job description to correlate the events with Spark UI. A link to Spark job history server would be also cool to have.
What would spark job name look like? Screenshots attached show job descriptions.

What would spark job name look like?

I mean job description, sorry.
Regarding a dedicated facet for job information, that sounds nice.

My proposal is:

Add processing_engine, spark_properties and environment-properties facets to Spark application events. Currently these facets are populated only for Spark job events, but they are usually the same for the entire application (especially processing_engine).

Add following properties to spark_properties facet:

spark.app.id - applicationId in Yarn

spark.submit.deployMode - client or cluster

spark.driver.host - where driver is started

spark.driver.appUIAddress - e.g. http://driver.host:43452 of SparkUI, served by driver

spark.org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter.param.PROXY_URI_BASES - URL of Yarn proxy for SparkUI, e.g. http://yarn.host:8088/proxy/applicationId

spark.yarn.historyServer.address - e.g. history.server.host:18081, address of Spark History server UI, can be used to build URL to showing the same interface as SparkUI, but for Spark application which is already stopped.

spark.ui.reverseProxyUrl - URL for reverse proxy SparkUI is served behind, like Kubernetes ingress.

spark.user - save here result of calling spark.sparkContext.sparkUser(), this is a name of user started the Spark session.
It's up to user which values he is interested in, because there are a lot of combinations how Spark can be deployed (local, Yarn, K8S, spark-submit with REST API, Spark Connect).
Probably these values should be set only for Spark application event, mostly to reduce size of Spark job runEvent, and also because these values cannot be changed in runtime.

Add new spark_job facet for Spark job runs with values:

jobId: int - from SparkListenerJobStart.jobId()

jobCallSite: string - from SparkListenerJobStart.properties().get("callSite.short")

jobGroup: string - from SparkListenerJobStart.properties().get("spark.jobGroup.id")

jobDescription: string - from SparkListenerJobStart.properties().get("spark.job.description")
This allows users to match RunEvent with specific jobId.
Here are examples of SparkListenerJobStart.properties():
{
    "spark.sql.execution.id": "5",
    "spark.jobGroup.id": "group",
    "spark.job.interruptOnCancel": "false",
    "callSite.short": "collect at /tmp/ipykernel_30402/148600433.py:2",
    "spark.job.description": "description",
    "spark.rdd.scope.noOverride": "true",
    "spark.rdd.scope": "{\"id\":\"56\",\"name\":\"collect\"}"
}

{
    "spark.rdd.scope.noOverride": "true",
    "spark.rdd.scope": "{\"id\":\"96\",\"name\":\"collect\"}",
    "callSite.short": "collect at /tmp/ipykernel_30402/3405814930.py:2",
    "spark.job.interruptOnCancel": "false",
    "spark.sql.execution.id": "9"
}

Drop spark_version facet as it is deprecated since 1.4.0

#2641 introduces a similar idea for spark.app.id/spark.app.name

Actually, now I think that adding all the described properties to SparkPropertiesFacet defaults is quite messy. It's probably better to move these options to another facet, and made them more user friendly:

uiUrl: string | null - URL of either Spark Master or Spark driver. It can be null if spark.ui.enabled is false.
proxyUrl: string | null - URL of Spark driver if it is served behind a reverse proxy, or YarnUI proxy, if any.
historyUrl: string | null - URL of Spark history server, if any.
userName: string - spark.sparkContext.sparkUser()

Currently sparkDeployMode is a part of debug facet. But I'm not sure if properties above should be filled up only if debug is enabled, as it can produce quite large JSON items.

But I'm not sure if properties above should be filled up only if debug is enabled, because this helps with investigating "who started a session which dropped up a table", "where can I find the logs of this application", and so on.

Also debug facet contains plan details, OL config and metrics values, so it can be too much to send on just every event.

I agree with both points - if we want to add additional debug information to general event - without debug facet being enabled - we'd need to do this in a way that does introduce information that's limited in size.