Hotfix/issue 1075 map rect fail

Fixes an issue with map_rect whenever threading is used. This PR is a hotfix and the merge request is wrt to MASTER !!! Please correct if that is not what we want here.
Summary
There is a new test which triggers the issue:
test/unit/math/prim/mat/functor/map_rect_concurrent_threads_test.cpp
If you run this test on the current master then it will fail while on this PR it works fine for a range of thread / job combinations.
Tests
Tests a range of thread / number of job combinations:
test/unit/math/prim/mat/functor/map_rect_concurrent_threads_test.cpp
Side Effects
None I am aware of.
Checklist

[X] Math issue #1075

[X] Copyright holder: Sebastian Weber
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[X] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[X] the code is written in idiomatic C++ and changes are documented in the doxygen

[X] the new changes are tested

What?? I am allowed to merge directly into MASTER? Maybe we should update the config here to not allow merging into master. I am going to put a review which asks for changes to avoid accidental merge.

No... I cannot myself request a change for my own PR... so please can someone else put a safety net here? @seantalts or @syclik ? Thanks.

I just changed the branch protection settings for master and develop to 1) require Jenkins to pass and 2) require a review. @syclik let me know if that's not what you wanted - I think it was probably just oversight or new settings from Github that we didn't set all the way.

I'm convinced these tests work. See this thread for a script to run that shows if your workload was affected by this bug. Will merge into master and then release 2.18.1


Remove version: foxglove.studio version 1.29.1

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/foxglove/studio/releases/download/v1.29.1/foxglove-studio-1.29.1-win-arm64.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 720)


feat(site): Add dark mode toggle

This adds a dark mode toggle to kit.svelte.dev. It is similar to Vitepress toggle in terms of functionality(and visually as well, although that may change), such that if user toggle to a theme(say dark), and user's system theme is also dark, the user preference is stored to be system. Now if the user switches their system theme to light, the site's theme will also switch to light. But while toggling, if the themes are not the same, the preference is stored as the theme name only, and stays that way, no matter what the system preference is

This trades theming that works without client-side JavaScript and automatically changes with the system theme for theming that requires client-side JavaScript and requires the user to click the button to make it match the theme they configured the rest of their system to use.

@babichjacob https://github.com/sveltejs/kit/pull/9607/commits/879d59bb63183e00a1b1461e65c627d632d6ffef along with https://github.com/sveltejs/site-kit/pull/85 adds support for theming that follows the system theme when there's no JS at all.
If you still want the capacity for the site to mirror your system theme, it will do that automatically once this is merged. If you visit the site after this PR is merged, and never toggle the theme toggle, it will follow the behavior stated above. And no dark mode flashes either


[refurb] Support itemgetter in reimplemented-operator (FURB118)

Summary
Lint about function like expressions which are equivalent to operator.itemgetter.
See: https://github.com/astral-sh/ruff/issues/1348#issuecomment-1909421747

Test Plan
cargo test

-return groupby(list(self.iter_choices()), key=lambda x: x[3:])
+return groupby(list(self.iter_choices()), key=operator.itemgetter(slice(3, None)))

Not a fan of this change tbh. While it may have slightly better performance, it's much less readable...
It's also much longer, but that's mainly because it prefers import operator instead of from operator import ..., which is probably unrelated to your PR.
That aside I really like having a lint rule that prefers itemgetter over lambdas. Just not for slices...


[WIP] Further compartmentalize testing

The current testing tooling utilizes system-wide Dracut and generate-zbm configuration files. This is an attempt to entirely decouple testing/ from the host OS.

Create a modules.d directory with symlinks to system-wide Dracut modules, and 90zfsbootmenu from the git checkout
Add a new configuration option to config.yaml / generate-zbm allowing any additional arguments to be passed to Dracut.
Copy config.yaml and configure it for local use
Create a new dracut.conf.d directory in place of /etc/zfsbootmenu/dracut.conf.d and populate it with a default zfsbootmenu.conf configuration file
Add a help section to setup.sh, along with handlers for individual pieces (config.yaml, dracut.conf.d, modules.d, zpool image)

The current flaw with this is that ./setup.sh -i should be run as root, and ./setup.sh -ymc should be run as the local user.

If the DracutFlags configuration option is reasonable, it also needs to be documented globally. I'm holding off on writing that for now.


build Problem in Swift

after I added pod into my project & imported Masonry
Trying to call  equalTo method
maker.leading.equalTo(view.mas_leading)
returns syntax error as the method does not accept parameters

As mentioned in read me please use snapkit https://github.com/SnapKit/SnapKit


If ARCore not installed, display a more specific message

Right now, if ARCore is not installed, running WebARonARCore just crash loops. Due to the naming similarity, it's easy to miss this step in the installation instructions. A message instead/before crashing that ARCore is required would be helpful

This issue will be resolved as soon as #38 lands.


Implement Support for Async in all wolf stages

Description:
Support async functions (or functions returning Promises) for all slot and ability functions.
Acceptance Criteria:

async for slot query
async for slot onFill
async for slot retry
async for ability nextAbility
other slot or ability functions that is defined by the user

I'm going to remove nextAbility from the success criteria.. because as @dnastrain and @gcrev93 discovered yesterday, it is not very reliable.  And we are slated to have a new (more robust) implementation for the v3 release

I agree, good catch. We'll circle back when we work on the nextAbility epic.


Removed gulp-util and added replacement dependencies (#27)

PR to fix issue reported here:
https://github.com/avajs/gulp-ava/issues/27

Came across this https://github.com/sindresorhus/ama/issues/479 and updated the PR... funny enough, the package-lock.json had caused the build to fail the first time.

Looks good. Thank you :)


GPU running stops at downloading

I keep getting this error while using the dicker for Gpu :
==========
== CUDA ==
CUDA Version 12.4.1
Container image Copyright (c) 2016-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
This container image and its contents are governed by the NVIDIA Deep Learning Container License.
By pulling and using the container, you accept the terms and conditions of this license:
https://developer.nvidia.com/ngc/nvidia-deep-learning-container-license
A copy of this license is made available in this container at /NGC-DL-CONTAINER-LICENSE for your convenience.
Starting server, please wait...
Initializing RealtimeSTT...
Exception in thread Thread-2 (_transcription_worker):
Traceback (most recent call last):
File "/usr/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
self.run()
File "/usr/lib/python3.10/threading.py", line 953, in run
self._target(*self._args, **self._kwargs)
File "/app/RealtimeSTT/audio_recorder.py", line 862, in _transcription_worker
worker.run()
File "/app/RealtimeSTT/audio_recorder.py", line 124, in run
system_signal.signal(system_signal.SIGINT, system_signal.SIG_IGN)
File "/usr/lib/python3.10/signal.py", line 56, in signal
handler = _signal.signal(_enum_to_int(signalnum), _enum_to_int(handler))
ValueError: signal only works in main thread of the main interpreter
[2024-10-08 11:59:29.057] [ctranslate2] [thread 153] [warning] The compute type inferred from the saved model is float16, but the target device or backend do not support efficient float16 computation. The model weights have been automatically converted to use the float32 compute type instead.
/usr/local/lib/python3.10/dist-packages/torch/hub.py:293: UserWarning: You are about to download and run code from an untrusted repository. In a future release, this won't be allowed. To add the repository to your trusted list, change the command to {calling_fn}(..., trust_repo=False) and a command prompt will appear asking for an explicit confirmation of trust, or load(..., trust_repo=True), which will assume that the prompt is to be answered with 'yes'. You can also use load(..., trust_repo='check') which will only prompt for confirmation if the repo is not already trusted. This will eventually be the default behaviour
warnings.warn(
Downloading: "https://github.com/snakers4/silero-vad/zipball/master" to /root/.cache/torch/hub/master.zip

The program gets stuck at the downloading and does not move ahead

I encounters same issue it seem like now, It can't initiate instance of AudioToTextRecorder() class
this is error message when I try initiate instance:
Traceback (most recent call last):
  File "/home/tawan/.pyenv/versions/miniconda3-latest/envs/STT-browser/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
    self.run()
  File "/home/tawan/.pyenv/versions/miniconda3-latest/envs/STT-browser/lib/python3.10/threading.py", line 953, in run
    self._target(*self._args, **self._kwargs)
  File "/home/tawan/.pyenv/versions/miniconda3-latest/envs/STT-browser/lib/python3.10/site-packages/RealtimeSTT/audio_recorder.py", line 862, in _transcription_worker
    worker.run()
  File "/home/tawan/.pyenv/versions/miniconda3-latest/envs/STT-browser/lib/python3.10/site-packages/RealtimeSTT/audio_recorder.py", line 124, in run
    system_signal.signal(system_signal.SIGINT, system_signal.SIG_IGN)
  File "/home/tawan/.pyenv/versions/miniconda3-latest/envs/STT-browser/lib/python3.10/signal.py", line 56, in signal
    handler = _signal.signal(_enum_to_int(signalnum), _enum_to_int(handler))
ValueError: signal only works in main thread of the main interpreter

Thanks for reporting. I wasn't aware of signal causing issues in another thread on other platforms. Fixed in current repo code, release for pypi (pip install) coming later.


Bug reintroduced with recent commit

mergeFixtureWithOverrides was updated to use array_merge with the attributes. This was the original behavior in v1.0 and resulted in throwing Illuminate\Database\QueryException Unknown column errors. This bug was fixed in https://github.com/laracasts/TestDummy/pull/29 but it was recently changed back in https://github.com/laracasts/TestDummy/commit/e21fedc5ed56922549e6a4926b24be8f4b3f8ead to "Allow overriding fields not defined in a factory". For me, the better solution to that problem would be to just add the fields to the factory.
This PR reverts back to the working version.
fixes: https://github.com/laracasts/TestDummy/issues/77

Honestly, I don't have any real opinion on this. Haven't noticed issues with either approach.
@adamwathan Any thoughts on this PR being merged?

Just an fyi, if this PR isn't accepted then attributes can't be passed to relationships and https://github.com/laracasts/TestDummy/pull/52 would become irreverent.

Regarding to #77, when I removed the attributes everything worked fine, but with attributes the relations can't be created correctly

There must be a way to preserve both behaviors, gonna dig in to it a bit now.
The change was triggered by this issue which gives some more detail: https://github.com/laracasts/TestDummy/issues/64
My intention is just to lean on the wisdom of the maintainers of Factory Girl, who started using the pattern in 2008.

It is highly recommended that you have one factory for each class that provides the simplest set of attributes necessary to create an instance of that class. If you're creating ActiveRecord objects, that means that you should only provide attributes that are required through validations and that do not have defaults.

The goal of a factory is to define the minimum attributes necessary to have database-valid instance of that class. If you have to define attributes that are nullable or have defaults provided by the database, you have introduce duplication of knowledge for no real reason.
Anyways, going to try and come up with a solution that allows both. It shouldn't be necessary to define every attribute to support a different feature.

After reading define the minimum attributes necessary to have database-valid instance of that class I think I have a better understanding of where you are coming from with Allow overriding fields not defined in a factory https://github.com/laracasts/TestDummy/commit/e21fedc5ed56922549e6a4926b24be8f4b3f8ead. You are keeping the factories lean as to not overcomplicate them right?
I'm all for simplicity but I also think that a factory that defines every attribute is more explicit and better "documents" what the modal is actual all about. This makes it easier for future devs or myself months later from now.
...now I'm not sure what the best solution is. Simplicity or explicitly....

It's not so much keeping them lean to avoid overcomplicating, I think it's more about what I think a test factory is meant for.
To me, the job of a test factory is "let me easily instantiate an object that is just valid enough that I can only worry about setting the attributes that matter to my test and everything else will just work" you know what I mean?
I totally understand what you want and I agree it's a useful feature, I just think we need to define a more explicit syntax.

@devinfd I've opened an issue to discuss coming up with a better syntax for overriding attributes in relationships here: #82
Would love your input!


SHC AI Contest Announcement By Krarilotus

SHC AI Contest Announcement By @Krarilotus .
https://www.youtube.com/watch?v=xs-rOotzJFQ

oh lol, thats no issue with the UCP btw.
But thx for mentioning it. I hope to get more values figured out :)

maybe, but for us English only players this is pretty much the only place you can reach us.

https://www.youtube.com/watch?v=8WgSMmWNzvQ
Just fyi, if you want some basics to beat the challenge from the contest, you might find them here.
I hope i can help you out with this. Its far from perfect, maybe i have to redo it, for making it worth beeing an official tutorial, but lets first find out the missing values!

I saw the video. Very informative. I was wondering if we can have a Google doc that list all the missing values and what they are for similar to the notepad you were using.

Good idea, i will make a sheet tomorrow that everyone can fill with suggestions for values, and one that lists comfirmed values, and who confirmed them.

I saw the video. Very informative. I was wondering if we can have a Google doc that list all the missing values and what they are for similar to the notepad you were using.
Here is the sheet for discussion:
https://docs.google.com/document/d/1hlxXA5rfIfGwm0oU_faScNCZArDJIk8lqbbWQ4gVdMc/edit?usp=drivesdk

Here are all the values so far put together:
https://docs.google.com/document/d/1idW3fsOcRgBf2ZzM-q4zD6jtjbH9yLBlAhT31d7KYbo/edit?usp=drivesdk

I saw the video. Very informative. I was wondering if we can have a Google doc that list all the missing values and what they are for similar to the notepad you were using.

Here is the sheet for discussion:
https://docs.google.com/document/d/1hlxXA5rfIfGwm0oU_faScNCZArDJIk8lqbbWQ4gVdMc/edit?usp=drivesdk
Here are all the values so far put together:
https://docs.google.com/document/d/1idW3fsOcRgBf2ZzM-q4zD6jtjbH9yLBlAhT31d7KYbo/edit?usp=drivesdk

0_0 Wow !!! You GOD!!!
It is necessary that byburton add new variables, and update AIC ...

It is necessary that @ByBurton add new variables, and update AIC ...
Actually, @ByBurton didnt want to get mentioned with the new values, but most of them i got hinted by her, so i guess she is already very busy doing exactly that :)
There should be a prototype of 2.13 somewhere. For now i guess we can still use 2.12, since it offers all the values modable already, just doesnt name them yet.

А об чём речь тут?) я не понимаю вообще)  Изменения набора солдат каждому из Ботов?

мы говорим о том, что они набирают, как быстро они набирают, и как они используют свою эко и свою армию в целом.
Вы можете настроить некоторые характеристики, изменив файл .aic, предоставленный патчем для сообщества.
но некоторые значения до сих пор неизвестны, если вы понимаете по-английски, вы можете посмотреть данные видео сверху, чтобы узнать больше
we are talking about what they recruit, how fast they recruit, and how they use their eco and their army in general. Some of these characteristics, you can adjust by modifying the .aic file from the community patch, but some are still unknown. In the videos linked above, some of this is explained

I added them, but they require a lot more testing. @Krarilotus
Most values do kinda what you said, but especially the variable you said determines the siege army rallies at seems veeery questionable.
What I could confirm kind of:
-Unknown131 if set to 0 army does not rally at an enemy fallen lord's gravestone anymore (determines rally after victory)
-Unknown129 the enemy retreats back after victory, but attacks as soon as the percentage that this value represents of the remaining forces compared to the original count of units is met
-Unknown130 I could not verify or test yet
-Unknown127 as mentioned above can not say if the ai really rallies somewhere else.

I added them, but they require a lot more testing. @Krarilotus
Most values do kinda what you said, but especially the variable you said determines the siege army rallies at seems veeery questionable.
What I could confirm kind of:
-Unknown131 if set to 0 army does not rally at an enemy fallen lord's gravestone anymore (determines rally after victory)
-Unknown129 the enemy retreats back after victory, but attacks as soon as the percentage that this value represents of the remaining forces compared to the original count of units is met
-Unknown130 I could not verify or test yet
-Unknown127 as mentioned above can not say if the ai really rallies somewhere else.

Unknown127 might only interfere with the rally point, but coud be something completely different. Unknown130 is kind of hard to test, since siegengines are already bugged and getting good testingconditions is hard. I tested this while i made an AI to proof how the AI Contest challenge coud be beaten, and especially when set to 100, the behaviour is clearly seen as waiting for all siege units to die before mainattack units start moving.
And for 129, it might be the percentage for all attackingforce groups. But i am not sure. With the settings in my aic video, the ai shoud have attacked immediatly again after killing of one of the wolfs in the match rat vs 7 wolfs, but it didnt. I can only imagine it was due to the fact, that all its assassins died in the encounter. Maybe some other factors count aswell, for example if its defense is low, if it fears an incoming attack, if it is the strongest ruler etc.
Because these variables are hard to pin down, they are not made official. And i woud highly appriciate more ideas for testing these and more people trying to confirm them, before announcing them officially.

@ByBurton and @Krarilotus You are great fellows. Without you there would be no future for Stronghold Unofficial patch and AIC ... Thank you so much !!!

@ByBurton and @Krarilotus You are great fellows. Without you there would be no future for Stronghold Unofficial patch and AIC ... Thank you so much !!!

I think most credit should go to sh0wdown. I am just a random guy using the patcher as we all do

I think most credit should go to sh0wdown. I am just a random guy using the patcher as we all do
@Sh0wdown
I am very grateful to him for what he has done a miracle!

Лоласик я ваще не врубился)  я к тому, что  - проблема вроде вижу мод делается и делается большая обновка для игры и это здорово! Но оно по-моему как -то разбросано по форуму что я не могу собрать всю информацию полностью воедино об этом моде) Вижу и новый ИИ и некоторые исправления и ещё что и  крепости новые - а получается как то разбросано)) Может, где-то всё складывается в одном месте?). А так конечно да и от меня большая благодарность всем тем, кто делает именно первую часть лучше.
=
Lolasik, I finally did not get it) I mean that - a problem like I see the mod is being done and a large upgrade is being made for the game and this is great! But in my opinion it is somehow scattered around the forum that I can not collect all the information completely together about this fashion) I see a new AI and some corrections and more that new fortresses - but it turns out like that is scattered)) Maybe somewhere everything is in one place?). And of course, yes, and from me a big thanks to all those who are doing exactly the first part better.

Russian story, correct me if I have misunderstood, but basically the latch has an added feature using byburton's aic editor which allows you to modify AI behaviour. As well as this firefly long ago released an SUV editor which allows you to design AI castles.
These are designed to be available for general users to design  their own AI players, the result is not part of the patch.
The video krarilotus posted focuses mainly on the aic editing side as it isn't very user friendly and still not fully understood even by the creator.
Ultimately the idea is that this allows the average user to create and upload their own AIs for other players to enjoy. You can already download castles on heavengames.

@GRhin
I figured it out. I thought that a great update for stronghold would include both fortresses and AI and fix bugs and glitches in the game and add new ideas and change the balance and parameters. I thought that the modification would be comprehensive and most complete. =) If so, I will be happy to install this large and useful option over the game in one action. =) I always hold the position of merging and creating a large project - fashion or patch ...
Я это понял Я думал что большое обновление для стронгхолда будет включать и крепости и ИИ  и исправление багов и глюков в игре и добавление новых идей и изменения баланса и параметров. Я думал что Модификация будет всеобъемлющая и наиболее полная. =) Если будет так то буду рад одним действием установить поверх игры этот большой и полезный вариант. =) Я всегда придерживаюсь позиции объединения слияния и создания большого проекта - мода или патча... Хотя сам бестолковый....с меня звуки с моего мода...

The patcher already includes custom castles, evrey's and tatha's as i believe, and overall ai fixes. But the main point as @GRhin said is the modability for a broader audience.
It is difficult to define the 'best' set of castles, as everyone and their dog has made castles, and they differ in many aspects from efficiency, to character and style over historical corectness up to complete different ai designs.

I thought that a great update for stronghold would include both fortresses and AI and fix bugs and glitches in the game and add new ideas and change the balance and parameters. I thought that the modification would be comprehensive and most complete. =) If so, I will be happy to install this large and useful option over the game in one action. =) I always hold the position of merging and creating a large project - fashion or patch ...  There are fixed and updated castles from Pitchneeded, evrey and tatha, and there is a "Vanilla-bugfix.aic" in the installer.
I see what you want in having all things in one place, and with the current relatively small modding community it may be practical, however if these features bring more modders into the community, having everyones work available would result in a lot of options in the patch, and alot of unnecessary updates to include them. Krarilotus has made several AIs that I know of, and there are 4 or 5 members of the community that I think are using these features. If they all made even 2 or 3 AIs each, the mod would become cumbersome and put alot of people off using it, alot more than making people to upload their own projects somewhere else and import into the patch as they desire (just create an aic folder, then copy the aic and aiv files into the appropriate directories). Maybe a good midground would be to create some software that compiles AI projects into an install file to make installing them simpler?

FYI, competition results - https://youtu.be/oIdxYXPmHVc

this has been complete, you can make a new issue when the 3rd contest is out. 2nd Contest has been won by Starshine, comclusion video is still missing cuz not enough time... but comingsoon!


fixed ConcurrentModificationException in AbstractMeta

In the case of multi-thread, when one thread traverses the collection and another thread operates on the collection, an error occurs, causing the job to stop. The following is the error message:
2018/09/13 10:10:23 - MAIN_SJCJ - ERROR (version <IP_ADDRESS>-28, build <IP_ADDRESS>-28 from 2017-11-05 07.27.50 by buildguy) : /KETTLE8_RES/MAIN_TRAN/MAIN_SJCJ
org.pentaho.di.core.exception.KettleException:
Unexpected error occurred while launching entry [SSCJ_2.0]
at java.lang.Thread.run (Thread.java:748)
at org.pentaho.di.job.Job$1.run (Job.java:850)
at org.pentaho.di.job.Job.access$000 (Job.java:121)
at org.pentaho.di.job.Job.execute (Job.java:732)
at org.pentaho.di.job.entries.job.JobEntryJob.execute (JobEntryJob.java:617)
at org.pentaho.di.base.AbstractMeta.setInternalKettleVariables (AbstractMeta.java:409)
at org.pentaho.di.job.JobMeta.setInternalKettleVariables (JobMeta.java:2341)
at org.pentaho.di.job.JobMeta.updateCurrentDir (JobMeta.java:2351)
at org.pentaho.di.base.AbstractMeta.fireCurrentDirectoryChanged (AbstractMeta.java:644)
at java.util.ArrayList$Itr.next (ArrayList.java:851)
at java.util.ArrayList$Itr.checkForComodification (ArrayList.java:901)
at org.pentaho.di.job.Job$1.run(Job.java:854)
at java.lang.Thread.run(Thread.java:748)

Caused by: java.util.ConcurrentModificationException
at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901)
at java.util.ArrayList$Itr.next(ArrayList.java:851)
at org.pentaho.di.base.AbstractMeta.fireCurrentDirectoryChanged(AbstractMeta.java:644)
at org.pentaho.di.job.JobMeta.updateCurrentDir(JobMeta.java:2351)
at org.pentaho.di.job.JobMeta.setInternalKettleVariables(JobMeta.java:2341)
at org.pentaho.di.base.AbstractMeta.setInternalKettleVariables(AbstractMeta.java:409)
at org.pentaho.di.job.entries.job.JobEntryJob.execute(JobEntryJob.java:617)
at org.pentaho.di.job.Job.execute(Job.java:732)
at org.pentaho.di.job.Job.access$000(Job.java:121)
at org.pentaho.di.job.Job$1.run(Job.java:850)
... 1 more

Hello, This is an automated comment from our build system. Since this pull request originated from a user  not in the Pentaho organization, we will not proceed  with automatic validation of the pull request.  However, rest assured that it will be reviewed manually as soon  as we get the chance. Thanks for your contribution!

@zhaxiaodong9860 - Thank-you for the contribution and letting us know about the issue. Normally, you need to report defects like this at https://jira.pentaho.com. In this case, I created a JIRA case for you: https://jira.pentaho.com/browse/PDI-17646
That said, I cannot accept the contribution as is - synchronization on the collection there may have solve the issue for you, but could lead to a performance issue in highly concurrent environments. I've added a comment to the JIRA case indicating that this class needs more work than just the one thing you fixed. Thank-you again for pointing out the issue with this file.


justify: true will make newlines in raw code

Description
Commit hash: 7bdf1f57b09ea605045254013a8200373451baf0
I tried to compile a previously written document after updating the typst version, and found that the formatting in some code blocks was broken.
justify: true will make newlines in raw code.
#set par(justify: true)

\```cpp
int main() {
  printf("Hello world\n");
  return 0;
}
\```

Since markdown does not support enclosing three backtick substrings in a code block, a backslash is added before the three backticks in the above code.
The final rendered code has some redundant newlines added:
int main() {
printf("Hello
world\n");
return
0;
}

I tried the release 0.7.0 version and the web app and everything behaves fine, but not in the latest commit.
Reproduction URL
No response
Operating system
Linux
Typst version

[X] I am using the latest version of Typst

Confirming the issue; I worked around it using
#show raw: txt => {
    set par(justify:false)
    txt
}

Note that this can be simplified to #show raw.where(block: true): set par(justify: false).

Did some digging and found that #1821 is the culprit, removing that bit makes code blocks work again. If I'm understanding things right, the (broken) old justification didn't work due to something which is likely a bug in upstream crate icu4x. So if icu4x fixes that, then the fix in this repo can get reverted and this issue just goes away.
Should ask though, is it intended for justification to be able to affect code blocks in the first place?

The bug occurs because I assumed that newlines could only occur at the beginning of the paragraph, when this wasn’t the case (such as with code blocks). This patch fixes the behavior:
diff --git a/crates/typst-library/src/layout/par.rs b/crates/typst-library/src/layout/par.rs
index d3cd6cbf..1e11c454 100644
--- a/crates/typst-library/src/layout/par.rs
+++ b/crates/typst-library/src/layout/par.rs
@@ -904,6 +904,7 @@ fn linebreak_optimized<'a>(vt: &Vt, p: &'a Preparation<'a>, width: Abs) -> Vec<L
         pred: usize,
         total: Cost,
         line: Line<'a>,
+        mandatory_linebreak: bool,
     }

     // Cost parameters.
@@ -919,6 +920,7 @@ fn linebreak_optimized<'a>(vt: &Vt, p: &'a Preparation<'a>, width: Abs) -> Vec<L
         pred: 0,
         total: 0.0,
         line: line(vt, p, 0..0, false, false),
+        mandatory_linebreak: true,
     }];

     let em = TextElem::size_in(p.styles);
@@ -934,7 +936,7 @@ fn linebreak_optimized<'a>(vt: &Vt, p: &'a Preparation<'a>, width: Abs) -> Vec<L
             let start = pred.line.end;

             // Fix for https://github.com/unicode-org/icu4x/issues/3811
-            if i > 0 {
+            if !pred.mandatory_linebreak {
                 if let Some(s_pred) = table.get(i + 1) {
                     let next_start = s_pred.line.end;
                     if !p.bidi.text[start..next_start]
@@ -1024,7 +1026,12 @@ fn linebreak_optimized<'a>(vt: &Vt, p: &'a Preparation<'a>, width: Abs) -> Vec<L

             // If this attempt is better than what we had before, take it!
             if best.as_ref().map_or(true, |best| best.total >= total) {
-                best = Some(Entry { pred: i, total, line: attempt });
+                best = Some(Entry {
+                    pred: i,
+                    total,
+                    line: attempt,
+                    mandatory_linebreak: mandatory,
+                });
             }
         }

but if we have to keep piling on kludges after one another, we might as well get the original problem solved on icu4x’s side.

@bluebear94 why do we need specific code in linebreak_optimized at all? can't we revert your fix and just patch the linebreak iterator, so that it behaves as if icu4x wasn't broken?

@laurmaedje Yeah, your idea looks like the best bet.


Correct paths in the the runut and runft test scripts

This corrects the path to Terminal.Core.Unit.Tests.dll in the runut
unit test script and makes the runft feature test script capable of
working with Release builds as well as Debug builds.
The path to Terminal.Core.Unit.Tests.dll changed when the project was
restructured, and the runut script was never updated to reflect that
change. That has now been corrected.
And the runft script used to be hard coded to look for tests in the
Debug directory, but it has now been updated to use the
%_LAST_BUILD_CONF% environment variable, so it should work for both
Debug and Release builds.
Validation Steps Performed
I've manually confirmed that the runut and runft scripts now work as
expected.
Closes #8485

@msftbot merge this in 2 minutes

No longer have a computer virus. I am returning message with a small Apple Iphone
Jimmy R. Spooner
CONFIDENTIALITY: The information contained in this transmission may contain privileged and confidential information. It is intended only for the use of the person(s) named above. If you are not the intended recipient, you are hereby notified that any review, dissemination, distribution or duplication of this communication, and the information contained in it, is strictly prohibited. If you are not the intended recipient, please contact the sender and immediately destroy all copies of the original message.
On Thursday, December 3, 2020, 1:29 PM, Carlos Zamora<EMAIL_ADDRESS>wrote:
@carlos-zamora approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I have a computer virus caling on small Apple iPhone
Jimmy R. Spooner4590 Cazes AvenueNorth Port, Fl. 34287Cell<PHONE_NUMBER>jimmyspooner<EMAIL_ADDRESS>CONFIDENTIALITY: The information contained in this transmission may contain privileged and confidential information. It is intended only for the use of the person(s) named above. If you are not the intended recipient, you are hereby notified that any review, dissemination, distribution or duplication of this communication, and the information contained in it, is strictly prohibited. If you are not the intended recipient, please contact the sender and immediately destroy all copies of the original message.
On Thursday, December 3, 2020, 1:38 PM, msftbot[bot]<EMAIL_ADDRESS>wrote:
Hello @DHowett!
Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

I won't merge this pull request until after the UTC date Thu, 03 Dec 2020 18:39:48 GMT, which is in 2 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@Jspooner09 please leave our repository alone.


Bug: Unknown language in MudCodeHighlight

Thanks for this great library 😀.
I am encountering an exception when using a Markdown code block with an unknown language, in this case razor:
Unhandled exception rendering component: Unknown language: "razor"
      p@http://localhost:5000/_content/MudBlazor.Markdown/MudBlazor.Markdown.min.js:1:15271
      m@http://localhost:5000/_content/MudBlazor.Markdown/MudBlazor.Markdown.min.js:1:12107
      @http://localhost:5000/_content/MudBlazor.Markdown/MudBlazor.Markdown.min.js:1:864294
      @http://localhost:5000/_framework/blazor.web.js:1:3244
      Promise@[native code]
      beginInvokeJSFromDotNet@http://localhost:5000/_framework/blazor.web.js:1:3212
      @http://localhost:5000/_framework/blazor.web.js:1:62919
      _invokeClientMethod@http://localhost:5000/_framework/blazor.web.js:1:63726
      _processIncomingData@http://localhost:5000/_framework/blazor.web.js:1:60408
      @http://localhost:5000/_framework/blazor.web.js:1:82184
Microsoft.JSInterop.JSException: Unknown language: "razor"
      p@http://localhost:5000/_content/MudBlazor.Markdown/MudBlazor.Markdown.min.js:1:15271
      m@http://localhost:5000/_content/MudBlazor.Markdown/MudBlazor.Markdown.min.js:1:12107
      @http://localhost:5000/_content/MudBlazor.Markdown/MudBlazor.Markdown.min.js:1:864294
      @http://localhost:5000/_framework/blazor.web.js:1:3244
      Promise@[native code]
      beginInvokeJSFromDotNet@http://localhost:5000/_framework/blazor.web.js:1:3212
      @http://localhost:5000/_framework/blazor.web.js:1:62919
      _invokeClientMethod@http://localhost:5000/_framework/blazor.web.js:1:63726
      _processIncomingData@http://localhost:5000/_framework/blazor.web.js:1:60408
      @http://localhost:5000/_framework/blazor.web.js:1:82184
         at Microsoft.JSInterop.JSRuntime.InvokeAsync[TValue](Int64 targetInstanceId, String identifier, Object[] args)
         at Microsoft.JSInterop.JSRuntimeExtensions.InvokeVoidAsync(IJSRuntime jsRuntime, String identifier, Object[] args)
         at MudBlazor.MudCodeHighlight.OnAfterRenderAsync(Boolean firstRender)
         at Microsoft.AspNetCore.Components.RenderTree.Renderer.GetErrorHandledTask(Task taskToHandle, ComponentState owningComponentState)

I have checked whether the markdig library is responsible for the error. However, it seems like markdig is not the source of the problem, as demonstrated by the following working code:
var result = Markdown.ToHtml("""
```foo
this is a test
```
""");
Console.WriteLine(result);

Therefore, I believe the issue arises from the MudCodeHighlight component in MudBlazor.Markdown. Unfortunately, I couldn't pinpoint the exact location in the code where the error was being produced, likely due to my limited familiarity with the codebase.
When an unknown language is encountered, I expect the code to be rendered without syntax highlighting.
Can we resolve this issue easily 🤷♂?

Recently code related to highlight.js has been changed, so most likely it's the cause of the issue. The exception seems to come from the js file and it makes the assumption more plausible.
I need to investigate why highlight.js that is used in the package does not recognise razor 😢

According to https://github.com/highlightjs/highlight.js/blob/main/SUPPORTED_LANGUAGES.md it seems that highlightjs-cshtml-razor also needs to be added to npm packages.. so let's see whether it solves the issue.


mraa.c: Added common function to init io from a description

mraa_init_io: Added to allow io to be initialised using a description
Aio Constructor: changed the unsigned int constructor to a normal int type, ambiguity errors arose due to the double meaning of unsigned 0 in c++, either the unsigned 0 or a void* to a NULL
mraajava.i: Added ignore's for the void* constructors for Aio,Pwm etc., this was because java doesn't know how to handle them
python/mraa.i: Added ignores for the void* constructors because they have no use in python
Signed-off-by: Houman Brinjcargorabi<EMAIL_ADDRESS>

Commit message makes no sense to me personally, when taken together with the title, I'd suggest to rephrase it.
What's the goal of this one in general?
And there are magic constants everywhere in the helper function, that calls for a correction. The helper itself is long and has no comments whatsoever, adding them and explaining operations being done there would make it much easier to read and comprehend for anyone looking at the code.

Thanks for the feedback, i've updated the description to hopefully give a bit more clarity. Can you give me a bit more information regarding which magic constants your talking about?

I've commented on a couple of lines with magic constants (but not all of them, there are more).
With corrected description it now makes more sense, but at the same time it's clear there are four unrelated changes in a single commit, you need to split them into four commits.
Where is that "description" init way is useful, could you provide any examples where that works better than the current way?

I think it could do with some more logging output when errors occur. Like if the string inst recognised, the mode or whatever.

Merged. Thanks everyone for reviewing & pushing this through. You rock!


Localization pt-BR.json

A translation to Brazilian Portuguese. It has to be added as follows in module.json:
        {
            "lang": "pt-BR",
            "name": "Português (Brasil)",
            "path": "lang/pt-BR.json"
        }

Thanks, @Kharmans!


13:12  error  Parsing error: Unexpected trailing comma after rest property?

/app/components/layout/cont.MasterDetail.js
13:12  error  Parsing error: Unexpected trailing comma after rest property
✖ 1 problem (1 error, 0 warnings)

@scheung38 thanks for reporting, will take a look later today!

Webstorm setting is Preference - Tools and File Watch Babel.
Also ES6 standard setting correct?

Just doesnt like the ...rest statement

Fixed https://github.com/neekey/demo-react-master-detail-view/commit/b191c101773ff1acdf05bbacc74bf7e66ed94427, you don't have to use webstorm babel watcher, it's just a syntax warning threw up by eslint.


Bug Invalid language switching

{local} seems to have incorrect values

Version 0.6.0

You need to use the variable {locale} not {local}. If this was not the problem, can you be a bit more specific? Did you create your own prompt and the {locale} variable wasn't replaced or did you use one of the default prompts? If you used a default prompt, which one?

I have released a new version 0.6.2  that contains a fix. You can wait for JetBrains to aprove the new version and publish it on marketplace or install it manually by following these steps.
Thank you for the report :pray:


[BUG?] Ramdon Wrong Blocks (Termux Android with ncnn-vulkan-armv8a-android 20200226 prebuild library)

I built the waifu2x-ncnn-vulkan in termux. The speed is impressive.
I built it with ncnn-vulkan-armv8a-android 20200226 prebuilt library and lastest glslang. The libvulkan.so comes from /system/lib64. Build process finished in termux.
The result is interesting:
Sometimes it works propoerly, but sometimes it gives result like this:

It happens also most randomly, independ with input pictures and TTA config, but seems to be relavent with GPU pressure (it happens more frequently wiht high process count and large block size.), the location are also random.
BTW, relavence to model is untested yet.
Anyideas about this phenomenon? Or how to get some logs about it?

please provide your phone spec and android system version

Rog 2 with Android 9.0 Snapdragon 855+ 12G Ram
Vulkan info as following:

please provide your phone spec and android system version

Rog 2 with Android 9, 855+, 12G Ram
Vulkan info as following:

[Update] Problem may be found: when the cell phone turn on/off the screen, wrong blocks will be generated.
By delaying the startup (to turn of the screen) and avoiding touching the cellphone last night, it works correctly on all 18 pictures with  (-t 64 -x -j 1:3:3) following (-t 128 -j 1:3:3).
Maybe Android did something to the driver when turn on/off screen.
Why it looks random is just because I turn on/off the screen randomly. Large block size make looks larger.

I am currently investigating a ncnn bug in flushing and invalidating non-coherent device memory.
This problem should be caused by it
Thanks for your report

Update on 2020/03/05 based on Lastest master branch:
If I didn't make some mistakes when I build the ncnn, then it seems like the problem still exists:
I designed two tests with ssh connect:

The screen are compeletely turned off during the first run, the result is nice:

During the second run, I turn off/on the screen periodically:

Don't know if it helps but im using tanyiok's builds from here and i can't reproduce this issue. I've tried turning the screen on and off over and over while its processing but the image isn't affected. Oneplus 6T, Android 9, Adreno 630, 8gb Ram. https://imgur.com/a/WM8kh0T

Don't know if it helps but im using tanyiok's builds from here and i can't reproduce this issue. I've tried turning the screen on and off over and over while its processing but the image isn't affected. Oneplus 6T, Android 9, Adreno 630, 8gb Ram. https://imgur.com/a/WM8kh0T

Interesting...
I just update my ROG 2 to Android Q. Now the driver version is 512.415.0, so the driver version is newer than your Oneplus. I also recomplied the program with the lastest Vulkan SDK, ncnn. But I have no difficulty to reproduce this BUG.
It may imple that this is a platform/OS/vendor specific problem. Maybe more feedback from different cellphone can make it clear.

It works fine on my Samsung Galaxy A50 too. 6GB RAM. Android 10. Mali-G72. Turned the screen off and on multiple times during processing.


Tests with Jest

Hi @echenley
Thanks for this example app in reflux!
I would like to know if you plan to cover it with tests Jest\Jasmine? That would be a really great addition to fulfil the gap in this area since it's not covered in reflux docs.

I'd love to add tests, though admittedly testing is not my strong suit. I'm going to start writing a few here and there, and I'm certainly open to PRs if anyone was so inclined. :)

@gothy I've had a hell of a time even writing one React component test with Jest. Honestly, Jest feels a little half-baked as of v0.5.0. It really makes you bend over backwards with certain dependencies (e.g. React-Router rackt/react-router#739) and only works with certain versions of Node/io.js (facebook/jest#243). I'm going to see if I can get going with another test framework—possibly Mocha, following the lead of react-starter-kit (kriasoft/react-starter-kit#78).
He references these posts, which seem pretty juicy:
Testing React Apps with Mocha (part 1)
Testing React Apps with Mocha (part 2)


TypeError: Cannot read property 'makeHref' of undefined

Still having issues getting this set up locally.
Have looked towards this but can't see the router being called twice in any components;
https://github.com/rackt/react-router/issues/1595
Thoughts?
Warning: owner-based and parent-based contexts differ (values: `undefined` vs `[object Object]`) for key (router) while mounting Link (see: http://fb.me/react-context-by-parent)
TypeError: Cannot read property 'makeHref' of undefined
    at render (/Users/rhysedwards/Downloads/ideas/node_modules/react-router/lib/Link.js:90:19)
    at ReactCompositeComponentMixin._renderValidatedComponentWithoutOwnerOrContext (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactCompositeComponent.js:789:34)
    at ReactCompositeComponentMixin._renderValidatedComponent (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactCompositeComponent.js:816:14)
    at wrapper [as _renderValidatedComponent] (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactPerf.js:70:21)
    at ReactCompositeComponentMixin.mountComponent (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactCompositeComponent.js:237:30)
    at wrapper [as mountComponent] (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactPerf.js:70:21)
    at Object.ReactReconciler.mountComponent (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactReconciler.js:38:35)
    at ReactDOMComponent.ReactMultiChild.Mixin.mountChildren (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactMultiChild.js:192:44)
    at ReactDOMComponent.Mixin._createContentMarkup (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactDOMComponent.js:289:32)
    at ReactDOMComponent.Mixin.mountComponent (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactDOMComponent.js:199:12)
    at Object.ReactReconciler.mountComponent (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactReconciler.js:38:35)
    at ReactCompositeComponentMixin.mountComponent (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactCompositeComponent.js:247:34)
    at wrapper [as mountComponent] (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactPerf.js:70:21)
    at Object.ReactReconciler.mountComponent (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactReconciler.js:38:35)
    at ReactCompositeComponentMixin.mountComponent (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactCompositeComponent.js:247:34)
    at wrapper [as mountComponent] (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactPerf.js:70:21)
Error: Invariant Violation: Server-side <Router>s need location, branch, params, and components props. Try using Router.run to get all the props you need
    at invariant (/Users/rhysedwards/Downloads/ideas/node_modules/react-router/node_modules/invariant/invariant.js:44:15)
    at componentWillMount (/Users/rhysedwards/Downloads/ideas/node_modules/react-router/lib/Router.js:254:34)
    at ReactCompositeComponentMixin.mountComponent (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactCompositeComponent.js:228:14)
    at wrapper [as mountComponent] (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactPerf.js:70:21)
    at /Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactServerRendering.js:42:27
    at ReactServerRenderingTransaction.Mixin.perform (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/Transaction.js:134:20)
    at Object.renderToString (/Users/rhysedwards/Downloads/ideas/node_modules/react/lib/ReactServerRendering.js:39:24)
    at /Users/rhysedwards/Downloads/ideas/public/assets/app.server.js:101:39
    at /Users/rhysedwards/Downloads/ideas/node_modules/react-router/lib/Router.js:53:7
    at done (/Users/rhysedwards/Downloads/ideas/node_modules/react-router/lib/AsyncUtils.js:14:14)
    at next (/Users/rhysedwards/Downloads/ideas/node_modules/react-router/lib/AsyncUtils.js:24:12)
    at /Users/rhysedwards/Downloads/ideas/node_modules/react-router/lib/RoutingUtils.js:120:9
    at /Users/rhysedwards/Downloads/ideas/node_modules/react-router/lib/RoutingUtils.js:100:13
    at done (/Users/rhysedwards/Downloads/ideas/node_modules/react-router/lib/AsyncUtils.js:14:14)
    at next (/Users/rhysedwards/Downloads/ideas/node_modules/react-router/lib/AsyncUtils.js:24:12)
    at /Users/rhysedwards/Downloads/ideas/node_modules/react-router/lib/RoutingUtils.js:120:9

@rhys-edwards Do you have a branch we could take a look at?
Also, try npm install again to make sure we've got the latest react-router. I had this problem before, but I fixed it with the new webpack.config.

@choonkending no branches to speak of as it was a clean clone. Can re-up it for you to take a look like if you wish?
Gave npm install a go but still being thrown the same error.

@rhys-edwards Sure! Would be helpful. I will try to reproduce this error if possible.

@choonkending Something going wrong and I can't make a branch due to an auth issue with Github.
In the meantime, I've done a clean clone from the repo; seems like reactt-router has updated with the below.
https://github.com/rackt/react-router/issues/1789
This is now throwing an error:
Rhyss-MacBook-Pro:react-webpack-node rhysedwards$ npm run dev

><EMAIL_ADDRESS>dev /Users/rhysedwards/Desktop/react-webpack-node
> NODE_ENV=development node server/index.js

Environment: development
/Users/rhysedwards/Desktop/react-webpack-node/public/assets/app.server.js:71
 \"react-router/lib/Location\""); e.code = 'MODULE_NOT_FOUND'; throw e; }()));
                                                                     ^
Error: Cannot find module "react-router/lib/Location"
    at webpackMissingModule (/Users/rhysedwards/Desktop/react-webpack-node/public/assets/app.server.js:71:96)
    at Object.<anonymous> (/Users/rhysedwards/Desktop/react-webpack-node/public/assets/app.server.js:71:198)
    at Object.<anonymous> (/Users/rhysedwards/Desktop/react-webpack-node/public/assets/app.server.js:122:28)
    at __webpack_require__ (/Users/rhysedwards/Desktop/react-webpack-node/public/assets/app.server.js:21:30)
    at /Users/rhysedwards/Desktop/react-webpack-node/public/assets/app.server.js:41:18
    at Object.<anonymous> (/Users/rhysedwards/Desktop/react-webpack-node/public/assets/app.server.js:44:10)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/rhysedwards/Desktop/react-webpack-node/server/config/routes.js:11:11)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)

npm ERR! Darwin 14.5.0
npm ERR! argv "node" "/usr/local/bin/npm" "run" "dev"
npm ERR! node v0.12.7
npm ERR! npm  v2.13.2
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>dev: `NODE_ENV=development node server/index.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>dev script 'NODE_ENV=development node server/index.js'.
npm ERR! This is most likely a problem with the react-webpack-node package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     NODE_ENV=development node server/index.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls react-webpack-node
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/rhysedwards/Desktop/react-webpack-node/npm-debug.log

I'm also getting the same error on npm run dev.

@rhys-edwards @davidlygagnon  Thanks for letting me know. Yea since react-router is still in it's beta stages, there might be many changes. I'll try to get a working version up and running for you guys.

Just another data point I have the same issue here.

+1

I had this issue as well when react-router beta 4 was released. A temporary fix was to fix it to the beta 3 version https://github.com/choonkending/react-webpack-node/commit/4796bec1dcdd401c56b20213cc435f9d47a32ae7, until beta4 is sorted :)
Let me know if this does not fix it for you (remember to pull the latest version)

Just letting you know, @choonkending, that on a fresh clone, running devHotLoader still produces the above error.

@rhys-edwards @jure Sorry it took so long to respond. It shouldn't be an issue with the latest master branch now.
You should now be able to run npm run build once. And from there run npm run dev which will start the server + use react-transform-hmr for hot reloading.
Closing this issue but feel free to open a new issue if you find any bugs. Thanks guys!


Update case-study-spatial-sound-design-for-holotour.md - Added correct GitHub author to metadata

Added correct GitHub author to metadata

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Could not find com.yqritc:android-scalablevideoview:1.0.4

Bug

Platform

Which player are you experiencing the problem on:

iOS
Android <-----
Windows UWP
Windows WPF

Environment info

React native info output:
0.68.2
Library version: 5.2.0
Steps To Reproduce

Everything was working fine this morning, i did an Android build with our CI. And this evening I didn't change anything but suddenly our CI give us this error: Could not find com.yqritc:android-scalablevideoview:1.0.4
We already have this fix:

jcenter() {
            content {
                includeModule("com.yqritc", "android-scalablevideoview")
            }
        }

What happened ? Why doesn't it work any more if we haven't changed anything?

...
Expected behaviour

Reproducible sample code

Video sample
If possible, include a link to the video that has the problem that can be streamed or downloaded from.

Same happened with us, got it to work with this patch
`diff --git a/node_modules/react-native-video/android/build.gradle b/node_modules/react-native-video/android/build.gradle
index 2fb8dfd..b508c95 100644
--- a/node_modules/react-native-video/android/build.gradle
+++ b/node_modules/react-native-video/android/build.gradle
@@ -22,5 +22,5 @@ android {
dependencies {
//noinspection GradleDynamicVersion
implementation "com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}"

implementation 'com.yqritc:android-scalablevideoview:1.0.4'

implementation 'com.github.MatrixFrog:Android-ScalableVideoView:v1.0.4-jitpack'
}
`

The 5.2.1 release shall already contain a fix for this issue. Can you double check please?

Ok it's good ! Thanks 😄
Sorry I didn't check the patch version, I just couldn't understand why it had suddenly stopped working

@voortexx I think your old version of this deps has been removed from your graddle cache !
So let's close this this issue


Importing dependencies where the module map differs from the pod name

This is unfortunate, but since emoji characters are not permitted in the module_name. They have to differ making cato impossible to handle emoji pods.
https://github.com/nestproject/Padlock
import Padlock

I'd guess we should do the following:
import Padlock  // pod '🔒'

:scream:


Add OpenSSLKeyLoader

Add a service that loads keys from parameters (key paths and passphrase as arguments of the service).
The service has been injected in the JWTEncoder rather than the 3 parameters, same for the method checkOpenSSLConfig that has been moved in the service and now takes no argument.
This also Improve checks for keys and their corresponding exception messages (One for file existing/reading problem, one for openssl loading, this for both public and private keys).
This avoid duplicated code (Command & Encoder) and make the bundle configuration easier to debug (centralised key loading logic).

Good idea @chalasr ! Thanks !

Do you think you could add some tests for the OpenSSLKeyLoader class ?

@slashfan Yes of course, I jusy realize that I forgotten them. I tell you when it's ok.

@slashfan Unit tests added !

Great !


Pages build failing

https://github.com/hyperledger/firefly/actions/runs/1843514416
/usr/bin/docker run --name ghcrioactionsjekyllbuildpagesv[10](https://github.com/hyperledger/firefly/runs/5190933240?check_suite_focus=true#step:4:10)1_b[11](https://github.com/hyperledger/firefly/runs/5190933240?check_suite_focus=true#step:4:11)adb --label 7db2d7 --workdir /github/workspace --rm -e INPUT_SOURCE -e INPUT_DESTINATION -e INPUT_FUTURE -e INPUT_BUILD_REVISION -e INPUT_VERBOSE -e INPUT_TOKEN -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_RETENTION_DAYS -e GITHUB_RUN_ATTEMPT -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_SERVER_URL -e GITHUB_API_URL -e GITHUB_GRAPHQL_URL -e GITHUB_REF_NAME -e GITHUB_REF_PROTECTED -e GITHUB_REF_TYPE -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e GITHUB_ACTION_REPOSITORY -e GITHUB_ACTION_REF -e GITHUB_PATH -e GITHUB_ENV -e RUNNER_OS -e RUNNER_ARCH -e RUNNER_NAME -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e ACTIONS_ID_TOKEN_REQUEST_URL -e ACTIONS_ID_TOKEN_REQUEST_TOKEN -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/firefly/firefly":"/github/workspace" ghcr.io/actions/jekyll-build-pages:v1.0.1
/usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/theme.rb:84:in `rescue in gemspec': The just-the-docs theme could not be found. (Jekyll::Errors::MissingDependencyException)
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/theme.rb:81:in `gemspec'
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/theme.rb:19:in `root'
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/theme.rb:[12](https://github.com/hyperledger/firefly/runs/5190933240?check_suite_focus=true#step:4:12):in `initialize'
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/site.rb:439:in `new'
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/site.rb:439:in `configure_theme'
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/site.rb:55:in `config='
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/site.rb:23:in `initialize'
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/commands/build.rb:30:in `new'
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/commands/build.rb:30:in `process'
	from /usr/local/bundle/gems/github-pages-223/bin/github-pages:70:in `block (3 levels) in <top (required)>'
	from /usr/local/bundle/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `block in execute'
	from /usr/local/bundle/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `each'
	from /usr/local/bundle/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `execute'
	from /usr/local/bundle/gems/mercenary-0.3.6/lib/mercenary/program.rb:42:in `go'
	from /usr/local/bundle/gems/mercenary-0.3.6/lib/mercenary.rb:19:in `program'
	from /usr/local/bundle/gems/github-pages-223/bin/github-pages:6:in `<top (required)>'
	from /usr/local/bundle/bin/github-pages:23:in `load'
	from /usr/local/bundle/bin/github-pages:23:in `<main>'
/usr/local/lib/ruby/2.7.0/rubygems/dependency.rb:311:in `to_specs': Could not find 'just-the-docs' (>= 0) among [15](https://github.com/hyperledger/firefly/runs/5190933240?check_suite_focus=true#step:4:15)9 total gem(s) (Gem::MissingSpecError)
Checked in 'GEM_PATH=/github/home/.gem/ruby/2.7.0:/usr/local/lib/ruby/gems/2.7.0:/usr/local/bundle', execute `gem env` for more information
	from /usr/local/lib/ruby/2.7.0/rubygems/dependency.rb:323:in `to_spec'
	from /usr/local/lib/ruby/2.7.0/rubygems/specification.rb:986:in `find_by_name'
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/theme.rb:82:in `gemspec'
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/theme.rb:[19](https://github.com/hyperledger/firefly/runs/5190933240?check_suite_focus=true#step:4:19):in `root'
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/theme.rb:12:in `initialize'
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/site.rb:439:in `new'
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/site.rb:439:in `configure_theme'
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/site.rb:55:in `config='
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/site.rb:23:in `initialize'
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/commands/build.rb:30:in `new'
	from /usr/local/bundle/gems/jekyll-3.9.0/lib/jekyll/commands/build.rb:30:in `process'
	from /usr/local/bundle/gems/github-pages-223/bin/github-pages:70:in `block (3 levels) in <top (required)>'
	from /usr/local/bundle/gems/mercenary-0.3.6/lib/mercenary/command.rb:2[20](https://github.com/hyperledger/firefly/runs/5190933240?check_suite_focus=true#step:4:20):in `block in execute'
	from /usr/local/bundle/gems/mercenary-0.3.6/lib/mercenary/command.rb:[22](https://github.com/hyperledger/firefly/runs/5190933240?check_suite_focus=true#step:4:22)0:in `each'
	from /usr/local/bundle/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `execute'
	from /usr/local/bundle/gems/mercenary-0.3.6/lib/mercenary/program.rb:42:in `go'
	from /usr/local/bundle/gems/mercenary-0.3.6/lib/mercenary.rb:19:in `program'
	from /usr/local/bundle/gems/github-pages-2[23](https://github.com/hyperledger/firefly/runs/5190933240?check_suite_focus=true#step:4:23)/bin/github-pages:6:in `<top (required)>'
	from /usr/local/bundle/bin/github-pages:23:in `load'
	from /usr/local/bundle/bin/github-pages:23:in `<main>'
  Logging at level: debug
Configuration file: /github/workspace/./docs/_config.yml
             Theme: just-the-docs
github-pages 223 | Error:  The just-the-docs theme could not be found.

Trying this, as we might be attempting to install Gem's that aren't supported in GHPages build: https://stackoverflow.com/a/58598379

ah, well it allowed me to recreate the problem on my laptop at least:
firefly/docs % bundle exec jekyll serve --livereload
Configuration file: /Users/pbroadhurst/dev/firefly/firefly/docs/_config.yml
jekyll 3.9.0 | Error:  The just-the-docs theme could not be found.

Looks like just-the-docs isn't in the theme list: https://pages.github.com/themes/
We took this one because we were taking guidance from Hyperledger, as to what Fabric had done before

Looks like we just need remote-theme and a plugin to support remote themes to Jekyll. Fixing

Pages build is green now


kusto release

https://github.com/Azure/sdk-release-request/issues/4270

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-arm-kusto


Catalog fails to update: the following untracked working tree files would be overwritten by checkout

Observed the TF on drone supposedly caused by the concurrent catalog creation and writing to the file system at the same time:
_________________________________ test_catalog _________________________________
[gw5] linux -- Python 3.6.5 /go/src/github.com/rancher/rancher/tests/.tox/py36/bin/python3.6

admin_mc = <core.conftest.ManagementContext object at 0x7f47c5a2eeb8>

    def test_catalog(admin_mc):
        client = admin_mc.client
        name = random_str()
        url = "https://github.com/StrongMonkey/charts-1.git"
        catalog = client.create_catalog(name=name,
                                        branch="test",
                                        url=url,
                                        )
>       wait_for_template_to_be_created(client, name)

test_catalog.py:13:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

client = <rancher.Client object at 0x7f47c5a55cf8>
name = 'random-13262-1536914187', timeout = 45

    def wait_for_template_to_be_created(client, name, timeout=45):
        found = False
        start = time.time()
        interval = 0.5
        while not found:
            if time.time() - start > timeout:
                raise AssertionError(
>                   "Timed out waiting for templates")
E               AssertionError: Timed out waiting for templates

caused by this error:
[100%]2018/09/14 08:37:32 [ERROR] CatalogController random-13262-1536914187 [catalog] failed with : Update failed: error: The following untracked working tree files would be overwritten by checkout:
	README.md
	busybox/v0.0.1/Chart.yaml
	busybox/v0.0.1/templates/pods.yaml
	busybox/v0.0.2/Chart.yaml
	busybox/v0.0.2/templates/pods.yaml
	busybox/v0.0.3/Chart.yaml
	busybox/v0.0.3/templates/pods.yaml
Please move or remove them before you switch branches.
Aborting
: exit status 1

@StrongMonkey QA is going to need some guidance on how to properly validate this bug I think

@sangeethah we should be able to verify

In v2.0.8, create several catalogs pointing to the same git repo.(different catalog name but with the same git url repo and branch name). Allow them to be pulled in the same time to see if there are any error showing up. (this is a race condition so it would not be easy to reproduce)
In v2.1.0-rc, do the same thing and see if you can still reproduce it.

In 2.0.8 , tried to created 50 catalogs pointing to the same git repo.(different catalog name but with the same git url repo and branch name) in parallel.
Encountered the following error for 2 of the catalogs:
2018/09/18 18:46:19 [ERROR] CatalogController default-32886 [catalog] failed with : Update failed: fatal: unable to write new index file
: exit status 128
2018/09/18 18:46:21 [INFO] Updating catalog default-18981
2018/09/18 18:46:21 [INFO] Catalog sync done. 1 templates created, 0 templates updated, 0 templates deleted
2018/09/18 18:46:21 [ERROR] CatalogController default-63887 [catalog] failed with : Update failed: fatal: unable to write new index file
: exit status 128

Tested the same scenario in v2.1.0-rc2
Tried to create 50 catalogs pointing to the same git repo.(different catalog name but with the same git url repo and branch name) in parallel.
No errors encountered on catalog updates.


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.8 to before v5.10.102",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=04f9bf2bac72480ca1d289b751b956dd1707a5d5",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=d3018a19622115e1126f6abb3657c65877a99410"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "04f9bf2bac72480ca1d289b751b956dd1707a5d5",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "d3018a19622115e1126f6abb3657c65877a99410",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "perf bpf: Defer freeing string after possible strlen() on it\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.10.102 by commit d3018a19622115e1126f6abb3657c65877a99410, it was introduced in version v5.8 by commit 04f9bf2bac72480ca1d289b751b956dd1707a5d5. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000402


Tab switching and moving gets very slow on components that hold complex HTML content.

GoldenLayout behaves very quick on barely "empty" components.
Having a few components, each holding some more complex HTML content, actions like tab switching and tab moving (removeChild/addChild) get really slow, notably (but not only) on IE.
Please see the fiddle with 4 components, each holding a simple 200 x 20 table:
https://jsfiddle.net/8g9L1uxh/
On IE 11, tab switching the above example is ridiculously slow...

I have the same problem. I'm loading large documents into tabs. Switching between them is very slow.
Maybe if there's some way to leave tab content in the DOM and just hide it when the tab isn't active?

The problem is that when you switch between tabs, the size of each tab containers is updated using the tabs content, even for hidden tabs. To retrieve the content size of hidden tabs, jQuery has to unhide the content which causes a reflow. It seems like redrawing table elements is pretty expensive, and since each tab content size is retrieved 4 times, the whole process can take multiple seconds to finish :( Interestingly, the impact is pretty low on tables made of div elements (like the table on the golden layout start page).
The problem does not really happens with visible tabs content because they are already drawn, so their size is already available.
To fix that, have a look at brouvio@70bb056 which prevents updating the size of hidden tabs (quick testings indicate this doesn't break anything). You can check it fixes your fiddle performances here.

@brouvio Thank you for your hint to your patch, it was a live saver for me. I have some (hidden) highly complex HTML and opening/closing of a new tab took nearly 3 seconds. With your patch, it opens/closes in a fraction of a second again. Do you see any chance to have this merged into the official product?

We'd happily take a look at merging a PR of this patch if you have the time @brouvio :)

I created a PR, hope that's ok. It's really important for me.

@uklimaschewski No problem, changes are pretty straightforward, I don't need credits for them.

Hello. Issue is still actual. Furthermore, slow tab switching in IE 11 and Edge can cause unwanted selected tab dragging. This behaviour can be easily reproduced in fiddle from first post or here: https://jsfiddle.net/czafryo2/
Just click on stack caret and select any slide: it will be opened in new row/column.


Direct access to task providers in Groovy DSL without breaking configuration avoidance

(Proposal, WiP)
See: #15720
These four options could be consider to address  #15720:
Options

Do nothing
Only make configuration with closure - tasks.a { } - respect configuration avoidance
In addition, make property access - task.a - respect configuration avoidance (return task provider)
In addition, make task.a.taskPropertyOrMethod automatically realize the task and delegate to the property (for backwards compatibility)

This draft PR does (2) in the first (3) in the second and (4) in the third commit. Doing only (1), did require almost no adjustment to any test to pass the pipeline.
How/why does the proposals solve the issues we currently have?

Groovy and Kotlin DSL are not aligned:
With (1) we'll keep this for at least another year. With (2) we'll make it slightly more aligned, but not completely. (3) or (4) would make for a nice alignment.
Using task configuration avoidance in Groovy is clunky because you need to use tasks.named('a') {} instead of the shorter notation tasks.a {}. This is solved with (2) already. (3) or (4) is not that important in this context as the most common way is to access and configure the task (provider) directly.

What do the proposals break?

If going with (2), the only thing that changes is the evaluation order of tasks. Which only plays a role if you do things you shouldn't do. And also won't be able to do anymore if you use configuration cache. For example:

def a = 0
tasks.test {
  a = 1
}
println(a) // after the change, this prints '0', before it would print '1'

If going with (4), in addition to the above, all places would break that, in dynamic Groovy, still strongly rely on the type Task. E.g.:

Task t = tasks.test // breaks, now of type TaskProvider; replace with tasks.test.get()

(Test) tasks.test // breaks,  now of type TaskProvider; replace with tasks.test.get()

signing.sign(jar) // breaks as method expects a Task, replace with signing.sign(jar.get())

If we would only go with (3) accessing task details through a provider would also break:

tasks.test.useJUnitPlatform()

Since the change only affects dynamic Groovy, statically compiled plugins (Groovy or other languages) are not affected as they were never able to use these "task accessors" in the first place.
Other methods to access the task will stay eager. As they are also eager in Kotlin DSL. So if we do this change, a Groovy DSL user that actually needs the realized task object, has a couple of options to replace tasks.a with:

tasks["a"]
tasks.getByName["a"]
tasks.a.get()

Closing this as there are not concrete plans. Keeping the branch around in case this is picked up again.


Running make file on specific folder/file

Hi,
In the specific folder that I'm working in, I have a make file that uses pandoc to convert a markdown file to pdf, docx, and html. However when I use the build command I think it attempts to convert the whole project and thus immediately runs into an error in trying to convert the Read Me file in the root of my project. Is there a way to specify the command so that it will only run the make file in the current folder I'm in?
Thanks!

Yes, you can set the current working directory in a custom atom-build file:
{
  "cmd": "make"
  "cwd": "{FILE_ACTIVE_PATH}"
}

Save this as .atom-build.json in the root folder and it will run make in whatever path the currently active file resides in. Read more about replacements

Thanks for the quick reply!
I'm getting an error though which says
you have a syntax error in your build file: /Users/[user]/github/papers/.atom-build.json: Unexpected string
I copied exactly what you put up there into the file.

Can you paste the contents of your .atom-build.json?

{   "cmd": "make"   "cwd": "{FILE_ACTIVE_PATH}" }

Sorry, but with the proper line breaks.

There's no comma after "make".

ah of course! Thanks!
Ok one more quick problem, as I said I'm using pandoc to convert a markdown file, and I'm using xelatex as the latex engine. It runs fine when I run it through the terminal but if I run it here I get this: pandoc: xelatex not found. xelatex is needed for pdf output.
Any idea why this wouldn't work?
Thanks again for your help

I'm guessing the PATH is not set correctly when you open Atom. You probably have something in your  .zshrc, .bashrc or equivalent shell init scripts which adds wherever xelatex is to your PATH. You could try to close Atom and start it from a terminal where it works. If it works then, you know it's a path issue.

I'm sorry, I don't quite understand what you mean when you say you could try to close Atom and start it from a terminal where it works.

So, quit atom completely. (Atom -> Quit).
Go to a terminal where Make works and start atom from there.
Run build. If it works, it is definitely a PATH issue.

 That worked, would you mind telling me how to fix the PATH issue?
Thanks for all your help with this, I really do appreciate it.

It's no problem. It depends on the operating system. On Unix/Linux, you can inspect the PATH variable by e.g. echo $PATH. It will be a colon : separated list of locations to search for binaries (such as xelatex).
See this issue and this issue for solutions from people with similar problems.

Ok, so I added a line in my .bash_profile which says export PATH="$PATH:$HOME/usr/texbin/xelatex"
As I understand it, that should add xelatex to the end of my path (and I think it did based on echo $PATH
Anyways, now the build works! Thanks for your help.


Host the website via GitHub pages

This would allow people to contribute more easily to the website and docs :)
The source of the website could either be kept in a separate repository, or in a branch in this repo. I personally prefer the latter, but any of those would be a nice improvement from the current setup.
(The domain could still be sanejs.dev, just in case you're not aware.)

Hey thanks for the tip. The website is also built in sanejs which requires a node backend so I don't think the site could be hosted here (don't know much about GitHub pages though). But yeah putting the source for the site up here makes sense.


close all the windows (fanzyzones)

Microsoft PowerToys version
0.72.0
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
FancyZones
Steps to reproduce
I have 7 windows open, the screen is divided into three parts, the first part is for a full window, the second part is for 3 windows, as well as the third part, I did this with a designing template that allows the fancyzone
✔ Expected Behavior
dont close all the windows
❌ Actual Behavior
When I have 7 windows open arranged with "fancyzone" and copying files from one directry to the other 6 directories after a while all the windows close unexpectedly
Other Software
No response

Not able to repro this, going to close. Let us know if you see this again!


Date Field with Mongoid

I have a date field as the following:
= f.input :birthday, as: :date, end_year: Time.now.year - 100, start_year: Time.now.year , input_html: { class: "input-medium chzn-select-deselect" }

When the record is saved I get the following instead of the :birthday field being filled.
#<Contact _id: 4f4fd18dbe5a2c07110000c5, _type: nil, firm_id: "test2", user_id: nil, party_id: nil, relationship_ids: [BSON::ObjectId('4f4fd31bbe5a2c07110000d0')], first_name: "Kris", last_name: "Waldrip", birthday: nil, birthday(1i): "1989", birthday(2i): "10", birthday(3i): "24">

Is there something I have to do special in my model or controller?
I did look in the docs this time justin ;-)

Hi,
Those date inputs are very specific to the way ActiveRecord will parse a params hash and coerce the params into objects as part of mass assignment. As you can see, the date and date are broken into multiple fragments (2i, etc), which ActiveRecord glues back together and coerced into a date or time.
My guess is that Mongoid does not do this, so you'll either need to do this work yourself in the model, do iit in the controller, or pick another type of input (like a StringInput) with a jQuery calendar widget attached, which will be the default soon anyway.
Would be AWESOME if you could submit a documentation patch for the date/time inputs so others don't struggle here!