Cannot link libraries on Archlinux due to missing permissions

Steps to reproduce:
Install Amazon VOD Add-On
Enable Adaptive Inputstream Add-On in Settings
In Amazon VOD Add-On: Login, start watching something
What happens:
Install Widevine popup appears, tries to install Widevine, fails after a while
What should happen:
After Widevine installation an error pops up, video is not played.
Ways to debug:
I modified the file ~/.kodi/addons/script.module.inputstreamhelper/lib/inputstreamhelper.py by adding the following before line 692:
self._log("addon: " + cdm_path_addon)
self._log("stream: " + cdm_path_inputstream)

And then tried the whole thing again with logging enabled, leading to this log output:
2019-05-20 11:26:23.733 T:139662384420608   DEBUG: [script.module.inputstreamhelper-0.3.4]: [install_cdm] found file: libwidevinecdm.so
2019-05-20 11:26:23.734 T:139662384420608   DEBUG: CAddonSettings[inputstream.adaptive]: loading setting definitions
2019-05-20 11:26:23.734 T:139662384420608   DEBUG: CAddonSettings[inputstream.adaptive]: loading setting values
2019-05-20 11:26:23.751 T:139662384420608   DEBUG: [script.module.inputstreamhelper-0.3.4]: addon: /home/max/.kodi/userdata/addon_data/script.module.inputstreamhelper/c
dm/libwidevinecdm.so
2019-05-20 11:26:23.751 T:139662384420608   DEBUG: [script.module.inputstreamhelper-0.3.4]: stream: /usr/lib/kodi/addons/inputstream.adaptive/libwidevinecdm.so
2019-05-20 11:26:23.754 T:139662384420608   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.OSError'>
                                            Error Contents: [Errno 13] Permission denied
                                            Traceback (most recent call last):
                                              File "/home/max/.kodi/addons/plugin.video.amazon-test/default.py", line 5, in <module>
                                                EntryPoint()
                                              File "/home/max/.kodi/addons/plugin.video.amazon-test/resources/lib/startup.py", line 74, in EntryPoint
                                                PlayVideo(args.get('name', ''), args.get('asin'), args.get('adult', '0'), int(args.get('trailer', '0')), int(args.get('s
elbitrate', '0')))
                                              File "/home/max/.kodi/addons/plugin.video.amazon-test/resources/lib/playback.py", line 462, in PlayVideo
                                                playable = _IStreamPlayback(asin, name, trailer, isAdult, extern)
                                              File "/home/max/.kodi/addons/plugin.video.amazon-test/resources/lib/playback.py", line 344, in _IStreamPlayback
                                                if not inputstream_helper.check_inputstream():
                                              File "/home/max/.kodi/addons/script.module.inputstreamhelper/lib/inputstreamhelper.py", line 778, in check_inputstream
                                                return self._check_drm()
                                              File "/home/max/.kodi/addons/script.module.inputstreamhelper/lib/inputstreamhelper.py", line 749, in _check_drm
                                                return self._install_widevine()
                                              File "/home/max/.kodi/addons/script.module.inputstreamhelper/lib/inputstreamhelper.py", line 550, in _install_widevine
                                                return self._install_widevine_x86()
                                              File "/home/max/.kodi/addons/script.module.inputstreamhelper/lib/inputstreamhelper.py", line 458, in _install_widevine_x86
                                                self._install_cdm()
                                              File "/home/max/.kodi/addons/script.module.inputstreamhelper/lib/inputstreamhelper.py", line 694, in _install_cdm
                                                os.symlink(cdm_path_addon, cdm_path_inputstream)
                                            OSError: [Errno 13] Permission denied
                                            -->End of Python script error report<--

Fix
I ran this command to fix it:
sudo chmod 777 /usr/lib/kodi/addons/inputstream.adaptive/

However I had to find out all of this by myself, would you mind putting in a check that handles this type of error and displays a more informative error message to the user?

I forgot to mention: the "what happens" section should include that I pressed "ok" and "accept" a few times in the "install Widevine" popup(s).

From a security-point of view, this is not a good solution.
But there's also no reason why inputstreamhelper is writing to that directory.
The symlink is normally created in: ~/.kodi/cdm/
What environment is this? OS? Kodi?

So if you have more information related to this issue, we would still like to know.
We would also like to know if this issue still happens with the current master branch.
In any case, if you have new information or test results, please reopen this issue, or report them here.
Thanks!

What environment is this? OS version? Kodi?
Have you reported this to the Archlinux Kodi maintainer?

Archlinux doesn't have versions, as for the package version it was the one that was distributed via the repos at that date. I haven't thought that this might be a packaging issue, I'll contact the maintainer.


Code Generator fixes

-Fix AsyncWrapperGenerator and NativeCallbacksWrapperGenerator do not pick up generic type argument namespaces which will lead to failing compilation of generated code
-Fix delegate parameter could not be passed by ref or in or out when used with TDelegate.

Awesome! Thank you for the PR ⭐


forwarder: customize the listener port

By default the port is 15150, this adds the support to customize it to a specific port. Currently changes added for AWS, Azure and IBM Cloud PowerVS providers.
Fixes: #1457

The default value of FORWARDER_LISTEN will be <IP_ADDRESS>:15150.

Hi @yoheiueda, are you suggesting we pass FORWARDER_LISTEN(addr+port) by default to the agent-protocol-forwarder?

I think FORWARDER_ADDRESS can also be configuration.

Okay

@Amulyam24
My point was that it is preferable to make the <IP_ADDRESS> part configurable in addition to the  15150 part.

are you suggesting we pass FORWARDER_LISTEN(addr+port) by default to the agent-protocol-forwarder?

So, when a user want to use the default <IP_ADDRESS>:15150, I don't think we need to explicitly specify the value in the command line argument of agent-protocol-forwarder.

Is using a customisable listen address (not port) applicable ? Since CAA uses the node IP (public or private) and the port to connect to the APF.
@yoheiueda @Amulyam24  is there a scenario that I'm missing?

applicable ? Since CAA uses the node IP (public or private) and the port to connect to the APF.

That's right @bpradipt. I missed this point. I will let @yoheiueda answer it if he has any specific scenario case for it

@bpradipt @Amulyam24 Oh, that's right. I don't come up with a specific scenario. I think we can go ahead without FORWARDER_ADDRESS.
When a pod VM image supports multiple network interfaces in the future, we will possibly provide an option to select a specific network address. But, the current deployment mechanism only supports a single network, so there are no appropriate value to be set toFORWARDER_ADDRESS.

@Amulyam24 can you please fix the commit check

Hi @bpradipt, did you get a chance to verify this option for AWS/Azure?

@Amulyam24 sorry this PR got missed. Can you please rebase and resolve the conflicts ?

Rebased the PR to resolve conflicts.


empty message

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to 'issue'
and open a new issue with your bug report in it preovide evidance as video pic or code snapshot

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop:

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone:

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

When I press the send button and the message is empty, the message is sen.

When I press the send button and the message is empty, the message is sent.

that issue was fixed
the ability to send empty messege ben fixed
date problem solved : 3/26/2024


modify XcodeVersion() to convert "4.2" to "0420" and "10.0" to "1000"

https://github.com/nodejs/node-addon-api/issues/445#issuecomment-535361389

Checklist

[ ] npm install && npm test passes
[ ] tests are included
[ ] documentation is changed or added
[ ] commit message follows commit guidelines

Description of change

landed in 8e9ec3b


Question about slow inference speed and math related benchamarks

Dear author,
Thanks for your amazing contributions. Could you please provide the rough running time of the evaluations? I used your inference script to evaluate on BBH, which is estimated to take more than 18 hours on one A100 (40GB). I want to make sure whether this is normal under your settings?
Meanwhile, the processing of math related benchmarks such as GSM8K, AQUA are not included in /data/otherbenchmarks/. Should I directly follow their orginal repo?
Thanks a lot for you reading and help!
Best

Dear Mr. Zhang
Thank you for taking the time to read our work. We apologize for the slow inference time, which is due to the fact that we haven't implemented the distribution yet. However, if you want to see approximate results, you can sample for BBH.
For other benchmarks that are not available in the repository, you can download the original corpus directly and use the script to process the data. We will take time to add these processed data.
Best,
Authors

Dear Mr. Zhang
Thank you for taking the time to read our work. We apologize for the slow inference time, which is due to the fact that we haven't implemented the distribution yet. However, if you want to see approximate results, you can sample for BBH. For other benchmarks that are not available in the repository, you can download the original corpus directly and use the script to process the data. We will take time to add these processed data.
Best, Authors


Running on Google Colab, create_link error occurs.

I run main.py on Google Colab , and I got the message bellow.
  File "/content/grive/My Drive/CycleGAN/cycleGAN-PyTorch/utils.py", line 37, in create_link     os.path.join(dirs[key], 'Link')) OSError: [Errno 95] Operation not supported: '/content/grive/My Drive/CycleGAN/cycleGAN-PyTorch/datasets/horse2zebra/trainA' -> './datasets/horse2zebra/ltrainA/Link'
I think it's better to copy trainA to ltrainA without using the link.

But why do you use link?

Yeah, you can do that. I never tried running this code on google colab.

Thanks a lot.

I run main.py on Google Colab , and I got the message bellow.
 File "/content/grive/My Drive/CycleGAN/cycleGAN-PyTorch/utils.py", line 37, in create_link os.path.join(dirs[key], 'Link')) OSError: [Errno 95] Operation not supported: '/content/grive/My Drive/CycleGAN/cycleGAN-PyTorch/datasets/horse2zebra/trainA' -> './datasets/horse2zebra/ltrainA/Link'
I think it's better to copy trainA to ltrainA without using the link.

only copying images would help from this problem?


DOCS-3269 Android TV and Android Support in READMEs and Documentation

What does this PR do?
Updates READMEs and public docs to mention Android TV support.
Motivation
DOCS-3269
Additional Notes
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #902 (5881a0c) into develop (c19dd9e) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #902      +/-   ##
===========================================
- Coverage    82.89%   82.80%   -0.09%
===========================================
  Files          265      265
  Lines         8996     8996
  Branches      1457     1457
===========================================
- Hits          7457     7449       -8
- Misses        1139     1142       +3
- Partials       400      405       +5

Impacted Files
Coverage Δ

...android/rum/internal/ndk/DatadogNdkCrashHandler.kt
83.43% <0.00%> (-2.21%)
:arrow_down:

...ain/java/com/datadog/opentracing/PendingTrace.java
58.62% <0.00%> (-1.72%)
:arrow_down:

.../android/rum/internal/monitor/DatadogRumMonitor.kt
94.38% <0.00%> (-0.62%)
:arrow_down:

...rc/main/java/com/datadog/opentracing/DDTracer.java
56.07% <0.00%> (-0.42%)
:arrow_down:

...ndroid/telemetry/internal/TelemetryEventHandler.kt
82.22% <0.00%> (ø)


Added proxies in Configuration

I have to use proxies to scrap a specific website so I added proxies attribute in Configuration.

I just came to this repo looking to see how complicated it'd be to contribute exactly this functionality...  Definite 👍 from me as an outsider, hoping that this might get merged!

Thanks so much for doing this @Walkoss, approving and merging now. Will be a few days before I also deploy a new version into pip.


Appstudio update test-component-pac-fizc

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-fizc-on-pull-request has failed.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
13 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
20 seconds
deprecated-base-image-check

✅ Succeeded
18 seconds
sanity-inspect-image

🏃 Running
---
clair-scan

🏃 Running
---
clamav-scan

✅ Succeeded
12 seconds
sbom-json-check

🏃 Running
---
sanity-optional-label-check

🏃 Running
---
sanity-label-check


feat(query-devtools): Persist picture-in-picture mode through reloads

This feature allows the picture-in-picture mode of the devtools to persists through page reloads.
The popup will remain open and will be re-used between page refreshes. Demo below
https://github.com/TanStack/query/assets/45807386/04bb474d-edeb-43d3-ba6b-282fee588265

Codecov Report

Merging #6942 (d712cfb) into main (f419daf) will decrease coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6942      +/-   ##
==========================================
- Coverage   41.33%   41.29%   -0.05%
==========================================
  Files         180      180
  Lines        7186     7193       +7
  Branches     1449     1454       +5
==========================================
  Hits         2970     2970
- Misses       3833     3836       +3
- Partials      383      387       +4

Components
Coverage Δ

@tanstack/angular-query-devtools-experimental
∅ <ø> (∅)

@tanstack/angular-query-experimental
82.29% <ø> (ø)

@tanstack/eslint-plugin-query
85.11% <ø> (ø)

@tanstack/query-async-storage-persister
48.43% <ø> (ø)

@tanstack/query-broadcast-client-experimental
∅ <ø> (∅)

@tanstack/query-codemods
0.00% <ø> (ø)

@tanstack/query-core
93.63% <ø> (ø)

@tanstack/query-devtools
4.09% <0.00%> (-0.02%)
:arrow_down:

@tanstack/query-persist-client-core
57.73% <ø> (ø)

@tanstack/query-sync-storage-persister
82.50% <ø> (ø)

@tanstack/react-query
93.07% <ø> (ø)

@tanstack/react-query-devtools
0.00% <ø> (ø)

@tanstack/react-query-next-experimental
∅ <ø> (∅)

@tanstack/react-query-persist-client
100.00% <ø> (ø)

@tanstack/solid-query
84.84% <ø> (ø)

@tanstack/solid-query-devtools
∅ <ø> (∅)

@tanstack/solid-query-persist-client
100.00% <ø> (ø)

@tanstack/svelte-query
62.68% <ø> (ø)

@tanstack/svelte-query-devtools
∅ <ø> (∅)

@tanstack/svelte-query-persist-client
100.00% <ø> (ø)

@tanstack/vue-query
70.81% <ø> (ø)

@tanstack/vue-query-devtools
∅ <ø> (∅)

@ardeora Wow, pure magic! ;-)

@ardeora Wow, pure magic! ;-)

Thank you so much for the feedback! And pointing me to the right direction 🥳  Hope you have a great week!


Adding more examples

I see the tests failed on print, but this is an example folder so I think it would be right to allow it or use logger.


[ENTESB-15644] Fix monitoring test

@astefanutti Do you think it could be backported to M4 or M5 branches ?

@astefanutti Do you think it could be backported to M4 or M5 branches ?

@astefanutti Do you think it could be backported to M4 or M5 branches ?

@llowinge could you create a PR to release-1.3.x branch?

@astefanutti Do you think it could be backported to M4 or M5 branches ?

@llowinge could you create a PR to release-1.3.x branch?

@astefanutti Do you think it could be backported to M4 or M5 branches ?

@llowinge could you create a PR to release-1.3.x branch?

Yes, i will.

@astefanutti Do you think it could be backported to M4 or M5 branches ?

@llowinge could you create a PR to release-1.3.x branch?

Yes, i will.


Fix the Styling in Import Data

Please do work for this task in a branch called issue-34.  Allow the users to upload .csv files (kinda done in Tasks/LoadBuildingTask.js


Identity center instance cannot be created or carried over if an organization is created after identity center is already enabled.

Describe the bug
I enabled identity center without first creating my organization.  I then created my organization and navigated back to identity center.  The splash page to enable IC was displayed, but when I clicked enable it told me It was already enabled in the region I was in.
I ran this script and the output was that it was already enabled in the region I was in.
`regions=$(aws ec2 describe-regions --query "Regions[*].RegionName" --output text)
for region in $regions; do
echo "Executing in region: $region"
aws sso-admin list-instances --region "$region"
echo "----------------------------------------"
done`
I had to delete my org then delete my identity center instance then re-create the org and re-enable Identity center.  It seems that Identity center that was enabled in the account should be available to the user after an organization is created.
To Reproduce
Steps to reproduce the behavior:
Make sure there is no identity center instance or organizations instance

Go to 'Identity Center console'
Click on 'Enable'
Go to organizations and click 'create and organization'
Navigate back to identity center to manage it
See that its no longer there and cannot be enabled

Expected behavior
Make sure there is no identity center instance or organizations instance

Go to 'Identity Center console'
Click on 'Enable'
Go to organizations and click 'create and organization'
Navigate back to identity center to manage it
Manage identity center normally.

Screenshots

Desktop (please complete the following information):

OS: [MacOS]
Browser [ chrome]
Version [macos14.3.1]

It seems you are describing a behavior of AWS IAM Identity Center, not an issue with the TEAM application. Identity Center now supports different instance types, including organization instances and account instances. See https://docs.aws.amazon.com/singlesignon/latest/userguide/identity-center-instances.html


Bug: Cannot open the plugin

Uncaught (in promise) Error: ENOENT: no such file or directory, open 'C:\Users\Administrator\Desktop\1\.obsidian\plugins\magic-calendar\.base64Media.json'

Cannot open the plugin.
And could you add a command in the plugin, I don't like use it open the plugin on the side.

Hello, can you please provide the steps to replicate the problem?

Hi there!
Thank you for opening this issue: Apparently, the latest release did not include in the zip file the .base64Media.json.
Everything should work fine now.


Fix out-of-tree builds generating netcdf_json.h and netcdf_proplist.h

Without this, build/include/netcdf_json.h and build/include_netcdf_proplist.h simply contain the initial #ifdev line.

I rebuilt these constructions as` part of  my repo:

https://github.com/DennisHeimbigner/netcdf-c branch v3plug.tmp

Any chance you can look to see if my version solves your problem?

To simplify my query. Here is the Automake code for building netcdf_json.h and netcdf_proplist.h
# netcdf_json.h is constructed as a header-only file for use by
# nczarr code wrappers in the plugin directory. It is
# constructed by joining libdispatch/ncjson.c with
# include/ncjson.h.  Additionally all the entry points are
# marked with a macro (OPTSTATIC) that marks the entry point as
# static inside netcdf_json.h.	This is an ugly hack to avoid
# having to reference libnetcdf in the nczarr code wrappers.

# Give the recipe for building netcdf_json.h
netcdf_json.h: ${top_srcdir}/libdispatch/ncjson.c ${top_srcdir}/include/ncjson.h
	rm -fr ${srcdir}/netcdf_json.h
	cat ${srcdir}/ncjson.h \
	    | sed -e '/!NCJSON_H/d' \
    	    | sed -e 's/NCJSON_H/NETCDF_JSON_H/' \
	    >> ${srcdir}/netcdf_json.h
	cat ${srcdir}/../libdispatch/ncjson.c | sed -e '/ncjson.h/d' >> ${srcdir}/netcdf_json.h
	echo '#endif /*NETCDF_JSON_H*/' >> ${srcdir}/netcdf_json.h

# netcdf_proplist is analogous to netcdf_json but, of course, using libdispatch/ncproplist.c and include/ncproplist.h
# Give the recipe for building netcdf_proplist.h. Basically same as for netcdf_json.h
netcdf_proplist.h: ${top_srcdir}/libdispatch/ncproplist.c ${top_srcdir}/include/ncproplist.h
	rm -fr ${srcdir}/netcdf_proplist.h
	cat ${srcdir}/ncproplist.h \
	    | sed -e '/!NCPROPLIST_H/d' \
    	    | sed -e 's/NCPROPLIST_H/NETCDF_PROPLIST_H/' \
	    >> ${srcdir}/netcdf_proplist.h
	cat ${srcdir}/../libdispatch/ncproplist.c | sed -e '/ncproplist.h/d' >> ${srcdir}/netcdf_proplist.h
	echo '#endif /*NETCDF_PROPLIST_H*/' >> ${srcdir}/netcdf_proplist.h

and the same code for CMakeLists.txt.
# Built source: netcdf_json.h
file(READ ncjson.h JSONH0)
STRING(REPLACE "NCJSON_H" "NETCDF_JSON_H" JSONH1 "${JSONH0}")
file(WRITE ${CMAKE_CURRENT_BINARY_DIR}/netcdf_json.h "${JSONH1}")
file(APPEND ${CMAKE_CURRENT_BINARY_DIR}/netcdf_json.h "#ifdef NETCDF_JSON_H\n")
file(READ ${CMAKE_SOURCE_DIR}/libdispatch/ncjson.c JSONC0)
STRING(REGEX REPLACE "#include[ ]+\"ncjson.h\"" "" JSONC1 "${JSONC0}")
file(APPEND ${CMAKE_CURRENT_BINARY_DIR}/netcdf_json.h "${JSONC1}")
file(APPEND ${CMAKE_CURRENT_BINARY_DIR}/netcdf_json.h "#endif /*NETCDF_JSON_H*/\n")

# Built source: netcdf_proplist.h
file(READ ncproplist.h PLISTH0)
STRING(REPLACE "NCPROPLIST_H" "NETCDF_PROPLIST_H" PLISTH1 "${PLISTH0}")
file(WRITE ${CMAKE_CURRENT_BINARY_DIR}/netcdf_proplist.h "${PLISTH1}")
file(APPEND ${CMAKE_CURRENT_BINARY_DIR}/netcdf_proplist.h "#ifdef NETCDF_PROPLIST_H\n")
file(READ ${CMAKE_SOURCE_DIR}/libdispatch/ncproplist.c PLISTC0)
STRING(REGEX REPLACE "#include[ ]+\"ncproplist.h\"" "" PLISTC1 "${PLISTC0}")
file(APPEND ${CMAKE_CURRENT_BINARY_DIR}/netcdf_proplist.h "${PLISTC1}")
file(APPEND ${CMAKE_CURRENT_BINARY_DIR}/netcdf_proplist.h "#endif /*NETCDF_PROPLIST_H*/\n")

I would argue that you shouldn't be modifying anything in ${srcdir}, and instead use ${builddir}.  This is what the cmake code is doing when it specifies ${CMAKE_CURRENT_BINARY_DIR}.

I see. And you are correct.

I've updated with fixes to the Github CI that were blocking. Thanks!


Fix declaring property named get/set/async

    class P {
        get;
        get = () => "123";
    }

Got SyntaxError: invalid property name.
This PR fixes it.

Is this a port from bellard/quickjs ?

Is this a port from bellard/quickjs ?

No, should I move this PR the the upstream? I submit it here because I use this fork in my project.
Looks like both repo are actively maintained. A bit confusing.

No need, I think this was fixed there too, that's why I asked.

This fixes another pattern where we declare a property (without initalizing it) called get, and later initilizes is. My original QuickJS PR didn't consider this.  Should be added to upstream as well.


[ Question ] Is it possible to emulate controllers?

Is it possible to emulate any controller with mouse and keyboard?

I tried this out and fixed some related bugs in the process :D
You can check out the example in the docs for more details. Some of the capabilities API is not fully documented yet but will (probably) not change.
The example doesn't use a mouse, but it's also possible (exercise for the reader).
Also make sure you're on at least map2 2.0.8 to make it work as expected.

@shiro Thanks for providing an example! I will try it.


Key "wlan" no more registering event on kb attach/detach

today it stops recognize.
no event when i try to rebind hotkey action, also nothin catched with sudo showkey -k
what i changed - yesterday i played with grub entries, but i reverted them all already now it GRUB_CMDLINE_LINUX_DEFAULT="quiet splash"
and im installed latest libwacom from Debian repos. and playing with libwacom configs.
any ideas? dont know what to try....

This kernel patch disables the wlan-on-attach/detach.
Also, read this:

The patch for the wireless disconnecting after connecting the keyboard has been included in Linux 6.11, which should be released as a new stable kernel soon. However, I haven’t tested this kernel to see if any other issues come up.

So if you recently upgraded your linux kernel to 6.11+, you should not receive a wlan event on keyboard attach/detach.
What kernel version do you run? You can see this with uname -a

bitodt thx, i checked, really - i missed that i vahe kernel upgrade this day, my kernel 6.10.12-x64v3-xanmod1 , looks like this patch already included there..
 I changed my duo file accordingly, the display watcher starts, but nothing happens to the screens.

@NaScha
The Problem might be, that the newest patch introduced a non-existent third monitor, which keeps the duo normal command from being run as I just copied the duo set-displays command in watch-displays.
I solved this for me by adding multi monitor support via #16 on my machine and removing the monitor check from watch-displays.
The "duo toggle" command may be broken, as it doesn't do anything for me either, but as long as "duo normal" works, this should be a problem.

@SchoeningStud
Tried as you adviced, but 2 Problems:
Using the 2 Variables from this Pull-Request
+eDP_TOP="eDP-1"
+eDP_BOTTOM="eDP-2"
duo set-tablet-mapping is broken.
Removing these variables and change all occurances to according eDP-x I can call duo set-tablet-mapping, but then, duo watch-rotation is broken. I can come to book mode, but not back to laptop-mode, i. e. I am stuck now in vert ical mode and can not get back to horizontal mode. The error is the following - any way to fix that?
duo watch-rotation Executing both command: gnome-monitor-config set -LM eDP-1 -m<EMAIL_ADDRESS>-s 1.74757 -x 0 -y 0  -t right -LM eDP-2 -m<EMAIL_ADDRESS>-s 1.74757 -x 0 -y 1030 -t right -p :::: ../src/gmc-display-config.c:691 cc_display_logical_monitor_config_add_monitor() -  :::: ../src/gmc-display-config.c:691 cc_display_logical_monitor_config_add_monitor() -  Logical monitor [ 2880x1800+0+0 ], scale = 1.74757   Monitor [ eDP-1 ] 2880x1800@120 Logical monitor [ 2880x1800+0+1030 ], PRIMARY, scale = 1.74757   Monitor [ eDP-2 ] 2880x1800@120 [(0, 0, 1.7475727796554565, uint32 3, false, [('eDP-1'<EMAIL_ADDRESS>@a{sv} {})]), (0, 1030, 1.7475727796554565, 3, true, [('eDP-2'<EMAIL_ADDRESS>{})])] Failed to set configuration: GDBus.Error:org.freedesktop.DBus.Error.InvalidArgs: Logical monitors not adjacent

I think I had the same "Logical monitors position are offset" when I used it initially on ubuntu 24.10 beta. This change fixed the problem for me y_offset=1800 unfortunately for some reason my display reports that it can't get scaled to 175%..

@NaScha
This was caused by an offset in the x coordinate in the top monitor in "duo left-up", which wasn't corrected for in any of the other commands. The fix I'm using is here, also this adapts all commands for multi monitor use.

@SchoeningStud
Your fix works like a charm! Now I have back all the functionality I need:

Tablet-Mapping (independent touch function on both screens)
lower screen on / off dependent on keyboard detach / attach
Auto-Rotation

Also added the keyboard_light extension to your fixed file content - great so far! Looking forward to F-Keys function what will come with newer Kernels.

@NaScha
The tablet mapping solved itself for me, I believe it was the GNOME 46 update.
For the second ond third point, if you are on nixos, here I have uploaded the part in the configuration.nix which creates the systemd services for automatic screen toggle, rotation and brightness syncronisation. I you are not on nixos, you would need to translate them to usual .service files.


Fix issue where ManageDSAit control sent

When ManageDSAit control was sent, the Control Value are expected to be empty.
Instead what happen previously,  a whitespace was sent as a result of the encoding process. This causes the backend ldap to complain and returns an error.
This change ensures that no whitespace are sent in the control value.

Awesome thanks @elan100cs!


Tune 404 error message

https://url-shortener.cdssandbox.xyz/abcdefgh
causes a slack error on a 404

This has been done and is part of https://github.com/cds-snc/url-shortener/pull/252 (forgot to close out the ticket in the PR 😞 )


SConsCPPScannerWrapper crashes on directives involving digits

This issue was originally created at: 2014-03-31 15:41:13.
This issue was reported by: scottd.
scottd said at 2014-03-31 15:41:13

SConsCPPScannerWrapper crashes (and causes scons to exit) when encountering certain preprocessor directive patterns involving leading digits.  For example, given a SConstruct file like this:

import SCons.Scanner
env = Environment(CPPPATH=['.'])
f = env.File("a.cpp")
scanner = SCons.Scanner.C.SConsCPPScannerWrapper('prescanner','.')
includes = scanner(f, env)
print "\na.cpp includes:"
for i in includes:
    print "  + %s" % str(i)

and a a.cpp file like this:

#define USE(X) (defined WTF_USE_##X  && WTF_USE_##X)
#if USE(3D)
#endif

scons crashes thusly:

scons: Reading SConscript files ...
  File "<string>", line 1

    USE(3D)

         ^

SyntaxError: invalid syntax

(The problem goes away if the source uses, say, "THREED" instead of "3D").

Just tried this example, and it doesn't show this problem (SConstruct needed modernizing for print -> `print()``). @bdbaddog okay to close?

sure. if it's fixed, close away! :)

Closing - anyone can feel free to reopen if this is still an issue.

Hmmm, clicked close with comment and it didn't. try again...


Increase size of vscode codeicons

I am following this section of the wiki to get vscode like icons https://github.com/hrsh7th/nvim-cmp/wiki/Menu-Appearance#how-to-add-visual-studio-code-codicons-to-the-menu
However they appear much smaller on mine than the example screenshot, is there any way to increase their size?

This is not an issue with this plugin.
The limited size is either that the font with that symbol indicate it should be in a single cell, or it is your terminal that do not support rendering symbols on 2 cells.
I'd suggest checking your terminal's config, and if necessary, open a feature request for that.

It's out of scope of nvim-cmp. Please organize your terminal settings.

This is not an issue with this plugin. The limited size is either that the font with that symbol indicate it should be in a single cell, or it is your terminal that do not support rendering symbols on 2 cells. I'd suggest checking your terminal's config, and if necessary, open a feature request for that.

Hi thank you for the explaination, what should i be looking for in my terminal config ? Just fyi i use the gnome terminal in ubuntu with zsh and tmux if that helps.

It's out of scope of nvim-cmp. Please organize your terminal settings.

Okay,, could you give me an idea what i should be looking for? What are you suggesting when you say organise terminal settings? I'm really  unsure what i shiuld be looking for

Im also using the https://github.com/be5invis/Iosevka font "Iosevka Regular Term", could it be an issue with the font i use?

Really sorry but I don't familiar to terminal so I can't suggest any solution.
I want only to say it's out of scope of nvim-cmp.


EDU-649 Add plugin help overlay

Closes https://educandu.atlassian.net/browse/EDU-649

Looks nice (and it's such a helpful feature, I hope)!


Package download fails if Nuget artifact provided

Describe the bug
We provide https://www.nuget.org/api/v2/package/OpenCvSharp4.Extensions/<IP_ADDRESS>40103 to ORT to download but it fails with:

IOException: Could not resolve provenance for package 'NuGet::OpenCvSharp4.Extensions:<IP_ADDRESS>40103' for source code  origins [VCS, ARTIFACT]. Resolution of ARTIFACT failed with: IOException: Could not verify existence of source artifact at https://www.nuget.org/api/v2/package/OpenCvSharp4.Extensions/<IP_ADDRESS>40103. HTTP request got response 404.

This is most probably due to the HEAD check we do here: https://github.com/oss-review-toolkit/ort/blob/bd4e76e996c7d99820dd884cea104276d4ee9861/scanner/src/main/kotlin/provenance/PackageProvenanceResolver.kt#L144 which does not follow redirects. This seems to be an odd behavior Nuget has breaking the correct lookup.
We should discuss whether it makes sense to do the HEAD or broaden the cases for the GET fallback.

Console / log output
n/a
Environment
 environment:
    ort_version: "25.1.0"
    build_jdk: "11.0.23+9"
    java_version: "17.0.11"
    os: "Linux"```

### Additional context

Add any other context about the problem here.

This is most probably due to the HEAD check we do here:
[...]
which does not follow redirects.

Actually, the requestSourceArtifact() helper function uses our pre-configured okHttpClient which does follow redirects (both SSL and non-SSL) by default.
Additionally taking into account what @georg-eckert-zeiss wrote, I'm closing this as won't fix.


Use C++11 compiler for continuous integration

It would be nice to use C++11 features in diff_match_patch. However, the Travis CI builds use older versions of gcc and clang that don't support C++11. Since C++11 support is generally widely available, could the Travis CI builds be updated to use newer compilers?
This would permit the use of:

lambdas
initializer lists
>> for nested template arguments
unordered_map
and more

Would the solution described in
C++11 Support with Travis-CI using g++
be appropriate?

IMHO, we can just switch to gcc-5. It is available from the same PPA.
Updates to llvm are described at http://llvm.org/apt/.
But, shouldn't this be addressed by the Travis CI people?

Enabled C++11 in the build and using Trusty 14.04 as environment  237a824 and 7f95b37.


[Tooltip] Custom component as children do not work

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
If I try to use a tooltip wrapping a chip, the tooltip doesn't show up until I click on the chip, after that the tooltip appear all the time
It seems that this behavior only happens when there is a onDelete prop being passed through
if the onDelete prop isn't passed the tooltip doesn't show up at all
Expected Behavior 🤔
The tooltip should appear all the time when I hover a chip
Steps to Reproduce 🕹
https://codesandbox.io/s/check-tooltip-with-chip-bug-pqjxp
Steps:

Hover the chip, that haves (the tooltip doesn't show up)
Click on the chip (the tooltip starts to show)

Context 🔦
I want to have small icons (or just some initials) inside the chip and if someone pass the mouse through it it should show the full text (the chip have a house, when you hover the text have written home for example)
Your Environment 🌎
I am only using the @material-ui/core in the the example and it happens

`npx @material-ui/envinfo`
  System:
    OS: Linux 5.4 Linux Mint 20.2 (Uma)
  Binaries:
    Node: 14.16.0 - ~/.nvm/versions/node/v14.16.0/bin/node
    Yarn: Not Found
    npm: 7.11.2 - ~/.nvm/versions/node/v14.16.0/bin/npm
  Browsers:
    Chrome: 91.0.4472.164
    Firefox: 90.0
  npmPackages:
    @material-ui/core: ^4.9.5 => 4.11.4
    @material-ui/icons: ^4.9.1 => 4.11.2
    @material-ui/styles: ^4.11.1 => 4.11.4
    @material-ui/system:  4.11.3
    @material-ui/types:  5.1.0
    @material-ui/utils:  4.11.2
    @types/react:  17.0.4
    react: ^16.11.0 => 16.14.0
    react-dom: ^16.11.0 => 16.14.0
    styled-components: ^3.2.3 => 3.4.10
    typescript:  3.9.9

If you check the console, there is a warning:
Warning: Failed prop type: The prop `children` is not supported. Please remove it.
    at Chip (https://pqjxp.csb.app/node_modules/@material-ui/core/esm/Chip/Chip.js:247:26)
    at WithStyles (https://pqjxp.csb.app/node_modules/@material-ui/styles/esm/withStyles/withStyles.js:47:31)
    at Chip (https://pqjxp.csb.app/src/Chip.js:43:23)
    at Tooltip (https://pqjxp.csb.app/node_modules/@material-ui/core/esm/Tooltip/Tooltip.js:177:28)
    at WithStyles (https://pqjxp.csb.app/node_modules/@material-ui/styles/esm/withStyles/withStyles.js:47:31)
    at WithStyles (https://pqjxp.csb.app/node_modules/@material-ui/styles/esm/withStyles/withStyles.js:47:31)
    at Tooltip (https://pqjxp.csb.app/src/Tooltip.js:43:3)
    at div
    at App
```

The component passed as children to the Tooltip, must be a forward ref component. Here is a working codesandbox https://codesandbox.io/s/check-tooltip-with-chip-bug-forked-0po2j See the changes in the `Chip.js`

Thanks a lot for your help @mnajdova


remove incorrect use of "using statement"

Address incorrect use of "using statement" to refer to a "using directive".

@mrlacey : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Update k8sapi

update k8sapi version from v0.13 to v0.15

Thanks for the PR. I think it makes sense to update the dependency. I am wondering how you created the 4.6 version API though. Last time I checked (and that is a while back) there was no API spec published after 4.5.

Thanks for the PR. I think it makes sense to update the dependency. I am wondering how you created the 4.6 version API though. Last time I checked (and that is a while back) there was no API spec published after 4.5.

Thanks for the PR. I think it makes sense to update the dependency. I am wondering how you created the 4.6 version API though. Last time I checked (and that is a while back) there was no API spec published after 4.5.

there is no 4.6 specification published, the 4.6 version is only used to mark the implementation of different versions of k8s-openapi.

Ok, so in that case there shouldn't be any 4.6 version. As that wouldn't reflect any of the 4.6 APIs.
I think the appropriate step would be to migrate to a newer k8s_openapi version, as you did, and then simply re-generate the APIs up to 4.5. Changing the version of this crate to 0.2.x.


indicate slave images are jnlp images

@gabemontero @mmilata @smarterclayton fyi.  this may fix some of the extended test issues we've seen w/ pipelines (I haven't audited the failures to see if any of them were related to us trying to run steps in the wrong container now that the k8s plugin was putting 2 containers in the pod)


Add section for gettft

add docs for gettft and how to do buy with fiat

Updates to the library regarding GETTFT.com
https://github.com/threefoldfoundation/info_threefold_pub/commit/72da26fa366cc9b9654cc19dbbab06ef7402bc39
https://github.com/threefoldfoundation/info_threefold_pub/commit/e461e96447826e5f28dd787a112f5513cac25882
Detailed manual on GETTFT we decided not to write down since GETTFT.COM is mostly self-explanatory.


Better Registration Application Data Support

When a register request is received, the Authorizer is responsible to decide if client registration is accepted or not.
Often this Authorizer gathers data about this client which can be necessary to attach to the registration.
We already have some kind of API to do that :

Authorizer.isAuthorized() returns a Registration and so a custom Registraton can be created (but that sounds not so good because this implies to create custom RegistrationStore too to handle it.
Then we add Map<String, String> getApplicationData() and so this will be automatically handled by RegistrationStore implementation. (#1018)

But neither 1) nor 2) supports Application Data update on  Registration Update Request.
Maybe we should change the API of Authorizer to make it returns ApplicationData on success.
Then used this Application Data :

to create Registration on RegistrationHandler.register
to create RegistrationUpdate which can handle ApplicationData modification on RegistrationHandler.update.

(Note : there was a bug until  3ceb0092998ebbe0d4922a29e315389e2a6d948c : Application Data was lost on update.)

I'm working on this at #1361

Intregrated (PR #1361) in master (should be available in 2.0.0-M10)


app-emulation: add qemu port

Some notes:

The second patch should be removed once managarm/mlibc#311 is merged.
Running qemu in a vm with more than one core may cause a kernel page fault.

Nope it's not blocked on mlibc, it should compile just fine with current master.

LGTM


Fix bug in IMEXARKAlgorithm, add HOMMEM1

PULL REQUEST
Purpose and Content
This PR fixes a big in the IMEX ARK scheme that was causing the implicit tendency to not be recorded for the last Newton iteration (it was being recorded for the pre-last Newton iteration). It also adds the HOMMEM1 IMEX ARK method, which Oswald asked to have available.
Benefits and Risks
The linear IMEX unit test now only requires one Newton iteration to give the expected convergence orders, whereas before it required 2 (using more iterations does not change the convergence order, as the problem is linear). This should fix some of the issues we've been seeing in ClimaAtmos.
PR Checklist

[ ] This PR has a corresponding issue OR is linked to an SDI.
[ ] I have followed CliMA's codebase contribution and style guidelines OR N/A.
[ ] I have followed CliMA's documentation policy.
[ ] I have checked all issues and PRs and I certify that this PR does not duplicate an open PR.
[ ] I linted my code on my local machine prior to submission OR N/A.
[ ] Unit tests are included OR N/A.
[ ] Code used in an integration test OR N/A.
[ ] All tests ran successfully on my local machine OR N/A.
[ ] All classes, modules, and function contain docstrings OR N/A.
[ ] Documentation has been added/updated OR N/A.

bors try

bors r+


feat: use browserify to bundle hoodie client (#532)

This makes the /hoodie/client.js request use Browserify to bundle an up to date version of @hoodie/account-client instead of delivering the prebuilt version in /dist.
For more details see issue #532.

LGTM, great work 👍. I’ve checked it locally with hoodie-app-tracker and its integration tests and they all pass.
Ping @hoodiehq/maintainers for 2nd 👀

Is this a breaking change since it changes the hoodieClientPath?
Otherwise, LGTM 👍

Once @HipsterBrown has his question answered, this LGTM. Thanks @sdvg! ✨

LGTM

@HipsterBrown @Charlotteis
This change is part of the browserify on demand
-  var hoodieClientPath = path.join(hoodieClientModulePath, 'dist/hoodie.js')
+  var hoodieClientPath = path.join(hoodieClientModulePath, 'index.js')

Instead of using the pre-built file at dist/hoodie.js, we now need the main file of @hoodie/client which is index.js. So it’s all good, it’s only the input path. The output path remains the same.
Thanks for your reviews everyone, this is great 👏 I’ll go ahead and merge it now


How can I change the "back" button to another word in the submenus?

Basically the title, how can change it to something else? Couldn't find it anywhere.

Search for back in /assets/js/jquery.dlmenu.min.js and change back to something else.


Associated iterator types for InspectEnumerable

The current definition of the InspectEnumerable traits forces you to use Box<dyn Iterator> for the method return types. Given that the iterator types can usually be named (and that impl Trait in traits is a long ways away) I think it would be beneficial to define associated types for each method:
pub trait InspectEnumerable<AccountId>: Inspect<AccountId> {
    type CollectionsIter: Iterator<Item = Self::CollectionId>;
    type ItemsIter: Iterator<Item = Self::ItemId>;
    type OwnedIter: Iterator<Item = (Self::CollectionId, Self::ItemId)>;
    type OwnedInCollectionIter: Iterator<Item = Self::ItemId>;

	/// Returns an iterator of the collections in existence.
	fn collections() -> Self::CollectionsIter;

	/// Returns an iterator of the items of a `collection` in existence.
	fn items(collection: &Self::CollectionId) -> Self::ItemsIter;

	/// Returns an iterator of the items of all collections owned by `who`.
	fn owned(who: &AccountId) -> Self::OwnedIter;

	/// Returns an iterator of the items of `collection` owned by `who`.
	fn owned_in_collection(
		collection: &Self::CollectionId,
		who: &AccountId,
	) -> Self::OwnedInCollectionIter;
}

These associated types could always be defined as boxed iterators if the implementer can't/ doesn't feel like explicitly naming the types.
I would be happy to take this on myself if it's accepted :+1:

Sounds reasonable.


Vimeo API blocked when used on HTTPS

I am using the plugin on a website that is using HTTPS. Chrome blocks the request to 'http://www.vimeo.com/api/v2/video/':
This request has been blocked; the content must be served over HTTPS.

I think the API url should not be hard-coded or use HTTPS by default.
Bests,

Hello Markus,
Thank you for using the plugin - as you  can see in the description of this project I've made a hardcopy of: https://github.com/videojs/videojs-vimeo and fixed a major bug for an private project. You can use this repository (with the bugfix) with npm i videojs-vimeo-v2. I've also included a bugfix for this issue.
Br,
Dominik


Export test

[x] Add a unit test to check some robots are exported as expected (replace #12)
[x] Test motoman

[x] Fix --output argument (which was not used ^^)
[x] Fix return code

For now, only the motoman arm export is tested.
Better than nothing.
The other modules would require to add xacro in travis which is not obvious.
👍


Timex.shift/2 gives wrong year when shifting by negative months over a year boundary

But only if it is a shift less than 12 months, and doesn't end up in December (12)
Steps to reproduce

Timex.shift/2
%Timex.Date{years: 2016, months: 5, days: 19}, months: -6

Timex.shift(%Timex.Date{years: 2016, months: 5, days: 19}, months: -6)
Expected: #<Date(2015-11-19)>
Actual: #<Date(2016-11-19)>

Description of Issue
This works for any negative month number that causes a result in November or earlier in the previous year. It works as intended for results in December (using months: -5 gives the expected result of #<Date(2015-12-19)> in this case).
Some other interesting tidbits, I get the expected result when shifting by -12 months, but -12 gives the same result as -24.

Fixed in #175


Support Partial/Filtered Unique Index for PostgreSQL and SQL Server

Problem
tl;dr - Support for Postgres Partial Indexes and related functionality
Consider, for ex, a versioned CMS schema
model Page {
  id                Int       @id @default(autoincrement)
  staticId          String
  isLatest          Boolean
  previousVersionId Int?
  previousVersion   Workflow? @relation("pagePreviousVersion", fields: [previousVersionId], references: [id])
  nextVersion       Workflow  @relation("pagePreviousVersion")
}

New entries for the same page (i.e. identical staticId) are created by adding a new entry with isLatest=true and setting isLatest=false on the old one. We want to enforce that only one version is ever latest, so we have a partial index on staticId where isLatest=true.
It looks like Prisma is mostly peaceful with this except for a few things:

Introspect will try to create these as full unique indexes (i.e. @@unique), which is incorrect
post.findOne won't allow {where: {staticId: '...', isLatest: true}} because there's no way to tell it that this guarantees uniqueness.

Suggested solution
Partial index support ala @@unique([staticId], where={isLatest: true}) would be great.
Alternatives
I can probably work around this with findMany(...)[0], but flagging as a feature request.
Additional context
There's another challenge in supporting this data model: AFAICT there is no way to update an object at the same time as connecting it. It seems like right now I can run:
const page = prisma.page.create({
  data: {
    staticId: prevVersion.staticId,
    isLatest: false,
    previousVersion: {
      connect: {id: prevVersion.id}
    }
  }
})
prisma.page.update({
  where: { id: page.id },
  data: {
    isLatest: true,
    previousVersion: {
      update: { isLatest: false }
    }
  }
})

Whereas I'd ideally like to run:
const page = prisma.page.create({
  data: {
    staticId: prevVersion.staticId,
    isLatest: true,
    previousVersion: {
      connect: {id: prevVersion.id},
      update: {isLatest: false}
    }
  }
})

Happy to file as a separate feature request as it seems mostly unrelated to partial indexes.

Slight update: my example prisma.page.update call doesn't work because of the ordering of the execution within the transaction (there's no way to make the isLatest: false happen first). This does, however, work with the transactionApi as you can specify ordering.

Can you share the SQL of the Page table above? Will make it a lot easier to understand.

How we're using this (we're currently moving over from Python/SQLAlchemy to Prisma):
CREATE TABLE pages (
    id SERIAL PRIMARY KEY,
    staticId character varying NOT NULL,
    isLatest boolean NOT NULL,
    previousVersionId integer REFERENCES workflows(id),
    # ...content/title/etc fields
);

CREATE UNIQUE INDEX pages_pkey ON pages(id int4_ops);
CREATE UNIQUE INDEX "idx_pages_unique_staticId" ON pages(staticId text_ops) WHERE isLatest = true;

Reading
The frontend gets the page for display via
SELECT * FROM pages WHERE staticId = ${staticId} AND isLatest = true;

Updating
Given a newly created page with a single revision:

id
staticId
isLatest
previousVersionId

1
page_abc
true
NULL

One would create a new version of page staticId from current latest version currentPageId:
BEGIN;
UPDATE pages SET isLatest = false WHERE id = ${currentPageId};
INSERT INTO pages ("staticId", "isLatest", "previousVersionId") VALUES (${staticId}, true, ${currentPageId});
COMMIT;

Resulting in:

id
staticId
isLatest
previousVersionId

2
page_abc
true
1

1
page_abc
false
NULL

Over at https://github.com/prisma/prisma/issues/2829#issuecomment-677834599 you mentioned:

Sounds like you're on the tail end of dev work here, but any chance of getting eyes on #3076? tl;dr - reintrospection is incorrect in a particularly bad way when using partial unique indexes, having Prisma ignore them rather than incorrectly assume they're globally unique would be a large improvement in usability for us.

Can you explain the relation to (Re)Introspection here and what the current problem is? I did assume we were ignoring this completely for now.

Right now when introspection sees a partial unique index, it treats it as a unique index. Using the example from #3076, introspection would add an @unique to staticId, which must then be removed.
#3076 as a while is a larger yak, but having introspection completely ignore PUIs (which is what I currently do when manually building our schema) would be preferable to the current behavior, as the current behavior is problematically incorrect.

Understood. Does https://github.com/prisma/prisma/issues/3373 describe the problem properly?

Yes it does, thanks!

Happy to file as a separate feature request as it seems mostly unrelated to partial indexes.

Just saw the second part of the original issue: Yes please 👍

@albertoperdomo This should be revisited now

Any news?

On SQL Server these are called "Filtered Indexes" (via): https://docs.microsoft.com/en-us/sql/relational-databases/indexes/create-filtered-indexes?view=sql-server-ver15

Partial indexes are not part of the preview feature, so I can not really say if this feature request here will come "soon". But we are certainly working through the index related gaps we have and closing them one by one.

Note from Tyler: This is needed as a performance optimization for large databases.

something I used frequently in the past and would love support for are indexes with predicates.
Example:
CREATE INDEX IDX_User_Email_ActiveOnly ON User (email) WHERE isActive = 1
The index is only utilized for queries with the isActive = 1 predicate, but the index size is significantly smaller than the alternative:
CREATE INDEX IDX_User_IsActive_Email ON User (isActive, email)
It's needed when tables are very large and an index on the whole thing is unnecessary.

Note: In a related issue, an alternative was mentioned (of course full support for these indexes would be better)
https://github.com/prisma/prisma/issues/16658

Any news?

Yes, I posted a comment in a duplicate issue asking for SQL examples so we can design this feature better: https://github.com/prisma/prisma/issues/6974#issuecomment-1483792245 Everyone who commented here or is subscribed to this issue, please go over there and comment. Thanks!
Generally, please leave comments at https://github.com/prisma/prisma/issues/6974 going forward. I am not going to close this one yet as it has a lot of upvotes, but generally #6974 is the better issue now to continue the discussion. 🙏


Default to MUMPS is MA57 is not available

This is going to become annoying:
julia> model = Model() do
           return AmplNLWriter.Optimizer(UnoSolverCommand())
       end
A JuMP Model
├ solver: AmplNLWriter
├ objective_sense: FEASIBILITY_SENSE
├ num_variables: 0
├ num_constraints: 0
└ Names registered in the model: none

julia> set_attribute(model, "preset", "ipopt")

julia> set_attribute(model, "print_solution", "yes")

julia> @variable(model, x)
x

julia> @objective(model, Min, (x - 1)^2)
x² - 2 x + 1

julia> optimize!(model)
libc++abi: terminating due to uncaught exception of type std::invalid_argument: Linear solver name is unknown

The solution is
julia> set_attribute(model, "linear_solver", "MUMPS")

julia> optimize!(model)
Problem /var/folders/bg/dzq_hhvx1dxgy6gb5510pxj80000gn/T/jl_VfYlG8/model.nl_scaled_equalityconstrained_boundrelaxed
1 variables, 0 constraints

Options:
... etc

But better options would be to:

default to MUMPS if MA57 is not available and MUMPS is
improve the error message to print the name of the available solvers and to tell the user to set the linear_solver option

I will change the default solvers based on what's available.

Maybe the same with the presets? If we haven't compiled BQPD then make -preset ipopt the default?

Quick question: you used the command set_attribute(model, "preset", "ipopt") in your code. This should be an attribute of the solver/optimizer, rather than of the model.
Would it be possible to have something like:
solver = AmplNLWriter.Optimizer(UnoSolverCommand())
set_attribute(solver, "preset", "ipopt")
...

?

There are multiple ways that you can pass options to a solver: https://jump.dev/JuMP.jl/stable/manual/models/#solver_options
None of this needs to concern Uno though. We'll pack them into the appropriate place in the CLI.

Setting the default subproblem solvers + improving the error messages was addressed in commit d8571b6.
I will address the default preset in a separate issue.

Great. I confirm that this worked in the latest build of Uno_jll


CI for each ROS distro branch

This PR is the first step in addressing the numerous issues I have seen in the repo with users encountering unexpected errors during firmware updates, such as #37, #35, and others. I outlined my plan to address this in #39, and this PR implements it.

Made the main CI GitHub Action for building firmware using PlatformIO reusable and accept parameters
Created individual GitHub Actions workflows for each ROS distro/branch that checks out that branch and calls the reusable CI to test the compilation of firmware with that ROS distro and branch
Display CI firmware build status badges on README for each ROS distro / branch to both show users what they can expect to work, and alert maintainers of issues
Scheduled nightly CI runs on each branch to update status and test for broken dependencies

The end result will be a repo that is much easier to safely add new features to, such as support for new boards (like the ESP32 PR), and more friendly to users and maintainers.
NOTE:
Before merging this PR, @grassjelly  please rename the current default branch, currently named "galactic" to master (this is in accordance with the naming of ros_control and other ROS things I looked at ) or let me know if you'd prefer main or rolling and I'll modify the PR. The reasons for this request is two-fold:

The default branch should be developed for ROS2 Rolling, not "galactic"
The galactic branch name should be available for backports to ROS2 Galactic

If this renaming is not made, this PR will behave slightly silly upon merge, (but still largely work and still be an improvement):

The table in the README's link to master will not be valid
Both the galactic and rolling actions will be run on the current default branch, "galactic", and the galactic action will fail, as the "galactic" branch's firmware/platformio.ini has a library dependency that has deprecated galactic

NOTE 2:
There will be companion PRs to the humble and foxy branches. These should all be merged at a similar time to allow the actions to work for those branches. The foxy PR also contains fixes to current deprecation issues. Upon renaming of the current "galactic" branch to something else, I will also create a PR for it.

I made an oversight and have not handled the case where ~/.platformio folder isn't created upon installing it, effecting both this PR and #46. I will fix this and update the branches.

@grassjelly what are your thoughts on names for the default branch? Do you think master, main, or Rolling? Once you change it I can make changes and get this merged (passing CI), and put in a galactic PR.

let me create a rolling branch based on humble

sounds good. I'll go through and make the README badges link to the correct place and double check the CI works correctly with that name (it should - I have it get the default branch)


Fix dockerfile

Description
There was something wrong in my previous fix. I tested it locally but probably made mistake. This one succeeded on jenkins.
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[ ] Changelog entry
[ ] Type annotations are present
[ ] Code is clear and sufficiently documented
[ ] No (preventable) type errors (check using make mypy or make mypy-diff)
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Works without  the env variables, so I removed them. Thanks for catching this!


Move graph driver to layer store

Decouple the graph drivers from the daemon, moving them behind the LayerStore abstraction.
cc @tonistiigi since we talked about this about a week ago
This should be another step closer to moving the layer/image/reference packages into a self-contained package.  There is still one things to do after this change, which is to move graphdriver registration out of the daemon package.

I just realized there is a problem with this change. I'm using daemon.configStore.GraphDriver all over to print the driver name, but that won't be set unless the user specified a --storage-driver option. If the driver is determined from the environment variable, or by inspecting the existing files, it's going to be an empty string.
I think there needs to be some way to get the selected graph driver out of the LayerStore.
I added that for just the windows restoreCustomImage, but I think I need to move it into the Layer interface unfortunately.
Do you see any other way?

I am ok with having GraphDriver() string as part of the LayerStore interface

Needs a rebase, and seems there are some compile issues.

Rebased, and I fixed the cross-compile issues by moving the registration import back to daemon/daemon for now.

LGTM

:heart: LGTM


Update namespaces to com.vaadin.polymer.

Oh and the namespace of the Sampler itself is still the old one, I was going to do that in another commit perhaps?

Review status: 0 of 46 files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io

Reviewed 46 of 46 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io


⚠ Bofrost.es has degraded performance

In edaed9c, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1730 ms

Resolved: Bofrost.es performance has improved in 6005116 after 10 minutes.


Gallery link in the overview

Included a link to the StaffHub PowerShell Gallery page that has instructions on how to install the StaffHub cmdlet module.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

staffhub/docs-conceptual/index.md
:white_check_mark:Succeeded
View (staffhub-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.