[web]: Text Editor is unusable on Flutter web because caret positioning is incorrect

Text Editor is unusable on Flutter web because the caret doesn't go where the user clicks, and the editing point for text is somewhere else again.
This is for a rewrite of my TaskAngel To-do List App (www.taskangel.com), which I am updating/converting from Windows and iOS to Flutter Web.
This issue is a show-stopper for my project because what good is a to-do list app where you can't change the text? Is anyone working on this? I am happy to help if I can.
On Mac, with Safai and Chrome the text can still be edited but the caret position has to be fine-tuned with the arrow keys.
On Android tablet with Chrome [version 84.0.4147.111], the caret goes inside the same the word that has been tapped, but to a different letter. But then if I start typing, the letter is inserted somewhere different.
On iPhone [iPhone 11 Pro max version 13.6] with Chrome [version 84.0.4147.122], if the text field has been scrolled horizontally, the cursor position when tapped is completely wrong. This also happens with Safari, and with a home page web link, on iPhone and iPad
In my text editing widget I have:
void initState() {
...
if (_task?.title == null) {
      _titleTextController = TextEditingController();
    } else {
      _titleTextController =
          TextEditingController.fromValue(TextEditingValue(text: _task.title));
    }
}

and then the page build function has:
new TextFormField(
                      style: textTheme.subtitle1,
                      controller: _titleTextController,
                       decoration: new InputDecoration(
                        hintText: 'What are you going to do?',
                        labelText: 'Task',
                        border: InputBorder.none,
                      ),
                      showCursor: true,
                      maxLines: 1,
                      keyboardType: TextInputType.text,
                      autofocus: true,

                      ),

I am building my app with this parameter set, as advised in this issue: https://github.com/flutter/flutter/issues/33523:
flutter build web --release --dart-define=FLUTTER_WEB_USE_EXPERIMENTAL_CANVAS_TEXT=true

On Mac with Safari, text editing is just about managable when you click on the text then use the arrow keys to get to where you want to change text.
On iPad, the caret goes to completely the wrong place if the text has been scrolled.
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, 1.20.2, on Mac OS X 10.15.5 19F72f, locale en)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
[✓] Chrome - develop for the web
[✓] Android Studio (version 3.6)
[✓] VS Code (version 1.48.0)
[✓] Connected device (3 available)
Thanks for any help or advice you can give me.
Thanks,
Andrew
http://www.taskangel.com

Hi @mypocketsoft
Can you please provide your flutter doctor -v, and a minimal complete reproducible code sample?
Thank you

Here's the flutter doctor -v. I'm working on the code sample.
[✓] Flutter (Channel beta, 1.21.0-9.1.pre, on Mac OS X 10.15.5 19F72f, locale en)
• Flutter version 1.21.0-9.1.pre at /Users/andrewboswell/Development/flutter
• Framework revision be9bc8cb39 (7 days ago), 2020-08-18 09:46:08 -0700
• Engine revision 267070c17a
• Dart version 2.10.0 (build 2.10.0-7.2.beta)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/andrewboswell/Library/Android/sdk
• Platform android-29, build-tools 29.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.6, Build version 11E708
• CocoaPods version 1.8.4
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 3.6)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 45.1.1
• Dart plugin version 192.7761
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
[✓] VS Code (version 1.48.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.13.2
[✓] Connected device (4 available)
• Android SDK built for x86 (mobile)  • emulator-5554                        • android-x86    • Android 8.1.0 (API 27) (emulator)
• iPhone SE (2nd generation) (mobile) • 2BEA330B-659A-476E-951D-9F208EC0FAFD • ios            • com.apple.CoreSimulator.SimRuntime.iOS-13-6
(simulator)
• Web Server (web)                    • web-server                           • web-javascript • Flutter Tools
• Chrome (web)                        • chrome                               • web-javascript • Google Chrome 84.0.4147.135
! Error: Andrew's iPad Mini is not connected. Xcode will continue when Andrew's iPad Mini is connected. (code -13)
! Error: Lizzie's iPad is not connected. Xcode will continue when Lizzie's iPad is connected. (code -13)
! Error: Andrew’s iPhone is not connected. Xcode will continue when Andrew’s iPhone is connected. (code -13)
• No issues found!

Could you please provide a minimal complete reproducible code sample and clarify the expected vs actual behavior (with a video for example)?

Here is the minimum reproducible code sample. The fault is most evident when running the web app on a mobile device, eg iPhone Chrome or Android Tablet Chrome. The fault is less evident when running on my MacBook with chrome.
Expected behaviour:
Scroll up towards the end of the text. Then when tapping a word in the text editor, the caret should move to the character in the text that was tapped, so that the text there can be edited.
Actual behaviour:
When tapping a word in the text editor, the text scrolls towards the start of the text and the caret moves to a random point on the top line. This is the wrong position for the text to be edited.
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Text Editor',
      theme: ThemeData(
        primarySwatch: Colors.blue,
        visualDensity: VisualDensity.adaptivePlatformDensity,
      ),
      home: MyHomePage(title: 'Flutter Text Editor'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);
  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;
  String _text = """
Lorem ipsum dolor sit amet, consectetur adipiscing elit. In ac vulputate nibh. Vivamus at lacus vel metus viverra semper. Ut maximus orci sed odio congue, id gravida arcu facilisis. Maecenas egestas, magna sed aliquam hendrerit, est leo volutpat sapien, varius convallis elit ante quis eros. Fusce non quam at dui aliquet fringilla vel a leo. Donec placerat mauris nec congue lobortis. Nullam sit amet orci ipsum. Nullam quis dolor vitae urna lobortis dignissim eget ut libero. In in pulvinar lorem. Phasellus ac tortor id risus feugiat feugiat vitae vel risus. Morbi porta arcu eget tellus hendrerit congue. Maecenas suscipit et risus ac commodo. Nullam mattis vel leo sed fermentum. Mauris volutpat sit amet neque nec ornare. Suspendisse ex sapien, pretium sit amet ante nec, dictum sagittis augue.\n\n""";
  var _textEditingController = TextEditingController();

  @override
  void initState() {
    _text = _text + _text + _text + _text + _text;
    _textEditingController.text = _text;
    super.initState();
  }

  @override
  Widget build(BuildContext context) {

    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Container(
        padding: EdgeInsets.symmetric(vertical: 20.0, horizontal: 50.0 ),
        child: TextField(
          decoration: new InputDecoration.collapsed(
          hintText: 'Your text'
        ),
          controller: _textEditingController,
          maxLines: null,
        )
      ));
      }
}

Reproducible on the latest master 1.22.0-2.0.pre.78.

Minimal reproducible code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  final controller = TextEditingController(
      text:
          "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.\n\n"
             * 10);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Sample',
      home: Scaffold(
        appBar: AppBar(
          title: Text('Sample'),
        ),
        body: Container(
          child: Center(
            child: SingleChildScrollView(
              child: TextField(
                controller: controller,
                maxLines: null,
              ),
            ),
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[√] Flutter (Channel master, 1.22.0-2.0.pre.78, on Microsoft Windows [Version 10.0.19041.450], locale en-US)
    • Flutter version 1.22.0-2.0.pre.78 at C:\Development\flutter_master
    • Framework revision d0596582fe (2 hours ago), 2020-08-25 23:26:06 -0700
    • Engine revision b1d9f863db
    • Dart version 2.10.0 (build 2.10.0-56.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at C:\Users\marku\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.6.5)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.6.30320.27
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.0)
    • Android Studio at C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] Connected device (5 available)
    • SM G950F (mobile)           • ce12171c51cc001c03 • android-arm64  • Android 9 (API 28)
    • sdk gphone x86 arm (mobile) • emulator-5554      • android-x86    • Android 11 (API 30) (emulator)
    • Windows (desktop)           • windows            • windows-x64    • Microsoft Windows [Version 10.0.19041.450]
    • Web Server (web)            • web-server         • web-javascript • Flutter Tools
    • Chrome (web)                • chrome             • web-javascript • Google Chrome 84.0.4147.135

• No issues found!

Was able to repro this on iOS and Android browsers but couldn't on desktop.

/cc mdebbar

The root cause of this issue is https://github.com/flutter/flutter/issues/41630. Please react with a thumbs up to that issue to show that you are affected by it.


The performance is worse after turning on mkldnn

Click to expand!
Issue Type
Performance
Source
source
Tensorflow Version
2.4.1
Custom Code
No
OS Platform and Distribution
centos7
Mobile device
No response
Python version
3.8.6
Bazel version
3.1.0
GCC/Compiler version
10.2
CUDA/cuDNN version
N
GPU model and memory
N
Current Behaviour?
The performance is worse after turning on mkldnn.
compile command without mkldnn：
bazel build --config=nogcp   --config=nohdfs  --config=noaws --config=nonccl -c opt --copt=-march=native //tensorflow:libtensorflow_cc.so

compile command with mkldnn：
bazel build --config=mkl --config=nogcp   --config=nohdfs  --config=noaws --config=nonccl -c opt --copt=-march=native  //tensorflow:libtensorflow_cc.so

performance with mkldnn：
Number of nodes executed: 2628
============================== Summary by node type ==============================
	             [Node type]	  [count]	  [avg ms]	    [avg %]	    [cdf %]	  [mem KB]	[times called]
	         _MklFusedMatMul	       33	    56.488	    83.143%	    83.143%	    55.356	       33
	            StridedSlice	     1449	     4.799	     7.063%	    90.206%	    66.120	     1449
	            _MklConcatV2	       14	     2.766	     4.071%	    94.277%	   118.188	       14
	                   Const	      737	     1.379	     2.030%	    96.307%	     0.000	      737
	                    NoOp	        1	     0.934	     1.375%	    97.682%	     0.000	        1
	                    _Arg	      303	     0.422	     0.621%	    98.303%	     0.000	      303
	                    Pack	        1	     0.216	     0.318%	    98.621%	     1.080	        1
	             _MklSoftmax	        5	     0.196	     0.288%	    98.909%	     4.724	        5
	                _MklToTf	       31	     0.169	     0.249%	    99.158%	     0.000	       31
	             _MklReshape	        6	     0.136	     0.200%	    99.358%	     5.472	        6
	     _MklInputConversion	        5	     0.105	     0.155%	    99.513%	     9.120	        5
	                     Sum	        5	     0.103	     0.152%	    99.664%	     5.120	        5
	              ExpandDims	       24	     0.097	     0.143%	    99.807%	     0.000	       24
	                 _MklMul	        5	     0.096	     0.141%	    99.948%	    41.984	        5
	                    Sqrt	        2	     0.010	     0.015%	    99.963%	     0.008	        2
	                 Sigmoid	        2	     0.009	     0.013%	    99.976%	     0.000	        2
	               IdentityN	        1	     0.007	     0.010%	    99.987%	     0.000	        1
	                     Mul	        1	     0.005	     0.007%	    99.994%	     0.000	        1
	                 _Retval	        3	     0.004	     0.006%	   100.000%	     0.000	        3

Timings (microseconds): count=1 curr=67941
Memory (bytes): count=1 curr=307172
2628 nodes observed

performance without mkldnn：
Number of nodes executed: 1905
============================== Summary by node type ==============================
	             [Node type]	  [count]	  [avg ms]	    [avg %]	    [cdf %]	  [mem KB]	[times called]
	            StridedSlice	     1449	     8.448	    48.678%	    48.678%	    66.120	     1449
	            _FusedMatMul	       33	     5.554	    32.002%	    80.680%	    25.260	       33
	                ConcatV2	       14	     1.302	     7.502%	    88.182%	   105.420	       14
	                    _Arg	      303	     0.737	     4.247%	    92.429%	     0.000	      303
	                   Const	       50	     0.370	     2.132%	    94.561%	     0.000	       50
	                    Pack	        1	     0.238	     1.371%	    95.932%	     1.080	        1
	                 Reshape	        6	     0.176	     1.014%	    96.946%	     0.000	        6
	                    NoOp	        1	     0.136	     0.784%	    97.730%	     0.000	        1
	                 Softmax	        5	     0.125	     0.720%	    98.450%	     0.000	        5
	              ExpandDims	       24	     0.108	     0.622%	    99.072%	     0.000	       24
	                     Sum	        5	     0.089	     0.513%	    99.585%	     5.120	        5
	                     Mul	        6	     0.040	     0.230%	    99.816%	     0.000	        6
	                    Sqrt	        2	     0.010	     0.058%	    99.873%	     0.008	        2
	                 Sigmoid	        2	     0.009	     0.052%	    99.925%	     0.000	        2
	               IdentityN	        1	     0.009	     0.052%	    99.977%	     0.000	        1
	                 _Retval	        3	     0.004	     0.023%	   100.000%	     0.000	        3

Timings (microseconds): count=1 curr=17355
Memory (bytes): count=1 curr=203008
1905 nodes observed

According to profile above, there are more const operators when mkldnn is enabled, and the performance of many operators becomes worse.

Standalone code to reproduce the issue
N

Relevant log output
No response

I just found that changing the mkl of the bazel compilation option to mkl_threadpool and turning on -O3 optimization has greatly improved the performance.

In addition, after mkl is turned on, new Const nodes will be created through the GetDummyMklTensorNode method of mkl_layout_pass, and these nodes are particularly time-consuming in inference, resulting in slower performance after mkl is turned on. Is there any way to remove the PartitionedCall operator?

could you please provide us a reproducer? mkl tensorflow builds will usually require you to set up openmp variables
export OMP_NUM_THREADS=

@baoachun
As preethi mentioned, you might need configure Openmp to achieve better performance.
You could refer to below article for more details.
https://www.intel.com/content/www/us/en/developer/articles/technical/maximize-tensorflow-performance-on-cpu-considerations-and-recommendations-for-inference.html
Moreover, after TF 2.9 (pip install tensorflow), oneDNN (mkldnn) is enabled by default, you don't need to build TF with  --config=mkl for using mkldnn.  In Official TF 2.9, you also don't need to configure openmp for oneDNN(mkldnn) because it use eigen threadpool instead.
Could you try you workload on official TF 2.9?
In the meantime, MklFusedMatMul indeed might have some slight performance drop, but the drop should be less than 10%.
oneDNN team will also work on further optimization on MklFusedMatMul.

@aice-support
@baoachun
Have you try your workload on official TF 2.9?
Moreover, what platform do you use?
Official TF 2.9 turns on oneDNN optimization by default on Intel Xeon CLX, CPX and ICX.

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


Fixes: #4545, added new progressBar

Fixed: #4545
It prevents jumping of content (unread message cards), when loading ends.

LoadingBar has two types one as shown in image and one is regular type depends on decimal ∈ [0,1]

Thanks for doing this!
Two quick comments:

Did you copy the ProgressBar code from another library? It's great to use other libraries, but we should try to include them in package.json so we can easily keep them up to date. This looks like a slightly edited version of Bar.js from oblador/react-native-progress — is there a reason you can't pull that file in from NPM instead?
It's great that you included the Fixes:  in the commit, but that should probably go at the end of the message. The first line should be easily readable without knowing the issue number, maybe something like HomeScreen: Replace "Connecting" spinner with indeterminate progress bar?

yes i copied that from library that you mentioned because I really didn't find any way to tackle the warning showing below

And before that I thought we need only horizontal progressbar then why to add the whole module, also we already have circular loading etc.
Please look at #4516 also how I got stuck with lot of failed tests , while writing this I realy didn't care about flow type or mentioned rules, so  this time tried without any warnings. I will be glad if you write something on the Idea of the PR #4516 and that's not copied from anywhere for sure.
I learned how types works and helps :)

I started a CZO thread to talk about how to handle this, I expect someone who knows more about flow than I do will chime in there :)

@WesleyAC
Should I force push the changes I did based on the solution in CZO thread ?
I changed the connecting spinner with indeterminate progress-bar in StreamTabsScreen also.
see how its looking :)

Yes, go ahead and push!

I made changes in  ChatNav and PMConversationScreen too, they were also containing connecting-Spinner and had same issues

I'm confused about how the loading bar goes away with this code — can you explain what triggers that?

Within the file common/progressBar.js as image below

A pre-defined selector provides the loading status and makes progress bar go away, so visibility of progress is independent from the screens same as previously implemented you can see in the file common/loadingBanner.js

Also, can you delete src/common/LoadingBanner.js in this commit? Since we won't be using it anymore.

No, once look at common/screen.js and this screen component used in many screens and connecting spinner looks pretty cool too! that's why I leave it.

@WesleyAC
Now it is ready for another review,
Instead of height i changed to bottomMargin, as height is NAVBAR_SIZE

@WesleyAC
Now it is ready for another review, i changed magic number :D to barHeight and it is using as bottom margin and height of bar also,
:)

@gnprice

Would you post a screencap showing what this looks like on that screen?

there it is!

one is above also


File Highlight and dynamically loaded content

Hey,
first of all: great work here!
I got a documentation page where I load some views via AJAX. I know that I must call Prism.highlightAll(); when I want to get Prism working on dynamically loaded content. But somehow this doesn't work with all the additional plugins like File Highlight or Line Highlight. They just don't apply.
Is this on purpose, a bug or what can I do to get them also running on dynamically loaded content? :)

Hey @morkro can you try it? It should be fixed now.

I consider this issue was fixed by #514.


Updating published sv2v

Firstly, thank you for all your work maintaining releases for HDL tools! I’m sure many appreciate the ease and simplicity this setup provides. I also periodically check in on the results at https://github.com/chipsalliance/sv-tests, which uses the package versions published here.
I've noticed that the version of sv2v under test has recently become stale (~7 weeks old). Although https://anaconda.org/LiteX-Hub/zachjs-sv2v has been updated regularly, it seems that because the other packages over at https://github.com/hdl/conda-misc have had failures, the newer versions of sv2v have not been given the main tag.

Would it make sense to update the main tag for independent (sets of) packages, even if there are adjacent/unrelated failures?
Regardless of the above, would it be appropriate to move sv2v from conda-misc to conda-eda? All of the other tools tested by sv-tests are packaged here in conda-eda, while sv2v is packaged in the less-active conda-misc. It seems like sv2v might be more accurately placed here, and would naturally benefit from the greater failure visibility this repo receives.

Hi @zachjs .
This is correct, we're working on bringing back conda-misc back to fitness.
Updating independent sets of packages is a great idea, but it's a maintenance pain. Frankly speaking, this should be somehow doable by GHActions, but it's not.
Either way, moving this to conda-eda makes sense. I will try it immediately.

I created a PR #143
@zachjs I'm thinking which directory would be the best for sv2v. conda-eda/misc?

Thank you very much for working on this! It seems like conda-eda/sv-front/ might be appropriate? That said, either folder would work, of course.

Right, sv-front makes sense. There was a hiccup in the CI, but hopefully it will pass now

This is merged to master, and the package is updated. I'm closing the issue, but feel free to reopen/create a new one if needed

Thank you very much for your quick work!


fix: for emphasis, include the case where the end of the content string is an escape sequence

Checklist

[x] Used only camelCase variable names.
[x] If functionality is added or modified, also made respective changes to the readme.
[x] Used conventional commits keywords.

Some cases I missed yesterday:
abc *\*t* def
abc _\_t_ def
abc ~~\~t~~ def
abc ==\=t== def

abc *t\** def
abc _t\__ def
abc ~~t\~~~ def
abc ==t\=== def

abc *\** def
abc __\___ def
abc ~~\~~~ def
abc ==\=== def

*\** def
__\___ def
~~\~~~
==\===

It'll be a lot easier to code this if Lua had proper eregex! Or maybe I can just use Treesitter instead and figure out how to find the nearest scopes.

Thx


chore(examples): add mobile design for media demo

This adds mobile design for the media demo.
Preview
See here
Related

The parent PR
Design

@francoischalifour About the categories and locations being broken on the desktop, I think it has something to do with the mobile widgets.
When I comment out categoriesMobile from search.ts, the categories on the desktop start showing correctly.
Do you have any clue on this?

@eunjae-lee It could be because they use the same panel?

@francoischalifour oh you're right. Thanks!


Button not displayed on iFrame

In my code, i have used
` CardAction plButton = new CardAction()
{
Value = "https://en.wikipedia.org/wiki/Pig_Latin",
Type = "openUrl",
Title = "Submit"
            };
            CardAction plButton1 = new CardAction()
            {
                Value = "https://en.wikipedia.org/wiki/Pig_Latin",
                Type = "openUrl",
                Title = "Submit"

            };

but, on web page it is displayed as hyperlink, while on emulator it is displayed like button. what i did wrong? attached the snapshot.

`

Hi @HardikShah289 the webchat currently does not display cards - this is a known issue that we are working on. We will be posting news on our blog when we have a webchat update, thanks.


Cache screens

Discussion https://twitter.com/Dimillian/status/1615029025902329857
https://twitter.com/Dimillian/status/1615058938202030081?s=20&t=iXZZFWeYrAwEjU-mfznL1A
This doesn't look that great tho as the system gets confused for the tab bar background and the navigation bar sizing
Also have an issue with the wrong navigation title appearing

            TabView(selection: $navigation.selectedScreen) {
                ForEach(navigation.screens) { screen in
                    screen
                        .tag(screen)
                        .id(screen)
                        .opacity(screen == navigation.selectedScreen ? 1.0 : 0)
                }
                ScreenIdentifier.showMore
                    .tag(ScreenIdentifier.showMore)
                    .id(ScreenIdentifier.showMore)
            }
            .tabViewStyle(.page(indexDisplayMode: .never))

I liked but the safe area is messed up.


Update Release workflow to create a git tag, github release, and publish to npm

Also requires approval for publishing new versions using the "prop" github environment

#114 seems like it should be required before this is merged, it's too much of a security hole.


Please add an open source license

preferably MIT
But any of the GPL licenses would be fine too.

Hey, it is Apache 2.0, as specified in README file ;)

Ah, ok.
I was expecting an file called "LICENSE"


Modified section "Custom Parameters"

In explanation of how to use the Custom Parameters, the doc shows that as project must be use ga4: (key  of second level of section var:).
But to use the Custom Parameters with the models that I defined in the my project (that obivously uses the package ga4) I must said to ga4 that the model <my_model> associated to that Custom Parameters (<my_model>_custom_parameters) is in <my_project> and not in ga4.
I propose this modify because i think that this aspect needs a more clear explanation.

[X] I have verified that these changes work locally
[X] I have updated the README.md (if applicable)
[X] I have added tests & descriptions to my models (and macros if applicable)
[X] I have run dbt test and python -m pytest . to validate exists tests

This change to the docs would mislead anyone adding custom parameters to the built-in staging models that should be nested under a ga4: block.
This is a dbt knowledge issue rather than a package issue, so I'm not sure that we should  change the docs at all.
However, if we were to change the docs to make it easier for people new to dbt starting out using the package, then I would prefer that we create a new section on Adding Custom Events where we cover how to add staging models, different ways of supporting custom parameters on staging models, and warn there that vars and model configs nested under a ga4 node won't affect custom events defined in the project and that you should set those under a project id node.

Hi @dgitis,
I think your idea is a good idea. By adding a new section to the document, we can add this new information without changing the original intent of the document.

Created Issue #135 and will close this PR.


New terraform version does not allow zone_id and zone_name to be used together

Description
It seems that somewhere between terraform vesion 1.2.3 and 1.3.4 TF no longer allows zone_id and zone_name to be used together for some reason.
This means that the records data block on line 10 is failing
Error: zone_id and name arguments can't be used together
│
│   with module.route53_records["domain.com"].data.aws_route53_zone.this[0],
│   on .terraform/modules/route53_records/modules/records/main.tf line 10, in data "aws_route53_zone" "this":
│   10: data "aws_route53_zone" "this" {

[x] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]:

Terraform version: 1.3.4

Provider version(s): provider registry.terraform.io/hashicorp/aws v4.39.0

Reproduction Code [Required]

Steps to reproduce the behavior:
Are you using workspaces? Yes
Have you cleared the local cache (see Notice section above)? Yes
List steps in order that led up to the issue you encountered Upgraded to terraform 1.3.4
Expected behavior
$ tfenv use 1.2.3
$ terraform import module.route53_records[\"domain.com\"].aws_route53_record.this[\"\ NS\"] Z035010000000LTCJGV2E_domain.com_NS
Acquiring state lock. This may take a few moments...

Import successful!

The resources that were imported are shown above. These resources are now in
your Terraform state and will henceforth be managed by Terraform.

Actual behavior
$ tfenv use 1.3.4
$ terraform import module.route53_records[\"domain.com\"].aws_route53_record.this[\"\ NS\"] Z035010000000LTCJGV2E_domain.com_NS
Acquiring state lock. This may take a few moments...
╷
│ Error: zone_id and name arguments can't be used together
│
│   with module.route53_records["domain.com"].data.aws_route53_zone.this[0],
│   on .terraform/modules/route53_records/modules/records/main.tf line 10, in data "aws_route53_zone" "this":
│   10: data "aws_route53_zone" "this" {
│

What do you have in your Terraform configs for this?

Hi @antonbabenko
Here is the main file:
terraform {
  required_version = ">= 1.3.4"
  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = "~> 4.39"
    }
  }

  backend "remote" {
    hostname     = "app.terraform.io"
    organization = "hyve-mobile"

    workspaces {
      name = "hm-infrastructure-route53-production"
    }
  }
}

provider "aws" {
  region  = var.aws_region
  profile = var.profile

  assume_role {
    role_arn = var.aws_assume_role_arn
  }

  default_tags {
    tags = var.default_tags
  }
}

module "route53_zones" {
  source  = "terraform-aws-modules/route53/aws//modules/zones"
  version = "~> 2.0"

  zones = var.route53_zones
}

module "route53_records" {
  for_each = merge(
    var.route53_records_hm,
    var.route53_records_mcm,
    var.route53_records_products,
    var.route53_records_portals
  )
  source   = "terraform-aws-modules/route53/aws//modules/records"
  version  = "~> 2.0"

  create       = try(each.value.create, true)
  private_zone = try(each.value.private_zone, false)
  zone_id      = try(each.value.zone_id, module.route53_zones.route53_zone_zone_id[each.key])
  zone_name    = try(each.value.zone_name, module.route53_zones.route53_zone_name[each.key])
  records      = each.value.records

  depends_on = [module.route53_zones]
}

Here is a sample of the zones var file:
route53_zones = {
  "domain1.com" = {
    comment       = "HostedZone created by Route53 Registrar"
    create        = false
    force_destroy = false

    tags = {
      ManagedBy   = "Terraform"
      Environment = "production"
    }
  }

  "domain2.com" = {
    comment       = "HostedZone created by Route53 Registrar"
    create        = false
    force_destroy = false

    tags = {
      ManagedBy   = "Terraform"
      Environment = "production"
    }
  }

  "domain3.com" = {
    comment       = "HostedZone created by Route53 Registrar"
    create        = false
    force_destroy = false

    tags = {
      ManagedBy   = "Terraform"
      Environment = "production"
    }
  }

  "domain4.com" = {
    comment       = "HostedZone created by Route53 Registrar"
    create        = false
    force_destroy = false

    tags = {
      ManagedBy   = "Terraform"
      Environment = "production"
    }
  }
}

Here is a sample of the routes file:
route53_records_hm.auto.tfvars
route53_records_hm = {
  "domain1.com" = {
    records = [
      {
        name    = ""
        type    = "SOA"
        ttl     = 900
        records = ["ns-1536.awsdns-00.co.uk. awsdns-hostmaster.amazon.com. 1 7200<PHONE_NUMBER> 86400"]
      },
      {
        name = ""
        type = "NS"
        ttl  = 172800
        records = [
          "ns-1536.awsdns-00.co.uk.",
          "ns-0.awsdns-00.com.",
          "ns-1024.awsdns-00.org.",
          "ns-512.awsdns-00.net."
        ]
      }
    ]
  }
}

route53_records_mcm.auto.tfvars
route53_records_mcm = {
  "domain2.com" = {
    records = [
      {
        name    = ""
        type    = "SOA"
        ttl     = 900
        records = ["ns-1536.awsdns-00.co.uk. awsdns-hostmaster.amazon.com. 1 7200<PHONE_NUMBER> 86400"]
      },
      {
        name = ""
        type = "NS"
        ttl  = 172800
        records = [
          "ns-1536.awsdns-00.co.uk.",
          "ns-0.awsdns-00.com.",
          "ns-1024.awsdns-00.org.",
          "ns-512.awsdns-00.net."
        ]
      }
    ]
  }
}

route53_records_portals.auto.tfvars
route53_records_portals = {
  "domain3.com" = {
    records = [
      {
        name    = ""
        type    = "SOA"
        ttl     = 900
        records = ["ns-1536.awsdns-00.co.uk. awsdns-hostmaster.amazon.com. 1 7200<PHONE_NUMBER> 86400"]
      },
      {
        name = ""
        type = "NS"
        ttl  = 172800
        records = [
          "ns-1536.awsdns-00.co.uk.",
          "ns-0.awsdns-00.com.",
          "ns-1024.awsdns-00.org.",
          "ns-512.awsdns-00.net."
        ]
      }
    ]
  }
}

route53_records_products.auto.tfvars
route53_records_products = {
  "domain4.com" = {
    records = [
      {
        name    = ""
        type    = "SOA"
        ttl     = 900
        records = ["ns-1536.awsdns-00.co.uk. awsdns-hostmaster.amazon.com. 1 7200<PHONE_NUMBER> 86400"]
      },
      {
        name = ""
        type = "NS"
        ttl  = 172800
        records = [
          "ns-1536.awsdns-00.co.uk.",
          "ns-0.awsdns-00.com.",
          "ns-1024.awsdns-00.org.",
          "ns-512.awsdns-00.net."
        ]
      }
    ]
  }
}

The error is Error: zone_id and name arguments can't be used together, but in your code, you have both:
  zone_id      = try(each.value.zone_id, module.route53_zones.route53_zone_zone_id[each.key])
  zone_name    = try(each.value.zone_name, module.route53_zones.route53_zone_name[each.key])

Fix it, and the problem will be gone.

Thanks @antonbabenko this functionality must have changed between TF version 1.2.3 and 1.3.2.
I have updated my code to this and it works:
zone_id      = try(each.value.zone_id, module.route53_zones.route53_zone_zone_id[each.key], null)
zone_name    = can(each.value.zone_id) == true ? null : can(module.route53_zones.route53_zone_zone_id[each.key]) == true ? null : try(each.value.zone_name, module.route53_zones.route53_zone_name[each.key])

Ok, I think this is a bit simpler:
zone_id      = try(each.value.zone_id, module.route53_zones.route53_zone_zone_id[each.key], null)
zone_name    = try(each.value.zone_id, module.route53_zones.route53_zone_zone_id[each.key], null) != null ? null : try(each.value.zone_name, module.route53_zones.route53_zone_name[each.key])

@antonbabenko thanks, that is much cleaner :)
The trouble I'm having now is that if I now remove zone_id or zone_name then ALL my resources want to update because they think something has changed...
 # module.route53_records["domain1.com"].aws_route53_record.this[" MX"] must be replaced
-/+ resource "aws_route53_record" "this" {
      + allow_overwrite = false
      ~ fqdn            = "domain1.com" -> (known after apply)
      ~ id              = "Z03935533A00000OSDBSM_domain1.com_MX" -> (known after apply)
      ~ name            = "domain1.com" -> (known after apply) # forces replacement
        # (4 unchanged attributes hidden)
    }

If I add both zone_id and zone_name and go back to v1.2.3 then it's fine...


[Enhancement] add metric for running txn number of per db

Why I'm doing:
We now have a limit on the number of running txn per database, but no metrics per database running txn.
What I'm doing:
Add metric for running txn number of per database.

What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[x] 3.2
[x] 3.1
[ ] 3.0
[ ] 2.5

ignore backport check: 3.3.5

ignore backport check: 3.3.6


Update Android deps

Closes #41

Kotlin 1.5.21
Gradle wrapper 7.1.1
Android gradle plugin 7.0.0

Thanks for your help to update the dependencies. I've just merged in #43 to address this so I'm going to close this out.


scipy needs to be imported before tensorflow

Environment info
Operating System:
Ubuntu 14.04.4 LTS
Installed version of CUDA and cuDNN:
cuda-7.5
cuDNN 5
Steps to reproduce

import tensorflow
import scipy.misc
scipy.misc.imread fails with "IOError: broken data stream when reading image file"

Importing scipy before tensorflow solves the issue.

Which TensorFlow version/Scipy version? Is there more debugging information? (ie, which line of scipy fails). I tried on last month's Anaconda install of scipy/tensorflow and it seems to work for me

@keveman: I'm almost certain this has the same root cause as #1924.

@yaroslavvb
Since PIL is probably the culprit:
>>> PIL.VERSION
'1.1.7'
>>> PIL.PILLOW_VERSION
'2.3.0'

For tensorflow, I cloned and installed from source today
commit 36d89cf8f7bdfb17daf93f8439d95018b8cda431
image_data = misc.imread(image_path, flatten=1)
  File "/usr/lib/python2.7/dist-packages/scipy/misc/pilutil.py", line 127, in imread
    return fromimage(im,flatten=flatten)
  File "/usr/lib/python2.7/dist-packages/scipy/misc/pilutil.py", line 189, in fromimage
    im = im.convert('F')
  File "/usr/lib/python2.7/dist-packages/PIL/Image.py", line 713, in convert
    self.load()
  File "/usr/lib/python2.7/dist-packages/PIL/ImageFile.py", line 234, in load
    raise_ioerror(e)
  File "/usr/lib/python2.7/dist-packages/PIL/ImageFile.py", line 56, in raise_ioerror
    raise IOError(message + " when reading image file")
IOError: broken data stream when reading image file

@mrry Yeah

PIL is indeed the culprit; I'm getting the same error, and I'm sidestepping scipy entirely. Even if the image is read into memory via StringIO. grr.

@keveman: Assigning this to you, but feel free to combine with the related bugs.

Fixed with 5405394


Grabber crashes when hitting X on the main window or any subwindow

Steps to reproduce

Open Grabber
Click on the X in the WM
Segfaults

Alternatively

Open Grabber
Search for anything
Click on a thumbnail to launch a subwindow
Click on the X in the subwindow
Segfaults

Context

There is no error in main.log
Happens with a blank settings.ini too
The coredump is 311MB. Let me know if you need it.

System information

OS: Arch Linux
Grabber version: 6f4d5c11bd008ba8ca5530ae706623a998655910

I'm having the same issue on Debian testing with the develop branch. The reason why coredump is so large is because it's a stack overflow caused by createWinId()
#0  0x00007ffff7a283a2 in QWidget::setAttribute(Qt::WidgetAttribute, bool) () at /usr/lib/libQt5Widgets.so.5
#1  0x00007ffff7a28259 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#2  0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#3  0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#4  0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#5  0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#6  0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#7  0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#8  0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#9  0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#10 0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#11 0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#12 0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#13 0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#14 0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#15 0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#16 0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#17 0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#18 0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#19 0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#20 0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
#21 0x00007ffff7a28337 in QWidgetPrivate::createWinId() () at /usr/lib/libQt5Widgets.so.5
<snip>...

Using git-bisect the issue was introduced by commit 25d501fa85ccde483e988a78a4eb3621fb71d14b .
For now I am able to fix this by Deselecting "Use built-in video player" in Tools->Options->Interface->Image window

I can reproduce on a self-built version, but note that nightly's AppImage does not seem to have this issue.

I'm on Arch, so building is the way instead of using AppImages.

Seemed to be some weird behavior when the QVideoWidget was being deleted automatically as a child from the image window.
Removing it from the widget tree and deleting it manually seems to fix the issue.
Very strange issue, especially since it works using AppImage but not when self-building. Maybe a different version of the video player library that doesn't like the way it was being deleted? 🤔


Not possible to update a datafile with columns in addition to the original columns

It would be good to be able to upload a datafile with additional columns (i.e., in addition to the columns that already were present in the initially uploaded datafile). This is at the moment impossible. When I try to add a .CSV file with new columns to an existing dataset, I get an Internal Server Error.

I think the appropriate behaviour should be that the extraneous columns are ignored. To add them seems not right. What do you think?


Implementing TypedValue and the git dependency on gazebo

It looks like right now to impl TypedValue that my type needs to also impl AsTypedValue and by implication AnyLifetime. IIUC, AnyLifetime is defined in gazebo which is published to crates.io but starlark uses it via git. So my crate needs to depend directly on both starlark and gazebo via two git deps. IMO in an ideal world the derive would come from crates.io or would be re-exported by the starlark crate. Do either of those options seem reasonable?
Separately, I think it would be nice if this repo's Cargo.toml could specify the exact gazebo revision it uses, but I'm not sure if y'all's open source export tooling can wire that up correctly. Without specifying the revision it's going to be hard to bisect through the crate's history using cargo. I think Cargo will support revision pins correctly so if I ever need to hold back starlark I should still be able to convince it to use an older compatible gazebo revision, but it would be easiest if starlark's commits included pointers to compatible gazebo commits.
EDIT: It seems Cargo gives me two different instances of gazebo if I specify a revision in my Cargo.toml without one being specified in starlarks. From Cargo.lock:
[[package]]
name = "gazebo"
version = "0.1.0"
source = "git+https://github.com/facebookincubator/gazebo?rev=604500f#604500f2775efa3c36bb53b5241a6911547fabdb"
dependencies = [
 "gazebo_derive 0.1.0 (git+https://github.com/facebookincubator/gazebo?rev=604500f)",
]

[[package]]
name = "gazebo"
version = "0.1.0"
source = "git+https://github.com/facebookincubator/gazebo#604500f2775efa3c36bb53b5241a6911547fabdb"
dependencies = [
 "gazebo_derive 0.1.0 (git+https://github.com/facebookincubator/gazebo)",
]

Which IIUC means that until starlark specifies a revision for gazebo that I can't pin a starlark version that uses an incompatible gazebo API. Is there a way to include the revision in starlark/Cargo.toml?

Both of your ideas seem reasonable. I think us relying on an unreleased version of Gazebo, which convenient for us, is a bit of a pain for everyone else. I'll push out a new release of Gazebo tomorrow, and pin us to a release, and do that going forward. Reexporting the AnyLifetime and few other types we rely on (ARef probably) seems like a good idea to simplify things for downstream users, it should only be a handful of things.
I still don't see why Cargo has picked different github versions for the two. Does cargo update fix that?
FWIW, we hope to make a release of Starlark in the next week or two, meaning you can rely entirely on Crates.io.

All great news!

After catching up on https://github.com/facebookexperimental/starlark-rust/issues/14, I see that starlark_immutable_value! impls AnyLifetime for me, so it's possible that the ergonomic concern is moot. I think the issues around pinning to old starlark versions should be resolved by publishing to crates.io because it won't allow git deps. Thanks for the prompt response!

Further update: I think that the macro will still need gazebo to be available in the root namespace even if I don't need to import the derive directly. Maybe starlark could re-export gazebo without docs and then use that re-exported API in starlark_immutable_value?

See https://github.com/facebookexperimental/starlark-rust/blob/4ea312ce2107644fff2a895054c3fae3d64c4722/starlark/src/macros/mod.rs#L121 - starlark_immutable_value actually uses $crate::__macro_refs::any_lifetime!, and we export the macros we use at https://github.com/facebookexperimental/starlark-rust/blob/4ea312ce2107644fff2a895054c3fae3d64c4722/starlark/src/lib.rs#L242-L245. So that should mostly fix it for you.
Note that this change landed appeared in the last week or so - if you checked previously, you would have needed gazebo in scope.

Nice! I suspect there may be another dependency hiding in the macro stack, because I'm at https://github.com/facebookexperimental/starlark-rust/commit/8a8523fc4d7700cdea6cf8a31a56d29ee7be4764 and I get this error when I remove gazebo from my Cargo.toml:
error[E0433]: failed to resolve: use of undeclared crate or module `gazebo`
   --> src/builtins/command.rs:139:1
    |
139 | starlark_immutable_value!(Output);
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use of undeclared crate or module `gazebo`

Ah, we use gazebo for ARef. That's one of the things that needs exposing.

I think this is all fixed now. In particular:

We expose ARef and AnyLifetime from starlark::value.
We use those definitions in the macros.
We depend on Gazebo 0.2.0, rather than a git version.

Of those, 3 should make it easy to have a Gazebo dependency too. 2 should make it so our macros don't add a Gazebo dependency automatically. 1 might make it so you don't need a Gazebo dependency, but I'm less sure - in practice you might need the any_lifetime! macro or similar, which we don't export. If you come up with a list of what needs exposing in practice, we can export a few more things, but I think at a certain point we'll suggest people just use Gazebo as an explicit dependency.


Introducing Providers

Introducing Providers. These are the ones that define what a RETS server (ie: provider) actually provides. For now I've only added the class, moved the methods and added the necessary code to mix these methods back into the RETS class. A base provider will be included in the library which will adhere to the spec. The goal here is to let any user write their own provider with functionality specific to their service. For example, a different login strategy.

Coverage increased (+0.63%) to 76.83% when pulling ba101e8dde8fb2098a1a20c086803e0646827bb0 on lgomez:provider into 1d5b56fcb778aea5b1653f1d5ea11423069b3b23 on retsr:master.


Validate the organization hierarchy in the organization management REST API

Description:
As mentioned in https://github.com/wso2/product-is/issues/13953, organization-specific routing capability is introduced and as stated in https://github.com/wso2/product-is/issues/13955, API calls that are invoked in the /o/{org domain} path are authorized based on the new permission model.
Let's consider the below given organization hierarchy

The following organization management API calls:

https://localhost:9443/o/<org A id>/api/server/v1/organizations/<root org id> -> root org is the parent of org A
https://localhost:9443/o/<org A id>/api/server/v1/organizations/<org B id> -> both orgs are in the same level in the tree
https://localhost:9443/o/<org A id>/api/server/v1/organizations/<org B_1 id> -> org B_1 is not a child of org A
https://localhost:9443/o/<root org id>/api/server/v1/organizations/<org B_1 id> -> org org B_1 is not an immediate child of root org
https://localhost:9443/o/<org A id>/api/server/v1/organizations/<org A id> -> same org

return successful results given that the authorization evaluation at the valve level is successful since the user has the relevant permissions for the organization domain (o/<org domain>)
However, these paths should be blocked to honor the hierarchy levels in the organization tree.
Only the following request format should be supported:
/o/<org domain>/api/server/v1/organizations/<immediate child of the org represented by the org domain>
Probably this will need to be handled at the organization management service level, rather than at the authorization valve as this validation is only required for the organization management endpoints.

Tracked by - https://github.com/wso2-enterprise/identity-org-mgt-connector/issues/30


protobuf and Python 3.6 compatibility problems - drop support for Python 3.6, support 3.7?

Hi
tl;dr: can HWI drop support for Python 3.6 to be in line with the up to date protobuf package version, which also dropped support for Python 3.6? Also, Python 3.6 reached end-of-life on Dec 23, 2021 and is not receiving security fixes anymore.
Details:
protobuf v3.20 introduced a breaking change:

*[Breaking change] Protobuf Python generated codes are simplified. Descriptors and message
classes' definitions are now dynamic created in internal/builder.py.

This resulted in BitBox02 users reporting errors when using HWI  (example) - their local protobuf version was higher than v3.20. To fix this, the bitbox02 dep now requires protobuf higher than 3.20 (PR), with updated protobuf files, and we released this as bitbox02 6.1.0.
Now I tried to update the HWI bitbox02 dep from 6.0.0 to 6.1.0, to solve this bug for e.g the Sparrow user above.
The problem is that the new protobuf version (from v3.20) requires Python 3.7, see this error when attempting to generate the poetry lock file for HWI after updating the bitbox02 version to 6.1.0:
  The current project's Python requirement (>=3.6,<4.0) is not compatible with some of the required packages Python requirement:
    - protobuf requires Python >=3.7, so it will not be satisfied for Python >=3.6,<3.7
    - protobuf requires Python >=3.7, so it will not be satisfied for Python >=3.6,<3.7
    - protobuf requires Python >=3.7, so it will not be satisfied for Python >=3.6,<3.7
    - protobuf requires Python >=3.7, so it will not be satisfied for Python >=3.6,<3.7
    - protobuf requires Python >=3.7, so it will not be satisfied for Python >=3.6,<3.7

  Because no versions of protobuf match >=3.21,<4.21.0 || >4.21.0,<4.21.1 || >4.21.1,<4.21.2 || >4.21.2,<4.21.3 || >4.21.3,<4.21.4 || >4.21.4
   and protobuf (4.21.0) requires Python >=3.7, protobuf is forbidden.
  And because protobuf (4.21.1) requires Python >=3.7
   and protobuf (4.21.2) requires Python >=3.7, protobuf is forbidden.
  And because protobuf (4.21.3) requires Python >=3.7
   and protobuf (4.21.4) requires Python >=3.7, protobuf is forbidden.
  Because no versions of bitbox02 match >6.1.0,<7.0.0
   and bitbox02 (6.1.0) depends on protobuf (>=3.21), bitbox02 (>=6.1.0,<7.0.0) requires protobuf (>=3.21).
  Thus, bitbox02 is forbidden.
  So, because hwi depends on bitbox02 (>=6.1.0,<7.0.0), version solving failed.

Can I make a PR that drops support for Python 3.6, requiring Python >=3.7?

Fyi:
Python 3.6 reached end-of-life on Dec 23, 2021 and is not getting any security updates anymore. This is the reason protobuf dropped support, and it makes sense imo to do the same for HWI.

@achow101 a response needed - this is blocking us from updating the bitbox02 package in HWI, preventing the protobuf incompatibility issue to be fixed, which breaks downstream wallets for our customers.

I will try to take a look this week, been busy with other work and travel recently.


New FanControl version, ADLX needs updated

There was a new update to FanControl today and it needs a new version of the ADLX plugin.

ADLX is now integrated, The plugin is deprecated.

How is it integrated when I'm getting these errors? I tried turning on the ADLXWrapper option but it just threw this error as well. There is ONE sensor for my GPU but, with ADLX I used to be able to control both fans individually.


ECALL_WFI() not documented.

ECALL_WFI() is in libhexfive.h but is not documented in README.md.

Added to https://github.com/hex-five/multizone-api/commit/ef73402bc04e10db381ad415b3f657bb1b6bd2ee
@HAKarlsson Thank you for pointing this out!


findOne is slow if collection transform is adding big fields

Observed Behavior
After the latest release (2.30.2) I've realized one of my collections was performing much slower when finding documents ( from ms to 3-4 seconds). To fix it, I had to reduce the transform of the document to a simpler object.
Expected Behavior
Kadira does not make the app that slower when finding documents in the database.
Reproduce by
Create a transform that adds a big field to a collection.
Measure the time to find a document
@arunoda

I believe you are stringifying the document or something like this on every findOne, meaning that if the object is big enough, it will take a lot of time.
But this was not happening before the latest release, so I wonder if #144  is related

👍


Added types and made certain types optional

Hi,
Thanks for creating this integration, many people have been asking for it. I will add a link to this repo in the core library's README.
In this PR, I added some more missing types and made some types optional. I will continue doing these changes whenever I change the options in the core ApexCharts library.
I am planning to copy your typings here - https://github.com/apexcharts/apexcharts.js/blob/master/types/apexcharts.d.ts
so that we can easily track changes at both places.
Thanks!

I did not plan to change the types and only had to create own type files to use the types for parameters.
If it is possible to mark all types as exported in your definition the library does not need seperate types and I can reuse the ones from apexcharts.


Update comfig.cfg

I commented cvars that already are in their default value and mastercomfig doesn't have to forcing to the default value again.

Thank you for your contribution to mastercomfig!


[azeventhubs] Remove the epoch options for the Processor

Remove the epoch options for the Processor. This wasn't intended to be configurable and should always be set and always be zero.
Fixes #19848

/azp run go - azeventhubs

/azp run go - azeventhubs


ci: Give workflow jobs more useful names.

The names show up in the UI, and having a bunch of jobs all
named 'check' makes it impossible to distinguish which job
is being referred to.

Test plan
n/a

Much better!

Where do you see that view? I always see the name of the workflow first so the new output is more noisy

After merging.

Yeah, I know it is a bit more verbose pre-merge, but I figured that was not so bad. IDK why GitHub doesn't use the same names in both places. 🤷

Aha, I had never used the "View details" button. It's surprising GH has different naming conventions for these jobs. I suppose they will iron out this quirk eventually. Totally fine by me to repeat the job name 👍


Want to translate the Go Code of Conduct into Brazilian Portuguese

I'd like to work on this translation. Is this something desirable?

/cc @campoy

I think we should have translated version of the code of conduct outside of this repo, the same way translations of the tour are somewhere else.
I'm wondering if this should be part of one of the resources already linked here.
Do you have any contacts with the owners of golangbr.org?

@campoy I do have contact with them. Should I go this route then?

Yeah, I think it should be somewhere in [http://www.golangbr.org/projeto/](this page)

Ok, will do. Thanks!

:+1:

Ok, I've got that under way and am closing this issue.
As a way of suggestion, people should see a Portuguese speaker on the list of people representing the community for the purpose of CoC issues. c/c @adg

And FYI re: the translation to pt-br: https://github.com/golangbr/golangbr.org/issues/14


Wording is misleading and gives the wrong impression

I was on a Reddit thread and there was a discussion where someone thought this page was telling them to use modules in their code NOW.

We recommend that new projects use modules rather than header files as much as possible.

While I agree that when the implementation is read all new projects should favor modules over headers, this wording is dangerous and could give people the impression that Microsoft is saying that the experimental implementation of C++20 Modules is ready for production usage.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

 This article is due for an update that should show up later this month for the 16.8 preview/release. We'll address the recommendation as part of that.
@cdacamar @gdr-at-ms  Would you care to comment on what this should recommend now?

It's ok to use modules now.


remove compress flag from solvers.py as it is no longer required for …

This PR removes the compress flag from the solvers submit method as this is no longer required to support toshiba.
Please see this request: https://github.com/microsoft/qdk-python/issues/235

Thanks @sanjgupt! Since the behavior of the target changed, I think we should re-record the Toshiba tests.


Inconsistency in direct title editing for CZO

Both the functionality and styling are confusing for direct title editing on CZO.  On the edit page, the title can be edited via right clicking, then typing.  The styling suggests "editable directly". The title window suggests a different story, with the generated title both functionally and stylistically uneditable.
000.zip

Moving here https://github.com/hydroshare/hydroshare/pull/3515


MXNet reimplement

Good job, but I have some questions:

It is known to all that FAIR's RegNet source code had released(pycls codebase), so what's the difference ?(RegNet-0.4GF is 0.2% less than official) and why u reimplement ?
Have u and your team use MXNet or gluon to implement RegNet? If not, why? Does phenomenon implies Pytorch more usability than MXNet ?

Thanks.

This repo is reimplementing the search process of RegNet, instead of simply providing configurations

MXNet is very easy to use. Personally, I have joined another team.

Yeah, I have found that you use AutoTorch to implement the search process.
Thanks.


fix the issue with explorer widget context menu

This PR fixes #10765
for new notebook action, we need to return the IConnectionProfile to avoid the circular structure issue
for script as create action, it is never meant to be exposed on database context.

Coverage decreased (-0.1%) to 37.407% when pulling<PHONE_NUMBER>f6ed112743813c450d2f90484f8d59 on alanren/fix-explorer-menu into cc78d6a8f09c1bd835858f50a4be2eaaf6287b2e on main.


Fixes getting setup

I decided to switch to working with Rstudio this week to get the participant experience. Did the getting set up workflow and made some corrections.
Made the choice to switch to pak as may save some issues with people getting setup.

I'm now trying to run the sessions and finding that none of the stan models will compile due to not being able to find the include functions

Given that it works in the CI, is this an RStudio specific issue?

No idea!

Bug is unrelated to the course. It looks like the issue with spaces in file paths has come up again (I was working out of a google drive folder called My Drive - moving the folder fixes it.

That's really good to know (especially as it may well affect course participants).
I wonder if it's something we could raise/fix upstream at some point.

So what is super weird is they have fixed it (i.e there is a closed issue from a year ago) so it is super weird it has really appeared with all new installs of everything.


Enhanced AI-Driven Face Recognition: AO3: Enhancement of Performance Rate, Increase of Accuracy, and Enhancement of Robustness of Systems

However, in the recent update of the face recognition script using dlib major changes were made to increase its efficiency and to include AI functionalities. The script of the application was initially designed for face detection, facial landmarks and face descriptors generation. But it has issues concerning execution efficiency, errors dealing with, and enhanced flexibility.
In order to solve those, the given script was changed with several enhancements: Firstly, the dynamic error handling was added to enhance the information provided to the end-user and to avoid program termination in the cases when an incorrect input or a non-existing file is used. This makes it more reliable and easier to use to the various clientele. Also additional conditions were put into the loops and where possible restructuring of loops was done to improve efficiency of the code.
AI-related features were also incorporated to improve on the script’s functionality. The face detection and recognition were enhanced with optimization techniques based on artificial intelligence: face descriptor comparison adopted a variable threshold to respond to optimum detection for similar faces. There are new sliders in the script for the automatic alignment of images with faces using AI which helps to improve the orientation of face images before applying filters, which results in higher quality of the picture.
In addition, the script’s execution time was reduced to include batch processing with the aid of AI parallelism to enable the processing of multiple images at once without delay. This is especially important if one is dealing with big data as the results in this case are massive. The new features also include an AI module that offers an automatic facial landmark enhancement in order to improve the precision of the landmarks detected which is vital for an accurate face recognition.
As a whole, these changes have made the script more versatile and capable when compared to the previous implementation while providing corresponding practical features that can be used in face recognition tasks.

Thanks for the PR.  End user applications should go in a separate repository though.  You should make one in your account and post it there :)


Print domains as string list for app commands

Before:
$koyeb apps list
ID      	NAME                 	DOMAINS                                                	CREATED AT
8cf805f7	http-server          	http-server-nicolas.koyeb.app                  	22 Sep 21 14:54 UTC
840711c8	someecho2            	someecho2-nicolas.koyeb.app                    	20 Dec 21 13:06 UTC
2fe5c1c9	demodemodemo         	demodemodemo-nicolas.koyeb.app,some.domain.com	03 Jan 22 11:46 UTC

After:
$koyeb apps list
ID      	NAME                 	DOMAINS                                                      	CREATED AT
8cf805f7	http-server          	["http-server-nicolas.koyeb.app"]                    	22 Sep 21 14:54 UTC
840711c8	someecho2            	["someecho2-nicolas.koyeb.app"]                      	20 Dec 21 13:06 UTC
2fe5c1c9	demodemodemo         	["demodemodemo-nicolas.koyeb.app","some.domain.com"]	03 Jan 22 11:46 UTC

lmk what you think of the display @koyeb/core . Suggestions welcome too!

LGFM :+1:
New format is super nice :smile:


tfx in path

I think it would be helpful to remind folks to use the node.js command prompt so that tfx is in the path.

Following the instructions in the readme should be sufficient. The tfx-cli should follow the same patterns as other CLI apps written in nodejs.


In some cases connection to execution service times out

Version: <IP_ADDRESS> | axocover
Stacktrace
AxoCover.Models.ExecutionProcess;ConnectToService;ExecutionProcess.cs;79
AxoCover.Models.ExecutionProcess;OnServiceStarted;ExecutionProcess.cs;69
AxoCover.Common.ProcessHost.ServiceProcess;OnOutputDataReceived;ServiceProcess.cs;77
Reason
at System.Diagnostics.Process.OutputReadNotifyUser
Link to HockeyApp

https://rink.hockeyapp.net/manage/apps/465309/app_versions/26/crash_reasons/166710961

Should be fixed by: https://github.com/axodox/AxoTools/releases/tag/master-1.1.135


Missing 4th parameter in userbuttons causes entries in error log

The userbuttons file can have a semi-optional 4th parameter, which represents "other attributes" (width, etc). If this parameter is missing it results in a message in  /var/log/apache2/error.log that says:
[php7:notice] [pid 521] [client <IP_ADDRESS>:5555] PHP Notice:  Undefined offset: 3 in /var/www/html/index.php on line 58
This doesn't appear to cause any real problems other than filling up the error log. Line 58 in index.php is simply:
$otherAtt  = $index[3];
I think something like:
if (count($index) > 3) {   $otherAtt  = $index[3]; } else {   $otherAtt  = ""; }
would suppress this error. (Sorry for the ugly format; I can't seem to make Github respect linefeeds inside code blocks)
I'm not sure what an empty $otherAtt does to the functions that eventually use $buttonString, so that bears some consideration.

Thanks. I have made that change. I think an empty otherAtt is OK.


WIP Update free5gc packages

WIP

Updated nfdeploy-fn docker image
Added Roles for nfdeployments and nfconfigs
Adjusted privileges

/test e2e-free5gc-ubuntu-focal

@lapentad do we need to include the NFDeployment and NFConfig CRDs?

I Removed them now

/lgtm
/approve

/retitle Fix free5gc-operator-role RBAC

/lgtm
/approve


Aac spec infrastructure implementation

Implements project infrastructure from AaC into this repo.  Updates the spec definition.
Closes  #784 #785

You seem to be missing the README for the secure_install directory.
Need to update the package referencing to be the AaC  Specification package within the instructions. Including the file names of the secure_install directory.
The scripts referenced here and included in this directory are some of the pieces that might have to change with regards to the build steps of the pipeline that I mentioned might be additionally impacted by moving away from the setup.py build.


Folia RTP error

Plugin Version:

3.6.12
Describe The Bug:

When doing RTP I'm getting this error: https://pastebin.com/UBiAcpp6
How To Reproduce:

do /rtp
boom error
Expected Behavior:

no errors
Screenshots/Error Log:

https://pastebin.com/UBiAcpp6
Additional Context:

Folia 1.20.4

Fixed in the latest version

Resolved


Abstraction for PyTree

Check for existing issues

[X] Completed

Description
It is good to have a general interface for PyTree classes. For reference, NumPyro did like this.

Not working on this idea for now!

Equinox has a great way of making PyTrees and Dataclass at the same time. We should look into it for a better experience.


Careful with clear_notebooks.sh

I naively used clear_notebooks.sh (in Mac) in some of my local notebooks for clearing the outputs and I got all their content deleted instead (including the checkpoints ipynb) so I lost all my changes. This should be avoided.
I think this line was the problematic one: jq 'del(.metadata.kernelspec)' "$notebook" > notebook_no_kernel.ipynb

what?! How can this happen?
The lines:
    jq 'del(.metadata.kernelspec)' "$notebook" > notebook_no_kernel.ipynb
    mv notebook_no_kernel.ipynb "$notebook"

removes the kernel spec in the metadata, export this in temporary notebook notebook_no_kernel.ipynb and then mv it back to original path
The whole script should just clear outputs and remove the kernel spec (that was causing issues in the CI when running the notebooks).
What do you mean by content deleted? All cells? The file?
So sorry for the information you lost.

No worries.
Just checked again. The problem is that I did not have jq installed. Therefore
jq 'del(.metadata.kernelspec)' "$notebook" > notebook_no_kernel.ipynb

was creating an empty file notebook_no_kernel.ipynb which was later renamed as the original notebook.
Maybe we should check if jq exists first or exit the script right there before the mv command

Add set -eu -o pipefail at the top


[feature request] - add a data object to the step options

There should be a way to pass custom data in a step. In fact, it is already possible. The only thing missing is a typescript definition for this.
I propose adding a data object to the step option. This will have arbitrary data.
We can enhance the experience of the user by using generics on the data type if that is possible.
I'm happy to provide a PR with guidance.

Never mind, I found a way to do it on my end:
interface MyStepOption<T> extends INgxpStepOption {
  data: T;
}

const steps: MyStepOption<{prop: string}>[] = [];
...

NB: INgxpStepOption is inheriting from StepOption


fixes https://github.com/wso2/docs-apim/issues/4123

Purpose
fixes https://github.com/wso2/docs-apim/issues/4123

Change this PR to draft mode because even though I changed one URL and generated the config-catalog multiple changes have got applied due to a contributor not generating the config catalog properly.

@ruthryi , please let me know if you recognise any of these changes.

This was my change.


[v4.x] Fix Matrix decomposition for a rare case.

Maybe long time ago there was something about scale. Now this branch is triggered only in one case and returns wrong answer.
Can be cherry-picked.
https://www.pixiplayground.com/#/edit/tbHFSNFRW4KCULGpdbygB

Looks like that was added here in 4.0.0-rc3
https://github.com/pixijs/pixi.js/commit/4bf3f687b0a00d6d00b1186e3da58507e1f0273a

That's the only way to hit that if.


Download local clients on Linux and Mac

We need to find a way to download MySQL and PostgreSQL binaries needed for backup/restore tasks on Linux and Mac. We already do that for Windows, but users of other operating systems are very frustrated when they can't start a task and sometimes don't understand that those clients need to be installed manually.

Indeed, I encountered this issue on Manjaro Linux and was very annoyed that it needed to be done manually.


Extra space in info bar on Welcome page

Microsoft PowerToys version
v0.86.0
Installation method
GitHub
Running as admin
No
Area(s) with issue?
Welcome / PowerToys Tour window
Steps to reproduce

Have a fresh install of v0.86
Click 'Yes' on the info bar to accept telemetry
See next message

✔ Expected Behavior
One less space before 'settings'
❌ Actual Behavior
We've got an extra space here

Other Software
No response

Please assign this issue to me if not already picked up


Set memory and cpu limit to last-50k

The same as what was done for nodewatcher (#298 and #299 ) deployment should be done for the job:
2 pods where recently evicted with the following in their describe:

Pod The node had condition: [MemoryPressure].

and the other

The node was low on resource: memory. Container nomidotwatcher was using 1703264Ki, which exceeds its request of 0.

edit: the jobs logs show nothing (1 has no log at all, the other has no error and just stops logging abruptly tasks.)

ok so the MemoryPressure complaint is coming from the Node level -
https://kubernetes.io/docs/concepts/overview/components/#node-components
so #298 should have been applied at that level, not to a deployment. I'm surprised the requests: { memory, cpu } fields were valid for the deployment in #298 though.
However, "Unlike pods and services, a node is not inherently created by Kubernetes: it is created externally by cloud providers like Google Compute Engine, or it exists in your pool of physical or virtual machines." - https://kubernetes.io/docs/concepts/architecture/nodes/#manual-node-administration
My Best Guess: So I think this is meant to be configured from our GKE rather than with kubectl, and at the Node level, not the Pods it manages.

So my questions before proceeding are:

first of all is the best guess above correct?
if so, how do we/should we manually adjust these requests for resources?
3a. We also have 3 such nodes in our Node Pool...do we need this many?
3b. More generally, what sort of metrics do we look at to decide how many we need?
3c. Should that be manually fiddled with at all?

cc @fevo1971: Sorry to bombard you with more Nodewatcher Devops ruckus but I'd really appreciate your expert eyes on this when you get a chance so that we can approach something more stable with our dashboards cluster. Thanks!

cc @fevo1971: Sorry to bombard you with more Nodewatcher Devops ruckus but I'd really appreciate your expert eyes on this when you get a chance so that we can approach something more stable with our dashboards cluster. Thanks!

will take some time later today to figure out what's happening here, and what limit's we are actually running into here. will keep you posted!

Thank you! 🙏

Yes, you are right, the final limit to this is the memory of the node the pod is running on. In our case ~2.7gb. We can set the limits in the container spec:
spec:
  containers:
  - name: nomidotwatcher
    resources:
      requests:
        memory: "2Gi"
[...]

When i look at the chart it looks to me like the app is leaking memory, gets killed (at ~1.8gb), and gets restarted (until it allocates the <=2gb again) and so on.
Do we know for sure if this is not you a bug in the software? From what i understand the app is reading data from the rpc-node and writing it into the database, is it expected to require +2gb of memory? And if so do we have an idea on what the required limit is, so we can set up a new nodepool accordingly.

Do we know for sure that this is not a bug in the software?

Not sure at all if you ask me. This memory (from your link) doesn't look normal (the 2 jump to the bottom are when the pod get killed) :

indeed looks like a common pattern resulting from memory leakage

My "findings", based mostly on what you can read https://tech.residebrokerage.com/debugging-node-js-memory-problems-d450787d9253
I have a local node with ~700 blocks with activity such as governance proposal.

Launch the following to be able to inspect the node process yarn build && PRISMA_ENDPOINT=http://<IP_ADDRESS>:4466 yarn prisma reset && PRISMA_ENDPOINT=http://<IP_ADDRESS>:4466 ARCHIVE_NODE_ENDPOINT="ws://<IP_ADDRESS>:9944" MAX_LAG=1 node --inspect ./lib/index.js
in chrome chrome://inspect/#devices
take heap snapshot at launch, around block 350, and close the 700.

We can see the following (comparing snapshot 1 and 3):

^The memory leak is clearly noticeable even with so few data, the heap keeps increasing. Unfortunately, the heap explorer didn't allow me to pin point a particular constant in our code. It seems that an array keeps increasing without being freed (on this example, 1.2Mb allocated, 0.2Mb freed between snapshot 1 and 3). this is how the biggest array looks like in details, you may find something interresting.
I then did the same, removing any task other than createBlockNumber, the leak is still here:

Note that I left createBlockNumber arbitrarily.
Another experiment I did, my Kusama node got stuck at block 700, so I've let nodewatcher go up until block 700, and just let it "Waiting for finalization or a max lag of 1 blocks.", while taking heap snapshots every minute or so. Note that this is a heap without any task at all (not even createBlockNumber)

The heap increases slower than with tasks, but most importantly, as soon as it waits, it seems that GC is doing a big job.
I did the same test with all tasks again, and we can see the same behaviour:

My goal was to see if I could reproduce our problem easiely --> definitely
Now we need to look at the code in first, and identify what could leak. I will test also older commits (before introducing the max_lag) and see how the heap behaves.

Just realized, we're launching our node with node -r ts-node/register --max-old-space-size=8192 ./src/index.ts indicating 8192 would mean that this process can take up to 8Gb memory isn't it? isn't that telling the GC to not care much unless we are around this value?

Also ts-node is not recommended to be used in production. https://github.com/TypeStrong/ts-node/issues/104
We should build with tsc and run node lib/index.js

Just realized, we're launching our node with node -r ts-node/register --max-old-space-size=8192 ./src/index.ts indicating 8192 would mean that this process can take up to 8Gb memory isn't it? isn't that telling the GC to not care much unless we are around this value?

it should be so i think, but look at the console the nodewatcher deployment hasn't used more than 1GB memorey in the past 30 days....


Mp3 encoder

Fixes https://github.com/processing/p5.js-editor/issues/13

The encoder library (for OSX only for now) is added to lib/ffmpegsumo.so.
'copy-ffmpeg-default' task for copying ffmpegsumo.so file into ./node_module/nwjs... folder, run by default task, to copy lib file for development.
copyFfmpegBuild function called by build function callback to overwrite the file in ./dist/... folder for real build

Notes:

Licence needs to be changed to GPL (not sure about it anymore)
With every nwjs update, the ffmpegsumo.so file needs to be updated to the file coming with Chrome with the same Chromium version as nwjs. Instructions

wonderful! thank you!!!


documentation / example extension for: server-sent-events-eventsource request.

At first, thanks for the tool (using the VS-Code extension).
I am not a Javascript programmer. I want to test APis with your Tool.
Presently, I am not able to test the SSE. There is no result / output visible after closing the session.
For the test, I have used the example in: https://dev.to/dhiwise/how-to-implement-server-sent-events-in-nodejs-11d9
Thanks in advance.

@beva-sdev Hi all my documentation is hosted on httpyac.github.io. I have updated the SSE examples once with postman-echo. But here I get partial errors. I'm still trying to identify where they come from. Somewhere there are connection problems and I can't tell yet if the used dependency or the server is faulty.

using sse.dev works without error. Seems to be some issues with postman-echo
# @keepStreaming
SSE https://sse.dev/test
Event: message

If you can't get it to work, maybe you can send me the server code and I'll take a look.

Thanks,
the  Event: message header is the solution, works as expected.

@beva-sdev I added it as default event with the next release.


Refactor client types and options

This commit refactors the client types and options in the client-types.ts file. It introduces new interfaces for common types, signer getters, gas options, transaction callbacks, skip client options, execute route options, execute cosmos message options, and sign cosmos message options.

Noticed alot of repeat and unified typing from my docs work. Attempted to clean it up. This may be a hazardous PR to merge mid-widget v2 sprint however.


Decode doesn't work with spaces in the path

My code:
        codes = reader.decode(r"C:\\Users\\oscar\\Projects\\Camera Project\\captures\\barcode_Color.png")

The error message:
Exception in thread "main" java.util.concurrent.ExecutionException: javax.imageio.IIOException: Can't get input stream from URL!
        at java.util.concurrent.FutureTask.report(Unknown Source)
        at java.util.concurrent.FutureTask.get(Unknown Source)
        at com.google.zxing.client.j2se.CommandLineRunner.main(CommandLineRunner.java:96)
Caused by: javax.imageio.IIOException: Can't get input stream from URL!
        at javax.imageio.ImageIO.read(Unknown Source)
        at com.google.zxing.client.j2se.ImageReader.readImage(ImageReader.java:44)
        at com.google.zxing.client.j2se.DecodeWorker.decode(DecodeWorker.java:125)
        at com.google.zxing.client.j2se.DecodeWorker.call(DecodeWorker.java:76)
        at com.google.zxing.client.j2se.DecodeWorker.call(DecodeWorker.java:56)
        at java.util.concurrent.FutureTask.run(Unknown Source)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
        at java.lang.Thread.run(Unknown Source)
Caused by: java.io.FileNotFoundException: C:\Users\oscar\Projects\Camera (The system cannot find the file specified)
        at java.io.FileInputStream.open0(Native Method)
        at java.io.FileInputStream.open(Unknown Source)
        at java.io.FileInputStream.<init>(Unknown Source)
        at java.io.FileInputStream.<init>(Unknown Source)
        at sun.net.www.protocol.file.FileURLConnection.connect(Unknown Source)
        at sun.net.www.protocol.file.FileURLConnection.getInputStream(Unknown Source)
        at java.net.URL.openStream(Unknown Source)
        ... 9 more

Specifically this line:
Caused by: java.io.FileNotFoundException: C:\Users\oscar\Projects\Camera (The system cannot find the file specified)

Please try codes = reader.decode(r"C:\Users\oscar\Projects\Camera\ Project\captures\barcode_Color.png")

If there are any updates, feel free to reopen this issue.


feat: remove the retweets that include likes @SaveToNotion

Description

I want to remove some meaningless retweets, such as those mentioning @SaveToNotion or @readwise.
Additional context
I feel using the setInterval method is not very well, but i can't think of a bettery way.
 Submitted with StackBlitz Codeflow.

We could use a MutationObserver I think

Thank you for recommending this API. I was not aware of it before.
I have tested it, and it is much better than before.
At first, I wanted to disconnect the observer after the page loaded. However, when I scrolled up back to the top, those retweets appeared again. It seems Twitter loads data dynamically.  So the result is still not very satisfactory.
Thanks again, and just let it gone. I will close this PR.


Integration Test - Release - 2019/02/01 11:40:47

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@adunndevster : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.


v2.2.3 Posting Comments Doesn't work

Steps to reproduce
login
post comment
Failure Logs
InnertubeError: Request to https://www.youtube.com/youtubei/v1/comment/create_comment?prettyPrint=false&alt=json failed with status 403
    at HTTPClient.<anonymous> (D:\Users\PC\Documents\YT\Commenter\node_modules\youtubei.js\dist\src\utils\HTTPClient.js:112:19)
    at Generator.next (<anonymous>)
    at fulfilled (D:\Users\PC\Documents\YT\Commenter\node_modules\youtubei.js\dist\src\utils\HTTPClient.js:5:58)
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  info: '{\n' +
    '  "error": {\n' +
    '    "code": 403,\n' +
    '    "message": "The caller does not have permission",\n' +
    '    "errors": [\n' +
    '      {\n' +
    '        "message": "The caller does not have permission",\n' +
    '        "domain": "global",\n' +
    '        "reason": "forbidden"\n' +
    '      }\n' +
    '    ],\n' +
    '    "status": "PERMISSION_DENIED"\n' +
    '  }\n' +
    '}\n',
  date: 2022-09-24T01:09:20.544Z,
  version: '2.2.3'
}

Expected behavior
post a comment
Current behavior
doesn't
Version
Default
Anything else?
No response
Checklist

[X] I am running the latest version.
[X] I checked the documentation and found no answer.
[X] I have searched the existing issues and made sure this is not a duplicate.
[X] I have provided sufficient information.

Just tested this recently and I did not encounter any issues.

Can't reproduce, are you perhaps using a brand account? They are known to be problematic.

Can't reproduce, are you perhaps using a brand account? They are known to be problematic.

could be that


Feature Request: Configurable sticky cookie name

Do you want to request a feature or report a bug?
feature
This feature request is related to https://github.com/containous/traefik/issues/1574 and https://github.com/containous/traefik/pull/1716, https://github.com/containous/traefik/pull/1712 already had the perfect solution but was dropped.
For heavy traffic applications like ours it would be very good if the LB cookie name would be configurable, the old implementation already had a VERY long cookie name, now it can become even longer, what we see with 1.4RC3 is _TRAEFIK_BACKEND_backend-adserver-production at ~800M Requests per day, this cookie name alone accounts for ~35GB of traffic.
It would be great to have a) the backend addition https://github.com/containous/traefik/pull/1716#issuecomment-307330224 optional and b) to make the cookie name configurable, we are very careful with cookies, 99% of our users only have a cookie i=someid, so it would be good if we could use t= or _= for traefik.

Every time someone does not respect the issue's template, a little bunny dies.

Please edit your issue description to respect the issue template as much as possible.

@ldez I added the one headline related to this feature request.

@MichaelErmer Sorry I closed by mistake.

This would be nice. Especially because #1716 was not a backward compatible change. Would make the upgrade process easier.

Thanks for your feedback @MichaelErmer, a PR will follow up soon :)

Closed by #2232.


Shortcut stopped working on Vivaldi

General information

Operating system + version: Arch Linux, up-to-date on 30.03.2019
Browser + version: Vivaldi 2.4.1488.35
Information about the host app:

How did you install it?: Package manager (AUR)
If installed an official release, put a version: Browserpass host app version: 2.0.21

Information about the browser extension:

How did you install it?

Installed through the AUR package, as a policy

Browserpass extension version as reported by your browser: 2.0.22

Exact steps to reproduce the problem

Install browserpass using Vivaldi
Try to trigger the popup using Ctrl+Shift+L

What should happen?
The selection popup should open.
What happened instead?
The selection popup doesn't open.
I hope you can take a look at this, this seems to have broken with the last Vivaldi update.

Sorry I don't use Vivaldi, so I can only give some generic advices for you to try. Since it's based on Chromium, does it have chrome://extensions/shortcuts, and if so, can you confirm that you see Browserpass shortcut there? If not, try to set it there.

I understand, thanks for the feedback. Yes, it's definitely listed there:
. I might try taking it up with the Vivaldi developers then. Unfortunate.

Yeah, seems like it's Vivaldi's fault, I'm not the only one. Thanks for the reply!

Gotcha 👍
By the way, if you can test the next major version of browserpass, please have a look in https://github.com/browserpass/browserpass/issues/331 😉 In particular, I'm curious if I guessed the configuration files for Vivaldi correctly:
https://github.com/browserpass/browserpass-native/blob/8411954b5a38ed7ed78aad2036e0bebdebfa982f/Makefile#L132-L154
https://github.com/browserpass/browserpass-native/blob/8411954b5a38ed7ed78aad2036e0bebdebfa982f/Makefile#L254-L276


fix: bind to http://localhost by default

Fixes #242

I wonder if we should continue to bind to <IP_ADDRESS> and print localhost. There’s a chance that if running inside a container and it needs to listen to an external port, binding to localhost isn’t enough.
Also, I don’t know if it’s possible but can we write a test to ensure Azure Static Web Apps emulator started is always printed when the emulator is ready? The reason for this is VS Code needs a string to watch for to indicate that the emulator is ready.

I will include a test for the message.
Binding to <IP_ADDRESS> can still be possible using --host <IP_ADDRESS> if the user needs to access the CLI from outside of localhost (container or mobile device...).


Enhance existing search functionality

Description

[ ] WHY - What is the problem this feature would answer?
Route users as directly as possible to the most relevant profile page and ultimately evidence page based upon the top hit results to access key data of interest across multiple entities.

[ ] HOW are we going to solve the problem?
Stage 1:
a) Confirm proposed behaviour for autocomplete feature based on usage stats
b) Review search function code to accommodate search via potential further entities e.g . drug, tissue, pathway.
c) Review subsequent requirements for refreshed search page design

Stage 2:
Potential to add chips to search field in order to build a query
Technical design under core team review to assess effort involved.

[ ] WHAT would this look like?

Progress Tracker

I would suggest:

split autocomplete, search and lookup in the API and data_pipeline
create a benchmark (eg. the average search ranking of a random 1000 genes)
optimize the search function to maximize the benchmark in 2.

These steps are completely independent of allowing chips/tags in the search UI, but are necessary groundwork.

Other additional search considerations
(i) Consider requirement to search by PMID:
Users wants to see the genes and disease involved by a single paper, or all the evidence that is associated with the same piece of literature.
(ii) Search by pathway
Use case:
To get to which genes are involved in a given pathway - there is no way currently to search via UI on the pathway directly, only via API using the reactome id.
Currently within the platform, users can search a particular disease and filter via pathway facet.
Evidence page --> affected pathway section --> point to reactome.
Batch search requires two genes to search and obtain the information via this route.

Closing as any agreed actions will be addressed as appropriate within platform repository roadmap epics.


Added filter[groups] and filter[organization]

Looks good via http://developer.twinehealth.com/preview/7158-new-filters-for-rewards