[doc-enhancement][Updatedfirst-react-app.md]

Updated for revamp

Docs Build status updates of commit 4e130e5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-react.md
:bulb:Suggestion
View
Details

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-app-react.md

Line 47, Column 15: [Suggestion-disallowed-html-tag] HTML tag 'link' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
84
30
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
83
29
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit ed074d1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-react.md
:bulb:Suggestion
View
Details

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-app-react.md

Line 45, Column 15: [Suggestion-disallowed-html-tag] HTML tag 'link' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
83
29
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit d2dbf21:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-react.md
:bulb:Suggestion
View
Details

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-app-react.md

Line 45, Column 15: [Suggestion-disallowed-html-tag] HTML tag 'link' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
84
28
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 8b58255:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-react.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md

Line 34, Column 14: [Warning-link-out-of-scope] File 'assets/videos/app-react-sample_0.3.mp4' referenced by link '../assets/videos/app-react-sample_0.3.mp4' will not be built because it is not included in build scope.
Line 33, Column 24: [Suggestion-disallowed-html-attribute] HTML attribute 'allowfullscreen' on tag 'video' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
84
28
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
84
28
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit a338929:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-react.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md

Line 50, Column 14: [Warning-link-out-of-scope] File 'assets/videos/app-react-sample_0.3.mp4' referenced by link '../assets/videos/app-react-sample_0.3.mp4' will not be built because it is not included in build scope.
Line 49, Column 24: [Suggestion-disallowed-html-attribute] HTML attribute 'allowfullscreen' on tag 'video' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
84
28
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 78a0180:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-react.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md

Line 50, Column 14: [Warning-link-out-of-scope] File 'assets/videos/app-react-sample_0.3.mp4' referenced by link '../assets/videos/app-react-sample_0.3.mp4' will not be built because it is not included in build scope.
Line 49, Column 24: [Suggestion-disallowed-html-attribute] HTML attribute 'allowfullscreen' on tag 'video' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f08c7f6:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-react.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md

Line 50, Column 14: [Warning-link-out-of-scope] File 'assets/videos/app-react-sample_0.3.mp4' referenced by link '../assets/videos/app-react-sample_0.3.mp4' will not be built because it is not included in build scope.
Line 49, Column 24: [Suggestion-disallowed-html-attribute] HTML attribute 'allowfullscreen' on tag 'video' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
84
28
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
85
26
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 28a6af9:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-react.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md

Line 50, Column 14: [Warning-link-out-of-scope] File 'assets/videos/app-react-sample_0.3.mp4' referenced by link '../assets/videos/app-react-sample_0.3.mp4' will not be built because it is not included in build scope.
Line 49, Column 24: [Suggestion-disallowed-html-attribute] HTML attribute 'allowfullscreen' on tag 'video' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
87
23
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 2eabe21:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-react.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md

Line 50, Column 14: [Warning-link-out-of-scope] File 'assets/videos/app-react-sample_0.3.mp4' referenced by link '../assets/videos/app-react-sample_0.3.mp4' will not be built because it is not included in build scope.
Line 49, Column 24: [Suggestion-disallowed-html-attribute] HTML attribute 'allowfullscreen' on tag 'video' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
87
23
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit ef6060b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-react.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md

Line 50, Column 14: [Warning-link-out-of-scope] File 'assets/videos/app-react-sample_0.3.mp4' referenced by link '../assets/videos/app-react-sample_0.3.mp4' will not be built because it is not included in build scope.
Line 49, Column 24: [Suggestion-disallowed-html-attribute] HTML attribute 'allowfullscreen' on tag 'video' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
87
23
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit f4b983b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-react.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md

Line 50, Column 14: [Warning-link-out-of-scope] File 'assets/videos/app-react-sample_0.3.mp4' referenced by link '../assets/videos/app-react-sample_0.3.mp4' will not be built because it is not included in build scope.
Line 49, Column 24: [Suggestion-disallowed-html-attribute] HTML attribute 'allowfullscreen' on tag 'video' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
87
23
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 196c7b9:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-react.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md

Line 50, Column 14: [Warning-link-out-of-scope] File 'assets/videos/app-react-sample_0.3.mp4' referenced by link '../assets/videos/app-react-sample_0.3.mp4' will not be built because it is not included in build scope.
Line 49, Column 24: [Suggestion-disallowed-html-attribute] HTML attribute 'allowfullscreen' on tag 'video' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
87
23
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit e5179b9:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-react.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md

Line 50, Column 14: [Warning-link-out-of-scope] File 'assets/videos/app-react-sample_0.3.mp4' referenced by link '../assets/videos/app-react-sample_0.3.mp4' will not be built because it is not included in build scope.
Line 49, Column 24: [Suggestion-disallowed-html-attribute] HTML attribute 'allowfullscreen' on tag 'video' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
87
23
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 0c5209f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-react.md
:warning:Warning
View
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md

Line 50, Column 14: [Warning-link-out-of-scope] File 'assets/videos/app-react-sample_0.3.mp4' referenced by link '../assets/videos/app-react-sample_0.3.mp4' will not be built because it is not included in build scope.
Line 49, Column 24: [Suggestion-disallowed-html-attribute] HTML attribute 'allowfullscreen' on tag 'video' isn't allowed. Disallowed HTML poses a security risk and must be replaced with approved Docs Markdown syntax.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
87
23
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit b56d52e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
87
23
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 195b4e6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
87
23
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit edc896c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
97
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 1d852b4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
97
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 25ec865:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
97
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit aa35b5e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 822365a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/teams-toolkit-v2/app-react-video-poster.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/react-app-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/videos/app-react-sample_0.3.mp4
:white_check_mark:Succeeded

msteams-platform/get-started/first-app-react.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
97
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

I think we should change the file names. As we talked, the calling the Overview page code-sample doesn't make any sense.
And I'd suggest changing this one to something like first-app.md too, because this is basically the hello-world (the first build and run) and using React is not the main focus in the new structure.

I think we should change the file names. As we talked, the calling the Overview page code-sample doesn't make any sense.
And I'd suggest changing this one to something like first-app.md too, because this is basically the hello-world (the first build and run) and uReact is not the main focus.

Docs Build status updates of commit 9a080d0:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/first-app-react.md
100
2
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

For test of video file.


menubar add extension menu

We love extension menu in Atom.
Extension Menu can find which actions provided in installed extensions quickly.

@f111fei thanks for this PR. Please understand that a change like this with UI impact needs to be discussed first with the team and might not be accepted if we feel that such an extension menu is desired or not.
Let's discuss in https://github.com/Microsoft/vscode/issues/6033

@bpasero   Sure, It`s better if you can provide an api similar to https://atom.io/docs/api/v1.7.3/MenuManager.

@f111fei, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Closing, we do not intent to build a menu structure like this.

So your intent is to have extensions placing all sorts of menu items all over the place, resulting in cluttered menus in which the user won't have any chance of finding anything?


name convention

"rump kernel" not the smae thing as "rumprun unikernel"

Where do I need to make the change? Can you help me with the copy please.


Support for parquet files with nested structures

I am trying to use Petastorm to pass a PySpark dataframe (read from a parquet file) to PyTorch.
In my case, the dataframe consists of 3 columns:

samples in columns 1 and 2 are 2D arrays of integers with size (None, 32)
samples in column 3 are scalars

When making the Spark converter using make_spark_converter() and make_torch_dataloader(), columns 1 and 2 are ignored and I get the following warning:
UserWarning: [ARROW-1644] Ignoring unsupported structure ListType(list<element: list<element: int32>>)
As I understand, discarding nested structures was added to Petastorm as a workaround to a pyarrow bug for parquet files with nested structures. However, the pyarrow bug has been fixed since arrow version 2.0.0 (see Python notes HERE), my parquet file can be read with pyarrow (after upgrading to latest version).
I would appreciate if such parquet files can be supported by Petastorm.
Best,
Mossad

@selitvin I can confirm the PyArrow fix and this should be a straight-forward patch to remove the previous workaround, subject to bumping the minimum version of the associated dependency to pyarrow>=2.0.0. Is there any reason that wouldn't work for consumers (i.e.: any known use cases that require earlier versions of PyArrow)?

@mossadhelali want to submit a PR, as described above?

@dmcguire81 Thanks for your reply and confirmation. I removed the PyArrow workaround and bumped up pyarrow to pyarrow>=2.0.0 but now I get the following error in arrow_reader_worker.py here :
Length of all values in column 'col1' are expected to be the same length. Got the following set of lengths: '1000, 1000, 563, 1000, 1000, 945, 1000, 945'
Seems that lists of lists are assumed to be of the same length across all samples. In my case col1 in the parquet file has the shape (num_training_samples, None, 32).
Can you please comment on whether the fix is still simple enough for me to implement?

My guess would be that the fix that actually helps you make progress is now more complex, given the extra constraints, but just the original goal of this issue ("Support for parquet files with nested structures"), in the general case, stays simple, whether or not that's useful for your problem.

I'm not familiar enough with make_torch_dataloader to venture a guess, but at least the reported dimension of (num_training_samples, None, 32) for col1 coming out of the code and the dimension you thought you had in the description ((None, 32)) are mismatched. Is it possible that meant to have a Parquet Row Group with num_training_samples rows of (None, 32)-dimensioned matrices, instead?

Thank you @mossadhelali  for picking it up and @dmcguire81  for your help.
There is an assumption that all lists have the same length in the current collate implementation (the code @mossadhelali  has pointed).
One way to go around it is to implement a TransformSpec that would align the lengths. This is geared towards TF constraint of working with tensors only. For pytorch users, it's too constraining I guess. Perhaps a better solution is to introduce a user defined collate function that would relax this constraint?
I can not work on this in the several coming weeks, but if @mossadhelali  can propose a PR with a solution we could work together to get it in.
I wonder if we can let user specify a collate function implementation that

Any updates on this issue? Will this workaround be removed in the next version?

This issue is currently blocking a project I’m working on. Has anyone created a PR to address?  @mossadhelali how did you address the original issue?

@baumanab I ended up padding the vectors to make them the same length and created a mask that is multiplied by the model outputs, i.e. similar to what is done in sequence models in NLP.
@selitvin Unfortunately, I don't have the time currently to work on a fix.

Re-reading, it looks straight forward to address in setup.py and unischema logic. @mossadhelali please let me know if you plan to create a PR, otherwise I’ll probably create one over the next week.

@baumanab did you end up creating a PR for this? I am also running into the same issue.

I started working on it, but put it down due to other time demands.  Are
you interested in collaborating on a fix?  I can point you to where I am.
On Tue, Oct 4, 2022 at 9:00 AM mirko-m @.***> wrote:

@baumanab https://github.com/baumanab did you end up creating a PR for
this? I am also running into the same issue.
—
Reply to this email directly, view it on GitHub
https://github.com/uber/petastorm/issues/690#issuecomment-1267226627,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABA5ZEWU5L5QQ5H3CDKOPUTWBRIAHANCNFSM46UA6MYQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I found a workaround, so this is no longer a pressing issue for me. However, I am interested in collaborating on a fix since that seems like a good opportunity to dive a bit deeper into petastorm.

That’s great to hear. I started on a fix for the PR. I’ll share what I have. What was your workaround?

On Oct 7, 2022, at 11:32 AM, mirko-m @.***> wrote:

I found a workaround, so this is no longer a pressing issue for me. However, I am interested in collaborating on a fix since that seems like a good opportunity to dive a bit deeper into petastorm.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

Sorry for the late reply. My workaround is to have multiple columns with flat arrays instead of a single column with a nested array. Then, in the loop over the dataloader I stack the flat arrays from the columns. Please let me know what I can do to help.

@baumanab Where is your fix up to in terms of progress?

My first attempt is directed surfacing the ignore flag to top layer and updating pyarrow to a version that handles nested structures. I was pretty close but had to put it down. I’ll work over the next week to complete. I could definitely use some help with review and test cases.

On Oct 23, 2022, at 4:09 AM, Brian L @.***> wrote:

@baumanab Where is your fix up to in terms of progress?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

Sorry for the late reply. My workaround is to have multiple columns with flat arrays instead of a single column with a nested array. Then, in the loop over the dataloader I stack the flat arrays from the columns. Please let me know what I can do to help.

No problem, sorry for mine as well. I could use help with review and test cases. I plan to have something testable no later than 1 week from today.   Great workaround btw.

Sounds good. Just ping me when you have something and I can try to help.

Are there any news on supporting nested structures?


Considered context not working correctly

When I have a codeblock in my note that includes a frontmatter, The plugin mistakenly removes everything prior to that code block when trying to gather the considered context.
So for example:
---
name: A
---

# This is a MD file.

```
---
name: B
---
```
As you see, B was inside a codeblock in the page.

This 👆 Will send "```As you see, B was inside a codeblock in the page.\n" as context. Not the whole page.
I'd like to try to fix this issue myself if you want. Seems like a good first issue and I can familarize myself with the codebase in the process :pray:

should be fixed in the next release

can you test with the beta release

tested and its working on version 0.5.25-beta
i'm closing this issue


glib-macros: remove KNOWN_GLIB_EXPORTS

See https://github.com/gtk-rs/gtk-rs-core/issues/127 for details.
Crates checked locally:

gtk-rs-core.
gtk3-rs.
gtk4-rs.
gstreamer-rs.
gst-plugins-rs.

Except for clone!, I didn't spot any explicit use of glib:: in the other macros.
I think full CI should be launched on these crates after this is merged though.
Fixes https://github.com/gtk-rs/gtk-rs-core/issues/127
Fixes https://github.com/gtk-rs/gtk-rs-core/issues/129

Does this require users to explicitly depend on glib now instead of indirectly via e.g. gtk?

Does this require users to explicitly depend on glib now instead of indirectly via e.g. gtk?


Update environment variable name for amazonS3builder in integration (#2550)

Which issue does this PR close?
Closes #2550
Rationale for this change
Update the environment variables names injected in the integration pipeline to test AmazonS3 client. The objective is to avoid conflicts when testing real injection while testing AmazonS3Builder::from_env() function.
What changes are included in this PR?
Update the github workflow pipeline + integration tests to leverage new names.
Are there any user-facing changes?
No

@tustvold it seems that AWS_* are useful as an environment variable for the CI. At least to work with localstack.
I'm starting to think that anyway we will need those variable in the CI, so we can just reuse them as is for testing the environment.
What do you think about it?

I'm not sure I follow what you mean, and the CI seems to currently be failing?

Yes, I understand that we need (at least) the key_id, the secret_key correctly setup for the CLI to execute aws --endpoint-url=http://localstack:4566 s3 mb s3://test-bucket.
But, it's seems to be not needed anymore after that. I'll try to setup environment by steps as you mention.

@tustvold it should be better now.
Sorry for not having put a draft tag on this PR at first 😅


Null icon name in parsed manifest

I found that the icon name is null for the following attached apk.
Version 2.1.1 works fine for this apk.
Version 2.1.2 results in the following exception: java.lang.NumberFormatException: For input string: "0x20000"
Version 2.1.3 onwards results in an empty icon name.
missing.icon.name.zip

A bug introduced recently.
Fixed in: https://github.com/caoqianli/apk-parser/commit/dfe77700c3f22973449f047f0d8d61c113de752b

Verified the fix. Thanks again for the quick response.


Update composer.json version

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


The editor allows you to create an indoor map; Embeds limit the zoom

Take a look at this map,
http://team.cartodb.com/u/andrew/viz/e3fdf7c4-abac-11e4-9ab0-0e4fddd5de28/embed_map
In the editor I'm a full 2 zooms further in

we limit zoom to the limit of the basemap so if you change the basemap to a plain color basemap it will allow to zoom in more

maybe we just need a warning in the editor then. because in the editor the basemap turns up great. or maybe we don't need such a low limit on our internal basemaps?
what is interesting, is when i made that map it was showing me our basemaps at the high resolution. i created teh table from scratch, went in, drew some features at high zoom, the basemap was always there....
i just clicked an option on the basemap menu and now it wont let me load it back again

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


test: empty last error message if volume expansion works

Signed-off-by: David Ko<EMAIL_ADDRESS>

No need, because we will rely on the original logic, https://github.com/longhorn/longhorn-engine/pull/816.


XcmV3Junctions uses XcmV4Junction instead of declaring a separate XcmV3Junction type

The current codegen on fee5ecb6d09dea073f130fd2a58995907bd36c9c generates the following using westend asset hub as the metadata
export type XcmV3Junctions = Enum<{ type: "Here", value: undefined } | { type: "X1", value: Anonymize<XcmV4Junction> } | { type: "X2", value: Anonymize<I42l4nthiehb7> } | { type: "X3", value: Anonymize<I2jk9pdm4ajs0n> } | { type: "X4", value: Anonymize<I293rauivpnv4n> } | { type: "X5", value: Anonymize<Id42rc2s9m61aa> } | { type: "X6", value: Anonymize<Ibe9k3j6og3ch4> } | { type: "X7", value: Anonymize<I3vkvorkiqho0h> } | { type: "X8", value: Anonymize<Icmb7nn8ip4qrt> }>;
export const XcmV3Junctions = _Enum as unknown as GetEnum<XcmV3Junctions>;

export type XcmV4Junction = Enum<{ type: "Parachain", value: Anonymize<number> } | { type: "AccountId32", value: Anonymize<I5891blicehaji> } | { type: "AccountIndex64", value: Anonymize<Idrke3qhmim88u> } | { type: "AccountKey20", value: Anonymize<I3liki1s5lgett> } | { type: "PalletInstance", value: Anonymize<number> } | { type: "GeneralIndex", value: Anonymize<bigint> } | { type: "GeneralKey", value: Anonymize<Ic1rqnlu0a9i3k> } | { type: "OnlyChild", value: undefined } | { type: "Plurality", value: Anonymize<Ibb5u0oo9gtas> } | { type: "GlobalConsensus", value: Anonymize<XcmV4JunctionNetworkId> }>;
export const XcmV4Junction = _Enum as unknown as GetEnum<XcmV4Junction>;

XcmV3Junctions is constructed with XcmV4Junction rather than XcmV3Junction, which doesn't exist. Looking at the metadata, XcmV4Junction and XcmV3Junction are the same type.
https://www.diffchecker.com/ayqPJnXm/
Should we provide an alias for XcmV3Junction? Because I am writing client side code like this and it is strange seeing  XcmV4Junction inside of a  XcmV3Junctions.X2 call.
 .submit$(account.address, {
        asset: {
          parents: 0,
          interior: XcmV3Junctions.X2([
            XcmV4Junction.PalletInstance(50),
            XcmV4Junction.GeneralIndex(BigInt(ASSET_ID)),
          ]),
        },
      })

Of course, one such solution is to put it on the user to just rename the import and then problem solved. question is, is this the desired DX? I have no idea so putting it up for discussion.

I fail to understand why this is an issue

XcmV3Junctions is constructed with XcmV4Junction rather than XcmV3Junction, which doesn't exist.

It does exist

Looking at the metadata, XcmV4Junction and XcmV3Junction are the same type.

I don't think so.

XcmV3Junctions is constructed with XcmV4Junction rather than XcmV3Junction, which doesn't exist.

It does exist

Looking at the metadata, XcmV4Junction and XcmV3Junction are the same type.

I don't think so.

run this https://github.com/ryanleecode/westend-asset-hub-test-papi
and u should get the following as the codegen
https://gist.github.com/ryanleecode/95c46612bf084c6c480234fb59a606ee
--

I fail to understand why this is an issue

Doesn't have to be, depends how you view it ofc. For me I was updating your example app  and it was a bit of a headscratcher to see the XcmV3Junction vanished. I checked the types and saw that it was aliased with XcmV4Junction. And that left me wondering are XcmV4Junction and XcmV3Junction really the same, is the codegen bugged? So i checked the metadata and saw that it was.
Now its obvious, well duh just import XcmV4Junction as XcmV3Junction. But it may not be obvious to everyone, especially newer developers or developers who are new to the ecosystem. For example a developer might do the following,

type XcmV3Junction
hit the quick fix hotkey in their editor, to make it auto import
no autoimport shows up
developer is now confused

So i'm not saying the current codegen is wrong, on a technical basis it is correct; just wondering if this is the right DX.

So i checked the metadata and saw that it was.

It really isn't, though. I probably made a mistake when I did the initial seed of the dictionary... Although, the mistake is likely to be in the name of the XcmV3Junctions.
Ok, I see. yeah, this is an issue... but probably not what you thought it was. Ok, so what I meant is that in principle it's very possible that in a runtime where they have updated to a newer version of XCM, some of the inner primitives are still using constructs from previous versions... So, it's not necessarily wrong to see an Enum of a newer version use something from another version. However, what you are describing here it is off, because its an older version referencing something newer, and that doesn't make sense.
Again, this is likely because of a mistake that I made when i created the initial seed of the dictionary... Whenever we have some time we will improve both the dictionary, and the tooling that we use for maintaining it.
So, yeah, I would rather close this issue and open a more generic issue about that... Because that's something that's under our radar. Also, any help with that would be greatly appreciated.

makes sense, thanks @josepot !


Keys of properties.labels field on instance templates are changed to camel case when creating.

Environment details

OS: MacOS 12.1
Node.js version: 16.3.1
npm version: 8.1.2
@google-cloud/compute version: 3.1.1

Steps to reproduce
When setting the properties.labels field the client library generates an error because it tries to transform the keys of the labels into camel case, which isn't valid.
The following code produces an error when run:

(async() => {
  const instanceTemplatesClient = new compute.InstanceTemplatesClient();

  await instanceTemplatesClient.insert({
    project: process.env.GCP_PROJECT, instanceTemplateResource: {
      "description": "Test",
      "name": "test-labels",
      "properties": {
        "canIpForward": false,
        "confidentialInstanceConfig": {
          "enableConfidentialCompute": false
        },
        "description": "",
        "disks": [
          {
            "autoDelete": true,
            "boot": true,
            "deviceName": "instance-template-1",
            "initializeParams": {
              "diskSizeGb": "10",
              "diskType": "pd-balanced",
              "labels": {},
              "sourceImage": "projects/debian-cloud/global/images/debian-10-buster-v20220118"
            },
            "mode": "READ_WRITE",
            "type": "PERSISTENT"
          }
        ],
        "labels": {"test-that-its-broken": ""},
        "machineType": "e2-medium",
        "metadata": {
          "items": []
        },
        "networkInterfaces": [
          {
            "accessConfigs": [
              {
                "kind": "compute#accessConfig",
                "name": "External NAT",
                "networkTier": "PREMIUM",
                "type": "ONE_TO_ONE_NAT"
              }
            ],
            "network": "projects/dev-project-lazy-test-io/global/networks/default"
          }
        ],
        "reservationAffinity": {
          "consumeReservationType": "ANY_RESERVATION"
        },
        "scheduling": {
          "automaticRestart": true,
          "onHostMaintenance": "MIGRATE",
          "preemptible": false
        },
        "serviceAccounts": [
          {
            "email"<EMAIL_ADDRESS>            "scopes": [
              "https://www.googleapis.com/auth/devstorage.read_only",
              "https://www.googleapis.com/auth/logging.write",
              "https://www.googleapis.com/auth/monitoring.write",
              "https://www.googleapis.com/auth/servicecontrol",
              "https://www.googleapis.com/auth/service.management.readonly",
              "https://www.googleapis.com/auth/trace.append"
            ]
          }
        ],
        "shieldedInstanceConfig": {
          "enableIntegrityMonitoring": true,
          "enableSecureBoot": false,
          "enableVtpm": true
        },
        "tags": {
          "items": []
        }
      }
    }})
})();

Generated error:
Error: Invalid value for field 'resource.properties.labels': ''. Label key 'testThatItsBroken' violates format constraints. The key must start with a lowercase character, can only contain lowercase letters, numeric characters, underscores and dashes. The key can be at most 63 characters long. International characters are allowed.
    at Function.parseHttpError (/Users/pauljohnson/Programming/lazy_cloud/server/node_modules/google-gax/src/googleError.ts:63:7)
    at decodeResponse (/Users/pauljohnson/Programming/lazy_cloud/server/node_modules/google-gax/src/fallbackRest.ts:102:45)
    at /Users/pauljohnson/Programming/lazy_cloud/server/node_modules/google-gax/src/fallbackServiceStub.ts:151:34
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Changing the key to testthatitsbroken works.

I'm seeing this as an issue. If you use any label key that has a _ underscore, the library changes it to camelcase, and then an error is thrown stating uppercase letters are not allowed.

This happens after google updated the google-gax package version from 3.1.2 to 3.1.3. I downgraded the version of the google-gax package to 3.1.2, and It works

Also getting this issue creating a VM with instanceResource.labels that have - (e.g. camel-case), these are also converted to camel case (e.g. camelCase).

google-gax issue: googleapis/gax-nodejs#1288

This will be resolved with https://github.com/googleapis/gax-nodejs/pull/1299


long_options doesn't need to be static

Without this change, scan-build warns that the address of stack variable gui is being stored in a global variable.
Practically speaking, this doesn't really matter much since main() is only ever called once, but it's an easy fix and there's really no reason not to do it.

I think I would prefer to keep long_options in global storage and the warning would probably go away by making gui static (putting in global storage). But this does not matter much so am merging this PR.


Check for kafka/network errors on finalizeKind, to unblock the borker deletion if the cluster is not reachable

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>Fixes #2569

Proposed Changes

If apache kafka is not reachble, we do not longer block the finalization of the broker

Release Note

If apache kafka is not reachble, we do not longer block the finalization/deletion of the knative kafka broker

Docs

Short version:
LGTM, but let's improve in a separate ticket/PR.
Long version:
The bad case that can happen is that one started having network issues and tried deleting the broker. Then we leak the topic. I don't think it is not a good idea to block the deletion for the possibility of network is coming back. We cannot know when it will come back.
However, for short network hiccups that live a short period of time, it would be a shame to not wait and not delete the topic.
Can we add a retry mechanism? Like, try 5 finalization attempts (preferably with exponential backoff) before giving up. We can store the attempt counts in the resource status or in an annotation. We should never wait for the brokers that were never ready (never created a topic) though. I am 100% ok to merge this PR to unblock namespaced broker usecases, but we can do this improvements in a separate PR.

However, for short network hiccups that live a short period of time, it would be a shame to not wait and not delete the topic.
Can we add a retry mechanism?

that is actually a good idea to explore

I know you're not there with this PR yet

perfect timing :smile:  I was about to update this PR and include the test

/retest
Strimzi operator issues

@aliok this is ready. Retry is done separately...

@matzew Thanks. I see all jobs are green, which is awesome. It proves the issue is fixed.
However, I added some comments here: https://github.com/knative-sandbox/eventing-kafka-broker/pull/2570#discussion_r964565706

/lgtm
/approve

/retest

/hold

/test unit-tests_eventing-kafka-broker_main
/test integration-tests_eventing-kafka-broker_main

/retest

/retest

Kafka Source  flakes:

/test integration-tests-namespaced-broker_eventing-kafka-broker_main
Kafka Source flakes..

/unhold

/cherry-pick release-1.6


[BUG]: state variables/concepts lose their description in template_model_to_petrinet_json

template_model_to_petrinet_json is lossy when it comes to the description of the state variable concepts.
https://github.com/gyorilab/mira/blob/0eec1320569663728e609fc498003c9d3ca553f3/mira/modeling/amr/petrinet.py#L349
The PetriNet AMR JSON schema supports state variable descriptions; so, concept description should probably be preserved in the JSON.
Example:

as a TemplateModel JSON:
https://github.com/liunelson/mira/blob/nliu/experiment/notebooks/nliu/data/monthly_demo_202410/prob5_test.json
as a AMR
https://github.com/liunelson/mira/blob/nliu/experiment/notebooks/nliu/data/monthly_demo_202410/Prob 5 Model A (1%2C992 counties).json

I believe I fixed the issue and will open a PR.
Here is an example of an petrinet amr that was created from loading in the template model json you linked (the first file) and exporting it as a petrinet amr. As you can see concept descriptions are now propogated.
https://github.com/nanglo123/mira/blob/42f9725fc23b5f8d0d64b46850a1af5b57ccfd01/mira/modeling/amr/propogated_concept_description_petrinet.json


[HUDI-5389] Remove Hudi Cli Duplicates Code.

Change Logs
JIRA: HUDI-5389. Remove Hudi Cli Duplicates Code.
In the process of reading the code, I found some duplicate code, I think this part of the duplicate code can be removed directly.

cli
hudi-spark

org.apache.hudi.cli.DedupeSparkJob
org.apache.spark.sql.hudi.DedupeSparkJob

org.apache.hudi.cli.DeDupeType
org.apache.spark.sql.hudi.DeDupeType

org.apache.hudi.cli.SparkHelpers
org.apache.spark.sql.hudi.SparkHelpers

The code on the left side of the table can be directly replaced by the code on the right side of the table, because their contents are exactly the same.
Impact
none.
Risk level (write none, low medium or high below)
none.
Documentation Update
none.
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@bvaradar Thank you for your help to review the code! I will modify the code.

@slfan1989 : Any updates ?

@bvaradar I will complete the modification within 1-2 days.

@slfan1989 : Did you accidentally close this PR ? Asking because you mentioned you will update the PR. Thanks

Did you accidentally close this PR ? Asking because you mentioned you will update the PR. Thanks

@bvaradar Sorry, I accidentally closed the PR, I have resubmitted the PR. Can you help to review the new PR? Thank you very much!
New PR - https://github.com/apache/hudi/pull/8360


Avoid the use of stride tricks to make code more readable

Admittedly this is a style issue, but I feel like stridetricks isn't very useful in this particular case and it somewhat destroys readability for me.
While the reshaping is cute, I honestly don't think it helps much with the python overhead.
I hit this code in trying to implment frustum culling for my application (though I still haven't succeeded in getting a performance improvement).
Let me know what you think.
I think there is also some complexity in the code due to an attempt at making it generaizable to beyond a single "aabb" object.
However, I didn't see any tests for this, and so my presumption is that this is problem and likely the cause of much of the original code compelxity.

I think there is also some complexity in the code due to an attempt at making it generaizable to beyond a single "aabb" object.

Yes, (almost) all functions in pylinalg are meant to also work on batches (i.e. arrays) of objects. That ability provides a big performance benefit in cases where multiple objects must be transformed. If the test for that is missing for this function, we should probably add that too, to make sure the changes don't break that ability.

We can merge this if you just run ruff on the changes.

??? locally it tells me there is nothing to change:
(dev) ✔ ~/git/pylinalg [simplify_aabb|✔]
mark@carbon $ ruff --version
ruff 0.8.4
(dev) ✔ ~/git/pylinalg [simplify_aabb|✔]
mark@carbon $ ruff check --verbose pylinalg/misc.py
[2024-12-25][08:55:51][ruff::resolve][DEBUG] Using configuration file (via parent) at: /home/mark/git/pylinalg/pyproject.toml
[2024-12-25][08:55:51][ruff_linter::settings::types][DEBUG] Detected minimum supported `requires-python` version: 3.9
[2024-12-25][08:55:51][ignore::gitignore][DEBUG] opened gitignore file: /home/mark/.cvsignore
[2024-12-25][08:55:51][ruff::commands::check][DEBUG] Identified files to lint in: 3.464185ms
[2024-12-25][08:55:51][ruff::commands::check][DEBUG] Checked 1 files in: 18.243µs
All checks passed!
(dev) ✔ ~/git/pylinalg [simplify_aabb|✔]
mark@carbon $

Git pull my commits and reinstall your full venv. I redid the whole packaging setup.

$ conda create --name linalg python=3.12
$ conda activate linalg
$ pip install -e ".[dev,docs,examples]"
$ ruff check .
All checks passed!
$ which ruff
/home/mark/miniforge3/envs/linagl/bin/ruff

still nothing.
Merry Christmas! You know making the most of the time off ;{)

It's ruff format . that you're missing :)

1. -> 1.0

took so much engineering time ^_^

maybe one day i'll be brave enough to use ruff format in my own projects!


AWS S3 screenshot uploads not working

Not sure if this is just something messed up with our configuration.. but all screenshot uploads to S3 suddenly stopped working a week ago or so. The console output just says "Failed uploading".
Our configuration is a little different, it's a private S3 bucket, but I've made sure to allow the Task role permissions to write to the S3 bucket (I even allowed the whole account and every single S3 action).
If more information is needed, let me know, I can provide more.

hi,
have the same error. my s3 bucket is public. error is:
AuthorizationQueryParametersErrorError parsing the X-Amz-Credential parameter; the region 'us-east-1' is wrong; expecting 'us-west-2'us-west-2

@KyleThenTR  @lipt0n  What cypress version are you using?

I have just checked the master branch and it all works fine. Same for the demo version  at https://sorry-cypress-demo.herokuapp.com/, which runs the most recent sorry-cypress version also works.
@KyleThenTR When you say "private" do you mean it has no public read? That shouldn't affect the write operations. Can you please run cypress in debug mode DEBUG=cypress:* to see the error details?
@lipt0n what is your S3_REGION and S3_BUCKET configuration? Googling it resembles this issue. You can explicitly set S3 DNS via (S3_READ_URL_PREFIX)[https://github.com/agoldis/sorry-cypress/blob/master/packages/director/src/screenshots/s3/s3.ts#L51:L51] (the name is actually misleading)

i did try setting S3_REGION and S3_READ_URL_PREFIX , but error is the same:
cypress:server:api request to url: PUT http://flipper-cypress-1182330490.us-west-2.elb.amazonaws.com:8080/instances/a82a594a-d7cb-44e9-ac95-2d3994841537 with params: {"body ....
.....
cypress:server:record failed to upload artifact { file:
....
AuthorizationQueryParametersErrorError parsing the X-Amz-Credential parameter; the region 'us-east-1' is wrong; expecting 'us-west-2'us-west-2

or is this something to setup in sorry cypress director ?  setting this up in cypress doesn't change a thing

ok, I.ve got it
after setting S3_REGION env in director it starts working.
thx for help!

@agoldis looks like they are uploading now, it's just not showing up on sorry cypress. We are on Cypress v5.0.0. Could that be the reason the screenshots stopped showing?

@KyleThenTR Are you able to access the S3 image by just typing the uploaded image URL? I believe it has something to do with the way you set permissions on S3.

@agoldis no I can't. I think it does have to do with the fact the the bucket is private and I can't set the bucket policy to be allowed for *. Now that I think about it, the bucket got changed to private the other week and that's when it stopped working. Don't think I can change that though since it's policy now

I suppose I could setup a cloudfront distribution to be able to access those images and then set that S3_READ_URL_PREFIX param

@agoldis I fixed this. I had to set the S3_ACL env var to private and then add a cloudfront distribution in front of the S3 bucket, and then updated the S3_READ_URL_PREFIX to the cloudfront distribution URL. This can be closed.


bin/grav install fails with message

Fatal error: Class Grav\Common\Errors\Errors may not inherit from final class (Whoops\Run) in grav/system/src/Grav/Common/Errors/Errors.php on line 14

Same as https://github.com/getgrav/grav/issues/536 ? Are you running the official release?

I am running the latest build with
git clone https://github.com/getgrav/grav.git

Read what I wrote on the other commit. There's a PR in place to fix this error, but it's not yet merged because we need to drop PHP 5.4 because of changes in the Whoops library, and we need to prepare for that.
You can use that branch now (https://github.com/getgrav/grav/pull/527), or just checkout the latest 1.0.5 release instead of develop.
Unless for development, I'd advise not to clone from Git directly, since Grav has an update mechanism already built-in.


Fix the crash during recording

This fix addresses the following issue: Invalid read in audio demo
Protect recording_data with a mutex to prevent racing.
Tested with my crashing project for 5 minutes. No crashes.

Thanks for the contribution.
Pull Requests should be made against the master branch, otherwise they will be missing in the future Godot versions. Release managers then cherry-pick relevant ones for the stable branches.
Note also that we have our own Mutex class: core/os/mutex.h.

The new pull request is here: https://github.com/godotengine/godot/pull/36569


Speaker page design Fixes

[x] Make org and name font-size equal
[x]  Make description gray
[x]  Content Align left
[x] Room page pills adjusted

Current coverage is 42.58% (diff: 100%)

Merging #711 into development will not change coverage

@@           development       #711   diff @@
=============================================
  Files                6          6
  Lines              688        688
  Methods             71         71
  Messages             0          0
  Branches           112        112
=============================================
  Hits               293        293
  Misses             395        395
  Partials             0          0

Powered by Codecov. Last update 5bf115b...052ead0


Print version and commit hash in printouts

@gregorgorjanc I am wondering if the printouts here refer to the pytest report, if that is the case then for each action of the test workflow, the commit hash can be seen from the workflow page:

@gregorgorjanc To access the version from the terminal, we can use pip show AlphaPeel:
(base) evie@Xingers-MacBook-Air AlphaPeel % pip show AlphaPeel
Name: AlphaPeel
Version: 1.1.1
Summary: Multilocus and hybrid peeling
Home-page:
Author: Andrew Whalen
Author-email<EMAIL_ADDRESS>License: MIT license
Location: /Users/evie/mambaforge/lib/python3.10/site-packages
Requires: numba, numpy
Required-by:

We can also add an option -version if necessary so that we can access the version of AlphaPeel via AlphaPeel -version. But for the commit hash, I am unsure if we would include the information in the software when we upload it to the PyPI.

—version would be awesome, but a printout on the screen while it’s working might be useful too?!

We can work on the commit hash later - I managed to get it working with AlphaMate - can check later.

@gregorgorjanc
For now, the printout looks like the following
(base) evie@Xingers-MacBook-Air functional_tests % bash runTests.sh
Reading in AlphaGenes format: test1/genotypes.txt
Reading in sequence data : test1/seqfile.txt
Use of an external phase file is not currently supported. Phase information will be translated to genotype probabilities. If absolutely necessary use a penetrance file instead.
External penetrance file included, but esterrors flag used. The two options are incompatible. esterrors set to false.
Reading in penetrance file: test1/penetrance.txt
Cycle  0
Peeling Down, Generation 0
Peeling Up, Generation 0
Cycle  1
Peeling Down, Generation 0
Peeling Up, Generation 0
Cycle  2
Peeling Down, Generation 0
Peeling Up, Generation 0
Cycle  3
Peeling Down, Generation 0
Peeling Up, Generation 0
Cycle  4
Peeling Down, Generation 0
Peeling Up, Generation 0
Writing to  test1/outputs/output.seg
[1] "Test 1: Success"

I think maybe we can add the version information at the beginning of the printout.

I think maybe we can add the version information at the beginning of the printout.

Yeah, something like AlphaPeel, version: X.Y.Z

@jwoollia reports
For example every time I open R I get the version e.g. I am on 'Beagle Scouts'. Likewise ASReml prints the version as it runs e.g. 'AlphaPeel version 1.1.3 ...'. In Rstudio with the interface there is a help which gives the version and build.  The latest 'brick in the wall' is I am no longer automatically an administrator due to a change in UoE policy so I then have to remember to 'Make Me An Adminstrator', but that is just another hurdle to climb over and which may appear at any time.


[BUG] Multi-node cluster role error

Launch a 3-node harvester cluster. Only one node has the role of master and the other two nodes have the role of worker.
# kubectl get nodes
NAME             STATUS   ROLES                       AGE    VERSION
hailong-h2       Ready    <none>                      140m   v1.20.4+k3s1
hailong-h3       Ready    <none>                      131m   v1.20.4+k3s1
hailong-hvst-1   Ready    control-plane,etcd,master   178m   v1.20.4+k3s1

All 3 nodes should be master nodes
Environment:

Harvester ISO version:   master-0008ce84-head
Installation Mode: ISO
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):

Validate version master 04/23
# kubectl get nodes
NAME        STATUS   ROLES                       AGE     VERSION
hailong-1   Ready    control-plane,etcd,master   59m     v1.20.4+k3s1
hailong-2   Ready    control-plane,etcd,master   7m49s   v1.20.4+k3s1
hailong-3   Ready    control-plane,etcd,master   8m1s    v1.20.4+k3s1


[AERIE-1727]  get put expansion

Tickets addressed: AERIE-1727
Review: By commit
Merge strategy: Merge (no squash)

Description

Verification

Documentation

Future work

Closing and replacing with https://github.com/NASA-AMMOS/aerie/pull/92 (this way I don't get confused when seeing Dylan as the PR owner 😂). Thanks for doing the heavy lifting here.


weather results not updating

running the example.py at 2pm on Nov,13 2021 in Canada , getting the results that seems not updated:
26
2021-11-09 00:00:00 Clear 36
2021-11-10 00:00:00 Cloudy 33
2021-11-11 00:00:00 Cloudy 31
2021-11-12 00:00:00 Mostly Cloudy 43
2021-11-13 00:00:00 Sunny 38
Used to work well, what could be wrong?

Same, not seeing any new data.

It was functional again since yesterday.  Nothing touched. No idea what happened. But all good now.


fix: use physical index to removePair

Codecov Report
Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.94%. Comparing base (eb25ba2) to head (456f13d).

Files
Patch %
Lines

ast/node.go
71.42%
1 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
- Coverage   73.80%   72.94%   -0.87%
==========================================
  Files          62       76      +14
  Lines        8266     8964     +698
==========================================
+ Hits         6101     6539     +438
- Misses       1826     2067     +241
- Partials      339      358      +19

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Provisioning "The Perspective" template failed

Describe the issue
A clear and concise description of what the issue is.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Details (please complete the following information):

PnP Correlation ID: a13e4f9d-9143-41e6-a7aa-d7b2b2a56a81
Reference Template: https://lookbook.microsoft.com/details/6944f54d-cc8e-45ca-ba13-5f887a2d5f81
Primary language of the target tenant: English
Are you using a Tenant Global Admin account to provision the template: Yes

Additional context
Add any other context about the problem here.

Hi,
Thanks for using the Look Book site. Based on the event log, we can see - based on the provided Correlation ID - that you targeted an already existing site and the exception was "Forbidden". Could you please try to provision the solution to a different site URL? In case of any issue, please create another item and provide the corresponding Correlation ID for further investigation. Thanks for your cooperation.


Add blazor authorize router view SN-432

Task: https://saritasa.atlassian.net/browse/SN-432

I added a login feature to the demo app to test authorization for the admin panel, possibly showcasing the authentication and authorization functions. I'm unsure whether we should keep it or remove it.
FYI: Login page

Is it fine, that I can access admin panel without logging in?

@AlexanderMakarov124 I just updated. By default, if we don't set any rules (roles or custom check function), anybody can access the admin panel.

@hieu-nguyentan Please, resolve possible conflicts with dev.

@AlexanderMakarov124 I just updated. By default, if we don't set any rules (roles or custom check function), anybody can access the admin panel (include anonymous).

Could you please update the demo to allow access to authorized users only? All roles are allowed.


workbench.action.moveEditorTo<Side>Group does not change the focused editor group

Does this issue occur when all extensions are disabled?: Yes

Version: 1.78.2
Commit: b3e4e68a0bc097f0ae7907b217c1119af9e03435
Date: 2023-05-10T15:00:40.428Z (1 wk ago)
Electron: 22.5.2
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.4.0
Sandboxed: No

Steps to Reproduce:

Add the following keybindings: (mac only)
[
	// #region Spawn terminal
	{
		// spawn terminal in current editor group, replace text editor if untitled and unedited.
		"key": "cmd+alt+t",
		"when": "editorTextFocus && resourceScheme == untitled && !activeEditorIsDirty",
		"command": "runCommands",
		"args": {
			"commands": [
				"workbench.action.createTerminalEditor",
				"workbench.action.closeActiveEditor"
			]
		}
	},
	{
		// spawn terminal in current editor group, replace text editor if untitled and unedited.
		"key": "cmd+alt+t",
		"when": "(terminalEditorFocus || editorFocus) && resourceScheme != untitled",
		"command": "workbench.action.createTerminalEditor"
	},
	// #endregion

	// #region Move current editor to pane (CTRL + SHIFT + CMD + <direction>)
	{
		"key": "ctrl+shift+cmd+up",
		"when": "editorTextFocus || terminalEditorFocus",
		"command": "workbench.action.moveEditorToAboveGroup"
	},
	{
		"key": "ctrl+shift+cmd+right",
		"when": "editorTextFocus || terminalEditorFocus",
		"command": "workbench.action.moveEditorToRightGroup"
	},
	{
		"key": "ctrl+shift+cmd+down",
		"when": "editorTextFocus || terminalEditorFocus",
		"command": "workbench.action.moveEditorToBelowGroup"
	},
	{
		"key": "ctrl+shift+cmd+left",
		"when": "editorTextFocus || terminalEditorFocus",
		"command": "workbench.action.moveEditorToLeftGroup"
	}
	// #endregion
]

Make sure your window is empty (has no groups).

Press CMD + OPT + T to create a terminal.

Press CMD + OPT + T again to create a second terminal.

Press CMD + CTRL + SHIFT + RIGHT to create and move the current terminal to the right

Press CMD + OPT + T to create a new terminal. (terminal is supposed to open on the right group, but opens on the left)

https://github.com/microsoft/vscode/assets/125522276/2b619b3b-3d7c-4284-8fcb-5f6bc1381a51

This is actually by design, see https://code.visualstudio.com/updates/v1_61#_locked-editor-groups


Include the test class in the JUnit Description

Fixes #61

Travis failure looks unrelated, but I generated this from GitHub's web UI so it'd be nice to see Travis pass before merging.

Yes. No one has contributed in a looooong while so the build configuration is stale. I'll fix it here soon and rebase your PR.

(Soon == order of days, I'm on paternity leave)

OK I fixed the CI build and rebased your change but now there's actual tests failing. I'll try to look later in the week unless you beat me to it.

Yeah, this fix on its own isn't going to work. I'm afraid I don't have the time to dig into this further, but it certainly would be nice if Burst preserved the test class in the description.


JSON fail to parse HP should be reworded

We have received customer feedback that the 'Fail' info lines can be confusing. This should be reworded to something friendlier to avoid the confusion.
Relevant line here: https://github.com/aws/sagemaker-containers/blob/8ba4085548d28c8651cbd28b3049af58b3057fbc/src/sagemaker_containers/_env.py#L214

@ericaws,
Any suggestions on the new wording? Feel free to submit a PR as well.

@ericaws
Any suggestions on the new wording? Also could you tell us what's confusing your customer?

Closing due to lack of activity.


JSX element class does not support attributes because it does not have a 'props' property.

I keep getting this error while trying to style DropShadow component:
JSX element class does not support attributes because it does not have a 'props' property.
I tried with the newest version and also with 0.0.4 and with the same code as in documentation example:
<DropShadow
      style={{
        shadowColor: "#000",
        shadowOffset: {
          width: 0,
          height: 0,
        },
        shadowOpacity: 1,
        shadowRadius: 5,
      }}
    >

Trying to wrap up the View component.
I am using React 18.2.0 and React Native 0.71.2.

It's typescript only-issue, in RN 0.71 there is no type Constructor that used in <project-root>/node_modules/react-native-drop-shadow/index.d.ts
Main functionality working perfect
To temporary solve this issue replace content of your <project-root>/node_modules/react-native-drop-shadow/index.d.ts with:
import React from "react";
import * as RN from "react-native";

export interface PropsView extends RN.ViewProps {}
declare class DropShadowComponent extends React.Component<PropsView> {}
declare const DropShadowBase: RN.NativeMethods &
  typeof DropShadowComponent;

export default class DropShadow extends DropShadowBase {}

You can also use patch-package to store changer made in node_modules

It's typescript only-issue, in RN 0.71 there is no type Constructor that used in <project-root>/node_modules/react-native-drop-shadow/index.d.ts
Main functionality working perfect
To temporary solve this issue replace content of your <project-root>/node_modules/react-native-drop-shadow/index.d.ts with:
import React from "react";
import * as RN from "react-native";

export interface PropsView extends RN.ViewProps {}
declare class DropShadowComponent extends React.Component<PropsView> {}
declare const DropShadowBase: RN.NativeMethods &
  typeof DropShadowComponent;

export default class DropShadow extends DropShadowBase {}

You can also use patch-package to store changer made in node_modules

Thanks so much for sharing this workaround! This also worked for me on a project with React 18.2.0 and React Native 0.71.4.
@hoanglam10499 - Is there any chance the source can be updated with this fix? (Forgive me - I'm not sure if this will break things for older versions of React Native.)

It's been a while since I've checked for updates. It appears that this issue is resolved in v0.0.7.
Thanks so much to the contributors (@hoanglam10499) for their hard work!!


Actuator updates

Updates to the actuator disk propeller and electric motor models for integration into the solar model.

@galbramc these test failures seem like mosek issues on some of the VMs

They sure do! Weird, I thought we just fixed those last month.

@courtin looking good.  Mostly minor changes.

@mjburton11 should be fixed now

sorry I'm working on upgrading the VM's and hashing out some of the hickups.

test this please

test models please

test models please

looks like jenkins is back in business, and all the tests are passing for this PR.

done

test models please

test models please

@galbramc still something strange going on with the tests for this PR - it looks like one if being marked as failed despite all the tests passing.

You have to go to console output to interpret those...one timed out (at 90 minutes! what kind of processor prioritization is going on on that machine anyway :p) while the other two lost internet access for a bit.

test models please

finally. one of the VMs was busy all day.

woo!


CB-12002 adding hbase-spark jars to HBASE_CLASSPATH in opdb blueprint

This commit is needed to allow any Spark job to connect to an HBase running in Public Cloud.
Previously this configuration change had to be made manually in CM for HBase, now we make it to be the default config, so any 7.2.10+ HBase cluster created in the cloud will be reachable from Spark through hbase-spark connector.

HODOR until CDPD-25051 not implemented

Hello @doktoric !
after some considerable amount of time, we finally have the necessary symlinks in the 7.2.11 parcel that makes this blueprint change upgrade-friendly.
I tested the new opdb blueprint in the cloud. I provisioned a COD (Operational Database, HBase) cluster with a relatively recently built runtime version (<IP_ADDRESS>-150) where the symlinks are all already present. Thanks to the extra config added to the blueprint, now I was able to use the Spark-Hbase connector from a DataEngineering (spark2) cluster, connecting to the COD database.
The symlinks in the 7.2.11 parcel:
[csso_mszalay@cod--1u4tfaib8p9tx-worker1 ~]$ ls -la /opt/cloudera/parcels/CDH/lib/hbase_connectors/lib/hbase-spark.jar
lrwxrwxrwx 1 root root 34 Jun 23 05:36 /opt/cloudera/parcels/CDH/lib/hbase_connectors/lib/hbase-spark.jar -> hbase-spark-<IP_ADDRESS>.2.11.0-150.jar

[csso_mszalay@cod--1u4tfaib8p9tx-worker1 ~]$ ls -la /opt/cloudera/parcels/CDH/lib/hbase_connectors/lib/hbase-spark-protocol-shaded.jar
lrwxrwxrwx 1 root root 50 Jun 23 05:36 /opt/cloudera/parcels/CDH/lib/hbase_connectors/lib/hbase-spark-protocol-shaded.jar -> hbase-spark-protocol-shaded-<IP_ADDRESS>.2.11.0-150.jar

[csso_mszalay@cod--1u4tfaib8p9tx-worker1 ~]$ ls -la /opt/cloudera/parcels/CDH/lib/hbase_connectors/lib/scala-library.jar
lrwxrwxrwx 1 root root 25 Jun 23 05:36 /opt/cloudera/parcels/CDH/lib/hbase_connectors/lib/scala-library.jar -> scala-library-2.11.12.jar

With these extra jars on the classpath, every opdb hbase clusters will be able to handle spark connections without the need of manual tweaking.
Could you take a look on this change?

thanks @doktoric for the review!
I'm not familiar with the process, do I need to do anything more with the PR?
(I think I can not merge it, at least I see no button on the github UI)

Hello @doktoric,
could you please merge this PR or let me know who to ask or how to proceed?
Thanks!


Rewrite in Typescript

Changes

Reimplement using Typescript
Combine TOS acceptance and publication in a single workflow
Remove dependencies to third party packages (contributor-assistant, dawidd6/action-download-artifact)
Only PR submitter needs to accept the TOS
Do not fail the workflow if no artifacts were found or the TOS weren't accepted
Delete workflow artifacts upon successful publication

Pending Changes

Share packages across projects (layout.ts, io.ts)

Closing as the legal requirements have changed and imply an implementation change


WIP fix(62): Add validation of logicalplan

related issue: https://github.com/polarsignals/arcticdb/issues/62 (Filtering by the wrong literal type causes a panic)
@brancz @thorfour I was wondering wondering if I could get confirmation that the general approach here is OK?
I added a file validate.go to the logicalplan module that can has logic to check if the plan is valid as well as some types to represent/print validation errors.
This code is still work in progress -- still need to add some more unit tests, do some more testing, clean up the code a bit, etc. I wanted to get some input from y'all first before I take us down the wrong path.
From a high level, does the approach make sense? Is this how/where we want to be validating the logical plans?
There's probably some other validations that I could try to add as well, either as part of this work or as a future PR. For example, we could maybe add some validations for type of expressions that are passed into Aggregation, Distinct and Projection.

I think this approach makes sense to me. One question I had regarding the Validate function was it looks like it only validated the last part of the plan and none of the input logical plans, we'd want to recurse backwards to validate each part of the plan right?

 I was planning to make it recurse up the inputs as well. I will add that 👍

This is awesome! 🎉
Great contribution!

Thank you so much for this!