Preserve folding state per file open/close

@Amr1977 Please give more details.
Add a small code sample, describe what you see and what you expect.

I just upgraded to latest vscode 1.27.1, the requested feature is now there, I was talking about preserving fold/unfold state for files between file open/close, meaning if I fold a section of a file and close that file then reopen the file I expect the folded part to keep being folded, I just retested it now and it is implemented.
Thank you very much for the brilliant job :+1:

Thanks. We had that for a long time. Must have been a bug that this didn't work. If you have reproducible steps, please reopen.


Exclude binaries

The repo currently includes factorio-server-manager and factorio-server-manger.exe. This PR removes them from the repo.
If you're up for rewriting history, consider git reseting (and force-pushing) master to match my exclude_binaries_rewrite_history branch, currently 68f99575147a5757208235b9fa3f84339dae0e95. This is the result of bfg --delete-files '{factorio-server-manager,factorio-server-manger.exe}', and it removes the binaries from the repo's history, shrinking everyone's future repo clones by 16 MB.

Thanks commited the binaries during development but don't need them in the repo anymore.


The syntax for the tgb property="{variable}" is too confusing

For tgb: users have to constantly put their properties within quotes and brackets which is very confusing. For example,
tgb.table("{table_dict}", properties=table_properties)

does not work but:
tgb.table("{table_dict}", properties="{table_properties}")

does
This is way too confusing and is not the expected syntax when coding in pure Python with the tgb. The user should be able to input his variable directly even if this means getting the variable name and adding "{...}" on our end

I was quite confused by this, because the syntax in markdown
<|{table_dict}|table|properties=table_properties|>
was working just fine.
The error displayed was
TypeError: unhashable type: ‘dict’
which did not really helped me

This issue has been postponed as outlined in the PR https://github.com/Avaiga/taipy/pull/635.
We can circle back to this issue later on if needed


Getting "cannot call method 'indexOf'" when running node app.js

Any suggestions?
TypeError: Cannot call method 'indexOf' of undefined
at isPrimaryService (/Users/dolivas/Projects/pagerduty-dashboard/server/groups.js:148:30)
at getServiceName (/Users/dolivas/Projects/pagerduty-dashboard/server/groups.js:165:7)
at buildService (/Users/dolivas/Projects/pagerduty-dashboard/server/groups.js:31:17)
at /Users/dolivas/Projects/pagerduty-dashboard/server/groups.js:21:33
at Array.forEach (native)
at buildServices (/Users/dolivas/Projects/pagerduty-dashboard/server/groups.js:20:15)
at module.exports (/Users/dolivas/Projects/pagerduty-dashboard/server/groups.js:11:22)
at makeUpdatePackage (/Users/dolivas/Projects/pagerduty-dashboard/server/main.js:56:16)
at /Users/dolivas/Projects/pagerduty-dashboard/server/main.js:40:24
at /Users/dolivas/Projects/pagerduty-dashboard/server/main.js:51:5

Hi David,
Thanks for your interest. Does node app.js run when using mock data? (Use mock: true in config.json)

it does work with mock data, just not with my api key and subdomain set it seems

Could you replace groups.js:148 with:
try {
    return service.description.indexOf('[dashboard-primary]') !== -1;
  } catch (e) {
    console.log(service);
    return false;
  }

and tell me what gets printed out?

I receive a list of all my pagerduty services and then a line with the date. Nothing afterwards and the web server doesn't start.
......
{"id":"REDACTED","name":"Test","service_url":"/services/REDACTED","service_key":"redacted@redacted.pagerduty.com","auto_resolve_timeout":14400,"acknowledgement_timeout":1800,"created_at":"2013-09-19T08:03:37-07:00","deleted_at":null,"status":"active","last_incident_timestamp":null,"email_incident_creation":"on_new_email_subject","incident_counts":{"triggered":0,"resolved":0,"acknowledged":0,"total":0},"email_filter_mode":"all-email","type":"generic_email","incident_urgency_rule":{"type":"constant","urgency":"high"},"scheduled_actions":[],"support_hours":null}
Sat Aug 08 2015 19:33:36 GMT-0700 (MST): Sending update.

Thanks David.
The issue here is that the object should have a description key as documented here: https://developer.pagerduty.com/documentation/rest/services/list
The missing description is the "undefined" in "TypeError: Cannot call method 'indexOf' of undefined".
I just set up a dashboard from scratch and it is working. On my end, I have services without descriptions that come back with the field as an empty string. I also went with a direct curl request and the services also show up with an empty description string.
As a sanity check, could you post the response from the below request for your subdomain and token?
curl -H "Content-type: application/json" -H "Authorization: Token token=TOKEN" -X GET -G "https://SUBDOMAIN.pagerduty.com/api/v1/services"

Some things I am considering:

Maybe no descriptions on any service causes the API not to reply with any descriptions?
The buildService function is messing up the object (during json parsing or object extension), which could be influenced by the environment?

What version of Node are you running?

Node version is v0.10.31,
Description is empty on all services it seems. I don't see anywhere in my pagerduty account where I can populate this field.
Here's a sample of one
{"id":"REDACTED","name":"REDACTED","service_url":"/services/REDACTED","service_key":"REDACTED","auto_resolve_timeout":14400,"acknowledgement_timeout":1800,"created_at":"2014-09-05T08:40:53-07:00","deleted_at":null,"status":"active","last_incident_timestamp":null,"email_incident_creation":"on_new_email_subject","incident_counts":{"triggered":0,"resolved":0,"acknowledged":0,"total":0},"email_filter_mode":"all-email","type":"generic_email","incident_urgency_rule":{"type":"constant","urgency":"high"},"scheduled_actions":[],"support_hours":null,"description":""}
Is there a way to replace null values with an empty string or a space even though it doesn't seem like the best fix?

Is there a way to replace null values with an empty string or a space even though it doesn't seem like the best fix?

I will go ahead and do that. If the API cannot guarantee the presence of that field (which it is not doing although the documentation suggests that it should), then my code should not assume that it exists.

I don't see anywhere in my pagerduty account where I can populate this field.

When you're on the edit page for a service, to the right of the large field for the name, there's a light grey chevron titled "Description (optional)". You can find it with a CTRL-F. To prevent future confusion, would you mind adding a description and seeing if it changes the API response?
If it does end up changing things, I will add a note to the README. Either way, I will put in a code fix.
Thanks for your help diagnosing this issue.

Let me know if it works in the new version.


Add lishlansdown's file

created a branch, created a file and made a commit, and opened a pull request

Here's a comment


HADOOP-17370. Upgrade commons-compress to 1.21

JIRA: HADOOP-17370

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
29m 24s

trunk passed

+1 :green_heart:
compile
0m 22s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 22s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
mvnsite
0m 27s

trunk passed

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
shadedclient
45m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 15s

the patch passed

+1 :green_heart:
compile
0m 14s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 14s

the patch passed

+1 :green_heart:
compile
0m 14s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
0m 14s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 16s

the patch passed

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 14s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 15s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
shadedclient
14m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 18s

hadoop-project in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

63m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3274/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3274

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml

uname
Linux c2bc27f833f6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2bcd8b9d4089b62e97185b5a19f4f5799a818e2b

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3274/1/testReport/

Max. process+thread count
727 (vs. ulimit of 5500)

modules
C: hadoop-project U: hadoop-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3274/1/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Looks PR #2452 is closed by mentioning that there are so many test case failures.. could please confirm the same..? and license file also updated.?

Update the license file. The license file is under the root directory, therefore all the unit tests will be run in the precommit job.

Thank you for picking up this, @aajisaka . :)

+1 from my side although I didn't check the CI result here.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  1s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 13s

trunk passed

+1 :green_heart:
compile
21m 20s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
18m 48s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
mvnsite
24m 47s

trunk passed

+1 :green_heart:
javadoc
7m 34s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
7m 36s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
shadedclient
28m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
20m  6s

the patch passed

+1 :green_heart:
compile
20m 39s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
20m 39s

the patch passed

+1 :green_heart:
compile
18m 38s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
18m 38s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
20m 14s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
7m 29s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
7m 42s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
shadedclient
29m 47s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
774m  2s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 40s

The patch does not generate ASF License warnings.

1015m 34s

Reason
Tests

Failed junit tests
hadoop.tools.dynamometer.TestDynamometerInfra

hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy

hadoop.yarn.server.router.clientrm.TestFederationClientInterceptor

hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3274/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3274

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml shellcheck shelldocs

uname
Linux 200d2c1a73e2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 063a35d280db7d81caa0bc0c8ac9d42ff6abb353

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3274/2/testReport/

Max. process+thread count
3637 (vs. ulimit of 5500)

modules
C: hadoop-project . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3274/2/console

versions
git=2.25.1 maven=3.6.3 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

The test failures look unrelated to the patch.

Thanks @steveloughran @dongjoon-hyun @virajjasani and @brahmareddybattula


[Bug] Incorrect file paths

Description
The web page is only displaying the HTML but the CSS is not being rendered when you go live. This is because the file paths  do not point to where the files are located.
Reproduction

Fork and clone the repository
Install the project dependencies
Run the servers.
See error. No CSS is being rendered in the webpage

Expectation
We expect to see a page with all the images, logos and styles.
Screenshots

Additional context
In order to work on the issue of the unresponsive header, this issue needs to be fixed first.
Implementation

[ x ] I would be interested in resolving this bug.

Closing as a duplicate of #28


Logo design

The SHEDEVER studio team pays close attention to the details of each of its products.
We strive to create not just another DEX, but an authentic, multifunctional tool that is part of the gaming Ecosystem of the SHEDEVER studio, which includes a series of 5 games based on Chess, Checkers, Backgammon, Go and Poker, as well as a multifunctional GameFi Marketplace.
We want the SHEDEX logo to reflect the essence of its concept - a universal crypto exchanger designed to create a seamless gaming experience for the Web2 and Web3 community.
However, we do not want to limit your imagination and creative enthusiasm! Feel free to express your ideas and show us your vision for the future GameFi DEX logo!
Additional Notes:

Once the design is finalized, add it to the project repository in an MD file, providing links to the Figma designs.

 Yes, sure


Implementation of reward issues screen

Why?
Implementation of annotations screen
How?
A temp functionality to open the annotations screen on View Reward Details tap
Testing
Ignore any weird stuff in the rewards tap and just tap the View Reward Details button to navigate to the annotations screen.
Once the PR is approved the navigation functionality will be removed and will be finalized in the next PR
Additional context
fixes fe-656

@PavlosTze good catches, now is ready to review


sol2 overridable_function_members suggest!!

In the example overridable_function_members. The usage of injection is introduced. I want to ask if there is a non-injection.
Example: This way of use
#define SOL_ALL_SAFETIES_ON 1
#include <sol/sol.hpp>

#include <iostream>

int main() {
std::cout << "=== override-able member functions ===" << std::endl;

struct thingy {
thingy(){
}

virtual void paint() {
std::cout << "p" << std::endl;
}
};

sol::state lua;
lua.open_libraries(sol::lib::base);

lua.new_usertype<thingy>("thingy",
sol::constructors<thingy()>(),
"paint", &thingy::paint);

sol::string_view code = R"(
obj = thingy.new()
obj:paint()
obj.paint = function (self) print("g") end
obj:paint()
function obj:paint () print("s") end
obj:paint()
)";

lua.safe_script(code);

std::cout << std::endl;

return 0;
}

The demand is actually the hope that the virtual function of the corresponding C++ class can be implemented in Lua.
Now there is no error when writing this way, but all the calls are on the C++ side.

So one thing to clarify: what do you expect this code to print?
#define SOL_ALL_SAFETIES_ON 1
#include <sol/sol.hpp>

#include <iostream>

int main() {
     std::cout << "=== override-able member functions ===" << std::endl;

     struct thingy {
          thingy(){
          }

          virtual void paint() {
               std::cout << "p" << std::endl;
          }
     };

     sol::state lua;
     lua.open_libraries(sol::lib::base);

     lua.new_usertype<thingy>("thingy",
          sol::constructors<thingy()>(),
          "paint", &thingy::paint);

     sol::string_view code = R"(
          obj = thingy.new()
          obj:paint()
          obj.paint = function (self) print("g") end
          obj:paint()
          function obj:paint () print("s") end
          obj:paint()
     )";

     /// (!!!!) THIS PART HERE
     thingy* obj_from_lua = lua["obj"];
     obj_from_lua->paint();

     lua.safe_script(code);

     std::cout << std::endl;

     return 0;
}

Do you expect the C++ call after defining obj.paint() in Lua to also change? Or are you just talking about overriding the function in Lua only?

`
#define SOL_ALL_SAFETIES_ON 1
#include <sol/sol.hpp>
#include
int main() {
std::cout << "=== override-able member functions ===" << std::endl;
struct thingy {
    thingy(){
    }

    virtual void paint() {
        std::cout << "paint in cpp" << std::endl;
    }
};

sol::state lua;
lua.open_libraries(sol::lib::base);

lua.new_usertype<thingy>("thingy",
    sol::constructors<thingy()>(),
    "paint", &thingy::paint);

sol::string_view code = R"(
obj = thingy.new()
obj:paint()
obj.paint = function (self) print("paint in lua") end
obj:paint()
function obj:paint () print("paint in lua2") end
obj:paint()
)";

lua.safe_script(code);

std::cout << std::endl;

return 0;

}
`
output:
=== override-able member functions ===
paint in cpp
paint in cpp
paint in cpp
I want:
=== override-able member functions ===
paint in cpp
paint in lua
paint in lua2

I... feel like this might already work, or at least it should...?
Not sure, time to find out.

Related to #583 ?

Yes, I have seen the solution provided. It does not meet my needs. Using sol::function paint is intrusive. Because I use the code generation method. I don't want to modify the original implementation of the class.

I... feel like this might already work, or at least it should...?
Not sure, time to find out.

up

You can do that without modifying  the original implementation of the class.
You "just" need to bind with sol wrapped class that inherit from your component and override the virtual method to defer to a sol function or the original implementation

您可以在不修改类的原始实现的情况下做到这一点。 您“只需要”绑定从组件继承的 sol 包装类并覆盖虚拟方法以遵循 sol 函数或使用模板的原始实现
 template <class T> class LuaComponentBase : public T
  {
  public:
    template <typename ...Args>
    LuaComponentBase(sol::this_state ts, Args &&...args)
      : T(std::forward<Args>(args)...)
    {
}
}

Thank you very much, you reminded me. The problem has been solved.
In the process of generating bind, generate the corresponding sol::function to bind. No need to modify the original class.


incorrect visualization PSU results

Those measures are "AVG" and a stacked Barchart doesn't work correctly.

I propose a LinePlot that shows evolution of PSU Scores between Men/Women in Language/Math topics

closed via #604


FIXED: When RaftServer cannot find a leader, Return a more readable erro...

...r.
Before:
curl -F "file=1234" "http://<IP_ADDRESS>:9333/submit"
{"error":"Post http:///dir/assign: http: no Host in request URL"}
After:
curl -F "file=1234" "http://<IP_ADDRESS>:9333/submit"
{"error":"Raft Server not initialized!"}

A more readable error message can be used to help developers find what is the real problem.


Edge labels [on] and Force Labels [on  - after assignment]

This turn edge_label on as default.
It also switches to show_forces on after assignment of forces is made.
This way user can know the edges in which they intend to apply forces.

This relates with issue #80

already done


Fix main window title translation.

Title for the main window was set directly using DisplayServer.
Window object title property was never set, and an empty string was used when localization is changed.

Do we need to do it both in main.cpp and scene_tree.cpp, or could the main.cpp one be removed?

Do we need to do it both in main.cpp and scene_tree.cpp, or could the main.cpp one be removed?

Yes, the actual window is created before it's linked to Window object.
Modified it a bit, to translate %s (DEBUG) prefix and title text independently.

Do we really need to translate the  (DEBUG) part though?

Do we really need to translate the (DEBUG) part though?

Maybe not, we should not translate title (DEBUG) and title as a different string, but I guess (DEBUG) part could stay untranslated.

Thanks!


Error<EMAIL_ADDRESS>install: node-gyp rebuild

5255 verbose stack Error<EMAIL_ADDRESS>install: `node-gyp rebuild`
5255 verbose stack Exit status 1
5255 verbose stack     at EventEmitter.<anonymous> (/opt/elasticbeanstalk/node-install/node-v4.2.3-linux-x64/lib/node_modules/npm/lib/utils/lifecycle.js:214:16)
5255 verbose stack     at emitTwo (events.js:87:13)
5255 verbose stack     at EventEmitter.emit (events.js:172:7)
5255 verbose stack     at ChildProcess.<anonymous> (/opt/elasticbeanstalk/node-install/node-v4.2.3-linux-x64/lib/node_modules/npm/lib/utils/spawn.js:24:14)
5255 verbose stack     at emitTwo (events.js:87:13)
5255 verbose stack     at ChildProcess.emit (events.js:172:7)
5255 verbose stack     at maybeClose (internal/child_process.js:818:16)
5255 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
5256 verbose pkgid<EMAIL_ADDRESS>5257 verbose cwd /tmp/deployment/application
5258 error Linux 4.1.13-18.26.amzn1.x86_64
5259 error argv "/opt/elasticbeanstalk/node-install/node-v4.2.3-linux-x64/bin/node" "/opt/elasticbeanstalk/node-install/node-v4.2.3-linux-x64/bin/npm" "--production" "install"
5260 error node v4.2.3
5261 error npm  v2.14.7
5262 error code ELIFECYCLE
5263 error<EMAIL_ADDRESS>install: `node-gyp rebuild`
5263 error Exit status 1
5264 error Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
5264 error This is most likely a problem with the hiredis package,
5264 error not with npm itself.
5264 error Tell the author that this fails on your system:
5264 error     node-gyp rebuild
5264 error You can get their info via:
5264 error     npm owner ls hiredis
5264 error There is likely additional logging output above.
5265 verbose exit [ 1, true ]

Please upgrade to the latest hiredis release on npm: v0.5.0


Fix/v0.2.2 oban pro configuration

Contributor checklist

[X] Features include unit/acceptance tests

🚀 Thank you for your contribution! 🚀


ACF not displaying in GraphQL

I have been trying to display my ACF fields on GraphQL but I have had no luck with it.
I do have installed the ACF to REST plugin, and I added this code to functions.php
add_filter( 'acf/format_value', function ( $value ) {
if ( $value instanceof WP_Post ) {
return [
'post_type' => $value->post_type,
'id'        => $value->ID,
];
}
return $value;
}, 100 );
I have been trying to modificate the code, and testing with different post types, but I am not able to solve this.

Which version of the source plugin are you using? And can you check if the posts have the acf property in your Rest API results?

@hjvedvik
"@gridsome/source-wordpress": "^0.1.0",
"gridsome": "^0.4.0"
and yes, it does show up one the REST API url: http://localhost/wp-json/wp/v2/pages

ACF was adden in 0.2. It should work if you update the source plugin :)

That did it, thank you!

Could you show your query to get ACF field, please?


The PropertyFieldPeoplePicker Control is not Reactive

Whenever I add or remove any value in PropertyFieldPeoplePicker, it doesn't reflect the new value on the page. I have to refresh the page to see it. This is only happening when I test the web part on SharePoint environment but it works in localhost environment.

Hi @SurinderTaneja, this happens when you are using the last version of the SPFx package (for example version 1.1.1 of sp-webpart-base). The sp-client-custom-fields will be fix soon to support these packages version. Stay tuned.
Regards,
Olivier

Hi @SurinderTaneja,
the problem has been fixed with the version 1.3.5 of the sp-client-custom-field library, now available on github at http://github.com/OlivierCC/sp-client-custom-fields. But be careful, this version changes the custom field declaration. I will republish a new version of the web parts with support of this very soon.
Regards,
Olivier

Thanks @OlivierCC for your quick response on this. I installed the 1.3.5 version of the sp-client-custom-field library and able to successfully build the solution by adding render:this.render.bind(this) but it still doesn't work with 1.1.1 version of sp-webpart-base. I am currently using the latest version of node(5.0.3) and it shows the below error when I try to enter the name in peoplepicker control.
Exception in CommandButton.render(): TypeError: Cannot read property 'palette' of undefined.
Regards.
Surinder

Hi @SurinderTaneja. Very strange error, i'm not able to reproduce it in my SharePoint sites. This error could come from Office UI Fabric.
Some questions to try to identify the issue:

What is the kind of your tenant : Dev (MSDN like), First release or normal release ?
What is the kind of page where the error happens: Workbench (../_layouts/15/workbench), modern page in modern site or classical page in classical site ? Or  every 3 ?
Can you send me the total stack trace of this exception in your browser ?

Thanks, regards,
Olivier


Upgrade Dependencies

This issue is mainly to track dependencies that needs updating as of opening the issue.

[x] knex@latest from 0.95.4
[x] objection@3 from 2.2.14
[x] supertokens-node@8 from 7.0.0
[x] eslint and associated plugins
[x]<EMAIL_ADDRESS>from 4.3.5
[x] Docker Image node:14-alpine to node:16-alpine
[ ] graphql@16 from 15.7.2
[ ] graphql-subscriptions@2 from 1.2.1
[ ] graphql-codegen and associated plugins
[ ] Migrate from subscriptions-transport-ws to graphql-ws?

Tried updating graphql-codegen but encountered the same issue as this. Turns out there's a deeper issue.
Relevant links:
#232 and #240 from apollographql/graphql-subscriptions
Might consider using patch-package for this issue.

Tried migrating to graphql-ws and this unfortunately breaks the GraphQL Playground as it's using a different protocol spec.
Relevant links:

https://github.com/graphql/graphql-playground/issues/1291
https://www.apollographql.com/docs/apollo-server/data/subscriptions/#the-graphql-ws-transport-library
https://github.com/enisdenjo/graphql-ws#ws-backwards-compat


feat(rendering): Add OrthographicCamera component

Description
Added OrthographicCamera component to update the Camera with a orthographic projetion.
One thing I'm not sure if its the best approach is the size parameter added, I put it as a multiplier to the viewport the camera is drawing to. Would it be better to leave it like that or change it to be values to represent the plane size, something like a vec2{800, 600}?
Checklist

[x] Self-review changes.
[x] Update render main sample.
[x] Add entry to the changelog's unreleased section.

One thing I'm not sure if its the best approach is the size parameter added, I put it as a multiplier to the viewport the camera is drawing to. Would it be better to leave it like that or change it to be values to represent the plane size, something like a vec2{800, 600}?

With the multiplier approach, does the visible area become smaller/larger depending on the viewport size? It doesn't seem right that different players see more or less of the game world just because their display resolution is different, atleast not by default. There is a lot of variance in display resolution/size combinations, ranging from things like 800x600 (usually windowed) all the way to 4K/8K, and small laptop displays to large TVs, which could result in very different experiences.

One thing I'm not sure if its the best approach is the size parameter added, I put it as a multiplier to the viewport the camera is drawing to. Would it be better to leave it like that or change it to be values to represent the plane size, something like a vec2{800, 600}?

With the multiplier approach, does the visible area become smaller/larger depending on the viewport size? It doesn't seem right that different players see more or less of the game world just because their display resolution is different, atleast not by default. There is a lot of variance in display resolution/size combinations, ranging from things like 800x600 (usually windowed) all the way to 4K/8K, and small laptop displays to large TVs, which could result in very different experiences.

Ok yes true, wasn't thinking in that way, my mistake I will change and commit with the other approach.

One thing I'm not sure if its the best approach is the size parameter added, I put it as a multiplier to the viewport the camera is drawing to. Would it be better to leave it like that or change it to be values to represent the plane size, something like a vec2{800, 600}?

With the multiplier approach, does the visible area become smaller/larger depending on the viewport size? It doesn't seem right that different players see more or less of the game world just because their display resolution is different, atleast not by default. There is a lot of variance in display resolution/size combinations, ranging from things like 800x600 (usually windowed) all the way to 4K/8K, and small laptop displays to large TVs, which could result in very different experiences.

Ok yes true, wasn't thinking in that way, my mistake I will change and commit with the other approach.

I guess we have four options here:
a) User specifies the final ortographic projection size - we simply don't take into account the target and viewport in the projection matrix math; leads to stretching but the user might want this in some cases I guess? I'm not sure
b) Multiply user specified size by the target*viewport size (what you have right now); AR is correct among all possible viewport configs, but users will be able to see a larger region of the world (in all directions) when rendering at higher resolutions.
c) User specifies the width of the projection matrix, and the height is calculated by multiplying the width by the aspect ratio of the target+viewport. AR is also correct on all possible configs, but users with higher display resolutions won't be able to view more of the world. Instead, users with weird aspect ratios might get to see more or less than what they should, but only in the vertical direction.
d) Same as above, but user specifies the height of the projection matrix instead of the width. I think this is more fitting than c), as in the previous options, users with extra wide displays would have their 'vertical view' very reduced. By specifying the height, we get the opposite. Users with extra wide displays get a larger 'horizontal view' but the 'vertical view' remains constant.
In my opinion, options c) and d) are the most useful, and we should probably allow the user to opt between them.
Maybe keep a float size; + an enum specifying which axis is being specified.

In my opinion, options c) and d) are the most useful, and we should probably allow the user to opt between them.
Maybe keep a float size; + an enum or boolean specifying which axis is being specified. What do you think?

Looks good. I think the perspective camera basically follows d)? Alternatively we could have a) and let a separate plugin manage the size, but that might be adding unneeded complexity.

In my opinion, options c) and d) are the most useful, and we should probably allow the user to opt between them.
Maybe keep a float size; + an enum or boolean specifying which axis is being specified. What do you think?

Yes seems good, I was already making the d) option but I will add the enum to also allow for c) then.

Just noticed this, don't use uppercase in the first letter of the commit messages; it should be: feat(scope): hey, not feat(scope): Hey

Added my last two comments, after resolving my comments it should be good to go. Don't forget to remove the _camera suffix from the files!

ok I think should all be fixed sorry for the small mistakes

Added my last two comments, after resolving my comments it should be good to go. Don't forget to remove the _camera suffix from the files!

ok I think all should be fixed sorry for the small mistakes

Dw about it, sorry for being so picky!


ImportError: No module named django.core.management

hello,
I followed your instructions creating a virtualenv and then creating a new directory and cd'ing into that directory and running yo django and it installed everything or so it seems.
I specified no repo and said I wanted django v1.7 to be installed. But when I try to run python manage.py runserver <IP_ADDRESS>:9000 I get ImportError: No module named django.core.management. . Not sure what's missing here...no errors are indicated during the running of yo django.

So, this doesn't in fact install django for you? And when you're asking which version to use, it's not to tell you which version we want you to install?....

You need to install the packages, with pip, after running the generator.

When I try to install the packes
Collecting django.core.management
  Could not find any downloads that satisfy the requirement django.core.management
  No distributions at all found for django.core.management```

@jackygrahamez django.core.management isn't a Python package! Try pip install django or install from the project requirements with pip install -r requirements/DEVELOPMENT.


Fix doubly-namespaced classes on database:reverse command

Fixes #1233, Replaces #1234

Thanks for the contribution! I read through the https://github.com/propelorm/Propel2/commit/12cc008196a2f49aee25281bd3562151cb6ae008 commit which brought in the change. I guess the fix is not to fix XmlDumper but the actual internal model representation. Meaning, that the Reverse class/ReverseManager should not place the --namespace in Table::namespace. However, I'm currently not sure why Table::namespace is set, since it actually only sets the Database::namespace.

Rebasable and passes on recent CI.
Conflicts with design goals of https://github.com/propelorm/Propel2/pull/1241

Is there any reason to have the .../Model/ prefix?
Also:
package="Acme.Blog" namespace="Blog"

Why do we need the namespace at all, if the package seems to contain it. Or can those be separate?

Replacement https://github.com/propelorm/Propel2/pull/1729


Update sbt-microsites to 1.3.0

Updates com.47deg:sbt-microsites from 1.2.1 to 1.3.0.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.47deg", artifactId = "sbt-microsites" } ]

labels: sbt-plugin-update, semver-minor

Codecov Report

Merging #1624 (e128216) into master (bd9a11b) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1624      +/-   ##
==========================================
+ Coverage   85.27%   85.36%   +0.08%
==========================================
  Files          58       58
  Lines        2227     2220       -7
  Branches      103      103
==========================================
- Hits         1899     1895       -4
+ Misses        328      325       -3

Impacted Files
Coverage Δ

...core/shared/src/main/scala/io/circe/CursorOp.scala
51.72% <0.00%> (-1.41%)
:arrow_down:

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
85.38% <0.00%> (-0.59%)
:arrow_down:

...es/core/shared/src/main/scala/io/circe/Error.scala
62.06% <0.00%> (-0.44%)
:arrow_down:

.../core/shared/src/main/scala/io/circe/Decoder.scala
85.33% <0.00%> (-0.04%)
:arrow_down:

...les/core/shared/src/main/scala/io/circe/Json.scala
81.00% <0.00%> (ø)

...re/shared/src/main/scala/io/circe/JsonNumber.scala
96.38% <0.00%> (ø)

...rc/main/scala/io/circe/shapes/SizedInstances.scala
92.85% <0.00%> (+14.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd9a11b...e128216. Read the comment docs.


1.14 bpf ct cleanups

Some innocent cleanups from diving into the CT code recently.

/test

ci-gingko fail is https://github.com/cilium/cilium/issues/25964


fix: ResponseInterface (2)

Needs to rebase after merging #6556
Description
Ref #4356
Now the framework depends on ResponseInterface, not Response.
Add

Response::getCSP()
ResponseInterface::getCSP()
ResponseInterface::getReasonPhrase()
ResponseInterface::getCookieStore()

Change API

API\ResponseTrait::failServerError()
Services::exceptions()
Debug\Exceptions::__construct()

Deprecate

Response::$CSP.  It is now public, but should be protected.

Checklist:

[x] Securely signed commits
[x] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

Awaiting rebase for this one.

I didn't think of 4.3 strictly as Validation only.
If you don't want to include any more interface changes in 4.3, this PR can be moved to 4.4.

I really want to fix Request as well, but it looks like it will require even bigger changes.
See #6573

Well when we originally talked about that I thought 4.3 would be out by now. I've been holding for @sclubricants's awesome database features, but maybe we should do 4.2.7 and 4.3 now and then spin up 4.4 for the database features and Request changes. Nothing wrong with having two minor releases close to each other. Thoughts from either of you?

4.2.7 is ready.
Speaking of 4.3,  #6536 is almost complete and all that remains is the documentation.
But @sclubricants's work continues. Can't wait for all.
So we may as well release 4.3 now.

Once we get https://github.com/codeigniter4/CodeIgniter4/pull/6536 merged then It should take long to add the upsert feature. The code is already written. Once the refactor is complete is should be as simple as adding the upsert methods. I have plans to add more features but those can wait for a later release. It would be nice to get the upsert feature into 4.3. At least if developers have to go through the pain of all the changes that have taken place it would be nice for them to have a new feature to work with.
Also, if we can get https://github.com/codeigniter4/CodeIgniter4/pull/6552 merged then I'd like to add the final piece of the Forge changes which is a method processIndexes(). This will allow creating indexes after table creation. All the code is written for this as well.
If we focus on getting these changes merged I would think we could have them completed in a week or two.  Not that we need to rush things but most of the breaking changes have already been made so the rest should go quicker.
I updated https://github.com/codeigniter4/CodeIgniter4/pull/6536 so hopefully it is ready to merge now and I can get the upsert PR submitted.

Thanks for the updates @sclubricants! I'm mostly just reading comments on these and letting the database team handle reviews but let me know if I can help more. Let's aim for 4.3 this coming weekend and if it looks like some of your desired merges  need a little more time then I am fine holding. I also am really fine with 4.4 coming right on the heels of 4.3, through.


Removed suspicious/ambiguous API factory methods

Fixes #2003

Codecov Report

Merging #2024 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2024      +/-   ##
============================================
- Coverage     97.62%   97.62%   -0.01%
+ Complexity     5168     5163       -5
============================================
  Files            91       91
  Lines         11835    11830       -5
  Branches       1568     1568
============================================
- Hits          11554    11549       -5
  Misses          134      134
  Partials        147      147

Impacted Files
Coverage Δ
Complexity Δ

vavr/src-gen/main/java/io/vavr/API.java
92.79% <ø> (+0.11%)
193 <0> (-4)
:arrow_down:

vavr/src/main/java/io/vavr/collection/TreeMap.java
97.4% <0%> (-0.44%)
151% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4558730...5225fe2. Read the comment docs.


JENKINS-30010: Multiple conditions support for flexible-publish

JENKINS-30010: Multiple conditions support for flexible-publish

I want to stick to the pattern that one call to a method in a PublisherContext creates one node. I replace this by #702.


Can't find target attribute [mode]

Hello,
since the upgrade 21.1.4 I'm unable to import data from CSV to DB (postgres).
Error message : Can't find target attribute [mode]
Everything works just find before the upgrade.
I have a column named : mode in the table and in the import file.
If I have a look to the mapping I have the Source Column named : mode
but the Target Column named : "mode"
It's impossible to rewrite the Target Column : mode
Any ideas ?

@mikaelmockel it will be very helpful if you can provide some sample csv file to reproduce an issue.
Is this problem actual for all the csv files or just for some special?
is there something in the logs?

The logs says : Can't find target attribute [mode]
Here are the screen captures :

I downgraded to 21.1.3 and it works just find.
In your changelog for 21.1.4 version I see some changes that can be the problem :

Data transfer:
- Table/column name case conversion was fixed
- Ambiguous column name mapping was fixed
PostgreSQL:
- Column rename DDL was fixed

Hello,
we have the same problem.
I exported a table to a csv file. That worked fine. When I imported it to the same empty table then I get ‚Can’t find target attribute [version]’. One column of this table is called ‘vesion’.

Thank you
Michael

Reporting in to mention this is not limited to PostgreSQL, it doesn't work with MySQL either. It does work with SQLite. This is not an issue in version 21.1.3.
Table structure MySQL (MySQL 8.0.26-0ubuntu<IP_ADDRESS>):

Table structure PostgreSQL (PostgreSQL 13.3 (Ubuntu 13.3-1.pgdg20.04+1):

Sample data:
date,recipient,category,sum,description,transaction_id
2021-08-01,test,test,1,test,6863F2D476F3EB11A2D3001DD8B71C03

Same for sql server

Yes,we have the same problem with  message "Cannot find target attribute [Index]" when try to import data table to either current database or annother database.
According to mikaelmockel's reply ,i downgrade it to 21.1.3 and it works well . Thank you for your solution ,@mikaelmockel。

I downgraded to 21.1.3 and it works just find.
In your changelog for 21.1.4 version I see some changes that can be the problem :

Data transfer:

Table/column name case conversion was fixed
Ambiguous column name mapping was fixed

PostgreSQL:

Column rename DDL was fixed

Yes,we have the same problem with message "Cannot find target attribute [Index]" when try to import data table to either current database or annother database.
According to mikaelmockel's reply ,i downgrade it to 21.1.3 and it works well . Thank you for your solution ,@mikaelmockel。

I downgraded to 21.1.3 and it works just find.
In your changelog for 21.1.4 version I see some changes that can be the problem :

Data transfer:

Table/column name case conversion was fixed
Ambiguous column name mapping was fixed

PostgreSQL:

Column rename DDL was fixed

Same for me. Version 21.1.3 working flawless. Thanks @mikaelmockel

Yes,we have the same problem with message "Cannot find target attribute [Index]" when try to import data table to either current database or annother database.
According to mikaelmockel's reply ,i downgrade it to 21.1.3 and it works well . Thank you for your solution ,@mikaelmockel。

I downgraded to 21.1.3 and it works just find.
In your changelog for 21.1.4 version I see some changes that can be the problem :

Data transfer:

Table/column name case conversion was fixed
Ambiguous column name mapping was fixed

PostgreSQL:

Column rename DDL was fixed

Same for me. Version 21.1.3 working flawless. Thanks @mikaelmockel

But it sometimes get blocked and keeps waiting for data transform when executing datatable table import task ,even the table has just a few raws .

Can be related to #13453

Seems to be fixed in https://github.com/dbeaver/dbeaver/issues/13542

Verified

Hi,
the issue is still present in the new 21.1.5 version of dbeaver.
Do not close the issue.

Hi @mikaelmockel
Issue fixed but will be available only in release 21.2.0 on 2021-08-30 here
or earlier here

Here are some screenshoots and the DDL of the table:
DDL:
CREATE TABLE XXX.dbo.Lista_contactos_eliminar_revisados_XXX (
eliminar varchar(12) COLLATE Modern_Spanish_CI_AS NULL,
[Nombre empresa] varchar(75) COLLATE Modern_Spanish_CI_AS NULL,
Nº varchar(30) COLLATE Modern_Spanish_CI_AS NULL,
Nombre varchar(75) COLLATE Modern_Spanish_CI_AS NULL
);
Columns mapped:

Error:

Thanks @TsunamiHandia
The issue was resolved. You can test it in our earlier version here


in-flight requests don't get dropped when the connection closes

If the client closes the connection, the server correctly detects that the read-half was closed but continues waiting for the response of all requests even though the write-half might already be gone as well.
This is the use-case were this is a problem(is that out of scope for this crate?):

you start a request like run_service without a timeout(currently, a very long timeout since it's not optional yet)
the request handler starts that service and waits until it's completion which is basically forever unless explicitly stopped from the server side
when the client gets stopped, the connection gets closed, the server should see that and drop the future of the request handler (which would stop the service)

Right now, the request handler waits for tarpc to drop the future after the connection closed while tarpc waits for the request handler to finish before doing so.
This is the responsible piece of code: https://github.com/google/tarpc/blob/v0.24.1/tarpc/src/rpc/server.rs#L460
I'm not yet sure ho to handle that correctly with the current logic, That's why I'm creating this issue instead of a PR which would change that behavior.

This is pretty interesting! I'm not sure I would recommend starting a running service bound to the lifetime of a request. I don't see a problem using a request to kick off the startup of a service, but what about instead binding the service to the lifetime of the client connection?

This is pretty interesting! I'm not sure I would recommend starting a running service bound to the lifetime of a request. I don't see a problem using a request to kick off the startup of a service, but what about instead binding the service to the lifetime of the client connection?

I do think that when a client connection is shut down, the tarp server could go clean up any lingering requests.

I do think that when a client connection is shut down, the tarp server could go clean up any lingering requests.

Ok, I just took a closer look, and this is actually a very simple fix! I should be able to have a fix in today.

Ok, I just took a closer look, and this is actually a very simple fix! I should be able to have a fix in today.

I just pushed a fix for this to the master branch; can you give it a whirl? If it works for you, I'll publish a new release fixing this (major increment, since it's technically a breaking change).

I just pushed a fix for this to the master branch; can you give it a whirl? If it works for you, I'll publish a new release fixing this (major increment, since it's technically a breaking change).

Closing, but feel free to reopen if you have any problems.


Document the -f flag

The -f flag for dotenv was not previously documented in the README. But now it is!

Hi @bcobb, I'm taking over maintenance of dotenv with @cadwallion and @jonmagic and your PR is on our radar. Thank you for taking the time to update the documentation! 😄  Would you still like to see this merged in?


completor.vim:227 line have bug

Press o/O key auto jump to first line if I open more buffer > 1 in vim
I use vim 9.0 and macvim 9.1 all have this question
" completor.vim
226   endif
227   all <--
228   if line == prevCompletionInput

Thanks, some typo got snuck in. Sorry about that.


Adding FSharpLint.Build

Work in progress part of #4
Added FSharpLint.Build v0.4.4 to Domain project
Having some issue with FSharpLint.Build on my machine so want to how it behaves on Appveyor

Not merging this one due to the invalid tag as I am not sure what it means. Pls let me know @HenrikRxn

As the initial PR statement says this is work in progress to see how it behaves on the build server.
Furthermore the fact that I haven't assigned a reviewer should strongly indicate that it should not be considered for merging.
I would suggest adding a WIP tag to the project that can be used to signify that a PR is still being worked on and is not ready for merging yet. There are a number of reasons why this could be useful, e.g. to share an early design to get feedback.

Closing for now as I have opened issue at FSharpLint repository

Understood, we can adopt that convention. Thanks Henrik.
On Aug 1, 2016 2:19 PM, "Henrik Røn"<EMAIL_ADDRESS>wrote:

As the initial PR statement says this is work in progress to see how it
behaves on the build server.
Furthermore the fact that I haven't assigned a reviewer should strongly
indicate that it should not be considered for merging.
I would suggest adding a WIP tag to the project that can be used to
signify that a PR is still being worked on and is not ready for merging
yet. There are a number of reasons why this could be useful, e.g. to share
an early design to get feedback.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/parthopdas/tddstud10/pull/28#issuecomment-236486064,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACCpLOgjFTDA3EJjHlvJnWzDaXUpUnHFks5qbXOzgaJpZM4JZBKq
.

Hi Partho
Reading my own comment in your reply made me realise it sounded a bit harsh
and it was not my intention. Hope you took no offence
Regards, Henrik
On 1 Aug 2016 7:16 a.m., "Partho P. Das"<EMAIL_ADDRESS>wrote:

Understood, we can adopt that convention. Thanks Henrik.
On Aug 1, 2016 2:19 PM, "Henrik Røn"<EMAIL_ADDRESS>wrote:

As the initial PR statement says this is work in progress to see how it
behaves on the build server.
Furthermore the fact that I haven't assigned a reviewer should strongly
indicate that it should not be considered for merging.
I would suggest adding a WIP tag to the project that can be used to
signify that a PR is still being worked on and is not ready for merging
yet. There are a number of reasons why this could be useful, e.g. to
share
an early design to get feedback.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/parthopdas/tddstud10/pull/28#issuecomment-236486064
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ACCpLOgjFTDA3EJjHlvJnWzDaXUpUnHFks5qbXOzgaJpZM4JZBKq
.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/parthopdas/tddstud10/pull/28#issuecomment-236491424,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATunn2cNcqjos5rtoH-mrW47wZtKiuQgks5qbYE-gaJpZM4JZBKq
.

None taken, don't worry about it. :) I'll add the WIP tag shortly.
On Aug 1, 2016 3:43 PM, "Henrik Røn"<EMAIL_ADDRESS>wrote:

Hi Partho
Reading my own comment in your reply made me realise it sounded a bit harsh
and it was not my intention. Hope you took no offence
Regards, Henrik
On 1 Aug 2016 7:16 a.m., "Partho P. Das"<EMAIL_ADDRESS>wrote:

Understood, we can adopt that convention. Thanks Henrik.
On Aug 1, 2016 2:19 PM, "Henrik Røn"<EMAIL_ADDRESS>wrote:

As the initial PR statement says this is work in progress to see how it
behaves on the build server.
Furthermore the fact that I haven't assigned a reviewer should strongly
indicate that it should not be considered for merging.
I would suggest adding a WIP tag to the project that can be used to
signify that a PR is still being worked on and is not ready for merging
yet. There are a number of reasons why this could be useful, e.g. to
share
an early design to get feedback.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/parthopdas/tddstud10/pull/28#issuecomment-236486064
,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/ACCpLOgjFTDA3EJjHlvJnWzDaXUpUnHFks5qbXOzgaJpZM4JZBKq

.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<https://github.com/parthopdas/tddstud10/pull/28#issuecomment-236491424
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ATunn2cNcqjos5rtoH-mrW47wZtKiuQgks5qbYE-gaJpZM4JZBKq
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/parthopdas/tddstud10/pull/28#issuecomment-236494145,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACCpLMrTMwHdWAKheEnNuDn2O1Yf5XzEks5qbYeTgaJpZM4JZBKq
.


Simplify coverage_args.

Maybe fixes https://github.com/Homebrew/brew/pull/2641.

Great work here @reitermarkus 👏


reconfigured stale module

hopefully this works now?

@KaiFish it seems you've removed a little too much code I think in that latest commit! We still need the config object being made and passed in, but we need it to feed from environment variables rather than being given by calling await context.config();. Does that make sense?

@BlueHatbRit what environment variables do you want to pass in? Since we're rewriting Stale here, we might as well just grab them in stale.js rather than doing the whole parameter-passing-dance

yeah, if you look in stale.js, we put all the environment stuff that was in the defaults.js file in there


Enhance Makefile for cross-platform compatibility

Updated the Makefile to detect the operating system and set the shell accordingly (PowerShell for Windows, Bash for others).
Modified installation commands to create necessary directories and files in a platform-agnostic manner.
Adjusted commands for running tests and linting to ensure compatibility with both Windows and Unix-like systems.
Implemented conditional logic for cleaning up files and directories based on the operating system.

This commit improves the usability of the project on Windows environments, ensuring that setup and testing processes work seamlessly across different platforms.

This change is

Great call.
This refactoring addresses maintainability concerns by:

Defining OS-specific command variables at the top (SHELL_PREFIX, MKDIR, TOUCH, etc.)
Consolidating repeated commands into variables (PYTEST_COMMON_ARGS)
Using proper PowerShell commands with full path escaping
Making file operations OS-agnostic via DIR_SEP variable
Adding directory existence checks for robustness

@aaron-siegel I added additional logic to use .make-install folder if it already exists otherwise create directory:
	@powershell -Command "if (-not (Test-Path '.make-install')) { New-Item -ItemType Directory -Path '.make-install' }"
else
	@if [ ! -d ".make-install" ]; then $(MKDIR) .make-install; fi

The reason I didn't think we should use PYTEST_COMMON_ARGS := -v -n auto --dist loadgroup --maxprocesses 6 tests is meant for tag specific markers. For example it could skip tests that are marked as slow or expensive
Where as the make command below will run tests on ALL tests (no marker filtering)
fullpytest: install
	@echo "Running pytest, including expensive tests ..."
	@$(ULIMIT_CMD) pytest -v -m '' -n auto --dist loadgroup --maxprocesses 6 tests


Add Timeline Page to Display Key Events and Milestones

fix: #219
This PR adds a "Timeline" page, presenting a chronological view of key events, milestones, and upcoming activities. The page is designed to give users a clear overview of important dates, deadlines, and event progress, enhancing visibility and helping users stay informed about the application's development and community initiatives.

Hey @rishicds please add levels to the PR

hey @rishicds please add labels


Use offsetof for flexible struct allocation

We are doing allocation of structs with flexible array members wrong. It should be:
palloc( offsetof(MyStruct, last_member) + num_items * sizeof(ArrayMember) );

See https://github.com/postgres/postgres/blob/master/src/include/c.h#L342-L350.
The reason is that padding may give a different array start location compared to sizeof.
typedef struct MyStruct {
    double x;
    char y;
    int z[];
} MyStruct;

int main(void) {
    printf("sizeof: %lu\n", sizeof(MyStruct));
    printf("offsetof: %lu\n", offsetof(MyStruct, z));
}

The above prints:
sizeof: 16
offsetof: 12

It doesn't look to me that we have a problem: sizeof(MyStruct) is always greater or equal than offsetof(MyStruct, z), so, in the worst case, we just waste the padding bytes.

You're right. For a moment I saw it the other way around. Nevertheless, it's a good small fix to have.


Unable to save changes in one edited cell

Double click on cell and edit contents. Then Save (Ctrl+S) button is active and you can save the change.

One click on cell and Ctrl+V data into it. Save (Ctrl+S) button is inactive. So you cannot save the change when it was made by pasting.

Thanks for report. Fix will be in the next version.
Workaround: use "Save" button in the results bottom toolbar.


Add license file

Please, add an explicit LICENSE file to the repo that states the license of this project.
I see composer.json has a "license": "ISC" declaration, but please confirm it in a LICENSE file too.

Added. Out of interest, are you planning to use this in some way or to contribute?

Thank you!
I am currently experimenting with adding PHP support in Eclipse Che. Che is integrating the language server protocol - still a work in progress. So, I am looking at the available PHP language servers and try to make them working with Che.
So far, I played with the https://github.com/HvyIndustries/crane
My next step is to look at your project. I believe that having a PHP language server implemented in PHP is the most sustainable solution for the long term. It has the highest potential for attracting the PHP community for contributing. And it can take advantage of the plenty of PHP tools that are already available.
It's great you have already done the heavy lifting of implementing the server-side of the low-level protocol.

Enabling other IDEs to use this is the exact reason why I did the server as a separate package on Packagist, and not inside the vscode extension.
I also looked at crane-php, but it is implementing its own PHP Parser in TypeScript, even though there is already a very great PHP Parser out there that is well-tested.
Currently I only implemented all the classes for the requests and the parsing/method dispatching in the advanced-json-rpc package. The initialize request is already handled called correctly. From here, I want to implement one request after another, and I would love contributions. I would be open to adding you as a maintainer.

Good progress so far. Perhaps, one thing we will try looking at in the next days is adding code validation using the same PHP parser.

That should be relatively simple: https://github.com/felixfbecker/php-language-server/blob/master/src/TextDocumentManager.php#L80-L83
I wanted to first implement documentSymbols, because I figured it would be the most simple if you have an AST. The biggest challenge will be provideCompletion of course (I definitely do not want to restrict it to the open file like crane, but follow autoloading standards).

Also, I pursue full test coverage (afaik crane doesn't have any tests)


Fixed Prototype pollution in simple-deep-assign

📊 Metadata *
Fixed Prototype pollution in simple-deep-assign.
Bounty URL: https://www.huntr.dev/bounties/1-npm-simple-deep-assign
⚙ Description *
simple-deep-assign is vulnerable to Prototype Pollution.
💻 Technical Description *
The package is vulnerable to Prototype pollution in the deepAssgin function. This vulnerability is fixed by filtering the keywords that causes pollution from the object.
🐛 Proof of Concept (PoC) *
// poc.mjs
import deepAssign from 'simple-deep-assign';

console.log('Before: ', {}.polluted})
deepAssign({}, JSON.parse('{"__proto__": {"polluted": "Prototype Polluted"}}'));
console.log('After: ', {}.polluted})

Before: undefined
After: Prototype Polluted

🔥 Proof of Fix (PoF) *
After fix:

👍 User Acceptance Testing (UAT)
All ok.
🔗 Relates to...
Provide the URL of the PR for the disclosure that this fix relates to.

Congratulations d3m0n-r00t - your fix has been selected! 🎉
Thanks for being part of the community & helping secure the world's open source code.
If you have any questions, please respond in the comments section, or hit us up on Discord. Your bounty is on its way - keep hunting!
Come join us on Discord

Congratulations d3m0n-r00t - your fix has been selected! 🎉
Thanks for being part of the community & helping secure the world's open source code.
If you have any questions, please respond in the comments section, or hit us up on Discord. Your bounty is on its way - keep hunting!
Come join us on Discord


Connect to Meetup API

Display upcoming event with Meetup API

If you need me to get a an api key for this let me know.  Recently Meetup has changed the way they do meetup stuff.


Eng 2998 masking

Description

Add docs for generic token masking
Document new reveal_last filter

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

[ ] Not Applicable

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.54.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Remove separator parameters

Since we are going for issue #10, separator variables are not necessary anymore.

Implemented on v<IP_ADDRESS>


Documentation for lower bound

Added ott.solvers.quadratic.lowerbound.LowerBoundSolver to the Gromov-Wasserstein Documentation.

@Daniel-Packer just a heads-up that @marcocuturi refactored the code #472 , so you might need to adjust the notebook a bit again.

thanks @Daniel-Packer , as Michal was mentioning I refactored the univariate solvers code (and Michal also had an extra pass)

Closing this, since the univariate solvers have been refactored again in #505


Update Pokémon Service to use Smithy IDL v2 (#2523)

Motivation and Context
Smithy IDL v2 has been released. The example Pokemon Service model should be updated to use v2.
Open issue 2523.
Description
Made appropriate changes to pokemon.smithy following the Smithy IDL v1 -> v2 migration guide.
The StreamingBlob was not marked as @required so I made it optional in the StreamPokemonRadioOutput.
Additional Changes:

Fix model link in Pokemon example make file.
Add *.iml files to .gitignore.

Testing
Manual test by running the example Pokemon Service
Checklist
N/A

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing this in favor of #3494.


Latest release doesn't load properly

Updating to latest release conflicted with the lang file: http://pastie.org/p/4ZHyQJ8o3OrsZDgSnJe3fl

hmm it says "404 Not Found"?! You should use anthoer paste website. Such as pastbin.


Improve authentication logging

Codecov Report

Merging #13313 (185d162) into master (46d5e18) will decrease coverage by 26.55%.
The diff coverage is 31.31%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96107da...185d162. Read the comment docs.

alluxio-bot, merge this please

alluxio-bot, merge this please

alluxio-bot, merge this please

alluxio-bot, merge this please


Returning a 302 from a page endpoint breaks client-side navigation to that endpoint

Describe the bug
I have a get handler like this. It works correctly when you go to / without following a link, but it breaks when following a link to / in the site header from the home page when logged in.
export const get: RequestHandler = async ({ params, locals }) => {
  if (locals.session) {
    return {
      status: 302,
      headers: {
        location: `/home`
      }
    }
  } else {
    return {
      status: 200
    }
  }
}

It seems to load the html when it is expecting the json, giving a 500 error page with "Unexpected token < in JSON at position 0"
Reproduction
Here I have made the get handler for /about redirect to /todos, but it doesn't work.
https://stackblitz.com/edit/sveltejs-kit-template-default-qvpqgw?file=src%2Froutes%2Fabout.js&terminal=dev
Not sure if it's exactly the same as my problem-- it seems to hang rather than show the error I'm getting locally
Logs
No logs are produced, just the error page.

500
Unexpected token < in JSON at position 0
SyntaxError: Unexpected token < in JSON at position 0

System Info
System:
    OS: macOS 12.2.1
    CPU: (10) x64 Apple M1 Pro
    Memory: 40.32 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.0 - ~/.nvm/versions/node/v16.13.0/bin/node
    Yarn: 1.22.17 - ~/.nvm/versions/node/v16.13.0/bin/yarn
    npm: 8.1.0 - ~/.nvm/versions/node/v16.13.0/bin/npm
  Browsers:
    Chrome: 99.0.4844.51
    Firefox: 97.0.2
    Safari: 15.3

Severity
serious, but I can work around it
Additional Information
No response

Ah, I think this is a bug in my understanding. I was thinking of endpoints primarily as SSR functions that happen to have a json form, when I should be thinking of then as json API functions that happen to also be called during SSR.
If I redirect to /home/__data.json instead, then it works for the client-side links, but the initial page loads break. I should probably put this logic in a load function instead.


Switch to I18n::Backend::Simple.new due to i18n-js compatibility

This will fix https://github.com/fnando/i18n-js/issues/344

#2537 solves this and is ready to go, but I'm not sure how to handle this version-wise.
If we remove this initializer we'll be dropping support for translating countries in all versions < 2.5. Maybe we need a major version bump, to make this solidus_i18n 2.0.

I've prepared a PR (#108) to remove this dependency if we go for the major version bump.
Alternatively we could leave the initializer and conditionally load that code only for some solidus version using this check?

Solved by #122 :tada:


testVerificationIfTwoMethodsOfExpressionOdeAreEquals

Verification that the two methods allowing us to express the ODEs return the same values.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

22 of 22 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 36.691%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
5252

Relevant Lines:
14314

💛  - Coveralls

I will wait until the test is green to commit this PR.


Upgrade Operator SDK version command

Feature Request
Describe the problem you need a feature to resolve.
In the projects I work, we sometimes upgrade Operator SDK versions. The way to do it is to follow the docs (https://sdk.operatorframework.io/docs/upgrading-sdk-version/) and apply changes for each version bump, right?
I was wondering if a command to do this automatically can be created?
Describe the solution you'd like.
One possible solution would be to annotate how that code user wants to upgrade was created.
Example of what I am doing with a helm based opeartor:
Create operator code in two temp folders. One using current Operator SDK version, and the other using the version I want to upgrade to
operator-sdk init --plugins=helm --domain=<OPERATOR_DOMAIN> --project-name=<OPERATOR_NAME>
operator-sdk create api --helm-chart=<CHARTS_FOLDER>
operator-sdk generate kustomize manifests -q --interactive=false

Then, I create a diff file between this two temp folders
diff -ruN <current_version_directory> <next_version_directory>

And finally apply the diff to my operator code, using patch command. This part can be enhanced, sometimes the command does not fully succeed.

@mateusoliveira43 Thanks for opening this issue, and mentioning this idea. Upgrading SDK projects can sometimes be tricky, especially with breaking changes. In order to help with the process, in Kubebuilder (upstream for SDK) there has some work being done on an alpha-generate command (https://kubebuilder.io/migration/migration_guide_gov3_to_gov4.html#your-upgrade-assistant-the-alpha-generate-command). The slight difference here though is that this command is intended to be used while bumping plugin versions rather than the version of the binary itself. Which seems reasonable, as most of the user facing changes can be expected with scaffolding changes.


Version solving failed in todos example

Getting this error on pubspec
Resolving dependencies... Because every version of electricsql_cli from path depends on electricsql from hosted and todos_electrified depends on electricsql from path, electricsql_cli from path is forbidden. So, because todos_electrified depends on electricsql_cli from path, version solving failed. exit code 1
Really excited to try electric btw. Thanks for building a dart client for it.

To run the example you need melos, so that the dependencies are picked correctly from the monorepo.
I'll update the README
You need to install melos
dart pub global activate melos
Then run melos bs at the root of the repository and then follow the TODOs example README
Make sure to try the example at a tagged commit, otherwise you may encounter unexpected issues.
`git clone --branch electricsql-0.2.1 <repo_url>


ValueError when using beet import

When trying to import a certain directory with beets i'm getting an error. Don't know what this is. I'm using Ubuntu Server 14.04.
Traceback (most recent call last):
  File "/usr/local/bin/beet", line 9, in <module>
    load_entry_point('beets==1.3.10', 'console_scripts', 'beet')()
  File "/usr/local/lib/python2.7/dist-packages/beets/ui/__init__.py", line 945, in main
    _raw_main(args)
  File "/usr/local/lib/python2.7/dist-packages/beets/ui/__init__.py", line 935, in _raw_main
    subcommand.func(lib, suboptions, subargs)
  File "/usr/local/lib/python2.7/dist-packages/beets/ui/commands.py", line 873, in import_func
    import_files(lib, paths, query)
  File "/usr/local/lib/python2.7/dist-packages/beets/ui/commands.py", line 845, in import_files
    session.run()
  File "/usr/local/lib/python2.7/dist-packages/beets/importer.py", line 305, in run
    pl.run_parallel(QUEUE_SIZE)
  File "/usr/local/lib/python2.7/dist-packages/beets/util/pipeline.py", line 345, in run
    self.coro.send(msg)
  File "/usr/local/lib/python2.7/dist-packages/beets/util/pipeline.py", line 158, in coro
    task = func(*(args + (task,)))
  File "/usr/local/lib/python2.7/dist-packages/beets/importer.py", line 1291, in manipulate_files
    session=session,
  File "/usr/local/lib/python2.7/dist-packages/beets/importer.py", line 635, in manipulate_files
    item.move(copy, link)
  File "/usr/local/lib/python2.7/dist-packages/beets/library.py", line 611, in move
    dest = self.destination(basedir=basedir)
  File "/usr/local/lib/python2.7/dist-packages/beets/library.py", line 653, in destination
    query, _ = parse_query_string(query, type(self))
  File "/usr/local/lib/python2.7/dist-packages/beets/library.py", line 1016, in parse_query_string
    parts = [p.decode('utf8') for p in shlex.split(s)]
  File "/usr/lib/python2.7/shlex.py", line 279, in split
    return list(lex)
  File "/usr/lib/python2.7/shlex.py", line 269, in next
    token = self.get_token()
  File "/usr/lib/python2.7/shlex.py", line 96, in get_token
    raw = self.read_token()
  File "/usr/lib/python2.7/shlex.py", line 172, in read_token
    raise ValueError, "No closing quotation"
ValueError: No closing quotation

Thanks for reporting; we need a better error message in any case. I believe this is an error in your path format config—can you paste that, please?

That's really fast! Thanks for helping me out. Here is it:

and
item_fields:     disc_unpadded: 1 if disc == 0 else str(disc)

Hmm, I commented out the first line of my path format and everything seems to work fine again.

Yes, you have an unbalanced " on that line.

Improved version:
>>> parse_query_string('mb_trackid::^$":', Album)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/bru/code/beets/beets/library.py", line 1075, in parse_query_string
    raise ValueError("Cannot parse {0!r} (error was: {1})".format(s, exc))
ValueError: Cannot parse 'mb_trackid::^$":' (error was: No closing quotation)

Being able to do raise ValueError("Cannot parse {0!r}".format(s)) from exc would be sooo cool :-)

Yeah, I'm certainly envious of chained expressions in Python 3.
What do you think about using InvalidQueryError so that the user gets a prettier, traceback-free error message?

I'm not sure about InvalidQueryError: it is currently quite low-level, belonging in beets.db.query.
Moreover the current formatting does not fit. Maybe there should be a more generic InvalidQueryError (residing in which module?, problem 1) that would be raised here, and then an InvalidQueryArgumentTypeError (that's a bit long for a name, problem 2) extending InvalidQueryError in beets.db.query.

Good points all. I think I lean toward your option 2, with a new subclass for parse_query_string-specific parse errors like this. A completely new exception would seem to be fine too.

Ok I'm working on it. What do you think of putting InvalidQueryError in beets.util? Moreover I have to tweak beets.dbcore.beets so the error raised by queries is enriched with the query itself.
I'm leaving for holidays, I'll wrap it up when in a week.

Hmm, I'd say no to locating it in beets.util since it doesn't fit with the standalone utilities there; dbcore seems like the right place for this.
Bon voyage! Thank you for looking into this!

Here it is! As you hinted the 2 exception classes are not directly related: InvalidQueryError wants the query, which InvalidQueryArgumentTypeError does not know.


Refactor: Allow the H2 codec to have both header and trailers

Currently we can only have either headers or trailers. With deferring processing, we could end up having both in the codec e.g. due to the stream being on a backed up connection.
Signed-off-by: Kevin Baichoo<EMAIL_ADDRESS>
Commit Message: Refactor to allow the H2 codec to have both header and trailers.
Additional Description:
Risk Level: low (refactor)
Testing: Ran tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Related Issue: #19127

/retest

Do we need to have space to latch 1xx_headers_ headers_ and trailers_? It looks like we might not handle all 3 with this impl.

Good catch, I think we're missing this in this PR. IIUC, we can get this if we get 1xx header that we don't send, then get the rest of the headers, then get trailers.

Also are we ever not sending headers on? AFIK the design doc I looked at was about delaying data, which is the bulk of what fills buffer. I think there's merit in delaying headers (both 1xx and !1xx) but you might want to just do data+trailers to start at which point I think this PR would not be needed yet?

I think we wanted to also capture the header case, but I'm fine deferring it.
I was originally thinking about implementing this in the following 3 phases:

Refactor to allow headers, trailers
Buffering of headers, trailers, body
Draining buffered data fairly

I'll try instead to do:

Buffering / Draining of data + trailers
This refactor (with support for 1xx headers)
Buffering / Draining headers

How does that sound?

IMO once you do "Buffering / Draining of data + trailers" I think we might even be able to deprioritize the other two as we'll have lower hanging fruit for reliability but yeah starting with that one and seeing where we go sounds good to me :-)


pushedAt is not reliable

Description
In the LibraryListItemColumnThree component, to calculate the "Updated at" field, to the getTimeSinceToday method the value props.library.github.stats.pushedAt gets passed.
But this field (provided by the GitHub API) is actually not "reliable": what I mean by that is that the field pushedAt is not the datetime of the last commit pushed to master - which to me should define when the repo has been updated.
To prove it I'll use the react-native-push-notification repo - if you check via native.directory (here) you can see that it says that it has been updated for the last time "2 weeks ago" because it uses

"pushed_at": "2017-06-30T17:58:21Z",

as datetime to use for the calculation.
But if you check instead the commit history it will say that the last commit to master was done on May 15th (2017-05-15T18:43:43Z) - which is way more than 2 weeks ago.
I can't actually figure out where the GitHub API gets that value for pushed_at, but yeah it's not the last commit to master.
Proposed solution
While searching around, I managed to use the GraphQL explorer from GitHub itself to search (in APIv4) for the last commit date using this query:
query {
  repository(owner:"zo0r", name:"react-native-push-notification") {
    ref(qualifiedName: "master") {
      target {
        ... on Commit {
          id
          committedDate
        }
      }
    }
  }
}

So my proposal would be to use, instead of the APIv3 (REST) for GitHub, actually move to its v4 and, by using GraphQL, fetch all the necessary data plus the datetime of the last commit to master, and then use that one to calculate the "Updated XXXX ago" field.
But it may be "a big deal" so I wanted to open an issue to discuss with you guys if it would be a good idea or if it would be better to stick with v3 - in that case, I guess it would be necessary a secondary GET to the API for the last commit for each repo.
If you greenlight it I'd love to try to do it and PR (but I can't give any ETD atm).

I'm a fan of GraphQL and so are the members on our team. So if you want to commit the time to creating a PR to migrating our code over to GraphQL I'm in.
Thanks for thinking about this! Really appreciate you helping us move forward.

I think you should thank @brentvatne for pointing me to the repo ;)
Anyway glad to hear, I will give it a shot - consider that my experience with actual GraphQL (and React web tbh) is limited to a 48hrs Hackathon so it will probably take me a bit of time to send the actual PR 😇
Any preferences over what to use to parse the data via GraphQL? I think that the standard GraphQL js lib should be enough for querying Github APIv4.

In that case, be sure to take your time, really think about the problem, and start with instances where we use isomorphic-fetch. You don't have to touch any of the React web components to prove that GraphQL is a better abstraction over using fetch calls.
I also think the standard GraphQL JS lib is fine :)

Hey @kelset!
I have put together PR #38 which implements a new scoring system. One of the rules checks the pushedAt date and awards a bonus for recently updated libraries. This issue currently causes an issue with that rule being incorrectly applied.
Are you currently working on a PR to fix this issue, or is it something that someone else is able to pick up?

Hi @matt-oakes,
yeah I'm still trying to make it work locally, didn't have enough spare time to complete it yet ><'
Hopefully this weekend I'd be able to submit at least a WIP PR with the "correct" pushedAtinformation your scoring system relies now.
Since we are speaking about it, I think it's worth saying that technically pushedAt is correct: it's GitHub that probably consider that field in a way we can't understand - so instead my idea was having a new field called something like lastCommitDate or lastCommitOnMasterDateand use that instead of pushedAt.

@kelset Sounds great! I think changing the name of the property to something like lastMasterCommitData is a good idea.
Just so you know, my PR also fixes a few small issues with the Github data:

watchers has been changed to subscribers. This is because "watchers" in the Github API is always the same number as "stargazers". The number of "watchers" at the top of each Github repo is actually called "subscribers" in the API (how straight forward...).
I have added fullName property, which is the repo name in the format react-community/native-directory. This is just to save parsing the githhubUrl again.

Details: https://github.com/react-community/native-directory/pull/38/files#diff-b28e04c47986d20caa4ad46f97f50afe

Quick update: didn't submit the PR 'cause couldn't find a way to do a "single" GraphQl call - most tutorials I've found are all just using Apollo to wrap everything, so yeah I haven't found a way yet 😶. Any link appreciated ;)

It looks like from this page of the official docs that you can just make a standard HTTP request, rather than using a library.
This page from the Github v4 GraphQL API docs should have all the details you need, along with the query you posted above. You just need to convert the requests to Javascript rather than the curl examples they give. It will return JSON which you should just be able to use. Should be no need for Apollo or anything more complex.

@kelset @matt-oakes I've landed: https://github.com/react-community/native-directory/pull/38, so:
license has been added
fullName has been added
watchers is now subscribers

Ok I'm back on track ;)
Finally the awesome guys at Apollo published an article that makes it quite easy for me to understand how to do it :)
I think that adding their apollo-fetch is worth for readability - gonna try to submit a PR tonight :3

Nice @kelset -- glad you're still working on this!
If the work is clean, simple and easy to understand, it will definitely land in native.directory! We use GraphQL on expo.io and I wouldn't mind using it here too.

PR submitted (#50) but it is not completed yet - I preferred to start creating it to be able to discuss it along the way.

Fixed by #333


handle custom as well default click handler

JIRA Ticket(s) if any

MOB-7970

Description

We have set the custom as well default handler for in-app message click.

NOTE: In-app changes will be handled separately and won't go in the Beta release.