Setting particle emitter color range makes particles black

Environment

OS Version:
Source or binary build? source, garden

Description

Expected behavior: Setting color range for particles affect particle color
Actual behavior: Particles always appear black

The Ogre2ParticleEmitter::SetColorRange function is working fine in the ign-rendering6 branch which is on ogre2.2. The gz-rendering7 branch is on ogre2.3. Looking at the ogre-next code base, I don't see many changes in the particle system between v2-2 and v2-3 branches. There haven't been any related changes in the Ogre2ParticleEmitter.cc as well. The bug might be coming from other parts of gz-rendering when we upgraded from ogre 2.2 to 2.3.
Steps to reproduce
Modify the particle_demo and change the line from"
areaEmitter->SetColorRangeImage(RESOURCE_PATH + "/smokecolors.png");

to
areaEmitter->SetColorRange(math::Color(1, 0, 0), math::Color(0, 1, 0));

The particles flowing upward from below the duck appear black instead of turning color from red to green
Output

There also is a (related?) issue with marker colors, see this post.
I can confirm on Harmonic (source built) with
libogre-next-2.3-dev
Versions:
2.3.1-9osrf~jammy

that issuing following command spawns white marker:
gz marker -m 'action: ADD_MODIFY, type: SPHERE, scale: {x: 0.2, y: 0.4, z: 1.2}, pose: {position: {x: 3.0, y: 0.0, z: 0.0}}, material: {ambient: {r: 1.0, g: 0.0, b: 0.0}, diffuse: {r: 1.0, g: 0.0, b: 0.0}, emissive: {r: 1.0, g: 0.0, b: 0.0}, specular: {r: 0.0, g: 0.0, b: 0.0}}'

Identical command but Gazebo started with Ogre1 renders in color.


Add missing 'cpp' for C++ code blocks

@Paul-Dempsey,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Image digest(s) as action output

It would be amazing to have this action output the docker image digests for the destination images.

@mowies Since we are not building the image or changing the digest while copying the image, the digest can be already known from the registry itself.
Also, the digest will be different for different platform (amd64, arm64 etc). How should that be shown?
It will be better if you can describe your use case, so that I can find a solution.

I had a misunderstanding regarding the image digests. They don't change when you move them to a different registry right?
If that's the case, I think this issue can be closed.

I had a misunderstanding regarding the image digests. They don't change when you move them to a different registry right? If that's the case, I think this issue can be closed.

Nope. The image digest does not change. That is the main aim of this project , to copy images to different registries without change in digest.


Can’t connect

On tessera remote 3.3.1 and the newest version of companion.
I'm trying to get control of a Brompton Tessera SX40 and not having any luck. I can ping the IP address and the Tessera software connects to the processors from the same computer that Companion is running on. And Companion is able to see/control other devices in the network, so everything should be working properly.
However, when I try to connect the Tessera module to the correct IP address of our processor, it fails with an extremely long HTTP GET Request for 192.168. 10.232 failed (400. ("api" (" devices" ("items": ("00013" ('type", "DB2.6-245-V1", "00023" ("type". "DB2.6-245-V1"1 "00035" ("type" " DB2. 6-245-V1")," 00045":)
Any help is much appreciated! We're trying to connect to three total processors and I get the same error on all three of them.
The error seems to be related to the fixture pack that I’m using. The panels I’m using require a custom fixture pack. When I delete the fixture pack the error is the same but instead of “ DB2. 6-245-V1” it says “unknown”

Hope you managed to fix this! Closing as stale for now - if you see an issue like this again don't hesitate to reach out to our support team at https://www.bromptontech.com/support/


modify close button, caption, count to be absolutely positioned to ta…

I find it really annoying that when i set "backdropClosesModal" to true, when trying to click anywhere near the left of the X (to close) button or around the center of the bottom of the image it fails to close the modal due to an unnecessary wrapper div around these elements.  These elements being the close button, the caption text, and the photo count.
I've changed things around so that the maxHeight of the image is set to windowHeight - (however much space is needed at top and bottom which was 90px and removed the image padding).
Then i changed the css around to make elements inline-block and positioned absolutely.
I don't believe there is a need for the 'GAP_BOTTOM' JSS variable as i replaced it with something a bit more descriptive for what is now being calculated which is 'CAPTION_COUNT_HEIGHT'.  But it seems 'figureShadow' is using it, though i don't see where 'figureShadow' is being used.  Let me know if I can remove that or if you have any other questions and I'd be glad to modify the code accordingly.

@neptunian Sorry I didn't jump on this sooner. I think it now conflicts with #60?
I agree that the styles need to be refactored and would like to implement a solution using flex-box that would let us remove internal state; support is pretty good these days.
What do you think?

Resolved by #73


[Webhooks: ServiceUpgrade] Creation of webhooks with invalid tags must not be allowed

Rancher Versions:
Server: Master
**Docker Version:**v1.13.1
**OS and where are the hosts located? (cloud, bare metal, etc):**Cattle, Cloud
**Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)**Single node
**Environment Type: (Cattle/Kubernetes/Swarm/Mesos)**Cattle
Steps to Reproduce:

Create a webhook for service upgrade with tag as $, & or tags starting with period/dash
Webhook creation is successful

Expected
Webhook creation with tags not allowed by docker should not succeed

Tested with v1.5.0-alpha1. Created webhooks for service upgrade with tag as $, & or tags starting with period/dash. Webhook creation fails with appropriate messages as expected. Examples below:
soumyas-MBP:~ soumya$ curl -u 0365294AE0BDE62D0682:3uqiUPRTxuLnDeBQGWQtvm2UUTshM2136Vn8a3EF -H 'Accept: application/json'  -H 'Content-Type: application/json' http://<IP_ADDRESS>:8080/v1-webhooks/receivers?projectId=1a5  -X POST -d '{"name": "servicebatchtest3", "driver": "serviceUpgrade", "serviceUpgradeConfig": {"tag": "&.", "batchSize": 2, "serviceSelector": {"test4":"value4"},"intervalMillis": 5, "startFirst": true}}'|python -mjson.tool
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   469  100   278  100   191   1179    810 --:--:-- --:--:-- --:--:--  1182
{
    "actions": {},
    "links": {
        "self": "http://<IP_ADDRESS>:8080/v1-webhooks/receivers"
    },
    "message": "Invalid tag &., tag length must be < 128, must contain [a-zA-Z0-9.-_] characters only, cannot start with '.' or '-'",
    "status": "Server Error",
    "statusCode": 400,
    "type": "error"
}

soumyas-MBP:~ soumya$ curl -u 0365294AE0BDE62D0682:3uqiUPRTxuLnDeBQGWQtvm2UUTshM2136Vn8a3EF -H 'Accept: application/json'  -H 'Content-Type: application/json' http://<IP_ADDRESS>:8080/v1-webhooks/receivers?projectId=1a5  -X POST -d '{"name": "servicebatchtest3", "driver": "serviceUpgrade", "serviceUpgradeConfig": {"tag": "#", "batchSize": 2, "serviceSelector": {"test4":"value4"},"intervalMillis": 5, "startFirst": true}}'|python -mjson.tool
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   462  100   272  100   190   1083    757 --:--:-- --:--:-- --:--:--  1088
{
    "actions": {},
    "links": {
        "self": "http://<IP_ADDRESS>:8080/v1-webhooks/receivers"
    },
    "message": "Invalid tag #, tag length must be < 128, must contain [a-zA-Z0-9.-_] characters only, cannot start with '.' or '-'",
    "status": "Server Error",
    "statusCode": 400,
    "type": "error"
}


Remove unused package file-system

file-system contains a vulnerability that hasn't been addressed in over 4 months. Since we're not using it anyway, this vulnerability doesn't affect us, but at least it won't bother npm audit.

How do you know we're not using it?


Updated basic-javascript.json file for challenge Manipulate arrays with shift

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[ ] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[ ] Tested changes locally.
[x] Addressed currently open issue (replace 17235 with an issue no in next line)

Closes #17235
Description

Updated basic-javascript.json file for challenge Manipulate arrays with shift challenge.

Added 'var' keyword before 'removedFromOurArray = ourArray.shift();'

Thanks @rajatkantinandi


Can distance update quickly?

I have say this is a good Augmented Reality Framework.
But I have a question,
when I am walking and changing the location.
Why distance update so slow?
I had change the code "self.reloadDistanceFilter" in ARTrackingManager.swift from 75 to 25.
how can I update the distance more quickly?
Thanks.

Have you tried userDistanceFilter?

Thank you for reminding me！It seems more quickly after set it to 5 or less.


wad-archive database lock

If you execute the script after running it completely it will error out on database locked!

Hoping this fix works 86b4247961a9495ce731b738106f44f34bf7387d


plugin: profile tool crashes qgis

Hi, this is the issue tracker of the QGIS website.
Please create an issue on the issue tracker of the profile tool plugin(? which one are you talking about?), providing more info then what you provide here:

show info about OS, what you were doing, kind of data etc etc

Closing this one here.


Agenda for May call | Wed 15 6pm / 5pm / 12noon / 9am

Next dev call: Wednesday 15 May at 6pm CEST / 5pm BST / 12noon EDT / 9am PDT
All welcome, please see BIDS mailing list for zoom link (or ping @KirstieJane!)
Agenda
The following points are put in place by @KirstieJane after the March call....they might move around as we develop and discuss the extension 😸
Document merged changes
There are a few changes that are already merged to master but that aren't reflected in the ProposedChangesToSpecification.md file.

[ ]  indexable metadata  merged in PR #37 but issue #26 open until the PCTS doc is updated
[ ] there are a few changes merged in PR #30 but not captured in the PCTS doc

Discussion about why we have justified collecting different scans together under one suffix (eg: MP2RAGE and MPM) needs to be added....for example.

Update the examples
We have some nice example folder structures at the moment, but there are a couple more tasks that should be done. See #34 & #35, #46.
General driving principle is that for each new concept in the specification we have an example in the text (and maybe as a dataset?)
There's the open issue #11 which hasn't moved forwards in a while - lets see where that goes.
Field maps
We need to update the specification (and maybe some of the examples - the files might be in the wrong folders) to generalise the use of field maps. See #44
Symbolic links
Need to add to the specification something about being able to symlink derivatives files to raw. See #25

Specifically to allow outputs to be used with current BIDS-Apps.
In the future, hopefully the BIDS-Apps will be able to take inputs from the derivatives, so this linking is a band-aid to help qMRI researchers get into the BIDS-App ecosystem, not a long term plan 😄

Timeline
It would be GREAT to get a PR open to the main specification before OHBM. Documenting what we have done (and why we have done it) is one of the big steps in getting there.... 💪 Keep up the hard work 🏋 🏋♀ 👾
We'll plan to meet on Wednesday 29 May at 4pm CEST / 3pm BST / 10am EDT / 7am PDT and also in person at OHBM in the Open Science Room. Stay tuned 🚀

I can't make this call but I wanted to ping a related issue I posted on the BIDS main repo:
"PDT2 anatomical modality: Recommendations and potential use of _echo"
https://github.com/bids-standard/bids-specification/issues/223
Mainly just looking for recommendations of how to name PD and T2 echo pairs when they've been glued together with the _PDT2 modality label.

@nicholst _PDT2 was there as a placeholder for a while, it is still untouched. Thank you for the reference, I will read this.

Thanks @nicholst! I'm closing this issue as we have had the call.
I think @Gilles86 is going to reply to your question at bids-standard/bids-specification#223 though. If it doesn't make sense then please open a new issue to discuss. I think the answer is related to #50 which contains a link to a WIP 😄


ISSUE-810 : Fix the Issues observed during Hive Sink testing

1). Improve logic to fetch latest ambari configs
2). Pass lowercase field name strings to DelimitedInputWriter in StreamlineHiveMapper

@HeartSaVioR @harshach  made some changes to code related to fetching latest  ambari configs.
and a minor fix in StreamlineHiveMapper


Request: Support class attributes

Hi,
So I got a pydantic model:
from pydantic import BaseConfig, BaseModel

from starlite.cache import CacheBackendProtocol
from starlite.types import CacheKeyBuilder

class CacheConfig(BaseModel):
    """Configuration for response caching.

    To enable response caching, pass an instance of this class to the
    [Starlite][starlite.app.Starlite] constructor using the
    'cache_config' key.
    """

    class Config(BaseConfig):
        arbitrary_types_allowed = True

    backend: CacheBackendProtocol
    expiration: int = 60
    cache_key_builder: CacheKeyBuilder

Both the backend and cache_key_builder attributes are typed using custom classes, which are imported only for typing purposes. Hence this would be possible:
from typing import TYPE_CHECKING

from pydantic import BaseConfig, BaseModel

if TYPE_CHECKING:
    from starlite.cache import CacheBackendProtocol
    from starlite.types import CacheKeyBuilder

class CacheConfig(BaseModel):
    """Configuration for response caching.

    To enable response caching, pass an instance of this class to the
    [Starlite][starlite.app.Starlite] constructor using the
    'cache_config' key.
    """

    class Config(BaseConfig):
        arbitrary_types_allowed = True

    backend: "CacheBackendProtocol"
    expiration: int = 60
    cache_key_builder: "CacheKeyBuilder"

I would like to ask for this feature to be included in this plugin.

Running flake8 on the bottom example produces no TC errors when testing. What exactly do you mean when you say include the feature?
If you mean that imports used type hinting should be flagged to have them moved into type-checking blocks, then I don't think that's possible, since last time I checked Pydantic evaluates the type hints at runtime. Scoping them in runtime-exempt code paths (which is what type checking blocks are) would lead to missing reference (NameErrors), no?

Running flake8 on the bottom example produces no TC errors when testing. What exactly do you mean when you say include the feature?
If you mean that imports used type hinting should be flagged to have them moved into type-checking blocks, then I don't think that's possible, since last time I checked Pydantic evaluates the type hints at runtime. Scoping them in runtime-exempt code paths (which is what type checking blocks are) would lead to missing reference errors (NameErrors), no?

Pydantic resolves these using the method resolve_foward_refs.
It could be that for pydantic this shouldn't be an error, but what about regular classes?

The problem is that we cannot know whether a class is a Pydantic class or regular class, if it has any base model. We're constrained to the scope of the individual file we're looking at, and the base class could be defined outside that scope.
tl;dr: if pydantic support is enabled, we treat any class with a base class as a potential pydantic class. More context in #58

well, you can expose a config option "pydantic_base_classes" or simply "exclude_for_attributes_check"

The exclude for attributes check option exists here 👍

I would reverse the config though - instead of a "pass list", an "pydantic include list", and all other classes shouldnt be considered pydantic.


Could Shake use the Remote Execution API?

I was looking to see the progress of Cloud Shake recently, and it looks like it's still in development. Since it's still in development, have you considered leaning on the Remote Execution API?
The idea being that Shake could be another client like Bazel, BuildStream, Pants, or Recc, and the server stuff would be taken care of by something else.
To be honest, I wonder if the client side of things couldn't be implemented by an oracle in Shake proper. It seems like it would subsume what Cloud Shake does, but maybe I'm missing some other pieces of what Cloud Shake does. The idea sounds possible in my head, but I've tried to look too deeply at whether that would work in practice or not. Might be an idea to try out in an external package.
What are your thoughts?

Even when complete, Cloud Shake wouldn't offer remote execution facilities, so it's not an either/or situation - they could both be useful.
I'm sure it's possible, but it's not as direct as other build systems. For example, in Ninja you run commands specifying the dependencies for a command. However, in Shake you run rules, specifying dependencies for rules - which means there isn't a 1:1 mapping between dependencies and commands. Shake also allows you to declare dependencies afterwards (needed) and for certain local artifacts that are correlated with other artifacts, Shake lets you avoid mentioning them at all. Neither of those would work with a remote execution API.
That said, if you want to give it a go, I think you just need to edit Command.hs with a Remote flag, and then run the command, with all dependencies already declared up to that point in the rule. I'd be keen to see the results!

Oh sorry, I should have been clearer. The Remote Execution API also defines caching. My understanding of Cloud Shake is that the thing it adds to Shake proper is remote caching. That's what I was thinking could be subsumed by the Remote Execution API. Is there more that Cloud Shake is intended to do?
I don't fully get the difference between a dependency and a command as you laid out. I'll try reading some more documentation and seeing if that clears it up.
For transparency, it would probably be quite a while before I did anything here. I don't currently use Shake for anything, so I don't really have the drive to explore this too deeply.

A rule defines an action. An action can execute multiple commands. RE (remote execution) caches and runs at the level of commands. Shake naturally works at the level of rules/actions, and requires consistency at that level. Cloud Shake caches at the level of rules. That means you can have an expensive Haskell computation cached in Cloud Shake, but if its run as an internal apart of the build, it wouldn't be suitable for RE. It could well be that if we had RE we wouldn't care about Cloud Shake, but they do somewhat different things.

I think I'm starting to get it. Thanks for explaining that!


Test automation, Number of tests to be executed

We followed Freddys repository on https://dev.azure.com/businesscentralapps/HelloWorld/_git/HelloWorld?path=%2Fscripts%2FRead-Settings.ps1&version=GBmaster
and included it our solution. My question is that there is only 3219 tests in all dependencies from Microsoft. In previous version onPrem there were more than 20k of tests. Is this normal or?
P.S i can mention that when creating a new container on the end i get this errors and warnings:

Scripts are basically the same as we used on version 13 with all dependency included in test tool for baseapp, this is testtool app.json:
{
"id": "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
"name": "TRASER DMS Business Central Test Automations",
"publisher": "TRASER Software GmbH",
"version": "<IP_ADDRESS>",
"brief": "",
"description": "TRASER Dealer Management System 365 Test Automations",
"privacyStatement": "",
"EULA": "",
"help": "https://docs.traser-software.de",
"helpBaseUrl": "https://docs.traser-software.de/{0}",
"supportedLocales": ["de-DE", "en-US"],
"url": "http://www.traser-software.de/",
"dependencies": [
{
"name": "TRASER DMS Business Central",
"publisher": "TRASER Software GmbH",
"version": "<IP_ADDRESS>",
"appId": "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
},
{
"appId": "63ca2fa4-4f03-4f2b-a480-172fef340d3f",
"publisher": "Microsoft",
"name": "System Application",
"version": "<IP_ADDRESS>"
},
{
"appId": "437dbf0e-84ff-417a-965d-ed2bb9650972",
"publisher": "Microsoft",
"name": "Base Application",
"version": "<IP_ADDRESS>"
},
{
"appId": "dd0be2ea-f733-4d65-bb34-a28f4624fb14",
"publisher": "Microsoft",
"name": "Library Assert",
"version": "<IP_ADDRESS>"
},
{
"appId": "e7320ebb-08b3-4406-b1ec-b4927d3e280b",
"publisher": "Microsoft",
"name": "Any",
"version": "<IP_ADDRESS>"
},
{
"appId": "9856ae4f-d1a7-46ef-89bb-6ef056398228",
"publisher": "Microsoft",
"name": "System Application Test Library",
"version": "<IP_ADDRESS>"
},
{
"appId": "5d86850b-0d76-4eca-bd7b-951ad998e997",
"publisher": "Microsoft",
"name": "Tests-TestLibraries",
"version": "<IP_ADDRESS>"
},
{
"appId": "23de40a6-dfe8-4f80-80db-d70f83ce8caf",
"publisher": "Microsoft",
"name": "Test Runner",
"version": "<IP_ADDRESS>"
}
],
"screenshots": [],
"platform": "<IP_ADDRESS>",
"idRanges": [
{
"from": 50100,
"to": 50149
}
],
"contextSensitiveHelpUrl": "https://Test.com/help/",
"showMyCode": true,
"runtime": "4.0",
"target": "OnPrem"
}
Thanks you in advance.

It would help if you would include information about how you got this number.
Like: If I run this script:
$imageName = "bcinsider.azurecr.io/bcsandbox:de-ltsc2019"
$auth = "NavUserPassword"
$credential = New-Object pscredential 'admin', (ConvertTo-SecureString -String 'P@ssword1' -AsPlainText -Force)
$licenseFile = "C:\temp\build.flf"
$containerName = "bcde"

New-BCContainer -accept_eula `
                -imageName $imageName `
                -containerName "bcde" `
                -licenseFile $licenseFile `
                -auth $auth `
                -Credential $credential `
                -updateHosts `
                -doNotCheckHealth `
                -includeTestToolkit

and open the test toolkit page and select all tests, I get:

Which clearly is more than 3219 tests.

Hi Freddy
i just changed your link to $imageName = "mcr.microsoft.com/businesscentral/sandbox:de" and it worked like a charm with all test codeunits include. I think my problem is in another script when choosing image, it created container out of mcr.microsoft.com/dynamicsnav:generic-1903 which is wrong and doesnt include all the tests.
I can close this issue and thank you again

This is why it is so important for me to get the full commands used and the output.
What you probably see here is, that when you use -useBestContainerOS (replatforming containers) something happened.
Since some apps are there, I almost assume that the cache containing files from images has errors (or maybe part filled from disk full).
You could try to use Flush-ContainerHelperCache to flush all caches and start again.

Had a quick look - when using -useBestContainerOS with local sandbox containers, the folder with the local tests isn't transferred to the new container - this is probably what you see here.
Will fix this for the next generic image.

I have deleted -useBestContainerOS ` and changed -isolation from "Process" to "hyperv" and then it worked with no errors like in first post. all tests are included
Tnx Freddy U R D Legend! :)

Next version of the generic image will fix this so that also -useBestContainerOS will get local applications folders transferred.

Generic image <IP_ADDRESS> was shipped today, this should fix the issue


Unable to correct password error, Relink command does not work as expected

Received a note that my bridge is disconected:

There doesn't appear to be a way to resolve the issue. The relink command makes a new indexed bridge (likely not the intended design) and the link command is for new bridges also.
Any advise so my rooms don't all have to be remade?

Having this issue myself:
Aug-25 22:02:41.153 [bot-sdk-MatrixLiteClient] info: (REQ-7) PUT http://localhost:8008/_matrix/client/r0/rooms/!UUKBcjSGPGDklEECqq%3Aingwie.io/send/m.room.message/1598392961153__REQ6
Aug-25 22:02:41.430 [MatrixPuppet:Steam] error: Failed to start up puppet 1 Error: InvalidPassword
    at SteamUser.<anonymous> (/srv/matrix/steam/node_modules/steam-user/components/logon.js:468:16)
    at /srv/matrix/steam/node_modules/steam-user/components/classes/HandlerManager.js:37:12
    at Array.forEach (<anonymous>)
    at HandlerManager.emit (/srv/matrix/steam/node_modules/steam-user/components/classes/HandlerManager.js:36:12)
    at SteamUser._handleMessage (/srv/matrix/steam/node_modules/steam-user/components/messages.js:545:24)
    at SteamUser._handleNetMessage (/srv/matrix/steam/node_modules/steam-user/components/messages.js:480:7)
    at SteamUser.processMulti (/srv/matrix/steam/node_modules/steam-user/components/messages.js:572:9)
    at SteamUser.<anonymous> (/srv/matrix/steam/node_modules/steam-user/components/messages.js:566:16)
    at /srv/matrix/steam/node_modules/steam-user/components/classes/HandlerManager.js:37:12
    at Array.forEach (<anonymous>) {
  eresult: 5
}

My password is definitively correct and it had asked me for my Steam Guard code too. I verified the used password in a browser, just to double-check. No luck unfortunately.

Same here on 91d5de6c2cac07fb57e8fcfed8768b8ac17a2877.
Sep-4 11:35:55.931 [MatrixPuppet:Steam] error: Failed to start up puppet 4 Error: InvalidPassword

Issued the link command, received the Steam guard code via email and sent it to the bot.

Same here, although there have been no new commits since last comment, this project seems unfortunately unmaintained.

And the same happened here ;/

Okay, I made some (small) progress on this:
relink does work, but it defaults to reusing the existing sentry file, which is stored in ~/.local/share/node-user/sentry.${accountName}.bin. Deleting this does not fix my connection errors, but it at least prompts me for the steam guard again.
It seems like there is some issue, when using Email for Steam Guard, see here: https://github.com/DoctorMcKay/node-steam-user/issues/333

I have he same problem.
I link the account enter the steam guard code and after this i get a new email from Steam with exact the same SteamGuard Code.
When i restart mx-puppet-steam systemctl restart matrix-mx-puppet-steam i get this error:
Jul 28 00:46:35 nas matrix-mx-puppet-steam[15650]: Jul-27 22:46:35.168 [MatrixPuppet:Steam] error: Failed to start up puppet 4 Error: InvalidPassword Jul 28 00:46:35 nas matrix-mx-puppet-steam[15650]:     at SteamUser.<anonymous> (/opt/mx-puppet-steam/node_modules/steam-user/components/logon.js:489:16) Jul 28 00:46:35 nas matrix-mx-puppet-steam[15650]:     at /opt/mx-puppet-steam/node_modules/steam-user/components/classes/HandlerManager.js:37:12 Jul 28 00:46:35 nas matrix-mx-puppet-steam[15650]:     at Array.forEach (<anonymous>) Jul 28 00:46:35 nas matrix-mx-puppet-steam[15650]:     at HandlerManager.emit (/opt/mx-puppet-steam/node_modules/steam-user/components/classes/HandlerManager.js:36:12) Jul 28 00:46:35 nas matrix-mx-puppet-steam[15650]:     at SteamUser._handleMessage (/opt/mx-puppet-steam/node_modules/steam-user/components/messages.js:571:24) Jul 28 00:46:35 nas matrix-mx-puppet-steam[15650]:     at SteamUser._handleNetMessage (/opt/mx-puppet-steam/node_modules/steam-user/components/messages.js:506:7) Jul 28 00:46:35 nas matrix-mx-puppet-steam[15650]:     at SteamUser.processMulti (/opt/mx-puppet-steam/node_modules/steam-user/components/messages.js:598:9) Jul 28 00:46:35 nas matrix-mx-puppet-steam[15650]:     at SteamUser.<anonymous> (/opt/mx-puppet-steam/node_modules/steam-user/components/messages.js:592:16) Jul 28 00:46:35 nas matrix-mx-puppet-steam[15650]:     at /opt/mx-puppet-steam/node_modules/steam-user/components/classes/HandlerManager.js:37:12 Jul 28 00:46:35 nas matrix-mx-puppet-steam[15650]:     at Array.forEach (<anonymous>) { Jul 28 00:46:35 nas matrix-mx-puppet-steam[15650]:   eresult: 5 Jul 28 00:46:35 nas matrix-mx-puppet-steam[15650]: }
and Steam sends a new SteamGuard Code.
@icewind1991 pls help

Yes, if you use the app for 2FA, you shouldn't have any issues, but I can't use the app, so this solution doesn't work for me (unless I set up an Android VM).

I use 2FA and have the same Problem on my Server.

Relink is not usable
I have to unlink and link my account again every week. not comfotable.

same thing happening to me
i can not link with or without steam guard

Tried using this with mobile 2fa, and still not working. Is there any working solution on this?

Invalid password for me too. I'm using WinAuth and my password is definitely correct.

I am seeing the same issue.

Same problem, using the guard OTP from Bitwarden, same as in mobile app (or winauth and similar apps)


Ability to subscribe to an event channel.

How do I subscribe my client to an event channel and listen for when the channel is triggered?

HI @bimsina, it doesn't support listening to events on a channel. Which platform are you using (web, flutter, io)?

Flutter

Yeah, sorry this package doesn't support Flutter right now, you can find other options at https://pub.dev/packages?q=pusher+flutter.

I found another package  that did the job. Anyway, thanks for the response. Appreciate it!


Consistent logos for Scout / Beacon / Conductor

time to change ALL THE LOGOS I was afraid of this happening.

For the time being, I can upload a white version of the binoculars.

I've added the Scout and Beacon logos (small black versions for the navbar and large white versions for the circles) here: https://drive.google.com/drive/u/1/folders/0B24dyIgc537SZnk5cTZySnNSZUE

@hamhands ^^
Still note done is Conductor logo, which I'lll add to the logo folder before the end of the week

Uploaded Beacon logos that have skinnier linework: https://drive.google.com/drive/u/1/folders/0B24dyIgc537SZnk5cTZySnNSZUE


Add new documentation site

Description
This is the initial setup of the documentation site that includes the ported guides from the existing docs site as well as references generated directly from the OpenAPI spec. The CLI and templates references are for now directly copied from their respective folders - this will be updated to follow a similar pattern to be automatically generated from the source code later.
This direct access to our core components is the main motivation for moving the docs to this repo - it will be much easier to weave them into a well-documented experience for us internally and externally later.
Architecture overview
The documentation site is an entirely static Astro site that uses Starlight framework for organizing and rendering documentation. I chose the Starlight framework as it provides very simple and good defaults for a documentation site: an interface for managing the sidebar and table of contents on each page, a search (built on Pagefind tool) that works out of the box, and a styling system that is accessible and looks good by default.
The entire site will be hosted in the docs/ URL subdirectory as it will be hosted on the fiberplane.com main domain alongside our Framer-hosted site (as opposed to the docs.* subdomain). This is why you will find some of the files live in a somewhat awkward docs/docs/ subdirectory - this is a work around to ensure that all markdown pages render on fiberplane.com/docs
The site renders the documentation content from two sources:

Markdown files that are in the src/content/docs/ subdirectory. These are pretty straightforward and they just render according to Starlight's conventions. As mentioned earlier the CLI and Templates reference are for now just these markdown files placed in their respective directories.
The OpenAPI spec that is rendered dynamically. This uses the underlying Astro's file-based routing engine to parse the openapi_v1.yml file and render the pages for each resource. For this I had to roll our own documentation components that I built on my own using the Starlight's design systems variables (with our fonts and colors mixed in) wherever possible. I could, however, make use of Starlight's template to make sure it sits flush with the rest of the documentation.

How OpenAPI documentation is rendered
The documentation is organized using the tags properties in the OpenAPI spec. Each tag corresponds with what we would consider a "resource" in Fiberplane: notebooks, templates, workspaces, events etc.
Each tag then has a number of operations associated that are rendered in a single large page that is ctrl/cmd-f'able along with necessary path, request body parameters, and return schemas. Every
path and operation makes use of the description property on the OpenAPI spec to render a rich markdown-supported documentation. The next phase in this project will entail a revision of the OpenAPI spec to ensure more of the relevant paths/parameters are better documented.
Remaining TODOs and other notes
There is a number of shortcuts tradeoffs I made that will need to be addressed in subsequent PRs.
Search. Most of the search works out of the box thanks to Starlight. The parts that are not currently indexed are the API reference pages. This is the immediate next step after the first site is fully shipped.
Blog site. The blog site will eventually move to this website under the blog/ subdirectory.
Types. You'll notice there are maybe more type castings and @ts-ignore s then we'd otherwise be comfortable in our codebase 😅. I was a bit more liberal with them wanting to get the first version out the door. Also, all of the site is rendered at build time anyway for now.
Design system. The site mostly uses Starlight's defaults with Fiberplane system sprinkled in. Eventually we'll move to fully our own styling.
Checklist

[ ] The changes have been tested to be backwards compatible.
[ ] The OpenAPI schema and generated client have been updated.
[ ] New models module has been added to api generator xtask
[ ] New types/fields are well-documented and annotated.
[ ] The CHANGELOG is updated.

@stephlow yeah unfortunately Biome doesn't support parsing Astro files as it doesn't yet understand HTML and CSS syntax. I was looking for a way to avoid adding Prettier but for now it seems like it's inevitable. Good news is that supporting HTML, CSS and their supersets like Astro seems to be on their roadmap.


Change ValueTypeIec61360 from 2000 to 2048

ValueTypeIec61360 change length from 2000 to 2048.
Compare to https://github.com/admin-shell-io/aas-specs/issues/306

@JoergNeidig may you please review this PR, thank you


Missing workbook language reference guide

I have been struggling to make use of workbooks for any but the simplest of tasks. This is largely due to the fact that there is no language reference guide that would afford the user the ability to specify "type" and other parameters in a meaningful way. Last time I checked type 0 type 2 type 9 etc are not Microsoft standard ways of naming things and have not been since ms-dos.
Yet here they are in each workbook as it to tell us that they are necessary but we are going to give you any more info about them.
I am really hoping that Microsoft is not up to its old tricks again by selectively providing info that gives the user a distinct disadvantage while creating workbooks on azure data.
For example, while it is clear how to use parameters in kql queries it is not clear how to conditionally show various dropdowns as a function of previous dropdown selections.  This conditional display is critical to our ability to make appInsights workbooks customizable for each of our spa's requirements.  The docs do not appear to have a solution to this very common problem.
Dropdown a value requires the display of dropdown b or dropdown c... which then requires dropdown e or dropdown f.
The conditional display values do not appear to work in such a scenario.
And there does not appear to be any docs about how to do this.
I have downloaded the entire corpus of documentation that is many thousand pages and at best disorganized and incomplete.
very disappointing indeed

Also whoever is in charge of the online docs for this particular product should be moved into the "creating badly worded  puzzles  for Xbox " division and out of their present position
Giving an abstract example not grounded in a specificity actionable and complete set of code is the equivalent of someone giving a PPT presentation with a bunch of arm-waving and then right before closing the presentation a small box in the corner of the last page that says "Miracle occurs here".
As it stands right now the docs are an insult to professionals who spend money on azure and expect not to have to waste time on sub standard work by the Azure docs team.

Here is another very simple request.
Depending upon which tables are selected I want the viewer to be able to select the columns they want.... This is available in the log query function but I cannot find an example of how to construct one (that has the dependency of other dropdowns) anywhere.
I am glad that Microsoft uses this functionality all over the place... bit disappointed that i have to write this request

Workbooks are generally intended to be created using the Workbooks UX, where a lot of this information is opaque to users.  The JSON format is the serialized format when a workbook is saved, and is only partially documented at the current time because of time and resource constraints.  Numeric enums, while not super discoverable, are a very common construct, even still today.

it is not clear how to conditionally show various dropdowns as a function of previous dropdown selections

It is not clear because it is not directly possible at the current time.  Individual parameters cannot be dynamically hidden and shown, though it is a request on our backlog.  Only steps have conditional visibility at this time, so a workaround may be to create different parameter steps, containing the parameters that apply or do not apply depending on the situation.

I want the viewer to be able to select the columns they want.

Also on our list, though is also (unfortunately) not very common in the Azure portal, and (because) it is not built into the portal's grid control itself.
I understand your concerns and frustrations.  Do you have a specific concrete docs thing we can fix?  Many of the examples are abstract because the actual data available in any log analytics workspace or metrics for any resource aren't valid in other places, so many concrete examples aren't easily portable.  We're working on trying to improve these things, so the more specifics you can give, the higher the chance we can address them.

I have many that I can provide but it would be faster for you to go through the workbook and kql online docs and review them for exact answers with actual working code (in a workbook or kql format that is complete as opposed to a theoretical snippet).
Over time i will gladly provide you with a list. But I am working as a consultant to a sp500 company with all the accompanying security etc on azure.
I truly mean this with no rancor... get someone who knows how to build reference documentation for workbooks and kql.
If you do this you will quadruple   use of this burgeoning technology.
The potential for workbooks and kql to be the standard templating language for cloud administration (the equivalent to .bat files in ms dos ) is yours to lose.
As it stands right now I am going to have to advise my client not to invest too much in this technology because it is not getting the attention it needs at ms and azure.
If this technology is implemented correctly all of azure could be built on it.
It is what I assumed was happening behind the scenes.
The thing is that it is not even that hard to build. I have built an HTML / SQL server full stack react generator in 6 months that does 90% of the non kql parts plus 3d web/gl graphics
I would offer to sell  or give it to you but I know how ms internally operates and it would take legions and millions of dollars just to find the person who has the authority to say yes
what a shame


@serenity-js/webdriverio Not able to Switch to Iframe

I'm using serenity-js/webdriverIO framework and I'm unable to Switch to Iframe. When  I looked at the serenity-js documentation, Switch is supported by Protractor  and couldn't find anything in webdriverIO.
Please help me how to implement Swicthing to Iframes in webdriverIO framework.

Hi @chaitanyachekuru and welcome to the Serenity/JS Community!
You're right, Serenity/JS 2.0 had support for Switch only for Protractor, not for WebdriverIO.
Serenity/JS 3.0 RC, which I'd recommend for any new projects, has a portable interaction to Switch that works with all the supported web integration tools, Protractor, WebdriverIO+Webdriver Protocol, WebdriverIO+Devtools Protocol, as well as Playwright.
You'll find plenty of usage examples in the web specs.
Hope this helps!

Hi @jan-molak
Is there any way that I can implement Switching to Iframes in Serenity/JS 2.0 as we have already built the test framework. Please let me know if there are any other alternatives that can be used in webdriverIO framework.

Sure, you could quite literally copy and paste Switch from @serenity-js/protractor and replace the protractor API calls with WebdriverIO equivalents

Thank you


fix: make code coverage work with azure

Realized that code coverage was silently failing after we moved to Azure. Upgraded codecov cli and simplified the process to use an ENV variable.

Actually this is not ready. I need to figure out a way to break this into it's own step or it will report coverage twice. Also need to add the ENV variable still.

Alright this should be ready now. I removed testing against node v12 since it would mean we'd report results twice. I'll figure out a cleaner way to bring this back in the future.


Log activity not working with soft delete

Describe the bug
Log activity not working with soft delete
To Reproduce
Things needed to reproduce the error.
eg: Configuration, Migration, Model, Controller/Command
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Versions (please complete the following information)

PHP:
Database:
Laravel:
Package:

Additional context
Add any other context about the problem here.
Exception
The thrown exception message.
Stack Trace
The full stack trace of the thrown exception.

Please fill all parts needed for a bug report. Otherwise we can't handle it and it will get closed in near future.


As a test reporter, I'd like to see just the tests and pass/fail.

Suggestion: add a "summaryOnly" boolean config flag. When set, this suppresses the error summary and effectively sets the maxLogLines to 0. So we see all the "describe" lines, all the "it" lines decorated with colour and tick/cross for pass/fail, and that's it.

The attached patch seems to work against commit a71f679.
summaryOnly.patch.txt

@captainstarfish is this still needed? Can you put together a PR?

Closing and referencing in new ticket


Signatures are verified when code is checked out in Concourse pipelines

In order to ensure that contributions to our repos only come from trusted team members, we should ensure that commits are signed when they are checked out in Concourse pipelines
Acceptance Criteria

[ ] GIVEN that we want our Concourse pipelines to only used signed commits
WHEN I use a custom script to check if commit signing is required for our pipelines
THEN the script output confirms that commit signing is enabled for our pipelines

Security considerations
This change will be a security enhancement in that it requires all commits to our repos to be signed and thus at least to be coming from a an identity that is verified with Github.
We will further enhance security by configuring Concourse to only accept commits with a public key that is "trusted" for our team.
Questions

What we will do about old, unsigned commits?

Implementation sketch
The Concourse git-resource plugin has options for requiring that commits are signed: https://github.com/concourse/git-resource.

[x] Research options for configuring our Concourse pipelines to only accept commits signed with keys from our team

Option: Create a CredHub secret containing all the public GPG keys for platform team members
Option: Create a keyserver, which could be used by Concourse and other tools to get our team's GPG keys. Some open-source keyserver options:

https://github.com/SKS-Keyserver/sks-keyserver
https://cgit.freebsd.org/ports/tree/security/pks
https://github.com/hockeypuck/hockeypuck

[x] Verify approach for requiring signed commits on a single Concourse pipeline
[ ] Try to write script to verify that checks whether every git-resource in all of our concourse pipelines enforces commit signing
[ ] Manually update every Concourse pipeline to use commit signing for git resources
[ ] Use script or manual validation to confirm that commit signing is enabled for git resources in all Concourse pipelines

Initial research findings:

There is no existing service that can be used to create a keyring for a team, as far as I can tell
The concourse git-resource requires that either commit_verification_keys or commit_verification_key_ids will be specified in order to perform signature verification of commits.

Thus, it probably doesn't matter if we use a key service like keyserver.ubuntu.com to store public keys for our team because we have to do one of the following:

Manually specify the ID for the GPG public keys that should be fetched via commit_verification_key_ids
Manually specify the GPG keys for our team via commit_verification_keys

In that case, I'm not sure there is any need to stand up our own keyserver?
We can probably use Credhub to store either the GPG keys themselves or the GPG public key IDs for our team.
@bengerman13 @pburkholder @mogul -Thoughts?

I'm definitely not interested in running our own keyserver if we can help it. Storing key IDs in CredHub seems like the right approach.

I think it's fine to use an external key server. They're public material so
there's no confidentiality risk, and they're keys so there's no integrity
risk (if they're munged, they'll just stop working).
I don't think we can run a service that's more available than the one
Ubuntu runs. If we can specify another fallback key server that would be
good, but is a nice-to-have.
If it's easy to store the keys themselves in Credhub, that works too.
On Thu, Jun 16, 2022 at 11:35 AM Mark Boyd @.***> wrote:

Initial research findings:

There is no existing service that can be used to create a keyring
for a team, as far as I can tell
The concourse git-resource requires that either
commit_verification_keys or commit_verification_key_ids will be
specified in order to perform signature verification of commits
https://github.com/concourse/git-resource/blob/5c934844cde1df0f2ad3e4c5edd2b5f023c56476/assets/in#L129
.

Thus, it probably doesn't matter if we use a key service like
keyserver.ubuntu.com to store public keys for our team because we have to
do one of the following:

Manually specify the ID for the GPG public keys that should be
fetched via commit_verification_key_ids
Manually specify the GPG keys for our team via
commit_verification_keys

In that case, I'm not sure there is any need to stand up our own keyserver?
We can probably use Credhub to store either the GPG keys themselves or the
GPG public key IDs for our team.
@bengerman13 https://github.com/bengerman13 @pburkholder
https://github.com/pburkholder @mogul https://github.com/mogul
-Thoughts?
—
Reply to this email directly, view it on GitHub
https://github.com/cloud-gov/product/issues/1764#issuecomment-1157804923,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJHWCUJ5NRCSDWLDLWJMSDVPNCS3ANCNFSM5XSMKREQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Peter Burkholder |  *
cloud.gov https://cloud.gov ISSO, compliance & security lead
please use @.** for cloud.gov matters
202-709-2028 <(202)%20209-2028> | @.**
@.***> *
| pronouns he-him https://www.mypronouns.org/he-him
Free/Busy Calendar
@.*>

Update:

Tried to get the pipeline to verify commits using commit_verification_key_ids loaded from Credhub and storing public keys on the Ubuntu keyserver. However, despite the fact that I'm sure I added my public key to the Ubuntu keyserver, I couldn't retrieve it either from their website or the command line. So I gave up on this for now
Pivoted to using commit_verification_keys in the git resource definition and storing the public key directly in Credhub. This approach is working: https://ci.fr.cloud.gov/teams/main/pipelines/deploy-allstar/jobs/deploy-prod/builds/41. The branch containing the pipeline updates is here.

Todo:

How do we re-use the same set of public keys from Credhub in every pipeline with pasting he same list of every team member's Credhub secret names into  commit_verification_keys in every definition?

Update:

Got the Pipeline to verify commits using commit_verification_key_ids. See https://ci.fr.cloud.gov/teams/main/pipelines/deploy-allstar/jobs/deploy-prod/builds/44
Proved that if you try to verify a commit that was signed with a different key than one specified via commit_verification_keys, then the build fails. See https://ci.fr.cloud.gov/teams/main/pipelines/deploy-allstar/jobs/deploy-prod/builds/50

One concern I have is that even on builds which are verifying commits successfully, we're getting this warning message:
gpg: Good signature from "Mark Boyd<EMAIL_ADDRESS>[unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.

I started a lengthy discussion about this warning in Slack. Based on my limited understanding of PGP, it doesn't seem like there is currently a way to make the Concourse git resource trust our self-signed PGP keys.
The question is: is this a problem? We have proven that the CI pipeline does succeed/fail correctly based on whether it is receiving commits that are signed with an expected PGP key or not. Maybe it doesn't matter whether CI environment itself trusts the PGP key, since it only needs to use it to verify a commit? On the other hand, my understanding is that if you can't verify a key signature, then you don't really have any proof of who the key claims to be and would be subject to spoofing.
Given my inexperience with cryptographic security, I don't really know the answer here. And I don't want to do the work on this issue only to implement it half-correctly.
@mogul @pburkholder @bengerman13 Thoughts?

I checked out the code for the Concourse git resource locally to do some more testing.
Tests and outcomes using commit_verification_key_ids:

Specify an unknown PGP key ID to verify a commit. Fails as expected.
Specify the correct PGP key ID that was used to sign a commit. Passes as expected.
Specify a different PGP key ID than the one that was used to sign a commit. Fails as expected.

Tests and outcomes using commit_verification_keys:

Specify the PGP public key that was used to sign a commit. Passes as expected
Specify a different PGP public key than the one used to sign a commit. Fails as expected

This test passes if you first run the test for the correct PGP key and then re-run this test for a different PGP public key. I think the reason why is that both PGP keys that I'm using for testing were signed by the same private key from my machine. I don't think there is any way for this scenario to occur in a real Concourse build anyway, so it likely doesn't matter.

@mogul

However signing keys is not very hard to do, if there's an existing key that Concourse trusts.

I can't find any documentation on this existing. And even if it did, then everyone on the team would have to sign their keys using this Concourse key, so it would be a bit onerous.

@mogul Thanks for documentation! If I'm understanding then, it seems like I'd have to modify the Concourse git resource to do a gpg --sign-key (assuming it has a key that it could use for signing), so would have to submit a PR to them and use a Docker image from a fork in the meantime.
At the moment, I'm not inclined to do that unless you think it's necessary.

Nope, let's move on and revisit this only if the message gets confusing for folks or compliance audits demand it.

After some testing, I have a Concourse pipeline successfully verifying commits against a list of PGP key IDs which are stored in Credhub. The cloud-gov-pgp-key-ids Credhub credential is an array of key IDs, so it can be updated to include the key IDs of every team member.
In order for this to work, every team member will need to upload their PGP public key to keyserver.ubuntu.com, since that is where Concourse is fetching the keys from.
We are having an issue with Concourse verifying commits signed by Github's PGP key, which is used when Github creates merge commits. Apparently the PGP key from Github has no user ID.
Next steps:

[ ] Resolve issue with Concourse identifying Github key ID
[ ] Get all team members to upload their PGP public keys to keyserver.ubuntu.com
[ ] Update all repos using a git resource pointing at a cloud-gov repo to include config to verify commits

PR for script to add PGP public key to S3: https://github.com/cloud-gov/cg-scripts/pull/218

PR for Concourse pipeline: https://github.com/cloud-gov/pgp-keys/pull/1/files

PR to update onboarding template: https://github.com/cloud-gov/product/pull/2070

The next step is that I need to somehow identify all of the repos containing Concourse pipelines and add this to the definition of every git resource that pulls from a cloud-gov repo:
commit_verification_keys: ((cloud-gov-pgp-keys))

First PR to update a pipeline with commit signature verification: https://github.com/cloud-gov/cg-deploy-allstar/pull/2

Todo:

[ ] Add note to offboarding template about removing team member public key from bucket

PR for script to detect git resources in our pipelines that aren't verifying commit signatures:
https://github.com/cloud-gov/cg-scripts/pull/219

Below is a list of all of the pipelines that have 18F/cloud-gov repos and which need commit verification configured. This comment will be updated with the PR(s) that add commit verification to the pipeline.

[ ] bosh-dependencies
[ ] buildpack-notifier
[ ] cg-cert-check
[ ] cg-sandbox-bot
[ ] deploy-admin-ui
[ ] deploy-aws-broker
[ ] bosh-releases
[ ] deploy-bosh
[ ] deploy-cdn-broker
[ ] deploy-cf
[ ] deploy-concourse
[ ] deploy-deployer-account-broker
[ ] deploy-diagrams
[ ] deploy-domains-broker
[ ] deploy-doomsday
[ ] deploy-go-s3-broker
[ ] deploy-postfix
[ ] deploy-limit-check
[ ] deploy-logsearch
[ ] deploy-nessus-manager
[ ] deploy-opsuaa
[ ] deploy-prometheus
[ ] deploy-shibboleth
[ ] deploy-stratos
[ ] deploy-uaa-extras
[ ] external-domain-broker
[ ] purge-sandboxes
[ ] report-federalist
[ ] secret-rotation
[ ] secureproxy-boshrelease
[ ] snort-boshrelease
[ ] sync-covid-bucket
[ ] test-hello-worlds
[ ] update-s3-resource-image
[ ] update-task-image
[ ] external-domain-broker-migrator
[ ] docker-registry-mirror
[ ] kibana-cf-auth-proxy
[ ] uaa-bot
[ ] deploy-credhub
[ ] legacy-domain-certificate-renewer
[ ] jumpbox
[ ] terraform-provision
[ ] container-scanning
[ ] deploy-cspr-collector
[ ] cvd-sync
[ ] aws-cloudtrail-notifier
[ ] deploy-allstar
[ ] aws-admin
[ ] billing-automation
[ ] cg-pgp-keys

@mogul @ChrisMcGowan I can't find the source code for the sync-covid-bucket pipeline. Is that pipeline even still needed?

PR to add offboarding step for removing PGP public key:
https://github.com/cloud-gov/product/pull/2071

Since the repo is not owned by our org, can we add commit verification to it? Because we can't enforce/expect that commits should only come from our own team

(If/when we get a PR, I think we can rebase to sign, just as we do when we get PRs to cg-site from non-members.) Let's turn then on, and revisit if this ends up causing more trouble than it's worth.

Given the fact that it was paused and had not been run since 2018, I deleted the secret-rotation pipeline. If necessary, we can always recreate the pipeline from the source code.

Running get-pipeline-git-resources-without-verification.sh now produces zero output, confirming that all Concourse pipelines have been updated to verify signed commits. Closing this issue now.


ci(helm): fix and simplify bats logic

what

Fix helm test
Simplify logic by using the bats image directly

why

Closes https://github.com/runatlantis/helm-charts/issues/292

tests

Tested locally with:kind create cluster --name test-atlantis
helm upgrade -i atlantis charts/atlantis -f ci/ci-values.yaml
helm test atlantis
kind delete cluster --name test-atlantis

Id love to get this merged in ASAP, so I can get it added into my existing ingress Pull Req.

@nitrocode
Any chance we get this in, so we can get the other open Pull's in place as well?
Thanks,

Hello the bats image was removed from dockerhub: https://hub.docker.com/r/bats/bats
Please avoid dockerhub at all costs in your software supply chain tbh.

bats issue: bats-core/bats-core#737

Replied on the issue.


Updated locate.go to fail if glob search directory does not exist.

I found that if VTROOT variable was not set to a valid directory than some unit tests like go/vt/sqlparser/parse_test.go TestParse  would incorrectly pass. This is due to the go/testfiles/locate.go Glob Method returning an empty []string even if the directory does not exist. The fix includes panicking if the $VTROOT/data/test directory does not exist.

Good catch. Thanks!


Safe handling of alias

Fixes #4003
Unable to repro the issue itself, but this mapper is a bottleneck that has failed multiple times in the past for other errors as well. Fixed this by replicating default type mapper's logic.

@nidhi-nair : I am sorry I should have closed this sentry issue. This crash is seen when we read from the db a page which has _id and _class keys in the DSL . This can be reproduced by actually editing a dsl object in the db and then reading the page via the java driver.

@trishaanand I was intending to allow the actual bug to surface through this. Now that you have shared the steps to reproduce this, let me try recreating the issue.


Launching Fireworks Causes Crash

BTW Version: CE1.4.1
Multiplayer (yes/no): no
Issue (be as specific as possible): Launching a firework causes a crash. Unable to re-enter world after the crash.
Steps to Reproduce (even if obvious): Set off a firework.
Addons (with versions): N/A
Crash Log (if there was a crash):
crash-2022-09-29_13.57.13-client.txt

Fixed for 2.0.0

Fixed for next release


qat: Add AppArmor unconfided anntotation configurability in the operator

Codecov Report

Merging #1591 (9f72c4d) into main (4429fb4) will decrease coverage by 0.02%.
Report is 17 commits behind head on main.
The diff coverage is 57.14%.

:exclamation: Current head 9f72c4d differs from pull request most recent head 697c2c3. Consider uploading reports for the commit 697c2c3 to get more accurate results

@@            Coverage Diff             @@
##             main    #1591      +/-   ##
==========================================
- Coverage   49.50%   49.48%   -0.02%
==========================================
  Files          42       42
  Lines        4965     4975      +10
==========================================
+ Hits         2458     2462       +4
- Misses       2363     2369       +6
  Partials      144      144

Files
Coverage Δ

cmd/gpu_plugin/gpu_plugin.go
86.74% <100.00%> (ø)

pkg/fpga/bitstream/bitstream.go
88.88% <100.00%> (ø)

pkg/controllers/qat/controller.go
11.05% <40.00%> (+1.53%)
:arrow_up:

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@tkatila @mythi

I'd avoid having qat specific args in the operator cli. @mythi 's proposal for having the annotation as default and then allowing user to change it by modifying the CR seems like a better option.

Thanks, preliminary makes sense, will take a look at this option.

@tkatila @mythi
I haven't found a good way to provide a kustomization without moving / duplicating the sample CR deployment (deployments/operator/samples/deviceplugin_v1_qatdeviceplugin.yaml), so resorted to documenting the annotation configurability through CR.

@tkatila @mythi
Updated to congfigure only existing annotations in the daemonset, please take a look.


Support for asyncio/aiobotocore?

I would like to use s3fs with asyncio/aiobotocore, so that I can download a file "in the background".  I don't have a deep enough understanding of asyncio, botocore or aiobotocore to know how challenging this would be to implement on a scale from trivial to nearly impossible.
My use case is that I am generating three inputs.  One comes from a tape drive archive and may involve a long wait (maybe half an hour), another involves downloading from an S3 bucket (similar time), and a third involves an involved CPU calculation.  Although I am new to asyncio I think it should be suitable for performing the tape archive download and the S3 download "in the background" while performing the CPU calculation.

I imagine this might be easier if botocore natively supported asyncio, but it currently doesn't and might never: https://github.com/boto/botocore/issues/458

I think you should be able to drop in an aiobotocore session or client for the botocore one. Of course, the calls within s3fs itself are not async, but it is something that I think many people would appreciate (along with the rest of fsspec-based implementations).
For your immediate needs, you might want to consider running your two IO tasks in threads, for which the code doesn't need to change at all.

Thanks for the advice.  Perhaps threads are the easier solution for me right now.


Research Docker (Tier 0)

Research docker
The team unanimously agrees to not utilize docker for capstone due to time constraints and the technical challenge imposed by the steep learning curve, instead, we will use Code Sandbox.

We agree.


[v1.13] bpf: lb: un-break terminating backends for service without backend

Manual backport of

[ ] #31840 (adjustments as some recent cleanups were missing. Also massage the BPF test, as the test framework in v1.13 doesn't have any of the helpers it was using)

Once this PR is merged, a GitHub action will update the labels of these PRs:
 31840

/test-backport-1.13

/test-backport-1.13

/test-backport-1.13

/test-1.16-4.19

/test-1.17-4.19

/test-1.20-4.19

/test-1.16-4.19

/test-1.17-4.19

/test-1.17-4.19

/test-1.17-4.19

/test-1.17-4.19

/test-1.17-4.19

/test-1.17-4.19

/test-1.17-4.19

/test-1.17-4.19


MissingSuperCall never reports

Expected Behavior
MissingSuperCall will report when the super call is missing.
Observed Behavior
I can not get the rule to ever report.
Steps to Reproduce

activate the MissingSuperCall rule with its default configuration
Include this code in a kotlin/jvm module:

open class ASuperClass {
    @OverridingMethodsMustInvokeSuper
    open fun superFun() = Unit
}
class BreaksDetektRule: ASuperClass() {
    override fun superFun() {
    }
}

Run detekt
Observe no issues are reported

Your Environment

Version of detekt used: Commit 7675ae87250594f16184069f7ac2c300d86ed070
Version of Gradle used (if applicable): 8.8

Are you running with Types Resolution?

Are you running with Types Resolution?

Can you answer this? How are you executing detekt? Which detekt task are you running?

Hi, @mgroth0 there is already one TC(super method has OverridingMethodsMustInvokeSuper annotation) similar to you case. Did you add somehow override mustInvokeSuperAnnotations in MissingSuperCall rule where javax.annotation.OverridingMethodsMustInvokeSuper is set?
Also, can you add the link to your detekt.yml from your reproducer project? I tried but couldn't find any

Hi @mgroth0 ahh I see this is added for 2.0.0 branch so it will not be available for the previous stable release.

I don't know if detekt publishes stable development builds
This rule will only be stable with the releae of 2.0.0

But since this rule is disabled by default you need to enable it. Also, you need to add the config like below
MissingSuperCall:
    active: true
    mustInvokeSuperAnnotations: ['androidx.annotation.CallSuper', 'javax.annotation.OverridingMethodsMustInvokeSuper']

mustInvokeSuperAnnotations is used to configure the annotations where you want this rule to be invoked
Your msg indicates that since detekt is not running with the type resolution this rule is being skipped.
You detektAll task which I can see in your project is defined like below
tasks.register("allDetekt") {
    dependsOn(tasks.withType<Detekt>())
}

Since it depends on Detekt I think it will not be depending on the type resolution version.
You can update your task to like below(syntax might be wrong please cross check):
tasks.register("allDetekt") {
    dependsOn(tasks.named("detektDebug")) // Here I am using `detektDebug` which is using type resolution
}

Hi, @mgroth0 I cloned your repo and somehow I am not able to run even a single rule(I added other issues as well in the code but none got reported). So I am not sure if this issue with your project or some configuration

Hi, @mgroth0 updated the original comment. In the project when you run detekt task, is detekt able to report any issue?

Hi, @mgroth0 sorry for the late reply, I got the chance to look into the newest reproducer and your added violation(empty catch) is getting reported by the detekt. I am unsure why I could not run my enabled rules in your project.
But I added the below code in your project
open class ASuperClass {
    @OverridingMethodsMustInvokeSuper
    open fun superFun() = Unit
}

class BreaksDetektRule : ASuperClass() {
    override fun superFun() {
    }
}

annotation class OverridingMethodsMustInvokeSuper

Just after the line 20 in your MyComposeAndroidActivity.kt and added mustInvokeSuperAnnotations: ['androidx.annotation.CallSuper', 'javax.annotation.OverridingMethodsMustInvokeSuper', 'bug.OverridingMethodsMustInvokeSuper', 'android.annotation.CallSuper'] in the MissingSuperCall rule like below
potential-bugs:
  active: true
  MissingSuperCall:
    active: true
    mustInvokeSuperAnnotations: ['androidx.annotation.CallSuper', 'javax.annotation.OverridingMethodsMustInvokeSuper', 'bug.OverridingMethodsMustInvokeSuper', 'android.annotation.CallSuper']

and I am able to get the violation by detekt
potential-bugs
	MissingSuperCall - [Overriding method is missing a call to overridden super method.] at /Users/atulgup/Learning/open_source/detekt-7582/src/main/kotlin/bug/MyComposeAndroidActivity.kt:28:5

I hypothesise that since you are using androidx.activity.ComponentActivity which has base class of android.app.Activity with the annotation android.annotation.CallSuper on onDestroy method, this was not getting detected. Here android.annotation.CallSuper is unrecognised in the project(so in the actual analysis this will not be resolved).
Can you try this with androidx activity?

So this leads me to conclude that MissingSuperCall might not work if the super class is from a dependency. For this, we have to create a sample project proving the same. Actually, I think in the Activity class the actual CallSuper is not added to your project. These types of classes are classified as NonExistence class from the kotlin compiler analysis

OK, closing this one in favour of the other issue. If you think this should be still open please comment here.


Add US flag to phone input country code dropdown box

In the PhoneInput web component, the US flag picture was added to the country code dropdown box.
Issue Type
Feature Request
Component or Pattern Affected

Expected Behavior

Desired Outcome in image below:

Current Behavior

Closed with #855


Update for Version 10

As expected beta 0.4.1 doesn't work on version 10 of the server. The following error is thrown on startup.
[23:14:09.507] [24] [Error] [Eco] Failed to start the server. Exception was Exception: ReflectionTypeLoadException
Message:Unable to load one or more of the requested types.

Source:System.Private.CoreLib

System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types.

   at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
   at System.Reflection.Assembly.GetTypes()
   at Eco.Shared.Utils.ReflectionCache.<>c.<GetTypesCached>b__10_0(Assembly a)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at Eco.Shared.Utils.ReflectionCache.GetTypesCached(Assembly assembly)
   at Eco.Shared.Utils.ReflectionCache.<>c.<GetGameAssembliesTypes>b__21_0(Assembly assembly)
   at System.Linq.Enumerable.SelectManySingleSelectorIterator`2.MoveNext()
   at Eco.Core.Serialization.SimpleSerializer.InitializeSerializableTypes()
   at Eco.Core.Serialization.SimpleSerializer..cctor()
System.TypeLoadException
Outer Exceptions:
One or more errors occurred. (Exception has been thrown by the target of an invocation.)
Exception has been thrown by the target of an invocation.
One or more errors occurred. (The type initializer for 'Eco.Core.Serialization.SimpleSerializer' threw an exception.)
The type initializer for 'Eco.Core.Serialization.SimpleSerializer' threw an exception.

[23:14:14.512] [24] [ Info] [Eco] Shutdown finished

[23:14:14.512] [24] [Error] [Eco] Errors report:
Failed to get derived types for 'Eco.World.Blocks.Block' in assembly 'EcoLawExtensionsMod, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' (usually safe to ignore for third party assembly). Error message: Unable to load one or more of the requested types.
: 1
Failed to start the server. Exception was Exception: ReflectionTypeLoadException
Message:Unable to load one or more of the requested types.

Source:System.Private.CoreLib

System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types.

   at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
   at System.Reflection.Assembly.GetTypes()
   at Eco.Shared.Utils.ReflectionCache.<>c.<GetTypesCached>b__10_0(Assembly a)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at Eco.Shared.Utils.ReflectionCache.GetTypesCached(Assembly assembly)
   at Eco.Shared.Utils.ReflectionCache.<>c.<GetGameAssembliesTypes>b__21_0(Assembly assembly)
   at System.Linq.Enumerable.SelectManySingleSelectorIterator`2.MoveNext()
   at Eco.Core.Serialization.SimpleSerializer.InitializeSerializableTypes()
   at Eco.Core.Serialization.SimpleSerializer..cctor()
System.TypeLoadException
Outer Exceptions:
One or more errors occurred. (Exception has been thrown by the target of an invocation.)
Exception has been thrown by the target of an invocation.
One or more errors occurred. (The type initializer for 'Eco.Core.Serialization.SimpleSerializer' threw an exception.)
The type initializer for 'Eco.Core.Serialization.SimpleSerializer' threw an exception.
: 1

Fixed in beta 0.5.0


Editing item's damages instead of level

Hi ! Excellent work at first 💯
This is not an issue, it's an idea of feature.
Here is the context : In-game items like FireworkArrow can deal a certain amount of damage based on his level and power, for example FireworkArrow at level 105 with a power of 11.42291355133057 will deal 4044 damages.
See my sample of values extracted from my character save for the FireworkArrow
POWER        LEVEL   DAMAGES
11.42291355133057 => 105   => 4044
11.48235321044922 => 105   => 4143
11.48703765869141 => 105   => 4151
11.48834228515625 => 105   => 4153
11.49747276306152 => 105   => 4169
11.5050516128540 => 106   => 4182
11.79001903533936 => 108   => 4695
12.14500808715820 => 112   => 5423
For the same level, you can have different power resulting in different damages number
Is it possible to implement a way to directly edit the damages of an item instead of his level ?
Then the level will be a readonly value ?
Thanks for reading this :)

That's definitely possible. One thing that would make this tricky is that I'm trying to mimic a similar interface as you would see in game (so that it's intuitive and easy to use). So if I added the feature to be able to modify the power value directly, it might not be as quickly understandable. I'm open to designs and ideas if you have any 😄 .


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter emporia for common errors and appropiate suggestions to keep this adapter up to date.
Please see the result of the check below.
ioBroker.emporia
   -

ERRORS:

[ ] :heavy_exclamation_mark: [E026] "{'engines': {'node'>='16'}}" is required at package.json, "{'engines':{'node'>='18'}}" is recommened
[ ] :heavy_exclamation_mark: [E033] @iobroker/adapter-core 2.6.7 specified. 3.1.4 is required as minimum, 3.1.6 is recommended. Please update dependencies at package.json
[ ] :heavy_exclamation_mark: [E036] @iobroker/testing 4.1.0 specified. 4.1.3 is required as minimum,  4.1.3 is recommended. Please update devDependencies at package.json
[ ] :heavy_exclamation_mark: [E162] js-controller 3.3.22 listed as dependency but 4.0.24 is required as minimum, 5.0.19 is recommended. Please update dependency at io-package.json.
[ ] :heavy_exclamation_mark: [E204] Versions "0.0.13, 0.0.11, 0.0.8, 0.0.7" listed at common.news at io-package.json do not exist at NPM. Please remove from news section.

WARNINGS:

[ ] :eyes: [W040] "keywords" within package.json should contain "ioBroker"
[ ] :eyes: [W115] "common.tier" is required in io-package.json. Please check https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/objectsschema.md#adapter.
[ ] :eyes: [W181] "common.license" in io-package.json is deprecated. Please define object "common.licenseInformation"
[ ] :eyes: [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
[ ] :eyes: [W202] Version of package.json (0.0.13) doesn't match latest version on NPM (0.0.12)
[ ] :eyes: [W522] Please consider migrating to admin 5 UI (jsonConfig).

Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be considered as a suggestion and be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence

This issue has been replaced by new isse #62
This issue can be closed.
your
ioBroker Check and Service Bot


latestarts to extract_candidate_symmetryvectors

Yeah- I just noticed that. Let me try to see if I can fix it


Feature Request: Runnables

Description
Zed has introduced Runnables, which display a play ⏯ button next to main() test functions etc to enable easy running of tests and runnable code based on treesitter.
Would love to see this supported in zed-v as well.
The changes are simple, just include a runnables.scm defining what treesitter components should show the buttons.
References:

Blog and details (see Runnables section)
golang runnables.scm implementation
golang rs source

I have zero experience with rust or treesitter. I looked at the code, and it will take me a while to get to the bottom of it to open a PR. So opening a feature request here - in case someone is gracious enough to add it to the repo.
I have greatly enjoyed coding in V with zed. It's super-stable and helpful.

Check out the README for how to use runnables.


Set more explicit path for finding correct package.json

[ ] Build docker image
[ ] Test on staging

👍

👍


Update Fees

Make values for  fast and fastest necessary (not optional). If there is any chain, which provides one fee only, we will set same value for average, fast, fastest.
HAVE
export type Fees = {
  type: FeeType
  fastest?: BaseAmount
  fast?: BaseAmount
  average: BaseAmount
}

WANT
type Fees = {
    type: FeeType
    fastest: BaseAmount
    fast: BaseAmount
    average: BaseAmount
};```

@veado what is expected when there is no options for fee ? just return everywhere the same value ?

If there is any chain, which provides one fee only, we will set same value for average, fast, fastest.

@thatStrangeGuyThorchain  Yes ^


[release-4.10] Bug 2052339: degraded webhook conditions to errors

Rename the following conditions so that they do not get rolled up into the overall Degraded status:
-MutatingAdmissionWebhookConfigurationDegraded
-ValidatingAdmissionWebhookConfigurationDegraded
-CRDConversionWebhookConfigurationDegraded
-VirtualResourceAdmissionDegraded
We will gather insights from connected customers in the future to determine if we can re-add these conditions to the overall Degraded status without impacting customer clusters.
cherry pick from https://github.com/openshift/cluster-kube-apiserver-operator/pull/1313

/assign @sanchezl

/label backport-risk-assessed

/retest

/retest e2e-upgrade

/test e2e-upgrade


[KYUUBI #4338] Bump Spark from 3.3.1 to 3.3.2

Why are the changes needed?
close #4338 .
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Updated the description as close #4338 . to make sure it's properly linked to the issue.

Hi @bowenliang123, that is not necessary if PR has a proper title-prefix

Hi @bowenliang123, that is not necessary if PR has a proper title-prefix

Got that.

@a49a Rebase to master branch with https://github.com/apache/kyuubi/pull/4340 merged, to fix docs building error (https://github.com/apache/kyuubi/actions/runs/4191677087/jobs/7266357199#step:4:95).

@bowenliang123 I have rebased the master branch. Thank you for your review.

Some Hive Connector tests failed, cc @Yikf

The root cause looks like is FileWriterFactory#jobId is not serializable, It was introduced in https://github.com/apache/spark/pull/38980, will take a look.

The failure is resolved by https://github.com/apache/kyuubi/pull/4359, merged to master/1.7


client module enhancement to use CompletableFuture to handle two or more threads  asynchronous computation

client module implement to use CountDownLatch to handle threads wait.
Add some new methods to java CompletableFuture to handle two or more threads  asynchronous computation

Is There any way create unit tests?

 add new feature method for client module.


Show indication that a build is waiting on other builds to finish

as we have QoS for builds some customers are reporting that their builds are "stuck" in New and are confused.
This mostly happens on clusters that have a lot of builds and QoS enabled.
It would be awesome if we can show customers some indication that the build is waiting on other builds to finish, maybe even with an indication how many builds are in front of it?

So it seems this already exists, but in at least the case I'm looking at the Pending status is really delayed, here an example where the status is not updated for minimum 6 mins.


Whether Skywalking can provide code-level visibility？

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion

Question

In the use of the process found that Skywalking call link can only to the request level, there is no specific code details, which compared with the Pinpoint below：
1）Pinpoint can see the concrete class and the method invocation situation

2）Skywaking can only see the invocation of service requests

Which company or project?
personal

Requirement or improvement

Please describe about your requirements or improvement suggestions.
Do I need to add additional configurations if I want to achieve code-level visibility?

First of all, we are not competing with Pinpoint. We have our own landscape and design goals, read Concepts and Designs. We have users in different languages and different scenarios(including tracing, APM and service mesh observability).
So, please, if you want to know something, just ask the question, don't involve pinpoint thing in, which could cause unnecessary discussion.
If you want to trace more methods, read optional plugins, at least the following three will help you, especially the last one is super powerful to enhance codes without plugin development.

Trace Spring annotation beans
Gson serialization lib in optional plugin folder
Customize enhance Trace methods based on description files, rather than write plugin or change source codes.


Test and document assigning task roles

https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_IAM_role.html


Packing ints into a vec4 in a shader does not currently work

Apparently bitwise operations are not available in the current version of webgl (??!!!??), meaning ints and uints can't easily be packed into the vec4 color output and unpacked in javascript again.
It may be possible to use these functions to emulate bitwise operations.

WebGL2 will come with bit-shift operators and higher-precision textures, both of which can fix this issue

ThreeJS WebGL2Renderer Issue: https://github.com/mrdoob/three.js/issues/9965

You can do it webgl you just need to do the shifting youtself
/**
* Properly encoding 32 bit float in rgba from here:
* http://www.gamedev.net/topic/486847-encoding-16-and-32-bit-floating-point-value-into-rgba-byte-texture/
*/
vec4 pack( const in float depth ) {
    const float toFixed = 255.0/256.0;
    vec4 result = vec4(0);
    result.r = fract(depth*toFixed*1.0);
    result.g = fract(depth*toFixed*255.0);
    result.b = fract(depth*toFixed*255.0*255.0);
    result.a = fract(depth*toFixed*255.0*255.0*255.0);
    return result;
}

void main() {
  gl_FragColor = pack(gl_FragCoord.z);
}

Thanks @DanielJoyce!
I'd considered packing the values manually -- I'll probably get around to it at some point!


ButtonView tapped trigger

I use ButtonView within a CollectionView to allow users to navigate to the detail of the item they clicked. However, when the user wants to scroll the TappedCommand gets executed. This does not happen if I use the native TapGestureRecognizer on a Grid for example. The tap is recognized correctly.
Is this intended behavior or is it a bug?

It's not an expected behavior. On which platform do you face this issue?

Android 33, both emulator and physical devices. I just notice it doesn't happen every time and at some places within the application, it works as expected. Going to investigate further and add more details.

Thanks for you demo, I found it.
The following line causes the problem:
https://github.com/enisn/UraniumUI/blob/b31b3d2cb20d10da9e0653c97ae5ddef06647713/src/UraniumUI.Material/Handlers/ButtonViewHandler.Android.cs#L54
It invokes tepped command even event is cancelled.


Update VecMap to 0.6

@alexbool
This is the new PR for your commit - no further action required, all rebasing is good!

@homu r+

:pushpin: Commit 150784a has been approved by kbknapp

:hourglass: Testing commit 150784a with merge e2c104c...

:sunny: Test successful - status


ERROR (Kamal::ConfigurationError): unknown key: traefik

As the title says we are getting this error without making any changes to the code except for the gem update to 1.9.2
Thing is that in the Gemfile
kamal version command return: 2.3.0 is it normal?
We are unable to deploy and we don't want to switch to Kamal 2 for now.
Also kamal downgrade is not usable even if we are using Kamal 1.9.2, returning ERROR (Kamal::ConfigurationError): unknown key: traefik too
Do we need to apply kamal 2 changes to the Kamal 1.9.x too?
Gemfile
group :development do
  gem 'kamal', '~> 1.9.0'
end

Deploy.yml snippet
traefik:
  options:
    publish:
      - 443:443
      - 8080:8080
    volume:
      - "./acme_certs:/acme_certs"
  args:
    api.dashboard: true
    api.insecure: true
    providers.http.endpoint: http://xxxxxxxx/traefik/config
    providers.http.pollInterval: "5s"
    entryPoints.web.address: ":80"
    entryPoints.websecure.address: ":443"
    certificatesResolvers.letsencrypt.acme.email: "xxxxxxx"
    certificatesResolvers.letsencrypt.acme.storage: "/acme_certs/acme.json"
    certificatesResolvers.letsencrypt.acme.caServer: "https://acme-v02.api.letsencrypt.org/directory"
    certificatesResolvers.letsencrypt.acme.httpchallenge: true
    certificatesResolvers.letsencrypt.acme.httpchallenge.entrypoint: web

@ghillahill you should either use a binstub ./bin/kamal or bundle exec bundle exec kamal.
kamal version returns 2.3.0 because you didn't specify what exact installation of the Kamal you are launching.

I'm having the same problem with kamal 2.3.0

Kamal 2.x replaced Traefik with kamal-proxy and so the traefik key in the config file is not valid anymore.

Thank you @igor-alexandrov
It is very easy to add tls now. All it took me was setting the proxy:
proxy:
  ssl: true
  host: ecample.com
  app_port: 3000

My problem was the port 443 not being open in the hosting service.

Great! I also can suggest you to include Thruster in your bundle and expose port 80 instead of 3000 on the container.


Cannot read property 'toISOString' of undefined

UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'toISOString' of undefined`

I believe this is caused by not handling all possible semver diff types, like premajor
https://github.com/stefanpenner/supported/blob/main/lib/time/index.js#L114
https://github.com/stefanpenner/supported/blob/15db2bbbabc2ffaf8da87948a2108151e2cd8be5/lib/time/index.js#L71-L75

I believe the crux of the issue here is that getLatest will literally return the latest version, which may be a prerelease. I believe we actually want to ignore prereleases for our purposes.
https://github.com/stefanpenner/supported/blob/main/lib/util.js#L40-L42


Clippy warnings

Whatever popped up while running
cargo clippy --workspace --all-targets --all-features -- -Dwarnings

Clippy warnings block merging of PRs for example, #11110.
Fixes #11121.

Merging as trivial to unblock CI.


docs incorrect for adding extra daemon using supervisord

Is there an existing issue for this?

[X] I have searched the existing issues

Output of ddev debug test
Expand `ddev debug test` diagnostic information
huzaifa@huzaifamustafa:~/code/shopware$ ddev debug test
Running bash [-c /tmp/test_ddev.sh]
======= Existing project config =========
These config files were loaded for project shopware: [/home/huzaifa/code/shopware/.ddev/config.yaml]
name: shopware
type: shopware6
docroot: public
php_version: 8.1
webserver_type: apache-fpm
webimage: drud/ddev-webserver:v1.21.5
router_http_port: 80
router_https_port: 443
additional_hostnames: []
additional_fqdns: []
database: {mysql 8.0}
mailhog_port: 8025
mailhog_https_port: 8026
phpmyadmin_port: 8036
phpmyadmin_https_port: 8037
project_tld: ddev.site
use_dns_when_possible: true
composer_version: 2
nodejs_version: 18
default_container_timeout: 120
======= Creating dummy project named  tryddevproject-2592 in ../tryddevproject-2592 =========
OS Information: Linux huzaifamustafa 5.15.0-73-generic #80~20.04.1-Ubuntu SMP Wed May 17 14:58:14 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
User information: uid=1000(huzaifa) gid=1000(huzaifa) groups=1000(huzaifa),4(adm),24(cdrom),27(sudo),30(dip),46(plugdev),120(lpadmin),132(lxd),133(sambashare),998(docker)
DDEV version:  ITEM             VALUE
 DDEV version     v1.21.6
 architecture     amd64
 db               drud/ddev-dbserver-mariadb-10.4:v1.21.5
 dba              phpmyadmin:5
 ddev-ssh-agent   drud/ddev-ssh-agent:v1.21.5
 docker           24.0.2
 docker-compose   v2.15.1
 docker-platform  huzaifamustafa
 mutagen          0.16.0
 os               linux
 router           drud/ddev-router:v1.21.5
 web              drud/ddev-webserver:v1.21.5
PROXY settings: HTTP_PROXY='' HTTPS_PROXY='' http_proxy='' NO_PROXY=''
======= DDEV global info =========
Global configuration:
instrumentation-opt-in=true
omit-containers=[]
mutagen-enabled=false
nfs-mount-enabled=false
router-bind-all-interfaces=false
internet-detection-timeout-ms=3000
disable-http2=false
use-letsencrypt=false
letsencrypt-email=
table-style=default
simple-formatting=false
auto-restart-containers=false
use-hardened-images=false
fail-on-hook-fail=false
required-docker-compose-version=
use-docker-compose-from-path=false
project-tld=
xdebug-ide-location=
no-bind-mounts=false
use-traefik=false
wsl2-no-windows-hosts-mgt=false

======= DOCKER info =========
docker location: -rwxr-xr-x 1 root root 35927008 May 26 02:52 /usr/bin/docker
docker version:
Client: Docker Engine - Community
 Version:           24.0.2
 API version:       1.43
 Go version:        go1.20.4
 Git commit:        cb74dfc
 Built:             Thu May 25 21:52:22 2023
 OS/Arch:           linux/amd64
 Context:           default

Server: Docker Engine - Community
 Engine:
  Version:          24.0.2
  API version:      1.43 (minimum version 1.12)
  Go version:       go1.20.4
  Git commit:       659604f
  Built:            Thu May 25 21:52:22 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.21
  GitCommit:        3dce8eb055cbb6872793272b4f20ed16117344f8
 runc:
  Version:          1.1.7
  GitCommit:        v1.1.7-0-g860f061
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0
DOCKER_DEFAULT_PLATFORM=notset
======= Mutagen Info =========
======= Docker Info =========
Docker platform: huzaifamustafa
Using docker context: default (unix:///var/run/docker.sock)
docker-compose: v2.15.1
Using DOCKER_HOST=unix:///var/run/docker.sock
Docker version: 24.0.2
Able to run simple container that mounts a volume.
Able to use internet inside container.
Docker disk space:
Filesystem                Size      Used Available Use% Mounted on
overlay                 937.3G    161.4G    728.2G  18% /

Expected Behavior
The ddev re/start commands work as expected and the configuration works.
Actual Behavior
I get an error as follows. If I comment the Dockerfile content it works again.
#23 [drud/ddev-webserver:v1.21.5-shopware-built internal] load build context
#23 transferring context: 2B done
#23 DONE 0.0s

#24 [drud/ddev-webserver:v1.21.5-shopware-built 11/11] ADD .ddev/web-build/messengerconsume.conf /etc/supervisor/conf.d
#24 ERROR: failed to calculate checksum of ref 2YA4:BZWE:CQ73:GPVP:ZVTV:LOKD:F4AD:BSQ3:SMVG:OKGS:F53K:OHNO::tezlvh420vgrsz7jfljt5jzjs: failed to walk /var/lib/docker/tmp/buildkit-mount517480092/.ddev/web-build: lstat /var/lib/docker/tmp/buildkit-mount517480092/.ddev/web-build: no such file or directory
------
 > [drud/ddev-webserver:v1.21.5-shopware-built 11/11] ADD .ddev/web-build/messengerconsume.conf /etc/supervisor/conf.d:
------
', stderr='failed to solve: failed to compute cache key: failed to calculate checksum of ref 2YA4:BZWE:CQ73:GPVP:ZVTV:LOKD:F4AD:BSQ3:SMVG:OKGS:F53K:OHNO::tezlvh420vgrsz7jfljt5jzjs: failed to walk /var/lib/docker/tmp/buildkit-mount517480092/.ddev/web-build: lstat /var/lib/docker/tmp/buildkit-mount517480092/.ddev/web-build: no such file or directory'

Steps To Reproduce
I followed the steps as mentioned here:
https://ddev.readthedocs.io/en/latest/users/extend/customization-extendibility/#explicit-supervisord-configuration-for-additional-daemons

Create Dockerfile.messengerconsume in .ddev/web-build
Put content inside:

ADD .ddev/web-build/messengerconsume.conf /etc/supervisor/conf.d

Create messengerconsume.conf file in .ddev/web-build
Put script:

[program:messengerconsume]
command=/usr/bin/php /var/www/html/bin/console messenger:consume async --memory-limit=128M
autorestart=true
startretries=10

ddev restart

Anything else?
No response

If you don't want the daemon to keep running, then web_extra_daemons isn't for you. I don't know exactly how your daemon is supposed to run, but yes, if it exits all the time then that's not what you want. I'm not entirely sure that your supervisord config is your best option though either, although it may be fine.
Right now the problem is that the docker buildx can't access your files. I think the problem is that your context isn't right. You should just be doing
ADD messengerconsume.conf /etc/supervisor/conf.d
The docs at https://ddev.readthedocs.io/en/latest/users/extend/customization-extendibility/#explicit-supervisord-configuration-for-additional-daemons are incorrect. Could you click the pencil in the upper right and fix them?

I actually did the PR,

https://github.com/ddev/ddev/pull/4967

Thanks I think this change works and i didnt get any errors when starting

Thanks I think this change works and i didnt get any errors when starting

@rfay Hey, so the project is still shutting down after the command exists. The command I am using is a basic symfony command that consumes messages in the queue.
[program:messengerconsume]
command=/usr/bin/php /var/www/html/bin/console messenger:consume async --memory-limit=128M
autorestart=true
startretries=10

So after the memory limit is reached, the command generally shuts down and then the supervisor restarts it again. But at the moment it seems that the project also shuts down and I have to start the project again.
2023-06-07 06:31:39,891 INFO exited: messengerconsume (exit status 0; expected)
2023-06-07 06:31:40,900 INFO spawned: 'messengerconsume' with pid 2987
2023-06-07 06:31:40,902 WARN received SIGQUIT indicating exit request
2023-06-07 06:31:40,904 INFO waiting for child_exit_monitor, php-fpm, apache2, mailhog, messengerconsume to die
2023-06-07 06:31:40,906 WARN child_exit_monitor: bad result line: 'This line kills supervisor: ver:3.0 server:supervisor serial:0 pool:child_exit_monitor poolserial:0 eventname:PROCESS_STATE_EXITED len:94'
2023-06-07 06:31:40,906 WARN child_exit_monitor: has entered the UNKNOWN state and will no longer receive events, this usually indicates the process violated the eventlistener protocol
2023-06-07 06:31:44,429 INFO waiting for child_exit_monitor, php-fpm, apache2, mailhog, messengerconsume to die
2023-06-07 06:31:47,434 INFO waiting for child_exit_monitor, php-fpm, apache2, mailhog, messengerconsume to die
2023-06-07 06:31:50,440 INFO waiting for child_exit_monitor, php-fpm, apache2, mailhog, messengerconsume to die
2023-06-07 06:31:51,441 WARN killing 'messengerconsume' (2987) with SIGKILL
2023-06-07 06:31:52,475 INFO stopped: messengerconsume (terminated by SIGKILL)
2023-06-07 06:31:52,482 INFO stopped: mailhog (terminated by SIGTERM)
[Wed Jun 07 06:31:52.507178 2023] [mpm_prefork:notice] [pid 1941] AH00169: caught SIGTERM, shutting down
2023-06-07 06:31:52,508 INFO stopped: apache2 (terminated by SIGTERM)
[07-Jun-2023 06:31:52] NOTICE: Terminating ...
[07-Jun-2023 06:31:52] NOTICE: exiting, bye-bye!
2023-06-07 06:31:52,529 INFO reaped unknown pid 1941 (exit status 0)
2023-06-07 06:31:52,554 INFO stopped: php-fpm (exit status 0)
2023-06-07 06:31:52,555 INFO stopped: child_exit_monitor (terminated by SIGTERM)

I'm not at all sure what you're doing is the best way to run this service; I think you'd be better to find a way to have the process continue on serving. But the answer will be in understanding supervisord's behavior and configuration. Supervisord is set up here to exit when something goes wrong...

Check this documentation provided by Shopware

It is recommended to run one or more messenger:consume workers. To automatically start the processes again after they stopped because of exceeding the given limits you can use a process control system like systemd or supervisor.

Technically the command stops after a certain time limit or memory limit. So even if the process is stopped, it should not stop the whole project instance, correct? I mean, supervisor maybe restarts the service, but there is no project running for supervisor to restart the service after it is stopped.
https://developer.shopware.com/docs/guides/hosting/infrastructure/message-queue#message-queue-on-production-systems

If that's the expected behavior you can do something like while true; do <whatever> || true; done. Or start it another way with a script that does something like that.
You'll see that conf.d/supervisor.conf has
[eventlistener:child_exit_monitor]
command=/usr/local/bin/kill_supervisor.py
process_name=child_exit_monitor
events=PROCESS_STATE_FATAL,PROCESS_STATE_EXITED

You can obviously override that as well.

Thanks, using the script logic seems to not cause problems so far.


Update to system and container metric collectors to stop repeated errors from being logged

Proposed changes

Add make target to build oss images.
Update to system and container metric collectors to stop repeated errors from being logged

Checklist
Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING document
[x] If applicable, I have added tests that prove my fix is effective or that my feature works
[x] If applicable, I have checked that any relevant tests pass after adding my changes
[x] I have updated any relevant documentation (README.md)

Closing for now. There might be a cleaner way of resolving this issue.


dep ensure hangs if ssh key has a passphrase

ignore

Would be nice of you to post your solution :-)