crash on macos with SIGABRT

Prerequisites
Please answer the following questions for yourself before submitting an issue.

[ X] I am running the latest code. Development is very rapid so there are no tagged versions as of now.
[ X] I carefully followed the README.md.
[ X] I searched using keywords relevant to my issue to make sure that I am creating a new issue that is not already open (or closed).
[ X] I reviewed the Discussions, and have a new bug or useful enhancement to share.

Observed Behavior
I am running v0.1.57 of the program with model weights from https://huggingface.co/TheBloke/vicuna-7B-1.1-GGML on an intel based MacOS with 16GB RAM and 6GB of used memory. I have been able to install the application but when I try to run it I get this:
Python 3.10.2 (main, Feb  2 2022, 08:42:42) [Clang 13.0.0 (clang-13<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from llama_cpp import Llama
>>> llm = Llama(model_path="./models/vicuna-7b-1.1.ggmlv3.q5_1.bin")
llama.cpp: loading model from ./models/vicuna-7b-1.1.ggmlv3.q5_1.bin
llama_model_load_internal: format     = ggjt v3 (latest)
llama_model_load_internal: n_vocab    = 32000
llama_model_load_internal: n_ctx      = 512
llama_model_load_internal: n_embd     = 4096
llama_model_load_internal: n_mult     = 256
llama_model_load_internal: n_head     = 32
llama_model_load_internal: n_layer    = 32
llama_model_load_internal: n_rot      = 128
llama_model_load_internal: ftype      = 9 (mostly Q5_1)
llama_model_load_internal: n_ff       = 11008
llama_model_load_internal: n_parts    = 1
llama_model_load_internal: model size = 7B
llama_model_load_internal: ggml ctx size =    0.07 MB
llama_model_load_internal: mem required  = 6612.59 MB (+ 1026.00 MB per state)
.
llama_init_from_file: kv self size  =  256.00 MB
[1]    53197 abort      python3

The Python interpreter just crashes with a SIGABRT. there is no traceback printed on the screen.
Expected Behavior
no error
Environment and Context
Please provide detailed information about your computer setup. This is important in case the issue is not reproducible except for under certain specific conditions.

Physical (or virtual) hardware you are using, e.g. for Linux:

I am running on Mac OS Ventura with intel based 6 core CPU and 16GB of RAM. 6GB is used.

Operating System, e.g. for Linux:

$ uname -a
% uname -a
Darwin  22.5.0 Darwin Kernel Version 22.5.0: Mon Apr 24 20:51:50 PDT 2023; root:xnu-8796.121.2~5/RELEASE_X86_64 x86_64

SDK version, e.g. for Linux:

$ python3 --version
$ make --version
$ g++ --version

% python3 --version
Python 3.10.2

% make --version
GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for i386-apple-darwin11.3.0
% g++ --version
Apple clang version 14.0.3 (clang-14<IP_ADDRESS>.1)
Target: x86_64-apple-darwin22.5.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

Failure Information (for bugs)
https://gist.github.com/siddhsql/ea1d8b0289896a7a0748504f6802c8ac
Steps to Reproduce
see above.
Try the following:

git clone https://github.com/abetlen/llama-cpp-python
cd llama-cpp-python
rm -rf _skbuild/ # delete any old builds
python setup.py develop
cd ./vendor/llama.cpp
Follow llama.cpp's instructions to cmake llama.cpp
Run llama.cpp's ./main with the same arguments you previously passed to llama-cpp-python and see if you can reproduce the issue. If you can, log an issue with llama.cpp

I did try this and it works. please see below:
% ./bin/main -m ~/llm/llama-cpp-python/models/vicuna-7b-1.1.ggmlv3.q5_1.bin -p "Building a website can be done in 10 simple steps:" -n 512
main: build = 634 (5b57a5b)
main: seed  =<PHONE_NUMBER>
llama.cpp: loading model from /Users/xxx/llm/llama-cpp-python/models/vicuna-7b-1.1.ggmlv3.q5_1.bin
llama_model_load_internal: format     = ggjt v3 (latest)
llama_model_load_internal: n_vocab    = 32000
llama_model_load_internal: n_ctx      = 512
llama_model_load_internal: n_embd     = 4096
llama_model_load_internal: n_mult     = 256
llama_model_load_internal: n_head     = 32
llama_model_load_internal: n_layer    = 32
llama_model_load_internal: n_rot      = 128
llama_model_load_internal: ftype      = 9 (mostly Q5_1)
llama_model_load_internal: n_ff       = 11008
llama_model_load_internal: n_parts    = 1
llama_model_load_internal: model size = 7B
llama_model_load_internal: ggml ctx size =    0.07 MB
llama_model_load_internal: mem required  = 6612.59 MB (+ 1026.00 MB per state)
.
llama_init_from_file: kv self size  =  256.00 MB

system_info: n_threads = 6 / 12 | AVX = 1 | AVX2 = 1 | AVX512 = 0 | AVX512_VBMI = 0 | AVX512_VNNI = 0 | FMA = 1 | NEON = 0 | ARM_FMA = 0 | F16C = 1 | FP16_VA = 0 | WASM_SIMD = 0 | BLAS = 1 | SSE3 = 1 | VSX = 0 |
sampling: repeat_last_n = 64, repeat_penalty = 1.100000, presence_penalty = 0.000000, frequency_penalty = 0.000000, top_k = 40, tfs_z = 1.000000, top_p = 0.950000, typical_p = 1.000000, temp = 0.800000, mirostat = 0, mirostat_lr = 0.100000, mirostat_ent = 5.000000
generate: n_ctx = 512, n_batch = 512, n_predict = 512, n_keep = 0

 Building a website can be done in 10 simple steps:
1. Decide on the purpose of your website and what you want to achieve with it. This will help guide the design, content, and functionality of your site.
2. Choose a domain name that is easy to remember and reflects the purpose of your website. It should be unique and preferably short, as people are more likely to remember shorter names.
3. Choose a web hosting service that provides enough space and bandwidth for your needs. Some popular options include Bluehost, HostGator, and SiteGround.
4. Select a website builder or content management system (CMS) such as WordPress, Wix, Squarespace, or Shopify to create your site. These platforms make it easy to customize the design and layout of your site without needing any coding experience.
5. Choose a theme or template that matches the purpose and style of your website. This will give your site a professional look and feel, which is important for building credibility with visitors.
6. Create high-quality content that is relevant to your target audience and provides value to them. Keep in mind that search engines rank websites based on the quality and relevance of their content, so it’s essential to focus on creating useful and informative articles, blog posts, videos, and other types of media.
7. Optimize your website for search engines by including relevant keywords and phrases throughout your content, meta tags, and headings. This will help ensure that your site appears in the top results when people search for related topics.
8. Use social media to promote your website and engage with your audience. Share your content on platforms like Facebook, Twitter, LinkedIn, Instagram, and Pinterest to increase visibility and drive traffic to your site.
9. Analyze your website’s performance using tools such as Google Analytics or Jetpack by WordPress. This will help you track key metrics such as page views, bounce rates, and conversion rates so that you can make data-driven decisions about how to improve your site over time.
10. Continuously update and improve your website with fresh content, new features, and ongoing optimization efforts. This will help keep visitors engaged and coming back for more, which is essential for building a loyal following and achieving your goals. [end of text]

llama_print_timings:        load time = 10298.92 ms
llama_print_timings:      sample time =   371.18 ms /   488 runs   (    0.76 ms per token)
llama_print_timings: prompt eval time = 10278.37 ms /    14 tokens (  734.17 ms per token)
llama_print_timings:        eval time = 104839.56 ms /   487 runs   (  215.28 ms per token)
llama_print_timings:       total time = 115566.46 ms

Failure Logs
https://gist.github.com/siddhsql/ea1d8b0289896a7a0748504f6802c8ac

I stepped through the code in a debugger and it crashes here:
def llama_init_from_file(
    path_model: bytes, params: llama_context_params
) -> llama_context_p:
    return _lib.llama_init_from_file(path_model, params)

_lib is CDLL (libllama.so)
and params is equal to
llama_cpp.llama_cpp.llama_context_params object at 0x1061eb640>
special variables
embedding:
False
f16_kv:
True
logits_all:
False
n_ctx:
512
n_gpu_layers:
0
progress_callback:
<CFunctionType object at 0x106291780>
progress_callback_user_data:
None
seed:
1337
use_mlock:
False
use_mmap:
True
vocab_only:
False
_b_base_:
None
_b_needsfree_:
1
_fields_:
[('n_ctx', <class 'ctypes.c_int'>), ('n_gpu_layers', <class 'ctypes.c_int'>), ('seed', <class 'ctypes.c_int'>), ('f16_kv', <class 'ctypes.c_bool'>), ('logits_all', <class 'ctypes.c_bool'>), ('vocab_only', <class 'ctypes.c_bool'>), ('use_mmap', <class 'ctypes.c_bool'>), ('use_mlock', <class 'ctypes.c_bool'>), ('embedding', <class 'ctypes.c_bool'>), ('progress_callback', <class 'ctypes.CFUNC...tionType'>), ('progress_callback_user_data', <class 'ctypes.c_void_p'>)]
_objects:
None

adding some more notes for self: we do see this line in the output of llama-cpp-python: https://github.com/ggerganov/llama.cpp/blob/5c64a0952ee58b2d742ee84e8e3d43cce5d366db/llama.cpp#L2501
            fprintf(stderr, "%s: kv self size  = %7.2f MB\n", __func__, memory_size / 1024.0 / 1024.0);

so then the only code left is what comes afterwards... and it does work when running llama.cpp directly

it beats me. I added this code just before returning ctx from llama.cpp:
fprintf(stderr, "debug: returning ctx\n");
    return ctx;

and I see this in the output console:
llama_init_from_file: kv self size  =  256.00 MB
debug: returning ctx

and yet self.ctx is None in:
assert self.ctx is not None

how is this even possible?

running docker image errors out as well:
% docker run --rm -it -p 8000:8000 -v $PWD/models:/models -e MODEL=/models/$MODEL_NAME ghcr.io/abetlen/llama-cpp-python:latest
llama.cpp: loading model from /models/vicuna-7b-1.1.ggmlv3.q5_1.bin
Illegal instruction

am i the only one with this problem? can't be.

Illegal instruction usually indicates that a binary code is compiled for the wrong architecture, i.e. this is a compiler configuration issue.

adding some more info to help anyone who runs into this problem: i tried pyllamacpp and it works (nevermind the garbage output):
% pyllamacpp ~/llm/llama-cpp-python/models/vicuna-7b-1.1.ggmlv3.q5_1.bin

██████╗ ██╗   ██╗██╗     ██╗      █████╗ ███╗   ███╗ █████╗  ██████╗██████╗ ██████╗
██╔══██╗╚██╗ ██╔╝██║     ██║     ██╔══██╗████╗ ████║██╔══██╗██╔════╝██╔══██╗██╔══██╗
██████╔╝ ╚████╔╝ ██║     ██║     ███████║██╔████╔██║███████║██║     ██████╔╝██████╔╝
██╔═══╝   ╚██╔╝  ██║     ██║     ██╔══██║██║╚██╔╝██║██╔══██║██║     ██╔═══╝ ██╔═══╝
██║        ██║   ███████╗███████╗██║  ██║██║ ╚═╝ ██║██║  ██║╚██████╗██║     ██║
╚═╝        ╚═╝   ╚══════╝╚══════╝╚═╝  ╚═╝╚═╝     ╚═╝╚═╝  ╚═╝ ╚═════╝╚═╝     ╚═╝

PyLLaMACpp
A simple Command Line Interface to test the package
Version: 2.4.1

=========================================================================================

[+] Running model `/Users/xxx/llm/llama-cpp-python/models/vicuna-7b-1.1.ggmlv3.q5_1.bin`
[+] LLaMA context params: `{}`
[+] GPT params: `{}`
llama.cpp: loading model from /Users/xxx/llm/llama-cpp-python/models/vicuna-7b-1.1.ggmlv3.q5_1.bin
llama_model_load_internal: format     = ggjt v3 (latest)
llama_model_load_internal: n_vocab    = 32000
llama_model_load_internal: n_ctx      = 512
llama_model_load_internal: n_embd     = 4096
llama_model_load_internal: n_mult     = 256
llama_model_load_internal: n_head     = 32
llama_model_load_internal: n_layer    = 32
llama_model_load_internal: n_rot      = 128
llama_model_load_internal: ftype      = 9 (mostly Q5_1)
llama_model_load_internal: n_ff       = 11008
llama_model_load_internal: n_parts    = 1
llama_model_load_internal: model size = 7B
llama_model_load_internal: ggml ctx size =    0.07 MB
llama_model_load_internal: mem required  = 6612.59 MB (+ 2052.00 MB per state)
.
llama_init_from_file: kv self size  =  512.00 MB
...
[+] Press Ctrl+C to Stop ...
...
You: who is the president of usa?
AI: class MQL5_CALLBACK_TYPE
{
public:
	virtual bool OnTick() = 0;
};

class MQL5_EVENT_TYPE
{
public:
	virtual void Process() = 0;
};
```scss
class MQL5_ON_TRADING_EVENT_TYPE : public MQL5_EVENT_TYPE
{
public:
	void Process();
};

class MQL5_ON_ORDER_EVENT_TYPE : public MQL5_EVENT_TYPE
{
public:
	void Process();
};

class MQL5_ON_TAKE_PROFIT_EVENT_TYPE : public MQL5_EVENT_TYPE
{
public:
	void Process();
};

class MQL5_ON_STOP_LOSS_EVENT_TYPE : public MQL5_EVENT_TYPE
{
public:
	void Process();
};

class MQL5_ON_HEDGE_EVENT_TYPE : public MQL5_EVENT_TYPE
{
public:
	void Process();
};

class MQL5_ON_TRADE_END_EVENT_TYPE : public MQL5_EVENT_TYPE
{
public:
	void Process();
};

//...

// Register events
MQL5_ON_TRADING_EVENT_REGISTER(class MQL5_ON_TRADING_EVENT_TYPE);
MQL5_ON_ORDER_EVENT_REGISTER(class MQL5_ON_ORDER_EVENT_TYPE);
MQL5_ON_TAKE_PROFIT_EVENT_REGISTER(class MQL5_ON_TAKE_PROFIT_EVENT_TYPE);
MQL5_ON_STOP_LOSS_EVENT_REGISTER(class MQL5_ON_STOP_LOSS_EVENT_TYPE);
MQL5_ON_HEDGE_EVENT_REGISTER(class MQL5_ON_HEDGE_EVENT_TYPE);QL5_ON_TRADE_END_EVENT_REGISTER(class MQL5_ON_TRADE_END_EVENT_TYPE);//...
You:

Closing please reopen if the problem is reproducible with the latest llama-cpp-python which includes an updated llama.cpp


@cap-js/postgres - cds returns ResourceRequest timed out response.

Description of erroneous behaviour
Hello!
During project development I have faced a problem which seems to be related to the acquireTimeoutMillis and destroyTimeoutMillis values.
We use quite big view that takes some time to process on the server side. Sadly, it takes so long that it causes timeouts which breaks the application flow. Frontend application sends usually 4-7 requests in batch to the server. Usually, first requests are handled without issues but whenever we select something from this bigger view it has to process a lot of data - all following requests are getting timed out. This issue happens mostly when requests are sent in batches.  I can easily read this big entity without any issues.
Timeouts were appearing exactly 1 second after request was sent so we quickly found out that it might be something related to the postgres plugin.
Here is the error stacktrace from application logs
TimeoutError: ResourceRequest timed out
at ResourceRequest._fireTimeout (/home/vcap/app/node_modules/generic-pool/lib/ResourceRequest.js:62:17)
at Timeout.bound (/home/vcap/app/node_modules/generic-pool/lib/ResourceRequest.js:8:15)
at listOnTimeout (node:internal/timers:559:17)
at processTimers (node:internal/timers:502:7)
Active connections:1
Error: begin called from:
at Pool.acquire (/home/vcap/app/node_modules/@cap-js/db-service/lib/common/generic-pool.js:18:44)
at runMicrotasks (<anonymous>)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async PostgresService.acquire (/home/vcap/app/node_modules/@cap-js/db-service/lib/common/DatabaseService.js:105:12)
at async PostgresService.begin (/home/vcap/app/node_modules/@cap-js/db-service/lib/common/DatabaseService.js:65:16)
at async PostgresService._begin (/home/vcap/app/node_modules/@sap/cds/lib/srv/srv-tx.js:205:3)
at async CatService.<anonymous> (/home/vcap/app/node_modules/@sap/cds/libx/_runtime/common/generic/crud.js:73:16)
at async next (/home/vcap/app/node_modules/@sap/cds/lib/srv/srv-dispatch.js:79:17)
at async CatService.handle (/home/vcap/app/node_modules/@sap/cds/lib/srv/srv-dispatch.js:77:10)
at async _getCount (/home/vcap/app/node_modules/@sap/cds/libx/_runtime/cds-services/adapter/odata-v4/handlers/read.js:104:20

For now we managed to temporarily fix the issue by increasing the timeouts values in the source file source code So my question is whether this timeout time could be increased or somehow exposed for configuration in package.json.
Thanks in advance!
Details about project

Package
version

OData version
v4 / v2

Node.js version
v16.16

@sap/cds
7.5.2

@sap/cds-dk
7.3.0

@cap-js/postgres
1.4.1

@BartekCapgemini thanks for the report.
There does not seem to be an issue with the default acquire timeout. The problem is most likely related to the fact that the pool implementation has a default max size of 1. Which you can increase using the service configurations by adding it into the pool property. As you can see in the source code you linked here
The configuration should look something like.
{
  "cds": {
     "db": {
        "impl": "@cap-js/postgres",
        "pool": {
          "max": 10 // configured according to your predicted service load
        }
     }
  }
}

Additionally I would like to add that the nature of the Postgres network protocol results in that all queries are executed in sequence. So if you would have a large $batch request with a change set that has to execute many different queries inside the same transaction. It will execute them in sequence as the tcp connection is only able to process a single query at a time. While having many requests in side a $batch request outside of any changeset. They will execute in parallel and will greatly benefit from having a larger max configured.

@BobdenOs thank you for reply.
Luckily we were able to solve most of the performance issues with timeouts by optimizing the underlying requests to both service and database.
For testing purposes I restored default timeouts values (1000ms) an set up max pool to 10 to see if after all optimizations we will face the same issue. At first glance it was working properly but ResourceRequest timed out error still appears.
Issue happens when user request column (in the smart table, not as a part of larger batch since all other data is loaded beforehand) that is dynamically calculated on the postgres side. This particular column relies on some regular expressions and array calculations but runs just fine when queried on pgAdmin for example.  We still get timeouts after 30s so we had to once again increase default values in the source code.

Hi @BobdenOs ,
was just thinking: Should we enhance the PG Guide with some more configuration options? Or maybe add such information to the general database guide if the new db plugins share the same config properties?


Import Kibana Saved objects

Visualizations and Dashboard

seems like the files are missing EOL at the end of the file.
Should you break the visualizations into multiple files (perhaps 1 for each visualization). Bundling all together, the file may grow very large, very fast, also, it is hard to effectively use version control to easily identify which visualization changed and how it evolved over time.

done


Refactor service_cache to use pagination

TL;DR
Refactors the service cache to iterate over the remote service list via pagination.
Why?
As of early-2021 Fastly's /service API moved to a paginated interface via query params instead of always returning the full list of services, the list now defaults to 20.
To make matters more confusing, the new default of 20 will only be returned for newer customer accounts created after 2021-02-01, older customers will still get a full list if they request /service without any query params - which is likely why no users of this exporter have complained yet.
This should also have a slight performance boost for the exporter (and the Fastly API :wink:), as some larger Fastly customers can have 1000s of services which result in very large HTTP/JSON responses.
Note:
A lot of the diff is whitespace and thus better viewed with it disabled via: ?w=1

Cool! Overall approach looks good. I'll propose a few changes, probably as a PR to this PR if that's OK?

Cool! Overall approach looks good. I'll propose a few changes, probably as a PR to this PR if that's OK?

@peterbourgon Hai 👋🏻  - Yes, that's absolutely fine and whatever is easiest for you!

Thank you for tolerating my pathologies.


Events not fired with the latest version

Hi,
Events are not fired with the latest version, here is a Codesanbox example:
https://codesandbox.io/s/laughing-dan-hu4yly?file=/src/App.js

Any news on this? I get the same problem, and it’s quite annoying as we can’t customize the behavior…

All Events are lowercased, meaning onAfteredit, please follow the doc https://github.com/revolist/revogrid/blob/master/src/components/revo-grid/readme.md

https://codesandbox.io/s/crazy-boyd-8pzj53?file=/src/App.js:885-896


Don't set InformerWatchNamespace for cluster scoped resources

Please provide a description of this PR:
When using ISTIO_WATCH_NAMESPACE, I got:
k8s.io/client-go@v0.27.0/tools/cache/reflector.go:231:
failed to list *v1.PartialObjectMetadata: the server could not find the requested resource

We should not set watch namespace for cluster scoped resources
Maybe related to https://github.com/istio/istio/issues/45512

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests-arm64

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests-arm64

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests-arm64

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

integ-operator-controller_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-operator-controller

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests-arm64

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

integ-operator-controller_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-operator-controller

integ-pilot-istiodremote-mc_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests-arm64

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

integ-operator-controller_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-operator-controller

integ-pilot-istiodremote-mc_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests-arm64

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

integ-operator-controller_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-operator-controller

integ-pilot-istiodremote-mc_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-multicluster

integ-cni_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

failed to list *v1.PartialObjectMetadata: the server could not find the requested resource

Not sure i understand the error is related to namespace

What is your k8s version?

v1.26.0

probably, test it though

MCS is in alpha phase, we have registered its schema in pkg/kube/mcs/register.go  and also in func istioScheme

hold as all tests failed

/retest

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

integ-operator-controller_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-operator-controller

integ-pilot-istiodremote-mc_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-multicluster

integ-cni_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-cni

unit-tests-arm64_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai mind taking a look at the test failures?

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

integ-operator-controller_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-operator-controller

integ-pilot-istiodremote-mc_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-multicluster

integ-cni_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-cni

unit-tests-arm64_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests-arm64

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-operator-controller

integ-pilot-istiodremote-mc_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-multicluster

integ-cni_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-cni

unit-tests-arm64_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests-arm64

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-multicluster

integ-cni_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-cni

unit-tests-arm64_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests-arm64

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

integ-operator-controller_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-operator-controller

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-multicluster

integ-cni_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-cni

unit-tests-arm64_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests-arm64

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

integ-operator-controller_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-operator-controller

integ-pilot-istiodremote-mc_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-cni

unit-tests-arm64_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests-arm64

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

integ-operator-controller_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-operator-controller

integ-pilot-istiodremote-mc_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests-arm64

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

integ-operator-controller_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-operator-controller

integ-pilot-istiodremote-mc_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-multicluster

integ-cni_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck_istio

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

integ-pilot-istiodremote-mc_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-multicluster

integ-cni_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-cni

gencheck_istio
641591e33d7dd89fd3e19e158ab8f13438e90803
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck_istio

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

integ-pilot-istiodremote-mc_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-multicluster

integ-cni_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-cni

gencheck_istio
c5107687f1a5fdfc2386c9ee5fd8bd3d960f36df
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck_istio

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

integ-pilot-istiodremote-mc_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-multicluster

integ-cni_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-cni

gencheck_istio
c5107687f1a5fdfc2386c9ee5fd8bd3d960f36df
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck_istio

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

integ-pilot-istiodremote-mc_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-multicluster

integ-cni_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-cni

gencheck_istio
8587dbe128cc48063965919ed7a00e8ec2012a0d
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck_istio

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

integ-pilot-istiodremote-mc_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-multicluster

integ-cni_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-cni

gencheck_istio
c9b67032e8a9f0ab550992593889fa5fb89ce307
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck_istio

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test unit-tests

integ-ambient_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-ambient

integ-pilot-istiodremote-mc_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-istiodremote-mc

integ-pilot-multicluster_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-pilot-multicluster

integ-cni_istio
f4a00d987f08a8f8c8dd8b90c751fd15b76b40c9
link
true
/test integ-cni

gencheck_istio
000a5c43a9e317dd8d20091f367cdd43416a2e3b
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck_istio

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
3d7db5d59ba31c0abc78ff2fa7af4bd86baab2bf
link
true
/test integ-ambient

integ-operator-controller_istio
3d7db5d59ba31c0abc78ff2fa7af4bd86baab2bf
link
true
/test integ-operator-controller

integ-cni_istio
3d7db5d59ba31c0abc78ff2fa7af4bd86baab2bf
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
3d7db5d59ba31c0abc78ff2fa7af4bd86baab2bf
link
true
/test integ-ambient

integ-operator-controller_istio
3d7db5d59ba31c0abc78ff2fa7af4bd86baab2bf
link
true
/test integ-operator-controller

integ-cni_istio
3d7db5d59ba31c0abc78ff2fa7af4bd86baab2bf
link
true
/test integ-cni

lint_istio
d14f2c541640268891a7298c544e1b7891786a1d
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
3d7db5d59ba31c0abc78ff2fa7af4bd86baab2bf
link
true
/test integ-ambient

integ-operator-controller_istio
3d7db5d59ba31c0abc78ff2fa7af4bd86baab2bf
link
true
/test integ-operator-controller

integ-cni_istio
3d7db5d59ba31c0abc78ff2fa7af4bd86baab2bf
link
true
/test integ-cni

lint_istio
d14f2c541640268891a7298c544e1b7891786a1d
link
true
/test lint

gencheck_istio
d14f2c541640268891a7298c544e1b7891786a1d
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dddddai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-operator-controller_istio
3d7db5d59ba31c0abc78ff2fa7af4bd86baab2bf
link
true
/test integ-operator-controller

integ-cni_istio
3d7db5d59ba31c0abc78ff2fa7af4bd86baab2bf
link
true
/test integ-cni

lint_istio
d14f2c541640268891a7298c544e1b7891786a1d
link
true
/test lint

gencheck_istio
d14f2c541640268891a7298c544e1b7891786a1d
link
true
/test gencheck

integ-ambient_istio
d14f2c541640268891a7298c544e1b7891786a1d
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I would suggest first we should restore collections schema related stuff, and just keep the check for cluster scoped resource.
MCS is rarely used with istio

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
e3eec1c57a34b62d99b00a0671af330cb27dfcdf
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu ptal, you added the hold so I do not want to remove it myself

sure will take a look


Modified string's concatenations format to f-strings

Modified string's concatenations format to f-strings. Code became more clear and also we avoid potential type's mismatch

I'm sorry we don't accept pure style PRs.


Registery -> Registry

Pull Request Test Coverage Report for Build 308300611

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.006%) to 39.527%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/common/ports.ts
4
74.14%

Totals

Change from base Build 307497149:
0.006%

Covered Lines:
20217

Relevant Lines:
46860

💛  - Coveralls


Fixed bugs in multiple flow examples

Description
Fixed bugs, style issues, and removed the dependency on cvxopt in multiple flow examples (commodity_flow, create_graph, max_flow,  and leaky_edges).  This includes the changes suggested by choltz95 and mmusallam19 in #1926.
Please include a short summary of the change.
Issue link (if applicable): #1926
Type of change

[ ] New feature (backwards compatible)
[ ] New feature (breaking API changes)
[x] Bug fix
[ ] Other (Documentation, CI, ...)

Contribution checklist

[ ] Add our license to new files.
[x] Check that your code adheres to our coding style.
[ ] Write unittests.
[x] Run the unittests and check that they’re passing.
[x] Run the benchmarks to make sure your change doesn’t introduce a regression.

Merging, CI failures due to unrelated miniconda issue.


Use hosted JSON guidelines for TLS evaluation

Howdy folks. Author of the Mozilla TLS guidelines here. Thanks for the great tool! I'm actually looking at using it in a number of Go projects we run.
One improvement I'd suggest to make would be to use the JSON version of the guidelines instead of hardcoding the recommendations. We host the file at https://statics.tls.security.mozilla.org/server-side-tls-conf.json You can refer to it in the code and fall back to hardcoded defaults if the retrieval fails.
As an example, here is how we use the JSON recommendations in the evaluation worker in the TLS Observatory works: https://github.com/mozilla/tls-observatory/blob/master/worker/mozillaEvaluationWorker/mozillaEvaluationWorker.go

That's very handy, we are looking t making it config driven at the moment so this comes at the perfect time. Also thanks a bunch for the TLS guidelines themselves, fantastically useful to to have a good checklist to work to.

hmm... I wonder if we could somehow use https://blog.golang.org/generate here to pull down the latest rules at build time so we have a recent copy to fall back on should the mozilla service be unavailable or for offline scans?


Linux ~> Decode Error

Hello i get this error after push button run syncplay
my distro is Neon KDE
Traceback (most recent call last):   File "/usr/bin/syncplay", line 19, in <module>     SyncplayClientManager().run()   File "/usr/lib/syncplay/syncplay/clientManager.py", line 12, in run     interface.addClient(syncplayClient)   File "/usr/lib/syncplay/syncplay/ui/gui.py", line 323, in addClient     self.showErrorMessage("Failed to load some settings.")   File "/usr/lib/syncplay/syncplay/ui/gui.py", line 663, in showErrorMessage     self.newMessage(time.strftime(constants.UI_TIME_FORMAT, time.localtime()) + message + u"
") UnicodeDecodeError: 'ascii' codec can't decode byte 0xce in position 10: ordinal not in range(128) [1]    22560 segmentation fault  syncplay
Can anyone help me?

What is your system locale? Does it work fine in --no-gui mode?

Change line 663 of /usr/lib/syncplay/syncplay/ui/gui.py from:

   self.newMessage(time.strftime(constants.UI_TIME_FORMAT, time.localtime()) + message + u"
")

To:

   self.newMessage(time.strftime(constants.UI_TIME_FORMAT, time.localtime()).decode('utf-8') + message + u"
")

And let me know what happens.

ok thnx its work but add decode and on line 339 on same file.

Is eb22f5d1c80fa6a06f29a47735a222f92305d04a an appropriate fix?


URI.revive is not well typed

Today it is:
	static revive(data: UriComponents | any): URI {
        ...
    }

It should be something like:
    static revive(data: UriComponents): URI;
    static revive(data: UriComponents | undefined): URI | undefined;
    static revive(data: UriComponents | null): URI | null;
    static revive(data: UriComponents | null | undefined): URI | null | undefined;
    static revive(data: UriComponents | null | undefined): URI | null | undefined {
        ...
    }

cc @weinand

I was running into this issue when I changed some type from being a URL to URL[] and the "revive" would happily accept it...

Fixed.
@aeschli This is the only thing that now looks fishy: https://github.com/Microsoft/vscode/blob/261fa9f93910ec25a9836fcfe68d7f3cb4a6a06b/src/vs/workbench/electron-browser/window.ts#L529

Verified via review. @jrieken FYI you can avoid these casts:
https://github.com/microsoft/vscode/blob/8ef8aa6b3cb5b96870660fdd3bb8d0755e62fe51/src/vs/workbench/api/browser/mainThreadSearch.ts#L157-L168
Like this:
		dataOrUri.forEach(result => {
			if ('resource' in result) {
				searchOp.addMatch({
					resource: URI.revive(result.resource),
					results: result.results
				});
			} else {
				searchOp.addMatch({
					resource: URI.revive(result)
				});
			}
		});


Mod breaks if you use radar-booster

If you deploy a radar-booster then it breaks the mod and everybody just becomes a number

Hi,
Thanks for taking the time to write up this issue. If you could, it would be great if you would be able to answer the following:
When you say everybody just becomes a number, what actually happens? Do the map markers disappear leaving only a number, or the player models or?
As you can understand, reproducing things solo can be a pain, so it helps to know what the issue looks like
Thanks!

When you turn on a radar-booster, the order of the numbers is lost (if you write "switch 1", then a player who does not have number 1 is selected). If players start to leave or join, their names are mixed in the terminal, someone may get the name "Player #3", someone's number (on the map) may become, for example, 128 - such a person cannot be teleported.

ah yes, this is due to how the game does its reordering when the radars are added. I don't know if I am brave enough to modify that code, but I had noticed it in testing. Having said that, the new number assigned had worked for me in testing before. So it is a new issue that this now no longer works


Declaration file

Hi! Is there any update regarding the making of a declaration file for TypeScript?
I saw the pr #320 , but it doesn't seem that's going anywhere?
Complements for the efforts on this repo.

Thanks @lame-dev. I've been meaning to get to it, but haven't had the chance. We are pretty actively working on converting to TypeScript and streamlining the API. What is currently in master should be close to our final API if you want to contribute a declaration file!


new setting KEY_FILE_PATH not in ..../databases/bes_db/configsettings.properties

[Build] 16.1 fix3 15.12.2016 (pre fix4)
[Steps to reproduce]
The release notes for 16.1 fix4 state that
"A new configuration setting (KEY_FILE_PATH) is available in the configsettings.properties file
located in <install_pack_dir>/ databases/bes_db.
This setting is used for specifying the location of the file containing the key required for encryption
and decryption of service parameters with data type PWD or custom attributes marked for
encryption."
[Expected result]
KEY_FILE_PATH is found as an optional parameter in configsettings.properties
[Observed result]
KEY_FILE_PATH is not found in properties file
[Details]
Please enter parameter (not mandatory) with default value shown

I checked the file from the latest build and found the entry.

verified


Questions about the accuracy of eight commonsense reasoning datasets vs the Llama paper

Hi, thanks for the useful code for us! I have questions about the accuracy of commonsense reasoning tasks. In the readme, the accuracy of Llama (for example) is

While the Llama2 paper is

Some tasks have lower accuracy after fine-tuning, like 76.5 -> 68.9 for BoolQ. Could you kindly explain this to me? Thanks a lot!

same question

Given the MMLU performance referenced in the Llama2 paper, I believe the results in Table 20 reflect a 5-shot scenario, while LLM-Adapters' performance is primarily zero-shot.


LightPlane shader isn't visible on Oculus Quest 2

Describe the bug
A material created using LightPlane shader doesn't render/isn't visible on Oculus Quest 2.
To Reproduce
Steps to reproduce the behavior:

Create Material with LightPlane shader
Apply on any mesh
View apk on Oculus Quest 2
Mesh not visible

Expected behavior
Mesh should be visible on Oculus Quest 2 with LightPlane shader on it.
Unity details:

Flat Kit version: 1.5.5
Unity version: 2019.3.11f1
Graphics Pipeline: Bult-in
Development OS: Windows

Build platform:

Platform: Android
Test device: Oculus Quest 2

Hi,
Could you please create the project in URP and update to the latest Flat Kit (currently it's v. 2.1.5)?
From Unity's 2021 public roadmap (https://blogs.unity3d.com/2020/08/13/the-road-to-2021/) it seems that the Built-in RP is not being developed and will become obsolete it in the future. As a small studio, unfortunately we can't spend our time supporting a deprecated RP.
Please let us know (write an email to<EMAIL_ADDRESS>if this is critical for your project. If you need to work in Built-In RP and can't update to the latest Flat Kit, we're offering you a refund.

Hello, I will try v2.1.5 asap but unfortunately, I can't move to URP as the game has been built on built-in. I will test the latest version and get back to you.

I can confirm that it doesn't show up on v2.1.5 either (built-in).

Thank you for confirming. Please, write an email to<EMAIL_ADDRESS>and I'll request a refund for you.

Oh no, I love the asset too much so I don't want a refund. :) I'll try to make it work or find another solution. Thanks for the help!


Map must not be polled after it returned Poll::Ready

Bug Report

What version of TiKV are you using?

 ["Welcome to TiKV"]
 ["Release Version:   6.0.0-alpha"]
 ["Edition:           Community"]
 ["Git Commit Hash:   ab9bb0028e3df3bd55838acf83412c10e9964ad3"]
 ["Git Commit Branch: heads/refs/tags/v6.1.0-alpha"]
 ["UTC Build Time:    Unknown (env var does not exist when building)"]
 ["Rust Version:      rustc 1.60.0-nightly (1e12aef3f 2022-02-13)"]
 ["Enable Features:   jemalloc mem-profiling portable sse test-engines-rocksdb cloud-aws cloud-gcp cloud-azure"]
 ["Profile:           dist_release"]

What operating system and CPU are you using?

Steps to reproduce

run br_integration_test.
What did you expect?
test passed.
What did happened?
[2022-03-18T07:46:34.192Z] [2022/03/18 15:46:00.090 +08:00] [FATAL] [[lib.rs:468](http://lib.rs:468/)] ["Map must not be polled after it returned `Poll::Ready`"] [backtrace="   0: tikv_util::set_panic_hook::{{closure}}\n             at /home/jenkins/agent/workspace/d_tikv_multi_branch_v6.1.0-alpha/tikv/components/tikv_util/src/[lib.rs:467](http://lib.rs:467/):18\n   1: std::panicking::rust_panic_with_hook\n             at /rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/std/src/[panicking.rs:702](http://panicking.rs:702/):17\n   2: std::panicking::begin_panic::{{closure}}\n             at /rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/std/src/[panicking.rs:617](http://panicking.rs:617/):9\n   3: std::sys_common::backtrace::__rust_end_short_backtrace\n             at /rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/std/src/sys_common/[backtrace.rs:138](http://backtrace.rs:138/):18\n   4: std::panicking::begin_panic\n             at /rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/std/src/[panicking.rs:616](http://panicking.rs:616/):12\n   5: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll\n             at /rust/registry/src/[github.com](http://github.com/)-1ecc6299db9ec823/futures-util-0.3.15/src/future/future/[map.rs:62](http://map.rs:62/):17\n      <futures_util::future::future::Map<Fut,F> as core::future::future::Future>::poll\n             at /rust/registry/src/[github.com](http://github.com/)-1ecc6299db9ec823/futures-util-0.3.15/src/[lib.rs:93](http://lib.rs:93/):13\n   6: tikv_util::future::PollAtWake::poll\n             at /home/jenkins/agent/workspace/d_tikv_multi_branch_v6.1.0-alpha/tikv/components/tikv_util/src/[future.rs:145](http://future.rs:145/):19\n   7: <tikv_util::future::PollAtWake as futures_task::arc_wake::ArcWake>::wake_by_ref\n             at /home/jenkins/agent/workspace/d_tikv_multi_branch_v6.1.0-alpha/tikv/components/tikv_util/src/[future.rs:188](http://future.rs:188/):9\n      futures_task::waker::wake_by_ref_arc_raw\n             at /rust/registry/src/[github.com](http://github.com/)-1ecc6299db9ec823/futures-task-0.3.15/src/[waker.rs:54](http://waker.rs:54/):5\n   8: futures::task_impl::NotifyHandle::notify\n             at /rust/registry/src/[github.com](http://github.com/)-1ecc6299db9ec823/futures-0.1.31/src/task_impl/[mod.rs:657](http://mod.rs:657/):18\n      futures::task_impl::core::TaskUnpark::notify\n             at /rust/registry/src/[github.com](http://github.com/)-1ecc6299db9ec823/futures-0.1.31/src/task_impl/[core.rs:67](http://core.rs:67/):9\n      futures::task_impl::std::TaskUnpark::notify\n             at /rust/registry/src/[github.com](http://github.com/)-1ecc6299db9ec823/futures-0.1.31/src/task_impl/std/[mod.rs:204](http://mod.rs:204/):41\n      futures::task_impl::Task::notify\n             at /rust/registry/src/[github.com](http://github.com/)-1ecc6299db9ec823/futures-0.1.31/src/task_impl/[mod.rs:147](http://mod.rs:147/):9\n      futures::task_impl::atomic_task::AtomicTask::notify\n             at /rust/registry/src/[github.com](http://github.com/)-1ecc6299db9ec823/futures-0.1.31/src/task_impl/[atomic_task.rs:250](http://atomic_task.rs:250/):21\n   9: tokio_timer::timer::entry::Entry::fire\n             at /rust/git/checkouts/tokio-8e927faba632ed16/e8ac149/tokio-timer/src/timer/[entry.rs:251](http://entry.rs:251/):9\n      tokio_timer::timer::Timer<T,N>::process\n             at /rust/git/checkouts/tokio-8e927faba632ed16/e8ac149/tokio-timer/src/timer/[mod.rs:276](http://mod.rs:276/):13\n  10: tikv_util::timer::start_global_steady_timer::{{closure}}\n             at /home/jenkins/agent/workspace/d_tikv_multi_branch_v6.1.0-alpha/tikv/components/tikv_util/src/[timer.rs:196](http://timer.rs:196/):17\n      std::sys_common::backtrace::__rust_begin_short_backtrace\n             at /rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/std/src/sys_common/[backtrace.rs:122](http://backtrace.rs:122/):18\n  11: std::thread::Builder::spawn_unchecked_::{{closure}}::{{closure}}\n             at /rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/std/src/thread/[mod.rs:498](http://mod.rs:498/):17\n      <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once\n             at /rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/core/src/panic/[unwind_safe.rs:271](http://unwind_safe.rs:271/):9\n      std::panicking::try::do_call\n             at /rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/std/src/[panicking.rs:492](http://panicking.rs:492/):40\n      std::panicking::try\n             at /rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/std/src/[panicking.rs:456](http://panicking.rs:456/):19\n      std::panic::catch_unwind\n             at /rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/std/src/[panic.rs:137](http://panic.rs:137/):14\n      std::thread::Builder::spawn_unchecked_::{{closure}}\n             at /rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/std/src/thread/[mod.rs:497](http://mod.rs:497/):30\n      core::ops::function::FnOnce::call_once{{vtable.shim}}\n             at /rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/core/src/ops/[function.rs:227](http://function.rs:227/):5\n  12: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once\n             at /rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/alloc/src/[boxed.rs:1854](http://boxed.rs:1854/):9\n      <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once\n             at /rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/alloc/src/[boxed.rs:1854](http://boxed.rs:1854/):9\n      std::sys::unix::thread::Thread::new::thread_start\n             at /rustc/1e12aef3fab243407f9d71ba9956cb2a1bf105d5/library/std/src/sys/unix/[thread.rs:108](http://thread.rs:108/):17\n  13: start_thread\n  14: __clone\n"] [location=/rust/registry/src/[github.com](http://github.com/)-1ecc6299db9ec823/futures-util-0.3.15/src/future/future/[map.rs:62](http://map.rs:62/)] [thread_name=steady-timer]

detail is in tikv2.log
https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/10706/pipeline/117

@you06 ptal. It seems to be related to the timer updates.

It's possible to fix the problem in PollAtWait to detect being notified twice. But it seems strange that it can be notified twice in a timer and I also saw some strange case failure due to wrong timer step: https://ci.pingcap.net/blue/organizations/jenkins/tikv_ghpr_test/detail/tikv_ghpr_test/17795/pipeline/.

Is there anything like online configuration changes that will update the tick timeout dynamically?

/type bug
/severity Critical

I carefully review the PollAtWake again, even being notified twice, it's impossible for PollAtWake to poll the same future twice as it will take the future after it returns ready. So it's more likely that the future is being polled by two executors.

The thread "steady-timer" thread only poll timers created by SteadyTimer, and both using SteadyTimer and PollAtWake can only happen in
https://github.com/tikv/tikv/blob/5ee7d037d4e2e63d710410daac81baca7e9efe69/components/raftstore/src/store/fsm/store.rs#L455-L469
and
https://github.com/tikv/tikv/blob/5ee7d037d4e2e63d710410daac81baca7e9efe69/components/raftstore/src/store/fsm/store.rs#L670-L689
. However, both places can't schedule the map future twice.
/cc @sticnarf What do you think?

So it's more likely that the future is being polled by two executors.

I cannot think of a possibility of this case, either.
The only possibility that the future is being polled by two executors is that the first one is the thread calling poll_future_notify and the second one is the steady-timer itself.
But the state transition of PollAtWake prevents parallel polling of the same future. Only one thread can set the task to the POLLING state, so they cannot both fetch the future to poll...

Or there is an illegal memory access that updates the state of Map accidentally.


decode_function doesn't return function's name

Why don't return it?
While on it, the function could also be improved to return a NamedTuple, easier to use. Here is a suggestion:
@dataclass(frozen=True)
class DecodedFunctionArgument:
    name: str
    value: str
    type: str

@dataclass(frozen=True)
class DecodedFunction:
    name: str
    inputs: List[DecodedFunctionArgument]

def decode_function_v2(
    abi: List[dict], tx_input: Union[str, bytes]
) -> DecodedFunction:
    """Decode function transaction input

    Parameters
    ----------
    abi: List[dict]
        Contract ABI
    tx_input: Union[str, bytes]
        Transaction input to decode

    Returns
    -------
    DecodedFunction
        Decoded type-name-value tuples
    """
    selector_to_type_def = {}
    for type_def in abi:
        if type_def["type"] == "function":
            selector = function_abi_to_4byte_selector(type_def)
            selector_to_type_def[selector] = type_def

    tx_input = hex_to_bytes(tx_input)
    selector, args = tx_input[:4], tx_input[4:]
    if selector not in selector_to_type_def:
        raise InputDataError("Specified method not found in ABI")

    type_def = selector_to_type_def[selector]["inputs"]
    types, names = get_types_names(type_def)

    values = decode_abi(types, args)
    return DecodedFunction(
        selector_to_type_def[selector]['name'],
        [DecodedFunctionArgument(t, n, v) for t, n, v in zip(types, names, values)]
    )

You can use the InputDecoder instead.
https://github.com/kigawas/web3-input-decoder/blob/master/web3_input_decoder/decoder.py#L22
It's planned to return the name in decode_function from 0.2 release :)

Thanks!

0.1.3 has been released with InputDecoder just now


Painting the enclosure green can cause it to heat up

These Stevenson screen enclosures are white so that they reflect most sunlight and avoid heating up (and therefore heating up the air in/around them). Painting them green is probably causing them to heat up.
I realized this when I noticed the air temperature measurement jump ~5 C as soon as the sun hit the enclosure.

And here's another sensor heating up at about 9:10am local time, which must be when it was first exposed to direct sunlight today:

Yeah it's a problem I've thought a little bit about and it's a real tradeoff between the branding/marketing which increases adoption and deployment of the sensor vs the heating challenges. I did some initial testing where I put a temperature sensor in a painted enclosure vs a white one and placed them in the sun. The paint definitely causes a noticeable thermal rise (2-5 degrees c greater than white, but the temperatures are still well within the stable thermal range from the sensors data sheet (0-50 C), so I didn't think it was an actual problem.

@spestana looking at one of the sensors from this morning, it looks like yours actually went offline around the peak temperature. Is that because you powered off the sensor or something similar?

I also noticed that the co2 ppm started to get really noisy as the temperature rise was happening:

Perhaps the best compromise would be to just leave the enclosure white and keep the headpiece as green like this:

I set up another side-by-side comparison today just to get some additional data. I placed identical sensors in the normal white enclosure vs the green one as shown below. The sun is shining directly at these sensors right now.

There is a temperature rise above ambient in both cases, but the difference seems to be quite small. The blue curve below is the green sensor and the purple curve is the white sensor. The biggest difference seems to only be about 0.5 C. Given this, it's hard for me to believe that the green paint is really affecting the data in a negative way. Perhaps it's just best to advise that the sensor is placed in as shady an area as possible?
Does this conclusion make sense to you @spestana?

@spestana looking at one of the sensors from this morning, it looks like yours actually went offline around the peak temperature. Is that because you powered off the sensor or something similar?

Yes, it was unplugged for a while as I was seeing if I could move it elsewhere.

I also noticed that the co2 ppm started to get really noisy as the temperature rise was happening:

I'm guessing rapid changes in T or RH would cause something like this, since the co2 measurements are calculated in part with T and RH.

Perhaps it's just best to advise that the sensor is placed in as shady an area as possible?

Yes, shade (like the north side of a building in the N hemisphere) would be ideal.  Also don't want to be too close to the ground either (1-2 meters high).

Perhaps the best compromise would be to just leave the enclosure white and keep the headpiece as green like this:

Honestly, if they're kept in the shade, my guess is that this heating problem won't be an issue with the enclosures being green.
They do look nice all green :frog:

I also wanted to note that the temperature_offset might not be necessary with a new enclosure that separates the SCD30 and the RaspberryPi (the very awesome design I see in #18 @eaudiffred )

Indeed!

Closing out for now given that we've updated the instructions and will move to a 3D printed enclosure which will eliminate the painting.


integrate linalg gsoc2016 work

Feature branch:
https://github.com/shogun-toolbox/shogun/tree/feature/linalg_refactor
This requires:

removing all old linalg code
using the new parts, all tests need to pass
big cmake cleanup as linalg is not compile time anymore

@OXPHOS you could have a go at this to wrap up the project. No? :)

Sure np!

Needs to migrate:

Apply
Convolve
ElementSqaure (Not sure about this one as it's just a specialization of ElementProduct)
ElementUnary
MatrixProduct
SpecialPurpose (elementwise logistic function)
Can add:
Transpose (Currently in SGMatrix)
Optimization
ASSERT in unit-tests
Integrate in-place methods and the not in-place methods

What is the minimal set of things that we need in order to merge the feature branch?
Is that feasible before say april?

rebase :D

That will take some time. Let me know @OXPHOS if you need help with that. Otherwise I might just do it

@karlnapf @vigsterkr Sorry I missed this thread.
The things can be done pretty soon:

Cholesky
Sum
Clean up interfaces (in-place and non in-place methods)
Thread-safe GPU transfer methods
Can we aim for Mar 1st for the rebasing?

Most of the linalg methods are transfered except ElementUnary and SpecialPurpose.

I wanna keep some notes here and maybe we could discuss further on irc.

linalg::special_purpose():

Needs to be refactored to get rid of CGPU* classes.
Defined 7 methods, none of which is currently used in develop branch.
(So this should be a good entrance task if we still want to keep the methods)

linalg::ElementUnaryOperation():

Needs to be refactored to get rid of CGPU* classes.
I cannot integrate it with current linalg framework because it allows user-defined operators, which cannot fit the macros we're currently using in LinalgBackend*.
Not sure what to do with it.

This is merged so I am closing this one.
@OXPHOS can you update the project for the stuff you think that should be done and potentially open additional issues if there are things that other people also could do?


tenacity-beta: Add version 1.3-beta3-1

Closes https://github.com/ScoopInstaller/Extras/issues/10885

[x] I have read the Contributing Guide.

/verify

@HUMORCE

/verify

I can't I'm busy with Work.


Support device group in synchronization2

Gfxr didn't deal with device group for synchronization2, like QueueSubmit2. We need to figure out if we need to do something for it.
Now, the capturing crashes for device group. When it runs vkEnumeratePhysicalDeviceGroups, it runs EnumeratePhysicalDeviceGroups in generated_vulkan_api_call_encoders.cpp many times. It crashes in GetInstanceTable(instance)->EnumeratePhysicalDeviceGroups in the third time. I can't find out the reason why it runs so many times and why it crashes. When it runs vkEnumeratePhysicalDevices, it also runs EnumeratePhysicalDevices in generated_vulkan_api_call_encoders.cpp four times. But it doesn't crash.

After update to VulkanRT-<IP_ADDRESS>,  the vkEnumeratePhysicalDeviceGroups crash issue was fixed.

@locke-lunarg do you think this issue has gone away and should be closed?

Yes. It should be fixed by https://github.com/LunarG/gfxreconstruct/pull/828.


AtomOne Logo Design Competition: Official 'Upload Logo/Vote For Logo' Issue

Hello participants and voters of the AtomOne Logo Design Competition!
FOR DESIGNERS
Please upload your logo submissions right in the comments of this issue. The deadline for submissions is 13th of May 2024, 11:59 PM UTC.
Each valid submission must contain: Full Size Logo ( include an icon + typography ) Short Logo ( coin logo to be used as a token logo in UIs (wallets, explorers, trackers)).

you can submit the entry in any format
participants are permitted to submit designs previously shared in similar discussions under the https://github.com/atomone-hub GitHub repository, provided they are using the same account that was used for submitting the original design
each participant can submit up to maximum 2 individual entries
all logo entries should come in 3 colors out of which white and black are mandatory
the use of AI is not allowed
AiB may decide to split the reward if your work builds on work previously submitted on GitHub by someone else

FOR VOTERS
Anyone with a registered GitHub account can vote on the submissions, starting on the first day of the competition, meaning April 22nd, 2024 and running until the end of the voting period, which is May 20th, 2024, 11:59 PM UTC.
4 winners will be announced by May 31st, 2024, 11:59 UTC. Once announced, the winners will be reached out and rewarded, and their logos will be put on GovGen chain for assessing community’s sentiment. Please, read the README and Terms and Conditions for full details.

Hey guyz, glad to share my contribution to the chain!
Full vector design available in any suitable file format, all made using custom typos. Every detail, size, and shapes can be adjusted according to community feedback. Easily adaptable for 3D rendering. Colors' palette can be derived to anything you want.

@AidarItkulov Could a rebranding that could also involve the name of the chain be taken into consideration or would it violate the guidelines? I have an idea that I already shared with Jae a few months ago. A simple but sensible and effective rebranding.

@th3nyst1c I'm afraid that would violate the rules of the competetion. I have no idea right now how far is the name that you're proposing from AtomOne, but maybe it can be adapted. If so, please consider spending some time adapting it to fit AtomOne brand name.

As already hypothesized a few months ago on X (formerly Twitter), my proposal involves a slight inclination of the current Cosmos logo (as already happened with some forks involving Bitcoin). In this proposal I also added a '1' in the center, so the logo (although simple) is the intuitive and effective representation of the union of the Atom and 1 symbols.

As happens with almost all symbols linked to other blockchains or protocols, even in this case I proposed the same logo to represent ATONE, to have continuity and to avoid creating confusion in the community.

Obviously the thickness of the lines, the font and the color palette can possibly be adapted to the community's requests before any adoption and advertising.

@th3nyst1c I'm afraid that would violate the rules of the competetion. I have no idea right now how far is the name that you're proposing from AtomOne, but maybe it can be adapted. If so, please consider spending some time adapting it to fit AtomOne brand name.

Even if this proposal cannot participate, I would still like to share what I think with the community. The following text below is an excerpt from a conversation I had with Jae on Twitter.
While Atom One and ATONE are solid options, I'd like to propose an alternative that aims to maintain a level of distinction from the original Cosmos network: “Atmosphere”.
Here are a few reasons why Atmosphere could be a compelling choice:

Uniqueness: The name Atmosphere is not currently in use by other blockchain projects, ensuring a distinct identity for the forked network.

Continuity with ATMO Ticker (and affinity with ATOM Ticker): Notably, the proposed ticker ATMO aligns with the first four letters of Atmosphere. This continuity can help ease the transition for users familiar with the original ATOM token.

Fork-Friendly Image: By choosing a name distinct from Cosmos, such as Atmosphere, the forked network can present itself as a friendly and independent project. This approach is likely to be more appealing to both investors and users who may be hesitant to engage with a project that closely resembles the one it forked name from (examples are all forks of Bitcoin and Ethereum).

In essence, Atmosphere encapsulates a sense of uniqueness, availability, and continuity while promoting a positive and independent image for the forked network.

Essentially Atom One would be replaced by Atmosphere while Photon would be replaced by Hydrosphere (It would be almost useless to point out how much sense there is in associating liquid staking with Hydrosphere).

Continuing with this logic it would make sense to replace GAIA with Lithosphere. Just like Gaia, the Lithosphere (although in strictly scientific jargon and not linked to Greek mythology) is also associated with the earth.

Maybe it's not strictly necessary, but I have to admit that it would be extremely fun (as well as being equally sensible) to call the ecosystem that would be created thanks to Atmosphere the term 'Biosphere'.

This is what the ATMO and HYDRO tokens would look like.

Below there are other illustrations that clarify the usefulness of Hydrosphere as well as the brand identity that will also involve the other liquid staking tokens.

End of the "non-proposal" (I don't think it can be taken into consideration). Despite this I hope that it will not be attacked as it does not comply with the competition. Thank you :)

@th3nyst1c First of all, thank you for all the work that's been done. Obviously, it took a lot of care to propose something like this. I would like to offer you to do the following:

Select two of the logos that you've proposed. I'm seeing at least three different logos here, but per competetion's rules we accept only two. I understand that it may not be ideal for you, but Atmosphere for example can be edited out to be AtomOne retaining the original icon of Atmosphere.
Submit your entries according to the guidelines of the competition (color variations, different versions, etc.)

That would ensure your place in the mix from which we're gonna select the winning concepts.

Hello! I am honored to have the opportunity to participate in the Atomone logo design competition

Excited to share my entry for AtomOne's logo competition! 🚀
Fully customizable and adaptable design!

Glad to share a collaborated design project for AtomOne! Thx for this opportunity!

Glad to share a collaborated design for AtomOne! Thx for this opportunity!

very much in the spirit of the atom. synthesis of the nucleus, energy. I like 😻 ⚛

A very organic, logical (Atom + Electron = Election) and comprehensive solution!
 I have more ideas! Is it true that I can send here 2 different cases maximum?

hello again! I have more ideas! Is it true that I can send here 2 different cases maximum?

You can send up to 2 separate entries.

Hi community ⚛
I'll be glad if you like my logo

Great job, couldn't imagine anything better!!!

Good job

Hello everyone! I'm excited to share my vision of branding for AtomOne 🔥

If you like it, I'd appreciate a ❤ up from you!

Hey community ⚛
Glad to share my second option with you 🪐
ps: I split the previous post into two separate posts 🙃

Glad to share my vision. Hope you like it 😄

@philrx31 @th3nyst1c @Konolee @pgrmadu @Beakdoong @dintsen @mobius080 @Besgmo @Alexazavr @imexdesigner @wwqiu just a reminder for everyone who already submitted their vision and for those that are only planning to do it: you can submit up to 2 separate entries!. There is still time to submit your first or second entry.

Hey Please have a look at our design, these logo's are eye-catchy and easier to remember and stand out!

Submit :2

I endeavored to maintain the logo's familiarity while making adaptations to ensure it remains recognizable to users, thus preserving continuity and avoiding the perception of a completely new product. ✌

Hey Community, Sharing my first design!

Hey community, Happily sharing my second design.

Hello again everyone! I'm very excited to share my SECOND branding vision for AtomOne 🩶

Uploading ATOM ONE LOGO.pdf…

Uploading ATOM ONE LOGO.pdf…

Uploading ATOM ONE LOGO.pdf…

Hello, everyone!
Sharing my version of the logo design

please shrare my logo

Hi community 🚀
Glad to share my vision with you ✨

Woooow!

Hello
I am happy to be able to contribute to the project, my mind remained obsessed with 2\3.
so here is what it gives.

Hi Community! Glad to share my design with you!

Hello hub! Sharing my 1st vision of AtomOne logo, hope you like it

🔥🔥🔥Hey Everyone🔥🔥🔥
We're entering the final day of the submission period. You're all doing good. If you submitted only 1 logo, think about adding another one (we accept up to 2 separate entries from each person).
FOR THOSE WHO HAVEN'T SUBMITTED THEIR LOGOS YET:

Don't be intimidated by anything or anyone. Your work matters and you still can win. There's nothing that stops you from winning. Time of submission won't affect the results (just do it before the deadline).
We're looking for interesting concepts and ideas. Your idea may not be perfectly presented or executed. Doesn't matter. We'll understand it and figure out how it can be used. Just try to meet the basic entry requirements.
If you have questions or if you're not sure about something just let us know.

The deadline for submissions is 13th of May 2024, 11:59 PM UTC
KEEP IT UP🏃

I am glad to present you with a different perspective on the concept that I submitted in the previous entry! Hope you will like it!

Looks great 😻

I really love it, it's awesome!!!

This is a good idea and amazing implementation. functionality is also at a high level.

Very nice and clear concept/

Hello everyone, thank you for opportunity to share my creative thoughts on the subject. I focused on building the atom form with the shape of number 1

Hello Cosmos network family!
We are honored to be a part of this design competition.
I'm sharing my design work in anticipation of AtomOne's successful launch and future endeavors. Be happy!

 Hope you will like it!

I like how it's looks

Hey everyone.
Submit 1

Submit 2:

Hi, here are 2 proposals. The proposed designs can be provided in any vector file format, and their size and shape can be adjusted as needed. They are easily adaptable for 3D rendering, and the color palette can be customized to your preferences.

Hello, here are 2 proposals for you. The proposed designs can be provided in any vector file format, and their size and shape can be adjusted as needed. They are easily adaptable for 3D rendering, and the color palette can be customized to your preferences.

looks great

Hello Cosmos network family!
We are honored to be a part of this design competition.
I'm sharing my design work in anticipation of AtomOne's successful launch and future endeavors. Be happy!

@pgrmadu you've submitted more than 2 separate entries. It would be appreciated if you could leave just 2 and delete the others. Thank you!

@Dru1DD Hi!

It seems like your entry images were not uploaded properly. I don't think that anyone is able to see them. Could you please re-upload?
In the comment to the entry you've mentioned that it's your second entry, but I don't think we've seen any other entry from you.

I am glad to present you with a different perspective on the concept that I submitted in the previous entry! Hope you will like it!

Cool! I like it❤

my second vision is a derivative of the first, I explain to you:
the “1” should be seen as a page “the white paper” where what AtomOne should be is written.
this drawing includes the importance of 2/3.

Hello Cosmos network family! We are honored to be a part of this design competition. I'm sharing my design work in anticipation of AtomOne's successful launch and future endeavors. Be happy!

This looks amazing. Very eyecatching and thoughtful

Hi!
My idea for this logo design competition is to create a simple and minimal logo that easily sticks in the audience's mind and appears familiar.
The overall concept is essentially an abstract form of an atom, incorporating digital shapes (vertical and horizontal lines resembling the number one).
Additionally, it features a closed lock within it, visible from all four directions, symbolizing security from all angles and offering potential for use in motion graphics.

Hello there!
I'm thrilled to be joining in contributing to AtomOne's perpetual advancement!
With so many exciting concepts to explore, my heart is racing!
I've detailed the concept and description for the logo in the design.
Have a wonderful day! ❤

@nicklove87 It seems like your submission was not uploaded correctly. Please, consider re-uploading.

🚨Attention!!!🚨
10 hours left to submit your first or your second logo. We're at the finish line friends. This is getting interesting!
FOR THOSE WHO HAVEN'T SUBMITTED THEIR LOGOS YET:

Don't be intimidated by anything or anyone. Your work matters and you still can win. There's nothing that stops you from winning. Time of submission won't affect the results (just do it before the deadline).
We're looking for interesting concepts and ideas. Your idea may not be perfectly presented or executed. Doesn't matter. We'll understand it and figure out how it can be used. Just try to meet the basic entry requirements.
If you have questions or if you're not sure about something just let us know.

💥The deadline for submissions is 13th of May 2024, 11:59 PM UTC💥

@pgrmadu you've submitted more than 2 separate entries. It would be appreciated if you could leave just 2 and delete the others. Thank you!

Ok sir I have  removed  extra designs

Hi everyone! I'm happy to share my proposal with the community! I went on a different route, hope you like it!

I'm not a designer but I want a galaxy as official atom one logo :D, maybe someone can refine.

Font: 13 Misa by Zane Townsend

Hey guys! 😉
Just popping in to share my take on the logo design.
Check it out! 😌
https://github.com/atomone-hub/assets/assets/22180879/acf0c428-f734-4dd7-b86c-ab575103d7ea

More simple solution, but very intuitive :D

Hey community ✨
Here is my 2nd option for the logo 🔮

If you missed, here's my first option

Hi there!
Thats my concept of Atom One logo, hope you will enjoy!
By the way, here u can view my other works for different brands https://www.behance.net/chanturiav710d

Here's my second logo design option that I've been working on 😉
I decided to add some animation to better showcase my idea. Hope you like it! ☺

I’m excited to share my project for AtomOne’s logo competition!
Hope you like it! Thanks for the opportunity!

Hey everyone ✋
Glad to be a part of history 🪐

https://github.com/atomone-hub/assets/assets/169649733/8cc6be12-97ad-4962-b001-c3f3ea00b0e8

Hello
Here is my vision for AtomOne!
Hope you'll enjoy

Hi there!
Thats my first raw concept of Atom One logo. I draw some lettering for you, hope you'll enjoy it!
atom-01

Hi there!
Thats my first raw concept of Atom One logo.   I hope it won’t prevent you to appreciate the very concept of such lettering in the logo.

@foxinrocks it's fine, no worries

🔥**As of May 13th 2024, 11:59 PM UTC the submission period is over **🔥
This is it friends! We've stopped accepting any new entries. You all have been amazing and it's been a pleasure to look at your fantastic concepts.
According to plan, the voting period is still underway and will be finished May 20th, 2024, 11:59 PM UTC. We encourage all community members to show to you appreciation of the great logo ideas that's been presented here using emojis or dropping a comment.
Thank you!

Hey I see my two entries are erased?? And several others also correct me if I'm wrong?

🔥**As of May 13th 2024, 11:59 PM UTC the submission period is over **🔥
This is it friends! We've stopped accepting any new entries. You all have been amazing and it's been a pleasure to look at your fantastic concepts.
According to plan, the voting period is still underway and will be finished May 20th, 2024, 11:59 PM UTC. We encourage all community members to show to you appreciation of the great logo ideas that's been presented here using emojis or dropping a comment.
Thank you!

Hello, I see around 20 posts are hidden untill clicking 'load more'. We are kind of invisible for voting :(

I liked the idea of designing a logo, I didn't see the time spent.
Have a good trip everyone !

안녕! 아톰원의 지속적인 발전에 동참하게 되어 정말 기쁩니다! 탐험할 흥미로운 개념이 너무 많아서 가슴이 뜁니다! 디자인에 로고에 대한 컨셉과 설명을 자세히 적어 놓았습니다. 즐거운 하루 보내세요! ❤

The logo is simple, and I think it can be applied in many places. I was thrilled to see it.
Although he is engaged in a related industry, the logo is simple and unique, so it remains in my memory. :)

@PreetChee
The logo is simple, and I think it can be applied in many places. I was thrilled to see it.
Although he is engaged in a related industry, the logo is simple and unique, so it remains in my memory. !!! :100: :1st_place_medal:

@AidarItkulov can you explain in more detail how the voting will take place ?

Hey @TOdynets & @Coa0303!
The voting process is described in the Readme file.
Here's the part that should answer your questions and concerns:

Anyone with a registered GitHub account can vote on the submissions, starting on the first day of the competition, meaning April 22nd, 2024 and running until the end of the voting period, which is May 20th, 2024, 11:59 PM UTC. The votes will contribute to the All In Bits decision-making process for selecting the winners but will not be the only determining factor. As part of this competition, All in Bits reserves the right to designate other winners beyond the most voted choices by the community. The All in Bits team will evaluate all submissions and will announce the winners by May 31st, 2024, 11:59 PM UTC.

The GitHub voting is the reactions (emojis) and comments that community members leave to show their appreciation of the logo submissions. This can't be a huge factor in determining the winners, because GitHub reactions can be easily gamed. If your entry stands out among other contenders the absence of positive reactions won't be a problem. In other words, don't worry about 'likes'.

Hello participants and voters of the AtomOne Logo Design Competition!
Today we are announcing the winners of our logo design competition. After weeks of creativity, effort, and community participation, we have selected the top designs that, in our assessment, could potentially represent the AtomOne brand. With much deliberation we have decided on two standout contributions that were original, not AI-generated, of great caliber and did not have any conflicts with existing logos in use.
Winner One
Designer: @Beakdoong
Submission

Winner Two
Designer: @PreetChee
Submission

Each winner will need to post their email as a response to this issue to be contacted individually to arrange the reward distribution. We will be reaching out to you shortly.
As part of our contribution, AiB will develop additional designs to complete the first batch of GovGen logo proposals. The winning logos along with any new proposals will be put on-chain to collect the Govgen community’s sentiment on the proposed AtomOne logo designs. This will help ensure that the chosen designs resonate well with our broader community. Following the GovGen community’s vote, AiB aims to develop a comprehensive brand identity for AtomOne around one of the selected logos.
For full details on the terms, conditions, and expectations, including the competition README and Terms and Conditions, please visit our GitHub repository.
https://github.com/atomone-hub/assets/tree/main/AtomOneDesignCompetition
We want to extend a heartfelt thank you to all the participants for their hard work and creative contributions. We also appreciate all of the voters who took the time to engage and support the competition. Your participation is invaluable to the success of the proposed AtomOne project.

https://investor.galaxy.com/overview/default.aspx
...

Congrats for winners — well done guys!

Just a note; It's difficult enough to create a good logo that is distinct from existing logos, but also a ludicrous amount of logos were upon inspection direct copies of other logos. We did investigate every plausible logo here.
For everyone who create a new logo, thank you for your submissions.

Hello everyone,
I am deeply honored to be selected as the winner of the AtomOne logo design contest. I am thrilled to have the opportunity to visually convey the project's vision and values.
I would like to extend my heartfelt gratitude to the AtomOne team for this incredible opportunity. I would also like to express my appreciation to all the talented designers who participated in this contest. Seeing your outstanding work was truly inspiring.
I hope my design contributes in some small way to the progress of the project, and I wish AtomOne continued success.
Sincerely,
Email<EMAIL_ADDRESS>

How ridiculous this is to the community, everyone has ridiculous copying and the winners are just similar=) and remove the link.
Where there are 4 winners but we'll pick two.
Thank you for the contest.

Congrats to the winners....
But what about the other 2 winners?

Congratulations to the winners!
I feel a little cheated and upset that there are only two winners, but I see in the readme that it says UP TO four. But in this issue, there are just four...

hello everybody!
I'm thrilled to have been selected as the winner of the AtomOne logo design competition.
I would like to thank everyone for this amazing opportunity and look forward to seeing the success of AtomOne.
Thank you all!
Email<EMAIL_ADDRESS>

Why it is only two winners? It suppose to be 4: 4 winners will be announced by May 31st, 2024, 11:59 UTC

Hey, @jaekwon @Ticojohnny! Can you share a list with information, which logos you think were generated by an AI and which were copied? :)
Also, it is really interesting to know, how did you choose the winners💫
Thanks!

I would also love to know what was copied and ai generated in your opinion. For example i know our designer spent 2.5 days with face in computer, let alone a weeks research. Happy for the winners. Disappointment to see those comments

@jaekwon you won't get very far with that approach

@dintsen
I don't look the same at all.
And then there's the philosophy of the brand.
If you feel wronged by this result, improve your skills, or raise it further. Don't do this here.

@PreetChee
It was so nice to see it because it was made with the meaning of the logo and brand.
Others didn't understand the meaning of the logo just by visual images,
It was cool because you made the logo with your meaning.  :100: :+1:

@dintsen
It's not at all similar.
Build your skills before gossiping about others.
It looks childish and funny to do this here.

Did you give yourself a like ? :)))
And I didn't say I was good, it's not fair to all the participants and it's not just me who noticed it,

@dintsen
I don't understand what you mean?
Do you think what you're doing right now is a good thing?
And where did you get the reference?
Can I check the reference you came to?
Or didn't you make it yourself and do some evil deeds?
Don't do this here and improve your skills.

@taltal2 Maybe it's not entirely professional of me, but this decision is just as unprofessional. I'm even shocked and just giving my opinion. Where it is not clear what was done with AI, what was copied (as the organizers said) when the winner's work is a copy of Galaxy investment fund

Let them take the tombstone logo then and go out to CMC.  Thanks everyone, there were some really high quality logos from the participants and a lot of experience . Bye everyone

Congratulations to the winners!

Hello @AidarItkulov would anyone be kind enough to clear the bad impression left. We invested time in this and frankly got offended by your companys try to shake it off by just mentioning a lot of copies and not aknowledging the fact they turn out to be uncompetent to recognise clear copying. This was 'advertised' as a 4 reward competition, although you could have give none of the awards, but your representation of the competition is called misleading. Also, how much were the two rewards given? Since your fond was supposed to be 20K+ we don't even have the information if the whole amount was split in half or just two rewarded with promoted sums. I challenge @jaekwon to stand to your belief and show up with that logo you consider original so that Investor Relations and their legal team can have their say on your design expertise. Now, that is what RIDICILOUS looks like.

To: @Coa0303 @dintsen @pronvis @apathereum
I know it's been some days since you commented, but I posted this comment on Discord and thought I'd share here.
The READ ME file attached to the GitHub post is clear on AiB's rights with regards to the competition:
"All in Bits, as the organizer of this competition, reserves the right to select the winners in accordance with the outlined guidelines and requirements."
[...]
"Total maximum prize pool for this competition is $28,000, which will be awarded to a maximum of 4 winning submissions, each in the amount of $7,000."
[...]
"Following the communicated deadline, up to 4 winning submissions will be listed as individual proposals on GovGen for the community to vote on as its preferred logo."
FWIW, it is common practice within the design industry and competitions to not award the maximum amount of submissions.