Proxy reset with pagination and reconciliation requeue

Description
Changes proposed in this pull request:

Proxy reset with pagination and reconciliation requeue

Pre-Merge Checklist

[ ] As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

https://github.com/kyma-project/istio/issues/155

I just tested this code using 8 deployments with 22 replicas (pods) each.
The first run seems to have "joined" containers that belong to the same deployment:
2024-07-17T08:55:17.974314Z	info	controlleruntime	Running proxy sidecar reset	expected image=europe-docker.pkg.dev/kyma-project/prod/external/istio/proxyv2:1.22.2-distroless
2024-07-17T08:55:18.156964Z	info	controlleruntime	Got running pods for proxy restart	number of pods=100 has more pods=true
2024-07-17T08:55:18.157156Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=31
2024-07-17T08:55:18.191781Z	info	controlleruntime	Got running pods for proxy restart	number of pods=100 has more pods=true
2024-07-17T08:55:18.192035Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=100
2024-07-17T08:55:18.192076Z	info	controlleruntime	Pods to restart	number of pods=30 has more pods=true
2024-07-17T08:55:18.195720Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-1 namespace=test
2024-07-17T08:55:18.284005Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-2 namespace=test
2024-07-17T08:55:18.362620Z	info	controlleruntime	Proxy reset only partially completed
2024-07-17T08:55:18.377810Z	info	controlleruntime	Reconcile requeued

The problem is that in the next reconciliation it once again restarts httpbin-1 deployment:
2024-07-17T08:55:34.189453Z	info	controlleruntime	Running proxy sidecar reset	expected image=europe-docker.pkg.dev/kyma-project/prod/external/istio/proxyv2:1.22.2-distroless
2024-07-17T08:55:34.284951Z	info	controlleruntime	Got running pods for proxy restart	number of pods=100 has more pods=true
2024-07-17T08:55:34.285264Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=34
2024-07-17T08:55:34.338815Z	info	controlleruntime	Got running pods for proxy restart	number of pods=100 has more pods=true
2024-07-17T08:55:34.339109Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=100
2024-07-17T08:55:34.339148Z	info	controlleruntime	Pods to restart	number of pods=30 has more pods=true
2024-07-17T08:55:34.344185Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-1 namespace=test
2024-07-17T08:55:34.502469Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-2 namespace=test
2024-07-17T08:55:34.581657Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-3 namespace=test
2024-07-17T08:55:34.596141Z	info	controlleruntime	Proxy reset only partially completed

And then 3rd restart of the same deployment:
2024-07-17T08:55:55.088211Z	info	controlleruntime	Running proxy sidecar reset	expected image=europe-docker.pkg.dev/kyma-project/prod/external/istio/proxyv2:1.22.2-distroless
2024-07-17T08:55:55.189955Z	info	controlleruntime	Got running pods for proxy restart	number of pods=100 has more pods=true
2024-07-17T08:55:55.190329Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=36
2024-07-17T08:55:55.248841Z	info	controlleruntime	Got running pods for proxy restart	number of pods=100 has more pods=true
2024-07-17T08:55:55.249220Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=93
2024-07-17T08:55:55.249346Z	info	controlleruntime	Pods to restart	number of pods=30 has more pods=true
2024-07-17T08:55:55.256246Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-1 namespace=test
2024-07-17T08:55:55.323544Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-2 namespace=test
2024-07-17T08:55:55.410893Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-3 namespace=test
2024-07-17T08:55:55.479599Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-4 namespace=test
2024-07-17T08:55:55.566509Z	info	controlleruntime	Proxy reset only partially completed

Also, since not restarts were done, at the same time there are 4 deployments being restarted (in this case 88 pods). In the example below there are even 5 of them:
2024-07-17T08:57:36.970464Z	info	controlleruntime	Running proxy sidecar reset	expected image=europe-docker.pkg.dev/kyma-project/prod/external/istio/proxyv2:1.22.2-distroless
2024-07-17T08:57:37.172276Z	info	controlleruntime	Got running pods for proxy restart	number of pods=100 has more pods=true
2024-07-17T08:57:37.172496Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=43
2024-07-17T08:57:37.246750Z	info	controlleruntime	Got running pods for proxy restart	number of pods=100 has more pods=true
2024-07-17T08:57:37.247062Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=91
2024-07-17T08:57:37.265578Z	info	controlleruntime	Got running pods for proxy restart	number of pods=24 has more pods=false
2024-07-17T08:57:37.265681Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=24
2024-07-17T08:57:37.265721Z	info	controlleruntime	Pods to restart	number of pods=30 has more pods=false
2024-07-17T08:57:37.270746Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-5 namespace=test
2024-07-17T08:57:37.290869Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-6 namespace=test
2024-07-17T08:57:37.380357Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-7 namespace=test
2024-07-17T08:57:37.512677Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-8 namespace=test
2024-07-17T08:57:37.554794Z	info	controlleruntime	Proxy reset completed

It would be good to have some kind of wait/check mechanism to prevent multiple restarts of the same deployment.

After adding one minute wait, the process looks much better, with 20 pods per deployment it restarts 40 pods at the same time:
2024-07-17T11:06:28.480447Z	info	controlleruntime	Got running pods for proxy restart	number of pods=100 has more pods=true
2024-07-17T11:06:28.480629Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=49
2024-07-17T11:06:28.480860Z	info	controlleruntime	Pods to restart	number of pods=30 has more pods=true
2024-07-17T11:06:28.484596Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-1 namespace=test
2024-07-17T11:06:28.577881Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-2 namespace=test
---
2024-07-17T11:07:37.458548Z	info	controlleruntime	Got running pods for proxy restart	number of pods=100 has more pods=true
2024-07-17T11:07:37.458710Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=49
2024-07-17T11:07:37.498941Z	info	controlleruntime	Got running pods for proxy restart	number of pods=100 has more pods=true
2024-07-17T11:07:37.499178Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=100
2024-07-17T11:07:37.499309Z	info	controlleruntime	Pods to restart	number of pods=30 has more pods=true
2024-07-17T11:07:37.502948Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-3 namespace=test
2024-07-17T11:07:37.598163Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-4 namespace=test
---
2024-07-17T11:08:47.089517Z	info	controlleruntime	Got running pods for proxy restart	number of pods=100 has more pods=true
2024-07-17T11:08:47.089721Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=48
2024-07-17T11:08:47.150624Z	info	controlleruntime	Got running pods for proxy restart	number of pods=100 has more pods=true
2024-07-17T11:08:47.151435Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=100
2024-07-17T11:08:47.152158Z	info	controlleruntime	Pods to restart	number of pods=30 has more pods=true
2024-07-17T11:08:47.156164Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-5 namespace=test
2024-07-17T11:08:47.265287Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-6 namespace=test
---
2024-07-17T11:09:56.572912Z	info	controlleruntime	Got running pods for proxy restart	number of pods=100 has more pods=true
2024-07-17T11:09:56.573076Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=48
2024-07-17T11:09:56.611809Z	info	controlleruntime	Got running pods for proxy restart	number of pods=100 has more pods=true
2024-07-17T11:09:56.612045Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=100
2024-07-17T11:09:56.621784Z	info	controlleruntime	Got running pods for proxy restart	number of pods=12 has more pods=false
2024-07-17T11:09:56.621833Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=12
2024-07-17T11:09:56.621855Z	info	controlleruntime	Pods to restart	number of pods=30 has more pods=false
2024-07-17T11:09:56.624963Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-7 namespace=test
2024-07-17T11:09:56.742104Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-8 namespace=test
2024-07-17T11:09:56.975210Z	info	controlleruntime	Proxy reset completed
---
2024-07-17T11:10:31.029368Z	info	controlleruntime	Got running pods for proxy restart	number of pods=100 has more pods=true
2024-07-17T11:10:31.029571Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=47
2024-07-17T11:10:31.075916Z	info	controlleruntime	Got running pods for proxy restart	number of pods=100 has more pods=true
2024-07-17T11:10:31.076110Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=90
2024-07-17T11:10:31.090040Z	info	controlleruntime	Got running pods for proxy restart	number of pods=16 has more pods=false
2024-07-17T11:10:31.090109Z	info	controlleruntime	Filtered pods with Istio sidecar	number of pods=13
2024-07-17T11:10:31.090300Z	info	controlleruntime	Pods to restart	number of pods=2 has more pods=false
2024-07-17T11:10:31.094559Z	info	controlleruntime	Roll out pod due to proxy restart	name=httpbin-8 namespace=test

There was some other trigger for reconcile process which made httpbin-8 restart twice.


CODE - codeowners and notifications

-smtp config required for notifications with SMP
-codeowners syntax and details

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://659da32808fae1415a4cabd2--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://659ef4263207731db86115f5--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://659ef42968761f1ea98d162f--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65a032c6f3c4031f24f1c5a3--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65a03c69bbae71263156e5f1--harness-developer.netlify.app

Merging now to sync with announcement, but can continue to refine as needed.


[feat] update course calendar on device after shifting course dates

Description
LEARNER-8303
When Course Dates calendar sync is turned on, after user shifts course dates, events on the calendar must be changes to reflect new dates.
How to test this PR

[ ] If syncing is on, "Shift Dates" CTA edits the dates/times of the calendar events to reflect the new dates/times on the Course Dates page.  Event changes are visible in the calendar
[ ] If syncing in off, nothing should happen related to calendar

Is showing the modal on resyncing the events to calendar intentional?

This is handled under separate PR.

Shifting the dates on the course dashboard isn't updating the calendar events. Is this intentional?

Fixed.

In comparison to other toasts the size of shift dates toast is very small.

For now, I have migrated snackbar, in the DatesTab to match calendar event snackbar.

closing in favour of #1512


Bump version to 1.7.0

Depends on https://github.com/qdrant/qdrant/pull/3175.
WIP

Also, just to clarify, I already figured why the build fails and how to fix it and currently working on it. (Thanks for the help, @IvanPleshkov! 🙏)

@ffuugoo my apologies, this needs to be removed in qdrant/qdrant:
https://github.com/qdrant/qdrant/blob/cafab322d08b1dd38204063e756a9c1b59bd9a72/lib/api/src/grpc/proto/health_check.proto#L5

@russcam

my apologies, this needs to be removed in qdrant/qdrant:
https://github.com/qdrant/qdrant/blob/cafab322d08b1dd38204063e756a9c1b59bd9a72/lib/api/src/grpc/proto/health_check.proto#L5
The namespace should only have been added to qdrant package protos 😵💫

Remove just that single line from the protocol definitions? I can quickly arrange that.

Remove just that single line from the protocol definitions? I can quickly arrange that.

I've add a more "generic" fix for this into this PR (and also created a similar-ish qdrant/qdrant#3181 PR, sorry).

@timvisee yes, removing that one line will fix compilation.
The other issue that will arise is that the integration tests are configured to run against the same docker image label as specified by <QdrantVersion>, so if that image is not yet available in docker repo, they will fail. The simple fix for this PR is as per https://github.com/qdrant/qdrant-dotnet/pull/36#issuecomment-1845360652. I can open another PR to control this docker version separately too if it would be helpful.

After QDrant v1.7.0 publishing we will revert hardcoded pathes and versions.
@russcam could you please review C# changes meanwhile? We will public client asap after qdrant release

@IvanPleshkov is doing God's work here. Thanks for picking this up! 😭🙏


Multipoints Route

Hi,
Is there any way if we would like to draw a route for more than two points.
for example from location A to location B to location C to location D to location A.
I would like to create a driving GPS demo for such routes.

Yes, this notion exists in the Google Maps Directions API, it's called waypoints.
PXGoogleDirections allows you to add 1 or more waypoints to your directions request, like this:
    var wp = [PXLocation]()
    wp.append(PXLocation.NamedLocation("your waypoint location 1"))
    wp.append(PXLocation.CoordinateLocation(CLLocationCoordinate2DMake(waypoint2_lat, waypoint2_lng)))
    directionsAPI.waypoints = wp

If you also want the Directions API to optimize the waypoints order for you, add this:
    directionsAPI.optimizeWaypoints = true

Otherwise the calculation will be made with respect to the user-specified order.
Also see this paragraph in the official API docs to see how things are handled behind the scenes: https://developers.google.com/maps/documentation/directions/intro#Waypoints
Good luck!


Cannot change retention policy on bucket

Via the UI I do the following:

Navigate to "Settings" -> "Buckets"
Click on the name of my bucket
Click on "periodically"
Type "30" into Days
Click save changes

Behavior:
I get an error Failed to update bucket: "telegraf"
Expected:
The retention policy is changed
Notes:
The error text is not selectable so I could not copy paste it. In this case the error was easy enough to type out but it would be nice to be able to copy paste error messages.

@nathanielc i am unable to reproduce. was this OSS or cloud?

This was against prod cloud.

I was not able to reproduce the same error. We have updated retention policy to 72hrs and was able to successfully update buckets.


cached decorator returns the same after waiting more than the ttl

greetings, I wrote the little below snippet to demonstrate my issue, I have a FastAPI (derived from Sarlette) route I decorated with a 1 second ttl. It returns a random int.
I have 2 tests calling each the route twice:

once back to back, this test works fine and return twice the same random number,

once waiting 3s (so more than the ttl) and this one fails. I would have expected that the random int generated in the route would be different the 2nd time in this case, as the ttl should have expired, which seems not to be the case,

There's a high probability I may be misusig the library though,
edit: that's probably a misuse in the test context, should i serve the app it seems pressing f5 after the ttl expired the int generated is different,
edit2: this seems like a pytest order issue, 2nd fails if both tests run, 2nd one suceeed if it runs alone
import asyncio
import logging
import random

import pytest

from aiocache import cached
from async_asgi_testclient import TestClient

from fastapi import FastAPI

app = FastAPI()

logger = logging.getLogger(__name__)
logger.setLevel(logging.DEBUG)

@app.get("/")
@cached(ttl=1)
async def home():
    my_randint = random.randint(1, 10000)
    logger.debug(f"rand: {my_randint}")
    return {"hello": my_randint}

@pytest.mark.asyncio
async def test_cache():
    async with TestClient(app) as client:
        response = await client.get("/")
        assert response.status_code == 200
        cached_int = response.json().get("hello")
        logger.debug(cached_int)

    async with TestClient(app) as client:
        response = await client.get("/")
        assert response.status_code == 200
        assert response.json().get("hello") == cached_int
        logger.debug(response.json().get("hello"))

@pytest.mark.asyncio
async def test_cache_wait_for_expire():
    async with TestClient(app) as client:
        response = await client.get("/")
        assert response.status_code == 200
        cached_int = response.json().get("hello")
        logger.debug(cached_int)

    await asyncio.sleep(5)

    async with TestClient(app) as client:
        response = await client.get("/")
        assert response.status_code == 200
        assert response.json().get("hello") != cached_int
        logger.debug(response.json().get("hello"))

ok after reading the tests of the library it seems I had to delete the cache myself in between tests, which seems now logical but kind of surprising at first.
working version below
import asyncio
import logging
import random
from typing import Dict

import aiocache
import pytest
import uvicorn

from aiocache import cached, SimpleMemoryCache
from async_asgi_testclient import TestClient

from fastapi import FastAPI

app = FastAPI()

logger = logging.getLogger(__name__)
logger.setLevel(logging.DEBUG)

async def log_cache_key(cache, key):
    value = await cache.get(key)
    logger.debug(f'cached value {value}')

@app.get("/")
@cached(ttl=1)
async def home() -> Dict[str, int]:
    my_randint: int = random.randint(1, 10000)
    return {"hello": my_randint}

@pytest.fixture
def memory_cache(event_loop):
    cache = SimpleMemoryCache()
    yield cache
    event_loop.run_until_complete(cache.delete('539_cachehome()[]'))
    event_loop.run_until_complete(cache.close())

@pytest.mark.asyncio
async def test_cache(memory_cache):
    async with TestClient(app) as client:
        response = await client.get("/")
        assert response.status_code == 200
        cached_int = response.json().get("hello")
        logger.debug(cached_int)

    async with TestClient(app) as client:
        response = await client.get("/")
        assert response.status_code == 200
        assert response.json().get("hello") == cached_int
        logger.debug(response.json().get("hello"))

@pytest.mark.asyncio
async def test_cache_wait_for_expire(memory_cache):

    async with TestClient(app) as client:
        response = await client.get("/")
        assert response.status_code == 200
        cached_int = response.json().get("hello")
        logger.debug(cached_int)

    await log_cache_key(aiocache.caches.get('default'), '539_cachehome()[]')
    await asyncio.sleep(2)
    await log_cache_key(aiocache.caches.get('default'), '539_cachehome()[]')

    async with TestClient(app) as client:
        response = await client.get("/")
        assert response.status_code == 200
        assert response.json().get("hello") != cached_int
        logger.debug(response.json().get("hello"))

Hey @euri10! glad you could figure it out. But yes indeed, in your tests you have 4 calls to hello, the first 3 happen in less than a second so it will retrieve the cached value. Why? Because the decorated function is the same and it uses the same instance of the cache so it is shared between all calls


This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Originally posted by @lock[bot] in https://github.com/kreait/firebase-php/issues/204#issuecomment-498010068
the problem is that the function is private so it does not call, just change the following and it works :)

the problem is that the function is private so it does not call, just change the following and it works :)

Solución

cambiar a ServiceAccount::fromValue

Thanks for sharing! Please use the discussions feature instead of opening a bug report to share your findings 🙏

You can always find the currently correct way to instantiate the SDK in the documentation at https://firebase-php.readthedocs.io/en/5.x/#quick-start


Add ability to see more results in the preview table

To address this incrementally:

Show 100 results instead of 25
Add manual pagination
Add infinite scroll

Possibly skip manual pagination and go directly to infinite scroll.

Update: we now show 150 rows in the table.
@ericpgreen2 has there been any decision about pagination vs infinite scroll? Should we update this issue title to cover one of those topics, or close this and start a new issue? I'm guessing those might be epic-sized topics with additional requirements for the API?

oh i see that in #316 @hamilton mentions a preference to not add buttons, which sounds like infinite scroll

@ericpgreen2 i think this issue may be redundant with #316 actually -- the issue titles are basically identical. I'll close this in favor of that one, but please feel free to revert if that is the wrong call


Simplest Xception model broken (TF, Windows 7, Python 3.5)

Windows 7, Python 3.5, fresh github pull
import keras.applications
from keras.layers import Input
model = keras.applications.xception.Xception(include_top=True, weights='imagenet', input_tensor=Input(shape=(299, 299, 3)))

yields the following when I run in Wing IDE
tensorflow.python.framework.errors_impl.InvalidArgumentError: No OpKernel was registered to support Op 'DepthwiseConv2dNative' with these attrs. Registered devices: [CPU,GPU], Registered kernels:
<no registered kernels>
[[Node: separable_conv2d/depthwise = DepthwiseConv2dNative[T=DT_FLOAT, padding="SAME", strides=[1, 1, 1, 1]](Relu_1, block2_sepconv1_depthwise_kernel/read)]]
Caused by op 'separable_conv2d/depthwise'

and the following when i run at the python command line.
Traceback (most recent call last):
  File "c:\Python35\lib\site-packages\tensorflow\python\client\session.py", line 1021, in _do_call
    return fn(*args)
  File "c:\Python35\lib\site-packages\tensorflow\python\client\session.py", line 999, in _run_fn
    self._extend_graph()
  File "c:\Python35\lib\site-packages\tensorflow\python\client\session.py", line 1048, in _extend_graph
    self._session, graph_def.SerializeToString(), status)
  File "c:\Python35\lib\contextlib.py", line 66, in __exit__
    next(self.gen)
  File "c:\Python35\lib\site-packages\tensorflow\python\framework\errors_impl.py", line 469, in raise_exception_on_not_ok_status
    pywrap_tensorflow.TF_GetCode(status))
tensorflow.python.framework.errors_impl.InvalidArgumentError: Node 'MatMul_1': Unknown input node 'Mean_1'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "c:\Python35\lib\site-packages\keras\applications\xception.py", line 199, in Xception
    model.load_weights(weights_path)
  File "c:\Python35\lib\site-packages\keras\engine\topology.py", line 2500, in load_weights
    self.load_weights_from_hdf5_group(f)
  File "c:\Python35\lib\site-packages\keras\engine\topology.py", line 2585, in load_weights_from_hdf5_group
    K.batch_set_value(weight_value_tuples)
  File "c:\Python35\lib\site-packages\keras\backend\tensorflow_backend.py", line 995, in batch_set_value
    get_session().run(assign_ops, feed_dict=feed_dict)
  File "c:\Python35\lib\site-packages\tensorflow\python\client\session.py", line 766, in run
    run_metadata_ptr)
  File "c:\Python35\lib\site-packages\tensorflow\python\client\session.py", line 964, in _run
    feed_dict_string, options, run_metadata)
  File "c:\Python35\lib\site-packages\tensorflow\python\client\session.py", line 1014, in _do_run
    target_list, options, run_metadata)
  File "c:\Python35\lib\site-packages\tensorflow\python\client\session.py", line 1034, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InvalidArgumentError: Node 'MatMul_1': Unknown input node 'Mean_1'

Supplanting Xception with VGGnet, everything works fine.
model = keras.applications.vgg16.VGG16(include_top=True, weights='imagenet', input_tensor=Input(shape=(224, 224, 3)))
No errors.
@nafizh ran on mac OS with keras 1.1.1 and python 2.7.12 and he had no error.

This is at least partly due to TensorFlow issue (https://github.com/tensorflow/tensorflow/issues/5818): the DepthwiseConv2DNative kernel isn't currently included in the TensorFlow build on Windows.

this one should still work.  Its a graph connection issue.
https://github.com/fchollet/keras/issues/4477
On Wed, Nov 23, 2016 at 5:54 PM, Derek Murray<EMAIL_ADDRESS>wrote:

This is at least partly due to TensorFlow issue (
tensorflow/tensorflow#5818
https://github.com/tensorflow/tensorflow/issues/5818): the
DepthwiseConv2DNative kernel isn't currently included in the TensorFlow
build on Windows.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fchollet/keras/issues/4478#issuecomment-262649736,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALarq53ZJN1JGTDBRECGNJpfFLNBb2G-ks5rBMQZgaJpZM4K6DX-
.

I should add that it seems prepending any amount of network in front of
that resnet50 example bombs.  For example, putting dropout before it.
On Wed, Nov 23, 2016 at 5:57 PM, Isaac Gerg<EMAIL_ADDRESS>wrote:

this one should still work.  Its a graph connection issue.
https://github.com/fchollet/keras/issues/4477
On Wed, Nov 23, 2016 at 5:54 PM, Derek Murray<EMAIL_ADDRESS>wrote:

This is at least partly due to TensorFlow issue (
tensorflow/tensorflow#5818
https://github.com/tensorflow/tensorflow/issues/5818): the
DepthwiseConv2DNative kernel isn't currently included in the TensorFlow
build on Windows.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fchollet/keras/issues/4478#issuecomment-262649736,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALarq53ZJN1JGTDBRECGNJpfFLNBb2G-ks5rBMQZgaJpZM4K6DX-
.


Disable drive pid during climb

Codecov Report

Merging #35 into master will decrease coverage by 0.37%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   78.31%   77.93%   -0.38%
==========================================
  Files          18       18
  Lines        1148     1160      +12
  Branches      116      119       +3
==========================================
+ Hits          899      904       +5
- Misses        225      230       +5
- Partials       24       26       +2

Impacted Files
Coverage Δ

pyswervedrive/chassis.py
96.73% <66.66%> (-1.23%)
:arrow_down:

automations/climb.py
33.33% <66.66%> (+1.85%)
:arrow_up:

pyswervedrive/module.py
88.81% <76.92%> (-1.12%)
:arrow_down:

utilities/pure_pursuit.py
88.19% <0%> (-1.39%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a9787...d1ac4bd. Read the comment docs.


Downpage and safelist.

Issue #: /bcgov/entity###
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

Codecov Report

Merging #26 (3dd8765) into main (0fe1eda) will increase coverage by 0.50%.
The diff coverage is 71.48%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   84.37%   84.88%   +0.50%
==========================================
  Files          35       40       +5
  Lines         768      959     +191
  Branches       72       57      -15
==========================================
+ Hits          648      814     +166
- Misses        117      138      +21
- Partials        3        7       +4

Flag
Coverage Δ

notifyapi
84.88% <71.48%> (+0.50%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

notify-api/src/notify_api/models/db.py
100.00% <ø> (ø)

...api/src/notify_api/services/providers/gc_notify.py
57.89% <33.33%> (-9.85%)
:arrow_down:

notify-api/src/notify_api/models/email.py
44.00% <44.00%> (ø)

notify-api/src/notify_api/models/safe_list.py
51.61% <51.61%> (ø)

...tify-api/src/notify_api/services/notify_service.py
64.28% <52.50%> (-35.72%)
:arrow_down:

notify-api/src/notify_api/models/content.py
95.23% <70.00%> (-4.77%)
:arrow_down:

notify-api/src/notify_api/models/attachment.py
96.36% <71.42%> (-3.64%)
:arrow_down:

notify-api/src/notify_api/resources/v2/notify.py
93.93% <71.42%> (+93.93%)
:arrow_up:

notify-api/src/notify_api/models/notification.py
96.80% <72.72%> (-3.20%)
:arrow_down:

...otify-api/src/notify_api/resources/v2/safe_list.py
73.91% <73.91%> (ø)

... and 17 more


How to process file outside project directory?

webpack 2.
+ Project_1
  - style.css
+ Project_2
  - node_modules
  - index.js
  - webpack.config.js
  - postcss.config.js

Directory Project_1 is shared and cannot be modified.
Inside Project_2, when referencing Project_1/style.css, Error: No PostCSS Config found in Project_1/.. is always thrown if no options is given in the loader (notice that postcss.config.js is not resolved).
And as we all known, passing options to the loader usually breaks because many loaders (for example, vue-loader) stringify the options and plugin got lost. Thus I cannot pass options to the loader either.
How can this be solved?

Just put postcss.config.js to Project_1. The whole idea of postcss.config.js is to store plugins to process file with the files.
So if you will start to use Project_1 in some new Project_3 you will be free to remembering what plugins do I need to Project_1’s files.

Advice about was from things like PreCSS. If you need just project-specific tools, like Autoprefixer. You should pass plugins as options to loader (there is no other way).

Ok, figured out config path can be specified. To help others with similar demands: use options.config to specify a config directory.


Update netfx-4.8 package to fix revoked certificate error preventing installation

The installer fetched by the netfx-4.8 package is currently outdated and fails to install due to a revoked certificate.
This PR updates the .NET 4.8 installer to release 528049, which successfully installs (tested on Windows 10 x64).
Let me know if I need to fix anything, first time editing a chocolatey package!

Thanks for the feedback. I'll address points 1 and 2.

The Release value is used for detecting the installation of this .NET version and does not change with patches/installer updates. The values for .NET 4.8 differ between operating systems and are documented here. The package needs to use the lowest value across operating systems, so it should stay at 528040.

The .NET release in the registry is 528049 after installation with the 68C9986A8DCC0214D909AA1F31BEE9FB5461BB839EDCA996A75B08DDFFC1483F installer.
Do I understand correctly that the value should remain 528040 even though that's not what the installed .NET release is?

dotnetfx is actually referencing the same installer (68C9986A8DCC0214D909AA1F31BEE9FB5461BB839EDCA996A75B08DDFFC1483F) as this PR. I'll just change netfx-4.8 to match dotnetfx

Do I understand correctly that the value should remain 528040 even though that's not what the installed .NET release is?

Yes, because the value does not depend on the installer, but on the operating system. (Surprising, I agree.)
The package must work on all supported systems. The Release value is only used in a "greater or equal than" comparison, so the package can use the lowest value it can possibly encounter.

dotnetfx is actually referencing the same installer

Oh, is that so? Shame on me, then, for forgetting to update netfx-4.8...

Thank you for the contribution. I'll publish the updated package shortly.


Bad link on page

The link at the very bottom of the page https://github.com/GoogleCloudPlatform/rad-lab/tree/main/modules/data_science
that says" Follow the instructions under gcp-ai-nootbook-tools Readme." goes to a 404 page.

Thanks for fixing so quickly!


Do not run app-frontend in scripts server

It is not doing anything for us and errors out more often than not for unrelated/unimportant reasons

Is the idea here to get rid of the app-frontend service entirely for interactive work? Trying to determine if I should just move a slimmed down version of it to docker-compose.test.yml, or do that but also supply a way to do something like server --with-frontend.

I think moving it to docker-compose.test.yml makes sense. I don't think anyone is using it right now for frontend dev work.


affected/package:

What version of Go are you using (go version)?

go version go1.17.2 darwin/arm64

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
go env Output
GO111MODULE="on"
GOARCH="arm64"
GOBIN="/Users/lion/gopath/bin"
GOCACHE="/Users/lion/Library/Caches/go-build"
GOENV="/Users/lion/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/lion/gopath/pkg/mod"
GOOS="darwin"
GOPATH="/Users/lion/gopath"
GOPROXY="https://goproxy.cn,direct"
GOROOT="/Users/lion/src/go/go1.17.2"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/lion/src/go/go1.17.2/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.17.2"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/lion/gopath/src/demo/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/72/2splrvts5klbzkjrkdr71dcw0000gn/T/go-build3161908003=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
use nginx config proxy proto request golang tls server ,trigger error

[ERR] Failed to read proxy prefix: tls: first record does not look like a TLS handshake

golang source code

its not support proxy protocol v1, its a bug? or not support this proxy protocol

The Go project doesn't use the issue tracker for questions. See https://golang.org/wiki/Questions.


Math rendering error on website

Solving for c...
https://allendowney.github.io/ModSimPy/chap14.html

Fixed. Thank you!


Unintended change of frequency of iCub's controlBoard_nws_yarp instances from 100 Hz to 50 Hz

Historically, iCub's Network Wrapper Servers (i.e. the YARP devices that publish informations over YARP ports) have run at 100 Hz. I may be wrong, but it seems to me that in the latest NWS/NWC layers migration (see https://github.com/robotology/robots-configuration/pull/321 and subsequent PRs), we switched to use 50 Hz frequency. It seems that this happend because we removed all the <param name="period">10</param> parameters, meaning that now we rely on the default period of controlBoard_nws_yarp, that is 1/0.02 = 50 Hz, see https://github.com/robotology/yarp/blob/v3.7.2/src/devices/ControlBoardWrapper/ControlBoard_nws_ros.h#L41 .

Quite an important change that went on unseen, actually.
Thanks @traversaro for the nice catch.
I would ask @randaz81 to comment on this.
For the time being, the quick fix on e.g. iCub 3 could be to make the NWS explicitly run at 100 Hz.
Remember that periods are now in expressed seconds (i.e., 0.01) and no longer milliseconds.

We started from iCubGenova01 and spread the changes to the other robots.
Apparently, iCubGenova01 no longer exposes the parameter period explicitly.

@Nicogene is on it.
The idea is to update the robots' config files to set the period explicitly.

Note that the problem was originally spotted by @GiulioRomualdi .
fyi @S-Dafarra


Graham Ganssle's contest entry

Cheers @gganssle ... I will try to validate today, but it might take me a few days to actually run everything.

Holler if you have questions.


TypeScript: verify callback typings can't assume types

jwt.verify(token, secret, (error, data) => {   const { userName } = data  })
throws
Property 'userName' does not exist on type '{}'.
Environment
"@types/jsonwebtoken": "^8.5.0",
"jsonwebtoken": "^8.5.1",
This is the current typings for VerifyCallback
export type VerifyCallback = (
    err: VerifyErrors | null,
    decoded: object | undefined,
) => void;

Maybe a generic could be added to extend decoded.
Or someone else has a better idea how to improve TypeScript behaviour here?

My suggestion would be something like
export function verify<Decoded>(
    token: string,
    secretOrPublicKey: Secret | GetPublicKeyOrSecret,
    callback?: VerifyCallback<Decoded>,
): void;

export type VerifyCallback<Decoded> = (
    err: VerifyErrors | null,
    decoded: Decoded | undefined ,
) => void;

Any suggestions on this?

You can't actually type the decoded value, as it comes from an untrusted source; typing it as anything other than Record<string, unknown> would be giving you a false sense of security in your typesafety.
Even if you think the decoded token will include a given property, it may not actually, JWTs don't validate properties beyond a limit set (those you can validate using the options argument).
There's nothing that guarantees the returned decoded value will contain given properties — only those the library explicitly checks (based on the options argument) could be "known" types. decoded would be better represented as Record<string, unknown>
So if you need a specific property, you should actually check if the decoded JWT contains that property.
Example:
const token = jwt.sign({ foo: "fooValue"}, "secret");

jwt.verify<{ bar: boolean }>(token, "secret", (err, decoded) => {
  // decoded is: { foo: "fooValue" }, so if `decoded` was cast as `{ bar: boolean }` then
  // you'd think `decoded.bar` is always present. As the signer of the token's payload
  // didn't include the `bar` property, then it won't be there.
})

If you want to guarantee the shape of the decoded object, then you'd need to pass decoded through a validation library like Joi or Yup, or just manually assert properties exist.
This issue can be a particular gotcha for people consuming JWTs from other services/servers.
In fact, in the typings for jws.decode which this module uses, payload of jws.Signature is typed as any.
There's actually no code in jwt.decode that guarantees the decoded value will be an object: https://github.com/auth0/node-jsonwebtoken/blob/master/decode.js#L7-L17
Nor in jwt.verify — payload isn't guaranteed to a parsed JSON Object (it comes from jwt.decode): https://github.com/auth0/node-jsonwebtoken/blob/master/verify.js#L136

To clarify with working code:
const jws = require('jws');
const jwt = require('jsonwebtoken')

const token = jws.sign({ header: { "alg": "HS256" }, payload: true, secret: 'secret'})
// => 'eyJhbGciOiJIUzI1NiJ9.dHJ1ZQ.tNWhzx87CKMgFxL2x9cqZJkzixGWWAkRNbHmbn6d5Dk'

jwt.decode(token, { complete: true })
/* {
  header: { alg: 'HS256' },
  payload: 'true',
  signature: 'tNWhzx87CKMgFxL2x9cqZJkzixGWWAkRNbHmbn6d5Dk'
} */

jwt.verify(token, "secret")
// => 'true'

Since this post got a lot of upvotes and there is no satisfying typescript solution yet, I'm gonna link this stackeroverflow here. Casting seems like the best solution for now.

let isJWTValid = false;

jwt.verify(token, "mysecret", (error, data) => {
    if (error) {
        return;
    }

    isJWTValid = true;
});

if (!isJWTValid) {
    return "invalid token";
}

const decodedToken = jwt.decode(token) as { myValue: string }; // <--- Cast here for Typescript

const { myValue } = decodedToken;

console.log("myValue", myValue);

I stumbled about the same issue and removed the additional call to jwt.decode
jwt.verify(token, "mysecret", (error, data) => {
    if (error) {
        return;
    }

    const decodedToken = data as { myValue: string }; // <--- Cast here for Typescript
    const { myValue } = decodedToken;

    console.log("myValue", myValue);
});

@ThisIsMissEm thank you for pointing it out. My take on the previous example was simple to get rid of the decode call. The checks are needed in any case.

interface CustomRequest extends Request {
token: JwtPayload;
}
const authenToken = (req: Request, res: Response, next: NextFunction) => {
try {
const token = req.header('Authorization')?.replace('Bearer ', '');
    if (!token) {
        throw new Error();
    }

    jwt.verify(token, signingKey as string, (err: VerifyErrors | null, payload) => {
        if (err || payload === undefined) {
            return next(err);
        }

        (req as CustomRequest).token = payload as JwtPayload;
        next();
    });

} catch (err) {
    res.status(401).send('Please authenticate');
}

};


Good

Nice

Have u just created an issue only to say Good? Do u have any idea about the usage of this feature? weirdo 🤔

Good


Use array of chars instead of String builder in DocumentFormatterUtil#cpf where length is predicted

Codecov Report

Merging #977 (9ad4dc6) into main (8d79729) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@             Coverage Diff              @@
##               main     #977      +/-   ##
============================================
- Coverage     92.33%   92.12%   -0.22%
+ Complexity     2760     2752       -8
============================================
  Files           289      289
  Lines          5518     5522       +4
  Branches        601      601
============================================
- Hits           5095     5087       -8
- Misses          270      280      +10
- Partials        153      155       +2

Files
Coverage Δ

...tafaker/idnumbers/pt/br/DocumentFormatterUtil.java
100.00% <100.00%> (ø)

...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java
92.85% <100.00%> (ø)

... and 4 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add Base After Base by DJVI (FULL VERSIONS)

Song Name
Base After Base
Artist Name
DJVI
Source
Youtube
Youtube Link
https://youtu.be/TZULkgQPHt0?si=Ctcl_VsWTVnZv0-9
Direct File Link
No response
Song ID
4
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 3294

reject
that's litterally already the song in game

But is it the full version you have?


Only append port to serviceUrl if port >= 0

Fixes a problem communicating with an eureka server that is running on port 80 or 443 (such as the case in cloud foundry). serviceUrl looked like this http://eurekahost:-1
I can confirm this works on a local build.
See https://github.com/spring-cloud/spring-cloud-netflix/issues/840 for the original issue.

FYI @tbak

NetflixOSS » eureka » eureka-pull-requests #573 FAILURE
Looks like there's a problem with this pull request

NetflixOSS » eureka » eureka-pull-requests #574 SUCCESS
This pull request looks good

Thanks!

@tbak thanks for the quick merge! Any idea on a release date?

@spencergibb It is done.

Sweet! @tbak you've been super helpful.


Allow multiple host name aliases for one project

What happened (or feature request):
feature request
It would be nice to be able to specify multiple additional (local) hostnames in configuration
which should be used for routing to the correct dev instance and used for the web server configuration (in case the web server does not accept arbitrary host names)
That is useful for applications that can deal with multiple host names in one instance (like TYPO3).

Just noting that this was a request from @tmotyl as well.

Pulling in @rfay to assist with the definition for acceptance criteria. I would stub this out as an entry in config.yml with the expectation that it would handle the /etc/host changes and accurately show up in ddev list/describe/start output.
Being more explicit:

End-users can add a hosts: entry in .ddev/config.yml
Each entry within .ddev/config.yml gets added to /etc/hosts
Each entry within .ddev/config.yml is used when reporting the site from ddev list, describe, and start.
Each entry gets a local self-signed cert and appropriate nginx configs.
ddev-ui and the json output it reads will need an array output.
Each entry uses the same HTTP/HTTPS ports (that is we're not allowing per domain port configs)

Potential issues are a few. Currently, our ddev list command assumes a single HTTP/HTTPS pair and the list might become a bit hard to read. I'm assuming we'll run into a few more trouble spots as soon as we start digging. Also, the ddev-ui integration

These ACs sound pretty solid.
In the future, does it make sense to wrap some of this work in a command? ddev hostname (add|remove) [whatever] or the like? Or more generally, if we had some command that could change attributes on an app or something - ddev [whatever] php_version 7.1 or ddev [whatever] containers add solr or something like that? Probably outside the scope of this one - this issue would be a prerequisite to some kind of wrapper command anyway.

@cweagans Let's consider that outside the scope of this issue. What you're describing could be something that extends ddev config either by setting a flag when running config or altering an attribute. I'm a little hesitant on doing this just yet because it is probably a bit of engineering effort and there are some bigger, more pressing rocks to move in the next 1-3 months. That said, happy to split out an issue to track this!

Updated assignee. I'll get the issue description updated with the motivation/AC and the labels updated. Also, I'll add the motivation and prioritization/milestone.

Key things to note:

We envision only multiple hostnames of the form mysite1.ddev.local, mysite2.ddev.local, etc. The hostname aliases would not have real subdomains, although mysite.d1.ddev.local and mysite.d2.ddev.local also would work fine, but the hostname portion is actually "mysite.d1". If TYPO3 multisite requirements are larger than that capability, we'll not meet the need with what we're thinking.
Currently we're not thinking about adding any databases, there's just the one that we normally provide. If I understand right, TYPO3 uses one database for multisite, so this will work there. It can work for Drupal (which typically uses a different db for each site) as long as people use table prefixes. But that would thoroughly mess up imports from a server that didn't use them. So I'm not optimistic about this working well for Drupal multisite.

At least it is important to have the possibility to have multiple hostnames for one TYPO3 installation.
For the project mysite1 I get for default the domain mysite1.ddev.local.
With the new config feature I can add mysite2.ddev.local and mysite3.ddev.local? Right?
Or I can add subdomain1.mysite1.ddev.local and subdomain2.mysite1.ddev.local?
Both would be nice. But If the last one is a problem for some reason, I you can do like this:
subdomain1-mysite1.ddev.local or subdomain2-mysite1.ddev.local with a minus instead of a dot

TYPO3 uses only ONE database for multisite, that's correct.


[SPARK-38198][SQL][3.2] Fix QueryExecution.debug#toFile use the passed in maxFields when explainMode is CodegenMode

What changes were proposed in this pull request?
QueryExecution.debug#toFile method supports passing in maxFields and this parameter will be passed down when explainMode is SimpleMode, ExtendedMode, or CostMode.
But the passed down maxFields was ignored when explainMode is CostMode because QueryExecution#stringWithStats overrides it with SQLConf.get.maxToStringFields at present,  so this pr removes the override behavior to let passed in maxFields take effect.
Why are the changes needed?
Bug fix
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GA and add a new test case

cc @MaxGekk

Merging to branch-3.2. Thank you, @LuciferYang .

thanks @MaxGekk


feature: 添加单据审批iframe

Codecov Report

Merging #970 (946102a) into v2.6.x_develop (0b89362) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           v2.6.x_develop     #970   +/-   ##
===============================================
  Coverage           60.75%   60.75%
===============================================
  Files                 467      467
  Lines               29843    29843
===============================================
  Hits                18130    18130
  Misses              11713    11713

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Missing showCurrentTimeButton & showCurrentDateButton function in Smartform Smartfields

In DateTimePicker it is possible to use a shortcut for navigating to the current date or time (sap.m.DateTimePicker, property: showCurrentDateButton & showCurrentTimeButton). Is it possible to use these functions in a Smartfield?
https://experience.sap.com/fiori-design-web/datetime-picker/#today-button

Hello @NolpaAnna ,
Smartfield is part of SAPUI5, not OPENUI5. GitHub is a place for managing issues for OPENUI5 only.
Please, open a ticket in SAP ticket system for managing incidents.
Regards,
Iliana


chore (Module.Basic): move material about modules over Rat to a separate file

This avoids importing ordered ring classes in this low level file.

I took the liberty to mark this as ready for review - please adjust if this is incorrect!

This PR is just import motion now - can you fix the title accordingly? Apart from that, the changes look good to me - feel free to maintainer merge on my behalf once you have fixed this!
awaiting-author

This PR is just import motion now - can you fix the title accordingly? Apart from that, the changes look good to me - feel free to maintainer merge on my behalf once you have fixed this!
awaiting-author

Wasted time :/


feature: multi bundle support in packager server

Tests are still failing

@thymikee I know, and it's because of some weird thing happening on CI, cause they are passing locally and we are using the start command (for which the integration test if failing) and we can clearly see it's working. Because of that we decided to temporarily skip this failing test and fix it later, since we are running short on time and have other higher-priority tasks to do.


What is the color scheme in the image of readme.md

Plesae, I search the name color scheme of this image.

I believe it's Evan You's custom version of https://github.com/equinusocio/material-theme
I've made a similar theme myself: https://github.com/Herteby/Super-Monokai

It was from an old version of Material Theme, but yeah it's Material Theme.


I am using live server for over a month now never faced this issue until now it is not loading css file changes css HTML file is in the root of my project folder whereas css is in a sudfolder in the workspace it is not reloading as I make changes in CSS file

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Other: <!-- Please describe: -->

Current behavior

Expected behavior

Environment
Browser:

- [ ] Chrome (desktop) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:

- Live Server: <!-- Check which version is installed -->
- Platform:  <!-- Mac, Linux, Windows -->
- Visual Studio Code: <!-- `code --version` -->

Others

I'm submitting a...
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[ ] Other: <!-- Please describe: -->

Current behavior
Expected behavior
Environment
Browser:

- [ ] Chrome (desktop) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:

- Live Server: <!-- Check which version is installed -->
- Platform:  <!-- Mac, Linux, Windows -->
- Visual Studio Code: <!-- `code --version` -->

Others

Same issue. Any update?


Add package.json and enough details to run a static web server

Acceptance criteria:

[x] Set up a package.json file npm init
[x] Update .gitignore to ignore unwanted files (package-lock.json and node_modules)
[x] Pick a simple web framework that can start a web server and display a simple HTML page

Look for a web framework with "hot relead" - save a change to a html or TypeScript file and immediately see the change in the browser without needing to restart the server or rebuild anything.

Fixed by #2


Update fossils.json

There's an error in the Dimetrodon torso image_uri, works without the uppercase.

Fixed in 2bb75ed. Thanks for bringing it up! :)


[WIP] Swagger Docs, Token and URL Resource Unit Tests

@pferreir @ThiefMaster is this ready to be merged?

go for it


Usage issue

Hello, his might be a silly problem, but bear with me please. I'm having trouble running the program to get the power readings. I've followed the steps in the readme file, and got to the Usage section.
From what I understand, I need to copy the code in the Usage section to the src folder and run it as a C script. I did so, but it's not compiling.
I'm not sure if what I'm doing is correct or not, or it's the case that I have to modify the code.
Thanks!

I added #include "hosp.c" in the beginning of the code (is that correct?) because it was giving me the following error
error: unknown type name ‘hosp_device’
 hosp_device* hosp = hosp_open();
 ^

This is the error that I'm getting now, after adding the #include "hosp.c
error: initializer element is not constant
 hosp_device* hosp = hosp_open();
                     ^

If you've installed the library to the system (i.e., you're not editing within the hosp source tree), you typically include files using angle brackets, not quotes -- #include <hosp.h>.  Then add to your -I compile flags, e.g., -I/usr/local/include/hosp (or even better, use the output from pkg-config: pkg-config --cflags hosp).
You will have to initialize from within a function (e.g., main).  You cannot initialize statically.

I'll close this since it appears to be a C programming error, not a bug.  LMK if you have additional problems though.


Structure of Documentation

This issue is being used to track what roughly will be placed in the docs, subject to change.
We can split the documentation into two parts; cryptography/technical aspects and ethereum specific topics.
This documentation will for the most part, focus on the cryptography and only allude or expand on ethereum specific topics when it directly affects the technical aspects.
For the technical aspects, some categories I think will be useful:

Overview
Opening proof, PCS
Test Vectors
Implementations
Optimisations - Eg. Recomputing commitment without computing every value, precomputing CRS points for scalar multiplication

Note

Overview is needed to provide a narrative for the rest of the chapters, so things do not seem random.
It may be helpful to start off with a non-optimised easy to understand implementation and then iterate to what we have now.
Each chapter should also have a summary section, where we say what functionality the concept provides. So for PCS, the summary may say something like "This allows us to commit to a vector and produce short proofs of the values in that vector using it's commitment"

Sounds good, please make a PR


Add Function to lookup usage based on customer ID

A single customer ID may span millions of addresses, we need a method to quickly lookup the total consumption for a given ID.
Request requires a valid token for security.

technically complete, but not scalable due to the way bucket list operations work.
need to revisit. closing.
likely solution is some sort of Cloudflare intersection/integration.


Fixes #1005: Common name is always displayed in French, although we h…

…ave translations for it
Description
Changed product_name text to  by sending a query asking the product name in the language of the UX.
If the name is not availabe in that language, just the product_name is displayed.
fixes #1005
Screen-shots, if any

Can you ensure that then  the locale is pt_BR or nl_BE, the _BR or _BE is removed ?
Otherwise, it doesn't work for some locale (off doesn't support country specific locale yet)

Apart from this, it seems to be working fine.
In addition to product_name, the system would need to be expanded to:

ingredients_text,generic_name, other_information,conservation_conditions,recycling_instructions_to_discard,recycling_instructions_to_recycle,warning,customer_service
image_front_url,image_ingredients_url,image_nutrition_url

Yeah right. I will do that.

Changes made in the latest commit : if the locale is country specific like pt-BR, nl-BE, the -BE part is removed.
(In screenshot) product name of<PHONE_NUMBER>714 with locale nl-BE is set to product_name_nl

Thanks, let's merge as is, and probably another PR for other fields ?


Use organization title, project title and _platform_title, rather than name [REPLACEMENT ISSUE]

The original issue
Id: 19
Title: Use organization title, project title and _platform_title, rather than name

could not be created.
This is a dummy issue, replacing the original one. It contains everything but the original issue description. In case the gitlab repository is still existing, visit the following link to show the original issue:
TODO

In GitLab by @kbubnicki on Sep 3, 2020, 00:41
mentioned in commit 1cf8d960d276ce21e6b3f2f75e918b241f04545d

In GitLab by @kbubnicki on Sep 3, 2020, 00:46
mentioned in merge request !9

In GitLab by @peterdesmet on Sep 4, 2020, 13:33
Implemented in !9.


If not selected date and  is Clearable = true and set endDate then clear icon show

Describe the bug
If not selected date and  is Clearable = true and set endDate then clear icon show
Expected behavior
clear icon to need show only if we select date.
Screenshots

I faced the same issue. Is there any update?

A workaround is to make isClearable dependent on the selection value – i.e., isClearable={!!startDate} or isClearable={!!endDate}.

Same issue!

A workaround is to make isClearable dependent on the selection value – i.e., isClearable={!!startDate} or isClearable={!!endDate}.

It works! Thanks


can we set auto width according to data?

can we set auto width according to data?

There is no such feature available in this version.

You can do that in a custom way, using the onload event. So, you can go thought all cells and interpreting the content of each cells to adapt though jexcel.setWidth the more convenient width for each column.


Naming convention of layer styles in sketch libraries

The v2 and V1 sketch styles are named with no spaces between the classes.
@aagonzales  I understand that the / is for the tree structure, but some of the IBM libraries have a space (for example, Carbon themes) and the others don't.   It's a minor inconsistency between the documents and how the styles were created/named, but an inconsistency nonetheless that was worth mentioning as it requires writing the classes differently if using a plugin to update layer styles via scss.
Carbon style names (have a space)
state / active-danger
vs
V1/V2 Language file style naming (have no space)
color/gray/10

fixed ! will be in next update 🙌🏻


Upload models

Create a new branch and upload compressed models to it. Make sure we come up with a reasonable naming convention based on API.

let's discuss the naming convention for the models.
To kick things off, how about:
openl3_<input>_<data>.h5.bz2
Which would give:

openl3_linear_music.h5.bz2
openl3_linear_env.h5.bz2
openl3_mel128_music.h5.bz2
openl3_mel128_env.h5.bz2
openl3_mel256_music.h5.bz2
openl3_mel256_env.h5.bz2

?

Given that we also may want to include the image embedding models, we could either put the models in separate folders (e.g. audio/ image/), add audio or image to the filename (e.g. openl3_audio_linear_music.h5.bz2) or both. I'd argue for at least adding it to the filename just so the model names are unambiguous. Doing both may be redundant, but maybe having separate subdirectories would be clear.

I agree we should add it to the filename so that filenames are perfectly unambiguous. Since there are just 12 files in total, I'm not sure there's need to save them to separate folders?

Let's just put it in one folder then. Adding audio and image to the filenames should be sufficient.

It has been done.


Reorganize Working with Kubernetes Objects section

These are a subset of the changes from PR #31261

move Understanding Kubernetes Objects to be section overview
within the section, consistently link to the new (moved) page from the first mention of “object”
tweak the appearance of the What's Next section to include other pages from the section
add a redirect so that old bookmarks etc work

The key aim here is to help people who are faced with https://kubernetes.io/docs/concepts/overview/working-with-objects/
With so many sub-pages, it's not obvious to a novice that you don't have to read all of the 10 pages in the section in order to work out what an object is. I'm very keen that we don't end up putting people off by presenting them with a wall of links.

Wall of links
Section overview

Working With Kubernetes Objects
Objects In Kubernetes

/label refactor
This moves a chunk of existing content.

For context, https://kubernetes.io/docs/concepts/storage/ is a similar wall-of-links page but one that actually works better as a section. It's still a lot to take in but there is a more obvious journey through the pages in the order they're listed.

@sftim let me explain my comments using the graph below:

I agree that the order's not ideal. However, I strongly recommend leaving that fix to happen in a separate PR. The more change I put into PRs, the lower the rate of reviews (and hence approvals).

Here is what I'm expecting.
We'd either manually write and maintain an _index.md file for a (sub-)directory, or we let Docsy to generate one for us.
We maybe should not do a mix -- half generated, half written. A page with mixed contents may not be so obvious to new contributors.
A better flow can be left to a future PR, but this one, as a complete PR, may simply copy the generated list as is. WDYT?

It's not a regression: https://kubernetes.io/docs/concepts/overview/working-with-objects/ has an unhelpful order and this PR does not change that fact.

If I omit the autogenerated index, I'd put in a comment to explain it. Only, I don't know what reason to give - I mean, I'm only making the change due to being asked to, not because I agree with that change myself.
What reason should I put?

Preview:
https://deploy-preview-39576--kubernetes-io-main-staging.netlify.app/docs/concepts/overview/working-with-objects/

Current pages:
https://kubernetes.io/docs/concepts/overview/working-with-objects/
https://kubernetes.io/docs/concepts/overview/working-with-objects/kubernetes-objects/

I think this pull request pushes the content from Understanding Kubernetes Objects into the Working with Kubernetes Objects section page.
/approve

Since this pull request is primarily focused on reorganizing pages instead of reorganizing and updating blocks of text, I suggest to move the changes forward.
@tengqm, does that seem okay?

/lgtm


removed a littering <3 in the footer

<3 was looking unreasonable, so, removed the same.

<3 is a main stay for me, thanks though.


crypto/x509: respect GODEBUG changes during program lifetime

For #41682 we allow GODEBUG=x509sha1=1 to reenable SHA1 certificate support.
But programs cannot use os.Setenv at startup, because the SHA1 behavior is loaded
into a global variable during func init in crypto/x509, apparently to make testing easier.
We should tweak the code to check GODEBUG as needed, and then we should backport the change.
Among other things, this will help Kubernetes update older releases to newer Go versions.

@gopherbot please backport


Ask for confirmation before marking all feeds read

I mistyped a shortcut earlier today and accidentally discovered that newsboat has an easy to type shortcut (C) that marks all items in all feeds as read without confirmation. As I understand it, Newsboat autosaves the read/unread status and has no ability to undo such changes which means that all the data about where I am in my YouTube channel, webcomic, and webnovel feeds has been deleted. Is this correct? If so that is a huge dataloss for me, particularly for webnovels that I tend to leave items as unread for months or years at a time until the backlog of chapters reaches roughly the size of a full novel. Thankfully I have a system backup from a couple weeks ago so I have the option of restoring from that and and being able to easily update the "read" status for a couple dozen items as opposed to having to skim through 43 novels to figure out where I was in each of them the last time I read them weeks or years ago.
Were it not for the fact that I'm surely in the minority for being so inconvenienced by having everything marked as "read", I would insist that something should change so that this can't happen, such as by asking for confirmation before marking everything read or adding the ability to undo such a change. As it stands, I probably am in a tiny minority so I have no rebuttal if you (the developers of newsboat) think that it's not worth the development effort and the inconvenience it would cause the majority of users, especially when people like me can just unbind those keys as I have now.

Hi! It's been on the to-do list ever since Newsbeuter (https://github.com/akrennmair/newsbeuter/issues/476, https://github.com/akrennmair/newsbeuter/issues/257), but I haven't gotten around to it, and no-one else picked it up either. So here we are.

@Minoru  I see that this feature has been added to the latest Newsboat 2.21. But is is possible to set in the configuration file of Newsboat, whether the user wants this feature or not?
For, some users (old) it might be useful to not to confirm as they have been using Newsboat for a long time, and they know important shortcuts. It was more frictionless for them, but now there is an additional step.

@anishmittal2020 Not at the moment, but it does make sense to add a setting akin to the existing confirm-exit. I'll turn your comment into an issue.


doesnt work with windows 11  22624

Hello
sharpshell doesnt work with windows 11 anymore? any update for windows 11 soon?

Hey @ecimen81 what's not working for you? I was helping another person recently and on my system it is working. I've only tested a SharpContextMenu though.
Edition	Windows 11 Pro
Version	22H2
Installed	08.01.2023
OS Build	22621.1702
Performance Windows Feature Experience Pack 1000.22641.1000.0

Can you give more infomation, what is not working (maybe a specific feature you need?)

i am talking about  CountLinesExtension sample.. i just use CountLinesExtension.dll from sample folder without touching anything and running above cmd commands with admin privilege..
C:\tmp\New folder>ServerRegistrationManager.exe install CountLinesExtension.dll -codebase
========================================
SharpShell - Server Registration Manager
CountLinesExtension.dll installed and registered.

Microsoft .NET Framework Assembly Registration Utility version 4.8.9032.0
for Microsoft .NET Framework version 4.8.9032.0
Copyright (C) Microsoft Corporation.  All rights reserved.
Types registered successfully
but doesnt show up on explorer contextmenu.

Hey @ecimen81 what's not working for you? I was helping another person recently and on my system it is working. I've only tested a SharpContextMenu though.
Edition	Windows 11 Pro
Version	22H2
Installed	08.01.2023
OS Build	22621.1702
Performance Windows Feature Experience Pack 1000.22641.1000.0

Can you please give more infomation, what is not working (maybe a specific feature you need?)

i am talking about CountLinesExtension sample.. i just use CountLinesExtension.dll from sample folder without touching anything and running above cmd commands with admin privilege..
C:\tmp\New folder>ServerRegistrationManager.exe install CountLinesExtension.dll -codebase
========================================
SharpShell - Server Registration Manager
CountLinesExtension.dll installed and registered.
Microsoft .NET Framework Assembly Registration Utility version 4.8.9032.0
for Microsoft .NET Framework version 4.8.9032.0
Copyright (C) Microsoft Corporation. All rights reserved.
Types registered successfully
but doesnt show up on explorer contextmenu.

There are multiple known issues / traps that can lead to that and I can try to help you with most of them. Do you know much about this topic (windows registry, context menu handlers, COM-Server, etc?) already?
Please see also for details:

https://github.com/dwmkerr/sharpshell/blob/main/docs/troubleshooting.md
https://github.com/dwmkerr/sharpshell/blob/main/docs/context-menu.md#troubleshooting

SharpShell also lists Windows 11 as fully supported:
https://github.com/dwmkerr/sharpshell/tree/main/SharpShell/Samples/ContextMenu/CountLinesExtension

I can test it with the sample project, too (I did not use the sample project in my tests), maybe something is wrong with the sample. Could you please give me the exact information what you downloaded (URL) / extracted or used (also for the SRM?)) so I can replicate as easy as possible?
Did you download this https://github.com/dwmkerr/sharpshell/tree/main/SharpShell/Samples/ContextMenu/CountLinesExtension and build it yourself or where is the DLL and the ServerRegistrationManager.exe from?

Some questions:

Did you look in the "advanced context menu" or in the "new windows 11 context menu"? The SharpContextMenu cannot be added to the new windows 11 menu (only the advanced (aka. old) menu), yet.
Did you / could you please look in the registry, if the necessary entries are created? Sometimes other extensions or "entries" can make problems, too.
** You should at least find something when you just search the full registry for "CountLinesExtension".
** Since you use -codebase, you could also try to search for the path the DLL is installed (C:\tmp\New folder\CountLinesExtension.dll" I guess).
** If nothing comes up, then there is a bigger problem.
** If there are entries maybe we can find errors in them.

There are also debugging options you could look into.

There are multiple known issues / traps that can lead to that and I can try to help you with most of them. Do you know much about this topic (windows registry, context menu handlers, COM-Server, etc?) already?
Please see also for details:

https://github.com/dwmkerr/sharpshell/blob/main/docs/troubleshooting.md
https://github.com/dwmkerr/sharpshell/blob/main/docs/context-menu.md#troubleshooting

SharpShell also lists Windows 11 as fully supported: https://github.com/dwmkerr/sharpshell#compatibility
I can test it with the sample project, too (I did not use the sample project in my tests), maybe something is wrong with the sample. Could you please give me the exact information what you downloaded (URL) / extracted or used (also for the SRM?)) so I can replicate as easy as possible?
Did you download this https://github.com/dwmkerr/sharpshell/tree/main/SharpShell/Samples/ContextMenu/CountLinesExtension and build it yourself or where is the DLL and the ServerRegistrationManager.exe from?
Some questions:

Did you look in the "advanced context menu" or in the "new windows 11 context menu"? The SharpContextMenu cannot be added to the new windows 11 menu (only the advanced (aka. old) menu), yet.

Did you / could you please look in the registry, if the necessary entries are created? Sometimes other extensions or "entries" can make problems, too.

You should find something when you just search the full registry for "CountLinesExtension".
Since you use -codebase, you could also try to search for the path the DLL is installed (C:\tmp\New folder\CountLinesExtension.dll" I guess).
If nothing comes up, then there is a bigger problem.
If there are entries maybe we can find errors in them.

There are also debugging options you could look into.

Yes exactly i downloaded from this   https://github.com/dwmkerr/sharpshell/tree/main/SharpShell/Samples/ContextMenu/CountLinesExtension
i used the ServerRegistrationManager.exe from extracted file which i downloaded from here..
sharpshell version <IP_ADDRESS>
and also i uploaded dlls now you can also check if its working or not?
here  the dlls which i am trying to register.
https://mega.nz/file/lGIFBRiT#dcP44M3uE1rvTLRazqOoIKH19W7vuc3kK_oEvb2Rfa4
by the way i tried with windows 10 vmware and i used the same command line with same dlls and its working..****

Okay thank you for the additional information.
Yes, I also have problems with the sample project. Unfortunately to say, I remember that it was difficult/impossible to get it working on Windows 11 with a specific file extension (which is used in the sample project).
It should work, when you not target ".txt" directly but either a custom extension or with any extension (*). When you register it for any extension it will be loaded for every file but you can only show it for wanted extensions by overriding the "ShowMenu" method.
I have not found another way to get it working, yet. It seems like in win11 the explorer has new places it looks for or overrides with the entries SharpShell makes, since the "*" and also custom extensions, seem to work. So I would not count that as "fully supported" but maybe that is only true for the SharpContextMenu - or, could also be, that it only works for some as the windows shell is very complex.
If that is a solution for you, you should try it. All you need to do is change
[ComVisible(true)]
[COMServerAssociation(AssociationType.ClassOfExtension, new string[] { ".txt" })]
public class CountLinesExtension : SharpContextMenu

to
[ComVisible(true)]
[COMServerAssociation(AssociationType.AssociationType.AllFiles)]
public class CountLinesExtension : SharpContextMenu

Thanks alot for helping .Yes you are right !! your solution is working. i am looking forward to hearing from you that you find a better solution for this problem.. Thanks again.

Okay thank you for the additional information.
Yes, I also have problems with the sample project. Unfortunately to say, I remember that it was difficult/impossible to get it working on Windows 11 with a specific file extension (which is used in the sample project).
It should work, when you not target ".txt" directly but either a custom extension or with any extension (*). When you register it for any extension it will be loaded for every file but you can only show it for wanted extensions by overriding the "ShowMenu" method.
I have not found another way to get it working, yet. It seems like in win11 the explorer has new places it looks for or overrides with the entries SharpShell makes, since the "*" and also custom extensions, seem to work. So I would not count that as "fully supported" but maybe that is only true for the SharpContextMenu - or, could also be, that it only works for some as the windows shell is very complex.
If that is a solution for you, you should try it. All you need to do is change
[ComVisible(true)]
[COMServerAssociation(AssociationType.ClassOfExtension, new string[] { ".txt" })]
public class CountLinesExtension : SharpContextMenu

to
[ComVisible(true)]
[COMServerAssociation(AssociationType.AssociationType.AllFiles)]
public class CountLinesExtension : SharpContextMenu

I will try something soon myself as I need it myself and will let you know in here when I find something out.

I find myself with much of the same issue. It seems to be impossible to get anything (aside from thumbnail and tooltip) to work with certain file extensions in Windows 11 (.scp for me). Have you found a solution yet for this problem?


Speed up docs action by using build environment from conda build action

This would mean we do both the conda and docs build in the same step.
May need to use '--keep-old-work' to keep the build environment
https://docs.conda.io/projects/conda-build/en/stable/resources/commands/conda-build.html?highlight=conda build arguments

Already running in parallel so as quick as possible


Needs option to delete old PR comments

From https://github.com/chocolate-doom/chocolate-doom/pull/1537
I got some (correct) complains about file src/hexen/p_action.h
I force-pushed the branch to correct them. The old comments were not deleted. This makes it hard to check if all the things have been fixed.

I have to checkwith the github REST API docs (optimistic it will help). My first guess is that the force push, which basically resets the branch's history, may be hiding the PR's full history, thus acting like a PR just opened.

Just to be clear, there is a difference between file-annotations and thread-comments.

thread-comments look like user comments that are only displayed in the PR's thread (or after the diff for a commit on push events).  These are automatically deleted every time cpp-linter-action runs.

file-annotations are comments posted within the diff for an event.
These cannot be deleted as they are specific to the commit that triggered the CI event. This is not our choice, it is a limitation of the workflow log commands that we use to post the annotations. Existing annotations cannot be fetched without recursively searching the parent commits (which would result in a catastrophic failure on forced pushed commits), and I'm still not sure its even possible to get a list of previous annotations via GitHub's REST API.
I had initially planned to use GitHub Checks API to post file-annotations, but I ended up going with workflow log commands because it didn't require a server constantly running a GitHub app (which costs 💰 AFAIK).

Therefore, we cannot offer an option to delete file-annotations. And thread-comments are automatically deleted on every run of cpp-linter-action. I'm closing this... Feel free to comment if I somehow misinterpreted the request.


Fix handling of erroneous uploads

Fixes https://github.com/zendframework/zend-psr7bridge/issues/21

@Pittiplatsch
Something wrong?

Wrong target...
Additionally, I'll try to write a unit test.


Adds __rmul__ to collections.deque

Closes #2834
Note: at the moment almost all collections are missing MemoryError corner case, like here: https://github.com/python/cpython/blob/d1ae57027fc39ff60dcfc1b63881400e5ca3ce56/Modules/_collectionsmodule.c#L709-L711
I guess that this is out of scope of this task, related:

https://github.com/RustPython/RustPython/issues/1750
https://github.com/RustPython/RustPython/pull/1779

I think that some tests in test_deque might hang because of that.

Local test produces a very strange result:
» target/debug/rustpython
Welcome to the magnificent Rust Python 0.1.2 interpreter 😱 🖖
>>>>> from collections import deque
>>>>> d = deque('abc', maxlen=5)
>>>>> d * 1 == deque('abc')
thread 'main' panicked at 'attempt to subtract with overflow', vm/src/stdlib/collections.rs:310:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

d.len() is 3, maxlen is 5. so 3-5 is overflowed.

I think that some tests in test_deque might hang because of that.

That's deadlocking, unfortunately. I've idly been trying to find a good way to tackle it. It is for another time, though.


Discovery API and Discovery UI can talk to the system in Docker

As a developer implementing the Smart Cities data platform, I want an easy way to run the entire system on my machine.
A developer should be able to run an app with iex -S mix and connect to the rest of the system running in docker on their machine.
Acceptance Criteria:

Discovery API (run through iex) is able to communicate with docker
Discovery UI (run through npm) is able to communicate with discovery-api (in docker)
Minimum of configuration changes

Technical Notes:

Configuration should be done in integration.exs
Ports need to be exposed
Phoenix apps may need to have a host file changed

rejected 08/14/19 by Carrie and Johnson


fix(ui): sort feature flags alphabetically

Description
Previously ignored by the ROX_CENTRAL_EVENTS feature flag introduction, this makes things right again.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
N/A

Current dependencies on/for this PR:

master

PR #7321   👈

This comment was auto-generated by Graphite.


"Bad" results with Realsense camera using the demo with real YCB objects

Hello @ethnhe ,
I am using your pretrained weights for the YCB dataset on my custom camera (Intel Realsense d415) stream/pictures but it seems that there is some kind of "shifting" applied to the objects (the orientation and size seem correct).
I have changed the K intrinsics and the factor depth to my camera.
Here you can see the best results I have managed to get for some objects but it's not accurate.

How can I improve the results? Do you have any suggestions?
Thank you very much for your time and consideration.

Dear @lucasbrd have you solved it? which modifications have you made in the demo code for running with your camera?
Thanks a lot


Update README.md

#462 add OS X desktop entry Makefile.
Thanks @brycefisher

Thanks for the PR! Just need one little change, and then it's ready to go.

@jwilm @brycefisher
Thanks for your reviewing.
I updated instructions.

awesome, @h-michael! Thanks for updating the text.
I find the wording of the current PR a bit confusing. The Makefile does not compile Alacritty for you. So, I might just rephrase this as:

You can pack a desktop app for OS X by first running cargo build --release, then running this task:
make install

The exact phrasing isn't super important, but clearly indicating that you have to invoke cargo build before the make target is the key point.

Thanks @brycefisher
I think that running cargo build is unnecessary, because Makfile includes 'binary' task, which runs cargo build --release.
So even if someone runs make install without cargo build --release, if need be, task runs cargo build --release.
Do I have a misunderstanding that you said ?

@h-michael apologies for the slow response.  Sorry to misunderstand the Makefile! LGTM.

@brycefisher Thanks !!
@jwilm Please merge whenever it is convenient for you.

There's some issues with the desktop entry that I'd like to resolve before publicizing it too much. Going to close this, and we can look at documenting it later.
Thanks for the PR @h-michael, and sorry for the change of heart about landing it.


[Suggestion] Return to battles after left and return

When restart bot and bot is battling, the bot don't return to the battle.

You can configure it.
See https://github.com/Ecuacion/Pokemon-Showdown-Node-Bot/blob/master/config-example.js#L254-L256

Yes, because if you restart the bot, all data stored in RAM is deleted, similar if you are battling and shut off the computer. For that reason when you use .kill and the bot is battling, it says there is a battle in progress, so if you use .forcekill or send a SIGINT/SIGTERM/SIGKILL you are aware that the bot will not return to the battle.
You can use .join battle-id and then .custom [battle-id] /joinbattle to re-join a battle.
Maybe a joinbattle battle-id commad to combine both lines is a good solution.

An good solution for this is storing all current battles in a .json file for bot returning after, like an human does.

Done in f5547304efce6cfad83fbd5abb74bc3a9b817c1c
You can enable the new battle autojoin feature setting exports.abandonedBattleAutojoin = true; in config.js


Try to use the mambaforge installer to speed up the build process

Our current CI build process involves multiple conda installations. I could already speed it up in the past by switching from conda to mamba - with the drawback that the setup of the conda installation (miniconda) takes a long time as it needs to install mamba.
Let's hope that starting with "mambaforge" makes it faster.

Its hard to tell quantitatively, but it seems the build is at least 1-2 min faster (even without caching).
While doing this test, I realized that the windows build does not pick up the conda cache correctly. It states that the repodata_record.json file is corrupted and therefore needs to reinstall all the packages, which takes at least twice as long. This should be fixed in a second iteration.


Make phone labels optional, add phone_1_after field

Note: This works with prod data, but to properly view the changes, use the staging data.
To view online: https://hto2020-fron-optional-p-c1iyhh.herokuapp.com/?api=https://hto2020-backend-staging.herokuapp.com/api-preview/#/
To view locally (once running): http://localhost:3000/?api=http://hto2020-backend-staging.herokuapp.com/api-preview
This PR:

[x] Adds a display field to display text_message_instructions (string, non-hyperlinked)

[x] Makes phone labels optional, and doesn't display them if they're not present in the data

[x] Adds a phone_1_ext field (string, displays after phone_1)

No regressions or breaking changes. It adds 2 fields to the Card display, and does not remove any.

unfortunately this will make localization impossible, as it codes English grammar into the data structure @develleoper

Oh! I may not have explained this well, but none of the text is hard-coded into the UI at all. They're all just text fields.
So, "ext" isn't hard coded into the UI. The variable "phone_1_after" is just a string. In the example I showed, the value of the variable is literally the string "ext 302." But it could hold any string value.
Context: We had a lot of phone numbers that included text after the number, such as:
"(503)-555-5555 ask for Annie" or "541 555-5555 press 2 and leave a message"
I didn't want to lose that information, but the extra text was also messing up the UI formatting for phone numbers (I assume.)
So this is a proposed solution: make a plain text field and display it after the phone number. It displays a string the user has entered.
Does that make more sense? And does that work as a solution?

@develleoper Also to clarify: I haven't made any changes to the Airtable. The preview data used in this deploy is from a copy of the Airtable. I altered the copy only.
As it stands, in the prod data right now, phone numbers can include text strings. Here's an example of a current listing on prod:

I'm assuming that the "press 2" after the phone number will mess with formatting, so that's the problem I was trying to solve!
I'm open to other solutions if this isn't the best one!

to be clear, i understand it isn't hard-coding text, my concern was grammar and word order, but in this case it's probably fine, and we don't need to be draconian about it 😅


Incorrect user agent result: HubPages

User Agent: HubPages V0.2.2 (http://hubpages.com/help/crawlingpolicy)
Result: HubPages V0.2.2 (http://hubpages.com/help/crawlingpolicy
I would also like to point out parsing error in User Agents like WordPress/4.8; http://xyz.com or redback/v0-570-g26f8c96, it always includes the trailing slash in the result, e.g. WordPress/ or Redback/
May be cleaning out the result with below code will help:
trim(preg_replace('/[^A-Za-z0-9\-\_\.]/', ' ', $result))

Would you like to submit a PR with the proposed changes?
Thanks

Sorry but I'm still a novice PHP developer and yet to learn how to work with Git :-(
But, what I'm proposing here is changing the method getMatches(); inside "Jaybizzle\CrawlerDetect\CrawlerDetect" as below:
public function getMatches()     {         return isset($this->matches[0]) ? trim(preg_replace('/[^A-Za-z0-9\-\_\.]/', ' ', $this->matches[0])) : null;     }
It will filter out any unwanted special characters and white spaces. I'm not sure, if any detected bot does really requires special characters, except a - (minus sign) and _ (underscore) .

Sorry for the delayed response.
I see where you are coming from, but the getMatches() method is not really used to return the exact bot that was detected, but more to return the exact portion of the user agent that caused the true response.
It would be nice to by able to have magic methods, such as isHubPages() but this would require us keeping a more complex database of bots and the beauty of this library is it's simplicity.
Always open to PRs though.
Thanks


RD2: Schedule Service Handles DayOfMonth 29, 30 and 31

We've added explicit support for monthly recurring donation days 29, 30 and 31.  Previously, these days were all considered the last day of the month.  Now we will respect the explicit selection in all months where that is possible and treat the selection as the last day of the month in all other cases.  Last Day of Month is still supported as an option.
Critical Changes
Changes
Issues Closed
Community Ideas Delivered
New Metadata
Deleted Metadata

@force2b @RadSFDeveloper Ready for review.
@sam-knox Please take a look at the PR description.
Thanks all!

**lurch: attach W-040426

Tracking W-040426

@force2b several of your comments relate to DayOfMonth == 31.  Easy to remove.  I put it in for discussion around what we expect to be coming from Elevate.  They will never send us 31, right?

31 does not need to be supported here.

@npsp-reedestockton I think you attach this PR to the wrong WI. It should be attach to WI-040427 instead of WI-040426.

**lurch: attach W-040427

Tracking W-040427

**lurch: detach

**lurch: attach W-040427

Tracking W-040427

Detached W-040426

Ready for another look...  Thanks!


feature/add unit test workflow

Add unit test packages (vitest/testing-library/happy-dom)
Add vitest config/Modify tsconfig/package.json for unit test
Fix unit test failed bugs
Summarize test reports into test-results
Add unit test workflow, refactor test workflows

needs rename branch.


feat(remix-dev+remix-react): add spinner to indicate rebuilding when using LiveReload & devServerRebuildingIndicator enabled

add spinner in LiveReload component to show spinning 💿 when any change that require live reload happens
https://user-images.githubusercontent.com/401304/143497677-80f48d9e-c9eb-44e8-bfbe-8a729ad44d87.mov
UPDATE 1:
I made a few updates in cc8b0d2 to allow adding devServer key to remix.config that can configure a few options for now. e.g:
devServer:  {
  broadcastDelay: 0,
  port: 8002,
  rebuildingIndicator: true,
}

I took the same approach as deprecating browserBuildDirectory added @deprecated flag and still alow devServerPort and devServerBroadcastDelay to be used.
UPDATE 2:
I created a separate PR for refactoring devServer options in https://github.com/remix-run/remix/pull/923

I love the little spinning disk! Really nice!

I made a few updates in https://github.com/remix-run/remix/pull/664/commits/cc8b0d2a21b7b78f2cab6561cc516e0661d46b86 to allow adding devServer key to remix.config that can configure a few options for now. e.g:
devServer:  {
  broadcastDelay: 0,
  port: 8002,
  rebuildingIndicator: true,
}

I took the same approach as deprecating browserBuildDirectory added @deprecated flag and still alow devServerPort and devServerBroadcastDelay to be used.

@ikhattab I think the new devServer option together with deprecating the devServerBroadcastDelay & devServerPort options would best be done in a separate PR first

@MichaelDeBoey good call 👍🏽  will work on it

@ikhattab I think the new devServer option together with deprecating the devServerBroadcastDelay & devServerPort options would best be done in a separate PR first

We also don't want a breaking change this early, so let's make sure the existing options are proxied onto the config with a console.warn of deprecation.

@jacob-ebey @MichaelDeBoey I created a separate PR for refactoring devServer options in https://github.com/remix-run/remix/pull/923

@ikhattab Since all changes from #923 are currently revoked, could you please revert them here too and just add the devServerRebuildingIndicator config + fix all conflicts?

The <LiveReload/> component is very simple. I think if you really want this feature, just create your own version of it and include it in your root route.
https://github.com/remix-run/remix/blob/63c5eff12661e1982a37cef8e1bc919523f93c78/packages/remix-react/components.tsx#L1375

@ikhattab Since all changes from #923 are currently revoked, could you please revert them here too and just add the devServerRebuildingIndicator config + fix all conflicts?

Hi @MichaelDeBoey, that'd be great. I'll resume working on this and probably will start with a new branch from dev with the same name and apply my changes to it

updated, also updated the docs.

I'm going to close this for now. I'm not convinced this is something we need to expand our config API for. As @kiliman points out, this is mostly achievable today by using your own LiveReload component. You don't get the rebuild hook, but esbuild is so fast I'm not sure that adds a ton of value.
If we do offer any sort of rebuild indicator, I suspect it will be built-in eventually. We have lots of ideas on how to improve the DX while running remix dev, and we have tasks in the backlog that may require a big overhaul of the LiveReload component.