chore(crossplane): migrate all irsas to epis

Type
enhancement

Description

Added and updated multiple Kustomizations across infrastructure, observability, and security to use new epis configurations.
Transitioned several configurations from IRSA to EPI, enhancing the management of IAM roles and policies.
Removed specific AWS IAM role annotations from service accounts in helm releases, aligning with new EPI configurations.

Changes walkthrough
Relevant filesEnhancement
10 files

infrastructure.yamlAdd and Update Kustomizations for Infrastructure

clusters/mycluster-0/infrastructure.yaml
Added a new Kustomization for infrastructure epis with dependencies and variable substitutions.  Updated dependencies in existing Kustomization to depend on the new infrastructure epis.

+20/-1

observability.yamlUpdate and Add Observability Kustomizations

clusters/mycluster-0/observability.yaml
Renamed existing observability Kustomization and updated its path.  Added a new Kustomization for observability with domain name substitution.

+24/-2

security.yamlAdd and Update Kustomizations for Security

clusters/mycluster-0/security.yaml
Added a new Kustomization for security epis with domain name substitution.  Updated dependencies in existing Kustomization to depend on the new security epis.

+22/-1

helmrelease.yamlRemove AWS IAM Role Annotations from Helm Release

infrastructure/base/aws-load-balancer-controller/helmrelease.yaml

Removed specific AWS IAM role annotations for the service account.

+0/-2

external-dns.yamlAdd IRSA Resource for External DNS

infrastructure/base/epis/external-dns.yaml
Created a new IRSA resource for external DNS with specific IAM policies.

+39/-1

load-balancer-controller.yamlAdd IRSA Resource for Load Balancer Controller

infrastructure/base/epis/load-balancer-controller.yaml
Created a new IRSA resource for the load balancer controller with extensive IAM policies.

+255/-1

loki.yamlTransition Loki Configuration to EPI

observability/base/epis/loki.yaml
Transitioned Loki configuration from IRSA to EPI with updated specifications.

+6/-6

cert-manager.yamlTransition Cert Manager Configuration to EPI

security/base/epis/cert-manager.yaml
Transitioned Cert Manager configuration from IRSA to EPI with updated specifications.

+5/-6

external-secrets.yamlAdd EPI Resource for External Secrets

security/base/epis/external-secrets.yaml
Created a new EPI resource for external secrets with specific IAM policies.

+31/-1

vault-snapshot.yamlTransition Vault Snapshot Configuration to EPI

security/base/epis/vault-snapshot.yaml
Transitioned Vault Snapshot configuration from IRSA to EPI with updated specifications.

+6/-6

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

:warning: I still have to work of external-dns. It doesn't seem to work yet

⚠ I still have to work of external-dns. It doesn't seem to work yet

Has been solved by using a recent image tag.


Android build

add github actions workflow.

Looks good to me. Thanks for introducing me to a feature of GitHub that I'd been meaning to learn about.


update policies and readme

https://issues.redhat.com/browse/ACM-10745
Updated policies with the following changes :

allow restoring Snapshots from a different location
allow customizing a ReplicationDestination configuration
add more optional hub-pvc-backup properties
updated readme

/cc @tesshuflower


www/nginx: Fix wrong stream server ca filename

If a CA Certificate for an stream server was selected the CA was saved with the last hostname set from the forearch loop of the HTTP Servers in the block above!

Hi!
correct fix imho
Since the streams block is touched, it might be worth fixing the certs creation for cases of a single stream server in config?
imho changing !isset($nginx['stream_server']['servername']) to !isset($nginx['stream_server']['@attributes']['uuid']) is enough for this
https://github.com/opnsense/plugins/blob/69a9a1d4545936716461f7c83306ee2549661d00/www/nginx/src/opnsense/scripts/nginx/setup.php#L124-L128

@itn3rd77
hi!
it looks like setup.php needs more work (PHP Warning:  Use of undefined constant next, no cert creation for single stream and single upstream verify)
Do you mind if I prepare a new pr for setup.php and include your fix in it?

If this one is correct I’d like to retain authorship unless more work is needed that reactors the line as well.

On 11. Apr 2021, at 11:35, kulikov-a @.***> wrote:

@itn3rd77
hi!
it looks like setup.php needs more work (PHP Warning: Use of undefined constant next, no cert creation for single stream and single upstream verify)
Do you mind if I prepare a new pr for setup.php and include your fix in it?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@fichtner got it. will make separate pr

Merged, thanks!

Thank you guys!


Not for CollectionCondition

Hi,
I'm looking for something like this:
shouldHave(Condition.not(CollectionCondition.texts("Null"))); or
shouldNotHave(CollectionCondition.texts("Null"))
Is it possible somehow?
It would be handy I guess when I have e.g. a collection of error messages and I'd like to know if it does not contain a specifix error message.
Anyway I applied this workaround for now:
.filter(Condition.matchesText("NullPointerException")).shouldHaveSize(0);

Use shouldBe(Condition.empty);

Thanks for the hint. I was sure it can be more readable but I feel it still a workaround.
.filter(Condition.matchesText("NullPointerException")).shouldBe(**CollectionCondition**.empty);

@apreg  use static imports, so code will become more readable

Solution provided so close it.
But feel free to reopen or create a new one if it's really needed.


{"ip": ""} returned when supplying callback parameter

Hi,
When I hit the service with say
https://api.ipify.org/?format=jsonp
I get back as expected:
callback({"ip":"195.xxx.xxx.xxx"});
However if I add the "callback" parameter, for example
http://api.ipify.org/?format=jsonp&callback=jq
...then I get back:
jq({"ip":"\u003cnil\u003e"});
Why?  Is this a bug?

I'm now trying to call it directly from script code with jQuery:
$.getJSON('//api.ipify.org?format=json', function(data) {
  console.log("data: " + data);
  console.log(JSON.stringify(data, null, 2));
});

This results in (in the console):
data: [object Object]
VM2301:8 {
  "ip": "<nil>"
}

Is this somehow something I'm doing wrong?

I have now tried another service that seems to work correctly, which suggests this must be a bug perhaps.  The following code works:
$.getJSON('//jsonip.com', function(data) {
  x=document.getElementById("myDiv");
  x.innerHTML = "Your IP is: <b>" + data.ip + "</b>";
  console.log("IP: " + data.ip);
});


Implement unit-tests for UpdateNuGetConfigPackageSourcesMappings task

Source-build tasks do not have any unit-tests. As tasks get complex tests are even more important, as was experienced with this task. There were developer-centric tests, which need to be converted into unit-tests.
This is related to https://github.com/dotnet/source-build/issues/4666
As part of this work, it is important to improve organization of unified build and source-build tests. Currently we have two projects in VMR, under test, both of them are product tests. Source-build tests should run both source-build and unified-build tests, as those are common - today. In the future there will likely be some tests that are specific to unified build and not applicable to source-build. Common, source-build and unified-build (or Microsoft) tests are 3 natural classes of tests. Perhaps unified-build tests can be marked appropriately, so that common tests are included in source-build testing.
Unit-tests are usually built and run as part of the same build so they consume the same dependencies. Product tests are intentionally removed from main build, to enable these test projects to consume artifacts (including packages) that are produced by unified- (or source-) build.
Open question: should unit-tests for unified-build and source-build tasks be built/executed together with product tests or earlier in the build when tasks are built.

@MichaelSimons @ViktorHofer

Open question: should unit-tests for unified-build and source-build tasks be built/executed together with product tests or earlier in the build when tasks are built.

IMO the current sequence point (the Test target) is appropriate and I wouldn't change that. Our repo official builds usually don't run tests (there are a few outliers, i.e. vstest). We decided on that few years back for improved reliability and build times.
If we need a place to do unit testing then I would recommend adding a new test project under /test.

As part of this work, it is important to improve organization of unified build and source-build tests. Currently we have two projects in VMR, under test, both of them are product tests. Source-build tests should run both source-build and unified-build tests, as those are common - today. In the future there will likely be some tests that are specific to unified build and not applicable to source-build. Common, source-build and unified-build (or Microsoft) tests are 3 natural classes of tests. Perhaps unified-build tests can be marked appropriately, so that common tests are included in source-build testing.

Sounds good.

Currently we have two projects in VMR, under test, both of them are product tests. Source-build tests should run both source-build and unified-build tests, as those are common - today.

The current source-build tests are a mixture of unit tests and scenario tests.  https://github.com/dotnet/source-build/issues/4384 tracks removing the scenario tests now that we have a shared set of tests in the scenarios-tests repo.
Source-build does not and should not run the current unified-build tests.  The current unified build tests are transient only for the purposes of comparing the unified build leg output to the current Microsoft builds as a means to identify differences in the unified build.

Common, source-build and unified-build (or Microsoft) tests are 3 natural classes of tests.

I like the idea of three separate projects for this.

However, I believe a better option might be to build unit-tests project along with tasks project, at the same time, using the same dependencies. That way we'd be building the tests using the same toolset and dependencies. Tasks are used during build, and consume old dependencies, unit-tests should consume those same dependencies. This allows unit-tests to test the actual tasks experience. In this scenario, we'd need to ensure we have the dependencies available during testing.

I don't think that's the right approach. We want to build the unit test projects independently and also not part of the main build. That's why we have tests.proj as a separate unit.

remaining question is about unit-test location

IMO the location should be a separate project under test/.

It should be possible to introduce some new '.proj` file to build the tasks project again, during testing to publish to a different location, and have it consume new dependencies.

We want to test the tasks that are executed as part of the VMR build, hence they shouldn't get rebuilt with a different set of inputs.

Anything under test is build using artifacts produced by build.

Would you mind elaborating on that? How is that enforced today?

I might have phrased some of my previous comments tersely. When we build tests we have all the newly produced packages in NuGet store, which can lead to issues with package mismatch.
However, the issue I have seen in my initial attempt to add unit-tests is somewhat different.
Test project directly depends on NuGet.Protocol (and indirectly other NuGet.* packages) version 6.9.1 - getting dependency from root Directory.Packages.props, and version from eng/Versions.props - https://github.com/dotnet/sdk/blob/8584c262d4d2e1a0af388271ae0715db3c53a2b6/src/SourceBuild/content/test/Microsoft.DotNet.UnifiedBuild.Tests/Microsoft.DotNet.UnifiedBuild.Tests.csproj#L13
When I added the unit-test source file to this project and a necessary reference to Tasks project, I got the following build errors (just one here, for brevity):
/src/git/dotnet/.dotnet/sdk/9.0.100-rc.1.24452.12/Microsoft.Common.CurrentVersion.targets(2413,5): error MSB3277: Found conflicts between different versions of "NuGet.Packaging" that could not be resolved.
There was a conflict between "NuGet.Packaging, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35" and "NuGet.Packaging, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35".
    "NuGet.Packaging, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35" was chosen because it was primary and "NuGet.Packaging, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35" was not.
    References which depend on "NuGet.Packaging, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35" [/src/git/dotnet/.packages/nuget.packaging/6.9.1/lib/net5.0/NuGet.Packaging.dll].
        /src/git/dotnet/.packages/nuget.packaging/6.9.1/lib/net5.0/NuGet.Packaging.dll
          Project file item includes which caused reference "/src/git/dotnet/.packages/nuget.packaging/6.9.1/lib/net5.0/NuGet.Packaging.dll".
            /src/git/dotnet/.packages/nuget.packaging/6.9.1/lib/net5.0/NuGet.Packaging.dll
    References which depend on or have been unified to "NuGet.Packaging, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35" [].
        /src/git/dotnet/artifacts/bin/Microsoft.DotNet.UnifiedBuild.Tasks/Release/Microsoft.DotNet.UnifiedBuild.Tasks.dll
          Project file item includes which caused reference "/src/git/dotnet/artifacts/bin/Microsoft.DotNet.UnifiedBuild.Tasks/Release/Microsoft.DotNet.UnifiedBuild.Tasks.dll".
            /src/git/dotnet/artifacts/bin/Microsoft.DotNet.UnifiedBuild.Tasks/Release/Microsoft.DotNet.UnifiedBuild.Tasks.dll [/src/git/dotnet/test/Microsoft.DotNet.UnifiedBuild.Tests/Microsoft.DotNet.UnifiedBuild.Tests.csproj]

This was caused by direct references to NuGet assemblies in .NET SDK, from the Tasks project, and other projects under tools: https://github.com/dotnet/sdk/blob/8584c262d4d2e1a0af388271ae0715db3c53a2b6/src/SourceBuild/content/eng/tools/Directory.Build.props#L9-L19
  <!--
    Use some assemblies from the SDK, instead of package references. This ensures they match what's
    found when the task is loaded by the SDK's MSBuild.
    Reference NuGet assemblies, except a command line assembly that causes warnings such as:
    MSB3277: Found conflicts between different versions of "System.Collections" that could not be resolved.
  -->
  <ItemGroup>
    <SdkAssembly Include="$([MSBuild]::NormalizePath('$(NetCoreRoot)', 'sdk', '$(NETCoreSdkVersion)', 'Newtonsoft.Json.dll'));
                          $([MSBuild]::NormalizeDirectory('$(NetCoreRoot)', 'sdk', '$(NETCoreSdkVersion)'))NuGet.*.dll"
                 Exclude="$([MSBuild]::NormalizePath('$(NetCoreRoot)', 'sdk', '$(NETCoreSdkVersion)', 'NuGet.CommandLine.XPlat.dll'))" />
  </ItemGroup>

While, I can solve this by creating a new project for unit-tests, that would not have a dependency on any NuGet.* packages (as I don't need them), there might be other unit-tests in the future, that would need NuGet.* packages and will hit this issue. So, I think that we should have the right solution in place, to avoid such issues down the road.

Yes, that makes sense. It's a mismatch between a direct assembly reference (the NuGet assemblies from the .NET SDK) and a package reference. That is a general problem and RAR (ResolveAssemblyReference) warns about these to make sure that dependencies are compatible and can be unified.
Here, either all tasks need to use a package reference or if that isn't possible (i.e. because of prebuilts), the projects that reference task projects need to use the same mechanism to reference NuGet assemblies. Note that this only affects NuGet assemblies and Newtonsoft.Json. We have a tracking issue to remove the latter eventually.
Hope that helps.


Launch configs: resolve replacement patterns in object keys, in addition to values

From https://github.com/Microsoft/vscode-chrome-debug/issues/226
A chrome-debug config can have
            "sourceMapPathOverrides": {
                "webpack:///C:/Depot/Impakt/DNA/DNACore/*": "${webRoot}/*" // SUCCEEDS
                //"webpack:///${workspaceRoot}/*": "${webRoot}/*" // FAILS
                //"webpack:///${webRoot}/*": "${webRoot}/*"  // FAILS
            },

vscode replaces ${workspaceRoot} in values, and the adapter replaces ${webRoot} in values, and now after https://github.com/Microsoft/vscode-chrome-debug/pull/543, in keys as well. It would be great if vscode would replace ${workspaceRoot} in keys.
One issue is that you can have collisions where two keys are the same after applying these replacements. In chrome-debug now, the last one wins where "last" is technically undefined.

duplicate of #34059.
I've just raised the priority of this to "On Deck".


Language change for App

As a client, I would like to have a possibility of changing the language of the menu of the app and the articles, so I can understand the information and navigate through the menu.
SP: 3
Priority: Medium
Risk: Medium
Ideal time: 10 hours
Demo steps:
Choose language in the menu. Page should reload in the selected language including all the app menu items and the article(s).

[ ] Implement the language change
[ ] Write and implement test cases

This issue was moved to katiaru/wikipedia#4


Properly consider component parameter type

Fixes #1753
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Thanks for the feedback @kevin-bates, I have updated the pr and also identified a few corner cases, and added those to the test cases.


[feat] sfpegListCmp - Hide datatable when there is no data to display

Is your feature request related to a problem? Please describe.
In the standard related lists, only the list title is displayed when no data is available.
Currently the sfpegListCmp still displays the table header in such a case, which is not very UX friendly.
Describe the solution you'd like
Show no datatable when there is no data to display
Describe alternatives you've considered
None
Additional context
N/A

Implemented the feature and included the ability to specify an optional special message displayed when no data is available. see https://github.com/pegros/PEG_LIST/blob/master/help/sfpegListCmp.md#no-data-display-handling


fix: correct numbering in README installation instructions

Correct the numbering in the installation instructions of the README to ensure clarity and accuracy.

You're right, I learned this shortly after this PR was opened and forgot to close it. Thanks for taking care of it

@gaearon would you mind taking a look at this https://github.com/reactjs/react.dev/pull/7298 since it'd be a nice addition to the docs


Add configuration refresh

Changes in this pull request

Adds the ability for the SDK to refresh the Superwall configuration every session start, subject to a feature flag.
Tracks a config_refresh Superwall event when the configuration is refreshed.

Checklist

[ ] All unit tests pass.
[x] All UI tests pass.
[x] Demo project builds and runs.
[ ] I added/updated tests or detailed why my change isn't tested.
[ ] I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
[ ] I have run ktlint in the main directory and fixed any issues.
[ ] I have updated the SDK documentation as well as the online docs.
[ ] I have reviewed the contributing guide

If you haven't already, you defo need to test this by loading config, publishing a change on a paywall and doing a fake refresh after X seconds of config and seeing what happens. Would need to test it when the paywall is open and when the paywall is closed, as well as with and without preloading

If you haven't already, you defo need to test this by loading config, publishing a change on a paywall and doing a fake refresh after X seconds of config and seeing what happens. Would need to test it when the paywall is open and when the paywall is closed, as well as with and without preloading

Done, works good! Also added test for the Success & Failure cases.


[Feature Request] Add integration tests

Community Note

Please use a 👍 reaction to provide a +1/vote. This helps the community and maintainers prioritize this request.
If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Graph Explorer currently has no integration tests. The unit tests can only take you so far, then the integration tests must take you the rest of the way.

Tests around Neptune Gremlin/OpenCypher/SPARQL queries
Tests around other database use cases
Tests for different versions of database servers

This video contained some really good ideas for setting up a consistent test environment, and development environment, using Docker.

YouTube - Using docker in unusual ways
Docker Compose Watch
Testcontainers


Have an error Refused to execute script from 'https://dsp-test.decenterads.com/static/video.mp4' because its MIME type ('video/mp4') is not executable.

<VAST
version
="
2.0
"

<Ad
id
="
V
"

<InLine

<AdSystem

SR
</AdSystem

<AdTitle

V
</AdTitle

<Impression

https://supply.decenterads.com/?c=v&m=i&h=abccef36feababd3c3d19ad25e17af25
</Impression

<Impression

http://dsp-test.decenterads.com/?c=rtb&m=b&key=8460bfd810c295bfdeeef7b6a57b9776&cp=1.3938481783246515
</Impression

<Creatives

<Creative
sequence
="
1
"

<Linear
skipoffset
="
00:00:05
"

<TrackingEvents

<Tracking
event
="
creativeView
"

https://supply.decenterads.com/?c=v&m=e&t=creativeView&h=abccef36feababd3c3d19ad25e17af25
</Tracking

<Tracking
event
="
start
"

https://supply.decenterads.com/?c=v&m=e&t=start&h=abccef36feababd3c3d19ad25e17af25
</Tracking

<Tracking
event
="
midpoint
"

https://supply.decenterads.com/?c=v&m=e&t=midpoint&h=abccef36feababd3c3d19ad25e17af25
</Tracking

<Tracking
event
="
firstQuartile
"

https://supply.decenterads.com/?c=v&m=e&t=firstQuartile&h=abccef36feababd3c3d19ad25e17af25
</Tracking

<Tracking
event
="
thirdQuartile
"

https://supply.decenterads.com/?c=v&m=e&t=thirdQuartile&h=abccef36feababd3c3d19ad25e17af25
</Tracking

<Tracking
event
="
complete
"

https://supply.decenterads.com/?c=v&m=e&t=complete&h=abccef36feababd3c3d19ad25e17af25
</Tracking

<Tracking
event
="
skip
"

https://supply.decenterads.com/?c=v&m=e&t=skip&h=abccef36feababd3c3d19ad25e17af25
</Tracking

<Tracking
event
="
start
"

http://dsp-test.decenterads.com/?w=i&p=1.8265012271310659&uq=cf3aa800e3cdae0f5038089d1c48f281&t=v
</Tracking

<Tracking
event
="
start
"

http://dsp-test.decenterads.com/?w=i&p=2.811&uq=0d6c409cf9956f929df79ec06da620a3&t=v
</Tracking

<Tracking
event
="
start
"

https://dsp-test.decenterads.com/i?clid=vls&paid=sh&dvid=v&avid=Stream_IA_%241.5_11.06_Vpaid_5ee2303e56cb0a0001cd1fdb_asis_dup&caid=14348&plid=14348|0&publisherId=303&siteId=a9M6CaTvK18AJxF6R&priceBid=3&pricePaid=1&lineItemId=[LI_ID]&kv1=320x480&kv2=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.launcher.smart.android&kv3=7933f0775bc65af5c08c3d7c0d1a55f6b8b43d3533be8430b76e971b5ec0ac80&kv4=<IP_ADDRESS>&kv7=16467&kv11=8bd9ce99af590755dec2a344b2123189&kv12=1594711643&kv15=USA&kv16=39.1564&kv17=-75.4955&kv18=com.launcher.smart.android&kv19=430f553d-5989-4d6b-b6a6-21e68b5d9eea&kv23=Comcast Cable&kv28=Samsung SM-G928T&kv25=com.launcher.smart.android&kv26=android&kv27=Mozilla%2F5.0 (Linux%3B Android 7.0%3B SM-G928T Build%2FNRD90M) AppleWebKit%2F537.36 (KHTML%2C like Gecko) Version%2F4.0 Chrome%2F76.0.3809.111 Mobile Safari%2F537.36&kv9=[C_LENGTH]&kv10=Comcast Cable&kv13=14348|0&kv14=[MRAID_V]&kv29=[ERRORCODE]&kv30=[CONTENTPLAYHEAD]_[ADPLAYHEAD]&kv33=[ASSETURI]&kv34=[VASTVERSIONS]&kv35=[IFATYPE]&kv36=430f553d-5989-4d6b-b6a6-21e68b5d9eea&kv37=[CLIENTUA]&kv38=[SERVERUA]&kv39=[DEVICEUA]&kv40=[DEVICEIP]&kv41=[LATLONG]&kv42=none&kv43=[PAGEURL]&kv44=[VIDEO_TYPE]&kv45=[PLAYERSIZE]&kv46=[REGULATIONS]&kv47=[ADTYPE]&kv48=[TRANSACTIONID]&kv49=[BREAKPOSITION]&kv50=[APPNAME]&kv51=[PLACEMENTTYPE]&kv52=0&kv24=MobileInApp_Video
</Tracking

00:00:25

delivery
="
progressive
"
width
="
480
"
height
="
360
"
bitrate
="
10
"
type
="
video/mp4
"

https://dsp-test.decenterads.com/static/video.mp4
</MediaFile

{"m":"e9f_6b6","h":"ip-172-31-92-188","w":{"t":[{"t":1,"a":[{"i":"5f0c252cc152e50001a68985","u":"https://dsp-test.decenterads.com/advast?p=22336512&w=4&h=3&ifa=[IFA]&ua=Mozilla%2F5.0 (Linux%3B Android 7.0%3B SM-G928T Build%2FNRD90M) AppleWebKit%2F537.36 (KHTML%2C like Gecko) Version%2F4.0 Chrome%2F76.0.3809.111 Mobile Safari%2F537.36&bundle=[BUNDLE_ID]⪫=[USER_LAT]&long=[USER_LON]&lmt=[DO_NOT_TRACK]&minduration=1&maxduration=60&referrer=[APP_STORE_URL]&vast_version=3&vpaid_version=2&video_format_type=instream&GDPR=[USER_CONSENT]&player_width=[WIDTH]&player_height=[HEIGHT]&schain=&us_privacy=[US_PRIVACY]","e":1,"t":[{"event":"AdImpression","type":"img","url":"https://dsp-test.decenterads.com/i?clid=vls&paid=sr&dvid=v&avid=Specto_IA_%242.5_Star_13.07_%243.44_22336512&caid=5f0c252cc152e50001a68985&lineItemId=5ee2303e56cb0a0001cd1fdb&kv7=Smart_IA_%241.5_11.06_Vpaid_5ee2303e56cb0a0001cd1fdb&kv1=300x250&kv2=[PAGE_URL]&kv4=<IP_ADDRESS>&publisherId=5eb808368cac9100019971b6&kv11=[IMPRESSION_ID]&kv12=[PLACEMENT_ID]&kv16=39.1564&kv17=-75.4955&kv18=com.launcher.smart.android&kv19=430f553d-5989-4d6b-b6a6-21e68b5d9eea&kv27=Mozilla%2F5.0 (Linux%3B Android 7.0%3B SM-G928T Build%2FNRD90M) AppleWebKit%2F537.36 (KHTML%2C like Gecko) Version%2F4.0 Chrome%2F76.0.3809.111 Mobile Safari%2F537.36&kv24=Mobile_InApp_Video","sample":100,"env":"mobile_app"}],"r":"N3L0Uw","c":"NHL0Uw","b":"com.launcher.smart.android","dr":"2.50"}]}],"r":"p"},"qs":{"app_category":"IAB1,IAB3,IAB9","app_name":"com.launcher.smart.android","app_store_url":"https://play.google.com/store/apps/details?id=com.launcher.smart.android","br":"chrome mobile webview","brv":"76","bundle_id":"com.launcher.smart.android","cb":"1594711645452568129","cc":"UA8","dt":"mobile","env":"ma","gdpr":"0","height":"250","ifa":"430f553d-5989-4d6b-b6a6-21e68b5d9eea","ip":"<IP_ADDRESS>","ns":"0","org":"571726dabc28330002000007","os":"android","osv":"7.0","sid":"gqv2qMjCt3yP9c2y1QE","sjs":"2050","sta":"MD","tc":"5ee2303e56cb0a0001cd1fdb","tcc":"NHL0Uw","ua":"Mozilla/5.0 (Linux; Android 7.0; SM-G928T Build/NRD90M) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/76.0.3809.111 Mobile Safari/537.36","uc":"0","user_lat":"39.1564","user_lon":"-75.4955","width":"300"},"c":{"bl":"991","sid":"gqv2qMjCt3yP9c2y1QE","b":"ai","do":{"e":"https://dsp-test.decenterads.com/s2","c":"https://dsp-test.decenterads.com/x","s":"sdk.wolseri.com","f":"ff.streamrail.net","fm":"ffcdn.streamrail.net"}},"z":{"ac":"1","aw":1,"blf":"3020","la":"7","r1":"5b6fc747f9d6349c32d8186588142397","rs":"3299","rw":"320","ts":"zrn0UA"}}

??? Please, reformat your question and submit another issue.


Change url social

Issue No.:#633
Discription :I just changed the url of every social-links.
Expected Behaviour :

update ur branch n make fresh PR


Reduce dependency on transmute

https://github.com/microsoft/winrt-rs/pull/354#discussion_r525957262

use core::ptr::NonNull;

pub unsafe fn f<'a>(ptr: *mut u8) -> &'a mut u8 {
    NonNull::new_unchecked(ptr).as_mut()
}

produces
error[E0515]: cannot return value referencing temporary value
 --> <source>:4:5
  |
4 |     NonNull::new_unchecked(ptr).as_mut()
  |     ---------------------------^^^^^^^^^
  |     |
  |     returns a value referencing data owned by the current function
  |     temporary value created here

This is because core::ptr::NonNull::<T>::as_mut has signature
   unsafe fn as_mut(&self) -> &mut T
// -----------------^---------^-----
// should be unsafe fn as_mut<'a>(self) -> &'a mut T

which contradicts its claim to produce a reference of arbitrary lifetime.  Should we contact rust-lang/rust?

Closing this issue. Transmute is necessary in some cases. Feel free to create new issues for specific cases where you may feel we can improve.


Ruby documentation comments formatting

The documentation comments in the code are in the markdown format but are generated on a single line, which makes it unreadable and unparsable using markdown or rubydoc.info.
One example is the #create_envelope method (rubydoc).
The documentation comments are the only source of documentation that I found for the ruby client, and this issue makes it really hard to work with.

Hi Robert! We hear you! We have a project underway to create SDK-specific documentation. The first project's first outcome is our C# part 1 docs. Ruby is on the list but will be much later in the year since we're proceeding in order of the SDKs' popularity.
Regards, Larry

@LarryKlugerDS I believe the docs and code is generate by Swagger. Would is be possible in the meantime to fix the generation config to add newlines in the documentation comments so that it could be parsable using markdown? 🤔

Thank you for the idea. I have filed it as DCM-5284.
Unfortunately we have a limited engineering staff. But we'll see how it goes.


Bugfix for json deserialisation of integer values

The code looks good, but is missing unittests for the From methods


fix(app): Multiple issues

Looks good, but maybe change the name here

to Company meetings instead of Personal Meetings, since this is what they are called on the navbar.

Also, maybe have it so when you click on personal meetings, it opens a new tab or window


Chatterino extension causes disconnecting and reconnecting

Describe the bug
Chatterino extension causes disconnecting and reconnecting when switching channels on chrome with chatterino extension.
if you switch tabs really fast ur chatterino will crash.
To reproduce
open 2 tabs of 2 different channels, focus chat and switch between the 2
Chatterino version
Chatterino Nightly 2.1.5 (commit 556c2aef2, 02.11.2019)
Operating system
Windows 10

https://github.com/Chatterino/chatterino-browser-ext/issues/32


hideAddToQueue is not defined

Basic Information
The small x button on the add to queue page does not work due to this
Other Information
[Are there any additional information that we should know about?]

i don't know why i made this an issue. is literally 1 line fix

nvm was fixed in previous merge


Optimize the time for creating pods and services when creating new Job.

What you would like to be added?
For the creation events of large-scale jobs, such as PyTorch jobs, use multiple goroutines to initiate createPod and createSvc, which can reduce the time for jobs to create Kubernetes (k8s) resources.
Why is this needed?
If there are a large number of pods under a large-scale job, initializing the pods and services (svc) will take a lot of time. This will seriously affect the startup of a large-scale training job.
Love this feature?
Give it a 👍 We prioritize the features with most 👍

The places where pods and svcs are created are as follows. I've tried to modify it to use multiple goroutines for processing.
https://github.com/kubeflow/training-operator/blob/d7f69e870ea962cdc523ab5bcd8fd1c6566d7571/pkg/controller.v1/common/pod.go#L321
https://github.com/kubeflow/training-operator/blob/d7f69e870ea962cdc523ab5bcd8fd1c6566d7571/pkg/controller.v1/common/service.go#L185


Fix typo & to & in ne-mftransform-_mft_output_data_buffer_flags.md

Changed & to & in the sample code.

Thanks!

@GrantMeStrength You're very welcome! 👍


Can't import image from src

So I have a list of reviews each with an logo field which is a path to the image. The images are in an images folder in my src folder.
Example
logo: 'src/images/logos/zoosk-logo.png',
I have a Reviews component which renders out Review components from the list passing the review object as a prop.
In the Review component I then display the logo in an image tag. Like so:

This works great with npm start, but when I use the run build, the images aren't copied over to the build file so the links don't work.  I know if you import the image then webpack will bundle it in the build step. But I can't import it, because the path comes from a prop, and imports can only be done at the top.
Is there anyway to go around this? I'm relatively new to react.

I was looking for this right now. Maybe create-react-app could have a default img or assets folder to move it's content into the build file?

This feature was discussed in #28, but the previous conclusion was that it is out of scope for Create React App.
Would copying the files to the build folder with a separate script work for your use case?

@fson Oh I see, i thought it could've been done without ejecting. Copying the files to the build folder would be the better approach for me. Any material you could point me to that would allow me to do this?

No, you don't need to eject for this. Just import those images wherever you create this object.
import logo from './logo.png'
import logo2 from './logo2.png'

export default {
  logo,
  logo2
}

Then pass this object down as you like. Importing images can be done in any file.

This works great with npm start

Since 0.4.0, it shouldn't. (As you noted it was broken in production in the first place.) Please use imports in JS instead, or please explain why JS imports don't satisfy your use case. Thanks!

To clarify. Your mental model shouldn't be "I need to import files right where they will be used" (like in Inage components). Your mental model should be "There should never be string literals in my code meaning absolute URLs to assets because build system won't know to include them. So every time I want to write a string literal for image URL, I should instead write an import. The result of that import will be the string I want (and can pass anywhere else)."

Thanks a lot @gaearon i'm actually coming from an angular background so i'm new to react. Thanks for guiding me on the right path. Solution works !

This is not really React-specific by the way. It's just that we think automatic bundling of assets with content hashes and compile-time checks for missing files is valuable enough that we ask people to use this mechanism for importing instead. The feature is more related to Webpack, not to React.
Is there something in Usage Guide we could change to make this use case clearer?

Oh i guess that's true. The docs are great man, just a new way of thinking for me since i'm used to referencing static assets the more traditional way. Thanks again

@gaearon @iRoachie worked like a charm for me too. Much like @iRoachie, I'm also coming from an Angular background, where I didn't use even npm or webpack. Other day I was trying to do that with file-loader.. Webpack feels confusing for newcomers (at least for me).
Maybe a small section about importing static files would add a lot of value to create-react-app, as it was created to ease the configuration process - even being related to Webpack, not React.

I think there is a section on "adding images" in usage guide. Is there a way to make it more helpful?

Yes, the section is there. I think I was so focused on Webpack loaders that couldn't find it. It's very clear, can't be more helpful than that. Thanks.

Well I guess you could make a note saying that it's the only way of referencing local files.

@iRoachie Would you like to send a PR to make it more helpful?

I'm a little unclear on this...I followed the README to issue #28 about possibly adding a static assets folder, and then found this issue. After reading the above comments, i'm still unclear on what I'm supposed to do in my use case. Let me explain:
I have folders of logos for sports teams, organized by league. This results in MANY logos, i.e.:
/mlb
  arizonaDiamondbacks.svg
  atlantaBraves.svg
  ...*.svg
/nba
  atlantaHawks.svg
  bostonCeltics.svg
  ...*.svg
/nfl
  arizonaCardinals.svg
  atlantaFalcons.svg
  ...*.svg
/*

The list goes on and on. I have a .json file where each team has an id and a league name that maps to the file's name. So when I map over each team's object, the URL to the team's image is dynamically inserted as a background-image in CSS, i.e.:
<h3 style={{backgroundImage: `url(assets/img/${team.league}/${team.id}.svg)`}}>
  {team.name}

If I switch over to using react-create-app (which I'd like to, because configuring webpack and keeping dependencies up to date is a headache for me) I'm unsure of how I would handle this case. Using import is impossible (unless you can dynamically import somehow??). If I understand this comment it seems like I'm supposed to create a separate JS file where I have to manually import and export every-single-file that I'm going to use, i.e.
import atlantaHawks from 'nba/atlantaHawks';
import atlantaBraves from 'mlb/atlantaBraves';
...
export {
  atlantaHawks,
  atlantaBraves
  ...
}

And then I import that in my file where I map over each object and just dynamically map somehow? that to imported file's name, i.e.:
import {*} from 'logos';

// later in render()
// somehow my `id` matches the import name? i.e. import {atlantaHawks} matches `team.id` when it's 'atlantaHawks' ??

  {team.name}

That seems like a lot of work to have to manually keep a list of files i'm importing/exporting? Seems like it'd be a lot easier to just keep track of my files and I can reference them myself in a static folder as I see fit. Could somebody shed some light on my use case here? I'm unclear how I should handle this when i'm not just referencing one or two images.

We'll likely support this in some way in 1.0. We just need to look at more use cases and decide on the optimal way to do that.
For your use case, just copying files seems reasonable and I agree we should allow it in the future. In this case they would be handled outside of the build system, without imports.
But the downside is that your images won't get "revved" so if some of them change, you'll have to manually add ?version or something like this to the query string, or browsers will cache older versions. In addition, if a file is accidentally missing or misspelled, you won't know this at compile time. All of this works automatically if you use imports.
As I said, I'm open to supporting your use case. I'm just struggling to figure out how to enable it in a way that people understand that importing is still what you should do in 90% of cases. I'm worried that if we just add support for "static" folder that gets copied as is, people will always put images there by habit, and won't realize that there are benefits to doing it via imports (compile errors on missing file, cache busting, potentially image minification if we enable it).
If you have a proposal on how to enable something like a static folder, but somehow make it clear it is an escape hatch for projects with hundreds of assets unrelated to components, rather than the normal way of adding images, I'd love to hear it.
I am keeping this issue open because I want to address it, but I'm not sure how yet.

Your use case is actually fully supported thanks to an awesome webpack feature called dynamic require
Instead of manually writing all your import statement, you can dynamically require your images with runtime parameters like require('./teams/' + team + '/' + image + '.svg') and webpack will auto-magically figure out what files could match this expression and include them in your bundle.
Here is an example based on the create-react-app starter template:

If you run npm run build on this app, you get a bundle that will look like this:

Webpack automatically figured-out all the files that could match
require(`./teams/${team}/${image}.svg`)

and included them in your bundle :)

@gaelduplessix When I tried that it gave the error that *img is not a module

We don't officially support Webpack's "non-standard" features like require.context. They happen to work but we make no promises about continuing to support them, and may break them any time.
Ideally we'd like to forbid their usage just to make this clear, but we haven't had time to work on this.

@gaearon Indeed, just stumbled on this comment saying it's not officially supported... That's still a workaround until there's a supported way for this use case though.

Totally understand where you're coming from. As I'm relatively unfamiliar with using import for things like images, I was just unsure if my particular use case should be bent to fit the import model used here. Plus, the README pointed me to this issue saying "if you prefer static assets ... please let us know". So perhaps my case is one you can consider in future implementations.
As far as how to make that clear, I'm not sure. But something along the lines of what you already have would go a long way I think, i.e. the docs specifically say "if you need to use images, use import" with an explanation/example. Then as a footnote to that it could say "oh and if you need static images or assets, create a folder name static and anything in there will copied directly over, but beware for X, Y, Z reasons". Having to create a static folder that doesn't exist by default might possibly help deter people from thinking "oh, i can just drop everything in here", i.e. if they create the folder they presumably read the docs and warnings (however I grant that it could become possible that they just read on a stack overflow answer "hey just create a folder named static and everything in there gets copied" so they don't get that context from the docs on why they should use import in 90% of cases).

Yea, this totally makes sense. Thanks for the conversation. I'll cut a release when I'm back from vacation in about two weeks.

I drafted a proposal to solve this in https://github.com/facebookincubator/create-react-app/pull/703. Unless we find some fatal flaws, it should come out in 0.5.0. Let me know what you think!

Closing as this is fixed, and will be released in 0.5.0.

This is now supported in 0.5.0.
Read about using the new public folder.
See also migration instructions and breaking changes in 0.5.0.

@gaearon why isn't webpack require recommended to use ? I don't understand why this is not a standard feature of webpack as it's in its documentation
I would love to use this feature myself as I have a structured folder of assets and manually importing them seems too heavy to maintain and using the public folder implies possible cache issues or 404 for the users.
Sorry if my question looks dumb; I just started using React and this project is a very smooth way to learn it !

@gaearon is it possible to set favicon of the app from src directory and deleting the one present in public directory?

No @anshumanv

For my case using imports is problematic, as I have an object class that one of its properties is an image URL, and I want to provide a path, but React doesn't recognize that path in this way.

@gaearon good insight. My vote would be to allow for static and import. I've always dealt with static. With great power comes great responsibility. This has been a huge source of headache for me. Like the previous posters have declared I to want a clean way to dynamically add images from a large repository of image and using the create-react-app has made that task near impossible, unless as you previously mentioned I have a flat JS file with image assets and then that file could possibly become outdated. Webpack is and never will be perfect. Developers need the flexibility to reference assets in public in develop mode.

Yep per docs PUBLIC_URL is set only in production.  In development it is set to empty string as expected, and if you reference  the dev server essentially serves /img/logo.svg, when the file is in your public folder under /public/img/logo.png
As this is an old issue, I would appreciate it if you open a new one if you have additional questions on this.

@bugzpodder yeah that's a problem. This whole assets thing is really overcomplicated. There needs to be an asset exposer function in the service worker. @bugzpodder I don't have any questions on this. I'm just a bit annoyed at the current work-around. Here's what I ended up doing. This works perfectly but I am not looking forward to maintaining a static list of images:
import kris01 from './kris01.jpg';
import kris02 from './kris02.jpg';

let imgs = {
    kris01,
    kris02
};

function getImage(key) {
    return imgs[key];
}

export default getImage;

Here's my wonderful little component that will be used in many places throughout my web app:
import React from 'react';
import getImage from './imgMap';

class ImageWithCaption extends React.Component {

    constructor(props) {
        super(props);
        this.image =
            {
                captionText: this.props.captionText || 'Default',
                uri: this.props.uri || '#',
                alt: this.props.alt || 'Alternative'
            };
    }

    render() {
        const IMAGE = getImage(this.image.uri);
        return (

{this.image.captionText}

        );
    }
}

export default ImageWithCaption;

So anyone else who is stuck on this for hours-on-end will hopefully have somewhat of a solution, or rather a hack, for development mode.

Last but not least I'm invoking the component with this for now (demo):
            <ImageWithCaption
                id="kris01"
                captionText="Paleo Services is a site for fossil collectors..."
                uri="kris01"
                alt="Kris 01"
            ></ImageWithCaption>

For you ES6 fans out there here is the image fetcher:
import kris01 from './kris01.jpg';
import kris02 from './kris02.jpg';

let imgs = {
    kris01,
    kris02
};

let getImage = (key) => imgs[key];

export default getImage;

Get Image from Local Resource Folder in React Native
React native provides a unified media management system so developers can easily manage all the image files by placing them together into a single folder. So here is the complete step by step tutorial for Show Image from Local Resource Folder in react native.
https://www.skptricks.com/2018/07/get-image-from-local-resource-folder-in-react-native.html

No, you don't need to eject for this. Just import those images wherever you create this object.
import logo from './logo.png'
import logo2 from './logo2.png'

export default {
  logo,
  logo2
}

Then pass this object down as you like. Importing images can be done in any file.

I am unable to import images that are outside of the src file.


[Exposure Request] codeunit 7002 "Price Calculation - V16" - IsDegradedLine

Please make function IsDegradedLine externally available.
procedure IsDegradedLine(PriceListLine: Record "Price List Line"; BestPriceListLine: Record "Price List Line") Result: Boolean
begin
    Result :=
        IsBlankedValue(PriceListLine."Currency Code", BestPriceListLine."Currency Code") or
        IsBlankedValue(PriceListLine."Variant Code", BestPriceListLine."Variant Code");

    OnAfterIsDegradedLine(PriceListLine, BestPriceListLine, Result);
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 47754.


KVM Acceleration not working

When installing Windows 11 I get
windows  | ❯ Building Windows 11 image...
windows  | ❯ Creating a 64G growable disk image in raw format...
windows  | ❯ ERROR: KVM acceleration not detected (device file missing), this will cause a major loss of performance.
windows  | ❯ ERROR: See the FAQ on how to enable it, or continue without KVM by setting KVM=N (not recommended).
But when I followed the FAQ and did
sudo apt install cpu-checker
sudo kvm-ok
It says
kam@debian:~$ sudo apt install cpu-checker
sudo kvm-ok
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
cpu-checker is already the newest version (0.7-1.3+b1).
0 upgraded, 0 newly installed, 0 to remove and 9 not upgraded.
INFO: /dev/kvm exists
KVM acceleration can be used
What do I do?

How does your compose file look like? Seems like you forgot to add /dev/kvm there.

version: "3"
services:
windows:
image: dockurr/windows
container_name: windows
devices:
- /dev/kvm
cap_add:
- NET_ADMIN
ports:
- 8006:8006
- 3389:3389/tcp
- 3389:3389/udp
stop_grace_period: 2m
restart: on-failure

Same here
❯ Starting Windows for Docker v3.05...
❯ For support visit https://github.com/dockur/windows
❯ CPU: AMD Ryzen 5 1600 Six Core Processor | RAM: 15/16 GB | DISK: 363 GB (ext4) | HOST: 6.8.0-31...
❯ ERROR: KVM acceleration not available (device file missing), this will cause a major loss of performance.
❯ ERROR: See the FAQ on how to enable it, or continue without KVM by setting KVM=N (not recommended).
but I do find al the KVM checks to be fine
kvm_amd               208896  0
kvm                  1437696  1 kvm_amd
irqbypass              12288  1 kvm
ccp                   143360  4 kvm_amd
Description:    Ubuntu 24.04 LTS
Release:        24.04
Codename:       noble
6.8.0-31-generic

got it working:
config --device /dev/kvm into container /dev/kvm

But you already had it in your compose file:
devices:
- /dev/kvm

So what change did you make to your compose file?

devices:
  - /dev/kvm:/dev/kvm

I actually use CasaOS, and just edited it whiting the GUI / app, but that line should do it.

that's my CasaOS setting, which exportes in YAML as: - /dev/kvm:/dev/kvm
was the only way I could make KVM work for me

I have the same issue: when I do the kvm-ok check, it tells me that I can use KVM, but I'm still stuck with ERROR: KVM acceleration not available (device file missing), this will cause a major loss of performance.
I have put the kvm path in devices and privileged is true, but still no dice.
Any suggestions? Would you like more info?

Same problem here. Using docker desktop 4.33.0

If you were trying to run the container via Docker Desktop and received this error, you can try to use Docker Engine directly. Docker desktop uses a virtual context desktop-linux which does not have enough permission to /dev/kvm, see here: Install Docker Desktop on Linux.
Docker Desktop for Linux and Docker Engine can be installed side-by-side on the same machine (but do not run them simultaneously). So what you need to do is:

Stop docker desktop by clicking Quit Docker Desktop or executing:

systemctl --user stop docker-desktop

Install docker engine. Instructions can be found here: Install Docker Engine
Run docker with sudo. You won't need parameter --privileged.

@kroese consider add some tips in README.md that tell users not to use Docker Desktop? Using Docker Desktop may be the cause of some other similar issues like #856 and seems to be a common practice recommended officially (see here: Install Docker Engine on Ubuntu):

You can install Docker Engine in different ways, depending on your needs:

Docker Engine comes bundled with Docker Desktop for Linux. This is the easiest and quickest way to get started.

Maybe you can add this to your FAQs:
If you are using Docker Desktop and encounters an error indicating the /dev/kvm is missing, permission is not adequate or kvm acceleration is not available while kvm_ok check receives no error, try to use docker daemon directly without Docker Desktop.
The key reason for the fact that docker daemon (from Docker Desktop) fails to find /dev/kvm is that the docker daemon runs in a virtual machine created by Docker Desktop, not on the host (like docker engine does), so it cannot access the low-level hardwares like /dev/kvm and it will fail at the device mounting step, see here: Why does Docker Desktop for Linux run a VM?. Even with --privileged, the docker daemon in the VM can start with no error and mount /dev/kvm, but this is a low-level hardware, but Docker Desktop only processes high-level hardwares, so the container eventually fails at the step where it trys to communicate with the device.

I have resolved my Issued with this
services:   osx:     image: dockurr/macos     container_name: macos     environment:       VERSION: "13"       devices:         -/dev/kvm       KVM: "N" ---- THIS line solved the problem     cap_add:       - NET_ADMIN     ports:       - 8006:8006       - 5900:5900/tcp       - 5900:5900/udp     stop_grace_period: 2m


Shellcheck issues warning when running on circle-ci

This is seen in circle-ci logs (see here for an example):
#!/bin/bash -eo pipefail
make check dep-check
shellcheck: unable to decommit memory: Invalid argument

This GitHub issue seems to track this. It appears innocuous, but we may want to install a newer shellcheck or build it ourself to avoid this warning.

Installing spellcheck stable (0.5.0) solves the issue. https://github.com/ligato/networkservicemesh/pull/327/files#diff-dc2f19473ed2123d5ba8b6fa9cb89383

Should this issue be closed now?

I think it's fixed, would be happy to close but do not have permissions.


Find common words, sub-phrases in list of texts?

Hello there,
i have an application where i have a list of texts (definitions) and a functionality is required
to find common occurances of sub-phrases (sometimes just common words)
i would not like to use a simplistic approach to just match common words since the type of matching (e.g common sub-sequence or n-gram is important).
So i saw lunr.js and thinking about using it, any recommendations?
Note the texts are usually in greek, but i think i can add custom stemmers and stop-words for greek (per related issues/questions and references therein)
Thank you

Let me check I understand what you're trying to implement:
You have a set of documents and you want to find all the documents which contain certain phrases? If this is correct then you can certainly use lunr for this, though you might want to customise it slightly for you use case.
lunr is specifically more about ranking a set of documents on how similar they are to a certain query. It sounds like you don't really care about ranking how similar they are, just whether a document contains some words.
You might want to look at creating custom processing, there is an old pull request that has code for adding an ngram tokeniser that might be useful to you
Greek shouldn't be an issue for lunr, you will just have to set up the right stemmers and stop words, you can see this done for other languages in the lunr-languages repo, if you do put together a greek language plugin please do add it to that repository.
Please re-open if you have any further questions or if anything is not clear.

Thanks for the answer.

You have a set of documents and you want to find all the documents which contain certain phrases? If this is correct then you can certainly use lunr for this, though you might want to customise it slightly for you use case.

Not exactly, the converse is needed, i.e find documents (actualy textual definitions in the list of definiitons) which contain similar phrases (for example "the quick brown fox" and the "the quick red herring") sth like that. The context is an application creating crossword puzzles and in the process of adding definitions to a compiled puzzle the creator wants to make sure that definitions are more or less unique (without checking one-by-one manualy) meaning the definitions are not similar (like the example above).
Hope this clarifies the question even more. Any help (or pointers) is appreciated


Doesn't start Centos 7 service as it's now systemd

It seems that many services on CentOS 7 have been moved from init.d to systemd. (I suppose it's the same for RHEL 7)
Maybe it would be a good thing to change the service provider in this case:
service node['ntp']['service'] do
  supports status: true, restart: true
  action [:enable, :start]
  timeout 120 if platform_family?('windows')
  retries 3
  retry_delay 5
  provider Chef::Provider::Service::Systemd if node[:platform] == "centos" && node[:platform_version].to_f >= 7.0
end

or something like that.

Modern chef releases should do this automatically. What version of Chef are you running?

Use Systemd for recent Fedora and RHEL 7. was part of the 12.0.0 chef release

OK, that was the point (Chef 11), I close the issue. Thanks


Update me

What's up? How are things moving along? What things are we planning on implementing?

Helllo.

Hey! I'm saturated in homework stuff at the moment, and I need a clean mind to actually code :P
I'll make a change to the shift+enter code and then I'd release it.

Should I take care of translations now?

I'm happy to continue with it.. there's nothing new right? Remember to credit those mentioned in the Discord!

Nothing new
Things to do:
Check all strings are in all languages
Add translation credits (every messages.json should have at the end a credit term, if not, check in Spanish and copy paste)
Busy is killing m e :(

Okay, have we made the timings consistent (3 vs 5 mins)?


Chore: fox lin and address some dependency issues

stellar-disbursement-platform-frontend-preview is available here:http://sdp-frontend-pr163.previews.kube001.services.stellar-ops.com/


Update PR Template

Removed code style checking from the template. It is checked by the CI anyway. No PR can be merged without passing this.

Could we add checkboxes to all items in the list?
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
would become
- [ ] Unit tests are added for small changes to verify correctness (e.g. adding a new operator)

I think the list items are intended as enumeration of possible situations. They usually don't apply all at once.

+1 on sheng's comment

Could we add a note that not applicable items should be removed from the description? It's sometimes hard to see the actual message between the default text lines

Done

@eric-haibin-lin would you add an item to remind the committers to check the API doc of the PR? See details in #9928. It should read like:
Committers should check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html. (e.g. link)

@szha That is nice! Didn't know we were building API docs for each PR.
+1 for adding that

Done

Could we also add an item to remind people linking the JIRA issue?

Done. Although I'm a little bit worried that all these reminders make the template kind of heavy

Agree, we might have to do a proper cleanup of that template and make it more lightweight.


SGX-enabled pods sometimes get created without SGX device mounted

Describe the issue
Not entirely sure if that is a bug in IDP, perhaps it just needs some explanation on how to properly ensure that sgx.intel.com/epc is available already or an upstream K8s/kubelet issue.
We are seeing a randomly occuring situation where Pods with "requests: sgx.intel.com/epc: 1Gi" defined in the Pod Spec get created without the necessary /dev/sgx_enclave volume mount. This causes the workload to fail due to lack of the SGX device (ENOENT error in Gramine).

When inspected by crictl, the mount points are missing in the containers.
We've seen this happening for Pods which are managed by Deployments, StatefulSets and Jobs,
Usually, removing the affected resource (Depoy/STS/Job) & resyncing the resource (equal to 'kubectl replace') causes the Pod to start correctly,
Delaying a specific container (e.g. by using sleep in an init-container) does not change a lot, perhaps because this aspect is connected with Pod (and not container) creation time.

My (intuitive) understanding is that until "sgx.intel.com/epc" is registered on the node, the Pod should not get created (due to being unschedulable for insufficient resources)?
If that intuition is wrong, what is the correct way to make sure that the Pod creation waits for "sgx.intel.com/epc" availability? Since this process is done as part of an automated flow (ArgoCD), we are not currently fully sure in what order the resources will get created.
To Reproduce
No clear reproduction scenario, happens randomly. We did not find a correlation with specific OCP version.
Expected behavior
Pod is created with the necessary volume mounts with /dev/sgx_enclave each time.
System:

OS version: Red Hat OpenShift 4.14, 4.15
Kernel version: RH kernel versions based on 5.14
Device plugins version: v0.28 from OpenShift OperatorHub
Hardware info: 4th and 5th Gen Intel Xeon Processors with QAT

Additional context
It might be an edge-case similar to the issue noticed for nVidia GPU (this specific comment): https://github.com/NVIDIA/k8s-device-plugin/issues/291#issuecomment-1041459716.
Similar as in the linked issue, the Pod somehow gets started before sgx.intel.com/epc can be succesfully allocated and mounted. Very curious why that happens.

@Feelas can you check the pod's resources when the error happens?
I believe you only get
sgx.intel.com/epc: 1Gi

and not
sgx.intel.com/epc: 1Gi
sgx.intel.com/enclave 1

which then suggests the operator has failed to mutate the pod. you could check the API server logs for more details why the operator/webhook had failed

Not sure if it's related, but we've seen somewhat similar with e2e fpga. Seems like a Pod is scheduled with the generic resource name (Pod goes to Pending) and when the operator comes fully online it doesn't detect the Pending pod. Pod is left in Pending state.

@mythi we've managed to trigger the error again.
As a result:

sgx.intel.com/enclave was indeed missing from the resources section of the pod and thus Gramine failed.
Pod was stuck in CrashLoopBackOff for a very long time,
none "admission: Mutated SGX Pod" messages for this specific Pod were present in the logs (controller-manager Pod)
after DELETEing the Pod, instantly there are the logs with "admission: Mutated SGX Pod" for our workload and it starts correctly.

Given my limited knowlede of webhooks:

I took a quick look at webhook triggers and it looks like it is hooking on the CREATE operation of the Pod (webhooks.rules for SGX MutatingWebhookConfiguiration).
Will a restarting Pod match a "pods Create" rule for a Webhook? Maybe that is the reason for this behaviour.

If yes, it looks like the webhook might not handle "retroactively" mutating Pods w/ SGX requests that were created on the cluster before the webhook itself is created and registered, unless of course I am missing something about how the webhooks work.

If yes, it looks like the webhook might not handle "retroactively" mutating Pods w/ SGX requests that were created on the cluster before the webhook itself is created and registered, unless of course I am missing something about how the webhooks work.

I'd like to understand why the mutation gets missed on CREATE because that's what starts CrashLoopBackOff.


extract_features.py argument fixes

Fixes an issue where command line arguments --image_list and --feature_path were not being passed to the main function.

Thank you!


Added Tri-Chandra Multiple Campus

Tri-Chandra Multiple Campus

@suulaav First stage of verification passed, official domain is m.facebook.com as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://m.facebook.com/tmgpremtmg/photos/a.647115135722016/1283592705407586/?type=3&locale=ne_NP&_rdr

@suulaav Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Upgrade milvus to 2.2.1, helm values to 3.3.6, bump version

Signed-off-by: shaoyue.chen<EMAIL_ADDRESS>/cc @zwd1208

/lgtm


Configureable file formats for auto.sh

Hi,
For personal projects I use .node-version file, but at my work we use nvm file format .nvmrc to detect node version. It would be nice to be able few file name formats for auto.sh.

I added CHNODE_AUTO_VERSION_FILENAME shell variable, which can be used to set the filename for the version files. To use with .nvmrc files, set CHNODE_AUTO_VERSION_FILENAME=.nvmrc. Details are in the readme. Would this work for you?

Yes, thank you!


Add order adjustment for gift cards

The adjustment value comes from Magento’s gift_cards_amount field, however it should be noted that this information is duplicated across multiple different fields:
"gift_cards": "[{\"i\":1234,\"c\":\"<<REDACTED>>\",\"a\":20,\"ba\":20,\"authorized\":20}]",
"base_gift_cards_amount": "20.0000",
"gift_cards_amount": "20.0000",
"base_gift_cards_invoiced": "20.0000",
"gift_cards_invoiced": "20.0000",

In the end, I chose to use the value from gift_cards_amount for this adjustment.
I’ve simply called the adjustment Gift Card, even though it should be possible to use more than just a single one.
However just in case it’d come in useful for any queries into how people are using gift cards I’ve mapped the JSON content from gift_cards into the order’s attributes (taking care to ensure we don’t inadvertently receive the gift card's code in case it has any remaining balance after the transaction).
I didn’t want to rely on the JSON content of the gift_cards field for the adjustments field in case the content of this field isn’t stable across Magento setups if they use different gift card implementations (i.e. extensions vs. Magento enterprise etc.).

Code looks like it makes sense, I have not replicated it end to end. Have you got some example screenshots of it from Magento to Solve?

Have you got some example screenshots of it from Magento to Solve where we can see it resolve to the correct final price?
I've included this information in the original Jira ticket.


Unable to set a cpu mode for a VM

Is this a BUG REPORT or FEATURE REQUEST?:
kind bug
What happened:
Attempted to set a VM to use host-passthrough for the CPU mode in the template, as per https://kubevirt.io/user-guide/#/workloads/virtual-machines/virtualized-hardware-configuration?id=mode
I can successful edit the VM template:
apiVersion: kubevirt.io/v1alpha2
kind: VirtualMachine
<...snip...>
    spec:
      domain:
        cpu:
          mode: host-passthrough
<...snip...>

But upon starting the VM, the cpu property gets reset to {}:
apiVersion: kubevirt.io/v1alpha2
kind: VirtualMachine
<...snip...>
    spec:
      domain:
        cpu: {}
<...snip...>

What you expected to happen:
That the CPU property would be honoured and the VM would boot in host-passthrough mode.
How to reproduce it (as minimally and precisely as possible):
Create a VM and attempt to set the CPU property to 'host-passthrough' as above.
Anything else we need to know?:
Environment:
$ virtctl version
Client Version: version.Info{GitVersion:"v0.6.2", GitCommit:"467db5c8ce17c5ca8e851809af1d890cf8dd900d", GitTreeState:"clean", BuildDate:"2018-07-18T11:24:15Z", GoVersion:"go1.9.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: &version.Info{GitVersion:"v0.6.2", GitCommit:"467db5c8ce17c5ca8e851809af1d890cf8dd900d", GitTreeState:"clean", BuildDate:"2018-07-06T21:23:23Z", GoVersion:"go1.9.4", Compiler:"gc", Platform:"linux/amd64"}
kubectl version
Client Version: version.Info{Major:"1", Minor:"10+", GitVersion:"v1.10.0+b81c8f8", GitCommit:"b81c8f8", GitTreeState:"clean", BuildDate:"2018-06-25T19:44:16Z", GoVersion:"go1.9.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"10+", GitVersion:"v1.10.0+b81c8f8", GitCommit:"b81c8f8", GitTreeState:"clean", BuildDate:"2018-07-03T22:26:30Z", GoVersion:"go1.9.4", Compiler:"gc", Platform:"linux/amd64"}

VM or VMI specifications:

- apiVersion: kubevirt.io/v1alpha2
  kind: VirtualMachine
  metadata:
    creationTimestamp: null
    labels:
      kubevirt-vm: ${NAME}-vm
    name: ${NAME}
  spec:
    running: true
    template:
      metadata:
        creationTimestamp: null
        labels:
          kubevirt-vm: ${NAME}-vm
      spec:
        domain:
          cpu:
            mode: host-passthrough
          devices:
            disks:
            - disk:
                bus: virtio
              name: disk0
              volumeName: ${NAME}-pvc
            - cdrom:
                bus: sata
                readonly: true
              name: cloudinitdisk
              volumeName: cloudinitvolume
          machine:
            type: q35
          resources:
            requests:
              memory: 8192Mi
        terminationGracePeriodSeconds: 0
        nodeSelector:
          kubernetes.io/hostname: computenode0.example.com
        volumes:
        - name: ${NAME}-pvc
          persistentVolumeClaim:
            claimName: ${NAME}-pvc
        - name: cloudinitvolume
          cloudInitNoCloud:
            userData: |-
              #cloud-config
              password: ${PASSWORD}
              disable_root: false
              chpasswd: { expire: False }
              ssh_authorized_keys:
              - ${KEY}

Cloud provider or hardware configuration:
Dell PowerEdge R930

OS (e.g. from /etc/os-release):
NAME="Red Hat Enterprise Linux Server"
VERSION="7.5 (Maipo)"
ID="rhel"
ID_LIKE="fedora"
VARIANT="Server"
VARIANT_ID="server"
VERSION_ID="7.5"
PRETTY_NAME="Red Hat Enterprise Linux Server 7.5 (Maipo)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:7.5:GA:server"
HOME_URL="https://www.redhat.com/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 7"
REDHAT_BUGZILLA_PRODUCT_VERSION=7.5
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="7.5"

Kernel (e.g. uname -a):
Linux master.example.com 3.10.0-862.el7.x86_64 #1 SMP Wed Mar 21 18:14:51 EDT 2018 x86_64 x86_64 x86_64 GNU/Linux

@dcritch can you check if it works if you use model instead of mode?

@rmohr yup, model works. I switched to Conroe to test/as per example and it was effective

Ok. So it looks like the user-guide is messed up. We don't have a mode field right now. Just model. If you don't set model it should use host-passthrough. Otherwise it would use the specified model. @dcritch in your case you should actually not have to set anything.

I don't get host-passthough, I get <cpu mode='custom' match='exact' check='full'> if I don't set anything

Actually I don't know what I get....
In the virt-controller pod, if I do a virsh dumpxml VM, I get:
  <cpu mode='custom' match='exact' check='full'>
but if I cat the xml on the filesystem I get:
# cat /etc/libvirt/qemu/goldmanperf_goldman01.xml | grep 'cpu mode'
  <cpu mode='host-model' check='partial'>

Opened https://github.com/kubevirt/user-guide/pull/107. This aligns what we currently have in the code with the user-guide. We don't have the mode field. We only have model. If you don't set a model, your host cpu will be examined and the closest matching cpu model known by qemu/libvirt will be selected, aka host-model.
So right now host-passthrough can't be selected on the API.

Is selecting it in the works? I was under the impression from @fabiand that it already was there

@dcritch Will push the PR today.
@fabiand @rmohr @dcritch From API perspective do we want to introduce mode field or adding boolean passthrough to CPU section can be enough?

@cynepco3hahue we could also add special model types: host-passthrough and host-model. Not sure if we need/want extra fields for that.

@cynepco3hahue we could also add special model types: host-passthrough and host-model. Not sure if we need/want extra fields for that.

@michalskrivanek do you have some thoughts?

@rmohr mm model: host-passthrough looks a little bit strange, but if everyone agrees I can do it this way.

@rmohr,
we do not need to mirror the exact libvirt syntax here. We do want to use named models, add(maybe remove/forbid, though I haven't really seen a use for it in real deployments) individual flags, and host-model, host-passthrough as special cases.
With host-(model|passthrough) it would be great to get the resulting CPU details somewhere (in status?) as that information is going to be useful(well, mandatory really) for scheduling, user display, etc.
so, I think we're good with "model: (libvirt named model|host-passthrough|host-model)", and need to figure out how to do flags (usually a list of +-flag, again maybe we're fine just with an implied "add") and how to get the result back to the user. That's all fine as a followup of course

oh, and also need to figure out how we want to express the secured variants. currently it's with additional flags, but it may make sense to use a separate field (secure: yes|no). I think that's the only way how to keep it user friendly/understandable and it doesn't explode in too many named types either (I like the recent "AMD EPYC IBPB SSBD" in oVirt:-D)

oh, and also need to figure out how we want to express the secured variants. currently it's with additional flags, but it may make sense to use a separate field (secure: yes|no)

I like the secure boolean solution.

maybe it's to early to add secure?
For this specific issue I wonder if we can do an opt-in for pastshrough, as it's a pretty special case (i.e. influences migration).
usePassthrough: true would be something for this specific case.
Then it's also easily validateable i.e. when we get live migration.

Why would it be easier validatable? You would have to check two fields then, since the model does not have any meaning and would not be allowed to be set.


Added onSequenceStep()

Since the changes were already made to the sample app, The change should also highlight on the Main page.

Thanks!


Make managed environment activity delete description shorter

In general, I want to start making our activity descriptions shorter.  One idea is to remove the Deleting Container Apps environment "mwf-3" or at least shorten it to something simpler (e.g. Deleting environment... or similar) since this information is already shown in the activity title.

It's a little bit complicated since the title is the name of the wizard, I believe. So while it works in this case, sometimes it will say "Creating Web App", but the description is set up to show all the steps that are running which is helpful to know.
I think the end goal should be that each step appears as a child underneath the title, which will make the description being too long to view less of an issue.
In this specific case though, we could probably just change the description to "This may take several minutes..." since the title does happen to match the step name.

Yeah, I'm not so much worried about the title as I am the description, which we can control with the progress report message


Reverting the changes

There are conflicts and reverting the
changes as the changes not working.
Signed-off-by: subhamkrai<EMAIL_ADDRESS>
Description

This PR fixes #
Notes to reviewers:
Checklist

[] DCO signed.
[] Title of the PR starts with area name, e.g. meshery:, mesheryctl:, ui:.

fixes #800


[DRAFT] feat: add support for CycloneDX XML

This adds support for CycloneDX XML as an input format. Format detection is being done by introspecting the bytes of the given document.
In addition to this, an abstract SBOMDocument was introduced which will make it possible to add additional SBOM formats (SPDX 2.x, JSON, YAML etc.) later on.
For now, only the ecosystems command has been extended. If this approach is deemed fine I can extend other commands as well.
TODO

[ ] Add copyright headers to sbom package
[ ] Add functionality to all commands processing document input

👍 on the approach here. Good stuff.

cheers @garethr , now ready for review.


Scope of saved queries

Hi,
As far as I can understand, the saved queries are saved on a specific scope, e.g. the resource that the query is saved on. When I save a query that I've made and run from a specific Log Analytics Workspace, this is not available from the Logs page directly under Azure Monitor - not even if I select the correct scope for the query. Is this correct? Could this be a bit more elaborated in the documentation, maybe also with some input on how this should be used - especially between Azure Monitor and each individual Log Analytics Workspace.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 773e07ff-6bd8-47b2-5b83-75c7246693e6
Version Independent ID: 8723d5a6-ac93-0dba-b2b8-83905d807d67
Content: Tutorial: Get started with Log Analytics queries - Azure Monitor
Content Source: articles/azure-monitor/log-query/get-started-portal.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @bwren
Microsoft Alias: bwren

@knuthalvor Thanks for your comment. We are actively investigating and will get back to you shortly.

#label:"CreateAzMonWIFeb2021"

Sorry, this one got lost in our backlog. We actually have some significant changes coming to the saved queries and function content coming in the next few weeks that will cover the scope of the queries and where they're stored in detail.
#please-close


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210718093620574 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210718093620574 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.566%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
26721

Relevant Lines:
56896

💛  - Coveralls


Fix missing litestar pytest marker

Description
This PR fixes thes following pytest warning: PytestUnknownMarkWarning: Unknown pytest.mark.litestar - is this a typo?  You can register custom marks to avoid this warning
Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[x] Enhancement/optimization
[ ] Documentation

Summary by Sourcery
Enhancements:

Add 'litestar' to the list of registered pytest markers in pyproject.toml to prevent PytestUnknownMarkWarning.

Hi, thanks for contributing to Strawberry 🍓!
We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!
So as soon as this PR is merged, a release will be made 🚀.
Here's an example of RELEASE.md:
Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)
Here's the tweet text:
🆕 Release (next) is out! Thanks to @NucleonJohn for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)


Error when running scweet

Hi,
I have an error with selenium driver when I run the app. Any idea ? Thank's a lot for your help

pip3 install -r requirements.txt
pip3 install selenium
Requirement already satisfied: selenium in /usr/local/lib/python3.7/dist-packages (3.141.0)
Requirement already satisfied: urllib3 in /usr/lib/python3/dist-packages (from selenium) (1.24.1)

python scweet.py --words "excellente//car" --to_account "tesla"  --max_date 2020-01-05 --start_date 2020-01-01 --limit 10 --interval 1 --navig chrome --display_type Latest --lang="en" --headless True
Traceback (most recent call last):
File "scweet.py", line 5, in
from selenium.webdriver.common.keys import Keys
ImportError: No module named selenium.webdriver.common.keys

@ElGringo275 In fact, this module is not needed anyway. Youcan delet the line from selenium.webdriver.common.keys import Keys. I will push the changes right away.


chore: Creating Versioning for Docusaurus Files

SUMMARY

Superset recently switched to docusaurus, which allows for versioned documentation. This creates the superstructure for that shift.
In order to create this new structure, I used the documentation here: https://docusaurus.io/docs/versioning
The new file structure is:

Where versioned_docs will house the docs for 1.4.0 (and subsequent revisions). The new file versions.json is an array with all the possible versions in it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@villebro this is current master, which I thought was on 1.4 and had docusaurus implemented because the structure was very similar. I can close this and create versioned 1.4.0 docs and push it to the 1.4 branch.


Fail to create Scenario:  KeyError: 'Date'

Summary
Can't create a Scenario when setting Country = 'China', Province = 'Hong Kong'
Codes and outputs:
import covsirphy as cs
# Dataset preparation
data_loader = cs.DataLoader("input")
jhu_data = data_loader.jhu()
population_data = data_loader.population()
scenario = cs.Scenario(jhu_data, population_data, country="China", province='Hong Kong')

The code returns
KeyError                                  Traceback (most recent call last)
<ipython-input-23-b7feafc92a73> in <module>()
----> 1 scenario = cs.Scenario(jhu_data, population_data, country="China", province='Hong Kong')

7 frames
/usr/local/lib/python3.6/dist-packages/covsirphy/analysis/scenario.py in __init__(self, jhu_data, population_data, country, province)
     40         population_data = self.validate_instance(
     41             population_data, PopulationData, name="population_data")
---> 42         self.population = population_data.value(country, province=province)
     43         # Records
     44         self.jhu_data = self.validate_instance(

/usr/local/lib/python3.6/dist-packages/covsirphy/cleaning/population.py in value(self, country, province)
    144             (int): population in the place
    145         """
--> 146         cell = self.subset(country=country, province=province)
    147         return int(cell.values)
    148

/usr/local/lib/python3.6/dist-packages/covsirphy/cleaning/cbase.py in subset(self, country, province, start_date, end_date)
    257         if country is None:
    258             ValueError("@country must be specified.")
--> 259         df = self._subset_by_area(country=country, province=province)
    260         # Subset with Start/end date
    261         if start_date is None and end_date is None:

/usr/local/lib/python3.6/dist-packages/covsirphy/cleaning/cbase.py in _subset_by_area(self, country, province)
    230             raise ValueError(
    231                 "@province was specified, but the dataset does not have Province column.")
--> 232         return self._subset_by_province(df, province=province)
    233
    234     def subset(self, country, province=None, start_date=None, end_date=None):

/usr/local/lib/python3.6/dist-packages/covsirphy/cleaning/cbase.py in _subset_by_province(self, record_df, province)
    191                 raise KeyError(
    192                     f"@province {province} has not been registered.")
--> 193             df = df.groupby(self.DATE).last().reset_index()
    194             return df.drop(self.PROVINCE, axis=1)
    195         # Calculate total values at country level if not registered

/usr/local/lib/python3.6/dist-packages/pandas/core/frame.py in groupby(self, by, axis, level, as_index, sort, group_keys, squeeze, observed)
   5808             group_keys=group_keys,
   5809             squeeze=squeeze,
-> 5810             observed=observed,
   5811         )
   5812

/usr/local/lib/python3.6/dist-packages/pandas/core/groupby/groupby.py in __init__(self, obj, keys, axis, level, grouper, exclusions, selection, as_index, sort, group_keys, squeeze, observed, mutated)
    408                 sort=sort,
    409                 observed=observed,
--> 410                 mutated=self.mutated,
    411             )
    412

/usr/local/lib/python3.6/dist-packages/pandas/core/groupby/grouper.py in get_grouper(obj, key, axis, level, sort, observed, mutated, validate)
    598                 in_axis, name, level, gpr = False, None, gpr, None
    599             else:
--> 600                 raise KeyError(gpr)
    601         elif isinstance(gpr, Grouper) and gpr.key is not None:
    602             # Add key to exclusions

KeyError: 'Date'

I have tried using Country='China', Province='None', but getting another error
ValueError                                Traceback (most recent call last)
<ipython-input-24-b7f99c97e7c2> in <module>()
----> 1 scenario = cs.Scenario(jhu_data, population_data, country="China", province=None)

/usr/local/lib/python3.6/dist-packages/covsirphy/analysis/scenario.py in __init__(self, jhu_data, population_data, country, province)
     50         # First/last date of the area
     51         df = jhu_data.subset(country=country, province=self.province)
---> 52         self.first_date = df[self.DATE].min().strftime(self.DATE_FORMAT)
     53         self.last_date = df[self.DATE].max().strftime(self.DATE_FORMAT)
     54         # Init

pandas/_libs/tslibs/nattype.pyx in pandas._libs.tslibs.nattype._make_error_func.f()

ValueError: NaTType does not support strftime

Environment

CovsirPhy version: 2.5.4-beta.new.75.fix.130
Colab

Also not working with "Australia", should I open a new issue? Sorry, I'm still learning how to use GitHub. This is really a fascinating project, thanks for your efforts.

Dear @hchangac ,
Thank you for using this package and welcome to this project!
Because the root cause seems to be the same for China and Australlia, it is OK to discuss the errors in this issue.
Using the following codes, I found that jhu_data.subset("China") and population_data.subset("Australlia") returned empty dataframes. This may be the cause of these errors because Scenario.__init__ calls subset methods.
import covsirphy as cs
data_loader = cs.DataLoader("input")
jhu_data = data_loader.jhu()
population_data = data_loader.population()
# Comfirm that records of China are registered in jhu_data
"China" in jhu_data.countires()
# But empty dataframe was returned for China
jhu_data.subset("China")
# Comfirm that records of Australlia are registered in jhu_data
"Australia" in jhu_data.countires()
# But empty dataframe was returned for Australlia
population_data.subset("Australlia")

I will do further investigation to fix this errors.

Dear @hchangac ,
I tried to fix this issue in development version "2.5.4-delta.new.75.126.fix.130.133" in GitHub.
Please kindly double check it.

records in China at country level
I found that the number of recovered cases were zeros in the raw data at country level. I changed the code to replace zeros with actual values. Greater values of [total values of provinces] and [registered values for the country] will be used.

records in Australia at country level
Population value was not registered for Australia at country level in the raw data. I changed the codes to calculate total population as the total value of provinces.

KeyError for population_data.value("China", province="Hong Long") was fixed. (In the previous version, subseted the population data with unregistered column = Date mistakenly.)

Thank you!

yes, it's working pretty well now, again, thanks for your efforts :)


DOC: scipy.linalg.eigh

The docs say:

lower bool, optional
Whether the pertinent array data is taken from the lower or upper triangle of a. (Default: lower)

but it is undocumented whether the same parameter lower is applied to b.

Thanks @keithbriggs That's a good catch. I'll add to #12442

Thanks!

From: Ilhan Polat<EMAIL_ADDRESS>Sent: 29 June 2020 14:46
To: scipy/scipy<EMAIL_ADDRESS>Cc: Briggs,KM,Keith,TUD2 R<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [scipy/scipy] DOC: scipy.linalg.eigh (#12445)
Thanks @keithbriggshttps://github.com/keithbriggs That's a good catch. I'll add to #12442https://github.com/scipy/scipy/pull/12442
—


bessemer node26/58 random reboots / GPU driver upgrade

Added the missing RSS / tag precursors. LGTM but I still think the missing initial capitals looks weird / is wrong.


Investigate high fuzzer overhead

Since commit 1408aab353b3a7f54b5a4e1b4471e054d615adcf, Fuzzilli computes and displays the "fuzzer overhead", i.e. the fraction of time that is not spent executing JavaScript code in the target engine. Normal values seem to be roughly between 5% and 15%. However, in long fuzzing sessions and seemingly especially in multithreaded mode (e.g. --jobs=32), this number can become quite significant (approaching 50%). This should be investigated.

I also get high overhead after a day or so when using --jobs. Is there anything I can do to help debug this?
Fuzzer Overhead:              76.39%

You'd probably need to use some kind of profiler (e.g. perf on Linux) to figure out where the CPU time is spent, and if there's a bug there that we can fix.
Alternatively, you can use network synchronization (and maybe a low --jobs number on each node), which seems to not suffer from the problem that much (--jobs is still marked as "experimental" due to this issue).

I did some initial investigation a couple weeks ago, using perf to trace a long running session.
The largest win was switching to vfork from fork in libreprl. I'm not 100% on my understanding of why this was happening, but the kernel seemed to be taking more and more time to fork as memory usage increased when jobs was high (64 in my case). This seemed to reduce the high overhead for long running sessions with high job counts.
Fuzzilli was also spending a significant amount of compute in the JavascriptLifter, in inlining and determining which variables should be let vs const. I'm not sure if removing these reduce the overall effectiveness of Fuzzilli, however.

Oh wow, great find! Yeah, using vfork does indeed seem to cause a considerable improvement in performance, and I guess it should be fine to use since the child process doesn't modify any global memory before calling execve (afaik, the only difference between the two on Linux is that page tables aren't modified/duplicated). My initial guess as to why this gives such a huge boost would be that the kernel has to take some lock related to page tables when performing a fork, which then probably causes many of the other fuzzing threads to block on it. Then once a fair number of JIT related samples are in the corpus, the number of timouts (e.g. due to infinite loops), and subsequently the number of child process restarts becomes large enough for this to be an issue. But I'm just guessing here.
I'll put together a PR to switch to vfork on Linux. I think we can keep using fork everywhere else though for now, since it's probably not too important and e.g. the macOS man page for vfork states
ERRORS
     The vfork() system call will fail for any of the reasons described in the fork man page.  In addition, it will fail if:

     [EINVAL]           A system call other than _exit() or execve() (or libc functions that make no system calls other than those) is called following calling a vfork() call.


Implemented ThreeStatus functionality in MetroToggle

I've implemented ThreeStatus functionality in your so useful MetroFramework
If you're interested, please, let me know i can send the code for your evaluation, maybe you can include it in this interface
Kind Regards

Hello Edheo,  would love to have the code for the ThreeStatus functionality. would it be possible for you to paste it here.
thanks/

Hi Archimedes24
Here you have the MetroToggle.cs
You will need to update also the MetroToggle.xml in the Localization folder
You can customize the text from the status label using the TextStatus property, where you can put the text for the 2 or 3 states separated by | char, see the example
this.metroToggle1.TextStatus = "Active|Not Active|NotDef";
I hope it is useful for you
MetroTogglexml.txt
MetroToggle.txt

Thanks. will let you know if i face any issues.
Date: Thu, 22 Sep 2016 04:24:41 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [thielj/MetroFramework] Implemented ThreeStatus functionality in MetroToggle (#74)
Hi Archimedes24
Here you have the MetroToggle.cs
You will need to update also the MetroToggle.xml in the Localization folder
You can customize the text from the status label using the TextStatus property, where you can put the text for the 2 or 3 states separated by | char, see the example
this.metroToggle1.TextStatus = "Active|Not Active|NotDef";
I hope it is useful for you
MetroTogglexml.txt
MetroToggle.txt
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


Nt 1110 pledge screen cta button ui improvements

📲 What
Moves the pledge CTAs (Pledge and Apple Pay) .
🤔 Why
So that users can clearly see and understand their payment options and where to tap to complete their pledge.
🛠 How
Created the PledgeScreenCTAContainerView and moved the buttons there.
👀 See

✅ Acceptance criteria

[ ] Navigate to the pledge screen, you should see the view overlay w/ the pledge CTAs

SwiftFormat found issues:

File
Rules

Kickstarter-iOS/Views/PledgeScreenCTAContainerView.swift
indent

  Generated by :no_entry_sign: Danger

SwiftFormat found issues:

File
Rules

Kickstarter-iOS/Views/PledgeViewCTAContainerView.swift
indent

  Generated by :no_entry_sign: Danger


remove strings as errors and align with with node-serialport errors

https://github.com/garrows/browser-serialport/blob/master/index.js#L190
need https://github.com/voodootikigod/node-serialport/issues/440

Until we get tests done, fixed the one string in https://github.com/garrows/browser-serialport/tree/returnerrors
Somewhat related, are we happy returning chrome.runtime.lastError. Is it actually an error object, or should we wrap it?
I tried some stuff in an extension but couldnt really verify..
typeof is object but both of these throw "TypeError: Expecting a function in instanceof check, but got Error"
console.log(chrome.runtime.lastError instanceof Error)
console.log(Error.prototype.isPrototypeOf(chrome.runtime.lastError)

Chrome errors should be actual error objects.  There was 1 more string that should have been an error.  Let me find it.

found and fixed in https://github.com/garrows/browser-serialport/commit/40bb717d5fe6fe7057e97c4baa82a4db52198191

error strings removed. updating title


Uploading binary file fails

If I try to upload a binary file it fails.  The target file is replaced with a file with 0 bytes.  How do I fix this?

Nevermind.  I think I figured out what I did wrong.  I was using ASYNC and did not allow a process to complete before proceeding.


Add support for Resque

I'm in the need of Prometheus metrics for Resque, so I thought I could give this a try.
Right now I'm using Resque.info only, but I wanna extend this to fetch metrics per queue, not just totals. I'll update this PR with those changes in the next few days.
Happy about any feedback for the existing solution - I basically just copied the Puma integration, don't know if that's a good standard.

Any idea when this would be released?

No worries, will push a new version out today, thanks for the reminder.


Unusual memory allocation while running "tf.assign"

System information

Have I written custom code: Yes
OS Platform and Distribution: Linux Ubuntu 16.04
TensorFlow installed from: binary
TensorFlow version: 1.4.0
Python version: 2.7
CUDA/cuDNN version: 8.0.61 / 6.0.21
GPU model and memory: Tesla K80

Describe the problem
In the minimal example below, I am observing an increase in RAM usage when calling assign_new_values. Strangely, the extend depends on the dataset size.
I see no obvious connection between the dataset and the variables that get assigned. Commenting out either the iterator or the sess.run(assign_op, ...) prevents additional memory allocation.
How is this possible?
Source code / logs
import numpy as np
import tensorflow as tf

DATASET_SIZE = 1000000

def create_dataset():
    image_paths = tf.constant(DATASET_SIZE * ['image.jpg'])
    labels = tf.constant(DATASET_SIZE * [0])
    dataset = tf.data.Dataset.from_tensor_slices((image_paths, labels))
    return dataset

def create_variables():
    for i in range(20):
       tf.get_variable('var_%d' % i, shape=[3, 3, 3, 32])

def create_assign_ops():
    for var in tf.global_variables():
        name = var.op.name
        placeholder = tf.placeholder(tf.float32, shape=var.shape, name=name + '/placeholder')
        tf.assign(var, placeholder, name=name + '/assign_op')

def assign_new_values(sess):
    for var in tf.global_variables():
        name = var.op.name
        assign_op = tf.get_default_graph().get_tensor_by_name(name + '/assign_op:0')
        sess.run(assign_op, feed_dict={name + '/placeholder:0': np.random.random(var.shape)})

if __name__ == '__main__':
    with tf.Graph().as_default():
        with tf.device('/cpu:0'):
            dataset = create_dataset()
            iterator = dataset.make_one_shot_iterator()

        create_variables()
        create_assign_ops()

        with tf.Session() as sess:
            sess.run(tf.global_variables_initializer())
            # Check RAM usage before
            assign_new_values(sess)
            # Check RAM usage after

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Bazel version
Exact command to reproduce

I updated the missing fields.

Nagging Assignee: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @mrry: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @mrry: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!