Nuget dependencies release -- Lost support for .NETStandard 2.0

The nuget.org release from 1.1.0 allows for .NETStandard 2.0 https://www.nuget.org/packages/JsonSettings.Library/1.1.0#dependencies-body-tab
1.2.0 restricts this to net8.0-windows7.0 https://www.nuget.org/packages/JsonSettings.Library/1.2.0#dependencies-body-tab
Request is reuploading to .NETStandard 2.0.

@BeachyHeadCode I don't have bandwidth for this. Feel free to rework the dependencies in the solution

fixed by @CZEMacLeod with #12

@BeachyHeadCode @CZEMacLeod I'm pleasantly surprised this package is in actual use! This is really out of the blue. It's been forever since I actively worked on this as you can tell. I recently had reason to dig into ASP.NET Core data protection features -- essentially a cross-platform version of DPAPI, apparently. I've also pivoted to System.Text.Json for all json needs


Question about q1_loss and q2_loss

Hi @ku2482
Just a question about these 2 losses, I understand that we want to maximize the policy objective so policy loss (which is the negative of the object) should approach negative infinity but why q1_loss and q2_loss approaches positive infinity as we train?
Is it because we soft-update target_critic but the online_critic seems to "move faster" so the online_critic is getting "further" away, hence, q1_loss and q2_loss keeps increasing?
Is it something expected? I tried SAC-discrete on Cart-Pole and another game and it seems to work fine, just that I don't understand how these two losses work
Thanks for your time reading :)

Hi @AlexTo
I have observed that behavior, too.
I assume that the cause is target entropy (0.98 * maximum) is too large and the policy would never reach it so that alpha is always getting larger.
It may weigh the entropy maximization much more than the Q maximization, although at least it works.
Maybe it's an interesting topic to find the best entropy optimization procedure (or just target entropy value) for SAC-Discrete.
Does it answer your question?
Thank you for your interesting question :)


Hover is conflicted with plugin of recent files,it will always jump as I move it to the top of recent files !

bug：Hover is conflicted with plugin of recent  files,it will always jump as I move it to the top of recent files !

This should be fixed in the latest release (0.7.2).


Fix for rdar://48526524 - wrong module file output when given by two -o's; cherry-pick to 5.1

Fixes rdar://48526524.
When no -c and there are >1 -o's each giving the module output file, the compiler would just use the first output file name for all primaries. This fixes that.

@swiftci please test and merge

@swift-ci please test and merge

Build failed
Swift Test OS X Platform
Git Sha - 4392586a182742df9365edb9e898d907961fce61

@swift-ci please smoke test os x platform

@swift-ci test and merge

@swift-ci please test and merge


Update the selected blog post.

Should be able to pull the available blog post data into the editor that the user can then edit and update.

Accidently closed this one when it should have been the 'delete' functionality


Investigate flaky nightly test - "Upgrade after emergency upgrade"

Nightly pipelines was fixed, but the it failed the next day.
Details below :
Nightly Test Run Status: Failure
Author: casperlabs-bors-ng[bot]
Drone Build: #9376
Commit Link: d9783da61e

Link to failed run: https://drone-auto-casper-network.casperlabs.io/casper-network/casper-node/9435/1/4

Another failed run: https://drone-auto-casper-network.casperlabs.io/casper-network/casper-node/9492/1/4

originally included in 1.5.4 but not a blocker thus moved to 1.6 and fix it. @alsrdn add comments and @rafal-ch talk to Ed

Added a PR that fixes the test. Description for the issue and the fix is also attached to the PR:
Root cause: In some runs this upgrade test was failing because it was hitting the 300 second timeout for syncing to genesis.
Sometimes when synchronizing historical blocks, the block synchronizer for node 1 was selecting 5 other nodes that did not have the finality signatures for that block (usually nodes 6-10).
Because the peer refresh interval was set to 90 seconds, the node did not have time to finish fetching the historical blocks if the situation described above happened for multiple blocks since the total timeout was 300 seconds.
Fix: Reduce the block_synchonizer.peer_refresh_interval config parameter for this test to 10s to allow it to become more lively and finish within the 300s timeout.


bgpv1: Use GoBGP's gRPC for better operational state visibility

Please see the commit for more details.
We should update cilium-runtime container image to contain gobgp CLI later.
Note: I think this interface is for debugging purposes. We should make another interface to see some operational states from a global perspective (e.g. exporting some states to CiliumBGPPeeringPolicy's state fields).
bgpv1: Listen to GoBGP's gRPC interface for better operational state visibility

Do we want to actually make this optional via the CRD tho? Will users want to "enable" and "disable" the creation of the unix socket on a per-router basis for sec reasons?

I couldn't come up with any risk for always enabling it in terms of security. Since we only use the UNIX domain socket inside the Cilium pod, to abuse the BGP, they need access to the Cilium Pod. That means it is always behind the authentication of Kubernetes or Node itself. If attackers can break that authentication, probably they can do more bad things.
Do you have any concerns about that?

Sounds reasonable to me.
The only other consideration is whether enabling the gRPC access takes up any more resources within the agent then having it off. Providing the option to disable it could be useful in that case.

@ldelossa Sorry for the late response.

The only other consideration is whether enabling the gRPC access takes up any more resources within the agent than having it off. Providing the option to disable it could be useful in that case.

Make sense. Then I'll propose to add a new hidden Cilium Agent option --enable-bgp-admin-interface=<bool>.
It turns on gobgp gRPC sockets for all virtual router instances when set to true and turns off all when set to false. All on or all off, because it is much simpler, won't introduce a new CRD field, and I don't come up with the situation users want to turn on per virtual router basis.
And it can be statically specified only when the agent comes up. The problem with dynamically enabling/disabling it is we need to recreate the GoBGP's BgpServer instance for doing it. When users want to check their BGP state, they need to disconnect the BGP session first.
It is turned on by default for a similar reason. Otherwise, when users want to troubleshoot their BGP, they need to disconnect the BGP session first.

One other thought @YutaroHayakawa - if the user uses the gobgp cli to write configuration to the instance, we'd get into a pretty whacky state. Right now, the BGP code assumes its the only thing adjusting the configuration. Is there any way to make this "read only" other then documenting that to would-be administrators?

I looked around gRPC library a bit. Unfortunately, I couldn't find a way to make API "read-only", so I think the better way here is to document it. And honestly, I think it's ok to allow admins to "write" something. Of course, we won't guarantee anything, and users should know what they are doing. However, in my opinion, since our BGP implementation is not perfect, this interface would be the last resort for users to work around the issue they met.

Make sense. Then I'll propose to add a new hidden Cilium Agent option --enable-bgp-admin-interface=<bool>.

@YutaroHayakawa do we want to add this flag in this PR?

I looked around gRPC library a bit. Unfortunately, I couldn't find a way to make API "read-only", so I think the better way here is to document it. And honestly, I think it's ok to allow admins to "write" something. Of course, we won't guarantee anything, and users should know what they are doing. However, in my opinion, since our BGP implementation is not perfect, this interface would be the last resort for users to work around the issue they met.

Yup, I can see that being a little trap door if for some reason user needs to work around a problem. :+1:

do we want to add this flag in this PR?

Yes, I want to include that in this PR. Any concern for that?

I fixed the code to divide the socket with ASN. But I see that the GoBGP fails to bind the socket with the address already in use  error even if I always delete the socket file before starting a new GoBGP server. It always happens in my current implementation in this branch.
I'm doubting that there's a race where two threads simultaneously create a new GoBGP server. I'll investigate the issue later, but takes time maybe. So, let me make this PR back to draft for the moment.


Code 'EUR' not found

bug report? yes
feature request? no
version: 2.2

Description
I have code:
$code = 'EUR';
$cnb = new \CnbApi\CnbApi(storage_path('app/cnb'));
$a = $cnb->findRateByCode($code);
print_r($a);
exit;
When I run it, it shows error: Code 'EUR' not found
Where can be problem?

When I tried to reproduce the code, everything worked.
When you run this code, does it work?
$code = 'EUR';
$cnb = new \CnbApi\CnbApi();
$a = $cnb->findRateByCode($code);
print_r($a);

The same problem. Don't affect the result.


usage info: set darker background color for specified filetypes / buftypes

I wanted to know if there is functionality in this plugin to set a darker background to specified filetypes / buftypes. This would allow much easier configuration for backgrounds of say the quick fix lists and non-supported plugins like fugitive.

j

Nightfox does not have a way to set the background color for a specific file/buffer type. This can be done though your config though with :help winhighlight.
There are two ways of implementing this.

In a your neovim's config directory using a after/ftplugin/<ft>.lua file (:help ftplugin)

-- after/ftplugin/gitcommit.lua
vim.cmd([[set winhighlight=Normal:NormalFloat]])

Create an autocmd

local filetypes = { "qf", "fugitiveblame", "vista", "vista_kind" }
local cmd = string.format(
  "autocmd FileType %s setlocal winhighlight=Normal:NormalFloat,SignColumn:NormalFloat",
  table.concat(filetypes, ",")
)
vim.cmd(cmd)

thanks, this works!!


[Grid] Prevent crash if spacing is set to zero in theme

[x] I have followed (at least) the PR section of the contributing guide.

Resolves #33771
Preview - https://deploy-preview-33777--material-ui.netlify.app/material-ui/customization/density/

Prevent Grid crash if spacing is set to zero in theme.
This also prevents the DensityTool demo which uses the Grid from crashing. Resolving #33771.

More details in https://github.com/mui/material-ui/issues/33771#issuecomment-1204751236.

Before: https://codesandbox.io/s/admiring-dirac-ctu7c1.
After:

@siriwatknp
Can you review this PR please ?

@siriwatknp @PunitSoniME I have added a test and updated the PR description explaining the issue in https://github.com/mui/material-ui/issues/33771#issuecomment-1204751236. Please take a look.

I am changing the PR title to Grid instead.

Thanks @ZeeshanTamboli
I was thinking to add suggested test case ( I owe you one 🙂 )
You helped me a lot in my recent PRs
Thanks @siriwatknp
I will take care of this next time 🙂

I'll get to this ASAP. Thanks
On Thu, Aug 4, 2022, 8:50 AM Punit Soni @.***> wrote:

Thanks @ZeeshanTamboli https://github.com/ZeeshanTamboli
I was thinking to add suggested test case ( I owe you one 🙂 )
You helped me a lot in my recent PRs
Thanks @siriwatknp https://github.com/siriwatknp
I will take care of this next time 🙂
—
Reply to this email directly, view it on GitHub
https://github.com/mui/material-ui/pull/33777#issuecomment-1205284401,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2KTIJYMS4RIQAOCABPDP3LVXPDATANCNFSM55N626NA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


define is not properly considering

Code
`include "defines.svh"

module top (
                                       clk,
                                       rst_n_sync,
                                       in,
                                       out
);

   input                                clk;
   input 			        rst_n_sync;
   input                                in;
   output reg                           out;

`ifdef ASYNC_RESET_N
   always@(posedge clk or negedge rst_n_sync)begin
`else
   always@(posedge clk)begin
`endif
     if(!rst_n_sync) begin
       out <= 1'b0;
     end else begin
`include "defines.svh"

module top (
                                       clk,
                                       rst_n_sync,
                                       in,
                                       out
);

   input                                clk;
   input 			        rst_n_sync;
   input                                in;
   output reg                           out;

`ifdef ASYNC_RESET_N
   always@(posedge clk or negedge rst_n_sync)begin
`else
   always@(posedge clk)begin
`endif
     if(!rst_n_sync) begin
       out <= 1'b0;
     end else begin
`include "defines.svh"

module top (
                                       clk,
                                       rst_n_sync,
                                       in,
                                       out
);

   input                                clk;
   input 			        rst_n_sync;
   input                                in;
   output reg                           out;

`ifdef ASYNC_RESET_N
   always@(posedge clk or negedge rst_n_sync)begin
`else
   always@(posedge clk)begin
`endif
     if(/*!rst_n*/!rst_n_sync) begin
       out <= 1'b0;
     end else begin
       out <= in;
     end
   end //always
endmodule

Command used
verible-verilog-format --inplace temp.v
**Error **
temp.v: temp.v:18:1-5: syntax error at token "`else"
temp.v:23:10-13: syntax error at token "else"
temp.v:25:6-8: syntax error at token "end"

Yes, handling of preprocessing is not stellar currently and this is  essentially #228 (there are other, similar issues like #241, #267). The problem you run into is that the formatter looks at the tokens as if they where in sequence without considering the branches, so sees two consecutive stars of always blocks and gets confused.
There is work in progress on this in PR #1898 - but since this project is driven by volunteers, it is moving at the pace at which there is free time.


Vicuna v1.3

Great work, thank you for sharing it!
I was waiting for the Vicuna v1.3 weights to get out (they were previously marked as coming soon in the readme) as it is my current model of choice (and perform significantly better than v1.1) but I see that this section has been removed from the readme.
Is there any plan to quantize that family of models?

We are currently running internal evaluations before we release the models, so it shouldn't take that long!


s4548663-GFNet-ADNI

Description
Dear 3710 team, this PR introduces and builds the GFNet model to classify brain MRI scans as either Alzheimer's Disease (AD) or Cognitive Normal (CN), using the ADNI dataset. Significant improvements have been made to ensure model accuracy, robustness, and memory efficiency.
Implementation

dataset.py: Load and preprocess the ADNI data within PyTorch custom data loader;
modules.py: Build a GFNet model structure;
train.py: Train a best model using the structure in modules.py by the data in the train set;
predict.py: Get the result of the test dataset by the trained model;
README.md: Including the description of the dataset and model structure, the final result with figures, future work if possible, and dependencies.

Testing

Run the train.py to get the trained model in ./models;
Run the predict.py to the accuracy result of the test set.

Notes:

Increased training time: This may lead to increased training time due to the use of a large number of data augmentation methods and small batch sizes.
Memory requirements: Although memory usage is controlled by reducing the batch size, the model still requires large GPU memory. If running on a low-profile device, you may need to adjust the batch size further.
Model complexity: Using multi-layer Transformer blocks and MLPS may make the model more complex, and the generalization ability on different datasets needs further validation.

Others
I submitted this homework late because I applied for an extension. I'm sorry for everyone's extra workload. Thank you for your comments. I will make sure to correct any problems in time.

<This is an initial inspection, no action is required at this point.>
File Organizing: Well-organized files.
Problem Solving:

The algorithm solves the problem appropriately.
Accuracy in testing dataset: 0.7485.

Model and functions:

It correctly uses PyTorch to construct the GFNet models and functions.
With data augmentation.
Training code cannot work as the model is initialized as input channel = 3 while the input image channel is 1, so an input shape error will be posted when the images are fed into the model.

Code design: Most of the functions are good other than the input channel error leading to code running failure.
Code comment and docstring:

Good code comments
Minmal function docstrings

Difficulty: Hard.
Additional Comments:

Reasonable commits
Good ReadMe design

Observational Feedback
Pull Request:
Correctly created the Pull request from Topic Recognition Branch .
The pull request includes a clear description about the file structure .
File Organizing: Well-organized files.
Commit Log:
Commit messages are  progressive for the Recognition Problem solved using 4 files .
Commits are regularly made, showing incremental development rather than bulk updates.
Documentation:
The README file could be made more readable with use of bullet points and organised code blocks .
Code comments are included.
Can add about Conclusion and future improvements in the ReadMe.

Marking

Good/OK/Fair Practice (Design/Commenting, TF/Torch Usage)
Good design and implementation.
Spacing and comments.
No Header blocks. -1
Recognition Problem
OK solution to problem. Accuracy in testing dataset: 0.7485.-1
Driver Script present.
File structure present.
Good Usage & Demo & Visualisation & Data usage.
Module present.
Commenting missing. Minimal doc strings-1
No Data leakage found.
Difficulty : Hard. GFNet (Hard Difficulty)
Commit Log
Good Meaningful commit messages.
Good Progressive commits.
Documentation
Readme :Good.
Model/technical explanation :Good.
Description and Comments :Good.
Markdown used and PDF submitted.
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch).
Feedback action required: Feedback marks possible +2 if the requested changes are made. Remove model checkpoint, cache files.-2
Request Description is good.
TOTAL-5

Marked as per the due date and changes after which aren't necessarily allowed to contribute to grade for fairness.
Subject to approval from Shakes

Approved extension +2

Cant merge because of conflicting changes to main repo files (model files). Please update for merge, doesn't affect grade.


Exposing some core Speasy methods to users

I'm thinking about exposing some Speasy core methods as user API since they might be handy for users.
We could expose and document as public API the following methods:

any_loc_open
list_files
make_utc_datetime
epoch_to_datetime64
load_variable
Maybe some cache decorators to allow users to cache custom functions

The main drawback to this is that we lose the ability to change the behavior or remove those functions.

@brenard-irap, @KatraB in case you have any opinion on this.
@jgieseler maybe you could have any use of such functions?

@brenard-irap, @KatraB in case you have any opinion on this. @jgieseler maybe you could have any use of such functions?

Well, i think it makes sense to expose those functions, many of them (list_files, datetime, ...) are not very risky or subject to change so why not. In the worst case, if some changes were needed, it could be considered to use functions overload to implement changes without breaking anything, no?

I'm not sure if it's worth the effort if you're not yourself benefiting from it (like loading them from here somewhere else). The functions are quite specific. I guess most users will write them themselves and/or won't find them from here...

@jgieseler that's the question, I mostly agree with you on epoch/utc functions but not so sure with the other ones.
At least we have students and physicists in our lab who might use those functions once they are able to find them.


DynamicsGraph.h missing #include <boost/format.hpp>

Trying to build GTDynamics, I got the following error:
In file included from /home/adam/GTDynamics/gtdynamics/dynamics/DynamicsGraph.cpp:34:
/home/adam/GTDynamics/gtdynamics/utils/JsonSaver.h: In static member function ‘static std::string gtdynamics::JsonSaver::GetNoiseModel(const shared_ptr&)’:
/home/adam/GTDynamics/gtdynamics/utils/JsonSaver.h:262:22: error: ‘format’ is not a member of ‘boost’; did you mean ‘boost::timer::format’?
  262 |         ss << boost::format("isotropic dim=%1% sigma=%2%") %
      |

Adding #include <boost/format.hpp> to DynamicsGraph.h seems to fix the issue.

Ah, yes - I have removed that include from Matrix.h in gtsam. Sorry!
Feel free to make a PR but that file should be in a cpp file where used if possible to avoid header bloat.

I went ahead and created #337 but now get in trouble building python wrapper. Confirm this works for you?

Can confirm #337 works. @dellaert can you try rebuilding the project from scratch?

Removing build and starting from scratch worked. Probably because my build folder was rather old.
I'll close this issue then.


🚧 formatting coding style for challnge contracts

stuff like variable naming and function style should be uniformed

solved in #8

reopening again because more challenges were added

We should consider running tools such as Amarna for this purpose.


Remove LinkedIn permission that are no longer in API

Remove LinkedIn permission that are no longer in API — https://developer.linkedin.com/support/developer-program-transition

Do you know which API, I should consider if I want to be able to search for job posts using some key words. I am working on a simple project where I want to fine tune the matching between a job post and a resume/profile.

@kthouz the public api i.e. the one that you don't have to be part of the Partner Program. My thoughts is that you'll need the full_profile permissions that are no longer in the public API.


Initialize AsyncLLMEngine bg loop correctly

Fixes wrong asyncio event loop being used when ran through uvicorn/FastAPI.
Fixes https://github.com/vllm-project/vllm/pull/880#issuecomment-1705015828
@zhuohan123

@Yard1 @zhuohan123 openai server cannot accept new request when abort request or request unexpectedly disconnected. pls check again.

@esmeetu I just checked the current master and it seems to be working fine - can you check again and tell me exactly what steps you took and requests you sent?

@Yard1
Related code:
def _raise_exception_on_finish(task: asyncio.Task) -> None:
try:
task.result()
except Exception as e:
raise RuntimeError("Task finished unexpectedly.") from e
raise RuntimeError("Task finished unexpectedly.")
When i abort request, it will raise RuntimeError("Task finished unexpectedly."). And background loop seems dead, cannot run new request task. I will reproduce later again.

@esmeetu Can you try with https://github.com/vllm-project/vllm/pull/957 ?

@Yard1 Same as before using latest main branch.
Correct the reproduce step:
SEND 100 requests simultaneously, then cancel all. Single request works right.
Error message:
Exception in callback _raise_exception_on_finish(<Task finishe...239e8d61324')>) at /home/dell/vllm/vllm/engine/async_llm_engine.py:49
handle: <Handle _raise_exception_on_finish(<Task finishe...239e8d61324')>) at /home/dell/vllm/vllm/engine/async_llm_engine.py:49>
Traceback (most recent call last):
File "/home/dell/vllm/vllm/engine/async_llm_engine.py", line 51, in _raise_exception_on_finish
task.result()
File "/home/dell/vllm/vllm/engine/async_llm_engine.py", line 214, in run_engine_loop
await self.engine_step()
File "/home/dell/vllm/vllm/engine/async_llm_engine.py", line 192, in engine_step
self.request_streams[request_id].put(request_output)
KeyError: 'cmpl-f1a1a40a81314a42b1305239e8d61324'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/dell/miniconda3/envs/ray/lib/python3.10/asyncio/events.py", line 80, in _run
self._context.run(self._callback, *self._args)
File "/home/dell/vllm/vllm/engine/async_llm_engine.py", line 53, in _raise_exception_on_finish
raise RuntimeError("Task finished unexpectedly.") from e
RuntimeError: Task finished unexpectedly.

Thank you, I will try to reproduce tomorrow

@esmeetu can you share what request (including sampling params) you were sending?

@Yard1 all requests like this(Humaneval benchmark),
Received request cmpl-4df9e168eeab4fa3b11f49cc7fe48b70: prompt: 'Below is an instruction that describes a task. Write a response that appropriately completes the request.\n\n\n### Instruction:\nCreate a Python script for this problem:\nfrom typing import List\n\n\ndef has_close_elements(numbers: List[float], threshold: float) -> bool:\n    """ Check if in given list of numbers, are any two numbers closer to each other than\n    given threshold.\n    >>> has_close_elements([1.0, 2.0, 3.0], 0.5)\n    False\n    >>> has_close_elements([1.0, 2.8, 3.0, 4.0, 5.0, 2.0], 0.3)\n    True\n    """\n\n\n### Response:', sampling params: SamplingParams(n=1, best_of=1, presence_penalty=0.0, frequency_penalty=0.0, temperature=0.0, top_p=1.0, top_k=-1, use_beam_search=False, length_penalty=1.0, early_stopping=False, stop=[], ignore_eos=False, max_tokens=2048, logprobs=None)
And i use multiprocessing lib to request api endpoint simultaneously.


Specify Custom file names at Spring Cloud Client

My Config Server has the following files:

application.properties
order-dev.properties
Everything works file with the order service with the db and message properties in the same file.

Now I wish to split the .properties file as follows:
orderdb-dev.properties and order-dev.properties.
How can I specify the order client to pick properties from order-dev and orderdb-dev only ? There are other clients too which I want to configure in similar fashion.
Can it be done ?
Versions:
Spring Boot: 2.1.5.Release
Spring Cloud Version: Greenwich.SR1

orderdb and order represent application names, maybe a better approach would be to use order-db-dev and order-dev so db is just another profile you enable.

@ryanjbaxter . Thanks will check it out.


fix(deps): update terraform-module

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/terraform-ibm-cbr
module
minor
v1.15.1 -> v1.16.0

terraform-ibm-modules/cbr/ibm (source)
module
minor
1.15.1 -> 1.16.0

terraform-ibm-modules/key-protect-all-inclusive/ibm (source)
module
patch
4.4.1 -> 4.4.2

terraform-ibm-modules/resource-group/ibm (source)
module
patch
1.1.0 -> 1.1.4

Release Notes

terraform-ibm-modules/terraform-ibm-cbr (github.com/terraform-ibm-modules/terraform-ibm-cbr)
v1.16.0
Compare Source
Features

The KMS CBR context are now set to target HPCS in the fscloud module by default, starting with version 1.16.0, instead of Key Protect.

Important Changes:

This update replaces the previous default Key Protect rule with HPCS. As a result, when you upgrade to v1.16.0, the context will no longer be the set for the key protect CBR rule.
To maintain the behavior from previous versions when upgrading to v1.16.0, you should set the new variable kms_service_targeted_by_prewired_rules variable to include 'key-protect.' This ensures that the 'key-protect' CBR context continues to be set. For detailed instructions on configuring this variable, please refer to the fscloud module's variables.tf file.

terraform-ibm-modules/terraform-ibm-key-protect-all-inclusive (terraform-ibm-modules/key-protect-all-inclusive/ibm)
v4.4.2
Compare Source
Bug Fixes

deps: update terraform-module (#371) (e1489e9)

terraform-ibm-modules/terraform-ibm-resource-group (terraform-ibm-modules/resource-group/ibm)
v1.1.4
Compare Source
Bug Fixes

fix variable name in catalog validation json template (#535) (6cadceb)

v1.1.3
Compare Source
Bug Fixes

fix typo in catalog validation json template (#534) (c4eb24f)

v1.1.2
Compare Source
Bug Fixes

cleanup for catalog onboarding (#533) (ec38fcc)

v1.1.1
Compare Source
Bug Fixes

create ibm catalog manifest which will be used for onboarding to the IBM catalog module registry (#528) (87bd79c)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.7.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


hide issue

If I specify the hide property in the field then the expression will not be able to override this afterwards.
Example:
{
        key: 'text2',
        type: 'input',
        hide: true,
        templateOptions: {
          label: 'Hey!',
          placeholder: 'This one is disabled if there is no text in the other input'
        },
        expressionProperties: {
          hide: '!model.text',
          'templateOptions.disabled': '!model.text'
        }
      }

I have hide: true and then an expression property that sets hide if the model has text. But the field will not appear.
You can check it out here: http://jsbin.com/yumasegefi/1/edit?html,css,js,output
if you remove the hide: true from the example then when you put data on the input box the second one will show up.
The reason I need to do something like this is that I have a huge multistep form that is slow to initialize on steps that have many fields, and in one part I have 3 possible headings and only one will remain. The current behaviour is that the 3 headings appear and then 2 of them disappear. I would rather have them all hidden by default and show only one when angular and angular formly finish doing their thing.
Thanks! Great library! it is saving me a lot of work and it has an amazing API. Were it not for angular performance issues this would be perfect.

I'll answer better later when I get a second, but the problem is with the
ng-if that formly uses on the fields. Look at changing that to ng-show
using the hide-directive attribute.

Kent C. Dodds

(Sent from my mobile device, please forgive typos or brevity)
On May 4, 2015 7:47 AM, "Pedro Catré"<EMAIL_ADDRESS>wrote:

If I specify the hide property in the field then the expression will not
be able to override this afterwards.
Example:
{
key: 'text2',
type: 'input',
hide: true,
templateOptions: {
label: 'Hey!',
placeholder: 'This one is disabled if there is no text in the other input'
},
expressionProperties: {
hide: '!model.text',
'templateOptions.disabled': '!model.text'
}
}
I have hide: true and then an expression property that sets hide if the
model has text. But the field will not appear.
You can check it out here:
http://jsbin.com/yumasegefi/1/edit?html,css,js,output
if you remove the hide: true from the example then when you put data on
the input box the second one will show up.
The reason I need to do something like this is that I have a huge
multistep form that is slow to initialize on steps that have many fields,
and in one part I have 3 possible headings and only one will remain. The
current behaviour is that the 3 headings appear and then 2 of them
disappear. I would rather have them all hidden by default and show only one
when angular and angular formly finish doing their thing.
Thanks! Great library! it is saving me a lot of work and it has an amazing
API. Were it not for angular performance issues this would be perfect.
—
Reply to this email directly or view it on GitHub
https://github.com/formly-js/angular-formly/issues/271.

Can't :( I really need to use ng-if because there are many dependencies and many fields hidden in the same step of the form. If I use ng-show all their binding will be active if though they are not being displayed.
I already have some performance issues (specially with older browsers and weaker machines) so I really can't afford to use ng-show.

That's fine. Switch from expression properties to watcher.

Kent C. Dodds

(Sent from my mobile device, please forgive typos or brevity)
On May 4, 2015 8:04 AM, "Pedro Catré"<EMAIL_ADDRESS>wrote:

Can't :( I really need to use ng-if because there are many dependencies
and many fields hidden in the same step of the form. If I use ng-show all
their binding will be active if though they are not being displayed.
I already have some performance issues (specially with older browsers and
weaker machines) so I really can't afford to use ng-show.
—
Reply to this email directly or view it on GitHub
https://github.com/formly-js/angular-formly/issues/271#issuecomment-98717998
.

Note, obviously, you've got some serious performance considerations, so you may need to take things at a bit of a different approach. If you have a bunch of fields with their own hide conditions, instead of paying for a watcher for each of those, create your own watcher and respond to model changes yourself (by setting hide on the appropriate fields).
It's not as clean and neat, but that's the reality of the performance situation. :-(

So I've now had time to actually read through your issue. For the headings, you might consider not using angular-formly and just coding that up yourself in the HTML. This would allow you to using ng-if without a problem.

These headers can appear in the middle of the form fields, that is one of the reasons I don't hardcode them. The second reason is that it is very appealing to have the entire form described in one JSON. Also because I intend to reuse as much as I can for future forms that are very different but have similar requirements, and I want to be able to build those forms very fast.
But is this hide thing a bug?
Also regarding what you said "Note, obviously, you've got some serious performance considerations, so you may need to take things at a bit of a different approach. If you have a bunch of fields with their own hide conditions, instead of paying for a watcher for each of those, create your own watcher and respond to model changes yourself (by setting hide on the appropriate fields)." You mean creating watchers outside of the JSON form configuration right?

@pedrocatre, yes, I do mean creating watchers outside of the JSON. This is because there's a watcher created for every time you have a watcher. And they all watch the same thing. It's just some extra overhead that may not be necessary.
The hide thing is not a bug. Basically, when the field is hidden behind the ng-if, it never compiles which means the expressionProperties never get set up and cannot run.
I may be able to add a hideExpression attribute which could make life a little bit easier for you. It would not be a normal formlyExpression though. It could be a function or a string, but it would be evaluated on the formly-form not the formly-field so you wouldn't have access to the same stuff... But it should be enough for what you want (it'll have the model for example).

hideExpression attribute would be nice thanks! I'm still going to think how I could do this with the existing mechanisms. One thing that comes to mind would be to have only one header instead of 3 and just change its text. It is less easy to configure and see, but it would probably work and I would have less watchers.
Regarding what you said about the watcher instead of expressionProperties it would not help in my case because I'm not using the expressionProperties per field. For the step that can have more than 100 fields I put them inside groups and I only have the expressionProperties per group of fields (8 groups in total each group has many fields inside) not in every field. It is strange that I have performance issues and so many watchers (I used your awesome ng-stats lib to see this!) because I one time bind most things inside the fields. Also I ng-if the groups until they are necessary. Still on that step in the best case scenario I have 513 watchers (before the user starts interacting with the form and causing more fields to show up). Worst case I have more than 3000 watchers. I will have to find time to take a closer look.

In the latest beta, I added a hideExpression property. Give that a shot.

Kent C. Dodds

(Sent from my mobile device, please forgive typos or brevity)
On May 5, 2015 10:38 AM, "Pedro Catré"<EMAIL_ADDRESS>wrote:

hideExpression attribute would be nice thanks! I'm still going to think
how I could do this with the existing mechanisms. One thing that comes to
mind would be to have only one header instead of 3 and just change its
text. It is less easy to configure and see, but it would probably work and
I would have less watchers.
Regarding what you said about the watcher instead of expressionProperties
it would not help in my case because I'm not using the expressionProperties
per field. For the step that can have more than 100 fields I put them
inside groups and I only have the expressionProperties per group of fields
(8 groups in total each group has many fields inside) not in every field.
It is strange that I have performance issues and so many watchers (I used
your awesome ng-stats lib to see this!) because I one time bind most things
inside the fields. Also I ng-if the groups until they are necessary. Still
on that step in the best case scenario I have 513 watchers (before the user
starts interacting with the form and causing more fields to show up). Worst
case I have more than 3000 watchers. I will have to find time to take a
closer look.
—
Reply to this email directly or view it on GitHub
https://github.com/formly-js/angular-formly/issues/271#issuecomment-99134665
.

@pedrocatre, have you tried hideExpression yet? Here's an example. I think this will do what you need. Only available in 6.4.0-beta.4 though... Please provide feedback :-)

ping @pedrocatre. I would really like to make sure that this solves your use case before I cut an official release. Let me know as soon as you are able please :-)

Yes, sorry it took my a while to answer. I only had the opportunity to test this today. It solves my use case :) thanks!

Supported in 6.4.0 :-)


Change all Moq entries to NSubstitute

Note to self: check UnsafeAccessor application for mocking protected class members.


Workflow to auto deploy contracts when changed

Sample output file: https://github.com/consensus-shipyard/ipc/commit/7d65801134fbf9369e20c342b835acb265f0f275
Saved in cd/contracts branch https://github.com/consensus-shipyard/ipc/commits/cd/contracts/
Closes ENG-627

Just a note that we discussed it in sync, and aligned that we need the addresses to be available somewhere.
We haven't 100% decided where exactly as @mb1896 had reservations about the branch suggested by @raulk .
@mb1896 feel free to propose alternatives. Let's aim to reach the decision today since it'd be valuable to have it next week when the hackathon starts.

For the record, the alternative that @mb1896 suggested was placing the addresses in a file in main. This was not seen as a good solution because bots pushing to main causes all sorts of problems. The parallel branch with merges from main is cleaner. And it's easy to change if we feel it doesn't work for us. So let's just go do it.

@mb1896 this is the GitHub Action you should use: https://github.com/stefanzweifel/git-auto-commit-action It does not require a Personal Access Token.

Just a note that we discussed it in sync, and aligned that we need the addresses to be available somewhere. We haven't 100% decided where exactly as @mb1896 had reservations about the branch suggested by @raulk . @mb1896 feel free to propose alternatives. Let's aim to reach the decision today since it'd be valuable to have it next week when the hackathon starts.

Thanks for the comments. I'm following @raulk 's direction now. Will sure to make this ready soon for external developers to check out.

@mb1896 just cross-posting from Slack:
I think it would help reviewers if:

the commits had descriptive names, not "test" ("test" is fine for local development but when you want someone to review, it's better to squash the commits and made them clearer)
there was a TODO included in the description to indicate what is left to code so reviewers know what to expect

@raulk Can you take another look?

@mb1896 When you're online, let's address Fridrik's comments, merge main and merge this PR. Raul's comments have been addressed so no need to block this PR on them. Thanks!

Btw this is great, I was already able to unblock a dev who encountered error because of contracts incompatibility by sending addresses from this commit to them..


A bug with compute_deltas

the output of compute_deltas  is a class of _kaldi_matrix.Matrix
AttributeError: '_kaldi_matrix.Matrix' object has no attribute 'numpy'.

Feel free to reopen this issue if you continue to have problems.

Note that to see the changes, you will have to build from source until conda packages are updated.
CC @vrmpx.


Code is not able to compile

I followed the instruction but when I ran this command bundle exec rake erd .It failed to complile

Sorry My mistake I forget to install module before running that command.


JSDoc

Is your feature request related to a problem? Please describe.
Code is not documented from within. RTD implementation is not automated.
Describe the solution you'd like
Add JSDoc comments to all JavaScript code.
Describe alternatives you've considered
Manual documentation.
Additional context
JSDoc, Sphinx, sphinx-js.

ESDoc.


Add DPG: Hive

Works towards unicef#555, may need some cleanup.
( created with https://github.com/ericherman/dpg-csv-to-json )

Hive initially submitted with several gaps in the DPG standard indicators which need to be addressed before we can proceed with the review:

[ ] Clear Ownership
[ ] Platform Independence
[ ] Adherence to Standards & Best Practices
[ ] Adherence to Privacy and Applicable Laws
[ ] Do No Harm
[ ] Protection from Harassment

I have contacted the person who made the submission and will update once they come through.

Digital solutions that are no longer active, or do not provide the required documentation needed for review, will be removed from the DPG Registry as per the archiving policy.


Foxy backport: windows port and sleep function

@norro
could you test, if this works on Windows (colcon build, colcon test) with Dashing and Foxy?

@norro
I compiled this PR on the Windows PC in the robotics lab with Foxy ROS 2 release.
the unit tests for rclc run successfully. The unit tests for rclc_lifecycle do not:
[ RUN    ] TestRclcLifecycle.lifecycle_node_transitions
unknown file: error: SEH exception with code 0xc0000005 thrown in the test body.
[ FAILED ] TestRclcLifecycle.lifecycle_node_transitions (30ms)
...

Could you run colcon-test or the binary (ros2_ws\build\rclc_lifecycle\Release>call rclc_lifecycle_test.exe) on your local Windows installation?

The backport-windows-port-and-sleep-func branch builds and tests without error in my local setup. I tried with colcon test and by executing rclc_lifecycle_test.exe explicitly.

The build farm CI job was never executed for Dashing. Theferefore I created a new PR https://github.com/ros2/rclc/pull/84

Stale PR, there seems to be a problem with CI build job on Dashing, I created a new PR https://github.com/ros2/rclc/pull/84


Add a Counter Aggregator

Counter Aggregator allows exporting a sum of multiple Prometheus counters to Stackdriver as a single CUMULATIVE metric.
This can be useful if you have so many counter metrics (or metrics with high label cardinality) in Prometheus that importing all of them to Stackdriver directly might be too expensive, however you would like to have a total cumulative counter that corresponds to the sum of those counters.

@knyar I have a higher level question. What is the motivation to do this, when Prometheus itself can do the same aggregation and many more? We want to keep the sidecar nimble and predictable, and I'm concerned that this feature and the new metrics are above the minimally required.

@knyar I have a higher level question. What is the motivation to do this, when Prometheus itself can do the same aggregation and many more?

I don't think there is a way for Prometheus to export a cumulative metric that corresponds to the sum of multiple counters if those counters can be reset independently.
Recording rules can only be used to export a sum of per-second rates (e.g. sum(rate(http_requests_total[2m]))), which can only be imported to Stackdriver as a gauge. Creating a recording rule with a sum of counters (sum(http_requests_total)) will produce incorrect data when some of those counters get reset.

Thanks for your comments, @jkohen.

It's not obvious how these two will interact. Can you think what it would take to merge the aggregator into the existing export path instead?

Sure, the main reason to use OpenCensus here is that it already implements everything one needs to export cumulative metrics to Stackdriver: tracks start time, creates Stackdriver protos, flushes data according to a predefined interval. As you've mentioned, the sidecar is already instrumented to export OpenCensus metrics, and the two paths don't really overlap or interact with one another.
After taking a quick look at the existing output path, I believe we will need to add the following additional functionality to Counter Aggregator to make it use QueueManager rather than OpenCensus for reporting aggregated counters to Stackdriver:

For each aggregated counter, we'll need to prepare a monitoring_pb.TimeSeries proto in a way similar to how seriesCache does it, and calculate its hash (later used to assign a QueueManager shard).
Instead of relying on reporting cycle implemented by OpenCensus, counter aggregator will need to implement regular flushing of accumulated counter values to QueueManager. This will likely require a separate goroutine with a timer for each counter.
Counter Aggregator will need to keep track of start times for each counter, fill values in the prepared monitoring_pb.TimeSeries protos, and push them to QueueManager.

Overall, I think seriesCache + QueueManager are well optimized for high-bandwidth proxying of samples from Prometheus WAL to Stackdriver, but are too low level for a simple task of exporting a small number of counters to Stackdriver, for which OpenCensus provides a simpler and more intuitive API. It seems like integrating counter aggregator with QueueManager will bring additional complexity without significant benefits, but I am happy to take a stab at doing it if it's something you feel strongly about.

@jkohen, @StevenYCChou, I've taken another look at this PR, and I believe I've resolved all comments that had a clear call for action.
This is currently blocked on your decision on whether it's ok for Counter Aggregator to use OpenCensus (which would be my preference, since it's simpler), or if you'd like me to integrate it with QueueManager.

Sorry for the delay. @StevenYCChou and I discussed your response offline, and I'm convinced to accept the new path you added. However, I still want to see some validation of performance and resource usage, because we are pulling in a large dependency with OpenCensus.
We have a benchmark here: https://github.com/Stackdriver/stackdriver-prometheus-sidecar/tree/master/bench
You'd have to trigger the codepaths you added. Let us know if you encounter issues, because we haven't used it in a while.

However, I still want to see some validation of performance and resource usage, because we are pulling in a large dependency with OpenCensus.
We have a benchmark here: https://github.com/Stackdriver/stackdriver-prometheus-sidecar/tree/master/bench
You'd have to trigger the codepaths you added. Let us know if you encounter issues, because we haven't used it in a while.

I've made a few changes necessary to run the benchmark with counter aggregator enabled and kept it running for 30 minutes.
I am not sure what data you'd like to see, but in this Drive folder (shared with you, but not public) you can find the output along with metric dumps for Prometheus server, old sidecar (before this PR) and the new sidecar.
Please let me know if you'd like me to add these changes to this PR as well.

Thanks for running the benchmark. It'd be interesting to look at resource usage for both sidecar versions, maybe other metrics like RPC rate, just for sanity. Can you share it? It should be in Stackdriver :)

Thanks for running the benchmark. It'd be interesting to look at resource usage for both sidecar versions, maybe other metrics like RPC rate, just for sanity. Can you share it? It should be in Stackdriver :)

I believe the benchmark is executed against a fake Stackdriver client in bench/main.go, so no data is written to Stackdriver. However, I've shared metric dumps from both old and new sidecar versions in my previous comment.
CPU and RAM usage is comparable.
In metrics/sidecar_old.2019-05-08T12_04_02:
go_memstats_alloc_bytes_total 2.90230536232e+11
process_cpu_seconds_total 4282.33

In metrics/sidecar.2019-05-08T12_04_01:
go_memstats_alloc_bytes_total 2.89940170256e+11
process_cpu_seconds_total 4301.3

RPC stats are in the same files, but there's too much data for me to attach it here.

Please let me know if you have any other comments, or if you would like me to squash the commits for this PR to be merged.
I am also curious whether you'd like my changes to the benchmark to be included in this PR or not.
Thanks!

Please let me know if you have any other comments, or if you would like me to squash the commits for this PR to be merged.

I or YCChou will squash before merge, don't worry.

I am also curious whether you'd like my changes to the benchmark to be included in this PR or not.

Let's look at these separately.

Thanks for running the benchmark. It'd be interesting to look at resource usage for both sidecar versions, maybe other metrics like RPC rate, just for sanity. Can you share it? It should be in Stackdriver :)

I believe the benchmark is executed against a fake Stackdriver client in bench/main.go, so no data is written to Stackdriver. However, I've shared metric dumps from both old and new sidecar versions in my previous comment.
CPU and RAM usage is comparable.
In metrics/sidecar_old.2019-05-08T12_04_02:
go_memstats_alloc_bytes_total 2.90230536232e+11
process_cpu_seconds_total 4282.33

In metrics/sidecar.2019-05-08T12_04_01:
go_memstats_alloc_bytes_total 2.89940170256e+11
process_cpu_seconds_total 4301.3

RPC stats are in the same files, but there's too much data for me to attach it here.

Looks good. I also spot checked another pair of files 15 minutes into the test and I see the same. Not as cool as a time series, but it does the job for now. Thank you!

@StevenYCChou can you confirm that this OK with you?

Yes, LGTM.


Hoveranimation, paths and placing method

Fields are now paths
When hovering over a field its text changes to its description.
Added crappy icon to website
New placing method

👍


--mode production overwrite results in error, mode in config works

Describe the bug
npm run build --mode production results in this:
Could not resolve entry module (production/index.html).
error during build:
Error: Could not resolve entry module (production/index.html).
    at error (/Users/oneWaveAdrian/Documents/Development/project/node_modules/rollup/dist/shared/rollup.js:7917:30)
    at ModuleLoader.loadEntryModule (/Users/oneWaveAdrian/Documents/Development/project/node_modules/rollup/dist/shared/rollup.js:19615:20)
    at async Promise.all (index 0)

It works fine on vite serve but somehow tries to find the index once using vite build
In the end I will need the mode function in order to load different .env files on prod build. e.g. I would use npm run build --mode subprojecta in order for vite to build the project loading environment file .env.subprojecta, --mode subprojectb to load .env.subprojectb and so forth as described in https://vitejs.dev/guide/env-and-mode.html#modes
When I set mode: 'projecta' within the vite.config.js it works as it should so the problem only appears when trying to bypass mode as defined in the docs.
Since I need to set the project dynamically on build within the pipeline I do need the bypass mode to work, what can I do differently? For now I see this as a bug
Reproduction

create project
create .env.staging
create .env.production
run npm run build --mode staging
error will be reported

Optional steps to prove the process should work in general:
6. add mode: staging to vite.config.js
7. See it work as it should
System Info
System:
    OS: macOS 12.0.1
    CPU: (6) x64 Intel(R) Core(TM) i5-8500B CPU @ 3.00GHz
    Memory: 2.45 GB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 17.0.1 - /usr/local/bin/node
    Yarn: 1.22.17 - /usr/local/bin/yarn
    npm: 8.1.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 95.0.4638.69
    Edge: 95.0.1020.53
    Firefox: 94.0.1
    Safari: 15.1
  npmPackages:
    @vitejs/plugin-vue: ^1.2.2 => 1.2.3
    vite: ^2.2.3 => 2.3.7

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Fixed by not using the  npm build command but creating a separate npm projecta command which points to vite build --mode projecta. It seems as if npm build does not transfer the parameter in a way vite can understand.


Custom resources should never be added to the Kubernetes "all" alias.

What steps did you take:
Operate against a Kubernetes cluster using a service account/user which has restrictive RBAC.
Run:
kubectl get all

What happened:
You get errors of:
Error from server (Forbidden): apps.kappctrl.k14s.io is forbidden: User "system:serviceaccount:lab-k8s-fundamentals-w01:lab-k8s-fundamentals-w01-s001" cannot list resource "apps" in API group "kappctrl.k14s.io" in the namespace "lab-k8s-fundamentals-w01-s001"
Error from server (Forbidden): packagerepositories.packaging.carvel.dev is forbidden: User "system:serviceaccount:lab-k8s-fundamentals-w01:lab-k8s-fundamentals-w01-s001" cannot list resource "packagerepositories" in API group "packaging.carvel.dev" in the namespace "lab-k8s-fundamentals-w01-s001"
Error from server (Forbidden): packageinstalls.packaging.carvel.dev is forbidden: User "system:serviceaccount:lab-k8s-fundamentals-w01:lab-k8s-fundamentals-w01-s001" cannot list resource "packageinstalls" in API group "packaging.carvel.dev" in the namespace "lab-k8s-fundamentals-w01-s001"

What did you expect:
It is generally regarded as bad practice to add additional Kubernetes resources to the all alias. The all alias is more or less reserved for Kubernetes core resources only and custom resources should never be added to the all alias. As a result, kapp-controller package should not be adding its custom resources to the all alias. By doing so you get errors like the above, which can in some cases throw out scripted automation and in general create excessive noise in the output of kubectl which can annoy users greatly.
Anything else you would like to add:
It can't be over emphasised that adding extra resources to the all alias is very bad practice. Other Tanzu/VMware products have done this in the past but they have since removed them because of it being bad practice.
Environment:
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.4", GitCommit:"e6c093d87ea4cbb530a7b2ae91e54c0842d8308a", GitTreeState:"clean", BuildDate:"2022-02-16T12:38:05Z", GoVersion:"go1.17.7", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.4", GitCommit:"e6c093d87ea4cbb530a7b2ae91e54c0842d8308a", GitTreeState:"clean", BuildDate:"2022-03-06T21:32:53Z", GoVersion:"go1.17.7", Compiler:"gc", Platform:"linux/amd64"}

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.
cc @jorgemoralespou

Thanks for that background @GrahamDumpleton ! This seems like a potential breaking change for anyone relying on that behaviour today.
@cppforlife any background on why this was added? If there's no compelling reason to have this information shown in kubectl all then this story is available for pickup and probably a small change.

was added in this https://github.com/vmware-tanzu/carvel-kapp-controller/pull/483. i dont have strong preference either way.

@GrahamDumpleton I added this, I'm sorry if it is causing you trouble. I don't think it's necessarily common knowledge or widely accepted that custom resources should never be added to the "all" category, here are two examples:
https://github.com/knative/serving/blob/e73e83bcfd7acba1c16193963a49649f7445a6ab/config/core/300-resources/service.yaml#L34
https://github.com/rabbitmq/cluster-operator/blob/3d1c94e1ceedeabc44f1ac1fd1c92d86303263f7/config/crd/bases/rabbitmq.com_rabbitmqclusters.yaml#L20
That said I think I understand how this could cause users problems, it's kind of unfortunate that categories work this way.

Did knative people add it back again!
Pretty sure I had this discussion with them a few years ago and they saw the wisdom in removing their CRDs from all. Seems people never learn this is a bad idea. :-(
The underlying problem is people assume that everyone works as cluster admin against the cluster when that isn't the case. They therefore think doing this is a convenience for everyone when it isn't.

What is annoying is that kubectl has an option:
--ignore-not-found=false: If the requested object does not exist the command will return exit code 0.

to not complain when a resource doesn't exist, but no option for don't yell and complain when RBAC prevents access to the resources which are named directly or via an alias. If it had such an option and one could also somehow set an environment variable so was applied all the time, one could suppress these noisy messages.


Other providers besides primary care perform TBI screening.

https://github.com/OSEHRA/vha-kbs-knarts/blob/bca27b99695f1182ee0f2c615ec60ba1b96f402e/content/neurology_tbi_screening/b41/CDSK_KRprt_CRDT_B41TBI.xml#L37
For Future Implementation:  Other specialties such as mental health and/or specialty clinics (Neurology/PM&R) may also perform TBI screening, but before modifying the white paper accordingly those other specialties should be consulted.

@linophth I'm not following what the requested change is. Is there something you want changed?

No.  Future Implementation concern.
Linda Wedemeyer, MD, RN, MS
Physician Informatician, Clinical Decision Support
Knowledge Based Systems
Office of Informatics & Analytics
Mobile<PHONE_NUMBER>
Los Angeles, CA
From: Preston Lee<EMAIL_ADDRESS>Sent: Tuesday, October 30, 2018 8:35 PM
To: OSEHRA/vha-kbs-knarts<EMAIL_ADDRESS>Cc: Wedemeyer, Linda<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [OSEHRA/vha-kbs-knarts] Other providers besides primary care perform TBI screening. (#453)
@linophthhttps://github.com/linophth I'm not following what the requested change is. Is there something you want changed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/OSEHRA/vha-kbs-knarts/issues/453#issuecomment-434549689, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Akhg1SwTqEK8Xb_UZgVWcoCkj8DFrIKaks5uqRp-gaJpZM4YC-uN.

@Fcuello Re: TBI this is the only issue that came to mind, but it is a future thing.


Text visibility issue and UI fix

Question description text isn't visible properly and other UI fixes are required.
Assign this issue to me, so that I can fix it.

Yes you can start @Alok5102R

Can I proceed with this issue @Akash88585 ?

Sure you can proceed @SagarKumar2840

Thanks @SagarKumar2840


TC: Check storvsc multi channel spread

Following storvcs api will be tested:

handle_multichannel_storage
handle_sc_creation

The test will rely on using a VM with at least 8 cores, to check if the 4:1 CPU/channel mapping is accurate.

PR tested:
[azure] ARM Image Under Test  : canonical : ubuntuserver : 18.04-lts : latest
[azure] Total Test Cases      : 1 (1 Passed, 0 Failed, 0 Aborted, 0 Skipped)
[azure] Total Time (dd:hh:mm) : 0:0:13
[azure]
[azure]    ID TestArea             TestCaseName                                                                TestResult TestDuration(in minutes)
[azure] -------------------------------------------------------------------------------------------------------------------------------------------
[azure]     1 STORAGE              STORAGE-HOT-ADD-DISK-PARALLEL                                                     PASS                10.37
[azure]
[azure]

Closing PR, as the storvsc_channel spread is already tested in the LSVMBUS TC.


Update logic-apps-limits-and-config.md

Update IP on Multitenant Inbound/Outbound IP addresses sections with new ASE IP on follows regions:
Brazil South
Canada Central
East Asia
East US
France South
Japan East
Korea Central
Norway East
South Africa West
South India
Southeast Asia
Switzerland North
Switzerland West
West US

@ecfan
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Closing this PR because author needs to recreate in the internal doc repo.
#please-close

#please-close

#please-close


Kill big vararg in parser

In parser::Parser::build_reduce_table an array is allocated with .with_items that takes a vararg.
The vararg used is quite large (1116 elements) and this cause that the generated C code takes 30m to compile with clang-3.6 if -O2 is used; it is likely a regression in llvm since the same code takes appreciatively 1s with clang-3.5 (and with gcc).
Unfortunately, clang-3.6 is currently provided by Apple to MacOS X users.
The proposed solution is to allocate the array then use a sequence of add. The generated C code is more complex but clang-3.6 can compile it.
Close #1498 (once c_src is regenerated)

+1

How did you find that this was the bottleneck?

:shipit:

@xymus in a compile_dir, I run make and found that files where compiling correctly until nit__parser.sep.1.c was hit. Then I did various experimentation with compilers, versions and flags as explained in #1498. eg. make CC=clang-3.5 CFLAGS=-O2 nit__parser.sep.1.o
My first idea was then to detect the version of clang used and, if version 3.6 was found, use -O1 instead of -O2. Some magic Makefile-fu later I had a working poc commit, then I realized it was ugly: just find the issue and solve it instead of refusing the challenge.
So maybe the size of the C file was the issue, so I regenerated a fresh nit_compile but I used the option --max-c-lines of [[nitc|http://nitlanguage.org/tools/nitc/]] so that C files are smaller (but more C files generated, obviously).
The time issue was still present in a single one of the C files so I reduced the --max-c-lines until the generated C file contained only the compilation of the single Nit method parser::Parser::build_reduce_table. So I knew it was the culprit.
The whole function is just a big vararg so my first try was just to replace the vararg with something else.
One try, one hit.
Tl;DR: Hole-in-one on Par 5


When switching back to Chrome OS crouton crashes and cannot switch back

After switch into linux on my Dell Chromebook 11 using the command sudo startxfce4 everything works fine but when I use CTRL + Shift + ALT + Back to switch into Chrome OS it doesn't allow me to switch back
This is what happens from the point of running the command to switching back to Chrome
Entering /mnt/stateful_partition/crouton/chroots/precise...
/usr/bin/startxfce4: Starting X server
X.Org X Server 1.15.1
Release Date: 2014-04-13
X Protocol Version 11, Revision 0
Build Operating System: Linux 2.6.42-61-generic x86_64 Ubuntu
Current Operating System: Linux localhost 3.8.11 #1 SMP Fri Aug 29 00:54:53 PDT 2014 x86_64
Kernel command line: cros_secure console= loglevel=7 init=/sbin/init cros_secure oops=panic panic=-1 root=/dev/dm-0 rootwait ro dm_verity.error_behavior=3 dm_verity.max_bios=-1 dm_verity.dev_wait=1 dm="1 vroot none ro 1,0 2506752 verity payload=PARTUUID=abee3104-2e02-1a42-9a42-82869515e73e/PARTNROFF=1 hashtree=PARTUUID=abee3104-2e02-1a42-9a42-82869515e73e/PARTNROFF=1 hashstart=2506752 alg=sha1 root_hexdigest=2de3a02d3b93d14d001d4d63b01caeb6cbb54751 salt=a1c5902bd1afa4423d5fa894efe20752e6869c18924a971f776cf69be3c790ab" noinitrd vt.global_cursor_default=0 kern_guid=abee3104-2e02-1a42-9a42-82869515e73e add_efi_memmap boot=local noresume noswap i915.modeset=1 tpm_tis.force=1 tpm_tis.interrupts=0 nmi_watchdog=panic,lapic
Build Date: 07 August 2014  11:49:36AM
xorg-server 2:1.15.1-0ubuntu2~precise2 (For technical support please see http://www.ubuntu.com/support)
Current version of pixman: 0.30.2
Before reporting problems, check http://wiki.x.org
to make sure that you have the latest version.
Markers: (--) probed, (**) from config file, (==) default setting,
(++) from command line, (!!) notice, (II) informational,
(WW) warning, (EE) error, (NI) not implemented, (??) unknown.
(==) Log file: "/var/log/Xorg.2.log", Time: Wed Sep 17 15:41:01 2014
(==) Using system config directory "/usr/share/X11/xorg.conf.d"
setversion 1.4 failed: Permission denied
Initializing built-in extension Generic Event Extension
Initializing built-in extension SHAPE
Initializing built-in extension MIT-SHM
Initializing built-in extension XInputExtension
Initializing built-in extension XTEST
Initializing built-in extension BIG-REQUESTS
Initializing built-in extension SYNC
Initializing built-in extension XKEYBOARD
Initializing built-in extension XC-MISC
Initializing built-in extension SECURITY
Initializing built-in extension XINERAMA
Initializing built-in extension XFIXES
Initializing built-in extension RENDER
Initializing built-in extension RANDR
Initializing built-in extension COMPOSITE
Initializing built-in extension DAMAGE
Initializing built-in extension MIT-SCREEN-SAVER
Initializing built-in extension DOUBLE-BUFFER
Initializing built-in extension RECORD
Initializing built-in extension DPMS
Initializing built-in extension X-Resource
Initializing built-in extension XVideo
Initializing built-in extension XVideo-MotionCompensation
Initializing built-in extension XFree86-VidModeExtension
Initializing built-in extension XFree86-DGA
Initializing built-in extension XFree86-DRI
Initializing built-in extension DRI2
Loading extension GLX
setversion 1.4 failed: Permission denied
xfce4-session: No gpg or ssh authentication agent found
(polkit-gnome-authentication-agent-1:20794): GLib-CRITICAL **: g_variant_new_string: assertion `string != NULL' failed
(polkit-gnome-authentication-agent-1:20794): polkit-gnome-1-WARNING **: Failed to register client: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.gnome.SessionManager was not provided by any .service files
(xfce4-panel:20788): Gtk-WARNING **: Unable to locate theme engine in module_path: "pixmap",
(Thunar:20790): Gtk-WARNING **: Unable to locate theme engine in module_path: "pixmap",
(xfwm4:20784): Gtk-WARNING **: Unable to locate theme engine in module_path: "pixmap",
(xfce4-session:20774): Gtk-WARNING **: Unable to locate theme engine in module_path: "pixmap",
(xfdesktop:20792): GLib-GIO-CRITICAL **: g_file_get_path: assertion `G_IS_FILE (file)' failed
(xfdesktop:20792): GLib-GIO-CRITICAL **: g_file_get_path: assertion `G_IS_FILE (file)' failed
(xfdesktop:20792): GLib-GIO-CRITICAL **: g_file_get_path: assertion `G_IS_FILE (file)' failed
(xfdesktop:20792): GLib-GIO-CRITICAL **: g_file_get_path: assertion `G_IS_FILE (file)' failed
(wrapper:20828): Gtk-WARNING **: Unable to locate theme engine in module_path: "pixmap",
(wrapper:20830): Gtk-WARNING **: Unable to locate theme engine in module_path: "pixmap",
(xfsettingsd:20805): Gtk-WARNING **: Unable to locate theme engine in module_path: "pixmap",
(xfdesktop:20792): Gtk-WARNING **: Unable to locate theme engine in module_path: "pixmap",
(II) AIGLX: Suspending AIGLX clients for VT switch
I've updated to the most recent version and this still happens.
after running sudo enter-chroot -n precise croutonversion this is the output
Entering /mnt/stateful_partition/crouton/chroots/precise...
crouton: version 1-20140915182125~master:4f5c8f73
release: precise
architecture: amd64
targets: xfce
host: version 5978.80.0 (Official Build) stable-channel wolf
Not unmounting /mnt/stateful_partition/crouton/chroots/precise as another instance is using it.

I know this comment thread is a bit old, but I wanted to post to thank you for that, the ctrl alt forward (dev console) then ctrl alt refresh allowed me to get back to my linux!


xRemotefile download fails via proxy

The original reported issue is in the link below -
https://github.com/puppetlabs/puppetlabs-dsc/issues/160#issuecomment-163691226
In summary, the issue is -
The xRemoteFile DSC Resource is a wrapper around the Invoke-WebRequest cmdlet. Invoke-WebRequest does provide parameters to handle proxy details, however xRemoteFile does not expose parameters itself that uses them.
What is the environment configuration is required to make it work via proxy. We have tried with http_proxy and https_proxy environment variable set, ie proxy and winhttp proxy.

Hi @riponbanik  - This looks like it would be fairly easy to add proxy settings to the resource. I'll schedule some time to have a look at this this week/weekend.
Thanks!

That would be great. Thanks for looking it after.

I'm working on this at the moment. I have to bring the resource up to current standards and guidelines while I'm at it so it'll take a day or two more before it's ready. I'll let you know once it's complete.


do some work to simplify arm and arm64 building

working towards simplifying arm and arm64 image builds.

ok, arm32 works - publishing Docker 17.04.0, 17.03.1 and 17.05.1
next up arm64

and rancher/os-docker:1.10.3_arm64 pushed. (not tested yet though)


Syntax error in _convert_json_to_entity(entity, property_resolver)

Hi,
I have a problem about the function:
`def _convert_json_response_to_entities(response, property_resolver, require_encryption,
key_encryption_key, key_resolver):
''' Converts the response to tables class.
'''
if response is None or response.body is None:
return None
entities = _list()

entities.next_marker = _get_continuation_from_response_headers(response)

root = loads(response.body.decode('utf-8'))

if 'value' in root:
    for entity in root['value']:
        entity = _decrypt_and_deserialize_entity(entity, property_resolver, require_encryption,
                                       key_encryption_key, key_resolver)
        entities.append(entity)

else:
    entities.append(_convert_json_to_entity(entity,
                                         property_resolver))

return entities`

in azure-storage-python/azure/storage/table/_deserialization.py. The code
    else:         entities.append(_convert_json_to_entity(entity,                                               property_resolver))
try to convert a json to an entity, but I'm curious about where the entity comes from because my IDE reports an error here.  Thanks.

Hi likel,
Good point. entity doesn't appear to be populated in the else clause path, interestingly enough this hasn't really manifested as a bug suggesting that path is rarely taken.
I can resolve this in our next release, but most IDEs typically won't block you from running this.
Thanks!

@likel Thanks for bringing this to our attention. 😄 It has been fixed in the new release 0.35.0.


Make it possible to limit number of log lines returned

We should also propagate this parameter through proxies.

Looks like configserver proxies all parameters. Created internal PR to proxy the parameter in the controller.


Bump node version

I am installing a dependency that needs a newer version of node -
lets bump it.

That's a good point - I'll put together a follow up PR once this is in the main repo.


[core] Migrate to Django 1.8

Low priority, but should be easy.

Resolved by virtue of Meteor migration.

Or not?


Join TMVjs,  mlc-llm and WebLLM

I think that there are a lot of issues that comes from TVM and are incorrectly identified here. I.E.

#257
#144
#280

I suggest to do a multi repo with tvmjs web-llm and mlc-llm to be able to cover all the relatedissues

Indeed the majority of the issues in this repo are related to tvmjs and mlc-llm

there are pros and cons of mono repo, in this case, web-llm focused on a runtime layer of compiled wasm from MLC, so we are ghoing to do separate repos. This being said, we will continuously monitor the requests and update the code, since there are overlaps of developer communities

Would make sense to transfer issues or at least tag them?

it is ok to keep issues inplace since it would be likely the same group of people handling them, of course we can also cross link

lets close it for now


Incorrect Product photo and breadcrumbs for group product.

Current behavior
When switching to group product from the cart, the photo and breadcrumbs are not updated.

Expected behavior
The appropriate product photo should be displayed.
Steps to reproduce the issue

Add following group-product https://next.storefrontcloud.io/gear/gear-3/set-of-sprite-yoga-straps-2046.html
Add other product, eg https://next.storefrontcloud.io/women/tops-women/tees-women/tees-25/karissa-v-neck-tee-1529.html?childSku=WS10-M-Green
Open minicart
Press Sprite Yoga Strap 8 foot link

Repository

Can you handle fixing this bug by yourself?

[ ] YES
[ ] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[x] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser:
OS:
Node:
Code Version:

Additional information

TODO:
we need to do same approach as for configurable product https://github.com/DivanteLtd/vue-storefront/pull/4426

This problem occurs because when you click on product in cart, it is simple product with visibility === 1. To fix that we need to check if product has parent and visibility === 1 before we enter route. So best place to do that is mappingFallback
Steps:

check if product has visibility === 1
check config
make search for different parent in one query - this can be done in 1.12
disable adding route mapping for product that has visibility === 1

This can be done in 1.11, but we need to have ability to create one query for parent for different type of product. So this will be fixed in 1.12.
Here is solution for 1.11 of someone needs that https://github.com/DivanteLtd/vue-storefront/compare/hotfix/v1.11.4...gibkigonzo:bugfix/4284?expand=1


Support common styling properties via NotificationFlyout

As Flyout is just a DependencyObject it doesn't support any direct styling of the NotificationFlyoutPresenter.
To add

[ ] Border
[ ] BorderThickness
[ ] Background
[ ] CornerRadius
[ ] NotificationFlyoutPresenterStyle
[x] RequestedTheme (available in 1.0.0)

For this one we may just introduce NotificationFlyoutPresenterStyle allowing the user to define a style for the NotificationFlyoutPresenter where they'll have access to setters for the properties mentioned. This will align with the Flyout control API.

Added in https://github.com/TheXamlGuy/NotificationFlyout/commit/ee7530b8b58f2251a2164d8e32c903fa48f74005

Added in https://github.com/TheXamlGuy/NotificationFlyout/commit/ee7530b8b58f2251a2164d8e32c903fa48f74005


Remove ability to create AnalysisResult by passing source code and filename

Calling detekt from production code should only ever pass a KtFile or a Path (from which a KtFile can be created).
Creating KtFile from text directly is only required from tests.
This is a breaking change for detekt-intellij-plugin, but a quick look at the source in that project suggests it will be a simple update.
Waiting on merge of:

#7235
#7237
#7238
#7240
#7250
#7251
#7254

Warnings

:warning:
It looks like this PR contains functional changes without a corresponding test.

  Generated by :no_entry_sign: dangerJS against 38c3ae83653ae299bfd64dd5f969d1487c4fbac8


vCPU Limits are not per resource group

[vCPU Limits are not per resource group, they are per region or SKU and  are for a particular subscription

Thank you
]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36f49a06-90b1-cbe1-3853-2c38277b79f8
Version Independent ID: 02ff6f6c-3ef6-b48f-060d-b290419e0aba
Content: Azure subscription limits and quotas - Azure Resource Manager
Content Source: articles/azure-resource-manager/management/azure-subscription-service-limits.md
Service: azure-resource-manager
Sub-service: management
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@ondemandIT Thanks for your feedback. We will review the issue and get back to you shortly.

@tfitzmac Can you please provide your inputs on this ?

@ondemandIT - thanks for this feedback. I'll update the text.


Creating a Balancer API provider to fetch pool state for join txs;

Would be nice to add examples showing how this can be used, could add one for join and one for exit.

@lgahdl once the latest updates are pushed can you generate a changelog for the PR please.


Support for C++11 alias template

I want to discuss on the support for the alias template, which was added to C++11.
Currently, the type alias (using identifier = type_id) is supported using the ctypedef type_id identiffier syntax, thanks to the semantic similarity between the two (one source I can find is subsection 2.1, proposal n1489).  C++ attributes is not supported but it doesn't seem to have any meaning in Cython context anyway.
What is missing is an equivalent declaration for C++11's
template <template_parameter_list>
using identifier = type_id;

which I propose to be ctypedef type_id = identifier[template_parameter_list] for consistency with the current C++ class and function template which are currently supported by Cython at the moment.  For example, in <type_traits>,
template <class T>
using remove_reference_t = typename remove_reference<T>::type;

could be written in Cython as ctypedef remove_reference[T].type remove_reference_t[T].
I am unsure how this can be achieved.
This issue might be a part of #2130.
Edit: for extern declaration, would the following be sufficient?
cdef extern from '<type_traits>' namespace 'std' nogil:
    cdef cppclass remove_reference_t[T]:
        pass

This seems to be needed for more modern C++ code.  It seems that a new form of node that defers evaluation would be needed (as the exact value for this is unknown at the definition of the template class but known at its instantiation).  Rather then trying to replicate the entirety of C++ concepts and templates into cython, it would be better to have an "escape hatch" form of using that defines only that there is an identifier but not attempt to check it...
as an example, a cusing is a using iterator_type =  which results in a type but who's understanding is ignored and placed out for the C++ compiler to validate.  This allows for the use of complex types without having to fully specify their nature.
That said, restriction of a typename to a "interface" or series of expected behaviors (such as inheriting a class and having methods, or being a pointer) would probably be enough to make the type useful in cython context
    cdef cppclass reverse_iterator[Iter]:
        cusing iterator_type


[Docs] Adopt Versioning

What would you like to be added:
Adopting some form of versioning for documentation would enable us to review and merge docs for a feature before it is released. This may just be versioned branches, or selectively versioning sections of the website. Unfortunately different areas of our website could use different approaches to versioning:

Area
Goal

Implementations
Always Latest

Conformance Results/Tables
Likely want to wait one month after a release before displaying latest, also want to be able to show historical results

GEPs
Likely want to who latest status for ease of reference, but this could get confusing as GEP status on website may not match released status

Features + Guides
Should match release

API Spec
Should match release

Contributing
Always Latest

Some potential options:
1. Reuse release branches
With this approach, we'd pin the docs website to the latest release-1.x branch. Every fix, update, and GEP would need to be cherry picked to that branch. Future-looking updates would go straight to main.
2. Introduce new docs branches
As part of a release process, we'd create a docs branch reserved for future releases, and send unreleased updates directly to that. I don't think this would allow us to avoid unreleased updates to the API spec documentation though.
3. Introduce selective versioning for some subset of the website
Instead of using branches, we could duplicate sections of our website that would benefit from versioning, and continue to serve everything from main.
Why this is needed:
In https://github.com/kubernetes-sigs/gateway-api/pull/3108, we have a feature that has met all graduation criteria for standard channel in v1.2, but we don't really have a good place to put the corresponding docs updates before v1.2 is formally released. This is just one of many examples of a common pain point when documenting features in Gateway API.

I think that 1 is pretty unavoidable - although moving to Hugo instead of mkdocs would allow us to use the same tooling as upstream Kubernetes, which may make getting contributors easier. That's a big job though.

for displaying conformance results, is there consensus on wanting it to be 1 month post release, or the suggested wait till 3 implementations are submitted (comment)?

for displaying conformance results, is there consensus on wanting it to be 1 month post release, or the suggested wait till 3 implementations are submitted (comment)?

Maybe instead of "whichever comes first", we should say "whichever comes later", so we can ensure that implementations always have at least 1 month to implement the latest release of an API to be included in our conformance table.

Agreed, I like "one month after release, or whenever three implementations support it, whichever is longer" as the rule.

Prior art: docs.kuadrant.io uses mkdocs as well and it has versioned docs.
I think it's based on https://squidfunk.github.io/mkdocs-material/setup/setting-up-versioning IIRC.


Android Only plugin?

Is this supposed to work on iOS?
If I look at the lack of code in the iOS folder, can I safely assume no?

@sta55en now you can use it on iOS to please update package to v0.1.0


Android caches DB schema?

I do deleting and copying db file via Sqlite.deleteDatabase(filepath) and Sqlite.copyDatabase(filepath) on every app start.
Also on LiveSync, if my db file was changed, it Successfully transferred to device too.
But in fact old version of db are copied.
To get new version of db I need delete platform directory and run tns run android.
What could be the problem?

Unfortunately I have no control over the CLI; and how it transfers things.    Are you 100% sure that even during a livesync you aren't getting the new version of the db?    I know it used to work...

I thought this is not the CLI problem, because it logs in the console Successfully transferred for db file.
But now I've checked it one more time and looks like CLI don't transfers it in fact during livesync.

@NathanaelA please, read this

Ah, yeah -- I see what he is talking about.    var myInput = _getContext().getAssets().open("app/"+name); is pulling it out of the apk file; so no matter if it is updated or not; it is the original copy.    Guess we need to add some logic here to check the extracted directory for a more recent version...


Whether the expansion of datatable and tree structure expansion can add animation transitions

This function solves the problem (这个功能解决的问题)
Whether the expansion of datatable and tree structure expansion can add animation transitions
Expected API (期望的 API)
Whether the expansion of datatable and tree structure expansion can add animation transitions

We won't add animation to tree table in a short term, since the code would be too complex. The return on investment don't worth to do it.


Is isEqualToDiffableObject: necessary

IGListDiffable protocol requires isEqualToDiffableObject: and diffIdentifier.
But I think diffIdentifier is enough to do the diff.
Why do I think isEqualToDiffableObject: is not necessary?
Sometimes it's possible that the implementation of diffIdentifier and isEqualToDiffableObject: is not consistent.
The simplest way is just return "self " for diffIdentifier.
@interface ClassA ()<IGListDiffable>
@interface ClassB ()<IGListDiffable>
...
- (nonnull id<NSObject>)diffIdentifier {
   return self;
}

And both ClassA and ClassB could optionally implement their own -isEqual: and -hash, according to their needs.
As a result, [id<IGListDiffable>instance1.diffIdentifier isEqual:id<IGListDiffable>instance2.diffIdentifier] becomes [instance1 isEqual:instance2].

Good question! So we actually didn't use to have isEqualToDiffableObject: at all! We just used isEqual:.
The point of having the two methods has to do with identity and equality, where the diff identifier uniquely identifies data (common scenario is primary key in databases). Equality comes into play when comparing the values of two uniquely identical objects (driving reloading).

For even more history, we originally set out to just use hash and isEqual:, but after @ryanolsonk and I filled up too many whiteboards, we settled on having an object-based identifier.

I thought about this because of #503
I guess that crash lies in the inconsistence of the two methods.

@rnystrom - should we update the diffable guide with this discussion?
https://instagram.github.io/IGListKit/iglistdiffable-and-equality.html

@jessesquires ya lets

closing as resolved


Simplify the conflict layout.

Just a tiny little bit customize, make it simple and modest expression.

Great! Thanks :ok_woman:

LGTM!

Sorry just added unrelated commit, cuz this is my last pr!

Thanks!!

LGTM


"An App is needed to use this device" issue

Hello,
Thanks for developing and maintaining this plugin! It works great for most part however, we recently discovered an issue, mainly on newer Samsung Devices, where the device will be unable to connect to the Polar Devices and give an error saying "An app is needed to use this device". I have attached a screenshot below. Is there a way with the api to bypass this? Or force the device to connect to the polar device?

Apologies if this is irrelevant to the library. Thanks again for your work on this plugin!

This plugin is just a wrapper for the native SDKs.
If you have any questions about the API it's probably best to create an issue on the repo for them.
https://github.com/polarofficial/polar-ble-sdk


Worflows

Workflow for Yarn Test, Vue-Tsc compilers and more.

@keita-hino Hey sure

@Ayushsunny
I created a PR.
Could you please confirm this?
https://github.com/INVIII/CloudStyle/pull/21


Cannot use avg() aggregate function - distorted donut pie

Who is the bug affecting?
When using avg() aggregates
What is affected by this bug?
Visualization
When does this occur?
Always
Where on the platform does it happen?
On LWCC
How do we replicate the issue?
Ex. SOQL
SELECT AVG(Speeltijd__c) label, Speler__r.Name value FROM Beoordeling__c WHERE Wedstrijd__r.Datum__c = LAST_N_DAYS:180  AND Aanwezigheid__c  = 'Aanwezig' WITH SECURITY_ENFORCED GROUP BY Speler__r.Name LIMIT 10

Expected behavior (i.e. solution)
Ability to create donut chart based on avg() aggregates
Other Comments

Hi @JeroenSfdc and sorry for the late reply ! We've been disconnected during some time, but good news is that we're back !
I've done some tests from my side and the AVG() function seems to work. I think that your problem is in the SOQL query: it seems that you're trying to use the aggregated values as the label, and the chart values as the segments in the doughtnut chart. I don't think that should work, because the library doesn't know how to draw doughnut segments from string values.

SELECT AVG(Speeltijd__c) label, Speler__r.Name value FROM Beoordeling__c WHERE Wedstrijd__r.Datum__c = LAST_N_DAYS:180 AND Aanwezigheid__c = 'Aanwezig' WITH SECURITY_ENFORCED GROUP BY Speler__r.Name LIMIT 10

should be written as:

SELECT AVG(Speeltijd__c) value, Speler__r.Name label FROM Beoordeling__c WHERE Wedstrijd__r.Datum__c = LAST_N_DAYS:180 AND Aanwezigheid__c = 'Aanwezig' WITH SECURITY_ENFORCED GROUP BY Speler__r.Name LIMIT 10

Let me know if that helps, and thanks for using the library !


Support ARM64 platform in PyTorch examples

Currently, we support only the AMD64 platform in all PyTorch examples.
However, some users use ARM64 machines such as Macbooks. So, supporting the ARM64 platform allows users to try the training-operator examples on their machines easily.
Contributors should support the following examples by adding the platform parameters here: https://github.com/kubeflow/training-operator/blob/e31d11faa9f6ce5111b60c01079d39295589e0ef/.github/workflows/publish-example-images.yaml#L24

[ ] examples/pytorch/cpu-demo/Dockerfile
[ ] examples/pytorch/elastic/imagenet/Dockerfile
[ ] examples/pytorch/elastic/echo/Dockerfile
[ ] examples/pytorch/mnist/Dockerfile
[ ] examples/pytorch/mnist/Dockerfile-mpi
[ ] examples/pytorch/smoke-dist/Dockerfile

/good-first-issue

Hey! Interested in this project, could I be assigned to this issue?

Hey! Interested in this project, could I be assigned to this issue?

Sure, feel free to assign yourself with /assign comment.

/assign


Review existing logs to see what logs we can add

Our connector logs major events when reading and writing, such as when it is copying a table from the intermediary file store into Vertica or exporting from Vertica into the intermediary file store. We also log errors and caveats around usage of the connector and connector options. Along with errors, the connector logs warnings when the usage of the connector is not as expected. In addition, we log info such as SQL statements, schemas, and filters that are used when manipulating relations or the data in those relations. In order to get a lower level view of our connector operations, a user may change the log level to ‘Debug’. The debug log level will give more details around specific components, such as partition information, impersonation tokens, and cleanup information.

Removed logging_level option from other projects in repo.


Scaling info

Do you have any information regarding what size dataset this can handle? I'm curious before I try it out if it's likely to work with my large dataset

The larger dataset I used to test the code is the Kaggle criteo dataset, preprocessed with hashing + gbdt.
One million sparse features generated.
45 millions instances.
... using 5 executors with about 30Gb memory.
With 2,350,000 instances and 1M sparse features it takes about 5min/iteration with the python code and 2min/iteration with the scala code to train the model.

Thank you for sharing

Hi,
Thank you for sharing your project, it looks very interesting.
However, I have a question, I try to apply what you did on my case, and I would like to know if it works on features that are not categorical ?
Thank you for your help.


pull request for e2e test at 12/30/2016 22:26:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Improve docking efficiency

Fixes #584
@JenkeScheen
@apayne97  importantly changes the default to not do oeomega enumeration for each compound before docking in large scale workflow

Codecov Report

Merging #585 (4ecf6fb) into main (814f8a0) will decrease coverage by 25.00%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

:exclamation: Current head 4ecf6fb differs from pull request most recent head 45f594b. Consider uploading reports for the commit 45f594b to get more accurate results

Additional details and impacted files

just to be clear - this is basically just an update to the cli (with some minor naming changes)? we've had the capability to do this for a while, right?

Yep.


[Enhancement]:I will add a button to change theme using javascript

Do you want to have the enhancement of existing game ? 😀 Describe yourself..
Game enhancement
we often get bore by watching  the same background,there should be an option to change theme
Describe the solution you'd like
Solution steps
I will add a button using javascript to change background colors.
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @TusharChamlikar !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

/assign

Hey @TusharChamlikar ! , This issue is already assigned to @shaklan2001. 💗
You can work on other issues 🚀
If there is anything wrong you can contact us on Discord🕹👀

Hey @TusharChamlikar ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


[question] 0.7.6 release prediction

When the 0.7.6 version is planned to be released. More or less of course. :)

Hi!
We'll be jumping to 0.8.0 directly (there were a few breaking changes).
I still need to fix utils::lines::simple::LinesIterator to use the new algorithm, and we should be ready to publish. I'm a bit busy this week, so this may come around the weekend.

Alright, the simple LinesIterator now relies on the one from utils::lines::spans, which means TextArea not uses the correct line-splitting formula (and doesn't split before punctuation marks). So just a bit more testing, and 0.8.0 should follow shortly.

I'd be happy if this stuff https://github.com/gyscos/Cursive/pull/211 were also merged.
Of course I'll fix comments before :)

0.8.0 published today.


[EC-51] Create a domain model

This PR extracts a couple of domain models from networking layer of etc-client and moves them to .domain package. We need all types listed below in EVM or in MPT.
Changes:

An io.iohk.ethereum.domain package with following members:

Account
Address
BlockHeader
Transaction
SignedTransaction

All changes resulting from the above.
Fixed typos.

🚶 ➡ 🍕 ➡ ⌨ ➡ :review:

@rtkaczyk @AlanVerbner @LukasGasior1  the PR is ready for next round of reviews.

@whysoserious currently we have some "model" classes in network (Receipt, TransactionLog) and some in domain. How about moving them all to domain and leaving only Message classes in network? rlp enc/dec for these we can put in the package object (currently naming is not consistent, for example we have AccountImplicits and SignedTransactions objects to hold these implicits). This is just a suggestion

@LukasGasior1 That's a good idea. However, let's do that on a one-by-one basis. I would have to spend one more day refactoring it and I really want to avoid it.
Re. rlp enc/dec, this functionality deserves for another refactor. It's a mix of implicits conversions, explicit conversions, uses of discouraged package objects etc. However, let's keep it in a backburner as well.

LGTM

LGTM :+1:


Feature Request : API to pull scalar data

Tensorboard allows to curl down the data from specific plots (scalars particularly).
Not sure about the plotly blockers, but would be nice feature to gather data from 100s of envs.

Dumping the raw data in JSON format or something like that should be totally fine.

I can implement some GET requests on the server that will allow this. As visdom is now supporting callbacks from webclient events I can imagine there will be growing use cases for this kind of functionality.


fix: fix @angular/compiler entry

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (336aed8) compared to base (4757ca2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #230   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines          368       368
  Branches        88        88
=========================================
  Hits           368       368

Impacted Files
Coverage Δ

src/index.ts
100.00% <ø> (ø)

src/transform.ts
100.00% <ø> (ø)

src/transform-microsyntax.ts
100.00% <100.00%> (ø)

src/utils.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


How to update data in Join engine table?

When using Join engine with ANY, how to refresh data?
Do I have to drop the table, recreate and then insert data again?

It's not possible to update already inserted rows in Join table.
Yes, you can recreate a table.