Json Mapping

Not a specific issue but not sure how the Json mapping works? There is no documentation on how to use it, just how to enable it.
https://github.com/MapsterMapper/Mapster/wiki/Json.net
Can you advise?
Thanks.

just map, for example
poco.Adapt<JToken>() or jtoken.Adapt<Poco>()


Minified js file size too large? can be zipped from 1.3MB to 300KB

Shouldn't the minification of a js script reduce the file size by a lot?
Maybe the main point is uglification, but it's still strange that zipping the minified js reduces its size from 1.3MB to 312KB.
-> check minification settings

the size mostly comes from OSMD, and we (mostly @bneumann) are already working on reducing the bundle size there, see chore/sizeReduce.


aborting cleanly

First of all, thanks for releasing this to the community!
I've got the encoding working OK. I have 1 input thread submitting input samples by calling CFHD_EncodeAsyncSample(), and another output thread getting output samples by calling CFHD_WaitForSample(). Both of these functions (and therefore the threads) can block.
Perhaps I've missed something, but I can't find a way to cleanly abort if, for example, the user wants to prematurely cancel the encoding. At the moment of abort, either of the threads may be blocked. I've found that in a third thread I can call CFHD_ReleaseEncoderPool() - that unblocks both threads but with an exception, so this is obviously a dirty way of doing this that might leave the heap in a mess or a memory leak.
Is there a way of aborting cleanly, or just forcing CFHD_EncodeAsyncSample() and CFHD_WaitForSample() to unblock cleanly ?

Does CFHD_StopEncoderPool() not work? I my quick test it seems to do what you need. It should finish any work in progress, but no new frames with be started.

Thanks for the fast response.
CFHD_StopEncoderPool() just calls CEncoderPool::StopEncoders().
CFHD_ReleaseEncoderPool() destroys the encoder pool object whose destructor just calls StopEncoders()
In other words, StopEncoderPool gets called whether you call CFHD_StopEncoderPool() or CFHD_ReleaseEncoderPool().
For example, to simulate an extreme situation where the output thread might be busy doing something else, if I call CFHD_EncodeAsyncSample() repeatedly without any calls to CFHD_WaitForSample(), then the pool queue fills up and CFHD_EncodeAsyncSample() blocks. While it is blocked, from a third thread I call CFHD_StopEncoderPool()  and nothing happens - the input thread is still blocked inside CFHD_EncodeAsyncSample(). If the third thread then calls CFHD_ReleaseEncoderPool() which deletes the CEncoderPool object, then there is a divide by zero exception in the first thread inside CFHD_EncodeAsyncSample().
At the moment I am handling this by catching the exception, but it seems a bit messy.
I agree that it would be great if CFHD_StopEncoderPool() was actually guaranteed to unblock CFHD_EncodeAsyncSample() and CFHD_WaitForSample() which would return a CFHD error code to indicate that the call was aborted. Perhaps it will cause future calls to be rejected (I haven't checked that), but it seems that CFHD_StopEncoderPool() will not force unblock existing calls.

My understanding of safe abort (it seems to work ok in VirtualDub2):

stop trying to send new frames for compression
consume all compressed frames
release objects
Hope this helps

Any recommendations?
In the sample code this situation doesn't come up as it only queues frames for encoding if there is slots in the queue.
if(queuedFrames < POOL_QUEUE_LENGTH)
CFHD_EncodeAsyncSample(..), queuedFrames++;
if (queuedFrames)
if (CFHD_ERROR_OKAY == CFHD_TestForSample(..))
error = CFHD_GetEncodedSample(..), queuedFrames--;
This would never have the encoder pool block.

In my code it is similar to example (single thread).
I tried to repeat said extreme conditions and see what happens.
I cannot identify any blocking in CFHD_EncodeAsyncSample().
However I got a deadlock in CFHD_ReleaseEncoderPool().
There is semaphore in CEncoderMessageQueue and it can overflow with 1024 messages (semaphore max count). Then new messages do not signal it.

Consuming all compressed frames would be OK, but with separate in and out threads and a third thread wanting to do the abort, it is difficult to come up with a method which gives 100%  confidence that the in and out threads will unblock in all situations.
To reproduce the "extreme" case I mentioned, just repeatedly call CFHD_EncodeAsyncSample() and do NOT call CFHD_WaitForSample() nor CFHD_TestForSample(). The queue will then fill up. Assuming you have set a queue length of say 8, then it will block in the 9th call to CFHD_EncodeAsyncSample(). The stack trace of the block is:
EncoderJobQueue::AddEncoderJob()
CEncoderPool::EncodeSample()
CFHD_EncodeAsyncSample()
I think it is blocking at the ConditionVariable:
// Wait until there is space in the queue
space.Wait(mutex);

Now I see this. Same idea as before: stop sending, continue consuming. Let the process finish naturally.

Yes, as David mentioned that's fine when using a single thread, but when using separate input, output and control threads you really need a way of ensuring 100% that the functions can be forced to unblock.
For example in DirectShow an output thread can block in GetDeliveryBuffer() as it waits for an output buffer to become available. But when the filter graph is stopped/flushed, GetDeliveryBuffer() is FORCED to unblock and returns an error code. I think that something similar is needed in the Cineform SDK for both input and output functions.
I can cope with handling the exception for now. If I have some free time I''l try to find out how the unblocking this can be added, but I'm hampered from stepping through the SDK code by an obscure problem with the debug build of the SDK (the release build works fine).


[WIP/POC] remove tagger for serverless

What does this PR do?
Remove tagger dependencies from the serverless build
comp/dogstatsd/replay/writer.go
Remove reference to tagger by extracting the writer function to a dedicated file (+ !serverless build flag) into a writer_write.go file
comp/trace/config/setup.go
Remove reference to tagger by creating containerSetup
With two implementations

One for severless (no-op) in setup_serverless.go
One for non-serverless env in setup_container.go
Both file are protected by exclusive build tags

pkg/aggregator/aggregator.go
Remove ref to tagger by creating tagger+ tagger_serverless
pkg/aggregator/context_resolver.go
Remove tagger ref
Use enrichTag instead of EnrichTag from previous step
pkg/aggregator/no_aggregation_stream_worker.go
Same as previous

checkCardinality

@maxday Just as a heads up, you may be able to slice out the tagger with this in-review PR as well: https://github.com/DataDog/datadog-agent/pull/21314

For the record I computed some stats for the init duration of the serverless agent on this branch:
base:   min=268ms, max=290ms, avg=278.3ms, median=278.5ms
branch: min=257ms, max=271ms, avg=264.2ms, median=264.5ms

So removing the tagger (and its dependencies) removes around 15ms of init time duration


NSG Flow log billing meter

The page mentions that NSG flow logs are billed per GB of logs collected,
I was wondering under which billing metric (meter/submeter which resource)
it's possible to follow up this consumption,
there seems to be no mention of any on this or other documentation pages that I can find.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd699dac-d6e5-5a39-624f-2d3f77f92fca
Version Independent ID: c922bcd2-0778-a7af-4855-1bff6c9ce380
Content: Introduction to flow logging for NSGs - Azure Network Watcher
Content Source: articles/network-watcher/network-watcher-nsg-flow-logging-overview.md
Service: network-watcher
GitHub Login: @damendo
Microsoft Alias: damendo

Thanks for the feedback! We are currently investigating and will update you shortly.

@frozen-oranges It should be under network watcher service name as- network logs collected.
Refer- https://azure.microsoft.com/en-us/pricing/details/network-watcher/)
Total flow log cost = Network Logs usage (collected) cost + storage cost. If you use Traffic Analytics on top of Flow logs, then Traffic analytics cost and corresponding LA ingestion and storage cost will be added as well.
These details can be checked using Azure Cost Management + Billing | Microsoft Docs

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Pushdown DAX functions to Direct Query

We are building data connector with ODBC Driver to implement direct query to our data source.
We found serveral DAX functions in Power BI can pushdown to direct query but several cannot. For example, MAX/MIN aggregations can pushdown to SQLs and leverage aggregation index in the data source; but other functions like MEDIAN/PERCENTILE aggregations cannot. In such case, Power BI has to load all detailed data from source and calculate MEDIAN/PERCENTILE in-memory, which may have performance risk in huge data scale.
Is there any interface or extension points we can implement or overwrite to pushdown those DAX functions to direct query? Thanks!

I'm afraid this isn't possible today. You're not the first person who's requested it, so hopefully we'll be able to deliver it at some point.
For what it's worth, the way this works today is that the AS engine generates SQL queries and sends them to us. We convert the SQL to M and end up with a query that combines what AS sent with the original user query that defined the table in the model. This query is what's pushed to the connector.
To support this change, we'd need to add an M function for percentile and probably a new non-broken median function -- and then implement the translation of the SQL pattern into M. We also need a way for the connector to report that it supports folding of these operations.


setState callback is not called (React 16?)

The following issue is still an issue: https://github.com/airbnb/enzyme/issues/953
It was blocked because of react-test-renderer, which fixed the issue in the following PR: https://github.com/facebook/react/pull/10106.
Via this commit: https://github.com/facebook/react/commit/5ac62095996cce7b5441d9fad73fbcda1e3d2fca
Basically we must update react-test-renderer to ^16.1.1

Update here: https://github.com/airbnb/enzyme/pull/1367


Is 'Evaluate on raw images' not supported yet?

Thanks very much for the awesome repo @ruotianluo .
Is the section Evaluate on raw images not supported yet? Based on my understanding, this section requires the use of dataloaderraw.py, which does not have data['att_mask'] properly set yet. Or am I understanding something wrong?
All I am trying to do is generating caption for some images. Any pointer is appreciated!

It's fixed now.


templating engine for help generation

Right now, help generation is done via code. For small string generation it worked ok. But with time I feel it is becoming difficult to maintain the help generation code.
Templating engines are built specifically for this. You can look at a template such as this:

  {{ for product in products }}

{{ product.name }}

           Price: {{ product.price }}
           {{ product.description | string.truncate 15 }}

  {{ end }}

");

https://github.com/lunet-io/scriban
and know what is going to get rendered. This approach also makes it easy to intuitively change help text. The way tests are written it should not matter how help got rendered, so ideally tests should not get modified

Agreed, it would bring more clarity.  The downside is taking on an external dependency for core functionality.   I also am not sure how it will hold up with the new terminal features like virtual terminal sequences.  Using those would provide a better format for the help for terminals that support it.  I'd been holding off on touching help again until we better understood adoption and how we should expect to interact with them.

How will the template engine ensure text is properly aligned in columns?  We generally have to loop through all the rows to get the max length of each field and pad with spaces.

How will the template engine ensure text is properly aligned in columns?
That will be an easy problem I think. Similar to asp.net mvc view models, we compute everything before hand and give dumb models to views to render. I can not be sure until I try though.

Agreed, it would bring more clarity. The downside is taking on an external dependency for core functionality. I also am not sure how it will hold up with the new terminal features like virtual terminal sequences. Using those would provide a better format for the help for terminals that support it. I'd been holding off on touching help again until we better understood adoption and how we should expect to interact with them.

yeah, I just created this issue for templated related discussions. even if we decide to do this change it can not be done suddenly. we need to consider the concerns you have mentioned. like being able to colour strings, and making sure alignment is proper, dependency etc.
Just just use this issue for such discussions and spikes/explorations for now.

If we go this route with an external dependency, it should be a separate package like the other external dependencies.  This way we can rev it independently.

It would also be great if there was a way for middleware to inject information into help for commands and arguments. I haven't thought of a clean approach for that yet.  The template would need to save a place for the data.  The problem is that the middleware doesn't know what the template looks like and the template doesn't know what info the middleware wants to output.

What middlewares dont have to think about injecting info into templates... What if they are just concerned about creating data. Once a middleware decides that it is the final middleware, it passes that data to help rendering middleware with a template name.
Just some thoughts.

Yes, the middleware doesn't need to know about the template specifically.
It needs to be able to specify some information to show and what entity
that info belongs to.  The command, subcommand, argument, etc.
I wonder if there are some generalized concepts about the help
documentation to let the middleware give hints.  For example, show before
or after arguments.  Show at top or bottom.  This is a symbol to postfix to
the end of an argument.
On Wed, Apr 1, 2020 at 9:55 AM Bilal<EMAIL_ADDRESS>wrote:

What middlewares dont have to think about injecting info into templates...
What if they are just concerned about creating data. Once a middleware
decides that it is the final middleware, it passes that data to help
rendering middleware with a template name.
Just some thoughts.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bilal-fazlani/commanddotnet/issues/231#issuecomment-607123836,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAZHMP4LOKIY54QYC55JATRKL6QXANCNFSM4LX4EOPQ
.

For example, show before or after arguments. Show at top or bottom.

With templates, I can think of following points

Create use different templates instead of using a lot or ifs
We don't have to provide settings such as "show at top or bottom" to the devs. We can provide predefined set of templates. And allow devs use their own template if they want to.
The data we provide to all templates can be same. (lots of data) and its up to templates to consume all or minimum data.

This is a symbol to postfix to the end of an argument.

I am not sure if I understand  this correctly.

Also, just a thought - may it is worth exploring if we can create html template and then render it on console. Like how browsh or lynx does it? Using some library of course (if there is any).
Not sure if that is possible, but if we find any library, then that can take care of colors, as well as table like padded alignments. But this is just too ambitious :P

For example, show before or after arguments. Show at top or bottom.
My point with this is that we have a bit of a race condition.  A help template doesn't know what middleware is registered.  A middleware doesn't know how to modify or append to the help output.
Let's say we're adding a middleware component to support separated arguments.  How does that middleware indicate the command supports separated arguments?  It should update the Usage section, but it doesn't know the format of the section so it can't just modify it.  And the help template doesn't know about this middleware.  How do we solve this?

Let's say we're adding a middleware component to support separated arguments. How does that middleware indicate the command supports separated arguments?

What about using A ViewModel?
So out context class has one more property called view model. This view has all properties required to render help. All middlewares which want to modify help, keep enriching this view model and keep passing it to next middleware until it finally reaches the help middleware where it gets passed to a view (template) and gets rendered.
In this case, our new middleware component adds relevant info into the view model.

I was thinking about middleware that may want to add some kind of indicator to an argument, like our "" or "(Multiple)". Perhaps, "!" for required or "*" for footnotes in extended help text.

So middleware don't decide how things get rendered. They just enrich information and its up to the template to decide how to render things.
For example, ViewModel contains a command and command contains 2 arguments. 1 non required other required. You can decide to a template which renders required args like this: agr1 ! or you can use a a template which renders required args like this: arg1: REQUIRED
The middleware just collect core domain cli data such as what is required, what is the type of argument, what is the description, etc. It doesn't decide how to display that data. Template decides that.
With this thought, a middleware can enrich the view model with footnote but it's the template that decide where to render that footnote and how.
I hope that makes sense..

I am sorry if that was incorrect, I have less knowledge about the framework than you now

What about using A ViewModel?
So our context class has one more property called view model. This view model has all properties required to render help. All middlewares which want to modify help, keep enriching this view model and keep passing it to next middleware until it finally reaches the help middleware where it gets passed to a view (template) and gets rendered.

Yes, I was thinking something similar.  It's just a matter of representing that model in a way that's as simple as possible while still being expressive enough.

You can decide to a template which renders required args like this: agr1 ! or you can use a a template which renders required args like this: arg1: REQUIRED

The gotcha here is that the template now has to understand "Required". Required is a contrived enough example that it's easy to assume a template should know about it.  When we generalize the concept, required is just another feature.  How does the template know what to do with "Random Feature H", maybe we'll call it Hamburger. The argument is totally Hamburger.
How would the Hamburger middleware represent itself in the template?  Likely, the answer is to update the text of the ViewModel.

The gotcha here is that the template now has to understand "Required".

Yes. That is because this template is specifically designed for model "XYZ" and XYX has a property "Required"

How does the template know what to do with "Random Feature H"

That is the one and only job of template. As template developers, we decide what to do with model data and hardcode its presentation logic into the template

How would the Hamburger middleware represent itself in the template? Likely, the answer is to update the text of the ViewModel.

Yes. There are some best practices of doing this. For example it's ok to put bool IsHamburger and int HamburgerPrice properties in the model and assign them values. It's not idiomatic to put int DescriptionLeftOffset properties in model and assign them values in the middleware.

That is the one and only job of template. As template developers, we decide what to do with model data and hardcode its presentation logic into the template

As a template developer, how do you model for data that you don't know about?  What about data from custom middleware from an external package or defined in the application?

Yes. There are some best practices of doing this. For example it's ok to put bool IsHamburger and int HamburgerPrice properties in the model and assign them values. It's not idiomatic to put int DescriptionLeftOffset properties in model and assign them values in the middleware.

I agree with this.  I'm probably overthinking this.  I guess the best we can do is offer a default template and make it easy for users to update when they're adding other middleware that adds new properties to the view model.

As a template developer, how do you model for data that you don't know about? What about data from custom middleware from an external package or defined in the application?

This is a good question. If a person is introducing a middleware which wants to introduce new data to help, they would have to add their own template. But they also need a place where that data can be stored. The ViewModel can have a placeholder Dictionary<string, object> customData for such scenarios. I agree that this is not the cleanest solution, but considering the number of people who might want do this, I think that solution should be fine. A more sophisticated solution might be based on generics but I am not sure if the outcome will justify the amount of engineering involved :P

To summarize:

pick a templating library
create CommandDotNet.{library-name}  eg. CommandDotNet.Scriban , CommandDotNet.DotLiquid,  CommandDotNet.RazerLite ...
create a IHelpTextProvider
add appRunner.Using___() ext method that takes an optional template string or filepath for users to provide customizations.

nice-to-have: users can template the help strings from attributes, like [Command(Description="lala {{ app.name }} lala")]
If, along the way we develop a good ViewModel, we can consider bringing that into CommandDotNet to be available for middleware to update and append to.

Another nice-to-have would be the ability to output all commands to markdown or man page files to be used as documentation for an application.  Probably v2 of the package.


add dispatch device utils to support other device type

Currently, vllm implemented kernels could only run on cuda device, to enable more device like cpu or xpu, we need to provide some mechanism to dispatch device at runtime(like pytorch provide cpu and cuda kernel by default).
Here is a proposal to add device dispatch. Any suggestion or better approch is welcome:)

@WoosukKwon Please take a look:)


Concave Body.velocity Issue in 'collisionStart' Event

Firstly, thanks for a really cool engine.
I'm having an issue accessing a body's velocity in the example below. The velocity vector of the body is returned as {0,0} while it is actually non-zero values when logged in the animation loop. This behaviour only occurs when using a concave body; for ex. it works fine if I replace the concave body with a circle body.
Matter.Events.on(engine,'collisionStart', function(event)
    var pairs = event.pairs;
    for(var i=0; i<pairs.length; i++) {
        console.log( pairs[i].bodyB.velocity);
     }
});

The concave body:
var starvertices = Vertices.fromPath('50 0 63 38 100 38 69 59 82 100 50 75 18 100 31 59 0 38 37 38');
this.body = Bodies.fromVertices(_x, _y, starvertices, {
   render: {
                fillStyle: color,
                strokeStyle: color,
                lineWidth: 1
            }
}, true);

Help would be greatly appreciated.
Thanks.

Assuming you need the velocity of the parent body, note collision events pairs are given for each part, so in that case this would be Body.getVelocity(pairs[i].bodyB.parent).
Note if you need the actual velocity of a part rather than the parent body, you'll need to also account for the part's offset from the parent body position as well as the parent body's angular velocity too.
I've also updated the docs on parts to help make this distinction a bit clearer, thanks.


Pod creation fails on OpenShift 4.3.5 with Istio 1.4.6

Fixes https://github.com/istio/istio/issues/22449

Once we've decided on the best course of action for 1.4, I'll fix this in 1.5 and master.

@jacob-delgado: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_cni_release-1.4
125e49663cdfc9b8627fadcd281c6f11dca9e025
link
/test lint_cni_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jacob-delgado can we get this merged?

cc @brian-avery @rlenglet
Can you please review this? I'll ping the release managers when I get a thumbs up.

Looks reasonable to me, but I'm not a CNI expert.

Looks reasonable to me, but I'm not a CNI expert.

Do you know who's? This is breaking on of our customers and we are currently patching it in private. Much easier for us to upstream these fixes. Thanks!

@luksa wrote our CNI content for OpenShift Service Mesh. I've asked him to take a look.

I fixed this on master a couple of months ago and it was backported to 1.5.
The instructions are here: https://istio.io/docs/setup/additional-setup/cni/#hosted-kubernetes-settings
So, would it make sense to backport the same fix to 1.4?

@jwendell +1

@jwendell +1

I fixed this on master a couple of months ago and it was backported to 1.5.
The instructions are here: istio.io/docs/setup/additional-setup/cni/#hosted-kubernetes-settings
So, would it make sense to backport the same fix to 1.4?

I take it this is the issue https://github.com/istio/cni/pull/237? A uniformed approach across all supported versions would be better than the approach in this PR.

it is concerning that none of the tests failed.
For every supported platform vendors should add tests.
Google team will do it for gke and Kind is not it.

Can you guard the usage of k8s-cni-net-dir? in both

mount in spec
install-cni, check readiness only if the it exist.

I reverted my changes and did a manual backport of https://github.com/istio/cni/pull/237
One discrepancy is in the install-cni.sh script found here https://github.com/istio/cni/pull/237/files#diff-a1fbe10058a1077a440d75c2abf5f1e1R93

@jwendell PTAL, this has your PR changes backported.
@mandarjog @lambdai can you do the verification on your platform?

@jacob-delgado this PR needs corresponding changes in other repos:
https://github.com/istio/istio/pull/20708
and doc changes for 1.4

I add do-not-merge label so that @jwendell can do the final review. Please you can remove the label then.

I'll merge this and the operator change, https://github.com/istio/operator/pull/771, in preparation for a overall build in the morning.

https://github.com/istio/istio.io/pull/7095 is the Doc PR.
One issue I noted in their and confirmed with @frankbu this morning is that the istio.io archive docs (which includes 1.4) are frozen and can't be updated. He did say that if we have to fix something in an old release, we can explain the doc is wrong and the needed change in the release notes for the point release.
Does that invalidate this solution? Or is the release notes sufficient? Looking at the doc PR changes, it seems to imply the docs are broken as they are now (oc has -n instead of a : ) in addition to the new install section. Maybe the user will look at the current 1.5 docs which I believe have the same/correct items.


Do you accept remote people?

Hi @haikyuu you can work remote, but first you need to work at least 3-4 months with us so you can get in par with our code.

OK thanks. And about the language, is it ok if i only talk english?

@haikyuu: definitely, we all speak english. :)

Sounds cool ✨

we do now: https://github.com/entria/jobs/pull/2


countdistinct bug

echo '1 2 2 3' | zq -z 'countdistinct()' -
{countdistinct:1(uint64)}

The mdtests are disabled.   It just doesn't work.

Plan is:

change name to dcount
take out hyperloglog and bring back later (create an issue for this)
use a map
fix bug with type (so two layer map)
generate error on table size exceeded

let's get this correct and worry about scale later.


Added more bodies of the solar system

Added the rest of the planets of our Solar System to the bodies list.

Codecov Report

Merging #169 into master will increase coverage by 0.15%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   82.25%   82.41%   +0.15%
==========================================
  Files          24       24
  Lines         885      893       +8
  Branches       66       66
==========================================
+ Hits          728      736       +8
  Misses        137      137
  Partials       20       20

Impacted Files
Coverage Δ

src/poliastro/bodies.py
96.29% <100%> (+1.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aba08c...f3974a3. Read the comment docs.

I amend myself: the coverage has increased! But it's kind of misleading because the code is just running, nobody is checking if the values are what they should be.

Also, I forgot to say: the important values (those who need greater precision) are in Table 8 of the DE430 report. The radiuses of the bodies are not that important in my view, but still should be read from a reputable source and properly cited.

We finally made a decision regarding the use of planetary constants in poliastro.
https://github.com/poliastro/poliastro/pull/197#issuecomment-321748009
So it means we are closing this PR in favor of #197. I appreciate your effort and encourage you to keep on contributing to poliastro!


Hack day/multi step progress bar

Added MultiStepProgressItem and MultiStepProgressBar components
and their tests and demos to canon-react.

Check out the commit guidelines https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#-git-commit-guidelines
You should do a rebase -i and squash to one commit, something like:
feat: adding MultiStepProgressItem and MultiStepProgressBar


fix: Enable HAProxy statistics report port 1936

Port 1936 is used to get HAProxy statistics report via web browser.

:tada: This PR is included in version 2.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Cleanup: resolve duplicate anchor issues

Merging.

merged:https://github.com/openshiftio/appdev-documentation/commit/c0d4541c2561e87cd72d983778d387f37f2e5add


Added proper mapping for 8BitDo Wireless Adapter on Linux

Please confirm before merge - DInput mode of this PR has A,B,X,Y reversed. On my Xbox One controller, they layout is
   Y
X     B
   A

I'm not sure previous version was a mistake, or it corresponds to different gamepads.

There have been multiple firmware updates at least one of which mentioned/addressed face button mapping.
I’m not sure if the dongle reorders the face buttons to match the labels or leaves them the same relative to cardinal direction (SDL and this repo defer to the latter).
I don’t have the hardware on hand to update/compare/check right now, but I can confirm in few weeks. If you want me to merge now and check later let me know and I’ll do so, otherwise just letting you know this has been seen! Thx for the PR

There have been multiple firmware updates at least one of which mentioned/addressed face button mapping.
I’m not sure if the dongle reorders the face buttons to match the labels or leaves them the same relative to cardinal direction (SDL and this repo defer to the latter).
I don’t have the hardware on hand to update/compare/check right now, but I can confirm in few weeks. If you want me to merge now and check later let me know and I’ll do so, otherwise just letting you know this has been seen! Thx for the PR

Checked with VM, looks good. Looks like the relevant firmware update was  12/11/2019 Firmware v1.30:

2. Fixed the button mapping issue for A/B and X/Y for Xbox One & Xbox One Elite 2 on D-input mode.

Checked with VM, looks good. Looks like the relevant firmware update was  12/11/2019 Firmware v1.30:

2. Fixed the button mapping issue for A/B and X/Y for Xbox One & Xbox One Elite 2 on D-input mode.


[BUG] USDT token not found or loading in UI

Steps to reproduce the behavior:

Go to '...'Error while loading the ERC20 contracts. / missing revert data in call exception; Transaction reverted without a reason string [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (data="0x", transaction={"to":"0x054B8f99D15cC5B35a42a926635977d62692F25b","data":"0x95d89b41","accessList":null}, error={"reason":"bad response","code":"SERVER_ERROR","status":403,"headers":{"content-length":"96","content-type":"application/json"},"body":"{"jsonrpc":"2.0","id":43,"error":{"code":-32600,"message":"project ID is temporarily disabled"}}","requestBody":"{"method":"eth_call","params":[{"to":"0x054b8f99d15cc5b35a42a926635977d62692f25b","data":"0x95d89b41"},"latest"],"id":43,"jsonrpc":"2.0"}","requestMethod":"POST","url":"https://mainnet.infura.io/v3/bb094b985d4444e08d1358697d22dbd5"}, code=CALL_EXCEPTION, version=providers/5.7.2)

Hi @helionicp, so far I could not reproduce the problem, and USDT is loading fine for me.
Do you still see the token list, but without USDT? If so, please open the "Manage Tokens" (at the bottom of the list) modal and disable USDT. Then load the token list again. Then turn it back on again and load it again (the million times proved "turn it off and back on again" ;) )

Ok, it's working now. Thank you so much.

There is a centralized point of failure in your system, you will need to change infra for Ethereum to a more decentralized version.

Hi @helionicp Thanks for confirming that it's working now, and for pointing out an important aspect that could and should be improved.
I will put this on the table in our planning meetings, so we can evaluate it and take next steps on it.


Caption => DisplayName

cc @Tratcher

Hi @HaoK, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

:shipit:

e091bceaa8ed468f8a50754c8ea84d52ce59ec50


Disable nested created

I need to disable nested create for some types in my Schema. I'm looking through the source code to find out how to do this. Could you suggest where to alter the code to accomplish that?
My guess is it's do with this line.
    elif input_flag == "create_nested":
        items["create"] = graphene.Field(
            convert_model_to_input_type(model, input_flag="create", registry=registry)
        )

``

Currently meta parameters cannot do to this level of customization, i am open to proposals to allow this level as well as disabling lookup fields in whereInputType


Symbol constraints for documentId not specified

Describe the bug

If I create a Fluid document with a documentId containing a colon for example urn:something it will create the document but subsequent operation including loading the container again will fail
There are likely other special characters that will create similar issues.
To Reproduce
Steps to reproduce the behaviour:

hardcode a documentId  in the cra-appexample to   use urn:something as the document id
launch the app to create the container and redirect to http://localhost:3000/#urn:something
reload the app with the given link http://localhost:3000/#urn:something
client and server side errors will appear (client request will fail with error 400)

Expected behaviour

It should work or fail to create the container in the first place since the documentId contains invalid characters or work consistently.
Logs
Client Error:

Server Error:

Sample log of tinylicious outputs when creating and loading a container with documentId urn:something
info: protocolTree "sha":"09be4158cf27b614361594f7ee8e4451046a9204","tree":[{"path":"attributes","mode":"100644","sha":"78acfe732d445a76ca4ca45276a9e89bc745e0da","size":0,"type":"blob","url":""},{"path":"quorumMembers","mode":"100644","sha":"0637a088a01e8ddab3bf3fa98dbe804cbde1a0dc","size":0,"type":"blob","url":""},{"path":"quorumProposals","mode":"100644","sha":"0637a088a01e8ddab3bf3fa98dbe804cbde1a0dc","size":0,"type":"blob","url":""},{"path":"quorumValues","mode":"100644","sha":"c730f7a6ff8c606cc2b7d083e5a9705bff0d7029","size":0,"type":"blob","url":""}],"url":""} {"messageMetaData":{"documentId":"urn%3Asomething","tenantId":"tinylicious"},"label":"winston","timestamp":"2021-06-22T15:58:25.036Z"}
info: appSummaryTree {"sha":"bb49e149fa59d48937a50eda5ea1ee1a5160647c","tree":[{"path":".blobs","mode":"040000","sha":"4b825dc642cb6eb9a060e54bf8d69288fbee4904","size":0,"type":"tree","url":""},{"path":".channels","mode":"040000","sha":"92e4d079826d12307dc96d1df21b0616ebf75399","size":0,"type":"tree","url":""},{"path":".metadata","mode":"100644","sha":"b15e82c2a2e350cf2b33bd7137b445546789992e","size":0,"type":"blob","url":""}],"url":""} {"messageMetaData":{"documentId":"urn%3Asomething","tenantId":"tinylicious"},"label":"winston","timestamp":"2021-06-22T15:58:25.036Z"}
info: POST /repos/tinylicious/git/trees 201 2.025 ms - 537 ![image](https://user-images.githubusercontent.com/43415869/122961795-07ce3e00-d385-11eb-8227-b83549036d5f.png)"label":"winston","timestamp":"2021-06-22T15:58:25.039Z"}
info: POST /repos/tinylicious/git/commits 201 1.813 ms - 379 {"label":"winston","timestamp":"2021-06-22T15:58:25.043Z"}
info: POST /repos/tinylicious/git/refs 201 2.267 ms - 124 {"label":"winston","timestamp":"2021-06-22T15:58:25.050Z"}
info: commit sha: "c0cc509272ca71e96de5ab0e065aba2fb44ff284" {"messageMetaData":{"documentId":"urn%3Asomething","tenantId":"tinylicious"},"label":"winston","timestamp":"2021-06-22T15:58:25.050Z"}
info: POST /documents/tinylicious 201 66.327 ms - 17 {"label":"winston","timestamp":"2021-06-22T15:58:25.050Z"}
info: OPTIONS /deltas/tinylicious/urn%3Asomething?from=0&to=2001 204 0.153 ms - 0 {"label":"winston","timestamp":"2021-06-22T15:58:25.064Z"}
info: GET /deltas/tinylicious/urn%3Asomething?from=0&to=2001 200 0.371 ms - 2 {"label":"winston","timestamp":"2021-06-22T15:58:25.065Z"}
info: Disconnect of 8ca78cfe-9f29-463c-9cca-f24935742374 from room {"messageMetaData":{"documentId":"urn%3Asomething","tenantId":"tinylicious"},"label":"winston","timestamp":"2021-06-22T15:58:35.759Z"}
info: OPTIONS /repos/tinylicious/commits?token=dGlueWxpY2lvdXM%3D&count=1&sha=urn%3Asomething 204 0.099 ms - 0 {"label":"winston","timestamp":"2021-06-22T15:58:35.893Z"}
info: GET /repos/tinylicious/commits?token=dGlueWxpY2lvdXM%3D&count=1&sha=urn%3Asomething 400 1.301 ms - 135 {"label":"winston","timestamp":"2021-06-22T15:58:35.896Z"}
info: GET /repos/tinylicious/git/refs/heads/urn%253Asomething 200 0.639 ms - 119 {"label":"winston","timestamp":"2021-06-22T15:58:35.917Z"}
info: GET /repos/tinylicious/contents/.protocol/attributes?ref=c0cc509272ca71e96de5ab0e065aba2fb44ff284 200 4.523 ms - 214 {"label":"winston","timestamp":"2021-06-22T15:58:35.923Z"}
info: Disconnect of 23dcf399-90f9-4fd4-94d5-810324e23e41 {"messageMetaData":{"documentId":"urn%3Asomething","tenantId":"tinylicious"},"label":"winston","timestamp":"2021-06-22T15:58:35.932Z"}
info: Disconnect of 23dcf399-90f9-4fd4-94d5-810324e23e41 from room {"messageMetaData":{"documentId":"urn%3Asomething","tenantId":"tinylicious"},"label":"winston","timestamp":"2021-06-22T15:58:35.932Z"}
info: GET /repos/tinylicious/git/refs/heads/urn%253Asomething 200 0.690 ms - 119 {"label":"winston","timestamp":"2021-06-22T15:58:35.935Z"}
info: GET /repos/tinylicious/git/commits/c0cc509272ca71e96de5ab0e065aba2fb44ff284 200 0.674 ms - 381 {"label":"winston","timestamp":"2021-06-22T15:58:35.936Z"}
info: GET /repos/tinylicious/git/trees/06e8514167a1accb24e4532da891080dcfd0c5c6?recursive=0 200 2.197 ms - 537 {"label":"winston","timestamp":"2021-06-22T15:58:35.943Z"}
info: POST /repos/tinylicious/git/blobs 201 5.881 ms - 59 {"label":"winston","timestamp":"2021-06-22T15:58:35.944Z"}
info: POST /repos/tinylicious/git/blobs 201 4.926 ms - 59 {"label":"winston","timestamp":"2021-06-22T15:58:35.945Z"}
info: POST /repos/tinylicious/git/blobs 201 5.572 ms - 59 {"label":"winston","timestamp":"2021-06-22T15:58:35.946Z"}
info: POST /repos/tinylicious/git/trees 201 3.355 ms - 184 {"label":"winston","timestamp":"2021-06-22T15:58:35.950Z"}
info: POST /repos/tinylicious/git/trees 201 2.396 ms - 296 {"label":"winston","timestamp":"2021-06-22T15:58:35.951Z"}
info: POST /repos/tinylicious/git/trees 201 1.736 ms - 779 {"label":"winston","timestamp":"2021-06-22T15:58:35.954Z"}
info: POST /repos/tinylicious/git/commits 201 1.708 ms - 456 {"label":"winston","timestamp":"2021-06-22T15:58:35.958Z"}
info: PATCH /repos/tinylicious/git/refs/heads/urn%3Asomething 400 0.658 ms - 338 {"label":"winston","timestamp":"2021-06-22T15:58:35.960Z"}

This came up in a 3P scenario where the customer was migrating existing documents to Fluid.  Being able to preserve the original doc ids would make integration simpler.
If we can't make that work, we should document the set of legal characters and verify there's no way to use ':' and other characters to attack the service.


OAuth2 backchannel renewal

OAuth2 backchannel renewal: Renew authentication token via backchannel
Description:

When an authentication token has expired and the user makes a request, the OAuth layer makes a renewal request via the Identity Provider's (IdP) backchannel.  Reason being that AJAX requests cannot deal with a redirect to login with the IdP.

I'm not sure I understand the feature request. Are you proposing a new functionality in oauth2 filter?

When I use Apache HTTPd with mod_oauth2, the proxy layer seems to manage renewing the access token (the client does need to poke the proxy layer with a timely message, paying attention to the expiry time), the renewal seems to happen between the proxy layer and the IdP.  When I switched to trying out Envoy (due to the annoyance of having to compile httpd with mod_oauth for ARM takes a long time), it seems to want to totally manage the access token thus alleviating the need to pass a Bearer Token for the client, etc, however, the AJAX calls I am making from our client layer to the api layer through the envoy proxy layer will fail once the token expires, as Envoy seem to require the AJAX layer to log into the IdP again.  Thus I imagine it is not using whatever information is in the token to allow renewal on the backchannel.
I do not know OAuth2 protocols, so if I am misusing terms that is because I simply want to use OAuth not write OAuth, if that makes sense.
As I "understand", it seems that the envoy oauth2 feature is missing the renewal capability, or I am missing how to use this feature?

CC @mattklein123 @derekargueta who probably know more about oauth2 than me.

AFAIK, the oauth2 filter doesn't refresh the id token using the refresh token. It just sets the cookie expired date and use the standard user auth code flow to get the tokens again when it's expired.


Replace Squeaky CI advice with custom advice

Closes https://github.com/Qiskit/documentation/issues/838.
Replaces the message in CI with correct instructions for our repository. I've added a switch to remove the advice from the printed message, I think this is the neatest net logic change: https://github.com/frankharkins/squeaky/commit/33e24f8eb633d25758c787c4efd5d645458c352f.

See https://github.com/frankharkins/documentation/pull/2 for the test PR.
This doesn't display the message when running tox -e lint, but I think it's unlikely a contributor would run that command locally without first encountering it in CI.

Thank you too!


redbiom now adds per sample studies to analysis

While working on this I realized that format_biom_rows was duplicated with similar functionality so decided to merge them. Also that qiita_pet/templates/artifact_ajax/artifact_summary.html should be an input and not a link so the js works as expected.

Codecov Report

Merging #2288 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #2288      +/-   ##
==========================================
+ Coverage   93.84%   93.84%   +<.01%
==========================================
  Files         163      163
  Lines       18494    18502       +8
==========================================
+ Hits        17356    17364       +8
  Misses       1138     1138

Impacted Files
Coverage Δ

qiita_pet/test/test_qiita_redbiom.py
98.52% <100%> (+0.11%)
:arrow_up:

qiita_pet/handlers/qiita_redbiom.py
94.8% <100%> (+0.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9aa1c4...46b174e. Read the comment docs.


rust-analyzer-unwrapped: 2024-06-03 -> 2024-06-11

Diff: https://github.com/rust-lang/rust-analyzer/compare/2024-06-03...2024-06-11
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 319386 run on x86_64-linux 1

4 packages built:

ra-multiplex
rust-analyzer
rust-analyzer-unwrapped
vscode-extensions.rust-lang.rust-analyzer

Result of nixpkgs-review pr 319386 run on x86_64-linux 1

4 packages built:

ra-multiplex
rust-analyzer
rust-analyzer-unwrapped
vscode-extensions.rust-lang.rust-analyzer


The 'is failing' and 'is passing' are past tense statuses

StatusFailing and StatusPassing are sent after a build has happened.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Mike Williams seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @gaima8 first of all thank you for the pr, i really appreciate the time that you put into this. Unfortunately we are not going to accept this submission, mostly because it could affect existing behaviour.  In more detail, the terminology used for build messages is 'standard' across most CI providers. Secondly and more importantly, changing messages like this can affect other automation that relies on these messages.
Thanks again for your work.


docs: contributing: Add docs on how to build docs locally

Can I work on this? I had some questions -

Should this be added in the contributing section of the documentation as a new subheading (making it Linux, Windows, Building documentation locally) or should I add a new point in both of the installations stating how to build the docs?
Which commands should I add for the documentation? mkdocs serve or mkdocs build or both?

I also couldn't find a link to the deployed documentation website. Could you please provide me the link?

Hi @Vaibhav-Chopra-GT, you can go ahead!

Yes, see https://www.builtree.org/simulate/contributing/ for reference.
You can refer the docs above

Deployed docs:
main/released
dev


focus-visible variant won't work without PostCSS plugin and JS polyfill

According to the Tailwind docs, the focus-visible variant only works with a PostCSS plugin and JS polyfill.
The JS polyfill I can live with, but I rather not use PostCSS plugins with WindiCSS (the experience of getting them to work has been mixed). Is there something we can do here to make the variant more usable out of the box?

To clarify, it does work in Chrome, Safari and Firefox, but need the polyfills to support other browsers (Edge?). Maybe not a crucial issue.

No. Edge now use chromium core, so it has support too.  And I don't think we need to support ie...


Fulcio 1.0

[ ] https://github.com/sigstore/fulcio/issues/716
[ ] https://github.com/sigstore/fulcio/issues/612
[ ] https://github.com/sigstore/fulcio/issues/589

Adding https://github.com/sigstore/fulcio/issues/589 which is also tracked in public good instance

this is done and rolled out to prod!


SELECTOR.dirty does not exist in rscli.py on line 934

The program stops because SELECTOR.dirty is used, but the property does not exist.

Added pull request: #3

Dirty-check on the GUI was cumbersome and replaced with direct save of changes. The pull request fixes no dirty-check on CLI.


Feature: Acknowledge return statements and JSX elements as levels of nesting

Currently, sticky scroll treats both JSX components and return statements as flat. For Example:
export default function Example() {
  const firstGen = "I'm a direct child of Example";
  doSomething();
  // return statement also at depth 1
  return (

        I'm nested at depth 4

  )
}

...gets folded to the following when scrolled to 'I'm nested at depth 4'
export default function Example() {
        I'm nested at depth 4

  )
}

...but Ideally, it would be folded to:
export default function Example() {
  return (

        I'm nested at depth 4

  )
}

We try to keep VS Code lean and we think the functionality you're asking for is great for a VS Code extension. Maybe you can already find one that suits you in the VS Code Marketplace. Just in case, in a few simple steps you can get started writing your own extension. See also our issue reporting guidelines.
Happy Coding!


[WIP] KSCrash 1.13 / Objc Namespace

Current coverage is 82.20% (diff: 57.69%)

Merging #106 into master will decrease coverage by 0.43%

@@             master       #106   diff @@
==========================================
  Files            27         27
  Lines          1895       1905    +10
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1566       1566
- Misses          329        339    +10
  Partials          0          0

Powered by Codecov. Last update 01e98a5...d95133d

Does this mean users now have to adjust their code?

Yes .. but just their objc code, we needed it because of this:
https://github.com/getsentry/sentry-swift/issues/31#issuecomment-268983277

In that case we should make sure to bump the API and mention it in the docs

Do you mean even go for 2.x or is 1.4.x engough?
Because its a "soft" break, Xcode even suggest to rename User to SentryUser when compiling?

1.4 might be enough. Just need to make sure we mention the change somewhere in a changelog in the docs.


(refactor): Enable new engines with custom dispatching and other constructs

Feature or Bugfix

Refactoring

Detail
The current codebase cannot easily support multiple engines. The below changes remediate that:

Move distributed methods out of non-distributed modules
Add a custom dispatcher and use it to register methods based on the execution engine and memory format value
Add classes to manage the state of the execution engine and memory format
Refactor the structure of distributed modules to support multiple engines

Code flow:

Engine class is initialised at import
It detects the installed engine (python vs ray), initialises the engine and registers the dispatched methods based on the value of the engine and memory format (using this custom dispatcher)

The good:

Clear separation of concerns: Distributed methods live outside non-distributed code, eliminating ugly if conditionals, allowing both to scale independently and making them easier to maintain in the future
Better dispatching: Adding a new engine/memory format is as simple as creating a new directory with its methods and registering them with the custom dispatcher based on the value of the engine or memory format
Custom engine/memory format classes: Give more flexibility than config when it comes to interacting with the engine and managing its state (initialising, registering, get/setting...)

The bad:

Managing state: Adding a custom dispatcher means that we must maintain its state. For instance, one capability currently missing in this PR is unregistering methods when a user sets a different engine (e.g. moving from ray to dask at execution time).
Detecting the engine: Conditionals are simpler/easier when it comes to detecting an engine. With a custom dispatcher, the registration and dispatching process is more opaque/convoluted. For instance, there is a higher risk of not realising that we are using a given engine vs another

The ugly:

Unused arguments: Each method registered with the dispatcher must accept the union of both non-distributed and distributed arguments, even though some would be unused. As the list of supported engines grows, so does the number of unused arguments. It also means that we must maintain the same list of arguments across the different versions of the method

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 7e5b8e30184137902665f17107c8e9eb58668327
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubLoadTests5656BB24-s6u9F3qN9oFy
Commit ID: 7e5b8e30184137902665f17107c8e9eb58668327
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubStandardCodeBuild8C06-llutOAimTATs
Commit ID: 7e5b8e30184137902665f17107c8e9eb58668327
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 76ac88e10f28e5ec3b47d09c5186a3e2eff5bde9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubLoadTests5656BB24-s6u9F3qN9oFy
Commit ID: 76ac88e10f28e5ec3b47d09c5186a3e2eff5bde9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubStandardCodeBuild8C06-llutOAimTATs
Commit ID: 76ac88e10f28e5ec3b47d09c5186a3e2eff5bde9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: c511d30dd94f0bf068126ccdb84dae7dd0178450
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubStandardCodeBuild8C06-llutOAimTATs
Commit ID: c511d30dd94f0bf068126ccdb84dae7dd0178450
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubLoadTests5656BB24-s6u9F3qN9oFy
Commit ID: c511d30dd94f0bf068126ccdb84dae7dd0178450
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 9fd4093a617af60ccca4ad3a212987cb1acaec1c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubLoadTests5656BB24-s6u9F3qN9oFy
Commit ID: 9fd4093a617af60ccca4ad3a212987cb1acaec1c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubStandardCodeBuild8C06-llutOAimTATs
Commit ID: 9fd4093a617af60ccca4ad3a212987cb1acaec1c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubStandardCodeBuild8C06-llutOAimTATs
Commit ID: fadfdf7155d313a2806fe95840e7a1d877d8bf41
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: eb8e42d2be05ff583b2523cd9939af453e025bec
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubLoadTests5656BB24-s6u9F3qN9oFy
Commit ID: eb8e42d2be05ff583b2523cd9939af453e025bec
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubStandardCodeBuild8C06-llutOAimTATs
Commit ID: eb8e42d2be05ff583b2523cd9939af453e025bec
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


TracingStartedInPage event not found.

Just noticed:
$ pwmetrics https://jsfeatures.in
Event RendererMain.START_MSG_LOOP has already been started
Event RendererMain.START_MSG_LOOP has already been started
TracingStartedInPage event not found.
Sorry, Visually Complete 85% metric is unavailable

Looks like it's something to do with user-timings

Filed https://github.com/GoogleChrome/lighthouse/issues/617 upstream to tackle part of this.
Interesting that you get the start_msg_loop log, but that's a bug on the devtools side we need to sort out.
Did you have any results at all on this run?

$ pwmetrics --json https://jsfeatures.in
{
  "timings": [
    {
      "name": "First Contentful Paint",
      "value": 1875.337
    },
    {
      "name": "First Meaningful Paint",
      "value": 1970.7
    },
    {
      "name": "Median Visual Completion",
      "value": 1997
    },
    {
      "name": "First Visual Change",
      "value": 1917
    },
    {
      "name": "Visually Complete 100%",
      "value": 2004
    },
    {
      "name": "Time to Interactive",
      "value": -1
    },
    {
      "name": "Visually Complete 85%"
    },
    {
      "name": "Navigation Start",
      "value": 0
    }
  ],
  "timestamps": [
    303915241.28
  ]
}

From nmow ;)

probably addressed now.


尝试将qwen1.5 14b llamafy后unsloth训练报错

Reminder

[X] I have read the README and searched the existing issues.

Reproduction
报错信息：
File "/mnt/cpfs/guanyutao/new-LLaMa-Factory/LLaMA-Factory/src/train.py", line 5, in main
run_exp()
File "/mnt/cpfs/guanyutao/new-LLaMa-Factory/LLaMA-Factory/src/llmtuner/train/tuner.py", line 33, in run_exp
run_sft(model_args, data_args, training_args, finetuning_args, generating_args, callbacks)
File "/mnt/cpfs/guanyutao/new-LLaMa-Factory/LLaMA-Factory/src/llmtuner/train/sft/workflow.py", line 34, in run_sft
model = load_model(tokenizer, model_args, finetuning_args, training_args.do_train)
File "/mnt/cpfs/guanyutao/new-LLaMa-Factory/LLaMA-Factory/src/llmtuner/model/loader.py", line 117, in load_model
model = load_unsloth_pretrained_model(config, model_args)
File "/mnt/cpfs/guanyutao/new-LLaMa-Factory/LLaMA-Factory/src/llmtuner/model/utils/unsloth.py", line 43, in load_unsloth_pretrained_model
model, _ = FastLanguageModel.from_pretrained(**unsloth_kwargs)
File "/opt/conda/lib/python3.10/site-packages/unsloth/models/loader.py", line 142, in from_pretrained
model, tokenizer = dispatch_model.from_pretrained(
File "/opt/conda/lib/python3.10/site-packages/unsloth/models/llama.py", line 1121, in from_pretrained
model, tokenizer = patch_tokenizer(model, tokenizer)
File "/opt/conda/lib/python3.10/site-packages/unsloth/models/_utils.py", line 185, in patch_tokenizer
raise RuntimeError(
RuntimeError: Unsloth: Tokenizer's pad_token cannot be = eos_token, and we couldn't find a
replacement of either <|reserved... or <|placeholder...
replacement of either <|reserved... or <|placeholder...
采用https://github.com/Minami-su/character_AI_open/blob/main/llamafy_qwen_v2.py进行llamafy，这是llamafy后的模型文件：

Expected behavior
No response
System Info
No response
Others
No response

unsloth 最新版已经支持了 qwen1.5 https://github.com/unslothai/unsloth/pull/447

unsloth 最新版已经支持了 qwen1.5 unslothai/unsloth#447

更新最新的unsloth，在本仓库直接微调qwen1.5就可以了吗？

大佬@hiyouga能否指点一下，FSDP  + Qlora的情况下，unsloth是不是不支持Qwen1.5。我尝试用最新代码运行过，结果报错：
RuntimeError: Unsloth: Unfortunately Qwen2 type models do not support RoPE scaling!
unsloth是用的最新的版本。


Redo broken GIFs

Unfortunately, @FloChiff GIFs don't work on every browsers, we need to find out why, and/or to remake them so that they loop instead of stopping after 1 loop.

On Chrome, gifs seem to be working fine! Do we know which browsers have issues displaying the gifs?

Yes, I have this problem on Firefox, whether I'm on the local dev server or on the deployed websie

Are all gifs from @FloChiff broken on your firefox? Could you link a walkthrough where you encounter the problem please?

I just check and on my computer, whether it is with Firefox or Chrome, some GIFs just refuse to loop (I only looked at the manual transcription walkthrough)

Weird, the transcription walkthrough works fine on my computer. 🤔


Inconsistent naming - category vs. level

Hi, there seems to be confusing and inconsistent naming across the library and its documentation regarding consent category vs. level.

The cookie itself contains level field
There is cookieconsent.get('level') method
<script data-cookiecategory=""> uses on the other hand term category
The example configuration has examples like my_category1
In the readme there are also mostly references to "cookie categories"
The new method getUserPreferences() returns accepted_categories and rejected_categories - ie. not levels.

So what should be used? Shouldn't this be also unified?

Yes, should be categories instead of level!


Remove oauth2client

Pre-Flight checklist

[ ] Testing

[ ] Code is tested
[ ] Changes have been manually tested

What are the relevant tickets?
Closes #1465
What's this PR do?
Removes oauth2client (deprecated) and uses google-oauth2 instead for the YouTube API.
How should this be manually tested?

Set OCW_STUDIO_ENVIRONMENT=devdev to bypass use of fake minio s3 buckets.  Set AWS_, YT_, and VIDEO_S3_ .env values to the same as on RC.
Upload a small video to a site's videos_final folder, then sync.
Check that there is a new Video object via django admin.
Using postman or curl, send the following request to http://localhost:8043/api/transcode-jobs/:

{
  "version": "0",
  "id": "c120fe11-87db-c292-b3e5-1cc90740f6e1",
  "detail-type": "MediaConvert Job State Change",
  "source": "aws.mediaconvert",
  "account": "<AWS_ACCOUNT_ID>",
  "time": "2021-08-05T16:52:33Z",
  "region": "us-east-1",
  "resources": [
    "arn:aws:mediaconvert:us-east-1:11111111:jobs/111111111-abplcg"
  ],
  "detail": {
    "timestamp":<PHONE_NUMBER>136,
    "accountId": "<AWS_ACCOUNT_ID>",
    "queue": "arn:aws:mediaconvert:us-east-1:<AWS_ACCOUNT_ID>:queues/Default",
    "jobId": "<VIDEOJOB_ID>",
    "status": "COMPLETE",
    "userMetadata": {},
    "outputGroupDetails": [
      {
        "outputDetails": [
          {
            "outputFilePaths": [
              "s3://ol-ocw-studio-app-qa/aws_mediaconvert_transcodes/<VIDEO_BASE_NAME>_youtube.mp4"
            ],
            "durationInMs": 132033,
            "videoDetails": {
              "widthInPx": 1280,
              "heightInPx": 720
            }
          }
        ],
        "type": "FILE_GROUP"
      }
    ]
  }
}

where VIDEO_BASE_NAME is derived from the Video.source_key value, for example:
gdrive_uploads/course1/14EvKgqg1eQqzxoo6YxvmxOxgf-HPn0mM/medium.mp4. -> course1/14EvKgqg1eQqzxoo6YxvmxOxgf-HPn0mM/medium

Wait a few minutes and verify that the video is uploaded to Youtube, processed, and is playable (refresh the Django admin page for the video every few minutes).

Codecov Report

Merging #1466 (5d949c8) into master (18b32ba) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1466      +/-   ##
==========================================
- Coverage   89.33%   89.32%   -0.01%
==========================================
  Files         235      235
  Lines        9954     9951       -3
  Branches     1873     1873
==========================================
- Hits         8892     8889       -3
  Misses        926      926
  Partials      136      136

Impacted Files
Coverage Δ

videos/conftest.py
100.00% <100.00%> (ø)

videos/youtube.py
97.61% <100.00%> (-0.06%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


vcpkg-tool tests does not build on arm macs

When I try to build for arm64 I get the following error:
[ 97%] Building CXX object CMakeFiles/vcpkg-test.dir/src/vcpkg-test/update.cpp.o
In file included from /Users/leanderSchulten/git_projekte/vcpkg-tool/src/vcpkg-test/catch.cpp:2:
/Users/leanderSchulten/git_projekte/vcpkg-tool/include/catch2/catch.hpp:7869:13: error: unrecognized instruction mnemonic, did you mean: bit, cnt, hint, ins, not?
            CATCH_BREAK_INTO_DEBUGGER();
            ^
/Users/leanderSchulten/git_projekte/vcpkg-tool/include/catch2/catch.hpp:7583:79: note: expanded from macro 'CATCH_BREAK_INTO_DEBUGGER'
    #define CATCH_BREAK_INTO_DEBUGGER() []{ if( Catch::isDebuggerActive() ) { CATCH_TRAP(); } }()
                                                                              ^
/Users/leanderSchulten/git_projekte/vcpkg-tool/include/catch2/catch.hpp:7562:34: note: expanded from macro 'CATCH_TRAP'
    #define CATCH_TRAP() __asm__("int $3\n" : : ) /* NOLINT */
                                 ^
<inline asm>:1:2: note: instantiated into assembly here
        int $3
        ^
1 error generated.

This is fixed upstream in catch2, so you have to update the dependency

@vicroms, could you please take a look?

We are already using a version with https://github.com/catchorg/Catch2/pull/1971


fix: check for empty string path parameters

This PR modifies ValidateStruct which only checks for non-nil parameter values to also check for parameter values that are the empty string. This matches behavior in the other cores.
Internal Tracking Issue: #1908

:tada: This PR is included in version 4.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Request] PHP-GMP enable option in workspace .env settings

Info:

Docker version ($ docker --version): 18.03.1-ce, build 9ee9f40
Laradock commit ($ git rev-parse HEAD): 2ec2312
System info (Mac, PC, Linux): Mac
System info disto/version: High Sierra 10.13.6

Issue:
The PHP extension GMP is installed in the PHP-FPM container, but composer install won't run in the workspace because it's not enable there in the CLI.

@vladyslavstartsev  That doesn't work.

@adammparker  can you please close your issue if every thing works fine?

Need help
I need php7.1-gmp in workspace container. I have set the following variable to WORKSPACE_INSTALL_GMP=true and PHP_FPM_INSTALL_GMP=true. php version in workspace container is PHP_VERSION=7.1. Rebuilding (docker-compose build --no-cache workspace) workspace container installs php7.2-gmp instead of php7.1-gmp. @vladyslavstartsev

okay, somehow it installs old PHP 7.2,
make sure it installs 7.1 (for example check that you changed values in .env and not env-example)


AmazonS3EncryptionClient not able to decrypt objects in S3 that are encrypted by SES

Scenario
We have set up a receipt rule in SES, to perform encryption on the inbound email and save it to S3. This encrypted object can only be decrypted by the client. When we used  AmazonS3EncryptionClient in the .NET SDK , we got the following error
"Value 'AES/GCM/NoPadding' for metadata key 'x-amz-cek-alg' is invalid. AmazonS3EncryptionClient only supports 'AES/CBC/PKCS5Padding' as the content encryption algorithm. Although this more is supported by other AWS SDKs, the .NET SDK does not support at this time.
Current Behavior

Possible Solution
Any possible way to achieve the client side decryption for this scenario in .NET. Please advise.
Steps to Reproduce (for bugs)

Context

Your Environment

AWSSDK.Core version used:
Service assembly and version used:
Operating System and version:
Visual Studio version:
Targeted .NET platform:

.NET Core Info

.NET Core version used for development:
.NET Core version installed in the environment where application runs:
Output of dotnet --info:
Contents of project.json/project.csproj:

As I understand things GCM is being added to .NET Core 3.0. There are some third party libraries of GCM but we don't know the support of those libraries so we don't want to take a dependency on them.

As I understand things GCM is being added to .NET Core 3.0. There are some third party libraries of GCM but we don't know the support of those libraries so we don't want to take a dependency on them.

Although you've taken extra dependencies for the Java SDK.
Namely on BouncyCastle, which happens to maintain a .Net/C# version through the same governance structure. From quick look into change log they have added support to GCM in 2008. What is different for .Net?


How about Fastify support?

Now I can select backend
yarn add @ts-rest/nest @ts-rest/express

but I would like to type
yarn add @ts-rest/fastify

and use this awesome tool with https://www.fastify.io/

The project looks amazing but this is currently a deal breaker for me.

@NOT-HAL9000 I was thinking the same 2 days ago, but tried it with express and now I feel that it's not that bad how I expected. Developer Experience even without fastify was amazing.

@gustawdaniel The dx of ts-rest looks amazing, but moving away from fastify to express is not an option.

As this is in high demand I'm going to look into this :)

@tsanyqudsi @NOT-HAL9000 @gustawdaniel The fastify lib is deployed under version 3.24.0-rc.0 :)
Also the PR #237 is open so this is your opportunity for feedback before we can't make breaking changes!

@oliverbutler Amazing! Thank you so much!


Support for diff custom style

Thanks for your work!
In this contribution, I have added a custom style option based on the documentation of the react-diff-viewer component.
This is a simple snippet:
diff_viewer(
    old_text,
    new_text,
    split_view=split_view,
    use_dark_theme=use_dark_theme,
    left_title=left_title,
    right_title=right_title,
    extra_lines_surrounding_diff=extra_lines_surrounding_diff,
    hide_line_numbers=hide_line_numbers,
    highlight_lines=highlight_lines,
    styles={"wordDiff": {"display": "inline", "padding": "0px"}},
)

Thank again!
P.S.: if you accept this pull request don't forget to build and publish the new version on PyPI

Thank you for your contribution! I will publish next version in a while!


Support HTML5 getUserMedia?

It's useful for KYC purpose - it's established as a standard behaviour that if a user is doing KYC form on the mobile, they will be offered to take a photo instead of uploading a photo (e.g. XAPP). As neuron is mostly javascript, it's kind of expected to happen in JS
navigator.mediaDevices.getUserMedia

An example of its use:
https://www.kirupa.com/html5/accessing_your_webcam_in_html5.htm

We will provide this feature in next milestone. Thanks.


Windows support TODOs

Git bash required to use (possibly WSL)

[x] need native windows installer/updater (installer now works on git bash)
[ ] add/host command is broken because of sudo and different hosts path
[x] interactive commands require j k l h keys to navigate instead of arrows (fixed by new prompt library)
[x] redis command "Error: not supported by windows"
[x] ssh command "Error: not supported by windows"
[x] Figure out what to do with prompt library (make fork an official go module)? Because of Windows bugs among other issues.
[x] Test our prompt library.
[x] self-update currently broken, but investigating fix
[ ] ssh and redis commands kind of work. You get a prompt, but no keyboard input is allowed.
[x] Uninstall instructions in readme

$ nitro ssh
Welcome to Ubuntu 18.04.4 LTS (GNU/Linux 4.15.0-96-generic x86_64)

 * Documentation:  https://help.ubuntu.com
 * Management:     https://landscape.canonical.com
 * Support:        https://ubuntu.com/advantage

  System information as of Thu Apr 30 19:06:02 PDT 2020

  System load:  0.0               Processes:              120
  Usage of /:   7.0% of 38.60GB   Users logged in:        0
  Memory usage: 52%               IP address for eth0:    <IP_ADDRESS>
  Swap usage:   0%                IP address for docker0: <IP_ADDRESS>

0 packages can be updated.
0 updates are security updates.

Last login: Thu Apr 30 19:14:48 2020 from <IP_ADDRESS>
ubuntu@nitro-dev:~$

I just pushed code that will be in the next release to correct redis and ssh errors on Windows.

When I run bash <(curl -sLS http://installer.getnitro.sh) on windows powershell I get this error:
At line:1 char:6
+ bash <(curl -sLS http://installer.getnitro.sh)
+      ~
The '<' operator is reserved for future use.
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : RedirectionNotSupported

Hope this helps!

I believe my issue is multipass is installed on windows (PS) and not WSL or bash

@clarknelson Yup... Git Bash is required https://github.com/craftcms/nitro/blob/windows/README.md#installation

I need to work on the paths for the apply command, path destinations are coming out strange on Windows:
Removing mount C:/Users/Jason from nitro-dev
Mounting ~\go\src\github.com\craftcms\nitro\demo-site to nitro-dev
umount failed: The following errors occurred:
"=>" is not mounted
"=>" not found in database

Thanks, I suppose that makes sense I am new to windows development.
Here is what I have now. The command runs but it wont let me input a command before it terminates:

@clarknelson yup resolved here and will be in the next beta release, early next week. https://github.com/craftcms/nitro/issues/115

@jasonmccallister I'm sure you already know, but gotta "" those Windows paths take into account spaces.

Great! I will start with Homestead and come back to Nitro when the new release is out :)

I just pushed a fix for the windows redis and ssh commands. I also resolved the issue with spaces in mount paths.

I get this

Now I have this error when trying to install:

One more for this list!

I think the install script should ask you to add the nitro dir /c/users/clark/Nitro to your path since it can't do that on Windows easily.
What the installer script does is essentially grab the nitro.exe from the latest release tag an put it in /c/Users/clark/Nitro then it tries to run nitro init.
Windows support is still WIP since many commands don't run in Windows yet.

thanks for the heads up on the path so I can keep going

@clarknelson Yup... Git Bash is required https://github.com/craftcms/nitro/blob/windows/README.md#installation

Install Multipass (requires 1.2.0+).
Download nitro_windows_x86_64.zip from the latest release
Create a Nitro folder in your home folder. i.e. C:\Users<username>\Nitro
Extract the zip file and copy nitro.exe into the Nitro folder you just created in your home folder.
Run this from the command line to add nitro to your global path: setx path "%PATH%;%USERPROFILE%\Nitro"
Run nitro init to create your first machine.

Where does it say it requires wsl or linux distro to be installed as a pre-requisite. The commands runs only on cmd or powershell.
bash comes to play after you run an instance within powershell?

@brandonkelly @jasonmccallister
For windows there is still the need of php and composer installed as native for composer to work?
Can we cd to path/to/project and run composer of the nitro-dev to be folder to install craft?
Also we do still need to edit hosts file manually to resolve a site host name?
Can you shed light on exact steps for windows in the documentation.

@delixyr

For windows there is still the need of php and composer installed as native for composer to work?

Not really related to Windows, but no for PHP and the next beta release will have Composer installed in the Nitro machine by default (see https://github.com/craftcms/nitro/issues/149).

Can we cd to path/to/project and run composer of the nitro-dev to be folder to install craft?

Yes.

Also we do still need to edit hosts file manually to resolve a site host name?

Yes, because of this:

Can you shed light on exact steps for windows in the documentation.

We will update the docs on the windows branch as progress is made. Please note that Windows is still a WIP so there are issues we are working through in the beta. We plan to have official Windows support before 1.0 launches.

We just released Nitro 1.0.0-beta.6 which greatly improves Windows support.  Works with regular old cmd.exe, but the biggest caveats are 1) cmd.exe needs to be run with Administrator permissions and 2) installing/updating is a manual process.  Be sure and check out the README for Windows-specific instructions.
Going to go ahead and close this one out and we can keep track of Windows tickets separately in their own issues now.


Facebook::Messenger::FacebookError: An active access token must be used to query information about the current user

Hi,
I keep getting the error Facebook::Messenger::FacebookError: An active access token must be used to query information about the current user. I have checked my PAGE_ACCESS_TOKEN and it's correct too... the code is shown after the error below.
rackup -p 3000
[2018-04-30 15:42:04] INFO  WEBrick 1.4.2
[2018-04-30 15:42:04] INFO  ruby 2.5.0 (2017-12-25) [x86_64-darwin17]
[2018-04-30 15:42:04] INFO  WEBrick::HTTPServer#start: pid=2513 port=3000
EAACzokllmUQBAMg6OfEZCfwIT3ks9UZA0Poyd7ZA6TcG4ZATECiQZCYsFQGPdKPJpbiq8boO4nck1NQRdu9sh22f0t76qpxcEmDoec0TOJMxLQppOdCgzNoCrefNAh0MRpiZA3YVztBeZAOnLj7GMhsHPrUS0gvqAHF07TnS4GvDAZDZD
Received '#<Facebook::Messenger::Incoming::Message:0x00007f84a43f1b98 @messaging={"sender"=>{"id"=>"1670528496347150"}, "recipient"=>{"id"=>"574780496202446"}, "timestamp"=>1525117231716, "message"=>{"mid"=>"mid.$cAAIKwp1Ztt5pSVdqZFjGBIiNIp6n", "seq"=>519605, "text"=>"gps"}}>' from {"id"=>"1670528496347150"}
Facebook::Messenger::FacebookError: An active access token must be used to query information about the current user.
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/facebook-messenger-1.0.0/lib/facebook/messenger/bot/error_parser.rb:53:in `raise_errors_from'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/facebook-messenger-1.0.0/lib/facebook/messenger/bot.rb:40:in `deliver'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/facebook-messenger-1.0.0/lib/facebook/messenger/incoming/common.rb:57:in `reply'
	/Users/trevor/Projects/bender/bot.rb:12:in `block in <top (required)>'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/facebook-messenger-1.0.0/lib/facebook/messenger/bot.rb:75:in `trigger'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/facebook-messenger-1.0.0/lib/facebook/messenger/bot.rb:67:in `receive'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/facebook-messenger-1.0.0/lib/facebook/messenger/server.rb:135:in `block (2 levels) in trigger'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/facebook-messenger-1.0.0/lib/facebook/messenger/server.rb:134:in `each'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/facebook-messenger-1.0.0/lib/facebook/messenger/server.rb:134:in `block in trigger'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/facebook-messenger-1.0.0/lib/facebook/messenger/server.rb:128:in `each'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/facebook-messenger-1.0.0/lib/facebook/messenger/server.rb:128:in `trigger'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/facebook-messenger-1.0.0/lib/facebook/messenger/server.rb:50:in `receive'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/facebook-messenger-1.0.0/lib/facebook/messenger/server.rb:29:in `call'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/facebook-messenger-1.0.0/lib/facebook/messenger/server.rb:19:in `call'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/rack-2.0.5/lib/rack/urlmap.rb:68:in `block in call'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/rack-2.0.5/lib/rack/urlmap.rb:53:in `each'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/rack-2.0.5/lib/rack/urlmap.rb:53:in `call'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/rack-2.0.5/lib/rack/tempfile_reaper.rb:15:in `call'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/rack-2.0.5/lib/rack/lint.rb:49:in `_call'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/rack-2.0.5/lib/rack/lint.rb:37:in `call'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/rack-2.0.5/lib/rack/show_exceptions.rb:23:in `call'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/rack-2.0.5/lib/rack/common_logger.rb:33:in `call'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/sinatra-2.0.1/lib/sinatra/base.rb:231:in `call'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/rack-2.0.5/lib/rack/chunked.rb:54:in `call'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/rack-2.0.5/lib/rack/content_length.rb:15:in `call'
	/Users/trevor/.rvm/gems/ruby-2.5.0/gems/rack-2.0.5/lib/rack/handler/webrick.rb:86:in `service'
	/Users/trevor/.rvm/rubies/ruby-2.5.0/lib/ruby/2.5.0/webrick/httpserver.rb:140:in `service'
	/Users/trevor/.rvm/rubies/ruby-2.5.0/lib/ruby/2.5.0/webrick/httpserver.rb:96:in `run'
	/Users/trevor/.rvm/rubies/ruby-2.5.0/lib/ruby/2.5.0/webrick/server.rb:307:in `block in start_thread'
2a03:2880:2040:8fc7:face:b00c:0:8000 - - [30/Apr/2018:15:42:25 -0400] "POST /webhook HTTP/1.1" 500 88593 0.1144

require 'facebook/messenger'
include Facebook::Messenger

Facebook::Messenger::Subscriptions.subscribe(access_token: ENV["PAGE_ACCESS_TOKEN"])

Bot.on :message do |message|
  puts ENV["PAGE_ACCESS_TOKEN"]
  puts "Received '#{message.inspect}' from #{message.sender}"

  message.reply(text: 'Hello, man!')
end

Any suggestions?

Suddenly my messenger exploded with responses... I think there may be some kind of issue at FB at the moment, it's been really slow today.


🤯 Visual Studio Code Extension

Is your feature request related to a problem? Please describe.
It's a feature request.
Describe the solution you'd like
It'd be amazing if you could make a Visual Studio Code extension to upload the selected part of our code to your API. I don't think it'd be that hard to do since you have the API running and you did a great job building the whole system...
Describe alternatives you've considered
I use other extensions but they all export as PNG files, which could also be an option for your extension but I'd prefer a cool webpage like yours current situation.
Additional context
None.

Why did you close this one? I'd like to make integration with your service in my extension. I think it'd extremely handy!


Default gaps are set to zero

By default, the gaps should be set to a value smaller than the higher gap in the hierarchy.
I have not visually tried the default values below, but let's start there.
Workspace margin:  32px
Gap Level 1          :   16px
Gap Level 2          :   8px
Gap Level 3          :   4 px
Gap Level 4          :   4 px
Gap Level 5          :   4 px
etc.

At today's (2015-08-04) meeting we agreed to set gutter to half of a parent by default.

Closing, because it is related to the old layout editor which was phased out.


License yearly update

Is your feature request related to a problem? Please describe.
Every year we need to update the License file to reflect the new year.
Describe the solution you'd like
Implement Github action to create a PR updating the License year automatically every year. This is available at https://github.com/marketplace/actions/update-license-copyright-year-s
Describe alternatives you've considered
Update the year manually. This would make sense if the Github action did not exist, but why not use something that is already developed?
Additional context
None

Created the PR for this on https://github.com/Leaflet/Leaflet/pull/7892


Execution results of given wasm file different from other runtime tools

Test Case
The given testcase was simply mutated a wasm file, which was obtained by compiling C program generated with Csmith using Emscripten Compiler(Emcc).
The original C program is c_file.c, the compilation results with Emscripten is wasm_file.wasm, and its wat format is wat_file.wat.
We mutated the wat file to change its global.set 0 in line 43614 with local.set 0. The result after mutation is mutated_file.wat, and its wasm format is mutated_file.wasm.
Expected Results
$ iwasm --stack-size=819600000 mutated_file.wasm

Output nothing.
Actual Results
$ iwasm --stack-size=819600000 mutated_file.wasm
Exception: out of bounds memory access

Versions and Environment
Tools Version: iwasm 1.2.3
Operating system: Ubuntu 22.04.1
Architecture: x86_64
Extra Info
I tried to use some other wasm runtimes, such as wasmer, wasmedge and wasmtime to execute the same testcase, they terminate normally and do not output anything(do not trigger errors).
Maybe there is something wrong with the “exception handling module”, or related parameters while using wamr to execute the given testcase are incorrect. Due to a lack of knowledge of WebAssembly, the detail still need you to confirm.

Hi, @luxinyi0105 I just ran your test case and got the same result.
Luckily I was able to find the root of this problem. To some extent, it's not a bug, but a feature. WAMR does a rather more strict memory boundary check.
This exception arises when calling function 3, namely wasi_fd_write in L43659. If we take a look at what parameter passes to this call, there is one parameter:
;; L43650-L43651
local.get 0
i32.load offset=60

The mutated_file.wasm set global 0 rather than local 0, making it out of boundary when calling the function.
You can set the breakpoint at wasi_fd_write to see how those boundary checks happen and how the changed value of that parameter causes OOB in the case of mutated_file.wasm.
BTW, if we don't care whether wasi_fd_write to a valid address or not and comment out the L658-661 of libc_wasi_wrapper.c, we can exit with 0. I would not recommend it in any other normal case, writing to an invalid address and failing silently is actually pretty dangerous, but for this program, you just want to give it a taste, you can surely try it :)


Chapter 7 Error when   when importing EvalDocuments in Colab

Information
The problem arises in chapter:

[ ] Introduction
[ ] Text Classification
[ ] Transformer Anatomy
[ ] Multilingual Named Entity Recognition
[ ] Text Generation
[ ] Summarization
[x] Question Answering
[ ] Making Transformers Efficient in Production
[ ] Dealing with Few to No Labels
[ ] Training Transformers from Scratch
[ ] Future Directions

Describe the bug
Error when importing EvalDocuments
ImportError: cannot import name 'EvalDocuments' from 'haystack.modeling.evaluation.eval' (unknown location)

To Reproduce
Steps to reproduce the behavior:

pip install farm-haystack
from haystack.eval import EvalDocuments

Expected behavior
Complete import EvalDocuments without error

EvalDocuments was removed.
https://github.com/deepset-ai/haystack/pull/1778

I tried to fix it as follows. Is this correct?
# create labels

labels = []
for i, row in dfs["test"].iterrows():
    # Metadata used for filtering in the Retriever
    meta = {"item_id": row["title"], "question_id": row["id"]}
    # Populate labels for questions with answers
    if len(row["answers.text"]):
        for ii, answer in enumerate(row["answers.text"]):
            span_start = row["answers.answer_start"][ii]
            span_end = span_start + len(answer)
            label = Label(
                query=row["question"],
                answer=Answer(
                    answer=answer,
                    offsets_in_context=[Span(span_start, span_end)] # 設定してもevalのscoreは変わらない。不要の可能性あり。
                ),
                document=Document(
                   id=i,
                   content_type="text",
                   content=row["context"]
                ),
                origin="gold-label",
                meta=meta,
                is_correct_answer=True,
                is_correct_document=True,
                no_answer=False)

            labels.append(label)

    # Populate labels for questions without answers
    else:
        label = Label(
            query=row["question"],
            answer=None,
            document=Document(
                id=i,
                content_type="text",
                content=row["context"]
            ),
            origin="gold-label",
            meta=meta,
            is_correct_answer=True,
            is_correct_document=True,
            no_answer=True)

        labels.append(label)

# create aggregated labels

document_store.write_labels(labels, index="label")
labels_agg = document_store.get_all_labels_aggregated(
    index="label",
    open_domain=True,
    aggregate_by_meta=["item_id"]
)

# evaluate

eval_result = pipe.eval(labels=labels_agg, params={"Retriever": {"top_k": 3}})
metrics = eval_result.calculate_metrics()

print(f'Retriever - Recall (single relevant document): {metrics["Retriever"]["recall_single_hit"]}')
print(f'Retriever - Recall (multiple relevant documents): {metrics["Retriever"]["recall_multi_hit"]}')
print(f'Retriever - Mean Reciprocal Rank: {metrics["Retriever"]["mrr"]}')
print(f'Retriever - Precision: {metrics["Retriever"]["precision"]}')
print(f'Retriever - Mean Average Precision: {metrics["Retriever"]["map"]}')
print(f'Reader - F1-Score: {metrics["Reader"]["f1"]}')
print(f'Reader - Exact Match: {metrics["Reader"]["exact_match"]}')

For Chapter 7 I would recommend switching over to the Haystack tutorials (https://haystack.deepset.ai/tutorials).    Haystack has changed (and improved) significantly since the version used in the book, so I don't think there's much value in learning how it used to work.


Remove descriptor from conflict check

This is not a solution. It will conflict if you generate the whole .pb.go file.


Define File type in typespec

In mutlipart/form-data, there is a widget to upload a file, when send the request in multipart/form-data, the actual content will be like:
Content-Disposition: form-data; name="file1"; filename="a.txt"
Content-Type: text/plain

Note there is a filename and the content-type of the file.
Current typespec use bytes to refer a file-uploaded which doesn't contain that information.
Some services such as Document Translation care about the filename, randomly generating a file name is not acceptable for them.
Expected:
There is a some like File type in typespec, or maybe we need to define some decorator like @File(filename: string, contentType?: string) to indicate it is a File with some information
@File("FileName", "ContentType")

We may also consider how we could handle the array of files in multipart/form-data

@markcowl link to existing design issues

Tracking this as part of this design issue: https://github.com/microsoft/typespec/issues/2704


Feat/api delivery service qualifier in address

Closes issue #202

Rebased/Cherry-Picked to handle duplicate commits in history


Ignore the version suffix when comparing assistant names

resolves #890
Description

Since we appended the version as a suffix to the assistant version name and it will always change, we must ignore it when computing the difference between two versions. I think it makes sense to literally add the version in the name instead of doing it in the __str__ method, since then we don't have to manually add the version each time we care about query results. A good example is in pipelines when we list the available assistants. It doesn't use the __str__ representation, but rather the DB name
User Impact

The diff view will show the assistant changed when it actually did
Demo

Docs

Codecov Report
Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

apps/assistants/models.py
22.22%
7 Missing :warning:

Additional details and impacted files

:loudspeaker: Thoughts on this report? Let us know!

🚨 Try these New Features:

JS Bundle Analysis - Avoid shipping oversized bundles

Do we care if the name changes at all?

I can imagine if you change you assistant's behaviour significantly, you might want to rename is (super edge case), but other than that, probably not


Server unittests

This branch will stay open to track future unit test changes.

I'm pushing a failing test, so the Travis results are fine

I referenced this thread to enforce lowercase Tag text: https://stackoverflow.com/questions/871037/django-overriding-init-for-custom-forms


Add tests for com.kennycason.kumo.font.scale.*

Hi,
I've analysed your code base and noticed that the classes in com.kennycason.kumo.font.scale are not fully tested. This is according to IntelliJ's internal coverage runner.
I've written tests for the scale functions in these classes with the help of Diffblue Cover. Hopefully, they should help you detect any regressions caused by future code changes.
If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other particular classes that you consider important.

Thanks a lot @James-Adam Tests are very much welcome! :)


Generalized CashAddr

The goal of this pull request is to generalize the CashAddr specification so that it can be used with new address types, like stealth/reusable addresses that need more than an hash as payload. The changes can be summed up to:

Expand the purpose of the prefix to refer to use case differentiation (e.g.: SLP).
Change the interpretation of the 3 least significant bits of the version byte, now renamed type byte, to allow a different meaning for each type.

Although the goal was to preserve backward compatibility, the revision of the size bits mean the test implied by some test vectors (those with type 15) changed, that is, addresses with an unknown type can no longer be length checked from the size bits alone. For that reason those test vectors were segregated to a new section and with new payloads.

Looking at the spec from @matiu it really does sounds like the first step here is to actually figure out what we want for stealth addresses to begin with. Depending on the result, we can see what kind of addresses is the best. It does look like that what will be sent will very much be some kind of complex datastructure, especially if we want to support multisig and alike. Maybe the best is just to send a JSON over the wire ?


Cargo test fails on env_var_mask:works_from_any_dir

failures:

---- env_var_mask::works_from_any_dir stdout ----
thread 'env_var_mask::works_from_any_dir' panicked at 'Unexpected stdout, failed var.contains("tests passed")
└── var as str:

command=`"/home/twitu/Code/mask/target/debug/mask" "--maskfile" "/tmp/.tmpgB48C0/maskfile.md" "ci"`
code=127
stdout=``````
stderr=```bash: mask: command not found

If I understand correctly it's failing simply because mask executable is not installed $PATH. I tried running this after doing cargo install mask and the test passed.
Should a source code test depend on the executable being installed externally? If this is the desired behaviour it could be mentioned in the README somewhere that the executable should be installed before running tests.
Mask version: 7c316514bbdfbb73bad723b1c28a5436cb27a945
Cargo version: 1.43.0
OS: Ubuntu 20.04
Terminal: zsh

Ahhh this is a lack of documentation I think. I usually run mask link and then mask test... but that depends on mask being installed first....
I'll update the contributing docs