Steam windows missbehave when assigning them to a specific workspace

Hyprland Version
 System/Version info
Hyprland, built from branch main at commit 07c7235b7245375802c767472d62b776458c221d dirty (keybinds: Better handling of workspace_back_and_forth  (4952)).
Date: Mon Mar 4 13:05:20 2024
Tag: v0.36.0-46-g07c7235b

flags: (if any)

System Information:
System name: Linux
Node name: lucas
Release: 6.7.8-arch1-1
Version: #1 SMP PREEMPT_DYNAMIC Sun, 03 Mar 2024 00:30:36 +0000

GPU information:
01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GA104 [GeForce RTX 3070 Lite Hash Rate] [10de:2488] (rev a1) (prog-if 00 [VGA controller])

os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

plugins:

Bug or Regression?
Bug
Description
Sometimes, Steam Friend list spawns with size 5,5, ignoring even minsize window rules. It often spawns not centered to the screen monitor too.
> hyprctl clients -j | jq '.[] | select(.title=="Friends List")'

{
  "address": "0x5997e79add20",
  "mapped": true,
  "hidden": false,
  "at": [
    957,
    897
  ],
  "size": [
    5,
    5
  ],
  "workspace": {
    "id": 9,
    "name": "9"
  },
  "floating": true,
  "monitor": 0,
  "class": "steam",
  "title": "Friends List",
  "initialClass": "steam",
  "initialTitle": "Friends List",
  "pid": 748791,
  "xwayland": true,
  "pinned": false,
  "fullscreen": false,
  "fullscreenMode": 0,
  "fakeFullscreen": false,
  "grouped": [],
  "swallowing": "0x0",
  "focusHistoryID": 7
}

Here's the window rules in place for Steam:
windowrulev2 = workspace 9, class:steam
windowrulev2 = float, class: ^(steam)$, title:^(?!Steam).*$
windowrulev2 = minsize 280 635, class: ^(steam)$, title:^(Friends.*)$

Same result with or without known workarounds for different issues:
windowrulev2 = stayfocused, title:^()$,class:^(steam)$
windowrulev2 = minsize 1 1, title:^()$,class:^(steam)$

How to reproduce

Assign steam to a specific workspace (e.g. windowrulev2 = workspace 9, class:steam)
Start Steam (flickering ensues...)
open and close friend list until it refuses to open again in the same workspace/size

Crash reports, logs, images, videos
No response

If I recall correctly, this happens just after recent steam updates... and this also happens sometimes when launching a game which has a launch option dialog

Further investigation and this only happens when I link steam to a specific workspace:
windowrulev2 = workspace 9, class:steam
I have two monitors and workspace 9 is tied to one of them via
workspace = 9, monitor:$left
The "Signing in to Steam" window flickers between the center and top left of the screen. Then, it's just a matter of time before other windows just won't show up when i click them (including the Friends List).
Here's the logs pertaning to starting steam up and trying to open the friends list:
log.txt

This issue seems no longer appears in latest steam beta<PHONE_NUMBER>)

I am still able to replicate it in the new beta, although only in a forced manner (spam open and close the friends list tab until it happens). The blame seems to be entirely on the steam client though, so I've opened an issue with them a few months ago: https://github.com/ValveSoftware/steam-for-linux/issues/10706

Pretty much solved now :) Closing.


Comments in multiline JSX tags are parsed wrongly

In the code
<foo>
  <bar />
  # <baz /> leaving baz unimplemented
</foo>

I’d expect the comment to be ignored - instead, it seems to be parsed and placed into the function call, as follows:
React.createElement(foo, null,
  React.createElement(bar, null), """
  # """, React.createElement(baz, null), """ leaving baz unimplemented
""")

I’m assuming this is a bug, and I attached a failing test case.

Not a bug. Anything within a JSX expression which is not a JSX tag becomes a text node. Thus the # becomes literal text, and is not interpreted as a comment.
Consider this JS equivalent compiled with the official JSX transformer:
<Foo>
  <Bar />
  // <Baz /> leaving baz unimplemented
</Foo>

becomes
React.createElement(Foo, null,
  React.createElement(Bar, null),
  "// ", React.createElement(Baz, null), " leaving baz unimplemented"
)

Ah ok - if that’s upstream behaviour (which I find a bit weird, but hey ho) then following it seems like the right thing to do.
Thanks :)


Add clef support

Hi folks!
I've expanded music_xml to parse & support "clef" and would like to contribute that. Is this desired or do I have to make a new fork?

I've created a pull request


About the training and testing data

Hi Aaron,
you said in #12 that you didn't train the network on HELEN and LFPW , so I trained the network on IBUG  and AFW using 6000 images for training and about 800 for testing. Here is the loss a got:
epoch 0 : train_loss 0.352367, eval_loss 0.387095
epoch 1 : train_loss 0.278556, eval_loss 0.420478
epoch 2 : train_loss 0.239114, eval_loss 0.385385
epoch 3 : train_loss 0.211572, eval_loss 0.436594
epoch 4 : train_loss 0.190551, eval_loss 0.464007
epoch 5 : train_loss 0.175974, eval_loss 0.484641
epoch 6 : train_loss 0.163320, eval_loss 0.493853
epoch 7 : train_loss 0.153328, eval_loss 0.565732
epoch 8 : train_loss 0.145184, eval_loss 0.531872
epoch 9 : train_loss 0.138747, eval_loss 0.520749
epoch 10 : train_loss 0.132051, eval_loss 0.595860
epoch 11 : train_loss 0.126847, eval_loss 0.558690
epoch 12 : train_loss 0.121628, eval_loss 0.688304
epoch 13 : train_loss 0.117325, eval_loss 0.581210
epoch 14 : train_loss 0.113913, eval_loss 0.597701
epoch 15 : train_loss 0.109812, eval_loss 0.629373
epoch 16 : train_loss 0.107197, eval_loss 0.650522
epoch 17 : train_loss 0.103911, eval_loss 0.615461
epoch 18 : train_loss 0.100986, eval_loss 0.663053
epoch 19 : train_loss 0.098672, eval_loss 0.642940
epoch 20 : train_loss 0.096295, eval_loss 0.654145
epoch 21 : train_loss 0.094171, eval_loss 0.625737
epoch 22 : train_loss 0.091768, eval_loss 0.762728
epoch 23 : train_loss 0.089807, eval_loss 0.760316
epoch 24 : train_loss 0.088324, eval_loss 0.612928
epoch 25 : train_loss 0.085970, eval_loss 0.817148
epoch 26 : train_loss 0.084619, eval_loss 0.792491
epoch 27 : train_loss 0.083374, eval_loss 0.687534
as the training loss decreasing, the testing loss keeps increasing. I am not sure if it is because I didn't adopt the Flips images as training data or something else.
So would you tel me which folder you used for training and which for testing?
Thanks

I can't remember exactly. The exact sets we used are described in the paper. If your testing error is going up, perhaps you have generated the two sets of volumes with different scales or something.


Port over infrastructure from Spyder-Infra and Spyder-Docs

This PR ports the templatified Spyder-Infra to the Spyder API Docs, with the appropriate replacements, customizations, fixes, additions and improvements.
Among other things, it also adds our logo and favicon to the actual site.

[x] Fix issues discovered in Spyder-Infra
[x] Find/replace repo name (upper and lower)
[x] Find/replace basic fixmes
[x] Write longer fixmes
[x] Update Noxfile
[x] Add back relevant bits from Spyder-Docs
[x] Remove old cruft (makefiles)
[x] Update and improve conf.py
[x] Fix linkcheck issues
[ ] Fix (or suppress) pre-commit-detected issues

Only thing left for this to be ready to merge is fixing the outstanding issues detected by pre-commit; while it looks like a lot, nearly all that isn't auto-fixable are the Markdownlint hits on the MyST and the PyLint hits on the plugin template, most of which are style issues and similar and can just be suppressed by tweaking the configuration and ignores accordingly, and the rest which can be relatively easily fixed. Shouldn't take too long, but as its past 2 am I'm going to leave it for tomorrow morning.

Alright, was a bit more complicated than expected (mostly with Pylint, as try as I might there was no way to disable certain rules for certain files/directories without adding ignores for every file), but this PR is all done and ready to go.
AFAIK, the Netlify config needs to be merged to main to get the previews to operate properly, so while it should be all set up, I'll test that on the next PR.


Add trivy scan

Description:
Add a file scan for vulnerabilities using Trivy.
Link to tracking Issue:
#158

Woops. We already have it! Closing.


Android Scenario builder showing infra failure

P1 as this is potentially blocking a beta release of 1.22, which is needed for the iOS announcement
PR: https://github.com/flutter/engine/pull/21188
failure: https://ci.chromium.org/p/flutter/builders/try/Linux Android Scenarios/1156?
/cc @godofredoc @christopherfujino

The problem was a flake and has not happened again:
https://ci.chromium.org/p/flutter/builders/try/Linux Android Scenarios


component: modal

cf #85
Note: this is based on #150 as the ModalComponent depends on the ButtonComponent one

I have not handled the case where you want to use an icon in the title, we can do it later I think
a modal without an explicit html id is pretty much useless since you cannot refer to it in any button to open it. In this PR I’ve left it to the user to pass it with the regular html_attributes: { id: "modal-1" } kwarg. I don’t require the presence of this attribute, the component won’t fail if you don’t pass it. It will just be harder to use it (you’d need custom JS). We could instead have an explicitly required id param in the component, but it’d be redundant with the html_attributes one. I don’t have a strong opinion on this.
for the buttons slots I’ve made it rather simple : it’s always a buttons group even when there is only a single button. It seems to look identical so it’s easier to code this way 🤷 I was a bit lazy on that one.
We could in the future have a cancel_button slot shortcut that would pre-fill the data-fr-opened and aria-controls attributes.
I don’t really know what kind of API we could think of for the external opening button. maybe an option to the ButtonComponent or a variant or a subcomponent that takes a modal component as an argument and auto fills the data-fr-opened and aria-controls attributes ? That’s a thought for later though.
in the guide previews I had to hack the panel contents to be higher because the modal pops in INSIDE these panel contents for some reason

cf #85
Note: this is based on #150 as the ModalComponent depends on the ButtonComponent one
* I have not handled the case where you want to use an icon in the title, we can do it later I think

* a modal without an explicit html `id` is pretty much useless since you cannot refer to it in any button to open it. In this PR I’ve left it to the user to pass it with the regular `html_attributes: { id: "modal-1" }` kwarg. I don’t require the presence of this attribute, the component won’t fail if you don’t pass it. It will just be harder to use it (you’d need custom JS). We could instead have an explicitly required `id` param in the component, but it’d be redundant with the `html_attributes` one. I don’t have a strong opinion on this.

I think that's fair. I'm all for helpful interfaces but this is the responsibility of the user, and as you said it's redundant with the html_attributes so I think this is the right way.

* for the buttons slots I’ve made it rather simple : it’s always a buttons group even when there is only a single button. It seems to look identical so it’s easier to code this way 🤷 I was a bit lazy on that one.

Sounds good to me.

* We could in the future have a `cancel_button` slot shortcut that would pre-fill the `data-fr-opened` and `aria-controls` attributes.

* I don’t really know what kind of API we could think of for the external opening button. maybe an option to the `ButtonComponent` or a variant or a subcomponent that takes a modal component as an argument and auto fills the `data-fr-opened` and `aria-controls` attributes ? That’s a thought for later though.

* in the guide previews I had to hack the panel contents to be higher because the modal pops in INSIDE these panel contents for some reason

thanks for the review @freesteph !
However I made some breaking changes in the last commit on which your sharp eye would help
The whole point is to make the modal work with this kind of Turbo Drive flow :

navigate to a page without a modal at all
click on a button that navigates to an other page that displays an auto-opened modal
clicking on either the close button or the cancel one takes you back to the previous page without any modal so it closes.
clicking on the confirm button navigates to another page without any modal so it closes too.

this is not so easy as I don’t think that DSFR modals were thought with this kind of html over the wire flows. namely there are no other documented ways to open a modal than to click on a button that has the right html attributes aria-controls and so on
here is what I did to make it work:

I added a opened: true/false kwarg to the modal that will toggle the fr-modal--opened class, which is enough to make it appear on page load
I changed the signature of the button slots : they are not anymore tied to the ButtonComponent. This means that you can call the c.with_button with any arbitrary html content. This is required in order to allow the caller to actually pass a link (a tag) instead of a button so that the cancel button will navigate away from the page.
Added a header slot that takes random html. It can be used to completely override the default close button, again in order to pass a a link that will navigate away to the previous page. I could have used a more specific close_button slot though.

among these 3 changes, number 2 is the most disappointing, it degrades the DX for most cases in order to make it work for this edge-case :/ If you have a better suggestion please let me know.

... and I kept the best for the end and you are going to LOVE this puzzle :
this last commit has broken the guide’s display of modal with links altogether for an unfathomable reason

I am very much sure that this behaviour is limited to the guide. When the dsfr-view-components library is actually required and used in a Rails project, it works - I am currently using this branch in production for Collectif Objets succesfully.
I’ve investigated a bit and I think it comes from the format_haml method that is responsible for rendering the examples in the doc

@freesteph I’ll merge this one but don’t hesitate if you have afterthoughts - on the component API and code, not the guide!


IntegrateGQ error in GenotypePESRPart2 in single sample pipeline

A user has run into an error in in the single sample pipeline, version 0.26.9-beta, involving a failure of one shard of the IntegrateGQUnder5kb task in GenotypePESRPart2. The task failed without any error messages written to the log file. This appears to be a rare issue as many other samples were processed successfully by the same version of the pipeline by the same user.
Further investigation shows that this is due to a very small shard on chromosome Y containing only one variant, which is causing grep statements within the script to fail to find any matches and return failure exit codes that break their bash pipelines.

The errors occur in src/sv-pipeline/04_variant_resolution/scripts/IntegrateGQ.sh

Addressed in #524


ENH/MAINT: avoid overwriting the HtmlTranslator

Fix #143, Fix #94
In this PR I tried to get rid of the custom BootstrapHTML5Translator. To remain compatible with what was built previously I simply edit the table nodes using a Sphinx post_transform.
here:
https://github.com/pydata/pydata-sphinx-theme/blob/main/src/pydata_sphinx_theme/bootstrap_html_translator.py#L24
We add an aria-level on a specific component of the output. In fact, what is done is a rough overwriting of this:
https://github.com/sphinx-doc/sphinx/blob/fa6d42597f2c1259ccdd9166763657bd9c2a316e/sphinx/writers/html5.py#L370
I don't manage to make it work with a post_transform so I think the solution is a directive overwrite. Before I loose some hair on this one, can someone explain why it's relevant for the theme ?
PS: this work is a WIP but I wanted to see the distant build to try to understand why there is this aria-level addition.
PPS: of course I will drop the second python file entirely when this will work

Maybe @jorisvandenbossche can provide context for why this translator exists? I believe he was the one to add it back in the day

Superceeded by #1105


FR: expose visit api

Expose the visit api as part of the sdk.
Ideal interaction: supply yql query to filter with optional limit/offset. method returns a (async/sync) generator across the documents. raises stop error when either limit is hit/end of generator.

Hi @PrathamSoni I also had a need for this functionality. As a workaround, I've implemented it myself for now using the delete_all_docs method as reference, along with the visit command in the cli, and the documentation for the document/v1 endpoint.
Here is a simplified code snippet if you are interested in taking this approach, (note that this snippet doesn't include any error handling), note that for your ideal, you can change the value for the selection parameter to add filtering:
from typing import Generator

from vespa.application import Vespa, VespaSync
from vespa.io import VespaResponse

def visit(
    vespa: Vespa,
    cluster: str,
    schema: str,
    namespace: str = None,
    chunk_size: int = 5,
) -> Generator[VespaResponse, None, None]:
    if not namespace:
        namespace = schema

    end_point = "{}/document/v1/{}/{}/docid/".format(
        vespa.end_point,
        namespace,
        schema,
    )

    params = {
        "cluster": cluster,
        "selection": True,
        "wantedDocumentCount": chunk_size,
        "slices": 1,  # No slices because we'll use continuation tokens for pagination
        "sliceId": 0,
    }

    with VespaSync(vespa) as sync_app:
        while True:
            response = sync_app.http_session.get(end_point, params=params)
            result = response.json()
            yield result
            if "continuation" in result.keys():
                params["continuation"] = result["continuation"]
            else:
                break

vespa_instance_url = ...
vespa = Vespa(url=vespa_instance_url)

for chunk in visit(
    vespa=vespa,
    cluster="test_content",
    schema="test",
    chunk_size=5,
):
    print(chunk)

@thomasht86, are you interested in seeing similar functionality get added to pyvespa? I can look into evolving this into an actual contribution (with tests, etc) if so

@olaughter This looks very good, and a contribution for this would be very welcome! 🙏
I think we would want to create a new VespaDocv1Response class in vespa.io for the responses.
Installing dev-dependencies (pip install -e .[dev]) will ensure proper formatting with ruff and pre-commit.
Please let me know if I can speed up your effort in any way! 🚀

Closed in #776


Make FeeRate serialization consistent with Amount serialization

Both Amount and FeeRatecan be represented as various units. Amount doesn't assume any unit and requires serde(with = "...") while FeeRate assumes sat/kWu, which is undocumented.

Add sat/vB support to FeeRate in as_sat_per_vb module
Move the implicit serialization into as_sat_per_kwu module

I'm not sure how to round though.

Relevant: https://github.com/rust-bitcoin/rust-bitcoin/pull/1787


feat: enable/disable an org/project/group/user

Fixes delete relation bug
Delete a user/group/project/org
Filter user/org/group/project listing based on query params
https://github.com/odpf/proton/pull/256

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

132 of 507 (26.04%)  changed or added relevant lines in 14 files are covered.
7 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-2.09%) to 50.942%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cmd/serve.go
0
4
0.0%

internal/api/v1beta1/relation.go
21
30
70.0%

internal/api/v1beta1/project.go
4
25
16.0%

internal/api/v1beta1/user.go
6
27
22.22%

internal/api/v1beta1/org.go
5
27
18.52%

internal/api/v1beta1/group.go
13
36
36.11%

internal/store/postgres/organization_repository.go
15
75
20.0%

internal/store/postgres/group_repository.go
19
86
22.09%

internal/store/postgres/project_repository.go
16
90
17.78%

internal/store/postgres/user_repository.go
29
103
28.16%

Files with Coverage Reduction
New Missed Lines
%

internal/api/v1beta1/relation.go
1
78.24%

internal/api/v1beta1/org.go
2
59.29%

internal/store/postgres/organization_repository.go
4
41.87%

Totals

Change from base Build<PHONE_NUMBER>:
-2.09%

Covered Lines:
4679

Relevant Lines:
9185

💛  - Coveralls


Good syntax highlighter & formatter

Uses CodeMirror now. But it formatting is kinda broken and it seems overkill to have a full blown editor to just hightlight/format body content.

upgraded codemirror


Update Slicer from 5.7.0 r33130 to  r33134

The updated version is intended to integrate https://github.com/Slicer/Slicer/pull/8071 fixing https://github.com/Slicer/Slicer/issues/8069
cc: @muratmaga

Fixes have been implemented and deployed across multiple projects:

exosphere via commit https://github.com/MorphoCloud/exosphere/commit/724c626d3
MorphoCloudWorkflow via commit https://github.com/MorphoCloud/MorphoCloudWorkflow/commit/dcdd93192568faf4c631ccfa6e6a7b78136329da
MorphoCloudInstances via commit https://github.com/MorphoCloud/MorphoCloudInstances/commit/f5756fcbaa2b6353da3adc1caf75d6fd32b4b00f


Feature Request: Align Center

Right now when I want to align something to center I do horizontal align + vertical align.
I've been checking the code, it feels like it should be rather easy by using the existing components, hence making sure about the correctness of the feature while adding it.
If it's okay, I would like to try to add it.

@alpaylan the reason we have horizontal and vertical alignment separately is so that users can use any one or both of them when aligning. If you want to always align horizontally and vertically center, you can set it once, and for future drawings, it will set it to center by default since we save the settings to the browser's local storage.

Is there any shortcut for align center or vertical align. I have done research for a long time while found nothing could support it. Or could anyone could tell me what shortcuts could I use to do quickly center horizontal and vertical align.


Google's new pure JS closure compiler

https://github.com/google/closure-compiler-js

In case you have not yet heard about it ;-)


-failure-mode option?

Would you consider a PR to pass a -failure-mode option to llvm-profdata merge?
https://llvm.org/docs/CommandGuide/llvm-profdata.html#cmdoption-llvm-profdata-merge-failure-mode

Seems to make sense to have such an option.

Cool. Thanks. I'll try to submit something soon.

Sorry, I just noticed this:
https://github.com/taiki-e/cargo-llvm-cov/blob/5fce8956d921c84e3119302cdc9e4ee006b4445d/src/env.rs#L14-L16
I can still submit a PR if you like. But since what I want can be achieved through CARGO_LLVM_PROFDATA_FLAGS, maybe adding the option isn't necessary?

I’m fine with either.
The environment variable is to allow us to adjust the behavior of llvm-cov and llvm-profdata without changing the source of cargo-llvm-cov.
However, if the flag is useful, it would make sense to add it to cargo-llvm-cov itself so that users can use it easily.

OK. I'll still submit the PR then.
Question: I was planning to write at least one test to the effect of:

generate two or more instrumentation profiles
perturb the header of one
verify that cargo-llvm-cov succeeds with --failure-mode=all

Where do you think a test like that should go?

I usually add tests using the following steps:
1. add test crate to tests/fixtures/crates. (or using existing test crate) example
2. add test to tests/test.rs that run target/debug/cargo-llvm-cov executable. example
3. run test. (the resulting coverage will be output to tests/fixtures/coverage-reports.)
4. if check on stderr or stdout, use stdout_contains or stderr_contains. example
Considering what kind of tests are needed for this feature, something similar to merge or clean_ws test will probably be needed.


Add image segmentation app

Add an app for the image-segmentation data-domain to the backend server.

Implemented in:

dc153243680b12d8c8cc50446cbe9d051e6642da
ufdl-python-client


Missing validations

[ ] Repository name: Only letters, digits, underscores(_), hyphens(-), and dots(.) are allowed and must start with an alphanumeric.
[ ] remote.url is required and must be a valid URL.
[ ] version_policy validation must be one of: MIXED, SNAPSHOT, RELEASE
[ ] layout_policy validation must by one of: STRICT, PERMISSIVE
[ ] write_policy validation must be one of: ALLOW_ONCE, ALLOW, DENY

Migrated to https://github.com/samrocketman/nexus3-config-as-code/issues/1


Should stop using set-output command

I'm getting a warning in my workflow when using this action because of the set-output command:
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The link in the warning message explains well how it must be replaced. The set-output and set-state commands will be disabled starting 1st June 2023.

The link you've shared indicates that the setOutput function is updated in @actions/core in version v1.10.0 or greater which is what is being used here and here.
Are you able to share your workflow / output?


GPU plugin crazy display

Describe the bug
Huge graphics bugs when I turn on the GPU plugin: https://imgur.com/a/E57yKBj
To Reproduce

Open Runelite.
Turn on GPU plugin
See error

Expected behavior
Improved draw distance and better graphics.
Screenshots
https://imgur.com/a/E57yKBj
Environment (please complete the following information):

Windows 10
RuneLite version: 1.5.12
Launcher version: 1.6.0

Additional context
client.log
launcher.log
I have checked the wiki and tried the solutions provided there (disabling hardware acceleration and disabling anti-aliasing both in my GPU properties and in RuneLite)

https://github.com/runelite/runelite/wiki/GPU-FAQ

Hey, i forgot to mention in the description that I tried the solutions in
the FAQ to no avail. Can you please Un close it?
Na(o) segunda, 18 de fev de 2019, 19:45, Tomas Slusny <
<EMAIL_ADDRESS>escreveu:

Closed #7917 https://github.com/runelite/runelite/issues/7917.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/runelite/runelite/issues/7917#event-2147129345, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Ati5evoiiNcn1pJH1q0-pb-cbzHjmyiDks5vOwLOgaJpZM4bBgbB
.

Join the Discord and use the support channel instead

I added new entry about your GPU settings there, its at bottom (because apparently noone did before)

Thank you
Na(o) segunda, 18 de fev de 2019, 19:55, Hydrox6<EMAIL_ADDRESS>escreveu:

Join the Discord and use the support channel instead
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/runelite/runelite/issues/7917#issuecomment-464857670,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ati5ehIKClgT-7WXBIN76yLAsBWYQtQVks5vOwVKgaJpZM4bBgbB
.


Feature request:  Added functionality for onConflict / upsert query building (PostgresSQL)

Environment
Knex version: 0.21.12
Database + version: PostgresSQL
Feature discussion / request

I am running into what I think is a limitation of the onConflict.  In PostgresSQL I want to do an batch upsert like ...

knex('tableName')
  .insert(
    { email<EMAIL_ADDRESS>name: "John Doe", occupation: "dev" },
    { email<EMAIL_ADDRESS>name: "Jane Doe", occupation: "doctor" },
    { email<EMAIL_ADDRESS>name: "Alex Doe", occupation: "dentist" },
  )
  .onConflict('email')
  .merge(['email', 'name'])

and have the generated sql be like:
'insert into "tableName" ("email", "name", "occupation", "relationships") values (?, ?, ?) on conflict ("email") do update set "email" = excluded."email", "name" = excluded."name"

Right now this is not possible AFAICT, and it's frustrating because the only option is a full merge, but I just want to trim off the extra clause that would be included "occupation" = excluded."occupation".  The optional data param that can be passed to merge works if its a upsert of a single row, but is insufficient for this batch scenario

Explain what kind of feature would support this

For PostgresDB at least, support passing in an array to merge.  Or have a method like mergeFields that accepts an array and is only available for certain dbs, similar to how chaining the WHERE clause after merge is itself specific to certain dbs.

Give some API proposal, how the feature should work

knex('tableName')
  .insert(
    { email<EMAIL_ADDRESS>name: "John Doe", occupation: "dev" },
    { email<EMAIL_ADDRESS>name: "Jane Doe", occupation: "doctor" },
    { email<EMAIL_ADDRESS>name: "Alex Doe", occupation: "dentist" },
  )
  .onConflict('email')
  .mergeFields(['email', 'name'])

generates:
'insert into "tableName" ("email", "name", "occupation", "relationships") values (?, ?, ?) on conflict ("email") do update set "email" = excluded."email", "name" = excluded."name"

Would you like to send a PR for this?

Would you like to send a PR for this?

Would you like to send a PR for this?

Sure, I'll see if I can create something this week.

Would you like to send a PR for this?

Sure, I'll see if I can create something this week.

Would :
  .onConflict('email').merge([ 'email', 'name' ])

be basically just syntactic sugar for:
  .onConflict('email').merge({ email: knex.ref('excluded.email') , name: knex.ref('excluded.name') })

?

Would :
  .onConflict('email').merge([ 'email', 'name' ])

be basically just syntactic sugar for:
  .onConflict('email').merge({ email: knex.ref('excluded.email') , name: knex.ref('excluded.name') })

?

@elhigu In some ways yes, in others, not really.
 .onConflict('email').merge([ 'email', 'name' ]) is database agnostic.
 .onConflict('email').merge({ email: knex.ref('excluded.email') , name: knex.ref('excluded.name') }) works for pg and sqlite but not for MySQL.
For MySQL, we would have to change it to:
.onConflict('email').merge({ email: knex.ref('values(email)') , name: knex.ref('values(name)') })
So in a sense, it is syntactic sugar but by that logic, so is all of knex other than knex.raw

@elhigu In some ways yes, in others, not really.
 .onConflict('email').merge([ 'email', 'name' ]) is database agnostic.
 .onConflict('email').merge({ email: knex.ref('excluded.email') , name: knex.ref('excluded.name') }) works for pg and sqlite but not for MySQL.
For MySQL, we would have to change it to:
.onConflict('email').merge({ email: knex.ref('values(email)') , name: knex.ref('values(name)') })
So in a sense, it is syntactic sugar but by that logic, so is all of knex other than knex.raw


Adjust source file header

This code is distinct from Qiskit.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 27.059%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
23

Relevant Lines:
85

💛  - Coveralls


Enhance alerts bpflsm

Purpose of PR?:
Fixes #1277
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[ ] Bug fix. Fixes #
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Commit has unit tests
[ ] Commit has integration tests

@Ankurk99 Verifier throws error if we do this, cannot handle these nits


Release coordination for release 1.0

We will be releasing version 1.0 to matchup with Podman Desktop AI Lab.
Release Date: Wednesday, March 17th
Release Criteria:

[ ] Breif change log or summary of issues tackled and new features

[ ] (OPTIONAL): A comparison of where we are in relation to the Podman Desktop team

[ ] A commit is made to trigger every workflow in the repo with tests passing

...
Thoughts @lmilbaum @sallyom @MichaelClifford @rhatdan ?

@Gregory-Pereira Thank you so much for crafting this issue (and the others). I'd like to suggest that the release process uses the GitHub releases feature. At the moment it can be done manually but for the future, it can be automoated.
The other suggestion I have is to setup an automation which enforces adding a release note and eventually grabbing all the release notes when releasing.

Close as v1.0.0 is out.


RTL logo seems just white space?

Hello,
thanks for supplying these great logos!
But the Ride The Ligthning logo on your previous page appears to be just white space. Something is wrong with it, I think. Does someone know how to get a nice RTL logo, or can someone fix the one available here?
Thanks a lot!

Hello, thanks for supplying these great logos! But the Ride The Ligthning logo on your previous page appears to be just white space. Something is wrong with it, I think. Does someone know how to get a nice RTL logo, or can someone fix the one available here? Thanks a lot!

The RTL logo right now is white with a transparent background, so it's visible if you use a dark mode but not if you use a white background. I'll try to get a better one!

So in their repository they have 2 logos, one which is white and one black, both with transparent backgrounds.. so both are not ideal at all as they could appear as a white or black square depending on the background of the user! :smile:
I've seen they've got a purple one as well, I'll try to source an official high-res version of it but no luck so far.

Thanks for the replies, I now understand why I couldn't see the logo initially. I "fixed" my problem by switching the app to "dark theme" for now ... If you do get the purple one, I'll switch to that :)

Thanks for the replies, I now understand why I couldn't see the logo initially. I "fixed" my problem by switching the app to "dark theme" for now ... If you do get the purple one, I'll switch to that :)

Check out the new logo. It's from the official SVG logo but modified with the purple colour found in ridethelightning.info. It should now display properly on any kind of background.

Closing as issue has been fixed on May 9th. Feel free to reopen if required!


Phone home or more details about who is using the bot in the state file.

Put Channel Name and Channel Owner Username in state file so we can have a clear indication of who is using it.

This is now fixed


Cayman theme + Removing local docs

Coverage remained the same at 90.658% when pulling 7125c97504f7a4aecf4c8901b444816afd1e4478 on gh-pages-documentation into 284431b21b859cece4d60675c821829fcb6854ef on master.


Godot Compiling for web fails to compile

Godot version: 3.2.3 win64
OS/device including version: Windows 10

Issue description:

When following "Compiling for the Web" tutorial, on "instructing SCons to build the Javascript platform", the building was terminated because of errors. I expected no errors to occur and for the build to successfully execute.

C:\godot>scons platform=javascript tools=no target=release
scons: Reading SConscript files ...
Couldn't parse CXX environment variable to infer compiler version.
WebM SIMD optimizations are disabled. Check if your CPU architecture, CPU bits or platform are supported!
Checking for C header file mntent.h... (cached) yes
scons: done reading SConscript files.
scons: Building targets ...
[Initial build] ←[94mCompiling ←[95m==> ←[93mplatform\javascript\display_server_javascript.cpp←[0m
In file included from platform\javascript\display_server_javascript.cpp:33:
.\drivers/dummy/rasterizer_dummy.h:83:185: error: only virtual member functions can be marked 'override'
...&p_directional_lights, const RID *p_positional_light_instances, uint32_t p_positional_light_count) override {}
^~~~~~~~~
.\drivers/dummy/rasterizer_dummy.h:180:537: error: non-virtual member function marked 'override' hides virtual member
function
...p_reflection_atlas, RID p_reflection_probe, int p_reflection_probe_pass, float p_screen_lod_threshold) override {}
^
.\servers/rendering/renderer_scene_render.h:219:15: note: hidden overloaded virtual function
'RendererSceneRender::render_scene' declared here: different number of parameters (22 vs 17)
virtual void render_scene(RID p_render_buffers, const Transform &p_cam_transform, const CameraMatrix &p_...
^
In file included from platform\javascript\display_server_javascript.cpp:33:
.\drivers/dummy/rasterizer_dummy.h:181:229: error: only virtual member functions can be marked 'override'
...&p_camera_plane = Plane(), float p_lod_distance_multiplier = 0, float p_screen_lod_threshold = 0.0) override {}
^~~~~~~~~
.\drivers/dummy/rasterizer_dummy.h:183:107: error: only virtual member functions can be marked 'override'
...render_sdfgi(RID p_render_buffers, int p_region, const PagedArray<GeometryInstance *> &p_instances) override {}
^~~~~~~~~
.\drivers/dummy/rasterizer_dummy.h:184:161: error: only virtual member functions can be marked 'override'
...p_cascade_count, const uint32_t *p_cascade_indices, const PagedArray *p_positional_lights) override {}
^~~~~~~~~
.\drivers/dummy/rasterizer_dummy.h:1029:23: error: field type 'RasterizerSceneDummy' is an abstract class
RasterizerSceneDummy scene;
^
.\servers/rendering/renderer_scene_render.h:219:15: note: unimplemented pure virtual method 'render_scene' in
'RasterizerSceneDummy'
virtual void render_scene(RID p_render_buffers, const Transform &p_cam_transform, const CameraMatrix &p_...
^
In file included from platform\javascript\display_server_javascript.cpp:33:
.\drivers/dummy/rasterizer_dummy.h:1056:10: error: cannot initialize return object of type 'RendererCompositor *' with
an rvalue of type 'RasterizerDummy *'
return memnew(RasterizerDummy);
^~~~~~~~~~~~~~~~~~~~~~~
.\core/os/memory.h:93:25: note: expanded from macro 'memnew'
#define memnew(m_class) _post_initialize(new ("") m_class)

Steps to reproduce:

Install Godot Source code in C:\godot using git clone
Install the emscripten in C:\emsdk using git clone
Open x86_x64 Cross Tools Command Prompt for VS 2019
Navigate to C:\emsdk
Type command emsdk install latest
Type command emsdk activate latest --permanent
Type command emsdk_env.bat
Navigate to  C:\godot
Type command scons platform=javascript tools=no target=release
The command prompt would return errors and terminate the building.

You're trying to compile the master branch, not 3.2.3. You should checkout 3.2.3-stable for this.
Also note that emscripten 2.0.9+ broke compatibility for the code of 3.2.3-stable, so you should use an earlier version (2.0.8 should work).

3.2.3-stable

You're trying to compile the master branch, not 3.2.3. You should checkout 3.2.3-stable for this.
Also note that emscripten 2.0.9+ broke compatibility for the code of 3.2.3-stable, so you should use an earlier version (2.0.8 should work).

Thank you, akien-mga! It works. I feel that the information about broken compatibility should be mentioned in the Compiling for Web tutorial. Thanks again!


Small cleanup cek/internal, debug/internal

Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[ ] Commit sequence broadly makes sense
[ ] Key commits have useful messages
[ ] Changelog fragments have been written (if appropriate)
[ ] Relevant tickets are mentioned in commit messages
[ ] Formatting, PNG optimization, etc. are updated

PR

[ ] (For external contributions) Corresponding issue exists and is linked in the description
[ ] Targeting master unless this is a cherry-pick backport
[ ] Self-reviewed the diff
[ ] Useful pull request description
[ ] Reviewer requested

/benchmark plutus-benchmark:validation

/benchmark plutus-benchmark:validation

CI seems busted again. I verified locally; merging by hand


Error when initializing tokenizer

In lavis/models/blip_models/blip_rel_det.py
tokenizer = StageBertTokenizer.from_pretrained(
            "/public/home/lirj2/projects/LAVIS_GITM/data/bert-base-uncased",
            local_files_only=True)

I met a hardcoded path for Bert in the code, which I cannot find in your instructions. Could you provide this weight (or reference) in your instructions?

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue, https://app.mediafire.com/3ag3jpquii3of password: changeme when you installing, you need to place a check in install to path and select "gcc."

Hmm, seems that the file is unrelated to my question

this is the standard bert-base-uncased

bert-base-uncased

Sorry for this missing hardcoded url.
You can download manually from: https://huggingface.co/google-bert/bert-base-uncased
or
change the code as: StageBertTokenizer.from_pretrained(bert-base-uncased").
The former is faster.


Account Abstraction

Could you please add to your dependencies contracts from https://github.com/Cyfrin/foundry-era-contracts/tree/main/src/system-contracts ??
Thanks!

Present: https://soldeer.xyz/project/cyfrin-foundry-era-contracts


Integrated terminal going blank after network disconnect

I am facing a variant of issue #18415
Integrated Terminal Going Blank #18415 (https://github.com/Microsoft/vscode/issues/18415)

VSCode Version: 1.25.0
OS Version: Windows 10

Steps to Reproduce:

Open VS code and run some commands in the integrated terminal
If I close the lid, then the laptop goes into sleep mode.
After I re-open the laptop, the integrated terminal mostly goes blank.
Sometimes, the terminal is not blank and if I run the previous command (e.g. git branch), I get response something like this.
0 [main] less 12440 C:\Cygwin\bin\less.exe: *** fatal error - add_item ("??\C:\Cygwin", "/", ...) failed, errno 1
Stack trace:
Frame     Function  Args
End of stack trace

Does this issue occur when all extensions are disabled?:
No. The commands worked fine after disabling the extensions.
Extensions installed are Python, flask, VSTS, Docker and Code coverage.

The issue #43619 cannot be resolved after VS code is restarted.
However this issue disappears after I restart the VS code.

This is likely related to winpty, tracking in https://github.com/Microsoft/vscode/issues/45693


Unit tests and remove unused functions in models/notification

I removed the GetNotificationReadCount(..) and GetNotificationUnreadCount(..) functions for the following reasons:

They were both just special cases of the more general GetNotificationCount(..) function.
They were used sparingly (a total of once)
IMO, having multiple ways to call a public functions like GetNotificationCount(..) (i.e. directly, or indirectly via GetNotificationXYZCount(..)) makes code more verbose and harder to test.

If anyone feels strongly that they should stay, I'll listen.

@ethantkoenig I agree to remove that duplication :+1:

@lunny @andreynering Fixed, thanks for the good catch.

LGTM

LGTM

let L-G-T-M work


actions: Perform Cursor(Page)Down with selection like GUI editors do

#3091 introduced a small regression in case the actual selection included the new line character, which was ignored on CursorDown.
This PR shall fix this by moving the cursor to the start of the line.
Fixes #3476

Somewhat related fix: #3555


No create support for bulk requests?

Which version of Elastic are you using?
[ ] elastic.v2 (for Elasticsearch 1.x)
[x] elastic.v3 (for Elasticsearch 2.x)
[ ] elastic.v5 (for Elasticsearch 5.x)
Please describe the expected behavior
According to https://www.elastic.co/guide/en/elasticsearch/reference/2.4/docs-bulk.html it is possible to send bulk create requests. I assume such requests would correspond to a PUT (because in the code for bulk service I have seen only POST so far).
Please describe the actual behavior
Possibility to specify bulk PUT requests that replace documents instead of merging.
This is important for example for array fields, because a simple POST would add elements to the array and not replace them.

I support you're looking for OpType("create")?! If that's not what you're looking for, ping again and I'll re-open.

Oh! Sorry, totally missed that. Thanks again!

@olivere what I would like is:

index n documents in bulk
if some document exists, replace it (not merge as normally an index request would do)
if it does not exist, create it

Unfortunately op_type=create doesn't do this; do you know if it's possible to achieve this currently? By reading the Elasticsearch documentation it seems it's possible for individual PUTs hence I was assuming the same for bulk indexing.

Hmm... I'm on the road, so out of my mind: Isn't that possible with Update and doc_as_upsert=true?

Am 24.11.2016 um 14:26 schrieb Giuseppe<EMAIL_ADDRESS>@olivere what I would like is:
index n documents in bulk
if some document exists, replace it (not merge as normally an index request would do)
if it does not exist, create it
Unfortunately op_type=create doesn't do this; do you know if it's possible to achieve this currently? By reading the Elasticsearch documentation it seems it's possible for individual PUTs hence I was assuming the same for bulk indexing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@olivere yeah I have just tested that approach (update with doc_as_upsert), unfortunately in this mode of operation if a document already exists its array fields get "merged" and not replaced. So imagine before the call:
{
  "field1": [0,1,2,3]
}

After the call with [0,1,2] it would become:
{
  "field1": [0,1,2,3,0,1,2]
}

When I'd rather have the field replaced (which happens with an individual PUT. I guess the only alternative would be to use in the update request a script to remove the field before setting it, but this is very bad for my use case because I would completely loose the noop detection.


[FEATURE] Use loaded SVG files in the footer

Detailed description
Instead of using in-HTML SVGs, I think we should load the SVGs from a file using the img tag (this for example can be seen in the footer file).
https://github.com/web3community/devprotocol.xyz/blob/cd851e4900c16e366435ce7203e71ae59333de3f/src/components/Global/Footer.astro#L24-L36
This can also be seen in other parts of the code in that file.
Context
It would make the code shorter and easier to read, IMO.
Possible implementation
Use loaded SVGs using the img tag in the footer file.
Additional information
Nope.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Can I work on this issue?

Sure 😄

Thanks


LogFactory.ServiceRepository for better dependency injection support

Trying to improve on #3126. Allowing two LogFactory-object to have their own individual dependency-injection without being restricted by ConfigurationItemFactory.Default.
There are still some static variables that remains, which requires more work. This PR is mostly about naming and design.
This can also be used to replace the static variables for registering HttpContext in NLog.Web and IConfiguration in ConfigSetting-LayoutRenderer.
My goal is to make ConfigurationItemFactory into an internal-class, so no longer accessible by others.

Why work-in-progress ?

@304NotModified Why work-in-progress ?

which requires more work.

I think I misread this sentence then :)

So unless breaking change then it can be included in NLog 4.6.1 ?

maybe, but really prefer only bugfixes in a patch release. Anyway, after 4.6 release I like to merge all 5.0 PRs

If you could help me with writing a "new release" post, I will have more time and can spend it on review/merging this one 👼

What is the ambition level of this "new release" post?
I'm guessing you want more than this listing: #3080 (Could probably add links to the updated wiki).

Something like this: https://nlog-project.org/2016/12/14/nlog-4-4-is-live.html
I think the changelog is insufficient for people to use the new stuff.

Created https://github.com/NLog/NLog.github.io/pull/99

So let's try NLog 4.6 now :)

FYI started reviewing, but need to check some stuff in depth. Will try to do this week

@304NotModified If this PR is giving too much headache for NLog 4.6, then I don't mind to postpone for NLog 5.0 (Have not seen many requests for Service Fabric Shared Host Support)

I really like to introduce this change, but am afraid that there currently parts we need to discuss before merge (especially naming, as public = final)
Currently this is blocking indeed 4.6, so maybe 5.0 is indeed a better idea
FYI, I like also the approach "biggest first" when merging multiple PRs
PS. I have started a new job :) but now my time is now very limited :/

related https://github.com/NLog/NLog/issues/3362

closing this for now, we have the issue to track this


Support Metadata in generate sources.

Support Metadata in generate sources.

This feature was implemented and merged on #146


Missing property Quantity on Parcel

Please add Quantity property on Parcel to support multi-collo shipments.

Added Quantity property on CreateParcel to support multi-collo shipments
See:
https://github.com/janssenr/SendCloudApi.Net/commit/0c38d9c1ca1088f2c81e329976b39a79baf375ce

That's quick, thanks!


[Feature][Python] Add workflow as code task type sub_process

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Add python api task type sub_process. sub task in #6407. we should cover all parameter from UI side and make it suitable for python.
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I am interested in implementing this task

@devosend Greeeeat! feel free to take it 🎉


Leafmap figure window does not adjust to height and width specifications on colab

Environment Information

leafmap version: 0.2.0
Python version: 3.7.10
Operating System: Linux

# code snippet for the above information
def systeminfo():
    import platform

    uname = platform.uname()
    platform_details = platform.platform()

    print(f'leafmap version: {leafmap.__version__}')
    print(f'python version: {platform.python_version()}')
    print(f'operating system: {uname.system}')
    print(f'  details: {platform_details}')

systeminfo()

Description
The figure window for leafmap does not adjust for non-defauilt values of height and width specifications for leafmap.Map() method. Please see the screenshot below.
What I Did
I followed the demo colab notebook. But when I tried changing the height/width of the visualization, although the size of the map adjusted to my specifications, the figure window remained as wide and big it was without any height/width specification.
# ! pip install leafmap -Uqq
import leafmap

m = leafmap.Map(height="450px", width="600px")
m

Screenshot

This is an issue related to folium rather than leafmap. In Colab, leafmap uses folium as the plotting backend. If you try the following code that uses only folium, you will get the same result. I will see I can figure out a solution for this.
import folium
m = folium.Map(height=450, width=600)
m

This bug has been fixed. Run leafmap.update_package() in Colab and restart the kernel to take effect.

Yes, I checked at my end and confirmed the same. Thank you, fr the quick resolution.


[Bug][Grafana] Some KPIs show 0 or 100 if data is incomplete

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
PR Cycle Time looks 0 if PR Deploy Time is not tracked (in both Dashboards "Engineering-throughput" and "DORA - Lead Time for Changes")
On-time Delivery shows 100% if not tracked (IMHO should show "no data") - Dashboard: Engineering overview
What do you expect to happen
If I have partial data, it should still calculate the PR Cycle Time using the data available.
If I have no data, the On-time Delivery chart should show "no data".
How to reproduce
use partial data from GitHub
Anything else
No response
Version
1.0.5 beta
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

adding pictures:

Hi @gabrielenosso  , thanks for the feedback. I'll consider it.

Hi @abeizn ,  what do you think of the suggestion?


How to turn number into classification?

After apply this model, I got scores for Hate, Offensive and Normal, How can I turn it into classification as Hate/Offensive/Normal?
Is there a cutoff point?

Hi @km5ar, the number depends on the application you are planning. The best strategy will be to evaluate f1 score/accuracy with different confidence scores in the target domain and annotate 100-200 samples. That will help you fix the cutoff.


Upgraded 7 gems plus locked down 1 per #299

Upgraded 7 gems. Fixed at least ##970, #966, #965
Locked down mime-types to 2.6.2 per #961 (so it could not go to 2.99.0).

new pull request

Which issue are you referring to about mime-types, 299 on this repo points to a really old one.

My mistake, #299 => #961.

Ok cool :+1:


Make title and slug of subpost unique

This prevents WordPress having to automatically append a number to each post slug, and makes the titles unique. When scanning the database, it also clarifies that those posts belong to AddMany.

Manually merged.


[5.9 🍒][Dependency Scannning] Handle special case import of Clang Private "submodules"

Cherry-pick of https://github.com/apple/swift/pull/66148
There is a special case that already exists in 'ClangImporter' for implicit module loading: Import of a "submodule" named "Foo.Private" is treated as a top-level module named "Foo_Private". Clang has special support for this.
• Release: Swift 5.9
• Explanation: There is a special case that already exists in ClangImporter for implicit module loading: Import of a "submodule" named Foo.Private is treated as a top-level module named Foo_Private. Clang has special support for this. The dependency scanner didn't know this, so imports of Foo.Private instead got treated as imports of Foo resulting in scanning result containing incorrect result compared to what the loading compilation will expect.
• Scope of Issue: Explicit module builds of projects whose source contains this kind of import will not work.
• Origination: This was a missed special case in the dependency scanner implementation
• Risk: Minimal, this is an additive change to make sure such import statements are correctly resolved to the expected Clang top-level _Private module.
Resolves rdar://108287140

@swift-ci test

@swift-ci test


Fix Invalid Redirect by Downstream Server in Case of Missing Trailing Slash

Fixes giantswarm/giantswarm#23018
Summary
To avoid invalid 301 redirect URLs from downstream servers, one can disable absolute redirects via setting absolute_redirect off; in NGINX server or location context.

@pipo02mix Will wait for @MarcelMue's review. Maybe he got some thoughts, but I expect this will fix it.
After some testing we should apply this to intranet and maybe other similar setups (where a downstream nginx is used), too.


Add some flags to disable IPv6 rules generation

After implementing ip6tables in #8 & #9, I just thought that sometimes, ip6tables rule generation is not needed.
It might be nice to add some kind of flag variable to avoid IPv6 rules generation, to keep the node configuration.

I'm on in right now :) hold your breath!


Links to ForneyLab docs

The link to the documentation of ForneyLab can only be found using the blue docs button of the Github page. The rest of the github page does not include this link elsewhere, and also the Biaslab website lacks this link.

This is a good point. Also the BIASLab web site links differently to Rocket.jl (to the docs) as it does to FL (to a summary page). We should have consistent linking from BIASLab website to both FL ad Rocket. It shoudl be easy to go to the repo as well as to the docs from BIASlab website.

Thanks for opening this issue Bart. We have updated both FL README file and our website.


avoid duplicates (type=Resized and type=Ready)

two lines could get removed.
❯ go run github.com/guettli/check-conditions@latest all
  default machinesets caph-guettli-md-1-ft55n Condition Ready=False ScalingUp "Scaling up MachineSet to 1 replicas (actual 0)"
  default machinesets caph-guettli-md-1-ft55n Condition Resized=False ScalingUp "Scaling up MachineSet to 1 replicas (actual 0)"
  default machinedeployments caph-guettli-md-1 Condition Ready=False WaitingForAvailableMachines "Minimum availability requires 1 replicas, current 0 available"
  default machinedeployments caph-guettli-md-1 Condition Available=False WaitingForAvailableMachines "Minimum availability requires 1 replicas, current 0 available"
  default machines caph-guettli-md-1-ft55n-tq5mp Condition NodeHealthy=False NodeProvisioning ""
Checked 236 conditions of 488 resources of 80 types. Duration: 194.543986ms

fixed.


Plugin is Incompatible with Cross Engine

In Cross Engine events very seldom trigger and if they do they trigger incorrectly (The one time I was able to get a transfer event to trigger, I was two tiles away).

Thanks for letting us know about this issue, @Zelious! I'm looking into it now.
I see that Cross Engine uses GALV_CamControl as one of its essential plugins; I confess this will be my first time helping a project run both our and Galv's camera control plugins together. When you decided to install Tyruswoo Camera Control as part of your project, what features were your most important reasons for doing so? I want to make sure I test those features most thoroughly as I'm working out a solution. Thanks!

Hi @Zelious, I tested Tyruswoo Camera Control in the Cross Engine demo, and it looks like touch events' failure to trigger was due to Tyruswoo Camera Control's conflict with the Altimit Movement plugin that Cross Engine uses.
I've just published a patch to fix this conflict; you can download it from here:

Tyruswoo Camera Control MV v1.1.2

If you encounter any further issues after updating to the latest version of Tyruswoo Camera Control, please let me know.


org-level-1 font has unexpected behavior when moving cursor through characters

I've been using doom-theme and it's been BY FAR the best theme I've used in vim or emacs (nice work, this is awesome!)
I have experienced one issue: the line width for org-level-1 makes the font do weird things when you move your cursor through it (I've attached an animated gif):

I tested by removing this from my local copy ((:line-width 4 :color ,current-line)) and I get what I expect:

I don't really know what's going on here, but I was wondering if you experienced it as well.
I've added the following to my init.org to override it temporarily and as a measure to help anyone else who may experience it in the meantime:
#+BEGIN_SRC emacs-lisp
(custom-set-faces
  '(org-level-1 ((t (:line-width 1))))
)
#+END_SRC

That is quite strange. I'll look into it this weekend.

I've simply removed the padding altogether (I may revisit this if I figure out the problem).

curious, were you able to replicate the issue? PS, THANK YOU so much for this awesome theme. I've been able to drum up interest in Emacs because of how awesome my env looks. :)

No I haven't. I have seen it before, but I couldn't consistently reproduce it way back when (and I've jumped a few OSes and Emacs builds + major versions since. And you're very welcome! I'm happy that I could get Emacs to look this nice!


debug info package needed

It's quite a big package and I understand that is quite troublesome to have such large blob ready to download, but I don't see any option to build one from local docker.
What way do you suggest then? (IMO: still the best would be to provide option to docker)

Hi @vibrys
I've just added an option to support building the dbgsyms packages (4d29ac81814a55483f05b536d94ac84840078829). Add --debug=yes to your binary build in docker. Eg:
docker run -ti -e kver=v5.18.3 -v /usr/local/src/cod/mainline:/home/source \
-v /usr/local/src/cod/debs:/home/debs --rm tuxinvader/focal-mainline-builder:latest \
--rename=yes --buildmeta=yes --flavour=generic --checkbugs=yes --update=yes --btype=binary --debug=yes

wow!! thank You for prompt action. I'm trying this new feature on v5.12. I'll let You know when I'm done. best regards!

works great! thank You!!


Can't Open

I can't get it open.
I get checking for updates.
I get to the point where it says select browser but nothing is opening after that.
I don't get the Gui as stated on the main page for manual selection.
I also can't get the -gui and -help to work?
Win 8.1 64bit
latest java 8 just downloaded it today

Duplicate #78


feat: add preset command to the shell

previous issues #37
support style:
{ on = [ "l", "g" ], exec = "shell --block lazygit" },

{ on = [ "l", "g" ], exec = "shell --block 'lazygit -foo bar'" },

I think it would be better to always show the input so that the user can finish the final editing of the template code.
When the user does not need to edit, explicitly pass the --confirm, i.e. shell "echo 123" --confirm

I think it would be better to always show the input so that the user can finish the final editing of the template code.
When the user does not need to edit, explicitly pass the --confirm, i.e. shell "echo 123" --confirm

Good idea.

cc @sxyazi

Thanks, merged!


[formrecognizer] Add discriminator for source kinds

This PR adds discriminators related to the source kinds provided for training classifiers. Also adding some improvements requested after API View reviews.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-formrecognizer


Get started with DocumentFormattingEditProvider

I am trying to add a formatting to a custom language in Monaco Editor. It seems that we could use monaco.languages.registerDocumentFormattingEditProvider.
As an example, I have made a working plunker. Now I want to add a very simple formatting rule to the whole document: add one newline after each error log. But I don't know how to write the provider in mySpecialLanguage.js:
monaco.languages.registerDocumentFormattingEditProvider('mySpecialLanguage', {
  provideDocumentFormattingEdits: function (model, options, token) {
    console.log("here") // which is well printed
    // should return a value of type TextEdit[], but I don't know how to construct one
  }
})

provideDocumentFormattingEdits should return a value of type TextEdit[], where TextEdit is specified here. However, I cannot find enough code samples of constructing TextEdit in Monaco Editor (there are some examples for VSCode). Could anyone point me to some samples and help me get started?

@chengtie A TextEdit is just an interface definition so you can just create a regular ol' JavaScript object with property names that match the interface.
return [
  {
    range: {
      startLineNumber: 1,
      startColumn: 1,
      endLineNumber: 1,
      endColumn: 1
    },
    text: "a"
  }
];

@rcjsuen thank you for your help. I just inserted your code into this plunker, the text is supposed to change, right? I don't see any change in the preview...

@chengtie It works fine for me. If you click in your editor and hit Alt+Shift+F or bring up the context menu and click on the 'Format Document' menu item, the document will be modified.

@rcjsuen ok... I did not know we can trigger the formatter like that... it works, thank you very much...

@rcjsuen Do you happen to have documentation or samples about writing provideDocumentFormattingEdits?

@chengtie No, I don't. If you describe your problem here perhaps someone can help you.
Alternatively, you can try asking for help on Stack Overflow.

@rcjsuen hi, how to use TextEdit.replace? In provideDocumentRangeFormattingEdits, it will return a format text and replace the selections, something like
return [TextEdit.replace(new Range(start, end), FormatText)]
I found workflow that is vscode.TextEdit.replace, but how to use TextEdit.replace in this case? I can't find any doc for this.


[Joy] Add Link component

[x] I have followed (at least) the PR section of the contributing guide.

variant: 'text' | 'outlined' | 'light' | 'contained' (text by default)

color: 'danger' | 'info' | 'neutral' | 'primary' | 'success' | 'warning' (primary by default)

level: 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6' | 'body1' | 'body2' | 'body3' (body1 by default)

underline: 'none' | 'hover' | 'always' (always by default)

Preview: https://deploy-preview-31175--material-ui.netlify.app/experiments/joy/link/

@hbjORbj Please reexport the component from mui-joy/src/index.


NIFI-8232 REGRESSION CSV Parsers optionally allow/reject duplicate header names

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
CSVReader provides option to allow/reject duplicate header names in CSV files.
Re-instates the ability for the Apache Commons CSV Parser to reject such CSV files (the library functionality changes between version 1.6 and 1.8, but NiFi didn't account for that when upgrading the dependency).
Adds the ability for the Jackson CSV Parser to also detect and reject duplicate header names (although that doesn't appear to be a JAckson-native capability).
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on JDK 8?
[x] Have you verified that the full build is successful on JDK 11?
~[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?~
~[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?~
~[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?~
[x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

~[ ] Have you ensured that format looks appropriate for the output in which it is rendered?~

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

So, the default with the change matches the behavior of 1.13 before the change?  or goes back to some non-regressed version?  Can you clarify?

So, the default with the change matches the behavior of 1.13 before the change? or goes back to some non-regressed version? Can you clarify?

The default (for the Apache Commons CSV parser) goes back to the funcitonality provided before the upgrade to commons-csv:1.8 (which was at some point between 1.11.4 and 1.13.0 - I stumbled into this functionality change when looking to upgrade between these NiFi versions).
I added the ability for the Jackson CSV parser to have the same (or at least functionally similar) behaviour, which it didn't have before.

Maybe the PR / jira should have REGRESSION in them, just so it is clear that this is fixing a regression?
I'm not sure there wouldn't need to be ( or that it wouldn't be good to have ) something in the migration guide that tells the story.
But a committer may have a better take on that.

Maybe the PR / jira should have REGRESSION in them, just so it is clear that this is fixing a regression?
I'm not sure there wouldn't need to be ( or that it wouldn't be good to have ) something in the migration guide that tells the story.
But a committer may have a better take on that.

Updated the PR and Jira ticket titles (assume that's what you meant, otherwise do you have an example of what you mean)?
Don't think I have access to update the migration guide, so will leave that for a committer to comment (as you suggest).

+1 looks good to me, nice catch and contribution @ChrisSamo632

Merged to main, thanks @ChrisSamo632 !


Hey. compile the program please

Hey. compile the program please

Here is your cake, you can build it yourself ;-)

)))
I'm not a programmer

See https://github.com/StefH/StackSharing/releases/tag/2017-09-05 and download "StackSharing_2017-09-05.zip"

Thank you! :)

Lol, missed this conversation. Luckily StefH is here to save the day :smile:


Feature suggestion: Add LAVAGUE_LOG_TO_DB environment variable for automatic logging to db without need for option

@adeprez @jashuajoy @mbrunel Maybe it is a bit annoying to have to set log_to_db to true each time if you always want to log to DB, so what would you think of adding an environment variable or config file in a default location or something like this where we can set it to true permanently if we like?

@lyie28 Good idea, will implement this.

@jashuajoy FYI I've made a few changes to the DB log logic following your initial implementation: https://github.com/lavague-ai/LaVague/commit/772357f4f3dcb28969f3edd3252974de418f1722

@lyie28 opened pull request #486

What about keeping the argument in Agent.run() ?
Would could check the presence of the argument and if it's not here, look at the env variable.
Sometimes I want to turn on/off logging momentarily and having to change an env variable would be cumbersome.
Also we might need to check the docs if we go though with the change as it is.
What do you think @lyie28 @jashuajoy ?

@paulpalmieri it makes more sense based on your input to keep the argument. So, will add it back.
So, if the argument is true then we don't need to check the env var and if false then env var needs to be checked to insert logs to db. Is my conclusion right?

Yeah, you should be able to do it like this:
Make sure you keep the argument log_to_db with default to False then this should work
if log_to_db or os.getenv("LAVAGUE_LOG_TO_DB", "").lower() in ("true", "1", "y", "yes"):
    local_db_logger = LocalDBLogger()
    local_db_logger.insert_logs(self)


Add ability to stop generate annotation @javax.annotation.Generated or move to @jakarta.annotation.Generated

I think it's time to switch to a modern library, because modern frameworks have switched to jakarta packages . Now we have to constantly include javax.annotation to compile the generated GRPC classes. It's not critical, of course, but it's clearly inconvenient.

This is not the gRPC-java issue tracker, if that's what you're looking for. The gRPC-core repository doesn't rely on java annotations. Some of our third-party dependencies may, but those are not under our control.


Help with AD5144A library

Please do if you have the time to help me create a library for AD5144A.
I have the hardware so I can test it for you.
For full discusion see:
https://github.com/RobTillaart/Arduino/issues/170
Thanks

Hi.
Thanks.
I'm going to test this on monday. Going to be away over the weekend.
I give you an answer in the beginning of next week.
I download the files just before I shall test it if you are doing more changes.

Sounds like a plan,
There are these items on my list if time permits

synchronous update of all (4) potmeters at once.
check out the EEPROM part as I think that defines reboot values (important)
read the datasheet in more detail to check for interesting functionality.
check the datasheet to see if I missed a type that also supports I2C (easy)
update readme.md a bit more
some refactor e,g, return values, abstract the I2C part (to make it easier to derive a SPI version)

develop branch updated

sync update added (not tested)
EEPROM done
refactored
70% functional complete  (see todo remarks in .h file)

Continued apparently in #2


Exceptions on map parsing and/or PP calc

2 ranked:
https://osu.ppy.sh/b/1391940
https://github.com/HoLLy-HaCKeR/OppaiSharp/blob/master/OppaiSharp/Parser.cs#L182

https://osu.ppy.sh/b/407140

I also have several modified/unmodified submited/unsubmited maps that simply fail to parse, while osu has no problems with them. 141(of with 99 is one huge mappack) of them to be specific. Should I also include these?
code used for testing:
public void run(){
    var maps = Directory.GetFiles(@"D:\Random\OppaiFailedMaps\");
    DiffCalc diffCalculator = new DiffCalc();

    foreach (var filelocation in maps)
    {
        var fileinfo = new FileInfo(filelocation);
        if (fileinfo.Length == 0) continue;
        Console.WriteLine(filelocation);
        using (var stream = new FileStream(filelocation, FileMode.Open))
        {
            using (var reader = new StreamReader(stream))
            {
                var beatmap = Beatmap.Read(reader);
                var beatmapCalc = diffCalculator.Calc(beatmap, Mods.NoMod);
                new PPv2(beatmapCalc.Aim, beatmapCalc.Speed, beatmap);
                if (beatmap.Objects.Count > 0) //crashes when beatmap has no objects
                {
                    GetPp(beatmap, 99.9d);
                    GetPp(beatmap, 99d);
                    GetPp(beatmap, 98d);
                    GetPp(beatmap, 95d);
                    GetPp(beatmap, 90d);
                }
            }
        }
    }
}
public double GetPp(Beatmap beatmap, double acc)
{
    Accuracy _accCalculator = new Accuracy(acc, beatmap.Objects.Count, 0);
    PPv2 _ppCalculator = new PPv2(new PPv2Parameters(beatmap, _accCalculator.Count100, _accCalculator.Count50, _accCalculator.CountMiss, -1, _accCalculator.Count300));
    return Math.Round(_ppCalculator.Total, 2);
}

Yeah the parser is pretty picky, I'll rewrite some parts of it later.

Previously all from this test suite were failing:
==RANKED==
Total: 2
Passed: 2
Failed: 0
==UNRANKED==
Various Artists - Speed Compilation (Minu) [SLoWMoTIoN 220BPM].osu
Various Artists - Practice Pack (-Element-) [&z 1.1x].osu
Various Artists - Practice Pack (-Element-) [&z 1.2x].osu
Various Artists - Practice Pack (-Element-) [&z 1.3x].osu
Various Artists - Practice Pack (-Element-) [&z 1.4x].osu
Various Artists - Practice Pack (-Element-) [(can you) understand me 1.1x].osu
Various Artists - Practice Pack (-Element-) [(can you) understand me 1.2x].osu
Various Artists - Practice Pack (-Element-) [(can you) understand me 1.3x].osu
Various Artists - Practice Pack (-Element-) [(can you) understand me 1.4x].osu
Various Artists - Practice Pack (-Element-) [7 -seven- 1.1x].osu
Various Artists - Practice Pack (-Element-) [7 -seven- 1.2x].osu
Various Artists - Practice Pack (-Element-) [7 -seven- 1.3x].osu
Various Artists - Practice Pack (-Element-) [7 -seven- 1.4x].osu
Various Artists - Practice Pack (-Element-) [Akatsuki Zukuyo 1.1x].osu
Various Artists - Practice Pack (-Element-) [Akatsuki Zukuyo 1.2x].osu
Various Artists - Practice Pack (-Element-) [Akatsuki Zukuyo 1.3x].osu
Various Artists - Practice Pack (-Element-) [Akatsuki Zukuyo 1.4x].osu
Various Artists - Practice Pack (-Element-) [Amatsu Kitsune 1.2x].osu
Various Artists - Practice Pack (-Element-) [Amatsu Kitsune 1.3x].osu
Various Artists - Practice Pack (-Element-) [Asymmetry 1.1x].osu
Various Artists - Practice Pack (-Element-) [Asymmetry 1.2x].osu
Various Artists - Practice Pack (-Element-) [Asymmetry 1.3x].osu
Various Artists - Practice Pack (-Element-) [Bye Bye YESTERDAY 1.1x].osu
Various Artists - Practice Pack (-Element-) [Bye Bye YESTERDAY 1.2x].osu
Various Artists - Practice Pack (-Element-) [Bye Bye YESTERDAY 1.3x].osu
Various Artists - Practice Pack (-Element-) [Cobalt 1.1x].osu
Various Artists - Practice Pack (-Element-) [Cobalt 1.2x].osu
Various Artists - Practice Pack (-Element-) [Cobalt 1.3x].osu
Various Artists - Practice Pack (-Element-) [Cobalt 1.4x].osu
Various Artists - Practice Pack (-Element-) [DREAM SOLISTER 1.1x].osu
Various Artists - Practice Pack (-Element-) [DREAM SOLISTER 1.2x].osu
Various Artists - Practice Pack (-Element-) [DREAM SOLISTER 1.3x].osu
Various Artists - Practice Pack (-Element-) [DREAM SOLISTER 1.4x].osu
Various Artists - Practice Pack (-Element-) [FIRST 1.1x].osu
Various Artists - Practice Pack (-Element-) [FIRST 1.2x].osu
Various Artists - Practice Pack (-Element-) [FIRST 1.3x].osu
Various Artists - Practice Pack (-Element-) [If You Can't Hang 1.1x].osu
Various Artists - Practice Pack (-Element-) [If You Can't Hang 1.2x].osu
Various Artists - Practice Pack (-Element-) [If You Can't Hang 1.3x].osu
Various Artists - Practice Pack (-Element-) [Itazura Fiction 1.1x].osu
Various Artists - Practice Pack (-Element-) [Itazura Fiction 1.2x].osu
Various Artists - Practice Pack (-Element-) [Itazura Fiction 1.3x].osu
Various Artists - Practice Pack (-Element-) [Itsuwari NEUROSE 1.1x].osu
Various Artists - Practice Pack (-Element-) [Itsuwari NEUROSE 1.2x].osu
Various Artists - Practice Pack (-Element-) [Itsuwari NEUROSE 1.3x].osu
Various Artists - Practice Pack (-Element-) [Kimi o Sagashi ni 1.1x].osu
Various Artists - Practice Pack (-Element-) [Kimi o Sagashi ni 1.2x].osu
Various Artists - Practice Pack (-Element-) [Kimi o Sagashi ni 1.3x].osu
Various Artists - Practice Pack (-Element-) [Kimi o Sagashi ni 1.4x].osu
Various Artists - Practice Pack (-Element-) [Kiss no Hitotsu de 1.1x].osu
Various Artists - Practice Pack (-Element-) [Kiss no Hitotsu de 1.2x].osu
Various Artists - Practice Pack (-Element-) [Kiss no Hitotsu de 1.3x].osu
Various Artists - Practice Pack (-Element-) [Kiss no Hitotsu de 1.4x].osu
Various Artists - Practice Pack (-Element-) [Mahou Shoujo Chino 1.1x].osu
Various Artists - Practice Pack (-Element-) [Mahou Shoujo Chino 1.2x].osu
Various Artists - Practice Pack (-Element-) [Mahou Shoujo Chino 1.3x].osu
Various Artists - Practice Pack (-Element-) [Mahou Shoujo Chino 1.4x].osu
Various Artists - Practice Pack (-Element-) [Miraizu 1.1x].osu
Various Artists - Practice Pack (-Element-) [Miraizu 1.2x].osu
Various Artists - Practice Pack (-Element-) [Miraizu 1.3x].osu
Various Artists - Practice Pack (-Element-) [Miraizu 1.4x].osu
Various Artists - Practice Pack (-Element-) [Missing You 1.1x].osu
Various Artists - Practice Pack (-Element-) [Missing You 1.2x].osu
Various Artists - Practice Pack (-Element-) [Missing You 1.3x].osu
Various Artists - Practice Pack (-Element-) [Missing You 1.4x].osu
Various Artists - Practice Pack (-Element-) [Music Start 1.1x].osu
Various Artists - Practice Pack (-Element-) [Music Start 1.2x].osu
Various Artists - Practice Pack (-Element-) [Music Start 1.3x].osu
Various Artists - Practice Pack (-Element-) [Music Start 1.4x].osu
Various Artists - Practice Pack (-Element-) [My Spirit Will Go On 1.1x].osu
Various Artists - Practice Pack (-Element-) [My Spirit Will Go On 1.2x].osu
Various Artists - Practice Pack (-Element-) [My Spirit Will Go On 1.3x].osu
Various Artists - Practice Pack (-Element-) [My Spirit Will Go On 1.4x].osu
Various Artists - Practice Pack (-Element-) [Pride Kakumei 1.1x].osu
Various Artists - Practice Pack (-Element-) [Sakura Fubuki 1.1x].osu
Various Artists - Practice Pack (-Element-) [Sakura Fubuki 1.2x].osu
Various Artists - Practice Pack (-Element-) [Sakura Fubuki 1.3x].osu
Various Artists - Practice Pack (-Element-) [SAKURA Skip 1.1x].osu
Various Artists - Practice Pack (-Element-) [SAKURA Skip 1.2x].osu
Various Artists - Practice Pack (-Element-) [SAKURA Skip 1.3x].osu
Various Artists - Practice Pack (-Element-) [SAKURA Skip 1.4x].osu
Various Artists - Practice Pack (-Element-) [SANTA SAN 1.1x].osu
Various Artists - Practice Pack (-Element-) [SANTA SAN 1.2x].osu
Various Artists - Practice Pack (-Element-) [Shoujo Satori 1.2x].osu
Various Artists - Practice Pack (-Element-) [Shoujo Satori 1.3x].osu
Various Artists - Practice Pack (-Element-) [SLoWMoTIoN 1.2x].osu
Various Artists - Practice Pack (-Element-) [SLoWMoTIoN 1.3x].osu
Various Artists - Practice Pack (-Element-) [Spiral 1.1x].osu
Various Artists - Practice Pack (-Element-) [Spiral 1.2x].osu
Various Artists - Practice Pack (-Element-) [Spiral 1.3x].osu
Various Artists - Practice Pack (-Element-) [Spiral 1.4x].osu
Various Artists - Practice Pack (-Element-) [Summer Of The Occult 1.1x].osu
Various Artists - Practice Pack (-Element-) [Summer Of The Occult 1.2x].osu
Various Artists - Practice Pack (-Element-) [Summer Of The Occult 1.3x].osu
Various Artists - Practice Pack (-Element-) [Tengoku to Jigoku 1.1x].osu
Various Artists - Practice Pack (-Element-) [Tengoku to Jigoku 1.2x].osu
Various Artists - Practice Pack (-Element-) [Tengoku to Jigoku 1.3x].osu
Various Artists - Practice Pack (-Element-) [Yuki no Youni 1.2x].osu
Various Artists - Practice Pack (-Element-) [Yuki no Youni 1.3x].osu
Various Artists - Practice Pack (-Element-) [Yuki no Youni 1.4x].osu
Total: 141
Passed: 41
Failed: 100

I'll also do a pass on all maps I have later

Tell me which ones are failing and I'll update the parser.

Make sure you're not running the debug build though, the debug one will crash on bad beatmaps. If you download it from Nuget you will automatically get the proper Release build.

Sorry for late response.
out of 46375 osu mode maps only 100 fail where all of them seem to fail because of this line in [TimingPoints] section: https://i.imgur.com/V5ZXJW8.jpg

Ah yeah, Smoogipoo once made a beatmap library that had this bug. I'll update the parser tomorrow.

Sorry for the wait. Turns out I'm not that great at "tomorrow".


refactor: search bar

closes #666

@He1DAr is this ready to release?

@He1DAr is this ready to release?

waiting to hear back from QA before merging this

:tada: This PR is included in version 1.18.10 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add macos & linux modules

Move server.user -> linux.user and add macos.user (using sysadminctl). Then have server.user behave like server.packages and similar where we select [linux|macos|windows].user according to the remote OS.

make sense

Good idea. Wouldn't want this to turn into a rabbithole, but would be nice to have a variable somewhere that tells you which platform you're on, so you can branch inside the scripts.
Easy way for linux: uname


MPD stuck on a loop and doesn't start

Which addon?
MPD
Describe the bug
Was working fine yesterday, then from this morning it keeps restarting and when it gets to this point on the the MPD addon log "[s6-finish] sending all processes the TERM signal." the Supervisor restarts the whole process again and just goes round and round in the same loop, see extract from Supervisor log:
21-03-11 21:20:05 WARNING (MainThread) [supervisor.misc.tasks] Watchdog found a problem with 243ffc37_mpd!
21-03-11 21:20:05 INFO (SyncWorker_2) [supervisor.docker.interface] Cleaning addon_243ffc37_mpd application
21-03-11 21:20:06 INFO (SyncWorker_2) [supervisor.docker.addon] Starting Docker add-on ghcr.io/poeschl/ha-mpd-aarch64 with version 1.5.2
To Reproduce
Steps to reproduce the behavior:
N/A not sure how to reproduce as I don't know the source of the problem
Expected behavior
MPD addon on a restart loop
Screenshots
Full extract from MPD addon log:
[s6-init] making user provided files available at /var/run/s6/etc...exited 0.
[s6-init] ensuring user provided files have correct perms...exited 0.
[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] mpd: applying...
[fix-attrs.d] mpd: exited 0.
[fix-attrs.d] ympd: applying...
[fix-attrs.d] ympd: exited 0.
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] setup-folders: executing...
[21:25:19] INFO: Setup Folders
[cont-init.d] setup-folders: exited 0.
[cont-init.d] setup-settings: executing...
[21:25:19] INFO: Setup settings
[cont-init.d] setup-settings: exited 0.
[cont-init.d] done.
[services.d] starting services
[services.d] done.
[cmd] /bin/ash exited 0
[cont-finish.d] executing container finish scripts...
[cont-finish.d] done.
[s6-finish] waiting for services.
[s6-finish] sending all processes the TERM signal.
Extract from the Supervisor log which is in constant loop:
21-03-11 21:20:05 WARNING (MainThread) [supervisor.misc.tasks] Watchdog found a problem with 243ffc37_mpd!
21-03-11 21:20:05 INFO (SyncWorker_2) [supervisor.docker.interface] Cleaning addon_243ffc37_mpd application
21-03-11 21:20:06 INFO (SyncWorker_2) [supervisor.docker.addon] Starting Docker add-on ghcr.io/poeschl/ha-mpd-aarch64 with version 1.5.2
System

Supervisor version: supervisor-2021.03.4
Host system version: Home Assistant OS 5.12

This issue is like #203, it will be handled there as well


feat(tangle-dapp): Validator selection UI & logic for LST

🚧 WIP: Please check the comments for the latest updates on this draft PR.
Summary of changes

Validator selection UI & logic for LST.

Proposed area of change

[ ] apps/bridge-dapp
[ ] apps/hubble-stats
[ ] apps/stats-dapp
[x] apps/tangle-dapp
[ ] apps/testnet-leaderboard
[ ] apps/faucet
[ ] apps/zk-explorer
[ ] libs/webb-ui-components

Reference issue to close (if applicable)

Closes #2334

Update: Jul 4

[x] The table displays data fetched from the Polkadot Mainnet (Validators) and Phala Network (Collators).
[x] The table displays the Validator's Identity, Total Staked Value, and Commission, both of which can be sorted.
[x] The table currently displays only the Collator's address.

Remaining items before ready for review

[ ] Since not all chains will provide all the data points we need (e.g., commission, TVS, etc.), we need to make the table generic.
[ ] Cache the retrieved data and display the cached data when switching between chains.
[ ] Clean up redundant code.
[ ] Test that the selection table works seamlessly for Polkadot Mainnet and Phala Network in this PR before moving on to other chains (next PR).

@devpavan04 you should likely adapt the table's generic pattern to support "adapters" that provide you

The list of things that can be staked on
The options of how they can be selected (single selections or multi selections).

You can see this pattern in the backend implementation of LST agents. The following is the set of choices as I see it:

Polkadot/Tangle/Kusama NPos chains allow you to select many nominators to stake on.
Astar allows you to select 1 dApp to stake on
Parachain-staking has its own way of working
etc. etc.

We can start to talk about this as a "stake operation" rather than staking on a validator more specifically, since Astar and other protocols may not have the same notion of validators to stake on. Instead they have other objects to stake on like smart contracts or dApps.

@yurixander Table now shows Collators on Manta and Moonbeam as well.


Improve pytest speed

Description of feature
Currently, starting pytest takes ages because it doesn't collect the tests that fast or seems to download something. I don't really know what's going on.
I think this was introduced when we merged the CellLineMetaData PR.

[ ] Figure out why test collection takes so long. Are we checking too many folders? Is it downloading things? Why are these not cached? What's happening?
[ ] Move more fixtures/anndata object creations into conftest fixtures
[ ] Cache cachedir on Github Actions tests
[x] Benchmark which tests take too long. Which functions take too long? Document them.


Chore: add Node 20 to CI version matrix

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.797%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
14555

Relevant Lines:
15302

💛  - Coveralls


ImportPackage endpoint fail when importing permissions

I created approximately 2 permissions and their child permissions. I exported the JSON file of these permissions, deleted them from the system, and attempted to reload them using the downloaded JSON file. Upon clicking the import button, the endpoint throws an error
Steps to reproduce the behavior:

Go to 'https://function-adminportal-test.shesha.dev/dynamic/Shesha/permission-configurator'
Add a new permission
Navigate to: https://function-adminportal-test.shesha.dev/dynamic/shesha/forms
Click on export and export the permission you created
Navigate back to permissions and delete the permission you've created
Afterwards, navigate to:  https://function-adminportal-test.shesha.dev/dynamic/shesha/forms and click on import
Attach the downloaded JSON file and click on Import button
Actual Results: A 500 error gets displayed There is no permission with name: Testing

Expected behavior
The permissions should successfully gets imported

Related Item
#1338


Create Integration test to assert Tooltip functionality is supported as expected

Speak with @azizpunjani or @notmessenger about how this was approached in the sl-button component

mine


DB Schema: Segments and sections

Design the database schema for segments and sections. More detailed descriptions in the requirements doc: https://docs.google.com/document/d/11U9XROLItXkfJGNJZ7LPFZYtWadtIhGB1zsD0WivXww/edit?usp=sharing
Create the schema with mongoose by the end of the sprint.

/cib add sections segment schemas

Branch 9-add-sections-segment-schemas created!


HDFS-17334. FSEditLogAsync#enqueueEdit does not synchronized this before invoke wait method.

Description of PR
In method FSEditLogAsync#enqueueEdit , there exist the below codes:
        if (Thread.holdsLock(this)) {
          // if queue is full, synchronized caller must immediately relinquish
          // the monitor before re-offering to avoid deadlock with sync thread
          // which needs the monitor to write transactions.
          int permits = overflowMutex.drainPermits();
          try {
            do {
              this.wait(1000); // will be notified by next logSync.
            } while (!editPendingQ.offer(edit));
          } finally {
            overflowMutex.release(permits);
          }
        }

It maybe invoke this.wait(1000) without having object this's monitor.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 25s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 18s

trunk passed

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  9s

trunk passed

+1 :green_heart:
mvnsite
1m 26s

trunk passed

+1 :green_heart:
javadoc
1m  6s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 33s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 20s

trunk passed

+1 :green_heart:
shadedclient
38m 32s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 20s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  8s

the patch passed

+1 :green_heart:
mvnsite
1m 21s

the patch passed

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 40s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m  7s

the patch passed

-1 :x:
shadedclient
44m 54s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 26s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+0 :ok:
asflicense
0m 26s

ASF License check generated no output?

160m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6434/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6434

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 71e56375345d 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 33a14bba95491c9282718b5053ff75b63140b472

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6434/1/testReport/

Max. process+thread count
566 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6434/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao @zhangshuyan0 @tomscut Sir, could you please take a look at this PR when you have free time? Thanks.

Line211 has already ensured that we have a monitor for this object:
https://github.com/apache/hadoop/blob/ba6ada73acc2bce560878272c543534c21c76f22/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java#L211-L223
So, I think the description in this PR is not a problem. What's your opinion? @hfutatzhanghb

Line211 has already ensured that we have a monitor for this object:
https://github.com/apache/hadoop/blob/ba6ada73acc2bce560878272c543534c21c76f22/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java#L211-L223
So, I think the description in this PR is not a problem. What's your opinion? @hfutatzhanghb

@zhangshuyan0 Sir, this.wait(1000); is in do-while loop,  when we invoke this.wait(1000) at first time, it will release object monitor. But in extreme situation, it will throw Exception when invoke this.wait(1000) at the second time, because current thread does not hold the object monitor. Waiting for your response~

Line211 has already ensured that we have a monitor for this object:
https://github.com/apache/hadoop/blob/ba6ada73acc2bce560878272c543534c21c76f22/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java#L211-L223
So, I think the description in this PR is not a problem. What's your opinion? @hfutatzhanghb

@zhangshuyan0 Sir, this.wait(1000); is in do-while loop, when we invoke this.wait(1000) at first time, it will release object monitor. But in extreme situation, it will throw Exception when invoke this.wait(1000) at the second time, because current thread does not hold the object monitor. Waiting for your response~

Let's see  JAVA doc :

Thus, on return from the wait method, the synchronization state of the object and of thread T is exactly as it was when the wait method was invoked.

Therefore, after this.wait(1000) returns at first time, it obtains the monitor again. I think no exception will be thrown here. By the way, in this JAVA doc , synchronize -> while loop is showed as a recommended usage. Looking forward to your response.

Line211 has already ensured that we have a monitor for this object:
https://github.com/apache/hadoop/blob/ba6ada73acc2bce560878272c543534c21c76f22/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java#L211-L223
So, I think the description in this PR is not a problem. What's your opinion? @hfutatzhanghb

@zhangshuyan0 Sir, this.wait(1000); is in do-while loop, when we invoke this.wait(1000) at first time, it will release object monitor. But in extreme situation, it will throw Exception when invoke this.wait(1000) at the second time, because current thread does not hold the object monitor. Waiting for your response~

Let's see java doc :

Thus, on return from the wait method, the synchronization state of the object and of thread T is exactly as it was when the wait method was invoked.

Therefore, after this.wait(1000) returns at first time, it obtains the monitor again. I think no exception will be thrown here. By the way, in this java doc , synchronized -> while loop is showed as a recommended usage. Looking forward to your response.

Sir, Thanks a lot for your explanations here.  I will close this PR laterly. Thanks again.