backup/restore use runs_once behavior, run backup during deploy by default

Coverage increased (+0.02%) to 94.58% when pulling 3485549a4ca1ab3d2f7cb9b27661d154f7e99389 on forced_manual_backup into 409127657c0f2bd180d348f14f5c3fc9fc15a9a8 on master.

Coverage increased (+0.6%) to 95.147% when pulling d03027747e3fb4c1be9133389b1364b9fb73b86d on forced_manual_backup into 409127657c0f2bd180d348f14f5c3fc9fc15a9a8 on master.

Coverage increased (+0.6%) to 95.147% when pulling d03027747e3fb4c1be9133389b1364b9fb73b86d on forced_manual_backup into 409127657c0f2bd180d348f14f5c3fc9fc15a9a8 on master.

Coverage increased (+0.6%) to 95.147% when pulling cfbd3c32e41ff72de91950f1825ee0ac34dfe7eb on forced_manual_backup into 409127657c0f2bd180d348f14f5c3fc9fc15a9a8 on master.

Coverage increased (+0.5%) to 95.105% when pulling 2afc1268923ae27a2d7147f4bf54379fe8590e1d on forced_manual_backup into 409127657c0f2bd180d348f14f5c3fc9fc15a9a8 on master.

Coverage decreased (-2.7%) to 95.139% when pulling 4277642d915cfd09ba069c2b8ee4147d52c310de on forced_manual_backup into dc0ba3093c6a4755e8c53d9931bf07ca7c9301ad on master.


[Bug]: setViewport does not work for puppeteer.connect

Minimal, reproducible example
const puppeteer = require('puppeteer');

(async () => {
  try {
    const browserURL = 'http://<IP_ADDRESS>:9222';
    const browser = await puppeteer.connect({ browserURL });
    const pages = await browser.pages();
    const page = pages[0];
//does not display the full page
    await page.setViewport({
      width: 1200,
      height: 800,
      deviceScaleFactor: 1,
    });
  }
  catch (e) {
    var dds = "dd";
  }
})();

Error string
no error
Bug behavior

[ ] Flaky
[ ] PDF

Background
I'm using Puppeteer to connect to an already running instance of Chrome using the puppeteer.connect method.
Expectation
I am expecting a resize of the viewport
Reality
However, I am facing an issue where the viewport size settings do not apply when connected to an existing browser, whereas it works perfectly fine when I launch a new browser instance using puppeteer.launch
Puppeteer configuration file (if used)
{
  "name": "amazon",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "puppeteer": "^22.9.0"
  }
}

Puppeteer version
22.9.0
Node version
21.4.0
Package manager
npm
Package manager version
10.2.4
Operating system
Windows

I am not able to reproduce. The viewport is resized according to the setViewport command. Perhaps make sure that nothing else changes the viewport?


fix #58 empty error state on action service failure

If an action service method call resulted in an error an empty object
is committed to the set*Error mutation rather than the error details.
This was an unintended result of Object.assign({}, error) which
always returned an empty object.
The mutation is responsible for serializing the error, via the
‘serialize-error’ package, and updating the errorOn* state so passing
the rejected error object as the mutation argument should work.

This is beautiful.  Thank you.

@cronik please come talk to me in the Feathers Slack when you get a moment.  I'd love to chat.

Released as<EMAIL_ADDRESS> Thanks again!


Add missing details about load-balancer-ip placeholder

Add details about the <load-balancer-ip> placeholder.
Fixes #8096

This looks very good to me but could use a second pair of eyes from either @heckj or @steveperry-53 just to be safe.
/approve

/lgtm
/approve


DBT 0.21.0 requires new configuration to override global DBT macros

See https://docs.getdbt.com/reference/dbt-jinja-functions/dispatch#overriding-global-macros
dispatch:
  - macro_namespace: dbt
    search_order: ['my_project/my_package', 'dbt']

@mroy-seedbox did you get this to work? I'm struggling with this

Yup, all you need is something like this in your dbt_project.yml:
name: my_project

# Allow my macros to override global DBT macros
dispatch:
  - macro_namespace: dbt
    search_order: ['my_project', 'dbt']

This is strange, I did this but it gives me No materialization 'plain' was found for adapter postgres! (searched types 'default' and 'postgres')

That is weird indeed! But I've never tested it with Postgres (only with Snowflake)... maybe there's something missing to make it work? 🤔

Same issue :(
macro-paths:
  - "macros"
  - dbt_modules/DDO/macros/materializations

# Allow my macros & DDO macros to override global DBT macros
dispatch:
  - macro_namespace: dbt
    search_order: ['my_project', 'dbt_modules/DDO/macros', 'dbt']

Try with dbt_packages/ instead of dbt_modules/.
dbt_modules/ was for older versions of DBT.

Same result with this config. It is a good point that I was using the old name, but unfortunately it didn't change the output.
I also ran a quick test where I removed dbt_packages from clean-targets but again, same result as in my previous post.
macro-paths:
  - "macros"
  - dbt_packages/DDO/macros/materializations

# Allow my macros & DDO macros to override global DBT macros
dispatch:
  - macro_namespace: dbt
    search_order: ['my_project', 'dbt_packages/DDO/macros', 'dbt']

target-path: "target"  # directory which will store compiled SQL files
clean-targets:         # directories to be removed by `dbt clean`
  - "target"
  - "dbt_packages"

Have you tried creating a copy of the materialization in your own project?
If that doesn't work, then it must be something specific to do with the DBT Postgres implementation. 😕

@AdrianCio: did it work? 😅

Apologies, I was off for a week. Indeed I ended up copying the materialization in my project which works fine.


Keras 3 expand dims not fully backend-agnostic

The function keras.ops.expand_dims(x, axis=(0, -1)) does not work with Tensorflow backend if more than one axis to expand along is defined. It raises InvalidArgumentError: 'dim' must be a tensor with a single value [Op:ExpandDims]. I guess it internally calls the function tensorflow.expand_dims() which only supports a single axis at a time. JAX backend works fine, Pytorch I did not try.

The newest version should support this functionality (in all backends), which was actually introduced by me 😃
You can refer to this colab
from keras import backend
from keras import ops

print(backend.backend())  # tensorflow
x = ops.ones([2, 3, 4, 5])
print(x.shape)  # (2, 3, 4, 5)
x = ops.expand_dims(x, [0, -1])
print(x.shape)  # (1, 2, 3, 4, 5, 1)

You can also find the test for this:
https://github.com/keras-team/keras/blob/master/keras/ops/numpy_test.py#L3332-L3361

Hi @MathiesW ,
Referring to @james77777778 comment could you please confirm woth what Keras version you have tested? Please try with latest version and still problem persists let us know with repro code snippet. Thanks!

Hi @SuryanarayanaY and @james77777778
I was using Keras 3.0.5. Just updated to 3.1.1 and now it works as intended. Thank you!


couldn't get the SuiteStore value in afterSuite hooks

I think the SuiteStore value should be clear after afterSuite hook executed rather than before

Duplicate of https://github.com/getgauge/gauge-js/issues/227. Please follow the tagged issue for progress.


Update github.com/hashicorp/go-retryablehttp for CVE-2024-6104

This library is only used (indirectly) by the New Relic scaler. It's unclear if KEDA is even affected by the issue (unsanitized logging) but it's good code hygiene to fix it either way.
$ go get -u github.com/hashicorp/go-retryablehttp
go: downloading github.com/hashicorp/go-retryablehttp v0.7.7
go: downloading github.com/hashicorp/go-hclog v1.6.3
go: upgraded github.com/hashicorp/go-hclog v1.6.2 => v1.6.3
go: upgraded github.com/hashicorp/go-retryablehttp v0.7.5 => v0.7.7
$ go mod tidy
go: downloading github.com/jstemmer/go-junit-report/v2 v2.1.0
$ go mod vendor

Checklist

[X] I have verified that my change is according to the deprecations & breaking changes policy
[X] Changelog has been updated and is aligned with our changelog requirements
[X] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5944

/run-e2e relic


SingleLine Input Text

Related Issue
A Pull Request should close a single issue; multiple issues can be closed when the issues are small and related, but that should be an exception not the rule. Please keep Pull Requests small and targeted; large 'code drops' with dozens of files will be closed and asked to split into reviewable pieces. Reviews that need to be large due to dependencies will be
reviewed on a case-by-case basis.
Please use one of the well-known github fixes keywords to reference
the issue fixed with this PR (eg Fixes #). If an issue doesn't yet exist please create one to aid
in issue tracking.
NOTE: For multiple issues resolved by this PR use the corresponding keywords every time in a comma-delimited list per the reference
page above.
Description
For all Pull Requests, please describe how the issue was fixed or how the feature was implemented from a summary level. This information will be used to help provide context to the reviewers of the pull request and should be additive to the issue being closed.

Implemented the Single Line Input Text for the Input Text element using the model based approach.
https://app.vidcast.io/share/cf7547e5-2bd1-44f8-a41d-c6800191c153

Sample Card
If appropriate, please include a link to a card in one of the samples directories that can be used to validate this change. This can be an existing card or a card added with this PR.
How Verified
How you verified the fix, including one or all of the following:

New unit tests that were added if any. If none were added please add a quick line explaining why not.
Existing relevant unit/regression tests that you ran
Manual scenario verification if any; Do include .gif's or screenshots of the testing you performed here if you think that it
will aid in code reviews or corresponding fixes on other platforms for eg.

Review in progress.


Update gradle clean task to reset window size and other preferences.

Codecov Report

Merging #299 (5644f38) into master (20f055b) will decrease coverage by 0.99%.
The diff coverage is 15.90%.

@@             Coverage Diff              @@
##             master     #299      +/-   ##
============================================
- Coverage     70.99%   70.00%   -1.00%
- Complexity      585      590       +5
============================================
  Files            98       98
  Lines          2131     2170      +39
  Branches        171      177       +6
============================================
+ Hits           1513     1519       +6
- Misses          536      566      +30
- Partials         82       85       +3

Impacted Files
Coverage Δ

src/main/java/donnafin/MainApp.java
0.00% <0.00%> (ø)

src/main/java/donnafin/model/Model.java
100.00% <ø> (ø)

src/main/java/donnafin/model/person/Address.java
66.66% <0.00%> (-13.34%)
:arrow_down:

src/main/java/donnafin/model/person/Asset.java
91.83% <0.00%> (-1.92%)
:arrow_down:

src/main/java/donnafin/model/person/Email.java
72.72% <0.00%> (-7.28%)
:arrow_down:

src/main/java/donnafin/model/person/Liability.java
91.83% <0.00%> (-1.92%)
:arrow_down:

src/main/java/donnafin/model/person/Name.java
66.66% <0.00%> (-13.34%)
:arrow_down:

src/main/java/donnafin/model/person/Notes.java
63.63% <0.00%> (-6.37%)
:arrow_down:

src/main/java/donnafin/model/person/Phone.java
66.66% <0.00%> (-13.34%)
:arrow_down:

src/main/java/donnafin/model/person/Policy.java
90.74% <0.00%> (-1.72%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d1fef...5644f38. Read the comment docs.


spacesuit: implement type-safe BitRange for range proofs

Closes #167

Changed from Option to Result; my understanding was that if the protocol should stop immediately if the value is not returned, then we should use Result. The None value, in this case signifying the absence of a bitrange would not be valid if I understand correctly.

Looks great! Just needs a few fixes to make travis happy.

Oh, could you please update the zkvm-spec.md to allow 0 as well 1–64?

last nitpick: i'd remove InvalidBitrange error as it's unused now. And rebase over main.
I've already done these two things here, but i cannot push to your branch, so you may peek at this one if you'd like: https://github.com/interstellar/slingshot/tree/pull/184/head


Live-Components: Firefox reload caches form-values (autocomplete?) and form is not re-rendered afterwards

I don't know if this really is an issue for live-components to fix, but:
I have a form in a live-component, where in twig one of the form fields is rendered or not, by looking at the formValues array. So if a user selects a certain entry from a radio-button-group, a text-field appears.
Everything is working fine. Refreshing the form also the initialState seems to work OK.
But Firefox behaves a bit differently. Form-values are cached when hitting reload.
So, radio button 'button 1', 'button 2', 'button 3', 'button 4'. If button 4 is selected, a text field appears. If I set the default to 'button 4' and I reload the page, Chrome neatly shows the text-field. If I change the form to 'button 2' for example, the text-field disappears. If I then reload the page, Chrome sets 'button 4' as selected again and the text-field appears again. Nice so far.
Firefox, after selecting 'button 2' and then reloading, keeps the button 2 selected, even if the HTML from Symfony says button 4 is checked="checked".
When you hard-reload, it works fine. But Firefox apparently caches form-values for a simple reload. But no 'change' events get fired, so live-components never see that something changed on the form from the state in HTML and will not re-render the form.
In a way I can see this as a bug in Firefox, but that sounds so harsh :). But they don't fire any events while changing input controls to a different state/value than is in the HTML that's loaded, so.....
Is there something that can be done in the live-component side of things?

Hmm, yea, I’m not familiar with this behavior in Firefox. It sounds like it effectively loads the form with button 4 selected (because that’s what the HTML from the server says), then it changes to button 2 due to some caching, but doesn’t trigger a change. If that’s true, that feels like bad behavior by Firefox. The question is whether there is any way to disable it.

Already fixed this a few times, IIRC setting autocomplete="off" on the form tag should work. (Or on inputs directly)

Yeah I've read that to, but turning autocomplete off isn't a good option
IMHO. The chance that a user reloads is less then annoying a user with
disabling features or their browser.
Then again, it's a radio group.... Its not like those are auto filled. I
can at least try.
On Thu, Aug 17, 2023, 20:18 jmsche @.***> wrote:

Already fixed this a few times, IIRC setting autocomplete="off" on the
form tag should work. (Or on inputs directly)
—
Reply to this email directly, view it on GitHub
https://github.com/symfony/ux/issues/1056#issuecomment-1682753613, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ALMD2DXCG4AUSMFGHICR6X3XVZN7JANCNFSM6AAAAAA3UEKQAE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Yeah, autocomplete=off in the choice_attr of the ChoiceType/EnumType does make Firefox behave better.
And since it's on the input level, it's not like turning off autocomplete for the whole form (what I really don't want to do).
So it's a workaround. Still feels like weird behaviour from Firefox though.
I get wanting to save the data entered in a form when someone reloads (how many times I didn't lose a big typed forum post because of things like that). But if you  - as a browser - decide to change an input control away from what the HTML tells you, at least send the proper events to let code react to it.


on installing npm

check the node-gyp documentation. you can also ask there for help on installation.


Kilo on Ubuntu 14.04

Allow deployment of the Kilo version of Keystone onto Ubuntu 14.04
Summary of changes:

use memcached for tokens
the keystone service is disabled. Access is done using WSGI via Apache's mod_wsgi
disabling token-based authentication for the admin user upon completion
a set of "sanity check" tasks which are run if keystone_run_sanity_check variable is set to yes
the default region is switched to RegionOne instead of regionOne

Testing
Kilo does not support Ubuntu 12.04, which is the only option for on Travis CI (to my knowledge).
Since the travis builds will fail, Vagrant is used to set up Ubuntu 14.04 and CentOS 7 libvirt instances to test deployment.
Currently, the Ubuntu test succeeds but the CentOS test fails, which I don't have time to fully dig into right now.

Hi @badi, thanks for your PR and sorry for the delayed reply.
Just WOW. Your PR is more than welcome :), but I have 2 comments:

We are trying to keep the role in kilo branch backward compatible with Juno. Although I see that this is becoming more and more difficult so probably it's time to give up that idea.
I am open to using other CI systems and I would really like to see these patches passing tests before merging them!

Thanks!

@dguerri Its just as well there was a delay actually as I haven't been able to integrate the changes in this PR with other kilo services in our setup. The current approach is to build up the deployment and then go back and clean up the roles. As such, I would suggest not merging this PR until I have time to revisit it. It's on my todo list, so I'll get to it eventually :)
Per your comments above:
1), I think this will be a challenge with kilo due to changes eg. WSGI/apache, api version changes, etc. In our case we don't need backward compatibility though. Maybe once things stabilize on our end we can discuss an approach that would satisfy everyone?

I completely agree on the necessity of the tests. I'm not yet aware of which CI services support ubuntu 14.04 and Github integration though.

Travis now supports trusty.
@badi please add these lines to .travis.yml so we can check again!
https://docs.travis-ci.com/user/trusty-ci-environment/
I would give +1  to move to wsgi apache and actually deprecate juno in favour of kilo and liberty
@dguerri


no version attribute

When I do import bitsandbytes;bitsandbytes.__version__, it outputs : AttributeError: module 'bitsandbytes' has no attribute '__version__', whereas most Python libraries would output the installed version.

yes I tried this and it's not working as well


Email address should be caller for auto-activation

Fixes #260
All Submissions:

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

[X] Does your submission pass tests?

LGTM


Feature/community rules

Add the possibility to load & upload rules made by the community

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[BUG] readnovelfull.com chapter list displayed as 0.

I found this when skimming my library. One book chapters list displayed as 0 but it has 2121 chapters when I open it with browser.

see #58


(New UI) Make use of the full page length for My Projects page

Scroll bar appears while the page still has a lot of space.

fixed.


Count non-regular files for progress as well

This should fix https://github.com/restic/restic/issues/206.
I think the source of the bug is that when generating the "todo list", we only count things as "file" if they are matching fi.Mode()&(os.ModeType|os.ModeCharDevice) == 0, where ModeType = ModeDir | ModeSymlink | ModeNamedPipe | ModeSocket | ModeDevice, so this excludes symbolic links.
This PR fixes that by counting everything as "file" which is not a "directory".
@fd0, does this make sense?
cc @rawtaz

(Tests are passing on Linux, but failing on OS X. They already fail on master though I think, so that's probably unrelated to my changes.)

This makes perfect sense and I'm ok with it :+1:


Fix HookResult(ExitType) when accept() is not called

close #354
High Level Overview of Change
Change ExitType to UNSET if accept() hook api is not called
Fixed as an amendment because of the effect on meta.HookExecution.HookResult
Context of Change

Type of Change

[x ] Bug fix (non-breaking change which fixes an issue)

The default is set to rollback on purpose... It's a security measure. A badly programmed hook might reach the end of the hook function without calling accept() or rollback() via some user input trickery. In these cases rollback is preferable because it's much less likely to result in a hack/loss of funds.

The mapping of ExitType::ROLLBACK->tecHOOK_REJECTED condition seems to be determined by hookResult.exitType ! = hook_api::ExitType::ACCEPT
https://github.com/Xahau/xahaud/blob/effc920b7e8ed3ccdbe48de1121cd32e3a87ad7b/src/ripple/app/tx/impl/Transactor.cpp#L1268-L1286
But if there is another way to resolve #354, that would be fine.


WAITING FOR REVIEW – [Testing] Formalize stress tests

Stress tests are, by definition, stressful. They intentionally burn a lot of resources by using randomness to hopefully surface state machine bugs. Additionally, many stress tests are multi-threaded these days and they may attempt to use all of the available CPUs to better uncover bugs. In isolation, this is not a problem, but the test suite as a whole assumes that individual tests are single threaded and therefore running multiple stress tests at once can quickly spiral out of control.
This change formalizes stress tests and then treats them like long tests, i.e. tested via 'check-swift-all' and otherwise opt-in.
Finally, with this change, the CI build bots might need to change if they are still only testing 'validation' instead of all of the tests. I see three options:

Run all of the tests. -- There are very few long tests left these days, and the additional costs seems small relative to the cost of the whole validation test suite before this change.
Continue checking 'validation', now sans stress tests.
Check 'validation', then the stress tests. If the former doesn't pass, then there is no point in the latter, and by running the stress tests separately, they stand a better chance of uncovering bugs and not overwhelming build bot resources. And by running the stress tests second, 'lit' can potentially be configured to run the stress tests serially, thus giving each stress test its best chance at uncovering bugs.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 7e00f96f40d02dfff4e2b0dec3c9c10a1bbc7a83

@swift-ci please test

@swift-ci please test linux

Build failed
Swift Test Linux Platform
Git Sha - 7e00f96f40d02dfff4e2b0dec3c9c10a1bbc7a83

@swift-ci please smoke test linux

Build failed
Swift Test OS X Platform
Git Sha - 7e00f96f40d02dfff4e2b0dec3c9c10a1bbc7a83

@swift-ci please smoke test osx

@swift-ci please smoke test macos

Hi @gottesmm, @shahmishal, and @jrose-apple  – Is there anybody else at Apple that should review this?

I'm not sure how I feel about adding another kind of tests, rather than just using long_tests again, but I can see the point of differentiating these (maybe you want to run them with a lower number of CPUs, to deal with the higher memory usage or the threading). I personally think it makes sense to say that long tests and stress tests all belong under validation-test/, though. What do you think?

Personally, I feel that long_test and the primary versus validation differentiation are not clearly defined, and even if they are clearly defined, actual test writers forget (at best) or don't care (at worst) about the differences over time.
If it were up to me, I'd ditch long_test as a REQUIRES flag, and then I'd have three test directories: tests, nonlinear-tests, and stress-tests.

tests – quick functional/unit tests. In other words, good "bang for buck" tests.
nonlinear-tests – combinatorial, permutation, exhaustive, and misc "long" tests.
stress-tests – Unreliable failure or success scenarios. Resource intensive.

validation-test is for "low signal-to-cost ratio" already. long_test is "maybe it has signal but it's really slow". The fact that we differentiate one of those by directory and the other by REQUIRES is perhaps questionable, but that's a separate issue.

If you want long tests and stress tests under validation-test, that sounds fine.
Personally speaking, 99.99% of the validation suite is fast enough that I run it all of the time and then Ctrl-C at the end when the stress tests are fighting with each other and the latent unmarked long_test tests are still running. If I don't hit Ctrl-C, then the validation suite takes about six times longer. That's why I modeled stress_test after long_test which is already excluded from validation.

Hey @jrose-apple – I've consolidated the stress/long tests into validation-test as you requested. I did not mark the latent long_test tests as such, because I didn't want to conflate this PR with the question/debate of "what counts as long?" and because long_test is conflated with no build bot testing as far as I know.
Should anybody else sign off on this PR before it is merged?
@swift-ci please smoke test

Ah, don't forget to move the inputs to the tests too!
long_tests are only run on specific bots, but it's not none. (They aren't included in PR testing unless you use test-with-preset, though.)

Nothing to be sorry for, this is a nontrivial testing change and it needs signing off. :-)
I moved the test inputs that I forgot. This just happened to work on my machine because I don't have the sanitizers setup and the command-line stress tests already had a copy of the inputs in validation-test.

@jrose-apple I need to do after-commit review of this. I need to focus on +0 right now... sorry = (.

@swift-ci please smoke test

Hi @jrose-apple – I posted to the compiler forum over the weekend in an effort to give people a heads up. Do think that if nobody responds by Friday, we can merge this? We can always revert this if people complain.

Someone else should look at it; I'd be fine with either @Rostepher or @shahmishal signing off.

@jrose-apple – Is there any specific question or concern that you have about this change? Or do you want review out of an abundance of caution?
For whatever it may be worth, this change is basically just copy-and-pasted from the long_test logic, so any feedback to this change would likely apply to long_test too.

It's not about the implementation at all. It's just making sure that someone else besides you and me knows that it's happening and what it means for the buildbots.

@davezarzycki @jrose-apple I landed +0. I can spend some time reviewing this now.

@davezarzycki Just from thinking about this in the abstract, I think that this is fine as long as we make sure that the long test bots (e.g.: https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04-long-test/) also run the stress tests. As long as that is true, I think this is fine.

Hi @gottesmm – Right. That's the idea. The least among of work would be for the long test bot to run the check-swift-all target (especially given that only_long doesn't work as advertised).
(Someday, the bots should be changed to check the stress tests serially, but that isn't urgent right now.)
How will I know when the bots have been updated?

@davezarzycki I would just update all of the long test presets to invoke the right flag for stress testing as well. See ./utils/build-presets.ini. I may need to update a few things internally, but I do not think that this will /break/ anything (we just won't run all of the tests that we need to). But I can fix/take care of that after this is merged.

Right. The stress tests will no longer be run on the build bots after this change. If you're willing to update the build bots, that's great! Thanks! If you could mark this as reviewed, and maybe nudge @Rostepher or @shahmishal to review this as well, I'd be happy to merge this. Thanks again!

@davezarzycki Can you update the following preset with the new stress test flag? otherwise, it looks good.
buildbot_incremental_linux,long_test
buildbot,tools=RA,stdlib=RDA,long_test

Please let me know if I updated utils/build-presets.ini correctly. Thanks

@swift-ci please smoke test

You will need to add support for stress test flag in build-script, after that you want to add the flag in presets. I would look at how long-test flag was added in the build-script.

@swift-ci please smoke test

I think the point was to keep the preset names the same but change the flags they pass.

@jrose-apple – I don't think I fully appreciate the build-presets.ini file and its interaction with the build-script. Can you be more specific about what you want changed?

You can check out build-script --help for more information, but they're basically just predefined sets of arguments. Nearly all of the buildbots then run build-script --preset=xyz. That makes it possible to reproduce a buildbot build locally.

@davezarzycki You can see how presents translate to arguments by using the flag --expand-build-script-invocation. For instance:
cartan:solon gottesmm$ ./swift/utils/build-script --expand-build-script-invocation --preset=buildbot_incremental,tools=DA,stdlib=DA,build
./swift/utils/build-script: note: using preset "buildbot_incremental,tools=DA,stdlib=DA,build", which expands to

./swift/utils/build-script --build-subdir=buildbot_incremental --compiler-vendor=apple --ios --tvos --watchos --reconfigure --verbose-build --build-ninja --build-swift-stdlib-unittest-extra --skip-build-benchmarks --release-debuginfo --assertions --debug-llvm --debug-swift --swift-stdlib-build-type=RelWithDebInfo --swift-stdlib-enable-assertions=true

cartan:solon gottesmm$

I've rebased and dropped the unintentional preset rename. I think this should be good to go now.
@swift-ci please smoke test

A test is determined to make 79 columns be the new "80 columns".
@swift-ci please smoke test


Included typescript-eslint

Included typescript-eslint
This is based on https://github.com/actions/typescript-action
Fixes #610

Signed-off-by: naveensrinivasan<EMAIL_ADDRESS>

I think this is ok for now. We'll want to add it to the Makefile and add a pre-submit at some point though.

Thanks, I can do that as part of the next PR!


Error decoding invoice with large amount

When decoding the following invoice, an exception is raised at require(pr.signedPreimage().contentEquals(tohash)).
The invoice is of (rather large) amount 100_000_000_000 msats.
lnbcrt11pj8wdh7sp5p2052f28az75s3eauqjskcwrzrjujf7rfqspsvk6hgppywytrdzspp5670t00mwakdy0l5w3lnw4rhdgnv4ctep974am6jp0zma627fhdfsdqqxqyjw5qcqp29qyysgqh2ce2cmptj33l35a9pt2l603aa34jpj8p35s302l0lhuujmtmkghrmkadv456h3rpsxjpschnpt5ugzltqsjtauvnfy799aufapav6gp202th5

java.lang.IllegalArgumentException: Failed requirement.
	at fr.acinq.lightning.payment.PaymentRequest$Companion.read(PaymentRequest.kt:233)
	at com.example.LightningKmpInvoiceTest.itShouldDecodeInvoiceSuccessfully(InvoiceConverterTest.java:111)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:577)
	at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:727)
	at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)

Hex.encode(pr.signedPreimage()):
6c6e62637274313030303030306d0c8ee6c4700d30c533a434f7e6d7c788df5f787058836ffa754af7dfa38561fb6125f3b807088021a332d9e67dfddecd20460886d324b8c859557aacc3d7d352272e240789850320583400300927501800545010904000

Hex.encode(tohash):
6c6e62637274313030300c8ee6c4700d30c533a434f7e6d7c788df5f787058836ffa754af7dfa38561fb6125f3b807088021a332d9e67dfddecd20460886d324b8c859557aacc3d7d352272e240789850320583400300927501800545010904000

Same behaviour with an invoice of amount 100_000_000_000_000 msats:
lnbcrt10001pj8wd3rsp5cv2vayxnm7d4783r0477rstzpkl7n4ftmalgu9v8akzf0nhqrs3qpp5vednenalh0v6gzxpzrdxf9cepv4274vc0tax5389cjq0zv9qvs9sdqqxqyjw5qcqp29qyysgqk5f8um72jlnw9unjltdgxw9e2fvec0cxq05tcwuen2jpu42q4p9pt2djk2ysu62nkpg49km59wrexm0wt3msevz53fr2tfnqxf5sdnqpu8th97

The exception is NOT raised with an invoice, of amount 10_000_000_000 msats (10x less than the first one above):
lnbcrt100m1pj8wwq5sp5cylu7386jfk4waf2h2dwpjlps5rqgz33vt3mc9mf0gkrm6gnpylspp5eeves0k77hk9l0pfjxzhhuyusutdme9detavkdycp2e2huw3at5qdqqxqyjw5qcqp29qyysgqstvreh8s4w7r8e3qkdchvjzql8vdzv4gkt03k5s4wc5krkhgwszkdrstlm9y7mwcktp70sqrft8z5xkxzvn5v4crl6zh72p3jf8xjfcqxkuqgz

All invoices have been created with CLN v22.11.1 on regtest.
Any hint or feedback is highly appreciated :pray:

The issue with your invoices is that they contain a description field, but it is empty. There have been discussions about that recently on the specification, but it's currently generally accepted that invoices without description or description hash are invalid.

Thanks for the clarification. How come the other invoice is parsed correctly?

That's strange, you're right! I'll look into it in more details, there must be something else...

Thanks for the report, you're totally right, this is a bug on our side! We simply don't handle amount that are multiples of 1BTC, because we interpreted the specification as requiring one of the defined currency multipliers: we thus encode 1BTC as 1000m (1000 mBTC) which creates a mismatch.


web support

Hello, thank you for this package since Flutter devs are sadly a bit slow with AVIF support.
For my usecase I would need to convert images to avif format before uploading.
The code is deployed as a web-app, so I cannot use flutter_avif as of right now.
I am not sure if it would be a big undertaking or not but is it possible to support web as well?

I have been thinking about adding web support. I think encoding part would be easy as we use rav1e to encode images and it can be compiled to wasm. For the decoding part I am thinking of just using the Flutter's Image widget since it uses the native capabilities of the browser and big percentage of browsers support AVIF.

Ok great to hear that it should be doable :)
regarding the decoding part I am not sure if Flutter's Image can handle AVIF, at least they don't list it:

The following image formats are supported: JPEG, PNG, GIF, Animated GIF, WebP, Animated WebP, BMP, and WBMP

But I was mainly concerned about the encoding part anyway.

I worked on web support over the weekend. I was able to compile rav1e to wasm, so right now, encoding works but only with canvaskit renderer. It doesn't work with the html renderer because the decodeImageFromPixels API I use to convert input images to rgba array is only implemented in canvaskit.
Another issue with encoding is that it does not support animations right now because the avif-serialize library I use does not support avis format. So I need to either implement avis support myself or compile libavif to wasm and use it.
There is also an issue with decoding. With html renderer it works on all browsers but with canvaskit it only works on chrome because of https://github.com/flutter/flutter/issues/115928.
I don't plan on publishing the web support until these issues are solved but I will keep the issue open, and share updates if anything changes.

ok, thank you very much for the update!

I found that using the HTML renderer on browsers that natively support avif already works with the built in Image class. It is only when using the CanvasKit do I get the decoding errors.
I don't know if that helps you, but at least its interesting.

I have fixed the problems I mentioned in my previous comment.
For decoding issues I have embedded a wasm avif decoder. The plugin is still using the native capabilities of the browser in html renderer, but it will use the wasm decoder in canvaskit until the https://github.com/flutter/flutter/issues/115928 issue is solved.
Encoding works fine both with single frame and animated images. But it is a little bit slow.
You can switch to version 2.2.0-dev to try it.


Support ROS Melodic

Ubuntu 18.04 comes with boost 1.65.1, and the usage of the boost::serialization::singleton class changed slightly in it (see https://www.boost.org/doc/libs/1_65_0/libs/serialization/doc/singleton.html ).  This will make it marti_common compile properly on 18.04 / Melodic.

Note that the melodic CI build will fail until https://github.com/ros/rosdistro/pull/17809 is merged and the package has been built on the build farm.


Doc generation bug: linked documentation without domain

Generated documentation moved from full URL to an absolute path.
https://github.com/googleapis/elixir-google-api/pull/1254/files#diff-7fe72a3ad2e3f75dd156ec267abc16a6L28

We should parse and capture that and if no domain, default to one.

Greetings, we're closing this due to inactivity. Please let us know if the issue needs to be reopened.


Dataview support

After publishing to confluence I expect to see a nice table. Instead I get a code fragment with Dataview query.
Would be great to have actual query result. I use dataview queries for having bibliography table at the bottom: all outgoing links if they lead to folder where I store notes on papers.

I am not sure if I can get access to the output from the Dataview plugin. Will need to investigate that.
Are you able to show the examples you are trying to replicate?

Maybe I can help with an example, because I have the same problem :-)

I have the same requirement. I'm synching large parts of my Obsidian vault with Confluence to share a knowledge base with others my in organization. I'm relying on links to connect projects, people, organizations, requirements. I use dataview to produce kind of table of contents on the top-level entry pages, e.g. "organization".

+1


[Feature] Integrate Cassandra DB

[ ] Integrate Cassandra Database
[ ] Create an Entity Relational Model Structure for the Database.
[ ] Make a Object Relational Model

Still having problem in connecting Cassandra so we migrated it MongoDB


Bump python libs, address insecure releases (#7550)

Bump python libs, address insecure releases

Using
https://requires.io/github/mistercrunch/superset/requirements/?branch=apache_release_improv
to identify insecure, old releases we're using and bumping.

redis <3.0

fix new flakes

(cherry picked from commit fd5befee38b352cf64b8d18e488751f69f97818b)
CATEGORY
Choose one

[x] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
Cherry picking PR that addresses a few problematic python libraries.
TEST PLAN
Test on staging
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
@john-bodley @graceguo-supercat @etr2460 @gabe-lyons

Codecov Report

Merging #145 into airbnb-master will decrease coverage by 7.56%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           airbnb-master     #145      +/-   ##
=================================================
- Coverage          72.63%   65.06%   -7.57%
=================================================
  Files                 78      427     +349
  Lines              10590    20680   +10090
  Branches               0     2313    +2313
=================================================
+ Hits                7692    13456    +5764
- Misses              2898     7100    +4202
- Partials               0      124     +124

Impacted Files
Coverage Δ

superset/cli.py
34.92% <ø> (ø)
:arrow_up:

superset/views/core.py
75.01% <ø> (ø)
:arrow_up:

superset/assets/src/components/Checkbox.jsx
100% <0%> (ø)

...ations/deckgl/layers/Polygon/PolygonChartPlugin.js
0% <0%> (ø)

...ets/src/dashboard/components/dnd/DragDroppable.jsx
94.59% <0%> (ø)

...c/visualizations/deckgl/layers/Polygon/Polygon.jsx
0% <0%> (ø)

...ssets/src/visualizations/presets/MapChartPreset.js
0% <0%> (ø)

superset/assets/src/components/EditableTitle.jsx
81.53% <0%> (ø)

superset/assets/src/setup/setupPlugins.js
0% <0%> (ø)

...t/assets/src/components/InfoTooltipWithTrigger.jsx
41.66% <0%> (ø)

... and 341 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8781864...f3d419e. Read the comment docs.


The Python grpcio generator can create classes with reserved keywords

What version of gRPC and what language are you using?

gRPC Version 1.35.0

What operating system (Linux, Windows,...) and version?

Tested on both Linux and Windows

What runtime / compiler are you using (e.g. python version or version of gcc)

Python 3.8.5

What did you do?
I created a protobuf file with a message with two fields: from and to. Then I implemented the server in Python and created a client in C#. The generated C# code worked without any problems, but when running the Python server I got an exception saying SyntaxError: invalid syntax because of the usage of the from field that I gave the message.
This would also happen with all the other keywords in Python, whereas it might not be a problem in other supported languages.
What did you expect to see?
To begin with I expected the Python interpreter to work even though the word from is a reserved keyword used in imports since I used it as a field name. Thereafter I questioned the design of the code generator and wheneter it should warn the user about this, or give the field a different name such as for example from_.
What did you see instead?
When running the generator I'd like to see some sort of a warning about this causing a syntax error, and/or giving the field a different name.

This keyword conflict is unfortunate, but existed in many languages. I would suggest to ask the question in https://github.com/protocolbuffers/protobuf/issues to see how ProtoBuf Python users solve this issue.


🐛💻 – documentation edit links not useful, possibly misleading

Describe the problem

Essentially all of the documentation pages on the gh-pages site are templates, and nearly all of the content is provided by including other markdown files. The edit links provide no way to edit the included documents. For example, the index page is a wrapper for README.md, but there's no way to edit README.md from an edit link.
In that sense, the edit links are really only useful for infrastructure developers to modify templates. Those developers would probably prefer using git directly instead of the GitHub edit interface.
For people who want to actually edit the README or CONTRIBUTING docs, there's no way to do that through edit links on the documentation site, which I find confusing.
The edit links are providing the wrong functionality to the wrong people.
Steps to reproduce

visit the documentation home
Click the "edit this page" icon on the upper right of the content
The editable content is only {{ include_file('README.md', downshift_h1= False) }}, there's no way to edit the included readme file.

The edit link seems to have been removed and this can be closed.


Safari doesn't show dragged-over state for file uploads

Why?
In reference to #7310
This is not an Ember issue. Safari ignores classes that begin with --. I believe that none of the IEs allow these types of classes as well.
Example:

https://jsfiddle.net/oy75f0L3/2/

Sources:

https://twitter.com/logicoder/status/654897918357434368
https://www.reddit.com/r/web_design/comments/4ji5p7/safari_completely_ignores_classnames_starting/

What Changed?
Globally searched for modifier classes that start with -- and removed the first dash.
Example

closes #7310

Removes double dashes from modifier classes as safari won’t allow
this.

@KennethAshley thanks for this! TIL 😁 Never knew Safari ignored classes prefixed with --


Add version: gurnec.HashCheckShellExtension version 2.4.0

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/115646&drop=dogfoodAlpha

Possible duplicate package entry.
Similar installer SHA256 hash found in manifest:

InstallerSha256: 2d6067f00bbb93526d146d2228a46dc4851f0fa866e69250279c6b2f00b8f1b7

manifests\g\gurnec\HashCheckShellExtension\<IP_ADDRESS>

Hi @vedantmgoyal2009,
Is this a duplicate?

Close with reason: Duplicate; Existing package has correct ARP


furnace: 0.6.3 -> 0.6.5

Description of changes
Haven't tested the new localisation support, as my system doesn't support any of the translations available so far. But English works, and it seems to be looking in the right paths.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Checked localisation in a VM, it does seem to work fine.


Feature/automate api tests

Description
Add Mocha API test run against docker compose environment
Changes

ARTS-408 - Introduce Mocha tests. Add ci target for Mocha.

Checklist:

[ ] Branch name follows convention (feature/arts-###-short-name OR fix/arts-###-short-name)
[ ] I have included a short-meaningful title, description and changes for this PR

WiP changes. Need to add publish to GHCR back in.

WiP changes. Need to add publish to GHCR back in.


Rate limit bugs

Trying to add rate Limit to the auth and found some bugs
1-  trying to add custom Rules to Phone Number plugin and it don't work but the main rate Limit work fine
rateLimit: {
    enabled: true,
    window: 60,
    max: 30,
    customRules: {
      "/phone-number/send-otp": {
        window: 60,
        max: 1,
      },
    },
  },

2- if i add database storage all rate Limit don't work without any error log
  rateLimit: {
    enabled: true,
    storage: "database",
    tableName: "rateLimit",
    window: 60,
    max: 30,
    customRules: {
      "/phone-number/send-otp": {
        window: 60,
        max: 1,
      },
    },
  },

even after make sure the rate Limit schema is linked
database: drizzleAdapter(db, {
    provider: "sqlite",
    schema: {
      ...schema,
      user: schema.User,
      rateLimit: schema.rateLimit,
    },
  }),

and the rateLimit table in db Is empty
Desktop:  win 11,  mode.js 22.6.0

Rate limit customStorage configuration is either not implemented (at least I couldn't find it) or not being respected. Additionally, the get and set methods for customStorage receive only the key, making it difficult to determine which rate limit to apply programatically. This is problematic because endpoints like /sign-in/email and /two-factor/verify have different window and max values compared to the default settings, and we can also apply our own rules.

hey guys both issues should be fixed on 1.0.10! feel free to re-open if not


mod: bump quic-go dependency

Please provide a description of this PR:

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot_istio
ef8073d8338600a797c86fbeb65373592395a6b6
link
true
/test integ-pilot_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Possible error in files synchronization

I am deploying a service to DevSpaces. Chart needs two yaml files, that I pass to it using install.values in azds.yaml:
install:
  chart: ../../../../k8s/helm/identity-api
  values:
  - values.dev.yaml?
  - secrets.dev.yaml?
  - inf.yaml
  - app.yaml

The first time I perform an azds up -v it works succesfully:
Using dev space 'default' with target 'edu-devspaces3'
Synchronizing files...
 Uploaded src\Services\Identity\Identity.API\app.yaml
 Uploaded src\Services\Identity\Identity.API\inf.yaml
Synchronized files in 5s
Installing Helm chart...
NAME:   default-identity-api-afb595a0
LAST DEPLOYED: Tue Jul 31 10:10:38 2018
NAMESPACE: default
STATUS: DEPLOYED

But, when I try to deploy (azds up -v again) I receive a helm error. This error is when additional app.yaml or inf.yaml are not present:
Using dev space 'default' with target 'edu-devspaces3'
Synchronizing files...
Synchronized files in 4s
Installing Helm chart...
Error: render error in "identity-api/templates/service.yaml": template: identity-api/templates/service.yaml:4:18: executing "identity-api/templates/service.yaml" at <.Values.app.svc.iden...>: can't evaluate field svc in type interface {}
Failed to install Helm chart
Service cannot be started.

If i touch (or do a dummy edit like adding a space) on both inf.yaml and app.yaml it works succesfully again (I see the files are uploaded again):
Using dev space 'default' with target 'edu-devspaces3'
Synchronizing files...
 Uploaded src\Services\Identity\Identity.API\inf.yaml
 Uploaded src\Services\Identity\Identity.API\app.yaml
Synchronized files in 4s
Installing Helm chart...
NAME:   default-identity-api-7d5fadd8
LAST DEPLOYED: Tue Jul 31 10:15:32 2018
NAMESPACE: default
STATUS: DEPLOYED

Thanks for reporting this issue. Our dev team is looking into it.

@eiximenis this should be fixed now. Let us know if you're still having issues. Thanks!


add support for value-class for u-* properties and value-title parsing

This should fix #37, #38, and #40


Feature/update dvc params new xlinear

Description
I'm preparing for a 0.2.3 release with the fix for the number of tags predicted by the model. For this, I am re-running the dvc pipeline, updating the parameters, updating dvc etc with a latest model.
Issue tracked on notion
Checklist

[x] Linked to Notion or GitHub issue
[ ] Added tests
[ ] Updated README
[ ] DVC up to date

Release checklist

[ ] DVC repro up to date
[ ] Models synced in S3
[ ] Version updated
[ ] CHANGELOG.md updated
[ ] Model and package version aligned

To release:

make build
make deploy

Dvc is currently running with the new parameters.


Submit Option - Ellipsoid Height not allowing meters

@seanfernandez what are the limits be for the other units?

@seanfernandez can you provide the limits?

0-12,000 should work for both feet and meters

Another bug for entering longitude degrees is keeping me from accessing the elevation field, but I'm confident this has been resolved in previous iterations.


jsonEncodedString not deal Date type

The jsonEncodedString not convert Date type,that make response by json with date type will fail.
like this code will return fail to js client
response.setHeader(.contentType, value: "application/json")
let d: [String:Any] = ["a":1, "b":0.1, "c": true, "d":[2, 4, 5, 7, 8],"f":Date()]
do{
try response.setBody(json: d)
}catch{
}
response.completed()

Hope add Date type convert in jsonEncodedString

@kjessup Are you keeping jsonEncodedString in it's current form or are you going to implement Foundation's JSONEncoder everywhere?

It is recommended to use the String type

It's not an issue of whether it is sent as a String. The issue is a feature request to automatically handle the Date type.


docs: add undocumented cast commands

The following undocumented commands for cast have had their documentation added

from-wei
parse-bytes32-address
to-dec
to-hex

Resolves #952

needs smol rebase


Undefined Values

Seems like 1.3.4 or perhaps an even earlier update introduced large swathes of undefined data in the main dataset. Note to address the bug ASAP.

Seems like an update from Google's end seems to have stopped supplying comments stating the subset to certain variations of fonts, thus being the source of the undefined data.


RTSP/1.0 400 Bad Request when query parameters are supplied in RTSP URL

Which version are you using?
v1.8.0
Which operating system are you using?

[ ] Linux amd64 standard
[ ] Linux amd64 Docker
[ ] Linux arm64 standard
[ ] Linux arm64 Docker
[ ] Linux arm7 standard
[ ] Linux arm7 Docker
[ ] Linux arm6 standard
[ ] Linux arm6 Docker
[ ] Windows amd64 standard
[ ] Windows amd64 Docker (WSL backend)
[ ] macOS amd64 standard
[ ] macOS amd64 Docker
[x] Other (macOS arm64 [M2] Docker)

Describe the issue
When attempting to stream video with RTSP (using Gstreamer), response 400 is given on SETUP request.
Describe how to replicate the issue

Launch MediaMTX with the following config: mediamtx.yml

Docker command I'm using is docker run --restart unless-stopped -v ./src/mediamtx/mediamtx.yml:/mediamtx.yml -v ./src/mediamtx:/app/data -p 8554:8554 -p 1935:1935 -p 8888:8888 -p 8889:8889 -p 8890:8890/udp -p 8189:8189/udp bluenviron/mediamtx

Stream a test video using Gstreamer (v1.22.10), observe the connection has no issues
gst-launch-1.0 videotestsrc ! videoconvert ! videoscale ! video/x-raw,width=640,height=480 ! x264enc speed-preset=veryfast tune=zerolatency bitrate=800 ! rtspclientsink protocols=tcp location=rtsp://<IP_ADDRESS>:8554/mystream
Stream a test video using Gstreamer, with sample query parameters
gst-launch-1.0 videotestsrc ! videoconvert ! videoscale ! video/x-raw,width=640,height=480 ! x264enc speed-preset=veryfast tune=zerolatency bitrate=800 ! rtspclientsink protocols=tcp location=rtsp://<IP_ADDRESS>:8554/mystream?key=value
Observe the response: Error (400): Bad Request

Logs

Logs from server:

2024/04/25 12:04:25 INF [RTSP] [conn <IP_ADDRESS>:25173] opened
2024/04/25 12:04:25 DEB [RTSP] [conn <IP_ADDRESS>:25173] [c->s] OPTIONS rtsp://<IP_ADDRESS>:8554/mystream?key=value RTSP/1.0
CSeq: 1
Date: Thu, 25 Apr 2024 12:04:25 GMT
User-Agent: GStreamer/1.22.10

2024/04/25 12:04:25 DEB [RTSP] [conn <IP_ADDRESS>:25173] [s->c] RTSP/1.0 200 OK
CSeq: 1
Public: DESCRIBE, ANNOUNCE, SETUP, PLAY, RECORD, PAUSE, GET_PARAMETER, TEARDOWN
Server: gortsplib

2024/04/25 12:04:25 DEB [RTSP] [conn <IP_ADDRESS>:25173] [c->s] ANNOUNCE rtsp://<IP_ADDRESS>:8554/mystream?key=value RTSP/1.0
CSeq: 2
Content-Length: 472
Content-Type: application/sdp
Date: Thu, 25 Apr 2024 12:04:25 GMT
User-Agent: GStreamer/1.22.10

v=0
o=-<PHONE_NUMBER> 1 IN IP4 <IP_ADDRESS>
s=Session streamed with GStreamer
i=rtspclientsink
t=0 0
a=tool:GStreamer
m=video 0 RTP/AVP 96
c=IN IP4 <IP_ADDRESS>
b=AS:819
a=rtpmap:96 H264/90000
a=framerate:30
a=fmtp:96 packetization-mode=1;sprop-parameter-sets=Z/QAHpDZaAoD2wFqDAwMgAAAAwCAAAAeR4sXUA==,aO8xkhk=;profile-level-id=f4001e;level-asymmetry-allowed=1
a=control:stream=0
a=ts-refclk:local
a=mediaclk:sender
a=ssrc:1080323934 cname:user668979404@host-d08b337a

2024/04/25 12:04:25 INF [RTSP] [session 7df37126] created by <IP_ADDRESS>:25173
2024/04/25 12:04:25 DEB [path mystream] created
2024/04/25 12:04:25 DEB [RTSP] [conn <IP_ADDRESS>:25173] [s->c] RTSP/1.0 200 OK
CSeq: 2
Server: gortsplib

2024/04/25 12:04:25 DEB [RTSP] [conn <IP_ADDRESS>:25173] [c->s] SETUP rtsp://<IP_ADDRESS>:8554/mystream/stream=0?key=value RTSP/1.0
CSeq: 3
Date: Thu, 25 Apr 2024 12:04:25 GMT
Transport: RTP/AVP/TCP;unicast;interleaved=0-1;mode=RECORD
User-Agent: GStreamer/1.22.10

2024/04/25 12:04:26 DEB [RTSP] [conn <IP_ADDRESS>:25173] [s->c] RTSP/1.0 400 Bad Request
CSeq: 3
Server: gortsplib

2024/04/25 12:04:26 INF [RTSP] [conn <IP_ADDRESS>:25173] closed: media not found
2024/04/25 12:04:26 DEB [path mystream] destroyed: not in use
2024/04/25 12:04:26 INF [RTSP] [session 7df37126] destroyed: not in use

It seems fine until Gstreamer tries to send data to the /mystream/stream=0 endpoint.
Additional info
The reason I need to send a query parameter is for JWT authentication; as specified in the docs I am trying to send jwt=..., however the process fails as described above.
Did you attach the server logs?

yes
Did you attach a network dump?

no

Hello, i can confirm that there's a bug, but it's on the GStreamer side, since in RTSP the control attribute (stream=0) should be appended AFTER query parameters (key=value), not merged with query parameters.
This is the (wrong) request that GStreamer sends when publishing:
SETUP rtsp://<IP_ADDRESS>:8554/mystream/stream=0?key=value RTSP/1.0

This is the right one:
SETUP rtsp://<IP_ADDRESS>:8554/mystream?key=value/stream=0 RTSP/1.0

The problem is that this split between query parameters and control attribute is not mentioned in the specification, it's an unwritten rule of RTSP that is implemented anywhere nonetheless. Except GStreamer, evidently. Thus i doubt that GStreamer maintainers would accept a patch.

This is fixed by https://github.com/bluenviron/gortsplib/pull/619.
With respect to my previous comment, i edited the server in order to support both URL formats.


Support old C++ compilers that don't have

Old C++ compilers such as g++ 7.x doesn't have <filesystem>, but they sometimes
have <experimental/filesystem> instead.
Checklist

[ ] Language changes are updated in docs/reference_guide.md
[ ] User-visible and non-trivial changes updated in CHANGELOG.md
[ ] The new behaviour is covered by tests

Thanks looking into this!
Looks like the alpine build fails on this, guess the __cpp_lib_filesystem isn't set there?

The alpine issue is odd. Since it was working before my change, it should have std::filesystem but __cpp_lib_filesystem seems not defined. Let me dig in.

__cpp_lib_filesystem is defined in <filesystem>. I think I had to include <version> first to have the feature macro.
https://en.cppreference.com/w/cpp/header/version

But  is not available prior to C++20... So I've changed the include section to use has_include which is available > C++17.
https://en.cppreference.com/w/cpp/preprocessor/include

thanks!


Inplace operation

RuntimeError: one of the variables needed for gradient conputation has been modified by an inplace operation.
When I use torch.autograd.set_detect_anomaly(True) to find the operation that failed to compute its gradient, it shows "x = self.conv(2) " in dcp/models/preresnet.py. I can't find the solution, Could anyone help me?

Hi, what version of Pytorch do you use? In what situation did you encounter this error?

Thanks for your reply! I use pytorch 1.6 when I try to channel-prune Resnet-56.
I just realized that if I change  "temp_input=temp_output" to  "temp_input=temp_output.detach()" in aux_trainer.py,   it works.  I don't know if this operation changes the algorithm.

发件人: liujingcs @.>
发送时间: 2021年11月22日 14:31
收件人: SCUT-AILab/DCP @.>
抄送: li feng @.>; Author @.>
主题: Re: [SCUT-AILab/DCP] Inplace operation (Issue #20)
Hi, what version of Pytorch do you use? In what situation did you encounter this error?
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/SCUT-AILab/DCP/issues/20#issuecomment-975173382, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKXC2ZAI5A3GYDSKESYTRBDUNHPVTANCNFSM5IQFO44A.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I've solved the problem。


Use enum instead of module for HTTP::WebSocket::CloseCodes

Followup to #8975

I think the problem with close codes is that there are lots of values. Is not the same situation as http status codes which are fixed by the rfc.
I'm fine with using enums, if the option for using integers are still available. And if having those overloads does not prevent the autocasting feature to work on enums.
Ref: https://developer.mozilla.org/en-US/docs/Web/API/CloseEvent#Status_codes

I'm fine with using enums, if the option for using integers are still available. And if having those overloads does not prevent the autocasting feature to work on enums.

It is, and it has to be for http status codes to work as well, since there are many unassigned ones that could be used by the developers anyway.
autocasting will obviously work only for the assigned ones.

Is not the same situation as http status codes which are fixed by the rfc.

HTTP status codes are in fact extensible and not limited to registered ones (see https://tools.ietf.org/html/rfc2616#section-6.1.1). So it's one and the same thing.

autocasting will obviously work only for the assigned ones.

I think a problem could be when we need to know all possible enum values at compile time. That's at least a possible scenario we should be aware of.
But for now it is IMO fine to apply this change because the close codes are conceptually identical to HTTP status codes (registered set, but extensible). If the implementation of enum changes at some point to only allow pre-known values, we would need to figure out something else anyway. And probably also take these codes into consideration.

If there is a valid range like there is with HTTP::Status, we could do something like https://github.com/crystal-lang/crystal/blob/master/src/http/status.cr#L71-L76 to validate the value is within that range.

@Blacksmoke16 Good idea! I've force-pushed changes with the check.

My idea is to force enums to have valid values, always. Right now Enum.new and also when returning enums from C bindings don't have this check, but we should have them.
Then, we could introduce an @[OpenEnum] or similar annotation to say "This enum can have more values than those listed", and then the compiler would always require an else when doing case over such enum.

@asterite Sounds good, but please open an RFC issue about that, to not to stall this PR.

Oh, of course. It's an idea, it's not necessary for this PR.

Anything left to do in here?

All comments addressed.


Create codeql.yml

Enables Code QL scanning

Ah, looks like we need to enable some dummy vars for building. I'll add 'em :)


Update the license for mechanize.

Its license can be found on the current maintainer's Github here, which is referenced via the main website here.

Thanks!


pip install no longer works

I just tried pip install pykml, and was disappointed to see that this no longer works.   I get
...
 WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ReadTimeoutError("HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Read timed out. (read timeout=15)")': /packages/8f/16/276e16f024db5aca4c8891cecd56219a5a1e016fa356e858dfb04590b1d5/pykml-0.1.3.tar.gz
ERROR: Could not install packages due to an EnvironmentError: HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Max retries exceeded with url: /packages/8f/16/276e16f024db5aca4c8891cecd56219a5a1e016fa356e858dfb04590b1d5/pykml-0.1.3.tar.gz (Caused by ReadTimeoutError("HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Read timed out. (read timeout=15)"))

Is anyone actively developing or maintaining PyKML?   This is a fantastic package, and it would be  great if someone wanted to at least maintain it for current releases of Python.

Thanks for the report.
We have been doing some recent work on upgrading pyKML to Python 3, but I have not yet committed the changes and pushed an update to pypi. I have blocked out some time for Friday during which I will try to push a new version.

Great news!  I'll be eager to hear of updates.

@tylere @donnaboise I am a bit lost
What's the right github repository to post issues about pykml?
I mean, which one is the source to the package which I can install using pip?
https://github.com/tylere/pykml/issues
https://github.com/pykml/pykml/issues
Thanks


Added aria-expanded state with toggle feature for leaflet-control-layers-toggle, regarding Issue #7526

Description
This PR adds the aria-expanded state to the leaflet-control-layers-toggle  anchor element(<a/). This aria-expanded state is toggled to true on mouse enter event and to false on the mouse leave event.
Here is a GIF demonstrating this change:

Fixes #7526
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] Accessibility feature
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Prior to committing the npm run lint command was run successfully with no issues
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes

Ok I'll try to implement the changes to keyboard inputs as well

Added keyboard input support for the aria-expanded attribute for leaflet-control-layers-toggle element.
Here is a GIF demonstrating the changes:

Sorry @ShehanAT, I forgot about the layers control's behavior. While the changes are technically correct, what should happen is:

https://github.com/Leaflet/Leaflet/issues/7191 - rather it should be collapsed/expanded when the layers control is activated
aria-expanded should be toggled based on the collapsed/expanded state

Alright I'll look into this soon

Added the request changes so that:

The layers control is not expanded upon focus event. Rather, only pressing enter or tab again after the focus event will cause it to expand
Upon layers control expanding via focus then enter key, the aria-expanded attribute is set to true. When a mouse click event on the map is registered, the layers control collapses and the aria-expaned attribute is set to false.

Here is a GIF demonstrating the new changes:

Added the fixes regarding keydown event. Here are more details:

Pressing Tab to navigate the map doesn't not open the layers-control unless it is focused on and then user presses Enter
I tested with both NVDA and Windows Narrator screen readers and the above point functions as expected while the screen readers are in use.

Side note: Using Windows Narrator with input learning mode on doesn't allow the user to navigate the webpage by pressing Tab, therefore expanding the layers-control won't be possible.
Here is a GIF demonstrating the new changes:

Side note: Using Windows Narrator with input learning mode on doesn't allow the user to navigate the webpage by pressing Tab, therefore expanding the layers-control won't be possible.

Narrator's input learning is merely a mode for users to learn their keyboard layout and the associated commands, so that's not a problem. 😋
While aria-expanded="false" is conveyed now (and as such allows the user to understand that new content is available after activating the control) - aria-expanded="true" is not conveyed due to the fact that the control is display: none (and as such can't keep the focus to convey the new state), this can be considered a separate issue (which relates to the inability to close the layers menu from the menu/control itself, which is problematic in some cases, mostly on mobile). With that said, ideally the layers control always toggles the collapsed/expanded state (and aria-expanded), i.e. if you were to temporarily set leaflet-control-layers-toggle to display: block!important in dev tools, it should be possible to toggle on repeated clicks. However I feel that's stretching the intent of this PR. I've separated some of the problems with the layers control into smaller issues, but maybe there needs to be a holistic discussion about the fundamentals of the layers control first...

maybe there needs to be a holistic discussion about the fundamentals of the layers control first

@ShehanAT Sorry for this oversight, aria-expanded is currently not appropriate. I think the layers control can be improved in other areas as well, so will need a new discussion first. Thanks for taking the time, and again, sorry!


Clear entire kubectl repo before turning on staging publishing bot

Removes ALL code in this repository
Prepares to accept kubectl code from Kubernetes staging, which requires that all contributions be made through staging (not directly to this repo).
Backup for this repository is at:

https://source.cloud.google.com/seans-devel/kubectl-backup

For code we want to re-introduce (e.g. kubectl book and integration test framemwork), we will add it to the kubectl staging directory:

https://github.com/kubernetes/kubernetes/tree/master/staging

/assign @pwittrock
/assign @soltysh
/assign @liggitt

/assign apelisse

/approve

/lgtm


Allows to set the unvoiced_cost in order to force f0 estimation

F0 is not tracked when the speech signal is very noisy (in voiced segments as well).
It is necessary sometimes to force the estimation by changing the cost for the presumably "unvoiced" segments.

I signed it!
G
On Mon, Aug 28, 2017 at 1:57 PM, googlebot<EMAIL_ADDRESS>wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.

If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data https://cla.developers.google.com/clas and verify
that your email is set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
If your company signed a CLA, they designated a Point of Contact who
decides which employees are authorized to participate. You may need to
contact the Point of Contact for your company and ask to be added to the
group of authorized contributors. If you don't know who your Point of
Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have
the pull request author add another comment and the bot will run again.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/REAPER/pull/11#issuecomment-325333888, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AELwPxkpxbHGFsfxdJ_vIuTz8XPmxh-kks5scqtHgaJpZM4PEbJc
.

--
Mobile: +33 7 67 45 22 38

If this pull request is merged, I can add another one to add a command line argument.


Deprecate "executables" after 0.18.0 release

My only input is that it might make more sense to keep executables instead of executable. Other fields that behave like this, like dependencies, are plural.

(moving this discussion here)
@tfausak That would mean we remove executable all together and only go with executables?  On the plus side that would be 100% backward-compatible, so we would not need a deprecation cycle.
It's just that reading
executabels:
  main: Main.hs

feels weird to me, at least initially.
But in general I'm open to it.

You're right, that is a little weird. I'm not sure which is better :confused:
dependencies: base
dependencies: [ base ]
dependencies:
  - base

executables: { main: Main.hs }
executables: [ { main: Main.hs } ]
executables:
  main: Main.hs

On the other hand, reading multiple executables in the executable section is also a bit strange.
executable:
  one: { main: one.hs }
  two: { main: two.hs }

I don't have a super strong opinion either way.

@tfausak Let's go with what your originally intended, having executable as a shortcut for executables: { package-name: ... }.  That way we also get slightly better error messages. Ok with you?

:+1: Sounds great!

Cool!


Echo Show set image changes clock

Hi.  First off, thanks for this fantastic component.  We've been in a Google Mini world for a long while now and have just transitioned over to the Echo world.  This component has made the transition very smooth as we use a fair amount of voice notification automations.
I recently purchased an Echo Show and am wanting to use it to set different backgrounds with visual notifications of which kid has to do which chore on days they have things to do.  I've successfully managed to set an image, but it seems that the clock defaults to the small clock in the upper left corner instead of the much larger clock we were using.  Is there any way to choose the clock type when setting the background image?  If not, is that something that could be added?
All the best to you!

Thanks. Glad it's been helpful for you. We're reliant on what the Amazon app can do as we're just emulating the functionality. I don't think it currently allows that setting when changing the background image but if you find it, we may be able to add that.

Ah, okay.  Just dug around and can't see any way to do it from the app.  Maybe someday :(  Thanks again.


feat: storage capacitor

https://capacitorjs.com/
There are errors in my tests, I did not know how to solve it. Can you help with that ?

Yes, I can, however, please don't use the repository or PRs to test your own packages in the future. This has basically nothing to do with urql except that it happens to implement a type that we accept, basically 😅
While I'm happy to help out with unrelated questions in discussions, this isn't something that's suitable for an issue or PRs. I get that it's convenient, but that's like opening a PR that you know will never be merged as is 😅

The error is very simple. In your mocks you're tryin to do:
      vi.spyOn(Preferences, 'get').mockResolvedValueOnce(
        JSON.stringify({
          [dayStamp]: { foo: 'bar', hello: 'world' },
          [dayStamp - 1]: { foo: 'bar', hello: 'world' },
          [dayStamp - 2]: { foo: 'bar', hello: 'world' },
        })
      );

However, Preferences.get doesn't return a string but a GetResult.
I can see that that's defined as { value: string | null }, so that's potentially a returned structure wrapping around JSON that you may have forgotten? https://unpkg.com/browse/<EMAIL_ADDRESS>

This is not my own package, I wrote you a package ?

Well, it is your package, in that you wrote a package that implements our Storage API 😅 You're free to do so and publish it of course, but submitting a PR (or a full package) to our repo means that you're asking us to maintain it.
That's why we have an RFC process for this: https://github.com/urql-graphql/urql/blob/main/CONTRIBUTING.md#how-do-i-propose-changes
Admittedly, I'll update it to make this more clear, but its intention is that if you're aiming to add a new feature, while we may choose to skip the RFC process, there's no guarantee that a change will be accepted.
That's why our PR template points out:

However, if you're starting to work on a large
change, it's best to make sure to open an issue first.

Hence the reason I was a little confused, since you were just asking for help with types, and your PR also doesn't follow our convention. So I was assuming, you were just asking for help.
However, if you're asking for this package to be merged into the repo, maintained by us, and published under this package name, I have to politely declien for now.
Of course it'd be great to have more storage adapters available for Graphcache. However, we can't maintain a larger number of them, and can't guarantee them all to continue working and accept issues for them, especially if we had no hand in writing them or understanding why they're important.
It's basically a maintenance burden that we try to avoid, because often the authors of these larger contributions (like yourself) are the better people to maintain these packages ✌

Hmm, now I get it. Actually I'm using it in capacitor right now and it works great. I thought it was easy for people to post directly here.
Iam not good on the testing vitest side. Key and value had to be entered there. That's why I asked for help. Otherwise the main code is working 99% of the time.


ImportError: DLL load failed while importing _cext: The specified module could not be found.

Hello its me again it seems im am cursed or  something
i tried installing ctk theme builder on another laptop and ran into a problem again (a different one though)
it installs just fine but when trying to run te program i get this Exception:
PS C:\Users\58147793\ctk_theme_builder> ./ctk_theme_builder
Traceback (most recent call last):
  File "C:\Users\58147793\ctk_theme_builder\\controller\ctk_theme_builder.py", line 10, in <module>
    from view.control_panel import ControlPanel
  File "C:\Users\58147793\ctk_theme_builder\view\control_panel.py", line 5, in <module>
    import utils.cbtk_kit as cbtk
  File "C:\Users\58147793\ctk_theme_builder\utils\cbtk_kit.py", line 12, in <module>
    from matplotlib.colors import is_color_like
  File "C:\Users\58147793\ctk_theme_builder\venv\Lib\site-packages\matplotlib\__init__.py", line 272, in <module>
    _check_versions()
  File "C:\Users\58147793\ctk_theme_builder\venv\Lib\site-packages\matplotlib\__init__.py", line 266, in _check_versions
    module = importlib.import_module(modname)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\58147793\AppData\Local\Programs\Python\Python312\Lib\importlib\__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\58147793\ctk_theme_builder\venv\Lib\site-packages\kiwisolver\__init__.py", line 8, in <module>
    from ._cext import (
ImportError: DLL load failed while importing _cext: The specified module could not be found.
PS C:\Users\58147793\ctk_theme_builder> ./venv/Scripts/activate
(venv) PS C:\Users\58147793\ctk_theme_builder> python --version
Python 3.12.3

i tried the solution from this stackoverflow answer (pip install msvc-runtime) but then i got the error:
ERROR: Could not find a version that satisfies the requirement msvc-runtime (from versions: none)
ERROR: No matching distribution found for msvc-runtime

theme builder setup log
theme_builder_setup_2024-05-24_21-05-42.log
python 3.12.3
windows 10 education
ctk_theme_builder 3.1.0

Hello @PimWagemans09. When you did the pip Install, did you source the virtual environment first?
venv\scripts\activate.bat

I did activate the venv before running pip and i installed the current latest version for windows from python.org

i just noticed the venv pip version is 24.0 evethough the version in get-pip.py is 22.3.1 i have not run pip install --upgrade pip
is this intentional?
also i now get a warning that i previously didnt when running theme_builder_setup.py:
Checking Python interpreter version...
WARNING: Python interpreter version, 3.12.3, is unsupported.
         Only Python versions between 3.8.0 and 3.11.99 are fully supported

The get-pip.py isn't intentional, and you can try upgrading pip.
Don't worry about the warning, it's a benign bug. 3.12 is actually supported.
I may struggle to reproduce this, as I only have Windows 11 these days.

Maybe some of the suggestions here might help:
https://www.partitionwizard.com/partitionmanager/the-specified-module-could-not-be-found.html

i tried reinstalling all the libraries is the venv as i didnt know wich one was causing the issue (and cleared the pip cache)
but that didnt help
and i checked the enviroment variables  which seem to be configured correctly including sys.path in the venv:
sys.path = [
    'C:\\Users\\58147793\\ctk_theme_builder',
    'C:\\Users\\58147793\\AppData\\Local\\Programs\\Python\\Python312\\python312.zip',
    'C:\\Users\\58147793\\AppData\\Local\\Programs\\Python\\Python312\\DLLs',
    'C:\\Users\\58147793\\AppData\\Local\\Programs\\Python\\Python312\\Lib',
    'C:\\Users\\58147793\\AppData\\Local\\Programs\\Python\\Python312',
    'C:\\Users\\58147793\\ctk_theme_builder\\venv',
    'C:\\Users\\58147793\\ctk_theme_builder\\venv\\Lib\\site-packages',
]
USER_BASE: 'C:\\Users\\58147793\\AppData\\Roaming\\Python' (doesn't exist)
USER_SITE: 'C:\\Users\\58147793\\AppData\\Roaming\\Python\\Python312\\site-packages' (doesn't exist)
ENABLE_USER_SITE: False

i also tried installing the visual studio c++ redistributables as mentioned here which didnt work and manually installing mvsc-runtime from a .whl file wich also didnt work due to the error:
ERROR: msvc_runtime-14.34.31931-pp38-pypy38_pp73-win_amd64.whl is not a supported wheel on this platform.

all other .whl files on pypi say they're for python 3.11 so i have not tried installing them

running the progam outside the venv (and installing the required packages) didnt work either

I can't say that I am surprised. The problem seems to be caused by an indirect dependency.

i tried from matplotlib.colors import is_color_like in the shell outside the venv  and that worked just fine so its something in the venv

i tried importing matplotlib inside a manually recreated venv and that also caused the error so its something with matplotlib in the  venv

i figured it out the fix was installing the visual studio redistrebutables but i made a mistake and downloaded the wrong version and didnt care to double check
sorry the inconvenience

No problem; pleased it's sorted.


Implement a simple CLI to dump requirement graph of a user

Summary
This PR implements a CLI that allows you to dump the requirement graph to the console. The tool itself isn't particularly useful since we already have a requirement debugger in the frontend. Its main purpose is to produce a starting point to do those requirement-graph-aware data migrations, since this tool shows how to query and build the requirement graph from the data using firebase-admin.
The implementation itself is very straightforward, since all the functions are already there. However, I do need to do some refactor to break the cyclic import between store, global-firestore-data and user-data-converter. The final dependency structure becomes

global-firestore-data
    |        |
    |       store
    |        |
user-data-converter

Test Plan

Running `npm run req-graph-dump [your email]` produces something like:
User Requirements:
  College-UNI-Physical Education
  College-EN-Mathematics
  College-EN-Physics
  College-EN-Chemistry
  College-EN-First-Year Writing Seminars
  College-EN-Computing
  College-EN-Introduction to Engineering
  College-EN-Engineering Distribution
  College-EN-Liberal Studies: 6 courses
  College-EN-Advisor-Approved Electives
  College-EN-Engineering Communications
  Major-CS-Introductory Programming
  Major-CS-Computer Science Core
  Major-CS-CS Electives
  Major-CS-CS Practicum or Project
  Major-CS-Technical Electives
  Major-CS-External Specialization
  Major-CS-Major-approved Elective(s)
  Major-CS-Probability
  Minor-MATH-Math Minor Prerequisites
  Minor-MATH-Four 3000 or 4000 level MATH courses
User courses:
  { uniqueId: 84, courseId: 352308, code: 'MATH 3110' }
  { uniqueId: 42, courseId: 352255, code: 'MATH 1910' }
  { uniqueId: 43, courseId: 352257, code: 'MATH 1920' }
  { uniqueId: 44, courseId: 352295, code: 'MATH 2930' }
  { uniqueId: 71, courseId: 352307, code: 'MATH 2940' }
  { uniqueId: 89, courseId: 351444, code: 'COGST 1101' }
  { uniqueId: 90, courseId: 354639, code: 'SOC 1101' }
  { uniqueId: 91, courseId: 352728, code: 'LING 1101' }
  { uniqueId: 92, courseId: 359378, code: 'ECON 2040' }
  { uniqueId: 93, courseId: 350281, code: 'ASIAN 2212' }
  { uniqueId: 69, courseId: 364536, code: 'CS 2112' }
  { uniqueId: 37, courseId: 358552, code: 'CS 2800' }
  { uniqueId: 38, courseId: 358556, code: 'CS 3110' }
  { uniqueId: 39, courseId: 358560, code: 'CS 3410' }
  { uniqueId: 40, courseId: 358595, code: 'CS 4820' }
  { uniqueId: 41, courseId: 358572, code: 'CS 4410' }
  { uniqueId: 54, courseId: 358569, code: 'CS 4110' }
  { uniqueId: 66, courseId: 358570, code: 'CS 4120' }
  { uniqueId: 58, courseId: 358571, code: 'CS 4121' }
  { uniqueId: 67, courseId: 358592, code: 'CS 4780' }
  { uniqueId: 68, courseId: 365294, code: 'CS 5114' }
  { uniqueId: 52, courseId: 350378, code: 'PE 1330' }
  { uniqueId: 53, courseId: 361736, code: 'PE 1657' }
  { uniqueId: 50, courseId: 369210, code: 'INFO 4998' }
  { uniqueId: 51, courseId: 369210, code: 'INFO 4998' }
  { uniqueId: 47, courseId: 368276, code: 'HIST 1200' }
  { uniqueId: 48, courseId: 368276, code: 'HIST 1200' }
  { uniqueId: 49, courseId: 354919, code: 'ENGRI 1220' }
  { uniqueId: -2, courseId: 358526, code: 'AP Computer Science A' }
  {
    uniqueId: -3,
    courseId: 355207,
    code: 'AP Physics C-Electricity & Magnetism'
  }
  { uniqueId: -4, courseId: 355146, code: 'AP Physics C-Mechanics' }
  { uniqueId: -5, courseId: 359187, code: 'IB Chemistry' }
Edges:
  College-UNI-Physical Education -> { uniqueId: 52, courseId: 350378, code: 'PE 1330' }
  College-UNI-Physical Education -> { uniqueId: 53, courseId: 361736, code: 'PE 1657' }
  College-EN-Mathematics -> { uniqueId: 42, courseId: 352255, code: 'MATH 1910' }
  College-EN-Mathematics -> { uniqueId: 43, courseId: 352257, code: 'MATH 1920' }
  College-EN-Mathematics -> { uniqueId: 44, courseId: 352295, code: 'MATH 2930' }
  College-EN-Physics -> { uniqueId: -4, courseId: 355146, code: 'AP Physics C-Mechanics' }
  College-EN-Physics -> {
    uniqueId: -3,
    courseId: 355207,
    code: 'AP Physics C-Electricity & Magnetism'
  }
  College-EN-Chemistry -> { uniqueId: -5, courseId: 359187, code: 'IB Chemistry' }
  College-EN-First-Year Writing Seminars -> { uniqueId: 47, courseId: 368276, code: 'HIST 1200' }
  College-EN-First-Year Writing Seminars -> { uniqueId: 48, courseId: 368276, code: 'HIST 1200' }
  College-EN-Computing -> { uniqueId: -2, courseId: 358526, code: 'AP Computer Science A' }
  College-EN-Introduction to Engineering -> { uniqueId: 49, courseId: 354919, code: 'ENGRI 1220' }
  College-EN-Engineering Distribution -> { uniqueId: 69, courseId: 364536, code: 'CS 2112' }
  College-EN-Liberal Studies: 6 courses -> { uniqueId: 93, courseId: 350281, code: 'ASIAN 2212' }
  College-EN-Liberal Studies: 6 courses -> { uniqueId: 89, courseId: 351444, code: 'COGST 1101' }
  College-EN-Liberal Studies: 6 courses -> { uniqueId: 91, courseId: 352728, code: 'LING 1101' }
  College-EN-Liberal Studies: 6 courses -> { uniqueId: 90, courseId: 354639, code: 'SOC 1101' }
  College-EN-Liberal Studies: 6 courses -> { uniqueId: 92, courseId: 359378, code: 'ECON 2040' }
  College-EN-Advisor-Approved Electives -> { uniqueId: -4, courseId: 355146, code: 'AP Physics C-Mechanics' }
  College-EN-Advisor-Approved Electives -> {
    uniqueId: -3,
    courseId: 355207,
    code: 'AP Physics C-Electricity & Magnetism'
  }
  College-EN-Advisor-Approved Electives -> { uniqueId: -2, courseId: 358526, code: 'AP Computer Science A' }
  College-EN-Advisor-Approved Electives -> { uniqueId: -5, courseId: 359187, code: 'IB Chemistry' }
  Major-CS-Introductory Programming -> { uniqueId: -2, courseId: 358526, code: 'AP Computer Science A' }
  Major-CS-Introductory Programming -> { uniqueId: 69, courseId: 364536, code: 'CS 2112' }
  Major-CS-Computer Science Core -> { uniqueId: 37, courseId: 358552, code: 'CS 2800' }
  Major-CS-Computer Science Core -> { uniqueId: 38, courseId: 358556, code: 'CS 3110' }
  Major-CS-Computer Science Core -> { uniqueId: 39, courseId: 358560, code: 'CS 3410' }
  Major-CS-Computer Science Core -> { uniqueId: 40, courseId: 358595, code: 'CS 4820' }
  Major-CS-Computer Science Core -> { uniqueId: 41, courseId: 358572, code: 'CS 4410' }
  Major-CS-CS Electives -> { uniqueId: 54, courseId: 358569, code: 'CS 4110' }
  Major-CS-CS Electives -> { uniqueId: 68, courseId: 365294, code: 'CS 5114' }
  Major-CS-CS Practicum or Project -> { uniqueId: 58, courseId: 358571, code: 'CS 4121' }
  Major-CS-Technical Electives -> { uniqueId: 66, courseId: 358570, code: 'CS 4120' }
  Major-CS-Technical Electives -> { uniqueId: 67, courseId: 358592, code: 'CS 4780' }
  Major-CS-Major-approved Elective(s) -> { uniqueId: -4, courseId: 355146, code: 'AP Physics C-Mechanics' }
  Major-CS-Major-approved Elective(s) -> {
    uniqueId: -3,
    courseId: 355207,
    code: 'AP Physics C-Electricity & Magnetism'
  }
  Major-CS-Major-approved Elective(s) -> { uniqueId: -2, courseId: 358526, code: 'AP Computer Science A' }
  Major-CS-Major-approved Elective(s) -> { uniqueId: -5, courseId: 359187, code: 'IB Chemistry' }
  Minor-MATH-Math Minor Prerequisites -> { uniqueId: 71, courseId: 352307, code: 'MATH 2940' }
  Minor-MATH-Math Minor Prerequisites -> { uniqueId: 43, courseId: 352257, code: 'MATH 1920' }
  Minor-MATH-Four 3000 or 4000 level MATH courses -> { uniqueId: 84, courseId: 352308, code: 'MATH 3110' }

Notes
Future applications:

graph-aware data migration script
typed firestore access for other firebase backend functions
integration tests of requirement computation on real data.

I'm getting this error when I run npm run req-graph-dump

I'm getting this error when I run npm run req-graph-dump

@hahnbeelee
The serviceAccount.json file is needed for cypress testing as well. You can find it on notion.

I'm getting this now. :/

@hahnbeelee The command should be npm run req-graph-dump [your email]. I updated the description.


HIVE-26448: Improve UnsignedInt128.setV*()

What changes were proposed in this pull request?
Currently, these method setV0, setV1, setV2 of UnsignedInt128 call updateCount directly.
The updateCount of UnsignedInt128 have a lot if ... else ... logic.
In fact, we can improve the code by judge count field of UnsignedInt128.
Why are the changes needed?
Improve UnsignedInt128.setV*()
Does this PR introduce any user-facing change?
'No'.
Just update the inner implementation.
How was this patch tested?
New test cases.

retest this please

cc @sunchao

Thanks, merged!

@sunchao @wangyum Thank you !


Login form

Required by/strictly related with #2

I added the login form to dev-Vina

and added routing

it can't run due to this.
But even removing that line this is what i see on the home

Login page works fine.
But about FileExplorer page i think that if user is not authorized should redirect to login page.
and there is a issue on top left corner.

it can't run due to this.
But even removing that line this is what i see on the home

Login page works fine.
But about FileExplorer page i think that if user is not authorized should redirect to login page.
and there is a issue on top left corner.

PS
There are a lot of warns, maybe the problem are caused by some of them?

src/components/FileExplorer.js
  Line 19:8:    'Delete' is defined but never used                   no-unused-vars
  Line 31:10:   'makeStyles' is defined but never used               no-unused-vars
  Line 45:7:    'drawerWidth' is assigned a value but never used     no-unused-vars
  Line 102:13:  Expected '===' and instead saw '=='                  eqeqeq
  Line 102:25:  Expected '===' and instead saw '=='                  eqeqeq
  Line 102:37:  Expected '===' and instead saw '=='                  eqeqeq
  Line 106:22:  Expected '===' and instead saw '=='                  eqeqeq
  Line 106:35:  Expected '===' and instead saw '=='                  eqeqeq
  Line 106:47:  Expected '===' and instead saw '=='                  eqeqeq
  Line 171:20:  'setSidebarOpen' is assigned a value but never used  no-unused-vars
  Line 172:1:   'useState' is assigned a value but never used        no-unused-vars
  Line 257:15:  'classes' is assigned a value but never used         no-unused-vars
  Line 286:11:  'api' is assigned a value but never used             no-unused-vars

src/components/Header.js
  Line 12:9:   'getUser' is defined but never used                                     no-unused-vars
  Line 96:34:  Comments inside children section of tag should be placed inside braces  react/jsx-no-comment-textnodes
  Line 99:70:  Comments inside children section of tag should be placed inside braces  react/jsx-no-comment-textnodes

src/components/HomeScreen.js
  Line 4:15:  'FormControl' is defined but never used         no-unused-vars
  Line 4:27:  'InputLabel' is defined but never used          no-unused-vars
  Line 4:38:  'Input' is defined but never used               no-unused-vars
  Line 4:44:  'Grid' is defined but never used                no-unused-vars
  Line 4:49:  'TextField' is defined but never used           no-unused-vars
  Line 4:70:  'ButtonGroup' is defined but never used         no-unused-vars
  Line 4:83:  'Button' is defined but never used              no-unused-vars
  Line 4:90:  'InputAdornment' is defined but never used      no-unused-vars
  Line 9:7:   'logoSpace' is assigned a value but never used  no-unused-vars

src/components/Login.js
  Line 2:9:    'useQuery' is defined but never used        no-unused-vars
  Line 2:18:   'useMutation' is defined but never used     no-unused-vars
  Line 2:30:   'queryCache' is defined but never used      no-unused-vars
  Line 28:5:   Duplicate key 'display'                     no-dupe-keys
  Line 78:10:  'error' is asesigned a value but never used  no-unused-vars

src/components/Router.js
  Line 1:10:  'useState' is defined but never used  no-unused-vars
  Line 6:2:   'Link' is defined but never used      no-unused-vars
  Line 7:2:   'Switch' is defined but never used    no-unused-vars

Hi Gian, I think the issues came from unused var which should be removed, I will try to refactor the code

@Janluke0, about the homescreen, I made it blue, because I don'to have any ideas yet to design the homescreen. Sorry about the file explorer, I edited directly on git in this part (added by Vina bla bla bla). To go to login page, just put /Login after the domain link. I want to reconnect between homescreen and login page, but as I mentioned above, if you have some ideas, maybe?

I made it blue, because I don't have any ideas yet to design the homescreen.

I remembered (from the pics you send on tg) that you did a white page with a blue button in the center so I thought that something happen anyway is not important.

To go to login page, just put /Login

yeah i saw it, it looks working fine.

if you have some ideas, maybe?

I think that a this point of the development the home could be the main page we are working on.

I made it blue, because I don't have any ideas yet to design the homescreen.

I remembered (from the pics you send on tg) that you did a white page with a blue button in the center so I thought that something happen anyway is not important.

To go to login page, just put /Login

yeah i saw it, it looks working fine.

if you have some ideas, maybe?

I think that a this point of the development the home could be the main page we are working on.

Ooh, yes, the image that I sent to the group? it was a react-native code, did you remember that I made for cross platform?as I don't have you and others replied, so I didn't use it. Do you ok, if I made just white, with a button in the center?

How you prefer, do the simplest thing, as i said it is not important.

Ok, make it simplest just nice to have, thanks :)
Best Regards,
Vina P.
give your best in every challenges.
On Tuesday, December 8, 2020, 12:02:28 AM GMT+7, Janluke0<EMAIL_ADDRESS>wrote:

How you prefer, do the simplest thing, as i said it is not important.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.


Refactor resource name to resource label for clarity

Work is related to manifoldco/engineering#8729
Reason for change
Everywhere in our docs we are using resource label for the slug we can use to fetch and resource name for the display name. In UI, resource name was the slug and the display name. That distinction has now been fixed and we should have a more clear standard when it comes to names and labels.
This PR also adds a new documentation page for how to create a fully connected resource details view with the components I have been creating.
Testing
Test with storybook and the docs

I remember talking about this with design, and treating resource name as the label going forward (i.e. not distinguishing them). I got the same sentiment from (I believe James) as well. Is that no longer the case?

I don't think that's the case at all, the pattern in GraphQL is to have a label (slug) and a displayName https://github.com/manifoldco/marketplace/blob/master/graphql/schema/product.graphql#L5. Our old pattern in REST was very similar with the label and name being the slug and the non-unique display value respectively.
It makes things very confusing to think of the resource's name as the label since names are now display names and are not unique. This get even more confusing when you think about the fact that fetched resources have both a name and a label https://github.com/manifoldco/ui/pull/257/files#diff-b4a3574eaa0ee363fc1cd18bdf94a008R64.
All our other endpoints, including the future graphQL endpoint, uses the label as the slug for fetching resources and the name as the displayName, not the name as both. This would make UI extremely inconsistent with our docs and other codebases.
Maybe the discussion was led by a bug in the gateway specs that made it ignore the name even though it was in the data returned by the endpoints? I have fixed the spec bug, but I still need to fix the same bug in the create resource endpoint on gateway.

Maybe the discussion was led by a bug in the gateway specs that made it ignore the name even though it was in the data returned by the endpoints?

I’m asking if you can verify with design & product on this. I’m telling you they made the call, and to check with them if they’re overriding that decision. It wasn’t an accident that everything is named resourceName consistently, even though yes it doesn’t match with our current API.