citrineos-core running failure in local system(macOS)

Which repository?

citrineos-core

Describe the bug
I am trying to run citrineos-core server, but facing multiple issues described below.
To Reproduce
Steps to reproduce the behavior:

Clone the citrine-core repo.
Install Node (v18.20.4)
Install NPM (10.7.0)
Install Docker(Docker version 24.0.5, build ced0996)
npm run install-all
npm run build
cd server
docker-compose -f ./docker-compose.yml up -d
npm run start

Expected behavior
CitrineOS-core server should be up and running according to the readme.
Screenshots
below screenshot is after 'npm run build'. Not sure whether its actually successful build or not:

below screenshot is after 'docker-compose -f ./docker-compose.yml up -d'

below screenshot is after 'npm run start'

MacOS version: 12.5

@thanaParis can anyone help on this setup issue please.

Hi @unaccepted !
It looks like there may be some issues with your local node environment. Here are some threads I found after searching for your errors on google:
https://github.com/nodejs/help/issues/3686
https://stackoverflow.com/questions/27541586/error-could-not-locate-the-bindings-file-tried-56
Following some of the advice above should help you get things set up correctly.
Both of these issues appear to be related to node-gyp. It may be you have an outdated version of it locally, or it was installed incorrectly. If problems persist despite the advice in the links above, I would consider making sure you start from scratch and reinstall the node dependencies.

Hi @thanaParis Thanks for the response.
I tried multiple times, even on another system. But I am getting same set of errors posted above.
Note that: I am using macOS and python3 version is: 3.9.6
Can you tell me the exact versions of node, npm, python3 to be used.
Also, do we need to change anything in the package.js or some other files to run it locally.

@thanaParis
Please find all the versions.

How to resolve this. This I am getting when hitting "docker-compose -f ./docker-compose.yml up -d"


Complex compounds aren't displayed correctly

Iron (III) carbonate is not displayed properly:

This is how it should look like:

The issue appears when there is a number behind the parenthesis, since cadmium cyanide is shown properly:

Just tried to see what's causing this bug. It's because of the way Typst parses parenthesis in a math environment. One way to solve it would be to add a space whenever a number and a parenthesis are together. It's not a perfect fix because it's not the way it should look.
This will be tricky to fix.

Another possibility is to close and open the math environment, like this: $"Fe"_2$$("SO"_3)_3$. But I'm not sure how that would interfere with the rest of the code.

Hi, i tried fixing this by adding the space as suggested, but it will affect the behavior for state of aggregation. For compounds like NaOH, it will no longer be possible to put the state in the subscript. This needs some more work.
  // on opening brackets...
   if _char_in.contains(regex("[\[({]")) {
     (_state, _out, _buffer) = (
+      "underscore": ("leading_punctuation", _flush_ce_buffer(_state, _buffer), " "),
       "_": ("", "", "")
     ).at(_state, default: ("leading_punctuation", _flush_ce_buffer(_state, _buffer), ""))
   }

Hi, i tried fixing this by adding the space as suggested, but it will affect the behavior for state of aggregation. For compounds like NaOH, it will no longer be possible to put the state in the subscript. This needs some more work.

Perhaps this can be solved requiring a space to be added between the compound and the state? I think it makes sense from a user perspective to type ce("NaOH (aq)") instead of ce("NaOH(aq)").


Bank Tab Data Blank

Hey guys,
I was able to get this app running on my iphone 6+ running the latest version of OS with no issues! Despite what the author wrote about the code being a mess I actually got errors or warnings while building the app so KUDOS to Richard for a job well done! The only thing that I found is that the Bank tab is empty, or atleast the view is. I was thinking this tab would be used for adding your Banks info to be able to send money to other players so I suppose a good question to ask here is this, is this app suppose to function as a "pay other people" app or just a UI template for a "pay other people" app? Thanks for the help!

Hey, as I said before, this is a project that I did when I started with iOS development and it is not supposed to be working extremely well.
Anyways, the "Bank" tab should be filled with the players after you add them in the "Add Player" tab. Make sure to pick a name, start amount of cash and a token for every player you add. After that, they should come up in the "Bank" tab. You can transfer money by tapping on the players in the "Bank" tab or in the "Transfer Money" tab.
The app should still work. It is made for managing money in games like Monopoly.
I hope I could help you a little, make sure to comment here if you need any help :)

Awesome! So it's more like a utility used when playing a game like monopoly? Pretty cool, I'll toy around with it a bit more and get back to you with my findings! Keep being awesome bro :)
Sent from my iPhone

On Feb 17, 2016, at 11:59 AM, Richard<EMAIL_ADDRESS>wrote:
Hey, as I said before, this is a project that I did when I started with iOS development and it is not supposed to be working extremely well.
Anyways, the "Bank" tab should be filled with the players after you add them in the "Add Player" tab. Make sure to pick a name, start amount of cash and a token for every player you add. After that, they should come up in the "Bank" tab. You can transfer money by tapping on the players in the "Bank" tab or in the "Transfer Money" tab.
The app should still work. It is made for managing money in games like Monopoly.
I hope I could help you a little, make sure to comment here if you need any help :)
—
Reply to this email directly or view it on GitHub.

Yes, it basically replaces cash in Monopoly.
Thanks, you too!

Sweet! Thanks again dude.
Sent from my iPhone

On Feb 17, 2016, at 2:11 PM, Richard<EMAIL_ADDRESS>wrote:
Yes, it basically replaces cash in Monopoly.
Thanks, you too!
—
Reply to this email directly or view it on GitHub.


Add Support for sidecar and init containers in Argo CD CRD for App Controller and API server

What type of PR is this?

/kind enhancement
/kind documentation

What does this PR do / why we need it:
Fixes #1476
Closes #1476
Have you updated the necessary documentation?

[x] Documentation update is required by this PR.
[x] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #1476
How to test changes / Special notes to the reviewer:

Added the unit tests to validate the feature.
TestReconcileServer_InitContainers
TestReconcile_SidecarContainers
TestReconcileAppController_Initcontainer
TestReconcileArgoCD_sidecarcontainer

I am yet to test it locally, but it looks good. The unit test coverage is solid. Do you think we need an additional e2e kuttl test?

Ran some local tests. Looks good.
I was wondering if we should include support for Volumes and VolumeMounts, similar to what is done for the repo-server. Certain use cases for sidecars aswell as init containers may require sharing mounts with the main container, which isn't possible without the option to configure additional mounts. Thoughts?


【容器管理】为全局服务集群的工作节点扩容中拷贝config.toml文件到火种节点，建议增加一步，确认runc的正确路径

Describe the bug

runc 路径命令 ： type runc
如果不同的话，需要替换到正确的路径
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '...'
Scroll down to '...'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

https://docs.daocloud.io/kpanda/best-practice/add-worker-node-on-global/

不明白啥意思，这条命令要加到哪儿的？

这篇文档产品已经调整过


Rectify public document for CMK for existing Cosmos DB account Azure CLI command is not working

Hi Team,
After testing our CMK for existing Cosmos DB account, found out the public documentation at command for part "Steps to enable CMK on your existing Azure Cosmos DB account with Continuous backup or Analytical store account" , steps 2 azure CLI command it is wrong or syntax error, can you please rectify it?
Ref doc:
Configure customer-managed keys on existing accounts - Azure Cosmos DB | Microsoft Learn
1. For System managed identity:
The correct Command should be like below as it does not allow to use SAMI identity url.
Public document command:
az cosmosdb update--resource-group $resourceGroupName --name $accountName --default-identity "SystemAssignedIdentity=subscriptions/00000000-0000-0000-0000-00000000/resourcegroups/MyRG/providers/Microsoft.ManagedIdentity/ systemAssignedIdentities/MyID"
Correct Command:
az cosmosdb update--resource-group $resourceGroupName --name $accountName --default-identity "SystemAssignedIdentity"
My lab example:
az cosmosdb update--name "cosmodbname" --resource-group "st-JP-resourceGroup" --default-identity "SystemAssignedIdentity"

2.For User managed identity : it is missing the “/” at the beginning of the subscription.
Public document command:
az cosmosdb update -n $sourceAccountName -g $resourceGroupName --default-identity "UserAssignedIdentity=subscriptions/00000000-0000-0000-0000-00000000/resourcegroups/MyRG/providers/Microsoft.ManagedIdentity/userAssignedIdentities/MyID"
Correct command:
az cosmosdb update -n $sourceAccountName -g $resourceGroupName --default-identity "UserAssignedIdentity=/subscriptions/00000000-0000-0000-0000-00000000/resourcegroups/MyRG/providers/Microsoft.ManagedIdentity/userAssignedIdentities/MyID"
Here is my lab example:

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e75b66ef-f651-a18b-2063-7fe3085f5264
Version Independent ID: 574e95a2-cb5c-bb81-d673-b795d5906bd2
Content: Configure customer-managed keys on existing accounts - Azure Cosmos DB
Content Source: articles/cosmos-db/how-to-setup-customer-managed-keys-existing-accounts.md
Service: cosmos-db
GitHub Login: @dileepraotv-github
Microsoft Alias: turao

@stella22-github
Thanks for your feedback! We will investigate and update as appropriate.

@stella22-github
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


Colour usage in code is not consis

How is colour defined in the app? I see colours defined in Assests.xcassets and AppStyle.swift. Both methods are used throughout the project. Can we stick with one? And put that in a readme doc?

Duplicate of #3492


pytesting animations

The plan is to use a combination of matplotlib's image comparison, and a custom movie saver from a stackoverflow answer by a mpl dev.
Additional, source.

This isn't quite finished


bug: 使用proxy-rewrite 插件添加regex_uri js报错

Issue description
使用proxy-rewrite 插件添加regex_uri js报错

Environment

apisix version (cmd: apisix version): 1.3
OS:  linux

Minimal test code / Steps to reproduce the issue

What's the actual result? (including assertion message & call stack if applicable)
What's the expected result?

you should report to https://github.com/apache/incubator-apisix-dashboard/issues

BTW, pls use English in public channel.


java-openliberty:  cache maven dependencies in stack image for codewind + (no-mount scenarios)

The command-line appsody user will use the mounts defined in the stack image APPSODY_MOUNTS envvar, mounting to the host ~/.m2.
However codewind's appsody integratoin doesn't use these mounts.
To the CLI user, it doesn't make too much sense to aggressively cache, inside the stack image, the maven dependencies the stack will likely use, since the host .m2 will be bind mounted over this anyway.
However, for codewind we would benefit from doing something like we do in appsody build with the preload-m2-pom.xml file.
Or we might ultimately decide not to, not to make the image any bigger...but worth looking into.

Another issue and PR that relates to this is https://github.com/appsody/appsody/issues/895

A challenge here is that the stack encompasses apps starting from all templates (and non-template apps)... so a cache highly-focuses on say default template could add unused bloat for another template.


Can not view the converted Markdown result

After I upload the pdf file on the https://pdf2md.morethan.io/, I can not view the converted result.

Hey, Its working for me
Can you share the pdf if you don't have an issue?

Im having the same exact issue with a rather big pdf (124 mb), cant share it due to size limitations.

@jaxis Can you open the inspector and copy-paste any error which are printed there ?

Like me, I have submitted an issue

me too
https://github.com/jzillmann/pdf-to-markdown/issues/66


chore(skip): integrate Skip's mev-tendermint into the core binary

In this PR
As discussed before, this is a draft PR to integrate Skip's mev-tendermint replacement for normal Tendermint into the core binary. This PR does not change any requirements for validators and using Skip is strictly opt-in by adding their credentials into config/config.toml. On releases that change the Tendermint version, the replace statement also has to be modified with the according version.
Questions

Should we add this into the go.mod file or should it be added into the build process instead (go mod edit -replace in Dockerfile and Makefile)?
Should this be merged in the main branch or in a future release/v14.0.x branch?

@Zygimantass it should be in the go.mod as you have done. Thanks
Main is the current v14 branch. After the proposal is on chain & passes we can merge this & I'll backport to v13

Hi @Zygimantass -- will you be making a mev-comet?
This is pretty key here, sdk v0.45.15-rc.0 uses comet

Yup, @faddat we'll rebuild with comet and update the PR

Closing for a future PR.


Allow all parameters of model.plot to be specified per lineage.

[ ] Additional function parameters, change functionality or change defaults?
[ ] New estimator in cr.tl.estimators?
[ ] New kernel in cr.tl.kernels?
[ ] New gene trend model in cr.ul.models?
[ ] New plotting function in cr.pl?
[x] Other?

Not only the time_range etc.

Too low of a prio right now (+ very niche). Closing this for now.


Custom color map popup broken

Commit:  http://higlass.io/app/?config=Wxxdw3aDTwyyx9TweoxWWQ
Steps to reproduce

http://higlass.io/app/?config=Wxxdw3aDTwyyx9TweoxWWQ
Try to open the custom color map

Observed behavior

Nothing happens 😱

Expected behavior

The color map dialog should open.  😶

Duplicate of https://github.com/hms-dbmi/higlass/issues/116


Fixed failing builds, removed Python3.5 support and Dependabot added v2 config

Summary

Dependabot added a V2 config file
Fixed the failing tests in the builds of Python 3.6, 3.7, 3.8
Removed Python3.5 support in favour of using fstrings which were introduced Python3.6 onwards (note: Python3.5 reached end of life on September 5th, 2020)
Test Plan (if any)

Checklist

[ ] I have tested this.

@renemarc Hi, I'm trying to learn how to contribute to open-source repositories. Found your repo on CodeTriage. I'm new to this so please let me know if I have made any mistakes or if I should doing things any differently. Looking forward to your feedback.


Change elasticsearch id to include inspector

This changes the ID used to look up single reports to be of the format "inspector"-"report_id". The indexing script is changed to match.
This fixes #5
(Deploying this change will require re-indexing the reports)

Nice, much-needed.

I'm not in a place where I can log into the server at the moment, but will re-index later on.


BUG: fetch vram data from local cluster

What do these changes do?

Related issue number

Resolves #351
Check code requirements

[ ] tests added / passed (if needed)
[ ] Ensure all linting tests pass

Do you think it's required to add a UT about this issue?


add EmbeddingBagPackedSum op and tests

We really want to avoid looping over tensors in C++ code wherever possible. And in particular looping for a number of iterations determined by a compute_shape call is worrisome. We want to do this logic in eDSL code so Tile & other MLIR optimizations are possible.
I think we could replace the core algorithm with something like the following to accomplish this:
  auto I_gathered = gather(I, indices);
  if (with_weights) {
    std::vector<int64_t> unsqueeze_axes;
    for (int64_t i = 2; i < I_gathered.rank(); i++) {
      unsqueeze_axes.push_back(i);
    }
    auto weights_expanded = op::unsqueeze(per_sample_weights, unsqueeze_axes);
    I_gathered = I_gathered * weights_expanded;
  }
  auto reduced = op::sum(I_gathered, edsl::make_tuple(1), false);
  return edsl::make_tuple(reduced);

Great! This code snippet is very concise and elegant! Thank you for pointing this out.
As for  #100, there's a parameter offsets defining variadic length of chunks(or the term segments?) very similar to #91 which makes it a bit more complicated. I'm not sure whether looping for a number of batch determined by offsets.size() can be avoided too. I will update the code for review later.


Linked push button with double, tripple and long push report

Hello,
I would like to use this firmware inside a wall push button, between the buttons and lamps, to be able to control the lamps through the button or zigbee, but also get zigbee reports on double, tripple and long presses, without affecting the connected lamp.
Would it be possible to link an output only on the simple push when selecting double, tripple and long ?
Thanks

@Arthuret Could you please test the latest version where I've added this feature?


Composition of pointwise optimization passes

Right now pointwise optimization passes are very general and I believe they can end up having non-local effects.  However there are lots of optimization passes that literally just work on gate replacement patterns.  This set of optimization passes has the nice property that this local changes can be composed.  If we create such a type of optimization pass we could avoid places where we make multiple passes on the data.

There is no "optimizer" abstract class anymore.
In places where we just do additions, we could chain these together.  This would not have impact on the overall runtime.  It could potentially be easier to reason about, but on the other hand the ordering even of replacements matters, so it's not clear that this would have benefit.
Closing unless we see compiler patterns that make more sense.  Then it would be better to create an issue with details of the idea.


Submit Priv Check not including Publications

https://github.com/hubmapconsortium/ingest-api/blob/d04106f3fb3114cfc8e57044fc8ddd06759b80f9/src/app.py#LL1146C11-L1146C11
https://github.com/hubmapconsortium/ingest-api/blob/d04106f3fb3114cfc8e57044fc8ddd06759b80f9/src/app.py#L1270
Seems as though Publications are not being included with superclass Datasets when checking permissions; Returns false on publication entities that should be true

@BirdMachine @shirey we had released the Publications work, it seems this issue has not been addressed accordingly. Can you verify and confirm?


Improve mutations docs

Description
Add a paragraph to mention how to return a union of types in mutation in 'Dealing with errors' docs.
Also, change a bit the first paragraph to sound a bit more 'fluent' but I can revert if you like more the older version :)
Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[x] Documentation

Issues Fixed or Closed by This PR

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Thanks for the contribution @estyxx . I've invited you to the Strawberry GraphQL organisation and feel free to request a (free) sticker here: forms.gle/dmnfQUPoY5gZbVT67


Link to Learn More of virtual workspace leads to Bing website

Issue Type: Bug

Open Code-Insiders
A notification will appear on the screen with "Manage Trust" and "Learn More" links.
[Notification Message]
Some features are not available because the current folder is backed by virtual file system and is note trusted. You can trust this folder to enable some of there features."
Click "Learn More" link.
The browser automatically launched and displayed the Bing site (https://www.bing.com/?ref=aka&shorturl=vscode-virtual-workspaces)

VS Code version: Code - Insiders 1.57.0-insider (fe1eafc80c07608de52a2f9c99fee103dea77f5e, 2021-06-04T12:19:25.391Z)
OS version: Darwin x64 20.5.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz (8 x 2700)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
4, 3, 2

Memory (System)
16.00GB (0.07GB free)

Process Argv
--crash-reporter-id 24e3eab7-335d-452f-bf6a-00d061debdb0

Screen Reader
no

VM
0%

Extensions (9)

Extension
Author (truncated)
Version

vscode-pull-request-github
Git
0.26.0

gc-excelviewer
Gra
3.0.42

vscode-language-pack-ja
MS-
1.57.0

remote-containers
ms-
0.182.0

remote-ssh
ms-
0.65.6

remote-ssh-edit
ms-
0.65.6

remote-wsl
ms-
0.56.4

vscode-remote-extensionpack
ms-
0.21.0

vsliveshare-pack
ms-
0.4.0

(5 theme extensions excluded)

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383:30185418
pythonvspyt602:30291494
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30291487
pythontb:30258533
vspre833:30267464
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscus158cf:30286554
pythonvsuse255:30303025
vscgsv2:30305091
vscorehov:30301224
vscod805:30301674
vscextlang:30310088
vsccppwt:30312692

Add the screen shot

I think PR #125512 by @aeschli means that this banner no longer appears, in which case the issue can be closed.

Yes, we no longer use the banner for virtual workspaces.


:memo: Update incorrect class reference

Hi,
please see #6 for more details.

Thank you. This has been renamed correctly to DotenvVault.


Update to latest open release

Test and update to Aras 11 SP12.

Tested and working on 11 SP12, SP15.


Incorrect file permissions of the stored jsctl config & auth data

I executed

jsctl auth login
jsctl config set organization xxx

as a result, I see that the config and auth data are store on the file system with 644 permissions. This is insecure. At most, the permissions must be 600.
https://github.com/jetstack/jsctl/blob/d57485d1c52b4bebb4b001f07e332d92c0024a71/internal/config/config.go#L96
Also, consider

opening/writing files with symbolic link check. This is to avoid symbolic link attacks.
do not load configuration/auth data if the file permissions are too open.

https://github.com/jetstack/jsctl/pull/47 should address this 🤞


Error message while calculating CRISPR score on new data from Sita

Error in lm.fit(x, y, offset = offset, singular.ok = singular.ok, ...) :
0 (non-NA) cases

I think I'm wrong. This is happening in the genetic interaction score calculation step. Sorry

Tracing the NAs, and I think the NAs are originating somewhere in the CRISPR score calculation.


feat(home-manager): init mako module

Adds support for mako. Resolves #16.
I also took the liberty of adding a helper function, fromINI, to lib.

ty! 🎉


Add MySQL version and SQL_MODE to environment information

What about adding this information to the /dashboard/system/environment/info dashboard page and to the c5:info CLI command?
Sample output of the c5:info CLI command (notice the new # Database Information section):
# concrete5 Version
Installed - Yes
Core Version - 8.5.2a1
Version Installed - 8.5.1
Database Version -<PHONE_NUMBER>3300

# Database Information
Version - 5.7.24
SQL Mode - NO_ENGINE_SUBSTITUTION

# Paths
Web root - /path/to/concrete5
[...]

This will be helpful.


How to use impureEnvVars

Issue description
I'm trying to propagate http_proxy environment variable from the calling user environment to the builder environment.
Unfortunately, in the builder environment, I'm not able to get back this variable.
Steps to reproduce
I run
export IMPURE=iop; nix-build -E 'with import <nixpkgs>{}; stdenv.mkDerivation {name="impure"; phases=["buildPhase"]; impureEnvVars=["IMPURE"]; buildPhase="env | grep IMPURE";}'

I get the following output
these derivations will be built:
  /nix/store/dmyqgk19r871adr4a29q3cjkxrbgwkdz-impure.drv
building path(s) ‘/nix/store/gqhbrlw9hjp6mm77zg5rmb6044xq4dby-impure’
building
impureEnvVars=IMPURE
buildPhase=env | grep IMPURE
builder for ‘/nix/store/dmyqgk19r871adr4a29q3cjkxrbgwkdz-impure.drv’ failed to produce output path ‘/nix/store/gqhbrlw9hjp6mm77zg5rmb6044xq4dby-impure’
error: build of ‘/nix/store/dmyqgk19r871adr4a29q3cjkxrbgwkdz-impure.drv’ failed

where I would expect to see IMPURE=iop in the builder env.
Technical details

System: (NixOS: nixos-version, Ubuntu/Fedora: lsb_release -a, ...)
Nix version: (run nix-env --version)
1.11.8 and 1.11.13
Nixpkgs version: (run nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion)
17.09pre-git
nixpkgs commitID f7ae955bc2d6ab74ff396f2be14e42a712dba61c
Sandboxing enabled: (run grep build-use-sandbox /etc/nix/nix.conf)

If you're using the Nix daemon, then this will not work, since the build will inherit environment variables from the daemon, not from the client.

With nix 1.11.13, I'm not using the daemon:
export IMPURE=iop; NIX_REMOTE='' nix-build -E 'with import <nixpkgs>{}; stdenv.mkDerivation {name="impure"; phases=["buildPhase"]; impureEnvVars=["IMPURE"]; buildPhase="env | grep IMPURE";}'
these derivations will be built:
  /nix/store/w6sqvd17f475g0pjl5a3sb8d15pf41xk-impure.drv
building path(s) ‘/nix/store/8y96bygg1xncd6vz75qc06fj4b7n48k6-impure’
building
impureEnvVars=IMPURE
buildPhase=env | grep IMPURE
builder for ‘/nix/store/w6sqvd17f475g0pjl5a3sb8d15pf41xk-impure.drv’ failed to produce output path ‘/nix/store/8y96bygg1xncd6vz75qc06fj4b7n48k6-impure’
error: build of ‘/nix/store/w6sqvd17f475g0pjl5a3sb8d15pf41xk-impure.drv’ failed

I also try to run the daemon from a shell where this variable is exported and it doesn't work better.

Another element is that I successfully used fetch_url in the same http proxy environment. So, the propagation of this variable works well with in the fetch_url expression but not in my buildPhase.

I think there is a bug in the first example. You're not creating $out. Try this:
export IMPURE=iop; nix-build -E 'with import <nixpkgs>{}; stdenv.mkDerivation {name="impure"; phases=["buildPhase"]; impureEnvVars=["IMPURE"]; buildPhase="env | grep IMPURE > $out";}'

@bjornfor yes. Sorry, i let this bug  since I was only interested by the build phase output.
@bjornfor do you have the IMPURE varaible in the output?

Sorry, that's my bad...
In the documentation of impureEnvVars, it is written it only works with fixed-output derivations... which is not the case of mine.
RTFM.

@nlewo it still doesn't answer the question how I can test derivation, that using impureEnvVars, with nix-build, i.e. how to pass IMPURE env variable to nix-buid


My checker file is empty

I have tried to implement some of the demands and my output file in the checker is empty. Trying the commands localy yielded the same results for the demands I have tried to implement.
My results on the checker

My results locally

robot.s contents

Can you give me guidance please?

Please don't forget to use \n and not \r\n when parsing.
Don't do like me:)


Fix match to use fastlane_core keychain_importer

This will fix #6866.
Depends on #6932 being released.
PR 3 of 3 🎉

Does that mean people have to provide that password by default now when using gym?

If so, is that also the case for Xcode itself?

No, you don't have to provide the password... On Sierra, when you don't provide the keychain password when running match, a popup will show up the first time when you are using gym to build the app asking if codesign is allowed to use the private key. This is not desirable for CI, so when you provide the password the popup will not appear.

Alright, that makes sense, thanks for clarifying 👍


rabbitmq connector  appsettings.json host ip config is not working

Describe the bug
rabbitmq connector  appsettings.json host ip config change is not working.
it still use <IP_ADDRESS> and will throw an error

Steps to reproduce
Steps to reproduce the behavior:

do as the tutorial says :https://steeltoe.io/service-connectors/get-started/rabbit
change the host ip from <IP_ADDRESS> to <IP_ADDRESS> which is my vm ip (centos)

  "rabbitmq": {
    "client": {
      "host": "<IP_ADDRESS>",
      "port": "5672",
      "username": "guest",
      "password": "guest"
    }
  }

Expected behavior
host ip change should be working
Environment (please complete the following information):

Platform: local
OS: Windows
.NET Version .NET Core3.1 / 2.2
Steeltoe Version 2.4.0
Any other library versions to note

Screenshots

See the code : https://github.com/wswind/Steeltoe-Sample/tree/master/04.RabbitMQ/MyCompany.SteeltoeExample

This appears to be a mistake in the tutorial - the property should be named server not host


intermittent error: Uncaught ReferenceError: jQuery is not defined

Configuration:
Uncaught ReferenceError: jQuery is not defineduser-agent: Mozilla/5.0 (Linux; Android 8.1.0; SM-J530F) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.157 Mobile Safari/537.36;
screen: 360;x;640;

this error is seen most often on iPhone Safari browser, in spite of the user agent seen above
PDF.js version: Yii2, version 1.0.2

invoked by code that looks like this:
registerCss("
body {margin:0px;padding:0px;overflow:hidden;}
iframe {overflow:hidden;height:100%;width:100%}
.container {overflow:hidden; width:100%; padding:40px 40px; position:absolute;top:0; left:0; right:0; bottom:0;}
@media only screen and (max-width: 768px) {
.container {padding:0px;}
}
");

$errorStyle = $error?"":"display:none; ";
?>
 top: 20%;">
    Document not available right now, check back again a little later

 0) { ?>
<?= \yii2assets\pdfjs\PdfJs::widget([
    'id'=>'preview',
    'width'=>'100%',
    'height'=>'100%',
    'url'=> $url,
    'buttons'=>[
        'presentationMode' => true,
        'openFile' => false,
        'print' => true,
        'download' => true,
        'viewBookmark' => true,
        'secondaryToolbarToggle' => true
    ]
]); ?>

<script type="text/javascript">
    setTimeout(function() {
        showError();
    }, <?= $until ?>*1000);

    function showError(event) {
        document.getElementById('preview-error').style.display = 'inline-block';
        document.querySelector("#pdfjs-form-preview").remove();
    }
</script>

Steps to reproduce the problem:

Just happens some of the time, no clear patter, when bringing up an image to view

Uncaught ReferenceError: jQuery is not defined

Considering that the PDF.js library isn't using JQuery, it's quite frankly very difficult to understand how this could be a valid PDF.js bug.

PDF.js version: Yii2, version 1.0.2

According to Google "Yii2" is a PHP framework, meaning that it's not related to the PDF.js project (which is written in JavaScript) and we consequently cannot provide support for it.
Also, the version number above doesn't look right, please find the latest PDF.js releases at https://github.com/mozilla/pdf.js/releases
All in all, this doesn't seem to be a bug in the PDF.js library; please also see https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us on the IRC channel -- keep in mind that just code snippets won't help us troubleshoot the problem.


EndpointSlice concept prioritised ahead of Service

This is a Bug Report

Problem:
https://kubernetes.io/docs/concepts/services-networking/ lists the EndpointSlice concept before Service.
Although the Service page needs work, the current page about Service should come before the page about EndpointSlice, which is still beta and only partly activated by default.
Proposed Solution:
Revise the EndpointSlice page to have a weight that is higher than the Service page. See https://github.com/kubernetes/website/blame/55ee59477ec2b82df778b16e4293ecc89bdacdb3/content/en/docs/concepts/services-networking/endpoint-slices.md#L11 for the line that needs tweaking.
Page to Update:
https://kubernetes.io/docs/concepts/services-networking/endpoint-slices/

Kubernetes Version:
v1.17
Additional Information:
/language en
/good-first-issue

This is a good first issue; if you've already had a pull request or two merged, I recommend leaving this one so that it's saved for a new contributor.

@sftim Thanks for triaging with an eye for new contributors! 🌟

@rahulrai-in are you working on this issue? if not I would like to take this.
Please let me know

@ashishsingh2k8 I planned to work on it during my break but couldn't find much time to tend to it. Please feel free to take this up. I will circle back to this issue on March 1 when I have some capacity to spare. Thanks.

/assign

Hi, @ashishsingh2k8 I am back from my holidays. Are you still working on this issue or would you like me to take it forward? Thanks.

You please take it,
Sent from my iPhone

On 01-Mar-2020, at 2:30 PM, Rahul Rai<EMAIL_ADDRESS>wrote:

Hi, @ashishsingh2k8 I am back from my holidays. Are you still working on this issue or would you like me to take it forward? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

/priority important-longterm

@prasadkatti I noticed you were just working in this area - would you like to pick this issue up as well?

Sure. :)
On Thu, Apr 2, 2020 at 3:28 AM Tim Bannister<EMAIL_ADDRESS>wrote:

@prasadkatti https://github.com/prasadkatti I noticed you were just
working in this area - would you like to pick this issue up as well?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/website/issues/18628#issuecomment-607760402,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYBIYMT2F2P7A2PJNN2NY3RKRSEFANCNFSM4KFTLD2A
.

/assign
On Thu, Apr 2, 2020 at 9:42 AM Prasad Katti<EMAIL_ADDRESS>wrote:

Sure. :)
On Thu, Apr 2, 2020 at 3:28 AM Tim Bannister<EMAIL_ADDRESS>wrote:

@prasadkatti https://github.com/prasadkatti I noticed you were just
working in this area - would you like to pick this issue up as well?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/website/issues/18628#issuecomment-607760402,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYBIYMT2F2P7A2PJNN2NY3RKRSEFANCNFSM4KFTLD2A
.


Can't pass several build flags

When using the build task (and possibly others) and supplying -ldflags (and presumably also -asmflags, -gccgoflags, -gcflags, -tags and -toolexec, all of which accept a quoted list of values), the plugin is unable to parse the command line, presumably because the command is being space-delimited.
The command being run is:
go install -ldflags '-X main.version=112 -X main.buildID=ABC-112' ./cmd/exename

but the error indicates that the string inside the quotation marks has been incorrectly split:
invalid value "'-X" for flag -ldflags: unterminated ' string

Using " instead had the same effect, and attempting to escape the spaces with \ also did not work.

@handcraftedbits If my issue is a duplicate... any idea what's causing this and plans to fix it?

It's because the current commandline parser just does a simple string split on spaces.  Really it needs to know about all the flags that go build/install/test/etc. handle and split appropriately.  That's a decent amount of work and I just haven't had the time to dive back into this project lately.

Could you just pass the whole kit and kaboodle to the go command line and call it a day? The command line tool already knows how to parse its own arguments, in theory.


expand wiki

[ ] explain mod.json
[ ] explain mod dependencies and priority
[ ] explain YAML (yml) patches
[ ] explain expression DSL in yml patches
[ ] explain texture asset overrides
[ ] general explanation of dw2bm and direct to that wiki

Hey there, my dad plays this and I am a (mainly) .NET dev. I've managed to get a C# mod running yesterday evening by looking through the code and try-and-error and could provide some starting wiki (from my point of view). I want to build a cli tool that parses the DSL for a overview of changes, so I will look into the DSL/YAML, anyways.
Could you provide a starting point or some "please do it this way" how you intend to fill the wiki or where to look for the information at best (besides just searching in the C# projects/classes like the .Dsl.DslBase).
Maybe this could also be improved by explanation and assertion through unit tests (parse YAML/DSL - examples)?
I see a starting point but no real test yet.

I need to generate some YAML/JSON schema first, then generate some stuff for the DSL. I created another issue to track that.
You'll probably need to browse the metadata in the reference assemblies in ref/ to locate the types handled by content patching YAML, you can find those types referenced in [Todo: edit comment with line ref]. The syntax for the DSL is mostly defined in DslBase.
Thanks for your time and support.

I'll get some DSL tests going at some point. :)

@Tyler-IN This wiki page seems redundant, remove?
https://github.com/DW2MC/DW2ModLoader/wiki/YAML-syntax-and-why-you-keep-getting-errors-on-loading.
YAML syntax and why you keep getting errors on loading.
The same is written here (with better format):
https://github.com/DW2MC/DW2ModLoader/wiki/How-for-format-your-YAML-files
How for format your YAML files

Okay, I think I've messed something up (sorry in advance). I did not think that the wiki page was public to edit/delete and thought it would prompt me to "create a pull request" like for all other changes in GitHub (and other projects don't even have the delete button).
I have accidentally deleted the referenced wiki page. I still have the content (backup on my device) if removing the page was not wanted. As stated above I think the page was redundant but please tell me should I recover/recreate the page?

It's fine. The duplicate was me trying to help with syntax by reformatting as an example.

The schema currently links to pages that don't exist in the wiki, starting an initiative to flesh it out.

The schema currently links to pages that don't exist in the wiki, starting an initiative to flesh it out.


Error in Installation from source.

In Ubuntu 16.04 and Go 1.10,
I run:
go get -u github.com/gtfierro/hod

I get:
go build github.com/gtfierro/hod/turtle: invalid flag in #cgo CFLAGS: -L/home/jbkoh/go/src/github.com/gtfierro/hod/turtle
# github.com/immesys/bw2/crypto
In file included from ed25519.c:19:0:
ed25519-randombytes.h:83:26: fatal error: openssl/rand.h: No such file or directory
compilation terminated.

so, I installed libssl-dev, and I get:
go build github.com/gtfierro/hod/turtle: invalid flag in #cgo CFLAGS: -L/home/jbkoh/go/src/github.com/gtfierro/hod/turtle

Looks there is some typo in the installation script.

This is an issue that was introduced due to changes in cgo for go 1.10 (https://github.com/golang/go/wiki/InvalidFlag). I haven't had time to fix it yet, but you should be able to compile fine using Go 1.9.x

Thanks!

https://github.com/gtfierro/hod/commit/b332a8463e53fc52265576c0d43c2b9675097c90
When you get a chance, can you try building Hod with go 1.10 on the latest commit?

This is fixed


1.3.16

1.3.16

Coverage decreased (-0.9%) to 92.046% when pulling a0992042a923a360ba9adc8a5c4867e98be8e9ee on development into e78000d8558d2bb1ea506626817ca85678242d50 on master.


When changing name/removing already "connected" nodes, error messaging fills the log

This has no actual impact on the functionality, but the extra error lines printed on log every time I updated an already connected dialogue node is annoying.

I get this too. It triggeres without me necessarily doing something. Possible has something to do with the current state of my dialogue.json.

I created an issue on the Godot repo. Apparently the issue has already been fixed and will be out in an upcoming 4.2 release

hey @adrientremblay thanks for working on this.
It may take me a second to figure out your merge request haha..
I'll get back to this issue and your merge request soon.

it does appear, the issue with log error when changing connected node name is fixed.
However, the "deletion" still triggers it.
I believe it is because there are other parts of the code that still uses "to" as well instead of "to_node"
will correct.

Found that manually "disconnecting" connection when also "queue_free" on the graph nodes would result in "node not found" error. Making changes to skip the manual "disconnection" of nodes when "deleting" a node.

verified issues are fixed in dev branch. Will go out to main branch in the next major update.


Forgot passcode option required

how did i miss that 😨

@ASN-BitHyve @summikhan11
There is no technical solution to this yet.
Moving it to 2.2


All-terrain Vehicle (Trail, access point)

Related to this issue.
HFC extended, in-house set:

I wonder if there are NPS trails that would allow motorcycles but exclude ATVs? In any case, I think having the symbol gives us flexibility. I'm still curious about potential applications down the road.

Source SVGs have been added to my branch, preview the 16px black version here.


Number of elements in trie

Hi, I am not sure whether there is a method in the trie that returns the number of elements in the trie. Is there?

You could search for "" and count the iterator.

Maybe it would be best to add a counter in the Map struct? Like in a Vec.

I don't see the use case where knowing the size in O(1) time is worth it. You generally don't want to reify it, so it's not like you need to know to preallocate. Most searches will always be a different size but it would represent an upper bound. Is there a use case you had in mind?

Generally speaking, I would expect the length of a set to be an O(1) complexity thing, especially since it only requires an usize. As a tradeoff time vs memory, it would seem worth it to me.

All right. Let's see it.

I will make a small pull request adding it after we finish merging #28

I've gone from hesitant to, "Yes, this is all good and makes sense."


Newly added test_network_utp hogs CPU and fails to finish

The test is currently here https://github.com/inetic/crust/tree/utp-network , I'll soon create a PR to add it into master (with #[ignored] for now), because CIs currently seem to fail for other reasons.
The test creates N nodes and exchanges K messages between them, if TCP sockets are used (test_network_tcp) then everything is OK, but when uTP is used, some connections are created and some messages exchanged, but then the test seems to freeze with CPU being used on 100%.
My theory is that there is a bug in the congestion control algorithm in rust-utp, so I'll now be working on creating a similar test against rust-utp itself to prove or disprove this theory.

Update: I created a test that creates a small local network here. The test fails, but a lot less often than our crust/utp-network test, suggesting there is a problem in both libraries.
When the rust-utp/test_network test is run the statistics I see are approximately as follows:
node count: 10; message count: 4: no failure
node count: 30; message count: 4: fails once in 5 runs
node count: 60; message count: 4: fails once in ~4 runs

The example I created above is slightly different to our usage and I now believe that is the reason it fails a lot less often. In the example the per node algorithm goes something like this:
n times do
    write
    read

While in Crust we make use of the timeout functionality we introduced, and the algorithm goes someting like this:
until (n reads) and (n writes)
    if less than n writes: write
    if less than n reads: read-with-timeout

If I modify the test_network example in rust-utp to use the timeouts, I can also reproduce the CPU hogging there. Suggesting the timeout implementation is not correct.

because CIs currently seem to fail for other reasons

now it's failing for the expected reasons: https://ci.appveyor.com/project/MaidSafe-QA/crust/build/1.0.395

because CIs currently seem to fail for other reasons

now it's failing for the expected reasons: https://ci.appveyor.com/project/MaidSafe-QA/crust/build/1.0.395

Nope, that seems like yet again different reason. Expected would have been (at time of writing the "because CIs currently...") that the test test_network_utp would fail. But since that comment, I made one fix here and it has been put into crate already (version 0.6.18).
The failure you linked to @vinipsmaker seems like is unrelated, but it is hard to tell since we've been merging failing PRs into master recently :-(
Today I was working on the network tests in rust-utp (here and here). As I mentioned yesterday, the one not using timeouts sometimes failed and the one which used timeouts failed much more often with CPU running on 100%. I found one bug which I fixed and now both versions of the test fail only rarely and it also seems to have fixed the CPU hogging.

Today I was mostly looking into Crust (not rust-utp), I tried running the crust_peer example with debug output on different droplets (network of size 20). Many instances worked flawlessly, and had established connections to all other nodes they were supposed to. But there were few which did not connect to all the other nodes. I traced the problem to the rust-utp/UtpSocket::connect(...) function where the error returned was SocketError::InvalidPacket, I think this suggest the rust-utp library has problem connecting over an unreliable link.
So I switched my focus back to rust-utp but this time with the netem on linux which (among other things ) helps emulate dropped packets. With this I was able to reproduce similar errors I saw on droplets so that is what I'll be working on next.
If someone wants to try it, here is how:
sudo tc qdisc add dev lo root netem loss 0.01%
cd <rust-utp>
cargo test test_network_no_timeout -- --nocapture
sudo tcp qdisc del dev lo root

(tomorrow I'll create simpler test than the network one)

Today I was working on the network tests in rust-utp (here and here). As I mentioned yesterday, the one not using timeouts sometimes failed and the one which used timeouts failed much more often with CPU running on 100%. I found one bug which I fixed and now both versions of the test fail only rarely and it also seems to have fixed the CPU hogging.

Commit https://github.com/inetic/rust-utp/commit/4832f19a1e79214fd3641b25ba2a89b2f689a6b7 makes a lot of tests from rust-utp fail. Reading Rust documentation we can spot that a 0-bytes read is used to signalize EOF, so it's most likely the error is on the rust-utp usage and not on rust-utp itself.
I did the following TcpStream test, which is the interface that rust-utp is most likely trying to mirror:
#[test]
fn vinipsmaker() {
    use std::net::{TcpStream, Shutdown};
    let mut stream = TcpStream::connect("<IP_ADDRESS>:8080").unwrap();

    stream.shutdown(Shutdown::Both);

    println!("{:?}", stream.read(&mut [0; 128]));
    println!("{:?}", stream.read(&mut [0; 128]));
}

And the output was:
running 1 test
Ok(0)
Ok(0)
test vinipsmaker ... ok

Therefore, an Err result is not the proper way to notify EOF and we should (1) revert this commit and (2) implement the solution elsewhere.

Regardless the bug we're hunting, upstream rust-utp has a bugfix for another bug and we should pull this commit later.

Therefore, an Err result is not the proper way to notify EOF and we should (1) revert this commit and (2) implement the solution elsewhere.

I submitted a PR to fix this issue on crust side and now I'll check if the CPU hog still happens. This commit was also reverted.
I verified the CPU hogging doesn't happen anymore. But as before, fixing this issue don't prevent the test to fail sometimes.

I've collected some stats running the test_network_no_timeout test from test_network branch a few times.

ok
err
hang

25
10
14

The "hang" column is very subjective, as I've considered a run as hunged anytime I got bored waiting (likely a time between 10s and 30s, but I didn't really measured my boring-ness). Anyway, I think we should run the test at least 45 times and no error should be raised from the rust-utp/UtpSocket::connect(...) call when we make any patch to rust-utp in a attempt to fix the error. So, as this error doesn't happen every time, this is the test to check if we fixed it, run the test 45 times and check no errors were raised.

I am not sure it's all possible but being able to run with rr (debugger) would allow replay when the hang happens?

I am not sure it's all possible but being able to run with rr (debugger) would allow replay when the hang happens?

I believe it'd. I remember trying before. But the problem is that the rust-gdb is quite annoying compared to gdb being used for C++ projects. I'd like to have a backtrace that isn't hidden all over macros that don't give line information when debugging Rust code.

Yes not easy, like debugging c++ templates in many ways. It would be interesting to see how this waterfall happens for rust as they seem focussed on ide integration which I assume will mean looking more at debugging. If anyone knows a way to tame macros when debugging then great.

After the rust-utp PR https://github.com/maidsafe/rust-utp/pull/8 merged, the crust service::test::test_network_utp test seems experiencing no hanging issue and doesn't see a failure either.
However, the time of completing the test is quite different, ranging from less than 5 seconds to over 30 seconds.

Regarding the hanging issue for service::test::test_network_utp, it is actually because of missing messages.
The PR https://github.com/maidsafe/crust/pull/437 has changed the testing code little bit so missing message won't cause the test hanging (but will still fail the test)

Wrap-up of today's investigation
I worked on top of the https://github.com/maqi/crust/tree/test_network_utp branch.
Tests would only pass if I removed this code. There would be a small chance (usually 1 out of 23) that the test would hang. I added some code to measure the hang cause and traced the problem to be non-received messages.
Adding a sleep between "this node is okay" and drop(service) didn't change hanging rate significantly, so it's unlikely that there is a race here preventing scheduled messages to be sent back.
I'm still investigating why there are messages that weren't sent back.

Summary of the works so far
This hanging issue turns out to be composed of two issues :
1, The failing of utp connection establishment and missing of exchanged msg
According to the work of Rust-UTP PR https://github.com/maidsafe/rust-utp/pull/8 , the test proves a failing rate at around : 0.005% when socket without timeout and 0.25% when socket with timeout.
However, according to the work of Crust PR https://github.com/maidsafe/crust/pull/437 , the test proves the crust level failing rate is around the same as the rust-utp when socket with timeout.
The previous testing code expects a 100% success and will HANG when not reach it. The updated testing code in the above two PRs will complete the test in case of failure happens.
Crust Issue https://github.com/maidsafe/crust/issues/439 has been raised separately for this part.
2, The crust CI builds on Windows will HANG after all tests get passed and completed.
This seems a long existing and shall be the original purpose of this issue being raised.
It has to be highlighted that even the service::test::test_network_utp has been logged as OK in the building log, the CI build still hangs as a whole on Windows OS (never seen it happen in Linux builds).
The test on rust-utp lib doesn't see such behaviour.
Will still use this issue as the main thread of the debugging work.

2, The crust CI builds on Windows will HANG after all tests get passed and completed.

It "smells" like a leaking thread problem. I'll focus on issue #1 (#439). Good luck.

I verified the CPU hogging doesn't happen anymore.

-- https://github.com/maidsafe/crust/issues/412#issuecomment-158321389
This issue was originally created to track the CPU hogging issue, but this issue has been fixed already.

1, The failing of utp connection establishment and missing of exchanged msg
2, The crust CI builds on Windows will HANG after all tests get passed and completed.

-- https://github.com/maidsafe/crust/issues/412#issuecomment-161249183

#1 (#439) has been fixed already.
#2 has a separate issue now: https://github.com/maidsafe/crust/issues/455

Gonna close this issue.


Grammatically updated the contribution part in roadmap.md

Describe your changes
I've changed a grammatical error of contribution in roadmap.md
Screenshots - If Any (Optional)

Issue ticket number and link
issue ticket number:   #643
link : [ ] [](https://github.com/kubescape/kubescape/issues/643)

Checklist before requesting a review

[x] My code follows the style guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have performed a self-review of my code
[x] If it is a core feature, I have added thorough tests.
[x] New and existing unit tests pass locally with my changes

Please open the PR against the dev branch (Unless the PR contains only documentation changes)

Fix has been merged


dotnet restore requires an argument to work

On my system the line RUN dotnet restore in some Dockerfiles requires the name of the project as an argument.

Fixed as part of #141.


rofi-emoji support in openSUSE

Hi dear developers,
Just wanted to ask if there anyway to add rofi-emoji to openSUSE repos? I've been using it in Arch for a long time ago and I really liked it, Thanks for your time.

That would have to be brought up with OpenSUSE's packager teams. Distributions pick packages to incorporate themselves, and use their own teams to deal with packaging and release management.
I will help any packager that would be interested in bringing this software to their repos, should it be needed. They can hit me up here on GitHub or send me an email at<EMAIL_ADDRESS>I'll close this issue as it's not something I can work on myself.
It seems like OpenSUSE have instructions on how to propose packages here: https://en.opensuse.org/openSUSE:How_to_contribute_to_Factory
Perhaps you could propose it to them? :)


Expand contributing documentation to include the Bio-Formats DEV jobs

These jobs will be active as soon as develop and dev_5_1 are split on the code
repository of Bio-Formats. This PR extends both the Bio-Formats and the
Documentation contributing tables/glossaries to list the new available jobs.

Looking at http://www.openmicroscopy.org/site/support/contributing-staging/ci-bio-formats.html
Four sections have broken enumerated list formatting (the #. is indented unlike for the rest).
Other than that it all looks OK to me.

Fixed - see https://www.openmicroscopy.org/site/support/contributing-staging/ci-bio-formats.html

Thanks looks good to merge to me.


Raise compile sdk level to 34

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Description
Raise compile sdk level to 34
Alternative(s) considered
NA
Type
Builds
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

getting the following error
RunTests

Incompatible model, 'panther', and version, '34'
Supported version ids for 'panther': 33
Total run duration: 0m  2s

> Task :engine:benchmark:execFlank FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':engine:benchmark:execFlank'.
> Process 'command '/usr/lib/jvm/java-17-openjdk-amd64/bin/java'' finished with non-zero exit value 18

* Try:
> Run with --info or --debug option to get more log output.
> Get more help at [https://help.gradle.org](https://www.google.com/url?q=https://help.gradle.org&sa=D).

updated pr to see if using a different model that supports api level 24 on firebase would fix this. thx @omarismail94

seeing a whole bunch of these errors

I think it's caused by the test apk for the instrumentation tests being targetted at a lower version. i'm going to try to raise that in the test options block of the data capture library and see if that works.


feat: make the open graph tags dynamic based on the base64 url

This PR addresses the issue mentioned in #224. I have added the following features in this PR.

The studio version I am testing on is hosted here: https://studio-studio-next.vercel.app. (I will switch this to Netlify deployment once we are able to resolve #1118)
The Image Generator service in charge of creating the dynamic image is hosted here: https://ogp-studio.netlify.app
The code for the image Generator service can be found here: https://github.com/helios2003/ogp-studio

Features Added

[x] Add a middleware that captures Open Graph crawler requests when they hit the website and rewrites the URL to the route api/crawler. This is done to serve minimal HTML when the crawler hits the page, reducing the chance of timeout.
[x] Parse the URL and send it to the Image Generator service to add the dynamic image.
[x] Show the default og:image if there is an invalid base64 string provided.
[x] Fall back on the usual behavior added in #1106 if there isn't a base64 string.

Todos

[ ] Address unusual behavior observed like Slack showing the default image even when the document is valid.

For example: if we go to https://studio-studio-next.vercel.app and use MQTT template, then the default behavior is observed instead of dynamic tags.
Sometimes, Slack crawlers arent able to detect the open graph image.

[ ] Figuring out why sometimes the dynamic og:image does not appear on site like Whatsapp.
[ ] Add additonal crawlers to the list.

cc : @smoya

Thank you for the review @KhudaDad414. I will add the suggested changes.

Also, I had a few questions:

Is it okay if I hardcode the popular social media site crawlers as I have done now or is it better if we use a library like https://github.com/monperrus/crawler-user-agents as suggested to me by @smoya.  The main problem I could think of is that by including all the potential sets of crawlers as mentioned in the repository we could be causing rewrites for nonopen graph crawlers as well which is not required. But @smoya mentioned that he does not expect other bots to use the query parameters like that of open graph crawlers.
Also, could you please let me know your thoughts on https://github.com/helios2003/ogp-studio and its code?

Is it okay if I hardcode the popular social media site crawlers as I have done now or is it better if we use a library like https://github.com/monperrus/crawler-user-agents as suggested to me by @smoya.  The main problem I could think of is that by including all the potential sets of crawlers as mentioned in the repository we could be causing rewrites for nonopen graph crawlers as well which is not required.

If you don't use a complete list of crawlers, you will end up facing issues like the one you mentioned:

Figuring out why sometimes the dynamic og:image does not appear on site like Whatsapp.

This is happening most probably because you are not considering Whatsapp User-Agent(s).

But @smoya mentioned that he does not expect other bots to use the query parameters like that of open graph crawlers.

AFAIK, indexer robots such as Google only follow links, meaning that unless there is a published link somewhere to a link such as https://studio.asyncapi.com/?base64=<base64_doc> or the variant with url query param, the parsing won't happen. In fact, it does make sense to do the parsing and return the proper title, description, etc to the results of such indexer bot request so it appears in the results (like google results).

Also, could you please let me know your thoughts on https://github.com/helios2003/ogp-studio and its code?

Will that work in a Netlify setup? I mentioned an alternative in case it doesn't in https://github.com/asyncapi/studio/issues/224.

Will that work in a Netlify setup? I mentioned an alternative in case it doesn't in #224.

Yes, it works. The service is currently hosted on Netlify: https://ogp-studio.netlify.app.

Additionally, I think we can include more statistics in the rendered image like # of operations

Okay, I will add it.

Added modifications:

Using a package for detecting crawlers.
Using sharp to optimize the image generation as mentioned here: https://nextjs.org/docs/messages/install-sharp.
Add the dynamic behavior for url query param as well.

The PR is ready for review @KhudaDad414, @smoya.

Also, I'm unsure if the middleware code I wrote is the best way to achieve this functionality. Any suggestions or improvements would be appreciated.

@helios2003 Are you planning to move the OG Image generator service (Netlify Edge Function) into this PR?

Maintainers, can you please review the PR? I have addressed all the comments above and included the unit tests. Additionally, I had to change the version of @asyncapi/converter after this commit: https://github.com/asyncapi/converter-js/commit/b3592ef21a288231871080945b0b7c53b70adb32.
I did not include these changes in the studio repository since we are soon switching to studio-next as the default version for studio based on this issue: https://github.com/asyncapi/studio/issues/1134

Some tests are still failing @helios2003

@Amzani the tests are failing in studio which I did not update as mentioned above.


Set report Page size as tooltip not working correctly, no category or data labels for the shape map with the new February 2021 Update

[Enter feedback here]
The process for using a tooltip is not the same as documented in this page. There is now a part in the page information tab that you have to click that says "allow use as tooltip". This does work

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 97cbbb3e-3916-4340-4ddc-67bf22159bf3
Version Independent ID: 5b620628-1c10-b0bb-bd4d-1fd229260ea1
Content: Using report tooltip pages in Power BI - Power BI
Content Source: powerbi-docs/create-reports/desktop-tooltips.md
Service: powerbi
Sub-service: pbi-reports-dashboards
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Hi @presidentecarter, sorry for the long delay. I see that the page has been updated, so I am closing this issue now. Thanks for reaching out!


How to stop retrying and throw the disconnect method when the Starscream return 404

same here, no error occurs if reconnectionStrategy differs from .none
the bug in func didDisconnect(_ error: Swift.Error?) and is related to RetryHandler - onDisconnected callback never called
sorry, no time to provide pull request


code_review:- add code based solution.

Add a field to provide updated code from the server

This has been added


Put nrpe pidfile dirctly into the usual run directory - Fixes #7

Hey,
this PR tries to fix #7 . As described there , the nrpe daemon can't be reloaded properly, because the pid file was not created. It seems nrpe is not creating the pid file if the directory does not exist. Unfortunately the init script does not fail and so it's not properly reported to the chef run. With this PR the pid file is put directly into the usual run dir (which should always exist) and not in a separated pid directory.

Well, the pidfile needs to point to path that appropriate system uses.
In my system, i found that i needed separate dir, because daemon runs as nagios user and that user can not write to /var/run, so i created /var/run/nrpe in my system.

which os/distro are you using? i'm using ubuntu 12.04 and only root can write to /var/run. Also nrpe runs as nagios user, but i think it creates the pid file still as root and afterwards does the daemon fork magic.

i run pld linux, but no, it fails to reload if using /var/run. the change itself is very old, so i do not have log. but i'm very sure it was during shutdown it was unable to remove pidfile with nagios user
https://github.com/pld-linux/nagios-nrpe/commit/ce845d3e4ec4488c37b2485ca92ffad3b8234af6
https://github.com/pld-linux/nagios-nrpe/commit/3c30292ce2a0479cea3f0b76e23ec503baae657e
https://github.com/pld-linux/nagios-nrpe/commit/6d1e0646a0de51e4d6f5773dff067a1175c723b1

ok, maybe it would make sense if the pid_dir is created within the init script? this script at least should run as root, so it will have the privileges to do so?

not knowing your system, but seeing  the diff, i would say if you stay with /var/run/nagios dir, it should work fine.
because:

/var/run/nagios dir seems to exist, and is likely writable for nagios user
recipe creates nrpe.conf which specifies where nrpe daemon writes the pid

also, recipe may add 'directory "/var/run/nagios"' resource (with proper nagios-writable permissions) if  the dir does not exist.

looked the PR diff again. you shouldn't modify 'freebsd' case, if you don't know or can test that system!

ahh ok, i'm running this cookbook with the source install method, then the /var/run/nagios does not exist for me. also after any reboot the /var/run directory is cleaned again. so even if chef creates the directory , i must ensure it runs after a reboot, which is not the case for me.
ok with the freebsd a totally agree

and for the fix for #7, are you sure debian initscript has "reload" action? maybe you need :restart instead?
# service nrpe reload
Usage: /etc/rc.d/init.d/nrpe {start|stop|restart|try-restart|force-reload|status}
# echo $?
3

this is from my system and it lacks reload, because nrpe daemon itself does not handle any signals

hmm so this cookbook provides an init script ... and it also supports the reload command https://github.com/schubergphilis/nrpe/blob/master/templates/default/nagios-nrpe-server.erb#L54

i assume you run /var/run as tmpfs and systemd? so you need systemd-tmpfiles configuration so the dir is created at boot.

if initscript comes from recipe, you can then mkdir in initscript in 'start' action. more universal than systemd config, i guess.
install -o nagios -g nagios -d /var/run/nagios

oo, it has signals support indeed. but test whether it actually reloads configuration?
# kill -HUP `cat /var/run/nrpe/nrpe.pid`
Aug  5 18:28:04 wintersunset nrpe[6463]: Caught SIGHUP - restarting...
Aug  5 18:28:04 wintersunset nrpe[6463]: Could not open config directory '/etc/nagios/nrpe.d/CVS' for reading.
Aug  5 18:28:04 wintersunset nrpe[6463]: Continuing with errors...
Aug  5 18:28:04 wintersunset nrpe[6463]: Server listening on <IP_ADDRESS> port 5666.
Aug  5 18:28:04 wintersunset nrpe[6463]: Listening for connections on port 0
Aug  5 18:28:04 wintersunset nrpe[6463]: Allowing connections from: <IP_ADDRESS>

Hi @5c077yP I am trying to fix the travis issues in this cookbook and going over all open PRs either failed in travis CI or did not even run Travis.
Do you think that this PR is still valid and required?

@snkutlu hmm, this PR is quite some time ago, let me think that through again

If you want to pick this up again, just raise a new PR. 👍


Menu icon only works if navigation drawer component is the root element

Version

react-native-router-flux v3.2.7
react-native v0.22.2, v0.23.0, v0.24.0-rc2
react-native-drawer v2.0.0

Expected behaviour
Creating a scene with a navigation drawer should create a hamburger icon for the menu.
Actual behaviour
A hamburger icon is only created if the menu is the root element.
Steps to reproduce
Working example:
<Router>
    <Scene key="main" component={NavigationDrawer} title="My Fancy App" type="replace">
        <Scene key="mainContainer">
            <Scene key="home" component={Home} />
            <Scene key="home2" component={Home2} />
        </Scene>
    </Scene>
</Router>

Non-working example (icon does not appear, but you can still swipe from the left to open the menu):
<Router>
    <Scene key="root>
        <Scene key="signIn" component={SignIn} type="replace" />
        <Scene key="main" component={NavigationDrawer} title="My Fancy App" type="replace">
            <Scene key="mainContainer">
                <Scene key="home" component={Home} />
                <Scene key="home2" component={Home2} />
            </Scene>
        </Scene>
    </Scene>
</Router>

Please check Example, Drawer is not root there, but works, right?

@codyhazelwood I think your problem is that you are rendering the navBar of the 'root' scene which doesn't have access to the Drawer context.
You should add <Scene key="root" hideNavBar={true}> and let the child render their own NavBar

Sorry for the late reply.  @aacotroneo Thanks a lot!  That fixes the problem.


fix(lib): typo in PHFetchOptions

:tada: This PR is included in version 1.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


21-issue: Update target frameworks and package references

Updated target frameworks to net9.0 and net9.0-windows7.0 in LauncherTest.csproj and launcherTests.csproj.
Upgraded MSTest.TestAdapter and MSTest.TestFramework to 3.6.3 in launcherTests.csproj.
Updated System.Security.Cryptography.Pkcs and System.Text.Json to 9.0.0 in Launcher.csproj.

Thanks @ahmdhjj   I'm mering the code.  The QL build failure is due to the QL not supporting .net 9.0  Will keep an eye and the next week or so and open issue if not resolved.


ActiveRecord::__get priority

Currently the activerecord implementation gives a higher priority to attributes (and relations) than it gives to setters and getters.
Often it is desired to overwrite an attribute (from the PHP point of view) using a getter and setter; since we can directly set an attribute using setAttribute.
Currently there are some issues with how writing to attributes is handled:

There are several places where the _attributes array is directly accessed, this means I cannot control it by overriding setAttribute (since that one gets bypassed in populate and __get / __set).

I cannot override a database field using getters and setters in my model, for example getCreated() to return a datetime object instead of a string. (Currently it can be done by using other names for the database field and the getter, but that is not desirable).

Some improvements could be made:

Only write to $_attributes via setAttribute.
Prioritize getXX and setXX over relations in magic getters and setters.

Currently ActiveRecord breaks a contract set by Object; from the docs:
    Object is the base class that implements the property feature.

That's OK.
Doesn't sound right. If you have the same name, it's conflicting anyway so it doesn't really matter what's preferred. It's not right anyway.

Why is 1 OK? Should I not be able to control what happens to my database fields?
How would I neatly implement type casting for example? (Not based on column type, but more generic, say I want integers in some field to be replaced with a value object, say, Meter).
To prevent / override reading / writing the database field directly I would have to override lots of function, reimplement ancestor behavior (since I want to skip BaseActiveRecord but I do want the Object getters / setters).

I mean change is OK.

1 . There are several places where the _attributes array is directly accessed, this means I cannot control it by overriding setAttribute (since that one gets bypassed in populate and __get / __set).

I am unsure it can be done, and unsure it should. It simply has no sense: these provides access to the raw database entity attributes, which are necessary while inserting/updating the record. There is nothing to change here.

I cannot override a database field using getters and setters in my model, for example getCreated() to return a datetime object instead of a string. (Currently it can be done by using other names for the database field and the getter, but that is not desirable).

This is not a correct way. If you override attribute access making some conversions on it. It will no way to save it actual value to database, especially if you insist on '1' implementation.
For example: imagine you have overridde getter for created_date in the way it returns DateTime object - so you are unable to get actual database value of it on 'insert' or 'update' operation, because $this->created_date always return object, while it should be integer or string for the database table.
You should create an alias for the attributes, for this purpose, it is alreay supported:
public function getCreatedDate()
{
    return new \DateTime($this->created_date);
}

public function setCreatedDate(\DateTime $date)
{
    $this->created_date = $date->toTimestamp();
}

You can setup validators for these virtual fields just like regular attributes.
I can't see any problem.

Currently ActiveRecord breaks a contract set by Object; from the docs:  Object is the base class that implements the property feature.

Yes. But there is no such thing as property access contract. It could be changed by child classes.
For example:
https://github.com/yiisoft/yii2/blob/master/framework/di/ServiceLocator.php#L68
https://github.com/yiisoft/yii2/blob/master/framework/base/DynamicModel.php#L81
You don't compain on these changes, do you?
It also has more sugnificant break of Object contract, see #583.

Regardless if you think I should be overriding them; currently the access is being duplicated across the ActiveRecord class.
That should be enough reason to  change it.
Giving other examples of stuff I don't complain about is not a valid argument in any discussion.
For the specific case of value objects, as long as they implement __toString properly they can be saved to the database just fine. (Note that currently Yii2 already does some typecasting which could in the future easily be extended to utilize some interface, so that for example if an object implements the DatabaseSerializable interface it gets serialized via some specific function from the interface..)
In short, it is a code clean up that provides me with more options as a side effect. If you do not want me to override a function mark it static, don't duplicate code and use the duplication as an excuse for not letting me override a function.

Regardless if you think I should be overriding them; currently the access is being duplicated across the ActiveRecord class.
That should be enough reason to change it.

Perhaps, but it seems it was some reason behind the current implementation - I just can not remember, which exactly. Need to be careful here.

For the specific case of value objects, as long as they implement __toString properly they can be saved to the database just fine.

For the objects - perhaps, but what will prevent you from other manipulations? What if someone will change the date format from 'Y-m-d' to 'Y/d/m' - he will receive the unexpected result. And perhaps will notice it only after some time.
There always SHOULD BE a way to access RAW table attributes, while you are talking about its possible removal.

Giving other examples of stuff I don't complain about is not a valid argument in any discussion.

Just as Currently ActiveRecord breaks a contract set by Object; from the docs is not a argument in any discussion too.

Lol, always fun to have these debates with you @klimov-paul !

Perhaps, but it seems it was some reason behind the current implementation - I just can not remember, which exactly. Need to be careful here.

If there is a reason for implementation decisions, then document it in the source code to prevent these discussions in the future ^^

For the objects - perhaps, but what will prevent you from other manipulations? What if someone will change the date format from 'Y-m-d' to 'Y/d/m' - he will receive the unexpected result. And perhaps will notice it only after some time.

These are coders we are talking about, they can break it if they want to; I can break the current implementation in exactly the same way, since I can assign objects to table attributes without any of my changes...

There always SHOULD BE a way to access RAW table attributes, while you are talking about its possible removal.

Why should there be a way? As far as I can tell there is no way for me to access them without being typecasted in Db\Column, so "raw" is relative in any case. If I want a way to access raw attributes I can just call the parent implementation of getAttribute right?

Just as Currently ActiveRecord breaks a contract set by Object; from the docs is not a argument in any discussion too.

It is a perfectly valid argument: it means either the documentation is (wrong, incomplete or unclear) or the code is wrong.

Perhaps, but it seems it was some reason behind the current implementation - I just can not remember, which exactly. Need to be careful here.

Perhabs consistency between _oldAttributes & _attributes

The test issues are drilled down to BaseActiveRecord::getDirtyAttributes

Duplicates #2262

Have updated the PR, it now passes all tests and I have even added a new test for getDirtyAttributes to test if the attributes are being tracked properly.

Is anything needed from me before this can be merged?

Can someone summarize what just changed?
Because it broke yii2-dynamic-ar.

I can tomorrow. Summary: ar attributes are only read/written to via
functions that can be overridden.
On Fri, Nov 20, 2015, 21:39 Tom Worster<EMAIL_ADDRESS>wrote:

Can someone summarize what just changed?
Because it broke yii2-dynamic-ar.
[image: Alt text]
https://camo.githubusercontent.com/3d1bc731e37780a41387083eb2585eae275bb3cb/68747470733a2f2f6d6f6e6f736e61702e636f6d2f66696c652f63704c6e71586c526e487a4d576939735468625a516c48486c755473574a2e706e67
—
Reply to this email directly or view it on GitHub
https://github.com/yiisoft/yii2/issues/9656#issuecomment-158517986.

I don't think non-BC change should be in 2.0.7.
I don't understand the discussion above, but changing BaseActiveRecord::__get() so that it calls the instance's getAtttibute() is a breaking change, at the very least.

I am not at my PC. But this change does not change the public api and
passes all tests. I'll try reproducing the error tomorrow, and will add
tests.
On Fri, Nov 20, 2015, 22:00 Tom Worster<EMAIL_ADDRESS>wrote:

I don't think non-BC change should be in 2.0.7.
I don't understand the discussion above, but changing
BaseActiveRecord::__get() so that it calls the instance's getAtttibute()
is a breaking change, at the very least.
—
Reply to this email directly or view it on GitHub
https://github.com/yiisoft/yii2/issues/9656#issuecomment-158522089.

I have not reviewed this PR before because I had no time for it. I do not think that this change should be made in 2.0.x and also not sure about 2.x.0. It changes a lot about how AR internals work and breaks existing code that deals with attribute handling.

It shouldn't though.. I can't make it tonight, will test Tom's scenario
Monday at the latest.
On Sat, Nov 21, 2015, 16:26 Carsten Brandt<EMAIL_ADDRESS>wrote:

I have not reviewed this PR before because I had no time for it. I do not
think that this change should be made in 2.0.x and also not sure about
2.x.0. It changes a lot about how AR internals work and breaks existing
code that deals with attribute handling.
—
Reply to this email directly or view it on GitHub
https://github.com/yiisoft/yii2/issues/9656#issuecomment-158652177.

@SamMousa when you get to reviewing this, please read the DynamicActiveRecord Design Principle—it's very short.
Implementation: DynamicActiveRecord::getAttribute() immediately calls parent::__get() expecting it to throw InvalidParamException if the named attribute does not exist. It catches the exception and implements the attribute itself. Recursion if BaseActiveRecord::__get() immediately calls the instance's getAttribute().

Will do.
On Sat, Nov 21, 2015, 17:57 Tom Worster<EMAIL_ADDRESS>wrote:

@SamMousa https://github.com/SamMousa when you get to reviewing this,
please read the DynamicActiveRecord Design Principle
https://github.com/tom--/yii2-dynamic-ar#design-principle—it's very
short.
Implementation: DynamicActiveRecord::getAttribute() immediately calls
parent::__get() expecting it to throw InvalidParamException
http://www.yiiframework.com/doc-2.0/yii-db-baseactiverecord.html#__get()-detail
if the named attribute does not exist. It catches the exception and
implements the attribute itself. Recursion if BaseActiveRecord::__get()
immediately calls the instance's getAttribute().
—
Reply to this email directly or view it on GitHub
https://github.com/yiisoft/yii2/issues/9656#issuecomment-158661967.

Hi @tom-- ,
I've looked into the issue and into DynamicActiveRecord. First of all, nice project I've made something like that myself using a kind of JsonBehavior that exposes attributes dynamically!
Okay, so before my changes the routing of __get went roughly like this:

Check if $this->_attributes has the key, if so return it (BaseActiveRecord).
Else check if $this->_related has the key, if so return it (BaseActiveRecord).
Else check getter exists, if so return it. (Component)

After that, if result type is ActiveQuery run the query and cache the results in $this->_related and return them instead of the query object.
In this flow, the getAttribute function is not used, meaning that if you wanted to adapt AR attribute handling (like in your project) you would have to override both __set, __get and getAttribute / setAttribute.
Since $_attributes is private you cannot write / read from it directly though.
After my patch, instead, __get and __set always try the attribute getters first, this means in your code the only "hooks" you need are getAttribute, hasAttribute and setAttribute.
Currently you have infinite recursion because your __get calls getAttribute, which calls "my" __get, which calls your getAttribute.
So TLDR; the patch does require some changes on your end but it will actually make the code flow of both BaseActiveRecord and DynamicActiveRecord simpler!

So TLDR; the patch does require some changes on your end but it will actually make the code flow of both BaseActiveRecord and DynamicActiveRecord simpler!

this implies that it is a BC break and should not be included in 2.0.x. We may apply it to 2.1 though.

Well, any change can be BC breaking if a descendant class overrides a function and then calls parent:: on another function...
That is just a recipe for disaster when any change is made in the parent class.

we can not  guarantee that we avoid breaking BC in all the cases but this one is obvious. 2.0.x releases of Yii are meant to be non breaking changes so we can not release 2.0.7 with this change.

That's okay, I don't mind that and obviously that is your perogative.
I'm just saying that if it really is a BC break there should be tests for it, there are and they pass. Since they test the public API.
The failing implementation here is DynamicActiveRecord, which is using knowledge that is not part of the public API. Calling a parent implementation of another function is not good practice, it assumes knowledge about the inner workings of the parent class.

@cebe do you suggest rolling it back?

I had no time to look at it yet, but it seems to me that in the current state it does not fit for a 2.0.x release.

API docs for Object, Component and BaseActiveRecord say that __get() throws an exception if the thing doesn't exist. __get() is a public method. DynamicActiveRecord::getAttribute() relies on this. I don't understand.
Afaict, unit tests for the exceptions exist for Object, Component but not ActiveRecord.

@tom-- , this implementation still throws that exception, however it calls $this->getAttribute to do the check.
Since your getAttribute again calls parent::__get() you get an infinite loop.

So, iiuc, the "knowledge" that DynamicActiveRecord::getAttribute() relies on is: BaseActiveRecord::__get() does not call $this::getAttribute() before xyz.

OK,  I guess it should be reverted...


Security save function to export saved object to marketflow database

in Security class, add def save(...) (like in MappableModel class)
after calling the save from the base class, run some code to export the object to the marketflow database
to export, use with MfManager(host=....) as mfman as in app/management/commands/importMarketflow.py
then call mfMan.insertSecurity (this is a new function in MfManager)
in insertSecurity, write self._execute("INSERT ....") (same query as in your testing)
also, need to detect if new object or edited object, so that the sql query is INSERT or UPDATE

@minerva22
I just committed #4d58969f4ed5eebfc06f65cac3e5ec66507c0355
and #c554970ec3c2c277cff029ece91089c77aeaa405
to your branch "save_export" in dataentry.
The new commits replace the ugly manual sql with an ORM class which is easier to read/maintain.
Do a "git pull" in your laptop tomorrow to download these commits before you start working tomorrow.
Also, I tested it, and it writes into the database for new rows.
I also added code to update an existing row if the security code already exists.
My testing was only done between the django app and heidisql,
where I saw the new row or the updated row.
Please test with heidisql also (or sql server manager),
and then test with the real marketflow, to see that the new security gets listed.
Let me know the result of your testing.

@minerva22 with your commit #acc7a49
we are still pending to test:

options, futures, shares can be edited in mf-dataentry, with the edits showing in marketflow's "security definition", without marketflow breaking and closing
fields edited in mf-dataentry correspond correctly to fields showing up as edited in marketflow UI
"hidden" fields of a new security/option/bond/futures are consistent when it is created via "mf-dataentry" or via marketflow "security definition"

when the above is tested, let me know so i can merge your branch into master


could not determine content type for extension .js

Hi I get the below warning when I build my vsix.
How do i override this?
warning : Could not determine content type for extension .js. Defaulting to application/octet-stream. To override this, add a contentType property to this file entry in the manifest.

Do you have the latest version? Try running npm up -g tfx-cli.

@trevorsg  how do i override this warning?

You shouldn't get this warning if you are using the latest version of tfx-cli. There are two ways to override it though. First is to open regedit and ensure there is a key for HKCR.js\Content Type set to a string value of "application/javascript". The second option is to add "contentType": "application/javascript" to the file entry in your manifest, as mentioned in the warning message.