Error: estimator MLPClassifier is not supported

Hello,
I've trying to use eli5 in a MLPClassifier.
I encounter the following error:
Error: estimator MLPClassifier(max_iter=3000, random_state=1010) is not supported
The code that gives the error is:
mlp = joblib.load(dirModels+fileName)
eli5.show_weights(mlp, top=10)

I've gone through the tutorial in https://eli5.readthedocs.io/en/latest/tutorials/sklearn-text.html with no issues.

Thanks for the report, it is indeed not supported and it's a non-trivial task to support it with show_weights, might need an API change as well to support passing a sample of documents.

@lopuhin Is ELI5 still being updated and supported? It looks like it isn't. Asking because I need to decide whether to use ELI5 in my next project or move on to something else.

@lopuhin Is ELI5 still being updated and supported? It looks like it isn't. Asking because I need to decide whether to use ELI5 in my next project or move on to something else.

@zeromh maintenance and PR review should resume next week, sorry for lack of support recently.

@zeromh maintenance and PR review should resume next week, sorry for lack of support recently.

@zeromh But in the context of this request - I personally don't have MLP show_weights support in mind in near future, so if you found a library which has it, I'd suggest using it (and would be glad if you share a link).

@zeromh But in the context of this request - I personally don't have MLP show_weights support in mind in near future, so if you found a library which has it, I'd suggest using it (and would be glad if you share a link).


Sign in - No button small language picker on the sign in page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

issue found when executing PR https://github.com/Expensify/App/pull/14851
Action Performed:

Access staging.new.expensify.com
Sign into a valid account
Go to Settings -> Preferences -> Language
Change the language
Verify it works as expected
Log out
On the sign in page, change the language from the small language picker

Expected Result:
User can change language from the small language picker on the sign in page.
Actual Result:
No button small language picker on the sign in page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/217831741-da930dd9-6624-4f1e-9840-3ca71fc5dc27.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016436adaef72de55c
Upwork Job ID:<PHONE_NUMBER>903913472
Last Price Increase: 2023-02-15

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

cc @cristipaval

Thanks @vitHoracek!
yeah, this might be related to my PR. I'll assign it to me for a quick look.

@michaelhaxhiu, @cristipaval Eep! 4 days overdue now. Issues have feelings too...

Hmm.. I can't reproduce this one on dev.

I think the issue happens due to these lines.
i18n is behind a beta flag, but on SignIn page we have no beta flag fetched from the backend, because betas are bound to the account. I wonder if we can always render the LocalePicker component, with no check for i18n beta flag, since this has been already for ages in production.

Started a Slack discussion here about removing the check for i18n beta flag. I think we should be good to remove.

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

@mollfpr Sorry, I messed up this issue. I forgot to add Internal label before opening the PR. Un-assigning you and assigning @aimane-chnaif since he is assigned to the PR.

@mountiny Could you please check if this issue and the PR are all set with all the chores (payment and everything else)? Thank you! 🙏

Assigned @aimane-chnaif so we can pay them for the review and testing

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.73-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/15169

If no regressions arise, payment will be issued on 2023-02-24. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@aimane-chnaif / @cristipaval] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@aimane-chnaif / @cristipaval] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@aimane-chnaif / @cristipaval] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@aimane-chnaif] Propose regression test steps to ensure the same bug will not reach production again.
[ ] [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

To be clear, this is a regression fix correct (based on this comment)?

Hmm.. I don't think so, according to the code, I think the issue has been there for a long time when the internationalisation was fully deployed to production.

@michaelhaxhiu Is there anything needed from my side on this issue?

We just need to pay out @aimane-chnaif and we can close this

Should be closed soon. I'll ping @michaelhaxhiu internally.

On it

paid


Couldn't find your C compiler

Hi，I meet a confused error like this：
$: which  gcc
/usr/bin/gcc
$: git clone https://github.com/toddr/XML-Parser/
$: cd XML-Parser
$: perl Makefile.PL
Couldn't find your C compiler
Compilation failed in require at Makefile.PL line 4.
Could you please give me more information?
Best.
Zhang.

$ echo $PATH
$ gcc -v

It may be bad output. XML::Parser depends on libexpat. Are you able to install this?

This may have been resolved by #89


Fix/3: fix demo scaffolding and switch to vue 3

Pull Request Test Coverage Report for Build 473131482

0 of 43 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-7.04%) to 30.0%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/masonite/inertia/commands/DemoCommand.py
0
43
0.0%

Totals

Change from base Build 472898912:
-7.04%

Covered Lines:
60

Relevant Lines:
200

💛  - Coveralls

Pull Request Test Coverage Report for Build 473131482

0 of 43 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-7.04%) to 30.0%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/masonite/inertia/commands/DemoCommand.py
0
43
0.0%

Totals

Change from base Build 472898912:
-7.04%

Covered Lines:
60

Relevant Lines:
200

💛  - Coveralls


Deprecate Parser.flatMap() in favor of Parser.transformEither()

The PR closes #24 by:

Deprecating current implementation of Parser.flatMap
Adding a new function Parser.transformEither() to replace the deprecated flatMap
Adding a new flatMap function with the expected shape.

I like these changes, much clearer.


SBOM generation includes all dependencies in working dir, not just Go ones.

What happened?

What were you attempting to do?

Building a go+react app. The directory structure is such that the go.mod file is at the root and there is a subdirectory called web that contains the node stuff.

What did you expect to happen?

Builds after zero changes to be really fast.

What was the actual behavior? Please provide log output, if possible.

Builds were slow and it seems generating the SBOM is where most of the time is spent (~28s):
Paketo Go Mod Vendor Buildpack 0.5.0
  Checking module graph
    Running 'go mod graph'
      Completed in 752ms

  Executing build process
    Running 'go mod vendor'
      Completed in 462ms

  Generating SBOM for directory /workspace
      Completed in 28.804s

When I run pack --sbom-output-dir /tmp I can see that /tmp/sbom/build/paketo-buildpacks_go-mod-vendor/sbom.syft.json contains all the node dependencies in addition to the go dependencies.
It looks like on this line the parameter to the sbom generator is pointing to entire workingDir and I suppose I expect to be more specific like just go.mod?
Build Configuration

What platform (pack, kpack, tekton buildpacks plugin, etc.) are you
using? Please include a version.

pack --version
0.24.0+git-79a40b7.build-3148

Checklist

[x] I have included log output.
[ ] The log output includes an error message.
[ ] I have included steps for reproduction.

I've reproduced this. I agree that we should be cataloging just the go.mod dependencies in this buildpack.


01-docs-home/04-managed-services.md

04-managed-services.md
@jacobsmith928 please complete this document as mentioned in the Products Outline doc earlier.

done.

@usrdev @jacobsmith928 the second line of the file references to an article, but no link is provided. Please share the link and I'll fix it!

fixed.


log errors occurring while waiting for cluster operator status

The TestNamedCertificates e2e test occasionally timeouts waiting for changes to take effect. This PR simply logs an error that might help shed some light on the flaky behavior of this test.

/test e2e-aws-operator

well, it doesn't win for beauty, but ok.  We need the flake fix, merging


Adds external protocol insertion for the clients and protocol selection based on the scheme

This patch allows the user to inject its own protocols to access git repositories, not just the standard HTTP and SSH.
It also adds automatic selection of the protocol to use based on the scheme of the URL of the repository.

Current coverage is 68.24%

Merging #10 into master will decrease coverage by -0.15% as of f0b4516

@@            master     #10   diff @@
======================================
  Files           17      17
  Stmts         1199    1203     +4
  Branches       191     191
  Methods          0       0
======================================
+ Hit            820     821     +1
- Partial         92      93     +1
- Missed         287     289     +2

Review entire Coverage Diff as of f0b4516

Powered by Codecov. Updated on successful CI builds.

LGTM :godmode:


Generate synthetic accessor for optional list properties

Add generation of synthetic accessor fun <optionalListField>FilterNotNull() to mitigate the issue with KN - Obj-C interop when List<T?> is translated to Swift as [Any].

Case with List<List<T?>?> is a little complicated, for that case we would have to generate smth like fun fooFiltetNotNullFilterNotNull():List<List<T>>, we definitely can do this but, what do you think?

I somehow thought this PR already does that since I saw some recursive calls in there.
I think we should be fine. I'm not sure that is really necessary. We can do that if that request comes from a user.


Upgrade to work with PIXI v4

I think there's a few things that were renamed during the transition which causes a couple things to potentially break. I think the big one is probably AbstractFilter becoming simply Filter. But there may be others that I don't know about, since I'm not super familiar with the changes made.

That's an easy fix to make. There have also been changes to the destroy() method of DisplayObjects and its subclasses, which we would probably want to take advantage of.

Was there any progress made on this?

I have not had time to take a look at it.

I've just pushed updated code to master that uses PIXI ^4.2.0. All of our examples seem to work fine, but if you have anything ready to test with it to make sure there aren't any obvious issues, I'd appreciate if you could test it for me. After that's done, I'll make bower/npm releases.

I tried it out, but ran into an issue where all the animations are black. I am using Springroll's fork of Pixi v4 : https://github.com/SpringRoll/pixi.js/pull/3

Hmm, I haven't tested anything with that branch (that should also be updated again). I will have to take a look at it this weekend.

mcdon00, had the same issue, adding to all displayObjects default value _tintRGB = 16777215 fixed that, but now I can see that something strange happend with rotation of objects (actual rotation become 0)

Not related to this issue, but I would strongly suggest that you all take a look at PixiAnimate which is our newest solution to exporting Pixi content natively from Adobe Animate (https://github.com/jiborobot/pixi-animate-extension). You can get it here: https://creative.adobe.com/addons/products/14345
This works with the latest version of Pixi v4.


regression: new windows runners produce malfunctioning binaries

Description
Starting 2 days ago, new generated binaries, even of older previously working commit, dont seems to be able to properly establish connections to the tox network. I am still digging into the code base to find out more about where the issue really is, but since the only change that seems to make a difference is the fact that the "binary is new", and I need to run this through the ci, this is somewhat of a chore.
looking at the runner update notes the only thing that might cause issues i the vcpkg update: https://github.com/microsoft/vcpkg/compare/08c4e7104...000d1bda1
but I cant fine anything in there that might cause issues. (pkg-config is not used on windows)
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[X] Windows Server 2019
[X] Windows Server 2022

Image version and build link
Image: windows-2022
Version: 20231211.1.0
AND
Image: windows-2019
Version: 20231211.1.0
Is it regression?
Yes, last successful run:
Image: windows-2022 Version: 20231205.1.0 https://github.com/Green-Sky/tomato/actions/runs/7207181708/job/19633517719
Expected behavior
the produced binary should start and connect to the tox network.
Actual behavior
The produced binary renders normally, and constantly produces network traffic, but cant connect to the network.
Repro steps
(see expected vs actual)

Hello @Green-Sky.
Saw latest runs are green. Is issue still persists and could you provide link to the failing run?

Sorry for the lack of updates. I spend hours trying to pin this down. I am no insane.
I am still unsure what is the actual cause, or why the runner update causes this.
First I did printf debugging with the ci (~5min turnaround time). I figured out that executing the binaries on my system using wine exhibits the same issues.
I figured out that the timer in toxcore was spewing out random numbers, instead of timestamps.
Keep in mind that this is specific to the runner version, and the same commits with previous runner versions produce correctly behaving binaries, so it is not specific to the environment it is executed it.
I then tried to add a test case to produce the bug in a somewhat isolated code environment, but still inside the same repository and discovered that THE MERE PRESENCE of the "new" source file, that is not compiled, causes the binary to be correct again. diff with messy commit, only look at the actual file changes.
I also discovered that compiling the timer as c++ instead of c fixes the binaries too. (mono_timer.c -> mono_timer.cpp + cmake change)
It is now the 3rd day and over 30 ci artifacts since I discovered this and I am turning insane.
(update:) While writing this update, I realized that an older commit that was rerun on the new runner images works 7495a50 , but the next commit following does not 6b5f40b

Here is a rundown on what changes "fixed" the regression:

changing mono_time.c to be compiled as c++
adding a new source file that is not even compiled

changes that did not fix the regression:

using old commits (in almost all cases, exception seen above)
using new commits (updating the toxcore subtree, which mono_time.c is part of)
changing related toxcore files (added print statements)
changing the runner from windows-2022 to windows-2019

I am sorry for opening this issue here, feel free to close it, if you dont see the relevance to runner-images :).
It has been a while since I have felt this lost in the dark... Time to move do binary diffing.

BTW I noticed a small discrepancy in the reported runner version and changelog version.
the runner reports Version:
20231211.1.0
while the changelog specifies:
20231211.1.1

@Green-Sky, thank you for a thorough troubleshooting rundown and I'm glad there are working solutions.
I will close this issue for now. Feel free to reach out in case of further concerns.


samples: echo_client: Set correct own and peer's addresses

The echo_server is at <IP_ADDRESS>, 2001:db8::2.
So, the own addresses should be, correspondingly <IP_ADDRESS>, 2001:db8::1.
The qemu_x86 overlay samples/net/sockets/echo_client/boards/qemu_x86.conf
is an extra source of confusion here (it just duplicates the wrong
configuration, making it obscure and difficult to find the problem),
removed.
Fixes: https://github.com/zephyrproject-rtos/zephyr/issues/14654
Signed-off-by: Oleg Zhurakivskyy<EMAIL_ADDRESS>

I have a mixed feeliings here. This indeed make qemu vs Linux work out of the box, but breaks qemu vs qemu or board vs board communication, which is IMO a more common use case. We could update echo_server/prj.conf as well, but that would contradict to what @jukkar wrote here. Can't we simply stress it out in the documentation that address swap is needed? Or provide a separate overlay config for qemu <> Linux?

Codecov Report

Merging #14676 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #14676   +/-   ##
=======================================
  Coverage   51.98%   51.98%
=======================================
  Files         309      309
  Lines       45584    45584
  Branches    10555    10555
=======================================
  Hits        23696    23696
  Misses      17080    17080
  Partials     4808     4808

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c29499...9d51000. Read the comment docs.

For me this patch also looks confusing, or possibly a result of confusion. There're comments in those config files that they're configured for qemu <-> qemu connection, and linux <-> qemu case needs patching.

The echo_server is at <IP_ADDRESS>, 2001:db8::2.

Which echo_server exactly? samples/net/sockets/echo_server is at <IP_ADDRESS>, 2001:db8::1, which are the default addresses for Zephyr samples.

We could update echo_server/prj.conf as well, but that would contradict to what @jukkar wrote here.

And I would be strongly -1 on that. I always use server-type apps on Zephyr side for testing, while client on Linux, and would prefer that config to work out of the box.
I have to admit I almost never use echo_client for testing, as it's much less comfortable and requires much more handwork. So, I wouldn't be a strong stakeholder of what default setup is for echo_client (qemu<->qemu vs linux<->qemu), but I'd let the original author decide, and if @rlubos says it's qemu<->qemu, and that's what we have now, I'd avoid just switching it around and confusing people. Of course, unless there're strong and convincing arguments for switchover.

@rlubos @pfalcon @tedd-an
This might make sense, and I am not against your arguments.
However, what the bug report is about, is described as the most common usage scenario, as per documentation:
One of the most common usage scenario
is to run echo-client application inside QEMU.

Anyway, the documentation probably beats commit’s comments.
So, please be more concrete with the usage scenarios, document/send patches.
If this brakes anything for you, let’s fix it.

@jukkar @rlubos @pfalcon
OK. I will take another look.
What actually makes sense here is to clearly document both cases first.
If qemu to qemu is more common, let’s document it, keep the configuration intact and provide an overlay/document BKM for a less common case.

I believe this issue was fixed in alternative way by https://github.com/zephyrproject-rtos/zephyr/pull/14690 . Please let me close this, as otherwise it's hard to keep track of what PRs are active and which aren't, in these hot last weeks before 1.14. If there's a mistake or misunderstanding, please reopen.


path/prop: also allow number (esp. for navigating arrays)?

Currently, Ramda's path / prop and similar methods are described in their docs as using string paths/props, while in its implementation -- and imho reasonably so esp. when dealing with Arrays -- also allows numbers:
R.path([0, 'a'], [{ a: 1 }])
// 1
R.path(['0', 'a'], [{ a: 1 }])
// 1
R.prop(0, ['a'])
// "a"
R.prop(0, { '0': 'a' })
// "a"

Now, I would like for the typings to also allow me to use these functions how I was already using them. You may counter this would clash with Ramda's docs, and therefore possibly intention. So I guess the question here is, would you consider this a bug in Ramda's implementation, or should we request they adjust their docs and accordingly allow this in the typings?

Note that toPairs does use {[k: string]: S} | {[k: number]: S}. I'm thinking we could have a type Prop = string | number;, a type Path = Prop[];, then have toPairs use {[k: Prop]: S} to abstract that part.

I would say that it's probably Ramda's docs which are outdated, but perhaps you should ask there ;)
Nevertheless, a PR is most welcomed, you seem to be heading in the right direction


[FEAT] Add an option to hide the resource in the menu

Is your feature request related to a problem? Please describe.
Currently, users need to customize the <Sider /> components to hide resources from their menu. We should support a way in our useMenu hook at @pankod/refine-core to let users hide resources in the menu.
Describe the solution you'd like
A field on options property of the resources.
<Refine
    resources={[
        {
            name: "posts",
            options: {
                visible: false, // or hide: true
            }
        }
    ]}
/>

Hey @aliemir  ,
We've released<EMAIL_ADDRESS>Could you approve this feature?
    <Refine
        ...
        ...
        resources={[
            {
                name: "posts",
                list: PostList,
                options: {
                    hide: true,
                },
            },
        ]}
    />


Navbar 1

i hope nothing breaks

We already had a Navbar na? so why a new one..just asking?

We already had a Navbar na? so why a new one..just asking?

Bro mb I did not pull or see the merged prs before started working

We already had a Navbar na? so why a new one..just asking?

Bro mb I did not pull or see the merged prs before started working

Ohhh...no issues then!!


Reorganize "University Course Programs" Section and Add USA PhD Programs

For issue #59

thanks for your efforts!


$app->run() gives 404 with nGinX

Hi - I'm trying to get Slim to work. I've browsed most of the issues on github as well as google and managed to get somewhere, but I still cannot get slim working properly.
Based on a post here, I use the following in my nGinX conf file. All my files are under /usr/share/nginx/html. Slim is installed there: /usr/share/nginx/html/Slim/*.
location / {
    root   /usr/share/nginx/html;
    index  index.php index.html index.htm;
    try_files $uri $uri/ /index.php?$request_uri;
}

Adding the try_files was relatively successful - it no longer 404s with just a simple require 'slim.php'
Here's my index.php:
require '/usr/share/nginx/html/Slim/Slim.php';
$app = new Slim();
$app->get('/hello/:name', function($name) {
echo "Hello, $name";
});
$app->run();
if I comment out the $app->run(); line, it "works" (if I put text after this, it renders in the browser).
If I uncomment the $app->run() line, I get 404.
I'm not sure what I'm doing wrong - does anyone have ideas?

OMG thank you @teemobean
try_files $uri $uri/ /index.php?$request_uri;
made everything work with Userfrosting (based on Slim), have been banging my head against a wall all morning!


Added OpenVPN

Hi,
Thanks for your contribution!  The project was added into the linuxfoundation:develop branch.


python310Packages.mypy-boto3-s3: 1.26.104 -> 1.26.116

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 227685 run on x86_64-linux 1

10 packages built:

python310Packages.dependency-injector
python310Packages.dependency-injector.dist
python310Packages.mypy-boto3-s3
python310Packages.mypy-boto3-s3.dist
python311Packages.dependency-injector
python311Packages.dependency-injector.dist
python311Packages.mypy-boto3-s3
python311Packages.mypy-boto3-s3.dist
toil
toil.dist


Challenge obtaining blockstate from ItemStack for Bewitchment gemblock

Mod Version:
<IP_ADDRESS>
Link to crash log (if applicable):
https://pastebin.com/3WMexJjN
Description:
Exception processing ore dictionary entry that has a Bewitchment gem block.
https://github.com/Um-Mitternacht/Bewitchment/issues/147#issue-392821866

Looks to be a bad ItemStack in the ore dictionary.  However, DS needed a fix to handle the situation better.


Onboarding applicationinsights

Docs Build status updates of commit 64779e2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-mapping/reference.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


You must use Bundler 2 or greater with this lockfile

I try to upload my rails app to heroku but i get this error.
remote: /tmp/d20181113-113-10miq1y/bundler-1.15.2/gems/bundler-1.15.2/lib/bundler/lockfile_parser.rb:108:in `warn_for_outdated_bundler_version': You must use Bundler 2 or greater with this lockfile. (Bundler::LockfileError)
From what i understand my bundler version (Bundler version 2.0.0.pre.1)
is different than the one in heroku (Bundler 1.15.x)
What can i do to change that?
Please help me!

Ugggh, you'd need to run gem install bundler -v 2.0.0.pre1 before this error happens, but I'm not sure if you can do this on heroku right now... For now, you can downgrade your bundler version to 1.17.1 and regenerate your lock file. I think
gem install bundler -v 1.17.1
gem uninstall bundler -v 2.0.0.pre1
bundle update --bundler

should do the trick.
@bundler/maintainers This seems no good? :thinking:. Maybe bundle install should automatically install and exec to the locked version in the lock file?

For the time being, it is possible to use Bundler 2 via this buildpack: https://github.com/bundler/heroku-buildpack-bundler2. You can set your Heroku app to use that buildpack by running heroku buildpacks:set https://github.com/bundler/heroku-buildpack-bundler2. We are working with Heroku to provide Bundler 2 as part of the official Heroku buildpack, but it will take some time.

Nice! Still, I wonder if it's a good idea that bundle install automatically installs and use the locked version of bundler in the lock file?

thanks a lot for the quick reply guys!

heroku buildpacks:set https://github.com/bundler/heroku-buildpack-bundler2

did it for me!

Thanks! This also worked for me.
heroku buildpacks:set https://github.com/bundler/heroku-buildpack-bundler2

Thanks a gazillion!!!

Thanks! This also worked for me.
heroku buildpacks:set https://github.com/bundler/heroku-buildpack-bundler2

Go to your heroku console in your browser. Go to your app. Then go to Settings. In Buildpacks click the button "Add buildpack" and enter this url: https://github.com/bundler/heroku-buildpack-bundler2
Now do git push heroku master and it should go through!

@schneems correct the best way is to update your bundler version on your gemfile.lock

@schneems - I tried what you suggested above, downgrading to bundler 1.17.3, removing the Gemfile.lock, re-generating it with the 1.17.3 version of bundler and then attempting to push up to heroku master. This failed because Could not find 'bundler' (< 2) - did find: [bundler-2.0.1]. Do I need to do something to re-initialize my Heroku environment to support bundler v1?

I don’t recommend deleting the Gemfile.lock. Just editing it. What does it say at the bottom in the “BUNDLED WITH” section now that you’ve made your modifications? Did you commit back to git after you made your changes?

@schneems - I tried what you suggested above, downgrading to bundler 1.17.3, removing the Gemfile.lock, re-generating it with the 1.17.3 version of bundler and then attempting to push up to heroku master. This failed because Could not find 'bundler' (< 2) - did find: [bundler-2.0.1]. Do I need to do something to re-initialize my Heroku environment to support bundler v1?

Open your Gemfile.lock at the bottom of your gemfile.lock update BUNDLE WITH version to 1.17.3 then redeploy to heroku again.

Previously I thought this behavior was limited to Rubygems 3+ (https://github.com/rubygems/rubygems/issues/2592) but now i'm realizing that the lockfile parser in Bundler 1.x is where this error is being raised.
Similar to https://github.com/rubygems/rubygems/issues/2592 since there's no actual discrepancy with Bundler 2.x lockfile and Bundler 1.x there's no current reason to raise this error right now. Can we backport an "escape valve" that will allow people to opt out of this error and release it in 1.17 ? There's not any technical reason that bundler 1.15 or 1.17 cannot execute a bundler 2.0.1 Gemfile.lock.

@schneems the intention was that both Bundler 1.x and 2.x could be installed at the same time, and RubyGems would give you the correct version on execution of any bundle command. Is it not possible for Heroku to have both Bundler 1.17 and 2.0 installed at the same time for some reason?

@indirect This is the solution I'm moving forward with on the buildpack https://github.com/heroku/heroku-buildpack-ruby/pull/850.
This solution inspects the Gemfile.lock and pulls the appropriate major version. I.e. 1.x will get 1.15.2 and 2.x will get 2.0.1 (for now). I'll merge early next week, then if there are no major issues, I can likely deploy to all apps a week from Monday.

Is it not possible for Heroku to have both Bundler 1.17 and 2.0 installed at the same time for some reason?

One of the issues with letting bundler decide which version to execute is that the buildpack uses the lockfile parser, which is the component that raises the exception on this issue. We can only require one specific version into the codebase so we have to know what major version of bundler we'll need to use anyway.
When we initially talked about how this was going to roll out it was my understanding that bundler 1.x could still execute and install a Gemfile.lock built with 2.0 and that the only thing that was changed was "jump" logic which I thought was isolated to the bundler codebase. That would give time to prepare the patch as described above. When I talked with Colby we've always thought there was a need to inspect the Gemfile.lock and download the appropriate bundler version.

That seems like a good solution. Sorry for the miscommunication about the lockfile parser; I thought that the version switching inside RubyGems would be usable by the buildpack as well.

Why just not use gem update bundler? For update ruby environment to use bundler 2?

Hi I managed to deploy my app to heroku with the bundler2 buildpack
→ heroku buildpacks -r staging
=== offers-app-staging Buildpack URLs
1. https://github.com/mojodna/heroku-buildpack-jemalloc.git
2. https://github.com/bundler/heroku-buildpack-bundler2

and it works fine:
remote:        Your app was upgraded to bundler 2.0.1.

But the application can't start after the deploy is finished. From the logs:
2019-02-15T19:49:40.000000+00:00 app[api]: Build succeeded
2019-02-15T19:49:44.680550+00:00 heroku[web.1]: Starting process with command `jemalloc.sh bundle exec puma -C config/puma.rb`
2019-02-15T19:49:46.355427+00:00 heroku[web.1]: State changed from starting to crashed
2019-02-15T19:49:46.337365+00:00 heroku[web.1]: Process exited with status 1
2019-02-15T19:49:46.289187+00:00 app[web.1]: bundler: failed to load command: puma (/app/vendor/bundle/ruby/2.6.0/bin/puma)
2019-02-15T19:49:46.289209+00:00 app[web.1]: Bundler::LockfileError: You must use Bundler 2 or greater with this lockfile.
2019-02-15T19:49:46.289211+00:00 app[web.1]: /app/vendor/ruby-2.6.0/lib/ruby/2.6.0/bundler/lockfile_parser.rb:108:in `warn_for_outdated_bundler_version'
2019-02-15T19:49:46.289213+00:00 app[web.1]: /app/vendor/ruby-2.6.0/lib/ruby/2.6.0/bundler/lockfile_parser.rb:95:in `initialize'
2019-02-15T19:49:46.289214+00:00 app[web.1]: /app/vendor/ruby-2.6.0/lib/ruby/2.6.0/bundler/definition.rb:83:in `new'
2019-02-15T19:49:46.289215+00:00 app[web.1]: /app/vendor/ruby-2.6.0/lib/ruby/2.6.0/bundler/definition.rb:83:in `initialize'
2019-02-15T19:49:46.289216+00:00 app[web.1]: /app/vendor/ruby-2.6.0/lib/ruby/2.6.0/bundler/dsl.rb:234:in `new'
2019-02-15T19:49:46.289218+00:00 app[web.1]: /app/vendor/ruby-2.6.0/lib/ruby/2.6.0/bundler/dsl.rb:234:in `to_definition'
2019-02-15T19:49:46.289219+00:00 app[web.1]: /app/vendor/ruby-2.6.0/lib/ruby/2.6.0/bundler/dsl.rb:13:in `evaluate'
2019-02-15T19:49:46.289220+00:00 app[web.1]: /app/vendor/ruby-2.6.0/lib/ruby/2.6.0/bundler/definition.rb:34:in `build'
2019-02-15T19:49:46.289222+00:00 app[web.1]: /app/vendor/ruby-2.6.0/lib/ruby/2.6.0/bundler.rb:135:in `definition'
2019-02-15T19:49:46.289223+00:00 app[web.1]: /app/vendor/ruby-2.6.0/lib/ruby/2.6.0/bundler.rb:101:in `setup'
2019-02-15T19:49:46.289224+00:00 app[web.1]: /app/vendor/ruby-2.6.0/lib/ruby/2.6.0/bundler/setup.rb:20:in `<top (required)>'
2019-02-15T19:49:46.289226+00:00 app[web.1]: /app/vendor/ruby-2.6.0/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
2019-02-15T19:49:46.289227+00:00 app[web.1]: /app/vendor/ruby-2.6.0/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'

Is there anything more that I need to do to setup bundler 2 on heroku?

This command:
heroku buildpacks:set https://github.com/bundler/heroku-buildpack-bundler2
Seems to have wiped out my previous command:
heroku buildpacks:add --index 1 heroku/nodejs
I was getting a webpack error, could not figure it out until I ran heroku buildpacks
I had 2 ruby buildpacks and the nodejs one was awol.

Heroku now supports Bundler 2 https://devcenter.heroku.com/changelog-items/1563

One reported issue. Even with bundler 2 on the system this error still happens when deploying an app with Ruby 2.6 since Ruby 2.6 ships with a default version of bundler.
https://github.com/heroku/heroku-buildpack-ruby/issues/856

Deployments were working OK for me with the bundler buildpack but I could not load the heroku console.
I switched to the standard heroku ruby pack, but I still have the same issue:
heroku console -r production
Running console on ⬢ policymogul-production... up, run.9121 (Standard-1X)
You must use Bundler 2 or greater with this lockfile.
I reverted to:
BUNDLED WITH
1.17.2
in Gemfile.lock
Seems its not ready for prime time.

@brentgreeff are you using Ruby 2.6.0? If so, can you try with Ruby 2.6.1?

Can confirm it works with Ruby 2.6.1

I tested the "bundler 2" third party buildpack with Ruby 2.6.0 and confirms that fails in the same way https://github.com/heroku/heroku-buildpack-ruby/issues/856#issuecomment-465619756
I suggest people migrate to Heroku's officially supported buildpack heroku/ruby and upgrade to Ruby 2.6.1 if they're currently using 2.6.0.
I opened a PR with a deprecation on the "bundler 2" buildpack https://github.com/bundler/heroku-buildpack-bundler2/pull/7

Just to add here, I've had the similar issue with Jekyll Netlify deploy. In Gemfile.lock I've changed:
BUNDLED WITH
    2.0.1

to 1.17.1 and that made the deployment successful.

On a dokku server with herokuish by using v199 heroku buildpack ruby:
dokku config:set --no-restart appname BUILDPACK_URL=https://github.com/heroku/heroku-buildpack-ruby.git#v199

With Gemfile.lock
[..]
rails (5.2.2)
      actioncable (= 5.2.2)
      actionmailer (= 5.2.2)
      actionpack (= 5.2.2)
      actionview (= 5.2.2)
      activejob (= 5.2.2)
      activemodel (= 5.2.2)
      activerecord (= 5.2.2)
      activestorage (= 5.2.2)
      activesupport (= 5.2.2)
      bundler (>= 1.3.0)
      railties (= 5.2.2)
      sprockets-rails (>= 2.0.0)
[..]
RUBY VERSION
   ruby 2.6.1p33

BUNDLED WITH
   2.0.1

deployment was successful
-----> Fetching custom buildpack
-----> Ruby app detected
-----> Compiling Ruby/Rails
-----> Using Ruby version: ruby-2.6.1
-----> Installing dependencies using bundler 2.0.1
[...]
=====> Application deployed:
[..]

@brentgreeff are you using Ruby 2.6.0? If so, can you try with Ruby 2.6.1?

ruby 2.6.1p33

not a big deal though, can live without those sweet 2.01 features.

I found one case where invoking a command via a binstub fails with Bundler 2 and Ruby 2.6.1. I'm able to reproduce this on docker outside of Heroku and I've reported to Ruby core:
I've detailed a few fixes on this thread:
https://github.com/heroku/heroku-buildpack-ruby/issues/856#issuecomment-467205932
The easiest one is to make sure all your commands in your Procfile are prefixed with bundle exec which is annoying, but at least there's a viable workaround.

Yeah. Will be fixed in 2.6.2. Have a look at https://github.com/bundler/bundler/issues/6937 and https://bugs.ruby-lang.org/issues/15582. Best workaround for the moment, gem update --system to force the reinstallation of the default bundler gem.

 Here is roughly what worked for me:
In an emergency? bundle exec rake worked for me anywhere I tried it.
Want to fix the underlying problem?

Update RVM, and be sure to add the new keys first, then rvm get head.
Update to Ruby 2.6.1 if you need to.
gem update --system
gem list bundler to make sure you have Bundler 2

Now it should run without issue.

I've encountered such problem on Heroku deployment that I've described in this stackoverflow post. The solution for me was setting in the Procfile the web command as follows:
web: bundle exec rails server -p $PORT -e $RAILS_ENV
Without it, Heroku was using the default Ruby 2.6.0 and then failing

Try Ruby 2.6.2 the 2.6.0 release has a bunch of bugs that were fixed.

gem install bundler
Successfully installed bundler-2.0.1
Parsing documentation for bundler-2.0.1
Done installing documentation for bundler after 2 seconds
1 gem installed
~/project/rake routes
You must use Bundler 2 or greater with this lockfile.

?

/usr/local/opt/ruby/bin/bundler version
Bundler version 2.0.1 (2019-01-04 commit d7ad2192f)

A temp solution is uninstalling old versions of bundler.
gem uninstall bundler --version 1.17.2

I can't seem to use the temp solution. Any ideas?
 ➜  git:(master) ✗ gem list | grep -i bundler
bundler (1.17.2)
➜  git:(master) ✗ gem uninstall bundler
Gem 'bundler' is not installed

Any ideas??


HRs use the screen width when they should be using window width

Describe the bug
HRs are rendered with the width of the whole terminal screen, so when an HR is in a buffer/window that is smaller than the whole screen, the center point is rendered too far to the right or sometimes even off-screen
Are you using a distro?
No

[!NOTE]
Distros can sometimes cause unusual behavior due to changing various options.

To Reproduce
Steps to reproduce the behavior:

Install markview.nvim.
Open a markdown file
Type ---
Run :vsplit

Expected behavior
The center (diamond) of the HR is centered in the window
Actual behavior
The diamond is centerd on the screen
Screenshots

Neovim version
0.10.0
Additional context
N/A

Unfortunately this doesn't work well.
Let's say you open a file and use :vsp in that case which window will the plugin look at? Extmarks will be placed on the buffer itself.
So, regardless of what I do at least 1 window will have incorrect width of HR.
Plus, this wouldn't work when resizing and if it did that would be performance issues on larger files.

@OXY2DEV Right, but at least in the case where the buffer is only open in one window, shouldn't the diamond be centered?
I'll admit that having the same buffer open in two windows is not the most useful anyway. Still -- it could just be centered to whichever window is active

That's caused by textoff. Again, different windows can have different textoff(and initially the value will be 0 regardless of the actual width of the statuscolumn) so it's next to impossible to do it.


Challenge http://www.freecodecamp.com/challenges/waypoint-create-a-text-field has an issue

Syntax error, unrecognized expression

Challenge completes if you follow the instructions by adding <input type="text">. Without a more descriptive error and providing your attempted code we can't troubleshoot your attempted solution.

I have problems with 4 of the challenges so far. Any time I see "Syntax
error, unrecognized expression" I can't finish it.
I know I did it right, I continued and checked how the solution was on the
next challenge and it was correct all 4 times.
Regards,
Jonathan
-Miya
http://miyadojo.com
On Tue, May 26, 2015 at 11:45 AM, Nathan<EMAIL_ADDRESS>wrote:

Challenge completes if you follow the instructions by adding . Without a more descriptive error and providing your
attempted code we can't troubleshoot your attempted solution.
—
Reply to this email directly or view it on GitHub
https://github.com/FreeCodeCamp/freecodecamp/issues/508#issuecomment-105598653
.

Sorry wrong file extension.
-Miya
http://miyadojo.com
On Tue, May 26, 2015 at 3:37 PM, Miyagui<EMAIL_ADDRESS>wrote:

I have problems with 4 of the challenges so far. Any time I see "Syntax
error, unrecognized expression" I can't finish it.
I know I did it right, I continued and checked how the solution was on the
next challenge and it was correct all 4 times.
Regards,
Jonathan
-Miya
http://miyadojo.com
On Tue, May 26, 2015 at 11:45 AM, Nathan<EMAIL_ADDRESS>wrote:

Challenge completes if you follow the instructions by adding . Without a more descriptive error and providing your
attempted code we can't troubleshoot your attempted solution.
—
Reply to this email directly or view it on GitHub
https://github.com/FreeCodeCamp/freecodecamp/issues/508#issuecomment-105598653
.


CVE-2019-19638 was assigned for this issue.

Merged your PR on v1.8.3. Thanks!


Md link fixes

Also remove the misc.xml from repository to improve working on other machines

bors: r+


test fix

Signed-off-by: Cameron Wall<EMAIL_ADDRESS>Issue: https://github.com/stolostron/backlog/issues/18901

/lgtm


I am not able to add multiple jenkins job on same dashboard

I am trying to add multiple jenkins job on same dashboard, can you please suggest how we can do this

@pandeyalok with the current Build widget you can select only one Jenkins  job at a time.

There is work in progress to implement this feature however no ETA at this moment.


Bug Report: In All Songs (with optimization turned on, if I make a mistake, the voice cuts off from player 1 "and I only go if I hit my turn")

If you are playing a downloaded version of the game, what operating system are you using?
Windows (x86), Windows (x86_64), Linux, or macOS? Specify below. ('Win10x64bit")
What version of the game are you using? Look in the bottom left corner of the main menu.
KE V1.5.4
https://user-images.githubusercontent.com/86559005/123546931-1033c980-d735-11eb-9926-6246a230a46b.mp4
https://user-images.githubusercontent.com/86559005/123547015-67399e80-d735-11eb-9017-d059c6397649.mp4
Please describe your issue. Provide extensive detail and images if possible.
"Plz Fix This"

i think it's cutting off cuz u missed, not sure about the other things tho

oh the "and I only go if I hit my turn" is on purpose i think lol

oh the "and I only go if I hit my turn" is on purpose i think lol

(I think it's bad, because it breaks the music and the effect "because it's also just for the audio and the eye")

naw that's a base game mechanic and it's intended.

So you're saying that that the the enemy's voice cutting off is intended? 'Cause last time I checked, only the BF can miss.

@KadeDev
So you're saying that that the the enemy's voice cutting off is intended? 'Cause last time I checked, only the BF can miss.

yes, it's intended. The vocals dont continue until you press a note again, so you could miss a note, and the opponent's section would just completely die out.

the enemy's voice cutting off is intended due to how it mutes bf's voice, but it's always supposed to play when its the enemy's turn
https://user-images.githubusercontent.com/15317421/123739144-04dabe00-d85b-11eb-90dd-c74c9483253e.mp4

and I assumed when playing on optimized, there is now way to check if the opponent has played notes


Class variable fields should not have public accessibility

This pull request is focused on resolving occurrences of Sonar rule squid:ClassVariableVisibilityCheck - Class variable fields should not have public accessibility
You can find more information about the issue here:
https://dev.eclipse.org/sonar/coding_rules#q=squid:ClassVariableVisibilityCheck
Please let me know if you have any questions.
Kirill Vlasov

Looks good to me, thanks @kirill-vlasov

This was addressed as part of the checkstyle changes to core #895. Thanks for the contribution @kirill-vlasov!


CSS Variable swatch in suggest widget has large gap

We recently introduced a new icon container for the symbol icons in the suggest widget, not sure if this is affected by it but it's being added to the dom twice:

@jrieken I don't think this commit looks right: https://github.com/microsoft/vscode/commit/bd6c4a88fe5a481bf23b030e6df5af07ee958216
What do you think? I can put a quick fix to make the iconContainer's class icon hide just for release, but I feel the DOM has become more complicated than it needs to be.

I trust you making the right call here 👍

Verifier: Complete color: i| in CSS. Verify you don't see the gap:


openttd failed to build on 10.12

openttd failed to build on 10.12
https://gist.github.com/anonymous/033bb352d658ae9ccd1ed3032b014f9e
[SRC] Compiling video/cocoa/event.mm
[SRC] Compiling video/cocoa/fullscreen.mm
[SRC] Compiling video/cocoa/wnd_quartz.mm
[SRC] Compiling video/cocoa/wnd_quickdraw.mm
[SRC] Linking openttd
Undefined symbols for architecture x86_64:
  "_iconv", referenced from:
      convert_tofrom_fs(void*, char const*) in unix.o
  "_iconv_open", referenced from:
      OTTD2FS(char const*) in unix.o
      FS2OTTD(char const*) in unix.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [openttd] Error 1
make: *** [all] Error 1

Seems like CLT is required to build without errors. You may install CLT by running xcode-select --install or wait a bit until we upload a new bottle for Sierra.

openttd bottles are updated with f326d9fde3a7ec7e348a1cbeb60bf78c554d9218. Please try installing it by brew install openttd.

@tomyun works now for me, thanks

@tomyun is there a way to know the libs/configure options you're using when creating the bottles?  Trying to get openttd to build from source outside of brew.
related https://github.com/Homebrew/homebrew-games/issues/464#issuecomment-236414302

@tony bottling is automatically done by CI server, but should not differ much from building on your own machine. brew install -d -v openttd may give you an idea how it actually builds. Also note that we apply some patches for compatibility issues on newer macOS (FS#6295, FS#6380).

Changing install name in /usr/local/Cellar/openttd/1.6.1/OpenTTD.app/Contents/MacOS/openttd
  from @@HOMEBREW_PREFIX@@/opt/xz/lib/liblzma.5.dylib
    to /usr/local/opt/xz/lib/liblzma.5.dylib
Changing install name in /usr/local/Cellar/openttd/1.6.1/OpenTTD.app/Contents/MacOS/openttd
  from @@HOMEBREW_PREFIX@@/opt/lzo/lib/liblzo2.2.dylib
    to /usr/local/opt/lzo/lib/liblzo2.2.dylib

I think that could be it.  Some of the ways I build tend to give me linking issues with lzma/lzo.  Interested in seeing how to get the exact behavior (./configure, the CI server settings, etc.) Even if it was to document it for others.
Building MacOS apps from source is just tricky business a lot of the time.

@tony You could also manually run ./configure in an interactive session by running brew install -d -v -i openttd. I don't know much about the CI server settings as I don't have an access to it either, but it shouldn't really matter because you can build bottles on your local machine too. brew bottle option might be of your interest although I have little experience with it. If you have further questions, feel free to open a new issue. Thanks!


examples: Update NI-DCPower readme to describe the .env simulation process

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Updated the NI-DCPower example's ReadMe file to describe the simulation process.
Why should this Pull Request be merged?
Explains the process of enabling the simulation in the ReadMe file.

Once this PR is approved, I'll raise a PR for all the other examples' readme.

Create a .env file in the measurement service's directory or one of its parent directories (such as the root of your Git repository or C:\ProgramData\National Instruments\MeasurementLink\Services).

When I place the .env file in the Git repository, everything works as expected. However, when I try to do the same by putting the .env file in the C:\ProgramData\National Instruments\MeasurementLink\Services folder, I encounter an error that says, "Device was not recognized." Is there anything I might be overlooking in this situation?
CC: @bkeryan

@bkeryan If we relocate the .env.simulation file to the examples/ directory, it's better to also move the .env.sample file to the same directory. Keeping these files in different directories may confuse. Please let me know if you have different thoughts.

Create a .env file in the measurement service's directory or one of its parent directories (such as the root of your Git repository or C:\ProgramData\National Instruments\MeasurementLink\Services).

When I place the .env file in the Git repository, everything works as expected. However, when I try to do the same by putting the .env file in the C:\ProgramData\National Instruments\MeasurementLink\Services folder, I encounter an error that says, "Device was not recognized." Is there anything I might be overlooking in this situation?
CC: @bkeryan

'Device was not recognized' sounds like it's not picking up your .env file at all and trying to use hardware from NI MAX? Can you describe your process? E.g.

Copy the DCPower folder to c:\programdata...
Cd over to that directory in powershell or VS Code terminal
Run poetry install
Run poetry run python .\measurement.py

My understanding is it would use the current working directory to start looking for the .env file. If, e.g. your working directory is c:\dev\measurementlink-python and then you run, e.g. poetry run python c:\programdata...\measurement.py, it may not find the .env.

Create a .env file in the measurement service's directory or one of its parent directories (such as the root of your Git repository or C:\ProgramData\National Instruments\MeasurementLink\Services).

When I place the .env file in the Git repository, everything works as expected. However, when I try to do the same by putting the .env file in the C:\ProgramData\National Instruments\MeasurementLink\Services folder, I encounter an error that says, "Device was not recognized." Is there anything I might be overlooking in this situation?
CC: @bkeryan

Use C:\ProgramData\National Instruments\MeasurementLink\Services when your measurement service is in C:\ProgramData\National Instruments\MeasurementLink\Services.
How about adding the text "for statically registered measurement services"?

(such as the root of your Git repository or C:\ProgramData\National Instruments\MeasurementLink\Services for statically registered measurement services)

Create a .env file in the measurement service's directory or one of its parent directories (such as the root of your Git repository or C:\ProgramData\National Instruments\MeasurementLink\Services).

When I place the .env file in the Git repository, everything works as expected. However, when I try to do the same by putting the .env file in the C:\ProgramData\National Instruments\MeasurementLink\Services folder, I encounter an error that says, "Device was not recognized." Is there anything I might be overlooking in this situation?
CC: @bkeryan

Use C:\ProgramData\National Instruments\MeasurementLink\Services when your measurement service is in C:\ProgramData\National Instruments\MeasurementLink\Services.
How about adding the text "for statically registered measurement services"?

(such as the root of your Git repository or C:\ProgramData\National Instruments\MeasurementLink\Services for statically registered measurement services)

Yes, this gives much better context.


Ping Cleanup

Changed a potentially misleading comment on the c# client, moved the ResetPing call to a more obvious location.
Both client and server skip sending pings.

@dotnet-bot test Windows Release x64 Build (Spanish language image) please

@dotnet-bot test Spanish language image please

@pranavkm is there a way to re-run the Spanish image build? Trying the whole string just ends up running the non-spanish build again because it's a substring

Hmm. Maybe it needs to be a distinct name? Roslyn does names in the format windows_debug_spanish_unit32_prtest. Perhaps changing https://github.com/aspnet/SignalR/blob/dev/build/buildpipeline/pipeline.groovy#L15 to be somewhat similar may help?


Problems about the proxies

Thanks for this project!
When i set proxies parameters, i get this error:
(CurlError("Failed to perform, ErrCode: 35, Reason: 'error:100000f7:SSL routines:OPENSSL_internal:WRONG_VERSION_NUMBER'"),)
the proxy has user name and password. and i set the param. like this:
auth = ["username","pwd"],

Could you please try the format http://username:password@<IP_ADDRESS>:3128

Could you please try the format http://username:password@<IP_ADDRESS>:3128

Thanks for you reply. I tried and the error still exist.
Out  [2]: (CurlError("Failed to perform, ErrCode: 35, Reason: 'error:100000f7:SSL routines:OPENSSL_internal:WRONG_VERSION_NUMBER'"),)

Could you please try the format http://username:password@<IP_ADDRESS>:3128

i use python 3.7.16 and win11(x64)

OK, more details could be helpfule.
Does it work for proxies without authentication?
Can you provide the url you were trying to access or the full code snippet?

OK, more details could be helpfule.
Does it work for proxies without authentication? Can you provide the url you were trying to access or the full code snippet?

it could work without authentication.
the url is https://tls.peet.ws/api/all
try:             r = requests.get(                 url = "https://kawayiyi.com/tls",                 allow_redirects = False,                 #proxies = self.myProxies,                 #auth = self.sAUTH,                 impersonate = "chrome101"             )             #r =  requests.get( url="https://kawayiyi.com/tls", impersonate="chrome101", proxies = self.myProxies)             return r         except Exception as e:             pass

TL;DR
You should change {"https": "https://localhost:3128"} to {"https": "http://localhost:3128"}.
Full explaination
I believe you are misusing https proxies, which is a very common pitfall.
A typical https over http proxy is a proxy capable of tunneling https traffic through the proxy. The client first send a plain http CONNECT request, then a tunnel is established between the via the proxy. The format should be:
proxies = {"https": "http://localhost:3128"}
            ^^^^^   ^^^^^^
                     Notice: http, not https

The connections:
Client <--http--> proxy <--https--> web
    \              /
     +----https---+

Because the CONNECT is plain http, the proxy address should start with http://, not https://.
A rare https over https proxy is a proxy that the client established a https connection with the proxy. In this case, the address should be:
proxies = {"https": "https://localhost:3128"}
            ^^^^^   ^^^^^^
                     Notice: https

The connections:
Client <--https--> proxy <--https--> web
    \              /
     +----https---+

So, you are using a https-over-http proxy as a https-over-https proxy, hence the SSL error.
Actually, in requests, this error is shout out more clearly:
r = requests.get("https://kawayiyi.com/tls", proxies={"https": "https://elastic:elastic@localhost:3128"})

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/opt/brew/lib/python3.10/site-packages/requests/api.py", line 73, in get
    return request("get", url, params=params, **kwargs)
  File "/opt/brew/lib/python3.10/site-packages/requests/api.py", line 59, in request
    return session.request(method=method, url=url, **kwargs)
  File "/opt/brew/lib/python3.10/site-packages/requests/sessions.py", line 587, in request
    resp = self.send(prep, **send_kwargs)
  File "/opt/brew/lib/python3.10/site-packages/requests/sessions.py", line 701, in send
    r = adapter.send(request, **kwargs)
  File "/opt/brew/lib/python3.10/site-packages/requests/adapters.py", line 559, in send
    raise ProxyError(e, request=request)
requests.exceptions.ProxyError: HTTPSConnectionPool(host='kawayiyi.com', port=443):
Max retries exceeded with url: /tls
(Caused by ProxyError('Your proxy appears to only use HTTP and not HTTPS, try changing your proxy URL to be HTTP. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#https-proxy-error-http-proxy', SSLError(SSLError(1, '[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:997)'))))

The error message literally says: "Your proxy appears to only use HTTP and not HTTPS, try changing your proxy URL to be HTTP"
It seems that error message for curl_cffi should be updated to clarify this issue.

oH ，it works!! many thanks for your excellent works.

https://github.com/yifeikong/curl_cffi/blob/v0.6.0b7/curl_cffi/requests/session.py#L348
Please don't force this, a simple warning, or a check that can be disabled with a parameter is fine, but in this case I know what I'm trying to do.

On my end using a NordVPN proxy (format https://service_user:service_pass@uk2279.nordvpn.com:89) which is a HTTPS proxy, it fails no matter what I try. It works as-is https:// scheme in requests.
The user pass is not the account user pass but the Service Credentials in the Nord Dashboard.

"https" proxies key, with http:// in proxy string: RequestsError: Failed to perform, ErrCode: 56, Reason: 'Recv failure: Connection was reset'. This may be a libcurl error, See https://curl.se/libcurl/c/libcurl-errors.html first for more details..
"https" proxies key, with https:// in proxy string (with the http:// check removed): RequestsError: Failed to perform, ErrCode: 60, Reason: 'SSL certificate problem: unable to get local issuer certificate'. This may be a libcurl error, See https://curl.se/libcurl/c/libcurl-errors.html first for more details.
Doing the exact same request without the proxy to the same URL results in a normal and expected 403 Error as it is geoblocked.

Do you have any non-ASCII characters in your path of working directory or virtualenv？

Not that I can tell, no

What about adding verify=False?

What about adding verify=False?

Tried that too, but would just give a generic error.

Someone else is having the exact same problem as me surrounding the use of NordVPN proxies.

curl_cffi is not setting PROXY_CAINFO, only CAINFO. Hence the SSL errors.
https://github.com/yifeikong/curl_cffi/blob/418e452c99dee5da176f0b0a768337cd5509c4c5/curl_cffi/curl.py#L273
try session.curl.setopt(CurlOpt.PROXY_CAINFO, certifi.where())

curl_cffi is not setting PROXY_CAINFO, only CAINFO. Hence the SSL errors.
https://github.com/yifeikong/curl_cffi/blob/418e452c99dee5da176f0b0a768337cd5509c4c5/curl_cffi/curl.py#L273
try session.curl.setopt(CurlOpt.PROXY_CAINFO, certifi.where())

That does in fact work, and may be the real fix for everyone in this issue including the original OP. Replacing https://->http:// in the proxy connection URI is not the real fix and may only work if the proxy happens to support both, which NordVPN explicitly turned off HTTP-only proxies back a few years ago.
However, it's very slow. Like very slow. I get about 400-600 kb/s according to my own (likely inaccurate) speed calculation but it is definitely S.L.O.W. It also gives me the imo entirely invalid warning of:
RuntimeWarning: You may be using http proxy WRONG, the prefix should be 'http://' not 'https://', see:
https://github.com/yifeikong/curl_cffi/issues/6

It also gives me the imo entirely invalid warning

Mistakenly writing http tunneling proxy as https:// is a question that I have been asked millions of times. I believe putting the warning here does more good than evil. But perhaps it should be able to be disabled.

ret = self.setopt(CurlOpt.CAINFO, self._cacert)

Thanks for the pointer, I will add this in future versions.

it's very slow. Like very slow.

That's definitely a problem worth investigating. Could you please provide more details?

Mistakenly writing http tunneling proxy as https:// is a question that I have been asked millions of times.

It's not a mistake to do this, and if a user does it then it's their own fault. This is not something that should be a warning when it will effect anyone who does in fact need to use a https:// for a HTTPS proxy.

The fix

I just want to quickly note that this will need to be handled by Curl class in _ensure_cacert method. Doing it manually via session.curl.setopt will not work once the Curl.reset() method is called, i.e. on the second request of the Session/curl object. I can't even do a patched-class approach because the Session object doesn't honor it anyway when used in different threads as mentioned in the doc-string.

Possibly true fixes

Get rid of that http vs. https warning, it generally causes more confusion than otherwise. It leads people to believe their proxy is not a HTTPS proxy if it is a HTTPS proxy. And if it is a HTTPS proxy, we are now bombarded with annoying warnings. I get the idea as to why this warning is in place, but it generally serves no real purpose. Your handholding for the people who just copy-paste, and annoying anyone who needs HTTPS proxies.
In Curl._ensure_ca_cert just copy the two lines to also set the same _cacert property to PROXY_CAINFO curlopt.
In Session.__init__ instead of asking for a Curl object, ask for a callable that can be called to initialize a Curl object. That way I can pass e.g., Session(curl=PatchedCurl, ...) where PatchedCurl is a class and it can be used on construction of the session and on any thread. If I need to pass arguments to PatchedCurl, or even just Curl class, I can do so with functools like functools.partial, Session(curl=functools.partial(PatchedCurl, debug=True), ...).


v0.11.0 Version Update

We are running v0.11.0 and plan to update it, but as of v0.11.1, backwards compatibility is broken with the addition of zk_compression flag and the way data is stored in zk. What is the correct way of upgrading without losing Marathon state?

I'm concerned about "#2984 Failed migration 0.11.1 -> 0.14.0-RC3".
Could it be safer to jump directly to 0.15.3-1 without migrating to 0.11.1 initially?

Hey @irmakcakmak we suggest to always update zk state before updating to a newer version.
See https://mesosphere.github.io/marathon/docs/upgrade/index.html
If you are concerned, you can disable zk_compression.
@bergerx The migration logic in Marathon will handle this. You can jump directly to the latest stable version.

@aquamatthias thanks!


Tenant changes changes miq product features on all servers

alternative for: https://github.com/ManageIQ/manageiq/pull/20708 (first commit is from that PR)
miq product features contain tenant data. So we want to update the product features data
on all servers when a tenant is added or changes.
This allows us to remove special logic from the front end: https://github.com/ManageIQ/manageiq-ui-classic/pull/7430
Closes ManageIQ/manageiq-api#928
Closes ManageIQ/manageiq#20708

Overall LGTM...can you also add a Closes ManageIQ/manageiq-api#928 somewhere so we know this is linked to that?

According to the issue described in ManageIQ/manageiq-api#928, perhaps this should only be a part of after_create?

@Fryguy made that change - let me know if you have other ideas

@kbrock Can you rebase, and then I can merge?

@Fryguy thanks for the ping. I hadn't realized this had a conflict

Backported to ivanchuk via https://github.com/ManageIQ/manageiq/pull/20886

Backported to ivanchuk via https://github.com/ManageIQ/manageiq/pull/20886

Jansa backport details:
$ git log -1
commit 4bebcc479de3c78212fbbe4acff0955cbce48e83
Author: Jason Frey<EMAIL_ADDRESS>Date:   Mon Nov 16 09:59:29 2020 -0500

    Merge pull request #20772 from kbrock/invalidate_all_caches

    Tenant changes changes miq product features on all servers

    (cherry picked from commit c7836b284561b3c9e396c610333659e1c5e287eb)

Jansa backport details:
$ git log -1
commit 4bebcc479de3c78212fbbe4acff0955cbce48e83
Author: Jason Frey<EMAIL_ADDRESS>Date:   Mon Nov 16 09:59:29 2020 -0500

    Merge pull request #20772 from kbrock/invalidate_all_caches

    Tenant changes changes miq product features on all servers

    (cherry picked from commit c7836b284561b3c9e396c610333659e1c5e287eb)

Kasparov backport details:
$ git log -1
commit 49681cc277fe57ebe03bb39fda53635f61270165
Author: Jason Frey<EMAIL_ADDRESS>Date:   Mon Nov 16 09:59:29 2020 -0500

    Merge pull request #20772 from kbrock/invalidate_all_caches

    Tenant changes changes miq product features on all servers

    (cherry picked from commit c7836b284561b3c9e396c610333659e1c5e287eb)

Kasparov backport details:
$ git log -1
commit 49681cc277fe57ebe03bb39fda53635f61270165
Author: Jason Frey<EMAIL_ADDRESS>Date:   Mon Nov 16 09:59:29 2020 -0500

    Merge pull request #20772 from kbrock/invalidate_all_caches

    Tenant changes changes miq product features on all servers

    (cherry picked from commit c7836b284561b3c9e396c610333659e1c5e287eb)


[WIP] ENH - Handle low rank residual matrix in AndersonAcceleration

This aims to handle the case of singular residual matrix in AndersonAccelration class
According to Dual Extrapolation for Sparse Generalized Linear Models (cf. Proposition 7),
if the matrix of residuals is not full rank (U.T @ U singular) then we can extrapolate using the K-1 previous iteration.
The following proposes an implementation of this. It will proceed as follow

[x] handle the case of singular U.T @ U
[x] implement unitest
[x] perform benchmark against main

P.S. @mathurinm does this count as a citation :smile:

Thanks ! I think #33 should be done before, while AA is still relatively simple ?

Here are the result of the benchmark

alpha / alpha_max = 1

alpha / alpha_max = 0.1

alpha / alpha_max = 0.01

alpha / alpha_max = 0.001

I'm not that convinced with the result. I believe that handling the singularity case will pay off only if the opt problem at hand yields a lot of low-rank residual matrices.
I made an example that shows that handling the singularity is not as beneficial as we might think:
$$
u_{n+1} = \begin{cases}
u_{n}            & \text{ if } n \bmod 3 \\
\rho \ u_{n} + b   & \text{ otherwise }
\end{cases}
$$
In this particular case, handling the singularity case deteriorate the convergence speed (more iterations are required than a usual AA). Refer to debug_script for more details.
I'm not really in favor of complexifying the code for a minor detail.
What do you suggest @mathurinm? I believe in your foresight.

I'm not really in favor of complexifying the code for a minor detail.

Completely agree. Let's close this then, thanks !


net/http: r.FormValue() ignores the return value of ParseMultipartForm()

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.8.1 darwin/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/saleem/proj"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.8.1/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.8.1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/tx/9dlgzqg11c30qh8p6l3czn000000gn/T/go-build451820530=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

What did you do?
I have a Go Http endpoint that handles image uploads. From the client I make a POST request, with a content type multipart/form-data. I send some string key, value pairs and an image file.
On the server when I try to read the string values sent using request.FormValue("key_name")  I get an empty string. This is the source code of request.FormValue from net/http:
func (r *Request) FormValue(key string) string {
	if r.Form == nil {
		r.ParseMultipartForm(defaultMaxMemory)
	}
	if vs := r.Form[key]; len(vs) > 0 {
		return vs[0]
	}
	return ""
}

The return value of ParseMultipartForm is ignored. It is the ParseMultipartForm function which is failing. Why is the return value ignored?
What did you expect to see?
The error returned from ParseMultipartForm should have been handled in request.FormValue of the net/http package
What did you see instead?
The error returned from ParseMultipartForm is not handled.

Request.FormValue is a convenience, best-effort method. If it's not convenient, don't use it.
We can't change its signature (https://golang.org/doc/go1compat) even if we wanted to.
Typical caller code will check FormValue for acceptable values and return an HTTP 400 Bad Request or similar if the request is bogus or missing form values. If you really need to know specifically how the request is malformed, call ParseMultipartForm yourself.


ClimaLandSimulations: use functions instead of includes

Purpose

This PR refactor ClimaLandSimulations code to use functions instead of include(path). This does not change the functionality. #456
To-do

unresolved comments from last PR #441 :

[x] functions instead of include
[x] all sites (not just ozark) - need to update!
[x] inputs and outputs DataFrame with Unitful should be outside of fluxnet_simulation() (for speed and maybe GPU compatibility)
[x] Fluxnet module
[x] Allow changing 1 param (e.g., fluxnet_simulation("US-MOz"; params = ozark_default_params(; hetero_resp = hetero_resp_ozark(; b = 2)))) --- done
[ ] lib/ClimaLandSimulations/src/fluxnet_simulation.jl around line 266, why the +40? (this is in experiment/integrated as well)
drivers.TA.values[1 + Int(round(t0 / DATA_DT))] + 40# Get soil temperature at t0
[ ] add tests for utilities (e.g., getoutput, data_tools.jl, etc)
[ ] lib/ClimaLandSimulations/src/utilities/climalsm_output_dataframe.jl and others files, avoid hard-coding values
[ ] lib/ClimaLandSimulations/src/utilities/inputs_dataframe.jl do we always have all variables from fluxnet input files? (note: I think so, even if there are -9999 they should be there - if not we can create it)
[ ] Should LAI, RAI, plant_\nu be in met_drivers?
[ ] Check that buildkite figures are similar to experiment, when it is, remove experiment folder
[ ] Add modularity as an arg, for example, fluxnet_simulation("US-MOz", conductance = Medlyn)
[ ] Make the list of parameters shorter (use more default values or constants)

Content

[x] I have read and checked the items on the review checklist.

@juliasloan25 @kmdeck
Making our files function, they will return named tuples.
For example,
julia> out = site_setup("US-MOz")
(dz_bottom = 1.5, dz_top = 0.025, n_stem = 1, n_leaf = 1, h_stem = 9.0, h_leaf = 9.5, t0 = 1.0368e7, dt = 120.0, n = 15)

In our current code, those variables are in global scope, so we have two options, unpack them
julia> dz_bottom, dz_top, n_stem, n_leaf, h_stem, h_leaf, t0, dt, n = out
(dz_bottom = 1.5, dz_top = 0.025, n_stem = 1, n_leaf = 1, h_stem = 9.0, h_leaf = 9.5, t0 = 1.0368e7, dt = 120.0, n = 15)

julia> n
15

or access them from the named tuple (but in that case, we'll need to adjust the code)
julia> out.n
15

Do you think we should unpack (but in that case, the parameter list will be long...) or use the nested values from the named tuples? (and in that case, we'll just have nested variable names in the code)
Just wondering what you think is "best practice" / "more readable" ...

@juliasloan25 @kmdeck @Espeer5
The PR is not ready to be merged, but I replaced all include of files with functions, as you can see in src/fluxnet_simulation.jl
You'll notice a function fluxnet_simulation_test(...) in that src/fluxnet_simulation.jl that I did to test the functions. - will need to delete it, but I thought it could be helpful for code review.
Everything works (but only Ozark is implemented for now, adding the other sites following the same framework will be easy), but what do you think of the code design? There is a lot of nested variables in the code now (e.g., params.soil_heat.ν_ss_quartz).
I didn't change the general file structure that we had previously in experiments, but maybe we could group some files? (not sure if there is a way to be less messy). Basically, I am open to any code or file restructuration.
I think what will be important for functionality in future PRs will be to allow users to change modules (e.g., fluxnet_simulation("US-MOz", conductance = Medlyn), where conductance could be any submodel implemented), and I am not sure yet how we'd implement something like this. Nothing urgent but to keep in mind. (parameters number and name could change, etc.)
Another functionality we mentioned last time is having a function like run_simulation(met_data, params, domain, ...) or similar, the idea being where users can use their own meteorological drivers and parameters, configuration, etc. (not especially fluxnet). Maybe that would be for another PR. (but I mention it if it is relevant for code design now). I think Ed's PFT PR could be a start in that direction.

I will wait to try and merge #466 until this is done -> I will have the PFTs spit out parameters in NamedTuples like this instead of creating global scope variables for each. I like this, it's a lot cleaner to work with and should make writing different methods for getting different parameters from different places easier.

I will wait to try and merge #466 until this is done -> I will have the PFTs spit out parameters in NamedTuples like this instead of creating global scope variables for each. I like this, it's a lot cleaner to work with and should make writing different methods for getting different parameters from different places easier.

@Espeer5 Sounds good! We can merge this PR (#457) ASAP (I think we need to wait 4 days because of renaming) and then start another PR for the rest. I think this one is already quite big.

@juliasloan25 @kmdeck @Espeer5
I am wondering what's the best way for user parameters here.
In this PR currently it is entered as a NamedTuple, but it is not convenient for two reasons:

modularity (but Ed explained a possible solution above)
modifying just one param (what if, for example, user just want to change param.conductance.g1) --> it would be neat if one could do run_fluxnet("US-MOz"; params = ozark_default_params(; conductance.g1 = 2.3) for example

Is there a way we could use our model parameter constructor here?
for example ClimaLand.Biogeochemistry.SoilCO2ModelParameters (or any)

Everything works (but only Ozark is implemented for now, adding the other sites following the same framework will be easy), but what do you think of the code design? There is a lot of nested variables in the code now (e.g., params.soil_heat.ν_ss_quartz).

I am OK with nested variables! they are clear and internal. I would suggest though that we match the same naming convention that we use for p and Y - so just a single soil field (not soil and soil_heat), and follow the other names for canopy, canopy components, soil co2, etc.

I didn't change the general file structure that we had previously in experiments, but maybe we could group some files? (not sure if there is a way to be less messy). Basically, I am open to any code or file restructuration.
For now I think this is OK.

I think what will be important for functionality in future PRs will be to allow users to change modules (e.g., fluxnet_simulation("US-MOz", conductance = Medlyn), where conductance could be any submodel implemented), and I am not sure yet how we'd implement something like this. Nothing urgent but to keep in mind. (parameters number and name could change, etc.)
Agreed! it would be nice. FWIW, it will also always be an option to run the code like we currently do in experiments (a little more explicitly) for more custom runs that we find hard to incorporate into the interface.

Another functionality we mentioned last time is having a function like run_simulation(met_data, params, domain, ...) or similar, the idea being where users can use their own meteorological drivers and parameters, configuration, etc. (not especially fluxnet). Maybe that would be for another PR. (but I mention it if it is relevant for code design now). I think Ed's PFT PR could be a start in that direction.
in my opinion, being able to run with your own parameters and config is very important, but for now using different drivers is less important. Just thinking about our own use cases (simulating flux net sites with flux net data but with different parameters, which we need to do in calibration) as higher priority for now :)

Keep in mind that after Nat's work with moving things to parameters (for site level and global runs), and as we work to be able to handle globally varying parameters (for global runs), this interface will need to change a bit.

@juliasloan25 @kmdeck @Espeer5
I am wondering what's the best way for user parameters here. In this PR currently it is entered as a NamedTuple, but it is not convenient for two reasons:
* modularity (but Ed explained a possible solution above)

* modifying just one param (what if, for example, user just want to change param.conductance.g1) --> it would be neat if one could do `run_fluxnet("US-MOz"; params = ozark_default_params(; conductance.g1 = 2.3))` for example

Is there a way we could use our model parameter constructor here? for example ClimaLand.Biogeochemistry.SoilCO2ModelParameters (or any)

Yes! our constructors usually already allow for this. We can splat named tuples into kwargs too:
julia> function foo(;a=2, b = 3, c = 4)
       @show a;
       @show b;
       @show c;
       end
foo (generic function with 1 method)

julia> foo()
a = 2
b = 3
c = 4
4

julia> x = (b = 5,)
(b = 5,)

julia> foo(;x...)
a = 2
b = 5
c = 4
4```
 so, it would be good to make use of the constructors we already have, maybe by splatting the passed NamedTuple (with a shorter number of params, optionally)?

FWIW, there is still something wrong in the ozark plots. The soil water content is not changing in time. Perhaps before merging, we can make sure the output is correct? not sure if it is is on the plotting side or from something in the sim itself.

@kmdeck
I addressed most of your review comments, I think!
Mostly changes are: Fluxnet is now a module, and user can change some parameters from the default. I also used our struct from src for the parameters when possible, and wrote a comment when we couldn't

@kmdeck @juliasloan25
I think I've addressed almost everything, besides some comments where I think we need to think a bit more.
After we merge this PR, I will open another one listing the (long) to do list.


Add status to BleDisconnectedException

Summary
The status param of onConnectionStateChange provides useful information even when new state is disconnected, since it holds the reason for disconnection, if supplied by the remote peer.
From Bluetooth Core Specification v5.0, Vol 2, Part E:
7.1.6  Disconnect Command

Command Parameters:

Reason:
  Size: 1 octet

Value:
  0x05, 0x13-0x15, 0x1A, 0x29, 0x3B

Description:
  Authentication Failure error code (0x05),
  Other End Terminated Connection error codes (0x13-0x15),
  Unsupported Remote Feature error code (0x1A),
  Pairing with Unit Key Not Supported error code (0x29),
  Unacceptable Connection Parameters error code (0x3B).

I believe it is also possible to get status 0x8 (Supervision Timeout), 0x3e (Connection Establish Timeout), and 0x16 (Connection Terminated By Local Host) in a disconnect callback, when it is triggered by the local host stack.
Library version
1.4.0
Preconditions
Connection state change event indicating a disconnect with a non-zero status.
Relevant code is at RxBleGattCallback.java#L76.
Actual result
BleDisconnectedException without a status value.
Expected result
BleDisconnectedException with a status value.

Sorry for my English...
I would like to know if you can get the status 0x81 (GATT internal error) and 0x85 (GATT error) after closing this issue?

Possibly irrelevant comment @ThunderThrash: I'm struggling right now with error 0x81, which is reportedly a "generic Bluetooth error", i.e., seems to have no diagnostic value whatever. Enlightenment appreciated!

I think BleDisconnectedException with a status value is great.

Just to achieve a bit of "closure" with my previous comment: the "generic Bluetooth error" 0x81 turned out to be that I was attempting to enable notifications when I should have been using indications (or vice versa, forget which). Wouldn't it be swell if there were explicit causes given like this?

@RobLewis Since 1.4.0 operations that are requested but are not supported by the characteristic properties are logged as a warning. There is also an issue #259 which will be released with #239 - it will cause the above mentioned operation to emit BleIllegalOperationException with a explicit cause.

I should have clarified that the above error was in some Android-native (non-RxAndroidBle) code I inherited. Rewriting it now with Rx. What a difference!

@Cierpliwy Looks like this is the one we were talking about. Mentioning just to remember about it.


output filename contains folder name.

We are trying to update from typedoc 0.19 to 0.20.x but encountered an issue that the output filename contains the folder name. For example, previously, an output would be docs/classes/fileA.html but now it is docs/classes/_folderB_fileA.html (the path to file A is src/B/A.ts).
Is this a new behavior in 0.20.x? If so, is there option to set it back like before?

It sounds like you used to use "mode": "file", with "inputFiles": ["src"] and when upgrading just replaced inputFiles with entryPoints, without specifying the entry point file. This is generally not the ideal use of 0.20+. You should instead give TypeDoc your entry point, and it will document your exports, without nesting everything within modules.
This will result in file names similar to the old ones, since the file names are determined by traversing the hierarchy within the converted project.

@Gerrit0 could you past here the configuration example to keep the behavior like mode=file using the new version 0.20, please?


Rebuilt the *.html files (output for swagger) to pick up fixes

Ran the swagger-spec/update.sh file to rebuild/update the swagger output and pick up the api fixes.
Note: This appears to have not been run in awhile and the build has picked up several other fixes that ive not delivered myself.
Fixes #8977

Thanks. @nikhiljindal did this and also added the swagger for v1 in #9256.

Ok great, ill close this PR then since its a duplicate.


@mzikherman - [WIP] Starts fillwidth component

After a few false starts I'm starting to understand the react / graphql version of replicating @craigspaeth's jQuery filldwidth plugin. This will definitely be less generic than that, the reason being that we can make use of the aspect_ratio attribute that gets returned on artwork images (which makes calculating a row a bit easier, especially not having to wait for images to load.
This doesn't really do much atm, just getting some code up here.

Hm, looks like Dimensions screws with the type-check...that will be fun to figure out.

Looking like this so far:
(6 artworks)

(10 artworks)

This is ready to go, what say y'all?

Let’s 👍


Adding myself as owner and removing sebastienvas

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: utka
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sebastienvas
If they are not already assigned, you can assign the PR to them by writing /assign @sebastienvas in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

prow/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@utka: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
599c299ff8e50bcaa937701530ad7bbf0c603037
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nmittler, utka
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sebastienvas
If they are not already assigned, you can assign the PR to them by writing /assign @sebastienvas in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

prow/OWNERS
tests/OWNERS [nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/retest

Already changed


feat: :lock: IDMSv2 metadata restrictions

Metadata Options for Launch Template
Description
Adding metadata options to the launch template options, which will allow for IDMS v2 restrictions: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html
Checklist

[x] CI tests are passing
[x] README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

@barryib @brandonjbjelland @bryantbiggs It wasnt apparent in the contributing guidelines who would review this, but I'm wondering if someone could take a look


Download fixed/changed qlogs

qvis often fixes/changes qlogs (e.g., remove duplicates, order timestamps, etc.).
It would be nice to allow people to download the "fixed" qlog afterwards.
Similarly, downloading qlogs with the tool parameters embedded is also needed if we want people to share the same viewpoints on files.
Maybe show a list of "currently loaded files" in the filemanager with a download button next to them?
cc @LPardue

A variant of this is to support exporting a qlog subset. For example, wireshark allows filtering of a pcap and then export of only visible or exported packets. This can aid distributed troubleshooting or analysis because it helps cut out noise.

I've added a first POC of this in the latest commits. On the bottom of the filemanager, you can now download a (mostly) draft-02 formatted qlog that is internally generated from whatever you uploaded. Intent is to have easy examples of "correct" draft-02 qlogs and to prevent people from having to go through the pcap/netlog conversions for large files they frequently re-use.
This now also contains some "custom" fields injected by the code though, which isn't super-clean. It also doesn't support exporting a subset or tooling parameters etc. but early feedback is welcome.

I've added a first POC of this in the latest commits. On the bottom of the filemanager, you can now download a (mostly) draft-02 formatted qlog that is internally generated from whatever you uploaded. Intent is to have easy examples of "correct" draft-02 qlogs and to prevent people from having to go through the pcap/netlog conversions for large files they frequently re-use.
This now also contains some "custom" fields injected by the code though, which isn't super-clean. It also doesn't support exporting a subset or tooling parameters etc. but early feedback is welcome.


Could not load file or assembly 'System.Security.Principal.Windows, Version=<IP_ADDRESS>

Hi,
Thank you for the great job.
I'm running a test project that build on .NET Framework 4.6.1.
However,
when I installed the project, It didn't install System.Security.Principal.Windows.
I installed it manually version 4.5.1 in both projects, the Test project, and System Under test Project.
When I tried to run the test, when it reach the following code
var client = server.ClientForCurrentUser();
it throws an exception
Test method Zeva.WebConsole.Tests.UnitTest1.TestMethod1 threw exception:
System.IO.FileLoadException: Could not load file or assembly 'System.Security.Principal.Windows, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference.

When I looked at my bin directory I found this version of  System.Security.Principal.Windows: 4.6.26919.2.2
I added an assembly binding in my config file like this:
<dependentAssembly>
        <assemblyIdentity name="System.Security.Principal.Windows" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
        <bindingRedirect oldVersion="<IP_ADDRESS>" newVersion="4.6.26919.2.2" /></dependentAssembly>

But It doesn't work.
Can you please help ?
if it is not related to the library issues, feel free to close it.
Thanks

Take a look at https://github.com/dotnet/corefx/issues/34022 - that might be your issue.
Another point I would offer is that this is a netstandard2.0 library, but Framework 4.6.1 doesn't properly support netstandard2.0 - see footnote (2) on https://docs.microsoft.com/en-us/dotnet/standard/net-standard#net-implementation-support. You may want to try upgrading to .NET Framework 4.7.2 if possible.
I'll leave this open for now, but I'm 99% sure that this isn't an issue with TestHost.WindowsAuth itself.

Thank You Scott for your quick reply.
I solved my problem by deleting the package and install it again and it worked properly.
Thank you for the great job and have a nice day.


Slow Text Entry when creating or editing a task

Bug Report
IMPORTANT:
Please follow this template strictly when reporting bugs. Providing detailed and accurate information helps the development team to understand and address the issue effectively.
App Version: v2.0.2
Platform: Linux
Installation Method: Snap
Bug Description:
Upon loading up Sleek and trying to enter a new task, Sleek responded with an extreme delay. A 1 or 2 seconds between typing and seeing the letters.
Same behavior when opening a new task.
Note, I have 800 lines in my todo.txt (if that overhead is part of the problem)
[Provide a clear and concise description of the bug you encountered.]
Steps to Reproduce:

[List the steps to reproduce the bug. Be as specific as possible.]

Open Sleek. Use keyboard shortcut or clicking the add task button. Typing task.
Expected Behavior:
[Explain what you expected to happen.]
Immediately responsive text entry.
Actual Behavior:
[Explain what actually happened.]
Delayed text entry
Additional Information:

[Include any additional information that might be relevant to the bug, such as error messages or console logs.]

Screenshots:
[If applicable, include screenshots that demonstrate the bug.]

Experiencing the same. Unless you are on a really fast machine task entry can get very slow. Namely: current ryzen laptop is percievably slow but usable, older haswell laptop is a bit of a pain.

I'll also note that I'm also running sleek1.3.0 as the last version I was using before snap caused some problems.
That version isn't having problems with the exact same size text files!
(If text file size is a concern.)

@jason-mehmel @callegar can you please check this pre-release in your environment and provide a quick feedback, if the issue here still occurs?
https://github.com/ransome1/sleek/releases/tag/v2.0.3-rc.1
I created a fake todo list with 1.500 todos and ran this pre-release on a 2015 i3 Thinkpad. The difference between 2.0.2 2.0.3-rc.1 is huge on this device. I'm curious about your environments.

The 2.0.3 RC1 release appears to be faster, thanks! As soon as I am on my slower machine, I'll double check that it is fast enough even for it.

It's definitely much faster!
I am noticing a slight amount of delay when entering text, but nothing compared to previous. The delay I'm noticing is something that I can live with!

It's definitely much faster!
I am noticing a slight amount of delay when entering text, but nothing compared to previous. The delay I'm noticing is something that I can live with!

Do you notice that delay also while typing in the search bar? And may I ask on what kind of hardware you're on? Rather on the outdated or more modern side?

I don't think there's a delay in the search bar!
And the very slight delay I'm noticing maybe isn't there? I've tried just spamming the keys and I think it's slightly slower then typing in a text field like this one on github, but I can't verify that!
It's not causing any kind of delay that would interrupt my ability to use the program.
The laptop is about 5 years old I think? Main stats below.
-Computer-
Processor		: Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz
Memory		: 16263MB (16GB)
Operating System: BunsenLabs GNU/Linux 11 (Beryllium)


Provide different zk for global/local in MockedPulsarServiceBaseTest

@aloyszhang help fixed issue by PR #9193, which caused by mis-use localZk and globalZk.
It would be a great help if we could use 2 mocked zk in the MockedPulsarServiceBaseTest, one zk for localZk() and another for globalZk. So it could help protect this kind of error happens again.
e.g. in NamespacesTest.java the globalZk and localZk is the same zk:
    @Override
    @BeforeMethod
    public void setup() throws Exception {
        super.internalSetup();

        namespaces = spy(new Namespaces());
        namespaces.setServletContext(new MockServletContext());
        namespaces.setPulsar(pulsar);
        doReturn(mockZooKeeper).when(namespaces).globalZk();   < ===
        doReturn(mockZooKeeper).when(namespaces).localZk();     < ===
...

If we create 2 MockZooKeeper, then in the place where mockZooKeeper is returned, we could choose between global and local as needed.
        doReturn(mockGlobalZooKeeper).when(xxx).globalZk();
        doReturn(mockLocalZooKeeper).when(xxx).localZk();

@jiazhai  Thanks for open this issue. I'll work on this later.

@jiazhai  Thanks for open this issue. I'll work on this later.


Visual glitches

Hi !
Nice extension for a first one 👍
I've just spotted two little glitches, accented characters have encoding issue and the badge containing "à l'antenne" is braking from his line.

Thanks @mdarse! I suspect you encounter the bug on Firefox?

I encountered the same bug, in Firefox.

@oncletom Yes, on Firefox 59 (nightly)

It is so weird and I suspect there is something related to the i18n feature (it injects translations in CSS files).

Can you reproduce it on Chrome/Chromium as well? Sadly there is no way to start Chrome in French on an English macOS…

I don't see the problem in Chrome :

(on a sidenote, it feels like the type is bigger in Firefox than in Chrome)

Looks good now.

I suspect it was a browser bug.