Query sql error: null in

Steps to reproduce the behavior (Required)

DROP DATABASE IF EXISTS g0;
CREATE DATABASE g0;
USE g0;
admin set frontend config ("enable_decimal_v3" = "true");
CREATE TABLE IF NOT EXISTS t0 (c_0_0 INT NOT NULL ,c_0_1 CHAR(1) NULL ) UNIQUE KEY (c_0_0) DISTRIBUTED BY HASH (c_0_0) properties("replication_num"="1") ;
CREATE TABLE IF NOT EXISTS t1 (c_1_0 BOOLEAN NULL ,c_1_1 DECIMAL64(15, 4)  NULL ,c_1_2 DECIMAL(7, 3)  NOT NULL ,c_1_3 DECIMAL128(14, 0)  NULL ,c_1_4 CHAR(31) NOT NULL ,c_1_5 DECIMAL32(5, 2)  NULL ,c_1_6 DECIMAL32(6, 0)  NOT NULL ) DUPLICATE KEY (c_1_0,c_1_1,c_1_2,c_1_3,c_1_4) DISTRIBUTED BY HASH (c_1_1,c_1_2) properties("replication_num"="1") ;
CREATE TABLE IF NOT EXISTS t2 (c_2_0 VARCHAR(11) NULL ,c_2_1 DECIMAL64(13, 7)  NULL ,c_2_2 CHAR(21) REPLACE_IF_NOT_NULL NOT NULL ) AGGREGATE KEY (c_2_0,c_2_1) DISTRIBUTED BY HASH (c_2_1) properties("replication_num"="1") ;
INSERT INTO t1 VALUES (true, 7939556.3011, 0.000,<PHONE_NUMBER>5274, "F", 9.27, 435029);
INSERT INTO t0 VALUES (24, ""), (28, ""), (24, "");
INSERT INTO t2 VALUES ("TDCnP73nE", 0.0099742, "nLsA"), (NULL, 0.0923564, "hh");
INSERT INTO t2 VALUES ("Jir", 0.0728920, "");
INSERT INTO t2 VALUES ("E9", 0.0060752, "u7q"), ("", 0.0713655, NULL);
INSERT INTO t1 VALUES (NULL, 4948928.4200, 7.630,<PHONE_NUMBER>820, "f1", 0.88, 458850);
INSERT INTO t1 VALUES (true, NULL, 5.475,<PHONE_NUMBER>9739, "J8", 6.05, 152722), (false, 7442737.0955, 5.093,<PHONE_NUMBER>9694, "G", 8.13, 241004);
INSERT INTO t1 VALUES (true, NULL, 9.548,<PHONE_NUMBER>7629, "", 1.85, 619814), (false, 2766961.1179, 7.723,<PHONE_NUMBER>2992, "8qEo9", NULL, 210260);
INSERT INTO t0 VALUES (2, "");

mysql> SELECT t0.c_0_1, t2.c_2_0, t2.c_2_2 FROM t1,  t2 LEFT OUTER JOIN t0 ON t2.c_2_0 = t0.c_0_1 AND t2.c_2_0 > "" GROUP BY t0.c_0_1, t2.c_2_0, t2.c_2_2;
+-------+-----------+-------+
| c_0_1 | c_2_0     | c_2_2 |
+-------+-----------+-------+
| NULL  | Jir       |       |
| NULL  | NULL      | hh    |
| NULL  | TDCnP73nE | nLsA  |
| NULL  | E9        | u7q   |
| NULL  |           | NULL  |
+-------+-----------+-------+

mysql> SELECT t0.c_0_1, t2.c_2_0, t2.c_2_2 FROM t1,  t2 LEFT JOIN t0 ON t2.c_2_0 = t0.c_0_1 AND t2.c_2_0 > "" WHERE (NOT ((t0.c_0_1) IN ("") )) GROUP BY t0.c_0_1, t2.c_2_0, t2.c_2_2 UNION SELECT t0.c_0_1, t2.c_2_0, t2.c_2_2 FROM t1,  t2 LEFT JOIN t0 ON t2.c_2_0 = t0.c_0_1 AND t2.c_2_0 > "" WHERE (NOT ((NOT ((t0.c_0_1) IN ("") )))) GROUP BY t0.c_0_1, t2.c_2_0, t2.c_2_2 UNION SELECT t0.c_0_1, t2.c_2_0, t2.c_2_2 FROM t1,  t2 LEFT JOIN t0 ON t2.c_2_0 = t0.c_0_1 AND t2.c_2_0 > "" WHERE (((NOT ((t0.c_0_1) IN ("") ))) IS NULL) GROUP BY t0.c_0_1, t2.c_2_0, t2.c_2_2;
+-------+-----------+-------+
| c_0_1 | c_2_0     | c_2_2 |
+-------+-----------+-------+
|       |           | NULL  |
| NULL  |           | NULL  |
| NULL  | Jir       |       |
| NULL  | NULL      | hh    |
| NULL  | TDCnP73nE | nLsA  |
| NULL  | E9        | u7q   |
+-------+-----------+-------+

mysql>  SELECT t0.c_0_1, t2.c_2_0, t2.c_2_2 FROM t1,  t2 LEFT JOIN t0 ON t2.c_2_0 = t0.c_0_1 AND t2.c_2_0 > "" WHERE (NOT ((NOT ((t0.c_0_1) IN ("") )))) GROUP BY t0.c_0_1, t2.c_2_0, t2.c_2_2;
+-------+-------+-------+
| c_0_1 | c_2_0 | c_2_2 |
+-------+-------+-------+
|       |       | NULL  |
+-------+-------+-------+

Expected behavior (Required)
Real behavior (Required)
StarRocks version (Required)

You can get the StarRocks version by executing SQL select current_version()
branch-2.0 asan
mysql> select current_version();
+------------------------------+
| current_version()            |
+------------------------------+
| SQLANCER_MASTER_ASAN 6d468b7 |
+------------------------------+

Query Plan is correct

+--------------------------------------------------------------------------------------------+
| Explain String                                                                             |
+--------------------------------------------------------------------------------------------+
| PLAN FRAGMENT 0                                                                            |
|  OUTPUT EXPRS:12: c_0_1 | 8: c_2_0 | 10: c_2_2                                             |
|   PARTITION: UNPARTITIONED                                                                 |
|                                                                                |
|   RESULT SINK                                                                              |
|                                                                                |
|   10:EXCHANGE                                                                              |
|      use vectorized: true                                                                  |
|                                                                                |
| PLAN FRAGMENT 1                                                                            |
|  OUTPUT EXPRS:                                                                             |
|   PARTITION: HASH_PARTITIONED: 12: c_0_1, 8: c_2_0, 10: c_2_2                              |
|                                                                                |
|   STREAM DATA SINK                                                                         |
|     EXCHANGE ID: 10                                                                        |
|     UNPARTITIONED                                                                          |
|                                                                                |
|   9:AGGREGATE (merge finalize)                                                             |
|   |  group by: 12: c_0_1, 8: c_2_0, 10: c_2_2                                              |
|   |  use vectorized: true                                                                  |
|   |                                                                                |
|   8:EXCHANGE                                                                               |
|      use vectorized: true                                                                  |
|                                                                                |
| PLAN FRAGMENT 2                                                                            |
|  OUTPUT EXPRS:                                                                             |
|   PARTITION: RANDOM                                                                        |
|                                                                                |
|   STREAM DATA SINK                                                                         |
|     EXCHANGE ID: 08                                                                        |
|     HASH_PARTITIONED: 12: c_0_1, 8: c_2_0, 10: c_2_2                                       |
|                                                                                |
|   7:AGGREGATE (update serialize)                                                           |
|   |  STREAMING                                                                             |
|   |  group by: 12: c_0_1, 8: c_2_0, 10: c_2_2                                              |
|   |  use vectorized: true                                                                  |
|   |                                                                                |
|   6:HASH JOIN                                                                              |
|   |  join op: INNER JOIN (BROADCAST)                                                       |
|   |  hash predicates:                                                                      |
|   |  colocate: false, reason:                                                              |
|   |  equal join conjunct: 8: c_2_0 = 12: c_0_1                                             |
|   |  use vectorized: true                                                                  |
|   |                                                                                |
|   |----5:EXCHANGE                                                                          |
|   |       use vectorized: true                                                             |
|   |                                                                                |
|   3:Project                                                                                |
|   |  <slot 8> : 8: c_2_0                                                                   |
|   |  <slot 10> : 10: c_2_2                                                                 |
|   |  use vectorized: true                                                                  |
|   |                                                                                |
|   2:CROSS JOIN                                                                             |
|   |  cross join:                                                                           |
|   |  predicates is NULL.                                                                   |
|   |  use vectorized: true                                                                  |
|   |                                                                                |
|   |----1:OlapScanNode                                                                      |
|   |       TABLE: t2                                                                        |
|   |       PREAGGREGATION: OFF. Reason: Has can not pre-aggregation Join                    |
|   |       PREDICATES: 8: c_2_0 > '', 8: c_2_0 = ''                                         |
|   |       partitions=1/1                                                                   |
|   |       rollup: t2                                                                       |
|   |       tabletRatio=10/10                                                                |
|   |       tabletList=170524,170526,170528,170530,170532,170534,170536,170538,170540,170542 |
|   |       cardinality=3                                                                    |
|   |       avgRowSize=2.0                                                                   |
|   |       numNodes=0                                                                       |
|   |       use vectorized: true                                                             |
|   |                                                                                |
|   0:OlapScanNode                                                                           |
|      TABLE: t1                                                                             |
|      PREAGGREGATION: ON                                                                    |
|      partitions=1/1                                                                        |
|      rollup: t1                                                                            |
|      tabletRatio=10/10                                                                     |
|      tabletList=170501,170503,170505,170507,170509,170511,170513,170515,170517,170519      |
|      cardinality=6                                                                         |
|      avgRowSize=1.0                                                                        |
|      numNodes=0                                                                            |
|      use vectorized: true                                                                  |
|                                                                                |
| PLAN FRAGMENT 3                                                                            |
|  OUTPUT EXPRS:                                                                             |
|   PARTITION: RANDOM                                                                        |
|                                                                                |
|   STREAM DATA SINK                                                                         |
|     EXCHANGE ID: 05                                                                        |
|     UNPARTITIONED                                                                          |
|                                                                                |
|   4:OlapScanNode                                                                           |
|      TABLE: t0                                                                             |
|      PREAGGREGATION: OFF. Reason: Has can not pre-aggregation Join                         |
|      PREDICATES: 12: c_0_1 = '', 12: c_0_1 > ''                                            |
|      partitions=1/1                                                                        |
|      rollup: t0                                                                            |
|      tabletRatio=10/10                                                                     |
|      tabletList=170478,170480,170482,170484,170486,170488,170490,170492,170494,170496      |
|      cardinality=2                                                                         |
|      avgRowSize=1.0                                                                        |
|      numNodes=0                                                                            |
|      use vectorized: true                                                                  |
+--------------------------------------------------------------------------------------------+

Fixed by #2187


Server has been rewritten

Contains a solution for issue https://github.com/equoia/twitchtvaudio/issues/6


ST7789 display is blank

Seems to be a recurring issue with this driver. I'm sorry if this has been covered before. I'm an amateur when it comes to embedded and it's my first time doing it.
I have a Pi Pico with a Pimoroni Pico Display 2''. From the example in their repo and the datasheet I managed to figure out the display driver and pin layout, which other issues found here seemed to corroborate.
However, my display is black and the code seems to be stuck at the display  init() call.
I see the backlight turning on, but I don't see the LED on the board turning on. (Moving the led.set_high() to before the display intialization makes the LED turn on)
I've looked at the troubleshooting, tried to change the SPI mode to 0, 1, 2, 3. Nothing changes.
The display works, if I run the example in the manufacturer repo it runs flawleslly
Thanks in advance.
#![no_std]
#![no_main]

use bsp::entry;
use bsp::hal;
use defmt_rtt as _;
use hal::pac;
use panic_halt as _;

use hal::gpio::*;
use hal::Clock;

use rp_pico as bsp;

// Mipidsi drivers
use mipidsi::*;

// Embedded HAL
use embedded_hal::digital::OutputPin;

// Embedded graphics to draw on the display
use embedded_graphics::draw_target::*;
use embedded_graphics::geometry::*;
use embedded_graphics::pixelcolor::*;
use embedded_graphics::primitives::*;
use embedded_graphics::Drawable;

// Embed the 'Hz' function.
use fugit::RateExtU32;

// Display specs
const WIDTH: i32 = 320;
const HEIGHT: i32 = 240;

#[entry]
fn main() -> ! {
    let mut pac = pac::Peripherals::take().unwrap();
    let mut watchdog = hal::Watchdog::new(pac.WATCHDOG);

    let clocks = hal::clocks::init_clocks_and_plls(
        bsp::XOSC_CRYSTAL_FREQ,
        pac.XOSC,
        pac.CLOCKS,
        pac.PLL_SYS,
        pac.PLL_USB,
        &mut pac.RESETS,
        &mut watchdog,
    )
    .ok()
    .unwrap();

    let mut timer = hal::Timer::new(pac.TIMER, &mut pac.RESETS, &clocks);

    let sio = hal::Sio::new(pac.SIO);
    let pins = hal::gpio::Pins::new(
        pac.IO_BANK0,
        pac.PADS_BANK0,
        sio.gpio_bank0,
        &mut pac.RESETS,
    );

    let mut led_pin = pins.gpio25.into_push_pull_output();

    // Configure SPI pins for display
    let spi_mosi: Pin<_, FunctionSpi, PullNone> = pins.gpio19.reconfigure();
    let spi_sclk: Pin<_, FunctionSpi, PullNone> = pins.gpio18.reconfigure();

    // Init SPI
    let spi = hal::Spi::<_, _, _, 8>::new(pac.SPI0, (spi_mosi, spi_sclk));
    let spi = spi.init(
        &mut pac.RESETS,
        clocks.peripheral_clock.freq(),
        62_500_000.Hz(),
        embedded_hal::spi::MODE_0,
    );

    let dc = pins.gpio16.into_push_pull_output();
    let cs = pins.gpio17.into_push_pull_output();

    // SPI interface
    let spi_device = embedded_hal_bus::spi::ExclusiveDevice::new(spi, cs, timer).unwrap();
    let di = display_interface_spi::SPIInterface::new(spi_device, dc);

    // Reset pin must be set to high.
    let mut rst = pins.gpio22.into_push_pull_output();
    rst.set_high().unwrap();

    // Configure the backlight pin, set to high
    let mut bl = pins.gpio20.into_push_pull_output();
    bl.set_high().unwrap();

    // Initialize the display
    let mut display = Builder::new(models::ST7789, di)
        .reset_pin(rst)
        .display_size(WIDTH as u16, HEIGHT as u16)
        .invert_colors(options::ColorInversion::Inverted)
        .orientation(options::Orientation::default())
        .init(&mut timer)
        .unwrap();

    // Code never reaches here
    led_pin.set_high().unwrap();

    // Clear the display initially
    display.clear(Rgb565::GREEN).unwrap();

    // Draw a rectangle on screen
    let style = embedded_graphics::primitives::PrimitiveStyleBuilder::new()
        .fill_color(Rgb565::GREEN)
        .build();

    embedded_graphics::primitives::Rectangle::new(Point::zero(), display.bounding_box().size)
        .into_styled(style)
        .draw(&mut display)
        .unwrap();

    loop {
        // Do nothing
    }
}

Seems to be a recurring issue with this driver. I'm sorry if this has been covered before. I'm an amateur when it comes to embedded and it's my first time doing it.

No problem, these issues can be tricky to resolve if you aren't familiar with embedded designs and this crate. There have been quite a few ST7789 related issues lately. I don't know if this is just a sign that this is a popular controller or if we have a problem with our code or at least with incomplete documentation. Every reported issue gives us the opportunity to improve the crate.

However, my display is black and the code seems to be stuck at the display init() call.

That's weird. There is no two way communication between the controller and the display, so that it shouldn't be possible for init to hang, even if the display didn't initialize properly. But my guess that init panics for some reason and causes the panic_abort handler to be called. I would suggest that you switch to another panic handler to see what is causing the issue, like panic-probe which is used in the RP2040 template: https://github.com/rp-rs/rp2040-project-template/blob/main/Cargo.toml

Thanks, that was very helpful. I could see the error in terminal now.
assertion failed: width + offset_x <= max_width
I checked the ST7789 framebuffer size and is set to 240x320 instead of 320x240, that's why it's failing.
Swapping the values around fixed the issue.
Thanks a bunch, spent a good 3-4 hours debugging but without a error message it was hard to point the issue.


useFilter docs are in the useSortBy file

I just noticed that the docs for useFilter are at the end of https://github.com/tannerlinsley/react-table/blob/master/docs/api/useSortBy.md

Whoops! Coding on a plane... you know how it is... no shoulder room. 😂
Can you PR that to a new file?

Sure
On Thu, Dec 5, 2019 at 10:01 PM Tanner Linsley<EMAIL_ADDRESS>wrote:

Whoops! Coding on a plane... you know how it is... no shoulder room. 😂
Can you PR that to a new file?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tannerlinsley/react-table/issues/1722?email_source=notifications&email_token=AACAVVGYC6ANNIESRA2G7HLQXHTE7A5CNFSM4JWMU6I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGDDSKA#issuecomment-562444584,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACAVVH4TFFG5A4CGPPGKPLQXHTE7ANCNFSM4JWMU6IQ
.

https://github.com/tannerlinsley/react-table/pull/1723 :)


How to get the forecast result picture

Hello, Author
Thanks for the your great idea is in the field of time series prediction.When I run your code, I have some trouble. I really hope to get your help
when I run the single_step_main.py, I find I get a best_model.pth in folder named SingleStep,but i don't know how to view the forecast results of this model.The best thing is that I can intuitively understand the prediction results through the pictures. What should I do?

We are sorry that we did not provide visualization code in the current release. We will add visualization functions in the next version. You can also visualize the results using matplotlib in single_step_main.py.

Thank you very much for your reply! I have some more questions.In the main function of this file, which variable is used to save the prediction results?If I can know this, I will be able to do visualization through Matplotlib.Thank you again for your reply!

In line 143 of single_step_main.py, "mu_pre" stores the predicted results of the model. You can visualize it together with "label" to see the model prediction performance. I hope this can help you.

In line 143 of single_step_main.py, "mu_pre" stores the predicted results of the model. You can visualize it together with "label" to see the model prediction performance. I hope this can help you.

OK!I know what I should do. Thank you again!


follow all set of commands, but portal i think not installed

I follow all commands to setup bullhorn career portal, but i think its not working. Can someone help me.
See below what i did

first clone the career portal
node install, bower install, gulp install
fire gulp command

after that fired 2 commands

gulp --corpToken='[CORP_TOKEN]' --sl='[SWIMLANE]' --companyName='[COMPANY_NAME]' --liClientId='[LINKED_IN_CLIENT_ID]'
gulp serve --corpToken='[CORP_TOKEN]' --sl='[SWIMLANE]' --companyName='[COMPANY_NAME]' --liClientId='[LINKED_IN_CLIENT_ID]'

I think here i am missing some info.
I have corp token, swimlane, i used bullhorn login as company name and linked id
but no such processing when hit. so something is wrong
my main focus on bower as when i hit bower install no such processing done
and this is my directory structure
http://puu.sh/qotnW/0236e0db5f.png
I think setup didn't installed properly too.
Can you guide what went wrong.
Thanks!

Hello Djeet,
it looks like you are running linux, which version of node did you install? Also, what linux distribution are you using? I want to attempt to reproduce this.

Hello bulbajackel,
Yes its 'Ubuntu 14.04.3 LTS'
node js - v0.10.25
npm - v1.3.10
http://puu.sh/qpd1T/423479dcb0.png
Let me know.
Thanks!

Thank you @djeet! Can you try updating your version of NodeJS/NPM?
If that doesn't work, do you mind posting the output from your terminal when running the gulp command?
Hope that helps!

@djeet are you still unable to run CP?

Hello Guys,
There is much progress from last time. There were issues with the last server. Tested on new, kindly see below:
nodejs version - 0.10.37
http://puu.sh/qxSP9/2c97c46466.png
npm version - 1.4.28
git version
http://puu.sh/qxSQm/6c431a52cb.png
npm install -g bower
http://puu.sh/qxSME/d80e5abad6.png
npm install -g gulp
http://puu.sh/qxSSU/1a548bf328.png
npm install
big response, ending is like
http://puu.sh/qxT65/29110dcf6b.png
bower install
http://puu.sh/qxTdS/6f577b0209.png
then bower install with --allow-root
long output, last response - http://puu.sh/qxUba/c15bc68a7a.png
gulp build
http://puu.sh/qxUgc/2103093bf5.png
then
gulp --corpToken='[token]' --sl='[swimlane]' --companyName='[company]' --liClientId='[linkedid]'
http://puu.sh/qxUsO/bdb5ae1d57.png
this is the directory structure now
http://puu.sh/qxUMi/85cf1be7e7.png
is it correct?

Hello Guys,
There is much progress from last time. There were issues with the last server. Tested on new, kindly see below:
nodejs version - 0.10.37
http://puu.sh/qxSP9/2c97c46466.png
npm version - 1.4.28
git version
http://puu.sh/qxSQm/6c431a52cb.png
npm install -g bower
http://puu.sh/qxSME/d80e5abad6.png
npm install -g gulp
http://puu.sh/qxSSU/1a548bf328.png
npm install
big response, ending is like
http://puu.sh/qxT65/29110dcf6b.png
bower install
http://puu.sh/qxTdS/6f577b0209.png
then bower install with --allow-root
long output, last response - http://puu.sh/qxUba/c15bc68a7a.png
gulp build
http://puu.sh/qxUgc/2103093bf5.png
then
gulp --corpToken='[token]' --sl='[swimlane]' --companyName='[company]' --liClientId='[linkedid]'
http://puu.sh/qxUsO/bdb5ae1d57.png
this is the directory structure now
http://puu.sh/qxUMi/85cf1be7e7.png
is it correct?

Hey, djeet, your commands put a built and a ready to be uploaded version of the career portal in the /dist directory. Currently what is shown in the screenshots is correct.
If you upload the contents of dist to your webserver, what happens?


LOGIN PAGE

Describe the bug
Add elements in the login page
Expected behavior

Screenshots (optional)

Additional context (optional )

@pranjay-poddar plz assign me this issue


LaTeX not working

Describe the error
I have installed it exactly (I believe) as in the documentation, and it worked when I tried to run SquareToCircle, but it doesn't work when I try to run the OpeningManimExample.
Code and Error
Code:
under example_scenes.py, OpeningManimExample doesn't work.
Error:
Traced all the way back to
File "C:\Users[my name]\PycharmProjects\manimm\manimlib\utils\tex_file_writing.py", line 72, in tex_to_d
vi
"See log output above or the log file: %s" % log_file)
Exception: Latex error converting to dvi. See log output above or the log file: media/Tex/664e80e8d8d98
482.log
Environment
OS System: Windows 10
manim version: master  Latest version, about 2 weeks ago as of this issue.
python version:3.7

name: Same problem, latex giving funky errors
about: The error you encountered while using manim, when tried running programs using the "Tex" class
Describe the error
The error is given whenever I run latex related things on manim.
Code and Error
Code:
`from manimlib import *
class st(Scene):
def construct(self):
tex = Tex(r'x^{2}').scale(3)
self.add(tex)`
Error:
`sh: latex: command not found
ERROR:root:
LaTeX Error!  Not a worry, it happens to the best of us.
Traceback (most recent call last):
File "/Users/gabriel/.pyenv/versions/3.9.4/bin/manimgl", line 8, in
sys.exit(main())
File "/Users/gabriel/.pyenv/versions/3.9.4/lib/python3.9/site-packages/manimlib/main.py", line 17, in main
scene.run()
File "/Users/gabriel/.pyenv/versions/3.9.4/lib/python3.9/site-packages/manimlib/scene/scene.py", line 75, in run
self.construct()
File "start.py", line 5, in construct
tex = Tex(r'x^{2}').scale(3)
File "/Users/gabriel/.pyenv/versions/3.9.4/lib/python3.9/site-packages/manimlib/mobject/svg/tex_mobject.py", line 167, in init
super().init(full_string, **kwargs)
File "/Users/gabriel/.pyenv/versions/3.9.4/lib/python3.9/site-packages/manimlib/mobject/svg/tex_mobject.py", line 42, in init
filename = tex_to_svg_file(full_tex)
File "/Users/gabriel/.pyenv/versions/3.9.4/lib/python3.9/site-packages/manimlib/utils/tex_file_writing.py", line 52, in tex_to_svg_file
tex_to_svg(tex_file_content, svg_file)
File "/Users/gabriel/.pyenv/versions/3.9.4/lib/python3.9/site-packages/manimlib/utils/tex_file_writing.py", line 60, in tex_to_svg
svg_file = dvi_to_svg(tex_to_dvi(tex_file))
File "/Users/gabriel/.pyenv/versions/3.9.4/lib/python3.9/site-packages/manimlib/utils/tex_file_writing.py", line 94, in tex_to_dvi
with open(log_file, "r") as file:
FileNotFoundError: [Errno 2] No such file or directory: '/var/folders/7r/drxcwz0s5h9ggsqw4_5c0b2w0000gp/T/Tex/81b653697ca64401.log'`
Environment
OS System: mac
manim version: master, latest
python version: 3.9.4

Maybe you need to check:

whether adding LaTex to the environment variable
whether missing LaTex packages

Same problem for me.
LaTex error comes up when using manimgl, but not when using manimce
Environment
OS System: Windows
manim version: master, latest
python version: 3.9.4

You can consider the following steps:
1.Create TempLatex directory in C drive
2.Find manimlib/default_config.yml in the manim (manimgl version) directory and open it with a text editor
3.Modify line 18: before: temporary_storage: "" after: temporary_storage: "C:/TempLatex "
4.Save

I got the same problem with mikTex. Anyone has ideas?

@zhOrange Try use @MrHeavythree 's method. It worked perfectly for me.


Adding Malay Language Translation

I'm a Malaysian. Can I contribute to this by translating README.md to Malay version?

I want to work on this issue

I want to work on this issue

You're welcome to do so, we can work on it together translating to Bahasa Melayu.

Thanks guys, if you're done, mention me and I'll merge it

@dephraiim Alright I just forked it, I'll probably do it later.

@dephraiim Hello, I have done the Malay Translation.

https://github.com/EugeneGohh/awesome-developer-dictionary/blob/master/README-ms.md

Have a nice day @dephraiim goanna close this issue.


tests: add flag tests

Summary

originally part of #605, but separated due to scope.
Requires #605, however this could be merged into 605 and then into master.
Checklist

[x] If code changes were made, then they have been tested

[ ] I have updated the documentation to reflect the changes
[ ] I have formatted the code properly by running task lint
[ ] I have type-checked the code by running task pyright

[ ] This PR fixes an issue
[ ] This PR adds something new (e.g. new method or parameters)
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

.Marked as a draft as this requires 605 but should not be merged into said branch


Add ES module build

Describe the pull request
This PR adds a ES module entry point to the library at /esm/index.js in addition to the existing CommonJS entry point at /lib/index.js.
Why
Most new frontend tooling like esbuild, Vite, and most package CDNs these days are esm-first, i.e. CJS modules require extra work and helper functions to get converted to esm. Exposing an esm entry point saves some work for these tools and reduces code size due to removal of CJS conversion helpers.
How
I added a new .babelrc-esm config file that configures babel to output esm instead of cjs, and a build:esm script that makes use of the config to output to a /esm dir, and a new "modules" entry point in package.json to point to /esm/index.js for esm consumers.
Screenshots
N/A

As far as I can tell, this changes nothing about the existing CJS outputs and workflow, and only adds the ESM entry point on top. However, there is still a chance of breakage due to the fact that many tools resolve to the module entry point over main by default, so they'll automatically switch over to this new esm build once this is released. So if we wanted to be extra cautious, it may be worth releasing as a new major and noting this as a potential breaking change.
I've published a version with the changes in this PR here, and tested with my own projects. So far they seem to work identically as before.
Happy to iterate on this until you're happy with it. Cheers!

Thanks a lot for your pull request, really great and thorough work. I'm totally on board with the changes and agree with your reasoning.

Thanks for typing out this in-depth description, covers everything I could think of.
I like the approach of not adding new dependencies or new tooling, but rather using the existing ones in the project.
The published version over @lewisl9029/intro.js-react is a great idea, allowed me to quickly test it in various demo sandboxes that I have and it worked great.

So if we wanted to be extra cautious, it may be worth releasing as a new major and noting this as a potential breaking change.

I totally agree with that statement, specially considering the state of the ecosystem and how often we see packages having issues with the whole CJS/ESM thing. I think it's better to be safe than sorry.
The only thing I'm not 100% sure without further investigation are the package.json modifications and if we should also provides an pkg.exports field or not.
What I propose is the following:

I still have various projects using intro.js-react and I'd like to test this new version in them before releasing it. I don't think from my early tests that there will be any issues, but I'd like to be sure.
I would like to review the report from publint.dev and see if some recommendations should be applied or not.

I'll try to do all of this as soon as I can.
If you have any thoughts or remarks, please let me know.

Ah I didn't know about publint, those recommendations look great!
I think if we're going to do a major, we might as well do a few more potentially breaking changes so we don't have to do another one later down the line:

Add the exports field as it suggested and only expose the main index.js and maybe Step and Hint modules as the public API.
Add type: module to package json and rename the CJS modules to .cjs instead of renaming the esm to .mjs, since those will be used more often in frontend projects
Maybe remove the src dir from the files list to slim down the package size.

Happy to update the PR with those changes if you're onboard! :)

Oh and it could be worth considering passing an explicit browserlist to preset-env to minimize the need for polyfills. If a user needs support for older browsers, they could always configure their bundlers to transpile the package themselves.

Add the exports field as it suggested and only expose the main index.js

Definitely agree.

Add type: module to package json and rename the CJS modules to .cjs instead of renaming the esm to .mjs, since those will be used more often in frontend projects

I was about to say yes regarding this point and remembered that @markerikson talked a bit about ESM compat issues in Redux / RTK and also did a lot of research regarding this topic.
I found this recent PR (and also this comment) which I think could be a solid starting point considering all the tests and research that went into it, the webpack 4 issues, etc. Based on this, here is the configuration I suggest:
"main": "dist/cjs/index.js",
"module": "dist/es/index.js",
"types": "index.d.ts",
"exports": {
  "./package.json": "package.json",
  ".": {
    "types": "index.d.ts",
    "import": "dist/es/index.mjs",
    "default": "dist/cjs/index.cjs"
  }
},

Some comments regarding this configuration:

I suggest removing the existing lib folder and the newly introduced esm one and consolidate everything in dist/cjs & dist/es for consistency.
"module": "dist/es/index.js" is explicitely a .js file (for webpack 4 support) which is just a copy of the dist/es/index.mjs file (reference)
In the exports field, the "types": "index.d.ts", has to be the first one as documented in https://www.typescriptlang.org/docs/handbook/esm-node.html#packagejson-exports-imports-and-self-referencing

Maybe remove the src dir from the files list to slim down the package size.

Good catch. I have no idea why we have this in the first place. Looking at the blame this dates back to the initial release, not sure what I was thinking at the time. I think we can safely remove it.

Oh and it could be worth considering passing an explicit browserlist to preset-env to minimize the need for polyfills.

Sounds like a good idea and I think this can be inlined directly in the babel config files, e.g. "targets": "> 0.25%, not dead". Did you have any specific browserlist query in mind?

Happy to update the PR with those changes if you're onboard! :)

First, do you have any thoughts or objections regarding my last suggested changes? Maybe I missed something? If not, I would be happy to review such changes if you're still willing to update the PR. Otherwise I'll get to them when I have some time.
Once the changes are in, I would still like to do a quick test in various projects that I have and after that I think we should be good to go and release a new version.

@HiDeoo : hiya! Yeah, my own experience so far is that you should not use type: "module" in package.json, and you should use .mjs for ESM files.  (Except in the case of Webpack 4, in which case you should have a top-level "module" field that still has a .js extension.)
Also, there's a really neat project called https://arethetypeswrong.github.io/ that will inspect your package and let you know if TS thinks the entry points are defined properly, and I have put together a prototype CLI tool that uses that library.  See https://github.com/arethetypeswrong/arethetypeswrong.github.io/issues/15 for discussion.

@HiDeoo I know... I've been begging for years for someone who actually knows what they're doing to write such a comprehensive guide.
And no one has yet :(
I'm going to end up writing a blog post soon about what I've learned, but it's going to be "here's a bunch of stuff I've figured out by trial and error and I think half of that is still wrong", and definitely not a comprehensive authoritative guide.

I'm going to end up writing a blog post soon

Would definitely be a great addition to your dev blog and also a solid, even if not authoritative, help to the community considering the state of the ecosystem.

Wow, thanks for the discussion @HiDeoo and @markerikson, I never realized how deep this rabbit hole goes, learning so much haha.
I just pushed an update and published a new version for testing at<EMAIL_ADDRESS>(version 0.7.1-2). Also ran it through arethetypeswrong and results are here: https://arethetypeswrong.github.io/?p=%40lewisl9029%2Fintro.js-react%400.7.1-2
Everything looks good except for this one point:

Imports of<EMAIL_ADDRESS>under the node16 module resolution setting when the importing module is ESM (its extension is .mts or .mjs, or it has a .ts or .js extension and is in scope of a package.json that contains "type": "module") resolved to CJS types, but ESM implementations.

I believe this is because we're using the same index.d.ts declaration file for both the esm and cjs entry points, and due to the lack of type: module, it's being treated as a CJS module. When I first tried the package in my app, typechecking was broken with the following TypeScript error:
seems to work fine, so maybe this is safe to ignore?

Wow, thanks for the discussion @HiDeoo and @markerikson, I never realized how deep this rabbit hole goes, learning so much haha.
I just pushed an update and published a new version for testing at<EMAIL_ADDRESS>(version 0.7.1-7). Also ran it through arethetypeswrong and results are here: https://arethetypeswrong.github.io/?p=%40lewisl9029%2Fintro.js-react%400.7.1-7
Everything looks good except for this one point:

Imports of<EMAIL_ADDRESS>under the node16 module resolution setting when the importing module is ESM (its extension is .mts or .mjs, or it has a .ts or .js extension and is in scope of a package.json that contains "type": "module") resolved to CJS types, but ESM implementations.

I believe this is because we're using the same index.d.ts declaration file for both the esm and cjs entry points, and due to the lack of type: module, it's being treated as a CJS module. When I first tried the package in my app, typechecking was broken with the following TypeScript error:

After I removed the declare module wrapper from index.d.ts though, typecheck seems to work fine, but the same warning is still there, so maybe this is safe to ignore?
A few other things worth noting:

I consolidated the two babel configs into 1 .js config that branches based on env.
I used last 2 versions, not dead as the browserlist query. Including > 0.2% seems to end up including IE11 in the list and results in a bunch of helpers being added. Without it the output is nice and clean. I think we can ask users to transpile them module themselves if they need IE11 support so we don't waste bytes for everybody else.
Had to add this plugin to rewrite imports to include extensions for the mjs version to work properly.

@lewisl9029: yeah. That "FalseCJS" warning is what I'm getting for all the Redux alpha packages right now.
Per discussion with Andrew Branch from the TS team, the "Right" answer here is that you're supposed to somehow compile your types twice, once as "CJS" and once as "ESM", and have two different typedefs files.
I have not yet figured out a good way to do that in practice.  So, for now, I'm ignoring that warning.  (That of course means there's a good chance something will break :)  But there's only so many changes I can keep making to all this package configuration.)

@markerikson I managed to find a setup that gets rid of the warning by adding another layer of conditions and copy pasting the index.d.ts to each subfolder with the appropriate .d.mts/.d.cts extensions:
  "exports": {
    "./package.json": "./package.json",
    ".": {
      "import": {
        "types": "./dist/esm/index.d.mts",
        "default": "./dist/esm/index.mjs"
      },
      "default": {
        "types": "./dist/cjs/index.d.cts",
        "default": "./dist/cjs/index.cjs"
      }
    }
  },

Here are the new results: https://arethetypeswrong.github.io/?p=%40lewisl9029%2Fintro.js-react%400.7.1-9
So it seems like the warning was actually only complaining about the extension, and the actual content of the declarations file be in esm form.
For the case of this module and its handwritten declarations, all I had to do was copy paste it with the right extension. If you're generating the declarations with tsc it might get a bit more complicated. But just copy pasting the esm declarations to the cjs dir with .d.cts could still be worth a try? 🤔

Oh hey I just found this example in the handbook that seems to match this format pretty closely:
https://www.typescriptlang.org/docs/handbook/esm-node.html#packagejson-exports-imports-and-self-referencing
    "exports": {
        ".": {
            // Entry-point for `import "my-package"` in ESM
            "import": {
                // Where TypeScript will look.
                "types": "./types/esm/index.d.ts",
                // Where Node.js will look.
                "default": "./esm/index.js"
            },
            // Entry-point for `require("my-package") in CJS
            "require": {
                // Where TypeScript will look.
                "types": "./types/commonjs/index.d.cts",
                // Where Node.js will look.
                "default": "./commonjs/index.cjs"
            },
        }
    },
    // Fall-back for older versions of TypeScript
    "types": "./types/index.d.ts",
    // CJS fall-back for older versions of Node.js
    "main": "./commonjs/index.cjs"

Hopefully that means it should be reasonably well supported from the typescript side at least.

Thanks for catching those missed updates and the comments! I've updated the PR with all of the requested changes. Let me know if you find anything else.

@lewisl9029 :

I managed to find a setup that gets rid of the warning by adding another layer of conditions and copy pasting the index.d.ts to each subfolder with the appropriate .d.mts/.d.cts extensions:

Yeah, that's theoretically an option here.  Andrew Branch from the TS team would likely tell you that there could be subtle differences in the generated typedefs depending on whether you're treating it as an ESM module or a CJS module, thus the need to run tsc twice.  In practice, hopefully that's not a concern and you can get away with copy-pasting the file.

I've updated the PR with all of the requested changes. Let me know if you find anything else.

This looks great. I've slightly updated the Babel config for tests as Jest didn't like the consolidated new one as-is.
I'll start testing this new version in a few projects for a few days and I think we should be good. Do you mind updating @lewisl9029/intro.js-react with the recent changes? It would make testing a bit easier for me but if not possible, that is not an issue.

Sure thing, just updated the package with the latest changes at version 0.7.1-12. Let me know if you find anything!

Sure thing, just updated the package with the latest changes at version 0.7.1-12. Let me know if you find anything!

Well, all my tests in a few projects went well, did not hit any issues, mostly drop-in replacements. I think we, and especially you, did everything to make the change as non-breaking as possible with all the informations we had.
I will merge this PR right now, and when I get home with a bit of free time, update the changelog with some warnings and publish a new major version 1.0.0.
Thanks again for you amazing work and patience on this PR. I'll make sure to ping this thread when the new version is released.

🎉  v1.0.0 has been published to the npm registry. Thanks again for your work on this PR.

Thank you for the review and great suggestions! I learned a ton. :)


Migrating from /access-key to iam-role/ and iam-key/ endpoints to generate iam keys

After Exoscale forced us to move to new iam-role and iam-keys endpoints in their API provider-exoscale wasn't able to issue buckets anymore.
this merge request fix that
Checklist

[x] The PR has a meaningful title. It will be used to auto generate the
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
[x] PR contains a single logical change (to build a better changelog).
[ ] I have run successfully make test-e2e locally.
[ ] Update the documentation.
[x] Categorize the PR by adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog.
[ ] Link this PR to related issues or PRs.

Also there's a typo in the PR title :D Migratic

Please review last small change in last commit, it fixes observation of legacy keys. Tested in local kind cluster and lab cluster. Works ^^

@zugao @Kidswiss I need at least one aprooval :P

Now just wish new release with this :-D

Hello @newbenji, release will be done in less than an hour I guess


Add the ability to set names.

Signed-off-by: Hal Gentz<EMAIL_ADDRESS>

@grovesNL The example for {build,get}_combined_image_samplers() in the readme of spirv-cross includes setting the name for the new combined samplers. Currently spirv-cross makes their default name equal to "_{whatever the combinded id is}" , however, I don't see anything which guarantees that will always be the case in future versions.
For that reason I think it would be preferable for gfx-hal's gl backend to give the samplers made by spirv-cross a name in case we latter want to refer to them.
As far as I can tell, rename_interface_variable isn't appropriate for my use case.


Can it use cpu only?

My device doesn't support GPU.Can it be changed to support cpu?

You can change utils.py, line 58
with tf.device('/gpu:0'):
to
with tf.device('/cpu:0'):


Fix deserialize operations objects

This PR is a fix for https://github.com/jolicode/elastically/issues/197
Before fix

After fix

Looks great thanks!
Can you add a note in the CHANGELOG?
A new "Fixed" section here please:
https://github.com/jolicode/elastically/blob/1bbd506a92210a45c541d7df9b8de2d0b3972b8e/CHANGELOG.md#L10-L22

Looks great thanks!
Can you add a note in the CHANGELOG?
A new "Fixed" section here please:
https://github.com/jolicode/elastically/blob/1bbd506a92210a45c541d7df9b8de2d0b3972b8e/CHANGELOG.md#L10-L22

Done


Reset_extent is not behaving as expected with local file when raster extents is smaller than the shape extents.

Hi,
I've made some tests to illustrate the problem I am facing. Here is my initial shape (world) and a syntetic raster with a square in Minas Gerais, Brazil. Visualizing it with reset_extent set to False:

If we filter the shape to Brazil (smaller than the raster) and set reset_extent to True, it will visualize correctly the raster.

But if we leave reset_extent = True and tries to visualize the world, it will stretch the raster to the world extents and it has no meaning at all...

Am I missing something here?
Thanks,
Mauricio

mmm... hard to tell without the underlying data. Is it possible at all that the crs differ between the two? My first instict would be to set crs=world.crs to be sure they're both aligned, but maybe chuva.crs is the same?

Hi @darribas , here is a code snippet that pulls the raster (small) from the internet.
Besides the problem with the extents, I've noticed that the result with reset_extent=True is also upside-down. :)
import geopandas as gpd
import xarray as xr
import rioxarray as xrio
import contextily as cx

# get the world from geopandas
world = gpd.read_file(gpd.datasets.get_path('naturalearth_lowres'))
print(world.crs)

# get rain from INPE
# !curl -O http://ftp.cptec.inpe.br/modelos/tempo/MERGE/GPM/CLIMATOLOGY/MONTHLY_ACCUMULATED_YEARLY/MERGE_CPTEC_acum_sep_2022.nc
rain = xr.open_dataset('./MERGE_CPTEC_acum_sep_2022.nc')['pacum'].squeeze()

# set the CRS as the same from the world (EPSG:4326)
rain = rain.rio.write_crs(world.crs)

# save Rain as geotiff to be used in Contextily
rain = rain.rename({'lat': 'y', 'lon': 'x'})
rain.rio.to_raster('./rain.tif', compress='deflate')

# Open the rain as tiff just for checking
rain_tif = xrio.open_rasterio('./rain.tif')
rain_tif.plot(aspect='equal', figsize=(5, 5))

ax = world.plot(facecolor='none', figsize=(10, 7))
cx.add_basemap(ax=ax, source='./rain.tif', reset_extent=False)

rain.rio.to_raster('./rain.tif', compress='deflate')
ax = world.plot(facecolor='none', figsize=(10, 7))

cx.add_basemap(ax=ax, source='./rain.tif', reset_extent=True)


Add Web Component ADR

This PR just creates a new decisions directory in this repo where we can add architectural/product decision records, as well as adding an ADR for the decision to use web components going forward (many more ADRs to come in the near to medium term).

So I was about to edit this to capitalize Web Components consistently, because I'd been told it acts as a kind of brand that way and can be confusing otherwise. I've been pointed to the mdn web docs to support that point, but once I checked that source, they even do it inconsistently.
Not to hold up this PR, but can we make a call about which will be the case for us? cc @sarah-sch and @finekatie

So I was about to edit this to capitalize Web Components consistently, because I'd been told it acts as a kind of brand that way and can be confusing otherwise. I've been pointed to the mdn web docs to support that point, but once I checked that source, they even do it inconsistently.
Not to hold up this PR, but can we make a call about which will be the case for us? cc @sarah-sch and @finekatie

@annepetersen and @finekatie - My gut reaction is that we should capitalize because maybe lowercase "web components" could refer to something more like USWDS's current component collection (or one from another design system). Capital "Web Components" = the new technology we're adapting. Maybe eventually as this technology evolves and becomes commonplace we (and others) will shift towards lowercase, but for now I think capitalization might be helpful. Especially because I see it capitalized in other sources such as W3C and Wikipedia.
Totally open to other takes here. It's not a straightforward call, and I know we try to use caps somewhat sparingly.

So I was about to edit this to capitalize Web Components consistently, because I'd been told it acts as a kind of brand that way and can be confusing otherwise. I've been pointed to the mdn web docs to support that point, but once I checked that source, they even do it inconsistently.
Not to hold up this PR, but can we make a call about which will be the case for us? cc @sarah-sch and @finekatie

@annepetersen and @finekatie - My gut reaction is that we should capitalize because maybe lowercase "web components" could refer to something more like USWDS's current component collection (or one from another design system). Capital "Web Components" = the new technology we're adapting. Maybe eventually as this technology evolves and becomes commonplace we (and others) will shift towards lowercase, but for now I think capitalization might be helpful. Especially because I see it capitalized in other sources such as W3C and Wikipedia.
Totally open to other takes here. It's not a straightforward call, and I know we try to use caps somewhat sparingly.

I agree with Sarah on this. I think it requires capitalization for now to differentiate it from other instances where we refer to "components".

@heymatthenry and @thisisdano — still want to hear your input here, but given concurrence between the content strategists and I at least, I'll draft revisions

I love this discussion. I have a weak preference for lowercase because "web components" is just a colloquial descriptor for a specific technology ("HTML Custom Elements"). Beyond that, I only have a strong preference for consistency, so I'm happy with whatever looks like the consensus position.

Noting here for the record we had a discussion in Engineering sync that mostly supported capitalization for now


Add "refund insufficent funds" config option

Add the option to not refund buyer when the amount of krist paid is less than the amount needed to buy one of the desired product. This is a very evil option, but is the last refund type that doesn't either have a hook or config option to suppress it.

Testing this in all stores right now, working like a charm. The server is rejecting the transaction, and the shops are ignoring it.

awesome, thanks!


add vpn to mvp template

Hey Sab,
I can't validate the P.R because I don't have any rights on mulesoft-consulting org


Allow to pass multiple functions for the same event to md2po

If at least one of the functions returns False, skip parsing in that method.

Added in v0.3.51.


add provider information to the fleet

from #krew channel, it will be nice to add provider to the fleet output. (e.g. kind, gke, eks etc)

I am trying to add this feature today.

Cool! Also, let me know if you'd like me to create a new GitHub org, maybe fleet or the like and move this repo there, might make things easier, going forward.

sure, that will be great.

The PR is merged to add this feature.


Relative background-image URLs do not work within .vue

Relative background-image URLs don't seem to be resolving correctly within .vue files, i've tested this on sass and vanilla css.
Using the same property values inline within the
ie: chrome-devtools://devtools/static/img/geos.png instead of http://localhost:8080/static/img/geos.png

This has been fixed in<EMAIL_ADDRESS>https://github.com/vuejs/vue-loader-example/issues/43


wrong path of screenshot attachment when test result is in subdirectory

Step to reproduce

Make test result directory ex; TestResults
Put test result in subfolder ex; TestResults/device0
Run command below
run xchtmlreport -r ./TestResults/device0 -r ./TestResults/device1 -r ./TestResults/device2 -v

Observed result

Report can be created in ./TestResults/device0 as expected (/)
Wrong attachment links are found in the report ex;
/TestResults/TestResults/device0/1_Test/Attachments/Screenshot_34544FE6-9D9D-4A07-AADE-15EFE90102DD.jpg

Expected result
Link of attachment should be
**/TestResults/device0/**1_Test/Attachments/Screenshot_34544FE6-9D9D-4A07-AADE-15EFE90102DD.jpg

Hi @kamon70. Thanks for the report.
Which version did you experience this one?

1.6.0

@TitouanVanBelle : i see this issue happening for me as well even after #70 has been fixed. My test results are also in a sub-directory similar to to what @kamon70 mentioned earlier. I guess this is the reason why i only see screenshots in the report for the first device and not for the other devices.

@TitouanVanBelle : I think due to this issue the screenshots are not even appearing in the report when running the tests on a single device or simulator. I think either this issue or the 1.6.0 release broke that feature. We might wanna fix this soon. cc: @chrisballinger

I just worked on a fix that uses absolute paths for screenshots instead of relative paths. Waiting for the review. Once it's merged we might wanna release a patch fixing this and the version number of 1.6.0.


Rename configuration rename-rules to acronym-mapping

sdk part for fixing issue https://github.com/Azure/autorest.csharp/issues/2456

API change check
API changes are not detected in this pull request.


Unstable

I use some extensions, I work in Vue.js development, since many years, since the beginning. At that time many things were missing, VS Code was just a text editor.
Now, VS Code tries to be an IDE, I think, but the work is spread al over the extensions platform, which is like a wild west. I am sure each extension author tests their own work, but it is impossible for them to test all the combinations. This issue is here to signal the instability and unhealthiness of the whole VS Code extensions ecosystem. Most of the time I update an extension something will break. Like every week I loose either the formatting, or the linting, or something else. Then I have to either hunt down what went wrong, what settings changed, what extension works with another one at which version.
Most of the time it's Prettier, Vetur, ESLint or VS Code itself. One of these, or some combination.
Until now I couldn't upgrade Vetur from 0.25.0 because it would stop formatting because some dependency of their own.
Today I upgraded Prettier. I can't save my work anymore.

I know, each issue means me to open a new issue for the specific extension, or update my settings, and all that. But, I was working just fine, then came the upgrade of the extension. From that point it stopped working and I can't work, I get interrupted. When will this whole thing be more stable? What if this would be a car, and I would be stuck on the side of the road because I dared updating an extension?
I know this issue will be closed quickly, the point is please read it and think about this, how to make upgrading an extension less dangerous. Thank you.

Hi @csicky, thanks for taking the time to write this, I'm sorry that your experience has been so frustrating. Having extensions break hurts productivity and hurts trust in the product.
As you say, I am going to go ahead and close this issue since there is not a specific bug we can fix here, but we will keep this feedback in mind.


fix(pagination-style): fix issues in 'pagination-style' rule

This commit fixes two issues in the 'pagination-style' rule:

The "previous" and "last" properties are no longer required
to be defined in a paginated response schema.  This change
brings the rule more in sync with the API handbook guidance.

The rule previously did not correctly process an allOf list
while performing checks on the "first", "next", "previous" or
"last" response schema properties.  This is now fixed.

PR summary

PR Checklist
General checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] Dependencies have been updated as needed
[ ] .secrets.baseline updated as needed?

Checklist for adding a new validation rule:

[ ] Added new validation rule definition (packages/ruleset/src/rules/*.js, index.js)
[ ] If necessary, added new validation rule implementation (packages/ruleset/src/functions/*.js, updated index.js)
[ ] Added new rule to default configuration (packages/ruleset/src/ibm-oas.js)
[ ] Added tests for new rule (packages/ruleset/test/*.test.js)
[ ] Added docs for new rule (docs/ibm-cloud-rules.md)

Checklist for removing an old validation rule:

[ ] Removed old rule implementation (packages/validator/src/plugins/validation/*.js)
[ ] Removed or adjusted testcases (packages/validator/test)
[ ] Updated default configuration to deprecate old rule (packages/validator/src/.defaultsForValidator.js)
[ ] Removed docs of old rule (docs/ibm-legacy-rules.md)

:tada: This PR is included in version 0.26.1 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.77.1 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


[docs] Fix typo for flink conf in deployment on kubernetes

Why are the changes needed?

Fix  typo for flink conf in deployment on kubernetes
Brief change log

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? ( no)
If yes, how is the feature documented? (not applicable)

cc @tcodehuber

@zhoujinsong thanks for the review and merging!


Boost.SIMD release update

@pbrunet there's still the mm.hpp issue to fix!

@jfalcou @pbrunet: travis is o,, I'll merge this once boost.simd release is done (and update boost.simd files accordingly) cc

boost.simd released, waiting for travis to validate the change!


Assess if documented examples should be augmented

Various commands are shared with clients via the official Seqera support portal. We should ensure these examples make their way back to the official docs. This will allow tower-cli users to more effectively support themselves and ensure documentation can be more DRY.
Tickets to assess:

[ ] FD 5286

@gwright99 I think the tower-cli docs are being ported to docs.seqera.io.
Tagging @llewellyn-sl


JOBLIB issue

I get the following error when trying to run the phy kwik-gui command. I only get this issue when I try to run this command on a mapped (or remote) network drive. My machine is running Windows 10.
//// error ////
anaconda3\envs\klusta\lib\site-packages\phy\cluster\manual\controller.py:413: UserWarning: Persisting input arguments took 1.17s to run.
If this happens often in your code, it can cause performance problems
(results will be correct in all cases).
The reason for this is probably some large input arguments for a wrapped
function (e.g. large strings).
 If you can, kindly provide the joblib's team with an
example so that they can fix the problem.

It seems like a warning because of latency with remote data access. Maybe you could try to delete the .phy subfolder (remote), and create there a symlink named .phy to a local folder. That might improve speed.

thanks I check that out!


update charm-relation-interfaces to use prometheus_scrape schema that is compatible with pydantic v2

Issue
Closes #140
Solution
The prometheus_scrape schema includes an optional field for metrics_path.  Pydantic's semantics for how a field is marked as "optional" changed between v1 and v2, resulting in Pydantic v2 erroneously interpreting the metrics_path field as required.  This PR in charm-relation-interfaces updates the schema to use the pydantic v2 way of defining optional attributes.  The current PR updates our dependencies to use this fixed schema.
Also included here is a conversion of a unit test to scenario in order to reproduce the above issue.  The previous unit test conceptually should have caught this bug, but because the issue occurred when calling ._get_scrape_configs() (which is only called in __init__) unit tests did not reproduce this bug because Harness reuses the Charm object for all events (eg: __init__ is only called once during harness.begin(), not on every event like in real Juju).  By refactoring to scenario, we more closely reproduce true Juju behavior and capture the bug.
Context
see above and #140
Testing Instructions
The new scenario test was introduced first before the charm was fixed to demonstrate that the test captures the error from #140 - see this CI run that demonstrates this.  This scenario test should be sufficient to demonstrate the fix works, so if the CI is passing on the PR it should be good.
To reproduce entirely manually, see #140 for instructions.
Upgrade Notes
No special procedure needed.  Charm should work once refresh to the latest version.

@ca-scribner Does the PR still need to pull the library?

Reminder to self: we don't pin charm-relation-interfaces, so this PR is pulling the schema update already :)


Add extension icon

To stand out more in the vs-code marketplace and identifiability I think we should define an icon/image for the extension.
Instead of the default grey extension icon.

Great idea @FaBjE, I'm going to shoot some prompts against SD and see what we get.

Midjourney blessed us with the above.

Although better than no icon. My first thought was "bitcoin icon in blue"
Do you get this in an editable format (svg) or just this PNG?

@FaBjE Lol!! that didn't even cross my mind but you are completely right.
Back to the drawing board... I used Midjourney with a pretty simple prompt to generate it. I do have a workflow for generating SVGs from PNGs and I will ensure to run through it for the next batch.
I will just generate a bunch and together we can pick one.
Feel free to do the same guys.

I'm glad you see the same 😆
I currently have no experience in generating logo's with AI.
I mostly just bodge some MDI icons together in gimp.
I asked for the editable format because I don't think this is a bad start.
What I later (think i saw) is that it combined the T and B from TaskButton together into a single shape. Which isn't a bad idea.
Maybe if you change the (color) "contrast" between both letters it stands out more.
We could repeat the horizontal stripe of the T to symbolize (a series of) task buttons.
and perhaps add "ask" and "uttons" in a tiny/dark font to complete the words.


Bdog 205

After discussion we decided to hold implement this as part of BDOG-217 and cache results into mongo instead of configuring a shared cache.


Switch from Travis to OCaml-CI

Since Travis is more-or-less effectively dead it would be nice to switch to OCaml CI to get this project to build and see PRs get exercised by builders again. What do you think @verbosemode?

That's a great idea. I've already enabled the app for the repo and I'm reading through the instructions now. As soon as it it setup we can get rid of the travis config.

Great! Let me know if you need any help, I was able to successfully set it up for my system recently.
Relevant PR: https://github.com/ocurrent/ocaml-ci/pull/386

OCaml-CI has been enabled for the repository now. The change is included in PR #27

Thanks again for the suggestion and sorry for the delay. I've finally merged the PR :-)


Submitted status for split datasets from Upload

New datasets created on reorganize DAG will get the Submitted status since they are already validated.

This will be helpful, thanks!


possible bug in model.py[363] with tf0.12.1

After running the train script for celebA i get the following error:
WARNING:tensorflow:From /home/myuser/Workspace/DCGAN-tensorflow-master/model.py:96 in build_model.: histogram_summary (from tensorflow.python.ops.logging_ops) is deprecated and will be removed after 2016-11-30.
Instructions for updating:
Please switch to tf.summary.histogram. Note that tf.summary.histogram uses the node name instead of the tag. This means that TensorFlow will automatically de-duplicate summary names based on their scope.
Traceback (most recent call last):
File "/home/myuser/Workspace/DCGAN-tensorflow-master/main.py", line 96, in
tf.app.run()
File "/home/myuser/.local/lib/python3.5/site-packages/tensorflow/python/platform/app.py", line 43, in run
sys.exit(main(sys.argv[:1] + flags_passthrough))
File "/home/myuser/Workspace/DCGAN-tensorflow-master/main.py", line 76, in main
sample_dir=FLAGS.sample_dir)
File "/home/myuser/Workspace/DCGAN-tensorflow-master/model.py", line 75, in init
self.build_model()
File "/home/myuser/Workspace/DCGAN-tensorflow-master/model.py", line 107, in build_model
self.G = self.generator(self.z)
File "/home/myuser/Workspace/DCGAN-tensorflow-master/model.py", line 363, in generator
h0 = tf.nn.relu(self.g_bn0(self.h0))
File "/home/myuser/Workspace/DCGAN-tensorflow-master/ops.py", line 37, in call
return tf.contrib.layers.batch_norm(x,
File "/home/myuser/.local/lib/python3.5/site-packages/tensorflow/init.py", line 35, in getattr
contrib = importlib.import_module('tensorflow.contrib')
File "/usr/lib/python3.5/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 986, in _gcd_import
File "", line 969, in _find_and_load
File "", line 958, in _find_and_load_unlocked
File "", line 673, in _load_unlocked
File "", line 665, in exec_module
File "", line 222, in _call_with_frames_removed
File "/home/myuser/.local/lib/python3.5/site-packages/tensorflow/contrib/init.py", line 27, in
from tensorflow.contrib import factorization
File "/home/myuser/.local/lib/python3.5/site-packages/tensorflow/contrib/factorization/init.py", line 24, in
from tensorflow.contrib.factorization.python.ops.gmm import *
File "/home/myuser/.local/lib/python3.5/site-packages/tensorflow/contrib/factorization/python/ops/gmm.py", line 30, in
from tensorflow.contrib.learn.python.learn.estimators import estimator
File "/home/myuser/.local/lib/python3.5/site-packages/tensorflow/contrib/learn/init.py", line 66, in
from tensorflow.contrib.learn.python.learn import *
File "/home/myuser/.local/lib/python3.5/site-packages/tensorflow/contrib/learn/python/init.py", line 23, in
from tensorflow.contrib.learn.python.learn import *
File "/home/myuser/.local/lib/python3.5/site-packages/tensorflow/contrib/learn/python/learn/init.py", line 27, in
from tensorflow.contrib.learn.python.learn import estimators
File "/home/myuser/.local/lib/python3.5/site-packages/tensorflow/contrib/learn/python/learn/estimators/init.py", line 269, in
from tensorflow.contrib.learn.python.learn.estimators.classifier import Classifier
File "/home/myuser/.local/lib/python3.5/site-packages/tensorflow/contrib/learn/python/learn/estimators/classifier.py", line 25, in
from tensorflow.contrib.learn.python.learn.estimators import estimator
File "/home/myuser/.local/lib/python3.5/site-packages/tensorflow/contrib/learn/python/learn/estimators/estimator.py", line 52, in
from tensorflow.contrib.learn.python.learn.learn_io import data_feeder
File "/home/myuser/.local/lib/python3.5/site-packages/tensorflow/contrib/learn/python/learn/learn_io/init.py", line 22, in
from tensorflow.contrib.learn.python.learn.learn_io.dask_io import extract_dask_data
File "/home/myuser/.local/lib/python3.5/site-packages/tensorflow/contrib/learn/python/learn/learn_io/dask_io.py", line 26, in
import dask.dataframe as dd
File "/usr/local/lib/python3.5/dist-packages/dask/dataframe/init.py", line 3, in
from .core import (DataFrame, Series, Index, _Frame, map_partitions,
File "/usr/local/lib/python3.5/dist-packages/dask/dataframe/core.py", line 12, in
import pandas as pd
File "/usr/local/lib/python3.5/dist-packages/pandas/init.py", line 22, in
from pandas.compat.numpy import *
File "/usr/local/lib/python3.5/dist-packages/pandas/compat/init.py", line 357, in
from dateutil import parser as _date_parser
File "/usr/local/lib/python3.5/dist-packages/dateutil/parser.py", line 158
l.append("%s=%s" % (attr, value))
^
SyntaxError: invalid syntax
does anyone know how to get rid of it?

never mind, I'm an idiot.


Future-core-preview-0.3.0-alpha.12 fails to build on new nightly

Due to commit: https://github.com/rust-lang/rust/commit/d9a4b22d3291913a8f2158a1b7c195bc30c9286e#diff-31ce1b2eb51b1e216232d2d4770b8f92 which removed LocalWaker (and others), futures-core-preview now fails to build with:
error[E0432]: unresolved import `core::task::LocalWaker`
 --> /home/micucci/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-core-preview-0.3.0-alpha.12/src/future/future_obj.rs:6:12
  |
6 |     task::{LocalWaker, Poll},
  |            ^^^^^^^^^^ no `LocalWaker` in `task`

error[E0432]: unresolved imports `core::task::LocalWaker`, `core::task::UnsafeWake`
 --> /home/micucci/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-core-preview-0.3.0-alpha.12/src/task/mod.rs:8:35
  |
8 | pub use core::task::{Poll, Waker, LocalWaker, UnsafeWake};
  |                                   ^^^^^^^^^^  ^^^^^^^^^^ no `UnsafeWake` in `task`
  |                                   |
  |                                   no `LocalWaker` in `task`

error[E0432]: unresolved imports `std::task::Wake`, `std::task::local_waker`, `std::task::local_waker_from_nonlocal`
  --> /home/micucci/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-core-preview-0.3.0-alpha.12/src/task/mod.rs:10:21
   |
10 | pub use std::task::{Wake, local_waker, local_waker_from_nonlocal};
   |                     ^^^^  ^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^^^^^^^ no `local_waker_from_nonlocal` in `task`
   |                     |     |
   |                     |     no `local_waker` in `task`
   |                     no `Wake` in `task`. Did you mean to use `Waker`?

Wait #1445 merged

Thanks for the link!
Anyone: Any ETA on #1445?  It's already been over 2 weeks.
It sounds like it will take a while for this breaking change to be fixed (I would normally say this should be a super-high-priority, but I understand "things" happen :)).
I'll pin my Rust toolchain prior to the above commit until it's all working again.
Thanks!

Alpha 13 was released a few days ago, so this should be fixed. Let me know if you run into any problems!


Work on tests

I started writing somewhat proper tests due to /examples/* becoming unmanageable and the overall lack of test-cases we are actually covering.

Please double-check if I forgot some important test cases.
Did not test modules flow since it is so simple
Did not test exporters since I haven't looked into em and the one for packages seems to be broken? :thinking:  (examples/exporters)
Will add more examples and probably few more tests in the future

Also, I'd like to dump pretty much everything to /src/ or /nix/ folder (haven't decided on the name) to the cleanup root directory as well as rename exporters.
For example utils.lib.exporter.overlaysFromChannelsExporter - mentioning exporter twice is definetelly unecessary.
Anyways, what kind of naming would you guys like?


Github action to check formatting,lints, run tests

Adds a Github action to run a formatting check, Dart analyze and then run tests.
Currently all 3 steps fail due to various issues, I'll submit followup PRs to try to fix at least the formatting and lints.

LGTM


Simplify controlflow when mocking enabled

Can you please briefly explain why were these mocked responses superfluous? There doesn't seem to be more mocks further in in control flow...

@mirgee I don't understand why the code is there. It's trying to do this early return of
Ok(Vec::new());

but I'd expect that to just happen naturally when empty vector (the response) is passed to the parse methods.
Not tests are broken deleting this, so I think it's really unnecessary logic.


Correct api docs of PostRepo

... and report if needed forge_remote_id is not valid

Codecov Report
Patch coverage: 49.09% and project coverage change: -0.22 :warning:

Comparison is base (6c58e9d) 39.28% compared to head (3874dde) 39.07%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1974      +/-   ##
==========================================
- Coverage   39.28%   39.07%   -0.22%
==========================================
  Files         177      178       +1
  Lines       10734    10787      +53
==========================================
- Hits         4217     4215       -2
- Misses       6223     6276      +53
- Partials      294      296       +2

Impacted Files
Coverage Δ

pipeline/backend/docker/convert.go
8.46% <0.00%> (-0.14%)
:arrow_down:

pipeline/backend/docker/docker.go
0.00% <0.00%> (ø)

pipeline/backend/kubernetes/pod.go
0.00% <0.00%> (ø)

pipeline/frontend/yaml/compiler/convert.go
0.00% <0.00%> (ø)

pipeline/frontend/yaml/types/container.go
77.77% <0.00%> (ø)

server/model/pipeline.go
0.00% <ø> (ø)

server/model/step.go
0.00% <ø> (ø)

server/model/workflow.go
0.00% <ø> (ø)

...tastore/migration/020_parent_steps_to_workflows.go
59.45% <ø> (ø)

pipeline/frontend/yaml/compiler/compiler.go
7.10% <20.00%> (+0.28%)
:arrow_up:

... and 3 more

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


initial commit for M06

lots of updating in slides; activities and examples largely unchanged.

Initial feedback:
Timing of animation is weird in slides 8-10. why are "3 resolved" showing up at the start?
We had "odds and ends" (slide 38) as optional in the past.
Do we need self-ticking clock (Slide 43)?
For Slide44, I suggest remove everything except the link to module /activity page. Let's leave instructions in one place. We want to avoid having these updated in two places.
I will take another pass at new slides in the evening ... need to think thru these.

Adeel wrote:

Timing of animation is weird in slides 8-10. why are "3 resolved" showing up at the start?

Removed extra slide

We had "odds and ends" (slide 38) as optional in the past.

Changed title to "Optional Material"

Do we need self-ticking clock (Slide 43)?

Removed (sniff!).  I really wanted to demonstrate that the self-ticking clock from m05 was easy to build.  I've left the slide in at the very end, after the LO's.  But you're right it doesn't fit in, and it felt weird every time I taught it.

For Slide44, I suggest remove everything except the link to module /activity page. Let's leave instructions in one place. We want to avoid having these updated in two places.

Agreed.  We should have a boilerplate slide that we can use for every module.

Two things:

Here is the link for Canvas assignment for Team formation:
https://northeastern.instructure.com/courses/188155/assignments/2447002

Here is my detailed take on slides:
Slide 7: Waiting is something called pending?
Slide 8 animation still has "3 resolved and one waiting" displayed before first click.
Slide 9 animation: red stars are showing before first click
Slide 13: Suggest adding this:

Someone calls example(n)

..... this prints console.log

good

good in other words, yellow code is blocked or does not execute.

.... in other words, control returns from the function

caller continues

Slide 14: important point to add is: "more code" gets executed while p1 is waiting.
Question is, when do we switch to p1? After p0 is completed (i.e., more code finishes)
Slide 15 might have an error. It is missing: "returning to main" which will be printed before "main finished\n"
Slide 17: Suggest adding text that says something like "we intentionally serialized this order"
Slide 18: An important point that's missing here is, how do we use parallel processing or concurrency? We can create many promises (not force serial execution) and rely on browser to execute waiting promises independently. Promise all allows us to pause some computation until all promises are fulfilled.
Slide 21: Suggesting adding this to last bullet - i.e., control returns from this function with pending promise.
Slide 25: You can add another note in box that says, the responses may be received out of order.
Rest LGTM

Aagh!  markdown has messed with the numbering.  What do your "5. good" and
"6. good.." refer to?  Can you resend with some triple backticks so I can
see exactly what you mean?
On Tue, Sep 17, 2024 at 2:48 PM Adeel A. Bhutta @.***>
wrote:

Two things:

Here is the link for Canvas assignment for Team formation:
https://northeastern.instructure.com/courses/188155/assignments/2447002
2.
Here is my detailed take on slides:
Slide 7: Waiting is something called pending?
Slide 8 animation still has "3 resolved and one waiting" displayed
before first click.
Slide 9 animation: red stars are showing before first click
Slide 13: Suggest adding this:
3.
Someone calls example(n)
4.
..... this prints console.log
5.
good
6.
good in other words, yellow code is blocked or does not execute.
7.
.... in other words, control returns from the function
8.
caller continues
Slide 14: important point to add is: "more code" gets executed while p1 is
waiting.
Question is, when do we switch to p1? After p0 is completed (i.e., more
code finishes)
Slide 15 might have an error. It is missing: "returning to main" which
will be printed before "main finished\n"
Slide 17: Suggest adding text that says something like "we intentionally
serialized this order"
Slide 18: An important point that's missing here is, how do we use
parallel processing or concurrency? We can create many promises (not force
serial execution) and rely on browser to execute waiting promises
independently. Promise all allows us to pause some computation until all
promises are fulfilled.
Slide 21: Suggesting adding this to last bullet - i.e., control returns
from this function with pending promise.
Slide 25: You can add another note in box that says, the responses may be
received out of order.
Rest LGTM
—
Reply to this email directly, view it on GitHub
https://github.com/neu-se/CS4530-Fall-2024/pull/28#issuecomment-2356654045,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAR3CMAQ3I4PAMOMRQCZPSTZXB2ONAVCNFSM6AAAAABOKEFE2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJWGY2TIMBUGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

It messed up all of my comments and numbering. I have updated it above.

Newly formatted comments were much better, thanks.
I see we now have some merge conflicts associated with this branch.  Can you resolve them when you merge?

Are updates done? I can review again and try to fix merge conflicts

Updated script for slide #7.


shell commands: colourize messages

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

Adds colour to shell-based commands via a new ohai function, and adds a check for HOMEBREW_NO_COLOR where necessary.

What benefits does this have?

Consistency with .rb-based commands and readability. It's something I noticed, as one who has several VM windows open for testing and runs brew update-reset frequently.


Use body parameter to send post data

Currently when creating a commit the POST data is send via the query parameter. This leads to the Gitlab API to respond with 414 URI too long once there are several documents part of the commit.
This can be fixed when sending the data via the POST body attribute.

Thanks for fixing this!


Can not attach Aria Label to button.

Issue Description
For Terra Button, there doesn't look like it has an easy way to attach aria-label to the button. Given that terra-icon has the prop ariaLabel, buttons should have that same interface as well.
Issue Type

[ ] New Feature
[ ] Enhancement
[x] Bug
[ ] Other

Expected Behavior
ariaLabel is a prop on button
Current Behavior
ariaLabel is not a prop on button

Shouldn't this be handled with custom props?

Closing as already available in current API


Move the tools vendoring to its own vendor folder

Signed-off-by: David Gageot<EMAIL_ADDRESS>

@jromero I've rebased the PR


On https://prod-preview.openshift.io - Dialog to associate workitem with iteration is unclear

See attached screenshot - the wording is unclear. If a workitem is currently not associated with an iteration, then the dialog should not refer to the workitem being associated with a blank iteration name. It would better if the dialog simply said "this workitem is not yet associated with an iteration."

Out of date - no longer an issues - closing as part of pre-bug-triage tasks.


support 'deflate64'?

I'm using the zip 0.66 crate on top of flate2. It seems like deflate64 is not supported in flate2. Windows will use the deflate64 algorithm to zip files when the file size is 2G or more.
Is there any plan to support deflate64?

I have created an example as well and can add files larger than 4GB without problems.
Could you add a program that reproduces the issue here?

DEFLATE64 is not supported by any of the underlying libraries (zlib, zlib_ng, miniz_oxide - though zlib has some separate source code for decompressing it in it's contrib section). zip can handle >2G files fine with the normal deflate algorithm. The ZIP64 extension to the zip format is what's used for that to handle the 32-bit size issue from the original spec.
That's is not the same thing DEFLATE64. Apparently the zip compressor in windows uses DEFLATE64 on >2G files still for whatever reason otherwise there wouldn't be much use for for libraries/apps dealing with the .zip format to have support for it as it doesn't seem to give all that much advantage over standard DEFLATE and there are better and more modern algorithms like LZMA etc if you want something better than DEFLATE.
I don't know how much it differs from standard DEFLATE and how much it would take to e.g implement it in miniz_oxide. Since it's still not in zlib after all these years I wouldn't expect to see it in there any time soon. If support is added in one of the underlying libraries it would make sense adding the glue logic to swap method to flate2 as well but it's kinda borderline in scope here. If it differs enough that it would make more sense as a separate librarly to zlib/miniz_oxide it would probably not make sense to include with flate2.

@Byron @oyvindln Thank you for your response!
@Byron My issue is about something other than adding large files.  I need to read the content from the zip file which the Windows user generates in my tool. My tool works fine if the zip file is not using the Deflate64 algorithm, even when the size is more significant than 2G.
However, it seems like Windows would automatically use the Deflate64 algorithm when the user is trying to compress files larger than 2G. I am curious to know whether the Windows user has the option to choose the algorithm or not ( I guess not).
@oyvindln I fully understood why the Deflate64 algorithm is not part of the underline zlib. But the headache is that Windows is so popular; on the other side, Windows makes this algorithm the default (transparent to the end-user) even though the benefit is very marginal. So, I have to consider how to support it in my tool.  I agree with you that keeping it in zlib/miniz_oxide is better.

This popped up today: https://crates.io/crates/deflate64

This popped up today: https://crates.io/crates/deflate64

Hope the zip-rs crate can leverage this and support deflate64 when unzip.

Thanks for sharing! I think in order to resolve this particular problem, it's more likely that zip-rs will make use of the deflate64 crate than flate2 to learn how to decode such streams.
I am following the new issue over on zip-rs to stay in the loop though.


Mouse cursor offset in Firefox because of Resist Fingerprinting

Describe the bug
This is a twist on #4108.  The symptom is the same: the mouse cursor is offset in eframe_template on the web in exactly the same way the video on the issue demonstrates.  However, the actual cause here is Firefox's "Resist Fingerprinting" feature.
I don't know if there's actually a possible egui solution here because I suspect Firefox is just lying to the app somehow.  I'm opening this issue mostly to save the next person who runs into this some time.
To Reproduce
Steps to reproduce the behavior:

Serve egui_template locally with trunk serve,
Browse in Firefox with privacy.resistFingerprinting=true (which I think is set by the "Enhanced Tracking Protection" feature somehow).

Alternatively, just go to https://www.egui.rs/#demo in Firefox and the mouse will be offset there too.
Workaround
For the demo, you can add egui.rs to privacy.resistFingerprinting.exemptedDomains in about:config.  Adding localhost or localhost:8080 to the same setting doesn't seem to work.
Clicking on the shield icon to the left of the URL and disabling "Enhanced Tracking Protection" for the site doesn't seem to work.
Alternatively, set privacy.resistFingerprinting to false.  I'm personally doing this because this setting just breaks so many things.

Can reproduce this on macos. I think it must be related to these two things they note under "What does Resist Fingerprinting alter?":

The device pixel ratio is reported as 2.0.
The CSS Resolution is reported as the zoom level, instead of taking into account the true device pixel ratio.

I think egui should be able to handle this correctly though, since e.g. imgui doesn't break with the feature enabled.
I think something is weird in eframe's device pixel ratio handling right now, since there also is a bug when dragging the browser window between monitors of different resolutions


Add CI status badge to README

Add the following badges to README to quickly get the master branch CI status

Closed via  #86


TST: fix signal.convolve test that was effectively being skipped.

Fixes same issue as was fixed in gh-7355 (32-bit failures for
complex192 and float96).  The fix from gh-7355 basically disabled
the test, because _fftconvolve_valid just doesn't work
(it always returns False, due to the weird check for numerical
arrays at the end).
_fftconvolve_valid wasn't used anywhere else, so just removed it rather than try to understand the convoluted logic in it.

Tested on 32-bit platform, all OK.
Will backport just the fix (not the removal) to 0.19.x

Green except for the timeout.
Fix backported in 03b1092.

I don't understand why fftconv would be invalid if all the arrays are numeric. Must have been a piece of leftover code.
The logic in _fftconv_faster has been moved to choose_conv_method. It'd be nice to change this, it could look like:
def choose_conv_method(...):
    if measure:
        # ...
    fftconv_valid = _fftconv_valid(...)
    if not fftconv_valid:
        return 'direct'
    if fftconv_valid and _fftconv_faster(...):
        return 'fft'
    return 'direct'

The logic in _fftconv_faster has been moved to choose_conv_method. It'd be nice to change this, it could look like:

Makes sense. That's a small refactor of _fftconv_faster for readability, it looks fine now. Can be done independent of this PR, removing the dead function in here still makes sense (the good parts are duplicated in `choose_conv_method`` already as you point out.

Can be done independent of this PR, removing the dead function in here still makes sense

@stsievert are you happy then?

@Eric89GXL yup, there's no reason to tie it in with this PR

Thanks @rgommers


css rules from svg style selector ignored

steps to reproduce
Use this svg in the demo (https://gabelerner.github.io/canvg/examples.index.htm)
<svg width="480" height="60" xmlns="http://www.w3.org/2000/svg">
  <defs>
  <style type="text/css">
  svg {
    font-family: serif;
    font-size: 48pt;
    fill: blue;
  }
  </style>
</defs>
  <text y="50" x="6">serif 48pt</text>
</svg>

expected
Text is rendered in blue as 48pt serif:

found
Text is rendered in something else. It looks as if the rules between svg{ } were not applied:

notes

In an older version (I have a 2013-08-24 timestamp on the file) canvg did use the "global" css style rules as described under 'expected'
tested in firefox 34.0 and safari 8.0.2 (both on MacOSX 10.10.1)
workarounds

copy the style rules in the svg selector to selectors for individual elements (text {yaddayadda} is applied)
use attributes in the svg element instead of css style rules
(keep using the older version for a while)

screen shot from demo in attachment

closed by https://github.com/gabelerner/canvg/pull/341

this is not fixed.

yes this is not fixed.

Will be good to give support for css rules also not only for inline styles.

Still looks fixed to me...
Alarmed this apparently broke since it was fixed in February, I checked the original reproduction sample  against the current version (http://gabelerner.github.io/canvg/examples/ ). Result is 100% OK, though:

That said you probably did run into unexpected behavior with an svg that looked similar. Try and run it against the current version (link above) and if the problem persists, log an issue with the offending svg.


update travis with coveralls integration

add coveralls integration to travis

Changes Unknown when pulling cb65b1fad42f30c0a7b1ce8df48dae4aaf22f66f on feat-coverallIntegration into ** on master**.

Changes Unknown when pulling 3eb4e7e99b2f46b3c110c3b093e9ecc41557c422 on feat-coverallIntegration into ** on master**.


create a donation banner of the first run

Hi there, thanks for the wonderful project!
As we all know, not many companies are donating to opensource projects and that might kill then eventually.
You can come up with a sponsorware version which is one way, but some pentesters might never read a website (https://mpgn.gitbook.io/crackmapexec/news-2022/major-release-for-crackmapexec) and just use a pre-installed version with their favourite Linux distribution.
So I suggest creating a nice banner which would be displayed on the first run and user would need to type something long like:
Yes, I'm aware

Hi,
I've added a link to porchetta.industries in the banner https://github.com/byt3bl33d3r/CrackMapExec/commit/63db136f2be8385644d2f79206e2c7ccb5938f55


Broken link: https://100r.co/site/site/home.html

Where did you find this link?

https://www.patreon.com/posts/nasu-33704782
The guide link towards the bottom -- received this as an email

Thank you! Fixed it :)

Does not appear fixed for me yet.

Sorry, it seems like I made a draft instead of edit, should be good now ^^


Fix typo in schedulespec schema

Instead of FORBID it had FORBIF.

Can one of the admins verify this patch?

@mindscratch Thanks! Please see #121 - this will remove that part of the sentence.


feat(ethportal-api): add BeaconState type

What was wrong?
To add support for Era files, we need to deserialize the beacon state. No BeaconState type is available in ethportal-api.
How was it fixed?
Implement BeaconState type
To-Do

[ ] Clean up commit history and use conventional commits.

I think these test files should go in portal-test-specs.

I think these test files should go in portal-test-specs.

Hmm, not sure, those are test assets for ethereum beacon network, not related to portal network specs.

The repo is just has spec in the name because of convention (execution-spec-tests and consensus-spec-tests) the repo is just for test data. Expessially with how big these test data files are. This is exactly why the portal-spec-test repo was made so we didn't need to have big test files in ethereum/trin and so other portal implementations could reuse the same test data. I am assuming since we are using these test data file other portal beacon implementations would also find value in it as well. Those reasons don't have to be mutually exlusive though to put test data there.
So the general direction should be a migration from test_assets -> portal-spec-tests for where we host our test data.

I think these test files should go in portal-test-specs.

Hmm, not sure, those are test assets for ethereum beacon network, not related to portal network specs.

The repo is just has spec in the name because of convention (execution-spec-tests and consensus-spec-tests) the repo is just for test data. Expessially with how big these test data files are. This is exactly why the portal-spec-test repo was made so we didn't need to have big test files in ethereum/trin and so other portal implementations could reuse the same test data. I am assuming since we are using these test data file other portal beacon implementations would also find value in it as well. Those reasons don't have to be mutually exlusive though to put test data there.
So the general direction should be a migration from test_assets -> portal-spec-tests for where we host our test data.

Those test files are extracted from consensus-spec-tests repo because I don't want to add this repo as a submodule  - it is very huge, we want to use a few folders and use Git Large File Storage which will complicate our workflow.
Those files here are used for testing serialization/deserialization for the BeaconState which is part of the consensus specs and is used for deserializing Era files. I don't think that we want to migrate all test_assets to portal-spec-tests because most of those files are used to test Trin-specific implementations and not all of them are part of portal specs. I think portal-test-specs should be kept only for test assets for the portal network implementation which should not include consensus and execution layer test files.

The repo is just has spec in the name because of convention (execution-spec-tests and consensus-spec-tests) the repo is just for test data.

I don't think this is true. If we just want to have a repo for storing large files for testing in trin, it should be called trin-tests. Using the same convention as execution-spec-tests and consensus-spec-tests is not a coincidence, it is because we want to accomplish the same thing for the portal - store test assets and test vectors that are used for testing portal network specs.
@njgheorghita, @morph-dev  what do you think?

I'm not sure I have enough knowledge of beacon network and these files to provide opinion on this specific case. I'm also missing broader context of what portal-spec-tests should be (and if it should be follow the same principles as execution-spec-tests and consensus-spec-tests). With that being said, I will still give my opinion.
My feeling is that portal-spec-tests should contain test files that can/should be used by all clients in order to test their implementation of the Portal Network. Are all clients expected to deserialize Era files?!
Even if it is not required by portal network spec, but if it is expected or useful in general context (e.g. in order to verify data, build bridge, etc.), I would say they can go there (e.g. under special directory, with README file as explanation).
I also believe that we probably have some files in test_assets that we don't want to move to portal-spec-tests because they are trin specific.


Do you have any plan to upgrade this project repo to Godot 4.X ?

Hi @nightblade9 , this repo is good for godot 3.X, I always use it :)  but as many developers recently switch to godot4 do you have any plan to upgrade your repo to the new stage?

Hi, thanks for the feedback, happy to hear that it's useful for you!
I took a look at how this runs in 4.0, and it seems like it needs major changes or a complete rewrite. I don't really understand the underlying code myself (put it together from a couple of places). I'll see if I can put aside some time in the next couple of weeks to get this working in 4.0.

I have now completed upgrading this to Godot 4. Thank you again for poking me to get me to do this.
If you still need the 3.x version, it's now in the godot-3.x branch.
I will submit it to the assetlib ASAP.

@nightblade9 Thank you so much ! It works on my godot 4 project.