Open a call for co-maintainers

Hello there!
I'm mostly just a passerby on this repo, but my impression is that more co-maintainers on this repo might help with the backlog of pull requests and issues. Is that a fair assessment, and something you might be open to someone coordinating with you?
(I imagine it might simply be opening a new ticket and at-mentioning some past contributors into the conversation, and talking about what sorts of help (triage, testing, releasing, etc.) might be most helpful :)

I was just about to write very similar thing, I completely agree.

Why is it that all the last few pull request seem to be have been closed by the devs themselves? Is there any off-github conversation that I'm not seeing?

@dlsniper @nlopes ping?

Hey, would love some maintainers to help on this! I have been pretty much away from this for a while now due to busy work and health issues.
If someone would love access to help maintain nlopes/slack please let me know, I'll gladly accept.

Cool! Thanks @nlopes!
What about a lightweight "nominations and seconding" process? Anyone want to nominate someone else as a co-maintainer? (I don't know the community well enough to suggest otherwise.)

I don't know if there even needs to be a vote. Is there anyone that would volunteer?

Yeah, just trying to create space for this project to NOT fail hard because someone that everyone suspects is unqualified steps up (and no process to say no) ;)

Anyhow, whatever works. In the meantime, did some quick check over the issue queues, and fwiw I nominate @james-lawrence

he's been active in the issues queues
he's submitted a non-trivial PR before
he's helped triage and dedup some issues

https://github.com/nlopes/slack/issues?utf8=✓&q=commenter%3Ajames-lawrence
You still using the lib james?

Oh, and also @catherinetcai!

she +1'd this thread, so she cares
no activity on this repo, but she's active on github according to her graph
she has a bunch of source repos written in go

And one more, @jeberly :)

works at a slack-reliant company: https://chatlio.com/
on the downside, not much github activity, but maybe doesn't work on github thru day
he +1'd this post, so he cares

@patcon Ahhhh - called out!
I've been playing around with it a bit. Would love to help maintain.

we're still using this library at my company. Happy to help if we're looking for additional maintainers.

Alright, I'm adding @james-lawrence, @jeberly, @catherinetcai and @patcon for now.
I'll still contribute but I'm hoping the above will help move the PR's and issues forward (for which I have no time).
I don't have a code of conduct in the repo (unfortunately) so please play nice (or draft one if you're so inclined).
If there are other people wanting to contribute that weren't above in comments, please let me know, else I'm closing this issue in a week from today.

sounds good. I'll try to get in touch with everyone next week to figure out logistics.

@42wim, would you be interested? since you use this for matterbridge, and I know that you're a rad maintainer

Is there an IRC or a Slack where we could congregate to discuss/plan?

Thanks :) can you add @dvdplm as well? He is at Chatlio too and has some PRs already.  We can't commit to full time maintainers, but we can help from time to time.  If a small financial sponsorship would also help, reach out to me at john [at] chatlio.com.

@catherinetcai I like the way you think
I created a gitter room, and there's a PR for the badge, if that seems simplest:

https://gitter.im/go-slack/Lobby#
https://github.com/nlopes/slack/pull/220

(invited everyone who interacted with this thread -- sorry if presumtuous!)

@patcon thanks for thinking about me ;-)
I can help here and there, but I think there are enough extra maintainers now to get the burden of nlopes.

@jeberly: I've added @dvdplm as well. Closing this issue now, I think we've got enough people to get this going. Huge thank you to all that volunteered to help. My gratitude is immense.


Vulnerability roundup 97: nomad-0.11.4: 1 advisory [6.5]

search, files

[ ] CVE-2020-28348 CVSSv3=6.5 (nixos-20.09)

Scanned versions: nixos-20.09: 50c8d1e0deb.
Cc @endocrimes
Cc @pradeepchhetri
Cc @rushmorem

See also: #102886


Is there a task to replace configuration parameters?

I would like to replace some configuration parameters in yaml files, is there functionality present in deployer. Otherwise I would like to help to implement this.

Just wondered if this would also allow for parameter setup on initial deployment?
Composer will die on symfony2 installs if the db parameters are incorrect as it tries to connect to any configured DB when warming the cache.
This means on first deployment of a new code base the deployer will die unless the parameters in parameters.yml.dist are correct. Those who don't want to store db passwords in their repositories will run into problems.
Composer will actually prompt for values to put into parameters.yml on first install. I remember when I used to use capifony that it would relay these prompts back to the user.
Any chance this functionality will be adopted?

Yes, it's possible to implement this for Symfony2 deploy. Now Deployer runs composer with no-interaction key and this is good solution. But it's really easy to implement parameters.yml creation.
PS I deploy all my Symfony apps with Deployer, and deployment of new code base was ok, even without parameters.yml (Symfony don't connect to db when warming cache).

Ok, I'll look into the interaction thing.
But I just did a new deployment and composer failed because it couldn't find symfony db (what the db name was set to in parameters.yml.dist) in my mysql server.
When updated the db name to the correct one then it proceeds fine. Perhaps you already have the correct db credentials in the parameters.yml.dist.

Did you run migration tasks too?

Nope, there is no database migration to be done. Also as far as I'm aware you can't run migration before you've run composer as it needs all the dependencies composer downloads. And composer fails at cache stage.

Will try to reproduce it myself.

Perhaps it's something specific to things I've done in my entities. I'm using JMS serializer with doctrine.

Yes, it's possible to implement this for Symfony2 deploy. Now Deployer runs composer with no-interaction key and this is good solution. But it's really easy to implement parameters.yml creation.

I didn't get it, can you please provide an example. It would be very helpful for initial deploy.

I ran into the same thing. This article explains why doctrine try connect to db on cache clearing:
http://stackoverflow.com/questions/34023813/symfony-2-7-cacheclear-command-checks-every-database-connection

Why it's run composer install without interaction event if I've override it like:
// dev server
server('dev', 'host', 22)
    ->user('user')
    ->identityFile()
    ->stage('dev')
    ->env('deploy_path', '/var/www/html/')
    ->env('branch', 'develop')
    ->env('env_vars', 'SYMFONY_ENV=dev')
    ->env('env', 'dev')
    ->env('composer_options', 'install')
;

?

@whyte624 did you managed to implement parameters.yml creation ?

@CharlyPoppins I'm creating build-time in a different place now.
More or less like that:  https://github.com/octava/BranchingBundle/blob/master/Composer/ScriptHandler.php

Ok thx I'll have a look

@elfet I'm not sure to understand.
The Symfony recipe run "composer install" with the --no-interaction option.
BUT this is not right for a general porpose because at the first deploy Composer needs to ask for the insersion of the parameters. (and when there are new parameters in parameters.yml.dist too)
We CAN remove --no-interaction from the composer_options
BUT it doesn't work
BECAUSE the run() function, used to run composer install, is not interactive.
Is there a way to have an interactive run()? (in Deployer\Server\Remote\NativeSsh)
Thanks

@danielsan80 yes, this will be possible in v5, see #1092

Ok,
so, waiting for v5, we can write a deploy:build-parameters task, to execute before deploy:vendors, who does the job of Incenteev\ParameterHandler\ScriptHandler::buildParameters. In this way composer install --no-interaction could be safe executed.
Here an example:
<?php
namespace Deployer;

use Symfony\Component\Yaml\Parser;
use Symfony\Component\Yaml\Yaml;
use Symfony\Component\Yaml\Inline;

task('deploy:build-parameters', function () {

    // Reset the tmp dir
    $tmpDir = '.tmp/deploy';
    exec('rm -Rf '.$tmpDir);
    @mkdir($tmpDir, 0775);

    // Download the parameters files
    try {
        download($tmpDir.'/parameters.yml', '{{release_path}}/app/config/parameters.yml');
        download($tmpDir.'/parameters.yml.dist', '{{release_path}}/app/config/parameters.yml.dist');
    } catch (\RuntimeException $e) {
        //Ignore exceptions
    }

    // At least parameters.yml.dist should be downloaded
    if (!is_file($tmpDir.'/parameters.yml.dist')) {
        throw new \InvalidArgumentException(sprintf('The dist file "app/config/parameters.yml.dist" does not exist.'));
    }

    $file = $tmpDir.'/parameters.yml';
    $distFile = $tmpDir.'/parameters.yml.dist';
    $exists = is_file($file);

    $yamlParser = new Parser();

    $action = $exists ? 'Updating' : 'Creating';
    writeln(sprintf('<info>%s the "%s" file</info>', $action, 'app/config/parameters.yml'));

    // Find the expected params
    $expectedValues = $yamlParser->parse(file_get_contents($distFile));
    if (!isset($expectedValues['parameters'])) {
        throw new \InvalidArgumentException(sprintf('The top-level key %s is missing.', 'parameters'));
    }
    $expectedParams = (array) $expectedValues['parameters'];

    // find the actual params
    $actualValues = array_merge(
        // Preserve other top-level keys than `$parameterKey` in the file
        $expectedValues,
        ['parameters' => []]
    );

    if ($exists) {
        $existingValues = $yamlParser->parse(file_get_contents($file));
        if ($existingValues === null) {
            $existingValues = [];
        }
        if (!is_array($existingValues)) {
            throw new \InvalidArgumentException(sprintf('The existing "%s" file does not contain an array', 'app/config/parameters.yml'));
        }
        $actualValues = array_merge($actualValues, $existingValues);
    }

    $actualParams = (array) $actualValues['parameters'];

    // Ask to the user for the missing params
    $isStarted = false;
    foreach ($expectedParams as $key => $message) {
        if (array_key_exists($key, $actualParams)) {
            continue;
        }

        if (!$isStarted) {
            $isStarted = true;
            writeln('<comment>Some parameters are missing. Please provide them.</comment>');
        }

        $default = Inline::dump($message);
        $value = ask(sprintf('%s:', $key), $default);

        $actualParams[$key] = Inline::parse($value);
    }

    $actualValues['parameters'] = $actualParams;

    // Save and upload the updated parameters.yml
    file_put_contents($file, "# This file is auto-generated before the composer install\n" . Yaml::dump($actualValues, 99));
    upload($tmpDir.'/parameters.yml', '{{release_path}}/app/config/parameters.yml');
});

than:
before('deploy:vendors', 'deploy:build-parameters');

In v5 it will be simple like this:
run('composer install', ['tty' => true]);

In v5 it will be simple like this:
run('composer install', ['tty' => true]);

Where do i put this line?

I was wondering yesterday: found tte command there :
//vendor/deployer/deployer/recipe/deploy/vendors.php
namespace Deployer;

desc('Installing vendors');
task('deploy:vendors', function () {
    if (!commandExist('unzip')) {
        writeln('<comment>To speed up composer installation setup "unzip" command with PHP zip extension https://goo.gl/sxzFcD</comment>');
    }
    run('cd {{release_path}} && {{bin/composer}} {{composer_options}}');
});

I think you have to override the command like this (not tested) :
run('cd {{release_path}} && {{bin/composer}} {{composer_options}}', ['tty' => true]);

A set() parameter would have been simplier (contributors if you hear me :D)

Does not work for me. Instead of prompt for parameters, i still get An error occurred when executing the "'cache:clear --no-warmup'" command:  exception.
Just to make sure i am doing it right - modified line 12 in ~/.composer/vendor/deployer/deployer/recipe/deploy/vendors.php


Change "ctype" to "dtype" in the "buffer" methods?

When I created the methods buffer_read(), buffer_read_into() and buffer_write() in #72, I gave them a ctype parameter to specify the data type used in the buffers. The possible values of this parameter were motivated by the corresponding function names in the libsndfile API, which contain them as substrings: 'double', 'float', 'int', 'short'.
Looking back at this now, I think it would probably have been more consistent from an API perspective, to call the parameter dtype and allow the options 'float64', 'float32', 'int32', 'int16'.
Should we change that?
If we decide to go that way, we could at first support both parameters and deprecate the old ctype parameter. After some time, we could remove it completely.

Sounds good to me.

Cool! I'll try to whip up a PR in the next few days ...

I've just made a PR: #179.

#179 was merged, I'm closing this.


lazy.nvim build fails ar: conftest.a: No such file

  Failed (1)
    ● cornelis 0.18ms ✔ build          ■■ build failed
        Preparing to install GHC (tinfo6) to an isolated location.
        This will not interfere with any system-level installation.
        Preparing to download ghc-tinfo6-9.4.8 ...
        ghc-tinfo6-9.4.8: download has begun
        ghc-tinfo6-9.4.8:   14.73 MiB / 178.01 MiB (  8.28%) downloaded...
        ghc-tinfo6-9.4.8:   43.60 MiB / 178.01 MiB ( 24.50%) downloaded...
        ghc-tinfo6-9.4.8:   71.31 MiB / 178.01 MiB ( 40.06%) downloaded...
        ghc-tinfo6-9.4.8:   94.53 MiB / 178.01 MiB ( 53.10%) downloaded...
        ghc-tinfo6-9.4.8:  122.79 MiB / 178.01 MiB ( 68.98%) downloaded...
        ghc-tinfo6-9.4.8:  145.47 MiB / 178.01 MiB ( 81.72%) downloaded...
        ghc-tinfo6-9.4.8:  168.36 MiB / 178.01 MiB ( 94.58%) downloaded...
        ghc-tinfo6-9.4.8:  178.01 MiB / 178.01 MiB (100.00%) downloaded...
        Downloaded ghc-tinfo6-9.4.8.
        Unpacking GHC into /home/res/stack/programs/x86_64-linux/ghc-tinfo6-9.4.8.temp/ ...
        Configuring GHC ...
        ar: conftest.a: No such file or directory
        Installing GHC ...
        Installed GHC.

        Process was killed because it reached the timeout

Remember kids, a nix shell will point all your linker paths into the store, remember that.


App Distro: fix async/await issue

Right now we're calling a completion handler with nil, nil when
releases are fetched but none are marked as "latest". This shouldn't
happen, and is considered an error.

Chatting with the App Distro team about the expected behaviour here - originally they said it should return an error but now seeing the test failing, it's worth confirming.

Should fix #9604


Add a Contribs Project for Prospective EarlGrey API's.

Looks awesome! This uses EarlGrey from master, right?

Looks awesome! This uses EarlGrey from master, right?

Yes, you need to use the setup-script in order to get it running.


Dropbox module error MemoryError after 7h compilation

<IP_ADDRESS>
Python: 3.8.3 (tags/v3.8.3:6f8c832, May 13 2020, 22:20:19) [MSC v.1925 32 bit (Intel)]
Executable: C:\Users\Ja7ad\Desktop\test\env\Scripts\python.exe
OS: Windows
Arch: x86

my code for test:
from dropbox import Dropbox

dbx = Dropbox('access token from dropbox developer')
print(dbx.files_list_folder('',recursive=True))
input()

nuitka command for compilation nuitka --recurse-all --standalone --show-progress --verbose --mingw64 test.py
Error recived:
Nuitka:INFO: Total memory usage before generating C code: 786.27 MB (824463360 bytes):
Traceback (most recent call last):
  File "C:\Users\Ja7ad\Desktop\test\env\lib\site-packages\nuitka\__main__.py", line 195, in <module>
    main()
  File "C:\Users\Ja7ad\Desktop\test\env\lib\site-packages\nuitka\__main__.py", line 188, in main
    MainControl.main()
  File "C:\Users\Ja7ad\Desktop\test\env\lib\site-packages\nuitka\MainControl.py", line 749, in main
    result, options = compileTree(main_module=main_module)
  File "C:\Users\Ja7ad\Desktop\test\env\lib\site-packages\nuitka\MainControl.py", line 648, in compileTree
    makeSourceDirectory(main_module=main_module)
  File "C:\Users\Ja7ad\Desktop\test\env\lib\site-packages\nuitka\MainControl.py", line 368, in makeSourceDirectory
    source_code = CodeGeneration.generateModuleCode(
  File "C:\Users\Ja7ad\Desktop\test\env\lib\site-packages\nuitka\codegen\CodeGeneration.py", line 481, in generateModuleCode
    return getModuleCode(module_context=module_context, template_values=template_values)
  File "C:\Users\Ja7ad\Desktop\test\env\lib\site-packages\nuitka\codegen\ModuleCodes.py", line 171, in getModuleCode
    result = header + template_module_body_template % template_values
MemoryError

Dropbox files before\after generate C code:

Seems dropbox runs into the 32 bit process memory limit here. This might be because it's more code, which I doubt, but also could be because some wrong optimization creates a constant at compile time that it ought not to.
Can you use --show-memory and attach full compilation report with only that. Then we would know the worst offender, either for load in first pass, or for later optimization, where one step would make it explode.

Seems dropbox runs into the 32 bit process memory limit here. This might be because it's more code, which I doubt, but also could be because some wrong optimization creates a constant at compile time that it ought not to.
Can you use --show-memory and attach full compilation report with only that. Then we would know the worst offender, either for load in first pass, or for later optimization, where one step would make it explode.

Seems dropbox runs into the 32 bit process memory limit here. This might be because it's more code, which I doubt, but also could be because some wrong optimization creates a constant at compile time that it ought not to.
Can you use --show-memory and attach full compilation report with only that. Then we would know the worst offender, either for load in first pass, or for later optimization, where one step would make it explode.

ok i send full report with --show-memory

**command:
**
nuitka --recurse-all --standalone --show-memory --enable-plugin=pylint-warnings --mingw64 test.py
code:
from dropbox import Dropbox

dbx = Dropbox('access token from dropbox developer')
print(dbx.files_list_folder('',recursive=True))
input()

Error:
Nuitka:INFO: Total memory usage before generating C code: 1.01 GB<PHONE_NUMBER> bytes):
Traceback (most recent call last):
  File "C:\Users\Ja7ad\Desktop\test\env\lib\site-packages\nuitka\__main__.py", line 195, in <module>
    main()
  File "C:\Users\Ja7ad\Desktop\test\env\lib\site-packages\nuitka\__main__.py", line 188, in main
    MainControl.main()
  File "C:\Users\Ja7ad\Desktop\test\env\lib\site-packages\nuitka\MainControl.py", line 749, in main
    result, options = compileTree(main_module=main_module)
  File "C:\Users\Ja7ad\Desktop\test\env\lib\site-packages\nuitka\MainControl.py", line 648, in compileTree
    makeSourceDirectory(main_module=main_module)
  File "C:\Users\Ja7ad\Desktop\test\env\lib\site-packages\nuitka\MainControl.py", line 368, in makeSourceDirectory
    source_code = CodeGeneration.generateModuleCode(
  File "C:\Users\Ja7ad\Desktop\test\env\lib\site-packages\nuitka\codegen\CodeGeneration.py", line 481, in
generateModuleCode
    return getModuleCode(module_context=module_context, template_values=template_values)
  File "C:\Users\Ja7ad\Desktop\test\env\lib\site-packages\nuitka\codegen\ModuleCodes.py", line 171, in getModuleCode
    result = header + template_module_body_template % template_values
MemoryError

report.txt

The code generation error will of course not necessarily trigger for the module that has the issue, but raises the question, of why there is an extra 1G spent, as I expect there to be that much remaining. I am not sure though, if Windows doesn't have a smaller limit there.
It may leak memory though. And in fact, what should be happening is that memory lowers during code generation. I believe I release stuff afterwards, before then calling scons. So this could be improved. After I finish the new constants branch, which will be shortly, code generation per module will be independent from another. Then surely we can release it sooner.
 I expected traces for changes during optimization, which could also be to blame, but notice that the later takes almost as much as the whole of mercurial compilation on 64 bits. Using 32 bits should only be less memory.

# Auto-generated by Stone, do not modify.
# @generated
# flake8: noqa
# pylint: skip-file

and then 104k lines of code. I believe, the constants for the module, are going to cause a lot of code, that my branch will address. I think, this might be a nice case to study differences in memory usage of that branch. Since Nuitka no longer generates per constant code, this might make a huge difference at that point. It could well be that the code of the file generated is being simply very large too, easily parts of a GB as well.
So I guess, over the weekend, I might surface with something useful there. The new constants code is internal testing and being fixed up. Should it finish, this is probably going to drop below the threshold of 2GB.

So, 64 bits Linux it's more like 227 MB to load, i.e. even more, due to larger pointers.

@kayhayen thank you for explain about this , i hope improved for support 2GB


Replace Travis CI with GitHub Action

@pablogsal @zware: It seems like .travis.yml was no longer used. So I switch to GitHub Action instead.


adding ModalWindow

dialogKit had a ModalWindow, which is nice to have in some occasions
this can be added to vanillaWindow.py
from AppKit import NSModalPanelWindowLevel
from vanilla import Window

class ModalWindow(Window):

    nsWindowLevel = NSModalPanelWindowLevel

    def __init__(self, *args, **kwargs):
        kwargs["closable"] = False
        kwargs["miniaturizable"] = False
        self._doCenter = True
        if "center" in kwargs:
            self._doCenter = kwargs["center"]
            del kwargs["center"]

        super(ModalWindow, self).__init__(*args, **kwargs)

    def open(self):
        super(ModalWindow, self).open()
        if self._doCenter:
            self.center()
        NSApp().runModalForWindow_(self._window)

    def windowWillClose_(self, notification):
        super(ModalWindow, self).windowWillClose_(notification)
        NSApp().stopModal()

Yeah, I think this will be pretty useful!

Note that in general, modal windows are considered very poor UI design.

True... its to have alternative for the archived dialogKit.ModalDialog.
sheet are also modal and there are cases where a modal window is a nice option.

A sheets is only modal relative to its parent window.
A modal window is only "a nice option" if the code really can't be changed to support a non-modal UI.
A ModalDialog has no place in a modern application — that's probably why it was archived.

dialogKit is archived in favour of vanilla, to old to much FL code in there

Ah of course, I forgot.

Pop Up Tools is very nice, and uses a modal window…

Pop Up Tools is very nice, and uses a modal window…

That's not a modal window at all, it's like a contextual menu. If you click somewhere else it disappears. It doesn't block you from doing somthing else.

@justvanrossum I think the idea is that it doesn’t disappear… see Make the window better

An frequent used example of a modal dialog is an Open panel.
see https://developer.apple.com/design/human-interface-guidelines/macos/windows-and-views/dialogs/
I indicates a higher level of user attention: "the app cannot do anything until you give it a file to open..."
Its a convenient window class, and annoying to make it each time you needs it.

I read that as "don't disappear if a click occurs inside the window, but outside of a control".

On macOS 10.15 not even the actual Open panel is modal... (On 10.10 it is, I don't know when it changed.)
Modal windows/dialogs are a remnant of '80s & '90s UI design and should be avoided at all cost.

"App-modal" I should say. There's obviously use for document-modal or window-modal windows, but those are "sheets" and we already have them.

there are valid use cases for modal dialogs, see Modal & Nonmodal Dialogs: When (& When Not) to Use Them

Modal dialogs interrupt users and demand an action. They are appropriate when user’s attention needs to be directed toward important information.

the most reasonable course of action here seems to be:

make modal window available for convenience, so that developers don’t have to write their own every time they need it
add a warning to the docs saying that they should be avoided at all cost

I was reading the latest release notes and noticed that sheets look like modal windows in macOS 11.

I added the version that I created for ezui that was, in turn, based on the one in RoboFont.
import vanilla

class Test:

    def __init__(self):
        self.w = vanilla.ModalWindow((200, 200))
        self.w.b = vanilla.Button((10, 10, -10, 20), "Close", callback=self.closeCallback)
        self.w.open()

    def closeCallback(self, sender):
        self.w.close()

Test()


SOLR-16157, SOLR-16117: Fix maven release artifacts

I think this fixes all of the issues that we could see with Solr Core (and Solr module) maven artifacts.
It overrides some of the work done in SOLR-16072. In general this approach requires less manual checking, and should just work whenever dependencies are added to solr-core or solr-server.

Auto-find modules to build maven artifacts and distribution for
Shared dependencies between solr-core and solr-server no longer need
special dependency types, except for Jetty client libraries. This
worked earlier because of SolrJ, and was not guaranteed to keep
working.
Remove the solr-server maven artifact.
Add versioning constraints for server libraries

The comments here imply that there should be future work for splitting embedded Solr Server out into a separate module, does a JIRA for that already exist?

Hmmm interesting that it worked regardless. The ultimate goal was to make the build less error prone to changes in dependencies. Personally I think that this is better than having to keep the lists between core and server in-sync.
Also can you make sure to purge your local maven cache of all solr artifacts before trying the current implementation?

I think what is happening is that my project depends on solr-core, which has a transitive on solr-solrj, which then brings in the rest of what we need? Am I supposed to be depending on solr-server for anything here? That doesn't exist anymore, right?

I also checked and the Jetty metrics that were fixed in SOLR-16072, and those are still visible with this change.


bump kedro version 0.18.13

Description
Why was this PR created?
Close #29

#29

Development notes
What have you changed, and how has this been tested?
Checklist

[ ] Read the contributing guidelines
[ ] Open this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Update the documentation to reflect the code changes
[ ] Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
[ ] Add tests to cover your changes

Notice

[ ] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Let's go for a first release!

Let's do that.


Daily rc sync to main

Just for reference: we're going to ignore the remaining CodeFactor warnings: three are from lines we didn't touch, and one is from a string literal that's one over the 100-character limit.


Unsoundness in C enum handling

The handling of all enums in our C API bindings is unsound. E.g.,
https://github.com/libbpf/blazesym/blob/9fe143a345f837c1dbec09530e8ec9f4a690c5f4/src/c_api.rs#L303-L310
C code could set any value, including those not representable by Rust. Discussed in many places (while also being common sense...), among others here: https://github.com/rust-lang/rust/issues/36927

So...after thinking about these potential issues some more I believe we should just live with them. If a user provides invalid enum variants through the C API that's on them and a bug in their code. We do not make any claims about being able to handle arbitrary wrong data, similar to how we would not identify a "broken" pointer (other than a NULL pointer; e.g., one that has been freed or just points into arbitrary memory). I am not sure we want to expend the energy to handle those invalid enum variants more gracefully. I am open to revisiting this issue in the future, but for now I am going to close it.


[jvm-packages]fix XGBoost-on-Spark SparseVector missing value problem

treat SparseVector as DenseVector

the problem
https://github.com/dmlc/xgboost/pull/4315
https://github.com/dmlc/xgboost/issues/3742
https://github.com/dmlc/xgboost/issues/3634
https://github.com/dmlc/xgboost/issues/4227

treating everything as dense vector brings significant amount of waste on the memory space, and the problem has been fixed in https://github.com/dmlc/xgboost/pull/4349 , are you still observing something out of order?

@CodingCat I'll defer to you on whether this pull request should make it to 0.90 release. However, I'm concerned that this PR increases memory consumption significantly and caused some tests to fail.

Memory issue is extemely important in distributed training on large datasets.
In my cases, thousands of slots are
defined while only small set of them are used per training job. To not change feature index, sparse
vectors are needed or a must.

I will close this PR soon as the problem has been fixed by other PRs,


feat: support local disk as state store backend

What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:

Support local disk as a backend of the state store. This makes it possible to simulate the real deployment without access to object services. An example is provided here.

Questions:
@hzxa21 Is it true that meta nodes won't query against state store directly. If so, then the example here works perfectly because I excluded the volume mounting of the data directory from the meta's Pod. Otherwise, I need to revise it.
Checklist

[x] I have written the necessary docs and comments
[x] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@hzxa21 Is it true that meta nodes won't query against state store directly. If so, then the example here works perfectly because I excluded the volume mounting of the data directory from the meta's Pod. Otherwise, I need to revise it.

meta node will not query against state store but it will contact object store backend to store the version checkpoint and backup states so I think making sure meta can read from and write to the object store data directory is neccessary. cc @zwang28

@hzxa21 Is it true that meta nodes won't query against state store directly. If so, then the example here works perfectly because I excluded the volume mounting of the data directory from the meta's Pod. Otherwise, I need to revise it.

meta node will not query against state store but it will contact object store backend to store the version checkpoint and backup states so I think making sure meta can read from and write to the object store data directory is neccessary. cc @zwang28

Thanks for pointing it out. I didn't mount the directory for meta Pods. Here's the fix: https://github.com/risingwavelabs/risingwave-operator/pull/440. PTAL!


fixup case of backedge from header to header

Fixes #45
Headers of multi-block loops that have a backedge to themselves, didn't have this processed.
The case of:
label not in doms[jt]
accounts for the case, where there were multiple entry edges into the loop and the original header has been replaced with a synthetic one.
An alternative fix would have been to simply delete this check, but then this breaks the test case test_double_header (after hacking the followup issues). This fix is non-intrusive and a test for the edge cases has been added too.

It looks like with the merge of the remove_labels PR, the test became stricter and exposed that this test had been working by accident. 08b019eaac56f0c0597af69f38603c680a6897d2 fixes -- basically on input we have [1, 2] and the link to 1 is replaced with a link to 5 -- so the expected jump_targets should be [5, 2] -- the commit fixes that!

The changes LGTM! I think we can go ahead with the merge on this one.

@kc611 thank you for the review!


RESTDataSource serializes undefined values as "undefined"

I have a data source like this:
class MyApi extends RESTDataSource {
  constructor() {
    super();
    this.baseURL = 'https://my-api.example.com/';
  }

  async getUser(query) {
    return this.get('/user', query);
  }
}

This is my resolver:
const userResolver = (_, __, {dataSource: {myApi}}) => {
  const query = {
    userId: "1",
    optionalParam: undefined,
  };
  return myApi.getUser(query);
}

This leads to this HTTP request:
GET /myApi/user?userId=1&optionalParam=undefined

while I think it would be more logical if this was fetched:
GET /myApi/user?userId=1

I think these lines implement the behavior:
https://github.com/apollographql/apollo-server/blob/d3882350fb768bde2d599343c257dc71400cb360/packages/apollo-datasource-rest/src/RESTDataSource.ts#L226-L229

I do understand the desire here, and I see a bunch of 👍 across this and the duplicate issue #26 over the years. The treatment of objects with keys with undefined values in JS is a bit inconsistent: it's not identical to leaving out the key, but some important APIs like JSON.stringify treat it that way. I can definitely understand the desire to write
return this.get('path', {
  params: {
    foo,  // which might be null/undefined
    bar: computeBar(), // similar
  },
});

and have it just work.
That said, our implementation of URL query parameters is based on the DOM URL API's URLSearchParams class, and we allow you to pass any representation of search parameters supported by that class's constructor.  In addition to an object, you can pass a string that's already serialized, or an array of two-element arrays of strings, or in fact any iterable object that lets you iterate and produce two-element arrays of strings.  And this API (which is about as "standardized" as you can get for an URL-producing API) assumes you give it strings and converts anything that isn't a string to a string, including undefined to "undefined".
I don't think it's reasonable for our project to effectively reimplement the entirety of the URLSearchParams API (supporting all the different ways params can be specified) just to strip out undefined first.  And I think only stripping in the "object" case and not the others would be inconsistent.
Also there's an interesting question as to whether we should strip null too. Doing that would not be consistent with JSON.stringify! But it probably makes sense.
Also note that the TypeScript types are correct: at least in the current version, this.get('foo', { params: { foo: undefined } }) fails to typecheck. So if you're using TS this at least shouldn't surprise you at runtime. (I'm assuming here and hereafter that you use strictNullChecks if you use TS.)
I can think of two approaches to take here. (Note that I consider them both to be backwards-incompatible but we will probably be releasing<EMAIL_ADDRESS>with a variety of improvements soon.)
(a1) The first is to give up on the idea of supporting any legal URLSearchParams constructor argument here, and just allow you to pass an object. So params would now have type Record<string, unknown> and we'd explicitly strip undefined (and null?) before passing it to new URLSearchParams. Anyone who may have been taking advantage of the other types allowed for params would have to adapt their code.
(a2) As a slight middle ground, we could declare params: Record<string, unknown> | URLSearchParams, so anybody using the other types can just manually write params: new URLSearchParams('x=y&z=w').
(b) The second is to declare the current state of the world to be intentional (after all, it matches the most standardized relevant API) and document how to achieve the goals shown by the snippet above. There are at least three pretty easy workarounds, and note that these workarounds also let you choose for yourself how null is handled, etc.
(b1) Just use lodash:
import { omitBy, isUndefined } from 'lodash';
return this.get('path', {
  params: omitBy({
    foo,
    bar: computeBar(),
  }, isUndefined),  // or you can use isNil to include null too
});

This is pretty easy. One downside is the TS types aren't smart enough to know the overall effect of omitBy+isUndefined so this probably doesn't work with TS.
(b2) Write your own TS function like
function omitUndefinedValues(x: Record<string, unknown>): Record<string, NonNullable<unknown>> {
  const y: Record<string, NonNullable<unknown>> = {};
  for (const [key, val] of Object.entries(x)) {
    if (val !== undefined && val !== null) {
      y[key] = val;
    }
  }
  return y;
}

Is there something like this on npm somewhere? We could publish it from the apollo-utils repository if that helps... This solves the TS issue of (b1).
(b3) Actually take advantage of the flexibility of the URLSearchParams constructor:
const bar = computeBar(),
return this.get('path', {
  params: [
    ...(foo !== undefined ? [['foo', foo]] : []),
    ...(bar !== undefined ? [['bar', bar] : []),
  ],
});

This requires no dependencies and typechecks properly out of the box, but is a bit more verbose (especially for the "computed directly in the call" use case).  And of course, anyone who has already discovered this workaround (or otherwise likes this pattern) would be broken if we chose (a).
I am leaning towards saying hey, who are we to say we know more than the designers of the DOM URL API, let's go with (b) and document how to do (b2) [with our own package] or (b3).  But maybe we should go with (a2) instead.

@glasser I don't have the mental capacity right now to carefully consider all the options but thank you so much for such a detailed / thoughtful response!

After sleeping on it, I'm feeling reasonably good about a major-version bump for (a2).


Externally-visible metadata?

I've been working on an alternate implementation to be compliant with the AppImage type 2 spec using Zip as the image file system (https://github.com/sagebind/appimagezip), but now I realize there is no way for external tools to know what file system an AppImage actually uses. Would it be a good idea to add some metadata to a new ELF section?
I'm thinking something like this:
$ readelf -p .appimage MyApp.AppImage
name = My App
builder = AppImageKit
filesystem = squashfs

Being able to identify the file system type could be useful, so that tools don't have to guess the format by scanning the file. For example, if we want to extract an AppImage or list its contents, we would need to know the file system format first. It may also be useful to record the application used to generate the AppImage.
We can't store this metadata in the .desktop file since we can't access it without reading the file system format first.

Hi @sagebind,
welcome to AppImage!
The name you mention is in the Name= key of the .desktop file. The builder you mentioned is currently not available in the metadata but could be embedded inside the filesystem; I don't see a pressing need for it to be outside of the filesystem. The filesystem you are mentioning is represented by different magic bytes:
AppImageSpec currently specifies two image types with two different filesystems for AppImage:

ISO9660 (type 1 images)
squashfs (type 2 images)

They have different magic numbers which can be used to determine the file type.

0x414901 at offset 8
0x414902 at offset 8

If you have a clear case why you need another filesystem, we could think about type 3 AppImages, with, you guessed it, 0x414903 at offset 8. But we should do so only if there is a very clear need and a very clear use case which type 2 cannot do. Also, we should do performance comparisons.

Maybe I misunderstood the draft spec, but I did not think type 2 was specific to squashfs and that using squashfs was an implementation detail. From the draft:

Type 2 image format
An AppImage which conforms to the type 2 image format:
[...]

MUST have appended to it a filesystem that the ELF part can mount

Also, in the announcement of the type 2 format: http://discourse.appimage.org/t/the-future-of-appimage-type-2-and-new-tools/65/2:

In contrast to the earlier ISO9660-based AppImage format, the new type 2 format:

Is not tied to any particular filesystem format (so there might be others in the future); right now my implementation uses squashfs rather than ISO9660

If type 2 is squashfs-specific, then we should probably say so in the draft. Otherwise, I see the fs implementation as distinct from the spec version. We could have a different set of magic bytes at a different offset for that.

Actually you are right, the spec for type 2 allows any type of filesystem to be used. I forgot that I had intentionally made it that generic, so thanks for reminding me. An external application wishing to determine the filesystem format would, in this case, need to get the offset to the beginning of the filesystem (= the byte after the end of the ELF) and then determine from the magic bytes of that filesystem what it actually is.

@sagebind still I'd be interested in your motivation to go with zip rather than squashfs.

That's a good point, it shouldn't be too hard to read the magic bytes right after the offset of the ELF, that seems like a reasonable solution to me. I should have thought of that...
I'm mostly experimenting for the heck of it, but I decided to use zip for three reasons:

Just like squashfs has better, more available tooling than ISO9660, zip has even more tooling than squashfs.
The zip format is very simple, so it should be possible to implement a smaller runtime binary that uses either very small zip libraries or no library at all. With squashfs you need to pull in all of squashfuse.
You can extract and/or view the image without executing without any special tools, since the zip format allows arbitrary prepended data. So for example, zipinfo UsingZip.AppImage works out-of-the-box, and renaming to a .zip lets you open it in a GUI.

I'm also concerned about performance; in theory zip lookup tables are quite fast, but in-file seeking is an issue. I think I can do some benchmarks once my implementation is more complete. The compression algorithm used might have a big effect on performance too.

Yes @sagebind I'd be very interested in benchmarks, e.g., of LibreOffice launch times.


No documentation about permissions for plans with TfS 2017

Hi,
The documentation about permissions is missing for TFS 2017.
Regards,

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ef517e1-f614-a2e5-d968-e32bdaac6183
Version Independent ID: babf6a50-0147-74bb-0e20-b1939de397af
Content: Review team delivery plans - Azure Boards
Content Source: docs/boards/plans/review-team-plans.md
Product: devops
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@spashx - Thank you for the feedback. Actually, the permissions for plans are missing for all versions. I'm correcting this with a new topic to be published soon.


guard for when headers already provide structs

The macOS toolchain for Xcode 12.4 defines this struct in nfs.h if NFS_NPROCS is already defined by other includes. By guarding for this we can detect if the struct is already defined and suppress issues building on this toolchain.
Relevant section from MacOSX10.15.sdk/usr/include/nfs/nfs.h and consistent in MacOSX11.1.sdk/usr/include/nfs/nfs.h:
/*
 * XXX to allow amd to include nfs.h without nfsproto.h
 */
#ifdef NFS_NPROCS
/*
 * Stats structure
 */
struct nfsstats {
        uint64_t        attrcache_hits;

This structure has been broken apart in newer toolchains as seen in MacOSX12.1.sdk/usr/include/nfs/nfs.h and MacOSX13.1.sdk/usr/include/nfs/nfs.h:
/*
 * XXX to allow amd to include nfs.h without nfsproto.h
 */
#ifdef NFS_NPROCS
/*
 * Stats structure
 */
struct nfsclntstats {
        uint64_t        attrcache_hits;
...
};

struct nfsrvstats {
        uint64_t        srvrpccntv3[NFS_NPROCS];
...
};

#endif

Note testing to ensure this struct remains consistent in various headers is likely needed.
Based on the 12.1 header more work may be needed for this to function properly in new OS versions.
A helpful reference repo I came across while looking at header files https://github.com/alexey-lysiuk/macos-sdk

Can you merge and create a new tag. Thanks!

Ready for merge

There is still testing in progress to make sure this works.  We will likely merge it soon.

Landed and tagged.


Fixing importlib.resources  preventing import by replacing with importlib_resources

A fresh conda environment with only the current version of exoatlas and its dependencies failed to import despite successful installation. The reason seems to be as simple as importlib.resources now being packaged in importlib_resources, but I don't know what version dependencies are affected.

Ha, thanks for fixing this @gmd! Ironically, that was my (apparently still out of date) fix for even more defunct pkg_resources.


Extrem slow blockchain copy via scp

I am copying the blockchain from my mac book but the speed is extremely slow.

Any ideas about that? Or is my question to general?
Thx

On my local network I get between 10-20 MB/s on transfere .. where the bottle neck is more likely the USB2.0 bus of the Raspberry. Why it is so slow on your setup its hard to say. Is your Laptop on WLAN? Is there any other process running on the Raspberry that blocks the USB2.0 bus bandwidth?
BTW the next release v1.1 will replace SCP with rsync for MacOS and Linux: https://github.com/rootzoll/raspiblitz/issues/397

I am copying the blockchain from my mac book but the speed is extremely slow.
Any ideas about that? Or is my question to general?
Thx

What is your storage media?  Some low quality flash drives (USB/SD) have very slow write speeds esp when copying a large amount of data where they get hot and slow down even more.  WLAN and router are possible problem sources too.

Thanks for your answers. Yeah normaley i have a speed about 15 MB/s in the LAN. The Laptop is on WLAN. The storage medias are two WD elements. Maybe its because the blockchain is on an external HDD. Maybe i try to copy it via rsync.

please close this.


revert: set global focus styles

Revert https://github.com/primer/react/pull/5029/files due to issues identified in the release: https://github.slack.com/archives/C02NUUQ9C30/p1728628747488159

Thanks for doing this 🙏🏼


Replace qmail with its living fork, notqmail.

The notqmail repo includes tags for various historical releases.

Awesome! Thanks @schmonz.


Documentation: Included Mods

@chaorace Could we insert the information in the RP which other Mods are included in which version/date?

Can do!


Add extra parameters to filter in queryset dynamically.

Hello,
Is there a way to work with results returned in the widget dynamically with values in the form?
Example:
continent = request.GET.get('continent', '')
queryset = Country.objects.filter(continent=continent)

I checked some methods, such as filter_queryset. But I have not found any that has access to the attributes on the form.
I found some issues, like this:
https://github.com/applegrew/django-select2/issues/22#issuecomment-41167962
But I noticed that the get_results method is no longer available to overwrite ..

@Gustavosdo You are not the first one to request such a feature #195.
I agree it would be nice, but it is also very hard to implement in a generic way. The only possibility I see is  to create your own JSON endpoint and to handle additional parameters.
You also need to make sure to collect these parameters. @anneFly did a great job making the js code more extendable.
I'm totally open for a pull request, but I don't have the time to implement a feature I don't need.


Update Butler matching notebook for Run 1.2i

As discussed with @jchiang87, I modified the matching_stack.ipynb tutorial to reflect the changes that came with Run 1.2i. I also added some annotations at points where I got stuck changing the code to work for Run 1.2i.
Update summary:

Explains how to extract information about the repo from Butler, e.g. through getKeys() and queryMetadata()
Explains how to get available filter, tract, patch combinations
Updates the repo locations for src and deepcoadd in Jupyter-dev
Updates the src dataset key schema for Run 1.2i, e.g. raft --> raftName
Uses new column names for kronflux

I'm sorry if I missed something obvious, but I can't figure out why the number of matches between the drp catalog (from src) and protoDC2 is 0. I inferred from the original dataId in Jim's notebook that {'visit': 219976, 'raft': '2,2', 'sensor': '1,1'} for Run 1.1p were the same as {'visit': 219976, 'raftName': 'R22', 'detectorName': 'S11'} for Run 1.2i. Was I wrong?

@jiwoncpark, I think that you can try to match directly to dc2_truth_run1.2_static so you don't have to worry about the rotation of the catalog. It is not finding any matches with the src_catalog because the regions don't overlap. You probably want to query a different sensor-raft (blue points are from the obj_catalog and orange are from the src_catalog):

Another option is to query a different tract, patch (you can check which ones overlap with the visit in the notebook using: overlaps[(overlaps['visit']==219976) & (overlaps['detector']==94)]. E.g, using:
our_filter = 'r'
our_tract = 4639
our_patch = '6,6'

You get ~350 matches

Hi @fjaviersanchez, thank you for looking into this! Are you suggesting that I work with the truth catalog instead, which would entail turning it into a afw_table without the rotation and passing it into the matchRaDec function? If I were to stick with protoDC2, how would I go about figuring out which sensor, raft combo overlaps with a given region in protoDC2?

You can use either protoDC2 or dc2_truth indistictively. The only difference would be that you don't have to rotate (you would still generate the afw.table/SourceCatalog object with dc2_truth as you said and in the function where you do the selection you avoid the rotation step).
The non-matching is a separate problem. In order to figure out which object catalog (coadd) overlaps with a given exposure (source catalog). In the overlaps table in your notebook you have all the information that you need (R22, S11 is detector=94).
This is because in this line:
galaxy_catalog = region_selector(gc, band=our_filter, max_mag=mag_max)
You get rid of anything out of any galaxies lying outside of the patch that you queried (that's why you weren't finding any matches in the src catalog, because the piece of protoDC2 that you had didn't overlap with src).

@jiwoncpark - I just wanted to check in about this PR, since there hasn't been activity for a while.  My impression from your exchange with @fjaviersanchez was that you may be planning additional changes before it's ready for review, so I was waiting on that - but please let me know if that's incorrect and I can seek out a reviewer now.  Thanks!

hi @jiwoncpark, just to check again, are there additional changes you are making on this PR? thanks!

Oh no, I missed Rachel's post from earlier. I'm so sorry! Yes, I recall I made some changes per suggestions from @fjaviersanchez but it seems I can't access the NERSC Jupyter server now (maintenance?) -- I'll request reviewers by this Thursday.

Thank you for your patience! In this version, ready for review, I've

implemented @fjaviersanchez 's suggestion of using the truth catalog instead and
added a method of finding the tract and patch combo for coadd that overlaps with a given src region, instead of an arbitrarily sky coordinate as I had in the previous version.

@wmwv has kindly agreed to review this PR!

I've also asked @jchiang87 (who wrote the original tutorial for Run 1.1) to review this!

Great, good to hear, thanks!

hi @jiwoncpark - is there an update on the changes requested by @wmwv for this PR?

I'll work on updating this for Run 2.xi.

hi @jiwoncpark, just wanted to check on the status of this notebook?

Hi @reneehlozek, I'm not sure if this tutorial is useful anymore, as I see that GCRCatalogs now publishes dc2_object_run2.1i_dr1*_matched and people can now just load that. I wrote the tutorial to teach myself how to match to truth, back when these weren't available. Do you think it would still be useful to update Jim's 1.1p matching notebook to 2.1i?

superseded by #135


Revert guidance to focus on SPFx v1.11

Category

[x] Content fix
[ ] New article

Related issues

fixes #6868

What's in this Pull Request?

revert changes to "set up dev env for spfx" to focus on SPFx v1.11

Docs Build status updates of commit 60e3c35:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/spfx/release-1.12.0.md
:white_check_mark:Succeeded
View

docs/spfx/set-up-your-development-environment.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


adding more important info

please compare changes and merge

Hi,
I didn't add 1D info on purpose as I think it's cringe.
What do you think? Is it necessary XD?


Update Styling on 'More' dropdown menu

New Mockup
Please check assets/css/global.css, design-assets folder images, and figma files for updated style guides. Any new pull request should use the updated color, spacing, and sizing variables.
No Bootstrap or jQuery
Please refrain from adding Bootstrap or jQuery to the site. These pr's will be closed. They overwrite global styles. Vanilla CSS and JS is way better now anyways 😊
New Task:
What is the task
To make the 'More' dropdown menu's styling germane to the 'dropbtn'.
Who is the task for?

[x] I created this task for me to complete, I will create a PR soon.
[ ] I created this task for someone else to claim.
[ ] I think this is a task that multiple people can do

Confirm all of the following:

[x] I have looked at all the issues currently available and this does not exist or overlap with another ticket

⚠ PLEASE ONLY SUBMIT A PR FOR THIS TASK IF THIS TASK WAS AVAILABLE FOR YOU TO CLAIM

Will fix to look like Mockup


Add @model (?) decorator to ensure structure[type] and relations[type] are predefined in the schema

Schema structure[type] & relations[type] are not defined unless the attribute or relationships decorators are present.
https://github.com/artemis-ag/mobx-async-store/blob/f5635e0e44445352207a86535e84cb3f82a54dec/src/schema.js#L11-L23
https://github.com/artemis-ag/mobx-async-store/pull/48 provides a temporary fix, but we should handle this more robustly.

7.0 no longer uses schema


mobile menu (navbar)

I'm not sure if this is tracked elsewhere but there's a lot of funky stuff going on with mobile menu, such as:

you have to double tap to cancel selected option
now the UI is a bit off and needs rethinking, it would be nice to have unified look for create/stats and chain
connect button basically hidden for me on iPhone, possible to scroll down to it in dev view on chrome

I'd like to start working on these tomorrow.
Originally posted by @petersopko in https://github.com/kodadot/nft-gallery/issues/4446#issuecomment-1340148441

👋🏻

Yup, its broken, thanks for creating this issue!

still working on this :eyes:

closing, as these issues will be resolved in

https://github.com/kodadot/nft-gallery/issues/4125


update deps

Didn't update the following:

react-hook-form
testing-library/react
testing-library/user-event

bc if I update them, the act warnings from react-hook-form appear again.
Will investigate at a later point in time.

I think it's handled in https://github.com/cstenglein/raspiblitz-web/issues/69 :)
Already medium prio => after initial release.
Currently I mostly do high prio issues till release.


Problem zoom

Hi, I have the following problem: I am loading the component in a pop-up window. The zoom effect (enlargedImagePosition: over) works only if I minimize and maximize the browser again. When I put the option: enlargedImagePosition: beside, the component works without problem. Thank you very much for the help

I solved the problem based on the answer given in error # 30


Confirm linking accounts elsewhere

It's possible in convoluted circumstances for attackers to trick participants into linking an account elsewhere belonging to the attacker, to the participant's Gratipay account. We should protect against this by adding an additional confirmation step, as Phabricator does:

Fix for https://hackerone.com/reports/170684.

We already have a confirm page for merging accounts. We want to add another confirm page before that one.

We have two actions, opt-in and connect. What's the difference?

https://github.com/gratipay/gratipay.com/blob/2101/www/on/%25platform/associate.spt#L53
https://github.com/gratipay/gratipay.com/blob/2101/www/on/%25platform/associate.spt#L66

opt-in is initial sign-in, connect is adding another account once you're already signed in. We certainly need the additional confirmation in the connect case. Do we also need it in the opt-in case?

Yes. Creating a new account with a malicious elsewhere attached is no better than linking a malicious elsewhere to an existing account.

Let's see if we can stick with ./associate as the callback to avoid having to update at all providers.

https://github.com/gratipay/inside.gratipay.com/issues/1196.


fix(formatter): use prettier config based on package.json location

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #108   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           18        18
  Lines          202       204    +2
  Branches        29        30    +1
=========================================
+ Hits           202       204    +2

Impacted Files
Coverage Δ

src/cli/index.ts
100.00% <100.00%> (ø)

src/lib/defaults/formatter.ts
100.00% <100.00%> (ø)

src/lib/index.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6535a83...cf5604c. Read the comment docs.


Removed warning when compiling iOS project

This change addresses a warning generated by xcodebuild as the deployment target of the base project was set up to 9.2 while the output library was set up to 7.0. I am just defaulting to the version of the OS configured in the parent project.
The definition of the parent property is here and here

Hi @emilioicai, it is me again (I must be very annoying)... This commit fixes some of the warnings I've mentioned before whilst compiling iOS. Is really easy to forget some of these properties where set as part of the build phases and xcode does not really highlight these.
In any case, let me know if there are problems with the commit and I will fix it as soon as possible.

Thanks @rodrigoelp for all your support :)


Require confirmation for account deletion

Just joined the project and made this PR as part of exploring the codebase -- no worries if this feature isn't wanted!
It felt a bit too easy for users to delete accounts -- just one click on the "Delete my account" button. This PR adds a second step to the account deletion process in which users have to type out "delete my account" and click confirm. (I think this is preferable to making them simply click a second button as it's too easy for the second button to be clicked by accident.)

Ah, good point, I'm used to assuming JS. This should work – now the second step will be shown by default, and if the user has JS enabled the second step will be swapped for the first on $(document).ready().


[UI] Fix dark mode on page beginner friendly repos

Description
Fixed the colors of the cards to improve the readable in dark mode. In doing so, I adjusted the colors to match the style of the other pages. Also, I added buttons for "Read more" in the same style as on other pages.
Now
Dark mode:

Light mode:

Before
Dark mode:

Light mode:

Category

[ ] Resource Addition
[ ] Documentation
[ ] Codebase
[x] User Interface
[ ] Feature Addition

Related Issue
Fixes #543
Checklist

[x] I have followed the CONTRIBUTING guide
[x] The name of the resource is spelled correctly (if applicable)
[x] The link to the resource is working (if applicable)
[x] The resource is added in the correct format (if applicable)
[x] I have tested changes on my local computer (if applicable)

Hey @Sriparno08, let me now if my style changes meet your expectations. I added the buttons because I thought the old link style looks a little old fashioned, but it would be easy for me to remove them if you don't like them.

@Sriparno08 also let me know, if you want to keep the buttons, what you think about the button color in light mode as I am not sure if they are too bright.


[XGBoost-Spark] error running binary classification on income classification dataset - labels are not correctly provided

For bugs or installation issues, please provide the following information.
The more information you provide, the more easily we will be able to offer
help and advice.
Environment info
Operating System: Ubuntu
Compiler: 4.8.4
Package used (python/R/jvm/C++):
xgboost version used:
If installing from source, please provide

The commit hash (git rev-parse HEAD) -- 7ff742ebf7ec70c747f9aec004689fc727ba3304
Logs will be helpful (If logs are large, please upload as attachment).

If you are using python package, please provide

The python version and distribution -- 2.7
The command to install xgboost if you are not installing from source

If you are using R package, please provide

The R sessionInfo()
The command to install xgboost if you are not installing from source

Steps to reproduce

Run the XGBoost algo on income classification dataset
with the following config params:

Map(alpha -> 0.0, min_child_weight -> 1.0, colsample_bylevel -> 1.0, subsample -> 1.0, lambda -> 1.0, max_depth -> 7, num_class -> 2, objective -> binary:logistic, max_delta_step -> 0.0, eta -> 0.1, colsample_bytree -> 1.0, gamma -> 0.5, nthread -> 1)
What have you tried?

It does run if we change the objective to multi:softprob, however, running it with binary:logistic or binary:logitraw leads to an error.

Error: 16/11/23 07:55:01 WARN TaskSetManager: Lost task 1.0 in stage 88.0 (TID 114, <IP_ADDRESS>): ml.dmlc.xgboost4j.java.XGBoostError: [07:55:01] src/objective/regression_obj.cc:90: Check failed: (preds.size()) == (info.labels.size()) labels are not correctly providedpreds.size=32560, label.size=16280

@CodingCat Please let me know if you would need more details.

luckily, I once used this dataset to test XGBoost....https://github.com/CodingCat/xgboost_test/tree/master/src/main/scala/me/codingcat/income
I cannot reproduce it with the code there,

Just hit the same, the solution, as I found in this answer, is to remove num_class from the parameter list.


Instagram builtin browser problem - Urgent

I'am using Instagram for IOS. When a bootstrap page with modal has been opened by the user, modal window does not position itself correctly inside instagram builtin browser. I set my Instagram account's address as https://getbootstrap.com/docs/4.4/components/modal/, see screenshot.
To reproduce:

Open your instagram account
Click Edit Profile
Set your web site as above
Close and view your profile
Click your web site

This is a huge problem for us because we use instagram ads and unfortunately users cannot use our web site when they click an ad.
Regards,

Have you tried vertically centering the modal via https://getbootstrap.com/docs/4.4/components/modal/#vertically-centered ?

confirmed. But I'm mot sure what we can do.

This is not an issue on android, not sure how to debug this 🤷♂

This is a bug of Instagram for IOS, fixed display with top 0 css class does not work as expected. I also had problems at other libraries like lightgallery.
A workarround:
.lg-toolbar {
margin-top: 40px !important;
}
.modal-dialog {
margin-top: 3rem !important;
}
.toast-top-left, .toast-top-center, .toast-top-right {
top: 3rem !important;
}

Do we close as a won't fix?

sure
On Thu, May 14, 2020 at 3:31 AM Mark Otto<EMAIL_ADDRESS>wrote:

Do we close as a won't fix?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/twbs/bootstrap/issues/30431#issuecomment-628316479,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA3M3R5BFCX63DPJE7WBRJDRRM3VXANCNFSM4LQ4NZTA
.


Nuxt 3 Support

Opening an issue to discuss whether there's plans to support Nuxt 3 and how the community can help.

The same for nuxt bridge. It doesn't seems there is support about it.

Starting support nuxt3/bridge https://github.com/nuxt-community/eslint-module/pull/70

Any update on this?

@jonorozcoc

Any update on this?

Haven't tried but #68 mentions that it works

Thanks @mlbiche
I'll check it

At the end, I am using eslint-plugin-nuxt, eslint-plugin-vue and @vue/eslint-config-standard. I have removed all Nuxt modules related to ESLint and all babel-related packages. And I have updated my ESLint config from something like:
module.exports = {
  root: true,
  env: {
    'browser': true,
    'node': true
  },
  parserOptions: {
    parser: '@babel/eslint-parser',
    requireConfigFile: false
  },
  extends: ['@nuxtjs', 'plugin:nuxt/recommended']
}

... to something like:
module.exports = {
  root: true,
  env: {
    'browser': true,
    'node': true
  },
  parserOptions: {
    ecmaVersion: 'latest',
    sourceType: 'module'
  },
  extends: [
    'plugin:nuxt/recommended',
    'plugin:vue/vue3-recommended'
  ],
  overrides: [
    {
      files: ['layouts/*.vue', 'pages/**/*.vue'],
      rules: { 'vue/multi-word-component-names': 'off' }
    }
  ]
}

@mlbiche is the plugin nuxt/recommended up-to-date with nuxt3?

@jonorozcoc At least it does not raise false positives with Nuxt 3. But it seems that it provides fewer rules than this module.

Nuxt3 Support in progress https://github.com/nuxt-community/eslint-module/pull/70

Released v4.0.0


reformant to use small heuristics

What do folks think about enabling this rustfmt option?
cc https://internals.rust-lang.org/t/running-rustfmt-on-rust-lang-rust-and-other-rust-lang-repositories/8732/81

I think we should do this.

reformatted!


Handling Streams instead/complementary of files

Get a readable stream (pdf) and return an other readable (png) to let developer pipe it in the writable of its choice.
I am working on it for my own need, but it need a re-design of the core abstracting the conversion and providing methods to configure input and output types (files or streams).
Did you already worked on it or not at all ?
Do you want pull requests when I will achieve it, or you prefer it stay in my fork ?

Or do you want we release it together ?

I'm very sorry for my late response @rbecheras. I've taken a bit long holiday.
Streaming input/output is a very good idea. I've not worked on that, but patches are welcome!
BTW, I found a module imagemagick-stream (https://github.com/eivindfjeldstad/imagemagick-stream), which may meet your need. Have you checked?

What happend to this? @mooz @rbecheras?
Does this library support stream processing?
I like to use it in combination with multer s3 stream upload to generate a preview of an PDF as thumbnail. Is this anyhow possible?

Just for the benefit of others coming here with a similar requirement, I used the following (imperfect) process for getting a Buffer into pdf-image and working with the output via temp-write:
const fs = require('fs');
const tempWrite = require('temp-write');
const PDFImage = require("pdf-image").PDFImage;
const filepath = tempWrite.sync('unicorn');

fs.writeFileSync(filepath, Body);
var PDFImage = require("pdf-image").PDFImage;
var pdfImage = new PDFImage(filepath, options);

pdfImage.convertPage(0).then(function (imagePath) {...

@manuelfink Hey:) Have you found a good solution for your use-case, I currently face the same issue.


[CP STAG] Fix FormData issue

Details
Fixed Issues
$ https://github.com/Expensify/App/issues/6528
Tests / QA Steps

Create workspace
Navigate to Workspace members page on iOS, Android, and Web
Verify members are visible on all platforms

Tested On

[x] Web
[ ] Mobile Web
[ ] Desktop
[x] iOS
[x] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Updated.

🚀 Deployed to staging by @Jag96 in version: 1.1.18-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Greenkeeper/initial

Coverage remained the same at 97.561% when pulling<PHONE_NUMBER>23c76868d5467834b966fa9cd5a3dd on greenkeeper/initial into 4ce89dbf2f1fd5e2991db2e1cb3b1608264090ba on master.


[BUG] Code blocks in article headings are not sized correctly

:bug: Bug report
Current Behavior
Code blocks in article headings are not sized correctly

Expected Behavior
Updated article code block styling when it's used in headings
Minimal reproduction of the problem with instructions
What is the motivation / use case for changing the behavior?

Environment

Daffodil version: X.Y.Z
Angular version: X.Y.Z

For Tooling issues:
- Node version: XX
- Platform:

Others:

@damienwebdev @griest024 Do you guys have an opinion on whether we should:

Remove the usage of code blocks in headings
Keep the code blocks in headings and add appropriate styling for it

I perfer (2)

I also prefer 2.


Files having an 'include' statement are not scanned

Hi !
When a file state an 'include', php-cs-fixer fix command doesn't analyse at all the file (but none error is thrown).
PS: This is entirely independant of using the 'include' fixer.

That's odd.
Could you provide a detailed description with file example ?

Ok, as soon as I find the time.

@Zzortell any news ?

Wow, I completely forgot. And I'm a little busy currently, I will try to keep this in mind.

Closing due to cannot reproduce


more halp

Describe the Suggestion
sooo with the previous commnet , i forgot to add one more thing
please put it on curseforge as well cuz my friends' computer cannot run fabric
Screenshots and Videos
No response
Additional Context
No response

"help" is not "halp".
this mod (Create Fabric) is already available on Curseforge.
If your friend's computer can't run Fabric you can use Create, which is a Forge mod (yes Create Fabric just port it to Fabric).
Curseforge is not Minecraft Forge.
you can edit your original issue.


Problem with SimpleSpinLock::lock causing spinLock() to block execution

Good evening Dave,
I've come across a problem in the "reentrantLocking.ino" example. Running it on an esp32 causes a near dealock situation.
The spinlock() method never gets a "free lock". Trying to wait for the provided iterations period (0xFFFFFFFFUL) makes the sketch block for a very long time ...
Changing 0xFFFFFFFFUL to a much lower value resolves the blocking situation of course.
But, I dont understand yet why "if (tm_internal::atomicSwapBool(&locked, false, true))" never comes truecin this special situation ... I need more research on that.
Details:
esp32: Terminal output
ets Jun  8 2016 00:22:57
rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:1
load:0x3fff0018,len:4
load:0x3fff001c,len:1216
ho 0 tail 12 room 4
load:0x40078000,len:10944
load:0x40080400,len:6388
entry 0x400806b4
276 Running inner task, before lock =0
276 locked synchronously, count=1
276 in nested function, lock count=2
276 Synchronous task done=100
527 Running inner task, before lock =0
527 locked synchronously, count=1
527 in nested function, lock count=2
527 Synchronous task done=200
778 Running inner task, before lock =0
778 locked synchronously, count=1
778 in nested function, lock count=2
778 Synchronous task done=300
1026 Before try lock, count=0
1026 We need to do async lock=0
1026   - got the lock=1
1029 Running inner task, before lock =1
The problem starts here (reentrantLocking.ino) with the new TaskMgrLock:
...
taskManager.scheduleFixedRate(250, [] {
log("Running inner task, before lock ", myLock.getLockCount());
// take the lock
TaskMgrLock locker(myLock);
log("locked synchronously, count", myLock.getLockCount());
nestedFunction();     ...
SimpleSpinLock,h
/**

Take the lock waiting the longest possible time for it to become available.
*/
void lock() {
spinLock(0xFFFFFFFFUL);
}

SimpleSpinlock.ccp
...
if (tm_internal::atomicSwapBool(&locked, false, true))  {      >> doesn't come true
...

Thanks for investigating this, I'll try and spin up the example on my ESP32 with a debugger and hopefully, I can recreate it.


Failed to import Social Sharing to Ionic's Provider List

I am using Ionic 3. In the app.module, I do this:
import { SocialSharing } from '@ionic-native/social-sharing';
..
providers: [
...
SocialSharing
]
But it has the following error:
Type 'SocialSharingOriginal' is not assignable to type 'Provider'.
Type 'SocialSharingOriginal' is missing the following properties from type 'FactoryProvider': provide, useFactory [2322]
How can I solve this??

Hello, I hope you found solution for this. I had the same issue and used this:
import {  SocialSharing} from '@ionic-native/social-sharing/ngx';


Updated RoleType enum to include all role types

Short description outlining key changes/additions
Updated RoleType enum to include all role types
JIRA Ticket Number
IDVA5-783
Type of change

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Infrastructure change

Pull request checklist

[ ] I have added unit tests for new code that I have added
[ ] I have added/updated functional tests where appropriate
[ ] The code follows our coding standards

An exhaustive list of peer review checks can be read here

CI: No security warnings found


Multiple h1 elements in tonals page

We wish to find the tonals table on a class page.
Our initial way of doing that was to look for the table following a
Propulsion
 element.
But, that is failing, because in one class there is an unrelated table before the tonals table.
So, we need a new test.  This looks-like a generic pattern:

find all tables on the page
extract first td from the first tr
check if the td has a colspan, and check value of the colspan is 4
if it does, attempt to extract the tonal data from it.

Next issue to be resolved after https://github.com/DeepBlueCLtd/LegacyMan/pull/137


Use with node programs

Hello! I'm trying to use stopify to compile node programs, but the examples given in the docs all seem to be for executing code in the browser. As a first example, I had the program:
console.log("hello")

I tried compiling it using node_modules/.bin/stopify in.js out.js --require-runtime, but running node out.js doesn't do anything. I tried, in a separate module, loading stopify and using it to execute the compiled script, but it seems like the API expects an uncompiled program to be passed in.
Is what I'm trying to do possible? If so, any help you could give in getting the example above to work, and also any advice on how to compile node applications that have multiple modules, would be much appreciated.

Here is an example of using it in Node:
> var stopify = require('./stopify');
undefined
> var runner = stopify.stopifyLocally(`console.log('hello, world'); 42`, { /* compiler options */ }, { /* runtime options */ });
undefined
> runner.g = { console: console }; // makes console visible to stopified code
...
> runner.run(result => { console.log(result); });
hello, world
{ type: 'normal', value: undefined }
undefined

I am curious what you're trying. We've only ever used Node for unit tests.

I'm writing a programming language, and one of the targets is JavaScript. One of the issues is my language has a synchronous, blocking style, which is awkward to translate into JavaScript: pure functions should still be synchronous, but functions that do IO and the like need to be asynchronous, and many higher-order functions need to be duplicated to support both (Bob Nystrom explains it better). I was hoping to use stopify to allow the output to be written in a synchronous style.
Thanks for the example. Is there a way to perform the compilation ahead of time? It seems like the CLI command I mentioned does so, but then it's not clear how to actually run the resulting code.

Got it. Stopify should support what you want. But, it looks like ahead-of-time compilation has bit-rotted. (Our primary use-cases are in the browser.) It should be a straightforward fix, and I'll address it this week. Sorry -- I can't quite get to it immediately.

No worries, and thanks for the replies! If you don't mind one more question: what's the normal approach with modules? Would you normally transform the program into a single JavaScript file/string and pass that into stopify, or would you transform each individual module and have the import/require mechanism working as normal?

I've dealt with this a bit for Pyret, where we have a branch that's applying stopify in various ways to the output of the compiler.
The easiest thing to do is to generate one string and stopify it last. Stopify doesn't have support (yet) for handling top-level expressions/statements in modules that are required. require would just default to node require, which does its own (synchronous, as far as I understand it, though I don't know the state of the art with top-level yield and await) instantiation and caching.
We wanted to be able to do this more incrementally to support partial compilation and to support a mix of stopified and non-stopified code (e.g. we have some libraries that we know don't need to have stopify applied). We ended up implementing our own asynchronous require to handle blocking toplevel operations. I'm not proud of the readability of this code, but it does do transitive requires of modules; it also lazily invokes stopify on them programmatically:
https://github.com/brownplt/pyret-lang/blob/anchor/src/webworker/runner.ts#L104
Of course, if you don't have blocking/async operations at the toplevel in your language, you may be able to get away with the built-in, synchronous node require.

Thanks, that's very helpful!

I may have a fix in #469. I'll post instructions as soon as I get Travis CI to be happy.

@mwilliamson I've fixed this on master, and can put out a release shortly. Would you mind building from source?
The documentation describes anAsyncRun interface that isn't setup for the Node runtime. Getting that to work will take a little more work. But, the code below uses a little more boilerplate that is needed to build any blocking function. I've shown a blocking sleep function, but you should be able to plug in anything else.
Here is a library implementation of a blocking sleep function.
// lib.js

/** Begin boilerplate that will be removable in the future. **/
var $__T = require("@stopify/continuations-runtime/dist/src/runtime/runtime");
var $__R = $__T.newRTS("lazy");

var saved = false;

function pauseImmediate(callback) {
    return $__R.captureCC((k) => {
        return $__R.endTurn(onDone => {
          saved = { k, onDone };
          callback();
        });
      });
}

function continueImmediate(x) {
    if (saved === false) {
      throw new Error(`called continueImmediate before pauseImmediate`);
    }
    const { k, onDone } = saved;
    saved = false;
    return $__R.runtime(() => k(x), onDone);
}

function wrap(f) {
    $__R.runtime(() => f(), (result) => console.log(result));
}

/** End of boilerplate **/

function sleep(duration) {
    pauseImmediate(() => {
      setTimeout(() => continueImmediate({ type: 'normal', value: undefined }), duration);
    });
}

module.exports.sleep = sleep;
module.exports.wrap = wrap;

Here is an example program:
// example.js

// NOTE: A relative path will not work, because this is not
// a direct call to require. You can use an absolute path or put
// lib.js in a module (i.e., in node_modules).
var lib = require("/home/arjun/repos/Stopify/lib.js");

function main() {
    console.log('Hello, world');
    lib.sleep(1000);
    console.log('I slept');
}

// Generate this. Sorry. :(
lib.wrap(main);

Finally, build and run:
./stopify/bin/compile --require-runtime example.js example.compiled.js
node example.compiled.js
beautified example.compiled.js
/home/arjun/repos/Stopify/lib.js
Hello, world
I slept
{ type: 'normal', value: undefined }

Thanks, I've only a little time to play around this so far, but I'll hopefully have more time in the future. I did make one small change so that relative requires work, but I'm not sure what other (possibly incorrect!) effects this would have: https://github.com/plasma-umass/Stopify/compare/master...mwilliamson:node-relative-require

I want to add something that we ran into recently that's related, which is that stopify assumes a single namespace for global variables.  However, module, exports, and require can't be global since they have different behavior per-module that needs to be closed over if their evaluation is delayed by being inside a function.
We solved this with a trick I've seen elsewhere (for example in Google Caja), which is wrapping the code in a function with the appropriate arguments and then immediately applying:
https://github.com/brownplt/pyret-lang/blob/2807e54b2c8483ca390e6ce3754a54afe5735f02/src/webworker/runner.ts#L35
If we don't do this, it's not possible to get dynamic require to do the right thing with relative paths, or for module and exports to work right with some of the ways TypeScript generates code (which will generate code that closes over the global exports variable for uses of e.g. const export foo = 10 with foo used in a function). We still use .g to set the globals, but we immediately apply these three values – it may turn out that we need to immediately apply others as well to avoid further conflicts.
It seems like an opportunity for a configuration option to this AsyncRun to specify some names that shouldn't be treated as global but as “module”-local, even just by doing this trick on behalf of the caller.
I can look into doing this at some point, but wanted to get the idea down in a reasonable context.

It seems like an opportunity for a configuration option to this AsyncRun to specify some names that shouldn't be treated
as global but as “module”-local, even just by doing this trick on behalf of the caller.

I suppose you call evalAsync to load the code of each module. Is that correct?
If so, we could pass a set of module-level names to evalAsync. Would that work?

Basically, yes.
I think it should be a set of names and their values, though. This makes it so a module that doesn't use return can still communicate via side effects on module.exports or similar (as the caller of evalSync shares a reference to that object).
On Mon, Sep 07, 2020 at 10:51 AM, Arjun Guha <<EMAIL_ADDRESS>> wrote:

It seems like an opportunity for a configuration option to this AsyncRun
to specify some names that shouldn't be treated
as global but as “module”-local, even just by doing this trick on behalf
of the caller.

I suppose you call evalAsync to load the code of each module. Is that
correct?
If so, we could pass a set of module-level names to evalAsync. Would that
work?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub (
https://github.com/plasma-umass/Stopify/issues/468#issuecomment-688456061
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAA5IU5Y4LC2DMRQDA4LKWTSEUMQXANCNFSM4PBG5PQQ
).


Constantly opening elm.js after every "build"

For some reason, every time elm-live says that it rebuilds (it actually never does but that is a separate issue) it opens the elm.js file in whatever editor is associated with js files. Extremely annoying and I can't figure out how to turn it off. If someone desires this bug/feature, please make it a toggle.
Running version 4.0.2.

I suspect the command line is elm and it unfortunately attempt to execute the elm.js found

I'd suggest you use another name other than elm.js.
https://github.com/wking-io/elm-live/issues/230#issuecomment-678309617

@choonkeat that worked for me. Any idea where the problem is?

An other solution, that worked for me:
Change the default program for opening .js files to notepad. Now when I am using Visual Studio code. Elm.js does not open.
The solution provided by @choonkeat did not work for me as the file is generated by elm-pages. I have no control about the output filename.


Remove: GitHub.GitHubDesktop.Beta version 2.9.6-beta3

## .\Tools\YamlCreate.ps1 -SkipPRCheck -Mode 5 -PackageIdentifier GitHub.GitHubDesktop.Beta -PackageVersion 2.9.6-beta3

[X] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

/azp run


General maintenance

Changes
Proposed

Fix non default imports. For example:

import path from 'path'
// path has no default export so we would want to use
import * as path from 'path'

Change comma-dangle in eslint
Change lint-fix npm script name to format

Todo

Move main and renderer source files to different folders
Move webpack configs to internals with prod and dev subfolder
Remove all webpack.EnvironmentPlugin({NODE_ENV: ...}) webpack 4 takes care of that
Improve environment variable consistency

Changed

Move all build files to the dist folder
Add a .prettierrc and .prettierignore for better editor support
Integrate prettier into eslint
Fix Import order
Change all path.resolve to path.join for more consistency

Old pull request here.
Updated clean up @chentsulin.
Don't merge yet still need to change some things, submitted this to get feedback.

Does anyone know why this is failing?
I can't reproduce it

Sorry for the confusion? Better solution to what? @amilajack

It also might be a good idea to add prettier html and json to the git hooks

I can add those plugins as well if you would like

Yes, please add them and autofix the styles

@amilajack Done

Also please fix the merge conflicts

I fix the merge conflicts but I need to fix the problem with postinstall, specifically electron-builder install-app-deps

Closing this for now until merge conflicts are fixed


Version 2.4.2

Landed in https://github.com/metarhia/impress/commit/ec8ffc4675f85e47ea223fa159cec2b383f8b449


hand edited tilesets don't get converted to correct palette locally

https://github.com/Ragzouken/smooltool/commit/b0d60d9fe0b3f0f6b3f03f4bb85c9e9c3ae913ef


Phase Optimizer logging interferes with webpack error reporting

The PhaseOptimizer uses the java logger to report skipped passes. However, since this doesn't utilize the error reporter and outputs to standard error, this interferes with the ability to parse error messages and use them in a structured manner.
See https://github.com/google/closure-compiler/blob/e48d8acbd170e0e5a4468825450e1cc0bef3fac8/src/com/google/javascript/jscomp/PhaseOptimizer.java#L280

@ChadKillingsworth
do you have any idea how you'd like to fix this?
I suppose the pass skipping warnings could use the error reporter instead of the normal logger.
Would that resolve this?

My initial thought was to use the error reporter and add an "info" level warning. Not off - but not an error either.

I have a branch which adds a new CheckLevel called INFO and the pass skipping warnings use that instead of the normal logger.
But the more I think about it - the more I realize that perhaps just disabling logging entirely for the open source compiler is best. I can't think of a single reason a standard user would want those warning messages or be able to do anything with them. Only compiler devs care and they can make a custom build.
I'm just going to PR that first.

Fixed by  #2998.


Release candidate 2.0

Features

OCFL Dataset Versioning
CVAT Annotation Platform
OCFL Dataset Migration Functionality
Dataset Editing
Dataset Deletion

Bug Fixes

Load EPPO singletons
Fix upload communication email logic

That's an exciting title for a pull request! Congrats!!

This sounds very exciting! Nice work!


nixos/service/languagetool: init

Description of changes
Introduce a new service starting the 'languagetool' HTTP service. The recommended way to use HTTPS is via a reverse proxy with SSL support, see https://dev.languagetool.org/http-server.html.
Things done
Added a service test for basic functionality check.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I've added a note to the release notes.
Thanks for your review! I've learned quite a lot :-)


Same energy consumption  for different pieces of code

CodeCarbon version:  2.3.1
Python version:3.9.6
Operating System:  Apple M1 Pro. , macOS-14.0-arm64-arm-64bit

Description
I am trying to generate the emergency consumption when we run different types of inefficient code - like unwanted loops, multiple API calls etc.   The goal is to find the consumptions and  then change the code to make it more sustainable.
Tell us what happened, what went wrong, and what you expected to happen.
The problem is whatever code I run, I get the same energy consumption value .  i expect different values when different code is run.
What I Did
Pasting my 2 pieces of code that I am trying to run :
Code 1:
from codecarbon import EmissionsTracker
Initialize CodeCarbon emissions tracker
tracker = EmissionsTracker()
def inefficient_loop(n):
result = 0
for i in range(n):
result += i * i
return result
Start tracking emissions
tracker.start()
Call the inefficient loop with a large number
result = inefficient_loop(1000000)
print(result)
CODE 2
import requests
from codecarbon import EmissionsTracker
Initialize CodeCarbon emissions tracker
tracker = EmissionsTracker()
def inefficient_weather_api_calls(api_key, city):
# Simulate inefficient API requests by making multiple unnecessary calls
for i in range(5):
print(i)
response = requests.get(
f"http://api.openweathermap.org/data/2.5/weather",
params={"q": city, "appid": api_key, "units": "metric"},
)
# Inefficient: Not using the response data, just making repeated calls
return response
Replace 'YOUR_API_KEY' with your actual OpenWeatherMap API key
api_key = "2222f7ef9f5853ceb124704bcc9f8d44"
city = "London"
Start tracking emissions
tracker.start()
Call the inefficient weather API
response = inefficient_weather_api_calls(api_key, city)
Inefficient: Not using the response data, just making repeated calls
for _ in range(3):
response = inefficient_weather_api_calls(api_key, city)
Stop tracking emissions and print the estimated carbon footprint
tracker.stop()
print(f"Estimated Carbon Footprint: {tracker.final_emissions} gCO2")
print(f"Estimated Carbon Footprint: {tracker.final_emissions_data} gCO2")
Stop tracking emissions and print the estimated carbon footprint
tracker.stop()
print(f"Estimated Carbon Footprint: {tracker.final_emissions} gCO2")
Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

These were the results after running the code :
CODE 1 Results :
333332833333500000
Estimated Carbon Footprint: 1.8371171394348145e-07 gCO2
[codecarbon INFO @ 22:08:56] Energy consumed for RAM : 0.000000 kWh. RAM Power : 12.0 W
[codecarbon INFO @ 22:08:56] Energy consumed for all CPUs : 0.000000 kWh. Total CPU Power : 5.0 W
[codecarbon INFO @ 22:08:56] 0.000000 kWh of electricity used since the beginning.
CODE 2 :
[codecarbon INFO @ 22:09:33] Energy consumed for RAM : 0.000021 kWh. RAM Power : 12.0 W
[codecarbon INFO @ 22:09:33] Energy consumed for all CPUs : 0.000009 kWh. Total CPU Power : 5.0 W
[codecarbon INFO @ 22:09:33] 0.000030 kWh of electricity used since the beginning.
Estimated Carbon Footprint: 1.8994773814803363e-05 gCO2
If you see Carbon emissions are almost same.
Could you please help to make us understand what is wrong here .  I need to prepare a report showcasing how inefficient code - loops objects etc can cause higher carbon emissions.
Any changes in system setup is required?

"Carbon emissions are almost same." take care at the scientific notation : You have  1.8e-07 and 1.8e-05 which mean a 100x factor.
Do you have the beginning of the trace ? I suspect we use a constant CPU TDP.


[Bug]: binary package logs folder doesn't exist

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Environment
https://github.com/matrixorigin/matrixorigin.io.cn/issues/504
Issue Description
https://github.com/matrixorigin/matrixorigin.io.cn/issues/504
Steps to Reproduce
https://github.com/matrixorigin/matrixorigin.io.cn/issues/504
Additional information
No response

https://github.com/matrixorigin/mo_ctl_standalone/issues/33#issuecomment-1631776649


Build npm packages from source?

As far as I can tell, Nixpkgs installs all dependencies for node.js software by downloading them from NPM. While this is fine for some packages, many NPM packages go through some sort of build step before they are uploaded to NPM, such as transpilation via Babel or TypeScript, "statically linking" into one JavaScript file with Rollup or Webpack, or minifying the JavaScript source (removing comments, renaming variables to one letter, and other space-saving optimizations). Therefore, I think that in many cases NPM tarballs are a lot closer to a binary release than a source distribution.
If we care about building node-based software 100% from source (and I do mean that "if"—maybe it isn't worth the trouble), then we need some way to replicate those build processes ourselves. Presumably this means writing nix derivations for a lot of NPM packages, which would be a fair bit of work (note that this wouldn't be necessary for anywhere near all NPM packages—I'd say 80-90% of npm tarballs exclusively contain source files).
Sorry if this issue has already been raised elsewhere—I searched Discourse and the issues here, and didn't find anything, but I might have missed something.

Given the amount of package this would would bring in a lot of maintenance work that currently can't be met by manpower.
The only way I can see is some (semi-)automated way as is done for TeXLive.

still important to me


(fleet) skip re-installation of packages that have already been installed

This PR:

Stores the version of installed packages in the package DB
Checks during installation if we already have the latest version installed and skips if we do

This does not play well with "configurable" packages such as APM's injector with docker/host options but I don't think we have a good option there TBH. Our behavior is in line with APT or YUM.

/merge


Guide to geneerate a live preview of project on local system

Update the README.md to add a simple way to preview the changes made to the project locally

Hey please assign the task to me I would like to contribute


qintelqwatch: New App - Initial Commit of the Qintel QWatch App

Pull Request Checklist
Please check if your PR fulfills the following requirements:

[X] Testing of all the changes has been performed (for bug fixes / features)
[X] The readme.html has been reviewed and added / updated if needed (for bug fixes / features)
[X] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[X] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[X] Verify all checks are passing.
[X] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[X] Do NOT submit updates to dependencies unless it fixes an issue.
[X] Limit your pull request to one application and submit multiple pull requests if necessary.

Pull Request Type
Please check the type of change your PR introduces:

[X] New App
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation
[ ] Other (please describe):

Release Notes (REQUIRED)

Initial Release, providing the "search qwatch exposures" and "on poll" commands

What is the current behavior? (OPTIONAL)
NA
What is the new behavior? (OPTIONAL)

New App

Other information (OPTIONAL)
Pay close attention to (OPTIONAL)
Screenshots (if relevant)

Thanks for contributing!

@calvin-qintel , Could you please provide me the access rights for this repo?

@dhwanis-crest I don't have access to change permissions on this repo. Pinging @pzhou-splunk who initially set it up.

Hi @calvin-qintel , I need the access rights for this forked repo to push changes on this PR. I think this is created by you so you would’ve the permission to provide me the access.

The changes of this PR are incorporated into  this- https://github.com/splunk-soar-connectors/qintelqwatch/pull/2