chore(docs): more clear params

What type of PR is this?
/kind documentation

Any specific area of the project related to this PR?
/area documentation

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

ff5041b chore(docs): more clear params

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: therealbobo
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @therealbobo! It looks like this is your first PR to falcosecurity/plugins 🎉

Hi @therealbobo. Thanks for your PR.
I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LGTM label has been added.  Git tree hash: 2388224eedfa458f5fd921705e861485279484b2

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce, therealbobo
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Removing _dl_sym and the requirement for it when running Splunk. This…

… is a temporary fix.
resolves #317

Reviewed with no comments.


imageupload tests: run serially

We've recently switched the imageupload suite to run in parallel, which has introduced flakiness:
https://search.ci.kubevirt.io/?search=unexpected+return+value+502&maxAge=48h&context=1&type=bug%2Bissue%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job
this was also seen in a previous attempt to make them parallel:
https://github.com/kubevirt/kubevirt/pull/11716#issuecomment-2373256509
let's put them back to running serial for now as the gain in runtime is not drastic.

What this PR does
Before this PR:
After this PR:

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

Thanks a lot for the quick response @akalenyu!
Did you figure out what have caused the flakiness? If so, can you please add the reasoning to the PR description?

So what I know is that running these in parallel increases flakiness, I am not sure why. Definitely something for us to look at..

Thanks a lot for the quick response @akalenyu!
Did you figure out what have caused the flakiness? If so, can you please add the reasoning to the PR description?

So what I know is that running these in parallel increases flakiness, I am not sure why. Definitely something for us to look at..

Fair enough. Thank you!
/approve

I see the retry mechanism I added to virtctl is not enough. Shouldn't have done that in the first place.
To me it still looks like the underlying issue is: https://github.com/kubevirt/containerized-data-importer/issues/3450

I see the retry mechanism I added to virtctl is not enough. Shouldn't have done that in the first place.
To me it still looks like the underlying issue is: kubevirt/containerized-data-importer#3450

I wasn't aware of that. The theory looks really promising. WDYT @mhenriks


ulauncher: 5.12.1 -> 5.15.0

Description of changes
For changelog see: https://github.com/Ulauncher/Ulauncher/releases
fixes https://github.com/NixOS/nixpkgs/issues/119350.
For the fix: the 0001-Adjust-get_data_path-for-NixOS.patch is no longer needed, the application wont start with it applied as it is not able to find the data dir. Without it, it works just fine.
I also adjusted the fix-path.patch to work on the latest version.
Additionally, ulauncher now depends on libX11 so I added it to LD_LIBRARY_PATH as passing it to buildInputs or nativeBuildInputs did not work.
I also set WEBKIT_DISABLE_COMPOSITING_MODE=1 because if i dont set it, the settings wont show up for me. (see this issue for the source of the workaround)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This doesn't work on my system. It builds, but when I try to run it, I get
Traceback (most recent call last):
  File "/nix/store/nhssah562br1kj01d3m86i11n5zfb0bl-ulauncher-5.15.0/bin/.ulauncher-wrapped", line 28, in <module>
    from ulauncher.main import main
  File "/nix/store/nhssah562br1kj01d3m86i11n5zfb0bl-ulauncher-5.15.0/lib/python3.10/site-packages/ulauncher/main.py", line 16, in <module>
    gi.require_version('Gtk', '3.0')
  File "/nix/store/0r0x4g07zd3nrrrlla8hfzsg88sfp0as-python3.10-pygobject-3.42.2/lib/python3.10/site-packages/gi/__init__.py", line 126, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace Gtk not available

That's why in https://github.com/NixOS/nixpkgs/pull/189505, gobject-introspection was moved to nativeBuildInputs, which fixes that error. You seem to have silently undone that change.

Yeah, I've seen this commit but since it is working for me, i thought never touch a running system.
Anyways I had to include a bunch of more packages in nativeBuildInputs in order to get it working again.
@tmarkov  could you please confirm it works for you as well now?

No, now I get
Traceback (most recent call last):
  File "/nix/store/22p02rr6mpfs30dm215am0cgw62d06cm-ulauncher-5.15.0/bin/.ulauncher-wrapped", line 28, in <module>
    from ulauncher.main import main
  File "/nix/store/22p02rr6mpfs30dm215am0cgw62d06cm-ulauncher-5.15.0/lib/python3.10/site-packages/ulauncher/main.py", line 25, in <module>
    from ulauncher.ui.windows.UlauncherWindow import UlauncherWindow
  File "/nix/store/22p02rr6mpfs30dm215am0cgw62d06cm-ulauncher-5.15.0/lib/python3.10/site-packages/ulauncher/ui/windows/UlauncherWindow.py", line 11, in <module>
    gi.require_version('Keybinder', '3.0')
  File "/nix/store/0r0x4g07zd3nrrrlla8hfzsg88sfp0as-python3.10-pygobject-3.42.2/lib/python3.10/site-packages/gi/__init__.py", line 126, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace Keybinder not available

It worked for me with only gobject-introspection moved to nativeBuildInputs. Did it not for you?

If i just move gobject-introspection into native build inputs I get:
Traceback (most recent call last):
  File "/nix/store/nc2ig7brdhg01pmbp4rfqd6is908yll4-python3.9-pygobject-3.42.1/lib/python3.9/site-packages/gi/importer.py", line 142, in load_module
    introspection_module = get_introspection_module(namespace)
  File "/nix/store/nc2ig7brdhg01pmbp4rfqd6is908yll4-python3.9-pygobject-3.42.1/lib/python3.9/site-packages/gi/module.py", line 257, in get_introspection_module
    module = IntrospectionModule(namespace, version)
  File "/nix/store/nc2ig7brdhg01pmbp4rfqd6is908yll4-python3.9-pygobject-3.42.1/lib/python3.9/site-packages/gi/module.py", line 109, in __init__
    repository.require(namespace, version)
gi.RepositoryError: Typelib file for namespace 'Pango', version '1.0' not found

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/nix/store/wqc74ydd00893zdrfrzrf0xqincc8q4r-ulauncher-5.15.0/bin/.ulauncher-wrapped", line 28, in <module>
    from ulauncher.main import main
  File "/nix/store/wqc74ydd00893zdrfrzrf0xqincc8q4r-ulauncher-5.15.0/lib/python3.9/site-packages/ulauncher/main.py", line 18, in <module>
    from gi.repository import Gtk, GLib
  File "/nix/store/nc2ig7brdhg01pmbp4rfqd6is908yll4-python3.9-pygobject-3.42.1/lib/python3.9/site-packages/gi/importer.py", line 144, in load_module
    raise ImportError(e)
ImportError: Typelib file for namespace 'Pango', version '1.0' not found

Indicating that pango is missing, which makes sense since it is not in the nativeBuildInputs...
Maybe this an issue with how I test the package, as I have my own package overlay where I define this derivation. Although this should not matter, as to my knowledge nix is sandboxed so no matter how you build a package, if it has the same inputs and same derivation it produces the same Package. To test this, could you provide me with the hash the derivation produces like this:
❯ readlink $(which ulauncher)
/nix/store/cwqshiz3iy4mmpn4rlprh8xs4afpm6sf-ulauncher-5.15.0/bin/ulauncher

Could you also provide me with the exact commands you run/files you have to test this PR?

Sorry for the long delay, this should finally fix it.
Could you please confirm @tmarkov?

Yup, I can build and run it.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1346

Hi, late comment but instead of using LD_LIBRARY_PATH we can use a patch that fixes loading of X11:
fix-libx11-path.patch
commit 692231f1bc1d7dd440b947715988cc61e4dfa10a
Author: Nicolas Berbiche<EMAIL_ADDRESS>Date:   Tue Apr 5 02:12:29 2022 -0400

    xinit: use configuration time variable to retrieve libX11 so

diff --git a/ulauncher/utils/xinit.py b/ulauncher/utils/xinit.py
index d358533..cd51803 100644
--- a/ulauncher/utils/xinit.py
+++ b/ulauncher/utils/xinit.py
@@ -11,7 +11,7 @@ if IS_X11_COMPATIBLE:
     # discussion of this ABI version back to before 2009, 12 years prior to when this code was added.
     # Also, with most of the development focus on Wayland, the chance of a ABI version bump in X11 is
     # exceptionally small. Therefore, no additional fancy discovery methods are necessary.
-    x11 = cdll.LoadLibrary("libX11.so.6")
+    x11 = cdll.LoadLibrary("@libx11_path@")

     # In order to use any X11 calls from multiple threads, the X11 library must be initialized to use
     # mutex protection. XInitThreads() sets this up and must be called before any other X11

And substituting it:
ulauncher.nix
{
  patches = [
    (pkgs.substituteAll {
      src = ./fix-libx11-path.patch;
      libx11_path = "${pkgs.xorg.x11}/lib/libX11${pkgs.stdenv.hostPlatform.extensions.sharedLibrary}";
    })
  ];
}

I don't feel like submitting a PR, so do whatever you want with this knowledge :)

Can you please submit a PR? Using LD_LIBRARY_PATH is often a source of impurity and can cause lots of problems.


Design: Workouts

Ticket shows design iterations for the view "WORKOUTS" and lists features
ACCESS: everyone

MVP Stage Features

[ ] ADD WORKOUT BUTTON

[ ] WORKOUT TITLE

[ ] WORKOUT POINTS

[ ] "DONE" BUTTON

[ ] click on workout opens "EDIT WORKOUT" View

Connect button to /claim/ api


how to catch the status of the validation ?

eg:
$(form).validator('validate')  returns the form object.
I need to get a boolean value - true or false.... or the field names with errors.
how do i get that ? there is no method documented

No such method exists. You can check if any form-groups have the has-error class on them.

ohh... this thing is completely automated .... it will be handy if there is a way to call it and check the status manually for complicated scenarios.
there is also a problem when you reuse the same form over and over again. once the form validation is pass through it keeps the state somewhere, then the next time on the same form it passes through even if there is an error, it does give the error feedback though, but the submit do not stop

is their a way that i can get the massage in variable instead of showing it within the the div ??
actually i want to use notify.js  plugin with it

http://1000hz.github.io/bootstrap-validator/#validator-events
@methakon Listen for the invalid.bs.validator event

Hello @ituhin
I am using like this.
function formValidator(form){
		//vaildate first
		form.validator('validate');

		var hasErr = form.find(".has-error").length;
		return hasErr;
	}

and then
var hasErr = formValidator($(this));  //<- $(this) is form

if(hasErr != 0){
	return;
}else{
	//Ok go!
}


Create Consumer for BPMN Errors

Description
We need a consumer that listens to BPMN errors and correlates the bpmnError Message in the specific StreamingTemplate process instance.
Details
Request a digiwf-integration-errors topic

A new event type createBpmnErrorshould be created and added to the typeMappings
Create the BpmnErrorEventDto

processInstanceId: string
errorCode: string
errorMessage: string

Correlate the bpmnError Message for the specific processInstanceId and pass the errorCode and errorMessage
Log.error if a bpmn error cannot be correlated do not create a dlq of bpmn errors

Technical hints

create a new errors package in the digiwf-connector-core module. You can copy the message package. It will be almost the same
create a ErrorService Interface that is implemented in digiwf-camunda-connector module. You can almost copy everything from the MessageServiceImpl because we will implement BPMN Errors via a EventSubprocess that is correlated with a message
extends the *-rest module to easily test the whole setup without the need of a sample integrations service that throws errors. You can copy the message package

I would use *-errors for BPMN errors and *-incidents for Incidents

Hi @lmoesle we talked about a sample integration service that can be used. I would do that in a second step. First step would be extending the rest api to fake it. Can be done more easily. I have created some technical hints for that issue

Topics are commissioned (https://git.muenchen.de/openshift/kafka/-/issues/70)


marketplace link is 404

Is this still an issue?
Seems that https://github.com/marketplace/actions/github-action-to-run-probot-settings works from here.
❓


Use correct uuid.NewV1() API

This PR fixes invalid usage of uuid.NewV1().
This method returns a value and an error, and it was used inline, like it returns a single value.
Fixes https://github.com/Azure/azure-sdk-for-go/issues/4690

The builds using azure-sdk-for-go fail with the following message:
# github.com/Azure/azure-sdk-for-go/storage
../../Azure/azure-sdk-for-go/storage/table_batch.go:135:61: multiple-value uuid.NewV1() in single-value context
../../Azure/azure-sdk-for-go/storage/table_batch.go:142:48: multiple-value uuid.NewV1() in single-value context

this change was made by auto generated code. see https://github.com/Azure/azure-sdk-for-go/issues/4690.
after fixing it, can you please fix codegen to include this new code?
thanks :)

Can one of the admins verify this patch?

The problem here is that HEAD and tag v1.2.0 (the version we reference) have different signatures for uuid.NewV1().  If you're not using dep to manage dependencies can you please pin your module dependency to v1.2.0 to uuid?

Closed in favor of https://github.com/Azure/azure-sdk-for-go/pull/4699


Preload option

Hi there, first time user. We decided to give Rive a shot, and our first use case is a loading animation for page load itself.
This means that it is of critical priority for the animation to appear as soon as possible on the page.
I am using @rive-app/react-canvas as such:
<Rive src='/loader.riv' />

I noticed that the loader was taking an unexpectedly long time to appear on screen, despite being a small file.
After having a look, it seems Rive only loads assets after loading rive.wasm. In general, it would be nice to be able to self-host/bundle that wasm file, but that's a separate issue.
If I change my code to this:
<link rel='preload' href='/loader.riv' as='fetch' />
<Rive src='/loader.riv' />

The asset will be loaded by the browser immediately – before the wasm asset.
This should be a trivial prop/feature to add to the React component, and is crucial for many use cases.
Note: I originally searched for a preload option in the Rive docs, as I assumed there would be one, but instead only found this article, outlining the same idea.

Hey @zplata, thanks for a quick response.
Yes, I would expect any preload prop to inline the link tag. It's perfectly acceptable and spec-compliant to include link tags within the body, as long as the link type is body-ok. Docs here.
Somewhat relevant article here.


Ensure all do_lookup blocks have empty list protection

Changes introduced with always_execute_geocode_block would cause nil object errors if there were no results.  In my case, it was causing rake db:seeds to blow up.

Thanks!


How to save console result after run TuckER iteration finish

What steps will reproduce the problem?

Dear anyone;
Please help to guide me how to save the result after I run iteration about 250-500 training completed ?
I left computer open for a few day and finish then I could not save result and run the next dataset because the recent data traing will gone.
Regards, Pop

Hey @bmaungklang, to save all results you run in the IPython console (i.e. inputs and outputs), you need to run the following command directly on it before running your code:
%logstart -o

This should create a file called ipython_log.py in the console's current working directory (you can check that directory by running the command %pwd before %logstart -o).
When you want to stop recording results, you need to run
%logoff

Here you can find more help about this command:
https://ipython.readthedocs.io/en/stable/interactive/magics.html#magic-logstart
Please try that and let us know if it works for you.

Closing due to lack of response. Hope the ideas I gave you were useful to solve your issue.


Specify highway types: avoid motorways

keep from trying to route us onto roads inappropriate for running.

Problem: in the current settings runners are routed onto highways which are definitely unsuitable for runners e.g. motorway
Solution: Specify custom_filter in osmnx.graph.graph_from_polygon [1], for an inspiration can be use CityStrides Street Query [2].
osmnx.graph.graph_from_polygon(polygon, network_type='all', simplify=True, retain_all=False, truncate_by_edge=False, clean_periphery=True, custom_filter=custom_filter)

References
[1] OSMnx docs
https://osmnx.readthedocs.io/en/stable/osmnx.html?highlight=custom filter#osmnx.graph.graph_from_polygon
[2] CityStrides Street Query
https://docs.google.com/spreadsheets/d/1dbj5giwBhCG-jWmokCnQOJhkIEE132FvXVyrvDL7tSU/edit#gid=1943684409

Thanks for opening this issue. You may also find it helpful to see how the existing filters(drive,walk, etc.) are defined to modify, and that can be found in the downloader.py file in the OSMNX repo.
downloader.py

I added following filters 👇, it seems to filter the motroway out.
CUSTOM_FILTER = (
    f'["highway"]["area"!~"yes"]["highway"!~"bus_guideway|bus_stop|construction|cycleway|elevator|footway|'
    f'motorway|motorway_junction|motorway_link|escalator|proposed|construction|platform|raceway|rest_area|'
    f'path|service"]["access"!~"customers|no|private"]["public_transport"!~"platform"]'
    f'["fee"!~"yes"]["foot"!~"no"]["service"!~"drive-through|driveway|parking_aisle"]["toll"!~"yes"]'
)

It should be live on the www.everystreetchallenge.com.
Thanks for you report and time!


Added filter-off icon

Hi 👋
I needed an icon to remove a filter, so I used the x from screen-share-off and cut the polygon of filter.

@gubser Nice icon!
Maybe we should call this filter-x instead of filter-off 🤔

Sure, here you are :+1:


Object decoded from query unable to resave into database

I've run into an issue where if I query the database and decode the results my objects have all their data and behave as expected. If I then change a variable and try object.save(into: db) it fails. If instead I get the object with the db.document(withID: as: object.self) method the object can be saved no issues. Maybe this is expected? Or is it expected to be able to modify objects collected from queries?

Document itself is readonly so you would need to get the MutableDocument by calling toMutable() and then decode the MutableDocument.

Sorry for replying this late. For some reason, I didn't get notification at all.


Config loader for plugins

for plugins that needs configuration data: like dedimania, mxkarma...

well.. maybe it's possible to use Yaml::parse() with ./app/config/plugins/pluginname.yml

Right now you should use the symfony config system.
later it will be handle by #27


Added method for checking if a string matches an elements symbol or name

Adds a simple method to check if a string is the same as an elements name or its symbol.

can we change clang format to only format the code that was changed not the whole file? It is really hard to do code review.

I would not know how to do that. I can go ahead and format the hole repo. Then this should not be as difficult.

@JensWehner Hey can you approve this?

@JensWehner I think I have now addressed your concerns.


Compat causes crash on Fabric with any version of compat

Sorry about the messy title. I'm playing on a server using this Fabric modpack. I'm getting crap FPS with Create using shaders so have tried to add this Compat mod, but the game crashes the instant the minecraft window appears - I've tested every compatible version of the mod.
crash-2024-12-17_14.13.22-client.txt
latest.log

Scratch this - I just needed to update my GPU drivers.


New files not appearing in mount

I had plexdrive working but any content added after ~30-May (realise the date is likely irrelevant) does not seem to appear in the mount.
I can see the files when logging into GDrive via browser, but not found within the plexdrive mount.
Cache appears to be complete, this started with plexdrive v2, and have now upgraded to v4 but the same content is found, i.e. not anything new.
I mounted via rclone and the files do appear (but subsequently hit the API ban), after the ban re-mounted with plexdrive and still no newer files.
I have tried deleting the cache, token.json & config.json in ~/.plexdrive and re-set up, also to no avail.
Is there something else I need to completely delete and restart cache?

No, this should be sufficient.
Maybe your files are shared, with an option that is not supported by plexdrive, yet?

Thanks @dweidenfeld
I assume you mean share settings on the actual GDrive files.
I haven't changed anything that I am aware of, did you have any share options in mind that I could check?

@dweidenfeld, I seem to of resolved, not entirely sure how but I did do two things and it seems to of worked...

I did have "Convert uploaded to Google Format", which I wouldn't of thought got enacted for my files, but I turned this off
I re-set my uploading authorization, again

And the new file seems to appear, I'm guessing it was to do with my uploading, and them getting corrupted or something somehow, rather than the Google setting.
Thank you for your help...
Feel free to close the ticket


Uprev libnetwork to pull in Solaris bridge driver support

- What I did
- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)
This PR proposes to uprev libnetwork to bring in the Solaris bridge driver support which is a dependency for #23397.
Signed-off-by: Amit Krishnan<EMAIL_ADDRESS>

I think #27594 is already bringing in solaris changes in libnetwork. Please check.

Yes it does. Thanks @aboch!


Safe creation with MetaMask v 10.x.x or greater fails to submit well composed transactions due to EIP1559

Description
[UPDATE]: the transaction DID end up completing successfully. This may have been a red herring and more of a network issue at the time?
(Sorry if this is the wrong repo!) When submitting the initial safe creation transaction, the gas parameters seem to be far off from what MetaMask would suggest for the same transaction. Submitting with the safe's gas suggestions causes transactions to get stuck. I'm not sure if this is just a coincidentally, poorly timed transaction, or if this would reproduce consistently in less congested network conditions
Environment

Browser: Firefox
Wallet: MetaMask
Environment:

production

Steps to reproduce

Go to the safe
Create a new safe
Submit transaction through metamask (do not change gas parameters)
Transaction stuck

Expected result
Safe should create successfully with EIP1559
Without doxxing myself, here are some numbers that look weird after my initial transaction:

@Schwartz10 , could you also provide information about the network: is it mainnet or any other network?

The safe creation flow is now more robust wrt monitoring the submitted tx/reporting errors.


[ENH] - Add Infracost to QHub CI and CLI

Feature description
Infracost is a tool that helps us retrieve the difference in monthly cloud cost estimates between the current and planned state of Terraform projects. With wide support for AWS, GCP & Azure, it can be integrated to our QHub CI to help us understand how our costs will change in case we make critical changes to our infrastructure.
Value and/or benefit
With the integration to QHub CLI, a user will be able to retrieve the total predicted costs for running QHub on a public cloud provider.
Anything else?

Infracost

Hi @dharhas, just to be sure. How do we want this to be included in the OGC sprint, and what should be moved as future work?

Currently, we have a PR to add this as an action to qhub main repo. Would like to know your thoughts on this as well, just to move accordingly.


docs: fix 8.3 typo and adding PHP version strategy

The Issue
8.3 is not marked up as code. Also, we could add the DDEV PHP version strategy? Maybe it belongs somewhere else?
How This PR Solves The Issue
Manual Testing Instructions
Automated Testing Overview

Release/Deployment Notes

You're welcome! I am eternally grateful to the DDEV team for tirelessly maintaining and expanding the wonderful tool that DDEV is.


Added os.expandvars to url attributes in deployment.py

Custom urls for repos often will have environment variables used for oauth2 authentication to private repositories. I have added logic in deployment.py to expand these for the url attributes.

Yep, working for me too.


No Pokemon

It seems like it should work since it returns a token when I login, but when I search for pokemon in a 1 x 0.5 km area which usually returns quite a few pokemon.. Im getting nothing at all. Im using over 200 coordinates within that are also and still getting nothing. Since Im getting the access token back, Im guessing that it is returning data, and when I look at the dump from the nearby pokemon requests it is returning arrays.. just nothing in them, no pokestops either, yet there is a pokestop in that area searched... ideas?

Open the settings and click show pokemon.
It's off by default by mistake

Is that in the node server settings? Im just doing a curl call, so Im not sure what you mean by the "settings" :)

Oh... you're not using the web client.
You might have been blocked.
Are you using an account that you've used to login to the real app since the latest update? You gotta be careful these days, they block stuff that doesn't look like the official client.

Ill try logging in again to the real app.. Ok I just logged in using that account and I logged in fine and see the map and nearby poke's, etc.. Plus they are returning an access token to me through curl. I was using this same account on a friend's node.js server and it was working until his server went down and since he's sleeping I can't have him restart it :) So I installed my own on my local computer, and I can see it working and running, but no pokemon are being returned.

Something wrong, I have been using the application (web client) for a couple of days already, and a while ago, nothing appears, no pokemon, no gyms, and no pokestops, just the plain map

See https://www.reddit.com/r/pokemongodev/comments/4w0jum/all_ptcgoogle_logins_failing_from_api/?sort=new .

@enst @coolaj86 so reading through that reddit that would mean that the code needs to be updated and maybe reinstalled? Im not a node developer, so Im just using it with curl through php to do what I need, so Im not sure what needs to be done, otherwise I would help out :). Looks like a new hash though.

link to the API release: https://github.com/keyphact/pgoapi

This is based on node.js (that's why it can run even on windows, without a C compiler or complicated install), so it actually uses https://github.com/Armax/Pokemon-GO-node-api.
However, I need help keeping up-to-date. It's a very easy task. Please let me know if you can help.
See https://github.com/Daplie/pokemap-webapp/issues/20


Sticky shared subscriptions

We are using shared subscriptions to handle messages on multiple instances of mqtt client application. To distribute messages we're subscribing to topics with name like '$shared/GRP/a/b/+/+/c/d'. In this situation with existing distribution policies we have no guarantees that the same instance of client application (the same subscriber) will handle messages from the same topic which breaks ordering of message handling.
It'd be nice to have support of sticky shared subscriptions like here - https://flespi.com/blog/sticky-shared-subscriptions-smarter-load-balancing-with-flespi-mqtt-broker or to have a 'hash' distribution policy like here - https://www.emqx.io/docs/en/v5.0/advanced/shared-subscriptions.html#load-balancing-policy-and-dispatch-ack-configuration.
Or may be it's already possible to achieve this goal somehow using existing vernemq?

@lasfromhell Verne implements shared subscription policies based on the assumption that the way to optimise delivery is to take into account to which node the PUBLISHER of the message is connected to. Verne can then deliver this message to a SUBSCRIBER connected to the same node, so that no in-cluster communication is needed. This is what local means. I don't know whether we can call this a variant of 'stickyness'.
There's also the built-in assumption that you prefer to deliver to an online queue before an offline queue. This is the weaker of the 2 assumptions, that is the local one sets the boundaries. Therefore, you can reverse the order with the prefer_online_before_local configuration, which is probably the most intuitive one. It will look for an online subscriber on a non-local node, if there are only offline subscribers on the local one.

random,
prefer_local,
local_only,
prefer_online_before_local

Whether one of those policies matches your needs is for you to decide, of course.

:point_right: Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
:point_right: Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

Yes, I understand local policies but in this case Verne sends the message to a random subscriber connected to local node (node the publisher of the message is connected to). But in our situation we need guarantees that the same subscriber will be selected for the same publisher (or for the same topic name), need to be sure that messages from the same topic always handled by the same application instance (subscription with wildcards, so each instance is subscribed to multiple topics)

Is it possible to implement in plug-in? I see there hooks like 'on_publish' and 'on_deliver' but looks like that these hooks don't allow to select another subscriber.

No, it can't be done as a plug-in. It needs to be added as a shared subscriber policy. The filter here does not have access to the publishing ClientId, though (supposing you'd want to hash on it); it would've to be injected from upstream calls.
https://github.com/vernemq/vernemq/blob/f08eb1405d781374bd99999068ac8f276d56fbd9/apps/vmq_server/src/vmq_shared_subscriptions.erl#L106

:point_right: Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
:point_right: Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

Okay, thank you for details

Why was this closed? I require something similar. Order of messages are important in my use case, and randomly distributing messages will break this. Hash-based routing is essential

@Climax777 Issue is closed because I took the time to layout what is implemented and what is currently not implemented. I also gave hints on how to go about it if someone needs to add this.
I'll happily review any related PRs!

:point_right: Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
:point_right: Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.


verify if ASUS ZenPad is running Chrome webstore kiosk app or fspmarshall's kiosk fork

fspmarshall's kiosk fork
https://github.com/fspmarshall/kiosk

Add here the fact we also need to know if it is running Forrest app, if we can automate the power on and off by comparing the commit Forrest did editing the code!

The ZenPad is running the application from the Google Play Store. In the "Play Store -> My Apps & Games -> Installed" section, the Kiosk Browser application shows up. If he had done his own installation, I shouldn't be able to see it in the "Installed" section of the Play Store matching the most recent version.

Thank you. I guess the next step is to figure out the options on turning it off from the Google Play store then (if we can pay a fee to permanently allow to power it off or on) and if we can use that version for research.
Since I am not sure if we are keeping or not the kiosk project on Github, as it seems we are not using, can you create another issue on this project indicating the new task so we keep the discussion on the new issue? Also, please post a comment here with the link to the issue and this issue link on the new one so we can trace it back in the future.

Okay, I've created the new issue: https://github.com/erdl/survey_display_local/issues/3

Alright, I guess this issue is done then, I am closing it.


Moved Generic Core classes

Changes in this PR:

Moved Response to com.generic.core.http.models
Moved BinaryData classes to com.generic.core.util.binarydata
Moved Context to com.generic.core.util
Moved Header, HeaderName, and Headers to com.generic.core.http.models

/azp run java - generic-sdk-core - ci

I'm not sure how I feel about moving Header, Headers, HeaderName, and Response into http.models, we dropped Http from the class names to enable them to be shared across wire formats (AMQP, HTTP) but by moving them into the http.models package we're effectively bringing that back but leaving the classes with less unique names possible leading to needing to fully qualify classes in code more often.

Per offline discussion the models will move into models.http but their names will also change to suffix with Http to help reduce class name conflicts.

Per offline discussion the models will move into models.http but their names will also change to suffix with Http to help reduce class name conflicts.

Correct, all mudels but Response will get an Http prefix.


Google Compute Engine support

Libretto needs to be extended to support Google Compute Engine. The new provider should support the standard list of operating systems mentioned in the Readme

https://github.com/apcera/libretto/pull/55


[Info]Source of Shell icons

@moudey I wanted to ask what is the source of the fluent icons used in the Shell context menu, as I couldn't find them in the repository, and if it was possible to download them. Thank you.

https://learn.microsoft.com/en-us/windows/apps/design/style/segoe-fluent-icons-font

Segoe Fluent Icons is a type of font created by Microsoft. Instead of letters and numbers, it contains symbols and icons. These icons are designed to be used in user interfaces of software and applications. They're part of Microsoft's Fluent Design System, which is all about making interfaces easy to use and consistent across different Microsoft products like Windows, Office, and others. The goal is to give users a smooth and intuitive experience, no matter which Microsoft product they're using.
... and they can not be downloaded

https://aka.ms/SegoeFonts

Thank you very much!

https://learn.microsoft.com/en-us/windows/apps/design/downloads/#fonts


Please distinguish between I and l better

I absolutely hate Roboto as a user interface font as the I (uppercase i) and l (lowercase L) are not distinct enough. They can also get confused with vertical bars | or | as well as numerous other unicode characters.  If you want to create the ultimate clear and functional font then please be doubly clear by adding bars to the I (uppercase i) and also add a small tail to the l (lowercase L).

sample text

Ill behaviour is caused by an AI called Al III commissioned by the little men in the Illogical Illuminati
aR65Hus0lfG3
Illinois

en-821-sentence-Roboto-Regular
en-821-sentence-roboto-regular
en-821-sentence-Roboto-Italic
en-821-sentence-roboto-italic
en-821-sentence-Roboto-Black
en-821-sentence-roboto-black

sample test text for the above request

Ill behaviour is caused by an AI called Al III commissioned by the little men in the Illogical Illuminati

aR65Hus0lfG3

Illinois

en-821-sentence-Roboto-Regular

en-821-sentence-Roboto-Italic

en-821-sentence-Roboto-Black

I wonder how will you concoct this since Roboto is a grotesque design; it just won't fit. Lowercase ells do not necessarily need to have tails to be distinguishable; the varying cap height of lowercase and uppercase helps on that, and let's not forget about context, which also helps disambiguate.

Yes make this happen. This is unacceptable to such a humanist focused design font like Roboto. Just look how Helvetica, San Francisco and Segoe pulled this off better

Is basically a flaw design. Several other fonts have this same problem, Nimbus Sans, Open Sans, Helvtica Neue, Google Sans etc.  Noto also by Google do not have this issue.

The best Open Source font I found is KDE Oxygen or the new Oxygen Sans fonts. They have nice shape and don't have the capital I and lower case, vertical bar issue.


Optimize hover feature for people page

When we tap on a person, the card flips to show info, but it doesn't flip back on tapping again

@shubhamkrm it would be great if you could share a GIF to establish your claim.

Btw I guess, there is no tap required. Only hovering over the card makes it flip and it flips back when mouse moves out of the region. Also it will not look better according to me with tap modification in my opinion.


Quality guidelines for samples

As we're updating samples for Steeltoe v4, please keep the following guidelines in mind:

Start from the standard .NET 8 project templates, add comments for Steeltoe/sample-specific changes.

Suffix project names with "Web" for web-based clients, suffix with "Service" for APIs and microservices.
Don't delete parts from the standard project templates that aren't strictly needed for the sample. The goal is for readers to recognize the boilerplate code. Removing parts raises the question of whether the sample is incompatible with the boilerplate.

Enable nullable reference types and prefer modern C# syntax, such as primary constructors.
All samples should have the Steeltoe.Samples code namespace prefix.
Consider adding integration tests, if feasible, and add status badges to /README.md.
Consider adding random-route: true to manifest files.
Run code-cleanup (we need to create a script that replicates *.sln.DotSettings into the sample directories first).
Don't forget to describe how to use the sample in a README.md.

Bonus points:

Use modern features, such as minimal APIs

Pending alignments:

Connector and Discovery samples don't use the Steeltoe.Samples namespace prefix.
Security samples don't use the project name suffixes, #333.


PDF improvements: names and symbols

Description
This addresses some of the items in issue #481.
Checklist

[X] Commit sequence broadly makes sense and commits have useful messages
[X] Code is formatted according to CONTRIBUTING.md
[X] Self-reviewed the diff

Just two items left to do.

[ ] Lines 83--86 of Introduction.lagda: The symbol X is not defined.
[ ] Line 211 of Utxo.lagda: ∑[←] is not defined.


complete config pkg tests

Codecov Report

Merging #1 (5d6b079) into master (cdbc3ce) will increase coverage by 50.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           master        #1       +/-   ##
============================================
+ Coverage   50.00%   100.00%   +50.00%
============================================
  Files           1         1
  Lines           8         8
============================================
+ Hits            4         8        +4
+ Misses          4         0        -4

Impacted Files
Coverage Δ

internal/pkg/config/config.go
100.00% <0.00%> (+50.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdbc3ce...5d6b079. Read the comment docs.


Add Modeling Interface Document

This PR adds a design document for the ClimaAtmos modeling interface, per Tapio's request. The document is still in its early stages, but I'll be adding to it over the next few weeks whenever I have time.

So far so good.


Fix #1186 Update SPDX license list to 3.18

Signed-off-by: Marc-Etienne Vargenau<EMAIL_ADDRESS>

Now 3.19 is out.


How to understand the calculation method of the kubernetes.io/batch-cpu value on a machine

What happened:
How to understand the calculation method of the kubernetes.io/batch-cpu value on a machine, and what are the sources of factors that affect the changes in the kubernetes.io/batch-cpu value?
I tried to read the source code, but I didn't understand (for example, adding some deployments without actual load increases the allocated CPU requests on the machine, but the kubernetes.io/batch-cpu does not increase).
batchAllocatable := nodeAllocatable * thresholdPercent - podUsage(HP  priority classes higher than Batch ) - systemUsage
https://github.com/koordinator-sh/koordinator/blob/main/pkg/slo-controller/noderesource/framework/README.md
Environment:

Koordinator version: - v1.4.1
Kubernetes version (use kubectl version): v1.28.2
docker version: cri-dockerd +  docker 19.03.14
OS (e.g: cat /etc/os-release): rhel7.9
Kernel (e.g. uname -a): Linux 4.19.9-1.el7.elrepo.x86_64 #1 SMP Thu Dec 13 10:52:03 EST 2018 x86_64 x86_64 x86_64 GNU/Linux

Anything else we need to know:

@KrWMdev Please refer to the Resource Model design doc: https://koordinator.sh/docs/architecture/resource-model


Tree history

I'm not sure whether this is a "can be addressed later" issue or a "should be considered in early designs" issue, hence this.
One of the distinctive features of advanced editors e.g. vim is the history tree, that is, recognising that undo/edit history is sometimes not linear and handling that natively. Atom doesn't do that, but perhaps XRay could? It can still be presented as linear by default.
This might also be a consideration with a multi-player editor, i.e. should each user have their own history, the global history, or some mixture of the two?
Anyway, is this something you've thought about or will be?

Hello @passcod and thanks for the feedback!
The core data structure powering xray is a CRDT where every fragment in the tree represents an insertion that some local or remote user has made in the past. By its very nature, this data structure allows to undo and redo the effect of any insertion, independently of when such insertion was made (i.e., the history can be non-linear). As a result, we can support a non-linear history in the local scenario as well as a per-user (or global, or a mix of both) history in the multi-user scenario.
So, to answer your question, I think architecturally this leaves the door open to support all kinds of cool history navigation. We haven't really sketched out what a coherent user experience for non-linear navigation would look like, but it's definitely something that we have thought about doing in the past. Considering that the data structure already supports such use cases by design, I wouldn't exclude that a more advanced non-linear history UX could also be provided by an extension as opposed to offering it by default in core.
Hope this helps!

Awesome, thanks for the explanation!


changing bold font in lux theme

Hello! I've been using the lux theme for my mkdocs site, however bold font isn't substantially different from standard text. I've been trying to find a way to edit my css/extra.css file to change this, but I haven't been able to figure out how to do this. Is there a way to adapt the lux theme this way?

+1

I don't think this is a GREAT solution, but if you can insert this CSS to override the default, it works. I'm using Quarto (not MKdocs), I think the problem is associated with using the "bolder" option for font weight. Changing it to "bold" makes normal bold font look better?
b,strong {font-weight: bold}

+1


Option to not install libdefs for devDependencies?

Most of the time I don't need libdefs for devDepdendencies. It would be nice if flow-typed install had an option to not install those.

Also, maybe you can consider adding a CLI command to add libdef only for one or multiple specified dependency/ies. For example: flow-type install redux-saga [...]. I want to introduce types gradually and adding 100+ libdefs at once most of which are stubs is something weird to me.
If the specified libdef is missing in flow-typed repo it could ask if the user wants to add stubs file.
What do you think?

What would be the preferred command?
I suppose the most common use case is that you want to install type defs for all dependencies and ignore all devDependencies. How about peerDependencies and bundledDependencies?
Maybe the command could be:
flow-type install --ignore-dev-dependencies


Normalized line endings to LF

Since I often modify the code on a Windows machine, some CR LF line endings are inserted by the IDE when I format the code automatically, which I then have to remove by doing a search and replace, otherwise the build will fail on GitHub (due to format checking).
Today, after doing the routine search and replace after making a change, two extra files were listed by Git. Of course I had to undo the changes on those files since they are unrelated to what I was changing. But removing it every time could get tedious, so let's fix the issue while it's only a couple of files.

You can configure git to automatically convert line endings for you, but if there's a strong preference for Pinta to use LF exclusively, it could be forced via .gitattributes. (https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings#per-repository-settings)

Thanks for the configuration tip @MrCarroll. In this case the CR LF line endings are not my own, but they are on the code that I downloaded from GitHub. The line endings have always been exclusively LF until these two files were created, so I'm assuming that that's what's preferred.
I may implement your tip on a future pull request. For now I think this is the best thing to do.

Yeah I think these were unintentional - I'd be okay with always forcing LF endings to avoid needing whitespace-related fixes like this

If you do, you could get rid of Pinta/tests/Pinta.Core.Tests/Assets
/sixcolorsoutput_crlf.ppm and get the *.ppm export to be always written with LF line endings. I haven't taken the time to look at how it's done so I added versions with both line ending conventions, but it needn't be that way.


.gh user <github_username> returning multiple instances of result

Description
Whenever we give the command .gh user < github_user_name >  double instances of the same user profile are returned
Expected Behaviour
The stats about the Github username mentioned should be returned only once, whenever we type .gh user <github_user_name> two instances are being returned.
Actual Behaviour
On writing the above specified command, only one instance should be returned.

This doesn't seem to be the case in production.
Are you sure you don't have 2 instances of your bot process running?

I guess I did both, Run with Docker and Run on the Host.

I'll close this then. Thanks!


Update project

Whole project overhaul

[X] Update Gradle plugin and build tools to the latest (now compatible with latest Android Studio 0.8.2)
[X] Update all dependencies to the latest version
[X] Standard formatting for code and resources
[X] Add missing Gradle/project/template files
[X] Fix all Lint errors
[X] Update README.md

This repository is now deprecated, closing all issues.  See README.md for more information.


Add license agreement configurations

Due to the new licensing, the configuration should include license agreements for the collector and enricher, e.g. https://docs.snowplow.io/docs/pipeline-components-and-applications/stream-collector/configure/#license

Hi Dumky, just catching up on this dastardly "accept license" change. I deployed snowplow-serverless last october on our (very) low traffic website as a way to connect marketing leads to GA campaigns. It worked great for a few months but hasn't worked since February due to the newer snowplow images requiring the additional config parameter.
I've just logged into GCP console and manually added an env var to the YAML configurations of each job.
I suspect I've lost the data between then and now.
Thanks for making this, it's really great. When I get time I might try and make a fork to use Open Snowcat.
Cheers,
Rich


ServiceBus async AutoLockRenewer crashes on disposal if no messages have been registered

Package Name: azure-servicebus
Package Version: 7.3.0
Operating System: Mac OSx
Python Version: 3.8.7

Describe the bug
I am using the async version of AutoLockRenewer. I have noticed that if I create it but I do not register a message (either directly or via a receiver), then I get an exception when it is disposed.
To Reproduce
Steps to reproduce the behavior: see the following code

import os
import asyncio
from distutils.util import strtobool
from azure.servicebus.aio import ServiceBusClient, AutoLockRenewer

CONNECTION_STR = os.environ['SERVICE_BUS_CONNECTION_STR']
QUEUE_NAME = os.environ["SERVICE_BUS_QUEUE_NAME"]

async def code_failing():

    servicebus_client = ServiceBusClient.from_connection_string(conn_str=CONNECTION_STR)

    async with servicebus_client:

        print('context, register via receiver')
        try:
            async with AutoLockRenewer(max_lock_renewal_duration=20*60) as renewer:

                async with servicebus_client.get_queue_receiver(queue_name=QUEUE_NAME, auto_lock_renewer=renewer) as receiver:
                    _ = await receiver.receive_messages(max_message_count=10, max_wait_time=5)
        except Exception as e:
            print(e)

        print('context, register explicitly')
        try:
            async with AutoLockRenewer(max_lock_renewal_duration=20*60) as renewer:

                async with servicebus_client.get_queue_receiver(queue_name=QUEUE_NAME, ) as receiver:
                    _ = await receiver.receive_messages(max_message_count=10, max_wait_time=5)
        except Exception as e:
            print(e)

        print('no context, register via receiver')
        try:
            renewer = AutoLockRenewer(max_lock_renewal_duration=20*60)

            async with servicebus_client.get_queue_receiver(queue_name=QUEUE_NAME, auto_lock_renewer=renewer) as receiver:
                _ = await receiver.receive_messages(max_message_count=10, max_wait_time=5)

            await renewer.close()
        except Exception as e:
            print(e)

        print('no context, register explicitly')
        try:
            renewer = AutoLockRenewer(max_lock_renewal_duration=20*60)

            async with servicebus_client.get_queue_receiver(queue_name=QUEUE_NAME) as receiver:
                _ = await receiver.receive_messages(max_message_count=10, max_wait_time=5)

            await renewer.close()
        except Exception as e:
            print(e)

if __name__ == '__main__':

    asyncio.run(code_failing())

Expected behavior
The object should be cleanly disposed. Instead I get:
10:57 $ env $(grep -v '^#' env  | xargs -0)  python3 autolock-bug.py
context, register via receiver
Set of coroutines/Futures is empty.
context, register explicitly
Set of coroutines/Futures is empty.
no context, register via receiver
Set of coroutines/Futures is empty.
no context, register explicitly
Set of coroutines/Futures is empty.

each exception is like:
Traceback (most recent call last):
  File "autolock-bug.py", line 32, in <module>
    asyncio.run(code_failing())
  File "/Users/aca286/.pyenv/versions/3.8.7/lib/python3.8/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/Users/aca286/.pyenv/versions/3.8.7/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
    return future.result()
  File "autolock-bug.py", line 28, in code_failing
    await renewer.close()
  File "/Users/aca286/.local/lib/python3.8/site-packages/azure/servicebus/aio/_async_auto_lock_renewer.py", line 236, in close
    await asyncio.wait(self._futures)
  File "/Users/aca286/.pyenv/versions/3.8.7/lib/python3.8/asyncio/tasks.py", line 413, in wait
    raise ValueError('Set of coroutines/Futures is empty.')
ValueError: Set of coroutines/Futures is empty.

Thanks for the feedback, we'll investigate and report back.

hey @andrea-cassioli-maersk , thanks for the report!
confirming the issue and the root cause if that when shutting down the async AutoLockRenwer via await asyncio.wait(self._futures), we don't check whether self._futures is empty leading to the error.
sorry about the trouble made to you! have a PR out to fix it: https://github.com/Azure/azure-sdk-for-python/pull/19722 which should be included in our next release.

Hey @yunhaoling , thanks for the quick feedback and fix!

@andrea-cassioli-maersk , we have fixed the issue in the release 7.3.2, sorry for keeping you waiting.


Bug when using devise and strip_attributes

strip_attributes (https://github.com/rmm5t/strip_attributes) defines a class_method "strip_attributes" for ActiveRecord::Base.
When I load devise before strip_attributes in the Gemfile, the method "strip_attributes" gets undefined, and I get the appropriate errors:
````Exception encountered: #<NameError: undefined local variable or method `strip_attributes' for #Class:0x00000006c68fa8>
......

Thanks for the report. Could you please read https://github.com/plataformatec/devise/wiki/Bug-reports and provide more information? An app that reproduces the error would also be super!

Closed by lack of information.


#1777: Replace Goerli with Sepolia in the TestChainId test

This PR is fixing the issue #1777, replacing the deprecated network Goerli with the Sepolia network.

@kirugan, could you review this please?


Improve config updating

I would like to be able to update config files for new versions without having to rename and generate the file. Ideally editing the existing config with new values.
I might want to use this project and then manually update the config version to match the latest such that it only runs when the config version changes.
https://github.com/tchristofferson/Config-Updater

Tested, seems to be working
I want to do a little more checking to make sure that the config is the same after this code is run, apart from the new values


Allow describe and require calls to precede the definition of AMD.ts in a generated bundle

The TypeScript compiler has his own rules in determining the order of inclusion of a set of source files. Trying to force a specific order is hard and counterproductive.
Calls to define and require should be allowed also before the definition of AMD.ts appears in the output of a bundle, likely using top-level functions being hoisted in the global scope.

Fixed in b642d14


WIP - Migrate listener package

Proposed changes:
Added listener package and implemented units tests.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Strange Failure On Exercise 054

I recently updated my zig version to 0.11.0-dev.1540+304420b99
When going back to work on Ziglings, I'm getting a failure on an exercise that passed previously.
Here's the code for the exercise.
const std = @import("std");

pub fn main() void {
    const zen12: *const [21]u8 = "Memory is a resource.";
    const zen_manyptr: [*]const u8 = zen12;
    const zen12_string: []const u8 = zen_manyptr[0..22];
    std.debug.print("{s}", .{zen12_string});
}

And here's the error.
Compiling 054_manypointers.zig...
Checking 054_manypointers.zig...

----------- Expected this output -----------
"Memory is a resource."
----------- but found -----------
"Memory is a resource."
-----------

Edit exercises/054_manypointers.zig and run this again.
To continue from this zigling, use this command:
    zig build 54

your slice range is slightly off [0..22]. Think about how many values that will be. I also made the same mistake :)

But the output is wrong. It is not possible to see what the error is. This goes along with another supposed improvement, and I will correct that. Thank you, therefore, for bringing it to our attention.

I just ran into this same error and after playing around I think I understand what's happening ... but I'm not sure.
The syntax for creating slices a[x..y] is supposed to return a slice where the elements are those at position x all the way up to y-1.
In this case, I would expect 0..22 to result in a slice consisting of elements at indexes 0 through 21 (where the element at position 21 is the period) -- so, the expected string.
The only thing that I can think of is that using the slice syntax on a many-item pointer behaves like the ... range syntax instead (i.e., it's inclusive of the end), and so it is returning the null byte at the end of the string?

that using the slice syntax on a many-item pointer behaves like the ... range syntax instead ...

Do you mean something like a[0..]?

and so it is returning the null byte at the end of the string?

But Zig generally has no null byte at the end of a string. Because the length is already enough.

I edited my above comment, I take back what I said about the range syntax. As it turns out, the problem existed between the keyboard and the chair...not sure where I got a length of 22 from.
Anyways:

But Zig generally has no null byte at the end of a string. Because the length is already enough.

This is counter to what I'm led to believe in 077_sentinels2.zig, namely:
//
// Are you ready for the THE TRUTH about Zig string literals?
//
// Here it is:
//
//     @TypeOf("foo") == *const [3:0]u8
//
// Which means a string literal is a "constant pointer to a
// zero-terminated (null-terminated) fixed-size array of u8".
//
// Now you know. You've earned it. Welcome to the secret club!

So, what I was thinking originally by mentioning the null byte is that somehow the it was getting returned as part of the output (which would make sense given how the error seems to be saying that, for the expected output x, x != x).
Here's an example I put together:

Example Code
const std = @import("std");

pub fn main() void {
    // string literal
    const zen12: *const [21]u8 = "Memory is a resource.";
    // turn it into a many-item pointer
    const zen_manyptr: [*]const u8 = zen12;

    std.debug.print("\nx = 0, y = 4\n", .{});
    std.debug.print("expected: Memo\n", .{});
    std.debug.print("actual: {s}\n\n", .{zen_manyptr[0..4]});

    std.debug.print("x = 0, y = 15\n", .{});
    std.debug.print("expected: Memory is a res\n", .{});
    std.debug.print("actual: {s}\n\n", .{zen_manyptr[0..15]});

    std.debug.print("x = 0, y = 20\n", .{});
    std.debug.print("expected: Memory is a resource\n", .{});
    std.debug.print("actual: {s}\n\n", .{zen_manyptr[0..20]});

    std.debug.print("x = 0, y = 21\n", .{});
    std.debug.print("expected: Memory is a resource.\n", .{});
    std.debug.print("actual: {s}\n\n", .{zen_manyptr[0..21]});

    std.debug.print("x = 0, y = 22\n", .{});
    std.debug.print("expected: Memory is a resource.<???>\n", .{});
    // actual is the "same" as above from the perspective of the user reading the terminal
    // I _think_ this is because it's including the null byte.
    std.debug.print("actual: {s}\n\n", .{zen_manyptr[0..22]});

    std.debug.print("x = 0, y = 23\n", .{});
    // I would expect garbage to start getting printed now
    std.debug.print("expected: Memory is a resource.<???>\n", .{});
    std.debug.print("actual: {s}\n\n", .{zen_manyptr[0..23]});
}

In any case, I think the crux of the issue is that when the user is silly like me, puts a number off by 1, and gets an error like this:
========= expected this output: ==========
Memory is a resource.
========= but found: =====================
Memory is a resource.
==========================================

Edit exercises/054_manypointers.zig and run 'zig build -Dn=54' again.

there isn't a ton of information to go off of to try to figure out what they actually did wrong. The only reason why I thought about the possibility of a null byte is because I've gone through ziglings in the past and remembered that little tidbit about string literals...and if this isn't what's going on, I'd really like to understand what is (and maybe help come up with a more helpful error)

From https://ziglang.org/documentation/master/#String-Literals-and-Unicode-Code-Point-Literals:
"String literals are constant single-item Pointers to null-terminated byte arrays".
To use a more general term, they are sentinel terminated pointers.
This means that accessing the element after the last is valid; and it is valid even in case when a string literal is casted to a normal slice.
As for the output check, I agree that is not very useful in same rare cases.
I plan to improve it by showing invisible characters (like NUL) and trailing whitespace.


feature(example): added example for sql_server db via pyodbc

Closes https://fivetran.height.app/T-796807 https://fivetran.height.app/T-843774

Getting some error

please follow https://learn.microsoft.com/en-us/sql/connect/odbc/linux-mac/install-microsoft-odbc-driver-sql-server-macos?view=sql-server-ver16#microsoft-odbc-18 to install key files on your macOS

Understood. Please address other comments please


Add Python 3.8 compatibility

Resolves #403
WIP

[x] Add Python 3.8 builds to Travis tests.
[ ] Resolve fails that arrise.

Ah yes, now I remember why I didn't include Python 3.8 compatibility last time,

Tensorflow 1.13.x isn't compatible with it.
We'll need to upgrade to at least Tensorflow 2.2, see https://www.tensorflow.org/install/pip
However if I recall correctly, moving to Tensorflow 2.x is incompatible with the API of our current Keras version, and upgrading that is going to be complicated if I recall our last conversation with @vs74 about this correctly from last year.
All this to say, @mariehbourget I think this PR might take a while and we'll need to completely retrain all our models again after it's complete.

We'll also need to stop using bireli, as moving up Tensorflow versions means we'll need too change CUDA version too

p.s. big picture-wise, is it even worth it spending a few days/weeks on upgrading to Tensorflow 2.2 and the accompanying  new Keras API if we're not going to be using any of it when moving to IVADOMED, since it uses PyTorch and not Tensorflow? Maybe we should just deal with the Python 3.8 upgrade whenever we're ready to get rid of Tensorflow and move to IVADOMED? @jcohenadad thoughts?

p.s. big picture-wise, is it even worth it spending a few days/weeks on upgrading to Tensorflow 2.2 and the accompanying new Keras API if we're not going to be using any of it when moving to IVADOMED, since it uses PyTorch and not Tensorflow? Maybe we should just deal with the Python 3.8 upgrade whenever we're ready to get rid of Tensorflow and move to IVADOMED? @jcohenadad thoughts?

agreed, not worth it

Ok great, I'll close this PR now and we'll handle it when making the move to IVADOMED.


After password is accepted, wallet stays on password screen

Looks like a routing issue. Menu shows as logged in, but I have to close and open the extension for the wallet to load my address page properly.
I saw this twice, then when trying to reproduce and make a video it doesn't show the same issue.

I'm seeing the same issue. I managed to record a video of it:
https://user-images.githubusercontent.com/4306391/222746293-41341efb-da6d-4dd4-b6a3-2f85465eb1cd.mp4
And here is the console output:

As you can see, the complete_unlock event is logged each time the password is entered, and if I open the wallet in a new tab it is unlocked, but the initial tab never shows anything but the password prompt


How to enable the nfs security with NFS client provisioner plugin

Hi Team,
We have configured one-premise k8s cluster and enabled NFS client provisioner plugin for dynamic PVC provisioning with NFS.
We need to enable NFS security as well. so that only k8s applications will able to use that NFS share. Please suggest/help on this.

Hi, @balajir24 - we're not able to answer this question here; I suggest trying https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner.


systemd-logind problem?

I'm getting the following on staging (/var/log/Xorg.0.log):
(EE) systemd-logind: failed to get session: PID 13553 does not belong to any known session

Any ideas if it's even a problem? @edolstra?

@rushmorem @vcunat is this still happening?

I can still see the message on ~week old staging (around d35352142).

@domenkozar I'm still getting this error message in my logs. When starting up my laptop, if I try to log in right after the kdm login prompt appears, the login fails. Everytime I have to try twice. I always log in successfully on the second try. However if I wait a bit (say a minute or two) before trying to login, I can do so on first attempt. I'm using kdm as my display manager and i3 as my window manager on nixos-unstable.
My guess is some systemd services are not starting up in the correct order. I haven't tried digging into this though, so I could be wrong.

Is this still current?

I'm still getting the message on recent 15.09, but it seems not to cause any problems.

I still see it in my logs as well but ever since I moved from NetworkManager to just wpa_supplicant and wvdial I can login on first attempt. Also it takes much less time to get to a usable state after entering login details.

As @vcunat noticed, patch https://github.com/NixOS/nixpkgs/commit/b292e19fbddaddd4ada813965e3be3880f15fa7e seems to have fixed this problem for me. If someone still has this problem, please try it out.

Closing this as it seems to be fixed, please reopen if you still experience this bug.


AAAAAAAAAAAAAA

Template
Please write your blade template that occurs issues.
Context (Environment)

write your environment

Description

Any other informations

Closed by #372


Conflict with spatie/laravel-medialibrary

Larastan Version: 2.0.0
--level used: 5
Pull request with failing test:
OS: Windows 10

Description
When I install spatie/laravel-medialibrary v10, I've an error when I execute larastan. This error can be checked on this repository.
composer require "spatie/laravel-medialibrary:^10.0.0"

Laravel code where the issue was found
./vendor/bin/phpstan analyse

Note: Using configuration file C:\workspace\projets\laravel-app\phpstan.neon.
This file is included multiple times:
- C:\workspace\projets\laravel-app\vendor\nunomaduro\larastan\extension.neon

It can lead to unexpected results. If you're using phpstan/extension-installer, make sure you have removed corresponding neon files from your project config file.

Larastan works when I remove laravel-media-library.

Hi,
They require phpstan/extension-installer in their composer.json Which is a tool that automatically registers an PHPStan extensions.
So please open an issue there. They should remove that from their composer.json

Thanks!

Fixed in laravel-medialibrary 10.0.4.


[17.12] daemon.cleanupContainer: nullify container RWLayer upon release

back port of https://github.com/moby/moby/pull/36160 and https://github.com/moby/moby/pull/36242 for 17.12
git checkout -b 17.12-backport-layer-not-retained upstream/17.12
git cherry-pick -s -S -x -Xsubtree=components/engine e9b9e4ace294230c6b8eb010eda564a2541c4564
git cherry-pick -s -S -x -Xsubtree=components/engine 195893d38160c0893e326b8674e05ef6714aeaa4

Conflict in second commit due to https://github.com/moby/moby/commit/87a12421a94faac294079bebc97c8abb4180dde5 (https://github.com/moby/moby/pull/35638) not being included in 17.12;
diff --cc components/engine/daemon/inspect.go
index 20cfa6ce2b,164e1aa2ae..0000000000
--- a/components/engine/daemon/inspect.go
+++ b/components/engine/daemon/inspect.go
@@@ -1,6 -1,7 +1,7 @@@
 -package daemon // import "github.com/docker/docker/daemon"
 +package daemon

  import (
+       "errors"
        "fmt"
        "time"

@@@ -187,10 -196,13 +195,18 @@@ func (daemon *Daemon) getInspectData(co
        // If container is marked as Dead, the container's graphdriver metadata
        // could have been removed, it will cause error if we try to get the metadata,
        // we can ignore the error if the container is dead.
++<<<<<<< HEAD
 +      if err != nil && !container.Dead {
 +              return nil, systemError{err}
++=======
+       if err != nil {
+               if !container.Dead {
+                       return nil, errdefs.System(err)
+               }
+       } else {
+               contJSONBase.GraphDriver.Data = graphDriverData
++>>>>>>> 195893d381... c.RWLayer: check for nil before use
        }
-       contJSONBase.GraphDriver.Data = graphDriverData

        return contJSONBase, nil
  }

ping @kolyshkin PTAL

need to have a look at this
15:13:14 daemon/inspect.go:191:26: cannot convert "errors".New("RWLayer of container " + container.ID + " is unexpectedly nil") (type error) to type systemError: need type assertion
15:13:14 daemon/inspect.go:200:27: cannot convert err (type error) to type systemError: need type assertion

From the first glance, systemErr{err} rather than systemErr(err) should be used for this version. Here's systemErr definition:
type systemError struct {
        cause error
}

Closed in favour of #433


Add support for sourcehut

sourcehut is a GitHub-like VCS service that I use a lot. dpu is a great command, so I wanted to make a modification to support sourcehut.
However, I did not add any tests because the unit tests did not work nearly as well locally. Is this currently being fixed? or is it broken just in my environment? Sorry, I see that everything is going through in CI. So is it because of my environment or...

#11
After the above PR are merged, I want to add a test, so I will draft it once.

@nishidayuya I have added some more tests for sourcehut, I will open a PR and would appreciate your review.

Thank you for your contribution! I released dpu-0.4.0 :tada:


useWaitForTransactionReceipt doesn't throw error when transaction reverts

Describe the bug
When a transaction reverts due to an out of gas failure, useWaitForTransactionReceipt doesn't return an error, and the loading variable stays true. FailureReason and failureCount are set, but error should also be set and isLoading should be set to false too.
Link to Minimal Reproducible Example
https://stackblitz.com/edit/new-wagmi-nwxapp?file=src%2FApp.tsx
Steps to reproduce:
-connect your wallet on sepolia
-click send approve tx button
-manually edit the gas limit in your wallet to 26000
No response
Steps To Reproduce
-use goerli (I've reproduced on both goerli and on a tenderly fork of mainnet so far)
-manually set gas limit to be too low on a transaction
-check values returned by useWaitForTransactionReceipt
Wagmi Version
2.5.7
Viem Version
2.7.15
TypeScript Version
5.2.2
Check existing issues

[X] I checked there isn't already an issue for the bug I encountered.

Anything else?
No response

Could u provide a Minimal Reproducible?

@1997roylee I updated my issue with a Minimal Reproducible link and instructions. I'm seeing slightly different behavior in the Minimal Reproducible than in my app. The error does eventually get set in this example, but it happens several seconds after the failureReason gets set. Ideally there wouldn't be this long delay, and the error would be set and isLoading set to false as soon as there's a failureReason, unless I'm missing something.

@Yuripetusko Makes sense! I understand retrying if the request to the node fails, but in this case where the request succeeds with a tx reverted error, there's no need to retry imo, maybe that's something wagmi can account for. Anyways, thanks for the advice on how I can handle it on my end.

@Yuripetusko Makes sense! I understand retrying if the request to the node fails, but in this case where the request succeeds with a tx reverted error, there's no need to retry imo, maybe that's something wagmi can account for. Anyways, thanks for the advice on how I can handle it on my end.

it's a default tanstack query behaviour. When useQuery hook queryFn throws an error, it auto retries silently (so it doesn't actually report thrown error but swallows it and retires)


(docs) Improve documentation about local dependencies pre-bundling

Clear and concise description of the problem
Hello,
Currently looking for a replacement of my current CRA setup, I read the vite documentation and was interested about the dependency resolution as it is a recurring issue in some of my projects.
Vite looks really promising in my cases but the note about linked dependencies is a but confusing and is not helping me much in understanding any possible issues and solutions.

https://vitejs.dev/guide/dep-pre-bundling.html#monorepos-and-linked-dependencies
Suggested solution
Could you elaborate more this part ?
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

For one, it should be npm pack not npm package, and the generated tar file should be installed instead. We could definitely further elaborate that part. I'll see if I can get to it soon, or feel free for others to grab this as well.

Hi @bluwy,
Thanks for your reply. Using npm pack seems incompatible with the feature (which caught my interest) of being able to compile linked source code. What is the best way to achieve this using vite ?

You should be able to run vite build with the linked source code that's using npm pack. I'm not quite sure what you mean otherwise. But for extra clarification, npm pack is only ever needed when the linked source code or package only exports CJS code. If it exports ESM code, then npm pack is not needed.


Add __enter__ and __exit__ method to the stream player and the stream recorder to use them as context manager.

Add method to turn stream player and stream recorder instance into possible context manager.
Remove testing utility function to create a stream and replace it directly with a call to a stream player.

Not worth it for now. The current behavior is good enough and the context manager might introduce new problems.


Update/feature subsetting

This PR is updated to new plugin standards

Versions do not match across files (VERSION, Readme, etc.)

I fixed it and add CLT and ict.yaml file for this plugin


Open API/Swagger archive sample

Description:

The master swagger file name in archive sample has to be renamed as 'swagger.json/yaml' instead of 'Swagger.json/yaml'[1]
A sample should be attached, so users can easily understand the expected format of the archive. Sample archive can be found here
dir.zip
Should add a note to archive the swagger files without having hidden folders like __MACOSX

[1] https://apim.docs.wso2.com/en/latest/design/create-api/create-rest-api/create-a-rest-api-from-an-openapi-definition/

@tgtshanika , please let us know if this change is applicable to APIM 4.0.0 as well.


createNew function

hi
while creating new item, I want to see added empty-data row at the top of table instead of buttom of it.
Is there any config setting to do this or  should I change source code. If source code should be changed, How can I change?

Hi @fatihkurnaz,
Sure, if you check readme.md you can see that when you create the TableDataSource you can set the 4th argument (config) to have the property prependNewElements with true value, which is false by default.
With the prependNewElements as true, new elements get inserted on top.
If you have any other doubt please reach me out.

Thank you it worked :+1:  Another doubt is paginator. I tried to insert paginator property for high-volume content. Do you have suggestion on this issue

I'm not getting the point here.
You just have to use (for example) angular paginator, and fill it with appropriate values and correct function to be called on page change event.

thank you again :)


runtime: test frequently times out after 10 minutes on linux-amd64-longtest builder

For example: https://build.golang.org/log/9b5c6ae2c5be87e49c9893e9ea6dcc2aa6198200
The builder has been consistently broken for this and other reasons since mid-May, so it's hard to pinpoint when this failure started happening. I tried looking for an existing issue about this, but couldn't find any.
If I run go test -v runtime on my laptop, I get the result:
ok      runtime 171.977s

Perhaps the three-minute timeout per package is too low for the runtime package, seeing as how my run barely fit under 180s. Or perhaps some of the long or expensive tests should be made faster.
/cc @aclements @ianlancetaylor @bradfitz
Tangential question - should this be labelled Testing or Builders? Perhaps the label descriptions could be clarified.

I bumped the timeout to 6 minutes in CL 115016.
Either I did it wrong or it's not deployed yet.

p.s. I thinks this should be labeled "builders".

Ah, I forgot to remove the is:open filter from my issue search. It didn't occur to me that the issue was already closed. I naively assumed that it couldn't have been, since the problem is still present :)
Then yes, this seems like it should be labelled Builders. Do you want to keep this issue open to track the deployment/debugging of your fix?

We're closer - now it only fails most of the time. When it does fail, it seems like the usual culprit is:
##### GOMAXPROCS=2 runtime -cpu=1,2,4 -quick
panic: test timed out after 10m0s

Runtime folks (@aclements @rsc @RLH @randall77): can we make it a priority to get the runtime long-test time under 10 minutes under load? The flakes in the longtest builder can easily mask more serious errors.
More examples (three in a row!):
https://build.golang.org/log/56f132e989f66fa5d09b52a61ee62a1e9a574d21
https://build.golang.org/log/9ddb78a19b4ad99475f218c79d1e1a41546a25cb
https://build.golang.org/log/a4253a3cc05bd87ced2958a9c68715743d5212e4

By "long test" do you mean just "go test"? Historically there has not been a requirement that the non-short tests complete in any particular time, and I'm kind of disappointed to see this requirement imposed.
But even ignoring that, 'go test runtime' runs in 1.5 minutes on my laptop. If the builders are 6X slower than my laptop, let's focus on that problem.

It looks like go test runtime usually takes about 200s on the builders, which is a little slow, but not ridiculous. The failure is usually "GOMAXPROCS=2 runtime -cpu=1,2,4 -quick".
That header says "-quick" (I forget how that's different from -short). How does the longtest builder affect that test?

By "long test" do you mean just "go test"? Historically there has not been a requirement that the non-short tests complete in any particular time, and I'm kind of disappointed to see this requirement imposed.

It's not the build system imposing it. It's cmd/go:
        -timeout d
            If a test binary runs longer than duration d, panic.
            If d is 0, the timeout is disabled.
            The default is 10 minutes (10m).

We can have the coordinator explicitly set it much higher if you'd like.

Actually, that's not quite accurate. While cmd/go's default is 10 minutes, cmd/dist test still sets a limit, adjusted by GO_TEST_TIMEOUT_SCALE. Instead I sent https://go-review.googlesource.com/c/build/+/167638 to just crank up the longtest's timeout scale.

I wrote that paragraph before I checked how long the runtime test actually took.
If the non-short tests run in a couple minutes for each package then I don't mind
having a builder that depends on that staying true (which is what I meant by
adding a requirement).
The real problem seems to be that the "longtest" builder machines are
underprovisioned/oversubscribed. If we are going to run the "long" tests,
which are by definition a bit CPU-intensive, it's not really fair to run them
on a CPU-starved machine that effectively runs at 1/6 the speed of my laptop.
Increasing the timeout doesn't seem like it addresses the real problem here.

The real problem seems to be that the "longtest" builder machines are
underprovisioned/oversubscribed.
...
it's not really fair to run them
on a CPU-starved machine that effectively runs at 1/6 the speed of my laptop.

It's using the default GCE VM type we use for all other container-based builds: n1-standard-4, 4 vCPUs (Haswell), 15 GB of RAM. That's not much worse than your laptop, is it? We could crank it up, though.
The VM is single-use & unshared by other tests. We stopped using Kubernetes a long time ago specifically because of people (often rightfully) blaming Kubernetes' isolation quality for flaky tests.

The -cpu=1,2,4 test takes a fair bit longer. On my workstation:
ok      runtime 422.956s
ok      runtime 422.739s
ok      runtime 420.853s
ok      runtime 419.106s
ok      runtime 421.480s
ok      runtime 417.887s
ok      runtime 421.122s
ok      runtime 418.034s
ok      runtime 416.562s
ok      runtime 417.979s
ok      runtime 415.275s
It doesn't surprise me that this goes over the 10 minute mark on a slower machine.

If the problem is the combined time for -cpu=1,2,4, should we split that dist test up into individual tests for each cpu value so that they can be run in parallel?

Well, we don't run the longtest builder sharded. It's not a trybot so we don't particularly care about latency. We also bound it to 1 builder per commit at a time, which means it can fill in the dashboard slowly, but that's fine.

It's still timing out at 10 minutes. Has the dashboard change been deployed?

@aclements, no, not yet. Every time I've went to do it people were using gomote and just starting trybots.
Btw, you can check this yourself at https://farmer.golang.org/ where it says at the top:

1379 total builds; 84 active. Uptime 46h57m1s. Version 1292b0303e050cc39ea0a4896f87994480a26ca8-bradfitz-2019-03-13T20:20:47Z.

I'll do it now.

The longtest builder appears to be happy now. Shall we close this?

Closing.


task is run although uptodate returns True

Hi,
I have a program that produces a output file. I already ran that program outside of doit. I wrote a dodo file for that task (which is computationally costly).
I want doit not to re-run that task. So I added the outputfile in targets and for uptodate I wrote a function::
  def exists(task, values):
    return all([os.path.exists(file) for file in task.targets])

If I add a print I can see that that function returns True. But doit runs the task nevertheless. Is this because the task is not in the database yet? How can I avoid execution? Do I have to modify the database?
Cheers,
Johannes

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/25455770-task-is-run-although-uptodate-returns-true?utm_campaign=plugin&utm_content=tracker%2F1885485&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1885485&utm_medium=issues&utm_source=github).

i think I solved it, by inserting a return 'up-to-date' in Dependency.get_status.
http://pydoit.org/dependencies.html#doit-up-to-date-definition has a very specific up-to-date definition. Perhaps it would be worthwhile to move the MD5 checks (and all others that rely on an existing database) into an uptodate function. Otherwise it is not prossible to override this behaviour.
In my case, I just want to check if the output file exists, but with the current implementation even run_once requires a doit run and will not understand that a file was downloaded (in the run_once example) already.

Issue #80 appears related.


SubredditHelper.call() got an unexpected keyword argument 'other_subreddits'

Describe the Bug
Encountered this error when attempting to subscribe to multiple subreddits at once:

TypeError("SubredditHelper.call() got an unexpected keyword argument 'other_subreddits'")

The docs mention that the other_subreddits parameter is accepted.
The Reddit docs also mention that the same parameter (called sr / sr_name on their end) is still accepted.
However, praw/models/reddit/subreddit.py and the error message above seem to indicate this has been deprecated within PRAW:
    @_deprecate_args("other_subreddits")
    def subscribe(self, *, other_subreddits: list[praw.models.Subreddit] | None = None):
        """Subscribe to the subreddit.

        :param other_subreddits: When provided, also subscribe to the provided list of
            subreddits.

        For example, to subscribe to r/test:

        .. code-block:: python

            reddit.subreddit("test").subscribe()

        """
        data = {
            "action": "sub",
            "skip_inital_defaults": True,
            "sr_name": self._subreddit_list(
                other_subreddits=other_subreddits, subreddit=self
            ),
        }
        self._reddit.post(API_PATH["subscribe"], data=data)

Desired Result

Determine whether or not I'm doing something wrong.
If not, determine whether this parameter has been deprecated within PRAW, and possibly have it added back since the Reddit API still seems to support it (unless it's been deprecated on their end but the docs don't reflect it yet).

Code to reproduce the bug
# Works
reddit.subreddit('pics').subscribe()

# Doesn't work
reddit.subreddit('pics', other_subreddits = ['funny', 'aww']).subscribe()

My code does not include sensitive credentials

[X] Yes, I have removed sensitive credentials from my code.

Relevant Logs
TypeError("SubredditHelper.__call__() got an unexpected keyword argument 'other_subreddits'")

This code has previously worked as intended
I'm not sure, I haven't used this code before.
Operating System/Environment
Windows 10
Python Version
3.12.0
PRAW Version
7.7.1
Links, references, and/or additional comments?
No response

However, praw/models/reddit/subreddit.py and the error message above seem to indicate this has been deprecated within PRAW:

The positional usage of other_subreddits in .subscribe() is deprecated not the parameter itself.
The .subscribe() method you're referencing is where you need to pass in other_subreddits=["funny", "aww"] like so:
reddit.subreddit('pics').subscribe(other_subreddits=["funny", "aww"])

Oh, duh! Thanks. Completely blanked on the fact that the parameter was listed for subscribe() and not subreddit().


Memory fixes for bibentry predictor.

Limits vram utilization by batching number
of bibentries that are passed to model at one
time (previously unbounded).
Context: our TIMO endpoint is running out of
GPU memory very quickly with production traffic
pointed at it. It is normal for these models to increase
vram usage to some plateau while they are warming
up, but the degree to which this was happening was
excessive.
I pulled a paper with >100 references
and ran it against a couple ad hoc endpoints. One
without bibentry batching, and one with the default
batching implemented here (n=5). Each had a single
worker. The latter showed far lower vram and gpu core utilization,
and had inference times twice as fast to boot. Moreover,
the unbatched instance's vram plateaued at ~60% with
just a single gunicorn worker, explaining why prod is having
major issues with 2 workers.
No batching:

With batching:

Cool! did you do adhoc endpoints with timo-tools? I haven't tried that yet... the invocation stats go to datadog??
I would guess in timo config you'll set the batch limit higher, do you think that will be a guessing game or is the adhoc deployment similar enough to real deployment that maybe (i'm guessing) 10 or 15 per batch is better?


Add documentation about the functional algorithms

BEGINRELEASENOTES

Add documentation about the functional algorithms in Gaudi

ENDRELEASENOTES

The documentation is not fully complete; there are other topics like histogramming that I should add at some point but I think for now this is a decent reference

Yeah, I think this is in a decent shape and we can add more things later.


avoid overfitting?

It might be useful to have at least 2 or more examples and platforms to start modeling in order to avoid unintentional overfitting :-)
Here would be a few examples from the Early Evidence Base pilot:

https://eeb.embo.org/doi/10.1101/2<IP_ADDRESS>1630
https://eeb.embo.org/doi/10.1101/2<IP_ADDRESS>968
https://eeb.embo.org/doi/10.1101/2<IP_ADDRESS>54882

Some of these examples illustrate the sequential involvement of 2 reviewing services. This could be interesting for the initial model. The display is also different, emphasizing more on the concept of a whole peer-review process and perhaps less oriented on sequential 'events'. Finally, some are from author-driven submission systems while the last is from an author-independent platform.

We currently have 5 examples going in the examples/ directory, including some that disagree on exact usage. While we should always keep an eye on issues of overfitting to our samples and get stakeholders directly involved in getting their needs met.


Update Composer dependencies (2023-12-14-00-17)

Visual regression test passed!
View the visual regression test report


Do we need a "Done" pipeline?

As specified in the contribution guidelines, the Done pipeline is intended for "issues that are done and approved in the sprint review."
I personally think this is unnecessary and potentially confusing:

Usually, issues that are "done" are closed and automatically moved to the Closed pipeline, which stores all closed issues or pull requests. In order to have these issues in the Done pipeline instead, they would need to stay open until the end of every sprint.
This would also mean though, that PRs would either have to be closed at the end of each sprint (which is not ideal) or automatically moved to the Closed pipeline when they are done. This would mean that done issues connected with PRs would end up in the Closed pipeline and other issues would stay open in the Done pipeline.

Labelling the issues with their corresponding sprint milestones allows us to look at all open and closed issues when viewing said milestone. These closed issues would be the same that should be stored in the Done pipeline which makes that pipeline redundant.

So I propose the removal of the "Done" pipeline.

The pipeline was deleted.


Scoped S3 Credentials

Overview
Builds on top of #1323 and #1330. This should actually target develop, but am targeting #1330 to reduce diff noise. Will rebase this after that has been merged.
Adds an endpoint which gets temporary credentials to an S3 folder, allowing the front-end to upload files from the user's machine to S3. These credentials use Auth0's delegation API call, along with AWS's STS configuration, about which more can be learned in #1323. This grants the user permission to list, read, write, and delete files in s3://${RF_DATA_BUCKET}/user-uploads/<user-id>/.
While the permissions are for the entire user folder, we return a bucketPath that appends the uploadId to the above path. This path can be used by the front-end to upload files. The endpoint also creates and then deletes a test.txt file to ensure that the temporary credentials work as expected before passing them through to the client.
The STS configuration applies to the rasterfoundry-development-data-us-east-1 bucket. Unfortunately, in the .env file, we point to rasterfoundry-staging-data-us-east-1. Change the value of DATA_BUCKET manually before proceeding.
Checklist

Styleguide updated, if necessary
[x] Swagger specification updated, if necessary
Symlinks from new migrations present or corrected for any new migrations

Demo
Create an upload
POST /api/uploads HTTP/1.1
Accept: application/json, */*
Accept-Encoding: gzip, deflate
Authorization: Bearer eyJ...

Connection: keep-alive
Host: localhost:9100
User-Agent: HTTPie/0.9.8

HTTP/1.1 200 OK
Connection: keep-alive
Content-Encoding: gzip
Content-Type: application/json
Date: Mon, 27 Mar 2017 20:34:49 GMT
Server: nginx
Strict-Transport-Security: max-age=15552000; preload
Transfer-Encoding: chunked
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-XSS-Protection: 1; mode=block

{
    "bucketPath": "https://rasterfoundry-development-data-us-east-1.s3.amazonaws.com/user-uploads/google-oauth2%7C116.../433cb5cb-d528-4655-a552-d131b2179f8e",
    "credentials": {
        "AccessKeyId": "ASIA...",
        "Expiration": "2017-03-27T21:35:40.000Z",
        "SecretAccessKey": "zZb...",
        "SessionToken": "FQoDYX..."
    }
}

Notes
Certain strings have been hard coded, such as the upload path and Auth0 delegation variables. Should these be moved into environment variables?
Should we try to cache the credentials retrieved?
Testing Instructions

Checkout this branch

Update the value of DATA_DIR in your .env file to point to the development bucket

Run server

Create an upload

Get credentials for the upload

Use the credentials in your local environment:
 export AWS_ACCESS_KEY_ID=ASIA...
 export AWS_SECRET_ACCESS_KEY=zZb...
 export AWS_SESSION_TOKEN=FQoDYX...

Use the credentials to upload test files, download them back, list them, and delete them.
 aws s3 ls "s3://rasterfoundry-development-data-us-east-1/user-uploads/google-oauth2|116.../433cb5cb-d528-4655-a552-d131b2179f8e/"
 aws s3 cp jabberwocky.txt "s3://rasterfoundry-development-data-us-east-1/user-uploads/google-oauth2|116.../433cb5cb-d528-4655-a552-d131b2179f8e/"
 aws s3 cp "s3://rasterfoundry-development-data-us-east-1/user-uploads/google-oauth2|116.../433cb5cb-d528-4655-a552-d131b2179f8e/jabberwocky.txt" ./
 aws s3 rm "s3://rasterfoundry-development-data-us-east-1/user-uploads/google-oauth2|116.../433cb5cb-d528-4655-a552-d131b2179f8e/jabberwocky.txt"

The quotes around the S3 url are necessary to escape the | in the user_id.

Connects #1266

Great feedback, @hectcastro. I incorporated them both in the most recent commit. The S3 generated URL now looks like: https://rasterfoundry-staging-data-us-east-1.s3.amazonaws.com/user-uploads/google-oauth2%7C116.../433cb5cb-d528-4655-a552-d131b2179f8e.
Unfortunately, when trying out the credentials, I found that they weren't working as expected. Trying them from the command line doesn't work either (I just get Access Denied for all operations). I'm not sure exactly where the error is happening, but I suspect that ${saml:sub} is expanding to something other than user.id. Is there any way to see what that value is?

Latest fixup adds an RFUploadAccessTestFile with the contents:
Allow Upload Access for RF: user-uploads/google-oauth2|116.../433cb5cb-d528-4655-a552-d131b2179f8e at 2017-03-29 16:23:10.085

Every time the same user gets credentials for the same upload, this file will be overwritten. At any time, it will have the timestamp of the most recent successful upload access.


maybe instantiation simplified on client side

create intermediary Just/Nothing structs and implicit conversion
remove previously used factory methods from Maybe

I would like you to squash your commit into reasonable amount. Preferably less is better, to make a compact increment.