[BUG] pyproject.toml: name, version not recognized (UNKNOWN 0.0.0)

setuptools version
62.1.0
Python version
3.10
OS
Ubuntu 22.04
Additional environment information
No response
Description
I recently started using Python 3.10 and found the pyproject.toml-based installation lacking. It now doesn't reads name and version incorrectly:
pip install .

Defaulting to user installation because normal site-packages is not writeable
Processing /path/to/foobar
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: UNKNOWN
  Building wheel for UNKNOWN (pyproject.toml) ... done
  Created wheel for UNKNOWN: filename=UNKNOWN-0.0.0-py3-none-any.whl size=1227 sha256=sgrhihehihg
  Stored in directory: /path/to/.cache/pip/wheels/dsliughredshg
Successfully built UNKNOWN
Installing collected packages: UNKNOWN
  Attempting uninstall: UNKNOWN
    Found existing installation: UNKNOWN 0.0.0
    Uninstalling UNKNOWN-0.0.0:
      Successfully uninstalled UNKNOWN-0.0.0
Successfully installed UNKNOWN-0.0.0

Any idea why this might be? Perhaps package that's missing in my 3.10 installation? I was surprised not to get an error message here either.

Hi @nschloe , is it the case you have apyproject.toml file without the [project] section?

No, it's all there. Let me try and construct an MWE.

Here it is: https://github.com/nschloe/setuptools-UNKNOWN-bug

Thank you very much Nico, that helps a lot.
I don't know exactly what is the problem, it seems to be working fine when installed in a virtual environment:
cd /tmp
git clone https://github.com/nschloe/setuptools-UNKNOWN-bug.git
cd setuptools-UNKNOWN-bug

virtualenv -p python3.10 .venv
.venv/bin/python -m pip install .

Cloning into 'setuptools-UNKNOWN-bug'...
remote: Enumerating objects: 12, done.
remote: Counting objects: 100% (12/12), done.
remote: Compressing objects: 100% (9/9), done.
remote: Total 12 (delta 0), reused 12 (delta 0), pack-reused 0
created virtual environment CPython3.10.4.final.0-64 in 6163ms
  creator CPython3Posix(dest=/tmp/setuptools-UNKNOWN-bug/.venv, clear=False, no_vcs_ignore=False, global=False)
  seeder FromAppData(download=False, pip=bundle, setuptools=bundle, wheel=bundle, via=copy, app_data_dir=/home/abravalheri/.local/share/virtualenv)
    added seed packages: pip==22.0.4, setuptools==60.9.3, wheel==0.37.1
  activators BashActivator,CShellActivator,FishActivator,NushellActivator,PowerShellActivator,PythonActivator
Processing /tmp/setuptools-UNKNOWN-bug
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: foobar
  Building wheel for foobar (pyproject.toml) ... done
  Created wheel for foobar: filename=foobar-1.2.3-py3-none-any.whl size=1637 sha256=f907c18db190782ff7e3066eecd072fd76ec5a4777809cf7f8325309cb24937a
  Stored in directory: /home/abravalheri/.cache/pip/wheels/d5/45/27/903aaeecfb5f483be8a106ef7e408201b853f57c4b50642397
Successfully built foobar
Installing collected packages: foobar
Successfully installed foobar-1.2.3

It also seem to be OK when running from a container:
> docker run --rm -it python:3.10-bullseye /bin/bash

cd /tmp
git clone https://github.com/nschloe/setuptools-UNKNOWN-bug.git
cd setuptools-UNKNOWN-bug
python -m pip install .

Cloning into 'setuptools-UNKNOWN-bug'...                                                                                remote: Enumerating objects: 12, done.                                                                                remote: Counting objects: 100% (12/12), done.                                                                                remote: Compressing objects: 100% (9/9), done.                                                                                remote: Total 12 (delta 0), reused 12 (delta 0), pack-reused 0                                                                                Receiving objects: 100% (12/12), done.                                                                                Processing /tmp/setuptools-UNKNOWN-bug                                                                                Installing build dependencies ... done                                                                                Getting requirements to build wheel ... done                                                                                Installing backend dependencies ... done                                                                                Preparing metadata (pyproject.toml) ... done                                                                                Building wheels for collected packages: foobar                                                                                Building wheel for foobar (pyproject.toml) ... done                                                                                Created wheel for foobar: filename=foobar-1.2.3-py3-none-any.whl size=1637 sha256=d2bf3f7094f34f173b108d9306ff9bfeb1b169e635989dce7f16fa9f453dd14b                                                                                Stored in directory: /root/.cache/pip/wheels/d5/45/27/903aaeecfb5f483be8a106ef7e408201b853f57c4b50642397                                                                                Successfully built foobar                                                                                Installing collected packages: foobar                                                                                Successfully installed foobar-1.2.3                                                                                WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv

Have you tried updating pip?

It also works in a venv here.
pip is at the latest version. There's got to be something wrong with my installation. Geez, I wish I had any clue at all.

Are you using the system-provided Python and pip (i.e. the ones in /usr/bin), or are you building your own?

It's all in ~/.local, from pypi. The issue remain on main/master (both setuptools and pip) which I'm using for debugging.

Any chance this originates from caches of previous builds?
Does it persist even after a rm -rf build dist *.egg-info src/*.egg-info?

Can you run pip debug and share the output from that? And, run pip install with -vv?

pip debug

WARNING: This command is only meant for debugging. Do not use this with automation for parsing and getting these details, since the output and options of this command may change without notice.
pip version: pip 22.1.dev0 from /home/nschloe/.local/lib/python3.10/site-packages/pip (python 3.10)
sys.version: 3.10.4 (main, Apr  2 2022, 09:04:19) [GCC 11.2.0]
sys.executable: /usr/bin/python3
sys.getdefaultencoding: utf-8
sys.getfilesystemencoding: utf-8
locale.getpreferredencoding: UTF-8
sys.platform: linux
sys.implementation:
  name: cpython
'cert' config value: Not specified
REQUESTS_CA_BUNDLE: None
CURL_CA_BUNDLE: None
pip._vendor.certifi.where(): /home/nschloe/.local/lib/python3.10/site-packages/pip/_vendor/certifi/cacert.pem
pip._vendor.DEBUNDLED: False
vendored library versions:
  CacheControl==0.12.10
  colorama==0.4.4
  distlib==0.3.3
  distro==1.6.0
  html5lib==1.1
  msgpack==1.0.3 (Unable to locate actual module version, using vendor.txt specified version)
  packaging==21.3
  pep517==0.12.0
  platformdirs==2.4.1
  pyparsing==3.0.8
  requests==2.27.1
  certifi==2021.10.08
  chardet==4.0.0
  idna==3.3
  urllib3==1.26.8
  rich==11.0.0 (Unable to locate actual module version, using vendor.txt specified version)
  pygments==2.11.2
  typing_extensions==4.0.1 (Unable to locate actual module version, using vendor.txt specified version)
  resolvelib==0.8.1
  setuptools==44.0.0 (Unable to locate actual module version, using vendor.txt specified version)
  six==1.16.0
  tenacity==8.0.1 (Unable to locate actual module version, using vendor.txt specified version)
  tomli==1.0.3
  webencodings==0.5.1 (Unable to locate actual module version, using vendor.txt specified version)
Compatible tags: 818
  cp310-cp310-manylinux_2_35_x86_64
  cp310-cp310-manylinux_2_34_x86_64
  cp310-cp310-manylinux_2_33_x86_64
  cp310-cp310-manylinux_2_32_x86_64
  cp310-cp310-manylinux_2_31_x86_64
  cp310-cp310-manylinux_2_30_x86_64
  cp310-cp310-manylinux_2_29_x86_64
  cp310-cp310-manylinux_2_28_x86_64
  cp310-cp310-manylinux_2_27_x86_64
  cp310-cp310-manylinux_2_26_x86_64
  ...
  [First 10 tags shown. Pass --verbose to show all.]

pip install . -vv

Using pip 22.1.dev0 from /home/nschloe/.local/lib/python3.10/site-packages/pip (python 3.10)
Defaulting to user installation because normal site-packages is not writeable
Created temporary directory: /tmp/pip-ephem-wheel-cache-5upjyai5
Created temporary directory: /tmp/pip-build-tracker-fj5v1v9p
Initialized build tracking at /tmp/pip-build-tracker-fj5v1v9p
Created build tracker: /tmp/pip-build-tracker-fj5v1v9p
Entered build tracker: /tmp/pip-build-tracker-fj5v1v9p
Created temporary directory: /tmp/pip-install-kn0svgpe
Processing /home/nschloe/software/nschloe/setuptools-UNKNOWN-bug
  Added file:///home/nschloe/software/nschloe/setuptools-UNKNOWN-bug to build tracker '/tmp/pip-build-tracker-fj5v1v9p'
  Created temporary directory: /tmp/pip-build-env-lvx4ym5h
  Created temporary directory: /tmp/pip-standalone-pip-jtuo8gm7
  Running command pip subprocess to install build dependencies
  Using pip 22.1.dev0 from /tmp/pip-standalone-pip-jtuo8gm7/__env_pip__.zip/pip (python 3.10)
  Collecting setuptools>=61
    Using cached setuptools-62.1.0-py3-none-any.whl (1.1 MB)
  Installing collected packages: setuptools
  Successfully installed setuptools-62.1.0
  Installing build dependencies ... done
  Running command Getting requirements to build wheel
  running egg_info
  writing manifest file 'UNKNOWN.egg-info/SOURCES.txt'
  Getting requirements to build wheel ... done
  Created temporary directory: /tmp/pip-standalone-pip-jed8u07y
  Running command pip subprocess to install backend dependencies
  Using pip 22.1.dev0 from /tmp/pip-standalone-pip-jed8u07y/__env_pip__.zip/pip (python 3.10)
  Collecting wheel
    Using cached wheel-0.37.1-py2.py3-none-any.whl (35 kB)
  Installing collected packages: wheel
    Creating /tmp/pip-build-env-lvx4ym5h/normal/local/bin
    changing mode of /tmp/pip-build-env-lvx4ym5h/normal/local/bin/wheel to 775
  Successfully installed wheel-0.37.1
  Installing backend dependencies ... done
  Created temporary directory: /tmp/pip-modern-metadata-hhyyiox_
  Running command Preparing metadata (pyproject.toml)
  running dist_info
  creating /tmp/pip-modern-metadata-hhyyiox_/UNKNOWN.egg-info
  writing manifest file '/tmp/pip-modern-metadata-hhyyiox_/UNKNOWN.egg-info/SOURCES.txt'
  writing manifest file '/tmp/pip-modern-metadata-hhyyiox_/UNKNOWN.egg-info/SOURCES.txt'
  Preparing metadata (pyproject.toml) ... done
  Source in /home/nschloe/software/nschloe/setuptools-UNKNOWN-bug has version 0.0.0, which satisfies requirement UNKNOWN==0.0.0 from file:///home/nschloe/software/nschloe/setuptools-UNKNOWN-bug
  Removed UNKNOWN==0.0.0 from file:///home/nschloe/software/nschloe/setuptools-UNKNOWN-bug from build tracker '/tmp/pip-build-tracker-fj5v1v9p'
Created temporary directory: /tmp/pip-unpack-w1yz2tuj
Building wheels for collected packages: UNKNOWN
  Created temporary directory: /tmp/pip-wheel-t0daq_rt
  Destination directory: /tmp/pip-wheel-t0daq_rt
  Running command Building wheel for UNKNOWN (pyproject.toml)
  running bdist_wheel
  running build
  running install
  running install_egg_info
  running egg_info
  writing manifest file 'UNKNOWN.egg-info/SOURCES.txt'
  Copying UNKNOWN.egg-info to build/bdist.linux-x86_64/wheel/UNKNOWN-0.0.0.egg-info
  running install_scripts
  Building wheel for UNKNOWN (pyproject.toml) ... done
  Created wheel for UNKNOWN: filename=UNKNOWN-0.0.0-py3-none-any.whl size=961 sha256=fbe801efc0ed589ed6e268eabeef9a3c21e21aebb5708474998de84ecab9c4ee
  Stored in directory: /home/nschloe/.cache/pip/wheels/8c/53/6f/b8f9907b9ed054106c802dcf084e59af6c78e96adc189caa9c
Successfully built UNKNOWN
Installing collected packages: UNKNOWN
  Attempting uninstall: UNKNOWN
    Found existing installation: UNKNOWN 0.0.0
    Uninstalling UNKNOWN-0.0.0:
      Created temporary directory: /home/nschloe/.local/lib/python3.10/site-packages/~NKNOWN-0.0.0.dist-info
      Removing file or directory /home/nschloe/.local/lib/python3.10/site-packages/UNKNOWN-0.0.0.dist-info/
      Successfully uninstalled UNKNOWN-0.0.0

Successfully installed UNKNOWN-0.0.0
Removed build tracker: '/tmp/pip-build-tracker-fj5v1v9p'

I could also add some print()s to setuptools or pip.

I wander if this is related to https://github.com/pypa/pip/issues/6264#issuecomment-1086882745
It seems that an older version of setuptools is being loaded from outside the environment prepared by pip.

Yup, that’s what this looks like. You’re almost certainly using a Debian-patched Python which behaves incorrectly with pip and how it handles build isolation.

I'm indeed on Ubuntu 22.04. I've now tried the fixed (?) Python from the deadsnakes PPA (https://launchpad.net/~deadsnakes/+archive/ubuntu/python3.10-jammy), still to no avail.
pip install . -vv

Using pip 22.0.4 from /home/nschloe/.local/lib/python3.10/site-packages/pip (python 3.10)
Defaulting to user installation because normal site-packages is not writeable
Created temporary directory: /tmp/pip-ephem-wheel-cache-cp8n1mrt
Created temporary directory: /tmp/pip-req-tracker-2wziyn5f
Initialized build tracking at /tmp/pip-req-tracker-2wziyn5f
Created build tracker: /tmp/pip-req-tracker-2wziyn5f
Entered build tracker: /tmp/pip-req-tracker-2wziyn5f
Created temporary directory: /tmp/pip-install-cugd9fnz
Processing /home/nschloe/software/nschloe/setuptools-UNKNOWN-bug
  Added file:///home/nschloe/software/nschloe/setuptools-UNKNOWN-bug to build tracker '/tmp/pip-req-tracker-2wziyn5f'
  Created temporary directory: /tmp/pip-build-env-grzhsya1
  Created temporary directory: /tmp/pip-standalone-pip-7g1ikiwq
  Running command pip subprocess to install build dependencies
  Using pip 22.0.4 from /tmp/pip-standalone-pip-7g1ikiwq/__env_pip__.zip/pip (python 3.10)
  Collecting setuptools>=61
    Using cached setuptools-62.1.0-py3-none-any.whl (1.1 MB)
  Installing collected packages: setuptools
  Successfully installed setuptools-62.1.0
  Installing build dependencies ... done
  Running command Getting requirements to build wheel
  running egg_info
  writing manifest file 'UNKNOWN.egg-info/SOURCES.txt'
  Getting requirements to build wheel ... done
  Created temporary directory: /tmp/pip-standalone-pip-x8kpa2d7
  Running command pip subprocess to install backend dependencies
  Using pip 22.0.4 from /tmp/pip-standalone-pip-x8kpa2d7/__env_pip__.zip/pip (python 3.10)
  Collecting wheel
    Using cached wheel-0.37.1-py2.py3-none-any.whl (35 kB)
  Installing collected packages: wheel
    Creating /tmp/pip-build-env-grzhsya1/normal/local/bin
    changing mode of /tmp/pip-build-env-grzhsya1/normal/local/bin/wheel to 775
  Successfully installed wheel-0.37.1
  Installing backend dependencies ... done
  Created temporary directory: /tmp/pip-modern-metadata-cx_uo7qm
  Running command Preparing metadata (pyproject.toml)
  running dist_info
  creating /tmp/pip-modern-metadata-cx_uo7qm/UNKNOWN.egg-info
  writing manifest file '/tmp/pip-modern-metadata-cx_uo7qm/UNKNOWN.egg-info/SOURCES.txt'
  writing manifest file '/tmp/pip-modern-metadata-cx_uo7qm/UNKNOWN.egg-info/SOURCES.txt'
  Preparing metadata (pyproject.toml) ... done
  Source in /home/nschloe/software/nschloe/setuptools-UNKNOWN-bug has version 0.0.0, which satisfies requirement UNKNOWN==0.0.0 from file:///home/nschloe/software/nschloe/setuptools-UNKNOWN-bug
  Removed UNKNOWN==0.0.0 from file:///home/nschloe/software/nschloe/setuptools-UNKNOWN-bug from build tracker '/tmp/pip-req-tracker-2wziyn5f'
Created temporary directory: /tmp/pip-unpack-hsq4yaq7
Building wheels for collected packages: UNKNOWN
  Created temporary directory: /tmp/pip-wheel-ngwdy_74
  Destination directory: /tmp/pip-wheel-ngwdy_74
  Running command Building wheel for UNKNOWN (pyproject.toml)
  running bdist_wheel
  running build
  running install
  running install_egg_info
  running egg_info
  writing manifest file 'UNKNOWN.egg-info/SOURCES.txt'
  Copying UNKNOWN.egg-info to build/bdist.linux-x86_64/wheel/UNKNOWN-0.0.0.egg-info
  running install_scripts
  Building wheel for UNKNOWN (pyproject.toml) ... done
  Created wheel for UNKNOWN: filename=UNKNOWN-0.0.0-py3-none-any.whl size=961 sha256=558fec805c83652321354cbcc23881544f1a163e9bfcb556db1ce4539a779e36
  Stored in directory: /home/nschloe/.cache/pip/wheels/8c/53/6f/b8f9907b9ed054106c802dcf084e59af6c78e96adc189caa9c
Successfully built UNKNOWN
Installing collected packages: UNKNOWN

Successfully installed UNKNOWN-0.0.0
Removed build tracker: '/tmp/pip-req-tracker-2wziyn5f'

I don't know what this patch does, but just to make sure the problem we discuss in https://github.com/pypa/pip/issues/6264#issuecomment-1086882745 is the case, would it be possible for you to try updating the version of setuptools in /usr/local/lib/python3.10/dist-packages/setuptools to 62.1.0 and running again? That could clarify some things...

deadsnake (intentionally) distributes exactly the same Python patches as Debian, simply backporting (and forward-poarting, is that a thing?) them to more system versions. So if something does not work right with the system Python, it’s likely to also not work with a deadsnake Python—that’s an explicit design goal.
But whatever the problem is, it very likely roots in the a patch that breaks build isolation.

This is a reproducer based on the issue previously reported in the pip tracker:
> docker run --rm -it debian:11 /bin/bash

apt update && apt install -y python3 python3-dev curl git
cd /tmp
curl -sSL https://bootstrap.pypa.io/get-pip.py -o get-pip.py
python3 get-pip.py --no-setuptools --no-wheel
python3 -m pip install -Uv setuptools==44.0.0
python3 -m pip list
# Package    Version
# ---------- -------
# pip        22.0.4
# setuptools 44.0.0
python3 -c 'import setuptools; print(setuptools.__path__, setuptools.__version__)'
# ['/usr/local/lib/python3.9/dist-packages/setuptools'] 44.0.0
git clone https://github.com/nschloe/setuptools-UNKNOWN-bug
cd setuptools-UNKNOWN-bug
pip install . -vv
# ...
# Successfully installed UNKNOWN-0.0.0
# ...

Note that when we update the root installation of setuptools, the project builds correctly, which indicates that the dist-packages folder is somehow leaking into the build environment:
python3 -m pip install -Uv setuptools==62.1.0
pip install . -vv
# ...
# Successfully installed foobar-1.2.3
# ...

@nschloe, if you can confirm that is the case, I think we can close this issue as a duplicate and follow the original discussion in https://github.com/pypa/pip/issues/6264 for updates.

Indeed, this is the problem. I've "fixed" it by removing the system setuptools,
sudo apt purge python3-setuptools

Now it all builds correctly.

Thank you very much for confirming @nschloe

I think this person had the same problem  :-)
https://pypi.org/project/UNKNOWN/

Judging from the 2004 upload, I’m pretty sure that’s a differnt problem. pyproject.toml wasn’t invented until 2016.

TLDR; On Ubuntu 22.04 (Jammy) ensure the environment variable DEB_PYTHON_INSTALL_LAYOUT=deb_system before running pip build a PEP621 compliant project with setuptools.
This issue is occurring on Jammy because pip is unable to get an accurate list of system package directories to remove from it's temporary build environment's sys.path.  As a result when the temporary build env's site/sitecustomize.py script runs /usr/lib/python3/dist-packages is left at the end of sys.path before the overlay and normal paths are added placing it before those dirs in the search path. This means Jammy's debian packaged setuptools at version 59 is found and loaded ahead of whatever version the pyproject.toml requested. That version does not support PEP621 and is unable to extract name and version metadata.
This was not an issue on 20.04 (Focal) because the get_purelib and get_platlib logic inside pip/_internal/locations/__init__.py switched at runtime between using the older distutils and newer sysconfig modules for determining purelib and platlib paths. That choice is based on the value of sysconfig._PIP_USE_SYSCONFIG, which only defaults to False if the python version is less than 3.10. The older distuils knew how to deal with Debian's install scheme layout, where the newer sysconfig doesn't unless the env var DEB_PYTHON_INSTALL_LAYOUT is set to either deb or deb_system.
This means this is a distro configuration/packaging issue, but I'm posting this comment on the closed bug because this bug report comes up as the top result when googling for this issue.

This was purportedly fixed toward the end of September 2022 in https://github.com/pypa/pip/pull/11466

For mac users -
Turns out, there was an outdated setuptools installed in my mac too. It took me some but I finally found it and removed it -
$ sudo rm ./Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/site-packages/setuptools*

For me it helped to update pip
python3 -m pip install pip -U

I've read through all of this but still have no idea what the solution is. I've updated to the latest pip. Can anyone succinctly describe a solution on Ubuntu 22.04? I'm in a dev container already, so I'm not using venv.

I recall I might have worked around this by specifying these things 8n any other way, such as the traditional setup.py .

Which is aggravating since then you get deprecation warnings non-stop...

I've read through all of this but still have no idea what the solution is. I've updated to the latest pip. Can anyone succinctly describe a solution on Ubuntu 22.04? I'm in a dev container already, so I'm not using venv.

Have you tried setting  DEB_PYTHON_INSTALL_LAYOUT=deb_system, in you dev container, or exporting it before running pip? There is a longer explanation here https://github.com/pypa/setuptools/issues/3269#issuecomment-1254507377, but I found that help me.  Though I thought it had been fixed by now... as I don't seem to have that set /etc/environment any more.

I've read through all of this but still have no idea what the solution is. I've updated to the latest pip. Can anyone succinctly describe a solution on Ubuntu 22.04? I'm in a dev container already, so I'm not using venv.

Have you tried setting DEB_PYTHON_INSTALL_LAYOUT=deb_system, in you dev container, or exporting it before running pip? There is a longer explanation here #3269 (comment), but I found that help me. Though I thought it had been fixed by now... as I don't seem to have that set /etc/environment any more.

The issue is occurring at build time, not at install time. I'm trying to build a wheel using this command line:
python3 -m build --no-isolation --wheel .

I just changed back to a setup.py.

I ran into this issue using pipx run build -n -s in GitHub CI (ubuntu-22.04).
pip install build && python -m build -n -s works.

Ran into this issue installing my package in a Docker. Fixed it by just upgrading pip before installing my package:
pip install --upgrade pip
pip install .

Ran into this issue installing my package in a Docker. Fixed it by just upgrading pip before installing my package:
pip install --upgrade pip
pip install .

same, worked well, thank you @kikefdezl


Native scroll validation

Hello!
Anyone knows if it would be possible to validate if there is any native scroll before starting scrolling the swipeable views?
Ex:

PS: The example above is using react-swipeable-views without the "event.preventDefault" at handleTouchMove.
Thanks!!

Well, that sounds like a valid use case :+1:.
I will try to have a look.

@oliviertassinari thanks!
Did you found anything about it?
Until now my only solution was to use nested native horizontal scroll instead of css transforms, which is a totally different approach :neutral_face:

Did you find anything about it?

i hadn't time to look at it.

Sorry, I have completely forgotten this issue.

if it would be possible to validate if there is any native scroll before starting scrolling the swipeable views?

Yes, I think so.
During the handleTouchStart, we could traverse up the DOM tree from the event target to the SwipeableViews root element. If we find a node containing a scroll bar, we could ignore this event.

Hey, thanks for getting back to this.
I am actually using the package even with the issue I mentioned..
We didn't had time to focus on it too.
It seems a good plan to ignore the event if a horizontal scrollbar is found.
But it would be better to ignore it only if the element is in the middle of the scrollable area. Handling the touch move would be required though...
So, I feel like I can help you with this in the next week, if that's ok.
Thanks!

But it would be better to ignore it only if the element is in the middle of the scrollable area.

You are right, I was looking at how Google weather handles this point.
The parent scroll container claims the scroll when the child element scroll is on the edge and the velocity of the movement is high enough.


[R-package] lgb.cv mixes booster verbosity with evaluation metric monitoring

When one calls lgb.cv, one usually wants to monitor the evaluation metric in the training and validation set as the fitting procedure happens, and one usually doesn't want to know about every internal detail of what's happening inside each boosting round.
lgb.cv takes a verbosity parameter, with levels for fatal/warning/info/debug, but the messages about the metric of interest in the training and validation data do not correspond to any of those. Currently, they'd be bumped together with info, even though they don't say it in the message.
But there's no current arrangement in which one would only get the messages about the metrics and not the internal messages from each boosting round - example:
library(lightgbm)
data(mtcars)
y <- mtcars$mpg
x <- mtcars[, -1] |> as.matrix()
result <- lgb.cv(
    data = lgb.Dataset(x, label=y),
    params = list(
        objective = "regression",
        metric = "l2",
        min_data_in_leaf = 5
    ),
    nrounds = 5,
    nfold = 3,
    verbose = 1,
    eval_train_metric = TRUE
)

[LightGBM] [Warning] Auto-choosing col-wise multi-threading, the overhead of testing was 0.000055 seconds.
You can set `force_col_wise=true` to remove the overhead.
[LightGBM] [Info] Total Bins 74
[LightGBM] [Info] Number of data points in the train set: 22, number of used features: 10
[LightGBM] [Warning] Auto-choosing col-wise multi-threading, the overhead of testing was 0.000044 seconds.
You can set `force_col_wise=true` to remove the overhead.
[LightGBM] [Info] Total Bins 74
[LightGBM] [Info] Number of data points in the train set: 21, number of used features: 10
[LightGBM] [Warning] Auto-choosing col-wise multi-threading, the overhead of testing was 0.000041 seconds.
You can set `force_col_wise=true` to remove the overhead.
[LightGBM] [Info] Total Bins 74
[LightGBM] [Info] Number of data points in the train set: 21, number of used features: 10
[LightGBM] [Info] Start training from score 20.604546
[LightGBM] [Warning] No further splits with positive gain, best gain: -inf
[LightGBM] [Info] Start training from score 19.761905
[LightGBM] [Warning] No further splits with positive gain, best gain: -inf
[LightGBM] [Info] Start training from score 19.880952
[LightGBM] [Warning] No further splits with positive gain, best gain: -inf
[1] "[1]:  train's l2:29.7871+2.01926  valid's l2:31.7638+4.84005"
[LightGBM] [Warning] No further splits with positive gain, best gain: -inf
[LightGBM] [Warning] No further splits with positive gain, best gain: -inf
[LightGBM] [Warning] No further splits with positive gain, best gain: -inf
[1] "[2]:  train's l2:25.4878+1.93599  valid's l2:28.1109+4.93162"
[LightGBM] [Warning] No further splits with positive gain, best gain: -inf
[LightGBM] [Warning] No further splits with positive gain, best gain: -inf
[LightGBM] [Warning] No further splits with positive gain, best gain: -inf
[1] "[3]:  train's l2:21.9533+1.92091  valid's l2:25.3463+5.08398"
[LightGBM] [Warning] No further splits with positive gain, best gain: -inf
[LightGBM] [Warning] No further splits with positive gain, best gain: -inf
[LightGBM] [Warning] No further splits with positive gain, best gain: -inf
[1] "[4]:  train's l2:18.9155+1.72977  valid's l2:23.1842+5.24103"
[LightGBM] [Warning] No further splits with positive gain, best gain: -inf
[LightGBM] [Warning] No further splits with positive gain, best gain: -inf
[LightGBM] [Warning] No further splits with positive gain, best gain: -inf
[1] "[5]:  train's l2:16.4374+1.55234  valid's l2:21.0872+5.31824"

Whereas one would usually want to see only these:
[1] "[1]:  train's l2:29.7871+2.01926  valid's l2:31.7638+4.84005"
[1] "[2]:  train's l2:25.4878+1.93599  valid's l2:28.1109+4.93162"
[1] "[3]:  train's l2:21.9533+1.92091  valid's l2:25.3463+5.08398"
[1] "[4]:  train's l2:18.9155+1.72977  valid's l2:23.1842+5.24103"
[1] "[5]:  train's l2:16.4374+1.55234  valid's l2:21.0872+5.31824"

And without the [1] that gets added by R's print function.
Should ideally have a separate parameter for deciding whether to print the metric that wouldn't be tied to the booster's internals.

Please quickly review and fix. This mix up of loggings is very annoying.

I am using the Python API (not R)

@bennyjg Thanks for using LightGBM.
The issue you're commenting on here is specific to the R package.
If you'd like to suggest different behavior for the Python package, please first check that there aren't other issues at https://github.com/microsoft/LightGBM/issues already tracking what you're asking about, then open a new issue with a minimal, reproducible example showing the behavior you're currently seeing and explaining the behavior you'd expect/prefer.

Thanks very much for taking the time to write this up!
I agree with the proposal that these things should be separated.


Add support for Numpy versions >= 2.0

Update build metadata to require numpy >= 2.0 for Python versions >= 3.9.

Thanks Aaron! 🙏
Would it make sense to include a "fixes" note in the OP referencing issue ( https://github.com/scikit-sparse/scikit-sparse/issues/120 )?

Thanks Aaron! Will this commit be merged soon?


Declare types for Promises ?

That is how my declaration looks.
declare class Promise$Type {
    all(promises: Object): void;
    then(result: Function, err: Function): void;
}

declare function Promise(callback: (resolve: Function, reject: Function) => void): Promise$Type ;

declare module "es6-promise" {
	declare var Promise: Promise;
}

The problem is that the following code passes the flow check call:
var test = Promise(function(resolve, reject) {});
test.then1(function(d) {

});

There seems to be some overlapping with #213.  flow check succeeds if the 'es6-promise' module is not installed. Otherwise I get 'Required module not found'.

Support for promises is built in. You shouldn't need to declare anything on your own. Are you still having this issue?

Please reopen if this is still an issue for you. Thanks!


Add sparse multivariate normal distribution

To simplify the review for #722, which is almost finished, I move part of that pull request which adds a SparseMultivariateNormal distribution to here.
This pull request implements a "sparse" (fast calculation) for log prob of a Multivariate Normal distribution whose covariance matrix has the form D + W.T @ W. Here D is a diagonal matrix and W is a matrix of size M x N (in the sparse situation: M << N).

@fritzo Thanks a lot for your review! I have made changes relevant to what you suggested. There are  several bugs that I detected along the way, so I include them on this pull request:

docs hook for binomial, poisson
change from scale_triu to scale_tril in MultivariateNormal (because we put constraint on scale_tril, not scale_triu).

This should pass all tests now.


no_std session

This is a start to have a session for no_std environments.
The HeapSession depends on the alloc crate which can be used without std lib. To use it in embedded environments, a global allocator must be defined. For cortex m controller, the crate alloc-cortex-m exists, which implements an allocator.
This first attempt will provide the flexibility of the SessionManager and can be used in embedded systems, as well in std environments. I will add an example how to use this attempt.
One thing is, that in the alloc crate, no HashMap is available, so this implementation uses a BTreeMap which has nearly the same interface.
To further verify this implementation, tests have to be added.
To move further in the embedded direction, some sort of static memory management would be great. But this is difficult to implement. It would mean, that the user has to specify which messages he uses, or the SessionManager has to adopt more to the underlying transport.
As an example, FDCAN:
Max 64Byte MTU.  The MTU size is not linear. It is specified in steps. Of course, every static allocated array can have a size of 64Byte memory. If most frames are smaller, this would not be very memory efficient. So, some kind of different sized buffers need to be used.
Based on DataTypes:
If the user subscribes for a message A, its data type must be specified. If the size of the data type can be known at the compile time, the needed memory space to receive the type can be allocated. But this can't be done for dynamic data types. Another problem is, that it is difficult to safe different sized slices in a collection because every different sized array is a different type.
let subs = Vec::<Buffer>::new(); // every Buffer must be the same len.

By now, I didn't come up with a good solution and more research has to be done.

Allocators are a pet peeve of mine so I can't ignore the fact that the crate you referred to uses a linear-time-complexity linked-list allocator, which is (very) bad. I made a decent allocator in C which could be reimplemented in Rust, or we could leverage one of the existing implementations of half-fit/TLSF in Rust like https://github.com/yvt/rlsf (I have no experience with this implementation though).


Feature: output to file

Is your feature request related to a problem? Please describe.
When running the scorecard docker container in a CI system it would be great if there was an option to write the output to a file.
This way we can avoid having to tee the results out and thus running scorecard in a shell.
Describe the solution you'd like
add a -o option that makes scorecard write the results to the file/path specified by -o
Describe alternatives you've considered
A current workaround is to redirect scorecard's output to a file or wrap it in a script that provides this -o functionality but in both those cases scorecard is not running in a minimal container anymore
Additional context
This sounds like a small change and I would be happy to send you a pull request if you're interested in this feature and can point me to the correct files/dirs that need changing.

This is something that github.com/ossf/scorecard-action also needs a workaround for:
https://github.com/ossf/scorecard-action/blob/7cc371152c77bfecfa34fdfb62b1630ff3682cf1/entrypoint/entrypoint.go#L92-L100
I'm personally in support of a -o option, as the stdout redirect workaround breaks scorecard-action if any logging statements accidentally slip into the code.
Currently if you do --format json, the only thing that is (or rather should be) printed is the json output itself. If provided -o argument I would expect that to disappear as it's written to the output file instead. Is that what you had in mind?

This way we can avoid having to tee the results out and thus running scorecard in a shell.

Seeing as you're using tee now, are you expecting the stdout to stay the same, but also write to a file?

+1 here
I would really love this for my use case. Right now I have to build my custom image on alpine base to redirect output to a file.

Hi there! I believe https://github.com/ossf/scorecard/pull/3192/ ended up getting stale and closed and not solving the problem here or in https://github.com/ossf/scorecard/issues/3191. I can reopen the PR addressing the changes, Spencer.
One thing I would change on the approach tho, is to keep the format argument, as you can still output the result in the TXT or JSON format, but additionally output it to result.json or result.txt or result.log instead of the console.

One thing I would change on the approach tho, is to keep the format argument, as you can still output the result in the TXT or JSON format, but additionally output it to result.json or result.txt or result.log instead of the console.

I'm not sure I follow. I would expect flags to do one thing:

--format to only change the format
--output to specify a destination instead of stdout

You're advocating for some sort of --tee?


Add MSVC compiling support for make

I need a .lib file for Windows. It would be really nice to have make support for this.

As far as I got but this just creates an empty .lib with no exports.
https://github.com/sol-vin/ferox-cr/blob/master/rsrc/ferox.c
https://github.com/sol-vin/ferox-cr/blob/master/rsrc/install.ps1

Thank you for your interest in this library, I will look into this issue as soon as possible!

@sol-vin Could you tell me which version of Visual Studio you're using to build this library?

@sol-vin Could you tell me which version of Visual Studio you're using to build this library?

2022

Thank you! 👍

I just added build instructions for Visual Studio 2019, could you please let me know if they work for you?

A-rcanity5858S-creen.obj : error LNK2019: unresolved external symbol frNumberPixelsToMeters referenced in function .2A.Arcanity.3A..3A.Screen.3A..3A.width_in_meters.3A.Float32
A-rcanity5858P-layA-rea.obj : error LNK2001: unresolved external symbol frNumberPixelsToMeters
A-rcanity5858C-ard43.obj : error LNK2001: unresolved external symbol frNumberPixelsToMeters
A-rcanity5858C-ards5858M-ana5858R-awM-ana.obj : error LNK2001: unresolved external symbol frNumberPixelsToMetersA-rcanity.obj : error LNK2019: unresolved external symbol frSimulateWorld referenced in function .2A.Arcanity.3A..3A.run.3A.Nil
A-rcanity.obj : error LNK2019: unresolved external symbol frGetWorldBodyCount referenced in function .2A.Arcanity.3A..3A.get_physics_bodies.3A.Array.28.Pointer.28.Ferox.3A..3A.Body.29..29.
A-rcanity.obj : error LNK2019: unresolved external symbol frDrawBody referenced in function .2A.Arcanity.3A..3A.get_physics_bodies.3A.Array.28.Pointer.28.Ferox.3A..3A.Body.29..29.
A-rcanity5858P-layA-rea.obj : error LNK2019: unresolved external symbol frVec2PixelsToMeters referenced in function .2A.Arcanity.3A..3A.PlayArea.3A..3A.make_walls.3A.Nil
A-rcanity5858C-ard43.obj : error LNK2001: unresolved external symbol frVec2PixelsToMeters
A-rcanity5858C-ards5858M-ana5858R-awM-ana.obj : error LNK2001: unresolved external symbol frVec2PixelsToMeters
A-rcanity5858P-layA-rea.obj : error LNK2019: unresolved external symbol frAddToWorld referenced in function .2A.Arcanity.3A..3A.PlayArea.3A..3A.make_walls.3A.Nil
A-rcanity5858C-ard43.obj : error LNK2001: unresolved external symbol frAddToWorld
A-rcanity5858C-ards5858M-ana5858R-awM-ana.obj : error LNK2001: unresolved external symbol frAddToWorld
A-rcanity5858C-ard43.obj : error LNK2019: unresolved external symbol frVec2MetersToPixels referenced in function .2A.Arcanity.3A..3A.Card.2B..40.Arcanity.3A..3A.Card.23.pos.3A.struct.2E.Raylib.3A..3A.Vector2
A-rcanity5858C-ards5858M-ana5858R-awM-ana.obj : error LNK2001: unresolved external symbol frVec2MetersToPixels
A-rcanity5858C-ard43.obj : error LNK2019: unresolved external symbol frNumberMetersToPixels referenced in function .2A.Arcanity.3A..3A.Card.2B..40.Arcanity.3A..3A.Card.23.center_x.3A.Float32
A-rcanity5858C-ard43.obj : error LNK2019: unresolved external symbol frRemoveFromWorld referenced in function .2A.Arcanity.3A..3A.Card.2B..40.Arcanity.3A..3A.Card.23.clean_physics_bodies.3A.Nil
C:\Users\Ian\Documents\GitHub\arcanity\bin\arcanity.exe : fatal error LNK1120: 9 unresolved externals

Using dumpbin /EXPORTS ferox.lib gives me no exports.
Microsoft (R) COFF/PE Dumper Version 14.37.32822.0                                                                      Copyright (C) Microsoft Corporation.  All rights reserved.                                                                                Dump of file .\rsrc\ferox.lib                                                                                File Type: LIBRARY                                                                                Summary                                                                                19 .bss                                                                                12D0 .chks64                                                                                8 .data                                                                                35C .debug$S                                                                                11A .drectve                                                                                8D0 .pdata                                                                                258 .rdata                                                                                879E .text$mn                                                                                E94 .xdata

I'm afraid I forgot to tell you that there have been breaking changes to the API for the next release and those functions have been renamed... (e.g. frNumberPixelsToMeters() ➡ frPixelsToUnits())
Could you please update your code for the binding and try building this library again?

https://github.com/c-krit/ferox/commit/50367e277e559e5363ce720cf1a26a5cdf722a00


Brey batten

Nice job on the project. Commits are detailed but I'm looking for some more often commits and a little more detail on what you're doing.
The width of the navbar is a little off -- something to work on.
Overall this is a pass. Nicely done


Cleanups

This PR removes some unused files and types.  It also removes impl From<u64> for TimeDiff which is somewhat dangerous as it is not clear that the u64 represents milliseconds.  TimeDiff already provides safer alternatives in the form of from_millis and from_seconds.

bors merge


[BUG] Part of the validation code is not generated

Description
I am testing the code in the 'example' directory. After using the 'buf generate proto' command, in the 'example.pb.validate.go' file, validation code has been generated for only a few fields. The validation code for fields like 'Id', 'Email', and 'Name' is empty. and the 'Home' field has not generated the primary validation code.
func (m *Person) validate(all bool) error {
	if m == nil {
		return nil
	}

	var errors []error

	// no validation rules for Id

	// no validation rules for Email

	// no validation rules for Name

	if all {
		switch v := interface{}(m.GetHome()).(type) {
		case interface{ ValidateAll() error }:
			if err := v.ValidateAll(); err != nil {
				errors = append(errors, PersonValidationError{
					field:  "Home",
					reason: "embedded message failed validation",
					cause:  err,
				})
			}
		case interface{ Validate() error }:
			if err := v.Validate(); err != nil {
				errors = append(errors, PersonValidationError{
					field:  "Home",
					reason: "embedded message failed validation",
					cause:  err,
				})
			}
		}
	} else if v, ok := interface{}(m.GetHome()).(interface{ Validate() error }); ok {
		if err := v.Validate(); err != nil {
			return PersonValidationError{
				field:  "Home",
				reason: "embedded message failed validation",
				cause:  err,
			}
		}
	}

	if len(errors) > 0 {
		return PersonMultiError(errors)
	}

	return nil
}

this is my buf.gen.yaml :
version: v1
managed:
  enabled: true
  go_package_prefix:
    default: tests.example.v1

plugins:
  - plugin: buf.build/protocolbuffers/go
    out: gen
    opt: paths=source_relative

  - plugin: buf.build/bufbuild/validate-go:v1.0.2
    out: gen
    opt:
      - paths=source_relative

Environment

Operating System:  Windows 11
Compiler/Toolchain: go version go1.20.7 windows/amd64
Protobuf Compiler & Version:  buf v1.27.1, protoc libprotoc 22.0-rc2
Protoc-gen-validate Version: 1.0.2
Protovalidate Version:  v1.0.2

TestCode
validatetest.zip

buf.gen.yaml
version: v1
managed:
enabled: true
go_package_prefix:
default: tests.example.v1

plugins:

plugin: buf.build/protocolbuffers/go
out: gen
opt: paths=source_relative

https://github.com/bufbuild/protovalidate-go/blob/60a89b50e8dac2e86cdcc0cb401e9508f170c2be/README.md?plain=1#L9-L16
example
https://github.com/bufbuild/protovalidate-go#example

Hi, @dorlolo! The protovalidate project does not have a code-generation component, the validation rules are determined at runtime via proto reflection by the libraries. The buf.build/bufbuild/validate-go plugin is a generator for protoc-gen-validate which is the predecessor of this project.
The README documentation on protovalidate and protovalidate-go walks through the process of using this project. Let me know if this helps!


Report Cards to Discord

TODO: Organization configuration for Discord channel to send to.
TODO: Get MLE Scrim ID from Sprocket Scrim object to generate report card for.


Word of Radiance not damaging enemies

Word_of_radiance_bug.zip
Word of radience shows an area of effect around the character. But when I cast it, it does no damage. Additionally, the animation for the spell impact seems to proc at a completely different tile.

Similarly, the Thunderclap cantrip also does not appear to work.


[WIP] Release v0.16.2

Includes

#1786
#1801
#1805

Resolves

#1809
#1807

As of https://github.com/voxel51/fiftyone/pull/1808/commits/a624f434889abb737662e455fe5ea63ab4319dc9, when I run this code:
import fiftyone as fo
import fiftyone.zoo as foz

dataset = foz.load_zoo_dataset("quickstart-video")
clips = dataset.to_clips("frames.detections")

session.view = clips

and then refresh the App by pressing ctrl + R in my browser, I get this error:
Error: invalid path support
at http://localhost:5151/assets/index.60546a6e.js:191:11861
at a (http://localhost:5151/assets/vendor.fa360434.js:51:287465)
at w (http://localhost:5151/assets/vendor.fa360434.js:51:276411)
at B (http://localhost:5151/assets/vendor.fa360434.js:51:277622)
at http://localhost:5151/assets/vendor.fa360434.js:51:278916
at http://localhost:5151/assets/vendor.fa360434.js:51:278888
at Object.F [as get] (http://localhost:5151/assets/vendor.fa360434.js:51:278910)
at getNodeLoadable (http://localhost:5151/assets/vendor.fa360434.js:51:235406)
at http://localhost:5151/assets/vendor.fa360434.js:51:277128
at u2.getLeafNode (http://localhost:5151/assets/vendor.fa360434.js:51:268153)

Also, if I then try to escape this error by pressing x in the error form, the error still persists. It also persists if I first do this:
session.view = None

and then press the x. However, I can now escape the error via ctrl + R in the browser.
I'm stating this second part because it would be ideal if pressing x would more reliably bring the App back to a functional state. One off-the-cuff idea there is:

If the error occurred while loading a view, reload with the view cleared (session.view = None)
If the error occurred while loading a dataset, reload with the dataset cleared (session.dataset = None)
If any other error occurred, just reload the current route

Comments addressed.
Resetting from the error page with the X is equivalent to session.dataset = None now. Adding in more scenarios would likely get complicated.

Just verified that #1807 and #1809 are resolved 👍

Resetting from the error page with the X is equivalent to session.dataset = None now. Adding in more scenarios would likely get complicated.

Hmm not sure about always resetting to session.dataset = None... feels like this might be more annoying than helpful because it'll take clicks to get back to where you where. Likely you did a sequence of things, all of which were valid except the very last thing. I guess in that sense what would be cool is to keep a small history of pages and just pop the bad one from the stack...
But anyway, don't want to overdesign right now. The whole point of having the x is to escape to a valid state, so, I guess if it must always do one thing, then session.dataset = None is the only thing that's guaranteed to work.


ROCm upgrades itself without explicit request

Just doing normal ubuntu updates causes ROCm to upgrade itself. With normal debian repositories this would not be a problem. But ROCm is different: The Release Notes of ROCM 3.7 state that "fresh and clean installation of AMD ROCm v3.7 is recommended".
The reason for this statement becomes obvious after such an involuntary upgrade: the whole ROCm installation is broken and must be fixed by manually executing the steps described in the installation guide. Several issues reported in this project already document this behavior.
While it is can be reasonable to have a manual upgrade process for ROCm software it is not reasonable to expect users to disable all updates for ubuntu. Updates are needed in order to keep the installation secure and to have bugs in other software packages fixed.

@seesturm This is not a defect, but intentional.
If you want to use only specific version of ROCm you can do that by installing specific version of ROCm using versioned packages.
What do you mean by:

whole ROCm installation is broken and must be fixed by manually executing the steps described in the installation guide

@baryluk ROCm team has to choose and document the intended upgrade method:

Either normal debian style "automatic" upgrades are supported - without the need to (manually) uninstall previous installation, or
ROCm is meant to be manually upgraded. In which case upgrade must not happen automatically.

According to current Release Notes the manual upgrade method is implied: "A fresh and clean installation of AMD ROCm v3.9 is recommended. An upgrade from previous releases to AMD ROCm v3.9 is not supported". But yet upgrades happen automatically - and break the installation.

What do you mean by:

whole ROCm installation is broken and must be fixed by manually executing the steps described in the installation guide

?

After involuntary upgrade ROCm installation is in an inconsitent state. It simply does not work for me anymore. E.g. I cannot execute tensorflow applications. And there are lots of issues in this tracker which are just caused by these involuntary upgrades. Most of the time the those "issues" are "solved" by a fresh install.

If the upgrade doesn't work properly, then it is a bug indeed.
It would be good to track what is the issue.
Where there any warnings or errors during the apt upgrade?
What is the output of rocminfo after an upgrade?
What is the content of /opt/ after the upgrade? (Is it just rocm, or is there something more?)
What is the output of grep -H . /etc/ld.so.conf.d/*rocm*conf and grep -H . /etc/OpenCL/vendors/amd*icd after the upgrade.
What is the output of /usr/bin/clinfo and  env /opt/rocm*/opencl/bin/clinfo after the upgrade?

Thanks @seesturm for reaching out.
Currently we are not supporting ROCm upgrade functionality and so it can/might not work.
We understand the query and we will get back asap on this.

@seesturm As mentioned earlier, try the rocminstall.py script  (available at https://github.com/srinivamd/rocminstaller) to install ROCm version on your system to avoid accidental updates, etc. However, before using the script you would have to remove all ROCm packages, reboot, and then install ROCm using the rocminstall.py (use --rev option) to select a specific ROCm version/release to install.
Please remove any existing ROCm repo setup on your system.
The rocminstall.py script is open sourced, source code can be reviewed.
It installs ROCm using the "version-suffixed" named packages instead of generic named packages. In other words, install rocm-dev3.7.0 (for 3.7 release) instead of rocm-dev (generic name). That allows the system to be keyed on the specific set of packages installed, and not get updated when new release of ROCm is published with updated generic-named packages but different version-suffix-named packages - the version-suffix packages will have to be explicitly installed. THe rocminstall.py script encodes these details in it.
When a new ROCm release is announced, you can use rocminstall.py script to install the new release, side-to-side to the existing installed release without having to uninstall ROCm first as a "fresh and clean" install would require.
You can select the ROCm version to use by using /opt/rocm-X.Y.Z/bin to invoke the specific version. Or create a symbolic link to use a specific version by default.
HTH.

Hi @seesturm
This falls into the path of ROCm upgrade and as we all know that upgrade does not work for now.
So we request to uninstall the and install the ROCm version of choice.
Once we enable ROCm upgrade, this will be taken care.
Hope this helps.
Thank you.

Installation instructions don't document how to "install the ROCm version of choice". Installation Guide explicitly requests following entry for apt
deb [arch=amd64] https://repo.radeon.com/rocm/apt/debian/ xenial main'
When following these instructions ROCm upgrades without request.

Hi @seesturm
I will reach docs team and will ask them to update/modify to call specific rocm versions also.
For now you can install specific ROCm version as deb [arch=amd64] https://repo.radeon.com/rocm/apt/3.7/ xenial main
You can replace by changing 3.7 to any other version like 3.6, 3.5, 3.9 etc.,.

@seesturm BTW. The Installation guide do have a section about removing ROCm, so it should be relatively well working method: https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation-Guide.html#uninstalling-rocm-packages-from-ubuntu
Once you remove all relevant pacakges (verify by checking dpkg -l | grep rocm or similar), reboot, then try doing an update and installing again.
@ROCmSupport  I added some fixes to the installation guide, to point some of these issues https://github.com/RadeonOpenCompute/ROCm_Documentation/pull/103

@seesturm Yes, it is known the installation doesn't fully follow Debian policies. There are multiple bugs about that already open. The issue with the upgrade process are known to users and ROCm team. It is slowly being worked on.

Hi @seesturm
I request to close this ticket, if you feel that you got reasonable answers.
Thank you.

When following the installation instructions ROCm still upgrades itself. So issue is not solved yet.

Currently ROCm upgrades automatically along with OS upgrade.
So request to uninstall ROCm and install ROCm again, until we enable ROCm upgrade functionality officially.
Thank you.

This issue is not meant as a support request, but intended for tracking a defect. Maybe the defect is fixed by changing the documentation (e.g. use the fixed-version repo path) or by crafting the packages according to debian standard. My understanding is that we can agree on that.
So, do you want this issue tracker for defect tracking? If yes, then I'd say we should keep this issue open until it is solved. Or if it is a duplicate, then please inform about actual defect tracking issue ID.
Thank you.

Yeah, I think the bug can stay open. I don't see any existing open issue with the same topic.
Leaving it open is good for tracking, and for making sure people in the future can easily find it by search.

Hi @seesturm
I will work with documentation team on this and will make sure that this point is covered.
Thank you.

Hi @seesturm, this has been updated in ROCm docs @
https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation-Guide.html#build-amd-rocm
After an operating system upgrade, AMD ROCm may upgrade automatically and result in an error. This is because AMD ROCm does not support upgrades currently. You must uninstall and reinstall AMD ROCm after an operating system upgrade.

So you are closing this issue without a fix?
The problem is still present: ROCm upgrades itself automatically and as a consequence gets broken. Each and every ROCm user will be hit by this by surprise when they least expect it!

Hi @seesturm
As I mentioned, its not a different issue than ROCm upgrade.
When upgrade works, this will be taken care automatically and so its not a separate issue.
For now, As I promised, we have updated the documentation with the information.
We have plans to make ROCm upgrade works well at 4.2 or 4.3 time frame.

No, the instructions don't provide information on how to deal with this. They basically just give a warning that a ROCm can break at any time. Just putting a warning is not a fix.
Furthermore: The way it is written one might read it as only releveant when Ubuntu upgrades say from 20.04 to 20.10. But ROCm breaks when ROCm is (automatically) upgraded.

Hi @seesturm
The answer is simple again.
ROCm upgrade does not work for now.
Once ROCm upgrade works, all kind of scenarios will/should work.
This scenario is also a child of ROCm upgrade.
Anyway I will keep it open until ROCm upgrade functionality comes back to working mode in 4.2 or 4.3

Still have Vega 56 hardware. What is the release in which this was fixed and does this release support Vega 56?

Hi @seesturm
Vega10/MI25 is dropped from supported list from ROCm 4.5. Thank you.

Hi @ROCmSupport
I'm now confused. Can I test this with my hardware or not?

Hi @seesturm,
I suggest to try with the supported hardware. Thank you.

Hi @ROCmSupport
I hope it is a misunderstanding but your phrasing sounds like you want me to buy new hardware. But I'm not planning to buy new hardware. Can you clarify?

Hi @seesturm
Sorry for misunderstanding :)
I am saying that, if possible, try it on a supported hardware. Because though upgrade works now, your hardware does not support it.
Request to take your call. Thank you.

My interpretation of the answer is that my hardware is no longer supported. Closing issue since ROCm is no longer useful for me.


Training the cmt-b model with cifar10 results in lower accuracy than the cmt-ti model.

Training the cmt-b model with cifar10 results in lower accuracy than the cmt-ti model.
Is this the right thing? Am I wrong?

Sorry for reply so late.
It may be caused by over-fitting or other reasons
You can use early stopping to check the result.


fix: bring config & version numbers up to those in v1

The build is still failing, probably need to ensure we update lerna and perhaps other dependencies too.

This sort of fixes things @elycheea
A bit concerned as to the change to lerna.json, but the feature is deprecated and using --immutable causes an error also.
I think V2 as in 2.0.0, probably has to be release manually from the command line.


Remove search by default

Not 100% sure about this so any comments would be great. Search is now removed from the index view by default, but can be re-included using content_for(:search).
The main problem with this is that the index view will now need to be overridden just to add search, and where possible we want to avoid overriding templates. To make this easier, I've stripped back the index.html.erb template so it just includes a few partials, rather than the whole listing table.
Alternatively, we could render a search partial into the index template, but leave it blank by default. Then that partial can be overridden to include the content_for, rather than the whole index view.
The other alternative is to implement a searchable? method on the controller, which is false by default but can be overridden by resource controllers.
Thoughts?

I think I like your last suggestion to have a searchable? method

I vote option A ("null / empty partial")

My only concern with this is around the naming, search is very generic and could be used by someone consuming this, maybe rawnet_admin_search or admin_search or something that's less likely to be implemented by someone else using this?

Personally I love the idea of having a searchable? method, but I feel like we'll end up littering the controllers with this kind of config if we're not careful. Think the empty partial makes more sense to keep it clean, especially as the chances are they'll have to modify the search form anyway (extra params etc).
@efexen the views are namespaces to rawnet_admin and the resource, so the chances of a clash are slim. I'll name it listing_search though.


fix: treat status as a flow attribute instead of element

Hey @k-capehart thanks for your continuous support! Looks good to me~ I'll add in new tests for this


Memory Leak 1.8.8 & ViaVersion

zNPCS is messing with ViaVersion UserConnection and it creates a huge memory leak.
If you have ViaVersion on a 1.8.8 server and zNPCS, and join with any version above 1.8.8 and just stay afk the memory will go up until the server crash.
After i removed zNPCS there was no memoryleak anymore

g

I dont think that's a problem with znpcs but more with viaversion, nobody has reported this error but only you, also I can only see viaversion in your "problem" log.

Hello!
The problem it's related to ViaVersion an ZNPCS, after i removed the zNPCS
plugin the memory was fine
În dum., 15 mai 2022 la 10:52, Gaston Gonzalez @.***> a
scris:

I dont think that's a problem with znpcs but more with viaversion, nobody
has reported this error but only you, also I can only see viaversion in
your "problem" log.
—
Reply to this email directly, view it on GitHub
https://github.com/gonalez/znpc-servers/issues/35#issuecomment-1126880582,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMLMRWYKZVHXXT65QEH5R73VKCUMDANCNFSM5V6CQGNQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Also the problem appears after i switched to znpcs few days ago
În dum., 15 mai 2022 la 11:01, Askarion @.***> a scris:

Hello!
The problem it's related to ViaVersion an ZNPCS, after i removed the zNPCS
plugin the memory was fine
În dum., 15 mai 2022 la 10:52, Gaston Gonzalez @.***>
a scris:

I dont think that's a problem with znpcs but more with viaversion, nobody
has reported this error but only you, also I can only see viaversion in
your "problem" log.
—
Reply to this email directly, view it on GitHub
https://github.com/gonalez/znpc-servers/issues/35#issuecomment-1126880582,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMLMRWYKZVHXXT65QEH5R73VKCUMDANCNFSM5V6CQGNQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Update:
Seems the problem appears if there's more NPC's, i removed all NPCs but i didn't removed the plugin and there's no more issue with memory

I have no idea, you are the only person who has reported this then it must be some incompatibility with another plugin you have.


[CROM-6661][BT-114][DO NOT MERGE] Reference Disk Opt-in: UI work

Confirmed with Chrome network traffic monitoring that the useReferenceDisks parameter was being sent in submission requests as expected.

Added info box with link to Terra Support article. I also had to do a nontrivial rebase, confirmed the 'useReferenceDisks' parameter is still working per network traffic.

Good news: I fixed the integration test issues with a rebase.
Less good news: Said rebase was not completely trivial. Also in the process of testing I noticed that 'Use Reference Disks' was missing from SubmissionDetails.js so I added that in. All of which means I must ask for another round of review... 😞


Session drops out occasionally

Describe the problem
Sessions abruptly drop out occasionally. I have not been able to tie it to particular events or songs.
I considered that it might be a memory (cache full), but the log clearly shows that old items are removed when an uncached song comes up. And, I am pretty sure I have had it drop out playing songs on playlists that run almost daily. That said, this is still high on my list - is what I show below roughly what you'd expect if its a cache-full issue?
To Reproduce
Steps to reproduce the behavior:

Start any playlist
Wait...
The nature of this issue makes it impossible to give a step by step to reproduce

Screenshots

Device information

Board (hardware info): Raspberry Pi 4B
Device type (as seen in balenaCloud): Raspberry Pi 4B (using 64bit OS)

Well this is embarrassing but I accidentally made this for the wrong repo... apologies.


Issue solved Go Back button

Please add hacktoberfest-accepted label

@devp299 look this comment

If we are in github it will show you go back button in readme file while rendering the website it will not show that button.
Can I do this?


Avoid delete keyword

For do that, simply keep in cache a null value for items removed.
That's more a experiment for know your opinion.
Maybe could be possible make a workaround about that, becase keep keys with null value not sounds a good idea; could be possible add a cleanup process to clear these keys after X method calls or or before call .keys.
Benchmark
Based on bench-lru.
before
name, set, get1, update, get2, evict
lru-cache, 154, 1099, 565, 1538, 299
hashlru, 3125, 1818, 3448, 9091, 3704
lru, 1493, 3226, 3448, 3704, 11

after
name, set, get1, update, get2, evict
lru-cache, 389, 1538, 730, 2041, 327
hashlru, 6250, 11111, 11111, 9091, 2703
lru, 1408, 3846, 3125, 4167, 1563

Better perfomance in all the aspects than using a Map

but if this keeps the key in the table, then this means that have a memory leak in the keys. in some cases, this wouldn't matter (say if you happen to have a fairly small number of keys) but if you have a forever expanding set of keys (say, timestamps, or uuids) then you'll eventually fill memory with keys.
We really need another benchmark to measure memory use...

@dominictarr I'm agree with your last words; need a benchmarking tool that mesaure CPU and memory usage for make more easy the impact of each modification.

The cache object now has unbounded growth, and you've also slowed down .keys by requiring a filter where !== null.

could be possible add a cleanup process to clear these keys after X method calls or or before call .keys

Then you'd have to deal with garbage collection pauses, effectively removing any gain you might see in microbenchmarks.


openshift-install not creating the worker vm using IPI

Describe the bug
I am trying to deploy a new cluster into my vsphere infrastructure using IPI
Bootstrap process completes but the workers are never created

Version

openshift-install 4.5.0-0.okd-2020-10-15-235428
IPI installation
How reproducible

i have try 10 times bootstrap completes but the workers are never created
this is my install-config.yml
apiVersion: v1
baseDomain: okd.local
metadata:
name: lab
compute:

hyperthreading: Enabled
name: worker
replicas: 3
platform:
vsphere:
cpus: 4
coresPerSocket: 4
memoryMB: 16384
osDisk:
diskSizeGB: 120

controlPlane:
hyperthreading: Enabled
name: master
replicas: 3
platform:
vsphere:
cpus: 4
coresPerSocket: 4
memoryMB: 16384
osDisk:
diskSizeGB: 120
networking:
clusterNetworks:

cidr: <IP_ADDRESS>/16
hostPrefix: 23
networkType: OVNKubernetes
serviceNetwork:
<IP_ADDRESS>/16

Log bundle
DEBUG Still waiting for the cluster to initialize: Working towards 4.5.0-0.okd-2020-10-15-235428: 86% complet

No workers are created in VMWare or in the cluster?

No workers are created in VMWare or in the cluster?

no vm workers are created, only the masters, i also notice that the ingress operator never startup

what does the VMWare terminal indicate logwise for the masters?
can you run oc get nodes and oc get events

what does the VMWare terminal indicate logwise for the masters?
can you run oc get nodes and oc get events

give me 10 min i will ran the installation and i can get you all the info

It doesn't looks like the bootstrap process has finished...  Nodes get created after the bootstrap process is complete...
try running  ./openshift-install gather bootstrap --dir=<installation_directory> and post the results...
(https://docs.okd.io/latest/installing/installing-troubleshooting.html#installation-bootstrap-gather_installing-troubleshooting)

also, if possible, you may want to make sure all the nodes are running on different VMWare hosts, or as much as possible...  I've had issues were OKD hosts saturated the VMWare host CPU and it caused issues...

It doesn't looks like the bootstrap process has finished... Nodes get created after the bootstrap process is complete...
try running  ./openshift-install gather bootstrap --dir=<installation_directory> and post the results...
(https://docs.okd.io/latest/installing/installing-troubleshooting.html#installation-bootstrap-gather_installing-troubleshooting)

it does finish look
DEBUG OpenShift Installer 4.5.0-0.okd-2020-10-15-235428
DEBUG Built from commit 63200c80c431b8dbaa06c0cc13282d819bd7e5f8
INFO Waiting up to 20m0s for the Kubernetes API at https://api.lab.okd.local:6443...
DEBUG Still waiting for the Kubernetes API: Get https://api.lab.okd.local:6443/version?timeout=32s: dial tcp <IP_ADDRESS>:6443: connect: connection refused
INFO API v1.18.3 up
INFO Waiting up to 40m0s for bootstrapping to complete...                                                                                DEBUG           Bootstrap status: complete
INFO Destroying the bootstrap resources...

DEBUG - bootstrap in ../../../tmp/openshift-install-612627491/bootstrap
DEBUG - master in ../../../tmp/openshift-install-612627491/master

The image you sent and the logs didn't show that completing...  Bootstrap node was still there...
what vmware hosts are created now?

The image you sent and the logs didn't show that completing... Bootstrap node was still there...
what vmware hosts are created now?

No, that is the issue I am having bootstrap completes but workers are never created, the cluster provisioning never completes

can you run oc adm must-gather
and another shot of your currently created VMWare nodes?

can you run oc adm must-gather
and another shot of your currently created VMWare nodes?
and check oc get csr

$ oc get csr
NAME        AGE     SIGNERNAME                                    REQUESTOR                                                                   CONDITION
csr-2mvx2   8m58s   kubernetes.io/kubelet-serving                 system:node:lab-5jjb9-master-1                                              Approved,Issued
csr-8qvkh   9m17s   kubernetes.io/kube-apiserver-client-kubelet   system:serviceaccount:openshift-machine-config-operator:node-bootstrapper   Approved,Issued
csr-x6b4s   8m38s   kubernetes.io/kubelet-serving                 system:node:lab-5jjb9-master-2                                              Approved,Issued
csr-xxx7v   9m3s    kubernetes.io/kube-apiserver-client-kubelet   system:serviceaccount:openshift-machine-config-operator:node-bootstrapper   Approved,Issued
csr-zbt4g   9m1s    kubernetes.io/kube-apiserver-client-kubelet   system:serviceaccount:openshift-machine-config-operator:node-bootstrapper   Approved,Issued
csr-zp5l2   8m40s   kubernetes.io/kubelet-serving                 system:node:lab-5jjb9-master-0                                              Approved,Issued
the output of the gather command is to big to paste it here what are you looking for
bootstrap vm is deleted every time

Do you have dropbox or similar you can put that logfile in?

Do you have dropbox or similar you can put that logfile in?

sure
https://www.dropbox.com/s/w09xr5js43btt29/gather.txt?dl=0

There should have been a directory created that you need to tar/gzip up...  That's what you need to put there:

There should have been a directory created that you need to tar/gzip up... That's what you need to put there:
(https://docs.okd.io/latest/support/gathering-cluster-data.html#support_gathering_data_gathering-cluster-data)

got it i just upload it
https://www.dropbox.com/sh/5vme5hm379excb9/AAAtfJnhJuIlEvsF7G8qpNcBa?dl=0

Bootstrap log
$ openshift-install --dir=/home/okdadmin/okd4lab/vsphere wait-for bootstrap-complete --log-level=debug
DEBUG OpenShift Installer 4.5.0-0.okd-2020-10-15-235428
DEBUG Built from commit 63200c80c431b8dbaa06c0cc13282d819bd7e5f8
INFO Waiting up to 20m0s for the Kubernetes API at https://api.lab.okd.local:6443...
INFO API v1.18.3 up
INFO Waiting up to 40m0s for bootstrapping to complete...
DEBUG Bootstrap status: complete
INFO It is now safe to remove the bootstrap resources
INFO Time elapsed: 0s

can you post the installer log?   should be <install_dir>/.openshift_install.log

I'm looking at my config:
compute:
- hyperthreading: Enabled
  name: worker
  replicas: 3
  platform:
    vsphere:
      cpus: 4
      coresPerSocket: 1
      memoryMB: 24576
controlPlane:
  hyperthreading: Enabled
  name: master
  platform: {}
  replicas: 3

Other than memory, the only difference is coresPerSocket: 1
Can you try that rather than coresPerSocket: 4

Yes that not the issue
for some reason the installer is not creating the worker nodes, but also the cluster is not getting ready the ingress project never comes up :( i will stop here at least the UPI is working

Here's your issue.
There are a bunch of these in must-gather.local.331163555932549138/quay-io-openshift-okd-content-sha256-5a9b4b4cdd15e8587d02490cf753c385213e6a97e5c2bf7babf416585e42fd70/namespaces/openshift-machine-api/pods/machine-api-controllers-6c4f6c6dc8-vd8x5/machine-controller/machine-controller/logs/current.log:
namespaces/openshift-machine-api/pods/machine-api-controllers-6c4f6c6dc8-vd8x5/machine-controller/machine-controller/logs/current.log:2020-11-24T21:13:43.289573655Z E1124 21:13:43.289519       1 controller.go:272] lab-5jjb9-worker-v9sp8: failed to check if machine exists: lab-5jjb9-worker-v9sp8: failed to create scope for machine: failed to create vSphere session: error setting up new vSphere SOAP client: Post https://sacla300.sac.flex.com/sdk: dial tcp: lookup sacla300.sac.flex.com on <IP_ADDRESS>:53: no such host
It can't find your vSphere host in DNS

Here's your issue.
There are a bunch of these in must-gather.local.331163555932549138/quay-io-openshift-okd-content-sha256-5a9b4b4cdd15e8587d02490cf753c385213e6a97e5c2bf7babf416585e42fd70/namespaces/openshift-machine-api/pods/machine-api-controllers-6c4f6c6dc8-vd8x5/machine-controller/machine-controller/logs/current.log:
namespaces/openshift-machine-api/pods/machine-api-controllers-6c4f6c6dc8-vd8x5/machine-controller/machine-controller/logs/current.log:2020-11-24T21:13:43.289573655Z E1124 21:13:43.289519 1 controller.go:272] lab-5jjb9-worker-v9sp8: failed to check if machine exists: lab-5jjb9-worker-v9sp8: failed to create scope for machine: failed to create vSphere session: error setting up new vSphere SOAP client: Post https://sacla300.sac.flex.com/sdk: dial tcp: lookup sacla300.sac.flex.com on <IP_ADDRESS>:53: no such host
It can't find your vSphere host in DNS

Thank you i really appreciate that you take the time to review the logs i was also doing that, i think i know why is that happening i will apply a workaround a retry rebuild

You're welcome!
I'm learning too and it give me the opportunity to deep dive into issues to better understand the systems...

Were you able to resolve the DNS issue and complete the install?

Were you able to resolve the DNS issue and complete the install?

yes adding internal forwarder fix the issue

awesome!  good luck!

/open
I think this issue should be reopened. I had misconfigured DNS (vcenter DN was not getting resolved) but the installer worked fine until it was time to create the worker nodes, which AFAIK is done by the master nodes.
This means the installer uses a different DNS VS the master nodes, the installer IMO should run a dig vCenter.url at the beginning and stop in case the resolution fails.
cc @mariosomma

/open
I think this issue should be reopened. I had misconfigured DNS (vcenter DN was not getting resolved) but the installer worked fine until it was time to create the worker nodes, which AFAIK is done by the master nodes.
This means the installer uses a different DNS VS the master nodes, the installer IMO should run a dig vCenter.url at the beginning and stop in case the resolution fails.
cc @mariosomma

/open

/open

/reopen

/reopen

Hi!
Thank you guys for this informative troubleshooting. I have the exact same symptoms as @bobby0724 but running in ovirt. By following the steps taken by @fortinj66 i found the likely error in the logs from
namespace: openshift-machine-api
pod: machine-api-controllser-XYXYXY
container: machine-controller
{"level":"error","ts":1613987970.6140544,"logger":"controller","msg":"Reconciler error","controller":"provdierID-controller","name":"shift-4prmr-master-1","namespace":"","error":"failed getting VM from oVirt: Failed to parse CA Certificate in file '/tmp/ovirt-ca-bundle933032459'","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/cluster-api-provider-ovirt/vendor/github.com/go-logr/zapr/zapr.go:132\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/cluster-api-provider-ovirt/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:237\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/cluster-api-provider-ovirt/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:209\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker\n\t/go/cluster-api-provider-ovirt/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:188\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\t/go/cluster-api-provider-ovirt/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:155\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\t/go/cluster-api-provider-ovirt/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:156\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/go/cluster-api-provider-ovirt/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133\nk8s.io/apimachinery/pkg/util/wait.Until\n\t/go/cluster-api-provider-ovirt/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:90"}
I made a custom install andI pasted the oVirt CA in the file ovirt-config.yaml and my private CA in the file install-config.yaml.
I have a "base" like sub.domain.tld where i install all openshift nodes but my ovirt API is at domain.tld (both in private IP-range (<IP_ADDRESS>/16)). I have all DNS issues resolved (finally) so I can resolve hosts and IP's from both domain.tld and sub.domain.tld.
Any suggestions why there is a failure to parse my ovirt certificate?
My CA's are self signed and before when I ran code ready containers I had to give a secret with an annotation to be able to download source from my private git server but I thought that was what I was doing by adding my CA's to the custom config files before running the installation. Did I miss anything?
Regards and happy hacking,
/F

Hmm, didn't realize this was closed...
If someone stumble on this I thought I could tell what was the problem.
When giving the info in the beginning of the installation I gave the FQDN[:PORT] to my ovirt-engine. Since I gave port 443 a Certificate was presented and I was asked if I wanted to trust it or not. Since I just had given the URL to my ovirt-engine where I have my custom certificate and the cn=fqdn was correct I accepted (a little to fast it showed). I assumed the presented certificate was my installed custom certificate but it must have been either the original ovirt certificate or an installer generated cert.
However, when I answered No I was asked to paste the real cert and then it worked.
/F

https://github.com/openshift/okd/issues/386#issuecomment-733397019
I have one question on the same if DNS was the culprit how master node got created?

#386 (comment) I have one question on the same if DNS was the culprit how master node got created?

Even I have the same question. The masters created but why not Workers and when I check into the Machine config I founf the worker count as 0 against 3 replicas set in the yaml?? This is bug in IPI install.

@kulkarma you may want to create a new discussion in regards to this since this issue is closed.


Network Timeout (Status:500)

Android 3.3.0 RC1 getting intermittent Network Timeout (Status:500) errors. AFAIK my network is just fine. These errors are causing variable amounts of information to show up from my account.

Not getting these in ios on the same end-user account. I have gotten one single 401 error so far in ios testing

I'm getting server errors trying to create a device from the same SMB MC so this may not be a mobile issue

brian: renee: Restarting the VM should resolve it. (bdzim: unless you disagree). Looks like the sql problem we've seen before.
Restarted, am now no longer getting server errors.


[doc] correct spelling of composable

This change fixes a spelling error in the VictoryAxis documentation.

@mmurkidjanian Thanks!

You're so welcome. I'm using Victory for a project right now and I'm really loving it. Hopefully will contribute something more meaningful to this codebase in the near future.


Fix links in readme

Q
A

Bug fix?
no

New feature?
no

API breaks?
no

Deprecations?
no

Related tickets
fixes #53

License
Apache 2.0

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


fix a glitch on blur transition effect

As described issue #174

Thanks, I will test it and merge it asap. :)

Thanks a lot for this PR.
Sorry for delay.


Unify FixedTime and Time (proof-of-concept)

PULL REQUEST ONLY FOR DISCUSSION, NOT MERGE READY BY FAR.
Objective
Current FixedTime and Time have several problems. This pull aims to fix many of them at once.

If there is a longer pause between app updates, time will jump forward a lot at once and fixed time will iterate on FixedUpdate for a large number of steps. If the pause is merely seconds, then this will just mean jerkiness and possible unexpected behaviour in gameplay. If the pause is hours/days as with OS suspend, the game will appear to freeze until it has caught up with real time.
If calculating a fixed step takes longer than specified fixed step period, the game will enter a death spiral where rendering each frame takes longer and longer due to more and more fixed step updates being run per frame and the game appears to freeze.
There is no way to see current fixed step elapsed time inside fixed steps. In order to track this, the game designer needs to add a custom system inside FixedUpdate that calculates elapsed or step count in a resource.
Access to delta time inside fixed step is FixedStep::period rather than Time::delta. This, coupled with the issue that Time::elapsed isn't available at all for fixed steps, makes it that time requiring systems are either implemented to be run in FixedUpdate or Update, but rarely work in both.
If you're fixing a specific issue, say "Fixes #X".

Solution

Add a maximum delta time that can limits how much can be added to the virtual game clock by a single frame update. This also limits how many fixed update periods are run per frame.
Make Time report "fixed step clock" time while inside FixedUpdate.

...

Add maximum_delta to Time that limits how much the virtual game clock can be advanced with a single update. Does not affect raw clock.
Move FixedTime::period to be Time::fixed_period and remove FixedTime structure entirely.
Make Time::delta, Time::elapsed and friends report time according to fixed steps inside FixedUpdate.
Implementation detail: Separate out Clock data structure to make it more obvious what the independent tracked values are and to reduce code duplication.

Changelog

This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section.

What changed as a result of this PR?
If applicable, organize changes under "Added", "Changed", or "Fixed" sub-headings
Stick to one or two sentences. If more detail is needed for a particular change, consider adding it to the "Solution" section

If you can't summarize the work, your change may be unreasonably large / unrelated. Consider splitting your PR to make it easier to review and merge!

Migration Guide

This section is optional. If there are no breaking changes, you can delete this section.

If this PR is a breaking change (relative to the last release of Bevy), describe how a user might need to migrate their code to support these changes
Simply adding new functionality is not a breaking change.
Fixing behavior that was definitely a bug, rather than a questionable design choice is not a breaking change.

Closing in favor of #8964


[backport] Fix to work with scheduled FlexCI job

Backport of #4929

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit e87f4474e70945bececaa4307c463669b3933d9b, target branch v8) failed with status FAILURE.

Stopped Jenkins, I'll merge after Windows CI pass


obsolete GO:0031668, GO:0009991; Fixes #27020

Hi @edwong57
I think you redid this? Can we just close this PR (without merging) ?

Yes, we can close this without merging.


[Investigation] Sanitize Hardcoded Resources

I'd like for us to take a moment when we get a moment to investigate all resource we create during the flow of the ODH Dashboard.
QE has found that some resources have a prefix of odh and when they build it downstream for RHODS it does not get a more appropriate name (https://issues.redhat.com/browse/RHODS-4963)
A quick investigation of our create calls and manifest files should yield an answer to which resources are not configurable by deployment.

Moved to https://issues.redhat.com/browse/RHOAIENG-1245


Contribution and Community

Hello Aidymouse,
I really like the Project and would be interested in contributing. Do you thought about creating a dedicated Discord Server to make organisation around the project a bit easier?

Hi there!
Sorry I took so long, University started again and I got busy.
However, I have set up a preliminary discord, you can join here: https://discord.gg/Jvws27VmWR
Looking forward to working with you!


Integrate Android build into Makefile

Library for Android can now be built with make. ANDROID_NDK_HOME needs to point to whetever android-ndk is installed. Same variable is used for Android Studio so there is a chance that it will be already configured. I also added support for arm64 arch, it is common now on newer phones, and support for clang.
Currently build fails with clang:
audio.c:197:6: error: conflicting types for 'IsAudioDeviceReady' bool IsAudioDeviceReady(void)      ^ ./raylib.h:930:12: note: previous declaration is here RLAPI bool IsAudioDeviceReady(void);                                  // Check if audio device has been initialized successfully            ^ audio.c:526:6: error: conflicting types for 'IsSoundPlaying' bool IsSoundPlaying(Sound sound)      ^ ./raylib.h:944:12: note: previous declaration is here RLAPI bool IsSoundPlaying(Sound sound);                               // Check if a sound is currently playing            ^ audio.c:917:6: error: conflicting types for 'IsMusicPlaying' bool IsMusicPlaying(Music music)      ^ ./raylib.h:958:12: note: previous declaration is here RLAPI bool IsMusicPlaying(Music music);                               // Check if music is playing            ^ audio.c:1073:6: error: conflicting types for 'IsAudioBufferProcessed' bool IsAudioBufferProcessed(AudioStream stream)      ^ ./raylib.h:969:12: note: previous declaration is here RLAPI bool IsAudioBufferProcessed(AudioStream stream);                // Check if any audio stream buffers requires refill            ^ 4 errors generated. make: *** [Makefile:305: audio.o] Error 1
Same will happen with src/android and ndk-build when newer version of ndk is used, clang is now default, unless NDK_TOOLCHAIN_VERSION is set in Application.mk or is exported, to for example 4.9. Then it will use gcc for build.
Example:
ANDROID_NDK_HOME=/opt/android-ndk make PLATFORM=PLATFORM_ANDROID ANDROID_ARCH=ARM64

This should fix #202

Hey @gen2brain! Amazing work! Really impressed! Congrats! :D
I see you are still doing some changes, please, let me know when I can merge!

Thanks! You can merge now.
I will try later to add support for i686-w64-mingw32 now that CROSS_COMPILE variable exists.


qlog when packets are dropped due to unsupported QUIC version

Codecov Report

Merging #2483 into master will increase coverage by 0.00%.
The diff coverage is 87.50%.

@@           Coverage Diff           @@
##           master    #2483   +/-   ##
=======================================
  Coverage   85.80%   85.80%
=======================================
  Files         123      123
  Lines        9442     9445    +3
=======================================
+ Hits         8101     8104    +3
  Misses        994      994
  Partials      347      347

Impacted Files
Coverage Δ

server.go
83.49% <0.00%> (ø)

internal/wire/header.go
91.43% <100.00%> (ø)

session.go
74.07% <100.00%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae1a13...f58eb47. Read the comment docs.


PT#149703867 standardjs/eslint swap

https://www.pivotaltracker.com/story/show/149703867
What just happened? https://standardjs.com/rules.html
A ss to demonstrate error reporting is as normal, browser and server console still show offending code

A ss showing we still build and run correctly (notice that url), ALSO super important 😆

cc @martinpovolny @dclarizio @himdel Just wanted you to be aware of the proposed "rules" changes here that may not be consistent with the OPs UI.

@Fryguy yep did!  and posted the pr 👍 😆 💘

@AllenBW could you tweak the code coverage a bit?

@chriskacerguis I do not believe that should be done in this pr, If we end up wanting to roll the linting change back we would be decreasing code coverage.

Spoke to @AllenBW and I agree with your above comment.


Lower quality audio enhancement in comparison to eqMac2

I finally got eqMac2 to work on my computer after upgrading to Catalina, and though it still has the known bugs on master (most notably audio blasting maximum volume on my headphones), the audio enhancement overall is awesome. I decided to give the newest version a shot, but noticed that the audio output seemed off. I unfortunately don't have the musical vocabulary to describe what I'm experiencing effectively, but I'll try. I experienced the following:

Bass sounded less "full" and introduced somewhat of a buzzing sound
Manipulating any of the sliders in the advanced settings also introduced a weird background noise
Even with no EQ settings enabled, having any audio go through eqMac seemed to make the output almost sound like it was traveling through some kind of layer that was dampening the sound.

Not sure if this is helpful, but just thought I should put it out there in case someone else could come up with a potential fix, describe their experiences, or tell me if there are some troubleshooting steps here.
Thanks all! Great work to @nodeful and anyone else who has contributed so far. You're doing awesome work.

Ok, so the way eqMac2 and the new eqMac works with the device volume is completely different. With eqMac2 I was putting the Hardware volume of your device to 100% and artificially lowering the Software volume to the desired amount. This allowed me to squeeze in more frequency volume without it going distorted. Unfortunately, this introduced bugs like that pesky volume spike if the app crashes. To mitigate that I had 2 options. Either build a Helper app that would act like a failsafe to keep the volume down if main app crashes, but what if the Helper app crashes as well? I have decided instead to give the full control of volume to the user. So to imitate eqMac2 audio quality here's what you need to do:

Set volume to 100%
Compensate the volume increase by moving the "Global Gain" slider in the Advanced EQ down to a desired volume.
Then increase the bass frequency to the desired amount.

I have built it a volume pull back logic if you are quitting the app, but in case the app crashes I have to warn you, you might get 100% volume blasting into your ears.
All of this is expected behaviour of not just eqMac, but Boom, iTunes EQ and others. So not much that can be done here. Just a Hardware limit you have to work around.

Hey everyone 👋
I will be open sourcing the new version of eqMac, therefore, I am closing this issue and repository as I will be transfering nodeful/eqMac2 repo to bitgapp/eqMac
Please bear with me for the next couple of days as I setup that new repo. The eqMac2 code will be living in the old-eqMac2 branch if anyone is interested in referencing it for whatever reason.
Please try out the new version and report bugs to the new repo.
Thanks for using eqMac.


Add v1.0.0-beta.5 release annoncement

Work for this issue will begin begin on branch work-liquid-labs/cloudsite/187.


feat: adds octuple badge, use badge in tabs

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@57ff803). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage        ?   82.58%
=======================================
  Files           ?       44
  Lines           ?     1074
  Branches        ?      444
=======================================
  Hits            ?      887
  Misses          ?      183
  Partials        ?        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ff803...6a4ac1e. Read the comment docs.


Issue when executing 'what-depends-on' command

Hi,
I'm trying execute following command:
sbt "project my-project" what-depends-on org.scalamacros quasiquotes_2.10.3 2.0.0-M3

but I faced with following error message:
[error] Not a valid command: what-depends-on
[error] Expected whitespace character
[error] what-depends-on
[error]                ^

Symbol '^' points on the symbole after "-on".
Command "sbt "project my-project" dependency-tree" works fine.

Using "sbt-dependency-graph" % "0.8.2" with sbt 0.13.13, java  1.8.0_102-b14 on Babun Cygwin on Windows7. Trying to get "what depends on" on a multi-project build, using Ivy for dependency management, getting exception and no output.
sbt "what-depends-on org.slf4j slf4j-api 1.7.21"
Getting this exception for each project of my multi-project build:
java.util.NoSuchElementException: key not found: ModuleId(com.myCo.myProj,myProj-some-name,0.0.+)
I can provide the stack trace (all 400 lines of it).
The projects all compile, i.e. "sbt compile", "sbt package" all work.
What am I doing wrong / how can I fix this?

Thanks, @radumanolescu. More stack trace would be helpful. You may also open a new issue for that.


Stop reconciling resources if envoy gateway is nearly out of memory

@envoyproxy/gateway-maintainers should we consider something like envoy's overload manager  where we stop reconciling more resources (flag this in a GatewayClass status) in case we hit some specified memory threshold ?
Originally posted by @arkodg in https://github.com/envoyproxy/gateway/issues/2265#issuecomment-2228934265

Hi @arkodg!
I would like to work on this if this feature is accepted
Let me know :)

thanks for looking into this one !
the next steps here before raising a PR is designing this (doesnt need to be a design doc), but can hopefully answer these questions

a lightweight way to compute remaining mem (total - current)
deciding on the default mem threshold when this kicks in (can resuse the same logic applied to envoy proxy)
how to stop reconciling the k8s controller ? is this enough to safely prevent OOM for the control plane ?
how to surface this to the user ? a status in all GatewayClasses ?


Problem with EmbeddedDocumentSerializers

Problem description
When there is an embedded serializer field defined in the root document serializer, DRF's BaseSerializer will throw a "Cannot call .is_valid() as no data= keyword argument waspassed when instantiating the serializer instance." AssertionError in is_valid method, create use case, based on the following assertion:
        assert hasattr(self, 'initial_data'), (
            'Cannot call `.is_valid()` as no `data=` keyword argument was'
            'passed when instantiating the serializer instance.'
        )

The first that comes to mind is that the following code in DocumentSerializer is failing to set the required property:
    def is_valid(self, raise_exception=False):
        valid = super(DocumentSerializer, self).is_valid(raise_exception=raise_exception)
        for embedded_field in self.embedded_document_serializer_fields:
            embedded_field._initial_data = self.validated_data.pop(embedded_field.field_name, serializers.empty)
            valid &= embedded_field.is_valid(raise_exception=raise_exception)
        return valid

Changing _initial_data to initial_data seems to fix the issue (looks like that only initial_data is used by BaseSerializer in DRF3), though I'm not sure of the consequences...
Test case:
# models:

class EmbeddedTest(EmbeddedDocument):
    int_field = IntField()

class Test(Document):
    string_field = StringField()
    dynamic_field = EmbeddedDocumentField(EmbeddedTest)

# serializers:

class EmbeddedTestSerializer(EmbeddedDocumentSerializer):

    class Meta:
        model = EmbeddedTest
        depth = 1

class TestSerializer(DocumentSerializer):
    dynamic_field = EmbeddedTestSerializer(many=False)

    class Meta:
        model = Test
        depth = 1

Thanks for pointing that out. Which version of DRF are you using?

I'm using DRF 3.0.4 (latest)

Additionally, I think there may be a problem with this block of code in DocumentSerializer, in a scenario where EmbeddedDocumentSerializer is explicitely defined as a field:
for embedded_field in self.embedded_document_serializer_fields:
    embedded_field._initial_data = self.validated_data.pop(embedded_field.field_name, serializers.empty)
    valid &= embedded_field.is_valid(raise_exception=raise_exception)

I'm not 100% sure, but I think what happens is that the serializer is registered both as a field and in embedded_document_serializer_fields property of the parent serializer (in the get_fields method), resulting in the validation being run twice. The first time it's called as a result of calling is_valid on a root DocumentSerializer (from run_validation), with raw data dict ("normal" DRF flow). The second time the validation is run by calling is_valid directly on the embedded serializer with the data that I think is already validated and passed as OrderedDict. The latter is a bit of an issue, imho.

Please check the issue with current trunk.

embedded validation should work now