refactor(Combinatorics/SimpleGraph): remove sndOfNotNil in favour of getVert 1

This allows to leave out the not-nil hypothesis, in addition to not needing it for
the definition of tail.

[x] depends on: #14977

Per discussion here

Just force-pushed after rebasing because of the #14977 merge:)

Thanks!
maintainer merge

Thanks!
bors merge


use flag instead of mitchellh/cli, set version at build time

ditched the cli library and moved all commands into their own file
moved VERSION from pkg/transporter/pipeline.go to cmd/transporter/main.go as a variable that will get set with ldflags
added new build script so we can start publishing static binaries for most archs

fixes #237

Coverage increased (+0.5%) to 53.409% when pulling 902df7179a1d435f7650eb28df1953384b6ceac8 on 237-version-from-build into 1dc0c3d305b55c3b05be1d42d1a95c6d76669780 on experimental.

Coverage increased (+0.5%) to 53.409% when pulling 1ca367e037d552352987cb22fdb70b9a0b851bc6 on 237-version-from-build into 1dc0c3d305b55c3b05be1d42d1a95c6d76669780 on experimental.

Coverage increased (+4.8%) to 57.641% when pulling c40c82046a2c1d13c28f072432bfc86d81d1eae5 on 237-version-from-build into 1dc0c3d305b55c3b05be1d42d1a95c6d76669780 on experimental.


Mitigate sending out stale offers due to missing offer update

With the recent change of automatically re-broadcasting offers from the given parameters, it can happen that the price gets stale if the automation fails to provide a new one.
Suggestion solution:
Extend the offer params endpoint with an "expiry" timestamp. The daemon is allowed to re-broadcast offers based on these parameters until that timestamp and has to stop otherwise. This ensures that - in case the automation fails to provide updated offer parameters - we stop sending out offers eventually.

an alternative way, arguably cleaner: the automation should be smart enough to adjust the OfferParams to withdraw the prices if they got stale by setting them to None.

The path on which we got to this problem was that the automation somehow failed internally and stopped updating the OfferParams. In that case, any logic that would detect a "stale" offer would likely also not have worked.

still, it sounds to me like an automation bug that could be fixed there! We could look at the timestamp of the offers when looking at them and prompt a refresh at certain interval (or at least triggering some error if they didn't get updated for longer). Right now the automation doesn't even verify that an offer got publish / updated at all on the feed.

Yes, it is a bug that can & should be fixed there. However, I think the proposed solution is still an improvement worth having because it makes client implementations simpler.
Any state that we don't need to keep track of in the client is good. Passing an expiry timestamp to the offer params allows the daemon to reason about these parameters without another interaction of the automation. Requiring the automation to follow up with this is tedious to implement and error prone. I'd rather empower the daemon to do this reasoning itself. This goes towards https://github.com/itchysats/architecture/issues/17.
Additionally, we can extend the implementation to automatically withdraw sent out offers from takers if that expiry timestamp is hit. We currently don't do that which is dangerous because it means an offer is basically valid forever.

@klochowicz What is your latest take on this issue? Are you strongly against the proposed solution or can we implement it as described and see how it performs?

I feel like this proposal goes against ADR003 - for me this is a concern of the automation / UI. Furthermore, this makes the maker implementation less simple.
As for the rest of the arguments, you don't need to keep track of timestamps or anything really - if you don't get price updates for X seconds, you send None immediately to indicate that you can't figure out new price. This makes things simple and robust IMHO.

That said, I don't mind a short-term fix until we fix automation if we don't trust it to react (until we make it more robust) :-)

I feel like this proposal goes against ADR003 - for me this is a concern of the automation / UI. Furthermore, this makes the maker implementation less simple.

If this proposal violates ADR003, wouldn't the original change of immediately sending out a new offer also already violate that decision?
The concept of a TTL is fairly design component and IMO naturally fits this problem. If we delegate the power of sending out new offers to the maker, why not also tell it in one go, when to stop doing that?

I don't think it's the case, because the decision to start/stop the flow of offers lies outside the maker - I see it more like an ergonomics change.
to me adding TTL here feels like a hack because we are not in any place at the time to perform a guess when sending out an offer (unless bitmex is actually sending us TTL of their price feed?). The correct answer for this question for me is "until the price feed gets stale".
Again, I'm happy for this to come through if this will plug a hole and buy us some time until we make automation more robust!

to me adding TTL here feels like a hack because we are not in any place at the time to perform a guess when sending out an offer

I think we are totally in place to make that decision. ADR003 specifies that an outside component like an automation bot is in charge of the business rules around price making like spreads etc. Those decisions are associated with how much risk you want to take in regards to volatility of the market and whatever you want really.
Being able to provide a TTL together with a price a form of managing this risk. It is saying: "Here are some offer parameters and I am confident that my underlying trading strategy will be profitable with this parameters for the next 2 minutes." If the market changes, new parameters are handed over. If the market doesn't change, you need to still refresh them. If for any reason, we are not able to refresh them, the TTL provides a safety switch to stop trading precisely because the daemon is in no position to make a decision on whether the current offer parameters are any good.
Now that I think about, I'd say this is actually perfectly in line with ADR003.

The reason I dislike this is that this business decision can be achieved already by the existing API, and achieving the same thing by multiple ways in an API is not a good design practice.
You can do precisely that strategy with the current API, because there are means of withdrawing offers when the risks become too much.

The reason I dislike this is that this business decision can be achieved already by the existing API, and achieving the same thing by multiple ways in an API is not a good design practice.

I see that point and I agree with it.

You can do precisely that strategy with the current API, because there are means of withdrawing offers when the risks become too much.

What if that is not possible because the automation bot dies for example? There is a risk in that as well.

to me adding TTL here feels like a hack because we are not in any place at the time to perform a guess when sending out an offer (unless bitmex is actually sending us TTL of their price feed?).

Re bitmex TTL: Bitmex price feed does not have a TTL because it does not give you any guarantees about the price. On the contrary, it's logical that it can't because it is a marketplace and not a centralized broker.
The price we get from Bitmex might have never been a "real" price neither: we get the 1 minute bucket price which is the average of the bids/asks at a specific minute. Bitmex updates this price every minute.
So, I don't think you can compare these two things :)

The correct answer for this question for me is "until the price feed gets stale".

Some time ago we added this feature where we resend the same order again if an offer was accepted or rejected. Would you remove this?
Personally, I would add a TTL and leave the current behavior. Imho this is a good feature to have, as also the taker can make use of this feature: I can only take an offer within the TTL

Note: Some mitigation achieved by #1658
We also found the bug in the automation and fixed it https://github.com/itchysats/maker-automation-rs/pull/88
We should still evaluate ensuring sanity in the maker daemon.

Does not happen at the moment.


Eager Load Results In Null Collection If No Items Present

Given a setup like this:
public class SomeItem
{
	public Guid Id { get; set; }

	public ICollection<OtherThing> OtherThings { get; set; }

	protected override void OnModelCreating(EntityTypeBuilder<SomeItem> entity)
	{
	}
}

public class OtherThing
{
	public Guid Id { get; set; }

	public Guid SomeItemId { get; set; }

	public SomeItem SomeItem { get; set; }

	protected override void OnModelCreating(EntityTypeBuilder<OtherThing> entity)
	{
		entity.HasOne(e => e.SomeItem).WithMany(e => e.OtherThings).HasForeignKey(e => e.SomeItemId);
	}
}

public void QueryItems()
{
	var item = dbContext.SomeItems.Include(s => s.OtherThings).FirstOrDefault(); // Returns an item for sake of example
	item.OtherThings // this is null instead of empty collection.
}

We see a collection being null when it should be an empty collection from what I can gather.
Am I missing something or is this a bug?
Workaround is to initialize the ICollection in the constructor, but it seems like I shouldn't have to.

@StrangeWill I am not able to reproduce this. Which version of EF Core are you using?

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.


spastic pseudosclerosis

Mondo term (ID Label)
spastic pseudosclerosis
https://www.ebi.ac.uk/ols/ontologies/mondo/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FMONDO_0010050
Bug/Typo/Error description
This is a legacy entry in OMIM
https://omim.org/entry/270900
it does not provide an adequate description of a disease, and so it should be retired.
@ahamosh Possibly there should be a special place in OMIM for entries like this that do not provide enough information for anybody today to figure out if a patient has the disease in question? I realize OMIM does not like to retire entries, but since people use the counts of OMIM entries to estimate the number of genetic diseases, it would be good to put this in some separate category. The HPO keeps a list of "legacy" entries like this which we would be happy to share.
Your nano-attribution (ORCID)
If you don't have an ORCID, you can sign up for one here

microcolon is another example of this
MONDO:0009628
it should also be obsoleted.


Make Travis automatically open a special issue in case of failing master

What is the expected enhancement?
The current merging process has a bottleneck explained on #927. One of the solutions involves targeting only one Python version for only one platform during regular merges and complete with a periodic build for testing the complete environment matrix.
For implementing this, we want some way to highlight when the cron build is failing for some reason. We opted for instructing the CI to open an issue in the repository. The following format is provided as a reference and open for dicussión:
Title: Master is failing in <CI name> at <short commit hash>
Body: See details at: <link to logs in the CI>
Labels: "master failing"

Well, this is what I propose:

Let hash be the commit hash causing the failure.
On failure, CI checks if there is an open issue with the label "master failing"
If it does not exists, open a new issue with the following format:

Title: Master is failing
Body: Master is failing in commit <hash>. Check the logs at: <link to CI logs>.
Labels: "master failing"

Else, check if there is a comment containing hash.
If there is none, send a new comment with the following content:

Master is failing in commit <hash>. Check the logs at: <link to CI logs>.

@delapuente I'm personally not necessarily convinced of the value of something like this. While I agree it could definitely highlight something real that needs our attention, like a new version of dependency package broke something or we introduced a bug causing non-deterministic failures, it is equally as likely that the travis infrastructure just fell apart. I've seen many times where the container they use for testing just fails to deploy, or a network issue fails an early setup stage and the job errors before even installing the project under test. Do we want an issue automatically opened if that kind of thing happens?

I this this was closed via #1071.


Add check for tslib __await helper

This adds a missing check for the new __await helper introduced in #15521 and adds a small bit of cleanup.

@mhegazy this is now in release-2.3


Something new!

hello! it's not really a isue but you should really add minecraft 1.19 xray mod for forge! that would be really cool bec now its only for fabric.

https://www.curseforge.com/minecraft/mc-mods/xray-1-13-rift-modloader/files/3918097


Multiple signatures don't show up in adobe reader

Hey, I just updated the package from 1.4.5 to 1.5.7 and noticed an issue with signing a document multiple times. When I sign a document twice, both the signature images show up in the chrome pdf reader (and preview on mac), but when I open it in Adobe reader, only the image for the first signature shows up. This was working in version 1.4.5.
In preview -

Same document in adobe reader -

You can find this document here - https://drive.google.com/file/d/1TvW1j4t8_V-ee50R2TkEy7InmliDsFBv/view
Original document before signing - https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf
Also, another issue I noticed is that now instead of signing the document, the library certifies the document.
Earlier in adobe reader -

Now in adobe reader -

The expectation while using the library is to sign and not to certify so I'm not sure why that changed. Could this also be the reason why multiple signatures don't show up in adobe reader? Can you help me with this?

Nevermind. I realized the issue was that I wasn't passing sigfield. Passing a unique sigfield for each signature fixed the multiple signatures showing up issue. However, the first signature still always shows up as certified instead of signed. I'll open a separate issue for that.

Nevermind. I realized the issue was that I wasn't passing sigfield. Passing a unique sigfield for each signature fixed the multiple signatures showing up issue. However, the first signature still always shows up as certified instead of signed. I'll open a separate issue for that.

I'm having this problem and passing an unique value to sigfield didn't do it. Could you please show me which parameters are you passing through the dct dictionary?


update the save_grade_and_comment_for_submission method in grades_controller.rb

Sub-Issue of #2 for easier division of work, please see that issue for description.
This issue is focused on the save_grade_and_comment_for_submission  method in the grades_cointroller.

Should be able to separate this into two methods save_grade and comment_for_submission

Deemed obsolete and removed from the class. Update method will handle everything.


Problem running sample code

Hi. I have setup the library using pip and have managed to write down a simple test for MICE imputation as you have suggested in your docs. But I can not seem to get it to run. I am running the code in Pycharm 3.3 IDE in Ubuntu 17.10.
Here is my console output:
<Connected to pydev debugger (build 173.4301.16)
/home/sundus/.local/lib/python2.7/site-packages/pandas/_libs/init.py:4: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
from .tslib import iNaT, NaT, Timestamp, Timedelta, OutOfBoundsDatetime
/home/sundus/.local/lib/python2.7/site-packages/pandas/init.py:26: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
from pandas._libs import (hashtable as _hashtable,
/home/sundus/.local/lib/python2.7/site-packages/pandas/core/dtypes/common.py:6: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
from pandas._libs import algos, lib
/home/sundus/.local/lib/python2.7/site-packages/pandas/core/util/hashing.py:7: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
from pandas._libs import hashing, tslib
/home/sundus/.local/lib/python2.7/site-packages/pandas/core/indexes/base.py:6: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
from pandas._libs import (lib, index as libindex, tslib as libts,
/home/sundus/.local/lib/python2.7/site-packages/pandas/core/tools/datetimes.py:6: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
from pandas._libs.tslibs.strptime import array_strptime
/home/sundus/.local/lib/python2.7/site-packages/pandas/tseries/frequencies.py:24: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
from pandas._libs.tslibs.frequencies import (  # noqa
/home/sundus/.local/lib/python2.7/site-packages/pandas/core/indexes/datetimelike.py:28: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
from pandas._libs.period import Period
/home/sundus/.local/lib/python2.7/site-packages/pandas/core/sparse/array.py:33: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
import pandas._libs.sparse as splib
/home/sundus/.local/lib/python2.7/site-packages/pandas/core/window.py:36: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
import pandas._libs.window as _window
/home/sundus/.local/lib/python2.7/site-packages/pandas/core/groupby.py:68: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
from pandas._libs import lib, groupby as libgroupby, Timestamp, NaT, iNaT
/home/sundus/.local/lib/python2.7/site-packages/pandas/core/reshape/reshape.py:31: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
from pandas._libs import algos as _algos, reshape as _reshape
/home/sundus/.local/lib/python2.7/site-packages/pandas/io/parsers.py:45: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
import pandas._libs.parsers as parsers
/usr/local/lib/python2.7/dist-packages/h5py/init.py:36: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
from ._conv import register_converters as _register_converters
/usr/local/lib/python2.7/dist-packages/h5py/init.py:45: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
from . import h5a, h5d, h5ds, h5f, h5fd, h5g, h5r, h5s, h5t, h5p, h5z
/usr/local/lib/python2.7/dist-packages/h5py/_hl/group.py:22: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
from .. import h5g, h5i, h5o, h5r, h5t, h5l, h5p
Traceback (most recent call last):
File "/home/sundus/Documents/pycharm-professional-2017.3.3/pycharm-2017.3.3/helpers/pydev/pydevd.py", line 1668, in
main()
File "/home/sundus/Documents/pycharm-professional-2017.3.3/pycharm-2017.3.3/helpers/pydev/pydevd.py", line 1662, in main
globals = debugger.run(setup['file'], None, None, is_module)
File "/home/sundus/Documents/pycharm-professional-2017.3.3/pycharm-2017.3.3/helpers/pydev/pydevd.py", line 1072, in run
pydev_imports.execfile(file, globals, locals)  # execute the script
File "/home/sundus/PycharmProjects/untitled/test_ycimpute.py", line 6, in
from ycimpute.imputer.mice import MICE
File "/home/sundus/.local/lib/python2.7/site-packages/ycimpute/imputer/init.py", line 2, in
from ..unsupervised.expectation_maximization import EM
File "/home/sundus/.local/lib/python2.7/site-packages/ycimpute/unsupervised/init.py", line 2, in
from .expectation_maximization import EM
File "/home/sundus/.local/lib/python2.7/site-packages/ycimpute/unsupervised/expectation_maximization.py", line 2, in
from ..utils.tools import Solver
File "/home/sundus/.local/lib/python2.7/site-packages/ycimpute/utils/tools.py", line 12
fill_method: object = "zero",
^
SyntaxError: invalid syntax
Process finished with exit code 1>

Hi! I‘m sorry to reply you until now.  It seems like you're using Python2.7. ’Could you send you code to me? It would be better you put your code here, or you can send me via my e-mail address on my Github. Thanks.


How to contribute

A section of README that indicates how best to contribute to the project

What do you mean?

Great to hear from you! Will reply in detail soon.
On Wed, Jun 14, 2017 at 9:59 AM Boris Conforty<EMAIL_ADDRESS>wrote:

What do you mean?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/salathegroup/react-native-scandit/issues/1#issuecomment-308494160,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD4Pzl5QPhPZ77auMqrL28Y8uptQa-cNks5sEBFKgaJpZM4N4zdw
.

@gordonIanJ
FYI We published react-native-scandit to npm & merge over time our internal progress into the following project: https://github.com/shoplinksys/react-native-scandit
The scandit barcode scanner is very essential to us. We added a "how to contribute" section here: https://github.com/shoplinksys/react-native-scandit#contribution


Self hosted version

First, I just want to say this is a pretty cool project.  Makes playing the game much more enjoyable when you don't have to flip through the journal to narrow things down.
Second, I'm sure I'm not alone in this when I say I'd like to be able to self-host this on my own equipment.  I'm not a fan of services like Heroku and Netlify.  They have their places, but I'd hate to lose access to this program when the free tiers run out again.
I threw together a quick dockerfile that lets me build this project and host it via docker on my own server.  I'd be more than happy to create a pull request to merge that in if you'd think other people would use it.  Just a suggestion, so if you don't agree feel free to close this issue.
Thanks!

hey @tgkenney thats why its on github, please feel free to create a PR, new branch would be great. I'll review it and merge it later today

Sure thing, I just created it.  I was only able to point the PR at master, but if you want me it merged into a different branch feel free to create one and I can point the PR at that

@tgkenney Added the branch

Edited

Merged


Incorrect Permissions for mediawiki Uploads

  services.mediawiki.enable = true;
  services.mediawiki.httpd.virtualHost.hostName = "...";
  services.mediawiki.httpd.virtualHost.adminAddr = "...";
  services.mediawiki.httpd.virtualHost.enableACME  = true;
  services.mediawiki.httpd.virtualHost.forceSSL = true;
  services.mediawiki.passwordFile = pkgs.writeText "password" "...";
  services.mediawiki.extraConfig = ''
    # Disable anonymous editing
    $wgGroupPermissions['*']['edit'] = false;

    # Disable account creation
    $wgGroupPermissions['*']['createaccount'] = false;

    # Disable reading by anonymous users
    $wgGroupPermissions['*']['read'] = false;

    # But allow them to read e.g., these pages:
    $wgWhitelistRead = [ "Main Page", "Help:Contents" ];
  '';
  services.mediawiki.database.type = "postgres";

The problem is that httpd runs as wwwrun but /var/lib is owned by mediawiki.

Running chmod -R wwwrun on /var/lib/mediawiki resolves the issue -- i.e. allows image uploads to be shown/read after uploaded.


Migrate models to SQLAlchemy v2

https://github.com/bamboo-cms/bamboo/pull/6#issuecomment-1863051974
Track it here, @yuxiaoy1 would you like to make a PR?

OK, will PR later.

PR submitted https://github.com/bamboo-cms/bamboo/pull/12


Closes #275: fix certmanager version

This PR closes #275

Update certmanager version to v0.12.0-beta.1

[UPDATE]

Update certmanager version to v0.11.0

Does the previous stable release (I'm guessing 0.11.0) work too? I'd vaguely prefer to depend on a stable release, not a beta.

Thanks for this fix btw! I think this shows I need to update my version of Kind :)

Yeah it does seem that v0.11.0 does use apps/v1, I'd prefer to use that instead of a pre-release version.

/assign @rjbez17 @adrianludwin

I've updated the version of cert-manager to 0.11.0 as a stable version.
@rjbez17 @srampal  could you please review this PR ? ☺ 🙏

This is great, thanks! Can you please just do one more thing - can you please squash your three commits together into one and force-push it onto the same branch? It'll keep the history much more clear. Thanks.
/ok-to-test

@adrianludwin done ! :)

/lgtm
/approved
/hold
Thanks for this change! Let's submit after we get one more reviewer.
For future reference, in the future consider using terms like "Upgrade cert manager version" in the commit message than "Fix" since "fix" implies there was a mistake, which (in this case) there wasn't. But it's not worth holding this up for that.

Whoops:
/approve

/lgtm
/approve
/hold cancel


TypeError: Cannot read property '0' of null

Error coming after installation of release 0.1.29 - 0.1.31. I am currently using this module on localhost for development env. You have put a validation of regex for ipv4 address from version 0.1.29.
./lib/index.js  line number - 30

Have look at this and try to add the validation for localhost also.

I'm experiencing this same issue too. Thanks

It turns out that localhost becomes ::1 at this point, which means it's an ipv6 address.
I haven't tested much.
To temporarily get rid of this, just edit the regexp to
const ipv4re = new RegExp(/\d+\.\d+\.\d+\.\d+|::1$/)

For further development, consider use a regexp or some way that handles both ipv4 and ipv6 address.

My team faced the same issue even with IPv4 address.
We have Express server under IIS reverse proxy.
Value of address variable become regular IP with port like <IP_ADDRESS>:12568
So this regex fails on such kind of client IP.
Solution we use:
Downgrade ddos package, until regex disappear.
Hope this answer can help the author and anyone who face this issue

We have same issue, and we see no choice but downgrade.
Please resolve this issue in new release

@PinnacleOne @MisterHoker @hyrious @tobsbola @abhijeet2015
5bf50ea6eafb2c87026a02e6f0bc390eb3ec43df
Specifically, it now handles @MisterHoker example, as well as "::1" which is on some systems the loopback.

@lumberbeard closing this issue. Let me know if the problem still persists (and provide details of the ip failure)


Demo: Implement protobuf for RPC

Would be nice to have the example using protobuf for the inner communication between nodes. I will implement that in a separated project, if it works I will implement that on the demo, if any interest is present.

/assignme

@BohuTANG I could implement something but the implementation is TERRIBLE and I am ashamed to ever write this code.

@ppamorim
The solution that I've seen most often is to use gRPC and tonic. This will be more efficient than using HTTP like the demo is ATM. However, one major benefit of using HTTP in the current demo is that it is very easy to follow (more familiar, no codegen, etc). This is IMHO one of the main benefits with the demo: simplicity. When you want an "advanced demo" more ready for production, look at metasrv in the databend repo. That being said, adding a more efficient RPC mechanism would be nice, but I'd consider having it behind a feature flag and definitely keep the HTTP endpoints for clarity.

I tried to pick this but I cannot find any efficient way to reuse responses from existing structs(ClientWriteResponse,VoteResponse etc). Any ideas are welcome

@drmingdrmer We can close this too


Idea - Exclude similar icons (website)

I selected to download all the icons in fontello.com, but i wanted to delete all similar icons in a selection. So... i would like to appear a list of all the similar icons and i can choose a list of icons.

Selecting all icons is clearly not the purpose of Fontello – the exact opposite actually. You should only select icons that you need, not to force your users to download megabytes of unused fonts.
You could also use the search feature on the site to deselect similar icons for a specific term.


Support Intl.NumberFormat.formatToParts in ES2018

TypeScript Version:  Nightly

Search Terms:
Code
new Intl.NumberFormat().formatToParts

Expected behavior: Should be supported
Actual behavior: It requires ESNext
Playground Link: https://www.typescriptlang.org/play?target=5#code/HYUw7gBAksAuA2A6AcgVwLYCMQCcBiA9jugIawAUAlIgGZGmwAqBACiTrAM5A
See also https://github.com/tc39/proposals/blob/master/ecma402/finished-proposals.md

Hi @RyanCavanaugh Is it ok if I work on this?

Sure, I'm not working on this at least.

@RyanCavanaugh After moving Intl.NumberFormat.formatToParts to es2018.intl.d.ts, esnext.intl.d.ts remains empty. Should it be kept that way, or should it be removed completely?

You can remove esnext.intl.d.ts and make esnext.intl point to es2018.intl.d.ts in src/compiler/commandLineParser.ts.

This is in with https://github.com/microsoft/TypeScript/pull/45647 👍🏻


Enable HostCachingAlloctor

🚀 The feature, motivation and pitch
HostCachingAlloctor provides pin memory for H2D and D2H copy. Some kernels require the alloctor, E.g. copy, cat...
Alternatives
Using system memory + synchronization to ensure functionality. But it will hurt performance.
Additional context
No response

WA for Copy.
https://github.com/intel/torch-xpu-ops/pull/127

XPU HostCachingAlloctor PR of PyTorch,
https://github.com/pytorch/pytorch/pull/123080

Done.


Remove donate app from RTD itself

This splits out the donate app from RTD, so that we don't ship our ad code to all the OSS users who don't care about it.
The actual changes are at the bottom, just some URL adjustments.

🎆


Replace rimraf through del

import del from 'del';

import * as config from './config';

export default function clean() {
    return del(config.PATH.clean, {force: true});
}

In my opinion, this is too complex an approach to replace rimraf.


Add sane behaviour to the Android back button

To start with, we add, to most of the views that include a
panel/overlay/dialog, an opened property that simply states whether
that panel is active and a close method that closes the panel.
For the invite-user view, we use the method back instead of close.  In
this case, there are multiple different panels that it might have open
instead of being the main panel itself and we want to make sure we close
the correct (active) one only.
In order to handle the overall functionality of the back button, we now
listen in root.ts for the backbutton core signal.  Our handler there
then cycles through the possible things that could be the top-level
element and closes whichever one that is.  If there is nothing else
open, we close the entire app with a new method that's been added to the
browser api.
Also, as a result of this change, a lot of elements that previously
handled sending open events to their direct children now do so via just
calling the open method on the child element.  It's a lot cleaner and
will hopefully remove some (rarely-suffered) overhead.
Fixes #2440

This change is

Should advanced-settings.ts and feedback.ts also be edited?

In what way?
On Thu, Aug 4, 2016 at 1:54 PM Nirvan Tyagi<EMAIL_ADDRESS>wrote:

Should advanced-settings.ts and feedback.ts also be edited?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/uProxy/uproxy/pull/2642#issuecomment-237631130, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA3G7mzy4gLqIkJGg8pm40nK9OLfG6hOks5qcic4gaJpZM4Jc6Cd
.

Review status: 0 of 14 files reviewed at latest revision, 2 unresolved discussions.

src/cca/app/scripts/cordova_browser_api.ts, line 350 [r1] (raw file):

  public exit = () => {
    (<any>navigator).app.exitApp();

Since we want to preserve state and keep running while in the background, this seems ... less than ideal.

src/interfaces/browser_api.ts, line 58 [r1] (raw file):

  respond(data :any, callback ?:Function, msg ?:string) :void;

  /* exit uProxy completely */

I think this comment needs more explanation, and possibly // style to match other comments here.

Comments from Reviewable

Review status: 0 of 15 files reviewed at latest revision, 2 unresolved discussions.

src/cca/app/scripts/cordova_browser_api.ts, line 350 [r1] (raw file):
Previously, bemasc (Benjamin M. Schwartz) wrote…
> Since we want to preserve state and keep running while in the background, this seems ... less than ideal.

I found a Cordova plugin that should fix this, let me know if this looks better.

src/interfaces/browser_api.ts, line 58 [r1] (raw file):
Previously, bemasc (Benjamin M. Schwartz) wrote…
> I think this comment needs more explanation, and possibly `//` style to match other comments here.

Done.

Comments from Reviewable

:+1: with one nit.


buildah: 1.9.0 -> 1.10.1

Motivation for this change
Update buildah to the latest version and adapt the package regarding it.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @vdemeester @Profpatsch

@GrahamcOfBorg build buildah

@GrahamcOfBorg build buildah


gsoler2 Acrolinx quality push: ad-fs-single-sign-on-settings.md

#assign: @robinharwood, @Xelu86
@robinharwood @Xelu86
Can you review the proposed changes?
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

No material changes, closing.


Raunak/testnet fixes

PR to address handling errors in onRecvPacket callback, and to fix the encoding to/from UniversalChannelPackets


Solitaire Rewards Too High

Hi @lanctot , first of all this is amazing collaborative effort! Thanks for this library.
I tried training DQN with Solitaire in Pytorch by tweaking the code here but the rewards are too high that my Q-values becomes NaN. Is there any way to resolve this?
Is rescaling the rewards a good option? If yes, how should I rescale them.
Any help would be really appreciated!
Thanks

Hmm, looking at the solitaire max reward: https://github.com/deepmind/open_spiel/blob/dbfb14322c8c3ebc089310032a56bfaed0dc4c01/open_spiel/games/solitaire.cc#L1556
That is a higher range than a lot of the other games. I am still surprised that you get NaNs though.
Maybe the learning rate is too high? I would first try tuning down the learning rate of your DQN agent (lower, maybe try 0.001 or 0.0005) because if that works then you don't have to modify the game.
But otherwise yes, you can also always transform your rewards to [0,1] by doing (game.min_utility() + reward) / (game.max_utility() - game.min_utility()).

Hi @lanctot, thanks for your response.
I implemented both of your suggestions and started training. I was wondering if someone has trained Solitaire before and if yes, how much reward they got after training?
Thanks.

I have not run it myself nor anybody in our team.
I will tag the original author of the game: @tyjch. Maybe they will have a better answer for you.

Hi @tyjch, can you please look into this. Also, if you did train then how did you modified your rewards so that the training becomes stable. I'm unable to get good results with DQN for rewards in [0,1].

@nileshop22 @tyjch I'd love to see an implementation example for solitaire as well!


Code inconsistency

@xzdandy What happens if the table already exists? This raised an issue that I did not notice before. I was using if_not_exists in the load executor. In mat executor, we can use handle_if_not_exists because the catalog entry is created in the mat executor. But this is not the case for the load operator, the catalog entry is created before the load executor. I think we shall choose one way for both of them. And update the mat, load design, and this creates (e.g., doc what happens the table exists, remove **kwargs, add a call to check whether a table exists or can we use read to do it?)

After discussed with Gaurav, we will move the load binder logic into the executor.


Add wrapper for files API

Codecov Report

Merging #233 (295285f) into main (152360f) will decrease coverage by 0.00%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
- Coverage   68.25%   68.24%   -0.01%
==========================================
  Files         101      103       +2
  Lines        5912     5921       +9
  Branches      434      435       +1
==========================================
+ Hits         4035     4041       +6
- Misses       1761     1764       +3
  Partials      116      116

Impacted Files
Coverage Δ

pyEX/files/files.py
28.57% <28.57%> (ø)

pyEX/premium/valuengine/__init__.py
80.00% <66.66%> (+30.00%)
:arrow_up:

pyEX/__init__.py
95.23% <100.00%> (+0.11%)
:arrow_up:

pyEX/client.py
28.81% <100.00%> (+0.30%)
:arrow_up:

pyEX/files/__init__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 152360f...7f5c894. Read the comment docs.


Nextcloud backup is executed twice every night

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
First observed in 22.1, but issue is also available in the recently released version 22.7.
I have specified a cronjob at:   1:30am to backup my Opnsense to a Nextcloud account.
When I now look at Nextcloud, I see that all backups are executed twice:   at 1:00am, and also at 1:30am.
To Reproduce
Steps to reproduce the behavior:

Go to 'System --> Configuration --> Backups'
Scroll down to 'Nextcloud' section
Configure connection to Nextcloud instance (username, password, URL, ...).
Click 'Setup/Test Nextcloud'Go to 'System --> Settings --> Cron'
Click on '+' to add a new cron job
Scroll down to 'Command' and select 'Remote backup' from the LOV
Save.
Login to Nextcloud URL and observe backups created.

Expected behavior
Only a single backup exactly at the time where the cron job is specified in the GUI.
Describe alternatives you considered
Nothing
Screenshots
Screenshot 1:   Cron settings

Screenshot 2:   backup file results on Nextcloud

Topic also raised in the forum, but no response so far:
https://forum.opnsense.org/index.php?topic=29621.0
Relevant log files
If applicable, information from log files supporting your claim.
Additional context
Add any other context about the problem here.
Environment
Software version used and hardware type if relevant, e.g.:
Virtualized OPNsense 22.7 (amd64, OpenSSL) in a KVM machine on Proxmox 7.2.7
Intel® Core i7-4900u,  8GB RAM

There is an automatic nightly cron job as documented. If you need more cron jobs that is what the manual one is for. I don't think running two closely together and then adding a ticket brings much to the table?
Cheers,
Franco

Hi Franco,
can you please point me to the documentation? -- Neither in the "Cloud Backup" section do I read something about 1:00am, nor in the "Cronjob" section of the documentation.
Apologies for raising this.  This was non-obvious to me.
What I now understand:   I will remove the Cronjob at 1:30am, and I will then magically get only a single cloud backup per day, at 1:00am.
Thank you.

Maybe such a hint should be added in the description of the plugin: "do not create a cronjob; OPNsense will take care for this already."

It's in the git-backup documentation it mentions "nightly" keeping the the of the cron job adjustable. https://docs.opnsense.org/manual/git-backup.html?highlight=nightly
In the NextCloud/Google documentation it's mentioned "per day". https://docs.opnsense.org/manual/how-tos/cloud_backup.html?highlight=day
I don't mind improving those but documentation is often there when people say they can't find it. ;)

Thanks, Franco.
To which extend is now the git-backup applicable for my reporting? -- I do not even have this installed.
So, I am gonna close this as issue since it is all working as designed, despite being hard-coded to 1:00am at the moment.
Another suggestion how to improve this:   display the hard-coded cronjobs in the cronjobs view, maybe greyed-out, such that users cannot modify those.
Thanks for explaining.

The git-backup is using the same component for remote backups. So you have two places where this is documented. If you need details I would always recommend the source code.

Would something like this be reasonable?

@mzurhorst I don't mind the docs change except that we don't want to put the 1:00 am internals in there because if we have to change them (the cron jobs have been rearranged before) it'll void the documentation and possibly will be wrong for a long time).

Sure. I will update the CR accordingly.  Shall I leave the "early morning" in or is this too specific as well?

"nightly" or "overnight" would be more precise... in any case thanks for doing this


pip>=10.0: ImportError: No module named req  solution

./cobra/detection.py
line 21:
from pip.req import parse_requirements
changes to
try: # for pip >= 10
from pip._internal.req import parse_requirements
except ImportError: # for pip <= 9.0.3
from pip.req import parse_requirements

already fix in #1078


Serverbrowser gamemodes filter array not localiseable

GetPrivateMatchModes() returns non localisable strings breaking gamemode filter

There also seems to be gamemodes missing and at the same time curretly non functional gamemodes like frontier defence are included
Don't have time to fix this so I made this

Just had to realize mode is #PL_private_match for all servers
So the gamemode filter doesn't work at all actually.

Just had to realize this doesn't work at all:
void function CheckGamemode( serverStruct t )
{
	if (filterArguments.filterGamemode != "SWITCH_ANY" && filterArguments.filterGamemode == t.serverGamemode)
	{
		file.serversArrayFiltered.append( t )
	}
	else if (filterArguments.filterGamemode == "SWITCH_ANY")
	{
		file.serversArrayFiltered.append( t )
	}
}

Because t.serverGamemode is always #PL_private_match

this should be fixed as of this commit


Loading a material after cubemap loaded doesn't assign cubemap

Project: https://playcanvas.com/project/701726/overview/test
Steps to Reproduce

Luanch project, cube is fine
find cubemap/Helipad, check Preload, launch project, cubemap is missing.

https://github.com/playcanvas/engine/blob/master/src/resources/material.js#L303
please use "assetReference.asset.loaded", cubemapAsset.resource can be null after loaded

The same situation exists when setting the skybox after monitoring the cubemap resource loading is completed

Thanks for this issue @yusjoel and the simple repo - much appreciated!

@terence-wang do you perhaps a repro for the skybox case?


BUG when two accounts send action at the same time to modify multiindex table

It took me several days to find the bug.
I got a table like this
TABLE t {uint64_t key, name player1, name player2, uint64_t status};

when the contract recieved the specific action , It will gothrough the table to find if there is a row which status == 1 and player2 is empty, if not exist, It will emplace one. now it has one row like this
{"key" : 1, "player1" : "bob", "player2" : "", "status" : 1}

When next player send the action ,he will find the row above and modify the player2 and status. It supposed to be like this.
{"key" : 1, "player1" : "bob", "player2" : "jack", "status" : 2}

The bug comes when two players send action at the SAME time, they could both find the row that status == 1 and player2 is empty ! Then the one who modify the table first will be overwitten by the next one. It will becomes like this, jack was overwitten by tom.
{"key" : 1, "player1" : "bob", "player2" : "tom", "status" : 2}

I'm wondering why would two player both find the same row, cause when a player find it he will modify the status to 2. so the next player will never find this row. Even if they both find the row,  can we lock the table before we modify it?
I've been suffering from this bug for a long time, does anyone has some good advice?
It's my code here.
https://github.com/afreshman/bugeos

your code seem does not take care of  p.status == 2  or player2 is null

are you sure this is a nodeos bug? You can use print in your contract and run nodeos with --contracts-console to see your console message.
I think so. It appears when over 100 users, I can't simulate in my local. But When I keep querying the bet table, I got a row with same key and same timestamp, but the player2 changes. I use eosio_assert before modify , it doesn't work.

Your code is not taking into account the fact that there are multiple producers in the system.  Until a block or action propagates, they can not know that one of your users has issued an action that modified a row.  This can easily result in two actions submitted at the same time modifying the same row twice, because different nodes receive their actions and execute them independently.  They're guaranteed to be applied in the same order on all nodes when they're finally added to the blockchain, but nothing in your code prevents them from modifying the same row twice.  Your architectural flaw is your attempt to use status as a mutex when the processes accessing it aren't even on the same machine.
You will need to deal with synchronization yourself.  There's nothing in the libraries that can help with that.  The simplest solution is to enter bets on independent rows, then run a matching engine yourself to pair them up based on their timestamps.  Having them edit the same row is an exercise in frustration.  Read up on Lamport timestamps and vector clocks for attempts to solve the problem.  You will discover that even these techniques are only eventually consistent and can lose data.
If you still have the problem and wish to discuss further, please post it in https://eosio.stackexchange.com. To keep things organized, Github issues are intended for bug reporting and feature tracking, and Stack Exchange is the right place for any technical support discussions. Thanks!


do not normalize light curve to compute peridogram

Removing an unnecessary (and problematic; #569) call to normalize a lightcurve before computing the periodogram.  The Lomb Scargle algorithm used can compute the same spectrum from an unnormalized light curve.

Thanks @keatonb!
@ojhall94 @christinahedges Do either of you remember why we added the call to lc.normalize() inside Periodogram.from_lightcurve()?
(There appears to be a unit test failure that is unrelated to this PR, I'll investigate.)

It's for the purposes of making the units work out--- ppm^2 / Hz is assumed for all units, since after normalization there's a factor of 1 x 10^6.  I think we could/should support different normalizations, since folks may wish to have units of variance / Hz for example.

See the flux_scaling parameter for where the factor of 1 million comes in to convert signals to parts-per-million:
https://github.com/KeplerGO/lightkurve/blob/b63b7d338ab57149179ebea6071d605e398dc0e5/lightkurve/periodogram.py#L838

@ojhall94 @christinahedges Do either of you remember why we added the call to lc.normalize() inside Periodogram.from_lightcurve()?

Could be related to the way the periodogram used to be normalized to enforce agreement with Parseval's theorem.  I changed this in #491 but didn't identify that these lines were no longer needed (or desired).

There's nothing holy about ppm, we should consider supporting the proper dimensional analysis if we know the input units (e/s, etc).

I agree with @gully that ideally units are inferred from the light curve flux units, but that sounds like hard work.
Could at least a normalize=True keyword be added to from_lightcurve like it is in _create_plot?  The language may get confusing since from_lightcurve also has a normalization keyword, where one would refer to the light curve and the other to the periodogram.
Another alternative is that the normalize function is rewritten to handle zero-centered data.  Perhaps if there are any negative values in the light curve we add one before renormalizing and then subtract it again?  We should probably also not trust this to work in all cases, as very low signal-to-noise light curves in regular flux units may contain negative values.

Hi Keaton! I've had a look at your issue #569 as well, super happy you raised this. There's so much stuff I missed so I'm glad people are paying attention :) To answer some of your questions:

Do either of you remember why we added the call to lc.normalize() inside Periodogram.from_lightcurve()?

As Gully pointed out, the from_lightcurve() function was originally built to just return power in units of ppm^2/muHz, so required fractional flux values. I considered including it under the hood harmless; if somebody had called lc.normalize() themselves before calling lc.to_periodogram(), it would just divide the data by 1 again.
I hadn't considered the use case for zero-centered data, but Keaton is right, it's completely incompatible with from_lightcurve().
I think rewriting the normalize() function to handle zero-centered data is the path of least resistance here. Instead of calling lc.normalize() internally, it could be a periodogram utility that checks where the data is centered.
Units would still have to be in ppm of course. As Gully says, support for the physical parameters in the future (even just magnitudes) would be ideal.

I prepared a proposal to modify the behavior of lc.normalize() over in #589.  Please have a look and leave any comments.  (If that PR is merged, we'll definitely want to make the normalization step optional in periodogram.from_lightcurve!)

To resolve this issue, I propose we do remove the call to lc.normalize() inside the periodogram, i.e. I am happy to merge this PR.
However, I do wonder if we need some sort of warning as follows:
if np.abs(1. - np.nanmedian(lc.flux)) < 0.5*np.nanstd(lc.flux):
    warnings.warn("The input light curve does not appear to be normalized, "
                  "this has consequence XXX.",
                  LightkurveWarning)

Is such a warning desirable?  What should the exact words be to explain the consequence of not normalizing? (@keatonb @ojhall94?)

@barentsen don't forget about the flux_scaling, which should be moved if the normalization is turned off.  The PPM units only work out if normalize is called, and the lightcurve is subsequently multiplied by a factor of 1 million.  Alternatively, you can state:
"The input light curve does not appear to be normalized, "
"The Periodogram units are unknown.  Plots and other methods will continue to erroneously report all units as parts per million (PPM)."
...which is unsatisfactory.  To support the correct input units would take some more sophisticated unit handling, probably an optional unit field for lightcurve flux to support (e/s) or (counts / time stamp)?  For now with Kepler/TESS, we know the units so may be easier, but a general LightCurve object typically has undefined units.

Should this instead be dealt with as as part of the normalization argument then?  Example:

normalization='amplitude' will return power in flux units;
normalization='amplitude-normalized' will normalize and return power in units ppm;
normalization='psd' will return power in units variance / frequency;
normalization='psd-normalized' will return power in units ppm^2 / frequency.

Does that make sense?

Offline, @gully suggested we may want to name the options amplitude, amplitude-ppm, psd, and psd-ppm.

I think showing a warning about units in to_periodogram when a light curve is passed that does not appear to be pre-normalized is a good idea.  Rather than trying to force a normalization in the function, encourage the user to pass a normalized light curve if they want their periodogram in relative units.
We might generally not want to make the decision that ppm is the user's preferred units (I usually want ppt or percent).  If the user passes an unnormalized light curve they may want to know the amplitude of signals in flux units.  Why not let the input units of the light curve be the output unit of the periodogram?  A periodogram of a normalized light curve can be easily put into units of ppm, ppt, or percent by multiplying the result of .to_periodogram by 1e6, 1e3, or 1e2.

I opened #591 to enable LightCurve objects to keep track of the flux units.  This should enable periodogram objects to automatically determine the correct units of power.

I finished work on #591, which keeps track of light curve flux units more properly, and changes LombScarglePeriodogram to adopt whatever units the light curve is in.
If we merge that PR, the behavior will become as shown below:

@keatonb @ojhall94 @christinahedges @gully Does the behavior of the units in the example above make sense to you all?

Hey @barentsen!
Thanks for doing this work! Super exciting to see Astropy units carried through the whole process. My only comments:

PR #591 will break any pipelines/tutorials/etc. that depend on the current normalization options. We might want to consider adding a warning, and/or updating tutorials in the same PR to minimise confusion for users.
I don't know the answer to this (@keatonb, @danhey?), but does anybody ever use amplitudes of e-/s when studying oscillations? If not, we may want to consider setting default kwargs to make the default power units something that users would recognise.

Thanks for the feedback @ojhall94!!
My thoughts:

We should definitely update the tutorials -- I intend to work on that today.  I don't feel too bad about this change because my understanding is that it should only affect units, not the intrinsic behavior. We should of course highlight it prominently in the change log and similar communications.
Periodogram will now use whatever units the light curve is in, so the only reason it shows "electron/second" is because that is the unit used by Kepler and TESS data products.  (Admittedly many publications show "counts" or "counts/second" in their plots, which is technically incorrect.)  The only alternative to this is to normalize by default, which is of course what I'm trying to avoid?

This is really great @barentsen !!
Purely for convenience, I have one small suggestion. I think changing units when computing the periodogram would be more natural if the to_periodogram call had a unit keyword, which may just access normalize internally.  Then if the user wants to view the light curve in different units (say e-/s) than the periodogram (say, ppm), they can call lc.to_periodogram(unit='ppm') which would give the same output as  lc.normalize(unit='ppm').to_periodogram().
I think units in = units out is the most predictable behavior.  I agree that most people won't want a periodogram in e-/s, but they probably also don't want the light curve in e-/s.  Periodogram of a normalized lightcurve gives a normalized periodogram.  I prefer avoiding making choices for the user that may abstract away exactly how the data are being manipulated.
Thinking about this has also helped me think of a way to handle zero-centered light curves, which I'll comment on over at #569

@ojhall94

As a user of ppm squared per microhertz, lc.normalize(unit='ppm').to_periodogram('psd') is more intuitive and much easier to write than specifying that in a unit kwarg. I think a unit kwarg would be neat, but in practice I think the way @barentsen set this up is best.

psd isn't a unit.  It just says you want the power spectral density rather than absolute power.  That could be ppm^2/muHz or ppt^2/muHz or, as you have pointed out is a little crazy but still valid, e-^2/(s^2 muHz).  I'm suggesting that only for convenience a periodogram keyword be provided as an option, so lc.to_periodogram('psd', unit='ppm') do the same as above, calling normalize under the hood only if specifically requested.  The default in to_periodogram should be unit=None.

I agree with @barentsen, that does work nicely, although the syntax you showed in your previous comment I'm also happy with, personally!

I think the confusing thing is actually something else, which makes me regret how we settled the issue of normalization options.  To me,normalization='psd', unit='ppm' makes sense because ppm is the amplitude unit, and the psd part says to square it and give the density.
What's more confusing is that if you calculate the periodogram with normalization='amplitude', the amplitude spectrum values are stored in an attribute called power even though these are not powers.  I think we would be most complete to let the periodogram object always have two attributes, power and amplitude, the latter just being the square root of the former.  Then the normalization keyword only says whether we want a power spectral density (psd) or absolute power units (absolute, or ps?), and the unit keyword can be something like amp_unit (to match freq_unit).  I prefer this to specifying all of the allowed combinations of normalization and amplitude units.

Thanks for sharing that thought @keatonb!  It may take me another day to respond because I decided I need to read Jake Vanderplas' review of the Lomb Scargle periodogram (https://arxiv.org/pdf/1703.09824.pdf).

Question about the above: If you do np.median(lc.normalize(unit='ppm').flux) do you get something close to 1e6?

Yep, I confirm:
*np.median(lc.normalize(unit='ppm').flux) equals 1e6;
*np.median(lc.normalize(unit='ppt').flux) equals 1e3;
*np.median(lc.normalize(unit='percent').flux) equals 1e2.
Is that the expected behavior?


Dev

Dev

@nanos @jandersonhill
I created this project, And it's actually ready. But I don't think I want to be the author of the plugin, I'd rather be such a helper. Anyone interested?
This is plugin such a dummy-switch or delay-switch but:

these project are abandoned
these project are accessory plugin (deprecated) and this is platform plugin
this project offers more and fix bugs from these projects
more in readme

Not me, sorry


Added SnapShot to LeftNav.test

Added a snapshot to LeftNav.test.tsx

@TylerHurtt  git pull upstream please

I'm pretty sure I did. What does it say is off?

I'm pretty sure I did. What does it say is off?


Dashlane: the version no longer supported

The Dashlane module doesn't seem to work anymore. Probably the protocol has changed.
PasswordManagerAccess.Common.InternalErrorException: Request failed with error: 'This version is no longer supported. The user must update to continue.'
- PasswordManagerAccess.Dashlane.Client.PostJson[T](String endpoint, Dictionary`2 parameters, RestClient rest)
- PasswordManagerAccess.Dashlane.Client.RequestDeviceRegistration(String username, RestClient rest)
- PasswordManagerAccess.Dashlane.Client.RegisterNewDeviceWithMultipleAttempts(String username, Ui ui, IRestTransport transport)
- PasswordManagerAccess.Dashlane.Client.OpenVault(String username, Ui ui, ISecureStorage storage, IRestTransport transport)
- PasswordManagerAccess.Dashlane.Vault.Open(String username, String password, Ui ui, ISecureStorage storage, IRestTransport transport)
- PasswordManagerAccess.Dashlane.Vault.Open(String username, String password, Ui ui, ISecureStorage storage)
- ...

Seems RequestDeviceRegistration got replaced with GetAuthenticationMethodsForDevice and some new parameters got added. Investigate that and figure out what else to send. Just changing the endpoint name leads to the following error:
{
	"requestId": "f254ddb9-241f-4f79-ba68-a3290e09c7e6",
	"errors": [{
		"type": "invalid_request_error",
		"code": "request_malformed",
		"message": "Request is malformed"
	}]
}


Add support for other Python versions

@James-Ansley Currently this very useful library is only supporting py3.10, would it be possible to make it work with py3.8, py3.9, and py3.11 ? Those versions of python are still getting updates.
Thanks!

Thank you for the suggestion. I have added support for Python 3.8+. Hopefully, this very useful library will now be able to be useful on even more Python versions.

@James-Ansley Thank you! 🙌


NIFI-4743 Added configurable null suppression to PutElasticsearchHttp…

…Record using a modified verison of a patch from Robert Bruno.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

This isn't easily tested with a unit test, so here's a flowfile that can be tested against an ES instance running on localhost:9200 (ie defaults)
Nullable_ES_Test.xml.txt

Gave your addition a quick look.   You should be fine, but I believe unnecessary since the writevalue function will never be called when the value is "null" due to the continue statement that happen when a null is found.  Again will not hurt though.  Double check my logic for sure.  I wrestled with that for a bit as well.

@pvillard31 If you have a min this is a small one that'd be good to have in 1.6. @robertrbruno wrote 95% of it, but I took his patch from Jira and made it into a PR. We've both kicked the tires, and it seems solid.

@pvillard31 @robertrbruno I checked in a new commit based on the feedback. Please take a look when you have a min.

@MikeThomsen changes look good to me.

@pvillard31 Can you close this?

@pvillard31 I think we can close this one too.

Ok.

@pvillard31 Added integration tests.

Thanks @MikeThomsen - will try to have a look this evening.


Mistlands update?

Hello!
Do you plan to update the various mods to be compatible with Mistlands and its new raids/enemies?
Thank you!

Yes. I expect to release new versions of Custom Raids and Spawn That later today.
Both have pre-releases available until then, that were built for the public test branch:

https://github.com/ASharpPen/Valheim.CustomRaids/releases
https://github.com/ASharpPen/Valheim.SpawnThat/releases

Awesome, looking forward to it.


FIX：lowcode 编译适配多包模式报错问题

目前物料解析模块，在解析@types/react 的时候，只从当前组件目录寻找，工作区的情况下，依赖安装在工作区，找不到对应依赖会报错

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: gu-xiaohui:x: guxiaohui.gxhguxiaohui.gxh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[DEV-12659] Develop featured categories homepage block

This setup doesn't sell the concept too well, but it is what I cobbled together locally.
I'm not happy with the 5 items layout on desktop, curious to hear your thoughts.

1 cat will have to be full width I think.
yeah I'm not sure about that desktop one either. I'd be tempted to go either way - stick to the 33%/max 50 of the size before, or make it 20% and have 5.
You're always going to have to suffer with an odd one out on it's own unless you either:

make it grow to be full width
count the number of featured categories, and conditionally change the style based on odds and evens (odds having a '33%/max 50' and evens having a % that gives an equal row number.


showing database already exists

window.plugins.sqlDB.copy(dbname, location, success,error);
showing database already exists.
But I don't understand where the db file coping. I set the location 0 for android. what is that mean in android?

Database is being copied to application sandbox storage:

/data/user/0/<packagename>/databases/

window.plugins.sqlDB.copy(dbname, location, success,error);
showing database already exists.
But I don't understand where the db file coping. I set the location 0 for android. what is that mean in android?

Database is being copied to application sandbox storage:

/data/user/0//databases/


[Android] Unable to use files with the same name as resources in release builds

Is this a bug report?
(write your answer here)
Yes
Have you read the Contributing Guidelines?
Yes
Environment
Environment:
OS: macOS Sierra 10.12.6
Node: 7.9.0
Yarn: Not Found
npm: 4.5.0
Watchman: 4.7.0
Xcode: Xcode 9.0.1 Build version 9A1004
Android Studio: 2.3 AI-162.3871768
Packages: (wanted => installed)
react: 16.0.0-beta.5 => 16.0.0-beta.5
react-native: 0.49.3 => 0.49.3
Steps to Reproduce

Create a new React Native project via react-native init
Copy 2 assets to your project with the same name but different extensions (in our case, it was male_02.obj and male_02.mtl). The easiest is to find a png and a jpg and name them the same.
From the JS file, require both files (ie. require("./test_image.png") and require("./test_image.jpg")
Perform a release build for Android

Expected Behavior
Both files are loaded into the app bundle and accessible by the application
Actual Behavior
Get an error complaining that the resource entry is already defined:
res/drawable-mdpi-v4/js_res_male02.obj:0: error: Resource entry js_res_male02 is already defined.
res/drawable-mdpi-v4/js_res_male02.mtl:0: Originally defined here.

This is because React Native copies resources into Android's res directory vs assets and it seems like the res directory ignores file extensions. Seems to me there are two ways around this, encode file extensions into the resource name or (ie. js_res_male_obj) or move to assets.
iOS release builds do not have this issue. Also if I rename male02.obj to male02_model.obj then it works just fine. However this presents a more annoying issue when my obj/fbx model has multiple materials/textures with the same name (but different extensions).
Full gradle output:
~/third-workspace/TestPackage/android$ ./gradlew assembleGvrRelease
Incremental java compilation is an incubating feature.
:app:preBuild UP-TO-DATE
:app:preGvrReleaseBuild UP-TO-DATE
:app:checkGvrReleaseManifest
:app:preGvrDebugBuild UP-TO-DATE
:app:preOvrDebugBuild UP-TO-DATE
:app:preOvrReleaseBuild UP-TO-DATE
:app:prepareComAndroidSupportAnimatedVectorDrawable2500Library UP-TO-DATE
:app:prepareComAndroidSupportAppcompatV72500Library UP-TO-DATE
:app:prepareComAndroidSupportSupportCompat2500Library UP-TO-DATE
:app:prepareComAndroidSupportSupportCoreUi2500Library UP-TO-DATE
:app:prepareComAndroidSupportSupportCoreUtils2500Library UP-TO-DATE
:app:prepareComAndroidSupportSupportFragment2500Library UP-TO-DATE
:app:prepareComAndroidSupportSupportMediaCompat2500Library UP-TO-DATE
:app:prepareComAndroidSupportSupportV42500Library UP-TO-DATE
:app:prepareComAndroidSupportSupportVectorDrawable2500Library UP-TO-DATE
:app:prepareComFacebookFbuiTextlayoutbuilderTextlayoutbuilder100Library UP-TO-DATE
:app:prepareComFacebookFrescoDrawee130Library UP-TO-DATE
:app:prepareComFacebookFrescoFbcore130Library UP-TO-DATE
:app:prepareComFacebookFrescoFresco130Library UP-TO-DATE
:app:prepareComFacebookFrescoImagepipeline130Library UP-TO-DATE
:app:prepareComFacebookFrescoImagepipelineBase130Library UP-TO-DATE
:app:prepareComFacebookFrescoImagepipelineOkhttp3130Library UP-TO-DATE
:app:prepareComFacebookReactReactNative0493Library UP-TO-DATE
:app:prepareComFacebookSoloaderSoloader010Library UP-TO-DATE
:app:prepareComGoogleAndroidExoplayerExoplayerR220Library UP-TO-DATE
:app:prepareOrgWebkitAndroidJscR174650Library UP-TO-DATE
:app:prepareTestPackageArcore_clientUnspecifiedLibrary UP-TO-DATE
:app:prepareTestPackageGvr_commonUnspecifiedLibrary UP-TO-DATE
:app:prepareTestPackageReact_viroUnspecifiedLibrary UP-TO-DATE
:app:prepareTestPackageViro_rendererUnspecifiedLibrary UP-TO-DATE
:app:prepareGvrReleaseDependencies
:app:compileGvrReleaseAidl
:app:compileGvrReleaseRenderscript UP-TO-DATE
:app:generateGvrReleaseBuildConfig
:app:mergeGvrReleaseShaders UP-TO-DATE
:app:compileGvrReleaseShaders UP-TO-DATE
:app:generateGvrReleaseAssets UP-TO-DATE
:app:mergeGvrReleaseAssets UP-TO-DATE
:app:generateGvrReleaseResValues UP-TO-DATE
:app:generateGvrReleaseResources UP-TO-DATE
:app:mergeGvrReleaseResources UP-TO-DATE
:app:bundleGvrReleaseJsAndAssets
Loading dependency graph, done.
warning: the transform cache was reset.
bundle: start
bundle: finish
bundle: Writing bundle output to: /Users/andychu/third-workspace/TestPackage/android/app/build/intermediates/assets/gvr/release/index.android.bundle
bundle: Done writing bundle output
bundle: Copying 8 asset files
bundle: Done copying assets
:app:processGvrReleaseManifest
:app:processGvrReleaseResources
res/drawable-mdpi-v4/js_res_male02.obj:0: error: Resource entry js_res_male02 is already defined.
res/drawable-mdpi-v4/js_res_male02.mtl:0: Originally defined here.

:app:processGvrReleaseResources FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:processGvrReleaseResources'.
> com.android.ide.common.process.ProcessException: Failed to execute aapt

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 27.808 secs

Reproducible Demo
If need be, I can provide one, but the repro instructions above are pretty simple.

@sejas I did the same thing because i was tired of having this issue and not a single command line to solve it automaticly


Support FreeBSD

This commit fixes issue on cquery's side. Its dependencies loguru and
sparsepp should also be ported to FreeBSD:

https://github.com/emilk/loguru/pull/46
sysinfo(2) called by sparsepp https://github.com/greg7mdp/sparsepp/blob/master/sparsepp/spp_memory.h#L32

With local hacks on loguru and sparsepp, it works on my FreeBSD 11.1

We should rename src/platform_linux.cc to src/platform_posix.cc later

Let's switch to https://releases.llvm.org/ (HTTP -> HTTPS) later on.
Some Xcode travis config cannot download bundled clang+llvm through HTTPS. https://travis-ci.org/jacobdufault/cquery/jobs/317854793
Downloading tarball

   destination: build/clang+llvm-4.0.0-x86_64-apple-darwin.tar.xz

   source:      https://releases.llvm.org/4.0.0/clang+llvm-4.0.0-x86_64-apple-darwin.tar.xz

Traceback (most recent call last):

  File "/Users/travis/build/jacobdufault/cquery/.waf-2.0.2-b8fa647d13364cbe0c1c8ec06042b54d/waflib/Scripting.py", line 118, in waf_entry_point

    run_commands()

  File "/Users/travis/build/jacobdufault/cquery/.waf-2.0.2-b8fa647d13364cbe0c1c8ec06042b54d/waflib/Scripting.py", line 178, in run_commands

    ctx=run_command(cmd_name)

  File "/Users/travis/build/jacobdufault/cquery/.waf-2.0.2-b8fa647d13364cbe0c1c8ec06042b54d/waflib/Scripting.py", line 169, in run_command

    ctx.execute()

  File "/Users/travis/build/jacobdufault/cquery/.waf-2.0.2-b8fa647d13364cbe0c1c8ec06042b54d/waflib/Configure.py", line 85, in execute

    super(ConfigurationContext,self).execute()

  File "/Users/travis/build/jacobdufault/cquery/.waf-2.0.2-b8fa647d13364cbe0c1c8ec06042b54d/waflib/Context.py", line 84, in execute

    self.recurse([os.path.dirname(g_module.root_path)])

  File "/Users/travis/build/jacobdufault/cquery/.waf-2.0.2-b8fa647d13364cbe0c1c8ec06042b54d/waflib/Context.py", line 125, in recurse

    user_function(self)

  File "/Users/travis/build/jacobdufault/cquery/wscript", line 200, in configure

    download_and_extract(CLANG_DIRECTORY, CLANG_TARBALL_URL, CLANG_TARBALL_EXT)

  File "/Users/travis/build/jacobdufault/cquery/wscript", line 98, in download_and_extract

    response = urlopen(url)

  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 154, in urlopen

    return opener.open(url, data, timeout)

  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 431, in open

    response = self._open(req, data)

  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 449, in _open

    '_open', req)

  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 409, in _call_chain

    result = func(*args)

  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 1240, in https_open

    context=self._context)

  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 1197, in do_open

    raise URLError(err)

URLError: <urlopen error [SSL: TLSV1_ALERT_PROTOCOL_VERSION] tlsv1 alert protocol version (_ssl.c:590)>


⚠ Bofrost.at has degraded performance

In 6629c14, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 3066 ms

Resolved: Bofrost.at performance has improved in 5c75909 after 7 minutes.


Add role annotation to Free

data Free f a = Free (FreeView f Val Val) (CatList (ExpF f))

a is never used in the implementation of Free so it gets inferred as phantom which causes problems when using coerce.

Ah, right. This should be representational instead.


Can we distribute free builds here?

There is probably something tricky in providing the builds. I'm not sure if it can be distributed freely here. If you know the answer, let me know.

Your better contacting CodeWeavera via there support system if you want clarification.
I’ve been providing prebuilt packages for a while now and also provide a Winehq like package (of 19.0.2 currently as 20.0.x is unstable and refuses to run on 10.9 without patches), I’ve contacted CodeWeavers numerous times for assistance with weirdness or just asking to fix there source links and why DXVK/MoltenVK were missing for the initial 20.0.0 upload.

I sent them a message, I'll report here with the answer :)

It’s strange I’ve had responses to some of my tickets even very technical ones but not others.
I’m guessing as this one was more general they haven’t gotten around to it yet.

It’s strange I’ve had responses to some of my tickets even very technical ones but not others.
I’m guessing as this one was more general they haven’t gotten around to it yet.

Oh, forgot to reply here, I received an answer on December 22nd and it seems positive:

Each of those projects has it's own license; the main one, Wine, certainly allows you to redistribute binaries that you build from the source code.  The license files with precise details should be in each archive.

Oh, forgot to reply here, I received an answer on December 22nd and it seems positive:

Each of those projects has it's own license; the main one, Wine, certainly allows you to redistribute binaries that you build from the source code.  The license files with precise details should be in each archive.

I’d have been surprised if that wasn’t the response considering, there aware of my packages and were also aware of doh123 when she was still active.
Even when you resolve #6 there will be additional errors after this, might wanna hold off until CX21.

I’d have been surprised if that wasn’t the response considering, there aware of my packages and were also aware of doh123 when she was still active.
Even when you resolve #6 there will be additional errors after this, might wanna hold off until CX21.

I'll be considering that the answer is yes we can according to answer I received here:
https://github.com/GabLeRoux/macos-crossover-cloud-build/issues/2#issuecomment-763996321
Feel free to reopen or create a new issue if there is a license problem, but it looks like it is ok to have the artifacts as they are right now.


update MDA benchmarks

Hi @jgreener64, we just released 0.18.0 of MDAnalysis and hopefully there's some performance improvements.  I checked the scripts and they should all work the same, so could we get them rerun?

All updated now, thanks.


Optional paths do not work with root

<Route path='/' ... >
  <Route path='basic' ... />
</Route>

This matches both / and /basic.
<Route path='/(profile/:guid)' ... >
  <Route path='basic' ... />
</Route>

But, this only matches / and /profile/.... It does not match /profile/.../basic or /basic.

You'd actually need path="basic" in the case you're describing. What do you get when you do that?

Sorry, I copied the wrong thing. I've corrected my previous comment. This does not work.

Hi! Per our new README:

For questions and support, please visit our channel on Reactiflux or Stack Overflow.

Shoot this is actually a bug - the code at https://github.com/rackt/react-router/blob/v1.0.0-rc3/modules/matchRoutes.js#L53 gives you a rule that looks like /(profile/:guid)/basic.
I guess we need to special-case the trailing parenthesis.

good catch @dylankarr, thanks @taion


Swift - CodingKeys improvements

This PR enhances the Swift code generator within the quicktype-core package by incorporating user-defined access level settings into the CodingKeys enum, alongside its ability to conform to additional protocols. This dual enhancement not only broadens the scope of customization for generated Swift code but also ensures consistency in access control and protocol conformance, facilitating more refined and secure code generation strategies.
Key Updates:

A new feature is introduced allowing the CodingKeys enum to inherit the access level specified by the user, ensuring that the enum's visibility aligns with the rest of the generated code.
The capability to specify additional protocols for the CodingKeys enum has been expanded to include the applied access level, offering a more integrated approach to custom protocol conformance.

How to Use:
quicktype \
  --src person.json \
  --src-lang json \
  --lang swift \
  --access-level public\
  --coding-keys-protocol "CaseIterable"\
  --out Person.swift

Thank you!


upgrade MKL

Description
upgrade mklml dependency
Checklist
Essentials

[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] upgrade MKL version from 20170720 to 20170908

@ykim362

0908 MKLML has one bug fix which is seg fault of convolution when filter size is greater than spatial domain. So, it might be good to upgrade.

Thanks, @ykim362. @eric-haibin-lin @piiswrong shall we merge this?


Description of App

Given tasks:

rubric={accuracy: 25}

[x] Add a usage section to your README which briefly explains how users can interact with the app and which information is provided on it.

Building from your research questions and usage scenarios provided in your proposal.md, give a high-level description of the interface for the app you will build.

https://github.com/J99thoms/Super-Smash-Dashboard/commit/7d5744dd61add0a16f67430c30554d4ece5e875e


Contribution of the RBAC WebService Pattern

https://github.com/cdk-patterns/serverless/issues/129

Going to try and simplify this and circle back. This code probably needs a workshop to bring the developer through it.

Going to try and simplify this and circle back. This code probably needs a workshop to bring the developer through it.


How to make tailwindcss and scss work together?

Hey!
I'm trying to make tailwindcss and scss work together, but I have some issues. I've tried 2 options
1 - rails new app_name -c tailwind - works fine, but I cannot use nested selectors, such as
p {
  h1.name {
     @apply text-9xl;
  }
}

2 - rails new app_name -c postcss - works almost fine, I can use nested selectors with my postcss config
module.exports = {
  plugins: [
    require('tailwindcss'),
    require('tailwindcss/nesting'),
    require('autoprefixer')
  ]
}

but I cannot use @import statement wit taiwindcss code (basic CSS code works fine).
application.scss
@tailwind base;
@tailwind components;
@tailwind utilities;

@import "external";

external.scss
h1 {
  @apply text-9xl;
}

body {
  background: red;
}

In this example body is read, but text-9xl isn't applied to h1. How to fix it?

The readme suggests to use postcss-import for @import statements with Tailwind.
Don't forget to put your @import statements at the top of your file. For example:
/* application.tailwind.css */

@import 'external';
@tailwind base;
@tailwind components;
@tailwind utilities;

@alec-c4 can this issue now be closed?


Add support for file uploads season

Duck season

231 tests were run on 399613aa. ❌ 2 Failed, ⚠ 4 Flaked. View Full Report ↗

❌ 2 Failed

Test Name
Failure Summary
Logs

Test$1UnsupportedMediaType
failure$1message: Failedfailure$1text: === RUN   Test$1UnsupportedMediaType    api$1test.go:74: Unsupported media type provided--- FAIL: Test$...
Logs ↗

Test$1RateLimitExceeded

Logs ↗

⚠ 4 Flakes

Test Name
Failure Summary
Logs

[chromium] should return list of users correctly.

Logs ↗

[chromium] should display error message for invalid login correctly.

Logs ↗

[chromium] should login with credentials correctly correctly.

Logs ↗

Test$1ConflictError

Logs ↗

settings


Decorator to Alias values  -1,0,1 in report

Does anyone have an idea how I can create a decorator for a report where I have an integer -1,0, and 1. I want to assign Partial,, Waiting and Complete.

Hi @stixoffire,
the easiest way to do this is - if your SQL backend is MS SQL, you can create a calculated field on DB-side which translates the 3 integer values to nvarchar values, holding Partial for -1, Waiting for 0 and Complete for 1.
Regards,
John

Closed due inactivity
Also check the issue guidelines.
If you still need help, you can ask this on stackoverflow with our new tag.
https://stackoverflow.com/tags/serenity-platform


[WIP] XMPP async

Description:
Move notify.XMPP from sleekxmpp to slixmpp to allow async functionality.

adds resource config option: lets users define the resource part of the sender address. see example below.
adds support for TLSv1.1 and TLSv1.2

Related issue (if applicable): fixes #17005
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6640
Example entry for configuration.yaml (if applicable):
# Example configuration.yaml entry
notify:
  - name: NOTIFIER_NAME
    platform: xmpp
    sender: YOUR_JID
    password: YOUR_JABBER_ACCOUNT_PASSWORD
    recipient: YOUR_RECIPIENT
    room<EMAIL_ADDRESS># (option)
    resource: HA-lakehouse  # (option)

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

I would highly appreciate also having httupuload integrated for xmpp notify ... Currently I use a cli command with
https://github.com/sezuan/uploadr
But slixmpp also has build in httupuload functionality.  I know not really very much people use xmpp but I think it's worth to get the best out of it .
Furthermore I was thinking about a xmpp bit to interact with Hass ...well only ideas but httupuload would be great

@thundergreen, I think that we should keep this PR limited to the migration to slixmpp.

That's something for another PR I think. I'd like to keep this PR clean.
Open an issue, I think I might look into it, once my XMPP server supports the HTTP Upload, so I'm able to use and test it as well...

Why not just pimp this component to a next upper level?  Would be nice to modernize this component ..like this it's an alternative to telegram and co, slixmpp offers this so why not using it?

@thundergreen one PR per feature.

@thundergreen I'd like to focus on the task at hand in this PR.
I'm already looking into HTTP upload with slixmpp. However this will be another PR.


Improve date on the user_invitations#show page

Extend the local_time gem to have a local_time_from_now helper that behaves just like local_time_ago but for future dates. Use this helper on the user_invitations#show page to improve the readability of the date.
It might be worth considering where else this functionality (or local_time_ago) might be useful elsewhere in the codebase.
Also consider releasing this as an asset gem that depends on the local_time gem.

Will not fix for now


playhead plugin: customize playhead icon and avoid parent scroll when playhead reaches end of audio

Is there any way to change the default red triangle icon?
Any idea how to avoid activating scroll on parent when playhead reaches end of audio?

I added to <playhead> children position: fixed and looks like it works as expected.

playhead > * {     position: fixed;   }
Elements with position fixed are immune to scrolling.


Shadow prelude rules globally

(How) Is it possible to shadow prelude rules in favor of our own/a macro? I have thin wrappers around C++ rules that I wish to enforce the usage of to avoid mistakenly calling the prelude ones. I would strongly prefer no to require explicitly load this override if possible.
I remember @dtonlay saying something about how Meta's rust_binary rule (or something similar) wrapped the prelude, so I assume that this is possible.

@JakobDegen Is there any documentation about this somewhere?

I've stumbled across app/buck2_interpreter/src/import_paths.rs, which looks like I want:
.buckconfig
[buildfile]
name = BUILD
includes = root//foo.bzl

root//foo.bzl
def cxx_library():
    print("I'm a library")

BUILD
cxx_library()

Prints as expected when evaluating that file. Am I abusing this? Should I expect it to break? It looks like LSP Go To Definition doesn't work with it, but that's a minor annoyance I can live with.
cc Buck2 wizard @ndmitchell

Yeah, you can use buildfile.includes to do this. We used to do that, but now ours just looks more like:
def cxx_library():
  fail("use load('some//path.bzl', 'cxx_library') instead")

And so all used rules have explicit loads associated with them.
Another alternative is to use your own prelude, which could feasibly load symbols from the standard one. The way the prelude works is that prelude//prelude.bzl needs to have a native symbol and then all items on that symbol will be available to build files

Ah that makes sense, thank you! I think that we'll do the exact same thing, that removes a bunch of magic and will unbreak Go To Definition.
I tried to make a custom prelude that loads the upstream one, but failed miserably because the upstream prelude's prelude cell references would point to our own, causing all sorts of issues. The following are conflicting:

the upstream prelude hardcodes the identifier prelude
the (custom) prelude cell has to be called prelude


When going back from project view carousel can no longer reach "New Project" on small screens

Describe the bug
The smallest screen I've been able to replicate this on is a browser window that is 1464 pixels in width.
When returning from project view it is impossible to drag or click your way back to the beginning of the carousel to make a new project. I was able to reproduce this on Microbit, in beta Arcade, and my local Arcade build on master.
To Reproduce
Steps to reproduce the behavior:

Make your browser window at most 1464 pixels in width
Go to https://arcade.makecode.com/ or any other MakeCode editor
Scroll to 'Project View' and open it
Click 'Go back'
Try to return to the beginning of the carousel

Expected behavior
Upon returning from project view you should be able to drag and click your way to the beginning of the carousel.
Screenshots
Note my browser size

Desktop (please complete the following information):

OS: OSX
Browser: Chrome

Should be fixed now.


feat(cypress): generate test reports

Type of Change

[ ] Bugfix
[ ] New feature
[x] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[x] CI/CD

Description

This PR adds configs and commands to generate test reports. Reports are generated automatically after the test is run.
Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

This is a P0 requirement that notifies people of tests that are failing with reports. At present, we only get to know that the specific test is failed, but no one that I know is bothered to care about just because it is still immature.
With this change, we should see test reports being generated and served right to us after the tests are run.
How did you test it?

Once the test run, below is format in which the reports get generated:
When the tests are running:

After generation of report is completed:

Above mentioned commands merge these reports into one:

Side panel
Main window

Embedded Screenshots:

In order for Embedded Screenshots to work https://github.com/juspay/hyperswitch/pull/5563/files#diff-5c94114f761905519a09ff1393545cfed7d2c7399079736b6c3c34cc64f03cd6 was removed with commit 67c014e (#5563)
Checklist

[x] I formatted the code prettier . --write
[ ] I addressed lints thrown by cargo clippy
[x] I reviewed the submitted code
[ ] I added unit tests for my changes where possible

@pixincreate Can you add the version name in the test report ?

Addition of x-request-id to reports will be taken as a separate PR.


fix readme hyperlink format

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Readme hyperlink does not format with a space in between.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM


Unable to go on https://uuid.ramsey.dev/ for documentation

Hi,
Unable to go https://uuid.ramsey.dev/
Need to access to the doc.
Thank you

Are you still unable to load the documentation site?

Still unable to load web site documentation i get "This site can’t be reached"

Yes but now able to reach https://readthedocs.org/ and https://uuid.ramsey.dev/ thank you :)


Design device case

The actual case for the pen contents needs to be designed. We may have talked about 3D printing it.

Decided on just buying a case from digikey


Ccache support with ONNX_MLIR_CCACHE_BUILD option

Add support for ccache on Windows and Linux. This isn't tested for other platforms, so additional changes may be required. Doesn't support ccache options through CMake, the way LLVM does, because of how platform dependent this approach is.
Signed-off-by: Nathaniel McVicar<EMAIL_ADDRESS>

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@jenkins-droid test this please

On Linux, at least for the Jenkins CI, we already do our own equivalent of caching since we build everything in docker. We only rebuild the images when necessary, e.g., we only rebuild llvm-project when we change to a new commit hash, etc. So I don't think ccache will buy us much on Linux. Therefore, I prefer not to introduce more complexity. I have no objection to have it on Windows if it provides visible benefits.

we only rebuild llvm-project when we change to a new commit hash, etc.
This is only for the ONNX MLIR build itself, not LLVM (which I admit is relatively fast, but some machines are much slower). The primary target is developer workstations, not CI or other online builds. I'm happy to remove support if you don't think it's appropriate, but I wanted to clarify who the audience is. Please let me know what you think!

@NathanielMcVicar Ah OK that would be fine, and defaults to OFF is good. Thanks for the clarification.

I'm actually curious on how much benefit it provides. Since most build systems (e.g., make, ninja, etc) only rebuild changed files already, don't they?

@gongsu832 I often have to do clean builds due to changes in our fork. I think the scenario where this is useful is somewhat limited, but hopefully some people will find it helpful. In terms of the actual improvement, it's pretty huge, with clean build time going from ~4 minutes to <1 minute. CMake takes much longer than the build if I have to reconfigure :)

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@jenkins-droid test this please

Jenkins Linux s390x Build #6200 [push] Ccache support with ONNX... started at 13:23

Jenkins Linux ppc64le Build #5322 [push] Ccache support with ONNX... started at 13:26

Jenkins Linux amd64 Build #6184 [push] Ccache support with ONNX... started at 12:23

Jenkins Linux amd64 Build #6184 [push] Ccache support with ONNX... failed after 24 min


Tick rate

is there a way to have it go faster then 20 ticks per operation it seems slow for what im trying to do

The advanced connector can go to 10 ticks per operation

do i have to have that only on the chest where i extrect from or do i need to chance them all

Only on the extraction point

oke ty lets see if thats a beter solution for my pulverizer setup

Also make sure to enable 'stack' mode for extracting items. That way it will extract a stack every 10 ticks

no i need it on single i want a even roundrobbin

Ah ok

i will try and see how the adv connector works else a setting to make out own tickrates will be nice in the future

Note that the reason for that limitiation is performance and lag avoidance. Especially if you're going to distribute single items like that then this is not very good for your TPS

i have the adv now on it and the lowest is again 20 tick

nvm was the wrong one was a old one again


Replace auto-upgrade scripts

The hook.py fails terrible with back-to-back release branch checkins. Really it would be better to have hook.py (or something else) build the release tarballs and then have a different process entirely for updating the nodes with a "current" image.

More reasons to update:

rsync-ing the versioned directory is the only reason we mount the NFS drive read-write.
if the image build hasn't completed when the containers restart they fail over and over again

This is like 50% done... the ce binary is now the deployment setup. But... we still need a solution for the rsync problem.

Fixed: designed away the rsync problem (sort of...it just isn't supported any more)


Update session to configure DistributedMemoryCache options by default

Once https://github.com/aspnet/Caching/issues/329 is addressed, session needs to add a default value for the maximum cache size.

@JunTaoLuo is this valid with the new plan?

cc @Tratcher

No changes are required for Session, it will happen in caching.


Add display data to SimpleFunction

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @swegner please review only the second commit here; the first is #757

LGTM

R: @bjchambers looping in committer for binding LGTM

LGTM


CXG draft schema defined

Draft schema for CXG/tiledb defined and documented.
Must include:

[x] versioning to make backward compat easier
[x] dataset-specific parameters

completed as part of #37