[release-1.2] fix: do not clear out spec.Domain.Memory

Do not clear out Memory in setGuestMemory but rather overwrite the Guest field, otherwise if hugepages are configured for the VM the setting would get lost.

What this PR does
Before this PR:
Creating a VM configured with hugepages does not actually use hugepages if memory is set through memory.requests
After this PR:
Creating a VM configured with hugepages does use hugepages if memory is set through memory.requests

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

/lgtm


Enable Windows ProxyAll by default

Enable windows proxyall feature by default because the kube-proxy userspace datapath has been removed since kubernetes 1.26.
(https://github.com/kubernetes/kubernetes/pull/112133)

/test-windows-all

/test-windows-containerd-networkpolicy

/test-windows-containerd-networkpolicy

/test-windows-containerd-networkpolicy

/test-ipv6-only-conformance

/test-windows-containerd-networkpolicy

/test-windows-containerd-networkpolicy
/test-windows-containerd-comformance
/test-windows-containerd-e2e

/test-windows-e2e

/test-windows-containerd-networkpolicy
/test-windows-containerd-comformance
/test-windows-containerd-e2e

/test-windows-containerd-comformance

/test-windows-containerd-conformance

/test-window-containerd.e2e

/test-windows-containerd-e2e

/test-windows-containerd-conformance

/test-e2e

/test-e2e

/test-conformance

/test-conformance

/test-networkpolicy

/test-e2e

/test-conformance

/test-conformance

/test-conformance

/test-conformance

/test-networkpolicy

/test-networkpolicy

/test-conformance

/test-e2e

/test-e2e

/test-e2e

/test-conformance

/test-conformance

Please remember to update docs/windows.md to remove intorductions on kube-proxy

Please remember to update docs/windows.md to remove intorductions on kube-proxy

Udpated.

@XinShuYang it doesn't seem that you removed docs/windows.md from hack/.notableofcontents. By removing it, you ensure that the ToC will always be up-to-date.

LGTM, but you need to rebase to resolve conflict first

@XinShuYang it doesn't seem that you removed docs/windows.md from hack/.notableofcontents. By removing it, you ensure that the ToC will always be up-to-date.

Updated, thanks!

/test-windows-all

/test-windows-proxyall-e2e

/test-windows-containerd-e2e

/test-windows-all

/test-windows-all

/test-all
/test-windows-all

/test-all
/test-windows-all

/test-windows-all
/test-all

Hi @jianjuns, do you have more comments?

/test-all
/test-windows-all

/test-all
/test-windows-all

/test-windows-containerd-conformance

/skip-all


Nurseries and breeding speed.

More on the repopulation speed issue:
// Breed speed
function breed() {
	let nurseries = building(2e6, 1.06) / (1 + 0.1 * min(magma(), 20));

I know that nurseries do not have a base cost of 2 million. I'm not sure that I understand the expected number of nurseries that a players expected to have, and I don't see anything here that is looking at the target zone (as in, more nurseries for a later target zone).
Can you clarify what perky is expecting in the way of nurseries?

I know that nurseries do not have a base cost of 2 million.

Nurseries have a base cost of 1M wood, 500K metal and 400K gems. I rounded that to 2M.

I don't see anything here that is looking at the target zone

This line contains function calls to building() and magma(). Both functions look at the target zone.


StartRound - two events (with tests) at the same time, don't work

I've noticed that if two events that trigger at the same time and have a Test (check if a variable is something), only one will run but components will add for both, its very odd.
If I run the same events without the tests, they run one after the other.
I've recreated this issue in the following test Scenario:
EditorScenario1.zip
Clicking the token sets a variable to 1, end the round and the next StartRound will try to run two events that have tests to see if the variable is set to 1.
One event places its token and prints its text, the other event prints no text but places its token. The second event, if it has follow on events they will never run (because you're never given the option to click the continue button.

Nothing obvious from a code review, will have to investigate.

I noticed this bug as well.

Fixed for 1.6

I glad this bug is fixed as it really messes up my scenario 'In The Dark' when the number of investigators is 5.  Unfortunately the spawn of a monster occurs in the first round but this prevents the setting of MinorMythosEvents to 1.  Resulting in only Flavour Mythos events until the major kicks in.
Which is a bit unfortunate.
Is version 1.6 going to be released soon? : )
If not I'll release a new version of my scenario to work around it.

Here is the list of things I want to look at for 1.6:
https://github.com/NPBruce/valkyrie/milestone/22
I have a lot going on right now, so I don't have the time.  Short answer is probably not.

Sorry not sure how I managed that.

I just did a quick test for this issue for 1.6.0b and it worked OK.
So it seems to be fixed.
If so, a big thanks for the quick work.  It was a nasty 'feature'.

Because 1.5 is broken I will rush out 1.6 in the next day or two if I can.


Unable to run google-analytics-extractor

Preconditions
-PHP 7.1
-apache2 2.4.18 (Ubuntu)
-Linux
What i did
i am following the instruction given in https://github.com/keboola/google-analytics-extractor to run this application. but always i am come up with the following output
'[2017-05-15 15:54:43] ex-google-analytics.WARNING: You don't have access to Google Analytics resource. Probably you don't have access to profile, or profile doesn't exists anymore. [] []
Extractor finished successfully.'

I can make sure the profile is exist and the yml configuration are correct.
i checked my profile configuration by using this https://developers.google.com/analytics/devguides/config/mgmt/v3/mgmtReference/management/profiles/get GA API caller and this api returning 200 status code.
The oauth are correct. i have create new api in developer.console and i have generate tokens.

What i want
Can someone explain me how to run the application successfully?

Sorry Mamreezaa I didn't get back to you. If you still want to use our extractor, please reopen this issue and I will write you instructions.


Update docs for release 0.14

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherrypick release-0.14

/approve


feat(console): azure ad provider

Partial of #4433
### Definition of Ready
- [ ] I am happy with the code
- [ ] Short description of the feature/issue is added in the pr description
- [ ] PR is linked to the corresponding user story
- [ ] Acceptance criteria are met
- [ ] All open todos and follow ups are defined in a new ticket and justified
- [ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
- [ ] No debug or dead code
- [ ] Critical parts are tested automatically
- [ ] Where possible E2E tests are implemented
- [ ] Documentation/examples are up-to-date
- [ ] All non-functional requirements are met
- [ ] Functionality of the acceptance criteria is checked manually on the dev system.

@eliobischof can you review after #5441 has been merged? thx

Didn't you want to make the templates more dry with the last template?

I can do that here or in a seperate PR if its easier for you

Didn't you want to make the templates more dry with the last template?

I can do that here or in a seperate PR if its easier for you

Maybe a separate PR is better


Ridiculous 404 messages

As an example, go here:
http://framework.zend.com/manual/2.4/en/ref/project.structure.html
Then you see random 404 error messages like:
"We hear Symfony doesn't have this problem" and "NO, Zend Framework is not to blame for this!"
Who's idea was it to add these childish messages???, I think its terrible PR and especially when newcomers to ZF see this, sigh

The 404 error page is not a part of the documentation.
Suggestions and improvements for the website: https://github.com/zendframework/zf-web
This issue can be closed.

@atlantic8-web regardless of that, it was fun and it is far from childish ;-)
This is a community project, and having fun at building this sort of stuff is vital, or else I wouldn't see a point in doing it (myself) at all.


Failed to Read Tensor Data on Quantized Model

I tried out the new version and it seems like there is an error when trying to load a quantized model.

gguf_init_from_file: failed to read tensor data
TTS.cpp/src/parler.cpp:604: runner_from_file failed for file models/parler-tts-mini-v1-Q5_0.gguf

Recreated. Taking a look now.

Should be fixed with https://github.com/mmwillet/TTS.cpp/commit/d09ec72e22af529f20d0c47ae4ce7220f14aeda1
I tested cpu generation with and without cross attention and it seems fine now.
The cause was just that there was meta for the top level model tensor (which was removed) added to the gguf file.


[Feature request] Add support for DWARF stack unwinding to show inlined native frames

On recent(-ish) versions of Fedora/RHEL/CentOS perf uses the elfutils/libdw unwinder instead of
libunwind since it is faster and more reliable on all supported
architectures: supporting stack unwinding using DWARF would be great to allow a better observability of the native space, given that inlined native frame are not available while using commong FP stack walking.

I looked at libdw, but did not see how it could be easily integrated into async-profiler.
The main problem is that the profiler can currently use only async signal safe API for stack walking.
However, I'll leave this issue open in case I decide to revise how async-profiler process stack traces (i.e. switch to offline processing).

I can write again to Jiri Olsa, dev of libdw, to ask for some help about it...maybe I will get some good hints on how to integrate it and will send a PR, but many thanks to have taken a look!!!

I spent some more time researching the topic, and came up with two findings: a good one and a bad one.
The bad one is that it doesn't look feasible to do DWARF-based unwinding on the fly. DWARF unwinding is really expensive both in computation and in memory used. While it's not usually a problem to get a stack trace during debugging, interpreting DWARF information during profiling will cause too much overhead. Furthermore, in async-profiler's case, stack traces are collected inside a signal handler, that incurs strict limitations on what can be done: e.g. no memory allocation, no locks etc.
There is a recent study [1] on improving DWARF unwinding performance by an order of magnitude using precompiled unwind tables. Sounds cool, except that implementing this approach in async-profiler would mean creating a specialized JIT compiler for unwind tables. This task alone is bigger than the rest of the profiler :) That's going to be too much effort for a Java profiler.
But I also have a good news for you.
Modern Intel CPUs can profile branch instructions, including calls and rets, and store their source and destination addresses (Last Branch Records) in hardware registers. Starting from Haswell, CPU can match these addresses to form a branch stack. This branch stack will be effectively a call chain automatically collected by the hardware.
What makes LBR call chain especially useful is that it works even without frame pointers. perf has supported LBR since Linux 4.1, and now I've added LBR call chain support to async-profiler.
The new option is --cstack lbr. It works only with hardware events like -e cycles (instructions, cache-misses etc.)
The maximum call chain depth is 32 (hardware limit). LBR stacks are not always complete or accurate, but they still appear much more helpful comparing to fp-based stack waling, when a native library is compiled with omitted frame pointers.
Here is an example of a traditionally collected profile:

and the same application profiled with --cstack lbr:

Taking the above into account, there are no plans to support DWARF in async-profiler.
LBR stack unwinding is a viable alternative.

I had to return to the problem of native stack unwinding in the context of another task.
DWARF is indeed a complex format; it's not just a format, but a Turing-complete virtual machine with its own bytecode, computation stack, etc. Fortunately, gcc and clang typically use only a small subset of DWARF functionality to encode unwind info for normal C/C++ routines. Furthermore, in most cases we don't need to decode information about registers other than the stack pointer (RSP) and the frame pointer (RBP).
So I came up with a solution that parses a small subset of DWARF and builds a lookup table. It's not a complete DWARF interpreter, but it helps to unwind the majority of C/C++ frames on linux_x64. Haven't implemented this for other platforms yet.
DWARF unwinding do requires extra memory (e.g. the lookup table for libjvm.so is about 2MB), and is slower than the traditional FP-based stack walker, but it's still fast enough for on-the-fly unwinding (I was able to make it signal safe).
I invite you to give it a try and provide the feedback. The code is available in dwarf branch.
Use --cstack dwarf option to enable DWARF unwinding.

E.g. the profile collected with a traditional FP-based stack walker:

And the same profile collected with --cstack dwarf:

Great! I have taken a look at the code yesterday ;)
I will try asap and I can already see how much more detailed it looks on native side (including GC frames too)

but it's still fast enough for on-the-fly unwinding (I was able to make it signal safe).

Very impressive @apangin !

Thank you @apangin


Postconditions for Bytecode Semantics?

Recently, with #490, postconditions have been added to most or all of the functions describing the semantics of individual bytecodes.  For example, this:
    function method Sub(st: State) : State
    requires st.IsExecuting() {
        //
        if st.Operands() >= 2
        then
            var lhs := st.Peek(0) as int;
            var rhs := st.Peek(1) as int;
            var res := (lhs - rhs) % TWO_256;
            st.Pop().Pop().Push(res as u256).Next()
        else
            State.INVALID(STACK_UNDERFLOW)
    }

Was changed to this:
    function method Sub(st: State): (st': State)
    requires st.IsExecuting()
    ensures st'.OK? || st' == INVALID(STACK_UNDERFLOW)
    ensures st'.OK? <==> st.Operands() >= 2
    ensures st'.OK? ==> st'.Operands() == st.Operands() - 1
    {
        //
        if st.Operands() >= 2
        then
            var lhs := st.Peek(0) as int;
            var rhs := st.Peek(1) as int;
            var res := (lhs - rhs) % TWO_256;
            st.Pop().Pop().Push(res as u256).Next()
        else
            State.INVALID(STACK_UNDERFLOW)
    }

In essence, postconditions (i.e. ensures clauses) have been added which attempt to clarify certain aspects of what the function does.
In this thread, I want to consider whether or not this is actually an improvement for our code base.  The essential argument is:

(Not Specifications) Postconditions like this are not necessary in Dafny (since this is a function).  They are not providing a specification for the function.  Rather, the function is its own specification (this is because functions are interpreted in Dafny, which contrasts with methods which are uninterpreted).

(Verification Aid) One situation when an ensures clause on a function makes sense is when it is needed to verify the function, or some other piece of code using it (e.g. see Pow() for an example);

(Key Properties) Another situation when an ensures clause on a function makes sense is when an important property must be maintained which is not obvious from its body.  Hence, adding it as a postcondition helps us double check this is true (e.g. see Expand() as an example).

(Readability) In my opinion, unnecessary ensures clauses on a function hurt readability as we simply have more code to read and understand.  Furthermore, ensures clauses take expressions which are inherently flat and this can make them very difficult to read (see below for an example).  Finally, the readability issue is particularly acute for people who are not familiar with specifications (noting that such people are our primary audience).

Ok, with the rough outline in place, I'm going to provide some more detailed discussion with examples.
Key Properties
Looking at our example above, an interesting question is whether or not the additional ensures clauses capture important properties which are not obvious from the code base.  Consider this one:
    ensures st'.OK? <==> st.Operands() >= 2

To my mind, this is pretty obvious from the body of the function.  Similarly for this one:
    ensures st'.OK? ==> st'.Operands() == st.Operands() - 1

Again, this is reasonably obvious from the line st.Pop().Pop().Push(res as u256).Next().
Overall, neither of these ensures clauses add any value for me.
Readability
The Sub example above is actually not too bad in terms of readability.  Many of the instructions are like this, however some are more problematic.  For example:
function method ReturnDataCopy(st: State): (st': State)
    requires st.IsExecuting()
    ensures st'.OK? || st' == INVALID(STACK_UNDERFLOW) || st' == INVALID(RETURNDATA_OVERFLOW)
    ensures st'.OK? <==> st.Operands() >= 3 &&
                        (st.Peek(1) as nat + st.Peek(2) as nat) <= st.evm.context.ReturnDataSize()
    ensures st'.OK? ==> st'.Operands() == st.Operands() - 3
    {
        //
        if st.Operands() >= 3
        then
            var m_loc := st.Peek(0) as nat;
            var d_loc := st.Peek(1) as nat;
            var len := st.Peek(2) as nat;
            if (d_loc + len) <= st.evm.context.ReturnDataSize()
            then
                // Slice bytes out of return data (with padding as needed)
                var data := st.evm.context.ReturnDataSlice(d_loc,len);
                // Sanity check
                assert |data| == len;
                // Copy slice into memory
                st.Expand(m_loc, len).Pop().Pop().Pop().Copy(m_loc,data).Next()
            else
                State.INVALID(RETURNDATA_OVERFLOW)
        else
            State.INVALID(STACK_UNDERFLOW)
    }

The ensures clauses are hard to understand because: (1) they are long and quite flat; (2) they use anonymous stack locations (e.g. st.Peek(1) as nat).  This contrasts with the body of the function which gives names to the locations in question (Ok, actually the names could be improved in this case I think, but the point remains).  In fact, I'm going to argue that adding this clause in particular is not improving our code base:
    ensures st'.OK? <==> st.Operands() >= 3 &&
                        (st.Peek(1) as nat + st.Peek(2) as nat) <= st.evm.context.ReturnDataSize()

In my opinion, this clause is not readable by anyone except an expert.  In fact, I could not read and understand this --- and I wrote the original version of the function!  I think the presentation in the body itself provides a much better and more readable description (esp if we improve the variable names and perhaps allow st.Pop().Pop().Pop() to be replaced with st.Pop(3)).
Conclusion
Overall, I think this is an important discussion for us to have and (hopefully) find some agreement on.  Its not immediately obvious how best to use the various mechanisms that Dafny provides, and I think we want to eventually settle on some kind of accepted practice within the group at least.

As a Dafny & FM beginner...
My current mental model is that I can look at the requires and ensures as a summary of the function/method and be done. The actual implementation is advanced magic I can typically ignore unless I really need it.
So, to me, the version with the ensures allows me to pick up what I need immediately, while the version without them does demand much more effort from me - at least that's how it feels in principle.
Surely anyone looking into Dafny for the first time will need some explanations. I feel even I could explain how to use the requires and ensures. I don't think I could do the same based on the function/method bodies. If you have to start mentioning how one of them is transparent/interpreted while the other isn't, IMHO you've already added a new layer of pain.

Hey,
I understand that highlighting key properties is useful.  But, more unnecessary things to read overall makes it harder to digest.  For example, I do not find this is easy to understand:
requires st.IsExecuting()
    ensures st'.OK? || st' == INVALID(STACK_UNDERFLOW) || st' == INVALID(RETURNDATA_OVERFLOW)
    ensures st'.OK? <==> st.Operands() >= 3 &&
                        (st.Peek(1) as nat + st.Peek(2) as nat) <= st.evm.context.ReturnDataSize()
    ensures st'.OK? ==> st'.Operands() == st.Operands() - 3

Anyway, its a stylistic issue so its hard to win an argument eitherway.

IMHO you've already added a new layer of pain.

Just remember that I am not adding this pain --- it is an artifact of Dafny.  I agree trying to explain it is difficult though.

Yes, but I'm guessing that users of our stuff probably don't really want to know too much about Dafny; they "just" want a spec with the guarantees of mechanical verification, etc.
And the spec is in the requires/ensures, right? All the rest is necessary and great to dig in, but if you can keep it under the hood, then even better.
I guess it's the same as publishing an interface and hiding the implementation, even if it's open source.

And the spec is in the requires/ensures, right?

Actually, no.  The whole function is the spec.  That's what I am trying (and failing) to explain above.  This is a subtle aspect of languages like Dafny (and Whiley).  There is a fundamental difference between a method and function in this case.  If it were a method we had written, then yes the ensures would be the spec.  But, for a function (and, accepting the unfortunate Dafny syntax, a function method) its different.
Anyways, I feel like I am losing this argument now.

If we keep with the idea of including postconditions, then we will have to find ways to make them more comprehensible.

I think the requires/ensures are necessary for the specs. They provide

information that is not obvious in the body
properties that are checked (so if we make a mistake/optimisation in the body, we still check that post conditions are satisfied).
[and the pre/post conditions do not impact the Java/Go generated code as they are discarded in code generation.]

I don't think it matters whether you use a method or a function method (and recursion) to write the code, you can add a relational spec in the form of pre/post conditions (the post conditions capture relations between the input and the output).
The body (imperative or functional) is how the result is computed, not what is should satisfy.
As I said before, I think this is an essential feature of Dafny. If we use only the body (without pre/post) the spec could be written in any other language, we do not add anything.
IMHO it is a great feature that provides some insight into the result of a computation (e.g. exactly when it returns an State.INVALID state etc).

information that is not obvious in the body

Well, the question is how do we decide what should be in the ensures clauses, and what should not.  What is the "style guide" here?  For example, in the SelfDestruct, some information is included but not all.  What's the decision making process here?
I would also say that the ensures clauses go beyond information that is not obvious in the body.  For example, the change in stack delta is obvious from the body.  However, one might argue that the presence of an account on the self destruct list is not obvious.

I don't think it matters whether you use a method or a function method

Did you mean "function or function method" here?  Using a method to implement our semantics would have quite big consequences.  It would mean a whole lot of our current tests would fail to verify, for example.

The body (imperative or functional) is how the result is computed, not what it should satisfy.

That is not correct in this case.  Every single piece of code in our DafnyEVM is part of the specification.  There is no imperative code that is hidden behind a spec.  That is the whole point of what we are doing.

As I said before, I think this is an essential feature of Dafny. If we use only the body (without pre/post) the spec could be written in any other language.

That is also not correct.  We can verify code using functions in Dafny regardless of whether they have ensures clauses.  The purpose of the ensures clauses is for presentation and to allow us to check key properties of interest.

IMHO it is a great feature that provides some insight into the result of a computation

It is a great feature when it conveys information clearly.


Question about module functionality

Hello, could you please tell me if it is possible to implement the following functionality with this module: Fields with expired TTL values are not deleted at all, but transferred to another hash or db?, for example with the name of the original + ":expired". Often we need to understand that the TTL has expired, but the data itself which is stored is also needed.

The feature you mentioned is not supported by TairHash. The original intention of TairHash is to quickly delete expired fields in order to quickly release memory.
But I can give you a suggestion. You can do some splicing on the redis hash field yourself, such as: ttl:original_field, and then you can hscan and check these fields regularly, and write them into another hash when they expire. Hope this can help you.

Thank you very much.


[FEATURE]: requested quality is not allowed in user's subscription

Which tool
tidal-gui <IP_ADDRESS>
Describe the feature
don't download music,help
Add screenshots

The same problem. It worked on 25.06, now it doesn't.

i cant download the music too beacause of this prolem please help us yaronzz <3333

i have same problem


To do app

In this PR I implemented the below:

Installed linters.
Installed   React App.
Created file components.
Add in the components of the file:  Header.js ,input.js,todoContainer.js
add todostyling.css

Your project does not work as expected. When the npm start command is run the project should start. It doesn't. Please consider fixing the problems you're facing and request a new review when the project will run.
[OPTIONAL SUGGESTIONS]

please consider adding a functional link to your live demo, as the one you're providing now is broken
kindly provide a snapshot of your working demo link
consider updating your various profile handles to your actual username (ex: GitHub: @githubhandle should be GitHub: @X-Elie-X in your README file)
please use your name instead of author in the README file


Shadowing an enum definition and referencing the outer definition in an initializer results in undefined enum value.

TypeScript Version:  Nightly

Search Terms: enum, shadowing, initializer
Code
// Outer enum
enum Enum { a = 1, b, c };

function foo(): number {
    // Inner enum with the same name
    enum Enum {
        // Initialize this using the value of
        // the outer enum, which is 1
        a = Enum.a
    };
    // This should return a number, but it's undefined! :o
    return Enum.a;
}

Expected behavior:
TypeScript should resolve the outer Enum definition and inline the Enum.a like it would with non-shadowed values.
Actual behavior:
TypeScript does not inline the value so Enum.a is evaluated (to undefined) resulting in a mismatch between the reported type and the runtime value.
Playground Link: http://www.typescriptlang.org/play/?ts=Nightly&ssl=1&ssc=1&pln=13&pc=2#code/PTAEHkFcBcFMCdSwHaQLYCgXtAUVWqAN6gCGoAvKAIwA0oARvQMagC+A3BhgGaTLNoASwD2yUDxEiAFAEoAXKAIMExDKA2gQoAJLJkq7IQDuQ6AAtQF2KADOpNDeQPY6zUbwE1mn1rB6zIVIAGyEALxsLIVtQSFshZABzK3MbADcQyBsRHjdfPxTsmEMCemNzIWZLaJo833IqfHQAOlI6zjrtABUKmNtzEUhggBNQeFhoSHhxcmUEegYYUDMAchj+YdgeBNhhgEJQeRE68cnpzxbSLjYgA
Related Issues: N/A, couldn't find any

An easy solution would likely be to rename the outputted enum variables when the compiler detects a shadowed definition.

The same behaviour can be observed with just
enum Enum {
    a = Enum.a
}

Classes detect the error
class Class {
    static a = Class.a; // error
}

Agreed, the behavior is working as intended, though I would say we should report an error.

@DanielRosenwasser I believe I've got a small code change that would report an error for this. README says to not raise a PR unless issue has a 'help-wanted' label so resisting temptation.
// checker.ts:32023
function evaluateEnumMember(expr: Expression, enumSymbol: Symbol, name: __String) {
    const memberSymbol = enumSymbol.exports!.get(name);
    if (memberSymbol) {
        const declaration = memberSymbol.valueDeclaration;
        if (declaration !== member) {
            ...
+       } else {
+           // Error
+       }
    }
    return undefined;
}

More than happy to contribute a PR with test cases, but understand if more hassle than just fixing internally 😄


Extend gitignore handling to respect .git/info/exclude

As many projects have checked it .gitignore, using .git/info/exclude for additional local ignores is quite convenient. Something along the these lines:
--- a/script/workspace.lua	2020-10-02 17:58:34.342786549 +0200
+++ b/script/workspace.lua	2020-10-02 18:03:52.054787135 +0200
@@ -58,6 +58,12 @@
                 pattern[#pattern+1] = line
             end
         end
+        buf = io.load(self.root / '.git' / 'info' / 'exclude' )
+        if buf then
+            for line in buf:gmatch '[^\r\n]+' do
+                pattern[#pattern+1] = line
+            end
+        end
     end
     -- config.workspace.library
     for path in pairs(config.config.workspace.library) do

What do you think?

It's good, PR plz


Bug/op 18063 rbac same app v4.1

We prefer small, well tested pull requests.
Please refer to Contributing to Spinnaker.
When filling out a pull request, please consider the following:

Follow the commit message conventions found here.
Provide a descriptive summary for your changes.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Add inline code comments to changes that might not be obvious.
Squash your commits as you keep adding changes.
Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.
https://devopsmx.atlassian.net/browse/OP-18063

This PR  triggered this build in this execution, please wait for it  and child pipelines to succeed before merging:  https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01GFMSPYTJCVHXBX3X4CGDPFVG

This PR  triggered this build in this execution, please merge to master only if this succeeds:  https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01GFMSQGZYZV92TBE6QKXZDXC3

SUCCESSFUL RunTests RESULT: Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 Reviewers ,  this PR did not cause the failures in  https://jenkins.opsmx.net:8181/jenkins/job/Dev-API-Automation-Test-GitPR/561/artifact/test-output/extentreport.html


form.submit() triggers a CanceledError from Axios

Laravel Precognition Plugin Version
0.5.5
Laravel Version
10.48.10
Plugin
Vue
Description
I've got a pretty basic form using Precognition, and all the form validation works great.  Using Firefox, when I call form.submit() to make a POST request, I get an Axios ERR_CANCELED error, and it never tries to contact the server.  The really weird thing is that if I double-click the submit button, the request goes through fine on the second click, like there's some kind of race condition.  This usually doesn't happen if I'm submitting a PUT request, but sometimes it does, and I haven't been able to identify a pattern.  This error happens on my colleague's machine as well.  If I test in Chromium, however, it works fine.
I realize this might not be a Precognition bug, but when I make the same POST submission by calling axios directly, it works just fine.
Steps To Reproduce
Here's a simplified example of what I'm doing.
const form = useForm(
    () => (props.terminal.id === 0 ? 'post' : 'put'),
    () => (props.terminal.id === 0 ? '/api/terminals' : `/api/terminals/${props.terminal.id}`),
    {
        name: props.terminal.name ?? '',
        type: props.terminal.type ?? '',
        phone: props.terminal.phone ?? '',
        // ...etc.
    },
);

const onSubmit = async () => {
    try {
        const response = await form.submit();
        const terminal = response.data;
        emit('saved', terminal);
    } catch (error) {
        console.error(error);
    }
};

Sounds like this might be a duplicate of https://github.com/laravel/precognition/issues/73
We should have a fix out for this shortly. Let's follow along in the other issue to keep things together.

@hackel, I'm also wondering if you could add the following to see if it makes a change on your end?
let submitting = false

const onSubmit = async () => {
    if (submitting) {
        return
    }

    submitting = true

    try {
        const response = await form.submit();
        const terminal = response.data;
        emit('saved', terminal);
    } catch (error) {
        console.error(error);
    } finally {
        submitting = false
    }
};

@timacdonald I'm still seeing this issue even after making those changes.

I've got a fix up that should address this one for you: https://github.com/laravel/precognition/pull/78


Remove dart-flutter-roller once Flutter w/ Deps roller is enabled

Mirror of fxb/51907

This is done, updates in the mirrored bug.


Consolidate all header parsing code

Header parsing logic is used in

MVC
StaticFiles
ResponseCaching

We should investigate the usages across the board and consolidate the code here.

https://github.com/aspnet/HttpAbstractions/issues/825

Tracking issues:

[ ] HttpAbstractions #758
[ ] ...

@Eilon #758 is complete, next we need to investigate having MVC replace their implementation with this one.

@Eilon Moving the rest of the work to preview3.

@Eilon could we do this in 2.1?

Yessss... @jkotalik is actually already working on some of this, starting with the toughest of them all: MediaType header value.

@muratg @Eilon We added structured suffixes and facets to MediaTypeHeaderValue (MTHV) in HttpAbstractions. I was trying to modify MediaType in MVC to wrap MTHV, though it seemed non trivial and wouldn't have much benefit until we either remove MediaType or can deprecate it. What other header logic can be moved from StaticFiles/ResponseCaching to HttpAbstractions?

I think we can deprecate MediaType. @Eilon thoughts?

@javiercn did some research on obsoleting MediaType and I think his findings were promising. @javiercn do you remember what the conclusions were?

@javiercn just came by to express to me just how excited he is to share his wealth of knowledge and extensive notes in this area; alas, he had to go to an important meeting first.

I would only obsolete MediaType if we actually plan to get rid of it, say, in MVC 3.0. Would that be the plan?

We should have a design we are all happy with for 3.0 (one that allows efficient header non allocating iteration as a basic API and a richer strongly typed allocating API for convenience)

I set up a mtg for this for tomorrow. I invited @javiercn @muratg @jkotalik @rynowak @Tratcher .

Plan from the mtg:

[ ] Change MediaType into a facade that just calls into MediaTypeHeaderValue
[ ] Mark MediaType as obsolete
[ ] Find all public exposure of MediaType in MVC, obsolete them, and make sure that there are non-obsolete alternatives
[ ] Do basic before/after perf tests on MVC scenarios for conneg to assess whether there is a regression, and, if so, how much


matching field type as well as path

as raised in #18

(TODO: how do I match a field where the field must have a particular value for "@type" IN ADDITION to having a particular path? This is how I would require that a multi-subject cred have particular data for subject A, and different data for subject B, as with a birth certificate...)

Is it possible to modify the input evaluation algorithm to account for this?

I believe this level of complexity is something we should avoid, because Subject A and Subject B should be getting their own objects that are specific to them.

Here's a use case I'm worried about. I have the impression that this use case is not possible with the current approach. If it is, then I am happy. If not, then I assert that we an important, unaddressed requirement.
Verifier wants to challenge Prover to show that:

They are the mother named in a birth certificate (mother's name and date of birth are disclosed -- or if non-ZKP, all the mother's info is disclosed).
The child named in the birth certificate was born in the state of Texas (child's name and place of birth are disclosed -- or if non-ZKP, all the child's info is disclosed).

@csuwildcat suggested that subject A and subject B will have their own objects, but I don't think that's adequate for what I've suggested above, because I have no way to tell whether the mother and the child are part of the SAME birth certificate. What I'm suggesting is that the idea of having an object enumerating the characteristics you want from each subject isn't good enough; you need to be able to say something about characteristics from each subject within the same cred, and you might also need a way to specify the relationship between two subjects across credential boundaries (prove you're the mother of a child who's also got a Canadian passport).

From the PE working group meeting
We think this issue is important to address, and we should begin exploring examples of credentials where we may want these checks. For the purposes of resolving things into a proposed first state, we will explore this at a later time. From the WG, it is agreed that support for this use case is possible with extensions. Whether or not it should be in the spec is up for discussion.
Although not an ideal solution, we were considering something like this:
              "path": ["$.issuer", "$.vc.issuer", "$.iss"],
              "purpose": "The credential must be from one of the specified issuers",
              "type_hint": "https://govt-schemas.org/1.0.0/accounts.json/Mother",

@wyc : I don't see how the proposed solution helps. You still don't know that the data about the mother and the data about the child come from the same birth certificate...

@dhh1128 now I'm confused - if this is a single credential submitted of the type 'https://medical-schemas.org/BirthCertificate', and the filters are being applied to it to check data about the mother and child that it contains, how would it not come from the same birth certificate?

if this is a single credential

How do you know it's a single credential? I suspect that your answer is that the credential will be revealed. This is true in non-ZKP cases, but it is not true for ZKPs. If your criteria don't have a way to express that requirement, and if the response is a ZKP, you don't have any way of knowing whether it comes from a single credential.

I wasn't assuming the credential data need be revealed in raw form, I was assuming that 1 input descriptor = 1 proving payload, which is logically from 1 issuer. Are you saying that we'll be dealing with forms of ZKPs that allow a Holder to perform clientside aggregation and mixing of different proving payloads from different issuers, such that they present a mixed bundle of assertions as if it was 1 input descriptor that cannot be tested with any confidence as to how they were commingled? I am not aware of such as scheme, so if that's what you're suggesting, can you point to a paper that defines how that is done and what it looks like?

I think whether a signature scheme allows for two attributes from the same credential to be presented separately isn't where we should focus here, because there are some that do allow for that.
What we need to be sure of is to make sure the spec supports a Verifier requiring that two different requested attributes come from the same credential.
I think right now the spec supports that the two issuers must be the same for two inputs, and it supports that two schemas must be the same for two inputs, but I'm not sure it supports that two credentials must be the same for two inputs.

I believe the current version of the spec supports this, no activity for 1.5 years, closing


Allow for --all to have shorthand

I frequently am using spr diff --all and have a larger stack of changes. It'd be nice to have this shorthand, which is similar to git commit -a.

Can you add the same to the other commands that have an --all option? (That's amend, close and format.)

Done!


Egg Dropping Puzzle

Submission Title
Egg Dropping Puzzle
Submission Type
Algorithms/Dynamic_Programming
Submission Description
Describe the Algo
Submission Directory
Algorithms => Dynamic_Programming => Egg_Drop.cpp
Contributors

[ ]  C++ -
[ ]  C -
[ ]  Python -
[ ] Java -
[ ] JavaScript -
[ ] TypeScript -
[ ] Golang -
[ ] Ruby -
[ ] php -
[ ] Swift -
[ ] C# -

please assign this to me for python

I can write the code in C++ language

Please assign this to me for C++ language

Please assign this to me for TypeScript

Please Assign This To Me For C / C++ Language

Hey can you assign this issue to me in C

thanks everyone :v:


chore(script): not fmt after install

What:

Why:

How:

Checklist:

[ ] Documentation
[ ] Tests
[ ] Ready to be merged
[ ] Added myself to contributors table

Coverage remained the same at 100.0% when pulling 40ef68611805195eaaa786bdc7883f1855a10007 on pr-fix-script into bae34c22a2265d086d8c03f3e8c9dad53022d7d0 on master.


[Feature] Can you please do INT4 Quantization for InternVL2-26B and InternVL2-40B

Motivation
A series of Internvl2 models has been released, I compared their InternVL-8B which is not as good as your INT4 Weight-only Quantization and Deployment (W4A16)  on some metrics. So  curious if the INT4 Quantization models of InternVL2-26B or 40B will be better or not.
Thank you all!
Related resources
No response
Additional context
No response

We did not test the them yet. Do you get any trouble doing awq quantization for the two models?

Get the error : NameError: free variable 'state_dict' referenced before assignment in enclosing scope
When runing " lmdeploy lite auto_awq OpenGVLab/InternVL2-2B --work-dir internVL2-2b-4bit "

We did not test the them yet. Do you get any trouble doing awq quantization for the two models?

It is a bug of the latest transformers. https://github.com/huggingface/transformers/issues/31685
Maybe you can downgrade the transformer version to 4.40-

I've tested with AWQ with no errors.

@tairen99 40B works well with https://github.com/InternLM/lmdeploy/pull/2023


HDDS-9118. Added an invalidateCacheEntry() in RocksDBCheckpointDifferHolder to close cached instance of RocksDBCheckpointDiffer

What changes were proposed in this pull request?
Compaction DAG pruning service/s are not getting started after bootstrapping. It is because RocksDBCheckpointDiffer is singleton class. On the metadataManager.stop() path we stop the executor and on restart we just used the cached object where executor is not running and don't restart Compaction DAG pruning service/s.
In this change, invalidateCacheEntry() is added in RocksDBCheckpointDifferHolder to close cached instance of RocksDBCheckpointDiffer and create new when getInstance() is called for the same metedata dir..
Note: Ideally there is no need to have INSTANCE_MAP but it was added so that tests don't interfere with each other.
For more details: https://github.com/apache/ozone/pull/4553#discussion_r1178510795
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9118
How was this patch tested?
Un-commented the test, (will be added as part of PR: https://github.com/apache/ozone/pull/5083) and ran it on fork.
https://github.com/hemantk-12/ozone/actions/runs/5755269497/job/15602339618
Also the test locally.

are @mladjan-gadzic tescases passing on new set of changes ?

are @mladjan-gadzic tescases passing on new set of changes ?

Yes, I added in test details
Un-commented the test, (will be added as part of PR: https://github.com/apache/ozone/pull/5083) and ran it on fork.
https://github.com/hemantk-12/ozone/actions/runs/5755269497/job/15602339618
I'll let @mladjan-gadzic push the actual test changes.

@hemantk-12 thank you for working on this!


[BUG] Lucene Snapshot Github Action Failing

There was an error in the OpenSearch Lucene Snapshots github action when trying to publish latest lucene-9.2.0-snapshot. The error is below:
Execution failed for task ':checkJdkInternalsExportedToGradle'.
> Certain gradle tasks and plugins require access to jdk.compiler internals, your gradle.properties might have just been generated or could be out of sync (see help/localSettings.txt)

This needs to be looked at so we can quickly build an updated 9.2. snapshot in prep for upgrading main and 2.x branches (and possibly 2.0)

Looks like #3396 fixed the issue.  Closing.


fix: vxeTable destruction/reconstruction remains at the first value

Description
解决VxeTable在modal/drawer中使用(或使用v-if切换)一直拿到的是第一次的表单
resolve: https://github.com/vbenjs/vue-vben-admin/issues/4804  有详细复现步骤及分析
https://github.com/vbenjs/vue-vben-admin/issues/4752
https://github.com/vbenjs/vue-vben-admin/issues/4785

Type of change
Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

[ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
[ ] Run the tests with pnpm test.
[ ] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

New Features

Enhanced handling of the grid API for improved flexibility and responsiveness within the component.

Bug Fixes

Ensured the extendedApi variable accurately reflects the latest instance of the API, enhancing stability.

Refactor

Updated variable declaration for better mutability and context usage within the component.

这个方案好像有问题，在某些情况下拿不到组件的实例对象

这样子拿到的对象是空的，没办法调用grid的方法


Backtrack /w fakelatency misses

Fakelatency values > 200 miss consistently while backtrack mode is set to all (turning on tracers shows that it is actually firing at bt ticks).
video : go f_ck yourself
config : go f_ck yourself
who i want to fix this : anyone but me.

wah

suggestion: remove all

i hope this isn't my fault

i hope this isn't my fault

it's not i just never fixed it when i made new backtrack


[WIP] Finalize 5.6.6 release

Summary/Motivation:
Creating a branch/PR for finalizing the 5.6.6 release. I updated the CHANGELOG to include the PRs that have been merged since the last release.
Changes proposed in this PR:

Update the CHANGELOG

Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the BSD license.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Coverage remained the same at 62.245% when pulling a8181c80e00dd3b11cbbd782a9b85983235fa6c6 on finalize-release into 4b81557c5db0a62939d4e0a89f27c053479656ff on master.


Use set_bytes for short temporary data in Metal internal shaders

For the internal shaders (blit/fill/copy) in Metal backend we pass data as a constant buffer (example). This requires us to retain the buffer for the lifetime of the command buffer, and is not super efficient. Instead, we should use Metal-specific setBytes functions there and avoid creating a buffer.

It partially depends on https://github.com/gfx-rs/metal-rs/pull/43 being merged and published


Incorrect requests version specifier in requirements.txt

Issue Description
Hi!
In the requirements.txt file, the requests version specifier is currently set to >=2.31.0,<2.29.0, which seems to be a mistake. And should be >=2.29.0,<2.31.0.
https://github.com/allegroai/clearml-serving/blob/main/clearml_serving/serving/requirements.txt

Hi @ilyahabr, thanks for noticing this.
Actually, this was caused by a snyk commit, and it was messed up a bit. The correct value should be >=2.31.0,<2.32.0 - care to add a PR?

Sure, I will create a PR

Was solved


Pull upstream changes.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 12 committers have signed the CLA.:x: Pospelove:x: Neumann-A:x: ras0219-msft:x: MarkIanHolland:x: jhs67:x: myd7349:x: PhoebeHui:x: grdowns:x: emptyVoid:x: wangli28:x: JackBoosY:x: quazi-irfanYou have signed the CLA already but the status is still pending? Let us recheck it.


clairctl is not working with ECR

It would be wonderful if clairctl would work with ECR - perhaps it does and its just unclear as to how to setup the clairctl.yml. Fortunately, there's a workaround with --local.
Is there a way that I can get ECR to work? Here's what I'm seeing...
> aws ecr get-login ...
> clairctl pull<PHONE_NUMBER>07.dkr.ecr.us-east-1.amazonaws.com/my-tag

Image:<PHONE_NUMBER>07.dkr.ecr.us-east-1.amazonaws.com/my-tag
 5 layers found
  ➜ sha256:3690ec4760f95690944da86dc4496148a63d85c9e3100669a318110092f6862f
  ➜ sha256:fc76571125e8044d9f0c22490a153d610ba30fa436b22dcca77c1cb50862d197
  ➜ sha256:b76dc12c79703dc381e037d8d3a443994d1588707d125358434fd56267220484
  ➜ sha256:27a65523b151d12c2b53af6d7135a039c3cbe7a86d3ddf1a2006a1e9b10f4a7d
  ➜ sha256:fcc3a1b907c7a8aa48b29c171fcd6a58ca18e8060730c1a64a8e896c392c1e10

> clairctl --log-level Debug push<PHONE_NUMBER>07.dkr.ecr.us-east-1.amazonaws.com/my-tag
2017-04-19 09:42:02.943911 D | config: Using config file: ./clairctl.yml
2017-04-19 09:42:02.944066 I | config: retrieving interface for local IP
2017-04-19 09:42:02.944071 D | config: no interface provided, looking for docker0
2017-04-19 09:42:02.944141 D | config: docker0 not found, looking for first connected broadcast interface
2017-04-19 09:42:02.944352 D | server: Update local server port from "0" to "64837"
2017-04-19 09:42:02.944359 I | server: Starting Server on <IP_ADDRESS>:64837
2017-04-19 09:42:02.949410 D | dockerdist: Downloading manifest for<PHONE_NUMBER>07.dkr.ecr.us-east-1.amazonaws.com/pvue/ingress-mapper
2017-04-19 09:42:02.949557 D | dockerdist: Retrieving repository client
2017-04-19 09:42:03.978730 D | dockerdist: endpoint.TLSConfig.InsecureSkipVerify: true
2017-04-19 09:42:04.777914 D | dockerdist: manifest type: *schema2.DeserializedManifest
2017-04-19 09:42:04.777936 D | dockerdist: retrieved schema2 manifest, no verification
2017-04-19 09:42:04.777953 I | config: retrieving interface for local IP
2017-04-19 09:42:04.777957 D | config: no interface provided, looking for docker0
2017-04-19 09:42:04.778027 D | config: docker0 not found, looking for first connected broadcast interface
2017-04-19 09:42:04.778178 I | clair: Pushing Layer 1/5 [sha256:3690e]
2017-04-19 09:42:04.778956 D | clair: Saving sha256:3690ec4760f95690944da86dc4496148a63d85c9e3100669a318110092f6862f[https://082822998707.dkr.ecr.us-east-1.amazonaws.com]
2017-04-19 09:42:04.786337 D | server: request url: /v2/pvue/ingress-mapper/blobs/sha256:3690ec4760f95690944da86dc4496148a63d85c9e3100669a318110092f6862f
2017-04-19 09:42:04.786358 D | server: request for image:<PHONE_NUMBER>07.dkr.ecr.us-east-1.amazonaws.com/pvue/ingress-mapper
2017-04-19 09:42:04.786409 D | server: host retreived: https://082822998707.dkr.ecr.us-east-1.amazonaws.com
2017-04-19 09:42:04.786438 D | server: auth.insecureSkipVerify: true
2017-04-19 09:42:04.786451 D | server: request.URL.String(): https://082822998707.dkr.ecr.us-east-1.amazonaws.com/v2/pvue/ingress-mapper/blobs/sha256:3690ec4760f95690944da86dc4496148a63d85c9e3100669a318110092f6862f
2017-04-19 09:42:04.890616 I | server: pull from clair is unauthorized
2017-04-19 09:42:05.002342 I | clair: adding layer 1/5 [sha256:3690e]: receiving http error: 400
client quit unexpectedly
2017-04-19 09:42:05.002377 C | cmd: pushing image "082822998707.dkr.ecr.us-east-1.amazonaws.com/pvue/ingress-mapper:latest": receiving http error: 400

# From clair:
clair_1     | 2017-04-19 13:42:05.001230 W | ext/imagefmt: could not download layer: got status code 401, expected 2XX
clair_1     | 2017-04-19 13:42:05.001297 E | clair: layer sha256:3690ec4760f95690944da86dc4496148a63d85c9e3100669a318110092f6862f: failed to extract data from http://<IP_ADDRESS>:64837/v2/my-tag/blobs/sha256:3690ec4760f95690944da86dc4496148a63d85c9e3100669a318110092f6862f: could not find layer
clair_1     | 2017-04-19 13:42:05.001590 I | v1: <IP_ADDRESS>:41396 "POST /v1/layers" 400 (219.699191ms)

Closing this in favor of #42


Dynamic canvas spawning in the pipeline editor

If you are in the pipeline editor, you notice (when dragging the canvas or zooming out) that to the left and top there is no canvas being drawn. When a component of the pipeline is placed here it should dynamically add canvas in that position.
The idea is basically an implementation of the dynamic canvas spawning seen in https://draw.io/.

@mausworks Aren't you working on this in #1060?


select component styling made cleaner

The select component in demogarphics has been made cleaner. Styling has been changed.
Type of PR

[ ] Bugfix
[x] New feature

Relevant Issues
Fixes #1010
Checklist

[x] Compiles and passes lint tests
[x] Properly formatted
[x] Tested on desktop
[x] Tested on phone

Screenshots

@amittttt please review and merge !!


Make package

Make genie_python into a pip-installable package.
See ticket for more detailed view of steps I took to get here.

Going to self-merge this as I need it to be on main to progress getting a pypi package uploaded. Not fixing ruff as part of this work (will pay my penance in a separate PR next week - this ticket is already rather fiddly without adding ruff fixes into the diffs)


[WIFI-10973] Add userRole argument to OWSEC createuser CLI function

Signed-off-by: Johann Hoffmann<EMAIL_ADDRESS>

Test is failing because the test script from the main branch is always used in the workflow (https://github.com/Telecominfraproject/wlan-testing/blob/master/.github/workflows/ow_docker-compose.yml#L141). Think we'll have to re-work this at some point.


Sound

There is only one critical requirement for sound:

[ ] Add a platform-independent mechanism for world and UI elements to “emit” sound (as a sequence of events), which the desktop and web code can then feed into some API.

But then there are further tasks and open questions to add sound to the game:

[ ] Decide how we are going to handle specific sounds, such as UI interactions and tool uses, in the all-is-cubes crate, minimizing bloat. Minimal set of recorded "click" noises? Pure synthesis? No concrete sound in the library, dependents must add their own?
[ ] Ambient sound synthesis (wind noise, rustles, hums, etc.) driven by character environment in the same way as camera exposure is.
[ ] Can we usefully synthesize sounds from block definitions? My predecessor project “Cubes” did that, but not well, but I know more about synthesis principles and techniques now. But it would probably still require material-properties hints to be not too incongruous.
[ ] Perhaps a Universe should be able to contain recordings for custom SFX and background music.

As of commit fde29b0d9e43cb64963efaf3630b8bee6088d5d5 there is very minimal sound support, intended to be just enough to be able to add further features incrementally. Actual sound output is desktop only, not web.


Running app on iOs failed (lime_byte_array_init__4)

trying to run my application on iOs simulator using lime test ios -simulator.
and i'm getting
** BUILD SUCCEEDED **
2015-05-27 11:48:34.647 ios-sim[29062:191728] Timeout: 60.000000 second(s)
Primitive not found : lime_byte_array_init__4
Error Null Function Pointer
lime version is 2.4.1
openfl version 2.2.8

This should be resolved, thanks! :smile:


Is this package maintained?

Hello,
I'm planning on using your package for my project but i'm not sure if this package is being maintained currently or not. On your readme you say that the package is no longer maintained, but I see that this package has compatibility with Laravel 7.0+ and latest commit was done 14 days ago. It would be great if you can clarify if this package is maintained and is usable for foreseeable future, thanks!

The readme is correct.


Remove duplicated logout message when logging out from workbench

Close #1567
Description

Easy fix, the useCheckLogoutParams hook is used both in the ProjectDetails component and the ProjectDetailsComponents component, so it's called twice. Removing one can fix this problem.
How Has This Been Tested?

Go to data science project, create a workbench
Login to the workbench
In the Jupyter notebook GUI, choose File -> Log out
Check the logout success message, make sure there is only one message in the notification center

Test Impact

N/A
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

useCheckLogoutParams is currently used in two places: ProjectDetailsComponents and ProjectDetails
I would expect this hook to be called as high in the component stack as possible. I'm not even sure either of these is ideal but if I were to have to choose one of the current ones, I would keep the one in ProjectDetails instead.
Works as expected. But there is an existing quirk.
The back button is no longer usable because the query string comes back and then immediately removed. The logout flow should be replacing the history state such that the back button brings us back to jupyter without being stuck on the current page.

/lgtm
/approve


Godot 4.0 Beta 8 macos universal version only opened with a blank grey window on a Intel x86_64 platform.

Godot version
Godot 4.0 Beta 8
System information
MacOS 10.15.7 (19H2) Intel Iris Graphics 6100 1536 MB
Issue description
The app only opened with a blank grey window on an Intel x86_64 platform.
Steps to reproduce
The app only opened with a blank grey window on an Intel x86_64 platform.
Minimal reproduction project
The app only opened with a blank grey window on an Intel x86_64 platform.

duplicate of #69046 (just search for 'gray' and it shows up)

Duplicate of https://github.com/godotengine/godot/issues/69046.


Refactor all LLM code to a seperate file outside of utils.js

Hey @aj47, really nice project - tried my hand on chrome extension for the first time ! Have a look at refactoring and let me know if I can improve it further :)


reduce restrictions for setting optimizer/dataset of a model

The public API requires the optimizer/dataset to be set before ml_train_model_compile. However, these restrictions can be relaxed and both can be later right until the training is being done:

dataset - current implementation allows this already, only documentation changes are needed
optimizer - minor implementation changes are needed (remove the check for the model is compiled when setting the optimizer and move the initialization of the optimizer to the training itself)

Thank you @pkosko for pointing these out.

:octocat: cibot: Thank you for posting issue #1849. The person in charge will reply soon.


Use other key for Shortcut view

Summary of the new feature/enhancement
Rather than pressing and holding the Windows key, I'd like to suggest that Win+/  (i.e. Win+?) be used to show the shortcuts window.
This avoids interfering with normal usage of the Windows key and allows the shortcuts display to show instantly, without delay.

As far as I know, Guide does not interfere with the Win button (combinations) at all. That's the fun of it.

Think this is a fair ask for the settings verified v1

@glittle
in 0.20 you can use Win + ? (depending on the keyboard layout it may be Win + Shift + ?)


Bad translation

Oops, l validated by mistake without entering a description.
I wanted to report a small correction, in the french version, the brands label is called "magasins", it should be "marques".

https://github.com/openfoodfacts/OpenFoodFacts-androidApp/blob/master/app/src/main/res/values-fr/strings.xml

Thanks


Add a sentence explaining that there are no transactions associated with account when transaction history is empty

Currently it is not entirely obvious if the user has not had any transactions or the transaction history does not work. The distinction should be clear.

Language: "There are no transaction associated with this account."


Add Support for 'Read Device Location History' Endpoint

Add support for the following endpoint:

https://m2x.att.com/developer/documentation/v2/device#Read-Device-Location-History

@fsaravia ready for review

:shipit:


CSS framework

http://getskeleton.com/#examples
http://getbootstrap.com/javascript/

bootstrap works really well with scss

http://getbootstrap.com/getting-started/

More or less settled on bootstrap.


Outdated screenshots

Screenshots are outdated needs update, also language specific screenshots will be nice to have. Java, JavaScript, PHP, Ruby, Go these could be added for now as these are popular languages these days also python..
Basically the languages which are supported by Jetbrains!!

I added some screenshots in the branch feature/screenshot. These screenshots do not seem to express the beauty of GitHub Theme, because my monitor resolution is not very high. Review when you have time.

I liked those screenshots, in my opinion we should merge it and in my opinion we can make things perfect and invest 2 months or we can add minor better update and push it to production to get the feedback. I like second option more.

Python not working @jiyuan0125

I'll fix it after sometime, awesome screenshots and i like the idea of more link 👌🏻, you rock 🤘🏻

I have updated all images to focus more on code styles.


fix(APIApplicationCommand): default_permission

Reference Discord API Docs PRs or commits:
discord/discord-api-docs#2737

this was actually a mistake in the docs pr iirc

It wasn't
On Mon, Apr 12, 2021, 02:02 Advaith @.***> wrote:

this was actually a mistake in the docs pr iirc
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/discordjs/discord-api-types/pull/111#issuecomment-817388032,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEJA4MCCC7ETXJMJ5TTYQCDTIIS7RANCNFSM42YAPAJA
.

https://github.com/discord/discord-api-docs/pull/2737#discussion_r601797055

Right, the documentation is wrong right now (not a first timer for the docs 😬)... submit a PR to fix it :D


After clicking ''add new mapping'' button,  the mapping panel header is better to be ''New Mapping''

This is a...

[X] Enhacement
[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Documentation issue or request

The problem
Currently,  ''Add new mapping'' panel header is the same as the ''Show/hide mapping details'' panel header.
Screenshot
''Show/hide mapping details'' panel header

''Add new mapping'' panel header

Expected behavior
It is better to change the mapping panel header from 'Mapping Details' to 'New Mapping''.

@igarashitm Hi Tomo, please help to review the above behaviour. Thank you~!

Do you mean having New Mapping label only while it doesn't have any source/target fields? It's actually going to be Mapping Details once you define a mapping by selecting fields. Does it mean we want to change the label once user add at least one field? Hmm for me it's a bit too busy.

@igarashitm  I mean when the user clicks '+' to add a new mapping, the title could change to 'New mapping'. When the user add at least one field, the mapping remain 'mapping details'. This is to differ the action between '+' action to 'activate mapping' action.


TiDb 大表同步出现NullPointerException

Search before asking

[X] I searched in the issues and found nothing similar.

Flink version
Flink1.14
Flink CDC version
2.3.0
Database and its version
TiDb 6.1.5
Minimal reproduce step
大表同步
What did you expect to see?
没有错误
What did you see instead?
java.lang.NullPointerException
at java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:411)
at com.ververica.cdc.connectors.tidb.TiKVRichParallelSourceFunction.flushRows(TiKVRichParallelSourceFunction.java:266)
at com.ververica.cdc.connectors.tidb.TiKVRichParallelSourceFunction.readChangeEvents(TiKVRichParallelSourceFunction.java:253)
at com.ververica.cdc.connectors.tidb.TiKVRichParallelSourceFunction.run(TiKVRichParallelSourceFunction.java:172)
at org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:110)
at org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:67)
at org.apache.flink.streaming.runtime.tasks.SourceStreamTask$LegacySourceFunctionThread.run(SourceStreamTask.java:323)
Anything else?
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

是否可以再这段代码增加null判断

Considering collaboration with developers around the world, please re-create your issue in English on Apache Jira under project Flink with component tag Flink CDC. Thank you!


Seeking some mp3 files causes jumps to EOF

Hi @lukasf
It is currently not possible to seek some audio files (I tested on a bunch of mp3s). Seeking will result in playback jumping to the end of stream.
I get the following output in debug:
FFmpeg (Warning): [mp3float @ 122CE800] Could not update timestamps for discarded samples.
File to reproduce:
https://1drv.ms/u/s!Ao-WOwsImxSMt9wXgDaPa-HC1kgY_g?e=EwERbt
I am not 100% sure if this is a problem everywhere or if the windows insider build is causing it.

Seems I introduced the bug with #117

Fixed with #123


GVL lock issue with recursive attached proc calls

rb_thread_call_with_gvl: called by a thread which has GVL
Here's a test case:
  def test_attached_recursion
    context = MiniRacer::Context.new(timeout: 20)
    context.attach("a", proc{|a| a})
    context.attach("b", proc{|a| a})

    context.eval('const obj = {get r(){ b() }}; a(obj);')
  end

Ideally this would be some sort of exception instead of a c-level crash. What do you think @SamSaffron?

Ouch, do you care to give fixing it a shot?
On Sun, Aug 27, 2017 at 12:33 PM, seanmakesgames<EMAIL_ADDRESS>wrote:

rb_thread_call_with_gvl: called by a thread which has GVL
Here's a test case:
def test_attached_recursion
context = MiniRacer::Context.new(timeout: 20)
context.attach("a", proc{|a| a})
context.attach("b", proc{|a| a})
context.eval('const obj = {get r(){ b() }}; a(obj);')

end
Ideally this would be some sort of exception instead of a c-level crash.
What do you think @SamSaffron https://github.com/samsaffron?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/discourse/mini_racer/issues/69, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAUXe47TPlAanr62CO9pnRefJyAoM03ks5scZo8gaJpZM4PD2WY
.

Definitely.

@SamSaffron: @n00bish graciously agreed to help out with this one, and it seems like the right way to fix it is to just properly flag the transition to gvl-land. He's made a note in his PR.
Take a look when you can. (and at my PRs too!) :D


⚠ ClamAV has degraded performance

In a727716, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 723 ms

Resolved: ClamAV performance has improved in 595ff4d.


Fix Theme.AppCompat issue...

Hello,
I would love to use PrettyDialog, but when I put it into my app I get this message.  I amend to Android and do not fully understand this problem so I was hoping you could tell me how to fix the issue?
You need to use a Theme.AppCompat theme (or descendant) with this activity
Thanks for any help!

The solution it to use YourActivity.this as context instead of getApplicationContext()


Pass in caption text to the CustomZoomContent

Issue Type

[ ] Bug report
[x] Feature request
[ ] Question / support request
[ ] Other

Description
Thank you for your work on adding in the ability to customize the zoom modal's content 🎉 (link)
However, using the exact example in the repo, I am having the hardest time trying to pass in the caption text to the CustomZoomContent component. What is the best way to pass in dynamic text that will appear in the Zoomed state?
https://github.com/rpearce/react-medium-image-zoom/blob/main/stories/Img.stories.tsx#L248

Hi, @jeremyzilar! Let's see if we can get you sorted.
The CustomZoomContent in this example,
https://github.com/rpearce/react-medium-image-zoom/blob/16ebc24d38c28739f39c99b1f6bb616f7b0adb93/stories/Img.stories.tsx#L236
can be anything. If you need to do this dynamically, I suggest the following approach:

I also want to say thank you for your time and whatever you contributed while with 18F, digital.gov, the U.S. Web Design System, and the rest.

It doesn't seem there's an outstanding issue here, so I'm going to close this. Please feel free to ask more questions!

So in trying both your example above, and the exact example in your storybook, the place where I keep getting hung up is that the modal doesn't close.
It seems that this open attribute is not getting removed or unset when closing the modal, where it is getting unset in your DEMO.
<dialog aria-labelledby="rmiz-modal-img-53e673c3d335" aria-modal="true" data-rmiz-modal="" id="rmiz-modal-53e673c3d335" role="dialog" open>

https://user-images.githubusercontent.com/395641/205322143-89d10b7f-dbc7-4bb2-8332-15ae02873bbe.mov
I couldn't find the spot in your repo where you are setting and unsetting open, but will keep digging around.
Here are the components I have:
const ContextImage = (props: any) => {
  return (
    <Zoom
      {...props}
      zoomImg={{
        alt: `thing`,
        src: props.url,
        srcSet: props.url,
      }}
      ZoomContent={ContextImageZoomed}
    >
      <Image key={props.id} src={props.url} alt={``} objectFit="scale-down" width={200} height={200} />
    </Zoom>
  )
}

const ContextImageZoomed = (props: any) => {
  const { buttonUnzoom, img, modalState } = props

  const [isLoaded, setIsLoaded] = useState(false)

  const imgProps = (img as ReactElement<HTMLImageElement>)?.props
  const imgWidth = imgProps?.width
  const imgHeight = imgProps?.height

  const classCaption = useMemo(() => {
    const hasWidthHeight = imgWidth && imgHeight
    const imgRatioLargerThanWindow = imgWidth / imgHeight > window.innerWidth / window.innerHeight

    return cx({
      "zoom-caption": true,
      "zoom-caption--loaded": isLoaded,
      "zoom-caption--bottom": hasWidthHeight && imgRatioLargerThanWindow,
      "zoom-caption--left": hasWidthHeight && !imgRatioLargerThanWindow,
    })
  }, [imgWidth, imgHeight, isLoaded])

  useLayoutEffect(() => {
    console.log("modalState ---->", modalState)
    if (modalState === "LOADED") {
      setIsLoaded(true)
    } else if (modalState === "UNLOADING") {
      setIsLoaded(false)
    }
  }, [modalState])

  return (
    <>
      {buttonUnzoom}
      <div className={classCaption}>
        <Image src={img.props.src} alt={``} objectFit="scale-down" width={img.props.width} height={img.props.height} />
      </div>
    </>
  )
}

So are you all sorted?
On the attribute topic, the open attribute gets set by the browser when showModal() is called on a <dialog> element.


Add icon.png

We are working on displaying a small icons in the package search. It will be basically pull "icon.png" from master on this repo. Could you add a small image (16:9, 184px wide best) of your motor shield?

@Robotmad Can you add the icon please?

@Robotmad Polling this ticket again. Can you add an image please?

simple image of the shield used to implement the motors added


Added Sign-Up Component

Description
Added a Sign-Up component to This Repo.
Motivation
This will help to easy creation of Sign Up Form.
Changes Made
Made from scratch .
Testing
Describe the testing approach or steps taken to validate the changes.
Related Issues
Specify any related issues or tasks that are addressed by this pull request.
Checklist

[x] Code follows the project's style guidelines.
[x] Tests have been added or updated to cover the changes.
[x] Documentation has been updated, if applicable. Mark ☑ in the component section of readme.md file.
[ ] All new and existing tests pass.
[ ] The code has been reviewed by at least one other developer.
[x] The pull request is linked to the corresponding issue, if applicable.

Screenshots (if applicable)
Add any relevant screenshots to showcase the changes made, if applicable.

Description
Added a Sign-Up component to This Repo.
Motivation
This will help to easy creation of Sign Up Form.
Changes Made
Made from scratch .
Testing
Describe the testing approach or steps taken to validate the changes.
Related Issues
Specify any related issues or tasks that are addressed by this pull request.
Checklist

[x]  Code follows the project's style guidelines.
[x]  Tests have been added or updated to cover the changes.
[x]  Documentation has been updated, if applicable. Mark ☑ in the component section of readme.md file.
[ ]  All new and existing tests pass.
[ ]  The code has been reviewed by at least one other developer.
[x]  The pull request is linked to the corresponding issue, if applicable.

Screenshots (if applicable)
Add any relevant screenshots to showcase the changes made, if applicable.

Please link the issue that this PR fixes


Added styling across application

Added colours, fonts and changed layouts of scenes in the application. Addresses #81

@ochu761 : will try getting the resize to work on my end


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
cc6f9f5 -> 3ece40d

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.21.2 -> v1.21.7

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.21.7
Compare Source
Bug Fixes

clear the plan file path only if SkipTestSetup is enabled (#647) (169b0d0)

v1.21.6
Compare Source
Bug Fixes

deps: update gomod (#646) (19f21bf)

v1.21.5
Compare Source
Bug Fixes

fix script permissions bug (#644) (ec8a424)

v1.21.4
Compare Source
Bug Fixes

improve log message during teardown (#643) (a6033a3)

v1.21.3
Compare Source
Bug Fixes

Only delete directory if it exists during teardown (#642) (f23a51b)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 2.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


C/C++ client support

We should make a C++ compatible version of the client for machines that don't have access to python or are unable to install the libraries we use.

This has become out of scope of this project for the time being due to the complexity of supporting two versions of the same application. we may revisit this when the project becomes more solidified, and features are not being added as frequently


Different Ways to Add Parentheses

DESCRIPTION
Given a string expression of numbers and operators, return all possible results from computing all the different possible ways to group numbers and operators. You may return the answer in any order.
The test cases are generated such that the output values fit in a 32-bit integer and the number of different results does not exceed 104.
Example 1:
Input: expression = "2-1-1"
Output: [0,2]
Explanation:
((2-1)-1) = 0
(2-(1-1)) = 2
This is the Leetcode problem.
DSA PROBLEM -
https://leetcode.com/problems/different-ways-to-add-parentheses/
Can you assign this to me?

@iamdestinychild Please assign this issue to me.


MediaMetadata.Builder().populateFromMetadata() miss some fields from .flac files

Version
Media3 1.5.0
More version details
I've also encountered the issue when using version 1.4.1.
Devices that reproduce the issue

OnePlus 6 running Android 11
Nothing Phone 2a running Android 14

Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Not tested
Reproduction steps
I went through the route of using MetadataRetriever to get the metadata for audio files based on https://developer.android.com/media/media3/exoplayer/retrieving-metadata#wo-playback.

Basically: MetadataRetriever → TrackGroupArray → TrackGroup → Format → Metadata → MediaMetadata.

A basic summary of what I did is (assume everything is defined):
val mediaItem = MediaItem.fromUri(uri)
val trackGroupArray = MetadataRetriever.retrieveMetadata(context, mediaItem).get()
val format = trackGroupArray[0].getFormat(0)
val metadata = format.metadata
val mediaMetadata = MediaMetadata.Builder().populateFromMetadata(metadata).build()

Then I return the fields available such as artist, title, trackNumber, etc..
Expected result
Accessing the title, artist, discNumber, and trackNumber fields on the MediaMetadata object should return the respective values.
Actual result
The title & artist fields both return the expected strings while discNumber & trackNumber returns null. This only happens when following the process for .flac files.
I do know that the vorbis comments for the discNumber & trackNumber fields are present as running metadata.toString() returns:
entries=[
  VC: TITLE=One Step Closer,
  VC: TOTALDISCS=1,
  VC: TOTALTRACKS=12,
  VC: ARTIST=Linkin Park,
  VC: DISCNUMBER=1,
  VC: ALBUM=Hybrid Theory,
  VC: GENRE=Alternative,
  VC: GENRE=Metal,
  VC: GENRE=Nu Metal,
  VC: COMMENT=CD, Warner Records<PHONE_NUMBER>26,
  VC: ALBUMARTIST=Linkin Park,
  VC: DATE=2000,
  VC: TRACKNUMBER=02,
  Picture: mimeType=image/jpeg, description=
]

I'm currently working around this problem by using MediaMetadataRetriever for .flac files instead since it correctly returns the disc & track numbers.
Media
I'll send the file to the specified email, but I think it affects all .flac files.
Bug Report

[ ] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

The conversion logic from vorbis comments to MediaMetadata is here:
https://github.com/androidx/media/blob/df887a942222914836081f868067960eb0149547/libraries/extractor/src/main/java/androidx/media3/extractor/metadata/flac/VorbisComment.java#L60-L80
Some of the tags mentioned at https://xiph.org/vorbis/doc/v-comment.html are missing from our logic, including TRACKNUMBER and GENRE - adding those is relatively uncontroversial.
The rest of the 'unrecognized' tags are less clear. It seems there's a lot of possible variety out in the wild, both in terms of the key names and the format of their values. Some examples of disc numbering from this 2009 comment:

DISC=n
DISCNUMBER=n
DISCNUMBER=n/x
DISC #=n
DISCC=x
DISCTOTAL=x
TOTALDISCS=x

Since TRACKNUMBER is one of the 'official' ones, and its description doesn't suggest the x/y formatting, it seems reasonable to me to derive that a TOTALTRACKS or similar key may also exist, and to follow the same convention for disc numbering. So I'll send a change adding support for:
TOTALDISCS
DISCNUMBER
TOTALTRACKS
TRACKNUMBER

If we get additional feedback with examples of the x/y numbering format, or different key names, we can add support for that too.

Disc and track number & totals (and genre) should now be populated by https://github.com/androidx/media/commit/12546070ee6bb8b41dc7c54714592f330d8794ba


Add IuliaCampean's file

created a branch, created a file and made a commit, and opened a pull request


Support select statements without from

At the moment we need to select from a table, even if we have no requirement for a table
e.g. we can't execute select 1, but we can execute select 1 from aTable
Existing tests should be cleaned up to remove tables from queries where none are required, which should be proof enough that this works.

We could provide an implicit conversion from SelectBuilder[F, Any, B] to Read.Select(Selection[F, A, B0], None, true, Nil) where the second parameter for Read.Select becomes Option[Table.Aux[Any]] and is not rendert in the None case.
However type inference might not work too well with this approach. Any other ideas how to solve this while keeping the compile time check that the selection type matches the TableType in queries select x from x.y;

I created a draft of my idea: https://github.com/TobiasPfeifer/zio-sql/commit/784fdd47e438ce38541b3fcd2168260c0f7d743b
As I expected the additional implicit conversion doesn't play well with intelliJ (more red lines then before)
Other suggestions and discussions are welcome

I wouldn't worry too much about IJ red squiggles. It's unlikely that people will actually use this often, but it'll tidy up the tests and should be supported since you can do it in SQL. Is this ready for review?

Need to tidy up some more specs and figure out why I can't compile this typeCheck assertion. I'll open a PR when it's ready


Sends cache-control header to nginx

looks like nginx won't cache things that don't have a Cache-Control max-age header

:+1:


sh: cpan: not found

Yesterday it still worked, today its gone
I use the docker-image library/alpine:latest but it hasn't changed in 4 weeks.
Inside the container i do
apk add --no-cache --update lighttpd awstats openssh-client rsync coreutils make

which provided me with a cpan executable, but now its gone. explicitly installing perl does not give me cpan either.
Please help.

cpan is provided by the perl-utils package. See https://pkgs.alpinelinux.org/contents?file=cpan&path=&name=&branch=v3.6&repo=&arch=.

It's probably also prudent to switch from "alpine:latest" over to something
more specific ilke "alpine:3.6" so you don't have another similar surprise
in a few months when Alpine 3.7 is released. 😇

thanks for the help :+1:


Application presentation

WHEN I am presented with the developer's first application
THEN that application's image should be larger in size than the others

this has been completed - the first app is the width of the container in addition to being taller.


fix: Add missing go_package options.

A couple proto files were mising the go_package option. We keep having to put it back when copying the protos to Go.

Without those lines we get...
protoc -I=internal --go_out=internal --go_opt=paths=source_relative --go-grpc_out=internal --go-grpc_opt=paths=source_relative internal/protos/*.proto
protoc-gen-go: unable to determine Go import path for "protos/auth.proto"

Please specify either:
	• a "go_package" option in the .proto source file, or
	• a "M" argument on the command line.

See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information.

--go_out: protoc-gen-go: Plugin failed with status code 1.
make: *** [protos] Error 1

The Go import path may be specified on the command line when invoking the compiler, by passing one or more M${PROTO_FILE}=${GO_IMPORT_PATH} flags. Example usage:
protoc --proto_path=src
--go_opt=Mprotos/buzz.proto=example.com/project/protos/fizz
--go_opt=Mprotos/bar.proto=example.com/project/protos/foo
protos/buzz.proto protos/bar.proto
Since the mapping of all .proto files to their Go import paths can be quite large, this mode of specifying the Go import paths is generally performed by some build tool (e.g., Bazel) that has control over the entire dependency tree. If there are duplicate entries for a given .proto file, then the last one specified takes precedence.
For both the go_package option and the M flag, the value may include an explicit package name separated from the import path by a semicolon. For example: "example.com/protos/foo;package_name". This usage is discouraged since the package name will be derived by default from the import path in a reasonable manner.

That's what the doc linked (https://developers.google.com/protocol-buffers/docs/reference/go-generated#package) says. I wonder if we should be doing this in whatever we have that generates our go stuff instead?

@rlinehan That would complicate generating the Go protos, which we currently do manually in a Makefile. We wouldn't be able to just do *.proto, we'd need to add a -M for every file.
The other proto files already have the go_package option, so this is just making them all behave the same.
Eventually we'll properly package them.


Fix "warning: already initialized constant COUNTRIES"

This should not harm the gem in anyway, its actually to prevent the following warning:
countries-0.9.3/lib/iso3166.rb:7: warning: already initialized constant COUNTRIES

This shouldn't be necessary.  If this issue gets more traction we will consider it.


Adds Vera (Vector Based Random Matrix Adaption) #2

Continuation of #1039.
Should now be 95% on par with that PR, with some minor changes on my part + resolving merge conflicts.
Examples and docs have not been included yet.
~TODOS:~

[x] Add documentation
[x] Add examples

https://arxiv.org/abs/2310.11454
Notable changes vis-à-vis 1039:

Some refactors around how the initialization of VeraModel proceeds, should be more straightforward now.
Add tests around saving and loading, which needs some special considerations for VeRA.
Fixed some issues with multiple adapters, requires more strictness (e.g. not allowing multiple different prng keys on the same model).
projection_prng_key now has a valid default value (0) in the config.
Removed support for Embedding to reduce complexity: Supporting Embedding layers with VeRA makes very little sense because its shape is always different from the linear layers' shapes. Therefore, they cannot share the vera_A and vera_B matrices, resulting in an error. The only conceivable way to support Embedding layers would be to only target that layer (and possibly the output layer if it shares the weight), but that more or less defeats the purpose of using VeRA. We may revisit support for Embeddings in the future, maybe if we can enable vera_A and vera_B to be of different shapes. Until then, let's support the most common use cases and simplify our lives.

To ensure that the vera_A and vera_B weights are shared (but not other tensors), I added some tests that check their corresponding data_ptr()s.
Moreover, I wrote a small script to check the amount of memory taken by the model. For this, I used a very high rank of 10000, so that vera_A and vera_B should be quite large. Then I compared the GPU memory taken for a model with a single layer having a VeRA adapter vs a model with many layers having a VeRA adapter. We should expect that both should take roughly the same memory, since most parameters are shared.
Here is the script:
from transformers import AutoModelForCausalLM
from peft import get_peft_model, VeraConfig, LoraConfig
from peft.tuners.vera import VeraLayer
from peft.tuners.lora import LoraLayer
import gc
import torch

RANK = 10000
model_id = "facebook/opt-125m"

config_cls = VeraConfig
layer_cls = VeraLayer

def get_gpu_memory():
    torch.cuda.synchronize()  # Wait for all kernels to finish
    gpu_info = {
        'allocated': f"{torch.cuda.memory_allocated(0) / 2**30:.4f}GB",
        'reserved': f"{torch.cuda.memory_reserved(0) / 2**30:.4f}GB",
    }
    print(gpu_info)

print("before loading the base model")
get_gpu_memory()

model = AutoModelForCausalLM.from_pretrained(model_id).cuda()
print("after loading the model")
get_gpu_memory()

config = config_cls(task_type="CAUSAL_LM", target_modules=["model.decoder.layers.0.self_attn.k_proj"], r=RANK)
model = get_peft_model(model, config)
num_vera_layers = len([m for m in model.modules() if isinstance(m, layer_cls)])
print(f"after adding {num_vera_layers} adapted layers with rank {RANK}")
get_gpu_memory()

del model
torch.cuda.empty_cache()
gc.collect()

print("after resetting")
get_gpu_memory()

model = AutoModelForCausalLM.from_pretrained(model_id).cuda()
print("after loading the base model")
get_gpu_memory()

config = config_cls(task_type="CAUSAL_LM", target_modules=["v_proj", "q_proj"], r=10000)
model = get_peft_model(model, config)
num_vera_layers = len([m for m in model.modules() if isinstance(m, layer_cls)])
print(f"after adding {num_vera_layers} adapted layers with rank {RANK}")
get_gpu_memory()

For VeRA, the results are:
before loading the base model
{'allocated': '0.0000GB', 'reserved': '0.0000GB'}
after loading the model
{'allocated': '0.4677GB', 'reserved': '0.5176GB'}
after adding 1 adapted layers with rank 10000
{'allocated': '0.5264GB', 'reserved': '0.5762GB'}
after resetting
{'allocated': '0.0000GB', 'reserved': '0.0000GB'}
after loading the base model
{'allocated': '0.4677GB', 'reserved': '0.5176GB'}
after adding 24 adapted layers with rank 10000
{'allocated': '0.5273GB', 'reserved': '0.5762GB'}

As we can see, when adapting 24 layers vs 1 layer, the memory used is almost identical. We expect a small increase because vera_lambda_b and vera_lambda_d are not shared, so this is in line with our expectations.
As a sanity check, if we do the same with LoRA instead of VeRA, we see a big increase in memory used:
before loading the base model
{'allocated': '0.0000GB', 'reserved': '0.0000GB'}
after loading the model
{'allocated': '0.4677GB', 'reserved': '0.5176GB'}
after adding 1 adapted layers with rank 10000
{'allocated': '0.5263GB', 'reserved': '0.5762GB'}
after resetting
{'allocated': '0.0000GB', 'reserved': '0.0000GB'}
after loading the base model
{'allocated': '0.4677GB', 'reserved': '0.5176GB'}
after adding 24 adapted layers with rank 10000
{'allocated': '1.8740GB', 'reserved': '1.9238GB'}

All if this is a strong indicator to me that the memory sharing actually works. If anyone has ideas for more tests, let me know.

@dkopi @vvvm23 I think I'm pretty much finished with the implementation itself, docs and examples are yet to come. Still, if you have time, I'd be happy with a review or if you can run some tests to see if the implementation performs as expected. The changes compared to the original PR are documented above, the core VeRA computation hasn't been changed, though.

Hi @BenjaminBossan, I can do a review some time this week.

@vvvm23 Did you have time to take a look?

@pacman100 Thanks for the feedback, indeed I hadn't checked the docstring example. It is now changed to a working model.
Your comment also prompted me to take a look at the models that are pre-configured in TRANSFORMERS_MODELS_TO_VERA_TARGET_MODULES_MAPPING. This was just a copy of the the LoRA settings. Unfortunately, not all models work, I had to exclude some popular ones like Mistral, Mixtral, Phi, and gemma. The issue is again that the shapes of the target layer weights can differ. Hopefully, we can add the feature of supporting multiple different weight shapes in the future.

It would be great to add @vvvm23 and @dkopi as co-authors for all their guidance and work!

Yes, that was indeed my plan. @vvvm23 @dkopi could you please let me know how you want to be added as co-authors?

Likewise, you can add
 Co-authored-by: Alex McKinney<EMAIL_ADDRESS>

Done :tada:
Thanks again so much @vvvm23 for doing the majority of the work and @dkopi for your constant feedback.
Let's hope that VeRA gains traction in the community. For the future, I'll add this list of improvements for VeRA that have yet to be implemented (contributions are welcome):

Make VeRA work with different weight shapes. This is IMO the biggest limitation right now. Most straightforward way would be to have one pair of fixed vera_A/vera_B weights per target weight shape.
There are cases where the shapes are the same when transposed, so (4096, 1024) vs (1024, 4096) (down and up projections for instance) - I wonder if we can use the same weights here and just transpose them.
If this is done, implement VeRA for more layer types than just Linear. Right now, supporting, for instance, Embedding, makes little sense, as it almost always has a different shape than Linear.
Support quantized weights, most notably bnb.
Support DoRA ("DVoRA")

Thanks again @BenjaminBossan ! please tag me in issues and PRs related to improvements :)


Both links in README to examples are now dead!

Bottom of page:

https://github.com/tiny-http/tiny-http
Dead links:
https://github.com/tiny-http/heroku-tiny-http-hello-world
https://github.com/tiny-http/crate-deps

Hey everyone, do you have any other examples of tiny-http in action?  Especially small examples and demos?  The more the merrier!

Fixed in https://github.com/tiny-http/tiny-http/commit/d8ba6a2caf53f996e00d0dec2498957ecc2542ee
Also, if you're looking for more examples: https://crates.io/crates/tiny_http/reverse_dependencies


Fluentd Jfrog installer for Splunk and Datadog

Fluentd installer for Datadog, JFrog products: artifactory and Xray
Fluentd installer for Splunk, JFrog products: artifactory and Xray
Supported installation types: Fluentd as service (td-agent, VM), Fluentd as user installation (VM), Docker image

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA


ci: add refresh dependencies to more quickly propagate changes

Description
--refresh-dependencies helps this action pull changes more quickly. Because we typically cache gradle, that'll use the default behavior of 24h between changes ( https://docs.gradle.org/current/userguide/dynamic_versions.html#sec:controlling-dynamic-version-caching )

@ravisingal @kotharironak do you mind reviewing when you get a moment?


Undefined object TypeError on PR description page

Cannot read property 'comments' of undefined

Extension version: 0.10.0
VSCode Version: 1.36.1
OS: macOS 10.14.6

Steps to Reproduce:

Expand PR details in side panel
Click Description

Doesn't load new page, VSCode surfaces the error. This appears to occur inconsistently between PRs, but consistently on affected PRs

@john4 I'm having trouble reproducing this - do you have an example PR where this happens? What do the reviews look like on such a PR?


Not proper Example code

It seems to me that Example code isn't so proper.
Initial code:
Text003: Label 'The original sentence is \\: %1';
Text004: Label 'The sentence is converted to:\\ %1';
new code:
Text003: Label 'The original sentence is:\\%1';
Text004: Label 'The sentence is converted to:\\%1';

Hi @DmitrijYudin
Thank you for your feedback, but we can not check which page contains the error without the link. Could you please go to the bottom of this page and click on the button FeedBack->This Page to report this issue?
Thank you so much 😸

Closing this issue because information is missing. Please open a new issue with topic information. Thanks.


Demo lightrag_ollama_demo do not work; circular import error

I install lightrag-hku by running pip install lightrag-hku
I tried to run your example: https://github.com/HKUDS/LightRAG/blob/main/examples/lightrag_ollama_demo.py
I got the circular import error
Traceback (most recent call last):
  File "/home/ubuntu/eliran/dev/toolmate/package/toolmate/lightrag.py", line 3, in <module>
    from lightrag import LightRAG, QueryParam
  File "/home/ubuntu/eliran/dev/toolmate/package/toolmate/lightrag.py", line 3, in <module>
    from lightrag import LightRAG, QueryParam
ImportError: cannot import name 'LightRAG' from partially initialized module 'lightrag' (most likely due to a circular import) (/home/ubuntu/eliran/dev/toolmate/package/toolmate/lightrag.py)

I had this problem.  It was resolved by creating a new environment using conda.  Then ran the setup.
conda create -n lightrag_new python=3.11
conda activate lightrag_new
github clone

pip install -e .
Hope this helps.

Perhaps you should rename the Python file, as the lightrag file is conflicting with the lightrag module.
hope this can help you

Perhaps you should rename the Python file, as the lightrag file is conflicting with the lightrag module. hope this can help you

Thanks, this was the reason causing the error.  It is now sorted, thanks.  closing now.