this.callInitHooks is not a function

Hi,
I'm using leaflet.markercluster v1.5.1 against leaflet v1.7.1 via npm. I'm running against the error in the title by doing the following (leaflet and leaflet.markercluster css files are imported via scss):
const L = require( 'leaflet' );
require( 'leaflet.markercluster' );

const map = L.map( 'openmap' );
map.setView( [ 52.091259, 5.122750 ], 10 );

L.tileLayer( 'https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png?', {
    attribution: 'Map data © OpenStreetMap contributors, Imagery © Mapbox',
} ).addTo( map );

var icon = L.icon({
    iconUrl: require('../../node_modules/leaflet/dist/images/marker-icon.png').default,
    iconRetinaUrl: require('../../node_modules/leaflet/dist/images/marker-icon-2x.png').default,
    shadowUrl: require('../../node_modules/leaflet/dist/images/marker-shadow.png').default,
    iconSize: [32, 48],
    iconAnchor: [16, 48],
    popupAnchor: [0, -52],
    shadowSize: [50, 60],
    shadowAnchor: [14, 58]
});

const markers = L.MarkerClusterGroup();

const title = 'Test';
const marker = L.marker([52.0912, 5.122], {icon, title});
marker.bindPopup(title);
markers.addLayer(marker);

map.addLayer(markers);

I've made a Codepen to demonstrate the issue (check js console for the error). It also happens if I don't use the npm versions but just src the js and css files (see the codepen)

I've got the same issue

You need to add new to your statement new L.MarkerClusterGroup(); or you must use the factory method L.markerClusterGroup();


Quotes around code-signing identity

Hi,
Great project - it's very helpful. I noticed that the code-signing fails if an identity with spaces is provided, e.g. a fully-qualified identity like 3rd Party Mac Developer Application: Glass Echidna Pty Ltd (QUKQK3GKXK).
This PR fixes that :smile:

Hi,
sorry for the delay, holidays with no internet connection :)
This looks good, merged and updated version to 3.1.3.
Thanks !


[fix][broker]fix to deadlock due to failure during topic creation

Fixes #15131
The Bug:
There was a race condition where the thread would try to remove the persistent topic if there was a failure during create a topic, which would result in a deadlock because a thread was trying to acquire the write lock when adding it to the map while another thread was contending for the write lock attempting to remove the persistent topic from the map.
Motivation and Changes:
Remove the persistent topic from the map in another thread following a failure during topic creation, waiting asynchronously until the topic replication/deduplication checks are fully completed/shut down before removing the topic from the map.

[x] no-need-doc

@nathanielsilverman #15131 has been fixed by #15570


2.6.1 Cannot read property of custom enum list

Custom enum like this:
@Getter
@AllArgsConstructor
public enum AccountType {
    CASH("现金账户", 2),
    BANK("银行账户", 3);

    private String name;
    private int code;
}

Pojo like this:
@Data
public class AccountQuery {
    @ApiParam(value = "账户号类型，支持多值", allowMultiple = true)
    private List<AccountType> type;
}

Controller method like this:
    @RequestMapping(value = "/account", method = GET)
    @ApiOperation(value = "查询账户", notes = "分页查询")
    JsonResult getPage(@ModelAttribute AccountQuery query) {
        return ok();
    }

Then the html page does not show the property 'type', I can not figure out why.
I found that ExpandedParameterBuilder#apply skiped this property.

add a @Setter annotation to account type and everything should be fine. This is a requirement by springfox to simplify model attribute evaluation

Er……It doesn't seem to work.
First, I add a @Setter annotation to the class like this:
@Setter
@Getter
@AllArgsConstructor
public enum AccountType {
    CASH("现金账户", 2),
    BANK("银行账户", 3);

    private String name;
    private int code;
}

It will cause a compile error.
Then, I add setter manually, like this:
@Getter
@AllArgsConstructor
public enum AccountType {
    CASH("现金账户", 2),
    BANK("银行账户", 3);

    private String name;
    private int code;

    public void setName(String name) {
        this.name = name;
    }

    public void setCode(int code) {
        this.code = code;
    }
}

The ui shows  "type[0].code" and "type[0].name" as the parameters,  and not multiple values, which is out of my expectation.
I want the ui to display that parameter is "type", and value is a textarea with the placeholder of "Provide multiple values in new lines."

I remember the version 2.5.x can display what I expected.

I pushed my code to https://git.coding.net/jearton/springfox-demos.git

@jearton Sorry I haven't had ⏲to get to it. With the holidays it might be a couple of weeks.


Polyfill Object.assign

This is all we really need to support IE9.

Mutating built-ins (Object, String.prototype) seems like it smells—if the polyfill has bugs then potentially we can affect other libraries in strange ways!
In this case Object.assign seems pretty harmless to me, since it's pretty simple and well-defined...but I still wonder if it'd be better to only polyfill it locally (var extend = typeof extend === 'undefined' ? Object.assign : ...)
Thoughts? Are my concerns unfounded? :)

Yeah, that's a fine way to do it.

Might be worth adding a comment / commit message saying this is motivated by IE9. :-)


fix silent error in run_task

Thanks for your contribution!
Could you please provide a brief description to your PR? For example, the output before and after this PR, and possibly some test code for the review.

Thanks for your contribution!
Could you please provide a brief description to your PR? For example, the output before and after this PR, and possibly some test code for the review.

async def main(page: ft.Page):
    async def task():
        1 / 0  # silent error, my PR fix it

    async def raise_error(e):
        page.run_task(task)

    btn = ft.ElevatedButton(
        text="Raise error",
        on_click=raise_error,
    )

    page.add(btn)

app = ft.app(main, export_asgi_app=True)

if __name__ == "__main__":
    import uvicorn

    uvicorn.run(
        "app:app",
        host="<IP_ADDRESS>",
        port=8550,
        reload=True,
    )


Optimize sui CLI response format

Description
Optimize sui CLI response format

Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)

[ ] protocol change
[x] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Thanks @howtosui


[PROPOSAL] - adding IF EXIST , IF NOT EXIST , TTL keywords to sql syntax

In some case of database migration , we need to check if there is some property in the class , class , cluster , record , index or function and then execute a sql statement.
If you add some keywords to orientdb like the IF EXIST or IF NOT EXIST the programmers can write more efficient and simple database migration procedures .
TTL keyword would be useful in Time To Live for entire of record , index  or even some property of a document .
Welcome to your comments
Saeed

Hi @lvca
As i see in https://github.com/orientechnologies/orientdb/issues/1110 this issue is open .
i prefer to use TTL keyword with the suggested  syntax .
Thanks
Saeed Tabrizi

Hi @saeedtabrizi
Happy to help :-)
For the TTL we have no specific plans, but I'll talk to the team about it, maybe we can include it in 3.0
Thanks
Luigi

This is already in v3.0-m2.

@lvca
Hey, please i still can't find any documentation about TTL in orientdb 3.0- , can u tell me about it please
thanks,
Moayad

Same here !! Checked the orientdb documentation for 3.0 but couldn't find any info regarding TTL option !!


[GRL Test 9.2.7] Operational Dataset synchronization issue

Certification Test 9.2.7 fails if the Router node in the topology is running the OpenThread stack.
As per Thread 1.1.1 spec section <IP_ADDRESS>.1  and <IP_ADDRESS>.2,  when attaching to a Thread Network Partition, if the newly received Active/Pending Timestamp is older than what the Thread Device had before attaching, the Thread Device MUST attempt to update the Leader with its newer Active/Pending Operational Dataset. This behavior is not observed on the Router node. The Router (testbed) node fails to synchronize its (newer) active and pending operational datasets, in turn, causing the test case to fail.
It appears that there may also be a potential test plan bug, as the test plan (version R68) steps 5 and 11 instruct the harness to initiate this synchronization for the Router, which should not be the case, as per spec section <IP_ADDRESS> and  <IP_ADDRESS> which states that:
A Thread Device that has a newer Active/Pending Operational Dataset, as determined by the Active/Pending Timestamp included in Thread Network Data, MUST provide its newer Active/Pending Operational Dataset to the Leader by sending a MGMT_ACTIVE/PENDING_SET.req to the Leader
Although the attached traces are for an older version of OpenThread, I have also observed this issue on a relatively newer version of the OpenThread stack

@schinchani , thanks for raising this issue. I have submitted a proposed fix with #6813. Please review.


Add addGestureRecognizer in code

Hello I'm using his great code, how can I add tap in scrollview
The code below works if it is equal to two ()
@IBOutlet weak var scrollView: UIScrollView!
@IBOutlet weak var pageControl: UIPageControl!
@IBOutlet var images: YiiPagedImages!
let TapRecognizer = UITapGestureRecognizer(target: self, action: "someAction:")
TapRecognizer.numberOfTapsRequired = 2 //(must be 1)
TapRecognizer.numberOfTouchesRequired = 1
scrollView.userInteractionEnabled = true
scrollView.addGestureRecognizer(doubleTapRecognizer)

Hi, hmm, I do not know why it is not working with a single tap. (I assume that is what you are asking).
You can implement it this way:
The YiiPagedImages object has a delegate property. That delegate has a tegPagedImagesCellViewDelegate_onImageTapped method that is called when an image in the scroll view is tapped.
If it does not work for you, there is an alternative I wrote recently: https://github.com/evgenyneu/Auk

Ah, have you tried TapRecognizer.cancelsTouchesInView = false?
http://stackoverflow.com/a/16885076

Thanks, with your help managed to solve


Add check to generation of s in issuer public key

The implementation uses the method described in p24 of this CL paper when generating the issuer public key, which involves sampling a random quadratic residue S and from that computing random powers to generate additional residues.  However, as stipulated in the paper, this method only works if S is a generator of the group of invertible quadratic residues mod n. This can be checked by verifying that it has order equal to the product of the Sophie-Germain primes p' and q' used to construct the safe RSA modulus n, but this check is not done  in the implementation.
Since p' and q' are coprime and are primes, every invertible quadratic residue has order 1, p', q' or p'*q'.  It therefore suffices to check that S is not 1, that S^p' is not 1 mod n, and S^q' is not 1 mod n.
Added this check in a separate PR from my other one but both need to be integrated - hope it makes sense!

Sure, will do.


Publisher screen (/enable)

@dylancom can you update the yarn.lock again to make it mergeable?
The prompt is pretty huge on my screen? is this intended? how do we manage sizes?


Out source parameters for action Slack to Slackfile?

Question Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Question Subject

slack action

Question Description

Hey!
I want to out source some parameters like slack_url for the action slack to a separate file. Other actions like match does support this (Mathfile). But if I create a Slackfile and write the slack_url to it, it seams that the slack action doesn't find this.
Can you tell me if slack doesn't support an extra file? Are these files just a feature of gym, match and others or does every action support this by default? Are there good alternatives to "out source" parameters like slack_url which are equal for every lane in the Fastfile for our project?
Thanks,
Fabian

Have you tried the Appfile? https://docs.fastlane.tools/advanced/Appfile/


Vue lost reactivity of array of object

Vue version
3.2.38
Link to minimal reproduction
https://github.com/amm834/vue-supabase-workout-app
Steps to reproduce

click Create nav link.
Select Workout Type and then click Add Exercise
It will show up the following input.

Open dev tool and watch the input form v-model state. It is reactive.
And click Add Exercise you will see the generated form input as following

open dev tool and watch the second input.
its v-model won't be reactive. That is bug. It is not working vue's deep reactivity.

see
https://github.com/amm834/vue-supabase-workout-app/blob/3a208d09a5b19103806c2195c91ac4d3d7fd3a6a/src/components/CreateWorkout.vue#L69
I have to initialize for union typed array, if i don't initalize that nothing will be shown when i select that workout type.
see
https://github.com/amm834/vue-supabase-workout-app/blob/3a208d09a5b19103806c2195c91ac4d3d7fd3a6a/src/components/CreateWorkout.vue#L71
It is the problem of lost of deep reactivity.
According to the vue doc it should work as expected. But it is not working.
What is expected?
Object inside that array should be reactive when I use it with v-model
What is actually happening?
Reactive object is lost of it behavior what you called reactive inside the array. Vue doc mentioned object inside the array is reactive cuz of deep reactive mechanism but it is not working as expceted to be vue doc mentioned .
See
https://vuejs.org/guide/extras/reactivity-in-depth.html
System Info
System:
    OS: Windows 10 10.0.22000
    CPU: (4) x64 Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz
    Memory: 1.35 GB / 7.66 GB
  Binaries:
    Node: 16.15.1 - C:\Program Files\nodejs\node.EXE
    npm: 8.11.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22000.120.0), Chromium (105.0.1343.42)
    Internet Explorer: 11.0.22000.120
  npmPackages:
    vue: ^3.2.38 => 3.2.39

Any additional comments?
Write more example and documentation for vue typescript. And example for how to manipulate with complex data structure and v-model. In fact, vue is lack of expert example in vue doc. Please provide that.
If vue support on the fly v-model value that can be a great feature for us.

So, it seem works when I console log the array. But still not working in Vue dev tool. Vue dev tool must be reactive. It's bug of devtool.

So, it seem works when I console log the array. But still not working in Vue dev tool. Vue dev tool must be reactive. It's bug of devtool.

you should move this issue to https://github.com/vuejs/devtools


Blur not working on iOS 8 target

I'm not sure if anyone has a fix for this but I've been trying to use this library I have everything setup but can't seem to achieve the blur like in the demo. I have navigation setup and working correctly but I cannot set a blur or blur tint color. I'm able to customize direction and a couple other properties but the blur does not seem to be working. The only thing I can think of is that this does not work for iOS 8. Here is my RootViewController's awakeFromNib:
- (void)awakeFromNib {
   self.contentViewController = [self.storyboard instantiateViewControllerWithIdentifier:@"homeController"];
   self.menuViewController = [self.storyboard instantiateViewControllerWithIdentifier:@"sideMenuController"];
   self.liveBlur = NO;
   self.liveBlurBackgroundStyle = REFrostedViewControllerLiveBackgroundStyleLight;
   self.blurRadius = 60;
   self.blurTintColor = [UIColor colorWithRed:45/255.0 green:55/255.0 blue:56/255.0 alpha:0.6];
}

Interesting....figured it out but I had to set the view color of menuViewController to clear in my RootViewController. That's something I wasn't seeing in the demo and didn't see mention of.

Interesting....figured it out but I had to set the view color of menuViewController to clear in my RootViewController. That's something I wasn't seeing in the demo and didn't see mention of.


chore: fix workflows

https://github.com/reactjs/zh-hans.react.dev/actions/runs/4580306178/workflow#L13
Why didn't these changes apply? I think I need to merge it to have a look.


feat: add esplora block source support

Description
The bitcoin backend currently supported are both bitcoind and electrum (without integration tests at the moment), as mentioned in #1187 having multiple, easy to use, bitcoin rpc backend support is useful for dogfooding federations and easy setup/deploy.
That said, this PR aims to implement and support Esplora support, although as it's for Electrum it currently does not have any integration test (I'm working on that 😁).
How
This adds a new implementation for the IBitcoindRpc trait for Esplora client. However, it could be implemented by using reqwest and calling each endpoint available on the Esplora API, this PR uses the rust-esplora-client as it's abstract all that logic and makes it easy to use, which is maintained by BDK team.
fixes #1187

Codecov Report
Base: 64.92% // Head: 64.18% // Decreases project coverage by -0.75% :warning:

Coverage data is based on head (96d236d) compared to base (14b440a).
Patch coverage: 0.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1564      +/-   ##
==========================================
- Coverage   64.92%   64.18%   -0.75%
==========================================
  Files         129      129
  Lines       23306    23570     +264
==========================================
- Hits        15132    15128       -4
- Misses       8174     8442     +268

Impacted Files
Coverage Δ

fedimint-api/src/bitcoin_rpc.rs
0.00% <0.00%> (ø)

fedimint-bitcoind/src/bitcoincore_rpc.rs
0.00% <0.00%> (ø)

fedimint-bitcoind/src/lib.rs
6.57% <0.00%> (ø)

fedimintd/src/ui.rs
0.00% <0.00%> (ø)

modules/fedimint-wallet/src/lib.rs
77.34% <0.00%> (+0.11%)
:arrow_up:

gateway/ln-gateway/src/utils.rs
61.53% <0.00%> (-30.77%)
:arrow_down:

crypto/tbs/src/hash.rs
3.87% <0.00%> (-9.46%)
:arrow_down:

fedimint-server/src/net/peers.rs
90.11% <0.00%> (-1.50%)
:arrow_down:

fedimint-core/src/util.rs
84.73% <0.00%> (-0.91%)
:arrow_down:

fedimint-api/src/macros.rs
13.57% <0.00%> (-0.07%)
:arrow_down:

... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I'm not sure why requesting a re-review for one user is removing the request for another one 🤯


Incorrect (or missing or changed?) repo component name

The zoom component has gone missing from the repo, replaced by a main component.
I'm not sure whether this is intentional or not.
This is probably related to #9.

Details:
With
deb [arch=amd64 signed-by=/etc/apt/keyrings/mwt.asc by-hash=force] https://mirror.mwt.me/my/deb any zoom

or
deb [arch=amd64 signed-by=/etc/apt/keyrings/mwt.asc by-hash=force] https://mirror.mwt.me/zoom/deb any zoom

I now see:
$ sudo apt update
Ign:1 http://dl.google.com/linux/chrome-remote-desktop/deb stable InRelease
[...]
Hit:13 https://mirror.mwt.me/my/deb any InRelease
[...]
Hit:21 https://esm.ubuntu.com/infra/ubuntu jammy-infra-updates InRelease
Fetched 110 kB in 7s (16.7 kB/s)
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
All packages are up to date.
W: Skipping acquire of configured file 'zoom/binary-amd64/Packages' as repository 'https://mirror.mwt.me/my/deb any InRelease' doesn't have the component 'zoom' (component misspelt in sources.list?)
W: Skipping acquire of configured file 'zoom/i18n/Translation-en_US' as repository 'https://mirror.mwt.me/my/deb any InRelease' doesn't have the component 'zoom' (component misspelt in sources.list?)
W: Skipping acquire of configured file 'zoom/i18n/Translation-en' as repository 'https://mirror.mwt.me/my/deb any InRelease' doesn't have the component 'zoom' (component misspelt in sources.list?)
W: Skipping acquire of configured file 'zoom/dep11/Components-amd64.yml' as repository 'https://mirror.mwt.me/my/deb any InRelease' doesn't have the component 'zoom' (component misspelt in sources.list?)
W: Skipping acquire of configured file 'zoom/dep11/icons-48x48.tar' as repository 'https://mirror.mwt.me/my/deb any InRelease' doesn't have the component 'zoom' (component misspelt in sources.list?)
W: Skipping acquire of configured file 'zoom/dep11/icons-64x64.tar' as repository 'https://mirror.mwt.me/my/deb any InRelease' doesn't have the component 'zoom' (component misspelt in sources.list?)
W: Skipping acquire of configured file<EMAIL_ADDRESS>as repository 'https://mirror.mwt.me/my/deb any InRelease' doesn't have the component 'zoom' (component misspelt in sources.list?)
W: Skipping acquire of configured file 'zoom/cnf/Commands-amd64' as repository 'https://mirror.mwt.me/my/deb any InRelease' doesn't have the component 'zoom' (component misspelt in sources.list?)

And apt is not finding zoom:
$ apt list zoom
Listing... Done
zoom/now <IP_ADDRESS>25 amd64 [installed,local]

(The ,local indicates the package is not available in a configured repo.)
Changing the component from zoom to main, e.g.
deb [arch=amd64 signed-by=/etc/apt/keyrings/mwt.asc by-hash=force] https://mirror.mwt.me/zoom/deb any main

fixes the issue.
$ sudo apt update
Ign:1 http://dl.google.com/linux/chrome-remote-desktop/deb stable InRelease
[...]
Get:12 https://mirror.mwt.me/zoom/deb any InRelease [1,777 B]
[...]
Get:24 https://esm.ubuntu.com/infra/ubuntu jammy-infra-updates InRelease [7,449 B]
Fetched 2,577 kB in 7s (373 kB/s)
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
All packages are up to date.

$ apt list zoom
Listing... Done
zoom/unknown,now <IP_ADDRESS>25 amd64 [installed]

Ah.  I see the README has now been updated to indicate that the appropriate component name has been changed to main (from zoom).
Closing.

Thanks. It's still useful because I intended for the old component to still work through a redirect, but I guess it doesn't.

To be clear, this has to do with the change of component name (from zoom to main), not the change of URL path (from /my/ to /zoom/).
As the warning messages state, the current InRelease only lists a main component:
Components: main

so apt, apparently, refuses to even look for a zoom component.

Yeah, I should have realized that. Components aren't individually signed. So, it can't look for a zoom component.


Make models more general

Components can now use any number of parameters and are no longer restricted to just sed and morph. This requires some structural changes to allow them to update their gradients, moving the majority of Blend._backward into Component, including the actual gradient update.
A bug fix was also implemented (interpolation.fft_convolve used the numpy.prod function that was not wrapped in autograd) and dead code (the symmetric center algorithm) was stripped out.

Can we close this PR? It's not an active development, and I can delete the fullscene branch without closing this PR. Just to be clear, I don't want to delete the parameters branch, which has independent code development, just fullscene, which is fully merged

Yes, that's fine. I'll close the PR but keep the branch.


Illegal characters

How ca i fix Illegal characters error ?

This has nothing to do with GetX,
I believe you should have copied this source code from another location and the space character has been replaced by the character 160, just delete each space you see and type space again

Thank Yooooooouuuuu for helping me 😇

This has nothing to do with GetX,
I believe you should have copied this source code from another location and the space character has been replaced by the character 160, just delete each space you see and type space again

As mentioned by Eduardo, this is a character conversion error that happened when you copy content from a website, and paste it directly into your IDE. As this is not related to Getx, I am closing.


Log in - Text is overlapped when tapped on "Back" when have autofill option

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to staging.new.expensify.com
On log in page put your email
Click on Back option

Expected Result:
Text is not overlapped when tapped on "Back" when have autofill option
Actual Result:
Text is overlapped when tapped on "Back" when have autofill option
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
Mobile Web

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/204868875-0c129fca-88e2-4f3e-bc09-257873b7e7a2.mp4
https://user-images.githubusercontent.com/93399543/204868876-5f9215f8-d33c-4c07-bed4-2f98a2d094c1.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

I can't reproduce this, @alexpensify can you test it as well to see if we can close it?

Coming back online from being OOO, I'll test tomorrow.

I'm not able to reproduce it either - I tried it with the same email used in testing.

Ok, let's close it if no one can reproduce it.


Fixes(216): Add option cwd to concurrently and to command options

Fixes #216

Coverage remained the same at 100.0% when pulling c15e76f14421a94c3f5bafad218e9abb7250cb67 on thdk:feat/spawn-option-cwd into b62a2a1c92caa590b78f336cc8fcef745e5a7832 on kimmobrunfeldt:master.

@gustavohenke & @kimmobrunfeldt it would be great to get this merged in and released.


Request: Backspace, or really any flow break resets counter

If you click the editor thats a flow break. If you backspace, thats a flow break. Etc. So really just break actions. If I find the time over my work break I'll fork and submit a pull.

This or #217 would be awesome to have.


Update m365-lighthouse-understand-deployment-statuses.md

@SKjerland - Made a small change.

@pabloang1 - Looks good to me! I went ahead and merged it.


locked services should only be included in output if they would have been changed

Note below default/ui-server shows as skipped, but it doesn't use that image, so wouldn't have normally been affected. Seems odd to include it.
$ fluxctl release --all --update-image=quay.io/weaveworks/scope:master-2fe3216e
Submitting release job...
Release job submitted, ID 6e45282d-e199-ca22-693e-2c60d1ac1389
Status: Complete.

Here's what happened:
SERVICE            STATUS   UPDATES
default/ui-server  skipped  locked
extra/demo         success  demo: quay.io/weaveworks/scope:master-456ac0bf -> master-2fe3216e
kube-system/scope  success  scope-app: quay.io/weaveworks/scope:master-456ac0bf -> master-2fe3216e
scope/collection   success  collection: quay.io/weaveworks/scope:master-456ac0bf -> master-2fe3216e
scope/control      success  control: quay.io/weaveworks/scope:master-456ac0bf -> master-2fe3216e
scope/pipe         success  pipe: quay.io/weaveworks/scope:master-456ac0bf -> master-2fe3216e
scope/query        success  query: quay.io/weaveworks/scope:master-456ac0bf -> master-2fe3216e
Took 42.864772s

Requirement
iff (-s=service-name || (--all && uses the image we're talking about)) ; only images that pertain to a service should be shown in the output


Not a mac app

There is no mac app for this.

https://github.com/RedddFoxxyy/Rhyolite
Checkout this, fork of fextify and also supports mac! Sometimes the arm64 version can crash, u can also use the x64 version, it also runs on M series chips!


IndexOutOfBoundsException when giving initial commands to Repl.run

Trying to set up ammonite-repl in sbt to include imports, but it’s throwing an error.  Here is my setup code:
initialCommands in console := s"""ammonite.repl.Repl.run("import org.joda.time._")”""
Error is:
Loading Ammonite Repl... import org.joda.time._java.lang.IndexOutOfBoundsException: Index: -1, Size: 0 at java.util.LinkedList.checkElementIndex(LinkedList.java:555) at java.util.LinkedList.get(LinkedList.java:476) at jline.console.history.MemoryHistory.get(MemoryHistory.java:96) at ammonite.repl.frontend.JLineFrontend$$anon$1.update(JLineFrontend.scala:110)

I'm 99% sure I've seen this before and it was a result of a corrupted ~/.amm history file. https://github.com/lihaoyi/Ammonite/issues/101 should fix this so the file won't get corrupted so easily

This happened on the first run on a new machine, with no ~/.amm history file.

This has been totally revamped, want to give it another shot?

Closing for now, feel free to re-open

Test with 0.4.5, and it works now!

Yay =)


Is there a Linux version or not?

From what I have seen in the issues, there has been a Linux version of Kitematic and it's still indicated in the readme file that you are supporting Linux, but I don't see any guides to install it. Is there a way?

Absolutely - If you look in the release there's a package that you can download:
https://github.com/docker/kitematic/releases/tag/v0.13.0
Then install it - it's an ubuntu based package which will also work in debian.
If you have any terminal issues, please see the wiki:
https://github.com/docker/kitematic/wiki/Early-Linux-Support

Ok thx a lot! It could be great to have some indications on the ReadMe file though

@samdidos Feel free to update the Wiki with a nice how-to while you install it :)

The latest Ubuntu package is at https://github.com/docker/kitematic/releases/latest


Give option to controll whether to clear .nuxt before build or not

What problem does this feature solve?
When using the commands you give out to update an online server:
nuxt build
nuxt start

You know nuxt build costs a lot of time. Before building, the dist folder was removed,  that causes that user cannot get the resources in dist.
In other words, server can not supply good service when building.
What does the proposed changes look like?
If user set to not clear .nuxt before build, all the build files will be saved. That means  server can supply good service when building.

This feature request is available on Nuxt community (#c8484)

We now keep the build directory mostly in memory with VFS in nuxt 3, so I think we can close this issue.


remove sending of usage emails

Remove the sending of usage emails. This will be added again later, once we settle on a new implementation.

See #1316 and #1321.


Add a tooltip for the CSV file upload component, linking to docs.

There isn't a mocked tooltip or copy for this, but it's a helpful stopgap while we iron out issues.

 Bug fixes


Which licensing is required?

Could you give some more information about the licensing required to be able to use the view only meeting experience?
Who needs to have the license, the view-only user or the meeting organizer?
What about O365 E3 / E5 licenses (in contrast to Microsoft 365 E3 / E5 lienses)?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2bf705c2-1f24-bdb5-e712-e8408b941aca
Version Independent ID: ddedd7e0-7d85-06e0-7f20-8b83b3dccec7
Content: View-only meeting experience - Microsoft Teams
Content Source: Teams/view-only-meeting-experience.md
Service: msteams
GitHub Login: @cichur
Microsoft Alias: v-cichur

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

Thank you for immediately closing this issue and replying with an automatic text. :(
I thought this is about providing documentation for Microsoft products.
And licensing is in my opinion also part of a documentation. And you already mention licensing in the current document, but it is incomplete.
A service ticket is not helpful in this case.


ReactNative's state update via this.setState breaks text input mode for Korean, Chinese, Japanese characters in 0.54 and 0.55

Environment
Environment:
OS: macOS High Sierra 10.13.4
Node: 6.11.0
Yarn: Not Found
npm: 3.10.10
Watchman: Not Found
Xcode: Xcode 9.3 Build version 9E145
Android Studio: 3.0 AI-171.4443003
Packages: (wanted => installed)
react: ^16.3.1 => 16.3.2
react-native: ^0.55.4 => 0.55.4
Steps to Reproduce
This issue has been reported number of times already. #19313 #18403 #19104 #19337 #12599 #18379 #18767 #18260
However, most of them reported the issue as being the TextInput bug whereas the real bug seems to lie with ReactNative's view re-rendering logic in iOS. This report is to unify them under a more proper title so that someone who is more likely to recognize the root cause of this issue can pay attention.
If there is a TextInput tag in jsx file and its onChange or onChangeText callback has this.setState() call, Korean, Chinese, Japanese characters (which have multi-stage character input mode) are not input correctly.
In caes of Hangul(Korean), if the cursor is at the end of the text, the input is handled properly. However, if the cursor is at the beginning or is in the middle of the text, the input character parts are not combined as they should be. The parts of a character that should form a single character are input separately by themselves.
To reproduce, just type some Korean characters in TextInput, such as "하늘". Then move the cursor to the beginning of the text, and then type any text. Let's say I typed "파란" this time.
Expected Behavior
The text should be input like "파란하늘" (meaning blue sky)
Actual Behavior
However, as of RN version 0.54 and 0.55, the text is input like "ㅍㅏㄹㅏㄴ하늘"
Chinese characters and Japanese kanji characters are input by first entering romanzi to specify the pronounciation and then the user select a character from a list of Chinese characters popup that appears. However, this popup does not appear at all, as demonstrated in #18403.
Korean, Chineses, Japanese characters input is handled by multi-state IM mode. However, setState => view re-rendering cycle of ReactNative in v0.54 and v0.55 seems to reset the "character input is in progress" IM mode, thus causing incomplete and/or no characters to be entered into TextInput field.
This is a rather serious issue for Korean, Chinese, Japanese developers who have no options but to stick with v0.53 or below. (0.53 is particularly unstable version so I am stuck using v0.52.3) If anyone can guess where this issue might be stemming from, please share your opinions. It would be very much appreciated. Thank you.

I forgot to mention that this is an iOS only issue.

@daesan can you reproduce this issue on react-native 0.56.0? I can't anymore...

@mandrigin Thank you for working on this issue! Unfortunately, I can reproduce the issue with both single-line TextInput and multi-line TextInput on RN 0.56.0...

Any updates on this issue? This only happens when you use iOS default input method, if you use third party input method, this problem will disappear.

Does this commit fix it? https://github.com/facebook/react-native/commit/892212bad2daadd373f4be241e4cd9889b0a1005

Does this commit fix it? 892212b

in RN 0.57 , Japanese solved but not Korean

Also encountered such a problem, it is suggested that using onCompositionStart/Update/onCompositionStartEndURL

@rarira @KouSyurei We experienced this issue ourselves and I tried to workaround this issue for Korean (but only for the multi-line text fields).
Here is a PR for that: https://github.com/facebook/react-native/pull/19809
If that solves your issues, please ping me, then I can extend it to the single-line text fields too.
PS: it would be nice to receive any feedback on that PR, from the core contributors. It's a bit hacky, I know, and if there is a better way to fix it, I'd ❤ to know that and I can commit to fix it. Being able to use a non-patched React Native version is worth it 🙂

Here is a fix for single-line text fields: https://github.com/facebook/react-native/pull/22546

Facing a similar issue when trying to put a  inside of  to get custom styles of text while typing. Something like <TextInput ...props>{this.state.textinput}.
While typing Chinese pinyin like haha("哈哈"), press h, then the input goes to h'aha', which the first h is turned to a simple alphabetical character.

@mandrigin Will check it out. My project is based on 0.51, so I need some time.

@mandrigin Upgraded my project to RN 0.57.7 last night. And interesting thing is, on 0.57.7, the issue I described above is fixed. And I didn't touch the RN branch you mentioned yet.
I am not sure if the issue I got is related to your problem. Sorry if I am not helpful.

@mandrigin  thanks for your effort, and after updating 0.57.8, there is no Korean multiline textinput issue!.. 0.57.7 still had the problem. Thanks!

@rarira great to hear! I hope the fix for single-line text fields will land soon too!


count accounts for multiple of same items

Added into the handle list change for the code to add the price of the item change to the list of prices, when the item is not completed.

I didn't get a notification for the pull request sorry! The total pricing is correct, the items just disappear after being clicked more than twice. I will merge this pull request and open another issue for it.


Error during install- adsb portal collectd pakage

Hello .
When i run the script one of the options is  if you would like to install the ADSB-Portal.
During the installation of these part of script send me an error:
Checking if the package collectd-core is installed [NOT INSTALLED]
them try to install :
Checking if the package collectd-core is installed  Inastallation attempt failed
Will attempt to Install the package collectd-core again in 5 seconds (attempt 1 of 5)
And exit with error , beacuse que collectd-core is not avaliable for instal...
Im trying to install collectd-core but the  pakage is no avaliable in the oficial repository. Its posible to add any repository thats include the pakage ?
Anyone can help me ?
thnaks

Which distribution are you attempting to install the portal on?

Which distribution are you attempting to install the portal on? There might be a naming difference I will need to compensate for. It should be noted that it has been reported that Debian Trixie does not have this package available at this time.

Armbian into a Orange pi lite,  Ubuntu 24,04 with xcfe desktop


Added tests for hipStreamDestroy

CMakeLists.txt was updated so any changes to config_amd_*.json copied when the project was rebuilt.
Unit_hipStreamDestroy_DoubleDestroy fails, but this could just be undefined behaviour.
Unit_hipStreamDestroy_WithPendingWork was found to hang, I think this is due to hipStreamDestroy not synchronizing before destroying the stream, but I'm not sure what the intended functionality is.
Depends on #2517

Any update on this?

Hi @chrispaquot. @jatinx looking at a solution using managed memory but hit a bit of a snag with the atomics, more details are in ticket EXSWCPHIPT-78.

@chrispaquot This is ready for review now. Unfortunately we've not been able to find a cross-platform reliable solution to replace the kernel that runs for a long time, but the current solution is at least reused between multiple tests. Due to that reuse, this PR is block by PR #2750.

@chrispaquot @mangupta This is now unblocked and ready to merge


supplements db no longer hosted at eveem

Currently having trouble getting started because this fetch fails: https://github.com/eveem-org/panoramix/blob/master/utils/supplement.py#L193
Would it be possible to share a zip of the supplements db somewhere else? in the meanwhile, i can just create an empty supplements.db locally, but it'd be nice to work with the ones you already have :)

@lsankar4033 : by creating an empty sample locally, do you mean that you understand the format inside the zip file ?
Because most projects like this are using https://www.4byte.directory.

I just created an empty sqlite db with the same table structure (informed from the queries in panoramix) and it works fine without function names. Building off of 4bytes makes sense going forward though.

@lsankar4033 : hemm, no. Don’t close this. You may have understood the table structure but no me. Nor do I understand where to write such file. Can you please share it with me ?

@lsankar4033 : please !

I made a fork where I committed a proper supplements.db (as an xz-compressed file that gets decompressed when panoramix runs):
https://github.com/palkeo/panoramix
The supplements.db I have is from when eveem was up, and this one has not been updated in a while, though. I'm thinking about a way to regenerate an updated one.

@palkeo it simply turns out Panoramix had everything.
from utils.supplement import crawl_abis_from_cache
crawl_abis_from_cache()

and it adds the abi files present in the cache_abi directory.

Eveem.org was down briefly, I restarted it, so you should be able to fetch it now no problem :)

@ytrezq as for crawl_abis_from_cache, it will make the supplement from your local abis, which will miss a ton of function definitions, so fetching it from eveem or palkeo's repo will be much better.
(and thanks @palkeo  for stepping in here with your repo)


Follow-up from "Added default option to config_jsonschema, with injection on validation."

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/42
Originally created by @aaronsteers on 2021-03-15 23:29:18

The following discussions from !12 should be addressed as follow-on steps:

[x] @aaronsteers started a discussion:

For berevity and reusability, can we move this extend_with_default() function into singer_sdk.helpers.tping?
And then after importing, this line can be identical:
JSONSchemaValidator = extend_with_default(Draft4Validator)

[x] @aaronsteers started a discussion:

If accessing the private _config member, this method should probably also be made private (_validate_config() instead of validate_config()).
I think either is fine: we could wrap again with dict(self.config) to avoid accessing the private member, or just make the whole method private.
Now that we are implementing JSON Schema, the validate method should not need to be public or overriden by subclasses. I checked for other references, and it is only referenced in __init__() here in this file.

View 4 previous comments from the original issue on GitLab


Add Dockerfiles with Debian and Alpine base images

Hi there!
I created two Dockerfiles for jsonlint. There is probably room for improvement in those, but feel free to use them, if you like.

Neat. Thanks for the contribution!


Resolve errors when using with Sinon 2

Sinon 2 (currently in beta) fixes a lot of useful stuff, primarily dealing with its module breakdown so that you can import sinon from "sinon" in an ES6-transpiled browser environment such as Webpack or Browserify.
However, the interface has changed a little, and 'behavior' is no longer an exported sinon object, rather it's being treated as internal to the stub module. This patch resolves this by patching behavior internally, in a conditional way so that the module maintains sinon 1 compatibility.

Unfortunately this probably isn't a viable approach since it'll break in Browserify.

Fortunately, it looks like patching behaviour was an unnecessary and redundant code path, anyway. If you look at the way sinon loads the behaviours in both 1.17 and 2.1, in both cases it's iterating through the behaviour prototype and augmenting the stub module with the behaviour methods.
So, the only thing you need to do after the fact is augment the stub module directly. I've updated the PR to reflect this - there's no optional require now so Browserify will still work without the -u flag.

That's there to allow stub.onCall(0).resolves('foo')

Well, that's a shame. There doesn't seem to a way to fix this without changing the API for sinon 2, or stipulating the Browserify users should use the -u sinon-as-promised flag in their config.
I've put in an issue with Sinon to add behaviour to Sinon 2's top-level exports, but given the number of open issues I don't expect it to happen any time soon.


Fix jsonv2 log format

Fixes #999.
Note: #1000 Yay! :tada:

@dmuhs , something similar is also present in mythril/interafaces/cli.py in the exit_with_error() function, can you also change that?

@norhh Fixed, thanks for the catch!


Monitor listener not present after reconnect

I have my Redis master setup on a private DNS name with a TTL of 30. Average reconnection it obviously around that time once everything propagates.
One thing I've noticed is that any monitor that is running on the client is not present after a reconnect.
To see if I could recreate it on a reconnect I first called monitor.off('monitor'); and then attached the listener again once redis.status was ready.
It's not an important part of my server so I wasn't worried about it not working, but one thing that happened was this lovely error:
[2015-05-29 20:30:50.073] [ERROR] [Server]-> Caught exception: Error: Command queue state error. If you can reproduce this, please report it.
    at Redis.exports.returnReply (/home/compilr/node_modules/ioredis/lib/redis/prototype/parser.js:125:33)
    at HiredisReplyParser.<anonymous> (/home/compilr/node_modules/ioredis/lib/redis/prototype/parser.js:27:10)
    at HiredisReplyParser.emit (events.js:107:17)
    at HiredisReplyParser.execute (/home/compilr/node_modules/ioredis/lib/parsers/hiredis.js:42:12)
    at Socket.<anonymous> (/home/compilr/node_modules/ioredis/lib/redis/event_handler.js:86:22)
    at Socket.emit (events.js:107:17)
    at readableAddChunk (_stream_readable.js:163:16)
    at Socket.Readable.push (_stream_readable.js:126:10)
    at TCP.onread (net.js:538:20)

So I'm reporting it just like you asked. Looks to be a hiredis issue and not yours perhaps.
If you need more info let me know!

Thank you for reporting this. It's a bug that monitors don't work after reconnection and will be fixed in the next release. However I just did some tests but haven't found any way to reproduce the Command queue state error. Could you please show me the code causing the error? Here's mine:
var redis = new Redis(6999);

var listener = function (time, args) {
  console.log(time, args);
};

redis.monitor(function (err, monitor) {
  monitor.on('monitor', listener);
  redis.on('ready', function () {
    monitor.removeListener('monitor', listener);
    monitor.on('monitor', listener);
  });
});

Thanks for the reply. I'll add code as soon as I can but I'll be away from this server for about a week on a work trip. I'll update you when I get back to it.
Thanks!

Hey thanks for fixing this! I'll be sure to update.
For your curiosity this was the code that was giving me the Command queue error:
          //var monitored = false;

            _.client.on('error', function(err) {
                _.errorHandler(err);
            });

            _.client.on('reconnecting', function(delay){
                logger.debug('Retrying connection in: %s ms', delay);
            });

            // setInterval(function(){
            //     if (_.client.status !== 'ready' && monitored) {
            //         _.client.monitor(function(err, monitor) {
            //             monitor.off('monitor');
            //             monitored = false;
            //         });
            //     } else if (_.client.status === 'ready' && !monitored) {
            //         _.client.monitor(function (err, monitor) {
            //             monitor.on('monitor', function (time, args) {
            //                 if (args.indexOf('info') === -1) {
            //                     logger.log('Redis activity: Time: %s Args: %s', time, args[0]);
            //                 }
            //             });
            //         });

            //         monitored = true;
            //     }
            // },3000);

This was basically my fix for checking the ready state and if it was monitored. I tried both removeAllListeners and .off()
Thanks again for the quick fix!

Just confirmed monitors are working as expected. Thanks again.


transactions are stuck in phoenix wallet. See photo

It has been like that for 16 hours, it won’t clear

Contact support by email<EMAIL_ADDRESS>if you have issues with your wallet.


Please do not have plugin run if it project type is "pom"

If you do a
if (project.getType().equals("pom")) return;
on the execute, this means we can force the plugin to run on child projects. Otherwise we can only put it in pluginManagement and then its a "suggestion".

This version is no longer maintained. Refer to more recent forks at https://github.com/Jasig/sass-maven-plugin/network for more up to date versions.


Add prefer colour variable rule

Similar to layer-styles-prefer-shared a new rule should suggest to use colour variables.
It should expose one option maxIdentical to allow people to define how often a colour value can be set within a document without nudging to use colour variables.

@smithzoo We'd like your help QA this if possible 🙂
Ping me when you're ready.
QA Steps

Check out the next release https://github.com/sketch-hq/sketch-assistants/pull/154
From the root run yarn build
Change to the Reuse Suggestions Assistant package cd assistants/reuse-suggestions
Build its tarball yarn package-tarball
Add the tarball to a Sketch 69+ document

The Reuse Suggestion Assistant should complain about more than 2 usages of a hard coded color, suggesting to use a color variable instead. It checks colors in the following places:

Artboard, Slice and Symbol Master backgrounds
Borders, Fills, Shadows and Inner Shadows of layer styles
Colors applied to text strings

@jedrichards still checking a few things but these jumped out at me:

I don't think disabled background colors for Artboards should be included. As it stands, creating 3 artboards w/o implicitly setting a background color (default), the error will be triggered. We do not include disabled fills/strokes.
Tooltip for colors is incorrectly showing 8 characters when the HEX is six. Looks like we're adding FF to the end.

@smithzoo Thanks Evan, all good/valid remarks. I'll sort these tomorrow morning 👍

@smithzoo This is ready for another look 🙇♂

@jedrichards excellent, works exactly as expected!

Sounds like this one can be closed already, @christianklotz?


InfluxDB Cluster PVC[meta and data], Can be created in AWS EFS / NFS storage framework !!

InfluxDB Cluster PVC, Can be created in AWS EFS / NFS storage framework !!
I can see in AWS GP2 storage class is recommended, but for the High Availability of the storage , just checking the alternative storage like NFS OR AWS EFS
Would the current cluster helm charts/manifest support the NFS/ EFS ??  or extra changes to be made in manifest? to get worked
influx cluster helm charts - https://github.com/influxtsdb/helm-charts/tree/master/charts/influxdb-cluster
Already NFS discussions -  https://github.com/influxdata/influxdb/issues/9047

@MohamedShaj InfluxDB Cluster is an alternative to InfluxDB Enterprise and supports high availability (For high availability, installations must have at least two data nodes. The number of data nodes in your cluster must be the same as your highest replication factor. Any replication factor greater than two gives you additional fault tolerance and query capacity within the cluster.).
So NFS/EFS is not required, because the storage of each data node is completely independent and does not require network sharing. For details, please refer to the official documentation.
For the influx cluster helm chart, you just modify the configuration items like storageClass and size in values.yaml. So you need to request your storage provider.
  persistence:
    enabled: true
    ## A manually managed Persistent Volume and Claim
    ## Requires persistence.enabled: true
    ## If defined, PVC must be created manually before volume will be bound
    # existingClaim:
    ## influxdb data Persistent Volume Storage Class
    ## If defined, storageClassName: <storageClass>
    ## If set to "-", storageClassName: "", which disables dynamic provisioning
    ## If undefined (the default) or set to null, no storageClassName spec is
    ##   set, choosing the default provisioner.  (gp2 on AWS, standard on
    ##   GKE, AWS & OpenStack)
    ##
    storageClass: "alicloud-disk-available"
    annotations: {}
    accessMode: ReadWriteOnce
    size: 25Gi

Okay,
Got it.
But for some requirement, we are making n/w share with meta and data and using AWS EFS means,
   persistence:       enabled: true       ## A manually managed Persistent Volume and Claim       ## Requires persistence.enabled: true       ## If defined, PVC must be created manually before volume will be bound       # existingClaim:       ## influxdb data Persistent Volume Storage Class       ## If defined, storageClassName: <storageClass>       ## If set to "-", storageClassName: "", which disables dynamic provisioning       ## If undefined (the default) or set to null, no storageClassName spec is       ##   set, choosing the default provisioner.  (gp2 on AWS, standard on       ##   GKE, AWS & OpenStack)       ##       storageClass: "efs-sc"       accessMode: ReadWriteMany       size: 10Gi
  EFS-SC is the efs storage class.
  the above config should work right  ?

First, you need to check whether efs-sc exists by executing kubectl get sc, and then check whether the size meets the requirements. If the size is set too small, it may not meet the storage provider's requirements. And finally, test whether the cluster can work normally in k8s.


Please create a HA Kubernetes Helm Chart

ideally this would use Statefulset and/or the operator pattern.

Linux would be great for first draft followed by windows

It looks like this Helm Chart already exists?
https://github.com/kubernetes/charts/tree/master/stable/mssql-linux

We'll not exactly
As part of this chart you can enable your SQL Server container for Availability Groups. As an administrator, you will need to configure additional settings once this options is enabled. For more information on Availability Group(s) click here for more information.
Looks like some manual work is required.

@amvin87 has just posted following helm chart you may find interesting. This is an early version and suggestions are always welcome.
https://github.com/microsoft/mssql-docker/tree/master/linux/sample-helm-chart

@amvin87 has just posted following helm chart you may find interesting. This is an early version and suggestions are always welcome.
https://github.com/microsoft/mssql-docker/tree/master/linux/sample-helm-chart

FYI. It looks to be that SQL Server team have decided to create separate azdata tool for deploying SQL servers to Kubernetes. IMO most interesting documents about that are:

https://docs.microsoft.com/en-us/sql/big-data-cluster/deployment-guidance
https://docs.microsoft.com/en-us/sql/big-data-cluster/release-notes-big-data-cluster?view=sql-server-ver15#tested-configurations


Use loose class transformation in babel to support IE10

Fixes https://github.com/clappr/clappr/issues/859

Thanks again man :beers:

:clap:


Dornamedical - The company can be found on production when the name of the company is typed in the searching bar

Description : The company Dornamedical can be found on https://peviitor.ro/ after the name of the company was typed in the searching bar.
Expected result : The website https://peviitor.ro/ is up and running

Step 1 : Open the homepage of the URL (https://peviitor.ro/)
Expected result : In the middle of the homepage is a searching bar

Step 2 : Verify if the searching bar is functional by clicking inside it.
Expected result : The text can be typed inside the searching bar

Step 4 : After typing the company's name press ENTER or click on the button CAUTA next to the searching bar
Expected result : After entering the company is found and displayed alongside its jobs.

Tests passed


_getdrive returns 0 if current directory is UNC path

If current directory is a UNC path, _getdrive() returns 0.
But the documentation never mentions this. For completeness, the documentation should mention this fact.
I have confirmed this for myself using the following test program:
#include <direct.h>
#include <stdio.h>

int main(int argc,char**argv) {
printf("DRIVE=%d\n",_getdrive());
printf("press ENTER to continue...");
getchar();
return 0;
}

If you run the above from a UNC path (easy way is to put the .EXE on a network share, use Windows Explorer to navigate to the share's UNC path and run the .EXE from there), then it will be started with the UNC path as the current working directory, and in that scenario it prints DRIVE=0. (The "press ENTER to continue..." and getchar() is simply to stop the console window from closing before you can see the output.) By contrast, if you run it from e.g. drive C, it will print DRIVE=3.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1f827185-f3ff-9a42-8b8b-262eb750f10d
Version Independent ID: a36ff9eb-d7bc-3754-d79c-eff34aedfbbb
Content: _getdrive
Content Source: docs/c-runtime-library/reference/getdrive.md
Product: visual-cpp
Technology: cpp-ucrt
GitHub Login: @corob-msft
Microsoft Alias: corob

@skissane
The function isn't really that smart. You'll get a 0 returned for any path that doesn't start with a letter followed by a colon, or for a zero-length path. That can happen in several situations, including when the current directory is a UNC path. You can also get a 0 returned in the unlikely event the path is longer than MAX_PATH and a temporary buffer allocation fails, in which case errno is set to ENOMEM.
I've updated the Return value section to clarify this, and it should be visible tomorrow. Thanks for bringing it up.


update session.rst

Adding backslash on line 34

Good call, and I will merge this. We are looking for secure commits, for future reference ... https://bcit-ci.github.io/CodeIgniter4/contributing/signing.html


chore: update utils image in push sbom task

I didn't realize there were two image lines in !140

@johnbieren your link in the description actually points to PR 141, which is this very PR ;)

@johnbieren your link in the description actually points to PR 141, which is this very PR ;)

fixed


Add Traffic Monitor 2.0 Bandwidth Capacity

Determine how to get the bandwidth capacity from ATS, add it to data stats, and display in the GUI.
Currently the GUI displays ∞.

This comes from astats, inf.speed.


Documentation

Task List:

[x]  Document Identifier Requests
[x]  Document Agent Requests
[x] Document Registry Requests
[x] Document Schema Requests
[x] Document Challenge Requests
[x] Document Contact Requests
[x] Document Credential Requests

related to https://github.com/WebOfTrust/keria/issues/24

How is this going?
I was going to introduce JSDoc today, start that process, thoughts @2byrds @rodolfomiranda @AlexAndrei98 @pfeairheller

merged with PR #85


cleanup: remove older versions when reasonable

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

This change updates the eligibility criteria for removing older kegs to be a bit more inclusive, thus better aligning the command with its documented behavior from brew help cleanup:

For all installed or specific formulae, remove any older versions from the cellar. [...]

Today, the cleanup command is a bit overly conservative in
that it doesn't even try to remove older kegs when the most
recent version isn't installed. This means "slow adopters" are
often left with many older kegs that have no use, even after
using the command. (Update: e.g. #412.)

Unchanged: if the most recent available version is installed, all
older, non-linked versions are eligible for cleanup.
New: if any version is linked, all versions older than it are eligible
for cleanup.
New: if no installed version is linked, all but the latest installed
version are eligible for cleanup.

Please note that I didn't modify or add to the existing cleanup test, but it's not immediately clear to me the proper way to do this, or if it's even necessary in this case.
Also, there are one or two points in the code where I made choices that may or may not be the accepted way to do things. I'll try to comment on these lines, but I'm sure someone will point out anything that should be changed. Thanks for considering this!

This means "slow adopters" are often left with many older kegs that have no use, even after using the command.

But what about people who do have a use for older kegs? One of the nice things about HB is the ability to keep multiple versions of something on hand and easily switch between them if needed.    That makes cleanup too aggressive, I think.
I agree that the current cleanup is not ideal and isn't aggressive enough for certain use cases.  There are just too many different kinds of tidying-up tasks, and too many different-but-reasonable expectations about what will/should happen, to be jammed into one command.

@chdiza Thanks for the feedback! About this:

But what about people who do have a use for older kegs? One of the nice things about HB is the ability to keep multiple versions of something on hand and easily switch between them if needed.  [...]

Actually, no. 😄 I'm not sure I was clear enough, but this PR only aligns behavior of the command with its description from brew help cleanup:

For all installed or specific formulae, remove any older versions from the cellar. [...]

People who run brew cleanup want to remove older versions of all (or speficic) formulae. This PR makes that happen. It still won't remove old kegs that are linked or newer than the linked version. If none of the installed kegs for a formula are linked, it will still leave the one with the latest version. The use case you mention is not applicable to people who use this command.
I hope this clarifies things for you. :) This PR just makes the command more generally-useful. 🌈

But what about people who do have a use for older kegs? One of the nice things about HB is the ability to keep multiple versions of something on hand and easily switch between them if needed.  That makes cleanup too aggressive, I think.

I don't understand this question. If a user has a use for the older versions and doesn't want them deleted, why are they running brew cleanup on those formulae? Isn't removing them the purpose of the command? What am I missing?

If a user has a use for the older versions and doesn't want them deleted, why are they running brew cleanup on those formulae?

The user would run the two-word command brew cleanup, not brew cleanup the-package-foo, with the purpose of getting rid of all "junk" across the HB installation, not just the junk associated with the-package-foo.  I don't think I've ever once run brew cleanup some-formula.
It doesn't matter though, because this PR simply makes cleanup do what the docs advertised.  I had got used to, and comfortable with, its buggy form without noticing that it differs from the docs.  I'll probably just make my own external command to do what I want.

I'll probably just make my own external command to do what I want.

@chdiza If I understand you correctly, what you want to do can be simply done with brew pin. ;)

pin doesn't tidy up any junk.  It prevents the installation of the lastest version of something.

@chdiza Of course. To be clear, I mean brew pin some-formula-you-don't-want-cleaned-up followed by brew cleanup. This will address your specific need of not wanting old stuff cleaned up when you run brew cleanup. I think we're getting off-topic though. :grin:
Any Project Members want to look at this PR?

@usmonster It also prevents me from installing the latest version of a formula, or even seeing that the one I have is outdated.

I agree with the general goal of this PR, but I think we need to clean up the logic a bit. Currently it's just dealing with too many cases in too many separate branches of the if statement. Here's a suggestion for how to basically re-implement the entire eligible_kegs_for_cleanup method:

If none or only one version of a formula is installed, immediately return an empty array and don't complain at all.
If at least two versions of a formula are installed:
Pick the currently linked version as a partition point. If none is linked, use the latest installed version.
Iterate over all installed versions and do one of:
1. If it's older than the partition point, it is eligible and should be cleaned up.
2. If it's identical to the partition point, it should stay.
3. If it's newer than the partition point, it isn't eligible, but it should produce a warning that this newer version was skipped/preserved.

Does this logic make sense? Have I missed an important use case? I think this approach massively simplifies the logic and yields the desired result. It always cleans up versions older than the one currently in use and leaves all newer versions alone (that might have been installed in the mean time). Those newer versions might exist because a user upgraded and then went back to an older version via brew switch because the newer version turned out to be problematic in some way.
Thanks for bringing this up and coming up with a PR! Sorry for the somewhat late feedback; these are busy days for me and apparently also for other maintainers …

@UniqMartin, thanks for thre feedback! I'm applying the small changes in the line comments, and I mostly agree with the restructuring of the logic you propose. From what I understand, the only behavioral differences between my PR and your proposal are that, in yours:

There's no more warning when skipping the only installed (non-pinned) version
A warning is now printed when skipping any versions (strictly) newer than the linked version
There's no warning when skipping a linked version(? ..please verify)

Is this correct and desired? If so, I'll implement this. Thanks again for the response! (And don't worry about delays--everybody's busy 😉.)

There's no more warning when skipping the only installed (non-pinned) version

Correct. But I can see an argument for producing a warning in case this non-pinned installed version is older than the most recent available version and it would also be less of a deviation from the current behavior. (Thus I adjusted the proposal in my previous comment accordingly.)

A warning is now printed when skipping any versions (strictly) newer than the linked version

Correct and I think this is desirable. We can always tweak this behavior later if too many users are seeing this warning and are annoyed by the extra output.

There's no warning when skipping a linked version(? ..please verify)

Correct. I think the linked version always aligns with the user's intention (either by consciously not brew upgradeing or by consciously brew switching to a specific version), thus there's no point in warning about this. And obviously that version is never eligible because it would need to be unlinked first.

Is this correct and desired? If so, I'll implement this.

I think this is all desired and correct, modulo the minor tweak mentioned above. I would appreciate if you could implement it like this and ideally add some tests (unit tests for eligible_kegs_for_cleanup) to make sure we don't break this behavior in the future (feel free to ask if you need help with this). Those tests would also serve as a way of documenting the expected behavior.

Thanks @UniqMartin, this sounds OK to me, though just wanted one more clarification:

i. (Added:) Produce a warning if this version is older than the latest available version and the formula isn't pinned.

This would only be if the only installed version isn't linked, correct? So the first condition would be something like:
    if installed_prefixes.length < 2
      if any_version_installed? && !linked_keg.exist? && !installed? && !pinned?
        opoo "Skipping (old) #{installed_kegs.last} due to it being the only version installed"
      end
      return []
    elsif ...

?

This would only be if the only installed version isn't linked, correct? So the first condition would be something like:

Almost. I think you can drop the !linked_keg.exist? check because to me it feels like it doesn't matter whether the outdated installed version is linked or not, as long as it is pinned. But it took me a few moments to come up with this argument, so maybe that's not as intuitive/useful. What do you think?
Another thing you could do (because I just noticed in your snippet), is to structure the code as follows once you update your PR. This limits the amount of indentation and makes it a bit easier to read:
if installed_prefixes.length < 2
  # Handle the simple case (zero or one installed version of a formula).
  return []
end

# Handle the remaining cases (what would have previously been the `else` or `elsif` branch).

Thanks again for the feedback. :)

I think you can drop the !linked_keg.exist? check because to me it feels like it doesn't matter whether the outdated installed version is linked or not, as long as it is pinned.

The "not linked" check is only there because we don't want to complain when we're skipping a linked keg. What I understood from that first added line is that, if there are fewer than 2 kegs installed, we only want to warn when skipping 1) the only keg (any_version_installed?), 2) that is not the newest version (!installed?), 3) is not pinned (!pinned?), and 4) is not linked (!linked_keg.exist?)... Does that make sense, or should I still drop that check?
In any case, I'd also like to write the tests first, but as I mentioned in the PR, it's not immediately clear how to write the tests I need without making some nontrivial additions to the existing testing infrastructure (though I only did a quick first glance+attempt and may be totally wrong..).
Thanks again for the advice and feedback!

The "not linked" check is only there because we don't want to complain when we're skipping a linked keg.

Why do we want to skip the warning in this case? To me it feels like we should always warn if the user could have updated to a newer version unless they deliberately decided to stick with an older version by pinning the formula. (But feel free to go ahead and prepare the proposed changes. That's a detail we can easily tweak later or even after this PR is merged.)

In any case, I'd also like to write the tests first, but as I mentioned in the PR, it's not immediately clear how to write the tests I need without making some nontrivial additions to the existing testing infrastructure (though I only did a quick first glance+attempt and may be totally wrong..).

Thanks! I like your approach. 😃 I don't think this requires massive changes to the testing infrastructure. I believe a few tests similar to test_migration_needed will do the job. The main task would be to set up some minimal kegs according to the various situations we'd like to test and then to check that the output of eligible_kegs_for_cleanup matches our expectations.

Would it be possible to add a switch that hides the warnings that the latest version is not installed?

Would it be possible to add a switch that hides the warnings that the latest version is not installed?

@chuchana No, I don't think we'd want that. Much in Homebrew assumes the latest version is the one installed.

@usmonster What's the status of this PR? It would be nice to incorporate the changes we discussed and to rebase it on an up-to-date master to resolve the merge conflicts. Thanks!

@UniqMartin I went on vacation shortly after my last comment (still not reliably online for a few more days), but I just rebased to resolve the conflicts. Haven't yet written the tests or made changes to logic, but hoping to get that done on an upcoming flight. ;)

Closing this for now but please feel free to create a new PR when comments are addressed and it's rebased. Thanks!

Any news on this? @usmonster

Hey @black-snow, I've been consumed by work projects recently, but I would still like to fix up my branch and make a new PR at some point. Not sure an ETA now would be accurate, but feel free to do it before me!


Found interface com.google.android.gms.location.FusedLocationProviderClient, but class was expected (declaration of 'com.google.android.gms.location.FusedLocationProviderClient'

Your Environment

Plugin version: 6.1.0
Platform: Android
Device OS version: Android 34
Device manufacturer / model: Emulator
XCode version: NA
Capacitor info (npx cap doctor)
Plugin config provided to #ready:

FATAL EXCEPTION: pool-16-thread-2 (Ask Gemini)
Process: com., PID: 3836
java.lang.IncompatibleClassChangeError: Found interface com.google.android.gms.location.FusedLocationProviderClient, but class was expected (declaration of 'com.google.android.gms.location.FusedLocationProviderClient' appears in /data/app/~~s3Z8FSmIWKLEONz9sX6GGg==/com..in==/base.apk) at com.transistorsoft.xms.g.location.FusedLocationProviderClient.getLastLocation(Unknown Source:50) at com.transistorsoft.locationmanager.location.TSLocationManager.getLastLocation(Unknown Source:20) at com.transistorsoft.locationmanager.geofence.TSGeofenceManager$d.a(Unknown Source:38) at com.transistorsoft.locationmanager.geofence.TSGeofenceManager$d.$r8$lambda(Unknown Source:0) at com.transistorsoft.locationmanager.geofence.TSGeofenceManager$d$$ExternalSyntheticLambda0.run(Unknown Source:2) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644) at java.lang.Thread.run(Thread.java:1012)

## Expected Behavior
Application should not crash while running transistorsoft plugin

## Actual Behavior
Getting error:
 Process: com., PID: 3836
 java.lang.IncompatibleClassChangeError: Found interface com.google.android.gms.location.FusedLocationProviderClient, but class was expected (declaration of 'com.google.android.gms.location.FusedLocationProviderClient' appears in /data/app/~~s3Z8FSmIWKLEONz9sX6GGg==/com..in==/base.apk)

## Steps to Reproduce
1. While using transistorsoft in android

## Context
Getting below error
FATAL EXCEPTION: pool-16-thread-2 (Ask Gemini)
 Process: com., PID: 3836
## Debug logs
<details>
	<summary>Logs</summary>

```<!-- Syntax highlighting:  DO NOT REMOVE -->
FATAL EXCEPTION: pool-16-thread-2 (Ask Gemini)
 Process: com., PID: 3836
 java.lang.IncompatibleClassChangeError: Found interface com.google.android.gms.location.FusedLocationProviderClient, but class was expected (declaration of 'com.google.android.gms.location.FusedLocationProviderClient' appears in /data/app/~==/com==/base.apk)

Duplicate #173.  This has been posted many times before.  Please search before posting.


[$250] Web - Notification - User receives push notification when public room notification are daily

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.19-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4845236&group_by=cases:section_id&group_order=asc&group_id=295000
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

User A creates Public room
User A invite User B to the public room
User A sends message to public room

Expected Result:
User B should not receive notification since public room notifications are set to Daily by default
Actual Result:
User receives push notification for new message when public room notification are set to daily by default
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/c2a84121-a5ee-4f37-980c-cd79e2848f91

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01960943628ae9eb04
Upwork Job ID:<PHONE_NUMBER>055474776
Last Price Increase: 2024-08-15

Issue OwnerCurrent Issue Owner: @ikevin127

We think that this bug might be related to #vip-vsb

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Context on the status of the vip-vsb project.
https://expensify.slack.com/archives/C066HJM2CAZ/p1721760866963099?thread_ts=1721729395.916419&cid=C066HJM2CAZ

Can't reproduce on v9.0.21-0

Not able to reproduce with the public room scenario on latest staging v9.0.21-1.

However, I was able to reproduce the same issue for the WS chat where if notification notice is changed to Daily, I still get notifications as if it's set to Immediately.

[!tip]
Steps

User A creates a new workspace.
User A invites User B to their (User A) WS chat.
User A set their WS chat Settings > Notify me about new messages to Daily.
User A sends message to their WS chat.

https://github.com/user-attachments/assets/3d1c4e22-a68e-4ca8-9e34-7def38d22d75
Note: The notification goes away as soon as I start the MacOS screen recorder and the notifications received while the screen recording is ongoing don't show up (this is MacOS / screen recorder related) -> issue should be tested / reproduced without screen recording on.

@ikevin127 Could you please record the entire process? I just tried to replicate it as you described, and it seems you’re receiving the notification because User B still has their "Notify me about new messages" setting on "Immediately."

@Amoralchik You're correct, my bad. The issue is not reproducible, I updated my previous comment to remove the other found issue.

@isabelastisser Issue not reproducible!

@ikevin127, thanks for the update! Closing.


[ic-classification-banner] Cypress test suite title

Summary of the bug
The first describe block for IcClassificationBanner cypress tests reads IcClassificationButton, this should be IcClassificationBanner.

Can I fix this, or is this for first time contributors?

Sent a PR. Close it if that's the case.


SMD Calculator

Note to Self: Need to add new test cases and get coverage up on new and existing utils before merging

Before merging a way to handle bad inputs with floating point errors should be addressed, not sure on an ideal solution yet


Release 1.8.5 missing in History.rdoc

Hey @botandrose,
I see that History.rdoc has details for 1.8.4 but not for 1.8.5
Could you look into this?
Thanks!

Ah, good catch. Thank you! Fixed!

@botandrose Great, thanks! 💯


complete room_invitation

complete room_invitation module

Do we have any reason to use topic () instead of topic() ? ( one space between the method name and the parenthesis)
If not, could you please remove the space when calling a method, in our debug log messages?
- topic ()
+ topic()

@huan This is my wrong. I have change it.
There are some in need of modification in other modules.  eg:

log = logging.getLogger("ModuelName")
log information standardized output. (space, case-uncased characters ...)

When you merge prs, I will commit a new pr to fix them.

Great to see that we can follow the same message format with the TS Wechaty in our PY Wechaty!
Cloud you please add this format to our Coding Style Wiki pages so that the future contributors will be able to follow the same style easily?
There's one more thing before this PR can be merged: the wechaty_puppet/__init__.py has conflicts with the master branch.
Please resolve it before we can merge it, thank you very much.


Saving PDF to another directory

This is a very easy to use and robust library.  Thanks for making it, as it satisfied my requirements almost exactly.
Is it possible to save a PDF to somewhere other than the default download folder, for example:
html2pdf().from(invoice).set(opt).save("D:\Reports\ReportFolder");
If not, is this feature under consideration? I underxtand that there might be security issues, but it would be nice to have.

browser permit this, no?

True. I had decided to use the default Downloads folder, but I'd like to send the generated PDF as an e-mail attachment.
Is there a way to render it on the server side so as to avoid uploading it just so it can be attached?

@eKoopmans will there be a future updates for regarding the saving to another directory?


Make images responsive (#362)

This PR makes images responsive in three contexts:

featured_image as rendered in summary pages that include images (summary-with-image).
featured_image as used in a background in the header.
Images added via the figure shortcode.

It's in response to issue #362, which is focused on the header background image. However, making background images in the header responsive required changes to the GetFeaturedImage partial, also used in summary-with-image; and the changes needed for summary-with-image were readily applicable to the figure shortcode.
Two different approaches are taken to responsive images:

A set of image URIs via a srcset attribute on <img /> elements. This is the preferred approach and used where feasible, with summary images and figure.
Media queries that use breakpoints. This fallback approach is used in the header, where we don't have an <img .> element to work with.

Activating responsive images
After applying this change, the minimum change needed to get responsive images working is to specify a set of breakpoints in the site config file--see details below. Note that, because per Hugo image processing documentation "To process an image, you must access the image as either a page resource or a global resource," only images that are resources will be responsive.
New GetImageSrcset partial
This func-type partial is used internally by both the figure shortcode and the summary-with-image partial. Sample usage:
{{ $srcset := partial "func/GetImageSrcset" (dict "original" $featured_image "target_width" $target_width) }}

featured_image here is the featured image and target_width the expected maximum width available to present the image, expressed as a ratio of the total width at a given breakpoint.
New override to default Hugo figure shortcode
A new figure shortcode adds a breakpoint-based srcset attribute to images embedded in posts.
Optional breakpoints
This optional parameter can be provided in the site's config file to supply a set of breakpoints. Only if it is present will images be responsive.
# Use defaults from tailwindcss, https://tailwindcss.com/docs/responsive-design.
breakpoints = [640,768,1024,1280,1536]

New featured_image_data parameter in post front matter
This optional parameter can be used to specify an anchor, used as a setting when cropping the featured image for use in the header. See valid values at https://gohugo.io/content-management/image-processing/#anchor.
Example:
featured_image_data:
  anchor: "Center"

Explicit alt attribute
As well as anchor, the featured_image_data parameter can be used to provide an alt value to be used as alt text for the image.
Of course, alt text is tangential to the focus of this PR, but it was not possible to do the work in this issue without touching existing code that generates the alt text.
featured_image_data:
  anchor: "Center"
  alt: "Illustration from Victor Hugo et son temps (1881). Drawing of the Hunchback of Notre Dame, showing the recently restored galerie des chimères."

The PR also provides a missing internationalized string for the fallback if an alt value is not provided.

Hi @nedjo and thank you for this.
I think the logic for images using srcset is sound and limiting it to the direct input of the user (by setting breakpoint) prevents breaking changes and unexpected behaviour.
I don't think we're ready to use the solution applied for background images though. I think this should be wrapped in its own function and asset template so does not crowds the templates. In any case I'd like to give it more time.
Now this breaks with the example site, could you address it before we move into a more in depth review? Here's the error:
Error: Error building site: failed to render pages: render of "page" failed: execute of template failed: template: page/single.html:1:24: executing "header" at <partial "page-header.html" .>: error calling partial: execute of template failed: template: partials/page-header.html:4:6: executing "partials/page-header.html" at <partial "header-image-style.html" .>: error calling partial: "/opt/build/repo/layouts/partials/header-image-style.html:5:51": execute of template failed: template: partials/header-image-style.html:5:51: executing "partials/header-image-style.html" at <$featured_image.RelPermalink>: can't evaluate field RelPermalink in type string

Thanks a ton!

@regisphilibert
Thx for the review!

I don't think we're ready to use the solution applied for background images though. I think this should be wrapped in its own function and asset file (to use with . ExecuteAsTemplate) so it does not crowd the templates. In any case I'd like to give it more time.

k, I'll try to see if I understand what's involved. Any hints appreciated.

Now this breaks with the example site

Yeah, on the site I developed this on I'm only using page resource images. I'll need to rework so it also supports static image files, and ensure the example site includes both image types.

I'll need to rework so it also supports static image files

By which I guess I mean, since we can't do processing and hence can't use a srcset without a resource, at least it doesn't break with static image files.

Thanks! This is a lot fo changes and a big review for me, so I have to push it to the next release! hope to get some time to take a good look at it soon! Thanks

Thanks! This is a lot fo changes and a big review for me, so I have to push it to the next release! hope to get some time to take a good look at it soon! Thanks

Thx for the update, sounds good.
Meantime I've resolved a few merge conflicts from the changes in https://github.com/theNewDynamic/gohugo-theme-ananke/commit/19242fd2f89b9ac4d469ebbe265808fae17a2388.

There's a new round of conflicts from the changes in https://github.com/theNewDynamic/gohugo-theme-ananke/commit/470ea40982f5036554819253c3ac6ed4a34193f4. I'll have a go at resolving them when I find time.


Update ride flags 7, 16, 18

PR for https://github.com/OpenRCT2/OpenRCT2/pull/7722
Todo: WW, TT

@Gymnasiast was already on it: https://github.com/OpenRCT2/objects/pull/20

Indeed, and mine passes CI. For those reasons I closed this one.
Any discussion can take please on #20.


Repo license

Can you please add a license to this repo so I can use it?
Thanks
Example: https://github.com/railstutorial/sample_app_rails_4/blob/master/LICENSE
Background Reference: http://opensource.org/licenses

Done.

thanks


Test at point doesn't seem to work if you are on a comment node?

When i do test at point on a comment within a test it just runs the entire file.

Just realized this was closed by #53


enhancement - optimize_for_inference

seems like an additional step is needed to get checkpoint / pb files in order for mobile.
I'm imaging an additional parameter to pass into benderthon to handle this.
https://github.com/hollance/TensorFlow-iOS-Example
The model is already included in the app as inference.pb. If you train the model with different settings, you need to run the freeze_graph and optimize_for_inference tools to create a new inference.pb.
perhaps you can cherry pick this code?
https://gist.github.com/omimo/5d393ed5b64d2ca0c591e4da04af6009#file-prep_model-py-L8
also it seems this op and node is critical to getting inference working.
restore_op_name = "save/restore_all"
filename_tensor_name = "save/Const:0"
https://github.com/icodingc/backup/blob/f867f8bdd9907e411653fa6f97d57f6982984c41/neuralstyle/freeze_graph_toy/gen_freeze_graph.py

it seems the mag file / Tensorflow_MetaGraphDef includes a helpful saverDef
from this / can ascertain
saverDef: gRPCTensorFlow.Tensorflow_SaverDef:
filename_tensor_name: "save_1/Const:0"
save_tensor_name: "save_1/control_dependency:0"
restore_op_name: "save_1/restore_all"
max_to_keep: 5
keep_checkpoint_every_n_hours: 10000
version: V1
https://gist.github.com/johndpope/99038722132de7f1e80ad96bd7e7e21f

fyi - code to rip apart bundle file. https://raw.githubusercontent.com/tensorflow/magenta/d8efb2a1984caadddd5e9290853b196dd90eba4a/magenta/scripts/unpack_bundle.py

after extracting the chkpt via the above script ->
benderthon tf-freeze attention_rnn.chkpt test.db save_1/restore_all
this dumps out 72 ops in the final graph. will try running the optimize script.

Oh, didn't know about optimize_for_inference_lib. It'd be nice to add it.

Fyi - there's another handy bazel script to get the input output variables
https://github.com/tensorflow/magenta/issues/715

bin/tensorflow/tools/graph_transforms/summarize_graph

@bryant1410 - fyi - https://github.com/tf-coreml/tf-coreml


Why we compute advantage and return inside the self.loss function in the PPOTrainer? Seems like we do not need to do it everytime.

As mentioned in the self.loss function, we use state values from the original episode  to compute the advantage and the return.
So we can compute them once prior to the ppo optimization loop.

@shamanez this is a very good point. Reward and values don't change and so won't advantages change. I am doing a refactor at #546 and hopefully can do this later.


MDX 2 (attempt 2)

Related to: GH-4058.
Note this PR is giant. It changes the format for heading IDs. Please review by commit and skip most files in Use {/*id*/} for headings because MDX has expressions.
This PR gets stuff working-ish, but there’s still more to do.
Here are some notes:
A bunch of stuff on the site isn’t working.
My guess is that that has to do with mdxType and isMDXComponent no longer existing, and the rendered VDOM nodes being different, which are sniffed in several components here.

The top nav bar isn’t showing (This page was not added to one of the sidebar JSON files), I don’t know why. Probably similar to the VDOM sniffing in MarkdownPage
This currently completely breaks LayoutPosts ToC stuff.
It’s sniffing the generated VDOM nodes that will be rendered. That changed.
Can someone explain to me what the goal of the ToC is, and we can make a nice reusable version of it instead?
There are a bunch of react warnings that’ll have to be investigated
inlineCode was removed — need to figure out a way to enhance block code (pre > code) and differentiate with “inline” code (code not in pre)
To do: Have to look at MDX/APIAnatomy, MDX/Challanges/Challenges, MDX/CodeDiagram, MDX/Link, MDX/PackageImport, MDX/Sandpack, pages/_app
MDX provider is not used for a context based API — should be possible to pass components to MDXContent instead
Some stuff is now in xdm, which will get released in the next MDX RC, swap that out last

My goal is to get some early feedback in. Will clean up later.

/cc @gaearon

Wonder if it is possible to keep the current headings IDs format? Will it work in MDX v2 or not?

Wonder if it is possible to keep the current headings IDs format? Will it work in MDX v2 or not?

Not really. Braces are used as expression in JSX and thus they were added now in MDX. There could be ways around it. But I can see more expressions being added, to the point where it’d become more and more complex to differentiate between the two

My guess is that that has to do with mdxType and isMDXComponent no longer existing, and the rendered VDOM nodes being different, which are sniffed in several components here.

What's the alternative to this? We do quite a bit of post-processing in a few places. Though I'm happy to simplify if we know how.

What's the alternative to this? We do quite a bit of post-processing in a few places. Though I'm happy to simplify if we know how.

As I understand it, the code is currently “sniffing” React’s VDOM. It does some cool stuff! But I personally would say it’s error prone (i.e., the VDOM might change), it also “feels” sort of “impure” to me.
On the other hand, it’s very similar to ASTs, and ASTs are nice, so if it does what’s needed, :+1:.
That also leads to where I’d solve it: the AST. First two examples: I’ve previously shared remcohaszing/remark-mdx-frontmatter, which takes YAML frontmatter and turns it into an export const frontmatter = {...}. A smaller, simpler, similar example is: remcohaszing/rehype-mdx-title. So what I’m thinking is to make a plugin, which I’m sure other people would be interested in as well, that adds an export:
export const tableOfContents = {title: 'Hello, World!', url: '#hello-world', rank: 1, children: [/*...*/]}

I believe the “sniffing” is mostly done for the ToC, but I haven’t investigated everything.

There’s quite a few places where we do that but I agree we should get rid of that.

Externalized the heading braces stuff in a different PR — please review that separately!

Where are we with the state of this effort? What's needed to finish it?

Hey! Thanks for the ping and sorry I didn’t communicate that yet.
It’s a bit more involved than I initially expected due to the sniffing/rendered node inspection.
I do have the knowledge to help with MDX 2 but I don’t have knowledge of this repo to make all the decisions myself.
This PR is kinda a riff on your earlier PR, and I’m :+1: for going about it that way, someone else taking a stab at this idea here as it’s not really a priority for me.

I did land the table of contents, but haven’t yet looked at anatomy, challenges, code diagrams, package imports, sandpack, or links.
Then, I think the code components needs to be migrated (inlineCode isn’t a thing anymore, it’s just HTML tag names so pre and code or just code).
Last, the nav stuff isn’t showing, which might be resolved by the other work?

https://github.com/reactjs/reactjs.org/pull/5107


Effect of corr_block_size on read correction

Hello,
How does the corr_block_size parameter affect read correction? For example, if I have a 1 Gb genome and I set corr_block_size=1000000000, does that mean I'm only using 1X coverage for each batch of read correction?
If so, do you have recommendations on the minimum genome coverage for the corr_block_size parameter?
Thank you,
Dan

hi @dmacguigan
PECAT uses corr_block_size for splitting the dataset, so that PECAT can run  in parallel on the cluster. It theoretically does not affect the result of error correction.


why can't i correctlyopen coco jason file with cocoviewer correctly?

my bad,I want to change from coco datasets to labelme ,and category_id start with 0 ,but i set 1.It's already resolved. Thanks for your contribution！

Alright! Thanks!


Add RPCs to create payload for creating denomination, minting and spending.

This one don't need to be in sigma release so I will remote it from milestone.

Relook into this in future when we have more time to work on this.


[DOC] mention distroless containers can be patched

What kind of documentation improvement is needed?
Missing information or guidance
What is the change that is needed?
looks like we are not mentioning this in the website. we should add a bullet point for this
related #383
Are you willing to submit PRs to contribute to documentation?

[ ] Yes, I am willing to implement it.

+1

It works with distroless containers today by using a tooling container, it will not install any package managers.

Might also help to describe the steps needed for ^^


Fixing packages versions to last supported

CI runs were failing due to a possible external issue regarding gcloud packages obtained via apt-get.
To avoid this the versions of the last working artifacts were fixed

This error has been fixed on the backend side now. Thanks @SanabriaRusso for preparing these, but I think we can close them now.