Fix to 1.35.0 nightly

I fork this repo and cargo test. Then, I had few errors. So, I fixed those. Please check ☺

Coverage decreased (-0.2%) to 91.321% when pulling a44ad4c0ae5348e0b8ae2f26bcda0a3a2d122832 on hnkz:fix-to-1.35.0-nightly into 4ee952215406262b3296af5205eb3e851139ba77 on khvzak:master.

Coverage decreased (-0.2%) to 91.321% when pulling a44ad4c0ae5348e0b8ae2f26bcda0a3a2d122832 on hnkz:fix-to-1.35.0-nightly into 4ee952215406262b3296af5205eb3e851139ba77 on khvzak:master.


when included through twig routing throws error

I have a twig page including another controller through the {% render() %} function.
In the included controller I render a template that includes the pagination render function.
I get an error on sliding.html.twig that there's no route for "" (empty route)
To solve the problem I changed the template a bit
I changed this on lines 7,13,20,30 and 36
{{ path(route, query|merge({'page': next})) }}
to this: (of course the param next should be changed to first/previous/page/last)
{{ route ? path(route, query|merge({'page': next})) : "?page="~next }}
To get this to work I also needed to give the second parameter (page) to the paginate() function directly from _GET() -- since it's not gotten correctly from either $request->query or $request itself.
The solution I used may just be a quickfix. Probably there's also a better solution to this.

hi, $pagination->setRoute($routeToUse); should be a solution for this case. If you have a diferent controller rendering the pagination be sure to set correct route for the pagination view.


On modal submit interaction reply ephemeral

It's not possible to send an ephemeral on a modal reply when modalSubmit event is ran.
Code:
Client.on('modalSubmit', modal => {
   modal.reply({
      content: "Message sent, anonymously.",
      ephemeral: true,
   });
}

Is that a bug, or is it supposed to be like that?

Modal Submit Interactions don't support a directly ephemeral reply.

Take the example from the readme:
const { Formatters } = require('discord.js');

client.on('modalSubmit', async (modal) => {
  if(modal.customId === 'modal-customid'){
    const firstResponse = modal.getTextInputValue('textinput-customid')
    await modal.deferReply({ ephemeral: true })
    modal.followUp({ content: 'Congrats! Powered by discord-modals.' + Formatters.codeBlock('markdown', firstResponse), ephemeral: true })
  }
});

Okay thank, just wanted to be sure.


FBbt_00004660 claw synonym missing

FBbt_00004660 in V2.

This is a bigger issue.  We're missing all synonyms for which no reference is provided, as these appear under a different attribute in OLS.   The following query finds all neurons for which this is the case.
MATCH (c:Class:Neuron) where exists(c.synonym) and not exists(c.obo_synonym) return count (distinct c)
Following file needs to be patched to fix: https://github.com/VirtualFlyBrain/VFB_neo4j/blob/master/src/uk/ac/ebi/vfb/neo4j/flybase2neo/add_refs_for_anat.py

@Robbie1977 IIRC, we used to have a null pub node for cases where there is no reference on a field that usually has one.   This had a short_form following standard FlyBase convention for cases like this.  I don't see this anymore, but wonder whether we should revive it for cases like this, meaning synonyms will always be found on an edge pointing to some kind of pub node.
We should probably do the same for descriptions (I actually thought we were doing this already, but seems not.
Any opinion on this?
CC @matentzn - need a similar solution for v2 schema.

Can we just not add the reference edge and then add the reference as an optional match in the query? Otherwise a blank pub node should be fine I'll just need to handle it appropriately.

Not sure I follow. In the case of synonyms, it's much cleaner if all synonyms are on edges, as otherwise we need to tie up the contents of c.synonym (a plain list of synonym strings) with synonyms on edges pointing to pubs (which come from the c.obo_synonym field in OLS).

Sorry forgot the synonym is on the edge itself.


Fix license string in setup.py

When the license for cfncluster-node was changed to Apache, the
classifier string was updated but not to the exact format that
PyPi wants, so PyPi rejected new versions.  Clean up the string
so that we can release 1.3.4.
Signed-off-by: Brian Barrett<EMAIL_ADDRESS>

Here's the list of accepted classifiers: https://pypi.python.org/pypi?%3Aaction=list_classifiers

Ship it!


Small fixes / Additions

Added travis.yml to support automatic building of commits/pull request in GitHub
Fixed issue identified by GCC in Adafruit_GFX.
No functional changes.

Cool. Good idea. Thank you.


Wrong JWT token sub attribute after second authentication

Describe the bug
I have an environment composed of a SPA, a resource server and an authorization server using Spring's new library.
SPA authorizes using the Authorization Code + PKCE flow.
Lib versions:
spring-boot-starter-parent: 2.5.2
spring-security-oauth2-authorization-server: 0.1.0
I'm having a somewhat complex problem to explain, but come on.
During the first authorization of the SPA application, which in turn is redirected to the login screen of the authorization server, I get an access_token with the JWT's "sub" attribute with the desired value (any user identifier), as a response. for example "bob".
When the token expires, a new authorization request is started, which in turn ends up returning a new access_token with the wrong "sub" attribute. Its value turns out to be the customer id and not the user identifier.
I'm going to divide this troubleshooting into 2 steps: 1st and 2nd authentication.
1st authentication (not yet logged into the Authorization Server)
During the first authentication that occurs on the endpoint /oauth2/authorize, the Principal is validated, which was passed on by the login form and created an authentication of the UsernamePasswordAuthenticationToken type, which in turn implements the org.springframework.security.core.Authentication interface.
This object is saved within the user's session in the SPRING_SECURITY_CONTEXT attribute.
After that, the code is created and saved in authorizationService.save(). For the Authentication#principalName field, the authentication username (username entered in the login screen) is used.
In the request back to /oauth2/token it is seen if there is a session and the Principal is searched via the SPRING_SECURITY_CONTEXT attribute. The correct Principal is loaded. The JWT "sub" is issued with the correct value which is the username.
Following the flow, the org.springframework.security.oauth2.server.authorization.web.DelegatingAuthenticationConverter class registers 3 converters:
OAuth2TokenEndpointFilterCustom
 -> converters.add(new AuthorizationCodeAuthenticationConverter());
    converters.add(new RefreshTokenAuthenticationConverter());
    converters.add(new ClientCredentialsAuthenticationConverter());

And ends up using the ClientCredentialsAuthenticationConverter converter to create the authorization on top of the request. Here authorization is wrong with application name (spa-client).
The first token ends up being issued correctly because its match is made by code, as shown in the following line:
OAuth2Authorization authorization = this.authorizationService.findByToken(
				authorizationCodeAuthentication.getCode(), AUTHORIZATION_CODE_TOKEN_TYPE);

So the wrong authorization is saved in the session.
2nd authentication
At the beginning of authentication it is seen that already exists session. Here the wrong authentication is retrieved and passed to the JWT "sub".
The framework uses this wrong value until it returns the token.
Comments:

The provider responsible for the first authorization is org.springframework.security.oauth2.server.authorization.authentication.OAuth2AuthorizationCodeAuthenticationProvider;
The provider responsible for the second is org.springframework.security.oauth2.server.authorization.authentication.OAuth2ClientCredentialsAuthenticationProvider because the user is already logged into the authorization server;
The sub is mounted on top of the Principal's name attribute.

Expected behavior
In all authentications, even if the user is logged into the authorization server, the JWT's "sub" attribute must come from the username.
Examples of requests:
http://localhost:9000/oauth2/authorize?client_id=spa-client&redirect_uri=http%3A%2F%2Flocalhost%3A4200&response_type=code&scope=openid&nonce=XXXXX&state=XXXXX&code_challenge=XXXXX&code_challenge_method=S256

curl 'http://localhost:9000/oauth2/token' \
  -H 'Content-Type: application/x-www-form-urlencoded' \
  -H 'Cookie: JSESSIONID=XXXXX' \
  --data-raw 'grant_type=authorization_code&client_id=sga-portal&code_verifier=XXXXX&code=XXXXX&redirect_uri=http%3A%2F%2Flocalhost%3A4200'

Examples of returns:
Correct:
{
  "sub": "bob", // username, it's OK!
  "aud": "spa-client",
  "nbf":<PHONE_NUMBER>,
  "scope": [
    "read"
  ],
  "iss": "http://localhost:9000",
  "exp":<PHONE_NUMBER>,
  "iat":<PHONE_NUMBER>,
  "jti": "9a428545-d976-4640-81b7-2bfc9df42bb3"
}

Wrong:
{
  "sub": "spa-client", // SPA name is WRONG!
  "aud": "spa-client",
  "nbf":<PHONE_NUMBER>,
  "scope": [
    "read"
  ],
  "iss": "http://localhost:9000",
  "exp":<PHONE_NUMBER>,
  "iat":<PHONE_NUMBER>,
  "jti": "9a428545-d976-4640-81b7-2bfc9df42bb3"
}

@jacksoncastro The current behaviour is correct. When the client performs the client_credentials grant flow, it is acting on behalf of itself NOT on behalf of the user (authorization_code grant flow). Therefore, the sub in the token when the client_credentials grant flow is performed will be the client_id.
Take a look at the refresh_token grant flow, as this might be what you need to configure to refresh the expired access token and preserve the existing sub (user).
You might want to review the Client Credentials grant for further details.

@jacksoncastro The current behaviour is correct. When the client performs the client_credentials grant flow, it is acting on behalf of itself NOT on behalf of the user (authorization_code grant flow). Therefore, the sub in the token when the client_credentials grant flow is performed will be the client_id.
Take a look at the refresh_token grant flow, as this might be what you need to configure to refresh the expired access token and preserve the existing sub (user).
You might want to review the Client Credentials grant for further details.

After upgrading to version 0.1.2 the error no longer exists, even if it is a client request (SPA).
Detail any new request to /oauth2/authorize (authorization_code) returns the sub correctly with this new version.
So in that case who is with the correct behavior?

@jgrandja we just stumbled across the same issue. Due to not being able to get refresh tokens using authorization_code flow with PKCE (as highlighted here and here), we're having to go back to /oauth2/authorize whenever our access_token expires.
Now, you're suggesting to

Take a look at the refresh_token grant flow, as this might be what you need to configure to refresh the expired access token and preserve the existing sub (user).

but we can't get a refresh token in the first place, so we're kind of stuck here. Any idea how to get around this? Thanks

@nickmelis

Any idea how to get around this?

If the access token expires and there is no refresh token available, then the client needs to go through the authorization_code flow again.

@nickmelis take a look at what the OIDC spec says regarding  prompt=none.
I recently set up a SPA to use authorization_code flow with PKCE. I was able to use the client's support for "silent renew" (or "silent authentication") to utilize the session to refresh the access token automatically. If your client does not support that, you may want to look into how client implementations support this feature. In my testing, it works out of the box without any user interaction.


Github-suggested Rust workflow

This gets us basic "it builds and tests or no merge for you" CI courtesy GitHub suggesting a CI setup and @philipcmonk noticing the suggestion.
cc @lukestiles

@ashelkovnykov you can now.
@zalberico can you add @ashelkovnykov to the urbit org and to the New Mars team?

He was already in the urbit org, but is now added to the new mars team

Still unauthorized to approve merges:

I think the issue is that I only have "write" permissions for the repo in the New Mars team. I believe I need "maintainer" permissions.
@zalberico @eamsden @philipcmonk

@ashelkovnykov made you a maintainer


If, Using operator accepts promise

Description:
Continue effort as same as https://github.com/ReactiveX/rxjs/pull/1484, this PR updates using and if to accept promise for factory functions.
Related issue (if exists):
relates to #1483

I think change's are ok, but will leave bit more to see any other suggestions around before check this in.

LGTM... merging now.

Merged with f8d7d1b, thanks @kwonoj


[Source control/commit message] Double click on a word issue

Issue Type: Bug
When I double click on a word within source control
commit message and viewing the Gitlens Diff Tree(before/after),
I'm jumping to the actual file editing, not the commit message.
It's a bit frustrating experience.
Extension version: 11.0.6
VS Code version: Code - Insiders 1.52.0-insider (ac165d7f974d70212be80cb15eaecfc1fd20b21a, 2020-11-30T17:21:33.245Z)
OS version: Darwin x64 19.6.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8559U CPU @ 2.70GHz (8 x 2700)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 3

Memory (System)
16.00GB (0.28GB free)

Process Argv
-psn_0_1646994 --crash-reporter-id 1bc210f2-0273-4380-a695-9baf18ed57e0

Screen Reader
no

VM
0%

This is actually a bug in VS Code: https://github.com/microsoft/vscode/issues/110751
GitLens doesn't not provide that commit view -- that comes directly from VS Code.


Tracking: Short-circuit evaluation in expressions

Some expressions can be evaluated with short-circuit optimization.

[x] #6380
[x] #6260
[x] #6580
[x] #6203

It should be automatically closed when task list items are all done 😢


Use alertmanager API v2 by default

I am proposing that in the Prometheus 2.25 release notes, we announce the future move to the alertmanager API v2 by default.
And 2.26 would make the switch to v2 by default.
Keep the option to use v1 for the time being.

Mmh
https://prometheus.io/docs/prometheus/latest/stability/
It is not clear if we are allowed to do this.

Mmh
https://prometheus.io/docs/prometheus/latest/stability/
It is not clear if we are allowed to do this.

For the record, Alertmanager API v2 has been introduced in v0.16.0 (2 years ago) and I would say that we're on par with the API v1 since v0.19.0.
Agree that the docs make it sound contentious but if we remove API v1 from Alertmanager (which isn't covered by the same guarantees IIUC), one can argue that the best move for Prometheus is then to default to the API v2 (e.g.  "Some features, which are cosmetic, still under development, or depend on 3rd party services, are not covered by this.").
To be clear, I'm very much interested in dropping v1 support in Alertmanager :)

For the record, Alertmanager API v2 has been introduced in v0.16.0 (2 years ago) and I would say that we're on par with the API v1 since v0.19.0.
Agree that the docs make it sound contentious but if we remove API v1 from Alertmanager (which isn't covered by the same guarantees IIUC), one can argue that the best move for Prometheus is then to default to the API v2 (e.g.  "Some features, which are cosmetic, still under development, or depend on 3rd party services, are not covered by this.").
To be clear, I'm very much interested in dropping v1 support in Alertmanager :)

We have looked at this during the bug scrub.
Prometheus 2.25 will have a warning note in the changelog about this. The plan is to default in 2.26 to api v2.

I think we can close this at this point @roidelapluie, given #8484 was merged and released.


feat: use mage pkg to generate ldflags

Signed-off-by: Batuhan Apaydın<EMAIL_ADDRESS>
What type of PR is this?

/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:

Special notes for your reviewer:
Does this PR introduce a user-facing change?

feat: use mage pkg to generate ldflags

PTAL @cpanato


[stable/zetcd] Added nodeSelector for zetcd.

related to https://github.com/kubernetes/charts/issues/1899

I'd prefer that the summary can be updated to
[stable/zetcd] Add nodeSelector for zetcd.

Also need to update the commit message to
[stable/zetcd] Added nodeSelector for zetcd.

/ok-to-test

/lgtm

Any feedback from chart maintainers? Can we have this got approved? /cc @kubernetes/charts-maintainers

Since nodeSelector is already in the deployment for this chart it lgtm but... I'm not a charts maintainer so one of them needs to chime in.

/cc @kubernetes/charts-maintainers can anyone help approve?


Virtual Node: specify labels/annotations not reflected in API Spec

Description
This PR moves the labels/annots not reflected from the VK deployment to the VirtualNode Spec API.
How Has This Been Tested?

[x] Locally
[x] Unit
[x] e2e

/test

/test

/rebase test=true

/merge


Performance issues due to HostListener of global click event

When you have too many dropdowns on the screen, performance goes horrible all because you have @HostListener('document:click', ...). This initializes as many global listeners as many dropdowns you have and even when you don't need any action but just click around handlers take crazy amount of time, especially as it triggers change detection in entire application. How it can be fixed is:
in toggleDropdown() add
if (!this.isVisible && this.settings.closeOnClickOutside) {
   Observable.fromEvent(document, 'click')
		.takeUntil(this.dropdownClosed)
		.takeUntil(this.destroyed$)
		.subscribe((event: MouseEvent) => this.closeOnGlobalClick(event.target));
}

closeOnGlobalClick(target) {
	if (!this.element.nativeElement.contains(target)) {
		this.isVisible = false;
		this.dropdownClosed.emit();
	}
}

And the whole problem is solved. This will only listen global click event when certain dropdown is opened. And listener will be removed as soon as it's closed, so at a time you will only have 1 listener of global click and only when it's really needed.

Good suggestion! Was that already merged?


what is the proper way to configure and use the gpt2 peripheral?

I am using gpt1 to blink an LED.  I want to use gpt2 to toggle the virtual shift modifier on my USB keyboard experiment.  I have the following code (derived from https://github.com/imxrt-rs/imxrt-usbd/blob/master/examples/teensy4/src/support.rs)
pub fn rig_timer<'a>(
    duration: Duration,
    dcdc: &mut DCDC,
    gpt1: Unclocked,
    ccm_pll1: &mut imxrt_hal::ccm::PLL1,
    ccm_handle: &'a mut imxrt_hal::ccm::Handle,
    ccm_perclk: imxrt_hal::ccm::perclk::Multiplexer,
) -> (GPT, imxrt_hal::ccm::perclk::Configured<'a>) {
    let (_frequency, ipg_hz) = ccm_pll1.set_arm_clock(hal::ccm::PLL1::ARM_HZ, ccm_handle, dcdc);
    let mut cfg = ccm_perclk.configure(
        ccm_handle,
        hal::ccm::perclk::PODF::DIVIDE_3,
        hal::ccm::perclk::CLKSEL::IPG(ipg_hz),
    );
    let gpt1 = rig_timer_2(duration, gpt1, &mut cfg);

    (gpt1, cfg)
}

pub fn rig_timer_2(duration: Duration, gpt: Unclocked, cfg: &mut Configured<'_>) -> GPT {
    let mut gpt = gpt.clock(cfg);
    gpt.set_wait_mode_enable(true);
    gpt.set_mode(hal::gpt::Mode::Reset);

    let gpt_ocr: hal::gpt::OutputCompareRegister = hal::gpt::OutputCompareRegister::One;
    gpt.set_output_compare_duration(gpt_ocr, duration);
    gpt
}

and I use it later

        let (gpt1, mut clock_config) = support::rig_timer(
            duration,
            &mut dcdc,
            gpt1,
            &mut ccm.pll1,
            &mut ccm.handle,
            ccm.perclk,
        );

        let gpt2 = support::rig_timer_2(
            core::time::Duration::from_millis(200),
            gpt2,
            &mut clock_config,
        );

but it appears that only gpt1 is usable with the idiom (also from support.rs)
pub fn time_elapse(gpt: &mut hal::gpt::GPT, func: impl FnOnce()) {
    let mut status = gpt.output_compare_status(GPT_OCR);
    if status.is_set() {
        status.clear();
        func();
    }
}

If I use gpt2, I never observe status.is_set() being true.
I flipped things so that gpt2 controls the LED and gpt1 controls the virtual shift key, and then the shift key flips like I want, but the LED never toggles, so I am reasonably confident the problem is with gpt2 (probably my configuration of gpt2).
What am I overlooking?  What should I change to make gpt2 work the way I think it should?

Sorry for the trouble. Nothing seems wrong with your routines. The one thing I don't explicitly see in these snippets is calls to set_enable(true). That call must be happening for GPT1, or it wouldn't work. Is a similar call also happening for GPT2?
As a small sanity check, I

took all the imxrt-usbd examples, and changed them to work with GPT2. Everything looks OK. But, that doesn't test two GPTs being used at the same time...
hacked a teensy4-bsp example to use both timers for timing events. Looks OK there, too.

Your initial instinct was correct.  I was missing gpt2.set_enable(true).
I wonder if this means that there should be separate types for the object before and after set_enable.  If there are multiple methods that only make sense to call after set_enable, this might be worth investigating (although the API change would be inconvenient to all downstream projects).

This is precisely the use case for a type state, but at some point the type states become burdensome to manage. It's a tradeoff as always.


Reverb "Damp" parameter values don't match description.

Tested versions
Godot 4.3 .Net
System information
Win10 x64 22H2
Issue description
"Damp" parameter says it measures how reflective the reverb is.
0 Damping should imply full reflectivity AKA no damping
1 Damping should imply no reflectivity AKA full damping.
Right now, 0 Damping performs no reflectivity AKA full damping. 1 Damping performs full reflectivity AKA no damping.
Solution: Invert values and keep current description OR keep current values and change Damping to Reflectiveness.
Steps to reproduce
n/a
Minimal reproduction project (MRP)
n/a

This would have to be changed in the documentation, as changing the behaviour would break compatible

@yosimba2000 can you assign it to me? I am willing to contribute

Go ahead and make a PR, we don't assign issues to people generally except area maintainers


2532 Avoid exposing environment variables while deploying on Digital Ocean

Should fix #2532
This PR improves the environment variable validation function in utils.py by adding functionality to mask the values of environment variables if they are set, while ensuring missing variables are correctly identified & are not exposed.
What does this implement/fix?

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[x] Did you test the pull request locally?
[ ] Did you add new tests?

The ValueError that's being thrown now looks like:
Value error, Set environment variables are: {'DIGITALOCEAN_TOKEN': '******oken'}

Missing the following required environment variables: {'SPACES_ACCESS_KEY_ID', 'SPACES_SECRET_ACCESS_KEY'}

Please see the documentation for more information: https://www.nebari.dev/docs/how-tos/nebari-do

This looks great @arjxn-py, I am a bit conflicted though if we should showcase the settled values at all in the error message... Maybe some rewording of the final error message would help. What do you think?

What do you think?

When i added the line to showcase the settled values the motive was to help users quickly identify which variables are set and which are missing.
Hence I believe it depends upon how we prioritize things, i.e. :

[ ] If we prioritize ease of debugging and transparency we can show those masked values
[ ] If security is the highest priority and even minimal exposure is unacceptable, then we can avoid showing them.

You can check either of the above to let me know which way should I go.
In addition to that, if we'd not want to show the masked values, I believe that it makes the mask_values function redundant plus I think that the previous error message is minimal & good but in case you'd want to reword that too, you can let me know. Thanks 🙂💐

I'm not sure how much significance does this PR hold after nebari-dev/governance#50, but I've made some changes so that the raised ValueError looks like this now -
Value error, Missing the following required environment variables: {'SPACES_ACCESS_KEY_ID', 'SPACES_SECRET_ACCESS_KEY'}

Please see the documentation for more information: https://www.nebari.dev/docs/how-tos/nebari-do

I've also removed the mask_value method as that is not being used now.
Tagging @viniciusdc as a gentle follow up. Thanks.

I don't see failing integration tests related to these changes. But if I can do anything about them, please let me know :)

Hi @arjxn-py, thanks for the follow-ups; it was a bit of a wild week. Yes, we will probably decommission DO soon, but I don't see any issues merging this as is. We will review this during our next internal meeting on Monday to see if we can include it in the Jully release. Thanks for the contribution !!

Hi @arjxn-py, thanks for showing up at the community meeting today!!! We hope to see you in the next one as well, and feel free to ask any questions during those meetings as well 🚀
Regarding this PR, though, I am more than happy to ignore any changes added to it since we will probably remove these files when DO is deprecated. But I don't want to waste you efforts, so I would suggest you double check how we are handling these errors to the other cloud providers (I assume we just copied the same logic over there), and then you can refactor this PR to change things over there instead 😄

you might not need to create accounts to the other providers, I think you might be able to workaround it by just set any random thing as the values for the variables (just make sure the name of the variables match what are in our docs) e.g

export AWS_ACCESS_KEY_ID="Access Key ID - add some random thing"
export AWS_SECRET_ACCESS_KEY="Secret Access Key - same"

try it out, then you don't need to create any accounts to test it (deploy will obviously not work though, keep that in mind)

Thanks for the further instructions @viniciusdc, I checked the same for other cloud providers as well and below are the results.
AWS
Seems to handle it well as we're creating boto3 session directly and handling client error nicely:
https://github.com/nebari-dev/nebari/blob/2a1b8772e3a384f5b127f92abff71d3e7ee50ff4/src/_nebari/provider/cloud/amazon_web_services.py#L71-L76
nebari init aws --project projectname    --domain domain    --auth-provider password
Unable to locate your Amazon Web Services credentials, refer to this guide on how to generate them:

        https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_access-keys.html

Paste your AWS_ACCESS_KEY_ID:
Paste your AWS_SECRET_ACCESS_KEY:
Defaulting to `us-east-1` region.
Please double-check that the AWS credentials are valid and have the correct permissions. If you're deploying into a non-standard partition (e.g. AWS GovCloud), please ensure the region specified exists in that partition.

GCP
I believe correct credentials should create a file with a name gcloud hence raising a FileNotFoundError, but I cannot see credentials being exposed
nebari init gcp --project projectname    --domain domain    --auth-provider password
Unable to locate your Google Cloud Provider credentials, refer to this guide on how to generate them:

        https://cloud.google.com/iam/docs/creating-managing-service-accounts

Paste your GOOGLE_CREDENTIALS:
Paste your PROJECT_ID:
Defaulting to region:`us-central1`.

FileNotFoundError: [Errno 2] No such file or directory: 'gcloud'

Azure
Throwing ClientAuthenticationError & no leakage of credentials on fake credentials
Unable to locate your Azure credentials, refer to this guide on how to generate them:

        https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/guides/service_principal_client_secret#creating-a-service-principal-in-the-azure-por
tal

Paste your ARM_CLIENT_ID:
Paste your ARM_SUBSCRIPTION_ID:
Paste your ARM_TENANT_ID:
Paste your ARM_CLIENT_SECRET:
Defaulting to region:`Central US`.

ClientAuthenticationError: DefaultAzureCredential failed to retrieve a token from the included credentials.
Attempted credentials:
        EnvironmentCredential: EnvironmentCredential authentication unavailable. Environment variables are not fully configured.
Visit https://aka.ms/azsdk/python/identity/environmentcredential/troubleshoot to troubleshoot.this issue.
        ManagedIdentityCredential: ManagedIdentityCredential authentication unavailable, no response from the IMDS endpoint.
        SharedTokenCacheCredential: SharedTokenCacheCredential authentication unavailable. No accounts were found in the cache.
        AzureCliCredential: Azure CLI not found on path
        AzurePowerShellCredential: PowerShell is not installed
To mitigate this issue, please refer to the troubleshooting guidelines here at https://aka.ms/azsdk/python/identity/defaultazurecredential/troubleshoot.

Uhm.. I see, so it seems that the other providers were already fixed in the past, and only DO was left behind, primarily due to previous discussions on deprecation, though this also means we don't have anything else to change there... @arjxn-py thanks for having a look and inspecting the other providers. I think you can close this one since we will be removing the DO files soon

Closing xref: nebari-dev/governance#50


Change for assertTableEq function's verbosity for the failure cases.

Changed the error messages created on failure.

This looks very good, thank you!


Two level master-detail relation

I have successfully use MasterDetailRelation attribute for master-detail crud.
My data structure is master-detail-detail2
So I have added MasterDetailRelation attribute to detail row.
detail2 record save successfully to DB but does not retrieve.
How can I retrieve detail2 records?
Thanks.

Maybe you can add a link field

Override OnReturn of DetailRepository.MyListHandler, then something like
foreach (var x in Response.Entities) {
x.Detail2List = Connection.List(q => q.Detail1ID == Row.Detail1Id);
}
Something like this might work, but i didn't think about two level of master/detail.

When I retrieve master the OnReturn of DetailRepository.MyListHandler does not fire. It fires only the OnReturn of MasterRepository.MyListHandler.
So something has to add in OnReturn of MasterRepository.MyListHandler.
Is it possible. if possible then please give a snippet. Thank again.

var d2 = Entities.Detail2Row.Fields;
foreach (var x in Response.Entity.DetailRows)
{
x.Detail2Rows = Connection.List<Entities.Detail2Row>(d2.DetailId ==  x.Id));
}

Error in compilation: Operator '==' cannot be applied to operands of type 'Serenity.Data.Int32Field' and 'int?'

Try x.Id
Value

thanks. it works.


fix: add customizable final_snapshot_identifier

what
add customizable final_snapshot_identifier
why
to be able to have multiple db apply/destroy lifecycles in the same account

Hey @osterman, could you review this?


General PomBase stats page: Annotation status graph

This graph:

From 2011? can come from Canto?

published | 2398
close to 2400, it will likely take another 2 years to get to 2533 which is  half way !
No urgency for a graph so "future"

@manulera  has done this here
https://github.com/pombase/website/issues/2048
We still did not get to "half way"  for published but we are close (2509
2509)


Add retry to in-memory storage system (close #156)

For issue #156.
This (breaking) change adds a backoff and retry mechanism to the Emitter. Previously, events that failed to send were returned, so that the user could choose to use a callback to track them again. Now, when a request fails, the events are returned to the event buffer for retry in a subsequent request.
When a batch of events (TrackerPayloads) is removed from the event buffer for sending, the events are now copied into a hashmap, and turned into a BatchPayload, a new wrapper class. BatchPayload stores the TrackerPayloads for the request along with the hashmap key. If the request is sent successfully, the batched events are deleted from the hashmap. If not, they are inserted back at the front of the event buffer. The aim is to send events approximately first in, first out.
The backoff mechanism uses the schedule() of ScheduledThreadPoolExecutor to delay all new requests after a failure has occurred. The initial delay is 50 ms, which increases exponentially with every subsequent failure. When one request succeeds, the retry delay returns to 0.
For testing purposes, it made sense here to allow users to set the InMemoryEventStore event buffer capacity on creation. The LinkedBlockingDeque by default has a capacity of Integer.MAX_VALUE. Having a bufferCapacity field made the name bufferSize to mean batchSize extra confusing, so I changed it. It's not really part of retry though, so I might move these commits to their own issues.
Note to community contributor @AcidFlow: we merged in your PR #259 in version 0.11.0 which allowed users to select their own ExecutorService. My current changes now require the ScheduledExecutorService interface. Any thoughts on this change?

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

Hey @mscwilson !
I haven't look at the whole changelog yet as I don't have much time, but regarding your change now requiring a ScheduledExecutorService I think this should be fine. IIRC my previous contribution was to give more control on the Executor service so you could control its thread factory, pool and rejected execution handler so users would control the amount of thread they use, and could add metrics on rejection for instance. Using a ScheduledExecutorService still gives the user the same control with more reliability thanks to your changes :)

Great, thanks @AcidFlow!


Rumble state is not always sent to client code

Describe the bug
Rumble feedback inconsistent. Request packets may get lost or come in out of order.
To Reproduce
Write a Feeder using the feedback callback/event and produce rumble requests with e.g. Dolphin Emulator (like so)
Expected behavior
Rumble packets should arrive in the syme order as submitted to the driver via XInput API.
Screenshots

System details (please complete the following information):

OS: all
Feeder software: all using the feedback events, either native or managed
Driver Version: all up to this point

Additional context
Original report

I've already butchered in a pool of threads which queues more requests pending in the driver and thus - not entirely fix - drastically reduces the chances of the queue running dry. So now I'm not losing packets anymore but now of course concurrency issues arise.
Invoking the notification function pointer/delegate within the same thread should be moved to a different worker thread and received packets shall be handed over via linear synchronized queue.

I've butchered the master branch quite a bit, my apologies, but I now found a way to deal with it properly via WinAPI, stay tuned.

It's Easter "holidays" here but I am still sober enough to get back to this, you shall be fixed if it's the last thing I'll do 😱

There we go https://youtu.be/uzNcQfxaMF0
Next some clean-up, more tests and applying the same to the DS4-code and we're ready to ship 😅

Thx for the fix. Rumble feedback seems to work now and no more lost events (at least when tested as part of DS4Windows app).

Based on this branch? Or on a workaround by DS4Windows?

Based on the fix in ViGemClient client library (as used via C# .NET library in DS4Windows).
DS4Windows app does have a fallback "max rumble timeout" to stop the rumble if it seems to be running exceptionally long time without any feedback updates from ViGemBus/Client.  But I have tested the new ViGemClient without this fallback timeout also to test whether the client side fix really does the trick. The good news is that I haven't seen any stuck rumble motors in those scenarios where it used to get stuck before this VigemClient fix (or fallback timeout workaround).

Great, thanks for the feedback. Next is to polish my horrible C++ shenanigans, implement proper clean-up and do the same for the DS4 route and we shall be on our route to victory 😎

You know what they say: "If it works, don't fix it".
But being a software developer I know that "cleaning up a code" is not the same as "fixing something which isn't broke" :-)

Nah by cleaning up I mean properly address all of the legacy code fragments and possibly leaking memory because I wanted to get a working prototype fast and "make it right" later 😉


dendrite: 0.9.6 -> 0.9.7

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/matrix-org/dendrite/releases.
meta.description for dendrite is: "A second-generation Matrix homeserver written in Go"
meta.homepage for dendrite is: "https://matrix-org.github.io/dendrite"
meta.changelog for dendrite is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.9.7 with grep in /nix/store/gwzsp4p3lg14ksd6ggasi2p0z22nryh0-matrix-dendrite-0.9.7
found 0.9.7 in filename of file in /nix/store/gwzsp4p3lg14ksd6ggasi2p0z22nryh0-matrix-dendrite-0.9.7

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
dendrite

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gwzsp4p3lg14ksd6ggasi2p0z22nryh0-matrix-dendrite-0.9.7 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dendrite https://github.com/r-ryantm/nixpkgs/archive/f7e287cfd5382f6746b7da35e8602952c014ea32.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gwzsp4p3lg14ksd6ggasi2p0z22nryh0-matrix-dendrite-0.9.7
ls -la /nix/store/gwzsp4p3lg14ksd6ggasi2p0z22nryh0-matrix-dendrite-0.9.7/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

dendrite

Maintainer pings
cc @Ma27 @fadenb @mguentner @Ekleog @Ralith @dali99 @sumnerevans for testing.

Result of nixpkgs-review pr 190804 run on x86_64-linux 1

1 package built:

dendrite


[VSCode 0.10.10] unexpected end of input. Stopping the debug adapter

Moved from: https://github.com/NativeScript/nativescript-vscode-extension/issues/25#issuecomment-194091440

Fixed with b0fa4c443899909f971ecff39f62c270959cda36


Fix tstamp explanation

Guidelines explanation of timestamps (section 1.3.3) states that tstamp=1 is the left bar line. I think it should be 0 (that seems to be how it's interpreted in Verovio).

@DILewis Thanks for the catch!


0.2.0: Play-related, Voice-related APIs

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/38760
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.0 -m "<description of version>" 377ffb326d25d4552cfd41ca822aec16067744af
git push origin v0.2.0


[minor docs] Fixes incorrect and inconsistent IAM policy indent

The IAM policy for AWS billing connection is poorly indented (as seen in the below screencap) - this updates the indentation to be consistent and correct.

@Phuurl : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


host functions: implement ed25519_verify

Currently blocked, waiting for clarification here: https://near.zulipchat.com/#narrow/stream/295302-general/topic/light_client/near/287206877


Ineffectual assignments

Below is a list of ineffectual assignments. These mostly indicate bugs. Here are a few for illustration.
Noop in jsonapi.go:
xs = (xs)[:j]

Overwritten/missing error check in confirmation.go:
redeemScript, err := hex.DecodeString(contract.BuyerOrder.Payment.RedeemScript)
_, err = n.Wallet.SweepAddress(utxos, nil, vendorKey, &redeemScript, spvwallet.NORMAL)

And again
redeemScript, err := hex.DecodeString(contract.BuyerOrder.Payment.RedeemScript)
signatures, err := n.Wallet.CreateMultisigSignature(ins, []spvwallet.TransactionOutput{output}, vendorKey, redeemScript, contract.BuyerOrder.RefundFee)

Complete list:
api/jsonapi.go:1628:4:warning: ineffectual assignment to xs (ineffassign)
core/completion.go:291:10:warning: ineffectual assignment to err (ineffassign)
core/confirmation.go:138:17:warning: ineffectual assignment to err (ineffassign)
core/confirmation.go:218:17:warning: ineffectual assignment to err (ineffassign)
core/disputes.go:850:23:warning: ineffectual assignment to err (ineffassign)
core/fulfillment.go:84:17:warning: ineffectual assignment to err (ineffassign)
core/listings.go:137:7:warning: ineffectual assignment to err (ineffassign)
core/order.go:103:7:warning: ineffectual assignment to err (ineffassign)
core/order.go:584:16:warning: ineffectual assignment to err (ineffassign)
core/order.go:639:3:warning: ineffectual assignment to skuExists (ineffassign)
core/order.go:1174:22:warning: ineffectual assignment to err (ineffassign)
core/order.go:1248:22:warning: ineffectual assignment to err (ineffassign)
core/profile.go:140:14:warning: ineffectual assignment to err (ineffassign)
core/refunds.go:84:17:warning: ineffectual assignment to err (ineffassign)
net/service/handlers.go:439:17:warning: ineffectual assignment to err (ineffassign)
net/service/handlers.go:501:17:warning: ineffectual assignment to err (ineffassign)
repo/config.go:58:2:warning: ineffectual assignment to headers (ineffassign)
repo/db/cases.go:261:8:warning: ineffectual assignment to err (ineffassign)
repo/db/cases.go:330:8:warning: ineffectual assignment to err (ineffassign)
repo/db/chat.go:179:6:warning: ineffectual assignment to err (ineffassign)
repo/db/chat.go:195:6:warning: ineffectual assignment to err (ineffassign)
repo/db/db.go:345:8:warning: ineffectual assignment to err (ineffassign)
repo/db/followers.go:73:8:warning: ineffectual assignment to err (ineffassign)
repo/db/following.go:68:8:warning: ineffectual assignment to err (ineffassign)
repo/db/keys.go:78:8:warning: ineffectual assignment to err (ineffassign)
repo/db/purchases.go:35:7:warning: ineffectual assignment to err (ineffassign)
repo/db/purchases.go:169:8:warning: ineffectual assignment to err (ineffassign)
repo/db/purchases.go:196:8:warning: ineffectual assignment to err (ineffassign)
repo/db/sales.go:35:7:warning: ineffectual assignment to err (ineffassign)
repo/db/sales.go:170:8:warning: ineffectual assignment to err (ineffassign)
repo/db/sales.go:197:8:warning: ineffectual assignment to err (ineffassign)
repo/db/txmetadata.go:41:8:warning: ineffectual assignment to err (ineffassign)

Superseded by #499


Stop running save-jobs notebook in CI for now

The notebook is failing with this:
---------------------------------------------------------------------------
StopIteration                             Traceback (most recent call last)
Cell In[2], line 3
      1 # Get ID of most recent successful job for demonstration.
      2 # This will not work if you've never successfully run a job.
----> 3 successful_job = next(jforjinservice.jobs()ifj.status().name=="DONE")
      4 job_id = successful_job.job_id()
      5 print(job_id)

StopIteration:

Also closes https://github.com/Qiskit/documentation/issues/2277 by ignoring a valid link.

Hm, this doesn't work because later cells depend on this cell.

Follow up tracked by https://github.com/Qiskit/documentation/issues/2287


The vscode:// url scheme usage is not documented

I asked a question in stack overflow to learn more about how to use vscode:// and what endpoints and parameters are available, but I got no aswers for a long time and I am going to assume that this is not documented at all.

Sorry, I just realized this issue should go in the vscode-docs repository.

For reference, this is the issue I posted in the vscode-docs repository.


Don't Merge! PR real time test for source branch full build

Docs Build status updates of commit bf1fa45:
:clock10: Pending: waiting for processors (28 builds ahead of you)
:warning: Docs Build is busy, currently there are 28 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit bf1fa45:
:clock10: Full build: the average full build time is 5 min(s) 16 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit bf1fa45:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: filters proposals by label

Summary

Closes: https://github.com/snapshot-labs/workflow/issues/254

Add labels filter to the proposals page
Add link to proposals page with labels filter

How to test

Go to proposals page
Try to select some labels in the labels filter
Individual label tag in proposals list and in proposal page should link to the proposals page with the correct labels filters already set

We should also make labels clickable on proposal preview and proposal page and redirect to proposals page with the label filter.

Can we add the labels on /home page and user page as well? And can we make labels clickable on the single proposal page, (redirecting to /proposals with label selected).

Can we add the labels on /home page and user page as well? And can we make labels clickable on the single proposal page, (redirecting to /proposals with label selected).

Labels already appearing on all proposals list (but notifications)

@bonustrack is the current UI ok ? or do you have something better ?

We don't need the counter here, event if we improve the style, it's not too relevant, most of time users wont filter 30 labels so we dont really need to count them:

Otherwise it looks good

We don't need the counter here, event if we improve the style, it's not too relevant, most of time users wont filter 30 labels so we dont really need to count them, we better save space:  Otherwise it looks good

How do you tell how many labels I have selected in this case ?

2 or more will have the same UI

Last minute performance addition: added a throttle to the watcher, so we "batch" requests when user is selecting multiple labels

Last minute performance addition: added a throttle to the watcher, so we "batch" requests when user is selecting multiple labels

Isn't that mostly useful when there can be lot of update going on?

Last minute performance addition: added a throttle to the watcher, so we "batch" requests when user is selecting multiple labels

Isn't that mostly useful when there can be lot of update going on?

User can select multiple labels

But it's not like they typing something, they will already take like half second to select another label

Maybe i’m just fast, we could increase throttle, or leave it like that
On Sat, Oct 26, 2024 at 17:04 Less @.***> wrote:

But it's not like they typing something, they will already take like half
second to select another label
—
Reply to this email directly, view it on GitHub
https://github.com/snapshot-labs/sx-monorepo/pull/910#issuecomment-2439576172,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADZAXONHELRLQVH7ZTY3FDZ5OHODAVCNFSM6AAAAABQGUFZDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZZGU3TMMJXGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Ok, I think we can leave it like this, can't be bad.

@wa0x6e Can we merge this?

@wa0x6e Can we merge this?

Up to the reviewers, for the latest changes

I believe it's good to go, you already addresses comments from Wik.


fix(@angular/cli): disable node global

The node only global object had been left in because it used to cause a build size regression with Angular.
This doesn't seem to be the case anymore so it should be removed because it causes problematic interactions with some libraries.
Fix #5804
Supersedes #7931

Note<EMAIL_ADDRESS>and up do not support old IE versions: https://github.com/webpack/webpack-dev-server#caveats

Whoops I found and issue with these changes :
Uncaught ReferenceError: process is not defined
https://github.com/zertosh/invariant/blob/49ae54d5a09c99a447e7dafa46bd3aa8f6923d98/invariant.js#L23
Only in dev mode, prod build works fine.

Ok I see. It's quite common for libs to try and check the env if available so we shouldn't disable it.
Thanks a bunch for testing this, it would have gotten through otherwise.

heads up that this might break the old service worker library. see:
https://github.com/angular/angular/pull/19702#issuecomment-338808149
should we make this option configurable? or at least turn it on if the old
service worker is present?
On Mon, Oct 23, 2017 at 2:57 PM Hans<EMAIL_ADDRESS>wrote:

Merged #8130 https://github.com/angular/angular-cli/pull/8130.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/pull/8130#event-1306600484, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AANM6KeQsmmPFnlPoo7g0jps2eLV1Xbsks5svQvmgaJpZM4QA4EL
.

@IgorMinar I think the error on the message you linked was due to patching the CLI files to disable global but not having updated webpack-dev-server with it (as this PR does). The webpack-dev-server version was needed to fix https://github.com/webpack/webpack-dev-server/issues/1147 (fixed by https://github.com/webpack/webpack-dev-server/pull/1148).

Seems like pdfjs is broken due to this change. It (or one of its dependencies) tries to load the browserify Buffer, which checks the environment.

can you make global configurable in angular-cli.json ? It also breaks Faye.

I'm starting to think that this will have to be configurable to allow
certain libraries to work, but it should be off by default.
On Fri, Oct 27, 2017 at 3:27 PM Michal Žeravík<EMAIL_ADDRESS>wrote:

can you make global configurable in angular-cli.json ? It also breaks Faye.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/pull/8130#issuecomment-339971030,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANM6J4x0OVZw9KAZ4q3mOuJEh6ewCv7ks5swdpLgaJpZM4QA4EL
.

@IgorMinar I agree. I have found no way how to get Faye (and possibly others) to work without global.


WIREFRAMES: Build Report Part 1 [5]

As a user, I want to review the Build Report. Wireframes will be created including:
Content such as:

stack level overview
component level information
recommendations

Interactions that should be included in wireframes:

Progress indicator while report is being generated
Failure state
How to take action on recommendations (Create work item)

Checklist:

Review with ALM team
Review with product team

Current wireframes, D2: https://redhat.invisionapp.com/share/A2AGUVBR8
(can share password as needed, per Matthias' request)
Reviewed with product team on 2/15 – Notes here


Support auto-restart RuboCop server

This PR supports auto-restart RuboCop server when updating RuboCop.
First, cache RuboCop version when the RuboCop server starts.
And, auto-restarts when the runtime (client) RuboCop version does not match the cached RuboCop version.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Seems to me that changes to the config should also auto-restart the server.

Right! I would like to look at it separately from this PR.

Thanks!


working credentialManager

I got it working! I fixed a few typos and made a bugfix to the confirm function so its response would actually get sent back over the postMessage, and updated clone to use the newly fixed corsProxy parameter.
I've only tested it for git clone. I imagine there may still be small fixes needed for fetch and push.

Ha, it works, thanks.


Dev Docs Revisions #4 - HTTPS Outcalls

Thank you for your contribution to the IC Developer Portal.
Before submitting your Pull Request, please make sure that:

[ ] You have updated the .github/CODEOWNERS file according to your changes.
[ ] You have registered new documents to /sidebars.js if any.

Closing and opening fresh PR


Fix log output bug - possible missing spaces between tokens

Hi,
While trying to run the Jenkins build collector I've found that a place without proper spacing in the logs.
Example:
2016-09-03 04:22:00,302 INFO  c.c.d.collector.CollectorTask - Error getting jobs for: http://<IP_ADDRESS>0s
Note that the '0s' is not separated from the host at the end.
My change should make it so that there is always at least one space between the tokens.

@LiranV - Thanks for the PR. Did you submit the CLA?

@tabladrum - just submitted the CLA. Thanks.

LGTM

LGTM


Feature: Use existing frames

Changelog Description
This PR adds option to publish previously locally rendered files. This allows artist to prepare workfile, press AE Render button and visually check rendered files. Only after that they might decide that these files are OK and should be published without re-rendering.
Additional info
Similar to Nuke functionality
Testing notes:

set Use existing frames in Creator

check Validator function before you'll hit Render in AE
Hit Render

5.Publish

Maybe the RenderCreator should convert value of "farm" from older instances to render target.


fix: Missing USD value on gallery item

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Feature

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #6954
[ ] Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[x] My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at f8208fa
Added USD prices to NFT activity table and made coingecko utility function more generic. This improves the user experience and the code maintainability.

🤖 Generated by Copilot at f8208fa

Sing, O Muse, of the skillful coder who modified the function
That getApproximatePriceOf was called, to take a string as input
And not a fixed union of tokens, as before, that limited its use
But now with tokenMap he made it work for any coin of value.

uuu, nice nice
Could you just put the USD prices in brackets to a k-grey color + put a gap between the ksm price and USD

uuu, nice nice
Could you just put the USD prices in brackets to a k-grey color + put a gap between the ksm price and USD

✅ Updated. Please check it. @exezbcz

thanks!

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.44 USD/DOT ~ 6.757 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0xcf6f68a71e8602fbc25060161b533eecca923ca003082850faee90ba311e7b92
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

next I think would be to have only one decimal should be enough to have clear UI
for bigger numbers I would use "k, M" 1000 -> 1k  & 1,000,000 -> 1M as some tokens are low on value


New emojis don't display

Hi! I've noticed new emojis just show as boxes with a cross through them. If I enable the iOS emoji pack, they just show as blank. The emojis work fine in every other app and they show on my keyboard fine.
Using latest version in the Play Store (1.12.2) on Android 13 on a new motorola razr 40 ultra.
Thanks!

I installed the beta from GitHub, emojis work with the iOS pack enabled but still display as a box with a cross through it if using the system Android emojis.

Unfortunately this is a flutter limitation, they haven't updated their internal fonts pack to support new emojis. This will be fixed once they do this.


Rendering less things in the RHS threads

Summary
Rendering the flag icon and the date (when is consecutive) only on hover or when is active, and the user profile info only when is not consecutive.

@lieut-data for the flag one, the checks are clearly way cheaper than the rendering of the flag itself, so this will be more performant in small and large threads. About the date, we only safe rendering on consecutive messages, so in a thread, long or short with a very small number of consecutive messages, we can have a worse performance but I doubt it, because we are adding 4 direct variable checks, and in the other hand we have the rendering of the date which probably is way more expensive than 4 variable checks.

@sudheerDev sure, no problem, we can explore other approach, something like "do not render on first render" but render it on firstHover and keep it there.

@sudheerDev any news here?

@jespino Will do this tomorrow. Was occupied with release bugs

@sudheerDev yes, no rush, just only to know where we are :)

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: https://i-080e4641b89fd254b.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Internal IP: <IP_ADDRESS>
Instance ID: i-080e4641b89fd254b

Spinmint test server destroyed

@jespino If we move the cusror fast frames drop to about 30fps for showing the hover menu i.e we skip showing menu for few messages on the way. Thats hardly a use case we need to consider IMO.
For the record: on daily for me most of the events are around 15ms or so. On spintmint it is close to 30ms.


Versioning and naming of datasets

Country ISO3
Date of processing
Metric name
date information

Check with @rowannicholls - are all admin levels collated into one file - e.g. in process_terraclimate or separate files.
Example for chirps-rainfall could be:
VNM_meteorological_chirps-rainfall_2024-11-18_date(2023-02).csv
or for WorldPop density data:
VNM_sociodemographic_worldpop-density_2024-11-18_year(2023).csv

@prathyushsambaturu this is taken from the naming parameters for the DART functions, where date can be year, year-month, year-month-day

Makes sense. Then we could go with this naming convention.


opening the find widget messes up the notebook view

Testing #180768

open a notebook and add a markdown cell with content at the top
open the replace widget and find an existing string in the markdown cell
Put focus somewhere else in the notebook, then press ctrl+f to focus the find widget
🐛 markdown cell is bumped up out of the view

@amunger you found good bugs!


Mocks

Once #2 is done, I should create some mocks for the design of the site

I made some rough drafts on Sketch. Gonna finish up the design with CODEZ.


Windows 2022 is not supported

List of supported OSes seems to be ending with Windows 2019. Is Windows 2022 in fact is not supported?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bef853ec-6fcb-22dc-76cf-d12af7c87dee
Version Independent ID: c36fc153-ef89-842e-9b48-5986b1b49552
Content: Azure Automation State Configuration overview
Content Source: articles/automation/automation-dsc-overview.md
Service: automation
Sub-service: dsc
GitHub Login: @SnehaSudhirG
Microsoft Alias: sudhirsneha

@artisticcheese
Thanks for your feedback! We will investigate and update as appropriate.

@artisticcheese, Received confirmation from the Engg team that Windows 2022 is not supported yet.


feat: enable autosharding in rln-js

Duplicate of https://github.com/waku-org/examples.waku.org/pull/296 for new example
Blocked by https://github.com/waku-org/js-rln/issues/91 as the message is not getting sent

closing in favor of https://github.com/waku-org/lab.waku.org/pull/13
will be addressed in https://github.com/waku-org/js-rln/issues/91


Missing the ISSUE TEMPLATES and the Code of Conduct

The project is currently missing the ISSUE TEMPLATES and the Code of Conduct.  With the issue templates, you can encourage contributors to include specific, structured information by using issue forms in your repository, and the code of conduct defines standards for how to engage in a community. If you want to add those, then I would be happy to add a PR.

I get the purpose of the issue template, but I'm not 100% sure we need it for now
Otherwise I've added a code of conduct! Thanks for your interest in the project :)


Variable within subject with dynamic_template_variable_data doesn't work

Issue Summary
I'm trying to insert a dynamical variable into the subject line via this library.
For example: "Hello {{name}}, welcome to {{store_name}}"
My email sends off no problem, but the subject renders {{name}} and {{store_name}} as... just that. No variables are inserted.
Code example:
                 dynamic_template_data: {
                    name: "John",
                    store_name: "My store",
                    subject: "Hello {{name}}, welcome to {{store_name}}!"
                  }

In my template within Sendgrid UI, the subject value is: {{subject}}
I've also tried: {{{subject}}} but no go.
Email is sent and the subject line is...
Hello {{name}}, welcome to {{store_name}}
When it should be...
Hello John, welcome to My store!

You may need to generate the dynamic subject in your code.  Or, try adding that dynamic subject in the html template’s subject line as opposed to in the dynamic_template_data key


increase circle timeout for dep ensure

Review Error for zblach @ 2018-12-12 21:04:48 UTC
User must have write permissions to review

Review Error for zblach @ 2018-12-12 21:06:08 UTC
User must have write permissions to review

This Pull Request was merged without enough reviews
Please go here to review and +1


Writing as Thinking (and Learning and Leading)

Article written as a note taken in Linkedin - https://www.linkedin.com/feed/update/urn:li:activity:7010327457459245056
https://mentrixgroup.com/newsletter/2022/12/01/writing-as-thinking-and-learning-and-leading

ORQGW5T4NVAQ3V5JJKC5FDPB6WJM6SRA


Entrypoint contract reference for V0.7

Background
EntryPointContractAddress in SmartWallet is hardcoded to v0.6 version
Question
How to manage this for V0.7?
should this be made configurable or create another SmartWallet Contract file for V0.7 as UserOps Struct is updated in 0.7

@wilsoncusack looking forward to contribute to codebase
please let me know if i can take up any issues

Hey @kanthgithub we are still considering whether we will support v0.7. Several things would have to change if we choose to do so. Closing this for now.


Ease Cursor Lag (VSync Active) with Better System Cursor Support

Input lag is a known problem when VSync is active, simply because it may take from 16 to 33 ms between the detection of an input signal by the OS to displaying the results ingame on screen. There's not really much that can be done about that.
However, in the especially obvious case of mouse cursor lag, the effects can be concealed by using the system mouse cursor instead of a custom rendered one. This is already possible, but the default system cursor isn't a great visual choice for most games.

Add backend API to specify the cursor image to use with a configured PixelData sprite.

Don't add this to INativeWindow, because it should also work in the editor. There needs to be a central API for that.
Consider adding it to the IGraphicsBackend directly, with the actual backend implementations pulling from there internally.

Update the BasicMenu sample to only render the ingame cursor when the system cursor is inactive. Also add a neat custom cursor sprite for the system cursor.

This Reddit post could have something interesting regarding VSync input lag.


[FEATURE] Order details in the my account section

In my account, in the section of history orders, each element has a link to "view details",  but there is no such a view:

Done:)


Duplicate items in contents

File: datacenter/dtr/2.2/guides/admin/manage-users/index.md, CC @joaofnfernandes
In the left navigation, this page is labeled as "Create and manage users", which is the same as the next page.

Title in the document is correct ("Authentication and authorization in DTR") but navbar displays "Create and manage users" which I can't find in the document.


Fix "whos" > "whose" in setup.py

Small typo.

Coverage remained the same at 100.0% when pulling 6a79e77ee1f7b1338a8a3d0c04682985229176c4 on StevenMaude:patch-1 into 5f31cc1d4031aaa1a416261bf456e0a1e6a93f58 on mewwts:master.


Object requires a newer version of iOS

Description
Hi Folks,
first of all, thank you for this wonderful library!
However, I'm not sure what am I doing wrong since my AR on iOS does not seem to work - it returns the message:
Object requires a newer version of iOS.
I assume that something might be wrong with my model:
https://cdn.glitch.global/40b96037-9b1b-4d40-8f86-6c16abe963fc/model.glb?v=1715287619810
Once I try to run it in AR, I can find following warning in my console:
THREE.USDZExporter: USDZ does not support double sided materials
When I set double sided material to false, the AR still shows "Object requires a newer version of iOS".
To be clear, I’m on the latest version of iOS and i tried several others too.
Thanks in advance for any help!
Live Demo

https://smooth-abalone-molybdenum.glitch.me/

Version

model-viewer: v3.5.0

Browser Affected

[ ] Chrome, version: xx.x.xxxx.xx
[ ] Edge
[ ] Firefox
[ ] IE
[x] Safari

OS

[ ] Android
[x] iOS
[ ] Linux
[ ] MacOS
[ ] Windows

AR

[ ] WebXR
[ ] SceneViewer
[x] QuickLook

Considering it says you need a newer version of iOS, could you at least include your iOS version? :)
@AdaRoseCannon @mrdoob Maybe you two can work out some kind of testing regimen so that Apple's Quick Look isn't constantly making breaking changes to its USDZ reader (this file is produced by Three's USDZExporter)?

Just to clarify, what version of THREE.js does this USDZExporter come from?

r163 - we're generally up to date at whatever the time of our release was.

From my side I have no other option than reverse engineer iOS viewer VR disabling things until it works again. It would be greatly appreciated if iOS could offer a mechanism to know what the issue actually is.

Can you link the USDZ model generated so we can take a look?

@AdaRoseCannon do you have a tool to extract it from a QuickLook session? MV just generates it in memory and passes the blob across, so there isn't super easy file access without hacking MV a bit. You might consider setting up a Glitch with Three.js for converting glTF to USDZ so you can easily repro problems like this (they are very common with our users).

I’ll do that, if @ermincelikovic has the original gltf then that would also be fine and I will make a glitch to test it with.

I believe the original GLB is the first link in the description above.

Totally missed it, my bad!

@AdaRoseCannon do you have a tool to extract it from a QuickLook session? MV just generates it in memory and passes the blob across, so there isn't super easy file access without hacking MV a bit. You might consider setting up a Glitch with Three.js for converting glTF to USDZ so you can easily repro problems like this (they are very common with our users).

Or you can load the glb in https://threejs.org/editor/ and export to usdz from there too.

That is a really useful tip and will save a lot of time.

Yes, I think we've been told to file Apple issues through their feedback assistant, though I personally find that kind of one-way communication irritating, so I'd also recommend filing it on their WebKit bug tracker where you might at least get an update.


facetFilters configuration not interpreted correctly with i18n

🐛 Bug Report
We localized our docusaurus website with the i18n feature.
Our website is has only 1 version so we don't need contextual search yet. -> I tried contextualSearch: true, this returns 0 results.
However the website is in 2 languages. So instead I decided to use faceFilters .
We have 3 docusaurus websites, but one algolia index.  our configuration looks good to me (very similar to docusaurus-v2 config except we have tags for the product):
https://github.com/algolia/docsearch-configs/blob/master/configs/boc-group.json
The algolia index is created based of the following URLs.
https://docs.boc-group.com/adonis/
https://docs.boc-group.com/adoit/
https://developer.boc-group.com/
Hence, with the following configuration we get search results of the appropriate product (e.g. adonis), BUT in 2 languages.
And we want to have only the language we are in.
    algolia: {
        apiKey: '3acb8d1e2dca055840337e29fa9be493',
        indexName: 'boc-group',
        searchParameters: {
            facetFilters: ['tags:adonis']
        },

SO.
We decided to add another facetfilter (because contextual search returns 0 results) -->
        algolia: {
            apiKey: '3acb8d1e2dca055840337e29fa9be493',
            indexName: 'boc-group',
            searchParameters: {
                facetFilters: ["tags:adonis","language:en"]
            },
        },

unfortunatly the above results in 0 results
To Reproduce
It's complicated to reproduce this in a sandbox due to the dependency with algolia.
Expected behavior
I would expect to find searchresults for the language I am in.
Actual Behavior
the search results return results in both languages.
Your Environment

Public source code: /
Public site url: https://docs.boc-group.com/adonis/
Docusaurus version used: Alpha.75
Environment name and version (e.g. Chrome 78.0.3904.108, Node.js 10.17.0):
Operating system and version (desktop or mobile): Windows 10  desktop

Reproducible Demo
The sandbox has trouble compiling with algolia it seems
https://codesandbox.io/s/holy-rgb-rszwc?file=/docusaurus.config.js
<EMAIL_ADDRESS>Module not found: Can't resolve '@theme/hooks/useSearchQuery' in '/sandbox/node_modules/@docusaurus/theme-search-algolia/src/theme/SearchPage'

It appears or  I understand now that the index is wrong.
Unfortunatly the Docsearch only gave access rights to the Algolia analytics dashboard but not the index itself.
I now realize that production does not have the required filters because in production we have lunar search still, hence why the index is wrong.
This does mean that for first time users, their search will only work after 24 hours after deployment to production.
OR
if you want a correct index before production, as you suggest, create a stage deployment with something like vercel where you include configure docsearch, index that (ask docsearch to accept your fork with your staging URL), in order to have a correct index before deploying to production.

Yes, it is required that you first deploy a Docusaurus site with the Algolia Docsearch plugin enabled, and then run a crawler on this site with the plugin enabled, so that the index is populated by the correct page metadatas


use onlyLocals option instead of css-loader/locals

css-loader/locals is no longer available in favor of the new onlyLocals options.

I still get an error. I think we'll need a merge for fix this. "Cannot find module 'css-loader/locals'"

Works for me. @jaredpalmer can we get this in?

This PR works for me thanks for creating @dominicrico and merging @jaredpalmer .
Are there plans to release a new version of razzle-plugin-scss that includes this change? Looks like there have been several changes and no new releases of the plugin.


[AppConfig] List Labels operation support

Summary
The App Configuration service supports an operation to list the labels associated with a resource, optionally filtering them.  The configuration client does not currently support this operation but should be extended to expose it.
Scope of work

Update the AppConfiguration client to support listing tags and, optionally, filtering by name.
Ensure documentation and samples are available to guide developers who wish to use the feature.

Success criteria

The AppConfiguration client API has been updated to include the service operation for listing tags.
When listing tags, the client supports passing an optional name filter, as supported by the service API.
The necessary documentation and samples have been created and follow repository standards.
The existing test suite continues to produce deterministic results and pass reliably.

References and resources

REST API Spec
REST API Docs

Close this issue as the feature supported in App Config 1.7.0.


Improve force layouts, edge panning

Improves the force layouting to be faster and less jittering

Thanks a lot, very nice changes!
asSet vs asIdentitySet was the right call btw, Pragma objects only compare their keyword (which is almost always action) and arguments (which are always empty), so asIdentitySet should give us the expected result if the duplicates arise from subclasses. Otherwise, we may even have to deduplicate by Pragma>>#selector, which is what we actually care about. But that case that this is necessary should arise rarely.


List available tags/versions when using/referencing a module

When writing a module reference I would like to get a list of available tags/versions in the private registry. This is very useful for any consumers of the module registry.
module vm1_res 'br/AzfModules:virtualmachine:xx' = {}

I think we have 2 options to implement this - 1 is to rely only on the list of images retrieved from ACR - the AcrPull permission allows user to list repositories and tags. However to get a descriptions of modules that are stored in metadata, we would need to download entire repository which would be too much.
Second option is to create a special repository with latest tag that will contain a generated index file. The index image name could be defined in bicepconfig for each registry alias and/or we could have a default (i.e. _index) to look up for.
We could have a tool or a command in bicep that would update the registry index - for each tag you could provide additional description or link to a MD file which would show in the hint on VSCode.
Assuming we have following bicep modules in our ACR:
bicep/networks/virtualnetwork:v1.0.0
bicep/networks/virtualnetwork:v1.0.1
bicep/networks/virtualnetwork/peering:v1.0.0
bicep/appservice/serverfarm:v1.0.0

The file itself could be a JSON file, some sample structure to begin discussion.
{
  "$schema": "http://bicep.azure.com/schema/registry-index",
  "registry": {
    "bicep": {
      "modules": {
        "networks": {
          "modules": {
            "virtualnetwork": {
              "tags": {
                "v1.0.0": {
                  "description": "Virtual network module v1.0.0 description"
                },
                "v1.0.1": {
                  "description": "Virtual network module v1.0.1 description"
                }
              },
              "modules": {
                "peering": {
                  "tags": {
                    "v1.0.0": {
                      "description": "Virtual network peering module v1.0.0 description"
                    }
                  }
                }
              }
            },
            "routetable": {
              "tags": {
                "v1.0.0": {
                  "description": "Route Table module v1.0.0 description"
                }
              }
            }
          }
        },
        "appservice": {
          "modules": {
            "serverfarm": {
              "tags": {
                "v1.0.0": {
                  "description": "App Service Server Farm module v1.0.0 description"
                }
              }
            }
          }
        }
      }
    }
  }
}

And this JSON would be placed in registry.azurecr.io/_index:latest image.
The reason behind this structure (dictionary, not list) is to ensure we do not have duplicates and simplify querying.
Here I assumed that index is at the top-level of the registry. Obtaining list of all modules in registry will reduce amount of downloads and will provide better experience
If we had smaller indexes on "networks" and "appservice" levels and then the VSCode would need to look for index every time we put a slash if we have a top-level module. example:
in bicepconfig we have a registry br/coreNetworks configured with path bicep/networks. when we type module vnet 'br/coreNetworks: tool tries to get bicep/networks/_index:latest image and read the index generated just for networks module.
But if we had a br/contoso configured with path bicep and indexes in bicep/networks/_index and bicep/appservice/_index then, typing module vnet 'br/contoso: would not give us any hint, or we would need to have additional index in bicep/_index just to list available "subregistries".
therefore I think having a one common index for entire ACR is a better option. based on registry alias path we can easily build a filter to narrow down the JSON and provide hints only for modules in registry alias.

I might recommend doing Option 1 as a first step, and then introduce Option 2 if the feedback justifies it. Thoughts?

Any updates on this issue? Maybe generally updates on providing some assistance when referencing modules in a private registry. Thanks.

Version/module autocompletion for private registries would enable developers to easily explore available templates. Lack of this feature makes Bicep adoption way harder.

closing this as duplicate of #3964


[New API] : Generate Joke Api Added

🎯 Title and Issue Number -  [New API] : Generate Joke Api  #262
Hello @dishamodi0910 ,

I will add the New Joke Api .

Demo
Click Here :rocket:
Closes #262

🗒 Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x]  I have gone through rules of when PR will get merged.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] I have followed proper file structure.
[x] I have gone through CONTRIBUTING GUIDELINES.md.

Thank you for contributing!❤
Don't forget to show some love by ⭐ the repository!

Hey @sivaprasath2004, Thank you for creating PR! We will review it super soon. 😇❣
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣

@dishamodi0910 ,please merge it..

Screencast from 2024-06-23 18-31-34.webm

@dishamodi0910 please check and merge it.. :rocket:

@sivaprasath2004 We're thrilled to inform you that your pull request has been successfully merged into the APIverse🚀🎁
Your hard work, dedication, and expertise have made a significant impact on our project, and we couldn't be more grateful for your contributions.😇
Your code will now be a part of our growing ecosystem, helping developers worldwide to create exceptional APIs.❣🔥
Happy Coding! ✨
Will See you soon❣

@dishamodi0910 ,please give the level3 lablel, because I'm gssoc contributor..

@dishamodi0910 ,please give the level3 lablel, because I'm gssoc contributor..


MWPW-152228: refactor georouting promises call

Refactors promises in georoutingv2
Resolves: MWPW-152228
Test URLs:
Before: https://main--milo--adobecom.hlx.page/?martech=off
After: https://mwpw-152228--milo--adobecom.hlx.page/?martech=off
QA:
Before: https://main--cc--adobecom.hlx.page/products/illustrator
After: https://main--cc--adobecom.hlx.page/products/illustrator?milolibs=mwpw-152228&martech=off

Validation done on the PR ,
Regression on geo routing popup
https://main--cc--adobecom.hlx.page/products/illustrator?milolibs=mwpw-152228

https://main--cc--adobecom.hlx.page/products/illustrator?milolibs=mwpw-152228&akamaiLocale=be


Update the main development branch to have a version of 0.0.0

Goal
The goal of this PR is to align with the https://github.com/LibertyDSNP/frequency/wiki/Release documentation
Discussion

Updated cargo toml versions to 0.0.0
Added make version v=X.X.X to make updating versions easy.

@aramikm

Is there any chance that this might match with multiline dependency version?

Hmm... Yes there is. I'll update it to only search for the 0.0.0. That would be safer.


Get_field for ACF_block and Gutenberg

Is your feature request related to a problem? Please describe.
With ACF Blocks we can easily create blocks in Gutenberg - with Timber it's even easier, but ACF is now using get_field function in two way:

for posts/users/terms it loads the data from meta - {{ post.get_field( 'example' ) }}
for blocks it loads the block data - not avaiable in Timber right now

Describe the solution you'd like
I can think of 3 ideas:

creating a global function {{ get_field( 'example' ) }}

public function add_to_twig( $twig ) {
        $twig->addFunction(new \Timber\Twig_Function('get_field', function( $field ) {
        return get_field( $field );
     } ));
return $twig;
}

and adding to constructor
add_filter('timber/twig', array( $this, 'add_to_twig' ) );

let's just use get_fields like in my example in https://github.com/timber/timber/issues/1645#issuecomment-430037660
creating a Block object so it will work just like post or term object - than we could use it like this {{ block.get_field() }}

and a very simple example:
<?php

namespace Timber;

use Timber\Core;
use Timber\CoreInterface;

class Block extends Core implements CoreInterface {

	public $PostClass = 'Timber\Block';
	public $TermClass = 'Block';

    public $block;

	public function __construct( $block ) {
        if( $block ) {
            $this->block = $block;
        }
	}

	public function __toString() {
		return $this->block_data['name'];
    }

    public function get_field( $key = '' ) {
        return self::meta( $key );
    }

	public function meta( $key ) {
        if( $key != '' && isset( $this->block['id'] ) && $this->block['id'] != '' ) {
            return get_field( $key, $this->block['id'] );
        }
    }
}

the callback:
function my_acf_bock_render_callback( $block ) {
    $context['block'] = new Timber\Block( $block );
    Timber::render( '/template-parts/block/content-testimonial.twig', $context );
}

and than in the block we can use this in twig file:
{{ block.get_field( 'testimonial' ) }}

The last solution looks more future proof. It will work at start and will be easy for other to add features.
Describe alternatives you've considered
All the alternatives are above.

Thanks for sharing this. I was just testing ACF Block and stuck with the Timber integration.
I like the implementation with Timber/Block, but for now I will settle with global get_field temporarily.
My one major problem with ACF Block is how huge the fields and labels are. Also when in Preview mode, the fields are pushed to the sidebar and it become unusable especially if I have Repeater. What do you think on this issue?

@hrsetyono you're right about the preview mode and sidebar, but on the other hand I really love that I can see how the block looks like (I'm sure that many of my client will love this feature too). I think there still a lot of work on the Gutenberg end in terms of usability and UX. ACF is just utilizing what Gutenberg has to offer.

@palmiak I noticed that I can't save any fields that are inside Metabox.
I have also tested in fresh installation with no other plugins except ACF 5.8 and Gutenberg.
I will let the author know

Thanks @palmiak for your work.
This is really exciting! I used to build something similar into the tinymce 3 years ago, with custom callbacks and timber rendering directly into the editor.
Here we go. I'm implementing this in a new and big project right now.
I want to use blocks for every single content-element in combination with acf and the preview-mode.
I will try to share the insights afterwards.

Because of the upcoming changes with get_fields and integrations I rethinked this a bit and:

first of all this should be a part of ACF Integration
second of all - the get_field method should be removed

<?php

namespace Timber;

use Timber\Core;
use Timber\CoreInterface;

class Block extends Core implements CoreInterface {

	public $PostClass = 'Timber\Block';
	public $TermClass = 'Block';

    public $block;

	public function __construct( $block ) {
        if( $block ) {
            $this->block = $block;
        }
	}

	public function __toString() {
		return $this->block_data['name'];
    }

	public function meta( $key ) {
        if( $key != '' && isset( $this->block['id'] ) && $this->block['id'] != '' ) {
            return get_field( $key, $this->block['id'] );
        }
    }
}

and the usage whould be
{{ block.meta( 'testimonial' ) }}

@gchtr what do you think about this?

@palmiak Yeah, this should probably be part of the ACF integration!
I first had the same thought about changing the name of get_field to meta. But when this is a specific integration for ACF, it would be valid to keep the name get_field. However, when «accessing custom field values» is handled through meta in Timber, it would probably be better to call it meta here as well. So I’m good with not using get_field 👍. If we have proper documentation, this won’t be a problem.
When this class is specific to ACF, should we call it ACF_Block instead of Block? But then again, when this class is added to the ACF integration, it would probably live in the Timber\Integrations\ACF namespace, which would allow for calling it Block again:
use Timber\Integrations\ACF\Block;

function my_acf_bock_render_callback( $block ) {
    $context['block'] = new Block( $block );

    Timber::render( 'block/content-testimonial.twig', $context );
}

Ok, so I'll prepare PR for this. Which branch to use as a base one?
sob., 3 lis 2018, 12:40: Lukas Gächter<EMAIL_ADDRESS>napisał(a):

@palmiak https://github.com/palmiak Yeah, this should probably be part
of the ACF integration!
I first had the same thought about changing the name of get_field to meta.
But when this is a specific integration for ACF, it would be valid to keep
the name get_field. However, when «accessing custom field values» is
handled through meta in Timber, it would probably be better to call it
meta here as well. So I’m good with not using get_field 👍. If we have
proper documentation, this won’t be a problem.
When this class is specific to ACF, should we call it ACF_Block instead
of Block? But then again, when this class is added to the ACF
integration, it would probably live in the Timber\Integrations\ACF
namespace, which would allow for calling it Block again:
use Timber\Integrations\ACF\Block;function my_acf_bock_render_callback( $block ) {    $context['block'] = new Block( $block );    Timber::render( 'block/content-testimonial.twig', $context );}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/timber/timber/issues/1818#issuecomment-435581231, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACO-OnrH_lAqqRffmBDWTKOENL_q6Jmwks5urYCogaJpZM4XiVsd
.

Just wondering if this was still active and whether it was targeting Timber v1?
We’re about to implement something on a project that would really benefit from the proposed Block class.

@joelambert maybe try https://github.com/palmiak/timber-acf-wp-blocks it a library that makes using blocks much easier

@palmiak thanks, that looks great!
We have a slightly different usecase so we’ll probably implement the above Block class in our app code in the first instance to test the implementation.

If someone wants to make a PR to implement this in Timber, or create an extension for Timber, feel free to do so.


Documentation: AWSParameterStoreConfigStore

Suggestion
Document the AWSParameterStoreConfigStore integration with all the necessary details that explain what the store is and how to use it.
Motivation

Introduces users to the ConfigStore.
Improves usability of the store by providing usage examples.
Improves the completeness of the integration package.

Context

Integration docs: https://docs.aws.amazon.com/systems-manager/latest/userguide/systems-manager-parameter-store.html
Integration SDK docs: https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/client/ssm
Example PR of a store doc contribution: #575

/assign

All yours @poorvibajpai

@RichardAkman  Sir i have written the documentation but I'm bit confused where to paste the whole data in the repo, Please help me with this one.

@poorvibajpai, please refer to PR #575 regarding where to place the files and how the documentation should look.


Preserve extended result codes in SQLiteException

Prior to 37278d1, extended result codes were preserved when throwing a
SQLiteException. This restores that behavior.
Refs #343

Thanks for the fix! Merged.


TLS support

Hi,
Sorry for opening a lame ticket instead of a pull request.
Is TLS (with client cert authentication) something that may eventually be implemented in oklog?

Sure, I'm open to it, of course.

Since there seems to be no protocol between forwarder and ingester couldn't the ingester just take connections from a local domain socket and then the transfers could be done by anything which can send lines of text to a socket.
e.g. netcat, stunnel, socat, ...
Using stunnel would provide a TLS solution.

Yep, to be explicit the communication paths are

Forwarder/Ingester — plain socket, newline separated records — use whatever you want
Ingester/Store — HTTP/1.1 for the moment — TLS applicable here
Store/Query — HTTP/1.1 for the moment — TLS applicable here

stunnel can also act as a proxy for http so it can also be used between the backend services as well.

Instead of implementing multiple solutions. Would it be possible to abstract the transport mechanism of how things talk to each other.
For example, a lot of this is just plain old TCP right now. It would be nice to have the components talk to each other different transport mechanisms based on the user requirements.
An good example is Mangos transports abstractions. That way users could add transport mechanisms as they need them.

Any transport abstraction beyond plain HTTP, especially something like ZeroMQ or mangos, would be severe overengineering at this stage of the project.

I am not saying to use mangos for a transport mechanism. I'm just referencing their implementation of different transport protocols. I agree mangos is over engineering.
It would be nice to implement the transport mechanism as an interface. It implements methods, Start, Accept, Stop,  (for example) and knows how to pass incoming and outgoing messages to the server it is running on. That abstraction would then worry about retry logic, encryption, etc.
Our systems require mutual TLS, not just TLS.

Ah, okay. I'm on board with this!

It would be nice to have a single setting to bind oklog to a certain ip (for instance, <IP_ADDRESS>) so a TLS tunnel like ghosttunnel can be put in front of it securely. Right now I think the ips are spread across api, ingest.fast, ingest.durable, ingest.bulk, and cluster.


[AVM Module Issue]: Not possible to configure static ip for private endpoints

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Bug
(Optional) Module Version
0.1.0
(Optional) Correlation Id
No response
Description
Some resources in Azure requires two NICs with a total of two private ips per private endpoints when configuring static ips. This module is currently only creating one NIC making this deployment to fail.

The code to reproduce this issue is the same as the private-endpoints example but with a static configuration (as there are no tests testing this)
Only code different than the example
ip_configurations = {
  staticIpConfig = {
    name               = "staticIpConfig"
    private_ip_address = "<IP_ADDRESS>"
  }
}

Full code
terraform {
  required_version = ">= 1.3.0"
  required_providers {
    azurerm = {
      source  = "hashicorp/azurerm"
      version = ">= 3.7.0, < 4.0.0"
    }
  }
}

provider "azurerm" {
  skip_provider_registration = true
  features {
    resource_group {
      prevent_deletion_if_contains_resources = false
    }
  }
}

# This ensures we have unique CAF compliant names for our resources.
module "naming" {
  source  = "Azure/naming/azurerm"
  version = "0.4.0"
}

# This is required for resource modules
resource "azurerm_resource_group" "this" {
  name     = module.naming.resource_group.name_unique
  location = "australiaeast"
}

# A vnet is required for the private endpoint.
resource "azurerm_virtual_network" "this" {
  name                = module.naming.virtual_network.name_unique
  location            = azurerm_resource_group.this.location
  resource_group_name = azurerm_resource_group.this.name
  address_space       = ["<IP_ADDRESS>/24"]
}

resource "azurerm_subnet" "this" {
  name                 = module.naming.subnet.name_unique
  resource_group_name  = azurerm_resource_group.this.name
  virtual_network_name = azurerm_virtual_network.this.name
  address_prefixes     = ["<IP_ADDRESS>/24"]
}

resource "azurerm_private_dns_zone" "this" {
  name                = "privatelink.azurecr.io"
  resource_group_name = azurerm_resource_group.this.name
}

# This is the module call
module "containerregistry" {
  source = "../../"
  # source             = "Azure/avm-containerregistry-registry/azurerm"
  name                          = module.naming.container_registry.name_unique
  location                      = azurerm_resource_group.this.location
  resource_group_name           = azurerm_resource_group.this.name
  public_network_access_enabled = false
  private_endpoints = {
    primary = {
      private_dns_zone_resource_ids = [azurerm_private_dns_zone.this.id]
      subnet_resource_id            = azurerm_subnet.this.id

      ip_configurations = {
        staticIpConfig = {
          name               = "staticIpConfig"
          private_ip_address = "<IP_ADDRESS>"
        }
      }
    }
  }
}

@bryansan-msft - Thanks for this submission.  We'll review and add it to the backlog.

@bryansan-msft - I believe this has been corrected in v0.3.0 and later with the addition of the standard private endpoint interface.  Can you please let me know if you're still encountering issues and we can help add anything that is missing.

As in version v0.3.1 this issue still persist.

Reviewing the code that creates the Private Endpoints, I found out that it only considers the subresource_name = "registry" in the ip_configuration block, but Azure needs a second private IP with the subresource_name = "registry_data_REGION"
As a suggestion, this code could be implemented:
variable "private_endpoints" {

...

    ip_configurations = optional(map(object({
      name               = string
      private_ip_address = string
      region = string
    })), {})
...
}

resource "azurerm_private_endpoint" "this" {
resource "azurerm_private_endpoint" "this_unmanaged_dns_zone_groups" {

...

  dynamic "ip_configuration" {
    for_each = each.value.ip_configurations

    content {
      name               = ip_configuration.value.name
      private_ip_address = ip_configuration.value.private_ip_address
      member_name        = "registry"
      subresource_name   = ip_configuration.value.region != "" ? "registry_data_${ip_configuration.value.region}" : "registry"
    }
  }

...

}


add support for tus upload-checksum header

another attempt to resolve #25
uses a boolean flag for upload_checksum as suggested by @bratao (instead of some sort of weird getattr(hashlib... nonsense)

@ifedapoolarewaju i made the changes

?

thank you very much for the work!


Syntax check error when use the plugin

IntelliJ throws an error like the screenshot below, according to the type definition, it seems vuetify should be passed in the options?

export type PluginOptions = {
  vuetify: Plugin;
  defaults?: {
    dialog?: {
      component?: VDialog['$props'];
      card?: VCard['$props'];
    };
    notify?: VSnackbar['$props'];
    bottomSheet?: VBottomSheet['$props'];
  };
};

File: cypress/test-server/src/plugins/index.ts
I tried it with app.use(Vuetify3Dialog, {vuetify, defaults: {}}).mount('#app'); in my app, it works without any error hint. But when I do the same thing in the test-server, it is still not working...

Hi! It has been fixed in last version 1.5.1 !


agent-web container erroring out

When deploying via azd up, the agent-web container does not seem to be working correctly.
After using the example and clicking 'Start Work' and error appears in the web console below:

I am facing the same issue. Can someone check this?