Introduce CarouselWithDots component, enhance responsiveness on about, job, and meetup pages, and modified follow us section in footer

Type: Feat (Feature)
Category: UI Components Refactor in Homepage
Scope: Carousel and TalkCard Components inside desktop and Mobile Design
Task: Component Refactoring and Type Definition Cleanup
Description

Introduced CarouselWithDots component for carousel navigation with dot pagination, aligning with Figma design specifications.
Implemented dot navigation functionality to ensure consistent and reusable carousel navigation across the application.
Renamed Talk component to TalkCard to accurately reflect its role as a specific card representation.
Defined Talk type in index.ts for TalkCard component, enhancing type safety and clarity within the application.

Expected

Snapshots/Videos:

Type of change

[ ] 🍕 Feature
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor

Added tests?

[ ] 🙅 No, because they aren't needed

Internationalization Support?

[ ] 🙅 No, because they aren't needed

Steps to test the feature:

Ensure the CarouselWithDots component appears correctly on pages requiring carousel navigation.
Verify dot navigation functionality by interacting with the dots to navigate through carousel items.
Check that TalkCard components display correctly with updated naming and adhere to the Talk type structure.

Snapshot of the test-cases that are passing:
As this PR involves static updates and component refactoring, there are no specific test cases to validate programmatically.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No, this PR does not introduce breaking changes. Users should update import paths to CarouselWithDots and TalkCard components if they were using the previous Talk component.

Changes Made:

Revamped job filters' mock data.
Split the job section into a distinct component.
Implemented a filter component following Figma's specifications and removed a previously present dropdown that did not align with the Figma design.
Added new types and interfaces customized for the job section.

Expected:

Snapshots/Videos:

The mobile view may appear suboptimal due to issues with the display of job cards.

Changes Made:

Modified styles using TailwindCSS in Jobcard.
Implemented CarouselWithDots for media widths less than large screens in Jobs page.
Commented out unnecessary code related to similar jobs in Jobsection; this code is needed in job description pages only.
Added a prop className to CarouselWithDots to hide the carousel on large devices and allow for further styles customization.
Uncommented a card related to learning for interviews as per Figma design in job section and commented out SignupForMeetupCard component.
Adjusted jslovers logo width from 150 to 100 to eliminate unnecessary space.

Snapshots:

The job page should now be responsive with these updates.

Changes Made:

Refactored the meetup page according to the Figma design specifications.
Introduced new types and interfaces for meetups and adjusted existing ones for job interfaces.
Updated the "Follow Us" section in the footer.
Made style modifications to the job section for consistency and improved UI/UX/ alignment.

Snapshots:

These changes enhance the visual consistency and functionality of the application, aligning it closer to design expectations .

Changes Made:

Modified styles using TailwindCSS in Jobcard.
Implemented CarouselWithDots for media widths less than large screens in Jobs page.
Commented out unnecessary code related to similar jobs in Jobsection; this code is needed in job description pages only.
Added a prop className to CarouselWithDots to hide the carousel on large devices and allow for further styles customization.
Uncommented a card related to learning for interviews as per Figma design in job section and commented out SignupForMeetupCard component.
Adjusted jslovers logo width from 150 to 100 to eliminate unnecessary space.

Snapshots:
The job page should now be responsive with these updates.

Question: Why the footer is wrapping next to job card? This is not how it should be. Is it from Figma?
Commented out unnecessary code related to similar jobs in Jobsection; this code is needed in job description pages only. Added a prop className to CarouselWithDots to hide the carousel on large devices and allow for further styles customization. - Do not comment the code. Delete the not required code.
Uncommented a card related to learning for interviews as per Figma design in job section and commented out SignupForMeetupCard component. - SignupForMeetupCard was component required to have consistency across all pages. Figma is not updated. Please undo the changes.
Adjusted jslovers logo width from 150 to 100 to eliminate unnecessary space. - I am not sure about this. Can you please point to extra space are you referring too?

In the Figma design, the job and meetup pages have separate cards, distinct from the 'SignupForMeetupCard'. I have adhered to all references from the Figma design.
I believe it's prudent to keep some code commented for now, as it might be used in another component later. If unnecessary, we can delete it at a later stage.
Currently, I am actively working on the Meetup detail page and making frequent modifications, so separating the PRs is not practical at the moment.

Implemented Issues #8, #9, and  #11  according to Figma design specifications.
Partially resolved Issue  #67 .
Currently addressing Issue  #14 .
Added social icons to the footer section, a new modification not previously present.

I appreciate your effort but would request you to work on the issues only when they are assigned to you. If someone is sitting on the issue , I try to every 2 weeks check with them and re-assign.
https://github.com/jslovers/jslovers-official-website/issues/14 : This is assigned to Ritesh
https://github.com/jslovers/jslovers-official-website/issues/67 : this is assigned to other people
https://github.com/jslovers/jslovers-official-website/issues/11 : this is assigned to someone else and PR is already there
https://github.com/jslovers/jslovers-official-website/issues/9 : This is assigned to someone else
https://github.com/jslovers/jslovers-official-website/issues/8 : This is also assigned to someone else.
I will go ahead and remove your PR from the above issues as it will confuse the current assigner.
Unfortunately, if  you cannot break the PR I won't be to accept your PR.  It is crucial to have a clean PR, and PR should have only the code/changes of the issue associated to it (1 issue -> 1 PR).
Reg commented code, GitHub can take care of history of the code. You don't need to worry about it. Always delete the code if not required.

I noticed in the pull request 79 discussion that you requested all changes be included in the same PR, so I have followed that guideline accordingly.
Regarding the issue of separating commits made for each features into separate pull request, I may encountered difficulties as some changes required updates to previously pushed code. Nevertheless, I will make my one last commit to this PR for meetup detail page then I will not make any commit to this PR.
If the individuals whom you assigned to the issues do not respond. In such a case, you can review my PR instead.
Thank you for the opportunity to contribute to your website.
Additionally, I wanted to mention that Vercel offers a bot for free PR deployment. I encountered this feature in a previous project and thought it might be beneficial for deploying the dev branch of your website. This could provide a visual representation of the code changes more easily.

79

Thank you. Reg 79 PR, dev was closing his old open PR and opening new PR everytime he wanted to push a new change/or code review comment. As a result all the PR comments were getting lost. Hence, I guided him that he can push hid code changed in the same PR (those were related to the issues he was working on).


Panel emails missing URL/Sender Name

Hello,
After experimenting with the panel I have identified a bug with email sending. Another user in Discord was able to confirm this bug is present as well.
Steps to replicate:

Cleanly install panel
Create account (sends account creation email)

Sent email will contain the following:
"If you’re having trouble clicking the "Setup Your Account" button, copy and paste the URL below into your web browser: http://localhost/auth/password/reset/0pXDOtPaVyOWmjVhADVG0o8Hjh6yf8w7?email="
It appears that APP_URL is not being applied to the generated emails, this occurs with any email sent from the panel. In addition, my installation is ignoring the "Email Sender Name:" and is using the default sending name of 'Pterodactyl Panel' instead. My mail configuration is not to blame, all variables are properly defined in the .env and I have been able to replicate this issue on 2 separate clean installs using 2 different mail methods (PHP Mail and SMTP).
Both installs were done on Ubuntu 16.04 following the instructions to the letter. Just in case it helps, here is my environment:
PHP 7.0.13-0ubuntu<IP_ADDRESS>
nginx 1.10.0-0ubuntu<IP_ADDRESS>
Mail: Tried SMTP/PHP Mail, issue is present in both.

After updating the .env file to include http:// in the APP_URL I am seeing proper URLs in emails.
However, the issue with Email Sender Name is still present. The panel seems to be ignoring the setting.

Not that it matters at this point, but I also was able to confirm this was the case.


⚠ Blutopia has degraded performance

In 794b1e6, Blutopia ($BLU) experienced degraded performance:

HTTP code: 200
Response time: 8874 ms

Resolved: Blutopia performance has improved in 60fd7f1 after 2 hours, 7 minutes.


Consider displaying proper error messages and not just status codes.

If we try to run, e.g., an empty dartpad, we get the following error:

It doesn't seem to me that this is very helpful and, in this case, it feels like DartPad is broken. I think it would be useful if the error messages that the compiler emits would be shown.

If we make the analyzer fail (crash?) with, e.g., the following program:
void main() {
  List<int> c = [var j] = [var j] = [var j] = [12];
  print(c);
  print(j);
  final a = (final f) => 33;
  final b = (final g, final ) = 55;
  final c = (final h) async => 77;
  final d = throw 99;
}

we get the following error message:

This also seems confusing to me. It doesn't give users any opportunity to understand what might have went wrong and how they can prevent that from ever happening again (such as by filing an issue).

Thanks for the report! This looks like a regression.

It's highly annoying to not get the error messages from the compiler when there is something wrong.
While the analyzer warnings and errors are often useful, I sometimes use DartPad to look for differences between the CFE and the analyzer. When the compiler just says
Error compiling to JavaScript:
compile: 400:

for every possible problem, including forgetting to write a main function (which the analyzer doesn't warn about), then it's not useful.

There are two things going on here; the front-end crash, and a regression in how we show error messages. The 2nd item is due to a recent re-write of the dart-pad backend. It should be straightforward to restore the previous behavior here.

Thank you @devoncarew for the quick fix! Compiler error messages are being shown now.

The following message is being displayed for the analysis failure due to an exception:

I think it would be helpful if users had the opportunity to report an issue instead of having to understand what "No name provided" means, but this might be a use-case not worth optimizing for? I'm not sure.

Thanks for the report! It was very detailed and timely.

but this might be a use-case not worth optimizing for? I'm not sure.

This particular issue should be very rare; this is a failure in our tools - a crash - and not normal static analysis results (i.e., you should see static analysis results for your snippet, and not a crash).

Got it. @devoncarew feel free to close this issue if you think that it has been resolved. To me it was mostly about the lack of error messages, which is fixed now.

Great; the other portions - the crash - are covered in some other issues.


What is the Design System named?

Google Form results
To-Dos

[ ] Figure out next steps. Another Google Survey? Discussion with the UX team?
[ ] Flesh out requirements that name much fulfill

[ ] Name must be available as an npm package
[ ] Name must be meaningful in the library context
[ ] Name must satisfy UX team

[ ] Update npm package names

[ ] Prefix npm package names with @nypl/

I'm going to close this out. It looks like we're going forward with nypl-ds and that's fine.


Add alternative data table cell output renderer for vscode notebook stdout

map it to application/vnd.code.notebook.stdout mime type to read data from cell outputs in all vscode notebooks.

was able to load json data from stdout in a TS notebook:

and csv data from stdout out in a notebook cell:


About some bugs and how to launch the project

Dear team,
I'm sorry to bother you but I really have some questions on how to launch the project.
The first question is that the project has numerous files & codes. As a beginner, it's rather too difficult to find which code to run.(I know the function is to merge ACM & DBLP together, but how to operate?)
Another question is that I ran into a bug after I typed the order 'sudo python3 -u setup.py install --single-version-externally-managed --record=record.txt'. The error said my system lacked module 'numpy', however it was not the truth. So, can you give me some advice on how to debug and launch the program?

Wish you a happy new year!

Hi. I'm sorry for the late reply. The whole team has been on winter break between the two semesters, and we just got back. We notice that you have opened three issues, and we will do our best to help with them.
First, may we ask which OS and Python version you are using? We will then reply and go from there. Thank you and regards, AnHai

Well，I'm so glad you replied to me! I'm using python 3.9.12 on my PC with Windows 11 and python 3.8 on my virtual machine Ubuntu20.04 Linux. What's more, I want to mention that now I can run your codes in all your ipynb of Basic EM Workflow Restaurants, but the DBLP&ACM keeps reporting errors.
I have solved Issue #157 myself, and I can share my findings with you. I found the length of decimal in "feature_vectors_dev" were > 6, which exceeded the range of float64. I modified your codes——I added feature_vectors_dev=feature_vectors_dev.round(6), but it reported KeyError: 'DataFrame information is not present in the catalog'.
However, if feature_vectors_dev=feature_vectors_dev.round(6) is not added, it will report there's NaN, Infinity, or too large numbers can't be processed as float64.
Can you give me some advice? Thank you.
徐宸
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "anhaidgroup/py_entitymatching"                                                                                @.>;
发送时间: 2023年1月18日(星期三) 上午7:41
@.>;
<EMAIL_ADDRESS>主题: Re: [anhaidgroup/py_entitymatching] About some bugs and how to launch the project (Issue #156)
Hi. I'm sorry for the late reply. The whole team has been on winter break between the two semesters, and we just got back. We notice that you have opened three issues, and we will do our best to help with them.
First, may we ask which OS and Python version you are using? We will then reply and go from there. Thank you and regards, AnHai
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Hi. Thanks for the info. We have verified that py_entitymatching can be installed in machine/software settings that you specified. We have also been able to replicate the same bug in the DBLP-ACM script that you had. We are looking into this bug and will get back to you asap. In the meantime if we have any questions, we will let you know. Thank you for your patience on this. AnHai

Hello, I am one of the py_entitymatching developers. I have identified the cause of issue #157. You can fix it by adding the argument "missing_val=numpy.nan" (no quotes) to any em.impute_table() function call in the program. impute_table() is called in cells 36, 45, and 51 in the DBLP-ACM notebook. It may appear in other jupyter notebooks as well; you will have to add this argument whenever impute_table() appears or you will get the same error. Note that you will have to import numpy before you can use numpy.nan as we do not import it in DBLP-ACM. Do not use feature_vectors_dev=feature_vectors_dev.round(), it will mess up the metadata and cause errors during catalog verification. In general, dataframes that are output from py_entitymatching functions should only be altered by other py_entitymatching functions; external function calls will not update the catalog properly and can cause errors.

OK, thank you for your advice! I have succeeded in running the DBLP notebook.
Best wishes,
Chan.

OK, thank you for your advice! I have succeeded in running the DBLP notebook.
Best wishes,
Chan.


Add option to output sharing links in an Image and Text 50/50 Group

See cfpb/design-manual#439 for background.
Additions

An option to output sharing links within an Image and Text 50/50 Group organism.

Testing

Pull down branch
./cfgov/manage.py migrate
./cfgov/manage.py runserver
Log into Wagtail admin at http://localhost:8000/admin/
Create or edit a page that can use the Image and Text 50/50 Group organism (e.g., Browse)
Create or edit an Image and Text 50/50 group
Tick the "Include sharing links?" option
Optionally enter the blurb to be shared
Save and preview

Review

@cfpb/cfgov-backends
@cfpb/cfgov-frontends
@schaferjh
@keelerr
@Dnpizarro

Screenshots

Notes

There are several ways in which this is a good first step, but doesn't match the functionality of the sharing links on the English-language Money as You Grow pages. See the todos below for more.

Todos

In a future PR, it would be nice to update the Social Media module to accept a custom label, so something like this could read "Share activities" (in English).
In a future PR, it would be nice to add the ability to create Pinterest share links, which are used [on the English version of Money as You Grow.

For super extra credit, support the uploading of custom images to be shared to Pinterest, like the ones used on the English MAYG.

In a future PR, it would be nice to have all of our headings auto-generate IDs for themselves, a la most Markdown rendering engines, so that we could share links directly to the section in question.

Checklist

[x] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[x] Code follows the standards laid out in the front end playbook
[x] Passes all existing automated tests
[x] New functions include new tests
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged
[x] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

(Will update the change log just prior to merging.)

:+1: Looks great.

Looks good from a conceptual/product owner POV. 😄


Notebook Screen cheese

open the endgame.github-issues notebook
collapsed all cells under 'preparation'
from the bottom upwards run cells and expanded cell above

the root cause was the markdown renderer related and it was already fixed. Please reopen if you are still seeing it.


[Question] Why is this returned promise uncovered?

There is not enough information here to say. What is the type of axios?


Unrecognized Content-Security-Policy directive 'This'

<meta http-equiv="Content-Security-Policy" content="This gets injected by cca">
This is displaying errors on Chrome Developer Tools.
Not sure if I have to specify them somewhere or what to do with this... I have some issues in my code happening afterwards and I have a feeling that this error could be influencing.
Can someone explain why or how to clear this error?
Unrecognized Content-Security-Policy directive 'This'.
/android_asset/www/plugins/org.chromium.bootstrap/chromeapp.html:10

Unrecognized Content-Security-Policy directive 'This'.
/android_asset/www/plugins/org.chromium.bootstrap/chromebgpage.html:9

Running on
$ cca checkenv
cca v0.5.1
Android Development: SDK configured properly.

@agrieve could you shed some light into what I'm missing?

Fixed on 0.6.0-rc1


single quotes break command prompt

Minor detail but the page shows in the working examples single quotes but my windows 10 command prompt broke, with an error that was not understandable.
I used double quotes around the the URLs and it worked.
This was specifically in regards to the file share to file share copy, not sure if it is everywhere.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cd2ee3a6-a4ae-068a-1a7e-9a81877e1a21
Version Independent ID: 57abfa84-1c27-6dcc-f757-bc3c90e6e6b0
Content: Transfer data to or from Azure Files by using AzCopy v10
Content Source: articles/storage/common/storage-use-azcopy-files.md
Service: storage
Sub-service: common
GitHub Login: @normesta
Microsoft Alias: normesta

Hi @joshuarmclean. Yes, you'll have to use double quotes for Windows command prompt and single for PowerShell. Thanks for sharing your feedback. This is a known issue and we have a note at the top of the article.  Thx!

Hello @joshuarmclean , thanks for taking time to share your valuable feedback! We are taking a look into this and will get back to you soon.

@joshuarmclean Since this has already been addressed in the documentation I will close out this issue.


GitHub can not see viewlet in the active  bar

Issue Type: Bug
when i install this extension ,there is no viewlet in the active bar,i tried to restart  vscode  still not work
Extension version: 0.6.0
VS Code version: Code 1.33.1 (51b0b28134d51361cf996d2f0a1c698247aeabd8, 2019-04-11T08:27:14.102Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz (8 x 1800)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
7.89GB (2.50GB free)

Process Argv

Screen Reader
no

VM
50%

Got the same problem. Same versions.

Me too.

Same here. With the following configuration.
Version: 1.34.0-insider (user setup)
Commit: 473af338e1bd9ad4d9853933da1cd9d5d9e07dc9
Date: 2019-05-01T00:22:05.899Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763

In the current version of the extension, there are 3 conditions that need to be met for the viewlet to show up:

a folder tracked by git has to be open
git has to be enabled
a remote has to be associated with github

Since this isn't made especially clear, I just merged a PR (https://github.com/Microsoft/vscode-pull-request-github/pull/1117) to have the viewlet just always be shown, with informational messages if one of these conditions isn't met. There may also be a timing issue on startup. We plan to release a new version of the extension on the 16th or 17th.
Can you all report what's in the output panel for GitHub Pull Request for you? You can bring up the panel with F1, View: Toggle Output, and then switch the dropdown to GitHub Pull Request.

[Info] C:\Users\maxim.ssh\config: ENOENT: no such file or directory, open 'C:\Users\maxim.ssh\config'

Here my output,

I tried to use code you provided in a different topic for adding a new remote, though I'm not really sure why the origin remote isn't being found?

except @tylerimplom , I have the same problems and configuration than all above...

Likewise, I get no viewlet:

I am signed in and the repo has branches and git is working:

In the newest version of the extension (0.7.0), the extension viewlet should now always be visible, and display some information if it is not able to render the list of pull requests. Does using the latest version of the extension resolve the issue? (Note that it requires the latest VS Code, 1.34.0)

It doesn't seem to work for me, I still get similar output in the box as before:

no...the update change ... nothing

@ElvenSpellmaker From the output, it looks like the "githubPullRequests.remotes" setting is currently set to ["origin", "me"], which aren't matching remotes in the current workspace.  Can you double check that these are correct when compared with the remote names from git remote -v? You can modify the setting by clicking "Configure remotes..." on the tree.
@Tatator01 Can you share what the output of git remote -v is? What is the message you see in the tree?

@RMacfarlane Where shall I run the command from sorry?
I have loads of remotes 🤔

@ElvenSpellmaker From the terminal in VS Code

@RMacfarlane Ahh I never use the integrated terminal (forgot there was one kinda)...

For git remote -v, result is
origin  https://github.com/Tatator01/liturgik-web.git (fetch)
origin  https://github.com/Tatator01/liturgik-web.git (push)

@ElvenSpellmaker I had similar output in the debug window. For me helped this https://github.com/microsoft/vscode-pull-request-github/issues/1142#issuecomment-498630151, maybe for you as well?

With the latest version of the extension, 0.10.0, the pull request tree should now display "Loading..." while git information is being read. This should fix a timing issue on Windows where the tree would display the wrong message. Please try it out and let me know if you still have problems with it, thanks!


Make workflow more explicit through folder re-design

To make things simpler, I was thinking we could simplify the main folders in this project to have three main parts

Configuration

Currently this is included as a pre-cursor step in 'process', but the argument for making it a stand alone folder is it would allow for project-specific sub-folders, e.g.

25-city study (ie. configuration set up to replicate what we did for the Lancet study)
1000 city templates (recommended configuration files that people can copy to new folders and modify to add new cities)
other...

These project specific folders could also optionally contain additional administrative documentation relating to specific projects
The 'docker' folder could also be potentially included in here (although perhaps that could be confusing; maybe would need projects than to be in a 'projects' sub-folder)

Process

This is the main 'process' folder that already exists, where spatial urban indicators are calculated using defined configuration

Analysis (and reporting?)

This folder exists, but could be better used and more clearly incorporate other aspects -- e.g. validation is a critical analytical step,
The global_scorecards is also designed to go in this folder, which is perhaps more about reporting than analysis, although perhaps it could be appropriate for these things to be co-located as 'analysis and reporting'?
sub-folders representing different analytical/reporting steps using the indicator data generated in the process stage could be located here
the 'maps' and 'validation' folders could be more appropriately located here also

The existing 'documentation' folder could be removed, with the contents subsumed in other readme files, to avoid duplication and make updates easier.
So this would mean we could essentially have the main project directory consist of 3 clearly-named folders with sequential relevance, the global-indicators.sh shell script, and the licence and readme markdown files.   I think this could make things less over-whelming for new-comers?
This was just a thought that occurred to me this morning, so recording it here as something to return to before I forget it.

I am going to close this issue, as broadly, the workflow is pretty clear now and incorporates the scorecards generation.


Reach browser max height pixels

Describe the bug
I'm doing some POC to check if I'll be able to render a larger list and I face some issues with the current approach you use by setting the height of the parent element to create the scrollable area. If the list size is long it could beat the max height value which is:
Firefox: 33554400px
Chrome:  33554428px

https://stackoverflow.com/questions/16637530/whats-the-maximum-pixel-value-of-css-width-and-height-properties
In that way is impossible to keep scrolling until the end of the list
Your minimal, reproducible example
https://codesandbox.io/p/sandbox/romantic-breeze-tjpnxm?embed=1&file=%2Fsrc%2Fmain.tsx%3A4%2C21
Steps to reproduce

Create a list with 1677723 items and each item should have 20px
Cannot scroll to see the last item

Expected behavior

Create a list with 1677723 items and each item should have 20px
Be able to see the last item

How often does this bug happen?
None
Screenshots or Videos
No response
Platform
macOS - Chrome
tanstack-virtual version
3.0.0-alpha.1
TypeScript version
No response
Additional context
No response
Terms & Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

@hyanmandian you got any solution for this. i am facing the same issue when rendering very large list


Research how to get Github to push changes on master to the dev server

Github Actions should provide a way to do this.

This is working with pbot-client commits 2d290e2b79221df815e93fc7c99979ee9568f2a4 and 14cc3ae4fe14c8bb957ef2032b45673214e233c2 and pbot-api commit a506c0ce3f058ebf392942f39425c15126c0b7af.
Resources used include the one mentioned above as well as the following:

It's really very cool.


feat(random_generate): Random username and mail generation for test.

PR Description
This PR introduces a feature for dynamically generating random usernames and emails to enhance test scenarios where placeholder data like {{username}} and {{email}} is used. The implementation ensures variety and uniqueness in the generated data to simulate real-world use cases effectively.

Closes #496

Checklist

[x] I have gone through the contributing guide
[x] I have updated my branch and synced it with project main branch before making this PR
[x] I am using the latest Flutter stable branch (run flutter upgrade and verify)
[x] I have run the tests (flutter test) and all tests are passing

OS on which you have developed and tested the feature?

[ ] Windows
[x] macOS
[ ] Linux

Change
https://github.com/user-attachments/assets/0c5b870b-c4f5-4712-a4cf-8ffd94fa1588

Hey @ashitaprasad, Can you please review this one ?
Suggested more change:

Writing lorem{number} should generate random text paragraph.
Generate Date and Time.
Generate Phone number.

Closing the PR as you did not discuss your approach on the issue thread.
As this is a low priority feature, it will only taken up after other high priority features are added.


formatting-utility sample in wrong directory

Formatting-utility sample is in directory winforms instead of windowsforms

@rpetrusha can you take a look at this?

Issue is still present in latest commit.

@BillWagner, Regarding this issue, can you look at this PR and my comment ? https://github.com/dotnet/samples/pull/1426#issuecomment-529100230


Shortcuts legend modal available on pressing the ? key.

Shortcuts legend modal available on pressing the ? key.
Youtube's modal:
https://user-images.githubusercontent.com/985197/64934197-bd627980-d80e-11e9-86e3-961745d0c665.png

hey there, I see that there's an assignee for this one, but does it need some work?

Hey @gangov I was planning to implement it myself, but never seemed to find a moment to finish it. You are very welcome to work on it if you are interested.

@ojeytonwilliams  thanks for the prompt reply, I'll give it a go

Awesome, I'm looking forward to seeing what you come up with.  Let us know if you need any further context/explanation.

I've set the project locally yesterday, so today I'm planning on knowing myself around afterwards I'll place my stuff. One question for now is what are the shortcuts that need to be listed? Is this topic okay for start:
https://forum.freecodecamp.org/t/free-code-camp-hotkeys/59467

That topic is quite out of date, I'm afraid. The hotkeys we use for freecodecamp.org are defined here: https://github.com/freeCodeCamp/freeCodeCamp/blob/main/client/src/templates/Challenges/components/Hotkeys.tsx


Angular 9.1.X warnings

Hi,
I'm having these two warnings with Angular 9.1.7:
WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>< 9.0.0 but none is installed
WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>< 9.0.0 but none is installed.
Is this something that could be addressed in a future (hope soon) version?
Thank you for your attention.

Please try the new version


Add liquidity section dropdown instead of tabs

https://www.figma.com/file/A0OEqjIWy6jL4Rk4kT8ddr/UX%2FUI_Workflow?node-id=3970%3A22391&t=V9GiGyfuf4aBvLkF-1

@mk26071980 could you share the Buy/Sell full set modal too? It's needed to complete this as there is only 1 one button for it


Export - Import GLB -- Error Emission

Good afternoon.
When exporting and re-importing GLB format, the emission data changes its value.

Add an object
Add material
Set the material - Emission color - RGB (1.0,1.0,1.0)
Strength emission - 0.5
GLB export (without animation)
Import the exported file
Emission color - RGB (0.5,0.5,0.5)
Strength emission - 1.0

Expected Behavior:
Emission:
color - RGB (1.0,1.0,1.0)
strength - 0.5
OS: Linux Manjaro
Blender version - 3.6.5 / 4.0.2
test_glb.zip
https://github.com/KhronosGroup/glTF-Blender-IO/assets/43431061/fad06def-68c2-4887-ba7c-49eeabd97d81

I can confirm this behavior, but I don't think this is a bug.
glTF core specification has no color + Strength data for emission values, only color.
So data are converted from Blender to fit glTF specification.
For Strength > 1.0, there is a glTF extension to handle it, but not sure we have to use it for strength <= 1.0
Do you have any issue with this behavior ?

More than a month without any answer.
Closing this ticket


Restructure the docs reference section

This change is

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 4 committers have signed the CLA.:white_check_mark: danielmai:white_check_mark: MichaelJCompton:white_check_mark: pawanrawal:x: arijitADYou have signed the CLA already but the status is still pending? Let us recheck it.


Add clairifcation System.Drawing.EnableUnixSupport

For context, see this conversation on Twitter

Closes https://github.com/dotnet/docs/issues/25755


Add Unisound to who-is-using doc

Add Unisound to who-is-using doc.

/ok-to-test
/lgtm

I signed it

@hex108 I have signed cla, but not work.

@hex108 I have signed cla, but not work.

Could you check the FAQ in https://identity.linuxfoundation.org/projects/cncf?

/lgtm
/approve

I signed it

I signed it


Adding support for OpenStack configuration

Added two roles one for the controllers and one for compute.
Will copy the ScaleIO specific files to the appropriate locations.
Will configure cinder and nova.

Looks good, code review :+1:


App crashes after npm install

Bug

Environment info

React native info output:
System:
    OS: Windows 10
    CPU: (4) x64 Intel(R) Core(TM) i7-6500U CPU @ 2.50GHz
    Memory: 5.84 GB / 15.89 GB
  Binaries:
    Node: 13.1.0 - C:\Program Files\nodejs\node.EXE
    npm: 6.12.1 - C:\Program Files\nodejs\npm.CMD
  SDKs:
    Android SDK:
      API Levels: 23, 24, 25, 26, 27, 28, 29
      Build Tools: 24.0.3, 25.0.0, 25.0.1, 25.0.2, 26.0.1, 27.0.3, 28.0.1, 28.0.3, 29.0.0, 29.0.2
      System Images: android-24 | Google APIs Intel x86 Atom, android-25 | Google APIs Intel x86 Atom
  IDEs:
    Android Studio: Version  <IP_ADDRESS> AI-191.8<IP_ADDRESS>10548
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: 0.61.4 => 0.61.4

Library version: 5.4.0
Steps To Reproduce

Run npm install package
Run react-native run-android
...

Describe what you expected to happen:

Application open normally.

Reproducible sample code

Can't see why your issue is related to this package.
Also no information about the error, etc.

But the error occour after install react-native-device-info. On run react-native run-android the app crashes.

what did logcat say about the crash?
can you reproduce with the example app?
If you were troubleshooting, in other words, would you have the information you needed to help?

I try view logcat and show only this:
--------- beginning of crash
--------- beginning of system
--------- beginning of main
01-09 12:15:51.352 16651 16651 D ReactNative: ReactInstanceManager.ctor()

no stack trace is suspicious. likely a filtered logcat instead of raw (like just running adb logcat from the terminal)
I want to be clear though: this project is used by hundreds of thousands of people. I use it personally (not just maintain it). And it works. You have a project-related problem, there is not a problem with the module. We're attempting to help you troubleshoot it here, but you'll have to be resourceful with your use of debugging tools, and with comparing to the example etc to find where in your project the integration went wrong.

posting a reproducible example via a fresh github repo might help as well, but I'd start with trying the example project here first to show it works

Of course, I understand.  if I upload the whole project here can this help?  I'm new to ReactNative, so I don't know how to use all the tools.

I would go for a minimal example. The thing is, this module already sort of includes one - and in a way that if you clone this module and run this script https://github.com/react-native-community/react-native-device-info/blob/master/refresh-example.sh it actually rebuilds the whole thing from scratch anyway - and it runs? So I'd really start with trying that sort of thing - just creating a sample app from the built-in react-native template and doing a test integration of react-native-device-info before going further
It should work
Then you'll have something to compare with your project to see what the differences are

Ok, I will try.

I created a new project and re-installed the package. Now the application no longer crashes, but now when I run and paste import it gives the message "undefined Unable to solve module 'react-native-device-info.'"

I created a new project and re-installed the package. Now the application no longer crashes, but now when I run and paste import it gives the message "Error: @react-native-community/react-native-device-info: NativeModule.RNDDeviceInfo is null."

@diegoaraujolima I am sorry but I can't help developers troubleshoot their own integration issues. The example works, and you should study it to see how so that your project can work.
Honestly I'm not sure how that even works as the dependency should not have the react-native-community in the name
yarn add react-native-device-info is it

Hello, I discovered the error. The problem happened when I tried to install the react-native-navigation library. After her installation no package worked anymore. The point is that I did all the procedures to install it correctly. However this is no longer your problem anymore. Anyway thank you for your help.


Define system actors

Like #40, ADRs often need to refer to other systems.  This needs to be done without referencing names of Red Hat interna; systems.  We need to establish a common vocabulary and have a mechanism for extending vocabulary as we need to talk about additional systenms.

With the work of #40, I think this is closeable.


[ENH] Conditional join column selection

PR Description
Please describe the changes proposed in the pull request:

Allow column selection/renaming within the function
Join on multi index possible, as long as both frames have the same number of column levels

This PR relates to #1102.

PR Checklist

Please ensure that you have done the following:

[ ] PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.

[x] If you're not on the contributors list, add yourself to AUTHORS.md.

[x] Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.

Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks
There will be automatic checks run on the PR. These include:

Building a preview of the docs on Netlify
Automatically linting the code
Making sure the code is documented
Making sure that all tests are passed
Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@ericmjl

🚀 Deployed on https://deploy-preview-1104--pyjanitor.netlify.app

I'm merging!


VScode F2 rename symbol feature for keys

I'm going to make a huge refactoring in my project for renaming dictionary keys. And I thought it will be easy with a refactoring feature in VSCode, but that feature doesn't work correctly for a such case. Let's say I want to rename the key in the dictionary object from "a" to "d", I click f2 (rename refactor feature) and expect that everywhere where the key "a" was used in the translation function will be renamed, but it doesn't happen, "a" key is to keep staying and I've got only typescript error "Argument of type '"a"' is not assignable to parameter of type '"d" | "b" | "c"'"
By the way, I tried the same feature in WebStorm and it works there properly. So for only this task I used the webstorm, and closed my issue, but it will be better if we have the same feature in VSCode available.
This is a small example of dictionary structure and translate function, for getting an idea and playing in your VSCode. Just try to rename any key in the dictionary object with (F2 rename symbol feature) in typescript file
const dictionary = {
  a: 1,
  b: 2,
  c: 3,
};

type Keys = keyof typeof dictionary;

function translate(key: Keys, dict: typeof dictionary) {
  return dict[key];
}

translate("a", dictionary);

You will have a better experience in this repository if you follow the issue templates for bug reports or feature requests.

To expedite the triage process, we need everyone to follow the issue template and instructions.
When you clicked "Create New Issue", the issue form was pre-populated with a template and some instructions. We need you to read those instructions completely, follow them, and then fill in all the fields in that template.
We are not able to assist with issues that don't follow the template instructions as they represent a significantly larger amount of work compared to issues which are correctly specified. Thank you for understanding.


[HDInsight] Support Relayoutbound feature and returning ClusterId

Remove previous NetworkSettings: related swagger spec PR https://github.com/Azure/azure-rest-api-specs/pull/10793
Add NetworkProperties and ClusterId : related swagger spec PR https://github.com/Azure/azure-rest-api-specs/pull/11134

Could you please help review this PR? Thanks in advance

Could you:

update versions in AssemblyInfo.cs
update the API tags in Az.Sdk.props if there is an API-version update

Could you:

update versions in AssemblyInfo.cs
update the API tags in Az.Sdk.props if there is an API-version update

Hi @YalinLi0312  I have updated the assembly info. Thanks for your review.


handle blobs as fields

I think this handles the issue with blob uploads correctly:
It doesnt matter we have set a filename or not. We just check if the content is an octet stream. If so we treat it as a file. If not, we treat it as a field.
Also according to the Spec, a filename is not mandatory.
https://datatracker.ietf.org/doc/html/rfc7578#section-4.2
   For form data that represents the content of a file, a name for the
   file SHOULD be supplied as well, by using a "filename" parameter of
   the Content-Disposition header field.  The file name isn't mandatory
   for cases where the file name isn't available or is meaningless or
   private; this might result, for example, when selection or drag-and-
   drop is used or when the form data content is streamed directly from
   a device.

So the check if filename was not undefined was already non spec conform.
You could also create a Blob with mimetype application/octet-stream and upload it, and because we would maybe check for filename,e.g. 'blob' we would not handle the blob correctly. Blob only means, that we have the data in-memory of the browser. For the server it should be actually not be important if an upload was made with a blob or not. It should only look if it is octet-stream or not.

Checklist

[x] run npm run test and npm run benchmark
[x] tests and/or benchmarks are included
[x] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

It is the problem is multipart/form-data spec, as it didn't state clearly how to distinguish a field and file.
It is rare but it can

a file without filename
a field having a filename

It would say it is better to make those decide by the consumer to decide what they need.
e.g. multiple flags, or function to determine what they means to be a file.
It is important because we do not know the client they use and the requirement of their server.
I am happy if both option exist.
the flags pass to the default function to determine the file and field.
If they want more, then pass an function to modify it.

According to the spec:
https://datatracker.ietf.org/doc/html/rfc7578#section-4.4
   Each part MAY have an (optional) "Content-Type" header field, which
   defaults to "text/plain".  If the contents of a file are to be sent,
   the file data SHOULD be labeled with an appropriate media type, if
   known, or "application/octet-stream".

So it seams, that we must handle all content types which are not text/plain as files?!

@cyantree See how busboy is currently used: https://github.com/fastify/fastify-multipart/blob/master/index.js
From my understanding, it is created once per request and then discarded. Multer does same thing: https://github.com/expressjs/multer/blob/master/lib/make-middleware.js
So I think that having a config option on Busboy instance, which would be responsible for deciding what is field and what is file is a valid approach. It should fall upon higher-level library (such as multer or fastify-multipart) to pass correct configuration per-route.

Actually if no mimetype is set it should be text/plain.
https://datatracker.ietf.org/doc/html/rfc7578#section-4.6
How about a simple regex or function for content type?
Default is: everything is a file except text/plain and no content type means text/plain?
That is imho closes to the rfc

@kibertoad You're absolutely right, sorry for mixing up these two packages. :)
Yes, busboy should only provide handling of parts and fastify-multipart should do the connection and configuration for specific routes.

@Uzlopak What if I send a text/plain file as a file? How should that be handled?

@Uzlopak
I've created a simple HTML form with file upload, text input and textarea input.
The following data will be sent when uploading a .txt file:
------WebKitFormBoundaryhtgx6m6izaBBUPXY
Content-Disposition: form-data; name="x"; filename="opencv-install-tipps.txt"
Content-Type: text/plain

sudo apt install make g++
PKG_CONFIG_OPENCV4=1 yarn add opencv

sudo apt install ca-certificates
------WebKitFormBoundaryhtgx6m6izaBBUPXY
Content-Disposition: form-data; name="txt"

hallo welt
------WebKitFormBoundaryhtgx6m6izaBBUPXY
Content-Disposition: form-data; name="txt2"

bac
------WebKitFormBoundaryhtgx6m6izaBBUPXY--

What I take from this:

File upload and text fields differ in filename and Content-Type.
As discussed earlier filename shouldn't be seen as safe marker to identifying file uploads.
Content-Type is also no safe marker as the original issue regards parsing JSON parsing of fields. Therefore in this case it's not possible to know whether a specific part is a file upload (e. g. for storing on the server) or a metadata object (e. g. for further validation)
In general Content-Type only tells what a content it but now what it's purpose is.

Then it is actually non conform to the spec imho.
Ok, different approach:
We supply per config a function which gets the values of content type, fieldname and filename. Depending on this everybody can determine if it is a file or a field.
In higher levels like fastify you have already schemas. So you could reuse them to configure busboy accordingly

We supply per config a function which gets the values of content type, fieldname and filename. Depending on this everybody can determine if it is a file or a field.
In higher levels like fastify you have already schemas. So you could reuse them to configure busboy accordingly

Yes, that would be fine for me. And when not supplying the function everything gets handled as a file.
Btw: Maybe let's check how other languages do it. I know that PHP also handles files seperately. So they must also use some aspect to mark something as a file, presumable Content-Type and/or filename.

Why should everything be by default a file? I kind of prefer the other way round

I've made some tests with PHP:
body.append('json', new Blob(['{"foo":"bar"}'], {type: 'application/json'}), '');
results in error 4 in PHP (UPLOAD_ERR_NO_FILE). So in this case the whole field gets dropped.
body.append('json', new Blob(['{"foo":"bar"}']));
body.append('json', new Blob(['{"foo":"bar"}'], {type: 'application/json'}));
body.append('json', new Blob(['{"foo":"bar"}'], {type: 'application/json'}), 'test.json');

all these three result in file uploads.
So I couldn't manage adding a blob as a field.

Why should everything be by default a file? I kind of prefer the other way round

I think this is how busboy used to work, and what users are going to expect. Experiment done by @cyantree seems to confirm that this is actually a norm.

Why should everything be by default a file? I kind of prefer the other way round

Because without any configuration every field would be loaded into memory which could easily lead to memory and performance issues.

The whole thing is quite confusing and I'm asking myself if this gets out of hand.
Sorry for swaying back and forth, I'm only trying to get a grip on the whole topic.
So maybe let's take a step back and start over:
Finding a sensible default for separating fields from files should be managable and maybe the status quo (before our PRs), already is it. If other languages have a solid way in handling parts, why should this library need some customization options for this?
So maybe the current version of busboy is already good enough and the original issue should be addressed in fastify-multipart? Maybe there the solution is configuring which field (without Content-Type application/json) should be handled as json.

So maybe the current version of busboy is already good enough and the original issue should be addressed in fastify-multipart?
Does busboy currently expose enough configuration for that to be feasible, though?

I pushed my proposal. You could supply a isPartAFile as option to busboy. I chose the old behaviour of busboy as fallback if no isPartAFile is supplied as option.
Now everybody can write his own function based on fieldName, contentType and fileName if it is a file or a field.

I pushed my proposal. You could supply a isPartAFile as option to busboy. I chose the old behaviour of busboy as fallback if no isPartAFile is supplied as option.
Now everybody can write his own function based on fieldName, contentType and fileName if it is a file or a field.

So maybe the current version of busboy is already good enough and the original issue should be addressed in fastify-multipart?
Does busboy currently expose enough configuration for that to be feasible, though?

Yes, I think so. busboy emits the following events:
boy.emit('file', fieldname, file, filename, encoding, contype)
boy.emit('field', fieldname, buffer, false, truncated, encoding, contype)

They contain pretty much everything.
fastify-multipart already contains a onFile() config that will be called for every file part. So a onField() config might be used for parsing the json data safely when necessary.

I pushed my proposal. You could supply a isPartAFile as option to busboy. I chose the old behaviour of busboy as fallback if no isPartAFile is supplied as option.
Now everybody can write his own function based on fieldName, contentType and fileName if it is a file or a field.

Thanks. Yes, that should do the trick, if exposed by fastify-multipart. Then one could write a filter function specifying which parts should be treated as field and therefore might be parsed as json and handled by the integrated validation.

@cyantree
Currently busboy decides what a field is and what a file. So fastify-multipart can not hook into it and say, "hey busboy, you are wrong, this is actually a file/field". But with a isPartAFile you could tell busboy what actually a file is and what a field is and then consume the right event for each part.
@kibertoad
I think with isPartAFile, we would have a necessary minimal change, which gives the power to the userland to configure busboy accordingly and with the default fallback it would be non-breaking. So are busboy would be still a valid drop-in-replacement for legacy busboy.
If you agree with me, I would add the necessary changes to typings and documentation.
Maybe isPartAFile is not the best name? but it is quite descriptive :)

@Uzlopak Yes, I think this is the exactly right solution. Just wonder if we should default to empty filename as file or field.

@kibertoad
@cyantree
added documentation. anything missing?

LGTM.
@cyantree What do you think?

Done

Thanks @Uzlopak and @kibertoad for your work and time. 👍

Thank you for for bearing with us through all of this :D.
and also for inspiring this whole commotion in the first place!

It was quite a ride and it was good that we worked together to get the best solution possible :)
I really love this hands-on mentality

@Uzlopak I'll work on benchmarks now. Then we can hopefully land all outstanding PRs and publish 1.0.0 :)


Click to edit the circle or polygon generated according to the data, but the API cannot be triggered.

Click to edit the circle or polygon generated according to the data, but the API cannot be triggered. Only the graphics drawn by the tool can trigger the API. How can I solve this problem

When do you load your data from the API?
The events are triggered by all layers that are created (with the controls but also without the controls) after L.PM is initialized.
So add your data from the API after L.PM is initialized / you see the controls.
If this is not working, please create a jsfiddle and share your code with us.


Error 409: --- begin server output --- Another transaction by user aodi2004 is already in progress for app: s~aodi2004, version: 1. That user can undo the transaction with "appcfg rollback". --- end server output ---

aodi2004@aodi2004:~/KeUploader$ sh update.sh
KindleEar uploader v1.3.1 (2015-08-20) by cdhigh
Your custom info :
app id : aodi2004
email<EMAIL_ADDRESS>timezone : 8
Correct? (y/n) : y
08:27 PM Host: appengine.google.com
08:27 PM Application: aodi2004; version: 2
08:27 PM Starting update of app: aodi2004, version: 2
08:27 PM Getting current resource limits.
08:27 PM Scanning files on local disk.
08:27 PM Cloning 15 static files.
08:27 PM Cloning 390 application files.
08:27 PM Compilation starting.
08:27 PM Compilation completed.
08:27 PM Starting deployment.
08:27 PM Checking if deployment succeeded.
08:27 PM Deployment successful.
08:27 PM Checking if updated app version is serving.
08:27 PM Completed update of app: aodi2004, version: 2
08:27 PM Application: aodi2004; module: worker; version: 1
08:27 PM Starting update of app: aodi2004, module: worker, version: 1
08:27 PM Getting current resource limits.
08:27 PM Scanning files on local disk.
Error 409: --- begin server output ---
Another transaction by user aodi2004 is already in progress for app: s~aodi2004, version: 1. That user can undo the transaction with "appcfg rollback".
--- end server output ---
这是什么问题啊？

执行python appcfg.py rollback kindleear/
等回滚后即可正常重新部署。


Implement "paint bucket" style object fill [14]

Using a selected color, a user can click in the void between any overlapping lines or closed paths to create a new filled shape.

Will need to test various shapes
Shapes that have breaks/are open to the main griddle will refuse to fill.

2 ways to fill an object. the snake method would give a cleaner more accurate result. once we work out the optimal thickness of the line we can easily fill within the parameters so the lines match up and slightly overlap to seal it in. Anyway just some food for thought

Pancake.. food for thought... :laughing:
Snake is certainly doable, just make the line based on the outside tangent and connect the ends. Will need some real world testing to see which works better.

For sure. It is all about testing!

All this week I've been working hard to find a way to will using the given mathematical boolean operations on paths.. and it seems like they're just not made for non-filled/closed paths.
On the Wikipedia page for flood fill, they actually list the open source vector editor Inkscape as one that does a vector fill. I checked and it does indeed have a vector flood fill, but I believe they're definitely cheating. A flood fill of a circle does not result in a perfectly circular filled path, but.. a slightly lumpy uneven one that still does a fine job of filling it. Reading the documentation on the feature, it's purely a perceptual thing, meaning that it looks at what matches and what doesn't and converts the pixels to a vector when it's done!
If we were to use a similar method, we would get around solving the very complex math required for the boolean method, and we'll get paths that are probably more than adequate for pancake fills, if not perfectly matching the lines.
Of course the work still has to be done to convert what we have to raster, finding the closed area, run a flood fill algorithm on it, convert that to boundary points, reorder those points via distance, then convert that to a shape, then simplify that. Sheesh! And that's not even fully accounting for internal filled path occlusion. Oh well, I have my work cut out for me :)

Ok, looks like it's time! First, the results:

How it works:
I've implemented basically exactly what I mentioned above:
0. On click: a 1bit raster map of all non-transparent pixels is created of the entire working layer. This is limited to the actual layer contents, so there's less work to be done the smaller the line area is (and conversely, there's more work to be done for an entirely filled canvas)
0. Once the matrix is converted for area map -> raster x/y coordinate, we can run a flood fill algorithm based around that coordinate, on the raster map from step 1. I happened to find a good third party n-dimensional fill that has built in support for boundary detection!
0. With that awesome boundary detection, we simply save each pixel mapped point into a big array of boundary locations. This is totally out of order of course.
0. During flood fill, if the fill boundary reaches the edge of the layer boundary, we've reached the edge and this means the fill shape is open, therefore the entire fill is cancelled.
0. If we know we're good, we take our mixed up boundary points and using the "first" point as a start, walk through every other point and match it to the next closest one. We know this will generally work because the boundary paths are regular and can only be a maximum of 2pixel diagonal, or relative 5units away from each other.
0. If there are any boundary points farther than this away from each other in the next matching iteration, we know that it must be an island! (An island is any closed path within another path). This is then added to a secondary N group.
0. All final ordered paths are added to a compound path (internal islands are by default removed from having fill). As this is super blocky (having originated from a relatively low resolution pixel map), we then run the simplify algorithm on it, removing ~60-70% of the excess nodes. Higher values of simplification were attempted, but commonly change the shape too much.
0. At this point we're basically complete. The compound path is marked as being a fill, and is passed on to the higher level function to be assigned a color. This allows the function to simply pass already filled shapes directly to have their colors reassigned if clicked again.
Pros/Cons:

It's reasonably fast. With only noticeable lag/slowdowns on very large fills
It's a little wiggly. Near the edges the path does not perfectly match. This really doesn't look all that bad and almost reminds me of pancake batter. As I've said before, it very likely more than good enough.
It doesn't matter how complex the shapes are. This is a HUGE plus as it means basically any crazy shape or path as long as it looks visually correct, is going to be able to be filled in a way that makes sense.
Where you click matters. Because I'm using the "first" point of the boundary list, that's based on the flood fill for a given area. The same shape will always yield the same boundary point list, but in a different order. This apparently results in triangle cutouts for certain shapes, given certain starting points. I have not worked out exactly what these are or the best way to reproduce. Testing is likely needed, and I'll have to work out a better starting point.

Areas of improvement:

The wiggly path bits can technically have their points snap to the closest path point to them... though that's possibly an extra two days of work for likely very little gain. And this may cause big issues with single path islands collapsing :/
Only if the boundary point order issue triangle is confirmed a recurring issue, I can attempt to fix.

I did a little digging and found a few more instances of the triangle crossover, turns out it's partially the island grouping threshold to blame, so I doubled it and it seems to be quite happy. I think I'm going to leave this issue be, and the next build with this will be to the m4 wrap issue.


[IntelliJ Plugin] Add ballerina module creation support

Purpose
This PR adds menu item to create ballerina modules in IntelliJ IDEA. This menu item only appears for the ballerina project root directory and src directory.
In addition, now the plugin also gives warning when user is trying to create src level bal files.
Fixes #17751,  #17816.
Samples
Please refer the following usages.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[x] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #17964 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #17964   +/-   ##
=======================================
  Coverage   15.17%   15.17%
=======================================
  Files          46       46
  Lines        1206     1206
  Branches      188      188
=======================================
  Hits          183      183
  Misses       1009     1009
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc832ad...d1028b7. Read the comment docs.


The default is_cpu_op value causes the COMM node to be skipped by the Workload layer.

I converted ASTRA-sim 1.0 text input files Resnet50_DataParallel.txt into Chakra traces. However, I observed that the COMM node was skipped by the workload layer of ASTRA-sim. This means that ASTRA-sim only output the time consumed by computation, without considering communication.
This issue was caused by the text converter not setting the is_cpu_op attribute of the COMM node to false. The default value of true causes the workload to skip the node, leading to the anomaly as shown in the following code (Workload.cc):
else if (
        node->is_cpu_op() ||
        (!node->is_cpu_op() && node->type() == ChakraNodeType::COMP_NODE)) {
      if ((node->runtime() == 0) && (node->num_ops() == 0)) {
        skip_invalid(node);
      }

@JoongunPark do you know anyone supporting text converter?

@zbceric  if you post a PR we can review / accept. Thanks!

Sorry for late notice the tag. The problem stems from default value (true) for is_cpu_op.
The above PR will solve the problem.


UseSelection and extending a object thows DbException

If I extend an entity with following property public bool SomeProp => true will try to resolve this property from the database.
Workaround public bool SomeProp() => true

From how I understand the selection middleware works, if a query were to include the SomeProp property, an expression will be created equivalent to data.Records.Select(r => new Record() { SomeProp = r.SomeProp }).  Given this, I am assuming the exception occurs because an expression is attempting to be used which is trying to set a read only property.  If you were to change public bool SomeProp => true to public bool SomeProp {get;set;} => true, does the exception still occur?  If it does not still occur, then perhaps the fix is to filter out read only properties in the selection middleware.
This does bring up another potential issue of where a read only property references other database mapped properties.  In code, if you wanted to use the aggregate property, you would simply include the other properties in the query so they can be aggregated into the other property.  Not sure how this could be done by HotChocoloate itself, except possibly by adding some configuration, either in code or in attributes, to state that specific properties depend on other properties being present.

@TheJayMann  you are absolutely right. The problem in this specific case is that the property is on a type-extension. And UseSelection does not compare the declaring type yet. It just checks for is PropertyInfo

This does bring up another potential issue of where a read only property references other database mapped properties.

This is also a limitation of the current implementation
Include would be EF specific unfortunately. Also.. Nested includes and selections are again difficult in that case

My way of having solved this is to have a set of data classes which are used by the query provider and mapped to the underlying data source, a set of DTO classes which mapped to the graphql query schema, and a linq query which maps from the data classes to the DTO classes.  This also eliminates the need for Include() method calls and the issue of selecting a property which is the aggregate of other properties.  I've noticed that EF Core (the only query provider I have tested) does a very good job of interpreting two levels of projections, even when one of the layers is of a type which is not mapped to the database.  Other query providers may or may not be able to handle the complicated queries generated by this method, but I did see a project which might help for query providers which don't work well: https://thorium.github.io/Linq.Expression.Optimizer/index.html.  It should simplify more complex queries, and might be able to help with other providers, though I haven't yet tested this.

@TheJayMann
Do you have an example for this?

My way of having solved this is to have a set of data classes which are used by the query provider and mapped to the underlying data source, a set of DTO classes which mapped to the graphql query schema, and a linq query which maps from the data classes to the DTO classes.

A very quick sample:
// Entity Framework Core data model class, represents a People table in the database
[Table("People")]
public class Person {
    [Key]
    public int PersonId { get; set; }
    public string FirstName { get; set; }
    public string LastName { get; set; }
}

// GraphQL model, representing data returned from the profiles query
public class Profile {
    public int ProfileId { get; set; }
    public string FirstName { get; set; }
    public string LastName { get; set; }
    public string FullName { get; set; }
}

// GraphQL model representing the root query type
public class Query {
    public IQueryable<Profile> GetProfiles([Service] ProfileContext profileContext) =>
        profileContext.People.Select(p => new Profile() {
            ProfileId = p.PersonId,
            FirstName = p.FirstName,
            LastName = p.LastName,
            FullName = $"{p.FirstName} {p.LastName}",
        })
    ;
}

If you query this while only selecting the fullName field, the query will still select both the FirstName and LastName columns of the People table, as the FullName property is set in the initializer by referencing the FirstName and LastName properties of the Person class.  Also, the PersonId  column is not selected, as the second select query made by the selection middleware is not selecting any properties which were initialized by it.
This also works when using navigation properties to perform joins.  Only one extra class is needed to be added to the profile class to create add a list of addresses, but the database has at least four different tables, each of which need to have its own separate Entity Framework class representing it.  Using this mapping process eliminates significant needless complications on the GraphQL surface.  In this case, the joins only get performed if you are actually query the addresses collection field.

@TheJayMann  Very cool! Thank you for the example!
EF must really have a good provider then :D
I can imagine MongoDB blowing up

EF Core has a really good provider.  EF6 does not.  I have a feeling this will not work at all in EF6.  One of the reasons I had switched from EF6 to EF Core is that you could not create a new object in a select expression if the class being instantiated was not a registered entity type.

This issue is resolved with HotChocolate.Data
You can also ignore members from the projection with
[IsProjected(false)]


🐛  Frame Processor threw an error: frame.drawRect is not a function (it is undefined)

What's happening?
Frame Processor threw an error: frame.drawRect is not a function (it is undefined)
Reproduceable Code
const frameProcessor = useFrameProcessor((frame) => {
    'worklet'
    // console.log(`${frame.timestamp}: ${frame.width}x${frame.height} ${frame.pixelFormat} Frame (${frame.orientation})`)

    //
    // console.log('pluginLite', JSON.stringify(pluginLite))
    if (!pluginLite) return
    // if (pluginLite?.state !== "loaded") return
    const data = frame.toArrayBuffer()
    const outputs = pluginLite?.runSync?.([data])
    // console.log('outputs', outputs)
    const detection_boxes = outputs[0]
    const detection_classes = outputs[1]
    const detection_scores = outputs[2]
    const num_detections = outputs[3]

    const frameWidth = frame.width;
    const frameHeight = frame.height;
    // console.log(`Detected ${detection_boxes.length} objects!`)

    for (let i = 0; i < detection_boxes.length; i += 4) {
      const confidence = detection_scores[i / 4]

      if (confidence > 0.1) {
        // Draw a red box around the object!
        const left = detection_boxes[i]
        const top = detection_boxes[i + 1]
        const right = detection_boxes[i + 2]
        const bottom = detection_boxes[i + 3];
        // console.log('left, top, right, bottom',left, top, right, bottom)
        // Skia.Path.Make()
        console.log('Skia', Skia)
        console.log('Skia', SkRect)
        // const rectDraw = rect(left, top, right, bottom)
        // frame.drawRect(rectDraw, '#e09999')
        const rect = Skia.XYWHRect(0, 0, frameWidth, frameHeight);
        frame.drawRect(rect, fillPaint);
      }
    }

  }, [pluginLite])

Relevant log output
ℹ [08:10:30.799Z][Console] Skia undefined
ℹ [08:10:30.800Z][Console] frame {"width":1080,"height":1920,"bytesPerRow":1636,"planesCount":2,"orientation":"landscape-right","isMirrored":false,"timestamp":99758977.808625,"pixelFormat":"yuv","isValid":true}
✖ [08:10:30.800Z][Console] Frame Processor threw an error: frame.drawRect is not a function (it is undefined)
ℹ [08:10:30.822Z][Console] Skia {"AnimatedImage": {"MakeAnimatedImageFromEncoded": [Function MakeAnimatedImageFromEncoded]}, "Color": [Function Color], "ColorFilter": {"MakeBlend": [Function MakeBlend], "MakeCompose": [Function MakeCompose], "MakeLerp": [Function MakeLerp], "MakeLinearToSRGBGamma": [Function MakeLinearToSRGBGamma], "MakeLumaColorFilter": [Function MakeLumaColorFilter], "MakeMatrix": [Function MakeMatrix], "MakeSRGBToLinearGamma": [Function MakeSRGBToLinearGamma]}, "ContourMeasureIter": [Function ContourMeasureIter], "Data": {"fromBase64": [Function fromBase64], "fromBytes": [Function fromBytes], "fromURI": [Function fromURI]}, "Font": [Function Font], "FontMgr": {"System": [Function System]}, "Image": {"MakeImage": [Function MakeImage], "MakeImageFromEncoded": [Function MakeImageFromEncoded], "MakeImageFromViewTag": [Function MakeImageFromViewTag]}, "ImageFilter": {"MakeBlend": [Function MakeBlend], "MakeBlur": [Function MakeBlur], "MakeColorFilter": [Function MakeColorFilter], "MakeCompose": [Function MakeCompose], "MakeDilate": [Function MakeDilate], "MakeDisplacementMap": [Function MakeDisplacementMap], "MakeDropShadow": [Function MakeDropShadow], "MakeDropShadowOnly": [Function MakeDropShadowOnly], "MakeErode": [Function MakeErode], "MakeOffset": [Function MakeOffset], "MakeRuntimeShader": [Function MakeRuntimeShader], "MakeShader": [Function MakeShader]}, "MakeVertices": [Function MakeVertices], "MaskFilter": {"MakeBlur": [Function MakeBlur]}, "Matrix": [Function Matrix], "Paint": [Function Paint], "Path": {"Make": [Function Make], "MakeFromCmds": [Function MakeFromCmds], "MakeFromOp": [Function MakeFromOp], "MakeFromSVGString": [Function MakeFromSVGString], "MakeFromText": [Function MakeFromText]}, "PathEffect": {"MakeCompose": [Function MakeCompose], "MakeCorner": [Function MakeCorner], "MakeDash": [Function MakeDash], "MakeDiscrete": [Function MakeDiscrete], "MakeLine2D": [Function MakeLine2D], "MakePath1D": [Function MakePath1D], "MakePath2D": [Function MakePath2D], "MakeSum": [Function MakeSum]}, "Picture": {"MakePicture": [Function MakePicture]}, "PictureRecorder": [Function PictureRecorder], "Point": [Function Point], "RRectXY": [Function RRectXY], "RSXform": [Function RSXform], "RuntimeEffect": {"Make": [Function Make]}, "RuntimeShaderBuilder": [Function RuntimeShaderBuilder], "SVG": {"MakeFromData": [Function MakeFromData], "MakeFromString": [Function MakeFromString]}, "Shader": {"MakeBlend": [Function MakeBlend], "MakeColor": [Function MakeColor], "MakeFractalNoise": [Function MakeFractalNoise], "MakeLinearGradient": [Function MakeLinearGradient], "MakeRadialGradient": [Function MakeRadialGradient], "MakeSweepGradient": [Function MakeSweepGradient], "MakeTurbulence": [Function MakeTurbulence], "MakeTwoPointConicalGradient": [Function MakeTwoPointConicalGradient]}, "Surface": {"Make": [Function Make], "MakeOffscreen": [Function MakeOffscreen]}, "TextBlob": {"MakeFromGlyphs": [Function MakeFromGlyphs], "MakeFromRSXform": [Function MakeFromRSXform], "MakeFromRSXformGlyphs": [Function MakeFromRSXformGlyphs], "MakeFromText": [Function MakeFromText]}, "Typeface": {"MakeFreeTypeFaceFromData": [Function MakeFreeTypeFaceFromData]}, "TypefaceFontProvider": {"Make": [Function Make]}, "XYWHRect": [Function XYWHRect]}
ℹ [08:10:30.833Z][Console] Skia undefined
ℹ [08:10:30.833Z][Console] frame {"width":1080,"height":1920,"bytesPerRow":1636,"planesCount":2,"orientation":"landscape-right","isMirrored":false,"timestamp":99759011.141416,"pixelFormat":"yuv","isValid":true}

Camera Device
const device = useCameraDevice('back', {
    physicalDevices: [
      'ultra-wide-angle-camera',
      'wide-angle-camera',
      'telephoto-camera'
    ]
  })

Device
iphone7 ios15
VisionCamera Version
3.3.1
Can you reproduce this issue in the VisionCamera Example app?
I didn't try (⚠ your issue might get ignored & closed if you don't try this)
Additional information

[ ] I am using Expo
[ ] I have enabled Frame Processors (react-native-worklets-core)
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

.......
this is not part of VisionCamera. I mentioned this like a thousand times, this is a separate experiment I did.

Why is it mentioned in the official docs if it's unsupported?
https://react-native-vision-camera.com/docs/guides/skia-frame-processors

@VNDRN did you read the content on the page you sent?

@mrousavy I am seeing this error on v4.0.1.  I see the Skia Frame Processor is available as part of V4. and the docs say it's for the Preview, not the actual saved image.
I use the same snipet as in the docs.
"react-native-reanimated": "~3.6.2",
"@shopify/react-native-skia": "0.1.221",
"react-native-vision-camera": "^4.0.1",
"react-native-worklets-core": "^1.3.0",


support require clauses in grant stmt

What problem does this PR solve?
ref https://github.com/pingcap/tidb/issues/9708
create user, alter user already support require syntax, grant also need that
What is changed and how it works?

make grant support require clause
fix and is optional

Check List
Tests

Unit test
Integration test

Code changes

impl change

Side effects

N/A

Related changes

Need to cherry-pick to the release branch 3.0

This change is

@jackysp @tiancaiamao  PTAL,  - - decrease codecov is caused by rename... maybe we can merge parse change first and move on other PRS.

comment address PTAL @tangenta  thx


Capture Runtime Env Context in Log Messages

A related issue we should create is to also capture generic runtime env context (e.g. parent task name if any, worker-process PID, node ID, etc.) in all of our log messages to make it easier to debug issues limited to a particular task, node, and/or worker process. If I look at one of our log files on a worker node today, it's nearly impossible to trace the series of events that a single worker process executes in order. Similarly, if I view aggregate cluster-wide logs, it's equivalently difficult to trace log messages back to their parent nodes.
Originally posted by @pdames in https://github.com/ray-project/deltacat/pull/56#discussion_r1093850771

Subtask: https://github.com/ray-project/deltacat/issues/55


Embedded dependencies

Consider I've created a project P1 (with Paket-managed dependencies) and published it to GitHub. Its csproj / fsproj files are automatically set up to take the dependency DLLs from P1/packages directory.
After a while, I am creating the second project P2 that uses P1 as a GitHub dependency (i.e. github ForNeVeR/P1 in my paket.dependencies). Paket correctly acquires P1 dependencies and installs it to P2/packages.
To build P1 and P2 together, I've added P1 project files from paket-files/ForNeVeR/P1 to the P2 solution. Is there another option for this case?
But the P1 still wants its dependencies to be in P1/packages, not P2/packages! And from P2 project perspective that folder is paket-files/ForNeVeR/P2/packages, and Paket even don't create it.
Is it the Paket-compatible use case? What could I do instead of mklink /j P1/packages P1/paket-files/ForNeVeR/p2/packages (note, that works correctly for me)?

mhm. that doesn't sound like a use case that we support.

So, the recommended way of doing this will be to publish the packages in question to Nuget?

We don't support full project dependencies via github yet. Did you look at
git submodule or git subtree instead?
On Dec 7, 2015 04:33, "Friedrich von Never"<EMAIL_ADDRESS>wrote:

So, the recommended way of doing this will be to publish the packages in
question to Nuget?
—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/Paket/issues/1294#issuecomment-162401359.

Is it a planned function or not? If not, I will close the issue.
Regarding your suggestion: yeah, thank you, I understood that I have to use something like git submodule or publish the package to Nuget, that's not a problem.
After all, I am already using Paket, and after some small manual modifications (mklink) it works.

it's not planned, but maybe http://7sharpnine.com/Xebec/ will one day be something for you. /cc @7sharp9

Ok, thank you for discussion, I'm closing it.


google-closure-compiler-linux throwing Java exceptions.

Executing the following command:
npx google-closure-compiler target/resources/main/js/es6-bundle.js > target/resources/main/js/es5-bundle.js --language_in=ECMASCRIPT_2017 --language_out=ECMASCRIPT5 --compilation_level=SIMPLE_OPTIMIZATIONS --rewrite_polyfills=true --warning_level=QUIET --jscomp_off=checkVars --create_source_map target/resources/main/js/es5-bundle.js.map

produces the following error statement:
java.util.zip.ZipException: invalid entry CRC (expected 0x4e1f14a4 but got 0xb1e0eb5b)
        at java.util.zip.ZipInputStream.readEnd(ZipInputStream.java:410)
        at java.util.zip.ZipInputStream.read(ZipInputStream.java:199)
        at java.util.zip.ZipInputStream.closeEntry(ZipInputStream.java:143)
        at java.util.zip.ZipInputStream.getNextEntry(ZipInputStream.java:121)
        at com.google.javascript.jscomp.AbstractCommandLineRunner.getBuiltinExterns(AbstractCommandLineRunner.java:481)
        at com.google.javascript.jscomp.CommandLineRunner.createExterns(CommandLineRunner.java:2073)
        at com.google.javascript.jscomp.AbstractCommandLineRunner.doRun(AbstractCommandLineRunner.java:1168)
        at com.google.javascript.jscomp.AbstractCommandLineRunner.run(AbstractCommandLineRunner.java:532)
        at com.google.javascript.jscomp.CommandLineRunner.main(CommandLineRunner.java:2231)

I confirmed that the native compiler is executed in this case (from google-closure-compiler-linux package). Force refresh and reinstallation of modules doesn't fix the problem.
Versions:
"20220202.0.0", "20220405.0.0"
Operating system:
Linux 5.10.105-1-MANJARO x86_64
Java version:
openjdk 11.0.14 2022-01-18
OpenJDK Runtime Environment Temurin-11.0.14+9 (build 11.0.14+9)
OpenJDK 64-Bit Server VM Temurin-11.0.14+9 (build 11.0.14+9, mixed mode)

I've tried to reproduce this problem without success using a JS file I had hanging around.
npx google-closure-compiler \
    regex_test.js \
    --language_in=ECMASCRIPT_2017 \
    --language_out=ECMASCRIPT5 \
    --compilation_level=SIMPLE_OPTIMIZATIONS \
    --rewrite_polyfills=true \
    --warning_level=QUIET \
    --jscomp_off=checkVars \
    --create_source_map test.sourcemap

I got the output I expected.
Here's relevant version information
$ npx --version
8.5.1

$ npx google-closure-compiler --version
Closure Compiler (http://github.com/google/closure-compiler)
Version: v20220405

$ java --version
openjdk 11.0.14 2022-01-18
OpenJDK Runtime Environment (build 11.0.14+9-post-Debian-1)
OpenJDK 64-Bit Server VM (build 11.0.14+9-post-Debian-1, mixed mode, sharing)

$ lsb_release -a
No LSB modules are available.
Distributor ID:	Debian
Description:	Debian GNU/Linux rodete
Release:	rodete
Codename:	rodete

$ uname -r
5.15.15-1rodete2-amd64

I also started running to this today. I'm not on computer right now so can't check all the specs for you yet, but what I do notice right away is that, like OP, I'm also using Manjaro

I'm also having the exact same issue, on ArchLinux (inside WSL).

Since I was unable to reproduce this problem with the latest release, and I doubt any of my coworkers can either.
I think we'll be dependent on folks in the OSS community to figure out what is happening here.

Here is a single command that will reproduce the problem:
docker run --rm -ti archlinux bash -c "yes | pacman -Sy npm && \
npm i -g google-closure-compiler && google-closure-compiler --version && google-closure-compiler a.js; bash"

Closure Compiler (http://github.com/google/closure-compiler)
Version: v20220405
java.util.zip.ZipException: invalid entry CRC (expected 0x4e1f14a4 but got 0xb1e0eb5b)
        at java.util.zip.ZipInputStream.readEnd(ZipInputStream.java:410)
        at java.util.zip.ZipInputStream.read(ZipInputStream.java:199)
        at java.util.zip.ZipInputStream.closeEntry(ZipInputStream.java:143)
        at java.util.zip.ZipInputStream.getNextEntry(ZipInputStream.java:121)
        at com.google.javascript.jscomp.AbstractCommandLineRunner.getBuiltinExterns(AbstractCommandLineRunner.java:481)
        at com.google.javascript.jscomp.CommandLineRunner.createExterns(CommandLineRunner.java:2083)
        at com.google.javascript.jscomp.AbstractCommandLineRunner.doRun(AbstractCommandLineRunner.java:1168)
        at com.google.javascript.jscomp.AbstractCommandLineRunner.run(AbstractCommandLineRunner.java:532)
        at com.google.javascript.jscomp.CommandLineRunner.main(CommandLineRunner.java:2241)

I've reproduced it also - you must specifically install npx for your platform and then run
$ npx google-closure-compiler

to get the issue. This immediately reproduces the problem, though doesn't make clear what the failure actually was.
Next I downloaded the actual executable from npmjs.com
https://registry.npmjs.com/google-closure-compiler-java/-/google-closure-compiler-java-20220405.0.0.tgz
Untarred, this contains a file package/compiler.jar, which starts up correctly.
In the debug logs for the failure above, I also found a different link, which better matches the issue's title:
https://registry.npmjs.com/google-closure-compiler-linux/-/google-closure-compiler-linux-20220405.0.0.tgz
This apparently contains an x86 linux binary in package/compiler, according to https://www.npmjs.com/package/google-closure-compiler-linux this is a

Linux native platform distribution of Closure Compiler.

Running this file is what results in the failure seen above. https://github.com/google/closure-compiler/#getting-started also references this binary distribution, as does https://www.npmjs.com/package/google-closure-compiler#user-content-native-binary-version.
I don't know how to build this distribution from the git repo with bazel, so I'm limited to stopping there and letting someone else take a look as to why the copy at npmjs.com might be corrupt somehow.


Add ttl as variable

Hi, the current TTL set is hardcode in the main.tf, In my case I need to keep the TTL shorter than 60 since is this is not a variable I need to create a dependencies folder with the subject_alternative_names and change the TTL there.

The way I'm using the module locally:
main.tf
-  ttl     = 60
+  ttl     = var.dns_ttl

variables.tf
+variable "dns_ttl" {
+  description = "The TTL of DNS recursive resolvers to cache information about this record."
+  type        = string
+  default     = "60"
+}
+

closed with #54


Add Support for Categories and Tags

Would be awesome if IdeaStrike supported categories, which an admin could pre-define and tags, which would be free-form for the user, but show suggested (or all) tags already entered

I'd like this to be a feature that people could enable - the site could be simple enough that tags/categories aren't necessary, or they may want to opt-in and allow users to tag ideas and organise them better.

That's sounds like a good way to approach it :)


Improved: Make lookup's no result message not selectable

Improved: Make lookup's no result message not selectable
(OFBIZ-12659)
Explanation
On lookups, the "No result" dropdown option should no be selectable. With this PR, clicking on "No result" empties the input (removes the search text).
See https://issues.apache.org/jira/secure/attachment/13045667/lookups-no-record-found.mp4
Thanks: Néréide Team

I tested, it works :)


Update compression config for openlm-research/open_llama_3b_v2

Reduce PPL for compressed openlm-research/open_llama_3b_v2 by removing all_layers=True compression parameter.

Precision
all_layers
PPL

FP16

12.40

INT4_SYM
False
13.45

INT4_SYM
True
13.73

INT4_ASYM
False
13.15

INT4_ASYM
True
13.36

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

@KodiaqQ please take a look

@nikita-savelyevv, you've provided numbers in the description with the ASYM mode, while configuration contains "sym": True. Why so?

@KodiaqQ Thanks for noticing. There were some errors in the collected metrics. I've updated the metrics in the PR description and changed the mode to asymmetric.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Galactic Unicorn won't display JPGs correctly

I have partially fixed this, following @Gadgetoid's pointers.
Using the included jpegdec, an image would load in and display incorrectly:
Incorrect

Correct (Note: 8x8 pixels)

Editing jpegdec.cpp and adding the following in int JPEGDraw(JPEGDRAW *pDraw) resulted in the colours displaying correctly
else if(pDraw->iBpp == 16) {
        for(int y = 0; y < pDraw->iHeight; y++) {
            for(int x = 0; x < pDraw->iWidth; x++) {
                int i = y * pDraw->iWidth + x;
                current_graphics->set_pen(RGB(pDraw->pPixels[i]).to_rgb888());
                current_graphics->pixel({pDraw->x + x, pDraw->y + y});
            }
        }

Fixed colours

However, the last few columns of the image repeats.
This is not true of all sizes:

I don't do C++, so am a bit lost now. I've been able to figure out that pDraw->iWidth in int JPEGDraw(JPEGDRAW *pDraw) is incorrect though.
If anyone can make any suggestions, I can continue to try, but feel i'm unable to progress now. :)

The auto builds here should at least now have the right pixel type - https://github.com/pimoroni/pimoroni-pico/pull/600
But I'm not sure what's going on with the width. Looks like your 11x11 pixel example is going wrong?

The auto builds here should at least now have the right pixel type - #600
But I'm not sure what's going on with the width. Looks like your 11x11 pixel example is going wrong?

Yeah, some width JPGs have additional columns/rows. I haven't looked into it further as I paused dev on this project.

I've synced JPEGDEC with the latest upstream changes to see if that's the cause, I'll have a poke.
Don't happen to have your 11x11 jpeg handy, do you?


The Documents section should only show completed sections. It should not show all possible sections/uploads/selections

[x] Documents page only showing uploaded documents
[x] No other information (NPI, SDAT) only documents


tasks-administer-federation-secret-2017-12-12

administer-federation-secret translation

updated

updated

/lgtm

ping @markthink

Could you squash the commit history?

squashed @lichuqiang @markthink


Fix #1952, patch for recursive event loop

Describe the contribution
Adds CFE_SB_RequestToSendEvent/CFE_SB_FinishSendEvent wrappers around all events generated by CFE_SB_TransmitMsgValidate.  This is avoids the potential for a recursive loop if configured improperly.
Fixes #1952
Testing performed
Build and sanity check CFE, run all tests.
Expected behavior changes
Tested with the mis-configuration where EVS had an invalid MID and confirmed that the system does not get into a recursive loop and segfault anymore.
System(s) tested on
Ubuntu
Additional context
This is just a minimal patch that does not change current architecture but avoids a crash.  A better fix for future versions would be to put this recursion protection into EVS in a more generic manner.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Pushed to fix clang-format errors.

https://github.com/nasa/cFS/wiki/Community-CCB-Agenda:-September-29-2021 APPROVED

caused by a misconfiguration
would benefit from re-architecting

@jphickey My merge of this one is causing the test failure
See https://github.com/astrogeco/cFE/commit/44312f0395152995317d55618cbd16989caa18fb
[  TTF] 127.027 sb_UT.c:4610 - CFE_SB_DeletePipe(PipeId) (0xffffffffca000003) == CFE_SUCCESS
[  END] 127 SB_SpecialCases.TransmitMsgPaths_Nomina TOTAL::27    PASS::26    FAIL::0     MIR::0     TSF::0     TTF::1     WARN::0


Extend linalg-ext attention to support cross attention

The current implementation only supported self attention where the query, key and value tensors have the same shape. This patch relaxes that constraint to support cross attention where the key and value can have a
sequence length different from that of the query tensor.

@MaheshRavishankar @hanhanW - could I get a review on this? Its blocking torch-mlir work on lowering the attention op.

Thanks @hanhanW


Test move sorting and pointer equality

Changes in this pull request
A couple other methods that were missing coverage.
Pull request checklist

[x] All tests pass. Demo project builds and runs.
[x] I added tests, an experiment, or detailed why my change isn't tested.
[x] I have reviewed the contributing guide

Going to let travis + coveralls do their thing, doesn't look like coveralls received any changes b/c we killed the builds of the other PRs.

all green!

ugh. oops. /Users/travis/build.sh: line 57: slather: command not found
i'll fix


Outside Div

How would I set the outside class that the breadcrumbs should be inside of?

The issue was moved to the new repository: link


FPS drops about 10 frames after using DisplayList and DisplayGroup

In my setup the app.stage owns a DipslayList object and each player has its own DisplayGroup. I will add new sprites onto the player and new ones will be covered by its existing sprites. I have compared with and without using pixi-display plugin. Sometimes it drops about 10 frames. Sometimes it's OK. Is there a recommended use of this plugin?

It depends on number of elements that has displayGroup, and whether you sort them. If you have 10k elements i suggest you to learn how pixi updateTransform() works and think how can you optimize it for your case.
pixi-display is the best "runtime" solution, and of course you can make better only if you know "static" optimizations for certain game that dont calculate everything on every frame.

Walk through all elements and determine which elements belong to which groups. That's a linear time algorithm, it has the same price that you are paying pixi for walks like "updateTransform" or "renderWebGL" (without cost of rendering itself).

Z-index sorting for groups: suppose we have a container with 1002 elements, two of them have different behaviour - one if in front and one is in back. If you just assign a "z-index" to all of them, you'll have to sort them all every frame. But with pixi-display you can assign them three different groups: one for back, one for front, and one for everything else, and thus the sort will work only on 3 elements

that is cheap.

Z-order sorting inside a group: when you have 1000 elements on different distance from screen, put that distance into zOrder field and enable sorting in the group.

that sort is slow, its the same sort as in phaserjs. First candidate for optimizations.

Currently I have custom "display" solution for 10k elements that uses CPU only when it needs to re-sort something. I will publish it later.
btw, there's new version: https://github.com/pixijs/pixi-display/tree/layers , it has different API , its easier to understand and it allows to use filters/masks: https://pixijs.github.io/examples/#/layers/lighting.js

I re-open it because that's the best explanation i gave so far :)