Feedback and test features

Hello Again!
Been playing a bit with sektron, on a rpi with a 5" touchscreen and a bluetooth keyboard connected to 4 volcas.
The experience is quite nice! and I see a lot of potential in this project!
Some feedback / wishlist / ideas that popped while jamming with this:

Pattern direction: ability to set up the pattern play direction (forward/backwards/ping-pong).

Modifying more than one step at a time. I know this might be difficult (and probably cumbersome), but it gets a bit annoying when trying to modify a few steps.(example: modifying velocity on hi hats on steps 1,4,8,12. My 'solution' is to add a copy/paste mechanism.  This improves productivity by a lot!  had to remap ctrl+c to ctr+q

At first, I loved the idea of one key for each step. But In practice I  always tried to use the arrow keys to navigate to the next step. I added a PrevStep/SextStep keymap, and (for me at least) was a nice booster, specially for copy pasting. This could potentially extremely useful for making a handheld/portable setup with fewer buttons.

This is totally related to my setup, but allowing click (touch in my case) to select a step would be really nice. I didn't investigate further but the UI library might have mouse support. Similarly touch/click and drag parameter could be another good usecase.

MIDI input would be killer, either in a step mode or in a live recording situation. I'm unaware of the complexities though.

In digitakt, when in 'track mode' pressing a button would trigger  the  associated sound/midi note. Maybe there is a good way to implement this (ctrl + step index key ?). Also this could be useful for a potential "live record" feature.

Polyphony: Digitakt does this by 'extending' the step note. only 4 notes supported. Not sure it is the best implementation but its something... I saw in the code some stuff about chords, so you might have already thought about that...

We need Swing support!!

LFO as you mentioned in the readme could be nice.

I was able to fork and setup a dev env pretty quick  and try a few features, I can open a PR for the mentioned features if you are interested but bear in mind is my first time with golang (hugo counts?) so the code might need some review.
Again, this is fantastic, thanks and good job!

Your feedback is awesome, thank you very much for the effort!
Would you mind creating a separate issues for each point? I know it's a pain but it will increase readability.

Pattern direction: ability to set up the pattern play direction (forward/backwards/ping-pong)

This would be a cool feature. It should be pretty easy to implement. For now, I would like to refrain from adding new sequencer parameters until we get the rest of the workflow right. The parameters part of the code is kind of clunky, so I may rewrite it at some point.

Modifying more than one step at a time. I know this might be difficult (and probably cumbersome), but it gets a bit annoying when trying to modify a few steps.(example: modifying velocity on hi hats on steps 1,4,8,12. My 'solution' is to add a copy/paste mechanism.  This improves productivity by a lot!  had to remap ctrl+c to ctr+q

Super interested by this! Feel free to open a PR.

At first, I loved the idea of one key for each step. But In practice I  always tried to use the arrow keys to navigate to the next step. I added a PrevStep/SextStep keymap, and (for me at least) was a nice booster, specially for copy pasting. This could potentially extremely useful for making a handheld/portable setup with fewer buttons.

Interesting. Feel free to submit a PR too. It seems weird to me to have multiple ways of selecting a step, but I can see how it would work with the copy/paste feature. I will try that.

This is totally related to my setup, but allowing click (touch in my case) to select a step would be really nice. I didn't investigate further but the UI library might have mouse support. Similarly touch/click and drag parameter could be another good usecase.

There's mouse support with bubbletea so it should be doable. And I can see the interest with touchscreens.

MIDI input would be killer, either in a step mode or in a live recording situation. I'm unaware of the complexities though.

We can listen to midi in without issues. There will be some concurrency issues in a live recording situation though (reading and writing steps at the same time) so we would need to add some mutexes on steps data.
Do you use step recording on the digitakt? I own a syntakt, and I only use the live recording mode. Step mode has always seemed weird to me.

In digitakt, when in 'track mode' pressing a button would trigger  the  associated sound/midi note. Maybe there is a good way to implement this (ctrl + step index key ?). Also this could be useful for a potential "live record" feature.

Maybe ctrl+track key? Seems clunky though, especially for recording. This would need some experimenting.

Polyphony: Digitakt does this by 'extending' the step note. only 4 notes supported. Not sure it is the best implementation but its something... I saw in the code some stuff about chords, so you might have already thought about that...

Yeah, I always though I would add some polyphony support, so all the data structures are ready. The main issue is how to add that nicely in the UI. Right now I don't have a nice solution in mind.
One easy solution would be to implement something like the chord machine in the syntakt or model:cycles. It's kind of rigid, but easy to reason about in terms of UI/UX.

We need Swing support!!

You can already make it swing with the offset parameter! But It's tedious, a track swing parameter would be better.

LFO as you mentioned in the readme could be nice.

Yes, and another thing that goes with that is trigger-less steps. That would allow to control only midi cc messages.

I was able to fork and setup a dev env pretty quick and try a few features, I can open a PR for the mentioned features if you are interested but bear in mind is my first time with golang (hugo counts?) so the code might need some review.

No worries! I'm open to all contribution.

Thanks for the replies! created each individual issue.


hardware observer has ERROR 'StorageControllers'

We received alerts related to
redfish_collector_failed{collector="redfish"} 1.0
Apr 18 04:30:33 infra python3[298134]: 2024-04-18 04:30:33 INFO Getting storage controller data...
Apr 18 04:30:33 infra python3[298134]: 2024-04-18 04:30:33 INFO Attempt 1 of /redfish/v1/
Apr 18 04:30:33 infra python3[298134]: 2024-04-18 04:30:33 INFO Attempt 1 of /redfish/v1/Systems/1/Storage/DE042000
Apr 18 04:30:33 infra python3[298134]: 2024-04-18 04:30:33 INFO Response Time for GET to /redfish/v1/Systems/1/Storage/DE042000: 0.010007815901190042 seconds.
Apr 18 04:30:33 infra python3[298134]: 2024-04-18 04:30:33 ERROR 'StorageControllers'

There are some request in middle but not related to Storage Controller.
The Error stopped and no additional information is provided.
Is there any information we can provide to resolve this?

Possibly duplicate of #69 on the prometheus-harwdare-observer repo.

Also quite similar to #115 and #177. This is potentially due to differing API paths for different hardware while querying for storage controller data from redfish

no ERROR seens after updated to rev 69, which including patch https://github.com/canonical/prometheus-hardware-exporter/pull/71


Suggestion: use titaniumifier

This looks a perfect candidate for being a titaniumified package. You’ll get gitTio support for free also :)
You can get yourself started at the Wiki documentation.
Please let me know if you have any issue in the process.

+1

Done


NPM app registry image not being polulated on deployment.yml

Hi there!
When deploying a NPM app the image prop on the deployment.yml is not being populated. On other services (.net API's) the image is being set.
aspire version: 8.0.0-preview.3.24105.21
aspir8 version: v0.1.40-preview
aspirate-output/fragfields-frontend/deployment.yml
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: fragfields-frontend
spec:
  minReadySeconds: 60
  replicas: 1
  selector:
    matchLabels:
      app: fragfields-frontend
  strategy:
    type: Recreate
  template:
    metadata:
      labels:
        app: fragfields-frontend
    spec:
      containers:
      - name: fragfields-frontend
        image:
        imagePullPolicy: Always
        ports:
        - containerPort: 3000
        envFrom:
        - configMapRef:
            name: fragfields-frontend-env
      terminationGracePeriodSeconds: 180

Program.cs
(...)

builder.AddNpmApp("fragfields-frontend", "../fragfields-frontend", "dev")
    .WithEndpoint(3000, 3010, scheme: "http", env: "PORT")
    .WithReference(identityService)
    .WithReference(matchService)
    .WithReference(identityService)
    .WithReference(subscriptionService)
    .AsDockerfileInManifest();

(...)

Thanks Adam. I'll take a look this evening

This should now be fixed in latest preview


How to pass data from mainVC to the containerView you selected?

Normal you pass some data with prepare segue to your view, so you can preform a query or pass that data into a tableview... Now I'm stuck because the segment is passing the button to show the right containerview, but is nog aware off some var I want to pass to the destination view

Hi @FredvanRijswijk !
I have updated my code now you can pass data from your Main View Controller to Container view. (if I got you right and if that's what you wanted).
let's say you have container view named FirstViewController.
`if let getFirstVCObject = self.container.currentViewController as? FirstViewController
{
     //pass your data with your getFirstVCObject

    }`

Kindly check out the updated code.
Thanks. :)


Fix for relative paths

Can we merge this @morebrownies @jjeffryes ?

I'll take a look at it once I finish my current branch.


controllers: dummy provision for clusterdeployment with installed timestamp

A dummy provision should be created for all legacy clusterdeployments. However, a dummy provision is not being created for legacy clusterdeployments that have an installed timestamp. To remedy this, the check for the installed timestamp has been moved inside the if statement verifying that the clusterdeployment has a link to a clusterprovision.
Additionally, the clusterdeployment controller has been changed to stop reconciling a clusterdeployment that is installed, has no clusterprovision to adopt, and has no infra ID. This is likely to happen when a clusterdeployment is restored prior to its clusterprovision being restored. The clusterdeployment controller should under no circumstances create a new clusterprovision when the spec of the clusterdeployment indicates that the cluster is installed.

/retest


Suggestion: improve command line options for extensions

A few improvements to command line options for extensions to allow debugging and issue reporting to be easier;

code --list-extensions - report versions also
code --disable-extensions --enable-extension <extension-name -- allow a single extension to be run
code --list-extensions - show enabled/disabled status

HTH

I would definitely LOVE #2 -- that way I could quickly run with all extensions disabled except for the extension I want to profile! And of course the disabled extensions wouldn't be persistent -- so on next start (without the command line) would have everything the way I would normally run

I have opened similar issue via API ( https://github.com/Microsoft/vscode/issues/15466 )
As extension installing / uninstalling via API not supported yet ( https://github.com/Microsoft/vscode/issues/14444 ) and CLI is supported for now, so it would be great if you can support those things and complete the extension management via CLI
In Settings Sync , currently im using custom requests for download and install extension as API doesnt provide ways to perform functions, i'm looking forward to change to CLI based extension installation / uninstall.

fyi #1 is already possible. Use the --show-versions flag when using --list-extensions

@sandy081 AFAIK, the disabled status of an extension is stored in the local storage which is available in the renderer process. The cli process doesn't have access to this information. Is that right?
If so, it is not possible to show the disabled/enabled status of an extension when listing them via --list-extension option.

True. But there are plans to bring that to CLI.

I like this idea, but does --enable-extension need to be combined with --disable-extensions? Or can it can be a separate argument?
code --disable-extensions
code --enable-extension ms-vsliveshare.vsliveshare

And can it accept multiple extension ids so that more than one can be enabled?
code --enable-extension ms-vsliveshare.vsliveshare ms-vsliveshare.vsliveshare-audio

What I'd love to see is the ability to use the console to deactivate and activate extensions not only globally but per workspace. That way, I can write scripts to set up a workspace with the needed extensions without having to make an extension pack for them. I can't stress how useful that is for people who are frequently creating new workspaces.


Gmail renders Body background as white only

Describe the Bug
When I send an email to a Gmail account it strips the background color.
I am passing a style with a background color to the body:
<Body style={main}>
   {...rest of template code}
</Body>

const main = {
    backgroundColor: '#0F1217',
    padding: '16px',
    fontFamily:
        '-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,Oxygen-Sans,Ubuntu,Cantarell,"Helvetica Neue",sans-serif',
};

In the React Email preview, it looks fine but when I send an email and open in Gmail the background is just white.
Which package is affected (leave empty if unsure)
@react-email/components
Link to the code that reproduces this issue
https://gist.github.com/jinsley8/a77e145e527223339c4dd1db47742945
To Reproduce
Use template to send an email to a gmail address.
Expected Behavior
I was expecting the background color to be the same as what I see in the preview and code. It should be dark, not white.
Not sure if I'm doing something wrong or if this is expected behaviour with Gmail stripping out the background color.
What's your node version? (if relevant)
18.12.1

I ended up solving it using another <Container /> between body and the main container.
I found that Gmail converts the body tag to a div and strips the styling.
<Body style={main}>
                // Added this next line
                <Container style={{ backgroundColor: '#0F1217', width: '100%', maxWidth: 'none' }}>
                    <Container style={container}>
                        <Header appDomain={web_url} />

                        <Section style={section}>
                            <Heading style={h1}>New trade request</Heading>

                            <Text style={{ ...text, marginBottom: '24px' }}>
                                Another user has sent you a trade request.
                            </Text>

                            <Button href={trade_link} style={{ ...button, lineHeight: '24px' }}>
                                View Trade Offer
                            </Button>
                        </Section>

                        <Footer appDomain={web_url} />
                    </Container>
                </Container>
            </Body>

Reopened because it still doesn't render properly when viewed on Apple iOS Mail on iPhone
Gmail (Desktop):

Apple Mail (iPhone):

How can I fix this?

The same issue occurs when I test using the demo templates, the background colour is stripped on Gmail and Apple Mail adds all the whitespace and shrinks it.
I tested these demos:

airbnb-review
codepen-challengers
google-play-policy-update
twitch-reset-password

None of the background colors render on Gmail iOS app:

@jinsley8 Thanks for opening the issue, I'm going to close this one in favor of #662

Thanks, I kind of added a separate issue at the end here wit some clients not displaying full width. I'll open a new issue for that.


Fixing issue when converting .js files (as opposed to .ts files)

@fbasso Thank you for reviewing my PR!


How to connect Portainer with Linux container demon running on "Docker for Windows"

Description
Not able to connect Portainer with Linux container demon running on "Docker for Windows"

Steps to reproduce the issue:

Docker daemon for windows container is already configured
Right Click on Docker Icon ->Switch to Windows container
Right Click on Docker Icon ->Settings.. -> Daemon -> then click on advanced -> add below line
{"Hosts":[tcp://<IP_ADDRESS>:2346]}
-> click on apply

Technical details:

Portainer version:1.16.4
Target Docker version (the host/cluster you manage): cluster
Platform (windows/linux): windows
Command used to start Portainer (docker run -p 9000:9000 portainer/portainer):

Why port 2346? 2375 is normal port.
How are you adding the endpoint inside Portainer? What IP:Port ?
Rgds,
Neil Cresswell
On 23/03/2018, at 10:31 PM, sudipto92 <notifications<EMAIL_ADDRESS>wrote:
Description
Not able to connect Portainer with Linux container demon running on "Docker for Windows"
Steps to reproduce the issue:

Docker daemon for windows container is already configured
Right Click on Docker Icon ->Switch to Windows container
Right Click on Docker Icon ->Settings.. -> Daemon -> then click on advanced -> add below line
{"Hosts":[tcp://<IP_ADDRESS>:2346]}
-> click on apply

Technical details:

Portainer version:1.16.4
Target Docker version (the host/cluster you manage): cluster
Platform (windows/linux): windows
Command used to start Portainer (docker run -p 9000:9000 portainer/portainer):

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_issues_1760&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=dfc3ifIA75A3qQgNg5ITxGYbDNoUKcHdrgWW86ZjuRo&s=I9FCXfzfZYmpT9bjuDi2IyQILziNCBRifRkQyyg1PVY&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWGrld6uSkV-5FEz7J-2DEhzO2k5iN7i01GPks5thMDogaJpZM4S4aR9&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=dfc3ifIA75A3qQgNg5ITxGYbDNoUKcHdrgWW86ZjuRo&s=1U7vdJ1kwyX7vpCN4hBmLo7v_9GDAXexPkO2tVIKvmc&e=.

it is same port 2375..
My issue is i am not able to initalize the docker daemon for linux container (Docker for windows)

Have you tried Docker community support? This is not the place to be asking for help with general docker issues.
Rgds,
Neil Cresswell
On 23/03/2018, at 10:46 PM, sudipto92 <notifications<EMAIL_ADDRESS>wrote:
it is same port 2375..
My issue is i am not able to initalize the docker daemon for linux container (Docker for windows)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_issues_1760-23issuecomment-2D375597480&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=JFPT0cGm4VnyNad_TZzuIFmUqVZq-biVLGf94pg1HlY&s=f2JADG5tJzFC9mbUpKUqBHji6G79BrvuQlEfnijV4x8&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWGrlf-5FqY5uGHEIUibCmVRYgeG1DJzDoks5thMR5gaJpZM4S4aR9&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=JFPT0cGm4VnyNad_TZzuIFmUqVZq-biVLGf94pg1HlY&s=j3JJ-Kvx_TE_teud1cokJIIsNu_3Sk0tUp9ImcmKE3g&e=.

@sudipto what is the version of the Docker engine you want to connect to ?

Docker version:   17.12.0-ce-win47 (15139)
Docker engine:   17.12.0-ce

Are you able to connect to your Docker daemon using the Docker CLI? If so, how are you using the CLI?


Feature: customized slice flag separator

What type of PR is this?
feature
(REQUIRED)

bug
cleanup
documentation
feature

What this PR does / why we need it:
add  customized slice flag separator
(REQUIRED)

Which issue(s) this PR fixes:
Feature https://github.com/urfave/cli/issues/1541
(REQUIRED)

Special notes for your reviewer:
(fill-in or delete this section)

Testing
(fill-in or delete this section)

Release Notes
(REQUIRED)

Feature: (https://github.com/urfave/cli/issues/1541)add  customized slice flag separator

The setting of "SliceFlagSeparator" is "global-level" because it is necessary to keep the same separator for each "sliceFlag". Therefore it is not set to "flag-level"

@dearchap Please help me, why does "CI" keep failing?😭

Can you do a gofmt or goimports in main dir ?

Can you do a gofmt or goimports in main dir ?

I did gofmt&goimports for the "flag_test.go" file, but it still failed.

@dearchap  Please help me review the code, I rely on this feature to do my work！💕💕💕


Image parameters do not work in v1.6.0 release

Newly added parameters templateImage=.. and image=.. for items do not work in the 1.6.0 release. I tested this in OSX 10.9.5. and 10.11.3. However, they are referenced in the documentation at https://github.com/matryer/bitbar. Could you release a new version?

This is expected. master is ahead of v1.6.0.

Any thoughts on when a new release will happen? Thanks for all your work on this! I love the simplicity of bitbar.

@iosdeveloper Bitbar is so great! I could not wait for the next release, so I git cloned the current master and tried to build it in XCode (Both 10.9 and 10.10) — could not get it to compile. Any ideas what one (non-developer) would need for a successful build to happen?

@myhd What is the error? You probably forgot to git submodule init && git submodule update (I wonder why this keeps coming up...).

@iosdeveloper You are so right. Thank you for the direction.
I must say I did not see the build info in the README, probably because it is under Contributing, and I did not want to contribute, but just build — or get — the newest version. Perhaps it is worth considering to put the build info somewhere else?


can not get receiverId when call roomInvitation.toJSON()

Miss set receiverId in the server end of wechaty-puppet-service.

Already resolved.


bug: certificate is not displaying properly

Describe the bug
certificate is not displaying properly. some part of certificate is hidden under navbar
To Reproduce
Steps to reproduce the behavior:

Do something : add some margin on top of certificate
See error on: https://app.100xdevs.com/certificate

Expected behavior
A clear and full certificate should be displayed properly
Screenshots or GIFs

Info (please complete the following information):

Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

can i work on it?

PR: #1557


Confirm random precedence of DNS Servers when using Custom DNS Settings in Azure Firewall

[Enter feedback here]
It would be good to confirm if below is true , as it seems different to how works on a standard Vnet DNS Servers setting with multiple entries , as this will try 1st Server, 2nd Server and so on.
If the Azure firewall behaviour is definately random as stated , I think it would be helpful to call out the difference for to VNet behaviour to clarify
--
If you configure multiple DNS servers, the server used is chosen randomly. You can configure a maximum of 15 DNS servers in Custom DNS.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c708ef58-326d-488f-6c6f-50021dc20063
Version Independent ID: 0dd28b93-b623-6668-55d0-2be56a8e3de4
Content: Azure Firewall DNS settings
Content Source: articles/firewall/dns-settings.md
Service: firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

Hello @andyjballgit
Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

Hi,
Repo details

i did a quick test where i had below in DNS Servers in firewall settings and had a script hit bbc.co.uk with Invoke-WebRequest 90 times with 120 second intervals (which is more than the ttl for bbc.co.uk) from a client that routes through the Azure firewall

<IP_ADDRESS>  -- Dummy IP / no DNS
<IP_ADDRESS>  -- Dummy IP / no DNS
<IP_ADDRESS> -- Azure DNS Resolver

bbc.co.uk allow added using Classic Application Rule

As per attachments i couldnt get it to fail - FirewallLog shows it doing a successful DNS lookup for each hit (cos of short ttl)

Note that DNS proxy is set to Enabled on the Firewall, but the client wasnt pointing at it , i did this as this seemed to be the only way to get AzureFirewallDnsProxy events to appear in the Firewall log

So this seems suggests that it is maybe trying all the DNS Servers in order ? If it was random , would expect it to fail a few times in 90 tries

--
FirewallLog.xlsx
TestURL.xlsx

any update on this ? thx

Thank you for your dedication to our documentation.
Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


[bevy_ui/layout] UiSurface update internal mappings

This is 4 of 5 iterative PR's that affect bevy_ui/layout

[x] Blocked by https://github.com/bevyengine/bevy/pull/12801
[x] Blocked by https://github.com/bevyengine/bevy/pull/12802
[x] Blocked by https://github.com/bevyengine/bevy/pull/12803

(Supersedes https://github.com/bevyengine/bevy/pull/12719)
The Demotion of a child UI node to root node might be out of scope and could be extracted into another PR. Extracted

Objective

Proper follow-up to #12698

Update UiSurface mappings to be more concise
Document UiSurface

Solution

Updated mappings:

use EntityHashSet to track relationships camera -> root nodes
adds tracking of camera_entity with Option<Entity> in RootNodeData (previously named RootNodePair)

Changelog
Migration Guide
TBD - even though it is passing the tests, it might introduce slightly different behavior and should probably be saved for 0.14 unless heavily scrutinized

removed Adds handling of UI nodes that are demoted and become a child of another root nodes tree from objective and extracting into its own PR

I plan on closing this PR and creating a new one with these rebased and updated changes, but I see a new state machine/cache has been added since then that I want to look at more closely before having anyone waste time reviewing this.

superseded by https://github.com/bevyengine/bevy/pull/16362


how to open submenu programmatically?

Hi, when I click on Menu button I would like to see "Edit" and "Find" submenus open. How can I achieve it? Thanks

The menu of this package has never been designed to work in this way, as it's not the expected behaviour of menus we've seen in most systems.
Still, it could be achieved by the instanceRef prop of a submenu.
Here is an example with one level of submenu. You could do the same for multiple levels of submenus.


fix gcc 5 bug

Unfortunately is not possible build SFML on Ubuntu Xenial (16.04) due to a GCC bug.
Further information on this link.

If it's an upstream bug, it should be fixed upstream, not here, in my opinion.

If it's an issue with your local build system – which it clearly is – adjust your local CMAKE_EXE_LINKER_FLAGS (or equivalent matching  your target type) in your build directory with these flags.
I don't think linking both static and shared(?) version of gcc specific extensions is the way to go here, as I could imagine this might cause unintended side effects regarding dependencies.

@MarioLiebisch It's not my build system, unfortunately, it's a bug of GCC. Users on Ubuntu 16.04 are unable to build SFML (cmake .. && make -j16 fail).

Warning about bugs in third-party tools is not something we want to do in SFML, otherwise we'd start collection tons and tons of warnings, as all software has some bugs.
Besides that, generating a warning for every GCC and shared library build is not an option. Not everyone compiles SFML on your specific Ubuntu version and even fewer run the broken compiler version. 😉

@eXpl0it3r I agree with you. But that's not a warning, it's a linkage error due to a bug in the compiler. GCC 5, unfortunately, is the default compiler of Ubuntu Xenial.
By the way, I signaled it.

But that's not a warning

message(WARNING "Applying workaround for https://bugs.launchpad.net/ubuntu/+source/gcc-5/+bug/1568899")

Looks like a warning to me.
That you then proceed to just link against libgcc and libgcc_s is even more questionable, as I wouldn't want that on Windows when using MinGW (which also matches GCC and shared library).

What about updating the stb_image extlib, wouldn't that also solve the issue?

Looks like they changed things in stb_image a while back, so updating it might indeed be an option now.


Fullstack app on 0.6 with context fails to share the state on server functions

Problem
Shared context on server server functions doesn't work on alpha.3 but was working fine on alpha.2. On 3 when I try to grab the state from the context I get ServerError|"alloc::sync::Arc<browser::BrowserManager>" not found in server context.
I also tried with other types like an empty struct Pool as described on the examples but the result is the same.
Steps To Reproduce
Steps to reproduce the behavior:
Create a fullstack app with context and without router.
LaunchBuilder::new()
        .with_context(server_only! {browser::BrowserManager::new()}) //The method new returns an Arc
        .launch(App);

On the server function try to grab the object manager
let FromContext(manager): FromContext<Arc<browser::BrowserManager>> = extract().await?;

When the server function is invoked from the frontend the error above described happens.
Expected behavior
Expected the state to be accessible on the server function.
Screenshots

Environment:

Dioxus version:  v0.6.0-alpha.3
Rust version:    1.81
OS info:    MacOS Intel
App platform:   Fullstack

Questionnaire
I'm interested in fixing this myself but don't know where to start

I'm running into this too, in my case launching via .serve_dioxus_application(ServeConfig::builder().context_providers(...)....
@fabiodcorreia any chance you found a workaround?

Although, actually, in this case, it might be due to providing a browser::BrowserManager but attempting to extract an Arc<browser::BrowserManager>?


ruff - fix ANN201 Missing return type annotation

Changes
This PR makes sure that all functions have return type annotations.
It does no other changes.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#158  👈
#157
#156
#155
#154
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @chrisaddy and the rest of your teammates on  Graphite


Could I show loading (spinner) for wating the complete submit (save data)?

Could I show loading (spinner) for wating the complete submit (save data)?
Please help me.

This is in the docs.  Please look at the Callbacks/Hooks, and specifically beginSubmit and endSubmit.  You can add the spinner in the beginSubmit and remove it in the endSubmit.

Thank, but I am not sure how to show/hide spinner in JS (I use sacha:spinner).

@thearabbit - did you find a way to show the spinner on beginSubmit? if yes, could you share how?

Now I used blockUI [https://github.com/malsup/blockui/] instead.
But don't up to date.


Add different file types to test pandas coverage

Adds three files to test read_html, read_json, and read_sas.
Source for SAS file: http://www.principlesofeconometrics.com/sas.htm
Source for HTML file: https://en.wikipedia.org/wiki/List_of_horror_films_of_2010

This is the data used for lux-org/lux:#156.


adjust wrapped lines selection to the rest of the line

Adjust right edge of wrapped lines selection to the rest of the line (similar to #549 / #564). IOW when selection the space character at the end of a wrapped line, then the selection is expanded to the right edge of the text area.
Old:
("01234 678 01" is a single line)

New:

Also closed rectangle path in ParagraphText.createRectangle(). Not sure whether this makes any difference, but com.sun.javafx.text.PrismTextLayout.getRange() does it too. So there might be a reason...

Thanks!


Refactor gRPC adapter support

With this in place:

A single RestGrpcAdapter can be used for multiple APIs (handy for dependency injection)
Services can "advertise" which transports they support, allowing automatic selection of adapters
Service metadata is provided to ClientBuilderBase through a constructor, removing the need most abstract methods

This is effectively #550 in a single commit, with more documentation comments etc. (I wanted to keep #550 in place while doing this, in case I missed anything.)


Add an "Optimization" recipe

Per discussion in #1751 , it's time we added a recipes page to cover performance and optimization.  @JAndritsch has volunteered to help write it, and I can definitely provide feedback and assistance.
Initial potential set of topics to cover per that discussion:

Connect components to state at the lowest level possible to prevent cascading renders from parent to children.
Normalize your data and pass collections of IDs instead of collections of large objects to components.
Use ImmutableJS.
Take advantage of "initialProps".
Re-define shouldComponentUpdate() when necessary.
Use React.addons.Perf to find and eliminate wasted renders.
Use Chrome's built-in profiling tools.
Memoization with Reselect
Per-instance component memoization
Performance in general. That subscriptions are O(n), that React Redux shallowly compares props, that memoization helps us avoid recalculations, etc.

Link-dumping a bunch of potential references, docs, and discussions:

https://github.com/markerikson/react-redux-links/blob/master/react-performance.md
http://somebody32.github.io/high-performance-redux/
http://stackoverflow.com/questions/37264415/how-to-optimize-small-updates-to-props-of-nested-component-in-react-redux
https://github.com/mweststrate/redux-todomvc/pull/1
http://stackoverflow.com/questions/37285200/react-redux-performance-optimization-with-componentshouldupdate
https://twitter.com/dan_abramov/status/720219615041859584
https://github.com/mozilla/tofino/issues/282
https://twitter.com/dan_abramov/status/733742952657342464
https://twitter.com/dan_abramov/status/719723707124604928
https://github.com/yelouafi/redux-saga/issues/241#issuecomment-207202589

Some relevant issues and docs:

The "Performance" section in the FAQ: http://redux.js.org/docs/FAQ.html
https://github.com/reactjs/redux/issues/1603
https://github.com/reactjs/redux/issues/1303

Thanks for putting this together, Mark. I should have some free time this week to start combing through those links and gathering info. I'll ping you once I have a rough draft.

Looks really good! I think that list is not in the final order of topics appearing in the guide?
And my 5 cents for now: I think it will be cool to add a topic about visualizing react component rerenders (with tools like render-visualizer). I know that this is more general to react perf, but for me, it was really helpful to find wrong container/representation hierarchy on lists

That was just the list of topics that @JAndritsch and @gaearon were proposing over in #1751 . Don't think any specific order was implied.  And yeah, render visualization and such would be good to cover too.

Why don't we list the helpful tools for optimization?
In my case

easy to handle shouldComponentUpdate with Recompose
babel plugin: transform-react-constant-elements, transform-react-inline-elements.
eslint rule: prefer-stateless-function

also useful.

Update: I've got a good start on this documentation and am continuing to work on it when time is available. I'll hopefully have a draft for review soon.

Cool, was going to ask if you'd had any time to look at it.  I still haven't managed to start in on the "Structuring Reducers" page myself.  Maybe this weekend, maybe?
Definitely ping me when you've got something to look at.

Any updates on this guys? :)

@markerikson  Can you give a code example for each of the 10 points?

@cristian-sima : I'm fairly busy at the moment, and when I do have time, my current priority is trying to work on the "Structuring Reducers" recipe described in #1784  .  I'd suggest reading through the links listed, particularly the set of articles included in the "React Performance" part of my React links list (which is the first link mentioned in this issue).

@markerikson How many connect functions do you think I should use?
My app is going slow, and I am using just 5 connects

@cristian-sima have you checked memoization?
http://redux.js.org/docs/recipes/ComputingDerivedData.html

I have no idea what is that, but I will look :)
Thanks

My experience is redux-devtools can slow things down quite a bit.  If you are using redux-devtools, you might want to check how slow your app is without it before you get too far down the optimization road. You should be able to use substantially more than 5 connects.

A significant improvement in performance I've made today by setting a shouldComponentUpdate.
Essentially, redux makes all the components to update. So, telling which to update has helped me

Excited for this recipe!
(If this comment novel should be its own issue or S/O question, let me know).
We're building an "activity feed" similar to Facebook's News Feed. We have hundreds of activities each with their own connect. Each activity has many sub-components (thumbnails that can be clicked on for modals, like/follow buttons etc.).
How should I connect each activity so we can optimise for shouldComponentUpdate? We've already normalised the data into activities (x liked 5 photos) and activityObjects (the 5 photos that x liked). Would one connect at the root activity suffice? Each activityObject can show up in multiple places in the feed. There are also members that can be followed (also normalised), and the indicator for that shows up in multiple places as well (for example when you click on a photo thumbnail activityObject).
Where do we hydrate the activityObjects for the best memoization? Do we denormalise at the root activity level and pass down all the props? Or connect each subcomponent only to the parts of state that it cares about?

Hi, @JAndritsch .  Wanted to check in and see if you are still planning to work on this.  You said you'd started a draft - is it posted anywhere?

Hey @markerikson.
Sorry for the delays here. Admittedly, I've had less time to work on this than originally thought. That being said, I still plan on putting in the effort when I can. I will send you the first draft when it's completed.

Gotcha.  Yeah, I understand the "find time to write" issues :)
I'd actually suggest pushing up your work in progress to a fork repo now. That way we can help contribute as you go.
Thanks for helping with this!

@markerikson Good idea. I created a separate branch and started the optimization recipe. Here's a direct link to it: https://github.com/JAndritsch/redux/blob/optimization-recipe/docs/recipes/Optimization.md.

So I was just discussing Redux optimization today at work and that conversation reminded me about this thread. I'd still like to contribute, assuming the content is accurate. Would anyone here be interested in reviewing the draft above? If all looks well, I'll try to finish out the remaining sections and then submit a PR.

Yeah, I'll try to take a look at it over the next day or two.
On a related note, I wrote a blog post a couple months ago that discussed some of the major aspects of performance: Practical Redux, Part 6: Connected Lists, Forms, and Performance.  Might be helpful to cross-reference some of the ideas in there.


Error reading from database (latest fresh build)

System.InvalidCastException: Unable to cast object of type 'LiteDB.DataPage' to type 'LiteDB.IndexPage'.
   at LiteDB.PageService.GetPage[T](UInt32 pageID) in C:\Github\LiteDB\LiteDB\Engine\Services\PageService.cs:line 46
   at LiteDB.IndexService.GetNode(PageAddress address) in C:\Github\LiteDB\LiteDB\Engine\Services\IndexService.cs:line 325
   at LiteDB.IndexService.Find(CollectionIndex index, BsonValue value, Boolean sibling, Int32 order) in C:\Github\LiteDB\LiteDB\Engine\Services\IndexService.cs:line 367
   at LiteDB.QueryEquals.<ExecuteIndex>d__2.MoveNext() in C:\Github\LiteDB\LiteDB\Engine\Query\QueryEquals.cs:line 18
   at LiteDB.LiteEngine.<Find>d__49.MoveNext() in C:\Github\LiteDB\LiteDB\Engine\Engine\Find.cs:line 36
   at LiteDB.LiteCollection`1.<Find>d__17.MoveNext() in C:\Github\LiteDB\LiteDB\Database\Collections\Find.cs:line 32
   at System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable`1 source)

and
System.InvalidCastException: Unable to cast object of type 'LiteDB.ExtendPage' to type 'LiteDB.DataPage'.
   at LiteDB.PageService.GetPage[T](UInt32 pageID) in C:\Github\LiteDB\LiteDB\Engine\Services\PageService.cs:line 46
   at LiteDB.LiteEngine.<Find>d__49.MoveNext() in C:\Github\LiteDB\LiteDB\Engine\Engine\Find.cs:line 44
   at LiteDB.LiteCollection`1.<Find>d__17.MoveNext() in C:\Github\LiteDB\LiteDB\Database\Collections\Find.cs:line 32
   at System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable`1 source)

two similar errors
I'm reading from and writing to the database asynchronously, both errors are from read ops.
Using, specifically, LiteCollection<BsonDocument>.FindById(...)
EDIT: Got another unique error message from the same situation.
System.ArgumentException: Offset and length were out of bounds for the array or count is gre
ater than the number of elements from index to the end of the source collection.
   at System.Buffer.BlockCopy(Array src, Int32 srcOffset, Array dst, Int32 dstOffset, Int32 count)
   at LiteDB.ByteReader.ReadBytes(Int32 count) in C:\Github\LiteDB\LiteDB\Utils\ByteReader.cs:line 108
   at LiteDB.BsonReader.ReadString(ByteReader reader) in C:\Github\LiteDB\LiteDB\Document\Bson\BsonReader.cs:line 145
   at LiteDB.BsonReader.ReadElement(ByteReader reader, String& name) in C:\Github\LiteDB\LiteDB\Document\Bson\BsonReader.cs:line 73
   at LiteDB.BsonReader.ReadArray(ByteReader reader) in C:\Github\LiteDB\LiteDB\Document\Bson\BsonReader.cs:line 52
   at LiteDB.BsonReader.ReadElement(ByteReader reader, String& name) in C:\Github\LiteDB\LiteDB\Document\Bson\BsonReader.cs:line 81
   at LiteDB.BsonReader.ReadDocument(ByteReader reader) in C:\Github\LiteDB\LiteDB\Document\Bson\BsonReader.cs:line 31
   at LiteDB.BsonSerializer.Deserialize(Byte[] bson) in C:\Github\LiteDB\LiteDB\Document\Bson\BsonSerializer.cs:line 25
   at LiteDB.LiteEngine.<Find>d__49.MoveNext() in C:\Github\LiteDB\LiteDB\Engine\Engine\Find.cs:line 0
   at LiteDB.LiteCollection`1.<Find>d__17.MoveNext() in C:\Github\LiteDB\LiteDB\Database\Collections\Find.cs:line 32
   at System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable`1 source)

Hi @mcmonkey4eva, can you past an unit test about this? Are you using Net35 ou NetStandard? I review all code to avoid this error.... it's all about locking.

tbh I don't know what triggered this beyond rapid async usage. I don't know if I'd be able to replicate it easily outside my environment. And it doesn't happen consistently, only once per few hundred calls.
It's the Net35 build, running under a .NET 4.5 program.
If you want, for a unit test, I could throw together something that just throws data into the wind asynchronously until it breaks, but I imagine you know your system well enough to make something at least as quality as that if not significantly more so.

How are you calling async? Can you paste you code in this part?

It more or less boils down to tasks, IE Task.Factory.StartNew( () => { ... } );
which in some cases does upserting of BsonDocument's.
IE, BsonDocument bd = new BsonDocument(); bd["_id"] = GetID(); /* other data */ collection.Upsert(bd);
and in other cases does reading of data via FindById
IE, BsonDocument bd = collection.FindById(GetID());
The program in question is a bit too complex and twisted to bother giving exact code, but it's basically the above in rapid parallel.
My idea of simulating it feasibly would be something like:
for (int i = 0; i < 1000; i++) // Change 1000 to whatever value spams it enough.
{
     int ind = i % 50;
     Task.Factory.StartNew(() => { collection.FindById(BitConverter.GetBytes(ind)); });
     Task.Factory.StartNew(() => {
        BsonDocument bd = new BsonDocument();
        bd["_id"] = new BsonValue(BitConverter.GetBytes(ind));
        collection.upsert(bd);
    });
}

... tweak as needed.

I made this unit test
[TestMethod]
public void Thread_FindUpsert_Test()
{
    using (var file = new TempFile())
    using (var db = new LiteEngine(file.Filename))
    {
        var tasks = new List<Task>();

        for (var i = 0; i < 10000; i++) // Change 1000 to whatever value spams it enough.
        {
            int ind = i % 50;
            var t1 = Task.Factory.StartNew(() => { db.FindById("col", BitConverter.GetBytes(ind)); });
            var t2 = Task.Factory.StartNew(() =>
            {
                var doc = new BsonDocument { { "_id", BitConverter.GetBytes(ind) } };;
                db.Upsert("col", doc);
            });

            tasks.AddRange(new [] { t1, t2 });
        }

        Task.WaitAll(tasks.ToArray());
    }
}

and still working. In this case, all tasks share same "db" instance. I will try more samples

Ok, I got the error. If I use LiteDatabase insted LiteEngine error occurs. Could be my LiteCollection.Find method and auto index create.

Hi @mcmonkey4eva, afer several day I still dont know how fix this in a good way. It's not possible catch exceptions when using yield return.
https://gist.github.com/mbdavid/6c693fc28ededabc8683de2f4d1364c9
Does anybody know how fix this?

Perhaps directly constructing a temporary list and returning that rather than doing a yield return? At least for the specific case... may require duplication of code.

If I use
    return FindWrap(query).ToArray();

works as expected. But, doing this it's terrible. This list could be too much documents and will use lots of memory.
My idea, at this moment, are:

Remove IndexNotFound exception
Run EnsureIndex as GetCollection<T> are called to all unique indexes (except PK)
Run AutoIndex as queries run (inside LiteEngine) but only non-unique

But, step 2 are not "free" and needs always read collection page.

@mbdavid Please have a look at the snippet I have added in the first comment to your gist. It allows error handling and still allows full streaming without loading everything into the memory. Not sure only where try-catch should be: in current or in MoveNext but that's easy to figure out :).

@mkosieradzki, I got me an idea: pass an Action to inner Find and avoid exception running index there. This will remove IndexNotFound exception.... I got it's simple way.

This happens MUCH less often in the newest build, but in a quick test it happened exactly once over a minute or two of testing (as opposed to several per second as it used to):
System.InvalidCastException: Unable to cast object of type 'LiteDB.ExtendPage' to type 'LiteDB.
DataPage'.
   at LiteDB.PageService.GetPage[T](UInt32 pageID) in C:\Github\LiteDB\LiteDB\Engine\Services\PageService.cs:line 46
   at LiteDB.LiteEngine.<Find>d__49.MoveNext() in C:\Github\LiteDB\LiteDB\Engine\Engine\Find.cs:line 46
   at LiteDB.LiteCollection`1.<Find>d__17.MoveNext() in C:\Github\LiteDB\LiteDB\Database\Collections\Find.cs:line 24
   at System.Linq.Enumerable.SingleOrDefault[TSource](IEnumerable`1 source)

I'm thinking this should be very high priority:
ANY rapid usage (async or sync) triggers this in recent builds.
I had to downgrade to the very first build of LiteDB v3, (Literally at commit "Nuget v3") to prevent the error. No modification to my code would let it through (I tried using my original code that I used prior to upsert, with an added synclock!)

Hi @mcmonkey4eva, yes this is priority and I was working on it. But was not easy found this tricky missing lock. From this Nuget v3 commit a lot of changes was made to support back multi process too (in this commit there is no multi instances support).
Now I run this test over 100 times using 2000 loop and no exception was throwed. Please try again with lastest version.

That did it!
The newest build no longer throws even a single error in my testing.
Amazing work! Thank you!

Hello!
I had this error any time when work with db. It's about 600000 documents. Used latest (3.0.1) build from nuget. Its my first time exirience with LiteDB. Looks like broken documents in db.
Code like that:
Dim col = db.GetCollection(Of DetailsLink)("DetailsLinks")
For Each item In col.FindAll
            Console.WriteLine(item.Uri)
Next

throw exception after some iterations.

@debagger should probably open a new issue for that.
Be sure to include a copy of an exception output when you do!


Issue #9123 Go Functions

Fixes #9123
Modifications
Check for nil ProducerSpec first
Verifying this change
as in #9123

@flowchartsman Can you rebase to the latest master to include recent changes that fix the broken master?

@flowchartsman Can you rebase to the latest master to include recent changes that fix the broken master?

@freeznet Can you review this change?

@freeznet Can you review this change?

@flowchartsman @sijie I have some findings related to #8761.
Currently go functions get KeyBasedBatchBuilder support with #8761, but the batchBuilderType is not exposed as an individual argument in pulsar-function-go/conf/conf.go https://github.com/apache/pulsar/blob/master/pulsar-function-go/conf/conf.go, so user cannot pass batchBuilderType to function, and batchBuilder is not usable. Additional, ProducerSpec from SinkSpec are not initialized  properly here: https://github.com/apache/pulsar/blob/master/pulsar-function-go/pf/instanceConf.go#L87-L90, and this will lead to #9123, user will get nil exception when access to instanceConf.funcDetails.Sink.ProducerSpec.

@flowchartsman @sijie I have some findings related to #8761.
Currently go functions get KeyBasedBatchBuilder support with #8761, but the batchBuilderType is not exposed as an individual argument in pulsar-function-go/conf/conf.go https://github.com/apache/pulsar/blob/master/pulsar-function-go/conf/conf.go, so user cannot pass batchBuilderType to function, and batchBuilder is not usable. Additional, ProducerSpec from SinkSpec are not initialized  properly here: https://github.com/apache/pulsar/blob/master/pulsar-function-go/pf/instanceConf.go#L87-L90, and this will lead to #9123, user will get nil exception when access to instanceConf.funcDetails.Sink.ProducerSpec.

@freeznet, it seems like what your saying is that my fix is a band-aid at a lower level, and that the other changes would fix this the right way, is that correct? If so, I think I should close this PR and we should make a new one that correctly fixes all of the issues you mention.

@freeznet, it seems like what your saying is that my fix is a band-aid at a lower level, and that the other changes would fix this the right way, is that correct? If so, I think I should close this PR and we should make a new one that correctly fixes all of the issues you mention.

@flowchartsman I think this PR is great and LGTM since it add nil check for pointer, but we should work on another PR to make BatchBuilder exposed to user properly.

@flowchartsman I think this PR is great and LGTM since it add nil check for pointer, but we should work on another PR to make BatchBuilder exposed to user properly.

@sijie should be rebased now, I believe

@sijie should be rebased now, I believe

@flowchartsman Thank you!

@flowchartsman Thank you!

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


Add nat_gateway_id to route and describe_route_tables

Add support for NatGatewayId parameter to create_route and to describe_route_tables response.
Resolves: #2496

Coverage decreased (-0.02%) to 93.738% when pulling 43070a03ba5fd6080dc19c76330ddfc055459974 on levinine:add_nat_gateway_id_to_route_and_describe_route_tables into 502957f1f9560cb6dff75271e6812498f4ff7bba on spulec:master.


[Dubbo-2191] add timeout config to zookeeper client

What is the purpose of the change
Add timeout config for zookeeper registry
Fix #2191
Brief changelog
Read timeout config from url and set to client
Verifying this change
CI pass
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[x] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #2217 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master   #2217      +/-   ##
===========================================
- Coverage     54.61%   54.6%   -0.02%
- Complexity     5152    5153       +1
===========================================
  Files           569     569
  Lines         25031   25033       +2
  Branches       4456    4456
===========================================
- Hits          13671   13669       -2
- Misses         9320    9326       +6
+ Partials       2040    2038       -2

Impacted Files
Coverage Δ
Complexity Δ

...ng/zookeeper/zkclient/ZkclientZookeeperClient.java
59.52% <100%> (+0.98%)
10 <0> (ø)
:arrow_down:

...ting/zookeeper/curator/CuratorZookeeperClient.java
62.16% <100%> (+0.51%)
12 <0> (ø)
:arrow_down:

...onfig/spring/extension/SpringExtensionFactory.java
75% <0%> (-10.72%)
10% <0%> (ø)

...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java
41.66% <0%> (-8.34%)
3% <0%> (ø)

...he/dubbo/remoting/transport/netty/NettyServer.java
67.85% <0%> (-3.58%)
8% <0%> (-1%)

...pache/dubbo/registry/support/AbstractRegistry.java
50.93% <0%> (-1.13%)
43% <0%> (ø)

...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java
59.16% <0%> (+0.83%)
31% <0%> (+1%)
:arrow_up:

...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java
78.67% <0%> (+1.47%)
29% <0%> (ø)
:arrow_down:

...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java
88.88% <0%> (+5.55%)
7% <0%> (+1%)
:arrow_up:

...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java
64.51% <0%> (+6.45%)
3% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7345582...5644585. Read the comment docs.

Also fix this issue:
https://github.com/apache/incubator-dubbo/issues/1743
Remember to close this issue after merging this pr.
:)

It LGTM.

hi, i am using the dependency is
<dependency>             <groupId>com.alibaba.boot</groupId>             <artifactId>dubbo-spring-boot-starter</artifactId>         </dependency>
,which had been solved the bug?
Look forward to your favourable reply.


CAMEL-11915: Updating the documentation to follow the new component o…

…perations and types

Update operation pas the body object into the
ElasticsearchActionRequestConverter.toUpdateRequest
Bulk operation pas the body object into the
ElasticsearchActionRequestConverter.toBulkRequest
Add missing query parameter for enable SSL. This is useful
if you want to point out a specific instance in the cluster for
specific routes

Merging now

Thanks @fharms the PR has been merged. Can you close this?

Your welcome


Code in qgs.py not compatible with python 3.11

In GitLab by @tomvansteijn1 on Apr 24, 2023, 09:27
The qgs module contains nested dataclasses. However Python 3.11 apparently does not accept mutable defaults.
Example error message:
ValueError: mutable default <class 'imod.qgs.SpatialRefSys'> for field spatialrefsys is not allowed: use default_factory

See for example here.

In GitLab by @JoerivanEngelen on Apr 25, 2023, 10:06
Thanks for posting this issue! We currently set maximum python version to 3.10 in the imod-environment.yml, but I see we did not do this yet in setup.cfg.
By the way:
We were thinking of scrapping this module (it's a module to generate .qgs projectfiles from a model object), as it is not used so often and hard to maintain: the .qgs files are not documented and can change with qgis versions without notice.

In GitLab by @JoerivanEngelen on Apr 26, 2023, 11:26
marked this issue as related to #351

In GitLab by @JoerivanEngelen on Apr 26, 2023, 11:26
marked this issue as related to #350


No active accounts

When trying to run twscrape, I received a warning that said "No Active Accounts"

try twscrape accounts and see if you've successfully loaded accounts. if u have, high probability that they've all been banned. see various threads for how to reduce incidence of this but it's a constant struggle.


When changing a password id from the URL, the details of the searched password are shown, but the folder structure is the same as before

The tree does not update when you change the password ID directly in the URL.

When the path contains passwordId the frontend must calculate the correct folder and must modify the browser URL. If password does not exist it must give error as now: sorry-page

Fixed in 1.2.0.dev


Create a periodic job for e2e conformance test and upload results to test grid

Now that we have the e2e conformance test run against PR(s), we need a CI job that runs the same thing periodically (6 hours? 12 hours?) Here are some notes:

We need a periodic job for Kubernetes/Kubernetes master against cloud-provider-openstack master (so we know if we break something)
We need a periodic job for Kubernetes/Kubernetes release-1.10 branch against cloud-provider-openstack master (se we make sure we don't break any one who wants to use our code against the last release)
Need to create a GCS bucket and upload files for each run, so we can display the results in kubernetes test-grid. See details in [1]

Nits:

test_results.html is empty as the junit xml file is under kubernetes directory (it's junit_01.xml)

Links:

[1] https://docs.google.com/document/d/1lGvP89_DdeNO84I86BVAU4qY3h2VCRll45tGrpyx90A/edit?ts=5a8486c1

/cc @animationzl @liu-sheng @kiwik

@dims please add privilege for @animationzl and I, we can not access to the google doc.
OpenLab have periodic pipeline, can run the job, we should consider the resource usage for all of the periodic jobs, beside e2e conformance job, there are some other sdk periodic jobs in OpenLab.

Work item:

Update periodic pipeline setting to run per 12 hours in OpenLab
Add a new job to run Kubernetes/Kubernetes latest release (1.10) against cloud-provider-openstack master in OpenLab (current e2e conformance job have supported run k8s master against cloud-provider-openstack master)
Update .zuul.yaml to add above two jobs into periodic pipeline in this repo
Support to upload test result to GCS, and report result in kubernetes test-grid
Fix the empty test_result.html issue

Hi @dims , could you help to finish this work item?

Support to upload test result to GCS, and report result in kubernetes test-grid

I have prepared a post hook in https://github.com/theopenlab/openlab-zuul-jobs/blob/master/playbooks/cloud-provider-openstack-acceptance-test-e2e-conformance/post.yaml#L10-L12 , but I can not understand well how to set config in kubernetes side.

Ack. the python script itself is here https://github.com/kubernetes/test-infra/blob/master/testgrid/conformance/upload_e2e.py
Though we have to figure out if there is a community GCS bucket we could use


Given giagram for the Token validation is not well rendered

Description:
Token validation diagram's Lines are overlapping with text; Please recreate it. Much clear rendering.
https://apim.docs.wso2.com/en/next/administer/key-managers/overview/

this document was belongs to APIM 3.2.0


Hi, I am new to learn github from Germany

👋  !

Hi there! i'm closing this issue since you've now been added as a collaborator. If you have any further questions, open a new issue and I'll be glad to help you out 🎈 🙇


S3 trigger

Issue #, if available:
#455
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Code review already performed.


Load specific terrain

Hello
Is it possible to load a custom terrain/map into Apollo/Dreamview?
My specific use-case is that Im looking at developing an autonomous offer road vehicle, and would like to run simulations using the specific terrain.
Thanks

Sorry we did not get back to you on this request. Are you still looking to add terrain to Dreamview?

Yes. That would be of great interest.
Thanks
On Fri, 24 Aug 2018 at 10:50, Natasha Dsouza<EMAIL_ADDRESS>wrote:

Sorry we did not get back to you on this request. Are you still looking to
add terrain to Dreamview?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ApolloAuto/apollo/issues/2968#issuecomment-415595716,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACEpHZodHiqOtZ_6kgBS0kPjQw0ot0UMks5uTzGggaJpZM4SQhxK
.

We are unfortunately not going to be adding terrain as part of Dreamview any time soon. It is definitely something on our future scope list. @magick93 if you do have some ideas, we would love to hear them.


/usr/include/vips/vips8:35:10: fatal error: glib-object.h: No such file or directory

Possible install-time or require-time problem

[x] I have read and understood all of the documentation relating to installation.
[x] I have searched for known bugs relating to this problem in my choice of package manager.

You must confirm both of these before continuing.
Are you using the latest version of sharp?

[x] I am using the latest version of sharp as reported by npm view sharp dist-tags.latest.

If you cannot confirm this, please upgrade to the latest version and try again before opening an issue.
If you are using another package which depends on a version of sharp that is not the latest,
please open an issue against that package instead.

[x] I am using Node.js with a version that satisfies ^18.17.0 || ^20.3.0 || >=21.0.0
[ ] I am using Deno
[ ] I am using Bun

If you cannot confirm any of these,
please upgrade to the latest version
and try again before opening an issue.
Are you using a supported package manager and installing optional dependencies?

[x] I am using npm >= 10.1.0 with --include=optional
[ ] I am using yarn >= 3.2.0
[ ] I am using pnpm >= 7.1.0 with --no-optional=false
[ ] I am using Deno
[ ] I am using Bun

If you cannot confirm any of these, please upgrade to the latest version of your chosen package manager
and ensure you are allowing the installation of optional or multi-platform dependencies before opening an issue.
What is the complete error message, including the full stack trace?
 > [sharp 4/5] RUN npm install --no-package-lock --save-dev node-addon-api node-gyp &&     npm install --no-package-lock --build-from-source --include=optional --verbose --foreground-scripts --platform=linux --libc=musl --arch=arm64 sharp &&     npm prune --production &&     npm cache clean --force:
...
10.16 gyp verb get node dir target node version installed: 20.18.0
10.16 gyp verb build dir attempting to create "build" dir: /sharp/node_modules/sharp/src/build
10.16 gyp verb build dir "build" dir needed to be created?  -I/glib-2.0<EMAIL_ADDRESS>-fPIC -pthread -Wall -Wextra -Wno-unused-parameter -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++17 -std=c++0x -fexceptions -Wall -Os -MMD -MF ./Release/.deps/Release/obj.target/sharp-linuxmusl-arm64/common.o.d.raw   -c
10.73 In file included from ../common.cc:13:
10.73 /usr/include/vips/vips8:35:10: fatal error: glib-object.h: No such file or directory
10.73    35 | #include <glib-object.h>
10.73       |          ^~~~~~~~~~~~~~~
10.73 compilation terminated.
10.73 make: Leaving directory '/sharp/node_modules/sharp/src/build'
10.73 make: *** [sharp-linuxmusl-arm64.target.mk:135: Release/obj.target/sharp-linuxmusl-arm64/common.o] Error 1
10.73 gyp ERR! build error
10.73 gyp ERR! stack Error: `make` failed with exit code: 2
10.73 gyp ERR! stack at ChildProcess.<anonymous> (/sharp/node_modules/node-gyp/lib/build.js:216:23)
10.73 gyp ERR! System Linux 6.10.4-linuxkit
10.73 gyp ERR! command "/usr/local/bin/node" "/sharp/node_modules/.bin/node-gyp" "rebuild" "--directory=src"
10.73 gyp ERR! cwd /sharp/node_modules/sharp/src
10.73 gyp ERR! node -v v20.18.0
10.73 gyp ERR! node-gyp -v v10.2.0
10.73 gyp ERR! not ok
10.74 npm info run<EMAIL_ADDRESS>install { code: 1, signal: null }
10.75 npm verbose stack Error: command failed
10.75 npm verbose stack     at promiseSpawn (/usr/local/lib/node_modules/npm/node_modules/@npmcli/promise-spawn/lib/index.js:22:22)
10.75 npm verbose stack     at spawnWithShell (/usr/local/lib/node_modules/npm/node_modules/@npmcli/promise-spawn/lib/index.js:124:10)
10.75 npm verbose stack     at promiseSpawn (/usr/local/lib/node_modules/npm/node_modules/@npmcli/promise-spawn/lib/index.js:12:12)
10.75 npm verbose stack     at runScriptPkg (/usr/local/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/run-script-pkg.js:77:13)
10.75 npm verbose stack     at runScript (/usr/local/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/run-script.js:9:12)
10.75 npm verbose stack     at /usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/rebuild.js:329:17
10.75 npm verbose stack     at run (/usr/local/lib/node_modules/npm/node_modules/promise-call-limit/dist/commonjs/index.js:67:22)
10.75 npm verbose stack     at /usr/local/lib/node_modules/npm/node_modules/promise-call-limit/dist/commonjs/index.js:84:9
10.75 npm verbose stack     at new Promise (<anonymous>)
10.75 npm verbose stack     at callLimit (/usr/local/lib/node_modules/npm/node_modules/promise-call-limit/dist/commonjs/index.js:35:69)
10.75 npm verbose pkgid<EMAIL_ADDRESS>10.75 npm error code 1
10.75 npm error path /sharp/node_modules/sharp
10.75 npm error command failed
10.75 npm error command sh -c node install/check
10.75 npm verbose cwd /sharp
10.75 npm verbose os Linux 6.10.4-linuxkit
10.75 npm verbose node v20.18.0
10.75 npm verbose npm  v10.8.2
10.75 npm verbose exit 1
10.75 npm verbose code 1

What is the complete output of running npm install --verbose --foreground-scripts sharp in an empty directory?
See above.
What is the output of running npx envinfo --binaries --system --npmPackages=sharp --npmGlobalPackages=sharp?
  System:
    OS: Linux 6.10 Alpine Linux
    CPU: (6) arm64 unknown
    Memory: 3.10 GB / 3.83 GB
    Container: Yes
    Shell: 1.36.1 - /bin/ash
  Binaries:
    Node: 20.18.0 - /usr/local/bin/node
    Yarn: 1.22.22 - /usr/local/bin/yarn
    npm: 10.8.2 - /usr/local/bin/npm
  npmPackages:
    sharp: ^0.33.5 => 0.33.5

Dependencies installed within the container
FROM node:20.18.0-alpine3.19

RUN apk add --no-cache --update \
    vips \
    vips-dev \
    vips-heif \
    libheif \
    libpng \
    libjpeg-turbo \
    libde265 \
    libwebp \
    g++ \
    make \
    gcc \
    build-base \
    glib-dev

Setting SHARP_FORCE_GLOBAL_LIBVIPS=1 seems to have fixed the issue. The installation instructions suggested that this was not required if a global libvips was detected.
This did uncover that the alpine 3.2 libvips version was not sufficient so I had to change to:
RUN apk add --no-cache --update \
    --repository=https://dl-cdn.alpinelinux.org/alpine/edge/main \
    --repository=https://dl-cdn.alpinelinux.org/alpine/edge/community \
    --repository=https://dl-cdn.alpinelinux.org/alpine/edge/testing \
    vips \
    vips-dev \
    vips-heif \
    libheif \
    libpng \
    libjpeg-turbo \
    libde265 \
    libwebp \
    g++ \
    make \
    gcc \
    build-base

The part of the installation log just before the section you've provided here should have included entries with information about what sharp discovered and the decisions it made when attempting to build from source.
As you've seen, the version of the vips-dev package provided by Alpine 3.19 is not recent enough for the latest sharp v0.33.5. You don't need to set (and I recommend against setting) SHARP_FORCE_GLOBAL_LIBVIPS unless you know that version mismatches should be ignored.
If you don't need to use a globally-installed libvips then I'd suggest not installing it and letting sharp using its prebuilt binaries, which removes a whole class of possible installation error.

@lovell As you can see from the dependencies, I needed support for heif images.


can't find storage

    我的也是这样

Originally posted by @xiaojieen in https://github.com/jinzhi0123/picgo-plugin-alist/issues/4#issuecomment-1283836757

可以提供一下picgo日志、插件配置、和alist网页的截图噢


Avoid duplicate connection error

If two or more connections come in at the same time the net_plugin will consider one of them a duplicate and will send a go away message
Use socket remote_address address:port for peer name instead or use remote_endpoint operator ==

Resolved by #6815


Which revision of nixpkgs is used by nixery.dev?

according to the website (Permalink) it's NixOS 20.09
according to the commit message of 8cd29e2e9f855793f428f77a958d222d6d14cf8d (the currently last commit touching nixpkgs-pin.nix on master), it's a 2021-10-29 snapshot of nixos-unstable

Which one is right?

Hey!
The website is totally out of date, sorry about that. Things changed a bit when I left Google and moved the service into the infrastructure of TVL instead.
Right now, as per the service configuration for the production deployment we use the nixpkgs commit that TVL's monorepo is pinned to. We update these about once a week (but it happens manually as there's some amount of breakage in parts of the repo as we have a wide variety of languages, tools, etc. in use).
There's no reason why the instance couldn't surface and display this commit somewhere, I'll try to do that at some point soon, but am pretty busy with other stuff at the moment.
Also for completeness sake, the nixpkgs-pin.nix that is checked in is pretty much only used for CI, nothing else.

Ah, cool. Would you welcome pull requests (at least partially) update the website?

Sure!

We're introducing a change that will dynamically display the deployed commit on nixery.dev: https://cl.tvl.fyi/c/depot/+/5881/


[Suggestion] Drag Arc or Semi-Circle

Hi! Loving the mod! It's awesome!
One new feature suggestion: Even better than dragging colonists into a line, would be dragging colonists into an arc or semi-circle.
Semi-circle around a target area is a very common layout, I think, but very click-intensive to do by hand.

Interaction could be - specify origin, specify radius, specify arc start angle, specify arc end angle.

Replaced bydrag-in-formation functionality. I know it's not the same but good enough in my opinion.


PyScript support

PyScript is convenient wrapper for Pyodide.
exodide requires Pyodide v0.21a2, however, PyScript uses Pyodide v0.20.1a2.
We will wait until PyScript update.

Hi @ymd-h ,
Yesterday the PyScript team updated the Pyodide to the last version, as you can see here.
So I think that will be possible to enable a integration between PyScript and Exodide.
Right?
Question
Is there anything that need to be change in Exodide side to be able to integrate Exodide with PyScript?

Hi @nyckmaia,
Thank you for your contribution, however, the CDN script hasn't updated yet.
https://pyscript.net/alpha/pyscript.js
(Please search with DEFAULT_RUNTIME.)
Do you know where we get updated one?
(or should we build and host PyScript development version by ourselves?)

I found <py-config> to configure Pyodide runtime.
https://github.com/pyscript/pyscript/blob/main/docs/tutorials/getting-started.md#the-py-config-tag
I tried but couldn't succeed yet.
    <py-config>
      runtimes:
        - src: "https://cdn.jsdelivr.net/pyodide/v0.21.0a2/full/pyodide.js"
          name: "pyodide-0.21.0a2"
          lang: "python"
    </py-config>

pyconfig.ts:106 Uncaught TypeError: Found non-callable @@iterator
    at PyConfig.connectedCallback (pyconfig.ts:106:34)
    at main.ts:22:34
    at main.ts:35:2

I noticed one more.
The PR didn't update Pyodide version at all, which still uses Pyodide v0.20.1a2.

We added example with PyScript at example.

Note
This works only with unstable version of PyScript. We will update after Pyodide update.


Fix invalid noqa comments

Description
Ruff (after my fix in https://github.com/astral-sh/ruff/issues/5855) was reporting invalid noqa annotations:
warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_bigint.py:19: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_bigint.py:65: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_bigint.py:74: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_uuid.py:22: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_uuid.py:66: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).
warning: Invalid `# noqa` directive on /Users/sobolev/Desktop/litestar/tests/unit/test_contrib/test_sqlalchemy/models_uuid.py:75: expected a comma-separated list of codes (e.g., `# noqa: F401, F841`).

For example, here's the first one: # pyright: ignore  # noqa: UP
I think that these noqa comments must be fixed.
URL to code causing the issue
No response
MCVE
No response
Steps to reproduce
No response
Screenshots
No response
Logs
No response
Litestar Version
main
Platform

[ ] Linux
[X] Mac
[ ] Windows
[ ] Other (Please specify in the description above)

Funding

If you would like to see an issue prioritized, make a pledge towards it!
We receive the pledge once the issue is completed & verified

Yes this is an annoying one for sure.
@JacobCoffee ?

I don't know if I should be posting here, but I have this comment in a file
# flake8: noqa: E301

and a warning from ruff
warning: Invalid code provided to `# ruff: noqa` on line 1: E301

Yes. I am thinking that recent changes maybe broke the rule-wide ignores.
books: Mapped[List[UUIDBook]] = relationship(  # pyright: ignore  # noqa: UP

books: Mapped[List[UUIDBook]] = relationship(  # pyright: ignore  # noqa: UP006

Also @martinlehoux, I think it is required for the hash to be before noqa as above.. i.e.
# flake8 # noqa: E301

fixed in #2044


CLOUD-61514 fix flow measure: some of the work is done in doExec

@schfeca75

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/cloudbreak-pull-request/2864/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/mock-integration-test/357/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/cloudbreak-pull-request/2865/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/mock-integration-test/358/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/cloudbreak-pull-request/2866/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/mock-integration-test/359/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/cloudbreak-pull-request/2867/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/mock-integration-test/360/


OpenID Connect & Active Session Storage

Integrated with https://github.com/hhorikawa/omniauth-openid-connect to provide a simple OpenID Connect authorization. There was a few other bugs that I ran into.
when storing the Omniauth respose into the session there was mixed code. One was treating the object as a hash and another was treating it as a omniauth object. There was only one reference to the omniauth object so I just converted the object to an hash and then changed the one reference to the omniauth object to be a hash reference.
With the pull of the omniauth-openid-connect being from github the docker file used to create the development image needs git to also be installed.
Added social link for OpenID Connect. The verbiage for hte link was too long so I made it say ODIC on the social icon. I do think we need to revist how this is generated. With the addition of OpenID Connect and OpenID there maybe a need to specify several social icons with the same type. Both the social icons and the config will need to change to accomodate this. I opted to not include this change because it could break current installations when upgrading.
Session storage - I ran into a limitation where the information stored inside of the session was exceeding 4kb. This is because currently portus uses cookie based session storage which has a limitation of 4kb. unfortunatly openid requries 4.1kb for the tokens and certs. I switched to the other common session storage to be active_record_store which is a database driven session storage. This really should of been done sense the first implementation of omniauth as there is some critical information in that data that could be abused if stored in a cookie. I am also surprised that the 4kb limit hasnt been broken for other things in Portus.
Added simple spec for openid_connect. Since i am not sure how to run the tests locally I think it will fail when travis-ci runs it.
Issues #1619

did you see https://github.com/m0n9oose/omniauth_openid_connect ?


HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …

…easy to understand

I think the logic is still there so we'd better keep the tests?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 54s
master passed

+1 :green_heart:
checkstyle
1m  7s
master passed

+1 :green_heart:
spotbugs
2m  4s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 27s
the patch passed

-0 :warning:
checkstyle
1m  4s
hbase-server: The patch generated 2 new + 2 unchanged - 1 fixed = 4 total (was 3)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 37s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 28s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

34m  1s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2430/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2430

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 11b87a163010 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 773185670b

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2430/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2430/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

I think the logic is still there so we'd better keep the tests?

Yes. Let me add them back.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 49s
master passed

+1 :green_heart:
checkstyle
1m  6s
master passed

+1 :green_heart:
spotbugs
2m  3s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 34s
the patch passed

-0 :warning:
checkstyle
1m  6s
hbase-server: The patch generated 2 new + 2 unchanged - 1 fixed = 4 total (was 3)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 28s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m  8s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

33m  2s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2430/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2430

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 9d46341b4421 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 773185670b

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2430/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2430/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 42s
the patch passed

+1 :green_heart:
compile
1m 35s
the patch passed

+1 :green_heart:
javac
1m 35s
the patch passed

+1 :green_heart:
shadedjars
9m 10s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 57s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
252m 33s
hbase-server in the patch passed.

291m  7s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2430/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2430

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c6396b98ffa6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8a6299bb38

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2430/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2430/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2430/4/testReport/

Max. process+thread count
3536 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2430/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


[5.9][CodeCompletion] Suggest synthesized declarations from macros

Cherry-pick #66821 into release/5.9
rdar://110535113

@swift-ci Please test

@swift-ci Please test Linux


add psr/simple-cache ^3.0

add psr/simple-cache ^3.0
Proposed changes
Add psr/simple-cache ^3.0 version to composer require dep to fix installation error:

konnco/filament-import 1.5 requires psr/simple-cache ^2.0 -> found psr/simple-cache[2.0.0] but the package is fixed to 3.0.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

Types of changes

[ ]  ✨ New feature (non-breaking change which adds functionality)
[x]  🛠 Bug fix (non-breaking change which fixes an issue)
[ ]  ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ]  🧹 Code refactor
[ ]  ✅ Build configuration change
[ ]  📝 Documentation
[ ]  🗑 Chore

thanks


precommit to clean notebooks?

should we configure precommit to clean all notebooks in gallery/interactive before commit?
in this way it would be clean

This does only work for notebooks of the "interactive" category, as static ones are not executed before rendering.


Allow keyboard time input

Currently the only way to set time is with the sliders.  Would be very helpful to be able to enter hours and minutes with the keyboard in addition to the sliders.
Thanks in advance.

I would love this. Easily the best date/time picker I have found, but that is a deal breaker for my application. Even if you never add this, thanks for making this great code available!


Made sure the layout engine gets recalculated when the route changes

Description
Fixed the layout view button, the problem was that the engine state wasn't recalculated on a route change.
Testing instructions
Add a set up instructions describing how the reviewer should test the code

Review code
Check Travis build
Review changes to test coverage
run the site and navigate to /gui/PANDA and click on the View button for the layout.

Agile board tracking
connect to #260
closes #260

Codecov Report

Merging #290 into version1 will increase coverage by 0.34%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           version1    #290      +/-   ##
===========================================
+ Coverage     87.16%   87.5%   +0.34%
===========================================
  Files            73      73
  Lines          2267    2594     +327
  Branches        372     461      +89
===========================================
+ Hits           1976    2270     +294
- Misses          262     288      +26
- Partials         29      36       +7

Impacted Files
Coverage Δ

src/malcolm/reducer/malcolmReducer.js
81.11% <100%> (+1.89%)
:arrow_up:

src/malcolm/actions/navigation.actions.js
72.38% <0%> (-6.26%)
:arrow_down:

src/malcolm/reducer/navigation.reducer.js
88.46% <0%> (-1.26%)
:arrow_down:

src/mainMalcolmView/middlePanel.container.js
82.53% <0%> (-0.32%)
:arrow_down:

src/malcolm/actions/method.actions.js
100% <0%> (ø)
:arrow_up:

...Details/attributeAlarm/attributeAlarm.component.js
100% <0%> (ø)
:arrow_up:

src/malcolmWidgets/table/table.container.js
100% <0%> (ø)
:arrow_up:

src/blockDetails/blockDetails.component.js
97.4% <0%> (+1.1%)
:arrow_up:

...s/attributeSelector/attributeSelector.component.js
95.31% <0%> (+1.43%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86af5aa...5e0afe9. Read the comment docs.


[sync]: from ODH to downstream

Description

mostly for the chore and test/ci related changes

How Has This Been Tested?

Screenshot or short clip

Merge criteria

[ ] You have read the contributors guide.
[ ] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
[ ] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

/test rhods-operator-e2e

/test rhods-operator-e2e

/lgtm

Can we add the jira issues included in the description?

/test rhods-operator-e2e

/test rhods-operator-e2e

@zdtsw Can we add the jira issues included in the description?

there is no jira related to this PR, only chore+test+make etc commits from ODH.


Cannot log into Alexa account for first time setup

I am trying to setup this plugin but I do not ever get the Amazon login screen as shown in the setup instructions. I only ever get the webpage with the QR code that attempts to install the Alexa app. When I click on the "Go To Alexa App" button on that page,  the Alexa app is brought to fore ground but then nothing happens.
I tried to turn off JS and clear cookies as instructed in common-issues, but then localhost:7002 landing page says I need to turn on JS to it to work.
So to summarize, I can neither login to Alexa using the credential dialog box in the browser nor login/get the cookie using the Alexa app.

Logs:
[11/27/2023, 9:57:23 AM] [homebridge-alexa-smarthome] Failed to initialize connection to Alexa. - You can try to get the cookie manually by opening http://localhost:7002/ with your browser.
[11/27/2023, 9:57:23 AM] [homebridge-alexa-smarthome] Alexa-Remote: Authentication check Error, try re-init
[11/27/2023, 9:57:23 AM] [homebridge-alexa-smarthome] Alexa-Remote: No cookie given, generate one
[11/27/2023, 9:57:23 AM] [homebridge-alexa-smarthome] Alexa-Remote: Error from retrieving cookies
[11/27/2023, 9:57:23 AM] [homebridge-alexa-smarthome] Alexa-Remote: Authentication check Error and renew unsuccessful. STOP
[11/27/2023, 9:57:23 AM] [homebridge-alexa-smarthome] After initialization - HttpError(Error getting smart home devices. Reason: Cookie invalid, Renew unsuccessful)
[11/27/2023, 10:01:23 AM] [homebridge-alexa-smarthome] Updating device states
[11/27/2023, 10:01:23 AM] [homebridge-alexa-smarthome] Alexa-Remote: Authentication check Error, try re-init
[11/27/2023, 10:01:23 AM] [homebridge-alexa-smarthome] Alexa-Remote: No cookie given, generate one
[11/27/2023, 10:01:23 AM] [homebridge-alexa-smarthome] Alexa-Remote: Error from retrieving cookies
[11/27/2023, 10:01:23 AM] [homebridge-alexa-smarthome] Alexa-Remote: Authentication check Error and renew unsuccessful. STOP
Plugin Config:
{
"devices": [],
"auth": {
"refreshInterval": 4,
"proxy": {
"clientHost": "localhost",
"port": 7002
}
},
"language": "en-US",
"performance": {
"cacheTTL": 300,
"backgroundRefresh": true
},
"debug": true,
"_bridge": {
"username": "0E:81:E1:5D:A2:A5",
"port": 41780
},
"platform": "HomebridgeAlexaSmartHome"
}
Screenshots:

Environment:

Plugin Version: v2.0.1
Homebridge Version: v1.7.0
Node.js Version: v20.9.0
NPM Version: v10.1.0
Operating System: Docker

It sounds like your Alexa app is not registered to the Amazon Alexa account you are trying to use with Homebridge. The QR code only comes up if you have never logged in to the Alexa app with your Alexa account.

Hi @joeyhage thanks for responding but its still not clear to me what the issue is. 1. I am logged into the Alexa app with my Amazon  account (the same CID that I use across all Amazon services) 2. "The QR code only comes up if you have never logged in to the Alexa app with your Alexa account." not sure what you mean here. I should be able to hit localhost:7002 from my computer browser and get to the Alexa login page like the instructions state right? That is not happening, it always shows the QR code(even when I am logged into the Amazon account ). This might help https://www.reddit.com/r/amazonecho/comments/16speat/the_alexa_web_interface_seems_to_be_gone_now/

Instead of localhost, can you please try using the private IP address of the device you are on? For example, <IP_ADDRESS>.
you would need to change the proxy.clientHost homebridge setting for this plugin and then access it using the IP address.
source: https://github.com/Apollon77/ioBroker.alexa2/tree/master#i-get-a-page-shown-with-a-qr-code-telling-me-to-scan-it

Hi @joeyhage any insight on this new failure?

Instead of localhost, can you please try using the private IP address of the device you are on? For example, <IP_ADDRESS>.
you would need to change the proxy.clientHost homebridge setting for this plugin and then access it using the IP address.

Just wanted to chime in that I had the same issue as OP (getting the QR code screen) and this solution worked perfectly for me. Thanks for the tip.

I just want to add that i was also getting the QR code screen and after changing a bunch of settings and really shooting in the dark, i found out that you cant have more than one targett clientHost, mine was set to: "localhost, <IP_ADDRESS>" and after changing it to just "<IP_ADDRESS>", the login screen appeared correctly. Thanks all for the help!


Consider config.relative_url_root in ActsAsResourceController.base_url

When Rails is deployed to a subdirectory per the official guide instructions, JSON:API should take this into account.
Implementation detail: Switched from string concatenation (+) to string interpolation because Rails.application.config.relative_url_root might be nil, which would cause an error as @hlogmans already stated.
Tested with:

Setting RAILS_RELATIVE_URL_ROOT=/subdirectory
Adding config.relative_url_root = '/subdirectory' in application.rb or .rb

Fixes #473
All Submissions:

[x] I've checked to ensure there aren't other open Pull Requests for the same update/change.
[x] I've submitted a ticket for my issue if one did not already exist.
[x] My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
[x] I've used Github auto-closing keywords in the commit message or the description.
[x] I've added/updated tests for this change.

Bug fixes and Changes to Core Features:

[x] I've included an explanation of what the changes do and why I'd like you to include them.
[x] I've provided test(s) that fails without the change.

Test Plan:
Unit test: bundle exec ruby -I test test/controllers/controller_test.rb -n test_links_include_relative_root
Manual testing:

Add config.relative_url_root = '/subdirectory' to config/application.rb
Run Rails server
Fetch any resource URL
Expected result: Link objects contain /subdirectory

Reviewer Checklist:

[ ] Maintains compliance with JSON:API
[ ] Adequate test coverage exists to prevent regressions

Note: I ran the test suite locally (ruby 2.6.3, rails 5.2.3, command bundle exec rake test) without https://github.com/cerebris/jsonapi-resources/pull/1282/commits/c6f11c35237fcaf4204f37ce9f42e391a892198b and it passed just fine:
Finished in 120.243376s, 5.5055 runs/s, 71.4052 assertions/s.
662 runs, 8586 assertions, 0 failures, 0 errors, 0 skips

However, Travis CI jobs all failed because subsequent tests suddenly included /subdir in their link responses. So I reset Rails.application.config.relative_url_root after the assertion, hope that provides enough isolation. Still wondering why the spillover only happens on Travis.
However, Travis

@lgebhardt FYI: It seems Travis fails on specific Ruby/Rails combinations due to a bundler version error. This seems unrelated to my PR since it's also happening in other PRs. The builds where bundler actually runs are fine.

@tobias-grasse Thanks!


withWorker() lacks testing

There is no test coverage at all because it's a bit challenging thing to test. It's currently not possible to even start it in jest because the trampoline code cannot be loaded.

do you think could be worth it to delegate worker threads implementation details to piscina?
e.g., https://github.com/piscinajs/fastify-piscina/blob/current/plugin.js#L7

do you think could be worth it to delegate worker threads implementation details to piscina?
e.g., https://github.com/piscinajs/fastify-piscina/blob/current/plugin.js#L7

I think this example is pretty accurate:
https://github.com/piscinajs/piscina/tree/current/examples/server


Programmatically show pin with annotations

Not sure if this is supported already but I couldn't find a way to programmatically show the pin with annotations as shown below, this was only after I manually tapped the pin.

My use case is I have a button on the map that spans to a pin but currently I have to manually tap the pin to actually get the annotation / box with pin details to show up.
I currently have the following calls with no success.
StoresMap.SendInfoWindowClicked(pin);
bool wasSuccess =  StoresMap.SendPinClicked(pin);
StoresMap.SendSelectedPinChanged(pin);

The wasSuccess is always false so I checked to see if the pin provided to the SendPinClicked exists in the list of pins and seems to be the pin I want to highlight.
Any help is greatly appreciated.

Please explore the sample app prior posting questions here. It has everything and even more to answer your question


feat(cross-filters): Add scoping for cross filters

SUMMARY
This PR add scoping for cross filters
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

https://user-images.githubusercontent.com/56388545/111170293-717fc480-85ac-11eb-95c3-0a6dce3cc9c3.mov
TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up

This is pretty amazing stuff @simcha90 ! 🎉

@robdiciuccio how can i turn on FFs in testenv? most of the features that needed to be tested are actually under FF or in Superset-UI currently. Is there a way to optimize it?  🙏

@robdiciuccio how can i turn on FFs in testenv? most of the features that needed to be tested are actually under FF or in Superset-UI currently. Is there a way to optimize it? 🙏
This way I enable it in local env

@junlincc feature flag and config overrides can be added if there's demand for those features. not currently possible, though.