wcslib: 5.20 -> 6.2

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/wcslib/versions.
meta.description for wcslib is: '"World Coordinate System Library for Astronomy"'.

Checks done (click to expand)

built on NixOS
Warning: no invocation of /nix/store/rrx0sqlkpndqdjbx3h08p2n1azvihn37-wcslib-6.2/bin/fitshdr had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 6.2 with grep in /nix/store/rrx0sqlkpndqdjbx3h08p2n1azvihn37-wcslib-6.2
directory tree listing: https://gist.github.com/3605836c8d082d605bb7ef432d463a63
du listing: https://gist.github.com/4d4d3043b02a1a324a2f012c388266d6

Outpath report (click to expand)

Outpath difference report
4 total rebuild paths
1 package rebuilds
1 x86_64-linux rebuilds
1 i686-linux rebuilds
1 x86_64-darwin rebuilds
1 aarch64-linux rebuilds
First ten rebuilds by attrpath
wcslib

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/rrx0sqlkpndqdjbx3h08p2n1azvihn37-wcslib-6.2 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A wcslib https://github.com/r-ryantm/nixpkgs/archive/445b85dd1f307e615c46701f79cc2632dcaef4b1.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/rrx0sqlkpndqdjbx3h08p2n1azvihn37-wcslib-6.2
ls -la /nix/store/rrx0sqlkpndqdjbx3h08p2n1azvihn37-wcslib-6.2/bin

Success on x86_64-linux (full log)
Attempted: wcslib
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rrx0sqlkpndqdjbx3h08p2n1azvihn37-wcslib-6.2
shrinking /nix/store/rrx0sqlkpndqdjbx3h08p2n1azvihn37-wcslib-6.2/lib/libwcs.so.6.2
shrinking /nix/store/rrx0sqlkpndqdjbx3h08p2n1azvihn37-wcslib-6.2/bin/fitshdr
gzipping man pages under /nix/store/rrx0sqlkpndqdjbx3h08p2n1azvihn37-wcslib-6.2/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rrx0sqlkpndqdjbx3h08p2n1azvihn37-wcslib-6.2/lib  /nix/store/rrx0sqlkpndqdjbx3h08p2n1azvihn37-wcslib-6.2/bin
patching script interpreter paths in /nix/store/rrx0sqlkpndqdjbx3h08p2n1azvihn37-wcslib-6.2
checking for references to /build in /nix/store/rrx0sqlkpndqdjbx3h08p2n1azvihn37-wcslib-6.2...
/nix/store/rrx0sqlkpndqdjbx3h08p2n1azvihn37-wcslib-6.2

Success on x86_64-darwin (full log)
Attempted: wcslib
Partial log (click to expand)
if [ ! -d "/nix/store/b4mkh8kkf61x5ibv3r81gwf85xwjkb48-wcslib-6.2/lib/pkgconfig" ] ; then \
     /nix/store/acnfbicd84bnya2l2dq868b5l482qihw-coreutils-8.30/bin/install -c -d -m 775 /nix/store/b4mkh8kkf61x5ibv3r81gwf85xwjkb48-wcslib-6.2/lib/pkgconfig ; \
   fi
/nix/store/acnfbicd84bnya2l2dq868b5l482qihw-coreutils-8.30/bin/install -c -m 444 wcslib.pc /nix/store/b4mkh8kkf61x5ibv3r81gwf85xwjkb48-wcslib-6.2/lib/pkgconfig/wcslib.pc
post-installation fixup
gzipping man pages under /nix/store/b4mkh8kkf61x5ibv3r81gwf85xwjkb48-wcslib-6.2/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/b4mkh8kkf61x5ibv3r81gwf85xwjkb48-wcslib-6.2/lib  /nix/store/b4mkh8kkf61x5ibv3r81gwf85xwjkb48-wcslib-6.2/bin
patching script interpreter paths in /nix/store/b4mkh8kkf61x5ibv3r81gwf85xwjkb48-wcslib-6.2
/nix/store/b4mkh8kkf61x5ibv3r81gwf85xwjkb48-wcslib-6.2

Success on aarch64-linux (full log)
Attempted: wcslib
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dkajiwk2l68g9dbzxc5x7w1x7xih1xvv-wcslib-6.2
shrinking /nix/store/dkajiwk2l68g9dbzxc5x7w1x7xih1xvv-wcslib-6.2/bin/fitshdr
shrinking /nix/store/dkajiwk2l68g9dbzxc5x7w1x7xih1xvv-wcslib-6.2/lib/libwcs.so.6.2
gzipping man pages under /nix/store/dkajiwk2l68g9dbzxc5x7w1x7xih1xvv-wcslib-6.2/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dkajiwk2l68g9dbzxc5x7w1x7xih1xvv-wcslib-6.2/lib  /nix/store/dkajiwk2l68g9dbzxc5x7w1x7xih1xvv-wcslib-6.2/bin
patching script interpreter paths in /nix/store/dkajiwk2l68g9dbzxc5x7w1x7xih1xvv-wcslib-6.2
checking for references to /build in /nix/store/dkajiwk2l68g9dbzxc5x7w1x7xih1xvv-wcslib-6.2...
/nix/store/dkajiwk2l68g9dbzxc5x7w1x7xih1xvv-wcslib-6.2


docs: add hermione -> testplane migration guide

ah, another thing. Did you try running npm run toc? This command is used to generate tables of contents in docs files. If you don't need one in your newly created file, include <!-- DOCTOC SKIP --> to the beginning of the file.


Add support for forwarding Docker client through SOCKS proxy

Closes #18373
ping @nathanleclaire

LGTM

This is very cool.  Nice job @LK4D4.  Will give it a spin soon.

LGTM

:+1: :tada: :balloon: :confetti_ball:

when I do export ALL_PROXY=socks5://<IP_ADDRESS>:1080, the docker still failed to pull tensorflow image from gcr.io,
abc@abc:~/source$ sudo docker run -it -p 8888:8888 b.gcr.io/tensorflow/tensorflow
Unable to find image 'b.gcr.io/tensorflow/tensorflow:latest' locally
docker: Error response from daemon: unable to ping registry endpoint https://b.gcr.io/v0/
v2 ping attempt failed with error: Get https://b.gcr.io/v2/: dial tcp <IP_ADDRESS>:443: i/o timeout
 v1 ping attempt failed with error: Get https://b.gcr.io/v1/_ping: dial tcp <IP_ADDRESS>:443: i/o timeout.
See 'docker run --help'.

is this commit enabling docker to pull image behind a socks5 proxy?


Consider splitting this package into router/plug support and UI

I am very greatful to have support for Phoenix with Ash Authentication, and I have some feedback in relation to some of the UI aspects.
I tried an earlier version of this package on another project and ended up "throwing the baby out with the bath water"  reeling at the UI approach and reverted to phx.gen.auth given it was easy to understand and reason about with no hidden magic.
After giving this package a second chance on a new project I ended up having to trawl the code trying to work out what overrides existed and how they got applied to what element/elements to work out which overrides I needed to apply and what module I needed to apply the overrides to.
Not the greatest experience And I again had to again say no cigar. Give me Heex templates and a set of well thought out components any day!  So hence I did decide to roll my own auth live view forms and it's happy days. I am still using the plug and router aspects of this package.
However it struck me as strange to have so much engineering for the form building and UI overrides approach and then I wondered what the Real-World example Ash app does...
Turns out it too (perhaps tellingly) rolls it's own auth forms, and honestly that was far easier to follow and reason about. It gets most of the value of this package in terms of plugs and routes without using any of the UI from it.
Given that the approach this package uses for building the UI is unlike normal phoenix UI code, I question would it not be time to reconsider the approach used and also at least consider breaking the UI part off into an "Ash Authentication Components" package and fully embrace the component model with attrs and slots instead of using "overrides"?
Perhaps such a component library could even take a 'headless component UI' approach which only considers the accessibility and is silent on the style and visual presentation? (e.g. something similar to Doggo)?
Anyway the intent of my issue is to provide some constructive feedback and my experiences using this package not to criticise the hard work because there is a lot of good stuff here.

We will be revisiting these design patterns in the next major release. The idea of the prebuilt UI was always to have something quick to get right out of the gate with some specific customizations, and then for users to create their own UIs for it eventually. We though it would be an early convenience that was discarded relatively quickly, but instead its been a primary sticking point for many users.
Ultimately we're in agreement that the current strategy for UI isn't working. We will leave the current system in place for backwards compatibility. We'll be leveraging igniter to do a mix of code generation and either enhancing the existing reusable components (which do exist) or adding new ones.

Thanks for the feedback @ahacking  - as @zachdaniel says there's plans afoot to try and make AAP more accessible for folks wanting to customise their authentication flow.


Feat/2021.05.c

This release is planned to

Fixes #44
Fixes #42

and other minor UI and data inconsistencies.

PR will be closed due to develop crash by updating Knowledgeportalia dataset

PR #55 has been deployed with develop.
Now this PR can now reopened.


/output/

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Sqlx error: Scan error on column index 4....converting driver.Value type []uint8 ("") to a int: invalid syntax

【description】
When I use sqlx to query rows, the following error occured:
sql: Scan error on column index 4, name "operator": converting driver.Value type []uint8 ("") to a int: invalid syntax
my code is like this:

query is like: SELECT id,obj_id,reason_id,obj_created_at,operator,created_at, modified_at, reason FROM.......
attention: the field sort of query and struct "ObjAggregate" is not the same
And i found out that if  i modify the struct from anonymous into normal struct, this error is not occured:

【debug】
i fount that this error is because of the following step (core/stores/sqlx/orm.go:70)：

when "v" is  a struct with anonymous struct
fields := unwrapFields(v)
the variable "fields" has the same size with the struct "ObjAggregate",
but for this step:
taggedMap, err := getTaggedFieldValueMap(v)
the size of "v" is actually 2, and  "taggedMap" is nil
so  when unmarshal rows:

the field sort of "values" and scanner is not the same, and the error occured...
【suggestion】
How about  modify this step(core/stores/sqlx/orm.go:70):
"taggedMap,err := getTaggedFieldValueMap(v)"  replace "v" into "fields" ?

@milkb32 I found that you're using v1.2.4, it's too early version, try the latest version please.

@milkb32 I found that you're using v1.2.4, it's too early version, try the latest version please.

Thank`s for the reply. The latest version v1.5.3 is ok.


How to change keyboard language and change Japanese input method

I am working on an application that supports multiple languages and it allows the user to different languages.
Is there any way we can do this programmatically (via C#)?
Is there an equivalent to this in WPF like the following?
InputLanguageManager.Current.CurrentInputLanguage = new CultureInfo("ja-JP);
Is there any event to detect input language change?
Also, how do we change Japanese input mode and input method programmatically?

You can use ActivateKeyboardLayout (tested on Windows 10 21H1)

ActivateKeyboardLayout() does not help. I want to be able to deterministically switch to a specific language, not to cycle the language list. Also, there is a need to programmatically  select a specific input method and input mode (Kana/Romaj input, Hiragana, Katakana, Alphanumeric, full-width, half-width) for Japanese (similarly to what  the language bar provides).

ActivateKeyboardLayout() does not help. I want to be able to deterministically switch to a specific language, not to cycle the language list.

You don't need to cycle
As the doc says, use LoadKeyboardLayout first.

This Win32 interface is not available in PInvoke.User32 package for Win UI3.

Why using a package ?
Just define it from the .h, like for any Win32 Api (or from .NET source code...)
        [DllImport("User32.dll", SetLastError = true, CharSet = CharSet.Unicode)]
        public static extern IntPtr ActivateKeyboardLayout(IntPtr hkl, uint Flags);

        public const int HKL_NEXT = 1;
        public const int HKL_PREV = 0;

        public const int KLF_ACTIVATE = 0x00000001;
        public const int KLF_SUBSTITUTE_OK = 0x00000002;
        public const int KLF_REORDER = 0x00000008;
        public const int KLF_REPLACELANG = 0x00000010;
        public const int KLF_NOTELLSHELL = 0x00000080;
        public const int KLF_SETFORPROCESS = 0x00000100;
        public const int KLF_SHIFTLOCK = 0x00010000;
        public const int KLF_RESET = 0x40000000;

A WinUI3 project cannot directly refer to User32.dll. That's why PInvoke.User32 package was created.

What does needs-triage label mean?


Controllers are improperly handled in dialogs

Describe the bug
I need to be able to create a controller for each one of my dialogs.
GetX controllers never get cleaned up if they are created inside a dialog after it is closed, therefore after one dialog is created all subsequent dialogs reuse the created controller.
Reproduction code
example:
import 'package:flutter/material.dart';
import 'package:get/get.dart';

void main() => runApp(GetMaterialApp(home: Home()));

class ExampleDialogController extends GetxController {
  final int count;

  ExampleDialogController(this.count);
}

class ExampleDialog extends StatelessWidget {
  final ExampleDialogController c;

  ExampleDialog(int count) : c = Get.put(ExampleDialogController(count));

  @override
  Widget build(context) {
    return Text('${c.count}');
  }
}

class Home extends StatelessWidget {
  final count = 0.obs;

  @override
  Widget build(context) {
    return Scaffold(
      appBar: AppBar(title: Text("GetX dialog bug")),
      body: Center(
        child: Obx(() => Text("$count")),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {
          count.value++;

          Get.dialog(
            SimpleDialog(
              title: Text('Test dialog'),
              children: [
                ExampleDialog(count.value),
              ],
            ),
          );
        },
      ),
    );
  }
}

To Reproduce
Steps to reproduce the behavior:

Click the fab a couple of times
The value in the dialog is not incremented because the controller is only initialized once.

Expected behavior
The controller to be reinitialized every time the dialog is reopened.
Flutter Version:
1.22.0
Getx Version:
3.13.2
Describe on which device you found the bug:
not important as it happens everywhere, but: Samsung galaxy a51

Get.create(()=>Controller()) is a way to create a new controller every time you run Get.find()
Use Get.create() instead of Get.Put(). Change your code like this:
class ExampleDialog extends StatelessWidget {
  ExampleDialog(int count) {
    Get.create(() => ExampleDialogController(count));
  }

  @override
  Widget build(context) {
    return Text('${Get.find<ExampleDialogController>().count}');
  }
}

You are calling Get.put in the initializer list from constructor.
The initializer list is called up before any route transition, still on the previous route.
You also don't need Put for dialogs, they are ephemeral.
Well, I don't think this is a bug, because the behavior described is exactly the expected behavior.

The way:
GetBuilder on root from dialog:
GetBuilder(
init: ExampleDialogController(),
builder:(c)

Get.put() inside build method.
Well, as there is nothing wrong here, I am closing this issue


Fix incompatible changes

Thank you for your review! PTAL.
Also, would you mind adding an explicit license to the repo? Preferably something like Apache 2 or MIT would be nice.

@Yannic let me know if you want me to merge the changes (I would prefer you did it, as I prefer to merge my own PRs/CLs/diffs/etc. when I think the time is right, but don't know how it works in GitHub)

Yes, please merge it. Github doesn't allow me to do it myself.


Account for error where delegation was prepared for different epoch

This should almost never happen. Basically, this should only happen when the user opens the web app in one epoch, then the epoch changes, then the user tries to delegate to a validator. In that case, we should at least show the error to the user rather than hanging indefinitely on "waiting for confirmation."

We've definitely been doing this incorrectly 😅 . Here's how it's handled in Rust:
https://github.com/penumbra-zone/penumbra/blob/aed1f8f607bfb4f9635d88f43b5ef8c5813036fd/crates/view/src/service.rs#L208-L218
Strange API, but if a non-zero response code is passed back, that indicates an error is present and viewable in the log.
  async broadcastTx(tx: Transaction) {
    const params = tx.toBinary();
    // Note that "synchronous" here means "wait for the tx to be accepted by
    // the fullnode", not "wait for the tx to be included on chain.
    const { hash, log, code } = await this.client.broadcastTxSync({ params });

    // Non-zero response code indicates an error
    if (code !== 0n) {
      throw new Error(`Tendermint error ${code.toString()}: ${log}`);
    }
    return new TransactionId({ inner: hash });
  }

@grod220 good catch! I've updated this with your suggestion and I'll merge when it's green.
Heads-up that I also created tickets for core and minifront to use error codes for showing more helpful error messages when a transaction fails. Henry was saying that should come after mainnet, though.


added basic instructions on BYOC

Added basic instructions for how to generate your own root or intermediate CAs based off information in k3s#1868
For Rancher (product) docs only
When contributing to docs, please update the versioned docs. For example, the docs in the v2.6 folder of the rancher folder.
Doc versions older than the latest minor version should only be updated to fix inaccuracies or make minor updates as necessary. The majority of new content should be added to the folder for the latest minor version.

@btat updated!

Thank you for the contribution!
I suggested a couple changes to the wording to highlight the fact that these steps should only be done before bringing up the cluster.
An additional two CAs are required for use with embedded etcd; would you care to include those in this as well?

I included those, thanks!

An additional two CAs are required for use with embedded etcd; would you care to include those in this as well?
I included those, thanks!

I'm not seeing the etcd CAs mentioned, did those changes get pushed?

Hi @mxplusb, please close this PR and create a new one at https://github.com/k3s-io/docs instead. Thanks!

I wont be making further improvements to the PR as I've run out of time


Add governance doc and CODEOWNERS for smi-spec

This PR adds a document for governance and CODEOWNERS.
The initial list of owners was pulled from the contributor graph for smi-spec.
After this change is merged we will enable required review from two CODEOWNERS for subsequent merges to master.

/lgtm


Remove redundant spec values

Fixes #17 . Disable_oom_killer and oom_score_adj were already part of the memory and process sections, so there was nothing to add.

Codecov Report

Merging #20 (145bb64) into main (b67aa8f) will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   26.88%   27.10%   +0.22%
==========================================
  Files           7        7
  Lines         491      487       -4
  Branches      248      244       -4
==========================================
  Hits          132      132
+ Misses        130      129       -1
+ Partials      229      226       -3


Ads not showing

ads not showing in video

and can we use large amount of proxy for daily usage with no view drop


What does >“nobody” starts including you< mean in no-permissions.md

While reading the great explanations is stumbled across this sentence "Once the work has other contributors (each a copyright holder), “nobody” starts including you." within the first paragraph of no-permissions.
Is this supposed to describe a deadlock-like situation and the sentence is equivalent to >..., no further contributions can be made not even from yourself<. or does it mean something else?

It means that any new code additions made by others can not be used by you without their permission.


Closes #265 | Implement dataloader for myxnli

Closes #265.
Checkbox

[x] Confirm that this PR is linked to the dataset issue.
[x] Create the dataloader script seacrowd/sea_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
[x] Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
[x] Implement _info(), _split_generators() and _generate_examples() in dataloader script.
[x] Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
[x] Confirm dataloader script works with datasets.load_dataset function.
[x] Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py.
[x] If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

Thanks! Updated!

The code is working as expected. Thank you for your PR!


updateWebhookSubscription

Description
This is part of the Push Deploy work to add a new handler to update webhook subscriptions.
Reviewer Notes
Please play close attention to the tests for UpdateWebhookSubscription Handler and Service Object
The endpoint show allow updating of the following fields:
subscriber_id - not the id of the subscription, but links to which contractor this subscription is related to status (ACTIVE, FAILING, DISABLED), event_key, callback_url, severity
Setup
To test the endpoint in Postman

Add a new collection, which will be this branch nt-CORRECTED-mb-6578-UpdateWebhookSubscription
Make sure that you are making a PATCH request with url: {{baseUrl}}/webhook_subscriptions
Follow [these instructions] (https://github.com/transcom/mymove/wiki/Test-Admin-and-Office-APIs-with-Postman) for copying the correct X-CSRF token into your Header in Postman
You should be able to send the request and receive a 200 response.

To run tests
go test ./pkg/services/webhook_subscription -testify.m TestWebhookSubscriptionUpdater -failfast  -v
go test ./pkg/handlers/adminapi -testify.m TestWebhookSubscriptionUpdater -failfast  -v

References

Jira story for this change

Messages

:book:
:link: MB-6578

  Generated by :no_entry_sign: dangerJS against 25d2bdd741a4a682e1f2beb6c6c11556a278c647

@NamibiaLT This PR can be closed since the rebased branch and final changes were merged in via #6030

This PR can be closed since the rebased branch and final changes were merged in via #6030


nzAutoClearSearchValue is not work  for select

Reproduction link
https://stackblitz.com/edit/angular-qcfahg?file=src%2Fapp%2Fapp.component.ts
Steps to reproduce
tap 'xxx' in the select and  click anywhere to make select blur,  the searchValue is still cleared
What is expected?
do not clear the searchValue
What is actually happening?
searchValue is cleared

Environment
Info

ng-zorro-antd
15.1.0

Browser
chrome

it works in your reproduction link

it works in your reproduction link

emm,  select works ，blur doesn't work。

it works in your reproduction link

emm, select works ，blur doesn't work。

Hi. fix is in progress :)


Support 1.19.4

Thank you for developing.
If possible, add support for SpyGot 1.19.4. I haven't downloaded your code (I'm still a long way from developing in java). I tried to redefine the dependencies for the classes, but it looks like something has changed in the queries. I attach a log of startup errors.

crashWP161.txt

I want to add that I still got into the decompiler: It is enough to add a class and change calls to the API and everything works on 1.19.4. Thank you for the clear code, even when decompiled, everything is quite easy to read. You are super! But please add support to the official repository.

@DmitryASmith
Could you fork the repo for your working version (for 1.19.4)? I’m not having any luck with copying/editing the 1_19_R2 class and recompiling.

With the permission of the author. So that there are no more questions for me, I will post here a working version with my additions to support 1.19.4 (since I did not use the source codes).
Rename the file to jar...
BeaconWaypoints-1.6.1b2.jar.zip


feat: Add sponsors section

Add sponsors section
LATER: I will make another PR to make a sponsor fragment to display the detail information of the sponsors. It is weird that when I fetched the sponsors, the number of sponsors sent to the app can go up to 600, I don't know if someone really made those much data or are there any problems in the server side. @iamareebjamal should I open an issue in the server
Fixes #1651
Screenshots for the change:

A lot of sponsor's image is getting cut. Use different scale type or different shape of image view

@angmas1 Updated

@angmas1 Updated

This looks good but, can you give some padding between image view and card view and make cards slightly larger and reduce space between adjacent cards and also reduce space between sponsor text views and cards.

@angmas1 yes, I get your point! Doing now

@angmas1 @iamareebjamal updated


Update --automate-all e2e tests

Continuation of #363. Configuration-only e2e tests work, but --automate-all tests do not.

[x] Fly
[x] Platform.sh
[x] Heroku
[x] In pytest.ini, just list each default plugin's tests/ dir.
[x] Make sure e2e tests only run when specifically requested, not for bare pytest calls.
[ ] Update docs to reflect new command: $ pytest tests/e2e_tests --plugin dsd_flyio -s

Fix destroy project for Fly

[ ] Deployment succeeds, but can't destroy the project.

[ ] fly info -> fly status --json.
[ ] Remove unused code.

[ ] Push changes to Fly plugin.

Bare pytest calls

[ ] Bare pytest calls should only run unit and integration tests.
[ ] e2e tests should only run for requested plugin.

Auto-collect tests for installed non-default plugins?

[ ] Detect installed plugins in root conftest.py.
[ ] Find non-default plugins.
[ ] Include these tests.

Working notes
Adding tests from an external package doesn't have a straightforward solution. It's been discussed for over a decade, without a clear answer.
Adding plugin paths to pytest.ini works, but it's hard-coding those paths. It would be really nice to dynamically discover and set those paths. There is pytest_configure(), which lets you modify the config object. There are several attributes that might work. I can see these by including this block in the root conftest.py:
def pytest_configure(config):
    print("\n*** in config ***")
    print(config)
    breakpoint()
    sys.exit()

(Pdb) pprint(config.__dict__)
...
 '_inicache': {'addopts': [],
               'cache_dir': '.pytest_cache',
               'consider_namespace_packages': False,
               'filterwarnings': [],
               'python_files': ['test_*.py', '*_test.py'],
               'pythonpath': [],
               'required_plugins': [],
               'testpaths': ['tests',
                             '../dsd-flyio/tests/',
                             '../dsd-platformsh/tests/']},
...
'args': ['tests', '../dsd-flyio/tests/', '../dsd-platformsh/tests/'],
 'args_source': <ArgsSource.TESTPATHS: 3>,
 'cache': Cache(),
 'hook': <_pytest.config.compat.PathAwareHookProxy object at 0x1018c1ee0>,
 'inicfg': {'testpaths': 'tests\n'
                         '../dsd-flyio/tests/\n'
                         '../dsd-platformsh/tests/'},
 'invocation_params': InvocationParams(args=('-s',),
                                       plugins=None,
                                       dir=PosixPath('/Users/eric/projects/django-simple-deploy')),

Try adding paths dynamically

[ ] Modify config._inicache.testpaths
[ ] Modify config.args
[ ] Modify config.inicfg.testpaths


Updating wlist.txt

Update required on wlist.txt by 2021 format.

We will be using seclists the have updated wlists


[FEAT]: Icon categories

Description
All icons are listed in README.md file according to alphabet. But it is hard to someone to see which icons are available. It will be great if they are categorized like social, tools, frontend, backend, low-level, design, adobe and etc
Additional Information
No response
Code of Conduct Acknowledgment

[ ] I have read and agree to the Code of Conduct.

The thing is that, if we do by classification, I think people will take more time to search their icon than if it is alphabetically. If we do that, it will be harder to "sort" them if there are new icons that come... I think it is okay to not have them sorted in a way other than alphabetically

Yes, I am totally agree. However, there are some icons that I do not really expect to see. And when some new icons added, always look for all icons needed. Anyway, it is just a small feature. Not the end of the world!


Removes scroll on unlocked items modal

Description
Fixes #...
Notes (out of scope, known isues, hints for reviewing code, ...)  (optional)
...
Test cases

[ ] Case 1:

Given I am the usual user
When I go to [this page](branch link)
And I click on ...
Then I see ...
And

[ ] Case 2:

Given I am the usual user
When ...

[auto-generated message] E2E test report on: https://algorea-static.s3.eu-central-1.amazonaws.com/branch/feature/unlocked-items-modal-remove-scroll/playwright-report/index.html


Crash when shooting laser rifle after scene transition

Cogito and Godot Engine Version:
Godot 4.2.1 and Cogito latest
Description:
Shooting the laser rifle picked up in demo scene 5 after transitioning to scene 4 results in a crash. This does not happen with the foam pistol from scene 5, and the scene doesn't crash if, after loading scene 4, you put away the rifle, then equip it again before shooting.
Reproduction steps:

Load demo scene 5
Pick up the laser rifle
Walk over to the scene transition hallway
Shoot the rifle

Expected behavior:
The rifle shoots.
Screenshots:

Thanks for the flag!
Could you check if https://github.com/Phazorknight/Cogito/commit/84bc8a7a3597e7c92ccba21b692b84fc0d054d1e fixes this for you?
The reason was that when the laser rifle gets equipped, it grabs a scene reference. But when the scene isn't fully loaded yet, this reference is null, resulting in the error you saw.
I've changed this to be a deferred call, which seems to fix this.

Nice one, that fixed it! 😄


Add a hard timeout for tasks.

I've added a setting that allows a hard time limit for tasks to be set, ignoring the retry window logic. That's difficult to use when there are lots of tasks running in parallel which take different amounts of time.
Note: Please review this code, and if you're happy I'll write tests then.
Thanks.

looks good by test please!

OK will do :+1:

cool

Tests added :+1:

OK I've changed the setting to take the number of seconds as an int instead of a timedelta.

Cool, I think in this case all the 4 commits can be squashed into one. Would that make sense @boosh?

How do I do that?

git rebase -i HEAD~4

OK done, but for some reason it included the merge. I'm not really a rebaser as you might have gathered...

Erm now there are six commits. Something didn't work out. Note that you must eventually --force push.

FFS

See #916 instead.


NUKE unused IPC calls

LGTM. Doing it in the 0.56 branch is the right way. Having syscalls that work in some engine builds of the same ABI version but not others wouldn't be good.

Fair enough. Probably won't gain any uses of the syscalls and we'll jsut discover it when we release 0.56


load-object-before-read false positives

Expected behavior
No error
Current behavior

An explicit load call on 'contentControl' for property 'id' needs to be made before the property can be read. eslint(office-addins/load-object-before-read)

Steps to Reproduce

When getById(id) is called
async function loadContentControl(id: number) {
  await Word.run(async function (context) {
    const contentControl = context.document.contentControls.getById(id);
    context.load(contentControl, "id");
    await context.sync();

    console.log("Loaded content control with id: " + contentControl.id); // this is the line where the error appears
  });
}

When getByTag(tag) is called
Similar code to the one above (use getByTag(tag) instead of getById(id))

Context

Operating System: Windows 10
Node version: 16.14.0
eslint-plugin-office-addins version: 2.1.3

Related issue
Issue #671 reported a similar problem. It is closed now.

The problem is that the linter rule is not recognizing the syntax 'context.load(contentControl, "id")' is the load call.  If you change it to contentControl.load("id") then the linter error will go away.
This is a limitation of the first version of the linter rule.  We should update the rule to include the form of syntax.

This should be fixed in the most recent version of the linter rules package.


Edits to API spec and drop most displayed request languages

This change is

@itsbilal Made some edits here (new text per the doc, and got part-way on a general copy edit), and left some more Q's in the doc.
Feel free to push a commit. Otherwise I'll look for updates in the doc and continue with my copy edit here. Thanks!


Release 1.6

Fix for below issues
https://github.com/sequenceiq/cloudbreak/issues/2092
https://github.com/sequenceiq/cloudbreak/issues/2064.
Fix summary

Added new form under "Manage Security group" to add existing groups along with new security group.
Added 2 new columns to Securitygroup table, for adding cloudplatform and storing cloud existing security group id.
Added ability to provide custom image id for building cluster.

hi, could you send the pull request against the rc-1.6 branch, please?

As per akanto comment, i will create another pull request on rc-1.6 branch.


System Model: Inter-System (and inter-domain) relationships for the System Landscape View.

The system model in Backstage catalog does have part-of relationship for Components with the System. but the Systems themselves do not have any peer/inter relationships as defined by the C4 Model.
Feature Suggestion
Define the inter-system (and probably inter-domain) relationship for Backstage System Model to cover the recommended modeling by System Landscape Diagram in C4 Model.
Possible Implementation
It would nice to allow the custom name for the relationship between the systems (and domains if we decide to pursue that)
Context
The context is pretty much explained here : https://c4model.com/#SystemLandscapeDiagram

https://github.com/backstage/backstage/issues/4394

Is this something you would like to contribute? :pray:

sure @benjdlambert, you can assign to me.

Does it make sense to make use of the existing dependsOn and dependencyOf relations
Refering to the C4 System Landscape Diagram, these relations can be defined as below.
apiVersion: backstage.io/v1alpha1
kind: System
metadata:
  name: atm-system
  title: ATM
  description: Allows customers to withdraw cash.
spec:
  owner: atm-team
  domain: customer-services
---
apiVersion: backstage.io/v1alpha1
kind: System
metadata:
  name: email-system
  title: E-mail System
  description: The internal Microsoft Exchange e-mail system.
spec:
  owner: customer-interactions-team
  domain: customer-interactions
---
apiVersion: backstage.io/v1alpha1
kind: System
metadata:
  name: internet-banking-system
  title: Internet Banking System
  description: Allows customers to view information about their bank accounts, and make payments.
spec:
  owner: core-banking-team
  domain: personal-banking
  dependsOn:
    - system:atm-system
    - system:email-system

If this sounds OK, I can raise a PR to make changes here
Also, does it make sense to use the metadata field defined in relation (reserved for future) for further describing the relation as per C4 model ? Reference here

Also possibly related: #7109 . In that ticket we discuss the value of automatically generating these relations, whenever one of the deeper components/apis reference others across systems.

Also, does it make sense to use the metadata field defined in relation (reserved for future) for further describing the relation as per C4 model ? Reference here

We can't make a metadata field for relations at this point; there's no support for that and internally we do deduplication of relations and stuff like that. So there's some architectural/design challenges to solve before we could get to that point. Also in basically all places where a relation is actually declared, such as in the spec of entities, there's just no nice room to put in a description text :)

introduce a new relations :  uses and usedBy ?

I think the existing dependsOn and dependencyOf express the same intent so to speak - the overlap is large enough for those two wordings, in my mind, that it's just as well that we keep the "depend" wording only.


Questions.yaml support

Questions.yml support
Need a nice Cluster Catalog form

Datatypes that are working:
String
Int
Bool
Enum
Hostname
Multiline
Password
The remaining types and validation should be: https://github.com/rancher/dashboard/issues/1097

This feature is validated on rancher:master-198ec5bdf52d3ed2b4865cfcf6ac1d61150bf55f-head HA setup
All the abovementioned types are recognized properly by the UI in the dashboard

String
Int
Bool
Enum
Hostname
Multiline
Password


Identified Poor Performance when tapping TextField

I have been working in a blog tutorial The ULTIMATE Guide for Building RTA.
Here is the code
In general I have had a great experience working with NativeScript-Angular, most of the times the app runs smoothly, I have managed to implement an overall good performance, I release memory when moving off sections, I use a singleton Socket connection, unsubscribe from any observable and use ListViews instead *ngFor.
But... Since the first chapter, I have been noticing that when you tap a TextField within the application in order to write something.. many -but not all of the- times the app slows while showing the keyboard.
This has been happening from the very fist section -login/register- before any HTTP Request or Socket connection is made, basically there is nothing in memory and still, when you tap on TextFields the app is unstable.
It is quite strange, because it is much more stable while navigating through sections, animations are smooth, TabView is great, ListView is awesome... But tapping in TextFields sometimes concerns me.
This is happening in any device / emulator running android.
I understand it may happen in an emulator, but the Samsung S6 has a pretty good performance, so I don't think showing the keyboard should be that heavy to sometimes kill the app.
I will be looking forward for updates over this thread.
UPDATED: the {N} example app does not present that problem, but I see is not in the angular version, so may be something related with the 2 way data binding?? not sure.. I will test with different bindings.
Cheers,
@jonathan-casarrubias

I found that removing the ng2 2 way data binding actually improves the performance, the keyboard loads smoother

Today I updated everything in my example project to RC4 and nativescript-angular 0.2.0 and I have to say I'm very exited to see the improvements in terms of performance, everything is so smooth now, I will close this issue, since I tried again 2 way data binding and the app is not getting slow anymore


SCSS class renaming does not work for nested classes

Describe the bug
SCSS class names like .open within the nested structure
<style lang="scss">
  .select {
    &.open {
      display: block;
    }
  }
</style>

should work when selected individually, such as addressing open.
Reproduction
Having a CSS class open inside a component that is applied conditionally to a div like
<div class="select" class:open={isOpen}>

with the SCSS rule
<style lang="scss">
  .select {
    &.open {
      display: block;
    }
  }
</style>

does not work as expected. Adding global like
<style lang="scss" global>

solves the problem, which suggests that the class .select.open is not handled properly.
Logs
No response
System Info
System:
    OS: macOS 12.3.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 22.43 GB / 64.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 17.8.0 - /opt/homebrew/bin/node
    npm: 8.5.5 - /opt/homebrew/bin/npm
  Browsers:
    Chrome: 100.0.4896.75
    Safari: 15.4

Severity
serious, but I can work around it
Additional Information
No response

What CSS is this getting preprocessed to?

With global option on, it is compiled to
.select.open {
  display: block;
}

does not work as expected

What do you mean "as expected"?
Do you expect other output than .select.open { display: block; } ?
I'm using latest SvelteKit version (next.320) and it's working fine.

Please provide a reproduction, or I'll have to close this issue. See https://github.com/sveltejs/kit/blob/master/.github/ISSUE_TEMPLATE/bug_report.yml


Fix typo in stable from README

Any updates?

Merged at https://github.com/sorenisanerd/gotty

this is still unresolved :|


fields.Url docs incorrect in "Intermediate Usage"

See #383.
Also, the docstring itself is rather lacking in clarity.

what is the correct usage? i can update it in the docs

this is the correct usage of fields.Url. this is incorrect. fields.Url does not accept a format string as shown in that example

Fixed by #406


BAEL-1326 default methods in interfaces

Oops, submitted wrong branch for this change, closing the PR.


complie_commands.json generated by node-gyp doesn't be in clangd search path.

https://clangd.llvm.org/installation.html#project-setup

clangd will look in the parent directories of the files you edit looking for it, and also in subdirectories named build/. For example, if editing $SRC/gui/window.cpp, we search in $SRC/gui/, $SRC/gui/build/, $SRC/, $SRC/build/, …

$ node-gyp configure -- -f compile_commands_json

will generate build/Release/compile_commands_json and build/Debug/compile_commands_json. both of them don't be searched by clangd. Can we provide a build/compile_commands_json which content is just same as build/Release/compile_commands_json or build/Debug/compile_commands_json to make clangd can find it? It should be easy.
Thanks!

To clarify, can you please add a symlink between the existing and desired files and then tell us if that placates clangd?  If ln -s does not solve this, does a cp do so?

Can node-gyp do this work for users?

Please provide the requested clarification before asking another question.

Please provide

Oh, sorry. :cry:

add a symlink

Yes, clangd don't care build/compile_commands.json is normal file or symlink. It only read its content.

Can node-gyp do this work for users?

The requested ln or cp command would define precisely what this work is.

Can we have a default symlink for Release/compile_commands.json or Debug/compile_commands.json? At least let user can get a out-of-box experience.


r/rust discussion

Not sure if you are the OP so I'm opening an issue to let you know that librips is being discussed on reddit, if you want to chime in:
https://www.reddit.com/r/rust/comments/5fpk9s/rips_rust_ip_stack/
Nice work :)

Thank you. yes, I noticed! Great with some attention :)


Link to sort grid

Is possible to create link to sort grid outside grid? I need to display buttons in template with defined sorting.
Thanks.

You can cheat it some way. But there are no native mathods to get these links.


Allow caching of authorization request

This pull requests adds a generic parameter to the construct option to provide an existing authorization object and allows you to get the authorization details from an existing connection. This way it is possible by the user to implement their own caching mechanism.
Example usage with Redis caching could be:
// Check if we have an authorization object available in Redis
$redis = \Redis::getInstance();
$auth = $redis->get('b2_auth');

if(!empty($auth)){

	// If available, decode object and use to init library
	$auth = json_decode($auth, true);
	$this->client = new \ChrisWhite\B2\Client(B2_ID, B2_KEY, ['authorization' => $auth]);

} else {

	// If not, generate init with new authorization request and save to Redis afterwards
	$this->client = new \ChrisWhite\B2\Client(B2_ID, B2_KEY);
	$authorization = $this->client->getAuthorization();

        // Save authorization object to Redis, expire in 23 hours so we don't use any expired tokens
	$redis->set('b2_auth', json_encode($authorization, JSON_UNESCAPED_SLASHES));
	$redis->expire('b2_auth', 60 * 60 * 23);

}

I do not know what to think of this. I understand the need, however, the implementation bothers me.
With the current deisgn, you have to provide the tokens from outside the library, meaning you have to do the authorization somewhere outside of the library as well.
Plus, this methods is not handling the potential timeout of a token. (Each token is provided with an expiration date). I have a personnel implementation that inject a CacheInterface . (as defined in PSR) and handles the expiration date and parallelization. (You cannot create more then 10 tokens in parallel).
Will check how much of it, I can open-source/publish.

@iammichiel I choose explicitly for the current design as to make it as generic as possible so everybody can choose their own caching method.
Authorization doesn't happen outside the library, you can only retrieve the authorization token after the initial connection and insert it into the library again at a later time.

@OscarEriksen A cache adapter plugin possibility and the cache adapters themselves require a much bigger overhaul and limit the freedom to use whatever the user want. I agree that that would be better and the ideal situation, but looking at this repo's activity and actual contributions i doubt how realistic it is that we will be getting that in the near future. At least this pull request will allow some sort of caching by users without forking the repo.

I agree with you. It's a nice quickfix and opens up for further development. @cwhite92 input?
If anyone wants to create a fork (seeing as the current maintainer doesn't really have time, no hard feelings) and work on an up-to-date php-library for Backblaze where the aim is to cover issues such as this, then I'd like to join in. And I think Backblaze would be greatly appreciative of it as well.

I forked the repo and merging the PRs in there. You can access it here: https://github.com/tarikozket/b2-sdk-php


Tag people and places in LHOM ch. 11

@LukasFrosch I've updated your branch (tag-names-with-URIs/lukasfroschmeier) so that it now has the latest version of ch. 11. Please make sure you do Fetch origin and Pull in the Github Desktop app before you start tagging.
You should commit your latest changes and push/synchronize your branch at least once per day when you're working on it.
For guidelines, see https://github.com/usaybia/usaybia-data/wiki/Tagging-people-and-places. Also there were some questions answered in #37.
Thanks!

@LukasFrosch please see my minor changes and line-by-line comments at https://github.com/usaybia/usaybia-data/commit/358c78e355e5170e91bdbd9a2c9a90180f9c9553# and https://github.com/usaybia/usaybia-data/commit/f1a0e70f39bc7b17ed1aad096e9b81ac7d650041
This is looking very good so I won't check the future tagging at the same level of detail. But don't hesitate to ask questions!


StashboxContainer.Resolve missing

The documentation in the readme says to use "var wulfgar = container.Resolve();" to resolve a dependency but the method Resolve is missing from the StashboxContainer.Resolver.cs

User error in upgrading from a very old version. Sorry about that.


Team update: @rajkumar42

/cc @rajkumar42
Mind reviewing? Twitter handle maybe?
See: https://git.io/vK4iS
Thanks!

LGTM! I don't have a twitter account yet.


Pycom ftp

Do you happen to know where the source for the FTP
server used in pycom?

For Pycom it is here: https://github.com/pycom/pycom-micropython-sigfox/tree/Dev_release_v1.20/esp32/ftp
For MicroPython, there is a ftp server in the cc3200 Port: https://github.com/robert-hh/micropython/tree/w60x/ports/cc3200/ftp
There is also branch for the Winner W60x chip supported by me which also has a ftp server, where the implementation is a little bit simpler: https://github.com/robert-hh/micropython/blob/w60x/ports/w60x/tools/ftpserver.c

Thanks. Some how the only portion of that repo I didn’t look at was  sigfox

Line 217 explains it:
{ "May" }, { "Jun" }, { "Jul" }, { "Ago" },
Should be Aug
I guess I’ll post a pull reassert.
Thanks again

Pycom does not maintain these products any more. You can make a PR, but most likely it will ne ignored.


feat(ndt): remove ndt package

Description
Remove ndt package.
The package was intended to provide a unique interface for various types of NDT implementation (like ndt_omp or pcl ones), but in real current Autoware is designed to use ndt_omp implementation. (e.g. the parameters are only designed for ndt_omp). In addition, as far as we know, NDT implementations other than ndt_omp does not seem to be used.
Thus, I propose to remove ndt and ndt_pcl_modified packages to simplify the localization module and especially ndt_scan_matcher.

Related links
[proposal] Removing NDT implementations other than ndt_omp

Tests performed
I have ran Autoware with the sample data from tutorial, and confirmed that the localization module works fine.

Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Thank you for great PR!!
I built and tested your branch, and the NDT worked successfully.
I'll check out the details soon.

There is still a description about OMP in ndt_scan_matcher/config/ndt_scan_matcher.param.yaml#L25.

There is no default value for converged_param_type in tier4_localization_launch/config/ndt_scan_matcher.param.yaml.
(On the other hand, ndt_scan_matcher/config/ndt_scan_matcher.param.yaml has the default value)

There is no description of converged_type in the ndt_scan_matcher/README.md.
If you don't mind, could you add something like following?

Type of termination criteria for iterative calculations (0=TRANSFORM_PROBABILITY, 1=NEAREST_VOXEL_TRANSFORMATION_LIKELIHOOD)"

@YamatoAndo I am not the owner on this branch and cannot give final approval.
Could you please review this PR in your free time?
(In the main branch I am the owner of ndt_scan_matcher , but this PR is derived from before that.)

I think it depends on this one
https://github.com/autowarefoundation/autoware.universe/pull/2118

Oh, I think this PR is blocked since @.YamatoAndo is the only code owner of ndt package (which will be removed with this PR).
@YamatoAndo Would you also approve this PR?


Pass JSON example data to components / snippets

We need to offer a way to pass in JSON data to fill the component with example data.

Yep! :)
Yet, I just noticed this: What if we have multiple snippets in one document. How do we determine what data goes into which snippet.
We could argue that you probably might only need one data file per document, because that document would only cover a component and its variants. So it would not need different data sets and we could implement a simple convention.
But actually I want to be free to create documents which cover different topics ...
I think it is probably the business of the language processor to be able to choose the data sources so it would need the ability to know about the location of the sources. What do you think?

But actually I want to be free to create documents which cover different topics ...

I agree, we should not restrict people artificially. That's one of the things that is annoying in existing solutions.

I think it is probably the business of the language processor to be able to choose the data sources so it would need the ability to know about the location of the sources.

Can you describe this in more detail? How would the language processor do that?

When adding components into the documents via codeblock, aiur can't really know which components get imported by the templating language in that block. You might want to use different data blobs for different components, though.
For JS languages this is no problem as it's obvious to just import data right from there - but what about other languages as Thymeleaf or Handlebars, etc ... ?
I was thinking that you could add some metadata to Thymeleaf templates or add HTML comments in Handlebars templates for example. The language processor would need to know a little bit more about the locations I think.

Instead of making aiur distinguish which data is provided to which snippet, why not let snippets decide themselves?
data:
    abc123:
        title: Hello World

lorem {{id}}

Fractal

Where is that data put? In a YAML beside the document?
Ah, I think what's missing regarding my thought: I was actually thinking about using the production templates/components in the styleguide but providing them with different data to present different states or so... So the variables in the templates would have the same names but different data would have to be provided.
But for certain templating languages actually yes, they can handle that themselves.

I was assuming some sort of adjacent YAML/JSON/… file, as with Fractal.
Personally, I wouldn't recommend (re)using application templates within the pattern library, as that creates coupling we (I) actually wanna avoid - though I can certainly see the appeal. (FWIW, in a recent presentation, Brad Frost briefly mentions that he doesn't like that approach in the Storybook community.)


@jthieba  Thank you very much.

@jthieba  Thank you very much.
I believe I tried it before but I don't know/remember why it didn't work.
Anyway, it works now.
Originally posted by @shahwan42 in https://github.com/coreui/coreui-free-vue-admin-template/issues/88#issuecomment-394156768
How did you solve it?

The previous comment in the same thread solved the issue for me at that time. I no longer use the coreui template and I don't know how it could be solved now.

Thank you.


Select on('change') fires twice and one of the times with an empty value

Code example:

$(() => {

    $('select').on('change', e => {

        const $this = $(e.currentTarget)

        console.log('value:', $this.val())

    })

})

When changing the select once, the following outputs in console:
value: test-value
value:

The second time it fires, the value is simply not empty, which can break your script if you don't add the following checker:
if ($this.val().length === 0) return

Do you have jQuery required twice? This has happened to me before if jQuery is included twice in your code base.

No, only once:
    <script src="../node_modules/jquery/dist/jquery.js"></script>
    <script src="../node_modules/materialize-css/dist/js/materialize.js"></script>

Are you sure that nothing else has required jQuery on it's own? Other dependencies, which in them selves require the library will bind all events twice.

Yes, the only thing that requires jquery in my project is materialize itself, which is odd, since you have to manually add it on your own.

Can't seem to reproduce this. Can you post your code? Maybe you added multiple listeners to the change event?

@jonasroessum Try making following change and see if it helps
$(() => {

    $('select').off('change').on('change', e => {

        const $this = $(e.currentTarget)

        console.log('value:', $this.val())

    })

})

I had this same exact issue and ended up here.
if ($this.val().length === 0) return
this solves it, but seems abit unnecessary.

I had this problem with my code
$('.myClassName').on('change', function(){
  console.log($(this).val());
});

which fired twice like the OP said. One with the value and other one empty. Reason that happens is because materialize creates a div that you actually interact with and hides the select element. The div has the same class so the onChange applies to the div as well. My solution was
$('select.myClassName').on('change', function(){

or you could use an ID, I haven't tested that.

Try this:
$('.select-wrapper.your_classe_name li').on('click', function(){         console.log($(this).text()) });

As @VeeK727 said, you should only be applying the change event handler to the original select

You got event fired twice because you have two dynamically created material select in your page, each time when you create material select you are calling $('select').on('change', e => {}) which is resulting events to be attached to material select. If you had three material select created then event would have fired thrice.
I prefer to remove all the prior events attached to material select and then attach a new event.
$('select').off('change').on('change', e => {}) seems the clean way. I was using vue.js template repeater with mcss and came across same issue.

9

9

For those who may coming from a Livewire Laravel background and experiencing the same issue, it could be caused by @push @endpush because if you use the component multiple times on the same page, you end up with duplicated script, so the solution could be:
@once
    @push
     // your scripts
     <script>
      .....
     </script>
    @endpush
@endonce


Adding extra data to preexisting table error

When adding rows from an Excel sheet to a preexisting table within a database, one is presented with an error along the lines of:
Error uploading data: 'float' object has no attribute 'lower'

I think I got this too, today is gonna be a good day


Display network type in network overview

Display "VPC Tier" as type if an isolated network belongs to VPC
else display its regular type

Backend changes are in https://github.com/apache/cloudstack/pull/4483

For now, moved to 1.1 as this is not a blocker or critical issue.

@rhtyd @GabrielBrascher I made changes to display vpcname in a new coloumn with a router link to it.
I also made changes to display the domain name as well

Backend changes merged. Moving to 1.0

@davidjumani merging this as Primate 1.0 has become too much dependent on 4.15 (esp. the VM deployment form) and we should encourage backward compatibility from 4.15 onwards. The backend PR will make into 4.15.
@ravening any separate PR to address David's concern is welcome!


Migration Tool: Only list files in migration tool project option that actually can be migrated

Overview
On Migration Window, when trying to migrate entire project using the "Add Full Project for Migration" button, Migration tool lists all files of the project which is not a great user experience, as it's uncertain to the user if all their files will be affected by the upgrade.
It would be better to just list the files that actually contain the components we're planning to upgrade. That would also make the list shorter, make it easier to filter files and give a better overview before pressing the migration button.
This is part of Migration Tool graduation.
Changes
Tool goes through object hierarchy checking if migration is supported on any of the hierarchy objects. Only show upgradeable files in that list.
Before:

After:

Fixes: #7690 .

@thalbern answering your question about double check of CanMigrate. A cache of the game objects would be needed. I might be wrong, but  we can't hold references to gameobjects in the scenes or prefabs. Only way to access those is to open scene by scene and prefab by prefab. reference is lost when unloading.

/azp run


cannot import name 'WinDLL' from 'ctypes' (/usr/lib/python3.9/ctypes/init.py)

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az network bastion rdp Extension Name: bastion. Version: 0.2.3.
Errors:
Paste here the error message you have received. Make sure to remove all sensitive information,
such as user name, password, credential, subscription ID, etc.

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az network bastion rdp --name {} --resource-group {} --target-resource-id {}

Expected Behavior
Environment Summary
Linux-5.4.0-1104-azure-x86_64-with-glibc2.35 (Cloud Shell), CBL-Mariner/Linux
Python 3.9.14
Installer: RPM

azure-cli 2.46.0

Extensions:
bastion 0.2.3
ai-examples 0.2.5
ml 2.14.1
ssh 1.1.3

Dependencies:
msal 1.20.0
azure-mgmt-resource 21.1.0b1

Additional Context

Command group 'az network' is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus
The command failed with an unexpected error. Here is the traceback:
cannot import name 'WinDLL' from 'ctypes' (/usr/lib/python3.9/ctypes/init.py)
Traceback (most recent call last):
File "/usr/lib64/az/lib/python3.9/site-packages/knack/cli.py", line 233, in invoke
cmd_result = self.invocation.execute(args)
File "/usr/lib64/az/lib/python3.9/site-packages/azure/cli/core/commands/init.py", line 663, in execute
raise ex
File "/usr/lib64/az/lib/python3.9/site-packages/azure/cli/core/commands/init.py", line 726, in _run_jobs_serially
results.append(self._run_job(expanded_arg, cmd_copy))
File "/usr/lib64/az/lib/python3.9/site-packages/azure/cli/core/commands/init.py", line 697, in _run_job
result = cmd_copy(params)
File "/usr/lib64/az/lib/python3.9/site-packages/azure/cli/core/commands/init.py", line 333, in call
return self.handler(*args, **kwargs)
File "/usr/lib64/az/lib/python3.9/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
return op(**command_args)
File "/home/allen/.azure/cliextensions/bastion/azext_bastion/custom.py", line 229, in rdp_bastion_host
from ._process_helper import launch_and_wait
File "/home/allen/.azure/cliextensions/bastion/azext_bastion/_process_helper.py", line 9, in
from ctypes import WinDLL, c_int, c_size_t, Structure, WinError, sizeof, pointer
ImportError: cannot import name 'WinDLL' from 'ctypes' (/usr/lib/python3.9/ctypes/init.py)
To check existing issues, please visit: https://github.com/Azure/azure-cli/issues
To open a new issue, please run az feedback

route to CXP team

@AllenOnAzure Can you please look into this similar issue which talks about alternative approaches of using tunnel command of linux OS.  Please find below a part of the discussion -

Also, note that RDP command works best on Windows, for other OS’ (like Linux) you can do the tunnel command and then use the client of your choice.
Connect to a VM using the az network bastion tunnel command. This lets you do the following:
Use native clients on non-Windows local computers (example: a Linux PC).
Use the native client of your choice. (This includes the Windows native client.)
Connect using SSH or RDP.
Set up concurrent VM sessions with Bastion.
Upload files to your target VM from your local computer. File download from the target VM to the local client is currently not supported for this command.
Currently, this feature has the following limitation:
Signing in using an SSH private key stored in Azure Key Vault isn’t supported with this feature. Before signing in to your Linux VM using an SSH key pair, download your private key to a file on your local machine.

Please let me know if you still have questions. Thanks.

@AllenOnAzure Please let us know if you are still facing this issue. Thanks.

@AllenOnAzure We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


fix: missing parenthesis on validateEnginePath

missing parenthesis for the engine path validation https://github.com/Disservin/fast-chess/blob/2a4ffaf57857df102dad4a1efb51106190fbd0c7/app/src/engine/uci_engine.cpp#L183
issue https://github.com/Disservin/fast-chess/issues/528

@vondele does this fix it?

yes

hmm, not sure, I have 'Warning; Engine New-ee6fc7e38b4aeef44862159215a56d97122f59a0 disconnects' .. might be related to this.


DNN-3000: add enable/disable cache expiration api.

This was reverted as the code change should have been made in the 8.0 branch.
I have manually done the correct merge.


Leaflet version and version lock [FOR PLUGIN DEVS  / USERS]

After two days of debugging I finally managed to grasp an issue that I was having on some personal projects ( vue people and others ).
As it stands leaflet used to export itself to the window object, in more recent version they also have an es6 module version.
Most of the leaflet plugins uses the window object so they keep exporting it.
Now there are some edge cases that completely breaks both vue2-leaflet and the plugins if there is a mismatch version from what version vue-leaflet declare is different from the one declared both in the vue-leaflet-plugin and the leaflet-plugin.
I'll make an example with markercluster plugin.
vue-leaflet declare as dependency leaflet: 1.3.4
leaflet.markercluster declare as dependency: leaflet 1.3.1
They are just patch releases so it should be all fine.
What happens instead is that webpack see the two differences and load two leaflet instances.
now everything still works MINUS when:
leaflet markercluster declare a new class say: const a = new LatLngBounds([lat, lon]).
and then uses the leaflet method to check if that bound intersect with other markers.
Since that method check a instanceof LatLngBounds and that LatLngBounds is coming from a DIFFERENT leaflet instance that check will pass false and then everything will start behaving bad / breaking
Everything is fine if all the leaflet versions are set at the same since only one distance of leaflet is instantiated.
@jperelli
EDIT FOR CLARITY:
A solid workaround for this is to use Aliases to point to a single leaflet root instance, for example in nuxt 1.x ( I believe 2.x too )  one would do:
build: {
  extend(config){
    config.resolve.alias['leaflet'] = path.join(__dirname, 'node_modules/leaflet');
  }
}

This explains the problem: https://lexi-lambda.github.io/blog/2016/08/24/understanding-the-npm-dependency-model/
Why use peer dependencies https://stackoverflow.com/questions/26737819/why-use-peer-dependencies-in-npm-for-plugins

Adding unit tests with different leaflet versions would be nice too, to help find out about problems

@lordfuoco Making the same version of leaflet is not solving the issue

@imudin To understand your problem can you please post down all the version of the leaflet related repo that you are using ?

@lordfuoco Now I works. I was using vue2-leaflet-path-transform locally. I  added it to my main project in this way npm i /path/to/vue2-leaflet-path-transform. After I published the plugin with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>it is working. Even I updated leaflet of main project to v1.3.4.

@imudin Great! So you are the author of vue2-leaflet-path-transform?
if so please state leaflet as a peerDependecy in your repo ( or not at all ) so that we can avoid this issue in the future

@lordfuoco Okay I will! thank you for your time 👍

Finally! I was getting a frustrating error whenever I tried to add polylines dynamically.
This workaround fixed it, @lordfuoco could this be added to the docs as a special note? I think it'd help save a lot of people (like me) time with debugging

@ciolt a PR would help :) I am bit swamped with work and behind here

Hi,
I'm using Nuxt 2.4.5 (last version), and I have the error "Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'" when the mouse hover a marker.
I  tried to put the workaround alias but it doesn't work
build: {
    extractCSS: true,
    vendor: ["vue-notifications"],
    extend(config) {
      config.resolve.alias["leaflet"] = path.join(
        __dirname,
        "node_modules/leaflet"
      );
    }

The build says

ERROR  path is not defined

@kaboume Add const path = require('path'); at the very top of the same file

Thank you!
After executed "npm install --save path" and added "const path = require("path");" at the top of the nuxt.config.js file, everything works fine.

@ciolt @kaboume did you try the new 2.0 ? it should fix the issue without workaround

No I didn't. I will try. Thank you.

since 2.x is out since a while closing this


PTX Backend reporting error code 701 when dispatching cuLaunchKernel on NVIDIA 30XX GPUs

Describe the bug
When running with the PTX backend on NVIDIA 30XX GPUs (e.g., 3070), kernel dispatch fails due to error 701.
[TornadoVM-PTX-JNI] ERROR : cuLaunchKernel -> Returned: 701

Following the NVIDIA documentation, this error means CUDA_ERROR_LAUNCH_OUT_OF_RESOURCES
link

This indicates that a launch did not occur because it did not have appropriate resources. This error usually indicates that the user has attempted to pass too many arguments to the device kernel, or the kernel launch specifies too many threads for the kernel's register count. Passing arguments of the wrong size (i.e. a 64-bit pointer when a 32-bit int is expected) is equivalent to passing too many arguments and can also result in this error.

Possibly this is related to the number if threads in the case of TornadoVM. Note that this error cannot be reproduced on older GPUs (e.g., 2060, 1050, etc), or the OpenCL backend running on the same 30XX GPU.
NVIDIA Driver used: 510.60.02
How To Reproduce
$ make BACKEND=ptx
$ tornado -Ds0.t0.device=0:0 --printKernel -m tornado.examples/uk.ac.manchester.tornado.examples.compute.MatrixMultiplication2D

Expected behaviour
A clear and concise description of what you expected to happen.
Computing system setup (please complete the following information):

OS: Fedora 36, NVIDIA Driver 510.60.02
OpenCL Version: 3.0
7.6
TornadoVM commit id: https://github.com/beehive-lab/TornadoVM/commit/5e5fbbc8cc2e79f3ecb87c32dedfec48d0f6b44d

Related issues: #194

Just an update:
After some debugging, we realised this error is due to a bug on new GPUs and drivers in regards to the cuLaunchKernel and the parameter list. The size of some parameters is not correct. This used to work (and still works) on GPUs running with drivers <= 510 in the current develop, which assumes all values (objects and primitives) as long types.
We need to update the logic to compute the parameter list within the runtime-system of TornadoVM.

New update:
We provide a fix for the data types by passing exactly but buffer sizes needed. However, some other applications throw a CUDA_ERROR_MISALIGNED_ADDRESS (716) error during cuEventCreate. This error can be also reproduced on older GPUs such as 2060 with the 510.46 NVIDIA driver.
As an alternative solution, we propose redesigning how arguments are handled within the TornadoVM runtime. Instead of passing the arguments using the extra argument fromcuLaunchKernel, we suggest filling the argument list.
More info:
https://developer.download.nvidia.com/compute/DevZone/docs/html/C/doc/html/group__CUDA__EXEC_gb8f3dc3031b40da29d5f9a7139e52e15.html
We will schedule this change for the next release.
Meanwhile, the OpenCL backend still works on new GPUs with new NVIDIA drivers.

Partial fixes for solving this issue have been merged.


Python 3.10 only syntax breaks extension in older Python versions

I'm referring in particular to install.py:
https://github.com/adieyal/sd-dynamic-prompts/blob/72f21dea4d1a31b0cd496a472a30c3d2ce96501d/install.py#L23
This syntax is Python 3.10 only, which means the extension won't work on platforms that don't have Python 3.10 (for example Google Colab or Paperspace).

Saving ngrok auth token to ~/.ngrok_token
/home/studio-lab-user/SageMaker/stable-diffusion-webui
Python 3.9.16 | packaged by conda-forge | (main, Feb  1 2023, 21:39:03)
[GCC 11.3.0]
Version: v1.2.1
Commit hash: 89f9faa63388756314e8a1d96cf86bf5e0663045
Installing requirements
Error running install.py for extension /home/studio-lab-user/SageMaker/stable-diffusion-webui/extensions/sd-dynamic-prompts.
Command: "/home/studio-lab-user/.conda/envs/default/bin/python" "/home/studio-lab-user/SageMaker/stable-diffusion-webui/extensions/sd-dynamic-prompts/install.py"
Error code: 1
stdout:
stderr: Traceback (most recent call last):
File "/home/studio-lab-user/SageMaker/stable-diffusion-webui/extensions/sd-dynamic-prompts/install.py", line 23, in
def split_package(requirement) -> tuple[str, str | None, str | None, str | None]:
TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'

Thanks for raising the issue - that's probably the reason many of the collab installations are not updating the dependency. Fixed in 2.11.4


timeout parameter for disk export

just suggestion, some disk might takes extra time to finish the job.
gcloud alpha compute images export

-timeout=TIMEOUT; default="2h"
Maximum time a build can last before it fails as "TIMEOUT". For example, specifying 2h fails the process after 2 hours. See $ gcloud topic datetimes for information about duration formats.

good suggestion, I will take care of it. Thanks


Camel ftp integration test updated

This PR is based on what has been done for camel-jetty + containers introduced by @lopushen .
It uses the mock  and test both producer and consumer of the ftp component.

This PR no longer makes sense


tidy-requires: module paths w/in require subforms should sort

This suggestion conflicts with this racket-review rule which ensures that uses of require subforms sort according to their module path. Another example can be found here.

I agree with this, and others have mentioned the possibility to me too. But I'd also like to keep Resyntax and racket-mode in sync when it comes to require tidying. I'll reach out to Greg to discuss this.

This sounds good in principle. I'd need to reload my brain with details about multi-in; the other clauses seem straightforward. I'll comment back here later...

So actually. Having finished my first coffee. I realized that racket-tidy-requires already works the way you described in your email, as in your example:
(require a
         b
         c
         (only-in a/extra x))

becomes
(require a
         (only-in a/extra x)
         b
         c)

Was there maybe some other example where it does not? Maybe I have a bug in some cases. If so, I'll fix. But the intent is definitely to sort by module (within each meta level).
TL;DR: I think you could go ahead and change resyntax to sort that way, and if some bug turns up, then it's on me to fix that.

Ah, I was going off the description here rather than actually installing racket-mode and seeing what it does, since I'm not an emacs user. What does it do if the require subform doesn't contain a single collection in it? Like (prefix-in foo: (combine-in a b c)), for example.

Review didn't support combine-in at all (because I never use it), so I just added it:
https://github.com/Bogdanp/racket-review/commit/6ce349fabb80ec565c7cc22b74cf16bcd3fbed8c#diff-dd9e24dda16c8ecc44babd298601cf79cbe4cd068711b7e6f8b8135691492e2a
Running tidy requires on that same file results in:
#lang racket/base
(require (prefix-in combined: (combine-in threading))
         (combine-in)
         racket/string
         (prefix-in combined: (combine-in threading racket/base)))

Ah, I was going off the description here rather than actually installing racket-mode and seeing what it does, since I'm not an emacs user.

Although that's intended as user docs, not a full spec, it is ambiguous; I can improve that.

What does it do if the require subform doesn't contain exactly one collection in it? Like (prefix-in foo: (combine-in a b c)), for example.

It's not even attempting to handle combine-in, yet.
I started a branch last week to refactor some of this (very old) code of mine, looking at the require grammar.
Among other things, I did add combine-in -- but I didn't consider the empty (combine-in) case. Thanks for pointing it out!
My instinct is to prune empty (combine-in) clauses. Although "tidy" shouldn't try to prune unused imports -- that's the job of a "stronger" command in Racket Mode, that runs the unused requires analysis) -- pruning no-meaning, no-op "import nothing" clauses like (combine-in) is probably OK or in fact desirable. What do you think?

Generally: It looks like I should re-read the grammar carefully, looking for any more edge cases or bad assumptions.

Perhaps the three of us ought to standardize on a shared implementation? A minimal-dependency package that we all reuse would get rid of any inconsistency problems.

I'm also not opposed to code sharing. But ATM I'm rewriting some of the old code. So that it still passes the old tests. But also handles some holes like combine-in. And is less smelly, to me, in some spots.
When the dust settles, I can touch base re sharing.
Few quick points about that, meanwhile:

My "outer API" is text => test: My Racket back end gets strings from Emacs, and returns strings. That doesn't mean a symbol or even syntax API couldn't be added, as well. But status quo, that's my edge data.

Racket Mode attempts to support old versions of Racket. Currently as old as 6.12.

Racket Mode is installed as an Emacs package, not a Racket package. It doesn't depend on any raco setup. Some optional features work if the necessary libs were installed by the user, otherwise they gracefully-ish don't work. Tidying requires fits fine in this category, I think. Already it needs macro-debugger-lib installed.

For a certain private project I had an infatuation with multi-in, and added support for the simpler flavors of that. That complicates my current code, somewhat, for better or worse.

IMHO what review does is reasonably a "subset" of what resyntax or Racket Mode might do. IOW the latter might format or arrange things in a way that's nice, but doesn't necessarily rise to the level of a code review warning or recommendation. I think?
It's probably more important for resyntax and Racket Mode to be in sync.
Also to be clear, I don't even know how my Racket Mode users actively use racket-tidy-requires, racket-trim-requires, and racket-base-requires. And when a project uses resyntax, my feelings wouldn't be hurt if the project forbid using those Racket Mode commands on source code, and lets resyntax prevail, when it's being applied to all the code all the time.


Custom Gradient Computation not working in TF 2.14

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
No
Source
binary
TensorFlow version
2.14.0
Custom code
Yes
OS platform and distribution
Linux
Mobile device
No response
Python version
3.10.12
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
I am using W&B's Keras callback WandbCallback. This callback has a feature to log gradients of each layer at every step. This feature works fine till TF 2.13.0 but is erroring out in TF 2.14.0.
This piece of code works fine in Tf 2.13.0 but errors out in TF 2.14.0:
import numpy as np
import tensorflow as tf
print(tf.__version__)
import wandb
from wandb.keras import WandbModelCheckpoint
from wandb.keras import WandbCallback

run = wandb.init(project="keras")

x = np.random.randint(255, size=(100, 28, 28, 1))
y = np.random.randint(10, size=(100,))

dataset = (x, y)

def get_model():
    m = tf.keras.Sequential()
    m.add(tf.keras.layers.Conv2D(3, 3, activation="relu", input_shape=(28, 28, 1)))
    m.add(tf.keras.layers.Flatten())
    m.add(tf.keras.layers.Dense(10, activation="softmax"))
    return m

model = get_model()
model.compile(
    loss="sparse_categorical_crossentropy",
    optimizer="sgd",
    metrics=["accuracy"],
)

model.fit(
    x,
    y,
    epochs=5,
    validation_data=(x, y),
    callbacks=[
        WandbCallback(
            save_model=False,
            log_gradients=True,
            training_data=(x,y)
        )
    ],
)

I investigated further and was able to narrow it down to the gradient logging logic which again works fine for 2.13.0 but not for 2.14.0.
I think this has to do with the breaking changes with tf.Tensor.
The piece of code below is the gradient logging logic which errors out in the latest version.
Standalone code to reproduce the issue
import tensorflow as tf
print(tf.__version__)
import wandb
import numpy as np

_training_data_x = np.random.randint(255, size=(100, 28, 28, 1))
_training_data_y = np.random.randint(10, size=(100,))

def get_model():
    m = tf.keras.Sequential()
    m.add(tf.keras.layers.Conv2D(3, 3, activation="relu", input_shape=(28, 28, 1)))
    m.add(tf.keras.layers.Flatten())
    m.add(tf.keras.layers.Dense(10, activation="softmax"))
    return m

model = get_model()
model.compile(
    loss="sparse_categorical_crossentropy",
    optimizer="sgd",
    metrics=["accuracy"],
)

def _get_custom_optimizer_parent_class():
    from pkg_resources import parse_version

    if parse_version(tf.__version__) >= parse_version("2.9.0"):
        custom_optimizer_parent_class = tf.keras.optimizers.legacy.Optimizer
    else:
        custom_optimizer_parent_class = tf.keras.optimizers.Optimizer

    return custom_optimizer_parent_class

_custom_optimizer_parent_class = _get_custom_optimizer_parent_class()
print(_custom_optimizer_parent_class)

class _CustomOptimizer(_custom_optimizer_parent_class):
    def __init__(self):
        super().__init__(name="CustomOptimizer")
        self._resource_apply_dense = tf.function(self._resource_apply_dense)
        self._resource_apply_sparse = tf.function(self._resource_apply_sparse)
        tf.print(self._resource_apply_dense)

    def _resource_apply_dense(self, grad, var):
        var.assign(grad)

    # this needs to be implemented to prevent a NotImplementedError when
    # using Lookup layers.
    def _resource_apply_sparse(self, grad, var, indices):
        pass

    def get_config(self):
        return super().get_config()

class _GradAccumulatorCallback(tf.keras.callbacks.Callback):
    """Accumulates gradients during a fit() call when used in conjunction with the CustomOptimizer above."""

    def set_model(self, model):
        super().set_model(model)
        self.og_weights = model.get_weights()
        self.grads = [np.zeros(tuple(w.shape)) for w in model.trainable_weights]

    def on_batch_end(self, batch, logs=None):
        for g, w in zip(self.grads, self.model.trainable_weights):
            g += w.numpy()
        self.model.set_weights(self.og_weights)

    def get_grads(self):
        return [g.copy() for g in self.grads]

inputs = model.inputs
print(inputs)
outputs = model(inputs)
grad_acc_model = tf.keras.models.Model(inputs, outputs)
grad_acc_model.compile(loss=model.loss, optimizer=_CustomOptimizer())

_grad_accumulator_model = grad_acc_model
_grad_accumulator_model.summary()

_grad_accumulator_callback = _GradAccumulatorCallback()

_grad_accumulator_model.fit(
    _training_data_x,
    _training_data_y,
    verbose=0,
    callbacks=[_grad_accumulator_callback],
)

weights = model.trainable_weights
grads = _grad_accumulator_callback.grads
print(weights)

metrics = {}
for weight, grad in zip(weights, grads):
    metrics[
        "gradients/" + weight.name.split(":")[0] + ".gradient"
    ] = wandb.Histogram(grad)

print(metrics)

Relevant log output
Traceback (most recent call last):
  File "/home/ayushthakur/client/wandb/test_grad_logging.py", line 88, in <module>
    _grad_accumulator_model.fit(
  File "/opt/conda/envs/tf214/lib/python3.10/site-packages/keras/src/utils/traceback_utils.py", line 70, in error_handler
    raise e.with_traceback(filtered_tb) from None
  File "/tmp/__autograph_generated_file4zq8l42d.py", line 15, in tf__train_function
    retval_ = ag__.converted_call(ag__.ld(step_function), (ag__.ld(self), ag__.ld(iterator)), None, fscope)
TypeError: in user code:

    File "/opt/conda/envs/tf214/lib/python3.10/site-packages/keras/src/engine/training.py", line 1377, in train_function  *
        return step_function(self, iterator)
    File "/opt/conda/envs/tf214/lib/python3.10/site-packages/keras/src/engine/training.py", line 1360, in step_function  **
        outputs = model.distribute_strategy.run(run_step, args=(data,))
    File "/opt/conda/envs/tf214/lib/python3.10/site-packages/keras/src/engine/training.py", line 1349, in run_step  **
        outputs = model.train_step(data)
    File "/opt/conda/envs/tf214/lib/python3.10/site-packages/keras/src/engine/training.py", line 1130, in train_step
        self.optimizer.minimize(loss, self.trainable_variables, tape=tape)
    File "/opt/conda/envs/tf214/lib/python3.10/site-packages/keras/src/optimizers/legacy/optimizer_v2.py", line 601, in minimize
        return self.apply_gradients(grads_and_vars, name=name)
    File "/opt/conda/envs/tf214/lib/python3.10/site-packages/keras/src/optimizers/legacy/optimizer_v2.py", line 760, in apply_gradients
        return tf.__internal__.distribute.interim.maybe_merge_call(
    File "/opt/conda/envs/tf214/lib/python3.10/site-packages/keras/src/optimizers/legacy/optimizer_v2.py", line 844, in _distributed_apply
        with tf.control_dependencies([tf.group(update_ops)]):

    TypeError: 'inputs' should be zero or more (nested) Tensors. Received 'None' with type '<class 'NoneType'>'.

From the Relevant Log Output above, if I remove tf.group from this line File "/opt/conda/envs/tf214/lib/python3.10/site-packages/keras/src/optimizers/legacy/optimizer_v2.py", line 844, in _distributed_apply, the issue seems to be resolved. I am not sure how to properly resolve this issue though, any help would be appreciated.

@ayulockin Thank you for raising this issue!
I was able to replicate the issue on colab using TF v2.14 and nightly. This issue is not appearing in 2.13.
@sachinprasadhs Could you please have a look. Thank you!

Thanks for quickly replicating it @sushreebarsa. Looking for a response from @sachinprasadhs :)

I solved the issue like this:
class CustomSGD(tf.keras.optimizers.legacy.Optimizer):
pass
...
Creating an instance of the custom SGD optimizer
custom_sgd_optimizer = CustomSGD(learning_rate=0.01)
When compiling the model, I added the run_eagerly=True attribute:
model3.compile(optimizer=custom_sgd_optimizer, loss='mse', metrics=['mse', 'mae'], run_eagerly=True)
Then, I trained the model with:
history3 = model3.fit(x, y, epochs=1200)
And it proceeded correctly without any issues.
Hope this helps! 🙂


fix(toast): added the possibility to pick icons from toast

Describe pull-request
Added the possibility to pick icons from toast
Solving issue
Fixes: AB#2583
How to test

Go to storybook link below.
Check in Components -> Toast
Check that the controls for the icons work as intended.

Screenshots
Additional context

Let's check this one with @charlottelorensson :)
Charlotte: Should the user have the option to choose/customize the icon of the Toast component or icons are tightly bounded to the type of component, eg success type === tick icon, warning === triangle icon etc ?


Adding missing DNS entries

Summary | Résumé
We had some missing DNS entries for production, I've added them here, and propagated the equivalent ones in dev. This will also add them to staging.
Related Issues | Cartes liées

https://app.zenhub.com/workspaces/notify-planning-core-6411dfb7c95fb80014e0cab0/issues/gh/cds-snc/notification-planning-core/36

Test instructions | Instructions pour tester la modification
TF Apply works
Verify that the records are the same in SRE AWS DNS
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur

[ ] This PR does not break existing functionality.
[ ] This PR does not violate GCNotify's privacy policies.
[ ] This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
[ ] This PR does not significantly alter performance.
[ ] Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

LGTM but maybe @patheard could give this a once over, he did much of the existing DNS for prod.
Question: will these get created in staging too?

Yeah these will create the equivalent entries in staging. Note that when we release this to prod, it won't actually administer the active notification.canada.ca DNS zone - I have it deploying to a "dummy" DNS zone so that we can compare the two.


Updated ReadMe with latest az cli command info

Fixed outdated command for creating service principals
Summary
Describe your changes here.
Fixes #Issue_Number, dotnet/docs#Issue_Number or dotnet/dotnet-api-docs#Issue_Number (if available)

Done and done... this should be ready to ship 🚀


fix: [Bug]Audio option hidden on edit mode

Description
Fixes #7868
Type of change
Hidden the audio options as per https://github.com/appsmithorg/appsmith/issues/7868#issuecomment-932018289

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.

Test A
Test B

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Does it open a download and playback window after you click the three dots?

@AR10X It does. But not in an obvious position. That's why we decided to completely remove it. Kindly check the issue for more context.

Ok I will try a different solution.

/ok-to-test sha=ff12d76


Local jsbin getting down behind nginx https proxy

Doing everything according https://github.com/jsbin/jsbin/blob/master/docs/nginx-config.md i'm getting error:
TypeError: Cannot call method 'indexOf' of undefined
    at Object.module.exports.protocolCheck [as handle] (/usr/local/lib/node_modules/jsbin/lib/middleware.js:267:34)
    at next (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/proto.js:199:15)
    at Object.handle (/usr/local/lib/node_modules/jsbin/lib/middleware.js:90:7)
    at next (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/proto.js:199:15)
    at Object.handle (/usr/local/lib/node_modules/jsbin/lib/middleware.js:28:7)
    at next (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/proto.js:199:15)
    at Object.handle (/usr/local/lib/node_modules/jsbin/lib/middleware.js:61:9)
    at next (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/proto.js:199:15)
    at Object.handle (/usr/local/lib/node_modules/jsbin/lib/middleware.js:41:7)
    at next (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/proto.js:199:15)
    at Object.handle (/usr/local/lib/node_modules/jsbin/lib/middleware.js:100:7)
    at next (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/proto.js:199:15)
    at Object.handle (/usr/local/lib/node_modules/jsbin/lib/middleware.js:150:7)
    at next (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/proto.js:199:15)
    at Object.handle (/usr/local/lib/node_modules/jsbin/lib/middleware.js:252:9)
    at next (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/proto.js:199:15)
    at /usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/middleware/csrf.js:48:88
    at Object.handle (/usr/local/lib/node_modules/jsbin/lib/middleware.js:111:16)
    at next (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/proto.js:199:15)
    at Object.json [as handle] (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/middleware/json.js:53:37)
    at next (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/proto.js:199:15)
    at Object.urlencoded [as handle] (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/middleware/urlencoded.js:51:37)
    at next (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/proto.js:199:15)
    at Object.cookieSession [as handle] (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/middleware/cookieSession.js:113:5)
    at next (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/proto.js:199:15)
    at Object.cookieParser [as handle] (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/middleware/cookieParser.js:60:5)
    at next (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/proto.js:199:15)
    at Object.handle (/usr/local/lib/node_modules/jsbin/lib/middleware.js:190:7)
    at next (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/proto.js:199:15)
    at resume (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/middleware/static.js:60:7)
    at SendStream.error (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/connect/lib/middleware/static.js:73:37)
    at SendStream.emit (events.js:95:17)
    at SendStream.error (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/send/lib/send.js:147:51)
    at SendStream.onStatError (/usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/send/lib/send.js:248:48)
    at /usr/local/lib/node_modules/jsbin/node_modules/express/node_modules/send/lib/send.js:320:26
    at Object.oncomplete (fs.js:108:15)

My jsbin config:
{
  "url": {
    "host": "<host>",
    "prefix": "/",
    "ssl": true
  },
  "store": {
    "adapter": "sqlite",
    "sqlite": {
      "location": "<db-file-path>"
    }
  }
}

Starting jsbin as:
JSBIN_PROXY=on PORT=3000 jsbin -c /etc/jsbin.conf.json

version on NPM is ancient,
https://www.npmjs.com/package/jsbin
i used one docker image which used global install, it just didn't work. After that we switched to another that used more recent branch from github, this now works, and you can set ssl  to true.
checkout code from github, and build using npm install -d, go into bin folder and start it.
(also use nodeenv or n to run it with old node, 0.10.46 works for me)

I can confirm all the things @kodi said are true :)