feature request: union of arg classes

Let's say we have two data classes, which both are required. E.g. model config and data config.
Would it be possible to arg-parse a union of both?

In type theory, a union represents an "either/or" relationship, but it seems like the scenario you describe requires an "and" relationship. This might be technically possible to acheive using multiple inheritance, but I wouldn't recommend it. It is possible to implement a new class whose fields are copied from both previous classes, and separate them to two different objects after parsing. Finally, you can use simple parsing, which supports nested parsing, and create a class with two fields, one for each previous class.

In type theory, a union represents an "either/or" relationship, but it seems like the scenario you describe requires an "and" relationship. This might be technically possible to acheive using multiple inheritance, but I wouldn't recommend it. It is possible to implement a new class whose fields are copied from both previous classes, and separate them to two different objects after parsing. Finally, you can use simple parsing, which supports nested parsing, and create a class with two fields, one for each previous class.

Wearing with simple parsing looks great, but it doesn't has attrs support ;)
On Tue, Jan 19, 2021, 3:19 PM Roee Nizan<EMAIL_ADDRESS>wrote:

In type theory, a union represents an "either/or" relationship, but it
seems like the scenario you describe requires an "and" relationship. This
might be technically possible to acheive using multiple inheritance, but I
wouldn't recommend it. It is possible to implement a new class whose fields
are copied from both previous classes, and separate them to two different
objects after parsing. Finally, you can use simple parsing
https://pypi.org/project/simple-parsing/, which supports nested
parsing, and create a class with two fields, one for each previous class.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/roee30/datargs/issues/2#issuecomment-762828254, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNDI64VIPCYI4V2QJWKS3TS2WBF7ANCNFSM4WIWK5ZQ
.

Wearing with simple parsing looks great, but it doesn't has attrs support ;)
On Tue, Jan 19, 2021, 3:19 PM Roee Nizan<EMAIL_ADDRESS>wrote:

In type theory, a union represents an "either/or" relationship, but it
seems like the scenario you describe requires an "and" relationship. This
might be technically possible to acheive using multiple inheritance, but I
wouldn't recommend it. It is possible to implement a new class whose fields
are copied from both previous classes, and separate them to two different
objects after parsing. Finally, you can use simple parsing
https://pypi.org/project/simple-parsing/, which supports nested
parsing, and create a class with two fields, one for each previous class.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/roee30/datargs/issues/2#issuecomment-762828254, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNDI64VIPCYI4V2QJWKS3TS2WBF7ANCNFSM4WIWK5ZQ
.

*nesting (autocorrect)
On Tue, Jan 19, 2021, 3:39 PM Yuval A<EMAIL_ADDRESS>wrote:

Wearing with simple parsing looks great, but it doesn't has attrs support
;)
On Tue, Jan 19, 2021, 3:19 PM Roee Nizan<EMAIL_ADDRESS>wrote:

In type theory, a union represents an "either/or" relationship, but it
seems like the scenario you describe requires an "and" relationship. This
might be technically possible to acheive using multiple inheritance, but I
wouldn't recommend it. It is possible to implement a new class whose fields
are copied from both previous classes, and separate them to two different
objects after parsing. Finally, you can use simple parsing
https://pypi.org/project/simple-parsing/, which supports nested
parsing, and create a class with two fields, one for each previous class.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/roee30/datargs/issues/2#issuecomment-762828254, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNDI64VIPCYI4V2QJWKS3TS2WBF7ANCNFSM4WIWK5ZQ
.

*nesting (autocorrect)
On Tue, Jan 19, 2021, 3:39 PM Yuval A<EMAIL_ADDRESS>wrote:

Wearing with simple parsing looks great, but it doesn't has attrs support
;)
On Tue, Jan 19, 2021, 3:19 PM Roee Nizan<EMAIL_ADDRESS>wrote:

In type theory, a union represents an "either/or" relationship, but it
seems like the scenario you describe requires an "and" relationship. This
might be technically possible to acheive using multiple inheritance, but I
wouldn't recommend it. It is possible to implement a new class whose fields
are copied from both previous classes, and separate them to two different
objects after parsing. Finally, you can use simple parsing
https://pypi.org/project/simple-parsing/, which supports nested
parsing, and create a class with two fields, one for each previous class.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/roee30/datargs/issues/2#issuecomment-762828254, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNDI64VIPCYI4V2QJWKS3TS2WBF7ANCNFSM4WIWK5ZQ
.

I don't plan to add nesting support. Please let me know if there's anything else that can be done.

I don't plan to add nesting support. Please let me know if there's anything else that can be done.

No.
Thanks a lot for your quick reply and for the reference about
simple-parsing.
On Tue, Jan 19, 2021 at 5:42 PM Roee Nizan<EMAIL_ADDRESS>wrote:

I don't plan to add nesting support. Please let me know if there's
anything else that can be done.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/roee30/datargs/issues/2#issuecomment-762926536, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNDI63756UVEJQTQNZ4OPDS2WR5PANCNFSM4WIWK5ZQ
.

No.
Thanks a lot for your quick reply and for the reference about
simple-parsing.
On Tue, Jan 19, 2021 at 5:42 PM Roee Nizan<EMAIL_ADDRESS>wrote:

I don't plan to add nesting support. Please let me know if there's
anything else that can be done.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/roee30/datargs/issues/2#issuecomment-762926536, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNDI63756UVEJQTQNZ4OPDS2WR5PANCNFSM4WIWK5ZQ
.


Replace Realm with Room

Realm is quite nice and very easy to work with, however, it has a binary (native) core that noticeably increases the APK size, while being merely a convenience for the programmer (it has no effect on the features or end user experience). Furthermore, this binary core is not open source yet.
Using SQLite was initially an option, however, the amount of boilerplate and lack of compile-time verification of code (as well as auto-complete, etc.) makes using SQLite with the vanilla APIs a bit painful.
Room apparently makes using SQLite much easier, while still being able to harness the full power of SQL (something lost with Realm). It almost certainly doesn't add to the APK size as much, and might actually use less resources at run-time.
The model classes underlx already has, for use with Realm, can probably be made into Room entities with little change.
Replacing Realm with Room/SQLite appears to be feasible and very appealing.
Data migration
Ideally we would like to avoid losing the trip history that beta testers have been collecting over the past months. This means a migration path from Realm to Room/SQLite must be established.
The only way to do this is to ship one or two releases that keep the Realm dependency solely for the purpose of migrating the data from the Realm database into SQLite, and then the Realm database is deleted. Realm would not be used for anything else in these releases. In a later release, Realm would be removed completely along with the migration code (the Realm database deletion code can still be kept).
This means users who update directly from the current version to that later version, that no longer contains Realm or the migration code, would lose their data. For an app with less than 30 users, with many of them probably not having that many trips in their history, this seems like a good compromise.
One of the difficulties that come to mind with this approach is that as long as Realm is present, the model classes can't be removed or replaced with Room entities (unless there's a way to use the same classes for both Realm and Room, but probably not). It's probably best to introduce a different package for Room entities, then the current model package will be deleted.

I started playing around with Room, but it takes more effort to migrate than I expected. The fact that Room doesn't allow object references like Realm means some things need to be rethought and more code rewritten. The data model must be thought with relational databases in mind, instead of OOP object composition. Not very surprising, since SQLite is still underneath the whole thing, and everything in Room very clearly maps to SQLite structures.
There's some stuff on the room-experiment branch.
Since the priority right now is to get the most important features going so we can go public on the Play Store, and since the database can be more or less flawlessly migrated later, and as what we have right now works, this shall be put on hold for now.


Remove from __future__ import annotations

It causes issues when rendering the API reference, which is more important than the source code.

Bad

Good


feat(e2e): modify e2e tests to run when more than one kepler is deployed

This PR updates e2e tests to run successfully when more than one Kepler is deployed.

@rootfs By any chance do you know why Kepler has stopped producing kepler_node_other_joules_total. I am facing this issue on CI where in e2e we check whether kepler_node_other_joules_total metric is present and with the latest build of Kepler it doesn't produce. #1143 contains more info on that


Investigate why the registry cache cannot pull blobs from ECR

How to categorize this issue?

/area quality
/kind bug
What happened:
The registry cache for some reason cannot pull blobs from ECR (at least from public.ecr.aws).
What you expected to happen:
The registry cache to pull images from ECR.
How to reproduce it (as minimally and precisely as possible):

Create a Shoot with cache for upstream public.ecr.aws

Create a Pod from the upstream , for example public.ecr.aws/nginx/nginx:1.23.0

Make sure the registry-cache fails to pull the blobs

Logs:
time="2024-09-19T14:23:24.143601968Z" level=error msg="response completed with error" err.code=unknown err.detail="unauthorized: " err.message="unknown error" go.version=go1.22.4 http.request.host="<IP_ADDRESS>:5000" http.request.id=46e13e3b-667d-44d4-bae2-6166c692b88a http.request.method=GET http.request.remoteaddr="<IP_ADDRESS>:2562" http.request.uri="/v2/nginx/nginx/blobs/sha256:f3d3961ba57b97cee8dea2cdc950856e6c3f4f6d1ba2fadaf5bdf069557bc469?ns=public.ecr.aws" http.request.useragent=containerd/v1.7.18 http.response.contenttype=application/json http.response.duration=263.540084ms http.response.status=500 http.response.written=84 instance.id=1c940ca5-d392-476a-8f73-18c5c4b26817 service=registry vars.digest="sha256:f3d3961ba57b97cee8dea2cdc950856e6c3f4f6d1ba2fadaf5bdf069557bc469" vars.name=nginx/nginx version=3.0.0-beta.1
time="2024-09-19T14:23:24.143602427Z" level=error msg="response completed with error" err.code=unknown err.detail="unauthorized: " err.message="unknown error" go.version=go1.22.4 http.request.host="<IP_ADDRESS>:5000" http.request.id=5e9c9254-da0f-48dd-be58-c31a66f8cec2 http.request.method=GET http.request.remoteaddr="<IP_ADDRESS>:39548" http.request.uri="/v2/nginx/nginx/blobs/sha256:778ddef5c8e3dfac8ba7265cbd22065f975b42a467e899f753d6d42d1b069da4?ns=public.ecr.aws" http.request.useragent=containerd/v1.7.18 http.response.contenttype=application/json http.response.duration=265.722708ms http.response.status=500 http.response.written=84 instance.id=1c940ca5-d392-476a-8f73-18c5c4b26817 service=registry vars.digest="sha256:778ddef5c8e3dfac8ba7265cbd22065f975b42a467e899f753d6d42d1b069da4" vars.name=nginx/nginx version=3.0.0-beta.1
time="2024-09-19T14:23:24.147671677Z" level=error msg="response completed with error" err.code=unknown err.detail="unauthorized: " err.message="unknown error" go.version=go1.22.4 http.request.host="<IP_ADDRESS>:5000" http.request.id=6ab4f416-338e-4714-9112-ad7ceb18cf70 http.request.method=GET http.request.remoteaddr="<IP_ADDRESS>:43359" http.request.uri="/v2/nginx/nginx/blobs/sha256:78979650788c06290785aaf0b0b200bd5c5e20285eec32c5684d93310ee38b67?ns=public.ecr.aws" http.request.useragent=containerd/v1.7.18 http.response.contenttype=application/json http.response.duration=255.817666ms http.response.status=500 http.response.written=84 instance.id=1c940ca5-d392-476a-8f73-18c5c4b26817 service=registry vars.digest="sha256:78979650788c06290785aaf0b0b200bd5c5e20285eec32c5684d93310ee38b67" vars.name=nginx/nginx version=3.0.0-beta.1
<IP_ADDRESS> - - [19/Sep/2024:14:23:23 +0000] "GET /v2/nginx/nginx/blobs/sha256:78979650788c06290785aaf0b0b200bd5c5e20285eec32c5684d93310ee38b67?ns=public.ecr.aws HTTP/1.1" 500 84 "" "containerd/v1.7.18"

Anything else we need to know?:
Similar upstream issue: https://github.com/distribution/distribution/issues/4383
Credits to @dimitar-kostadinov for this finding
Environment:

Gardener version (if relevant):
Extension version: v0.10.0
Kubernetes version (use kubectl version):
Cloud provider or hardware configuration:
Others:

I just stumbled over this issue 😄
Does the occur on all shoots or on AWS shoots only? If it is the latter, it might be related to some AWS credential helpers and permissions of the VMs or its service accounts.
I can remember similar issues for gcsweb on prow on GCP when the VMs had a GCP service-account. The application was aware of the service account because of the GCP metadata service and tried to use it. The service account did not have permissions to access the storage buckets (it was a storage bucket in the gcsweb case) at all. Even though the bucket was public, gcsweb could not access it.
I could imagine that something similar could happen for other application on other hyperscalers too.
It is just an idea which came to my mind. I did not investigate the registry-cache case at all yet.

I found some weirdness about public ECR:
https://docs.aws.amazon.com/AmazonECR/latest/public/public-registry-auth.html
according to the auth document of public ECR, Amazon ECR Public supports the [Docker Registry HTTP API](https://docs.docker.com/registry/spec/api/), with the exception of the tags API. However, you must provide an authorization token with every HTTP request.
When I tried for example curl -u AWS:<ecr-public-password> https://public.ecr.aws/v2, it didn't work ({"errors":[{"code":"DENIED","message":"Your Authorization Token is invalid."}]}). So according to the document above, it must inject token to every curl request when using HTTP API Auth.
I think this is the same reason why distribution registry (I used 3.0.0-beta.1) is not working with public ECR.
However, when it comes to the private ECR, the same curl -u AWS:<ecr-private-password> https://aws_account_id.dkr.ecr.region.amazonaws.com/v2 will actually work. And distribution registry 3.0.0-beta.1 can work as a pull through cache for private ECR.
In conclusion, I can only think that this is a limitation with public ECR.


RunnablePublisher::run() calls setPublishAudio instead of setPublishVideo

When creating a new Publisher in the RunnablePublisher::run() on android, it calls setPublishAudio(publishVideo) instead of setPublishVideo(publishVideo). Will send in a PR to set it right.

fixed with 3.2.0


Use EncodeUri() if part of the URL path or EncodeUriComponent() if used as a URL parameter

When reviewing your template, we've noticed that it is using user-defined parameters to build a URL. It's best practice to use encodeUri() if part of the URL path or encodeUriComponent() if used as a URL parameter.

Hi! Thanks for these suggestions. They have been applied to the template.


Unable to connect to AuraDB Neo4j instance

Attempted from master and dev/5.2.1 branches, on iOS and MacOS.
Result:
failure(NIOCore.ChannelError.connectTimeout(NIOCore.TimeAmount(nanoseconds:<PHONE_NUMBER>))).

Confirmed can reach port from dev machine:
nc -vz 536aec41.databases.neo4j.io 7687
Connection to 536aec41.databases.neo4j.io port 7687 [tcp/*] succeeded!

Would very much like to use your hard work in a SwiftUI project but am unable to move further unfortunately.

@chadobado I just did a quick test and didn't have problems. I used Xcode to link latest Bolt-Swift package and Neo4j-Swift from dev/5.2.1 branch.
Here is my test code:
override func viewDidLoad() {
        super.viewDidLoad()
        // Do any additional setup after loading the view.

        do {
            let client = try BoltClient(hostname: "12341234.databases.neo4j.io",
                                            port: 7687,
                                        username: "neo4j",
                                        password: "neo”4j,
                                        encryption: Encryption.certificateIsSelfSigned)

            let result = client.connectSync()
            switch result {
            case let .failure(error):
                print(error)
            case .success(_):
                print("Connected")
            }

            let labels = ["Movie"]
            client.nodesWith(labels: labels, andProperties: [:]) { result in
                switch result {
                case .failure(let error):
                    print(error)

                case .success(let successResult):
                    print("Found \(successResult.count) nodes")
                    if let node = successResult.first {
                        print("    \(node.labels.joined(separator: ","))")
                        for (key,value) in node.properties {
                            print("        \(key) = \(value)")
                        }
                    }
                }
            }
        } catch (let error) {
            print(error)
        }
    }

And using the test movie data from Aura I see:
Connected
Found 25 nodes
    Movie
        title = RescueDawn
        released = 2006
        tagline = Based on the extraordinary true story of one man's fight for freedom

Maybe confirm the encryption type you specified?

@joshjacob I'm facing the same problem like @chadobado. I don't understand what could be the problem.
`class Neo4jManager: ObservableObject {
var neo4jClient: BoltClient?
func connect() {
    do {
        let client = try BoltClient(hostname: "example.databases.neo4j.io",
                                    port: 7687,
                                    username: "neo4j",
                                    password: "neo4j",
                                    encrypted: true)

        self.neo4jClient = client

        neo4jClient?.connect { result in
            switch result {
            case .success:
                print("Connected to Neo4j!")
            case .failure(let error):
                print("Failed to connect: \(error.localizedDescription)")
                print(error)
            }
        }
    } catch {
        print("Failed to create BoltClient: \(error.localizedDescription)")
    }
}

}`

@chadobado I solved this problem by allowing outgoing network connections by adding this line to my entitlements file:
<key>com.apple.security.network.client</key> 	<true/>


Keeping reusable components under samples/ leads to build issues

Steps to reproduce:

Try to build samples/net/echo_server with BLE support:

make BOARD=96b_carbon CONF_FILE=prj_bt.conf

This will lead to following object layout:
$ find -name "*.o"
./bluetooth/gatt/ipss.o
./outdir/96b_carbon/arch/built-in.o
./outdir/96b_carbon/arch/common/built-in.o
./outdir/96b_carbon/arch/common/isr_tables.o
./outdir/96b_carbon/arch/arm/built-in.o

As can be seen, ipss.o goes outside the normal outdir/$(BOARD)/ hierarchy. This of course causes conflicts when building the same samples for other boards/archs (I don't see errors, but there're definitely spurious rebuilds).
Another issue trying to build a sample like samples/net/sockets/echo . As can be seen, this has 4 layers of hierarchy, while samples/net/common/Makefile.common refers to ipss.o as:
obj-y += ../../../bluetooth/gatt/ipss.o

so, it simply cannot find it for the samples like that.

@jukkar , @carlescufi, @Vudentz : Please let me know if you have an idea how best to fix this. My idea would be to introduce subsys/bluetooth/service/ , and start with moving ipss.o there, as that's truly reusable service as used in the codebase. Then other services from samples/bluetooth/gatt/ may follow, if needed.

Not that similar issue exists for other subsystems, e.g. recently similar was fixed for net, and this ticket talks about usb cases: https://github.com/zephyrproject-rtos/zephyr/pull/716

Agreed, I've never liked the samples/bluetooth/gatt folder. I do think that (standard) services belong in the subsys folder or, alternatively, in the lib folder. So as I see it either we move those to subsys/bluetooth/host/<gatt,services> or to lib/bluetooth/gatt

@carlescufi : Thanks for quick response. There's currently no lib/bluetooth/ , and the current content of lib/ is rather generic (libc/its adaptations, json). And having lib/bluetooth/ would mean that subsystem is split between 2 subtrees.
On the other hand, taking subsys/net/ as an example, it has net/ip/ for the "core" code, and net/lib/ for various protocols and helpers. So perhaps, keeping everything under subsys/bluetooth/ , in a suitable subdir, is possible.

@pfalcon right, I think subsys/bluetooth/gatt or subsys/bluetooth/services would be the right location for this

I talked about this with @jhedberg just recently, the idea is to move this to subsys/ as an application layer.

The way I see this code is that it's an extension of the application domain, or in other words a library that the application uses. One requirement of it is that it must only use public APIs. I'm therefore a little reluctant at putting it under subsys/bluetooth since it's not really on the same level as the Bluetooth subsystem, rather a layer above it (i.e. the application). Just like HCI drivers are a layer below the (host) stack, and therefore separately under drivers/bluetooth, I don't see anything wrong with putting this code under lib/bluetooth/

Well, whatever works to resolve the situation. Ideally it would be nice to have some inter-subsystem consistency and patterns, and as I point, net uses subsys/net/lib/ for the very similar purpose (and with very similar constraints, like public API usage), but if for BT, lib/bluetooth/ offers better separation, well...

@jhedberg @pfalcon I would always put consistency before other concerns, so I'd be in favor of either placing it under subsys/ or talking to the net people so that they move theirs to lib/

#bikeshedding alert: I would refrain from lib/ and follow how it was done in subsys/net, lets keep the code for bluetooth in one place under subsys and create the needed structure under subsys/blueooth

Then I'd probably go for subsys/bluetooth/lib. Anyway, this is a non-issue for IPSP since the existing "lib" for it can be completely removed. @Vudentz will fill in the details.

In case of IPSP there is no such problem anymore since as NET_APP takes care of it, so there must be something pulling it since I removed ipsp.o from Makefile in:
https://github.com/zephyrproject-rtos/zephyr/pull/979

git grep ipss.o
samples/net/common/Makefile.common:obj-y += ../../../bluetooth/gatt/ipss.o

https://github.com/zephyrproject-rtos/zephyr/pull/1168

https://github.com/zephyrproject-rtos/zephyr/pull/1168 indeed helped with the immediate issue, thanks! So, I guess the rest can wait until 1.10 window opens.

Seems like a dupe of https://jira.zephyrproject.org/browse/ZEP-2384, which was marked closed, but now I'm not sure why.
Also, are we using GH issues now, not JIRA?


Include characteristics in DecodedString

Addresses #22.
Display [STACK] or [HEAP] instead of more meaningless offsets, global addresses are still displayed.
The DecodedString tuple now includes a characteristics dictionary.

build fails, so need to add enum34 to requirements in setup.py before merging

otherwise, looks good

:balloon: looks good to me


quote

is the whole thing a quote here? or just what's in double quotes?

The whole thing is a quote from the news piece, and the piece used a direct quote, which is in the double quotes.


Add site-wide "Admin Maintenance" view

Is your feature request related to a problem? Please describe.
We need a central location to display site-wide admin level things.
Describe the solution you'd like
Should contain buttons for kicking of jobs to

recompute all project statistics
rebuild the small variant summary view

Ask Mikko how to best build this into the app. Should only be available to super users.
Describe alternatives you've considered
N/A
Additional context
N/A

Comment from internal bug tracker.
Maybe the following implementation would be most elegant, need to talk to @mikkonie

Add an site-admin app similar to site-info app.
Plugin architecture allows to hook in views or at least buttons triggering the API.
The implementation, e.g., for recomputing project statistics should be in the variants app itself.
EXCEPT if @mikkonie  thinks that it would make more sense to have a separate variants_admin app (TBD).

Also, we should place an overview of the "rebuild in-house database" jobs and triggering the rebuilds.

Fun fact: there are several long-standing open issues in SODAR Core for building a generic site admin app :)
So I'm all for doing it that way. However, if you are in a hurry, can of course create a separate app now and migrate the actual functionality into a generic site admin app later..


Invalid google_app_id

Hello,
I did each step but i always had a same problem.

I'm looking for about this error, but all people says that problem is google-service.json but i think that It's correct.

Any idea?

I have the same issue. I have the google-services.json & the GoogleService-Info.plist (it works for iOS).

try with the latest release of the plugin. re-open if needed


[Localization] JSON.parse Unexpected token  in JSON at position 0  on  DefaultLocalizer.js

Hi, I think there is a bug in botbuilder nodeJs . var entries = JSON.parse(data); throws an exception on file DefaultLocalizer.js the error message is : Unexpected token  in JSON at position 0 . notes : data = "{"locale_prompt": "test"}" and is retrieved from ressouce file (locale/en/index.json)
but if I hardcode data = '{"locale_prompt": "test"}' it works fine

@stevengum97 thoughts?

Hi, if I replace  line 1 by line 2, it works

var entries = JSON.parse(data);
var entries = JSON.parse(data.toString('utf8').replace(/^\uFEFF/, '')); //JSON.parse(data);

Best regards

Thanks for the update @logcorner - Glad to hear you found a solution.


Add CI build with minimum supported versions

xref https://github.com/nsidc/earthaccess/issues/386#issuecomment-1841302469

Note we're now getting
FAILED tests/unit/test_results.py::test_data_links - AttributeError: 'DataGranules' object has no attribute 'headers'

Like reported in https://github.com/nsidc/earthaccess/issues/386

Thoughts about keeping the mindeps file up-to-date?

It we were using setuptools, we could do something like this:

pyproject.toml[tool.setuptools.dynamic]
dependencies = { file = ["ci/requirements-min.txt"] }

test env using conda or pip:conda create --name earthaccess --file  ci/requirements-min.txt

python -m pip install ci/requirements-min.txt

I'm not sure if you can do the same with Poetry

For us I think just manually updating is fine.

I agree with this as well. I like the comments in both files, and I don't think it's a burden since we should rarely be updating those.

Thanks all for the reviews!


Added Istanbul Bilgi University

the university website is www.bilgi.edu.tr - please provide some proof (link to the relevant page), that the committed domain also belongs to the university. Thanks!

You can check who is info of mail.bilgiedu.net and you would see it's registrant is as Istanbul Bilgi University.
Link: http://mail.bilgiedu.net.ipaddress.com
Besides that, there is one page which refers this domains but it's in Turkish<EMAIL_ADDRESS>Br,

Thanks a lot for extra info - I'm adding the domain.


PTYExample fails to connect

Running the PYTExample project in Xcode 8.3 produces the following output after setting up a connection and pressing the connect button.
2017-04-11 17:30:20.961 PTYExample[15217:1605150] NMSSH: libssh2 (v1.8.0) initialized
2017-04-11 17:30:20.961 PTYExample[15217:1605150] NMSSH: Start -------.com resolution
2017-04-11 17:30:20.963 PTYExample[15217:1605172] NMSSH: Socket connection to --.---.--.--- on port 22 failed with reason -1, trying next address...
2017-04-11 17:30:20.963 PTYExample[15217:1605172] NMSSH: Failure establishing socket connection
2017-04-11 17:30:20.964 PTYExample[15217:1605172] NMSSH: Disconnected
Is anyone else having the same issues?

Check which build configuration was used for NMSSH https://github.com/NMSSH/NMSSH/issues/213

I downloaded NMSSH as a zip, opened NMSSH-iOS.xcodeproj, switched the scheme to 'NMSSH Framework' and built. I then closed that project and loaded Examples/PTYExample/PTYExample.xcodeproj and clicked the play button. That's correct, right?

Building the Framework with all optimisations set to 'None' in Xcode allowed me to use the Framework in another project. I haven't tried PTYExample again. I'm out of time!

Fails with the same error here... anybody got an idea? I'm trying to connect to a RasperryPi, SSH in enabled on it. I turned the optimisation Level off as mentioned in #213 , but that does not seem to make the deal for me...

Alright, I just downloaded the whole ZIP again, made sure I turned off all optimisations before I first run it and it works. :)

25a0706 should fix the issue.


following tutorial 1,  I got an error report

with code "t, x = simulate(model, timespan=timespan, x0=x0, control_vars={'u_0':2})"
I got error report:
File "D:\Program Files\Anaconda3\envs\BGT\lib\site-packages\BondGraphTools\sim_tools.py", line 190, in _bondgraph_to_residuals
raise ModelException(message)
BondGraphTools.exceptions.ModelException: Invalid control function for var: 0.
Control functions should be of the form:
0 = f(t, x, dx/dt)
Thank you very much for attention!

full report:
Traceback (most recent call last):
File "D:\Program Files\Anaconda3\envs\BGT\lib\site-packages\BondGraphTools\sim_tools.py", line 180, in _bondgraph_to_residuals
r = f(0, 0, 0)
TypeError: 'int' object is not callable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:/学习/BondGraphTest/test.py", line 36, in
t, x = simulate(model, timespan=timespan, x0=x0, control_vars=[2,2])
File "D:\Program Files\Anaconda3\envs\BGT\lib\site-packages\BondGraphTools\sim_tools.py", line 122, in simulate
res, X = _bondgraph_to_residuals(system, control_vars)
File "D:\Program Files\Anaconda3\envs\BGT\lib\site-packages\BondGraphTools\sim_tools.py", line 190, in _bondgraph_to_residuals
raise ModelException(message)
BondGraphTools.exceptions.ModelException: Invalid control function for var: 0.
Control functions should be of the form:
0 = f(t, x, dx/dt)

I just hit the same.
I can fix it here and obtain the expected evolution by replacing 2 with lambda _, __, ___: 2; i.e.
t, x = bgt.simulate(model, timespan=timespan, x0=x0, control_vars={"u_0": lambda _, __, ___: 2})

I'd propose a PR for the docs but I'm very new to BondGraphTools (maybe ten minutes) so expect there's a more idiomatic way to express constant effort.

Oh, I see, following on to the next step of the tutorial with the sinusoidal forcing, I see that a string will do:
t, x = bgt.simulate(model, timespan=timespan, x0=x0, control_vars={"u_0": "2"})

@Conearth and @gdmcbain
There was a issue with read-the-docs not building the v0.4 release.
This is now fixed, and the tutorials are now showing the correct thing.
Please let me know if you still have issues.
Cheers


Improve the pss inputs calculation functions

as reported by @tavovalmo the current functions to fetch PSS inputs are unclear and in some cases incomplete. For instance:
function get_pss_input_signal(
    ::Val{2},
    device_states::AbstractArray{<:ACCEPTED_REAL_TYPES},
    inner_vars::AbstractArray{<:ACCEPTED_REAL_TYPES},
    ω_sys::ACCEPTED_REAL_TYPES,
    dynamic_device::DynamicWrapper{PSY.DynamicGenerator{M, S, A, TG, P}},
) where {M <: PSY.Machine, S <: PSY.Shaft, A <: PSY.AVR, TG <: PSY.TurbineGov, P <: PSY.PSS}
    # TODO: Frequency Input for PSS not properly supported yet"
    return ω_sys - 1.0
end

We need to improve the interface and implement other inputs like speed.

Stab1 uses speed deviation too. However, I struggled to understand how to choose option 1. I finally used what José suggested:
external_ix = get_input_port_ix(dynamic_device, M)
ω = device_states[external_ix[1]] # get machine speed
u = ω - 1.0


Advanced french dev documentation

#1362 : a proposal of some of our documentation created, it could be useful to other developers.
Not perfect, but that is a beginning

Merged manually (squashed / cherry-picked).


Internet connection speed affected by default proxies

When starting a K2s cluster the order of default proxies is set to:
<IP_ADDRESS>
<IP_ADDRESS>
X.X.X.X -> real default proxy
Since <IP_ADDRESS> is an proxy with no functionality, this leads to certain timeouts.
Here a way has to be found to  improve this.
Additional info:

<IP_ADDRESS> is needed for container functionality, maybe it can be omitted somehow in routing or the order can be changed
<IP_ADDRESS> is coming from Loopbackk2s, normally not needed at all, if possible shall be omitted

To determine the routing used for internet connectivity, next hops where communication is sent to:
Get-NetRoute -DestinationPrefix <IP_ADDRESS>/0 | Select-Object -ExpandProperty NextHop

Solved now main.


Document forward compatibility across major Quarkus release boundaries

I did this change in November, but seem to have forgotten to do a pull request for it.

Thanks!


Change ? extends Text to Text.

https://github.com/SpongePowered/SpongeAPI/blob/74a6311b865e2ecc35e6e7851ccbc681e0119f97/src/main/java/org/spongepowered/api/command/CommandCallable.java#L106
https://github.com/SpongePowered/SpongeAPI/blob/74a6311b865e2ecc35e6e7851ccbc681e0119f97/src/main/java/org/spongepowered/api/command/CommandCallable.java#L89
Text is a sealed class, no one outside of the API can extend it. Additionally, optional can only contain a single element. So why is it typed as ? extends Text?
It causes errors, and means that you can't do the following.
callable.getHelp(commandSource).orElse(Text.EMPTY);

As getHelp returns Optional<? extends Text> there is no way to know what type it contains, just that it's a descendent of Text, so Java prevents you from matching against subtypes.

@Minecrell Thoughts on this? It seems okay to me to switch the signature to Optional<Text> instead of Optional<? extends Text.

What was the original reason for Optional<? extends Text>? Seems to me that there was little point in having the wildcard in the signature in the first place. In face the guidelines for wildcard use seem to recommend not returning a wildcard type in an API.

Using a wildcard as a return type should be avoided because it forces programmers using the code to deal with wildcards.

I would assume its so that subclasses can override the method and narrow the definition, however all of them simply override it as Optional<Text> anyway so there is little point.

Shouldn't the different subclasses override with their specific type?

https://github.com/SpongePowered/SpongeAPI/pull/1239

Could someone close this now?


Successful send but no notification available

Hi sir, I got problem regarding send notification.
I'm already do what have been told. When execute, the toast said "Done" but no notification.
Is it have any fix?

hi @Firdauser03 send me the code or snipet, but I think there is an error in notification not in library.


Icon request

Is it possible to include an icon for void linux?
Icon from refind-ambience

If someone wants to color match and make a PR, for sure!


Potential class name collision when using responsive style props or pseudo class

I have identified a potential issue in our Sheet implementation. Currently, the Sheet.addRule() method generates CSS class names based on the style property name, using the generateHash function. This works well in most cases. However, when using responsive style props, different components can end up with the same class name, leading to unintended style conflicts.
Consider the following two components:
<k.div  p={[4,8]}   />
<k.div  p={4}   />
<k.div  p={4}  _hover={{p: 8}} />

Both cases result in the same CSS class name being generated. However, the actual styles applied to these components should be different.
Because generateHash only considers the style string and not the responsive properties or pseudo-class styles, it will return the same hash for different responsive style prop values or different pseudo-class style states. This leads to a collision in the generated class names and results in incorrect styles being applied to the components.
We need a way to distinguish between different values of the same style prop when generating class names, especially when responsive or pseudo-class styles are involved.

Possible solution:
addRule(style: ResponsiveStyle): string {
    const css = style.base.replace(cssPropertyRegex, "");
    const id = "kuma-" + generateHash(style);
    const existingRule = this.rules.find((rule) => rule.id === id);
    if (!existingRule) this.rules.push({ id, css });
    return id;
  }


Cannot read property 'config' of null from http://localhost:3000/resources/zips/toh-6/toh-6.zip

This issue is about one of your examples you have on the "Tutorial: Tour of Heroes" downloadable example.  When running "ng serve" on the example one gets:
  Cannot read property 'config' of null

I am using a Mac with Yosemite and I did the following:
 git clone https://github.com/angular/angular.io.git
 git clone https://github.com/angular/angular
 sudo ./scripts/before-install.sh
 sudo ./scripts/install.sh
 gulp serve-and-sync
 In a browser I went to:   http://localhost:3000/docs/ts/latest/tutorial/
 I downloaded http://localhost:3000/resources/zips/toh-6/toh-6.zip
 I unzipped toh-6.zip
 I changed directory into toh-6
 npm install
 ng serve

On typing "ng serve" I got:
 $ ng serve
 Cannot read property 'config' of null
 TypeError: Cannot read property 'config' of null
  at Class.run (/Users/johndickerson/workspaces/prospect/toh-6/node_modules/@angular/cli/tasks/serve.js:22:63)
  at check_port_1.checkPort.then.port (/Users/johndickerson/workspaces/prospect/toh-6/node_modules/@angular/cli/commands/serve.js:103:26)
  at process._tickCallback (internal/process/next_tick.js:103:7)

I have the following npm global installs:
$pwd
/usr/local/lib/node_modules/@angular/cli
$ npm version
{ '@angular/cli': '1.0.0-rc.4',
npm: '4.1.2',
ares: '1.10.1-DEV',
cldr: '30.0.3',
http_parser: '2.7.0',
icu: '58.2',
modules: '51',
node: '7.6.0',
openssl: '1.0.2k',
tz: '2016j',
unicode: '9.0',
uv: '1.11.0',
v8: '5.5.372.40',
zlib: '1.2.11' }
I am not sure if this is a Mac thing.  The funny thing is that in:
toh-6/node_modules/@angular/cli/tasks/serve.js:22:63

it shows:
const projectConfig = config_1.CliConfig.fromProject().config;

if I go to "fromProject" I see the file:
<EMAIL_ADDRESS>
At the top of the config.d.ts file it has:
 export declare const CLI_CONFIG_FILE_NAME = ".angular-cli.json";

Notice there is a dot at the beginning of the name:   ".angular-cli.json"
This file does not exist anywhere.
There is a file without a dot in:
<EMAIL_ADDRESS>
I realize that this could be an  "@angular/cli" problem rather than an "angular.io" problem.
If instead of using "ng serve", I use "npm start" it does not get past loading on in the browser and in the server the only problem I can see:
17.03.21 17:10:24 404 GET /systemjs-angular-loader.js

Forgive my lack of knowledge at the moment but maybe I have somehow highlighted a problem with the example or the lack of instructions in the example or am stupid and am wasting everyone's time.
Thank you for your time.

The example is NOT a angular-cli example so that won't work. You need to npm start it.

Thanks Foxandxss,
Once I added the missing /systemjs-angular-loader.js "npm start" worked.
It is missing from here:
e.g.  http://localhost:3000/resources/zips/toh-6/toh-6.zip

It is also missing in some of the other examples.
Cheers
John

I need to check that. I fixed that yesterday but I am not sure if we went live after that.

You are right, I cloned the rep before yesterday before your fix.  Sorry for not checking again before raising the ticket.
https://angular.io/resources/zips/toh-6/toh-6.zip is fine.
You can close the ticket.
Cheers


Google Clone Added

Added a Google Clone which works same as Google Search Engine
** Fixes #41 **
It searches stuffs  for you.
Added a readme file for the respective project.
All the files are nicely arranged in respective folders.

Demo Video
https://user-images.githubusercontent.com/85401522/156899936-a5c6ef6d-4b2d-4838-8c1f-6de0db9c1885.mp4

@rajprem4214 no doubt on your work but add Demonstartion video and show all functionalities which your search engine can do . So that it dosen't looks like that you have done any plagiarism and that all. in video just go through your code and open that html file in video recording.

Added the same.

@rajprem4214 no doubt on your work but add Demonstartion video and show all functionalities which your search engine can do . So that it dosen't looks like that you have done any plagiarism and that all.


SteamCMD Redhat systems

This is not even remotely useful as a documentation page. It is not professional looking, does not follow our layout, and is overall not useful.
Please create a new PR that follows the other doc pages.


How to build libcrfsuite.so in Linux env?

Hi vinhkhuc,
I have modified the original crfsuite and want to build the libcrfsuite.so in linux. As https://dl.dropboxusercontent.com/u/11628772/crfsuite-linux-build.tar.gz listed in ISSUE#6 is no longer accessible. Could you help provide the steps of building the so file again?

Hi lyc1116,
You can get the file crfsuite-linux-build.tar.gz at https://github.com/vinhkhuc/jcrfsuite/tree/master/misc.
Thanks,
Vinh

Thank you very much, a big help!


Update competition webpage

[x] Describe winners
[x] Save as template for next competition
[x] SMARTS-project
[x] Codalab

Competition results posted at:

https://smarts-project.github.io/
https://codalab.lisn.upsaclay.fr/competitions/6618


Ignore TableMasterJournalIntegrationTest#JournalTransformDb

The test is too flaky.

alluxio-bot, merge this please.

alluxio-bot, cherry-pick this to branch-2.4 please.


Typo in 1.3.1 code example

Hi, loving this book so far! I ran into a quick issue in section 1.3.1. The code offered is:
oline_snap_counts <- oline_snap_counts %>%   group_by(game_id, team) %>%   arrange(player, .by_group = TRUE)
but line 3 should use
arrange(player, .group_by = TRUE)
basically the words ".group_by" are just reversed. I was able to figure it out real quick with chat gpt, but in case people want to copy and past without fuss, I thought it would be worth highlighting.
Thanks!

The use of .by_group rather than .group_by is not a typo. It was done by choice. To be clear, both return the same information, but in a differing arrangement.
For example, using .by_group returns the following:


removed kbl assertions

Pull Request

[x] I have checked for similar PRs.
[x] I have read the contributing guidelines.

Changes

[x] Code
[ ] Documentation
[ ] Other:

Description
Removed kbl assertions

@takebene merge conflicts


Feature/add offline mode

Now the site can work offline :) Test by going to https://the737toolbox.appspot.com

Well done @dftaiwo 👍

Yay!
One more coming up! :)
Regards,
Femi TAIWO
http://plus.google.com/+FemiTAIWO
On Tue, Aug 9, 2016 at 8:27 PM, Aikomo Onaopemipo<EMAIL_ADDRESS>wrote:

Merged #3 https://github.com/fathermerry/737/pull/3.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fathermerry/737/pull/3#event-750342615, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AACg6br_zKULqVSt3VDDsduGvIq8CF9pks5qeNS7gaJpZM4JgWrB
.


Layer bounding box

Description
I often found myself wanting a bounding box around the layer, especially when using the plane rendering mode fore volumes. Without it, I lose track of where I am in the volume and I'm always slicing back and forth to the extremes just to make sure I'm not forgetting parts of the volume.
This PR is an attempt at implementing a bounding box visual that can be used by any layer. There are a few quirks, but the gist is this:

get the bounds of the visual from vispy
generate a rectangle or cuboid made of lines and markers

The annoying stuff mainly comes from juggling 2d and 3d and making sure things are up to date.
This is a WIP and I only made it work-ish for image and points, to get some feedback. To test it, try:
import napari
import numpy as np

v = napari.Viewer(ndisplay=3)

img = v.add_image(np.random.rand(10, 20, 15), translate=(30, 50, 12), scale=(10, 12, 13))
pts = v.add_points(np.random.rand(10, 3) * 200)

The cool thing of this approach is that it inherits the transform of its parent, so we get all of that for free.
Something that's worth discussing in relation to this:

how should we interface with this from the napari side?
can we join this with other "world space overlays" (need better name :P) and share some functionality? I'm thinking for example @Czaki's "technical layers" or @alisterburt and @kevinyamauchi's napari-threedee's depictors/manipulators.

Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change
[ ] example: I check if my changes works with both PySide and PyQt backends
as there are small differences between the two Qt bindings.

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

From looking at your screenshot, it looks like the points bounding box might not be the right size (it looks too "tall"). Is that just a perception issue or is there an issue there?

If anything, it's too small, because it doesn't include the point size (whether it should, is a discussion we had before in other forms and other places :P). It looks too tall because you can't tell the depth of the point in the middle-top!

I think this means we need the layer extent but in scene space?

@alisterburt and I added a layer._display_bounding_box attribute to the base Layer class that may be useful.
https://github.com/napari/napari/blob/5827a55f18d02fc65958766db4d5457549c63cb0/napari/layers/base/base.py#L1330-L1332

@alisterburt and I added a layer._display_bounding_box function to the base Layer class that may be useful.

Oh, I forgot about that! I think that's exactly what I need :D

Superseded by #4894.


Release 0.6.1

Rebuild with Go 1.15.
Cleanup darwin/386 in example config.
Fix cgo builds on illumos by avoiding static linking #192
Workaroud builds failing with copy_file_range: operation not permitted0

Signed-off-by: Ben Kochie<EMAIL_ADDRESS>

CC @davepacheco

Thanks!


Add BDynamicsMk22Cockpits

Closes #2683

This is ready to merge. If you want to override asetprops to 1.0.5 compatibility I'm pretty sure that's a safe bet.

override for ASETProps done in #2706.


Use non-polling for watch mode by default

Is your feature request related to a problem? Please describe.
The current implementation of watch mode explicitly enables the usePolling option of chokidar, which has a much higher resting cpu footprint than the native filesystem watcher. Polling is technically supported in more cases, but the documentation suggests that native file watch is supported on most common platforms.
Describe the solution you'd like
Set usePolling to false by default (the default value in chokidar anyway), and either gracefully fall back on platforms that don't support it or allow users an option to override it if they need to.
Describe alternatives you've considered
You can override the the option in chokidar through an environment variable named CHOKIDAR_USEPOLLING, but IMO it would be more ideal to optimize for the common case and potentially advertise that option to users who need polling for some reason (or support a more direct way to override it via the cli).

Thank you @mintchkin , I think it could help a lot. Any chance you want to create a PR for this? :) I think we might be able to expose some of the chokidar configuration, and allow developers to override it if needed.

@dotansimha opened #4823, let me know if that's in line with what you imagined

Available in<EMAIL_ADDRESS>


flakey test causes me to delete fork

Bug Report
https://github.com/operator-framework/operator-lifecycle-manager/blob/master/.github/workflows/flaky-e2e.yml is super flakey (fails most of the time) and because of that I am deleting my fork

keeping my fork up in case this issue will require you to look at my fork
What did you do?
clone the repo
What did you expect to see?
that the flaky or any recurring GHA will not break every time it runs.
What did you see instead? Under which circumstances?
I saw daily an error and it wasn't clear enough I could PR it and solve.
Environment

operator-lifecycle-manager version:

N/A

Kubernetes version information:

N/A

Kubernetes cluster kind:

N/A
Possible Solution
N/A
Additional context
I rebased the repo multiple times but the same problem persisted

Hi @georgettica thank you for the bug report. This is a long and recurring issue and we are trying to address it little-by-little. To address this we've been trying to factor out the flaky tests to a separate (non-required) job - to unblock people and identify the culprits and try to fix them in turn. Over the last few months we've already made several changes to the e2e sweet and improved CI a fair bit, though the road to complete stability is long - and we, of course, welcome any help with this effort (see the flaky test issues).
Your frustration is not misplaced and is shared by the other developers. We're doing what we can and appreciate your feedback, patience and, if inclined, help in this matter ^^

if that is ok, could changes that help be linked to this issue? so if any are frustrated aswell they can vent here and maybe shell out different cards to solve this?

@georgettica I'll add here the list of flakes
That would be a great start!
Thanks again for your understanding and patience ^^

Software can be hard, I feel.ypur pain and hopefully at some point the flakiness will clear up


feat:  lower total digg shares and max supply

Major change here is to lower total digg shares and max supply.
Also some work on ensuring we're comparing apples to apples in the tests.

updated in upstream PR.

updated in upstream PR.


Javascript enableFormTracking does not allow for blacklisting or whitelisting

This becomes an issue if the form that is being tracked captures credit card information.

Duplicate of https://github.com/snowplow/snowplow-javascript-tracker/issues/287


wasm-compose resource subtype mismatch

I have the following wit file:
package test:ser

interface serializer {
    resource serializer-resource {
        constructor()
        serialize-i32: static func(self: serializer-resource, v: s32) -> string
    }
}

world test-serialize {
    import serializer
}

world test-serializer {
    export serializer
}

and two WASM components which implement test-serialize and test-serializer, respectively (both are implemented in Rust and then transformed into components with wasm-tools component new).
I am trying to compose these two components such that the serialize component can construct a new serializer-resource and call a method on it, even though it imports both from another component, i.e. none of the functionality comes from the host.
When running wasm-tools compose serialize.wasm -d serializer.wasm -o composed.wasm, I get the following error:
error: failed to connect instance `$input` to definition component `./serializer.wasm`

Caused by:
    0: source instance export `test:ser/serializer` is not compatible with target instance import `test:ser/serializer`

After a bit of digging, I found that the following two subtyping checks cause this error:
https://github.com/bytecodealliance/wasm-tools/blob/a0c46a7a16fef5cc9143ad30c77f19303c27d907/crates/wasmparser/src/validator/types.rs#L2521
and
https://github.com/bytecodealliance/wasm-tools/blob/a0c46a7a16fef5cc9143ad30c77f19303c27d907/crates/wasmparser/src/validator/types.rs#L3074
I have no idea why two independent resource IDs are generated even though the resource imported by the serialize component is the same as the resource exported by the serializer component. Crudely commenting out this check allows the components to be composed, and the composed component to be run in wasmtime, and the resource seems to work perfectly fine (constructor, method, and destructor are all called as expected).
Is there a way for the component subtyping match to succeed? Thank you for your help!
Attachments:
serializer.zip
serialize.zip

Thanks for the report! This is a known issue with wasm-compose where it does not yet have support for resources. This hasn't quite bubbled up to the top of the priority queue for anyone yet and is likely to require a bit of surgery to handle this, so it's unfortunately not an easy lift.
That being said this is good to keep track of, thanks for filing this!

FYI, I'm starting work on a subset of resource support in wasm-compose, specifically composing two components which import the same resource type such that they can pass handles to that type between each other.  Hopefully we can build upon that work to support other cases as well.

@dicej you might want to do it on top of #1257 to avoid annoying rebase conflicts.


chore: use external xast type declarations

Removes our custom type declarations for Xast in favor of the ones suggested by xast.

If you are using TypeScript, you can use the xast types by installing them with npm:
npm install @types/xast

— https://github.com/syntax-tree/xast#types

Motivation
While it makes sense to declare types of Xast for our plugin API, I think it'd be better to avoid maintaining them as part of this library/application if there are conventional solutions available already.

Imo it's better to leave maintaining/redistributing them to @DefinitelyTyped, which Titus Wormer and Christian Murphy from syntax/xast helped define.
The new types more strictly adhere to the Xast spec, which should simplify integrating with Xast libraries in future.

My hope was actually to explore some libraries surrounding Xast, in particular, xast-util-from-xml and xast-util-select. Unfortunately, neither of these meet fulfil our needs atm.

Not 100% sure if this is a worthwhile change, so feedback welcome.

Working with attributes with these types is less trivial though parser produce only string values. I'd prefer to stay with old types.
This change also introduce 2 more packages. xast-util-from-xml would bring even more.
Last couple months I had very bad Internet connection and loading myriads of packages in node_modules made it worse. So I'd encourage you to keep svgo more concentrated.
Underlying xml parser seem interesting though. We could write own wrapper around it and replace sax.

Sounds good, I'll shelve this then!

Underlying xml parser seem interesting though.

Unfortunately, one thing that will stop us from using it for now is the lack of support for DTD entities.
https://github.com/rgrove/parse-xml#not-features
Not sure if that's planned, or something we'd be able to work around. I'll review both later, but right now, I'm more focused on documentation.
Sharing a WIP for the sake of it:

Awesome!

@TrySound Seems we're unable to exchange email. Yandex thinks I'm a spammer. 😭
The documentation isn't ready yet, but I'm making good progress and think it will be ready for other maintainers to review soon. My goal is by 6 October 2023!
It's already hosted on GitHub pages, but from my namespace:

https://svgojs.org/
The Cleanup IDs page is a pretty good showcase for info, parameters, and practical demo.

Also willing to transfer the domain to Kir when or if requested.
Would it be alright for you to create a new repo called svg/svgojs.org or svg/website, so I can open a PR there when it's ready?

Wrote to you in matrix


Snake game added

This closes issue #446.
A snake game using python and pygame library.

[x] Contributor in HacktoberFest

Screenshots -

Will remake a pull request. Forgot some changes.


Add missing fireChannelReadComplete in FilterHandler

Type of change

Bugfix

Description
If handleResponseFilterResult is running in an async context, the decodedFrame is written to inboundChannel but not flushed.
It works now because the future is completed and handleResponseFilterResult is running in sync context. fireChannelReadComplete is called by netty. We can not rely on this in async context.
Additional Context
Why are you making this pull request?
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Review performance test results. Ensure that any degradations to performance numbers are understood and justified.
[ ] Make sure all Sonarcloud warnings are addressed or are justifiably ignored.
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

@luozhenyu thanks for the contribution.   Could you write a FIlterTest that demonstrates the issue?  We need supporting tests to make sure that fixes can't regress.

@franz1981 could I ask for your advice here too?  I don't have a good mental model about how a Netty application should use  fireChannelReadComplete.  The javadoc tells me what is does rather than why/when I should use it.
io.kroxylicious.proxy.internal.FilterHandler#forwardResponse currently uses fireChannelReadComplete on the code path used when a request filter decides to send its own response the client (rather than forwarding the request to the broker).  We call this a short circuit response.
@luozhenyu change adds fireChannelReadComplete, which is the 'normal' path used when the proxy is relaying a response from the broker towards the client.
Any insights would be appreciated.

I should better check there, but for what I can see, given that the filter is a duplex handler in theory we already propagate read completions on duplex read complete, but the modified method in the PR could be called while there are no read(s) on the filter, meaning that we requires to propagate read completion due to the newly issued reads from there, unless we keep track of the filters reading/readCompleted state and skipping it, if not needed.
IDK If the modified method can be called outside of the event loop from some alien thread, but If the answer is "yes" we need somehow to propagate read completion, for sure, see https://github.com/netty/netty/blob/netty-4.1.110.Final/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java#L465 which shows that read completions can be called from outside the owning event loop, becoming just a task submission.
This means another thing: the number of reads fired Vs completions, depending how the other inbound handlers are implemented, could guarantee much better (write) performance i.e.
issuing a single read + read complete will likely make the next inbound handler to NOT be able to batch its own writes effectively (usually we write on read and flush on completion).
In order to do things better there are several strategies here, where the simpler one is to have a mpsc unbound queue of messages and the filter's forward could just drop them there, submitting a task to the context event loop to drain them.
If the drain task found many of them can just perform a single complete for N reads, increasing the write batching of the outbound handlers which will process them.
If luckily, the filter'a read could already try draining from the queue without issuing any completion, because for each read there always be a reas complete, while in the event loop.
A further optimization can just use some atomic variable to avoid issuing useless runnables, but is not required for correctness.

@luozhenyu are you adding you own Netty Handlers to the pipeline, by any chance?

Use case not clear and there is no response from the owner.


Display a Response from API in UI

Changes:

Adds a global Axios instance, initialized with a baseUrl value and a pre-configured interceptor
Adds a .env-example and .env support
Adds example API request and success/error case handling
Adds example of a class method to encapsulate conditional rendering
Adds a run-server Make command
Updates AboutUs to be a stateful component
Removes CheckboxWithLabel stateful component

Note: No backend code changes are made in this PR so as to retain the original ticket's scope. There may be related backend changes/refactoring to be done in a future PR.

Looks like you may have some issues with webpack.


[release/v2.5] Update rke to v1.2.12

Issue: https://github.com/rancher/rancher/issues/34026

Are we not upgrading to v1.3.0 for 2.5.x?

AFAIK we don't upgrade rke like that, instead we have a given rke version per rancher version (2.4 -> 1.1, 2.5 -> 1.2, 2.6 -> 1.3).

@PennyScissors That's correct, release/v1.2 is for 2.5.x.


Move on_each to cirq.Gate

Part of #4034. (See https://github.com/quantumlib/Cirq/issues/4034#issuecomment-832913708)
This can go before or after #4207, as they are disjoint problems.
Note that deprecating SingleQubitGate will be more troublesome than the others, as things like _CALIBRATION_IRRELEVANT_GATES and NOISE_MODEL_LIKE depend on it.

@daxfohl is this ready for re-review?

Yes, the new code only supports the strict option for multi-qubit gates, per the discussion here: https://github.com/quantumlib/Cirq/issues/4034#issuecomment-867973560

@daxfohl, how would you feel about splitting this into two PRs, one to generalize SupportsOnEachGate to handle >1 qubits, and then a second PR to move on_each into the Gate base class?

some readability concerns raised above. I agree with @maffoo that this change would benefit from being split into the two proposed parts

Sure, I can address those concerns and split into two PRs.

First part added at #4281. We can return to this later then. I'll move it to draft status. @mpharrigan @maffoo

Closing in favor of #4303


[IOTDB-3448] Migrate the logic of deleteRegion onto the consensus module

see jira3448

Coverage increased (+0.01%) to 44.538% when pulling 3dffa2b1006c576496cd98177132b7f321c0c1b0 on jira3448 into 27eeae4e016b839a5f541ae90efc24903143d23b on master.

PTAL @OneSizeFitsQuorum


Why does it follow famous people? How does this get us more followers?

Why does it follow famous people? How does this get us more followers?

Check #22


[Flaky Test] TestPluginTrustedInstall

DockerTrustSuite.TestPluginTrustedInstall tends to be flaky on janky and experimental.
01:48:39 ----------------------------------------------------------------------
01:48:39 FAIL: docker_cli_plugins_test.go:302: DockerTrustSuite.TestPluginTrustedInstall
01:48:39
01:48:39 docker_cli_plugins_test.go:320:
01:48:39     c.Assert(err, checker.IsNil)
01:48:39 ... value *errors.errorString = &errors.errorString{s:"\nCommand: /go/src/github.com/docker/docker/bundles/17.04.0-dev/binary-client/docker plugin enable <IP_ADDRESS>:5000/dockercli/trusted-plugin-install:latest\nExitCode: 1, Error: exit status 1\nStdout: \nStderr: Error response from daemon: error setting up propagated mount dir: invalid argument\n\n\nFailures:\nExitCode was 1 expected 0\nExpected no error\n"} ("\nCommand: /go/src/github.com/docker/docker/bundles/17.04.0-dev/binary-client/docker plugin enable <IP_ADDRESS>:5000/dockercli/trusted-plugin-install:latest\nExitCode: 1, Error: exit status 1\nStdout: \nStderr: Error response from daemon: error setting up propagated mount dir: invalid argument\n\n\nFailures:\nExitCode was 1 expected 0\nExpected no error\n")
01:48:39
01:49:02
01:49:02 ----------------------------------------------------------------------

/cc @anusha-ragunathan @tiborvass @vieux

https://github.com/docker/docker/blob/master/plugin/manager_linux.go#L53 errors due to mount --make-rshared throwing  "invalid argument". It is flaky given that regular plugin installs (not trusted) works and even this test on CI passes majority of the time.

Not sure if this is specific to a host. I found only one occurrence of this failing test on Docker-PRs CI. https://jenkins.dockerproject.org/job/Docker-PRs-experimental/31517/console
@vdemeester : Can you provide links to other failures, so we can see if there's a common host sympton?

Anusha https://github.com/docker/docker/pull/31862 https://jenkins.dockerproject.org/job/Docker-PRs/40395/console

@thaJeztah : I think the fix I have will work for this issue. Once the PR is merged, lets wait atleast a week to ensure there are no more test failures on CI (I couldnt reproduce the issue locally)


'Not connected' 'Connecting' loop on stable, 'Connecting...' forever on beta

In both the beta and latest stable version, yakyak cannot connect

Do you have terminal/console output? Difficult to say what would be the cause otherwise.

Do you have terminal/console output? Difficult to say what would be the cause otherwise.

STABLE:
Starting Yakyak v<IP_ADDRESS>...
using hangupsjs v1.4.0-beta
syncrecentconversations: Asking hangouts to sync recent conversations
2021-07-23 12:37:15 WARN no SAPISID cookie
hangupsjs:: connecting
reconnecting 0
resolving proxy http://plus.google.com
resolving proxy https://plus.google.com
resolved proxy DIRECT
resolved proxy DIRECT
2021-07-23 12:37:15 INFO fetchPvt failed Cannot read property 'length' of null
connect_failed TypeError: Cannot read property 'length' of null
at c:\Users\User\Desktop\yakyakstable\yakyak-win32-x64\resources\app.asar\node_modules\hangupsjs\lib\initdataparser.js:69:19
at _fulfilled (c:\Users\User\Desktop\yakyakstable\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:854:54)
at c:\Users\User\Desktop\yakyakstable\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:883:30
at Promise.promise.promiseDispatch (c:\Users\User\Desktop\yakyakstable\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:816:13)
at c:\Users\User\Desktop\yakyakstable\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:570:49
at runSingle (c:\Users\User\Desktop\yakyakstable\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:137:13)
at flush (c:\Users\User\Desktop\yakyakstable\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:125:13)
at processTicksAndRejections (internal/process/task_queues.js:79:11)
error connecting TypeError: Cannot read property 'length' of null
at c:\Users\User\Desktop\yakyakstable\yakyak-win32-x64\resources\app.asar\node_modules\hangupsjs\lib\initdataparser.js:69:19
at _fulfilled (c:\Users\User\Desktop\yakyakstable\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:854:54)
at c:\Users\User\Desktop\yakyakstable\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:883:30
at Promise.promise.promiseDispatch (c:\Users\User\Desktop\yakyakstable\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:816:13)
at c:\Users\User\Desktop\yakyakstable\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:570:49
at runSingle (c:\Users\User\Desktop\yakyakstable\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:137:13)
at flush (c:\Users\User\Desktop\yakyakstable\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:125:13)
at processTicksAndRejections (internal/process/task_queues.js:79:11)
2021-07-23 12:37:29 WARN no SAPISID cookie
2021-07-23 12:37:29 WARN no SAPISID cookie
2021-07-23 12:37:29 WARN no SAPISID cookie
2021-07-23 12:37:29 WARN no SAPISID cookie
and then it loops again from 'reconnecting 0'
BETA
Starting Yakyak v1.5.12-beta...
using hangupsjs v1.4.0-beta
syncrecentconversations: Asking hangouts to sync recent conversations
2021-07-23 12:39:28 WARN no SAPISID cookie
hangupsjs:: connecting
reconnecting 0
resolving proxy http://plus.google.com
resolving proxy https://plus.google.com
2021-07-23 12:39:28 WARN no SAPISID cookie
resolved proxy DIRECT
resolved proxy DIRECT
2021-07-23 12:39:29 INFO fetchPvt failed Cannot read property 'length' of null
connect_failed TypeError: Cannot read property 'length' of null
at c:\Users\User\Desktop\yakyak-win32-x64\resources\app.asar\node_modules\hangupsjs\lib\initdataparser.js:69:19
at _fulfilled (c:\Users\User\Desktop\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:854:54)
at c:\Users\User\Desktop\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:883:30
at Promise.promise.promiseDispatch (c:\Users\User\Desktop\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:816:13)
at c:\Users\User\Desktop\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:570:49
at runSingle (c:\Users\User\Desktop\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:137:13)
at flush (c:\Users\User\Desktop\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:125:13)
at processTicksAndRejections (internal/process/task_queues.js:79:11)
error connecting TypeError: Cannot read property 'length' of null
at c:\Users\User\Desktop\yakyak-win32-x64\resources\app.asar\node_modules\hangupsjs\lib\initdataparser.js:69:19
at _fulfilled (c:\Users\User\Desktop\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:854:54)
at c:\Users\User\Desktop\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:883:30
at Promise.promise.promiseDispatch (c:\Users\User\Desktop\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:816:13)
at c:\Users\User\Desktop\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:570:49
at runSingle (c:\Users\User\Desktop\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:137:13)
at flush (c:\Users\User\Desktop\yakyak-win32-x64\resources\app.asar\node_modules\q\q.js:125:13)
at processTicksAndRejections (internal/process/task_queues.js:79:11)
2021-07-23 12:39:30 WARN no SAPISID cookie
2021-07-23 12:39:30 WARN no SAPISID cookie
2021-07-23 12:39:30 WARN no SAPISID cookie
2021-07-23 12:39:30 WARN no SAPISID cookie
and then it loops again from 'reconnecting 0'

same thing. YakYak v<IP_ADDRESS> (latest)
reconnecting 0
resolving proxy http://plus.google.com
resolving proxy https://plus.google.com
resolved proxy DIRECT
resolved proxy DIRECT
2021-07-27 11:01:50 INFO fetchPvt failed Cannot convert undefined or null to object
connect_failed TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at keys (/snap/yakyak/117/yakyak/resources/app.asar/node_modules/fnuc/lib/fnuc.js:434:19)
    at values (/snap/yakyak/117/yakyak/resources/app.asar/node_modules/fnuc/lib/fnuc.js:438:16)
    at /snap/yakyak/117/yakyak/resources/app.asar/node_modules/hangupsjs/lib/util.js:12:34
    at /snap/yakyak/117/yakyak/resources/app.asar/node_modules/fnuc/lib/fnuc.js:234:18
    at /snap/yakyak/117/yakyak/resources/app.asar/node_modules/fnuc/lib/fnuc.js:21:18
    at /snap/yakyak/117/yakyak/resources/app.asar/node_modules/hangupsjs/lib/initdataparser.js:47:17
    at _fulfilled (/snap/yakyak/117/yakyak/resources/app.asar/node_modules/q/q.js:854:54)
    at /snap/yakyak/117/yakyak/resources/app.asar/node_modules/q/q.js:883:30
    at Promise.promise.promiseDispatch (/snap/yakyak/117/yakyak/resources/app.asar/node_modules/q/q.js:816:13)
error connecting TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at keys (/snap/yakyak/117/yakyak/resources/app.asar/node_modules/fnuc/lib/fnuc.js:434:19)
    at values (/snap/yakyak/117/yakyak/resources/app.asar/node_modules/fnuc/lib/fnuc.js:438:16)
    at /snap/yakyak/117/yakyak/resources/app.asar/node_modules/hangupsjs/lib/util.js:12:34
    at /snap/yakyak/117/yakyak/resources/app.asar/node_modules/fnuc/lib/fnuc.js:234:18
    at /snap/yakyak/117/yakyak/resources/app.asar/node_modules/fnuc/lib/fnuc.js:21:18
    at /snap/yakyak/117/yakyak/resources/app.asar/node_modules/hangupsjs/lib/initdataparser.js:47:17
    at _fulfilled (/snap/yakyak/117/yakyak/resources/app.asar/node_modules/q/q.js:854:54)
    at /snap/yakyak/117/yakyak/resources/app.asar/node_modules/q/q.js:883:30
    at Promise.promise.promiseDispatch (/snap/yakyak/117/yakyak/resources/app.asar/node_modules/q/q.js:816:13)

I'm seeing the same behavior with <IP_ADDRESS> on Debian.
`Starting Yakyak v<IP_ADDRESS>...
using hangupsjs v1.4.0-beta
syncrecentconversations: Asking hangouts to sync recent conversations
hangupsjs:: connecting
reconnecting 0
resolving proxy http://plus.google.com
resolving proxy https://plus.google.com
resolved proxy DIRECT
resolved proxy DIRECT
2021-07-31 19:11:25 INFO fetchPvt failed Cannot read property 'length' of null
connect_failed TypeError: Cannot read property 'length' of null
`

Never mind.  This was resolved for me by following https://github.com/yakyak/yakyak/issues/1343 - uninstall yakyak, remove local yakyak config, reinstall.

for us technically uninclined where is the config dir on Windows?

for us technically uninclined where is the config dir on Windows?

According to the source, it looks like it should be under your home dir\AppData\Local somewhere, or so it appears.
const windows = name => {
const appData = env.LOCALAPPDATA || path.join(homedir, 'AppData', 'Local');
    return {
            // data/config/cache/log are invented by me as Windows isn't opinionated about this
            data: path.join(appData, name, 'Data'),
            config: path.join(appData, name, 'Config'),
            cache: path.join(appData, name, 'Cache'),
            log: path.join(appData, name, 'Log'),
            temp: path.join(tmpdir, name)
    };

};

I'm seeing the same on MacOS Catalina (10.15.7) installed both from the x64 package (<IP_ADDRESS>) and from homebrew. The login window doesn't come up at all, no yakyak directory in/.config.

Where, exactly, is this config file in Windows 11?  I did a grep in [user]\AppData\Local and found nothing remotely related to yak.  I use YakYak every day and now it is not working at all, exactly as described above; deleting the YakYak install directory and reinstalling it did nothing, presumably because the bad config file is still somewhere around.


Supporting service_timeout as a Proc

I would like to timeout only at specific endpoints, or specific requests (e.g. GET)
I am thinking about supporting service_timeout with a Proc, e.g.
Rack::Timeout.service_timeout = ->(env) do
  if special_case
    false
  else
    15
  end
end

Open for discussion on the alternatives.

Closed as duplicate. Please see #9, #56, #64, #67.


Change directory strategy for each given container manager

I hadn't seen you have created a new repo for the examples. Nice.
Here is my first contribution, feel free to accept or not.

R: @patricklucas take a look.

Patrick if you agree we can work now on making flink also an official chart of kubernetes :)
https://github.com/kubernetes/charts

any update on "making flink also an official chart of kubernetes"?
Is there someone maintaining this? I've been using Flink with our own kubernetes resouces files, based on the documentation. I would prefer using a HELM chart. Trying this chart to set it up HA. No luck yet

Excellent question @VinceMD. I would really love to work on this now. @patricklucas any chance we can do this with your code?

@iemejia I now understand better the HA setup. I could not make it work with this Helm (see https://github.com/docker-flink/examples/issues/4) but I think I got it working with my own manifest files and docker images.
Also consider that document https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65147077 which outlines future changes to Flink to make it leverage the power containers and provisioning job managers and task manager just and only when needed.
With current versions, there are two main ways to set it up HA with Kubernetes and Zookeeper:

Two or more active job managers and a zookeeper cluster. This replicate what you would do in a more traditional infrastructure. As described in the diagram https://ci.apache.org/projects/flink/flink-docs-release-1.4/ops/jobmanager_high_availability.html
If the first jobmanager is not responsive, a new leader is elected. The Flink client is communicating to Zookeeper to find out the details of the new leader.

A single job manager and a zookeeper cluster. The job manager is stateless, so if Kubernetes is able to detect quickly that the Job manager is not healthy (LivelinessProb is critical here), it will kill it and start a new one. The new one will connect to Zookeeper, complain that there is no Leader for a while and that even though Job manager is the same hostname, the leader ID stored in Zookeeper is not the same as the new ID just generated. But it will eventually become the new leader and try to recover jobs.

Benefits of option 1: you don't need to wait for the container to be restarted. It should quickly pivot to the other job manager
Cons of option 1: two job managers consume more resources. One of them is doing nothing. You have to setup two Kubernetes services, one for each job managers. You need to inject the full hostname of the job managers in conf/masters file in each container so that the UI can redirect you to the right URL of the leader job manager. So basically we can't use a single service and 2 pods behind the service. It has to be 2 services and 2 pods. Zookeeper sends you to one or the other. There is not actual load balancer. The clients as well as the tasks manager need to be talking to the right leader, via the right exposed service.
Benefit of option 2: cheaper to run, simpler to configure (only 1 k8s service).
Cons of option 2: without a well defined Liveliness Prob for the job manager (I don't know yet if there is a health check service available for job manager), it may remain in an unhealthy state. So it will never be restarted by Kubernetes. Another issue, even if job manager is indeed restarted, it may take time to pull the container image or something can happen during the boot process. It could further delay the job recovery or might never happen if the pod fail to boot for any reason. Having active/active with leader election in option 1, somewhat mitigates that risk.

@VinceMD will you be up to contribute actively to work on a helm chart ? We can then ask the community and try to make it an official helm chart as we did with the docker image. We can setup a repo for this here and start working on this based on @patricklucas's implementation.

Yes I would need some help with https://github.com/docker-flink/examples/issues/4
I'm planning on using a HELM chart for FLink and Zookeeper soon.
I'm not expert with Flink or HELM but would like to see a community supported project.
We need to be mindful of FLIP-6  so to not do too much work for nothing if the design changes considerably.

After further testing I believe a single Job manager is sufficient in HA mode. I feel more confident it works with the LivenessProb https://github.com/docker-flink/examples/pull/8

Hi folks, thanks for the continued discussion about this. The last few months have been pretty crazy and I let this work fall by the wayside.
Regarding HA-mode: the general consensus has been that the best approach to Flink HA-mode when using a resource manager is to use a single jobmanager. Granted, as you've noticed, this leaves a few things unanswered, such as the best way to do a liveness probe, but I think what you have in #8 is a decent start.
As far as this PR, @iemejia, if you fix up the conflicts and address the one comment I made (just replace that file you moved with a link to the new location) I think we can merge this and move on.

@patricklucas agree. After implementing the liveness prob, I also decided to use a single Jobmanager.


Documentation (Live Web)  Immutable JS Example v6.8.0 Webpack Bundle Error

Are you submitting a bug report or a feature request?
Bug Report
What is the current behavior?

What is the expected behavior?

Sandbox Link
http://redux-form.com/6.8.0/examples/immutable/
What's your environment?

Firefox 53.0.3 and Chrome 59.0.3071.86 (Official Build), Ubuntu 16.04
Other information
Just saw that you updated the project to 6.8.0 and added immutableProps to the form config :+1:
So I went to the Immutable JS example to see if it was updated (habitual check if examples changed when the docs have changed) thus this issue.
Hope this helps in bringing a quick fix. But if no time is available to give to it I would be more than happy to address it when I myself get some time later today or tomorrow.
Love the project, thank you @erikras and contributors for the continued development

Yep, working on it. Same as #3038.
That's what I get for releasing late on a Friday. 🤦♂


Support for enter and exit animations

This adds support for enter and exit animations for NotificationItem.
Previously the initial class given to the NotificationItem component was .notification-hidden and immediately changed to .notification-hidden this causes the notifications to always have the same transition animation from .notification-visible to .notification-hidden and the other way but in reverse transition.
Now there's a difference between the initial state of the NotificationItem.
When state.visible is undefined it means that the NotificationItem is first rendered
When state.visible is true it means that the NotificationItem is transitioning to a visible state
When state.visible is false it means that the NotificationItem is transitioning to a hidden state
This fixes issue #83

@OriR the tests are failing. Can you take a look?

@igorprado I've fixed the tests + added one more for the new behavior.

@igorprado is there anything more you'd like me to add here?

🚀


[Help Wanted] React Native maintainer

I have primarily focused my efforts on the Android version of Lottie and don't actively use the React Native one for any of my projects. Would anybody like to help me out and become a more active maintainer of  this projects so it doesn't get stale?

Yeah totally! We use this a lot internally so if there are ways I can help out I'd be totally down. Are there some specific tasks you have mind?

@cdlewis Awesome!
Some things that come to mind are:

Helping triage/handle issues
Reviewing PRs
Updating to the test version of lottie (2.5.0 is now out on both platforms)
Adding bridges for new features

@cdlewis Can you email me at my first name dot last name at airbnb.com if you're interested? I can help you ramp up.

Hey @gpeal, I'm also interested since we use this library on several projects at BAM. I'm sending you an email :)

When I use this plug-in, the image will not be rendered, although I have introduced these files, what is the problem?This is my code structure.
<LottieView
        ref={Animation => {
          this.Animation = Animation
        }}
        // progress={this.state.progress}
        source={require('../../data.json')}
        autoSize={true}
        imageAssetsFolder="images"
        speed={1}
        autoPlay={true}
        loop={true}
        />


Improves the UI of webpage by Changing the positioning of image,button, text and also changes the font-family of the webpage.

I improved the UI of the webpage and make it more user-friendly. So that user can interact with the web-page more comfortably.
I changed the positioning of the elements, edited the buttons styles and font-family of the whole web-page.
This is all about my contribution.

@ankur0904  All things looks great , just do  one thing make the Sucessfully login text colour to  Red .

Changed font color. Please check it.

Looks Great to me , Looking forward to see more contribution from your side .
Happy open source !
☺


ps auxf does not work

It seems that build 14328 made "ps aux" work, but "ps auxf" still does not.

#192

For information: still does not work on build 14352

@xilun You are correct, fix is still on the way to the flighting branch.

Works for me on 14361.


Add "Communicating with other packages" section to docs

I'd like to provide more guidance on service names. The approach I originally envisioned is that the services would form a dot-separated namespace so that each package could own its own top-level namespace, like autocomplete-plus.completion-provider. Then the atom namespace would be reserved for core services like atom.repository-provider.
It's interesting that people are gravitating toward - separated names instead of camel-case. I sort of wish config were that way now.

I'll open a PR on the docs.


Starting the current devlopment Windows installer provides no user notification on startup

OS :  ALL Windows
The installer should provide some immediate notification that the installation or upgrade process is underway to prevent the user from starting the process twice. There is a very long pause between the initial "start" and the fist dialog box that being the python installation. This also dramatically affects windows ka-lite upgrades because in that process the prior installation is uninstalled and having both running out of sync at the same time can cause the system to get stuck trying to both install and uninstall simultaneously.

This may only be an issue where the user has a previous version of python installed (such as an upgrade) otherwise there is a pretty quick notification that python will be installed.

Do you mean that after launching the installer executable, there is a long pause before anything noticeable happens?

Do you mean that after launching the installer executable, there is a long pause before anything noticeable happens?

I'd noticed the same thing on some windows virtual machines. There it turned out the problem was a windows service using all the available resources. Stopping that service caused the installer to proceed normally.


Update implementation-notes.md

prevChild could be CompositeComponent which cause prevChild.node to be undefined

We require contributors to sign our Contributor License Agreement, and I don't think we have you on file.
In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.
(Sorry for the awkwardness here. I'm still getting the new repo setup. Normally this comment is automated.)


Generate pages corresponding to Markdown files in directories

TypeDoc currently includes the content of README.md in the generated index.html. It would be useful if README.mds in subdirectories also caused corresponding pages to be generated.
This should probably be labelled enhancement and plugin idea.

This is something I'd like to include in TypeDoc itself, but will probably be a part of the guides work that's planned for 0.24, probably won't happen for a while...

Another, maybe simpler way, would be to just list a docs files with their path and create static docs from it, in a separate menu. Just to wrap existing docs into code-generated one.

I see the Guides project board is now closed - do there happen to be plans for this idea now?

I would go one step further and say that generally all md files should be taken into account.
Suggested Solution
Similar to what Compodoc does, it would be extremely helpful if typedoc would consider md (Markdown) files that are in the same directory as the class and have the same filename. These MD files could be displayed in a tab from the displayed class or linked quite high up in the document.
Example

startup-config.service.ts
startup-config.service.md (this is the md file that belongs to the file above and should be integrated into its documentation)

Another vote for this. We have a monorepo-like structure with components living in their own directories, with their own READMEs. It would be nice if those READMEs were also picked up by typedoc.

Fixed with TypeDoc 0.26, which is releasing 2024/06/21


not opening vaex file (h5vaex False) -- can't find a bug and no error message

Very strangely, I had install vaex on a clean python distribution and now opening a file does not seems to do anything without raising any issue.
vaex.open('./gums18_mw_S000322010.hdf5')
I expected to return a Hdf5MemoryMapped instance but returns None
The file works on a different machine (not going through updates)
list(h5py.File('gums18_mw_S000322010.hdf5', "r")['/table'].items())
Does list columns and expected content.
it seems it does not recognize the format for some unknown reasons, below I expect
h5vaex True which appends on the other machine.
for name, class_ in list(vaex.file.other.dataset_type_map.items()):
     print(name, class_.can_open('./gums18_mw_S000322010.hdf5'))

buist False
fits False
h5vaex False
amuse False
gadget-hdf5 False
soneira-peebles False
zeldovich False
ascii False
gadget-plain False
votable False
tap False

I do not know if this bug is from Vaex or a bunker library, but I do not have any reported info as to where it fails... any idea?

For some reasons pip or conda did not install the git master properly and obtained an old version of at least vaex/file/other.py.
It seems corrected after forcing installation.
However, I suggest to raise an exception when no format was found.

Hi Morgan,
there are two issues here, one is a change in file format (the latest git has a better format that allows masked values), but it still understands the older format, and that you've resolved yourself.
The second issue is that if it fails to open a file, it will return None. The reason is that every reader is tried, so if the hdf5 one fails, it will try others and does not know for instance that a file should be able to be opened with the hdf5 reader but due to some bug failed to.
I think a better behaviour would be:

have a file extension to reader mapping, so .hdf5 will be tried by that specific class
if it fails, it will try all the others
and if that still didn't get to anything, it will print out the stacktrace by the initial attempt of opening the file

Do you agree?
cheers,
Maarten

I don't know if you want to check the extension itself. Sounds a good idea to try.
I suggested to raise an issue if none of the readers work. Of course that does not fully says why, but at least would not a code run with a None object.

Fixed in master a while ago.


Docs: clarify not to use chrome installed by snap on Linux

The chrome browser that we are using can be installed by the snap, which is popular in these years and is the default package manager on Ubuntu Desktop. But the namespace mechanisms limits many allowances that causes the failure invoking from the puppeteer plugin of Koishi.
Therefore, we should clarify the disadvantages of using snap to install the chrome with the puppeteer plugin and suggest some alternatives methods.

Updated in #31


ERROR Issue

A fatal error occurred
A fatal unexpected error has occurred and Oasis-wallet must stop. Please copy report this issue below on our github account. You can also try refreshing page to see if the issue persists. Once you leave this page, all of your wallets will be closed.
The above error occurred in task Za
created by Xa
created by takeEvery(staking/fetchAccount, Xa)
created by er
Tasks cancelled due to error:
takeEvery(staking/fetchAccount, Xa)
takeEvery(staking/validatorSelected, Qa)

Duplicate of https://github.com/oasisprotocol/oasis-wallet-web/issues/403


Restore context correctly

Fixes #54

@rocketraman can you sign your commits? You can use GPG, SSH, or SMIME for that (I use all three in various places).

@rocketraman can you sign your commits? You can use GPG, SSH, or SMIME for that (I use all three in various places).

Yep. Do you want me to rebase this PR with a signed commit, or for the future only?

@jvz Is it possible to release a 1.3.1 with this change? I'm using it in a project which extensively uses logging contexts, and without this change, things are royally messed up.

@rocketraman check this out https://logging.apache.org/logging-parent/latest/#release-instructions and see if you can start the release.

@jvz If I want to do a 1.3.1 release, what is the recommended approach in terms of branches?  Create branch release/1.3.1 of off tag rel/1.3.0 and cherry-pick my change into it?


Returning Account object after inserting new value into Account table in db

Hey guys,
I am new to MyBatis so  I hope you guys do not mind me asking a couple of questions.

When trying to insert into db , it does not return the object I am saving, is it possible to return that object somehow ? if not then how can i approach a situation when I have a method create account and after hitting the controller it should return account object its generated id and other fields?

Below is the method which i would like to return Account
 @Options(useGeneratedKeys=true, keyProperty = "id", keyColumn="id")
 @Insert("INSERT INTO ACCOUNT(customerId,country) values (#{customerId},#{country})")
 void createAccount(Account account);

If i have a Balance table and Account table and account should have list of Balance  and when somebody calling createAccount it  passes list of balances how would i proceed using mybatis ?

public class AccountCreateRequest {
    private Long customerId;
    private String country;
    private List<String> currencies;
}

public class Account {

    @Id
    private Long id;

    @Column("country")
    private String country;

    @Column("customerId")
    private Long customerId;

    List<Balance> balances;

}

Closed in favor of StackOverflow.


Computed value without setter is not writable

What problem does this feature solve?
https://github.com/vuejs/vue-next/blob/d66211849ca174c4458b59d3df5569730ee224f6/packages/reactivity/src/baseHandlers.ts#L95-L96
Computed value without setter (and the default setter is production ? noop : warn) is not writable, here should skip this case, don't set target[key].value, and leave it to the rest part of function to set target[key].
But before PR, I want to ask clearly -- why here set target[key].value preferentially, rather than write target[key]? Why not treat everything as the same, no matter it is ref (readonly or not) or computed (getter only or with setter)?
If we fix this problem, getter-only computed value is skipped, how should we treat the others? I think the rule should be explicit and written in spec doc.
What does the proposed API look like?

It should still attempt the write to trigger the warning. Otherwise it just fails silently.

@yyx990803 Why not set on the target to replace that computed like the other cases do?
https://github.com/vuejs/vue-next/blob/d66211849ca174c4458b59d3df5569730ee224f6/packages/reactivity/src/baseHandlers.ts#L104
While running this function, user is just trying to set value on target[key], not on target[key].value, the latter is just an preferred optimization. A warning and failure just because optimization error which can't be avoid will be amazing.
import * as Vue from 'vue';
const computed = Vue.computed(() => 1);
const data = { a: computed };
data.a = 2;// warning and fails -- and can't avoid, unless:
data.a = Vue.ref(2);// Is this intended? If so, throw an error would be better than just warn.
                              // like write to readonly value in strict mode throwing an error.

How do you think?

The latter doesn't seem intended to me, rather like a bug.

The latter made a rewrite of Ref, using ref(2) to replace the computed ref a. Details can be found here https://github.com/vuejs/vue-next/blob/master/packages/reactivity/tests/reactive.spec.ts#L200-L213. But I think we should ban this behavior, the first reason is that it will cause TS type mismatch:

Another reason is that ban this behavior can avoid confusion for users, as @LongTengDao showed above.


Map View - SCANS data aggregation issue

Hi all,
I've noticed that the map seems to be showing multiple surveys for SCANS within the grid cells. I've checked the data for duplication (showing 14 surveys within each cell).

I checked the data and didn't see any obvious duplication in the effort table. Could you check why the map might be showing 14 surveys in each cell? I'll continue to check the data uploaded - if this is a problem caused by the data I'll fix and re-upload.

Thanks Niki, it was a bug and it's solved now :)

ok closing this then 🤓


Add support for Optimism

The Multicall contract is deployed and verified:

Kovan Optimism: https://kovan-optimistic.etherscan.io/address/0x4afaa782d74825a267e40ae2a231c271d1c392c3
Optimism: https://optimistic.etherscan.io/address/0x7cbc68dc836e05833cf88b6676715db805b5c0a2

resolves #26

Can this get merged? Seems like a straight-forward addition

ping @cavanmflynn can we get this merged please?

For anyone who is interested to use this library w/ Optimism support, I have temporarily forked to @kargakis/ethers-multicall until this PR gets merged.

are you alive?

For anyone looking for a live, tested and maintained alternative to ethers-multicall, please move to ethers-multicall-provider