Use constants for transaction versions.

This change is

Codecov Report

Merging #904 (9fa8184) into barak/v3_adj/invoke (4dc7e64) will decrease coverage by 0.04%.
The diff coverage is 80.00%.

@@                   Coverage Diff                   @@
##           barak/v3_adj/invoke     #904      +/-   ##
=======================================================
- Coverage                68.40%   68.36%   -0.04%
=======================================================
  Files                       42       42
  Lines                     5864     5857       -7
  Branches                  5864     5857       -7
=======================================================
- Hits                      4011     4004       -7
  Misses                    1481     1481
  Partials                   372      372

Files Changed
Coverage Δ

.../blockifier/src/transaction/account_transaction.rs
93.90% <71.42%> (-0.08%)
:arrow_down:

crates/blockifier/src/block_context.rs
58.82% <100.00%> (ø)

crates/blockifier/src/execution/entry_point.rs
93.98% <100.00%> (ø)

crates/blockifier/src/transaction/objects.rs
38.70% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged in the following PRs: 1, 2, 3.


Update Find-DbaDbGrowthEvent.ps1 link and examples

Update Find-DbaDbGrowthEvent.ps1 link and examples to use new command name ("Find-DbaDbGrowthEvent' instead of "Find-DbaDatabaseGrowthEvent").

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[x] Documentation
[ ] Build system

Purpose

Approach

Commands to test

Screenshots

Learning

awesome, thank you! 🔥


Visual studio locks up when I create project from Existing Node.js Source

After creating a new project the VS UI locks up completely and I need to end task VS. I then open the project and all is well.
Is there any way I can find out what's happening?
I have tried:

Stripping project down to empty index.js and simple package.json created with "npm init"
removing all spaces from the path - C:\Users\Steve\Documents\projects\spikes\hapi-book
disabling "add to version" control in the create wizard - which seems to do nothing anyway
disabling  / removing various VS extensions

I have VS community 2015 and updated everything to latest
Any ideas?

Does this happen with the RC2 version of node tool? Also, does this happen when you add the new project to a existing solution or creating a new solution?

Do you happen to have a bower_components or node_modules folder that is not at the root of your project?
See #430 (which I just filed)

@zhengbli I didn't see RC2 so just downloaded 1.1 (I did reinstall it just in case)
@mousetraps No. I stripped down to just an empty index.js and simple package.json with no more files and folders.

@zhengbli where can I find RC2?

@SteveALee You can find the download link at aka.ms/ntvslatest

Also can you do the following to help us diagnose the problem:

open task manager, go to "details" tab
right click on one of the column names, choose "select columns"
check "command line" in the list
repro the problem, and take a screenshot of the task manager details tab with the "command line" column, so we can figure out what is taking up the resources.

Thanks!

Ah, didn't know about that column - useful. Will have a go over next few days.

The UI is locked but nothing much is happening with devenv.exe - it appears to be 0 cycles. This is the screen shot of VS straight after creating the project

Here is my package.json

{
  "name": "dindin",
  "version": "0.0.0",
  "description": "wibble",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC"
}

Index.js is empty (but same problem if it has content)
.njsproj

        Debug
        2.0
        {1bf69820-c08a-4207-8084-5f6b180e52ff}

        ShowAllFiles
        index.js
        .
        .
        {3AF33F2E-1136-4D97-BBB7-1795711AC8B8};{349c5851-65df-11da-9384-00065b846f21};{9092AA53-FB77-4645-B42D-1CCCA6BD08BD}
        11.0
        $(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)

              False
              True
              0
              /
              http://localhost:48022/
              False
              True
              http://localhost:1337
              False

              CurrentPage
              True
              False
              False
              False

              False
              False

The path C:\Users\Steve\Documents\projects\spikes\hapi-book-Copy.vs\NodejsApp1\v14 is empty

@SteveALee I tested using your files and couldn't repro the problem. And as the content of the .njsproj is parsed by GitHub somehow I cannot see all of it. Could you put it as a gist and share the link? Thanks!

@zhengbli oh what a mess. I thought markdown escaped that critical tags. Will sort out.

@zhengbli Please see https://gist.github.com/SteveALee/a9f838b79639949ac879

Ok the njproj file is identical to what I have on my machine, except the projectGuid. That means it can create the project fine, only has problems when trying to open it. A recent fix at #396 might be related to that part. Although @mousetraps @billti do you have any idea why no .suo files are generated?

The .suo files are an artifact of Visual Studio, and not specific to NTVS. Are they being created for other project/solution types? If not, then it would seem to be a general VS error.
Is there anything unique/interesting about this configuration? Are you creating projects on a local drive? Do you have My Document redirected? Any other extensions installed into VS? etc.

@billti Perhaps the lack of .suo files are due to having no code in the index.js?
Nothing unusually interesting. here :)
I disabled all the new extensions. Also moved test project folder to c:.
In desperation I have uninstalled VS (13 and 15), removed all the Azure and SQL server items left and reinstalled VS community using typical rather than full. Also re installed NTVS 1.1 RC2. I probably uninstalled too much as VS install errored about SQL Server compact 4 missing path (haven't resolved that one yet) and VS errors on startup about the resource manager package not loading properly.
The bad news is VS STILL locks up after adding the new project. It's just that now the VS UI is in a incomplete state and not showing the main window
I wonder is it possibly as I am not using TFS?
Anyway I can at least work around it by restarting VS and as you can't see it perhaps mark as cannot reproduce?
Now I need to sort out my VS installation.

@SteveALee Hi Steve, we just updated the RC2 with a couple of fixes that may be related to your situation. If you have time could you give it a shot? https://github.com/Microsoft/nodejstools/releases/tag/v1.1-RC.2.1

@zhengbli  any chance of a binary?

Scratch that, I read the notes.  :)

Yes! That fixes it!
Not sure from release notes why was problem but I'm happy now. Just need to restore VS to fully working.
Thanks.

I just tried to add create new from some existing code and it froze again, requiring a task kill and restart
This is the code
https://github.com/GPII/windows
or rather my fork, but that is unchanged

Spotted the new release "9-17-2015 Dev Build" so tried it but still hangs on create new project

I notice this after installing nvm-windows with node 4.1.0 and rolling back to 0.12.x. Nvm-windows messes with the path for npm (but don't know if that affects VS/NTVS) and also makes the %ProgramFiles% a NTFS symbolic link.
Will rollback at some point and retest.

I just tried again using latest nodejstools release, nvm-windows and node 0.10.40 and it still freezes :(

Hmm... Still can't repro... Can you try a simple experiment? temporarily rename your global node_modules folder (the one listed when you execute "npm bin -g"). Then add from existing with mostly empty folder (no npm modules installed).

Also are any node processes showing up in task manager when this issue occurs? If so, what are the corresponding contents of the "command line arguments" column in the details pane?

OK - complete steps

Create new blank console app NodejsConsoleApp1 in C:\Users\Steve\Documents\projects\
rm NodejsConsoleApp1.sln .vs\ NodejsConsoleApp1\NodejsConsoleApp1.njsproj
new project from source NodejsApp1 C:\Users\Steve\Documents\projects\NodejsConsoleApp1\NodejsConsoleApp1\ Create new solution

UI responds for a second or 2 as I mouse over Team Explorer but then freezes.
There are a bunch of node process but they are from web analyser which I installed after the problem reoccurred. When I previously looked during this state there were no node task

SO I killed all those node process (appears to be a bug win web analyser) and disabled web analyser extension but have exactly the same symptoms.

Thanks, looks like we'll need some more info then... would you mind sending us a dump of devenv.exe when the issue occurs? The quickest way to create a dump is by right clicking the process in Task Manager, and selecting "create dump file". Process explorer, procdump, etc. also work. You can either upload it somewhere and post a link here, email it to me, or send it to ntvshelp at microsoft com.
Thanks for your patience so far - hopefully we can get to the bottom of it soon!

Minidump is http://opendirective.net/NTVS/devenv.zip (~300MB).
Note that the NodejsApp1.njsproj was created by VS but no other project files where.

Thanks! Now we're getting somewhere :smiley:
Stack trace of the main thread:
 	[Managed to Native Transition]
 	WindowsBase.dll!System.Windows.Threading.DispatcherSynchronizationContext.Wait(System.IntPtr[] waitHandles, bool waitAll, int millisecondsTimeout)	Unknown
 	mscorlib.dll!System.Threading.SynchronizationContext.InvokeWaitMethodHelper(System.Threading.SynchronizationContext syncContext, System.IntPtr[] waitHandles, bool waitAll, int millisecondsTimeout)	Unknown
 	[Native to Managed Transition]
 	[Managed to Native Transition]
 	mscorlib.dll!System.Threading.WaitHandle.InternalWaitOne(System.Runtime.InteropServices.SafeHandle waitableSafeHandle, long millisecondsTimeout, bool hasThreadAffinity, bool exitContext)	Unknown
 	mscorlib.dll!System.Threading.WaitHandle.WaitOne(System.TimeSpan timeout, bool exitContext)	Unknown
 	mscorlib.dll!System.Threading.WaitHandle.WaitOne(System.TimeSpan timeout)	Unknown
>	Microsoft.ApplicationInsights.dll!Microsoft.ApplicationInsights.Channel.InMemoryTransmitter.Runner() Line 94	C#
 	mscorlib.dll!System.Threading.Tasks.Task.InnerInvoke()	Unknown
 	mscorlib.dll!System.Threading.Tasks.Task.Execute()	Unknown
 	mscorlib.dll!System.Threading.Tasks.Task.ExecutionContextCallback(object obj)	Unknown
 	mscorlib.dll!System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, object state, bool preserveSyncCtx)	Unknown
 	mscorlib.dll!System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, object state, bool preserveSyncCtx)	Unknown
 	mscorlib.dll!System.Threading.Tasks.Task.ExecuteWithThreadLocal(ref System.Threading.Tasks.Task currentTaskSlot)	Unknown
 	mscorlib.dll!System.Threading.Tasks.Task.ExecuteEntry(bool bPreventDoubleExecution)	Unknown
 	mscorlib.dll!System.Threading.Tasks.SynchronizationContextTaskScheduler.PostCallback(object obj)	Unknown
 	WindowsBase.dll!System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate callback, object args, int numArgs)	Unknown
 	WindowsBase.dll!System.Windows.Threading.ExceptionWrapper.TryCatchWhen(object source, System.Delegate callback, object args, int numArgs, System.Delegate catchHandler)	Unknown
 	WindowsBase.dll!System.Windows.Threading.DispatcherOperation.InvokeImpl()	Unknown
 	WindowsBase.dll!System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(object state)	Unknown
 	mscorlib.dll!System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, object state, bool preserveSyncCtx)	Unknown
 	mscorlib.dll!System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, object state, bool preserveSyncCtx)	Unknown
 	mscorlib.dll!System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, object state)	Unknown
 	WindowsBase.dll!System.Windows.Threading.DispatcherOperation.Invoke()	Unknown
 	WindowsBase.dll!System.Windows.Threading.Dispatcher.ProcessQueue()	Unknown
 	WindowsBase.dll!System.Windows.Threading.Dispatcher.WndProcHook(System.IntPtr hwnd, int msg, System.IntPtr wParam, System.IntPtr lParam, ref bool handled)	Unknown
 	WindowsBase.dll!MS.Win32.HwndWrapper.WndProc(System.IntPtr hwnd, int msg, System.IntPtr wParam, System.IntPtr lParam, ref bool handled)	Unknown
 	WindowsBase.dll!MS.Win32.HwndSubclass.DispatcherCallbackOperation(object o)	Unknown
 	WindowsBase.dll!System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate callback, object args, int numArgs)	Unknown
 	WindowsBase.dll!System.Windows.Threading.ExceptionWrapper.TryCatchWhen(object source, System.Delegate callback, object args, int numArgs, System.Delegate catchHandler)	Unknown
 	WindowsBase.dll!System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority priority, System.TimeSpan timeout, System.Delegate method, object args, int numArgs)	Unknown
 	WindowsBase.dll!MS.Win32.HwndSubclass.SubclassWndProc(System.IntPtr hwnd, int msg, System.IntPtr wParam, System.IntPtr lParam)	Unknown
 	[Native to Managed Transition]

It looks like the main thread is blocked at a WaitOne call in ApplicationInsights (which we use for some of the new telemetry work in RC2.)
@sanyamc-msft any ideas?

Great!

I don't know if this is relevant as collateral damage but when I open my existing project after killing VS a number of files show as VC pending edit in the solutions explorer. However there are no diffs shown and git status shows no pending commits (as expected)
Any ideas how I might investigate this one?

I experience this issue as well,
in order to get it working, I had to delete the .suo file

@MoLo interesting as I didn't get a .suo file generated. Only the .nsjproj.

I have this problem as well. Here is the exact code that I was trying to create a project for - https://github.com/ThoughtWorksStudios/node-aws-lambda

Hmm... is this also broken for you in NTVS 1.1 RC? If not, then it can't be due to the recent telemetry changes, so something else is amiss...

@SteveALee @waynebloss I think I managed to fix this. Mind trying out this private build?
https://github.com/mousetraps/nodejstools/releases/tag/import

@mousetraps Wow, thanks! I just tried it and it fixed the issue on my machine.
Should I just continue running this build for now or would you recommend installing the 10-14-2015 Dev Build release for any reason?

@mousetraps :+1:  \0/ it fixes it for me.
@waynebloss Looks like it's already in that pre-release :)

Actually this is the diff (I didn't tag it correctly when creating the release)
https://github.com/Microsoft/nodejstools/compare/v1.1.Dev-10.14.2015...mousetraps:import

Oh, so you uploaded a binary for the release that did match the tag? They should detect that :)
So that diff makes a little more sense to me given the problem :)

The fix is now available in our latest dev build

Excellent- thanks very much!
Steve Lee
OpenDirective http://opendirective.com
On 20 October 2015 at 15:42, Sara Itani<EMAIL_ADDRESS>wrote:

The fix is now available in our latest dev build
https://github.com/Microsoft/nodejstools/releases
—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/nodejstools/issues/427#issuecomment-149588673
.

I'm running into this same issue.  Repro is slightly different.  When loading an existing project I encounter the same hang in the VS main thread due to App Insights.
I was using the 1.1 Release.  Rolling back to 1.0 resolves the hang.
Let me know if more information would be of use.


Release google-auth-library-java v0.12.0

This pull request was generated using releasetool.
11-14-2018 14:53 PST
Implementation Changes

Show error message in case of problems with getting access token (#206)
Add note about NO_GCE_CHECK to metadata 404 error message (#205)

New Features

Add ImpersonatedCredentials (#211)
Add option to suppress end user credentials warning. (#207)

Dependencies

Update google-http-java-client dependency to 1.27.0 (#208)

Documentation

README grammar fix (#192)
Add unstable badge to README (#184)
Update README with instructions on installing the App Engine SDK and running the tests (#209)

Internal / Testing Changes

Cleanup ImpersonatedCredentials (#212)
Add codecov (#201)
Kokoro release (#200)
Enable releasetool (#202)
Add CODEOWNERS and issue/pr templates (#203)
Fix snapshot version in pom files and fix urls after repo move (#196)
Fix warnings (#199)
Add Kokoro continuous job configs (#197)
Add windows Kokoro test config (#181)
Fix assorted warnings (#186)
0.11.0 has been released (#182)
Add Kokoro CI config (#180)

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8225b92). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #213   +/-   ##
=========================================
  Coverage          ?   76.86%
  Complexity        ?      327
=========================================
  Files             ?       21
  Lines             ?     1465
  Branches          ?      158
=========================================
  Hits              ?     1126
  Misses            ?      260
  Partials          ?       79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8225b92...3faaf2b. Read the comment docs.

Release is at https://github.com/googleapis/google-auth-library-java/releases/tag/v0.12.0


Not loading

The notebook does not appear to load.

Do you have some more details?Op 14 apr. 2017 17:43 schreef emoriebeck notifications@github.com:The notebook does not appear to load.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

I've tried on different web browsers and computers.

This is presumably a problem in how GitHub itself tries to present the notebook. I'll check it out. But if you download the notebook and run it in jupyter, it should work fine.It's easiest to clone the whole repository, otherwise ensure that you have also downloaded the ighelper.py file.Op 14 apr. 2017 18:03 schreef emoriebeck<EMAIL_ADDRESS>I've tried on different web browsers and computers.
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.

It loads fine in my browser on my laptop (although it doesn't work no my mobile). What browser, what OS and what system (CPU & memory) are you on?


ValueError: 0.5/0.75 is not in list - when passing a custom set of IoU thresholds to MeanAveragePrecision

🐛 Bug
When I try to use MeanAveragePrecision to compute the mAP over a custom range of IoU thresholds, a value error is thrown if 0.5 and 0.75 are not included in the list.
This is due to these values being hardcoded here.
To Reproduce
Steps to reproduce the behavior...
Traceback (most recent call last):
 line 27, in <module>
    print(map.compute())
  File "C:\Users\hughesc\Anaconda3\envs\accelerated-dev\lib\site-packages\torchmetrics\metric.py", line 440, in wrapped_func
    value = compute(*args, **kwargs)
  File "C:\Users\hughesc\Anaconda3\envs\accelerated-dev\lib\site-packages\torchmetrics\detection\mean_ap.py", line 766, in compute
    map_val, mar_val = self._summarize_results(precisions, recalls)
  File "C:\Users\hughesc\Anaconda3\envs\accelerated-dev\lib\site-packages\torchmetrics\detection\mean_ap.py", line 656, in _summarize_results
    map_metrics.map_50 = self._summarize(results, True, iou_threshold=0.5, max_dets=last_max_det_thr)
  File "C:\Users\hughesc\Anaconda3\envs\accelerated-dev\lib\site-packages\torchmetrics\detection\mean_ap.py", line 570, in _summarize
    thr = self.iou_thresholds.index(iou_threshold)
ValueError: 0.5 is not in list

Code sample
import torch
from torchmetrics.detection import MeanAveragePrecision

if __name__ == '__main__':

    device = torch.device('cuda:0')

    preds = [
        dict( boxes=torch.tensor([[1.5, 2., 3., 4.]], device=device),
        scores=torch.tensor([0.6], device=device),
        labels=torch.tensor([1], device=device),)
    ]

    targets = [
        dict(boxes=torch.tensor([[1., 2., 3., 4.]], device=device),
             scores=torch.tensor([0.8], device=device),
             labels=torch.tensor([1], device=device), )
    ]

    map = MeanAveragePrecision(class_metrics=True,
                               iou_thresholds=[0.1, 0.2],
                               ).to(device)

    map.update(preds, targets)

    print(map.compute())

Expected behavior
Ideally, I would like to be able to calculate mAP using any custom range of IoU values, or even a single value if it is passed as a list (e.g. [0.4]). Although this is a departure from the pycoctools implementation, this would make this metric well suited to use cases outside of the coco competition.
At a minimum, this restriction should be documented, and the error should be handled more gracefully.
Environment

OS (e.g., Linux): Windows, Ubuntu
Python & PyTorch Version (e.g., 1.0): Python 3.8 & 3.9, PyTorch 1.10
How you installed PyTorch (conda, pip, build command if you used source): conda
Any other relevant information:

I am facing the same issue when passing a single threshold, which I need to do some error analysis.
Maybe a potential solution is to have an optional argument at the beginning set by default at [0.5, 0.75] to indicate the desired thresholds to be reported? Then would be possible to iterate over the asked thresholds and report them? If you like the idea, maybe I could give it a go and do a PR.

Hi @Chris-hughes10 and @bepuca,
I created PR #995 to address this. We will simply check for the 0.5 and 0.75 in the list of thresholds and if they are not present we will set them to -1. Hope this works for your both :]

Thank you very much for such a quick response @SkafteNicki !

I know the issue is closed, but I feel the solution proposed is not the best case. Shouldn't the metric be general enough to provide mAP for any IOU?


clang-tidy-rule: Filter out headers

Here in gnss-converters we pass headers as source files. In clang-tidy-rule we iterate over sources and run clang-tidy on them.
Since a header is not a final compilation unit, we cannot be sure if this will work. If we want to keep passing headers as source files, we have to filter them out in clang-tidy-rule.

Yes, headers will be linted if included in a source file.
I added a comment.


read IdPEntityId from identity.xml

Fixed with https://github.com/wso2/carbon-identity/commit/104c4e33fa407c66b58dfbf05660a213965e7eb7


[ALLUXIO-2608] Deprecate Throwables.propagate with RuntimeException in RetryHandlingMetaMasterClient.java

https://alluxio.atlassian.net/browse/ALLUXIO-2608
Deprecate Throwables.propagate with RuntimeException in RetryHandlingMetaMasterClient.java

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14027/
Test PASSed.


docs: renamed documentVisibilityState to injectDocumentVisibility

Renamed documentVisibilityState to injectDocumentVisibility to align with our naming convention for injectable functions, enhancing code readability and consistency.

I'll add a migration for this one and fix the CI issue

Tested the migration and it worked


[WIP]RSP-1565: ButtonGroup to use collection Item and context

Closes
✅ Pull Request Checklist:

[ ] Included link to corresponding Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Team:

I think this PR was superseded by the collection builder one.


Proposal: Cross-Implementation Benchmarking Dataset for Plutus Performance

Describe the feature you'd like
I'm working on a C++ implementation of Plutus aimed at optimizing batch synchronization. We'd like to benchmark our implementation against existing open-source Plutus implementations to foster cross-learning and understand their relative performance. This issue is a request for feedback on the proposed benchmark dataset, as well as for approved code samples representing your implementation to include in our benchmarks. Detailed information is provided below.
The proposed benchmark dataset is driven by the following considerations:

Predictive Power: Benchmark results should allow us to predict the time required for a given implementation to validate all script witnesses on Cardano’s mainnet.
Efficient Runtime: The benchmark should complete quickly to enable rapid experimentation and performance evaluation.
Parallelization Awareness: It must assess both single-threaded and multi-threaded performance to identify implementation approaches that influence the parallel efficiency of script witness validation.
Sufficient Sample Size: The dataset should contain enough samples to allow computing reasonable sub-splits for further analysis, such as by Plutus version or by Cardano era.

The procedure for creating the proposed benchmark dataset is as follows:

Transaction Sampling: Randomly without replacement select a sample of 256,000 mainnet transactions containing Plutus script witnesses. This sample size is chosen as a balance between speed, sufficient data for analysis, and compatibility with high-end server hardware with up to 256 execution threads. The randomness of the sample allows for generalizable predictions of validation time of all transactions with script witnesses.
Script Preparation: For each script witness in the selected transactions, prepare the required arguments and script context data. Save each as a Plutus script in Flat format, with all arguments pre-applied.
File Organization: For easier debugging, organize all extracted scripts using the following filename pattern: <mainnet-epoch>/<transaction-id>-<script-hash>-<redeemer-idx>.flat.

To gather performance data across open-source Plutus implementations, I am reaching out to the projects listed below. If there are any other implementations not listed here, please let me know, as I’d be happy to include them in the benchmark analysis. The known Plutus implementations:

https://github.com/IntersectMBO/plutus
https://github.com/pragma-org/uplc
https://github.com/nau/scalus
https://github.com/OpShin/uplc
https://github.com/HeliosLang/uplc
https://github.com/HarmonicLabs/plutus-machine

I look forward to your feedback on the proposed benchmark dataset and to your support in providing code that can represent your project in this benchmark.
Describe alternatives you've considered
No response

The randomness of the sample allows for generalizable predictions of validation time of all transactions with script witnesses.

I suppose this will give you the most popular scripts rather than the most diverse ones. But I think that's fine.
So what do you want from us? A thumbs up? That all sounds great. I think whatever code we might have provided you with would just be skewed for our implementation and who cares about our implementation when people pay for the scripts on the mainnet. So just take it from the mainnet as per your plan, I think it's representative enough.
I'm not sure how to triage this issue, so I'll triage it as "Low priority".

@effectfully, this task has two stages with the following needs:

Stage 1 - Planning:

A thumbs up that the proposed methodology makes sense.
A thumbs up that the proposed dataset format (a directory of scripts in the flat format with arguments pre-applied) makes it easy to create a reference script.

Stage 2 - Benchmarking (after the dataset and a reference implementation are shared):

Prepare a reference script that takes a directory path to the dataset and the number of worker threads and outputs the run time and the result for each executed script.
Provide an interpretation of the benchmark results from the POV of the Haskell implementation.

Regarding the representation of scripts, yes, with the random selection, more popular scripts have a stronger influence on the results than less popular ones. However, that's exactly the way they influence the Node's run time on the mainnet.
At the same time, not reflecting in the dataset the relative frequency of scripts on the mainnet would make the results not representative of the actual mainnet workload. The relatively large sample size (256,000 transactions with script witnesses), should still ensure a solid representation of diverse scripts in the dataset. If you have some specific characteristics in mind that you'd like to test (the number of unique scripts, etc.), please let me know. Generally, the sample size can be increased if there are clear benefits that outweigh the longer benchmark run times.
Regarding approved scripts for each implementation, one of the benchmark's goals is to measure the parallel efficiency of each implementation (does the performance scale linearly with the number of workers). As I understand that may require some fine-tuning of the Haskell runtime parameters for optimal performance, and I don't want to take the risk of misconfiguring it. Another reason is that you could provide several scripts representing experimental optimizations. For example, Rust and C++ implementations seem to benefit drastically from optimizations related to memory allocation patterns. A strong impact of certain optimizations may help to advocate for their earlier inclusion into the mainnet release of Cardano Node.

@sierkov everything you said makes perfect sense to me.
@rvcas @MicroProofs are you folks interested in any of what's been discussed here?

This figure appears significantly lower than the number you reported. Could you kindly double-check your results? If your figures are correct, I’d greatly appreciate it if you could share your methodology so we can better understand the discrepancy.

@sierkov Interesting discrepancy, indeed.
The code I've used to extract plutus script evaluations from Mainnet is currently in a private repo. I am working on making it public, once ready -- I'll share a link with you.  I can also describe what is done there: Cardano.Api is a Haskell library that delegates tasks to the Ledger library. It contains the applyBlock function.
The indexer applies it block by block, folding over the ledger state and getting [LedgerEvent] for each application. These LedgerEvents include SuccessfulPlutusScript plutusEventsWithCtx and FailedPlutusScript plutusEventsWithCtx. All such events are then inserted into a PostgreSQL DB table script_evaluation_events, and there are 40929053 records in it right now.
Here is a sample of the last 20 rows:

@Unisay, thank you for the prompt follow-up. To better understand the issue, we analyzed a small random sample of transactions with Plutus witnesses by manually comparing redeemer counts against Cexplorer.io. All analyzed transactions matched precisely.
Examples:

00006CACA3C2415EA3B36ACCCE78EEBFC9111D9F5C5F572E57CF0CAEC3B9D906: 1 redeemer
33FC43437EC692B37287A5BCBB52041499666ADFB085D767615BE29A0291F51F: 2 redeemers
BBBBB5A19B1C985927BEE3E23D7158044F6D82D7E47A67218E108BB8568803C0: 2 redeemers
FFFFD512C92D545D41A58DA0580214A8FD94FCB0013B52EAB7C6ADD95CE4B19A: 3 redeemers

To help find the root cause of the discrepancy, I’m attaching two files with the following statistics:

The number of plutus redeemers for each mainnet epoch: epoch-stats.txt.
The number of script evaluations for each unique Plutus script: script-stats.txt.

Would it be possible for you to prepare tables with the same contents from for your dataset? That would allow us to trace the causes of discrepancies down to individual epochs and scripts. Then, we can confirm each case by manually analyzing the respective raw data.
P.S. The epochs table reports both unique and non-unique redeemers. That's because a small fraction of transactions contains multiple redeemers with the same id (purpose tag + reference index) while Cardano Node evaluates only the final entry. Reporting this for comprehensiveness.

I apologize for the confusion: I gave you the wrong number first time, it's 40 millions, not 400.

Here is the repository (as promised).
This is the place where LedgerEvents are emitted for each block.

@Unisay, thank you for sharing the code. Two quick questions:

Which approach do you use to test the correctness of computed statistics? Is there a pre-generated test chain with known parameters? If so, I’d be grateful for a pointer.
Could you share the expected time to populate the database with mainnet data?


fix race in SubscriberImplTest::receiveMessage

cc @davidtorres
This bug manifests as testBundleAcks deadlocking.
The test

publishes a series of messages to a mock server,
waits to receive them back,
and acknowledges them.

For performance reasons, the client does not immediately
send the acknowledgement request to the server.
Instead, it sends acks in batch every 100ms.
Using a fake clock, the test advances the time by 100ms,
sending the ack-batch, then verify that the mock server
receives the acks.
The bug is in step 2. The test thread waits by waiting on a
CountDownLatch, which is counted down by GRPC thread calling
receiveMessage().
However, the method decrements the latch before acking the message.
On a bad day, the test thread can wake up, advance the clock,
and send the ack-batch before the GRPC thread could add the
message to the batch.
The test then waits for the server to receive an ack it never sent,
deadlocking the test.
The fix is for receiveMessage() to ack the message before
decrementing the counter.

Changes Unknown when pulling 7ce540537a4456efa56c8550f5104e11a019df3b on pongad:fix-race into ** on GoogleCloudPlatform:pubsub-hp**.

Your description is hard to follow. Could you add some qualifiers? If the following are incorrect, it indicates that I didn't understand correctly:

(mock) server -> (mock) pubsub server
client -> subscriber client

Add explicit references to where the following are performed in the code:

"the test thread can [...] send the ack-batch"
"before the GRPC thread could add the message to the batch"
"The test then waits for the server to receive an ack"

It's hard to verify the flow if I have to do the work to correlate these descriptions with the code.

@garrettjonesgoogle PTAL

LGTM


use kotlin base parent

safe a few 100 lines of xml

blocked by https://github.com/toolisticon/maven-parent-kotlin-base/issues/7


Extensions: include Replace Activities Label by Leleat

This extension was developed to test a design idea for GNOME Shell.
https://extensions.gnome.org/extension/5706/replace-activities-label/

Reflexion
Hello, this is interesting although, as others have noticed, it might not be descriptive enough for someone not using Gnome as their primary desktop.
The devil is in the details
This extension experimentally supports the usage of an Animation File which might make this a tad bit more flavored.
It can also Hide the App Menu which is something that has already been tested for the Focus Indicator that was eventually not merged for reasons currently unknown to me.
I like the idea of being able to Hide this menu but it might damage the experience for Mouse Centered use cases.
Conclusion
We should also reflect on whether or not the Focus Indicator might actually be a good inclusion as the feature set partly overlaps and that extension shows, in my opinion, a clearer improvement in usability.

It might not be descriptive enough for someone not using Gnome as their primary desktop.

That's the entire point of trialing things here, in an experimental place, to see how people get on with it.

It can also Hide the App Menu which is something that has already been tested for the Focus Indicator that was eventually not merged for reasons currently unknown to me.

This will likely be default in GNOME 45. It was tested late in the GNOME 44 cycle and we decided against making that large UI change alone without testing more options for the Activities button itself.
For context, the point of Beyond is that I'm involved in GNOME design discussions, and am using this as a test bed for trying out ideas that come up within the upstream GNOME discussions. We can iterate fast here and change them much more easily than GNOME can do (where they have to worry about release screenshots and a more stable overall experience).
Think of Beyond as an A/B testing ground for GNOME. :)

Thank you for the clarification, I'm testing the extension out, it's a good inclusion. :)
The Focus Indicator is too a good extension.

Superseded by #87


Documentation on nullsafety.dartpad.dev contains legacy type signatures

The docs that appear in the documentation pane for classes and constructors from the SDK all contain legacy types.
Repro code:
var fame = Duration(minutes: 15);

Click to place your cursor on the Duration constructor. The documentation pane contains a signature showing all legacy types with the stars. These should all be non-nullable:
(new) Duration* Duration({int* days = 0, int* hours = 0, int* minutes = 0, int* seconds = 0, int* milliseconds = 0, int* microseconds = 0})
Creates a new Duration object whose value is the sum of all individual parts.

cc @stereotype441 @pq @jwren
It sounds like these might be coming from the analysis server?

@bwilkerson @scheglov

Analysis Server outside of DartPad shows correct non-nullable signatures.
So, it might be something related to how DartPad configures its analysis context.
Note, that if the analysis context does not have non-nullable experiment enabled, then it is considered a legacy library, and all Null Safety elements are converted back into legacy elements when imported into a legacy library.

This is the initialization code through which the server is spun up:
https://github.com/RedBrogdon/dart-services/blob/nnbd/lib/src/analysis_server.dart#L55
It's using the non-nullable experiment flag along with some others.
The SDK path given to the wrapper points to a local install of a custom build of the Dart SDK (you can grab a Linux build off our Cloud Storage server).
I'll keep poking at this, but any advice you can provide, @scheglov, is much appreciated.

Do you have .dart_tool/package_config.json in the packages that you analyze with the analysis server? If you do, and it specifies a language version other than 2.9, then any enabled experiments are discarded.

This has been corrected in today's release! Thanks to those who reported it and/or offered advice on fixing it. 😄


Add portuguese translation

A PR for Brazilian Portuguese has also been opened (#136).
Is it meaningful in your opinion to have both languages featured or you guys can agree on a single language? Do they differ substantially?

It's the same language, so any portuguese speaking person would be able to read both. That being said, you can definitely tell one was written by a Brazilian and another by a Portuguese. I've seen some apps have both a pt_PT and pt_BR translation, but if you only want to have one, I think any of them would work.

If standard Portuguese is also comprehensible by Brazilians, I'd prefer to keep only one.
I kindly ask to @vrmiguel to review this PT translation and let me know if some term is not clear.
If something is not clear, may you find a version that suits both?
Thanks in advance guys!

Since #136 has been closed, I'll proceed merging this PR!

@all-contributors please add @franciscoBSalgueiro for translation


Threading issue with Anaconda

I am able to run the premade environments properly, however I want to create my own environment as dm_control supports mujoco 2.0 now. Following to tech report, I tried the following code snippet
simple_MJCF = """
<mujoco>
<worldbody>
<light name ="top" pos ="0 0 1.5"/>
<geom name ="floor" type ="plane" size ="1 1 .1"/>
<body name ="box" pos ="0 0 .3" >
<joint name ="up_down" type ="slide" axis ="0 0 1"/>
<geom name ="box" type ="box" size =".2 .2 .2" rgba ="1 0 0 1"/>
<geom name ="sphere" pos =".2 .2 .2" size =".1" rgba ="0 1 0 1"/>
</body>
</worldbody>
</mujoco>
"""

physics = mujoco.Physics.from_xml_string(simple_MJCF)

I get the following error,

File "/home/anaconda3/lib/python3.5/threading.py", line 1069, in _wait_for_tstate_lock
assert self._is_stopped
AssertionError:

This is strangle because I am able to run benchmark environments without issues. Is there a workaround I should try ?

I wasn't able to reproduce this in a conda environment, although from the error message it looks as though it could possibly be related to https://bugs.python.org/issue23768. Does the error occur specifically when the interpreter process terminates?

Closing due to inactivity


*/15 * * * * /home/ark/bin/arkmanager update --update-mods --safe --warn  @all

Hi, my problem is that the line:
*/15 * * * * /home/ark/bin/arkmanager update --update-mods --safe --warn  @all
will start downloading all mods, no matter if they need an update or not. Can i somehow only check ... and only download if theres an update needed. Also what I want is this:

Update Mods (if neccessary)
Update Server (if neccessary)
Warn Players
Restart (if neccessary)

Is this possible? Can you help me?
Also is it possible to check if the server is running every 5 mins - if no start it - if yes do nothing?
Thank you very much! :)

Always updating mods suggests that you need to point steamdatadir to the Steam data directory (which is sometimes ~/.steam or ~/Steam), as it is unable to determine if a mod update is necessary.
If you want the server to always restart after crashing, even if it the last startup attempt failed, then set arkAlwaysRestartOnCrash=true in your arkmanager config.

ok so if i have multiple configs int he ~/.config/arkmanager/instances/ dir, i set steamdatadir in ~/.arkmanager.cfg to ~/.steam/?
No I wanna start the server on system startup.

or is it just impossible to have arkmanager not download every mod again and again?

If e.g. ~/.steam/steamapps/workshop exists, then try setting steamdataroot=$HOME/.steam in ~/.arkmanager.cfg
To start the game server(s) on server startup, one possibility is to have an @reboot cron job - e.g.:
@reboot sleep 60 && $HOME/bin/arkmanager start @all

ok it seems to work. i now have:
*/15 * * * * /home/ark/bin/arkmanager update --update-mods --safe --warn  @all
Now, how do I restart the ark server of which a mod has been updated, automatically?

and its steamdataroot not steamdatadir right?`;D

Now, how do I restart the ark server of which a mod has been updated, automatically?

The command you are using should automatically restart the server after a warning period when mods need to be updated.

and its steamdataroot not steamdatadir right?`;D

It is indeed steamdataroot.  There are no references to steamdatadir in the code or in the readme.

ok. thank you very much. I now have this:
30     *       *       *       *       /home/ark/bin/arkmanager saveworld @all && /home/ark/bin/arkmanager backup @all
@reboot sleep 60 && /home/ark/bin/arkmanager start @all
*/15 * * * * /home/ark/bin/arkmanager update --update-mods --safe --warn  @all


fix URLs for dirhtml builds

closes #1675
@kathatherine can you try out this branch to see if it fixes dirhtml builds for you?

Followed most of the instructions here to set up a dev environment with your branch. Whether I build the pydata-sphinx-theme docs or my own set of docs, I get the following extension error:
Handler <function _fix_canonical_url at 0x10598cae0> for event 'html-page-context' threw an exception (exception: _fix_canonical_url() takes 3 positional arguments but 5 were given)
Uncertain if I've done something wrong or if there's an underlying issue with the branch, but it does appear that the failing tests are giving the same error.
Thanks for attempting to fix this!

Thanks for the tip on that theme install. TIL!
This appears to get the job done for my dirhtml built docs. 🎉
I didn't notice any edge cases when clicking around. Thanks very much!

Team, I'll plan to self merge this one tomorrow unless someone wants extra time to review. I think it's a pretty innocuous change


fix: Allow image fetcher to fallback on 503 status code.

Right now containerd will fallback to another image source when the
current source returns a 404 status code. But if the source returns a
503 indicating that it is offline it doesn't attempt any of the other
sources.
This just makes it so that under that condition as well, containerd will
attempt other sources if they are available.

It might also be worth handling other status codes as well for falling back? Such as:

502 Bad Gateway
504 Gateway Timeout

Where if there is another source to fall back on it should at least attempt that other source? But I wanted to keep this PR small.

This came up because I run an image proxy for docker to make sure I don't have to worry about API limits and such; and that proxy was down and nginx was returning a 503 for the proxy preventing it from falling back to just pulling the image from docker's registry directly.

Could be worth looking at. I guess we need to have a good look at what's the most logical step for each of these (there may be definitions for that in the RFCs).
For example, for the 503, there's also (only looked at the MDN page; perhaps the RFC has more details);

Common causes are a server that is down for maintenance or that is overloaded. This response should be
used for temporary conditions and the Retry-After HTTP header should, if possible, contain the estimated
time for the recovery of the service.

What's the expectation in that case? Wait, and retry the same location, or continue with next?

I think in that specific case continue with next might be the best; as the server has indicated that it is intentionally unavailable (regardless of cause). But other status codes might be better to retry? Such as a gateway timeout?
But retry logic within containerd seems odd to me at a glance, as what comes to mind is Kubernetes logic for image pulling and how it already has a robust retry and backoff system built on top of containerd. While that is not representative of every use case, retry logic at the containerd level itself feels odd; similar to retry logic within curl or git.

Reading into this more if a retry-after header was present in a 503 response; would it be reasonable to retry against that mirror if that retry after did not exceed what would be considered a timeout for pulling a given image. Or if that timeout threshold had not already been met? Then upon failure to retrieve the image from that mirror, continue onto the next mirror; or surface the error if there are no other mirrors left.

To the best of my knowledge, this change still only affects the registry configuration which is now considered deprecated and is slated to be removed in the future. I think itd be easier to just close this now and I can readdress it in the new configuration.
Thank you all for your time!


Actions and sensors not exposed

I was able to successfully manually add the virtual apple tv to my home using the provided setup code from the Homebridge logs, however, although I see the virtual hub in my Home, I don't have the sensors nor switches available:
Homebridge 1.7.0
node 20.9.0
{
    "mediaTypes": [],
    "deviceStates": [
        "idle",
        "loading",
        "paused",
        "playing",
        "seeking",
        "stopped"
    ],
    "remoteKeysAsSwitch": [
        "turn_off",
        "turn_on"
    ],
    "blacklist": [],
    "name": "Apple TV Enhanced",
    "avadaKedavraAppAmount": 15,
    "_bridge": {
        "username": "0E:68:CC:56:77:E4",
        "port": 56696
    },
    "platform": "AppleTVEnhanced"
}

Here are the plugin related logs:
[11/8/2023, 9:27:57 PM] Homebridge v1.7.0 (HAP v0.11.1) (Homebridge E80A) is running on port 51281.
[11/8/2023, 9:27:57 PM] [Apple TV Enhanced] Launched child bridge with PID 635854
[11/8/2023, 9:27:57 PM] Registering platform 'homebridge-appletv-enhanced.AppleTVEnhanced'
[11/8/2023, 9:27:57 PM] [Apple TV Enhanced] Loaded homebridge-appletv-enhanced v0.3.3-beta.3 child bridge successfully
[11/8/2023, 9:27:57 PM] Loaded 0 cached accessories from cachedAccessories.0E68CC5677E4.
[11/8/2023, 9:27:57 PM] [Apple TV Enhanced] Platform: Finished initializing platform: Apple TV Enhanced
[11/8/2023, 9:27:57 PM] [Apple TV Enhanced] 'linux 5.15.0-73-generic' is supported by the plugin Homebridge Apple TV Enhanced.
[11/8/2023, 9:27:57 PM] [Apple TV Enhanced] Python check: Starting python check.
[11/8/2023, 9:27:57 PM] [Apple TV Enhanced] Python check: plugin dir exists.
[11/8/2023, 9:27:57 PM] Homebridge v1.7.0 (HAP v0.11.1) (Apple TV Enhanced) is running on port 56696.
[11/8/2023, 9:27:57 PM] Loaded 1 cached accessories from cachedAccessories.0EADBECAAA3A.
[11/8/2023, 9:27:57 PM] [Apple TV Enhanced] Python check: Python 3.10.12 is installed and supported by the plugin.
[11/8/2023, 9:27:57 PM] [Apple TV Enhanced] Python check: Virtual environment already exists.
[11/8/2023, 9:27:57 PM] [Apple TV Enhanced] Python check: Venv is using current system python version (3.10.12).
(node:635853) [DEP0123] DeprecationWarning: Setting the TLS ServerName to an IP address is not permitted by RFC 6066. This will be ignored in a future version.
(Use `node --trace-deprecation ...` to show where the warning was created)
[11/8/2023, 9:28:01 PM] [Apple TV Enhanced] Python check: Pip is up-to-date
[11/8/2023, 9:28:01 PM] [Apple TV Enhanced] Python check: Python requirements are satisfied.
[11/8/2023, 9:28:01 PM] [Apple TV Enhanced] Python check: Finished
[11/8/2023, 9:28:01 PM] [Apple TV Enhanced] Platform: Starting device discovery ...
[11/8/2023, 9:28:07 PM] [Apple TV Enhanced] Platform: Adding Apple TV Living Room (3) (A8:51:AB:9D:15:C5)
[11/8/2023, 9:28:07 PM] [Apple TV Enhanced] Living Room (3) (A8:51:AB:9D:15:C5): verifying credentials ...
[11/8/2023, 9:28:07 PM] [Apple TV Enhanced] Living Room (3) (A8:51:AB:9D:15:C5): Credentials are still valid. Continuing ...
[Apple TV Living Room (3)@@Firmware Revision] Characteristic not in required or optional characteristic section for service Television. Adding anyway.
[Apple TV Living Room (3)@idle@Configured Name] Characteristic not in required or optional characteristic section for service MotionSensor. Adding anyway.
[Apple TV Living Room (3)@loading@Configured Name] Characteristic not in required or optional characteristic section for service MotionSensor. Adding anyway.
[Apple TV Living Room (3)@paused@Configured Name] Characteristic not in required or optional characteristic section for service MotionSensor. Adding anyway.
[Apple TV Living Room (3)@playing@Configured Name] Characteristic not in required or optional characteristic section for service MotionSensor. Adding anyway.
[Apple TV Living Room (3)@seeking@Configured Name] Characteristic not in required or optional characteristic section for service MotionSensor. Adding anyway.
[Apple TV Living Room (3)@stopped@Configured Name] Characteristic not in required or optional characteristic section for service MotionSensor. Adding anyway.
[Apple TV Living Room (3)@turn_off@Configured Name] Characteristic not in required or optional characteristic section for service Switch. Adding anyway.
[Apple TV Living Room (3)@turn_on@Configured Name] Characteristic not in required or optional characteristic section for service Switch. Adding anyway.
[11/8/2023, 9:28:08 PM] [Apple TV Enhanced] Apple TV Living Room 3 (A8:51:AB:9D:15:C5): Finished initializing
[11/8/2023, 9:28:08 PM] Apple TV Living Room (3) B058 is running on port 35901.
[11/8/2023, 9:28:08 PM] Please add [Apple TV Living Room (3) B058] manually in Home app. Setup Code: 964-51-427
[11/8/2023, 9:28:08 PM] [Apple TV Enhanced] Apple TV Living Room 3 (A8:51:AB:9D:15:C5): New Active State: on
[11/8/2023, 9:28:08 PM] [Apple TV Enhanced] Apple TV Living Room 3 (A8:51:AB:9D:15:C5): New Media Type State: music
[11/8/2023, 9:28:08 PM] [Apple TV Enhanced] Apple TV Living Room 3 (A8:51:AB:9D:15:C5): New Device State: paused

It seem like you have paired the bridge but not the Apple TV device itself. Since it exposed as a Television device, my plugin needs to expose this as an external accessory. To add it, go in your Home app to Add Device > more options, then add the Apple TV. The paring code should be in the log.
This is also documented in the README.

I believe that's exactly what I did. I tried to explain that in my first sentence.
Allow me to record a video, I believe that should clarify things a bit.

Sure, go ahead

https://github.com/maxileith/homebridge-appletv-enhanced/assets/3199950/bfe96cd7-2941-4b10-90d2-924081326c10

Yeah, so my assumption was correct. You are adding the child bridge and not the Television device. When being in the "Select an Accessory to add to My Home" dialog, you need to select the Television device that was present in the video.
Explanation: K want my plugin to expose Apple TVs as Television devices. Televisions evince are always "external Accessories" meaning that they are their own bridges. That is why they are not associated with a bridge but themselves.

You need to add the device directly, not the bridge

Dear lord.. I thought that was my existing AppleTV. Sorry and thanks!

You are welcome @Birowsky.
Thank you for the screenshot @Maxiklaxi.


Email contact improvements

Description
Improve how contact email is handled in the repo
Related Issue
No related issue. I just really hate clicking on email links and it opening the default Mac mail app, or the default iOS mail app. This is much better, people can copy and then paste into Gmail web/whatever they want
Changes Made

Contact link on pricing page now copies<EMAIL_ADDRESS>to clipboard
CONTACT_EMAIL is now a value in constants
Email links in privacy policy and TOS are consistent

Screenshots

Checklist

[ ] I have tagged the issue in this PR.
[x] I have attached necessary screenshots.
[x] I have provided a short description of the PR.
[x] I ran yarn build and build is successful
[x] My code follows the style guidelines of this project.
[x] I have added necessary documentation (if applicable)

AI Code Review is in progress (usually takes <3 minutes unless it's a very large PR).


Add new option deleteScreenshotsWhenAccepted

This introduces a new option that can be used to make sure when your threshold is high and one pixel for example changes that it won't replace the screenshot when you approve it.
This removes a lot of noise/manual work, since we never want to see the screenshots that got accepted. Right now we are manually removing those screenshots. Nothing really changed, so they should not be replaced when they got approved. We use docker but even with the same docker image they might be 1-pixel-off aliasing issues.
Let me know what you think about, I would be happy if this could be merged and released, hopefully other people find it useful, too.

I'm ok with supporting this new option. Thank you!

I've published version 0.9.0 with your changes.
By the way @jalyna would you be interested in maintaining the project? I no longer use it, and if you are, you're probably going to do a better job than me.


Orbax Checkpointing and Flax.NNX require hacking to work together

I'm building a system using flax.nnx and orbax.checkpointing. However, it is overly complicated on how to save and restore models due to the new jax.random.key() being used in flax.nnx rather than jax.random.PRNGkey().
I have had to create a workaround where all layers with rng and key in their path are changed from dtype=key<fry> to a format appropriate for saving. Then, upon restoration, they need to be shanged back.
I am attaching a link to a notebook explaining what I've done but I would be keen to hear if there are simpler workarounds? Or, preferably, if there is a way to simple save and restore models?
https://colab.research.google.com/drive/1ozln9ejG7eRtxvbkqHYU3K6OyPvveH9w?usp=sharing
Note: I am also adding an issue to flax to see if there is a fix their side (#4383).

Hi, just checking if https://github.com/google/flax/issues/4383 suggested solution is sufficient enough.  Currently, Orbax only support dtype=key<fry> via the JaxRamdomKeyCheckpointHandler.  To support it combining with other types, a feature request would be needed.

Duplicate of #1105 .  Orbax team is working on supporting RNG as part of a PyTree.


Add Header.Type Parameter

Originally motivated because typ is a required JOSE header parameter in OID4VCI
Also added links to relevant JWS spec doc

Turns out this wasn't quite enough b/c in the jws.Sign() flow we're hardcoding the header values in a few places... will need to think this through from the outside-in (from jwt package's dependency on jws.Sign())


I hope to use HTML tag in schedules title.  But not Success

Version
1.12.5

Development Environment
window 10
google browser 76.0

Current Behavior
I hope to use HTML tag in schedules title.   But is not Success

schedule: [{
  bgColor: "#67c23a",
  borderColor: "#67c23a",
  category: "time",
  color: "#fff",
  dragBgColor: "#67c23a",
  end:<PHONE_NUMBER>000,
  id: "001",
  location: "ShangHai",
  start:<PHONE_NUMBER>000,
  title: "Title Name<br/> Class Name"
}]
view: 'week',
scheduleView: ['time'],
// Write example code

Expected Behavior

I through edit time.hbs.  solve the problem.  because i find time-tmpl Function
time-tmpl Function
'time-tmpl': function(model) {
    return common.stripTags(model.title);
 }
stripTags: function(str) {
    return str.replace(/<([^>]+)>/ig, '');
}

solve method
{{{time-tmpl model}}} -> {{{model.title}}}

Will this bring other hidden dangers???

It would be useful to support HTML in title

@blacklisten
How about using a template?
https://nhn.github.io/tui.calendar/latest/tutorial-example14-template-for-month

I tried the template but didn't get what I wanted
I want this, it supports some HTML tag

I using https://github.com/nhn/tui.calendar/issues/441#issuecomment-544129413 achieve it
@jungeun-cho

@blacklisten
const cal = new Calendar('#calendar', {
    ...
    template: {
      time: function(schedule) {
        return schedule.title;
      }
    }
  });


Create wireframes

Create wireframes for the "Upload" and "Results" page

Implemented by https://github.com/DCGenomics/NCBI_August_Hackathon_Push_Button_Genomics_Solution/pull/10


Kitkat - "Internet connectivity error"

The app has stopped working on my Kitkat phone. Upon launching the app, I immediately see this: "Internet connectivity error", and "No data to display". Strangely, it still works fine on my tablet, running Marshmallow. Naturally, I assumed there was an issue with my phone, but then I learnt that the app has ceased to function on my mom's phone, as well - also Kitkat.
I see a couple of recent reviews on GPlay, reporting the same issue.
Any ideas?
EDIT: Same errors on 2.05, 2.1 and 2.3.

Android versions < 5.0 don't have TLS 1.2 and 1.2 enabled by default, though it is supported.    The environment canada website is using TLS 1.2.  Maybe this is the problem?


[AIRFLOW-2662] add k8sexecutor worker pod node_selectors and affinity…

… fields
Make sure you have checked all steps below.
JIRA

[ ] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-2662

Description

[ ] Here are some details about my PR, including screenshots of any UI changes:
In this issue(https://issues.apache.org/jira/browse/AIRFLOW-2397, pr url: https://github.com/apache/incubator-airflow/pull/3369), only the affinity function of the kubernetes operator pod is provided, and the affinity function of the kubernetes executor pod is not supported. The full affinity and nodeselector function are provided here.

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[ ] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@Fokko PTAL

I've reworked the git commit message this time, please adhere to the guidelines. Otherwise this will mess up our git logs.


Compiling benches requires nightly

futures-channel/benches/sync_mpsc.rs uses the nightly test crate for benchmarking

extern crate test;
use crate::test::Bencher;```

Compiling with beta fails.

This is normal, the built-in benchmarking suite has required nightly forever.


Edit package metadata

Adds contact info, renames package

I should probably give you direct push access for that


chore(dependencies): Update dependencies to remove potential security vulnerabilities

@jeff-phillips-18 @dtaylor113 @AllenBW we concerned about the remaining Node Security warning since this was meant to remove some of those warnings?


Support taskPriority

Activities and decision tasks can have a priority attached to them which controls the ordering SWF hands out those jobs. This can be useful if you're getting a stream of lower priority tasks and don't want them to block high priority tasks. Generally this isn't needed but it can be quite handy.
From what it looks like only a couple sections of code need to be updated to support it, namely *_options and some of the botoflow.decisions classes and an extra constant to say inherit the workflow taskPriority when scheduling activities.

Fixed in #9


All animations disabled by transition animation scale

Steps to reproduce

Go to your device's developer options
Set transition animation scale to 0x (off)
Run any Flutter app (that has been built with v3.24.2)
Observe and endure

Expected results
Typically only animator duration scale will affect ripple effects, so changing the transition animation scale should have no affect
Actual results
Animator duration scale has no affect, and transition animation scale affects all/most Flutter animations if it's set to 0x, with no in-between
I should note this issue was not present last time I tested a Flutter app (a month or so ago) which leads me to believe it's not entirely related to this issue
Code sample
Code sample
Simple app to show the lack of ripple
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(useMaterial3: true),
      home: Scaffold(
        body: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              ListTile(title: const Text("Tap"), onTap: () => ()),
            ],
          ),
        ),
        floatingActionButton: FloatingActionButton(
            onPressed: () => (), child: const Icon(Icons.add)),
      ),
    );
  }
}

Screenshots or Video
Screenshots / Video demonstration
https://github.com/user-attachments/assets/f0fb53cc-7527-489f-b3c0-c840f7c51bb1

Logs
No response
Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.24.2, on Fedora Linux 40 (KDE Plasma) 6.10.7-200.fc40.x86_64, locale en_US.UTF-8)
    • Flutter version 3.24.2 on channel stable at /home/fedora/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4cf269e36d (8 days ago), 2024-09-03 14:30:00 -0700
    • Engine revision a6bd3f1de1
    • Dart version 3.5.2
    • DevTools version 2.37.2

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /home/fedora/Android/Sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /home/fedora/.local/share/JetBrains/Toolbox/apps/android-studio/jbr/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
    • All Android licenses accepted.

[✗] Chrome - develop for the web (Cannot find Chrome executable at google-chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Linux toolchain - develop for Linux desktop
    • clang version 18.1.6 (Fedora 18.1.6-3.fc40)
    • cmake version 3.28.2
    • ninja version 1.12.1
    • pkg-config version 2.1.1

[✓] Android Studio (version 2024.1)
    • Android Studio at /home/fedora/.local/share/JetBrains/Toolbox/apps/android-studio
    • Flutter plugin version 81.0.2
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)

[✓] Connected device (1 available)
    • Linux (desktop) • linux • linux-x64 • Fedora Linux 40 (KDE Plasma) 6.10.7-200.fc40.x86_64

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

I should note this issue was not present last time I tested a Flutter app (a month or so ago)

Hi @dozenadime, do you remember which previous Flutter version this worked on?

I don't remember, no, but luckily the problem doesn't occur after downgrading to v3.19.6. I'm fairly certain it worked on v3.22.x as well (based on the release date), but for some odd reason I couldn't downgrade to check that
The relevant Flutter Doctor information with animations working, just in case
[✓] Flutter (Channel stable, 3.19.6, on Fedora Linux 40 (KDE Plasma) 6.10.8-200.fc40.x86_64, locale en_US.UTF-8)
    • Flutter version 3.19.6 on channel stable at /home/fedora/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 54e66469a9 (5 months ago), 2024-04-17 13:08:03 -0700
    • Engine revision c4cd48e186
    • Dart version 3.3.4
    • DevTools version 2.31.1

@dozenadime
I tried replicating this behavior on latest versions by setting animation scale to off and then tapping on the button which taps with no animation. If set it to 1.5x and then tap on the button, it probably shows the transition scale as shown below:
https://github.com/user-attachments/assets/77ac86f8-009b-4a21-b0a5-0855f12944e1
Is the expected behavior that, even if the animation scale is off, tapping on the button should animate ?

Is the expected behavior that, even if the animation scale is off, tapping on the button should animate ?

@darshankawar Specifically the transition animation scale, yeah. On the devices I've experienced this with, transition animation scale will only affect transition animations (such as the home button animation), and not things like ripple effects. You can see this in the initial video where I have the basic animator scale set to 10x to exemplify the ripple effects
Just to clarify, this isn't only an issue with ripple effects. Other effects, like the animations on the navigation bar labels are also eliminated:
https://github.com/user-attachments/assets/1859db53-3e5c-4697-b4fa-300cf8d70bbd
Example taken from https://api.flutter.dev/flutter/material/NavigationBar-class.html, with the NavigationLabelBehavior set to onlyShowSelected to make the effect more apparent. I fail to show it in the video, but this scenario doesn't occur in Kotlin apps

This looks specific to Android device settings, maybe we need to pipe this setting up to the framework from the engine? Sending over to the Android team to see what they think!

From triage: We intend to investigate whether the relevant settings are the same as in this comment.


Not Enough Memes

Only 1 meme spotted in all of the source code. Disappointing.
EDIT: Some cuck deleted the only good meme SMH

Not enough issues either smh


Remove mergify.yml

Thanks. Does it honor the Don't squash label?

Thanks. Does it honor the Don't squash label?

Yes. Just FIY: https://github.com/maistra/test-infra/blob/main/prow/config/tide.yaml#L7

/retest

/retest


HeroRoll font size and color

TheMario — Yesterday at 1:37 PM
is there a way to play around with the font size and color of the header when you roll herodice? (one  example: after a 1d6[hk]center the text "Killing attack to the head", make it bigger and display it in red) like the rest of the macro and journals using css??

TheMario — Today at 10:50 PM
or just find a way to use css like the standard foundry chat rolls (like /r 11-3d6+11 # DCV Hit: )


Implement Moderation page

Description
When experiences are submitted for review, a moderator will need to review the submission for adherence to community conduct and so forth.
Tasks

[ ] Populate a table of experiences, tagged with "review"
[ ] Add an approve button that sets the moderation state of the experience to "Accepted/Approved/Public"
[ ] Add a reject button that sets the moderation state of the experience to "Rejected"

Suggest another button is added after rejection that might read ' further action required' ' contact user to request edit/ ' or some other variation

@SuziQpid , certainly. There are additional features/requirements to add from a user perspective if an experience is rejected, such as a change log or even some sort of reason for rejection. The moderation flow between moderators and users has yet to be hashed out fully, so for the time being, a reject and try again approach will be implemented for simplicity and progress sake.


More information on debugging / troubleshooting strategies

Using ADO Pipelines in a project right now, a few things that my team and I found useful for debugging and troubleshooting were (which would be useful to capture somewhere in the documentation)

Using visual pipelines, often breaking into atomic parts, to test out different pieces helps in accelerating the debugging process

When working staging and build artifacts, to make sure that the artifacts were saved in the correct paths, you can use the "script" task to see the contents of the directory

Scoping of build and pipeline variables, especially as it pertains to jobs run by agents within the same pipeline is important to note

For bash tasks, there is a difference in the way the script behaves locally (even when using the same OS hosted agent) and remotely. E.g. in the availability of certain tools like "bc"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 611642f0-881f-10b9-ae94-3c562001d1f0
Version Independent ID: 41efb94b-4c7a-64a3-b23b-70c8634ae727
Content: Release variables in Azure Pipelines - Azure Pipelines & TFS
Content Source: docs/pipelines/release/variables.md
Product: devops
GitHub Login: @alexhomer1
Microsoft Alias: ahomer

Thank you for your feedback. I will consult the documentation team and update the topic based on their response.


Examples: set examples/index.html as first page of dev server

Could we set examples/index.html as the first page of the dev server (npm run dev)?
Also, what is examples/index1.html about? I can't see anything useful when I try access it from the development server. If it's not useful anymore could you remove it?

working on this right now!

in the latest updates i have deleted index1.html

Oh right, sorry I didn't notice.


Implement BCryptSha256PasswordHasher to avoid password truncating issue

Fixes #504

Coverage increased (+0.1%) to 95.455% when pulling 03cc0e00fb11e805f06c28573e0a70c3924601fb on akkie:bcrypt_sha256 into 8b77d0f5cec9682e450834ee83c5a9d36d6cf463 on mohiva:master.

Super nice, do you have any documentation on how to roll forwards?


MicroService code re-factoring

This PR revisits MicroService code and made it working with proposed MS-Transferor architecture. So far it does the following:

talks to ReqMgr2 and gets acquired workflows
talks to Workqueue and gets GQE
performs as is Unified Transferor logic

Alan, I fixed this API.
On  0, Alan Malta Rodrigues<EMAIL_ADDRESS>wrote:

amaltaro commented on this pull request.

@@ -81,6 +85,19 @@ def phedexInfo(datasets):
blockNodes[item['name']] = nodes
return blockNodes

+def getRequests(status):
This is not using what I suggested here: https://github.com/dmwm/WMCore/issues/9142#issuecomment-482565706
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmwm/WMCore/pull/9140#pullrequestreview-229364565

Valentin, I noticed this week that the model we have been discussing was missing one use case. Which is regarding the pileup sample and the need to have it completely available for a workflow (either in one or in scattered among many sites). Which brings me to the conclusion that we cannot have a service only making subscriptions and not monitoring them.
I'm drafting another proposal and will write it down soon, such that we can go through it later today, if you have time.

@vkuznet I'd suggest to separate the developments you're putting into this PR into a couple of PRs, or maybe even 3. This PR has a) code refactoring, b) further developments for Transferor and c) implementation of TransferMonit, making it harder to validate and thus easier to introduce a bug.
If not too late, try to at least keep those 3 above in different commits.

Alan,
since both MSTransferor and MSTransferorMonit are integrated it would be hard to
separate this PR because we want to have fully working system at once.
Instead, I suggest to merge this PR and then separate further
development into different streams as you suggested. Moreover it seems
logical since now we can concentrate on individual implementations.
V.
On  0, Alan Malta Rodrigues<EMAIL_ADDRESS>wrote:

@vkuznet I'd suggest to separate the developments you're putting into this PR into a couple of PRs, or maybe even 3. This PR has a) code refactoring, b) further developments for Transferor and c) implementation of TransferMonit, making it harder to validate and thus easier to introduce a bug.
If not too late, try to at least keep those 3 above in different commits.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/dmwm/WMCore/pull/9140#issuecomment-493834921

@amaltaro , Alan please review this PR. I removed WorkQueue pieces from the code as was requested on today's meeting.

@vkuznet did you manage to run the very basic tests here? I understand it depends on many other things, but is the code at least not crashing as it is?
The concerns I expressed in my previous comment are still valid; and we will need to revisit them in the next PR.
I'm merging a bunch of things by tomorrow (cherrypy changes, new request status, pulling workqueue elements from another status) and possibly this one such that we can see how it goes in testbed.
Can you please squash all non test changes into the same commit and leave unittests/pylint changes in a second commit? Thanks

Alan,
thanks for update. I fixed unix tests flow even though they need separate revision since logic has changed completely. I squashed all commits to move things forward.
Feel free to review/decide tomorrow if you want to merge it.

Alan,
please merge this PR that I can move forward. Honestly I spent more time on comments, then on actual work. I already made significant clean-up of this code, see
https://gist.github.com/vkuznet/ba5fd2015963ed12a21029c9df02e04f
where I remove local store, I removed APIs you complained, I put clear logic based on proposal. But I want to apply changes once this PR is merged. This will allow me to come back to code and re-use it if necessary.

I guess you're just not used to have people reviewing your PRs.
Alright, let's put it in. Next PR will be the production-quality one though :) Thanks!

It is not that, I doubt that we both need to waste time on code which is far
from what we need and bother about pre-mature optimization/quality.
Once we achieve the functional code according to proposal then reviewing PR in
terms of code syntax and other stuff makes sense.
On  0, Alan Malta Rodrigues<EMAIL_ADDRESS>wrote:

I guess you're just not used to have people reviewing your PRs.
Alright, let's put it in. Next PR will be the production-quality one though :) Thanks!
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/dmwm/WMCore/pull/9140#issuecomment-495354546

I disagree.  Most of code convention, unused imports/vars,  can be fixed with a couple of clicks in an IDE. So the cost is very small to have a production-quality code in the repo. Last but not least, we know that half of those cases we never get back to the code and improve it.

Alan,
we may have disagreement on how to approach code/repositories. But I value my
and peoples time. As such, while awaiting a simple merge I spent time to adjust
code to new specs. This version is more close to specs, it addressed many issues
you raised.  But since you're resisted to merge intermediate code, I saved it for
on my own and pushed new one forward. Feel free to review again.
Valentin.
On  0, Alan Malta Rodrigues<EMAIL_ADDRESS>wrote:

I disagree.  Most of code convention, unused imports/vars,  can be fixed with a couple of clicks in an IDE. So the cost is very small to have a production-quality code in the repo. Last but not least, we know that half of those cases we never get back to the code and improve it.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/dmwm/WMCore/pull/9140#issuecomment-495363838


Gate Sensor issue

What issue do you have? Please be as thorough and explicit as possible.
Gate Sensor isn't working as well at HomeKit (always closed; see logs below). In eWeLink app it works fine.
Gate works, but not as expected.
Config not changed in HomeBridge.
Maybe important:
iOS 16.0 beta
tvOS 16.0 beta
Details of your setup.

Do you use (1) Homebridge UI-X (2) Homebridge CLI or (3) HOOBS?

(1) HomeBridge UI-X

Which version of Homebridge/HOOBS do you have?

v1.5.0 (latest)

Which platform do you run Homebridge/HOOBS on (e.g. Raspberry Pi/Windows/HOOBS Box)? Please also mention your version of Node.js/NPM if known.

Raspberry Pi
NodeJS v16.16.0
npm v8.11.0

Which version of this plugin (homebridge-ewelink) do you have? Has the issue started since upgrading from a previous version?

v10.0.0 (latest)
No (but it didn't cause any problems before)

Which eWeLink devices do you have that are causing issues? Please include product models if applicable.

Gate: Sonoff Mini (v1)
Gate sensor: Sonoff Mini (v1)
Please paste any relevant logs below.

[eWeLink] Config entry [bridgesensors] has an invalid entry which will be ignored.

[eWeLink] [Gate Sensor] could not be initialised as Cannot read properties of undefined (reading '0') at default.initialiseDevice (file:///usr/lib/node_modules/homebridge-ewelink/lib/platform. js:790:58).

Update: I recognized the first problem is I named the sensor to 'Gate Sensor', so I added 'gate' to the array. The next issue:

[eWeLink] [ Gate Sensor] device update failed as Cannot read properties of undefined (reading 'updateCharacteristic') at default.externalUpdate (file:///usr
/lib/node_modules/homebridge-ewelink/lib/device/simulation/sensor-visible.js:183:24).

Logged out:

[eWeLink]
Gate Sensor] initialising with optio ns {"logging": "standard"
', "lowBattThr
eshold":25}. hapchar:
Function: LockCurrentStat
e]{
UUID: '0000001D-0000-xxxx'
UNSECURED: 0,
SECURED: 1, JAMMED: 2, UNKNOWN:
3
} [Function: LockTargetState] {
UUID:
0000001E-0000-xxxx'
1
UNSECURED: 0,
SECURED: 1
}

Hi @angyalz
Can you try renaming your config item
[eWeLink] Config entry [bridgesensors] has an invalid entry which will be ignored.

from bridgesensors to bridgeSensors? And see if this makes things start working?

Hi @bwp91,
It just my fault while copying the log (from the photo of log). In config this key named as right as well (by UI config)

Can you show me your config just for this device so I can get a sense of what you’re trying to do?

@bwp91 Of course:

"singleDevices": [
                {
                    "label": "Gate",
                    "deviceId": "1000xxxxb4",
                    "deviceModel": "single",
                    "showAs": "gate",
                    "operationTime": 160,
                    "sensorId": "1000xxxxd5",
                    "hideSensor": false,
                    "overrideLogging": "debug"
                },
                {
                    "label": "Gate Sensor",
                    "deviceId": "1000xxxxd5",
                    "deviceModel": "single",
                    "showAs": "sensor",
                    "sensorType": "contact",
                    "overrideLogging": "debug"
                }
            ],
            "bridgeSensors": [
                {
                    "type": "motion"
                }
            ],

My first attempt was to adding 'gate' string to the sensorId array in platform.js at line 788 (but I realized it was not the best idea. At the same time, the sensor started to show real status, but not the gate)

Does the gate sensor have an on/off status based on whether the gate is open or closed? If so you would would be better to use the show as '1 Garage Door' option rather than Gate. They both show the same accessory type in HomeKit.
The 'gate' simulation is not (yet) coded to take advantage of using a separate sensor for status

@bwp91 Thanks for the fast reply!
I changed the type to garage door, it works as expected.
But the error log from sensor-visible.js:178 stays. (But I can live with it)
Of course the 'gate' string was removed from array of sensorId at platform.js
Thanks for your help!

If you update to beta version 10.0.1-beta.1 do you still get this warning in the log?

@bwp91 Yes

When the plugin initialises, in which order do your devices appear in the first list?
I just need to know which comes first, the “gate” device or “gate sensor” device?

@bwp91 By the log the order is other devices, Gate Sensor, other devices, Gate, other devices

Hi,
Closing this just as been a little overwhelmed with issues recently.
If this is still an issue or a feature you would like implemented then please do re-open this ticket!
Thanks for your understanding!


Changing card image download logic

Changing image download logic for cards by downloading the entire card instead of just the view. This kind of change adds also the buttons to the downloaded image, that is not ideal.

This should close https://github.com/neo4j-labs/neodash/issues/228


Default i18n messages should not replace pre-existing keys

If you have an app with i18n configured, and some local i18n keys to replace dry-validation message defaults, then later requiring dry-validation will overwrite those keys.
For example, if I set up i18n like this, in the boot sequence of my app:
require "i18n"
I18n.load_path += Dir["#{MyApp::Container.root}/apps/*/locales/**/*.yml"]
I18n.backend.load_translations

And where I have a .yml file like this:
en:
  errors:
    filled?: "Fill this thing, yo"

And then later on require a file that requires dry-validation, the errors.filled? key gets replaced with the default:
[1] pry(main)> I18n.t("errors.filled?")
=> "%{name} must be filled"

If, instead, I do a little hoop-jumping and force dry-v's i18n integration to load before I suppose my own locale files, then things work as I'd want:
require "i18n"

# Load dry-validation's i18n support first, so we can override if we want
require "dry/validation/messages/i18n"

I18n.load_path += Dir["#{Alpinist::Container.root}/apps/*/locales/**/*.yml"]

I18n.backend.load_translations

[1] pry(main)> I18n.t("errors.filled?")
=> "Fill this thing, yo"

You can see these examples in action in https://github.com/icelab/alpinist/tree/sign-in-and-users-crud.
I think the preferred behaviour here would be for dry-v not to do anything that might result in pre-existing keys being overwritten.

I'm not sure how to solve this to be honest. Does it work as expected when you unshift load path rather than append?

Sorry Tim but there's no way around that.

@solnic Fair enough! Thanks for looking into it.


Update app.css

Closing as per https://github.com/visenze/visenze-experiences-web/pull/23#issuecomment-2443477504.


email in security center don't support multiple address

Hi Team,
Seems that email field in Microsoft.Security/preview/2017-08-01-preview/SecurityContacts don't support multiple addresses that don't match the behavior at portal. Please have check.

Routing to security center team to follow up, thanks.

Have anyone following up the issue?
Thanks for that.

@lrxtom2 - each security contact supporting one item, but you can have multiple security contacts.

The 2020-01-01-preview version supports a semi-colon delimited list in the renamed "emails" property

Can anyone confirm that gjtaylor's response addresses the issue?  Does this require further followup or is it safe to close this?


Windows and clang: compilation error in src/loaders/svg/tvgSvgSceneBuilder.cpp

error:
../src/lib/tvgMath.h:52:56: error: use of undeclared identifier 'M_PI_2'
   if (radian < FLT_EPSILON || mathEqual(radian, float(M_PI_2)) || mathEqual(radian, float(M_PI))) return true;
                                                       ^
../src/lib/tvgMath.h:52:92: error: use of undeclared identifier 'M_PI'
   if (radian < FLT_EPSILON || mathEqual(radian, float(M_PI_2)) || mathEqual(radian, float(M_PI))) return true;
                                                                                ^
../src/lib/tvgMath.h:122:37: error: use of undeclared identifier 'M_PI'
    auto radian = degree / 180.0f * M_PI;
                                    ^

Problem:

First, on Windows, one must define _USE_MATH_DEFINES before including math.h to get M_PI and other macros.
tvgSvgSceneBuilder.cpp includes first cstring, which includes math.h, and after, it includes tvgMath.h. So _USE_MATH_DEFINES is not defined when math.h is included from cstring
when tvgMath.h is included, _USE_MATH_DEFINES is defined, but math.h is not included anymore. Hence the problem.

solution: in tvgSvgSceneBuilder.cpp, include tvgMath.h before the strings includes
or else define _USE_MATH_DEFINES globally
what do you think of this solutions ?

either one fine to me.


Expose DeviceCommissioner::ComputePASEVerifier to Obj-C.

Problem

Expose DeviceCommissioner::ComputePASEVerifier to Obj-C.

Change overview
Added functioncomputePaseVerifier:iterations:salt: to MTRDeviceController to expose DeviceCommissioner ::ComputePASEVerifier to Obj-C.

Also, why is this API on MTRDeviceController instances at all?  It does not use any instance state, either in practice or conceptually.  In the SDK API it's an instance API on DeviceCommissioner, but that's also an odd API choice and we should not be propagating it into the Darwin framework.


Add example for deterministic sign specifying a nonce

Hi, I'm working with this piece of code currently:
bool CKey::Sign(const uint256 &hash, std::vector<unsigned char>& vchSig, uint32_t test_case) const {
    if (!fValid)
        return false;
    vchSig.resize(72);
    RFC6979_HMAC_SHA256 prng(begin(), 32, (unsigned char*)&hash, 32);
    do {
        uint256 nonce;
        prng.Generate((unsigned char*)&nonce, 32);
        nonce += test_case;
        int nSigLen = 72;
        int ret = secp256k1_ecdsa_sign((const unsigned char*)&hash, 32, (unsigned char*)&vchSig[0], &nSigLen, begin(), (unsigned char*)&nonce);
        nonce = 0;
        if (ret) {
            vchSig.resize(nSigLen);
            return true;
        }
    } while(true);
}

Where secp256k1_ecdsa_sign prototype is:
int secp256k1_ecdsa_sign(const unsigned char *msg, int msglen, unsigned char *sig, int *siglen, const unsigned char *seckey, const unsigned char *nonce)

And, im trying to replace EC with Picnic, but I can't find a way to specify a noce in the code, I saw it in the signature2 struct but there is not example of the use of this structure.

hi @0T34
The Picnic spec and implementations do not allow callers to specify the nonce.  This is the reference implementation and signing is deterministic. So you can test your implementation with the provided known-answer tests (see kats_test.c).
The optimized implementation is much faster and is constant-time, the implementation we recommend using for prototyping.  In that implementation signing is also deterministic.

Thanks for the information.


Marketing button component

Not sure if this component should be named:

Primer::ButtonMarketingComponent (following React's ButtonDanger pattern)
Primer::MarketingButtonComponent (reads better)
Primer::Marketing::ButtonComponent (grouping all marketing components together)

Why not extend ButtonComponent?
They are really similar, but I decided to not add a marketing: argument to ButtonComponent since the options for its arguments differ
Docs

There don't seem to be too many Marketing related variants on Primer css so this seems 💯


Override logo based on config

@joaquimrocha i have added the caching part as well

@joaquimrocha and @krnowak changes done please review.


Memory Leak when --num_env > 1

repro:
python3 -m baselines.run --alg=ppo2 --env=PongNoFrameskip-v4 --num_timesteps=2e7 --num_env=2
Observations:

The memory usage of the two python env processes increases at about 30MB per minute until it OOM.
If I run with --num_env=1 there is no leak
cifar10 runs with no leaks
If I use other algos such as --alg=acer, it also leaks
If I use retro env (as opposed to atari env in the command above) it also leaks

I tried to track down the memory leak with pympler.
In:
def worker(remote, parent_remote, env_fn_wrapper),  subproc_vec_env.py
I used:
from pympler import tracker
tr = tracker.SummaryTracker()

[...]
if cmd == 'step':
     ob, reward, done, info = env.step(data)
      if done:
          **tr.print_diff()**
          ob = env.reset()

This is the output I got:
                        types |                       # objects |         total size

==================================== | =========== | ============
<class 'numpy.ndarray |                               911 |    113.88 KB
<class 'builtin_function_or_method |           911 |     64.05 KB
<class 'float |                                                  53 |     1.24 KB
<class 'list |                                                     0 |    928     B
<class 'int |                                                      1 |     28     B
Seems the ob, reward, done and info variable are leaking.
I tried to use del on these variables but the garbage collector doesn't get rid of them, even if I manually call it  with "gc.collect(2)"
Software:
Ubuntu 18.04
Tensorflow 1.12
Python 3.6.7
latest baselines (no modifications)
Hardware:
2x 2680v2
64MB ddr3
gtx 1060

@MatPoliquin does upgrading to numpy 1.16.1, as suggested in the referenced issue, solve this?

@pzhokhov Seems to be the cause, since I don't have the leak anymore. Thanks!

Cool, let me close this then


Support the lastest ssl_quic_method_st with set_read_secret and set_write_secret?

Hi, BoringSSL QUIC API supports ssl_quic_method_st with set_read_secret and set_write_secret method, I wonder if quictls/openssl supports the latest ssl_quic_method_st with set_read_secret and set_write_secret? Or only support set_encryption_secrets method?

The code currently does not support set_write_secret nor set_read_secret.
See: https://github.com/quictls/openssl/blob/openssl-3.0.0-alpha13%2Bquic/doc/man3/SSL_CTX_set_quic_method.pod

@tmshort should we revive #60?