Lab-4,5 : Numeronyms and stringer interface

Fixes #67
Changes proposed in this PR:
-Program to return numeronyms for a given set of strings
-Test cases for the program
Fixes #70
-Make IPAddr type implement fmt.Stringer to print dotted ip address
-Test cases for the program

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #80   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          11     12    +1
  Lines         170    182   +12
=====================================
+ Hits          170    182   +12

Impacted Files
Coverage Δ

04_numeronym/ShahNikita19/numeronym.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 290e700...874f93c. Read the comment docs.

@eobjects @ShahNikita19 Is this PR ready for review? It has changes requested label with no comments.

Yes,  it's ready, can u please review it.
On Thu 14 Feb, 2019, 8:55 AM Daniel Cantos<EMAIL_ADDRESS>wrote:

@eobjects https://github.com/eobjects @ShahNikita19
https://github.com/ShahNikita19 Is this PR ready for review? It has
changes requested label with no comments.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/anz-bank/go-training/pull/80#issuecomment-463473085,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AsU8frLeOw_px5blm8HW3en8M5l-f-V8ks5vNNc3gaJpZM4a48Sc
.

Please fix broken build!

Hi,
There has been  no activity in the last 20 days so I will close this PR.
Feel free to open it again if you have something to add.
Thanks!
Julia


Feature Request: Watermarked Documents

Describe the feature you'd like
An option to easily add a watermark to documents, and choose its positioning (top left, top right, etc).
Describe the benefits this feature would bring to BookStack users
This would be beneficial for using BookStack for policies in a work environment. For documents only viewed on BookStack, it's not really required, but say I wanted to print off a policy for another member of staff or third party company, I'd like to have company info (logo, web address) on the PDF.
Additional context
I work as a single IT administrator for a company and use BookStack for Policies and documenting servers and applications we use here.
Thanks for all your work so far on this project, the recent addition of shelves has been really beneficial, and has really complimented my slight OCD! 👍

This feature would be great!
+1

Agree, this would be a great feature to let people know that documentation is still in a draft stage for example.

This would be a great addition to add to the list of functionalities!

Hi team of BookStack.
You do great job with BookStack and it's the best free knowledge tool easy to use in the world ^^
Could you add the WaterMark feature for able bookstack to become THE knowledge to use pls x)

+1 ... Would be very nice!

+1 would like this feature as well.


Update .travis.yaml to exclude publish stage in PR

To save extra time.
Reference: https://docs.travis-ci.com/user/conditional-builds-stages-jobs

This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

Command Guidelines

[ ] Each command and parameter has a meaningful description.
[ ] Each new command has a test.

(see Authoring Command Modules)

Merged: https://github.com/Azure/azure-cli/commit/e0dbd104cd1926fb5fab023c79aa93714849c498


Reset margin for button element

Safari has a default margin for the button element.
I think it should be resetted as other elements.

can you please tell more about the issue i am not able to understand it


Add cargo descriptions and KYTHE_DIR explanation [phab:D1016]

Created by djrenren at 2016-08-16 22:49:10:
The cargo packages required descriptions so I added them. Also added an explanation of setting the KYTHE_DIR environment variable.

zarko commented inline (context lost during migration) at 2016-08-16 23:30:00:
Should Cargo be capitalized here?

zarko commented inline (context lost during migration) at 2016-08-16 23:30:00:
to determine the path to the local installation of Kythe

zarko commented inline (context lost during migration) at 2016-08-16 23:30:00:
Rust

zarko accepted this revision at 2016-08-16 23:30:00

djrenren commented inline (context lost during migration) at 2016-08-16 23:34:15:
Debatable. Went against my gut to follow the cue from a different package but I agree it's weird and if it give you pause as well I'll make it lowercase.

djrenren wrote at 2016-08-16 23:37:22:

Fix nits

djrenren closed via commit 209ab05b9d419b2e4c2c7e0a3a97454797a4674c at 2016-08-16 23:37:44


change readme for wicket7

The actual readme says that it works for wicket-6. After change API to work with wicket-7 we should change the readme.

Done by @thombergs


Configure node labels and taints

TODO:

Set up node labels and taints to organize nodes effectively based on their capacities and intended usage.
Use Kubernetes affinity and anti-affinity rules to ensure optimal allocation and scheduling of workloads.

Won't do. No need for now, we might re-open the issue in the futur


Create a redirect for www.freecodecamp.com/wiki to the Github Wiki

I will take a crack at this

All yours!

good luck!

I added this real quick. It'll be in tonight's wave of curriculum commits. Sorry for jumping the queue, @krantzinator

no worries @QuincyLarson I was still in the research phase. I'll look for something else to help with

Closed by commit baaae04.


Update http4s-client, http4s-dsl to 0.23.23

About this PR
📦 Updates

org.http4s:http4s-client
org.http4s:http4s-dsl

from 0.23.16 to 0.23.23
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.http4s" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, version-scheme:early-semver, commit-count:1

Superseded by #528.


[Sonar] Change this condition so that it does not always evaluate to "false" in src/main/java/org/trebol/jpa/services/conversion/CustomersConverterJpaServiceImpl.java

Summary

Source Sonar issue URL
Issue type: Bug / Vulnerability / Code Smell
Severity: Blocker / Critical / Major / Minor / Info
Technical debt: 5min / 15min / 20min effort

@Angel-M-R

Could you assing me ?


postgresql::ruby not running apt-get update

I was having issues getting libpq-dev to install on Ubuntu14. Even after making sure to specify recipe[apt::default] first in the run list. I noticed the ruby recipe (https://github.com/hw-cookbooks/postgresql/blob/develop/recipes/ruby.rb) was using run_action and would to run before recipe[apt::default] was being run.
This could be a odd use case as my base vagrant image already has the file /var/lib/apt/periodic/update-success-stamp (last updated on July 6th) so the check being performed here https://github.com/hw-cookbooks/postgresql/blob/develop/recipes/ruby.rb#L32 was always skipping the apt-update call from being triggered.
I added a quick work around for my situation here:
https://github.com/kpettijohn/postgresql/blob/feature/apt-update-on-time/recipes/ruby.rb#L33
Basically I just check that apt-get update was run with 24 hours. I don't think this is really the best solution but I thought it would be worth creating a issue to give this some visibility if others run into the problem.
Starting Chef Client, version 11.14.2
resolving cookbooks for run list: ["apt::default", "mycookbook"]
Synchronizing Cookbooks:
  - apt
  - nginx
  - beanstalkd
  - bluepill
  - ohai
  - yum-epel
  - database
  - runit
  - build-essential
  - openssl
  - rsyslog
  - yum
  - aws
  - mysql-chef_gem
  - chef-sugar
  - mysql
  - yum-mysql-community
  - xfs
  - mycookbook
  - postgresql
Compiling Cookbooks...
Recipe: ohai::default
  * remote_directory[/etc/chef/ohai_plugins for cookbook ohai] action create
    - create new directory /etc/chef/ohai_plugins
    - change mode from '' to '0755'
  Recipe: <Dynamically Defined Resource>
    * cookbook_file[/etc/chef/ohai_plugins/README] action create
      - create new file /etc/chef/ohai_plugins/README
      - update content in file /etc/chef/ohai_plugins/README from none to 775fa7
      --- /etc/chef/ohai_plugins/README	2014-08-25 16:02:33.641378345 -0700
      +++ /tmp/.README20140825-6943-3v6zpq	2014-08-25 16:02:34.033350556 -0700
      @@ -1 +1,2 @@
      +This directory contains custom plugins for Ohai.
      - change mode from '' to '0644'

Recipe: ohai::default
  * ohai[custom_plugins] action reload
    - re-run ohai and merge results into node attributes
[2014-08-25T16:02:46-07:00] WARN: Cloning resource attributes for service[nginx] from prior resource (CHEF-3694)
[2014-08-25T16:02:46-07:00] WARN: Previous service[nginx]: /home/vagrant/.chef/local-mode-cache/cache/cookbooks/nginx/recipes/package.rb:46:in `from_file'
[2014-08-25T16:02:46-07:00] WARN: Current  service[nginx]: /home/vagrant/.chef/local-mode-cache/cache/cookbooks/nginx/recipes/default.rb:24:in `from_file'
Recipe: build-essential::_debian
  * package[autoconf] action install (up to date)
  * package[binutils-doc] action install (up to date)
  * package[bison] action install (up to date)
  * package[build-essential] action install (up to date)
  * package[flex] action install (up to date)
  * package[gettext] action install (up to date)
  * package[ncurses-dev] action install (up to date)
Recipe: postgresql::apt_pgdg_postgresql
  * file[remove deprecated Pitti PPA apt repository] action delete (up to date)
  * apt_repository[apt.postgresql.org] action add
    * remote_file[/home/vagrant/.chef/local-mode-cache/cache/ACCC4CF8.asc] action create (up to date)
    * execute[install-key ACCC4CF8.asc] action run (skipped due to not_if)
    * file[/var/lib/apt/periodic/update-success-stamp] action nothing (skipped due to action :nothing)
    * execute[apt-cache gencaches] action nothing (skipped due to action :nothing)
    * execute[apt-get update] action nothing (skipped due to action :nothing)
    * file[/etc/apt/sources.list.d/apt.postgresql.org.list] action create (up to date)
     (up to date)
Recipe: postgresql::client
  * package[postgresql-client-9.3] action install (up to date)
  * package[libpq-dev] action install

    ================================================================================
    Error executing action `install` on resource 'package[libpq-dev]'
    ================================================================================

    Mixlib::ShellOut::ShellCommandFailed
    ------------------------------------
    Expected process to exit with [0], but received '100'
    ---- Begin output of apt-get -q -y install libpq-dev=9.3.5-1.pgdg14.04+1 ----
    STDOUT: Reading package lists...
    Building dependency tree...
    Reading state information...
    The following extra packages will be installed:
      comerr-dev krb5-multidev libgssrpc4 libkadm5clnt-mit9 libkadm5srv-mit9
      libkdb5-7 libpq5 libssl-dev libssl-doc zlib1g-dev
    Suggested packages:
      doc-base krb5-doc krb5-user postgresql-doc-9.3
    The following NEW packages will be installed:
      comerr-dev krb5-multidev libgssrpc4 libkadm5clnt-mit9 libkadm5srv-mit9
      libkdb5-7 libpq-dev libssl-dev libssl-doc zlib1g-dev
    The following packages will be upgraded:
      libpq5
    1 upgraded, 10 newly installed, 0 to remove and 2 not upgraded.
    Need to get 2,032 kB/2,828 kB of archives.
    After this operation, 11.4 MB of additional disk space will be used.
    Err http://us.archive.ubuntu.com/ubuntu/ trusty-updates/main libssl-dev amd64 1.0.1f-1ubuntu2.4
      404  Not Found [IP: <IP_ADDRESS> 80]
    Err http://security.ubuntu.com/ubuntu/ trusty-security/main libssl-dev amd64 1.0.1f-1ubuntu2.4
      404  Not Found [IP: <IP_ADDRESS> 80]
    Err http://security.ubuntu.com/ubuntu/ trusty-security/main libssl-doc all 1.0.1f-1ubuntu2.4
      404  Not Found [IP: <IP_ADDRESS> 80]
    STDERR: E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/o/openssl/libssl-dev_1.0.1f-1ubuntu2.4_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]

    E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/o/openssl/libssl-doc_1.0.1f-1ubuntu2.4_all.deb  404  Not Found [IP: <IP_ADDRESS> 80]

    E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
    ---- End output of apt-get -q -y install libpq-dev=9.3.5-1.pgdg14.04+1 ----
    Ran apt-get -q -y install libpq-dev=9.3.5-1.pgdg14.04+1 returned 100

    Cookbook Trace:
    ---------------
    /home/vagrant/.chef/local-mode-cache/cache/cookbooks/postgresql/recipes/ruby.rb:54:in `block in from_file'
    /home/vagrant/.chef/local-mode-cache/cache/cookbooks/postgresql/recipes/ruby.rb:53:in `each'
    /home/vagrant/.chef/local-mode-cache/cache/cookbooks/postgresql/recipes/ruby.rb:53:in `rescue in from_file'
    /home/vagrant/.chef/local-mode-cache/cache/cookbooks/postgresql/recipes/ruby.rb:24:in `from_file'
    /home/vagrant/.chef/local-mode-cache/cache/cookbooks/mycookbook/recipes/default.rb:20:in `from_file'

    Resource Declaration:
    ---------------------
    # In /home/vagrant/.chef/local-mode-cache/cache/cookbooks/postgresql/recipes/client.rb

     36:   package pg_pack
     37:

    Compiled Resource:
    ------------------
    # Declared in /home/vagrant/.chef/local-mode-cache/cache/cookbooks/postgresql/recipes/client.rb:36:in `block in from_file'

    package("libpq-dev") do
      action :install
      retries 0
      retry_delay 2
      guard_interpreter :default
      package_name "libpq-dev"
      version "9.3.5-1.pgdg14.04+1"
      timeout 900
      cookbook_name "postgresql"
      recipe_name "client"
    end

I notice that this issue is still open, does this mean this is being recognized as an issue in the postgresql cookbook and an fix will eventually be provided as part of the cookbook? Or should we assume that this is a configuration "bug" and we, the consumers of this cookbook, should be incorporating the work-arounds provided by @hulu1522 into our cookbooks?
(Obviously in the short term @hulu1522's fixes need to be used. I'm just wondering what the long-term solution is expected to be.)

@RLovelett Personally I think that because the cookbook is already attempting to update the repos at compile time here it would be nice to have some better logic to determine if apt-get update should be run at compile time or not.
If we think it should be left up to the consumers of the cookbook then we should remove the current logic so it will fail consistently and just add a note on the README that includes some suggestions provided by @hulu1522
Just my two cents on the issue.

I guess I'll through in a few comments on this one.  The biggest issue with the Ruby recipe is that it needs to compile the gem.  That requires build-essential cookbook to run.  Since you are forcing that to run at compile time we need to make sure apt is run before it in order for the package repo's to be updated.  I would almost suggest removing both the build-essential and apt from the recipe and allow the end user to install them as a base.  Just make sure people know about the change and how to fulfill the dependancies of using the Ruby recipe.  @kpettijohn @RLovelett

postgresql::ruby is building the pg gem fine in current cookbook releases.

Still having this problem with postgresql release 4.0.6


Taking screenshots and recording videos

[x] #24

Maybe recording screen as well?

This is very easy to do on Android:
$ adb shell screenrecord /sdcard/test_recording.mp4

Was implemented with patrol drive (with flutter screenshot), in Patrol 1.0 we'll lose this feature.


Create document for how to get into extensions stores

Fixes #2

Hi, thanks for the info, but I think this shouldn't go in the readme as we don't want to push people to release their own versions.

I hear what you're saying, but honestly 🤷♂ so what if they do. It's driving people to your site in a way that only helps your ohdear.app project


Excel Writer step 10.2

 Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

🐸 JFrog Frogbot

:white_check_mark: Build finished in 40m 12s
Build command:
mvn clean verify -B -e -Daudit -amd -pl plugins/excel/core

:ok_hand: All tests passed!
Tests run: 116, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

 Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

🐸 JFrog Frogbot

:white_check_mark: Build finished in 23m 47s
Build command:
mvn clean verify -B -e -Daudit -amd -pl plugins/excel/core

:ok_hand: All tests passed!
Tests run: 116, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message


Nullability annotations in the generated abstract classes

Is it possible to add  some nullability annotations (e.g. org.jetbrains.annotations.NotNull) to the getters and setters in the generated Abstract classes.
As an example, for the below xml attributes
<Attribute name="title" javaType="String" nullable="false" columnName="TITLE" maxLength="50" />
<Attribute name="description" javaType="String" nullable="true" columnName="DESCRIPTION" maxLength="250" />

Is it possible for the generated code to contain nullability annotations as follows
@NotNull
public String getTitle()
{
	// getter code
	return data.getTitle();
}

public void setTitle(@NotNull String newValue)
{
	// setter code
}

@Nullable
public String getDescription()
{
	// getter code
	return data.getDescription();
}

public void setDescription(@Nullable String newValue)
{
	// setter code
}

Would it be somehow possible to achieve this by extending either the MithraGenerator or the Abstract.jsp file

Sorry, this is currently not possible. NotNull is not a standard java annotation and there are at least 7 competing ones!
It should be relatively easy to add the @NotNull annotation to the generator and a flag to turn it on. The user can then choose which variety of NotNull they want by adding an <Import> declaration.

Thanks for the quick reply! Would it be possible to get this enhancement? This would help us in making our code more null safe. I am also trying to use Reladomo in a Kotlin project and these annotations would help Kotlin's type system to generate compile time errors instead of the NullPointerException and MithraNullPrimitiveException.

To avoid the MithraNullPrimitiveException you should have a call to isNull() check generated by Reladomo.

To expand on what Nikhil is saying, no annotation is going to help with MithraNullPrimitiveException. To look at the special null value for a primitive, you must call isFooNull() before calling getFoo(). If you're having serious issues with those, it may be because of mismatches in your database design. In most cases, primitives stored in a database should not be nullable. Your database will be happier too, because it doesn't have to store a special flag for these. In the rare cases where you want the null value to mean something special then the code pattern should always check for this special condition anyway, as above.
The standard java compiler does not support compile time checking of NotNull annotation. Using java code in a Kotlin project isn't going to generate byte code any differently either.
So as far as I can tell, this doesn't help much for your case, nor does it in general, as the only use seems to be for trivial checks in IDEs.


Expose OracleContainer image name property as public constant

This makes it easier and safer for user code to refer to image name property. For example:
@BeforeAll
static void setUpClass() {
    Assumptions.assumeTrue(
        TestcontainersConfiguration.getInstance().getProperties().containsKey(OracleContainer.IMAGE_NAME_PROPERTY));
}

Thanks @vpavic - I think this is pretty sensible. I just wonder if there's a more general solution that we could look at.
#1345 will remove the image pull from the container constructor. This should make it safe to instantiate an OracleContainer even if the image is not available.
We would then have freedom to add some methods to the container class itself - for example, isImageAvailable(). Maybe with an optional boolean argument to prevent pulling of the image, if that's desired.
You could then make your assumption be: assumeTrue(myOracleContainer.isImageAvailable()), reducing the amount of 'knowledge' that's needed to find out whether the image is available.
WDYT?

@rnorth Maybe I am missing something, but I thought this is not the point of @vpavic.
I thought about a use case like:
if (!TestcontainersConfiguration.getInstance().getProperties()
  .containsKey(OracleContainer.IMAGE_NAME_PROPERTY)) {

  TestcontainersConfiguration.getInstance()
    .updateGlobalConfig(OracleContainer.IMAGE_NAME_PROPERTY, "myTestingImage");
}

Not sure though? :sweat_smile:

Thanks for the feedback @rnorth.
Yes, @kiview is right - my idea was simply to support a safer way of verifying presence of oracle.container.image Testcontainers property.
The background is that in Spring Session we have an Oracle integration test that is conditional on presence of this property. This is needed due to lack of public Docker images for Oracle database so the test only runs when explicitly enabled.

@kiview the code you linked should never be used, actually :D
updateGlobalConfig is semi-internal API, but we had to call it from another package. Setting environment properties imperatively is not a good idea, since it will be shared between projects

@bsideup Note that instantiating container is exactly what I prevent in this case, hence the use of this check in @BeforeAll.

Any further feedback on this? To clarify a bit more, as can be seen from the example in the opening comment, I'm preventing the entire test class from being set up, and would like to do it in a less fragile way, referencing the constant (or possibly something else, but it has to be static).
So any helper method would need to be static to be an option for this use case.

Could this be reopened please?


feat: add streaming kafka-to-http sample

What this PR changes/adds
Create a simple streaming sample.
Why it does that
documenting streaming capabilities
Linked Issue(s)
Closes #107

@yurimssilva please fix the e2e tests, then I will merge it


ALSA warnings at startup

Hi,
when i start jasper.py everytime i got a lot of warnings about ALSA.
There is a way to abolish them?
example:
ALSA lib confmisc.c:1286:(snd_func_refer) Unable to find definition 'cards.bcm2835.pcm.front.0:CARD=0'
ALSA lib conf.c:4259:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:4738:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM front
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.rear
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.center_lfe
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.side

Yes there is way but not simple. I did something 2 years back and don't remember what I did right now.

Could you please check it? And if is possible send me the resolution steps?
Il 04 mar 2018 06:02, "G10DRAS"<EMAIL_ADDRESS>ha scritto:

Yes there is way but not simple. I did something 2 years back and don't
remember what I did right now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jasperproject/jasper-client/issues/667#issuecomment-370202410,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMi1nk47UNLEeRjnJlGKQo9i_NRh5pFPks5ta3VOgaJpZM4Sa4cE
.

ok check this out
https://groups.google.com/forum/#!topic/robocopai/UnbVwW8sOGo


Is threads > 0 supported?

We have a clickhouse cluster with more than one node.
Hi I have adbt pipeline which works fine with threads = 1, but yields a variety of irregular errors when I run with threads > 1. Is this expected to work?

We run tests against ClickHouse Cloud with threads = 4.  What type of errors are you seeing?  Support for distributed tables is also experimental, so that might be related.

First of all I often see this right after I do dbt run
19:07:45  Encountered an error:
Database Error
  Database Error
    Failed to create dbt_dev database due to ClickHouse exception

Then often various steps will fail, and some steps will be skipped, that I dont see when running on a single thread. Here is one example of an error I never see singlethreaded:
19:09:24  Running with dbt=1.4.9
19:09:24  [WARNING]: Configuration paths exist in your dbt_project.yml file which do not apply to any resources.
There are 1 unused configuration paths:
- models.clickhouse.lookups
19:09:24  Found 15 models, 0 tests, 0 snapshots, 0 analyses, 325 macros, 1 operation, 1 seed file, 11 sources, 0 exposures, 0 metrics
19:09:24
19:09:24  Concurrency: 4 threads (target='dev')
19:09:24
19:09:24  1 of 15 START sql incremental model dbt_dev_intermediate.int_sales__daily__external  [RUN]
19:09:24  2 of 15 START sql table model dbt_dev_staging.stg_configuration__adunit__site__placement  [RUN]
19:09:24  3 of 15 START sql table model dbt_dev_staging.stg_configuration__placements .... [RUN]
19:09:24  4 of 15 START sql table model dbt_dev_staging.stg_configuration__sites ......... [RUN]
19:09:25  2 of 15 OK created sql table model dbt_dev_staging.stg_configuration__adunit__site__placement  [OK in 0.83s]
19:09:25  5 of 15 START sql table model dbt_dev_staging.stg_dim__bidders ................. [RUN]
19:09:26  4 of 15 OK created sql table model dbt_dev_staging.stg_configuration__sites .... [OK in 1.07s]
19:09:26  6 of 15 START sql table model dbt_dev_staging.stg_dim__channels ................ [RUN]
19:09:26  3 of 15 OK created sql table model dbt_dev_staging.stg_configuration__placements  [OK in 1.13s]
19:09:26  7 of 15 START sql table model dbt_dev_staging.stg_dim__countries ............... [RUN]
19:09:26  5 of 15 OK created sql table model dbt_dev_staging.stg_dim__bidders ............ [OK in 0.75s]
19:09:26  8 of 15 START sql table model dbt_dev_staging.stg_dim__device_types ............ [RUN]
19:09:26  6 of 15 OK created sql table model dbt_dev_staging.stg_dim__channels ........... [OK in 0.79s]
19:09:26  9 of 15 START sql table model dbt_dev_staging.stg_dim__media_types ............. [RUN]
19:09:26  7 of 15 OK created sql table model dbt_dev_staging.stg_dim__countries .......... [OK in 0.88s]
19:09:26  10 of 15 START sql view model dbt_dev_staging.stg_landscape__realtime .......... [RUN]
19:09:27  8 of 15 OK created sql table model dbt_dev_staging.stg_dim__device_types ....... [OK in 0.69s]
19:09:27  9 of 15 OK created sql table model dbt_dev_staging.stg_dim__media_types ........ [OK in 0.67s]
19:09:27  10 of 15 OK created sql view model dbt_dev_staging.stg_landscape__realtime ..... [OK in 0.91s]
19:09:27  11 of 15 START sql incremental model dbt_dev_staging.stg_landscape__hourly ..... [RUN]
19:09:31  11 of 15 ERROR creating sql incremental model dbt_dev_staging.stg_landscape__hourly  [ERROR in 3.83s]
19:09:31  12 of 15 SKIP relation dbt_dev_staging.stg_landscape__daily .................... [SKIP]
19:09:31  13 of 15 SKIP relation dbt_dev_intermediate.int_sales__daily__internal ......... [SKIP]
19:11:50  1 of 15 OK created sql incremental model dbt_dev_intermediate.int_sales__daily__external  [OK in 145.72s]
19:11:50  14 of 15 SKIP relation dbt_dev_intermediate.int_sales__daily ................... [SKIP]
19:11:50  15 of 15 SKIP relation dbt_dev_marts.mrt_sales__daily .......................... [SKIP]
19:11:50
19:11:50  Running 1 on-run-end hook
19:11:50  1 of 1 START hook: clickhouse.on-run-end.0 ..................................... [RUN]
19:11:51  1 of 1 OK hook: clickhouse.on-run-end.0 ........................................ [OK in 0.30s]
19:11:51
19:11:51
19:11:51  Finished running 8 table models, 4 view models, 3 incremental models, 1 hook in 0 hours 2 minutes and 26.40 seconds (146.40s).
19:11:51
19:11:51  Completed with 1 error and 0 warnings:
19:11:51
19:11:51  Database Error in model stg_landscape__hourly (models/staging/landscape/stg_landscape__hourly.sql)
19:11:51    :HTTPDriver for http://clickhouse-dev.dragonite.venatusmedia.com:8123 returned response code 500)
19:11:51     Code: 36. DB::Exception: ALTER UPDATE/ALTER DELETE statement with subquery may be nondeterministic, see allow_nondeterministic_mutations setting. (BAD_ARGUMENTS) (version <IP_ADDRESS>92 (official build))
19:11:51    compiled Code at target/run/clickhouse/models/staging/landscape/stg_landscape__hourly.sql
19:11:51
19:11:51  Done. PASS=10 WARN=0 ERROR=1 SKIP=4 TOTAL=15

It would be useful to understand (maybe from the ClickHouse logs?) what the exception is for the create database DDL query.  It seems like it might be permissions related.
Certain incremental materializations using "lightweight deletes" with the delete_insert strategy use subqueries that could be considered "non-deterministic" by Clickhouse (although they aren't actually non-deterministic because dbt should be executing the affected queries in sequence as part of the materialization).  Recent versions of dbt-clickhouse attempt to automatically send the "allow_nondeterministic_mutations" setting, but that doesn't always seem to work (and could also be permissions related.)
Are there any additional exceptions available in the ClickHouse server or query logs?

Sorry for the delay getting back, but this is an error from the clickhouse log at the time of the iniital error:
2023.10.27 16:05:42.038408 [ 619 ] {1b9a3f62-1d96-45c7-a9d3-d5b467da31d2} <Error> executeQuery: Code: 82. DB::Exception: There was an error on [chi-repl-04-23-replcluster-23-0-0:9000]: Code: 82. DB::Exception: Database dbt_dev already exists. (DATABASE_ALREADY_EXISTS) (version <IP_ADDRESS>92 (official build)). (DATABASE_ALREADY_EXISTS) (version <IP_ADDRESS>92 (official build)) (from <IP_ADDRESS>:40268) (in query: CREATE DATABASE dbt_dev ON CLUSTER "replcluster-23" ), Stack trace (when copying this message, always include the lines below):

0. DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000c604e57 in /usr/bin/clickhouse
1. DB::DDLQueryStatusSource::generate() @ 0x00000000122944a3 in /usr/bin/clickhouse
2. DB::ISource::tryGenerate() @ 0x000000001315ab35 in /usr/bin/clickhouse
3. DB::ISource::work() @ 0x000000001315a686 in /usr/bin/clickhouse
4. DB::ExecutionThreadContext::executeTask() @ 0x000000001317205a in /usr/bin/clickhouse
5. DB::PipelineExecutor::executeStepImpl(unsigned long, std::atomic<bool>*) @ 0x0000000013168e90 in /usr/bin/clickhouse
6. DB::PipelineExecutor::execute(unsigned long, bool) @ 0x00000000131681c2 in /usr/bin/clickhouse
7. DB::CompletedPipelineExecutor::execute() @ 0x0000000013166a72 in /usr/bin/clickhouse
8. DB::executeQuery(DB::ReadBuffer&, DB::WriteBuffer&, bool, std::shared_ptr<DB::Context>, std::function<void (DB::QueryResultDetails const&)>, std::optional<DB::FormatSettings> const&) @ 0x00000000122a9f8c in /usr/bin/clickhouse
9. DB::HTTPHandler::processQuery(DB::HTTPServerRequest&, DB::HTMLForm&, DB::HTTPServerResponse&, DB::HTTPHandler::Output&, std::optional<DB::CurrentThread::QueryScope>&) @ 0x00000000130b2d4f in /usr/bin/clickhouse
10. DB::HTTPHandler::handleRequest(DB::HTTPServerRequest&, DB::HTTPServerResponse&) @ 0x00000000130b7629 in /usr/bin/clickhouse
11. DB::HTTPServerConnection::run() @ 0x0000000013127fd2 in /usr/bin/clickhouse
12. Poco::Net::TCPServerConnection::start() @ 0x0000000015b10374 in /usr/bin/clickhouse
13. Poco::Net::TCPServerDispatcher::run() @ 0x0000000015b11571 in /usr/bin/clickhouse
14. Poco::PooledThread::run() @ 0x0000000015c47da7 in /usr/bin/clickhouse
15. Poco::ThreadImpl::runnableEntry(void*) @ 0x0000000015c4607c in /usr/bin/clickhouse
16. ? @ 0x00007fa0c226c609 in ?
17. ? @ 0x00007fa0c2191133 in ?

2023.10.27 16:05:42.038758 [ 619 ] {1b9a3f62-1d96-45c7-a9d3-d5b467da31d2} <Error> DynamicQueryHandler: Code: 82. DB::Exception: There was an error on [chi-repl-04-23-replcluster-23-0-0:9000]: Code: 82. DB::Exception: Database dbt_dev already exists. (DATABASE_ALREADY_EXISTS) (version <IP_ADDRESS>92 (official build)). (DATABASE_ALREADY_EXISTS), Stack trace (when copying this message, always include the lines below):

0. DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000c604e57 in /usr/bin/clickhouse
1. DB::DDLQueryStatusSource::generate() @ 0x00000000122944a3 in /usr/bin/clickhouse
2. DB::ISource::tryGenerate() @ 0x000000001315ab35 in /usr/bin/clickhouse
3. DB::ISource::work() @ 0x000000001315a686 in /usr/bin/clickhouse
4. DB::ExecutionThreadContext::executeTask() @ 0x000000001317205a in /usr/bin/clickhouse
5. DB::PipelineExecutor::executeStepImpl(unsigned long, std::atomic<bool>*) @ 0x0000000013168e90 in /usr/bin/clickhouse
6. DB::PipelineExecutor::execute(unsigned long, bool) @ 0x00000000131681c2 in /usr/bin/clickhouse
7. DB::CompletedPipelineExecutor::execute() @ 0x0000000013166a72 in /usr/bin/clickhouse
8. DB::executeQuery(DB::ReadBuffer&, DB::WriteBuffer&, bool, std::shared_ptr<DB::Context>, std::function<void (DB::QueryResultDetails const&)>, std::optional<DB::FormatSettings> const&) @ 0x00000000122a9f8c in /usr/bin/clickhouse
9. DB::HTTPHandler::processQuery(DB::HTTPServerRequest&, DB::HTMLForm&, DB::HTTPServerResponse&, DB::HTTPHandler::Output&, std::optional<DB::CurrentThread::QueryScope>&) @ 0x00000000130b2d4f in /usr/bin/clickhouse
10. DB::HTTPHandler::handleRequest(DB::HTTPServerRequest&, DB::HTTPServerResponse&) @ 0x00000000130b7629 in /usr/bin/clickhouse
11. DB::HTTPServerConnection::run() @ 0x0000000013127fd2 in /usr/bin/clickhouse
12. Poco::Net::TCPServerConnection::start() @ 0x0000000015b10374 in /usr/bin/clickhouse
13. Poco::Net::TCPServerDispatcher::run() @ 0x0000000015b11571 in /usr/bin/clickhouse
14. Poco::PooledThread::run() @ 0x0000000015c47da7 in /usr/bin/clickhouse
15. Poco::ThreadImpl::runnableEntry(void*) @ 0x0000000015c4607c in /usr/bin/clickhouse
16. ? @ 0x00007fa0c226c609 in ?
17. ? @ 0x00007fa0c2191133 in ?
 (version <IP_ADDRESS>92 (official build))

I should mention also that we are running against a cluster of one shard consisting of two replicas.

For the non-deterministic error, I should also mention that this incremental materialization is based off a remote view to another clickhouse instance. Im not sure if this is relevant though.

Ah, the DATABASE ALREADY EXISTS error is a pretty obvious bug in the way that the client handles creating a database on startup for clusters.  If the database exists on one replica but not the one that is checked, it runs the CREATE DATABASE ON CLUSTER incorrectly.  I'll have to give it some thought but that should be a pretty easy fix.
The fact that you're doing something off of a Remote table function may in fact be contributing to the other weird error.  I know it's unlikely but if you could find a reproducible example it might be possible to track down.

Ill try to find some time to create an example.

For those who have this issue like me. Set allow_nondeterministic_mutations = 1 in user profile will make it work. https://clickhouse.com/docs/en/operations/settings/settings#allow_nondeterministic_mutations

I should also point out that this has recently been occurring on a single thread. So I think this is not related to multiple threads as first thought.

If you are continuing to get this error:
ALTER UPDATE/ALTER DELETE statement with subquery may be nondeterministic, see allow_nondeterministic_mutations setting.
I believe @supnobita's suggestion should provide a valid workaround if you make sure the active profile has allow_nondeterministic_mutations=1 enable on all nodes.  dbt_clickhouse tries to send that setting with every relevant request, but it may not be effective due to permissions or other issues.  I'll look at the behavior here and try to make it more foolproof from the dbt-clickhouse side but there's only so much the plugin can do if the appropriate setting is not enabled, since it's difficult for the client to validate the setting on all possible nodes.
Similarly, ensuring that the dbt database already exists on all nodes should also fix the initial create database error.  For similar reasons this is difficult to ensure from dbt-clickhouse.

Just to be clear, the delete+insert incremental strategy involves what ClickHouse regards as a non-deterministic mutation.  It's an implementation behavior of "lightweight deletes".

As of version 1.7.1  there are now some prechecks in place to ensure the database exists on the entire cluster and that nondeterministic mutations are allowed in connection with the delete+insert strategy.


Feature: Adding Loenn plugin trigger for Map Makers

Somehow I didn't realize there is already a pull request to add this feature (#1) . I did it anyways 🤙🏼
Loenn Plugin to toggle mod

This has a lua implementation and some validations to keep original user's config of the mod.
That's it 🦊

And the property...

Hey there! i'm making a helper update for Portaline, which will add some useful entities such as emancipation grills, and i'd love to have this in the base mod. May i use your code? I'll make sure to credit you on the GameBanana page (alongside @Saplonily)
i've also noticed that your Portaline+ is using the same id as the base Portaline, which is not recommended. Would you mind taking Portaline+ down in favour of the new update? Thank you

Of course!, I'd love to see this implemented in the original. I'll reopen the pull request by the way🦊

awesome, thank you!!! will be merging the pr now

lol, thanks for doing these!


cmd/compile: ctz rules on s390x

I don't think these rules do the right thing if the input argument is 0.
What does FLOGR return if the input is 0?
Ctz64 should return 64 if the input is 0, and Ctz32 should return 32 if the input is 0.  But FLOGR is used for both, one of them at least has to be wrong.
It probably doesn't matter at the moment as the runtime probably never calls Ctz with a 0 argument.  But I'm about to make math/bits use the intrinsic, and there it matters.
@mundaym

I can see why the rules looks dubious but they are correct. I've created a little program to demonstrate:
https://play.golang.org/p/LFdFii1YQC
Thanks for opening the issue though, always worth double checking these things :).

Ok, I was confused about the bit twiddling.  (CtzX 0) doesn't actually pass 0 to FLOGR.
Thanks for looking into it.


Create alumno.txt

I made this pull request in an effort to add the Universidad Técnologica de Puebla and its domain @alumno.utpuebla.edu.mx to the list of educational institutions known by your organization. Thank you very much in advance, if you facilitate the veracity review of the existence of my university you can visit the internet portal of the same with the only caveat that it is completely in Spanish https://www.utpuebla.edu.mx/

@Manuel-Baez-Ponce First stage of verification passed, official domain is utpuebla.edu.mx as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.


Added xeus-cpp

Converting to draft atm !

I think we can close this PR now as it was superseded by #937.


cmake-based openmpi builds

I've identified an issue where openmpi builds, configured using cmake, cause the downstream netcdf-fortran parallel tests to break.
The issue goes away if parallel netcdf-c is configured using autotools.  Similarly, the issue goes away if parallel netcdf-c is configured using cmake but we are using mpich2 instead of openmpi.
See https://github.com/Unidata/netcdf-fortran/issues/58 for the fortran side of this.  Starting to debug this on the cmake-parallel branch.
Note that the parallel netcdf-c tests work just fine and dandy regardless of which tool was used to configure it.

Corrected, closing out.


Add hibernation button

Is it possible to add a hibernation button?

I'm afraid that it's quite difficult to implement this feature now, because GNOME doesn't provide a button for hibernation (as well as for sleep).
But I'll see what I can do for this.

Yes. Hibernation is configured by me.
I tried adding the button myself, but it didn't work.
(I haven't written a gnome shell program)
                addButton({
                    label: _(`Hirbernate`, `button`),
                    setKeyFocus: this._type === 1,
                    action: () => {
                        const signalId = this.connect(`closed`, () => {
                            this.disconnect(signalId);
                            this._confirm(`ConfirmedHirbernate`).catch(logError);
                        });
                        this.close(true);
                    },
                });

It'll take effect with a command.(systemctl hibernate)

Fixed with 502c7eb636b152621f38d172159886e672defb1b.

Thank you. It works.
But the internationalization of the text is not working, it was working fine before.

Yes, now someone has to translate it.


./run: line 103: ./bedrock-server-<IP_ADDRESS>: cannot execute binary file: Exec format error

Hi, try to install mc server on my blue (aarch64), but get this error.
 Add-on: HA Spawn Point Bedrock
 Minecraft Server Addon Bedrock Edition
-----------------------------------------------------------
 Add-on version: 2024.1.0
 You are running the latest version of this add-on.
 System: Home Assistant OS 12.2  (aarch64 / odroid-n2)
 Home Assistant Core: 2024.5.5
 Home Assistant Supervisor: 2024.05.1
-----------------------------------------------------------
 Please, share the above information when looking for help
 or support in, e.g., GitHub, forums or the Discord chat.
-----------------------------------------------------------
s6-rc: info: service base-addon-banner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service base-addon-timezone: starting
s6-rc: info: service base-addon-log-level: starting
s6-rc: info: service fix-attrs successfully started
[09:33:23] INFO: Configuring timezone (Europe/Amsterdam)...
s6-rc: info: service base-addon-log-level successfully started
s6-rc: info: service base-addon-timezone successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
services-up: info: copying legacy longrun ha-spawn-point-bedrock (no readiness notification)
s6-rc: info: service legacy-services successfully started
Download URL 'https://minecraft.azureedge.net/bin-linux/bedrock-server-<IP_ADDRESS>.zip'
Download bedrock-server-<IP_ADDRESS>.zip started ... please wait
Removing old version
Installing new version
Create Bedrock Server Configuration
Update allow-list with allow_list in ./server.properties
Update default-player-permission-level with default_player_permission_level in ./server.properties
Update difficulty with difficulty in ./server.properties
Update gamemode with gamemode in ./server.properties
Update level-name with level_name in ./server.properties
Config: update server entry: level-name = Spawn Point Bedrock
Update max-players with max_players in ./server.properties
Update server-name with server_name in ./server.properties
Config: update server entry: server-name = Spawn Point Bedrock Server
Creating allow List
Use Allow User List: False
Creating permission List
Update User Permissions
Starting Bedrock Server
./run: line 103: ./bedrock-server-<IP_ADDRESS>: cannot execute binary file: Exec format error
[09:34:38] WARNING: Halt add-on with exit code 126
s6-rc: info: service legacy-services: stopping
s6-rc: info: service legacy-services successfully stopped
s6-rc: info: service legacy-cont-init: stopping
s6-rc: info: service legacy-cont-init successfully stopped
s6-rc: info: service fix-attrs: stopping
s6-rc: info: service base-addon-timezone: stopping
s6-rc: info: service base-addon-log-level: stopping
s6-rc: info: service fix-attrs successfully stopped
s6-rc: info: service base-addon-timezone successfully stopped
s6-rc: info: service base-addon-log-level successfully stopped
s6-rc: info: service base-addon-banner: stopping
s6-rc: info: service base-addon-banner successfully stopped
s6-rc: info: service s6rc-oneshot-runner: stopping
s6-rc: info: service s6rc-oneshot-runner successfully stopped```

Hi and thanks for your report. I think the aatch platform is not working correctly anymore. I may have to in include box64 in the next release.

Experiencing the same issue here, also on aarch64 but on a Raspberry Pi 5:
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service base-addon-banner: starting

-----------------------------------------------------------
 Add-on: HA Spawn Point Bedrock
 Minecraft Server Addon Bedrock Edition
-----------------------------------------------------------
 Add-on version: 2024.1.0
 You are running the latest version of this add-on.
 System: Home Assistant OS 12.4  (aarch64 / raspberrypi5-64)
 Home Assistant Core: 2024.7.1
 Home Assistant Supervisor: 2024.06.2
-----------------------------------------------------------
 Please, share the above information when looking for help
 or support in, e.g., GitHub, forums or the Discord chat.
-----------------------------------------------------------
s6-rc: info: service base-addon-banner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service base-addon-timezone: starting
s6-rc: info: service base-addon-log-level: starting
s6-rc: info: service fix-attrs successfully started
[22:49:54] INFO: Configuring timezone (Europe/London)...
s6-rc: info: service base-addon-log-level successfully started
s6-rc: info: service base-addon-timezone successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
services-up: info: copying legacy longrun ha-spawn-point-bedrock (no readiness notification)
s6-rc: info: service legacy-services successfully started
Download URL 'https://minecraft.azureedge.net/bin-linux/bedrock-server-<IP_ADDRESS>.zip'
bedrock-server-<IP_ADDRESS>.zip already downloaded
bedrock-server-<IP_ADDRESS>.zip already Installed
Create Bedrock Server Configuration
Update allow-list with allow_list in ./server.properties
Update default-player-permission-level with default_player_permission_level in ./server.properties
Update difficulty with difficulty in ./server.properties
Update enable-lan-visibility with enable_lan_visibility in ./server.properties
Update gamemode with gamemode in ./server.properties
Update level-name with level_name in ./server.properties
Update max-players with max_players in ./server.properties
Update online-mode with online_mode in ./server.properties
Update server-name with server_name in ./server.properties
Creating allow List
Use Allow User List: False
Creating permission List
No Permission Update needed
Starting Bedrock Server
./run: line 103: ./bedrock-server-<IP_ADDRESS>: cannot execute binary file: Exec format error
[22:49:57] WARNING: Halt add-on with exit code 126
s6-rc: info: service legacy-services: stopping
s6-rc: info: service legacy-services successfully stopped
s6-rc: info: service legacy-cont-init: stopping
s6-rc: info: service legacy-cont-init successfully stopped
s6-rc: info: service fix-attrs: stopping
s6-rc: info: service base-addon-timezone: stopping
s6-rc: info: service base-addon-log-level: stopping
s6-rc: info: service fix-attrs successfully stopped
s6-rc: info: service base-addon-log-level successfully stopped
s6-rc: info: service base-addon-timezone successfully stopped
s6-rc: info: service base-addon-banner: stopping
s6-rc: info: service base-addon-banner successfully stopped
s6-rc: info: service s6rc-oneshot-runner: stopping
s6-rc: info: service s6rc-oneshot-runner successfully stopped

Looking at the code, it would appear that this one is using the official minecraft binaries, which would appear not to be aarm64 compatible.
I assume this is why the WilliamCorsel addons use the itzg images, for now we'll have to stick with those, despite seeming to fail to pass through the environment variables properly for some reason :/


Findings severities - No Informational?

Hi,
When looking to add findings, there are 4 severities (Low, Med, High, Crit). The documentation shows that there should be Informational, as well. The dashboard even looks like it will support it and there's references to informational in the code itself (in some cases, looks like it's accounted for). But, there's no way to add an informational finding (as far as I can tell)... Is there a way we can add informational findings? I attempted to change the severity in the admin section of an item... but it blew up the dashboard, so no dice there. Any help with this one?
Thanks

Hi @rkane-nm could you screenshot the error that occurred when you added the severity to the admin interface and share it here? I think I can push an easy fix.

Turns out that error wasn't a problem. It was because I typed in "Informational" instead of "Info". Once I changed it to "Info" it was fine. But is there a reason Informational isn't in the severity drop downs within the overall application?

Hi @rkane-nm I forget why it was removed originally. We still accept 'info' level severity for scanners, but it isn't exposed as an editable option. I think there was UI issues, but I can look into re-adding to the UI since it seems like there is value in having it.

Fixed: https://github.com/OWASP/django-DefectDojo/pull/405


add: serverless framework docs file

what: https://github.com/serverless/serverless/tree/main/docs
how: https://github.com/arc53/DocsGPT/wiki/How-to-train-on-other-documentation

https://github.com/arc53/DocsHUB/pull/5


ci: verify pyproject.toml file

We now have a GitHub action to lint changes on TOML files, most likely
pyproject.toml. This relies on the taplo
project which seems to have wide adoption. For example, the VSCode
extension (Even Better TOML) has over 1,707,199 installation and uses
taplo internally.
Two new make target have been added:

make toml-lint: will lint the pyproject.toml file
make toml-fmt: will format the pyproject.toml file

Closes: https://github.com/instructlab/instructlab/issues/1347
Signed-off-by: Sébastien Han<EMAIL_ADDRESS>Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the
conventional commits.
[ ] Changelog updated with breaking and/or notable changes for the next minor release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

Workflow error example.

Merging "manually" since I got two approvals, Mergify is not merging because e2e did not run, it's not worth rebasing and pushing to trigger it since this PR is not touching any py files. Thanks!


cmake script to generate ctest definitions from catch tests

#719
this is a cmake script which can be used for automatic CTest generating by parsing c++ sources for CATCH tests.
When you'd like to add CTest test you are usually doing this:
enable_testing()
add_test(...)
add_test(...)
Instead of the adding each test manually, I suggest to try using of this script which parses and adds found CATCH tests into cmake project
enable_testing()
include(ParseAndAddCatchTests)
ParseAndAddCatchTests(${PROJECT_NAME})
Notice 1: this script is a simplified version of Fraser999's scripts
Notice 2: this script doesn't replace and doesn't contain cmake commands for the adding CATCH lib into the project

I am going to test and merge it tomorrow.
In the meantime, if you don't mind, I am going to give you a bit of advice for better PRs. Seeing how this is a follow-up on the previous PR, you should note the reason for this one, but there is no need to copy verbatim the body of the previous one. IE, this one should be something along the lines of:

This is a followup for #879, where I added a CMake script that can parse out Catch TEST_CASEs and register them in ctest. However, it does not recognize TEST_CASE macros where the opening brace is on a separate line.
This PR fixes this.

and that is it.

In the meantime, if you don't mind, I am going to give you a bit of advice for better PRs.

thank you veyr much! I have a huge experience in enterprise development (with a tens or even hundreds of the branches but no PR technique)  but absolutely don't know the rules  of open source game. I'm glad an any advice here


[APIM 4.1.0] Problems Arising from Nested Schemas in API Product Creation

Description
Hi Team,
When an API product is created using a resource of an API that includes a nested schema (where one schema references another), the referenced schema is excluded from the API product’s definition, leading to an faulty API product definition.
Thanks,
Sameera
Affected Component
APIM
Version
4.1.0

The fix has been done via [1]. Hence, closing the issue.
[1] https://github.com/wso2/carbon-apimgt/pull/12694


Blog about building VS Code extension on App Center

This shouldn't be an issue here - it has nothing to do with the code.  I'll also remove the label and use the color for "help-wanted".


Nodes missing

First, this map is GREAT!
Second, I don't know what your source for the locations of the nodes are, but there are nodes missing, as far as I've found mostly in the NE part of the map.
Third, I'd be glad to contribute by giving you the positions of the missing ones I've found.
Fourth, There is quite a big and widespread mod called "refined power" that adds a node called "element 65" (if I'm not mistaken) and nodes for accessing streaming water for hydro-power. It would be really cool to add these as an option on your map too!
Great work anyways!!

This map hasn't been updated since Update 2. At the time of writing only https://satisfactory-calculator.com/en/interactive-map is up-to-date,


Update python3Packages.google*

Motivation for this change
Update Google Python bindings.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Me sitting here and wondering why the hell I compile stdenv and then I see it: Why is this targeting staging?!

Why is this targeting staging?!

It felt that this would trigger a massive rebuild in the first place. Looks like that older PR are indeed targeting master. Thanks for switching the target branch.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 133298 run on x86_64-linux 1

18 packages marked as broken and skipped:

python38Packages.arviz
python38Packages.dm-sonnet
python38Packages.graph_nets
python38Packages.optuna
python38Packages.pymc3
python38Packages.pywick
python38Packages.rl-coach
python38Packages.shap
python38Packages.skorch
python39Packages.arviz
python39Packages.dm-sonnet
python39Packages.graph_nets
python39Packages.optuna
python39Packages.pymc3
python39Packages.pywick
python39Packages.rl-coach
python39Packages.shap
python39Packages.skorch

19 packages failed to build and already failed to build on hydra master:

home-assistant: log was empty
python38Packages.gcsfs: log was empty
python38Packages.google-cloud-error-reporting: log was empty
python38Packages.google-cloud-logging: log was empty
python38Packages.pathy: log was empty
python38Packages.pytorch-metric-learning: log was empty
python38Packages.spacy: log was empty
python38Packages.spacy-transformers: log was empty
python38Packages.textacy: log was empty
python39Packages.gcsfs: log was empty
python39Packages.google-cloud-bigquery: log was empty
python39Packages.google-cloud-error-reporting: log was empty
python39Packages.google-cloud-logging: log was empty
python39Packages.pathy: log was empty
python39Packages.pytorch-metric-learning: log was empty
python39Packages.spacy: log was empty
python39Packages.spacy-transformers: log was empty
python39Packages.textacy: log was empty
s3ql: log was empty

21 packages failed to build and are new build failures:

dvc-with-remotes: log was empty
python38Packages.baselines: log was empty
python38Packages.edward: log was empty
python38Packages.gensim: log was empty
python38Packages.google-cloud-automl: log was empty
python38Packages.google-cloud-bigquery: log was empty
python38Packages.google-cloud-resource-manager: log was empty
python38Packages.google-cloud-storage: log was empty
python38Packages.ignite: log was empty
python38Packages.mask-rcnn: log was empty
python38Packages.scikit-tda: log was empty
python38Packages.smart-open: log was empty
python38Packages.tflearn: log was empty
python38Packages.umap-learn: log was empty
python39Packages.gensim: log was empty
python39Packages.google-cloud-automl: log was empty
python39Packages.google-cloud-resource-manager: log was empty
python39Packages.google-cloud-storage: log was empty
python39Packages.ignite: log was empty
python39Packages.smart-open: log was empty
snakemake: log was empty

150 packages built:

beancount (python39Packages.beancount)
deja-dup
duplicity
duply
fava
gcalcli
git-annex-remote-googledrive
gpt2tc
kmymoney
ledger2beancount
lieer
privacyidea
python38Packages.beancount
python38Packages.beancount_docverif
python38Packages.chirpstack-api
python38Packages.cirq
python38Packages.cirq-google
python38Packages.drivelib
python38Packages.goobook
python38Packages.google-api-core
python38Packages.google-api-python-client
python38Packages.google-auth
python38Packages.google-auth-httplib2
python38Packages.google-auth-oauthlib
python38Packages.google-cloud-access-context-manager
python38Packages.google-cloud-appengine-logging
python38Packages.google-cloud-asset
python38Packages.google-cloud-bigquery-datatransfer
python38Packages.google-cloud-bigquery-logging
python38Packages.google-cloud-bigtable
python38Packages.google-cloud-container
python38Packages.google-cloud-core
python38Packages.google-cloud-dataproc
python38Packages.google-cloud-datastore
python38Packages.google-cloud-dlp
python38Packages.google-cloud-dns
python38Packages.google-cloud-firestore
python38Packages.google-cloud-iam
python38Packages.google-cloud-iam-logging
python38Packages.google-cloud-iot
python38Packages.google-cloud-kms
python38Packages.google-cloud-language
python38Packages.google-cloud-monitoring
python38Packages.google-cloud-org-policy
python38Packages.google-cloud-os-config
python38Packages.google-cloud-pubsub
python38Packages.google-cloud-redis
python38Packages.google-cloud-runtimeconfig
python38Packages.google-cloud-secret-manager
python38Packages.google-cloud-securitycenter
python38Packages.google-cloud-spanner
python38Packages.google-cloud-speech
python38Packages.google-cloud-tasks
python38Packages.google-cloud-testutils
python38Packages.google-cloud-texttospeech
python38Packages.google-cloud-trace
python38Packages.google-cloud-translate
python38Packages.google-cloud-videointelligence
python38Packages.google-cloud-vision
python38Packages.google-cloud-websecurityscanner
python38Packages.google-resumable-media
python38Packages.gspread
python38Packages.kubernetes
python38Packages.oauthenticator
python38Packages.openshift
python38Packages.proto-plus
python38Packages.pydrive
python38Packages.pyro-ppl
python38Packages.pytorch (python38Packages.pytorchWithoutCuda)
python38Packages.pytorch-lightning
python38Packages.rising
python38Packages.slicer
python38Packages.tensorboardx
python38Packages.test-tube
python38Packages.torchgpipe
python38Packages.torchvision
python38Packages.weboob
python38Packages.woob
python39Packages.baselines
python39Packages.beancount_docverif
python39Packages.chirpstack-api
python39Packages.cirq
python39Packages.cirq-google
python39Packages.drivelib
python39Packages.edward
python39Packages.goobook
python39Packages.google-api-core
python39Packages.google-api-python-client
python39Packages.google-auth
python39Packages.google-auth-httplib2
python39Packages.google-auth-oauthlib
python39Packages.google-cloud-access-context-manager
python39Packages.google-cloud-appengine-logging
python39Packages.google-cloud-asset
python39Packages.google-cloud-bigquery-datatransfer
python39Packages.google-cloud-bigquery-logging
python39Packages.google-cloud-bigtable
python39Packages.google-cloud-container
python39Packages.google-cloud-core
python39Packages.google-cloud-dataproc
python39Packages.google-cloud-datastore
python39Packages.google-cloud-dlp
python39Packages.google-cloud-dns
python39Packages.google-cloud-firestore
python39Packages.google-cloud-iam
python39Packages.google-cloud-iam-logging
python39Packages.google-cloud-iot
python39Packages.google-cloud-kms
python39Packages.google-cloud-language
python39Packages.google-cloud-monitoring
python39Packages.google-cloud-org-policy
python39Packages.google-cloud-os-config
python39Packages.google-cloud-pubsub
python39Packages.google-cloud-redis
python39Packages.google-cloud-runtimeconfig
python39Packages.google-cloud-secret-manager
python39Packages.google-cloud-securitycenter
python39Packages.google-cloud-spanner
python39Packages.google-cloud-speech
python39Packages.google-cloud-tasks
python39Packages.google-cloud-testutils
python39Packages.google-cloud-texttospeech
python39Packages.google-cloud-trace
python39Packages.google-cloud-translate
python39Packages.google-cloud-videointelligence
python39Packages.google-cloud-vision
python39Packages.google-cloud-websecurityscanner
python39Packages.google-resumable-media
python39Packages.gspread
python39Packages.kubernetes
python39Packages.mask-rcnn
python39Packages.oauthenticator
python39Packages.openshift
python39Packages.proto-plus
python39Packages.pydrive
python39Packages.pyro-ppl
python39Packages.pytorch (python39Packages.pytorchWithoutCuda)
python39Packages.pytorch-lightning
python39Packages.rising
python39Packages.scikit-tda
python39Packages.slicer
python39Packages.tensorboardx
python39Packages.test-tube
python39Packages.tflearn
python39Packages.torchgpipe
python39Packages.torchvision
python39Packages.umap-learn
python39Packages.weboob
python39Packages.woob
tts


Vuetable-2 not waiting for API response

Hi @ratiw
I have implemeted vue table 2 and used transformation to format data as required.
it works fine but when my API response it delayed (for any reason),
vuetable does not wait and shows no  records available as API response is pending.
However when API response comes, it renders that but one of rows also shows no data available.
Please see the attached snapshots.

Please have a look and let me know what I am supposed to do ?
Thanks
Anit

To add to above question,
if i decide to go with api-mode=false and then setting data and pagination properties accordingly,
how would sorting works in that case ?
How can i get what column user clicked and the current direction so that can be to sort data. ?

@anit05 For the first question, it's better that you set up a sample project on jsfiddle or codepen that will exhibit the behavior you mentioned; otherwise, it's hard for me to see what went wrong.
For the second question, in Data mode (:api-mode="false"), you will be responsible for data manipulation (including sorting) via dataManager method. Vuetable is only responsible for displaying them. Please see the example in this codepen.

Thanks @ratiw
I will look at whether i can setup a sample for you to look at.
Secondly, for data-mode, in dataManager method , i am calling an API to get data as per current page and page size . However, it does not wait for my API response , rather it returns
here is the sample code :
dataManager(sortOrder, pagination) {
var url = apiUrl;
        var returnResponse = {};
        //pagination = this.$refs.vuetable.makePagination(data.length)
        //var returnResponse = {
        //    pagination: pagination,
        //    data: data
        //};
        //return returnResponse;
        this.$http.get(url).then(response => {
            // get body data
            console.log('first data');
            return response.body
        }, response => {
            // error callback
        }).then(dataObject => {
            var responseData = this.transformData(dataObject);

// transformData transforms data in format required by vuetable-2
let data = responseData.data;
pagination = this.$refs.vuetable.makePagination(2)
var returnResponse = {
pagination: pagination,
data: data
};
return returnResponse;
}, data => {
// error callback
})
console.log(returnResponse);
return returnResponse;
    }

The problem is that returnResponse is returned empty.
can you please look at what i need to do for this case ?
Thanks

To add to this,
since http requests are asynchronous  and data-manager works with synchronous requests.
so what to do for getting around this ?
Thanks

I'm running with the same thing. altho I "solve it" with a watch like.
    watch: {
      // @todo: find a workaround to avoid a watcher in the data list.
      artworkDataList (newVal, oldVal) {
        this.$refs.vuetable.refresh()
      }
    },

Still it feels a bit wrong to do this, there's another solution to ascynchronous data ??

@anit05 Sorry, I've so busy that I forgot about your question. It was the comment fro @killua99 that actually brought me back to this.
Anyway, after seeing the above code I was wondering why are you calling the API yourself since Vuetable is created to work with asynchronous data from the beginning. It even provides a transform function to allow it to work with almost any API.

@ratiw hi, passed by here. I am using Apollo Graphql and wanted to use it together with Vutable2 beta.
But looks like dataManager does not support working with promises. And direct connection of the api to graphql does not seem to be possible.

@bochkovyi I could say that I'm familiar with Promise concept, but I'm not quite sure about making dataManager supporting promises? Could you please suggest the scenario on how it would be to make dataManager support promises? Or even making Vuetable-2 able to work with graphql in API mode? I really don't know much about graphql. Any advice and/or suggestion would really be appreciated.

@ratiw thanks for your reply:)
OK, let's look here: https://github.com/ratiw/vuetable-2/blob/next/src/components/Vuetable.vue#L989

looks like on line 992 we already check if this.data is an Array and assign it. Therefore, no need to additionally make an attempt of assigning it on line 1000.
return message on line 997 is also not needed because callDataManager is not expected to return anything.

If we remove that part, we can rewrite lines 997 - 1001 like this:
  const result = this.dataManager(this.sortOrder, this.makePagination());
  // when method returns promise, the result is of type "function"
  if (typeof result === 'function') {
    result.then(data => this.setData(data))
  } else {
    this.setData(result)
  }

i did not test it though, i found another workaround - I do assign data directly from dataManager.
async dataManager(sortOrder, pagination) {
const server_response = await graphQlCall(...)
...
this.$refs.vuetable.setData({
pagination: pagination,
data: server_response
});
}
I am also in the middle of testing.
I used your example from beta page.
I also had to remove the watch(... this.$refs.vuetable.refresh() ) because it seem to have caused infinite loops together with my approach.
and regarding your question about graphql integration with request API - I can't really recommend anything better then writing to the Apollo team. I think they will contribute to your project.
It's really awesome and generally very easy to use!

@ratiw please check my reply above I edited it in this part.
typeof result === "object" && typeof result.then === "function"
I've tested this in such a way: hijacked the this.$refs.vuetable.callDataManager in the mounted hook of my component and placed the above snippet. It really works:) But not from page load, so I had to trigger sorting buttons to actually refresh it. Anyway, I am using the solution with setData now. Please check this fix and apply it, so I can use the correct way:)

@ratiw
thanks for mentioning!
I tried to yarn upgrade, but looks like it works only when the package version changes...
And even sudo rm -rf node-modules did not help.
How can I fetch your latest updates?:)

@bochkovyi I think the easiest way is to fork from the next branch of this repo and use the fork in your app and test it.


[add-resource] New Plugin/Theme

I would like to add my new plugin/theme to the Grav Repository.
Here are the project details: https://github.com/philippspinnler/grav-theme-minimalist
I hope it meets the requirements.

You need to do a release for it to show up in the the repo.

done :)


Remove need to call directly into libcontainer

I'd like containerd to completely stop depending on libcontainer to get data (and thus fully support different runtime implementations
We currently depends on loading data via libcontainer for the following cases:

[ ] Update container resources (e.g. alter cgroup values)
[x] Retrieve a list of container processes (can now be achieved by runc ps --format=json thanks to https://github.com/opencontainers/runc/pull/779) -> #221
[x] Retrieve container statistics (can be achieved through runc event --stats thanks to https://github.com/opencontainers/runc/pull/780) -> #221
[ ] Get notified on OOM (atm, I can only think of having a pre-start hook to synchronize with the starting container). Note: This would fix #188

Great to see this, but can we create a new API for runc , the runc events --stats is not that clear than runc stats. The events commands is more like a channel to keep receiving and showing events of a containers, such as "pause", "resume", "exit", etc.

It seems the "ctr contaienrs update" has the same issue?

For the runc events --stats this should be made an issue on https://github.com/opencontainers/runc if you feel strongly about it :)
As for ctr containers update, it doesn't have the same issue per se, as it just forward the request to containerd which then takes care of it.

@mlaventure not that strong, just wonder if we need to keep it consistent-the events from docker/containerd and the events from opencontainers/runc.


Proper way to add text in the center of Navbar reactstrap?

I built a menu bar using reactstrap Navbar. I am trying to add text (please refer to the the red rectangle portion in the attached screenshot) in the center of the menu bar, but could not make it.

I was just wondering what is the proper way to add text in the middle of the Navbar? Any suggestions would be greatly appreciated.

Not really specific to reactstrap. Check out bootstrap's response to a similar issue: https://github.com/twbs/bootstrap/issues/27676

This is a limitation of CSS—flexbox cannot inherently do what you want it to do without setting fixed widths on the first and last items (assuming three items). Absolute positioning is another option. So is grid layout, depending on your browser audience's intended support.

@TheSharpieOne Thank you for your information. I am going to close this issue.


Phalcon.so not found for runtime:php

When deploying with runtime: php in app.yaml with extension=phalcon.so in php.ini, I get this error in kaniko-project:
PHP Warning: PHP Startup: Unable to load dynamic library 'phalcon.so' (tried: /opt/php72/lib/x86_64-linux-gnu/extensions/no-debug-non-zts-20170718/phalcon.so (/opt/php72/lib/x86_64-linux-gnu/extensions/no-debug-non-zts-20170718/phalcon.so: cannot open shared object file: No such file or directory), /opt/php72/lib/x86_64-linux-gnu/extensions/no-debug-non-zts-20170718/phalcon.so.so (/opt/php72/lib/x86_64-linux-gnu/extensions/no-debug-non-zts-20170718/phalcon.so.so: cannot open shared object file: No such file or directory)) in Unknown on line 0
Other than that, when deploying as runtime: custom, phalcon seems to be working; but would be nice to have deployment works for runtime: php;

@sharifelgamal are you still around on this project? I'm wondering if this repo has a direct line to the GAE php runtime or if there's some sort of internal cherry-picking process?

The GAE runtime for php is produced entirely from internal code and process
and is unrelated to this repo.
On Wed, Aug 21, 2019, 10:16 PM Daniel Holmes<EMAIL_ADDRESS>wrote:

@sharifelgamal https://github.com/sharifelgamal are you still around on
this project? I'm wondering if this repo has a direct line to the GAE php
runtime or if there's some sort of internal cherry-picking process?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/php-docker/issues/481?email_source=notifications&email_token=AAF76UTRTBIR4KV6OEYJMTDQFYOLBA5CNFSM4HVGAZ3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD435ASQ#issuecomment-523751498,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAF76USUWYYNNOOKTQXPVN3QFYOLBANCNFSM4HVGAZ3A
.

Thanks @donmccasland. I was under the impression from the previous maintainers that the runtime: php system used a docker image based on this repo

@donmccasland I just realised where I got my assumption from. The documentation states explicitly:

This image is intended to use with runtime: php configuration. The image is uploaded to gcr.io/google-appengine/php:latest.

So I don't think that's correct.

Yes, this image produced by this repo gets published up to
gcr.io/google-appengine/php:latest, but this image is still only for users
of AppEngine Flex or users producing custom images like this:
https://cloud.google.com/appengine/docs/flexible/php/testing-and-deploying-your-app
-don
On Sun, Aug 25, 2019 at 5:02 PM Daniel Holmes<EMAIL_ADDRESS>wrote:

@donmccasland https://github.com/donmccasland I just realised where I
got my assumption from. The documentation states explicitly:
This image is intended to use with runtime: php configuration. The image
is uploaded to gcr.io/google-appengine/php:latest.
So I don't think that's correct.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/php-docker/issues/481?email_source=notifications&email_token=AAF76UWL3LKINFROAAE25SDQGMMQJA5CNFSM4HVGAZ3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5C6TRQ#issuecomment-524675526,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAF76UV263WG7FVEZSC4DQTQGMMQJANCNFSM4HVGAZ3A
.

--
*Have build/release/devinfra questions?  *
Join us on Google Chat in the Nest Devinfra Chat
https://chat.google.com/room/AAAAZjVzpI4


How-to recipes: Using a Node server and deploying on heroku

Hey folks,
Thanks for create-react-app! I'm new to the world of React and overall I've had a breeze getting set up. I'm a bit puzzled on deployment still, so I thought I'd open an issue to clarify these instructions in the How-to recipes section as suggested here.
Summary:

I have followed Deployment on Heroku and successfully deployed a backendless React app on Heroku.
I have followed Integrating with a node backend and got it the client and server working together locally.

But I can't get 1 and 2 working together, i.e. a react client + node server working on a single Heroku app.
Github repo that repros the issue:

https://github.com/vrk/food-lookup-demo
This is a clone of the Integrating with a node backend example with a few changes to get it to partially work on Heroku, explained in detail in the README.

Questions:

I realize that I could deploy 2 separate Heroku apps, one for client and one for  server and do the CORS dance to get them to talk to each other. Is that what people usually do for deploying? If so, what's the point of these instructions if you can't actually deploy with that setup?
Assuming that there is a way to get a node server and client server working on one Heroku app: Here's my github repo I'm trying to deploy: https://github.com/vrk/food-lookup-demo Can someone take a look at the repro instructions and see if I'm approaching this the wrong way?

Would appreciate any help. Thanks!

Hello, @vrk!
Basically this tutorial is based on the idea, that you open two different ports on the same instance.
So, it's ok when you doing this on your local machine or VPS, but it will not work with heroku, where dyno give you possibility expose only one port to outside world and map it to <app_name>.herokuapp.com:80.
So, if you want to use heroku for hosting react app and backend, I guess, you will need two separate apps, so it's Option 1 from your question.
Also there is workaround, you can serve your react app dist directory from node server using express.static, for example, and than the whole app will be served on the same port.

Oh awesome! Thanks for the fast reply. I'll give that express.static thing a try in the next day or two and will report back!

Well that went a lot faster that I thought. Thank you, got it working now! That's just what I needed to know.
For posterity in case someone else comes across this issue, what I did was the following:

Add app.use(express.static(path.join(__dirname, 'client/build'))); to my server.js
Update the server package.json to include "install": "cd client && npm run build && cd .." under "scripts"
(for the food-lookup-demo) Get rid of the foreman stuff (no Procfile or anything)
(for the food-lookup-demo) Change process.env.API_PORT to process.env.PORT of course

I'm trying to decide if there's a tutorial I can contribute to the User Guide section of this project , maybe simply an addendum to the Integrating with a Node Backend section that explains the changes needed if someone wants to deploy that to Heroku. I'll keep this open for now for this reason.

@vrk Can you please update your fork of food-lookup-demo to include what you did to get it properly deployed on Heroku? I followed the steps in your fork as well as what you said in this comment and I still can't access the api dyno. I get 500 Internal Server Error.
Thanks!

Maybe worth including this into that guide?
cc @acco

@CaliAlec Awesome, glad you got it working!
@gaearon / @acco One thing that wasn't obvious to me until now: the fact that you don't have to/shouldn't run a server for your React apps made through create-react-app, and that the server business is strictly for debugging.
I think it'd be helpful to mention that more clearly in the following places:

npm start: Add a line at the end of the section that's like "Note: In development mode, react-scripts launch a webpack dev server, which is what is running on http://localhost:3000. This server is only used for development and you should not have to run this server for production. When you're ready to deploy, build your app into a single static web page via npm run build instead."
npm run build: Add something that says "Your React app can now be served as a static web page via the build/ directory"
Integrating with a node backend: Emphasize that these instructions only make sense for development and not deployment: you don't have to have Node backend running on a different port for deployment. To deploy with a node backend, you would follow a pretty different set of instructions, i.e. something that involves "npm run build" and exposing this build directory on your node server.
Deployment: I would add one sentence at the top of this section "npm run build" again, like "In general, deploy via 'npm run build'

Feel free to do what you want with those suggestions, including ignore them :) I'm also happy to help with a PR for README.md.

@gaearon Good idea, time has come to add a Heroku/deployments section to the post.
@vrk Thanks for starting this discussion and for all the info! There are two main approaches developers will take here. The first is along the lines that you took — have your node server serve your static assets (the result of npm run build). In that scenario, as you illustrated, you would have to have pretty different setups between development and production.
However, the production deployment we had in mind was a little different. You can use npm run build to generate your static bundle and then toss that onto any static asset server, like S3. Then, you'd deploy your Node/API server to a service like Heroku. example.com would point to index.html on S3 and then the React app would make API requests to something like api.example.comwhich refers to Heroku. This is more of a "pure" separation of client and server and would mean that the setup for production is closer to that of development.
Some hurdles that come to mind with that approach: Handling CORS if you don't have a domain name (using Heroku free tier) and making the dual target deployment strategy palatable. In any case, I'll drop a note here when we've expanded our post to include deployments.

@acco I think a lot of quick (small) projects probably don't bother with a static asset server split from the app server. Especially if you're going to deploy to some fast PaaS setup. Furthermore, handling multiple server processes just makes everything much more complicated if you're going to run things through an end-to-end test or something.
So, I sorta think supporting a single app server that handles client + server is a better developer experience even if in a more disciplined prod deployment, most people would want to get a static app server up and going.
With that in mind, what about making react-scripts expose a middleware that's analogous to react-scripts start?
The method suggested here https://www.fullstackreact.com/articles/using-create-react-app-with-a-server/ (which is linked from your docs) where you create a nested node.js feels more complicated than necessary. I bet it also would break a lot of auto-detect code in common infrastructure like Travis CI and its default recipes. For example, Travis CI's caching documentation for node.js suggests manually specifying the node_modules directory for cache. With the nested package setup, you'll never cache the client node_modules.
If instead we exported a middleware, similar to how WebpackDevServer exports one in addition to the CLI version, you can just use() it from express.
I imagine a pseudo code looking something like:
const express = require('express');
const reactScripts = require('react-scripts');

app.use('/', reactScripts.createClientRouter());
app.use('/api', myapi_router);

Followed by a modification to package.json so that start no longer directly calls react-scripts start.
This way a fullstack eng could hook into the react-scripts environment programmatically without breaking hermeticity.

I don’t think we’re at the point where we’re ready to expose any APIs from react-scripts yet.

@gaearon understood about the dangers with that, but:
(a) this is a fairly narrow API since the semantics are just "mount the equiv of react start on this path"
(b) without it, you have a fairly common use case (monolithic server that combines api + asset serving) that requires some moderately complicated workarounds, or ejecting.
I feel like it might be worth considering bumping the priority a bit.

Thanks for all the info and replies!
@acco: Makes sense. Thanks, and looking forward to seeing what you come up with!

(b) without it, you have a fairly common use case (monolithic server that combines api + asset serving) that requires some moderately complicated workarounds, or ejecting.

My drive-by opinion: I agree with @awong-dev. Recommending a deployment solution that would involve 2 Heroku instances (or S3/Heroku combo, or some other pure separation) seems to go slightly against the "simple setup!" spirit of create-react-app. It seems it'd be nice if you could support a way for create-react-app to work harmoniously on a simple monolithic server. (But of course, these things are super easy for me to say as a drive-by observer of this project 😜 )

Hey @awong-dev @vrk —
Thanks for the thoughts!
Totally valid points. I do think it would be great if a developer could avoid working with both S3 and Heroku to deploy a create-react-app app. S3/credentials/s3cmd are all a pain to setup for the first time. There is a Heroku integration that alleviates most of this (Bucketeer) but it's not free.
For a simple, free, one-dyno setup, having your "API" server also serve static assets is the only option (as @vrk highlighted). So it just means there will be some divergence between the setup of your app in development vs production. (You could close this divergence by having your Node+Express server proxy requests to Webpack in development (as opposed to the other way around) but I need to think through if this is more or less confusing.)
In any case, I'll compose examples for each of these scenarios and see what will be reasonable to suggest. Hopefully next week. I'll comment here when I have something

@acco Hi have you come up with anything that works now?

Hi @crazyyi Thanks for pinging me :) Full intention to do this still. I'll post here when I make time for it

Hey all — Thanks for your patience!
I pushed a solution along with a quick write-up to food-lookup-demo. Per my earlier comment, this solution uses the free "one-dyno" solution. We have Node+Express (server.js) serve both the API and the static bundle (client/build) in production.
I still need to write the blog post that builds off the previous one, describing the steps for readying that repo for deployment. In the meantime, the diff is highly informative. Notably:

We have separate start scripts for production and development (start and run dev, respectively).
We have separate Procfiles for production and development.
We check client/build into git (so we can push it to Heroku).
We have Express serve static assets in production.

Outside of that, I just did some juggling with the PORT environment variable to make everything work OK with Heroku.
Hope this helps!

@acco Is there any reason why you have decided to run the server in production with babel-node? Babel docs recommends against this.

@faurehu There isn't other than to keep things simple :) Indeed, transpiling server.js with babel before deploying would be better for a real production app

Another, IMHO easier way to make this deployable on heroku without buildpack.

heroku create
Make heroku install dev dependenciesheroku config:set NPM_CONFIG_PRODUCTION=false
Add simple dev server npm install express --save + create simple server.js static server, like this one: https://github.com/heroku/node-js-getting-started/blob/master/index.js
Add Procfile for herokuecho 'web: node server.js' > Procfile
Add this postinstall script script to npm scripts: `"postinstall" : "npm run build","
git push heroku master  !Profit!

@jkarttunen thanks for that. Rather than setting PRODUCTION to false, I added react-scripts to dependencies (not dev) and that seems to work too.

For folks still looking to run reactjs and express together on heroku, I wrote this article that covers how we are doing it at the moment.
https://originmaster.com/running-create-react-app-and-express-crae-on-heroku-c39a39fe7851#.j95kab51f

For anyone considering deployment on Heroku with separate instances for server and client and using cookies, keep in mind that herokuapp.com is on the public suffix list meaning that you can't pass cookies directly between two Heroku instances:
https://devcenter.heroku.com/articles/cookies-and-herokuapp-com

Is there anything actionable for us in this issue? Perhaps, somebody would like to add something to the Heroku deployment section in User Guide?

Hello @acco !
After being at this for hours, and looking at several different implementations,  your's actually worked! Particularly in removing "/build" from the .gitignore file as per your food-lookup-demo, I'm able to run the build process in my dev environment and just push the entire build folder to Heroku (and not to mention my git repo).
Since it's been about 7 months since you posted that implementation (and things move so fast in the react community :-) ), do you still use this implementation or has your perspective changed on this? Is it still good practice to remove "/build" from the .gitignore in the interest of preserving simplicity when deploying to Heroku?
Let me know.

hey guys, looking through this I'm still struggling a bit to run it the way I need:

client + server.js hosted on heroku, which makes request to:
a separate api server.js also hosted on heroku
Particularly, I want my client-server to make requests for user data to my api-server on all routes. Is this possible..?

If anyone is trying to figure out how to do this with a Rails backend, I suggest checking out this blog post: ReactJS + Ruby on Rails API + Heroku App
Seems like the Rails version of this has been neglected. 😞 Maybe a deployment section can also be added to the blog post and readme for others to find.


Unstable GPS data while using the 2nd telemetry on TELEM2 port - v1.11.0-beta1

Describe the bug
Hi, I found very strange GPS behavior after uploaded "v1.11.0-beta1" to pixhawk 4. Firstly, I configured MAV_1_CONFIG = TELEM2 (My UAV has been flown using this config. before since firmware v1.8.2, v1.9.2 and v1.10.2 and I got no error). Then, I investigated using"mavlink inspector" in QGC and take a look at GPS_RAW_INT.
GPS signal seems unstable, the fluctuation ranges from 0 to 5 Hz. It should be a constant value or nearly constant (compared with an older firmware, I have already tested before).
Finally, the result is the flight mode could not be changed from ALTITUDE to POSITION, No Green GPS LED light visible. I managed the test as follows
To Reproduce / Test Case
Case 1: v1.11.0-beta1 --> OK
MAV_1_CONFIG = Disabled
https://review.px4.io/plot_app?log=9764baca-ec06-40aa-b1ba-79719d0b75fc
Case 2: v1.11.0-beta1 --> Error / ubx msg warning
MAV_1_CONFIG = TELEM2
https://review.px4.io/plot_app?log=a670c429-592e-4e52-a200-b811bd45f14d
Case 3: v1.11.0-beta1 --> OK
MAV_1_CONFIG = TELEM/SERIAL4
https://review.px4.io/plot_app?log=98b8c1ec-d492-48b5-823a-870af29e5686
Case 4:  v1.11.0-beta1 --> Error / ubx msg warning
MAV_2_CONFIG =  TELEM2
Case 5: v1.11.0-beta1 --> OK
MAV_2_CONFIG =  TELEM/SERIAL4
Case 6: v1.11.0-beta1 --> Error / ubx msg warning
MAV_1_CONFIG = TELEM/SERIAL4
MAV_2_CONFIG =  TELEM2
Case 7: v1.10.1 --> OK (compare to Case 2 v1.11.0-beta1. It is not the same result even config. is the same)
MAV_1_CONFIG = TELEM2
https://review.px4.io/plot_app?log=29bea816-da9d-4cd4-b042-c0fdb14e489d
The error is the same whether telemetry is available on that port or not, indoor or outdoor if I configure MAV_X_CONFIG to TELEM2. According to the flight log of Case 2, you will see the strange GPS behavior at "GPS Uncertainty and GPS Noise & Jamming". In every test case, Telemetry works fine.
However, GPS works fine if I upload the older firmware "v1.10.1" (v1.8.2 / v1.9.2 is the same) Is it firmware bug ? or Did I miss anything?
Drone (please complete the following information):

Describe the type of drone: Tiltrotor using E-flite Convergence airframe
Hardware: Pixhawk4 + GPS pixhawk 4 + Holybro telemetry

Thanks for the detailed report. I can reproduce this, also on master.

Pixhawk 4 with GPS attached
param set MAV_1_CONFIG 102
param set SER_TEL2_BAUD 57600

The problem goes away when disabling TX DMA (CONFIG_USART3_TXDMA) on Telem2. @davids5 can you have a look?

Thanks for reporting @saengphet

Another report: https://logs.px4.io/plot_app?log=1c41e67f-696b-4b76-a669-cf4cd42330b0
MAV_1_CONFIG, 102
SER_TEL2_BAUD, 38400

I have Isolated the problem and will have a fix in next week.

Please re-test with https://github.com/PX4/Firmware/pull/15528


custom vue components

Hi, is it possible to specify custom vue components in the markdown file that will be rendered afterwards? e.g. <my-button>Hi</my-button> will then become Hi as html element

Hi, is it possible to specify custom vue components in the markdown file that will be rendered afterwards? e.g. <my-button>Hi</my-button> will then become Hi as html element

Sorry I didn't get to you earlier, been lost in other projects tbh. You won't be able to do that from the posts .md files but you could technically define minimal components within vue3-md-blog/src/components as MyCustomButton.md as long as they don't need any kind of setup or js logic in general.


chore(release): 26.5.6

Pull Request Test Coverage Report for Build 813533417

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.936%

Totals

Change from base Build 813511041:
0.0%

Covered Lines:
1004

Relevant Lines:
1034

💛  - Coveralls


Minor fixes

The matroska crate update makes the builder fail because Rust 1.70 is not deployed on Github's bots yet, but that should be very temporary. Merged everything except standardize flush() for now because I am not sure why we should wait for a keyframe after every flush - while I agree we typically will only do that at the end of a stream, is there a reason to enforce that?

@Gnurou

Merged everything except standardize flush() for now because I am not sure why we should wait for a keyframe after every flush - while I agree we typically will only do that at the end of a stream, is there a reason to enforce that?

This is based on the GStreamer design.
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/main/subprojects/gst-plugins-bad/gst-libs/gst/codecs/gsth264decoder.c#L487
Notice how the DPB is drained and then cleared. You can't resume decoding after that, you must wait for a sync point. The only reason why we do not crash is because we happen to call that only at the end of decoding in ccdec. Client code can theoretically call this whenever they want though.
Note the VP9 version, which calls gst_vp9_decoder_reset, which is https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/main/subprojects/gst-plugins-bad/gst-libs/gst/codecs/gstvp9decoder.c#L300
^ Again, must wait for a sync point
Same for VP8 -> https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/main/subprojects/gst-plugins-bad/gst-libs/gst/codecs/gstvp8decoder.c#L331

I see, thanks for clarifying. Indeed if we clear the DPB there is no way for us to resume decoding after that.
I am wondering how this works with something like a e.g. video editor that would send a few frames to decode, call flush() to get sure it gets the work it sent fast, and then sent some more P frames to decode what follows. Maybe I am misunderstand how such tools work and maybe they simply decode whole recoverable sets and keep the frames around to display as needed.
In any case we definitely don't want to crash after a flush, so merging this CL!


Win10 doesn't like std::max

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

10:1 defining NOMINMAX before including <windows.h> will also solve this.

10:1 defining NOMINMAX before including <windows.h> will also solve this.

iirc this particular projects builds spirv-cross by including every cpp into a big translation unit, so that would pollute things.


Airplay casting on tvOS

Description
I want to know if there is a way of checking from the tvOS side if someone is casting via airplay. I'm using this library https://github.com/disjfa/react-native-airplay-btn for casting from the mobile app side to the tvOS device I have, but now I want to do the other way around (checking is someone is already connected to the tvOS).
I'm doing some pocs by adding that library to my tvOS app but I'm not sure how to check if it works (as I cannot cast to the simulator).
Thank you very much,
Eric.

I have looked around, and the only examples I have found are those which check the other way (the iOS device can see if it is casting to the Apple TV).


feat(Mathlib/Tactic/Basic): add triv tactic

My first tactic, please check carefully!
mathlib3 tactic is https://github.com/leanprover-community/mathlib/blob/903e8941f0862f6c34f28babbb607842a7f8a6c7/src/tactic/interactive.lean#L663

According to the mathlib3 documentation, triv differs from trivial in that it does not try to apply contradiction. So doesn't this need to avoid that scenario too?

@kbuzzard, it's easier for everyone if you make PRs direct from the leanprover-community repository. (I've just merged master for you.)

@semorrison That's my fault, I told Kevin that it was fine to make PRs from a fork like in other github projects. It's not entirely clear to me whether we need to also be following the mathlib contribution strategy with the new CI setup.

@semorrison That's my fault, I told Kevin that it was fine to make PRs from a fork like in other github projects. It's not entirely clear to me whether we need to also be following the mathlib contribution strategy with the new CI setup.

No problem. It was just a few extra steps for me to merge master into this to resolve a conflict.

We still have a conflict :-(

bors r+