Add-linting-black-mypy

You can check the related part of CI here

Hey importing 'from future import annotations' allows to use list[str] instead of List[str] in Python versions <3.9.
With this we can also use | instead of Union in Python versions <3.10.
Read more about it here:
https://docs.astral.sh/ruff/rules/future-rewritable-type-annotation/

Thank you for this.

@dinjazelena - the unit tests are failing for Spark 2.4.8: https://github.com/MrPowers/quinn/actions/runs/6444181927/job/17496859733. You know how to fix these?

We should put mkdocs in a separate dependency group

@MrPowers , hey, yeah, this is dependency issue, so no worries. Will fix it today.


Rearranged package structure to more standard form

Changes:

script is no longer part of the library, but in the seperate scripts
directory
library is now packaged as google/init.py. The old packaging
layout sometimes caused issues with setuptools, resulting in
"TypeError: ('Not a package:', 'google')
when trying to import any package

Thanks! I had never tried using is as a dependency with setuptools so I never noticed the problem. (In fact when I used it myself I never installed it as a package at all, just dumped the .py somewhere and ran it from command line).

Could you do a pypi release, as this isnt actually fixed until setuptools can download and install the 'google' dependency that doesnt have this bug.

I think I'll have to work a bit more on it, I just tried the following and this happened:
Mario@Mario-PC ~/google
$ python setup.py --help
Downloading https://pypi.python.org/packages/source/s/setuptools/setuptools-0.9.6.tar.gz
Extracting in /tmp/tmp5lWRMe
Now working in /tmp/tmp5lWRMe/setuptools-0.9.6
Building a Setuptools egg in /home/Mario/google
/home/Mario/google/setuptools-0.9.6-py2.7.egg
Common commands: (see '--help-commands' for more)

  setup.py build      will build the package underneath 'build/'
  setup.py install    will install the package

Global options:
  --verbose (-v)      run verbosely (default)
  --quiet (-q)        run quietly (turns verbosity off)
  --dry-run (-n)      don't actually do anything
  --help (-h)         show detailed help message
  --no-user-cfg       ignore pydistutils.cfg in your home directory
  --command-packages  list of packages that provide distutils commands

Information display options (just display information, ignore any commands)
  --help-commands     list all available commands
  --name              print package name
  --version (-V)      print package version
  --fullname          print <package name>-<version>
  --author            print the author's name
  --author-email      print the author's email address
  --maintainer        print the maintainer's name
  --maintainer-email  print the maintainer's email address
  --contact           print the maintainer's name if known, else the author's
  --contact-email     print the maintainer's email address if known, else the
                      author's
  --url               print the URL for this package
  --license           print the license of the package
  --licence           alias for --license
  --description       print the package description
  --long-description  print the long package description
  --platforms         print the list of platforms
  --classifiers       print the list of classifiers
  --keywords          print the list of keywords
  --provides          print the list of packages/modules provided
  --requires          print the list of packages/modules required
  --obsoletes         print the list of packages/modules made obsolete

usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
   or: setup.py --help [cmd1 cmd2 ...]
   or: setup.py --help-commands
   or: setup.py cmd --help

It shouldn't be trying to download setuptools before getting a help message...

I think that's just the
from ez_setup import use_setuptools
use_setuptools()

running -- it should still happen after reverting my change.

Indeed, it happened after I reverted the changes. Seems like I tried to make it compatible with setuptools before and then completely forgot about it. I'll remove that and bring back your changes, then test it to make sure I didn't break anything.

Ok, it seems to be working normally now. Can you try out if the dependency is resolved correctly?

install_requires requires setuptools (distutils doesn't support it). I think you can probably safely just use
from setuptools import setup

as most people would have setuptools installed. That's how the Python Packaging Authority suggests it, at least: https://github.com/pypa/sampleproject/blob/master/setup.py

Good idea. I'll leave it in a try/except in case setuptools isn't installed for some reason, can't hurt.


call option for container identity

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 11.863%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
256

Relevant Lines:
2158

💛  - Coveralls


Scala Stream Collector: add splitter for large event arrays

Maximum record size for Kinesis is 50 KB (http://docs.aws.amazon.com/kinesis/latest/dev/service-sizes-and-limits.html), so we will need a mechanism to split larger payloads coming from POSTs.
This will need to support:

Self-describing JSONs where the data: field is an array
Payloads containing vanilla JSON arrays

This is pretty important actually...

Is the second case for POSTs whose body is an array of individual event JSONs, e.g.
[{
  "e": "se",
  "p": "srv",
  "tv": "py-0.9.0"
}, ...]

?

Hey @fblundun - I think the only important case is the one you cite - splitting out a payload_data into multiple smaller payload_datas...

We will also need to support an event being a) oversized and b) failing splitting, so necessitating a bad stream...

We still need this, it just splits at 1Mb...


In the UK we like Centrigrade but mph

Sorry to be awkward.  There's does not seem to be a way of getting this.

Yes, you are right. I should fix it

I was thinking of suggesting something along these lines.  How easy would it be to implement setting each measure individually for us really awkward people? e.g. wind in knots, but temperature in kelvin?

Me too. I know I'm weird but I really like the temp in kelvin

+1 for kelvin temperature

Maybe we should support all known temperature scales?
Something like: temperature=code
Where code is one of the following:

F — Fahrenheit
K — Kelvin
R — Rankine
De — Delisle
N — Newton
Re — Réaumur
Ro — Rømer

At least Newton's and Réaumur scale would be really interesting to have


Cookies added through the express aren't being added in the final response in sitecore-jss-proxy package

Description
We are adding cookies and version header( a custom one we add to show the git commit number in the response) to the response using express before sending the request to SSR proxy. I see the version header in the browser but not the cookies. When I try to log the ServerResponse from config setHeaders I see the cookies. When I log from createViewBag I don't see cookies in the serverResponse object anymore but i can see version header.
Expected behavior
Take into account cookies added by express when handling proxyResponse in SSR Proxy.
Steps To Reproduce
Using express, add cookies to the response before ssr proxy is registered.
Possible Fix
Don't delete set-cookie headers from serverResponse object and include them in the final response.
Your Environment

Sitecore Version:10.1.1
JSS Version: 16.0.0
sitecore-jss-proxy version: 16.0.0
Browser Name and version: Chrome version 92
Operating System and version (desktop or mobile): Mac

Hi @rupa29, is it possible for you to provide a code snippet? Are you using the provided setHeaders() hook in your ProxyConfig which is still stripping out your cookies?

Hi @CobyPear I'm not allowed to share the code. Will you be available for a call? I can go over what we are doing. We use setHeaders in the proxy config but cookies are set before that.

@rupa29 Our product team, who supports GitHub issues, can't do calls. Perhaps you could reproduce the issue in a simpler, non-customer codebase which you are able to share? Otherwise you can utilize Sitecore Support.

@nickwesselman  We will be reaching out to Sitecore Support. Thank you

@rupa29 Were you able to resolve this?

@nickwesselman  We are able to find a work around for now. But we want this to be fixed

@rupa29 Can you provide the internal ticket # so we can reference?

@nickwesselman Here it is CS0273427

@rupa29 Looks like we are still awaiting a sample that demonstrates the issue there as well.

@nickwesselman We demonstrated the issue to one of the sitecore team members they are aware of the issue.


Improve CSGPolygon3D documentation

master version of https://github.com/godotengine/godot/pull/57045.

Describe why polygon triangulation usually fails in the error message.

Thanks!


[BUG]: step_error: command not found in karavi-observability-install.sh

Bug Description
When using karavi-observability-install.sh to perform the installation of Karavi Observability on OpenShift, the output shows step_error: command not found
|- Verifying OpenShift versions
  |
  |--> Verifying minimum OpenShift version                          ./karavi-observability-install.sh: line 425: step_error: command not found
Failed
  |
  |--> Verifying maximum OpenShift version                          Success

Logs
[root@<host> installer]# ./karavi-observability-install.sh install --namespace karavi --values values.yaml
---------------------------------------------------------------------------------
> Installing Karavi Observability in namespace karavi on 1.23
---------------------------------------------------------------------------------
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /root/<host>/auth/kubeconfig
|
|- Karavi Observability is not installed                            Success
|
|- Karavi Authorization will not be enabled during installation
|
|- Verifying OpenShift versions
  |
  |--> Verifying minimum OpenShift version                          ./karavi-observability-install.sh: line 425: step_error: command not found
Failed
  |
  |--> Verifying maximum OpenShift version                          Success

Screenshots
No response
Additional Environment Information
No response
Steps to Reproduce
On OpenShift, install Observability according to the guide https://github.com/dell/karavi-observability/tree/main/installer
Expected Behavior
The script should not output step_error: command not found.
CSM Driver(s)
n/a
Installation Type
No response
Container Storage Modules Enabled
No response
Container Orchestrator
OpenShift 4.10
Operating System
n/a

Fixed.


Crash Dumper: E2E tests using kill filter

Signed-off-by: Kevin Baichoo<EMAIL_ADDRESS>
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: E2E test for crash dumper using the kill filter
Additional Description: The separate components where we have crash dumping support have individual unit tests, some with more mocks than others. E2E tests will build more confidence in the crash dumping pipeline.
Risk Level: Low (tests only)
Testing: Integration tests
Docs Changes: NA
Release Notes: NA
Platform Specific Features: Systems that use the crash handlers (windows doesn't currently)
Fixes #14249

/retest
Network flake

/retest

@KBaichoo seems a legit CI failure, can you take a look?
/wait

Fixed -- the test doesn't make sense to run under the compile time options mode since it requires Envoy to handle signals which that mode disables.


Error when installing Istio-ingressgateway &  egressgateway in Ambient Mode

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
When I use the 1.23.0 istioctl tool to install and deploy Istio Ambient Mode on a Kind k8s cluster on a local Mac computer, Istio-ingress fails to start. From the logs, I find that the pilot-agent execution format inside the container is incorrect. I'm not sure if this is a problem with the istioctl tool or an image packaging problem. Can someone help me check it out?

Version
➜  ~ istioctl version
client version: 1.23.0
control plane version: 1.23.0
data plane version: 1.23.0 (1 proxies)

➜  ~ kubectl version
Client Version: v1.29.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.0

Additional Information
➜  ~ istioctl bug-report
Target cluster context: kind-1-28-0
Running with the following config:
istio-namespace: istio-system
full-secrets: false
timeout (mins): 30
include: {  }
exclude: { Namespaces: kube-node-lease,kube-public,kube-system,local-path-storage }
end-time: 2024-09-06 17:39:39.651195 +0800 CST
Cluster endpoint: https://<IP_ADDRESS>:62635
CLI version:
version.BuildInfo{Version:"1.23.0", GitRevision:"d0ca037e58f90f58b38b33c5769fec25b6bfa9f3", GolangVersion:"go1.22.6", BuildStatus:"Clean", GitTag:"1.23.0"}
The following Istio control plane revisions/versions were found in the cluster:
Revision default:
&version.MeshInfo{
{
Component: "pilot",
Revision:  "default",
Info:      version.BuildInfo{Version:"1.23.0", GitRevision:"d0ca037e58f90f58b38b33c5769fec25b6bfa9f3", GolangVersion:"", BuildStatus:"Clean", GitTag:"1.23.0"},
},
}
The following proxy revisions/versions were found in the cluster:
Revision default: Versions {1.23.0}
Fetching logs for the following containers:
default/podinfo/podinfo-5749df899b-gln6j/podinfo
istio-system/istio-cni-node/istio-cni-node-2hxnr/install-cni
istio-system/istio-egressgateway/istio-egressgateway-7b9688dc7c-nzk9t/istio-proxy
istio-system/istio-ingressgateway/istio-ingressgateway-78797b6b44-pbzzp/istio-proxy
istio-system/istiod/istiod-6bfbcfcdc8-vqxpx/discovery
istio-system/kiali/kiali-5df8897db6-q9qhw/kiali
istio-system/prometheus/prometheus-bbcb484d4-krz5t/prometheus-server
istio-system/prometheus/prometheus-bbcb484d4-krz5t/prometheus-server-configmap-reload
istio-system/ztunnel/ztunnel-sfq8c/istio-proxy
Fetching Istio control plane information from cluster.
Fetching CNI logs from cluster.
Running Istio analyze on all namespaces and report as below:
Analysis Report:
Info [IST0102] (Namespace flux-system) The namespace is not enabled for Istio injection. Run 'kubectl label namespace flux-system istio-injection=enabled' to enable it, or 'kubectl label namespace flux-system istio-injection=disabled' to explicitly mark it as not needing injection.
Info [IST0102] (Namespace knative-serving) The namespace is not enabled for Istio injection. Run 'kubectl label namespace knative-serving istio-injection=enabled' to enable it, or 'kubectl label namespace knative-serving istio-injection=disabled' to explicitly mark it as not needing injection.
Info [IST0102] (Namespace kube-node-lease) The namespace is not enabled for Istio injection. Run 'kubectl label namespace kube-node-lease istio-injection=enabled' to enable it, or 'kubectl label namespace kube-node-lease istio-injection=disabled' to explicitly mark it as not needing injection.
Info [IST0102] (Namespace kube-public) The namespace is not enabled for Istio injection. Run 'kubectl label namespace kube-public istio-injection=enabled' to enable it, or 'kubectl label namespace kube-public istio-injection=disabled' to explicitly mark it as not needing injection.
Info [IST0102] (Namespace kube-system) The namespace is not enabled for Istio injection. Run 'kubectl label namespace kube-system istio-injection=enabled' to enable it, or 'kubectl label namespace kube-system istio-injection=disabled' to explicitly mark it as not needing injection.
Info [IST0102] (Namespace local-path-storage) The namespace is not enabled for Istio injection. Run 'kubectl label namespace local-path-storage istio-injection=enabled' to enable it, or 'kubectl label namespace local-path-storage istio-injection=disabled' to explicitly mark it as not needing injection.
Info [IST0102] (Namespace test) The namespace is not enabled for Istio injection. Run 'kubectl label namespace test istio-injection=enabled' to enable it, or 'kubectl label namespace test istio-injection=disabled' to explicitly mark it as not needing injection.
Info [IST0118] (Service kube-system/kube-dns) Port name metrics (port: 9153, targetPort: 9153) doesn't follow the naming convention of Istio port.
Time used for creating the tar file is 85.097305ms.
Cleaning up temporary files in /var/folders/0b/5w2ptk7x0zb4cs3_ptq8gbsw0000gn/T/bug-report.
Done.

isitoctl installation command:
➜  ~ istioctl install --set profile=ambient --set "components.ingressGateways[0].enabled=true" \       --set "components.ingressGateways[0].name=istio-ingressgateway" \       --set "components.egressGateways[0].enabled=true" \       --set "components.egressGateways[0].name=istio-egressgateway" \       --skip-confirmation

exec format error implies you have a mismatch of architecture typically. Istio images are multi-arch though, so it shouldn't really happen, but maybe you have a cached version of the wrong architecture so its not pulling a new one?

Thank you for your answer. As you said, I went into the Kind Node environment to check the current Image image and found that the Image architecture used was indeed the expected amd64 Linux. This puzzled me because the image architecture was correct. However, when I deleted this image and reinstalled it, it would get the Image again and it was successfully run, but when I checked the Image on the Node again, I found that its architecture was also amd64 Linux. So, I am not sure why it reported an error when it was installed for the first time, even though its Image architecture was indeed the expected amd64 Linux.


FriendsViewerPlugin ClassCastException

FYI the API got updated this week, so https://github.com/molo-pl/runelite-plugins/blob/a5655ae927bc9f872af7bec25e7c9aa7a948bafe/src/main/java/com/molopl/plugins/friendsviewer/FriendsViewerPlugin.java#L192 will result in a ClassCastException.

Really hope this plugin hasn't been abandoned, but it's now been a couple weeks of it being broken.

I'll look into it as soon as time allows (probably this week).

Fixed in https://github.com/runelite/plugin-hub/pull/6586


Exception on playing Spotify Song Preview URL

I am testing library using your test app.
Load MP3 Stream option.
Put this URL: https://p.scdn.co/mp3-preview/63c396837c1738dd17a7a2b055a4981dce74f46f?cid=26d287105e31491889f3cd293d85bfea
This URL is a song preview from Spotify API.
If I put the URL in google chrome, the song play ok, but not in your app.
After 10 seconds I get this error:
System.ArgumentNullException was unhandled
HResult=-2147467261
Message=You must provide a non-null Mp3Frame to decompress
Parameter name: frame
ParamName=frame
Source=NAudio
StackTrace:
at NAudio.Wave.AcmMp3FrameDecompressor.DecompressFrame(Mp3Frame frame, Byte[] dest, Int32 destOffset) in C:\Users\eyanson\Downloads\NAudio-master\NAudio-master\NAudio\FileFormats\Mp3\Mp3FrameDecompressor.cs:line 52
at NAudioDemo.Mp3StreamingDemo.Mp3StreamingPanel.StreamMp3(Object state) in C:\Users\eyanson\Downloads\NAudio-master\NAudio-master\NAudioDemo\Mp3StreamingDemo\MP3StreamingPanel.cs:line 118
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
at System.Threading.ThreadPoolWorkQueue.Dispatch()
InnerException:

looks like a bug where frame is null, we shouldn't try to decompress it. I've made a small fix.


Enhancement suggestion: Serve file with 'Content-Disposition', 'attachment' when request URL has ?download query

Something like
// If request URL has ?download query serve as download
if (req.query.hasOwnProperty("download")) {
  console.log('Just served this one as download!');
  res.setHeader('Content-Disposition', 'attachment');
}

This modification used to come in very handy to me when I wanted to get my smartphone to download stuff served from my PC.
Thanks!

@akaleeroy curious what you're doing instead?
It's not something we'd add to http-server directly (as defining URLs within the server would be a Bad Thing).
FWIW, if you're linking to these files, you can use the download attribute on an anchor tag: <a download href="awesome.file">Download</a> https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#attr-download
Somewhat related to this issue is the #360 issue which would cover situations where you always want a download triggered.


Can I do unlimited requests?

I have a question. Most of the WhoIs python packages require a WhoIs API key. This one doesn't. Can I do unlimited requests and if so is this package just scraping the data from some website to check if it is available?

This package uses the native Linux/Mac/windows command line "whois" to do it's work.
No keys required.
But note that a individual whois server for a toplevel domain may have limitations of max amount of requests per second.

This package uses the native Linux/Mac/windows command line "whois" to do it's work. No keys required. But note that a individual whois server for a toplevel domain may have limitations of max amount of requests per second.

So then I get a error if I reached the limit right?

Yes
On Tue, Jan 9, 2024, 15:58 Martijn de Vries @.***>
wrote:

This package uses the native Linux/Mac/windows command line "whois" to do
it's work. No keys required. But note that a individual whois server for a
toplevel domain may have limitations of max amount of requests per second.
So then I get a error if I reached the limit right?
—
Reply to this email directly, view it on GitHub
https://github.com/mboot-github/WhoisDomain/issues/28#issuecomment-1883207535,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7CCKLDDVZCO2WSBVCKCFNTYNVLKRAVCNFSM6AAAAABBSBHFG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBTGIYDONJTGU
.
You are receiving this because you commented.Message ID:
@.***>

Last update of whois database: 2024-01-15T20:38:27Z <<<

NOTICE: The expiration date displayed in this record is the date the
registrar's sponsorship of the domain name registration in the registry is
currently set to expire. This date does not necessarily reflect the expiration
date of the domain name registrant's agreement with the sponsoring
registrar.  Users may consult the sponsoring registrar's Whois database to
view the registrar's reported date of expiration for this registration.
TERMS OF USE: You are not authorized to access or query our Whois
database through the use of electronic processes that are high-volume and
automated except as reasonably necessary to register domain names or
modify existing registrations; the Data in VeriSign Global Registry
Services' ("VeriSign") Whois database is provided by VeriSign for
information purposes only, and to assist persons in obtaining information
about or related to a domain name registration record. VeriSign does not
guarantee its accuracy. By submitting a Whois query, you agree to abide
by the following terms of use: You agree that you may use this Data only
for lawful purposes and that under no circumstances will you use this Data
to: (1) allow, enable, or otherwise support the transmission of mass
unsolicited, commercial advertising or solicitations via e-mail, telephone,
or facsimile; or (2) enable high volume, automated, electronic processes
that apply to VeriSign (or its computer systems). The compilation,
repackaging, dissemination or other use of this Data is expressly
prohibited without the prior written consent of VeriSign. You agree not to
use electronic processes that are automated and high-volume to access or
query the Whois database except as reasonably necessary to register
domain names or modify existing registrations. VeriSign reserves the right
to restrict your access to the Whois database in its sole discretion to ensure
operational stability.  VeriSign may restrict or terminate your access to the
Whois database for failure to abide by these terms of use. VeriSign
reserves the right to modify these terms at any time.
The Registry database contains ONLY .COM, .NET, .EDU domains and
Registrars.

TERMS OF USE: You are not authorized to access or query our Whois
database through the use of electronic processes that are high-volume
I cannot use this in python it says in the terms of use

i usually use extensive caching so i dont query records that i already know and that are unlikely to have changed ( based on expiry date)
but yes many individual whois servers have their own limits set and their own rules.
whoisdomain is just a parser for the whois cli data it is not a service separate from cli whois
i will close the issue, if there are no open questions


Security Improvement for binary install

Issue #, if available:
The method for installing the eksctl and associated commands is not secure as it creates a file in a system-wide directory owned by a user (user = whoever the person is logged in as).
Description of changes:
Instead of using mv (and chmod in some of the examples), use the "install" command with appropriate flags
ex - replace first line (mv) with the second (install)
sudo mv /tmp/eksctl /usr/local/bin/
sudo install -m 0755 /tmp/eksctl /usr/local/bin/eksctl

Testing (if applicable):
RHEL8
[jradtke@rhel8 ~]$ touch /tmp/test
[jradtke@rhel8 ~]$ ls -l /tmp/test
-rw-rw-r--. 1 jradtke jradtke 0 Apr 24 16:48 /tmp/test
[jradtke@rhel8 ~]$ sudo install -m 0755 /tmp/test /tmp/test1
[jradtke@rhel8 ~]$ ls -l /tmp | grep test
-rw-rw-r--. 1 jradtke jradtke  0 Apr 24 16:48 test
-rwxr-xr-x. 1 root    root     0 Apr 24 16:48 test1

macOS
macOS:~ jaradtke$ touch /tmp/test
macOS:~ jaradtke$ ls -l /tmp/test
-rw-r--r--  1 jaradtke  wheel  0 Apr 24 17:02 /tmp/test
macOS:~ jaradtke$ sudo install -m 0755 /tmp/test /tmp/test1
macOS:~ jaradtke$ ls -l /tmp/ | grep test
-rw-r--r--  1 jaradtke  wheel      0 Apr 24 17:02 test
-rwxr-xr-x  1 root      wheel      0 Apr 24 17:03 test1
macOS:~ jaradtke$ uname -s
Darwin

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/override eks-anywhere-e2e-validate-tinkerbell-hardware-presubmit

/approve
/cherrypick release-0.17


No deploy command available v1.12-RC2. Unable to deploy DAB

Output of docker version:
Client:
 Version:      1.12.0-rc2
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   906eacd
 Built:
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.0-rc2
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   906eacd
 Built:
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 17
 Running: 3
 Paused: 0
 Stopped: 14
Images: 26
Server Version: 1.12.0-rc2
Storage Driver: devicemapper
 Pool Name: docker-253:2-8497910-pool
 Pool Blocksize: 65.54 kB
 Base Device Size: 10.74 GB
 Backing Filesystem: xfs
 Data file: /dev/loop0
 Metadata file: /dev/loop1
 Data Space Used: 2.305 GB
 Data Space Total: 107.4 GB
 Data Space Available: 4.974 GB
 Metadata Space Used: 4.149 MB
 Metadata Space Total: 2.147 GB
 Metadata Space Available: 2.143 GB
 Thin Pool Minimum Free Space: 10.74 GB
 Udev Sync Supported: true
 Deferred Removal Enabled: false
 Deferred Deletion Enabled: false
 Deferred Deleted Device Count: 0
 Data loop file: /var/lib/docker/devicemapper/devicemapper/data
 WARNING: Usage of loopback devices is strongly discouraged for production use. Either use `--storage-opt dm.thinpooldev` or use `--storage-opt dm.no_warn_on_loop_devices=true` to suppress this warning.
 Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
 Library Version: 1.02.107-RHEL7 (2015-10-14)
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge overlay null host
Swarm: active
 NodeID: 0c9va1a4eo6aglx8pcls31qxm
 IsManager: Yes
 Managers: 1
 Nodes: 3
 CACertHash: sha256:fa97bb22c536eee439645e45f8919be343000e0fcfce8259496868e91c19bc9e
Runtimes: default
Default Runtime: default
Security Options: seccomp
Kernel Version: 3.10.0-327.4.5.el7.x86_64
Operating System: Red Hat Enterprise Linux Server 7.2 (Maipo)
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 1.797 GiB
Name: manager1
ID: 7D2S:N2OL:6WE4:2XXI:MDIS:2N2A:PQF7:IKNE:6SKQ:IMUB:XRCZ:322E
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: bridge-nf-call-ip6tables is disabled
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):
VM Running on VMWare
OS Information:
$ uname -a
Linux manager1 3.10.0-327.4.5.el7.x86_64 #1 SMP Thu Jan 21 04:10:29 EST 2016 x86_64 x86_64 x86_64 GNU/Linux
$ cat /etc/redhat-release

Steps to reproduce the issue:

Installed docker-engine v1.12-RC2
Installed docker-compose v1.80-RC1
Cloned this repo: https://github.com/dgageot/dockercon16
Updated locations for the images (registry on localhost)
Ran docker-compose bundle
Attempted to run docker deploy dockercon16

Describe the results you received:
Trying to run through some examples leveraging Distributed Application Bundles (DAB). Now I've run through leveraging an example, and have bundled it up with docker-compose bundle without issue. Now when I try to deploy the bundle, I receive the following error:
$ docker deploy dockercon16
docker: 'deploy' is not a docker command.
See 'docker --help'.

Describe the results you expected: I expected the command to succeed and would effectively have the service running on my swarm.
Additional information you deem important (e.g. issue happens only occasionally):
Below is the output of the commands available when executing docker. You can see I'm missing both the deploy and stack commands.
Commands:
    attach    Attach to a running container
    build     Build an image from a Dockerfile
    commit    Create a new image from a container's changes
    cp        Copy files/folders between a container and the local filesystem
    create    Create a new container
    diff      Inspect changes on a container's filesystem
    events    Get real time events from the server
    exec      Run a command in a running container
    export    Export a container's filesystem as a tar archive
    history   Show the history of an image
    images    List images
    import    Import the contents from a tarball to create a filesystem image
    info      Display system-wide information
    inspect   Return low-level information on a container, image or task
    kill      Kill one or more running container
    load      Load an image from a tar archive or STDIN
    login     Log in to a Docker registry.
    logout    Log out from a Docker registry.
    logs      Fetch the logs of a container
    network   Manage Docker networks
    node      Manage Docker Swarm nodes
    pause     Pause all processes within one or more containers
    port      List port mappings or a specific mapping for the container
    ps        List containers
    pull      Pull an image or a repository from a registry
    push      Push an image or a repository to a registry
    rename    Rename a container
    restart   Restart a container
    rm        Remove one or more containers
    rmi       Remove one or more images
    run       Run a command in a new container
    save      Save one or more images to a tar archive (streamed to STDOUT by default)
    search    Search the Docker Hub for images
    service   Manage Docker services
    start     Start one or more stopped containers
    stats     Display a live stream of container(s) resource usage statistics
    stop      Stop one or more running containers
    swarm     Manage Docker Swarm
    tag       Tag an image into a repository
    top       Display the running processes of a container
    unpause   Unpause all processes within one or more containers
    update    Update configuration of one or more containers
    version   Show the Docker version information
    volume    Manage Docker volumes
    wait      Block until a container stops, then print its exit code

@streetmapp deploy command is only ship in the experimental build of docker 1.12.x :angel:
See https://github.com/docker/docker/tree/master/experimental to get it :wink:


code cover

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3b75326). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   45.10%
=========================================
  Files             ?       11
  Lines             ?      286
  Branches          ?        0
=========================================
  Hits              ?      129
  Misses            ?      134
  Partials          ?       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b75326...fe180b3. Read the comment docs.


update solo12

The solo 12 we had was actually a solo 8.
This PR fix this, by importing meshes from https://github.com/open-dynamic-robot-initiative/robot_properties_solo/tree/master/meshes, updating the urdf, and generating some .obj from the .stl when they were missing.

@thomasfla : could you review this ?

I guess we still need:

a review from @thomasfla
an answer to @wxmerkt

If the collision objects are .obj, why are we adding the .stl?

For 2., I have no idea. I don't know well the pro/cons of both formats. I would look at their size, the kind of information they embed, and the support in they have in different places. If they are totally redundant, yes, we should only keep the best one.

For 2., I have no idea. I don't know well the pro/cons of both formats. I would look at their size, the kind of information they embed, and the support in they have in different places. If they are totally redundant, yes, we should only keep the best one.

Usually people have a simplified stl for collision checking and obj or dae for visualisation. I am happy to keep both, if both are used. Here, there are files added that none of the URDFs reference.

Maybe we should wait a bit for https://github.com/open-dynamic-robot-initiative/robot_properties_solo/issues/19https://github.com/open-dynamic-robot-initiative/robot_properties_solo/issues/19

Looks good to me, we can merge this now and patch it when MPI solves the collision glitch.
Thanks @nim65s !

I started that again.  I added only the new STLs, and I can load the robot, and reproduce @thibnoel last results in https://github.com/open-dynamic-robot-initiative/robot_properties_solo/issues/19

If I run assimp export solo12_lower_leg_left_side.stl solo12_lower_leg_left_side.obj, I get:
╰─>$ ll solo12_lower_leg_left_side.*
 110K  solo12_lower_leg_left_side.stl
 185K  solo12_lower_leg_left_side.obj
  180  solo12_lower_leg_left_side.mtl

So the OBJ are even heavier than the STL, so I don't see the point in using them.


Logging out sent me to a broken page

Was logged in with google, logged out via the top right menu. Sent me to this page: http://puu.sh/kYTVP/cf74f02617.png

What page did you log out from?

Happens on all of them. Although, now that I looked closer it appears it briefly loads the correct page before switching to the broken looking one.

More testing:
-It appears to take me to the home page correctly, then redirect me back to the page I logged out from
-The settings page logs me out correctly.

Appears to work fine in Chrome/IE. So it's a Firefox issue. Tried in a private tab as well and still happened: latest Firefox, version 41.0.2


The new finding_info object

Related Issue: https://github.com/ocsf/ocsf-schema/issues/762
Description of changes:

Adding a new attribute of the finding object in the dict - finding_info
Adding new attributes in the finding object
Adding deprecation tags as applicable
Removing analytics from the new vuln class, as it is being replaced by the attributes present in finding_info.
Adding finding_info to the base finding class.
Aligning analytic desc in dictionary with the the one in the object.
Adding a related change flagged in a different PR

Closing in favor of https://github.com/ocsf/ocsf-schema/pull/769


Error identifier

Hi there. It was working, I upgraded kanboard to 1.2.33 version and now this plugin generates the error "Internal Error: Invalid identifier: tblPro"
I uninstalled and installed it again but error keeps.

I added this plugin after I updated to 1.2.34. It works fine.
Try to backup your database and setup a new 1.2.34 instance?

Hi, thanks for your answer. Well, I made a new installation using Kanboard <IP_ADDRESS> but plugin TableView is not working as it was not working with previous realease. I get the same message when clic on Table View on menú un project dashboard " "Internal Error: Invalid identifier: tblPro""

Below is my kanboard configuration
Configuration
Application version: 1.2.34
PHP version: 8.2.8
PHP SAPI: fpm-fcgi
HTTP Client: cURL
OS version: Linux 5.15.95-0-lts
Database driver: sqlite
Database version: 3.41.2
I run kanboard in docker with image "kanboard/kanboard:v1.2.32", then I mount the app directory to host and unzip the latest version to it.

Thanks again. I am running the 7.2 PHP. TableView plugin was running Ok but it failed with a kanboard update, 2 o 3 versions ago, really I did not detected it at the update time.
What it is rare for me is that not even making a clean kanboard <IP_ADDRESS> installation the plugin work.
Thanks for your time and your comments sulisu

This may not be an issue triggered by the TableView.
The only thing to do with "tblPro" I knew was a library called "Apache POI".
The library is used to read files in Microsoft Office format or Open Office format.


As requested, adding an example of the 'generic connection' mechanism

This adds a simple, fairly contrived, example of using the generic connection mechanism. This also came with a slight re-factor/re-naming from needs discovered later and from creating this example and wanting to make sure it was clear.
The example still uses the built in connection manager and transport, but changes what it connects to. I think even though it doesn't cover all available functionality it's a good starting point and is more concise than it would otherwise be.

Thanks!


Joint 'gripper_right_joint_mimic' not found in model 'turtlebot3_manipulation'

I want to simulate TB3-manipulation and followed the Humble instructions. I used:
ros2 launch turtlebot3_manipulation_bringup gazebo.launch.py

If I additionally:
ros2 launch turtlebot3_manipulation_moveit_config servo.launch.py

Then I get lot of:
[moveit_robot_model.robot_model]: Joint 'gripper_right_joint_mimic' not found in model 'turtlebot3_manipulation'

I can move the arm using _teleop however the control buttons seem to be wrongly mapped. For example pressing joint1+ and then joint1- does not return the arm to the original position.
Is this a bug or feature?

Probably related to https://github.com/ros-controls/gazebo_ros2_control/issues/173

https://github.com/ROBOTIS-GIT/turtlebot3_manipulation/blob/3baa265d0f4843955ed77716be6f88b71689d7a1/turtlebot3_manipulation_description/urdf/open_manipulator_x.urdf.xacro#L210
gripper_right_joint => gripper_right_joint_mimic gets rid of the errors. I can create a PR if a maintainer acknowledges that this is the right fix.
Regarding the teleop issue: The described behavior still exists after the fix. Probably another issue.

My workaround led to a static right grip in Gazebo, so I added a dummy joint like shown in https://github.com/ros-controls/gazebo_ros2_control/issues/173:
<joint name="${prefix}gripper_right_joint_mimic" type="fixed">
      <parent link="${prefix}link5" />
      <child link="dummy_mimic_fix" />
    </joint>
    <link name="dummy_mimic_fix"/>

Also related: https://github.com/ros-controls/gz_ros2_control/issues/96

Thank @goekce so much for the solution. For anyone need help with this issue
To edit turtlebot3_manipulation/turtlebot3_manipulation_description/urdf/open_manipulator_x.urdf.xacro
<joint name="${prefix}gripper_right_joint" type="prismatic">
   ...
</joint>
<joint name="${prefix}gripper_right_joint_mimic" type="fixed">
  <parent link="${prefix}link5" />
  <child link="dummy_mimic_fix" />
</joint>
<link name="dummy_mimic_fix"/>

I am also facing the same issue.

https://github.com/ArpanROS/ros2.git
This is the git link

It seems that this issue has already been resolved above, so I will go ahead and close it.


For shared per-container volumes, delete when stack is deleted

https://github.com/rancher/rancher/issues/8755


Checkbox: Add LabelPosition property to specify the label's Start/End position

Following up on PR #5152, MudCheckBox now also supports the LabelPosition property.

Description

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[X] The PR is submitted to the correct branch (dev).
[X] My code follows the code style of this project.
[X] I've added relevant tests.

@henon ready for your review

Awesome, thanks Yomodo

Note: this PR caused incorrect positioning of checkbox labels under certain conditions (see issue #5634) which is now fixed by PR #6377


Can't support dcgm 3.0

After instalation dcgm by this manual started getting errors:
[Model Analyzer] Initializing GPUDevice handles
Traceback (most recent call last):
  File "/home/radoronin/anaconda3/lib/python3.9/site-packages/model_analyzer/monitor/dcgm/dcgm_structs.py", line 622, in _LoadDcgmLibrary
    dcgmLib = CDLL(os.path.join(libDcgmPath,
  File "/home/radoronin/anaconda3/lib/python3.9/ctypes/__init__.py", line 382, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: /usr/lib/x86_64-linux-gnu/libdcgm.so.2: cannot open shared object file: No such file or directory

DCGM Version : 3.0.4
Then i create symlink libdcgm.so.2 to libdcgm.so, and then errors changed to:
[Model Analyzer] Initializing GPUDevice handles
Traceback (most recent call last):
  File "/home/radoronin/anaconda3/bin/model-analyzer", line 8, in <module>
    sys.exit(main())
  File "/home/radoronin/anaconda3/lib/python3.9/site-packages/model_analyzer/entrypoint.py", line 248, in main
    gpus = GPUDeviceFactory().verify_requested_gpus(config.gpus)
  File "/home/radoronin/anaconda3/lib/python3.9/site-packages/model_analyzer/device/gpu_device_factory.py", line 36, in __init__
    self.init_all_devices()
  File "/home/radoronin/anaconda3/lib/python3.9/site-packages/model_analyzer/device/gpu_device_factory.py", line 62, in init_all_devices
    device_atrributes = dcgm_agent.dcgmGetDeviceAttributes(
  File "/home/radoronin/anaconda3/lib/python3.9/site-packages/model_analyzer/monitor/dcgm/dcgm_agent.py", line 103, in dcgmGetDeviceAttributes
    dcgm_structs._dcgmCheckReturn(ret)
  File "/home/radoronin/anaconda3/lib/python3.9/site-packages/model_analyzer/monitor/dcgm/dcgm_structs.py", line 646, in _dcgmCheckReturn
    raise DCGMError(ret)
model_analyzer.monitor.dcgm.dcgm_structs.DCGMError_VerMismatch: API version mismatch

And i cant find in official docs how to install DCGM of early version.

In our container we use:
# DCGM version to install for Model Analyzer
ENV DCGM_VERSION=2.2.9

Can you try installing that version?
apt-get install -y datacenter-gpu-manager=1:${DCGM_VERSION}

thanks, that's work for me!


Refactor/variables-redux

Which issue(s) this PR fixes

Fixes #138
Additional comments

Handle service and component variables through Redux:

Initialize Redux with 3 slices:

config, to handle user config (read from the config.json in dev mode, and fetched from /config when exported)
variables, to handle variables fetched from the server with a loading state.
userInput, to hold variables changed by an user for a given service (and its components). Thought, I'm not sure that Redux is the good place to store those infos.

TODO: Actualize sub-part of the slice when navigating through services and components. For now, variables are only fetched all at once when loading the app.
TODO: Store the logs in a log slice.

This PR allows:

To use Redux to handle the global state instead of using useContext/useReducer. Redux is well documented and should be easier to maintain.
To fix most of the bug linked to component and service switches.
To improve performances, as variables as store since the first API call.

Agreements

[X] I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004.
[X] I hereby agree to grant TOSIT a copyright license to use my contributions.

Thanks for your review, I'll have a look at it!

You were right, I added both:

a toast / early return statement if nothing have been modified
a cleanup of the state when the request succeeded

Would be even better after #131

One more thing to fix : When editing a value and then undoing the changes (the store holds the variable already on the server), an error is thrown in addition to this toast :

validating these changes would produce no difference

Done, also added a reset of the user inputs when switching from a service to another which was causing a bug.

Thought, I'm not sure that Redux is the good place to store those infos.

This kinda confirms what I thought. Ideally, we should compare the inputted values to the server ones to avoid the "validating these changes would produce no difference" error. However, 2 slices cannot be mixed (variables and userInput in this case).
The solution would be to store in a context local to the service the variables modified for a service and its components. Then, possibly persist this context in the global store (or local storage) if we want to keep the user's uncommitted modifications in memory.
I'm gonna try to roll back to a local context for this feature but this time using a reducer instead of a simple state (keeping the same logic as the slice).

Hi,
I have other comments ^^'
I suppose that the type of the variable is checked before validation.

There's a difference of behavior between the first and the second modification in case of an error : eg. :

"hdfs"zz and click on "Validate" => information with "No variables to change"
rollback and click on "Validate" => error with "validating these changes would produce no difference"
"hdfs"zz and click on "Validate" => error with "validating these changes would produce no difference"

With the boolean type, is there a difference between true and "true" ?
in the YAML file, the result is :

true => true
"true" => 'true'

@mdrutel

There's a difference of behavior between the first and the second modification in case of an error

The behavior that you describe is a bit odd but is not a big error. In fact, variables that are similar to the one that are one the server shouldn't even be sent. I'll open an issue to improve this later.

With the boolean type, is there a difference between true and "true" ?

Some Hadoop services ask for boolean, and other for string. It's not really an UI issue. What we could do to improve the ux is:

Display the type of each variable in an explicit way. (#130)
Use the json schema to show descriptions for those variables.


When I try use curl I get error 35

I write comand curl  https://portal.rosreestr.ru:4433 -k and get error curl: (35) error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure. What I am doing wrong?

Does this site work with any other software without a client certificate?

No. It shold work nly with authorization by certificate. And the user must also send his certificate too. I have not yet learned how to do it with curl, but I thought that I got other type of error.

Could you try
    curl https://portal.rosreestr.ru:4433 -k -v --key key.pem --cert cert.pem
with your key.pem and  cert.pem and show output?

I have only cer file. No private key. How to get it from cer file?

No

Do you have something like ----- ***** -----?

No. I hava 0‚E0‚ф ч°zДЪ»з in this file when I open it by notepad++

It's probably in DER-format. You can try openssl x509 -inform der -in certificate.cer -out certificate.pem to convert it to pem and then look with notepad++.

Yes, it is works. I got -----BEGIN CERTIFICATE-----.

Do you have -----BEGIN PRIVATE KEY----- somewhere in the file?

No. Mybe to need use special console key for get the private key ?

Usually, obtaining private key is part of proccess of generating (obtaining) client certificate. Could you describe how did you get your cer?

Currently, I don't know the reason of the error.

Maybe this servise use different algoritms? How to change connection algoritm?

This server does not support TLS 1.1, TLS 1.2, TLS 1.3 but TLS1.0. May be it supports SSLv3, but curl in docker does not support it.


Purify 2B in new kernels

@CheukHinHoJerry  -- I think before we can get rid of ACE1 and ACE1x we may want to implement at least the 2B purification in the new implementation. Do you have any thoughts on that? Can we both think about it and discuss early next week?

Sure - I will mull over this during weekend.

@CheukHinHoJerry  -- I think this is the only missing feature for 0.8. Have you managed to give any thought to this yet? Don't worry if not, but I don't want to start if you have already done something.

I haven't done anything on this yet. We discussed last time that we are more inclined to do this as a separate lux layer. I am still uncertain on how to do this efficiently but maybe we shouldn't worry about the cost and just do this naively?

Let me see if I find any time to have a first go at this over the next two days.

just to record here that there is a draft in P4ML, but it seems to be a little non-trivial to make this both efficient and general (i.e. non-polynomials...)


Allow configurability of AWS resources

Description
AWS resources should be configurable. Scope defined here

https://github.com/civiform/civiform/issues/5058 related as well


Add version to app name when releasing

The Chore
Rename the Vegawallet app in the release binaries to Vegawallet-vX.X.X with the appropriate version name, so it's easier for people who wish to have multiple apps to interact with different networks on different versions.

Need to consider that changing the name will stop the application replacing the existing version when installed and result in multiple applications.

Closing as is a duplicate now of Version signposting #581


[App Config] Fixing Build Snippets

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

Resolves #33973


Update anchors and copy snippets

Summary
This PR:

fixes the hidden anchor headings when folks use the hashed links on a page
adds the copy snippet styling to the ESR tab
adjusts related styles and syntax issues

Ticket Link
https://app.asana.com/0/0/1206883460555094/f

Tab instances on:

http://mattermost-docs-preview-pulls.s3-website-us-east-1.amazonaws.com/6999/install/install-tar.html
http://mattermost-docs-preview-pulls.s3-website-us-east-1.amazonaws.com/6999/install/install-rhel-8.html


[CPP Graph]Enable FFN fusion

Type of Change
Add FFN fusion for gptneox-20b，Dolly-v2-3B, Mpt-7B, Starcoder-3B, falcon-7B

https://inteltf-jenk.sh.intel.com/view/nlp-toolkit-validation/job/ITREX-cpp-graph-extension/52/

please update with latest API https://github.com/intel/intel-extension-for-transformers/blob/793629f11a775a05b5c22ee53224020516926eac/intel_extension_for_transformers/llm/runtime/graph/models/gptj/gptj.cpp#L204

https://inteltf-jenk.sh.intel.com/view/nlp-toolkit-validation/job/ITREX-cpp-graph-extension/71/

https://inteltf-jenk.sh.intel.com/view/nlp-toolkit-validation/job/ITREX-cpp-graph-extension/71/

failed?

https://inteltf-jenk.sh.intel.com/view/nlp-toolkit-validation/job/ITREX-cpp-graph-extension/71/

failed?

failed Since yesterday a pr in zhentao modified the command line of inference, causing inference to fail, I retested it, still in queue, I tested it locally and there is no problem


Reduce the loading time of the website and maximise lighthouse score

Description
What can be done?

Loading CSS later after HTML loads
async loading of the page

Screenshots

Additional information
No response
Do you want to work on this issue?

[ ] I want to work on this issue.

Hi @AnirudhPanda
Can I work on this issue under GSSoC'23?


Use VECTOR_PTR_RO instead of non-API DATAPTR

https://github.com/r-devel/r-svn/commit/d499fab95b1ba23ee7842293030d4af1e69ae0fe

DATAPTR_RO is also fine to use.


show all derived images per page

This allows browsing AlternativeImages for all segments, and adds tooltips (showing the pageId and/or segment ID):

(I also removed the hilarious PAGE-XML split hack – it seems to be enough to just disable the highlighting. And the file open dialog needed a filename filter to allow picking anything.)
You may want to make a new release after the recent changes.

Zooming works and is more comfortable than in PageViewer, but there might be problems when scaling too large (memory?).
Also, I have not changed the basic size calculation which tries to show all images with the same height (which is obviously not very useful anymore now that all derived images of the fileGrp are shown, regardless of hierarchy level). Maybe we should not use absolute height (calculated from the window size) as target, but simply display scale=1.0 as original pixel size?
Moreover, I noticed a glitch in the page_qty selector, which now apprears analoguously in the scale selector: you cannot select the second step...

Thanks @bertsky ! What a great feature!

Zooming works now and is more comfortable than in PageViewer, but there seem to be (memory?) problems when scaling too large.

I  clamped the zoom range from 0.125 (2^-3) to 4.0 (2^2) because it was too easy to accidentaly  freeze the program with high zoom levels.

Also, I have not changed the basic size calculation which tries to show all images with the same height (which is obviously not very useful anymore now that all derived images of the fileGrp are shown, regardless of hierarchy level). Maybe we should not use absolute height (calculated from the window size) as target, but simply display scale=1.0 as original pixel size?

Yes, original pixel size makes more sense, maybe we can add  "fit to height/width/page" buttons later

Moreover, I noticed a glitch in the page_qty selector, which now appears analoguously in the scale selector: you cannot select the second step... (but have not gotten around it yet via initialization or different set_adjustment). Should open a separate issue for that...

I have the impression Gtk.Adjustment.new(0.0, min_, max_, step, page_increment = 0, page_size = 0) helped
I changed the ImageZoomSelector display a bit, it now shows the log2 (not log1.2) of the zoomlevel (and a tooltip with the actual zoomlevel). The idea is, that this values are easier to grasp (-2 = 1/4 |-1 = 1/2 | 0 = 1 | 1 = 2 | ...) I hope this is ok with you, I'm open to change that behaviour later.

I clamped the zoom range from 0.125 (2^-3) to 4.0 (2^2) because it was too easy to accidentaly freeze the program with high zoom levels.

Yes, better safe than sorry.

Yes, original pixel size makes more sense, maybe we can add "fit to height/width/page" buttons later

Good idea.

I have the impression Gtk.Adjustment.new(0.0, min_, max_, step, page_increment = 0, page_size = 0) helped

Not for me, unfortunately (with built PyGObject against Gtk 2.0). If I click plus on #Pages=1 I (still) immediately end up with 3.

I changed the ImageZoomSelector display a bit, it now shows the log2 (not log1.2) of the zoomlevel (and a tooltip with the actual zoomlevel). The idea is, that this values are easier to grasp (-2 = 1/4 |-1 = 1/2 | 0 = 1 | 1 = 2 | ...) I hope this is ok with you, I'm open to change that behaviour later.

Oh, yes – it's much better this way! Separating the exponential base from the stepsize, coupling the mouse wheel scale to the button scale, showing a comprehensive tooltip etc. are all absolutely to my liking :-)

Don't forget to make a new release soon!


Use Jekyll-Assets to enable SCSS?

https://github.com/jekyll/jekyll-assets
Not sure if it works with github pages, but I think it does.
Worth checking, as it could get these styles cleaned up.

Turns out Jekyll does this natively


changed Requirement.md

I changed the requirements as new research has made me identify new requirements that will be essential in developing communication skill.

Closing as had to make amendments to file

Reopened as mistakes have now been fixed


[FAQ] How to customize configuration values to override default values

Hey @Peefy , can i have some description for this issue.

The question is here https://www.kcl-lang.io/docs/user_docs/support/faq-kcl#37-how-to-modify-existing-configuration-blocks-in-kcl
This issue is no longer open.


Nodes get cut-off when ilabels_fontsize is set to large number.

I have the following code to draw a directed graph with edge weights.
## Load the packages
using Random
using CairoMakie
using GraphMakie
using Graphs
using LaTeXStrings
using Colors

## Create a random directed graph
vnum = 4
enum = 6
ilabels = string.('a':'z')[1:vnum]
seed = 1234
g = erdos_renyi(4, 6, is_directed = true, seed = seed)
Random.seed!(seed)
elabels = LaTeXString.(string.(rand(1:10, enum)))

## Plot the data
font_size = 32
fig, ax, p = graphplot(
    g;
    ilabels = ilabels,
    ilabels_fontsize = font_size,
    elabels = elabels,
    elabels_fontsize = font_size,
    node_color = :orange,
    edge_color = :gray,
    edge_width = 4,
    node_strokewidth = 4,
    arrow_shift = :end,
    arrow_size = 40,
);
hidedecorations!(ax);
hidespines!(ax);
colsize!(fig.layout, 1, Aspect(1, 1.0));
resize_to_layout!(fig);
fig

As you can see, the nodes in the picture gets cut off when they are too large. Is there any way to avoid this?

I'll close this as a duplicate of #141.
Peviously I posted some code on discourse to work around that problem: https://discourse.julialang.org/t/textbox-graph-with-networklayout-with-labels-cut-off-using-graphmakie/96566/3
Unfortunately, I still don't know how to solve this fundamentally. The problem is, that this would be an iterative process since the nodes are drawn in pixelspace. Therefore, its hard to predict where the axis limits need to be exactly (axis limits change pixel/per_data_unit scale which changes the axis limits and so on.


zed is not opening

Check for existing issues

[X] Completed

Describe the bug / provide steps to reproduce it
Steps:
cmd + space type zed and hit enter
Result:
mac tells that it is open
and I would like to see the window go to the front
but nothing happens
Environment
mac
If applicable, add mockups / screenshots to help explain present your vision of the feature
https://user-images.githubusercontent.com/33072590/226261810-7b301544-288f-4405-b521-2d37301977a7.mov
If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.
If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.
No response

This is a duplicate of #1148 :
Zed opens, like the dock indicator suggests and the menu bar changes to show the menus of Zed whenever the app is focused. It just does not open a window automatically, you have to click on File > New Window to get one. (or use the cmd-shift-N shortcut for it)
Do people just never look at the global menu bar? 😄

I agree, the current behavior is not desirable.
So please go give the older issue a :+1: so we can keep the votes for one issue in one place.

Closing this in favor of #1148.


design idea: transformers tchee tchoo tchhurk kurk keigh

We intentionally make the storage component internals lazy, which implies first requests block before service. This addresses things like subtle race conditions when zipkin and a dependency start at the same time. For those who remember, we crashed back when it was finagle, and this caused a mess of questions. Users do not like having to orchestrate things to deal with a second delay.
Yet, there are some resources that have a delay, like looking up DNS for elasticsearch domains and waiting for the health check to come back. We also have intentional delay, like a guard on ES templates being there because it is even worse chaos if we let requests pass without setting the template.
Meanwhile, I think armeria/netty could possibly handle some things better if things were not lazy. While it is risk to do things on event loop, as you can smash the entire server (See #2697), it does offer choices.
I was thinking (in the shower).. what if we can have both words? Could we startup with a throwaway blocking router, which then unhooks itself once storage is initialized? This might dramatically simplify thread pools etc.. in theory anyway..
cc also @kojilin in case you do things like this in normal services :P

I think the code version is something like
if (initialized)
  run();
else
  blockingExecutor.execute(() -> {
    run();
    initialized = true
}

I would be worried though if at some point that initialized does not reflect reality and something later blocks. If the server codebase enforced a practice of

Blocking I/O methods do not take callbacks
Callbacks passed to methods do not do blocking I/O

then it would be safe but without that, it would be quite realistic to accidentally add back a block. Don't think it's worth trying that until a potential zipkin 3 - we discussed a major version would probably be needed to codify blocking guidelines on APIs and I think we'd need

Any API that takes a callback must not do blocking I/O itself, only call other APIs that take callbacks to do so

No callback provided to such an API can do blocking I/O or call a method that does blocking I/O

Even better would be to not ever do blocking I/O - not blocking does not imply not ordering. Composition of CompletableFuture can ensure ordering, caching of futures can ensure synchronization. But it makes the codebase much more complex so it might be too much of a shift.
Just a memo of my thoughts

interesting.. I was thinking about really like a proxy an in-memory proxy/barrier which intercepts the http traffic, but blocks callers on a configuration gate. somehow, this proxy/interceptor is removed. he other code actually stays the same except it could rely on no ordering or initialization proxy.
It seems a lot simpler without a rewrite which I don't think anyone has time for right now. It would be very easy to get the blocking ordering part (which does the most suprising I/O) off the main line.
This doesn't mean the ideas you have for zipkin 3 aren't cool, I like them, just I was wondering about a tactical change as I don't think at the moment we'd require having time resources and desire to do a full rewrite for an optimization like this. I think we can make a Zipkin 3 wishlist with what you've mentioned regardless. I think in Brave for example, we have // BRAVE 6 notes scattered around in relevant places which identify trouble spots.

@anuraaga Just opened a zipkin3 also and assigned you as the lead but this is not implying sending you to coal mine :) just to what degree you are interested and have time on more strategic things, please note or progress what you can https://github.com/openzipkin/zipkin/issues/2759
We put a lot of time into refactoring the server and deserve to benefit from that. For example we've had significant work done since march and this has impacted users not always in good ways. We have a brand of being the stable option and we should live up to that.
I think you get it, I'm just trying to find a way of being objective about duty and how we could. Ex. we have been in process of armeria transition on and off the last 5 months. We deserve a break at some point, and users do too. Having 3 if not 6 months of stability before the next huge refactor seems reasonable. Since we're not out of the woods, yet, on this one.. I was looking for tactical ways to get things stable, but understand this idea could be misplaced. take it as a grain of salt if it isn't helpful.

Yeah I agree we shouldn't do any big rework any time soon, just ideas for how to get to safe async. I think for now, we're already where we need to be - running calls on the blocking executor since our logic we can never assume to be fully async. Without assurances on the blocking properties of business logic, I think we would always be nervous about accidentally blocking an event loop but now it's basically not possible (well, that does assume we don't add a redis layer or something to our span decoders, currently the only significant business logic run on the event loop ;) )
The performance impact of the switch is marginal, I'd guess at max a couple ms in a very worst case - for the other issue I didn't see any visible impact from removing it unlike the weirdness of handleAsync. Hopefully we can look at getting that back, in a couple of years or something :)

works for me, @anuraaga, let's reserve effort towards other things in the air and eventually a zipkin3!


pipenv shell ignores VIRTUAL_ENV environment var

pipenv shell do not respect VIRTUAL_ENV env var because PIPENV_ACTIVE is set before accessing project.virtualenv_location method
https://github.com/pypa/pipenv/blob/master/pipenv/project.py#L418
it causes pipenv shell to create a new virtual env folder instead of using the existing one set in VIRTUAL_ENV

@codeinvain Yes it is working this way so that we can test pipenv inside a virtualenv. Anyway, if you are already in an activated virtualenv, pipenv shell makes no sense.

@frostming  thanks for the quick reply.
maybe i didn't explain myself correctly.
I have an existing setup using pipenv using custom  virtual env folder path (non default ~/.local/share/virtualenvs/) .
i'm directing pipenv to use my custom virtual env using  VIRTUAL_ENV  environment before invoking pipenv commands .
this works well for all pipenv commands (pipenv run / pipenv --venv/ etc') but pipenv shell which tries to create a new virtualenv under ~/.local/share/virtualenvs/ once executed.

maybe the solution  is to memoize os.getenv("VIRTUAL_ENV") in https://github.com/pypa/pipenv/blob/847b8ae28da5bc9c301ae9689f8429ce394cfaec/pipenv/project.py#L420
        if ("PIPENV_ACTIVE" not in os.environ and
                not PIPENV_IGNORE_VIRTUALENVS and virtualenv_env):
            self._virtualenv_location = virtualenv_env
            return self._virtualenv_location

since it does not make any sense that you call the same method (project.virtualenv_location ) and get two different results depending on when it was called

@codeinvain I see, in master branch the PIPENV_ACTIVE is postponed so that it can work rightly now.
https://github.com/pypa/pipenv/blob/44db5dd87dbeb34e94bf42f178c13b70e9405e8c/pipenv/core.py#L2151-L2160
Can you try against master branch and see if it fit your case?

@frostming thanks!
Unfortunately this implementation does not work. it fixes the prompt message on pipenv shell but ignores this path beside that.
it still have issues with pipenv install inside or outside the virtual env
when using VIRTUAL_ENV and inside the pipenv shell its trying to resolve bins from ~/.local/share/virtualenvs/<PIPENV_DEFAULT_ENV_NAME>/ and not from VIRTUAL_ENV path.
It all leads me back to my proposals either to

memoize _virtualenv_env
or
ignore PIPENV_ACTIVE

memoization will work if we have only one Project instance (if we have multiple instances that instances that are created after  os.environ["PIPENV_ACTIVE"] = vistir.misc.fs_str("1") will be invalid
ignoring PIPENV_ACTIVE in Project.virtualenv_env IMHO  is more predictable and is easier to reason about when maintaining the code. would be nice to understand what are the scenarios that you want  ignore VIRTUAL_ENV once inside a pipenv session (i assume marked as PIPENV_ACTIVE)
That's i did to check:
$ mkdir -p  /tmp/example && cd /tmp/example
$ pip install git+https://github.com/pypa/pipenv.git --user
Collecting git+https://github.com/pypa/pipenv.git
  Cloning https://github.com/pypa/pipenv.git to /private/var/folders/db/wy74wjzd0n59f__0jrkk1f3c0000gn/T/pip-req-build-e4l36ujl
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
    Preparing wheel metadata ... done
Requirement already satisfied (use --upgrade to upgrade): pipenv==2018.11.27.dev0 from git+https://github.com/pypa/pipenv.git in /Users/danielc/Library/Python/3.6/lib/python/site-packages
Requirement already satisfied: pip>=9.0.1 in /Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages (from pipenv==2018.11.27.dev0) (19.0.2)
Requirement already satisfied: setuptools>=36.2.1 in /Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages (from pipenv==2018.11.27.dev0) (40.2.0)
Requirement already satisfied: virtualenv in /Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages (from pipenv==2018.11.27.dev0) (16.0.0)
Requirement already satisfied: certifi in /Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages (from pipenv==2018.11.27.dev0) (2018.8.24)
Requirement already satisfied: virtualenv-clone>=0.2.5 in /Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages (from pipenv==2018.11.27.dev0) (0.3.0)
Building wheels for collected packages: pipenv
  Building wheel for pipenv (PEP 517) ... done
  Stored in directory: /private/var/folders/db/wy74wjzd0n59f__0jrkk1f3c0000gn/T/pip-ephem-wheel-cache-5onz5iv6/wheels/0a/02/1f/d42a34feec5f69f4960928f5efa3e149adfde2ce317f1ba69e
Successfully built pipenv
$ pipenv --version
pipenv, version 2018.11.27.dev0
$pipenv install ujson
Creating a virtualenv for this project…
Pipfile: /private/tmp/example/Pipfile
Using /Users/danielc/.pyenv/versions/3.7.2/bin/python3 (3.7.2) to create virtualenv…
⠹ Creating virtual environment...Using base prefix '/Users/danielc/.pyenv/versions/3.7.2'
New python executable in /Users/danielc/.local/share/virtualenvs/example-KJM9Zk2R/bin/python3
Also creating executable in /Users/danielc/.local/share/virtualenvs/example-KJM9Zk2R/bin/python
Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /Users/danielc/.pyenv/versions/3.7.2/bin/python3

✔ Successfully created virtual environment!
Virtualenv location: /Users/danielc/.local/share/virtualenvs/example-KJM9Zk2R
Installing ujson…
Adding ujson to Pipfile's [packages]…
✔ Installation Succeeded
Pipfile.lock not found, creating…
Locking [dev-packages] dependencies…
Locking [packages] dependencies…
✔ Success!
Updated Pipfile.lock (326af2)!
Installing dependencies from Pipfile.lock (326af2)…
  🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 1/1 — 00:00:00
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.
$ # ^^ you can see that it works as expected without virtual env set ^^
$
$
$ export VIRTUAL_ENV=/Users/danielc/.local/share/virtualenvs/example-KJM9Zk2R0-custom-venv
$ pipenv install ujson
Installing ujson…
WARNING: location not created nor specified
✘ Installation Failed

@codeinvain

When inside pipenv shell, pipenv takes control over the virtualenv paths. If you run pipenv --venv inside the pipenv shell subshell, it will gives you the pipenv owned virtualenv path.
To use a custom virtualenv location, the recommended way is to write the path in a .venv file under the project directory. We don't manually set VIRTUAL_ENV value which is owned by virtualenv tools.

I repeat your steps in the previous comment, works fine.

@frostming per your advise moved to .venv file instead of setting VIRTUAL_ENV and it looks fine both on dev and 2018.11.26 release
thanks!


Private libs end up in public provides

gcc-12-test-sca.yaml
package:
  name: gcc-12-test-sca
  version: 12.4.0
  epoch: 0
  description: "the GNU compiler collection - version 12"
  copyright:
    - license: GPL-3.0-or-later

environment:
  contents:
    packages:
      - busybox
      - gcc-12

pipeline:
  - runs: |
      mkdir -p ${{targets.destdir}}/usr/lib
      cp -r /usr/lib/gcc ${{targets.destdir}}/usr/lib

build output:
024/07/11 18:58:44 INFO generating package gcc-12-test-sca-12.4.0-r0
2024/07/11 18:58:44 INFO scanning for shared object dependencies...
2024/07/11 18:58:44 INFO   found lib libc.so.6 for usr/lib/gcc/x86_64-pc-linux-gnu/12.4.0/libgomp.so.1.0.0
2024/07/11 18:58:44 INFO   found lib libc.so.6 for usr/lib/gcc/x86_64-pc-linux-gnu/12.4.0/libitm.so.1.0.0
2024/07/11 18:58:44 INFO   found lib libm.so.6 for usr/lib/gcc/x86_64-pc-linux-gnu/12.4.0/libquadmath.so.0.0.0
2024/07/11 18:58:44 INFO   found lib libc.so.6 for usr/lib/gcc/x86_64-pc-linux-gnu/12.4.0/libquadmath.so.0.0.0
2024/07/11 18:58:44 INFO   found lib libc.so.6 for usr/lib/gcc/x86_64-pc-linux-gnu/12.4.0/libssp.so.0.0.0
2024/07/11 18:58:44 INFO scanning for commands...
2024/07/11 18:58:44 INFO scanning for pkg-config data...
2024/07/11 18:58:44 INFO scanning for python modules...
2024/07/11 18:58:44 INFO scanning for shbang deps...
2024/07/11 18:58:44 INFO   runtime:
2024/07/11 18:58:44 INFO     so:libc.so.6
2024/07/11 18:58:44 INFO     so:libm.so.6
2024/07/11 18:58:44 INFO   provides:
2024/07/11 18:58:44 INFO     so:libgomp.so.1=1
2024/07/11 18:58:44 INFO     so:libitm.so.1=1
2024/07/11 18:58:44 INFO     so:libquadmath.so.0=0
2024/07/11 18:58:44 INFO     so:libssp.so.0=0
2024/07/11 18:58:44 INFO   installed-size: 74429639
2024/07/11 18:58:44 INFO   data.tar.gz digest: f4370156bd67b791b8c0cb8eb0856a4a25a6a0301cad1f2ee85cfc26aa308e93
2024/07/11 18:58:44 INFO wrote packages/x86_64/gcc-12-test-sca-12.4.0-r0.apk

Expecting this to not happen:
2024/07/11 18:58:44 INFO   provides:
2024/07/11 18:58:44 INFO     so:libgomp.so.1=1
2024/07/11 18:58:44 INFO     so:libitm.so.1=1
2024/07/11 18:58:44 INFO     so:libquadmath.so.0=0
2024/07/11 18:58:44 INFO     so:libssp.so.0=0

As these libraries are in the private /usr/lib/gcc/ location, these are not public libraries and should not conflict with gcc which ships them publically. As intention is for gcc-12 to be co-installable with gcc.
Seems like we check for usr/lib/ prefix, but then we have unlimited depth, and subdirs shouldn't typically be included in automatic SCA provides as typically they are outside of the ldconfig.conf paths.
(cc @smoser @imjasonh @jonjohnsonjr )

This bug is the reason why gcc-12 package uses no-provides which intern is buggy w.r.t. turning of depends, see https://github.com/chainguard-dev/melange/issues/1366

Do you have an idea how many packages list a provides: so: that's "private" today?
(Is "private" here being defined as being under a subdirectory in /usr/lib?)

Maybe this is helpful. Maybe not. I put together this crappy shell script https://gist.github.com/smoser/0a11e2643b884960c1e5349d4dc0b8c7 .
I'm going to attach the output in case you find it useful.
out.d.tar.gz
more crappy shell scripts with that data can answer your question.

Just checking my understanding: another example of this is py3-seaborn which has
-rwxr-xr-x root/root<PHONE_NUMBER>-01-26 10:15 usr/lib/python3.12/site-packages/numpy.libs/libquadmath-96973f99.so.0.0.0

and so has it in its provides:
provides = so:libquadmath-96973f99.so.0.0.0=0.0.0

https://apk.dag.dev/https/packages.wolfi.dev/os/x86_64/py3-seaborn-0.13.2-r0.apk@sha1:6d5ff93ebf4f34a98d67ca94f2c073f98832f57e/.PKGINFO
It sounds like that should be detected as a "vendored" .so, and not as a provided one. Is that right?

It feels to me like we should only generate provides: for .so files in "normal" locations... those that we would put in /etc/ld.so.conf or /etc/so.conf.d/ .  If something had a dependency on libquadmath above, then it is extremely unlikely that py-seaborn would successfully provide it.
I feel like there are probably some cases where that is not true, but i would expect those to be outliers.  I can imagine that

within the same origin package , things might "know" to look in additional paths
for some well defined/well known plugin architectures there might be paths that are not expected to be added to system search path.

py3-seaborn => shouldn't really vendor in numpy, and should really depend on matching py3-numpy.
Also our libquadmath currently is not correctly shipped by gcc as a separate package, as that really out to be a separate package for things to depend on at runtime (as in py3-numpy likely should have dependency on so:libquadmath.so which is provided by libquadmath package which is currently empty, because bugs).


How to open themeable browser within themeable browser

Hi again
i have three pages 1) index page 2) faqs page and 3) contactus page.
On index page i have a link which opens contactus page in themeable browser
Now in contactus page there is a hyperlink which suppose to open faqs page but currently its  not openning.
probably the themeable browser is already open i think. So how do i open themeable browser within a link in themeable browser

and one more thing on exit the page is still in memory when i remote debug i still see the last page after exit or close.

and one more thing on close page is still in memory when i remote debug i still see the last page

@skhurams, could you please open a separate issue for this so that it can be tracked independently? Could you please also include the platform and version for this issue? (iOS, Android?)
Now back to your previous comment. If I understand this correctly, user opens the Contact Us page in ThemeableBrowser. While in ThemeableBrowser, user clicks on a URL in Contact Us that leads to FAQ. I assume this redirection happens entirely in ThemeableBrowser and your JavaScript (wrapped by Cordova) did not interact wit this redirection. Furthermore the URL of FAQ page on Contact Us page is correct and reachable. Is that correct? If that's the case then ThemeableBrowser should work by design. eg. If you load up Google, then click on Google News, ThemeableBrowser should redirect  you to Google News page. What you are trying to accomplish is analogical in behaviour is it?
You may want to add a listener to loadstart, loadstop and loaderror events to see if there's any loading errors.

@skhurams, could you also include platform and version for this issue? (ie, iOS 7 etc.)

By the way, did you use _blank for your FAQ URL in Contact Us? Because multi-window is totally not supported.

yes i used target="_blank" but it didn't help

What I meant was target="_blank" is not supported by neither ThemeableBrowser nor InAppBrowser. So if that's the case, then removing it will help. I assume you didn't have target="_blank" before?
What if you open your Contact Us page in your system's default browser eg.
cordova.ThemeableBrowser.open('http://your-url/contactus', '_system');

Then you click on FAQ link in your system browser, does that work? What is the behaviour there? Do you use any frameworks for your Contact Us page eg. jQuery Mobile? Again, what's your platform and version?

It would help if you could post the source code inside your Contact Us page that links to your FQA page. Of course, feel free to mask any confidential information.

FYI I've made a new release to address memory leak issues.  So you have to wait for about 10 seconds for the dismissed WebView to be destroyed.

Hi How add loader or prograssbar in themebrowser i want to show  laoder in themebrowser untill its open www.google.com.for now its taking some time to open and untill it opens its showing empty white screen.
this is my code (ima using ionic)
$scope.themebrowser = function()
{
					var ref = cordova.ThemeableBrowser.open('http://www.eenadu.net/andhra-pradesh-news.aspx', '_blank',
					{
						statusbar: {
						color: '#ffffffff'
					},
					toolbar: {
						height: 44,
						color: '#f0f0f0ff'
					},
					title: {
						color: '#003264ff',
						showPageTitle: true
					},
					backButton: {
						image: 'back',
						imagePressed: 'back_pressed',
						align: 'left',
						event: 'backPressed'
					},
					forwardButton: {
						image: 'forward',
						imagePressed: 'forward_pressed',
						align: 'left',
						event: 'forwardPressed'
					},
					closeButton: {
						image: 'close',
						imagePressed: 'close_pressed',
						align: 'right',
						event: 'closePressed'
					}
					/*,
					customButtons: [
					{
					image: 'share',
					imagePressed: 'share_pressed',
					align: 'right',
					event: 'sharePressed'
					}
					],
					menu: {
					image: 'menu',
					imagePressed: 'menu_pressed',
					title: 'Test',
					cancel: 'Cancel',
					align: 'right',
					items: [
					{
					event: 'helloPressed',
					label: 'Hello World!'
					},
					{
					event: 'testPressed',
					label: 'Test!'
					}
					]
					}*/
					,
					"browserProgress": {
					"showProgress": true,
					"progressBgColor": "#016585",
					"progressColor": "#FFAA16"
					},
					backButtonCanClose: true,
					fullscreen:true
					}).addEventListener('backPressed', function(e) {
						$ionicHistory.goBack();
					//alert('back pressed');
					}).addEventListener('helloPressed', function(e) {
					//alert('hello pressed');
					}).addEventListener('sharePressed', function(e) {
					//alert(e.url);
					}).addEventListener(cordova.ThemeableBrowser.EVT_ERR, function(e) {
						console.error(e.message);
					}).addEventListener(cordova.ThemeableBrowser.EVT_WRN, function(e) {
					//alert(e.message);
					});

					ref.addEventListener('loadstart', function(event) {
						console.log('loadstart');
						$ionicLoading.show({
						content: 'Loading',
						animation: 'fade-in',
						showBackdrop: true,
						maxWidth: 200,
						showDelay: 0
					  });
					//$scope.progressbar = ngProgressFactory.createInstance();
					//$scope.progressbar.start();
					});
					ref.addEventListener('loadstop', function(event) {
						$ionicLoading.hide();
					//alert('loadstop');
					//$scope.progressbar.stop();
					$ionicLoading.hide();
					});
					ref.addEventListener('event_getURL', function(event) {
					//alert('event_getURL');
					});
					ref.addEventListener('exit', function(event) {
					//alert('exit');
					});

 }

if add loader in on event load 'start' its not showing laoder in themble Browser its showing in my actuall view(before page)
how solve this please help me


json file keys get sorted alphabetically during save

The order of the keys should be preserved!

You might want to have a look at the form Schema, as it solves all these signs Afaik

https://github.com/mozilla-services/react-jsonschema-form/blob/master/README.md#the-uischema-object

... yep, good idea! I'll check it out!

it may be too proprietary, but it also may be worth while having a look at it.


Directory suggestions disappear with one use of emulate -L zsh

I'm using the develop branch.
When I hit tab, directory names as completions used to pop up (I have autocd set). Now, they don't.
The issue appears to be the line emulate -L zsh in _zsh_autosuggest_modify in zsh-autosuggestions.zsh. Removing it fixes the issue. No idea why.

Do you get this behavior using zsh -f and sourcing the plugin manually?

Hello, i'm also having this issue (version 0.5.0). using zsh -f and sourcing the plugin does also replicate the issue, deleting the line emulate -L zsh also fixed the issue. My laptop doesn't have this issue even with the line emulate -L zsh though which is weird. I don't really know where the difference is that can cause the bug as my pc and laptop use the same dotfiles. If there's anything i should test let me know

@mnpqraven What version of zsh are you using? And what is the output of setopt?

both machines are on zsh 5.6.2 (x86_64-lc-linux-gnu)
the setopt are also identical
alwaystoend
autocd
autopushd
completeinword
extendedhistory
noflowcontrol
histexpiredupsfirst
histignoredups
histignorespace
histverify
incappendhistory
interactive
interactivecomments
longlistjobs
monitor
promptsubst
pushdignoredups
pushdminus
sharehistory
shinstdin
zle

I have a minimal .zshrc from @Ifnister here that reproduces the issue:
setopt autocd
autoload -Uz compinit
compinit
source /usr/share/zsh/plugins/zsh-autosuggestions/zsh-autosuggestions.zsh

i just tested on the working machine, the issues also appears in zsh -f with manual plugin sourcing

Looks like this was introduced with #360. Will have to find a different fix for #334.

As a workaround for now, you can add expand-or-complete (or whatever is bound to tab (^I)) to ZSH_AUTOSUGGEST_IGNORE_WIDGETS in your .zshrc after sourcing the plugin.
# Check which completion widget you're using
% bindkey '^I'
"^I" expand-or-complete

# Add to your .zshrc
ZSH_AUTOSUGGEST_IGNORE_WIDGETS+=(expand-or-complete)

Going forward, we can probably just add all of the completion widgets to that array, but there may be a way we can fix the issue without having to disable suggestions for those widgets.

Ok @alok @mnpqraven, I've got a fix on branch fixes/autocd-tab-completion (#402). Try it out and let me know if it works?

hi @ericfreese, it seems to be working again now, thank you very much, i'll keep this updated if a run into a bug again

Works for me.


feat: added ServiceFilterMode option for proxy

fixes #389

/cc @kevin-wangzefeng @fisherxu

Please update your PR title.

Need add the default value of ServiceFilterMode in xx:

@siredmar Hello, please also modify the code according to the review suggestion. If there is anything else you can ping me.

@Poorunga modifed according your suggetions. Please take another look

@siredmar Everything is ok, finally please merge your commit.

@Poorunga done squashing all commits

/lgtm

/approve


Parsley accepts tld's with single character

What kind of issue is this? (put 'x' between the square brackets)

[ ] Question. This issue tracker is not the place for questions. If you want to ask how to do
something, or to understand why something isn't working the way you expect it to, use
http://stackoverflow.com/questions/ask .
Provide working code, starting from http://codepen.io/marcandre/pen/jqbzyN?editors=101.
We monitor the tag parsley.js.

[x ] Bug report. If you’ve found a bug, you must provide a minimal example in a CodePen,
starting from http://codepen.io/marcandre/pen/jqbzyN?editors=101 .

[ ] Feature Request. Make sure there's no good way to do what you want first;
consider asking on http://stackoverflow.com/questions/ask first.

example: https://codepen.io/henzestplus/pen/BaBxoJK?editors=101#anon-signup
topleveldomains are at least 2 characters, I am using sendinblue, and they seem to deny e-mail addresses with  a single topleveldomain character.
<EMAIL_ADDRESS>should fail, while<EMAIL_ADDRESS>even though it might not exist, should succeed.Instead, both succeed.

Here is a replacement email address validator I had to create for my project that fixes that problem for the meantime.
// Parsley's email validator allows 1 character for the TLD (after the final dot) while the correct minimum is 2 characters
// this validator (data-parsley-real-email) uses a corrected version of Parsley's built-in RE
window.Parsley.addValidator('realEmail', {
  requirementType: 'string',
  validateString: function(value) {
    return /^((([a-zA-Z]|\d|[!#\$%&'\*\+\-\/=\?\^_`{\|}~]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+(\.([a-zA-Z]|\d|[!#\$%&'\*\+\-\/=\?\^_`{\|}~]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+)*)|((\x22)((((\x20|\x09)*(\x0d\x0a))?(\x20|\x09)+)?(([\x01-\x08\x0b\x0c\x0e-\x1f\x7f]|\x21|[\x23-\x5b]|[\x5d-\x7e]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(\\([\x01-\x09\x0b\x0c\x0d-\x7f]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF]))))*(((\x20|\x09)*(\x0d\x0a))?(\x20|\x09)+)?(\x22)))@((([a-zA-Z]|\d|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(([a-zA-Z]|\d|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])([a-zA-Z]|\d|-|_|~|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])*([a-zA-Z]|\d|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])))\.)+(([a-zA-Z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF]){2}|(([a-zA-Z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])([a-zA-Z]|\d|-|_|~|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])*([a-zA-Z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])))$/.test(value);
  },
  priority: 256
});

I pushed a fix but now my test environment is broken. I don't know when I'll have the time to shave that yak...