Fix deletion of encoded tickets in ticket registries

Lots of TicketRegistry implementations were not encoding ticketId when deleting tickets. This lead to issues like the one described in #2660.
Commit description:

I have added ticket ID encoding where it seem it was missing (some registries had encoding already in place or were fetching encoded tickets and using their id instead).
I have also deleted one ambiguous method on AbstractTicketRegistry. This method was unused and did not state whether the provided ticket was supposed to be EncodedTicket or not.

Additional comments:

It would be nice to have unit tests for encoded registry behavior, but writing such tests is too complex for me.
TicketRegistry implementations don't have single naming / style convention when comes to encoded values. Possible future improvement: refactor registries so that every time encoded ticket or ID is expected, the variable can use enc prefix or something like that.
It is also not clear, whether the log statements should log original ticket ID or the encoded one. Where one registry logs Removing ticket [{ENCODED ID}], other might be logging Removing ticket [{ORIGINAL ID}].

This is very very good. Thank you.
There are test cases in the codebase that handle cases for encoded tickets. Given this is a bit of a sensitive area, I highly recommend you attempt to write at least one test case for the simplest registry you can find to ensure deletes happen correctly.

PS If you need help, LMK and I'll set one for you to see how that could be done.

@mmoayyed I can try to write something, but I would appreciate some consultation. Is it possible to get in touch somewhere? Gitter maybe?

That, or here. Both are perfectly fine.

I am on gitter :). The topic I want to discuss is what the overall approach should be...
Looking at the registry structures, the encoding is reponsibility of the subclasses. So ideally every test should be run with no-op encryption and with a real encryption. I am able to achieve this by parametrizing AbstractTicketRegistryTests (working gist example).
Possible issues with described approach:

This will double the registry tests being run (not sure if that is an actual issue).
Some tests are not extending the abstract test (MemCache registry tests)... maybe they should be refactored to extend the abstract test class.
Some registries are probably not using encryption (Jpa?)... Those might just run non-parametrized.

P.S.: Found new issues with just by playing around with the tests :).

Your gist looks very good to me. No issues and your usage of parameterized tests is also superb.

This will double the registry tests being run (not sure if that is an actual issue).

No problem. The only issue might be that tests take longer to execute :) and Travis might complain. But that's Travis's problem and not ours.

Some tests are not extending the abstract test (MemCache registry tests)... maybe they should be refactored to extend the abstract test class.

They should be, yes. Clean up where you can.

Some registries are probably not using encryption (Jpa?)... Those might just run non-parametrized.

That's fine, or perhaps as an extra bonus we make those support the behavior as well. (Calls for a separate pull request though)
Keep it up.

PS Please do merge with master once you get the chance to make sure all tests can run correctly by the CI instance.

I have rebased branch on top of the current master. I was not able to refactor MemCacheTicketRegistryTests as the registry does not support enumerating stored tickets. Also there are several issues with ticket encryption and I had to disable the tests for few registries as fixing them is not trivial (Ignite and Mongo).
I personally feel like the whole TicketRegistry layer should be a bit refactored. I was thinking about for example doing TicketRegistry and IterableTicketRegistry (allowing for deleteAll, sessionCount, serviceTicketCount and getTickets). Also the common superclass AbstractTicketRegistry might be split into a common superclass and a superclass with encryption support. If encryption is something every repo should support, then I would possibly introduce template methods and not leave the (de|en)cryption to subclasses.
Well... lots of thoughts and all of them are definitely out-of-scope for this PR :).

Outstanding work! Thank you. This is awesome.
As you start going the path of refactoring stuff, please  open up PRs as early as possible so we all could get an idea what you wish to accomplish so we can help you better if needed, and please be mindful of the release policy and breaking API changes. The less of those you have, the quicker we can manage, merge and release.

I this something, that we should backport to 5.1.x? (Not the tests, the core functionality that deals with deleting encoded tickets? If so, could I ask you to take a pass at 5.1 and see how difficult it would be to backport and then submit PR? If too much, please let me know and I can cherry but I'd like it best if you could claim all the credit :)

I this something, that we should backport to 5.1.x?

Well, the symptoms of incorrect deletion are fixed by #2660 . So the only real issue is that registries might experience ticket "memory leak". But that is not that severe because (as far as I understand it) tickets are usually stored with expiration / TTL. Also I did not fix every registry :/ (I left few FIXME comments in unit tests).

please open up PRs as early as possible so we all could get an idea what you wish to accomplish

I will create gist or PR if I find time to pitch something more specific.
Thank you for the merge.

Just a quick update that I have added support for encryption to both mongodb and ignite ticket registries. You may want to review, if that peaks your interest. Probably there are still a few others that lack this support, and they will gradually mature.

In my opinion, it probably should be backported to 5.0.x and 5.1.x


python test error

After a '$ python setup.py test' with nvidia-352 drivers on ubuntu, i have this error:
test_ocl_interpolate_flow_form (tests.test_motion.InterpolateFlowTestCase) ... ok
test_ocl_interpolate_flow_hires (tests.test_motion.InterpolateFlowTestCase) ... OpenCV Error: Gpu API call (CL_MEM_OBJECT_ALLOCATION_FAILURE) in openCLExecuteKernel, file /build/buildd/opencv-2.4.9/modules/ocl/src/cl_operations.cpp, line 413
terminate called after throwing an instance of 'cv::Exception'
  what():  /build/buildd/opencv-2.4.9/modules/ocl/src/cl_operations.cpp:413: error: (-217) CL_MEM_OBJECT_ALLOCATION_FAILURE in function openCLExecuteKernel

Whats's wrong ? Is it a bug ?
Thanx

In the same time, all video files i test with '$  butterflow -r XXX video.mp4' produce a segfault..

It looks like your hardware isn't capable of completing the 4K resolution tests. What is the output of butterflow -d? What are the dimensions of the files you are testing Butterflow with? Can you run these commands without an error?
# Make a 2 sec 640x480 30fps test video and increase rate to 60fps
ffmpeg -y -f lavfi -i testsrc=duration=2:size=640x480:rate=30:decimals=3 \
-c:v libx264 -crf 18 a.mp4
butterflow -r 2x --poly-s 0.1 a.mp4

$ butterflow -d
OpenCL devices:
  Platform          	: NVIDIA CUDA
  Platform Vendor   	: NVIDIA Corporation
  Platform Version  	: OpenCL 1.2 CUDA 7.5.18
    Device    		: GeForce GTX 550 Ti
      Version 		: OpenCL 1.1 CUDA
      Version 		: 352.41

I have always segfault after ffmpeg reencode and test 'butterflow -r 2x --poly-s 0.1'

For resolutions, segfault at all resolutions !!

Your device is not supported. Butterflow only works with OpenCL devices greater than 1.1 with full device profile. I will add in some code that will detect if your device is compatible and issue a warning if it isn't. Thanks.

Only works with opencl ? No possibility to disable GPU to prefer CPU ?

Presently, yes. Two core functions in Butterflow depend on having an OpenCL device (although I do have plans on removing this requirement eventually). You can use a CPU, again, as long as it supports OpenCL 1.2 and up but the output of butterflow -d that you posted suggests that you don't have a compatible device.

Understood. Thanks

No problem. Butterflow will now warn and prevent those with incompatible devices from running the app via bb0c727d5c71dab921be3133ae7dfeb80fe86384. Thanks for bringing this to my attention.

It's now possible to use Butterflow without needing to set up OpenCL. If you're interested in giving this new ability a test drive then checkout the latest master, then make a small test video with ffmpeg -y -f lavfi -i testsrc=duration=0.5:size=640x480:rate=30:decimals=3 -c:v libx264 -crf 18 a.mp4 and run butterflow -sw -r 2x --poly-s 0.1 a.mp4 against it.
But be warned, there's still some bugs associated with the software version of frame interpolation that I'm trying to fix so the accuracy and quality of the frames may be amiss. It's noticeable if you ever try rendering almost anything other than these generated test videos.
Note that with my GPU that video takes .04 minutes to render while it takes 2.14 minutes with the -sw flag. Just something to think about if you're working with any lengthy regions of videos :wink:.

Great news...
But here, after an install git version from scratch i get a "SegFault error"... :(

Is there a way to sort debug info to show you ?


add go-occur-definitions function

Add a function to quick view all the functions and type in a go file
I think that's quit useful for me, and I add a key bind for this 'C-c C-o'
you can have a try -.-
forgive my poor English

Thanks for the pr. I don't think this function will be generally useful to enough people to justify adding it to go-mode.


Improve memory use of read_csv

read_csv falls back to the Pandas implementation for certain situations. This is expensive in terms of memory due to data duplication; first, we create a Pandas dataframe using pandas.read_csv, and then convert it to a Modin dataframe.
The following events fall back to pandas.read_csv and should be fixed to be more memory efficient:

[ ] file does not exist on disk (e.g. located in S3).
[ ] filepath_or_buffer is not an instance of str, py.path.local or pathlib.Path
[ ] file is compressed (high priority)
[ ] as_recarray is True
[ ] chunksize is not None
[ ] skiprows is list-like or callable
[ ] nrows is not None

Most changes need to be done in io.py.
Thanks to @Bidek56 for reporting!

I've assigned myself to this issue for now, but contributions are welcome!

Hi @chvsp! The best starter parameter from the list above is nrows. The first step would be to make sure you fully understand the behavior of the pandas implementation. This will be a great performance improvement as nrows is a very common parameter to be used.
When you feel you are ready to start implementing it, io.py is where this change will go. If you run into problems or questions along the way, feel free to email the dev group. Thanks again for looking into this!

Closing this. Feel free to reopen if the discussion should continue or if issue was not resolved.


Zero damage zone

The player can stay outside the game canvas and gain time without ever having to worry about getting killed.
Source: OBJ_DUMMY_PLAYER » Step

Fixed.


openSettings().then() doesn't wait until user returns from settings

Bug
In version 1.1.1, when I executed RNPermissions.openSettings() the .then() method would not execute until a user came back to the app from settings or the app became in the foreground (atleast in iOS). When I switched to version 2.0.8, the .then() method executes once the app settings have opened. Is there a way to get the old functionality to work again? Thanks.
Environment info
System:
OS: macOS 10.15.2
CPU: (4) x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
Memory: 1.05 GB / 8.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.13.0 - ~/.nvm/versions/node/v10.13.0/bin/node
Yarn: 1.21.1 - /usr/local/bin/yarn
npm: 6.13.4 - ~/.nvm/versions/node/v10.13.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
IDEs:
Xcode: 11.3/11C29 - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.5 => 0.61.5
npmGlobalPackages:
react-native-cli: 2.0.1
React native info output:
N/A
Library version: 2.0.8
Steps To Reproduce

Use and run openSettings() method in app.
...

Describe what you expected to happen:

In version '1.1.' .then() would run after the user has returned to the app from settings in iOS
In version '2.0.8' .then() runs once settings have been launched in iOS

Reproducible sample code
RNPermissions.openSettings()
      .then(() => {
        this.checkPushNotifications();
        // console.log('Finished opening settings');
      })
      .catch(() => {
        this.triggerSnackbar('Error attempting to open settings.');
      });

It's not a bug. On the old version, we have two methods: canOpenSettings and openSettings. Now we have only one that will be rejected if it's not possible.
To perform an action when the app is getting focus back, you can use AppState: https://facebook.github.io/react-native/docs/appstate

Awesome. Thanks @zoontek!

@adteague you can share your solution? Im have a same problem.

@mateussmohamed Here's the abbreviated version...
import {AppState} from 'react-native';

state = {
  appState: AppState.currentState,
}

componentDidMount() {
  AppState.addEventListener('change', this.handleAppStateChange);
}

componentWillUnmount() {
  AppState.removeEventListener('change', this.handleAppStateChange);
}

handleAppStateChange = nextAppState => {
  const {appState} = this.state;
  if (appState.match(/inactive|background/) && nextAppState === 'active') {
    this.checkPushNotifications();
  }
  this.setState({appState: nextAppState});
};

I basically store in the component state when the app goes into the background and then when it becomes active again I check for changes in their permissions (in this case push notifications)

same after added the state controller in component(Screen). My app continues reloading after user changes permissions in IOS settings, only if user changes the permissions. If user dont changes, when back to app the end screen is maintained on previous state.
some possibility this problem be related the React Navigation?

I'm not exactly sure what you are trying to accomplish with your code. The solution I provided worked perfectly for what I was seeking to accomplish; which was to check if there were an permission changes after the app comes back into focus from the background.

My app has a rule, where user can only use if the camera permission is enabled. Case the user denied the ask for the camera permission, a screen is displayed with the explanations regarding the use of the camera. In this screen I execute  openSettings so that user enables the permission. Upon returning to App after the enabled my App is being reloading.
My abbreviated version..
export default function CameraPermission() {
  const [appState, setAppState] = useState(AppState.currentState)

  async function handleOpenSettings() {
    await openSettings()
  }

  const handleAppStateChange = async nextAppState => {
    if (appState.match(/inactive|background/) && nextAppState === 'active') {
      const cameraPermission = await checkCameraPermissions()

      console.log('cameraPermission', cameraPermission)
    }

    setAppState(nextAppState)
  }

  useEffect(() => {
    AppState.addEventListener('change', handleAppStateChange)

    return () => {
      AppState.removeEventListener('change', handleAppStateChange)
    }
  }, [])

  return ()
}

my app flow, for better understanding...

Sorry, I've provided all the insights I know and a solution that should work for everyone. Without having your code/app I can't help any further


reports that the kit fails to run, with zlib errors

Description of the issue

A user is reporting this error, from the use of a 13 year old version of zlib
https://github.com/kkaefer/DEPRECATED-node-zlib/issues/14
I've raised a PR to fix:
https://github.com/alphagov/govuk-prototype-kit/pull/2404

another user has had this issue - seems to be affecting Windows so far

I ran into this too, on MacOS. https://github.com/joelanman/govuk-prototype-kit-prototype got me up and running, cheers @joelanman

Just to add to this - It looks like this is affecting latest node minor versions - node version 18.20.0 it fails, however on version 18.19.0 it works - Same for 20.12.0 it fails but 20.11.0 succeeds. This issue is stopping the creation of new prototypes.

yeh it's weird I can't see how it ever worked, given we are requiring that package, and it is too old and doesn't work
there is a wider bug - the npx govuk-prototype-kit create command is failing silently when this bug occurs, and it shouldn't. I wasn't sure if it was worth raising


Support running benchmarks in separate processes

It should be possible to run benchmarks in separate processes.

PHPUnit generates a "template" file and exports all of the variables.
It should be possible to do something similar, serializing the iteration/subject parameters and having the generated script output serialized results which would then be picked up by the Runner.

Done.


Automatically apply enum types or create struct from results of Multiple Hash Lookup

Currently, when the user resolves an entire block of hashes with the Multiple Hash Lookup command, the only analysis update we make is to add the resolved hashes to the hashdb_strings_{ALGORITHM_NAME} enum type. This means that the user must go back and manually apply the enum type themselves to each of the selected hashes.
We should at least automatically apply the enum type to each value used to resolve the hash. As an extra step, we could also define a new struct type whose size is the same length as the block of selected hashes, and which contains each resolved hash value as a separate field. (This would be the same thing as what the HashDB Ghidra plugin does for multiple hash lookups.)

Would love to see this enhancement added, thank you!


Feature request: JIT

This is a feature request for what may well be another very large performance improvement: JIT compilation.
The idea is simple: Currently, a regex is compiled to bytecode which is then interpreted.  Instead, it can be compiled to native machine code.  It would be nice to support at least x86 and ARM.  The V8 JavaScript engine does this.

It's actually not clear at all that this would be a performance improvement. This regex engine is already reasonably competitive with PCRE2's JIT. (There are benchmarks in this repo, including pcre1, pcre2, oniguruma, tcl and re2.)
Building a good JIT takes years of effort. It should be built outside this crate before we even start the conversation of whether it belongs here or not.

Currently, a regex is compiled to bytecode which is then interpreted.

This is an accurate description of the Pike VM, but the overheard of intepretation is mostly removed in the DFA.


Make the Sandbox truly pluggable

As discussed with @josevalim in #1959, this small PR removes the hardcoded references on Ecto.Adapters.SQL.Sandbox so that one can plug his own version of the sandbox without overriding the existing Ecto.Adapters.SQL.Sandbox.

I have pushed a branch for my sandbox to test out how it works on its own.

https://github.com/jumpn/cockroachdb_sandbox/tree/no-override

I had to provide ensure_all_started and child_spec and I am not entirely convinced I am doing it properly. Would very much appreciate some guidance there.
And beyond that, my sandbox does not work any more:
** (UndefinedFunctionError) function Jumpn.Repo.Pool.__pool__/0 is undefined (module Jumpn.Repo.Pool is not available)
    Jumpn.Repo.Pool.__pool__()
    lib/cockroachdb_sandbox.ex:586: CockroachDBSandbox.proxy_pool/1
    lib/cockroachdb_sandbox.ex:518: CockroachDBSandbox.checkout/2
    (db_connection) lib/db_connection.ex:919: DBConnection.checkout/2
    (db_connection) lib/db_connection.ex:741: DBConnection.run/3
    (db_connection) lib/db_connection.ex:1132: DBConnection.run_meter/3
    (db_connection) lib/db_connection.ex:584: DBConnection.prepare_execute/4
    (ecto) lib/ecto/adapters/postgres/connection.ex:86: Ecto.Adapters.Postgres.Connection.execute/4

For some reason, the repo arg being passed to checkout is Jumpn.Repo.Pool all of the sudden instead of the expected Jumpn.Repo

@tlvenn your pool should be pool: DBConnection.Ownership and set ownership_pool: ToYourCurrentPool.

Ha make sense, i was a puzzled by that and decided to ignore it, I guess I should not have :)
Also i am curious as to how __pool__ got injected into my repo, I dont understand how this is happening.

@tlvenn your pool should be pool: DBConnection.Ownership and your module is just conveniences for working with the pool, nothing more. :)

@tlvenn the __pool__ configuration is injected into the repository by the adapter. There is an open issue to make the __pool__ configuration dynamic and get rid of the __pool__ compile-time injection.

Regarding the __pool__, it is injected when you declare the following?
def __adapter__ do
        @adapter
      end

As for the sandbox, i am not sure I actually understand what you are suggesting. If I define the pool to use DBConnection.Ownership then all the checks we do in the PR will fail to detect we are using a sandbox. Am i missing something ?

Solved the issue by changing back the normalize_pool/1  to:
defp normalize_pool(pool) do
   if function_exported?(pool, :unboxed_run, 2), do: DBConnection.Ownership, else: pool
end

Now my sandbox works properly.
So it seems this is needed for more than backward compatibility.

@tlvenn you are right. We need to figure out a better way to handle this then. I am going to merge your PR as is and then try to come up with a better approach than checking for unboxed_run on normalize_config.

Thanks for the review @josevalim and have a great WE.

The tests are failing with Travis but I cant seem to reproduce it, all the tests are passing on my computer. I have seen that error before but it disappeared after a mix clean. I dont really understand how this is happening given the scope of the changes I made.
The error:
** (UndefinedFunctionError) function Ecto.Adapters.SQL.Sandbox.ensure_all_started/2 is undefined or private
    (ecto) Ecto.Adapters.SQL.Sandbox.ensure_all_started([pool_timeout: 5000, timeout: 15000, loggers: [Ecto.LogEntry, {Ecto.Integration.Repo, :log, [:on_log]}], adapter: Ecto.Adapters.Postgres, url: "ecto://postgres:postgres@localhost/ecto_test", pool: Ecto.Adapters.SQL.Sandbox, ownership_pool: DBConnection.Sojourn], :temporary)
    (ecto) lib/ecto/adapters/postgres.ex:86: Ecto.Adapters.Postgres.ensure_all_started/2
    integration_test/pg/test_helper.exs:68: (file)
    (elixir) lib/code.ex:363: Code.require_file/2
    (elixir) lib/enum.ex:651: Enum."-each/2-lists^foreach/1-0-"/2

It is happening because function_exported? does not load the module. That said, the check you added to normalize_config will never pass, even for the sandbox, because the module has not been loaded yet. So we never rewrite the sandbox pool entry to DBConnection.Ownership.

Hi @josevalim, can you help out on this one, I am not so intimate with how/when module loading works and how to best address this issue. Thanks in advance.

I guess a Code.ensure_loaded(pool) does the trick

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:


Question about iou_smooth_l1_loss_log

When I read the code in iou_smooth_l1_loss_log line118-line135. The loss factor on line 125 is -log(iou)/regression_loss, and the return factor *regression_loss/normalizer is equal to -log(iou)/normalizer. But iou is calculated by cv2, how to calculate the gradient? Thank you！
https://github.com/yangxue0827/RotationDetection/blob/7bffc18703dbf8532199e139949769c5368182d9/libs/models/losses/losses.py#L118-L135

OK！Thank you for your reply!


Initial bryan

Created basic file structure

Front end should connect to basic vite react setup.  Backend unfinished, will fail at index.ts.


Each member of team takes three clubs and works with them to get attendance, feedback, and case studies for this week

This week we've decided to divide the 12 Labs clubs among the 4 of us, giving each of us 3 clubs to work with. Each of us will be responsible for working with our clubs to get attendance, feedback, and case studies for their meetings this week.
What must be gathered from each club for it to be considered successful for the week:

Attendance (with names, emails, and phone numbers) of all attendees
Some feedback from club members (we don't need feedback from every club member, though I think that'd be nice)

This can even be gotten from calls with one or two club members from each club

A recap case study submitted in a pull request

They could submit a Google Doc to us and we covert it to Markdown and submit a PR ourselves
We could get on a call with them and write the case study coursers and submit it as a PR
They could submit the PR themselves

I've created the following issues to track each team member's clubs:

@hellyeah hackedu/meta#247
@jonleung hackedu/meta#245
@MaxWofford hackedu/meta#248
@zachlatta hackedu/meta#246

Closing this because the week ended


Run GPU tests with PyTorch 1.12

What does this PR do?
Use PyTorch 1.12 in Azure GPU CI
Discussed with @Borda
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[n/a] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca the GPU CI with PT 1.12 shall be up and running...


@onResize Modify parameter value

@resizing="(x, y, w, h) => onResize(w, x, y, h)" >
Can I modify the parameter values in this method， i want in other ways modify the "w", but ican't

thanks

I don't know if I fully understand your question. Do you want to programmatically change the value of w, in order to reflect that change also in the component? In this case you can't. Callback arguments are just copies of the original values. If you want to change the value using component props you can check out version 2 of the component on the dev branch, which implements this functionality as well.

thank you!


Override defaultSeverity defined in extended configs

PR checklist

[x] Addresses an existing issue: #2569
[x] Enhancement

[x] Includes tests

[x] Documentation update

Overview of change:
Helping @FelschR to finish the implementation he started in the PR #3240 (AFAIK it's not possible to add commits to somebody else's pull request). I took into account @ajafff's feedback and added the test case.
CHANGELOG.md entry:
[enhancement] Override defaultSeverity defined in extended configs (#2569)

Thanks for your interest in palantir/tslint, @M0ns1gn0r! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Code looks good to me.
I just want to make sure this is what we want. Ping @adidahiya
To summarize the current behavior:

b.json extends a.json

b has a defaultSeverity
b overrides the defaultSeverity of a

d.json extends c.json

only c has a defaultSeverity
d does not inherit the defaultSeverity of c
instead it defaults to "error" while everything from c has the defaultSeverity of c applied

Is there anything left that prevents merging of this PR?

@M0ns1gn0r currently there's nothing you can do. I'd like @adidahiya to sign off the changes I proposed so I know how to proceed after merging this.

@M0ns1gn0r to fix CI you need to merge the latest master into your PR
I'll open a PR based on this one that adds the missing functionality. We can then merge this PR and mine right after that.


RTC: STM32: configure U5xx boards

Adds RTC clock for U5xx based boards.
STM32 RTC does not support years before 2000 (rtc_ll_stm32.c). Excludes the test_y2k test on STM32 boards.
Adds stm32 test cases, configs, & overlays.

Changes regarding RTC are good :) are the failing tests caused by this PR? if so, they need to be fixed :)

Are the failing tests caused by this PR?

No. I pushed a fix for the failing test here https://github.com/zephyrproject-rtos/zephyr/pull/71329


Updated Milestone section and made other minor changes

The Milestone page was not loading, updated it to lookalike mockup
Corrected minor type in Profile page i.e. 'Personal Details' in lieu of 'Personel Details'
Changed the icon next to Name of Event field in Register page as per the mockup

Resolve conflicts


Reuse a CAP Java Service

Tutorial: https://developers.sap.com/tutorials/cp-cap-java-service-reuse.html
Step 6 - Get errors:
user: bookstore $ cds deploy --to sqlite
[ERROR] db/schema.cds:14:56-62: Artifact "sap.capire.bookstore.Books" has no element "author" (in entity:"sap.capire.bookstore.Authors"/element:"books")
[ERROR] db/schema.cds:4:49-71: Cannot find package module '@sap/capire-products'
[ERROR] srv/services.cds:16:33-55: Cannot find package module '@sap/capire-products'
[ERROR] srv/services.cds:5:65-73: Element or variable "category" has not been found (in entity:"BooksService.Books"/element:"genre")
What to do?
BR Michael

@beckermarc Can you take a look at the issue please? Thanks a lot.

@beckermarc Can you take a look at the issue please? Thanks a lot.

Hi @mts2605,
what is/was the output when you executed:
npm install $(npm pack ../products-service -s)

Did you make sure to follow all the steps at the end of the previous tutorial part: https://developers.sap.com/tutorials/cp-cap-java-reusable-service.html -> Step 9: Set up for reuse
Best regards,
Marc

Hi @mts2605,
what is/was the output when you executed:
npm install $(npm pack ../products-service -s)

Did you make sure to follow all the steps at the end of the previous tutorial part: https://developers.sap.com/tutorials/cp-cap-java-reusable-service.html -> Step 9: Set up for reuse
Best regards,
Marc

Hi Marc
Thanks for fast answer.
When looking at step 9 as suggested, after doing the full tutorial one more time, I noticed that the code shown from "your"package.json looks different than the one I see:
Shown below: (Where I, as you can see, have added new name = @sap/capire-products
_
{
"name": "@sap/capire-products",
"version": "1.0.0",
"description": "Generated by cds-services-archetype",
"license": "ISC",
"repository": "",
"cds": {
"requires": {
"db": {
"kind": "sqlite",
"model": "*"
}
}
}
}
_
As I see it, some dependencies and scripts are missing!?
But most important, now it worked anyway;-)
Br,
Michael

Hi Marc
Thanks for fast answer.
When looking at step 9 as suggested, after doing the full tutorial one more time, I noticed that the code shown from "your"package.json looks different than the one I see:
Shown below: (Where I, as you can see, have added new name = @sap/capire-products
_
{
"name": "@sap/capire-products",
"version": "1.0.0",
"description": "Generated by cds-services-archetype",
"license": "ISC",
"repository": "",
"cds": {
"requires": {
"db": {
"kind": "sqlite",
"model": "*"
}
}
}
}
_
As I see it, some dependencies and scripts are missing!?
But most important, now it worked anyway;-)
Br,
Michael

Yes, these were only generated by older versions of our project generation archetype. Meanwhile those are not required anymore.

Yes, these were only generated by older versions of our project generation archetype. Meanwhile those are not required anymore.


WORKSPACE setup instructions for 0.2.6 are incorrect.

rules_pkg 0.2.6 was abandoned and replaced, but the path to the correct package was not updated in the setup rules.
http_archive(
    name = "rules_pkg",
    urls = [
        "https://github.com/bazelbuild/rules_pkg/releases/download/0.2.6-1/rules_pkg-0.2.6.tar.gz",
        "https://mirror.bazel.build/github.com/bazelbuild/rules_pkg/releases/download/0.2.6-1/rules_pkg-0.2.6.tar.gz",
    ],
    sha256 = "aeca78988341a2ee1ba097641056d168320ecc51372ef7ff8e64b139516a4937",
)
load("@rules_pkg//:deps.bzl", "rules_pkg_dependencies")
rules_pkg_dependencies()```

FIxed.


Establish VS Code Workspace

Using workspace config inside dev container, would like to add tasks eventually

nom scripts in package.jsomn accomplish tasks


All css and js files  are added with pre tags

May be is a bug. If relative path used to load css、js、img... They will be loaded like a DOM：

@joket1999  Did you solve this problem?

@joket1999 Did you solve this problem?

No, I've given up.


Error for ApexLSP.

[{
"resource": "/ApexLSP",
"owner": "apex",
"severity": 8,
"message": "Unable to activate the Apex Language Server",
"startLineNumber": 1,
"startColumn": 1,
"endLineNumber": 1,
"endColumn": 1
}]
This is the error. Uninstalled and reinstalled the app and updatesd all the extensions still the errors.MOved the Application from downloads to applications.

/causedByExtension

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!


⚠ Roblox Site (Under Aritifical Testing) has degraded performance

In 51cd9cf, Roblox Site (Under Aritifical Testing) (https://www.roblox.com) experienced degraded performance:

HTTP code: 200
Response time: 3378 ms

Resolved: Roblox Site (Under Aritifical Testing) performance has improved in 0539e96 after 12 minutes.


Error cmd.exe ENOENT

I am experiencing an issue with the l10m Dart translation library when running commands through a VSCode extension made specifically for l10m. The extension identifies which translation file has been modified and runs a command to regenerate the translation for that specific folder. However, this process results in the error: C:\Windows\system32\cmd.exe ENOENT.
This issue only occurs on Windows. I have already added the path C:\Windows\system32 to the environment variables, but the problem persists. Please investigate and address this issue in the library to prevent it from happening.

Fixed in this PR https://github.com/augustodia/l10m_vscode/pull/3


Update latest target to stable core v20.2.0

Update the latest target for quickstart build with stable core v20.2.0.
Also updated xdr and rpc ref for latest build.

When will this be merged?


cookie-factory dependency fails to compile on macOS

Environment

OS: macOS 10.15.4 (19E224g)
rage version: master

% git clone git@github.com:str4d/rage.git
Cloning into 'rage'...
remote: Enumerating objects: 180, done.
remote: Counting objects: 100% (180/180), done.
remote: Compressing objects: 100% (93/93), done.
remote: Total 2087 (delta 102), reused 142 (delta 80), pack-reused 1907
Receiving objects: 100% (2087/2087), 681.39 KiB | 1.96 MiB/s, done.
Resolving deltas: 100% (1268/1268), done.
% cd rage
% cargo build
   Compiling libc v0.2.66
   Compiling typenum v1.11.2
   Compiling cfg-if v0.1.10
   Compiling proc-macro2 v1.0.8
   Compiling byteorder v1.3.2
   Compiling unicode-xid v0.2.0
   Compiling syn v1.0.14
   Compiling memchr v2.3.0
   Compiling getrandom v0.1.14
   Compiling semver-parser v0.7.0
   Compiling lazy_static v1.4.0
   Compiling cc v1.0.50
   Compiling log v0.4.8
   Compiling arrayvec v0.4.12
   Compiling subtle v1.0.0
   Compiling opaque-debug v0.2.3
   Compiling ryu v1.0.2
   Compiling autocfg v1.0.0
   Compiling version_check v0.1.5
   Compiling spin v0.5.2
   Compiling subtle v2.2.2
   Compiling nodrop v0.1.14
   Compiling untrusted v0.7.0
   Compiling byte-tools v0.3.1
   Compiling ppv-lite86 v0.2.6
   Compiling regex-syntax v0.6.14
   Compiling static_assertions v0.3.4
   Compiling fake-simd v0.1.2
   Compiling remove_dir_all v0.5.2
   Compiling unicode-width v0.1.7
   Compiling quick-error v1.2.3
   Compiling base64 v0.11.0
   Compiling cookie-factory v0.3.0
   Compiling arrayref v0.3.6
   Compiling termcolor v1.1.0
   Compiling bech32 v0.7.2
   Compiling thread_local v1.0.1
   Compiling semver v0.9.0
error[E0415]: identifier `s` is bound more than once in this parameter list
   --> /Users/rex/.cargo/registry/src/github.com-1ecc6299db9ec823/cookie-factory-0.3.0/src/internal.rs:144:36
    |
144 |     fn skip(s: WriteContext<Self>, s: usize) -> GenResult<Self>
    |                                    ^ used as parameter more than once

error: aborting due to previous error

For more information about this error, try `rustc --explain E0415`.
error: could not compile `cookie-factory`.
warning: build failed, waiting for other jobs to finish...
error: build failed

This sounds like a new compiler error. What version of Rust were you compiling with?

Latest nightly.

Confirmed that on Ubuntu it builds fine with latest stable (1.41.0), and fails with latest nightly (1.43.0-nightly (07a34df18 2020-02-08)), so this isn't a macOS-specific problem. I'll open an upstream issue.

Opened https://github.com/rust-bakery/cookie-factory/issues/31

The issue is fixed upstream, but a new release has not been made yet. I'll leave this open until we can pull in the updated dependency.


CRUD operations

I just discovered this project, and looks cool, but as beginner I have no idea how to run the crud operations.
I need to create, read (I guess using the find method), update and delete things.
I tried to do:
// store.js
const fortune = require('fortune')
    , nedbAdapter = require('fortune-nedb')
    ;

var f = fortune({
  adapter: {
    type: nedbAdapter,
    options: {
        dbPath: "foo.json"
    }
  }
}).defineType('user', {
    name: {
        type: String
    }
}).defineType('post', {
    message: {
        type: String
    },

    // One-to-many relationship of post author to user posts.
    author: {
        link: 'user',
        inverse: 'posts'
    }
});

f.adapter.create("user", {
    name: "Alice"
}).then(function (data) {
    console.log(data);
}, function (err) {
    console.log(err);
});

But I'm getting:
[TypeError: Cannot read property 'user' of undefined]

What am I doing wrong?

You need to call the connect method before you can do anything. The constructor can't call connect automatically, because it can't know when setup is done.
Maybe this is the wrong approach, and the constructor itself should handle all of the setup, actually it doesn't even make sense to be able to redefine types and transform functions on the fly. In version 2, it will likely fix this and make the setup less confusing and more declarative.

Thanks for quick reply, @0x8890! :sparkles:
I'm posting the working code, just for posterity:
// store.js
const fortune = require('fortune')
    , nedbAdapter = require('fortune-nedb')
    ;

var f = fortune({
  adapter: {
    type: nedbAdapter,
    options: {
        dbPath: "content"
      , autoload: true
    }
  }
}).defineType('user', {
    name: {
        type: String
    },
    posts: { link: 'post', inverse: 'author', isArray: true }
}).defineType('post', {
    message: {
        type: String
    },
    author: {
        link: 'user',
        inverse: 'posts'
    }
});

f.connect().then(function (data) {
    f.adapter.create("user", [{
        name: "Alice"
    }]).then(function (data) {
        console.log(data);
    }).catch(function (err) {
        console.log(err);
    });
    setInterval(function () {
        f.adapter.find("user").then(function (data) {
            console.log(data);
        }).catch(function (err) {
            console.log(err);
        });
    }, 1000);
}, function (err) {
    console.log(err);
});

Calling connect makes sense, but it would be handy to automagically call it when we call crud operations.
Where can I find more fortunejs examples and good practices? From the quick look I see that it doesn't have so many examples...

Nah, instead of magic I think a better error message would suffice ("need to call connect first")
Here's an entire application in ~800 LOC: https://github.com/0x8890/imagenote (should probably add a link to this in the docs)
AFAIK it's used in a few closed-source projects so I can't point to more examples :(

@0x8890 A friendly error would be cool too! I will most probably use this library in one of my projects. If you like I will add more examples (maybe creating the examples directory?).
Thanks!

I got some ideas from your feedback: https://github.com/fortunejs/fortune/issues/157.


Hides language tabs from regional admins

What's this PR do?
Hides the language tabs at the top of /node/edit/ from regional admins
How should this be manually tested?
Edit a node as a regional admin and verify the tabs aren't there.
Any background context you want to provide?
Looked in both menu_alter $items and the node_form alter $form and couldnt find them set in either. Figured this was an easier solution.
What are the relevant tickets?
Fixes #5113

@angaither updated to be more :drupal-y:

@angaither added commmennnttsssss :speech_balloon:

:+1:


PokemonGo-Bot-Start.bat

Improved some things of the batchfile and made the bot selfrestarting in case of some errors.

Thanks but we only accept PR on dev branch.


players and date look very busy next to each other

Our column spacing is generally fine but the right-aligned number against the number in "3 weeks ago" is not right.

This is no longer an issue with "players" and "date" on the main decklist because we removed players but it remains an issue in competitions (players and date) and players (# competitions and record).
I'm not sure if it's a sufficient answer to just make sure any column containing a number is right-aligned. Probably not because the widest of the left-aligned columns will always butt up against the right-aligned number even in that case.

We're in a good state here with grayed repetitions and some work on columns in general.


The getPositionOnRoute have an issue with longer routes and higher zoom

The calculation of the whit dot marker on the path is getting a very anoying offset when you zoom is very high and your path is a bit longer (tested here with 20km) - in Zoom Level 18+ you are not able to grab the dot with your mouse marker - since it's simply "running way"...
The root cause can be found in the fact, that L.GeometryUtil.locateOnLine and L.GeometryUtil.interpolateOnLine are not inverse to each other.
you can take the point calculated from locateOnLine into the interpolateOnLine and you do not get your original location back... I simply "fixed" this issue by copy the original 'locateOnLine' and return all required information in a single step... -> the L.GeometryUtil.closest method is actually that what we have been looking for (IMHO)

Perfect, thanks for pointing this out @marq24 - keep them coming (:


FIX: ensure threads do not leak when #start is called

Periodic instrumentation now follows a general pattern where they
inherit from PeriodicStats.
This implementation ensures proper management of backing thread

All classes inheriting now have a .started? method to determine
if instrument is started

All classes implement a clean .stop method for stopping active
periodic instrumentation

Consumers of the class get to write less code repeat code due
to worker_loop

We're encountering this issue https://github.com/discourse/prometheus_exporter/issues/222 after upgrading to 2.0.1.
Our mitigation: rollback to 2.0.0


feat(ns): update default namespace to "kubearmor"

This PR will

install kubearmor, probe daemonset in "kubearmor" ns
sysdump now checks for kubearmor in all the ns using labels

Related https://github.com/kubearmor/KubeArmor/issues/1167

Please rebase to fix tests.


fix: remove E2E_APPLICATIONS_NAMESPACE env var

Description
remove E2E_APPLICATIONS_NAMESPACE env var from installation script so that build-templates test uses the test framework initialization by default in openshift-ci
https://github.com/redhat-appstudio/e2e-tests/blob/daec5a209de5d01aa9832f8d7074630bc5d43d8e/tests/build/build_templates.go#L42-L55
Issue ticket number and link
Type of change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
in CI 🤷
Checklist:

[X] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

/test redhat-appstudio-e2e


Adds Example Manifests

Fixes #296
Signed-off-by: danehans<EMAIL_ADDRESS>

cc: @arkodg @AliceProxy

Codecov Report

Merging #298 (ec5593c) into main (bca9c19) will decrease coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   58.44%   58.16%   -0.29%
==========================================
  Files          31       31
  Lines        2835     2835
==========================================
- Hits         1657     1649       -8
- Misses       1080     1087       +7
- Partials       98       99       +1

Impacted Files
Coverage Δ

internal/provider/kubernetes/gateway.go
77.04% <0.00%> (-6.56%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Git extension gets preferential handling for naming its statusBarCommands in the Status Bar context menu

https://github.com/microsoft/vscode/blob/5d1faee1610052c3aaca4798e1a7fb3638953386/src/vs/workbench/contrib/scm/browser/activity.ts#L159-L171
If another SCM extension adds more than one command to the status bar the second and subsequent ones list in the status bar context menu with names that include their command ID. For example:

Thank you very much for the feedback. At the moment we are not planning on making any changes related to this.


Rewrite iter_subtrees to more efficient version

Using OrderedDict provides these properties:

given subtree is yielded only once since it's stored in OrderedDict
only once (even though it may be put there multiple times) so no need
to double check if subtree was already seen
order of iteration is preserved as it was previously when subtrees
to iterate over were stored in a list

I've amended commit to avoid the issue with OrderedDict.values() being not usable with reversed in Python 3.4.

I would suggest adding a del queue statement before the second for-loop to reduce the memory footprint.
Also, this algorithm is less efficient since if trees appear more than ones, both copies are added to the queue, despite all the children already being in the queue. The first repetition check is still needed.

Done.

Cool, thanks!


Construct a neural network for hiragana

Construct a neural network for japanese characters (hiragana) that improve the actual results.

Possible idea to increase accuracy, create 3 different neural networks, one to determinate if is a vowel or a consonant, another two to classify vowels and consonants


Migrate to netstandard2.0

For #16
Some tricky cases:

RazorEngine isn't compatible with netstandard. Replate with RazorLight nuget package
GraphRunner has async interface due to async-only interface in RazorLight engine. It's a breaking change. For backward compatibility, was added non-async methods, which are called async methods with GetAwaiter().GetResult(). Such methods can be marked as Obsolete

So, regarding ConfigureAwait. , it make sense only for .Net Framework. In Asp .Net Core SynchronizationContext was removed (http://blog.stephencleary.com/2017/03/aspnetcore-synchronization-context.html)

Oh yeah. Spot on. Still mostly working in framework so forget about things like that.

From: Vadim Hatsura<EMAIL_ADDRESS>Sent: Wednesday, September 26, 2018 9:42:44 PM
To: cake-contrib/Cake.Graph
Cc: Warren; Comment
Subject: Re: [cake-contrib/Cake.Graph] Migrate to netstandard2.0 (#17)
So, regarding ConfigureAwait. , it make sense only for .Net Framework. In Asp .Net Core SynchronizationContext was removed (http://blog.stephencleary.com/2017/03/aspnetcore-synchronization-context.html)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/cake-contrib/Cake.Graph/pull/17#issuecomment-424862899, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AF5xC6RLBgORwnJwJ3IHui-c-0oh9UyIks5ue-bEgaJpZM4W4bJe.

Cool. Looks good. Thanks for your contribution


Need average function implementation

average.js is a module that contains a functions for calculating the average value of an array.
More details are comments on the average.js
file.

I found in averages.pec.js file that you did :
 it("should return negative value for negative elements", () => {
        expect(average([-1, -2, -3])).toStrictEqual((-1 + (-2) + (-2)) / 3);
    });

the array items in the left side are not the same in the right side, is it a typo?

@MenaiAla  i'm very sry i cant implement this i have some work to do

@larbibaraka i'm working on it, i have to pass two tests and it will be done

@boussadjra , sorry for the late message I had some issue with my Internet, yes, I fixed it. Thank you.

@larbibaraka , sorry to assign you without inform you .

@boussadjra , please just follow the COMMITS_TEMPLATE rules for the better convention.

@MenaiAla please let know what i did wrong in order to avoid that the next time

@boussadjra , Sorry I commented before I see your commit, in fact you understand the convention no worries.


Latests commits break openaps on edison with ValueError: Invalid GPIO pin specified error

Multiple users of openaps reported that the latest master checkout causes
ValueError: Invalid GPIO pin specified with openaps. Previous master checkouts didn't have that error.
Latest comit that was ok:
https://github.com/intel-iot-devkit/mraa/commit/e0052acfa7ab441b5417a0fbd010ce77b285a4d8
So the problem was caused by one of the following commits (or the combination):

https://github.com/intel-iot-devkit/mraa/commit/30bbb886850d2a7c55c5803e5c830e5c6cfd2e1a
https://github.com/intel-iot-devkit/mraa/commit/d544e3c2f60ff3dd1b2501fb6e8b4136347675f3

I was able to reproduce this issue after performing installation of the current master branch of oref0 with openaps.
The command producing the error was:
openaps mmtune
Which produced this stack trace:
Traceback (most recent call last):   File "/usr/local/bin/openaps-report", line 82, in <module>     app( )   File "/usr/local/lib/python2.7/dist-packages/openaps/cli/__init__.py", line 51, in __call__     self.run(self.args)   File "/usr/local/bin/openaps-report", line 75, in run     output = app(args, self)   File "/usr/local/lib/python2.7/dist-packages/openaps/cli/subcommand.py", line 52, in __call__     return self.method.main(args, app)   File "/usr/local/lib/python2.7/dist-packages/openaps/reports/invoke.py", line 40, in main     output = task.method(args, app)   File "/usr/local/lib/python2.7/dist-packages/openaps/uses/use.py", line 44, in __call__     self.before_main(args, app)   File "/usr/local/lib/python2.7/dist-packages/openaps/vendors/medtronic.py", line 62, in before_main     self.setup_medtronic( )   File "/usr/local/lib/python2.7/dist-packages/mmeowlink/vendors/mmeowlink.py", line 92, in setup_medtronic     setup_medtronic_link(self)   File "/usr/local/lib/python2.7/dist-packages/mmeowlink/vendors/mmeowlink.py", line 75, in setup_medtronic_link     link = builder.build(radio_type, port)   File "/usr/local/lib/python2.7/dist-packages/mmeowlink/link_builder.py", line 16, in build     return SubgRfspyLink(port)   File "/usr/local/lib/python2.7/dist-packages/mmeowlink/vendors/subg_rfspy_link.py", line 55, in __init__     self.open()   File "/usr/local/lib/python2.7/dist-packages/mmeowlink/vendors/serial_interface.py", line 27, in open     self.serial = spi_serial.SpiSerial()   File "/usr/local/lib/python2.7/dist-packages/spi_serial/spi_serial.py", line 7, in __init__     self.cs0 = m.Gpio(23)   File "/usr/local/lib/python2.7/dist-packages/mraa.py", line 649, in __init__     this = _mraa.new_Gpio(*args) ValueError: Invalid GPIO pin specified
This error seems to occur on any function call involving the radio on the explorer board.
The error also occurs when calling reset_spi_serial:
Resetting spi_serial Traceback (most recent call last):   File "/usr/local/bin/reset_spi_serial.py", line 3, in <module>     s = spi_serial.SpiSerial()   File "/usr/local/lib/python2.7/dist-packages/spi_serial/spi_serial.py", line 7, in __init__     self.cs0 = m.Gpio(23)   File "/usr/local/lib/python2.7/dist-packages/mraa.py", line 649, in __init__     this = _mraa.new_Gpio(*args) ValueError: Invalid GPIO pin specified

I'm looking into this.

In the meanwhile, it would help me if you could post the contents of your syslog log files around the time you get the error. There should be additional output from mraa, which could help me understand this better.

my guess is that the strncmp in x86.c broke it, sometimes reading from sysfs is not what you expect and we may have had some trailing characters we previously ignored. But syslog output would confirm it

@alext-mkrs thanks for looking into this. I created a hotfix for our OpenAPS community to use the latest stable 1.7.0 MRAA version. We shouldn't have releases which depend on GitHub master/dev branches. I only created the fix, and don't have a spare Edison to help you debug this issue at this moment. I'm pretty sure somebody from https://gitter.im/nightscout/intend-to-bolus?at=594e26d26ae41d5d337c3700 will respond soon.

Yeah, no worries, I've found it already - indeed we get the newline symbol attached to the name by getline() we use in x86.c. Looks like we just need to do some more sanitization on the data we get from there. I'm on it.

The fix is coming in PR #772.

Thanks a lot.  Will there be a new MRAA release (with this PR off course) in the coming weeks? At openaps/oref0 we're about to ship a 0.5.0 release and I wonder if we can then ship a 1.7.1 or 1.8.0 MRAA release. I don't know if there are advantages for us, but I noticed the 1.7.0 release is from May.

I'd let @arfoll comment on the release plans, but generally I don't see anything obviously beneficial for OpenAPS, given it's using Edison and the feature set used is stable. Since 1.7.0 there were mainly fixes for static code analysis findings (none were critical though) and some ARM-based platforms and Joule cleanups.

@PieterGit I don't want to rush a release out without testing, there is not much of interest for you for an edison platform anyways as @alext-mkrs mentioned. I'll see if we can't make a release in the coming weeks.
For your use case you should definately be on a stable version of mraa, I'm a little surprised you are using master in the first place, although always happy to get the bugs 👍 and generally mraa master is pretty stable.

Please don't hurry with a release 😄
Most of the OpenAPS users use an Explorer board with Edison. Some still use RPI2/RPI3 (arm based). It was a bug on the oref0 side that master was used instead of a release. We fixed that now with a hotfix / 0.4.3 release.  I' created a PR so that we can confirm that your master branch works with oref0 dev, see
https://github.com/openaps/oref0/pull/507
Can you indicate if the ARM-based cleanups are interesting for our OpenAPS users?

You can see full list of commits here, but as for ARM, there was a RPi fix for setting SPI frequency and an update for BBB to work with newer kernels.


Problem: Interpreter code is in infrastructure, even though most of it is just plain code, no libraries

The interpreter code is in the infrastructure folder, a legacy decision. It should be moved out into the main app folder.
Solution: Move the code and change the namespaces
SuccessCriteria: Existing tests pass

Looking good, closing the issue.


Exclude rebel.xml from the jar

It would be great if the rebel.xml could be excluded from the jar.
When I use this Vaadin Add-on in my project, I get repeatedly an error notification:
Invalid 'dir' defined in class path of rebel.xml (jar:file:.../WEB-INF/lib/vaadin-combobox-multiselect-1.1.14.jar!/rebel.xml): Directory '/Users/thorbenvh8/Documents/workspace/vaadin-combobox-multiselect/vaadin-combobox-multiselect/target/classes' does not exist

done in 1.2.0


Can I ask a simple question here?

[Sorry, I just realized I should have posted this under "Discussions". Headed there now!]

Answered #37 . Discussion welcome!


RAY parallelization fixes

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #1377
What are the significant changes in functionality due to this change request?
Activate the parallel for multi-node approach:

addition of  bash/python scripts to activate "ray start" in remote nodes
addition of shutdown of ray at the end of a parallel calculation
addition of the possibility for RAVEN to read (from the RunInfo) the headNode, remoteNodes IPs for already instanciated (outside) RAY servers (used in Raven Running Raven for example)
addition of the possibility in the RunInfo to specify additional PYTHONPATH to update the system path with (Raven Running Raven)
Modified the test tests/cluster_tests/RavenRunsRaven/code.xml to use the new approach of external instantiation of RAY and internal usage

Activate a "exclusive node approach" for MPI simulator (Here just for discussion since it is very hacky)

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Job Test Ubuntu 18-2 Python 3 on 353cc5d : invalidated by @alfoa

I think we really need a test case so we can see how this works (that is easier to run than the HERON case that lead to this).  I think it probably needs to remove PBS things from the RAVENInterface (or we need to explicitly decide that RAVENInterface is PBS only).  I think we need to think more about magicSyntax and decide what it needs to do, and then figure out the best way to do it.
I think this patch contains several useful improvements, we just need to work on them a bit more so they are easier to support in the future.
Thanks.

Job Mingw Test on 353cc5d : invalidated by @alfoa

Job Mingw Test on 353cc5d : invalidated by @alfoa

The updates and fixes improve things and this pull request is getting better.  I still am trying to understand if we need to add a test or two for this.  (Things like remoteNodes don't seem to be tested at all, but it might be difficult to test this.)

Job Mingw Test on 03892d0 : invalidated by @alfoa

Job Mingw Test on c5bf64b : invalidated by @alfoa

Job Precheck on b380cac : invalidated by @wangcj05
fetch issue

@joshua-cogliati-inl I have resolved the conflicts, can this PR be merged?
In addition, it seems there is an issue with pecheck, SRAW can not be fetched. If you have time, could you take a look at it?

All jobs on b39c252 : invalidated by @wangcj05

All jobs on b39c252 : invalidated by @wangcj05
retesting

Job Test Ubuntu 16 on 1eecb00 : invalidated by @wangcj05
tests/framework/CodeInterfaceTests/RAVEN/Basic failed, retesting

Job Test Ubuntu 18 PIP on 1eecb00 : invalidated by @wangcj05
one failed run for tests/framework/CodeInterfaceTests/RAVEN/ROM, retesting

Job Test qsubs on 1eecb00 : invalidated by @joshua-cogliati-inl
Failed tests/framework/Optimizers/GeneticAlgorithms/mishraBirdConstrained and tests/framework/Optimizers/SimulatedAnnealing/VeryFastSA

Job Test qsubs on c636570 : invalidated by @joshua-cogliati-inl
FAILED: Diff tests/cluster_tests/RavenRunsRaven/Code

Job Test qsubs on c636570 : invalidated by @joshua-cogliati-inl
FAILED: Diff tests/cluster_tests/InternalParallel/test_interal_parallel_ext_model Diff tests/cluster_tests/InternalParallel/test_parallel_scikit_rom Diff tests/cluster_tests/InternalParallel/test_parallel_postprocessor Diff tests/cluster_tests/InternalParallel/test_parallel_msr Diff tests/cluster_tests/InternalParallel/test_parallel_ensemble_picard Diff tests/cluster_tests/InternalParallel/test_parallel_ensemble_linear Diff tests/cluster_tests/InternalParallel/test_hybrid_model_code Diff tests/cluster_tests/InternalParallel/test_parallel_hybride_model_external Diff tests/cluster_tests/AdaptiveSobol/test_parallel_adaptive_sobol

Job Test qsubs on c636570 : invalidated by @joshua-cogliati-inl
FAILED: Diff tests/cluster_tests/RavenRunsRaven/ROM Diff tests/cluster_tests/RavenRunsRaven/Code Diff tests/cluster_tests/InternalParallel/test_parallel_ensemble_picard

Job Test qsubs on c636570 : invalidated by @joshua-cogliati-inl
FAILED: Diff tests/cluster_tests/InternalParallel/test_interal_parallel_ext_model Diff tests/cluster_tests/InternalParallel/test_parallel_scikit_rom Diff tests/cluster_tests/InternalParallel/test_parallel_postprocessor Diff tests/cluster_tests/InternalParallel/test_parallel_msr Diff tests/cluster_tests/InternalParallel/test_parallel_ensemble_picard Diff tests/cluster_tests/InternalParallel/test_parallel_ensemble_linear Diff tests/cluster_tests/InternalParallel/test_hybrid_model_code Diff tests/cluster_tests/InternalParallel/test_parallel_hybride_model_external Diff tests/cluster_tests/AdaptiveSobol/test_parallel_adaptive_sobol


how to remove /index.php/ at all link

You'll have to enable the Apache module mod_rewrite.

ofcause i have enable the mod_rewrite

I have enabled mod_rewrite as well, but I still see index.php. This is frustrating.


Fix hot reloading in a workspace

Fixes hot reloading for child crates in workspaces with the macro and CLI
closes #848

Looks great, thanks!


Adding many AwoX 33957 light bulbs causes NWK_TABLE_FULL etc.

When adding around 30 AwoX 33957 light bulbs, the pairing process starts to fail.
Fx. these log etnries:
info  2023-06-29 17:49:44: 0xa4c138797f2233a6 (0xa4c138797f2233a6): Not supported (Unknown)
error 2023-06-29 18:51:11: Failed to read state of '0xa4c1388faadf4746' after reconnect (Read 0xa4c1388faadf4746/1 genOnOff(["onOff"], {"sendWhen":"immediate","timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":null,"transactionSequenceNumber":null,"writeUndiv":false}) failed (SREQ '--> ZDO - extRouteDisc - {"dstAddr":3631,"options":0,"radius":30}' failed with status '(0xc7: NWK_TABLE_FULL)' (expected '(0x00: SUCCESS)')))
It seems to be a problem directly related to the number of bulbs added to the network. Everything works nicely and pairs quickly until a number of around 30 bulbs is reached. When the critical number of bulbs is reached, all subsequently added devices are recognized as not supported devices.

AwoX devices spam the network, this is already known and listed on the device pages: https://www.zigbee2mqtt.io/devices/33943_33944_33946.html#warning-degrades-network-performance


Add debug with breakpoint configuration to PipelineRun

Based on TEP-0042, this commit will allow users to enable the debug.breakpoints property on any TaskRun resources generated by a PipelineRun
the reconciler will pass any debug.breakpoints properties from the PipelineRun's taskRunSpecs over to the generated resolved TaskRun instances so that per Task debugging can be enabled
Signed-off-by: James Strachan<EMAIL_ADDRESS>
Changes

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Docs included if any changes are user facing
[x] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[ ] Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

/kind feature
/cc @waveywaves @vdemeester

Trying to understand how this would work? debug every resource in a sequence or the order its created in? would this pause the execution of the entire pipeline? how would you resume? do you really need debugging every resource a pipeline creates? or just a step level debug is sufficient, for example, pausing a particular step irrespective of whether its part of a taskRun or a pipelineRun? Of course, a step level debug wouldn't work with pipeline resources.

@pritidesai this PR let’s you enable debugging on a PipelineRun for a named Task, so that when the controller creates the TaskRun, the debug setting is applied. From that point onwards the TaskRun the breakpoint works exactly the same as if you created a TaskRun with the same debug configuration.
If a TaskRun pauses on a breakpoint there is no effect on any other Task in the same pipeline.
Resume works the same as with a TaskRun - running scripts inside the pod.
Basically debug/breakpoints only affect a TaskRun. The reason for this PR is that the tekton controller creates the TaskRun resources if you use a PipelineRun

@vdemeester you mean in the validate code: https://github.com/tektoncd/pipeline/pull/3857/files#diff-1153e019c943846e52e599290b137d535b134d52a5d922e32ed42c5cdefe6f8aR81 or is there another way to mark the debug field as alpha?

@vdemeester I just added alpha validation to the new debug field on PipelineRun.spec.taskRunSpecs https://github.com/tektoncd/pipeline/pull/4145/commits/322a861bd387d9a3056e7fdb7b395642e7dd34f1

here's a little blog and demo of how to use this PR with Jenkins X and Lens to debug pipelines

Thanks for the PR on debug !

@waveywaves how about we allow a global debug setting applied to all Tasks and a per task debug option & a way to merge the 2 structs? So that folks can use one or the other?

how about we allow a global debug setting applied to all Tasks and a per task debug option & a way to merge the 2 structs? So that folks can use one or the other?

@jstrachan
that sounds good :100:
and also I am guessing in this case the individual task debug spec get precedence over the global PipelineRun debug spec ?
@bobcatfish @vdemeester I am not sure, but do we need a discussion around this(maybe in the next working group call) and update to the existing TEP to hash out the details before proceeding ? This level of change where taskRun debug is being enabled through pipelineRuns should be alright initially to let users enable taskRun debug through pipelineRuns. wdyt ?

@waveywaves OK I've added a PipelineRun.Spec.Debug flag in addition to TaskRun specific structs; so you can debug all Tasks with a top level setting or add specific settings on a TaskRun instead

@waveywaves the initial implementation of merge combines the breakpoint names from the PipelineRun.Spec.Debug and the TaskRunSpec[i].Debug. Would  you refer we just use the TaskRunSpec[i].Debug if its specified otherwise use the PipelineRun.Spec.Debug?

@bobcatfish @vdemeester I am not sure, but do we need a discussion around this(maybe in the next working group call) and update to the existing TEP to hash out the details before proceeding ? This level of change where taskRun debug is being enabled through pipelineRuns should be alright initially to let users enable taskRun debug through pipelineRuns. wdyt ?

Indeed, I think we need to update the TEP or do a follow-up TEP on PipelineRun support.

@jerop as you might know, James is no longer working the project. Could anyone on the Teton team try to reimplemented this on top the TEP which now marked as implémentés ? This a great future to have.

@jstrachan @jerop @waveywaves I think it can be reopened and then make some updates:

The TEP is accepted.
There a developing issue: https://github.com/tektoncd/pipeline/issues/5184, but it's closed by bot without completion.

🌹 🌹 🌹


Subsecond timestamps without timezone are not accepted

Subsecond timestamps without timezone are not accepted. select '2019-09-19 08:30:05.123456789'::timestamp9; gives an error:
ERROR:  invalid input format for timestamp9, required format y-m-d h:m:s.ns +tz "2019-09-19 08:30:05.123456789"
LINE 11: select '2019-09-19 08:30:05.123456789'::timestamp9;
                ^
SQL state: 22008
Character: 244

Both timestamp and timestamptz can parse the same string: select '2019-09-19 08:30:05.123456789'::timestamp; => 2019-09-19 08:30:05.123457.

I've added a commit that handles this more gracefully

Hi, thank you a lot for fixing this, but there are still issues with handling different formats of the string. Below are common formats that timestamp supports and timestamp9 does not:

'2022-07-21 12:33:03.123456Z' and '2022-07-21T12:33:03.123456Z' (difference is only in date-time separator)
'2022-07-21 12:33:03.123456789' and '2022-07-21T12:33:03.123456789'
'2022-07-21 12:33:03.123456789Z' and '2022-07-21T12:33:03.123456789Z'

Support for the first case should be easy to add, but I currently have no plans to implement (2) and (3). Up to microsecond, we can let Postgres logic handle the parsing, but when it starts involving nanoseconds currently we just have some simple parsing logic that requires the format 2022-07-21 12:33:03.123456789 +0200

It would be great if you can fix the first case. This should cover my issue for now.
I don’t have an immediate issue with them but I may hit it later. In such case, are you fine if I send a PR to fix them?

Sure, happy to review PRs. First case should be fixed now in master.

Works great! Thank you for fixing it!


External hostname is not updated if an ingress is added after relating a charm to Prometheus

Bug Description
See title. If you first relate to Prometheus and then to Traefik, it all works as expected. The other way around, no cigar.
To Reproduce

Environment

Relevant log output
-

Additional context
We could have used the ingress established/revoked events, but these are unfortunately fired prematurely

Reproduction
After relating a charm to traefik, its metrics endpoint is not updated and prometheus reports health: down because it is no longer reachable via the local ip.

am, prom, trfk deployed and all in active/idle.
juju relate am:self-metrics-endpoint prom

curl <IP_ADDRESS>:9090/api/v1/targets | jq '.data.activeTargets'

"scrapeUrl": "http://<IP_ADDRESS>:9093/metrics",
"globalUrl": "http://<IP_ADDRESS>:9093/metrics",
"health": "up",

juju relate am trfk

curl <IP_ADDRESS>:9090/api/v1/targets | jq '.data.activeTargets'

"scrapeUrl": "http://<IP_ADDRESS>:9093/metrics",
"globalUrl": "http://<IP_ADDRESS>:9093/metrics",
"health": "down",

juju run-action trfk/0 show-proxied-endpoints --wait

proxied-endpoints: '{"am": {"url": "http://<IP_ADDRESS>:80/wlcm2-am"}}'

update-status didn't help because the lib doesn't automatically observe it for sidecars, and alertmanager didn't pass custom refresh events.

Proposal 1
Users of MetricsEndpointProvider must be instructed to always set custom refresh events
self.metrics = MetricsEndpointProvider(
    # ...
    refresh_event=[  # needed for ingress
        self.ingress.on.ready_for_unit,
        self.ingress.on.revoked_for_unit,
        self.on.update_status,
    ]

Proposal 2
MetricsEndpointProvider should always observe update-status by default.
Proposal 3
MetricsEndpointProvider should update relation data every re-init.
I.e. the contructor MetricsEndpointProvider should call self._set_scrape_job_spec every instantiation, instead of registring it as an observer.
Ideas? @dstathis @Abuelodelanada @rbarry82

I think proposal #3 is preferable by far. It's idempotent, users don't have to do anything at all, it doesn't depend on update-status-interval or calling other events, and it can easily be removed from the library constructor when stripPrefix middleware lands in traefik, which makes this problem more or less disappear entirely (at least from an in-model/cluster perspective, as well as any external targets which have routable endpoints and don't need a path specified by any reverse proxy).

Tested manually and the combination of:

https://github.com/canonical/prometheus-k8s-operator/pull/384 and
https://github.com/canonical/alertmanager-k8s-operator/pull/103 (with the modified prom lib)

solves the issue.
With which charm did you experience this @simskij ? You may need to update charm code:

fetch-lib for prometheus_scrape
pass external_url to MetricsEndpointProvider
use correct port number for the job port = urlparse(self._external_url).port or 80

I saw it with the loki datasource in grafana after deploying it as a bundle.

If it's a loki datasource issue then perhaps it's not related to prometheus_scrape?
Maybe we need to manually call update_source in loki?
BTW, update_source seems very different from refresh_event.
@dstathis @rbarry82

Maybe we need to manually call update_source in loki? BTW, update_source seems very different from refresh_event. @dstathis @rbarry82

update_source is just a superset of _set_unit_details which also allows passing additional fields, and was added explicitly for consumers to say "I have an ingress now, so update out-of-band in case GrafanaSourceProvider._source_url from the constructor is out of date".
Since Loki already uses the property in the constructor, update_source would be called when an ingress is added, yes, which allows setting/updating the Grafana relation data immediately after ingress_ready rather than waiting for some other event to re-trigger the constructor. We could do the same thing in grafana_source as is done here, but it would make sense from Loki's codebase to add it just after update_endpoint(...), since the semantics are the same. The Prometheus libraries have just obsessively avoiding having any public API at all which could be used for this purpose.

My bad, I saw it in Prometheus too, but it seems to have been resolved now.


App crashes when not setting a theme

Hey,
first of all: great library! I wanted to use it to just show all licenses for the libraries I use. So I created a very simple Activity extending your MaterialAboutActivity:
class LicenseActivity : MaterialAboutActivity() {

   override fun getActivityTitle(): CharSequence? {
        return getString(R.string.about_title)
    }

    override fun getMaterialAboutList(context: Context): MaterialAboutList {
        val appCardBuilder = MaterialAboutCard.Builder()

        appCardBuilder.addItem(MaterialAboutTitleItem.Builder()
                .text(R.string.app_name)
                .icon(R.mipmap.ic_launcher)
                .build())

        appCardBuilder.addItem(ConvenienceBuilder.createVersionActionItem(context,
                DrawableUtil.getDrawable(context, R.drawable.ic_info_outline_black_24dp),
                getString(R.string.version),
                false));

        val butterknifeLicenseCard = ConvenienceBuilder.createLicenseCard(context,
                null,
                "Butterknife", "2013", "Jake Wharton",
                OpenSourceLicense.APACHE_2)

        return MaterialAboutList(appCardBuilder.build(),
                butterknifeLicenseCard)
    }
}

When I ran my app to try it out it crashed with
android.view.InflateException: Binary XML file line #29: Binary XML file line #29: Error inflating class TextView
                                                       at android.view.LayoutInflater.inflate(LayoutInflater.java:558)
                                                       at android.view.LayoutInflater.inflate(LayoutInflater.java:434)
                                                       at com.danielstone.materialaboutlibrary.adapters.MaterialAboutListAdapter.onCreateViewHolder(MaterialAboutListAdapter.java:43)
                                                       at com.danielstone.materialaboutlibrary.adapters.MaterialAboutListAdapter.onCreateViewHolder(MaterialAboutListAdapter.java:21)
                                                       at android.support.v7.widget.RecyclerView$Adapter.createViewHolder(RecyclerView.java:6367)

So I saw that mal_material_about_list_card.xml is causing the error. In the end it was crashing because I didn't set mal_color_primary resp. I didn't set a theme in my Activity. Adding
   override fun onCreate(savedInstanceState: Bundle?) {
        setTheme(R.style.Theme_Mal_Light_LightActionBar)
        super.onCreate(savedInstanceState)
    }

solved the problem, because it sets all of the required attributes.
While writing this I saw you write in the README to ensure setting a theme that extends one of yours. So I guess that is my own fault. Nevertheless I suggest that you check in MaterialAboutActivity if your attributes are set and, if not, fail with an explaining error message, as I'm probably not the only one that gets depressed seeing an InflateException from your layout file.

Sure! I'll try find some time soon. Thanks


Can this C# project be updated to Mediasoup latest version ?

As the question states I want to get this code up to date with latest mediasoup updates. How can I do that ? I've been googling interoperability between C++ & C# for the past two days but It seems I am out of my depth as I am new to C++ and its build mechanisms. I am willing to contribute to this project, I am just in need of some guidance.

Support, I'm right working on transplanting mediasoup to .NET platform. By the way this lib is so heavy with plenty of public extensions which will lead to 'pollution'.

Where will it be available at ? Can you share repository or something to keep track of it ?

I m sorry to say that it's still having many problems and not been ready for production. But I can tell you whenever it's done.

Where will it be available at ? Can you share repository or something to keep track of it ?

I m sorry to say that it's still having many problems and not been ready for production. But I can tell you whenever it's done.

I'm doing this. :)

I'm doing this. :)

Ohh my god bro, I cant even believe this.

@MOSMekawy @feast107
Please test it.

I can't wait to do it

https://github.com/DearVa/mediasoup-library-build/actions
mediasoup auto build with GitHub Actions, hope this helps. Windows dll is successfully built currently.

Linux so works now. Just fork and Enjoy it :)


New logo/icon proposal

Good day sir. I am a graphic designer and i am interested in designing a logo for your good project. I will be doing it as a gift for free. I just need your permission first before I begin my design. Hoping for your positive feedback. Thanks

Thank you @mansya it's very kind of you! I'm afraid this app actually has an original design including an icon. Hope you can understand that. Thanks a bunch!


Have interrupt handlers pass in CriticalSection token to share resources more efficiently

When entering an ISR in MSP430, interrupts will always be disabled. As such, accessing global resources such as a bare-metal mutex can be done safely without calling interrupt::free, which is required right now. I suggest that the [interrupt] macro be modified to have the signature fn ISR(cs: CriticalSection) so mutexes can be accessed without additional overhead. Using the cs token after calling interrupt:enable is unsound, but enable is unsafe already. Applications that achieve concurrency without using cs, such as RTFM, can simply ignore the token.

Yes, I want to do this as well/agree with it in principle.
Sometimes however, you may want to reenable interrupts within the ISR. There is currently no way to do this with safe code. The rationale for making interrupt::enable() unsafe is that if you call it within a critical section, you violate the invariants of interrupt::free().
I think there should be a separate token type call it InInterruptSection, and both InInterruptSection and CriticalSection implement a trait called InterruptsDisabled. interrupt::free can be parameterized over the InterruptsDisabled trait and since IIRC interrupt::free is always inlined, code duplication of monomorphization doesn't matter.
Then we could create a new function: interrupt::enable_nested(cs: InInterruptSection) that's safe to call within an interrupt. Thoughts?

If we parametrize interrupt::free over InterruptDisabled trait wouldn't that require existing code to add type annotations to closures in the form of interrupt::free(|cs: &ConcreteInterruptSectionType| ...) to avoid ambiguity? We can also pass a cs token into main, since MSP430 starts with interrupts disabled. This way we can use an API like enable_nested(cs) everywhere (perhaps even have it replace interrupt::enable). This also eliminates the need for multiple critical section types.

If we parametrize interrupt::free over InterruptDisabled trait wouldn't that require existing code to add type annotations to closures in the form of interrupt::free(|cs: &ConcreteInterruptSectionType| ...) to avoid ambiguity?

 Indeed, that's a problem.

We can also pass a cs token into main, since MSP430 starts with interrupts disabled. This way we can use an API like enable_nested(cs) everywhere (perhaps even have it replace interrupt::enable). This also eliminates the need for multiple critical section types.

I wouldn't outright replace enable, just in case code that's trying to create an alternate safe abstraction needs it. However, consuming cs probably means that enable interrupts is safe inside a critical section, because without an alternate safe abstraction one can't do (safe!) I/O within a critical section after the interrupts are enabled.
Would like some more eyes on this though (any chance you could idle in Matrix again?)...

With the currently proposed API you actually can't enable interrupts safely inside a critical section because the closure passes in a &CriticalSection, which can't be consumed. I'm actually fine with that because interrupt::free restores previous interrupt settings on exit, so it could disable interrupts implicitly after enabling them inside and cause confusion.
I'm idle on Matrix right now so we can talk more.

Closed by #10


emacs.pkgs.color-theme-solarized: convert to melpaBuild

Description of changes

Part of  https://github.com/NixOS/nixpkgs/issues/278925
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@samuelrivas
Since you are a very sporadic contributor and this package requires low maintenance effort, I took the initiative of removing you from its maintainers list.
Are you still interested in being a co-maintainer of this package?

With #316107, this let argset = ... in ... refactor is not necessary.

Let's wait this land in master...

Closing in favor of https://github.com/NixOS/nixpkgs/pull/325168


Update using-one-time-initialization.md

Change OpenEventHandleAsync in first subsection to OpenEventHandleSync.

@turingcompl33t : Thanks for your contribution! The author(s) have been notified to review your proposed change.


AMBARI-24833. Use seconds instead of minutes for cloud log threshold

What changes were proposed in this pull request?
Use seconds instead of minutes for cloud log threshold
it will be more usable for ambari stack (smart configs)
How was this patch tested?
waiting for UTs

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-LogSearch-Github-PR-Builder/59/
Test PASSed.

i will close this, let's keep as minutes


When trying to load a raid game crashes when deploy timer hits 0

SPT Version
3.10-BE
Project Type
Server
Expected Result
I would expect to load into the selected raid
Actual Result
Game crashes with no error thrown. Happens no matter the map or whether I select Scav or PMC. I nuked and tried twice as well.
Steps To Reproduce

Copy live Tarkov data to SPT-BE
Delete Battle Eye folder
Copy unzipped BE 33420 files to root of SPT-BE folder
Create a developer profile
Select Bear
Launch a raid

Server Log
Click and attach file. ↓
BepinEx Log
Click and attach file. ↓
Client Log
Click and attach file. ↓
Player Profile
No response
Screenshots
No response

Attachments

server-2024-11-05.log (133 KiB)
LogOutput.log (9 KiB)
2024.11.05_22-04-48_<IP_ADDRESS>.33420 traces.log (47 KiB)
672a94610005f5194e5af54d.json (596 KiB)

Originally written by atlas1337

As an additional note I created a second profile with standard edition and had the same issue.

Originally written by atlas1337

Fresh logs incoming. Only the client crashes.

Attachments

2024.11.06_18-53-55_<IP_ADDRESS>.33420 application.log (31 KiB)
2024.11.06_18-53-55_<IP_ADDRESS>.33420 errors.log (1 KiB)
2024.11.06_18-53-55_<IP_ADDRESS>.33420 notifications.log (0 KiB)
2024.11.06_18-53-55_<IP_ADDRESS>.33420 spatial-audio.log (0 KiB)
2024.11.06_18-53-55_<IP_ADDRESS>.33420 traces.log (49 KiB)

Originally written by atlas1337

Attachments

2024.11.06_18-53-55_<IP_ADDRESS>.33420_backend.log (17 KiB)
LogOutput.log (10 KiB)
launcher.log (1 KiB)
server-2024-11-06.log (48 KiB)

Originally written by atlas1337

Tested a raid in live since I haven't played in a few days and live Tarkov doesn't crash. Checked event viewer per Drakia and no errors under Application or System logs

Originally written by atlas1337

Turns out issue was caused by Riot Vanguard

Originally written by atlas1337


Performance comparison

Do you have any recommendations on how to generate those charts because I would like to know how it compares against a regular dictionary.

I just used office/excel. There must be better ways, but for a handful of charts excel was good enough.
I'd expect that regular dictionary is faster, especially on small dictionary sizes and sequential accesses. Not sure by how much though. Might vary by the kinds of keys/values, size of data, pattern of access.


WRP-3423: Add aria-own to prevent read parent page

Checklist

[x] I have read and understand the contribution guide
[ ] A CHANGELOG entry is included
[ ] At least one test case is included for this feature or bug fix
[x] Documentation was added or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added
Tv reads out previous page's header after return the PopupTabLayout page from Input 's Popup
Resolution
It is regression from https://github.com/enactjs/sandstone/pull/1289.
After removing "aria-hidden", the bug occurs.
So I add a wrapper div and set aria-own to prevent read parent page after return the previous page.
It is exactly same way with Alert https://github.com/enactjs/sandstone/pull/813/
Additional Considerations
Screenshot test pass : Jenkins enact-screenshot-tests/1086/
Links
WRP-3423
Comments
Enact-DCO-1.0-Signed-off-by: Jeonghee Ahn<EMAIL_ADDRESS>

Would you please find out if there any better way? As you can see in the alert PR comment, and also in the https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-owns, aria-owns should NOT be used for parent/child DOM.
This is a tricky workaround solution and I don't want to expand this workaround across more components.

In JSX, it looks like a parent/children DOM, but in actual Rendered DOM trees, the two DOM are separate.
Because Popup redner FloatingLayer and FloatLayer attach a dom at div with id="floatinglayer" using ReactDOM.createPortal. Therefore, since the two DOM are separate that do not have a parent/children relationship at all, they need to be connected through aria-owns. So I don't think this method is tricky workaround, and it's an appropriate usage of aria-owns. That's why I it was used in Alert #813.
If you want avoid this method, we should revert #1289 to keep aria-hidden. But when using aria-hidden, I'm not sure why the headings aren't read when returning to the popupTabLayout.


Enable animation on inner nodes of the element and options

Fix #11172

@kurkle I have tried to implement the animation on properties of inner objects in element or options.
This should address the following https://github.com/chartjs/Chart.js/pull/11129#discussion_r1104099648

Set as draft to improve some checks

Set ready for review

This should be checked for performance regressions with large datasets

This should be checked for performance regressions with large datasets

@kurkle  Good point.  What do you suggest to address it? A test case with many elements as fixture or as specs?

This should be checked for performance regressions with large datasets

Just for info. I did a test, locally, with and without this PR, using a scatter chart with 10000 points. I measured the time from beforeUpdate to afterRender, and both cases lasted about 2200ms.
It seems new code is not affecting the current performance. Of course this PR is not affecting the animation stuff because the Animation class is working as before. I'll do other tests.

I'd try to find the breakking points, it used to be somewhere around million points on my old machine, but single dataset could not handle 500M points (if my memory serves). Anyway, with extreme numbers, possible regressions are easier to spot.
Having this in CI is not trivial, because performance of the runnen varies greatly. Would need to run both, master and pr benchmarks in the same runner to get a hint of the performance impact of a pull request.
For me the unknowns are: how to checkout and build both branches and how to report the results.
Also the benchmarks itself require a good amount of consideration for not taking too long but still having good results.

@kurkle I'll do additional tests (if I have time today). I'm not an expert on JS, you know, but I'm trying to use my knowledge on other languages to understand better where we could have a bottleneck based on the amount of data elements.
To be honest, the first implementation I did locally, I was using a Map (and a different flow) instead of an array but, having to check the start name of the property during the scan of the values, I preferred to use an array.
In the Animations constructor (and more in the configure method) I don't see any issue related to the amount of elements because if the properties are path based or not, I don't see any big computation (or many new objects, one for each path property).
Instead, in _createAnimations method, I see a possible issue based on the amount of data elements (even if path properties are not used).
      const matched = pathAnimatedProps.filter(item => item.prop.startsWith(prop));
      if (matched.length) {

With this code, for every animated property (also the normal ones) it returns an "array" (maybe new one, always empty if there is not any path property).
Therefore, for instance, having 100K data elements and 4 animated properties (not path ones, implemented by this PR), passing thru that code we are creating useless 400K "array".
To avoid it, I can change the PR going back to my first local impl where I had 2 cycles, 1 for path props and 1 for normal ones and where those "array" were not created. And I was using Map which should be better performed accessing by an indexed key.
@kurkle what do you think?

@kurkle have a look now. I did some checks and indeed Map is really more performed. The time spent to check if the animation property is flat one or  not, is almost 0 (in my test with 10K). Now I try with more items (try to avoid to crash my FF).

Test with 100K data elements (with the same conditions, FF opened after clearing cache).

Branch
Elapsed rendering time

master
11207 ms

PR 11173
11552 ms

rebased


AlmaLinux 9 testing

We need to make sure that jobsub_lite works well with CentOS8.  Preferably, this should happen before our go-live.

Should we amend this to AlmaLinux 9?

So there should be an AlmaLinux9 image / images for Fermicloud mid-January or so, we should get one setup as a
jobsub_lite node.

Should we amend this to AlmaLinux 9?

Absolutely.

So just to update this ticket; we have an Alma9 instance installed with jobsub_lite.
Unit tests say:
=========== 10 failed, 79 passed, 43 deselected, 15 errors in 24.00s ===========
Most failures are with voms_proxy_init; some others fail because a failed test is not cd-ing back to the test
directory.
However, after updating the cilogon-silver.pem file in /etc/grid-security/certificates, the voms_proxy_init parts
are starting to work(?), and we're down to 2 test failing:

a failure in condor_submit_dag which looks like a condor bug, we get: "Error: Child was terminated by signal 11"
The other, test_get_creds_1, is complaining that the file pointed to by $X509_USER_PROXY doesn't exist(?)...

I'll post a note on fnal.slack.com#jobsub in slack about the test node so folks can get in and test.

So now other than the condor-submit-dag crash, the Alma9 tests appear to be working.

Meeting on 2024-05-08:  condor_submit_dag works fine now (we think).  Will close, and reopen if that's not the case.


Show progress on physical hardware interface

For example, 1 red light could be on if you've just started your Pomodoro session, and it counts up to 3 red lights as you near the end. This aids people in knowing whether they can interrupt you soon.

#19


Your pre-trained model cannot be downloaded

Hello, your pre-trained model cannot be downloaded because the Google Cloud Drive link is invalid. Can we share the pre trained model again? thanks

预训练模型你找到了吗

没有，作者没有回复我

那你配置原始tf的版本成功了吗

这个pytorch版本能用，我就没有配置tf版本

那你有shapenet的预训练模型吗，我就想test和评估一下模型

Hello @wjk158  and @lmc2000,
I apologize for the delay in responding to this issue. Thank you for your patience. Also thank you for your interest in our implementation.
It seems that the pre-trained models have been removed from the provided Google Cloud Drive link. I'm working on recovering these models and will notify you once the models are re-uploaded. If you have any further questions or require additional assistance, please feel free to ask.

Hello @lmc2000 and @wjk158,
I've uploaded the pretrained models to Google Drive and provided the links for download in the README. If you have any issues downloading them, you can let me know. For now, I'm closing this issue.