Blocking behavior not working: useBuyerJourneyIntercept + useApplyCartLinesChange

Packages involved in the issue
@shopify/cli : 3.67.1,
@shopify/ui-extensions : 2024.7.x,
@shopify/ui-extensions-react": 2024.7.x

Describe the bug
When using useBuyerJourneyIntercept to block the customer at the shipping step in conjunction with useApplyCartLinesChange for all line items, the blocking behavior doesn't work as expected.

Steps to reproduce the behavior:

Clone the following repository: https://github.com/AntoineColorz/bug-intercept-buyer-journey/
Run the project (npm run dev)
Use choice_3 (steps as described in the screencast)

Expected behavior
The blocking behavior should prevent the customer from proceeding past the shipping step.

 If I put a blocking without any condition I manage from time to time to pass anyway.
import React, { useState } from "react";
import {
  reactExtension,
  BlockStack,
  useBuyerJourneyIntercept,
  useApplyCartLinesChange,
  useApi,
  ChoiceList,
  Choice,
  Text,
} from "@shopify/ui-extensions-react/checkout";

export default reactExtension(
  "purchase.checkout.shipping-option-list.render-before",
  () => <Extension />
);

const choiceListExemple = [
  { label: "Choice 1", value: "choice_1" },
  { label: "Choice 2", value: "choice_2" },
  { label: "Choice 3", value: "choice_3"},
];

function Extension() {
  const { lines } = useApi();

  const [selectedChoice, setSelectedChoice] = useState("choice_1");

  const applyCartLinesChange = useApplyCartLinesChange();
  const cartLines = lines.current;

  useBuyerJourneyIntercept(() => {
    return {
      behavior: "block",
      reason: "block every time",
      errors: [
        {
          message: "normally you should never pass",
        },
      ],
      perform: () => {
        console.log("🚩 _ BLOCK _ 🚩", performance.now());
      },
    };
  });

  return (
    <BlockStack>
      <ChoiceList
        name="requestedTest"
        onChange={(value) => onChoiceListChange(value)}
        value={selectedChoice}
        variant="group"
      >
        {choiceListExemple.map((choice) => (
          <Choice
            id={`${choice.value}`}
            key={`${choice.value}_key`}
          >
            <Text>{choice.label}</Text>
          </Choice>
        ))}
      </ChoiceList>
    </BlockStack>
  );

  async function onChoiceListChange(value) {
    setSelectedChoice(value);

    const customAttribute = [
      {
        key: "choice",
        value: value,
      },
    ];

    for (const cartLine of cartLines) {
      await applyCartLinesChange({
        type: "updateCartLine",
        id: cartLine.id,
        attributes: customAttribute,
      });
    }
  }
}

https://github.com/user-attachments/assets/636062e5-d8dd-49de-ad75-967d6168f451


BUG: Incorrect file path

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Incorrect file/image path of Human Resource

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

please @PatilHarshh assign this to me


Step-by-step guide how to create your plugin

I would like to create fileHandler plugin, but there is no set-by-step guide on how to do it.
Found only this page - https://scully.io/docs/plugins
Examples are good, but it appeared still not enough for me

@aaronfrost I've been working on an article/guide with @SanderElias for this. It's almost done.

@aaronfrost I've been working on an article/guide with @SanderElias for this. It's almost done.


Add support for a card based layout, as described in the TcMenu main repo

See https://github.com/davetcc/tcMenu/issues/308

Tested and working enough that any issues raise can be dealt with separately.


Wrong node allocation description

When using the -L/--list-detailed in order to get detailed information about one of my self-backed tests, ReFrame reports the following:
...
    Node allocation:
      standard (1 task(s))
...

This is misleading information because I have the following seam in my code
...
    @rfm.run_after('setup')
    def set_num_tasks(self):
        if self.current_partition.fullname in ['daint:gpu', 'dom:gpu']:
            self.num_tasks = 72
            self.num_tasks_per_node = 12
            self.num_cpus_per_task = 1
...

I do not know what to do here, because I understand that the information is taken from after init.
And if ReFrame executes all steps up to compile (excluding compile) to display the information, I could still write:
...
    @rfm.run_after('compile')
    def set_num_tasks(self):
        if self.current_partition.fullname in ['daint:gpu', 'dom:gpu']:
            self.num_tasks = 72
            self.num_tasks_per_node = 12
            self.num_cpus_per_task = 1
...

One cannot execute compile to give me the -L flag because in this particular case, for instance, it takes 20 min to compile the test... 😄
My proposal is to either remove this entry from -L or change the wording, in case, there is a hook for any other phase after init. An example would be
...
    Node allocation (assumed):
      standard (1 task(s))
...

The word assumed has to be replaced by a better word, but you get the idea.

As you mention, the information printed in the detailed listing is before running the test, i.e., before entering the setup(). Technically, this is not a bug, but perhaps not well documented. ReFrame tests can be very dynamic, so there is no way to get accurate information after they are initialized. Suggesting to remove this raises the question, why then not remove all other detailed information, since this can also be defined entirely outside the __init__()! If we keep the minimum that can be defined, then we will end up reporting only the valid systems and valid programming environments.

Ok, this is valid. What about printing something like that if there are hooks?
    Node allocation:
      standard (1 task(s) -- may be set differently in hooks)


pylivy sessions with hive

Hi!
Im trying to start livy sessions with hive:
from livy import LivySession

import datetime

LIVY_URL = "http://mylivy:80"

with LivySession.create(
        LIVY_URL,
        jars=[
            "gs://mybacket/hotfix/jars/iceberg-spark3-runtime-0.9.0.jar",
            "gs://mybacket/hotfix/jars/spark_etl-1.0-SNAPSHOT.jar",
            "gs://mybacket/hotfix/jars/spark-bigquery-with-dependencies_2.12-0.17.3.jar"
        ],
        py_files=["gs://mybacket/hotfix/dags/package.zip"],
        num_executors=1,
        name=f"add-attribution-window-hours-{datetime.datetime.now()}",
        spark_conf={
            "spark.kubernetes.container.image.pullPolicy": "Always",
            "spark.kubernetes.driverEnv.ETL_ENV": "prod",
            "spark.executorEnv.ETL_ENV": "prod",
            "spark.kubernetes.driverEnv.HIVE_CONF_DIR": "/opt/spark/conf/hive-site",
            "spark.sql.warehouse.dir": "gs://mybacket/hive/",
            "spark.sql.catalogImplementation": "hive",
            "spark.kubernetes.driver.secrets.hive-site": "/opt/spark/conf/hive-site",
            "spark.executor.memory": "16g",
            "spark.executor.cores": "6",
            "spark.eventLog.enabled": "true",
            "spark.kubernetes.namespace": "default"
        }
    ) as session:

    # Run some code on the remote cluster
    session.run("spark.sql('show databases;').show(20, False)")
    # Retrieve the result
    #local_df = session.download("df")
    #local_df.show()

but 'show databases' in hive always empty (like local empty hive-metastore)
in log i see its trying to start hive:
21/12/01 12:22:24 INFO SharedState: Setting hive.metastore.warehouse.dir ('null') to the value of spark.sql.warehouse.dir ('gs://mybucket/hive/').
21/12/01 12:22:24 INFO SharedState: Warehouse path is 'gs://mybucket/hive/'.
21/12/01 12:22:26 INFO CodeGenerator: Code generated in 267.63079 ms
21/12/01 12:22:26 INFO CodeGenerator: Code generated in 11.710265 ms
21/12/01 12:22:26 INFO CodeGenerator: Code generated in 17.16884 ms

when i start livy batch with same spark_conf, always working fine, i have access to all tables, and log looks like that:
21/12/01 09:29:03 INFO HiveConf: Found configuration file file:/opt/spark/conf/hive-site/hive-site.xml
21/12/01 09:29:03 INFO HiveUtils: Initializing HiveMetastoreConnection version 2.3.7 using Spark classes.
21/12/01 09:29:03 INFO HiveConf: Found configuration file file:/opt/spark/conf/hive-site/hive-site.xml
21/12/01 09:29:03 INFO SessionState: Created HDFS directory: /tmp/hive/root
21/12/01 09:29:03 INFO SessionState: Created local directory: /tmp/root
21/12/01 09:29:03 INFO SessionState: Created HDFS directory: /tmp/hive/root/c42cf693-a56b-44d4-8b4f-5b67ed85c721
21/12/01 09:29:03 INFO SessionState: Created local directory: /tmp/root/c42cf693-a56b-44d4-8b4f-5b67ed85c721
21/12/01 09:29:03 INFO SessionState: Created HDFS directory: /tmp/hive/root/c42cf693-a56b-44d4-8b4f-5b67ed85c721/_tmp_space.db
21/12/01 09:29:03 INFO HiveClientImpl: Warehouse location for Hive client (version 2.3.7) is gs://mybucket/hive/
21/12/01 09:29:04 INFO metastore: Trying to connect to metastore with URI thrift://myhive-metastore.us-north1-a.c.myproject.internal:9083
21/12/01 09:29:04 INFO metastore: Opened a connection to metastore, current connections: 1
21/12/01 09:29:04 INFO metastore: Connected to metastore.

how to correctly set hive-config for livy sessions?

answer:
in config just set
livy.repl.enable-hive-context = true
and hive enabled on sessions


[doc improvement][property description update]

Please review.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema.md
86
94
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit f1a21f2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema.md
86
94
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 3189cc4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema.md
85
96
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit a4682c6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


The 20211102.0 version uses unpublished GTEST_FLAG_GET macro from googletest

Describe the bug
In the 20211102.0 version of abseil-cpp some of the test code started using the GTEST_FLAG_GET macro. This causes the following build failures when attempting a CMake build with a pre-installed, latest released version (1.11.0) of googletest:
[ 47%] Built target absl_cord_internal_test"
absl/strings/cord_ring_test.cc: In function 'absl::lts_20211102::{anonymous}::Composition absl::lts_20211102::{anonymous}::RandomComposition()':"
absl/strings/cord_ring_test.cc:278:35: error: 'random_seed' was not declared in this scope; did you mean 'random_r'?"
  278 |   RandomEngine rng(GTEST_FLAG_GET(random_seed));"
      |                                   ^~~~~~~~~~~"
      |                                   random_r"
absl/strings/cord_ring_test.cc:278:20: error: 'GTEST_FLAG_GET' was not declared in this scope; did you mean 'GTEST_FLAG'?"
  278 |   RandomEngine rng(GTEST_FLAG_GET(random_seed));"
      |                    ^~~~~~~~~~~~~~"
      |                    GTEST_FLAG"

After taking a look at the GoogleTest GitHub repository it seems, that the changes introducing this macro are only present in the main branch but haven't been packed into an official release, yet.
Steps to reproduce the bug

Install the 1.11.0 version of GoogleTest.
Configure the abseil-cpp build with CMake (version >= 3.20.0) and the -DABSL_FIND_GOOGLETEST=ON -DABSL_USE_EXTERNAL_GOOGLETEST=ON -DBUILD_TESTING=ON options.
Build with make.

What version of Abseil are you using?
20211102.0
What operating system and version are you using
Docker container on a Ubuntu 18.04 host.
What compiler and version are you using?
gcc: 9.1.0
What build system are you using?
cmake: 3.21.4
make: 4.2.1
Additional context
None.

Now I've also noticed that this version of abseil-cpp is also relying on ::testing::Conditional, which is GTest matcher, which also didn't make it to any official release, yet. After providing a dummy macro for GTEST_FLAG_GET and removing the use of ::testing::Conditional the project built along with all tests, so I think those are the only two.

The June 2022 release addresses this issue. A coordinated GoogleTest release was done to ensure compatibility, and our release documentation has been updated so ensure future releases are coordinated as well.

I fell behind is it corrected?


The break lease activity logs display for non-leased blobs when breaking lease for multi blobs that contain non-leased blobs

Storage Explorer Version: 1.21.0-dev
Build Number: 20210826.2
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Big Sur 11.4
Architecture: ia32\x64
How Found: Ad-hoc testing
Regression From: Not a regression
Steps to Reproduce

Expand one storage account -> Blob Containers.
Create a blob container -> Upload two blobs.
Acquire lease for one blob -> Select the two blobs.
Break lease -> Observe only display break lease activity log for the leased blob.

Expected Experience
Only display break lease activity log for the leased blob.
Actual Experience
Display break lease activity logs for the two blobs.
Additional Context
This issue also reproduces when acquiring lease several blobs which contains leased blob.

Hi, it sounds like you are having self signed certificates issues. We have to recommended paths forward for you:

Try using system proxy, which you can read about in our networking documentation: https://docs.microsoft.com/en-us/azure/storage/common/storage-explorer-network There are some limitations to it, so make sure you understand those.
Try setting certificates manually. You can read about this process in our troubleshooting guide for additional help with that: https://docs.microsoft.com/en-us/azure/storage/common/storage-explorer-troubleshooting?tabs=Windows%2C2004#ssl-certificate-issues
If neither of those help feel free to come back here to let us know what happaned.

This is by design.

@MRayermannMSFT I checked this in Portal, It just displays the number of the blobs that actually Acquire/Break lease.


Configuration of local directory path

I want to deploy single directory from project. How to configure local directory path?
It is possible to configure multiple directories? For example:
project
|-dir_one -> sftp://remote/path/one
|-dir_two -> sftp://remote/path/two
|-dir_local_only
|-README

The best way to do this would be to have a .ftpconfig file in each directory. And then open each in atom in separate windows or in the same window if you have the multiple hosts feature ticked in settings.


bug(Datepicker): NVDA keyboard interaction not working according to documentation

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
NVDA keyboard interaction for the calendar popup is not according to the documentation.
JAWS works well.
Reproduction
StackBlitz link: Can be reproduced on the Angular Material website: https://material.angular.io/components/datepicker/overview#datepicker-overview
Steps to reproduce:

Using the keyboard, open the datepicker popup
Press the right arrow
Press the down arrow

Expected Behavior
When pressing the right arrow, the next day should be focused.
When pressing the down arrow, the same day in the row below (next week) should be focused.
Actual Behavior
When pressing the right arrow, NVDA reads the current month letter by letter.
When pressing the down arrow, the next day is focused.
To get a bit more of a correct behavior, press Alt + arrows to get closer to the interaction described in the documentation (e.g. Alt  + Right Arrow focuses the next day). Sadly, Alt + Arrow Up closes the popup.
Environment

Angular: 16.2.0
CDK/Material: 16.2.0
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows
NVDA: 2023.1 (2<IP_ADDRESS>913)

Hello folks,
Thank you for reporting accessibility issues.

NVDA keyboard interaction not working according to documentation

There's is no requirement that keyboard functionality is the same when using datepicker with Assistive Technology (Screen Reader). Screen Readers implement their own keyboard functionality and the specifics are usually an implementation detail of the screen reader.
Please let us know if you have an accessibility criteria, such as WCAG, or explanation why it is a problem for the user.
If you would like support, I suggest using the support chanels, which are StackOverflow, Gitter, and Google Groups. We can give a limited amount of support in this issue tracker.
Best Regards,
Zach


[v3alpha] An issue with the working of draft connection

In ConnectionGraphicsObject on mouseMove event you transfer self to hovered node for reaction:
ngo->reactToConnection(this);
This connection is using in NodePainter::drawConnectionPoints for painting ports. And you reset this pointer at the end of this method.
But sometimes mouseRelease event of ConnectionGraphicsObject and corresponding destroying of draft connection happens before NodePainter::drawConnectionPoints call.
So sometimes NodePainter accesses the destroyed pointer.
I think you need to let the scene set reaction connection to nodes and tracks for it destruction.

Thanks for pointing this out, I'll have a look in the nearest days.

I used QPointer, it is cleared automatically when the object inside is destroyed.
To me the two options were not clearly distinguishable. ItemPositionChange, ItemPositionHasChanged. Now I see the difference.

Thanks for your valuable and inspective remarks!


Cannot read property 'getRemainingTime' of null

please add verification for adsManager in onAdPlayheadTrackerInterval.
{snip} totype.onAdPlayheadTrackerInterval=function(){var e=this.adsManager.getRemainingTime(),t=this.currentAd.getDuration(),n=t-e;n=n>0?n:0;var i= {snip}

It should never be the case that AdsManager is null in this function. How do you reproduce this error?

I can't reproduce this error self, but I see that this happens in 3% of users.

looks like it happens on midroll state immediately after "reset".
do you have idea why reset doesn't clear interval?

Hi @onix-sergey ,
It looks like this issue may have been resolved with https://github.com/googleads/videojs-ima/pull/814 .
I am going to close the issue, but if that is not the case, please feel free to reopen so I can look into fixing it.


AttributeError: module 'skvideo.io' has no attribute 'VideoCapture'

getting this error while running the preprocessing file (both scripts)

Make sure you have installed skvideo module.
There is some problem with the lib I use. I am not sure the updated version is better.

i have installed skvideo.Still i am getting the error!!!
visakh@visakh-Inspiron-5521:~/Documents/Main Project/Fall-Detection1/Preprocessing$ python3 preproc_batch.py
Traceback (most recent call last):
  File "preproc_batch.py", line 17, in <module>
    cap = sv.VideoCapture(data_path + fn)
AttributeError: module 'skvideo.io' has no attribute 'VideoCapture'

i have no problem importing skvideo

visakh@visakh-Inspiron-5521:~/Documents/Main Project/Fall-Detection1/Preprocessing$ python3
Python 3.5.2 (default, Nov 23 2017, 16:37:01)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import skvideo

Hope you are doing well.
My vm is down so I cannot reconstruct the environment.
What I remind is the module I install is scikit-video(It seems the old version of skvideo). I am not sure they have already fixed the bug and merge these two packages yet.
Try
 $ sudo pip install scikit-video

Hope it works for you. If not, I suggest using other library to open the video.


Force login for user

i want Always ask for enter credentials when open a base url even the user already previously.
tried
export const loginRequest = {
scopes: ["user.read"],
prompt: 'login',
}
this.authService.loginPopup(loginRequest);
this is not working for me

Have you tried prompt: 'select_account'?
Additionally, in the future, please fill out the provided template, as it helps us diagnose issues better.

@jmckennon also with
this.msalService.loginRedirect({       prompt: 'select_account'     });
it does not work, the prompt seems to be ignored

@Shyam268 @Saxy We've been unable to reproduce this issue, can you both provide your msal configurations and versions?

msal version is 1.3.4
msal configuration
export function MSALConfigFactory(config: AppConfigService): Configuration {
  const appSettings = config.getConfig(config.APP_SETTINGS);
  const authentication = appSettings.authentication;
  const auth = {
      auth: {
          clientId: authentication.clientId,
          authority: authentication.b2cPolicies.signUpSignIn.authority,
          redirectUri: appSettings.redirectUri,
          postLogoutRedirectUri: appSettings.postLogoutRedirectUri,
          navigateToLoginRequestUrl: false,
          validateAuthority: false,
      },
      cache: {
          cacheLocation: authentication.cacheLocation
      }
  };
  return (auth as Configuration);
}

Since you're using B2C, I would recommend also filing a ticket with the B2C service team.
Are you using a social/third party IDP or a local login? Sometimes social IDPs (i.e. Google) can automatically redirect without our given parameters, which is my guess to what is happening here. I would recommend taking a look at network traces to see which params are getting sent, and you can send a fiddler trace to the email on my profile if you'd like help diagnosing.

Closing this as we're assuming the original problem has been solved due to inactivity, please open a new issue if you have further questions. Thanks!


new benchmarks

I'm going to remove some code duplication. But this should provide us more info in order to optimize protodef.


Add .htaccess so permlink works when restart container.

When for any reason that the container was restarted, the permlink does not work until you visit the url /wp-admin/options-permalink.php
I inspected the code and turns out it just generate a .htaccess file.
Add this file ensure that the permlink works from the beginning.

Thank you


How can I get access to frontmatter in __layout.svelte?

Hi,
I setup vite-plugin-svelte-md with success in a SvelteKit project: https://github.com/stephane-klein/sklein.xyz/tree/c4e80fe6abe621f68e669dd5a375ef01eda92470
Question: here, how can I get access to markdown frontmatter in __layout.svelte?
Suggestion: what do you think to document this method in README.md?
Best regards,
Stéphane

@ota-meshi an idea?

__layout.svelte may be deprecated, but for now I think you can get the frontmatter with:
<script context="module">
  const docs = import.meta.glob("./**/*.md")

  /** @type {import('@sveltejs/kit').Load} */
  export async function load({ url }) {
    const key = `./${toMarkdownPath(url.pathname)}`
    if (docs[key]) {
      return {
        props: {
          frontmatter: (await docs[key]()).frontmatter,
        },
      }
    }
    // ...
  }
</script>

Suggestion: what do you think to document this method in README.md?

The document may be of value after the Svelte Kit reaches GA.

@ota-meshi thanks ♥
Question: where is defined toMarkdownPath?

toMarkdownPath function depends on your environment. (Such as slashes and baseURL.)
It's a function that converts a URL's PATH to a markdown PATH.


Possible cause of game crash

I think the mod might be the cause of 2 type of crashes I had recently (had no crashes before installing it).
One of the game crashes happened after pressing end turn (~ turn 161) and it just quit the game without any error message.
Here is a link to the game save which causes the crash on my computer: https://dl.dropboxusercontent.com/u/25584776/quicksave.Civ6Save
I don't know where to look for crash logs so I hope this save file might be useful for figuring out if the mod was the cause of the crash. This mod and the default Aztec mod pack were the only mods running during that game.
The other crash happend with a city located right on the left border of the map in the upper left corner. Whenever I entered that city with my unit to conquer it the game would just exit to desktop. I'll see if I can find a save for that.
The crash happens with current last version of the mod also.

That's a pretty big deal, I'll start testing the save right away to see if I can replicate. I get the feeling that this may be due to the popup queue not being handled properly when they're disabled, were you playing with or without popup visuals enabled? As far as personal experience goes, I have a ~130 turn game going on started with the mod and I've suffered no instability. Just out of curiosity, how much RAM does your system have?

Where do I find the setting for the pop-up visuals? My system has 16 GB of RAM.

These are the game executable stats before pressing end turn button: http://i.imgur.com/J92QobF.png

Is there any way to disable an existing save from requiring the mod to load? Just to see if it would crash without it. Since this is only an UI mod there should be no reason for it to always be loaded (required for a save to load).

I believe there's a way to do it using firetuner from the civ 5 sdk

Are you able to reproduce the issue on your machine? I don't even know if saves load across different machines or operating systems.

Yes, I just tested the savefile and it crashes after ending the turn. I'm going to attempt disabling the mod file now and trying again to see if that affects the outcome

Cool, I'm glad it can be reproduced. I tried going back a few autosaves to see if maybe it will not crash when reaching same point but it still crashed.
Hmmm, I seen the Tuner option in the game settings but no idea how to use it once enabled.

Alright, after taking a few stabs at getting the game to disable the mod in your save, I've found no success. That's rough, but I've got no real docs to work with here.
Instead, I've created a dummy version of my mod that the game will accept, but doesn't actually load any files on top of the base game. This is effectively the same as removing the mod. The game still crashes when the turn is passed, even when there's absolutely zero trace of the mod.
That being said, this kind of all points to it not being the mod's fault, unless it's somehow had some kind of persistent detrimental effect upon your save

I think you are right, it might not be the mod. I searched for the previous save which had the crash issue when conquering the city and at that point I did not have the mod installed, it crashed with no mods except aztec. Seems like a bug in the game itself. I'd forward the bugged saves to the devs if I'd knew where to do that.
Thank you for your investigation.

Ah, did you also clear the cache folder after using the empty mod replacement? I think there might be some settings that might interfere if C:\Users\Razvan\Documents\My Games\Sid Meier's Civilization VI\Cache is not cleared
Would it be possible to give a link here with the empty replacement mod so I can try too? (might be useful to test bug causes for other mods too later)

I've cleared my cache and attempted to pass again with the stubbed mod, still crashed for me.
Here's the link to the stubbed mod files so you can try yourself

Oh by the way, the file manifest is the part that's stubbed, I just left the files in because it didn't matter. If the files aren't listed in the *.modinfo manifest they might as well not exist. I confirmed the files weren't loaded in-game by checking menus like the GP Panel to see if they were Vanilla or CQUI (they were the vanilla when checked, confirming the in-game behavior was not being overridden)

The only persistent efefct I could imagine would be the custom map pins that I implemented. Have you used those district map pins by any chance?

@jacks0nX Yes, I did use map pins to plan where to place districts and deleted some if not most of them as I placed districts. But I did not place the pins with the new icons since in that mod version the new icon pins were not there yet.

I checked the save, at that point of the game all the pins added have been removed.

Alright then, I'm going to leave this issue open for a little while longer while you test, but I am going to be removing the bug tag and setting it as invalid for now since it seems to be mostly resolved. Normally I'd wait until I had full confirmation, but I need to get to sleep and I don't want this sitting at the top of the bug tracker with a scary bug tag still on it for the next 8 hours

I tested with the stub mod after deleting cache. It's ok to close it as it is most certainly not caused by the mod. Thank you

Alrighty then, sorry about the loss of that save file, it looked pretty fun! Thanks for being so helpful in investigating, reports like yours are the gold standard and I'll never not appreciate receiving them. Have a pleasant day!

I am really glad that the issue was not caused by this mod as I already got used to how much easier it makes gameplay and was dreading not using it just to not get a bug again. Thank you for your work on it


Remove assert that AppCheckListener is always registered

This fixes a regression in https://github.com/firebase/firebase-ios-sdk/pull/8898

FYI There still seems to be a test failure related to the previous PR. Will look in 30 minutes.

@schmidt-sebastian @paulb777 I would be more comfortable to go for release only once we have comprehensive code coverage for the cases when App Check or/and Auth are not installed in an app.


Clean Code 101

press ctrl + alt + L to auto format code in IntelliJ.

PR opened to wrong repository, please ignore.


minor change the pull request template

feat(pull-request-template):
Added minor changes in the template of pull request.
Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA
[x] Lint and unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Hi @brf153, thanks for the contribution! 🚀 💯
Sorry, we're not planning to make the checklist visible, because of that, I'm closing this one!


Issue when importing entities with filters with and without correlationid

Hi,
I am using ServiceBusExplorer-4.1.112.
When trying to import Entites with rules for Topics getting an error
"the key is not found in the dictionary"
When went though the code found this line in "ImportExportHelper.cs"
string Correlationid = "Correlationid";
 if (filter.Name == string.Format(NodeNameFormat, Namespace, CorrelationFilterEntity))
            {
                ruleFilter = new CorrelationFilter(propertyValue[Correlationid] as string);
            }

Its not able to find CorrelationId with a capital "I".
It works if changed to
string CorrelationId = "CorrelationId";
And this variable is only used in import helper.
This is a part of bigger issues where It is assuming that filter has correlationid.
My filter had only label so had to replace corerelationid with label, to make it work.
ruleFilter = new CorrelationFilter(propertyValue[Label] as string);
May be this is an enhancement.
Thanks
Karteek

Hi @kart33k sorry for the huge delay, could you fork the code, make a change in your branch and submit a PR? Thanks :)


Returning error options from a validator

Is your feature request related to a problem? Please describe.
Full form validators only allow an error message to be attached to a single field. This limits how generic validators can be.
For example, I am trying to have a single 'remote' validator that simply sends the form model to my API. The validation will be done on the API for the entire form. This would have the advantage of being able to use highly complex validation logic without the need to send more data to the UI.
However, I can't attach error messages to specific fields if I find validation problems using this technique.
Describe the solution you'd like
Be able to specify the errorPath option along with the errors. This might require the introduction of a third error type alongside the existing boolean and ValidationError types.
Maybe something like
{
errors: ValidationError[],
options: {
  [key: string]: any,
  errorPath: string
}[]

Describe alternatives you've considered
I've tried:

using errorPath but it wasn't flexible enough
setting the errors on the control in the validator via setErrors but that prevent future validations from being triggered properly
Attaching validators to fields instead of the whole form or a formGroup however this is counter intuitive since it the validation is supposed to be multi-field.

I've been reading through the source and I think it's probably implementable in the handleResult function in field-validation.ts in the case of errorPath being missing or errors being neither boolean nor ValidationError types.

Added an alternative way in v5.8.0 release by returning errorPath through the ValidationError:
export function fieldMatchValidator(control: AbstractControl) {
  ...

  return {
    fieldMatch: {
      message: 'Password Not Matching',
+     errorPath: 'passwordConfirm'
    },
  };
}


New version: MLJModels v0.5.1

Registering package: MLJModels
Repository: https://github.com/alan-turing-institute/MLJModels.jl
Created by: @ablaom
Version: v0.5.1
Commit: 75ffe249d452ea539c5a5b896ca8c32a60d86904
Git reference: master
Release notes:

(Bug) Resolve problem loading some ScikitLearn classifiers (https://github.com/alan-turing-institute/MLJ.jl/issues/252)

Thank you.


Pinocchio 3

All Pinocchio 3 development.
Improvement are stored in CHANGELOG.md.
TODO:

[x] Manage new dependencies

[x] Release Pycppad with a recent eigenpy version on Windows
[x] Release pycppad with cppad 2023 on Windows ? (since codegen is never used on Windows, it's useless)

[x] Local convention by default

[x] ABA

Set in a details/impl namespace
only use aba

[x] CRBA

[x] Remove abort
[x] setup back old GeometryObject constructor that wasn't deprecated in pinocchio 2
[x] Green CI

Linux Release

[x] test-cpp-cppad-joints

Fail caused by -fstack-protector-strong
valgrind trigger some errors

Linux Debug

[x] Disk space issue…

Macos Release

[x] test-cpp-constrained-dynamics
[x] test-cpp-cppad-joints
[x] test-cpp-casadi-explog

Macos Debug

[x] test-cpp-constrained-dynamics
[x] test-cpp-cppad-joints
[x] test-cpp-casadi-explog
[x] test-cpp-casadi-joints
[x] example-py-autodiff-rnea
[x] example-py-codegen-rnea

Add CPPAD_DEBUG_AND_RELEASE flag

Ubuntu 20.04

[x] Fix expose-collision.cpp
[x] Fix casadi python binding crash

[x] Test dependencies

[x] exemple-robot-data
[x] proxsuite-nlp
[x] aligator
[x] proxsuite
[x] crocoddyl
[x] tsid

Congratulations 🎉
I'll double check this asap

🥳 Nice achievements and team work powered by the Willow team @INRIA !!!

This deserves champagne at INRIA tonight 🎊
Congrats!

This deserves champagne at INRIA tonight 🎊 Congrats!

At Inria, some people (I won't name here) would prefer Côte-Rôtie ;)

Great news, congratulations :tada:

Congratulations everyone !!! 🥳 🥳 🥳

This is GREAT! Congrats for a huge work :slightly_smiling_face:


Dismiss/cancel not discoverable

Say a user opens up the scanner sheet. If they are aware of the fact that a modal sheet was just used, they can swipe down to dismiss it. However, the default view being pretty much full-screen means most users remain unaware that a sheet is active, and do not know how to dismiss/cancel the scanner view.
Can some options be added to make how to cancel/dismiss a scanner view more discoverable? Either an option to add some kind of close/cancel button, OR have the sheet show up as smaller than the full screen, say at 75 or 80% of the screen instead.
Sheets are supposed to have a presentation detents feature for iOS 15 and up -- not sure if that can help here.

I do see issue https://github.com/twostraws/CodeScanner/issues/45. Having an explicit wrapper with navigation seems like a good workaround, though its not trivial on the caller (at least I haven't gotten it to work properly yet).
I still think it is valid to think about supporting detents as those are the standard way sheet gestures are supposed to be discoverable.

Even when presenting a modal you have to wrap your view into a navigation view with the cancel button (the navigation view inside the modal)


LLVM 3.5

Inside the build pack
crystal -v
Crystal 0.22.0 [3c71228] (2017-04-20) LLVM 3.5.0

I'm getting very slow compile times, possibly because of this. Any ideas how I update this.
I'll update this if I work it out sooner.

I'm not sure if the slow compile times are due to that, but we already know LLVM 3.5 generates incorrect code and are in the process of dropping support for it.
The Crystal version we use is here:
https://github.com/crystal-lang/heroku-buildpack-crystal/blob/master/bin/compile#L50
That is generated from https://github.com/crystal-lang/omnibus-crystal. There's already a WIP PR to move to LLVM 3.8 here: https://github.com/crystal-lang/omnibus-crystal/pull/17
So this issue should be fixed once we merge that PR. If you're in a hurry, I guess you could try to build Crystal from source, publish it, fork this repo and change that line.
Hope this helps!

Thanks, it does help. I'm already using a fork of the buildpack with a variation of libgc, so I may create / link my own binary and see if it effects compile time.
Thanks again for the prompt response...

Cool! If it's not too much to ask, would you let us know how it goes? Would be useful to close the loop.

Quick update, I gave this a go but the crystal I built on ubuntu 14.04 against llvm 3.8 through errors when I tried to build my app. Think I missed something along the way. Hopefully I'll get another chance to try this week. I should have noted down the errors, but it was one of those '2:00am, give up and go to bed' moments. I'll be a bit more systematic in my process next time.

Its now impossible to compile in this buildpack with the lastest crystal as the 0.23 version required LLVM3.8>.
Looks like I'm stuck on 0.22 until this is resolved. See other discussion here - https://github.com/crystal-lang/crystal/issues/4647#issuecomment-312586483

@crisward, thanks for keeping us up to date. Don't worry about "getting stuck", we will not release any new Crystal versions until there's a 0.23.x that works on Ubuntu 14.04.

Thanks, that's very reassuring.

@crisward I think this is no longer an issue, is it ok if we close it?

0.23.1 is compiled against 3.8, which sort of fixes this, however this has nothing really to do with the buildpack and more to do with the omnibus binaries. So I'll close. Thanks.


generate pool files locally and then upload it

This should speed up the role run

This doesn't seem to be an issue anymore. Closing it.


CLI window instantly closes after specifying file.

Hi, am I doing something wrong? After running the CLI and specifying the file the window instantly closes with no message or logfile.
Also is this only usable on dll's or also for dotnet .exe files?

Hi,
Did you tried to drag-and-dropp the file into BitMono.CLI and creating 'libs' directory in the same path where`s your file located, try to attach logs from BitMono.CLI path if they are exist

Hi, yes I also tried drag & drop, it shows correct path.  so that part works.
I can see no logs unfortunately.
By running a mono shell i can manually launch the program through it but maybe I am misunderstanding?
The architecture is client locally that connects to web server and downloads different packages depending on situation. Most of the stuff is however done serverside so maybe we should just focus on running a simpler renamer and properly rely on the webservice for security.

Hi, today I will upload new version that probably will reveal the problem

So, now you could try it with a new update

same thing, is there supposed to be a logfile being created?

Now there is should outputted logs directly in Console (if you will get an error) after running the BitMono.CLI
Could you please explain steps what you are doing while obfuscating

so i publish a client from my visual studio -> .exe file
i open bitmonocli.exe
drag and drop client.exe
filepath is established, press enter. window closes.

Try this steps:

Your directory with Client.exe + as well there is should be created libs directory - drop there your libraries (dependencies) that you are using in your project.
Drag-and-drop Client.exe in BitMono.CLI

Try this update

hmm I'm not sure it utilizes any libs in that sense, it's pretty much stand-alone.  (Once compiled). it accesses a programdata folder for settings and storage of downloads.
progress!
Something went wrong! System.BadImageFormatException: .NET data directory RVA is 0
   at dnlib.DotNet.MD.MetadataFactory.Create(IPEImage peImage, CLRRuntimeReaderKind runtime, Boolean verify)
   at dnlib.DotNet.MD.MetadataFactory.Load(Byte[] data, CLRRuntimeReaderKind runtime)
   at dnlib.DotNet.ModuleDefMD.Load(Byte[] data, ModuleCreationOptions options)
   at BitMono.Obfuscation.ModuleDefMDCreator.<CreateAsync>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at BitMono.Obfuscation.BitMonoEngine.<ObfuscateAsync>d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Program.<Main>d__3.MoveNext()

Uhmm.. seems you already protected your app and your trying to load the same file which is already obfuscated isnt it? May be Im wrong.

oh hang on i will try publish a fresh version.

Which version of .NET your app use? Seems to .NET Core, idk why .NET data directory RVA is 0, probably it is a matter of you or other obfuscation tool?

.net 6.0 windows, nah i get same result on a "new" client

As far as I know .NET 6.0 compiles an Native assembly (in this case you don`t need any obfuscation, because your code in native, no one decompiler could even open it in human-readable code) as well as managed - you have to use managed one via obfuscation

Hmm seems I need to do some more research as to why we needed to obfuscate our project haha, thanks for your time and support however!

Glad that I help you, no problem!


Support cuTENSOR

This PR proposes to make cuTENSOR, a high-performance CUDA library for tensor operations, available on CuPy. Please see this link for details about cuTENSOR.
All cuTENSOR's C APIs are exposed in cupy/cuda/cutensor.pyx. In addition, a bit abstracted APIs such as contraction, elemetwise_trinary and elementwise_binary are exposed in cupy/cutensor.py, so that python developers can utilize cuTENSOR in rather pythonic way. Please see examples in examples/cutensor/ on how to use these APIs.
In order to build CuPy with cuTENSOR enabled, you first need to download cuTENSOR from here and tell a path where cuTENSOR is installed by an environment variable CUTENSOR_PATH when you build CuPy.
$ cd (to where cupy is installed)
$ CUTENSOR_PATH=/path/to/cutensor python setup.py install

Any feedback would be greatly appreciated.
Thanks in advance.

@anaruse Request to please also consider HIP and ClPy. Thank you for the good work 🙏!

How does it compare with DLPack?

Thanks for the contribution! I checked the code and basically it LGTM.
However now cuTensor v0.1 seems unavailable for download. If this PR works fine with cuTensor v0.2, I'd like to proceed merging this PR after I confirm it works with v0.2. (I'm now waiting for approval to join the program).

I confirmed it works fine on cuTensor 0.2.2 / CUDA 10.
pfnCI, test this please.

Jenkins CI test (for commit 59df90fe5e51947467181fb45d248182db7a0024, target branch master) failed with status FAILURE.

LGTM! Test failures are not related to this PR.

Thanks for merging this PR!


Replace unmaintained release action

The curl command looks pretty much the same as the action! 😄

I don't know why we had to switch to curl, but I like that we don't rely on creating a temporary file for the changelog. Thanks

We were using an unmaintained action that was on a deprecated version of NodeJS. I think I could have written a raw JavaScript snippet instead here, but I went with curl since it was straightforward enough.


add support for conda environments

Thanks. Could you modify this so it's its own slice - conda isn't python specific as far as I can tell.

done!

Could you also update the README about the new slice, below this line
" promptline#slices#git_status() - count of commits ahead/behind upstream, count of modified/added/unmerged files, symbol for clean branch and symbol for existing untraced files

Please squash the commits.

updated!

Thanks, looks good!
Would you like to add your name to this file?

sure thing, did you want me to make the change or you will?

I wanted you to add it but it doesn't really matter :) You're in CONTRIBUTORS.md now, thanks! https://github.com/edkolev/promptline.vim/commit/bcce033792fb1d5745f42fe65b963754c5353847


Add Alan thinks he needs async locks

This story comes from an async writing session with @LucioFranco and @Darksonn.

@nikomatsakis @Darksonn Y'all were right - the order of the story was wrong. I pushed an update.

@rylev thanks for writing this up, it looks great!


Fix the column size difference bug in SummingMergeTree

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
When merging SummingMergeTree parts, every time the next row has a different key, the engine does these steps:

Write the currently accumulated row (if there is one and it is non-zero).
Generate a new set of states for the next row and add the values to them.

Then I added support for AggregateFunction in #2566 which goes around the separate state and aggregates data directly in the merged column.
This behaves incorrectly (#2645) when the engine reaches the end of the output block. Previously it would still read the next input row, put it into state and reuse the state on the next interation. Now, for AggregateFunction columns, it adds an extra element.
This can be reproduced with:
DROP TABLE IF EXISTS t;

CREATE TABLE t
(
    date Date,
    key UInt32,
    u AggregateFunction(uniq, UInt64)
)
ENGINE = SummingMergeTree(date, (date, key), 1);

INSERT INTO t SELECT
    today() as d,
    number as k,
    uniqState(toUInt64(number % 500))
FROM numbers(5000)
GROUP BY d, k;

INSERT INTO t SELECT
    today() as d,
    number + 5000 as k,
    uniqState(toUInt64(number % 500))
FROM numbers(5000)
GROUP BY d, k;

OPTIMIZE TABLE t;

The PR changes the order of things slightly. Now when a different key is encountered, and the output block is full, the engine does not pop the queue and does not create the state (or append an empty value to the AggregateFunction columns).
This also adds the mentioned case to the tests. Fixes #2645.

cc @champtar, @alexey-milovidov, @bocharov, @vavrusa, @twalwyn, @Dorokhov

Looks Ok. Thank you!


[backward-cpp]Update  version

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Fix complier error on mingw plateform

They install an unusual CMake config file, probably for header-only usage. Some patterns are really strange.
vcpkg's usage heuristics doesn't work well for them. I suggest installing a share/backward-cpp/usage file:
backward-cpp provides CMake targets:

  find_package(Backward CONFIG REQUIRED)
  # To use the header library
  target_link_libraries(main PRIVATE Backward::Interface)
  # To use the prebuilt library
  target_link_libraries(main PRIVATE Backward::Backward)

(untested)

good idea.
------------------ 原始邮件 ------------------
发件人: @.>;
发送时间: 2023年12月11日(星期一) 下午4:22
收件人: @.>;
抄送: @.>; @.>;
主题: Re: [microsoft/vcpkg] [backward-cpp]Update  version  (PR #35583)
@JonLiu1993 commented on this pull request.
In ports/backward-cpp/vcpkg.json:
>    "version": "1.6", -  "port-version": 1, +  "port-version": 2,
If there is no progress upstream within two weeks I suggest we use version-data.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Actually, prior to this PR, Backward had always joined the build system in the form of header only. However, in the current PR, it is added to the compilation in the form of a library.

now, add version-date format and a usage file

Usage tested successfully by backward-cpp:x64-windows:
backward-cpp provides CMake targets:

  find_package(Backward CONFIG REQUIRED)
  # To use the header library
  target_link_libraries(main PRIVATE Backward::Interface)
  # To use the prebuilt library
  target_link_libraries(main PRIVATE Backward::Backward)


[mgmt] breaking change detection tool bug

In some cases, breaking change detection tool will detect some non-breakings as breaking change:
1  interfaces with the NextOptionalParams suffix will be detected as breakingchanges. like:
- Interface ApiDiagnosticListByServiceNextOptionalParams no longer has parameter filter
- Interface ApiDiagnosticListByServiceNextOptionalParams no longer has parameter skip
- Interface ApiDiagnosticListByServiceNextOptionalParams no longer has parameter top

2 Client has a new signature will be detected as breakingchanges. like:

3 The definition of parameter is moved from subclass to parent class will be detected as breakingchanges. like:
https://github.com/Azure/azure-sdk-for-js/pull/26450#discussion_r1273058808
4 https://github.com/Azure/azure-sdk-for-js/pull/27223#discussion_r1338094846 In changelog, we suggested not to use track2 for public documents, so we may consider update the link
from
https://aka.ms/js-track2-quickstart

to
https://aka.ms/azsdk/js/mgmt/quickstart

so we need to update this in changelog tool
### Tasks
- [ ] https://github.com/Azure/azure-sdk-tools/issues/7885

miss logs if we have this change:

5 issue in Azure/azure-sdk-for-js#26543

fixed

9 need support enum breaking detection https://github.com/Azure/azure-sdk-for-js/pull/30014#discussion_r1690855320


Wrong GitHub repository link for the Invasive species information management task group?

Page(s) where issue occurs

Invasive species information management

Issue description

The github button links to another task group: sensitive-species-extension

Should the link be updated to another repository perhaps?

Thank you for catching that.  I'll coordinate the new repository with the convener and core members.  In the meantime, I've just removed the link to a github repo.


Plugin is not working for me

I did the following and it does not seem to work for me:

Installed the plugin via October Installer
Added the {% styles %}   {% framework extras %} {% scripts %} into my layout file
Set the "Menage website content file" to allow.
Added {% component 'contenteditor' file="test.htm" %} into my page with appropriate content "test.htm" created.

Still does not work for me :( I checked the html and content-tools.min.js is not loaded

Hey, thanks for feedback, can you please provide more info about october? (version, what plugins you use.. etc)

It works after drag the component in the page. Is this a requirement?

Its required, because you calling component


only need java runtime

is that possible to only include java runtime in invoker.yml
like this:

name: "RUNTIMES_MANIFEST"
value: '{ "defaultImagePrefix": "openwhisk", "defaultImageTag": "latest", "runtimes": { "java": [ { "kind": "java", "default": true, "image": { "name": "java8action" }, "deprecated": false, "attached": { "attachmentName": "jarfile", "attachmentType": "application/java-archive" }, "sentinelledLogs": false, "requireMain": true } ] }}'

You’ll have to disable the heath protocol which assumes node. And the invoker might also assume node6 is available for stem cells.

I think @rabbah answered the question, so this issue can be closed.  An issue to make node6 optional would belong in the main openwhisk repo.


Nuke/Rebuild quantecon-notebooks-jl once TOML is done

No LFS!

See updated idea instead, with archiving. Will be easier to test


Typo on example

Version
@toast-ui/react-calendar: ^2.1.3
Test Environment
Chorme, Windows
Current Behavior
Might be typo?
Just tested and it work with onClickDayName but not onClickDayname
https://github.com/nhn/tui.calendar/blob/main/apps/react-calendar/example/app.tsx#L267-L314
onClickDayname={...}

should be

onClickDayName={...}

Yeah, You're right. It should be onClickDayName.
https://github.com/nhn/tui.calendar/blob/main/apps/calendar/src/types/eventBus.ts#L40

Tks for reply and glad to know 😄


Plugin Description
The plugin relies on themida-unmutate to deobfuscate functions obfuscated by Themida's code mutation. The user needs to set the cursor to the entry point of the obfuscated function (or portion of code if the function is partially mutated) and then run the "Deobfuscate ..." action.
Plugin Repository URL
Repo URL: https://github.com/ergrelet/themida-unmutate-bn
Real Release

[X] I have made a real release

Thanks! I've updated the plugin manager, should be live in ~5m


guided gradcam naming issue

there is an example of gradcam with guided backprop modifier. but in the literature guided gradcam means something else: guided backprop multiplied by gradcam

Hi, @eyaler . Thank you for your proposal. But the name was named by the paper that proposed Grad-CAM, so we aren't going to rename.
https://arxiv.org/pdf/1610.02391.pdf
We'll close this issue, but please feel free to reopen whenever you need.
Thanks!

@keisen so in the paper:
guided grad cam = visualize_saliency(backprop_modifier='guided') * visualize_cam()
this is different from the "guided grad cam" implied in keras-vis:
visualize_cam(backprop_modifier='guided')
you can see an example here:
bit.ly/vis-colab

Hi, @eyaler , Thank you for your great easy to understand example! I got it, so I reopened this in your stead.
I believe that we should add explanation how to visualize guided-gradcam to the gradcam section of the example notebook. Would you please submit a PullRequest that improve this issue?
Thanks!


Device Lost when writing SV_PrimitiveID to OutputPrimitives<T, N>

The following shader produces a DEVICE_LOST error
const static let color: float3[] = {
  float3(1.0, 0.0, 0.0),
  float3(0.0, 1.0, 0.0),
  float3(0.0, 0.0, 1.0),
};

const static let position: float3[] = {
  float3( 0.5,  0.5, 0.0),
  float3( 0.0, -0.5, 0.0),
  float3(-0.5,  0.5, 0.0),
};

struct SVertexOutput {
  float4 Position: SV_Position;
  float3 Color;
};

struct SPrimitiveOutput {
  uint PrimitiveId: SV_PrimitiveID;
};

[shader("mesh")]
[numthreads(1, 1, 1)]
[outputtopology("triangle")]
func MainMesh(
  OutputVertices<SVertexOutput, 3> outputVertices,
  OutputPrimitives<SPrimitiveOutput, 1> outputPrimitives,
  OutputIndices<uint3, 1> outputIndices,
) -> void {
  SetMeshOutputCounts(3, 1);
  outputVertices[0] = { float4(position[0], 1.0), color[0] };
  outputVertices[1] = { float4(position[1], 1.0), color[1] };
  outputVertices[2] = { float4(position[2], 1.0), color[2] };
  outputIndices[0] = uint3(0, 1, 2);

  // This next line causes the DEVICE_LOST error
  outputPrimitives[0] = { 0 };
}

[shader("pixel")]
func MainPixel() -> void {}

I have attached a sample application for further testing, building steps:
cd extracted_folder
mkdir build
cd build
cmake ..
cmake --build .

Building requires a C++ compiler that supports at least C++14
If untouched, executing the application will produce VK_ERROR_DEVICE_LOST, this was tested on the following configurations:

Windows 11
NVIDIA RTX 3070 - 551.86, NVIDIA RTX 4070 Super - 551.86

bug.zip

Is there a SPIRV validation error coming out from the spirv?

Even with --env=vulkan1.3?

If no validation errors, this is likely a driver bug, or missing validation checks in spirv-Val, or missing validation rules in the Vulkan spec.

This seems like something we should fix. PerPrimitiveNV is required by spec for PrimitiveId builtin. @pmistryNV

Even with --env=vulkan1.3?

Yes

If no validation errors, this is likely a driver bug, or missing validation checks in spirv-Val, or missing validation rules in the Vulkan spec.

After testing on an AMD Radeon RX 6750 XT - RADV NAVI 22 it does appear to be working, but an equivalent GLSL shader compiled to SPIR-V works fine on my GPU (RTX 3070 - 551.86), I'll investigate more.

Can you share the equivalent GLSL shader?

Everything passed via OutputPrimitive<T>  is automatically decorated with PerPrimitive currently. The fact that this builtin isn't decorated is a bug.

To summarize the TODOs here:

Slang is missing PerPrimitive decoration, we should fix it.
spirv-val is missing the validation check, and we need to add validation rules for that.
The NVIDIA driver is probably not handling this correctly, so we may need to fix the driver.

Below is the excerpt from the SPIRV i dumped
OpDecorate %gl_PrimitiveID BuiltIn PrimitiveId
%gl_PrimitiveID = OpVariable %_ptr_Output__arr_int_int_1 Output

It needs an additional decoration
OpDecorate %gl_PrimitiveID PerPrimitiveNV
Corresponding SPIRV-Validation rule that is missing from the validator. I will fix that too.
VUID-PrimitiveId-PrimitiveId-07040
The variable decorated with PrimitiveId within the MeshEXT Execution Model must also be decorated with the PerPrimitiveEXT decoration

MeshShader.zip
I am having difficulties running the test. @LVSTRI can you verifiy with the modified MeshShader.spv file and see if the issue is resolved?

Testing on an RTX 3070 (551.86) the issue seems solved, let me know if I can help with the test I provided

Thanks then let me make the fix in SLANG. Also added a comment on https://github.com/KhronosGroup/SPIRV-Tools/issues/4919 that i am working on to fix the validation of ext_mesh_shader.

I just wanted to add that the same bug (PerPrimitiveEXT decoration missing) happens for SV_CullPrimitive and every other builtin in OutputPrimitives<T, N>, I just found this out.

https://github.com/shader-slang/slang/pull/3895 this is the PR for fixing the bug.

I just wanted to add that the same bug (PerPrimitiveEXT decoration missing) happens for SV_CullPrimitive and every other builtin in OutputPrimitives<T, N>, I just found this out.

#3895 this is the PR for fixing the bug.

Can you give it a try and let me know if this fixes the issues that you are seeing

const static let color: float3[] = {
  float3(1.0, 0.0, 0.0),
  float3(0.0, 1.0, 0.0),
  float3(0.0, 0.0, 1.0),
};

const static let position: float3[] = {
  float3( 0.5,  0.5, 0.0),
  float3( 0.0, -0.5, 0.0),
  float3(-0.5,  0.5, 0.0),
};

struct SVertexOutput {
  float4 Position: SV_Position;
  float3 Color;
};

struct SPrimitiveOutput {
  uint PrimitiveId: SV_PrimitiveID;
  bool cull : SV_CullPrimitive;
};

[shader("mesh")]
[numthreads(1, 1, 1)]
[outputtopology("triangle")]
func MainMesh(
  OutputVertices<SVertexOutput, 3> outputVertices,
  OutputPrimitives<SPrimitiveOutput, 1> outputPrimitives,
  OutputIndices<uint3, 1> outputIndices,
) -> void {
  SetMeshOutputCounts(3, 1);
  outputVertices[0] = { float4(position[0], 1.0), color[0] };
  outputVertices[1] = { float4(position[1], 1.0), color[1] };
  outputVertices[2] = { float4(position[2], 1.0), color[2] };
  outputIndices[0] = uint3(0, 1, 2);

  // This next line causes the DEVICE_LOST error
  outputPrimitives[0] = { 0, false };
}

As pointed out by @LVSTRI something like below shader will still fail


bug(calling): When User goes to Settings during call/mic cuts out

Issue:
While Sheldon and I were on a call today, he was coming through super clear but each time he would navigate to the Settings page his mic would cut out and I could no longer hear him until he returned to our chat
OS:
I was on MacOS 14 while Sheldon was on Windows 10

could not reproduce.


Deprecation Warning in Ruby 1.9.3

Hey sporkmonger,
Since 1.9.3 is out, and it has started printing pretty explicit warnings about deprecating Config in favor of RbConfig, I thought I'd go ahead and oblige. What do you think?
Regards,
René van den Berg

Code must work on 1.8.6, 1.8.7, and 1.9.x as well. Please verify that this change works in older versions and I'll go ahead and merge it. Otherwise please update code to check that the RbConfig constant exists and then branch to the appropriate snippet of code.

RbConfig is an alias for Config since Ruby 1.8.5, so this should work. Testing in RVM:
$ irb -f
irb(main):001:0> RUBY_VERSION
=> "1.8.6"
irb(main):002:0> require 'rbconfig'
=> true
irb(main):003:0> RbConfig
=> Config

Also, on Ruby 1.8.7:
$ irb -f
irb(main):001:0> RUBY_VERSION
=> "1.8.7"
irb(main):002:0> require 'rbconfig'
=> true
irb(main):003:0> RbConfig
=> Config

What's the status of this issue? Looks like there is already a fix for that warning, why hasn't it been released yet?

I'm not sure. I think I've demonstrated that the change works on older versions as well, so I'm not sure if there's anything left for me to do. If there is, please let me know.


unable to run ans

Im trying to run ans under ubuntu 16.04 server(virtual machine on top kvm) with dpdk 17-11 stable, when I try to run the app I got the following:
root@ubuntu-16-04-dpdk:~/dpdk-ans/ans# ./build/ans -c 0x2 -n 1 -- -p 0x1 --config="(0,0,1)"
EAL: Detected 4 lcore(s)
EAL: No free hugepages reported in hugepages-1048576kB
EAL: Probing VFIO support...
EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using unreliable clock cycles !
EAL: PCI device 0000:01:00.0 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 1af4:1041 net_virtio
EAL: PCI device 0000:07:00.0 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 1af4:1041 net_virtio
EAL: PCI device 0000:08:00.0 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 1af4:1041 net_virtio
param nb 1 ports 2
port id 0
Start to Init port
port 0:
port name net_virtio:
max_rx_queues 1: max_tx_queues:1
rx_offload_capa 0x1c: tx_offload_capa:0x2c
Creating queues: rx queue number=1 tx queue number=1...
MAC Address:52:54:00:C8:6F:19
Deault-- tx pthresh:0, tx hthresh:0, tx wthresh:0, txq_flags:0xf00
lcore id:1, tx queue id:0, socket id:0
Conf-- tx pthresh:0, tx hthresh:0, tx wthresh:0, txq_flags:0x0
Skipping disabled port 1
Allocated mbuf pool on socket 0, mbuf number: 16384
Initializing rx queues on lcore 1 ...
Default-- rx pthresh:0, rx hthresh:0, rx wthresh:0
port id:0, rx queue id: 0, socket id:0
Conf-- rx pthresh:8, rx hthresh:8, rx wthresh:4
core mask: 2, sockets number:1, lcore number:1
start to init ans
USER8: LCORE[1] lcore mask 0x2
USER8: LCORE[1] lcore id 1 is enable
USER8: LCORE[1] lcore number 1
USER1: rte_ip_frag_table_create: allocated of 25165952 bytes at socket 0
USER8: LCORE[1] UDP layer init successfully, Use memory:4194304 bytes
USER8: LCORE[1] TCP hash table init successfully, tcp pcb size 448 total size 58720256
USER8: LCORE[1] so shm memory 16777216 bytes, so number 131072,  sock shm size 128 bytes
USER8: LCORE[1] Sock init successfully, allocated of 41943040 bytes
add eth0 device
USER8: LCORE[1] Interface eth0 if_capabilities: 0x1c
*** stack smashing detected ***: ./build/ans terminated
Aborted (core dumped)
I dont see some dpdk issues.. testpmd working for example

Support environment
EAL is based on dpdk-18.11;
linux version： 4.4.0-45-generic (Ubuntu 16.04.1 LTS).
gcc version： gcc version 5.4.0 20160609.

i followed the user guide...
ubuntu server is ok?

ubuntu server is ok, ans doesn't depend on it.
But dpdk vesion shall be 18.11. shall same as ans.

now i got:root@ubuntu-16-04-dpdk:~/dpdk-ans/ans# ./build/ans -c 0x2 -n 1 -- -p 0x1 --config="(0,0,1)"
EAL: Detected 4 lcore(s)
EAL: Detected 1 NUMA nodes
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: No free hugepages reported in hugepages-1048576kB
EAL: Probing VFIO support...
EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using unreliable clock cycles !
EAL: PCI device 0000:01:00.0 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 1af4:1041 net_virtio
EAL: Error: Invalid memory
EAL: PCI device 0000:07:00.0 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 1af4:1041 net_virtio
EAL: PCI device 0000:08:00.0 on NUMA socket -1
EAL:   Invalid NUMA socket, default to 0
EAL:   probe driver: 1af4:1041 net_virtio
Start to Init port
port 0:
port name net_virtio:
max_rx_queues 1: max_tx_queues:1
rx_offload_capa 0x21d: tx_offload_capa:0x802d
Creating queues: rx queue number=1 tx queue number=1...
Ethdev port_id=0 requested Rx offloads 0xf doesn't match Rx offloads capabilities 0x21d in rte_eth_dev_configure()
EAL: Error - exiting with code: 1
Cause: Cannot configure device: err=-22, port=0

Pull the latest ans from github.

latest master?
if so, I did it..

ubuntu@ubuntu-16-04-dpdk:~/dpdk-ans$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Untracked files:
(use "git add ..." to include in what will be committed)
ans/build/
help-dummy.o
librte_ans/librte_ans.a
librte_anscli/librte_anscli.a
librte_anssock/librte_anssock.a

nothing added to commit but untracked files present (use "git add" to track)
ubuntu@ubuntu-16-04-dpdk:~/dpdk-ans$ git pull
error: cannot open .git/FETCH_HEAD: Permission denied
ubuntu@ubuntu-16-04-dpdk:~/dpdk-ans$ sudo git pull
[sudo] password for ubuntu:
Already up-to-date.
ubuntu@ubuntu-16-04-dpdk:~/dpdk-ans$ sudo git branch -v
ans-17.11 7ac8fc8 add more comments before adding acl function

master    dc97dc8 fix tcp issue
ubuntu@ubuntu-16-04-dpdk:~/dpdk-ans$

git pull https://github.com/ansyun/dpdk-ans.git

What is your NIC ? it doesn't support DEV_RX_OFFLOAD_IPV4_CKSUM, but support DEV_RX_OFFLOAD_UDP_CKSUM and DEV_RX_OFFLOAD_TCP_CKSUM?

virtio, binded with igb_uio or uio_generic

Fix the issue just now. Please pull the latest ANS code and try it.
Thanks.

working Thanks


Introduce GitHub Actions

No publishing job on NuGet or consideration for new tags yet, but at least we can build the solution with the new workflow. We can reserve System.Runtime.CompilerServices.IsConst for GTA.UI.WIDTH and GTA.UI.HEIGHT of v2 API too.
We should be careful with the publishing job, so I create a pull request.
Mentioned in a comment in #1222 btw.

On LemonUI, I do something complicated yet clean.
I have one job that Lints and Builds, and another jobs that Deploys. On the Build step, I post the Debug and Release artifacts:
  lint-and-compile:
    strategy:
      matrix:
        configuration: [Debug, Release]
    runs-on: ubuntu-22.04
    steps:
      - uses: actions/checkout@v3
      - uses<EMAIL_ADDRESS>        with:
          dotnet-version: "7.0.x"
      - run: dotnet restore ${{ github.event.repository.name }}.sln
      - uses<EMAIL_ADDRESS>        with:
          version: 1.9.3.${{ github.run_number }}
          use-tag: true
          csproj-files: "**/root.props"
      - run: dotnet build ${{ github.event.repository.name }}.sln -c ${{ matrix.configuration }}
        working-directory: ${{ env.GITHUB_WORKSPACE }}
      - uses: actions/upload-artifact@v3
        with:
          name: ${{ github.event.repository.name }}.${{ matrix.configuration }}
          path: bin/${{ matrix.configuration }}

Then I have another job that does the actual deployment, but only on releases:
  deploy:
    runs-on: ubuntu-22.04
    if: ${{ github.event_name == 'release' }}
    needs:
      - lint-and-compile
    steps:
      - uses: actions/checkout@v3
      - uses<EMAIL_ADDRESS>        with:
          dotnet-version: "7.0.x"
      - uses: actions/download-artifact@v3
        with:
          name: ${{ github.event.repository.name }}.Release
          path: bin/Release
      - run: ls -R
        working-directory: bin/Release
      - run: 7z a ${{ github.event.repository.name }}.zip ${{ github.workspace }}/bin/Release/*
      - run: dotnet nuget push "**/*.nupkg" -s 'https://api.nuget.org/v3/index.json' -k ${{secrets.NUGET}}
      - uses<EMAIL_ADDRESS>        with:
          allowUpdates: true
          artifactErrorsFailBuild: true
          artifacts: ${{ github.event.repository.name }}.zip
          omitBodyDuringUpdate: true
          omitDraftDuringUpdate: true
          omitNameDuringUpdate: true
          omitPrereleaseDuringUpdate: true

I'm waiting for crosire's clear decision about my admin role for this project/repo. Looks like you don't necessarily need an admin role to create a release via GitHub API and you can do this with a write access, but I think I need to grab an admin role before I can configure API tokens for NuGet packages without exposure.

No need for that. You can enable certain permissions on the worker. Check https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

So I can create releases via external actions with certain permissions. And now crosire gave me an admin role for the organization and I configured a NuGet API key so I can publish API packages without the key getting exposed.
I'm planning to release the new version of SHVDN after SHV gets updated for the new GTA version since an new update of GTA was announced and we would add new hashes again. I should get this done before that time comes...

I think this PR got as sophiscated for the status check as the previous AppVeyor workflow. Removed the files for AppVeyor CI to prevent unintended accidents.
I put my personal token for the GitHub release API since I'm not a fan of the github-actions bot as a release author (if you use github.token for the release API, then you will see). I haven't seen any repos that have any releases with the github-actions bot author except for Vue.js, either. I've looked into React, Node.js, Ruby on Rails, Laravel, MAME (emulator), and DeSmuME for their releases on GitHub.
When we add a job or workflow where API packages will be automatically published to NuGet, we would use msbuild [project filename] -t:pack /p:Configuration=Release /p:Platform="x64" because you can't use the nuget command (no support for SDK-style projects) or dotnet pack (no support for projects that depends on MSVC projects) for the SHVDN solution.


[FP]: Apache HBase Hadoop compatibility matches Apache Hadoop

Package URl
<EMAIL_ADDRESS>CPE
cpe:2.3:a:apache:hadoop:2.2.0:::::::*
CVE
No response
ODC Integration
{"label"=>"Maven Plugin"}
ODC Version
7.2.1
Description
The Apache HBase Hadoop compat library (which allows Hbase to work with multiple versions of Apache Hadoop) is mistaken for one of the Apache Hadoop libraries themselves

approved


Missing required property error check isn't working

Problem:
It seems that the required property error check for resources is not working as per the example in the README.
Troposphere Version:
0.7.2
OS:
OS X 10.10.3
Steps:
>>> from troposphere import Template
>>> import troposphere.ec2 as ec2
>>> t = Template()
>>> t.add_resource(ec2.Instance("ec2instance", ImageId="ami-3bcc9e7e"))
<troposphere.ec2.Instance object at 0x10b8cf310>
>>> print(t.to_json())

Expected result:
ValueError: Resource InstanceType required in type AWS::EC2::Instance

Actual Result:
{
    "Resources": {
        "ec2instance": {
            "Properties": {
                "ImageId": "ami-3bcc9e7e"
            },
            "Type": "AWS::EC2::Instance"
        }
    }
}

It looks like this is due to the fact that InstanceType is no longer necessary!
http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-instancetype
Updating the README - pushing the change now.  Thanks!


Improve handling of // in strings

...by searching for // $ instead.  This still doesn't consider string boundaries, but is much less likely to occur accidentally (in a URL, for example).

CI is fixed in #327  - updated master

This breaks commented out assertions (as explained by the comment above the line I changed 🤦).


Create Generic Pages “projects”

Automatically generated by Netlify CMS

👷 Deploy Preview for benevolent-muffin-215770 processing.

Name
Link

🔨 Latest commit
c256a99e54b404f67fbf7bf76188d6dbbb408774

🔍 Latest deploy log
https://app.netlify.com/sites/benevolent-muffin-215770/deploys/62841b8f0bd0750009a20af6


Allow more variables to be set through os_env

I want to merge this change because...
Some variables need to be changed and it is more convenient to do so through the ENV
variables rather than rewriting the settings.py file.
Currently, for the helm charts, I need to add a custom_settings.py file to allow for this. Now, I
will leave the ability to add a custom_settings.py in the helm charts as users may have specific
reasons for that but I'd prefer that the default case is that it is not required.
What does this commit/MR/PR do?

Allows more variables to be set via os_env
Makes app more configurable from os_env rather than
settings.py
Changes the default timezone to UTC rather than America/Chicago

Why is this commit/MR/PR needed?

Try to move away from relying on changing settings.py as much as
possible.
More flexibility

Pull Request Checklist

[ ] Privileged views and APIs are guarded by proper permission checks.
[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Database queries are optimized and the number of queries is constant.
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] GraphQL schema and type definitions are up to date.

Any word on this ?
I'd like to close it if it is not suitable for merge.

@patrys
Ok, I'll close this PR.


Rewrite example code for async await

It's how i'd expect most users to consume it
Just an idea. :)

Thanks for the suggestion @paulirish — though I'm not completely sure I understand. Do you mean all the examples should use the async/await syntax? Or perhaps that all the examples should include async/await syntax, whether or not they also include an equivalent snippet using Promise/then-able syntax?
Some of the example code does use "await" inside async functions, e.g. https://github.com/WICG/async-cookies-api/blob/gh-pages/cookies_test.js#L85 and (in the explainer) https://github.com/WICG/async-cookies-api/blob/gh-pages/explainer.md#reading (scroll down for the async/await version) - however based on earlier feedback I left some "classic" Promise-structured examples too to avoid confusing readers not yet familiar with the newer syntax

(Also see discussion on https://github.com/WICG/async-cookies-api/pull/17 )

@paulirish Thank you for the feedback!
I've updated the explainer with the latest changes we've done in Chrome. I think the examples use async / await wherever it makes sense to do so. If you spot places where that's not the case (and space would be saved), please point them out in specific issues / PRs.


When the evaluation of "npx promptfoo@latest" fails, the process exit code is still 0

$ npx promptfoo@latest eval
...
Successes: 0
Failures: 2
Token usage: Total 4297, Prompt 0, Completion 0, Cached 4297
Done.
$ echo $?
0

Thanks for catching this.  Fixed in 65d79fb


Mission test

To Highlight:
Implemented Tests for the missions

Hi @David-Kasilia, 👋
Highlights 👏

Your testing accurate passed! 🎉
Code is very clean and organized, excellent! 🤓
Styling looks great! 😎
Great work using the right GitHub Flow.
Your README looks professional, well done!
Commits are descriptive, good work.
Linters are working properly, great job!

Your project is complete!  There is nothing else to say other than... it's time to merge it! 🚀
Very nice work, congratulations! 🎉
APPROVED! 💯  💯  💯

Cheers and Happy coding! 🤓
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
✅  Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Value of dataset.id lost

Hi @Muchiachio,
I hope these images can help to identify my problem. Ajax grid based on this: http://mvc6-grid.azurewebsites.net/Grid/Ajax.

grid = grid.findElement(element); returns with new HTML element which was overwritten in reload previously.

Thanks in advance.
P.S.: thanks for your work. Good job, useful tool.

It might not be available in some part of the code, but I can't repro it being lost completely after complete ajax reloads. Are you running into problems, because of resetting grid configuration?

Hi.
Meanwhile I found. JS typo caused my problem.
But,
I've tried to implement something similar than this: https://github.com/NonFactors/MVC6.Grid/issues/87
I just put public array into MvcGrid which has same content that mvcgrid.instances array.
I have initailizeGrid method on the View where I set up configuration for the grid.
And here is where I try to refresh my grid content. (User is notified by the program the content has been changed by other user (refresh button appears))
            var id = parseInt(document.querySelector('.mvc-grid').dataset.id);
            var grid = MvcGrid.grids[id];
            grid.reload();
        });

I just want to pointing, based on the code if I call reload on existing grid instance in the constructor it should goes into this code part.
    function MvcGrid(element, options) {
...
        if (element.dataset.id) {
            return grid.instances[parseInt(element.dataset.id)].set(options); <---- TO HERE
        }

But it never goes into there. It is possible it is some kind of misunderstanding from my side.

It looks like my typo caused my problem. My original problem was when I changed external filters It worked until I clear filter value for column, but I've upgraded from <IP_ADDRESS> to <IP_ADDRESS> and it fixed this problem and now it works fine with
new MvcGrid(document.querySelector('.mvc-grid')).reload();
Thank you for your clarification.


[SP-4692] Backport of PDI-17644 - StaxPoiSheet creates an additional …

…object with null when it encounters a null field (8.1 Suite)

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/steps/excelinput/staxpoi/StaxPoiSheet.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory

Branch Change: -7.2% :small_red_triangle_down:
Complexity Change: -7.7% :small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.7% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.9% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/engine/src/main/java/org/pentaho/di/trans/steps/excelinput/staxpoi/StaxPoiSheet.java

:heavy_exclamation_mark: 'for' child has incorrect indentation level 8, expected level should be 6. at Line: 275

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/steps/excelinput/staxpoi/StaxPoiSheet.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.4% :small_red_triangle_down:
Line Change: -3.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Method Change: -1% :small_red_triangle_down:

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupsert.SalesforceUpsertMeta

Instruction Change: -0.1% :small_red_triangle_down:


docs: add project description and docs

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

See the complete overview on Codacy


feature: allow action to fail silently

Resolves #4

Added config option fail-silently (boolean) to allow the action to log a warning message instead of emitting the red X of death

:tada: This PR is included in version 4.5.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Patch release notes to set correct NGNIX image

Codecov Report

Merging #2687 (5f991f6) into release-0.7.3 (b57582c) will decrease coverage by 0.16%.
The diff coverage is 4.12%.

@@                Coverage Diff                @@
##           release-0.7.3    #2687      +/-   ##
=================================================
- Coverage          35.22%   35.05%   -0.17%
=================================================
  Files                158      158
  Lines               9159     9213      +54
  Branches             185      196      +11
=================================================
+ Hits                3226     3230       +4
- Misses              5438     5488      +50
  Partials             495      495

Flag
Coverage Δ

moduleA
22.50% <4.49%> (-0.61%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...nents/ktb-events-list/ktb-events-list.component.ts
12.50% <0.00%> (-0.55%)
:arrow_down:

bridge/client/app/_models/event-labels.ts
100.00% <ø> (ø)

bridge/client/app/_models/trace.ts
31.74% <0.00%> (-0.52%)
:arrow_down:

bridge/client/app/_services/api.service.ts
10.41% <0.00%> (-0.46%)
:arrow_down:

bridge/client/app/_services/data.service.ts
1.08% <0.00%> (-0.04%)
:arrow_down:

bridge/client/app/app.module.ts
100.00% <ø> (ø)

...lient/app/project-board/project-board.component.ts
2.85% <0.00%> (-0.40%)
:arrow_down:

...ation-service/common/projects_materialized_view.go
71.62% <0.00%> (-0.66%)
:arrow_down:

mongodb-datastore/handlers/events.go
23.07% <0.00%> (-0.30%)
:arrow_down:

...uation-details/ktb-evaluation-details.component.ts
11.92% <5.00%> (-0.30%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae7a2e...5f991f6. Read the comment docs.


Next Previous arrow enable/disable

If we enable nav for slider, and there is less items in slider then we specified in slider, than the arrows should be hide.

+1

+1

Agreed. I renamed this so I better understand what it's about.


Value from Setting class must accept blank/null

conf\models.py
from
value = models.CharField(max_length=2000)
to:
value = models.CharField(max_length=2000, null=True, blank=True)
because this code from conf\forms.py causes exception, if object is created:
setting_obj, created = Setting.objects.get_or_create(name=name)
...and...why not accept blank values?

Works for me:
>>> Setting.objects.get_or_create(name="test")
(<Setting: test: >, True)


Authentication suddenly not working

I ran my project today and it keeps saying my credentials are wrong, yet they are not.
When I place the spreadsheet public it still says it's private.

Found a temporary fix, publish your spreadsheet and set it only to be found with people with the link. This way you can still build your project without auth

This just started happening for me as well.
Warning: Running "i18n_gspreadsheet:config" (i18n_gspreadsheet) task

Invalid google credentials for [redacted]

Ah, so looks like Google made a breaking change and the auth method will need to be updated:
https://github.com/theoephraim/node-google-spreadsheet/issues/38

I don't think this issue will be fixed.

Any solution?


Creation of Utils class for optimize the use of functions.

Creation of Utils class for optimize the use of functions in general like: get the current Time.

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:


#CX-7672 : Enhanced UX for agent state

Description
#CX-7672 : Enhanced UX for agent state - Added new variant engaged for button and avatar
Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:
Before (If applicable):

After:

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

BUILD

BUILD


Apple Theme Which is Dark in Development Become Light in Production

Describe the bug
In development, the theme is dark.
But in the production suddenly the theme become light.
To Reproduce
Steps to reproduce the behavior:

Generate slidev project with yarn create slidev
Uninstall seriph theme and install @slidev/theme-apple-basic
In slides.md

---
theme: apple-basic
layout: intro
---

# Title

Subtitle

    Name. Date

Run it, looks normal.

Build it in local then run it with serve dist or deploy it in Vercel. It will be different

Minimal reproduction here: https://github.com/iwgx/into-accessibility/tree/bug-dark-theme
You can see it live here: https://into-accessibility-gqpjsdxue-iwgx.vercel.app
Desktop (please complete the following information):

OS: Windows 10
Browser: Google Chrome
Slidev version: 0.21.3

It's based on the viewer's system preference by default. If you want to force it, you can add this to your frontmatter:
---
colorSchema: 'dark'
---

Thanks for your reply, but in my local computer I think I'm using same viewer system preference.
So I don't think my local development and my local build will have different result. CMIIW.
But the solution works, so still weird.


Add custom headers for requests (close #364)

Add custom headers for http requests.

Failing test but seems to be from the sessions PR rather than this one so approving.


TypedDict support

Right now if you want to write a TypedDict that will work with isinstance - you need to write:
from typing_extensions import TypedDict

class User(TypedDict):
    name: str
    registered: bool

class UserDictMeta(type):
    def __instancecheck__(cls, arg: object) -> bool:
        return (
            isinstance(arg, dict) and
            # The part below can be really long if `user` has lots of fields
            isinstance(arg.get('name'), str) and
            isinstance(arg.get('registered'), bool)
        )

UserMeta = type('UserMeta', (UserDictMeta, type(TypedDict)), {})

class UserDict(User, metaclass=UserMeta):
    ...

a = {'name': 'sobolevn', 'registered': True}
print(isinstance(a, UserDict))  # True

I see that people can benefit from a better API, like:
from phantom.structure import TypedDictWithStructure
from typing_extensions import TypedDict

class User(TypedDict):
    name: str
    registered: bool

class UserDict(User, TypedDictWithStructure):
   ...

a = {'name': 'sobolevn', 'registered': True}
print(isinstance(a, UserDict))  # True

Possible problems:

#128
mypy right now does not allow to call isinstance with TypedDict subtypes: error: Cannot use isinstance() with TypedDict type

What do you think?

Related https://bugs.python.org/msg399615

I think this is better solved in a library focused on runtime type checking of TypedDict. It doesn't seem like narrowing a dict to a TypedDict can ever be safe (since the dict could be manipulated by another context). I personally have only found TypedDict useful for describing i.e. dict literals in config and so I don't find this compelling.


Remove docs related part since zeppelin-docs module is removed

#289 PR occured below warning.
java.io.FileNotFoundException: /Users/zeppelin/zeppelin-server/../zeppelin-docs/src/main/swagger
This PR fixes it by removing docs related part.

You should also consider to remove the swagger dependencies too. We dont need to add more dependencies if there is no use for them.

@minahlee FYI, we have swagger dependencies on zeppelin-server/pom.xml

I created #332 to address issue about dropping swagger dependency.
While this PR nicely removes error, It looks good to me!

To complete the picture, why the docs have been removed? Would it make sense to revive the zeppelin-docs webapp?

@echarles #289 has short description about why it has been removed.

If there're no more discussion, i'm merging it.


Milestone 3: Report feedback

Reasoning

While generally, your description of your method is strong, you could indicate why you decided to work with a linear regression algorithm as opposed to another type of model.

Good explanation of how sklearn picks top features

Most important: Description of Figure 3 is not very accurate - the model under-estimates grade 8 wine as you say, but it over-estimates grade 4 wine. It also doesn't seem to make good predictions for grade 7.
Your critique (discussion) is pretty good. I'd like to see a comment on the variation you're seeing in Fig 3 - how does that relate to how good your model is?
You have one good idea for future directions - any more?

Writing:  Minor grammatical errors, eg:

"is mainly relying on qualified experts" > "mainly relies on"
"data used in this project is obtain from" > "is obtained from"
"Reragding" > "regarding"
"is a reason model to choose" > "is a reasonable model"

Mechanics: Still need to cite an external source (you link to one but make sure to include it in your reference list)

Hi Kate! Thank you for the feedback. I checked the reference list and I think the external source was included as:
@article{cortez2009modeling,
  title={Modeling wine preferences by data mining from physicochemical properties},
  author={Cortez, Paulo and Cerdeira, Ant{\'o}nio and Almeida, Fernando and Matos, Telmo and Reis, Jos{\'e}},
  journal={Decision Support Systems},
  volume={47},
  number={4},
  pages={547--553},
  year={2009},
  publisher={Elsevier}
}

And it also showed up in the reference section in the report:

This is the link to this source:
https://www.sciencedirect.com/science/article/pii/S0167923609001377?via%3Dihub

Thanks for the clarification, I mistook that for your data source.
On that note, your References section should also include your data source, as indicated on this page: http://archive.ics.uci.edu/ml/datasets/Wine+Quality
Paulo Cortez, University of Minho, Guimarães, Portugal, http://www3.dsi.uminho.pt/pcortez
A. Cerdeira, F. Almeida, T. Matos and J. Reis, Viticulture Commission of the Vinho Verde Region(CVRVV), Porto, Portugal
@2009

Thanks Kate 😃!


Fe pass a

@twinge @draffensperger
cap is having issues with submitting refs when not logged in, related to being redirect to login (it skips login for loading the ref but not submit).. if we pass in the access key ("a" param) each time, we can find the answer sheet by that and it will provide security that way, so that we can safely skip the login

I guess we should stop telling travis to test mysql? :+1:

Yeah I'm not sure what's up with that.. I had fixed an error like that at some point.. did it have to do with the ruby version or something?  The default value of "freeze" or something weird like that... not sure why it broke again, and I just haven't had the time to look into it again


[Neovim] Active even in terminal buffers

Pretty simple issue:

Is there a way to deactivate the plugin only when it's a terminal ?

let g:indentLine_bufNameExclude = ["term:.*"]