YARN-10891. Extend QueueInfo with max-parallel-apps in CS.

Description of PR
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 40s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 16s

trunk passed

+1 :green_heart:
compile
10m 21s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
8m 38s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 48s

trunk passed

+1 :green_heart:
mvnsite
3m 34s

trunk passed

+1 :green_heart:
javadoc
2m 59s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 50s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m 48s

trunk passed

+1 :green_heart:
shadedclient
16m 44s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 31s

the patch passed

+1 :green_heart:
compile
9m 27s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

-1 :x:
cc
9m 27s
/results-compile-cc-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 generated 5 new + 177 unchanged - 5 fixed = 182 total (was 182)

+1 :green_heart:
javac
9m 27s

the patch passed

+1 :green_heart:
compile
8m 31s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

-1 :x:
cc
8m 31s
/results-compile-cc-hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 1 new + 181 unchanged - 1 fixed = 182 total (was 182)

+1 :green_heart:
javac
8m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 36s

the patch passed

+1 :green_heart:
mvnsite
3m 16s

the patch passed

+1 :green_heart:
javadoc
2m 45s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 35s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
7m 17s

the patch passed

+1 :green_heart:
shadedclient
16m 59s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 59s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 40s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
99m 41s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
27m 41s

hadoop-yarn-client in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

282m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3314

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell cc buflint bufcompat

uname
Linux 27ac8c4a6643 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9550bc21542672de87259cc7be077e757e38fb97

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/1/testReport/

Max. process+thread count
910 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Probably I should have just extended the CapacitySchedulerQueueInfo for the Cluster Scheduler API (REST).
https://hadoop.apache.org/docs/stable/hadoop-yarn/hadoop-yarn-site/ResourceManagerRest.html#Cluster_Scheduler_API
marking as WIP

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 41s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 53s

trunk passed

+1 :green_heart:
compile
12m 55s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
10m 49s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 54s

trunk passed

+1 :green_heart:
mvnsite
4m 13s

trunk passed

+1 :green_heart:
javadoc
3m 19s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m 33s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
8m 27s

trunk passed

+1 :green_heart:
shadedclient
19m 43s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  8s

the patch passed

+1 :green_heart:
compile
12m  6s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
cc
12m  6s

the patch passed

+1 :green_heart:
javac
12m  6s

the patch passed

+1 :green_heart:
compile
10m 58s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
cc
10m 58s

the patch passed

+1 :green_heart:
javac
10m 58s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 54s

the patch passed

+1 :green_heart:
mvnsite
4m  3s

the patch passed

+1 :green_heart:
javadoc
3m 16s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m  5s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
8m 55s

the patch passed

+1 :green_heart:
shadedclient
20m  9s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 15s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
5m 19s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
102m 57s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
27m 19s

hadoop-yarn-client in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

316m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3314

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell cc buflint bufcompat

uname
Linux 5365ae19b87a 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 58af85160c3b883e31d76ebb5257083995261dfc

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/2/testReport/

Max. process+thread count
934 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  8s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 45s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 27s

trunk passed

+1 :green_heart:
compile
13m 14s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
10m  3s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 54s

trunk passed

+1 :green_heart:
mvnsite
3m 56s

trunk passed

+1 :green_heart:
javadoc
3m 24s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m 41s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
8m 47s

trunk passed

+1 :green_heart:
shadedclient
20m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 13s

the patch passed

+1 :green_heart:
compile
12m 31s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
cc
12m 31s

the patch passed

+1 :green_heart:
javac
12m 31s

the patch passed

+1 :green_heart:
compile
9m 31s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
cc
9m 31s

the patch passed

+1 :green_heart:
javac
9m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 35s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 582 unchanged - 0 fixed = 585 total (was 582)

+1 :green_heart:
mvnsite
3m 15s

the patch passed

+1 :green_heart:
javadoc
2m 44s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 35s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
7m 23s

the patch passed

+1 :green_heart:
shadedclient
16m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 59s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 40s

hadoop-yarn-common in the patch passed.

-1 :x:
unit
99m 45s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
27m 28s

hadoop-yarn-client in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

304m 39s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivities

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3314

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell cc buflint bufcompat

uname
Linux ec126b247cf3 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cf6bd2d0ce56348dfbdcbb177b4ed6d85b297072

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/3/testReport/

Max. process+thread count
928 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 22s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m  4s

trunk passed

+1 :green_heart:
compile
10m 12s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
8m 30s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 42s

trunk passed

+1 :green_heart:
mvnsite
3m 28s

trunk passed

+1 :green_heart:
javadoc
3m  1s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 50s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m 48s

trunk passed

+1 :green_heart:
shadedclient
17m 17s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 33s

the patch passed

+1 :green_heart:
compile
9m 28s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
cc
9m 28s

the patch passed

+1 :green_heart:
javac
9m 28s

the patch passed

+1 :green_heart:
compile
8m 32s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
cc
8m 32s

the patch passed

+1 :green_heart:
javac
8m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 37s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn-project/hadoop-yarn: The patch generated 5 new + 628 unchanged - 0 fixed = 633 total (was 628)

+1 :green_heart:
mvnsite
3m 14s

the patch passed

+1 :green_heart:
javadoc
2m 46s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 37s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
7m 19s

the patch passed

+1 :green_heart:
shadedclient
16m 51s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 59s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 41s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
99m 27s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
27m 27s

hadoop-yarn-client in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

281m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3314

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell cc buflint bufcompat

uname
Linux a8af8ccfec3d 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b1be624b791f94c3a07e58ca243782fb5b97c28c

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/4/testReport/

Max. process+thread count
912 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Probably I should have just extended the CapacitySchedulerQueueInfo for the Cluster Scheduler API (REST).
hadoop.apache.org/docs/stable/hadoop-yarn/hadoop-yarn-site/ResourceManagerRest.html#Cluster_Scheduler_API
marking as WIP

Speaking of which: Could you please update the REST API documentation?
I think the relevant sections are:

Elements of the queues object for a Parent queue
Elements of the queues object for a Leaf queue - contains all the elements in parent except ‘queues’ plus the following:

You can also add the maxParallelsApps JSON / XML property to the example responses down there.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 42s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 23s

trunk passed

+1 :green_heart:
compile
10m 41s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
9m  4s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 49s

trunk passed

+1 :green_heart:
mvnsite
4m  6s

trunk passed

+1 :green_heart:
javadoc
3m 38s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m 17s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
7m 29s

trunk passed

+1 :green_heart:
shadedclient
16m 17s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 43s

the patch passed

+1 :green_heart:
compile
9m 41s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

-1 :x:
cc
9m 41s
/results-compile-cc-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 generated 3 new + 179 unchanged - 3 fixed = 182 total (was 182)

+1 :green_heart:
javac
9m 41s

the patch passed

+1 :green_heart:
compile
9m 15s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
cc
9m 15s

the patch passed

+1 :green_heart:
javac
9m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 48s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 628 unchanged - 0 fixed = 632 total (was 628)

+1 :green_heart:
mvnsite
3m 38s

the patch passed

+1 :green_heart:
javadoc
3m 17s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m  4s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
8m  5s

the patch passed

+1 :green_heart:
shadedclient
16m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m  5s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 59s

hadoop-yarn-common in the patch passed.

-1 :x:
unit
114m 51s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
28m 13s

hadoop-yarn-client in the patch passed.

+1 :green_heart:
asflicense
1m  0s

The patch does not generate ASF License warnings.

306m 28s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.recovery.TestFSRMStateStore

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3314

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell cc buflint bufcompat

uname
Linux 1aefd69e7c52 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / bf209cf5428bc91905ed03df4d6ba34b0bcfc6df

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/5/testReport/

Max. process+thread count
942 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Probably I should have just extended the CapacitySchedulerQueueInfo for the Cluster Scheduler API (REST).
hadoop.apache.org/docs/stable/hadoop-yarn/hadoop-yarn-site/ResourceManagerRest.html#Cluster_Scheduler_API
marking as WIP

Speaking of which: Could you please update the REST API documentation?
I think the relevant sections are:

Elements of the queues object for a Parent queue
Elements of the queues object for a Leaf queue - contains all the elements in parent except ‘queues’ plus the following:

You can also add the maxParallelsApps JSON / XML property to the example responses down there.

Done. The example response was updated manually - only with the maxParallelApps properties - but it might be outdated, this part of the doc was not changed too much in the recent years.
I just noticed that the Applications and Apps is not too coherent in the Rest API:
| numApplications | int | The number of applications currently in the queue |
| maxParallelApps | int | Maximum number of applications that can run at the same time |

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 15s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 46s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m  9s

trunk passed

+1 :green_heart:
compile
13m 28s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
11m 12s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
2m  0s

trunk passed

+1 :green_heart:
mvnsite
4m 37s

trunk passed

+1 :green_heart:
javadoc
3m 58s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m 48s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 33s

branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
18m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  0s

the patch passed

+1 :green_heart:
compile
11m  4s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
cc
11m  4s

the patch passed

+1 :green_heart:
javac
11m  4s

the patch passed

+1 :green_heart:
compile
9m  6s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
cc
9m  6s

the patch passed

+1 :green_heart:
javac
9m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 40s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 628 unchanged - 0 fixed = 632 total (was 628)

+1 :green_heart:
mvnsite
3m 45s

the patch passed

+1 :green_heart:
javadoc
3m 11s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m  1s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 26s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site has no data from spotbugs

+1 :green_heart:
shadedclient
16m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 59s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 41s

hadoop-yarn-common in the patch passed.

-1 :x:
unit
99m 20s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
27m 26s

hadoop-yarn-client in the patch passed.

+1 :green_heart:
unit
0m 27s

hadoop-yarn-site in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

306m 29s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3314

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell cc buflint bufcompat markdownlint

uname
Linux 385e635152e4 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2bdbf0487474bd5f38f7957b843917c8e78448d7

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/6/testReport/

Max. process+thread count
904 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  7s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 43s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 33s

trunk passed

+1 :green_heart:
compile
12m  6s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
8m 32s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 40s

trunk passed

+1 :green_heart:
mvnsite
4m  5s

trunk passed

+1 :green_heart:
javadoc
3m 26s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m 16s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 28s

branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
16m 29s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 45s

the patch passed

+1 :green_heart:
compile
9m 28s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
cc
9m 28s

the patch passed

+1 :green_heart:
javac
9m 28s

the patch passed

+1 :green_heart:
compile
8m 31s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

-1 :x:
cc
8m 31s
/results-compile-cc-hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 1 new + 181 unchanged - 1 fixed = 182 total (was 182)

+1 :green_heart:
javac
8m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 38s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 628 unchanged - 0 fixed = 632 total (was 628)

+1 :green_heart:
mvnsite
3m 45s

the patch passed

+1 :green_heart:
javadoc
3m  9s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m  0s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 25s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site has no data from spotbugs

+1 :green_heart:
shadedclient
16m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 58s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 42s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
99m 37s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
27m 19s

hadoop-yarn-client in the patch passed.

+1 :green_heart:
unit
0m 27s

hadoop-yarn-site in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

294m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3314

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell cc buflint bufcompat markdownlint

uname
Linux 74806fd5a520 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 91edc0818b20c17f6b5d2d827f6fe5d1bd33681a

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/7/testReport/

Max. process+thread count
936 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 27s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m  4s

trunk passed

+1 :green_heart:
compile
10m 49s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
8m 55s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 48s

trunk passed

+1 :green_heart:
mvnsite
4m 14s

trunk passed

+1 :green_heart:
javadoc
3m 26s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m 11s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 27s

branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
16m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 44s

the patch passed

+1 :green_heart:
compile
9m 33s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
cc
9m 33s

the patch passed

+1 :green_heart:
javac
9m 33s

the patch passed

+1 :green_heart:
compile
8m 27s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

-1 :x:
cc
8m 27s
/results-compile-cc-hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 3 new + 179 unchanged - 3 fixed = 182 total (was 182)

+1 :green_heart:
javac
8m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 37s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 628 unchanged - 0 fixed = 632 total (was 628)

+1 :green_heart:
mvnsite
3m 42s

the patch passed

+1 :green_heart:
javadoc
3m 10s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m  0s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 25s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site has no data from spotbugs

+1 :green_heart:
shadedclient
16m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 58s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 41s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
100m  3s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
28m  1s

hadoop-yarn-client in the patch passed.

+1 :green_heart:
unit
0m 25s

hadoop-yarn-site in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

289m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3314

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell cc buflint bufcompat markdownlint

uname
Linux 94c0f871006b 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4720ac7e928ac384f03baab0bb256f303c2fdd9a

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/8/testReport/

Max. process+thread count
934 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3314/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Allow platform configuration to be set on the options argument

Useful for setting a custom output path and only generating platforms
and sizes of resources that are actually needed.

Thanks for your contribution.
Merged and published to npm registry<EMAIL_ADDRESS>

thanks! :+1:


Fix typos in README.md.

This PR fixes two small typos in Readme.md
Let me know if there is anything I should add or change.
@jdebacker

Thanks @duncanhobbs   Merging now.


Setup test/release ci

also added @parcel/config-default and @parcel/core for build

these workflows have been tested

test: https://github.com/aeongdesu/osu-bar-overlay/actions/runs/2549614656
release(tag): https://github.com/aeongdesu/osu-bar-overlay/actions/runs/2549595117

result: https://github.com/aeongdesu/osu-bar-overlay/releases/tag/testtest

Usage should be edit because I'm not good at english

Usage should be edit because I'm not good at english

You mean making it easier to understand?

You mean making it easier to understand?

yes and 2 step needs to download from releases, not clone/download the repository method
and please enable releases tab in edit repository details

Oh, i forgot that. I've updated it.

Oh, i forgot that. I've updated it.


Construct with new keyword

How do I put a function on a constructed object and tie my internal object to the instance?  The code
var client = new client();
client.get("value");

I am able to get the first line to call a native function as a ctor call with the code..
JsPropertyIdRef clientId;
JsGetPropertyIdFromName(L"client", &clientId);
JsValueRef clientCtor;
JsCreateFunction(Client, nullptr, &clientctor);
JsSetProperty(globalObject, clientId, clientctor, true);

I want to have a function on the object (get) that can call to native, but I can't figure how.  I suppose I need to associate a pointer to the instance and define a call back that is assigned to client.  I've tried a number of ways but cannot figure out.

Thanks for opening the issue @beetfarmer !
Do you want to define a native function on a class of objects or a specific instance? If latter, you have the right idea to grab the JsValueRef of the instance and set the native function as a property. If former, you need to set the native function as a property of the prototype. As an example, you can check out how I project a native ctor called JsPoint with its member functions to JS.
projectNativeClass
JSPointConstructor
JSPointPrototype

@liminzhu Thanks - It's for an instance.  The example using the JsSetPrototype did the trick.

@liminzhu Thanks - It's for an instance.  The example using the JsSetPrototype did the trick.


Updates based on Codespace Validation

I spun up a codespace and it took a bit, ~10 mins. But I also had to fiddle with it because the schema.rb file didn't have a current timestamp so bin/setup in turn didn't fully work (failed on bin/rails db:reset complaining about an un-executed migration).
Anyway -- these are the modified files from a clean env build.

(I made these changes and this PR from the browser-VSCode in a codespace!)


Kerala data is wrong for Nov 23

Kerala state level data is wrong. Today cases are 3757 but in the app its shown as 4508.Thiruvanthapuram today confirmed cases are 229 but shown in app as 980.Please correct the issue.

Has been corrected


Basic CRUD operations handled for using ionic storage

Done:

A basic CRUD operations methods are handled to use ionic storage easily.
Interfaces moved as models and each steps are defined under overall info model.

To do:

Error handling needs to be done
Async await support in functions
Backup mechanism to store in sqlite when indexed db / local storage is cleared by OS.
Storing images and files. As of now storing images as blob and base 64 formats are studied. But both has its own consequences. As indexed db supports ArrayBuffer formats , should try to use that.

Issues faced:
While choosing Iphone, when the first data is stored in indexed db, on page refresh the storage shifts to local storage. But doesn't happen with android. Because of this shift, data stored in the indexed db can't be retrieved as local forage fetched data only from the current storage system.
Further clarifications needed:
Quota allocation needs to be understood well, as it is dynamic in nature. From the guides 50% of free disk space is allocated for browser. The fraction for each storage system is unclear. Also most of the data available for web application nothing much available for mobile apps and mobile OS.

@Bharathravi1995 From my point of view, you can merge it. I wasn't sure if you want to do add anything here, so I didn't merge it.
Btw: You are doing a lot of work/reasearch here. I believe this takes a lot of time. --> Thumbs up 👍 👍 👍 Maybe, we could split our work so that you can concentrate more on the Storage issues and I concentrate more on the UI/Forms? I just want to make sure you don't get burned out :D Storage can become pretty complex...

@Bharathravi1995 From my point of view, you can merge it. I wasn't sure if you want to do add anything here, so I didn't merge it.
Btw: You are doing a lot of work/reasearch here. I believe this takes a lot of time. --> Thumbs up 👍 👍 👍 Maybe, we could split our work so that you can concentrate more on the Storage issues and I concentrate more on the UI/Forms? I just want to make sure you don't get burned out :D Storage can become pretty complex...

Yes we can split it and work. Now I gonna merge this PR.


Model fails with exception if given epoch more than 62

Hi,
I'm trying to run your model on python 3.8.5 with the Tensorflow version of 2.3.1.
It works fine with lower epochs but as soon as it goes to 62 or higher epoch, the model fails with the exception given below
2021-01-06 15:28:33.866558: W tensorflow/core/kernels/data/generator_dataset_op.cc:103] Error occurred when finalizing GeneratorDataset iterator: Failed precondition: Python interpreter state is not initialized. The process may be terminated.
[[{{node PyFunc}}]
Have you faced such an error or can you tell what can be the solution for it?
Thanks in advance!

Hi,
no actually I did not. I tested the repository with Tensorflow 2.2 and python 3.7 and I did not remember an error there. It is a bit strange that error occurs after a certain number of epochs. Normally when there is an error with the generator it should come up at the first epoch. Try to downgrade to 2.2, the performance should be similar.
Did you change anything from the standard setup?

Hi,
no actually I did not. I tested the repository with Tensorflow 2.2 and python 3.7 and I did not remember an error there. It is a bit strange that error occurs after a certain number of epochs. Normally when there is an error with the generator it should come up at the first epoch. Try to downgrade to 2.2, the performance should be similar.
Did you change anything from the standard setup?


Scientists want predictable downloads of annotated expression matrices from the portal dataset-view

Story
Scientists want predictable downloads of annotated expression matrices from the portal dataset-view. The size of downloads can be large and require a large time investment to complete. Network interruptions or timeouts should not require scientists to restart a large download.

Per discussion with @tihuan and @mckinsel - resumable downloads are paused until we have more signal from users.


Ability To rename or naming while saving.

Yes! Invoke the SAF save as dialogue. If you tap on an existing filename it will write that filename to the dialogue. It's even possible to overwrite this way. User has control.

Added this to one time save location dialog when long pressing FAB

It's available


image: impl From for String

I considered converting the media type strings to constants so they can be
referenced without allocating a String but since these types aren't
comprehensive (ie we always have to deal with unknown types so we could never
impl From<String> for &'static str) I don't think that's necessary.
Signed-off-by: wayne warren<EMAIL_ADDRESS>

Codecov Report

Merging #146 (382d7f5) into main (c109fe1) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   22.61%   22.43%   -0.19%
==========================================
  Files          23       23
  Lines        2069     2086      +17
  Branches     1146     1146
==========================================
  Hits          468      468
- Misses        791      808      +17
  Partials      810      810

@waynr may I ask you to squash your commits or sign-off the last one?

@saschagrunert WDYT?


Revisions UI (#2170 rebased)

just to give it a run through CI...

Merged in 5e07bead42d35bf703bf69f47f1ddc2cbf9839ee + parents

But, you forgot localizate this feature:

My project are in Spanish and the admin is in spanish, but revisions still is english.

@SalahAdDin I suspect it's because it hasn't been translated. Revisions haven't yet been translated in Italian either (https://www.transifex.com/torchbox/wagtail/translate/#it/wagtailadmin/77472003?translated=no) @gasman is a maintainer of the Transifex project and would be able to corroborate that more easily than I can.

@heymonkeyriot @SalahAdDin That's correct, yes. Translations can only happen after the feature has been merged, and this was one of the last features to be merged for 1.4rc1 - as a result, there was no time window before 1.4rc1 for the translations to be done. The Spanish translation has now been completed, and the translations will be included in the final 1.4 release.

Oh yeah! It's a goo news, good works :+1:


Remove obsolete Config override that causes problems in Android Studio

This annotation is causing CourseUnitNavigationActivityTest to fail when run from Android Studio.
As it turns out, we no longer need the annotation, so I removed it.
Reviewers
If you've been tagged for review, please check your corresponding box once you've given the :+1:.

[ ] Code review: @BenjiLee

Thanks for the pull request, @bguertin! I've created OSPR-1307 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.
Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.
We can't start reviewing your pull request until you've submitted a     signed contributor agreement     or indicated your institutional affiliation.     If you like, you can add yourself to the AUTHORS      file for this repo, though that isn't required.     Please see the CONTRIBUTING     file for more information.

👍

@1zaman thoughts ??


Regenerate docs

Regenerate docs
This PR generates up-to-date docs.
Wed Mar 21 2018 ->
Thu Sep 27 2018
https://gsuitedevs.github.io/apps-script-oauth2/

What do you think about linking the docs in the README?

Good catch! It is linked to in the README (see "generated reference documentation"), just not very prominently.


Chords: conf.tooltipContent is not a function

I get this error every time I hover over a chord, even when running the demo.

Turns out you just had to add tooltipContent as a config option.


New feature (--scan-all). Changed number of processes to be equal to number of cores

You can now run
s3tk scan-object-acl --scan-all
to scan all the bucket for open rights.
Also combine --also-private to show custom and private rights.
I.e
Usage: s3tk scan-object-acl [OPTIONS] [BUCKET]
Options:
--only TEXT Only certain objects
--except TEXT Except certain objects
--scan-all Scan and show all public buckets
--also-private Also private
--help Show this message and exit.
Also shows at the end the totals for right types and for items.
Will not exit on Boto ClientError on Bucket (i.e Permission, Non-existent bucket etc.), simply continue to next object/Bucket.

Hey @marcinguy, thanks for the PR 👍  I'm worried about the complexity this adds to the code without much benefit. I'd recommend writing a shell script around s3tk to achieve this.

Cleaning up stale PRs


Syntax error not showing in node inspect in node 12+

HI,
I'm trying a simple script with a syntax error in it but I'm not getting the error displayed when running with node versions 12+. Older versions are ok. I've tried this script (in test.js):
console.log(1)
console.log(2
console.log(3)

When running with node 11, I'm seeing the error:
# node-inspect test.js
< Debugger listening on ws://<IP_ADDRESS>:9229/9f22bef2-a0db-4c2d-89d6-f741e1f3c9cd
< For help, see: https://nodejs.org/en/docs/inspector
< Debugger attached.
< /test.js:2
< console.log(1
<             ^
< SyntaxError: missing ) after argument list
<     at Module._compile (internal/modules/cjs/loader.js:760:23)
<     at Object.Module._extensions..js (internal/modules/cjs/loader.js:827:10)
<     at Module.load (internal/modules/cjs/loader.js:685:32)
<     at Function.Module._load (internal/modules/cjs/loader.js:620:12)
<     at Function.Module.runMain (internal/modules/cjs/loader.js:877:12)
<     at internal/main/run_main_module.js:21:11
< Waiting for the debugger to disconnect...
debug>

But with node 12+ (tried 13,14) the error is not echoed in the terminal and I'm getting:
/ # node-inspect test.js
< Debugger listening on ws://<IP_ADDRESS>:9229/583b30fe-ab2d-43f9-af41-a23d0148c985
< For help, see: https://nodejs.org/en/docs/inspector
< Debugger attached.
< Waiting for the debugger to disconnect...
debug>

I would like to get the error echoed in the terminal. Is this a valid output or I'm doing anything wrong?
Thanks-

This also reproduces with node --inspect-brk. The difference is that there the console API is forwarded to the DevTools. But in the terminal, the error is silently omitted.
I think swallowing the stderr output when attaching a remote debugger is likely a bug and worth fixing.


Probably a network error, is the server down?: [object Object]

I try to use janus's demo page.and I get this error:
Probably a network error, is the server down?: [object Object]
I noticed the page get a url like this:
 https://www.iocollege.com:8089/janus
In fact,this no programe listen to the port 8089. and I try to do like this:
`
cp /root/janus-gateway/conf/janus.transport.http.jcfg.sample /opt/janus/etc/janus/janus.transport.http.jcfg
nano /opt/janus/etc/janus/janus.transport.http.jcfg
general:
https = true
secure_port = 8089
admin:
admin_https = true
certificates:
cert_pem = "/opt/cert.pem"
cert_key = "/opt/pkey.pem"
`
so,maybe some error stop to configs to general /janus.transport.http.jcfg .my config and run like this:
./configure --prefix=/opt/janus --enable-websockets
/opt/janus/bin/janus
and get this:
`
Janus commit: 0028c714080fc3e4aad0a85171b1dfc73d2489cc
Compiled on:  2020? 03? 31? ??? 15:30:04 CST
Logger plugins folder: /opt/janus/lib/janus/loggers
[WARN] 	Couldn't access logger plugins folder...
Starting Meetecho Janus (WebRTC Server) v0.9.3
Checking command line arguments...
Debug/log level is 4
Debug/log timestamps are disabled
Debug/log colors are enabled
Adding 'vmnet' to the ICE ignore list...
Using <IP_ADDRESS> as local IP...
[WARN] Token based authentication disabled
Initializing recorder code
Initializing ICE stuff (Full mode, ICE-TCP candidates disabled, half-trickle, IPv6 support disabled)
STUN server to use: www.iocollege.com:3478

<IP_ADDRESS>:3478 (IPv4)
Testing STUN server: message is of 20 bytes
Our public address is <IP_ADDRESS>
TURN server to use: www.iocollege.com:3478 (udp)
TURN REST API backend: (disabled)
Crypto: OpenSSL pre-1.1.0
[WARN] The libsrtp installation does not support AES-GCM profiles
Fingerprint of our certificate: 7C:04:84:B5:9F:20:26:7B:1D:E4:17:BD:C0:3C:BE:98:51:E5:1C:DB:BD:A5:78:B1:3E:C8:C7:84:FD:2C:5D:FE
[WARN] Event handlers support disabled
Plugins folder: /opt/janus/lib/janus/plugins
Loading plugin 'libjanus_textroom.so'...
JANUS TextRoom plugin initialized!
Loading plugin 'libjanus_recordplay.so'...
JANUS Record&Play plugin initialized!
Loading plugin 'libjanus_videoroom.so'...
JANUS VideoRoom plugin initialized!
Loading plugin 'libjanus_echotest.so'...
JANUS EchoTest plugin initialized!
Loading plugin 'libjanus_streaming.so'...
JANUS Streaming plugin initialized!
Loading plugin 'libjanus_videocall.so'...
JANUS VideoCall plugin initialized!
Loading plugin 'libjanus_voicemail.so'...
JANUS VoiceMail plugin initialized!
Loading plugin 'libjanus_audiobridge.so'...
JANUS AudioBridge plugin initialized!
Loading plugin 'libjanus_nosip.so'...
JANUS NoSIP plugin initialized!
Transport plugins folder: /opt/janus/lib/janus/transports
Loading transport plugin 'libjanus_pfunix.so'...
[WARN] Unix Sockets server disabled (Janus API)
[WARN] Unix Sockets server disabled (Admin API)
[WARN] No Unix Sockets server started, giving up...
[WARN] The 'janus.transport.pfunix' plugin could not be initialized
Loading transport plugin 'libjanus_websockets.so'...
Sessions watchdog started
Joining Janus requests handler thread
[WARN] libwebsockets has been built without IPv6 support, will bind to IPv4 only
libwebsockets logging: 0
WebSockets server started (port 8188)...
Secure WebSockets server started (port 8989)...
[WARN] Admin WebSockets server disabled
Secure Admin WebSockets server started (port 7989)...
JANUS WebSockets transport plugin initialized!
Loading transport plugin 'libjanus_rabbitmq.so'...
RabbitMQ SSL support disabled
[WARN] RabbitMQ support disabled (Janus API)
[WARN] RabbitMQ support disabled (Admin API)
[WARN] RabbitMQ support disabled for both Janus and Admin API, giving up
[WARN] The 'janus.transport.rabbitmq' plugin could not be initialized
WebSockets thread started
`

so,is sth error ?why not listen 8089(is websocket plugin's reason )?

I guess you're having issue with https://janus.conf.meetecho.com/ that is WebRTC server that is not related to Janus API Gateway, just the same name.


Separate lib module

Isolate independent modules from the Minestom framework and its opinionated control flow.
Files would have to be slowly moved over (Palette, Registry, Packet). Shouldn't be done in one go.
Goals are:

Encourage more features to be independent from Entity/Instance
Better organize our utils by considering them as their own library
Make the future scratch module/repo more appealing

<3

Marking ready for review so the ci triggers


Added .NET Core Uninstall Tool Docs

Summary
Added documentation for .NET Core Uninstall Tool (dotnet-core-uninstall).
Discussed with @KathleenDollard, @rowanmiller and @leecow.

I think this should be it's own article in the /additional-tools/ folder. Something like one of the other existing ones: https://docs.microsoft.com/en-us/dotnet/core/additional-tools/dotnet-svcutil-guide?tabs=dotnetsvcutil2x and it should be a tutorial with command line reference. Jamming it in here is out of place and makes it harder to find the tool reference itslef.
And the article you've changed here should just link off to the standalone uninstall tool article.

Closing this PR because #13562 is a duplicate.


Change storage configuration to support multiple concurrent snapshots

The API changes made in #743 allows for multiple snapshots to be returned from an Event Store.
The storage needs to be adapted to allow storage of multiple concurrent versions of snapshots and define a cleanup strategy for removing old snapshots.

After discussing with the team, we have decided not to implement this in the EmbeddedEventStore. Conceptually, there is no version concurrency on this Event Store implementation. Changing the Storage Engine to support this will result in complex migrations.


Band-edge positions evaluated via sumo-bandstats in collinear antiferromagnetic NiO

Is it possible to change the method of searching for band-edge positions in spin-polarized systems?
My purpose is on the quick calculation of effective masses in various insulators including spin-polarized systems with non-zero spin magnetic moments.
As shown in the band-dispersion diagram attached here, in collinear antiferromagnetic NiO (AFM NiO), its VBM and CBM are in (0.500, 0.500, 0.500) (T point) and (-0.438, 0.312, 0.312) (in T-H2 line), respectively.
This diagram was created via vise, which is developed by Y. Kumagai.
The band-edge positions mentioned above are also visually confirmed in a vasprun.xml file and an OUTCAR file.
band_NiO_ColinearAFM.pdf
However, the command sumo-bandstats seems to give a different result from the above.
The CBM position is not consistent with the above result.
Meanwhile, in spin-unpolarized systems, VBM and CBM positions seem to be successfully found.
The part of the results of the command sumo-bandstats in AFM NiO is as follows:
Valence band maximum:
Energy: 6.623 eV
k-point: [0.50, 0.50, 0.50]
k-point location: T
k-point indices: 32
k-point degeneracy: 1
Band indices: 21, 22(Up), 21, 22(Down)
Conduction band minimum:
Energy: 10.020 eV
k-point: [0.61, 0.39, 0.50]
k-point location: between GAMMA-H_2
k-point indices: 55
k-point degeneracy: 6
Band indices: 23(Up), 23(Down)

There is no direct Gamma-H2 segment in this band dispersion plot; it seems to be calculated on a different k-point path to the sumo-bandstats data? Do you have a sumo-bandplot output we can compare with the vise plot? Is it from the same calculation?

Thank you very much for reply!
The high-symmetry k-point paths in the fully relaxed AFM-NiO cell were gererated via the SeeK-path program in vise.
I knew that sumo had also the SeeK-path program yesterday, but in my calculation mentioned above, the SeeK-path program in vise was used.
A band dispersion diagram created via sumo-bandplot is here.
Compared with the diagrams created via vise and sumo-bandplots, the same k-point positions of the band egdes (VBM and CBM) appeared; that is, the VBM position was at the T point, and the CBM position was at the point in the T-H2 line.
band_NiO_CollinearAFM_sumo-bandplot.pdf
The space group in my AFM-NiO cell with magnetic moment in two Ni atoms was R-3m.
R-3m appears only in the case of non-zero Ni magnetic moment.
On the other hand, a conventional NiO cell without magnetic moment, as you may know, its space group is Fm-3m.
Your opinion is that this difference in space group judging from atomic positions can be problematic in my analysis, isn't it?
If there is a way to force the space group R-3m to be imposed, could you please let me know?

You can force sumo-kgen to use the seekpath path with --seekpath, and to use a given spacegroup with --spg. https://smtg-bham.github.io/sumo/sumo-kgen.html#usage You need the spacegroup number, which for R-3m is 166.
It looks like the paths are the same in your plots, anyway, so we can compare directly. Are you sure that sumo-bandstats gives the output in the initial post when run on the file plotted here? It is quite puzzling that it would find a point on the Gamma->H2 path if that path does not exist in the data.
Magnetic spacegroups can be a headache indeed and you will probably have to deal with them at some point: but as these plots are on the same path I don't think that is causing the discrepancy.


[SPARK-48929] Fix view internal error and clean up parser exception context

What changes were proposed in this pull request?

Replace INVALID_VIEW_TEXT (SQLSTATE: XX000) error-condition which is forced when view expansion fails to parse with the underlying error.
The reason being that the underlying error has important information AND it is much more likely that view expansion fails because of a behavior change in the parser than some nefarious action or simple corruption.
For example the recent removal of ! and NOT equivalence fails old view on on Spark 4.0 if they exploit the unsupported syntax.
As part of this change we also include the Query context summary in the ParserException processing.
This will expose the view name along side the view query error message.
Why are the changes needed?

Better error handling improving ability of customers to do root cause analysis.
Does this PR introduce any user-facing change?

We are now giving more error context in case of parer errors and specifically in case of parser errors in view expansion
How was this patch tested?

Existing QA
Was this patch authored or co-authored using generative AI tooling?

No

LGTM except for one minor comment

Thanks, merging to master


Add the empty_string_as_null option for COPY FROM.

Summary of the changes / Why this improves CrateDB
If empty_string_as_null is true, then all column's values
represented by an empty string, including a quoted empty string,
are set toNULL.
Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

@kovrus Did you consider using FORCE_NULL(field1,...) instead  which @amotl mentioned recently at #10563. This would also make it postgresql compatible.

retest this please

Relates https://github.com/crate/crate/issues/10563


Atmos landing page

Work In progress. [WIP]

Help needed to disable Scroll or move to next page on scrolling.

Ready to merge.

Urgent merge.


Two test failures on ppc64le

Describe the bug
While packaging version 1.0.3 for Fedora linux, we found that the tests test_csd_morlet and test_time_frequency fail on ppc64le.
Steps to reproduce
Run the unit tests on a ppc64le system. There is no reason to believe this error is specific to the Fedora Linux RPM build environment.
Expected results
All tests pass.
Actual results
=================================== FAILURES ===================================
_______________________________ test_csd_morlet ________________________________
mne/time_frequency/tests/test_csd.py:529: in test_csd_morlet
    assert_allclose(csd._data[[0, 3, 5]] * sfreq, power)
E   AssertionError:
E   Not equal to tolerance rtol=1e-07, atol=0
E
E   Mismatched elements: 9 / 9 (100%)
E   Max absolute difference: 13.4892946
E   Max relative difference: 0.99930094
E    x: array([[2.698620e+01+3.629330e-17j, 9.270776e-04+1.165640e-21j,
E           2.699776e+01-1.773874e-17j],
E          [2.698733e+01+3.677728e-17j, 1.591260e-03-2.498003e-21j,...
E    y: array([[1.350002e+01, 2.383404e-03, 1.351705e+01],
E          [1.349949e+01, 2.270551e-03, 1.603048e-04],
E          [1.349873e+01, 6.293613e-03, 1.350833e+01]])
----------------------------- Captured stdout call -----------------------------
Not setting metadata
1 matching events found
Applying baseline correction (mode: mean)
0 projection items activated
0 bad epochs dropped
Computing cross-spectral density from epochs...
[done]
Computing cross-spectral density from epochs...
[done]
Computing cross-spectral density from epochs...
[done]
Computing cross-spectral density from epochs...
[done]
Computing cross-spectral density from epochs...
[done]
----------------------------- Captured stderr call -----------------------------

  0%|          | CSD epoch blocks : 0/1 [00:00<?,       ?it/s]
100%|██████████| CSD epoch blocks : 1/1 [00:00<00:00,  850.08it/s]

  0%|          | CSD epoch blocks : 0/1 [00:00<?,       ?it/s]
100%|██████████| CSD epoch blocks : 1/1 [00:00<00:00,  911.01it/s]

  0%|          | CSD epoch blocks : 0/1 [00:00<?,       ?it/s]
100%|██████████| CSD epoch blocks : 1/1 [00:00<00:00,  745.79it/s]

  0%|          | CSD epoch blocks : 0/1 [00:00<?,       ?it/s]
100%|██████████| CSD epoch blocks : 1/1 [00:00<00:00,  900.26it/s]

  0%|          | CSD epoch blocks : 0/1 [00:00<?,       ?it/s]
100%|██████████| CSD epoch blocks : 1/1 [00:00<00:00,  887.12it/s]
_____________________________ test_time_frequency ______________________________
mne/time_frequency/tests/test_tfr.py:132: in test_time_frequency
    assert_allclose(epochs_amplitude_2.data**2, epochs_power_picks.data)
E   AssertionError:
E   Not equal to tolerance rtol=1e-07, atol=0
E
E   Mismatched elements: 17637 / 17640 (100%)
E   Max absolute difference: 8.4915913e-21
E   Max relative difference: 63.63766583
E    x: array([[[[6.565396e-24, 3.838394e-24, 1.699187e-24, ..., 1.025243e-22,
E             8.846176e-23, 7.457034e-23],
E            [1.024062e-22, 9.587875e-23, 8.570987e-23, ..., 6.220701e-23,...
E    y: array([[[[9.130315e-23, 9.576540e-23, 9.999026e-23, ..., 2.239139e-22,
E             2.292956e-22, 2.341922e-22],
E            [1.239185e-22, 1.324456e-22, 1.410500e-22, ..., 1.732860e-22,...
----------------------------- Captured stdout call -----------------------------
Opening raw data file /builddir/build/BUILD/mne-python-1.0.3/mne/time_frequency/tests/../../io/tests/data/test_raw.fif...
    Read a total of 3 projection items:
        PCA-v1 (1 x 102)  idle
        PCA-v2 (1 x 102)  idle
        PCA-v3 (1 x 102)  idle
    Range : 25800 ... 40199 =     42.956 ...    66.930 secs
Ready.
Not setting metadata
7 matching events found
Setting baseline interval to [-0.19979521315838786, 0.0] sec
Applying baseline correction (mode: mean)
3 projection items activated
Loading data for 7 events and 420 original time points ...
0 bad epochs dropped
Not setting metadata
7 matching events found
Setting baseline interval to [-0.19979521315838786, 0.0] sec
Applying baseline correction (mode: mean)
Created an SSP operator (subspace dimension = 3)
3 projection items activated
Loading data for 1 events and 420 original time points ...
Removing projector <Projection | PCA-v1, active : True, n_channels : 102>
Removing projector <Projection | PCA-v2, active : True, n_channels : 102>
Removing projector <Projection | PCA-v3, active : True, n_channels : 102>
Loading data for 7 events and 420 original time points ...
Loading data for 7 events and 420 original time points ...
Loading data for 7 events and 420 original time points ...
Loading data for 7 events and 420 original time points ...
0 bad epochs dropped
Loading data for 7 events and 420 original time points ...
Not setting metadata
Loading data for 7 events and 420 original time points ...
Loading data for 7 events and 420 original time points ...
Loading data for 7 events and 420 original time points ...
Not setting metadata

Additional information
Platform:         Linux-5.18.10-200.fc36.ppc64le-ppc64le-with-glibc2.35.9000
Python:           3.11.0b5 (main, Jul 26 2022, 00:00:00) [GCC 12.1.1 20220628 (Red Hat 12.1.1-3)]
Executable:       /usr/bin/python3
CPU:              ppc64le: 8 cores
Memory:           Unavailable (requires "psutil" package)
mne:              1.0.3
numpy:            1.22.0 {blas=flexiblas, lapack=flexiblas}
scipy:            1.8.1
matplotlib:       3.5.2 {backend=agg}
sklearn:          1.0.2
numba:            Not found
nibabel:          3.2.2
nilearn:          0.9.1
dipy:             1.5.0
cupy:             Not found
pandas:           1.3.5
pyvista:          Not found
pyvistaqt:        Not found
ipyvtklink:       Not found
vtk:              9.1.0
PyQt5:            5.15.6
ipympl:           Not found
pooch:            v1.5.2
mne_bids:         Not found
mne_nirs:         Not found
mne_features:     Not found
mne_qt_browser:   Not found
mne_connectivity: Not found

I am happy to run any additional tests that may be helpful, or try any candidate fixes, on real or emulated ppc64le hardware.

@sanjayankur31

Out of curiosity, what backend is flexiblas using? I think the default is OpenBLAS, could you run the tests with the Netlib backend?

Out of curiosity, what backend is flexiblas using? I think the default is OpenBLAS, could you run the tests with the Netlib backend?

I will try it.

With the Netlib backend (export FLEXIBLAS=NETLIB), the two failures reported here on ppc64le and the one failure reported in https://github.com/mne-tools/mne-python/issues/10984 on aarch64 disappear; there is, however, a new failure on x86_64:
________________________ test_make_eeg_average_ref_proj ________________________
mne/tests/test_proj.py:341: in test_make_eeg_average_ref_proj
    assert_array_almost_equal(reref._data[eeg].mean(axis=0), 0, decimal=19)
E   AssertionError:
E   Arrays are not almost equal to 19 decimals
E
E   Mismatched elements: 11 / 14400 (0.0764%)
E   Max absolute difference: 1.8973538e-19
E   Max relative difference: inf
E    x: array([4.4017478825648476e-20, 5.3052496929694344e-20,
E          4.4440995299275626e-20, ..., 4.5344497109680210e-20,
E          4.2408116225865306e-20, 5.2346636140315759e-20])
E    y: array(0)
----------------------------- Captured stdout call -----------------------------
Opening raw data file /builddir/build/BUILD/mne-python-1.0.3/mne/tests/../io/tests/data/test_raw.fif...
    Read a total of 3 projection items:
        PCA-v1 (1 x 102)  idle
        PCA-v2 (1 x 102)  idle
        PCA-v3 (1 x 102)  idle
    Range : 25800 ... 40199 =     42.956 ...    66.930 secs
Ready.
Reading 0 ... 14399  =      0.000 ...    23.974 secs...
Adding average EEG reference projection.
1 projection items deactivated
Created an SSP operator (subspace dimension = 4)
4 projection items activated
SSP projectors applied...

With the Netlib backend (export FLEXIBLAS=NETLIB), the two failures reported here on ppc64le and the one failure reported in #10984 on aarch64 disappear

Cool, so those two architectures now pass all tests, right?

there is, however, a new failure on x86_64

This test looks like it is too strict (19 decimals), the actual difference is still very small. We might consider relaxing the test a bit. Can you see what the smallest number of decimals is until this test passes?

Thanks for looking at this.

Cool, so those two architectures now pass all tests, right?

Correct, on Netlib BLAS. Does this project target only Netlib BLAS, or should these tests pass on other BLASes? Or do you think these are actual bugs in OpenBLAS?
Obviously, we can run the tests with Netlib BLAS in the Fedora RPM build if we like, but we can’t enforce a particular flexiblas backend at runtime.

This test looks like it is too strict (19 decimals), the actual difference is still very small. We might consider relaxing the test a bit. Can you see what the smallest number of decimals is until this test passes?

Based on Max absolute difference: 1.8973538e-19, you would expect 18, and my testing confirms that is sufficient in practice. It is still a very strict bound.

Correct, on Netlib BLAS. Does this project target only Netlib BLAS, or should these tests pass on other BLASes? Or do you think these are actual bugs in OpenBLAS?

I'm not sure, I really am no expert, but what I know is that OpenBLAS is very fast but sometimes not that mature. We do not target any particular BLAS implementation, ideally it should not matter at all. AFAIK we don't test different BLAS implementations but just take whatever NumPy defaults to on our test platforms (which do not include ARM64).

Obviously, we can run the tests with Netlib BLAS in the Fedora RPM build if we like, but we can’t enforce a particular flexiblas backend at runtime.

We should take a closer look at the failing tests, maybe we can work around this issue somehow. But the more I think about it, the more I believe that this might be an upstream issue. Can you find out which NumPy function is causing the problematic output?

Based on Max absolute difference: 1.8973538e-19, you would expect 18, and my testing confirms that is sufficient in practice. It is still a very strict bound.

Good, I'm OK with lowering the tolerance to 18 digits, but I want to confirm with others. @larsoner WDYT?

Yes 18 digits is fine for that test, feel free to open a PR
Indeed we should dig into whether it's an OpenBLAS bug or if we need to adjust some tolerance at our end internally (e.g., a 1e-6 instead of 1e-7 in a pinv rtol or something that eventually causes a division by zero) to make it work
@musicinmybrain do you have any suggestions for where I could read about how to emulate aarch64 to replicate this failure? Then I could dig into OpenBLAS etc.

Yes 18 digits is fine for that test, feel free to open a PR

OK!
You could set up a self-hosted runner, they support Linux ARM64. Ideally, you could install Fedora 36.

@musicinmybrain do you have any suggestions for where I could read about how to emulate aarch64 to replicate this failure? Then I could dig into OpenBLAS etc.

Personally, I’m using Fedora 36 on x86_64 (but a Fedora 36 VM could work too). I’ve done dnf install fedora-packager and set up mock to do RPM builds in a chroot, and I’ve done dnf install qemu-user-static to allow software emulation of other architectures.
Then it’s something like:
fedpkg co python-mne
cd python-mne
# Edit the spec file as needed (switch BLAS, uncomment test skips, etc.)
fedpkg mockbuild --root fedora-rawhide-aarch64 --no-cleanup-after

The emulation is not fast, but it works.
Anyone can do the above. As a Fedora packager, I can also run (non-interactive but arbitrary) experiments on real hardware.
Another thing that might work for you is Oracle Cloud’s free tier, which now includes an aarch64 instance.

The emulation is not fast, but it works.

Okay I'll give this a shot. I'm on Ubuntu 22.04 but I'm assuming the commands are easy to translate. I'll post here with what I used if I can replicate, then hopefully I'll be able to isolate if it's an OpenBLAS bug or something at our end.
FYI @musicinmybrain we are going to release 1.1 in the next couple of days. I doubt this tol issue will be fixed by then, but we could fix it in the next few weeks and push out a 1.1.1 if it would help with packaging. But at least for now it seems like https://github.com/mne-tools/mne-python/pull/10993 will land in 1.1, so you could also package 1.1 as long as you can tell it to run test using the Netlib BLAS on that arch for now.

I'm on Ubuntu 22.04 but I'm assuming the commands are easy to translate. I'll post here with what I used if I can replicate, then hopefully I'll be able to isolate if it's an OpenBLAS bug or something at our end.

It’s not convenient for me to test this, but allegedly, on Ubuntu, you can install qemu-efi and then use virt-manager to set up an emulated VM using the appropriate ISO.

you can install qemu-efi and then use virt-manager to set up an emulated VM using the appropriate ISO.

I set up a qemu image using ppc64le arch and a pseries CPU (default for that arch), then installed the Fedora 36 ppc64le image, logged in, and did:
$ sudo dnf install -y python3.10 openblas git python3-pip python3-numpy python3-scipy python3-matplotlib python3-threadpoolctl
$ python3.10 -c "import numpy"
Illegal instruction (core dumped)
$ sudo dnf -y install gdb
$ gdb --args python3.10 -c "import numpy; print(numpy)"
... enable debuginfo
(gdb) run
... a lot of downloads

Then:

Maybe this is related to https://bugs.launchpad.net/ubuntu-power-systems/+bug/1920784 -- not sure.
So I'm a bit stuck @musicinmybrain -- is there a different CPU you'd recommend that I perhaps try?


Not working with Villager hats mod

https://github.com/Lemonszz/villager-hats/releases/tag/1.14-1.0.0
cosmetic-armor-slots-1.0.0.jar

Looks like a compatibility issue with how the player renders different features. I'm not sure if this will require the creation of an API to solve this, or if I can add some fancy way of detecting armor-like features that draw over the player.

Fixed by commit 435985b10016cd3911dc56abbd48400b69d22b9a.


bump xla to enabled batching in gather

Since we were using an "old" version of XLA we where missing the batching dims stablehlo attribute.
This was preventing the usage of batching in the gather operator.
Since I had already wrote the batching test before hand and was just ignoring the compilation error,
this PR just bump xla and remove the error suppression code in tests.

it could also help #19 which was using a Cuda 560.


MultiDrag: onAdd return undefined items

Hello again!!
I appreciate the help provided for each case reported, This component is almost ready! its functionality seems to be nearing completion, I was testing the latest changes made and everything seemed to be working the best way when a new error came out.
Then I leave the demonstration and follow-up.
Apparently it occurs in the event of  onAdd, followed by the functions : createCustoms, createNormalized, removeNodes, handleStateAdd.
At some point the items change to undefined, I don't know if the problem comes from a previous action,but I could tell when I applied a debugger about the onAdd event following the next steps.

And, my code:
import React, {Component, Fragment} from 'react';

import { MultiDrag, ReactSortable, Sortable } from 'react-sortablejs';

import styled from "styled-components";

Sortable.mount(new MultiDrag());

export const Item = styled.div`
  display: flex;
  padding: 0.3rem;
  border-radius: 0.2rem;
  background-color: #fff6;
  margin-bottom: 0.3rem;
  &.sortable-ghost {
    background-color: #c8ebfb;
  }
`;

const defs = { chosen: false, filtered: false, selected: false };

class App extends Component{

  constructor(props){
    super(props);

    this.state={
      list: [
          { id: 1, name: "shrek1", ...defs },
          { id: 2, name: "shrek2", ...defs },
          { id: 3, name: "shrek3", ...defs },
          { id: 4, name: "shrek4", ...defs }
      ],
      list1: [
        { id: 5, name: "shrek5", ...defs },
        { id: 6, name: "shrek6", ...defs },
        { id: 7, name: "shrek7", ...defs },
        { id: 8, name: "shrek8", ...defs }
      ]
    }
  }

  render(){

    const {list, list1} = this.state;

    console.log('este es', list, list1);
    return (
      <Fragment>
      <Column>
            <ReactSortable
              multiDrag
              list={list}
              setList={(list)=> {
                this.setState({list})}
              }
              animation={150}
              group="shrek"
            >
              {list.map(item => (
                <MultiDragItem key={item.id}>{item.name}</MultiDragItem>
              ))}
            </ReactSortable>
            <ReactSortable
              multiDrag
              list={list1}
              setList={(list1)=> {
                this.setState({list1})}
              }
              animation={150}
              group="shrek"
            >
              {list1.map(item => (
                <MultiDragItem key={item.id}>{item.name}</MultiDragItem>
              ))}
            </ReactSortable>
          </Column>
      </Fragment>
    )
  }
}

export default App;

const Column = styled.div`
  display: flex;
  width: inherit;
  & > * {
    width: 100%;
    margin-left: 0.3rem;
    :first-child() {
      margin-left: 0rem;
    }
  }
`;

const MultiDragItem = styled(Item)`
  &.sortable-selected {
    background-color: #0a0a;
  }
`;

PD: Feliz Navidad!!! Merry Christmas!! from COL...!!

@jhonct12 I imported your component into an example and am unable to replicate it. Both states match for me.
What actions did you do before state became out of sync? I'm dragging and dropping randomly but can't get it to bug out.
I think I'll have to build in a way to check what items parsed in are actually being displayed, to check sync.

@jhonct12 I've found some buginess in the multidrag. At this stage it looks like react can't update the state fast enough. I may have to do this at another time. Merry christmas!

@jhonct12 I imported your component into an example and am unable to replicate it. Both states match for me.
What actions did you do before state became out of sync? I'm dragging and dropping randomly but can't get it to bug out.
I think I'll have to build in a way to check what items parsed in are actually being displayed, to check sync.

@waynevanson thanks for answering!!
I have generated it again, apparently it only happens when you select two or more items in a list and pass them and fold this other list without removing any selected ones, select others and pass them to the source list:
example:
X List:
a, b, c, d
List Y:
e, f, g, h
select a and b, move these items.
Ready and left:
e, f, g, h, a and b. a and b remain selected.
select e and f and move them to list X.
The component stops working.
simulation:

@jhonct12 I've found some buginess in the multidrag. At this stage it looks like react can't update the state fast enough. I may have to do this at another time. Merry christmas!

@waynevanson Thank you for your collaboration and be very attentive! greetings and happy holidays!!!


Feature/quote form

I updated design based on Zeplin.

Half of the code has a BEM structure, check that all classes have the same structure.

En el número de huéspedes debería limitarse .

En el número de huéspedes debería limitarse .

Se podría manejar como un improvement.

The line on the input is not aligned to the text.
Blue color when focused is not the same that the one used in Zeplin.
Enviar a mi Correo button should be centered.
Please don't use percentage to place the alert icon.
Desktop view still needs to be implemented.

please change the labels when it's ready

"Cotización enviada con éxito ✔" appears on page load, this should only appear after a successful submission

Repeating comment since it was totally ignored:
"
"Cotización enviada con éxito ✔" appears on page load, this should only appear after a successful submission
"


Nothing happens when user tap on “CELO deposit received....Tap to learn more” blue banner when user taps on banner if user received CELO from other user while app is open

Frequency: 100%
Repro on build version: Appstore build 1.15.2, Playstore build 1.15.2
Repro on devices: iPhone SE 1st Generation, iPhone 6+(12.4.5), Redmi note 8 (10.0), Vivo v11 pro (10)
Pre-condition:
Receiver must have the valora app open on the screen & should receive Celo from other user.
Repro Steps:

Launch the application & login with test account.
Go to celo exchanges page
Tap on Withdraw celo button
Paste Account key OR scan other user Qr code
Enter amount & send
User B should receive  & Tap “CELO deposit received...” blue banner
observe Nothing happens

Current Behavior: Nothing happens when the user tap on “CELO deposit received. You Have received 0.0111 CELO! You can earn, save and spend in Valora.Tap to learn more” when user receives CELO from another user.
Expected Behavior: “Tap to learn more” text  should not show on Blue banner of CELO deposit received  if it not tappable
Impact: Bad User experience.

Hey @MuckT We have verified this issue on android internal build V:1.23.3 and observed that issue is still reproducible
Observation : Nothing happens when we click on the "learn more" text visible in blue banner
Attachment : learnmore.mp4
Device : OnePlus 7T(11.0)


Subscription EventHandler Async/Await Support

Are there any plans to support async / await within an EventHandler? Is this what #59 is referring to?
eg:
IAsyncSubscription s = c.SubscribeAsync("foo");
s.MessageHandler += async (sender, args) =>
{
    await SomeAsyncMethod(args.Message);
};
s.Start();

@ColinSullivan1 Thanks for clarifying, I swear visual studio is playing games with me, my snippet wasn't working last I checked and now with fresh eyes it works, regardless I am glad to see that it works!
I also wanted to clarify blocking behaviour / threading of the AsyncSubscription as well, each message is processed by the handler completely before it moves onto the next.
So in order process messages in parallel I am doing something like the below, holding onto the subscription references in a local collection (obviously this is really rough, going to production will have proper locking etc).
public async Task WatchForRequests(int limit = 1)
{
	for (var i = 0; i < limit; i++)
	{
		var sub = _conn.SubscribeAsync("my-subject", "my-queue-group");
		sub.MessageHandler += async (sender, args) =>
		{
			await MessageHandler(sender, args);
		};
		sub.Start();
		_mySubsriptions.Add(sub);
	}
}

@james-andrewsmith , No worries!  Sometimes code is broken until the exact moment you ask someone else to look at it.  :)
The message handler for each queue subscriber will process each message sequentially and will block - every subscriber is serviced by a task assigned to it at creation. However, messages will be distributed randomly by the server to subscribers in the queue group and you'll lose the source order delivery guarantee.  ...with this approach you'll really distribute your work nicely, but your messages must atomic, each representing a complete unit work.  Does that make sense?
BTW, if you have a large number of subscriptions, you'll want to checkout NATS.Client.Options.SubscriberDeliveryTaskCount.

@ColinSullivan1 Thank you very much for your guidance - I will definitely ensure I tweak the task count accordingly.


Implement TA feedback for AddProcrastinationActivity

Closes #91 and #92 , i.e. now there is a character limit when adding activity name and description and there is a notification displayed when activity is added successfully (implements feedback from TAs during last sprint)

Closed while debugging.


Loading time issue - taking to much time to display server data

Describe the bug
Currently fetching data from server is taking lot of time.
Expected behavior
Fetching Data  should not take more than  2 to 3 seconds
A clear and concise description of what you expected to happen.
Logs
If applicable, add logs to help explain your problem (e.g. the error message and/or exception traceback).
Environment (please complete the following information):

OS: window
Browser: Chrome

Additional context
Add any other context about the problem here.

I think we can compress the images to decrease the loading time.


PHP 8.1 deprecation fixes

Fixed some PHP 8.1 deprecation errors. Null strings casted as empty. No BC breaks

Yes, you are right. Some change I've made by mistake in set function. I've added test and revert some changes

Sorry for the delay here @sartor , I wasn't seeing any errors when running the tests, but I've made sure all errors of this type will cause test failures in future (b5b54bc718cb480e26479b22d35aa674f289d8a9)
I've merged your fixes in a20112f29623cd66d175e3099a98824f437d21a9 and will get them released today, thanks!


otel: add new charts to DD dashboard(s)

We recently used the pubsub and async call failure mode metrics to debug an issue for the client team.
We should incorporate those into the FTL dashboard in DD.

https://app.datadoghq.com/dashboard/39r-qfe-r4w/ftl?fromUser=false&refresh_mode=sliding&view=spans&from_ts=1724068218161&to_ts=1724071818161&live=true


phaser/typescript/typings.json is not a module

This Issue is about (delete as applicable)

An error in the TypeScript defs

When using typescript@next I get phaser/typescript/typings.json is not a module. This probably happens because of this line: https://github.com/photonstorm/phaser/blob/master/package.json#L51
I never saw someone linking to the typings.json. I think this must be linked to a .d.ts.
Other errors I get: phaser/typescript/typings.json(2,11): error TS1005: ';' expected.

Same error here.

From this link, "typings" in package.json should be "./typescripts/phaser.comments.d.ts".

Sure, go for it.  Honestly, I must waste so much time looking after defs, etc. Am honestly this close to just dropping them from the repo, and letting someone else deal with it.

Oh no, please not. Keep it in the package. In my experience it is not that hard to maintain. What are your problems with it?
You typically just have a "typings" field your package.json pointing to a .d.ts. And the .d.ts is quite simple. And if there should be something which is too complicated to express in TypeScript you can just give it the type any as an escape hatch.

Trust me, there is nothing simple about having to maintain a 5700+ line Phaser defs file and a 2000 line Pixi defs, and ensure they are in sync with a constantly evolving Phaser API. And then things like TS 2 come along and cause havoc with its new strict setting, etc :(

I know... Your project is big! Definitely. But despite stricter settings in TS2 (which are really useful for finding bugs!) the big problem here isn't the complexity of the format, but staying in sync with the source files, right?
Did you tried to generate declaration files from your JSDocs comments? Looks like you use them a lot. Or did you considered switching phaser itself to TypeScript? You should try make a small private project with TypeScript 2 and a modern IDE like VS Code: code completion, refactoring, inline documentation and so on work really well nowadays. Especially such a big project like phaser itself would benefit from being written in TypeScript.

Phaser used to be written in TypeScript but was changed to JS at some point.

Me, too. Converted some TS projects to JS. We looked multiple times into TS, but I always thought it has more downsides than upsides. But many are fixed by now... The TS team did a really great job. We just switched to TS some month ago.

We have written and currently maintain a line of business system that is 210k+ lines written in typescript with a number of API's that we provide external typings for.  As of the current version there is absolutely no way I would write a large system of any kind in plain JavaScript and I don't believe there is anything I could do in JS that I cannot do in TS.
We use Typescript 2, VS Code (most of the team use the insiders build) and npm as our task runner (see https://medium.freecodecamp.com/why-i-left-gulp-and-grunt-for-npm-scripts-3d6853dd22b8 for good reasons why). It's incredibly productive and, although this may not be so important here, a massive time saver when it comes to integrating other peoples code into a project.

@wingyplus I'm still getting the same error despite adding "typings": "./typescript/phaser.comments.d.ts", to my package.json file. Is there anything I can do about it?

@Aristona This line should not be added to your package.json, but phasers.
I haven't used phaser in a while so I don't know what is the current state of this issue.

@donaldpipowitch Oh, okay. That solved the issue. Is there any way to fix it without changing Phaser's package.json? That'll be overridden when I issue a npm install.

We probably need to make a PR to phaser, but I have no idea what is the state of phaser and v3. It still has a "typescript" keyword in its package.json (see here), but it looks like the TypeScript folder was removed and the source code isn't written in TypeScript. So v3 will probably remove TypeScript support at all...? Would be sad to see this.

I don't know if I'm doing something wrong, or if phaser has an issue
One of the reasons I chose Phaser was support for typescript. Documentation can always be spotty, but being able to . your way to glory and check signatures is very useful.
I've been unable to get intellisense working for phaser. AFAIK, typescript should be able to find the definitions in node_modules if I add it to my project.json since ts2. But it doesn't. And @types doesn't work either.
http://stackoverflow.com/questions/38444279/how-should-i-use-types-with-typescript-2

The PR should be against the Phaser CE repo: https://github.com/photonstorm/phaser-ce
Phaser 3 will have TS defs, yes. They're being worked on at the moment.

Thank you for taking the time to open this issue. However, official support for Phaser 2 has now ended as we focus on preparing Phaser 3 for beta release. In a bid to keep the project tidy, and avoid confusion, we are closing all v2 related issues.
This does not mean your issue won't be looked-at. In November 2016 the Phaser CE (Community Edition) project began. The aim of Phaser CE was to allow the community to continue v2 development. Since then it has gained significant traction, with many updates and releases.
If you are still interested in having your issue investigated we strongly recommend testing the latest Phaser CE release. And only if the problem persists, opening an issue on the Phaser CE repo.


Auto-Reconnect on failure

Fixes #187
This PR adds two new configuration-options:
reconnect-delay: Time in seconds to wait between reconnect attempts.
reconnect-count:
Max number of retries of connections before giving up (and exiting). -1 means infinite reconnects. The counter is reset if a connection was established successfully.

If only I was this thorough when reviewing my own work :sweat_smile:
Thanks for all the work you've been doing lately :smiley:

Thanks so much! :1st_place_medal:

FYI I've made a couple of updates including making null mean infinite reconnects instead of -1. https://mqtt-io.app/#/config/reference/mqtt/?id=mqtt-reconnect_delay
I'll need to test it out a bit more before releasing a new version.
One thing that will need a solution is that any sensor reads (and probably input changes etc.) will queue up until the MQTT connection is reestablished. This will cause a big flood of messages which is probably undesirable, as it might cause other systems to do weird things very rapidly! It might be an idea to optionally discard publishes until the reconnection is successful.

I am using version 2.2.6 and the client does not connect automatically when the server is restarted. Is the patch not yet active in this version?

It should do in 2.2.6, yeah. Could you post your log output, annotated with when the MQTT broker goes away and comes back please?

When I start mqtt_io from the console and shut down the server, I don't get a message that the server is down, just like when I start the server. Is there a switch to get more accurate logs?

I tested again with a different RPI.
The client does not automatically reconnect if the connection is lost. However, as soon as I send a message, for example with a push of a button, the client re-establishes the connection. The client only recognizes the termination of the connection if it recognizes an error while sending. However, this is not so good as the server keeps saying that the client is not connected until the client sends a new message.


gitignore .~

ignoring files with ~

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

What's that for?

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!