python_app_version doesn't get set in partial playbook runs

For python apps, we get the python_app_version from the current checkout of the code and use it to determine the path for the deployed version. When we run playbooks without running the full sequence, e.g. using the --start-at-task option, this variable doesn't get set, and then any task that needs to know the path to the deployed version of the project fails.
The task is currently part of the build_project_repo role: https://github.com/Princeton-CDH/cdh-ansible/blob/main/roles/build_project_repo/tasks/main.yml#L43-L54
On a new deploy, it can't be run until the new version of the code has been checked out; but on an existing deploy it could be run anytime.

Interesting challenge. You could try moving the Get python package version task into a pre-tasks section in the playbook - I'm not sure how pre-tasks interact with --start-at-task. If you know the value you need, you could pass it as an extra variable, for example, -e python_app_version=x.x when you run with --start-at-task. I'm not sure what outcome you're most interested in here - running with --start-at-task? handling new deploys? something else?

@acozine thanks so much for looking and commenting.  One use case is running --start-at-task and not having to worry about this being unset.  I now have a new use case which is why I'm prioritizing fixing this: for the db upgrade I'm doing with Francis, we figured out that we could write a minimal playbook to do the necessary db setup for cdh applications and then update the settings so the application is configured to use the new db. In order to update the settings, I need to know the path for the current deploy - which relies on this python app version (and also on a a git hash from git info, which I figured out when I tried running it).  I've got a preliminary solution that pulls these two steps out into a separate task that can be included in the role and included in the new db setup/migration playbook - but that doesn't resolve the --start-at-task use case.

ah, I actually fixed this recently in dfb01a7b26b55803d499d7f2d08a6ce745dc68e5 by adding an always tag to the steps in build_project_repo that get the git short reference and the python package version


Fix bitbucket pipeline

Bitbucket Pipeline Review Creation
I have completed the Bitbucket Pipeline setup, which serves the purpose of generating reviews for pull requests. Whenever a user initiates a pull request on Bitbucket, this pipeline runs automatically and appends a review as a comment to the respective pull request.
Here's an overview of the workflow for this pipeline:
Step 1: We begin by cloning the repository from https://github.com/Codium-ai/pr-agent.git using this pipeline.
Step 2: The pipeline executes the command "cd pr-agent" to navigate into this directory.
Step 3: To build and run the file, we employ Docker Compose. As a prerequisite, we install Docker Compose with the command "pip install docker-compose."
Step 4: The review is created for the pull request by executing the command "docker-compose up --build." This command initiates the build and runs it, ultimately producing the review for the pull request.
New files introduced for this pipeline include:
docker-compose.yml: This file is employed to create the build and execute it.
Dockerfile.bitbucket_pipeline: This Dockerfile is utilized by the docker-compose file.
entrypoint.sh: You can find this file within the bitbucket_pipeline folder.
bitbucket_pipeline_runner.py: I have created this file in the servers folder, and it contains the actual script responsible for running the PRReviewer class.
Attached is a screenshot demonstrating a review created by this pipeline for reference.

Preparing review...

PR Analysis

🎯 Main theme: The PR introduces a Bitbucket pipeline that generates reviews for pull requests automatically.
📝 PR summary: This PR adds a Bitbucket pipeline to the existing project. The pipeline is designed to automatically generate reviews for pull requests on Bitbucket. It does this by cloning the repository, navigating to the directory, and using Docker Compose to build and run the file. The review is then created for the pull request.
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
⏱ Estimated time to review: 30 minutes. The PR is relatively large with several new files and changes. However, the changes are straightforward and mostly involve setting up the new pipeline.
🔒 Security concerns: No. The PR does not seem to introduce any obvious security issues. However, it's always a good idea to perform a thorough security review for any changes that involve handling sensitive data, such as tokens.

PR Feedback

💡 General suggestions: The PR is well-structured and the changes are clear. However, it would be beneficial to include error handling in the new Python script to ensure that the pipeline can recover gracefully from potential issues. Additionally, consider adding some tests to verify the functionality of the new pipeline.

 🤖 Code feedback:

relevant file: pr_agent/servers/bitbucket_pipeline_runner.py
suggestion: Consider adding error handling to the script. This could include try/except blocks around areas that might raise exceptions, such as network requests. This will make the pipeline more robust and easier to debug. [important]
relevant line: async def run_action():

relevant file: Dockerfile.bitbucket_pipeline
suggestion: It's a good practice to use an unprivileged user for running the application inside the Docker container. This can help to prevent potential security issues. [medium]
relevant line: FROM python:3.10 as base

relevant file: docker-compose.yml
suggestion: It's recommended to specify the version of Docker Compose file format. This can help to avoid potential issues with future updates of Docker Compose. [medium]
relevant line: version: '3'

relevant file: pr_agent/servers/bitbucket_pipeline_runner.py
suggestion: Consider using a logging library instead of print statements. This will provide more flexibility and make it easier to control what is logged and where the logs are sent. [medium]
relevant line: print("BITBUCKET_BEARER_TOKEN not set")

@CodiumAI-Agent /review

PR Analysis

🎯 Main theme: Implementing Bitbucket Pipeline for PR Reviews
📝 PR summary: This PR introduces a Bitbucket Pipeline setup for generating reviews for pull requests. It includes a new Python script, Dockerfile, and docker-compose file specifically for this pipeline. The pipeline clones the repository, navigates to the directory, installs Docker Compose, and runs the build to produce a review for the pull request.
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
🔒 Security concerns: No

PR Feedback

💡 General suggestions: The PR is well-structured and the code changes are clear. However, it would be beneficial to include error handling in the Python script for cases where environment variables are not set. Also, consider adding logging for debugging purposes. Lastly, it's recommended to add tests for the new functionality.

 🤖 Code feedback:

relevant file: pr_agent/servers/bitbucket_pipeline_runner.py
suggestion: Consider adding error handling for cases where the environment variables are not set. This will make the script more robust and easier to debug. [important]
relevant line: pull_request_id = os.environ.get("BITBUCKET_PR_ID", '')

relevant file: pr_agent/servers/bitbucket_pipeline_runner.py
suggestion: Consider adding logging statements to help with debugging. This can be especially helpful in a pipeline context where console output is often the only insight into what's happening. [medium]
relevant line: async def run_action():

relevant file: Dockerfile.bitbucket_pipeline
suggestion: Consider using a multi-stage build to reduce the size of the final Docker image. This can make the pipeline run faster and use less resources. [medium]
relevant line: FROM python:3.10 as base

relevant file: docker-compose.yml
suggestion: Consider using Docker Compose version 3.8 or later to take advantage of the latest features and improvements. [medium]
relevant line: version: '3'

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

Preparing review...

PR Analysis

🎯 Main theme: This PR is about setting up a Bitbucket Pipeline to generate reviews for pull requests. The pipeline runs automatically whenever a pull request is initiated on Bitbucket, and appends a review as a comment to the respective pull request.
📝 PR summary: The PR introduces a Bitbucket Pipeline setup for the project. It includes a new Python script for running the PRReviewer class, a Dockerfile for creating the build, an entrypoint.sh file for executing the Python script, and updates to the docker-compose.yml and configuration.toml files. The PR also includes updates to the INSTALL.md and README.md files to document the new Bitbucket Pipeline setup.
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
Estimated effort to review [1-5]: 4
The PR includes several new files and changes to existing files. It requires a good understanding of Bitbucket Pipelines, Docker, and the project's existing setup to review effectively.
🔒 Security concerns: No
The PR does not appear to introduce any obvious security concerns. The use of environment variables for sensitive data such as tokens is a good practice. However, it's always a good idea to perform a thorough security review for any changes that involve handling sensitive data.

PR Feedback

💡 General suggestions: The PR is well-structured and the changes are logically grouped. The use of environment variables for configuration is a good practice. However, it would be beneficial to add error handling for the case where required environment variables are not set. Also, consider adding logging for better traceability and debugging. Lastly, it would be good to add tests for the new functionality to ensure it works as expected and prevent regressions in the future.

 🤖 Code feedback:

relevant file: pr_agent/servers/bitbucket_pipeline_runner.py
suggestion: Consider adding error handling for the case where required environment variables are not set. This will make the application more robust and easier to debug. [important]
relevant line: pull_request_id = os.environ.get("BITBUCKET_PR_ID", '')

relevant file: pr_agent/servers/bitbucket_pipeline_runner.py
suggestion: Consider adding logging to the application. This will make it easier to trace the flow of the application and debug issues. [medium]
relevant line: if name == "main":

relevant file: Dockerfile.bitbucket_pipeline
suggestion: Consider using a multi-stage build to reduce the size of the final Docker image. This can improve the startup time of the container and reduce the resources it uses. [medium]
relevant line: FROM python:3.10 as base

relevant file: docker-compose.yml
suggestion: Consider using Docker Compose version 3.8 or later to take advantage of the latest features and improvements. [medium]
relevant line: version: '3'

Preparing review...

PR Analysis

🎯 Main theme: This PR introduces a Bitbucket Pipeline setup to generate reviews for pull requests. It includes the addition of several new files and modifications to existing ones to accommodate the new feature.
📝 PR summary: The PR adds a Bitbucket Pipeline that automatically runs and appends a review as a comment to the respective pull request whenever a user initiates a pull request on Bitbucket. The pipeline clones the repository, navigates into the directory, installs Docker Compose, and then builds and runs the file to produce the review for the pull request.
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
Estimated effort to review [1-5]: 4
The PR is quite large and introduces several new files and changes to existing ones. It requires a thorough review to ensure that the new pipeline works as expected and doesn't introduce any issues or vulnerabilities.
🔒 Security concerns: No
The PR does not seem to introduce any obvious security concerns. However, it's important to ensure that sensitive data like API keys are securely handled and not exposed.

PR Feedback

💡 General suggestions: The PR is well-structured and the changes are well-documented. However, it would be beneficial to add error handling and logging to the new Python script to make debugging easier in case of issues. Also, consider adding tests to ensure the pipeline works as expected.

 🤖 Code feedback:

relevant file: pr_agent/servers/bitbucket_pipeline_runner.py
suggestion: Consider adding error handling around the environment variable retrieval to handle cases where the variables are not set. This will make the script more robust and easier to debug. [important]
relevant line: pull_request_id = os.environ.get("BITBUCKET_PR_ID", '')

relevant file: Dockerfile.bitbucket_pipeline
suggestion: It's a good practice to specify the versions of the packages you're installing. This can help avoid potential issues caused by package updates that introduce breaking changes. [medium]
relevant line: RUN pip install . && rm pyproject.toml requirements.txt

relevant file: docker-compose.yml
suggestion: It's a good practice to use environment variables for sensitive data. Make sure that sensitive data like API keys are not hard-coded or checked into version control. [important]
relevant line: - OPENAI_API_KEY=${OPENAI_API_KEY}

relevant file: pr_agent/servers/bitbucket_pipeline_runner.py
suggestion: It would be beneficial to add logging to the script. This can help with debugging and provide visibility into the script's execution. [medium]
relevant line: if name == "main":

Preparing review...

PR Analysis

🎯 Main theme: Implementing Bitbucket Pipeline for PR Reviews
📝 PR summary: This PR introduces a Bitbucket Pipeline setup to generate reviews for pull requests. The pipeline clones the repository, navigates to the directory, installs Docker Compose, and builds and runs the file. The review is then created for the pull request. The PR also includes the addition of new files and environment variables for the pipeline.
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
Estimated effort to review [1-5]: 3
This PR introduces a new feature and modifies several files. It requires a moderate level of effort to review, as the reviewer needs to understand the new pipeline setup and the implications of the changes.
🔒 Security concerns: No
The PR does not seem to introduce any obvious security concerns. The use of environment variables for sensitive data like tokens is a good practice. However, it's always important to ensure these environment variables are securely managed.

PR Feedback

💡 General suggestions: The PR is well-structured and the changes are clearly explained in the description. However, it would be beneficial to add error handling in the new Python script to handle potential issues during the pipeline execution. Also, consider adding a cleanup step in the pipeline to remove any temporary files or resources created during the execution.

 🤖 Code feedback:

relevant file: pr_agent/servers/bitbucket_pipeline_runner.py
suggestion: Consider adding error handling for potential issues during the pipeline execution. For instance, if the PR URL cannot be constructed correctly or if the PRReviewer cannot run successfully, it would be helpful to catch these exceptions and log meaningful error messages. [important]
relevant line: await PRReviewer(pr_url).run()

relevant file: Dockerfile.bitbucket_pipeline
suggestion: It's a good practice to minimize the number of layers in your Dockerfile to reduce the image size. You can achieve this by combining the ADD and RUN commands into a single RUN command that includes the removal of temporary files. [medium]
relevant line: ADD pyproject.toml .

relevant file: docker-compose.yml
suggestion: It's recommended to use versioned tags for Docker images to ensure the pipeline uses a consistent environment. Using the 'latest' tag can lead to unexpected changes when the image is updated. [medium]
relevant line: image: python:3.8 # Use an appropriate Python image with pip

relevant file: pr_agent/servers/bitbucket_pipeline_runner.py
suggestion: It's a good practice to avoid using print statements for logging in production code. Consider using a logging library which can provide more flexibility (like log levels) and output logs to various destinations. [medium]
relevant line: print("BITBUCKET_BEARER_TOKEN not set")

Preparing review...


Remove IHostingEnvironment dependency

https://github.com/aspnet/Security/issues/1201#issuecomment-299541453
This functionality is moving into Hosting. Expect a Hosting PR shortly.

Woot, nice. This even comes with a bonus: OWIN/Katana apps using Microsoft.Owin.Security.Interop will no longer bring the ASP.NET Core HTTP/Hosting abstractions that were not really needed :+1:

Yup, that was always a weird dependency.


Fixed Issue [#7133]

Issue Reference
#7133

@papnoisanjeev
This is working fine, please find the screenshot Here


Outline relisting flow

Product / Design to outline ideal relisting flow

Met with @eajensenwa - added relisting flow, outlined here


Formatting Infinity With Decimals Throws a Type Error

A piece of code I was writing had a bug and was returning infinities and I discovered that numeral fails when trying to format infinity to have decimals, specifically:
numeral(Infinity).format("00.0"); //throws TypeError: Cannot read property 'length' of undefined
The minimal failing case is the following:
numeral(Infinity).format(".0");

Hi, this repository is no longer maintained. You can get an improved version here: https://github.com/foretagsplatsen/numbro. That one is still maintained and you can report your issues there.

Fixed


fix issue 198

sheet.cssRules in firefox call exception, but css in this time is not loaded.

This fix masks css load errors, please pull latest verstion of lmd and try to run npm test with your changes. test will freeze on - require.css() cross origin


Pixels in progress arrow are off

Issue description
There's one spot on the progress arrow where there's a 2 pixel step, where the rest are 1 pixel, and it looks off.

Steps to reproduce
No response
Minecraft version
1.21 (Latest)
Fabric loader version
0.16.00
Fabric API version
0.100.8+1.21
Oritech version
0.8.0
Other relevant versions
No response
If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)
No response

Thanks for reporting this, I didnt even notice this when making the texture. I've fixed it now, and the change will be included in the next release (probably 0.8.1)


Support /vendor/ directory

Determine the ramification of the go tool adding experimental support for the /vendor/ directory.

Support must involve searching for dependencies.
Support will probably allow vendoring by copying into the /vendor/ directory.
We need to move the vendor.json file into the project root to support either location. Rewrites cannot go into the /vendor/ folder.

Rewrites cannot go into the /vendor/ folder.

But import path rewriting will not be necessary anymore with the improvements proposed by Russ Cox a few hours ago on golang-dev?

@ngrilly Import path rewriting might go away eventually. However it won't be until 1.6 it could be the default and not until 1.7 until the option becomes mandatory. That's a while yet, and until then I will continue to treat it as an experiment (one I fully support).
For clarity, the following changes need to be made:

Move the "vendor.json" file to the root of the project directory.
Update "vendor init" to "vendor init {rewrite | copy}". Record in the vendor.json file.
Even for rewrites, dependent packages can now be found in the /vendor/ folder. Look in it if found.
Support vendoring by copying into /vendor/.

Most of this work has been done in the "importmap" branch. More work remains.
Before merging I want a good path forward (migration) and better output for listing current status.

This is now merged.


Rosetta packaging for Mainnet -- requested by many community members (bkase)

Probably this refers to this (https://www.rosetta-api.org/) and not this (https://en.wikipedia.org/wiki/Rosetta_(software)) even though the latter would make sense for this issue. :-)


Thanks!

Thanks for this amazing project! It’s now powering the Ollama integration in Kernel Memory. 🎉
Great work, and much appreciated!
https://github.com/microsoft/kernel-memory/pull/770

Wow, that's actually pretty amazing!
I love projects supporting local AI models, really happy to see this featured in Semantic Kernel (Memory).


mdDialog, arrow keys navigate through buttons

Bug, feature request, or proposal:
Feature request
What is the expected behavior?
Regarding mdDialog, when it's open, if it has 2 or more buttons (example: Yes, No, Maybe), I should be able to navigate with arrow keys on this buttons.
What is the current behavior?
Navigation possible only with TAB.
What are the steps to reproduce?
Navigate to https://material.angular.io/components/component/dialog
Try using arrow keys.
What is the use-case or motivation for changing an existing behavior?
Using arrow keys is the expected behaviour.
See another plugin using arrowkwys: http://alertifyjs.com/

For accessibility, the standard is actually only TAB: https://www.w3.org/TR/wai-aria-practices/#dialog_modal.

I think if you want arrow-key-navigable buttons like that, you should use radio buttons–especially if the answers are mutually exclusive. That form control will give you the user interaction pattern you're looking for.

This is not something we plan on implementing.


Vat logo added and 404 page markup set to match VAT messaging

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--edge-delivery-vat-demo--Netcentric.hlx.live/
After: https://--edge-delivery-vat-demo--Netcentric.hlx.live/

Just to kick it off and establish the process...

URL for testing:

https://vat-logo-and-404-page--edge-delivery-vat-demo--netcentric.hlx.page/


Code analysis messages in margin

From<EMAIL_ADDRESS>on 2013-01-07T09:32:00Z
Spyder Version:  2.1.10
Python Version:  2.7.3
Qt Version:      4.8.2, PyQt4 (API v1) 4.9.3 on Linux What is the expected output? What do you see instead? Code analysis messages in margin should specify what tool (pylint, pep8, pyflakes) generated said message, as well as the error code if applicable.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1219

From ccordoba12 on 2015-01-02T18:41:04Z
That would juts confuse user who doesn't know what pep8 or pyflakes is.
Status: WontFix


Add .swift-sample file

This PR adds a .swift-sample file to the repo. This metadata is crawled by the Package Catalog and used to generate links through to the Swift Sandbox showing how to use a particular package. We've created a sample package for BlueCryptor, which is what this metadata refers to.

@billabt :)


Upgrade to 0.90.2 and Yeelight diseappeared

Home Assistant release with the issue:
0.90.2
Last working Home Assistant release (if known):
0.78
Operating environment (Hass.io/Docker/Windows/etc.):
Windows
Component/platform:
Yeelight
Description of problem:
After I updated Home Assistant, all Yeelights disappeared. I checked in the Yeelight app that LAN control is on.
In the configuration.yaml I have the following (without errors):
light:

platform: yeelight
devices:
<IP_ADDRESS>:
name: Luce dietro il vaso
use_music_mode: true
<IP_ADDRESS>:
name: Luce dietro il mobile tv
use_music_mode: true
<IP_ADDRESS>:
name: Luce sotto la scrivania
use_music_mode: true
<IP_ADDRESS>:
name: Luce dietro il letto
use_music_mode: true
<IP_ADDRESS>:
name: Comodino Vale
<IP_ADDRESS>:
name: Comodino Gianluca

UPDATE: I solved with "py -m pip install --upgrade yeelight"

You should close the issue if you really got it fixed.


broadcast in weave doesn't work?

in document I only see "multicast is supported", but how about broadcast? e.g. if I send broadcast to <IP_ADDRESS> in one container, will other containers on other hosts receive the data?

yes

@rade could u kindly guide me the doc or example? I didn't find useful thing on document and the broadcast doesn't work in my environment...

If you post a reproducible step-by-step example of what you've tried to get to work then we can probably identify what went wrong.

 However it could succeed on outer hosts.
root@c3:/# socat -u udp-recv:12345,reuseaddr -

root@c2# socat - udp-sendto:<IP_ADDRESS>:12345,broadcast

The broadcast address you used is on Docker's container network - eth0 - rather than weave's - ethwe. Try the latter and it should work.

Yes that would work. While I was expecting weave to be more powerful to hack route/iptables stuff a bit thus use could transparently use 172.17.x.x directly.


Feature/np cumsum

Simple implementation of cumulative sum. Either call as a member function from an NDArray or as a static function via np.cumsum().

@Oceania2018 I tried using Linq instead but didn't get it to work. Any advice are welcome
Assert.IsTrue(Enumerable.SequenceEqual(arr, expected));
resulted in
The type arguments for method 'Enumerable.SequenceEqual<TSource>(IEnumerable<TSource>, IEnumerable<TSource>)' cannot be inferred from the usage. Try specifying the type arguments explicitly
Assert.IsTrue(Enumerable.SequenceEqual<double>(arr, expected));
resulted in
cannot convert from 'NumSharp.NDArray' to 'System.Collections.Generic.IEnumerable<double>

Assert.IsTrue(Enumerable.SequenceEqual(arr.GetData<double>(), expected.GetData<double>()))

Tests from the examples in the numpy documentation have been added.
Added documentation to functions.

4/6 tests are failing currently. The failing tests are related to summing over specific axes, as well as specifying data types.

Thank you for the PR!


Limited the dark mode toggler ability to the toggler button itself

Fixes: #360
Proposed Changes

Limited the ability of theme toggling to the toggle button itself

Additional Info

Added the limitation because there were unexpected overflows that were breaking the cursor look.

Clips of changes
Before
https://user-images.githubusercontent.com/49204837/103173415-dc104680-4880-11eb-8339-f9046aefab2a.mp4
After
https://user-images.githubusercontent.com/49204837/103173424-e6cadb80-4880-11eb-8b15-7e1c237bb5a3.mp4

@smaranjitghose please have a look.

NWOC, DWOC or SWOC?

SWOC


Laganellac/2021_11_1_EnhanceBlueprintExport

Type of change

[ ] Bug fix
[x] New feature
[ ] Documentation update
[ ] Other

How Has This Been Tested?
This has been tested on Ubuntu 18.04 using the GUI & CLI to exercise the new options added to the blueprint export. A new blueprint_export.py has been added to the repo with baselines (generated on my workstation) checked in under test/baseline/databases/blueprint_export. Generally, the multi domain silo datasets have been used to test the blueprint flatten / partition functionality; both partitioning them into a greater number of domains or combining them down to a smaller number of domains.
Checklist:

[x] I have followed the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code where applicable.
[x] I have updated the release notes.
[ ]  I have made corresponding changes to the documentation.
[x] I have added debugging support to my changes.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have confirmed new and existing unit tests pass locally with my changes.
[x] I have added new baselines for any new tests to the repo.
[ ] I have NOT made any changes to protocol or public interfaces in an RC branch.
[ ] I have assigned reviewers (see VisIt's PR procedures for more information).

What does this pull request include?
This pull request includes enhancements to the blueprint export plugin which allow users to apply blueprint's "flatten" and "partition" operations to the exported dataset. This pull request includes:

Updates to blueprint plugin XML to support write options
The addition of an "operation" option (enum) to the blueprint export which supports the values "Partition", "Flatten_CSV", and "Flatten_HDF5"
The addition of a "Partition target number of domains" option which tells blueprint::mesh::partition how many domains to create
Enhancements to avtBlueprintWriter.C to handle these options. When using partition or flatten, the operations are deferred until CloseFile so that the parallel implementations of flatten / partition can be used safely.
Fixed a bug in "HomogeneousShapeTopologyToVTKCellArray" which was causing it to needlessly copy the connectivity array repeatedly
Added avtBlueprintDataAdapter::VTKFieldNameToBlueprint which filters out '/'s from field names before adding them to blueprint. I noticed that invalid blueprint "fields" entries were being created due to field names like "topology/field0" being passed to conduit.
Added blueprint_export.py which tests partitioning the multi domain silo datasets against image baselines, and flattening the multi domain silo datasets against text (CSV) baselines.
blueprint_export.py is currently on the skip list because the visit-thirdparty Conduit version will need to be updated to support these features
Enhancements to the CMake logic which check for partition/flatten support (checks if conduit version is >= 0.8.0). Conditional compilation added to blueprint plugin which disables the new features if conduit version is too old
Update bv_conduit for version v0.8.0, also have it write the conduit version to the host-config.cmake file so that the above check can be made

Please let me know if you have any questions / need me to make any changes.

Tagging @cyrush and @BradWhitlock as this goes along with some work we've been doing in the Conduit repo.

Hey @cyrush, I've recently done some work that builds off the work done in this branch. Specifically, I've added the ability for the user to provide a "MultiLineString" through the DBOptions attributes which is then parsed into a Conduit node in the BlueprintWriter. This node is then passed as the options input to either Flatten or Partition.
The work exists here: https://github.com/Laganellac/visit/tree/laganellac/2022_02_08_AddMultiLineEdit
I was wondering how you would like to organize this. I notice that this PR has already been approved but is not yet merged. I could wait until this gets merged into develop and then create a new PR with the new work OR I could merge my new branch into this existing PR (which would need to be reviewed again, I assume).
Let me know what you think.

@Laganellac  This looks good, thanks! I plan to merge this today, then you can do a PR to develop for the extended work.

@Laganellac merged, so you can move forward with the other PR into develop.


[FEATURE REQ] Bug bash for existing features in SCA 6.0

Context
Prepare the Spring Cloud Azure 6.0 GA, we need to verify the existing features working in Spring Boot 3.0.0 and Spring Cloud 2022.0.0.
Goal
Go through the below items:

MS reference doc for 6.0.0 and sync diffs to Github pages.
Other getting started doc.

@moarychan please change #31895  for Spring Cloud Azure 6.0 Release, and use it for all the related task, no  need to create feature request for each task


Cannot enable or disable users in realm

I get an error when I want to enable or disable a user. Using wick from the documentation
/wick --url ws://localhost:18080/ws \
--realm com.leapsight.bondy \
call bondy.realm.security.disable "com.leapsight.test_creation_1"

I get
FATA[0000] got errors:
- calling remote procedure 'bondy.user.disable': bondy.error.function_clause: : code=function_clause, description=, message=

Using curl
curl -X "POST" "http://localhost:18081/services/call"
  -H 'Content-Type: application/json; charset=utf-8'
  -H 'Accept: application/json; charset=utf-8'
  -d $'{
    "procedure": "bondy.user.enable",
    "options": {},
    "args": [
      "com.leapsight.test",
      "peer1"
    ],
    "kwargs": {}
  }'

I get
{"args":[""],"details":{},"error_uri":"bondy.error.function_clause","kwargs":{"code":"function_clause","description":"","message":""}}

Digging / tracing through the code and trying to debug, the error comes from:
https://github.com/bondy-io/bondy/blob/e72460e094cd0d897e74a5c2864c6eaa3cd7a213/apps/bondy/src/bondy_rbac_user.erl#L860-L864
The problem is that the User send is a Binary and it seems that the function is expecting something different. Removing the type check will fix the problem and I can enable and disable an user. But I don't think that's the right thing to do right? I suppose it should be fixed in https://github.com/bondy-io/bondy/blob/e72460e094cd0d897e74a5c2864c6eaa3cd7a213/apps/bondy/src/bondy_rbac_user_wamp_api.erl#L96
All the above happens for both enable and disable an user.

Thanks @Jopie01 I’ll take a look tomorrow and get back to you.

@Jopie01 Just made a commit to develop fixing this issue and improving some other validations.
If you do:
wick --url ws://localhost:18080/ws --realm com.leapsight.test \
call bondy.user.enable "app1"

No return
Then:
wick --url ws://localhost:18080/ws --realm com.leapsight.test \
call bondy.user.is_enabled "app1"

should return
[
   false
]

@aramallo Thanks! Did a pull and now it works perfectly!
Also using curl is working with
curl -X "POST" "http://localhost:18081/services/call"
  -H 'Content-Type: application/json; charset=utf-8'
  -H 'Accept: application/json; charset=utf-8'
  -d $'{
    "procedure": "bondy.user.enable",
    "options": {},
    "args": [
      "com.leapsight.test",
      "peer1"
    ],
    "kwargs": {}
  }'

And replacing bondy.user.enable with bondy.user.disable is also working.


Remove repititive columns

Signed-off-by: Akash Srivastava<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 1230

0 of 5 (0.0%)  changed or added relevant lines in 4 files are covered.
4284 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.006%) to 26.855%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

probe/kubernetes/cstor_storage_pool.go
0
1
0.0%

probe/kubernetes/cstor_volume.go
0
1
0.0%

probe/kubernetes/cstor_volume_replica.go
0
1
0.0%

probe/kubernetes/disk.go
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

render/detailed/detailed.codecgen.go
1693
29.56%

report/report.codecgen.go
2591
35.7%

Totals

Change from base Build 1222:
0.006%

Covered Lines:
14579

Relevant Lines:
54288

💛  - Coveralls


Formal definition of the API between the Deployment Engine and the Extensibility Provider

Can we please have a formal definition of the API between the Deployment Engine and the Extensibility Provider that includes the description of the expected json payloads and responses?
Also, the story for versioning that API needs to be addressed. Specifically, what is the cadence, support and deprecation model for the versions of the API
Ideally, I would prefer an API spec that is language agnostic and from which a client/server implementation can be generated automatically. In addition, if possible, it would be beneficial to release a sample (or reference)
Also, it would be beneficial to provide a cli that can test a provided Extensibility Provider endpoint to validate it meets the requirements in terms of expected responses etc...
Originally posted by @asilverman in https://github.com/Azure/bicep/issues/3565#issuecomment-1106829888

/cc @alex-frankel @anthony-c-martin @shenglol - I think we can consider this done.


Document support tiers in Nixpkgs manual

After RFC046 got merged, no documentation was added to the nixpkgs manual regarding support tiers.
This is the last state of the conversation.
cc @7c6f434c

Related: https://github.com/NixOS/nixpkgs/pull/143732 (discussed in the docs team meeting today)

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/2023-07-24-documentation-team-meeting-notes-66/30885/1

Closed by #254741


Software: PDF Reader category

Add a PDF Reader category.
Initial options:

Adobe Acrobat Reader DC
Sumatra PDF

Completed in commit 64c5ce8


Prevent auto-insertion of summary docstrings

Environment data
VS Code version: 1.87.2
C# Extension version: 2.22.3
Steps to reproduce

Type "///"

Expected  behavior
Nothing should happen.
Actual behavior
This text is auto-inserted:
/// <summary>
///
/// </summary>

Furthermore, pressing return after any line that starts with a "///" auto-inserts another "///" on the next line.
Additional context
Is there an existing way to disable this behavior?

@akhera99 do you know if we have an option for this in VS?  If we do we may want to add it to VSCode as well


Transpose Parameter for Out-HtmlView?

When sending data (aka a PS Object) to Out-HtmlView I want to transpose rows into columns. Is this possible with the current module's version?
E. g.: Form Exchange Shell I saved the result from 'Get-SendConnector' to XML. Now I import that file into $Q: '$q1=Import-Clixml -LiteralPath .\SendConnector.xml'
The result looks like this
.
The attributes of the two connectors are in rows below each other and the table has many columns next to each other. But I would have liked to swap: the connectors (in the example here there are two) next to each other in columns and the attributes below each other.
As a workaround, I open the table as an Excel file, copy the rows and paste them in a new sheet using the transpose function. This then looks like this:

I need this quite often. It would be nice if this function was available directly in the module.

Out-HtmlView -Transpose is it not working?

Oh - my bad. I overlooked this parameter. Sorry! But when I use Out-HtmlView with -Transpose I can only see the first connector and the second one is not shown.

When I use -FlattenObject too the result is quite weird or mixed.

I guess my implementation of it is incorrect or was approached for showing a single object transposed. To transpose correctly more than 1 object you would need to provide a way to define column names (object names). You have picked X and Y yourself.

Maybe this helps. I just noticed that the second object is included in the output after all. But not in another column as expected. The second object is below the first one and all row labels are repeated. Here is an example for Get-ExchangeCertificate:

I guess my implementation of it is incorrect or was approached for showing a single object transposed. To transpose correctly more than 1 object you would need to provide a way to define column names (object names). You have picked X and Y yourself.

Not quite. X and Y are the anonymized names of the connectors. I copied this information manually to the top to improve readability for me. In the original output the first line contains the name of the first attribute of the object. DNSRoutingEnabled' in the case.

Right, in your case it's DNSRoutingEnabled, but for others, it may be a value from DisplayName, and for others value from FriendlyName. It's just something user dependant which means there needs to be a choice and the value needs to be unique. It can't assume things.

New versions resolve this issue:
1.21.0 - 2024.06.29

Changed behavior of Transpose in New-HTMLTable / Out-HtmlView
Added TransposeLegacy to New-HTMLTable / Out-HtmlView to keep old behavior
Added TransposeName to New-HTMLTable / Out-HtmlView to allow for custom name (default is Object 0, Object 1, Object 2)
Added TransposeProperty to New-HTMLTable / Out-HtmlView to allow for transposing on unique value from specific property (ex. ServerName)
Added Out-HtmlView additional options PrettifyObject, PrettifyObjectSeparator, PrettifyObjectDateTimeFormat

Those changes resolve: #316
$Object = @(
    [PSCustomObject] @{
        Test  = 5
        Ello  = 'Motto'
        Hello = 'Totto'
    }
    [PSCustomObject] @{
        Test  = 5
        Ello  = 'Motto'
        Hello = 'Totto'
    }
    [PSCustomObject] @{
        Test  = 5
        Ello  = 'Motto'
        Hello = 'Totto'
    }
    [PSCustomObject] @{
        Test  = 5
        Ello  = 'Motto'
        Hello = 'Totto'
    }
    [PSCustomObject] @{
        Test  = 5
        Ello  = 'Motto'
        Hello = 'Totto'
    }
    [PSCustomObject] @{
        Test  = 3
        Ello  = 'Lotto'
        Hello = 'Totto'
    }
)

$Object | Out-HtmlView -Transpose -TransposeName 'Test ' -Filtering

New-HTML -TitleText $Title -Online -FilePath $PSScriptRoot\Example-TableTranspose01.html {
    New-HTMLTable -DataTable $Object -Filtering -Transpose
} -ShowHTML


Maplibre example

Hi again! I'm testing perf differences between Maplibre and Leaflet and was curious when you might have time to make a Maplibre example for https://protomaps.com/docs/alternate-renderers
Thanks!
Julius

The easiest way to access this right now is creating a bundle on https://protomaps.com/bundles and looking at gl.html in the downloaded ZIP.
This isn't using MapLibre yet until PR 30 at https://github.com/maplibre/maplibre-gl-js/pulls is merged.
I do need to add some other examples around using MapLibre/JSON styles, so let's continue in this new issue I made on another repo: https://github.com/protomaps/protomaps-themes/issues/8

oh interesting! i thought it already supported custom tiles

but now reading this code i grabbed from online somewhere, it looks like its just for raster. so the missing functionality is support for custom vector tiles (not raster)?
thanks as always for the fast response

The missing functionality is custom Protocol support in MapLibre. The way Mapbox 1.13 and MapLibre 1.14 work is that they must consume a Z/X/Y tile URL (an HTTP web service) for vector or raster tiles
All my examples/tools for protomaps.js work with either a Z/X/Y tile URL like above, or a local PMTiles file hosted on your own computer or an S3-like service. To make that second option, PMTiles work in MapLibre, I currently use my own fork of version 1.13 in the gl.html, but it's hacky. If you want to use Z/X/Y tile urls e.g. api.protomaps.com/tiles/v2/{z}/{x}/{y}.pbf it should work just fine with any version of MapBox GL <=1.13 or MapLibre; I don't have good examples yet but basically you need to work off of this json style: https://github.com/protomaps/protomaps-themes/blob/master/mbgl/base.json

oh gotcha, that works great! thanks~

@tarngerine see https://github.com/protomaps/protomaps-themes/issues/8#issuecomment-859597903 for more info on GL styles


Feat/android jcenter

This fixes the long awaited #9 and #64.
To upload a new release, it's important to have a local.properties file which includes your bintray username and api key. They're for obvious reasons excluded from git.
Before doing so, you'd also need to be in that specific repository.
We'll setup those things this friday.
The code is ready to be merged.

Use this line in any app implementation ('io.o2mc.sdk:sdk:0.0.7').
Execute make deploy to deploy a new version to bintray (& jcenter). Update version number before execution.

Put
bintray.user=<USER>
bintray.apikey=<APIKEY>

in the project root's local.properties file.


Ability to capture modifier keys (e.g. alt)

I'm messing with MenuBar et.al. and am curious about something: Why does MapKey (and the rest of the call chain) filter out letting ProcessKey see just modifier key events?
For example, if we wanted MenuBar to highlight when a user presses alt like it does on Windows, we'd want it to be able to 'see' that the user has just pressed alt.
Would the world end if MapKey was modified to pass through shift-modifier keys?

There really is a gap in that regard. Like using ControlV or ControlF that doesn't even work. I haven’t looked at it much yet. I just solved the Alt key and € key that was not working. My preference would really be to make the combination of the shift, ctrl and alt keys available separately from the other keys. Regarding the mouse, I introduced practically all the basic functionalities needed. Regarding the keys, I don't know if there are any limitations in their handling, some combinations can be managed by the OS itself and it may not be possible to change its behavior. It would be great to be able to improve the level of the keys control. Take a look at TextField where I implemented 3 key combinations to copy (Ctrl+Alt+C), cut (Ctrl+Alt+X) and paste (Ctrl+Alt+V).

I just did a test where I modified MapKey in WindowsDriver.cs to pass just alt keypresses on.
It demonstrated pretty clearly that a new API will be required because existing ProcessKey implementations get confused.
I would suggest
public virtual bool KeyDown(KeyEvent keyEvent)

and
public virtual bool KeyUp (KeyEvent keyEvent)

Ala Windows' WM_KEYDOWN/WM_KEYUP.
Thoughts?

And if neither the
public virtual bool KeyDown (KeyEvent keyEvent)
nor the
public virtual bool KeyUp (KeyEvent keyEvent)
were even captured, the
public virtual bool KeyPressed (KeyEvent keyEvent)
could be implemented as in the mouse event Pressed, Release and Clicked

Yep. I just did a PoC to prove this works:
In this gif I do:

Alt down/up
Down
Down
Alt down/up

Proving that I could plum KeyDown all the way up to MenuBar.

Ignore the "About..." menu in this demo. That's my test case for enabling top-level menu items that don't have sub-items, but can just do an action.
KeyDown/KeyUp will be groovy, but for what I really want, I'm afraid it will require more complexity: I need the equivalent of GrabMouse for the keyboard...
What do you think about using a bool to indicate up/down vs. having two methods? e.g.:
/// <summary>
/// Method invoked when a key is pressed or depresed.
/// </summary>
/// <param name="keyEvent">Contains the details about the key that produced the event.</param>
/// <param name="up">True if this is a key-up event. False if it is a key-down event.</param>
/// <returns></returns>
public virtual bool KeyPress (KeyEvent keyEvent, bool up)
{
	return false;
}

Good job. The parameter up in KeyPress is not necessary because this event is only captured if we ignore both the key down and the key up, that is, it is only triggered after the key up, of course.
In KeyEvent it is necessary to include both the key that produces the event as well as the key modifiers, such as Alt, Ctrl, Shift as well as special keys.

Some additional notes...
In reality, ProcessKey is mis-named. What it really does is is process keystokes, and in all implementations (Windows, Net, and Curses) gets called on key-up. Actually for Net and Curses it gets called when a keystroke happens because there is no concept of keydown/up events in those drivers. IOW, the only implementation where the whole keydown/keyup functionality will work is Windows.
This mutes my enthusiasm some, because I suspect it's a tenet of gui.cs to have apps work the same cross platform?

Perhaps you are right. I think many of the complexities used should only work on windows :-)

Right, they should work cross platform, and I think that the way of handling this would be to introduce a new method "ProcessKeyDown" which might only be triggered on Windows.   And we could flag this appropriately.  Perhaps provide this not as a ProcessKeyDown, but a "WindowsKeyDown".
Anyways, what we could do in addition to this new method, is essentially allow the per-platform capabilities to be enhanced.  So for example, the "Alt" processing key might be limited to Windows, and I think that it is ok that this is the case.    On each platform, we can take advantage of the best that we can get.

Also my opinion is to try to adapt to all platforms and the keys that do not exist in some or in others to replace with another combination that has the same behavior.

Done. Closing.


New Line with Backtick After Performing Pull

One issue I notice is that when I run the wti pull command, a "" is added to a new line directly after the opening ` tag. Any ideas?
<?xml version="1.0" encoding="UTF-8"?>
<resources>
    `

Hi @adavis . This is an issue on the WebTranslateIt.com service or on your language file itself, not an issue on the synchronization tool. Could you send me an e-mail at<EMAIL_ADDRESS>with the ID of your project and the name of the file having this issue so I can investigate?
Thanks,
Edouard

ok, will do thanks

I just found your project name from the previous ticket. There was indeed a backtick saved in the headers of one of your files. It was probably there because a file was uploaded with a backtick. Anyway, I just removed it so your language files should be all good now.
Don’t hesitate to let me know if you need further assistance.
Best regards,
Edouard


Standalone Pact verifier doing extra unnecessary tests when verifying by URL and publishing

I've struggled a bit to narrow down the cause of this completely, because it involves interacting with real services and publishing to our actual broker, but I think my interpretation is correct.
Problem
I have a provider with three consumers. I'm setting up a CI job that verifies a consumer's Pact, by its URL, against its provider (triggered from the contract_requiring_verification_published webhook). I want to publish these results back to the broker. Therefore I've ended up with a command like:
pact_verifier_cli --url={pact url} --publish

Understandably, the verifier needs to know where the broker is so that it can publish the results. So I add that argument (I've omitted auth here):
pact_verifier_cli --url={pact url} --publish --broker-url={broker url}

However, the verifier now verifies four pacts: the one provided with --url and the latest from each of the three consumers. As far as I know it only publishes verification for the --url one.
Verifying the extra pacts is a waste of time in CI, but it's also a potential blocker. Instead of pulling the latest pacts from the main branches of the consumers, it's getting them from the broker path /pacts/provider/{provider}/latest. This returns (and therefore it tries to verify) the absolute most recent of each consumer, even if they're from branches with invalid contracts. Thus the verifier may fail even though the one pact it was asked to check is fine.
Cause
I think the underlying issue here is that the --broker-url argument is being used for two things:

Specifying where results publication should go (as a dependency of --publish)
Identifying pacts to verify (as specified in the docs)

And so you end up verifying extra pacts just because you want to publish.
Specifically, this block of code seems to be where it's using the presence of the broker URL argument to go and fetch additional pacts.
Mitigation
I'm looking at a couple of fixes I can try to unblock us:

Set --consumer-version-selectors to {"branch": "main"} so that it's at least running against pacts that we know work

But this is still verifying additional pacts, which wastes CI time (and the money it costs to do so) on every verification

Stop using --url, and instead craft --consumer-version-selectors that would match the same contract

This looks promising but would require me to rewrite a bunch of integration points, webhooks etc. to pass the consumer name/branch rather than the URL

I also tried using nonsense --consumer-version-selectors ({"branch":"-invalid"}) so that it wouldn't return anything but, quite reasonably, that failed because it didn't return anything 😄
Potential fixes for pact_verifier_cli
(Assuming I've understood all of the above correctly!)
You could only fetch pacts from the broker if --consumer-version-selectors or --consumer-version-tags is provided (therefore removing this else clause), but that would be a breaking change. And presumably the else clause is there for good reason.
You could add a --publish-broker-url argument that is used for publication but doesn't trigger fetching additional pacts, but that feels verbose and easy to confuse.
You could add a --no-broker-fetch argument that explicitly opts out this behaviour when --broker-url is provided, which wouldn't be breaking but again feels verbose and a little unintuitive.

I've added a --webhook-callback-url option which will do what you need. You should be able to run it with
pact_verifier_cli --webhook-callback-url={pact url} --publish --broker-url={broker url} --provider-name {provider name}

@rholshausen Sorry for the slow response, but that seems to be working great, thank you very much!


DOC: Clearer attribute style

Switches numpydoc to use numpydoc_attributes_as_param_list = True like in sklearn (requested by @agramfort)
Sets capture_repr to make it so the recent SG PR does not change our behavior
Tweaks our param list style to look more like sklearn

@drammock point (3) is about aesthetic judgment so I'll let you take over and keep / discard / modify as you see fit.

https://16312-1301584-gh.circle-artifacts.com/0/dev/generated/mne.preprocessing.ICA.html

@agramfort feel free to click the green button if you're happy

Beautiful
Can you also backport this ? Thx


Social Recovery Module

Summary
Account Recovery Module for Biconomy Modular Smart Account.
Based on this.
Features

It allows the submission and execution of recovery requests
EOA guardians only
For security reasons, the guardian's address is not stored, instead, its signature over CONTROL_HASH is used
Security delay is always applied to new guardians and recovery requests

How it works
The algorithm relies on the 4337 concept of having the validation and execution phase.
The checks happen in the validateUserOp method.

Related Issue
Change Type: New Feature
Checklist

[x] My code follows this project's style guidelines
[x] I've reviewed my own code
[x] I've added comments for any hard-to-understand areas
[x] I've updated the documentation if necessary
[x] My changes generate no new warnings
[x] I've added tests that prove my fix is effective or my feature works
[x] All unit tests pass locally with my changes
[x] Any dependent changes have been merged and published

How do we check if userOp.calldata matches previously submitted recovery request?
How are guardian signatures supplied?

The above diagram tries to explain what happens during validation but also has mentions of execution. Can we have separate flow diagram on what happens during the execution?
Do we have a technical draft on how social recovery module works? like we have done for other modules

Just to confirm, should this be merged into main or develop?

How do we check if userOp.calldata matches previously submitted recovery request?

if (
            keccak256(userOp.callData) ==
            _smartAccountRequests[msg.sender].callDataHash
        )

How are guardian signatures supplied?

they are in the userOp.signature field

The above diagram tries to explain what happens during validation but also has mentions of execution. Can we have separate flow diagram on what happens during the execution?

Updated the diagram

Do we have a technical draft on how social recovery module works? like we have done for other modules

Not yet. Will start making it this week

The above diagram tries to explain what happens during validation but also has mentions of execution. Can we have separate flow diagram on what happens during the execution?

Updated the diagram

Do we have a technical draft on how social recovery module works? like we have done for other modules

Not yet. Will start making it this week

cool
for devs to understand what would help is ways to interact with this module. which would translate to different types of transaction journeys, for each can we add small flow like EP calls SA calls ARM and so on.

can we please add test cases for adding, removing and replacing guardians. + removing expired guardian

The above diagram tries to explain what happens during validation but also has mentions of execution. Can we have separate flow diagram on what happens during the execution?

Updated the diagram

Do we have a technical draft on how social recovery module works? like we have done for other modules

Not yet. Will start making it this week

cool
for devs to understand what would help is ways to interact with this module. which would translate to different types of transaction journeys, for each can we add small flow like EP calls SA calls ARM and so on.

like

When account is deployed by default it enables social recovery module from the sdk. optionally setup can also be done at this step if dev/user provides at least one guardian. secure frontends of wallet onboarding would work like this

btw ARM can not only be sole module enabled right? as it will only use validateUserOp for the cases when there is specific userop calldata

transaction journey to setup guardian on enabled module

flow for submit recovery request. who can submit, which details are required etc in calldata and signature and particular order to follow in stitching signatures.

flow for execute recovery request. who can submit, which details are required etc

please change the scope to merge into develop branch

please change the scope to merge into develop branch

done

can we please add test cases for adding, removing and replacing guardians. + removing expired guardian

they are in place.
https://github.com/bcnmy/scw-contracts/blob/2d016552d59dfd174b29af0b688a4771a44d5c4c/test/module/AccountRecovery.Module.specs.ts#L2072-L2129
https://github.com/bcnmy/scw-contracts/blob/2d016552d59dfd174b29af0b688a4771a44d5c4c/test/module/AccountRecovery.Module.specs.ts#L2277-L2357
etc

The above diagram tries to explain what happens during validation but also has mentions of execution. Can we have separate flow diagram on what happens during the execution?

Updated the diagram

Do we have a technical draft on how social recovery module works? like we have done for other modules

Not yet. Will start making it this week

cool
for devs to understand what would help is ways to interact with this module. which would translate to different types of transaction journeys, for each can we add small flow like EP calls SA calls ARM and so on.

like

When account is deployed by default it enables social recovery module from the sdk. optionally setup can also be done at this step if dev/user provides at least one guardian. secure frontends of wallet onboarding would work like this

btw ARM can not only be sole module enabled right? as it will only use validateUserOp for the cases when there is specific userop calldata

transaction journey to setup guardian on enabled module
flow for submit recovery request. who can submit, which details are required etc in calldata and signature and particular order to follow in stitching signatures.
flow for execute recovery request. who can submit, which details are required etc

Yep, thank you! Will make all of those flowcharts in the article

do resolve the conflicts as well


standard --fix always exits with code 0

What version of this package are you using?
latest
What operating system, Node.js, and npm version?
node.js lts 12.3.6 npm 6.1
What happened?
running it an npm scripts always exits with code 1
What did you expect to happen?
should have some sort of check to see if it is an npm script and if it is then it should always exit code 0
Are you willing to submit a pull request to fix this bug?
no sorry

+1 on this issue.. it gives false negative which causes CI integration to fail

I can't reproduce this.
It's not possible to debug this issue without additional information. If this is still an issue, please leave a comment or open a new issue.


Step 2 of Renew an uploaded Certificate could be more accurante on where to update the cert

Step 2 of https://docs.microsoft.com/en-us/azure/app-service/configure-ssl-certificate#renew-an-uploaded-certificate is pointing out
"Bind the new certificate to the same custom domain without deleting the existing (expiring) certificate. This action replaces the binding instead of removing the existing certificate binding."
We think it might be more clear if it actually tells you to go to TLS/SSL settings--> private certificate thumbprint, since the link attached to "Bind the new certificate" it is linking to just how to create one, not really on how to modify one which on the Portal is actually slightly different. For instance, if you go to Custom Domains (as the linked document suggests) you cannot really change the binding.
Thanks in advance!
Ignacio

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cc2ee874-df45-1de2-1b30-1fd75c7fd709
Version Independent ID: ee181722-8386-9842-407f-d0549012d2e9
Content: Add and manage TLS/SSL certificates - Azure App Service
Content Source: articles/app-service/configure-ssl-certificate.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@IgnacioAlvarezArenas Thanks for the feedback! We are currently investigating and will update you shortly.

@IgnacioAlvarezArenas Thank you for the input. We made an enhancement to the document to hopefully add a little clarity.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Error 122 in Fedora Linux

After following the README, I have a working app, but when the browser tries to open the Zoom Client, it prints "An unknown erorr occurred, Error code: 122"

I am using ngrok with a *.ngrok-free.app domain
Zoom Version: 5.16.2 (8828)
Fedora Version: 38
I see in the 'Domain Allow List' that those domains need some kind of verification, but nowhere in the logs can I see any reason as to why it's failing

What am I missing?

This might be an issue with the Zoom client on Linux than this sample, so I'll close the issue


Finding and rendering link hints is much slower on Firefox

Finding link hints is 3-5 times slower on Firefox.
Rendering is at least twice as slow.

A good improvement i found testing is instead using left and top properties use a transform with translate3d to leverage the use to the gpu

That's an interesting tip. I'll have to give it a shot.


Fix setup scripts of submodule kata

Use parts of the infrastructure in ../utils/
Sourcing (. setup.sh) or executing (./setup.sh) the script now both works
Don't try to be smarter than the average setup.sh script if it doesn't work anyway...

Thank you for your contribution!


EditorExportPlugin will not be called when its script changes

Godot version
4.1.stable
System information
nixos-unstable
Issue description
_customize_resource() and _customize_scenes() will not be called when the EditorExportPlugin script itself is modified unless this also changes the hash returned by _get_customization_configuration_hash().
Steps to reproduce

Open the minimal reproduction Project
Run the Main Scene
Observe, how the cube is white, as declared by the scene.
Export it.
Run it and observe, how the cube is now red, proving my export plugin works.
open res://addons/export/export_plugin.gd
Modify the Color on Line 18.
Export the project once more.

Expcted: The cube now has a new Color.
Observed: It is still red.
Minimal reproduction project
src.zip

Got stuck with the same issue developing my plugin. Based on the source code of 4.3dev4.. Turns out you have to modify a scene manually in order _customize_scenes to be actully invoked, just changing _get_customization_configuration_hash() return value does not seem to work.


:robot: Allow manual testing of branches for uki jobs

What this PR does / why we need it:
Should allow us to manually test different agent and immucore branches for uki jobs directly and run the tests batteries with artifacts built from those branches so we dont need to cut a newer version just to test something
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

cancelled all jobs as this doesnt affect them


Add spanish language file

Feature Request
Is your feature request related to a problem? Please describe.
I wanted to add a Spanish language file copying the English words to Spanish
Describe the solution you'd like
I added a Spanish file, with the addition of some extra words that also have the same meaning.
Teachability, Documentation, Adoption, Migration Strategy
It looks like just adding the file will allow it work one the PR is merged
PR: https://github.com/LucasCtrl/spookyBot/pull/3

Closed with PR #3


Implement thermo_water_update scheme (non-portable wrapper to cam_thermo_water_update)

Originator(s): @jimmielin
Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number):
Closes #177, implementing thermo_water_update scheme to call cam_thermo_water_update.
Describe any changes made to the namelist: N/A
List all files eliminated and why: N/A
List all files added and what they do:
Implement thermo_water_update scheme
A       schemes/thermo_water_update/thermo_water_update.F90
A       schemes/thermo_water_update/thermo_water_update.meta
List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)
Include thermo_water_update scheme in CAM7 suite
Fixes CAM7 build failure by using constituent tendency updater after dry adiabatic adjustment
M       suites/suite_cam7.xml
List any test failures:
Is this a science-changing update?  Yes

Marking as draft until https://github.com/ESCOMP/CAM-SIMA/pull/316 is merged and CAM7 test failure is resolved (https://github.com/ESCOMP/CAM-SIMA/issues/335) so this "scheme" can be fully tested.


[EMB-136] Add missing og:title metatag

Purpose
Add missing og:title metatag
Summary of Changes
Add og:title metatag
Side Effects / Testing Notes
n/a
Ticket
https://openscience.atlassian.net/browse/EMB-136
Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
[ ] testable and includes test(s)
[ ] changes described in CHANGELOG.md

Coverage remained the same at 47.749% when pulling 79f32f2dd9daf4ee1a8b14193ea2a704e14471df on jamescdavis:add_missing_title_metatag into 799f4ba86efb7e5ee00e82b403da515544be35b2 on CenterForOpenScience:develop.


fix when formatting using LTS local formatting token

Thanks for the contribution. Please add tests for this 👍

Good job 👍

Thanks
On Sun, Sep 3, 2017 at 9:48 AM, Ali Taheri Moghaddar <
<EMAIL_ADDRESS>wrote:

Merged #106 https://github.com/jalaali/moment-jalaali/pull/106.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jalaali/moment-jalaali/pull/106#event-1232514175, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGbJ0jkjZYMwwEBtrJFsjb3JDkhad_70ks5sejajgaJpZM4PK2rn
.

--
Your Sincerely
Mehdy Karimpour
[image: Green Eco]Please, consider the environment before printing this
email.


N-UCLA dataset

Thank you for such a great work. Recently I'd like to verify my model on the N-UCLA dataset. It would be great for me if you could provide the code to generate and preprocess the raw data. Thanks again ~

@Roy790422795
Do you know how to  generate and preprocess the NTU120 data?  I would be very grateful if  you could share the codes with me. My webchat:  mingjialia   Looking forward to your contact with me. Thank you very much.

I also want the codes you mentioned.

I'm looking for the same


Allow non generic log

Currently Babe and Aura modules make use of a phantom data because Log must be generic over the runtime trait.
But this phantom data complexify then the convertion to DigestItem, look at __parse_pattern_2, __parse_pattern, __parse_expr and __parse_expr_2 in core/sr_primitives.
This __parse_* stuff can be removed in two ways:

1 - allow non generic log, this would imply having to specify in construct_runtime macro: Log<T>(..) for all modules except babe and aura.
2 - just change Aura log from

pub enum RawLog<T> {
	/// AuRa inherent digests
	PreRuntime([u8; 4], Vec<u8>, PhantomData<T>),
}

to
pub enum Never {}
pub enum RawLog<T> {
        __PhantomVariant(Never, PhantomData<T>),
	/// AuRa inherent digests
	PreRuntime([u8; 4], Vec<u8>, PhantomData<T>),
}

but this implies having some non buildable variant of the log which could annoying in the future if we want to implement some full match pattern (but currently there is not such thing so its actually fine).
I would go for option 1 if wanted, it is not very difficult

log mecanism has been moved out of construct_runtime


fix chain switching on wallet connection

Describe your changes
force the app to switch to the currently selected network when a wallet connects on a different network
Link the related issue
https://github.com/user-attachments/assets/2bc5f8f0-54bc-4096-8e5d-31b1c0e551ef
Checklist before requesting a review

[ ] Is this PR ready for merge? (Please convert to a draft PR otherwise)
[ ] I have performed a self-review of my code.
[ ] Did I request feedback from a team member prior to the merge?
[ ] Does my code following the style guide at docs/CODING-STYLE.md?

Instructions for Reviewers
Functionalities or workflows that should specifically be tested.

Environmental conditions that may result in expected but differential behavior.

If relevant, list additional work to complete pre-merge (delete logging, code abstraction, etc)

replaced by https://github.com/CrocSwap/ambient-ts-app/pull/4377


Record clicks on non-movable blocks

LGTM

@tmickel please take a look--I'm probably merging this tomorrow morning unless I hear objections.

This still fails for touch.


fix: add get range in storage engine

Codecov Report

Merging #218 (fb31017) into main (28b5b09) will increase coverage by 0.32%.
The diff coverage is 47.50%.

:exclamation: Current head fb31017 differs from pull request most recent head afab976. Consider uploading reports for the commit afab976 to get more accurate results

@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   51.70%   52.03%   +0.32%
==========================================
  Files          37       37
  Lines        2785     2950     +165
==========================================
+ Hits         1440     1535      +95
- Misses       1345     1415      +70

Flag
Coverage Δ

rust
52.03% <47.50%> (+0.32%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/node/src/auth_storage.rs
1.36% <0.00%> (-0.22%)
:arrow_down:

src/node/src/storage_node_impl.rs
0.82% <0.00%> (-0.20%)
:arrow_down:

src/storage/src/kv_store.rs
88.60% <95.95%> (+5.27%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

This PR exceeds the recommended size of 1200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.


spirv-val doesn't validate Vulkan restrictions for  OpTypeRuntimeArray

Vulkan spec says:
OpTypeRuntimeArray must only be used for:
◦ the last member of an OpTypeStruct that is in the StorageBuffer storage class decorated as
Block, or that is in the Uniform storage class decorated as BufferBlock.
This CTS tests violates it  dEQP-VK.spirv_assembly.instruction.compute.pointer_parameter.workgroup_memory_variable_pointers contains

I have a rule for WebGPU that is a restriction on this rule, so I will implement this first.


Optimize output

Signed-off-by: zhouhao<EMAIL_ADDRESS>

LGTM

What is the purpose of this change? What do you mean by "Optimize Output"?


Can not start the app - linux platform

There is an error while starting the app in linux.
Please rename test-ui/core/UITester.less to UiTester. This will resolve the problem on case sensitive systems.

I tested the AppImage download on Ubuntu and it works fine. Further more I'm developing on a Mac which has a case sensitive file system, too.
Please give me more information about your error: Which Linux distribution are you using? How did you start Picturama (did you use the AppImage or something else)? Can you post the original error message?

Hello. Here  are some details:
Linux - Arch Linux
Clone the repo
Start yarn and yarn start
The result is:
Child mini-css-extract-plugin node_modules/css-loader/dist/cjs.js!node_modules/less-loader/dist/cjs.js!src/test-ui/entry.less:
Entrypoint mini-css-extract-plugin = *
[./node_modules/css-loader/dist/cjs.js!./node_modules/less-loader/dist/cjs.js!./src/test-ui/entry.less] 319 bytes {mini-css-extract-plugin} [built] [failed] [1 error]
    ERROR in ./src/test-ui/entry.less (./node_modules/css-loader/dist/cjs.js!./node_modules/less-loader/dist/cjs.js!./src/test-ui/entry.less)
    Module build failed (from ./node_modules/less-loader/dist/cjs.js):

    @import "./core/UiTester.less";
    ^
    Can't resolve './core/UiTester.less' in '/mnt/devel/projects/github/test/picturama/src/test-ui'
          in /mnt/devel/projects/github/test/picturama/src/test-ui/entry.less (line 1, column 0)

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Check this directory - picturama/src/test-ui/core/
There are two files:  UITester.less and UiTester.tsx
In UiTester.tsx you try to import  import './UiTester.less'
But the file is UI - with capital I letter instead of i

Thank you for the details. I fixed the casing with f9efe8d451302313f9459d34de8820e68403340b.


[POC] mailbox sending queue on yielding scheduler

closed for https://github.com/apache/pinot/pull/10761


Feature/new UI theme - All Subscriptions page, Add New Podcast modal, Podcast Detail page, Episode Info modal

Description

This PR addresses the following UI updates discussed in #158. I have called out specific features I did not complete as part of this, since I first wanted to only do a "reskin" as a first iteration.

All Subscriptions page (and by extension Favorites page)

I have not yet added the new topic filter or the grid/list view toggle.

Add New Podcast modal

I just realized that I have not yet done the PodIndex import. I can do that in the next PR or I can update this one if you prefer.

Podcast Detail page

I have not yet added the episode sort, the duration of each episode, or the checkmark once an episode is complete.

Episode Info modal

Linked Issues
This addresses part but not all of #158.
Additional context

I'd like to call out that I installed new dependencies for the font and the icons. I've also started to use the icons directly instead of using components. This was because I needed to toggle between the outlined and the filled version (for the "Download to server" indicator), and it would have been messier with a component. Lastly, I created some components for some commonly used elements (headings, buttons, inputs). I hope this is OK.

Sorry, I just noticed that it looks like you use pnpm instead, so we have two different lock files. Should I switch over to pnpm and reinstall the new dependencies?

Switching to pnpm would be good. Maybe we should switch the default select by a radix drop-down which already contains all the necessary alt attributes + can be styled more easily
(https://www.radix-ui.com/docs/primitives/components/dropdown-menu). I also noticed that the drop-down 1.1.-31.12 isn’t being persisted and defaults to oldest to newest episodes.

Better use grid than flex box as the box is shorter if someone has a really short description. I think it would be better to have the box take up close to the full width.

Other than that I really appreciate your work that you put into the first two pages. If you need any help feel free to comment here.

Maybe we should switch the default select by a radix drop-down which already contains all the necessary alt attributes + can be styled more easily (https://www.radix-ui.com/docs/primitives/components/select).

Do you want that covered in this iteration? That might also open up other questions about whether we should utilize other components from that library.

I also noticed that the drop-down 1.1.-31.12 isn’t being persisted and defaults to oldest to newest episodes.

I don't think that's due to the changes I've made. I think it's the same with the latest build.

The notification is a little bit out of the page
We should get rid of the burger menu. It should only be displayed on mobile to open the sidebar.

Likewise, I haven't touched the header yet.

Ah okay. Forgot that that is also part of the header. Would be good if you could add the dropdown in this iteration so we can say that the pages are done.

@SamTV12345 Alright, I've added the Radix select. We might need to work through some merge conflicts, as I noticed there have been changes to the sort/filter in the main branch.

Thanks. I fixed the sorting/filter bug in the main branch. Sorry for the misunderstanding I broke that feature 😅.

Did the Podindex tab in the add podcast modal look good? Forgot to mention that there is a hidden tab that is only activated once the correct credentials are set.

Yep! It looks like it basically shares the same front-end code as the iTunes import, so I don't think I had to do anything additional for it.

Alright, sure. Do you want me to just keep adding to this PR?

Yes. That's alright. I'll merge this one into the new-ui-theme and will try to resolve the merge conflicts.


CTCSS enable it only for transmission

Is it possible to set the tone only for transmission and not for reception?
Thank's

I'm sorry for not getting back to you sooner.
Yes, setting a different tone for receiving and transmitting is possible.
You can use the option --ctcss followed by 2 numbers separated by a comma. The firest number is for tx the second for transmit.
For example: --ctcss 94.8,103.5

Hello @cdjlele,
I just made a PR (pull request) for that.
Regards,
Armel F4HWN.

I have merged your changes. Thank you so much for sending your code.
-fred-

You're welcome Fred. Thank you, it's been a pleasure 😌


Hide internal stacktrace lines in CC reports

This is a companion PR for

https://github.com/gradle/configuration-cache-report/pull/9

It changes the format of the data written for the CC report, marking part of exception stack traces to improve their display in the HTML report.

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test APT

I've triggered the following builds for you. Click here to see all build failures.

AllPerformanceTestsReadyForRelease build

@bot-gradle merge

The merge queue build has started. Click here to see all failures if any.


workbench.action.tasks.build no longer triggers build but opens a list of tasks

Fixes #130028

The issue only occurs when there is a task labeled "build" which is also the default build task. Essentially, it's "defaultness" is getting overwritten.


Welcome screen

welcome screen for newcomers. should also create the SQLite files in the background.

solved in #9


F#

What about F#? Does anyone use tab?

It seems that Top 180 F# repos don't use tabs. Do you want to increase the number of analysed repositories?


Pad computation results to the required length.

I noticed pk.finalize() occasionally (and for no apparent reason) returns an
UnsupportedParameters error, instead of the Ok result I would expect.
I don't have a minimal reproducible example I can share yet, but here are the
steps I took to reproduce the issue:

use pk.blind() to create a blinded message for a recipient whose public key
is pk
get the recipient to produce a blinded signature and use it to create a
BlindedSignature
call pk.finalize(...) <--- this will occasionally fail the verification:

first the message is unblinded to produce the signature of the original
message: https://github.com/jedisct1/rust-blind-rsa-signatures/blob/622b6a5949544a35c9d5913ddb599a7fe6de5cfa/src/lib.rs#L342-L344
the signature then fails the verification because sig.len() != modulus_bytes
(in my case, sig.len() = 511 and modulus_bytes = 512): https://github.com/jedisct1/rust-blind-rsa-signatures/blob/622b6a5949544a35c9d5913ddb599a7fe6de5cfa/src/lib.rs#L357-L359

This is what I think happens:

these initial checks pass, so I know blind_sig.len() == modulus_bytes
according to the RFC, the resulting unblinded signature should have the same
length as the blinded signature
somehow this other length check fails, despite the fact that
blind_sig.len() == modulus_bytes at the beginning of finalize()!
the problem seems to be this: converting a vector of bytes to and
fromBigUint, with some transformations in between (i.e. unblind), doesn't
guarantee the output vector has the same length as the input one, because
BigUint will strip away any leading zeroes from the representation of the
number:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=80d02761702f676119fedbb9a5ddd845

This patch fixes the problem for me (the solution seems to be to pad any vectors
obtained using to_bytes_be to have a length of modulus_bytes).

Good catch.
The Zig implementation doesn't have this issue since it defines a bn2binPadded() function for this.
Instead of adding zero_left_pad() calls, maybe it would be less error-prone to do something similar, and define a to_bytes_be_padded() function instead. That can be implemented as a trait.

@jedisct1 Thank you for the review!
I addressed your comment in a separate commit, but I'm happy to squash it before merging.

Looking good!
Thank you so much for this, Gabi!


Catch EventBus event in Custom View

I'm customing a View and I want to listening event from there. I created a show() and hide() method then put register & unregister inside these methods.
But i tried to put
     @Subscribe(threadMode = ThreadMode.MAIN)     public void onEvent(EventBusMessage eventBusMessage) {         Log.i("hieu", "");     }
but it didn't jumped in.
How to archive this? Thanks.

Logcat doesn't log empty string, that made me think that it doesn't work in custom view.


Refactor .py file to better-use OO principles

Specifically the concept of "question type" is better handled at the class level. But this is a big refactor

Current plan is to replace "DAQuestion" source method with a series of small Mako templates that can be loaded from a YAML file. See https://github.com/SuffolkLITLab/docassemble-assemblylinewizard/tree/loading-data-from-yaml-file


Tests

Hey :wave:
I think some tests for the package would come handy :relaxed:

@manniL Can I have your advice? I'm not experienced in writing tests for packages. I'm going to to make following tests on npm publish hook:

payload extract
payload write to nested path
eval payload to json

Sounds OK?

Hi! 👋 Awesome work!
As I tested the module today, I didn't noticed any issues with empty payload.json files. Even for nested routes.
Are there still known bugs? Is it package suitable for production?

@robertpiosik Hi! Cool, glad you like it.
Yes, bug with empty payload is fixed a month ago.
There may be issues if you are using vuex to fetch data, or router base to make prefix for all URLs. And as there  are no tests yet, new buggs compability may appear with new nuxt version.
I'd use this module for production if I'd need to. But so far, the only real project I know using it is https://tobias-thiele.de/ (https://github.com/DreaMinder/nuxt-payload-extractor/issues/2).

I'll try to add some tests ! @Atinux you confirmed Nuxt will crawl all pages for generating routes ? Will this feature (extract payload) be released with ?
The payload.json file is a real data saving !

@edimitchel nice, thanks! But...

Will this feature (extract payload) be released with ?

after you and me faced nested-routes bug, I don't think it is a good idea. Because in current implementation,  I don't see any way to solve it. Maybe it should be moved to core, where its possible to get nesting-level of current route... Or hooks API should be modified to do so if its possible.

I suggested this question because a comment made by @Atinux on https://github.com/nuxt/rfcs/issues/22#issuecomment-499075927

Use our crawler in union with generate.routes (crawler already working on https://github.com/nuxt/nuxtjs.org/blob/master/modules/crawler/index.js) and move it inside @nuxt/generator


/tmp fills up unecessarily

The production instance for https://view.commonwl.org had 900 GB in /tmp - it seems these folders are not cleared up after inspecting say a git checkout.
CWL Viewer should be improved to delete any /tmp directories after use.
In addition the Dockerfile could add a background job to delete old content in /tmp. /tmp should also be a Volume so this is not tracked in the differential file system, perhaps docker-compose can mount it with tmpfs (Warning: which could then use too much memory.)
This could also be an external cronjob, but it will need to run "something" to tidy /tmp - normally in a full distro you would use something like tmpreaper or a simple find -delete -maxage ... job.

Ah, that explains the issues. Thanks for looking into this so late in the day!

Related #279

Hey @mr-c, @tetron I have few questions regarding this issue:

Are you talking about the checkouts we see after running- "find /data", several lines like this are generated "/data/git/202a2346ae8fb5e1b31483ac74950b9bf80c9d24/tools/qc-stats-job.yaml"?
How often you want this to get deleted, I mean 5 mins or 10 mins after checkout?
How often cronjob needs to be executed?

Hi @Anushka-shukla let me try to clarify a bit.
When running with the composer template, the paths under /data are mounted as docker volumes. They are not the problem. The problematic files are in /tmp in the "spring" container. There are 2 types of directories created there, example names:
1617296363663-0
1618114192166-0
1618114192624-0
1618114195612-0
1618114196218-0
1618114200741-0
1618114215101-0
1618114388013-0
1618114389375-0
robundle100420815496920298
robundle9048388051013328806
robundle9049397155484048896
robundle9071142471129036907
robundle9074233902584532163
robundle9075313018928131845
robundle9094827430149401292
robundle9135927134991560993
robundle9142606895250111209
robundle9148493090147849597
robundle9191568390507878674
robundle9216040329276667335
robundle9219138050744442526

The directories with the name like epoch-0 (that large number is the number of seconds since 1970-01-01 00:00:00, aka the epoch) contain a git checkout.
My guess is the process goes something like: temporary git checkout under /tmp/epoch-0, sometimes that takes a long time because the repository is enormous. If the user is impatient they can start multiple at once, which bogs down processing even more (bug 1). I assume that eventually, if nothing goes wrong, a copy is made to /data/git . But the copy under /tmp/epoch-0 is not (always?) cleaned up (bug 2). At some point I guess the /tmp/robundle directories are made as well, and those do not (always?) seem to be cleaned up either (bug 3).
In terms of when to delete the temporary files - ideally that would happen when the processing is done and the copy to /data/git/ is made (if that is really how it works!). In other words, it should not be time based, and we want to remove the need for the cron job.
Does that clarify things a bit?

Hey, thanks @cure yes this explains the issue, thanks.

Hi @cure, I'm not able to find the /tmp folder and spring container. How I can reproduce these bugs?

Try docker-compose exec -T spring find /tmp
On Mon, 12 Apr 2021 at 18:27, Anushka Shukla @.***>
wrote:

Hi @cure https://github.com/cure, I'm not able to find the /tmp folder
and spring container. How I can reproduce these bugs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/common-workflow-language/cwlviewer/issues/200#issuecomment-817949795,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKE4CBCJSS2OUNSFMNI563TIMNNPANCNFSM4FFSB63Q
.

--
Michael R. Crusoe
Co-founder & Lead,
Common Workflow Language project http://www.commonwl.org/
https://orcid.org/0000-0002-2961-9670
@.***


Ignore all exception from telemetry.

Signed-off-by: Pan Li<EMAIL_ADDRESS>

Codecov Report

Merging #343 into 2.0.x will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##            2.0.x     #343   +/-   ##
=======================================
  Coverage   80.79%   80.79%
=======================================
  Files          42       42
  Lines        1078     1078
  Branches      138      138
=======================================
  Hits          871      871
  Misses        133      133
  Partials       74       74

Impacted Files
Coverage Δ

...e/spring/data/cosmosdb/common/TelemetrySender.java
82.75% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a53b8bd...d05fe61. Read the comment docs.


[enhancement] implement puppet strings

Include puppet-strings in gemfile and make sure we update documentation on each run

also update .gitignore


Ghost Touch

Sometimes, when i play PUBGM my screen has ghost touch and i cannot pull my screen for control the recoil. Hope you can fix this Thank You BTW, Iam a Content creator, i very need scrcpy THX

I'm not sure to understand the problem you have.
What do you mean by "ghost touch" and what can't you do?


Expose Jetty Metrics via JMX

We are using the confluent rest proxy and are looking for more detailed metrics about request wait time, thread usage etc.
Jetty has a wealth of JMX metrics but they need to be manually enabled. Can we enable these metrics?
http://www.eclipse.org/jetty/documentation/current/jmx-chapter.html

Closed via #47


add openai functions agent

add openAI functions agent
PR Checklist

[x] Read the Contributing documentation.
[x] Read the Code of conduct documentation.
[x] Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
[x] Describes the source of new concepts.
[x] References existing implementations as appropriate.
[x] Contains test coverage for new functions.
[x] Passes all golangci-lint checks.

@tmc  Sorry to bother you, could you please review and merge my PR? Thanks!

@tmc Sorry to bother you, could you please review and merge my PR? Thanks!

Sorry about the delay.
In reviewing this I think we can improve some design issues with the agents package.
I filed https://github.com/tmc/langchaingo/issues/463 -- can you comment on that and consider implementing these? I will approve and merge this now but I'd like to refactor this before the subsequent release.

@tmc Sorry to bother you, could you please review and merge my PR? Thanks!

Sorry about the delay.
In reviewing this I think we can improve some design issues with the agents package.
I filed #463 -- can you consider implementing these in a separate PR? I will review this now but I'd like to refactor this before the subsequent release.

Do you mean I open another PR to implement this refactoring and then implement the openai function agent?
If so, I'll give it a try.

@tmc Sorry to bother you, could you please review and merge my PR? Thanks!

Sorry about the delay.
In reviewing this I think we can improve some design issues with the agents package.
I filed #463 -- can you consider implementing these in a separate PR? I will review this now but I'd like to refactor this before the subsequent release.

Do you mean I open another PR to implement this refactoring and then implement the openai function agent?
If so, I'll give it a try.

No we can tackle that in a later PR, I have a small comment about this PR and will accept it but we should then work on cleaning up the agents package API after that.

This needs to be rebased with the recent LanguageModel -> LLM refactor

This needs to be rebased with the recent LanguageModel -> LLM refactor

Why this refactoring? It seems that the function call needs the chat completions interface, but the LLM interface only supports completions?

@tmc fixed


Version 2.0.3 not in the npm repository

Bug Report
Problem
The latest version 2.0.3 is not in the npm repository and therefore cordova plugin add<EMAIL_ADDRESS>fails
What is expected to happen?
cordova plugin add<EMAIL_ADDRESS>succeeds
What does actually happen?
cordova plugin add<EMAIL_ADDRESS>fails
Information

Please publish the latest version to npm.
As far as I know, these other packages are in also the same situation:

cordova-plugin-inappbrowser
cordova-plugin-network-information
cordova-plugin-screen-orientation
cordova-plugin-splashscreen
cordova-plugin-statusbar
cordova-plugin-whitelist

Command or Code

Environment, Platform, Device

Version information

Checklist

[x] I searched for existing GitHub issues
[x] I updated all Cordova tooling to most recent version
[x] I included all the necessary information above

The version you are looking for has not been officially release. Please monitor npmjs. Once the plugin appears there, then it is officially available to use.
https://www.npmjs.com/package/cordova-plugin-device
The other packages are in also the same situation.

Cool, thanks for the clarification :)


Change Spray version to 1.3.2 and change spray-routing to spray-routing-...

Currently, spray-swagger relies on Spray 1.3.1 which uses an old version of Shapeless (1.2.4). In order to resolve conflict cross-version suffixes when trying to use shapeless 2.0.0, this PR bumps Spray to 1.3.2 and uses the spray-routing-shapeless2 release as described in the Spray docs which says:

For shapeless 2.0.0 you should use spray 1.3.2 (Scala 2.10 or Scala 2.11) and the spray-routing-shapeless2 module instead of spray-routing.

You may have to maintain two different branches the same way the Spray project does, with one using spray-routing and the other using spray-routing-shapeless2 for those that wish to use shapeless 2.0.0.

@levinotik just looking at this now, sorry for the delay. What do you think is the best move here? just support shapeless 2.0.0? What about Spray 1.3.3/Shapeless 2.1?

Thanks @mhamrah
I'm not totally sure and I think it depends on how you feel you want to handle things going forward. Seems the questions are:

When do you want to bump master to use Spray 1.3.3?
For how long, if at all, would you continue to publish artifacts for Spray < 1.3.3 as changes are made to this project?
Should you maintain a separate branch for the Shapeless 2.0.0/Spray 1.3.2 combo?

One option might be a deprecation cycle where for some length of time, you'll publish new artifacts for Shapeless 1.2.4/Spray 1.1.3, 1.2.3 or 1.3.3 and Spray 1.3.2/Shapeless 2.0.0, eventually stopping new releases for anything except for Shapeless 2.1.0/Spray 1.3.3. I guess this question depends largely on what the users of this library are doing.
Just trying to lay out the issues. Hope it's helpful.


How to install from pip?

Conda is pretty problematic as far as reproducibility goes since you have to hack together environments. Ideally, packages can be installed from pip, but this doesn't seem to be documented on the README. Is this possible?

This package can be install with pip by running pip install .
You can also try the Docker or Singularity containers at https://biocontainers.pro/tools/riassigner.

For installation guideline see the 'Installation' section in the readme - there is also a section on how to install the package manually.
Otherwise it would maybe also be possible to host the package via pypi, but that would require additional steps.

Yes I am explicitly interested in using the standard package installation procedure from PyPI - a package without this won’t be useful/usable to most potential users

Thanks for the feedback - yeah, I was considering hosting on PyPI some time ago but then didn't follow up with it - I agree that a large user base uses PyPI exclusively.
I'll have a look and see that we can get the package onto PyPI!

@cthoyt the package is now installable via pip - can you please confirm everything works fine for you?

@cthoyt Are you still experiencing some problems that need to be addressed for the review?

@hechth sorry I seemed to miss your comment before. Pip install works great now!


Upgrading the hawkular-client to 2.0.0

@miq-bot add_label providers/hawkular, gem changes
cc @abonas @lucasponce @pilhuhn

@chriskacerguis why was this assigned to you?

@Jiri-Kremser the commits "merge ..." and "rubocop" shouldn't imo really go into the git log later, please check if they can be squashed.

the commits "merge ..." and "rubocop" shouldn't imo really go into the git log later, please check if they can be squashed.

Done

the PR is a bit hard to review because some methods look like they were erased, but in fact they were just shifted somewhere else in the file (metrics_resource, child_resources, etc.)

I think this looks good to me.

@pilhuhn ok then lets go with your review :smile:

@simon3z Can you have a look as well please?

Thanks @pilhuhn, @yaacov can you take a look? Thanks.

metrics are collected, so LGTM :+1:  from the metrics collection point of view.

@pilhuhn LGTMed this PR, and we also got green light from containers team, so reassigning to @chessbyte for miq core final review & merge.
@miq-bot assign @chessbyte

@abonas should this be labeled darga/yes or darga/no?

@chessbyte middleware should not be in darga
On 21 Jun 2016 9:07 p.m., "Oleg Barenboim"<EMAIL_ADDRESS>wrote:

Merged #9299 https://github.com/ManageIQ/manageiq/pull/9299.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ManageIQ/manageiq/pull/9299#event-699445616, or mute
the thread
https://github.com/notifications/unsubscribe/AF_Ife_sVRvfxPqO68eULMHZ7O4lZlKuks5qOChWgaJpZM4I551V
.