mini project issue

https://theoh32.github.io/jtf-blog/plan

Group Planning Blog
Good things:

Work seems to have the key features laid out: leaderboard based on time taken (Theo), sorting algorithm and the visualization (Justin), and the visual bar representation  (Finn)
Provided visual examples and code samples of what they are trying to implement
Every person pitched a part of the project and seems invested and involved in the process
Every person on the team has at least one Java feature to code and work on

Lacking:

Only thing lacking is specifics regarding which methods using and what data they are sorting in each sorting method to determine complexity

Overall Score/Comments:

0.95/1
Everything looks solid, as mentioned jsut missing specific methods and data used for sorting and probably could've gone a little bit more into depth if they are sorting an API, user input, or pre set data

Jif is classic method to view data.  I have not done such a representation before and particularly through an API.  It seems like data in sort need to write to location that API can fetch.  Mechanics needs discussion.


Adjusting the logging for Sync Rest Proxy

Sync rest proxy should not utilize the RestProxyBase logger, it adds difficultly towards understanding the logs.
Also, we should look to adjust rest proxy base to not log status codes for completed HTTP requests. If the service rejects the request, we should allow that to be logged by the SDKs, allowing them to maintain their own logging logic.

This issue currently affects the logging for the Tables SDK:
TableServiceClient.createTableIfNotExists (when table already exists) gives unhelpful log message:
[ERROR] com.azure.core.implementation.http.rest.RestProxyBase - Status code 409...


(AO) The new Cpython vertual environment could not support edb.configuration.run(fix_padstack_def=True)

After extracting To_Be_1216.zip in a new Cpython environment
Unzip To_Be_1216.zip
Run_EDB.bat.
It makes bellow errors.
Traceback (most recent call last):
File "C:\Users\aohta\OneDrive - ANSYS, Inc\Documents\2024_BMT\DENSO\To_Be_1216\pyedb_setup.py", line 57, in
To_Be_1216.zip
File "C:\Users\aohta\venv310\lib\site-packages\pyedb\configuration\configuration.py", line 124, in run
self.cfg_data.components.apply()
File "C:\Users\aohta\venv310\lib\site-packages\pyedb\configuration\cfg_components.py", line 254, in apply
comp.set_parameters_to_edb()
File "C:\Users\aohta\venv310\lib\site-packages\pyedb\configuration\cfg_components.py", line 214, in set_parameters_to_edb
self._pyedb_obj.enabled = self.enabled
File "C:\Users\aohta\venv310\lib\site-packages\pyedb\dotnet\edb_core\cell\hierarchy\component.py", line 210, in enabled
cmp_prop.SetEnabled(value)
AttributeError: 'IOComponentProperty' object has no attribute 'SetEnabled'
Can you please find out what the problem is?
Newly created Cpython virtual environment:venv310_NG.zip
https://ansys-my.sharepoint.com/:u:/p/akira_ohta/EbriGxMM3eVNoItQ3Xc3PZsBHOkYo0hwcmCi_Ct54eRkCw?e=l7LIKF
This script runs without problems in environments that have been updated to the latest version using
pip install -U pyaedt[all] from the previous environment.
Lib Environment updated to the latest version from the previous environment:venv310_OK.zip
https://ansys-my.sharepoint.com/:u:/p/akira_ohta/EWDlo-EPGEFFjTo3_oljVpABsuXpvzYfe6mswh9sDb4Ryg?e=UQFA0z

This is not related to env. Only RLC can be enabled or disabled. You can remove "enabled" key from cfg file.
AttributeError: 'IOComponentProperty' object has no attribute 'SetEnabled'

@hui-zhou-a
Hui-san
Thank you for response.
Please let me know correct cfg format of  edb_configuration.json.
It is in To_Be_1216.zip
I could not run correctly after remove "enabled" key from cfg file.
edb_configuration.json
(I found PyEDB could not control model activate/deactivate now.
So I think it is need to control by cfg file.)
But error is occurred as bellow.
PyAEDT INFO: EDB initialized.
Traceback (most recent call last):
File "C:\Users\aohta\OneDrive - ANSYS, Inc\Documents\2024_BMT\DENSO\To_Be_1216\pyedb_setup.py", line 56, in
edb.configuration.load(config_file=file_json)
File "C:\Users\aohta\venv310\lib\site-packages\pyedb\configuration\configuration.py", line 92, in load
self.cfg_data = CfgData(self._pedb, **self.data)
File "C:\Users\aohta\venv310\lib\site-packages\pyedb\configuration\cfg_data.py", line 60, in init
self.ports = CfgPorts(self._pedb, ports_data=kwargs.get("ports", []))
File "C:\Users\aohta\venv310\lib\site-packages\pyedb\configuration\cfg_ports_sources.py", line 123, in init
if p["type"] == "wave_port":
KeyError: 'type'
I  could not run correctly after remove all component assign setting.
no_cmp_edb_configuration.json
The error has been occurred on New env.
Error Message
File "C:\Users\aohta\venv310\lib\site-packages\pyedb\configuration\configuration.py", line 140, in run
temp[name] = pdef.get_properties()
AttributeError: 'EDBPadstack' object has no attribute 'get_properties'. Did you mean: 'hole_properties'?
I think it is depending on Cpython env.

@aohta2021 it isa bug. DL1 is an IO component from database. It needs to be changed to inductor before setting enabled. I made a pr to fix this

@hui-zhou-a
I added new TEST case as To_TEST_1223.zip
and no error PyAEDT enviromnet as venv310_OK.zip
This has not been fixed yet.
Please run_EDB.bat after changed Line 20 and Line 30 for your install environment.
Error can avoid after setting old updated PyAEDT( Which is setting venv_310_OK)
I think this issue is depending PyAEDT environment.
Please check it again.
To_TEST_1223.zip
https://ansys-my.sharepoint.com/:u:/p/akira_ohta/EZjWAtUSoEpDgbmQQtK145wBIF5redDbnCdrGlMCmtDq1g?e=4iwhGE

The issue is
edb.configuration.run(fix_padstack_def=True)
It makes error on the latest PyAEDT.
If it is changed fix_padstack_def=False, Script ruin successful.
But the design could not keep anti pad hole and it makes DC error on analysis.


RedisStore::add() is a little bit overkill

In Illuminate\Cache\RedisStore, the add method uses the EVAL command from Redis to run a Lua script that performs some checks before adding the key/value to the database.
public function add($key, $value, $minutes)
{
    $lua = "return redis.call('exists',KEYS[1])<1 and redis.call('setex',KEYS[1],ARGV[2],ARGV[1])";

    return (bool) $this->connection()->eval(
        $lua, 1, $this->prefix.$key, $this->serialize($value), (int) max(1, $minutes * 60)
    );
}

In my company, the security department blocks unsafe Redis commands to ensure hackers can't do too much harm. I don't know a lot about Redis, so I'm asking here if it could be possible to re-implement it in a safer way.
I don't use the add method (I prefer using remember), but I think this is an easy and useful change anyway.

If your company blocks Lua Script then I believe you'll face many issues in lots of places using teh framework.
Anyway for suggestions and feature requests please use the https://github.com/laravel/internals repo.


Sidebar active attribute not working

Describe the bug
On older versions it works so I guess something has broken (or a change that isn't reflected in the docs). My understanding is I provide a boolean inside the active tag and based on that it would show as active or not.
This is how I'm using it:
<Sidebar class="...">
                <SidebarWrapper class="...">
                    <SidebarGroup>
                            <SidebarItem ... active="{activeNum === 1}" on:click={() => activeNum = 1}/>
                            <SidebarItem ... active="{activeNum === 2}" on:click={() => activeNum = 2}/>
                            ...

If activeNum is 1 the first item would be active, if activeNum is 2 second item would active and so on. So this is working as expected on 0.34.9. I upgraded recently to 0.44.19 (and today to 0.44.20) and this doesn't work anymore for some reason.
Reproduction
You should able to reproduce it pretty easily. Here's the easiest example I could think of:
<Sidebar>
    <SidebarWrapper>
        <SidebarGroup>
            <SidebarItem ... active="{true}"/>
            <SidebarItem ... active="{false}"/>
...

I don't think even the given example in the docs works (with correct url ofc) but I'm not 100% sure as I might be doing something wrong there.
Flowbite version and System Info
As mentioned above working as expected on 0.34.9
Not working as expected on 0.44.19 and 0.44.20
(I haven't tried other versions for now to pinpoint where it has broken)

System:
    OS: Windows 10 10.0.19045
    CPU: (12) x64 AMD Ryzen 5 1600 Six-Core Processor
    Memory: 4.98 GB / 15.93 GB
  Binaries:
    Node: 18.15.0 - C:\Program Files\nodejs\node.EXE
    npm: 9.5.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.3636.0), Chromium (111.0.1661.62)
  npmPackages:
    @sveltejs/kit: ^1.27.6 => 1.27.6
    flowbite-svelte: ^0.44.20 => 0.44.20
    svelte: ^4.0.0 => 4.2.7
    vite: ^4.0.0 => 4.5.1

Please use activeUrl as stated in the doc: https://flowbite-svelte.com/docs/components/sidebar#Adding_links_and_active_class

See the first example in the docs using the active attribute.
... <SidebarItem label="Sidebar" href="/docs/components/sidebar" active={activeUrl === '/docs/components/sidebar'}> ...
Also I can't use activeUrl as I need to use it on 1 page (in a modal). Why was the active attribute removed? Are you planning on adding it back?

@pbborisov18
I found a way that works for me at least:
create the activeUrl. I think you actually have to name it activeUrl because when I named it href it didnt work.
let activeUrl = '/settings/profile';
create your Sidebar and give the SidebarItems some logic sounding hrefs. Also give the event with your on:click function (or whatever triggers you use)
<div class="flex gap-10 justify-center"> 	<Sidebar {activeUrl} {activeClass} {nonActiveClass} class="mt-10 left-0"> 		<SidebarWrapper> 			<SidebarGroup class="space-y-8"> 				<SidebarItem 					href="/settings/profile" 					id="profile" 					label="Public Profile" 					{spanClass} 					on:click={(event) => changeTab(0, event)} 				> 					<svelte:fragment slot="icon"> 						<UserOutline 							class="w-5 h-5 text-gray-500 transition duration-75 dark:text-gray-400 group-hover:text-gray-900 dark:group-hover:text-white" 						/> 					</svelte:fragment> 				</SidebarItem> 				<SidebarItem 					href="/settings/account" 					id="account" 					label="Account management" 					{spanClass} 					on:click={(event) => changeTab(1, event)} 				> 					<svelte:fragment slot="icon"> 						<UserSettingsOutline 							class="w-5 h-5 text-gray-500 transition duration-75 dark:text-gray-400 group-hover:text-gray-900 dark:group-hover:text-white" 						/> 					</svelte:fragment> 				</SidebarItem> ...
In the triggered function set the activeUrl and preventDefault for the event because it will route you to the page otherwise
function changeTab(tabIndex: number, event: MouseEvent) { 		event.preventDefault(); 		switch (tabIndex) { 			case 0: 				activeUrl = '/settings/profile'; 				break; 			case 1: 				activeUrl = '/settings/account'; 				break; ...
Since I use replaceState (see Shallow Routing) from the new Sveltekit2.0 Update to change the url and not actually load the page I can use my activeUrl then to change url in the browser.
So I think the important things are that the activeUrl is actually called activeUrl and the SidebarItems have their href's set according to your activeUrl changes. You can just prevent the default routing event in your event method (The SidebarItems actually represent  tags). There you go.

@pbborisov18
I found a way that works for me at least:
create the activeUrl. I think you actually have to name it activeUrl because when I named it href it didnt work.
let activeUrl = '/settings/profile';
create your Sidebar with the activeUrl variable and give the SidebarItems some logic sounding hrefs. Also give the event with your on:click function (or whatever triggers you use)
<Sidebar {activeUrl}><SidebarWrapper><SidebarGroup><SidebarItem href="/settings/profile" id="profile" label="Public Profile" on:click={(event) => changeTab(0, event)}>...
In the triggered function set the activeUrl and preventDefault for the event because it will route you to the page otherwise
function changeTab(tabIndex: number, event: MouseEvent) { 		event.preventDefault(); activeUrl = "/yourExample"; ...
Since I use replaceState (see Shallow Routing) from the new Sveltekit2.0 Update to change the url and not actually load the page I can use my activeUrl then to change url in the browser.
So I think the important things are that the activeUrl is actually called activeUrl and the SidebarItems have their href's set according to your activeUrl changes. You can just prevent the default routing event in your event method (The SidebarItems actually represent  tags). There you go.
I think the confusing part is that in the documentation it actually uses active=... even tho it doesnt do anything. So I tried it out myself and got stuck on the idea that active= could do anything. But you actually HAVE to use the activeUrl even tho you prevent the routing.

I'm interested in this as well. I assumed that you can set the active state of the item manually. Example in the docs is showing the use of active as well. But it seems it all is controlled by activeUrl.
This is very limiting, as not all app sidebars are directly linked to routing, and using pseudo paths to 'trick' the component is not very intuitive and feels hacky.
Don't you agree @shinokada? What is the reason for this limitation? Would it make sense to create a PR to extend this component?

I just noticed that SidebarDropdownItem behaves differently to SidebarItem. In SidebarDropdownItem you can actually manually set the active prop.
It creates even more confusion to me. I would expect both components to have consistency.

The active property appears to have been there before on the SidebarItem but someone commented it out claiming to simplify it, however this doesn't work with sub routes or dynamic sub routes when you might want to mark sidebar item active with out defining child items in the side bar
https://github.com/themesberg/flowbite-svelte/blame/233f9b2caf6fda5172e1c6e03306ee9a6c722253/src/lib/sidebar/SidebarItem.svelte#L11


Web clipper feature: option to automatically clip every page on load

TL;DR - I want to browse and trust that the clipper (& interpreter) are taking notes for me.
Use case or problem
Obsidian Web clipper is great. So great that I'd like the option to have it "clip" every website I visit automatically.
Proposed solution
In the Extension Settings, an option that would be default Off for privacy, but the user could select to have every page automatically clipped on page load.
The one potential complication (which I've experienced with Hunchly) is for pages with dynamic content that doesn't change the URL. So for example, if I'm looking at the X/Twitter homepage feed, it can be tricky to tell the plugin how to add/overwrite the clip when the content changes but the URL doesn't. I think the feature would be useful even if this were too challenging to solve.
Current workaround (optional)
I am currently evaluating Hunchly as a workaround.
I am also looking into ways I can configure Chrome to "script" Obsidian Web Clipper.
Related feature requests (optional)
Now that the Web Clipper has Interpreter, this would be a very powerful "automatic note-taking" workflow. Basically, I just browse and trust that the clipper & interpreter are taking notes for me.

I don't think we should add this option for many reasons. It would require some additional permissions that I don't think are necessary. But also I don't think any changes to Web Clipper are necessary in order for you to achieve this. What you need to do is automate triggering the "Quick clip" action.
Keep in mind that doing this will be a slow and expensive way to browse. It's probably better to build a more dedicated extension for this purpose.

ok, thanks for reviewing.
> "What you need to do is automate triggering the "Quick clip" action."
any tips on how to accomplish this in chrome?

I am also interested in this functionality. It looks like the plugin is using the browser command and messages API to send the "Quick clip" action to the correct place in the plugin.
I am very new to plugins, so it is possible I have misunderstood this, but the onMessage listener only listens for messages coming from the same extension. One potential solution would be to add a few lines of code with the onMessageExternal, which would do the same thing as the onMessage, but open up the message API so actions could be triggered by another extension.
Currently the quick clip is triggered by a keyboard shortcut, making use of the command API that allows plugins to bind a function to a keyboard shortcut. I have spent most of the day looking for a way to automate this, but I could not find anything. Injected user scripts are sandboxed, so no code based injection will properly trigger. There are also basically no tools for triggering a keyboard shortcut automatically.
@kepano, it is possible I have misunderstood this, as I am a brand new developer. I am willing to try to PR changes, but this is my first attempt at contributing to open source, so I may need a little guidance.


try without heroku?

because I have no experience with heroku.
can I try the example on local machine?

initialize your app ``` ./setup-heroku.sh ``

sure, make sure to adjust your database settings and then run python manage.py after_deploy

Thanks

Hi, I am trying to setup Stream-Example-Py on my local machine. This is the first time I am working on a Django application, so I don't have much knowledge about what configurations to do. I am following the instructions given in -
https://github.com/GetStream/Stream-Example-Py/blob/master/install
I have installed rest of the dependencies but I am unable to find ./setup-heroku.sh in the project repository. Where is it located ? Secondly, don't I need to install redis or casandra or memcache on my local machine and give the configurations in django setttings.py to make the application work ?

@anunayasri doc referred to an old script, you should use this to prepare your app
python manage.py after_deploy

Do you have a new setup guide for the app ? What about database configurations ?
When I ran python manage.py after_deploy, I got the following error
Traceback (most recent call last):
  File "manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/usr/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 453, in execute_from_command_line
    utility.execute()
  File "/usr/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 392, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 272, in fetch_command
    klass = load_command_class(app_name, subcommand)
  File "/usr/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 77, in load_command_class
    module = import_module('%s.management.commands.%s' % (app_name, name))
  File "/usr/local/lib/python2.7/site-packages/django/utils/importlib.py", line 35, in import_module
    __import__(name)
  File "/home/anunaya/shopo/Stream-Framework/Stream-Example-Py/core/management/commands/after_deploy.py", line 3, in <module>
    from django.contrib.auth import get_user_model
  File "/usr/local/lib/python2.7/site-packages/django/contrib/auth/__init__.py", line 5, in <module>
    from django.middleware.csrf import rotate_token
  File "/usr/local/lib/python2.7/site-packages/django/middleware/csrf.py", line 16, in <module>
    from django.utils.cache import patch_vary_headers
  File "/usr/local/lib/python2.7/site-packages/django/utils/cache.py", line 26, in <module>
    from django.core.cache import get_cache
  File "/usr/local/lib/python2.7/site-packages/django/core/cache/__init__.py", line 143, in <module>
    cache = get_cache(DEFAULT_CACHE_ALIAS)
  File "/usr/local/lib/python2.7/site-packages/django/core/cache/__init__.py", line 130, in get_cache
    mod = importlib.import_module(mod_path)
  File "/usr/local/lib/python2.7/site-packages/django/utils/importlib.py", line 35, in import_module
    __import__(name)
  File "/usr/local/lib/python2.7/site-packages/django_pylibmc/memcached.py", line 25, in <module>
    raise InvalidCacheBackendError('Could not import pylibmc.')
django.core.cache.backends.base.InvalidCacheBackendError: Could not import pylibmc.

did you run pip install -r requirements.txt? the errors is about a missing dependency

Yes. It runs without any errors and says that the requirements are already satisfied.
The error was because my system library path was not correct. Its resolved now. But, as I feared, I am getting errors for database configuration. Here is the traceback:
Traceback (most recent call last):
  File "manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/usr/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 453, in execute_from_command_line
    utility.execute()
  File "/usr/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 392, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 272, in fetch_command
    klass = load_command_class(app_name, subcommand)
  File "/usr/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 77, in load_command_class
    module = import_module('%s.management.commands.%s' % (app_name, name))
  File "/usr/local/lib/python2.7/site-packages/django/utils/importlib.py", line 35, in import_module
    __import__(name)
  File "/usr/local/lib/python2.7/site-packages/south/management/commands/__init__.py", line 13, in <module>
    from south.management.commands.syncdb import Command as SyncCommand
  File "/usr/local/lib/python2.7/site-packages/south/management/commands/syncdb.py", line 19, in <module>
    from south.db import dbs
  File "/usr/local/lib/python2.7/site-packages/south/db/__init__.py", line 84, in <module>
    db = dbs[DEFAULT_DB_ALIAS]
KeyError: 'default'

I updated the install.md file and it should be clear what to change now.


Adding support for Vulkan Functions to be loaded by user

After posting this issue: https://github.com/bombomby/optick/issues/108 I figured I'd dig in and at least see what would be needed to support vulkan meta-loaders. This is the solution I've whipped up so far. I've tested this in a personal engine and it seems to work great.

Looks like some checks failed. I will work on that :)

Code has changed a bit since I first opened the review. Glad I managed to fix the builds in CI. Though I'm not so happy about requiring vulkan.h to be included before optick.h. I don't like adding an include order dependency to anything but I can't think of a better way to be able to get access to the Vulkan function pointers. I would forward declare them but I don't think I can forward declare functions with unknown types (VkResult for example). Hopefully this is still okay.

Hi Arsen, thanks for the pull request.

Though I'm not so happy about requiring vulkan.h to be included before optick.h. I don't like adding an include order dependency to anything but I can't think of a better way to be able to get access to the Vulkan function pointers. I would forward declare them but I don't think I can forward declare functions with unknown types (VkResult for example).

You should be able to replace VkResult with int32_t in forward declarations. Including vulkan.h from optick.h is a really bad idea as it will have a noticeable impact on the compilation time for big projects. I can see that you've already tried this approach in https://github.com/bombomby/optick/pull/109/commits/ef25e91739a6d0731f840b7204dd2feb863ae707. What was the problem with this approach?

Thanks for the feedback! My preliminary efforts to forward declare the function pointers were thwarted by not being able to replace certain enums with compatible types. Turns out you can forward declare enums in C++ with enum VkResult; or if you want you can supply a specific size/backing type with enum VkResult : int32_t; TIL!
I'm much happier with this PR with that resolved :)

Well it looks like enum VkResult; only works on MSVC and enum VkResult : int32_t will only work if the later declaration of VkResult ALSO uses the same explicit backing type. What a pain. The current solution works but does mean that including optick.h before vulkan.h will cause a problem

The only way to avoid this would be to avoid trying to forward declare the enums and instead require users to cast their function pointers to the "forward declared" versions

So, with forward declared enums off the table as an option. What would be your preferred solution to this?

The current manual enums that force an include order dependency
Replacing enums with int types and requiring users to manually cast function pointers
Something else that I'm missing?

So, with forward declared enums off the table as an option. What would be your preferred solution to this?
I would go for option 2 for now: Replacing enums with int types and requiring users to manually cast function pointers.
optick.h is usually included in many headers, so keeping it small and with minimum dependencies is the key.


Please tell me about the permissive license.

MIT License OR Apache License 2.0?

Thank you for your inquiry. Our project is licensed under the MIT License, and we have included the details of the LICENSE in the readme.txt file.


Files and images as block attachments

It's looking more obvious that blocks can be their own mini-applications: they're a contact form, an image gallery, a listing, a map, etc. They stand more and more on their own, just like a separate content type.
So just like a content type has individual file fields, I argue that the blocks should be able to "embed" their own files. I've been exploring this concept and have a WIP implementation where file and images are stored (as blobs, of course) in the annotation of the context and they can be referenced by the block.
I'm wondering what are the feelings of the Volto community towards this

@tiberiuichim I fully agree with your opinion here. Blocks are the core building blocks of Volto and we will have put some effort into getting this right. Somehow I have the feeling that we are re-inventing something new on top of the existing layers we have and we are solving the same problems over and over again. So I am +1 discussing this but it won't be an easy one.

@tisto I still see a lot of value in regular Plone content types, to stay as they are now. They have workflow + security, indexing, publishing (their own URLs), etc. So from my perspective the Plone content types become containers for the block mini-applications. To have the Volto blocks exposed as Plone content items wouldn't make sense (IMHO).
To a certain degree, how blocks are stored in the backend is not that important. But a page composition solution such as https://github.com/collective/collective.frontpage feels "ugly": a lot of special content is created, just to fit the limitations of the Plone platform.

@tiberiuichim this discussion is also about the issue that you showed us during the sprint?
Right now, with folderish contents when we are in creation form and add an image block with a new uploaded image, that image is created in its container (because you haven't created it yet).
But when you edit it and add a new image block, the new image is created inside it.
This can be confusing for editors because they have two images loaded in two different places.
With your proposal this could be fixed, but we should still allow users to reference an already created Image content in the portal

@cekk It would be another approach to solve that image creation issue.
But it's also about harmonization of concepts inside Volto: with blocks we're unshackling the content from the bounds imposed by the content types. If I can create any block in a content and it wouldn't appear anywhere else in the portal, why can't I add a file attachment to that content?

probably we should give both options.
Right now in plone you can:

upload an image directly in the content-type (with the leadimage behavior field for example)
reference one Image content in TinyMCE field

The first case could be still managed adding image fields to the content types when needed.
Blocks are used more or less to replace the rich text field (with blocks we are building the body of the page), so for me it's not a common use-case the reuse of images for editors. But there should also be the use-case where for a page they need a one-shot image and they don't want to upload it in a common folder or inside that content, but it's ok to store it into the block.


Fix an issue in reproducibility in some cases

Hi there!
When user does evaluation within the same runtime, the results do not remain the same. That was beacause the details
were saved in the class attributes of DetailsLogger and MetricsLogger.

Hi ! Can you fix the style tests on this so that we can merge ? :)

@NathanHB, May I close it? As it's obsolete now.

Hi Sadra! Yep, closing it now :)


Serialize once per format to increase perf in broadcasting scenarios

Also found an issue where we registered KeepAliveTick too soon and fixed it.

Before:
127k - Json
145k - MsgPack
After:
170k - Json
425k - MsgPack

Changed the backpressure on the pipes and JSON jumped to ~250k now. We'll have to talk about actual default values, not for this PR though.

:up: 📅


Make InstructionScheduleMap params ParameterExpressions

Summary
Changes InstructionScheduleMap schedule generator params to be ParameterExpressions rather than numbers. Fixes #3923.

Just a note, most of the import changes happened automatically (as a result of make style or make lint I think).

@menehune23 Thanks for the update. This is really great and I've been waiting this for long time.

How do we bind actual parameters to the ParameterExpression?, i.e. synchronization with circuit parameter.

Pulse scheduler always pass *args. This cannot generate **kwargs due to its implementation.
https://github.com/Qiskit/qiskit-terra/blob/43c649018124de507d876cf3bfedc02abacbcce8/qiskit/scheduler/lowering.py#L87-L88
Is it possible to create an entry of direct X gate as shown in this paper?
https://arxiv.org/abs/2004.11205
We may want to add rx to basis gates:
https://github.com/Qiskit/qiskit-terra/blob/master/qiskit/circuit/library/standard_gates/rx.py#L23
Then scheduler pass theta to the instmap and it convert theta to amp of Gaussian. In this case theta may be also ParameterExpression with a bound float value.

parameter ordering issue.

In ParameterizedSchedule the order of parameters is force sorted by key and thus function signature of generator is not remained.
https://github.com/Qiskit/qiskit-terra/blob/43c649018124de507d876cf3bfedc02abacbcce8/qiskit/pulse/schedule.py#L776

Were we going to cast a ParameterExpression to a float in the ParameterizedSchedule if supplied?

@taalexander Per the discussion in #3923, my understanding was that for this issue, we'd cast to float just before passing to any callable schedule (i.e. functions and ParameterizedSchedules). Let me know if that's not what you had in mind.
I know that eventually, the ParameterizedSchedule will be replaced with a proper implementation that can take in ParameterExpressions directly (#3384). It was at that later time that I was planning to adjust the casting logic in the InstructionScheduleMap to only cast for functions, but leave them uncast (remaining as ParameterExpressions) for the new schedule type.

@nkanazawa1989

How do we bind actual parameters to the ParameterExpression?, i.e. synchronization with circuit parameter.
If you take a look at the test changes, you'll see how to bind a value to a ParameterExpression. Let me know if I understood your question correctly.

In ParameterizedSchedule the order of parameters is force sorted by key and thus function signature of generator is not remained.

This feels like a separate bug that should be filed, if I understand correctly.

In your test case the parameter is bound before set to the generator function (this is the PR to add parameter object to schedule, so basically this test case is already enough). However we want to keep them as unbound parameter objects and bind a value before sending the program to the backend. Perhaps we can use parametric pulses because they can keep argument as parameters.
https://github.com/Qiskit/qiskit-terra/blob/04f20797eaa1a460e405adb8333508cd73bc448b/qiskit/pulse/library/parametric_pulses.py#L148-L149

I understand the problem, and I agree that it seems like a bug. That said, it looks like a pre-existing bug that should be filed separately.

This is not a bug, it's intentional. In the textualized CmdDef of U3 gate there are three parameters P1 P2 P3 associated with the shift phase instructions. However the order of instruction is not [P1, P2, P3] and we need to sort this to match with U3 gate definition to convert the gate into schedule without using **kwargs. We need to modify circuit parameter framework or write smart parser of CmdDef to address this.

@nkanazawa1989 My apologies. I misunderstood where the binding was expected to happen. I'll look into this further when I have some time outside of work.

@taalexander @nkanazawa1989 I'm realizing too that my original thoughts around this issue were based on replacing the param type with ParameterExpressions. Since we're actually just adding it as an additional type (adding to the Union type), I need to step backwards and rethink some of my original ideas. It is beginning to make more sense now though.

@taalexander @nkanazawa1989 Now that I've had a chance to revisit this with better understanding, please take another fresh look. I summarized the changes in the release note, so please let me know if my understanding of when binds should occur is correct. Thanks!

Please note: all checks pass, but it looks like a couple just failed to report back, so they show up yellow.


Fix typo

Coverage remained the same at 71.011% when pulling 70f4901ad8a018dbe1f36ffcc590ea069b2590b1 on yeojin-dev:fix-typo into 9bce928111b9bbc82d732a59f7243cdde8d59392 on django-extensions:master.

Thanks !


Replace samalba/dockerclient with docker/engine-api

@dgageot Linting got you :smile: var imageId should be imageID

Nice!
Some minor feedback but LGTM whenever you fix the lint issue.

I'm going to close this PR. I fear that  the code is getting more and more complex each time we change our way of connecting to the Docker daemon: Docker command through ssh, then DockerClient, then Engine-api.
I'm going to try simplify the code first and then we'll see


"Păunești","Viișoara" are listed in the drop-down menu

Description:
"Păunești","Viișoara" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Preconditions : the website (https://peviitor-ro.github.io/ui.orase/) is up and running. After every step delete the text you typed from the search bar.

Step 1
Write in the search bar "Păunești"

Expected results
The location appears in the drop-down menu as "Sat Păunești,  VRANCEA (Păunești)"

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

*Step 13
Write in the search bar "Viișoara"

Expected results
The location appears in the drop-down menu as "Sat Viișoara,  VRANCEA (Păunești)"


zli images should not return signatures but rather indicate if signed

Mostly done in https://github.com/project-zot/zot/commit/7f9052972d7adb4daf840722a81663b9be4102e5.
There are some remaining issues, tracked in #905 and #930


Allow more key combination with event.code instead?

Numpad0-9, arrow keys and navigation keys should be allowed for more keyboard shortcuts with event.code.

That's a very good point - I didn't realize that event.code is more expressive and that event.key does not differentiate between numpad and regular numbers. I'd be happy to make a change to support this.


Merge from master into linux

Two commits in this PR-

The merge commit
A commit that re-enables TTD after the merge (936b724)

In the merge commit, conflicts fixed in following files:
        bin/ch/ChakraRtInterface.h
        bin/ch/WScriptJsrt.cpp
        bin/ch/ch.cpp
        lib/Common/DataStructures/BaseDictionary.h
        lib/Jsrt/ChakraCommon.h
        lib/Jsrt/ChakraDebug.h
        lib/Jsrt/Jsrt.cpp
        lib/Runtime/Base/ScriptContext.cpp
        lib/Runtime/Types/NullTypeHandler.h

Commented one of the methods with char16/wchar_t argument. We shouldn't expose any wchar Jsrt method to xplat.

BTW;  @digitalinfinity I just realized that some of the comments I'm adding not much to do with your changes but the ones merging from master. Looks like we will be dealing with them separately ?

:shipit:

@obastemur Thanks for the review! Updated the PR (i'll rebase the last two commits before merging, kept them separate for ease of review).
You are correct, I'm not verifying the stability/performance of the TTD API in this PR- @mrkmarron and I can deal with that separately in a subs. I'm not fixing the comments around TTD code that you made- most of them are in win32 specific code or in functions which have a todo for xplat. We can deal with them in a separate commit, but useful feedback nonetheless.


Update scalajs-react-virtuoso to 0.1.0

Updates io.github.toddburnside:scalajs-react-virtuoso from 0.0.3 to 0.1.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.github.toddburnside", artifactId = "scalajs-react-virtuoso" } ]

labels: library-update, semver-minor

This is the scalajs-react upgrade to version 2. It requires a new version of scalablytyped and some additional changes.


Open API for other apps to use

Theres no way for other apps, like kometa, to access information from maintainerr at the moment afaik. Because theres no API for them to call.
Id like that to be added, so kometa can get information from maintainerr on whats about to be deleted, and how many days its left until that happens on every specific item that is marked for deletion.
That way they/we can create overlays on the items in plex that shows how many days until that specific item is deleted. Very much the same as maintainerr has it in their built-in collection in the maintainerr Web-UI.
And my guess is that other apps can benefit from this API as well, tho granted, i have no such ideas at the moment except Kometa overlay.
Screenshots
Something like this is what i want Kometa to be able to add as overlay (with the numbers) showing days until deletion.

Device (please complete the following information):

OS: Docker
Version 2.0.4 (maintainerr)

The API is actually open, but undocumented, at the moment. You could access and use it if you really wanted to.
However, once there is proper authentication, this API endpoint will become protected with the API token currently already available in settings.

I would also like this feature. In the meantime Kometa only shows a banner telling the movie/show is on it's way out.
You can easily do this by filtering on the collection the movies/shows are in.
overlays:
  last_chance:
    overlay:
      name: Last-Chance
      file: /config/assets/last_chance.png
      vertical_align: top
      horizontal_align: right
      vertical_offset: 0
      horizontal_offset: 0
    suppress_overlays:
      - runtime
    plex_search:
      all:
        collections:
          - Sista chansen

But it would be great if it actually showed how many days are left.

I would also like this feature. In the meantime Kometa only shows a banner telling the movie/show is on it's way out.
You can easily do this by filtering on the collection the movies/shows are in.
overlays:
  last_chance:
    overlay:
      name: Last-Chance
      file: /config/assets/last_chance.png
      vertical_align: top
      horizontal_align: right
      vertical_offset: 0
      horizontal_offset: 0
    suppress_overlays:
      - runtime
    plex_search:
      all:
        collections:
          - Sista chansen

But it would be great if it actually showed how many days are left.

Thanks for the overlay suggestion. Didn’t know that. I guess you’ve done the last_chance.png yourself?

Yeah, I just placed the file in /config/assets/

Yeah, I just placed the file in /config/assets/

Yeah, I just need to learn how to be creative and make an overlay first. :)
But I’ll get there eventually! Thanks once again for the temporary solution!

I used photoshop to edit the default "ribbon" overlay.
Ribbon overlays
It's not that hard, and photoshop is not required. You can probably find a free image editor online.


Localization for string values

Is it possible to support multi-language?
For example, native Android provides strings-xx.xml file inside value...  and all values defined in this file are used for localization.
In other words, we can get different texts according to language preference by using just one id.
This is valid in iOS even if the method is different.
Is it possible such usage in SLib? If not, this is elementary requirement, I think.

It is already supported.


[RELENG-5260] readhat-licences-leaks

Codecov Report

Merging #83 (4e6ded6) into main (94f8790) will decrease coverage by 1.27%.
The diff coverage is 13.33%.

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   73.55%   72.27%   -1.28%
==========================================
  Files          12       12
  Lines         692      707      +15
==========================================
+ Hits          509      511       +2
- Misses        183      196      +13

Impacted Files
Coverage Δ

srcs/runners_manager/vm_creation/openstack.py
27.77% <13.33%> (-2.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94f8790...4e6ded6. Read the comment docs.


gopass show -c process never stops

Summary
I tried running the command described in setup.md: gopass ls --flat | dmenu | xargs --no-run-if-empty gopass show -c. This apparently launches two gopass commands which run forever.
Steps To Reproduce

Execute gopass ls --flat | dmenu | xargs --no-run-if-empty gopass show -c
It will show a message that the clipboard will be cleared after 45 seconds. But after 45 seconds the process keeps running and I have to manually kill it with Ctrl-C.
Check with ps ax | grep gopass that there are still two gopass processes running: gopass show -c <pass> and gopass unclip --timeout 45

Expected behavior
45 seconds after the command has been executed all gopass processes should stop.
Environment

OS: Gentoo Linux
OS version: Linux gentoo-y700 5.10.1-gentoo
gopass Version: gopass 1.10.1 (2020-12-16 05:10:34) go1.15.5 linux amd64
Installation method: app-admin/gopass ebuild

What happens if you run gopass show -c nameofanentry  ?
Does it also keep running ?

The command starts and keeps running forever. However, there is no message about 45 seconds.

@fm2mwvtsp8vqtuy5 Thanks for the detailed explanation. Unfortunately I was able to reproduce. At least on my system (Linux) killPrecedessors does seem to take care of any lingering processes.
But you are right that we're not using Process.Kill according to documentation, so we'll fix that :+1:

@dominikschulz: I'm glad I could help you and I'm happy to see that you fixed it so quick.


Control inside viewport steals focus of other control elements outside of the viewport

Godot version: 3.0.2

OS/device including version: Arch Linux, x64

Issue description:
Control nodes overlapping a ViewportContainer don't receive input if there is a Control Node inside the Viewport also convering the area in question.
Example:

This is the SceneTree for an application that has a "Top Bar" with menu items. The rest of the screen is occupied with a ViewportContainer, which shows a nice spatial world. That Viewport also contains a Control node which occupies the whole size of the Viewport that is supposed to catch some events.
Now if the menu buttons are activated, the menu items will overlap with the Viewport, but the menu items can't actually be clicked.

Steps to reproduce:

Add some UI, possibly popups.
Create a ViewportContainer so that the popups will overlap with it.
Fill ViewportContainer with a Viewport that contains a  large Control node that will occupy the overlapping space of the popups.
Try to click popus.

(see example project)
Minimal reproduction project:

viewport-control-bug.zip

Resolved in 4.0-dev.


HOC: exercise generator

[ ] #75
[ ] word / letter / syllable generator according to current course progression

@inyono Isn't this done already?

yep


IndexError: too many indices for array & out of range

When I run python main --batch-size 256 --model-name quasart_reader --num-epochs 10 --dataset quasart --mode reader, I got:
08/20/2018 01:34:57 PM: [ 16 ]
08/20/2018 01:34:57 PM: [ 16 ]
08/20/2018 01:34:57 PM: [ 16 ]
08/20/2018 01:34:57 PM: [ [(1, 1), (9, 9)] ]
Traceback (most recent call last):
File "\src\reader\model.py", line 253, in update
if (tmp1.data.cpu().numpy()[0]<(score_s[i][target_s[i][j][0]]*score_e[i][target_s[i][j][1]]).data.cpu().numpy()[0]):
IndexError: too many indices for array
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "main.py", line 820, in
main(args)
File "main.py", line 744, in main
pretrain_reader(args, train_loader_with_doc, model, stats, train_exs_with_doc, train_docs)
File "main.py", line 376, in pretrain_reader
train_loss.update(*model.update(ex_with_doc[idx_doc], l_list, r_list, HasAnswer_list[idx_doc]))
File "\src\reader\model.py", line 264, in update
logger.info(target_e[i])
IndexError: list index out of range

Thanks a lot ! In addition, for stanford nlp is not supported, if I use spacy as tokenizer, how about the result?

I did not try spacy yet, and I think the result will be comparable with spacy. And if you want to use stanford nlp, you may try the install script (https://github.com/facebookresearch/DrQA/blob/master/install_corenlp.sh) provided by Danqi Chen.


Use latest kyaml and cmd/config

Updates to the latest versions on master of kyaml and cmd/config.

/lgtm
/approve
not sure why all the red; we'll see.


Export and load didn't work for some models

I am trying to maintain a installed models folder by using the following download_model function, then use bioimageio.core.load_resource_description(model_path) to load the function, but it failed for this model: "10.5281/zenodo.5911832", it failed at loading the pytorch weights file. But if I pass the model id directly, it works.
def downlod_model(model_id):
    out_folder = os.path.join(MODEL_DIR, model_id)
    out_path = os.path.join(out_folder, "model.zip")
    if os.path.exists(out_path):
        return out_path
    os.makedirs(out_folder, exist_ok=True)
    bioimageio.core.export_resource_package(model_id, output_path=out_path)
    return model_id

Not sure if it's related, if I unzip the downloaded model zip, the rdf.yaml file seems to be corrupted.

I can't reproduce this. Here's the full script I tried this with:
import os
import bioimageio.core

MODEL_DIR = "./tmp"
os.makedirs(MODEL_DIR, exist_ok=True)

def downlod_model(model_id):
    out_folder = os.path.join(MODEL_DIR, model_id)
    out_path = os.path.join(out_folder, "model.zip")
    if os.path.exists(out_path):
        return out_path
    os.makedirs(out_folder, exist_ok=True)
    bioimageio.core.export_resource_package(model_id, output_path=out_path)
    return out_path

p = downlod_model("10.5281/zenodo.5911832")
x = bioimageio.core.load_resource_description(p)
print(x)

And it works after running it several times. Also note that I changed the returnvalue to always give back out_path.
Can you try removing the zip and running it again? Maybe something just went wrong in the download...
If the issue persists, please post the version of bioimageio.spec and bioimageio.core.

I tried several times, the zip file is ok. And loading is ok too as you seen in the script, but did not work for that particular model (with the prediction using the prediction pipeline).
Can you try to run prediction with bioimage.core? The error occurred inside a docker container, so I didn't get much more details about it.
For the versions, it should be the latest since I built the container on Friday.

Prediction works for me without any problems too:
import os
import bioimageio.core
import numpy as np
from xarray import DataArray

MODEL_DIR = "./tmp"
os.makedirs(MODEL_DIR, exist_ok=True)

def downlod_model(model_id):
    out_folder = os.path.join(MODEL_DIR, model_id)
    out_path = os.path.join(out_folder, "model.zip")
    if os.path.exists(out_path):
        return out_path
    os.makedirs(out_folder, exist_ok=True)
    bioimageio.core.export_resource_package(model_id, output_path=out_path)
    return out_path

p = downlod_model("10.5281/zenodo.5911832")
model = bioimageio.core.load_resource_description(p)

test_data = np.load(model.test_inputs[0])
test_input = DataArray(test_data, dims=tuple(model.inputs[0].axes))
with bioimageio.core.create_prediction_pipeline(model) as pp:
    prediction = pp(test_input)[0]
print(prediction.shape)

Okay, good to know, thanks for testing it!
I will need more investigation then, I also had some other issue within the docker container I made. I will get back when I had more time with it.
For now I am skipping downloading the zip but using a persistent cache folder.
BTW is there any performance drop if we load it from a zip compared to the cache folder, would it unzip it before loading the models?

Hey, could you check also if the rdf.yaml file is ok after unzipping? It appears to be corrupted for me.

Hey, could you check also if the rdf.yaml file is ok after unzipping? It appears to be corrupted for me.

I can unzip it without any issues.

This happens to me again and made a summary in another issue: https://github.com/bioimage-io/core-bioimage-io-python/issues/270
For some reason, a weights file get corrupted and get cached, and I didn't set BIOIMAGEIO_USE_CACHE=no before importing bioimageio.core (I did after importing).


Incompatible with Netmiko >=4.0.0

As Netmiko 4.0.0 Release has the following:

Relocate exceptions module to netmiko.exceptions (was ssh_exceptions)

cumulus.py will fail to load.
To enable compatibility, the reference needs to be changed in cumulus.py, line 38:
from netmiko.ssh_exception import NetMikoTimeoutException
to
from netmiko.exceptions import NetMikoTimeoutException

Here is a simple fix to support both.
--- a/napalm_cumulus/cumulus.py
+++ b/napalm_cumulus/cumulus.py
@@ -35,7 +35,10 @@ from napalm.base.exceptions import (
)
from napalm.base.utils import string_parsers
from netmiko import ConnectHandler
-from netmiko.ssh_exception import NetMikoTimeoutException
+try:

from netmiko.ssh_exception import NetMikoTimeoutException
+except ModuleNotFoundError:
from netmiko.exceptions import NetMikoTimeoutException
from pytz import timezone

Hi, thank you for the tip @justinbrink .
Did not consider at all to use try-except clauses in the imports themselves.


[ANCHOR-193] Fix the bug where the result of deposit information not saved in database in SEP31

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What

ANCHOR-193 Fix the bug where the result of deposit information not saved in database in SEP31
Added IntelliJ Run Configurations for debugging version 1.2

Why
Bug fix.
Known limitations
N/A

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr788.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr788.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr788.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr788.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr788.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr788.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr788.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr788.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr788.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr788.previews.kube001.services.stellar-ops.com/


Add weekly updates for 2015-08-28

https://github.com/nodejs/evangelism/pull/142/files

원문 링크입니다.
https://medium.com/node-js-javascript/io-js-and-node-js-week-of-august-28th-129b6b2f1be6

@nodejs/iojs-ko 리뷰 부탁드립니다.
https://github.com/nodejs/iojs-ko/pull/110

Closed via #128.


Could not generate User Model code

Hello , friends !
I have a flutter 2.0.6 release
The null safty is supported
I created a file user.json in the assets/models directory
And I wrote the following code in the file:
{
   "name": "",
   "age": 0,
   "friends": ["",""]
}

And I ran the command below:
get generate model on home with assets/models/user.json
This error appeared to me, and I do not know what is the solution?
✖  + error_unexpected Could not format because the source could not be parsed:

line 4, column 3 of .: Variables must be declared using the keywords 'const', 'final', 'var' or a type name.
  ╷
4 │      List?<String> friends;
  │      ^^^^
  ╵
line 4, column 3 of .: Expected to find ';'.
  ╷
4 │      List?<String> friends;
  │      ^^^^
  ╵
line 4, column 17 of .: A function body must be provided.
  ╷
4 │      List?<String> friends;
  │                    ^^^^^^^
  ╵
line 4, column 17 of .: Variables must be declared using the keywords 'const', 'final', 'var' or a type name.
  ╷
4 │      List?<String> friends;
  │                    ^^^^^^^
  ╵
line 4, column 7 of .: The string '?' isn't a user-definable operator.
  ╷
4 │      List?<String> friends;
  │          ^
  ╵
line 4, column 7 of .: Methods must have an explicit list of parameters.
  ╷
4 │      List?<String> friends;
  │          ^
  ╵
line 4, column 7 of .: Operator declarations must be preceded by the keyword 'operator'.
  ╷
4 │      List?<String> friends;
  │          ^
  ╵
line 4, column 8 of .: Types parameters aren't allowed when defining an operator.
  ╷
4 │      List?<String> friends;
  │           ^^^^^^^^
  ╵

Time: 517 Milliseconds

'pub' is not recognized as an internal or external command,
operable program or batch file.

I have the same issue.

same issue here @jonataslaw . Do you have any idea what could it be?

It's a easy fix, but I'm very busy this week.
Just insert the "?" If there is no subtype, and if there is, insert it at the end of the subtype, so we have List? instead of List?
this here the code:
https://github.com/jonataslaw/get_cli/blob/master/lib/common/utils/json_serialize/sintaxe.dart#L76-L80

@jonataslaw
This problem that happened to me is due to the basic generation of the code in the package get_cli
I did not write this list, just applied the example that was mentioned on the Read Me page

@jonataslaw
this should be closed now


toast should include an overlayIndex according to the documentation

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ ] 3.x
[ ] 4.x
[x] 5.0.0-beta.15
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request

Current behavior:
overlayIndex isn't included in the ToastOptions interface but is called out in the documentation: https://beta.ionicframework.com/docs/api/toast/
Expected behavior:
The overlay index would be accepted and respected
Steps to reproduce:
Attempt to create a toast item with an index:
this.toastCtrl.create({
message: 'test.',
duration: 3000,
position: 'top',
overlayIndex: '1000'
})
Other information:
I only had to look up this property as the toast is no longer on top of modal windows. If the previous behaviour returns so toasts are displayed on top of modals, this isn't needed.

I don't think that's implemented, that's probably the reason why it is hidden from creation options. Current details:
https://github.com/ionic-team/ionic/blob/bf486e2c99c74db7dcaa752d7d46446f9fbe5f11/core/src/utils/overlays.ts#L13-L14

Fixed: https://github.com/ionic-team/ionic/commit/ac42180f144130a33caa09df150751d387054322
overlayIndex is an internal property, it should not be handled manually


⚠ ClamAV has degraded performance

In 65b4b21, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 97 ms

Resolved: ClamAV performance has improved in 63886d0.


Is there a plan to release the nanbiled branch?

Dear Maintainers.
After https://github.com/meta-qt5/meta-qt5/commit/6e244970dcdb631613af80f37e00957de417449d commit, it appears that there is no branch with nanbield in LAYERSERIES_COMPAT_qt5-layer.
I would like to inquire whether the nanbiled branch is scheduled to be released.
Many thanks.

See https://github.com/meta-qt5/meta-qt5/pull/561

See #561

Dear @shr-project.
Thank you for the release of the nanbield branch.


Feature/enhance btp

Misc fixes for BTP implementation

Update to 0.14.0-SNAPSHOT
Added Codec for BTP Timestamps, which are slightly different from Interledger Timestamps.
Update BtpErrorCode to have code, name, and description.
Create new factory for BTP OER codec access
Improved Javadoc
Improved units test coverage

Codecov Report

Merging #178 into master will decrease coverage by 0.88%.
The diff coverage is 90.38%.

@@             Coverage Diff              @@
##             master     #178      +/-   ##
============================================
- Coverage     72.61%   71.73%   -0.89%
- Complexity      281      302      +21
============================================
  Files            77       91      +14
  Lines          1256     1369     +113
  Branches        131      131
============================================
+ Hits            912      982      +70
- Misses          287      330      +43
  Partials         57       57

Impacted Files
Coverage Δ
Complexity Δ

.../interledger/btp/asn/codecs/AsnBtpPacketCodec.java
62.5% <ø> (ø)
5 <0> (?)

...re/src/main/java/org/interledger/btp/BtpError.java
50% <ø> (+20%)
1 <0> (ø)
:arrow_down:

...src/main/java/org/interledger/btp/BtpTransfer.java
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

.../main/java/org/interledger/btp/BtpSubProtocol.java
28.57% <ø> (ø)
1 <0> (ø)
:arrow_down:

...org/interledger/btp/BtpSubProtocolContentType.java
100% <ø> (ø)
7 <0> (ø)
:arrow_down:

...src/main/java/org/interledger/btp/BtpResponse.java
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

.../java/org/interledger/btp/BtpRuntimeException.java
53.84% <ø> (-7.27%)
5 <0> (ø)

...interledger/core/asn/codecs/AsnTimestampCodec.java
80% <0%> (-4.22%)
3 <0> (ø)

...ger/btp/asn/codecs/AsnBtpGeneralizedTimeCodec.java
100% <100%> (ø)
3 <3> (?)

...terledger/btp/asn/codecs/AsnBtpErrorDataCodec.java
100% <100%> (ø)
3 <1> (?)

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31c3a6a...8162e6d. Read the comment docs.

Before merging, we should discuss https://github.com/interledger/rfcs/issues/480 and https://github.com/interledger/rfcs/issues/481.


manage_master_user_password=true on MSSQL Replica is not honored

Description
RDS for MS SQL Server allows for replicas to have their passwords managed in secrets manager.  The manage_master_user_password setting does not get applied correctly to the replica instance when it is set to true.

[ X ] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]: 6.1.1

Terraform version: 1.4.5

Provider version(s):
aws v5.14.0
random v3.5.1

Reproduction Code [Required]
terraform {
  required_version = ">= 1.0"

  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = ">= 5.00"
    }
  }
}

provider "aws" {
  region = local.region
}

data "aws_availability_zones" "available" {}

locals {
  name    = "complete-mssql"
  region  = "us-east-1"

  vpc_cidr = "<IP_ADDRESS>/16"
  azs      = slice(data.aws_availability_zones.available.names, 0, 3)

  tags = {
    Name       = local.name
    Example    = local.name
    Repository = "https://github.com/terraform-aws-modules/terraform-aws-rds"
  }
}

################################################################################
# RDS Module - db
################################################################################

module "db" {
  source = "terraform-aws-modules/rds/aws"

  identifier = local.name

  engine               = "sqlserver-ee"
  engine_version       = "15.00.4312.2.v1"
  family               = "sqlserver-ee-15.0" # DB parameter group
  major_engine_version = "15.00"             # DB option group
  instance_class       = "db.t3.xlarge"

  allocated_storage     = 20
  max_allocated_storage = 100

  # Encryption at rest is not available for DB instances running SQL Server Express Edition
  storage_encrypted = false

  username = "complete_mssql"
  port     = 1433

  manage_master_user_password = true

  multi_az               = true
  db_subnet_group_name   = module.vpc.database_subnet_group
  vpc_security_group_ids = [module.security_group.security_group_id]

  maintenance_window              = "Mon:00:00-Mon:03:00"
  backup_window                   = "03:00-06:00"
  enabled_cloudwatch_logs_exports = ["error"]
  create_cloudwatch_log_group     = true

  backup_retention_period = 1
  skip_final_snapshot     = true
  deletion_protection     = false

  performance_insights_enabled          = true
  performance_insights_retention_period = 7
  create_monitoring_role                = true
  monitoring_role_use_name_prefix       = true
  monitoring_interval                   = 60

  options                   = []
  create_db_parameter_group = false
  license_model             = "license-included"
  timezone                  = "GMT Standard Time"
  character_set_name        = "Latin1_General_CI_AS"

  tags = local.tags
  timeouts = {
    create = "6h"
    delete = "6h"
    update = "6h"
  }
}

data "aws_iam_policy_document" "rds_assume_role" {
  statement {
    sid = "AssumeRole"

    actions = [
      "sts:AssumeRole",
    ]

    principals {
      type        = "Service"
      identifiers = ["rds.amazonaws.com"]
    }
  }
}

################################################################################
# Supporting Resources
################################################################################

module "vpc" {
  source  = "terraform-aws-modules/vpc/aws"
  version = "~> 5.0"

  name = local.name
  cidr = local.vpc_cidr

  azs              = local.azs
  public_subnets   = [for k, v in local.azs : cidrsubnet(local.vpc_cidr, 8, k)]
  private_subnets  = [for k, v in local.azs : cidrsubnet(local.vpc_cidr, 8, k + 3)]
  database_subnets = [for k, v in local.azs : cidrsubnet(local.vpc_cidr, 8, k + 6)]

  create_database_subnet_group = true

  tags = local.tags
}

module "security_group" {
  source  = "terraform-aws-modules/security-group/aws"
  version = "~> 5.0"

  name        = local.name
  description = "Complete SqlServer example security group"
  vpc_id      = module.vpc.vpc_id

  # ingress
  ingress_with_cidr_blocks = [
    {
      from_port   = 1433
      to_port     = 1433
      protocol    = "tcp"
      description = "SqlServer access from within VPC"
      cidr_blocks = module.vpc.vpc_cidr_block
    },
  ]

  tags = local.tags
}

################################################################################
# RDS Module - replica
################################################################################

module "replica" {
  source = "terraform-aws-modules/rds/aws"

  identifier = "${local.name}-replica"

  engine               = "sqlserver-ee"
  major_engine_version = "15.00"
  engine_version       = "15.00.4312.2.v1"
  family               = "sqlserver-ee-15.0"
  instance_class       = "db.r5d.xlarge"

  max_allocated_storage = 200

storage_encrypted = false
  replicate_source_db = module.db.db_instance_identifier

  port = 1433

  manage_master_user_password = true

  multi_az                        = false
  vpc_security_group_ids          = [module.security_group.security_group_id]
  maintenance_window              = "Mon:00:00-Mon:03:00"
  enabled_cloudwatch_logs_exports = ["error"]
  create_cloudwatch_log_group     = true

  backup_retention_period = 0
  skip_final_snapshot     = true
  deletion_protection     = false

  performance_insights_enabled          = true
  performance_insights_retention_period = 7
  create_monitoring_role                = true
  monitoring_role_use_name_prefix       = true
  monitoring_interval                   = 60
  create_db_option_group                = false
  create_db_parameter_group             = false
  license_model                         = "license-included"
  timezone                              = "GMT Standard Time"
  character_set_name                    = "Latin1_General_CI_AS"

  tags = local.tags

  timeouts = {
    create = "6h"
    delete = "6h"
    update = "6h"
  }
}

data "aws_db_instance" "db"{

  depends_on = [module.db]
  db_instance_identifier = module.db.db_instance_identifier
}

data "aws_db_instance" "replica"{

  depends_on = [module.replica]
  db_instance_identifier = module.replica.db_instance_identifier
}

output "db_secret_arn_is_null"{
  value = data.aws_db_instance.db.master_user_secret == null
}

output "replica_secret_arn_is_null"{
  value = data.aws_db_instance.replica.master_user_secret == null
}

Steps to reproduce the behavior:
Execute repro code.
Expected behavior
Master user password on replica instance managed in secrets manager.  Evidence would be that output replica_secret_arn_is_null would be false.
Actual behavior
Master user password on replica instance is set statically by random provider/not managed in secrets manager.  Evidence is that output replica_secret_arn_is_null is true.

I don't believe replica's honor this setting, only the writer instance (per the API)

I don't believe replica's honor this setting, only the writer instance (per the API)

Per https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/rds-secrets-manager.html MS SQL Server allows this.

This problem still exists.


test(rest:e2e): Increase timeout for send a direct message e2e test

Currently the "Send a Direct Message" E2E test fails due to the 30s timeout. This increases it to 60s hoping this is long enough to make it pass

Not sure how they are related but #3849 already fixed the timeout issue for the direct message e2e, so this pr is no longer needed
not sure how it was causing a timeout not an exception but I'm not going to ask