ASCIIGenome failing during analysis

Check Documentation
I have checked the following places for your error:

[X] nf-core website: troubleshooting
[X] nf-core/viralrecon pipeline documentation

Description of the bug
While running viralrecon using data from the SNAP/Swift protocol, the pipeline repeatedly crashed at the ASCIIGenome step:

If I skip the ASCIIGenome step (--skip_asciigenome), the pipeline finishes as expected. I was asked to create this issue by @drpatelh (https://nfcore.slack.com/archives/C0110R22NH3/p1623156803141900?thread_ts=1623119196.129800&cid=C0110R22NH3)
Steps to reproduce
Steps to reproduce the behaviour:

Command line: nextflow run nf-core/viralrecon --platform illumina --input samplesheet.csv  --genome 'NC_045512.2'  --protocol amplicon --primer_bed swift.bed --primer_left_suffix '_F' --primer_right_suffix '_R' --ivar_trim_offset 5 --skip_assembly -profile singularity --max_memory "50.0 GB"
See error:

Error executing process > 'NFCORE_VIRALRECON:ILLUMINA:VARIANTS_IVAR:ASCIIGENOME (sample1)'

Caused by:
  Process `NFCORE_VIRALRECON:ILLUMINA:VARIANTS_IVAR:ASCIIGENOME (sample1)` terminated with an error exit status (1)

Command executed:

  zcat sample1.vcf.gz \
      | grep -v '#' \
      | awk -v FS='	' -v OFS='	' '{print $1, ($2-50-1), ($2+50)}' \
      > variants.bed

  ASCIIGenome \
      -ni \
      -x "trackHeight 0 bam#1 && trackHeight 50 bam@2 && readsAsPairs -on && filterVariantReads && save sample1.%r.pdf" \
      --batchFile variants.bed \
      --fasta GCF_009858895.2_ASM985889v3_genomic.200409.fna \
      sample1.ivar_trim.sorted.bam \
      sample1.vcf.gz \
      swift.bed \
      GCF_009858895.2_ASM985889v3_genomic.200409.gff \
      > /dev/null

  echo $(ASCIIGenome -ni --version 2>&1) | sed -e "s/ASCIIGenome //g" > asciigenome.version.txt

Command exit status:
  1

Command output:
  (empty)

Command error:
  WARNING: Skipping mount /usr/local/var/singularity/mnt/session/etc/resolv.conf [files]: /etc/resolv.conf doesn't exist in container
  Cannot read history file '/home/default/.asciigenome.yaml'

  Indexing 'GCF_009858895.2_ASM985889v3_genomic.200409.fna'.
  Initializing coordinates... Done from: sample1.ivar_trim.sorted.bam
  Cannot read history file '/home/default/.asciigenome.yaml'
  Invalid coordinates: -36 64
  Exception in thread "main" exceptions.InvalidGenomicCoordsException
  	at tracks.IntervalFeature.validateIntervalFeature(IntervalFeature.java:231)
  	at tracks.IntervalFeature.intervalFeatureFromBedLine(IntervalFeature.java:183)
  	at tracks.IntervalFeature.<init>(IntervalFeature.java:70)
  	at samTextViewer.Main.main(Main.java:150)

Expected behaviour
ASCIIGenome to generate the correct output files, and for the pipeline to complete without error.
Log files
Have you provided the following extra information/files:

[X] The command used to run the pipeline
[X] The .nextflow.log file
nextflow.log

System

Hardware: Desktop
Executor: Just a simple nextflow run command
OS: pop!_os
Version  20.10

Nextflow Installation

Version: 21.04.1 build 5556

Container engine

Engine: Singularity
version: Unsure
Image tag: nf-core/viralrecon v2.0

Additional context
What's the best way to privately share some reads that might allow the issue to be replicated?

This should be fixed in https://github.com/nf-core/viralrecon/pull/202 @charlesfoster. I submitted a PR to cfreate a multi-tool container that contains ASCIIGenome and BEDTools. The interval size adjustment will now be chucked through bedtools slop as an additional step to santise the intervals and to make sure they don't cross chromosomal boundaries. Be great if you can test this when that PR is merged.
nextflow pull nf-core/viralrecon
nextflow run nf-core/viralrecon -r dev <YOUR_PARAMETERS>


endlessh-go: 20220710 -> 20220731

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Out of curiosity, what prompted you to remove proxyVendor? The dependencies didn't change in this release; was it ever needed in the first place?

There was no need for it. I guess I've initially added it by accident.


lit.dev playground / examples: until directive example doesn't work

Description
until directive example doesn't work.
Playground: (https://lit.dev/playground/#sample=examples/directive-until) ajax call fails (CORS error)
API address: https://api.mocki.io/v1/b551e5c3
Steps to Reproduce

Go to https://lit.dev/playground/#sample=examples/directive-until

Refresh the result box.

See the output in dev tools:
Access to fetch at 'https://api.mocki.io/v1/b551e5c3' from origin 'https://playground.lit.dev' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

Browsers Affected

[x] Chrome
[x] Firefox
[x] Edge

Thank you for the report! The example has been updated to use a different example api.


Fix: make template macro independent.

In my work on "highlighting closing tags" i have found that template! macro cannot be used dirrectly in examples (i tested in counter).
Few imports was missing, and some extern crates was needed to use template! instead of view!.
I have added feature gate and hide all needed imports behind it.
But if you want i can remove custom feature, reimport all crates in csr mode, and add fallback use macro::view as template in ssr or hydration mode.
I also have copied code from this benchmark to the examples, to keep template testable in future.
If you plan to remove template! or deprecate it in future, feel free to close this PR. But if you want to keep template!, i can add support of semantic highlighting to it (currently it is completely broken).

Thanks! This looks reasonable to me.
Yes, the semantic highlighting's completely messed up.
Re: future plans — I will definitely be keeping template around. It was actually the original view macro but replaced by the more flexible current version of the renderer. There's a small but meaningful performance benefit in some cases using template. Removing the SSR/hydration aspect of it made it much more manageable, but it could definitely use some love. One possibility for the future involves merging some of the template logic back into the view, but I don't have any immediate plans to do it.


Update pubspec.yaml

Upgrade js version to the latest version

Nice - please add an entry to the changelog and I'll get it merged in.

Completed in https://github.com/acoutts/flutter_libphonenumber/pull/69


I want to run it with a GROQ LLM; what and where to change code?

I want to run it with a GROQ LLM; what and where to change code?
Besides the python code I think also the prompts would probably be changed (src/goal_prompt.md).
Especially I would like to do experiments with the "Game of 24" example!
Must the LLM have the capability for tool use / function calling?
Which GROQ models could be used?
See:

I think this GROQ model is a good candidate:

Llama 3 Groq 70B Tool Use (Preview)
Model ID: llama3-groq-70b-8192-tool-use-preview
Developer: Groq
Context Window: 8,192 tokens
Model Card
Is the context window large enough (8192 tokens) ?
I hope you can answer these questions, because I really love the GROQ LLMs !

Thank you for your interest in our project! To modify the code for running it with a GROQ LLM, you'll primarily need to update the API calls to switch from OpenAI's API to the model of your choice. This should be the main adjustment needed (function calling isn't needed, but you may need to implement the execute part manually). We definitely appreciate contributions from the community to make the Gödel agent more versatile, so feel free to submit a pull request if you'd like to help us improve this functionality.
However, it's important to note that self-improvement requires a highly capable LLM, one that can understand its own code and suggest meaningful enhancements. While models like Llama might be able to perform certain tasks, they may not be powerful enough for this type of self-referential improvement. Additionally, a context window of 8192 tokens might not be sufficient for more complex tasks, though you could try reducing the length of history to better fit within this limit.
As for modifying the goal_prompt, it is indeed possible to allow the agent to change it. That said, preventing it from doing so is also straightforward if you have security concerns. So far, we haven't observed any behavior from the current LLM that suggests modifying the goal_prompt, but security remains a key focus for our future work. We welcome anyone interested in contributing to this area as well.
Regarding the "Game of 24" experiment, running it would simply require implementing task inputs and an evaluator. The same approach can be applied to any other task you wish to experiment with. However, due to our current workload, we haven't yet organized that portion of the code.

Thank you for your quick response!
I am very interested in this project, so I will certainly look into it. But it may take some time ...
I will keep you informed if I get results with GROQ LLMs!

I am going to try llama3-groq-tool-use:8b with Ollama. First create two alias chatgpt model:
c2j@Mars:~$ docker exec -it ollama ollama list
NAME                       ID              SIZE      MODIFIED
llama3-groq-tool-use:8b    36211dad2b15    4.7 GB    11 hours ago

c2j@Mars:~$ docker exec -it ollama ollama cp llama3-groq-tool-use:8b gpt-3.5-turbo
copied 'llama3-groq-tool-use:8b' to 'gpt-3.5-turbo'

c2j@Mars:~$ docker exec -it ollama ollama cp llama3-groq-tool-use:8b gpt-4o
copied 'llama3-groq-tool-use:8b' to 'gpt-4o'

c2j@Mars:~$ docker exec -it ollama ollama list
NAME                       ID              SIZE      MODIFIED
gpt-4o:latest              36211dad2b15    4.7 GB    3 seconds ago
gpt-3.5-turbo:latest       36211dad2b15    4.7 GB    About a minute ago
llama3-groq-tool-use:8b    36211dad2b15    4.7 GB    11 hours ago

Then run Gödel Agent
(ENV310_Agent) MacBook-Pro:src c2j$ OPENAI_API_KEY=WOKEY OPENAI_BASE_URL=http://<IP_ADDRESS>:11434/v1 python main.py

I am going to try llama3-groq-tool-use:8b with Ollama. First create two alias chatgpt model:
c2j@Mars:~$ docker exec -it ollama ollama list
NAME                       ID              SIZE      MODIFIED
llama3-groq-tool-use:8b    36211dad2b15    4.7 GB    11 hours ago

c2j@Mars:~$ docker exec -it ollama ollama cp llama3-groq-tool-use:8b gpt-3.5-turbo
copied 'llama3-groq-tool-use:8b' to 'gpt-3.5-turbo'

c2j@Mars:~$ docker exec -it ollama ollama cp llama3-groq-tool-use:8b gpt-4o
copied 'llama3-groq-tool-use:8b' to 'gpt-4o'

c2j@Mars:~$ docker exec -it ollama ollama list
NAME                       ID              SIZE      MODIFIED
gpt-4o:latest              36211dad2b15    4.7 GB    3 seconds ago
gpt-3.5-turbo:latest       36211dad2b15    4.7 GB    About a minute ago
llama3-groq-tool-use:8b    36211dad2b15    4.7 GB    11 hours ago

Then run Gödel Agent
(ENV310_Agent) MacBook-Pro:src c2j$ OPENAI_API_KEY=WOKEY OPENAI_BASE_URL=http://<IP_ADDRESS>:11434/v1 python main.py

Interesting! I am curious about your results. I hope it will not be all too slow though…
I hope I can find the time in the coming weeks to try it with the (very fast!) GROQ models. I hope I do not run into rate limit errors with that. In that case I will have to implement a effective back-off method for handling that.
The whole idea of a self referential Gödel Machine, that can do introspection, design new tools if the task asks for it, do “monkey patching” (modifying itself while running, “hot updating“), making a better version of itself, reprogramming itself, is an amazing concept for which there was no actual implementation yet. With this implementation we work towards an actual approximation of it!
It appears that it is sensitive dependent on the code it starts with as the paper mentions. But that should surprise us, given that the whole process is self-referential and thus will give rise chaotic and fractal behavior, which inherently has that property of sensitive dependence on initial conditions.
A interesting metaphor in this context:
A Gödel Machine resembles a surgeon who operates on himself!


Connecting to pusher.com instead of my instance

Hello @rennokki,
after initially having everything up and working, I've had to upgrade the dependencies to PHP7.4 and with this a new issue came up. While the websockets:serve is running, the site is now connecting to sockjs.pusher.com instead of my instance.
I guess it's an issue in the configuration, so I'll share the relevant parts below. If something else is required please let me know!
Configuration
env file:
BROADCAST_DRIVER=pusher

# ...

# Adjusted, but similar:
PUSHER_APP_ID=432746436346
PUSHER_APP_KEY=2a53nr42et52d5m
PUSHER_APP_SECRET=sh3j5ua9p1atj

MIX_PUSHER_APP_KEY="${PUSHER_APP_KEY}"
MIX_PUSHER_APP_CLUSTER="${PUSHER_APP_CLUSTER}"

connections in config/broadcasting.php:
        'pusher' => [
            'driver' => 'pusher',
            'key' => env('PUSHER_APP_KEY'),
            'secret' => env('PUSHER_APP_SECRET'),
            'app_id' => env('PUSHER_APP_ID'),
            'options' => [
                'cluster' => env('PUSHER_APP_CLUSTER'),
                'useTLS' => true,
                'encrypted' => true,
                'host' => '<IP_ADDRESS>',
                'port' => 6001,
                'scheme' => 'http'
            ],
        ]

config/websockets.php:
<?php

use BeyondCode\LaravelWebSockets\Dashboard\Http\Middleware\Authorize;

return [

    /*
     * Set a custom dashboard configuration
     */
    'dashboard' => [
        'port' => env('LARAVEL_WEBSOCKETS_PORT', 6001),
    ],

    /*
     * This package comes with multi tenancy out of the box. Here you can
     * configure the different apps that can use the webSockets server.
     *
     * Optionally you specify capacity so you can limit the maximum
     * concurrent connections for a specific app.
     *
     * Optionally you can disable client events so clients cannot send
     * messages to each other via the webSockets.
     */
    'apps' => [
        [
            'id' => env('PUSHER_APP_ID'),
            'name' => env('APP_NAME'),
            'key' => env('PUSHER_APP_KEY'),
            'secret' => env('PUSHER_APP_SECRET'),
            'enable_client_messages' => false,
            'enable_statistics' => true,
        ],
    ],

    /*
     * This class is responsible for finding the apps. The default provider
     * will use the apps defined in this config file.
     *
     * You can create a custom provider by implementing the
     * `AppProvider` interface.
     */
    'app_provider' => BeyondCode\LaravelWebSockets\Apps\ConfigAppProvider::class,

    /*
     * This array contains the hosts of which you want to allow incoming requests.
     * Leave this empty if you want to accept requests from all hosts.
     */
    'allowed_origins' => [
        'STAGING.HOST.com',
        'HOST.com',
    ],

    /*
     * The maximum request size in kilobytes that is allowed for an incoming WebSocket request.
     */
    'max_request_size_in_kb' => 250,

    /*
     * This path will be used to register the necessary routes for the package.
     */
    'path' => 'laravel-websockets',

    /*
     * Dashboard Routes Middleware
     *
     * These middleware will be assigned to every dashboard route, giving you
     * the chance to add your own middleware to this list or change any of
     * the existing middleware. Or, you can simply stick with this list.
     */
    'middleware' => [
        'web',
        Authorize::class,
    ],

    'statistics' => [
        /*
         * This model will be used to store the statistics of the WebSocketsServer.
         * The only requirement is that the model should extend
         * `WebSocketsStatisticsEntry` provided by this package.
         */
        'model' => \BeyondCode\LaravelWebSockets\Statistics\Models\WebSocketsStatisticsEntry::class,

        /**
         * The Statistics Logger will, by default, handle the incoming statistics, store them
         * and then release them into the database on each interval defined below.
         */
        'logger' => BeyondCode\LaravelWebSockets\Statistics\Logger\HttpStatisticsLogger::class,

        /*
         * Here you can specify the interval in seconds at which statistics should be logged.
         */
        'interval_in_seconds' => 60,

        /*
         * When the clean-command is executed, all recorded statistics older than
         * the number of days specified here will be deleted.
         */
        'delete_statistics_older_than_days' => 60,

        /*
         * Use an DNS resolver to make the requests to the statistics logger
         * default is to resolve everything to <IP_ADDRESS>.
         */
        'perform_dns_lookup' => false,
    ],

    /*
     * Define the optional SSL context for your WebSocket connections.
     * You can see all available options at: http://php.net/manual/en/context.ssl.php
     */
    'ssl' => [
        /*
         * Path to local certificate file on filesystem. It must be a PEM encoded file which
         * contains your certificate and private key. It can optionally contain the
         * certificate chain of issuers. The private key also may be contained
         * in a separate file specified by local_pk.
         */
        'local_cert' => env('LARAVEL_WEBSOCKETS_SSL_LOCAL_CERT', null),

        /*
         * Path to local private key file on filesystem in case of separate files for
         * certificate (local_cert) and private key.
         */
        'local_pk' => env('LARAVEL_WEBSOCKETS_SSL_LOCAL_PK', null),

        /*
         * Passphrase for your local_cert file.
         */
        'passphrase' => env('LARAVEL_WEBSOCKETS_SSL_PASSPHRASE', null),
    ],

    /*
     * Channel Manager
     * This class handles how channel persistence is handled.
     * By default, persistence is stored in an array by the running webserver.
     * The only requirement is that the class should implement
     * `ChannelManager` interface provided by this package.
     */
    'channel_manager' => \BeyondCode\LaravelWebSockets\WebSockets\Channels\ChannelManagers\ArrayChannelManager::class,
];

Code
bootstrap.js:
import Echo from 'laravel-echo';

window.Pusher = require ('pusher-js');

window.Echo = new Echo({
  broadcaster: 'pusher',
  key: process.env.MIX_PUSHER_APP_KEY,
  wsHost: window.location.hostname,
  wsPort: 6001,
  forceTLS: false,
  disableStats: true,
});

Tried:

The site is using Cloudflare, but have tried to switch to dev-mode and setting the origin IP in my host file locally - no change.
The site is running on Forge - not sure if this might influence.
Switching off the daemon and running it manually. No connections arrived.

Side Note
The backend logs also show attempts to connect to pusher.com to deliver the notifications - I guess the issue on the frontend affecting the backend as well. Any hints on how to configure it correctly are highly appreciated.
Versions I'm using:
Composer
PHP 7.4.10
laravel/framework                   v7.28.3
beyondcode/laravel-websockets       1.8.1
pusher/pusher-php-server            v4.1.4

NPM
<EMAIL_ADDRESS><EMAIL_ADDRESS>
Cheers,
Peter

try adding this config option enabledTransports: ['ws', 'wss'], to your Echo object

Hey @myckhel
Thank you for pointing this out. It indeed helped to point the requests at my application.
Now I struggle with the next issue: The socket server is running, but the requests aren't arriving. I get a 404 on the site.
I've ensured the server firewall to allow the port and even switched Cloudflare off (sockets are already on). Any clues what to look at?
Again, thank you for you help,
Peter

Oh
Have you tried to visit the websocket dashboard /laravel-websockets

Connect and send custom events to see if it works normally from the server part.

If so i guess server side working  and client side would need debugging

Hey @myckhel
thanks for pointing me to the dashboard! Good idea to check! Here are my findings:

I can connect - it works as expected. That's already more than I get on the website. This lead me to look closer at the issue of the website not connecting and I've noticed that my site is returning 404 as Echo is attempting to connect on 443 (SSL) instead of 6001 (websockets). I've fixed this by adding 'wssPort': 6001 to the Echo configuration.

I can't send messages on the dashboard or from the application. I guess the application is attempting to send via pusher.com... I get a 500 error back with this:

[2020-10-08 10:03:14] production.ERROR: Failed to connect to Pusher. {"userId":1,"exception":"[object] (Illuminate\\Broadcasting\\BroadcastException(code: 0): Failed to connect to Pusher. at /home/project/project.com/vendor/laravel/framework/src/Illuminate/Broadcasting/Broadcasters/PusherBroadcaster.php:121)
[stacktrace]
#0 /home/project/project.com/vendor/beyondcode/laravel-websockets/src/Dashboard/Http/Controllers/SendMessage.php(26): Illuminate\\Broadcasting\\Broadcasters\\PusherBroadcaster->broadcast()
#1 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(48): BeyondCode\\LaravelWebSockets\\Dashboard\\Http\\Controllers\\SendMessage->__invoke()
#2 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Routing/Route.php(239): Illuminate\\Routing\\ControllerDispatcher->dispatch()
#3 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Routing/Route.php(196): Illuminate\\Routing\\Route->runController()
#4 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Routing/Router.php(685): Illuminate\\Routing\\Route->run()
#5 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(128): Illuminate\\Routing\\Router->Illuminate\\Routing\\{closure}()
#6 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Routing/Middleware/SubstituteBindings.php(41): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#7 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Routing\\Middleware\\SubstituteBindings->handle()
#8 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/VerifyCsrfToken.php(77): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#9 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Foundation\\Http\\Middleware\\VerifyCsrfToken->handle()
#10 /home/project/project.com/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php(49): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#11 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\View\\Middleware\\ShareErrorsFromSession->handle()
#12 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php(116): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#13 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php(62): Illuminate\\Session\\Middleware\\StartSession->handleStatefulRequest()
#14 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Session\\Middleware\\StartSession->handle()
#15 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/AddQueuedCookiesToResponse.php(37): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#16 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Cookie\\Middleware\\AddQueuedCookiesToResponse->handle()
#17 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php(67): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#18 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Cookie\\Middleware\\EncryptCookies->handle()
#19 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(103): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#20 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Routing/Router.php(687): Illuminate\\Pipeline\\Pipeline->then()
#21 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Routing/Router.php(662): Illuminate\\Routing\\Router->runRouteWithinStack()
#22 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Routing/Router.php(628): Illuminate\\Routing\\Router->runRoute()
#23 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Routing/Router.php(617): Illuminate\\Routing\\Router->dispatchToRoute()
#24 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(165): Illuminate\\Routing\\Router->dispatch()
#25 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(128): Illuminate\\Foundation\\Http\\Kernel->Illuminate\\Foundation\\Http\\{closure}()
#26 /home/project/project.com/vendor/laravel/nova/src/Http/Middleware/ServeNova.php(26): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#27 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Laravel\\Nova\\Http\\Middleware\\ServeNova->handle()
#28 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#29 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest->handle()
#30 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#31 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest->handle()
#32 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ValidatePostSize.php(27): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#33 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Foundation\\Http\\Middleware\\ValidatePostSize->handle()
#34 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/CheckForMaintenanceMode.php(63): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#35 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Foundation\\Http\\Middleware\\CheckForMaintenanceMode->handle()
#36 /home/project/project.com/vendor/fruitcake/laravel-cors/src/HandleCors.php(37): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#37 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Fruitcake\\Cors\\HandleCors->handle()
#38 /home/project/project.com/vendor/fideloper/proxy/src/TrustProxies.php(57): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#39 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Fideloper\\Proxy\\TrustProxies->handle()
#40 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(103): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
#41 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(140): Illuminate\\Pipeline\\Pipeline->then()
#42 /home/project/project.com/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(109): Illuminate\\Foundation\\Http\\Kernel->sendRequestThroughRouter()
#43 /home/project/project.com/public/index.php(55): Illuminate\\Foundation\\Http\\Kernel->handle()
#44 {main}
"}

Any great points on how to configure the backend application to use the local websockets server too @myckhel ?
Once more, thank you for your help! I wouldn't been that far without it!
Cheers,
Peter

Having a similar problem on laravel 8, although only on localhost, previously it worked, no changes in config

Maybe you are missing this config option in Echo object key: PUSHER_KEY that could be the reason for the error.

Maybe the pusher key is not correct key: PUSHER_KEY that could be the reason for the error.
try to log your pusher key or confirm its the exact

Shouldn't the key be irrelevant when using this websocket module?

Maybe the pusher key is not correct key: PUSHER_KEY that could be the reason for the error.
try to log your pusher key or confirm its the exact

Shouldn't the key be irrelevant when using this websocket module?

weeeew im not sure but i think its better to follow the pusher way.

weeeew im not sure but i think its better to follow the pusher way.

Hmmmmm, I'm keen to make it work with this package. I've googled already but couldn't find anything solving my issue.

Checking the line error came from.
https://github.com/beyondcode/laravel-websockets/blob/c85ec38452f8dfdad4310dc22af19108f89fa9fe/src/Dashboard/Http/Controllers/SendMessage.php#L26
It seems the data from the dashboard is not a json.
I hope you put a valid json in the data input e.g {"key": "value"}
Before you pressed the send button.

Yup, I've made sure it's a json. It also throws an error, if you enter something else @myckhel

If you use 'useTLS' => true, you might as well change the scheme to https

It might not be helpful, but I had the same issue and in my case, the host in the pusher config was wrong. If you are using homestead on your local, please check host is set to your local host name or ip

It might not be helpful, but I had the same issue and in my case, the host in the pusher config was wrong. If you are using homestead on your local, please check host is set to your local host name or ip

Hey @damieneskimo
I've resolve it by now. Plus a few other issues I've noticed along the way. Thanks for pointing it out, in a similar hope to make the search easier for others I've written a little blogs post about the issues I've solved. Maybe it helps someone...
Cheers,
Peter

Hey @damieneskimo
I've resolve it by now. Plus a few other issues I've noticed along the way. Thanks for pointing it out, in a similar hope to make the search easier for others I've written a little blogs post about the issues I've solved. Maybe it helps someone...
Cheers,
Peter


K.Dᴀᴠɪs: Watch PhalluMAX

K.Dᴀᴠɪs requests the watch of the watch_keyword PhalluMAX. See the Metasmoke search here and the Stack Exchange search here.

PhalluMAX has been seen in 1 true positive, 0 false positives, and 0 NAAs.

!!/approve

Coverage remained the same at 65.236% when pulling 2de929c7bf25cea95abaff112dc9897dea7d9f02 on auto-blacklist-1522039016.6895425 into fa980635f7e3f61e518301338d067d6e7dee5f8f on master.


does this model support chinese model?

does this model support chinese model ? can i train a chinese model to use?

You can find this information listed at the bottom of Readme.md，https://github.com/bojone/SimCSE


[Select] Collapse as TransitionComponent doesn't work

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.
Current Behavior 😯
If I specify a TransitionComponent in the MenuProps of a Select component, the menu draws in the wrong place and does no transition.
The default transition is Grow, but I want to change it Collapse.
Expected Behavior 🤔
The menu should use the Collapse transition.
Steps to Reproduce 🕹
I couldn't figure out how to use codesandbox so I made a new create-react-app project.  Here's the source to App.js:
import React from 'react';
import MenuItem from '@material-ui/core/MenuItem';
import Select from '@material-ui/core/Select';

export default function App() {
  const [selectValue, setSelectValue] = React.useState(1)

  return (

        <Select
          value={selectValue}
          onChange={evt => setSelectValue(evt.target.value)}
          MenuProps={{
            //TransitionComponent: "Collapse",
            transitionDuration: 1500
          }}
        >
          <MenuItem value={1}>one</MenuItem>
          <MenuItem value={2}>two</MenuItem>
          <MenuItem value={3}>three</MenuItem>
        </Select>

  )
}

If you run this and click on the Select you'll see the menu appear and slowly grow.  If you then uncomment-out the TransitionComponent line and try again, you'll see the menu appear with no transition at the origin.
Context 🔦
I don't like the default Grow effect and would like to use a Collapse effect.
Your Environment 🌎

`npx @material-ui/envinfo`
  System:
    OS: Windows 10 10.0.19043
  Binaries:
    Node: 14.17.3 - C:\Program Files\nodejs\node.EXE
    Yarn: Not Found
    npm: 7.20.5 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Spartan (44.19041.1023.0), Chromium (92.0.902.73)
  npmPackages:
    @material-ui/core: ^4.12.3 => 4.12.3
    @material-ui/styles:  4.11.4
    @material-ui/system:  4.12.1
    @material-ui/types:  5.1.0
    @material-ui/utils:  4.11.2
    @types/react:  17.0.17
    react: ^17.0.2 => 17.0.2
    react-dom: ^17.0.2 => 17.0.2
    typescript:  4.3.5

Thanks for the report.
Looks like it's just an issue with Collapse. It's working for Fade: https://codesandbox.io/s/basicselect-material-demo-forked-idh71

I would like to give this a try if no one else is working on it.

I would like to give this a try if no one else is working on it.

Sure, go ahead. I've assigned the issue to you for bookkeeping. If you're stuck at any point feel free to open a PR with your progress.

I just looked at the codesandbox link posted yesterday by @eps1lon and I'm not seeing the same thing he is.  I added this to the  component:
          MenuProps={{
            TransitionComponent: "Fade",
            transitionDuration: 1500
          }}

With that in place I'm seeing the same thing as when I try to use "Collapse" -- the menu appears at the origin and there's no transition.  The same happens if I use "Grow" as the TransitionComponent.

If the component is imported and then passed as a value to the transitionComponent Fade, Grow and Zoom work, but Collapse does not work.
import React from "react";
import MenuItem from "@material-ui/core/MenuItem";
import Select from "@material-ui/core/Select";
import Fade from "@material-ui/core/Fade";

export default function App() {
  const [selectValue, setSelectValue] = React.useState(1);

  return (

        <Select
          value={selectValue}
          onChange={(evt) => setSelectValue(evt.target.value)}
          MenuProps={{
            TransitionComponent: Fade,
            transitionDuration: 1500,
          }}
        >
          <MenuItem value={1}>one</MenuItem>
          <MenuItem value={2}>two</MenuItem>
          <MenuItem value={3}>three</MenuItem>
        </Select>

  );
}

I just looked at the codesandbox link posted yesterday by @eps1lon and I'm not seeing the same thing he is. I added this to the component: MenuProps={{ TransitionComponent: "Fade", transitionDuration: 1500 }} With that in place I'm seeing the same thing as when I try to use "Collapse" -- the menu appears at the origin and there's no transition. The same happens if I use "Grow" as the TransitionComponent.

If the component is imported and then passed as a value to the transitionComponent Fade, Grow and Zoom work, but Collapse does not work.
import React from "react";
import MenuItem from "@material-ui/core/MenuItem";
import Select from "@material-ui/core/Select";
import Fade from "@material-ui/core/Fade";

export default function App() {
  const [selectValue, setSelectValue] = React.useState(1);

  return (

        <Select
          value={selectValue}
          onChange={(evt) => setSelectValue(evt.target.value)}
          MenuProps={{
            TransitionComponent: Fade,
            transitionDuration: 1500,
          }}
        >
          <MenuItem value={1}>one</MenuItem>
          <MenuItem value={2}>two</MenuItem>
          <MenuItem value={3}>three</MenuItem>
        </Select>

  );
}

I would like to give this a try if no one else is working on it.

Sure, go ahead. I've assigned the issue to you for bookkeeping. If you're stuck at any point feel free to open a PR with your progress.

Thank you. I'm a complete newbie at this, and I'm trying to figure out how to test the material-ui locally. Do I link it the react-app (e.g. yarn link)? If there is an article for this I would really appreciate. Thank you in advance!

I think I've figured out why this is happening but not sure what the fix would be.
For every transition component except for Collapse, in React Developer Tools it shows the component is being rendered:

For the Collapse component, React Developer Tools shows WithStyles() being rendered.

I could be wrong, but Collapse is the only component that uses the styled component within the transition component, and it may be the reason Collapse doesn't work it this context. Any help with this would be appreciated. :)

Thank you! I'm a complete newbie at this, and I'm trying to figure out how to test the material-ui locally. Do I link it to the react-app (e.g. yarn link)? If there is an article for this I would really appreciate. Thank you in advance!

I suspect that this is best tested manually during development so I would suggest you pick a demo using Select from docs/src/pages in TypeScript (ignore type errors for now) and work with that during development (yarn docs:dev).
Once you figured out how to fix or what the problem is, you can open a PR and I guide you through the rest.

Thank you, I will try that out!
On Thu, Aug 19, 2021 at 12:41 AM Sebastian Silbermann <
@.***> wrote:

Thank you! I'm a complete newbie at this, and I'm trying to figure out how
to test the material-ui locally. Do I link it to the react-app (e.g. yarn
link)? If there is an article for this I would really appreciate. Thank you
in advance!
I suspect that this is best tested manually during development so I would
suggest you pick a demo using Select from docs/src/pages in TypeScript
(ignore type errors for now) and work with that during development (yarn
docs:dev).
Once you figured out how to fix or what the problem is, you can open a PR
and I guide you through the rest.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/mui-org/material-ui/issues/27731#issuecomment-901684923,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGGC435SELZIFKCBDV34BKTT5SYTLANCNFSM5CEFXAQQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Hello any news on this, I get the same issue now, all other transitions work but not Collapse

i have the same issue, anyone have a fix?

Same issue, anyone have a fix?


ocaml-ng.ocamlPackages_4_08.ocaml: 4.08.0+rc2 -> 4.08.0

Motivation for this change
Major release!
Announcement<EMAIL_ADDRESS>Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_08.ocaml


Update for SCIM 2.9.3

Overview

Update to include SCIM bridge v2.9.3

Changes

Update helm dependencies
Update appVersion to include SCIM bridge 2.9.3
Update chart version

Checklist

[X] review the guide to contributing


Make rustls-tls an optional feature for reqwest.

rustls-tls includes a dependency that has a license considered
copyleft (MPL-2.0). To make this library more sound to use under the
MIT license, make rustls-tls an optional feature. This removes the
ability to specify client certs when the rustls-tls feature is
disabled. However, tls is enabled with reqwests defaults by default.

Appreciate the prompt review on the other two changes! This PR still depends on the old rustify version which uses the MPL-2.0 dependency by default. I can make it point at the rustify git directly or can update once there is a new version on crates-io if that is preferred.


[BugFix] Fix routine load task info null pointer exception

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/load/routineload/KafkaTaskInfo.java
0
1
00.00%
[179]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/load/routineload/KafkaTaskInfo.java
0
1
00.00%
[179]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/load/routineload/KafkaTaskInfo.java
0
1
00.00%
[179]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/load/routineload/KafkaTaskInfo.java
0
1
00.00%
[179]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)


Add a plugin to upload photos to Google Photos

Fixes #315.
This PR aims to address the recent changes in Google Photos + Google Drive where syncing between the two is no longer supported.
It works by uploading photos as part of the import process to add a copy of every photo in your library to Google Photos. Google Drive is not required for this plugin to work.
This plugin lets you have all your photos in Google Photos without relying on Google Drive. You can use another cloud storage service like iCloud or Dropbox or no cloud storage at all.

Coverage decreased (-0.09%) to 90.417% when pulling a7fd823983be57a062114d646dda4b2bb468de49 on google-photos into 7c3ea1e1d7a054f0cfe4f7c4801de8caf65d0a45 on master.

Coverage decreased (-0.09%) to 90.417% when pulling a7fd823983be57a062114d646dda4b2bb468de49 on google-photos into 7c3ea1e1d7a054f0cfe4f7c4801de8caf65d0a45 on master.


Accessibility: give alt tags to images on the Empty page and Error page

Describe the bug
No response
To Reproduce
No response
Expected Behavior
No response
Screenshot/ Video
No response
Additional context
No response

@kedaroo ,can you assign this issue ?

@hindu-muppala assigned. Good luck!


docs(dev guide): cleanup of deprecated Jade mixin

Replaced uses of liveExLinks mixin and then deleted its definition.

LGTM


Circle ProgressBar

I picked the demo project and add the class "Circle" to the ProgressBar and I see no changes in the layout

and the result

why the correct style is not being loaded?

@aboimpinto The demo project looks different now. Are you sure you pulled the master branch?

I think I have an old version of that ... I will check with the new version

It looks like the issue has been resolved. If not, feel free to reopen issue.


Gated deployments to production

After merge to main and staging deployment is successful, move to the production deployment. In this scenario, only allow it if it has been approved by a human.

Fixed in


CheatableStarknetFacade

Move Starknet's implementation details in CheatableStarknetFacade. Simplify CairoTestExecutionState and ContractsCheater. Code responsible for deploying and declaring wasn't moved in this PR. I plan to use CheatableStarknetFacade in PR with Expect Events.

I don't really understand why we need this abstraction to be present. it's coupling the starknet interaction code with starknet object itself (by inhertiance), which seems sub-optimal in terms of future code growth.

I am confused. I don't see the inheritance.

Can you please explain the reasoning? I think it'd be feasible to extract cheatables' interaction with starknet to a separate module, just i don't think that's the correct way of doing it.

This class hides Starknet's internals from Protostar. Protostar shouldn't know about these classes:

StarknetGeneralConfig
FactFetchingContext
DictStorage
SharedState
PatriciaStateReader
ExecuteEntryPoint

Also, it provides Starknet's interface made for Protostar needs. In Expect Events PR I need to get emitted events. This data isn't stored in CachedState, and I don't want to build code on top of unstable Starknet internals, especially because a refactoring in planned on the Starknet side.

This class hides Starknet's internals from Protostar
doesn't CairoTestExecutionState do the same thing ATM? This is a stretch IMO

and I don't want to build code on top of unstable Starknet internals
well that's what we mainly do here 😬 also if extracted to a controller (cheater ATM), and passing the StarkNet object, it'd fit into our current design nicely, without the need to compilcate things

doesn't CairoTestExecutionState do the same thing ATM? This is a stretch IMO

CairoTestExecutionState, as the name suggest, keeps test execution state.

well that's what we mainly do here 😬 also if extracted to a controller (cheater ATM), and passing the StarkNet object, it'd fit into our current design nicely, without the need to compilcate things

I don't get this part. CheatableStarknetFacade would focus on providing Starknet interface for Protostar needs, Contracts Cheater/Controller would focus on business logic. The class is now big enough to justify separation.

CairoTestExecutionState, as the name suggest, keeps test execution state.

well yes, but it contains the knowledge on how to build the new state as well. that seems reasonable to me.

CheatableStarknetFacade would focus on providing Starknet interface for Protostar needs, Contracts Cheater/Controller
would focus on business logic. The class is now big enough to justify separation

Yes i agree, but it doesn't conform to the design we agreed upon, in which controllers would be divided by the technical aspect (transactions, expectations, state manipulation, etc..). It makes us pass yet another weird object around which contains state and some operations directly on that state (which current cheatcodes don't do - they can be treated as a function).
I just don't get the need for a separate abstraction over "starknet" since we established kind of "MVC" here -

HintLocal as a view
Controllers (previous cheaters) as a (stateless) controller
CheatableCachedState/ StarknetState as  a model

This adds another concept which is not optimal for understanding the architecture and what belongs where

You also said one time that you wanted to avoid dividing things by the domain, and do the division instead by a technical concept - StarknetFacade is the opposite of that in my understanding


Support cpuManagerPolicy for kubelet configuration in NodePool

Description
What problem are you trying to solve?
We need to use the cpuManagerPolicy: static instead of None
Currently we only support this list: https://karpenter.sh/docs/concepts/nodepools/#spectemplatespeckubelet
How important is this feature to you?
Will make more choice for applications to use dedicated CPU

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

We're currently tightly constraining down the set of kubeletConfiguration options that we offer in the NodePool. The reason for this is primarily that we (as a cloudprovider) don't want to have to handle the userData orchestration (and testing) for every kubeletconfiguration option that we add to the codebase.
If you need to add additional config to to your userData, you can add it using the technique documented in the upstream docs

Thank @jonathan-innis


Add more unit-tests for Lucene Byte Vector

Description
Add more unit-tests to improve test coverage for Lucene Byte Vector
Check List

[x] All tests pass
[x] New functionality has been documented.
[x] New functionality has javadoc added
[x] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@naveentatikonda are you still working on this PR?

@naveentatikonda are you still working on this PR?

Will rebase this PR, get it reviewed by our team and close it this week.

@naveentatikonda can this be closed?


changing initials to use the first and last name when given three names

I have an issue where my User name has first middle and last names. This was generating initials from the first and middle names instead of the first and last names. This fixes that.
John Adams =>  JA
John Quincy Adams => JA

Yes you are right.
Thanks for the commit. I'll update the package.


router: forbid bouncing packets internally

A packet received on the internal interface would previously be "bounced" to the responsible egress router.
This is forbidden in the SCION design and was an accidental mis-feature of the processing logic.
Fixes #4497

This change is


[EC-233] Implemented EIP 170

Description
Includes implementing EIP-170. This disables the use of contracts larger than a fixed limit (24576 in the Eth mainnet), causing their creation to fail.

I see it is not part of EIP but should we add block height configuration to enable this limit at specific I see condition block.number >= FORK_BLKNUM?

sorry accidentally closed

I see it is not part of EIP but should we add block height configuration to enable this limit at specific I see condition block.number >= FORK_BLKNUM?

I see it is not part of EIP but should we add block height configuration to enable this limit at specific I see condition block.number >= FORK_BLKNUM?

It could be easily added, however AFAIK the block height isn't configurable on Parity or Geth (as for example in https://github.com/ethereum/go-ethereum/blob/master/core/vm/evm.go#L278), maybe you've seen otherwise?

but if it has no configuration how it can be turned on?
is it enabled in geth and parity?

but if it has no configuration how it can be turned on?
is it enabled in geth and parity?

In Geth and Parity it is always turned on, it seems that the reason why that's the case is that it was activated before the block gas limit was big enough to allow having txs that created contract with code this large (due to the gas cost per contract code byte).

needs merge


Downgrade paho-mqtt version

Use more strict version constraints for paho-mqtt

As a side note I think that we should never ever trust dependabot without manual tests.

Personally I do trust tools like dependabot and renovate, if we have enough tests. I mean it worked with out tests, but we didn't check how the dependencies worked out at HA. (Like, there are only some libraries we have to watch out for)

This is not a long term solution because it forces people to use an unsupported paho-mqtt version that will gradually become incompatible with other dependencies projects have.


Added contributor list

A big thanks to my main contributors

https://github.com/prettier/plugin-pug/blob/213fafc0db9b3654fab13116cce0bbfe2f3d7a3a/package.json#L20-L22

@jerome-benoit  I will hold on so that if you would like to add more details about you we can do that .)


Support creating a blank VHD in a storage account

There are Kubernetes scenarios where users need to be able to provision blank VHDs in a storage account so they can make them available in their cluster.
Today, basically there are only two options as far as I can tell:

Attach a new blank disk to a VM from the Portal or CLI. Immediately detach the disk. At least it's a valid VHD.
Create the VHD on your local system. (qemu-img, etc)

There ought to be a way to do this from CLI (or better yet, if this were something that Storage could do via an API).

Though it is possible to use a combination of PutPageBlob and PutPageb to create a blank page blob and then append a VHD label to the blob, an Azure API support is ultimate the best idea for the following reason:

it is atomic operation
Even if VHD format changes, the API won't change.

Here's a sample piece of code: https://gist.github.com/sedouard/0468d1b2d0153ca9a652
But ideally this problem should be resolved with upcoming new Disks APIs.

One such user scenario is Pachyderm which requires a data-disk to be created and mounted to be used for their RethinkDB (https://github.com/pachyderm/pachyderm/issues/960) and having an API to create a blank data-disk would be the 💣 or...at least put Azure on par with AWS and GCE:
AWS: aws ec2 create-volume ...
GCE: gcloud compute disks create ...

I ended up wrapping @sedouard's workaround into a tidy Docker image (https://github.com/jpoon/azure-create-vhd). Still would be good to have this in the Azure CLI.

I had already done that as well, for the azure-kubernetes-demo repo that shows how to use data disks: https://github.com/colemickens/azure-tools

Is there any update on this? @colemickens docker image works good, but enabling this operation via the Azure CLI is really the way to go.

No update here. When everything moves to managed disks, there will be an easy way to do this, including CLI support. For now, the non-managed disks implementation simply has no API for disk creation.
For now, it's much easier to just use dynamic provisioning... you just create a PVC for whatever size you want and Kubernetes will make the PV for you.

@colemickens I managed to use dynamic provisioning via the kubernetes.io/azure-disk Provisioner but I'm hitting the very low limit (i.e. 4) of mounted disks on my A2 VM.
Is there a way to do the same dynamic provisioning with azure-file? I.e., dynamically create files in my Storage Account and mount them on my Pods.
ta.

Dynamic provisioning for Azure Files should be in 1.7, and probably cherry-picked to 1.6.1, I think: https://github.com/kubernetes/kubernetes/pull/42170
But you probably shouldn't use it for anything serious at all. The perf is definitely not good enough for a DB or anything.

@colemickens thx for the prompt response. And yeah, I recon this is an SMB drive and not suitable for DBs. Wondering if it could work for a small SQLite though..
In any case, do you happen to know why is there a limitation on the number of vhds I can mount on a VM and why is it so low?
{
    "maxDataDiskCount": 4,
    "memoryInMb": 3584,
    "name": "Standard_A2",
    "numberOfCores": 2,
    "osDiskSizeInMb": 1047552,
    "resourceDiskSizeInMb": 138240
  }

That's just how Azure sells their SKUs. I'd suggest contacting support to ask them and express your interest in different SKUs with lower compute and more disks.

Thx @colemickens.

@dbalaouras here's a table that shows the various SKUs and the number of data disks that you can attach.

@jpoon thx. My concern is that in best case, the number of disks is double the number of cores. It's not super useful when using Dynamic Provisioning, thus (at least) 1 vhd per Pod, cause you are then limited to 3 Pods per Node :-/

@dbalaouras

And yeah, I recon azure-files are SMB drives and not suitable for DBs. Wondering if it could work for a small SQLite though..

I tried to use Azure File for SQLite database storage for Grafana which failed with errors about "locked" database. Adding "nobrl" to CIFS share mount options workarounds this issue, but I doubt this somehow makes SQLite correctly work on SMB share, I think data corruptions can be expected.

When everything moves to managed disks, there will be an easy way to do this, including CLI support.

Yep, try az disk create

Trying to use
az disk create

with Kubernetes like this example from @colemickens (https://github.com/colemickens/azure-kubernetes-demo/blob/master/test-azure-disk.yaml) , where I need to specify VHD url.  Managed disks don't seem to have the notion of VHD URLs ? How can I use managed disks in the yaml for Kubernetes ?

I need to specify VHD url.  Managed disks don't seem to have the notion of VHD URLs

I don't really know the e2e flow, but for this specific question, try az disk grant-access

@writeameer managed disk support in k8s is coming and I think is slated for 1.7 (https://github.com/kubernetes/kubernetes/pull/41950)

@yugangw-msft  Thank you.
@jpoon Got it, thank you for the link to the issue - great insight - much appreciated.

Hi folks, can this issue be closed now since managed disk support has been integrated with azure/k8s? Let me know if there are other improvements I should made.


Feat: Implemented Pull to Refresh feature on Skill Listing

Changes: Added pull to refresh on Skill Listing Page  #462

@jogendra  please review.

@raghavbabbar I am little busy these days. Will review your PR soon. Thank you for your contribution :)


Update to 3.0 preview5

Might still be some minor stuff to clean up in CI but I think this is ready for review.


[Accessibility] Support speech typing in editor and terminal

Type: Feature Request
CC @meganrogge
ms-vscode.vscode-speech currently supports Copilot Chat only. However, its speech-input feature can empower people with dis/abilities to improve their typing performance in other editor areas.
I understand that the speech-typing is primarily trained for natural languages rather than programming syntax; however, the natural speech typing in editor areas is still useful for  writing comments, drafting markdown/plaintext documents, etc.
In terminal, the natural language speech input can be used in conjunction with github-copilot-cli tool so there is no reason to prevent users from voice-typing through this extension in terminal.
Extension version: 0.3.2023110115
VS Code version: Code - Insiders 1.85.0-insider (eb56719ae7653bff54989385818ef39e1cd73d29, 2023-11-24T15:21:39.004Z)
OS version: Windows_NT x64 10.0.22631
Modes:

@meganrogge @Tyriar this is all ready to be adopted in the workbench, simply use ISpeechService.createSpeechToTextSession and listen to the onDidChange events. You can use ISpeechService.hasSpeechProvider to know if there is an extension present.

Natural language search in the quick pick / command palette would also be nice

I think eventually we would want to support speech input to anywhere you can type (input fields, text areas).

One question is how we handle the insertion of special characters /punctuation via voice input.
@jooyoungseo mentioned that some software allows mapping between a nonverbal sound and punctuation (like a tongue click)

@bpasero for these, what do you think about a status bar indicator when the speech to text session is in progress for sighted users?
tracking the issue for screen reader users here https://github.com/microsoft/vscode/issues/201901

@jooyoungseo how do you prevent VS code's speech detection from taking in the screen reader content? When I enable voiceover and try to use VS Code speech, parts of what the screen reader says are inputted.

@meganrogge yes I would think a global indicator makes sense, but maybe it needs to account for indicators that are already in context: for example, the copilot chat input box indicates recording. I would not want to see more indicators globally, e.g. in the status bar.
That makes me wonder if maybe all indication should be in context, for example where the cursor is in the editor or terminal.
//cc @hbons as I think this is also a UX issue to look at

We could perhaps put an indicator on the editor / terminal tab

I have pinged you on a UX design from Jo that I found interesting for inline chat.

editor inspiration:

Going to track speech typing in the editor / input fields in a separate issue


HDDS-2137 : OzoneUtils to verify resourceName using HddsClientUtils

/label ozone

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
1184
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
72
Maven dependency ordering for branch

-1
mvninstall
31
hadoop-ozone in trunk failed.

-1
compile
22
hadoop-ozone in trunk failed.

+1
checkstyle
62
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
927
branch has no errors when building and testing our client artifacts.

+1
javadoc
168
trunk passed

0
spotbugs
204
Used deprecated FindBugs config; considering switching to SpotBugs.

-1
findbugs
26
hadoop-ozone in trunk failed.

_ Patch Compile Tests _

0
mvndep
27
Maven dependency ordering for patch

-1
mvninstall
34
hadoop-ozone in the patch failed.

-1
compile
25
hadoop-ozone in the patch failed.

-1
javac
25
hadoop-ozone in the patch failed.

-0
checkstyle
28
hadoop-hdds: The patch generated 7 new + 38 unchanged - 5 fixed = 45 total (was 43)

-0
checkstyle
28
hadoop-ozone: The patch generated 3 new + 26 unchanged - 9 fixed = 29 total (was 35)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
723
patch has no errors when building and testing our client artifacts.

+1
javadoc
166
the patch passed

-1
findbugs
25
hadoop-ozone in the patch failed.

_ Other Tests _

-1
unit
160
hadoop-hdds in the patch failed.

-1
unit
27
hadoop-ozone in the patch failed.

+1
asflicense
31
The patch does not generate ASF License warnings.

4616

Reason
Tests

Failed junit tests
hadoop.ozone.container.keyvalue.TestKeyValueContainer

hadoop.ozone.container.ozoneimpl.TestOzoneContainer

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1455

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux eee188862a63 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 56f042c

Default Java
1.8.0_222

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/1/artifact/out/branch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/1/artifact/out/branch-compile-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/1/artifact/out/branch-findbugs-hadoop-ozone.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/1/artifact/out/patch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/1/artifact/out/patch-compile-hadoop-ozone.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/1/artifact/out/patch-compile-hadoop-ozone.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/1/artifact/out/diff-checkstyle-hadoop-hdds.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/1/artifact/out/diff-checkstyle-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/1/artifact/out/patch-findbugs-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/1/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/1/testReport/

Max. process+thread count
340 (vs. ulimit of 5500)

modules
C: hadoop-hdds/client hadoop-ozone/common U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@elek @adoroszlai Could you please let me know if there is a way to build hadoop-ozone with hadoop-hdds client dependency?

/retest

@virajjasani I am not sure what do you need exactly. hadoop-ozone always use hadoop-hdds (common, client as a dependency).
The alternative CI builds is not triggered because we have a whitelist to allow PR builds

/retest

@virajjasani I am not sure what do you need exactly. hadoop-ozone always use hadoop-hdds (common, client as a dependency).
The alternative CI builds is not triggered because we have a whitelist to allow PR builds

Thanks @elek

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
83
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
68
Maven dependency ordering for branch

-1
mvninstall
31
hadoop-ozone in trunk failed.

-1
compile
20
hadoop-ozone in trunk failed.

+1
checkstyle
46
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
882
branch has no errors when building and testing our client artifacts.

+1
javadoc
151
trunk passed

0
spotbugs
174
Used deprecated FindBugs config; considering switching to SpotBugs.

-1
findbugs
24
hadoop-ozone in trunk failed.

_ Patch Compile Tests _

0
mvndep
26
Maven dependency ordering for patch

-1
mvninstall
32
hadoop-ozone in the patch failed.

-1
compile
22
hadoop-ozone in the patch failed.

-1
javac
22
hadoop-ozone in the patch failed.

-0
checkstyle
26
hadoop-hdds: The patch generated 8 new + 37 unchanged - 6 fixed = 45 total (was 43)

-0
checkstyle
25
hadoop-ozone: The patch generated 3 new + 26 unchanged - 9 fixed = 29 total (was 35)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
705
patch has no errors when building and testing our client artifacts.

+1
javadoc
153
the patch passed

-1
findbugs
23
hadoop-ozone in the patch failed.

_ Other Tests _

+1
unit
282
hadoop-hdds in the patch passed.

-1
unit
25
hadoop-ozone in the patch failed.

+1
asflicense
28
The patch does not generate ASF License warnings.

3400

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1455

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux f63c9bb8183d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 01d7924

Default Java
1.8.0_212

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/2/artifact/out/branch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/2/artifact/out/branch-compile-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/2/artifact/out/branch-findbugs-hadoop-ozone.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/2/artifact/out/patch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/2/artifact/out/patch-compile-hadoop-ozone.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/2/artifact/out/patch-compile-hadoop-ozone.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/2/artifact/out/diff-checkstyle-hadoop-hdds.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/2/artifact/out/diff-checkstyle-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/2/artifact/out/patch-findbugs-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/2/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/2/testReport/

Max. process+thread count
380 (vs. ulimit of 5500)

modules
C: hadoop-hdds/client hadoop-ozone/common U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1455/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


Fix the view memory leak and array/view copy/move.

This fixes some of the discussed issues with arrays. The changes are noted in the list below. Some of these points should still be discussed.

Add tests for copy/move of all combinations of array/view.
Add a new exception helper macro for testing array dimensions.
When copying something into a view, do bound checking and ensure what is
copied has a compatible amount of data. To discuss.
When copying into an array, the proper amount of data is allocated and copied
over.
When moving a into b, b becomes a and a is invalid afterwards.
Resize and reset for views reset the pointer to nullptr and do not allocate
anything. To discuss. Another way would be to do nothing, or we could also
provide a specific method for setting the pointer.

Regarding when copying into a view, bounds checking and a throw looks reasonable to me.
The resize_and_reset gets called when moving from an view, right ? In that case, intuitively, to me, setting the pointer to nullptr and not allocating makes sense. I am not sure if it makes sense to decide based on whether something makes implementing our algorithms easier because if the function does something un-intuitive, then using and debugging it becomes a lot harder.

@tcojean Can you add a test with a custom deleter and copying of views with mismatching sizes?
That way, we document that this is a potential problem we need to address.
ASSERT_THROW(view1_custom_del = view2, gko::NotSupported);

Copying view test with mismatched size is already there I think
ASSERT_THROW(view2 = view_size4, gko::OutOfBoundsError);

Anyone has any idea why I get this weird Windows compilation issue? I don't think I changed anything relevant...?
D:\a\ginkgo\ginkgo\core/base/iterator_factory.hpp(297,2): error C2398: Element '2': conversion from 'size_t' to 'gko::detail::IteratorFactory<IndexType,ValueType>::Reference::array_index_type' requires a narrowing conversion [D:\a\ginkgo\ginkgo\build\reference\ginkgo_reference.vcxproj]
          with
          [
              IndexType=gko::int64,
              ValueType=std::complex<double>
          ]
D:\a\ginkgo\ginkgo\core/base/iterator_factory.hpp(296): message : while compiling class template member function 'gko::detail::IteratorFactory<IndexType,ValueType>::Reference gko::detail::IteratorFactory<IndexType,ValueType>::Iterator::operator [](size_t) const' [D:\a\ginkgo\ginkgo\build\reference\ginkgo_reference.vcxproj]
          with
          [
              IndexType=gko::int64,
              ValueType=std::complex<double>
          ]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\include\algorithm(2749): message : see reference to function template instantiation 'gko::detail::IteratorFactory<IndexType,ValueType>::Reference gko::detail::IteratorFactory<IndexType,ValueType>::Iterator::operator [](size_t) const' being compiled [D:\a\ginkgo\ginkgo\build\reference\ginkgo_reference.vcxproj]
          with
          [
              IndexType=gko::int64,
              ValueType=std::complex<double>
          ]

#490 simply rebase onto develop

Thanks... I thought I was already up to date with develop but I guess I missed this one.


Generating coroutines for existing Java stubs (without .proto)?

May I admit ignorance of Kroto+ internals. Does Kroto+ require .proto file(s), or does it [after protoc and javac] load the Java classes, inspects them by reflection, and generates the coroutines from them only?
Say you have access to Java classes generated by protoc (for example, as artifacts from Maven). Removing a copy of .proto would mean one less step to maintain. (Of course, if the generated classes change, then the developer may have to update the coroutines, too.)

An example is https://github.com/grpc/grpc-java/blob/master/services/src/main/proto/grpc/health/v1/health.proto, which has the generated Java classes on Maven Central.

So kroto does in fact generate coroutines clients. There’s no reflection involved. Setting up the codegen to run for an existing artifact from maven is trivial. The process is explained in detail here https://github.com/google/protobuf-gradle-plugin/blob/master/README.md#protos-in-dependencies
If you didn’t want to configure code gen then you could technically use the call builders directly. The generated stubs do this internally similar to the code generated by the default grpc java plugin. https://github.com/marcoferrer/kroto-plus/blob/e88d06241a129665c584aae709ddda61eeb121ef/kroto-plus-coroutines/src/main/kotlin/com/github/marcoferrer/krotoplus/coroutines/client/ClientCalls.kt#L59

Thank you.


Support all S3 storage classes

Support all S3 storage classes
Description
Current version of libcloud supports only "standard" and "reduced_redundancy" storage classes.
AWS S3 add new storage classes during the past two years (https://docs.aws.amazon.com/cli/latest/reference/s3/cp.html).
This PR is to support all S3 storage classes.
Status

done, ready for review

Checklist (tick everything that applies)

[x] Code linting (required, can be done after the PR checks)
[x] Documentation
[x] Tests
[ ] ICLA (required for bigger changes)

Closes #1882

Thanks for the contribution and sorry for a late response. I'll review the changes today.

I reviewed the changes - they need some more work (lint is failing, tests is failing, etc.), but besides that they look good to me.
I will fix lint and test failure and merge changes into trunk.

I fixed lint and failing test and merge your changes into trunk.
Thanks again for your contribution.


[FEA] Improve limit processing performance

Is your feature request related to a problem? Please describe.
When running a query with a limit, an input task will often load the entire input file (or set of files if batching smaller files).  This can be inefficient if the limit is low and accessing the data is slow.  In those cases it is often faster to load much less data since only that amount of data is needed to satisfy the limit.
Describe the solution you'd like
I'm not sure how best to fix this, but I wanted to file an issue to track some ideas:

Better limit push-down into the input formats, where we may be able to avoid running fully wide in the input stage.  This is likely a change best done in Apache Spark and is not specific to GPU processing.
Automatic tuning of the input batch size so we're not so aggressive at batching large amounts of rows together for reduced overhead and therefore higher throughput.  For many limit queries, latency trumps throughput.
Related to the previous, we could load fewer row groups from the input file when we see the number of rows loaded from the row group far exceed the limit (or some similar heuristic).  This could guess wrong and cause us to invoke the GPU parser once per rowgroup in vain attempts to hit the limit early, but it could be a nice win in other cases.

Closing as won't fix for now


Implement TemplateGrid

This PR implements a generic TemplateGrid that can be used to generate a grid of templates representing logical qubits (for example).
Closes #244

This is ready for review.

Just as a comment, while we are definitely moving towards having an even
convention for our surface code and standardizing the global 3D structure,
there will be cases where we need to build specialized structures at a
lower level, so we do need to maintain generality. For example,
implementing the latest state distillation factory, which we will talk
about in due course, will require very custom layers of scalable circuits.
The idea is that the entire factory will become a block available in our 3D
template and this block will be carefully constructed using all techniques
available.
Best,
Austin.
On Tue, Jun 25, 2024, 11:48 PM Adrien Suau @.***> wrote:

I don't quite get the use case for DenseQubitSquareTemplate, could you
explain more on this?
QubitSquareTemplate is not complete enough. For example, when gluing two
logical qubits into a larger patch, some of the corners should be assigned
a plaquette, which is not possible with QubitSquareTemplate because these
corners are not included in the template.
As a side note, it allows even and odd logical qubits, we might want to
restrict that in the future according to the norm we want to use.
—
Reply to this email directly, view it on GitHub
https://github.com/QCHackers/tqec/pull/245#issuecomment-2190941402, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKAXTEMXHWJ5KLVNCR5JMTZJJP3DAVCNFSM6AAAAABI4ETOB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJQHE2DCNBQGI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


(IAC-528) added git share directive for viya4-deployment

Fixes this issue : https://github.blog/2022-04-12-git-security-vulnerability-announced/

This needs testing just added the code snippet needed to start moving forward on this one.

Best way to test. Create the new docker image. Run a container with that image using the entry point bash then
cat .gitconfig

You should see output showing a section with the label [safe] and the correct directory.


Add CI tool integration

Add either https://snap-ci.com/ or https://travis-ci.org/ integration.
Should have:

Post Submit:

Run Tests
Publish Snapshot version

Deploy version

Increment version
Deploy to MVN Central

'Post Submit' part has been set up on Snap-CI -- https://snap-ci.com/ctco/cukes-rest/branch/master

Manually triggerable 'Publish version' pipeline step has been set up and used to release version 0.2.0 .
After Sonatype will enable automatic synchronization to Maven central nexus-staging-maven-plugin will have to be set up so that the releases would not require manual actions to forward artifacts from staging repository to release repository.

Deployment has been set up with nexus-staging-maven-plugin.
Release of version 0.2.1 was performed with the new configuration.


ETH_P_* constants should be c_ushort

ETH_P_* constants (and probably more I haven't stumbled across) should be defined as c_ushorton linux x86-64 rather than c_int for 2 related reasons:

To improve ease of use with the various sockaddr_* structs where they most often get used.
Because when they are converted to big endian network ordering for use in those structs, (0x00000003).to_be() != (0x0003).to_be(), which is a really irritating gotcha.

I'm happy to do a find-and-replace to get those (and any others which people think should be changed) if you think it's a sane change.

This is similar to https://github.com/rust-lang/libc/issues/1619, something that is int in function signatures but short in structs. We'll have to figure out what to do here.


Flow claims type incompatibility for async function when returned value is instance of subclass with a constructor

Consider the following minimal example class that extends node's EventEmitter:
import { EventEmitter } from 'events';

class Example extends EventEmitter {
  constructor() {
    super();
  }
}

Now consider the following helper:
function makeExample(): Example {
  return new Example();
}

As expected, Flow 0.19.1 has no issues with this and reports 0 errors.
Now consider an async version of this helper:
async function makeExampleAsync(): Promise<Example> {
  return new Example();
}

This makes Flow complain:
index.js:16
 16:   return new Example();
              ^^^^^^^^^^^^^ Example. This type is incompatible with
430:     static resolve<T>(object?: Promise<T> | T): Promise<T>;
                                    ^^^^^^^^^^ Promise. See: /private/tmp/flow/flowlib_38091f69/core.js:430

What's weird:

Using no base class or custom base class (rather than some node-provided one) makes the error go away
Getting rid of the custom constructor in the subclass makes the error go away.

Given that the sync version of the helper is cool with Flow, I can only assume that this a bug in Flow? I don't really see how the async version changes any of the contracts and assumptions that Flow can make.

Think this is working as intended, as @samwgoldman explained to me in #834. (An async function is just a generator + promise in disguise.)

What if you do
return await new Promise(function(resolve, reject) {
    resolve(new Example());
}).then(function(example) {
    return example;
});

?

Sadly that doesn't change anything. Even the following causes the same error:
function makeExampleAsync(): Promise<Example> {
  let example = new Example();
  return Promise.resolve(example);
}

If this is related to #834 (which I don't quite understand, because I'm lacking context -- the repo that's referenced has been deleted), I'd be happy to sprinkle some extra type checks into my code. But where?

So this is pretty strange, but we've seen errors with Promise and EventEmitter interacting poorly before. See #545 and #683. I'm honestly not sure what is going on there...

@samwgoldman any workarounds you can think of? I tried typing everything out with Promise<any> rather than Promise<Example> but that doesn't help either...

Never mind, this worked for me as a (sad) workaround:
async function makeExampleAsync(): Promise<any> {
  let example: any = new Example();
  return example;
}

This is a problem I saw a ton of times while trying to declare Bluebird properly for flow:
The issue seems to be Flow bailing out early on a union type when it really should be trying the other side.
For example, the definition of Promise.resolve() is:
declare class Promise<R> {
  // ...
  static resolve<T>(object?: Promise<T> | T): Promise<T>;
}

Which fails the above example with the error:
 12:   return new Example();
              ^^^^^^^^^^^^^ Example. This type is incompatible with
 17:     static resolve<T>(object?: Promise<T> | T): Promise<T>;
                                    ^^^^^^^^^^ Promise. See: interfaces/promise.js:17

But simply inverting the union fixes the issue. This is really odd, because unions shouldn't have ordering:
  static resolve<T>(object?: T | Promise<T>): Promise<T>;

  No errors!

I verified that it was, indeed, typechecking:
// No errors!
async function makeExampleAsync(): Promise<EventEmitter> {
  return new Example();
}

//  16:   return new Foo();
//             ^^^^^^^^^ Foo. This type is incompatible with
//  17:     static resolve<T>(object?: T | Promise<T>): Promise<T>;
//                                  ^^^^^^^^^^^^^^ union type. See: interfaces/promise.js:17
class Foo {}
async function makeExampleAsync(): Promise<EventEmitter> {
  return new Example();
}

I just ran into this today...has there been any project on this issue?

The following code works:
/* @flow */

import { EventEmitter } from 'events';

class Example extends EventEmitter {
  constructor() {
    super();
  }
}

async function makeExampleAsync(): Promise<Example> {
  return new Example();
}

function makeExample(): Promise<Example> {
  let example = new Example();
  return Promise.resolve(example);
}

Likely fixed in 0.28 as part of the big union/intersection re-implementation.


[SPARK-35682][PYTHON][TESTS] Pin mypy==0.812 in GitHub Actions CI

What changes were proposed in this pull request?
Seems like the new MyPy version was released (0.901) and it broke the CI: https://github.com/python/mypy/releases.
python/pyspark/pandas/indexes/base.py:2007: error: Argument 1 to "from_tuples" of "MultiIndex" has incompatible type "Index"; expected "List[Tuple[Any, ...]]"
python/pyspark/testing/pandasutils.py:41: error: Library stubs not installed for "tabulate" (or incompatible with Python 3.6)
python/pyspark/testing/pandasutils.py:41: note: Hint: "python3 -m pip install types-tabulate"
python/pyspark/testing/pandasutils.py:41: note: (or run "mypy --install-types" to install all missing stub packages)
python/pyspark/testing/pandasutils.py:41: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 2 errors in 2 files (checked 312 source files)

I tried to fix these instances and pin it to the latest version (0.901). However, I realised that python/pyspark/pandas/indexes/base.py:2007 has a logic issue (see https://github.com/databricks/koalas/pull/1325#discussion_r647889901 and https://github.com/databricks/koalas/pull/1325#discussion_r647890007) which cannot be fixed quickly.
Therefore, I decided to pin it to the previous version we used before for now, in order to unblock other PRs builds.
Why are the changes needed?
To unblock other PRs.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
I tested in my local but it has to be tested and passed in GitHub Actions in this PR.

cc @dongjoon-hyun, @viirya, @ueshin and @itholic

Test build #139515 has started for PR 32829 at commit 052c9c1.

LGTM, let me take a look at the SPARK-35683 and resolve SPARK-35684.

Merged to master.
Related tests passed, and other tests should not be related at all.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44040/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44040/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44040/

Test build #139515 has finished for PR 32829 at commit 052c9c1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139515/


Update newest prisma

Prisma 2 is in production now
https://www.prisma.io/blog/prisma-the-complete-orm-inw24qjeawmb

Sure I’ll do that today.


Security scan

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: sullub sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

test

re


Do not retry statement without drop, when drop was succesful

This should fix #65. The following code after except tries to rerun the create statement in case drop statement failed because the entity did not exist. This PR adds a check if the drop was actually successful, which means the error probably came from syntax error in the user-supplied definition. This is able to fix the issue in #65 for me in the sense I am getting a syntax error instead of 'already exists' error now.
https://github.com/olirice/alembic_utils/blob/f6370b05f76eaf27f8e08e714e297b6f793baaa6/src/alembic_utils/simulate.py#L46-L65

In fact, the did_yield is probably not needed at all here. did_drop should be enough to decide whether to retry without the drop.

thanks for the PR!
I agree that including did_drop and did_yield is redundant. If you'd make that change in the PR i'll get this merged

Done

Codecov Report

Merging #66 (78b26d6) into master (f6370b0) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #66   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           18        18
  Lines          840       840
=========================================
  Hits           840       840

Flag
Coverage Δ

unittests
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/alembic_utils/simulate.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6370b0...78b26d6. Read the comment docs.


Improvement: Make "Last Active" available in neonctl branches list

From Discord: https://discord.com/channels/1176467419317940276/1281248863470096446/1281248863470096446

Is there a way to get the Last active field from the browser UI with this command: neonctl branches list --project-id PROJECT_ID --output json?
Currently, I only see a created_at and an updated_at, neither of which match the data of the Last active column.  We're trying to automate branch cleanup and need this data to know which branches are safe to be pruned.

So essentially, we need the same information that powers the "Last Active" column in the Neon Console UI made available in the neonctl response to neonctl branches list

FYI, @lpetkov @Shridhad knowing you work on the new branches grid, perhaps you want to figure out if this can be addressed too


Roles: everyone is a member

In my app, all messageboards have posting_permission set to logged_in. However, when creating a private topic, the list of users is taken from Roles. Is this a bug?
Also, when creating a private topic in the demo app, the only user I can add is joel.

Just ran into this on the meta messageboard on thredded.com where I @ message'd someone who is not a member, and it didn't notify them. Best user story I can think of right now is

As a user who posts on a completely public messageboard I want my @ mentions to notify me.


[api] expose workflow on request resources

We need workflow as part of the Request resource API output in order to show the Request Workflow details in SUI.
api/requests/<id>?attributes=workflow
Sub task of https://www.pivotaltracker.com/n/projects/1914499/stories/135708235

@abellotti @imtayadeway Could you please review? Thanks.
/cc @chriskacerguis

This LGTM for the main part, just a couple of questions above. Thanks! :cake:

:+1: LGTM
Thanks @AparnaKarve ! :balloon:

Thanks @AparnaKarve for the API enhancement.  LGTM!!
Will merge when 🍏


Properly handle SearchResult XSS issues.

The SearchResult.ascx page is susceptible to XSS when the search string has single-quotes (breaks JSON at page bottom). This patch fixes the issues the right way; using HtmlAttributeEncode when emitting user-supplied values (when echoing back the SearchTerm or TagsQuery values in the input fields) and JavaScriptStringEncode when emitting the SeachTerm in the dnn.searchResult.queryOptions script.
This also simplifies the code behind to null-coalesce the query parameters and not do the encoding on the input values (instead encoding them on the rendering out, as it should be)

changes looks good and merge, btw, for JavaScriptStringEncode, we want to use Localization.GetSafeJSString instead of it.


Infer the appropriate MNIInfant cohort based on the participant's age

Closes #826.
Changes proposed in this pull request

Adapt Nibabies' code to figure out the right cohort to use based on a participant's age.
Make --infant require --subject-anatomical-reference session since age can't be inferred across sessions.

Codecov Report
Attention: Patch coverage is 13.08411% with 93 lines in your changes missing coverage. Please review.

Project coverage is 28.57%. Comparing base (ee895af) to head (6d6d0e7).

Files with missing lines
Patch %
Lines

qsiprep/utils/bids.py
9.87%
73 Missing :warning:

qsiprep/workflows/base.py
0.00%
12 Missing :warning:

qsiprep/interfaces/anatomical.py
20.00%
4 Missing :warning:

qsiprep/workflows/anatomical/volume.py
40.00%
3 Missing :warning:

qsiprep/workflows/dwi/hmc_sdc.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
- Coverage   28.76%   28.57%   -0.19%
==========================================
  Files          68       68
  Lines       10025    10123      +98
  Branches     1109     1134      +25
==========================================
+ Hits         2884     2893       +9
- Misses       7042     7131      +89
  Partials       99       99

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hi @tsalo, must I have a .tsv file to specify the ages? (My data is not longitudinal)
I read the rc1 and Nibabies documentation and tried using —age-months 2 as an argument, which was invalid as expected. Otherwise is there some way I could specify the cohort from the available keys directly (e.g. from bids.py L719-739)?
If constructing a .tsv file is the only way, could I confirm that I just need a column with subjects and a second column with age_months? Are column headers needed?
Thanks!

@chiuhoward I think just having the age in your participants.tsv should be enough, but I don't think we've tested the infant processing outside of an HBCD-specific context. We didn't add --age-months because I think it's already deprecated in Nibabies.
When we implement --output-spaces users will be able to specify the cohort in the template string, but in the meantime specifying the age in the TSV is probably the only way to get it working.