Fail to create ClusterServiceBroker

What version of environ?

Kubernetes (v1.6.0, one-node)
Service Catalog (v0.1.0-rc1)
OS (Ubuntu 17.04)

What happened?
I  developed a new service broker called opensds-broker, which can transfer request to opensds. When I installed it using helm, everything went well as followed:
NAME                                             READY     STATUS    RESTARTS   AGE
opensds-broker-opensds-broker-2617526377-gj873   1/1       Running   0          12m
ups-broker-ups-broker-3390838748-nxsc7           1/1       Running   0          5m

But after I created the servicebroker resource in Service Catalog, some errors occured:
  status:
    conditions:
    - lastTransitionTime: 2017-10-16T08:19:32Z
      message: 'Error fetching catalog. ClusterServiceBroker "opensds-broker": Error
        getting broker catalog: Get http://opensds-broker-opensds-broker.opensds-broker.svc.cluster.local/v2/catalog:
        dial tcp: lookup opensds-broker-opensds-broker.opensds-broker.svc.cluster.local:
        no such host'
      reason: ErrorFetchingCatalog
      status: "False"
      type: Ready
    operationStartTime: 2017-10-16T08:19:32Z
    reconciledGeneration: 0

At first I thought there is something wrong with installation, so I tried to install ups-broker as guided, but same error occured:
  status:
    conditions:
    - lastTransitionTime: 2017-10-16T08:29:59Z
      message: 'Error fetching catalog. ClusterServiceBroker "ups-broker": Error getting
        broker catalog: Get http://ups-broker-ups-broker.ups-broker.svc.cluster.local/v2/catalog:
        dial tcp: lookup ups-broker-ups-broker.ups-broker.svc.cluster.local: no such
        host'
      reason: ErrorFetchingCatalog
      status: "False"
      type: Ready
    operationStartTime: 2017-10-16T08:29:59Z
    reconciledGeneration: 0

Since I'm not so familiar with this project, so I would be appreciated if someone offers help.

Do you have cluster DNS installed / running correctly?  The error indicates a DNS failure.

Hey,
Even I am encountering the same error, even though my DNS is installed and running correctly. It'll be a real help if you could provide more insight.

Catalog controller is trying to contact the broker using the DNS name of your broker's service.  It creates the DNS name by concatinating the ..svc.cluster.local.   Make sure the service is running.  Take a look at kubectl get services --all-namespaces and verify you see your services and that they have an IP address and are running.  You can also try kubectl describe service ups-broker-ups-broker -n ups-broker.

Hi @jboyd01
Thanks for the reply.
As u mentioned, I ran both the commands describing the status of the broker's service. It was indeed in a running state without any discrepancies. Therefore,  I tried replacing the url in the contrib/examples/walkthrough/ups-broker.yaml from url: http://ups-broker-ups-broker.ups-broker.svc.cluster.local to url: http://[ip-address-on-which-service-is-running]
Now, I encounter a different error as shown below:-
svcat describe broker ups-broker
Name:     ups-broker
URL:      http://[ip-address-on-which-service-is-running]
Status:   ErrorFetchingCatalog - Error fetching catalog. Error getting broker catalog: Get http://[ip-address-on-which-service-is-running]/v2/catalog: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
However, when I "curl http://[ip-address-on-which-service-is-running]/v2/catalog".
It runs without any problems.
Please let me know how do I proceed further or if anything more needs to be done.

as mentioned in https://github.com/kubernetes-incubator/service-catalog/issues/1402#issuecomment-336881170 it sounds like DNS or some other critical infrastructure is not working.  You shouldn't need to change the ip address.   What kind of kube cluster are running?  (ie minikube, local-up-cluster, etc)
I just re-read your description - are you on the same versions as the original person reported (v0.1.0rc1 & kube 1.6)?  That is a pretty old version of Service Catalog, and officially Kube 1.6 wasn't supported (https://github.com/kubernetes-incubator/service-catalog/blob/v0.1.0-rc1/docs/install-1.6.md)
I'd recommend picking up a new version of Service Catalog.  We're on v0.1.14 and to the best of my knowledge its pretty stable.  A lot has changed (for the better) over the last 6 months.  Note that you'll still need at least Kubernetes 1.7 or greater.

Hi @jboyd01
Thanks for replying.
The issue which I mentioned in my comment has been encountered on a system with the following environment:-
Kubernetes version (use kubectl version): 1.9.6
Service Catalog version:- 0.1.14
Type of kube-cluster:- Local-up
OS (e.g. from /etc/os-release): Ubuntu 16.04
Kernel (e.g. uname -a): s390x
Install tools: Docker(Version:18.03.0-ce)
Also, all the pods are up and running as shown below:-
kubectl get pods --all-namespaces
NAMESPACE NAME READY STATUS RESTARTS AGE
catalog catalog-catalog-apiserver 2/2 Running 0 17m
catalog catalog-catalog-controller-manager 1/1 Running 0 17m
kube-system etcd 1/1 Running 0 1d
kube-system kube-apiserver 1/1 Running 0 1d
kube-system kube-controller-manager 1/1 Running 0 1d
kube-system kube-dns 3/3 Running 0 1d
kube-system kube-flannel-ds 2/2 Running 0 1d
kube-system kube-proxy 1/1 Running 0 1d
kube-system kube-scheduler 1/1 Running 0 1d
kube-system tiller-deploy 1/1 Running 0 1d
ups-broker ups-broker-ups-broker 1/1 Running 0 13m
cat /etc/resolv.conf
nameserver <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>
search default.svc.cluster.local svc.cluster.local cluster.local
However, I am still facing the issue as mentioned.
Please let me know how do I proceed further or if anything more needs to be done.

Sounds like an interesting setup and please report back when you solve the issue so we can add some notes to the documentation to support future users, thanks for trailblazing @abhaysingh1722 !

Hi @jboyd01
The walkthrough example mentioned in https://github.com/kubernetes-incubator/service-catalog/blob/v0.1.14/docs/walkthrough.md is not working as expected for "kubectl get clusterservicebrokers ups-broker -o yaml"  as I am getting the status as:-
ErrorFetchingCatalog - Error fetching catalog. Error getting broker catalog
Is there any other way to check if my service catalog build is working correctly or not?

@abhaysingh1722 Good to hear you are using a recent build and Kube 1.9.  I don't have experience with s390 nor am I aware of any issues around it.  I routinely run with local-cluster-up.sh.  An alternative you could try is minikube.  Based on the details we've discussed so far, it still sounds like a Kubernetes infrastructure problem.
If you do kubectl describe clusterservicebroker ups-broker  what is the Status and Events listed?
If you look at the Catalog controller log you will see additional details on why the catalog is failing to communicate with the broker, but I imagine the describe command above will highlight the problem.  To view the log you can use the command kubectl logs -l app=catalog-catalog-controller-manager -n catalog | less
Are you still overriding the default host name for the broker service (ups-broker-ups-broker.ups-broker.svc.cluster.local) as described in https://github.com/kubernetes-incubator/service-catalog/issues/1402#issuecomment-381649466 ?   What's the describe look like for the service? ie kubectl describe service ups-broker-ups-broker -n ups-broker
If you were not aware, you can deploy a pod for investigating the environment and running tools like nslookup or curl within the pod.  This should help resolve or at least determine if DNS is the issue.  For example:
$ kubectl run busybox --image=radial/busyboxplus:curl -i --tty --rm
If you don't see a command prompt, try pressing enter.
[ root@curl-jboyd-fd66dccbf-7s5ws:/ ]$ nslookup ups-broker-ups-broker.ups-broker.svc.cluster.local
Server:    <IP_ADDRESS>
Address 1: <IP_ADDRESS> kube-dns.kube-system.svc.cluster.local

Name:      ups-broker-ups-broker.ups-broker.svc.cluster.local
Address 1: <IP_ADDRESS> ups-broker-ups-broker.ups-broker.svc.cluster.local

[ root@curl-jboyd-fd66dccbf-7s5ws:/ ]$ curl http://ups-broker-ups-broker.ups-broker.svc.cluster.local/v2/catalog
{"services":[{"name":"user-provided-service","id":"4f6e6cf6-ffdd-425f-a2c7-3c9258ad2468","description":"A user provided service","bindable":true,"dashboard_client":null,"plan_updateable":true,"plans":[{"name":"default","id":"86064792-7ea2-467b-af93-ac9694d96d52","description":"Sample plan description","free":true},{"name":"premium","id":"cc0d7529-18e8-416d-8946-6f7456acd589","description":"Premium plan"}]},{"name":"user-provided-service-single-plan","id":"5f6e6cf6-ffdd-425f-a2c7-3c9258ad2468","description":"A user provided service","bindable":true,"dashboard_client":null,"plan_updateable":true,"plans":[{"name":"default","id":"96064792-7ea2-467b-af93-ac9694d96d52","description":"Sample plan description","free":true}]},{"name":"user-provided-service-with-schemas","id":"8a6229d4-239e-4790-ba1f-8367004d0473","description":"A user provided service","bindable":true,"dashboard_client":null,"plan_updateable":true,"plans":[{"name":"default","id":"4dbcd97c-c9d2-4c6b-9503-4401a789b558","description":"Plan with parameter and response schemas","free":true,"schemas":{"service_instance":{"create":{"parameters":{"$schema":"http://json-schema.org/draft-04/schema#","properties":{"param-1":{"description":"First input parameter","type":"string"},"param-2":{"description":"Second input parameter","type":"string"}},"type":"object"}},"update":{"parameters":{"$schema":"http://json-schema.org/draft-04/schema#","properties":{"param-1":{"description":"First input parameter","type":"string"},"param-2":{"description":"Second input parameter","type":"string"}},"type":"object"}}},"service_binding":{"create":{"parameters":{"$schema":"http://json-schema.org/draft-04/schema#","properties":{"param-1":{"description":"First input parameter","type":"string"},"param-2":{"description":"Second input parameter","type":"string"}},"type":"object"},"response":{"$schema":"http://json-schema.org/draft-04/schema#","properties":{"credentials":{"properties":{"

Hi @jboyd01
Thanks for replying. I'll have a look, with those commands.
Is there any other example to check if my service catalog build is working correctly or not?

@abhaysingh1722 the ups broker is a simple broker many Catalog developers use every day for simple test and verification.  This should work and I think its the most straight forward configuration.   I don't think its an issue with the build - everything is pointing to an error with the Catalog Controller pod being able to communicate with the broker pod.  I'd pursue reviewing the events & status from kubectl describe service ups-broker-ups-broker -n ups-broker


Enzyme 3: Mount rendering finds the same element twice with React.cloneElement

If I clone an element and try to find the same element after mount rendering, Enzyme finds the element twice.
Please see my component and test below:
Component
export const Dummy: React.StatelessComponent<DummyProps> = (
    props: BadgeProps,
) => {
    const { children, id } = props;

    const clonedChildren = React.Children.map(children, (child: any) => {
        return React.cloneElement(child);
    });

    return
{clonedChildren}
;
};

Test
import { mount } from 'enzyme';
import * as React from 'react';

import { Dummy } from 'path/to/Dummy';

describe('Dummycomponent test suite', () => {

    it('renders a Dummy', () => {

        const wrapper = mount(

                <Dummy id="find-me"/>

,
        );

        expect(wrapper.find('#find-me').length).toBe(1);
    });
});

In this case, it's because it's finding both Dummy, and the div. Try wrapper.hostNodes().find()?

I don't think so. My result is the same even if my wrapper is
const wrapper = mount(

                <Dummy id="find-me"/>

,
        );

Sorry, should have given a clearer example.

Maybe I'm not being clear. Try wrapper.debug(), and you'll see two nodes with an id of "find-me".

wrapper.debug() gives me this.

      <Component id="find-me">

      </Component>

Now I can see why is it finding two nodes. wrapper.hostNodes().debug() also gives me the same result as above.

Hmm - wrapper.hostNodes() should restrict it to the divs; are you saying wrapper.hostNodes().find('#find-me').length is not 1?

Yes.

Just to confirm: what version of enzyme, react, and adapter are you using? Can you upgrade them all to the latest (if they're not already there) and try again?

I'm on<EMAIL_ADDRESS><EMAIL_ADDRESS>and<EMAIL_ADDRESS>

In that case, I'd say it's a bug in hostNodes. Can you try with shallow and see if hostNodes functions properly there?

console.log(wrapper.hostNodes().debug());  after shallow rendering the gives expected output.

      <Component id="find-me" />

Is it possible to prioritize this issue? From my point of view it is a blocker for existing projects that want to upgrade to react16

I also have Mount Rendering problem that render component twice.

@newnewnet can you file a new issue for that?

Any updates on this issue?

If there were updates, they'd be posted here. PRs are always welcome.

It seems after reading the thread here that the bug has nothing to do with the title of the issue but rather the behavior of hostNodes. In particular, that given nithinpeter's setup, wrapper.hostNodes().find('#find-me') finds the react component and the regular div with ids of "find-me" rather than just the div.
I am not sure this is a bug. Wouldn't this be expected behavior? Based on my limited knowledge of the codebase,  I would expect wrapper.find('#find-me').hostNodes() to return 1 because hostNodes() would be filtering against the nodes that have an id of find-me. So it would discard the React Component. wrapper.hostNodes().find('#find-me') on the other hand would call hostNodes on the root div, which would just return the wrapped root div. So calling wrapper.hostNodes().find('#find-me') would traverse the tree from the rendered root div (which <Dummy id="find-me"/> is nested in) and return the nodes that have an id of "find-me".
If this is not expected behavior I imagine it would be an enhancement of some kind.

Yes, I think that is expected behavior. You need .hostNodes() every time you want to filter out non-host-nodes; it doesn't set any kind of "host-node-only mode".
@nithinpeter what happens if you try wrapper.hostNodes().find('#find-me').debug()?

This behavior seems non-optimal. As you could previous to Enzyme 3, you should be able to do something like:
wrapper.find('#cancel_confirmtion_btn').simulate('click'); with a mounted component, and it to find only one div with the id cancle_confirm_btn.
What is the value of rendering the React Component along with the divs?

Got it. Thank you. And thank you for the example.
I'm trying to think of when you would want the React Components to also be rendered to test against them. I guess if you're dynamically rendering what is to be passed into them and would like to check against that rather than the actual divs..

That, as well as if you want to be able to access instance methods for any particular reason, like if you want to forcibly setState somewhere inside the tree.

Only the following worked for me:
it('should contain an element called #element-id', () => {
  const { wrapper } = setupMount();
  expect(wrapper.find('#element-id').hostNodes()).toHaveLength(1);
});

The following worked for me 👍
it('should contain an element called #element-id', () => {
  const { wrapper } = setupMount();
  expect(wrapper.find('#element-id').hostNodes()).toHaveLength(1);
});

I just hit up against this, it seems you can work around this to get the HTML element by being specific about the selector.
wrapper.find('input.Myclass') as opposed to wrapper.find('.Myclass')

@chrisrymer alternatively, wrapper.hostNodes().find('.Myclass')

@ljharb awesome work responding to the community!
Is it possible to make a patch in setupTests.js or somewhere else to implement hostNodes() for all find usage? I wonder that because I have a huge codebase with lots of tests that I want to upgrade to react 16.
Just so you know, about the issues with actual DOM elements and React Elements when upgrading. For me, wrapper.find('.Myclass').hostNodes() usually works but wrapper.hostNodes().find('.Myclass') returns 0 elements.
Thanks

No, it's not, and that would be a poor choice because it's too magic and implicit. I'd suggest writing a codemod that changes your entire codebase all at once (also, definitely upgrade to enzyme 3 and get everything passing, before upgrading your react version)

@guilherme6191 yes, precisely that - get enzyme 3 working on React 15 with the appropriate adapter first, before trying to upgrade React.
For the codemod, yes, that's probably the simplest approach - at least, all find occurrences that are passing in a selector (a string that's either a selector or an html element name).

hostNodes fixed it for me


feat: async runner.filter predicate (#6370)

Purpose
I need to have freedom in using both, sync and async functions when filtering tests using the Runner object
Approach
use an asynchronous filter
References
https://github.com/DevExpress/testcafe/issues/6370
Pre-Merge TODO

[x] Write tests for your proposed changes
[x] Make sure that existing tests do not fail

Hi @eignatyev
Thank you for contributing to TestCafe. We will review this PR.

Hi @miherlosev, thank you for getting back to me. The failing test should be fixed now.

Rebase please.

@miherlosev should I improve something else, or you guys will merge it when it's a good moment?

Your PR is OK. We will merge it after updating the Runner.filter topic in our documentation.


Change commandText property/parameter name

Currently input and output bindings share an attribute - and with that share the commandText property/parameter
This value can be multiple things based on the type of binding :
Input - Either a query or the name of a stored procedure
Output - The table name to upsert to
So out of the 3 potential options only one is really a "commandText".
To make it much more clear we should consider the following :

Renaming it to queryOrStoredProcedure and using that for input bindings
Adding a new property/parameter tableName and using that for output bindings (similar to the trigger attribute)

This is a pretty big breaking change, but would help make things a lot more clear when using the bindings.

Backlogging for now, but if we did choose to look at this again in future a couple things to consider :

Split the SqlAttribute into multiple (SqlInputAttribute & SqlOutputAttribute)
Maintain backwards compat - for a time at least. Can use data to determine how many people are using the "old" names and then when that number gets low enough can deprecate the back compat
Could also look into other breaking changes like fixing parameter parsing https://github.com/Azure/azure-functions-sql-extension/issues/6


Unable to complete free ticket order

Describe the bug
We've created an event with a $0.00 ticket for sponsors & organizers. However, I am unable to complete any order with the free ticket. I am able to get to the payment page, where it says "This is a free ticket, you can submit your order directly." however there is no "submit" or "proceed" button. There is a "Make Contribution" button, but it is grayed out.
Our event is here -> https://opencollective.com/solidus/events/solidusconf-2019-21928ev
To Reproduce
Steps to reproduce the behavior:

Create an event with a $0.00 ticket
Attempt to purchase the ticket and proceed to the payments page

Expected behavior
You should be able to check out with a free ticket - ideally with a "Complete Order" button rather than a "Make Contribution" button
Screenshots

I can reproduce.
@Betree do you think this is related to the change you made in the input fields?

@piamancini I don't think so, but it may be related to the recent refactor I made (https://github.com/opencollective/opencollective-frontend/pull/2281). I'll check that in priority today.


dyld: Symbol not found:

App crashes when try to launch on Iphone. But works on simulator.
dyld: Symbol not found: __TFSsoi1lFTSSSS_Sb
Referenced from: /private/var/mobile/Containers/Bundle/Application/23E75276-3295-4C2F-AA3E-6119F1D160FA/punjit.app/Frameworks/Alamofire.framework/Alamofire
Expected in: /private/var/mobile/Containers/Bundle/Application/23E75276-3295-4C2F-AA3E-6119F1D160FA/punjit.app/Frameworks/libswiftCore.dylib
in /private/var/mobile/Containers/Bundle/Application/23E75276-3295-4C2F-AA3E-6119F1D160FA/punjit.app/Frameworks/Alamofire.framework/Alamofire

From the Contribution Guidelines:
Asking Questions

We don't use GitHub as a support forum.For any usage questions that are not specific to the project itself, please ask on Stack Overflow instead. By doing so, you'll be more likely to quickly solve your problem, and you'll allow anyone else with the same question to find the answer. This also allows maintainers to focus on improving the project for others.

Hi Matt
The question is specific to the project itself. The project was compiling before i synced to the latest version of Alamofire with new Swift 1.2. After that it stopped working.
And it is raising different exceptions on different devices but all related to Alamofire.

Please follow the instructions in the README. The iOS example app runs on a device without any issues and many people in the community are using Alamofire on devices. The issue is specific to your project and you should ask your question on Stack Overflow as @mattt mentioned.


shouldn't there be an auto_increment for primary key?

https://github.com/chasethenag420/sbs/blob/master/test_account.sql#L27
Looks like every table we need add auto_intcrement for primary key. check once

@Jaswitha  is this fixed?

Yes , Auto increment should be there for userpii table .
On Wed, Oct 7, 2015 at 2:30 PM, Nagarjuna Myla<EMAIL_ADDRESS>wrote:

Closed #10 https://github.com/chasethenag420/sbs/issues/10.
—
Reply to this email directly or view it on GitHub
https://github.com/chasethenag420/sbs/issues/10#event-429645476.

do you want me to check for foreign key constraint?
On Wed, Oct 7, 2015 at 2:53 PM, jaswitha vankineni <
<EMAIL_ADDRESS>wrote:

Yes , Auto increment should be there for userpii table .
On Wed, Oct 7, 2015 at 2:30 PM, Nagarjuna Myla<EMAIL_ADDRESS>wrote:

Closed #10 https://github.com/chasethenag420/sbs/issues/10.
—
Reply to this email directly or view it on GitHub
https://github.com/chasethenag420/sbs/issues/10#event-429645476.

I have closed the issue I created 6 days back ;-)..that's why you got mail alert now I guess. Forget about this issue.. and yes if possible lets make foreign key constraint

ok ill look into it.
On Wed, Oct 7, 2015 at 3:04 PM, Nagarjuna Myla<EMAIL_ADDRESS>wrote:

I have closed the issue I created 6 days back ;-)..that's why you got mail
alert now I guess. Forget about this issue.. and yes if possible lets make
foreign key constraint
—
Reply to this email directly or view it on GitHub
https://github.com/chasethenag420/sbs/issues/10#issuecomment-146346191.

i made the foreign key constraint in the userpii table . i think it should
work now .There won't be any code changes.
On Wed, Oct 7, 2015 at 3:07 PM, jaswitha vankineni <
<EMAIL_ADDRESS>wrote:

ok ill look into it.
On Wed, Oct 7, 2015 at 3:04 PM, Nagarjuna Myla<EMAIL_ADDRESS>wrote:

I have closed the issue I created 6 days back ;-)..that's why you got
mail alert now I guess. Forget about this issue.. and yes if possible lets
make foreign key constraint
—
Reply to this email directly or view it on GitHub
https://github.com/chasethenag420/sbs/issues/10#issuecomment-146346191.


Implement vendor chunk support for esbuild builder

Command
build, serve
Description
When using esbuild builder, we got many chunks:

but that amount (we have around 50-65) not suitable for production use cases, because of performance application degradation due to poor web vitals. That happens due to absence of vendor chunk support. Yes we got that message, when we 'serve' app:
The esbuild-based browser application builder ('browser-esbuild') is currently in developer preview and is not yet recommended for production use. For additional information, please see https://angular.io/guide/esbuild
The 'namedChunks' option is not used by this builder and will be ignored.
The 'vendorChunk' option is not used by this builder and will be ignored.

Describe the solution you'd like
Would be good to have support of vendor chunk when all node modules libs concatenated like webpack builder do.
That dramatically changed core web vitals due to small amount of initial chunks
Describe alternatives you've considered
No response

For context esbuild does not support this https://github.com/evanw/esbuild/issues/207

@alan-agius4 yes, I see before that issue, but, in that case, esbuild is not suitable for production. I really test it for our large production application and see dramatic web vitals degradation. esbuild in that case only provide some speed of building, but ruin real web vitals totally.  Would be good if @alan-agius4 and your team can propose changes to esbuild for vendor chunk support.

Hi @pumano,
I did discuss this with @clydin, from initial testing we saw that with esbuild the lighthouse score were slightly better.
Overall, vendor chunking should have only been used for development purposes. This only existed in the Webpack builder to workaround rebuild time issues that Webpack has. While indeed Esbuild does generate more chunks, this does not necessary mean they are all initial, and in the majority of cases this is done to return initial size which should improve CWV as Webpack's module concatenation causes a lot of unneeded code to be put in the initial chunk.
Are you testing the lighthouse scores on a production or the Angular CLI dev-server? Testing with a dev-server can result in an incorrect scores since server config is a big part of this, such as response processing which differs greatly between vite and webpack-dev-server, compression, caching etc... It would be helpful to share your lighthouse reports.

@alan-agius4 I prepare lighthouse comparison for our app with webpack and with esbuild:
before:

after:

Any reason why you don't use HTTP 2? From the screenshots above I can see that the initial requests more than doubled, from 54 to 110 requests.

We have some limitations now, but after this issue we also trying to looking for HTTP/2

It would we great if you could send them via discord. You can find me in discord.gg/angular
I already sent you DM message

Hi @pumano,
We discussed the issue that you are facing and the root cause does appear to be because of using HTTP 1.
With the new modern toolchain we recommend users using modern HTTP protocols such like HTTP/2 or HTTP/3 which nowadays are provided out of the box by the majority of hosting providers and CDNs.
In the unlikely event that you still experience poor web vitals after using HTTP/2 or 3 please open a new issue.

@alan-agius4 OK thank you, for detailed feedback. We will try to upgrade our infrastructure for using HTTP/2.


Fix PlotBand.Label updating together with axis

When both Axis and and PlotBand.Label are updated twice, the label crashes.
The root cause: Updating axis recreates plotbands and -lines. Also calling axis.update without redrawing chart leaves axis.plotBandAndLines array empty.
This PR makes axis updates redraw synchronously when axis has plotbands or plotlines. Also this changes usePlotBandLine to always return newest object instance.
Note: PlotBand label can be updated once. After that it does not render changes:
https://jsfiddle.net/8tdozmgf/

Codecov Report

Merging #260 into master will decrease coverage by 17.68%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #260       +/-   ##
===========================================
- Coverage   89.17%   71.48%   -17.69%
===========================================
  Files          81       18       -63
  Lines        1016      249      -767
  Branches      194       45      -149
===========================================
- Hits          906      178      -728
+ Misses         96       63       -33
+ Partials       14        8        -6

Impacted Files
Coverage Δ

...-highcharts/src/components/WithHighcharts/index.js

.../src/components/HighchartsChart/HighchartsChart.js

...x-highcharts/src/components/Options3d/Options3d.js

...s/src/components/PlotBandLine/PlotBandLineLabel.js

...x-highcharts/src/components/UseHighcharts/index.js

...react-jsx-highcharts/src/components/YAxis/YAxis.js

...omponents/PlotBandLine/UsePlotBandLineLifecycle.js

.../components/Highcharts3dChart/Highcharts3dChart.js

...t-jsx-highcharts/src/components/Loading/Loading.js

...sx-highcharts/src/components/UseColorAxis/index.js

... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b62ff7...7e05487. Read the comment docs.

Fixed all the review comments. I consider this ready for merge.


[5.3] Add sentence_case to Support Helpers

A function to reverse snake_case or title_case to a simple sentence

Please don't include other commits.

No plans to add this to core.


Radix Sort

Radix sort does digit by digit sorting starting from the least significant digit and going up to the most significant one.

See my (as of now unmerged) PR on a go-lang implementation.


Add abilty to load from safetensors

It seems that presently you can't load from a safetensors file  unless I'm mistaken the library is using diffusers with the sdpipeline under the hood which should support this

Solved in #20


min-width

It would be nice to be able to specify a minimum width. With extremely small images, I get a lightbox that indeed shows the image, but the title/footer is outside of the lightbox.

+1 for this issue, lightbox is broken with images of small size.

+1 for this issue, lightbox is broken with images of small size. @ashleydw

I gave up on this and created a simple but functional BS4+JQ lightbox snippet: https://gist.github.com/joho1968/4b86e638f9967d95ec43780277fb3d58


How does the API calculates PPP?

Hi, awesome package and great work!
I want to use your API in a project that might last a long time (an open-source project). I want to know how to calculate PPP so that I can integrate it into my own set-up so it does not have a reliance on your API. However, I would be happy to host a mirror for your API as well if you are interested in sharing the source code of it.
Let me know,
Thanks,
Sapnesh

Hi Sapnesh,
all the implementation details can be found here https://github.com/rwieruch/purchasing-power-parity https://github.com/rwieruch/purchasing-power-parity It’s possible to install the API as JS library, but then you would have to provide your own API keys for the third-party APIs. If you implement yourself, you would need the data from somewhere else to calculate the PPP as well. The API that I have set up calculates the PPP once a day.
Best wishes,
Robin

On 26. Apr 2020, at 20:33, Sapnesh Naik<EMAIL_ADDRESS>wrote:
Hi, awesome package and great work!
I want to use your API in a project that might last a long time (open-source project). I want to know how to calculate PPP so that I can integrate it into my own set-up so it does not have a reliance on your API. However, I would happy to host a mirror for your API as well if you are interested in sharing the source code of it.
Let me know,
Thanks,
Sapnesh
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/rwieruch/purchasing-power-parity/issues/7, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS5OX3GEN2AU3WSCXUBEU3ROR473ANCNFSM4MRLD5YQ.


Avoid camera crash on Background process limit - No background processes

Changelog

Fix crash

Checklist

Avoid camera crash on Background process limit - No background processes

Tested on

Android 13

Looks good to me!


Use custom token to have the correct rights

"Read and write org and team membership, read and write org projects"
according to https://github.com/alex-page/github-project-automation-plus

bors merge


How to only build with certain languages

I wanted to know how to exclude all the language files that I don't want from the build? It's taking to much space.

@tvianney with the latest version, you will have only the languages that you provided in your configuration. Can you confirm?

@elreco Can you give us more infos where in the configurations or how to set it up? Thank you


GH-373: Transaction Synchronization

Resolves https://github.com/spring-projects/spring-kafka/issues/373
Implement Spring transaction synchronization.
cherry-pick to 1.3.x

Do we still need to worry about distinguishing KafkaTransactionManager in the ListenerContainer? I don't see any changes on the matter there.
I thought after making the TX sync proper we won't need to worry about the TX Manager type.
No? What am I missing?
Thanks

It depends on the answer to your other suggestion (which I need to think about) - we need to know whether or not to send the offsets.

Merged as https://github.com/spring-projects/spring-kafka/commit/36f836f07b20ceb7c94f6619c867c80488f2ce15

... and cherry-picked to 1.3.x


Adding details for API creation using openAPI archive

Adding details about creating API using open API archive.
Related to https://github.com/wso2/carbon-apimgt/pull/8509

@Sarangan0219, please address the last review comment and also look at resolving the conflicts.

@shaniR , the merging of this PR is blocked at the moment based on the review comments that you have added. Can you please review it, approve and merge it.


added genesis block for quark algorithm

can I know if anyone is going to accept or reject my PR?

Cheers!
Could you give me a cryptocurrency specific example so I can verify that the code indeed creates valid genesis blocks for quark and argon based coins.
Like there is currently in README.md for X11:
Create the original genesis hash found in HiroCoin

I don't know where I can find argon2 coins

For Argon2 I found these:
https://github.com/Encel-US/Argon2
https://github.com/OpesCoin/OPES
Second one seems to be more tested as it has it's own announcement on Bitcointalk.

It seems quark and argon2 PoW algorithms are not used in any of the well-known cryptocurrencies. I will close this PR because I feel adding more algorithms without real use cases would just make things more complicated.


picker doesn't update adapter start/end values in setState

I use picker as a widget and i want to update adapter start & end to new value every time the user click on button ,
but it only keeps the first values it's get, i even try with state  to call setState but it still not working . here is my code any help is appreciated
class _MyHomePageState extends State<MyHomePage> {
  int start = 0;
  int end = 5;

  void _updatePicker() {
    setState(() {
      start = 12;
      end = 24;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Picker(
            adapter: NumberPickerAdapter(data: [
              NumberPickerColumn(begin: start, end: end),
              NumberPickerColumn(begin: 0, end: 59),
            ]),
            delimiter: null,
            hideHeader: true,
            itemExtent: 32.0,
            height: 120.0,
            textScaleFactor: 1.1,
            columnPadding: EdgeInsets.all(6.0),
            selectedTextStyle: TextStyle(color: Colors.blue, fontSize: 18.0),
            onSelect: (Picker picker, int i, List value) {
              print(picker.getSelectedValues());
              List selectedValues = picker.getSelectedValues();
            }).makePicker(ThemeData(
          backgroundColor: Colors.white,
        )),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _updatePicker,
        child: Icon(Icons.access_time),
      ),
    );
  }
}

you @fatimahossny can try this, this is not the efficient one, but kinda like workaround
short Explanation: this will force picker widget to force reload, do note that you must wrap one of your picker inside other widget on futureBuilder like the example below.
sorry for my bad english :')
`
class _MyHomePageState extends State {
int start = 0;
int end = 5;
Future forceRebuild = Future.delayed(Duration.zero);
void _updatePicker() {
setState(() {
start = 12;
end = 24;
forceRebuild = Future.delayed(Duration.zero);
});
}
@override
Widget build(BuildContext context) {
....
body: Center(
child: FutureBuilder(
future: forceRefreshLuasBangunan,
builder: (context, snapshot) {
if (snapshot.connectionState == ConnectionState.waiting)
return Container(
child: {YourNumberPicker}
);
return {YourNumberPicker};
),
.....
}
`

Thanks! I've fixed this bug.

Thanks! I've fixed this bug.

Not working, I can't update new list NumberPickerColumn for NumberPickerAdapter, setState not working. Can you help me?

Thanks! I've fixed this bug.

I've setState but NumberPickerAdapter keep end with count of old state.


typeof a === "object" does not type the object as Object

Code
function doStuff(a: any) {

    if (typeof a === "object") {
        a //why isn't a typed as Object here?
    }
}

example here
Expected behavior:
in the if statement a should be typed as Object and give code completion suggestions for object (like hasOwnProperty).
Actual behavior:
a is still typed as any and no object based code completion suggestions are given.

Just running into this; the type guard you should use is something like:
function isObject<T>(t: T): t is T & object {
  return (typeof t === 'object') && (t !== null);
}

You need to eliminate null, because even though typeof null === 'object', null is not assignable to the type object.  In other words, the OP should be a request that typeof t === 'object' narrow to object | null, not just object.
Unfortunately even if TypeScript could automatically narrow a variable x where typeof x === 'object' from T to T & (object | null) (or from any to object | null) you would run into the following problem when you try to eliminate the null yourself:
function oops<T>(t: T): T {
  if (typeof x === 'object') {
    // even if this narrowed to (T & (object | null)), which it doesn't
    if (t !== null) {
      // here t is still T & (object | null) !!
      return new Proxy(t, {}); // so error here 🙁
    }
  }
  return t;
}

which is why I think the type guard above is the best bet here.

Also, not sure why @ahejlsberg's comment about narrowing from Array<T> to object would apply to an intersection (Array<T> & object would be equivalent to Array<T>, wouldn't it?) but I'm guessing that narrowing by eliminating union constituents and narrowing by intersection are done separately.  Oh well.


feature/setup-absolute-imports

Using Absolute Imports

Implementing absolute imports in Create React App
Linting
Type checking
Applying absolute imports

Looks good, let's merge!


Copy button from the info addon should not copy the ellipsed code

Work summary
When the example code of the storybook is too long it's cutt-off in the view using ellipsis  (which is ok) but the cut version if also the ones who is copied.

I think that when clicking on the copy button a uses is expecting to get the whole example in the clipboard.

I agree

Hi @ndelangen, any update on this issue?

@robcronin it has been closed from the stale bot, so: no.
I think you should provide a PR yourself if you need it


TypeError: init() got an unexpected keyword argument 'cell_clip'

It shows error while trying "python run.py --name test".(run.py is other repository file 'lefnire/tforce_btc_trader.git')
What could be the cause of this (issue/problem)?
Appreciate your help.
Traceback (most recent call last):
File "run.py", line 57, in
main()
File "run.py", line 43, in main
**hydrated
File "c:\users\administrator\rl\tensorforce\tensorforce\agents\ppo_agent.py", line 151, in init
entropy_regularization=entropy_regularization
File "c:\users\administrator\rl\tensorforce\tensorforce\agents\learning_agent.py", line 149, in init
batching_capacity=batching_capacity
File "c:\users\administrator\rl\tensorforce\tensorforce\agents\agent.py", line 79, in init
self.model = self.initialize_model()
File "c:\users\administrator\rl\tensorforce\tensorforce\agents\ppo_agent.py", line 179, in initialize_model
likelihood_ratio_clipping=self.likelihood_ratio_clipping
File "c:\users\administrator\rl\tensorforce\tensorforce\models\pg_prob_ratio_model.py", line 88, in init
gae_lambda=gae_lambda
File "c:\users\administrator\rl\tensorforce\tensorforce\models\pg_model.py", line 95, in init
requires_deterministic=False
File "c:\users\administrator\rl\tensorforce\tensorforce\models\distribution_model.py", line 86, in init
discount=discount
File "c:\users\administrator\rl\tensorforce\tensorforce\models\memory_model.py", line 106, in init
reward_preprocessing=reward_preprocessing
File "c:\users\administrator\rl\tensorforce\tensorforce\models\model.py", line 200, in init
self.setup()
File "c:\users\administrator\rl\tensorforce\tensorforce\models\model.py", line 307, in setup
self.initialize(custom_getter=custom_getter)
File "c:\users\administrator\rl\tensorforce\tensorforce\models\pg_model.py", line 107, in initialize
super(PGModel, self).initialize(custom_getter)
File "c:\users\administrator\rl\tensorforce\tensorforce\models\distribution_model.py", line 93, in initialize
kwargs=dict(summary_labels=self.summary_labels)
File "c:\users\administrator\rl\tensorforce\tensorforce\core\networks\network.py", line 180, in from_spec
kwargs=kwargs
File "c:\users\administrator\rl\tensorforce\tensorforce\util.py", line 159, in get_object
return obj(*args, **kwargs)
File "C:\Users\Administrator\RL\tforce_btc_trader\hypersearch.py", line 155, in init
super(CustomNet, self).init(layers_spec, **kwargs)
File "c:\users\administrator\rl\tensorforce\tensorforce\core\networks\network.py", line 270, in init
kwargs=dict(scope=scope, summary_labels=summary_labels)
File "c:\users\administrator\rl\tensorforce\tensorforce\core\networks\layer.py", line 143, in from_spec
kwargs=kwargs
File "c:\users\administrator\rl\tensorforce\tensorforce\util.py", line 159, in get_object
return obj(*args, **kwargs)
TypeError: init() got an unexpected keyword argument 'cell_clip'

It's a tforce_btc_trader thing, we'll address it there

yes, agree


Incoming call, no notification/flash/alert/sound

When I get an incoming call on facebook messenger for desktop i don't get any alert or notification or sound.
Future feature:

notification when incoming call
select ringtone for incoming call

Ho that is true, I will see to that.
Meanwhile please try the new beta.
See https://github.com/Aluxian/Facebook-Messenger-Desktop/issues/458


message: Bundle message stripping, validation, and truncation

We always want to do these at the same time. Previously, message editing did too much stripping (fixes #16837) and failed to check for NUL bytes.

lgtm, feel free to merge when CI is happy.


clightning: 0.6.3 -> 0.7.0

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

works for me

[x] package build on x86_64-linux
[x] executables tested on x86_64-linux


Re-name - website link updates

Below links require an update. Most of these still work via re-directs, except Greenhouse & 1 notion link, but require an update.
Top navigation bar - roadmap link

Update to https://taho.upvoty.com/

Main page - download now button -

Update to: https://chrome.google.com/webstore/detail/taho/eajafomhmkipbjmfmhebemolkcicgfmd

Chrome & Brave store links
4 instances: (2x) and taho.xyz/download (1x) and https://taho.xyz/security (1x)

update to: https://chrome.google.com/webstore/detail/taho/eajafomhmkipbjmfmhebemolkcicgfmd

Footer bar

Governance - update to gov.taho.xyz
FAQ - update to https://tahowallet.notion.site/Taho-Knowledge-Base-4d95ed5439c64d6db3d3d27abf1fdae5
Jobs - update to https://boards.greenhouse.io/tahowallet

https://taho.xyz/dao - Join Discord button

update to chat.taho.xyz

https://taho.xyz/dao - image with 4 quadrants

Discord → chat.taho.xyz
Governance forum → gov.taho.xyz
Community Workspace → https://tahowallet.notion.site/

Found two last things just now on the pledge page - https://taho.xyz/web3pledge/
In section: Now imagine a community-owned wallet that actually embodies and protects Web3 values—a wallet that’s available to anyone, anywhere on Earth, that can finance itself, that’s governed by a DAO, -->
update the link to  https://taho.xyz/dao/
And the preview image of the pledge on Twitter and Discord shows Tally Ho.


deviceQuery succeed in xavier host , but failed in docker

System information

OS Platform and Distribution (Host: Linux Ubuntu 18.04 ):
Apollo installed from (source or binary):
Apollo version (3.5):
-Docker verion dev-aarch64-20170927_1111:

Steps to reproduce the issue:
build cuda samples
run "deviceQuery", it returns:
cudaGetDeviceCount returned 38
-> no CUDA-capable device is detected
Result = FAIL
but on xavier host, run "deviceQuery", it passed.
I modified "./docker/scripts/dev_start.sh", mapping host directory then run ldconfig:
case "$(uname -s)" in
Linux)
volumes="${volumes} -v /dev:/dev
-v /media:/media
-v /tmp/.X11-unix:/tmp/.X11-unix:rw
-v /etc/localtime:/etc/localtime:ro
-v /usr/src:/usr/src
-v /lib/modules:/lib/modules
-v /usr/local/cuda:/usr/local/cuda:rw
-v /usr/local/cuda-10.0:/usr/local/cuda-10.0:rw
-v /usr/lib/aarch64-linux-gnu/tegra:/usr/lib/aarch64-linux-gnu/tegra:rw
-v /usr/lib/aarch64-linux-gnu/tegra-egl:/usr/lib/aarch64-linux-gnu/tegra-egl:rw"
"/usr/lib/aarch64-linux-gnu" is not mapping, use docker its own, but did some library linking, as below:
/usr/lib/aarch64-linux-gnu/libdrm_nvdc.so -> tegra/libdrm.so.2
/usr/lib/aarch64-linux-gnu/libcuda.so -> tegra/libcuda.so
/usr/lib/aarch64-linux-gnu/libdrm_tegra.so -> libdrm_tegra.so.0.0.0(copy from host)
Am I missing something that caused this issue? how I can I configure docker base on dev-aarch64-20170927_1111
Supporting materials (screenshots, command lines, code/script snippets):
btw, tegrastatus return correct:
nvidia@in_dev_docker:/apollo$ ./tegrastats
RAM 2786/15690MB (lfb 1x4MB) SWAP 720/7845MB (cached 36MB) CPU [10%@1190,1%@1190,0%@1190,2%@1190,0%@1190,1%@1190,0%@1190,0%@1190] EMC_FREQ 0% GR3D_FREQ 0% AO@40C <EMAIL_ADDRESS>Tboard@41C <EMAIL_ADDRESS>AUX@40C <EMAIL_ADDRESS><EMAIL_ADDRESS>PMIC@100C GPU 155/155 CPU 465/465 SOC 776/776 CV 0/0 VDDRQ 0/0 SYS5V 1498/1498
RAM 2786/15690MB (lfb 1x4MB) SWAP 720/7845MB (cached 36MB) CPU [11%@1190,2%@1190,0%@1190,0%@1190,0%@1190,0%@1190,0%@1190,0%@1190] EMC_FREQ 0% GR3D_FREQ 0% AO@40C <EMAIL_ADDRESS>Tboard@41C <EMAIL_ADDRESS>AUX@40C <EMAIL_ADDRESS><EMAIL_ADDRESS>PMIC@100C GPU 310/232 CPU 465/465 SOC 932/854 CV 0/0 VDDRQ 0/0 SYS5V 1620/1559

update:
sudo ./deviceQuery   PASSED!
./deviceQuery always Failed!
chmod 777 /dev/nvidia* not works!
so, run perception/camera...test
[NVBLAS] No Gpu available
I cannot run the test with root privilege.


Error response from daemon: Cannot locate specified Dockerfile: Dockerfile

Problem encountered on https://dotnet.microsoft.com/learn/aspnet/microservice-tutorial/docker-file
Operating System: macos
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

File Structure:
Controllers			Properties			appsettings.Development.json	myMicroservice.csproj
DockerFile			Startup.cs			appsettings.json		myMicroservice.sln
Program.cs			WeatherForecast.cs		bin				obj
Dockerfile:
FROM mcr.microsoft.com/dotnet/core/sdk:3.1 AS build
WORKDIR /src
COPY myMicroservice.csproj .
RUN dotnet restore
COPY . .
RUN dotnet publish -c release -o /app
FROM mcr.microsoft.com/dotnet/core/aspnet:3.1
WORKDIR /app
COPY --from=build /app .
ENTRYPOINT ["dotnet", "myMicroservice.dll"]

@shirhatti can you please help?

@nishanil


v2 Testing: Observed issues and suggested improvements

As stated in my last comment in #10, I was able to test the v2 and noticed the following behaviors:
Issues:

When a Connect-MgGraph error occurs, the script incorrectly reports "Successfully connected to Microsoft Graph".
This can easily be reproduced by incorrectly setting one of the 3 key variables, for example. In my testing, I tried to delete the certificate used to authenticate the App in Azure and this is what happened:

The error itself is of course expected in this example, but the script fails to catch the error and instead incorrectly continues as if no error had occurred.

Connect-MgGraph is missing the -NoWelcome argument, like in the previous v1 script:
https://github.com/ugurkocde/IntuneAssignmentChecker/blob/59d2c6334fdf091e2afde46eae0e9007be82fa94/IntuneAssignmentChecker_v2.ps1#L88

So far, it seems to be the only real issues I've noticed. I will update this post accordingly if I find new ones.

Suggested improvements:

A small adjustment can be made to how the script exits, by adding Disconnect-MgGraph | Out-Null right before exit here: https://github.com/ugurkocde/IntuneAssignmentChecker/blob/59d2c6334fdf091e2afde46eae0e9007be82fa94/IntuneAssignmentChecker_v2.ps1#L2045-L2046
This ensures the MS Graph token gets cleared each time the script is exited using the option "8". This is desired to improve reliability and security, in case of configuration changes, for example. | Out-Null allows for a silent output of the command, as it lacks an argument similar to -NoWelcome for Connect-MgGraph. So it's probably the closest to that behavior we can achieve by redirecting the output to $null.

Thank you again for this awesome script!

Have a look at the new updated v2 script. I added your idea and the fix for the connect-graph command.
Thanks for your Issue 👍


Feature/issue 1031 window icon

Adds the ability to set the window icon at runtime.
resolves #1031
based on feedback from this PR: #1163
https://user-images.githubusercontent.com/8339817/120373742-0034ef80-c319-11eb-98e0-178b7fa98de7.mp4
Notes: since there was some confusion, winit does support changing the window icon at runtime.
Outstanding work:

[x] Feature Gating for non X11/Wayland/Windows? It is already feature gated on winit size, so I think it is fine to keep it like this on bevy side.
[ ] Document how to work with window icons; especially Wayland

I really appreciate this feature request, and other than some of my initial comments, this looks good so far :)

Thanks for the quick review and the nice comments. Makes you really feel welcomed :).
About the whole Handle thing:
I understand why cart was pushing for it in the old PR. Using bevy_asset to handle the icon loading just makes sense.
But I am not sure, if this is the best solution.
In 99% of the cases, people will want to set the icon once, at the very start in the WindowDescriptor and as far as I understand at that point you have no way to get a Handle. That means you will have to manually load the asset and set the icon in you setup system.
Actually changing the icon at runtime (where bevy_asset is the most logical solution) I would assume is not something most people will do.
Ideally we would find a way to do both with Handle, but a simple (data,width,height) struct might be the most generic solution, that would also allow someone to include_bytes the icon.

I agree with your assessment on use cases; I would in fact be mildly alarmed if my icon changed at runtime!
I personally think that synchronous, blocking image loading may be the correct choice here because it maps onto the use cases better and avoids the circular dependencies.

Actually changing the icon at runtime (where bevy_asset is the most logical solution) I would assume is not something most people will do.

This is true, however just because most people may not want this functionality, does that me we should remove the possibility?

Ideally we would find a way to do both with Handle, but a simple (data,width,height) struct might be the most generic solution, that would also allow someone to include_bytes the icon.

I'm not the biggest fan of this approach as it's very easy to mess up just using Vec<u8> as the pixel data. And as a user, it's not easy to actually generate that data.

In 99% of the cases, people will want to set the icon once, at the very start in the WindowDescriptor and as far as I understand at that point you have no way to get a Handle. That means you will have to manually load the asset and set the icon in you setup system.

Yes this is the tricky part. I'm also in agreement with cart that we should use bevy_asset (e.g. the AssetServer to accomplish this). However, I also agree that it would be nice for this to be set in the WindowDescriptor... so I guess I'm a little torn.
Some possible paths forward:

Add an Option<Handle<Texture>> field to the WindowDescriptor so it is possible to set it on startup. This way someone could manually creates an asset (not via the AssetServer).
Allow setting/changing the icon at runtime. That way someone can utilize the AssetServer to create a handle to the appropriate texture and then set the icon in a startup system.
Perhaps have the WindowDescriptor have an Option<PathBuf> so that we can specify what file/asset we want the icon to be, and then inside our window logic, try to load an asset that is pointed to by the PathBuf. This way we can still utilize the AssetServer and the user can set the icon at startup.

Hmm yeah theres a bit more nuance here than I initially thought. Heres my current take:

Expose a set_icon_bytes(bytes: Vec<u8>) operation and set_icon_path(path: &Path) on window
Add a icon_path: Option<PathBuf> to WindowDescriptor and Window (but don't do anything to load it in bevy_window or bevy_winit as that violates the dependency tree). WindowDescriptor is only for queuing up new windows, not for polling runtime state.
In bevy_render, add a system that: detects new windows and queued SetIconPath operations, grabs their icon_paths, triggers loads, stores WindowId->Handle<Texture> maps for windows waiting on loads (holding the handle ensures it isnt dropped), and polls load status of each texture in that list until it either succeeds or fails. On success, it looks up the Texture and calls window.set_icon_bytes(), then removes the WindowId->Handle<Texture> mapping from the list, which drops the texture handle (which triggers a drop of the texture).

I do think supporting Handle<Texture> would be nice, but I think its cleaner to keep bevy_render a level above bevy_window (and this also allows bevy_window to be used without bevy_asset, which is an added benefit).
Ultimately (3) could be simplified once we add "async/await on AssetServer in systems", but that will take some time :)

I really like where this implementation is going, it's starting to look quite a bit better :smile:
In response to my comments I left above, here are some viable solutions:
An icon can either be a:

PathBuf
Vec<u8> + UVec2

When it's set as a PathBuf you don't add it to the queue yet. You simply store the path and then have a separate system (similar to your window_icon_changed function which will load the texture asynchronously, then when it's loaded, queue it up and send the bytes to winit.
When it's the bytes directly, you can just add it directly to the queue.
So I would personally have the SetIcon command to only be able to hold the bytes directly, and never hold path :)
Let me know if this makes sense or feel free to ask more questions!
I'm also always available on the discord if you want to message me there!!

I really like where this implementation is going, it's starting to look quite a bit better smile
In response to my comments I left above, here are some viable solutions:
An icon can either be a:
* `PathBuf`

* `Vec<u8>` + `UVec2`

Yes, makes sense.

When it's set as a PathBuf you don't add it to the queue yet. You simply store the path and then have a separate system (similar to your window_icon_changed function which will load the texture asynchronously, then when it's loaded, queue it up and send the bytes to winit.

What if someone does:
set_icon(path); ...(later) set_icon(path);
With the same path.
So far I am have been operating on the understanding that I would not load anything again if the path did not change, but maybe that is not a scenario I should consider?
-> User-Error :D?

When it's the bytes directly, you can just add it directly to the queue.
So I would personally have the SetIcon command to only be able to hold the bytes directly, and never hold path :)

Since bevy_winit can not do anything with SetIcon if it has a path I agree.
Should only have bytes.

Let me know if this makes sense or feel free to ask more questions!
I'm also always available on the discord if you want to message me there!!

I implemented a alternative version just using window.icon().
I still busy check if a change has happened, but that was true in the previous version as well.
The upside: We do not need to expose command queue anymore and it should not matter when the icon_changed system in bevy_render runs anymore.
The downside: The system is noticeably more noisy. It is probably possible to condense it somehow, but I am not yet sure how.

Sorry for the long absence.
What should I do to get this PR mergable?
@NathanSWard btw. Not sure who you are on discord. I assume "Bakuta", but I could not find a link between that account and you github account :D

@NathanSWard btw. Not sure who you are on discord. I assume "Bakuta", but I could not find a link between that account and you github account :D

Yep, that's me :) feel free to ping me there whenever!
I think my nickname is Nathan [🍞👑] on the server also.

I think this is done now. Happy to do any necessary changes though.

Hmm, this mostly looks good but I'm not sure whether we should couple this to bevy_render - it feels like this'd be more at home in bevy_winit. Though that'd mean we can't use bevy_render textures for window icons, but perhaps we shouldn't be doing that anyway.

I do think it is worthwhile to question the approach.
In #1163 a simpler solution was implemented, similar to using WindowIconBytes directly for this solution. But there was demand to make it work within the bevy_asset "ecosystem".
In fact this PR was initially only covering a similar usecase of the old PR and only afterwards I was trying to make it work with Assets.
As you have said using Texure was not possible because of cyclic depencencies, so cart came up with the idea that is currently implemented here.
I guess it might be possible to remove the bevy_window dependency from bevy_render, but I am not sure that the motivation for all this work is justified (just to make icons works with textures :D).
You mention not using textures - but does that not mean not using bevy_asset?

What's needed for this to be merged? I could use this feature.

https://github.com/bevyengine/bevy/blob/cba2b2effc5867d34f39e3e6573a3bd1b3513f14/crates/bevy_winit/src/lib.rs#L47
Is exclusive_system() always guaranteed to run on the main thread (now and in the future)?
If we can't always guarantee this, I'd suggest we add an assert to the change_window system. I just spent an inordinate amount of time trying to figure out why a Bevy app was hanging on startup intermittently. Turns out it was a system calling set_window_icon() running in the compute task pool instead of the main thread.
While this isn't an issue specific to this PR - in fact this PR will help prevent this mistake - I'd like to be doubly sure no one else needs to debug this issue in the future😆. An assert that is almost never triggered but can panic, is way better than mysterious intermittent application hangs.

Is exclusive_system() always guaranteed to run on the main thread (now and in the future)?

Now yes, in the future maybe.  See #3973 for my thoughts on how we could evolve the API. TL;DR: I think we need to split "main thread" from "not send and sync", where the former is a special case of the latter.

I'd suggest we add an assert to the change_window system
I approve of this!

Now yes, in the future maybe. See #3973 for my thoughts on how we could evolve the API. TL;DR: I think we need to split "main thread" from "not send and sync", where the former is a special case of the latter.

If #4027 is merged, it would resolve this issue because it would force the change_window() system to use world.get_non_send::<WinitWindows>().unwrap(); instead of world.get_resource::<WinitWindows>().unwrap();.

This seems done? There are some conflicts, but I can't seem to find any "github conflict ui" here anymore.

@janus-culsans @lukors this PR seems relatively abandoned (sorry for the long limbo); if one of you are interested, pulling up a new rebased PR with a link to this thread and credit to @KirmesBude would help move this along.

Yes, I would be interested.

This pr is from license change so it can't be used as a basis... you would pretty much have to not look at its code to redo it

I can't even merge their branch into a new fork with attribution, even though it was MIT before?
That's funny.

yes, the repo is now dual licensed MIT / Apache 2, so merging this PR would change its license without the author authorisation

Closing this out; I don't think we're getting a relicense at this point and it's better to avoid misleading folks.

All PR authors were pinged several time at the relicensing time... you could try pinging them again, maybe they are active again after a few months of inactivity.

Based on the following comment, is anyone able to reopen this PR now @mockersf @alice-i-cecile ?

I can reopen it, but I'd prefer #5488 as we'll likely need a bit more back-and-forth :)

Just looking through the history of this story —

From May 28, 2021, to June 19, 2021, @KirmesBude and @NathanSWard worked on https://github.com/bevyengine/bevy/pull/2268, and then PR went dormant.  A challenge here was that there was a licensing change, apparently from MIT to MIT/Apache-2.0 (dual license), and @KirmesBude  didn't see the request to re-license the work until significantly later, so at the time people proceeded under the assumption that the PR should be avoided in order to prevent unintentional copying.
From July 29, 2022, to August 29, 2022, @alt0173 and @alice-i-cecile worked on https://github.com/bevyengine/bevy/pull/5488.  The PR became blocked on another dependency, and @alt0173 eventually deleted the repo, at which point the PR was automatically closed.

The first PR is now re-licensed, and an attempt to rebase it off of latest main could be made.  Not sure which of the two implementations would be preferable.


Feature request: Stand alone query: Provide Mechanism to save query you dont own

💬 Request for Comments

In stand alone query when you open a query you don't own, there is no option to copy over or save your changes as your own query.
Implementation Plan

Provide a clone/save as button for queries you don't own. You would then copy over the current query and its context with the current user as the owner.

This has been implemented, the create query button is definitely there. I think if you don't see the save/create a new button pair in a query that you own, that's probably a bug with how we compute ownership of query, so closing this issue for now.
https://user-images.githubusercontent.com/13574879/140612254-d210409f-9fa6-4a0e-9185-638a81df43f4.mov


403 Forbidden Responses as anonymous user should be 401 Unauthorized

What is the bug?
On a cluster with anonymous access enabled, when I try to access a resource for which I do not have permissions then I receive a 403 Forbidden response
e.g.
< HTTP/1.1 403 Forbidden
< Content-Type: application/json; charset=UTF-8
< Date: Thu, 05 May 2022 06:09:13 GMT
< Transfer-Encoding: chunked
<
* Connection #0 to host opensearch left intact
{"error":{"root_cause":[{"type":"security_exception","reason":"no permissions for [indices:admin/get] and User [name=opendistro_security_anonymous, backend_roles=[opendistro_security_anonymous_backendrole], requestedTenant=null]"}],"type":"security_exception","reason":"no permissions for [indices:admin/get] and User [name=opendistro_security_anonymous, backend_roles=[opendistro_security_anonymous_backendrole], requestedTenant=null]"},"status":403}

According to RFC 2616 a 403 Forbidden means

The server understood the request, but is refusing to fulfill it.  Authorization will not help and the request SHOULD NOT be repeated.

A 401 Unauthorized would be correct here as authentication is required.

The request requires user authentication

This is causing interoperability issues with https://github.com/lmenezes/cerebro which rightly does not request credentials to authenticate after a 403 Forbidden response.
Wikipedia states

HTTP 403 provides a distinct error case from HTTP 401; while HTTP 401 is returned when the client has not authenticated, and implies that a successful response may be returned following valid authentication, HTTP 403 is returned when the client is not permitted access to the resource despite providing authentication such as insufficient permissions of the authenticated account.

How can one reproduce the bug?
Set up a cluster with anonymous access enabled
As an anonymous user, try to access a resource the unauthenticated user has no permissions for and observe that a 403 Forbidden error is returned.
What is the expected behavior?
A 401 Unauthorized response instead of 403 Forbidden when unauthenticated users try to access resources they do not have permissions for.

[Triage] You're right. There is an ambiguity to this area. Thank you for reporting this. As this is a breaking change w.r.t backwards compatibility, we're not going to change the response code in 2.0 release, but we'll keep this proposal in mind if there is an opportunity to update the behavior.


Uploading to two different buckets

Is there an easy way to set up multiple evaporate-directives in the same application, so they upload to different S3-Buckets? E.g. I have a form with two evaporate-input elements and one of them should upload to 'my-images.s3.amazonaws.com', the other one to 'my-apps.s3.amazonaws.com'.
It seems to me that because the 'eva'-provider produces a singleton, all instances of the evaporate-directive share the same config and this can't currently be done. Is that correct?
I would gladly provide a pull request for this, but I'm not entirely sure what would be the best way to implement this..

You're right about the current implementation and your proposition also totally makes sense. Would it be ok if I have a look at it within a few days?

Yes, that would be great, thank you! Let me know if I can help.
On 10 May 2016 9:13 pm, "Denis Zhbankov"<EMAIL_ADDRESS>wrote:

You're right about the current implementation and your proposition also
totally makes sense. Would it be ok if I have a look at it within a few
days?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/uqee/angular-evaporate/issues/9#issuecomment-218260374

It should work, but I don't want to move it from the prerelease version without tests. Would be great to get your help in that direction if you please, because I'm afraid I don't have much time for that in the coming weeks.


Add options for different spaCy models / different NER taggers

Right now, the set of spacy models that can be used is limited. That could be made  more flexible. In particular, the package should allow for different NER tagger, eg Stanford NLP’s Stanza library.
-- currently, allows for different spacy models.

Implemented in the branch relatio-v0.3 (method self.process_roles() of the Preprocessor() class)


#592 PHP RFC: Deprecate dynamic properties

fix #592

Hi, any chance of this being merged anytime soon?
Thanks in advance.

Hello @lucaspouchot, we are reviewing it and push it for next release


Insecure packages

I can't quite figure out how to allow the use of insecure packages without a shell variable.
When setting
nixpkgs.config.permittedInsecurePackages

I get
Failed assertions:
- In a flake setup, the options nixpkgs.* should not be
 used. Instead, rely on the provided flake outputs and pass in
 the necessary nixpkgs object

I'm using flakes. The full config can be found at

https://github.com/RyanGibb/nixos/blob/948e1a4ea7be2658cf4e0beb0f1878fe1ded1889/flake.nix#L194
https://github.com/RyanGibb/nixos/blob/948e1a4ea7be2658cf4e0beb0f1878fe1ded1889/nix-on-droid/default.nix

You need to pass an instance of nixpkgs with your config applied to nixOnDroidConfiguration:
{
    nixOnDroidConfigurations.default = nix-on-droid.lib.nixOnDroidConfiguration {
      modules = [ ./nix-on-droid/default.nix ];
      pkgs = import nixpkgs { config.permittedInsecurePackages = ...; };
    };
}

Thank you!


Datalake2Sentinel Connector

The Datalake to Microsoft Sentinel integration allows you to upload indicators from Orange Cyberdefense Datalake platform to Microsoft Sentinel.
New data connector for integration Datalake to Sentinel

JSON file with data connector definition
Short README with link to GitHub repository where integration code is located

@microsoft-github-policy-service agree company="Orange Cyberdefense"

Hello @cert-orangecyberdefense for SVG logo please follow below guidelines, I tried to correct the logo but was facing issue.

Logo needs to be in SVG format and under 5 Kb
Ensure raw file of logo does not have any of the following:

cls and style formats
embedded png formats
xmlns:xlink

Logo needs to be in SVG format and under 5 Kb
Logo scales well to fit in a 75 px square
SVG code file is formatted well for readability

Also for Solution, you need to add input file and solutionmetadata which is required to repackage solution. Please refer to any of the solution for more clarification. Input file is located inside data folder of the solution.

Hello @cert-orangecyberdefense for SVG logo please follow below guidelines, I tried to correct the logo but was facing issue.
1. Logo needs to be in SVG format and under 5 Kb

2. Ensure raw file of logo does not have any of the following:

cls and style formats
embedded png formats
xmlns:xlink

3. Logo needs to be in SVG format and under 5 Kb

4. Logo scales well to fit in a 75 px square

5. SVG code file is formatted well for readability

Also for Solution, you need to add input file and solutionmetadata which is required to repackage solution. Please refer to any of the solution for more clarification. Input file is located inside data folder of the solution.

Hello @v-prasadboke thank you for your reply. l have added the require files and will soon provide a new logo.

Thanks for commiting the required changes. Will take a look at it once.

Hello @cert-orangecyberdefense, Waiting for reply on Publisher ID

Hello @cert-orangecyberdefense, Waiting for reply on Publisher ID

Hi @v-prasadboke the update of the publisher ID is now ok, waiting for your approval to continue the process
Thanks


Replace files with edited copies

Purpose

...

Hopefully, no break in change?

[ ] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

Late night tinkering around, sorry for this mistake.


Format Yes/No fields in treasury output

Define and use a new "capitalize" helper in our output generation.
Fixes #394

@igor47 I did a manual pass opening up each export template file and searching for "yes" in the text of the sheet.  To update, I'd end up doing the same thing.
Yes, theoretically, we could generate the formatting rules along with our other rules.  Form my point of view, someone has to manually define the rule to apply to each logical column anyway, and I think putting that mapping in the input template just moves it further away from the code.
The less frequently we have to update the input template for partners, the better I think the experience is.


ModuleNotFoundError: No module named 'models.backbone'

Thanks for your wonderful jobs，but I got an error when trying to train a retinanet baseline:

$python train_coco.py --config-file models/retinanet/configs/coco/train.yaml --num-gpu 4 OUTPUT_DIR workdir
Traceback (most recent call last):
File "train_coco.py", line 9, in
from train_tools.coco_train import default_argument_parser, start_train
File "/disk1/qdworkspace/QueryDet-PyTorch/train_tools/coco_train.py", line 53, in
from models.backbone import build
ModuleNotFoundError: No module named 'models.backbone'

It seems that the program is looking for a file 'models.backbone' but there is no backbone.py in QueryDet-PyTorch/models/ ?

Please comment out this line and have a try. Additionally, you may need to modify the batch size to 8  if you are using 4 GPUs,.

There are still some modules not found in coco_train.py:

from detectron2_backbone.config import add_backbone_config
import detectron2_backbone.backbone.mobilenet

and the function add_backbone_config() is actually used in coco_train.py and coco_infer.py, how to deal with this?

Oh, I'm sorry, you will also need to install detectron2_backbone. I have updated the readme.

Thanks! I can run the training now.


Add a pull request template

[ ] Create a .github folder
[ ] Add a pull request template to the .github folder using this template

Hey, I would love to work on this.
Please can you add the following labels; hacktoberfest2023, hacktoberfest-accepted


Where we have to store environment variables.

Hello, I don't know anything about Go language, so it would be great, if you tell me, what type of file I have to make for the environment variables?

Environment variables are an independent concept unrelated to the programming language used.
How you set them depends on how you wish to deploy the bot:

CLI: set the environment variables inline like ATERNOS_SESSION=xxx ./aternos-discord-bot. That's how it works on linux. On windows it might be slightly different (just google it). You can also set the variables system wide, although that's not recommended.
docker: see readme. It's the -e flag.
kubernetes: see readme.
source code: create a .env file. You can use  env.example as a starting point (if it exists in the repo, can't quite remember).

Oh yeah never mind, that doesn't work. I was confused because it's a usual thing to do in Node but not Go. I updated my comment; it's the same step as CLI.

I've also updated the project README with clearer instructions on how to set the environment variables on your specific system and/or build form source.

Thanks


Switch to bundle-based replication rules

Instead of specify each component to replicate, require to insert Replication and use not_replicate_if for exclusion we should could specify bundles and their markers for replication. For example:
app.replicate::<CityBundle>();

#[derive(Bundle)]
struct CityBundle {
    transform: Transform,
    city: City,
    ...
}

// Could be a macro?
impl ReplicationMarker for CityBundle {
    fn replication_marker(world: &World) -> TypeId {
        TypeId::of::<City>()
    }
}

So instead of iterating over all entities with Replication we could iterate over all entities with special markers and replicate only components from the list.
This will require more check on archetype:
https://github.com/lifescapegame/bevy_replicon/blob/ecb264477e353bda6550603b5fdd5e50c5d53b7b/src/replication_core.rs#L130
But will completely remove this check:
https://github.com/lifescapegame/bevy_replicon/blob/ecb264477e353bda6550603b5fdd5e50c5d53b7b/src/server.rs#L180
I would expect this approach to work faster and be more user-friendly.

I decided to keep per-component approach for now and just refine it a bit by replacing not_replicate_if with Ignored<T>.
Per-component approach have some pros:

No macro required at all, everything is done via plain generics.
It's very clear for user how to implement custom serialization for specific type.
It's obvious how it works. What if two bundles intersects? What if two bundles on entity represent a third bundle? What if you remove one component from a bundle, should we send removal to clients for the whole bundle or just stop replicating it?
Check if archetype contains a component is very fast, but system that track bundle insertion and insert markers may not be.


[Feature Request] Introduce minor randomness to click events

This might be a minor thing considering the situation, but I was wondering if it's possible to introduce some randomness to the region click events. This doesn't have to be anything major, just enough to make it seem like someone is hitting the button, instead of it being always in the center of the region.

I really think it is a nice way to prevent from banning. Cause in some games are banning players based on click behavior (epic seven)

FGO(JP) probably won't do this in the foreseeable future.

They (Kinoko and director) acknowledged that farming is bothersome.
https://news.fate-go.jp/2020/0130tubmg/ Only mentioned binary exploitation, explicitly.

I won't be worried about this - none of the users who use this script has been banned, myself included. And we're kind of "whales" cause we care this game enough that we got to use script to play it.
Pandemic outbreak is more concerning currently (sad but true).

Oh, I actually forgot this issue existed. While I agree it's not a must have, I did go ahead and changed stuff to fit for me a while ago. If you care enough, here's the function I added to utils.lua:
-- Take region and click on a random point within, to simulate a human touch.
function utils.RandomClick(region)
	if region == nil then
		return -1
	end

	local loc = Location(region:getX() + math.random(0, region:getW()), region:getY() + math.random(0, region:getH()))
	click(loc)
	return 1
end

As for the game.lua, I've changed pretty much everything into regions. Probably not something you can just copy/paste straight up, but I'll upload it to this post anyway.
regions.txt
As far as I'm concerned the issue can be closed, sorry for not answering earlier.


Updating Jenkins minimal version in README.md

Forgot to update README.md, please accept.

Hi @FulaiZhang-cn,
I've accidentaly missed the README.md file. Please check that as well.


StyleSheet.registerCompiled is not a function on fresh install of React Native and Nativewind 4.0.1

Describe the bug
I'm seeing this error with a fresh install of React Native
TypeError: _$$_REQUIRE(_dependencyMap[1], "(...)op").StyleSheet.registerCompiled is not a function (it is undefined), js engine: hermes
Same as reported last November: https://github.com/marklawlor/nativewind/issues/687
To Reproduce

Install react native from cli:

npx react-native@latest init reactNativeFreshInstall

Follow getting started instructions

https://www.nativewind.dev/v4/getting-started/react-native

Add missing dependency: react-native-css-interop

Reproduction repo
https://github.com/josephfh/react-native-nativewind-issue

Update! Using the newer version of this package (which was not being installed/found/something) in my react native app has fixed the above problem:
"react-native-css-interop": "0.0.22"
pnpm i react-native-css-interop only installs 0.0.13

FYI, I fixed it by removing react-native-css-interop from my dependencies.


fix: Remove unneeded column in s2s df

As per feedback on https://github.com/rungalileo/rungalileo/pull/792/files, we:

rename target_output -> target
no longer log tokenized_label in finalized df

Same thing happening here: https://github.com/rungalileo/runners/pull/423

Looks good. I'll let you figure out what's up with tests...

linting issue, fixed

Codecov Report

Merging #739 (1831e56) into main (bdc8876) will decrease coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 64.28%.

@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
- Coverage   89.73%   89.67%   -0.07%
==========================================
  Files         169      168       -1
  Lines       13635    13594      -41
==========================================
- Hits        12236    12190      -46
- Misses       1399     1404       +5

Files Changed
Coverage Δ

dataquality/clients/api.py
51.33% <ø> (+0.31%)
:arrow_up:

dataquality/loggers/data_logger/seq2seq.py
80.95% <ø> (ø)

dataquality/schemas/route.py
100.00% <ø> (ø)

dataquality/utils/profiler.py
56.25% <0.00%> (-0.46%)
:arrow_down:

tests/loggers/test_seq2seq.py
100.00% <ø> (ø)

dataquality/schemas/seq2seq.py
82.50% <50.00%> (ø)

dataquality/analytics.py
75.00% <66.66%> (-7.41%)
:arrow_down:

dataquality/loggers/base_logger.py
91.51% <100.00%> (ø)

...aquality/loggers/model_logger/base_model_logger.py
90.99% <100.00%> (-0.09%)
:arrow_down:

dataquality/utils/auto.py
95.00% <100.00%> (ø)

... and 6 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Jesse: Watch samsungmobilespecs.com

Jesse requests the watch of the watch_keyword samsungmobilespecs\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

samsungmobilespecs\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Searching for bugs, nothing to see here... hlevci

Searching for bugs, nothing to see here... hlevci

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Midi: remove velocity from sendNoteOffMessage

I think it is confusing to have an inconsequential velocity value included for a note off message, but I could see leaving the argument and defaulting it to zero for backwards compatibility...
Unless there's some situation where note off has a velocity that I'm not aware of??

I've never seen midi note off velocity used anywhere.


Appended selection of cip core packages for edge impulse integration

Needed to add the CIP_CORE variable for Edge Impulse

@matinlotfali Is this syill needed? I thought it was needed to run the edge impulse script on MistySOM (per Brennan - support guy from E.I.)

It might be needed in future if someone prefers the most compatibility and control over EdgeImpulse


ImproveOptimize logging performance with LOG.isDebugEnabled()

In a logging system, when the log level is configured to not output logs of a certain level, by checking LOG.isDebugEnabled() before the log output statement, the overhead of string concatenation can be avoided. When performing string concatenation, even if the log level does not meet the output condition, the string concatenation operation will still be executed, which can lead to unnecessary performance overhead.

run buildall

run buildall

run buildall

PR Run Status

Limitations and other issues: Failure - Unfortunately, this PR is too big for us to review. Please either conduct the review manually or break it into smaller PRs.  We are working to address this limitation in Bito.


Multiple JSON Delete/+sample buttons not functional

I'm using quicktype from a Windows 10 machine with chrome LTS.
I'm attempting to use the Multiple JSON source, but the delete & the +sample buttons aren't working.
I see this error being thrown in the console:
react-dom.production.min.js:101 Uncaught RangeError: Maximum call stack size exceeded
    at l.get (index.tsx:342)
    at l.get (index.tsx:342)
    at l.get (index.tsx:342)
    at l.get (index.tsx:342)
    at l.get (index.tsx:342)
    at l.get (index.tsx:342)
    at l.get (index.tsx:342)
    at l.get (index.tsx:342)
    at l.get (index.tsx:342)
    at l.get (index.tsx:342)

Repro steps

go here
select "Source Type" of "Multiple JSON"
click the trash icon
nothing happens (Error thrown)

this is a known issue, has been reported multiple times, and is almost 2 months old.
i've already tried to help in #1665 but no response so far.
i run into this issue every time i try to use quicktype, and i'd love to get this fixed. @schani @dvdsgl

Duplicate of #1665


Barber is incompatible with Dagger code generation

Hi -
Tracking this, so I wanted to put in an issue. When adding Barber to a project that already uses Dagger (and dagger-compiler) for injection, dagger code generation fails to run.
My setup is as such;
apt 'io.sweers.barber:barber-compiler:1.0.1'
compile 'io.sweers.barber:barber-api:1.0.1'
compile 'com.squareup.dagger:dagger:1.2.2'
provided 'com.squareup.dagger:dagger-compiler:1.2.2'

Can you give me a little more info? Stacktrace, does it happen even if you don't use any barber code, etc?

Can you give me a little more info? Everything still builds just fine for me if I add dagger to my dependencies.

If more than one annotation processor is used then this also has to be added to the build config:
android {
    packagingOptions {
        exclude 'META-INF/services/javax.annotation.processing.Processor'
    }
}

Ah yes, that's a good point. Would be better if @inktomi could provide some more clarification though

I'm so sorry. I've been out of town. I will try this tomorrow on a fresh project to ensure there was nothing else happening in mine..

Sounds good, thanks!

@inktomi any luck?

Hi, sorry for the delay.
I set up the following little test project. It shows the issue when you try to run it.
https://github.com/inktomi/BarberDagger
03-09 09:15:22.008    5388-5388/? E/AndroidRuntime﹕ FATAL EXCEPTION: main
    Process: com.mattruno.testdaggerbarber, PID: 5388
    java.lang.RuntimeException: Unable to create application com.mattruno.testdaggerbarber.TestApplication: java.lang.IllegalStateException: Module adapter for class com.mattruno.testdaggerbarber.ServiceModule could not be loaded. Please ensure that code generation was run for this module.
            at android.app.ActivityThread.handleBindApplication(ActivityThread.java:4521)
            at android.app.ActivityThread.access$1500(ActivityThread.java:144)
            at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1339)
            at android.os.Handler.dispatchMessage(Handler.java:102)
            at android.os.Looper.loop(Looper.java:135)
            at android.app.ActivityThread.main(ActivityThread.java:5221)
            at java.lang.reflect.Method.invoke(Native Method)
            at java.lang.reflect.Method.invoke(Method.java:372)
            at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:899)
            at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)
     Caused by: java.lang.IllegalStateException: Module adapter for class com.mattruno.testdaggerbarber.ServiceModule could not be loaded. Please ensure that code generation was run for this module.
            at dagger.internal.FailoverLoader$1.create(FailoverLoader.java:45)
            at dagger.internal.FailoverLoader$1.create(FailoverLoader.java:40)
            at dagger.internal.Memoizer.get(Memoizer.java:56)
            at dagger.internal.FailoverLoader.getModuleAdapter(FailoverLoader.java:57)
            at dagger.internal.Modules.loadModules(Modules.java:43)
            at dagger.ObjectGraph$DaggerObjectGraph.makeGraph(ObjectGraph.java:174)
            at dagger.ObjectGraph$DaggerObjectGraph.access$000(ObjectGraph.java:138)
            at dagger.ObjectGraph.create(ObjectGraph.java:129)
            at com.mattruno.testdaggerbarber.TestApplication.onCreate(TestApplication.java:16)
            at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1011)
            at android.app.ActivityThread.handleBindApplication(ActivityThread.java:4518)
            at android.app.ActivityThread.access$1500(ActivityThread.java:144)
            at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1339)
            at android.os.Handler.dispatchMessage(Handler.java:102)
            at android.os.Looper.loop(Looper.java:135)
            at android.app.ActivityThread.main(ActivityThread.java:5221)
            at java.lang.reflect.Method.invoke(Native Method)
            at java.lang.reflect.Method.invoke(Method.java:372)
            at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:899)
            at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)

I see. Have you tried @denley's solution? I'm not very familiar with Dagger, so I'm not sure where to start with this since all the code looks like it's just dagger issues.
android {
    packagingOptions {
        exclude 'META-INF/services/javax.annotation.processing.Processor'
    }
}

I do have that included in the gradle file for the app module.. no affect though =\
https://github.com/inktomi/BarberDagger/blob/master/app/build.gradle

Hmm, I have no idea then. I'll try looking at it some this weekend, but no promises. Going to mark this as help wanted now as well

I just had a quick look and I think I've figured it out. It's actually not an issue with Barber (the same problem occurs when you remove the Barber dependencies). It appears to be an issue with the android-apt plugin ignoring the provided dependencies.
It will work with the following configuration instead (notice the apt instead of provided for the dagger compiler dependency):
apt 'io.sweers.barber:barber-compiler:1.0.1'
compile 'io.sweers.barber:barber-api:1.0.1'
compile 'com.squareup.dagger:dagger:1.2.2'
apt 'com.squareup.dagger:dagger-compiler:1.2.2'

Ah interesting, so someone can't use apt and provided in the same configuration?

It appears that way. The apt plugin seems to completely take over the annotation processing or something like that.

Interesting. Well, good to know. @inktomi can I mark this as resolved then?

Awesome. Thanks for the team effort!!


Can't start container tag 0.10.12

Can't start the image.
Stuck into:
overall progress: 0 out of 1 tasks
1/1: starting  [============================================>      ]

error message
using docker service logs --name
invalid boolean value "$ACME_AGREE" for -agree: strconv.ParseBool: parsing "$ACME_AGREE": invalid syntax

Also here: https://github.com/abiosoft/caddy-docker/blob/24eb76481d9ed3eaafda1d769749ce50b89ddec8/Doc
There should be spaces:
CMD [ "--conf", "/etc/Caddyfile", "--log", "stdout", "--agree=$ACME_AGREE" ]

I built the image using the space but I have the space issue.

I can't seem to reproduce this. What command did you use to start your container ?
Also, the source link shared above is broken.

Wow, you're fast. I was about to close the issue.
It's my bad, I only updated the Dockerfile (was running 0.10.10). I realized there is other deps outside the Dockerfile. All running smoothly now!

But the spaces should be fixed.
CMD [ "--conf", "/etc/Caddyfile", "--log", "stdout", "--agree=$ACME_AGREE" ]


Added styling to the two web pages.

Both pages are styled according to wireframe mockup
Page Two has a working thumbnail click function that brings up a modal box.

"thumbs up emoji"


XLM-R: pre-processing steps

Hi,
I'm very interested in the pre-processing steps for training a RoBERTa/XLM-R model from scratch 😅
BPE with sentencepiece
Could you provide the spm_train command that was used to create the sentencepiece model. Interesting part would be the --control_symbols (and their order), --unk_piece and --pad_piece.
BPE encoder
In my understanding, the next part after spm_train is the following:
 cat {train,dev,test}.txt | spm_encode --model=<model_file> --output_format=piece > {train,dev,test}.bpe

I would do that step with train, validation and test dataset. Is that correct?
fairseq preprocessing
fairseq-preprocess \
    --only-source \
    --trainpref train.bpe \
    --validpref valid.bpe \
    --testpref test.bpe \
    --destdir output \
    --workers 60

Are these the correct pre-processing steps?
My aim is to convert a trained model with the 🤗/Transformers and use it for various NLP tasks, so the correct tokenization/sentence piece model is one crucial part 😅
Thanks many in advance!

Hey,

Yes, so we follow the same process as XLM paper for training SPM model. The SPM model was trained only on subsample of data.  As the whole data seemed too big to train SPM model and we saw that subsample of data was good representative of vocab. While subsampling, we up/down sample language based on the probability formula mentioned in the paper with smoothing value of 0.7.
Rest all arg are default, so <unk> and <pad>.

Yes exactly.

That's exactly correct.

There were no other language specific tokenization or segmentation.


Add "select all" to points and shapes layer

Description
I propose to add a new checkbox "select all" for the points and shapes layer.
If checked, changes to the colors, size, and edge_width are propagated to influence all points/shapes of the respective layer.

Type of change

[X] New feature (non-breaking change which adds functionality)
[X] This change requires a documentation update

References
Similar ideas have been mentioned here:
https://github.com/napari/napari/issues/702
https://github.com/napari/product-heuristics-2020/issues/19
closes https://github.com/napari/napari/issues/2353

How has this been tested?

[X] the test suite for my feature covers all properties of Shapes and Points covered by my change
[X] all tests pass with my change

Final checklist:

[X] My PR is the minimum possible work for the desired functionality
[X] I have added tests that prove my fix is effective or that my feature works
[X] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

@mstabrin Thanks for the suggestion! However, I don't think this is the correct implementation — selection with a checkbox is a very non-standard UX design. Note that you might have missed that there is already a keyboard shortcut for this, "A".
I think the correct fix is to add an edit menu with all the standard edit menu choices, such as "Edit > Select all" "Edit > Cut/Copy/Paste", etc. However, I think that @tlambert03's app-model refactor (#4784) is probably a prerequisite for this. @tlambert03 what do you think? Is it worth adding an "ad-hoc" edit menu now or should we wait for app model to land?
In the meantime, I propose closing this PR as I don't see the tick box as the correct implementation in any context.
A final comment: in the early days of napari I made the point that since napari isn't a typing app, we could use keyboard shortcuts without modifiers, such as "V" (toggle visibility) and "A" (select all), in the style of Gmail/Fastmail and others. I still think that's the right model for most shortcuts (e.g. the mode changes for labels layer on 1-5), but, for standard shortcuts such as cut/copy/paste/select all that appear across almost all apps, I think we should use the standard Ctrl/Cmd+key. The main issue that this PR addresses is that the shortcut is not discoverable. But using a standard shortcut from ~all apps addresses discoverability quite well.

@jni Thank you for your input :) Maybe we can talk about the behavior of the "A" shortcut.
I am working a lot with 3D point layers in large volumes, i.e., up to 4kx4kx4k.
The "A" shortcut seems not to select all points of the layer, but only of the current visible slice.
Maybe I should look into the "A" shortcut implementation then? :)
It appears that multi-selection on non-visible slices is supported.

And we can close this PR :)

Ah! Damn. Yeah that's difficult, because we need a visual indicator of what's happening across slices. My suggestion after thinking about it for 10s: 😂

Cmd-A select all points in this slice, raise notification "Selected [n] points in this slice, use Cmd-Shift-A to select all points on layer."
Cmd-Shift-A select all points, raise notification "Selected [n] points across all slices, including [m] points not currently visible"

Ok I'll close this but we can keep discussing here until we come up with a path forward.

@jni I made a suggestion based on your suggestion at PR #4809.
I also added a "deselect" option in case the points are already selected similar to other Control-A behaviors in other software.


Fix URLs in setup wizard file download

URLs have double https:// / http:// for both TOR and LAN addresses in the downloaded file resulting from the setup wizard. See screenshot:

This is a consequence of us returning a URL and the UI prefixing it with a protocol. My preference would be to remove the UI prefixing.


Docs for arangoinspect

Initial draft. I'm not sure about the following:

For non-cluster deployments,
you may authenticate with a user name and password instead:
arangoinspect --server.ask-jwt-secret false --server.username "root" --server.password "foobar"

Is a JWT-secret only used in clusters, or also other deployment modes? Is it only possible to use username/password for single server instances?

Builds: https://docs.arangodb.com/review_arangoinspect/Manual/Programs/

Hi, are we all set for this PR? @Simran-B if yes, please remove the WIP label and I will merge.

@sleto-it There's still my open question:

Is a JWT-secret only used in clusters, or also other deployment modes? Is it only possible to use username/password for single server instances?

And Kaveh asked to remove the hint box about data privacy - we need a decision from you

Note to self: Also update text if needed in 3.3 regarding JWT secret - https://github.com/arangodb/arangodb/pull/5703