feat: Improve Error Reporting for Coverage Threshold Failures

This pull request attempts to pull out Jest coverage threshold errors when a test run fails due to Jest's coverage thresholds.
Currently, the error that comes back and that is displayed in the comment is:
Error: The process '/usr/local/bin/yarn' failed with exit code 1

The aim of this PR is to make that error show the actual error for a threshold failure:
(copied from test written)
 'Jest: \\"global\\" coverage threshold for statements (88%) not met: 79.68%\\n        Jest: \\"./some/path\\" coverage threshold for statements (45%) not met: 44.91%\\'

This will be formatted in the PR and should give the user an indication to what exactly is failing instead of having to parse the console output from the action.
This PR fixes #
Related (maybe closes)

https://github.com/ArtiomTr/jest-coverage-report-action/issues/233
https://github.com/ArtiomTr/jest-coverage-report-action/issues/227

@ArtiomTr - I have tried debugging this using a fork of the repo you mentioned.
I also tried to use act locally and still had similar results.
In https://github.com/ArtiomTr/jest-coverage-report-action/pull/250/commits/b3fbc5c926c1033f765fd905ff3b317e106758f0 I attempted to change the string entirely to make sure that my changes were being picked up. They are not.
I assumed that using @branch would work - but maybe it's not behaving as expected. I even committed the dist after figuring that may be the issue - to no luck though.
Do you have any other good ways to test this action - or maybe could shed some light on what I'm doing wrong?

@therynamo, action runs index.js file from the dist directory. So to test the action, you need to:

Build action using npm run build
Commit & push index.js file into your branch.
And don't forget to change pipeline configuration (.yml file) in the testing repository

# ...
using: therynamo/jest-coverage-report-action@branch

I recommend using the playground repository, that you can fork to test the action.
Make sure that you're using proper action version, it is displayed in pipeline console.
Hope this helps you!

Hey @ArtiomTr thanks for the response!
If you take a look at the PR https://github.com/therynamo/jest-coverage-report-action-test/pull/1 - the config is actually set up to point to this branch. I've been running it on CI and locally using act.
If you look at the CI run https://github.com/therynamo/jest-coverage-report-action-test/pull/1/checks - it does indeed say its using this branch - but if you look at the output you can see that no debug statements or i18 changes are reflected - even though i have run yarn build and pushed the dist directory up to this branch.
Have you had success testing this way in the past? I am not sure what I'm doing incorrectly - as I've looked over the run.sh script and theoretically what is in the PR I linked above should be working 🤷 .

@therynamo, I've suggested changes on your PR (https://github.com/therynamo/jest-coverage-report-action-test/pull/1/files#r838701555). Could you try using them? I think these changes might solve the problem.

@ArtiomTr - hey - thanks again for your suggestions on that fork I made. I can't believe I missed that 🤦 .
That did however allow me to test these changes - and here is the result:
https://github.com/therynamo/jest-coverage-report-action-test/pull/1#issuecomment-1082325357
Which leads to:

About using formatErrors function as a mechanism for reporting threshold errors - I would like to separate the threshold messages from the "errors", because I think these have different meanings:

Thresholds not met - action is doing everything correctly, there is an issue with tests.
Errors - some bug / unexpected behavior / bad configuration.

So right now using formatErrors it looks like so:

In my opinion this is pretty clear that my coverage is failing for reasons related to thresholds not being met. Plus the implementation was pretty straight forward. I can investigate more if option 1 is what we're really looking for. I will absolutely respect your design choice here as this is your action.
Some food for thought is that Jest does indeed exit 1 here when thresholds are not met. This is something I would want clear indication of. The fact that its highlighted by a code block is great because that's immediately where my attention goes as a user.

If you are fine with what it looks like in the above picture 🥳 . If not - I can take some more time to make it look more like the global threshold values. It may be more in depth though - and could end up being a much larger feature add. Again - totally fine - I'm just trying to narrow the scope to allow us to get some sort of MVP for this. We are currently not making our coverage deltas a "required check" right now because you have to click into the action and read the console output to find out that the coverage thresholds were not met. We want it to be as easy as possible for developers to see what exactly is failing their PR.
Anyway - thanks again for your awesome support and help in getting this into a good spot - you've been a great maintainer! 😄

Hey guys,
This PR helped quite a bit, I struggled for a while since the current state can be misleading. It looked like there is a bug with the action itself (and other users reporting similar issues send you further down that rabbit hole).
The emphasis on Error: The process '/opt/hostedtoolcache/node/16.15.1/x64/bin/npm' failed with exit code 1 is too high with it being wrapped in a code block, you almost never read Functions coverage not met... right under it.
Would be amazing to have this merged. Happy to help!


run --blkio-weight results in a panic

Description
If --blkio-weight is given to nerdctl run, nerdctl panics.
We may need to change this line:
https://github.com/containerd/nerdctl/blob/c00780a1f5b905b09812722459c54936c9e070e6/pkg/infoutil/infoutil.go#L249
to:
info := &dockercompat.Info{}

so that info won't be a nil pointer on the next line:
https://github.com/containerd/nerdctl/blob/c00780a1f5b905b09812722459c54936c9e070e6/pkg/infoutil/infoutil.go#L250
I'm happy to PR it, and I just want to make sure I'm not missing anything.
Re. why it's not caught by existing tests, my guess is that BlockIOWeight does not have unit tests because it's platform-dependent, and re. integration tests, TestRunBlkioWeightCgroupV2 seems to be skipped because bfq module is not loaded. I only checked a random recent workflow run, so I could be missing something.
Steps to reproduce the issue
lima nerdctl run --name ctr1 --blkio-weight 300 -w /sys/fs/cgroup alpine sleep infinity

Describe the results you received and expected
Received
➜  ~ lima nerdctl run --name ctr1 --blkio-weight 300 -w /sys/fs/cgroup alpine sleep infinity
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xa69f08]

goroutine 1 [running]:
github.com/containerd/nerdctl/pkg/infoutil.BlockIOWeight({0xdd21ec, 0x7})
	/go/src/github.com/containerd/nerdctl/pkg/infoutil/infoutil.go:250 +0x28
main.generateCgroupOpts(0xc5fd00?, {0x40002f81c0, 0x40})
	/go/src/github.com/containerd/nerdctl/cmd/nerdctl/run_cgroup_linux.go:244 +0x1584
main.setPlatformOptions({0x1100978, 0x40004c6000}, {0x400000e040?, 0x1?, 0x40?}, 0x0?, 0x0?, {0x40002f81c0, 0x40})
	/go/src/github.com/containerd/nerdctl/cmd/nerdctl/run_linux.go:72 +0x294
main.createContainer(0x0?, {0x1100978, 0x40004c6000}, 0x0?, {0x40002230e0?, 0x0?, 0x0?}, {0x0, 0x0}, 0x0, ...)
	/go/src/github.com/containerd/nerdctl/cmd/nerdctl/run.go:435 +0x2a0
main.runAction(0x400013a900, {0x40002230e0, 0x3, 0x9})
	/go/src/github.com/containerd/nerdctl/cmd/nerdctl/run.go:300 +0x12c
github.com/spf13/cobra.(*Command).execute(0x400013a900, {0x400003a0d0, 0x9, 0x9})
	/go/pkg/mod/github.com/spf13/cobra@v1.6.0/command.go:916 +0x5e0
github.com/spf13/cobra.(*Command).ExecuteC(0x400013a300)
	/go/pkg/mod/github.com/spf13/cobra@v1.6.0/command.go:1040 +0x360
github.com/spf13/cobra.(*Command).Execute(...)
	/go/pkg/mod/github.com/spf13/cobra@v1.6.0/command.go:968
main.xmain()
	/go/src/github.com/containerd/nerdctl/cmd/nerdctl/main.go:125 +0xc4
main.main()
	/go/src/github.com/containerd/nerdctl/cmd/nerdctl/main.go:108 +0x1c

Expected
The container should be run successfully with the specified --blkio-weight.
What version of nerdctl are you using?
➜  ~ lima nerdctl version
Client:
 Version:	v1.0.0
 OS/Arch:	linux/arm64
 Git commit:	c00780a1f5b905b09812722459c54936c9e070e6
 buildctl:
  Version:	v0.10.5
  GitCommit:	bc26045116045516ff2427201abd299043eaf8f7

Server:
 containerd:
  Version:	v1.6.8
  GitCommit:	9cd3357b7fd7218e4aec3eae239db1f68a5a6ec6
 runc:
  Version:	1.1.4
  GitCommit:	v1.1.4-0-g5fd4c4d1

Are you using a variant of nerdctl? (e.g., Rancher Desktop)
Lima
Host information
➜  ~ lima nerdctl info
Client:
 Namespace:	default
 Debug Mode:	false

Server:
 Server Version: v1.6.8
 Storage Driver: overlayfs
 Logging Driver: json-file
 Cgroup Driver: systemd
 Cgroup Version: 2
 Plugins:
  Log: fluentd journald json-file syslog
  Storage: native overlayfs stargz fuse-overlayfs
 Security Options:
  apparmor
  seccomp
   Profile: default
  cgroupns
  rootless
 Kernel Version: 5.15.0-52-generic
 Operating System: Ubuntu 22.04.1 LTS
 OSType: linux
 Architecture: aarch64
 CPUs: 4
 Total Memory: 3.816GiB
 Name: lima-default
 ID: a928eae4-cc94-427b-9e85-bcae448db4bd

WARNING: AppArmor profile "nerdctl-default" is not loaded.
         Use 'sudo nerdctl apparmor load' if you prefer to use AppArmor with rootless mode.
         This warning is negligible if you do not intend to use AppArmor.
WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled

HI @davidhsingyuchen, it has been fixed :-)


Issue when rewrite options  dropdown widget

Line 488
var options = $.extend({}, defaults, options);
Y can resolve this remove variable declaration.
options = $.extend({}, defaults, options);
Sorry for my english

this is fixed in the latest 0.97.8 and should be closed


CON-1243: Fixes to update Intel SGX to 2.18

Here we update Conclave to use Intel SGX 2.18.
This required some changes:

revert the usage of versioned Ubuntu packages in some Docker container, as we now can use the latest versions
Intel SGX SDK relies on the package libsgx_urts.so.2 to be installed instead of the previous version libsgx_urts.so. This means that our own patched version need to follow that name as well (this is where we have introduced the function sgx_configure_thread_blocking), if we do not rename our library, the SDK will pick up the default one from Ubuntu default dirs
add libboost-thread-dev which is now required for linking
update our C++ code to compile with C++17, to follow the Intel SGX SDK update
This allows us to get rid of conclave_tools.h file (where C++17 functionalities were added to C+11 code), together with the related C++ unit tests that were testing this.
A couple static_cast have been added because of the C++17 update.
sgx-emm/create_symlink.sh has been added to run in the main CMakeLists.txt, this is a new functionality used from Linux Kernel 6.0. Even though the functionality is not used in Kernel <6.0, the script is required, as the related headers need to be included, even when the functionality is not used
the dtv.patch that was applied in order to get rid of a segmentation fault issue present in the Intel SGX SDK, has been removed as Intel has now fixed such issue in the SDK itself
the patch QuoteGen_makefile.patch has been updated, as it could not be applied correctly
as Intel SGX SDK has changed the way the path /dev/sgx_enclave is used to determine the type of the driver we now need to pass /dev/sgx_enclave to the Docker containers so that they can resolve the symbolic link ./dev/sgx/enclave provided with --device=/dev/sgx/enclave

Looks good to me.


specifing a GPU index

Hi, I was wondering what is the 'cleanest' way to specify a GPU index to run on.
(e.g., if you have a machine with 8 GPUs, and you have been allocated GPU number 5)
I am currently able to do that by hacking the config_proto, but this means code duplication..
is there an option to do so?
Like, an option for running on one GPU, and at the same time specify which GPU id to use (like CUDA_VISIBLE_DEVICE).
At the moment, if I do not hack the config_proto, my experiments will just run on CPU (even if I use --worker_gpu or --ps_gpu)

I am using CUDA_VISIBLE_DEVICE and it works fine with Tensor2tensor.

thanks for the info.
seems not to work for me, but I assume some mistake on my part then..

Well, after double checking (and logging env variables), I think I am setting CUDA_VISIBLE_DEVICE correctly..
looking at the code, does anyone know where the CUDA_VISIBLE_DEVICE is (supposed to be) handled?
Like, if I look at the code where the config_proto is created, i.e.,
https://github.com/tensorflow/tensor2tensor/blob/master/tensor2tensor/utils/trainer_utils.py#L327
I see that no 'visible_device_list' is set.
So that I end up with:
gpu_options {
per_process_gpu_memory_fraction: 1.0
}
instead of (this is the one working - when I hack the config_proto):
gpu_options {
per_process_gpu_memory_fraction: 1.0
visible_device_list: "14"
}
Any insight?
Thanks a lot,
Mirko

The environment variable to be set is CUDA_VISIBLE_DEVICES. This is not dealt with by Tensor2Tensor or TensorFlow but is specific to CUDA. With the env var set, the process only sees those devices.

Closing for now as it does not seem that this is a bug. Please do reopen if you find differently.

I just confirm, I am using CUDA_VISIBLE_DEVICES, not CUDA_VISIBLE_DEVICE.

same here - using the correct one (the typo is just in this thread - sorry for that) - still, not working.
Just to be clear - my problem is that if I do not hack the code directly, tensor2tensor runs on CPU (not on the wrong GPU - it just falls back on CPU).
So, not sure there are some additional GPU option required to use a GPU (I tried the various option in t2t-train, but no luck) .
As I showed above, the problem seems to be that the config_proto is simply not specifying any visible device GPU id, i.e.,
gpu_options {
per_process_gpu_memory_fraction: 1.0
}

this is way it could help to know how tensor2tensor decides to run on GPU or CPU.
(is it enough to use a GPU compiled version of tensorflow? it would seem not from my experiment, given I am using that one)
Thanks again,
Mirko

Encounter the exact same problem. The couple of CUDA_VISIBLE_DEVICES and --worker_gpu turn out work not that well.


Snow layers don't place past the first layer

Only one layer of snow is places even if the schematic is for multiple layers of snow.

Snowblock layer getting is currently broken - I should fix it again


Optimized impl

Hey Christopher, I really hope you manage to put some time to review and merge this code. For me, it was impossible to run the code on a 10K dataset but this allows you to do it in a few minutes.
Please let me know if you have any questions or revisions.

Hi All! I just replaced the main code with this version and I can confirm this implementation is orders of magnitude faster.
On a 2490 dataset it took previously about 30 min, now it takes about 4 seconds.

Hi @christopherjenness , any chance you have time to review and merge this?


refactoring - protected

fixes #83 - Related issue
fixes #34 - Documentation
fixes #32 - Documentation
fixes #81 - Hot reload in examples
Before merge

[ ] remove the first commit (with a git rebase -i master)
[ ] take care of authors not to be deleted after rebase, if needed, to reset use something like : git commit --amend --author 'Fabien JUIF<EMAIL_ADDRESS>

Coverage remained the same at 98.462% when pulling 958b1ec18429effeb509ab9b714473c95943bf05 on refactoring-protected into b3f2b3a0d19b4dad54bd55ee98aff215dd4566ae on master.

@frinyvonnick can you take care of removing comment from a squash commit to avoid this please ?

Sure i can 👍

@frinyvonnick FYI
I am currently using lerna into my client project.
And I am right in this issue: https://github.com/lerna/lerna/issues/1114

Maybe we can close this PR ?

Yeah, sorry about this :(


Color Themes do not recognize multi-line variable declarations in JavaScript

VSCode Version: 0.10.11
OS Version: Windows 7 Ultimate N

Steps to Reproduce:

Open a JavaScript file (.js)
Enable the Dark+ color theme through the File > Preferences > Color Theme menu
Make a variable declaration, ending in a comma
On the next line, make a second variable declaration, ending in a semicolon.

Example:
var a = 0, // This variable will be stylized
    b = 0; // This variable will be not be stylized

This appears to be fixed in master :fireworks:


Pipeline will fail if fhir restore fails even if continue on fail is enabled

If fhir restore fails, the failure reason is now printed to the log.


CloudWatch v2

coverage: 78.795% (+0.2%) from 78.633%
when pulling b254803ed3a417276a20fab934d117cb532a5167 on dissoupov
into d6151cd166581702f146604cc70a303a7d9ff9ce on main.


Support Merge Test Results for Xplat Agent

Presently Xplat agent doesn't support merging of test results.
With this change, Xplat agent will publish merged test results and all the test files will be published in single archive.

looks fine


DIGITAL-197: Update Venue Field

Jira ticket

DIGITAL-197
Purpose

This PR will update the description of the venue field and setting it to be collapsed until the user would like to open and update it
Includes the following PRs that must be merged first

Deployment and testing
Local Setup

lando rebuild -y
QA/Testing instructions

visit http://digitalgov.lndo.site/node/add/event and check that the description has been updated and that is is collapsed and will open when the user selects it.
Checklist for the Developer

[x] A link to the JIRA ticket has been included above.
[x] No merge conflicts exist with the target branch.
[x] Automated tests have passed on this PR.
[x] A reviewer has been designated.
[x] Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

[ ] The file changes are relevant to the task objective.
[ ] Code is readable and includes appropriate commenting.
[ ] Code standards and best practices are followed.
[ ] QA/Test steps were successfully completed, if applicable.
[ ] Applicable logs are free of errors.

Boy, I see why you changed this to a inline entity form now. This took a little research, but here's the way to 'fix' this. https://www.drupal.org/project/paragraphs/issues/2921613.
Basically, if you don't leave this empty

then, the 'closed' editing option does nothing.


Performance tuning

We tried to integrate the library into GraphHopper but we are currently facing a rather big slow down. E.g. for this PBF we normally have an import time of around 23sec and with the latest integration this takes ~60-70s. For planet PBF the slow down exists too but the bigger problem in these cases are the memory errors like GC overhead limit exceeded that don't go away even with 20GB more RAM.
As the GC seems to be very active it could be also the reason for the slow down but I'm unsure as although I gave it several GBs it wasn't faster. I also tried to reduce the regex compilations with a cache but without success.
What only helped was to avoid calling limitSpeedsTo. For that I replaced createResultTags with:
if (exactRoadType != null) {
  val result = exactRoadType.tags.toMutableMap()
  result.putAll(tags.filter { !it.isImplicitMaxSpeed })
  return Result(exactRoadType.name, result, Certitude.Exact)
}

Is it possible to make calling this optional? The reduction of the other speeds is not really needed in our case as we would reduce it ourselves via Math.min which would be simpler+faster. (Or maybe do this only when fetched from the map but a custom map implementation would be necessary)
I tried to avoid the pattern matching and used indexOfs instead and the improvement was significant but not enough for us (only down to 33sec).

Do you have a benchmark result, i.e. how much time was spent in which functions?
I see a few places that maybe could be optimized, namely the new instance creation of the Regexes (or the use of the regexes altogether) and the copying of lists and maps. But it would be preliminary optimization without seeing if it actually matters.

limitSpeedsTo is not optional, otherwise the library would output for input of e.g.
maxspeed=60
highway=motorway

e.g. an HGV speed like this
maxspeed:hgv=100

(because the legislation says that a HGV may not go faster than 100, but that also means that it may not go faster than any general speed limit posted; the mentioned function guarantees that).
The requirement of this library is certainly to be correct, so I don't think we can refrain from doing that.

I tried to avoid the pattern matching and used indexOfs instead and the improvement was significant but not enough for us (only down to 33sec).

That's nice, though. Please feel free to create a PR for that already. (One thing after another.)

What would probably somewhat speed up the results for large input data - independent of any performance optimizations within this library - would be to cache the results. I.e. have a map like
// Map<input tags, result>
Map<Map<String, String>, LegalDefaultSpeeds.Result>

and only calculate it if not already present in the map.
The memory hog-ness of such a cache could be somewhat reduced if only the tags on the way relevant to default speed limits would be considered.

Is it maybe the conditionals-stuff that takes this long?

Actually, regarding the cache: One can just use a (large) LRU cache to guarantee it to not exceed a certain memory limit and the most common taggings are memorized.

I've just replaced the creation of a list and removing elements from there with doing the same with a sequence. Let me know if it makes any difference.

Regarding the conditionals stuff, the current situation is a bit awkward:
The Python parser of the wiki page outputs speed limits in the JSON like this:
"tags": {
  "maxspeed": "100",
  "maxspeed:goods": "80",
  "maxspeed:goods:conditional": "70 @ (weightrating>3.5); 60 @ (weightrating>12)",
},

only for the kotlin library having to pull apart and glue back together these values again in the limitSpeedsTo function.
It may be easier to consume if the output of the JSON generator would be e.g. something like this (or similar):
"tags": {
  "maxspeed": {
    "speed": "100"
  },
  "maxspeed:goods": {
    "speed": "80",
    "conditionals": [
      {"speed": "70", "condition": "weightrating>3.5" },
      {"speed": "60", "condition": "weightrating>12" },
    ]
  },
},

However, the only thing that would saved would be

the splitting of the string by "; "
the splitting of the substring by " @ "

So, not sure if this does really make such a difference, given to change this one has to both change the python script and also the kotlin library parsing it.

So, how much of this overhead is the splitting of strings with ; and @?

Ah, I see. I'd imagine that creating another hashmap for every single road instead of modifying the input map could be a source of overhead.
Something like
fun getRoadType(
        countryCode: String,
        tags: Map<String, String>,
        relationsTags: List<Map<String, String>> = emptyList(),
        replacerFn: (name: String, evaluate: () -> Boolean) -> Boolean = { _, ev -> ev() }
    ): AnotherResult?

where AnotherResult would contain the certitude, the matched road type name and the "raw" tags associated with that road type.

But uhm, as I wrote, a lru cache that caches the results associated by their input values (output for the same input values will be the same, after all) will solve any performance issues.

You could use async-profiler to track CPU usage and memory allocations.

That a cache has very little effect or even a negative effect really puzzles me... how can effectively not calling the library (i.e. only call it for uniques) be about as fast as calling the library?
Though, that the key of your cache is a string is a little suspect. Might be a bit costly to create a string from each and every tags of each and every road segment. I'd have created a data structure with hashCode that'd contain the tags map, country alpha2.

Yes, but the String concatenation is avoidable.

JMC also provides a solid automated analysis which might help here :)
https://www.oracle.com/java/technologies/javase/products-jmc8-downloads.html

I see you already did! Some notes:

btw: would you be able to release a new version?

Could do, need to check if I have the keys with me (I'm traveling right now)

So, the string splitting does make a difference after all?

You mean master vs. 1.2? Have not tested it and always used master since then.

No, I mean the splitting of the strings done here
https://github.com/westnordost/osm-legal-default-speeds/blob/1554cc5a5d0c20d2bd71b1dcfa92cbab3acd6172/library/src/commonMain/kotlin/de/westnordost/osm_legal_default_speeds/LegalDefaultSpeeds.kt#L237-L240
which would be avoidable if the JSON was changed like here suggested here https://github.com/westnordost/osm-legal-default-speeds/issues/7#issuecomment-1558760541


Values not updating

I am trying to use this code to send data to Blynk as an output rather than serial.
The values seem to not update throughout most of the day.
Any ideas?
Thanks

Have you checked to see if this is because of the checksum value being incorrect? I have noticed on my test bench that the checksum sometimes is not correct and this is why I have had issues with my values updating. A better and shielded connector resolves this problem for me.

Same for me. Keeping the values for about 15 measurements, independent of any timer or whatever.. After it stops and only keep working again if I reset my esp. Wouldn't it be possible to simply delete/ignore  the wrong data if the checksum isn't correct? I'm not that great in programming, so just an opinion.

Short update: neither with another cable, nor with another esp or different timings it does work. It's not the checksum, seems like the communication freezes and after ~2 minutes, you'll always receive the exactly same data. Tried in blynk and tried via serial :( any suggestions?

For me the config.h fields were not correct for the latest victron update, so my checksum was never valid. I ended up rewiting most of the data retrieval, which i packaged in a library here https://github.com/metrafonic/arduino-vedirect

Hey @metrafonic,
would have greatly appreciated a pull request with new config.h settings for different firmware.
A note on your new implementation, it uses the .readStringUntil() command, which is a blocking command. This library was purposely written to not use any of the blocking serial read commands, as it will mess with other loops on the ESP. For example TCP/IP / MQTT etc.


dtype must be explicitly provided

Hi, I followed the instructions in the README but with the carla server running, when try to run a client I get the following error:
:/app# python client/train.py --config client/config/a2c.yaml
Environment 0 running in port 2000
Trying to make client on port 2000
Environment 1 running in port 2003
Trying to make client on port 2003
Environment 2 running in port 2006
Trying to make client on port 2006
Environment 3 running in port 2009
Trying to make client on port 2009
Environment 4 running in port 2012
Trying to make client on port 2012
Environment 5 running in port 2015
Trying to make client on port 2015
Environment 6 running in port 2018
Trying to make client on port 2018
Environment 7 running in port 2021
Trying to make client on port 2021
Successfully made client on port 2000
Traceback (most recent call last):
File "client/train.py", line 301, in
main()
File "client/train.py", line 117, in main
video_every=args.video_interval, video_dir=os.path.join(args.save_dir, 'video', experiment_name))
File "/app/client/envs_manager.py", line 45, in make_vec_envs
envs = VecPyTorchFrameStack(envs, num_frame_stack, device)
File "/app/client/envs_manager.py", line 139, in init
low=low, high=high, dtype=venv.observation_space.dtype)
File "/home/user/miniconda/envs/py36/lib/python3.6/site-packages/gym/spaces/box.py", line 21, in init
assert dtype is not None, 'dtype must be explicitly provided. '
And from the server:
[2019.05.03-03.33.36:809][  0]LogContentStreaming: Texture pool size now 2000 MB
[2019.05.03-03.33.37:044][  1]LogLinux: Setting swap interval to 'Immediate'
[2019.05.03-03.33.37:044][  1]LogLinux: Warning: Unable to set desired swap interval 'Immediate'
ERROR:ERROR: tcpserver  tcpserver 2002 2000 : error reading message: End of file: error reading message: End of file
[2019.05.03-03.33.38:873][  3]LogCarlaServer: Warning: Client disconnected, server needs restart
[2019.05.03-03.33.38:873][  3]LogCarlaServer: Restarting the level...
[2019.05.03-03.33.38:885][  4]LogNet: Browse: /Game/Maps/Town01?Name=Player?restart
[2019.05.03-03.33.38:896][  4]LogLoad: LoadMap: /Game/Maps/Town01?Name=Player
[2019.05.03-03.33.41:203][  4]LogAIModule: Creating AISystem for world Town01
[2019.05.03-03.33.41:399][  4]LogLoad: Game class is 'CarlaGameMode_C'
[2019.05.03-03.33.41:657][  4]LogWorld: Bringing World /Game/Maps/Town01.Town01 up for play (max tick rate 0) at 2019.05.03-03.33.41
[2019.05.03-03.33.41:658][  4]LogCarla: Loading weather description from ../../../CarlaUE4/Config/CarlaWeather.ini
[2019.05.03-03.33.41:659][  4]LogCarla: Loading weather description from ../../../CarlaUE4/Config/CarlaWeather.Town01.ini
[2019.05.03-03.33.41:661][  4]LogCarlaServer: Waiting for the client to connect...
^C[2019.05.03-03.33.42:370][  4]LogLinux: FLinuxPlatformMisc::RequestExit(bForce=false, ReturnCode=130)
[2019.05.03-03.33.42:370][  4]LogLinux: FLinuxPlatformMisc::RequestExit(0)
[2019.05.03-03.33.42:370][  4]LogGenericPlatformMisc: FPlatformMisc::RequestExit(0)
ERROR:[2019.05.03-03.33.51:661][  4]LogCarlaServer: Warning: Failed to initialize, server needs restart
tcpserver 0 : connection failed: Operation canceled
Any ideas on why this is occurring?

I had the same problem.
Installing gym version 0.10.8 solved it for me.


Scrollable widget support

Scrolling is quite a basic feature for a UI toolkit. We need it!
I see two different approaches to tackle this:

Draw the scrollable contents into a Canvas. The issue is that we would need to recreate it once the scrollable changes dimensions. We could circumvent this initially by forcing users to set a fixed width and height for scrollables. However, this destroys the purpose of a responsive UI. Another approach could be simply avoid resizing the Canvas every frame while resizes happen, and only do it at a specific rate. Although this would cause the UI to not resize smoothly, it could be good enough for now.
Implement scissor test support for Target. This sounds way more elegant, but it entails more work as we will have to add scissor support for all the current pipelines (quads and font rendering). It should be doable, but it needs to be done carefully.

In both scenarios, Widget::draw definition will probably need to change to improve composability and recursive draws (scrollables inside scrollables). Although I think a tree-like data structure stored in Renderer could work too.
Any other ideas?

Triangles can be cropped to fit the rectangle. If you are collecting all vertices into batch and drawing them then you can just pass them trough cropping algorithm that will calculate new vertex and texture positions based of view rectangle. Assuming all objects inside ui can be represented by rectangles (AABB) when being drawn.


Cannot get deployed url

Describe the bug
I've initiated the deployment process. Let me check the deployment status for you...
Your site has been successfully deployed! You can view it at: undefined.
Link to the Bolt URL that caused the error
https://bolt.new/~/github-dqnongkj
Steps to reproduce
just deployed
Expected behavior
to provide netlify url for deployed project
Screen Recording / Screenshot

Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 131
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 104912827,
  "usedJSHeapSize": 88520999,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = mangollc
Chat ID = 5c5ec35b8369

Additional context
.

This issue is now fixed.

https://github.com/stackblitz/bolt.new/issues/3948


[Feature Request] Render DICOM RTSTRUCT Point Contours visually

What feature or change would you like to see made?
The new fix for RTstructs in the most recent beta 3.90.2 is allowing rendering of almost all the RTstructs that used to not display.
The one exception so far is point probes.
If created in MIM for example a point probe is created it shows it as a mini cross hair

Currently when rendering in OHIF it doesn't appear at all but if clicked on in the side panel will localize to the correct slice.

If we could display that point in some way that would be great.
Why should we prioritize this feature?
Point contours are used a lot in RTplans to mark max doses or just to identify  the focal center of a region.
Displaying them along with the rest of the contours would be great and wouldn't leave the user confused where the contour went which is listed on the side panel.

You can find the dataset here https://fileshare.uhn.ca/download/d09ca363-b381-4c09-bf35-da6cfb3631db  -password outlook
please note this will expire on June 6 2024

We released OHIF 3.9 which address this issue


AWS Lambda unhandled exception

Followed documentation to deploy PR Agent on AWS Lambda, to use in a github app.
When github tests with a ping request the response is a 502. Tried to use the app in the configured repo but it's not even making a request, I assume because the app is not in a ready state.

In CloudWatch I see logs related to the request, noticeably this warning:
LAMBDA_WARNING: Unhandled exception. The most likely cause is an issue in the function code. However, in rare cases, a Lambda runtime update can cause unexpected function behavior. For functions using managed runtimes, runtime updates can be triggered by a function change, or can be applied automatically. To determine if the runtime has been updated, check the runtime version in the INIT_START log entry. If this error correlates with a change in the runtime version, you may be able to mitigate this error by temporarily rolling back to the previous runtime version. For more information, see https://docs.aws.amazon.com/lambda/latest/dg/runtimes-update.html
[ERROR] Runtime.ImportModuleError: Unable to import module 'pr_agent.servers.serverless': No module named 'fastapi'
Traceback (most recent call last):

I've tried a few things related to env vars, as I was not sure it could be the problem, but I noticed no difference in any approach I tried.

@s1moe2
AWS lambda was added as a contribution by the community:
https://github.com/Codium-ai/pr-agent/pull/92
We personally are not working with AWS LAMBDA, and are limited in our ability to support specific problems people encounter. I am not sure if its related to PR-Agent code, or the deployment. Most likely the latter
It's weird you see a "no module named fastapi" error, since its in a requirement.txt
Maybe try asking people who have worked with AWS LAMBDA with PR-Agent
https://github.com/search?q=repo%3ACodium-ai%2Fpr-agent+AWS+Lambda+&type=pullrequests
@koid were you able to deploy to AWS Lambda ?

@mrT23 see my PR :point_up:
I do have other problems, but at least this solves the missing dependencies.

After resolving the Lambda issues I finally ran some tests. I'e tried to add a "/review" comment and to open a PR.
As seen in the image below, ignored events responded with success to the webhook. However, both meaningful events (review and new PR) responded with 502 but there are no logs of errors/exceptions.

@s1moe2
Why would it timeout after 3 seconds ?? Inference takes longer than that (usually 30-120 seconds)
I don't think this is something that comes from PR-Agent definitions

Ah yes, my bad. I had not changed the default timeout. Thanks.

@s1moe2 How did you handle putting the github__private_key in the lambda environment variables. I've tried multiple ways of setting multi line strings and such but they all result in errors.

@taimaruuu No idea how you are deploying. In my case, I am using OpenTofu, so I'm reading the content of a file using its features:
resource "aws_lambda_function" "codium_lambda" {
  ...

  environment {
    variables = {
      ...
      "GITHUB__PRIVATE_KEY"  = file(var.gh_app_pem_file)
    }
  }
}

I believe you should be able to also set the string directly by using \n characters.

@s1moe2 I was having issues with it and tried multiple ways of doing it with \n, \n and more. Eventually settled for just storing the private key as a base64 encoded string in the variables and then adding code to decode it before using it for authentication


EncryptDataSource Support sql.show

Fixes #2466.
EncryptDataSource Support sql.show.

Pull Request Test Coverage Report for Build 8409

22 of 25 (88.0%)  changed or added relevant lines in 8 files are covered.
38 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 60.427%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/datasource/EncryptDataSource.java
2
3
66.67%

sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/api/EncryptDataSourceFactory.java
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/datasource/EncryptDataSource.java
38
11.54%

Totals

Change from base Build 8408:
-0.2%

Covered Lines:
8258

Relevant Lines:
13666

💛  - Coveralls

Bravo, thank you for high quality pull request.

I fix issue for checkstyle on your code: 18fb9f772a6d127d3fc7f91219455341d6de0870
please take a look.

ok，thanks！ @terrymanu


kontrol.regulator.feedback.critical_damp_optmized() and kontrol.regulator.post_filter.post_low_pass() bisection algorithm

Both of the functions use the bisection method to find optimized parameters.
Perhaps make a separate module for handling these algorithms?

Added bisection algorithm 01e753e.
Still need to work at replacing/simplifying the contents inside the functions.

Not important for now.


ci(security): Helm chart in ghcr.io should also be signed

Is your feature request related to a problem? Please describe.
The container images of the project are signed, the helm chart isn’t signed.
Describe the solution you'd like
Please sign the helm chart also.
Describe alternatives you've considered
No

Hey, I can work on this


Removes objc attribute from DownloadProgressViewDelegate

It wasn't needed, so it just cause the compiled code to be larger than needed.
Also changed the header to the standard one.

@gdhakal Thank you!


Mark comparisons of union constituents involving markers as being unreliable sources of variance

Fixes #40312
The root cause is that when measuring the variance of something like T | A | B, we'd check if T' | A | B is assignable to T | A | B and return a strong variance result, since, yes, it does hold that for all subtypes of T, the relationship holds. However, the relationship between T' and T is not the same as the relationship between T and T | A | B - while every subtype of T will be assignable to the union, there as some things which are not subtypes of T (eg, T | A) which will also be assignable to the union - when we detect we are making such a measurement, we need to mark the variance result as Unreliable, so we can, in the negative case, fall back to a structural comparison of the union members.
Included is an interface-based test case for the same issue - this has been an issue in our variance calculations since their inception, so you can see the interface case replicate the undesirable assignability behavior far into our past (at least as old as 2.7) ❤

@typescript-bot perf test this
@typescript-bot user test this
@typescript-bot test this
@typescript-bot run dt

RWC diff is just the removal of a 'StyleRuleSetRecursiveArray<StyleRuleSet<ViewStyle>>' is not assignable to parameter of type 'StyleRuleSetRecursive<TextStyle>' error, which seems OK (and in the vein of what this fixes), plus somechanged elaborations in fp-ts. DT looks clean (runner is out of date (since the runner repo moved) and so has some incorrect expected failures, but that should be fixed in the pipelines now).

@typescript-bot user test this

Unfortunately, we never finished reviewing this PR. It is pretty old now, so I'm going to close it to reduce the number of open PRs.


feat: move system Flatpak handling out of Yafti

This takes system Flatpak handling out of Yafti and does it the same way as we tried on endlish-oesque.

Flathub is included in the image as a system remote the way the Flatpak documentation recommends
/etc/flatpak/install contains a list of Flatpaks to be installed
A new line in Containerfile reads /etc/flatpak/install and installs the apps without deploying (to preseed the needed files)
ublue-flatpak-system-install reads /etc/flatpak/install and installs what's there without pulling remote data
flatpak-system-install systemd unit runs ublue-flatpak-system-install at boot

@p5 and importantly, you don't require the Internet at boot. 😄 This was the impetus for endlish-oesque, as that's a major feature of Endless OS.

Hi!
I managed to get this working over on Bazzite with some work, and I'd like to share my findings
Installing all the flatpaks without deploying them works fine, but they aren't cached nicely on the image. We need /var/lib/flatpak/repo/objects and /var/lib/flatpak/repo/remotes/flathub, but since var must be empty when the image is created, we have to move them somewhere else. I know it's ugly but I opted for that to be /etc/flatpak/flathub and /etc/flatpak/objects. These files are not cached by flatpak in the directory defined by FLATPAK_SYSTEM_CACHE_DIR so it has to be done this way (unless there are any better suggestions on this one, I'd really like to know)
On initial boot, I configured the service to move these files back over to /var/lib/flatpak/.. and to remove the directories so that space isn't being wasted. I also opted to check for the existence of /etc/flatpak/install before running the script as otherwise the service will fail after the file has been moved
https://github.com/ublue-os/bazzite/pull/86/files


Update cea-positions

Update based on the following link provided by Issa:
https://www.centreforeffectivealtruism.org/blog/cea-update-q2-2021/?fbclid=IwAR3sRmhXX0sCYvu1eEJ4S4fsyFb8QXHIx-9bttiJaR76z5m-KnBbgpx5X3A#org-chart

Updated


Noisy visual with the iguana demo

I'm a graduate student working on a project that uses scientific visualization, considering using Godot to visualize volumetric data being generated by High Energy Physics simulation.  I tried following your Volume Viewer for Godot video and am able to get the image of an iguana skull, but the visual includes some sort of interference (screen capture attached).  The skull image is visible (great visual) and appears to respond correctly to the Volume Layer adjustment entries (very cool), but I need help figuring out how to eliminate the tiny dancing squares.  Please let me know if you have any ideas.
Thanks,
Kim Peterson

I've not seen anything like that before and am not sure what may be causing it.  It looks like some sort of memory corruption with your graphics card.  What OS and graphics card are you using?  Have you tried this on a different computer?  Also, have you tried Forward vs Mobile vs Compatibilty modes?  You might also want to try updating your graphics drivers.  You could also try moving the shader sliders to see if some configurations give you a clear picture.

I have been using 2 different computers, Windows 11 and Linux (Mint 21.1).  Both computers have RTX4090 with up to date drivers.  I have tried all the perspective views.  Forward and Mobil Modes (Compatibility Mode shows the noise, but no Iguana).  I've adjusted the slider controls.  All of that (other than Compatibility Mode) has no effect.
I installed Godot_Volume_Layers in the Windows machine by downloading the zip file from the github site.  Godot was installed on the Linux machine using Software Manager.  Both installations are version 4.2.1.  I retrieved Blender from the Blender website for each machine.  They both indicate Blender version 4.0.2.  Godot Volume Layers is version 1.0.2.
I notice that when I run the project I get no image, just a plain dark grey screen that opens up.  Should the project run and produce a visual?
Today is the first time I have ever installed Godot, so the chances of me making a mistake or leaving something important undone seem pretty high as I followed the video and installed the Iguana Demo Project.  I'll look around for some other Godot v4 demo project and see if I can verify that I'm doing the installation and project setup right.
Kim

I just opened the project, and am getting the same issues.  I'm not sure why - everything was working fine when I last touched it a few months ago.  I'll have a look at it tomorrow.

I've pushed an update.  This should fix the issue.  The color variable was not being explicitly initialized which is what was causing problems based on the system.

Perfect.  I confirm the issue is fixed:


integrate to citros

hi @gtep96,
We merged the updates branch.
please integrate to citros:

build the production dockerfile locally.
check that it's running locally on your PC (it may need 1.5 minutes to launch)
push the new image to the cloud
sync with CITROS
launch a simulation with timeout of at least 3 [min].

Thanks

Done. I needed to change bot model from waffle to burger and comment out one line in the devcontainer.json to make it work on Mac.


SocialContextOperations#getAllMutualFriends: Fix NPE and add picture as extra data

#219

#220

#221

@troig Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@troig Thank you for signing the Contributor License Agreement!

@troig : I'm ready to merge this, but would rather the PR included tests (or changes to existing tests) that verify that the PR does what it claims. Without tests, the PR review process requires much more time.

@habuma: Sure, bet me a few days to have it a look. Thanks


Develop constructor functions of each project type

Since the backend won't generate the default expenditures, I added validations to check if the expenditure matches the project type.

Backend done.


Fix typechecking around projection

Pull Request Test Coverage Report for Build 852

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 80.069%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/ast/function_def.js
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

lib/ast/function_def.js
5
79.91%

Totals

Change from base Build 851:
-0.05%

Covered Lines:
8321

Relevant Lines:
10001

💛  - Coveralls


和Riverpod 配合，发现无法正常使用，必须restart才能正常使用

Android  上同时集成Riverpod，无法正常使用
Ume版本：
flutter_ume: ^1.0.1
flutter_ume_kit_ui: ^1.0.0
flutter_ume_kit_device: ^1.0.0
flutter_ume_kit_perf: ^1.0.0
flutter_ume_kit_show_code: ^1.0.0
flutter_ume_kit_console: ^1.0.0
riverpod版本：
flutter_riverpod: 1.0.3
hooks_riverpod: 1.0.3
riverpod: 1.0.3
PluginManager.instance // 注册插件
..register(WidgetInfoInspector())
..register(WidgetDetailInspector())
..register(ColorSucker())
..register(AlignRuler())
..register(ColorPicker()) // 新插件
..register(TouchIndicator()) // 新插件
..register(Performance())
..register(ShowCode())
..register(MemoryInfoPage())
..register(Console());
runApp(ProviderScope(child: UMEWidget(child: MyApp(), enable: true)));

Error log 错误日志
没有错误日志

Environmental info 环境信息
Flutter doctor
[✓] Flutter (Channel stable, 3.3.3, on Mac OS X 10.15.7 19H114 darwin-x64, locale zh-Hans-CN)
Checking Android licenses is taking an unexpectedly long time...[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc2)
[✗] Xcode - develop for iOS and macOS
✗ Xcode installation is incomplete; a full installation is necessary for iOS development.
Download at: https://developer.apple.com/xcode/download/
Or install Xcode via the App Store.
Once installed, run:
sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer
sudo xcodebuild -runFirstLaunch
✗ CocoaPods not installed.
CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
Without CocoaPods, plugins will not work on iOS or macOS.
For more info, see https://flutter.dev/platform-plugins
To install see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.3)
[✓] IntelliJ IDEA Community Edition (version 2020.1)
[✓] VS Code (version 1.72.2)
[✓] Connected device (3 available)
UME and kits version UME 及插件包版本
flutter_ume: ^1.0.1
flutter_ume_kit_ui: ^1.0.0
flutter_ume_kit_device: ^1.0.0
flutter_ume_kit_perf: ^1.0.0
flutter_ume_kit_show_code: ^1.0.0
flutter_ume_kit_console: ^1.0.0

+1，用 flutter_boost 时，main 里启动任务多了，会偶现 debug 浮标点击没反应，要 hot restart 才行。


Icon view from Object browser is missing logic to introduce disabled class

In pull request https://github.com/plone/volto/pull/6054 we received a new object browser view (Icon View)
In the list view which was the previous default if you had an image block on a non image such as a link content type
that item is displayed with a list tag with the class disabled.
See:

This is how the Icon view shows the link content type:

Adding the disabled class to the icon view list tag would make the listing look like:

@ichim-david I've identified a way to improve the Icon View in the object browser. We can add a 'disabled' class to non-image items, similar to how it's done in the List View. This would involve modifying the IconViewItem component to check the item type and apply the class accordingly. It's a small change that will enhance visual consistency across views. Would you like me to proceed with implementing this enhancement?

@KUNDAN1334 please read and follow First-time contributors, especially Things not to do, Contributing to Plone, and Contributing to Volto.
Also it is not necessary to use AI-generated text when making comments. It adds nothing to the discussion, repeating what has already been stated.


Added feature delete function

Noticed that there wasn't a function to delete existing feature keys, added one plus a couple tests.
Let me know if there are any issues. Thanks!

@EricR Any word on this? This feature would be very useful for my use case!

:+1:

Would be nice to have this small feature

Thank you!


Update README.md

Closes #14

Hey @S-ishita Please do change things as I asked earlier. raise new PR, points for both will be given for this PR only


Better ios integration

draft swift to send more passport data
same button as android to scan

ended up copying changes manually to https://github.com/zk-passport/proof-of-passport/tree/ios


Missing LICENSE file

I am trying to implement my own COSE library and I would like to include these examples in my repository for testing purposes and bits of them in unit tests, however, there is clear no license associated with these examples, so I am not sure if I am allowed to copy or transform them in any way.

Added license file

Thank you!


Exposing the password to log file.

In case of exception in class RedirectingEurekaHttpClient, the serviceEndpoint variable, holds the full url including the password to eureka, and the line ->
logger.info("Request execution error. endpoint={}, exception={} stacktrace={}", serviceEndpoint,
e.getMessage(), ExceptionUtils.getStackTrace(e));
print it to log.
Can you not print the password.

the serviceEndpoint variable, holds the full url including the password to eureka

This bit is not clear to me, can you give an example? You mean when a serviceUrl supplied via the config has sensitive information itself?

Hello , i hope it will make it more clearer.
I mean on startup of the service, in case of exception, sensitive information, such as password is written to log. because the object serviceEndpoint is holding this info and he is printed to log.
The password it self is encrypted in the properties file, but the serviceEndpoint at runtime holding this info decrypted, and is when printed to log it exposes this information.

the serviceEndpoint variable, holds the full url including the password to eureka

This bit is not clear to me, can you give an example? You mean when a serviceUrl supplied via the config has sensitive information itself?

Hello , i hope it will make it more clearer.
I mean on startup of the service, in case of exception, sensitive information, such as password is written to log. because the object serviceEndpoint is holding this info and he is printed to log.
The password it self is encrypted in the properties file, but the serviceEndpoint at runtime holding this info decrypted, and is when printed to log it exposes this information.

because the object serviceEndpoint is holding this info

This is the bit I'm not sure I understand, how does a password end up in there in the first place, and what password is it? Do you specify your endpoints in the form of:
eureka.serviceUrl.<zone>=http://host:port/eureka/v2<password in the query string or path>?
I don't disagree we should not be logging sensitive info, but I want to understand how sensitive info ends up in the service end point and what's the overall use case. If you can describe the use case with a minimal example that'd be helpful.

In our case, the URL is provided via a custom EurekaClientConfig. When getEurekaServerServiceUrls() is called on our custom config, we build URLs with the username and password (https://user:password@server:port). The URL (with the password) is what is logged in RedirectingEurekaHttpClient.execute() when exception is thrown. Granted it is INFO but it's also dumped as warning further down in executeOnNewServer()

gschoendaller

Sounds like this can be configurable, in general you do want to know which peer the request failed to, but in cases you use a scheme like this it can be nice to be able to obfuscate it. We can discuss possible ways of doing it if anyone's interested in implementing this.

fyi I'm doing something like this because it seems spring boot norms are to encode the password in the URL.
      URI serviceUrl = URI.create(eurekaUri);
      BasicToken auth = null; // this is armeria type, but anyway you can see what I mean
      if (serviceUrl.getUserInfo() != null) {
        String[] ui = serviceUrl.getUserInfo().split(":");
        if (ui.length == 2) {
          auth = BasicToken.ofBasic(ui[0], ui[1]);
        }
        serviceUrl = stripBaseUrl(serviceUrl);
      }

--snip--
      // here is the washed serviceUrl, not the input
      LOGGER.info("Using eureka to discover zipkin: {}", serviceUrl);

--snip--
  // Strip the credentials and any invalid query or fragment from the URI
  static URI stripBaseUrl(URI baseUrl) {
    try {
      return new URI(baseUrl.getScheme(), null, baseUrl.getHost(), baseUrl.getPort(),
          baseUrl.getPath(), null, null);
    } catch (URISyntaxException e) {
      throw new IllegalArgumentException(e);
    }
  }


Date picker broken after update from 3.1.4 to 3.1.5

Working date picker in version 3.1.4
I am using a date picker in conjunction with activeadmin:
    f.inputs 'Details' do
      # ....
      f.input :published_at, as: :datepicker
    end

This produces a date picker like so:

Broken date picker in version 3.1.5
When I updated to the latest version of formtastic (everything else being equal). I get this JS Error in my console:

TypeError: input.datepicker is not a function. (In 'input.datepicker($.extend(defaults, options))', 'input.datepicker' is undefined)

Workaround
I am currently stripping down the version of formtastic in my Gemfile in order to keep the functionality working:
gem 'activeadmin'
gem 'formtastic', '= 3.1.4' # Date picker won't work otherwise

See https://stackoverflow.com/questions/16121895/jquery-datepicker-for-simpleform-just-like-in-activeadmin

Note: If this functionality is no longer supported one option would be to revert to use the gem simple-form-datepicker, which would also allow to customise the date  picker (e.g. starting day etc.)

@besi formtastic does not provide datepicker input type. It provides date_picker.
https://github.com/justinfrench/formtastic/blob/master/lib/formtastic/inputs/date_picker_input.rb
datepicker is provided by activeadmin https://github.com/activeadmin/activeadmin/blob/master/lib/active_admin/inputs/datepicker_input.rb
I don't know from where this JS error comes from or how it tries to initialize the jQuery Datepicker, but it is hardly formtastic issue as formtastic does not provide any javascript.
If formtastic changes the html output between versions please provide example of how exactly that changed.

@mikz Thanks for the heads up.
I can now use the date picker component as desired:
f.input :published_at, as: :datepicker, datepicker_options: {firstDay: 1}


Feat/early cleanup

This change adds a function to the return values of dir() and file(), which permits the consumer to clean up the temporary files early. Original functionality of cleaning up on exit is not affected.
Examples where this might be useful:

Local testing, where the test process is run with a watch flag. Calling the cleanup function would permit each test to be cleaned up after its completion.
Web server which needs temp working space. Since this is a long-running process, the list of files in the tempX array would grow without bound without some way of clearing them.

Coverage increased (+0.09%) to 95.918% when pulling 9a490b36e6a1fab3f88e3e0346d916d5ab518bdc on ryaninvents:feat/early-cleanup into 6d348a3ef4eb890a426b46c737f21424b23b4d3c on Moeriki:master.

Awesome 👍


[BEAM-9055] Unify the config names of Fn Data API across languages.

This PR would unify the config names of Fn Data API across languages which mentioned in : https://github.com/apache/beam/pull/10246#discussion_r362572952
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---

---
---

Java

Python

---

---
---

XLang
---
---
---

---
---
---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

Run Java PreCommit


cleaned Text dataset implementation and read methods

[Issue #13], [Issue #36 ]

Put an x inside the applicable checkboxes [ ].

Primary type of change:

[ x] New feature.
[ ] Bug fix.
[ x] Refactor.
[ ] Documentation.
[ ] Build/ devops.
[ ] Test.
[ ] Other.

Checklist:

[ x] I have actually ran this code locally to make sure it works.
[x ] I have ran the existing tests, and inspected areas that my code touches.
[ ] I have updated the tests to include my changes.
[ ] I have included updates to the documentation.
[x ] I am pushing a branch, not my main/ master.

Describe the env you tested on: OS, Python version, shell type (e.g. cli, ide, notebook).

Contains breaking changes:

[ ] Yes (explain what functionality it breaks).
[x ] No

🎉  nice! thank you.
Taking a look downstream, although the encoders look like they work with a list of strings, the splitting/folding methods use numpy indices to split the data. So now that I think of it, you will probably need a to_numpy method as well.

Taking a deeper look at Splitset specifically, it just uses np.arange(row_count) to simulate the index, but I would be surprised if to_numpy is not needed at some point


feat: configure tempo remote write

:tada: This PR is included in version 0.2.0-alpha.27 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Requirement level of properties described in "6. Entry list" is not specified

6. Entry list defines entry properties, however, it is not specified which of these properties MUST be present and which are OPTIONAL. I suggest noting the requirements explicitly.

I agree that this should be specified somewhere, but I don't think the right place is under 6. Entry list because that really just is a list of definitions of what these properties are, in any context. So I rather think the place is in 4.1.2 JSON API response schema; where under attributes it says "containing key-value pairs representing the entries properties". Hence, the fix for this connects to #3 in that both things could be clarified in the same place.
But then is the question: should any of these entry properties be mandatory?

So I rather think the place is in 4.1.2 JSON API response schema

I agree.

But then is the question: should any of these entry properties be mandatory?

Strictly speaking all properties can be made optional in case the id is used to store database-specific identifiers (doesn't this supersede the need for local_id property?). I can think of databases not having values for last_modified nor immutable_id.

This has partly been implemented in section 6.2. Structure Entries for a "structure".
Since section 4.1.2. JSON API Response Schema only specifies the general schema of the response (and the same is true for section 4.2.2. Response Schema) and we would want to add other entry types ("calculation", "md_structure", ...), it makes sense to create an overview table under each entry in section 6. Entry List that summarizes what is mandatory and what is optional for each entry type.

To summarize the status quo: There is currently no clear rule for what should go into section 4 and what should go into section 6 of the spec.
For example, in #12, @rartino wrote

6.1.1 is really just intended mostly as an 'appendix' that lists field names and gives more precise details on how they are defined, wherever they appear in the output. The requirements for what MUST and MAY be included in a response is meant to be in section 4.

However, this is clearly no longer the case, as section 6.2 now specifies what MUST and MAY be included in structure responses for example.
I personally find the "appendix approach" anyhow suboptimal because it means there are potentially two places where I need to look as an implementer of a given response (either the information in the appendix is relevant, and then I need to look there, or it is not, and then it does not need to be in the spec). This leaves the question of how to subdivide the spec.
Here is a proposal:

Anything that is used by multiple entry listing endpoints goes into section 4.1
(this concerns the sections that are now 6.1 and 6.6)
Anything that concerns a specific entry listing endpoint remains in section 6.
Where applicable, descriptions should always specify which properties are required and optional.

Do you agree?
P.S. While going through the spec I noticed that there is a possibility of confusion arising from the use of the term "JSON API Response Schema" e.g. as the title of sections 4.1.2/4.2.2. Without context, one would expect these sections to be concerned only with JSON API definitions, while they actually refer to the schema relevant to the default response_format.
I've opened PR #137 to add the meaning of the term to the definitions.

I'll clarify my present position on what goes in Sec 4 vs Sec 6.
For the purpose of organization, I like to view Sec 1-5 as the definition of a, in a sense, fully generic database query API. I.e., Sec 1-5 shouldn't contain anything that is materials data-specific (it is fine in examples, but not as part of the specification). Then, I like Sec 6 to provide the full definition of all the identifiers we need to provide materials data using this database query API.
I believe this is achieved in PR #150. Along with the already merged #137 that I think fully addressed the "P.S" in @ltalirz comment above, I have marked that PR to close this issue. If anyone disagrees, please edit out the corresponding 'closes' in that PR.


Fixes #51 : adr for code hosting platform

#51

Will be using Microsoft Engineering Playbook's ADR template

@redat97

Will be using Microsoft Engineering Playbook's ADR template

you should be using our own guide:
https://github.com/ai-cfia/dev-rel-docs/pull/44/files

https://github.com/ai-cfia/dev-rel-docs/pull/52#issuecomment-1768525065
@rngadam I think we should have an empty template like the one I linked, unless you disagree I will create an issue for that and I will link it to this PR

@redat97 english spelling of platform is platform, not plateform (as per title)

Closed this by accident when I tried to rename the branch

Get approval from @ThomasCardin first

This document is not formatted to wrap at column 80. This should be caught in a status check?

how do you configure that exactly? I followed the wiki

@melanie-fressard showed me an extension nvm

I can see it in my last commit, weird but this was the point
Mainly suited for a team of developers which work on larger project requiring more ressources opposed to GitHub.
@rngadam this was the point, remove or keep?

I don't see it as I don't agree with the assessment, seems rather arbitrary.
remove it.

This document is not formatted to wrap at column 80. This should be caught in a status check?

still not fixed

No idea why it was closed I ran a command from vs code and closed it but all tests are passing now

Had to remove some links that died

docker link is returning 404 for some reason but works when I go on it I tried with deadlinkchecker.com as well and same thing


Failed to transfer files

Copied from email thread:
I’m following https://htcondor.readthedocs.io/en/latest/users-manual/parallel-applications.html#simplest-example to test submitting jobs to the parallel universe.
Upon submitting that, the error I got is
007 (041.000.000) 2023-07-06 13:00:04 Shadow exception!
 Error from<EMAIL_ADDRESS>Failed to transfer files
And then the job would seems to be stuck in the queue and idle forever.
If I submitted a slightly modified example of
#############################################
## submit description file for a parallel universe job
#############################################
universe = parallel
executable = /bin/sleep
arguments = 1
machine_count = 2
log = log
should_transfer_files = NO
request_cpus = 1
request_memory = 1024M
request_disk = 10240K

queue

Then the job would not fail, but seems to be stuck in the queue and idle forever too.
How to solve this?

Copied from email thread:
From Robert:
use:
should_transfer_files = YES
when_to_transfer_output = on_exit_or_evict

Setting should_transfer_files to IF_NEEDED or NO only works if there's a
shared file system between all nodes if I remember correctly. And we
currently don't have this.

Copied from email thread:
I got the same error after setting that to YES.
Error from<EMAIL_ADDRESS>Failed to transfer files
This example uses /bin/sleep so I think transferring is not necessary.
But the problem is that even if I set it to NO, it would idles indefinitely.

Copied from email thread:
From Robert:
looks like this might be a configuration issue, some of the worker nodes
work fine while others cause this problem.
I'll need to further look into this.

Copied from email thread:
From Robert:
the file transfer errors should be gone now.


chore: No need to init noir_js

Description
Provides lazy initialization when noirProgram.init() is not called before.
Problem*
Resolves noir_js should not "require" to .init()#2952
Summary*

Documentation

[ ] This PR requires documentation updates when merged.

[ ] I will submit a noir-lang/docs PR.

[ ] I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

@signorecello had requested to not have lazy init, so that they could init once on loading the page. What are the thoughts here?

@signorecello had requested to not have lazy init, so that they could init once on loading the page. What are the thoughts here?

This doesn't need to be mutually exclusive though?

Exactly, as stated in related issue you can

(Optionally) init upfront
generateProof

init will lazy init if step 1 omitted
if step 1 performed beforehand this is call to init should be no-op

Verify step does not rely on encoder or acvm so does not need init.


Searched in the following locations:       https://jcenter.bintray.com/com/android/support/support-v4/27.1.1/support-v4-27.1.1.jar

cordova 7.1.0
cordova platforms
Searched in the following locations:
https://jcenter.bintray.com/com/android/support/support-v4/27.1.1/support-v4-27.1.1.jar

This is a problem on bintray, the solution is to put google over bintray in the Cordova gradle files


⚠ Samsung has degraded performance

In bf8b7e6, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2828 ms

Resolved: Samsung performance has improved in 416aa38.


[New game]: food matching game

🎮 Game Request
Game logic and basic description
The player will have to remember the position of the food item and match it with the same food at different position.
Point down the features
Game points
Points will be granted on successfully matching the food images.
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @laibaahsan27 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hello @laibaahsan27, Time's Uppp!⏰
Sorry for closing your issue!
But it's more than a week since we haven't received anything from your side 😢 .
Come up with new ideas, create a new issue and make sure you finish it within a week! 🔥
All the best! 🚀
Happy Hacking! 💗

Hey @laibaahsan27 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Hardware versions

We can use the hardware, I2C channels, and EEPROM to know what version of the HAT was are using. How should the software change?

This is now an immediate issue.
List of current changes needed between dev hardware versions:

pin 1 in  PWM_TO_PIN
ADS11115 vs ADS1015
Heating PWM is fixed (should be removed from config)
...

Let's look at a simple example: PWM pin 1 changed from 6 to 17 between versions 0.0 and 0.1. How should we be able to support both? (Yes, we must support all versions of boards)
(master, as of writing)
PWM_TO_PIN = {
    # map between PCB labels and GPIO pins
    1: 6,  # TODO: 17
    2: 13,  # hardware PWM1 available
    3: 16,
    4: 12,  # hardware PWM0 available
    5: 18,
}

Have some mapping in the code?
from pioreactor.version import update_for_version

PWM_TO_PIN = {
    # map between PCB labels and GPIO pins
    1: update_for_version['pwm_to_pin1']
    2: 13,  # hardware PWM1 available
    3: 16,
    4: 12,  # hardware PWM0 available
    5: 18,
}

### version.py

def get_hardware_version():
   ... logic for hardware version here

if get_hardware_version() == 0.0:
   update_for_version = {
     pwm_to_pin1: 6,
     ...
   }
elif get_hardware_version() == 0.1:
   update_for_version = {
     pwm_to_pin1: 17,
     ...
   }
...

It's very simple, which I like, but will this cover all required cases? A problem may be that over time, as new versions come out, this update_for_version gets large and starts to permeate more and more of the code base. OTOH, YAGNI.

Another option is to have different code bases. This seems really complicated, and limits swapping HATs between RPis (since the hard disk and the HAT are on different devices).


clean up notebook example link, add Binder link #285

Instead of a raw link to GitHub, I added some surrounding text so it looks nicer.
More importantly, I also linked to Binder so people can try the notebooks from their browser.
For now, the Binder link doesn't have a branch specified so it'll default to "main" (the default) but as discussed in #285 once we cut a release, we can specify "stable" as the branch.

(I know this was merged, so feel free to ignore)
but right now you have: (https://github.com/opendp/opendp/blob/main/docs/source/examples.rst)
docs/source/examples.rst
26:You can open and run these notebooks online in Binder_ (navigate to ``python/example``).
28:.. _Binder: https://mybinder.org/v2/gh/opendp/opendp/HEAD

but just so you know you can add an easy tag to the readme.md

like here : https://github.com/RoyRin/arxiv_connections

@RoyRin I'm aware of the "launch binder" button and I use it over at https://github.com/pdurbin/dataverse-irc-metrics
No objection from me about adding a "launch binder" button to the README but as I suggest at https://github.com/RoyRin/arxiv_connections/issues/1 I think it either needs to link to a specific notebook or have some explanatory text to indicate where the user should go hunting for them from the root directory (for OpenDP it's python/example) once the user is dumped into Jupyter Lab. I've tried and failed to link to a directory of notebooks (you just get sent to the root). Linking to a single notebook works fine.
If you want to create a pull request, please go ahead. I'll leave it to @andrewvyrros and @Shoeboxam to decide if they want it or not. Thanks for the suggestion!
Oh, while I'm thinking of it, I know we closed #285 already but originally we talked about linking to the "stable" branch, which we haven't done yet.

I think we need a README.md in the examples folder anyways, like this:
https://github.com/opendp/smartnoise-samples/tree/master/analysis
Perhaps we could have a note for binder users in there, and link binder to open that README.md?

Yep, I believe you are right (@pdurbin), I think Binder takes a path to an individual file or to the whole repo, I don't think there's a way to point it only to a subdirectory in a repo (which is unforunate).
@Shoeboxam  I agree with putting a binder link in python/example/README.md makes sense too.
I can make a tiny PR that puts a binder link in python/example/README.md with the words "navigate to /python/examples" next to it.

@RoyRin Just ran a little test and fiddled with urls. Surprised to find that direct links only work for notebook files-- I'm not getting any luck linking directly to a README.md, for example. So it seems like the README.md can't really be used as a landing page for loading binder.


doc: add a tutorial for beginners

add a tutorial for beginners;
add the tutorial link in README.md;

Um, can you leave your sign-off in the commit change log?
Better you can also add some description in you commit log so others can better understand what is the patch trying to fix/improve.

@changweige I have added my sign-off  and description in commit log.


ls (show list of all notes)

A simple command to print all exiting notes under notya notes folder.
Usage
notya ls

or
notya list

then the output should be: (very similar to default shell ls command)
my_new_note.md	repo_readme.md	new_note.md
new_note_1.md	go_sources.md	new_note.md

cc: @Enginbatintr3


Autodiff Cookbook Docs Out of Sync

In second-to last part of the section Jacobians and Hessians using jacfwd and jacrev, the readthedocs markdown is not rendering correctly, namely there is a list that is being rendered inline like:
"This shape makes sense: if we start with a function f:Rn→Rm, then at a point x∈Rn we expect to get the shapes * f(x)∈Rm, the value of f at x, * ∂f(x)∈Rm×n, the Jacobian matrix at x, * ∂2f(x)∈Rm×n×n, the Hessian at x,
and so on."
In the checked in ipython notebook, this same section is rendered correctly as:
"
This shape makes sense: if we start with a function $f : \mathbb{R}^n \to \mathbb{R}^m$, then at a point $x \in \mathbb{R}^n$ we expect to get the shapes
$f(x) \in \mathbb{R}^m$, the value of $f$ at $x$,
$\partial f(x) \in \mathbb{R}^{m \times n}$, the Jacobian matrix at $x$,
$\partial^2 f(x) \in \mathbb{R}^{m \times n \times n}$, the Hessian at $x$,
and so on.
"
I don't know if readthedocs uses a different markdown parser than ipython or if this is just a case of out of date docs, but figured it would be useful to flag.

It was a missing blank line.  Should be fixed.

Thanks for taking a look!


How to get graphiql ide while dependancy Injection in graphql fastapi?

This is the code:
from starlette.graphql import GraphQLApp
from starlette.requests import Request as Rq
from fastapi_jwt_auth import AuthJWT

graphql_app = GraphQLApp(schema=graphene.Schema(query=Query, mutation=Mutation))

@router.post("/gql")
async def graph(request: Rq, Authorize: AuthJWT = Depends() ):
    request.state.authorize = Authorize
    return await graphql_app.handle_graphql(request=request)

app.include_router(router)

Its working fine with post request on insomnia ide but I am unable to see the graphiql ide in the browser in "localhost:8000/gql" url
It gives error: "GET /gql HTTP/1.1" 405 Method Not Allowed
How can I get the graphiql ide in browser?
Is it possible to get the ide by Custom Request and APIRoute class? https://fastapi.tiangolo.com/advanced/custom-request-and-route/
https://stackoverflow.com/questions/65175492/how-to-get-graphiql-ide-while-dependancy-injection-in-graphql-fastapi

@amiyatulu looks like your issue has been resolved in fastapi-jwt-auth or are you still looking for an answer?

Yes, closing the issue. Thank you.

Thanks for the help here @ycd ! :clap: :bow:
Thanks for reporting back and closing the issue @amiyatulu  :+1:


Definition of "primitive" types

AtlasMap has a confusion on the definition of "primitive":

Java primitives: (boolean , byte , char , short , int , long , float, double)
JavaField.isPrimitive() == true: (Java primitives and boxed of those + java.lang.String)
AtlasMap primitives: (other than FieldType.COMPLEX, i.e. JavaField.isPrimitive() == true + java.lang.Object + date/time classes)

The boundary between 2. and 3. is ambiguous. IMHO java.lang.String should be Atlas primitive. See if there's any problem if JavaField.isPrimitive() returns false for java.lang.String. Also consider if we want to introduce JavaField.isAtlasPrimitive().

@igarashitm: This should already be defined. At one point there were *ModelUtil class that had the isPrimitive() methods and the ability to convert from the FieldType <-> the Java Class. (I don't see them in the code base atm).
One note to consider: the definition of a "Atlas Primitive" should extend beyond just Java. The intent is for it to the Atlas FieldTypes to be comprehensive across all formats, not just Java. For example. FieldType.INTEGER also maps to XML xs:int and xs:integer.
Perhaps a definitive table of what the Atlas FieldType primitives represent from a data-level would communicate their meaning more clearly, vs relying on the solely Java representation.
For example:
FieldType.INTEGER is defined as a 64-bit signed whole number

What do you mean? are you saying JavaField.isPrimitive() should return true? why?
FieldType.INTEGER was obviously mapped to 32-bit, i.e. Java int. That's why I introduced FieldType.BIG_INTEGER. There was no corresponding field type as opposed to we already had FieldType.DECIMAL which maps to Java BigDecimal.
FYI, in XML module, both of xs:int and xs:integer were actually mapped to FieldType.INTEGER, but I changed xs:integer to be mapped to FieldType.BIG_INTEGER.
Basically the original field type mapping was inconsistent and needed to clean up.

And FieldType.LONG is the one mapped to 64-bit

What do you mean? are you saying JavaField.isPrimitive() should return true? why?

No, there was a utility method that accepted parameters. My short-hand left out the method argument.  It was something along the lines of:
boolean AtlasFieldUtil.isPrimitive(FieldType fieldType)
.. and a corresponding utility method specific for Java classes
boolean AtlasJavaModelUtil.isPrimitive(Class<?> clazz);

FieldType.INTEGER was obviously mapped to 32-bit, i.e. Java int. That's why I introduced
FieldType.BIG_INTEGER. There was no corresponding field type as opposed to we already had
FieldType.DECIMAL which maps to Java BigDecimal.

Correct, in my rush while updating the ticket I left out the signed bit division. FieldType.INTEGER should be defined as a signed 32-bit whole number (4 bytes), FieldType.LONG is signed 64-bit whole number (8 bytes), etc.
XML maps cleanly, since the spec declares bit length for number fields.
JSON.number should default map to something along the lines of a Double to prevent overflows in various JSON implementations that would be on either side of an AtlasMapping conversion. Additionally, AtlasMap Json module should support a configurable behavior for how to marshal/unmarshal json.number. This would allow users to specify exact bit length and precision on a per-mapping basis. JSON.number does not have a consensus interpretation of the specification and various implementations have adopted different bit lengths and precision acuity.

Basically the original field type mapping was inconsistent and needed to clean up.

Curiously, how was it inconsistent? The utility methods encapsulated all the field type <-> java class information.

Curiously, how was it inconsistent? The utility methods encapsulated all the field type <-> java class information.
All those I fixed. Again, that utility method is still saying that the java.lang.String is primitive. And that's what I intend to address with this issue.

String should be an “Atlas Pimitive”.


SSL / kTLS support?

Hello Jens. First of all, thank you for the great work you're doing.
I'm currently writing a Python wrapper for io_uring (the plan is to integrate it into pyftpdlib). One thing that is crucial is being able to send files over SSL. Despite I've never experimented with it, I bumped into kTLS. Can kTLS and io_uring be mixed together? If not, are there ways to use io_uring + SSL and at the same time avoid using user-space buffers (sendfile / splice)?
Sorry in advance if this has already been asked (Google didn't help).

It should just work with the equivalent send/sendmsg/recv/recvmsg op codes, setup will be the same. The only caveat is that control messages are currently disabled with io_uring, so that currently won't work through io_uring, but could be done on the side if you wish.
Slightly longer term, the plan is to enable control messages as well, so that that part will work too.

Thank you.

@giampaolo Its also better to have a wrapper around Liburing, which is already been written if you want to try it out https://github.com/yostealth/liburing

The cmsg's are now supported, (iirc, since 5.12?). I think can be closed


🐞 When the first tab is closed no tab is active

Description
When the user closes the first tab and other tabs exist after it, no other tab is selected and editor area is empty.
To Reproduce

Open three tabs.
Click to select the left-most tab.
Close this tab
Notice that no tab is selected and editor area is empty.

Expected behavior
After closing the first tab, second (now first) tab should be selected.
Screen Recording
https://user-images.githubusercontent.com/806104/213084164-e4099941-e572-406d-b8ce-b1c8fab628cc.mov

Documenting some of my sleuthing from discord, for posterity.

I'm looking at this tab closing issue... and noticing something worrying. when I breakpoint at the moment a tab is closed, I'm seeing that selectionState.openedTabs is showing a file that I have not opened at any point.

po selectionState.openedTabs
▿ 4 elements
  ▿ 0 : TabBarItemID
    - codeEditor : "/Users/XXX/projects/faceswap/.readthedocs.yml"
  ▿ 1 : TabBarItemID
    - codeEditor : "/Users/XXX/projects/faceswap/setup.py"
  ▿ 2 : TabBarItemID
    - codeEditor : "/Users/XXX/projects/faceswap/tools.py"
  ▿ 3 : TabBarItemID
    - codeEditor : "/Users/XXX/projects/faceswap/update_deps.py"

It looks like CodeEdit is correctly saving the openedTabs array when saving the workspace state. However, the tab bar uses the getItemByTab(id: TabBarItemID) method to fetch tabs. This means that after closing and re-opening the workspace all files are closed but the tabs are marked as still open.
That also explains the original issue, there's a tab that's in the openedTabs array but isn't opened in the openFileItems array, so the tab bar doesn't display it when it becomes selected.

@austincondiff are you able to recreate this on main branch?
https://user-images.githubusercontent.com/8212554/220164847-9e1abba5-6003-41ba-a6e7-b53850bac4bd.mp4

@Code-DJ In the latest release, I am able to reproduce it.
https://user-images.githubusercontent.com/806104/220169804-7505096c-7c95-46ba-bbd3-71b332d8349b.mp4

Closing, because we are not able to reproduce.


Subscription upgrade not working - WSO2 APIM 3.1.0

Description:
The user cannot invoke the API after upgrading the subscription tier if the request has been throttled out already.
Steps to reproduce:

Create a Subscription Policy via the admin portal. (1PER1DAY)
Go to the publisher portal and publish an API (Add Unlimited and 1PER1DAY as subscription tiers.)
Go to the dev portal and create an application. (TEST_APP)
Subscribe to the created API to the TEST_APP with the 1PER1DAY subscription tier.
Invoke the API until the request gets throttled out.
Delete the previous subscription and add a new subscription with the Unlimited tier.
Generate a new access token through the dev portal and invoke the API and you will get the 429 response as below.

Affected Product Version:
3.1.0

Please find the below summary of the fix below.
Patch number: WSO2-CARBON-PATCH-4.6.0-1174
Update number: 1595
Support PRs:
https://github.com/wso2-support/carbon-apimgt/pull/3499
https://github.com/wso2-support/carbon-apimgt/pull/3500 (x-full)
https://github.com/wso2-support/update-artifacts/pull/1409
Public PRs:
https://github.com/wso2/carbon-apimgt/pull/10640
https://github.com/wso2/product-apim/pull/11383
Test PRs:
https://github.com/wso2-support/product-apim/pull/774 (x-full)
https://github.com/wso2-support/product-apim/pull/775

Closing the git issue as the public fixes are added via https://github.com/wso2/carbon-apimgt/pull/10640 and https://github.com/wso2/carbon-apimgt/pull/10832

This is fixed in APIM 3.2.0 as well.


Multi-tenant is not supported.

Is this a BUG REPORT or FEATURE REQUEST?:

Multi-tenant is not supported.
/kind bug

What happened:

Login with one user, and create a bukcet.
Login with another user which belongs to a different tenant, and still can see the bucket created in step 1.

What you expected to happen:
User cannot see the bucket belongs to another tenant.
How to reproduce it (as minimally and precisely as possible):
Do as the steps list above.
Anything else we need to know?:
Environment:

Gelato(release/branch) version:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

IMO, this should be a must have feature/fix. @sfzeng @skdwriting Please let me know your opinion.
We are enhancing the next release with some of the key security features and this should be must have.

Guys from YIG is working on it,  they will create PR recently.


There are 10 devices here under the router,but only router can be found.

Error:Unhandled exception:\nBad state: Stream has already been listened to.

I have the same issue and I don't know why this is happening.
With the following command nmap -sP <IP_ADDRESS>/23  on my Linux distribution I'm able to find all the devices connected to the network but when it comes to the following snippet of code:
final stream = NetworkAnalyzer.discover(subnet, port);

    stream.listen((NetworkAddress addr) {
      if (addr.exists) {
        print('Found device: ${addr.ip}');
        setState(() {
          devices.add(addr.ip);
          found = devices.length;
        });
      }
    })

None of my devices are showing up except for my router.
I even tried with the discover2 method but nothing is changing.
I really would like to understand what's going on. Thanks a lot!


FINERACT-1609: Added Pagination to reports

Description
https://issues.apache.org/jira/browse/FINERACT-1609
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[x] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[x] Create/update unit or integration tests for verifying the changes made.

[x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

[ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Please hold off with merging this. I'd like to check this in detail tomorrow.

Same here... left already one comment, but might have more... not entirely sure if we are reinventing something.

Accidentally closed the PR but reopened it for now.
I wanted to say, I'm also missing unit tests for some of the service classes because I feel like the integration tests are not really covering each scenario.

Closing this as it's abandoned.


Fix the hyperlink of federation.md to the latest path.

Fix the hyperlink of federation.md to the latest path.
BTW, the same error in 1.8 branch.

This change is

@tengqm , good idear!
I traversed the repo, and modified all the relevant documents. Pls review it.

/lgtm
Thanks for fixing them!


Does it work on linux?

Can I use this library on Linux?

If not, do you plan to add cross-platform in the future?

Hi.
While I haven't updated the library in a while, I would have no reason to believe it wouldn't compile and link under Linux, assuming the library's DllExport macro is updated to be placed in a platform-dependent #ifdef.
You can open a PR to do this if you'd like, or I will do it later.

Thanks for the info!


Performer Gender and Numbers

Hello,
Thank you for this neat plugin.. really appreciate the efforts you put into it.
I have two suggestions to enhance the user experience for performers:
1- It would be beneficial to have an option to filter the list to display only female performers.
2- Additionally, limiting the number of performers displayed to a maximum of five, with an ellipsis to indicate additional performers, could help declutter the interface, especially in scenes with a large number of participants.
Thank you for considering this feedback.

Hey
Thanks for the kind words! Two solid suggestions, I'll definitely incorporate them, hopefully soon.
Thanks


fix:  修复表格滚动的时候，单元格没有正常显示的问题

🤔 这个变动的性质是？

[ ] 新特性提交
[x] 日常 bug 修复
[ ] 站点、文档改进
[ ] 演示代码改进
[ ] 组件样式/交互改进
[ ] TypeScript 定义更新
[ ] 包体积优化
[ ] 性能优化
[ ] 功能增强
[ ] 国际化改进
[ ] 重构
[ ] 代码风格优化
[ ] 测试用例
[ ] 分支合并
[ ] 其他改动（是关于什么的改动？）

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

☑ 请求合并前的自查清单
⚠ 请自检并全部勾选全部选项。⚠

[x] 文档已补充或无须补充
[x] 代码演示已提供或无须提供
[x] TypeScript 定义已补充或无须补充
[x] Changelog 已提供或无须提供

Codecov Report

Merging #255 (35031ca) into canary (934c84c) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 35031ca differs from pull request most recent head 3776ee5. Consider uploading reports for the commit 3776ee5 to get more accurate results

@@           Coverage Diff           @@
##           canary     #255   +/-   ##
=======================================
  Coverage   72.59%   72.59%
=======================================
  Files           6        6
  Lines         135      135
  Branches       32       32
=======================================
  Hits           98       98
  Misses         33       33
  Partials        4        4

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Auto-update PowerToys

Description of the new feature / enhancement
Hi, I'd love to see an auto-update feature that'll rid me of all those pesky daily "New version of PowerToys is available" messages.
Scenario when this would be used?
A checkbox in the settings that'll allow to choose to auto-update.
Supporting information
No response

/dup https://github.com/microsoft/PowerToys/issues/31806


gnomeExtensions.arc-menu: 33.2 -> 33

Motivation for this change
Despite the 33.3 -> 33 this doesn't appear to be a downgrade.
An actual stable release, where before it was a development version.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Hmm still isn't clear to me what the correct version is to be using here.
https://extensions.gnome.org/extension/1228/arc-menu/ has a 34 which is development, but 33 support 3.34.
https://gitlab.com/LinxGem33/Arc-Menu/issues/136 ?


Prefixes /w IPs in different VRFs

Issue type: bug report

Python version:
NetBox version:

Jeremy,
I am honestly not sure if this a bug or should be feature request. I noticed that as I get more IPs into our setup, that a prefix where two VRFs meet, do NOT show all IPs.
For example, in a /30 routed linked between me and a provider the .1 IP would be a part of one BGP ASN and the .2 IP would be a part of another BGP ASN. Not sure what I should do to account for that.

VRFs and ASNs are entirely separate concepts. Prefixes and IPs are grouped by VRF; as in the real world, each prefix or IP can belong to only one VRF (or the global table). The assignment of ASNs has no effect on this.

They are entirely separate concepts, sure. A VRF is just a organization of routes in a routing table.
"As in the real world" .... nice jab thanks.
Umm but multiple IPs, within a given prefix, can be members of different VRFs. A /24 could a 10 IPs in 10 different VRFs. Which is where my question came up. Several /30's in different VRFs within the same /24 prefix.
No idea why I mentioned AS, they had nothing to do with my train of thought.

Hi,
I'm evaluating Netbox 2.2.2 (I think about migrating from Racktables to Netbox), and I have the same issue/request.
I have many prefixes that have /31 or /32 IPs in differents VRFs, and I can't find a way to fit this into Netbox.
I think having to associate a prefix to a VRF is a bit rigid. Maybe adding an option like "Shared across multiple VRFs" would solve this.

@jeremystretch: Can you re-open this?


Ctrl-C on fn start behaviour inconsistent

After running fn start in the foreground, Ctrl-C'ing the process sometimes stops the functions container and sometimes leaves it running.   Working with new users I've seen them interrupting fn start and then reissuing the command only to be told the container 'functions' is already running.   To avoid making casual users learn Docker,  I suggest a few enhancements:

Ctrl-C/SIGINT to fn start should shut down the functions container
If someone issues fn start and the functions container is already running it should fail with an appropriate user friendly error message.
Either add an argument to fn start like -f(orce) or add fn restart to shut down the current functions container and start a new one.  I think "restart" is more explicit and would be the advice provided when the user tries to use "start" when a functions container is already running.

i've noticed this also. ctrl-c feels like it should shut down but sometimes the container keeps running.


Migratable DMA regions

Original issue: https://charm.cs.illinois.edu/redmine/issues/107

Regions of memory attached to a migratable entity like chare array elements that can be used as the target of RDMA operations.

Original date: 2015-02-09 17:35:45

Needs CmiOnesided to happen first.

Zero copy API covers this. Either low-level direct API put/get operations, or high-level entry method APIs


Unable to get products/offerings

Using the migration guide, I tried many ways to retrieve products and offerings from my account. I used both my secret API key and also my public app-specific API key for android to test. The getProducts method returns {products: []} (while I have 3 products as parameters and on revenuecat) with either key. And the getOfferings method returns a different error with either key.
Here is my implementation of getProducts:
await Purchases.getProducts({   productIdentifiers: [     "id1",     "id2",     "id3"   ],   type: PRODUCT_CATEGORY.NON_SUBSCRIPTION })
The getOfferings errors are as follows. With the secret API key:
Uncaught (in promise) Error: There was an unknown backend error.
and with the google/android public key:
Uncaught (in promise) Error: There is an issue with your configuration. Check the underlying error for more details.
the underlying error being:
ConfigurationError
Which is the key to use and what parameters/functions/other things am I doing wrong or are missing?

@Martijn0405 the secret API key should never be used within your app, it's meant only for server-to-server interactions, so that's why there's a backend error for that one (although we should improve the message to make that clearer).
For the public key error, there should be more information available in the logs, could you share more of the log messages?

Hi, I was only see the error from the response: ConfigurationError. How would I access the logs with more information?

I looked at the response of configure(), and it was -1, using the Google key on an Android test device.


seabird entanglement - location

As a [researcher] I want [the app to offer the app-user the chance to log the location of where they found the entangled seabird(s)]
maybe two options: 'current location' and 'input location'

Entanglement not being treated separately from other observations.


Update channel-lifecycle.mdx

That section is already written in #19. Feel free to comment there.

ah, I hadn't seen that when I wrote this, thanks for the heads up!