Fix renaming/moving nodes in inherited hierarchies causing orphans (by introducing scene-local-ids)

This adresses: https://github.com/godotengine/godot-proposals/issues/6291
And these (closed) issues:
https://github.com/godotengine/godot/issues/72803
https://github.com/godotengine/godot/issues/24817
https://github.com/godotengine/godot/issues/38186
https://github.com/godotengine/godot/issues/16650
I tried my best to comment every line that i deemed necessary so it's easier to understand how everything ties together.
It's actually not that complicated (and for the most part self-contained) which is why i think it's worth considering for inclusion.
It's also VCS friendly, and backwards compatible with a small caveat, but for more details see this post here:
https://github.com/godotengine/godot-proposals/issues/6291#issuecomment-1440644535
All in all it's currently at a point where i don't see more edge cases, but i marked those that i tested in the linked post, so feedback is welcome if there's anything i missed.
And as a preview, here's the illustration from the linked post:
https://user-images.githubusercontent.com/8841352/220732782-644e3088-1209-4637-b8c7-7a30df12e6d3.mp4

Disclaimer: I don't have a c++ background, but i tried my best to understand the source and follow formatting and structure of existing code.

Good luck on your first contribution!
One detail, comments should be formatted like this:
This is a comment.

[..] generate documentation with godot --doctool

Executing this just removed my added entries in doc/classes/Node.xml, what does that mean? should i place them somewhere else?

Oh yes you haven't exported the functions in Node, look in _bind_methods

ClassDB::bind_method(D_METHOD("get_local_id"), &Node::get_local_id);
ClassDB::bind_method(D_METHOD("set_local_id", "value"), &Node::set_local_id);

After adding this, it still removed the entries, is there anything wrong with these statements?

That's odd, are you running doctool on the version of Godot from the branch? It needs to be the built code

i just adapted another launch option in vscode accordingly:
{
  "name": "Doctool",
  "type": "lldb",
  "request": "launch",
  "program": "${workspaceFolder}/bin/godot.linuxbsd.editor.dev.x86_64.llvm",
  "args": [ "--doctool" ],
  "cwd": "${workspaceFolder}",
  "preLaunchTask": "build"
}

i know it's not necessary to debug it, but in my understanding it should run the same (it executes and prints the expected statements about erasing old docs and generating new)

Most things that are nodepath based (script exported NodePaths, Node references and signals) now also work in my test scenario.
I can imagine there being unusual path definitions though that may not be handled by the current substring matching.
But i'm currently not sure of any way to create one. If there is some normal functionality that creates unusual paths, i'd appreciate a hint.
Apart from that i think it's ready for a review from someone who knows c++ and godot's internals better than i do.

did you check skeleton? "Skeleton3d:Hips"

did you check skeletons?
As bones are not nodes this change doesn't apply to them, but i checked BoneAttachments.
From what i saw, they don't seem to use Nodepaths to address bones and only work as direct children of the skeleton node (don't even need them in this case, which is why they probably use simple string names), so this change doesn't apply to them either.

Some relative back/upwards directed (../) paths were not adjusted correctly, this is now also fixed.
To handle all cases more generically, paths should probably be converted to some kind of universal base to be compared, then converted back to their specific representation (probably by checking if they're rooted, then rooting them, adjusting to changes and converting back to being non-rooted -if initially so), not sure if that doesn't just introduce its own issues and complications while not even being necessary.
And as an extra, here's an example scene-post-import script that allows using/parsing ids from imported scenes, so they can be handled by this reconnection featurefix too.
id_postimport_script.zip

I'm not sure if the amount of verbose prints and warnings and if some method names are acceptable.
Maybe there should also be more consistency in the wording of scene-local-id vs local-id; i though that the short form is better (less text) for writing to files, so i also used that for variable and method names.
feedback is appreciated.

It looks like this has been awaiting review for five months, and is meant to address some pretty important functionality regarding scene inheritance.
My project breaks if I try to restructure any scenes that are inherited from, and it makes me very sad.
Can anyone please advise on how to progress with getting this pull request reviewed? 🙂

@Kookiness can you confirm that it solves the issues?

@AThousandShips
Not yet, but I can try! I've never done any forking or merging or compiling from source; I'm just getting to grips with managing my own projects on GitHub. But yeah, I'll see if I can figure out how. Thanks for the response!
I see it says there are conflicts that need resolving - that makes me think it could get messy, and might be above my level of experience, but I'll see what I can do.

Just a little hint for when you manage to test it; test it on a copy of your project as it modifies scene assets (to add node ids). And initially, you have to open your scenes at least once in order of creation or inheritance, so ids are correctly assigned and linked. This only applies to existing projects, not newly created ones. Also, I haven't touched this in a while, so it's on an earlier Godot version, just be aware.

@Flavelius
Hey, thank you very much for the guidance! 🙂 That all makes sense.
My current project is broken anyway (inherited nodes vanishing upon game launch) and on hold due to the issue(s) you made this PR for, which is why I was very pleased to see you had done this. I haven't quite figured out exactly how to fix my project yet without sacrificing some progress on scene modifications, so I'd be testing your enhancement on a new project, and/or after safely stashing my recent project changes first, or as you say, testing with a copy of my project.
On that note, I think I've narrowed down my current project's broken-ness to the .tscn file that other nodes inherit from, but I haven't managed to figure out what needs exactly what needs changing/reverting in the .tscn file to restore the project's node references yet. Maybe you would know the answer! (Of course I wouldn't expect your enhancement to fix the references that have already become broken; rather, that it hopefully just might prevent it from happening again to projects in the future.)

Godot's current way or referencing nodes is based on volatile node names (it implicitly assumes that once you name a node it will stay that way...). So to fix it manually, you'd have to adjust all node paths you encounter in your broken inherited scenes and adjust them to the new correct path.

I also want to mention that i'm probably not going to work on this anymore as i had to continue my project in another engine due to various unresolvable issues. If anyone wants to pick this up, feel free to.

Thank you. Yeah, it's the part about finding the new correct path that I'm struggling with, but I'll try some more.
Yeah, I actually tried Godot about six or so years ago, but my project back then became broken and unopenable in its very early stages, which concerned me. I was hoping things might be more stable now, hence jumping back in.

I found some time and decided to update everything to the most recent master state.
I decided to use a per-scene tracked id offset counter to address the last issue i found, that deleting and adding a node was previously re-assigning the same id which would result in uncaught mismatches.
I decided to use the per-scene id offset field, because other alternatives i considered were not viable, like naive increments with duplicate checking, which produces the issue mentioned above, using project settings to store a global incrementing offset, which is not a good choice because of the string-addressing, type conversions and requirements to manually save() (IO pressure), and introducing another persistent file (undesired).
The current solution has the benefit that, as the ids are scene local, the chance of them ever overflowing is highly unlikely, access is performant and persistence is tied to that of the linked scene, practically eliminating the potential for accidental information loss (which could lead to reused ids).
I'm not sure how saving to binary is compatible with this, but as far as i see it, it is done for builds only where tracking persistent hierarchy info invalidations is not necessary.
There currently are (--)verbose prints in the code for id changes, but as some cases require resetting ids under normal circumstances these prints can become quite a lot, not sure if i should remove them or if verbose mode is allowed to spam the output.
This still needs testing. The simple tests i did had no issues, but i might have missed a case in some indirect code path like those used in undo/redo.

Looks good! I'll try to test it soon, and perhaps accelerate official reviewing with my queries. I've stumbled upon the same problem recently and I'd like to help get it fixed asap.
If I understand correctly, if ancestor has 3 nodes (with id 0, 1, 2) then the inheriting scene will start its node numbering with 4, etc. What will happen if you add the 4th node in ancestor? Will it result with doubled 4 until next save of inheriting scene? I sense that it might pose some problems in VCS branching scenarios, but I can't put my finger on it yet.

Every saved scene has its own numbering sequence, this includes inheriting ones. The reference path follows them through 'owner' ids.
As long as the referenced scene doesn't mangle its ids the path should stay intact.


Tutorial seemingly inconsistent with main docs on Shared folder

This tutorial places the layout page, and some partials, in Pages/Shared folder, while the main documentation for Razor Pages says to put the layout page directly in Pages folder, and also says:
"We recommend you not put the layout file in the Views/Shared folder. Views/Shared is an MVC views pattern. Razor Pages are meant to rely on folder hierarchy, not path conventions."
Clarification in one place or the other is necessary.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a25bf940-8977-fec4-461b-542a9f550fc8
Version Independent ID: 5492c641-af15-64b8-beaa-ddf511be73e6
Content: Get started with Razor Pages in ASP.NET Core
Content Source: aspnetcore/tutorials/razor-pages/razor-pages-start.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

So out of interest which is correct?

ASP.NET Core 2.0 Razor Pages: Pages
ASP.NET Core 2.1 or later Razor Pages: Pages/Shared
Mixed app of Razor Pages + MVC that uses a common layout page: We're waiting to hear back from engineering on what they suggest. See: https://github.com/aspnet/Docs/issues/7336#issuecomment-401577370

We recommend you not put the layout file in the Views/Shared folder. Views/Shared is an MVC views pattern. Razor Pages are meant to rely on folder hierarchy, not path conventions.

That's all correct. You don't put Razor Pages layout files in the MVC Views/Shared folder

hile the main documentation for Razor Pages says to put the layout page directly in Pages folder,

Where does it say that in the 2.1 version?

Just to add on to this, I created a 2.1 app and the _Layout.cshtml is under Pages/Shared.
Also, the _viewStart.cshtml looks like
@{
Layout = "_Layout";
}
will it still work while _ViewImports.cshtml declares the namespace as @namespace RazorPagesMovie.Pages?


fix(clerk-react): Remove typo in clerkjs script attributes

Description

Checklist

[ ] npm test runs as expected.
[ ] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

!snapshot

Hey @panteliselef - the snapshot version command generated the following package versions:

Package
Version

@clerk/chrome-extension
1.0.5-snapshot.v1db13ec

@clerk/elements
0.2.1-snapshot.v1db13ec

@clerk/clerk-expo
1.0.5-snapshot.v1db13ec

gatsby-plugin-clerk
5.0.0-beta.45

@clerk/nextjs
5.0.5-snapshot.v1db13ec

@clerk/clerk-react
5.0.3-snapshot.v1db13ec

@clerk/remix
4.0.4-snapshot.v1db13ec

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension
npm i<EMAIL_ADDRESS>--save-exact

@clerk/elements
npm i<EMAIL_ADDRESS>--save-exact

@clerk/clerk-expo
npm i<EMAIL_ADDRESS>--save-exact

gatsby-plugin-clerk
npm i<EMAIL_ADDRESS>--save-exact

@clerk/nextjs
npm i<EMAIL_ADDRESS>--save-exact

@clerk/clerk-react
npm i<EMAIL_ADDRESS>--save-exact

@clerk/remix
npm i<EMAIL_ADDRESS>--save-exact


Left-handed channel tuning tool reversed

Version 0.1.2+1.17

This is a side effect of how vanilla minecraft item rendering works, all items are flipped in the other hand
Though it is possible to fix this manually, which will be considered


Add content for Performance Benchmarking Section

Add content

@NisantaSahoo please elaborate all the contents

Tracked under: https://github.com/openebs/openebs-docs/issues/550


Match versions in Cargo lockfile

This needs to match Cargo.toml to prevent --frozen builds from failing. Can be tested by running cargo build -j 12 --target x86_64-unknown-linux-gnu --frozen --release on the master branch where it'll fail and on this branch where it will not.
Should I also update the deployment workflow to use --frozen to prevent this in the future? Without an up-to-date lockfile I cannot build this package within NixOS so updating becomes a bit of a hassle :grimacing:

I will be more careful next time! Thanks for pointing it out :)


Add ignore key to [fmt] section

Component
Forge
Describe the feature you would like
An array of excluded globs would be very useful, e.g.:
[fmt]
ignore = ['**/vendor/*','**/preprocessed/*']

Additional context
No response

+1 on this, great idea
Should ignore take a file path, or should there be three ignore fields analogous to the various match flags in forge test? Perhaps the keys are:

ignore_path
ignore_contract (also accepts libraries)
ignore_function (also accepts modifiers)

Path is self explanatory, contract/function could be an array of the form MyContract or functionSig(address) OR path/to/file.sol:Contract OR path/to/file.sol:Function OR path/to/file.sol:Contract:Function
IMO the main use case is copying in a dependency, and wanting to leave the formatting unchanged to simplify diffs against the original source, so I can see these suggestions being overkill with a single ignore_path key being all we need.
Open to either, but figured it was worth discussing :)

@mds1 i'd rather have the ignore entry limited to path globs. reason for that being for specific functions & contracts you can use fmt disable


Single program analyses with custom smtlib conditions require space character

In single program analyses, when including a custom pre or post condition, it seems that any references to mem must be followed by a space. This error in the case that mem or other custom variables used by CBAT are followed by a closing parenthese or newline.
Here is a relevant example. To run, just run bash run_wp.sh with wp installed. The interesting bit is the post condition:
(declare-const x (_ BitVec 64))
(assert
 (bvule
  (select  mem
	   (bvadd (bvsub init_RSP #x000000000000001c) x))
  (select  mem
	   (bvadd (bvsub init_RSP #x000000000000001b) x))))

CBAT runs successfully.  However, I get an error that mem is not found when I remove the " " space character following mem:
pass "wp" failed in runtime with Z3.Error("(error \"line 7 column 11: unknown constant mem\")\n")

Note that this is only a problem for single binary analysis. I believe the function that is causing the error is here. The function ~f in the fold is matching on the variable name used by Z3 (in this case, mem) with a space appended on after. If the variable is followed by a closing parenthese or other type of whitespace (for example newline or tab), this snippet of code won't match on the variable. This isn't an issue with comparisons between binaries as a different function is used and looks for a preceding init_ or an appended _mod or _orig.
Note that when I remove the space from being concatenated on line 67, I no longer get an error and CBAT works as expected. E.g.
~pattern:(Var.name var)

However, this fix doesn't account for the case when a user creates a variable name that contains Var.name in a custom SMTLIB expression. Instead for single binaries, it might make sense to add in a relatively unique identifier like prepending "VAR" to all custom variables like mem, and mention in the user documentation that the user should not create new variables that start with VAR. I have no idea how hard this would be to implement. Alternatively, I can add in some documentation about this to the relevant README to warn users to include a space after referencing variables used internally by CBAT.

Handled in #147.


Refactor ExerciseController.java

Summary
Removed unneccessary userId variable assignment
Close issue(s)
Close #184

@all-contributors add @cerrussell for code


Design: porter's cli api

porter <NOUN> <VERB> vs <VERB> <NOUN> vs total chaos
common flags that we'll need for automation vs. humans, e.g. -o json|table
what commands do we want to bring in from duffle
Adding convenience commands like helm upgrade --install which is very scripting friendly

The output of this should the the full set of commands and flags we would like porter to support, and the guidelines for how new commands should look 'n feel.
EDIT: One of the goals of porter is to not require the user to know about CNAB or duffle. Which is why the CLI is wrapping commands already provided by duffle.

Notes:
Wrapping duffle

Decide if we are wrapping everything from duffle, or a subset?
We don't want to exec to the duffle binary because we will want to read in the porter manifest (we don't have a duffle manifest). This also lets us change how the command is presented, as we may want to do some things differently, such as signing or the local store.
Are we keeping duffle's command word-for-word
Keep what duffle does to take advantage of muscle memory, unless we are trying to streamline a scenario. Then we may support a slightly different set of flags or have something defaulted.

Local Store

Porter will use the same file format / oci compliant format for local store so that the pkg in duffle can be given a path for duffle's store or porter's store and we can share the same code.
local and remote store use the same format (carolyn finally understands)
porter can look for dependencies in the local store under PORTER_HOME

Grammar
We decided to optimize for the help text and understanding what someone can do with porter. So we grouped by nouns when possible. Not all of the commands fit this model now. I'll open issues later to adjust to match decisions made here. We may want to override the help text to group together actions and nouns.
$ porter --help

## Things you can work with
* bundles
* credentials
* mixins

## Things you can do
init
install
upgrade
uninstall
status

Command Groups
Author Bundles
porter init
porter bundle create (are these build/create important enough to warrant aliases?)
porter bundle build
Manage Credentials
porter credentials

list
add
edit
generate
list
remove
show

Manage local store
porter bundles

list
remove
sign (not sure we want to have signing not paired with building)
verify (need to write out the scenario for verifying a bundle not authored by the user)

Note: This kind of collides with bundle authoring.  Need to think about this more.
Manage PKI (this may change soon in duffle, hold off)
porter keys

export
import
list

Think about signing by default and how we can make this easier with porter (so people never have to deal with the pgp app), also public key verification.
Manage mixins
porter mixin

install
upgrade
uninstall
schema

think about how to restore / install a set of mixins for a bundle authored on another computer

[ ] Make sure we are consistent across commands with our verbs (remove vs uninstall)

Would also like to see porter bundle push, porter bundle pull


Add Round Avatar Status theme

Round Avatar Status
This makes the avatar status at the top right of the screen appear as a round dot instead of a vertical bar.

Checklist
Failure to complete this checklist or deleting boxes from the checklist will result in the closing of your pull request unless this is a theme update. Please write any comments regarding this checklist at the bottom of your pull request.
Check every box.

[x] I am the original author of this theme or have permission from the original author to make this pull request.
[x] All copyright of this theme's contents belong to the listed author or is cited in the repository linked above.
[x] This theme's target has been marked appropriately and only styles said target.
[x] This theme works properly on the latest versions of SteamOS for Steam Deck, decky-loader and SDH-CssLoader.
[x] This theme only uses * or !important if absolutely necessary.
[x] This theme is under 4MB in size and uses the least disk space possible.
[x] This theme's preview image does not include text unless it is necessary to describe changes that can be made.
[x] This theme is safe for work and does not contain any sexual, drug-related, or profane content.
[x] This theme prefixes any CSS variables with a unique identifier.

Check one box.

[x] I am not bundling a part of another theme with this theme to encourage mixing and matching themes.
[ ] Themes included with this theme are toggleable using a patch.

Check one box.

[ ] This is a keyboard theme applied to the default keyboard.
[ ] This is a system-wide theme applied to the default keyboard. The keyboard is toggleable using a patch.
[x] This theme does not target the keyboard.

Submitted on new website


[MobileNetwork] Prepare release for first beta

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


Search with "-" replace to "\-"

Hello!, I've got a problem when I try to search with "-" it will replace with "\-".
(This is about security right? But how can I handle these kind of data?)
My data is.
JF62E-0002682

This is json when datatable are searching.
"search": {
"value": "JF62E\\-0002682",
"regex": "true"
}

-- Edit --
This problem only on
multi-filter-select ref: http://datatables.yajrabox.com/eloquent/multi-filter-select
ref: https://github.com/yajra/laravel-datatables/blob/5f803548454491b1e1583442b294aed6ce066b27/src/yajra/Datatables/Engines/BaseEngine.php#L178
Thank you very much.

I think value was escape because of regex true? Can you try using regex false?

@yajra, OK. Now I change regex to false and it got the same.
"search": {
"value": "JF62E\\-0002682",
"regex": "false"
}

But I change.
var val = $.fn.dataTable.util.escapeRegex($(this).val());

to
var val = $(this).val();

and it work now.
Thanks.


CFG ❤🔥 CSG

Combine CFG and CSG and get rid of the redundant enumerators. However, keep the @cfgrammar macro. Make sure the code works afterwards.

Duplicate of #31, btw. I think the note about renaming the combined version to "Grammar" still holds, right?


[WIP] Move ClientE2ETestSuite into a separate module

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Just trying

close this one and open https://github.com/apache/spark/pull/39807


Text is cut off on mobile in Roman

This is what it looks like for me:

I don't know whether it's related to the recent reader changes: the site has always been janky on mobile for me -- I assumed it was something to do with my accessibility settings (2x font zoom) but the above was when I tried with the default settings.

Thanks -- I can reproduce this on my phone (though not in my browser debugger). I'll prepare a fix.

Deployed and fixed on my phone. Please re-open if the issue persists.


Getting a "Git Gateway Error: [object Object]" error upon getting timed out and logged out, staying permanent until password reset

Describe the bug
When I leave the CMS open for an extended period of time, it throws a message saying You have been logged out, please back up any data and login again. Upon re-loading the page, it prompts me to log in with Netlify Identity. I'm using Git Gateway, and Google/Github for user login. I log in with google, select the account I want to log in with, and it all seems to go correctly. Though immediately after, it takes me back to the login screen, and when I press the button to log in with Netlify identity, it throws the error, always, until I end a password reset for my account
To Reproduce:

Leave CMS open in the background until prompted that I've been logged out
Refresh the page, gets to the login screen
Log in as normal, select Google as the login method, and select my account
Immediately goes back to login page, upon successive attempts to use the login button, only get the error

Expected behavior
I expect to be able to log in normally after selecting all of the correct options
Screenshots

Applicable Versions:

Netlify CMS version: netlify-cms 2.10.192
Git provider: GitHub
OS: Windows 10 and 11
Browser version: Brave 1.42.95, Chromium: 104.0.5112.81

CMS configuration
backend:
  name: git-gateway
  branch: svelte
collections:
  - name: FAQ
    label: FAQ
    folder: modules/faqs/
    create: true
    slug: "{{order}}-{{day}}-{{month}}-{{year}}-{{Category}}-{{title}}"
    fields:
      - name: Category
        widget: "select"
        options:
          - { label: "Starting Out", value: "Starting Out" }
          - { label: "Building", value: "Building" }
          - { label: "Betaflight", value: "Betaflight" }
          - { label: "Video", value: "Video" }
          - { label: "Radio", value: "Radio" }
          - { label: "Hardware", value: "Hardware" }
      - {label: "Order", name: "order", widget: "number"}
      - {label: "Question", name: "title", widget: "text"}
      - {label: "ID", name: "id", widget: "text"}
      - {label: "Answer", name: "answer", widget: "markdown"}

  - name: 5" Beginner Build
    label: 5" Beginner Build
    folder: modules/buildLists/5inchBeginner/
    create: true
    slug: "{{order}}-{{day}}-{{month}}-{{year}}-{{Category}}-{{title}}"
    fields:
      - label: Category
        name: Category
        widget: "select"
        options:
          - { label: "Frames", value: "Frames" }
          - { label: "Motors", value: "Motors" }
          - { label: "Flight Controllers", value: "Flight Controllers" }
          - { label: "ESCs", value: "ESCs" }
          - { label: "Video Transmitters", value: "Video Transmitters" }
      - label: Price Range
        name: color
        widget: "select"
        options:
          - { label: "Budget", value: "green" }
          - { label: "Mid-Range", value: "orange" }
          - { label: "High-end", value: "red" }
          - { label: "Varied", value: "violet" }
      - {label: "Order", name: "order", widget: "number"}
      - {label: "Title", name: "title", widget: "text"}
      - {label: "Link", name: "link", widget: "text"}
      - {label: "Description", name: "text", widget: "text"}

      - {label: "Price", name: "price", widget: "text"}
      - {label: "Point 1", name: "point1", widget: "text", required: false}
      - {label: "Point 2", name: "point2", widget: "text", required: false}
      - {label: "Point 3", name: "point3", widget: "text", required: false}
      - {label: "Point 4", name: "point4", widget: "text", required: false}
      - {label: "Point 5", name: "point5", widget: "text", required: false}

  - name: 3" Cinewhoop Build
    label: 3" Cinewhoop Build
    folder: modules/buildLists/3inchCinewhoop/
    create: true
    slug: "{{order}}-{{day}}-{{month}}-{{year}}-{{Category}}-{{title}}"
    fields:
      - label: Category
        name: Category
        widget: "select"
        options:
          - { label: "Frames", value: "Frames" }
          - { label: "Motors", value: "Motors" }
          - { label: "Flight Controllers", value: "Flight Controllers" }
          - { label: "ESCs", value: "ESCs" }
          - { label: "AIOs", value: "AIOs" }
          - { label: "Video Transmitters", value: "Video Transmitters" }
      - label: Price Range
        name: color
        widget: "select"
        options:
          - { label: "Budget", value: "green" }
          - { label: "Mid-Range", value: "orange" }
          - { label: "High-end", value: "red" }
          - { label: "Varied", value: "violet" }
      - {label: "Order", name: "order", widget: "number"}
      - {label: "Title", name: "title", widget: "text"}
      - {label: "Link", name: "link", widget: "text"}
      - {label: "Description", name: "text", widget: "text"}

      - {label: "Price", name: "price", widget: "text"}
      - {label: "Point 1", name: "point1", widget: "text", required: false}
      - {label: "Point 2", name: "point2", widget: "text", required: false}
      - {label: "Point 3", name: "point3", widget: "text", required: false}
      - {label: "Point 4", name: "point4", widget: "text", required: false}
      - {label: "Point 5", name: "point5", widget: "text", required: false}

  - name: 1s - 2s Toothpick Build
    label: 1s - 2s Toothpick Build
    folder: modules/buildLists/1s2sToothpick/
    create: true
    slug: "{{order}}-{{day}}-{{month}}-{{year}}-{{Category}}-{{title}}"
    fields:
      - label: Category
        name: Category
        widget: "select"
        options:
          - { label: "Frames", value: "Frames" }
          - { label: "Motors", value: "Motors" }
          - { label: "AIOs", value: "AIOs" }
          - { label: "Video Transmitters", value: "Video Transmitters" }
      - label: Price Range
        name: color
        widget: "select"
        options:
          - { label: "Budget", value: "green" }
          - { label: "Mid-Range", value: "orange" }
          - { label: "High-end", value: "red" }
          - { label: "Varied", value: "violet" }
      - {label: "Order", name: "order", widget: "number"}
      - {label: "Title", name: "title", widget: "text"}
      - {label: "Link", name: "link", widget: "text"}
      - {label: "Description", name: "text", widget: "text"}

      - {label: "Price", name: "price", widget: "text"}
      - {label: "Point 1", name: "point1", widget: "text", required: false}
      - {label: "Point 2", name: "point2", widget: "text", required: false}
      - {label: "Point 3", name: "point3", widget: "text", required: false}
      - {label: "Point 4", name: "point4", widget: "text", required: false}
      - {label: "Point 5", name: "point5", widget: "text", required: false}

media_folder: "/static/uploads/"
public_folder: "/uploads/"

site_url: https://vitroidfpv-sv.netlify.app/
display_url: https://vitroidfpv-sv.netlify.app/
logo_url: https://vitroidfpv-sv.netlify.app/favicon.png

Additional context
Doesn't seem to happen all of the time, though it working fine is usually an exception

I have managed to catch it and record it, here
https://user-images.githubusercontent.com/76877124/185665048-aebc777a-0327-497b-a353-f8673cf0de34.mp4

I was hoping to get it solved on the Brave platform, as I'd prefer to not jump ship because of something minor like this, but thanks for helping narrow it down

clearing my cookies seemed to help when this happened to me

clearing my cookies seemed to help when this happened to me

for some reason this working, i have no idea why.


Inheritance: cosmetic improvements and remaining shortcomings

Hello Tony and happy new year!
I finally found some time to look at the shortcomings we have with inherited entities. Problems mentioned in http://trackable.codeplex.com/discussions/552553#PostContent_1278793 and http://trackable.codeplex.com/discussions/552553#PostDetailsCell_1278860 still seem to be valid.
I'm currently working on a more radical solution, but for now would like you to have a look at the following PR which fixes a few obvious glitches in

TrackableExtensions.CloneObject
TrackableExtensions.GetChangeTrackingProperty
TrackableExtensions.GetEquatableMethod
TrackableExtensions.GetEntityIdentifierProperty

It also reveals the shortcoming in the ModelBase class, which doesn't allow us to call its NotifyPropertyChanged method from the inherited entity (commit ac8f8642cd98c5701ded8f77b6710c01bdb61989).
As I said I'm cooking and shooting out a new concept, which will eventually address not only the ModelBase.NotifyPropertyChanged problem, but generally improve the design. Though for now I suggest that we make just a little step (which this PR actually is) and better understand where TE still falls short.
I advise you to read the commit messages top down to follow the story vs. studying just the final diff :)
Best regards,
AZ

Hi @azabluda, Great work so far. Thanks for taking a stab at the inheritance issue.  I read through the commit messages and it looks like a number of things were discovered and resolved.  The major one I noticed back when I looked at this is that the change tracker doesn't play nice with inheritance.  But I think inheritance is an important thing to support - which is sort of obvious. ;-)
I just finished some work and should have a chance next week to work on the the issues I entered into [CodePlex] (https://trackable.codeplex.com/workitem/list/basic) for the 2.5 release.  I'll also transfer those issues over here.

Cool, then it feels like my current work is rather closely related with https://trackable.codeplex.com/workitem/35, https://trackable.codeplex.com/workitem/35 and https://trackable.codeplex.com/workitem/48
Once this PR is merged I will present you my draft.

Good work.  I took the liberty of added two commits in the pursuit of a possible solution, which is to add an overload of NotifyPropertyChanged to ModelBase which accepts a type argument for the specific type.  However, this is not cast in stone, and we can revert the last commit if your upcoming solution takes us in a different direction.  So just consider it as part of the conversation.
Glad you're working on these issues ... it motivates me to work on the other issues and push toward the 2.5 release milestone.

overload of NotifyPropertyChanged to ModelBase which accepts a type argument for the specific type

Basically agree. Although one could consider the restriction to TModel type as sort of protection against misuse, it has never been a bullet-proof solution. With the new overload the options to shoot oneself in the foot have just slightly increased.
My new approach (see the upcoming PR) is making the syntax even shorter keeping the security at the same (=low) level
NotifyPropertyChanged(() => PromoCode);

Cool, I'll have a look. True what you say about not being bullet proof. I've heard of some possible improvements to the implementation, basically throwing an exception if the property name does not match the property setter from which it is called.=

But better than exception would be a compiler error or warning. :)


Build

Not an issue but some people were having trouble compiling so heres my compile.
sashimi.zip
alongside a game I played with sashimi, it can crush me time after time as a 1600.

I found the number of threads can be adjusted in '/engine/src/args.rs'. The original code is :
let num_threads = num_cpus::get();
So, i tried :
let num_threads = 1;
and this works, the engine can even run with 1 thread.


Create a CloseClaimsParser object

To parse inputs from the user for closing of claims. Ensure that the claim that the user wants to close exists in the first place AND has not been closed yet.

pushed to v1.4


"kubectl create job --from=cronjob/hello hello-job" fails with "error: failed to create job: jobs.batch "hello-job" is forbidden: cannot set blockOwnerDeletion..."

Kubernetes version (use kubectl version):
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.4", GitCommit:"8d8aa39598534325ad77120c120a22b3a990b5ea", GitTreeState:"clean", BuildDate:"2020-03-12T21:03:42Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.3", GitCommit:"06ad960bfd03b39c8310aaf92d1e7c12ce618213", GitTreeState:"clean", BuildDate:"2020-02-11T18:07:13Z", GoVersion:"go1.13.6", Compiler:"gc", Platform:"linux/amd64"}
$

Environment:
$ cat /etc/redhat-release
Fedora release 31 (Thirty One)
$ minikube version
minikube version: v1.8.2
commit: eb13446e786c9ef70cb0a9f85a633194e62396a1
$

What happened:
$ kubectl create job --from=cronjob/hello hello-job
error: failed to create job: jobs.batch "hello-job" is forbidden: cannot set blockOwnerDeletion in this case because cannot find RESTMapping for APIVersion apps/v1 Kind CronJob: no matches for kind "CronJob" in version "apps/v1"
$

What you expected to happen:
$ kubectl create job --from=cronjob/hello hello-job
job.batch/hello-job created
$

How to reproduce:

enable the OwnerReferencesPermissionEnforcement API server admission plugin

create a CronJob, the one from the k8s docs will do:

apiVersion: batch/v1beta1
kind: CronJob
metadata:
  name: hello
spec:
  schedule: "30 3 * * *"
  jobTemplate:
    spec:
      template:
        spec:
          containers:
          - name: hello
            image: busybox
            args:
            - /bin/sh
            - -c
            - date; echo Hello from a CronJob
          restartPolicy: OnFailure

Run "kubectl create job":

$ kubectl create job --from=cronjob/hello hello-job
error: failed to create job: jobs.batch "hello-job" is forbidden: cannot set blockOwnerDeletion in this case because cannot find RESTMapping for APIVersion apps/v1 Kind CronJob: no matches for kind "CronJob" in version "apps/v1"
$

Disable the OwnerReferencesPermissionEnforcement admission plugin, repeat the "create job" command that now succeeds and examine metadata.ownerReferences, which refers to {apiVersion: apps/v1, kind: CronJob} but needs to be {apiVersion: batch/v1beta1, kind: CronJob} instead:

$ kubectl get job.batch/hello-job -oyaml
apiVersion: batch/v1
kind: Job
metadata:
  annotations:
    cronjob.kubernetes.io/instantiate: manual
  creationTimestamp: "2020-03-17T17:46:12Z"
  labels:
    controller-uid: 1a1375bb-cf92-433c-b2ca-74caf8d37c71
    job-name: hello-job
  name: hello-job
  namespace: default
  ownerReferences:
  - apiVersion: apps/v1
    blockOwnerDeletion: true
    controller: true
    kind: CronJob
    name: hello
    uid: 38bc1133-075f-4e63-8f33-55d5cbd61cf8
  resourceVersion: "1538"
  selfLink: /apis/batch/v1/namespaces/default/jobs/hello-job
  uid: 1a1375bb-cf92-433c-b2ca-74caf8d37c71
...

Duplicate of https://github.com/kubernetes/kubernetes/issues/88645
/close


Document "kapp app-group"

As titled. What's the exact difference between group and just deploy? I couldn't find any meaningful documentation.

We do have some documentation on it here: https://carvel.dev/kapp/docs/latest/gitops/
Are there other things you would like to see covered in this section?

Above command will deploy an application for each subdirectory in my-repo directory

That's useful information I'd expect part of the CLI help page.


Add Database name to DESCRIBE statement support Databricks struct fields.

Describe your changes :
Fix #3719

Type of change :

[x] Bug fix

Frontend Preview (Screenshots) :
Screen Shot 2022-03-28 at 4 27 23 PM

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] All new and existing tests passed.

Reviewers
@harshach @ayush-shah @pmbrull

I think I found one more thing that I need to change before we merge this in. The 'database' in the ingest config file under source.config.database is optional. (see https://docs.open-metadata.org/integrations/connectors/databricks#database-optional). I should add logic to check if that is provided. Otherwise, this may not work. Will run a local test as well.

Merging this - Will fix the formatting in the upcoming PR


node defaults when targetting node

Feature request

What is the expected behavior?
When target is set to 'node', I expected __dirname to behave as normal since the code would be running in a node environment. Instead, it is "mock"ed to resolve to / by default. I can see how this would make sense if targeting a browser, but was surprising when targeting node.
What is motivation or use case for adding/changing the behavior?
I think defaulting to normal node behavior is a less surprising default when targeting node.
How should this be implemented in your opinion?
Since the issue I ran into specifically was related to __dirname, I haven't given enough thought to all of the node options, but since it is mention that

Since webpack 3.0.0, the node option may be set to false to completely turn off the NodeStuffPlugin and NodeSourcePlugin plugins.

I could see setting node to false by default when target is set to node, but I'm open to feedback about where that isn't appropriate.
Are you willing to work on this yourself?
yes with guidance, but this would be fairly low priority for me since i was able to configure it to work for our project. mostly wanted to bring some attention to it in hopes of saving someone else the time I had to invest to get that working for us.

this was fixed in #9172


End portals do not obey scaling factor

End portals do not seem to obey the scaling factor of worlds.
For instance, if I am at 1200,1200 in the surface world, and I enter an end portal to go to the end, and I have set the scaling factor of the end to 32, I still end up at 1200, 1200, rather than at 37,37.

To clarify, you said that scaling is obeyed for Nether Portals?

Yes, scaling is obeyed for Nether Portals, but not for End portals.

This is kinda a big deal, so I'm moving this to 2.2. It needs to get done before release.

I have no idea what the scaling_factor is for the end but I do know that taking an ender portal results in me spawning on an obsidian platform in the ender world at the same exact coords I left the overworld at.

@credomane End Portals can be used just like Nether Portals, ie you can link worlds A and B with Nether Portals, and A and C with End portals. Therefore, scaling should be behavied.
Honestly though, I'd like to polish this feature a bit more, and to not rush it, I'm bumping back to 2.3.

It should be noted in Multiverse/Multiverse-Core#375 that this feature got bumped, and the other got resolved. So if another dev wants to do a release this weekend, you have my approval.


implemented permissions on table level

also pls check test failures

Codecov Report

Merging #6430 into sys-allocations will decrease coverage by 0.03%.
The diff coverage is 100%.

@@                  Coverage Diff                  @@
##             sys-allocations    #6430      +/-   ##
=====================================================
- Coverage              82.88%   82.84%   -0.04%
- Complexity             12928    12930       +2
=====================================================
  Files                   1485     1485
  Lines                  48208    48210       +2
  Branches                5845     5845
=====================================================
- Hits                   39956    39941      -15
- Misses                  5497     5510      +13
- Partials                2755     2759       +4

Impacted Files
Coverage Δ
Complexity Δ

...e/operation/reference/sys/shard/SysAllocation.java
77.04% <100%> (+2.04%)
14 <1> (+2)
:arrow_up:

...ava/io/crate/metadata/sys/SysTableDefinitions.java
95.74% <100%> (+0.09%)
15 <2> (+1)
:arrow_up:

...a/io/crate/exceptions/ContextMissingException.java
81.81% <0%> (-18.19%)
1% <0%> (-1%)

...crate/executor/transport/TransportShardAction.java
73.68% <0%> (-15.79%)
8% <0%> (-1%)

core/src/main/java/io/crate/types/ShortType.java
80.76% <0%> (-11.54%)
16% <0%> (-3%)

...ticsearch/indices/recovery/BlobRecoveryStatus.java
63.63% <0%> (-9.1%)
3% <0%> (-1%)

...peration/collect/BatchIteratorCollectorBridge.java
65.78% <0%> (-7.9%)
2% <0%> (ø)

.../distributed/TransportDistributedResultAction.java
73.84% <0%> (-7.7%)
9% <0%> (ø)

...ain/java/io/crate/lucene/GenericFunctionQuery.java
63.82% <0%> (-6.39%)
9% <0%> (-1%)

...ore/src/main/java/io/crate/types/GeoPointType.java
75.75% <0%> (-6.07%)
23% <0%> (-2%)

... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf1abea...e2129a9. Read the comment docs.


Configure production build

Configure the project to build for production. Assets should be minified, development-specific implementations should be disabled for production builds.
Acceptance Criteria:

A npm script exists to build assets for production
Built assets produce minified JS and CSS assets
Server files do not bundle external dependencies that live in node_modules/
Client files do bundle external dependencies that live in node_modules

Proper code-splitting and chunking exists to separate dependencies chunk from app chunk

TODOS:

[ ] Set up file hashing in webpack for caching assets, as well as asset mapping so the Express server serves the correct cached assets
[ ] Ensure uglification in production webpack builds
[ ] Look into component imports of larger libraries (react-dom, react-dom-router) to reduce bundle sizes of dependencies

Generating a manifest for content hashed asset filenames using webpack-manifest-plugin is not difficult but it introduces a new challenge.
The benefits of content-hashing are desirable: over multiple version releases of the web app unchanged chunks/bundles will continue to be cached while changed chunks/bundles will break the cache (due to new filenames). However, this introduces the issue that hard-coded references to these generated file assets need to know the full filename including the hash. This is solved in client-side applications (or even server-rendered applications that use a static HTML file) through the HtmlWebpackPlugin as that plugin will inject the correct hashed asset names on every build.
The issue is that we are using server-side rendering of the entire application, including the HTML document structure, using React's renderToPipeableStream method on our Express server. This means there is no static HTML file to directly modify.
So we generate a manifest.json file which contains a mapping of the base filenames to hashed filenames. This is not a problem for the server application - it can simply file-read the manifest and store the mapping in memory to feed to the React application so that it can render the <script /> and <link /> tags with the correct asset filenames. However, the client application will not have access to this JSON file (it is not part of the application bundle), so we must devise a solution to get that mapping to the client application for application hydration. If we do not, there will be errors of rendering mismatches.
After extensive research (two days), I have only found three viable methods of achieving this task:

Hard code the mapping as a global JS variable in the rendered client document from the server.

The server can read the manifest.json file and store the mapping in memory.
We will have to find a solution for injecting the mapping into the document, perhaps on server startup we can create a manifest.js file that stores the mapping to a global variable such as MANIFEST and then add it to the bootstrap script on page request.
Drawbacks: we are setting a global, we are writing a file on server start-up. Both operations are large surface areas for error and issues.

The client can fetch the contents of the JSON from the server on client-application startup.

The client can initiate a fetch request to the server at a determined endpoint (such as /api/manifest) and retrieve the mapping from the server, which can have it cached in memory from server startup.
Drawbacks: Upon running the entry application for the client, the browser would have to make an external server request before the client app could hydrate. This adds a delay to hydrating the client application. While we would still see rendered content on the page from the server, it still adds an additional, blocking, hop before hydration can occur.

The stringified mapping is sent down to the client on server-request as a cookie. The client then loads and reads this cookie to properly hydrate the application.

This has the same benefit in option 1 in that there is no additional blocking request prior to client application hydration. It has the additional benefit of not polluting the global namespace.
Drawbacks: A cookie which contains the manifest is still set, and we would have to make sure the expiration of the cookie is immediate to ensure the caching works as intended.

Of these options I prefer the cookie approach. It has the smallest surface area of error of the three options, does not require the server to write an asset file on startup, and does not require the client to make a network hop prior to hydration. This cookie strategy is the one we will move forward with for now. Perhaps in the future a better option will be discovered to replace this strategy.

The production build mode of webpack already minifies. Additional mangling of the output code is out-of-scope for the boilerplate at the moment.
As for component imports: the biggest assets in the vendors bundle (the largest bundle) are react-router-dom and react-dom, both of which are enormous in production (274.87kb and 128.65kb respectively). I'm not certain at this stage that this could be further reduced while using these dependencies: it would be up to the dependencies themselves to package themselves in a way that allowed for either component import or tree shaking.
For now we are going to skip over this optimization concern.

Task completed in PR #53


Add more jav sites

A shame approximately only 50% of these commits are complaints with RFC:952 syntax based blacklists projects like @pi-hole and hosts file based

Yes, it seems like most jav sites are not blocked. I got these sites by a simple google query "jav sites" from the first 10 pages.

A shame approximately only 50% of these commits are complaints with RFC:952 syntax based blacklists projects like @pi-hole and hosts file based


[BUG] cmd always show could not install

when i tried to build apk using
fvm flutter build apk --release --target-platform=android-arm64 -t lib/main.dart --flavor dev
always show could not install

@Nabouste can you run the command with fvm --verbose .... please also run fvm doctor on the same directory that you are running the command

fvm verbose.

Maybe I was not clear please add fvm --verbose in front of the rest of the command flutter build apk .........
So its fvm --verbose flutter build apk .....other args....

Same problem here

@cassiorosso could you try to install 1.22.6 through fvm install 1.22.6, seems fvm is getting a configuration to run 1.22.6 but its getting an error which I am not familiar with

@cassiorosso looking at the issue again, I believe because the version is not installed.. you have to run it as administrator, and link to the project also. After that, you won't need to run as an administrator.
I will go ahead and close this issue, please reopen with detailed information on how to replicate it to see how I can help.


BUG Fix: The showSlides() had a BUG as it was nested inside another Function so it was not Accessible Globally.

…on and solved the BUG: showSlides()

BUG Fixed: the showSlides() was nested inside currentSlide() so showSlides() was not Accessible Globally.

@PratikKrGhosh, Great.. if you have solved the bug... Please share the snapshots after your changes.

@PratikKrGhosh Please share the snapshots after your changes.

@Devesh1509 Sure Here is the Snapshot.
https://github.com/Devesh1509/JavaScript-Slider/assets/144181107/ede1236a-ab21-48d4-8dd5-4d16cd0d7ace

Finally I have

added Favicon to Your Website
Fixed the showSlides() Bug
Increased Program Readability
done Documentation by adding Comments in JS file.
Removed Unwanted lines of code by Commenting them out.


Starship combat: initiative roll in the tracker not working for PC and NPC starships

Hello,
so if I toggle ships into combat state and roll initiative ( = piloting check ) for them, the roll is a flat D20, the piloting skill of the pilot does not get added to the roll. This holds true for NPC and PC ships as well. (I build custom ships for society modules, but I tested this with the ships already uploaded to the system as well. Same issue.) The other skill check both on PC and NPC ships are fine. Also, I haven't found a way to reverse initiative order in the tracker. I don't know if this is already implemented or not.
Thanks in advance,

UnforcedError

hello, solved on Discord. Have a nice day :)


Serge

Language
Circle aria
added meter mixin to simplify

It also appears the draft PRs are triggering the continuous-integration/travis-ci/pr build now.


onBlur is producing an "alien" message when user go back to history in Chrome

Let's imagine an input with onBlur handling. When user focus the input and go back to history elm produce a wrong message which go to current module.
In most cases it's going to be an source of JS error and elm app will be fallen in a result.
In Ellie example you can see both of cases: soft error when app doesn't fall (see at logs) and fatal error.
OS: macOS High Sierra 10.13.3
Browser: Google Chrome 63.0.3239.132 (Official Build) (64-bit)
Elm version: 0.18.0
I hope it will help to make Elm little bit more stable and better.

Related: https://github.com/elm/compiler/issues/2069#issuecomment-665811812


Serialize event id for public attendees

What kind of a pull request is this?

QA / Code Review

Code Checklist

[x] The code follows dotkom code style
[x] The code passes the defined tests
[ ] I have added tests for the code I added
[ ] I have provided documentation for the code I added
[x] The code is ready to be merged

(Possible) Breaking Changes

[x] The changes are backwards compatible

Description of changes
We needed a way to determine what event a public attendee belongs to
Screenshot(s) if appropriate

Just because I am curious:
Is it thus possible to query for public attendees without passing which event you want the attendees for?

No, that is currently not possible. We could set that up, but it would require a separate endpoint instead of nesting it for the event. Maybe that is the reasonable way to go anyways?

I see! So the API-call already included the event id? Can't the attendees be linked to that without serialization then?

Yes, we could have manually added it in the front-end when we got the data. But in the long run I just thought it cleaner for the endpoint to serialize all the required data anyways


Add easy to use chart point tooltip

Yup! This is coming.

any progress on this one?

🎉🎉🎉

psyched to see this! 🎉 🏆

So 1337!

@hshoff does this work with LinePath/AreaClosed?

@thienanle it does but it's a bit more involved. I'm working on making this easier for folks, but haven't settled on an api I'm happy with just yet.
Here's an example of how it works: https://www.webpackbin.com/bins/-KpGjCM5yQ4nkND4c-P-

Things to note:

use a stateful react component (class) so you can using ref on the <svg ref={s => this.svg = s}>, you'll use this in your event handlers
i'm using a transparent <Bar /> overlay on top of the chart to handle the mouse events
onMouseMove

// convert event coords to local svg coords
const { x } = getCoordsFromEvent(this.svg, event);
// use xScale.invert to get x value
const x0 = xScale.invert(x);
// use d3-array bisector to find the data value
const index = bisectDate(data, x0, 1);
const d0 = data[index - 1];
const d1 = data[index];
const d = x0 - xStock(d0.date) > xStock(d1.date) - x0 ? d1 : d0;

// use `withTooltip`s `showTooltip()` to update the position and data
showTooltip({
  tooltipData: d,
  tooltipLeft: x,
  tooltipTop: yScale(d.close),
});

I'm hoping to make this easier in the future as I'll be needing to use it for @vx/brush @vx/drag interactions . But for now this should get you up and going with position based on event positions.
Happy to answer any questions if things come up.

@hshoff thank you for the example, super helpful!
Yes it would be great to not have to use a transparent <Bar /> and have the mouse events on the <AreaClosed /> instead. Thanks for your work on this!
I was also thinking, in the case where a chart has more than 1 series (multiple <LinePath /> components for example), would it make sense to put the mouse events on each? Perhaps on a wrapping component (something like <Group />) would make more sense?

@thienanle yup! you can put the events on the <AreaClosed /> as of<EMAIL_ADDRESS>Example: https://www.webpackbin.com/bins/-KpN6KNn40htehDwd80C

For multiple <LinePath />s it depends what you're trying to do, you could put them on each or you could put it on a <Group /> like so: https://www.webpackbin.com/bins/-KpN9sBHl_pBgbCcLFCt

@hshoff have you tested this on <Arc />? I love the feature of getting the hovered arc section data onMouseMove, but I'm getting an error
Warning: setState(...): Cannot update during an existing state transition (such as within `render` or another component's constructor). Render methods should be a pure function of props and state; constructor side-effects are an anti-pattern, but can be moved to `componentWillMount`.

@thienanle could you post your onMouseMove function? happy to take a look.

onMouseMove={data => event => {
	const { x, y } = localPoint(this._svg, event);

	showTooltip({
		tooltipData: data,
		tooltipLeft: x,
		tooltipTop: y,
	});
}}

Calling showTooltip is what seems to cause the warning.

I solved my issue by calling showTooltip on onMouseMove on <Group /> and setting tooltipData to my component's state (so that I can get the data for the hovered pie).
<Group
	onMouseLeave={hideTooltip}
	onMouseMove={event => {
		const { x, y } = localPoint(this._svg, event);

		showTooltip({
			tooltipLeft: x,
			tooltipTop: y,
		});
	}}
>
	<Arc
		onMouseMove={data => event => {
			this.setState({
				tooltipData: data,
			});
		}}
	/>
</Group>

But it would be nice to not have to do this!

@hshoff any way you could update the links to those examples? They no longer seem to work: https://www.webpackbin.com/bins/-KpGjCM5yQ4nkND4c-P-

@hshoff second

@hshoff third

The demos all now link out to code sandboxes, this is the Areas sandbox.
As harry said above, there is an invisible Bar on top of the Areas which triggers the tooltip anywhere you mouse over, but you could change this behavior by moving the onMouse/TouchMove handler to the Area, or whatever is relevant for your series shape.

Please show example with normal tooltip for multiline chart (hover on marker circle should show value of series item).


Annotation view: importing comments fails

I did not manage to import comments that I had exported before.
On the first attempt for a question,  nothing happens after choosing
and uploading the json file. On further attempts, clicking on import
has no visible effect.
Tested on Chromium and Firefox, with hybrid comments

Ok, I will do some tests


Support for wifi status with tmux-wifi

Is there an existing issue outlining your improvement?

[X] I have searched the existing issues and my improvement has not been raised yet.

What would you like to see added and/or changed?
I'm loving the catppuccin universe, and I'd love to see support for wireless status using tmux-wifi! I've used it before in my old, hacky manual status bar and found it very useful. Are you open to contributions?

Will leave this open to see if there is more demand for this. You can always place custom (not upstreamed modules) in ./custom and those will get priority over the modules in ./pane, ./status and ./window.


Directives improperly replaced in source when names overlap

I have a shader that has these defines:
#define K 0.14285
#define Ko 0.4285

When I try to parse the shader, I get this error:
Uncaught Parse error on line 34:
...57) - 0.14285o;	vec3 oy = mod(fl
----------------^

This is the input line:
vec3 ox = fract(p*K) - Ko;

You can see it appears to be thinking that Ko is actually K then identifier o, so it errors.
Additionally, is it possible to prevent inlining of define statements in the parsed AST?

Merged.

I think, in order to do what you're asking would require turning off the directives part of the preprocessor. But then, that would leave directives in place, and the parser is going to barf on those.


Additional unit test for cache archive: handle missing directory

Issue Number

#1164
Overview

[x] I have added an extra unit test for metadata cache: cache, remove, re-download
[x] I have seen my test fail
[x] I have fixed the issue by making sure that the parent folder exist before downloading the archive

Comments

bors r+

bors r-

bors r+


Character Creator

For now make it an ugly long form since our group already has characters created. In the future, make it a nice step-by-step builder.

We've instead decided to make this as automated as possible from the get go, as otherwise there isn't much point.


Lab 03 Add usage script or instructions how to interact with multi-node network

I figured our how to use postman to send post requests to the first node created by the setup-docker script. This causes a block to be mined if you add enough transactions.
But I am unsure of the process of building out a multi-node network where transactions posted to node 2 will cause node 1 and node 2 to have a common view of the blockchain. Seems like each node will have its own genesis block for example.
Also not clear on how peers are declared/detected. Maybe this should be obvious by reading the code, but it is not obvious to me.
I am teaching a blockchain course at Villanova University in the state of Pennsylvania.

There is a test.py file in the project. I suggest that an assignment challenge might be to add an @app.route declaration for getBalance where the there is an argument for an address. Also a method to return just the size of the blockchain. I might take up the challenge myself to see if I know enough based on the current README and examining the code.

I did implement getBalance and getLength app.route implementations and this was straight forward. I now believe that the simple lab 03 implementation does not support a multi-node network with each node having a common blockchain view of blocks mined by any of the nodes in the network.
@app.route('/length', methods=['GET'])
def get_length():
    response = {
        'length': len(blockchain.chain),
    }
    return json.dumps(response), 200

@app.route('/getBalance', methods=['GET'])
def get_balance():
    address = request.args.get('address')
    balance = blockchain.get_balance(address)
    response = {
        'address': address,
        'balance': balance
    }
    return json.dumps(response), 200


Add linting script and dependencies

Hi!
I noticed there was an .eslintrc here, but couldnt see any linting script defined?
This enables eslinting of source JS files by running:
$ npm run lint

Also fixed some minor linting issues.

Good catch, thank you!


i can't use the return of configuration sent to esp8266, mqtt.

How can I handle the configuration message received from the iot core for esp8266. I can see on the serial monitor, but I can't find in the library how to handle this configuration message.
Serial Monitor:
Waiting on time sync...
Connecting...
Refreshing JWT
connected
Library connected!
incoming: /devices/xp5939303130350c0d17/config - na
incoming: /devices/xp5939303130350c0d17/config - config1
incoming: /devices/xp5939303130350c0d17/config - config2
incoming: /devices/xp5939303130350c0d17/config - config3

It's [the callback function specified in esp8266_mqtt.h].


Installation with packer: 'fzf' is not a valid executable, aborting. Please make sure 'fzf' is installed.

Info

Operating System: MacOS
Shell: zsh
Terminal: iTerm
nvim --version:

NVIM v0.6.1
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by brew@Monterey

fzf --version:

No installed globally
Located at ~/.local/share/nvim/site/pack/packer/start/fzf/bin/fzf

[x] The issue is reproducible with minimal_init.lua

fzf-lua configuration

local status_ok, fzf_lua = pcall(require, "fzf-lua")
if not status_ok then
  return
end

fzf_lua.setup {
  -- fzf_bin = "/Users/strdr4605/.local/share/nvim/site/pack/packer/start/fzf/bin/fzf"
}

Description
I installed this plugin with packer. I did not have fzf installed so I followed the guide with
  use { "junegunn/fzf", run = "./install --bin" }
  use "ibhagwan/fzf-lua"

Are you sure that we need to run ./install --bin? If yes then fzf-lua should pickup fzf from ~/.local/share/nvim/site/pack/packer/start/fzf/bin/fzf.
In order to work probably I have to install fzf globally or set my config to
fzf_lua.setup {
  fzf_bin = "/Users/strdr4605/.local/share/nvim/site/pack/packer/start/fzf/bin/fzf"
}

I think the easiest is to write in docs that fzf should be installed globally.
Or fzf-lua should pick up the fzf binary from packer folder.

I think the easiest is to write in docs that fzf should be installed globally.

Easiest? yes. Correct? not IMO :-)

Or fzf-lua should pick up the fzf binary from packer folder.

https://github.com/ibhagwan/fzf-lua/commit/f7f54dd685cfdf5469a763d3a00392b9291e75f2 - this uses fzf#exec (provided by the fzf plugin) to determine the fzf binary path anywhere in the neovim runtime.


Node crash when agent is concurrently enabled with inspect

GCLOUD_USE_INSPECTOR=1 node --inspect log.js

Where log.js is a simple express app with this at the top:
const debug = require('@google-cloud/debug-agent').start({
  projectId: 'some project id'
});

Node crashes when DevTools connects.
/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node[32991]: ../src/inspector_agent.cc:346:void node::inspector::NodeInspectorClient::connectFrontend(node::inspector::InspectorSessionDelegate*): Assertion `(channel_) == (nullptr)' failed.
 1: node::Abort() [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
 2: node::(anonymous namespace)::DomainEnter(node::Environment*, v8::Local<v8::Object>) [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
 3: node::inspector::NodeInspectorClient::FatalException(v8::Local<v8::Value>, v8::Local<v8::Message>) [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
 4: node::inspector::InspectorIo::DispatchMessages() [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
 5: node::RunForegroundTask(v8::Task*) [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
 6: node::NodePlatform::FlushForegroundTasksInternal() [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
 7: uv__async_io [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
 8: uv__io_poll [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
 9: uv_run [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
10: node::Start(v8::Isolate*, node::IsolateData*, int, char const* const*, int, char const* const*) [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
11: node::Start(uv_loop_s*, int, char const* const*, int, char const* const*) [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
12: node::Start(int, char**) [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]
13: start [/Users/ofrobots/.nvm/versions/node/v8.9.0/bin/node]

This is with node 8.9.0 with debug agent 2.2.2.

I cannot seem to reproduce the crash reliably so far today.
/cc @eugeneo @ak239.

Minimal repro:
const inspector = require('inspector');
const session = new inspector.Session();
session.connect();

setInterval(() => { console.log('jello')}, 2000);

Start with node --inspect test.js. Attach devtools.

Without devtools:
// Flags: --inspect=9229
const inspector = require('inspector');
const session = new inspector.Session();
session.connect();

setInterval(() => { console.log('jello')}, 2000);

setTimeout(() => {
  require('child_process').spawn(process.execPath, [
    'inspect',
    'localhost:9229'
  ])
}, 1000);

Opened bug upstream: https://github.com/nodejs/node/issues/16852

Closing as the bug is upstream.


Custom Pagination Using Django REST Framework with Vue.

Article checklist
Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

This closes #4250

Any updates @jumamiller

@dentonya , I've requested for a few changes,kindly work on them before we move to tech review!

hey @jumamiller done with changes

Hi @dentonya, could you check the hero image...upload news one.

Hi @dentonya, could you check the hero image...upload news one.

ok noted @jumamiller

Hi @dentonya, could you check the hero image...upload news one.

done with changes @jumamiller

@dentonya
Please be sure to go over any edits made by your peer reviewer to improve future articles and reviews and prevent any PR closure.
As a rule of thumb - we can only accept articles (pull requests) that are fully polished and complete articles - articles that are ready to be published.
All revisions and edits should be completed on your own forked repo (as to not take up room in the queue).

@jumamiller
Can we get a status update on this PR?
Lets also please refrain from making major edits/revision to the PRs - we can guide and point out certain issue for the author - but it is the author's responsibility to go through the content for any other issues or errors.

Awesome job on the article @dentonya
cc: @jumamiller


Add a --recursive flag?

The * wildcard search does not work in Windows terminals. For example,
pytest --nbmake */*.ipynb finds all ipynbs one level below in a bash terminal, but not in powershell or cmd. Maybe there could be a pytest --nbmake --recursive command that recursively searches all lower levels for ipynbs?

Hi @jkbhagatio, I would expect you need 2 * e.g. pytest --nbmake **/*.ipynb
Does this not work on windows?

Nope, on Windows * does not act as a path wildcard on its own, instead it has to be used with some other command, like get-childitem https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.management/get-childitem?view=powershell-7.2
But it'd be nice if pytest --nbmake could do recursive searches with the same syntax os-agnostic

This behaviour is actually determined by pytest.
nbmake really just hooks into the test collection behaviour of pytest.
My gut feeling is that pytest already has the capability you are looking for but you will have to find out how to trigger it as there are lots of options/config.
I'm going to close this issue so you can follow up with pytest but please reopen if you think this is nbmake's fault.


Description of the new feature/enhancement
Re: [microsoft/winget-pkgs] New package: windows.PCSX2 version 1.6.0 (PR #127891)
Proposed technical implementation details (optional)
  MesterPerfect:windows.PCSX2-1.6.0-10b500e4-e5c9-437e-a905-3c8d0cb81243

Hi @fwadnjar,
Could you provide more detail about the feature's purpose and implementation?


render the action_topic and reformat the code a little

This is to fix #304

Let me know if the code formatting is ok. Also, I'm not sure we need if (variable !== undefined) versus just if (variable) since it will always be truthy when it's not undefined. It also weeds out empty strings.

I'm not sure we need if (variable !== undefined) versus just if (variable)

Yep it is not needed but I started using that because it is more clear then if (var) and sometimes it could prevent errors when for example comparing number values and if value is 0 it will return false and that is not what you want in such cases. It is just a more concise way to make comparison, if the value is not in the map it should be undefined so I use undefined


Allow setting projectid for customer gateway

Hi all!
Please find my humble (trivial) pull request for optionally setting the projectid for the customer vpn gateway.
Let me know what I can do to help to get this in!
Thanks
Bart

Hi @svanharmelen !
Thanks again for reviewing! I'll update the patch with your suggestions.
Thanks
Bart

Hi @svanharmelen! I have updated the pull request with your suggestions. Please let me know if I can do anything else to help out :-)

LGTM @schans! Thanks!

Cool!


Export emoji package

I would love to use the emoji package in my own Buildkite client, but it's not exported. Would it be possible to export the functions that make it possible to translate e.g. :pipeline: into emojis?

Here's my basic attempt at this: https://github.com/kevinburke/buildkite/commit/72abf9c23d7bbdc999a964f55644dac1fc45eb28
I'm using iTerm2, and I can see base64 data being downloaded and printed, but iTerm2 can't render it - I just get one half of a broken image in the terminal. Any idea what I'm doing wrong?

Ah... this is another master vs. main issue. I think it's working now, once I fix that!

We are looking at releasing the emoji package as its own thing, so this will likely be done in the future but not as a part of the CLI.


Should not start fetching remote data before initial UI

This issue is currently in generic format and need to be further detailed

I want to work in it.

@garg-anuj  can we break it into details?

@shubhamvashisht Approach I came up for this is. All aerogear pipe config and checking for auth should be moved after initial screen display. We can assume that auth state is same as last time app was visited.

@garg-anuj as you mentioned the "initial screen display", is it about mainActivity before checking the auth status?

we can move auth status check and configure pipe to separate thread s it doesn't hamper UI. Additionally we may save auth state from last usage of app and assume state is same. Until we get to find out from other thread that there is some change.

@garg-anuj  great, can we break it into phases? i will start working on it.

@shubhamvashisht Move auth status check and configure pipe to separate thread as first mile stone

@garg-anuj
I think this will change the LoginActivity.java file.
If one is working on it, he should send the PR to @danielpassos branch.
(Just an opinion)


feat(consensus): consensus fast path

Description
Implementing fast path for the consensus protocol

@b00f We accept https://pips.pactus.org/PIPs/pip-10 for implementation.


✨Add content_api_key helper

This very small helper adds {{contentkey}} to the collection of handlebars helpers available to theme creators.
This will make it easier for themes to access the content API key, without either requiring the user to get it from the integrations page and input it on the theme setting page or resorting to JavaScript to read it from one of the built-in script tag attributes -- both ugly workarounds.

@cathysarisky Have you tested a theme with this helper with gscan? Also could you expand on the use case? Helpers are meant to provide a means to interact with the content API w/o needing to do so directly.

Ohh... I bet I need to patch gscan, too.  Will check, thank you.
I've had occasions where I wanted to access the API with something other than a built-in script, such as a 'dashboard' (with extra user data over in AWS) that needed to get the URLs of featured images given the post name.
Currently, some paid themes that use infinite scroll or client-side filtering of posts require the user to input their content API key as a theme setting.  This will give them access to it directly in the theme instead.  I've got a theme customization project to do this week where the client wants to be able to filter by multiple tags and authors.  I definitely need to talk to the content API for that one, and its silly that the client needs to copy the API key from one place to another, or else I need to pull it out of the

@cathysarisky Have you tested a theme with this helper with gscan?

No user-visible errors on uploading - apparently the check Ghost does on theme upload doesn't include checking for non-existent helpers.
Passes gscan.

I've added a test, and verified that gscan doesn't need updating.  Thanks for your comments @9larsons !

How to use this and what are the uses of the helper?

How to use this and what are the uses of the helper?

I wrote a teeny blog post about it: https://www.spectralwebservices.com/blog/introducing-a-new-helper/
But basically, you put {{content_api_key}} in your .hbs code and it writes out the content API key.  Useful if your theme has javascript that needs to use the api key.
I'd imagine using it for loading your own copy of portal or search or another integration, in combination with #21229.


stream is null during docker pull and not handled

I have this issue, on some user machines this works fine but for some it throws the following errors:
TypeError: Cannot read property 'pipe' of null
    at Modem.followProgress (/data/app/node_modules/docker-modem/lib/modem.js:316:10)

Following is the implementation
docker.pull(repoTag, function(err, stream) {
    docker.modem.followProgress(stream, onFinished, onProgress);
    function onFinished(err, output) {
        ....
    }
    function onProgress(event) {
        ....
    }
}

Docker Version 18.03.1-ce-mac65 (24312)

Could you give more details?
Can't replicate this.

docker.modem.followProgress(stream, onFinished, onProgress);
function buildImage(dockerBuildDir, dockerfilePath, imageTag) {
return new Promise((resolve, reject) => {
var tarStream = tar.pack(dockerBuildDir);
docker.buildImage(tarStream, {
  dockerfile: path.relative(dockerBuildDir, dockerfilePath),
  t: imageTag
}, (error, stream) => {
  containers.add(stream);

  if (error) { reject(error); }
  else {
    stream.on('error', (e) => {
      containers.delete(stream);
      reject(e);
    });
    stream.on('end', function () {
      containers.delete(stream);
      resolve(imageTag);
    });
  }

  followProgress(stream, (err, res) => err ? reject(err) : resolve(res));
});

});
}

I know this is very old, but I had the same issue and it turned out the /var/run/docker.sock did not exist. Once that was corrected, everything worked fine.


how to install

Thanks for the product! I'd love to use this. But I don't see it among the available plugins in lapce. Is there a way I can use it?

The plugin isn't in the available plugins for Lapce as the current stable release does not have the code that the extension requires for inline completions (we've been slow on making new stable releases).
The nightly version of Lapce does support that, so if you use nightly then you can use the plugin.
However since it isn't in the plugin store (no nightly-specific plugins yet :( ) you'll have to build this plugin manually, and then put it in your plugins folder.
Which you can find In Lapce with 'Open Plugins Directory' in the top command palette. Note that nightly/stable use different folders, you'll want to put it in the nightly versions plugin folder.

After a little bit of thought I think I'll just update the copilot dist and then just put it on the plugins site with a warning about it requiring nightly.

Thank you, this is very helpful


AWS toolkit breaks VS IntelliSense

Describe the bug
C# IntelliSense does not show ToolTips when I hover over variables and method calls
To Reproduce
Open a Solution in Visual Studio containing one or more C# source files.
Open a .cs file in the Editor.
Hover the mouse over an event, class, interface, method call, or property.

Expected behavior
A ToolTip appears, displaying the signature of the method or other item, along with any documentation.
Development System (please complete the following information):

Windows Version: Windows 11
Visual Studio Version: VS 2022
AWS Toolkit for Visual Studio Version: Latest

Microsoft confirms that this is a AWS extension bug.

Thanks for reaching out @sinand99 , looking at the linked developer community ticket, it looks like the Refactoring Toolkit is the problem, which is a different extension from the AWS Toolkit for Visual Studio:

I have positively identified that the AWS Toolkit for .NET Refactoring VS 2022 extension (https://marketplace.visualstudio.com/items?itemName=AWSTR.refactoringtoolkit2022) is the culprit.

The AWS Toolkit for .NET Refactoring VS 2022 extension does not have a corresponding GitHub issue, but you can send an email to the team at<EMAIL_ADDRESS>in order to get help. I will now close this issue, as it doesn't relate to the AWS Toolkit for Visual Studio.

Thanks for reaching out @sinand99 , looking at the linked developer community ticket, it looks like the Refactoring Toolkit is the problem, which is a different extension from the AWS Toolkit for Visual Studio:

I have positively identified that the AWS Toolkit for .NET Refactoring VS 2022 extension (https://marketplace.visualstudio.com/items?itemName=AWSTR.refactoringtoolkit2022) is the culprit.

The AWS Toolkit for .NET Refactoring VS 2022 extension does not have a corresponding GitHub issue, but you can send an email to the team at<EMAIL_ADDRESS>in order to get help. I will now close this issue, as it doesn't relate to the AWS Toolkit for Visual Studio.

I just gave it as an example, since both extensions share the same bug. Please do not close this, as it is NOT solved yet.

Hi @sinand99 , I have the AWS Toolkit for Visual Studio installed, and do not have the refactoring Toolkit installed.
I have signed in to CodeWhisperer, and I am unable to reproduce the issue. Here you can see I am hovering over a property, and getting intellisense while calling a method.

You may want to consider disabling and/or uninstalling one or both extensions, restarting Visual Studio, and trying again to see if the issue persists.


increase string value storage length to accomodate larger contains searches

increase length from 200 -> 500
test
Changelog
Migration

Closes #6036

Closing this for now as it will not solve the actual use case issue.


Clarity on versioning

It isn't clear what the current, finished, supported, and semantics of versions/releases are.
https://github.com/operator-framework/operator-metering/releases shows the latest release to be 0.14.0 from last year, but my sense is that the "release-4.x branches" are more recent. I would have assumed that releases 4.0 through 4.5 were finished and actual releases, but I see 4.4 and 4.5 are identical and even with master, having received commits as recently as 8 hours ago.
I have some local customizations that I want to pin to a release version, but it seems like they're a moving target. Please advise (and ideally add some documentation) around this matter.

We currently follow the Openshift release cycle since the 4.0 release and went GA in the 4.2 release. We're currently working on the 4.4 release cycle, which is why master/release-4.4/release-4.5 are all synced with the same commits. For more information about what has changed between releases, you would have to look at the OCP documentation. Here is the docset from the most recent release: https://docs.openshift.com/container-platform/4.3/metering/metering-about-metering.html
I realize this isn't ideal and I can help guide you attaching some changes to a release version.

Thanks for explaining, that makes sense!


Urban Code Deployment Collector is not updating recent changes

When deployment is done via Urban code process, I am not seeing recent changes in the Hygieia dashboard using udeploy-deployment-collector.
Collector reflects only old change in the Hygieia dashboard. How to get all the recent changes in the dashboard?
I have provided Mongo Db configurations, cron value as "udeploy.cron=0 0/5 * * * * " and I am using only one deployment server which is also added in the application properties.
Is this known issue? Kindly help in resolving this.

Can you provide these information:

Did you build the latest collector?
Is your collector running?
Any error log from the collector.

Hi Tabladrum,
I am using the code which was downloaded 2 weeks before. Yes, my collector is running and I don't see any error in the log.

So you are running every 5 hrs? Sorry I always get confused with cron expression.

Cron is running every 5 mins
0 0/5 * * * *

@papithag can you please report on this issue?

@tabladrum , new code worked. Closing this issue


Two liveness checks when using decoy registration with sharing over API

Issue
The delay on the client affords one liveness check but not two serially which is what is currently happening for registrations received over the decoy registration channel then shared over the registration API.
We need to reduce this to one liveness check.
Solution
To address this This pull request makes changes to the protobuf structs used to wrap the ClientToStation message.
Merge ClientToStation Wrappers
The first change is to merge ZMQPayload and ClientToAPI into one protobuf struct called C2SWrapper. This can now be used for both purposes and allows for extra information to be shared ecternal to the actual ClientToStation message (e.g. source and decoy addresses which the application and registration management system would otherwise not have access to).
Add Prescanned flag
I have chosen to add a Prescannedfield to the RegistrationFlags internal to the ClientToStation message. This is the flag that is relied on to indicate if a registration shared over the API has been scanned already or not. The Registration API does NOT interfere with this flag. At the same time I am leaving the DetectorPrescan Registration source so that we can tell how effective registration sharing is and track metrics about it independently of the decoy registration channel.
Notes
Because the Prescanned flag is internal to the ClientToStation message and the Registration API makes no checks to validate the source of registrations or differentiate decoy registrations shared over the API from client registrations submitted through the API clients could set the Prescanned flag on their own. This is not a big concern at this time because the liveness scans exist to facilitate connections, and bypassing the liveness scan only means that a live phantom will break the connection phase for the client.

see also

the gotapdance PR associated with this
the original issue #58


fix(localization): various localization improvements

[x] Add searchType to localization
[x] Localization updateText when change language + minor fixes
[ ] Update title on options screen when change language
[ ] Add {{payload}} (action and ref_type,) to localization file for events screen (eg, "created", "edited", "moved" or "deleted", "commented", etc). See details here. (Important)
[ ] Add support for localization for moment
[ ] Add dynamic language output (view code). (i.e. so that we do not add it manually each time when a new language is supported).
Possible solution: export all available languages (locale/languages/index.js). A new key is added: originalName (or simply title) - this is the national name of the language (it will be displayed). Or something like this (information about the language at the beginning of each language file):

export const en = {
   meta: {
     title: 'English',
     code: 'en',
   },
  // ...
};

Do not hesitate to update this PR, if you want!

I did dynamic output of languages (from file language-settings.js), look, please.
Also I suggest to show native names of languages, instead of in English, i.e. Deutsch instead of German, for example, how do you like this proposal?

Update title on options screen when change language

How can we re-render the title when changing the language?

Also, look at this commit, I did support the localization of events better, it looks like it worked out well, but I want to know your opinion :relieved:

@lex111 you said:

Update title on options screen when change language

I need help! How can we re-render the title when changing the language?

Two "solutions":

Wait for this one https://github.com/react-community/react-navigation/issues/2330 (can be logged in another issue)
I have never tested it yet, but the in the issue 2330, they mention NavigationActions.SetParams. Maybe it can work for us.

@Antoine38660 thanks, but unfortunately did not work NavigationActions.SetParams for me, the title update did not come through.

@Antoine38660 hurraaay, I did it, I misunderstood how to use setParams, in general, you can shoot a smiley of disappointment, it's works! :smile:

Awesome dude! 🎉 🎉 🎉
11/11 checks. I'll look at your code tonight 😃

Woops I'm sorry if I merged it too prematurely in case you wanted to take a look as well @Antoine38660. Please let us know if you see anything that should be changed and we can address it in a future PR


SynatxError with Gulp

Experiencing syntax errors during gulp task. I imagine I am most likely doing something wrong. Figured I would open up an issue anyway. Great library btw!
Using:
Sage Starter Theme  v8.5.1
Gulp v3.9.1
Bower 1.8.0
NPM v4.0.5
Node v6.10.3

What file are you using?
anime.js uses ES6 syntax, try using anime.min.js (ES5).

That's definitely my issue. I don't have ES6 support. Thank you for the quick reply. I should be able to fix my workflow appropriately with this information. Really appreciate it and again, great library!


Seed Heroku via local task w/ param?

In order to use seedbank to seed my staging rails server on Heroku, I currently need to have that personal data in the git repository and I don't want to be forced to have to do that, especially when I open source the project.
I'm thinking of modifying seedbank to accept a parameter that includes this data when it's called through the heroku CLI. Within my seeds, I've already isolated just the data portions for each seed file into a hash within each file.
Basically, I was thinking to modify the code within seedbank, giving it an option to pull from a parameter hash that if received, rather then that data defined within the seed file itself.  Not sure if my use case is that different from others', but do you think this is a good plan?  Or is there a better way?
I kind of liked the idea of separating the data in a more formal kind of way within each of the seed files, since that's what people would be editing, keep it cleaner.  Maybe a separate file XXX_seeds.data.rb

Maybe I am missing something but what is the problem to run heroku run rake db:seed:foo?

food.seeds.rb has to be within git, right?  I don't want any personal data in there or have to deal with another private git branch just to keep it private.

@JimW you probably don't need to actually modify seedbank to do this, you could put the code right in the seeds file couldn't you?
I think of the data in 2 ways, stuff that's not private, but just required to get the app off the ground, that goes into seedbank. Private stuff like user credentials I leave out of production and staging and manually create as it's usually minimal, or I design the app to cater for that being absent. YMMV but I find that balance has never tipped heavily towards the private data.

I'm releasing an app that at it's core, deals with google accounts, so all the test data that is used for staging, needs to be valid google accounts (and so private) to actually test stuff while in staging.  I would think that is the case with any kind of server app that allows individual accounts to communicate with other APIs.  So in this case, I just can't find a workflow for dealing with test data on Heroku using seedbank, as it is, if I'm restricted to having to keep that data in github.  Simplest solution I found, was just to find a way to pump it through seedbank during the call from my local machine, where private data could live happily.

I ended up putting all my seed data for my app into a single yaml file, where it's easier to see and define everything.  So rather than dealing with separate files and prerequisites via seedbank, I just deal with them all in the original seeds.rb as I'm consuming my yaml from aws s3.  Seedbank is nice though, just not what I need right now.

Glad you found a solution.


HintOptions for Args

I'd like to have HintOptions for an Arg.
Example usage:
./move <DIRECTION>

where DIRECTION could give hints on up, north, and so on.
It's currently only possible to add HintOptions on Flags AFAIK.

I see now that it's present in master. 😄
I guess we can keep this open until that version has been released..?

Pushed 2.2.0!

👏👍
Den tis 12 juli 2016 06:18Alec Thomas<EMAIL_ADDRESS>skrev:

Pushed 2.2.0!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/alecthomas/kingpin/issues/131#issuecomment-231933388,
or mute the thread
https://github.com/notifications/unsubscribe/AAAGP9jIXZ4ODnevXa1PHYgBPh-zFDpuks5qUxWBgaJpZM4I6hM3
.


docs.vuestorefront.io documentation does not reflect the recent .md doc files on GitHub

Current behavior

The current https://docs.vuestorefront.io/guide/modules/introduction.html does not reflect the most recent version of https://github.com/DivanteLtd/vue-storefront/blob/master/docs/guide/modules/introduction.md.
Expected behavior

https://docs.vuestorefront.io/guide/modules/introduction.html and the .md files on GitHub, e.g. https://github.com/DivanteLtd/vue-storefront/blob/master/docs/guide/modules/introduction.md are on par.
Steps to reproduce the issue

Repository

https://github.com/DivanteLtd/vue-storefront/blob/master/docs/guide/modules/introduction.md
Can you handle fixing this bug by yourself?

[ ] YES
[X] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser:
OS:
Node:
Code Version:

Additional information

Fixed!

Thanks!


Issue with KVK stats display being visible

Hello, I love your tool and since the recent update there was one tiny problem for me, the new KVK stats system struggles to analyze data when the stats are visible and not hidden, I think this has to do with the button to extend killpoints overlapping and as there is a small delay after clicking out of the KVK data button, the
-> Line 236 :
            for _ in range(2):
                device.shell(f'input tap 1118 314')

loop seems not to be enough and it just skips the killpoints tiers analysis unless the player has kvk stats hidden, as that allows the killpoints button to be clicked in time. I figured adding some delay
            for _ in range(2):
                time.sleep(0.5)
                device.shell(f'input tap 1118 314')

fixes my issue.
Maybe I did something wrong when setting up the tool ?
Thanks!
The button I'm talking about :

New version has been uploaded. Please check with this one. This one, should not be affected by computer's speed.
Thank you.


Compatibility with the Notebook Pro GTX 1050 ?

Hi,
Are these mods compatible with the GTX 1050 version?
If not, is there anything else available for it?
Thanks

Sorry they are not!


harmonize jsdoc

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.006%) to 99.573%

Files with Coverage Reduction
New Missed Lines
%

src/modules/olMap/handler/measure/OlMeasurementHandler.js
1
96.71%

Totals

Change from base Build<PHONE_NUMBER>:
-0.006%

Covered Lines:
11973

Relevant Lines:
11978

💛  - Coveralls


rados: prevent building go-ceph/ioctx_octopus.go (downstream only)

As the few rados api's are not available in downstream ceph image.
Adding the unmet Build Constraint rhcs_next to prevent this file
from building.
Signed-off-by: Mudit Agarwal<EMAIL_ADDRESS>This needs to be removed once we start using RHCS5 for OCS4.9
/cc @Madhu-1 @nixpanic

LGTM, but how can this be tested before merging?

We can't test this, lets try to enable github actions asap for future PRs