Per-pod native sidecar enablement

(This is used to request new product features, please visit https://github.com/istio/istio/discussions for questions on using Istio)
Describe the feature request
We’d like the ability to control which pods use native sidecars, as we run a multi-cluster setup, and not all clusters are running new-enough kubernetes (1.28). Ideally this would be an annotation on the pod spec.
Describe alternatives you've considered
Waiting until all of our workload clusters are running k8s 1.28
Affected product area (please put an X in all that apply)
[ ] Ambient
[ ] Docs
[ ] Dual Stack
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

https://github.com/istio/istio/issues/48794 could also solve your probably in a different manner. But per-pod is probably also useful

I think there are (at least) two somewhat natural options for said per-pod enablement (for arguments sake, let's call it injectNativeSidecar):

Add it to proxyConfig, similar to HoldApplicationUntilProxyStarts
Create a new annotation, similar to sidecar.istio.io/rewriteAppHTTPProbers

Do you have a strong preference between them? I have a slight preference towards the annotation, as proxyConfig is already somewhat of a pain to merge in our tooling, but if required would be fine.

My current assumption is native sidecars are going to something that we want ~universally, and we just have some transition pain due to versions. Based on that, a more temporary solution (annotation) seems appropriate. I would call it sidecar.istio.io/native-sidecar: true/false perhaps (the 'sidecar' bit is repeated which is a bit awkward, but 'native' on its own is odd as well).

note to self, use nativeSidecar instead of native-sidecar

Even if native sidecars are going to be most likely something enabled on the whole cluster long-term, it's important to allow people to enable a few pods initially so they can test the stability. Keep in mind that this is still a beta feature of K8s and it is risky to set the whole cluster without previous testing.

Even if native sidecars are going to be most likely something enabled on the whole cluster long-term, it's important to allow people to enable a few pods initially so they can test the stability. Keep in mind that this is still a beta feature of K8s and it is risky to set the whole cluster without previous testing.

This was implemented in https://github.com/istio/istio/pull/53490 so you should be able to do this.
FWIW, its not easy but you can always test out global settings like this with Istio canary installs as well.


Can't dynamic create PersistentVolume after PVC created. Operation not permitted #904

quay.io/cephcsi/cephcsi v3.1.0 docker image
There seems to be the same problem，error:= failed to get connection: connecting failed: rados: ret=13, Permission denied. change to image quay.io/cephcsi/cephcsi:canary it's ok ,pls help check, thanks!
explain:
[root@master01 ceph-csi]# git branch
(detached from v3.1.0)
devel
[root@master01 ceph-csi]#
[root@master01 rbd]# kubectl -n ceph-csi describe pod csi-rbdplugin-provisioner-5f9d8fb9c6-4l8xf|grep quay.io/cephcsi/cephcsi
Image: quay.io/cephcsi/cephcsi:canary
Image ID: docker-pullable://quay.io/cephcsi/cephcsi@sha256:678dbf3dada23438ae101175e7ce893565982b6ff2362b19c7c4f13254446663
Image: quay.io/cephcsi/cephcsi:canary
Image ID: docker-pullable://quay.io/cephcsi/cephcsi@sha256:678dbf3dada23438ae101175e7ce893565982b6ff2362b19c7c4f13254446663
Normal Pulling 19m kubelet Pulling image "quay.io/cephcsi/cephcsi:canary"
Normal Pulled 16m kubelet Successfully pulled image "quay.io/cephcsi/cephcsi:canary"
Normal Pulled 16m kubelet Container image "quay.io/cephcsi/cephcsi:canary" already present on

3.1.0 is too old and it's not supported anymore. @easonboy have you tried the 3.4.0 image?


Could not load html change?

Souce code
When i change 'src/index.html',build file 'dist/index.html' not update.

please try the 2.0 branch

"html-webpack-plugin": "^2.0.3"

Seems to work here


twister: ignore unencodable unicode of west flash command.

sometimes there are some unencodable unicode chars from output
of west flash command, need to ignore them rather than reporting
an error.
this fix is from zephyr side, add handler to handle unencodable unicode chars in twister.
fix: #42098
Signed-off-by: Chen Peng1<EMAIL_ADDRESS>

This is ignoring garbage output from all tools in the entire universe just for the sake of a single bug in a single tool: thesofproject/rimage/issues/86
Great for increasing the PASS rate in the short term, not so good in the longer term...
As I just recommended in thesofproject/rimage/issues/86, can you try (temporarily) dropping the -v option of rimage instead?

dropping the -v option of rimage instead

@marc-hb  I didn't invoke rimage with "-v" option, the main problem is that this debug info "dump_cse_v2_5(hdr, out);" will always be output, because the condition "if (1 || verbose)", this is always true, the source code in rimage like below.
seems a mistype, I tried to use "if (verbose)" and rebuilt rimage, then it won't output this debug info.
static int parse_cse_v2_5(const toml_table_t *toml, struct parse_ctx *pctx,

       hdr->nb_entries = toml_array_nelem(cse_entry_array);

       if (1 || verbose)

                dump_cse_v2_5(hdr, out);

and also I think this would be better to be fixed from rimage side, but from zephyr side, we also need to increase the stability of twister script to handle more exceptions.

because the condition "if (1 || verbose)", this is always true

I just understood that, sorry for the earlier suggestion. Let's discuss rimage in thesofproject/rimage/issues/86

we also need to increase the stability of twister script to handle more exceptions.

This PR is not "handling more exceptions". It's ignoring garbage which means it's ignoring bugs = the opposite purpose of a test tool which is meant to find problems. Moreover it's now ignoring bugs in the entire "universe" of flash tools (which have apparently never caused any issue) all because of single bug in a single (and hackish) signing tool.

this only ignore those errors caused by decoding issue with some unrecognized chars when doing flash, actually, it doesn't influence flash, it is just a display error in twister debug log, for other errors of flash, we still can capture them, but we do not want to twister will be blocked to run all tests just due to this minimal issue.

I agree this should not block twister from running all tests. I didn't realize it did.
However it should report a test failure whenever this happens.

yes, it would be better if we not only can handle this error, but also report it out.

rimage fix submitted in

https://github.com/thesofproject/rimage/pull/88


Global tags are not applied to custom CloudFormation resources

Is your feature request related to a problem? Please describe.
Currently the global tags feature global tags does not apply to resources defined in custom CloudFormation templates defined in customizations-config.yaml. We would like to use the same templates for different customers that have different requirements for tags without having to change all our CFN templates.
Describe the feature you'd like
Make the global tags feature apply the tags to all resources including those defined in custom CloudFormation templates in customizations-config.yaml

Hi Martin! Thank you for utilizing the Landing Zone Accelerator on AWS (LZA) solution. As you mentioned, we currently apply the global tags to the CDK constructs that LZA natively supports. I've put in a feature request for this particular use case. As I cannot provide a timeline on the implementation of this feature, I will keep this issue open in the meantime should you have any relevant questions or concerns.


[eventhubs-checkpointstore-blob] Add missing dev dependencies

Missing dependencies were masked by Rush configuration which merges dependencies across packages

I'm not sure what the merge conflict is but looks good. How did you detect that it was missing the dev dependency?

@chradek: Rush is adding an option implicitlyPreferredVersions which we plan to set to false for a few reasons.  First, it allows Rush to support multiple conflicting versions of peer dependencies, which are not supported if implicitlyPreferredVersions=true.  Second, Rush now feels this is the better default and should be enabled going forward (it defaults to true when using<EMAIL_ADDRESS>though we are still using<EMAIL_ADDRESS>since 4.0.0 dropped support for Node 8).
Fixing these missing dev dependencies is one step in enabling implicitlyPreferredVersions=false, but there are still other issues we need to fix before we can merge the config change to enable this.
More info: https://github.com/microsoft/rushstack/pull/1618


Fix gmm regularisation and issues with div by zero

This PR fixes some parts of the the GMM model that were causing instability issues:

covariance regularisation is applied during the update step i.e applied to each batch instead of only at the end of an epoch.  This ensures that the covariance matrices for the components are positive definite.

If there are still issues with singular covariance matrices, the linalg error is caught and a more informative error message is raised (as is done in sklearn )
Two parameters are added to control the regularisation, one for the model which is initialised and run for a single epoch, and another for the actual model which is trained using batch training for multiple epochs.

very small values (1e-16) are added dividing by the component_weights, this is because when training on batches, some of the components may have zero samples, and thus zero weight.

Two other changes are made:

When sampling, the component probabilities are converted to 64 bit precision and then normalised to ensure they are between zero and 1. There is an issue linked in the code to explain why this is necessary.
If more than 10% of the components have zero data assigned to them, a message is printed alerting the user and suggesting that they should consider reducing the number of components.

With these changes, I can run a gmm with at least 300 components. I tried running with 1500 but I still get issues with singular covariances matrices. I inspected the covariance matrices and the values are very high, so I'm guessing we'd need a very high regularisation parameter to have a large enough regularising effect. I didn't push this any further, because over 90% of the components had zero weight.

Note that I haven't changed the regularisation for other covariance types ("diag", "spherical", "tied"). I think these might be bugged anyway so I don't plan to change them in this PR. If we want to support them then we can make a follow up PR to fix the implementation and add regularisation.


unmarshal errors when calling payment.Client.Get

Hi, It's me again... sorry. I'm reporting a similar error to #38 but with other fields when calling payment.Client.Get. This time I fixed locally one by one, getting error after error, until success.
All the errors I found so far:

"json: cannot unmarshal string into Go struct field ItemResponse.additional_info.items.unit_price of type float64".
"json: cannot unmarshal string into Go struct field OrderResponse.order.id of type int"

go version go1.22.0 darwin/arm64
github.com/mercadopago/sdk-go v0.0.0-20240314131414-b9fd995267f8

Hello, thanks again 😅.
Fixed it.


Parallel Wheel Builds

Overview

Add parallelized build strategy for wheels to reduce build times.
Add Python 3.12 wheels.
Add mullinux wheels in addition to manylinux wheels.
Add validation tests (agent_unittests) to end of wheel build process.
Update actions used in build and deploy to newer versions.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c3314ae) 81.03% compared to head (b08ced5) 81.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1024      +/-   ##
==========================================
- Coverage   81.03%   81.03%   -0.01%
==========================================
  Files         190      190
  Lines       19640    19640
  Branches     3431     3431
==========================================
- Hits        15916    15915       -1
- Misses       2732     2734       +2
+ Partials      992      991       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Closing this since this PR does it and more: https://github.com/newrelic/newrelic-python-agent/pull/1024.

@hmstepanek You closed the wrong one 😆


Add ability to sign metadata. (Improved)

Related to #207.
Improved:

Test: Added signature validation
prettyprint optional on metadata generator in order to avoid signature validation problems.
signature position fixed. Now is placed at the top,

Fix algorithm calculator. This method was wrong

@Lordnibbler, @luisvm what do you think about this PR?

comments aside looks good :+1:


[SPARK-28314][SQL] Use the same MemoryManager when building HashedRelation

What changes were proposed in this pull request?
Broadcasting some tables with a large number of rows may cause infinite recursion loop in TaskMemoryManager#allocatePage.
This is because HashedRelation uses Long.MaxValue to construct MemoryManager instead of memory configured by driver.
MemoryAllocator#allocate throws OOM,TaskMemoryManager#allocatePage captures OOM and continues to call allocatePage.
How was this patch tested?
add UT

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test build #4817 has started for PR 25084 at commit b56705c.

Hm, interesting, that does look odd that it makes a new memory manager instead of using one from the env. @JoshRosen or @davies do you recall any reason we couldn't make this change?

It looks like SPARK-11309 is a ~4-year-old TODO to clean this up.
Chasing through git blame, it looks like the new TaskMemoryManager was introduced in an even earlier patch: https://github.com/apache/spark/pull/7592#discussion_r35400866
I think this is because broadcast variable memory is not exclusively owned by a single task:

We only deserialize HashedRelation in broadcasts.

In TorrentBroadcast, we use locking to ensure that each executor JVM holds a single copy of the re-assembled broadcast.

When a task reads a broadcast variable, we take out a block manager read lock and release the read lock at the end of the task. This ensures that the block manager doesn't evict the reconstructed broadcast while it is still in use by a task (doing so would mess up the memory accounting: after eviction, the block manager would assume that the on-heap broadcast variable was garbage-collectible, but it can't be collected if it's still being used by a task).

All memory allocated by a TaskMemoryManager is automatically cleaned up at the end of a task when Executor calls cleanUpAllAllocatedMemory(). If we use the current task's TaskMemoryManager to allocate the pages for the reconstructed broadcast variable then those pages would be freed once the first task completed, causing use-after-free problems in the other tasks sharing the same broadcast variable.
In the current code, we create a dummy TaskMemoryManager for each deserialized broadcast and never call cleanup (instead, letting the GC handle it for us). This is why the old code has a comment about using on-heap memory: if you allocate off-heap memory here then it'll never be freed back to the UnifiedMemoryManager, eventually causing an OOM.

This illustrates some problems with our current memory abstractions: we don't have a good way to use the Tungsten managed buffers / memory blocks for storage memory. Given this, I think we may need a different short-term fix for the infinite recursion than this patch's current code. Maybe we could pass in a depth flag to detect when we're recursing and use that to prevent infinite recursion?
(By the way, the wide scoping of the catch OutOfMemoryError feels dodgy to me: this should probably be narrowed down to only catch OOMs when allocating the MemoryBlock's backing long[] array, then wrap and re-throw as a SparkOutOfMemoryError)

Thanks to @JoshRosen for explaining that we can't use env's memory manager at the moment.
I simply implemented the call to TaskMemoryManager#allocatePage record depth.
Throw SparkOutOfMemoryError if more than 10000 times. 10000 times does take a while, and the cpu load becomes a bit high.
However, this will get 10000 logs with failed allocations. I am not sure how many times to throw an exception is reasonable.
Also, can we respect the current configuration to create a dummy TaskMemoryManager instead of using Long.MaxValue ?
Val memoryManager: MemoryManager = UnifiedMemoryManager(conf, numUsableCores)

I don't think that picking an arbitrary high limit like 10,000 is a good idea. Instead, I think we should try to gain a deeper understanding of the circumstances where we might attempt to allocate, fail, then retry and fail again.
My intuition is that an allocation failure followed by a spill followed by another allocation failure means that we're doomed such that a third retry won't succeed. I think (but don't remember offhand) that when a memory consumer asks another consumer to spill then the spilled memory is atomically transferred to the consumer that requested the spill, so it seems unlikely that we'd get into a situation where we need more than a single spill to successfully allocate memory (because if spilling back-to-back can succeed then why wouldn't we have just spilled all of that memory in the first spill call?).
It's admittedly been a couple of years since I've touched this part of the code, though, so my understanding could be outdated.
If we're able to determine that back-to-back spills won't succeed, though, then we could potentially avoid this depth-limit constant choice problem and instead just bound it at 1 or 2.

I found some logs in the production environment.
Sometimes BroadcastMode#transform can succeed after multiple failed allocation logs appear.
If use Runtime.getRuntime.maxMemory*spark.memory.fraction or Runtime.getRuntime.maxMemory, although the allocation(TaskMemoryManager#allocatePage) is unsuccessful, memoryForTask accumulates the number of allocations each time, so after several failures, it will exit the recursive allocatePage call and throw a SparkOutOfMemoryError.
 Storage limit = 1185.6 MB.
19/07/18 20:10:49 WARN BlockManager: Persisting block broadcast_12 to disk instead.

Can one of the admins verify this patch?


Adding message to update rosa CLI if incompatible roles are found

Based on feedback by end user, updating the message to suggest updating rosa CLI to latest version and try again if incompatible roles are found. Not sure if this would work and be valid for all versions and latest rosa CLI yet but I think its worth adding if its supported.

@ravitri account roles will also be not compatible if the user already has rosa 1.1.8 and created account roles for ocp 4.8. Planning to use the same rosa 1.1.8 to install a fresh ocp 4.9 cluster then they need to run the account roles again if not they will get the above error. Having said that i m not sure if we can ask the user to always download the latest rosa cli to create a cluster.
@arendej  can you PTAL.


⚠ ClamAV has degraded performance

In d2e9b1a, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 87 ms

Resolved: ClamAV performance has improved in d14e818 after 6 minutes.


Behavior changed: workbench.action.navigateBack

The behavior of workbench.action.navigateBack appears to have changed unexpectedly. When the same file is open in multiple editor groups it used to navigate within the same editor group. Now, it will prefer to navigate to any editor group where the file is visible before navigating to same file in the current group.
This is a little subtle to explain, but it substantially hinders my ability to edit because I can't predict where focus is going to jump based on where I actually moved the cursor.
Imagine I have 2 files: A and B. I open A in 2 editor groups, side-by-side, like this:
<(A)> | (A)
Here the parenthesis denote visibility, angle brackets denote focus, and the vertical pipe denotes separate editor groups. Next, I "Go to definition" on a symbol in the left group that navigates to another file in a new editor:
A <(B)> | (A)
Now B is focused in the left group. Next I workbench.action.navigateBack to return my cursor to the previous location. I expect this to focus A in the left group, because that's where my cursor actually was. Instead, this focuses A in the right group:
A (B) | <(A)>
I don't know exactly when this changed, but I believe it was in the last 2-3 months.
Issue Type: Bug
VS Code version: Code 1.62.2 (3a6960b964327f0e3882ce18fcebd07ed191b316, 2021-11-11T20:56:38.428Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-9600K CPU @ 3.70GHz (6 x 3696)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.92GB (21.64GB free)

Process Argv
--crash-reporter-id ba5ddb4a-051a-4a6e-a317-30ba05374695

Screen Reader
no

VM
0%

Extensions (22)

Extension
Author (truncated)
Version

unique-lines
bib
1.0.0

auto-align
bla
0.0.13

graphviz-preview
EFa
1.5.0

vsc-material-theme-icons
equ
1.2.2

vscode-pull-request-github
Git
0.32.0

customize-ui
ioc
0.1.54

monkey-patch
ioc
0.1.15

vsc-space-block-jumper
jmf
1.2.2

Lua
key
0.0.9

polacode-fixed-edition
mrr
0.3.6

jupyter
ms-
2021.10.1101450599

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.3

remote-containers
ms-
0.205.2

remote-ssh
ms-
0.66.1

remote-ssh-edit
ms-
0.66.1

remote-wsl
ms-
0.58.5

vscode-remote-extensionpack
ms-
0.21.0

cpptools
ms-
1.7.1

code-settings-sync
Sha
3.4.3

dot
Ste
0.0.1

vscode-todo-highlight
way
1.0.5

(1 theme extensions excluded)

I'm confused. I swear this changed because it's a core part of my workflow, but I'm seeing issues 5 years old (!!!) with a ton of upvotes.
https://github.com/microsoft/vscode/issues/9526
https://github.com/microsoft/vscode/issues/45233
https://github.com/microsoft/vscode/issues/130663
https://github.com/microsoft/vscode/issues/108422
https://github.com/microsoft/vscode/issues/89903

There were no changes as far as I can tell, but the linked issues make sense to me.


Show help output on when enroll is missing required args. Fix configT…

…ypes=all processing on list services. Fixes GH-155

@plorenz @andrewpmartinez Making the JWT positional does make sense, but we've already created wrapper scripts to enroll the edge-routers.  This change will break existing scripts already released into the production environment.   Cloud we do both?  positional or have a switch(--jwt/-j)?


Casanovo Mztab file confirmation

Hi,
I ran the casanovo code in the google colab environment and produced the file linked here, can i confirm that it was done correctly.
(https://drive.google.com/file/d/1kgVxg17Mtwi4lyoBKsSDKkILNnOaxyiY/view?usp=share_link)
I am concerned with the output as when i opened it on notepad, and there weren't peptide sequences, or PSM in the columns on the bottom of the file.
Initially I thought it was running fine with the example file and that my experimental files were corrupted, but it seems the example file did not produce peptide sequences within the output file.
Can I get advice on this matter?

Can you make your file on Google Drive publicly accessible? I get access denied at the moment.

Hi I've edited the access on it!
Please advise me if there's any other access issues!
On Wed, 29 Mar 2023, 14:47 Wout Bittremieux, @.***>
wrote:

Can you make your file on Google Drive publicly accessible? I get access
denied at the moment.
—
Reply to this email directly, view it on GitHub
https://github.com/Noble-Lab/casanovo/issues/155#issuecomment-1488649323,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6S5RMZLLHPSHZXUX3ESOZTW6Q4N3ANCNFSM6AAAAAAWL5N4JE
.
You are receiving this because you authored the thread.Message ID:
@.***>

The output is indeed incomplete. This indicates that Casanovo didn't finish successfully. The header information is written at the start of the execution (present in your file), whereas the PSMs are written after the data has been processed (missing in your file). So something happened that prevented Casanovo from completing.
Can you share the full Casanovo log file?

Hi, I don't have the specific one for that run, but i re-ran the code and the output is the same, and the log in the folder here along side this run's output file
(https://drive.google.com/drive/folders/1LQrc4n2iZbMd5hvTp5_6EB1lRsJdpT-K?usp=sharing)

Can you provide some more information how you ran Casanovo? There are a few aspects that are unclear to me:

The log contains output for 4 executions of Casanovo. Did you run it multiple times?
On line 95 in the log I see UserWarning: Detected KeyboardInterrupt, attempting graceful shutdown... Did you stop the execution at some point?
I also don't see the final line you provided in the log, wheres normally the output and log should be identical.

So I had ran it a few times, the run after the last keyboard interrupt was
the one I have with this file.
After the code had finished I downloaded a copy of the log , and then
waited 10- 15 minutes before downloading the files again and put those in
the folder, and I checked it once through again and there wasn't a change
on the log.
On Fri, 31 Mar 2023, 08:59 Wout Bittremieux, @.***>
wrote:

Can you provide some more information how you ran Casanovo? There are a
few aspects that are unclear to me:

The log contains output for 4 executions of Casanovo. Did you run it
multiple times?
On line 95 in the log I see UserWarning: Detected KeyboardInterrupt,
attempting graceful shutdown... Did you stop the execution at some
point?
I also don't see the final line you provided in the log, wheres
normally the output and log should be identical.

—
Reply to this email directly, view it on GitHub
https://github.com/Noble-Lab/casanovo/issues/155#issuecomment-1491475423,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6S5RM7TRPJ67GUG2ET3BP3W62FFXANCNFSM6AAAAAAWL5N4JE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Do you mind sharing your notebook from Colab so I can try to recreate the issue?

(
https://colab.research.google.com/drive/1VD5cg6uC1xJj9J_GrHMuk6fVRMmKHUZ0?usp=share_link
)
Hi this is the link for the colab note book
Please note: there are some installations to help with the environment in
Google colab.
Also the spectra mgf file will need to be uploaded before casanovo reads it

every time the session is cut, it deletes all the file in the notebook.

On Fri, 31 Mar 2023, 10:34 Wout Bittremieux, @.***>
wrote:

Do you mind sharing your notebook from Colab so I can try to recreate the
issue?
—
Reply to this email directly, view it on GitHub
https://github.com/Noble-Lab/casanovo/issues/155#issuecomment-1491632327,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6S5RM224AN5IXSGQJSWIMTW62QMHANCNFSM6AAAAAAWL5N4JE
.
You are receiving this because you authored the thread.Message ID:
@.***>

I simplified the Colab notebook a little bit, but I didn't have any issues running it.
One key thing to check is to make sure that you're using a Colab instance that has access to a GPU, as we're currently still solving a CPU-related bug (#106).
I'm going to close this issue, because I can't reproduce any problems. If problems persist on your end, please let us know.


Project details page layout

I like the look of the revised project details page, and having everything on a single save, but I've just realised that it's very easy to miss the save button. When you're configuring the guidance, the save button is off screen (you need to scroll down). I had checked a guidance box and navigated away without a notification of unsaved changes.
@jollopre had introduced an autosave for the guidance checkboxes so perhaps this is worth reintroducing? Or repositioning the save button higher up the page so it always on screen, or adding a notification of unsaved changes?
@JEK-III can you advise?

Good to capture this here. Button positions, refining all page layouts, etc are a later-stage task once all new features have been added so will also be addressed by UX and as part of #424.

We also flagged the need to add the PI/Data Contact Phone No. below Email on this page.
I think autosave was implemented throughout the site but maybe not on the project details page. @jollopre can we autosave all the things?

Hi @stephaniesimms The autosave had been added to the guidance configuration and write plan page by @jollopre but seems to have been lost on both with recent changes. I noticed as I could change tabs without any warning of unsaved changes. Autosaving throughout the site would be best in my opinion too so hopefully we can implement that

Yes. Jose's code is still there, it stopped firing though when the HTML structure of the pages changed. Its fairly easy to add it back in.
Do we want to just make the guidance auto-save or would we like the project details themselves to auto-save?

@sjDCC I've added the auto-save functionality back into the write plan page (pending a PR before I can deploy).
I'm looking at dmponline-test though and can't seem to get the warning message about unsaved changes to appear. The auto-save waits a few seconds to fire, so there is a brief lag after the user makes their change when they can click on the share tab or navigate away via the menu. I have tried multiple approaches but the warning never appears.

Thanks @briri. Good to know it was there but just not firing. And thanks for reinstating it.
We used to have a warning that popped up when you moved between sections with unsaved changes but I think the autosave replaced this. That does leave a couple of seconds where you could navigate away but probably low risk.
The place I'd lost changes was on guidance configuration. Here I guess it's good to implement autosave on whole page (covering guidance config and plan details).
I agree with you that it would be best to have autosave throughout site. It's more googledocs style, which is approach we're going for long term I think anyhow

The page is no longer auto-saving after we moved all of the JS over to ES6 and webpack. I'm going to close this one out, we should create new tickets for any pages we want to start auto-saving.


Containerize the microservice using Docker

As a developer, I want to containerize the microservice using Docker to ensure the application runs in the same environment across all platforms.

As a developer
I need to containerize my microservice using Docker
So that I can deploy it easily with all of its dependencies
Assumptions

Create a Dockerfile for repeatable builds
Use a Python:3.9-slim image as the base
It must install all of the Python requirements
It should not run as root
It should use the gunicorn wsgi server as an entry point

Acceptance Criteria
Given the Docker image named accounts has been created
When I use docker run accounts
Then I should see the accounts service running in Docker


set transparent background png compass

using attribute translucent_background

working as intended

All seems to work. Feel free to merge. 👍


Event log with missing previous link

It appears that in some conditions the link with the previous event log is lost, causing the state of the participant to be wrongly reported in the event activity.

Possibly linked to https://github.com/kalisio/aktnmap/issues/247.


Allowing several fields in a Person record to be empty.

We may not know a person's middle name, email address, nearest airport, etc., so this PR modifies the Person model to allow those fields to be missing.

On Tue, Jan 06, 2015 at 08:32:43PM -0800, Greg Wilson wrote:

We may not know a person's middle name, email address, nearest
airport, etc., so this PR modifies the Person model to allow those
fields to be missing.

Most of these make sense to me, but I think Person.slug should be
neither nullable nor blank.  It looks like we use Person.id in most
places as the identifier, but we use Person.slug for badge strings:
result[badge.name] = [{"user" : p.slug, "name" : p.fullname()} for p in persons]
We may also use it in other places (I'm not sure).  In any case, if we
want the slug as an alternate ID field complementing Person.id, I'd
require it for all people.

We only need a non-empty person.slug when we're issuing a badge (or
adding someone to the website for some other reason), so in almost all
cases it can safely be NULL.

On Wed, Jan 07, 2015 at 11:06:24PM -0800, Greg Wilson wrote:

We only need a non-empty person.slug when we're issuing a badge (or
adding someone to the website for some other reason), so in almost
all cases it can safely be NULL.

Once we get student badges, I think a majority of Person instances
will have badges.  Event with the current database:
$ python3.4 ./manage.py shell

from workshops.models import Person

Number of people:

Person.objects.all().count()
7517

Badged people:

Person.objects.all().exclude(award=None).count()
322

Learners (who may eventually be getting skill badges):

Person.objects.filter(task__role__name='learner').count()
6559

So once we add learner badges, we'll have:

from django.db.models import Q
Person.objects.filter(
...     Q(task__role__name='learner') |
...     Q(award__isnull=False)
... ).distinct().count() / Person.objects.all().count()
0.8903818012504988

almost 90% of our People badged.
I'm not sure how “added to the website for some other reason” is
represented in the database, but unless it's in there somewhere it
will be hard to ensure we've slugged everyone that falls into that
category.  I think it's easier to just create slugs for everyone.

On Thu, Jan 08, 2015 at 08:50:15AM -0800, W. Trevor King wrote:

I think it's easier to just create slugs for everyone.

Alternatively with #70 we could use Person.username as a slug, and
have people slug themselves when they create an account (e.g. to
register as a trainee).

Only a handful of people will need login accounts for the foreseeable future - this is not going to be a self-serve system, and we can add logic to check that Person.slug is non-empty when assigning badges.

On Sat, Jan 17, 2015 at 09:35:58PM -0800, Greg Wilson wrote:

Only a handful of people will need login accounts for the
foreseeable future - …

Ok.  I don't see anything in the docs that says a person needs to have
a non-null username 1, but the uniqueness constraint doesn't play
well with string fields if we have multiple blank-string entries, and
Django won't store NULLs for empty strings 2.  I guess that means
I'll need a separate username field for #147, and we'll just live with
the overlap between it and the slug field.

Everyone who will ever be allowed to log in will have a non-null,
non-empty slug slash username - will that get us through?

On Sun, Jan 18, 2015 at 12:46:36PM -0800, Greg Wilson wrote:

Everyone who will ever be allowed to log in will have a non-null,
non-empty slug slash username - will that get us through?

It won't let us use the slug as the username, since the username's
unique requirement is about a database constraint, and Django doesn't
give you the “multiple NULL entries don't violate uniqueness” out with
string-based fields (as described in the ticket 4136 I linked
earlier).

Gotcha.  OK, username field it is - or do you want to have a completely
separate model for login accounts with username/password info and a
possibly-null foreign key ref to a Person?

On Sun, Jan 18, 2015 at 02:50:41PM -0800, Greg Wilson wrote:

… or do you want to have a completely separate model for login
accounts with username/password info and a possibly-null foreign key
ref to a Person?

No, since I see no reason to distinguish between “people that can log
in” and “people we track” beyond a null password (or false is_active,
or whatever).  They're still all people.

This one has fallen out of date, and should not be a blocker.


MM-13924 Ensure OpenGraph and message attachment images go through the proxy

Doing this on the app instead of the server because it might otherwise cause problems when we're requesting image dimensions. I was looking at a more generic way of doing this, but this doesn't seem like the time to add it since we're just about to kick off RC testing.
Ticket Link
https://mattermost.atlassian.net/browse/MM-13924
Checklist

Added or updated unit tests (required for all new features)

@hmhealey Sorry for the delay. I overlooked this from my review queue.


Re-enable auto updating of members

@hythloda Please review and make sure the member logo list is correct. Thanks!

well we have a new issue that "White Source Ltd., d.b.a mend.i" doesn't like their given name and want to be called just "mend.io"  I made the changes in LFX. But will that propagate down the pipeline?

well we have a new issue that "White Source Ltd., d.b.a mend.i" doesn't like their given name and want to be called just "mend.io" I made the changes in LFX. But will that propagate down the pipeline? They are watching the landscape pretty closely right now since they just annouced.

Mend is not in the right spot :(

Hi! I can keep trying through the day to see when the API updates. So far, it's showing the old name.
I see mend.io is a 'General' member, and it shows for me in that section; not sure if you are referring to something else..

Got it - yeah that would be corrected once the right company name is
populated.
On Thu, Sep 21, 2023 at 1:55 PM Amanda L Martin @.***>
wrote:

Hi! I can keep trying through the day to see when the API updates. So far,
it's showing the old name.
I see mend.io is a 'General' member, and it shows for me in that section;
not sure if you are referring to something else..
They are general but should be in the M section after Lockheed... not in
the WXYZ section.
—
Reply to this email directly, view it on GitHub
https://github.com/ossf/ossf-landscape/pull/343#issuecomment-1730045825,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACIOIIUF6C3ERKRPDVT3VLX3R5PLANCNFSM6AAAAAA5B4TBV4
.
You are receiving this because you authored the thread.Message ID:
@.***>

@hythloda ok - this should be better now; can you double-check the build and make sure there is nothing else that is wrong?

LGTM


implement an appender for Log4Cplus

closes #19

Pull Request Test Coverage Report for Build 245

43 of 46 (93.48%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+3.9%) to 93.478%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

include/crow/integrations/loggers.hpp
7
8
87.5%

include/crow/integrations/log4cplus.hpp
36
38
94.74%

Totals

Change from base Build 232:
3.9%

Covered Lines:
43

Relevant Lines:
46

💛  - Coveralls


Corrected sub-list indentation

Corrected the indentation of the sub-list points 4a and 4b, which were, earlier, not indented properly.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @sanket0896,Thanks again for the PR! We want to show our appreciation by sending                                              you some swag. Could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


Update UG with optional fields regarding acad details for add and edit

Fix #49

Codecov Report

Merging #51 (258717a) into master (af06165) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #51   +/-   ##
=========================================
  Coverage     72.39%   72.39%
  Complexity      409      409
=========================================
  Files            71       71
  Lines          1268     1268
  Branches        132      132
=========================================
  Hits            918      918
  Misses          313      313
  Partials         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af06165...258717a. Read the comment docs.


New addons base image

Move to a new clear centos 7 base image.
Still to do:

do we need peep-support? (which was available in the old base-images but we don't seem to use it?)

This requires nodejs 0.12.x https://bugzilla.mozilla.org/show_bug.cgi?id=1226533

Do we need mozilla/marketplace-env@73e58cc

With a base image running Centos 7 you probably want to check what's the the main repos. It would also be worth checking with jason to see what we're running in prod.
I'm hopeful a lot of that will be not needed.

Seems a little odd to me to make this a PR. Questions might be better placed in the issues as an alternative.
I see the "not-ready" but the title was confusing. I was thinking "we don't want to do that" :). But I see this is just for you and not something you'd intend to merge.

Yeah, I did this mostly just to have a reference for stuff that is code-related. Some of this stuff might go to the addons base image too but I found it nicer to discuss about that in a PR rather than an issue with no code references.

Oh and I totally messed up the title, auto-filled titles from git commits make me oversee that every time :disappointed:

@muffinresearch @magopian I'd love to have some feedback on this.
Actually now that I'm thinking about it - almost all of the stuff from this PR should go in the addons/olympia docker file right?

r?

I'm not very knowledgeable regarding docker, but what I see seems to make sense.

@muffinresearch r? I updated the pyrepo references so that we're now prefering the same packages we use on prod (e.g fixes mysql-python linking issue) and we're now verifying the gpg keys of all source repos.

I think there's some open questions on what ops are using for sources (e.g. where does their pip and mysql deps come from) but that can be dealt with later. I also wonder could we use a system package for mysql-python? Presumably that would save on the mysql deps in the first place?
For node I see they are mirroring nodesource so the solution here should be equivalent for all intents and purposes. Which is great. :tada:
I think it would be nicer to use EPEL for python-pip vs curling a python script. I added instructions for that in the comments above.
Fix that and assuming olympia runs fine on this - I think this is fine to land and qualifying the sources can be a follow-up.
Don't forget to remove the local build line. :+1:
r+wc


[Improvement] The method of getting the first value of an element uses get(0) and needs to be optimized.

Search before asking

[X] I had searched in the issues and found no similar optimization requirement.

Description
The method to obtain the first value of an element uses get(0). There may be situations where the array goes out of bounds when the data is empty. It needs to be optimized to increase its robustness.
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

#3279


discourse.assets: work around cannot execute: required file not found

Description of changes
yarn run patch-package as postinstall-hook doesn't work because it has a shebang using /usr/bin/env which isn't available in the sandbox. Removing the postinstall hook and manually running this after patchShebangs appears to solve the issue.
Relevant error log of the build error
(NIXPKGS_ALLOW_INSECURE=1 nix-build -A discourse.assets)
error /build/source/app/assets/javascripts/node_modules/discourse: Command failed.
Exit code: 127
Command: patch-package
Arguments:
Directory: /build/source/app/assets/javascripts/node_modules/discourse
Output:
/bin/sh: line 1: /build/source/app/assets/javascripts/node_modules/.bin/patch-package: cannot execute: required file not found
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I am unable to reproduce this build error locally.
And the build didn't fail on hydra/ofborg either.
I am a bit confused why this change was necessary.
Did this only happen in certain environments I am unaware of?
Would be very grateful if you could shed some light on this, so that I can avoid similar issues in the future :)
Thanks!

Yeah, this one was super-weird. I have mostly observed it on my build-hosts (and builders from my employer) even though the h.n.o. build seemed fine mostly. And I'd like to stress that this wasn't a one-time issue, it happened frequently and I could observe via breakpointHook that the required files were indeed unpatched. Until today I have no idea unfortunately what caused this and this was mostly a workaround (because that implementation worked fine on all hosts it's not a regression at least).
However now that I look back at this PR I realize that I haven't documented precisely enough what was wrong here, sorry for that!
Would you mind referencing my comment if you're touching discourse anyways otherwise I'll try to do it soonish.


DATE_BUCKET() Error Indicator with 4 Parameters

Azure Data Studio Version: 1.23.0 (system setup)

Steps to Reproduce:

Enter the following code when connected to an Azure SQL Edge instance:

DECLARE
    @date DATETIME2(0) = '2020-04-15 21:22:11',
    @origin DATETIME2(0) = '2020-01-01';
SELECT 1 AS BucketNumber, DATE_BUCKET(wk, 1, @date, @origin) AS BucketBeginDate;

An error appears indicating that this syntax is correct and that DATE_BUCKET() requires three arguments:

Origin is, however, a valid, optional argument for the function and executing the script succeeds:

This does not block any work as executing the code succeeds, but it does show an unnecessary issue in an otherwise-fine script.

This should be fixed in the next release of ADS - if you are able to verify this on the latest version of our insiders builds that would be great!
https://github.com/microsoft/azuredatastudio#try-out-the-latest-insiders-build-from-main


Init grpc dependency management

What this PR does / why we need it:
Adds dependency management for code-generators to run locally.
Also we now set all Versions in a central place - the Makefile.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Documentation:

Does this PR introduce a user-facing change?:

/retest

/retest

/retest

retest

/retest

/close
replaced by dev-image


Hosts Overcommit State

Plugin Version 1.4
Running ./vCheck.ps1 from command line
The variable '$VMMem' cannot be retrieved because it has not been set.
At C:\PowerShell\Scripts\vCheck-vSphere-master\Plugins\30 Host\07 Hosts Overcommit State.ps1:33 char:12
+       [INT]$VMMem += $_.MemoryMB
+            ~~~~~~
    + CategoryInfo          : InvalidOperation: (VMMem:String) [], RuntimeException
    + FullyQualifiedErrorId : VariableIsUndefined

This is most likely due to strict mode being enabled in your Powershell session.  Try running "Set-StrictMode -Off" before running vCheck.  It is normally off by default.

This was indeed the issue, thank you!


FirestoreMixin: query is missing in '_firestoreBind' method.

Currently queries for properties of 'collection' type are totally ignored.

Introduced by #297, fix: #303


Update Python Script Excel/MD to YAML : Ability to convert to event relationship template

create excel template for event relationship, i will share mine from the azure work.
update python script excel/md to yaml in DD to be compatible with new excel template.

Hey @ashwin-patil , I hope you are doing well. Can you provide more details or maybe an example for this issue?
Thank you 👍


NoClassDefFoundError

Ummm, not sure why but this error pops out
Exception in thread "Thread-0" java.lang.NoClassDefFoundError: com/github/steveice10/mc/auth/data/GameProfile
I've checked the jar file and I can confirm that there's no class like that. Do I need to download other sources?

I also has this error  java.lang.NoClassDefFoundError: io/netty/channel/SimpleChannelInboundHandler

Nvm fixed this


KAFKA-15086, KAFKA-9981: Intra-cluster communication for Mirror Maker 2

Relevant Jira tickets:

KAFKA-10586
KAFKA-9981

Implements the internal REST API changes described in KIP-710.
A lot of the diff here comes from shuffling existing parts of the code base into new parts, without significantly altering them. This is necessary in order to make the current REST API logic for Kafka Connect more extensible and reusable, which in turn allows us to add logic for the dedicated Mirror Maker 2 REST API with less effort.
Shuffled but not extensively rewritten portions include:

WorkerConfig properties being extracted into the new RestServerConfig class
Pulling out some REST forwarding logic previously internal to the ConnectorsResource class into the new HerderRequestHandler class
Pulling out all REST logic for internal endpoints from the ConnectorsResource class into the new InternalClusterResource class

These changes should not affect the docs generated by, e.g., the DistributedConfig class, but should allow other AbstractConfig classes to easily add properties related to the (public- or internal-facing) Connect REST API.
An integration test is also added that runs a multi-node, dedicated Mirror Maker 2 cluster with exactly-once support enabled in order to test out both code paths related to intra-cluster communication.

@gharris1727 @viktorsomogyi @mimaison would you mind taking a look at this when you have a moment?

Thanks Mickael, I've addressed your suggestions and rebased.

Thanks for the reviews, everyone!

Whoops--there was a typo in the title at the time of merge. It should refer to KAFKA-10586, not KAFKA-15086.


console.log leftover in processProps function

Version
6.0.0-beta.18
Browser and OS info
any
Steps to reproduce
open devtools, inspect console
What is expected?
devtools extension doesn't pollute the console
What is actually happening?
devtools extension pollutes the console

This one https://github.com/vuejs/devtools/blob/6ab078a1c863016f4fea990fdfa565c5318084bc/packages/app-backend-vue3/src/components/data.ts#L47 was introduced while fixing https://github.com/vuejs/devtools/issues/1559

i hope update will be ready until monday


Bump lapin and bb8 versions

This patch introduces compatibility with bb8 0.7.1 and lapin 2.0.
bb8
For bb8, I removed the patch version from the cargo dependency requirement, as I'm assuming any future 0.7 versions will be compatible, and there will be less crate administration if the next required bump is with the future potential 0.8 release.
lapin
lapin::ConnectionProperties no longer implements std::fmt::Debug in the 2.0 branch, so I had to change the lib's missing_debug_implementations policy. Implementing Debug by hand seemed to me to be a little out of scope for bb8-lapin.
In the connection test that uses tokio, I set the current Tokio runtime as the executor, as amqp-tokio is now deprecated and unused for lapin 2.x. I'm reasonably sure this is how lapin 2.0 expects its executor/reactor to be specified based on the documentation and source, but as the release was only five days ago and there is no official example, it's possible I got it wrong so I'd appreciate any feedback. I'm thinking about getting lapin's maintainer to comment on an example Tokio usage to confirm this.
Other changes
I took the time to set 2021 as the Rust edition in Cargo.toml

Confirmed Tokio executor & reactor usage - an example was recently added to Lapin in amqp-rs/lapin#362.
@adrianbenavides Tagging you in case you missed the PR. When you have the time, I would appreciate a glance. Thanks!

Confirmed Tokio executor & reactor usage - an example was recently added to Lapin in amqp-rs/lapin#362.
@adrianbenavides Tagging you in case you missed the PR. When you have the time, I would appreciate a glance. Thanks!

Sorry @vipera, I totally missed the PR, I need to revise my notification settings 😓 .
I'll take a look at this today, thanks!

LGTM!

Looks like we have to make some little adjustments:

cargo fmt is failing: make sure to run it and also that cargo clippy is passing
you could also delete the beta and 1.45 rust versions from CI here: https://github.com/adrianbenavides/bb8-lapin/blob/master/.github/workflows/test.yaml#L14

After this the PR should be ready to merge.

Ah, let me just fix for rustfmt, good catch there, rustfmt! :)
Not sure whether you want to downgrade the edition to get the other test to pass for rust < 1.56

Alright, removed the beta and 1.45 tests based on your input.

@adrianbenavides Would you consider publishing 0.3.0 to crates.io? My Cargo.toml would look nicer :)


ZE FAQ - release note

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[ ] If the changes in this PR is part of the next future release, make this pull request against the docs-staging branch which will be published at the next release boundary. If the changes in this PR are part of the current release, use the default base branch, master. For more information about branches, see https://github.com/zowe/docs-site/tree/master#understanding-the-doc-branches.

[ ] If this PR relates to GitHub issues in docs-site or other repositories, please list in Description, prefixed with close, fix or resolve keywords.

Description (including links to related git issues)
Update Zowe 1.14 Release Notes in the ZE section.
:heart:Thank you!

@IgorCATech I noticed that this PR only has one line change, that looks like this. Is that correct?

@BrandonJenkins14 Not really, What I wanted to have there is this following line:
"Check out the Zowe Explorer FAQ to learn more about the purpose and function of the VS Code extension."

@BrandonJenkins14 The conflicts are resolved and it should be ok now.


Explicitly call out the use of the Office template format

Hi,
I think it would be good to call out the fact that files uploaded to an organization asset library to use as templates need to be in the .dotx, .potx or .xltx format.
Thanks
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5bacce83-65f6-b862-e413-09122aee356d
Version Independent ID: 5c4e1169-1d5d-6e0d-d574-f3aaba0a5d92
Content: Create an organization assets library - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/organization-assets-library.md
Service: sharepoint-online
GitHub Login: @kaarins
Microsoft Alias: kaarins

Added a pull request for this. #2664


Move TCP State Table outside of the Controller and Providers.

Blocked by: #425
Proposal
We would like to introduce a new interface to abstract the reading and writing of the TCPStateTable in Maesh.
BTW WDYT of renaming TCPStateTable into TCPPortMapping ?
Background
To use Maesh code in a different environment, we would like to use our own storage backend for the TCP State Table.
Workarounds
Unfortunately no.

BTW WDYT of renaming TCPStateTable into PortMapping

Sure! I would prefer TCPPortMapping though, just because it is tied to TCP use.

Sure! I would prefer TCPPortMapping though, just because it is tied to TCP use.

Sold !

We should make sure to migrate old objects then as well :)


Certification and authority for a internal network erea.

I'm a new user of bazel, so I want to build some bazel project as demos to be farmiliar to bazel.
but I met bazel version conflicts between different projects, so I got our bazelisk.
it's looks so good to me.
But I worked in a internal network.
when I run bazelisk build //...
I got log as below:
Downloading https:// bla bla bla..........: x509: certificate signed by unknown authority.
Hops guys help me.
Thank you in advance.
BTW: @laurentlb ,Hi, laurent, friend, I'm Pearce, we met last year in reproducible builds summit marrakech, how's going.

Same problem, I can't fetch GCS objects used by bazelisk, have you solved that problem?

Closing due to age. Please re-open if the problem still persists.


[ARM] [Debug] Islandwood News test app is failing to launch

This is on the latest master build. Will try this manually and report back as well

We're doing a bunch of app launch perf work to improve this. And are using this app to validate the work. Closing this issue out.


fix: bump melt memory further

Coverage: 84.853% (-0.02%) from 84.877% when pulling 723b7c52fae091104f6f6e00181417db7b34e850 on fix-bump-melt-memory-further into e9fb8807a1c48854ce28e8b7942e0f3b4d4a7765 on main.


image_plot cannot handle rectangular inputs

##Environemnt
OS: Ubuntu 18.06
Tensorflow: 1.14
SHAP = 0.31.0
##To reproduce
shap.image_plot improperly overlays the shap_values onto the image when the images input to the CNN model are not square (X by X). Here is an example using 249x299 as the input to the model:

##Workaround
If the same images are fed into the same model architecture except for a 299x299 (square) input, the SHAP overlay is fine. See below:

Looks like the maintainers are overwhelmed with interest and issue reports. Maybe one day I'll try to help them try find the line of code that needs fixing, or even try a pull request.


[Security Risk] Enable of security validation mechanism.

At present, the security validation function is enabled through the Config of image-rs, but we must consider the risk in actual use: there may be malicious boot image providers, which disable the security validation function by providing wrong image-rs configuration.
Therefore, do we need to consider forcibly enabling security validation in the code of image-rs?

@jialez0 is this issue still relevant or can be closed?
If it's still relevant to what release do you think we should map it to (mid-November, end-December, mid-February etc...)?


eq and not-eq broken by new number types

While investigating issue #1287 I noticed that the expression in this line was unexpectedly evaluating to true even when I passed a single argument to the script:
if (not-eq (count $args) 1) {

You can reproduce with these simpler, standalone, examples:
> eq 1 (num 1)
▶ $false
> not-eq 1 (num 1)
▶ $true

Note that the explicit numeric comparison commands work as expected with the new number system:
> == 1 (num 1)
▶ $true
> != 1 (num 1)
▶ $false

Is it a bug, or is it a feature? Quoth the doc:

Determine whether all $values are structurally equivalent.

I'd say that the string 1 and the number (num 1) are not structurally equivalent, and that one should use == and friends to compare numbers.
Whether I am right or not, this needs to be documented better. Also the docs for eq should make reference to ==.

Part of the problem is "structurally equivalent" isn't defined and it's not clear that everyone will have the same intuitive definition. Of course, what really caused the breakage wasn't a change in behavior of eq and not-eq it's that count now outputs a num rather than a string. I guess the question is whether eq and not-eq should coerce a num to a string when comparing the value to a string. That solution, however, creates some ambiguities and may be worse than the current, slightly surprising, behavior. Consider eq 1 (num 1) (float64 1) where the comparison of the second and third arguments are clearly not structurally equivalent even though they are numerically equivalent.

Part of the problem is "structurally equivalent" isn't defined and it's not clear that everyone will have the same intuitive definition.

Agreed. Your example is a great illustration: It is not clear to me that eq 1 (num 1) should produce a different result than eq (float64 1) (num 1). And should the latter produce the same as eq 1.0 1? And if we admit that eq 1 (num 1) should return $true, what about eq 01 1?
Overall, it seems safest to me to keep the current, strict behaviour of eq and to document clearly that only == will yield the expected result when applied to numbers and number-like strings.
However, users might possibly wish to compare lists [1 2 3] and [1 (num 2) (float64 3)] with a $true result (and similarly for maps). One could achieve that by giving eq an option &numeric, for example.

This is the intended behavior; I've clarified that in the doc of eq. It's an unfortunate backward-incompatible change.


the module attributes is enclosed during compile time.

Host
Tell us about your Host OS (the machine you're building burrito apps on)
Host OS:  MacOS
Host CPU: aarch64
Please run zig version in your Burrito project directory and write the version here:
0.11.0
Please run elixir -v in your Burrito project directory and write the version here:
Erlang/OTP 26 [erts-14.2.1] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit] [dtrace]

Elixir 1.16.1 (compiled with Erlang/OTP 26)

Target
Host OS: Linux
Host CPU: both x86_64 and aarch64
Host LibC and Version: I generated a complete static file.

defmodule Rpc do
@hostname :inet.gethostname() |> elem(1) |> to_string

def validate(topic) do
   getHostname(topic) = @hostname
end

end

The @hostname will alwalys store the hostname of the machine which I compile the binary. It won't be the hostname that run the binary.

This isn't a bug or anything related to burrito. It's actually a feature of Elixir! 😃
Module attributes are resolved at compile time, not at runtime. So the expression given is evaluated at compile time.
Take a look at the official Elixir docs: https://hexdocs.pm/elixir/module-attributes.html
Specifically the section "As Constants" where it gives an example of how a function called in an attribute will be eval'd at compile time only.

Oooh I see. Without burrito I simple share the source code directly and compile it locally.
Thanks tons for the comment!


Can't communicate with agents connected to <IP_ADDRESS> in Empire 2.4

Empire Version
2.4 (have not tested on latest dev commit, will follow).
OS Information (Linux flavor, Python version)
Kali Rolling, Python 2.7
Expected behavior and description of the error, including any actions taken immediately prior to the error. The more detail the better.
Expected behavior: If a listener is created with Host set to <IP_ADDRESS>, then a stager started on the same machine should be able to connect back to <IP_ADDRESS>.
Actual behavior: Listener receives initial agent connection, but any commands (such as sysinfo) are not executed on agent. It connects back and registers in the database, but after that there either aren't any other connections, or it attempts to connect but does not do so successfully.
Screenshot of error, embedded text output, or Pastebin link to the error
https://gist.github.com/Strazzom/e95341da18aafe85ed7465325c8a5d00
Any additional information
Bit of context: there are certain kinds of "proxies" (not really proxies in the true sense) that forward connections from a remote server to a local port. Think ssh -R <rport>:<host>:<lport>. SSH tunnels are one example, however there are multiple technologies that do this.
Ngrok and Serveo do this, (ngrok have their own tool, serveo just uses plain SSH). The reason for using such tools is to avoid paying for a VPS, and just hosting the listener on your own computer with remote port forwarding. There are multiple reasons this is desirable, but the main ones are low cost (free) and lack of complex setup to achieve basically the same result as using a VPS.
Both of these tools forward connections to <IP_ADDRESS>. I configured them to forward connections to the port Empire is running the listener on.
The issue is, the agent will connect back initially, accessing the /admin/get.php, /news.php, and /login/process.php scripts on the web server, and displaying the Initial agent [...] now active text. I have looked at the built in logging utility in ngrok to confirm that the agent is accessing those PHP scipts. After this however, there are no further connections (as would be expected at whatever interval the DefaultDelay option is set to), and any commands issued to the agent hang indefinitely, presumably because there are no further connections from the agent.
Initially, I thought this was an issue with the remote port forwarding tools themselves, however when I configure a listener with set Host <IP_ADDRESS> and run a stager on the same host, the same issue occurs. Hence, there must be a bug in Empire, where it can't receive from stagers connecting from <IP_ADDRESS>.

Here is a log from --debug 2:
https://gist.github.com/Strazzom/69ff06b6d25431bc6988597384a5e923

I have confirmed that this is not a platform dependent issue, having performed the exact same procedure on the docker image. As with when empire is running in a VM, the initial agent connection occurs, and then it doesn't continue to check in when running on the same machine as the listener.
I confirmed this after fixing the issues in #994. I thought that this might be an issue with my Kali VM, however if the same issue occurs when empire is running in a docker container, the bug must in fact be in empire.

@Strazzom, I can't seem to reproduce this issue you're having. I've tried this on a debian host. There doesn't seem to be any errors in the debug output either. Can you try this on another host and see if it's reproducible? :man_shrugging:

The dev branch does not install correctly on Debian 10, so I can't test it there. I will have to report that as a separate issue.
You seem to be using Debian 8. I will test it on Debian 8/9 and report back.

So, update:
I dealt with dependency hell on the Debian 8/9 docker images, so I gave up on that approach. Unfortunately, I have not had the time to set up a VM to test this on.
To avoid dealing with dependencies, I pulled the docker image for 2.4 (the base image of which is Ubuntu) and git cloned the dev branch there. The same issue is reproduced exactly when I attempt to reproduce the issue.
In the near future I will get ahold of a Debian 8 VM, so that I can more or less exactly reproduce your setup, and confirm whether this issue persists there.

@Strazzom I'm not sure why the docker image is even in play. In my test, I was just using a home grown Debian image. No docker install.

@Strazzom did you ever figure what the root cause was for this issue?

@Strazzom if you're able to track down the root cause of this, please feel free to comment and I'll reopen this.


csvsql does not work from within a script that is run as a cron job

I have tried with the following:

Created a php script that execute csvsql
Created a python script that execute csvsql

Both these scripts run "forever - while True"
Within the while loop it tests for a certain criteria, and if met it will execute csvsql
Both these scripts works 100% when run from the command line, for example:
sudo php myscript.php
sudo python myscript.py
The problem is, the moment I create a service (cron) from these scripts, then csvsql fails (Does not create my postgresql table and does not give an error message)
Always I execute the scripts with sudo rights.
Example:
/usr/local/bin/csvsql --db<EMAIL_ADDRESS>--no-constraints --insert --table geocoding_854EF913-3C06-4E6D-A56F-A89425AACCFB_1 "/tmp/854EF913-3C06-4E6D-A56F-A89425AACCFB/1/Test.csv"

Hi. Have you looked an issue #342 ?

Seems to be duplicate.


Upgrade the Agent build to embed Python 3.8

What does this PR do?
Upgrade the Agent build to embed Python 3.8.
I had to upgrade:

pip to 19.2.3 due to this: https://github.com/pypa/wheel/pull/303
pip-tools to support the new pip version
in integrations-core, pywin32 to 227 see https://github.com/DataDog/integrations-core/pull/5036
in integrations-core, cryptography to 2.8 see https://github.com/DataDog/integrations-core/pull/5047

Motivation
Provide the Agent with the latest Python 3 available.

@truthbk Yep it's needed for the build with Python 3.8 to succeed, the reason is linked in the PR description


Update contribution process docs

Now specifies our real contribution approach - branch-off-main-repo, rather than suggesting people fork repo.

hamishwillee
1:34 PM Well [darn]. Then suggest you don't merge this. Close with reason "we can't support this safely"


Config reference should not become its placeholder character if the string is empty

Describe the bug
If a config reference is empty, it becomes its placeholder character. This should not happen, it should become an empty string if the value is empty.
Steps To Reproduce
Steps to reproduce the behavior:

Set up an output, for example (A:COM ACTIVE FREQ NAME:1,String)
Setup "test output" config and add the above output as a config reference, using '#' character
Set MF to Run
Tune a frequency on COM1 that is not any nearby ATC frequency, so the name is empty
See your referencing output

Expected behavior
It should probably get the empty string that COM ACTIVE FREQ NAME is set to.
Actual behavior
The value becomes our placholder character '#'
Details

MobiFlight Version: Git dea92f, wasm module 1.0.0
FlightSim: MSFS2020
AddOn: Anyu


[bugfix] Ignore invalid Slurm nodes in flexible task allocation

Separate the retrieval of Slurm node descriptions and
creation of SlurmNode instances when nodes
in flexible task allocation.

Make the necessary unittests changes to test for invalid
node descriptions.

Fixes #1031

Codecov Report

Merging #1054 into master will increase coverage by 0.05%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##           master    #1054      +/-   ##
==========================================
+ Coverage   91.97%   92.03%   +0.05%
==========================================
  Files          81       81
  Lines       10984    10986       +2
==========================================
+ Hits        10103    10111       +8
+ Misses        881      875       -6

Impacted Files
Coverage Δ

unittests/test_schedulers.py
96.84% <100%> (-0.01%)
:arrow_down:

reframe/core/schedulers/slurm.py
57% <75%> (+2.39%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 595f4a0...639af9a. Read the comment docs.


Cleanup usage of unwrap() in re_query

What
Part of https://github.com/rerun-io/rerun/issues/6330
Removes or explicitly allows unwrap() where it makes sense.
Affected crates: re_query
Note: most of the usages of unwrap in this crate were already checked so they are explicitly allowed.
Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!

PR Build Summary
Recent benchmark results
Wasm size tracking

To run all checks from main, comment on the PR with @rerun-bot full-check.

 I'm just sorry I'm not able to finish the unwrap ticket faster - life got in the way. 😄

no worries at all!


Report HTTP errors from girder to client UI

An issue was discovered when working with the vagrant VM when it was stood up with the DEVELOPMENT flag. Girder failed to load the required plugins due to an old symbolic link that was pointing a non-existent directory. The client was unable to access girder so it did not display previous projects or clusters but did not make the user aware of any obvious errors. When the developer tools was open the HTTP errors showed up in the console. This HTTP errors should be handled and reported by client without having to open the developer tools.

closed with #480


weird study save problem

sometimes when I create a study, two study directories are created, and both appear empty.

the study opens but the folders appear empty

opening both folders, I see "This folder is empty" ... I am not sure if this is an FDA problem or a Windows problem?

@rnugent3 Were you creating a study from scratch or importing from old fda?

The study folder should have these files and folders by default when creating a new study.

I am unable to reproduce this. I am not sure how it would be possible for fda to run without the *.sqlite file being in the folder.

I was importing from old fda.

I tried importing from old fda and did not see this behavior.

I'll attempt to reproduce this at a later time. For now, this is not critical.

Failed to reproduce. I am going to close this and we can open a new issue in the event that this happens again, hopefully with better steps from me to reproduce.


Downscaling mechanism incompatibility with coverage clipping

Context

The downscale tiles mechanism does not work with clip: true inside the coverage parameter of the source.
It was detected as a problem with downscaling #687 but downscaling only fails together with clipping.
Expected Behavior

Tiles should be generated in the missing layers from a higher zoom with clipping.
Actual Behavior

Blank tiles still appear in downscale zoom levels. Although, seeding works fine between min_scale and max_scale of the source.
Possible Fix

The solution found was to modify the file:
/usr/local/lib/python3.10/dist-packages/mapproxy/cache/tile.py In the "_load_tile_coords" function.

Condition ( if not created_tiles and self.rescale_tiles ) has been changed to ( if blank_created_tiles and self.rescale_tiles ).
Added the next code right before the previous condition:
blank_created_tiles = False
for tile in created_tiles:
if tile.source_image().mode == 'RGBA':
if all(tile.source_image().load()[x, y][3] == 0 for x in range(tile.source_image().width) for y in range(tile.source_image().height)) :
blank_created_tiles = True

Steps to Reproduce

Create a cache with zooms that are out of the scale limits of the source.
Add the parameter downscale_tiles with any value greater or equal to 1.
Add a coverage to the source with clip: true and a datasource for the coverage.
Check if there is any blank tile in downscaling zoom levels.

The following configuration shows that there is some incompatibility between the combined use of the datasource and clip: true parameters with downscaling.
If we simply remove the clip: true parameter the following configuration will work, otherwise everything will be blank except the zoom indicated between min_scale and max_scale, which in this case is zoom 12.
services:
  demo:
  tms:
    use_grid_names: true
    # origin for /tiles service
    origin: 'nw'
  kml:
      use_grid_names: true
  wmts:
  wms:
    md:
      title: MapProxy WMS Proxy
      abstract: This is a minimal MapProxy example.

layers:
  - name: osm
    title: Omniscale OSM WMS - osm.omniscale.net
    sources: [osm_cache]

caches:
  osm_cache:
    grids: [webmercator]
    sources: [osm_wms]
    downscale_tiles: 2

sources:
  osm_wms:
    coverage:
      clip: true
      datasource: EU.txt
      srs: EPSG:3857
    type: wms
    min_scale: 100000
    max_scale: 150000
    req:
      url: https://maps.omniscale.net/v2/demo/style.default/service?
      layers: osm

grids:
    webmercator:
        base: GLOBAL_WEBMERCATOR

globals:

Context

The aim was to ensure that there were no blank tiles in downscaling zooms in those layers that required it.
Your Environment

Version used: checked in MapProxy 1.14 and MapProxy 1.16
Environment name and version: Python 3.10
Server type and version:
Operating System and version: Ubuntu

Here you have the coverage used: EU.txt


add raycast

Coverage decreased (-0.2%) to 99.557% when pulling 586af714dff15b5eb683405d68007f5d349f542e on feat_raycast into d0477781ed5e0a60a03e1f3993e0dec23ff14f93 on master.


Ask an expert links are broken

The calendly "get in touch" link on this page and on https://keptn.sh/community/#ask-an-expert still points to @Jürgen Etzlstorfer's link.

Could not verify that there are still references to my profile or contact information.
Closing this. FYI @oleg-nenashev


Only allow the author that requested the help command to react

The suggested modification ensures that only the author who initiated the help command can interact with the button. This prevents anyone else from deleting or modifying the page of the embed.

Please remove the response message
the check can look like this:
    async def interaction_check(self, interaction: discord.Interaction) -> bool:
        return interaction.user.id == self.allowed_user

done


GenerateBitmapCode function needs review/refactoring

Description:

The GenerateBitmapCode has several comments in it about obsolete code which we should remove. In addition, there is some inconsistency between the number of closing parenthesis between the three art types. These need to generate the exact number of paired parenthesis -- we cannot require the caller to fix it up.

The obsolete code is gone and the number of closing parenthesis is now correct.


[FEATURE REQUEST] Tags in report

Webpack report may contain handler tags.
Here is an example.

The example on the screenshot used css-minimizer-webpack-plugin, copy-webpack-plugin and my own plugin for purged CSS.
What is motivation or use case for adding/changing the behavior?

On my example I can quickly verify that assets have been minimized, styles were purged. This is convenient and helps to avoid unnecessary testing.
Feature request
Describe the solution you'd like

Add tags to report if HTML entries are successfully processed by minimizer.
I haven't investigated how HTML minification is implemented in the plugin.
The standard implementation involves adding a label to 'AssetInfo' object and then using 'compilation.hooks.statsPrinter' hook.
async process(compiler, compilation, assets) {
  const content = makeSomething();
    compilation.updateAsset(
            file,
            new RawSource(content),
            { minimized: true },
          );
}
apply(compiler) {
    const { pluginName } = this;

    compiler.hooks.compilation.tap(pluginName, (compilation) => {
      compilation.hooks.processAssets.tapPromise(
        {
          name: pluginName,
          stage: compiler.webpack.Compilation.PROCESS_ASSETS_STAGE_OPTIMIZE_SIZE,
          additionalAssets: undefined,
        },
        (assets) => this.process(compiler, compilation, assets),
      );

      compilation.hooks.statsPrinter.tap(pluginName, (stats) => {
        stats.hooks.print
          .for('asset.info.minimized')
          .tap(
            pluginName,
            (minimized, { green, formatFlag }) => {
              if (!minimized) {
                return '';
              }

              if (!green || !formatFlag) {
                return 'minimized';
              }

              return (green)((formatFlag)('minimized'));
            },
          );
      });
    });
  }

Describe alternatives you've considered

Appreciation for the useful project

[ ] After the feature is implemented, do not forget to give a star ⭐

@vralle
Thanks for the feature request. It's very important to have correct asset info.
In my intern test, I can add minimized property in  the assetInfo on the HTML file.
In the compiler.hooks.done hook I will see the updated asset info in stats.compilation.assetsInfo, e.g.:
 ## DONE:  Map(3) {
      'index.html' => { javascriptModule: false, minimized: true, size: 198 }, <= HERE is added the 'minimized' property
      'style.47f4da55.css' => { size: 21 },
      'main.5317c1f6.js' => {
        immutable: true,
        contenthash: '5317c1f6',
        javascriptModule: false,
        minimized: true, // <= this is set by Webpack in production mode
        size: 23
      }
    }

But, I can't reproduce the stats.hooks.print.for('asset.info.minimized') hook. It just doesn't work by me.
Can you please create small repo with working stats.hooks.print.for('asset.info.minimized') hook.

@vralle
ah, the stats.hooks.print.for('asset.info.minimized') works only when webpack run in CLI.
My problem was using integration test, where Webpack run via API.

I will finish new version tomorrow.

@vralle
the feature is implemented. Can you please try the v4.8.0


Incomplete usage info

Having hard time understanding how to use this.
Can't generate love-letter-templated example due to crash (https://i.imgur.com/QpwYQjd.png)
Dungeon deck couldn't be generated properly either - icons folder isn't carried over, and even after I move it manually they fail to get loaded - HTML doesn't replace "{ icon }" references with correct image path.
Also, syntax you utilize isn't documented anywhere in the readme, a little bit confusing to work with.

Thanks for your feedback!

Having hard time understanding how to use this.

I totally get that. At some point I was working on a document to explain usage in more details, but never managed to complete it. I will just put up what I have, though incomplete.

Can't generate love-letter-templated example due to crash

I was made aware of the problem with the Love Letter example previously, but never got around to fixing it. It only affects Windows- unfortunate, because I don't have a copy/machine to test on.
On macOS, this works (assuming located in project root):
$ python3 -m cards make example/love-letter-templated -o ~/Desktop

Dungeon deck couldn't be generated properly either

There's definitely some problems with this example. I will see what I can do.
Though it doesn't work right now, this is all that should be needed to build it (assuming located in project root):
$ python3 -m cards make ~/Downloads/dungeon-deck-master/src -d ~/Downloads/dungeon-deck-master/src/definitions.csv -o ~/Desktop --disable-backs

Thank you for fast reply :)
Well, I guess I'll continue digging under WSL then. Do you plan to continue your work on the project?

To be completely honest, I don't think I will.
I haven't been active on this project for many years now, and coming back to it yesterday to see if I could easily fix your problem made it pretty clear that maintenance requires more effort than I am willing to commit. If anything, I would want to start over completely 😅
Consider alternatives.


Query to General Form Previsit

Initialize some values from db.
Refactor generalForm (Split modules)
Enable TextField based on choice
Make the data consists after going back to General Form
Clear TextField after selecting non-text-field-required choice

The 'ward' field has not yet shown information.

@prawproudd Becuase none of patient in DB has it.

LGTM! Ward field work now! gogo


Add Environment to PodOptions

Change Overview
This PR adds Environment of type []v1.Env to be passed to PodOptions.
Pull request type
Please check the type of change your PR introduces:

[ ] :construction: Work in Progress
[ ] :rainbow: Refactoring (no functional changes, no api changes)
[ ] :hamster: Trivial/Minor
[ ] :bug: Bugfix
[ ] :sunflower: Feature
[ ] :world_map: Documentation
[ ] :robot: Test

Issues

fixes #issue-number

Test Plan

[ ] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

does this effect the kanister functions, that support podOverride, somehow?

@ankitjain235 possible to add unit test for this?


[v5] Warning too many classes use cases

Since upgrading to 5.0.0-beta.5 I get the following warning:
Over 50 classes were generated for component box__StyledBox. This happens when some of the props you use for styling have many potential values and we need to make a new CSS class for each variant. Over time the stylesheet will grow and slow down your app.
For these particular CSS rules with high dynamicity, consider using the attrs() method together with a style object.
Example:
  const Component = styled.div.attrs(props => ({
    style: {
      background: props.background,
    },
  }))`width: 100%;`

  <Component />

The component referenced here StyledBox is my base component that I use to style everything in combination with styled-system. But unless I'm missing something this is not a big deal. Would it be possible to make this warning account for this use case or at least a way to disable it?
Environment
System:

OS: macOS 10.14.5
CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
Memory: 279.50 MB / 16.00 GB
Shell: 5.3 - /bin/zsh

Binaries:

Node: 12.4.0 - /usr/local/bin/node
Yarn: 1.15.2 - ~/Code/application/node_modules/.bin/yarn
npm: 6.9.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman

npmPackages:

styled-components: ^5.0.0-beta.5 => 5.0.0-beta.5

@probablyup even 50 is too low... (reference #2622)
Let's either remove that warning or make the threshold much higher. The reason we have that warning is to catch things like people animating using an interpolation, which 50 is not high enough to reliably catch.

Put back to the original value in https://github.com/styled-components/styled-components/releases/tag/v5.0.0-beta.6


Chrome46

What is the ETA for Electron to adopt Chrome 46? I'm particularly interested in the ServiceWorker enhancements related to issue #2115
Thanks

Currently there is no ETA, you can see https://github.com/atom/electron/issues/3312#issuecomment-153632338 for more.

Thank you


As the head tutor, I am able to perform operations on groups of contacts, (update, delete).

Implemented with deleteShown, exporting, copying


Converted replace_right_cell method in OPS to use ExplorerPresenter.

split code in replace_right_cell into multiple methods.
@dclarizio please review/test.

Please add specs for this refactoring.

@dclarizio please review/test, added spec test for replace_right_cell method.

@h-kataria Everything seems to be working fine, but I saw that the buttons on the schedule editor screen have a styling problem that is not there on master:

Verified changes.


Destructuring + async/await scoping issue in es2015

Input code
const x = async function() {
    console.log(
        await Promise.all([[1], [2], [3]].map(
            async ([a]) => Promise.resolve().then(() => a * 2))
        )
    );
}

Transpiled with swc to es2015, this yields [6, 6, 6], but I'd expect [2, 4, 6]. The [a] is handled in a way, that all calls of () => a * 2 only see the last value.
The generated code looks like this:
console.log(await Promise.all([
    [
        1
    ],
    [
        2
    ],
    [
        3
    ]
].map(_asyncToGenerator(regeneratorRuntime.mark(function _callee(param) {
    var _param, a;
    return regeneratorRuntime.wrap(function _callee$(_ctx) {
        while(1)switch(_ctx.prev = _ctx.next){
            case 0:
                _param = _slicedToArray(param, 1), a = _param[0];
                return _ctx.abrupt("return", Promise.resolve().then.call(Promise.resolve(), function() {
                    return a * 2;
                }));
            case 2:
            case "end":
                return _ctx.stop();
        }
    }, _callee);
})))));

Config
{
  "jsc": {
    "target": "es2015"
  }
}

Expected behavior
Expected output [2, 4, 6], just like if you paste that in chrome:

Version
The version of @swc/core: 1.2.22

As a sidenote. Do you even need to downlevel destructoring in "target": "es2015"? As far as I can tell this feature was introduced in es2015 - see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment

@sod I'm not sure about it. I did it because babel's 2015 preset does it.


Add Argus schema

This PR adds a schema for Argus CSV output. The switch -c , enables CSV output mode.
Consider this command:
argus -r trace.pcap -w - | ra -L0 -c , -n -s +dur

It would produce the following example output:
StartTime,Flgs,Proto,SrcAddr,Sport,Dir,DstAddr,Dport,TotPkts,TotBytes,State,Dur
09:00:03.914398, e        ,udp,<IP_ADDRESS>,626,   ->,<IP_ADDRESS>,626,1,75,INT,0.000000
09:00:20.093410, e        ,lldp,00:22:2d:81:db:10,0,   ->,01:80:c2:00:00:0e,0,1,118,INT,0.000000
09:00:21.486288, e        ,arp,<IP_ADDRESS>,,  who,<IP_ADDRESS>,,2,106,CON,0.000025
09:00:21.486539, e        ,udp,<IP_ADDRESS>,68,  <->,<IP_ADDRESS>,67,2,689,CON,0.163820
09:00:33.914396, e        ,udp,<IP_ADDRESS>,626,   ->,<IP_ADDRESS>,626,1,75,REQ,0.000000
09:00:50.208499, e        ,lldp,00:22:2d:81:db:10,0,   ->,01:80:c2:00:00:0e,0,1,118,REQ,0.000000
09:01:03.914408, e        ,udp,<IP_ADDRESS>,626,   ->,<IP_ADDRESS>,626,1,75,REQ,0.000000
09:01:20.323835, e        ,lldp,00:22:2d:81:db:10,0,   ->,01:80:c2:00:00:0e,0,1,118,REQ,0.000000
09:01:33.914414, e        ,udp,<IP_ADDRESS>,626,   ->,<IP_ADDRESS>,626,1,75,REQ,0.000000
09:01:50.439162, e        ,lldp,00:22:2d:81:db:10,0,   ->,01:80:c2:00:00:0e,0,1,118,REQ,0.000000
09:02:03.914411, e        ,udp,<IP_ADDRESS>,626,   ->,<IP_ADDRESS>,626,1,75,REQ,0.000000

I'm having trouble with getting the integration test to work. If I invoke it manually, it works. But not via the script. Is this the same for you?
This produces output just fine:
gunzip -c input | vast import -N csv -t argus.record
vast export -N ascii 'State != "CON" && Dur > 4900ms'

The same commands in the integration script don't.


match multiple conditions in offset range

Hi, I am learning Yara and have a question about how to create a rule that matches multiple conditions in an offset range
For example, I check two strings str1 and str2. Both str1 and str2 can appear multiple times in the file. My hit condition is that I see both strings and there exists a matching pair of str1&str2 whose offset is less than 100 bytes. The order doesn't matter. Does Yara support this? if it supports, how the rule looks like? Thanks!

This does what you want:
import "math"

rule exaple {
  strings:
   $str1 = "aaaaa"
   $str2 = "bbbbb"

  condition:
   for any i in (1..#str1) : (
     for any j in (1..#str2) : (
       math.max(@str1[i],@str2[j]) - math.min(@str1[i],@str2[j]) < 100
     )
   )
}

The condition would be clearers with:
math.abs(@str1[i] - @str2[j]) < 100

instead of:
math.max(@str1[i],@str2[j]) - math.min(@str1[i],@str2[j]) < 100

But the "math" module doesn't have a "abs" function for getting the absolute value.


Deprecate ArborX::{min,max,minMax} and move them to KokkosExt

ArborX::min -> ArborX::Details::KokkosExt::min_element
ArborX::max -> ArborX::Details::KokkosExt::max_element
ArborX::minMax -> ArborX::Details::KokkosExt::minmax_element

The standard algorithms {min,max,minmax}_element return iterators and our version returns a value. What is the intent here? Further alignment with the standard parallel algorithms? Moving functionality from utils to KokkosExt?

The goals are:

Deprecate them in the ArborX:: namespace
Move functionality that really has little to do with ArborX to KokkosExt
Provide an approximation to the standard algorithms so that they could be replaced in Kokkos algorithms in the future (or easily tested with)

What about calling these {min,max,minmax}_reduce?

What about calling these {min,max,minmax}_reduce?

While I understand your logic, I would prefer the current naming (despite the divergence with the standard).


Shoosh semver informational part build warning

When we merged #2572 we introduced a build warning
warning: /home/tobin/build/github.com/tcharding/rust-bitcoin/02-15-improve-base58/bitcoin/Cargo.toml: version requirement `0.105.0+25.1` for dependency `bitcoinconsensus` includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion

At the time I was too lazy to see if we could shoosh it - I believe we should keep using the full version (incl. the informational +25.1). Seeing the warning everytime we build is annoying though.

I believe we should keep using the full version (incl. the informational +25.1).

I believe we should not. Those versions can get out of sync and there won't be a correct one. I'd rather make people look into cargo tree to see the real version they actually use.


Add type checking job to the CI workflow

Description
Following a Discord conversation, this PR adds a type checking job to the CI workflow to catch type errors in the codebase even tho we are not bundling the code yet.

The unit test failure is related to the Tailwind package which does not match the coverage thresholds expected. This used to pass before the configuration was invalid.