Lightning App Release 0.6.2

What does this PR do?

Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @tchaton @rohitgr7 @borda

waiting on #14814

can anyone @kaushikb11 @tchaton check why this test is failing?
___________________ test_lightning_work_run_method_required ____________________

    def test_lightning_work_run_method_required():
        """Test that a helpful exception is raised when the user did not implement the `LightningWork.run()` method."""

        with pytest.raises(TypeError, match=escape("The work `LightningWork` is missing the `run()` method")):
>           LightningWork()
E           Failed: DID NOT RAISE <class 'TypeError'>

seems that in into __init__ following method self._check_run_is_implemented() is not called correctly


error:20078044:BIO routines:bio_read_intern:internal error:../openssl-1.1.1b/crypto/bio/bio_lib.c:281

I'm setting custom BIO to use our own media channel, and this communication I'm making to secure using TLS 1.2 (OpenSSL TLS)
Client has sent hello packet and reached at server side successfully, but I get below error
error:20078044:BIO routines:bio_read_intern:internal error:../openssl-1.1.1b/crypto/bio/bio_lib.c:281
Client is waiting for Server Hello
I'm not sure why this error, kindly help!

Marking as inactive, to be closed at the end of 3.4 dev barring further input


Update branch protection policy to include required status checks

This implements https://github.com/ossf/allstar/issues/30 by introducing the following config settings to branch_protection.yaml:

requireUpToDateBranch: Controls whether required status checks should be strict, as defined in the GitHub documentation.

Note that (AFAIK) you can enable strict required status checks without any required checks, hence I set this as a separate flag.
I defaulted this to false for backward compatibility reasons.

requireStatusChecks: List of status checks that should be required for merging.

When operating in fix mode, the following logic is implemented:

If repo has no required status checks, and requireUpToDateBranch = true, enable strict required status checks.
If repo has no required status checks, and requireStatusChecks is non-empty, set required status checks to the desired list.
If repo has required status checks and strict mode is false but requireUpToDateBranch = true, enable strict mode.
If repo has required status checks and requireStatusChecks is non-empty, merge in status check to the existing list, deduping at the end.

Awesome, let's try out in staging.

@yorinasub17 Staging is deployed: https://github.com/apps/allstar-staging
Any chance you can do a quick sanity check with that app instance? Thanks.
If good, I'll push to prod.

Just installed it on our test org (I can't install it into our main org for internal policy reasons) and looks like it ran successfully!
For the config:
optConfig:
  optOutStrategy: true
  disableRepoOverride: true
action: fix

enforceDefault: true

requireApproval: true
approvalCount: 1
dismissStale: true

blockForce: true

requireUpToDateBranch: false
requireStatusChecks:
  - context: lint
    appID: 15368

Result:

Great kicking off prod deployment now.


Refine configure output

This patch outputs $LDFLAGS with $LIBS to detect if goaccess is properly linked.

Merged, thanks!


IGNITE-3808 Reproducer for missing EntryProcessr invocation

This test reproduces IGNITE-3808. It is intermittent; every 3 or 4 invocations the test will fail with a message like this:
junit.framework.AssertionFailedError: Unexpected clear bit: 180424

Sorry, test is ok. But I can't to reproduce test failure on x86. Do you use different arch to run test?

IGNITE-3808
Resolved


Ensure a new timestamp is obtained in FI filter

In https://github.com/grpc/grpc/pull/25738, I tried to make the tests happy by ensuring the channel is ready before scheduling any calls. However, the flake still exists. I think the best options now is getting a new timestamp in fault injection filter, so we have minimum impact to performance and other components.
1000x of opt: https://source.cloud.google.com/results/invocations/b94a28de-2c10-4662-95da-7fb61849a783
https://source.cloud.google.com/results/invocations/7bd45434-a2eb-46d7-9f23-b2d64b8e9de8
bug: b/185138304

CC @drfloob
PTAL @markdroth

Do we know what's actually causing the problem now that we're starting each RPC with its own ExecCtx instance?  In what case is an RPC using a stale time?
This fix seems fine, but I'd like to understand why it's needed and add a comment explaining it.
Also, if we do this, we probably no longer need to proactively connect the channel in the test.

So far, I'm unable to reproduce this locally or on RBE. I will dig more when I found a reliable reproduction.

@markdroth Recently, there is another failed run of delay-related test case (thanks to @donnadionne):
https://source.cloud.google.com/results/invocations/7ad79e84-8b3d-4beb-b975-bae896c5b260/targets/%2F%2Ftest%2Fcpp%2Fend2end:xds_end2end_test@poller%3Depollex/tests
The percentage of timed out requests is slightly over the expected range. This could mean a certain error is accumulating. As previous experiments, we know this PR's fix works (but it's not the most ideal way).
Similar to Alex's fix https://github.com/grpc/grpc/pull/26086 on DNS, this PR patches the problem in the FI filter.
On the other hand, I'm raising the number of RPCs (statistic confidence to 99.995% from 99.99%) in https://github.com/grpc/grpc/pull/26408.
Hopefully, this flake will disappear.

@markdroth There is another failed case due to inaccurate time (1ms short): https://source.cloud.google.com/results/invocations/15cbca4b-ba6c-4ecf-a377-89f3afbe4148/log
test/cpp/end2end/xds_end2end_test.cc:11642: Failure
Expected: (rpc.elapsed_time) >= (kFixedDelaySeconds * 1000), actual: 999 vs 1000
[  FAILED  ] XdsTest/FaultInjectionTest.XdsFaultInjectionAlwaysDelayPercentageAbort/XdsResolverV3Rds, where GetParam() = 16-byte object <00-00 01-00 00-00 00-00 00-00 00-00 00-00 00-00> (1155 ms)

Can we move this PR forward? Or what other info should I collect?


Add alert for outdated ScriptVersion values

to catch problems like #379 and #658 in a timely manner, we need an alert for machines or entire queues that are online, heart-beating, but not getting the latest helix-scripts/ version after a deployment. alert would need HeartbeatExport data, the latest ScriptVersion (updated during every rollout), and some way to ignore inconsistencies while deployments occur or Running machines wait to process a new configuration

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[x] Internal Infrastructure Improvements

Release Note Description
Added an alert to help detect incomplete configuration updates during our rollouts.

see conversation related to this issue in #769. upshot is we have the telemetry and Grafana already displays the information on https://dotnet-eng-grafana.westus2.cloudapp.azure.com/d/queueOverview/on-premises-helix-queue-status?orgId=1
this issue would just go one step further and add an alert based on the same data. important thing is to not alert when we're in the middle of deploying :grin:

placing in helix machines epic for now. we may decide to move it back to Ops - Service Maintenance as the epic moves ahead


[Github Lib] Fetch Commit SHA From Timestamp

Need to wrap a few things in the Github Lib to close out the issue.
// Git Lib

[ ] Create high level FetchCommitSHAFromTImestamp func (Needs to incorporate the rest of the algorithm for edge cases surrounding).
[ ] Create FFJSON models for Repo Data Request Response (currently a map of interfaces, can be optimized)

// Importing Github Keys

[ ] Create script that will import github keys into cassandra
[ ] Auto execute bash scripts on docker build
[ ] Encrypt Script

@skeswa Look ok? Going to try to wrap up a few of these tomorrow. Lemme know if there is anything you want me to take a look at.
PS: how is the GitLib stuff working out?


Free membership is not working!!

Your Environment

Add-on name: Tivimate
Add-on version: [e.g. 2.0.0]
Operating system version/name: Android 9.0

Describe the bug
Free membership is not working anymore. Saying "you need VIP membership to stream this video". I am using one playlist with 230 channels.

Totally irrelevant. This repository only covers Kodi add-ons. Join discord for more on this

Totally irrelevant. This repository only covers Kodi add-ons. Join discord for more on this


Apex Scraper headless bug

Issue: Main scraper file will not finish while running the scraper in headless mode
Solution: Running the .pyw file with the subprocess.run( ) method doesn't allow them main file to finish while the scraper runs without a terminal. To fix this the main file now uses subprocess.Popen( ) to run the scraper in headless mode. I'll be updating the repo later today.
Closing Issue
Fri, 1/6/2023, 4:22 pm


feat: Adds progress image to the local source create

Pull request

What this PR does / why we need it
PR adds progress bar with image size to the --local-path workflow for workload create and apply commands.
Which issue(s) this PR fixes

Fixes #225
Describe testing done for PR

Installed in local and validated against the local cluster
Additional information or special notes for your reviewer


Platform package

Used for future linux support move all windows related things into its own package, and delete code that doesn't full fill the purpose of this pr.

I've checked to see if it runs(it does) though do to my current situation I'm unable to test it pass that.

Looks nice, can you resolve conflicts?

sure


backend errors w/methods w/default arguments

With the latest 1.2.3 build from master, calling inherited methods w/defaulted parameters using named arguments results in backend errors. This prevents the Dart compiler from building.
With an interface:
interface I {
    shared Boolean id(Boolean a, Boolean b = false) => b;
}

class C() satisfies I {
    void foo() {
        id { true; }; // error
    }
}

// Ceylon backend error: cannot find symbol
// symbol:   variable $this

and a superclass:
class A() {
    shared Boolean id(Boolean a, Boolean b = false) => b;
}

class C() extends A() {
    void foo() {
        id { true; }; // error
    }
}

// Ceylon backend error: not an enclosing class: simplebug.A

This will probably be interesting to @tombentley.

With the latest 1.2.3 build from master

Since when?

Between a9737ee and 8b9894d.

Damn, that's quite a span. But still, it should help, thanks.

Well, ok @FroMage, here you go.
With a "simple" Ceylon project comprised of the problem code and buildcheck.sh:
#!/bin/bash

# Build
cd ~/Repos/ceylon/ceylon
git clean -fxd
ant dist

if [ "$?" -eq "1" ]; then
    echo "Build failed, skipping with exit code 125."
    exit 125
fi

# Test
cd /tmp/simple
~/Repos/ceylon/ceylon/dist/dist/bin/ceylon compile
status=$?

# Log and return the exit code
if [ "$status" -eq "0" ]; then
    echo "Marking good; exit code 0."
    exit 0
else
    echo "Marking bad; exit code $status."
    exit 1
fi

git bisect commands and results are:
#!/bin/bash

pushd ~/Repos/ceylon/ceylon

# For the class version
#git bisect reset
#git bisect start
#git bisect bad 8b9894d
#git bisect good a9737ee
#git bisect run ~/Repos/ceylon/bisect/buildcheck.sh

# 8b9380aba50608d16c672664e25322375d273fa5 is the first bad commit
# commit 8b9380aba50608d16c672664e25322375d273fa5
# Author: Tom Bentley<EMAIL_ADDRESS># Date:   Mon May 23 14:36:42 2016 +0100
#
#     Fix #6283 but always using a qualified this for $argthis$
#
# :040000 040000 786fbea7e532f9bc5d1c17c5ebb7f0a47ff71f76<PHONE_NUMBER>5adeff8adec8b98a8aa756ebc7ff60 M      compiler-java
# bisect run success

# For the interface version
git bisect reset
git bisect start
git bisect bad a9737ee
git bisect good 9db6222
git bisect run ~/Repos/ceylon/bisect/buildcheck.sh

# There are only 'skip'ped commits left to test.
# The first bad commit could be any of:
# 73becb99ab5885a5ff920f76401803028fd7835f
# 794c965c8257abb3d06b54fc9472f37ad74925ed
# We cannot bisect more!
# bisect run cannot continue any more

TLDR: these are actually two separate bugs.

The class problem started with 8b9380aba50
The interface problem started with 73becb99a or 794c965c8

Note: not sure why 73becb9 was "skipped"; perhaps Eclipse interfered with the cli compile.

Fixed!

Thanks, works great!


Change Requester type and add ManagerEvents Interface

Hello Tomato6966 in this Pull Request I changed the typing of the Music Requester in the Search method of the Player with the purpose of being defined the id of the user instead of the object of the user as a whole so I see a performance gain in the sense of less memory being used
and I added an interface to the manager events, so the user who has an EventHandler to start the Event in a separate file can get the name of the events more easily using the interface
here's how I created my Bot's EventHandler that uses the BaseEvent to validate the Event which in turn uses the event interfaces to validate the names of the Events
In the end this PR stuck in improving the quality of life of the developer who uses your fork of Erela.js
Some code changes was my IDE using ESLint to "fix" the code

Sorry but i wont support this, as this client is not maintained anymore by me, check out the readme


char* comparison uses the contents, not the pointer

char* a = strdup("Hello");
char* b = strdup("Hello");
CHECK(a == b); // passes, even though it shouldn't

Looking at the code, it seems like 'eq' is transforming the value to a string, and then doing the comparison, which doesn't do the right thing in this particular case. Casting the pointers to void* seems to solve it.

You're reporting this at the right time - just a day or 2 before the release of 1.1 - which is supposed to be stable - so thanks.
More people would like the pointers to be compared instead of the C strings - and this is what I'll do - by default the pointers will be compared, and only if the user defines something like DOCTEST_CONFIG_COMPARE_C_STRINGS will they be treated differently.
I initially made it the way it is because boost.test does the same (I think). But I will change it for 1.1 - another little breaking change...


fix disableRetry if extra is const

if the user makes extra is const
unsupported operation cannot modify unmodifiable map extra
await dio.get<dynamic>(
  'https://mock.codes/500',
  options: Options(extra: const {'key':'value'})..disableRetry = true,
);

@rodion-m
check this


[app-configuration] Handle ETags and ifMatch/ifNoneMatch conditionals

Update APIs to consistently handle etags via ifMatch/ifNoneMatch fields in the options parameter.

Many tests added to get all the edge cases and to document the various status codes and errors
Added an exception that might get moved into core (ResourceBodyNotFoundError). Hiding this away in my package for now since the name is still under discussion (but the concept is not).

A note for reviewers: the ResponseBodyNotFoundError is not necessarily the final name (and is not the final home). It's in discussion but the logic on when its thrown is right. After this PR pending whatever discussion happens I'll probably end up moving it into core-http.

Approved! I still have the above question about making ETag required in the response, but I don't think that should be a blocker for this.

I'll add an issue (#5366) to fix this - I also need to do a field modification for 'locked' so I can add that in at that time.


Add architecture diagram, update docs

Signed-off-by: Patrik Stas<EMAIL_ADDRESS>

Codecov Report

Merging #334 (d471230) into main (3ccd807) will decrease coverage by 4.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
- Coverage   47.75%   43.53%   -4.22%
==========================================
  Files         116      113       -3
  Lines        9249     8808     -441
  Branches     2204     2134      -70
==========================================
- Hits         4417     3835     -582
- Misses       3314     3577     +263
+ Partials     1518     1396     -122

Flag
Coverage Δ

integration
?

unittests
43.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

aries_vcx/src/messages/connection/did_doc.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

aries_vcx/src/messages/basic_message/message.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

aries_vcx/src/handlers/connection/cloud_agent.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

aries_vcx/src/handlers/connection/pairwise_info.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/handlers/connection/inviter/states/complete.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

aries_vcx/src/messages/connection/invite.rs
0.00% <0.00%> (-71.43%)
:arrow_down:

aries_vcx/src/handlers/connection/connection.rs
10.00% <0.00%> (-60.00%)
:arrow_down:

...x/src/handlers/connection/inviter/state_machine.rs
0.00% <0.00%> (-50.00%)
:arrow_down:

libvcx/src/api_lib/api_handle/mod.rs
41.02% <0.00%> (-31.02%)
:arrow_down:

libvcx/src/api_lib/api_handle/devsetup_agent.rs
0.00% <0.00%> (-28.76%)
:arrow_down:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ccd807...d471230. Read the comment docs.


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/channel-wg-leads
/assign knative-sandbox/channel-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/pkg 5708c4c...d016976:
  > d016976 Update community files (# 2353)
  > b35fcdd kmap changes (# 2355)
  > a99300d kmap (# 2354)
bumping knative.dev/eventing a5081ac...4e372e5:
  > 4e372e5 Update personas.md (# 5917)
bumping knative.dev/eventing-kafka 9b0fdd6...957ed8b:
  > 957ed8b upgrade to latest dependencies (# 996)

/test pull-knative-sandbox-eventing-kafka-broker-integration-tests


Interested in presenting a SharePoint Development Topic

I'm interested in presenting a custom Question and Answer solution we created that works within a SharePoint site (like a Communication site). It enables all members and visitors to ask, answer, moderate, follow and be notified and more.  I think it presents another alternative to a Yammer embed which some customers still hesitate on.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 19f0bf18-5ece-8fac-f602-17500085ad26
Version Independent ID: 087cf5a1-6c1e-1f19-b3c1-d1e661092fb3
Content: SharePoint Developer Community (SharePoint PnP) resources
Content Source: docs/community/community.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

I neglected to mention that it is a solution we create for a customer so I can show bits of code but it hasn't been added to sp-dev-fx-webparts yet.  However, I'm going to work with the custom to pursue open sourcing it in a few weeks so there is a chance.  :)

Agreed in email - Looking forward - thx for volunteering @bogeorge.


fix: Remove UUID from ChatMessage.

This solves the ""Additional properties are not allowed ('id' was unexpected) - 'messages.O'" bug.

https://github.com/adamrushy/OpenAISwift/pull/107 is a better fix for this issue.


[Request] Working Anti-Aim with Desync

check out the pull request on legit aa

#1257

use the search function on github next time, close this. #1257 and #1546


complete path is always used for move and copy commands

I want to move a directory and all it files to a different directory. In the Web-UI it works like I want it, I have the option Move to a Custom Path there. I don't have such an option in the CLI client and if I want to move repo-name/a/b to be in repo-name/c/b it will end up in repo-name/c/a/b

@peshay,
This is definitely supported. See https://github.com/JFrogDev/jfrog-cli-go/issues/168 as a reference.

ah okay thanks! so you have to work with placeholder and --flat !


Update all certs for sample apps

Update all certs for sample apps.

@rajsesh-msft is added to the review. #Closed

When you merge this, can you please make sure to change the commit message to note that these things got squashed together? Thanks!

Did this help the CI build? It still appears broken.

No. How do I recall/cancel this pull request?

In reply to: 254254289 [](ancestors = 254254289)

I'll have a correct fix without the other changes in a 30 min's or so.

In reply to: 254265628 [](ancestors = 254265628,254254289)

I'll clean this up and send a new CR.
Please ignore this PR.


Problem with the preservation of multi-line basic strings

Hi @maliknajjar Thanks for the update. There seems to be a new problem with the preservation of multi-line basic strings (acc. to https://toml.io/en/v1.0.0#string):
When I add such a string like in this example:

then it is already now displayed in the widget omitting the new lines.
And when I then edit the date (or any other object) using the widgets on the right, then the string is converted to a basic string:

While the content is probably still the same, this seems not to be the behavior that the user wants. Would you agree?
Originally posted by @MoritzRitter in https://github.com/maliknajjar/guifier/issues/5#issuecomment-2385257660

Hi @MoritzRitter, thank you for bringing this up.
The issue you're describing is related to the smol-toml TOML parser that the library uses. The parser should check if a string in the JavaScript object contains newline characters (\n). If it does, the string should be formatted as a multi-line TOML string when converting it back to TOML format.
This behavior should preserve the new lines as expected, instead of converting the string into a basic single-line format.

I opened an issue in the smol-toml library here

@2colours, thanks for your response.

It's a completely different beast to represent semantically equivalent values differently based on some syntax metadata.

got it, so it's not capable of doing that.

How does your GUI itself distinguish between single-line and multi-line strings? The problem seems to be that it not only fails to distinguish them, but also drops the \n that's actually coming from the library.

the GUI doesnt distinguish anything. it just parses and stringifies using the smol-toml library. and it wouldn't really matter. Even if the text editor interpreted the \n correctly, it would result in:
multi_line_string = "Line1
Line2
Line3"

which is invalid TOML syntax.
Essentially, it seems there's no way to get the smol-toml library to produce a multi-line string.

@maliknajjar I mean it makes exactly the difference of right and wrong whether the GUI produces separate lines as one long line or not.

since the smol-toml library doesnt plan on supporting specifying text style in the near future. I will close this for now

since the smol-toml library doesnt plan on supporting specifying text style in the near future. I will close this for now


Remove test dependency

The following test should remove usage of log4j entirely.
https://github.com/OpenLiberty/ci.maven/blob/39e1d729e1d0e65aa7e26e2da108b19e259b6cc0/liberty-maven-plugin/src/it/ear-project-it/pom.xml#L42

Done in PR #1338


Yippee for functioning SimpleClans support!

Nice! You're getting good at this. Seeing how you've pretty much committed more in the past week or so than I have in a months, and assuming @mcmonkey4eva approves (if he even cares), a few more of these things and I'll probably end up giving you direct access to the repo if you want it


add sign

第六期论文复现赛，增加 SIGN 模型，论文Detecting Beneficial Feature Interactions for Recommender Systems，队伍名称BamTeam，AI Studio项目地址
具体添加信息如下：

模型组网
datasets全量数据集
TIPC
中英文主页
read the docs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Source folders need to be configurable from the project folder

Clearly, globbing the src folder doesn't work, and this should be something we can setup outside of the extension.


hardware: add nvme kernel module for vm-intel

Without this vm/bootstrap step will fail if we run the installation on nvme block device.

Thanks, I don't use Intel machines anymore so I was unable to test, but this makes sense to me.


Need TOML parameters for IWA configs

The following configurations required when configuring IWA single sign on [1] steps 7, 8, 9, are missing their equivalent .toml parameters.

/conf/security/authenticators.xml file:

<Authenticator name="IWAUIAuthenticator" disabled="false">
       <Priority>5</Priority>
   </Authenticator>

should have the following toml parameters:
[admin_console.authenticator.iwa_ui_authenticator]
enable = true
priority = 5

conf/tomcat/web.xml

<security-constraint>
  <display-name>Security Constraint for IWA</display-name>
  <web-resource-collection>
    <web-resource-name>Protected Area</web-resource-name>
    <url-pattern>/</url-pattern>
    <http-method>DELETE</http-method>
    <http-method>GET</http-method>
    <http-method>POST</http-method>
    <http-method>PUT</http-method>
  </web-resource-collection>
  <auth-constraint>
    <role-name>Everyone</role-name>
  </auth-constraint>
</security-constraint>

conf/tomcat/META-INF/context.xml

<Valve className="waffle.apache.NegotiateAuthenticator" principalFormat="fqn" roleFormat="both"/>
<Realm className="waffle.apache.WindowsRealm"/>

[1] https://docs.wso2.com/display/IS570/Configuring+IWA+Single-Sign-On

Fixed By: https://github.com/wso2/carbon-kernel/pull/2134
Toml key will be:
[admin_console.authenticator.iwa_ui_authenticator]
enable = true
priority = 5

web.xml and context.xml related configs will get inferred. No need to mention them in the docs.


Reflect fedimint failures faster

It goes all the way through to 30s timeout even if there's a cancelled state that comes back a lot quicker.

I'm a bit stuck on this until I get some advice: https://github.com/fedimint/fedimint/discussions/4001
I think at least one possible scenario I can check is if restarting the subscription stream after a few seconds will return the final cancel status update that doesn't seem to be coming back from the original stream.

Blocked on https://github.com/fedimint/fedimint/issues/4014


appregistry: don't sync for 4.2 yet

We will need this whenever we actually start building 4.2 because we don't want to import 4.2 images over 4.1 images.
<jwforres>
the bundle we push always needs to contain the latest off all our z-streams
which means for any given operator like template-service-broker-operator, we need to pull the manifests out of the 4.1.z image the 4.2.z image, and glom them together

<sosiouxme>
to answer the question, i can make 4.2 sync a no-op until we have it sorted.

<jwforres>
yeah can you do the stopgap when you guys need to start running 4.2 builds
lets reconvene next week once 4.1.0 is out the door, and put our heads together

/lgtm


leak test failed in 'schema_storage_test.go'

What did you do?
Run unit test by:
go test -run ^TestSchemaStorage$ github.com/pingcap/tiflow/cdc/entry -v
What did you expect to see?
Test pass and goleak report no error
What did you see instead?
Test passed but goleak report an error:
goleak: Errors on successful test run: found unexpected goroutines:
[Goroutine 17484 in state select, with net/http.(*persistConn).writeLoop on top of the stack:
goroutine 17484 [select]:
net/http.(*persistConn).writeLoop(0xc008dfc7e0)
    /home/go1.19.6/src/net/http/transport.go:2392 +0xf5
created by net/http.(*Transport).dialConn
    /home/go1.19.6/src/net/http/transport.go:1752 +0x1791

 Goroutine 17483 in state IO wait, with internal/poll.runtime_pollWait on top of the stack:
goroutine 17483 [IO wait]:
internal/poll.runtime_pollWait(0x2af53b494ec0, 0x72)
    /home/go1.19.6/src/runtime/netpoll.go:305 +0x89
......
]
FAIL github.com/pingcap/tiflow/cdc/entry 4.195s

Versions of the cluster
Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):
none

Upstream TiKV version (execute tikv-server --version):
none

TiCDC version (execute cdc version):
v6.5.0

/severity minor


How to pass logfire tags via loguru

Question
Hi, I've been using logfire with loguru, my configuration is as below
import os
import logfire
from loguru import logger

HANDLERS  = [
    {"sink": sys.stdout, "level": LOG_LEVEL, "format": LOG_FORMAT, "colorize": True},
]

if os.environ.get("LOGFIRE_TOKEN"):
    HANDLERS.append({**logfire.loguru_handler()})
    logfire.configure(console=False)

logger.configure(handlers=HANDLERS)

def get_logger(source):
    return logger.bind(source=source)

All this works, but I want to be able to pass logfire tags when I log using loguru like logging.info("", _tags=['my', 'logfire', 'tags'], is it possible to do that?

I was hoping logger.info('Hello, {name}!', name='World', **{'logfire.tags': ['foo', 'bar']}) would work, but we don't actually handle it properly.


Database selection doesn't work properly

Issue Type: Bug
After the databases are loaded, when i scrolling list and selecting a database brings it back to the top of the list
Azure Data Studio version: azuredatastudio 1.33.1 (0b9ef714c823d662815f441aec4a94eaa21940f8, 2021-11-04T17:43:30.222Z)
OS version: Darwin x64 20.6.0

I believe this is a dupe of #17808


Adding docker support

Adding docker image files for both prod and dev use
Adding instructions to top level README.md to:

Run a copy of the prod version hosted on hub.docker to try out the project
Build and run an image that will listen to changes on the host machine (to allow developers to use an IDE on their host machine)

Coverage remained the same at 88.034% when pulling 94c264a3c43a8c424317dd3acee6557d2d797400 on dockerizeallthethings:adding-docker-support into 97fc20662fac2e6584b0fb3801d74d3b185b6cdb on coryhouse:master.

@dockerizeallthethings, thanks for the PR! Could you open an issue and link it to this PR? In general, we like to have a discussion about what goes into the project and an issue is the perfect place to do that. Cheers.

Thanks for the PR! Dumb question: How would we update the Docker image hosted on hub.docker later?

If you have accounts on hub.docker I should be able to add them as
contributors.
Also, you're certainly welcome to host your own version on hub.docker, if
you'd prefer.
Lemme know if you have any other questions, and feel free to send me some
hub.docker usernames to add :).
--RG
On Sat, Dec 30, 2017 at 7:46 PM, Cory House<EMAIL_ADDRESS>wrote:

Thanks for the PR! Dumb question: How would we update the Docker image
hosted on hub.docker later?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/coryhouse/react-slingshot/pull/522#issuecomment-354583571,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ago6YtvXGK21FEUl5djdE8H4Cob7IZ1Aks5tFwOigaJpZM4RNHOH
.

Great! I'm housecor

Done!
I also created an issue linked to the PR, as per an request from a Nick
Taylor (to which I can't seem to directly respond).
Happy New Year!
--RG
On Mon, Jan 1, 2018 at 2:51 PM, Cory House<EMAIL_ADDRESS>wrote:

Great! I'm housecor
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/coryhouse/react-slingshot/pull/522#issuecomment-354682638,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ago6YmRCAcaVBWIwfuXZcHnT13lRe4Qqks5tGWFUgaJpZM4RNHOH
.

This is for implementing #529.

I haven't tried this locally yet, will try to take a peek at this tomorrow. Just curious why alpine instead of slim for Node? I haven't done a whole lot of Docker yet. New job's immersing me though 😉

I also don't know Docker well enough yet to vet this. I'm hoping to dive in soon for work but for now I'm no help on this.

Hi!
At first good work @dockerizeallthethings. I wanted to do this myself, but you were faster than me :).
Couple notes from my side:

HMR is not working on Docker for Windows, because of the way how volume binding works. To make it work, you must add poll: true to watchOptions inside webpackDevMiddleware config
This is just my thing, but I personally prefer to use docker-compose over docker cli. Even though in this case we really do not need to orchestrate multiple containers, I find it much more easy to work with. E.g.: If you have one service inside docker compose with all necessary configurations (volume/port binding, container name, tty, ...) you can than just type docker-compose up hmr instead of docker run -v "$(pwd)"/src:/code/src -p 3000:3000 -p 3001:3001 --name react-slingshot -d react-slingshot
During dev, I would probably rather use full node container instead of alpine. Sometimes I find it useful to connect inside the container and execute bunch of commands from console, but again this is just a personal thing...

I can contribute with docker-compose setup if you are interested.
Please, let me know.

@dockerizeallthethings, sorry that this PR and issue has gone stale. Any ideas for the first point that @mikedevita mentions?

I'm not a huge fan of this for a couple of reasons:

Only one Dockerfile should be provided and it should closely mimic a PROD environment.
The PROD dockerfile it should not build the project. This causes a lot of ENV headache. The dist folder should be built like normal, then copied over to the Docker image on creation.

If someone wants to develop using Docker, that should be put back on the developer, this PR is making A LOT of assumptions.
For example, I use react-slingshot in a multi-project build, but my react-slingshot project has dependencies on other projects that have to be built first. Therefore, the Dockerfile has to change accordingly.
In my opintion, this is a good start but not ready to merge. I'm going to FORK react-slingshot this weekend and try to implement some ENV configuration changes and I'll integrate Docker as well.

If anyone is curious about my Docker comment, check out the PR: https://github.com/coryhouse/react-slingshot/pull/590


Regions index

Following discussion in https://github.com/sgkit-dev/vcf-zarr-spec/issues/21

Tests are failing because we need https://github.com/tomwhite/bio2zarr/tree/variant-end (or similar).

Should we get the variant_length added to vcf2zarr first (and maybe even compute the index, optionally, there)?

Yes, we definitely want variant length/end in vcf2zarr first. (I see you've opened https://github.com/sgkit-dev/bio2zarr/issues/278 for that - thanks.)
I think we should compute the index in vcf2zarr - it's cheap to do so may not need to be optional. But we could wait a bit on that until we are sure everything's working with the index we've designed first.

Thanks @tomwhite, this is a big step forward!


[zh] Remove user specificed parameter from URL

The /u/2/ is use for specific which account to use.
For instance, if we open following URL and confirm it's different account.

https://groups.google.com/
https://groups.google.com/u/0/
https://groups.google.com/u/1/
https://groups.google.com/u/2/

For public URL, it should be the default one rather than specific "third account".
English PR:

#34094

/approve
/lgtm


Visualizer: Error when trying to solve from visualizer

Debian 9(stretch), installed asprilo via conda
visualizer 0.2.0
clingo 5.3.0
'async_' is wrong key argument to clingo.control.solve(on_model = self.on_model, async_ = True)
in solver.py (egg file)
the error shows:
solve: 0
Traceback (most recent call last):
File "/home/david/anaconda3/envs/asprilo/bin/viz-solver", line 10, in
sys.exit(main())
File "/home/david/anaconda3/envs/asprilo/lib/python3.6/site-packages/visualizer-0.2.2-py3.6.egg/visualizer/solver.py", line 366, in main
File "/home/david/anaconda3/envs/asprilo/lib/python3.6/site-packages/visualizer-0.2.2-py3.6.egg/visualizer/solver.py", line 250, in run
File "/home/david/anaconda3/envs/asprilo/lib/python3.6/site-packages/visualizer-0.2.2-py3.6.egg/visualizer/solver.py", line 138, in receive
File "/home/david/anaconda3/envs/asprilo/lib/python3.6/site-packages/visualizer-0.2.2-py3.6.egg/visualizer/solver.py", line 164, in on_raw_data
File "/home/david/anaconda3/envs/asprilo/lib/python3.6/site-packages/visualizer-0.2.2-py3.6.egg/visualizer/solver.py", line 201, in on_data
File "/home/david/anaconda3/envs/asprilo/lib/python3.6/site-packages/visualizer-0.2.2-py3.6.egg/visualizer/solver.py", line 277, in solve
TypeError: 'async_' is an invalid keyword argument for this function
close solver

This happens since the visualizer requires clingo's current development version 5.4.0 where keyword async of Clingo.solve was changed to async_ for compatibility with python>=3.7. For proper installation, call conda install asprilo-visualizer -c potassco -c potassco/label/dev to also pull in clingo 5.4.0. You can also find a detailed install guide here.

Thank you for answering and updating the installation instructions,
after remove and re-install clingo 5.4.0, now i get to point where i get message "found solution",
and the plan is not loaded into the visualizer.
should i open a new issue?
here a snippet from my terminal:
Connection with: ('<IP_ADDRESS>', 45230)
/home/david/asprilo/encodings/m/./action-M.ilp:19:43-54: info: atom does not occur in any rule head:
move(#X0,#P1,#X2)
/home/david/asprilo/encodings/m/./goal-M.ilp:7:22-38: info: atom does not occur in any rule head:
processed(#X0,#P1,#X2)
found solution

Can you please provide the instance data you are using?
Maybe @Thomas-Otto can comment on this too.
Alternatively, I'd recommend to not use a solver script at first but simply load or pipe your instance and computed answer set into the visualizer.

Thank you, I've already done piping as a workaround and it works,
But since we (students team) aim on extending Asprilo with more solvers we want it to be embedded in the visualizer.
BR,
David.
בברכה,
דוד אבקסיס

From: Philipp Obermeier<EMAIL_ADDRESS>Sent: Sunday, June 30, 2019 1:28:15 PM
To: potassco/asprilo
Cc: davidabek1; Author
Subject: Re: [potassco/asprilo] Visualizer: Error when trying to solve from visualizer (#31)
Can you please provide the instance data you are using?
Maybe @Thomas-Ottohttps://github.com/Thomas-Otto can comment on this too.
Alternatively, I'd recommend to not use a solver script at first but simply load or pipe your instance and computed answer set into the visualizer.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/potassco/asprilo/issues/31?email_source=notifications&email_token=AGLVYBKCPH6FFEYK7ALPJWDP5CDD7A5CNFSM4H4HJCDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4JNZQ#issuecomment-507025126, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGLVYBKZRVJQ57EQMV6A4VLP5CDD7ANCNFSM4H4HJCDA.

@Thomas-Otto and @pobermei , i've attached the information on instance data:
settings solver instantiate: viz-solver --port 5000 -m incremental -e ~/asprilo/encodings/m/encoding.ilp
(encodings have been downloaded from your git)
I've changed the file suffix from lp to txt so it uploads directly and not a zip file.
demo_mapf_solver_withProd_Orders_WithPickingStations.txt

ey. It took me some time to figure that out. The problem seems to be an incompatibility between the 'inc' mode and the solver. The solver works slightly different and the encodings are build for the 'inc' mode from clingo. But adding the following two lines to the goal-M.ilp file under the "#program check(t)" section should fix the problem:
#external query(t).
occurs(object(robot,R), action(move,D),     t) :- move(robot(R),D,t).
You can add these two lines to every other program part that iterates trough the time steps, too.

It works!!
thank you,
@Thomas-Otto as you directed I've changed goal-M.ilp, and it was enough to get it to work,
but you mentioned that i can add this 2 lines to every other program part that iterates time steps,
besides goal-M.ilp and goal-M-XY.ilp what are the other files to be candidate for this change and when it will show (as currently it works fine, with change only to goal-M.ilp)?

Hi @Thomas-Otto , continued my question from previous comment, I again tackle kind of the same issue.
We have added the ability to assign robots to specific shelves, in order to transform the problems from anonymous to non-anonymous (based on your team instructions).
Now again Clingo solving the problem and I can pipe it to viz, but doing it from the visualizer I get infinite calls UNSAT, not solving the problem.
Attached the same problem but with added ASSIGN rules, attached all changed encoding files to support it: input.lp, encoding.ilp, goal-M-assign.ilp
encodings_folder.zip
While attaching the zip file, I have tried to change output-M-assign.ilp, with added lines to show assign rule in the output, it made it worse: as i could only solve with Clingo, couldn't pipe to viz (empty everything, as it didn't pass the plan to the pipe), starting from viz show the same issue as infinite calls UNSAT.

Hi @davidabek1,
i meant that it does not matter to which file you add these lines to. It is just a matter of style and how you want to structure your code. It should also work if you add the lines to the "action-M.ilp" file.
The way the visualizer works is:
When is receives an instance it reads this instances in asp atoms and translates it into an internal model. When is sends an instance to the solver it translates this internal model back into asp atoms and send these atoms to the solver. So the visualizer does not simply sends whole instance files to the solver. Atoms that the visualizer can not handle are discarded.
The visualizer expects that every input atom follows a specific syntax:
init(object([OBJECTNAME], [OBJECTID]), value([VALUENAME], [VALUEVALUE])).
occurs(object([OBJECTNAME], [OBJECTID]), action([ACTIONNAME], [ACTIONVALUE])).
However every atom that the visualizer can't handle but matches this syntax will be remembered by the visualizer and will be send to the solver, too.
Long story short:
Your assign atoms in the instance file are ignored by the visualizer and are not send to the solver.
You must change the syntax of your atoms to something like:
init(object(robot, RID), value(assign, (SID, STATIONID))) or
init(object(assign, AID), value(assign, (RID, SID, STATIONID))).
Or you just add something like
"init(object(robot, RID), value(assign, (SID, STATIONID))) :- assign(robot(RID), shelf(SID), station(STATIONID))."
to your instance file and something like
"assign(robot(RID), shelf(SID), station(STATIONID)) :- init(object(robot, RID), value(assign, (SID, STATIONID)))."
to the "input-lp" file.


Unify more CUDA and HIP files into common

A lot of the files we have in common/cuda_hip don't work standalone, but instead require to be included with certain other includes being available. Here I'm trying to change this, allowing the files to be parsed from tooling more easily, and making it easier to write CUDA and HIP code simultaneously.
I did many of these modifications automatically using the following python script, or using plain text replacement to fix the headers

#!/usr/bin/env python3
import sys
import os
import difflib
import subprocess
common_filename = sys.argv[1]
base_filename = common_filename.replace(
    "common/cuda_hip/", "").replace(".hpp.inc", "")
cuda_filename = next(f"cuda/{base_filename}{extension}" for extension in [
                     ".cu", ".cuh", ".template.cu"] if os.path.exists(f"cuda/{base_filename}{extension}"))
hip_filename = next(f"hip/{base_filename}{extension}" for extension in [
                    ".hip.cpp", ".hip.hpp", ".template.hip.cpp"] if os.path.exists(f"hip/{base_filename}{extension}"))
output_filename = f"common/cuda_hip/{base_filename}{'.cpp' if cuda_filename.endswith('.cu') else '.hpp'}"

common_lines = list(open(common_filename))[3:]  # remove license header
cuda_lines = list(open(cuda_filename))
hip_lines = list(open(hip_filename))

cuda_file_guard = f"GKO_{cuda_filename.upper().replace('/', '_').replace('.','_')}_"
hip_file_guard = f"GKO_{hip_filename.upper().replace('/', '_').replace('.','_')}_"
common_file_guard = f"GKO_{common_filename.upper().replace('/', '_').replace('.','_')}_"

cuda_lines = [line.replace(cuda_file_guard, common_file_guard).replace(
    "namespace cuda", "namespace GKO_DEVICE_NAMESPACE").replace("CudaExecutor", "DefaultExecutor") for line in cuda_lines]
hip_lines = [line.replace(hip_file_guard, common_file_guard).replace(
    "namespace hip", "namespace GKO_DEVICE_NAMESPACE").replace("HipExecutor", "DefaultExecutor") for line in hip_lines]

for i in range(len(cuda_lines)):
    if cuda_lines[i].startswith('#include "cuda/'):
        cuda_lines[i] = cuda_lines[i].replace(
            '#include "cuda/', '#include "common/cuda_hip/').replace(".cuh", ".hpp")
for i in range(len(hip_lines)):
    if hip_lines[i].startswith('#include "hip/'):
        hip_lines[i] = hip_lines[i].replace(
            '#include "hip/', '#include "common/cuda_hip/').replace(".hip.hpp", ".hpp")

cuda_location = next(i for i, line in enumerate(cuda_lines)
                     if line.startswith(f"#include \"{common_filename}\""))
hip_location = next(i for i, line in enumerate(hip_lines)
                    if line.startswith(f"#include \"{common_filename}\""))
cuda_replaced = cuda_lines[:cuda_location] + \
    common_lines + cuda_lines[cuda_location + 1:]
hip_replaced = hip_lines[:hip_location] + \
    common_lines + hip_lines[hip_location + 1:]

cuda_replaced = subprocess.run(
    args=["clang-format", f"-assume-filename={output_filename}", "-"],
    stdout=subprocess.PIPE,
    stderr=subprocess.PIPE,
    input=bytes("".join(cuda_replaced), "utf-8"),
).stdout.decode().splitlines()
hip_replaced = subprocess.run(
    args=["clang-format", f"-assume-filename={output_filename}", "-"],
    stdout=subprocess.PIPE,
    stderr=subprocess.PIPE,
    input=bytes("".join(hip_replaced), "utf-8"),
).stdout.decode().splitlines()

if cuda_replaced == hip_replaced:
    with open(output_filename, "w") as file:
        file.write("\n".join(cuda_replaced))
else:
    print(common_filename)
    print(cuda_filename)
    print(hip_filename)
    print("\n".join(
        difflib.unified_diff(cuda_replaced, hip_replaced)
    ))

Some related questions:

What should be the canonical place of including hip_runtime.h? I don't think we should have to do that with every file, instead something like config.hip.hpp or types.hip.hpp seems most appropriate
Should hip::config be used on host or device or both? If we use it on the device only, we should be able to handle #1429 more easily, the host side should instead be handled with a runtime value, like exec->get_warp_size()

TBH, I'm not sure if this can be reviewed by humans. 200+ changed files are not easily processed manually. So I guess we have to rely on our CI.  If you could provide some key files to look at, that would help a lot.
But in general terms, unifying redundant code sounds good to me. Is the goal to unify as many files as possible and only exclude those, where the actual implementation differs? If so, maybe a list of files that are not suitable would be helpful.

@MarcelKoch Most of these changes are 90% automatical, but the remaining 10% is what's interesting. I'll see what I can do in terms of providing a diff what changed beyond the automated stuff. I reviewed a similar PR in the past using meld's three-way comparison.

Perhaps the easiest is if you already know where the 10% interesting stuff is, you could just give us a list of files and then we can manage.

I had to do so many small changes, I can't really remember, I'll have to reproduce that in an automated fashion

TBH, I'm not sure if the places where you did manual changes are that important. AFAIK the changes are mostly code movement, with the addition of perhaps some wrappers around the moved code. And I'm somewhat confident that our CI would catch errors on that level. If there are any changes besides that, it would be good to know if you can point us to those.
Otherwise, the question of review is rather on the concept itself and not on the individual changes.

Link to review only the non-automated changes: https://github.com/ginkgo-project/ginkgo/pull/1516/files/774b3d6b9b7d6d99fb8357685424f8bf6b027f97..e6d1e5fe469574ac8edd6067c9b0316e2cf0fa15
For the first commit, best look at the Python script in the PR description

Looking backwards, I think the major reason why we couldn't go further in unifying files then was that we didn't realize the chevron launch syntax <<<...>>> was supported since ROCm 2.8 already, which made having different files for CUDA and HIP necessary. The reason I'm trying to eliminate the .inc files is that they split up code across 3 files that should be the same file - earlier on it used to be kernel implementation vs. kernel launch and headers, now it is mainly kernel implementation + launch vs. headers. It is only a small step to pull the headers into the shared codebase as well.
With this change, the support for C++ tools is much improved, as they tend to separate files into headers and source files, neither of which the .inc files fit into.
Looking at how much of the code can be unified with a simple script without and diffs, I think this shows that we are already in-facto there, even if we didn't put in the effort of unifying the files.

Just a general comment, I think it would have been good if the python script itself would also have been part of the commits. This would allow to also comment on the script directly, which is not possible right now.

@MarcelKoch I added the script, but will remove it again before merging

@MarcelKoch The list is rather extensive - most of base, all factorization preconditioners, CSR, triangular solvers, Jacobi, batch. Especially with the base stuff, I don't think that would be feasible. Do all of these changes need to happen in this PR? The other work that is going on makes this a rather moving target, I'm already happy to have made it this far without any major rebasing required.

@upsj I didn't expect base to be part of that, so I was guessing it wouldn't be too many files (I'm already excluding batch, because that needs a rework anyway). But if that is not the case, then it should be done in a separate PR.
I would still like to see that done, because the directory structure is rather complicated right now.

@MarcelKoch I agree, that would be my next goal


Pulling docker image results in error “unauthorized: authentication required”

Hello,
I am trying to pull the latest qsiprep from docker hub but get an error “unauthorized: authentication required” when docker is pulling the specific part a508bf686514. I do not have issues with other images that I pull from docker hub. I already tried to logout/login from Docker to no avail sadly.
Is anyone else experiencing this issue? What software is a508bf686514?
Thank you!

 I've read that clock skew can cause problems like this.


Main-B-20975-too-submits-mto-and-receives-incorrect-validation

[INTEGRATION PR] (INT-B-20975)
Agility ticket
Summary
When the MTO shipment is submitted by the TOO, the confirmation message on the screen reads "Customer created successfully". The TOO does not create the customer, so this changes are made to display "Customer created successfully" after a SC saves a customer profile and also display "Task order created successfully" when a TOO approves a move.
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Access the MillMove application
Login in with an account with multiple roles at least with (Service Counselor(SC)  and Task Ordering Office(TOO) )
SC creates a new customer account , receives "Customer created successfully". Then go and create a move.
Log in as a TOO
Review and Submit move
"Task order created successfully" confirmation message displays.

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

@deandreJones this pr is ready for main merge when you get the chance, thanks

@brianmanley-caci this pr looks good for main merge when you get the chance.

@samaysofo the happo diffs look like there is an issue.

@samaysofo the happo diffs look like there is an issue.

@samaysofo you need to wrap those components in a <MockProviders> I think

You mean in the test , we use  instead of the  ?

@samaysofo the happo diffs look like there is an issue.

@samaysofo you need to wrap those components in a <MockProviders> I think

You mean in the test , we use instead of the ?

In the storybook of the component. That's what Happo checks. We added in checking state in the code, but the storybook component doesn't have a place to mock that state without a mock provider (aka mock redux)

@samaysofo the happo diffs look like there is an issue.

@samaysofo you need to wrap those components in a <MockProviders> I think

You mean in the test , we use instead of the ?

In the storybook of the component. That's what Happo checks. We added in checking state in the code, but the storybook component doesn't have a place to mock that state without a mock provider (aka mock redux)

ah ok gotcha, will make the change and create integrationTesting pr again.

@brianmanley-caci @danieljordan-caci I created an INT pr for the fix INT-PR

Good to go - can you make sure to link your second PR in the description of this one? Just so we have it documented there.


Application does not start (unexpected keyword argument 'socket_options')

When launching the application with python app.py we get the following error:
  File "<original path removed for privacy>/whisper-webui-github/app.py", line 1, in <module>
    import gradio as gr
  File "<original path removed for privacy>/venv/lib64/python3.10/site-packages/gradio/__init__.py", line 3, in <module>
    import gradio.components as components
  File "<original path removed for privacy>/venv/lib64/python3.10/site-packages/gradio/components.py", line 39, in <module>
    from gradio import media_data, processing_utils, utils
  File "<original path removed for privacy>/venv/lib64/python3.10/site-packages/gradio/processing_utils.py", line 20, in <module>
    from gradio import encryptor, utils
  File "<original path removed for privacy>/venv/lib64/python3.10/site-packages/gradio/utils.py", line 395, in <module>
    class Request:
  File "<original path removed for privacy>/venv/lib64/python3.10/site-packages/gradio/utils.py", line 415, in Request
    client = httpx.AsyncClient()
  File "<original path removed for privacy>/venv/lib64/python3.10/site-packages/httpx/_client.py", line 1397, in __init__
    self._transport = self._init_transport(
  File "<original path removed for privacy>/venv/lib64/python3.10/site-packages/httpx/_client.py", line 1445, in _init_transport
    return AsyncHTTPTransport(
  File "<original path removed for privacy>/venv/lib64/python3.10/site-packages/httpx/_transports/default.py", line 275, in __init__
    self._pool = httpcore.AsyncConnectionPool(
TypeError: AsyncConnectionPool.__init__() got an unexpected keyword argument 'socket_options'

Fixed version of httpx dependency


Allow Angular 7

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Can't be included in angular 7 projects
https://github.com/swimlane/ngx-datatable/issues/1582
What is the new behavior?
Allows peer dependency of angular 7
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Thanks!


I beleive that a pure python implementation would be faster in this situation. I've re-implemented in our patckage the case  where data=False in pure python and got a speedup of ~20x

https://github.com/jonnymaserati/welleng/blob/0afc2ddd62f6b4605dc9ea3ea20d021b7315e974/welleng/survey.py#L1647-L1670

Thanks for the feedback @Jrmy-rbr!
PRs are always welcome if you'd like to share your optimized version.

With this code, I get a speed-up of a factor ~ 2.25. The bottleneck being the call to _get_sections() which cannot be solved in the tortuosity function itself.
M_TO_FT = 1/0.3048
FT_TO_M = 0.3048

def dist(pos1: Union[List[float], np.ndarray], pos2: Union[List[float], np.ndarray])->float:
    vec = [p1i - p2i for p1i, p2i in zip(pos1, pos2)]
    return math.sqrt(sum([v1 * v2 for v1, v2 in zip(vec, vec)]))

def cumsum(iterable: Union[List[float], np.ndarray])->List[float]:
    result = iterable.copy()
    for i,el in enumerate(iterable):
        if i != 0:
            result[i] += result[i-1]
    return result

def tortuosity_py(survey:Survey)->List[float]:
    sections = survey._get_sections()
    sections_upper, sections_lower = sections[1:-1], sections[2:]
    n_sections = len(sections_upper)

    l_c = (sections[-1].md - sections[1].md) * M_TO_FT

    factor = (n_sections / (n_sections + 1)) / l_c * 1e7

    return cumsum([factor*((l.md - u.md) / dist(l.location, u.location)-1) for u,l in zip(sections_upper, sections_lower)])

Thanks @Jrmy-rbr
I'm not sure where you're getting your benchmarks from and they seem to be decreasing by orders of magnitude each time? :-)
I'm coding up a modified TI method so figured I'd take a look at your suggestion. See below some performance comparisons for your code, the original (poor) numpy implementation and an updated numpy implementation. When I run the Volve wells (about 100 actual/drilled wellpaths) through these functions I get the following:
Importing the data...
Extracting survey data...
Processing wells...
modified_tortuosity_index = 0.2917945384979248 seconds
tortuosity_py = 0.3112528324127197 seconds
tortuosity_index = 0.39501476287841797 seconds

So looks like your native code is about 20% faster and the refactored numpy code is 7% faster again.
The test code is below if you want to try it out yourself... I expect the numpy version to be faster the more sections there are per well, with your native version probably being quicker if there's only a few sections since the overhead should be much smaller.
I'll add the refactored numpy implementation in the next version.
import welleng as we
import numpy as np
import pandas as pd
import xml.etree.ElementTree as ET
from tqdm import tqdm
import time
import math
import ray

# for ease I accessed the data file locally and gave it a
# shorter name. You'll need to change this to reflect the
# local location of the data file.
filename = 'data/Volve.xml'
M_TO_FT = 1/0.3048
FT_TO_M = 0.3048

ray.init()

@ray.remote
def generate_survey(df, well):
    sh = we.survey.SurveyHeader(
        name=well,
        azi_reference="grid"
    )
    w = df.loc[
        df['def_survey_header_id'] == well
    ].sort_values(by=['md'])
    cov_nev = we.survey.make_long_cov(np.array([
        w['covariance_yy'],
        w['covariance_xy'],
        w['covariance_yz'],
        w['covariance_xx'],
        w['covariance_xz'],
        w['covariance_zz']
    ]).T).astype(float)

    # radius data is sometimes missing or zero and looks to be in inches
    # default these to 15" radius and convert to meters
    radius = np.array(w['casing_radius']).astype(float)
    radius = np.where((np.isnan(radius) | (radius == 0)), 15, radius)
    radius *= 0.0254

    s = we.survey.Survey(
        md=np.array(w['md']).astype(float) / 3.281,
        inc=np.array(w['inclination']).astype(float),
        azi=np.array(w['azimuth']).astype(float),
        n=np.array(w['offset_north']).astype(float),
        e=np.array(w['offset_east']).astype(float),
        tvd=np.array(w['tvd']).astype(float) / 3.281,  # appears that TVD data is in feet?
        header=sh,
        cov_nev=cov_nev,
        radius=radius
    )

    return s

def tortuosity_index(survey, data=False):
    sections = survey._get_sections()
    sections_upper, sections_lower = sections[1:-1], sections[2:]
    n_sections = len(sections_upper)

    # assume that Survey object is in meters
    l_c = (sections[-1].md - sections[1].md) / 0.3048

    l_cs, l_xs = np.vstack([
        [
            l.md - u.md,
            np.linalg.norm(np.array(l.location) - np.array(u.location))
        ]
        for u, l in zip(sections_upper, sections_lower)
    ]).T

    ti = np.hstack((
        np.array([0.0]),
        (
            (n_sections / (n_sections + 1)) * (1 / l_c) * (
                np.cumsum(
                    (l_cs / l_xs) - 1
                )
            )
        ) * 1e7
    ))

    return ti[-1]

def modified_tortuosity_index(self):
    sections = self._get_sections()
    sections_upper, sections_lower = sections[1:-1], sections[2:]
    n_sections = len(sections_upper)

    l_c = (sections[-1].md - sections[1].md) / 0.3048

    l_cs, u_loc, l_loc = [], [], []
    for u, l in zip(sections_upper, sections_lower):
        l_cs.append(l.md - u.md)
        u_loc.append(u.location)
        l_loc.append(l.location)

    l_cs = np.array(l_cs)
    l_xs = np.linalg.norm(np.array(l_loc) - np.array(u_loc), axis=1)

    ti = np.hstack((
        np.array([0.0]),
        (
            (n_sections / (n_sections + 1)) * (1 / l_c) * (
                np.cumsum(
                    (l_cs / l_xs) - 1
                )
            )
        ) * 1e7
    ))

    return ti

def dist(pos1, pos2):
    vec = [p1i - p2i for p1i, p2i in zip(pos1, pos2)]
    return math.sqrt(sum([v1 * v2 for v1, v2 in zip(vec, vec)]))

def cumsum(iterable):
    result = iterable.copy()
    for i,el in enumerate(iterable):
        if i != 0:
            result[i] += result[i-1]
    return result

def tortuosity_py(survey):
    sections = survey._get_sections()
    sections_upper, sections_lower = sections[1:-1], sections[2:]
    n_sections = len(sections_upper)

    l_c = (sections[-1].md - sections[1].md) * M_TO_FT

    factor = (n_sections / (n_sections + 1)) / l_c * 1e7

    return cumsum([
        factor*((l.md - u.md) / dist(l.location, u.location)-1)
        for u,l in zip(sections_upper, sections_lower)
    ])

def main():
    # read the WITSML data
    print("Importing the data...")
    try:
        tree = ET.parse(filename)
        root = tree.getroot()
    except:
        print("Please download the volve data and point filename to its location")

    # extract the survey data and create a dataframe
    print("Extracting survey data...")
    survey_data = [
        c.attrib for c in root
        if c.tag == "CD_DEFINITIVE_SURVEY_STATION"
    ]
    df = pd.DataFrame(survey_data)
    df['md'] = df['md'].astype(float)

    wells = df['def_survey_header_id'].unique()

    print("Processing wells...")
    # this is a bit slow... multithread this if you want to do it faster
    data = [
        generate_survey.remote(df, well)
        for well in tqdm(wells)
    ]
    surveys = ray.get(data)

    start = time.time()
    for survey in surveys:
        ti_0 = modified_tortuosity_index(survey)
    finish = time.time()
    print(f"modified_tortuosity_index = {finish - start} seconds")

    start = time.time()
    for survey in surveys:
        ti_1 = tortuosity_py(survey)
    finish = time.time()
    print(f"tortuosity_py = {finish - start} seconds")

    start = time.time()
    for survey in surveys:
        ti_2 = tortuosity_index(survey)
    finish = time.time()
    print(f"tortuosity_index = {finish - start} seconds")

    print("Done")

if __name__ == "__main__":
    main()


Add connect exercise

This is an implementation of the new connect exercise (exercism/x-common#54).

:+1:


Support for platforms other than Bukkit

I think InvUI is the best library for creating a serverside gui in minecraft, I would really like to use it for example in Minestom.
If you plan to somehow radically change the library, I would very much like the platform code to be separated from the api code

Thanks for your feedback, but this would require rewriting most parts of the library (because basically everything works around Bukkit's implementations), so it's probably something that I'll do in the near future, if ever.


Zeal: Cannot download RFC docset

I just installed Zeal 0.6.0 on a fresh Debian unstable system and added the rfcdash docset. I get:

Error transferring https://api.cld.me/0s1k080e1N0K/download/RFCs.docset-v1.5.0.tgz - server replied: Not Found

Sorry for that, it should work now.

Thank you for the quick solution!


[Hyperdrive] add Supabase example for Hyperdrive

@Maddy-Cloudflare I have addressed your comments. can you PTAL?


YARN-2017

https://issues.apache.org/jira/browse/YARN-2017

YARN-2017 Abstract away object types
YARN-2017 update capacity scheduler
YARN-2017 update fair scheduler
YARN-2017 Update fair scheduler
YARN-2017 Update tests
YARN-2017 partial application of missing part from yarn-1474
YARN-2017 update findbugs
YARN-2017 remove unused imports
YARN-2017 fix failing tests

Can one of the admins verify this patch?


Adding profiles should be easier through visual editors

Description of the new feature/enhancement
It would be great if we had a visual editor to add profiles. For noob users (like me) it is too hard to generate GUIDs and deal with ms-appx:// links!

Proposed technical implementation details (optional)
How about a popup with options similar to MS Profiles?

You get the drill, don't you? Please consider adding it to v1.0 release

/dup #1564


Make execute_on_stream inherit from dependencies_aware_execution_policy

This is a short-term fix, long-term some major restructuring is needed.

Actually, we should probably add at least one test for this use case. I'm assuming this is for issue #1195?

Yah agreed we need a test for this.

So this doesn't actually work as intended. The longer term solution may be needed instead.

Superseded by #1230


Wont this method also affect other male lalafell?


Dealing with large CSVs

Hey Chris,
first of all thanks for crafting this awesome VIM plugin!
I tested you file with a more or less large CSV and tried the nifty :%ArrangeColumn on it - and it takes very long to finsh. Is there a trick maybe to deal with large CSVs? Something like partial or streamed loading of a file? Or a lazy evaluating application of commands?
I checked the help file (Ctrl-F) but couldn't find something helping me in that regard.
 I'll check if there is some way to make :ArrangeCol faster

I may try myself, but could be a good use case for JobControl on Neovim here. Just planting the seed.

Isn't JobControl only for external commands, like system() or :! or so? I don't think, this can make internal VimL functions faster...

I used it on 400MB csv and it works for few minutes very good,  then vim blocks.

this probably depends on what you do. certain operations will make Vim slow, like :ArrangeCol or so.

I just  to move full screen. The vim is frozen for 30seconds. I have 2 million records with 18 columns.

I just tried to open a 3 MB file with 1600 rows and four columns. I tried to page down a few times and vim freezes for about a minute. Works perfectly on small files, though.

Oops, my mistake; a few fields were 200 000 characters long. Sorry for the noise!

Yeah, this is a known problem. I intend to rewrite part of the :ArrangeCol command using python (which would only work on a vim compiled with +python), but I haven't found the time for that (and I don't know python well enough to do that quickly), therefore it might take some time, until I get to do it (and there is always something else to do :(
I guess, if moving around bothers you, you can disable syntax highlighting and you might want to experiment with different 're' settings. Also :syntime report would be interesting for such slow csv files. Also I think there is a help entry, on how to switch to a possible simpler syntax highlighting, which would be worth a try.

Hi Chris,
I also wanna thank you for the plugin. Makes life much easier when handling csv files.
However,
I'm having lots of trouble dealing with a 5.3 MB file. (52242 rows x 7 cols)
Each time I try moving up or down, the plugin complains that it will only use the first 10000 lines to compute column width. Is there some configuration I can apply to fix this?
Also initial loading time is quite large. Are you planning any updates that can improve this?

I can only do so much and depending on the csv file, creating the regular expressions can be expensive. What configuration are you using for the plugin? I suppose some kind of autocommand like it is mentioned in the documentation?
https://github.com/chrisbra/csv.vim/blob/master/doc/ft-csv.txt#L1648-L1678

My config is as follows:
let g:csv_no_progress = 1
let g:csv_strict_columns = 1
:let g:csv_start = 1
:let g:csv_end = 100

Is there something I'm missing that would allow it to run faster?

I wonder where this:

Each time I try moving up or down, the plugin complains that it will only use the first 10000 lines to

comes from. Is there any CursorMoved autocommand installed?

Is there something I'm missing that would allow it to run faster?

I am not sure. Some profiling information would be good to see what exactly is slow.

No, I don't have any autocommand installed that works on CursorMoved.
This is my plugin list. Is it possible that csv.vim is incompatible with one of them?
vim-airline/vim-airline
taglist.vim
airblade/vim-gitgutter
scrooloose/nerdtree
w0rp/ale
ntpeters/vim-better-whitespace
pseewald/vim-anyfold
neovimhaskell/haskell-vim
tpope/vim-commentary
cespare/vim-toml
junegunn/fzf
junegunn/fzf.vim
In any case, I have profiled the problem and noticed the following:

My tendency to use arrows instead of hjkl :( is the main reason for the huge delays. (with hjkl I have almost no delay) I do not understand the difference though...
csv#MoveCol seems to be the most expensive function call. (~ 10s total run time)

Note that I profiled with a file of ~3000 lines, so I didn't get the message I mentioned before, but got huge delays nonetheless.
I have attached the profiling logs, so that you could have a look :)
profile.log

hm, looks suspicious that csvColWidth() is called so many times (and recalculates the current widht over and over again). I am not using this plugin anymuch anymore, since I don't have to handle CSV files a lot nowadays.
For now, try to disable the mapping of <up> and <down> using
:let g:csv_nomap_up=1
:let g:csv_nomap_down=1

that should make <Up> and <Down> work faster.

@chrisbra @Michel-Haber A great releave and -maybe- relatively easy for this admittedly anoying "CSV file to large only checking the ..." would be to show it only once per buffer?
BTW setting the old regex engine set re=1 which has better performance on edge cases causes an error.

thanks, I have a look.

Hi Chris, using a 27000 line CSV comes with the message about the 10000 line limit TWICE for each cursor-up or down. Disabling it (like you mentioned) fixed it so far for me.

Ah, I wanted to have a look, forgot about it. Anyhow, should be fixed now.

Sorry for suggest other plugin here. csv.vim served me for long time. But fails with large files (20Mb or above)
https://github.com/mechatroner/rainbow_csv this just works, you can filter, etc...


master -> staging

Proposing to merge master -> staging to fix ~10 Rust packages via https://github.com/NixOS/nixpkgs/pull/80153, and also avoid merge conflicts with the treewide no-op https://github.com/NixOS/nixpkgs/pull/79978

@bhipple See https://discourse.nixos.org/t/maintainers-needed-for-merging-staging-staging-next-branches/3833/4

Are you sure?  I changed the target branch from staging to staging-next, but if that's actually how it's supposed to be done, then I think the RFC wording might be out of date?

staging-next is branched from staging and only fixes to stabilize and security fixes shall be delivered to this branch. This branch shall be merged into master when deemed of sufficiently high quality.

This seems to imply that the merge goes master -> staging -> staging-next -> master.

I just merged master into staging, there weren't any conflicts.

Updates from master are typically merged via staging-next into staging, however, that is not necessary per se, e.g., if there aren't any updates in staging-next (as was the case now) there is no point.


chore: update github action to allow workflow calls

:tada: This PR is included in version 2.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.1.0-alpha.11 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Clicking on a rectangle, then text inside selects both

Repro:

Create a rectangle with background
Create a text in the middle
Click on the rectangle
Click on the text (WITHOUT shift)
Both are selected. Only the text should be selected

cc @dwelle

Not just text, but anything:
Looks like the regression was indeed introduced in my last PR :/


Library & Sample update

SdkTarget is now 21 for both Library and Sample
Updated Library & Sample to use latest gradle and support library
Using AppCompat v7 instead of ActionBarSherlock for ActionBar support
Removed .idea from versioning (versioning .idea adds to many noise and isn't necessary)

Nice, thanks


Search results in Search tab do not use the includes and excludes from the main settings

When selecting an index to include in the settings, push the search button (without any search term entered) and you get back a lot more than you want to. You actually get back all records from all indices.

Fixed with the last push, now the search screen also uses the includes


Feature Request: Embed Solidity Comments/Documentation with Typescript Types

Disclaimer: I'm very new in this field of development. Sorry, if I have taken something completely wrong in advance :D
Wouldn't it be nice if the types generated by typechain/eth-sdk would also include the comments/documentation provided within the solidity contract files? So that if I hover over a function in VSCode the documentation pops up? I guess that task is not so easy as the comments are not included within the ABIs downloaded from etherscan, right?

Hey @wottpal,
this is a great question actually and having this feature would have a perfect sense!
These kinds of comments are called natspect and TypeChain (which we use under the hood) has already limited support for them. The problem is that natspec is stripped out by etherscan so we don't have a good source for abi with natspec.
I think that Sourcify provides them but the amount of verified contracts there is limited for now.

Hey, thanks for your reply. So to conclude, it would be helpful if the etherscan APIs would also provide natspect side-by-side with the ABIs, right? Should we ask in their Reddit for it? (I just noticed their project isn't OS which feels a little bit odd as they are such an integral part of web3-tooling).

@wottpal yeah, sounds good. You should ask them about it.

just for the records: https://www.reddit.com/r/etherscan/comments/s2zr9o/provide_contract_natspect_together_with_abis/


ResearchStudy.condition coding  inconsistencies between dbGap, AnVIL and KidsFirst

We should use the same ontologies (or provide mappings).
While all three systems use ResearchStudy.condition to indicate the condition that is the focus of the study.
All three have a significant number of studies without a populated condition.
In addition, all three systems use different ontologies:
system:
ontology system:  study_count
* 'kidsfirst':
    * None: 21,
    * 'http://snomed.info/sct': 8
* 'dbgap':
    * None: 234,
    * 'https://dbgap-api.ncbi.nlm.nih.gov/fhir/x1/NamingSystem/MeshEntryTerm': 1597,
    * 'https://uts.nlm.nih.gov/metathesaurus.html': 1459,
    * 'urn:oid:2.16.840.1.113883.6.177': 1591
* 'anvil':
    * None: 358,
    * 'http://purl.obolibrary.org/obo/doid.owl': 35

Hi Brian, the FHIR ResearchStudy condition and focus are two different things.
Some studies do not have a condition, because the study does not focus on conditions, rather than normal sample as a control or reference. We have explored this when looking at the NCPI data catalog.
Thanks,
Asiyah

Hi Brian, the FHIR ResearchStudy condition and focus are two different things. Some studies do not have a condition, because the study does not focus on conditions, rather than normal sample as a control or reference. We have explored this when looking at the NCPI data catalog.
Thanks, Asiyah

Hi Asiyah,
Agreed that condition and focus are two different things - that may explain at least some of the studies without a Condition.
However, where there is a condition,  I'm concerned that we have 5 different ontology systems.

What guidance would we provide to researchers searching by condition?
What might we do to reduce the number of ontologies used or simplify mapping between them?

Hi Brian,
Can you list the 5 different ontology systems? I have done some work of mapping DO-MONDO-MeSH for NCPI data catalog. which is based on the dbGaP FHIR server. I also have some experience with ontology harmonization or alignment, and I am working with DO and MONDO to resolve the inconsistencies I see from NCPI use case. If you list the 5 ontologies out, we may make a case for aligning all these 5 ontologies for the NCPI community.
Thanks,
Asiyah

If you list the 5 ontologies out, we may make a case for aligning all these 5 ontologies for the NCPI community.

From above ...
Thanks!
-b

'kidsfirst':
* None: 21,
* 'http://snomed.info/sct': 8
'dbgap':
* None: 234,
* 'https://dbgap-api.ncbi.nlm.nih.gov/fhir/x1/NamingSystem/MeshEntryTerm': 1597,
* 'https://uts.nlm.nih.gov/metathesaurus.html': 1459,
* 'urn:oid:2.16.840.1.113883.6.177': 1591
'anvil':
* None: 358,
* 'http://purl.obolibrary.org/obo/doid.owl': 35

Do you know what this is for: urn:oid:2.16.840.1.113883.6.177
On Thu, Dec 2, 2021, 18:31 Brian @.***> wrote:

If you list the 5 ontologies out, we may make a case for aligning all
these 5 ontologies for the NCPI community.
From above ...
Thanks!
-b

'kidsfirst':

None: 21,
'http://snomed.info/sct': 8

'dbgap':

None: 234,
'
https://dbgap-api.ncbi.nlm.nih.gov/fhir/x1/NamingSystem/MeshEntryTerm':
1597,
'https://uts.nlm.nih.gov/metathesaurus.html': 1459,
'urn:oid:2.16.840.1.113883.6.177': 1591

'anvil':

None: 358,
'http://purl.obolibrary.org/obo/doid.owl': 35

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NIH-NCPI/ncpi-fhir-ig/issues/44#issuecomment-985085880,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACCPEPIDBFY5R4BEOXZM2DLUO76UFANCNFSM5JFVHB6A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I'm traveling now, and will be out of office next week. Will follow up
then.  As far as I know:
https://www.hl7.org/documentcenter/public/standards/vocabulary/vocabulary_tables/infrastructure/vocabulary/voc_ExternalSystems.html
On Thu, Dec 2, 2021, 4:21 PM Asiyah Yu Lin @.***> wrote:

Do you know what this is for: urn:oid:2.16.840.1.113883.6.177
On Thu, Dec 2, 2021, 18:31 Brian @.***> wrote:

If you list the 5 ontologies out, we may make a case for aligning all
these 5 ontologies for the NCPI community.
From above ...
Thanks!
-b

'kidsfirst':

None: 21,
'http://snomed.info/sct': 8

'dbgap':

None: 234,
'
https://dbgap-api.ncbi.nlm.nih.gov/fhir/x1/NamingSystem/MeshEntryTerm':
1597,
'https://uts.nlm.nih.gov/metathesaurus.html': 1459,
'urn:oid:2.16.840.1.113883.6.177': 1591

'anvil':

None: 358,
'http://purl.obolibrary.org/obo/doid.owl': 35

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/NIH-NCPI/ncpi-fhir-ig/issues/44#issuecomment-985085880
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ACCPEPIDBFY5R4BEOXZM2DLUO76UFANCNFSM5JFVHB6A
.
Triage notifications on the go with GitHub Mobile for iOS
<
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
<
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NIH-NCPI/ncpi-fhir-ig/issues/44#issuecomment-985108170,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAALVQGSNB2ZVQYU4L5CPBTUPAEO5ANCNFSM5JFVHB6A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

It looks like that urn is mesh again.
Based on our prior conversations, it sounded like "Given we are using these ResearchStudy objects as a way to do information retrieval, MeSH is a good target". The field is a codeable concept, so we can have a custom free text and multiple ancillary concepts included. IE, if I'd like to flag with SNOMED concept, great, but I should also include the MeSH term that's most relevant.


Community Member

As a DAO user I would like to be able to have a community member so that the DAO can have a clear separation

member should have hypha account
member should have at least one token

AC:

[ ] scan blockchain for TELOS accounts that are also HYPHA accounts
[ ] add community tag if they hold token

@Alex-IS we need your help for this feature. @Gerard097 needs list of all accounts stored in ppp so that he can check if they have balances.

@n13 I'm tagging you here because we talked about this two weeks ago, and you said that you can help with this. Gary will need a list of all current accounts so he can scan and check if they are members of a dao's community (ie have a token)


[WIP] Get CompanyAddress field to autofill and show errors

Details

This component uses a 3rd party package to populate the dropdown list for addresses. After quite a lot of wrestling we decided to just make AddressSearch a functional component because that seems to fix our problems immediately.
Fixed Issues

$ https://github.com/Expensify/App/issues/5794
Tests / Web QA

Sign into New Dot (new account is fine)
Create a new workspace
Connect a new bank account
Follow this SO for the routing number and account number https://stackoverflow.com/c/expensify/questions/342/525#525
Input valid information on all fields in the Company Information step (doesn't need to be real info)

Variant 1

Refresh the page

Variant 2

Hit Submit. When you're on Step 3 (Personal Information) click the back arrow to go back to Step 2 (Company Informaion)

Either way

Notice that all the fields are auto-filled except for the Company Address.

Tested On

[ ] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Putting this on WIP until I've tested on all platforms

Can we add the CP Staging label to this, so we can get it into the launch.

🚀 Cherry-picked to staging by @robertjchen in version: 1.1.7-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@isagoico that is a typo, company address should be auto-filled. Can we check this one off?

Yup my bad. That was copy pasta from the issue I made for this 😬


Dashboard

Please draw/scribble a wireframe of what you want this to look like

Ping on this

I plan to do this this afternoon from about 1500.

Assigned to @lamby as per email conversation today

(delete confirmation)


[flutter_webview] PWA support for offline access in Mobile devices #561

Use case
Is it possible to cache "initialURL" so that if there is no internet, InitialURL always opens the page from the local cache if the app has been opened at least once and the cache is not cleared.
Proposal
Caching the intialURL as well as follow up URL after the first-page load just like PWA insides flutter.
What was done
I just created a simple WebView flutter app and accessed PWA website all pages, closed the app, disconnected from the internet, opened the app again and voila got the error, the page is not available.
But it works fine in the mobile chrome browser, it loads all pages I accessed with my Internet on even after disconnecting from the internet.
But inside flutter webview app, I get an error, "This webpage is not available".

@rebootcode
maybe I didn't understand correctly, but
it seems to me that you want to cache the whole destination of the url rather than the url itself
if so, I'm not sure it's realistic expectation

PWA has an offline store option and if flutter_webview can support PWA, It will be just a magical moment.

@rebootcode ,To use flutter_webview, you would have to create a flutter app which supports android and iOS only.
flutter_webview currently doesn't support flutter web.
This Stackoverflow question has a workaround.
After following that, building a flutter web app will enable caching by default and if you deploy the web app with SSL, it can be used as a PWA.

@sidrao2006 - Do  you mean https://pub.dev/packages/flutter_webview_plugin has PWA support using below options:
    bool withLocalStorage: true,
    bool withJavascript: true,
    bool clearCache: false,
    bool clearCookies: false,
    bool enableAppScheme: true,
    bool withLocalStorage: true,
    bool appCacheEnabled: false,

Does enableAppScheme implies PWA support?

@rebootcode , sorry I'm not sure about that package

@rebootcode , sorry I'm not sure about that package

Where is a workaround in the question, it just tells you how to create "webview" for which we already have a plugin?
This whole thread is about supporting the "PWA" inside flutter_webview package.

@rebootcode , as I've mentioned above, flutter_webview does not support web. It throws a PlatformException if you try to run it in the web.
The question I linked to has a workaround to this problem. The problem being that the authors of the package did not add web support to it and you can only run it on other platforms as a flutter app and not a PWA. Since, your aim is building a PWA, you will might to follow the given solution.
Thanks

Also, since this is neither a bug nor a feature request, please close this issue if you agree with me
Thanks

@sidrao2006 - what do you mean, this is not a feature request?
It is a feature request for "PWA Support" inside flutter_webview plugin

@rebootcode please check #45295 which requests to add web support for webview

@rebootcode please check #45295 which requests to add web support for webview

I literally have no IDEA, why would people want "WebView"for flutter web. This is out of my imagination right now to imagine a web application inside WebView. It sounds like someone just need to learn iframe, but that is beyond the discussion for this thread.

Flutter web completely supports PWAs. Flutter webview is like any other widget which can be used in a flutter app. However it isn't supported on the web (which is addressed in the above mentioned issue)

@rebootcode Flutter already supports PWAs.
Also, one of the ways of using webview in web is with iFrame.

@rebootcode Flutter already supports PWAs.

No, it is not, I just created a simple WebView flutter app and accessed web page, closed app, closed internet, open app and voila got the error, the page is not available.

@rebootcode , I think you've got it a little wrong.
PWA is a standalone web app / web site with a platform wrapper provided  by the browser. You DO NOT have to build a native app. That's the whole point of a PWA! You just way to work with web technologies and the browser does the work for you.
What you're referring to is something like a TWA which can be deployed to the playstore as an android app but is actually a native webview.
I'm not sure whether you want something like this.
Please refer to this Stackoverflow question. It should satisfy your requirement.
Flutter Web supports PWA but Webviews can't support PWA. Because you cannot have a PWA inside a native app. Also, webviews support for web has to use Iframes. You cannot run a browser instance within a browser

@sidrao2006 - buddy, no offence, but you are talking all stuff that's just irritating, provoking and written with less thought or maybe someone put you on disk to write it here even though if you have no idea,
1). If you don't need it, don't come to this thread and share your input, it makes the whole thread a trash post
2). If You think you don't need PWA with your logic you don't even need "webView", you can just ask your user to do "Bookmarking" of your web on the browser.
The title clearly mentions 3 interesting points:
1). PWA -> Offline access -> Mobile devices
If webview supports "local storage", "cookies" and the whole world, it must also support PWA for "offline access" property which is such a necessity.
PWA Offline access supports in webview is pretty powerful as it will make webview more like a native app with its offline access property.
The main thing here is "offline access" feature of PWA.

@rebootcode , I have provided a link to a package that does the same.

Again, you are using the wrong terms and that's confusing.
PWAs are standalone.
Yes, I agree, caching webview URLs is useful but that doesn't make it a PWA if you are using native code to implement other functionality as well.
Again, PWAs are generated by the browser, not the developer

Please refer to this guide - https://web.dev/progressive-web-apps and this one - https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps

Due to Flutter's limitations on 3D, I also have a significant portion of the application in WebView, and PWA support for WebView would be very helpful. Since in our region, there are problems with the Internet coverage.
Offtopic: dear @sidrao2006 your opinion is understandable, but it seems to me that your comments (more than half of all others) somewhat clog this thread. Sorry

@sidrao2006 - Please keep your comment off this thread, your comments are way too much distracting to the post with your little knowledge and opinion.
Kindly let the flutter team have a look at it.
Mr. @sidrao2006 , I highly recommend deleting your post, it's confusing to the community here, we all are here well knowledgable developers at least know, "how to google & search", thus no point in sharing a technology glossary list.

@rebootcode
I see there's an open feature request to integrate PWA for webview_flutter plugin. Also see this comment on feasibility of this request implementation. Would you be okay to follow-up in that issue and close this one as duplicate ?
Thanks.

@darshankawar, I see the previous #30582 thread recommends downloading the PWA app inside flutter.
But I recommend instead of downloading another app, just supporting the "offline" or "page cache" features using serviceworker or something similar inside webview to let page accessible offline.
It sounds similar and the objective may sound similar, but the approach and requirement are strictly for "offline" based access using serviceworker cache or something similar.
Not sure, if merging both and closing this thread would be right.

Related to 30582

+1
@FlutterIssues This should be hot for webview

+1
It's necessary for Web Apps to create an experience like the "native app".

is there any method for offline cache web view support for the Flutter ios app?


Add a " Get Magicoins " hack...

I am sure everyone is missing magicoins right? Well if you do this hack, no one will have this problem anymore !
So basically, the hack should ask the player " How much Magicoins do you want? ", then the player types in the amount desired and then it automatically gives the player amount of Magicoins he wanted...
Please add this cool function !

Please do it

yes pls

How do you redeem a code