Weird exit message: snapshot saved, context canceled, exit code 1

Hi,
Following up this thread: https://forum.restic.net/t/weird-exit-message-snapshot-saved-context-canceled-exit-code-1/939/3

Hi, I am running restic with sftp backend.
On large folder sets (500MB) it sometimes produces this error: context canceled.
However snapshot is being saved. Same thing I caught on S3 backend.
Basically I need exit code 0 to make sure it worked fine, for monitoring purposes.
Thank you.

I have applied that patch:
--- a/cmd/restic/main.go
+++ b/cmd/restic/main.go
@@ -88,8 +88,8 @@ func main() {
        switch {
        case restic.IsAlreadyLocked(errors.Cause(err)):
                fmt.Fprintf(os.Stderr, "%v\nthe `unlock` command can be used to remove stale locks\n", err)
-       case errors.IsFatal(errors.Cause(err)):
-               fmt.Fprintf(os.Stderr, "%v\n", err)
+//     case errors.IsFatal(errors.Cause(err)):
+//             fmt.Fprintf(os.Stderr, "%v\n", err)
        case err != nil:
                fmt.Fprintf(os.Stderr, "%+v\n", err)

And executed it again:
+ export DEBUG_LOG=/tmp/restic-debug.log
+ DEBUG_LOG=/tmp/restic-debug.log
+ run_backup
+ restic.debug2 version
debug log file /tmp/restic-debug.log
debug enabled
restic 0.9.2 (v0.9.2-64-gf1b0bb3-dirty) compiled with go1.9.4 on linux/amd64
+ grep -Pv '^unchanged '
+ restic.debug2 -r sftp:pathos.tanatos.org@pavel.wsynth.net:/home/pathos.tanatos.org/restic backup --files-from ./files --exclude-file ./excludes -v -v
debug log file /tmp/restic-debug.log
debug enabled
open repository
lock repository
load index files
using parent snapshot 16cfb49f
start scan on [/var /home/fuck/btsync/encdroid.encdroid /usr/local /etc /opt /root]
start backup on [/var /home/fuck/btsync/encdroid.encdroid /usr/local /etc /opt /root]
modified  /etc/openvpn/openvpn-status.log, saved in 0.011s (427 B added)
modified  /root/.config/rss2email.cfg, saved in 0.014s (0 B added)
modified  /root/.local/share/rss2email.json, saved in 0.206s (2.452 MiB added)
modified  /var/www/odesk.rss, saved in 0.155s (1.045 MiB added)

Files:           0 new,     4 changed, 36422 unmodified
Dirs:            0 new,     0 changed,     4 unmodified
Data Blobs:      4 new
Tree Blobs:      1 new
Added to the repo: 3.500 MiB

processed 36426 files, 0 B in 0:54
snapshot d6cdea05 saved
context canceled

real	0m54.585s
user	0m41.416s
sys	0m3.368s
+ local EXIT_CODE=1

Still, the same error & no stacktrace.  Log file attached.
restic-debug.log.gz

I'm also seeing this message with an SFTP backend, not sure about the exit code. See https://github.com/restic/restic/issues/1356#issuecomment-417753573

Me too from time to time with SFTP, I do not remember if it happens with S3 too.

I could completely get rid of this bug by deleting restic cache folder right before running restic. Then exit code is 0.

So it looks like it's related to the cache, hm.

Ha, found the issue. It is not related to the cache, but deleting the cache changes restic's behavior so that the issue does not occur. The underlying issue is that when the backup is finished faster than the scanner (which is only used to display progress information), the error is returned. When restic is busy downloading metadata to a cold cache, the scanner is always finished faster.
Here are the juicy details:

backup starts, restic runs the scanner and the archiver in parallel
when the archiver is done, the tomb is cancelled here: https://github.com/restic/restic/blob/6d9c008900609e894ebc35ec5935f40ab31928d0/cmd/restic/cmd_backup.go#L513
This cancels all contexts derived from this tomb, including the one passed to the scanner here: https://github.com/restic/restic/blob/6d9c008900609e894ebc35ec5935f40ab31928d0/cmd/restic/cmd_backup.go#L466
When the context passed to the scanner is canceled, its Err() method returns the Error: Context cancelled, which is then returned by the scanner, e.g. here: https://github.com/restic/restic/blob/6d9c008900609e894ebc35ec5935f40ab31928d0/internal/archiver/scanner.go#L54-L56
This error bubbles up and is returned by the function run by t.Go() here: https://github.com/restic/restic/blob/6d9c008900609e894ebc35ec5935f40ab31928d0/cmd/restic/cmd_backup.go#L466
Which is then returned by t.Wait() here: https://github.com/restic/restic/blob/6d9c008900609e894ebc35ec5935f40ab31928d0/cmd/restic/cmd_backup.go#L516-L519

In the end, it bubbles up to the main function.
For a very small backup set, the issue can be provoked with the following patch:
diff --git a/cmd/restic/cmd_backup.go b/cmd/restic/cmd_backup.go
index 290a31ba..06c2f43a 100644
--- a/cmd/restic/cmd_backup.go
+++ b/cmd/restic/cmd_backup.go
@@ -463,7 +463,7 @@ func runBackup(opts BackupOptions, gopts GlobalOptions, term *termstatus.Termina
        sc.Result = p.ReportTotal
        p.V("start scan on %v", targets)
-       t.Go(func() error { return sc.Scan(t.Context(gopts.ctx), targets) })
+       t.Go(func() error { time.Sleep(2 * time.Second); return sc.Scan(t.Context(gopts.ctx), targets) })
        arch := archiver.New(repo, targetFS, archiver.Options{})
        arch.SelectByName = selectByNameFilter

This will be resolved in #1991

@fd0  many thanks , it helped, you rock!

I have also been seeing this error with S3 as my backend, will give the binaries a try.

Seems to have done the trick 👍

There seems to be an error in the changelog; it says "Do not return an error when the scanner is faster than backup", but the detailed description implies the problem is when the backup is faster than the scanner.

Oh well, you're right. I'll correct it.


Generate license

@khatkar looks like what was needed was just to fix the setup.py:
https://github.com/plamere/spotipy/commit/48d04f343b99014822a87d6ec4965c6c921be8ac#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R35
➜ pip3 show spotipy
Name: spotipy
Version: 2.19.0
Summary: A light weight Python library for the Spotify Web API
Home-page: https://spotipy.readthedocs.org/
Author: @plamere
Author-email<EMAIL_ADDRESS>License: MIT
Location: /usr/local/lib/python3.9/site-packages
Requires: urllib3, requests, six
Required-by:


Fix failing ServerInUseHostPort test on MacOS

Signed-off-by: albertteoh<EMAIL_ADDRESS>
Which problem is this PR solving?

Master branch unit tests are failing on TestServerInUseHostPort, seemingly only for MacOS (okay for Linux builds).
IIUC, the reason for the test is to have test coverage of error handling code when listening on GRPC and HTTP ports. To achieve this, the test first listens on those same ports, then attempts to bind to those same ports again via the QueryService Start(); and expecting an error to be returned.
When running this test, no error is returned when binding to <IP_ADDRESS>:8080 while :8080 is bound, causing the assertion to fail. Interestingly, this behaviour differs between MacOS and Linux (at least on my Centos 8 VM).
From this, it appears that the Linux OS libraries are stricter than MacOS; the former considering the <IP_ADDRESS> address to be bindable to the loopback network interface.
Confirmed with the following simple program which I ran on both OSes:

package main

import (
     "fmt"
     "net"
 )

 const (
     hostname0 = ":8080"
     hostname1 = "<IP_ADDRESS>:8080"
 )

 func listen(hostname string) {
     fmt.Println("Listening to", hostname)
     if _, err := net.Listen("tcp", hostname); err != nil {
         fmt.Println(err.Error())
     }
 }

 func main() {
     listen(hostname0)
     listen(hostname1)
 }

...and here are the results:
MacOS
$ go run main.go
Listening to :8080
Listening to <IP_ADDRESS>:8080

Centos 8
$ go run main.go
Listening to :8080
Listening to <IP_ADDRESS>:8080
listen tcp <IP_ADDRESS>:8080: bind: address already in use

Short description of the changes

The fix involves explicitly providing the host IP (loopback in this case) in the host port string.
Add a stronger assertion on the error.
Have tried adding a MacOS job in Travis checks to prevent this from happening in future (there've been 2 MacOS specific unit test breakages in the last few weeks already), however, had some difficulties getting the Sarama unit tests to pass, and not sure why they're failing.

cc @rjs211

@yurishkuro are there any outstanding concerns that need addressing in this PR?


Running from pre-receive hook

Describe the bug
Running from pre-receive hook to scan the latest commit is failing with timeout even after adding the --timeout option.
To Reproduce
Add the gitleaks docker image in the github environment. Setup pre-receive hook to run on the gitleaks environment and scan the latest commit everytime.
Expected behavior
the scans should be completed and the leaks should be reported.
Screenshots

you can see the scan is failing even after adding the timeout with 3seconds
Basic Info (please complete the following information):

OS:
Gitleaks Version: 3.2.0 also happens to older version 2.0.1

cc @zricethezav

This has been fixed

Hi @sunilkarthy89    could you please share some inside how we can configure gitleaks as pre-receive hook


feat: add new profile finder method for chromium and firefox

Proposed changes

Checklist

[ ] Pull request is created against the dev branch
[ ] All checks passed (lint, unit, build tests etc.) with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

16 of 141 (11.35%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-4.3%) to 37.941%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

profile/filesystem.go
0
3
0.0%

profile/profile.go
0
34
0.0%

profile/finder.go
15
103
14.56%

Totals

Change from base Build<PHONE_NUMBER>7:
-4.3%

Covered Lines:
387

Relevant Lines:
1020

💛  - Coveralls


How did you get file 'candi_keyword.txt'?

You provide file 'src/preprocess/persona_process/convai2/candi_keyword.txt'.
It's seem that this file is the topic keyword.
How do you get file 'candi_keyword.txt'?
How do I build this file if I use code to work with other datasets?

We follow the preprocessing from a previous work, which uses a rule-based method and PMI measuring to get keywords:
https://github.com/squareRoot3/Target-Guided-Conversation


Create integration with Sqlite 3 Database

Feature

_Create integration with Sqlite 3 Database
_

Integration should be very simples
Checklist:

[x] Implement feature;
[x] Add tests;
[x] Update docstring;
[x] Update documentation.

To better understand

More detailed explanation of functionality.
Here you can explain the motivation for this task to be carried out.

Example

Some code examples and expected results.

connected to sqlite3 and create routes


Annotations in the crowdsourcing interface cannot overlap

The current implementation supports only mutually exclusive annotations.
However, for annotation set containing labels:

Incorrect
Interesting

One needs to annotate spans of text that quite often overlap.

In case someone wants to delve into this, here is the JS library used for the annotation process: https://github.com/SuLab/YPet .

We agree with @oplatek that we will not support overlapping annotations. It is a good practice to keep the labels independent of each other and not supporting it will allow us to keep the library conceptually simple.
We will describe our design choice in the documentation.


Insufficient funds for fee when using the "send all" button

The web wallet returns the following error to me when I use the "send all" button. isn't it already discounting it?

Thanks for the issue, and apologies for the delay in response.
I have submitted a PR that appears to fix this issue


Some package-lock.json entries are resolved from http sources

We want all of that to say https probably.

Doesn't seem to be true anymore.


Can't see "Open Variable Inspector" after installing the extension

I updated Jupyter lab to 2.1.4 from 1.2.6 to resolve this issue. Once I did that, I can't access the variable inspector anymore through the right click. I reverted back to 1.2.6 but still the issue persists.

I really appreciate if you can help.
Here is my env:
$ conda list | grep jupyter
jupyter                   1.0.0                    py37_7
jupyter_client            6.1.3                      py_0
jupyter_console           6.1.0                      py_0
jupyter_core              4.6.3                    py37_0
jupyterlab                1.2.6              pyhf63ae98_0
jupyterlab_server         1.1.4                      py_0
$ jupyter labextension list
JupyterLab v1.2.6
Known labextensions:
app dir: /Users/inas0003/opt/anaconda3/share/jupyter/lab
@jupyter-widgets/jupyterlab-manager v1.1.0  enabled  OK
@jupyterlab/debugger v0.1.2  enabled  OK
@lckr/jupyterlab_variableinspector v0.4.0  enabled  OK
Uninstalled core extensions:
@lckr/jupyterlab_variableinspector

I had same issue, this worked:
https://github.com/jupyterlab/jupyterlab/issues/8122


Added dom library to tsconfig compilerOptions

This resolves missing reference warnings when variables like window.location.pathname are used in index.svelte

Thanks for contributing!
also see CONTRIBUTING.md: gitmoji and Conventional Commits are recommended.


Dark mode theme draft

-Navbar logo and text colors will need to be changed, but site is much easier to read now

Closing for now until I add a button to switch modes and fix the navbar.


The Popover component accepts a placement prop, but the data-placement attribute is not completed based on this prop

The Popover component accepts a placement prop, but the data-placement attribute is not completed based on this prop. For example, if placement is set to bottom start, the data-placement attribute should also be bottom start (not only bottom) to facilitate better animations.

Hello  @mohammadhosseinmoradi :)
fix: #6825
Update the Popover component to set the data-placement attribute directly from the placement prop. Ensure your CSS or animations handle detailed placements like 'bottom start'.


Custom styles

I'm submitting a feature request
Hi,
First, thanks for your work, nice plugin.
Could you provide a way to customize the Google Map style ?
Actually you provide some predefined map styles, it's cool. But it will be better to allow to define a custom style.
Not necessary via the admin interface, but perhaps with a hook on your Util->get_styles() method.
Or by parsing another styles.json declared via a constant...
Thanks.

What about adding a textarea where user can paste his style json content ?

Perfect.

Here is how you can add your own styles along with pre-defined

<?php

// get more styles from - https://snazzymaps.com
// this should be is a valid json string
$my_own_style = '[{"featureType":"all","elementType":"geometry.fill","stylers":[{"visibility":"on"},{"saturation":"0"},{"weight":"0.01"},{"color":"#c3233a"}]},{"featureType":"all","elementType":"geometry.stroke","stylers":[{"color":"#ffffff"},{"visibility":"on"}]},{"featureType":"all","elementType":"labels","stylers":[{"visibility":"on"}]},{"featureType":"all","elementType":"labels.text.fill","stylers":[{"color":"#ffffff"},{"visibility":"on"}]},{"featureType":"all","elementType":"labels.text.stroke","stylers":[{"color":"#ffffff"},{"saturation":"0"},{"visibility":"off"}]},{"featureType":"all","elementType":"labels.icon","stylers":[{"visibility":"simplified"}]},{"featureType":"road","elementType":"geometry","stylers":[{"lightness":100},{"visibility":"simplified"}]},{"featureType":"road","elementType":"labels","stylers":[{"visibility":"off"}]}]';

add_filter('agm_custom_styles', function ($json) use ($my_own_style) {

    array_push($json, array(
        'id' => '81760',// make sure the id is unique among all styles in styles.json
        'name' => 'swingtime-map',
        'style' => json_decode($my_own_style, true)
    ));

    return $json;
});

Paste above code in your theme's functions.php
I planed to add textarea in future version.

thanks a lot.


Misleading native transports doc?

The native transports wiki page suggests using the os-maven-plugin maven plugin to configure the classifier of e.g. the netty-transport-native-epoll dependency.
But this will substitute the os name and arch based on the build environment, which would typically be arbitrary/variable (e.g. a CI platform, local workstation, ...). Whereas this is only really important for the target runtime environment.
Furthermore, only linux-x86_64 is supported for epoll, and so it seems to me the correct advice would be to have the <classifier> fixed to this wherever the dependency is included, regardless of the build/runtime envs. This is effectively what happens already when using netty-all.

@njhill want to do a PR ?

@normanmaurer AFAICT you can't do PRs for github wiki content, so I just edited that page directly. If there are any concerns/comments we can easily revert or update it, PTAL: https://github.com/netty/netty/wiki/Native-transports/_compare/3111bd83110138c5930666ccc948c39813847204...3692b87b30c6adc46c11c9e8d28762c303ca62d4

@normanmaurer updating the doc wiki doesn't appear to have updated the pages yet. Assuming you agree with the changes, is there something which needs to run to regenerate?

I will need to re-generate these... doing as we speak.


grammar-used activation hook regression

Prerequisites

[ ] Can you reproduce the problem in safe mode? N/A
[x] Are you running the latest version of Atom?
[x] Did you check the debugging guide?
[x] Did you check the FAQs on Discuss?
[x] Are you reporting to the correct repository?
[x] Did you perform a cursory search to see if your bug or enhancement is already reported?

Description
My package has a grammar-used activation hook, as per #8313 it is triggered on opening a new file but not on opening a previous session.
I have observed this working correctly at some point in an earlier version, but can't say how long ago.
Steps to Reproduce
(as per #8313)

Install language-purescript and ide-purescript
Open a file with .purs extension - observe package starts
Close atom
Re-open atom (so file is still open)

Expected behavior: [What you expected to happen]

Package is started

Actual behavior: [What actually happened]

Package does not start
Package can be observed to neither be started nor activated (via console.log on startup)
Opening a new file which was not already open will start the package as normal (but not switching to one of the existing files)

Versions
apm 1.10.0
atom 1.9.4 (also verified on 1.10.0-beta1)
OSX 10.9.4

I think this is showing up in thomasjo/atom-latex#200

Same issue in latex, packages not work with remember tabs. I think it's atom error, not package error

We hit this issue in Nuclide too- in a hastily move, I ended up removing all of the grammar-used activation hooks (facebook/nuclide@f413cbfc39341f7728767e8611d81fb960c16cd4) for Atom 1.9.0 compat.
I believe that what is going on is that activation hooks are only triggered when atom.workspace.openTextFile is used. When TextEditors are deserialized, they get created via a different code path that doesn't trigger the activation hooks.

/cc @robrix and @joshvera

I think this was introduced by https://github.com/atom/atom/pull/11603

This is fixed on master. The fix will be released in v1.9.8 and v1.10.0-beta5.


Interop with c++/cx

I was wondering if there's some good way of calling into rust code I've written with winrt-rust from, eg, a XAML control I wrote in C++?
Trivial interop I've already managed, but I'd like to be able to write, say, an IAsyncAction in rust that I can call from C++, and this has so far proved difficult.
Specifically, I wrote the following fairly trivial thing in Rust and compiled as a static library:
#[no_mangle]
pub extern fn test() -> HString {
    HString::new("Hello from rust!")
}

#[no_mangle]
pub extern fn do_async_stuff() -> ComPtr<IAsyncOperation<StorageFile>> {
    let uri = Uri::create_uri(FastHString::new("ms-appx:///Assets/file.txt").deref()).unwrap();
    StorageFile::get_file_from_application_uri_async(&uri).unwrap()
}

And in my C++ control I have
extern "C" {
    extern HSTRING test();
    extern WhatGoesHere? do_async_stuff();
}

MainPage::MainPage()
{
    InitializeComponent();
    this->TXT->Text = ref new String(test());
}

I' don't think it's possible to express the type needed in C terms, so I suppose I would have to get around that by using, say, a void pointer and re-interpret cast it. But to what? I assume the hat pointer types are not what's used on the Rust side...

This is an interesting use case that I haven't thought about before (actually, I haven't thought much about use cases of winrt-rust at all 😄 ).
Unfortunately I don't know much about C++/CX, so I'm not sure how the hat pointers (^) there look at the ABI level. This documentation suggests that they are ABI compatible with raw pointers, so it might be possible to just write ^IAsyncOperation<StorageFile> on the C++/CX side where you have ComPtr<IAsyncOperation<StorageFile>> (both are just *IAsyncOperation<StorageFile> with additional "magic"). So maybe this works out of the box?
You might also be able to use the new C++/WinRT projection (https://github.com/Microsoft/cppwinrt) instead of C++/CX, but this depends on what you want to do from the C++ side. GUI development is probably hard with C++/WinRT because there is no GUI designer yet as far as I know.

Interesting, it seems it does indeed work to just cast directly to the expected C++/CX types. It's a bit ugly, since the rust functions need to be declared in "C" on the C++-side, but it works. For reference, I now have:
Static rust lib
#[no_mangle]
pub extern fn do_async_stuff() -> ComPtr<IAsyncOperation<StorageFile>> {
    let uri = Uri::create_uri(FastHString::new("ms-appx:///Assets/file.txt").deref()).unwrap();
    StorageFile::get_file_from_application_uri_async(&uri).unwrap()
}

C++ "Universal application"
extern "C" {
    extern void* do_async_stuff();
}

MainPage::MainPage()
{
    InitializeComponent();

    auto temp = do_async_stuff();
    auto storageFileTask = reinterpret_cast<IAsyncOperation<Windows::Storage::StorageFile^>^>(temp);

    auto t = concurrency::create_task(storageFileTask);
    t.then([this](Windows::Storage::StorageFile^ file) {
        TXT->Text = file->FileType;
    });
}

And the XAML-defined TextBlock named TXT gets populated by the .filetype of the asset. Pretty cool.


398 Support optional "source" in /sensors/data [GET]

Allow to filter requests for sensor data by data source. Users can find out relevant source ids from chart tooltips.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 6 (83.33%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 64.975%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

flexmeasures/api/common/schemas/sensor_data.py
2
3
66.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
6587

Relevant Lines:
9518

💛  - Coveralls


Script aligns solar panels perpendicular to the sun

When the sun sets, the script stops aligning the solar panels as intended. But once the sun rises again and increases the power output to the hibernation limit, the script might turn into the wrong direction, causing the solar panels to stay perpendicular to the sun and not produce any power.

originally reported by sybersmoke on the Steam Workshop discussion

Closed due to no missing feedback from the reporter; assuming that ce5cf0d6 fixed the problem eventually.


bump the versions of wasm-bindgen and js-sys

Upping the versions of wasm-bindgen and js-sys to  0.2.92 and 0.3.69 respectively.

What exactly is the Motivation behind this?
The specified versions are already using the default notation, which is semver forward compatible.

I'm gonna go ahead and close this, but please feel free to leave a comment here.


[boost-modular-build-helper] Fixup mingw lib names

Describe the pull request

What does your PR fix?
Fixes building boost on mingw on windows, removing all tags from the static and import lib names (.a and .dll.a).
Almost the same is already implemented for .lib names.

Which triplets are supported/not supported?

This change looks good but I want to make sure it builds cleanly with https://github.com/microsoft/vcpkg/pull/20432

I pushed a merge with master to ensure  #20432 was applied and that rerunning generate-ports resulted in no additional changes.


The requestBody declared with $ref is not generating json_body

Describe the bug
If a requestBody is declared with a $ref, then no json_body property is generated. If the reference is inlined, then json_body is generated.
To Reproduce
Steps to reproduce the behaviour:

Example schema:

paths:
  "/objects":
    post:
      operationId: object_create
      requestBody:
        $ref: "#/components/requestBodies/Object"

generated API is:

def sync_detailed(
    *,
    client: Client,
) -> Response[Object]:
    """
    Returns:
        Response[Object]
    """

    kwargs = _get_kwargs(
        client=client,
    )

    response = httpx.request(
        verify=client.verify_ssl,
        **kwargs,
    )

    return _build_response(response=response)

Expected behavior
The expected API should be:
def sync_detailed(
    *,
    client: Client,
    json_body: Object,
) -> Response[Object]:
    """
    Args:
        json_body (Object):

    Returns:
        Response[Object]
    """

    kwargs = _get_kwargs(
        client=client,
        json_body=json_body,
    )

    response = httpx.request(
        verify=client.verify_ssl,
        **kwargs,
    )

    return _build_response(response=response)

OpenAPI Spec File
test.yaml

Hi I just submitted a PR above which works with your yaml. It'll be helpful if you have some time to review

hello, do you have an update on the ongoing PR? I'm facing the exact same issue :/

@Leemur89 This library seems not actively maintained. I recommend just using the official openapi generator

@kigawas are you sure? It just got a new release last week
Otherwise do you hav the link to the official openapi generator please? I've been using this one to generate custom python code and could not find a better one
(however I found a workaround to dereference my swagger file)

@Leemur89 The biggest problem is that it only supports Open API v3.0 partially and has no plan to upgrade, while fastapi has already swifted to 3.1. If some day I may have to change to use another library, I'd rather change it now.
https://github.com/openapi-generators/openapi-python-client/issues/585

@Leemur89 The biggest problem is that it only supports Open API v3.0 partially and has no plan to upgrade, while fastapi has already swifted to 3.1. If some day I may have to change to use another library, I'd rather change it now.

3.1 support is in progress in https://github.com/openapi-generators/openapi-python-client/pull/856 . I would categorize this project as "lightly maintained", I am still working on it but it's (mostly) only me and it's not my focus.

@dbanty Glad to hear you are working on this!


add validateBlockHeight function and tests

Current dependencies on/for this PR:

feature/proof-of-stake

PR #649

PR #686

PR #705

PR #706   👈

This comment was auto-generated by Graphite.


Support switching on/off at certain times

We usually have team members awake 24 hours a day able to respond to user messages in papercups.
However, at the moment, we don't!
We'd love the ability to edit the hours when papercups is on/off for situations when support is / is not available.

good idea @jamesefhawkins! this is similar to https://github.com/papercups-io/papercups/issues/95, correct?
would you like to completely hide the chat widget when it's "off", or just display a message indicating you aren't available?

I'd probably rather hide it completely so we don't disappoint people, but either way seems kind of valid.

got it, we can support both and let you choose whichever you prefer 👍 hoping to get to this by next week!

@jamesefhawkins out of curiosity, how "complicated" are your working hours?
e.g. is it something pretty straightforward like "weekdays from 9am-5pm", or is it more like "mondays from 10-6, tuesdays from 9-7, etc etc"?
(just trying to get a sense of how we should design this UX!)


Typo in the docstring in precision_recall_curve.py

There's a typo in the URL mentioned in the docstring.
Thanks!

Hi, I would like to contribute to this issue. I know it's just a typo, but it would be a good way to get involved with the community and learn more about how new PRs are handled.


Importing nltk on cgi-bin python webpage on localhost.

Hello,
I have a cgi-bin webpage. I use textblob in my python codes. When I run my website on localhost, I get the following error: "Resource u'tokenizers/punkt/english.pickle' not found.  Please
use the NLTK Downloader to obtain the resource:"
nltk.download('all'), or "python -m textblob.download_corpora" didn't solve my problem.
How can I fix this issue?
Thanks

Bump same issue, also there is another post about this same issue about ec2.


Color codes in git output

Description
Follow up of #379 , sort of.
#380 removed the ^D^H^H prefixes to "everything" on Linux for me (which is awesome)
On macOS, they're not quite gone yet. They've changed from ^D^H^H to ^D.
Neovim version
NVIM v0.8.0
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by<EMAIL_ADDRESS>Features: +acl +iconv +tui
See ":help feature-compile"
system vimrc file: "$VIM/sysinit.vim"
fall-back for $VIM: "/opt/homebrew/Cellar/neovim/0.8.0/share/nvim"
Operating system and version
macOS 13
Steps to reproduce

nvim -u minimal.lua in a git repo
:Neogit
observe ^D in unpulled, unmerged commits and at the start of the commit message on Head: and Push:

Expected behavior
No ^D characters
Actual behavior

Minimal config
vim.cmd([[set runtimepath=$VIMRUNTIME]])
vim.cmd([[set packpath=/tmp/nvim/site]])
local package_root = "/tmp/nvim/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
  require("packer").startup({
    {
      "wbthomason/packer.nvim",
      {
        "TimUntersberger/neogit",
        requires = {
          { "nvim-lua/plenary.nvim" },
          { "sindrets/diffview.nvim" },
        },
        config = function()
          print("loaded neogit")
          require("neogit").setup()
        end,
      },
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. "/plugin/packer_compiled.lua",
      display = { non_interactive = true },
    },
  })
end
if vim.fn.isdirectory(install_path) == 0 then
  print("Installing neogit and dependencies.")
  vim.fn.system({ "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path })
end
load_plugins()
require("packer").sync()

Hi! Could you test #388, please?


0.2.7 Archive for Bower still has 0.2.6 version.

Here is package.json content in https://github.com/Orange-OpenSource/angular-swagger-ui/releases/tag/0.2.7:
{
"name": "angular-swagger-ui",
"version": "0.2.6",
"dependencies": {},
"devDependencies": {
"glob": "^4.3.5",
"grunt": "^0.4.5",
"grunt-concurrent": "^1.0.0",
"grunt-contrib-clean": "^0.6.0",
"grunt-contrib-concat": "^0.5.0",
"grunt-contrib-connect": "^0.9.0",
"grunt-contrib-copy": "^0.7.0",
"grunt-contrib-jshint": "^0.11.0",
"grunt-contrib-less": "^1.0.0",
"grunt-contrib-uglify": "^0.9.2",
"grunt-contrib-watch": "^0.6.1",
"grunt-html2js": "^0.3.0",
"grunt-newer": "^1.1.0",
"jshint-stylish": "^1.0.0",
"load-grunt-tasks": "^3.0.0",
"matchdep": "^0.3.0",
"time-grunt": "^1.0.0"
},
"engines": {
"node": ">=0.10.0"
}
}

If you have a look at package.json in the repository the version is correct.
As this file is now ignored by bower you should delete folder bower_components/angular-swagger-ui and run bower update then everything should be ok


⚠ PrivateHD has degraded performance

In e40f5aa, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 1331 ms

Resolved: PrivateHD performance has improved in 041a052.


Requiring files that exist outside of the webpack root directory

Hello. I'm trying to write a webpack application that acts on a set of files that exist just outside of the directory where webpack lives. For example one of the require statements in 'index.js' webpack entry script refers to '../config.json'. Doing that gives me an error similar to the following:
ERROR in ./index.js
Module not found: Error: Cannot resolve 'file' or 'directory' ../config.js in /Users/frank-weindel/Documents/Working/Data Transition/Data Schema/webpack
 @ ./index.js 14:0-30

Relative to the webpack root, that file does in fact exist.
I've even tried it using absolute paths, but the same error occurs.
The reason I want to do it this is to keep the webpack application logically separated from the data its trying to use. This data (its a JSON schema) should live on its own.
Is this possible with webpack? Or is it purposefully restricting access to files outside its root?

@frank-weindel Is this relevant still?

Probably not. We haven't run into this problem in awhile


Update validations groups

Split the 'clean-undercloud' group into 'prep' and 'pre-introspection'
and update validations accordingly.

Cool! The check-network-gateway validation is miscategorized in the readme (commented inline), feel free to push after fixing it.


[Refactor](inverted index) refactor inverted index interface in tablet schema (#43003) (#43280)

pick from master #43003,#43280

run buildall


S3 gateway: browsing functionality + CLI availability

New functionality for the s3 gateway:
Bucket operations

[x] MakeBucket
[X] ListBuckets
[x] BucketExists
[x] RemoveBucket
[x] ListObjects

Object operations

[X] GetObject
[X] PutObject
[x] StatObject
[x] RemoveObject
[ ] RemoveObjects
[x] FPutObject
[x] FGetObject

Availability

[x] Runnable from the CLI via pachctl s3gateway
[ ] Runnable inside of pachd

Testing

[x] Integration w/ minio
[x] Conformance
[ ] Manual w/ s3cmd

This should be enough to get it to be mostly usable from minio and S3 CLI tools. It does not include a variety of more advanced functionality.

@jdoliner let me know if any of the functionality I've targeted shouldn't be added, or, oppositely, if there's functionality minio supports that we should add: https://docs.minio.io/docs/golang-client-api-reference.html

I was hoping to nix multipart uploads (FPutObject) because it doesn't map well onto PFS semantics. Unfortunately, it appears that minio implicitly does a multipart upload when the contents are over 64mb in size. I think this will need to be implemented (even if done hackily), because otherwise we won't support ingress of files over 64mb.

Results of the first conformance test run: 94 passed, 785 errored, 132 failed. Ouch.

Errors are now standardized to mostly match S3's. 111 tests now passing. I haven't looked yet, but am hoping there's some low hanging fruit to get the pass count up.

Heads-up: I'm exploring going back to combining the repo and branch into the bucket name in a separate branch, since the current scheme is understandably causing a huge percentage of the conformance test failures. This comes with a separate set of downsides, but it might be worthwhile. TBD.

@jdoliner Here's the next iteration of improvements, under active development: https://github.com/pachyderm/pachyderm/compare/s3-gateway-exposed...s3-gateway-conformance-2?expand=1
The largest change this has is going back to branch names as part of the bucket name. Bucket names are now repo-branch, with the shortcut repo referring to repo's master branch. I might tweak the separator to be something else, but overall it's a big improvement in the list bucket logic and conformance test passes. How about I merge that into branch?

@jdoliner I went ahead and merged those changes in, since I think it should make the overall review easier.
About ~20% of conformance tests are passing. Most (but not all) of the failures are as expected, because it's testing functionality that we don't intend to support. I'll make continued improvements towards conformance test passes in a separate PR that I'll open after this gets merged.
Once pachd integration is completed, this will be ready to review.

Definitely cool with merging that branch into here. I'm not sure how I feel about branch.repo as the naming scheme, is there a reason to do that over repo.branch? Having branch before repo feels weird to me since branches are subobjects of repos.

I'm glad you asked! There's several options we could go with, but they all come with trade-offs. Here's the reasoning that led me to the current scheme, but I'm curious what you think after this wall of text:
First, the general reason for using . as a separator is because it's the only character that's valid as part of a bucket name, and not valid as part of a repo name. I had somehow missed this the first go-round because I was looking at some bucket validation documentation that was even stricter than necessary. It's possible the use of . in a bucket name may cause issues for some S3 libs, but haven't come across that problem yet.
Second, the branch in front of the repo is for two reasons:

The S3 spec is geared towards hostname-based bucket resolution, i.e. <bucket>.s3.amazonaws.com, rather than path-based. So, when an API is using path-based resolution like ours, the first part of the path is a subdomain in some sense, where branch.repo would make more sense than repo.branch.
The conformance tests allow you to specify a prefix for bucket names, but not a suffix (see s3gateway.conf.) All sorts of tests are run, including fuzzing with randomly generated and very long bucket names. This setup allows me to keep the branch name fixed, but allow conformance tests to randomly generate repo names.

I see a few options, assuming you agree . is the right separator:

We could keep branch.repo.
We could switch to repo.branch, in which case conformance tests will randomly generate branches. It wouldn't be too much work for me to make this change and do a conformance test run pass if that still sounds good - unless you know of a reason why randomly generating branches might cause problems (e.g., are branch names more restrictive than repo names? Are there tighter length restrictions?)
At one point, I experimented also with making the branch part optional, and defaulting to master; so /repo/ would resolve to the master branch of repo. I could go back to this, but it adds some complexity that I wasn't sure was worthwhile.

It turns out, when running minio, it'll gracefully degrade FPutObject/FGetObject to use non-multipart operations IFF multipart-related endpoints return a NotImplemented code. I didn't observe this before because I was instead returning a standard 404, which minio didn't gracefully degrade on.
This means I can rip out multipart code, and it'll still work (at least for minio.) I'm inclined to do this since that's the meatiest code here, but the trade-off is that other s3 clients may not be smart enough to gracefully degrade.
I did also experiment with storing multipart contents on PFS on the s3-gateway-multipart-on-pfs branch, which I'll keep in case it's useful in the future. @jdoliner I know you suggested using the object store itself, but the ability to atomically commit multiple file changes was going to come in handy, so I tried that avenue first.

41% of tests passing now. Most of gains come from just skipping tests that use unsupported features, but there's some real improvements too; most notably, support for HTTP ETags. This is done by storing a metadata JSON file for each file. This litters the repo with a lot of metadata files, but it's the simplest solution. I can explore something more thorough at a later point.

All non-ignored tests are now passing, though there's still one error that pops up in conformance tests, as boto3 tests rely on bucket versioning when tearing everything down.
pachd integration is also done. However, when running integration tests against a pachd instance with port forwarding, the port forward seems to inevitably break, and tests can't finish. I'm not sure if this is a problem with the port forwarder or the s3gateway server yet.

@jdoliner this is ready for another pass. pachd integration is technically done, but issues unrelated to this PR make it not usable; namely, k8s' port forwarder is unreliable in the face of broken pipes. Progress on that issue is being tracked here.

I added some docs on how it works and s3gateway's peculiarities.
@jdoliner those docs should be helpful in getting a higher-level view, and to discover any other issues you'd like me to address before merging.
@JoeyZwicker could you review the docs changes?

Made a few docs suggestions, but none of them are blocking on the merge. Docs team can do them after the fact if needed

@JoeyZwicker I moved the API docs into the references section. Does that look good?


NLog - MessageTemplateParameter - IsReservedFormat

Moved MessageTemplate UnitTests into the MessageTemplates-namespace.

in what case would you like to use the IsReservedFormat?

in what case would you like to use the IsReservedFormat?

Was thinking that I wanted to help the Seq-engine. It wants to pass the parameters through its own custom formatter. So it wants to know if it is "$" or "@" or "l", but I also want to tell users they should not use the format-string together with string.Format.

@304NotModified If something should be changed, then please tell. Would prefer to have this included before nblumhardt does the testdrive with https://github.com/datalust/nlog-targets-seq

merged!


suggestion breaks on fast vi movement

If the user switches to vicmd and invokes a vi movement quickly enough (within the KEYTIMEOUT interval) the suggestion preview will disappear. One possible solution is to decrease KEYTIMEOUT but that introdoces problems with key bindings that consist of multiple keys (for example cc, iw or key bindings of the surrounding module). Is this a known problem?

The problem is caused by an optimization in widgets.zsh. The optimization avoids getting multiple suggestions if still keys are queued for processing. However, there is no guarantee that the last key will invoke the suggestion rendering process; in my case the last key is a vi movement and no suggestion is rendered at all. In my opinion, this optimization should be removed. What do you think?

That optimization was added as a fix for #219 (see PR #223). Ideally, we could find a way to solve this problem, while still supporting the fix for #219. If there's no way to satisfy both, I think we should add an option to disable this instead of removing it for everyone.

This was just fixed on develop with commit https://github.com/zsh-users/zsh-autosuggestions/commit/42f5a06f7f29007d91e37f85e1dc5a80f1b7c059
Will go out with the next release.


[BUG] Few Profile pictures load after page loads

A few profile pictures load after the page is loaded.. Even though it takes 1 second to load, it's slightly annoying. We should make it so that on page load, all images (EVERYTHING) is loaded, even if it means the page will take some time to load, in my opinion.

So should we add an Event listener that is triggered when the website is fully loaded?
What is your opinion?


创建日期格式化规则并增强规则单元测试验证方式

1、add rule "UseRightCaseForDateFormatRule"
2、extend TestFramework to enhance unit test ability

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.默研 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Support yarn require muscle memory

thefuck does work with yarn, but I found an edge case.
The following command was valid in npm but not yarn:
yarn require lodash

You're supposed to use yarn add for reasons. However, thefuck suggests remove and run.


Dependent pair deconstruction / construction issue

I cannot manage to write generic functions taking advantage of dependent pairs. Here is a snippet:
val id : (x:Type & x) -> (y:Type & y)
let id p = match p with
  | (|a, b|) -> (|a, b|)

It raises (Error 12) Expected type "y: Type & y"; but "(| a, b |)" has type "_: Type & a"
How to make it work? Is it a bug?

This is a sort of known issue.
This works:
let id (p:(x:Type & x)) :(y:Type & y) =
  match p with
  | (|a, b|) -> (| a, b |)

And this too:
val id : (x:Type u#a & x) -> (y:Type u#a & y)  //note the explicit universe annotations
let id p =
  match p with
  | (|a, b|) -> (| a, b |)

The problem is in the universe  generalization code. When F* type checks the val declaration in your example, it figures that id is polymorphic in two universes, which then makes the implementation of id type incorrect. So, F* "over-generalizes" the universes in the val declaration.
On the other hand providing explicit universe annotations on val or rather just write the let works since then F* can figure out that there is only a single universe to generalize.

#604.

Closing as duplicate


Request: Hide placeholder text in Manual Resolver

I think the placeholder text should be removed/hidden from the user when Manual Rolls is used to help prevent poor sportsmanship, as there is no indication if a die value is manually entered or left empty for the Foundry Roller to resolve
https://github.com/foundryvtt/unfulfilled-rolls/assets/86370342/fcacf8ee-254d-4060-b444-b1ae7a51eb74

Adding this to styles/unfulfilled-rolls.css seems to do the trick
#manual-resolver .terms .dice-term-input::placeholder {
  opacity:0;
}


extend-shallow is missing

Hi. extend-shallow is implicitly set by your package-lock.json. That leads to an error for users, that use npm in a version below 5.

fixed. thanks for the issue!


HDH-294-investigate-icons-on-sidebar

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: _Adding module logos in sidebar___________
Jira/GitHub Issue numbers (if any): _HDH 294_________________________
Preview links/images (Internal contributors only): _____

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[x] Successful preview build.
[x] Code owner review.
[x] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66a9a086c6bb863a4e661082--harness-developer.netlify.app


FormData file stream sends partial data

Summary
Hey, I'm passing a stream into formData and only seeing partial output.  I don't see the end of the multi part data boundary and the content length is cut down. I have ruled out connection timeouts and have reason to believe theres an underlying issue with Request for passing streams in formData. Any insight is much appreciated thanks!
Simplest Example to Reproduce
const response = await request({
  formData: { data: createReadStream() },
  method: 'POST',
  url: 'http://<IP_ADDRESS>:9995/upload',
})

What I'm getting:
-----------------
{ path: '/upload',
  headers:
   { host: '<IP_ADDRESS>:9995',
     'content-type': 'multipart/form-data; boundary=--------------------------211331766535096179762063',
     'content-length': '199',
     connection: 'close' },
  method: 'POST',
  body: '----------------------------211331766535096179762063\r\nContent-Disposition: form-data; name="data"\r\nContent-Type: application/octet-stream\r\n\r\n�PNG\r\n\u001a\n\u0000\u0000\u0000\rIHDR\u0000\u0000\u0002X\u0000\u0000\u0002X\b\u0006\u0000\u0000\u0000�f��\u0000\u0000 \u0000IDATx^��Ys$K���\u0002y���',
  cookies: undefined,
  fresh: false,
  hostname: '<IP_ADDRESS>',
  ip: '::ffff:<IP_ADDRESS>',
  ips: [],
  protocol: 'http',
  query: {},
  subdomains: [],
  xhr: false,
  os: { hostname: 'c6e460367831' } }
::ffff:<IP_ADDRESS> - - [23/Nov/2018:22:06:40 +0000] "POST /upload HTTP/1.1" 200 811 "-" "-"

Expected Behavior
curl -i -X POST -H "Content-Type: multipart/form-data" -F<EMAIL_ADDRESS>http://<IP_ADDRESS>:9995/

HTTP/1.1 100 Continue
HTTP/1.1 200 OK
X-Powered-By: Express
Content-Type: application/json; charset=utf-8
Content-Length: 211361
ETag: W/"339a1-1v8h14L6mGCfSU3d3RYgy9ui5hE"
Date: Fri, 23 Nov 2018 22:02:29 GMT
Connection: keep-alive

{
  "path": "/",
  "headers": {
    "host": "<IP_ADDRESS>:9995",
    "user-agent": "curl/7.54.0",
    "accept": "*/*",
    "content-length": "88941",
    "expect": "100-continue",
    "content-type": "multipart/form-data; boundary=------------------------3760353b704a9113"
  },
  "method": "POST",
  "body": "--------------------------3760353b704a9113\r\nContent-Disposition: form-data; name=\"data\"; filename=\"fitbit.JPG\"\r\nContent-Type: image/jpeg\r\n\{data...}\r\n--------------------------3760353b704a9113--\r\n",
  "fresh": false,
  "hostname": "<IP_ADDRESS>",
  "ip": "::ffff:<IP_ADDRESS>",
  "ips": [],
  "protocol": "http",
  "query": {},
  "subdomains": [],
  "xhr": false,
  "os": {
    "hostname": "c6e460367831"
  }
}

It seems like this works when knownLength is specified. It'd be great if that was not necessary.

not stale!

See https://github.com/form-data/form-data/pull/397#issuecomment-471976669


Difficulties loading pre-trained weights!

Hello!
Thank you very much for adding a code snippet to outline how to load pre-trained SpeechT5 weights, super helpful for understanding how to process the data and load the task 😊
I've been attempting to load the 'base' pre-trained weights according to the code snippet provided here:
import torch
from speecht5.tasks.speecht5 import SpeechT5Task
from speecht5.models.speecht5 import T5TransformerModel

checkpoint = torch.load('/path/to/speecht5_checkpoint')

checkpoint['cfg']['task'].t5_task = 'pretrain'
checkpoint['cfg']['task'].hubert_label_dir = "/path/to/hubert_label"
checkpoint['cfg']['task'].data = "/path/to/tsv_file"

task = SpeechT5Task.setup_task(checkpoint['cfg']['task'])
model = T5TransformerModel.build_model(checkpoint['cfg']['model'], task)
model.load_state_dict(checkpoint['model'])

Steps performed:

Downloaded the fine-tuned base checkpoint from https://github.com/microsoft/SpeechT5#pre-trained-models
Create a dummy dict of Hubert labels with using the instructions provided here with n_clusters=500:

for x in $(seq 0 $((n_clusters - 1))); do
  echo "$x 1"
done >> $lab_dir/dict.km.txt

Download the dummy text dictionary using the download link provided in @Ajyy 's previous issue response from the G Drive link. As outlined, the text dict should be placed under data and the Hubert labels under hubert_label_dir.
Using the Hubert labels and text dict, running the aforementioned code snippet to load the pre-trained model. Loading the task throws an error:

 Click for full traceback
task = SpeechT5Task.setup_task(checkpoint['cfg']['task'])

---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
File ~/SpeechT5/SpeechT5/fairseq/fairseq/data/dictionary.py:242, in Dictionary.add_from_file(self, f)
    241 try:
--> 242     line, field = line.rstrip().rsplit(" ", 1)
    243     if field == "#fairseq:overwrite":

ValueError: not enough values to unpack (expected 2, got 1)

During handling of the above exception, another exception occurred:

ValueError                                Traceback (most recent call last)
Input In [10], in <cell line: 1>()
----> 1 task = SpeechT5Task.setup_task(checkpoint['cfg']['task'])

File ~/SpeechT5/SpeechT5/speecht5/tasks/speecht5.py:301, in SpeechT5Task.setup_task(cls, args, **kwargs)
    299 if args.t5_task == "pretrain":
    300     dicts["hubert"] = [Dictionary.load(f"{args.hubert_label_dir}/dict.{label}.txt") for label in args.hubert_labels]
--> 301     dicts["text"] = Dictionary.load(op.join(args.data, "dict.txt"))
    302 else:
    303     if config is None:

File ~/SpeechT5/SpeechT5/fairseq/fairseq/data/dictionary.py:216, in Dictionary.load(cls, f)
    207 """Loads the dictionary from a text file with the format:
    208
    209 ```
   (...)
    213 ```
    214 """
    215 d = cls()
--> 216 d.add_from_file(f)
    217 return d

File ~/SpeechT5/SpeechT5/fairseq/fairseq/data/dictionary.py:227, in Dictionary.add_from_file(self, f)
    225 try:
    226     with open(PathManager.get_local_path(f), "r", encoding="utf-8") as fd:
--> 227         self.add_from_file(fd)
    228 except FileNotFoundError as fnfe:
    229     raise fnfe

File ~/SpeechT5/SpeechT5/fairseq/fairseq/data/dictionary.py:260, in Dictionary.add_from_file(self, f)
    258     self.add_symbol(word, n=count, overwrite=overwrite)
    259 except ValueError:
--> 260     raise ValueError(
    261         "Incorrect dictionary format, expected '<token> <cnt> [flags]'"
    262     )

ValueError: Incorrect dictionary format, expected '<token> <cnt> [flags]'

Do we need to add a flag column to the dummy text dict? I appended a column of zeros to the dummy text dict (giving token, count, 0). The task can then be loaded:
task = SpeechT5Task.setup_task(checkpoint['cfg']['task'])
Error with loading the weights:

model = T5TransformerModel.build_model(checkpoint['cfg']['model'], task)
model.load_state_dict(checkpoint['model'])

 Click for full traceback
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
Input In [17], in <cell line: 2>()
      1 model = T5TransformerModel.build_model(checkpoint['cfg']['model'], task)
----> 2 model.load_state_dict(checkpoint['model'])

File ~/SpeechT5/SpeechT5/speecht5/models/speecht5.py:1040, in T5TransformerModel.load_state_dict(self, state_dict, strict, model_cfg, args)
   1036     m_state_dict = {
   1037         key.replace(f"{m}.", ""): value for key, value in state_dict.items() if key.startswith(f"{m}.")
   1038     }
   1039     if hasattr(self, m):
-> 1040         self._modules[m].load_state_dict(m_state_dict, False)
   1041 return self

File ~/venv/lib/python3.8/site-packages/torch/nn/modules/module.py:1497, in Module.load_state_dict(self, state_dict, strict)
   1492         error_msgs.insert(
   1493             0, 'Missing key(s) in state_dict: {}. '.format(
   1494                 ', '.join('"{}"'.format(k) for k in missing_keys)))
   1496 if len(error_msgs) > 0:
-> 1497     raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
   1498                        self.__class__.__name__, "\n\t".join(error_msgs)))
   1499 return _IncompatibleKeys(missing_keys, unexpected_keys)

RuntimeError: Error(s) in loading state_dict for TransformerEncoder:
	size mismatch for proj.weight: copying a param with shape torch.Size([81, 768]) from checkpoint, the shape in current model is torch.Size([7, 768]).
	size mismatch for proj.bias: copying a param with shape torch.Size([81]) from checkpoint, the shape in current model is torch.Size([7]).

Would be very grateful to get some insight on these two questions:

Do we need to process the dummy text data in an additional way to add the 'flag' column?
Is the size mismatch error being thrown related to the saved PT checkpoint?

Many thanks for your help!

@sanchit-gandhi are you working on converting SpeechT5 to Huggingface ?


When using "Highlight Selected Connections" all connections are highlighted and not just the one connect to the node

Describe the bug
When you select a node everything connected to that node should be highlighted to indicate what is connected. When I a node now all the nodes connected are correct but all the lines are also highlighted so it is very hard to see what is connected to this node. Only the nodes connected to this node should be highlighted and everything else should be dimmed down.

The pink lines for example should be dimmed down.
Expected behavior
No response
Actual behavior
No response
How to Reproduce?
No response
Godot full version
4.2.1.stable
Orchestrator version
v2.0.rc2
Additional information
Instead of having this in the project settings would it be possible to chagne this to the toolbar for the graph so you can easy switch it on and off.

Ok, so I misunderstood the original request. I do think we can place it on the toolbar too, allowing for quick toggle access 👍


Improve JSON perfomance with jsoniter

Jsoniter algorithms better with marshalling and unmarshalling, so, why don't use them?

why don't use them?

While jsoniter may be a little faster, I've been meaning to remove the "encoding/json" dependency altogether.
I was only using it for encoding json strings that had unicode or needed escape characters.
I pushed an update moments ago that replace the need for the "encoding/json" or "jsoniter", and adds a new function AppendJSONString which converts a string to json and appends it to a byte slice.
It seems to be a little faster than both "encoding/json" and "jsoniter".
https://gist.github.com/tidwall/4bba4ee9473f810371046b8564d45e9d

Oops, seems like i didn't notice that commit, sorry ^_^
Glad to see dependency-free solution from you, thanks!


Help button does not work in Mac OX standalone

Should just need to update .spec files to be able to find the html.

I have fixed this locally, and will be making a new standalone release soon


Disclaimer in download

[x] edit: http://gis.ices.dk/geonetwork/srv/eng/catalog.search#/metadata/7a6151e4-812b-4455-97a2-74c5102d418f
[x] edit: (description on this link: http://datsu.ices.dk/web/selRep.aspx?Dataset=148)
[x] edit: Data provided from the website are classified as either 'Public' or 'Restricted':
[x] edit: better to move "Documentation can be found at https://esas-docs.ices.dk/" to section 3

I assume these are typos/suggestions for the disclaimer.txt file that is included in a download. @neil-ices-dk can you correct these or is this something for @cmspinto?

edit: (description on this link: http://datsu.ices.dk/web/selRep.aspx?Dataset=148)

the typo in the dataset name has been forwarded to the vocab management group for correcting

edit: (description on this link: http://datsu.ices.dk/web/selRep.aspx?Dataset=148)

do you want the description to be the full text from the landing page?
https://www.ices.dk/data/data-portals/Pages/European-Seabirds-at-sea.aspx

edit: better to move "Documentation can be found at https://esas-docs.ices.dk/" to section 3

this was previously moved from section 3 to gather the links in one section and a pointer made in section 3 to avoid repetition:
Information about the ESAS data and formats can be found in the links in section 7.

There are two links in section 3 already... so still preferring the https://esas-docs.ices.dk/ in section 3 as well.

Regarding the 2nd bullet, the link should only be between brackets:
The Download ZIP bundle includes the requested data file in the CSV format (description on this link:
http://datsu.ices.dk/web/selRep.aspx?Dataset=148), and the data disclaimer.
The Download ZIP bundle includes the requested data file in the CSV format (description on this link)
http://datsu.ices.dk/web/selRep.aspx?Dataset=148, and the data disclaimer.
...instead of...
The Download ZIP bundle includes the requested data file in the CSV format (description on this link:
http://datsu.ices.dk/web/selRep.aspx?Dataset=148), and the data disclaimer.

typo corrected in vocab; @nicolasvanermen it would be easier if you go and make the edits on the disclaimer yourself and then just ping Carlos who will upload the final version - thanks
https://github.com/ices-tools-dev/esas/blob/main/disclaimer-download

OK did so, the first commit gave some sort of warning though:

@nicolasvanermen you can ignore the warning you got: your next commit got a ✔ meaning that the website (https://esas-docs.ices.dk/) was built successfully.

@cmspinto to pull into the esas app

Disclaimer updated, could someone `have a look?

@cmspinto yes the disclaimer matches, there is one issue though in section 6

Additionally, if the download is predominantly from one or two data providers, please directly acknowledge the data source(s) when using the data:
XXXXXXXXXXXXXXXXXXXX

Where XXXX was supposed to be filled with the DataRightsHolder(s)

I have updated the disclaimer document at https://github.com/ices-tools-dev/esas/blob/main/disclaimer-download. Note that it includes a number of whitespace changes that I think make the text easier to read, so please replace the entire disclaimer.
I have also updated the citation sentence to:

A minimum citation would include the following:
European Seabirds At Sea (ESAS) (https://esas.ices.dk), 2022. ICES, Copenhagen
If the download is predominantly from one or two data providers, please acknowledge them directly as well.
The following data providers contributed to the download:
XXXXXXXXXXXXXXXXXXXX

I have a long history of misinterpreting this specific issue, but as far as I understand now XXXXXXXXX will be a tailored list of data providers included in the download, and this is what will be implemented. Correct me if I am wrong again...

but as far as I understand now XXXXXXXXX will be a tailored list of data providers included in the download

Yes, that is how I understood it too.

Haven't publish yet, will do tomorrow (28/10/2022) but the citation will look like this:

Disclaimer:

The current disclaimer in the download includes the institutes names, yet is not the same as the one reviewed by Peter: https://github.com/ices-tools-dev/esas/blob/main/disclaimer-download.
So parallel versions are circulating apparently...

Have updated the disclaimer to be this one: https://github.com/ices-tools-dev/esas/blob/main/disclaimer-download

Beautiful, closing this issue.


materialize website

Recently when going to the website i have the following error , i believe its something to do with the location of the jquery loading.
Failed to load resource: net::ERR_TOO_MANY_REDIRECTS
http://materializecss.com/bin/jquery-2.1.1.min.js Failed to load resource: the server responded with a status of 404 (Not Found)
I would think google CDN would be good for this.

This should only happen if you are not connected to the internet.


Missing Typings with OmitApi with external client

Bug description
If I try to initialize a global prisma client by specifying the omitConfig first, then the types do not autocomplete.
I need to specify the config outside the actual client because I dont want to have to keep specifying what stuff is being omitted more than once when making my client(s)
How to reproduce

Expected behavior
I should specify what I want to omit once, and use that information both for getting types and for actually making the client
Prisma information

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

generator client {
  provider        = "prisma-client-js"
  previewFeatures = ["omitApi"]
}

model User {
  id        Int      @id @default(autoincrement())
  createdAt DateTime @default(now())
  updatedAt DateTime @updatedAt
  email     String   @unique
  name      String
  age       Int
  country   String
  role      Role     @default(USER)
  posts     Post[]
  profile   Profile?
}

model Post {
  id        Int      @id @default(autoincrement())
  createdAt DateTime @default(now())
  updatedAt DateTime @updatedAt
  title     String
  content   String?
  published Boolean  @default(false)
  authorId  Int
  author    User     @relation(fields: [authorId], references: [id])
}

model Profile {
  id     Int    @id @default(autoincrement())
  bio    String?
  userId Int    @unique
  user   User   @relation(fields: [userId], references: [id])
}

enum Role {
  USER
  ADMIN
}

import { PrismaClient } from "@prisma/client";

const omitConfig = {
  user: {
    id: true,
  },
}

declare global {
  var prisma: PrismaClient<{ omit: typeof omitConfig }>;
}

const _prisma = global.prisma || new PrismaClient({
  datasourceUrl: process.env.DATABASE_URL,
  omit: omitConfig
});

if (process.env.NODE_ENV === "development") global.prisma = prisma;

async function check() {
  const user = await prisma.user.findFirstOrThrow({})
  let y = user.id  // this should have errored saying property 'id' does not exist on type
}

Environment & setup

OS: macOS
Database: PostgreSQL
Node.js version: 22.3

Prisma Version
prisma                  : 5.16.1
@prisma/client          : 5.16.1
Computed binaryTarget   : debian-openssl-1.1.x
Operating System        : linux
Architecture            : x64
Node.js                 : v22.3.0
Query Engine (Node-API) : libquery-engine 34ace0eb2704183d2c05b60b52fba5c43c13f303 (at<EMAIL_ADDRESS>Schema Engine           : schema-engine-cli 34ace0eb2704183d2c05b60b52fba5c43c13f303 (at<EMAIL_ADDRESS>Schema Wasm             : @prisma/prisma-schema-wasm 5.16.0-24.34ace0eb2704183d2c05b60b52fba5c43c13f303
Default Engines Hash    : 34ace0eb2704183d2c05b60b52fba5c43c13f303
Studio                  : 0.502.0
Preview Features        : fullTextSearch, views, relationJoins, omitApi

Hi @khalilsarwari.
In that case, it's actually not a prisma problem, but TS inference problem.
In you example. inferred type for omitConfig is { user: { id: boolean } }, so when you use it as a generic argument for PrismaClient, we don't know if it's value is gonna be true or false and therefore can not omit the field. What we need is the type to be  { user: { id: true } }. This happens automatically if you inline omit config into the constructor, but if you are splitting it up into separate variable, you'd need to force TS to be more strict. You can do so by adding as const to variable declaration, like this:
const omitConfig = {
  user: {
    id: true,
  },
} as const;

Hope that helps! Since there is no issue for Prisma here, I am going to close the issue. Feel free to comment if the fix does not work for you.

Thank you for sharing the fix, and for explaining it - my issue is fixed!


[Bug]:  API when binded to a table does not dispaly the API in Table Data of property pane

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When user binds an API to a table it is observed that the Table data of property pane remains empty
Steps To Reproduce

Create an API
Run the. API
Create a Binding to a table
observe user is navigated to Canvas
Observe the property pane of Table
Table data field remains empty

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
cloud

Seems to be on the master as well hence lowering the priority


Support for the exclude option

Isn't this redundant? tmp_options is a clone of requirejs_options, so it should already have this property. I'm trying to resolve a conflict with #9 and can't decide whether to keep this or not.

Actually, instead of listing one by one options, an array with options related to a path should be defined and loop on it to harmonized the path. The readme is also outdated, I'm fixing it.


Markdown fix for CHANGELOG

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fixes redis socket connections

Adds tests and changes the code slightly. This is essentially the same issue with dj-database-url in: https://github.com/kennethreitz/dj-database-url/pull/73
I needed a way to support unix sockets, please review and merge.

@dstufft bump


Import Issues

I'm currently working with the Aurelia framework which uses Systemjs as the module loader. In the config.js for Systemjs, I'm able to configure aliases for paths, which of course do not resolve in Atom. I would like the ability to either reference paths again or create an alias for the path so that it resolves properly.
Is there a reason the /// reference does not work anymore? Sometimes I just need to import the typing from another file (that's not a d.ts), but don't actually need to import the class directly.
Example
class SpecialClass {
  constructor() {
    // do some stuff
  }
}

I would just reference here
class MyOtherClass {
  constructor(store: SpecialClass) {
    // Do stuff
  }
}

If I use import {SpecialClass} from 'specialclassfile' it will insert var SpecialClass = require('specialclassfile') which is the expected behavior, however I only want to reference the file for type information.
Thanks in advance.

It seems like this is a bigger issue then I thought it was. @cmichaelgraham and I were trying to figure a way around my issue and decided to go the route of enabling "declarations": true in the tsconfig file.
What I ended up discovering is my declaration file added the following lines, in order to support the types I was using.
import { Page } from 'helpers/page';
import { Message } from '../elements/message/message-view';

interface CommanderData {
    sock: Socket;
    chatView: Chat;
}

I then proceeded to use my CommanderData interface, however it kept telling me the name was not found. I decided to manually go through the auto-generated definition code piece by piece, until I discovered that commenting out the import statements allowed the CommanderData interface to be used globally.
Conclusion... Import statements break definition discovery, at least in this specific case. If you need more information, let me know.

The following is my line by line analysis of your message. The final outcome : by design, needs work in the compiler :)

Is there a reason the /// reference does not work anymore

They should still work.

however I only want to reference the file for type information.

FWIW If the file is an external module i.e. has a root level import / export then it cannot be ///referenced

Here was the auto-generated declarations file

Yup, you can see you have root level import / export (import { Message } from 'elements/message/message-view';
export ). Such files cannot be ///ref`ed. This is in the design of the compiler.

Import statements break definition discovery, at least in this specific case. If you need more information, let me know.

Sorry, by design. The plan forward is (https://github.com/Microsoft/TypeScript/issues/2338) you should be able to import/require such .d.ts files and these .d.ts files should live right next to the actual .js files. That way the compiler reads .d.ts and the runtime reads .js. Unfortunately I haven't had the time to help out implementing 2338.

Thanks, I'll keep watch of this.


Handle NaN periodogram power

The code stays in an infinite loop when a large vector on NaN values are given
Converting those to 0 seems to do the trick to avoid the infinite loop.
Details are mentioned  at: https://github.com/welch/seasonal/issues/9

Thanks for the PR!
Do you have an example in which a NaN is produced for non-NaN input?
Else, poor form to quietly accept and squash a NaN, I'd rather leave things
as they are.

This example is produced when I gave an nan input to fit_seasons
I don't know how exactly these powers should be calculated. Its understandable not wanting the change the Nan's to zeros.
But in that case I think an exception should be thrown or it should just return None. Or you think that input shouldn't be a NaN under any circumstance. There can be an assertion (but seems like it can be)
Because being stuck in an infinite loop that eventually eats up the memory is one of the worst consequences. Because in that case you don't even know why it happened.
In my case the NaN values were not given by choice but was a consequence of the re-sampling of an unexpected input.
I am closing the PR perhaps you can find and implement the more suitable solution according to the structure of the module.


Recover Conversion Functions from Pipeline Resources for backwards compatibility

Changes

When we reverted removal of PipelineResources related fields,
we did not recover the conversion functions. As a result, when migrating
Tekton Chains to watch v1 objects, we run into Issue https://github.com/tektoncd/pipeline/issues/7105.
This PR recovers the conversion functions so that we can continue to convert PipelineResources related fields. It addresses issue  https://github.com/tektoncd/pipeline/issues/7105.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
Recover Conversion Functions from Pipeline Resources for backwards compatibility

/kind bug

/assign @wlynch

/approve


cuRAND fails when generating an odd number of values

Apparently this is all expected according to their documentation. This crate should find away around this short coming of their host api.

maybe generate ((n + 1) / 2) * 2 number then?
if the number is even, then n = 2m => ((2m + 1) / 2) * 2 = m * 2 = 2m
if the number is odd,  then n = 2m + 1 => ((2m + 1 + 1) / 2) * 2 = (m + 1) * 2 = 2m + 2 (even)
or just use if then else?

Okay I tried some different logic for if the number of values is odd, but got some weird alignment errors.
A really hacky way I might move forward with is to ALWAYS allocate an even number of values. So in the case where you have an array with an odd number of values, there would be an extra value hanging out at the end unused to round it out.

so basically generate if n is odd, then generate n + 1 numbers and truncate the vec length (didn’t find the location in the code, so not sure what the output is). but i’d say that that’s a good solution

Yeah exactly - will probably want to add fn malloc_async_even to result.rs (https://github.com/coreylowman/cudarc/blob/main/src/driver/result.rs#L266), and then move to using that here https://github.com/coreylowman/cudarc/blob/main/src/cudarc.rs#L228

ok - do you think it's worth for me to look into the code, because i understand basically nothing 😅

If you have time and interest, sure! I can help review code or answer questions.

ok thx! i'll have a look at it in the next few days. any recommendations of what to read before/where to start with?

Relevant CUDA documentation:

cuRAND host api overview: https://docs.nvidia.com/cuda/curand/host-api-overview.html#host-api-overview
cuRAND host api docs: https://docs.nvidia.com/cuda/curand/group__HOST.html#group__HOST
CUDA Driver api allocation function: https://docs.nvidia.com/cuda/cuda-driver-api/group__CUDA__MALLOC__ASYNC.html#group__CUDA__MALLOC__ASYNC_1g13413273e84a641bce1929eae9e6501f

The functions that have a requirement on even number of values are the log normal & normal generation functions:

curandGenerateLogNormal
curandGenerateLogNormalDouble
curandGenerateNormal
curandGenerateNormalDouble

I.e. they all say:

CURAND_STATUS_LENGTH_NOT_MULTIPLE if the number of output samples is not a multiple of the quasirandom dimension, or is not a multiple of two for pseudorandom generators

ok thanks, i'll have a look into this

ok, i (finally) installed everything

A simple solution would be
pub type Array<N, const A: usize> = [N; (A + 1) / 2 * 2];
instead of
[N; A]

@M1ngXU i'm actually thinking that we won't use cuda rng apis to start with for dfdx. Notably, all random numbers with be generated on CPU and then copied to GPU. while this isn't as efficient as possible it enables reproducibility across both cpu & cuda. this will make testing a breeze, and we don't have to worry about things like this bug.

@M1ngXU i'm actually thinking that we won't use cuda rng apis to start with for dfdx. Notably, all random numbers with be generated on CPU and then copied to GPU. while this isn't as efficient as possible it enables reproducibility across both cpu & cuda. this will make testing a breeze, and we don't have to worry about things like this bug.

ok, and since generating rng is done once, not much time should be lost

Won't fix this bug since it's with the underlying library, and as stated we won't even be using cuRAND.


Extracting value from key:value pair on a secret path

Hi there,
I'm just having a play with this module and trying to figure out how to get a value from a key within a secret path.
Example : I have a key:value called testuser:testpass1234 under the secret/mysecrets/secret1 path.
While I can do this successfully:
get-secret -name mysecrets/secret1 -Vault secret

UserName                          Password
--------                          --------
mysecrets/secret1 System.Security.SecureString

I'm unable to access the value of testuser underneath this path:
get-secret -name mysecrets/secret1/test -Vault secret
It just bombs out with the following error :
Get-Secret : Unable to get secret sysadmin/Temp/test from vault secret
At line:1 char:1
+ Get-Secret -Vault secret
+ ~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (Microsoft.Power...sionVaultModule:ExtensionVaultModule) [Get-Secret], PSInvalidOperationException
    + FullyQualifiedErrorId : GetSecretInvalidOperation,Microsoft.PowerShell.SecretManagement.GetSecretCommand

Get-Secret : The secret mysecrets/secret1/test was not found.
At line:1 char:1
+ Get-Secret -Vault secret
+ ~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (Microsoft.Power...etSecretCommand:GetSecretCommand) [Get-Secret], ItemNotFoundException
    + FullyQualifiedErrorId : GetSecretNotFound,Microsoft.PowerShell.SecretManagement.GetSecretCommand

In comparison, using native vault command I could definitely extract the key:value pair like so:
vault kv get -version=1 secret/mysecrets/secret1/test

==== Data ====
Key                             Value
---                               -----
testuser                       testpass1234

How do I go about extracting the same info using your module?
Or am I using it the wrong way?
I'm using kv1 engine.
Nice work btw :)
Thanks
J

1st off, thanks for submitting an issue and using the extension!
A few quick question so I can look into it:
What version of PowerShell are you using ($psversiontable)?
What version of SecretManagement are you using?
Or are you loading this module directly into your PowerShell session?
I have a branch I have been sitting on for some GA changes, so will include this fix if I can.

Hi Josh,
Here are the details :
$PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.19041.906
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.906
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

The version of SecretManagement and SecretStore are 1.0.0 and 1.0.2 respectively.
Thanks!
J

I am trying to re-create this and understand the situation a little bit more.
This is what I initially had:

This is what I think you setup, correct?

I can retrieve secrets from both locations.

The design of the extension might not be optimal for most Hashicorp Vault use right now. The current output type I am returning is a PSCredential, but maybe a better output type would be a hashtable. That way you can use the custom key/value under the path.

@szahri  Please checkout the new Preview Branch . This now includes the default output of a Hashtable, which might help with part of the problem.
Example usage below:

@szahri Were you able to test the new version?

Hi Joshua
Just testet the preview relese and this is working perfectly! Both ways, reading and writing secrets btw.
Thanks for all the work on this module, consuming HC Vault is extremely comfortable on windows powershell systems with this.
Cheers,
Rob

This issue should now be resolved. Please open another issue if you have any further problems with this functionality.


spirv-opt: Eliminate Dead Input Components Pass

This adds the --eliminate-dead-input-components pass which currently
removes trailing unused components from input arrays.
Fixes #4532

@dneto0 I have addressed all of your concerns so far and have added regression tests and moved this out of WIP status. Please let me know if you have any other concerns or would like anyone else to review.

@dneto0 Ping :)

@diego Is David available to finish this? If not, could you please have someone finish the review? Thanks!

@s-perron @jaebaek Is there someone who can please finish this review?


Lets add a screenBackgroundColor as a prop in navigatorStyle

By default the view backgroundColor is white. This produces a white flickering for some of us when using dark backgroundColor for the Screen View, because when we use navigator.push, a new RootView is created and React styles applies not directly. So what happens is the following:

Navigator takes the registered component
Create a new ReactView, which has by default backgroundColor white!
Applies the navigation

React styles will get applied

This commit adds a new navigatorStyle property screenBackgroundColor, which will get applied directly to the view as the backgroundColor, before React applies the backgroundColor from the actual styles.

Hi, we wanted to update you that we are currently postponing the processing of pull requests.
Please refer to React native controllers evolution, we'll appreciate your feedback.


More clear error message in dashboard

Now when the actor call fails, the error returned in the response is a stacktrace, so we show an error in the frontend and the logs page shows the stacktrace of the error.


simplify pull request template

This PR proposes some simplifications to the pull request template.
I believe it'll make contributing a bit less intimidating for beginners, and reduce the amount of boilerplate text that has to be read by maintainers reviewing PRs.
Changes
I'll leave inline comments explaining each proposed change.
Testing
N/A
Notes
N/A
Checklist

[x] PR has an informative and human-readable title (this will be pulled into the release notes)
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
[x] Passes all existing automated tests
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future TODOs are captured in comments
[x] Project documentation has been updated if adding/changing functionality.
[x] Reviewers requested with the Reviewers tool :arrow_right:

Ok I'm done adding notes. Thanks very much for considering this!


Undo doesn't work after saving

The undo function which on most editors have history of up to 100 undo even after saving a file. But this doesn't seem to be the case on brackets... Any fix?

There's an hotfix tracking here: https://github.com/adobe/brackets/issues/11826#issuecomment-177135304

Closing duplicate.
Fix coming next release.


Automatically regenerate IDE integration steps

Initially posted this as a question in the Slack and was encouraged to convert it to an issue here.
The docs have a clear section on how to set up some basic IDE integrations (with VSCode, in my case):
First party deps:
ROOTS=$(pants roots)
python3 -c "print('PYTHONPATH=./' + ':./'.join('''${ROOTS}'''.replace(' ', '\\ ').split('\n')) + ':\$PYTHONPATH')" > .env

Third party deps:
pants export --py-resolve-format=symlinked_immutable_virtualenv --resolve=python-default

It would be nice to rerun these steps automatically when either a source is changed (for first party deps) or a 3rd party dependency is changed.

Yep, this is a great idea - could be done pretty reasonably as part of some post-pants.toml change hooks that the plugin already needs to have.
Ideally could be back ported into pants.


Add functions

I'm really sorry for being such a NN but I don't know how to paste the tutorials on youtube are all with a different source if I'm right. I already have the code for what I'm trying to add could someone link me a tutorial or something please. Any help is welcome thank you! <3

What do you want to add?

1, Do you know what nn mean?
2, What is it you wanna add?

I wouldn't suggest even trying to paste new features into osiris, for even if you have prior programming knowledge, pasting is still a bit of work.
For instance if you want to paste, say, a different anti-aim from a different source, then you'd have to adjust the names of the functions inside that bit of code to the ones existing in osiris; and well, if osiris doesn't have the functions needed for it, you're either gonna have to paste them too or make them yourself.
If you dont know what you're doing, you're not gonna get anywhere trying to paste.

pasting takes no effort other than searching inside your base. everything is already there and you aren't reversing things in IDA.
the code is already there so you don't even need to think of the flow or variable management.

This isn't really the place for asking for someone to help you paste someone else's work into your source. If you aren't entirely sure on how to get the code you have into this source, I would recommend watching some C++ tutorials and familiarizing yourself with the Osiris framework before continuing. I can say this is one of the nicest frameworks I've seen on Github, so it shouldn't be too difficult to learn your way around the source.

learncpp.com

Okay thank y'all for the "support", I'll just look for some c++ tutorials as joshcancode mentioned and look on the website posted by xpossed-you. Thanks!

Okay thank y'all for the "support", I'll just look for some c++ tutorials as joshcancode mentioned and look on the website posted by xpossed-you. Thanks!

Good! You're already doing better than 99% of the pasting community. Dedicating to learning C++ before hopping into this is a huge step to making better software. I wasn't trying to sound rude earlier, I'm just very stern with people who want to paste without any knowledge. Glad you're putting in some effort before starting.

Okay thank y'all for the "support", I'll just look for some c++ tutorials as joshcancode mentioned and look on the website posted by xpossed-you. Thanks!

see learning is better than pasting. thank you back


delete _alt jsons when the setting is disabled

less confusing

i dont think im gonna do this i changed my mind


Backend MVP

What?
Pull request to add a Minimum Viable Product for the Hotel Services backend API, according to the specifications.
For this MVP the following tasks were done:

[x] Specify and document the requests and responses handled by the API, see the documentation
[x] Design a database for persisting the data, see the ERD.
[x] Add configuration for allowing CORS and routing the requests.
[x] Add models and migrations for database entities.
[x] Add models validations.
[x] Add controllers.
[x] Add tests.
[x] Add seeds to easily interact with the frontend during development.

For the corresponding MVP pull request of the frontend of this app, see here.
For more details on the implementation of each task, see the messages of the closed Pull Requests labeled as MVP 1.

I believe I have reviewed this PR already. So I invalidated the review request since no changes were made. IT seems like you have some issues with creating services and recommendations, please double check this. If you need further assistance you are free to reach out to me personal and I'd be glad to trouble shoot with you

I believe I have reviewed this PR already. So I invalidated the review request since no changes were made. IT seems like you have some issues with creating services and recommendations, please double check this. If you need further assistance you are free to reach out to me personal and I'd be glad to trouble shoot with you

Note for the next reviewer:
The backend of this project had no changes since the first review, but there are lots of improvements on the frontend. Please, review them.


@neodx/svg support ignore path for replace color

Hello, Sometimes we have a color icons like a social network, how to ignore it in vite plugin?

Unfortunately, #91 isn't supported yet, but I plan to start working on it in about a week.

Done under #109


react-gtm-module not posting events to GA4 in Chrome

Chrome Version: 108.0.5359.124
Package Version: 2.0.11
Problem:
We seem to not be getting events passed in to GA on chromium based applications. In Firefox the GTM events get funneled to GA correctly, so it doesn't seem to be configuration on our end.
Our application is a Microsoft Teams based application, so is hosted through an iframe on their app, which we don't control that iframe, which also might be an issue, however again this works in firefox.
With GA Debug: ON we see the events trying to be pushed and then we get
Generated new client id: <redacted>
js?id=G-57Z8TEKTRK&l=dataLayer&cx=c:180 No session cookie found. Generating fresh session object.
js?id=G-57Z8TEKTRK&l=dataLayer&cx=c:180 Event processing aborted during storage.

As well as warnings saying GA couldn't update the session cookies. This seems to be only affecting chromium based browsers as far as we can tell, but since Teams uses Chromium based on Mac, we are also not seeing it in client.
Any thoughts?

@devinwalter My workaround was setting the following on the GA4 configuration Tag in GTM as "Fields To Set":
Field Name: cookie_flags
Field Values: samesite=none;secure
I believe the issue, particularly with iFrames (I have a similar use case) is that when setting cookies, GA will use the window's domain, not the iframe's so the cookies are considered Third Party, not First Party . Since Chrome uses "Lax" now instead of "None" as the default value for samesite, the cookies aren't able to be set/updated.
I actually had the same issue with this for UA, so it's a browser issue not the package I think.

@codal-matthew-fung that was a tough issue to solve, thank you for taking the time to share.
I have the exact same scenario as you, embeded react component in an iframe, using react-gtm and getting that error.


fix: take KUBECONFIG env variable into consideration

Closes #331
📑 Description

Before, the default value set for the --kubeconfig flag prevented the
KUBECONFIG env variable to be ever taken into consideration. This
behavior has now been fixed.
If --kubeconfig flag is set, it takes precedence over the KUBECONFIG env
variable.
✅ Checks

[x] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[x] All the tests have passed

ℹ Additional Information

Mhmm to really test it, we would need some kind of end to end testing I guess. In general,
this would sound like a good thing to implement imho.
Tbh I would create a ticket for it though, as this needs some more thought put into it :slightly_smiling_face:


Add new parameter set to Get-ClrStack

It would be great if Get-ClrStack will be able to accept instances of MS.Dbg.DbgThreadContainer as an input so it will be able to use in the pipeline.
PS Dbg:\NetDebugDemos_16124\Threads
> Get-ChildItem | Get-ClrStack

Thanks for filing these. There is whole bunch of improvement that needs to happen for managed code support, and it's great to have some very specific items that we can track.


go/src: all.bash not picking up changes in go/src/cmd/go/testdata/script directory

What version of Go are you using (go version)?

$ go version
go version devel +b7a85e0003 linux/amd64

Does this issue reproduce with the latest release?
Yes. I pulled the most recent version of Go master branch.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/usr/local/google/home/zpavlinovic/.cache/go-build"
GOENV="/usr/local/google/home/zpavlinovic/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/usr/local/google/home/zpavlinovic/go/pkg/mod"
GONOPROXY="*.git.corp.google.com"
GONOSUMDB="*.git.corp.google.com"
GOOS="linux"
GOPATH="/usr/local/google/home/zpavlinovic/go"
GOPRIVATE="*.git.corp.google.com"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/google/home/zpavlinovic/golang-dev/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/google/home/zpavlinovic/golang-dev/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="devel +b7a85e0003"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/usr/local/google/home/zpavlinovic/golang-dev/go/src/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build2036562605=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Build and test again go/src$ ./all.bash

What did you expect to see?
Based on instructions in Contribution Guide, failure along the lines of
go test proxy running at GOPROXY=http://<IP_ADDRESS>:46381/mod
--- FAIL: TestScript (0.01s)
    --- FAIL: TestScript/test_vet (4.10s)
        script_test.go:252:
            # Test file (1.304s)
            # Non-test file (1.315s)
            # Test issue #22890 (0.487s)
            # Test with ... (0.866s)
            > ! go test ./vetfail/...
            [stdout]
            ok          m/vetfail/p2    0.023s
            [stderr]
            # m/vetfail/p1
            vetfail/p1/p1.go:1:1: invalid non-alphanumeric build constraint: !foo-bar
            vetfail/p1/p1.go:8:2: Printf format %d has arg "hello" of wrong type string
            [exit status 2]
            > stderr 'Printf format %d'
            > stdout '^WRONGPREFIXok\s+m/vetfail/p2'
            FAIL: testdata/script/test_vet.txt:26: no match for `(?m)^WRONGPREFIXok\s+m/vetfail/p2` found in stdout

FAIL
exit status 1
FAIL    cmd/go  61.526s

This failure can be reproduced by running go test -run TestScript in go/src/cmd/go (after setting the GOROOT properly; see output of go env above).
What did you see instead?
Success.
...

My GOROOT is set to src/go. go env above shows it. I've set it up this way so go test can pick up the changes; otherwise, it does not.

With GOROOT="/usr/lib/google-golang", I got success again
...
ALL TESTS PASSED
...

I wonder if that is what we want here. At the very least, I would expect such tests to be run by continuous integration: https://go-review.googlesource.com/c/go/+/341735.

The longtest builders do run these tests, but they aren't run by default in TryBots (presubmit builds) to shorten turnaround time and save CPU. You can opt into them with SlowBots, for example, by adding TRY=linux-amd64-longtest when running TryBots.
Longtest builders do run regularly after changes are merged. https://build.golang.org/ shows their status.

So, in summary

all.bash does not run all tests, only short ones
longtests including script tests are run only by SlowBots by the CI system if explicitly specified
longtests including script tests are run periodically after merging

I understand the need for this setup, so I am not suggesting something should necessarily be changed there. However, I wonder if documentation can updated. If someone is, say, changing flags for commands, these script tests will likely be needed. With no documentation, potential bugs can creep into the repo and only discovered later after the fact.

All correct. And bugs creeping in post-merge, only visible on the build.golang.org dashboard does happen.
I'll close this issue since it's not a bug per so, but I'd encourage you to bring this up on the golang-dev mailing list for discussion with a wider audience.
Documentation would help, but there are a lot of moving parts here, and there should be some discussion about where it should live so it's discoverable.