Map preview should indicate when map can't be displayed

Map preview is no longer indicating when a map can't be displayed, and instead just showing the basemap. Better to add a message saying that there is no map. For example, this dataset: https://catalogue.saeon.ac.za/records/10.15493/DEA.CARBON.10000119

This is actually happening - but the error message is being shown below the map so it's not very obvious. Instead the error message should be absolutely positioned on top of the map with a nice box shadow.
Here's an example of such a dataset: https://catalogue.saeon.ac.za/records/10.15493/NCCIS.DATA.10000039


Add tests for poi_category

Short description

This PR adds tests for the poi categories in order to increase our test coverage further and secondly to make sure we catch bugs such as #2708 in the future.
Proposed changes

Add tests both for creating new poi categories and for the poi category list

Side effects

I think none?

Resolved issues

Fixes: Partly #2582

Pull Request Review Guidelines

It's a nice improvement and catches the error reported in #2708 :+1:
I'd suggest to add tests for updating a POI category (adding a new translation to an existing category and/or changing a translation of an existing one) and deletion (used categories will not be deleted, but unused ones can be).

@MizukiTemma thank you for your feedback. I implemented the three requested tests (updating, successful deletion of poicategory not in use, unsuccessful deletion of poicategory in use). The last one detected a bug. Therefore this PR is blocked and has a failing test until the issue is resolved

@MizukiTemma This PR is ready for review again :)

@MizukiTemma I updated the branch now. Please check if the changes already do everything you had in mind :)


Fix Golos system accounts authorities in genesis

There are 3 system accounts in Golos: miners, null and temp. They have individual rules and behaviour, which can't be moved to Golos dApp. While importing, this accounts should become unusable.

PR #792


feat: Better runtime error handling

Currently, when a runtime error occurs during the execution of the program, the application only shows the error in the console.
Like in good debuggers, it would be nice to pause the execution of the program at the runtime error, show the erroneous statement in the Sierra code view, and then allow the user to step back and analyze the cause of the error.
The backend provides an is_execution_successful flag which indicates if there was an error during execution. When this flag is set to true, that means the last trace item is the runtime error.
Acceptance criteria
When is_execution_successful flag is true, the frontend should show the trace in red in the Execution Trace view. It should also show in red the corresponding set of instructions in the Sierra and CASM views.
Out of scope
Showing the error line in the Cairo editor is not part of this issue.
Hint: See the context/cairoVMApiContext.tsx file to implement this part.
Some examples of runtime error in Cairo
Calling the panic function
fn main() {
  panic(ArrayTrait::new());
}

division by 0
fn main() -> u8 {
  10_u8 / 0_u8
}

overflow
fn main() -> u8 {
  255_u8 + 1_u8
}

underflow
fn main() -> u8 {
  0_u8 - 1_u8
}

out of bounds
use array::ArrayTrait; fn main() {
  let a = ArrayTrait::<u8>::new();
  let _ = *a.at(0);
}

@mazurroman I'd like to have this one

Can I implement this logic and build this feature?

Hi @mazurroman I would love to handle this.

Hey I'd like to try this one please :)
When is_execution_successful is false I will find the corresponding problematic instruction in the execution trace/Sierra/CASM and highlight it in red.

Thank you everyone for your interest in working on this issue. I have assigned it to @saimeunt because he provided the most comprehensive information on how to resolve the issue.
There are more open issues in case anyone wants to take a look!


Add links to the bug fixes

@nannanli Ashley - i might have approved this in error.  I presumed that an open PR might hold up publishing the doc for the 9.3 release. I hope that the approval does not cause a problem.
thx

@JamesBauman Thanks Jim!


drivers: fuel_gauge: Place API into iterable section

Add wrapper DEVICE_API macro to all fuel_gauge_driver_api instances.

@teburd @aaronemassey PTAL

Do we need to do this for emulator APIs too?

Those API functions do not take a const struct device * as first argument, so they aren't really device APIs.


Disallow moving literals to their own line in binary expressions

This is another proposed solution to #314, see the discussion there.
This also solves @llimllib case in #46 (see comment https://github.com/jlongster/prettier/issues/46#issuecomment-271696399). Currently we output his/her worst solution. Now we would output:
lots +
  of +
  additions +
  are +
  put +
  into +
  some +
  weird +
  format +
  thats +
  ugly > 0;

While that might look a little weird with that example code, I think this will solve a lot of real-world problems where we'd move a simple literal to its own line.

Can you add a test as well, this way if someone is going to tweak that logic in the future, it's going to show a difference.

Oh definitely. I was mainly opening this as a proof of concept to see what people though. Add tests though would be a good way to show the difference.

Do want identifiers to be included in this test too? Currently we might still break them onto newlines, but I think that might be OK.
Also, this PR doesn't quite work. Now it doesn't break any of the expression at all if it's all made up of numbers (if we check idents too, it'll break even more). This is because even the sub-expressions have a literal/ident on the right-hand side too. I suppose we should check if the left-hand is not a binary expression too, which would only trigger them when it's a simpler expression like ident + 5.

Considering closing this since we have another solution in #314, or does anything thing we should still also implement this?

Closing this for now, we can reopen if later we find other scenarios where it's helpful. Let's get #314 in first and see how well that works.


Should not try relay many times if failed

https://sepolia.etherscan.io/address/0x0000000000808fE9bDCc1d180EfbF5C53552a6b1

Relayer could try use eth_call to try call the transaction before send_RawTransaction.


Redoing the VesselView updates

Politas, I redid this entire PR becuase I had to make more changes and didn't have the original around anymore

No worries. Am I right in thinking that the two "UI" mods are only installing a single file each?
If so, you could use find_matches_files, eg
"find" : "VesselViewRPM.dll",
"find_matches_files" : true,
"install_to" : "GameData/VesselView"

rather than matching the folder and excluding all the other files.

There is a problem with this.  When you now try to install the VesselViewer, CKAN then presents two lines for the VVesselViewUI.  Multiple issues:

The mod name for each is identical, probably because it's pulling the name from spacedock
Only one can be selected
Selecting and installing gets a CKAN error


fix bugs in concurrency chapter, "A solution: Producer/Consumer" section

At the end of the _concurrency_ chapter, there is a demo named _A solution: Producer/Consumer_ has some bugs.
I also fixed them in Russian, Korea and Chinese.

val queue = new LinkedBlockingQueue[String]()

But the other code use q for this instance, so it's an error.
2.
for (i <- i to cores) {

The second i is error, it should be 1.
3.
pool.submit(new IndexerConsumer[String](index, q))

index  is not declared.

class Producer[T](path: String, queue: BlockingQueue[T]) extends Runnable {
  def run() {
    Source.fromFile(path, "utf-8").getLines.foreach { line =>
      queue.put(line)
    }
  }
}

val q = new LinkedBlockingQueue[String]()
val producer = new Producer[String]("users.txt", q)

queue.put(line) in Producer class will call an error.
error: type mismatch;
 found   : String("sssssssssss")
 required: T
    b.tell("sssssssssss")
               ^
one error found

Change it to
class Producer[T>:String](path: String, queue: BlockingQueue[T]) extends Runnable {

or
class Producer[T](path: String, queue: BlockingQueue[String]) extends Runnable {

can fix it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


New aka.ms link

Aka.ms link name
BeyondVPN
Category (Optional. Select None to auto-select)
None

Thank you for submitting aka.ms/BeyondVPN. Your link already exists at akaSearch.net. 🙏✅


Dynamically handle switching between light and dark mode

Some users have a preference for dark mode or light mode -- usually expressed in different ways. Dynamically render the theme that will most likely appeal to the user.
Use palette customization through material ui: https://material-ui.com/customization/palette/

:tada: This issue has been resolved in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Scala Common Enrich: fix failing WeatherEnrichmentSpec expectation

In integration test we were relying on closest timestamp output from OpenWeatherMap. It looks like they optimized historical timestamp from precise 2015-08-29T23:16:14.000Z to round 2015-08-30T00:00:00.000Z. We need to fix expectation to conform this change.
This is in some sense critical for R88, because Travis run SCE tests even if SCE itself isn't releasing.
@alexanderdean should it be SCE 0.24.1?

Hey @chuwy - can we get away with just a SCE 0.24.1, or do we have to release a SHE too?

Luckily, just SCE.

Cool, let's schedule into R88, update CHANGELOG etc. Thanks!


fix: update clear bit in page_diff

Sometimes, a page was properly created by the PageWalker, but then in subsequent commits an empty page was found.
For this to occur, two conditions needed to be satisfied:

A leaf must have been placed at the last level of a page, resulting in children in the next page.
For example, a value with a key of 0b00000001_00000000_... which currently resides at the 6th level of the first page.
A new leaf with a common prefix of at least 15 bits needed to be introduced.
For instance, 0b00000001_00000001_...

During the update, a new subtree would be created below the existing leaf, involving the following steps:

Clearing the children of the existing leaf (setting the 'cleared' bit to 1 in the relative page_diff)
Establishing a new page to store both leaves and their children
Writing all internal nodes up to the node where the existing leaf was stored (on the same page where the previous children were present)

The issue arises as step one clears the PageDiff where the children were stored, and step three writes new internal nodes to the same page and page diff without removing the cleared bit. As a result, bitbox reads the cleared bit in the page_diff and ends up deleting the page instead of saving the updated version with the necessary internal nodes.
In summary, if a page initially containing only two children at the first layer were transformed into a page with solely internal nodes, bitbox would not save it.
The solution is straightforward: ensure to use clear bits when eliminating everything, but if writing occurs again, remove the clear bit.
However, there is another tricky part: the changes on the page themselves still need to happen even if a page is being cleared because later on, the same page could be reused. Leave garbage in the nodes would lead to errors. That's why I didn't just put a set_cleared(false) within PageDiff::set_changed(...).
Tests will be a part of a follow-up to being able to effectively conduct other tests and benchmarks in the meanwhile!
Closes THR-50

#596  👈 (View in Graphite)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.


Revert "Update README.md"

Reverts Esen002/jbbmo-Introduction-to-Git-and-GitHub#1

Reverted change back to 2022


Glamor adoption questions

Hey, I'm on the brink or releasing a component library but ran into a hurdle with aphrodite. Wondering if glamor behaves the differently as in allows the styles to be overridden by user created css. Could you take a look at the issue I raised here. I would love to switch in glamor if it doesn't behave the same in that aspect.

No, I suppose glamor would have the same problem. Rather, this is more a problem with css than glamor / aphrodite. And I wouldn't move the tags to the top of head, this would be confusing to the user.
Could you component library accept style objects instead of classnames? You could merge those in and you'd get expected behavior.

@threepointone I was planning on supporting both classNames and style objects. In any case thanks!

closing this issue for now. assuming this classname is a class from the developer's own stylesheet, not a glamor / aph classname, not much we can do, sorry :|


Add Firehose Project to Code Schools section.

Feature
Why is this feature being added?

Firehose Project is in the process of a possible partnership offering a scholarship to eligible veterans in the Los Angeles Area. For now add them to the Code Schools section -> Online Schools
What should your feature do?
Add the Logo attached to this issue

The logo is attached for Firehose Project
Currently not accepting the G.I. bill
Location: San Francisco, CA

Closing, duplicate of back-end issue: https://github.com/OperationCode/operationcode_backend/issues/341


Shuffle button disappeared and buttons are not aligned either when language is Traditional Chinese

Did you read the README?

[X] I have read the README, the theme is installed/configured correctly and the "Troubleshooting" section contains no information related to my problem

Do you have the latest versions of Spicetify, Spotify and Bloom?

[X] I'm using the latest versions of Spicetify, Spotify and Bloom

Is there already an issue for your problem?

[X] I have checked older issues, open and closed

Is your problem definitely caused by the theme?

[X] I have checked the app behavior without the theme and it is different

Environment & Computer Info
- Spotify version: <IP_ADDRESS>5.g02fef27a
- Installed from: Spotify site
- Spicetify version: v2.31.1
- Color scheme: darkmono
- Extensions: adblock.js, allOfArtist.js, made-for-you-shortcut.js, volumePercentage.js, theme.js
- Custom apps: Spicetify market
- Bloom installation method: Spicetify Marketplace

Description

When I set the language to English, everything works fine. But when I set it to Traditional Chinese, the Shuffle button disappeared. Buttons are not aligned either
Screenshots

If I disable the "Smart shuffle" from the experiment setting, though the shuffle icon shows, it is un-clickable

I have the same issue xd

@IdkWhatToCallMe123 @ElliotCHEN37 do we still have the issue?

after testing i found a new issue
the play button is white

thx for fixing them, looking forward to next update

@ElliotCHEN37 can we check the issues now?

the button is still white (re-installed via marketplace)

how about reinstalling with the script! let me knw how it went afterwards!
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
iex "& { $(iwr -useb 'https://raw.githubusercontent.com/nimsandu/spicetify-bloom/main/install/PowerShell/Bloom.ps1') }"

this works ryt on mine, thats why its hard to figure out whats wrong!

still not working...

hmm. well lets see what we can do! btw whats your spicetify version?

適用 Windows (64 位元) 的 Spotify
<IP_ADDRESS>9.g606b7f29
Spicetify v2.36.13
Theme:
Extensions: scannables.js, copytoclipboard.js, adblock.js
Custom apps: marketplace, lyrics-plus

Thanks!!
Will see what we can do!

solved in latest version


Persistent tabs feature

Would love to see an simple implementation of tab persistence so when a page is refreshed the active tab remains selected. I've seen this done with jquery cookies before. Possibly a tie-in with that?

You can implement this behavior using window.localStorage or .sessionStorage. I don't think that bootstrap should include this functionality. Doing exactly same thing for my app.

Will leave this one up to @fat to decide. I don't think we need to include that with the core bundle, but perhaps someone would like to make an add-on?

Definitely don't want to get into the cookie game with bootstrap plugins - and because storage apis don't have support in ie7 it's a no go.
I've played with doing more advanced hash stuff but ran into problems and decided simpler is the way to go.
Meanwhile i agree with @wildchild, you should definitely extend this plugin if that functionality is desired.

storage apis don't have support in ie7

For future plugin authors information, I believe it's possible to emulate localStorage using IE's UserData.


Migrate app examples to app sdk

https://github.com/saleor/app-examples
App examples are actually showcase of saleor api and SDK features
This should be more into app-sdk.
Leave original repository, we can update readme and make it read only, but first CLI must update to stop consuming it

@peelar please handover to @saleor/dex


RateLimiter backoff time overflows if too many http requests fail

The backoff time increases exponentially following 2number of failed requets. On a 64-bit system the maxsize of int is 263, so the number of failed requests is capped at 63 without overflowing.

This occurs if max number of tokens is set high enough that there can be many pending requests.


Any way to get the agent to send alerts?

I need to find a way to send alerts when one of the agents is not responding.

Has the answer to this thread changed since Apr 2014?


Unable to locate the city in the IANA database bug

I don't know if I'm doing something wrong but following read calls throw error
phable.parsers.json.IanaCityNotFoundError: Unable to locate the city Prague in the IANA database
with Client(uri, username, password) as client:
  points = client.eval('readAll(point and tz=="Prague" and (unit == "kW" or unit == "°C"), {limit:2})')
  points = client.read('point and tz=="Phoenix" and (unit == "kW" or unit == "°F")', 2)
  points = client.read('point and tz=="Prague" and (unit == "kW" or unit == "°C")', 2)

Tried Phoenix and Prague and both throw error, also tried eval and read but it is the same.
The points in skyspark are nothing special, they look valid.
Also tried running the readAll in skyspark and it returns the points as expected.
Can you replicate this issue?
(on latest 0.1.13)

It was because my new enviroment was missing tzdata package, which comes in as dependency of pandas but this enviroment did not have pandas. Maybe tzdata should be required dependency of phable?

I was not able to replicate the issue using the example code provided and Python 3.11.
I see that Phable maps Haystack's city name "Prague" to "Europe/Prague" and "Phoenix" to "America/Phoenix".  Is this what you would expect?
Here is example code:
from phable.parsers.json import _haystack_to_iana_tz

print(_haystack_to_iana_tz("Prague"))
print(_haystack_to_iana_tz("Phoenix"))

Please note that Phable relies on the zoneinfo module which was introduced in Python 3.11.
Which version of Python are you using?

I'm using python 3.11.2. I was able to make it work after installing the tzdata package. Can you check if you have this package installed? Does it work for you when you uninstall it?

I just ran another test using Python 3.11.2 without tzdata and it worked for me.
According to the Python docs in the link below:
"By default, zoneinfo uses the system’s time zone data if available; if no system time zone data is available, the library will fall back to using the first-party tzdata package available on PyPI."
https://docs.python.org/3.11/library/zoneinfo.html#module-zoneinfo
I suspect on my computer time zone data is available and on your computer it is not.  This is why I think you see the error and I don't.
For now I would recommend you install phable with the pandas dependency.
I think there are several possible solutions for us to explore:

Make tzdata a mandatory dependency to phable
Make tzdata an optional dependency to phable
Keep the existing design and update the docs

In either case I think we will update the phable docs.
What do you think is the best solution considering other users of phable may not want the tzdata dependency?

You are right, without tzdata running this I get empty set.
import zoneinfo
zoneinfo.available_timezones()

After installing tzdata it shows all the timezones.
I would probably go for 3 - keep it as is, update docs, and if possible add some helpful message at the end of current one like:
Unable to locate the city Prague in the IANA database. Consider installing tzdata package.

Hi Vojtech, thanks again for the feedback.  I implemented your latest advice in Phable version 0.1.14.


Get same port when trying to connect multiple times on iOS is failing

following logs for device: https://gist.github.com/baydet/f7764332b8d30fdbe69ba3a2f25bab01
CS: https://gist.github.com/baydet/24119d7e157d3d4c0f5869ccefc81785

fixed thaliproject/Thali_CordovaPlugin#1367


cannot import name 'ExtractSummaryAction' from 'azure.ai.textanalytics'

Frustratingly have followed all steps, including installing a new version of Python.  But Python is complaining it can't import ExtractSummaryAction.
Any suggestions for why not? or what to do about it?
Thanks,
PhilO

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a08dd9c5-27a8-eba6-caeb-8f049e60c255
Version Independent ID: 5f7efa46-5862-3ee8-f729-3f1ac584e524
Content: Quickstart: Use Document Summarization - Azure AI services
Content Source: articles/ai-services/language-service/summarization/quickstart.md
Service: cognitive-services
Sub-service: language-service
GitHub Login: @jboback
Microsoft Alias: aahi

@PhilOutram
Thanks for your feedback! We will investigate and update as appropriate.

@PhilOutram
It seems like you are trying to use the ExtractSummaryAction class from the azure.ai.textanalytics module, but Python is unable to import it. This could be due to a few reasons, such as a typo in the import statement or a missing package.
To troubleshoot this issue, you can try the following steps1:
Double-check that you have installed the azure-ai-textanalytics package by running pip list in your terminal and looking for it in the list of installed packages. If it is not installed, you can install it by running
pip install azure-ai-textanalytics
Make sure that you are importing the ExtractSummaryAction class correctly. The correct import statement should be:
from azure.ai.textanalytics import ExtractSummaryAction
Check that you are using the correct version of the azure-ai-textanalytics package. The ExtractSummaryAction class was introduced in version 5.3.0b1, so if you are using an older version of the package, you may need to upgrade it.
If none of these steps solve the issue, I'd recommend you create a support ticket since the support team will be able to respond much more quickly and have a conversation with you to figure out what could be going on.

@PhilOutram
We are going to close this thread. if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Rework ICA, test & add it to report

We're also writing a JSON file with useful ICA info; however I'm not sure just HOW useful this file is, given that all information is contains can also be retrieved from the ICA object / file directly. In any case, in the future I would like to add an automated table generator that provides an easy overview of the rejected ICs at a single glance.
Will ping you again once the artifacts are readily built so you can see for yourselves.

Ok here are the artifacts:

all ICs
rejection based on EOG and manually selected components
JSON file with info on ICA (tbd whether we want to keep it)
ICA in the final report

cc @agramfort
@SophieHerbst You happy with this so far? :)

Improved report with all ICs

Ok so this became HUGE, considering the number of changes lines.
But I'll give you a quick rundown, because really not that much has changed – it was mostly cleanups, restructuring, refactorings, decluttering. Oh and yes, I've adjusted the "user flow", of course :)
So from a user's perspective, to perform ICA, you now would do the following:

in the config:

use_ica=True
ica_l_freq can be used to select a high-pass filter cutoff frequency
via ica_n_components you can control how many PCs to feed into ICA (either as an int -- fixed number of PCs -- or as a float < 1, specifying the cumulative explained variance)
to actually reject components, you set ica_reject_components

Now how would you know which ICs to reject?
By default, we now in step 4 perform EOG and ECG artifact detection if possible (i.e. if the respective channel types are available). If no ECG channel is available, we try to use magnetometers instead. Currently there is no workaround for a missing EOG (theoretically we could create a virtual EOG channel too, at least for EEG (I don't know about MEG); this is not yet implemented)
At the end of step 4, an HTML report is generated with all the information about the automated artifact detection, and diagnostic plots for all ICs. So the user can then review all that information at once before proceeding to the next steps.
(Previously, there was no way to review EOG/ECG artifact detection results at this stage)
Also we emit a message to guide the user, e.g.:

09:39:31 [Step-04][sub-01, ses-anodalpre] ICA completed. Please carefully review the extracted ICs in the report, and add all ICs you wish to exclude to the configuration file, e.g.: ica_reject_components = {'sub-01': [0, 1, 5 ]}

Once you've done that, you may proceed to step 5 where the actual rejection is performed.
But what if you don't want to manually select / review components for rejection? In that case, you can set ica_reject_components = 'auto', which will automatically remove ICs identified as ECG/EOG artifacts: in step 4, we store those ICs in ica.exclude before writing the ICA object to disk; and in step 5, we load it from disk and simply rely on ica.exclude if ica_reject_components = 'auto'.
Performace with the example dataset ds001810 is still bad, but it demonstrates the procedure.

What I've added in bce7d86 is what I had discussed with @agramfort on Slack:
In situations where

we find an existing ICA solution stored on disk, and
the user manually specified ICs for rejection in the config file,

we now do not re-calculate the ICA solution, but instead re-use the existing solution. We still run ECG and EOG artifact detection and create all diagnostic plots, but we do not overwrite or alter the existing ICA solution per se. Users will be notified of this, and are advised to either delete the existing solution, or to remove the manually-picked ICs from their config file in order to create a new solution. This is to ensure one doesn't accidentally remove the "wrong" ICs when re-running the pipeline on a different system than the one used for initial IC inspection.

Rebased on master to resolve merge conflicts

@agramfort This needs to be addressed upstream in https://github.com/mne-tools/mne-python/issues/8147
Since there is not much we can do here for now, I'd propose we move ahead with this PR? Once the issue is addressed upstream, everything will automatically fall into place.

@agramfort Additionally to the ICA Report, we now also create a TSV file that lists all independent components and their status (good, bad), and allows uers to specify which components to exclude.

This is finally good to merge! Results could still be better but generally all seems to work now!
Artifacts:

All ICs: https://701-167957354-gh.circle-artifacts.com/0/reports/ds001810/sub-01_ses-anodalpre_task-attentionalblink_proc-ica_report.html
After artifact removal: https://701-167957354-gh.circle-artifacts.com/0/reports/ds001810/sub-01_ses-anodalpre_task-attentionalblink_proc-clean_report.html
Complete report: https://701-167957354-gh.circle-artifacts.com/0/reports/ds001810/sub-01_ses-anodalpre_task-attentionalblink_report.html
user-editable TSV file to control IC removal: https://701-167957354-gh.circle-artifacts.com/0/reports/ds001810/sub-01_ses-anodalpre_task-attentionalblink_proc-ica_components.tsv


Migrate from ethers v5 to v6

Description:

There is a new major ethersjs version with many breaking changes. We're trying to bump the version but the RLP encoder/decoder has been modified and v5 rlp encoded tx can not be decoded in v6 which causes SDK errors. Blocked till the SDK doesn't migrate to ethersjs v6. Another showstopper is the error handling and transaction reverting in ethers v6 which has been entirely changed.
A part of the migration guide can be found here, but it doesn't include RLP encoder/decoder and error handling :confused: .
I tried to bump the version only in the relay package (the server package runs ethers v5) and run the acceptance tests against the relay that running ethers v6 and they were all green. So if we're pushed to bump the version to v6, as a workaround we can bump only the relay's ethers version, and postponed the bumping of acceptance tests ethers version.
Related issue(s):
Fixes #1136
Child good-to-have issue: https://github.com/hashgraph/hedera-json-rpc-relay/issues/1617
Blocked by:

https://github.com/hashgraph/hedera-services/issues/7670
https://github.com/hashgraph/hedera-local-node/pull/376 - in hedera-services has been added a new config.txt property, and we have to edit the config.txt in the local node, then release a new version that will be used by the ci otherwise if we just bump the services and mirror-node versions in acceptance test's index.spec.ts, the node will not start due to config.txt error`

Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report
Patch coverage: 78.57% and project coverage change: -1.04% :warning:

Comparison is base (f972c2e) 78.17% compared to head (faf2798) 77.14%.
 Consider uploading reports for the commit 0e6c006 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1314      +/-   ##
==========================================
- Coverage   78.17%   77.14%   -1.04%
==========================================
  Files          33       33
  Lines        2603     2603
  Branches      525      525
==========================================
- Hits         2035     2008      -27
- Misses        407      427      +20
- Partials      161      168       +7

Files Changed
Coverage Δ

packages/relay/src/lib/precheck.ts
58.53% <76.92%> (-28.05%)
:arrow_down:

packages/relay/src/lib/eth.ts
85.32% <100.00%> (ø)

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Should we also update the ethers.js version in the dapp-example?

Yeah, but let's do it in another task/PR.


K.learning_phase:0 doesnt work after loading from Tensorflow checkpoint

Please make sure that the boxes below are checked before you submit your issue. If your issue is an implementation question, please ask your question on StackOverflow or join the Keras Slack channel and ask there instead of filing a GitHub issue.
Thank you!

[x] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/fchollet/keras.git --upgrade --no-deps

[x] If running on TensorFlow, check that you are up-to-date with the latest version. The installation instructions can be found here.

[ ] If running on Theano, check that you are up-to-date with the master branch of Theano. You can update with:
pip install git+git://github.com/Theano/Theano.git --upgrade --no-deps

[ ] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

Hi, I am using Keras layers for my Tensorflow model following this tutorial (https://blog.keras.io/keras-as-a-simplified-interface-to-tensorflow-tutorial.html)
I am saving my model into a checkpoint file using tf.Saver and loading it back. I have a dropout layer in my model, so I am setting the K.learning_phase:0 for testing. However, it seems like it is not getting the key-value from the feed_dict.
saver = tf.train.import_meta_graph(log_path + file_name + ".meta", clear_devices=True)
graph = tf.get_default_graph()

pred_op = graph.get_operation_by_name("prediction/prediction")
# placerholders
labels = graph.get_tensor_by_name("input/labels:0")
X = graph.get_tensor_by_name("input/X:0")

with tf.Session(config=session_conf) as sess:
    K.set_session(sess)
    saver.restore(sess, log_path + file_name)
    feed_dict = {
        labels: y_test,
        X: x_test,
        K.learning_phase(): 0
    }
    pred = sess.run(pred_op, feed_dict)

I am getting the Error:
tensorflow.python.framework.errors_impl.InvalidArgumentError: You must feed a value for placeholder tensor 'nn-layers/fully-connected-layer-0/dropout_1/keras_learning_phase' with dtype bool
This is quiet strange since setting the learning_phase=0 was working very well when the model was training and evaluating.

I tried to save the checkpoint file after setting K.set_learning_phase(0) but still does not work.

I am running into what I suppose to be at least a related problem.
I created a tensorflow model making use of the K.learning_phase() flag like this:
return tf.cond(K.learning_phase(),                                true_fn=lambda: 1,                                false_fn=lambda: -1.)
When building the model from code, and then running it via sess.run(..., feed_dict={...,                                                                                K.learning_phase(): 1}), the model behaves as expected. However, when I load the same model from a tensorflow checkpoint created and loaded via a tf.train.Saver, -1 is returned independently of which value is fed to K.learning_phase().


Remove job running tests in release mode on the CI and bors

Importance of this job decreased since we fixed the major performance downsides
in debug mode which used to cause flaky test behaviour in debug mode. Right
now they seem to be more of a hindrance than adding any value as we are
being hit by compile times on the CI and bors.

bors r+


Use .env Variables for Dazzle (Use ScratchDB, Dazzle dir)

I noticed these values weren't being used before.

On second thought: these aren't being used. Why are these here?


Update Google Cloud SDK on BuildKite agents

The Google Cloud SDK that is deployed on the current BuildKite agents is
quite old, and thus is missing some flags I need to be able to proceed
with #10939. Namely, the --worker-pool flag is missing in this
version.
Explain your changes:

Update Google Cloud SDK download URL from version 296.0.1 to 400.0.0

Explain how you tested your changes:

I have not. The changes first have to be applied to the agents. I don't think i can do this.

Hi @bryanhonof - this is actually an old configuration that is no longer in use.
Could you please open a PR to add this adit to the new buildkite agent deployment files (it would need to be added in each of the three deploy yaml files):
https://github.com/MinaProtocol/mina-deployments/tree/main/src/buildkite
The deploy file that is edited in this PR is planned to be purged from the main repo, but had not be cleaned up yet.

Correction - I modified the files directly. So the change you wanted is now in the config files. They would just need to be applied to redeploy the agents now.


Full bleed web part section do not render icons

Category

[x] Bug

Describe the bug
When a web part is deployed in the full-bleed mode the image icon for the web part won't get rendered.

The image is properly references on the page and the issue is related to the CSS used there.

To show the image the following CSS need to be changed:

/* Inline #19 | https://n8dlab001.sharepoint.com/sites/Showcase?Mode=Edit */

.image-308 {

  /** Original Values **/
  /* width: 100%; */
  /* height: 100%; */
  /* width: contain; */
  /* object-fit: contain; */
  /* position: absolute; */
  /* height: absolute; */
  /* object-fit: undefined; */
  /* position: undefined; */
  /* position: absolute; */
  /* left: 48px; */
  /* top: undefined; */
  /* transform: 48px; */
  /* transform: undefined; */

  /** Appropriate values **/
  display: block;
  opacity: 1;
  width: 48px;
  height: 48px;
  object-fit: contain;
  position: absolute;
  left: 50%;
  top: 50%;
  transform: translate(-50%, -50%);
  width: 48px;
  height: 48px;

}

The changes are not perfect but at least the image renders

Steps to reproduce
Deploy a web part using full bleed.
Expected behavior
Render image defined in the web parts properly.

Confirmed... I can repro this in SPO & SPFx v1.11

Thank you @StfBauer for reporting this one, and sorry for the long delay.
It has been fixed and should be available WW in the next couple of weeks.

This should be rolled WW now.


UnhandledPromiseRejectionWarning: Error: ENOENT, No such file or directory 'undefined' <<<----------------------------------------------------------

Im so close! Please review & tell me where im going wrong.
Repo appears updated since last Tutorial video.  Looks like its starting to mint, gives it a DNA and then is looking for the image in the wrong directory.  How can i correct this?  All layers are in folders in the input folder. /input/Backgrounds/super_rare   ect.
Thank you

creating NFT 1 of 10

rarity: original
dna: 05-06-02-02-06-05-05-05-06--09-010
(node:12892) UnhandledPromiseRejectionWarning: Error: ENOENT, No such file or directory 'undefined'
at setSource (C:\Users\Morpheus360\generative-art-opensource-main\node_modules\canvas\lib\image.js:91:13)
at Image.set (C:\Users\Morpheus360\generative-art-opensource-main\node_modules\canvas\lib\image.js:62:9)
at C:\Users\Morpheus360\generative-art-opensource-main\node_modules\canvas\index.js:34:15
at new Promise ()
at loadImage (C:\Users\Morpheus360\generative-art-opensource-main\node_modules\canvas\index.js:23:10)
at C:\Users\Morpheus360\generative-art-opensource-main\index.js:75:25
at new Promise ()
at loadLayerImg (C:\Users\Morpheus360\generative-art-opensource-main\index.js:74:10)
at C:\Users\Morpheus360\generative-art-opensource-main\index.js:215:27
at Array.forEach ()
(Use node --trace-warnings ... to show where the warning was created)
(node:12892) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:12892) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
PS C:\Users\Morpheus360\generative-art-opensource-main>

config.js
/**************************************************************

UTILITY FUNCTIONS

scroll to BEGIN CONFIG to provide the config values
*************************************************************/
const fs = require("fs");
const dir = __dirname;

// adds a rarity to the configuration. This is expected to correspond with a directory containing the rarity for each defined layer
// @param _id - id of the rarity
// @param _from - number in the edition to start this rarity from
// @param _to - number in the edition to generate this rarity to
// @return a rarity object used to dynamically generate the NFTs
const addRarity = (_id, _from, _to) => {
const _rarityWeight = {
value: _id,
from: _from,
to: _to,
layerPercent: {}
};
return _rarityWeight;
};
// get the name without last 4 characters -> slice .png from the name
const cleanName = (_str) => {
let name = _str.slice(0, -4);
return name;
};
// reads the filenames of a given folder and returns it with its name and path
const getElements = (_path, _elementCount) => {
return fs
.readdirSync(_path)
.filter((item) => !/(^|/).[^/.]/g.test(item))
.map((i) => {
return {
id: _elementCount,
name: cleanName(i),
path: ${_path}/${i}
};
});
};
// adds a layer to the configuration. The layer will hold information on all the defined parts and
// where they should be rendered in the image
// @param _id - id of the layer
// @param _position - on which x/y value to render this part
// @param _size - of the image
// @return a layer object used to dynamically generate the NFTs
const addLayer = (_id, _position, _size) => {
if (!_id) {
console.log('error adding layer, parameters id required');
return null;
}
if (!_position) {
_position = { x: 0, y: 0 };
}
if (!_size) {
_size = { width: width, height: height }
}
// add two different dimension for elements:
// - all elements with their path information
// - only the ids mapped to their rarity
let elements = [];
let elementCount = 0;
let elementIdsForRarity = {};
rarityWeights.forEach((rarityWeight) => {
let elementsForRarity = getElements(${dir}/${_id}/${rarityWeight.value});
elementIdsForRarity[rarityWeight.value] = [];
elementsForRarity.forEach((_elementForRarity) => {
  _elementForRarity.id = `${editionDnaPrefix}${elementCount}`;
  elements.push(_elementForRarity);
  elementIdsForRarity[rarityWeight.value].push(_elementForRarity.id);
  elementCount++;
})
elements[rarityWeight.value] = elementsForRarity;

});
let elementsForLayer = {
id: _id,
position: _position,
size: _size,
elements,
elementIdsForRarity
};
return elementsForLayer;
};
// adds layer-specific percentages to use one vs another rarity
// @param _rarityId - the id of the rarity to specifiy
// @param _layerId - the id of the layer to specifiy
// @param _percentages - an object defining the rarities and the percentage with which a given rarity for this layer should be used
const addRarityPercentForLayer = (_rarityId, _layerId, _percentages) => {
let _rarityFound = false;
rarityWeights.forEach((_rarityWeight) => {
if (_rarityWeight.value === _rarityId) {
let _percentArray = [];
for (let percentType in _percentages) {
_percentArray.push({
id: percentType,
percent: _percentages[percentType]
})
}
_rarityWeight.layerPercent[_layerId] = _percentArray;
_rarityFound = true;
}
});
if (!_rarityFound) {
console.log(rarity ${_rarityId} not found, failed to add percentage information);
}
}
/**************************************************************

BEGIN CONFIG
*************************************************************/

// image width in pixels
const width = 1000;
// image height in pixels
const height = 1000;
// description for NFT in metadata file
const description = "Viral Viruses by CRISPR";
// base url to use in metadata file
// the id of the nft will be added to this url, in the example e.g. https://hashlips/nft/1 for NFT with id 1
const baseImageUri = "https://crispr/viral_viruses";
// id for edition to start from
const startEditionFrom = 1;
// amount of NFTs to generate in edition
const editionSize = 10;
// prefix to add to edition dna ids (to distinguish dna counts from different generation processes for the same collection)
const editionDnaPrefix = 0
// create required weights
// for each weight, call 'addRarity' with the id and from which to which element this rarity should be applied
let rarityWeights = [
addRarity('super_rare', 1, 1),
addRarity('rare', 2, 5),
addRarity('original', 5, 10)
];
// create required layers
// for each layer, call 'addLayer' with the id and optionally the positioning and size
// the id would be the name of the folder in your input directory, e.g. 'ball' for ./input/ball
const layers = [
addLayer('Background', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Mouths', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Teeth', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Eye Square Fix', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Eyes', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Body', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Horns', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Horns Shading', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Body Shading', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Mouth Accessories', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Head Accessories', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Eye Accessories', { x: 0, y: 0 }, { width: width, height: height }),
];
// provide any specific percentages that are required for a given layer and rarity level
// all provided options are used based on their percentage values to decide which layer to select from
addRarityPercentForLayer('super_rare', 'Mouth Accessories', { 'super_rare': 10, 'rare': 30, 'original': 60 });
addRarityPercentForLayer('original', 'Background', { 'super_rare': 10, 'rare': 30, 'original': 60 });
module.exports = {
layers,
width,
height,
description,
baseImageUri,
editionSize,
startEditionFrom,
rarityWeights,
};

index.js
/**************************************************************

UTILITY FUNCTIONS

scroll to BEGIN CONFIG to provide the config values
*************************************************************/
const fs = require("fs");
const dir = __dirname;

// adds a rarity to the configuration. This is expected to correspond with a directory containing the rarity for each defined layer
// @param _id - id of the rarity
// @param _from - number in the edition to start this rarity from
// @param _to - number in the edition to generate this rarity to
// @return a rarity object used to dynamically generate the NFTs
const addRarity = (_id, _from, _to) => {
const _rarityWeight = {
value: _id,
from: _from,
to: _to,
layerPercent: {}
};
return _rarityWeight;
};
// get the name without last 4 characters -> slice .png from the name
const cleanName = (_str) => {
let name = _str.slice(0, -4);
return name;
};
// reads the filenames of a given folder and returns it with its name and path
const getElements = (_path, _elementCount) => {
return fs
.readdirSync(_path)
.filter((item) => !/(^|/).[^/.]/g.test(item))
.map((i) => {
return {
id: _elementCount,
name: cleanName(i),
path: ${_path}/${i}
};
});
};
// adds a layer to the configuration. The layer will hold information on all the defined parts and
// where they should be rendered in the image
// @param _id - id of the layer
// @param _position - on which x/y value to render this part
// @param _size - of the image
// @return a layer object used to dynamically generate the NFTs
const addLayer = (_id, _position, _size) => {
if (!_id) {
console.log('error adding layer, parameters id required');
return null;
}
if (!_position) {
_position = { x: 0, y: 0 };
}
if (!_size) {
_size = { width: width, height: height }
}
// add two different dimension for elements:
// - all elements with their path information
// - only the ids mapped to their rarity
let elements = [];
let elementCount = 0;
let elementIdsForRarity = {};
rarityWeights.forEach((rarityWeight) => {
let elementsForRarity = getElements(${dir}/${_id}/${rarityWeight.value});
elementIdsForRarity[rarityWeight.value] = [];
elementsForRarity.forEach((_elementForRarity) => {
  _elementForRarity.id = `${editionDnaPrefix}${elementCount}`;
  elements.push(_elementForRarity);
  elementIdsForRarity[rarityWeight.value].push(_elementForRarity.id);
  elementCount++;
})
elements[rarityWeight.value] = elementsForRarity;

});
let elementsForLayer = {
id: _id,
position: _position,
size: _size,
elements,
elementIdsForRarity
};
return elementsForLayer;
};
// adds layer-specific percentages to use one vs another rarity
// @param _rarityId - the id of the rarity to specifiy
// @param _layerId - the id of the layer to specifiy
// @param _percentages - an object defining the rarities and the percentage with which a given rarity for this layer should be used
const addRarityPercentForLayer = (_rarityId, _layerId, _percentages) => {
let _rarityFound = false;
rarityWeights.forEach((_rarityWeight) => {
if (_rarityWeight.value === _rarityId) {
let _percentArray = [];
for (let percentType in _percentages) {
_percentArray.push({
id: percentType,
percent: _percentages[percentType]
})
}
_rarityWeight.layerPercent[_layerId] = _percentArray;
_rarityFound = true;
}
});
if (!_rarityFound) {
console.log(rarity ${_rarityId} not found, failed to add percentage information);
}
}
/**************************************************************

BEGIN CONFIG
*************************************************************/

// image width in pixels
const width = 1000;
// image height in pixels
const height = 1000;
// description for NFT in metadata file
const description = "Viral Viruses by CRISPR";
// base url to use in metadata file
// the id of the nft will be added to this url, in the example e.g. https://hashlips/nft/1 for NFT with id 1
const baseImageUri = "https://crispr/viral_viruses";
// id for edition to start from
const startEditionFrom = 1;
// amount of NFTs to generate in edition
const editionSize = 10;
// prefix to add to edition dna ids (to distinguish dna counts from different generation processes for the same collection)
const editionDnaPrefix = 0
// create required weights
// for each weight, call 'addRarity' with the id and from which to which element this rarity should be applied
let rarityWeights = [
addRarity('super_rare', 1, 1),
addRarity('rare', 2, 5),
addRarity('original', 5, 10)
];
// create required layers
// for each layer, call 'addLayer' with the id and optionally the positioning and size
// the id would be the name of the folder in your input directory, e.g. 'ball' for ./input/ball
const layers = [
addLayer('Background', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Mouths', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Teeth', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Eye Square Fix', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Eyes', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Body', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Horns', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Horns Shading', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Body Shading', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Mouth Accessories', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Head Accessories', { x: 0, y: 0 }, { width: width, height: height }),
addLayer('Eye Accessories', { x: 0, y: 0 }, { width: width, height: height }),
];
// provide any specific percentages that are required for a given layer and rarity level
// all provided options are used based on their percentage values to decide which layer to select from
addRarityPercentForLayer('super_rare', 'Mouth Accessories', { 'super_rare': 10, 'rare': 30, 'original': 60 });
addRarityPercentForLayer('original', 'Background', { 'super_rare': 10, 'rare': 30, 'original': 60 });
module.exports = {
layers,
width,
height,
description,
baseImageUri,
editionSize,
startEditionFrom,
rarityWeights,
};

same issue

I have ran npm install canvas and still same error.
Is this possibly a rarity config issue?  Do i need to add super_rare, rare, & original to every single layer.  I have 12 so would the total be 36 lines of code. 3 rarity types for all 12 layers?

Also I've went through all of the closed tickets and applied everything I learned and still same error.  Please advise.

Do i need to rename the actual image layer file name to something specific?

Try putting layer files name like this
layer1_folder > layer1.png
layer2_folder > layer2.png


fix: increase e2e env startup timeout

Motivation
Make the e2e tests stable.
Description

When E2E job failed on CI, it's often it's just the timeout for starting the e2e nodes.

Steps to test or reproduce

Run all tests.

:tada: This PR is included in v1.16.0 :tada:


Fix rebalancer adding extra replicas

Fix the rebalancer adding extra replicas when downsizing clusters due to
not clearing the instance state map before writing in the new segment
assignment.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@54d8cd8). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1567   +/-   ##
=========================================
  Coverage          ?   59.32%
=========================================
  Files             ?      818
  Lines             ?    39542
  Branches          ?     5182
=========================================
  Hits              ?    23457
  Misses            ?    14405
  Partials          ?     1680

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54d8cd8...586c1b2. Read the comment docs.


TUTORIAL updates

hi,
it seems Oscar 1.3 is working well with Django 1.10, and so does Wagtail 1.8 -- any chance to get updated tutorial for integrating the three manually?
Thanks!

Hi. Oscar 1.3 has a problem with the transition to Django1.10.
Error in strategy Middleware.

Thanks for reporting this! Right now we're a little swamped with other activities, so I'm happy to accept a PR for this.


always swap with native currency.

This is one way to support swapping with only the Balances pallet as one side of every pair.
The swap methods have been split out into buy / sell methods to make the logic clearer.
(Separate asset instances can be handled by multiple dex instances as now there is no cross asset-instances pair.)

Feedback from Joe is that while this would work it would be hard to adapt should the people want to support any to any pairs rather than just dot to any pairs in the future.


Make quotes more ANSI compatible.

Using double quotes for values is MySQL specific.  Running against
a MySQL server with ANSI_QUOTES mode set results in an inability to
record migrations in the database as the migration name value is
treated as a column name.
This change makes the use of single quotes more consistent with all
existing database drivers and more compatible with ANSI usage.
This is more of a bug fix than a feature and will close #453

Are there other places where double quotes are used?

I don't think so.  This change makes phinx functional on my setup, and I just did a quick scan of double quotes in all the adapters.


Fonts in Extensions dont update when changing themes

VSCode Version: Code - Insiders 1.15.0-insider (47a49c7fb8138fd27e2a95259ae96e9ac49a65a5, 2017-07-14T07:45:27.194Z)
OS Version: Windows_NT x64 10.0.15063
Extensions:

Extension
Author (truncated)
Version

npm-intellisense
chr
1.3.0

path-intellisense
chr
1.4.2

vscode-eslint
dba
1.2.11

vscode-npm-script
eg2
0.2.0

search-node-modules
jas
1.1.1

vscode-icons
rob
7.10.1

code-settings-sync
Sha
2.8.2

JavaScriptSnippets
xab
1.4.1

(1 theme extensions excluded)

Steps to Reproduce:

Open Any Extension
Change Theme
Check Fonts (Please refer to attached GIF)

#25370


e2e: Add test for AWS SQS target

@FranBarrera can we implement this in triggermesh/triggermesh instead? E2E tests are running there now.

@antoineco Sure, I can implement it there.


False positives replacing equivalent expression, like Duration::ZERO and Default::default()

For example cargo-mutants will complain that it can replace std::time::Duration::ZERO with Default::default().
Some cases in the standard library can maybe be special cased but there are often functions that are equivalent to Default::default() but are provided because they provide a more meaningful name. In fact Default::default() is often implemented just by calling a different method like Self::empty().
I don't know if there is a general solution to this problem. Maybe there can be a basic complexity metric such that this replacement is only done if the thing being replaced is more complex than a simple field access, function call or similar. For example Duration::from_secs(0) or accessing some constant DELAY likely should also not be replaced.
Vaguely related: https://github.com/sourcefrog/cargo-mutants/issues/418

A much more complex option would be to inject some sort of check that runs the old code and checks that at least once it is different than the default value.
Although this has a number of problems:

Requires that the value implements PartialEq.
Requires injecting code into the process and a side-channel to get the result of the check.
Still not perfect as it just shows that the test don't trigger a non-default value, not that the replaced expression is equivalent to Default::default().

Adding a table of heuristics that are known to be equivalent seems like the most immediately tractable thing.
I don't know about running the code as a way to detect this: in addition to the factors you name there it would also rely on observing all the side effects of the code.
I wondered if one option would be to look at the generated code (at some stage of the pipeline) and see if it's equivalent. If so we can be confident the mutation has no effect. However, that seems potentially pretty complicated as the code may not get inlined, or the name of the full symbol might still be present. Symbolic interpretation would be interesting but seems like a large expansion in complexity.

That would be a step beyond adding more heuristic name-based assumptions that, say, new typically means the same as default(), etc.
I think it would be important to be clear what properties we are attributing to "simple enough" expressions.
One option is "any simple expression probably has the same value as one of the generated default values", so mutating it is likely to be a false positives, i.e. FooBaz::bar(18) is probably the same as Default::default(). That seems unlikely to be true in general, and I'd hope we could minimize this by recognizing cases. The point of function calls is generally to return a non-default value or to have a side effect.
Or, you might be saying that "sufficiently simple expressions are self evident and unlikely to have any bugs, so it's fine if they're not tested."  It's probably true that complex code is more likely to have bugs than simple code, but I don't think I'd go that far. For example if you have a function that returns a static string, and no test depends on the value of the string, I think that's worth at least thinking about. Conceivably we could have a default-off option to skip simple functions.
I think the way forward is to accumulate some examples from real code that show a significant number of uninteresting false positives and then think about how to reduce them.

That's an important distinction. I think the result ends up having some benefits from both categories.
There are often values that aren't critical. Maybe I have a timeout somewhere and it isn't important if it is 10s or 15s. I don't necessarily need a test. That being said in most cases 0s is bad, but putting a test >5s seems silly. This is sort of your "unlikely to have bugs" point. In general I am not very interested in writing tests that just assert values of my "constants" (which may be calculated via functions or similar). But of course there are always cases where it does make sense (maybe the calculation of that constant is in fact complex, even if the local code is just gen_constant().
Another part of it is that in many cases I would prefer to avoid false-positives. Especially if I am new to mutation testing I might want to get more significant results. Although it may also be worth having these often false-positive available in some modes or similar for those who really want to audit and consider a long list of results. This leans more towards the first category of there is a decent chance that this is a default value or in some ways just as valid as the default value, so maybe it makes sense to suppress the possible false-positive.
Overall I think the main reason I think this may be a viable approach is the latter. Simple constant-looking expressions are less likely to be bugs and less likely to be worth testing so are false-positive prone. Whether or not they are equal to the default value is somewhat beside the point.
Seeing more examples is definitely a good idea. Then patterns can be drawn.

Another part of it is that in many cases I would prefer to avoid false-positives. Especially if I am new to mutation testing I might want to get more significant results.

I think this is the more important consideration, and I’ll further propose that cargo-mutants should by default not mutate simple functions (if there is a workable automated definition of “simple” to apply here). My experience is that there‘s a lot of small functions that don’t feel worth writing tests for, because there is a sense in which the most reasonable test would be just reiterating the function’s code, and cargo-mutants would be a more useful tool — providing more value for the effort of running it — if it produced “more significant results” by default (and those more significant results might suggest better tests to write which end up incidentally testing the simple functions; e.g. getters might be tested as a consequence of testing the output of an algorithm that produces the struct having the getters).
Perhaps in this mode, if all mutants are caught (or even  unconditionally), it could then print something like “123 mutations were not performed because they were presumed false-positive-prone. Run with --include-simple-functions to try these too.” — so that users can learn how to increase the coverage if they want to and when it’s a good time to do so.

If you did not see it you might read https://mutants.rs/goals.html about my overall thinking on this balance.

My experience is that there‘s a lot of small functions that don’t feel worth writing tests for, because there is a sense in which the most reasonable test would be just reiterating the function’s code... and those more significant results might suggest better tests to write which end up incidentally testing the simple functions; e.g. getters might be tested as a consequence of testing the output of an algorithm that produces the struct having the getters

I'd agree I wouldn't want to steer people towards writing unit tests for trivial functions that just recreate the code. (I wouldn't want that even regardless of mutants; those tests can if taken to extremes just make the program needlessly hard to understand and change.)
But, I'd be wondering why mutating those functions does not cause a larger test to fail. As you say: writing a test for a getter might be boring; but if the getter always returns None and no test fails that's interesting. Writing a test that checks fn timeout() { 5 } function might be boring, but if no test fails when the timeout is literally zero that seems surprising.
(Also: why is the hypothetical timeout a function not a const/static if it's always the same? If it actually reads from config or an environment variable, maybe that should be tested?)

why is the hypothetical timeout a function not a const/static if it's always the same?

In my case this was a trait method. The trait has it as a method in case it isn't possible to be const/static (Rust is pretty particular about what can be) but the implementation isn't.


dlb:add initcontianer to plugin

initcontainer enables vfs and configures vfs

every 2nd pf is used for configuring vfs
the number of vfs per pf can be configured by users (default:1) add dlb-initcontainer kustomize overlay
update CRD to have initImage
implment operator to run initcontainer
update e2e test to run initcontainer overlay
update envtest to test initimage

Codecov Report

Merging #63 (5b3929f) into main (e80d06b) will decrease coverage by 0.40%.
 Consider uploading reports for the commit 3af79e1 to get more accurate results

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   51.19%   50.79%   -0.41%
==========================================
  Files          41       41
  Lines        4551     4607      +56
==========================================
+ Hits         2330     2340      +10
- Misses       2088     2132      +44
- Partials      133      135       +2

Impacted Files
Coverage Δ

pkg/controllers/dlb/controller.go
17.35% <23.80%> (+0.43%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


How to use this script in version 0.7.3 of the engine

Describe your problem here.
There is a mod that makes a video become a background but in the most updated version of the engine the game gives the error
" ERROR ON LOADING (mods/scripts/script.lua): SScript: 000: Tried to access a null variable bitmapDATA"
I wanted to know if any code was changed or something
The script works perfectly in version 0.6.3 of the engine
https://gamebanana.com/mods/426880 (script link)

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

get the updated version on psych discord server

get the updated version on psych discord server

I have the latest version of psych but I wanted to know how to port the script using the new versions of HaxeCode


CLOUDP-263212: Add unit test for OpenAPI to Collection conversion

Proposed changes

Add Bats to dependencies
Add test that:

Runs convert-to-collection.sh on example input
Compares the output to correct Collection file (ignoring randomly generated fields like id's)

Update README to be in line with current bash scripts

Jira ticket: CLOUDP-263212
Checklist

[x] I have signed the MongoDB CLA
[x] I have added tests that prove my fix is effective or that my feature works

Further comments

[Post Discussion with Matt] The tests look quite fragile. Will look into using Spectral as an alternative


Create docs directory for v3.9

[ ] Tests
[ ] Documentation
[ ] Release note

None required

Deploy preview for calico ready!
Built with commit 674689e2a44cc29639e2f8f149097d53be7bde08
https://deploy-preview-2836--calico.netlify.com


PR: Make --test mode start in a clean config directory like with Pytest

Pull Request Checklist

[x] Read and followed this repo's Contributing Guidelines
[x] Based your PR on the latest version of the correct branch (master or 3.x)
[x] Followed PEP8 for code style
[x] Ensured your pull request hasn't eliminated unrelated blank lines/spaces,
modified the spyder/defaults directory, or added new icons/assets
[x] Wrote at least one-line docstrings for any new functions
[x] Added at least one unit test covering the changes, if at all possible
[x] Described your changes and the motivation for them below
[x] Noted what issue(s) this pull request resolves, creating one if needed
[x] Included a screenshot, if this PR makes any visible changes to the UI

Description of Changes

Thanks to @bcolsen for his detailed report leading to this PR.
Currently, passing the --test flag to bootstrap.py just sets the SPYDER_TEST env variable which instead tells spyder to not load and save the user's individual settings file, e.g. spyder.ini, while not affecting handling of anything else inside for spyder-py3 directory, including the history logs for the normal and internal consoles, along with your pylint, profiler, working dir, help, and online help histories, your language and rope settings, any third party plugins you may have installed, and your default temp.py and template.py (new file template) files. Obviously, this is not particularly desirable for most testing scenarios—one would want "clean" to be truly "clean", without such cruft.
Therefore, this PR just makes --test set the Spyder config dir to a clean temp one, just like SPYDER_PYTEST currently does. It also makes sure to clean the current temp directory if one exists, removes the old, unnecessary code to just load a clean config file, and does some minor cleanup immediately around changed lines.
It seems its not really possible to include a unit test for this as the Pytest suite already does this anyway, and has other checks for it, if its otherwise even really possible to test for.
Issue(s) Resolved

Fixes #7112

Hello @CAM-Gerlach! Thanks for submitting the PR.

In the file bootstrap.py, following are the PEP8 issues :

Line 25:1: E402 module level import not at top of file

Wrt @pep8speaks , I was just following the convention already in the file for all other spyder imports, it is likely needed for safety, and I added # analysis:ignore for a good measure.

I tested it on my home computer and it seem to work well.
I'll test it a work tomorrow against the 10 mb history.py :-)

I'll test it a work tomorrow against the 10 mb history.py :-)

I'm not sure I understand how the size of any history.py file in the normal Spyder config dir would have any effect on --test mode whatsoever. Either it works (using the temp config dir), or it doesn't (it still uses the main one), which would be obvious already on your home machine assuming you had anything at all in the history before.

Sorry bad joke! You are right the file size would clearly have no affect.
I just had another idea.  We could add this to the main Spyder executable as well to make trouble shooting easier.  This would be like having a "safe mode" like Firefox has. It's like testing a Spyder reset, but if it doesn't fix the problem you don't lose your settings. We could even call it --safe-mode.

Sorry bad joke! You are right the file size would clearly have no affect.

I've certainly had more than my share of those, so I'm not one to talk...

I just had another idea. We could add this to the main Spyder executable as well to make trouble shooting easier.

Great idea! Shouldn't be hard to do; the only thing is that normal Spyder and bootstrap.py use two separate argument parsers, so we'd have to either stick it in both (very easy to do, but not exactly DRY) or refactor that, and move the small block of code that wipes the temp config to near the beginning of start.py. @ccordoba12 , agree?

The broader change I would suggest is unifying the bootstrap parser into the main cli_options get_options() parser since the great majority if not all of their options are useful to either start mode; in particular, this relates to your #7123 , since you can't actually set spyder --debug with normal Spyder even though that's what we've been telling a lot of users to help figure out problems (we've instead had to have them manually set the SPYDER_DEBUG environment variable to 3, in a platform unportable way).
If we needed a few different options for each, we could either add an parameter to get_options() in cli_options to tell it which set of extra options to add, or we could just add them to the parser returned by get_options() in start.py and boostrap.py respectively. Then, the only other thing we'd need to change is to have start.main() take one parameter, options or the like, with a default value of None that bootstrap.py could pass the rest of the parsed options that start.py would need, and then enclose the current parser block in start.py with if options is None: which would replicate the current behavior by default.
However, the one complexity here is that Spyder 4 was converted over to use argparse, while Spyder 3 is still stuck on the deprecated argparse, which will make more complicated, at least for @ccordoba12 when merging it to master. We could do this just in master, but since its not really a feature but rather an important change helping users find and solve bugs and problems, and would make our lives a good deal easier maintaining Spyder 3, I would think we would want to get it out to them as soon as possible. So, we can either keep things using the deprecated optparse in Spyder 3 and Carlos can fix any conflicts merging to master, or as part of this we can backport the argparse change.
@ccordoba12 , opinions? I italicized the two portions most in need of your input so you could find them easily.

This would be like having a "safe mode" like Firefox has. It's like testing a Spyder reset, but if it doesn't fix the problem you don't lose your settings. We could even call it --safe-mode.

We're using pytest for this, so this we'll need to improve our current implementation.

The broader change I would suggest is unifying the bootstrap parser into the main cli_options get_options() parser since the great majority if not all of their options are useful to either start mode

I don't know about this. I'll have a PR with this change, but the initial idea behind different cli options for both is that boostrap options don't apply to the main Spyder script and vice versa.

I didn't mean to have this setting for unit testing but as a convenient way for users with bugs to troubleshoot their local install problems without deleting all their settings

I understood that. So, if we want to add an option to use a clean prefs directory as part of a regular Spyder installation, we'd need to not use pytest for the implementation because then pytest would become a Spyder dependency, and we don't want that.

Sorry for my confusion. I get it now, thanks.  It will require more work than I thought.

So, if we want to add an option to use a clean prefs directory as part of a regular Spyder installation, we'd need to not use pytest for the implementation because then pytest would become a Spyder dependency, and we don't want that.

Good point, I didn't think of that. In fact, since pytest (and py, which is also needed) aren't dependencies for a basic source install either, even in its current form its a problem.
However, upon further investigation, it actually would be quite simple (and both in scope and necessary for just this PR even, given the above) as well as probably optimal overall to just reimplement the two relevant functions (one from pytest and one from py), because both packages are imported locally just for those two functions and used nowhere else in the file, and both functions are just one-line thin wrappers around standard library functions;

py.path.local.get_temproot() is a oneliner that just imports tempfile,  calls tempfile.gettempdir() and then casts it to a py.path.local convenience wrapper, which in our code is then immediately casted back to str making it pointless and wasteful to use the wrapper instead of just tempfile.gettempdir() directly.
_pytest.tmpdir.get_user is a private (so should we even be relying on it?) wrapper for getpass.getuser() that just calls it in a try-except block, returning None if it doesn't work due to a narrow set of conditions (Windows + a tox based CI that strips env variables). It would be trivial to include just try-except in base.py, if it is even really necessary in our use case, or even including the user name to begin with—on Windows, the one platform where the standard library get_user() could fail, each user has their own temp directory such that including the username is unnecessary anyway

Therefore, I'll implement those two minor changes here, and we can go from there.

I'll have to see a PR with this change, but the initial idea behind different cli options for both is that boostrap options don't necessarily apply to the main Spyder script and vice versa.

I'll submit a separate issue and PR. Looking through the existing CLI options for normal Spyder, it looks like pretty much every single one of them would be applicable to boostrap.py as far as I can tell; on the other hand, two of the six in bootstrap.py's are identical to those in cli_options, (show and hide console), two would be very useful to have there (test and debug), and two are bootstrap specific (no-apport and gui).
Therefore, would seem the best course of action might be to add the two commonly useful ones to cli_options, do a small refactor to get_options so it returns the parser rather than the evaluated options (its only one extra line, and IIRC a best practice anyway), and then add the two extra options in boostrap.py, passing the evaluated options on to main(). All in all, maybe a dozen lines worth of changes.

Okay, I implemented what I discussed in the first part of previous post to remove the dependencies on py and pytest in the relevant portions; overall its actually a small net improvement to do so even aside from the proximate reason. I tested it with and without clean, doing various activities in Spyder and restarting several times, and everything related to the change works well. Therefore, this PR looks ready on my end.
With regard to the second point, I figured out it already works to call bootstrap.py --clean -- --spyder-options-here so there seems little point to doing most of what I suggest above. However, this just means we can move debug and clean over to the main parser, handle them appropriately in start.py and/or mainwindow instead of boostrap.py, and be done with it—I'll just need to make sure they "stick" before they're needed. I'll open another issue/PR to take a crack at that.

I tested this and it works on linux :+1:

@ccordoba12 Addressed your comment; thanks.

I left several new comments because I don't like --clean as an option.

Ok, no problem. Good catch!


NEXT-8428: Add customer link to customer overview

1. Why is this change necessary?
To make it easier for admin user to find/edit the user of an order
2. What does this change do, exactly?
It adds a router link wrapped around the name of the customer in the order overview
3. Describe each step to reproduce the issue or behaviour.
Open order overview and click on the customer name
See:
https://vimeo.com/418368609/a556913058
4. Please link to the relevant issues (if any).
https://github.com/shopware/platform/issues/802
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

don't forget to add Fixes #802 to your commit message, to close the issue automatically :wink:

@mitelg Fixed by add Fixes #802 to the commit message of this fix.
yo dawg - I heard you like fixes. so I put fixes in your fixes so you can fix while fixing fixes.

I would add an entry in the Changelog 🙂

@jleifeld Done :)

QA approved :heavy_check_mark:

@t2oh4e please rebase your branch, as it has merge conflicts after the first PRs got merged :see_no_evil:
also it seems that you have not signed the CLA yet?

@mitelg Conflicts fixed. CLA signed (I was pretty sure I did that already)

thanks for your contribution @t2oh4e :+1: :tada: :blue_heart:


ci: Could we have a pre-push hook to run checks

Forgetting about running the Rebar3 check alias can happen to anyone and explicitly add on the README that we should always do that before contributing... I would forget anyway. Having a pre-push hook feels fair enough to me and would help on keeping the commit history cleaner.

Also, for people not wanting to fix whatever might make the check fail, there's an option ( :mage_man:  that I will not name here) for git push to skip pre-push hooks.

I've been thinking about this for a while and would avoid it, at least for now. I've read several online discussions on the pros and cons and found no compelling reasons to add pre-push hooks to the repo. As we are a little team of contributors, I would suggest that each one maintain its hooks, at least for the moment.


[Feature Request]: azure firewall module support for Hub Deployment

Description
having been using carml modules at customer site for some time now, the azure firewall module doesnt support deployment into a virtual wan hub, although the sku parameter is provided.
would be nice to have the azure firewall module updated to include stand-alone (VNet) deployment as well as Hub deployment. For now, have made my own module and using in place of the carml module.

After an internal discussion, the idea is to keep both the managed & unmanaged firewall in one module but provide different test cases for e.g.:

Firewall min
Firewall common
vWAN Firewall min
vWAN Firewall common

This implementation will likely require a union() for the properties object (with its ups and downs)

@fblix , the duplicate is closed as completed. Can we close this one? Thanks.


Clipping planes tweaks

CC https://github.com/AnalyticalGraphicsInc/cesium/pull/6201#pullrequestreview-102883592

@likangning93, thanks for the pull request! Maintainers, we have a signed CLA from @likangning93, so you can review this at any time.
:warning: I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:

Discussion offline, might be better to move the "many clipping planes" demo to Terrain Clipping Planes and remove the drawing portion.

It might make sense to move ClippingPlane to Scene as well.

I'm not sure when the bug was introduced, but in 3D Tiles ClippingPlanes if you select the model and then uncheck Enable edge styling there is an error in the console: Uncaught TypeError: Cannot set property 'edgeWidth' of undefined (on line 200)
It looks like this is just a bug in the Sandcastle code.

Another thing to fix:
I noticed that when a model is constructed with a color the color is not getting applied, probably because recreateProgram is not getting triggered. It's also possible this worked before createProgram was split into createProgram and recreateProgram. Do whatever seems right to make the fix.

Example code:
var viewer = new Cesium.Viewer('cesiumContainer');

function createModel(url, height, heading, pitch, roll) {
    var origin = Cesium.Cartesian3.fromDegrees(-123.0744619, 44.0503706, 0.0);
    var modelMatrix = Cesium.Transforms.headingPitchRollToFixedFrame(origin, new Cesium.HeadingPitchRoll());

    var model = viewer.scene.primitives.add(Cesium.Model.fromGltf({
        url : url,
        modelMatrix : modelMatrix,
        minimumPixelSize : 16,
        maximumPixelSize : 256,
        color : Cesium.Color.fromAlpha(Cesium.Color.BLUE, 0.85),
        colorBlendMode: Cesium.ColorBlendMode.HIGHLIGHT,
        silhouetteColor: Cesium.Color.fromAlpha(Cesium.Color.YELLOW, 1.0),
        silhouetteSize: 2.0
    }));

    model.readyPromise.then(function(model) {
        var camera = viewer.camera;

        // Zoom to model
        var controller = viewer.scene.screenSpaceCameraController;
        var r = 2.0 * Math.max(model.boundingSphere.radius, camera.frustum.near);
        controller.minimumZoomDistance = r * 0.5;

        var center = Cesium.Matrix4.multiplyByPoint(model.modelMatrix, model.boundingSphere.center, new Cesium.Cartesian3());
        var heading = Cesium.Math.toRadians(230.0);
        var pitch = Cesium.Math.toRadians(-20.0);
        camera.lookAt(center, new Cesium.HeadingPitchRange(heading, pitch, r * 2.0));
    }).otherwise(function(error){
        window.alert(error);
    });
}

createModel('../../SampleData/models/CesiumMilkTruck/CesiumMilkTruck.glb');

@lilleyse updated! Color on model construction should be fixed too.

Just those small things. Otherwise looks ready to go.

@lilleyse updated!

Ok looks good. Thanks for all the changes!


Adding Contact Us page.

Hello @apoorvaron  ,
I would like to design the frontend of contact us page which will help the user to contact or share their experience with the owner of the website easily. This will help to enhance the user experience.
The page will have a form which collects necessary details like email address, mobile number, message, etc.
Please assign me this issue.
I would like to work on this issue under GSSOC'23.

Okay Sure ! You can work on this

@apoorvaron Thank you for assigning me. Can you please let me know if there any specific requirements that I should keep in mind will working on this issue?

@kasturimandlik Just Add contact Us page and store the user data in the MySQL DB.

@apoorvaron I will fulfill the requirements mentioned. Can you please give me some time as i have my exams going on?

@kasturimandlik Sure

@kasturimandlik Are you still working ?

@apoorvaron Yes, I am working.

@kasturimandlik When will it be completed ?

I have designed the page and finished with the frontend part of it. Can you please review it?

@kasturimandlik It is too simple

@kasturimandlik Closing this issue
Reasons

too simple
Din't code
Inactive Contributor


Reversed (Lon/Lat) coordinate input not accepted by Distance Direction starting point box

While checklist testing the coordinate conversion tool, I used this test pair:
20.82S 45.47E and 45.47E 20.82S.
The second of these (45.47E 20.82) is rejected by the input box of the Distance and Direction Line tool.

Shouldn't the same code from CC work in this input box?
Testing with ArcMap 10.6, (8184) and Military Tools 2.0

This issue was moved to Esri/distance-direction-addin-dotnet#467


most-subject/dist/most-subject.js not working in browser

I used most-subject successfully in the past. Then I switched to xstream for a while. Now I am trying to use most-subject version 4.02 but it won't load when I try it in Chrome. I am bundling with Webpack. I moved the whole npm package into bower_components because I need to get node_modules out of the way when I compile the server. I started out with just the /dist/most-subject.js file in bower_components and get identical results to the ones shown here. This is a screen shot of the top of of the Chrome console log:

Here is line 9876 of the of the Webpack bundle:

And here is line 9832

The most relevant line seems to be line 7434. Here it is:

This is a screen shot of my index.html file:

That's for all of this, I'll try to look into it very soon!

Thanks. By the way, I have a function something like this:
function f(string) {
    var _this = this;
    this.id = string;
    this.stream = some stream;
    this g(x) {
        put x into _this.stream;
    }
}
var instance = new f;

I did this with most-subject and xstream, but I could not find a way to do it with most. If you, or anyone reading this, happens to know how to use most in this way, I would much appreciate your telling me. most uses most-subject, so I keep thinking the technology is somewhere inside of most.
Cheers!

So I think the issue is right in my face: https://github.com/TylorS/most-subject/blob/master/dist/most-subject.js#L4
The usage of most.defaultScheduler is not something that is accessible via the most builds currently.
I might backtrack and use browserify or something else and do separate builds of for node/browser

UPDATE:
I don't know if this helps; but for what it is worth, I tried most version 18.8 and got this:

Hey @dschalk As soon as  https://github.com/mostjs/prelude/pull/8 gets merged, I have a rewrite in TypeScript with a new build system that should fix this issue. Hopefully by the end of the night :)

Thanks. I am eager to switch back to most-subject.
The new version does not crash the browser or give any error messages. The new version's API is different from what I remember so I am experimenting. As I recall, subject() returned an object with a "stream" attribute, but that isn't the case now.
I am experimenting with the return value of mostSubject.subject in my Chrome console log. When I run s =  mostSubject.subject(), I get an object with many methods, including "next" and "observe". So far, I have gotten no results and no error messages. Obviously I am missing something.
So, naturally, I clicked the link to https://tylors.github.io/most-subject/doc, but the page is not there. Chrome displays the 404  "File not found" page.

The APi has channged with v4 - thanks for pointing out that there are issues with the docs as well. I'l ltry to get that fixed as well.
In the mean time, the API is as follows
- const {observer, stream} = subject()
+ const stream = subject()

stream.observe(x => console.log(x)

- observer.next(1)
+ stream.next(1)

- observer.error(new Error('error'))
+ stream.error(new Error('error'))

- observer.complete()
+ stream.complete()

http://codepen.io/TylorS/pen/rLNgrZ?editors=0010

Thanks again. The example is just what I needed.

:+1: I'll close this then. Feel free to reopen if its needed

I think the issue is resolved, so I am not trying to reopen it. I am writing this to say that I don't think "then" is working in the example you gave me. When I run the code shown below, the output remains the same: three results, no result repeated.
stream.observe(x => console.log(x))
  .then(x => console.log(x))
  .then(x => console.log(x))
  .then(x => console.log(x))
  .then(x => console.log(x))
  .then(x => console.log(x))
  .catch(e => console.error(e))

stream.next(1)
stream.next(2)
stream.next(3)
stream.complete('complete')

Browser console:
1
2
3

Strange indeed, I'm not getting the same behavior here :/

Does it print each number twice? It only prints the numbers once for me. I don't need next right now, but I thought I should tell you what I got when I ran the code. I expected it to log a number once when the promise resolved and again on the call to "next".
I made the transition from xstream back to most-subject. My app is running flawlessly (as far as I can tell, anyway) at http://schalk.net:3055.

They print just once for me as well. then() is only called on complete() which is the same behavior the most has itself.
I'm curious, are you using most-subject for the ability to imperatively call complete()?

No. Here is the story:
My app runs online at http://schalk.net:3055. The repo is at https://github.com/dschalk/JS-monads-stable. In the repo at /client/monad.js there is this:
var MonadStream = function MonadStream(g) {
  var _this = this;
  this.id = g;
  this.stream = mostSubject.subject()
  this.ret = function (a) {
    _this.stream.next(a);
    console.log('in ' + _this.id + ' emmitting ' + a);
    return _this;
  };
};

var mM$1 = new MonadStream('mM$1');

And one of its uses is (in /client/main line 626) is this
  const mM$1Action$ = mM$1.stream.observe(v => {
      console.log('In mM$1Action$. v is: ', v)
      O.mMindex2.bnd(inc, mMindex2);
      O.mMallRolls.bnd(spliceAdd, O.mMindex2.x, v, mMallRolls);
      mMcurrentRoll.ret(v);
      document.getElementById('0').innerHTML = (O.mMallRolls.x[O.mMindex2.x])[0];
      document.getElementById('1').innerHTML = (O.mMallRolls.x[O.mMindex2.x])[1];
      document.getElementById('2').innerHTML = (O.mMallRolls.x[O.mMindex2.x])[2];
      document.getElementById('3').innerHTML = (O.mMallRolls.x[O.mMindex2.x])[3];
      cleanup(7)
  })

I tried to define MonadStream using only most and was unable to come up with an algorithm that worked. I think I could define MonadStream with RxJS and Bacon, and I have successfully done so with xstream and most-subject.  Now that the state of my monads is in the mutable global object "O", the slickest solution might be to use ordinary monads defined by Monad (in /client/monads.js at line 49) and the ordinary "ret()" method, which mutates "O" and automatically runs every expression observing it. There's a spreadsheed-like calculator in the online app at http://schalk.net:3055, demonstrating that this works.
I keep thinking that there must be a way to define MonadStream with most. That's why I asked if anybody knows how to do it in the off-topic comment above. The tools don't seem to be in the most API, so I think I would need to study and understand the most code. That would be a project for me.
I am awe-struck by Motorcycle.js, My monad experiments thrive in Motorcycle. I am using most-subject for streaming mostly because I feel so comfortable in the environment that you and your collaborators have created.


Fixed the navbar for responsive view.

Description
I have made a completely responsive and properly aligned navbar for various devices.
I have added a hamburger icon which on click has a toggle effect on the navbar.
Related Issues
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Closes #611

Type of PR

[x] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]

https://github.com/Anishkagupta04/RAPIDOC-HEALTHCARE-WEBSITE-/assets/143121854/10361a19-2810-4a0a-9f26-eff9417de9ec
Checklist

[x] I have gone through the contributing guide
[x] I have updated my branch and synced it with project main branch before making this PR
[x] I have performed a self-review of my code
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

@meetarora10 Resolve conflicts

@varshith257 resolved

@meetarora10 Rather than in the center can you put the navbar items to the left and also give some consistent spacing among them

@varshith257  I have aligned navbar items in the left and also added some spacing as you said.

@varshith257 please review this PR.

@meetarora10 Can also give consistent space among the button and text in every navbar item?

@varshith257 I will add more space then.

@varshith257  please review and merge this PR so that I can create other issues and work on it.


[ NEW PAGE ] DIY Readout Error Mitigation

Note: on hold until we figure out where in docs to put this and overall patterns structure
the new primitives won't include automatic readout error mitigation, so it would be good to include a docs page to show users how they can do it themselves

We won't be able to include a code example until https://github.com/Qiskit/qiskit-aer/issues/2078 is resolved.

Oh, actually, we could do it using local testing mode once qiskit-ibm-runtime 0.22 is released.

Closing since this content will be on the learning platform instead.


Hide/Show option

For hiding or showing some parameters.
Also add FileNameExtension
Example for showing "filename.ext" instead of "C:\Downloads\filename.ext"
mediainfo --HideParameter=General_CompleteName --ShowParameter=General_FileNameExtension

Very cool!
On 6 Mar 2018 6:45 pm, "Jérôme Martinez"<EMAIL_ADDRESS>wrote:

Merged #795 https://github.com/MediaArea/MediaInfoLib/pull/795.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MediaArea/MediaInfoLib/pull/795#event-1507223900, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABEyvmjZi5KrBJPshQxZagwVld9eTW5Mks5tbtlQgaJpZM4Sa5NK
.


x/net: h2c package uses obsolete upgrade mechanism

x/net/http2/h2c package uses HTTP Upgrade headers based mechanism to determine if a connection should be upgraded to h2c.
This mechanism was deprecated by RFC 9113 https://datatracker.ietf.org/doc/html/rfc9113#name-http-2-version-identificatio
Perhaps it makes sense to leave the functionality as is to not break existing clients (?) but would be good to maybe mention the deprecation in code comments and rewrite the other comments that refer to the obsolete RFC 7540 to refer to sections in RFC 9113

The "h2c" string was previously used as a token for use in the HTTP Upgrade mechanism's Upgrade header field (Section 7.8 of [HTTP]). This usage was never widely deployed and is deprecated by this document. The same applies to the HTTP2-Settings header field, which was used with the upgrade to "h2c".

This usage was never widely deployed I'm not sure If I fully agree with that, h2c seems to be used all over the place
I guess a clarification about it being obsolete and mentioning the  RFC9113, which is the authoritative source.

cc @neild @tombergan


error in merge_retrieval_results_by_score

A functionsrc/openmatch/retriever/dense_retriever.py -- split_retrieve -- merge_retrieval_results_by_score could not work properly when I tried to use partition to do retrieval task.

#108 the function has been fixed in this pull request.

Thank you for your contribution!


Generate initial version

💡 Summary
When a new repository is being created from the skeleton, the skeleton's version number should be ignored and be replaced with a standard initial version such as 0.0.1.
Motivation and context
Each skeleton repository has its own version. If a new repository descends from a skeleton it should not inherit the skeleton's version number and should start from a new version number such as 0.0.1.
Implementation notes
The bump_version.sh script could possibly be used to implement this feature, if that script was modified to force the version to a specific version (in this case, it would set the new repo's version to 0.0.1, regardless of what the skeleton's version was).
Acceptance criteria
The script should be able to do what is discussed.

[ ] When gh-skeleton clone is run, the newly-created repository is initialized to the standard version number (e.g. 0.0.1) rather than inheriting the current version number of the parent skeleton.

This would be a nice improvement.

If a repository has a bump-version script you can expect to get the list of files that use the version of the project with bump-version --list-files once it has been implemented.