Support for multiple vault paths with environments

Hi, I'd like to support using vault items that are nested at arbitrary levels of depth.  Since this would introduce some ambiguity, I'd propose it works as follows:

For each of the current items we load (application, application,env, project-name, project-name,env), load all key/value pairs.
Enumerate the children items (these end with a /) using LIST, and load each that we have access to the same way.

The end result would be that items at deeper levels would override key/value pairs at higher levels.
Example:
/secret/application:

api.clientId=AAAAA
api.clientSecret=BBBBBB
api.username=ursula
api.password=lucky7s

/secret/application/api:

username=jethro
password=snakeeyes

I know there is some work going on to centralize spring's vault integration, so where would be the best place to implement this? Also, does the idea line up with the way you all use this facility?

Do you mean applying recursion to each Vault context path we determine and picking up these properties?
Spring Cloud Vault takes a distinct approach to selectively pick paths that match the default context and the application name combined with activated profiles. I'm not sure about the benefits compared to the added complexity. Spring Cloud Vault is currently in charge of the rules which paths are accessed. By changing to recursive scanning, the paths would also depend on the content stored in Vault.
You can enable fetching of deeper elements by enabling profiles for your application. Taken your example:

/secret/application is fetched by Spring Cloud Vault
If you enable a profile named api, Spring Cloud Vault would also fetch /secret/application/api

Beyond that, you can add Vault PropertySources on your own and control which one takes precedence (see https://gist.github.com/mp911de/17f550ffecdc9e8f22061bfdf896bbb4 and #58).

Thanks, I didn't think of using profiles that way.  I think they do get me secret isolation, which is the main thing I want to accomplish. The limitation is that we lose the notion of "environment", since we only get one profile at a time. The recursion idea might not be necessary, if there's a simpler way to do it.
Here's a description of what I'm trying to do. I welcome input on how to do it, and if it's even a good idea!
Goals:
I have a number of services that interact with a number of systems.  Each service has access to one or more systems, and most systems are accessed by multiple services.

Secrets for each system are stored in vault only once, at a canonical path.
Services are authorized to read only the secrets they need, in their current environment
Services use @ConfigurationProperties(prefix = "systemName") to access the secrets they need.

Idea 1
My first idea was just to extend paths from what spring-cloud-vault-config already uses. /secret/application/api and /secret/application/loadtest/api might each contain secrets, and services would access them through a bean like this:
@Component
@ConfigurationProperties(prefix = "api")
public class Api {
    String clientId
    String clientSecret
    String username
    String password
}

Assuming the service activates the loadtest profile, it should get the secrets from /secret/application/loadtest/api. In Vault, the service would be associated with a policy that selectively allows read capability to the necessary secrets:
path "/secret/application/loadtest/api" {
  policy = "read"
}

Idea 2
Another method might be to make the first component of the path be the system name, and use it as the default context.  If there were a list of paths in bootstrap.yml, we could create a composite property source that searched all of them using spring-cloud-vault-config's current locator logic. That would look like this, assuming the "dev" profile:
bootstrap.yml:
spring:
  cloud:
    vault:
      secrets:
        - api
        - rabbit
        - db/orders

secrets would be loaded from these locations if they exist:

secret/api/dev
secret/rabbit/dev
secret/db/orders/dev

In the spring cloud config client we support comma separated names. See https://github.com/spring-cloud/spring-cloud-config/issues/618.
So I'd go with something closer to "Idea 2". The analogous property here would be spring.cloud.vault.generic.applicationName. It defaults to spring.application.name.

I'm going to take a run at this using @spencergibb's suggestion, and report back soon

It doesn't support that mode of operation yet. It would be similar to idea 2 that needs to be implemented.

Right, sorry that was vague.  I'm going to try to implement it and see if it works in my application, and either report back here with more discussion or a pull request. :)

Great!

We are using the generic backend with KV (version 1).
We have a scenario where we pull secrets that happen to have the same keys. For example, these paths both have the secret key "username":
secret/database/A
secret/database/B
When we use the each as a list in spring.application.name:
spring.application.name = database/A, database/B
The "username" value from database/B overwrites the "username" value from database/A.
How can we reference both sets in the properties files?
Other clients actually force you to map a property to a secret, IE:
dba_username = secret/database/A#username
dbb_username = secret/database/B#username
Also, is it possible to have multiple spring vault configs? Meaning, we pull secrets from two different sources (vaults), but would also need to reference then individually as well.

By registering a VaultConfigurer, you get full control over which context paths get loaded (see https://cloud.spring.io/spring-cloud-vault/1.1.x/multi/multi_vault.config.backends.configurer.html). You can also provide a PropertyTransformer (see PropertyTransformers) to e.g. prefix incoming keys per backend.


How to reproduce SSD+?

I only saw SupCE mode for using label information, but I wonder if SSD+ can be reproduced using this code base?

Hi! I'm wondering the same question too! I saw that in losses.py, the SupConLoss seems probably able to reproduce SSD+ if labels are provided, but I'm not quite sure. Correct me if I'm wrong! :)

Indeed, when labels are provided, the SupConLoss is used to train SSD+ models.


RD Web Client Support

This article states that you can use this method to publish RDS and use the RD Web Client to access RDS resources, however the article here: https://docs.microsoft.com/en-us/windows-server/remote/remote-desktop-services/rds-supported-config#using-remote-desktop-services-with-application-proxy-services states that you cannot use the web client when publishing with AD Application Proxy - please could you clarify and update one of the articles accordingly?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 18fcb539-bdbd-068d-46c0-44058146031e
Version Independent ID: 15e99611-e40e-310c-1625-9e76b27cfe99
Content: Publish Remote Desktop with Azure AD App Proxy
Content Source: articles/active-directory/manage-apps/application-proxy-integrate-with-remote-desktop-services.md
Service: active-directory
Sub-service: app-mgmt
GitHub Login: @kenwith
Microsoft Alias: kenwith

@James-MCT Thank you for pointing that out . We will involve the content authors on this and update the thread.

We're working with the RDS team to get their help updating their docs.

I submitted a PR to update the referenced doc that web client is supported now. Here is the announcement I referenced in the PR: https://techcommunity.microsoft.com/t5/azure-active-directory-identity/azure-ad-application-proxy-now-supports-the-remote-desktop/ba-p/1257367

@James-MCT - thank you for catching this and taking the time to open the issue. I missed it. I know it takes time to login to GitHub and open an issue and write it up and I very much appreciate it. :)

#please-close


[R-package] Added instructions for generating R test coverage

Really excited to say that I've discovered that covr (the most popular library for generating test coverage for R projects) now works well with lightgbm's R package! I had created jameslamb/lightgbm-r-coverage  to work around the previous issues I had and I am VERY excited to archive that repo.
In this PR, I propose adding instructions to the R package's README explaining how contributors can generate coverage reports. I think this will be a valuable way for us to catch edge cases that are not covered by our current tests, and all the other good things you can do with code coverage.
At the time of creating this PR, the R package is 64.48% covered.
lightgbm Coverage: 64.48%
R/lgb.plot.importance.R: 0.00%
R/lgb.prepare_rules.R: 0.00%
R/lgb.prepare_rules2.R: 0.00%
R/lgb.prepare.R: 0.00%
R/lgb.prepare2.R: 0.00%
R/lgb.unloader.R: 0.00%
R/readRDS.lgb.Booster.R: 0.00%
R/saveRDS.lgb.Booster.R: 0.00%
R/lgb.cv.R: 57.14%
R/lgb.Predictor.R: 57.66%
R/lgb.Booster.R: 62.58%
R/callback.R: 67.48%
R/utils.R: 70.63%
R/lgb.Dataset.R: 72.02%
R/lgb.train.R: 75.94%
R/lightgbm.R: 95.45%
R/aliases.R: 100.00%
R/lgb.importance.R: 100.00%
R/lgb.interprete.R: 100.00%
R/lgb.model.dt.tree.R: 100.00%
R/lgb.plot.interpretation.R: 100.00%

I've attached a detailed coverage report for those who are curious (GitHub will not let you attach a .html file, so had to zip it).
coverage.html.zip

Just rebased to current master. I added two more files to  .gitignore that were missed  before.
@StrikerRUS normally I wouldn't merge  an R-package PR with only your approval but I think for this once it's ok. Do you agree?

@jameslamb

normally I wouldn't merge an R-package PR with only your approval but I think for this once it's ok. Do you agree?

Sure!


Don't reset channel state on resolver failure when LB policy exists.

cc @muxi @srini100

****************************************************************

libgrpc.so

     VM SIZE                                                                              FILE SIZE
 ++++++++++++++ GROWING                                                                ++++++++++++++
  +0.0%    +140 [None]                                                                 +1.09Ki  +0.0%
   +10%    +192 src/core/ext/filters/client_channel/resolver/fake/fake_resolver.cc        +192   +10%
      [NEW]    +171 grpc_core::FakeResolverResponseGenerator::SetFailureOnReresolution        +171  [NEW]
      +4.8%      +9 [Unmapped]                                                                  +9  +4.8%
       +12%      +6 grpc_core::FakeResolver::RequestReresolutionLocked                          +6   +12%
       +20%      +6 grpc_core::FakeResolverResponseGenerator::SetFailureLocked                  +6   +20%
  +0.0%      +4 src/core/ext/filters/client_channel/client_channel.cc                       +4  +0.0%
      +0.1%      +4 on_resolver_result_changed_locked                                           +4  +0.1%

  +0.0%    +336 TOTAL                                                                  +1.28Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

In the test I've added here, the client does have an established connection at the point at which the network goes away, so the channel is in state READY.  Once the connection is dropped, it then transitions to state IDLE.
I don't think it actually matters what the starting state is here.  The important part of the test is that when pick_first transitions to IDLE, it does not get overridden by the subsequent resolver failiure.

BTW, to be clear, in a case where there is no network connectivity to start with, then pick_first will go to state TRANSIENT_FAILURE, not IDLE.  That is the intended behavior.

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,019,988      Total (>)      2,019,964

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,183,347      Total (>)     11,183,087

 No significant differences in binary sizes

in a case where there is no network connectivity to start with, then pick_first will go to state TRANSIENT_FAILURE, not IDLE.

Wait, could you elaborate this? I guess I am a bit confused here by 'to start with'. On mobile platform when you lose connection, it's likely because you lose connectivity, and that was the original issue here: when you lose connectivity and gets it back again, there's that deadlock in TRANSIENT_FAILURE that prevents any further call from succeed.

Also, note that if there was no network connectivity when the channel first came up, then the channel would go into TRANSIENT_FAILURE due to the resolver failing, and there would be no LB policy yet, so it would stay in that state until the resolver succeeds and creates an LB policy, which would then change the state based on its attempts to connect to backends.

Wait, could you elaborate this? I guess I am a bit confused here by 'to start with'. On mobile platform when you lose connection, it's likely because you lose connectivity, and that was the original issue here: when you lose connectivity and gets it back again, there's that deadlock in TRANSIENT_FAILURE that prevents any further call from succeed.

This is exactly the case that the test in this PR covers: the connectivity state starts in READY, because the network connection is working.  Then the network drops, so we transition to another state.
What I meant about "to start with" is that if the network connection is not working when the channel is first created, we won't get into this state to start with, because then we will go into TRANSIENT_FAILURE due to the resolver failure.

Ahh that makes sense. I think it is correct behavior. Before the first connection there's no lb policy so fail_call_if_in_transient_failure is not called. No problem in this case.

****************************************************************

libgrpc.so

     VM SIZE                                                                              FILE SIZE
 ++++++++++++++ GROWING                                                                ++++++++++++++
  +0.0%    +140 [None]                                                                 +1.09Ki  +0.0%
   +10%    +192 src/core/ext/filters/client_channel/resolver/fake/fake_resolver.cc        +192   +10%
      [NEW]    +171 grpc_core::FakeResolverResponseGenerator::SetFailureOnReresolution        +171  [NEW]
      +4.8%      +9 [Unmapped]                                                                  +9  +4.8%
       +12%      +6 grpc_core::FakeResolver::RequestReresolutionLocked                          +6   +12%
       +20%      +6 grpc_core::FakeResolverResponseGenerator::SetFailureLocked                  +6   +20%
  +0.0%      +4 src/core/ext/filters/client_channel/client_channel.cc                       +4  +0.0%
      +0.1%      +4 on_resolver_result_changed_locked                                           +4  +0.1%

  +0.0%    +336 TOTAL                                                                  +1.28Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Corrupt JSON data (indicates timeout or crash):
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10

[microbenchmarks] No significant performance differences

Known issues: #17138 #17230 #17231


ES-2053: Create wrapping objects for parameters passed into sdk functions

When you are ready, trigger this job please: https://ci02.dev.r3.com/job/Corda5/job/corda-runtime-os-combined-worker-plugins-smoke-tests/view/change-requests/job/PR-5948/

@pavelnenov-r3 re: https://github.com/corda/corda-runtime-os/pull/5948#discussion_r1542979290
(can't make a proper Reply in github UI for some reason):

members are interpolated to strings, so the CLI will accept strings.

Yes, but the way how they are interpolated to strings is not controlled by the test, that's the problem. So the test input relied on the implementation.

build e2e


Invalid schema in GetPeersResponse

The response schema for GetPeersResponse is invalid according to AJV
     Error: "nullable" cannot be used without "type"
      at getSchemaTypes (node_modules/ajv/lib/compile/validate/dataType.ts:26:13)
      at typeAndKeywords (node_modules/ajv/lib/compile/validate/index.ts:159:31)
      at subSchemaObjCode (node_modules/ajv/lib/compile/validate/index.ts:147:3)
      at subschemaCode (node_modules/ajv/lib/compile/validate/index.ts:124:7)

Rendered the schema looks like
                          "enr": {
                            "allOf": [
                              {
                                "type": "string",
                                "description": "Ethereum node record. [Read more](https://eips.ethereum.org/EIPS/eip-778)",
                                "example": "enr:-IS4QHCYrYZbAKWCBRlAy5zzaDZXJBGkcnh4MHcBFZntXNFrdvJjX04jRzjzCBOonrkTfj499SZuOh8R33Ls8RRcy5wBgmlkgnY0gmlwhH8AAAGJc2VjcDI1NmsxoQPKY0yuDUmstAHYpMa2_oxVtw0RW_QAdpzBQA8yWM0xOIN1ZHCCdl8"
                              },
                              {
                                "nullable": true
                              }
                            ]
                          },

Because of the allOf syntax nullable is not in the same block as type.

Hmm this looks like ajv or openapi schema bug. Afaik this is a legit way to reuse existing type and make it nullable

I checked our v.2.3.0 release against the online swagger editor and it's not raising errors - are we ok to close this issue @dapplion ?


Apply Traits to Attestation.

This works spans from https://github.com/Azure/azure-sdk-for-java/pull/26562  where interfaces to capture commonly occurring APIs at client builders has been created.

API changes have been detected in com.azure:azure-security-attestation. You can review API changes here


Chrisda

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/exchange-eop/connect-to-exchange-online-protection-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-eop/exchange-online-protection-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-eop/media/MSN_Video_Widget.gif
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/connect-to-exchange-online-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/media/0fd389a1-a32d-4e2f-bf5f-78e9b6407d4c.png
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/media/24645e56-8b11-4c0f-ace4-09bdb2703562.png
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/media/MSN_Video_Widget.gif
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/media/b85d80d9-1043-4c7c-8f14-d87d8d56b188.png
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/media/d3a405ce-5364-4732-a7bb-2cc9c678da2d.png
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/mfa-connect-to-exchange-online-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/disable-access-to-exchange-online-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/exchange-online-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/connect-to-exchange-servers-using-remote-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/control-remote-powershell-access-to-exchange-servers.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/exchange-cmdlet-syntax.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/exchange-management-shell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/filters-in-recipient-commands/filterable-properties-for-filter.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/filters-in-recipient-commands/filterable-properties-for-recipientfilter.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/filters-in-recipient-commands/filters-in-recipient-commands.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/find-exchange-cmdlet permissions.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/open-the-exchange-management-shell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/use-update-exchangehelp.md
:white_check_mark:Succeeded

exchange/docs-conceptual/index.md
:white_check_mark:Succeeded

exchange/docs-conceptual/intro.md
:white_check_mark:Succeeded

exchange/docs-conceptual/office-365-scc/connect-to-scc-powershell/connect-to-scc-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/office-365-scc/connect-to-scc-powershell/mfa-connect-to-scc-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/office-365-scc/media/0fd389a1-a32d-4e2f-bf5f-78e9b6407d4c.png
:white_check_mark:Succeeded

exchange/docs-conceptual/office-365-scc/media/24645e56-8b11-4c0f-ace4-09bdb2703562.png
:white_check_mark:Succeeded

exchange/docs-conceptual/office-365-scc/media/b85d80d9-1043-4c7c-8f14-d87d8d56b188.png
:white_check_mark:Succeeded

exchange/docs-conceptual/office-365-scc/media/d3a405ce-5364-4732-a7bb-2cc9c678da2d.png
:white_check_mark:Succeeded

exchange/docs-conceptual/office-365-scc/office-365-scc-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/overview.md
:white_check_mark:Succeeded

exchange/docs-conceptual/toc.yml
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Add-AvailabilityAddressSpace.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Add-DistributionGroupMember.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Add-MailboxFolderPermission.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Add-ManagementRoleEntry.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Add-RoleGroupMember.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Add-eDiscoveryCaseAdmin.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Clear-ActiveSyncDevice.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Clear-MobileDevice.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Clear-TextMessagingAccount.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Compare-TextMessagingVerificationCode.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Complete-MigrationBatch.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Disable-AntiPhishRule.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Disable-App.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Disable-InboxRule.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Disable-JournalRule.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Disable-MailPublicFolder.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Disable-Mailbox.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/exchange-eop/connect-to-exchange-online-protection-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-eop/exchange-online-protection-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-eop/media/MSN_Video_Widget.gif
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/connect-to-exchange-online-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/media/0fd389a1-a32d-4e2f-bf5f-78e9b6407d4c.png
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/media/24645e56-8b11-4c0f-ace4-09bdb2703562.png
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/media/MSN_Video_Widget.gif
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/media/b85d80d9-1043-4c7c-8f14-d87d8d56b188.png
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/media/d3a405ce-5364-4732-a7bb-2cc9c678da2d.png
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/mfa-connect-to-exchange-online-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/disable-access-to-exchange-online-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-online/exchange-online-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/connect-to-exchange-servers-using-remote-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/control-remote-powershell-access-to-exchange-servers.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/exchange-cmdlet-syntax.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/exchange-management-shell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/filters-in-recipient-commands/filterable-properties-for-filter.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/filters-in-recipient-commands/filterable-properties-for-recipientfilter.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/filters-in-recipient-commands/filters-in-recipient-commands.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/find-exchange-cmdlet permissions.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/open-the-exchange-management-shell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/exchange-server/use-update-exchangehelp.md
:white_check_mark:Succeeded

exchange/docs-conceptual/index.md
:white_check_mark:Succeeded

exchange/docs-conceptual/intro.md
:white_check_mark:Succeeded

exchange/docs-conceptual/office-365-scc/connect-to-scc-powershell/connect-to-scc-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/office-365-scc/connect-to-scc-powershell/mfa-connect-to-scc-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/office-365-scc/media/0fd389a1-a32d-4e2f-bf5f-78e9b6407d4c.png
:white_check_mark:Succeeded

exchange/docs-conceptual/office-365-scc/media/24645e56-8b11-4c0f-ace4-09bdb2703562.png
:white_check_mark:Succeeded

exchange/docs-conceptual/office-365-scc/media/b85d80d9-1043-4c7c-8f14-d87d8d56b188.png
:white_check_mark:Succeeded

exchange/docs-conceptual/office-365-scc/media/d3a405ce-5364-4732-a7bb-2cc9c678da2d.png
:white_check_mark:Succeeded

exchange/docs-conceptual/office-365-scc/office-365-scc-powershell.md
:white_check_mark:Succeeded

exchange/docs-conceptual/overview.md
:white_check_mark:Succeeded

exchange/docs-conceptual/toc.yml
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Add-AvailabilityAddressSpace.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Add-DistributionGroupMember.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Add-MailboxFolderPermission.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Add-ManagementRoleEntry.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Add-RoleGroupMember.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Add-eDiscoveryCaseAdmin.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Clear-ActiveSyncDevice.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Clear-MobileDevice.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Clear-TextMessagingAccount.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Compare-TextMessagingVerificationCode.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Complete-MigrationBatch.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Disable-AntiPhishRule.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Disable-App.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Disable-InboxRule.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Disable-JournalRule.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Disable-MailPublicFolder.md
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Disable-Mailbox.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix for Issue #151 - Google Credentials isinstance check

Fixed issue #151 by changing the isinstance(token, Credentials) check in _connect_token to isinstance(token, google.auth.credentials.Credentials).
This should allow support for any kind of Google Credentials object when authentication with Cloud Storage. Further testing needs to be done to confirm this, however.

I think this is the right thing to do, thank you.

No problem, thanks for merging!


added optional styling for button and pagination

I'm going to close this since it has been added now. But thanks a tonne for your contribution!


Sharing my interesting results with rectangle renderer

Hi, thanks for open-sourcing the great work, and I just wanted to share my own results.
(I think it'll be great if there's a place for users to post their own results, which will be some kind of "open gallery")
The input was my profile picture (drawn with LuaTeX+TikZ before, which imitated the JOI logo - https://git.io/vQwmS)

The progressive output was interesting; the network preferred to draw a tilted rectangle, rather than using an axis-aligned rectangle (can you think of a reason behind this?):

The final result looked like this:

Hi, thanks for your result! To generate axis-aligned strokes, we need to add a constraint on the orientation of the stroke parameters. You can try: pt.x_ctt.data[:, :, -1] = torch.clamp(pt.x_ctt.data[:, :, -1], 0, 0)
I have uploaded a demo script on this feature (see demo_8bitart.py). I have the following results on my side. You can try it and tell me whether it works fine. Thanks!

Great idea! It's working really well on my side, too. Thanks a lot.


hqplayer-desktop: update tarball location and misc improvement

Description of changes

Things done
I did not test because I have no use of this binary (and it is binary prebuilt). I grep-ed to validate path are all valid.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Fixing hqplayerd may also be needed

Fixing hqplayerd may also be needed

I can't find new version:
https://www.signalyst.eu/bins/naa/linux/fc36/networkaudiod-4.4.0-14.fc36.x86_64.rpm I guess networkaudiod is not hqplayerd (since version is lower)


v2.6.0

Codecov Report

Merging #313 (8f67cd2) into main (81d3867) will decrease coverage by 0.87%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
- Coverage   76.28%   75.40%   -0.88%
==========================================
  Files          11       11
  Lines         544      549       +5
==========================================
- Hits          415      414       -1
- Misses        124      128       +4
- Partials        5        7       +2

Impacted Files
Coverage Δ

pkg/printing/logger.go
79.84% <81.25%> (-4.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81d3867...8f67cd2. Read the comment docs.


Adding Ollama devfile

What does this PR do?:
Adding Ollama devfile
Inspired by https://www.opensourcerers.org/2023/11/06/a-personal-ai-assistant-for-developers-that-doesnt-phone-home/
Which issue(s) this PR fixes:
https://issues.redhat.com/browse/CRW-6049
PR acceptance criteria:

[x] Contributing guide
Have you read the devfile registry contributing guide and followed its instructions?
[x] Test automation
Does this repository's tests pass with your changes?
[ ] Documentation
Does any documentation need to be updated with your changes?
[x] Check Tools Provider
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:
https://workspaces.openshift.com#https://raw.githubusercontent.com/devfile/registry/b0af3873840501ae8732c997bc528dfcb011c879/stacks/ollama/devfile.yaml

/verify-owners


Added VSCodium.VSCodium version 1.58.2

PS C:\Users\WDAGUtilityAccount\Desktop\manifests> winget install -m "C:\Users\WDAGUtilityAccount\Desktop\manifests\v\VSCodium\VSCodium\1.58.2" --scope machine
Found VSCodium [VSCodium.VSCodium]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://github.com/VSCodium/vscodium/releases/download/1.58.2/VSCodiumSetup-x64-1.58.2.exe
  ██████████████████████████████  79.1 MB / 79.1 MB
Successfully verified installer hash
Starting package install...
Successfully installed

PS C:\Users\WDAGUtilityAccount\Desktop\manifests> winget install -m "C:\Users\WDAGUtilityAccount\Desktop\manifests\v\VSCodium\VSCodium\1.58.2" --scope user
Found VSCodium [VSCodium.VSCodium]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://github.com/VSCodium/vscodium/releases/download/1.58.2/VSCodiumUserSetup-x64-1.58.2.exe
  ██████████████████████████████  79.1 MB / 79.1 MB
Successfully verified installer hash
Starting package install...
Successfully installed

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

I wonder why it identifies itself as being written by Microsoft when it's the fork. Weird.


[models] LoadOBJ crashes if model has more materials than meshes.

[x] I tested it on latest raylib version from master branch
[x] I checked there is no similar issue already reported
[x] My code has no errors or misuse of raylib

Issue description
On LoadOBJ(), raylib does model.meshCount = materialCount;, in one of my models the material count is 4, while the mesh count is 1. This ends up causing a segmentation fault on line 3322: for (int v = 0; v < 3; v++) { model.meshes[mm].vertices[vCount[mm] + v] = attrib.vertices[idx0.v_idx*3 + v]; } vCount[mm] +=3; because mm is out of bounds.
Environment
Windows 10 using Visual Studio 2019.
Issue Screenshot
https://i.imgur.com/v6viC8r.png

I think my understanding of this issue is flawed, but I think the screenshot helps understanding the crash better than I can explain why it happens.

Here is the affected OBJ and material.
machinegun.zip


support Graphics.{beginBitmapFill, lineBitmapStyle}

API:

lineBitmapStyle(bitmap:BitmapData, matrix:Matrix = null, repeat:Boolean = true)
beginBitmapFill(bitmap:BitmapData, matrix:Matrix = null, repeat:Boolean = true)

as implemented in flash
Implementation is WIP.
The GraphicsData class is growing quite a bit through this so we are going to introduce a Brush class.  Is this ok?
Adding everything to the constructor of GraphicsData we get:
function GraphicsData(lineWidth, lineColor, lineAlpha, lineBitmap, lineBitmapMatrix, lineBitmapRepeat, fillColor, fillAlpha, fillBitmap, fillBitmapMatrix, fillBitmapRepeat, fill, shape)

So we are looking to go for:
function GraphicsData(lineWidth, lineBrush, fillBrush, fill, shape)

with a new class Brush with the properties

color
alpha
bitmap
bitmapMatrix
bitmapRepeat

And will grow further when we go for lineGradientStyle and beginGradientFill next ;)
Edited for clarification about the GraphicsData change and format fixed

this looks interesting!

Implementation branch moved to GreyRook:dev-bitmaps based upon PR #1587 for refactoring GraphicsData with Brush classes.

+1

+1

Closing in favor of the Brush Refactoring PR, which is serving as my reminder to do this in v5.


[Bug] FlinkCdcSyncDatabaseSinkITCase. testRandomCdcEventsDynamicBucket is not stable

Search before asking

[X] I searched in the issues and found nothing similar.

Paimon version
Error:  Errors:
Error:    FlinkCdcSyncDatabaseSinkITCase.testRandomCdcEventsDynamicBucket » Timeout test...
https://github.com/apache/incubator-paimon/actions/runs/5652244000/job/15311564241?pr=1603
Compute Engine
flink cdc
Minimal reproduce step
ci failed
What doesn't meet your expectations?
ci failed
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

The main reason is that numRecordsPerCheckpoint may be 0, which makes TestCdcSourceFunction unable to send data. I have created a pr, if you have time, please help to review it.


Allow one_of to accept groups of parameters

one_of [:a, :b], [:a, :c] should be read as one_of (:a and :b),  (:a and :c)

This is an interesting feature, but I don't think it's worth the extra implementation overhead. It's difficult to think of too many situations that would benefit from this and not be better served by a more robust domain model validation.
There's no end to the amount of business logic that one might want when handling parameters. This library tries to address the most common situations, and defer more complex logic to other means.

:+1: Agree


connection pool 'close' method

I just ran into a bug where my clients were being destroyed.  I pinned it down to this line of code.  According to:
https://github.com/brianc/node-postgres/wiki/pg#parameters
You should only pass a truthy value if you want the client to be destroyed and removed from the connection pool - which is not normally the case.  Even if it was the example's intent, you should simply pass in 'true' instead of the client, because it is misleading to the reader in what is actually going on.

Thanks!


Now I can't load a playlist

I have a Orange Pi Zero, but now a I cant load any playlist. show me the next message, check this out:
"directory or file not found"
Before it did not happen!

Can you try mopidy local scan or if you run mopidy as service sudo mopidyctl local scan. If doesn't help. Try to show as your config: https://docs.mopidy.com/en/latest/troubleshooting/#show-effective-configuration
And permisions on directory yours files are in. ls -ls /path/to/directory

Is this a specific mopidy-youtube problem or a local music problem? If the
latter please create a new post at discuss.mopidy.com.
Either way you just include the exact steps to reproduce the problem as
this report is not sufficient to help you effectively.
On 10 Mar 2018 8:47 am, "Tomáš Filo"<EMAIL_ADDRESS>wrote:

Can you try mopidy local scan or if you run mopidy as service sudo
mopidyctl local scan. If doesn't help. Try to show as your config:
https://docs.mopidy.com/en/latest/troubleshooting/#show-
effective-configuration
And permisions on directory yours files are in. ls -ls /path/to/directory
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mopidy/mopidy-youtube/issues/91#issuecomment-372014227,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5DqFIxo0-8Ht9oJjXsCFNVMDB-5H-Rks5tc5MlgaJpZM4SlFXV
.

Maybe related to the API key being invalid, should be fixed by #93

Adding more info on the issue.
When adding a playlist:
$ mpc add yt:http://www.youtube.com/watch?list=RDMMNnFidFbwQSA
error adding yt:http://www.youtube.com/watch?list=RDMMNnFidFbwQSA: directory or file not found

This error is shown in the application log:
ERROR    YouTubeBackend backend caused an exception.
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/mopidy/core/library.py", line 19, in _backend_error_handling
    yield
  File "/usr/lib/python2.7/site-packages/mopidy/core/library.py", line 236, in lookup
    result = future.get()
  File "/usr/lib/python2.7/site-packages/pykka/future.py", line 299, in get
    exec('raise exc_info[0], exc_info[1], exc_info[2]')
  File "/usr/lib/python2.7/site-packages/pykka/actor.py", line 200, in _actor_loop
    response = self._handle_receive(message)
  File "/usr/lib/python2.7/site-packages/pykka/actor.py", line 294, in _handle_receive
    return callee(*message['args'], **message['kwargs'])
  File "/usr/lib/python2.7/site-packages/mopidy_youtube/backend.py", line 160, in lookup
    return resolve_playlist(req.get('list')[0])
  File "/usr/lib/python2.7/site-packages/mopidy_youtube/backend.py", line 132, in resolve_playlist
    for item in data["items"]:
KeyError: u'items'

Debugged /usr/lib/python2.7/site-packages/mopidy_youtube/backend.py:132 to find the content of data:
(Pdb) data
{u'error': {u'code': 403, u'message': u'Access Not Configured. YouTube Data API has not been used in project<PHONE_NUMBER>49 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/youtube.googleapis.com/overview?project=119103001349 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.', u'errors': [{u'domain': u'usageLimits', u'message': u'Access Not Configured. YouTube Data API has not been used in project<PHONE_NUMBER>49 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/youtube.googleapis.com/overview?project=119103001349 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.', u'reason': u'accessNotConfigured', u'extendedHelp': u'https://console.developers.google.com/apis/api/youtube.googleapis.com/overview?project=119103001349'}]}}

This is related to other issue with API key. Since using youtube api for
this purpose is against google policy. They shutdown account with
registered API key. There is solution if you want to risk it. You can
generate your own api key on google developer site and change it in
backend.py file of mopidy youtube. But since it is against google policy.
They can shutdown your account too.
Dňa ne 25. 3. 2018, 0:41 Axel Becerril<EMAIL_ADDRESS>napísal(a):

Adding more info on the issue.
When adding a playlist:
$ mpc add yt:http://www.youtube.com/watch?list=RDMMNnFidFbwQSA
error adding yt:http://www.youtube.com/watch?list=RDMMNnFidFbwQSA: directory or file not found
This error is shown in the application log:
ERROR    YouTubeBackend backend caused an exception.
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/mopidy/core/library.py", line 19, in _backend_error_handling
yield
File "/usr/lib/python2.7/site-packages/mopidy/core/library.py", line 236, in lookup
result = future.get()
File "/usr/lib/python2.7/site-packages/pykka/future.py", line 299, in get
exec('raise exc_info[0], exc_info[1], exc_info[2]')
File "/usr/lib/python2.7/site-packages/pykka/actor.py", line 200, in _actor_loop
response = self._handle_receive(message)
File "/usr/lib/python2.7/site-packages/pykka/actor.py", line 294, in _handle_receive
return callee(*message['args'], **message['kwargs'])
File "/usr/lib/python2.7/site-packages/mopidy_youtube/backend.py", line 160, in lookup
return resolve_playlist(req.get('list')[0])
File "/usr/lib/python2.7/site-packages/mopidy_youtube/backend.py", line 132, in resolve_playlist
for item in data["items"]:
KeyError: u'items'
Debugged /usr/lib/python2.7/site-packages/mopidy_youtube/backend.py:132
to find the content of data:
(Pdb) data
{u'error': {u'code': 403, u'message': u'Access Not Configured. YouTube Data API has not been used in project<PHONE_NUMBER>49 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/youtube.googleapis.com/overview?project=119103001349 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.', u'errors': [{u'domain': u'usageLimits', u'message': u'Access Not Configured. YouTube Data API has not been used in project<PHONE_NUMBER>49 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/youtube.googleapis.com/overview?project=119103001349 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.', u'reason': u'accessNotConfigured', u'extendedHelp': u'https://console.developers.google.com/apis/api/youtube.googleapis.com/overview?project=119103001349'}]}}
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mopidy/mopidy-youtube/issues/91#issuecomment-375933087,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APlHeyhCbqO3zkIeBqzs7Pq5fFgYev8Oks5thtmhgaJpZM4SlFXV
.

Related issue  #87


make publish crate optional

The official manifest has a key for disable publishing.
Currently cargo release will fail when cargo publish is executed and publish = false.
With my PR no extra option is added!

Nice, thank you @ChriFo


Reformatting of docstrings.

This CL has been rebased.

Finally got it all sorted out! Thanks for your patience, man!

Awesome, thanks!


Update version.sh to work with macOS 10.15.

Reads the version with PlistBuddy. Taken from instagram/IGListKit#1423.
Changes in this pull request
Issue fixed: #1420
There are no breaking changes, and the code just fixes an issue that came up because of the way 10.15 handles the default command.
This fix is crucial to get the demo project back on track. It doesn't compile in the current master branch!
Checklist

[x] All tests pass. Demo project builds and runs.
[ ] I added tests, an experiment, or detailed why my change isn't tested.
[ ] I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
[x] I have reviewed the contributing guide

Hi @yspreen thx for working on this! I actually tried running /scripts/version.sh and it ran fine on my macOS 10.15.*, I am wondering what was the issue you ran into? thanks

@lorixx Just see the issue #1420
I just ran into this again, one year later. It fails with
ERROR | version: A version is required
without the fix. I think it's finally time to merge this and solve the issue


No armors, no powerups

Viewer does'nt show armors and powerups on map screenshot

https://discordapp.com/channels/536281825077755954/537620677935759361/634089841528930354


Using typeahead when adding users to a team

Fixes: #39
Signed-off-by: Jürgen Löhel<EMAIL_ADDRESS>

This branch has conflicts because I've merged #534

The only problem that I got, and sorry for not noticing this before, is that one side-effect of this is that you've changed the size of the input element for the name. Could you change that?
Besides that, it looks good to me.

LGTM

Good job @jloehel! LGMT

beside comment in routes.rb:9 LGTM.
Well done!

Good job :clap:

@mssola or @jloehel: could you also update the changelog?

@flavio let me do it


Security contact for agentscope?

Hello AgentScope team!
I'm from the GitHub Security Lab and would like to report potential vulnerabilities in AgentScope.
Could you please provide us a security contact to send the report to?
Instead of providing a security contact you can also enable private vulnerability reporting for your repositories.
Thanks!

Thanks for your attention. We have enabled private vulnerability reporting already.


Unclear how to make Sentry work with Vite + React sourcemaps

Environment
Vite 5.2.0, React 18.2, Node 20.11.0
What version are you running? Etc.
@sentry/react: 8.7.0
@sentry/vite-plugin: 2.18.0
Steps to Reproduce

Configured vite and sentry like that:

export default defineConfig({
  plugins: [
    react(),
    sentryVitePlugin({
      authToken: '... token ...',
      org: '... org name',
      project: ' ... project name',
    }),
  ],

  server: {
    port: 3000,
    proxy: {
      '/api': {
        target: 'https://my_needed_url.com',
        changeOrigin: true,
      },
    },
  },

  build: {
    outDir: 'build',
    sourcemap: true, // (!!!)
  },
});

Kept Sentry init options default

Made a button that throws error
Built prod bundle and served it with vite preview so my prod bundle runs
Sourcemaps are uploaded, I can see it

Expected Result
After firing error I expected to see normal stack trace with my code like this, like I see in browser:

Actual Result
But actually I'm getting weird  stacktrace like this:

And this on Most Relevant tab

So where I got first screenshot?
If it configure VIte  sourcemap: 'inline' I'm getting sourcemap baked into bundle so bundle file weights 11Mb+ but it allows Sentry to show me actual code.
So how to configure Vite and/or Sentry to get nice stacktraces without making weird 11Mb bundles with baked in sourcemaps?
If no clear idea comes to mind, maybe there is some repo in github where VIte + Sentry is configured nice way, so I can compare and try

build.sourcemap: true is fine. Do you have any other tools or plugins in your build pipeline? Some of them may generate faulty source maps.

build.sourcemap: true is fine. Do you have any other tools or plugins in your build pipeline? Some of them may generate faulty source maps.

  "scripts": {
    "start": "vite",
    "build": "tsc && vite build ",
    "build_sentry": "tsc && vite build && npm run sentry:sourcemaps",
    "lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0",
    "preview": "vite preview",
    "sentry:sourcemaps": "sentry-cli sourcemaps inject --org ng-hp --project my-project-front ./build && sentry-cli sourcemaps upload --org ng-hp --project my-project-front ./build"
  },

I run npm run build_sentry and then npm run preview to serve build and trigger error button

so you are using the vite plugin and the cli to upload sourcemaps? I recommend removing one or the other.


Add $meteor.collectionFS for handeling these collections

Added ability to override the "diffArray" of the $meteorCollection base object in case of collection with special objects (like CollectionFS).
This PR also the solution for "Max Call Stack" errors when trying to work with CollectionFS.

Thanks @dotansimha


Eclipse Java compiler instead of tools.jar?

Hi,
Your project looks really promising and I would like to try and use it in one of our products, but it has a major limitation, that is, the dependency on the JDK.
It is a known fact that tools.jar cannot be a part of the distribution, but there is a good alternative - ECJ.
http://mvnrepository.com/artifact/org.eclipse.jdt.core.compiler/ecj
Could you consider using it instead?

Hello!
It seems to be a really good idea as depending on ECJ would certainly be better than depending on JDK. ECJ implements the same interface as Java Compiler so I've just created a quick proof of concept and made all the tests passing with ECJ. There are some changes that I have to make like changing default target and source version compiler options and improving diagnostic info handling a bit. I'm definitely going to try to implement this feature for the next version in the coming days. Thank you for the issue :-)

Nice! If you need an example on ECJ usage, check here
https://github.com/CoCoViLa/CoCoViLa/blob/master/src/main/java/ee/ioc/cs/vsle/ccl/CCL.java#L243

ECJ support was included in the 1.1 release.
Thanks again for the idea!
By the way "CoCoViLa" is a really cool project name :-D


pdfDocument

Hi,
Do you have any example of upload a document to sale invocies?
That section doesn't have any information to use the endpoint in postman,
Regards.

Yes, you are right @saponteindra. Sorry for the inconvenience.
The Attachments API is something that still needs to be updated.
I've done it locally a few months ago but haven't updated the Postman Workspace yet.
We need to know that uploading files to the specific documents will create an "Incoming Document" (https://learn.microsoft.com/en-us/dynamics365/business-central/across-income-documents):
For the document attachments you would have to create your own Custom API afaik.
Create
$headers = New-Object "System.Collections.Generic.Dictionary[[String],[String]]"
$headers.Add("Content-Type", "application/json")
$headers.Add("Authorization", "••••••")

$body = @"
{
    `"parentId`": `"ef4f9ac6-b449-ef11-bfe9-6045bdac9971`",
    `"fileName`": `"myPDF.pdf`",
    `"parentType`": `"Sales_x0020_Invoice`"
}
"@

$response = Invoke-RestMethod 'http://bcserver:7048/BC/api/v2.0/companies(83fb7f98-b449-ef11-bfe9-6045bdac9971)/attachments?tenant=default' -Method 'POST' -Headers $headers -Body $body
$response | ConvertTo-Json

Upload
$headers = New-Object "System.Collections.Generic.Dictionary[[String],[String]]"
$headers.Add("If-Match", "*") # change this for prod env
$headers.Add("Content-Type", "application/pdf")
$headers.Add("Authorization", "<insert_your_authorization_here>")

$body = "<file-contents-here>"

$response = Invoke-RestMethod 'http://bcserver:7048/BC/api/v2.0/companies(83fb7f98-b449-ef11-bfe9-6045bdac9971)/attachments(8be63854-3566-ef11-9223-b37aba01145f)/attachmentContent?tenant=default' -Method 'PATCH' -Headers $headers -Body $body
$response | ConvertTo-Json

Thanks for the answer, that helper me a lot.


FiniteStateMachine only processes one event per frame.

FiniteStateMachine only processes one event per frame.
I'm not sure if this is a bug or if it is intentional, but it was certainly a surprise to me. I was expecting the event stream to complete its processing within a given _process_*() callback. Ultimately this assumption led to some really wonky behaviour and/or delayed transitions as the queue backed up.
I can hack in a solution locally, but if this is intentional I'd rather not build on a hacked solution that breaks fundamental assumptions of the library.
I'm not sure what the intent is here. Could I get some clarity?

Currently it only parses one event per tick.
	# Check if there are events
	if current_events.size() > 0:
		# Get the first event
		event = current_events[0]
		# Remove the event from the list
		current_events.remove_at(0)

This is by design. However it is a valid discussion if it should support handling more than that.


colab notebook 2D

Adding google colab notebook for 2D segmentation

Hi, I have trained the model using a custom dataset and now I want to use this new weights for inference.  I am loading weights while creating an instance of Cellpose class as shown in the attachment. Could you please let me know if this is the correct way to load custom weights?

Further, when I load weights in this way and proceed to prediction, I get the following error.

Could you please let me know if the error is from the way I am loading the weights?
Thanks in advance!!

Hi, is this in google colab?? Assuming you are doing it in your local environment from what I can tell.
Regardless, if you are using a pretrained model, check this documentation:
https://cellpose.readthedocs.io/en/latest/api.html#cellpose.models.CellposeModel

class cellpose.models.CellposeModel(gpu=False, pretrained_model=False, torch=True, diam_mean=30.0, net_avg=True, device=None, residual_on=True, style_on=True, concatenation=False)
Parameters

        gpu (bool (optional, default False)) – whether or not to save model to GPU, will check if GPU available

        pretrained_model (str or list of strings (optional, default False)) – path to pretrained cellpose model(s), if False, no model loaded; if None, built-in ‘cyto’ model loaded

        net_avg (bool (optional, default True)) – loads the 4 built-in networks and averages them if True, loads one network if False

        diam_mean (float (optional, default 27.)) – mean ‘diameter’, 27. is built in value for ‘cyto’ model

        device (mxnet device (optional, default None)) – where model is saved (mx.gpu() or mx.cpu()), overrides gpu input, recommended if you want to use a specific GPU (e.g. mx.gpu(4))

I haven't used this option in a while, but in your case it should be:
models.CellposeModel(gpu=True, pretrained_model=model_type)
Check the eval option here as well: https://cellpose.readthedocs.io/en/latest/api.html#cellpose.models.CellposeModel.eval
Your post has made me realise that I should add an option of using a custom trained model in the google colab notebook... 😃

Thanks for the reply. You guessed it right, I am doing everything locally.
I am creating an object of class Cellpose() which combines Cellposemodel and size model and while creating an object, I pass the path of the weight as model_type argument. So, in the end, the model_type argument is passed to the object of the CellposeModel class.
In the constructor of the CellPose(), I added a condition to check if the custom_weights are loaded or the default 'cyto' or 'nuclei' model.


ARDC - Annotate and Train Classifier for Multi-Label

One of Tom's biggest requests is to try and classify awards by possible software created rather than just "software created." Specifically his categories were:

analysis code (used once for a paper / project)
infrastructure (larger projects, well maintained, well used, multiple components)
prototype tools (new libraries, tools, engines, databases, etc.)
algorithms (5 lines of code +)
no software created

might need to go back and forth with Tom about the definitions for these prior to annotation
ultimately, this is likely valuable for us in general in other work. largely just takes time for me to annotate (do we want to double annotate or just me?)
cc @nniiicc iirc you previously linked me a paper about "definitions for different types of software" do you have that link handy somewhere?

found tom's definitions: https://zenodo.org/record/6378082


implement request stat tracker middleware

What's wrong
a mdidleware is needed to track all incoming requests to this api.
What done looks like
all incoming requests trigger middleware to send incoming request data to the stats api.
Where the changes need to be made

middleware file should be created
middleware function should be registered as global middleware
http request to stats service should occur asynchronously to the reset of the request being handled
a service file should be created for the StatsService
a config file should be created for the stats service
the StatsService file should reference the service & url through the config / env variables ( and any other variables that might be non-static / configurable )

Related PR - https://github.com/precision-sustainable-ag/dst-cover-crop-data-api/pull/39


Dropbox disabled Bookdrop

When I try to login to Dropbox, it says this app is disabled. So we need the new "local" version that's promised on the readme!

@stephanie-wang I don't see the app disabled, but it looks like the domain expired? What's the status of the project? Can we help with either setting up a local version or can you post instructions for your heroku configuration? Love/miss this app already! Thanks.

So sorry, but my Dropbox account was recently disabled, so the app is temporarily unavailable. I'll try to get it up and running again this weekend. Please bear with me!

I'm having the same "app is disabled" error, is there any updates on this issue? Thanks

same issue here

Hello, Any update? This service is very useful, would be nice to get it back ;) Thanks a lot!

@stephanie-wang our brains are atrophying from disuse. please save us!

I'm so sorry! I've been very busy with work recently, but I will hopefully have time this weekend or next to get this sorted out! Stay tuned. :)

Any update? :)

I contributed to this project and am willing to contribute again if might help get it resolved? I'll pledge $50. Any others willing to pony up?

I will throw in a few $.. its starting to annoy me that I have to move everything to my kindle manually.. Think about it.. The people complaining here are mostly developers.. what about all the regular people using this?

I'm hoping for an update at some point, but couldn't wait any longer. So for now I just made an IFTTT applet to run it for me. Might be an easy fix for people while we wait. I just did IF dropbox THEN gmail to send it to my kindle email.

I'm so sorry, I've been pretty busy, but I've finally got around to this! You can all reactivate your accounts at getbookdrop.com! I had to install a new Dropbox app, so after logging in with Dropbox, make sure to move your books to the new folder Dropbox/my-bookdrop.
Thanks for being patient with me! The service should be more available starting now. :)

Getting the error..
This app is unable to link additional users because it has been frozen pending review.

Getting the same "unable to link additional users" error, and it's been several months...

I dot think this app is being maintained anymore

Stuck on error 500 when returning to the site after dropbox authentication :(


Linux: Add wayland drm_lease_shim library

Draft because it puts the .so in same directory as the source file. I'm not sure how to get target output dir from build.rs.

I'm not sure how to get target output dir from build.rs.

Use env::var("OUT_DIR")

alvr_filesystem::target_dir()

This goes one more dir up, so it loses the debug/release subdir.


Attaching ref description in readme is incorrect

<QRCodeScanner ref={(node) => {this.scanner = node}}>
instead of
<QRCodeScanner ref={(node) = this.scanner = node}>
solved it for me at least. PS thanks for the module :)

yep, you are correct, I've updated the readme and will push it out in the next release, thanks for the catch!


Update SECURITY.md

The update I made is to the reward part, min = 2500, up to 100k.
Also, question, is there a better email to send disclosures to than<EMAIL_ADDRESS>

This looks good, but this security file is in almost every other onflow repo. Are you planning on updating those also?


Minor tweaks to SubstructLibrary

This PR contains minor trivial tweaks to SubstructLibrary:

added some missing const keywords
added an addFingerprint overload to allow passing pointers.
This is useful to add a pattern fingerprint with non-default number of bits and pass ownership to the SubstructLibrary: PatternFingerprintMol returns an ExplicitBitVect *, and in the absence of this overload an unnecessary copy would be generated
added a test

@ptosco, yeah those functions should definitely be const.
The lack of an addFingerprint was a design decision to prevent conflicts in fingerprint types.  I.e. you need to define the fingerprinting class before you can add fps.  I can see, though, that this might be slow when adding molecules.  If this is the reason, perhaps a threaded loader would be more appropriate.
After the comment/doc update I'll merge this.  But I'm still a bit worried that we are going to open ourselves up to confusion with the addFingerprint and users who don't overload the fingerprint generator.

@bp-kelley Note that I have only added an overload to addFingerprint - the function was already there. I can definitely add the comment but this specific PR does not affect the ability to add raw fingerprints, which was already there. Am I wrong?
The threaded mol loader is on my to-do list - I'll create an issue and assign it to myself. Are you OK with this?

@ptosco I knew I was reviewing myself when I wrote it!
Before we write the threaded mol loader, I would like to think about having a standard pattern for doing this in general.  I.e. should we exploit the threaded mol reader?  If we just have a list of smiles to add, I think that can be independent and probably pretty easy to implement.
I.e. mols.reserve(size), pattern.reserve(size) -> threaded fill.

@bp-kelley Good point about the threaded mol loader - we definitely want to make it as general as possible.
About addFingerprint, I have had another thought to address your concern: what about changing
  virtual ExplicitBitVect *makeFingerprint(const ROMol &m) const {
    return PatternFingerprintMol(m, 2048);
  }

into
  virtual ExplicitBitVect *makeFingerprint(const ROMol &m, unsigned int numBits = 2048) const {
    return PatternFingerprintMol(m, numBits);
  }

That would actually serve the same purpose and would be much safer. Agreed?

I think this belongs in the constructor actually since it would need to be serialized.
class RDKIT_SUBSTRUCTLIBRARY_EXPORT PatternHolder : public FPHolderBase {
 unsigned int numbits;
 public:
  PatternHolder() : numbits(2048) {}
  PatternHolder(unsigned int numbits) : numbits(numbits) {}
  //! Caller owns the vector!
  virtual ExplicitBitVect *makeFingerprint(const ROMol &m) const {
    return PatternFingerprintMol(m, numbits);
  }
};

If we make the variable one a separate class, actually, we can preserve backwards compatibility.

@bp-kelley Right, we do want to serialize the number of bits. I hope what I have committed makes sense - the bed is calling me aloud.

OK, I have messed up something with Java wrappers. I'll build them locally and sort this out.

Get the tests working then I'll push a PR to your fork for the serialization.  Then I'll go back to your stable sort PR!

@bp-kelley This should be good now.

@bp-kelley yeah, I left out a small, insignificant detail: the serialization itself :-D  mind you, I said I was sleepy.
Don’t spend time on this, I’ll do it tomorrow, and add a test. Save your energies for the stable sort thing :-)

It should be easy to make the serialization use the old when numbits is 2048 so we don’t break backwards compatibility.

Brian Kelley

On Nov 13, 2020, at 4:24 PM, Paolo Tosco<EMAIL_ADDRESS>wrote:

@bp-kelley yeah, I left out a small, insignificant detail: the serialization itself :-D mind you, I said I was sleepy.
Don’t spend time on this, I’ll do it tomorrow, and add a test. Save your energies for the stable sort thing :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@bp-kelley I think this should be good now.

@bp-kelley Sorry, I had not realized this was being blocked by a conflict.
I have resolved the conflicts and got rid of PatternNumBitsHolder as per your suggestion.
Instead, I leveraged the serialization version to do the right thing at deserialization time to keep backwards compatibility. I have added a test for that that uses a pickle generated with the version 1 serializer and it works OK.

@bp-kelley the Unsupported version is caused by the fact that the pickle I have included as backward-compatibility test uses a very recent version of Boost which apparently is incompatible with the one used by the Azure build server. I will generate a pickle with the same Boost version used by the server now - that should fix the problem.

@bp-kelley I think this is ready to go now.

@ptosco Looks good, let's verify if you need to bump all the serialization versions, but after that I'll merge.

@bp-kelley Thanks Brian. You can indeed bump only the PatternHolder version, I bumped all of them just for consistency, but I'll revert others to 1 if you prefer so.

Since they didn’t change let’s do this.  Is there any way to write a version 1 pickle if there isn’t a changed numbits by the way?

@bp-kelley No, but that's a good idea - I'll implement it now and add it to this PR. This will also avoid having to maintain the V1 pkl file for testing.

@bp-kelley the serialization version is a compile time constant, so it cannot be set at run time.
Instead, I have reverted to version 1 for all including PatternHolder. I write numBits only if != 2048, and read it from the archive only if it actually exists. However, this has one major drawback: older RDKit version may read new pickles and ignore the number of bits. This is fine if the library had been generated with 2048 bits, otherwise everything will be screwed up. Instead, bumping version to 2 will avoid this.
Let me know which version you prefer. If you prefer the former, I will just set all versions to 1 but PatternHolder to 2 and revert this last change.

@bp-kelley the failures in the tests are due to upstream issues in master (molzip, etc.). Looks like the master branch build is partly broken.

Yep, I had a bad commit, it should be reverted.

@bp-kelley The mac test failure is on the multiThreadedMolSupplier - nothing to do with this PR.
Let mw know if you like my last commit (description here: https://github.com/rdkit/rdkit/pull/3564#issuecomment-740784439).
I don't like it, because there is a danger that an old RDKit version will read 1024-bit pickles as if they were 2048-bit.
Instead, the version 2 format would not be read by older RDKit, but the version 1 format will still be read by newer RDKit, which I think is the most important thing.
If you agree with me, I'll revert the last commit and go back to having PattternHolder on version 2 and all the rest on version 1.


Update the container

hasnt been updated for a while and i get a git 128 error. It was merged a fix in january but it don't seems like that's included in the container
https://github.com/custom-components/integration_blueprint/issues/71

Update your devcontainer.json to use ghcr.io/ludeeus/devcontainer/integration:stable


Smarter PlaceNode.Country(). Fixes #143

For places that do not follow the strict four jurisdictional entities the country can still be extracted by referring to a list of known countries and comparing them with the suffix of the place name.
It can work around some basic puntuation, capitalization and whitespace. However, it is not as full proof as it could be, yet.

This change is

Codecov Report

Merging #147 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   94.22%   94.25%   +0.02%
==========================================
  Files          36       36
  Lines        1421     1427       +6
==========================================
+ Hits         1339     1345       +6
  Misses         70       70
  Partials       12       12

Impacted Files
Coverage Δ

place_node.go
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b8223...0466432. Read the comment docs.


foreachloop SSIS on azure not reading files from azure file share subdirectory

I have a SSIS package with For each loop that enumerate on path like C:\folder\folder1\folder2\folder3 and reading all the files from folder3 with search pattern .xlsx and now the same structure is created on azure file share \storagename\folder\folder1\folder2\folder3 when SSIS package deployed to azure sql Catalog and running same using data factory is not reading the files available at folder3 and saying that foreachloop enumerate empty as I am using UNC path for folder3.
please help me to read files from azure file share subdirectory using SSIS foreach loop.

@khatri034 Please ask product support or support forums like https://techcommunity.microsoft.com/t5/sql-server/bd-p/SQL_Server


[CARBONDATA-2972] Debug Logs and function added for Adaptive Encoding

Added a function to get the type of encoding used. Added the debug log for checking which type of encoding is used.

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[x] Testing done

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/477/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/8726/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/656/

retest this please

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/8746/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/677/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/506/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/8753/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/684/

retest this please

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/8764/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/697/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/522/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/8852/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/785/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/600/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/792/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/8859/

LGTM


[WIP] Support accessing built-in filters as callbacks

Marking this as WIP until we address flushing/ending the filter (#4). Edit: done.
Closes #3

Upon further inspection of the above build errors it turns out this is caused by incompatibilities (aka bugs) in PHP 7 and HHVM respectively:

HHVM inconsistency

Using DEFLATE (compression) algorithm returns strings that are bigger than the input string
Minimal reproducible script: https://3v4l.org/eK3Xa
Though this works fine: https://3v4l.org/jfDem
FWIW: HHVM buffers the whole string anyway, so I'm not sure how useful it's going to be anyway: https://github.com/facebook/hhvm/blob/master/hphp/system/php/stream/default-filters.php#L77

PHP7 inconsistency

Using DEFLATE (compression) on an empty string should return a 2 byte output string
Minimal reproducible script: https://3v4l.org/hpsJA
Though this works fine: https://3v4l.org/A0teN

There's not really much we can do about this here.
As such, I'll look into documenting this as known issues and skip the relevant tests here.


Towards 0.6.15.

Review by @gzm0

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3575/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4712/
Test PASSed.


[WIP] Introduce Mypy type annotation to paulis.py

This ensures the parameters type and return type of each function are consistent.
There are several error messages left to be fixed, the majority require more code-selection handler
$ mypy pyquil/paulis.py
pyquil/paulis.py:28: error: No library stub file for module 'numpy'
pyquil/paulis.py:28: note: (Stub files are from https://github.com/python/typeshed)
pyquil/paulis.py:91: error: Argument 1 of "__eq__" incompatible with supertype "object"
pyquil/paulis.py:131: error: Unsupported operand types for * ("float" and "complex")
pyquil/paulis.py:148: error: Unsupported operand types for * ("float" and "Number")
pyquil/paulis.py:150: error: Incompatible return value type (got "PauliSum", expected "PauliTerm")
pyquil/paulis.py:155: error: Iterable expected
pyquil/paulis.py:180: error: Argument 1 to "float" has incompatible type "Number"; expected "Union[SupportsFloat, str, bytes]"
pyquil/paulis.py:206: error: Unsupported operand types for * ("float" and "PauliTerm")
pyquil/paulis.py:216: error: Unsupported operand types for + ("Union[Number, PauliTerm]" and "PauliTerm")
pyquil/paulis.py:216: error: Unsupported operand types for * ("float" and "PauliTerm")
pyquil/paulis.py:294: error: Unsupported operand types for * ("float" and "PauliTerm")
pyquil/paulis.py:348: error: Unsupported operand types for * ("float" and "Number")
pyquil/paulis.py:393: error: Incompatible return value type (got "float", expected "PauliSum")
pyquil/paulis.py:393: error: Unsupported operand types for + ("PauliSum" and "float")
pyquil/paulis.py:393: error: Unsupported operand types for * ("float" and "Union[PauliSum, PauliTerm, Number]")
pyquil/paulis.py:405: error: Unsupported operand types for * ("float" and "PauliSum")

In particular, the error
pyquil/paulis.py:150: error: Incompatible return value type (got "PauliSum", expected "PauliTerm") makes me think that almost all the operators do return PauliSum instead of PauliTerm. Would it be possible to write them so that the operations are closed under the set of PauliTerm?

Hi @rht! Thanks for your contribution. Really sorry that we didn't look at this earlier.
I'm going to close this particular pull request since there have been a number of changes to that file since the PR was opened. That being said, if you are willing to update this to match the latest version of the code then I'd be happy to merge it for you. Type annotations are 💯 . If you do open up another request tag me as a reviewer.


Support for jmap -live

I would like to know if jattach supports the equivalent of the jmap -dump:live as mentioned in Oracle documentation. The intent here is to only dump live objects, in order to optimize the size of the dump file. Since jattach only has the dumpheap option, it is not clear, if the live option is supported.
Appreciate your help.

Yes, just add -live option at the end:
jattach PID dumpheap outputfile.hprof -live


Template file modification does not register

hi, i m trying to modify the template file that generates the wal and wal-bordered color schemes. i am modifying the file in  ~/.vscode/extensions/{extension dir}/out/template.js
However thes modifications fo not register and the theme is generated for the original color specified, not the new color number. I tried changing the out/src/template.js file but to no avail.
Can you provide me some insight into this?

Hi, just to make sure that I understand your problem, what is it that you're trying to achieve? From my understanding it seems that you're trying to change which of the 9 colors provided by pywal is being used for a certain ui element, is that correct?

Yes I am trying to change the activity bar foreground color. I changed the color code values.
I reloaded the theme and vscode but the changed colors did not reflect.
Seems like the modification only takes effect after one reboot.

Yes, the theme updates only when vscode boots or when the wal file gets updated. You can manually reload the theme through the command. You can find it in the README. Remember that the file you're modifying is called only in those occasions to generate the actual file(the json one), so you won't see the changes applied until the theme updates.
If you don't have any further questions I'll consider this issue solved.


Update: ProductServiceClientPactTest : Allow testSingleProduct to be run in isolation

The current test configures the mockserver URI only for getAllProducts.
getSingleProduct works because the base URL is already set.
It is better to allow the methods to work in isolation, so that they for example can run individually in an IDE.
This fix is applied only on the step3 branch, but other branches will likely have the same issue.

Ports are now set up to be random in the tests, as part of a repo wide update across all branches, thanks for this change


Care score calculator

Add CARE score calculator

some minor modelling added to policies.ttl as the calculator can only reasonable look at specific predicates in some instances.
basic unit tests added which pass on the added "reference" care_test_data.ttl file

@nicholascar please review and provide edit/comment access to the "Flow chart - Care docs to IDN Care Score" google doc as I think a few of the items need minor updates.


HSEARCH-3562 Reporting errors about duplicate fields fails with an AssertionFailure when field is declared by a class bridge or class-level @Spatial

https://hibernate.atlassian.net//browse/HSEARCH-3562
To be backported to several other branches, see the ticket.

Pull Request Test Coverage Report for Build 1

8 of 8 (100.0%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.008%) to 84.0%

Files with Coverage Reduction
New Missed Lines
%

engine/src/main/java/org/hibernate/search/store/impl/FSSlaveDirectoryProvider.java
2
80.23%

Totals

Change from base Build 24:
-0.008%

Covered Lines:
23808

Relevant Lines:
28343

💛  - Coveralls

Merged and backported. Thanks!


add-path is deprecated warning

It seems a vulnerability was identified in the Github Actions runner (https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/) and in response Github have deprecated (and will soon disable) the add-path command.
This affects https://github.com/lukka/get-cmake/blob/main/src/get-cmake.ts#L120-L121
Based on the announcement, the fix here should be as simple as updating @actions/core to at least v1.2.6.

@Silic0nS0ldier the problem should be fixed in PR 13. Can you provide a link to the workflow that is providing the warning? I am afraid the reason is that i changed the default branch to main, and left the master branch behind.

Ah, I see. I was using a pinned version (3.18.2, from the README), but the latest was 3.18.3 at the time. At the time I had assumed that was the latest version (Github gave me no indication of the contrary). Updating did the trick.
Main reason I went for the pinned version was to avoid breakages related to CMake updates. I suggest decoupling versioning of the action from that of CMake, if possible. Much like how the setup node action works.

@Silic0nS0ldier thanks for the suggestions.
I think the main source of confusion comes from the fact that GitHub proposes (when clicking on Use latest version) the tag of the last released version.
Instead it should also offer the user the chance to stay on top of most recent major version, i.e. offering the last released version on a branch (i.e. for this action it is get-cmake@latest).
I hope you agree with me, that decoupling CMake version and action version would not help: if you use in your workflow<EMAIL_ADDRESS>(because GitHub told you so), your workflow will stick with v1.2.3, and not benefit of any updates/fixes (e.g. you would not get a fix for the deprecation of add-path). You would need to use get-cmake@latest to get updates. The same is happening on setup-node action, you would need to use setup-node@v2 rather than the one currently proposed by GitHub, e.g<EMAIL_ADDRESS>You can read more about this in this post I left in the GitHub Community:
versioning-guidance-for-authoring-and-consuming-actions.
Note: I assume Git tags should not move, and only branches do :) In principle, you could rewrite Git history and move all the versioned tags, but I am not considering that as an option.

The YAML snippet for "use latest version" being a pinned version is annoying, but ordinarily doesn't affect me as I relax the range to accept any minor and patch level release.
In the context of the get-cmake action I did not do this as the action version doubles as CMake version selection, and I did not want to have to worry about CMake updates breaking my workflow (I don't think CMake versions according to semver given how complex configurations can be).
The snippet provided by Github does not help, but was not the cause of my issue here. To illustrate what I'm trying to say, here are 2 examples.
# CMake version determined by action version, not possible to update action without increasing CMake version
- name: Setup CMake
  uses<EMAIL_ADDRESS>
# CMake version determined by action input, action can be updated automatically
- name: Setup CMake
  uses: lukka/get-cmake@3
  with:
    cmake-version: 3.18.3

I'm not sure if a matrix can be used for step versions either. Decoupling would allow the cmake version to be defined by a matrix item.

@Silic0nS0ldier thanks for the explanation, it makes sense to allow the selection of CMake version by adding a new input, and at the same time allowing workflow to consume automatically the most recent version of the action.
In this case the action is one-liner by design (maximum simplicity), and I also assumed that it is always a good thing to use latest CMake (i.e. with get-cmake@latest the workflow would benefit of the up to date action), as I never experienced major breakage using always latest CMake.
This design choice also proved me wrong in the scenario where a workflow needs to test the build with a specific ancient version of CMake (e.g. 3.8), which I have not created a tag for. Your approach would make this just working indeed.


Remove -only-exposed from docker-gen statement so that it will pick u…

Remove -only-exposed from the docker-gen statement in order to allow the letsencrypt-companion container to pickup containers that are in internal networks.
Docker itself will not actually expose ports on containers that are in internal-only networks. This creates a problem when attempting to proxy web servers in containers that are on internal docker networks, as they will never be picked up by letsencrypt-companion since they technically do not have an "exposed" port.
Example: I'd like to proxy requests for a container running Portainer. Since Portainer only interacts with the docker service itself, it can sit on an internal docker network for increased security. However, since letsencrypt-companion only picks up containers with exposed ports, and this Portainer container can't expose a port on an internal docker network, it will never get a cert created by letsencrypt-companion.
This might be better as some kind of option, maybe an environment variable that can be set, but since letsencrypt-companion is only looking for containers with the LETSENCRYPT_HOST and LETSENCRYPT_EMAIL environment variables anyway, it seems reasonable to just remove this argument from the docker-gen statement.

Have you tested it ?
I just tested what you suggested (portainer on an internal network) in a variety of docker networks setup, none of them works with your PR, you end up with an empty upstream section in the generated /etc/nginx/conf/default.conf
I'm not sure of what you are trying to accomplish by putting a container supposed to provide an UI on an internal network.

I have tested it, but this change would only affect the generation of the certs by the letsencrypt-companion container. Did you check to see if your certs had been generated?
To get the default.conf to generate properly, a similar change has to be made to the docker-gen statement that generates the default.conf. The difference is that you can change this without modifying the code for docker-gen since you specify your own entrypoint for the docker-gen container.
Here's an example docker-compose file that works and might make more sense: https://gist.github.com/thmhoag/2e160cee99fb7c9f46db8e4a34c80d15
Of course to run it you'll have to change the image name of the nginx-letsencrypt to whatever you named the build from my pull-request, and also the VIRTUAL_HOST, LETSENCRYPT_HOST, LETSENCRYPT_EMAIL.
The key for the default.conf is that my entrypoint line for the docker-gen container also excludes the -only-exposed argument.

entrypoint: /usr/local/bin/docker-gen -notify-sighup nginx -watch -wait 5s:30s /etc/docker-gen/templates/nginx.tmpl /etc/nginx/conf.d/default.conf

As far as what I'm trying to accomplish, you're right, it's a bit of an edge-case. The idea is simply to keep all containers that don't absolutely require outside internet access on an internal network, especially the containers that have access to the docker.sock. This still leaves the letsencrypt-companion container on an external network, but that is unavoidable since it requires internet access to generate and maintain ssl certs.

The idea is simply to keep all containers that don't absolutely require outside internet access on an internal network

Correct me if I'm wrong, but if you want to proxy traffic to the portainer container and have it accessible via a domain name (and a portainer container you can't reach as pretty much zero purpose), it no longer qualify as a container that don't require outside internet access. The two seems pretty contradictory to me.

Right, exactly. I'm intentionally exposing web traffic via the proxy, but that container doesn't need access to the internet to serve the purpose of providing a web UI for docker.sock.
I think my question here would be, is there any reason that we need the -only-exposed argument for this docker-gen statement? My thought behind the pull request was that the argument is unnecessary since containers will be filtered out by the LETSENCRYPT_HOST and LETSENCRYPT_EMAIL environment variables anyway, so I can't imagine anyone unintentionally generating certs for containers by removing it. However, if there is a specific reason for needing it that I'm missing here, maybe we could also consider making in an option via another environment variable, or providing some kind of override?

My thought behind the pull request was that the argument is unnecessary since containers will be filtered out by the LETSENCRYPT_HOST and LETSENCRYPT_EMAIL environment variables anyway, so I can't imagine anyone unintentionally generating certs for containers by removing it.

True.
I don't see any real necessity behind the argument either (beside the presumption that container without exposed ports won't require proxying anyway and thus don't need to be feeded to docker-gen, which prevents your use case).


Include git revision in pm file and packaging version

... was lost since CVS times

for some reason Travis build is not kicking in here


Ability to export/import shared logs

With the .gbfr log format, it should be possible to share these out and import them back into the parser for analysis.

With https://github.com/false-spring/gbfr-logs/commit/ea22f2c691fec6581e5c0b5cc578ffadaccdfb74 it's possible to export the raw damage event log to CSV, which makes it possible to parse and reconstruct the timeline.
However, I plan to add additional meta information around saving sigils / trait loadout per party chara, so will need to find a format that also saves it alongside the event log.


The file I created is not working

Windows and playsound are can't play my mp3 files
`from responsive_voice import ResponsiveVoice
import playsound
import os
engine = ResponsiveVoice()
konum = "C:\Users\**\Documents\ST\indirilenler\"
cumle = "Tabiki"
dosya = cumle + ".mp3"
if not os.path.exists(dosya):
engine.get_mp3(cumle, mp3_file= konum + dosya, gender= ResponsiveVoice.MALE)
playsound.playsound(konum +dosya)
else:
playsound.playsound(konum + dosya)`

thank you for reporting, it seems the internal api used by responsive voice has changed, this is an unofficial package and not approved by responsive voice, i will have to check what changed and see if i can do something about it
this package is currently not working in any platform

Is there anything i can do to solve this problem?

Recently, I signed up at responsive voice.org and I received a key. Probably they are sending individual api keys.

I guess these personal api keys are for java script, are there api keys for python. Which language do you use

Yes,
The api key is in a single line of JavaScript.
I use English and speak a little Spanish.
This is what they sent me:
JavaScript

On February 25, 2020 3:55:19 PM CST, Guennx<EMAIL_ADDRESS>wrote:

I guess these personal api keys are for java script, are there api keys
for python. Which language do you use
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/OpenJarbas/py_responsivevoice/issues/7#issuecomment-591090057

-- Sent from /e/ Mail

I converted their JavaScript into Python
http://stevs.net/converter/
#!/usr/bin/python
print "#!/usr/bin/python
print "JavaScript

\n";\n";
On February 25, 2020 4:08:52 PM CST, "Christian K."<EMAIL_ADDRESS>wrote:

Yes,
The api key is in a single line of JavaScript.
I use English and speak a little Spanish.
This is what they sent me:
JavaScript

On February 25, 2020 3:55:19 PM CST, Guennx<EMAIL_ADDRESS>wrote:

I guess these personal api keys are for java script, are there api
keys
for python. Which language do you use
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/OpenJarbas/py_responsivevoice/issues/7#issuecomment-591090057

-- Sent from /e/ Mail

-- Sent from /e/ Mail

fixed in release 0.5
Still without needing an api_key ;)


ks version missing/incorrect data

kubecfg version: dev-2017-11-28T11:52:46-0800
jsonnet version: v0.9.5
client-go version: v1.6.8-beta.0+$Format:%h$

Expected:

Version of ksonnet tool itself (e.g. 0.7.0)
client-go version looks wrong

ok, after some investigation.

The version of the ksonnet binary will be reflected as soon as I make a release cut documented here: https://github.com/ksonnet/ksonnet/blob/master/CONTRIBUTING.md#make-a-release. This will have to happen after the code freeze thursday.
See explanation in https://github.com/ksonnet/ksonnet/issues/121

I've opened a PR to change the name of kubecfg to ksonnet #171.

Looks like this comes from upstream:
gitCommit    string = "$Format:%H$"    // sha1 from git, output of $(git rev-parse HEAD)

They have a build process that preprocesses files.

Turning this into a release checklist:

[ ] Create v0.6.0 tag
[ ] Create the Github release
[ ] Update homebrew to install v0.6.0


js: Add reference decoder by Jasper

This is the reference decoder implementation.
It follows the decoder interface and should be a drop-in replacement for the actual decoder from meshopt_decoder.js.
It is provided for educational value and is not recommended for use in production because it's not performance-optimized.


Handle "Plumb Blow'd Up" Better

If there are unhandled exceptions, make sure that there is a way for clients to find out about them. For in-process stuff, this could just be ensuring that there are relevant events with exceptions. If the Issue #16 separate-process stuff works, would need to consider sending exception data back via the result Intent.

Addressed via #171


Scale in ratio

Scale the spatial view in ratio, so that there is no scoll bar

Multiplied with 0.5 reduced the problem, but does not solve it


Blank Umami screens on android

i used to be able to check Umami on my phone, now i get just a series of blank screens - dashboard, websites, anything else - except for the Umami header with logo and hamburger, and the footer. the only page that loads is the settings > profile page. always used to work until the last update, same in 1.40.0. on pc all is correct and working. just not android.

Nothing that I can see. It's like it's there but it's not.


Resolve urlencode import with tolerance for Python 3

@martey I pushed needed fixes. Would you please CR again?


Test fails on macOS

$ yarn test
yarn run v1.15.2
$ npm run build && jest
npm WARN lifecycle The node binary used for scripts is /var/folders/v7/6kzxdgb93x328tk9pg633s200000gn/T/yarn--1552870982981-0.9442051424146831/node but npm is using /usr/local/bin/node itself. Use the `--scripts-prepend-node-path` option to include the path for the node binary npm was executed with.

><EMAIL_ADDRESS>build /Users/styfle/Code/zeit/webpack-asset-relocator-loader
> ncc build src/asset-relocator.js

1290kB  dist/index.js
1290kB  [8752ms] - ncc 0.15.2
 FAIL  test/project.test.js
  ● should correctly run webpack build project-chunking

    expect(received).toBe(expected) // Object.is equality

    Expected: "asset.txt"
    Received: ""

      at eval (eval at <anonymous> (test/project.test.js:13:7), <anonymous>:5:39)
      at eval (test/project.test.js:13:7)
      at Object.<anonymous>.it (test/project.test.js:11:5)

 PASS  test/index.test.js (8.422s)

Test Suites: 1 failed, 1 passed, 2 total
Tests:       1 failed, 31 passed, 32 total
Snapshots:   0 total
Time:        8.988s
Ran all test suites.
error Command failed with exit code 1.

@guybedford See the Circle CI output in #6
It looks like both Linux and macOS are failing the same test.