[Python] Added a new python_format.py script to the utils directory we can use to automatically check the formatting for all the Python sources in the project.

This script is intentionally written in Python 3 as the black tool does not work with Python 2.7. I don't expect we will start using this script yet, but I wanted to add it for future use.

@swift-ci please smoke test

@swift-ci please smoke test

@Rostepher Thanks for the reply in #26462. I have read this PR since it was mentioned in #29719, but perhaps my point wasn’t articulated well enough.
I understand the point of any automated formatting tool is to unify coding style on the whole project and to minimize avoidable conflict over personal preferences. We already follow pythonic best practices with python_lint.py and enforce these during smoke test on each PR.
From the quick inspection of Black, it seems the point of that particular formatter is to have 0 configuration options. I find that philosophy rather extreme, since it denies programmers any choice to express one’s thoughts in a readable way to fellow humans. Instead it offers just blind enforcement of rigid rules. As can be seen in #29719, the end effect is actually lower source code readability, since it often turns carefully crafted concise expressions into exploded multi line monstrosities.
Given that we already use python_lint.py to unify Python coding style across the project, what is the actual issue on our project that using Black will solve?
Personally, I don’t see a good reason to disrupt development by mass source code changes, replacing single quote with a double quote everywhere, to get a less readable source code in the end. Did I miss any discussion on Swift forums that lead to this being the project’s consensus going forward? CC @eeckstein @gottesmm


Check thermos.sh script for correct \n escaping

Tests revealed that the newline escaping in thermos.sh might be faulty due to tailing whitespace between the backslash and '\n'.
Todo: Check and fix if necessary.

Fixed by commit e44c22bffd2a98b01a96daf27dc14ae3c11dbd38


New Website Logo: Academia.edu

Organization name: Academia.edu
Homepage url: https://www.academia.edu
Logo url: https://a.academia-assets.com/images/academia-logo-redesign-2015.svg

Details: Turning strings into structured paper and author data, faster than Ruby

Added to the website. Thanks!


Use walkDecls instead of eachDecl

Resolves deprecation message according to postcss/postcss#487

:+1: Been meaning to update this. It appears the travis build is failing, likely due to the package.json using the older version of PostCSS. Would you be able to bump to the latest version for the PR and I'll get this merged in.

Closing due to inactivity. I've updated to work with PostCSS 5 and updated deps so tests pass.

Ah! Sorry. I completely missed this. Thanks for the update, this is brilliant :+1:

No problem @BarryThePenguin :smile:


Perlin: hitting float limit causes constant output

After letting the Perlin module run for a while the curTime variable (a float) if "full" hitting the float limit and adding deltaTime to it does not have any effect anymore, hence producing a constant output.

good spotting :)
thx

I made a quick patch (resetting the variable), but at some point I'll go back to this and figure out the better way to do it.
Calling it close for now ;)

Thank you. If you update the Makefile to version 0.6.1, I'll pull the new version in the Plugin Manager.

checking the new plugin page and updating in the next days :)


deleting code that is no longer defined in the repos

say I have a myrepos.repos file that is imported by a workspace setup script like:
vcs import < repos/myrepos.repos
myrepos.repos is in version control and contains a set of repos that changes over time, sometimes repos are added and sometimes taken away.
Currently, if a repo is deleted from myrepos.repos - the previously cloned subrepo persists. Is there some supported way I can have vcstool automatically delete everything that is not defined in myrepos.repos?
I could simply rm -rf src before running vcs import but unfortunately downloading is expensive as there are a number of very large (LFS) files in the repos.

I was looking for this feature inside of the vcstool. Is there a plan to make it available?
Or at least to have a command allowing users to explicitly request a warning that a repository is present when they call vcs import (this issue seems to be similar to such functionality). If the system is big, dynamic, and relies heavily on vcs tool - like autoware - it is quite difficult to keep track of changing repositories without such a feature.

This is a problem in gitlab CI with the default git strategy. Clones in CI get polluted with old repos, and there isn't a way to clean it out.
https://docs.gitlab.com/ee/ci/pipelines/settings.html#choose-the-default-git-strategy
If you take care of using a good .gitignore that matches the repos file, then you could try cleaning out the local git directory after checkout.

Wow, this workflow is also broken when a fetch git strategy.

Have a .repos file that has a repo on branch branchA

repositories:
   my/repo1:
      type: git
      url: git@github.com:my/repo1.git
      version: branchA

Commit a change to the .repos file where you switch branches to branchB

repositories:
   my/repo1:
      type: git
      url: git@github.com:my/repo1.git
      version: branchB

And, the CI checkout script is as follows:
vcs import --input my_sources.repos src --debug --force --shallow
vcs pull src
vcs status src

The import and pull succeeds, but vcs status still shows my/repo1 is at branchA.
We have a mix of local repositories and cloned reposities in the src workspace. Being able to clear out the src directory and use VCS to check out the correct branch when using fetch strategy for the top workspace would be extremely helpful to keep CI fast.
For now, we will have to change to a pull strategy and do a lot of I/O in jobs.


Bug: Verse div's "id" and "data-verse" properties = none

This bug is intermittently occurring on both surge and dev builds (and at this time cannot be reproduced).
Workaround: clean node modules and run npm run clean:all to reset and that fixes it.

This issue was fixed by updating proskomma


Update to v1

Description
V1 of the Data Package and Tabular Data Package specs are in release candidate stage. The Python and Javascript libraries have been updated. While there are still a couple of things unresolved, this library can be updated to support V1 of the specs now.
Tasks

[x] Review the whole family of specifications
[x] Review the implementation notes
[x] Review either the Python (Data Package Table Schema) or JavaScript (Data Package Table Schema) reference implementations (whichever language you feel most comfortable reading)
[x] Review the stack reference
[x] Review the blog post that announces v1 of the specifications
[x] Review the test packages that can be used to test your work (in addition to the normal and expected unit tests)
[x] Review the OKFN Coding Standards

Parts of the coding standard are language specific, and parts are workflow specific. The workflow points are important for you. If you want to contribute language-related standards to our docs for your language, we welcome it!

[x] Write a set of high-level issues for each library, on the respective issue tracker, that outline the work plan. Do this with some feedback from @roll who has done V1 updates for the Python and Javascript libraries

Note the structure of this issue: A narrative description and a specific list of tasks. Follow a similar pattern
The sequence of work is important: start with the Table Schema library first, as the Data Package library has a direct dependency on it

The issues concerned with updating this gem to Table Schema v1-spec can be found under Version-1 label.


Removed docker logo

I have read all the guidelines and have tried my best to adhere to them. As mentioned in issue #30948 I have updated the visual representation for a container without reference to the original docker logo. Since it was an image, I had to replace the entire file and also created a SVG for reference to any future contributors.
This is my second PR regarding the same issue as my previous PR #30978 was a bit of a blunder on my part as I am new to Git.
Any feedback and suggestions/criticism are very much welcome/appreciated.

/kind cleanup

/kind cleanup

what do I need to do?

Hi @RayAsh37, thanks for this! We can close the other issue as this looks like it's sorted all the git issues we were running into.
Deploy preview: https://deploy-preview-31338--kubernetes-io-vnext-staging.netlify.app/docs/concepts/security/overview/
/lgtm

/assign @celestehorgan

@nate-double-u thanks for being so patient with me. Due to the mistakes, I have learnt a little more about Git and contributing to Open Source as a whole.

No problem, happy to help!

@celestehorgan hey, I had to create a new PR (but with the same changes) since I messed up my previous one. Please review.

/approve
Nice cleanup


adding datadog document

I am fine with things. Ready to merge.

Pierre,
Thanks for your message. I am hoping also that there is nothing else I
have to do with this pull request. I am also sometimes confused by
github.
I am working on the New Relic version, which seems to be very similar to
Datadog. I have also been thinking about how to link these docs. Perhaps
an entry for "metrics" in the main left-hand menu?
Jim
On 2021-11-03 04:07, Pierre-Alexandre Meyer wrote:

Thanks for the review! We probably still need to provide a link to
that new doc (from the AWS docs maybe?).
--
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub [1], or unsubscribe
[2].
Triage notifications on the go with GitHub Mobile for iOS [3] or
Android [4].
Links:
[1]
https://github.com/killbill/killbill-docs/pull/275#issuecomment-958806028
[2]
https://github.com/notifications/unsubscribe-auth/AHELNHYK334K2LKHH2KP3FTUKECUJANCNFSM5GVXWXSQ
[3]
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
[4]
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub


Hosting problems on azure

I've deployed project to Azure App Service, everything went ok, except after some random amount of time kestrel seems to loose requests.
In logs I see something like
info: Microsoft.AspNet.Hosting.Internal.HostingEngine[1]
Request starting HTTP/1.1 GET http://renta-api.azurewebsites.net/projects
without any continuation. Than after some time everything is working ok.
Maybe this is an issue with HttpPlatformHandler.
Here is its configuration
<handlers>       <add name="httpplatformhandler" path="*" verb="*" modules="httpPlatformHandler" resourceType="Unspecified"/>     </handlers>     <httpPlatform processPath="%home%\site\approot\web.cmd" arguments="" stdoutLogEnabled="false" stdoutLogFile="\\?\%home%\LogFiles\stdout.log"
PS I use standard right-click deploy project method.

This issue was moved to aspnet/KestrelHttpServer#698


Add SineWaveSequenceGenerator

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (fd99f66) 100.00% compared to head (36b843c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #39   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           28        29    +1
  Lines          834       854   +20
  Branches        73        73
=========================================
+ Hits           834       854   +20

Files Changed
Coverage Δ

src/startorch/sequence/__init__.py
100.00% <100.00%> (ø)

src/startorch/sequence/wave.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Sankey visualisation

Implement a standalone ng2 component providing a sankey visualisation, fit for the initial prototype (Described in #1)

Scrapped for now


useMMKVObject hook causing issue in app.

I am getting this error when using useMMKVObject hook within our own custom hook wrapper. While this issue is related to redux it is being initiated by the set call in the hook. In order to work around this I switched the code to use without the hook but also believe I lose the listener effect that a hook. Any help or insight would be appreciated, and thank you for the library.
const useSubscription = (shouldHandleRedirect = false) => {
  const subscription = useSelector((state) => state.iapSubscription)
  const [localSubscription] = useMMKVObject('subscription')
  // .. replacing with line below fixes the issue
  // const localSubscription = JSON.parse(storage.getString('subscription'))

  const [isConnected, setIsConnected] = useState(true)

  const userProgram = useSelector(
    ({ firestore }) => firestore.data?.userProgram
  )
  const [hasSubscription, setHasSubscription] = useState(true)
  const userRole = useSelector(
    ({ firebase: { profile } }) => profile?.role
  )
  const dispatch = useDispatch()

  const navigation = useNavigation()

  useEffect(() => {
     // Work with data...
  }, [subscription, localSubscription, isConnected, userRole, userProgram])

 ...
}

Same +1

Hmm, maybe it's because of this? https://github.com/mrousavy/react-native-mmkv/blob/77982c1a61a5e6d2683e6569ca92e09390b28c48/src/hooks.ts#L90-L98

Hey! Sorry I cannot reproduce the issue here and it has been inactive for a while.
I am going over issues right now and want to keep the repo clean - so I'm closing this for now, if anyone can post a reproduceable example here I can re-open and take a look :)


Update google-auth-library-credentials to 1.17.0

About this PR
📦 Updates com.google.auth:google-auth-library-credentials from 1.8.1 to 1.17.0
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.auth", artifactId = "google-auth-library-credentials" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.google.auth", artifactId = "google-auth-library-credentials" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #281.


validation on register form

Use validation package to show form error

Today i was working on form validation task and  it's completed
In this task i used two form validation packages like formik and yup
This is my form validation branch
https://github.com/narinder07/intern-best-practices/tree/form-validation
This is my commit branch
https://github.com/narinder07/intern-best-practices/commit/507b6606fa6ec8ba4871b9b787cc6fbc7fedb112


Question: Dynamic import.

All pages generate routes that are 'Promise: import(name)->Promise.'
I want him to be static import, all of them. What should I do?

This is not the good repo.


Stream to file leads to WinError 2 Exception

Hi, i am trying to capture video on Python using the Ps3eye and pseyepy using this code:
from pseyepy import Camera,Stream
c = Camera()
s = Stream(c, file_name="test_movie.avi")

I got everything to work, using Display(camera) i can see the video, but the saving of the video using Stream results in the following exception:

Exception` in thread Thread-9:
Traceback (most recent call last):
File "C:\Users\osswa\anaconda3\lib\threading.py", line 932, in _bootstrap_inner
self.run()
File "C:\Users\osswa\anaconda3\lib\site-packages\pseyepy\io.py", line 193, in run
ff = self.klass(timestamps=True, **mpm)
File "C:\Users\osswa\anaconda3\lib\site-packages\pseyepy\io.py", line 96, in init
self.proc = sp.Popen(self.cmd, stdin=sp.PIPE, stderr=sp.PIPE)
File "C:\Users\osswa\anaconda3\lib\subprocess.py", line 854, in init
self._execute_child(args, executable, preexec_fn, close_fds,
File "C:\Users\osswa\anaconda3\lib\subprocess.py", line 1307, in _execute_child
hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
FileNotFoundError: [WinError 2] The system can't find the specified file

No video file is created, but a test_movie_time_0.txt file is created in the folder of the python script.
I assume theres something wrong with my FFmpeg, but i cant find the issue. I set the system PATH variable to the FFmpeg\bin folder, and using the basic ffmpeg commands with already existing files works as well.

I still couldn´t solve this issue.
Could the reason be line 85 in io.py?
self.cmd =     ['/usr/local/bin/ffmpeg',
....
]

As far as i understand, '/usr/local/bin/ffmpeg' is a path in Linux, but i am using Windows.


Codename of Trisquel Flidas should be lowercase "flidas"

$ distro
Name: Trisquel GNU/Linux Flidas (8.0)
Version: 8.0 (Flidas)
Codename: Flidas

$ cat /etc/os-release
NAME="Trisquel GNU/Linux"
VERSION="8.0, Flidas"
ID=trisquel
ID_LIKE=debian
PRETTY_NAME="Trisquel GNU/Linux Flidas (8.0)"
VERSION_ID="8.0"
HOME_URL="https://trisquel.info/"
SUPPORT_URL="https://trisquel.info/wiki"
BUG_REPORT_URL="https://trisquel.info/project/issues"

$ cat /etc/apt/sources.list.d/flidas.list
deb http://mirror.fsf.org/trisquel/ flidas main

I fail to see why it should be lowercase. It isn't written in lowercase in the release file.
It would be inconsistent with the current implementation, as we currently provide the code name as is.
If you intend to say that all code names should be lowercase, that's a different issue and should be discussed in a wider context.

Hey @ian-kelling, it looks like Trisquel's OS-RELEASE file does not honor VERSION_CODENAME [1] attribute.
As distro does not perform distribution codenames normalization, nor special cases handling [2], I guess this is an "upstream" issue.
Feel free to re-open if you don't think so, bye 👋

[1] : https://www.freedesktop.org/software/systemd/man/os-release.html#VERSION_CODENAME=
[2] : https://github.com/python-distro/distro/blob/c613bdfe2ae4f8b823e38376f537b1d07bac6bd3/distro.py#L1058-L1076


Adds check to see if dictionary array passed to sqk_insertOrUpdate is valid

Includes a check to see if dictionary array is valid before attempting to filter nil or empty array.

Hard to decide whether this belongs in or not. It's tempting to just allow the invalid value since it makes calling code nicer to read, but I feel like it should probably crash if called with nil, just as if an app would crash if you tried to insert nil into an array.
It's similar in a way, since in both you are attempting to insert data. The precedent is set by Foundation, so for now, not going to merge.
You could always make you're own method that wraps sqk_insertOrUpdate and does the check.


fix(planning_test_utils): rename header directory to match project name

Description

This PR renames the directory where the headers are to match the name of the package to follow the conventions of the other packages.
See https://github.com/autowarefoundation/autoware/issues/4070
Tests performed

Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kyoichi-sugahara thanks for the review. I can't merge this PR despite being approved, can you merge it for me? Thanks.


glTF loader exception handling

This change makes it such that you can now do the following:
var onError = function (scene, message, exception) {
    if (exception instanceof BABYLON.LoadFileError) {
        if (exception.request) {
            alert(exception.name + ": " + exception.request.status);
        }
    }
};
BABYLON.SceneLoader.Append(rootUrl, sceneFilename, scene, onSuccess, onProgress, onError);

I have verified the Tools.LoadFile change in IE11, Edge, Chrome, and FireFox on Windows 10.

@deltakosh @sebavan Perhaps should test on Safari before merging?

Do you want it in 3.1?

Perhaps not. @sebavan Do we need this in 3.1?

we ll merge it just after to prevent issues in 3.1. this can wait 2-3 more days. thx Gary


+6 icons

Description
Added a few icons for common Japanese apps, hope to keep adding more in the future.
Icons addition information
Added
ICOCA ( jp.co.westjr.android.icocaapp/crc64fa0dbc8111ab4fb7.MainActivity )
JOYFIT ( jp.joyfit.joyfitappandroid/jp.joyfit.joyfitappandroid.MainActivity )
Mynaportal ( jp.go.cas.mpa/jp.go.cas.mpa.presentation.view.eventcontrol.EventControlActivity )
くら寿司 ( jp.co.kura_corpo/jp.co.kura_corpo.SplashActivity_ )
モンベル ( jp.montbell.montbellofficialapp/jp.montbell.montbellofficialapp.SplashActivity )
ヤマレコ ( com.yamareco.memo/com.yamareco.memo.ui )
Contributor's checklist

[x] I followed the Lawnicons guidelines and will make changes if someone suggests. I will also make sure that Lawnicons builds correctly.+

Flubbed some spaces in the XML, fixing now.


Update diagrams, add multiple nodes IR setup

AFAIK the Credential Manager app does not exist anymore in V2. Please update the diagrams accordingly and show how the setup and firewall configuration looks in case multiple nodes are used for the IR.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 32785d15-8202-6e44-f1d2-420ef0600f3f
Version Independent ID: 3af5fa49-7bd4-18ce-f8dc-aa4a2b8c6478
Content: Create a self-hosted integration runtime - Azure Data Factory
Content Source: articles/data-factory/create-self-hosted-integration-runtime.md
Service: data-factory
GitHub Login: @nabhishek
Microsoft Alias: abnarain

@timoklimmer - Thanks for posting the valuable feedback. I am moving it to content author to review and share their thoughts.
@nabhishek - Can you please take a look?

#reassign @lrtoyou1223
Can we remove Credential Manager and replace with local powershell in this article?  Thanks!


[Class modifiers] Analysis server / IDE support work

This is the issue tracking the work that needs to be done in the analysis server to support the class modifiers feature. If you decide to work on a feature, either create an issue for the feature and link to it from here, or put your name beside the feature so that we don't duplicate effort.

[x] Call Hierarchy
(brianwilkerson, NA)
[x] Closing Labels
(brianwilkerson, NA)
[x] Code Completion
Need to suggest the new modifiers and filter out suggestions that are invalid based on class capabilities
[x] Code Folding
(brianwilkerson, NA)
[x] documentSymbol
(brianwilkerson, NA)
[x] Flutter Outline
(brianwilkerson, NA)
[x] Hovers
Need to add the new modifiers to the hover help
[x] Implemented Markers
(brianwilkerson, NA)
[x] Navigation
(brianwilkerson, NA)
[x] Occurrences
(brianwilkerson, NA)
[x] Organize Imports
(brianwilkerson, NA)
[x] Outline
NA
[x] Overrides Markers
(brianwilkerson, NA)
[x] #51496
Needs review
[x] #51440
(@pq)
[x] Refactorings - legacy
(brianwilkerson, NA)
[x] Refactorings - self describing
(brianwilkerson, NA)
[x] Search - Find References
(brianwilkerson, NA)
[x] Search - Member Declarations
(brianwilkerson, NA)
[x] Search - Member References
(brianwilkerson, NA)
[x] Search - Top-level Declarations
(brianwilkerson, NA)
[x] selectionRange
(brianwilkerson, NA)
[x] Semantic Highlights
Highlight new keywords
[x] signatureHelp
(brianwilkerson, NA)
[x] Snippets
(brianwilkerson, NA)
[x] Sort Members
(brianwilkerson, NA)
[x] Type Hierarchy
(brianwilkerson, NA)

We're pushing Class Modifier quick-fixes until post-beta (pending further investigation into what we want to support) so I think this issue is good to close as complete.


Update README.md version env var name

It should be PLUGVERS instead of PLUGINVERS.

Good find!  Thank you.


[P1] How did you create the validation set for Commonsense reasoning hyperparameter tuning?

The paper mentions taking the last 300 examples for math reasoning, but I can't seem to find that for Commonsense.
Thanks!

@Edenzzzz thanks for your question! our hyperparameter tuning process is described above, on pg. 22 Appendix C. we are using the last 300 examples from  the GSM8K training set for hyperparameter tuning.
to translate this into code, you can view it at,
https://github.com/stanfordnlp/pyreft/blob/main/examples/loreft/dataset.py#L109
    def postprocess(self, kwargs):
        original_dataset_size = len(self.task_dataset)
        if self.task in ["gsm8k"] and \
            self.original_data_split == "train" and self.test_split == "validation":
            self.task_dataset = self.task_dataset.select(
                range(original_dataset_size - 300))
        if self.task in ["gsm8k"] and self.original_data_split == "validation":
            self.task_dataset = self.task_dataset.select(
                range(original_dataset_size - 300, original_dataset_size))
        self.raw_dataset = self.task_dataset # also update the raw dataset pointer.
        return

we use the remaining (minus that 300 examples) as our training set, and evaluate our models on that hold out 300 examples.
i also updated our README to provide example script to run hyperparameter tuning:
https://github.com/stanfordnlp/pyreft/blob/main/examples/loreft/README.md#hyperparameter-tuning

Thanks for your quick reply! I was also wondering if it'd be better to use the eval datasets of Commonsense reasoning (boolq, piqa etc.) instead of a math reasoning dataset.

@Edenzzzz yes, i think it would be interesting to see the performance. there are two main reasons why we did this:

This ensures a somewhat fair comparison to LoRA/DoRA. LoRA parameters are tuned on the math reasoning datasets provided in the LLM-Adaptors paper. They tune on math reasoning datasets and test on commonsense reasoning. DoRA follows this paper. So, we thought it would be better to follow a similar paradigm.

We pick GSM8K train for our HT to ensure there is no data leakage. Based on my readings of LLM-Adaptors paper as well as their repo (correct me if i am wrong), they did their HT search on the actual math test dataset (i.e., selecting ranks, modules to apply LoRA, etc..), which is not ideal. To avoid this while keeping a similar searching paradigm, we pick GSM8K train (last 300 examples).

Besides these two practical reasonings, I would agree it is better to do separate tuning for all methods (which means a full HT search for all methods on commonsense reasoning dev). Given the time limit, we end up with the current solution.

Closing this issue for now, feel free to reopen if there are new issues! Thanks!

Thanks for your detailed reply! I haven't found hyperparameter tuning details in the paper, but this might be what you meant.

They subsequently mentioned training on CommonSense 170K and Math10K, aligning with your paper.


7.1.0: Remove hardcoded allowlist of Sentry environment names.

active_sentry_environments was a hard-coded list of allowable values for the Sentry environment tag. It was introduced during the Replatforming discovery phase in 2020 in order to prevent the Puppet/EC2 stack in the test account from sending events to Sentry.
(It was done this way because at that time, disabling Sentry in the test environment was more difficult than it should have been, while some teams had Sentry alerts and Slack subscriptions which didn't select by environment).
We don't need this feature any more and we're now better off without it, because it complicated the semantics of SENTRY_CURRENT_ENV in a way that is surprising to the user.
This fixes a current problem where apps in the integration cluster are unable to send events to Sentry.
If we want to run without Sentry in future, we can just not set SENTRY_DSN.
Rollout: requires all the affected apps to update to govuk_app_config 7.1 (i.e. this release) in order for the fix to take effect :(

Could backport this into a 6.1 release as well if we need to get this out sooner, maybe? (Then again, maybe the Sentry bug will encourage teams to update to v7 😈😆)

On second thoughts, if we want to get the fix out asap then it's gonna be easiest just to update everyone to v7 en masse; it's a pretty straightforward upgrade (just removes Unicorn, which nobody's actually using any more afaik)


Antivirus detection

For some reason when I try and download the skin changer my antivirus software (ESET antivirus) keeps detecting trojan virus in the files and it gets removed when I download it. Please help ;*(

Also if you were wondering witch file it removes it is this one (Win64/Agent_AGen.AKX)

Disable your antivirus since the program use unsual win32 apis, thats why its false positive


Optimize wrap buffer cumulation in SslHandler and don't mutate input buffers

Motivation:
SslHandler doesn't support sharing the input buffers since the input buffers get mutated. This issue has been reported as #14069. Fixes have already been made to support the use case using read-only buffers as input. However, this is not useful for existing Netty applications.
I checked the Netty code once again and noticed that it's possible to optimize the current implementation in SslHandler and avoid the buffer mutation.
The default behavior in SslHandler causes very hard to debug problems. In Pulsar, there have been issues open for multiple years that have been caused by the SslHandler's default behavior of mutating the input buffers (apache/pulsar#22601 is one starting point to the issues).
The current implementation of SslHandler will mutate the input buffers by using the input buffer as a cumulation buffer when there's available capacity. This is not optimal at all. This PR contains an improvement where the cumulation buffer is allocated to the final size immediately so that cumulation is more optimal. That's why I think that this will be more optimal in the end and won't cause performance regressions.
After these changes, it should be possible to pass a slice or duplicate of a buffer and the input buffer doesn't get mutated. The input buffer's readIndex will be modified so multiple threads cannot share the same input buffer without a slice or duplicate.
I created a failing test case that shows that a duplicate buffer doesn't prevent input buffer mutation.

It's a very surprising behavior of SslHandler that passing a .retainedDuplicate() buffer could result in mutations to the original buffer. That's another reason why I think that SslHandler shouldn't ever mutate the inputs.
Modification:

add protected ByteBuf composeFirst(ByteBufAllocator allocator, ByteBuf first, int bufferSize) to AbstractCoalescingBufferQueue to support allocating an optimal cumulation buffer instead of using the input buffer as a cumulation buffer
remove dead code from compose where there was handling for CompositeByteBuf

composeFirst will be called before compose so this case isn't needed.

Result:
Fixes #14069 without the need to set the input buffer as read-only

@normanmaurer Thanks for the review. I applied your suggestions. PTAL

The issue #12919 explains why SslHandler has been causing issues in Apache Pulsar. The incoming messages come from the network and use LengthFieldBasedFrameDecoder which slices the buffers. The buffer used by LengthFieldBasedFrameDecoder gets mutated by SslHandler later when the same buffers are passed to Apache Bookkeeper client which also uses Netty and contains SslHandler.
Issue #12919 references vert.x issue https://github.com/eclipse-vertx/vert.x/issues/4509 . It seem vert.x applied a workaround in https://github.com/eclipse-vertx/vert.x/issues/4517 .
Found also a workaround data corruption issue within Netty, #11802. That was to address #11792.

@franz1981 do you also have a chance to review this PR? Thanks!

As a followup, I also created #14093 with the title "Duplicate of slice should have the same capacity as the original slice so that it's not writable" to address the issue #12919 by @vietj, "ByteBuf slice duplicates are not slices".
(In Pulsar, that's why SslHandler was able to corrupt the input buffer of LengthFieldBasedFrameDecoder since calling .retainedDuplicate later in Pulsar code "removed" the slice created by LengthFieldBasedFrameDecoder.)


Update rails testing for ruby 3.0

Description
Currently, none of the released versions of rails work on 3.0. So we have removed all rails tests from running on 3.0 until new versions are released that support 3.0.
Once a fixed versions are released, add these to our CI and enable rails testing for 3.0

6.15.0 released!

6.15.0 released!


[FRAAS-1455] Update OTP to Verification Code

The name change also affects the example in one REST call.

Yep, I suggest also renaming the OneTimePasscode env variable to VerificationCode or equivalent. And replacing all references in the postmant collection

d'oh. I missed that.

Previously approved. Encountered and resolved a trivial conflict. Merging based on previous approvals, based on time constraints.


Tweak browser back button behaviour

Prevent history.pushState in a few cases.

use history.replaceState (replace)

when user opens account details page and clicks Transactions link
http://localhost:1234/mainnet/emerald/address/0xCB2412a993f406eFf10a74011410a4F35e3549E3
http://localhost:1234/mainnet/emerald/address/0xCB2412a993f406eFf10a74011410a4F35e3549E3#transactions

when user opens block details page and clicks Transactions link
http://localhost:1234/mainnet/emerald/block/6236663
http://localhost:1234/mainnet/emerald/block/6236663#transactions

Needs manual control or ReactLink replace cannot be 1 to 1 match of pathname and search

when user opens account details page and clicks Show More tokens
http://localhost:1234/mainnet/emerald/address/0xba504818fdd8d3dba2ef8fd9b4f4d5c71ad1d1d3
http://localhost:1234/mainnet/emerald/address/0xBA504818FdD8D3dBA2Ef8fD9B4F4D5c71aD1d1D3/tokens/erc-20#tokens

when user opens account details page and clicks a token pill in Tokens row
http://localhost:1234/mainnet/emerald/address/0xba504818fdd8d3dba2ef8fd9b4f4d5c71ad1d1d3
http://localhost:1234/mainnet/emerald/address/0xBA504818FdD8D3dBA2Ef8fD9B4F4D5c71aD1d1D3/tokens/erc-20#oasis1qzk2y3kvp7000qck8zjsmwadhy3lumnmdys20x3z

history.pushState (default behaviour)
TBA

Options:

RouterLink with full match + manual control of replace prop
RouterLink with partial match
Manual control of replace prop (pass prop through SearchResult), remove RouterLink

Is the writeup "current behaviour" or is it the goal. And:

Needs manual control or ReactLink replace cannot be 1 to 1 match of pathname and search

when user opens account details page and clicks Show More tokens
http://localhost:1234/mainnet/emerald/address/0xba504818fdd8d3dba2ef8fd9b4f4d5c71ad1d1d3
http://localhost:1234/mainnet/emerald/address/0xBA504818FdD8D3dBA2Ef8fD9B4F4D5c71aD1d1D3/tokens/erc-20#tokens

history.pushState (default behaviour)

when user clicks tabs in Account Details
http://localhost:1234/mainnet/emerald/address/0xCB2412a993f406eFf10a74011410a4F35e3549E3
http://localhost:1234/mainnet/emerald/address/0xCB2412a993f406eFf10a74011410a4F35e3549E3/token-transfers#transfers
http://localhost:1234/mainnet/emerald/address/0xCB2412a993f406eFf10a74011410a4F35e3549E3/tokens/erc-20#tokens

Show More tokens does the same thing as clicking tabs. Is the difference because of lowecase address in first URL?

Option 4: RouterLink with full match + convert tab paths to hash

Option 4: RouterLink with full match + convert tab paths to hash

how this can work with tokens/erc-20#oasis1qpyyglghqwzfqpwuvcmvehkxc24r8f5leq3cp3mk  ?

Option 4: RouterLink with full match + convert tab paths to hash

how this can work with tokens/erc-20#oasis1qpyyglghqwzfqpwuvcmvehkxc24r8f5leq3cp3mk ?

we would need a custom hash syntax :/ And it becomes odd when pagination is supposed to be kept in history, but tabbing isn't
/token-transfers?page=2 -> ?page=2#/token-transfers


Drop confusing *LibName variables

These make the code very confusing and I cannot understand the use case. Multiple architectures cannot exist in the same CMake project. When installing, multiple architectures should probably be installed to different locations, not have different names. The native CMAKE_<CONFIG>_POSTFIX variable can be used to append arbitrary suffixes to installed libraries.
This removes changes from #1538. I may not have all the context here. So I'd appreciate any insight @jgonzalezdr has on what this was originally intended to support.

Coverage remained the same at 99.64% when pulling 17ce4b65a4198640c95a0f3dabc50e0a9ca89411 on thetic:disconfuse into 8cc621c113c7275b524ebdc8330a2b214fd4de6a on cpputest:master.

@jgonzalezdr Any comments on this ?

As no feedback, I'll merge this for now.


Failing assertions hang

The assertFn(...) calls appear to hang whenever an assertion fails. It doesn't output the step name, just remains stuck after the previous successful step.
I am using version 1.0.1.
For example with I should see "foo" I added a console.log before and after the call to assertFn(html, expectedText) in assert-dom.js. The second log is never reached when the html doesn't include foo, but is when the html does include foo.
I tested a try...catch block around it and the AssertionError is thrown correctly, so it does appear the issue is not with chai as far as I can tell.

I've been running it through grunt-cucumber, doing this causes it to hang.
Testing it with cucumber-js directly actually just causes it to end the process at the failing test (still without outputting it to the terminal).

Essentially it looks like the AssertionError thrown by chai isn't caught correctly in cucumber-mink.
I wrote a quick example to test it outside of cucumber-mink which confirmed it isn't a problem with chai or cucumber:
  Scenario: This is a failing scenario
    When I go to the homepage
    Then I should be on "/login"
    And failing example
    And I should see "this text doesn't exist"

var chai = require('chai');

module.exports = function () {
  this.Then(/^failing example$/, function (callback) {
    try {
      chai.assert.include('foo', 'bar');
    } catch (e) {
      callback(e.toString());
    }
  });
}

Not sure where to take it from here, sorry!

Hi @lsjroberts,
Thanks again for your feedback, i'll look into it quickly :)

@lsjroberts i made some changes in #25, can you test it with your custom runner ?

@Adezandee Sure will do, I'll give a run when I'm back in the office tomorrow

@Adezandee Yep, that works correctly thanks very much :)

@lsjroberts Great, gonna merge it and release a fix aka. v1.0.2.
I released a new documentation page also, http://cucumber-mink.js.org/steps/
don't hesitate if you have any feedback about it, missing step etc. Thanks !


Add default help content to the assets folder

Fixes #12980
PR Summary
Add the default.help.txt file to the repository instead if consuming it from MyGet as a nuget package.
PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

@PoshChan please remind me in 24 hours

@rjmholt, this is the reminder you requested 24 hours ago


System.InvalidOperationException: Column: Ownership Status Does not exist

I'm pretty new to easy repro.  I'm tasked to fix issues in the existing test code and build additionally on top of that.
In a custom grid displayed, which I click to sort that grid using a column name, it gives me this exception.
xrmBrowser.ThinkTime(2000); xrmBrowser.Grid.Sort("Ownership Status", 3000); xrmBrowser.Related.OpenGridRow(0);
The reason for sorting is to get the current owner in the first record of the grid.
I tried using this line as well
xrmBrowser.Grid.Sort("Ownership Status", 3000);

@TYLEROL Could you please help?

I'm back from vacation and will look at this today.

Just updated develop with a fix for the sort.  Please test the latest changes.

Just updated develop with a fix for the sort. Please test the latest changes.

@dtu11  I need to get the latest changes and try?

Yes pull down the latest develop branch and test it.

There are quite a few people on holiday leave so there is a hold on pushing this out to release and Nuget until Jan 3rd.   I'll work with Tyler to get this out to Nuget after the holidays.


Integrate Welcome bot

I can add a welcome bot config file having a proper message that will show up when any user will open up an issue or pull-request for the first time.
For reference, check out: https://github.com/apps/welcome

I would love to work on this issue as a part of DWOC.

I would love to work on this issue as a part of DWOC.

Sure go ahead. Please do add the below details to the template,
🌟 Star it 🍴Fork it 🤝 Contribute to it!
Discord server - https://discord.gg/tTJQxvSaDP
Happy Coding,

Sure go ahead. Please do add the below details to the template,
🌟 Star it 🍴Fork it 🤝 Contribute to it!
Discord server - https://discord.gg/tTJQxvSaDP
Happy Coding,

I have created a pull request. Kindly review it

I have created a pull request. Kindly review it

@rexdivakar Can you please add DWOC label here also

@rexdivakar Can you please add DWOC label here also


Fixed comman url issue [issue #264]

What is the change?
Replaced all Post title parameters with Post Id in endpoints and controller, as post title can be common that is creating ambiguity and causing this issue.
Related issue?
issue: #264
How was it tested?
All the controllers after changes tested on the local system performing related operations.
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

[x] Have you followed the Contribution Guidelines while contributing.
[x] Have you checked there aren't other open Pull Requests for the same update/change?
[x] Have you made corresponding changes to the documentation?
[x] Your submission doesn't break any existing feature.
[x] Have you tested the code before submission?

Screenshots or Video:
none

Hey! Thanks for contributing!
There's a typo in your commit message can you please fix that, meanwhile I'll review you pr.

I reviewed the pr and everything works fine, you have squashed the bug, great work!
So please fix the small typo and then I'll add the ready-to-merge tag.

@RushanKhan1 I've fixed the typo in the commit message.

@Pranav016 I've fixed the common URL issue in the new structured code. please review.

@Pranav016 I've removed the text that came from conflicts.
here is the link to the video of the working website locally - link to drive


build-snapshot: fixed bug with screenshot taking

closing as fix was delivered in a little bit different way using https://github.com/qaprosoft/carina/pull/743


Unable to signIn with OpenIDConnect when already signed Up with email and password

Bug report
Describe the bug
I am unable to link/sign in with OpenID using the same email as an account signed up with email and password.
When looking at supabase logs I see,
duplicate key value violates unique constraint "users_email_key"
To Reproduce

I sign up with email and password and I then click the verification email. I verify that the row looks good in auth.users.
I then create an account using OpenIDConnect. The error I get back is GotrueError(message: Database error saving new user)

let response = await supabase.auth.signUp({
  email<EMAIL_ADDRESS>  password: 'RQTFSUtvkVqRfzemYsPI'
})

let response = await supabase.auth.signIn({
  oidc:{
      id_token: 'valid_id_token',
      nonce: 'valid_nonce',
      provider: 'google'
  }
})

They work separately, but they fail when called after each other.
Expected behavior
I expect that I can sign in with oidc when the email is the same as an account that has already same up with email and password.

Hey, due to issues with the quality of implementation for OIDC we've decided to stop supporting it and removed it from the v2 version of the client library all together.
It's been a while, but if you could attach some logs from the failing operation we may be able to look into this issue further. Until then, I'll close it.

@hf Wait really? What about my and other's production apps that are currently using OIDC? This seems very bizarre so just get rid of. I was working on making a PR to fix the issue with it involving iOS.

Forgive my ignorance, but if OIDC is removed what happens to users who've created their account using Apple/Google auth? How will they sign in to the app if they can't use their email and password? And, how will we do native sign-in?

Exactly. It seems too haste of a decision to remove OIDC.

@DanMossa
#412 is now fixed, but in v2 the possibility to log in with oidc is now missing. How to enable native Apple/Google login? (react native)

I will actually be very upset if the endpoint to support oidc is removed. I and many others have spent a lot of time support OIDC. It's required for native auth and I really hope we get clarification on what's happening.
@hf @kangmingtay

Hey, this was maybe prematurely communicated. We'll discuss with the team tomorrow and give an update. You're right about supporting existing use cases.

Hey everyone, the team and I discussed this at length. Here's our conclusions:

We recognize this is being used in the wild and is a hard requirement on iOS.
The current implementation has some (serious) known issues and we don't want to encourage people to be using something that is of low quality.
Mid-term we do want to add official support for an OIDC login flow (that uses ID tokens), but this is unlikely to be backward compatible with what we have today.

Thus we decided to do the following:

Add back support for this flow in v2 of gotrue-js, but under an @experimental annotation. We're going to be allocating some time to do this in the next 2 to 3 weeks.
Since Sign-in with Apple is a hard requirement in mobile apps on iOS, we'll try to address some of the known issues in that flow only. Since we're busy with some other priorities, we can't promise a timeline on addressing this.
Any PRs from the community on this topic will be considered closely, in an effort to unblock you.
Once we address OIDC ID token login flows properly, the existing flow will be deprecated and the existing API is likely to be removed with some prior notice. Prepare your codebase for such an eventuality in the future.

Feel free to let us know how you feel about this or if we should reconsider something. Thank you for your dedication so far!

that sounds promising. thank you very much for the transparent communication.

So - I’m not familiar with oidc - but I’ve done apple sign in flows a few times. I’ll avoid bloating this ticket with findings - there’s a sample repo I have with nodejs that I’m working on here / it has the official apple sign in sample code bundled together - there’s few tickets that have suggested oidc but it seems obsolete - https://github.com/supabase-community/gotrue-swift/issues/4
My sign in almost sort of works - I’d drop this effort in a heart beat if there was a native sign in flow. But I’m yet to see anything working beyond web flow.
There’s another ticket which is around using jwt of authorised user to access database with RLS. That’s important for me once sign in is working.
https://github.com/supabase-community/supabase-swift/issues/49

I think adding OIDC in v2 is important. Especially for google one tap login

@hf: any news on this? :)

@megacherry Hey not yet since we've been busy preparing stuff for Launch Week 6. https://supabase.com/launch-week
We're going to start planning our next steps in January and this (OIDC support) is high up on our list.

@megacherry Hey not yet since we've been busy preparing stuff for Launch Week 6. https://supabase.com/launch-week
We're going to start planning our next steps in January and this (OIDC support) is high up on our list.

Hi glad to hear that. I want to implement OIDC for my application but don't want to migrate back to supabase v1 to implement OIDC. It is now January, I just want to remind and hope if the team is working on it.

also we need some swift / java code examples (not react-native).

This bug appears to also affect OAuth. (Tested with Google Specifically)
If you signup with Google, and then set a password or use a magic link, everything works as expected, but if you do things the other way around you get the same error (ERROR: duplicate key value violates unique constraint "users_email_partial_key" (SQLSTATE 23505)).
For clarity:
Sign Up with OAuth -> Add Password/Use Magic Link -> User logs in correctly
Sign up with Password/Magic Link -> Try to Sign-In with user -> 500: Database error saving new user

@hf: It is now almost the end of January and I would like to politely ask if you have made any progress in the matter? Is there anything we can do to support you? :)

Hey everyone! Here's the PR: https://github.com/supabase/gotrue-js/pull/603
Sorry this took so incredibly long!


Parser serialization/code generation

Currently, each time a program/text need to be analyzed, the grammar is parsed first to extract the metamodel and the language-parser.
Is there a way of serializing the generated parser so the grammar parsing can be done once and for all?
From prior discussion, @igordejanovic suggested two solutions:

pickle the parse graph,
generate the parse graph code as the parser code is a parser graph object, it could be done (the one prefered by @igordejanovic).

Indeed, the second solution seems to be the best one, and would add a behavior close to the ANTLR one without disturbing the existing
From what I understand, a simple visit of each parser node should be enough to recreate the same graph parser, am I missing something?
In such a scenario, the metamodel should also be generated, could this be done also very simply or is there some catch for the metamodel generation?
Thanks!

After giving it some more thought I'm not sure anymore that parser serialization is worthwile. IMHO there are three incentives for serializing parser/metamodel (i.e. generating parser code):

Performance
Removing run-time dependency on textX/Arpeggio
Producing parser/metamodel for some other language

I haven't got any trouble with the first one. There is some overhead in constructing parser/meta-model from grammar but it is usually fast enough for humans (e.g. if you are experimenting with the language). And, you can always keep constructed meta-model around (e.g. module level reference) and reuse it multiple times. If keeping meta-model is not an option (can't see why) pickling still can be used: see if there is pickle file next to a grammar, try to load it, if it fails reconstruct meta-model as usual and pickle for further use. Pickling/unpickling should be fast enough and the approach is transparent for the user. Not sure if there are any gotchas with this approach and the current implementation though.
Second incentive seems more interesting but both textX and Arpeggio are light libraries easily installable via pip so there shouldn't be a problem. @aranega Yes, parser could be serialized by walking the parser model graph and emitting Python code for constructing the graph with special care of forward reference resolving. Meta-model could also be serialized as it is more or less a structure with information about meta-classes and their relations. Still, removing run-time dependency wouldn't be easy to achieve and there would be a considerable maintenance overhead afterwards so I question the reasons for going down this route.
Third point would be a lot of work and would mostly replicate ANTLR so I don't see the point.
Current interpretative style of work seems more in the spirit of dynamic languages.
@aranega Maybe there is a different perspective from the standpoint of PyEcore but I don't know much about it to comment. I guess when you make some more progress in integration between tools you could shed some light on the subject.
Thanks for interesting ideas and discussion.

Thanks for the new point of view. Actually, the idea is not to remove run-time dependencies from the generated code, but more to simply "drop" the grammar parsing (finally, a little bit like ANTLR). Regarding what you are exposing, it may not be such a good idea.
The final goal was more in the usage/dev. flow for the integration with PyEcore I'm experimenting. At the same occasion, I though it could be also interesting for textX, but I understand that it would not be very valuable.
To be a little more explicit about what I had in mind, currently, textX has "two" ways of working:

you can use a dynamically generated metamodel from the grammar,
you can use classes defined by the user to replace some/all of the dynamically generated one.

The second point is interesting as it allows the user to define and add behavior inside a custom class. I would like to have the exact same possibilities when using textX with PyEcore. PyEcore, as EMF, have two major 'mode', a dynamic one, where elements are created in memory, and a static one where the metamodel Python code is generated.
For the first point, the dynamic mode works perfectly, and for the second point, the dynamic mode and the static one can be use. When the dynamic mode is used, there is not so much problems.
However, if we want to use the static mode, which is prefered when there is behavior to add to each metaclasses, we need the metamodel Python code to modify it.
The metamodel code can be generated from a .ecore, but it is not a good idea as it forces to maintain the grammar and a metamodel that reflect the grammar. Another solution could be to manually create the static metamodel code. This possibility is out of the picture as the static code is quite painful to write (PyEcore performs run-time type checking, so if there is a relationship between two metaclasses, the relationship must be typed by the target metaclass and the two metaclass must be known during the static metamodel writing, plus some tricks).
Moreover, the parser already creates the metamodel in memory for free. The idea is to generate the code for the metamodel created by the parser.
So, when we want to use a static metamodel, the process is not as direct than with textX: we need first to generate the metamodel, then we need to use the classical textX process were the grammar is parsed using the generated metamodel code as user-classes. This is not a big deal, but as the grammar is, finally, parsed twiced at this point, it seems to me a little bit cumbersome. Generating the parser code at the same occasion was more a "bonus" actually, and a way of "cuting" this "twice-parsing" impression. At the end, this is really not a big issue, but if I could do both operations at the same time, it sounded better to me.
Sorry for the long post, I wanted to be sure to expose the pros and cons, and see if you find this "requirement" (generating first the metamodel code in some case) cumbersome or not.

I think that generating user-classes (meta-model in Python code) would indeed be useful for textX. Probably that operation should be performed using a new textx cli command as it is a form of compilation.
Thus you could update your user classes when you change the grammar. But at run-time only one parse of the grammar is needed in order to reconstruct language parser and additional meta-model information that are not available in plain Python user classes. Those additional information are kept in meta-model object in textX.
Another issue that arise is to keep manual changes in user classes. For this git could be used. Above mentioned textX cli command could switch to some predefined branch when generating code and merged branch with generated code back to the main development branch.
I'll register another issue for this user-classes generator idea while we could continue PyEcore related code generation + textX at PyEcore issue tracker.

Indeed, the "compilation" operation using a cli sounds less painful and more friendly. The PyEcore metamodel code generation should be easy using pyecoregen which provides all we need to do this.
I pushed my experiment on this repository https://github.com/aranega/textX. Please keep in mind that it is still in a early POC stage. Consequently, the 'merging' between textX and PyEcore is still raw and coded in a "quick and dirty" fashion. There is still some work to do, but the main idea is here.

Great! pyecoregen looks awesome. It sounds like a much better and more flexible approach. The initial experiment with PyEcore + textX also looks very promising. Making this support and dependency to be optional using a parameter would be awesome!

Here is a little update about the experiments on textX + PyEcore.
The code is still dirty, but I have interesting results, and all the examples from the textX documentation seems to work (there is probably some catches). The hardest part is clearly the auto-identification of EDataType and EEnum like rules.
From what I currently have, I'm able to automatically create an Ecore metamodel from a grammar, parse a model towards an instance of this metamodel, handle the model/metamodel and serialize them in XMI if needed.
I will develop and give more details - probably today - in an issue in the PyEcore github project as I cannot create issues on a fork.

Amazing work Vincent!
This really opens a sea of possibilities.

I opened an issue here https://github.com/pyecore/pyecore/issues/16 where I will continue to add the results of the POC.


Issue with username/password login?

I haven't been able to successfully log in with username/password, with or without 2FA enabled.

Sorry for the drive by but the description reminded me of an issue I've had with go get. When running against private repos, it will hang with a pending git auth request that is suppressed by default, unless GIT_TERMINAL_PROMPT=1 is set in the environment. Hoping maybe this might help, unless you've already tried it.

Try to make this changes at dorker.py:
<line 36>
else:
#client = github3.GitHub()
client = github3.GitHub(username=gh_user, password=gh_pass, token=gh_token)
   # client.login(
   #     username=gh_user,
   #     password=gh_pass,
   #     token=gh_token,
   #     two_factor_callback=two_factor,
   # )

    # Check if login worked


User Guide: Fix missing ellipsis in command formats with tag

Closes #246
Commands with [t/tag] have missing ellipsis have been updated to include them.

LGTM


[Question] OOM finetune full llava1.5 with bs1, but successfully finetune llava1.5 with lora bs 16 (80ggpu)

Question
When I use the official doc and script(https://github.com/haotian-liu/LLaVA/blob/main/scripts/v1_5/finetune_task.sh), I can successfully finetune 13b llava1.5 with lora(bs 16; deepspeed 3;80g gpu), but failed in finetuning full 13b llava1.5 even bs1(OOM). Besides, I can also successfully finetune full 13b llava1.0 with same gpu and bs16. Is there any problem in official llava 1.5 scripts?

I have a similar issue using finetune_task.sh and still cannot figure out why;


Make it possible to preview graphic templates on localhost

List of templates under the list of graphics, render them in realtime?

Mostly working, though there may still be a few wrinkles with copytext. Leaving open for the moment.


[Draft] Scaffolding for BalancerV2 Integration

All the traits and structs have been adjusted to account for a new BaselineSource (namely BalancerV2). Still need include some details related to PriceEstimation and PoolFetching
Test Plan
Existing CI still runs (as long as BalancerV2 is not chosen as a BaselineSource)

Given that this PR is only an outline for what the Balancer integration could eventually look like, we have decided not to merge this branch, but rather use it as a reference point when tackling #589. That is (cc @fedgiac , @nlordell) you guys are welcome to work off of this branch if it is helpful, but we can independently introduce all the components without disturbing the rest of the project.
Hopefully the contents of the PR can be helpful guidance for a successful integration.


SwaggerDoc missing for net core 1.1.0

SwaggerDoc is not recognized.
http://imgur.com/a/05OYy

I haven't been able to get Swagger working on dot net core 1.1.0
If I try the ConfigureSwaggerGen I get an exception when browsing to the /swagger route.
When I use AddSwaggerGen instead, the exception is gone. But then I get a 404:
            services.AddSwaggerGen(c =>
            {
                c.SwaggerDoc("v1", new Info { Title = "My API", Version = "v1" });

                // add stuff
//                c.IncludeXmlComments("/");
//                c.DescribeAllEnumsAsStrings();
            });

I'm curious how you got service.AddSwaggerGen to work without a parameter. I had to do this to get it through the compiler:
            services.AddSwaggerGen(opt =>
            {

            });

I'll keep digging but it appears that Swashbuckle is not compatible with 1.1, at least not with the instructions in the readme.

What works for me is something like:
    services.AddSwaggerGen(swagger =>
    {
        swagger.SwaggerDoc("v1", new Info { Title = "My API", Version = "v1" });
        swagger.IncludeXmlComments(Path.Combine(PlatformServices.Default.Application.ApplicationBasePath, "MyApi.xml"));
    });

I was using wrong version, correct version is Install-Package Swashbuckle.AspNetCore -Pre. I was using something else.


Fix WHERE pushdown with parametrized SQL as table clickhouse FDW

What kind of change does this PR introduce?
Bug fix
What is the current behavior?
SELECTing with WHERE clause that only contains the parameter from the parametrized SQL table definition was inserting a spurious WHERE without any clause.
What is the new behavior?
Checks for empty conditions and only adds WHERE when appropriate.
Also adds some tests.

Thank you for the PR!


Linking issue when compiling with python

I followed the instruction to build with python but got the below error message during compilation.
[100%] Linking CXX shared module pypointmatcher_native.cpython-38-x86_64-linux-gnu.so
/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/7/../../../x86_64-linux-gnu/libboost_filesystem.a(operations.o): relocation R_X86_64_PC32 against symbol `_ZN5boost10filesystem16filesystem_errorC1ERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEERKNS0_4pathESC_NS_6system10error_codeE' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
python/CMakeFiles/pypointmatcher_native.dir/build.make:1950: recipe for target 'python/pypointmatcher_native.cpython-38-x86_64-linux-gnu.so' failed
make[2]: *** [python/pypointmatcher_native.cpython-38-x86_64-linux-gnu.so] Error 1
CMakeFiles/Makefile2:350: recipe for target 'python/CMakeFiles/pypointmatcher_native.dir/all' failed
make[1]: *** [python/CMakeFiles/pypointmatcher_native.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

I checked whether my libboost_filesystem.a had an issue with linking following this page, but it printed below messages so it seems my static library is not a problem.
...
000000000ecc<PHONE_NUMBER>04 R_X86_64_PLT32<PHONE_NUMBER>000000 _ZNK5boost10filesystem - 4
000000000eeb  00cd00000004 R_X86_64_PLT32<PHONE_NUMBER>000000 _ZdlPv - 4
000000000f70<PHONE_NUMBER>04 R_X86_64_PLT32<PHONE_NUMBER>000000 _ZNK5boost10filesystem - 4
000000000f88<PHONE_NUMBER>04 R_X86_64_PLT32<PHONE_NUMBER>000000 _ZNK5boost10filesystem - 4
000000000fa0<PHONE_NUMBER>04 R_X86_64_PLT32<PHONE_NUMBER>000000 _ZNK5boost10filesystem - 4
000000000fd6<PHONE_NUMBER>04 R_X86_64_PLT32<PHONE_NUMBER>000000 _ZNK5boost10filesystem - 4
000000000fee<PHONE_NUMBER>04 R_X86_64_PLT32<PHONE_NUMBER>000000 _ZNK5boost10filesystem - 4
000000001006<PHONE_NUMBER>04 R_X86_64_PLT32<PHONE_NUMBER>000000 _ZNK5boost10filesystem - 4
00000000107d<PHONE_NUMBER>04 R_X86_64_PLT32<PHONE_NUMBER>000000 _ZN5boost10filesystem4 - 4
000000001102  00cd00000004 R_X86_64_PLT32<PHONE_NUMBER>000000 _ZdlPv - 4
000000001179<PHONE_NUMBER>04 R_X86_64_PLT32<PHONE_NUMBER>000000 _ZN5boost10filesystem4 - 4
0000000011fe  00cd00000004 R_X86_64_PLT32<PHONE_NUMBER>000000 _ZdlPv - 4
000000001273<PHONE_NUMBER>04 R_X86_64_PLT32<PHONE_NUMBER>000000 _ZN5boost10filesystem4 -
...

I made sure that the version of pybind11 is 2.5.0 and designated the python executable of my conda environment (cmake -DPYTHON_EXECUTABLE=$(python3.8 -c "import sys; print(sys.executable)") .. while activating conda env).
This is my variable configurations of cmake. My OS is Ubuntu 18.04.5 LTS.
cmake -DBUILD_PYTHON_MODULE=ON -DPOINTMATCHER_BUILD_EXAMPLES=OFF ..
-- The C compiler identification is GNU 7.5.0
-- The CXX compiler identification is GNU 7.5.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- No build type specified; defaulting to CMAKE_BUILD_TYPE=Release.
-- Performing Test FLAG_WEXTRA
-- Performing Test FLAG_WEXTRA - Success
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Boost version: 1.65.1
-- Found the following Boost libraries:
--   thread
--   filesystem
--   system
--   program_options
--   date_time
--   chrono
--   atomic
-- Boost version: 1.65.1
-- Found the following Boost libraries:
--   thread
--   filesystem
--   system
--   program_options
--   date_time
--   chrono
--   atomic
-- libnabo found, version 1.0.7 (include= libs=)
-- using built-in yaml-cpp, version 0.3.0
   -- text-based configuration enabled
-- Looking for _POSIX_TIMERS
-- Looking for _POSIX_TIMERS - found
-- API Documentation (doxygen): disabled
-- The Python module will be install at this location : /home/jykim/libpointmatcher/python/pypointmatcher
-- Found PythonInterp: /home/jykim/anaconda3/envs/jykim/bin/python3.8 (found version "3.8.12")
-- Found PythonLibs: /home/jykim/anaconda3/envs/jykim/lib/libpython3.8.so
-- pybind11 v2.5.0
-- Performing Test HAS_FLTO
-- Performing Test HAS_FLTO - Success
-- LTO enabled
-- Configuring done
-- Generating done
-- Build files have been written to: /home/jykim/libpointmatcher/build

Hi @qpwodlsqp , sorry for not getting to this earlier.
The linking error you're referring to is caused, as correctly spotted in https://github.com/CGAL/cgal-testsuite-dockerfiles/pull/138 , by the static linking of Boost library here. I currently don't see any advantage in linking Boost statically, but will leave this open to see if @KernelA has some comments on it. If not, I'll do a PR with a fix.

Hi, @qpwodlsqp.
Dou you compile boost with  position-independent code generation?
boost is compiling with -fPIC flag in the GitHub Actions.
https://github.com/norlab-ulaval/libpointmatcher/blob/e146a503c4f39160ce103bd4fba4f2ed404ef123/.github/workflows/build-python.yaml#L188

@RedLeader962 Is the Python workflow currently used in the CI/CD system?
@KernelA Typically, you'd install boost on Linux / MacOS through your package manager, e.g., sudo apt-get install libboost1.37-dev. What's your motivation for building the library from source?

@boxanm, because without  -fPIC full compilation process does not work. GitHub Actions compiles wheel package which we can install except some problems with manylinux:
https://peps.python.org/pep-0600/

@boxanm No the python binding compilation and testing logic are not implemented yet on the libpointmatcher-build-system running on the norlab-teamcity-server. We have decided to postpone the python binding integration to latter this year. However they are build via github action on merge to the master branch.

@KernelA while I understand the need to install Boost statically to ship wheel packages and eventually publish libpointmatcher on PyPi or elsewhere, I believe that it only needs to be done as part of Github actions. Most libpointmatcher users already have Boost (and Eigen) installed and shared between multiple projects. We should not complicate libpointmatcher's installation by requiring Boost to be built from source.
So I suggest setting the Boost_USE_STATIC_LIBS to OFF by default and only triggering it in the Github actions pipeline.
I'm a big fan of publishing the library on PyPi, however, the current Python bindings installation is unnecessarily complicated in my opinion. As compared to simply setting a cmake flag, you need the extra step to call pip build. Again, ok for the build system, but user installations should have the least requirements possible.

Hi, @boxanm. The necessary changes in the pull request #530

Hi, @qpwodlsqp. We merged into develop branch necessary changes.   Boost linking is dynamic, by default.


mdx plugin: add example for MdxForm

The goal of this PR is to add a small example of MdxForm in the demo-gatsby.
It's a WIP. Feel free to contribute!

Argh. I'm getting a build error in the demo site:
ERROR in ./src/components/test-mdx-form.js
Module not found: Error: Can't resolve '@tinacms/gatsby-tinacms-mdx' in '/Users/joe/Dev
/oss/tinacms/packages/demo-gatsby/src/components'

👍 You'll need to add gastby-tinacms-mdx to the package.json of demo-gatsby and bootstrap again.


getMousePos returns x: 0, y: 0 no matter what on Mac OS X Catalina

 "robotjs": {
      "version": "0.6.0",
      "resolved": "https://registry.npmjs.org/robotjs/-/robotjs-0.6.0.tgz",
      "integrity": "sha512-6pRWI3d+CBZqCXT/rsJfabbZoELua+jTeXilG27F8Jvix/J2BYZ0O7Tly2WCmXyqw5xYdCvOwvCeLRHEtXkt4w==",
      "requires": {
        "nan": "^2.14.0",
        "node-abi": "^2.13.0",
        "prebuild-install": "^5.3.3"
      }
    },

const robot = require('robotjs')
console.log(robot.getMousePos())`
> { x: 0, y: 0 }

$ ../node_modules/.bin/jasmine mouse.js
Started
.FF....

Failures:
1) Mouse Move the mouse.
  Message:
    Expected false to be truthy.
  Stack:
    Error: Expected false to be truthy.
        at UserContext.<anonymous> (/Users/brandonros/Desktop/bilge-bot/robotjs/test/mouse.js:20:34)
  Message:
    Expected false to be truthy.
  Stack:
    Error: Expected false to be truthy.
        at UserContext.<anonymous> (/Users/brandonros/Desktop/bilge-bot/robotjs/test/mouse.js:21:34)

2) Mouse Move the mouse smoothly.
  Message:
    Expected 0 to equal 100.
  Stack:
    Error: Expected 0 to equal 100.
        at UserContext.<anonymous> (/Users/brandonros/Desktop/bilge-bot/robotjs/test/mouse.js:42:26)
  Message:
    Expected 0 to equal 100.
  Stack:
    Error: Expected 0 to equal 100.
        at UserContext.<anonymous> (/Users/brandonros/Desktop/bilge-bot/robotjs/test/mouse.js:43:26)

7 specs, 2 failures
Finished in 2.199 seconds

The new robotjs version has been published but there is a bug into the NodeJS core about the screen sizing, it should be packaged soon into a new NodeJS version https://github.com/libuv/libuv/issues/2566

+1

yep, this seems to work properly on Node 14.1.0 (and probably earlier as well, but that's the one I just tried)

Thank you for letting us know @fabiomcosta, I can now close it

$ npm install

><EMAIL_ADDRESS>install /Users/bros/vpn/node_modules/robotjs
> prebuild-install || node-gyp rebuild

prebuild-install WARN install No prebuilt binaries found (target=12.18.2 runtime=node arch=x64 platform=darwin)
  CXX(target) Release/obj.target/robotjs/src/robotjs.o
../src/robotjs.cc:63:39: error: too few arguments to function call, single
      argument 'context' was not specified
        const size_t x = info[0]->Int32Value();
                         ~~~~~~~~~~~~~~~~~~~ ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8.h:2709:3: note:
      'Int32Value' declared here
  V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const;
  ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8config.h:368:31: note:
      expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
../src/robotjs.cc:64:39: error: too few arguments to function call, single
      argument 'context' was not specified
        const size_t y = info[1]->Int32Value();
                         ~~~~~~~~~~~~~~~~~~~ ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8.h:2709:3: note:
      'Int32Value' declared here
  V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const;
  ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8config.h:368:31: note:
      expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
../src/robotjs.cc:97:33: error: too few arguments to function call, single
      argument 'context' was not specified
        size_t x = info[0]->Int32Value();
                   ~~~~~~~~~~~~~~~~~~~ ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8.h:2709:3: note:
      'Int32Value' declared here
  V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const;
  ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8config.h:368:31: note:
      expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
../src/robotjs.cc:98:33: error: too few arguments to function call, single
      argument 'context' was not specified
        size_t y = info[1]->Int32Value();
                   ~~~~~~~~~~~~~~~~~~~ ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8.h:2709:3: note:
      'Int32Value' declared here
  V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const;
  ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8config.h:368:31: note:
      expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
../src/robotjs.cc:114:33: error: too few arguments to function call, single
      argument 'context' was not specified
        size_t x = info[0]->Int32Value();
                   ~~~~~~~~~~~~~~~~~~~ ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8.h:2709:3: note:
      'Int32Value' declared here
  V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const;
  ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8config.h:368:31: note:
      expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
../src/robotjs.cc:115:33: error: too few arguments to function call, single
      argument 'context' was not specified
        size_t y = info[1]->Int32Value();
                   ~~~~~~~~~~~~~~~~~~~ ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8.h:2709:3: note:
      'Int32Value' declared here
  V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const;
  ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8config.h:368:31: note:
      expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
../src/robotjs.cc:143:39: error: no matching member function for call to
      'ToString'
                v8::String::Utf8Value bstr(info[0]->ToString());
                                           ~~~~~~~~~^~~~~~~~
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8.h:2668:44: note:
      candidate function not viable: requires single argument 'context', but no
      arguments were provided
  V8_WARN_UNUSED_RESULT MaybeLocal<String> ToString(
                                           ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8.h:2684:31: note:
      candidate function not viable: requires single argument 'isolate', but no
      arguments were provided
                Local<String> ToString(Isolate* isolate) const);
                              ^
../src/robotjs.cc:159:22: error: no matching member function for call to
      'BooleanValue'
                doubleC = info[1]->BooleanValue();
                          ~~~~~~~~~^~~~~~~~~~~~
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8.h:2699:8: note:
      candidate function not viable: requires single argument 'isolate', but no
      arguments were provided
  bool BooleanValue(Isolate* isolate) const;
       ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8.h:2702:51: note:
      candidate function not viable: requires single argument 'context', but no
      arguments were provided
                V8_WARN_UNUSED_RESULT Maybe<bool> BooleanValue(
                                                  ^
../src/robotjs.cc:239:35: error: too few arguments to function call, single
      argument 'context' was not specified
        mouseDelay = info[0]->Int32Value();
                     ~~~~~~~~~~~~~~~~~~~ ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8.h:2709:3: note:
      'Int32Value' declared here
  V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const;
  ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8config.h:368:31: note:
      expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
../src/robotjs.cc:251:30: error: too few arguments to function call, single
      argument 'context' was not specified
        int x = info[0]->Int32Value();
                ~~~~~~~~~~~~~~~~~~~ ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8.h:2709:3: note:
      'Int32Value' declared here
  V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const;
  ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8config.h:368:31: note:
      expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
../src/robotjs.cc:252:30: error: too few arguments to function call, single
      argument 'context' was not specified
        int y = info[1]->Int32Value();
                ~~~~~~~~~~~~~~~~~~~ ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8.h:2709:3: note:
      'Int32Value' declared here
  V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const;
  ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8config.h:368:31: note:
      expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
../src/robotjs.cc:418:44: error: expected '(' for function-style cast or type
      construction
int GetFlagsFromString(v8::Handle<v8::Value> value, MMKeyFlags* flags)
                                  ~~~~~~~~~^
../src/robotjs.cc:418:28: error: no member named 'Handle' in namespace 'v8'
int GetFlagsFromString(v8::Handle<v8::Value> value, MMKeyFlags* flags)
                       ~~~~^
../src/robotjs.cc:418:46: error: use of undeclared identifier 'value'; did you
      mean 'False'?
int GetFlagsFromString(v8::Handle<v8::Value> value, MMKeyFlags* flags)
                                             ^~~~~
                                             False
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8.h:307:25: note:
      'False' declared here
  friend Local<Boolean> False(Isolate* isolate);
                        ^
../src/robotjs.cc:418:53: error: unexpected type name 'MMKeyFlags': expected
      expression
int GetFlagsFromString(v8::Handle<v8::Value> value, MMKeyFlags* flags)
                                                    ^
../src/robotjs.cc:418:65: error: use of undeclared identifier 'flags'
int GetFlagsFromString(v8::Handle<v8::Value> value, MMKeyFlags* flags)
                                                                ^
../src/robotjs.cc:418:71: error: expected ';' after top level declarator
int GetFlagsFromString(v8::Handle<v8::Value> value, MMKeyFlags* flags)
                                                                      ^
                                                                      ;
../src/robotjs.cc:762:1: error: unknown type name 'BMP'
BMP buildBMP(Local<Object> info)
^
../src/robotjs.cc:766:2: error: unknown type name 'BMP'
        BMP img;
        ^
../src/robotjs.cc:768:19: warning: 'Get' is deprecated: Use maybe version
      [-Wdeprecated-declarations]
        img.width = obj->Get(Nan::New("width").ToLocalChecked())->Uint32Value();
                         ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8.h:3553:3: note:
      'Get' has been explicitly marked deprecated here
  V8_DEPRECATED("Use maybe version", Local<Value> Get(Local<Value> key));
  ^
/Users/bros/Library/Caches/node-gyp/12.18.2/include/node/v8config.h:328:29: note:
      expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated(message)))
                            ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
1 warning and 20 errors generated.

Whole slew of errors trying to pull in the latest libuv changes in node.js v12.18.2


[BACKLOG-15720] Fixes the Home and Public label in the search box are appearing lower case.

@ddiroma Please Sir!


[Android] App crashes on card scanning PaymentSheet

Describe the bug
We recently added stripe-identity-react-native SDK in our Android app and we discovered that card scanning PaymentSheet does not work anymore : app crashes.
To Reproduce
Steps to reproduce the behavior:

add implementation 'com.stripe:stripecardscan:20.3.+' in android/app/build.gradle file
add @stripe/stripe-identity-react-native SDK
invoke PaymentSheet
click on "scan card"

Expected behavior
App should not crash
Smartphone (please complete the following information):

Device: All
OS: All
Version : last version for the 2 SDK

@ccen-stripe @charliecruzan-stripe

hi @nicolasdevienne , could you try include stripecardscan as follows?
implementation('com.stripe:stripecardscan:$stripeVersion') {
  exclude group: 'com.stripe', module: 'ml-core-cardscan' // exclude the cardscan-specific portable tflite runtime
}

Both Identity and cardscan use ml-core-xxx. Identity already includes ml-core-default, which is a superset of ml-core-cardscan. So we need to exclude it to avoid the duplicate class issue.

hi @nicolasdevienne , could you try include stripecardscan as follows?
implementation('com.stripe:stripecardscan:$stripeVersion') {
  exclude group: 'com.stripe', module: 'ml-core-cardscan' // exclude the cardscan-specific portable tflite runtime
}

Both Identity and cardscan use ml-core-xxx. Identity already includes ml-core-default, which is a superset of ml-core-cardscan. So we need to exclude the later to avoid the duplicate class issue.

Hi @ccen-stripe! I changed $stripeVersion by 20.35.+ and it works! Thank you!


Conflict between the use createStateContext and createReducerContext hooks and exhaustive-deps lint rule

What is the current behavior?
The functions, setState and dispatch, associated with createStateContext and createReducerContext hooks, respectively, are flagged by the exhaustive-deps lint rule when they are used in hooks such as useEffect and not being included in the dependency arrays.
Steps to reproduce it and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have extra dependencies other than react-use.
Here is a link to screenshots that showcase the issue. I took the demo code of the createStateContext hook taken from the official docs and added a simple useEffect to demonstrate the issue.
Screenshots
What is the expected behavior?
According to the official React docs (reference), the setState and dispatch functions returned from useState and useReducer hooks have stable identity and thus are safe to exclude them from the dependency array. In fact, the exhaustive-deps lint rule does not flag setState and dispatch functions associated with useState and useReducer hooks when they are omitted from the dependency array.
The setState and dispatch functions resulted from createStateContext and createReducerContext should be compatible with the exhaustive-deps lint rule in the same way.
A little about versions:

OS: MacOS 10.15.5
Browser (vendor and version):
React: v16.13.1
react-use: v15.3.2
Did this worked in the previous package version?

The setState and dispatch functions resulted from createStateContext and createReducerContext should be compatible with the exhaustive-deps lint rule in the same way.

Is that possible to do?

After a second thought, I think it's right how the lint rule applies as it is. Although the original useState and dispatch functions are designed to have stable identities, the useState and dispatch functions associated with createStateContext and createReducerContext are in fact context objects, which are mutable and thus cannot be viewed as stable.


KAFKA-14132: Replace Easymock & Powermock with Mockito in KafkaBasedLogTest

Replaced Easymock & Powermock with Mockito in KafkaBasedLogTest.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@C0urante @mjsax @cadonna could you please review this?

Hi @divijvaidya
Thanks for letting me know about ticket KAFKA-14132. It turns out that @mdedetrich has already begun working on this issue and has submitted a PR, but he said he doesn't have enough time to complete it and agreed to close it. Thus, I think we can handle this issue in this PR. When you have time could you please review this PR?

I don't why checks result in This commit cannot be built. It looks like the built failure is not related to this PR or to the connect module, I would appreciate it if anybody could help me resolve it or explain me why it occurs.

When you have time could you please review this PR?

I am sorry, I won't have time to review this any time soon. Will circle back in a couple of weeks perhaps. I am tagging a few folks who might be interested in reviewing this: @clolov @yashmayya @shekhar-rajak

I don't know why checks result in This commit cannot be built. It looks like the built failure is not related to this PR or to the connect module, I would appreciate it if anybody could help me resolve it or explain me why it occurs.

I checked the build and the failures are from unrelated tests that are known to be flaky so you can just ignore them.

Hi @yashmayya,  thank you for your review! I've addressed the questions raised by you. Can you have one more look?

Thank you for reviewing @yashmayya. The CI is still flaky with large number of failures and I am restarting it.

It looks like test failures are not related to this PR.
Build / JDK 17 and Scala 2.13 / testBalancePartitionLeaders() – org.apache.kafka.controller.QuorumControllerTest
Build / JDK 11 and Scala 2.13 / testSecondaryRefreshAfterElapsedDelay() – org.apache.kafka.common.security.oauthbearer.internals.secured.RefreshingHttpsJwksTest
Build / JDK 11 and Scala 2.13 / testBalancePartitionLeaders() – org.apache.kafka.controller.QuorumControllerTest
Build / JDK 8 and Scala 2.12 / testSyncTopicConfigs() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationBaseTest
Build / JDK 8 and Scala 2.12 / testCreatePartitionsUseProvidedForwardingAdmin() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest
Build / JDK 8 and Scala 2.12 / testRackAwareRangeAssignor() – integration.kafka.server.FetchFromFollowerIntegrationTest
Build / JDK 8 and Scala 2.12 / testBalancePartitionLeaders() – org.apache.kafka.controller.QuorumControllerTest
Build / JDK 8 and Scala 2.12 / testHighAvailabilityTaskAssignorLargeNumConsumers – org.apache.kafka.streams.processor.internals.StreamsAssignmentScaleTest
Build / JDK 11 and Scala 2.13 / testOffsetTranslationBehindReplicationFlow() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest
Build / JDK 8 and Scala 2.12 / testOffsetTranslationBehindReplicationFlow() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest
Build / JDK 8 and Scala 2.12 / testOffsetTranslationBehindReplicationFlow() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest


wanna xfer this repo over to me or "Ether"?

Seems to be a more suitable home now as I'm maintaining it and have completely rewritten it? :)

Bump @redhog

Bump @redhog

Sure

Done :)

Awesome ta, can you make sure I'm able to push to the npm package too please? :)

@redhog, just checking if the NPM push permissions are available for JohnMcLear.  (No rush, just a gentle reminder!)

jose@server:~/ep_cursortrace$ npm publish
npm notice
npm notice 📦<EMAIL_ADDRESS>npm notice === Tarball Contents ===
npm notice 51B    static/css/ace_inner.css
npm notice 1.0kB  static/css/cursortrace.css
npm notice 330B   static/js/css.js
npm notice 2.4kB  handleMessage.js
npm notice 12.5kB static/js/main.js
npm notice 589B   ep.json
npm notice 425B   package.json
npm notice 998B   README.md
npm notice 265B   .travis.yml
npm notice === Tarball Details ===
npm notice name:          ep_cursortrace
npm notice version:       2.0.15
npm notice package size:  7.1 kB
npm notice unpacked size: 18.5 kB
npm notice shasum:        19cf98998243331e32627878d566837c98d11ed5
npm notice integrity:     sha512-jA6aORk0KkuOt[...]B9N/hlrT/1TIA==
npm notice total files:   9
npm notice
npm ERR! code E403
npm ERR! 403 403 Forbidden - PUT https://registry.npmjs.org/ep_cursortrace - You cannot publish over the previously published versions: 2.0.15.
npm ERR! 403 In most cases, you or one of your dependencies are requesting
npm ERR! 403 a package version that is forbidden by your security policy.

npm ERR!


Improve performance of workspace/symbol for large queries + projects

Avoid short queries (< 3 characters) since they are slow and noisy. Xcode does the same thing.

Limit the number of results returned:

Improves performance for queries which match many symbols
Currently take the first N results to improve performance for large projects but once we support cancellation we should take the top N results.

@swift-ci please test

@swift-ci please test

@swift-ci please test


Feature: Implement a 24 Band Equaliser instead of 10.

I think it would be a good idea to have more bands to play with in EqMac in order to more precisely control the sound output, for e.q 20hz 25hz 30hz 35hz 45hz etc. Like the older EqMac2 that no longer works.

Duplicate of #252
Don't create duplicate issue or you might get blocked from posting new ones


router should be able to use both views links or controller methods

Do you mean function closure that is able to return a view or a direct link?

i mean something like this :
protected $routes = [         'index'       => 'views/index',                                   // this line will return the index directly         'error'  => 'ErrorsController@displayError',    // this line will execute a method within a controller     ];

I see
I think a better approach would be a helper method to retrieve a view directly similar to the one introduced in Laravel 5.5 here

yeah it's already exist
public static function getView(string $view, array $data = null) on router.php line 47
example :
return Router::getView('index', ['name' => 'you', 'age' => '99']);
the problem is in routes used by user how to know if a route is a link to a view or a method in controller ?
there is some solution but i'm not satisfied with them  as they seems some how messy or will cause some bugs on exceptional conditions.

It looks pretty good
I'll think of a solution