Unable to run Remix on monorepo

What version of Remix are you using?
1.7.0
Steps to Reproduce
Create monorepo with turbo
npx create-turbo@latest
Create Remix app inside apps folder
cd apps
npx create-remix

Expected Behavior
Work inside monorepo.
Actual Behavior
When running npm install (doesn't matter if i do it in the root of the monorepo or in the remix app) and npm run dev gives the following errors.
[1] Watching Remix app in development mode...
[0] Done in 170ms.
[1] The path "framer-motion" is imported in app/components/graph.tsx but "framer-motion" was not found in your node_modules. Did you forget to install it?
[1] 💿 Built in 498ms
[1] Remix App Server started at http://localhost:3000 (http://<IP_ADDRESS>:3000)
[1] Error: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
[1] 1. You might have mismatching versions of React and the renderer (such as React DOM)
[1] 2. You might be breaking the Rules of Hooks
[1] 3. You might have more than one copy of React in the same app
[1] See https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.

I've copied the folder outside of the monorepo and it works, so it's a problem related to the monorepos.

Duplicate of #4106


Zotero git auto push does not work on Windows

The issue discussed in #972 still exits on Windows. Zotero does not automatically push the exported bib file changes and I have to manually stage and make commit.
I have the following configured in .git/config:
[zotero "betterbibtex"]
	push = true

may be fixed by #2882.


Batch Processing : How to withhold output until input terminates

Hello, thank you very much for designing and open sourcing this system. I've been reading y'alls papers on Trill, FASTER and Quill for years now.
I have a few questions about how to use it.
Trill for batch processing
I realize that Trill is primarily a streaming data engine. But I work with a lot of batched data also that i would like to perform queries against using Trill.
Maybe i don't have the egress side of things setup correctly but my setup looks like this
public static async Task EventsPerHour(string rootFolder)
{
    await
        LogExtractor
        .Create()
        .ExtractSingleSiteDirectory(rootFolder)
        .AsObservable()
        .ToTemporalStreamable(
            e => e.Entry.Timestamp.Ticks,
            DisorderPolicy.Drop(TimeSpan.TicksPerHour),
            FlushPolicy.None,
            PeriodicPunctuationPolicy.None())
        .GroupApply(
            e => e.Entry.Timestamp.Hour,
            g => g.Count(),
            (g, v) => new { Hour = g.Key, Count = v })
        .ToStreamEventObservable()
        .ForEachAsync(i => {
            Console.WriteLine(i.Payload);
        });
}

So what i would like to get out of this somehow is a single list of (Hour, Count) pairs.
What i actually get is a lot of incremental updates as the data flows in. To compensate i made a handler method that tracks all the updates per group and only keeps the last one. It produces correct output, but it seems wasteful to have the engine continue to produce output that i'm discarding.
Can i tell Trill to withhold output until the input stream terminates? If so how?
Weakened Discoverability
Also, why are so many things marked [EditorBrowsable(EditorBrowsableState.Never)]? For example, I see people using the 3 argument version of group apply in examples, but for whatever reason you have GroupSelectorInput<T>.Key marked as never browseable, making the result selector function seem useless initially.
Is there a reason this property (and others like it) is hidden?
GroupApply vs Partition+Aggregate+SelectByKey
Are these two constructions equivalent? If so which should i prefer?
 .GroupApply(
    e => e.Entry.Timestamp.Hour,
    g => g.Count(),
    (g, v) => new { Hour = g.Key, Count = v })
//yield type `IStreamable<Empty,'a>

vs.
.Partition(e => e.Entry.Timestamp.Hour)
.Aggregate(g => g.Count())
.SelectByKey((time, key, count) => new { Hour = key, Count = count })
//yields type IStreamable<PartitionKey<int>, 'a>

My sincere apologies for how long it has taken to comment on this - for some reason, I didn't get a notification that your issue posted. I'm looking at this right now and will give you some guidance within a couple of hours.

Re: Discoverability
Most of the things marked as not being discoverable are fields, methods, or types that we would rather not be public but have to be in order for code generation to function properly. However, the specific example you give is clearly an oversight - one should be able to access the key directly. I will fix that in the next release.

Hey, it isn't your fault about the delay. I tripped some kind of spam filter when i made this issue and Github  suspended my account so it was hidden from you. It took them a couple of days to fix it.
Also, there isn't a massive rush on me needing answers. I've been having a lot of fun reading all the papers and working with Trill.

Ah, the wonderment that is spam filters. I'm glad you're having fun with Trill - it's a blast to work on, too.
Re: Partition
The partition method does something kind of special and magical. I'll try to explain as best I can.
There is a concept within Trill called "partitioned streams". This feature is one way to get around the restriction within Trill that all data must be in order post-ingress. What it allows is for data to follow an independent timeline per partition. For instance, if you have data coming from a collection of sensors, and you want to do a query per sensor (normally done using GroupApply) but each sensor's data may arrive at the processing node with different network lag, partitioned streams allows each sensor to have its data treated as its own timeline. Global disorder policies (e.g., Drop) are then applied on a per-sensor basis rather than globally.
The way that you "enable" this feature is by ingressing PartitionedStreamEvents instead of StreamEvents. Alternatively, one can enable this feature by using ToPartitionedStreamable instead of ToTemporalStreamable. In both of these cases, the result is that you end up with a stream of type IStreamable<PartitionKey, P>. The marker "PartitionKey" in the key type of the streamable means you're in partitioned world, the world's strangest theme park.
Now, the method Partition allows the user to introduce partitions in the middle of a query rather than at ingress. This method allows the user to then do temporal operations on the data without worrying about keeping all data in order. For instance, a concrete feature request that we got was to be able to do different windowing on data based on a key. The Partition method allows the user to split the timeline, thus allowing each individual partition to be windowed independently without any fear of misordering. You could then have one partition do a tumbling window on an hour, another partition have a hopping window of 10 minutes with a hop of a minute, and so forth.
A good example of the Partition method in action is the Rules Engine example in our samples repo.

That is a nice bit of flexibility to have!

Re: your initial example
Have you tried using TumblingWindowLifetime(TimeSpan.TicksPerHour) instead of your GroupApply? That should give you one result per hour, only returned when the full hour of data has passed.

Hmm, looking at my notes, later versions of my queries did switch to tumbling windows. They seem to work great with one exception:
If there is no data for a time period, the data returned data will skip over the empty windows.
As an example, I have a bunch of logs I'm ingressing and filtering for particular events. I'm trying to get per-hour counts of event occurrence. My query looks like this
await
    LogExtractor
        .Create()
        .ExtractSingleSiteDirectory(siteLogFolder)
        .AsObservable()
        .Where(e => e.Entry.Method == "ScaryEvent")
        .ToTemporalStreamable(
            e => e.Entry.Timestamp.Ticks,
            DisorderPolicy.Drop(TimeSpan.TicksPerMinute),
            flushPolicy: FlushPolicy.FlushOnPunctuation,
            periodicPunctuationPolicy: PeriodicPunctuationPolicy.None()
            )
        .Select(e => Empty.Default) //hopefully saving memory since i only need counts???
        .TumblingWindowLifetime(TimeSpan.TicksPerHour)
        .Count()
        .ToStreamEventObservable()
        .ForEachAsync(evt => {
            var start = ToDateTime(evt.StartTime).Value;
            if (evt.IsData)
            {
                var end = ToDateTime(evt.EndTime);
                Console.WriteLine($"{start} {end}  - {evt.Payload}");
            }
        });

This works, but produces output like this
5/22/2019 4:00:00 AM 5/22/2019 5:00:00 AM  - 2970
5/22/2019 5:00:00 AM 5/22/2019 6:00:00 AM  - 2750
5/22/2019 6:00:00 AM 5/22/2019 7:00:00 AM  - 35
5/22/2019 7:00:00 AM 5/22/2019 8:00:00 AM  - 1595
5/23/2019 4:00:00 PM 5/23/2019 5:00:00 PM  - 240
5/23/2019 5:00:00 PM 5/23/2019 6:00:00 PM  - 855
5/23/2019 6:00:00 PM 5/23/2019 7:00:00 PM  - 4610

Note that there is a time skip in between 8AM -> 5PM where there were no events.
I can manually fill in these empties with a little stateful selector on the egress, but is there a built in way to get the empty windows too?

Oh and lastly has the research from this paper made it into the wild yet? I'm super interested in the multiple egress latency selection stuff.

I'm sorry to say the multiple latency work hasn't made it into the main branch nor is on the GitHub site (still only on our deprecated internal repo). I'll reach out to Yinan and see if he's willing to at least port his research prototype to GitHub in a branch.

I believe that there is a way to fill in the missing gaps with nulls - let me try to reach into the deep well of my brain's recycle bin and see if I can page that back.

For posterity,
If you set you periodic punctuations to the same interval as your window, Trill will emit punctuation event for the missing intervals.
var query =
    inputObservable
    .ToTemporalStreamable(
        startEdgeExtractor: item => item.Timestamp.Ticks,
        periodicPunctuationPolicy: PeriodicPunctuationPolicy.Time(TimeSpan.TicksPerMinute)
        )
    .TumblingWindowLifetime(TimeSpan.TicksPerHour)
    ...


Show Logic App Run details not working in Logic Apps

Describe the Bug with repro steps

Go to a run of a logic app that calls another logic app.
select the logic app that was ran inside the main logic app (child logic app)
A pane with options expands on the right. The first button is "Show Logic App run details"
Click the button - it should take you to that specific run. The button does nothing.
Tested in both Google Chrome and Microsoft Edge and the same result in both, button does nothing and no error logged in console.

What type of Logic App Is this happening in?
Consumption (Portal)
Which operating system are you using?
Windows
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos
No response
Browser
Chrome and Edge
Additional context
No response

This is fixed with the following PR: https://github.com/Azure/LogicAppsUX/pull/5956
It's currently in our upcoming release, and is also being hotfixed.


WAL-135 ✨ implements method for checking uid existence

@hlminh2000 could you please add scenario that reproduces the issue, so we could verify the fix? Thanks

:tada: This PR is included in version 1.0.0-semantic-release.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


typescript: index enums [phab:D1906]

Created by evmar at 2017-08-26 01:09:49:
An enum declares a type and constant.
Each enum member declares a constant.

evmar wrote at 2017-08-26 01:11:55:
simpler

fromberger accepted this revision at 2017-08-26 01:28:48

fromberger closed via commit 4082b81a9dbcd56965ce5368448cb2cb3830e647 at 2017-08-26 01:29:28


Mac M1 cannot bring up SAK-cluster

Describe the bug
During terraform init I receive error
Error: Incompatible provider version │ │ Provider registry.terraform.io/hashicorp/template v2.2.0 does not have a package available for your current platform, darwin_arm64. │ │ Provider releases are separate from Terraform CLI releases, so not all providers are available for all platforms. Other versions of this provider may have different platforms supported.
Use version
SAK from master branch
To Reproduce
Use Arm-based workstation  and try to bring up example-folder.
Possible solution:
https://discuss.hashicorp.com/t/template-v2-2-0-does-not-have-a-package-available-mac-m1/35099

fixed with https://github.com/provectus/sak-vpc/pull/4

Examples in swiss-army-kube repo still have "template" provider.


Remove DynActionMarker derive

Remove the DynActionMarker derive, which was introduced in #306 but has been non-functional since #447.

Turn this into a draft until a more comprehensive cleanup is completed.

I'm going to cut a release here: we're about to have breaking changes and it's nice to ship it.


updated incorrect versions

Change(s):

Updated incorrect versions for the following parsers: vimAuditEventEmpty , ASimNetworkSessionCheckPointFirewall, ASimNetworkSessionMicrosoftSysmon , vimNetworkSessionCheckPointFirewall .

Reason for Change(s):

The version of ASimNetworkSessionMicrosoftSysmon should have been updated as the parser was updated.
The versions of the other Three parsers were incorrect.

@v-atulyadav : @TomerAligaev  is a Microsoft intern and therefore does not have to sign the CLA.


Move forward in a nested list fails

Assume you have a nestable class like this one :
public class Nestable
    {
        public string Label { get; set; }

        public List<Nestable> Children { get; set; }

        public Nestable()
        {
            this.Children = new List<Nestable>();
        }
    }

Your have this object :
{
    Label: "object 1"
    Children: [
        { Label: "object 1.1", Children: [] },
        { Label: "object 1.2", Children: [] }
    ]
}

And you want to move 1.1 into 1.2. The operation should be :
[{
    op: "move",
    from: "/Children/0",
    path: "/Children/1/Children/-"
}]

And you expect to obtain :
{
    Label: "object 1"
    Children: [
        { Label: "object 1.2", Children: [
            { Label: "object 1.1", Children: [] }
        ] }
    ]
}

Correct ?
But it fails with :
The index value provided by path segment '1' is out of bounds of the array size.
It's because move gets value, removes source and add at destination. but in this special case, destination has moved...

It seems my interpretation was wrong.
RFC says :

This operation is functionally identical to a "remove" operation on
the "from" location, followed immediately by an "add" operation at
the target location with the value that was just removed.

The correct patch should be
[{
    op: "move",
    from: "/Children/0",
    path: "/Children/0/Children/-"
}]


Usage of GridFunctionCoefficient

Hi,
I have a question on how to use a GridFunctionCoefficient in DG spaces. The problem I encounter is everything is working very well for single process jobs, but if I try to run on multiple cores I get an error. I tried with ex14p with the modification below to provide minimal working example
   // 8. Define the solution vector x as a parallel finite element grid function
   //    corresponding to fespace. Initialize x with initial guess of zero.
   ParGridFunction x(fespace);
   ParGridFunction onex(fespace);
   x = 0.0;
   onex = 1.0;
   GridFunctionCoefficient onegf(&onex);

   // 9. Set up the bilinear form a(.,.) on the finite element space
   //    corresponding to the Laplacian operator -Delta, by adding the Diffusion
   //    domain integrator and the interior and boundary DG face integrators.
   //    Note that boundary conditions are imposed weakly in the form, so there
   //    is no need for dof elimination. After serial and parallel assembly we
   //    extract the corresponding parallel matrix A.
   ParBilinearForm *a = new ParBilinearForm(fespace);
   a->AddDomainIntegrator(new DiffusionIntegrator(onegf));
   a->AddInteriorFaceIntegrator(new DGDiffusionIntegrator(onegf, sigma, kappa));
   a->AddBdrFaceIntegrator(new DGDiffusionIntegrator(onegf, sigma, kappa));

To run: mpirun -np 2 ex14p -m ../data/inline-quad.mesh -o 0
The error file: ex14p.txt
I am not sure if I am using GridFunctionCoefficient incorrectly, I would really appreciate if you could look into it. Also the MPI error is produced as a result of AddInteriorFaceIntegrator, if I pass a ConstantCoefficient for interior faces while keeping it as a GridFunctionCoefficient for rest, everything works. However, it is not suitable for my application where I have a Picard iteration and I have to use the solution from previous step to create the new bilinear forms.
Best wishes,
Abdullah Ali Sivas

I think the solution for this is to call onex.ExchangeFaceNbrData()- this will allow elements on the processor boundary to evaluate the GridFunctionCoefficient on adjacent elements owned by another processor.

Thanks Veselin. This solved the MPI error. However, I still am not getting the correct result for my problem. I am working on a mwe now, can I keep this issue open until I get it?

Sure, we can keep the issue open for now.

Hi again,
I cannot reproduce the error I am getting with pure MFEM 3.4. It must be due to one of the integrators we created for HDG. We can close this issue now. Thanks a lot for your help.


Use HTTPS for download links

On http://influxdb.com/download/ change all http://s3.amazonaws.com/... links to https.
https for influxdb.com would be pretty neat too.

That's for reasons, please don't trivialize.
Also, a signed package repository would be awesome and is very easy to manage with http://www.aptly.info/ (golang, of course).


Error "Not enough balance on account" when sending USDT Token to Cake

I got enough USDT and DFI on that account

Duplicate of https://github.com/DeFiCh/app/issues/195


Add support for require, dynamic import statements, decouple tree state from parser

See: Issue #7
Features
1. SaplingParser
a) Newly supports a subset of require() syntax

DOES support object destructuring with alias assignment

e.g. const { foo: alias, bar } = require("./module")

DOES support array destructuring

e.g. const [foo, bar] = require("./module")

DOES NOT support namespaces and member expressions

e.g. const foo = require("./module"); ... ; <foo.component />;

DOES NOT support invocations or method/member calls

e.g. const foo = require("./module")();
e.g. const foo = require("./module").method(arg);

b) Newly supports a subset of variable declaration imports

DOES support object destructuring with alias assignment, and array destructuring
(no actual use cases, but intermediate step towards fully supporting dynamic imports)

e.g. const { foo: alias, bar } = import("./module")
e.g. const [foo, bar] = import("./module")

DOES NOT support await expressions, .then() chains, or Promise.resolve() calls for dynamic imports

e.g. const foo = await import("./module")
e.g. import("./module").then(mod => mod.loadPage())
e.g. const foo = Promise.resolve(import("./module"))

c) Introduces Babel type guards-based parsing strategy

Partially replaces obsolete Babylon token-based parsing.
Allows for more declarative, extensible code, including the above feature updates.
Enables explicit checks with strong typing for all control flow branches.

d) Converts SaplingParser into a static class

.parse() is the only public (and static) method.

Grouped methods into objects (ParserHelpers, ASTParser, ImportParser, ExportParser).

Converted all SaplingParser methods to pure functions where possible, and provided clear indication of mutations.

.parser() relies entirely on mutating input data in-place, but this was previously unclear due to its non-void return type.

Redundant parser and tree instance usage consolidated in SidebarProvider and parser.test

There is no conceptual benefit to modeling SaplingParser as an object that can have multiple instances, as there is no variation in parsing functionality between instances, and the only state it encapsulates is tree-related.

Enabling the parser to support different configurations or multiple interfaces would be a good use case for converting it to a factory or strategy class in the future.

2. SaplingTree
Encapsulated Tree state and methods to new class.

Strong low-cohesion indicator: No reference to this.tree in any SaplingParser class method that doesn't have Tree in its name.
Supporting multiple Tree object instances is a more useful abstraction.
Migrated .toggleNode(), .updateTree(), .#traverseTree() from SaplingParser to SaplingTree.
Nested nodes are accessible with .get() as follows (useful in parser test file):
e.g. tree.get(0, 1, 2) is equivalent to tree.children[0].children[1].children[2].
Tree class objects are serializable/deserializable for messaging as workspaceState Memento object.

Test Status

Features supported by latest version fully functional.
Added test cases for new features.

Issues

Mocha test suite not functional due to typescript module resolution issue in emitted code.

Manually editing types directory path in extension/out/SaplingParser.js temporarily resolves issue.

Remove SaplingTree from types barrel file.
General bug fixing, refactoring, consistent styling, removing dead code paths and obsolete comments and tests.

Roadmap

Clean up Tree and Node types for interfacing with parser vs. webview, as well as a serialized type for messaging between the two. Each require slightly different set of properties.
Expand import and export statement support.

Add support for barrel files.

Rewrite SaplingParser .getJSXChildren(), .getJSXProps(), .checkForRedux() methods to use Babel type guards.

Add support for Redux hooks.

@MajorLift  Il convert the pr to a draft? since u have mentioned you have some Todos pending.

@MajorLift
I have created a new branch
https://github.com/hb1998/react-component-tree/tree/parser/babel-type-guards
Moving forward you can send PRs to that branch, we can test the branch internally and release, once it's stable.

@hb1998 Done! The PR is fully functional and can be merged as is. The mocha test issue is the only thing that needs fixing. I'll take another look at it with fresh eyes tomorrow just to be sure.

@hb1998 Done! The PR is fully functional and can be merged as is. The mocha test issue is the only thing that needs fixing. I'll take another look at it with fresh eyes tomorrow just to be sure.

@MajorLift  sure will test it meanwhile.
Thanks for the contribution.


[Tree] How to move an existing node to a different level (parent) of the tree (moveAsPrevSiblingOf, moveAsNextSiblingOf...)

Hello friends,
I'm searching for a method to move an existing node to a different level (parent) within a tree. Please don't say now that i have to duplicate existing node (because still not implemented), afterwards to delete existing node and than to persist duplicated one underneath the new parent, because deleting process would cause a lot of dependencies to trigger...
if still not implemented: is there a roadmap or someone already working or willing to work on it (in this case i could try to help with implementing/reviewing)
Thanks

Please don't say now that i have to duplicate existing node (because still not implemented)

Hi, you are using an open source project, which was contributed mainly by one person, during his unpaid free time. Such attitude is insulting.
If moveAsPrevSiblingOf does not work, then you have few options, either contribute a proper patch or develop your own version of tree, or do whatever it takes to support your needs like you have described by performing few actions instead of one. Contribution or your own tree version will not be that easy, probably custom tree for specific use case would be even easier. I've stopped using PHP years ago and this project is now only maintained by contributors without any backward incompatible changes.
I personally would use plain SQL to manage the tree properly and efficiently. But of course you need to understand and learn nested set type of tree, since it gives nice sorting capabilities.

Hello, whats about this? Feedback welcome...
<?php

namespace AppBundle\Repository;

use Gedmo\Tree\Entity\Repository\NestedTreeRepository;
use Gedmo\Exception\UnexpectedValueException;
use Gedmo\Tool\Wrapper\AbstractWrapper;

/**
 * CustomNestedTreeRepository
 *
 */
class CustomNestedTreeRepository extends NestedTreeRepository
{
  /**
   * moves node as next sibling of dest node
   *
   * @param object    $node          target node which has to be shifted.
   * @param object    $sibling       previous sibling of target node.
   * @param object    $parent        new parent of target node.
   *
   * @return boolean TRUE if all queries were successful.
   */
  public function moveAsNextSiblingOf($node, $sibling, $parent)
  {
      if (empty($node)) {
          throw new InvalidArgumentException('The target node need to be specified.');
      }
      if (empty($sibling)) {
          throw new InvalidArgumentException('The sibling need to be specified.');
      }
      if (empty($parent)) {
          throw new InvalidArgumentException('The parent need to be specified.');
      }
      if ($node === $sibling) {
          throw new UnexpectedValueException("Cannot move node as next sibling of itself");
      }
      return $this->moveExistingNode(
        $node,
        $node->getRootId(),
        $sibling->getRgt() + 1,
        $sibling->getLevel() - $node->getLevel(),
        $parent->getId()
      );
  }

  /**
   * moves node as previous sibling of dest node
   *
   * @param object    $node          target node which has to be shifted.
   * @param object    $sibling       next sibling of target node.
   * @param object    $parent        new parent of target node.
   *
   * @return boolean TRUE if all queries were successful.
   */
  public function moveAsPrevSiblingOf($node, $sibling, $parent)
  {
      if (empty($node)) {
          throw new InvalidArgumentException('The target node need to be specified.');
      }
      if (empty($sibling)) {
          throw new InvalidArgumentException('The sibling need to be specified.');
      }
      if (empty($parent)) {
          throw new InvalidArgumentException('The parent need to be specified.');
      }
      if ($node === $sibling) {
          throw new UnexpectedValueException("Cannot move node as previous sibling of itself");
      }
      return $this->moveExistingNode(
        $node,
        $node->getRootId(),
        $sibling->getLft(),
        $sibling->getLevel() - $node->getLevel(),
        $parent->getId()
      );
  }

  /**
   * move node's and its children to location $destLeft and updates rest of tree
   *
   * @param object    $node         target node which has to be shifted.
   * @param int       $rootId       id of the root node
   * @param int       $destLeft     destination left value
   * @param int       $levelDiff    difference of the level to shift
   * @param int       $newParentId  id of the new parent node
   *
   * @return boolean TRUE if all queries were successful.
   */
  private function moveExistingNode(
    $node = null,
    int $rootId = null,
    int $destLeft = null,
    int $levelDiff = null,
    int $newParentId = null
  ) {
      if (empty($node)) {
          throw new InvalidArgumentException('The target node need to be specified.');
      }
      if ($rootId === null) {
        throw new InvalidArgumentException('The id of the tree root need to be specified.');
      }
      if ($destLeft === null) {
          throw new InvalidArgumentException('The left value of destination need to be specified.');
      }
      if ($levelDiff === null) {
          throw new InvalidArgumentException('The difference of the level need to be specified.');
      }
      if ($newParentId === null) {
          throw new InvalidArgumentException('The id of the new parent need to be specified.');
      }

      $em              = $this->getEntityManager();
      $wrapped         = AbstractWrapper::wrap($node, $em);
      $meta            = $wrapped->getMetadata();
      $config          = $this->listener->getConfiguration($em, $meta->name);
      $identifierField = $meta->getSingleIdentifierFieldName();

      $nodeId          = $wrapped->getIdentifier();
      $left            = $wrapped->getPropertyValue($config['left']);
      $right           = $wrapped->getPropertyValue($config['right']);
      $treeSize        = $right - $left + 1;

      if ($left >= $destLeft) { // src was shifted too?
          $left       += $treeSize;
          $right      += $treeSize;
      }
      $delta           = $destLeft - $left;

      $em->beginTransaction();
      try {
          // Make room in the new branch
          $this->listener
              ->getStrategy($em, $meta->name)
              ->shiftRL($em, $config['useObjectClass'], $destLeft, $treeSize, $rootId);

          // now there's enough room next to target to move the subtree
          $this->listener
              ->getStrategy($em, $meta->name)
              ->shiftRangeRL($em, $config['useObjectClass'], $left, $right, $delta, $rootId, $rootId, $levelDiff);

          // correct values after source (close gap in old tree)
          $this->listener
              ->getStrategy($em, $meta->name)
              ->shiftRL($em, $config['useObjectClass'], $right + 1, -$treeSize, $rootId);

          // point to new parent
          $qb = $em->createQueryBuilder();
          $qb->update($config['useObjectClass'], 'node')
             ->set('node.' . $config['parent'], ':pid')
             ->setParameter('pid', $newParentId)
             ->where($qb->expr()->eq('node.' . $identifierField, ':id'))
             ->setParameter('id', $nodeId);
          $qb->getQuery()->getSingleScalarResult();

          $em->commit();

          return true;
      } catch (Exception $ex) {
          $em->rollback();
          $em->close();
          throw $ex;
      }
  }
}


looks like Pipelines Controller is not freeing memory

Expected Behavior
I would expect after some time Pipelines Controlled under load memory consumption would become constant - Pipelines Controller will start freeing memory.
Actual Behavior
This is a memory graph of a Pipelines Controller processing 10k very simple PipelineRuns with just one Task just printing "hello world" (Pipeline, PipelineRun)
These PRs were running from about 13:00 to to 15:30, script was creating new PRs in a way to make sure at max 100 of them is in pending/running:

Is this expected, or is this some sort of memory leak?
Steps to Reproduce the Problem

Run 10k PipelineRuns and observe Pipelines Controller memory consumption over time
This was automated in this repo with signing-tr-tekton-bigbang scenario

Additional Info

Kubernetes version:

Cluster is gone already, but it was ROSA OpenShift 4.14.11 with 5 compute nodes AWS EC2 m6a.2xlarge

Tekton Pipeline version:

chains-info: v0.19.0
pipelines-as-code-info: v0.22.4
pipelines-info: v0.53.2
triggers-info: v0.25.3
openshift-pipelines-operator-cluster-operations: v0.69.0
openshift-pipelines-operator-lifecycle: 1.13.0

Reported this together with https://github.com/tektoncd/chains/issues/1058

@jhutar are the PipelineRun cleaned (deleted) from the cluster in that scenario ? Because if not, they will be "cached" by the informers and thus, they will be kept in memory up until they are deleted from the cluster (and informers cache updated).

Yes, they are not deleted. So this means Pipelines Controller memory usage will just grow with number and size of PRs in the cluster. If there are excessively big PRs (maybe with long script), this might become a problem even for smaller number of PRs.
I understand this is property of underlying Go library (these informers you mentioned), but is there a way how to drop oldest records from the cache or so? Just to have a way how to keep memory usage flat.

I understand this is property of underlying Go library (these informers you mentioned), but is there a way how to drop oldest records from the cache or so? Just to have a way how to keep memory usage flat.

We need to explore this yes. There might be ways to "optimize" or filter some objects once they are done.


[3.0] fix ignored interface name matches method

What is the purpose of the change
fix #8581 on  branch 3.0

Codecov Report

Merging #8723 (b83bd60) into 3.0 (3a43fb9) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0    #8723      +/-   ##
============================================
- Coverage     63.65%   63.56%   -0.10%
  Complexity      312      312
============================================
  Files          1146     1146
  Lines         48173    48134      -39
  Branches       7252     7218      -34
============================================
- Hits          30665    30594      -71
- Misses        14135    14164      +29
- Partials       3373     3376       +3

Impacted Files
Coverage Δ

...n/java/org/apache/dubbo/common/utils/NetUtils.java
68.83% <100.00%> (-0.71%)
:arrow_down:

...ng/transport/dispatcher/all/AllChannelHandler.java
68.96% <0.00%> (-20.69%)
:arrow_down:

...ng/transport/dispatcher/WrappedChannelHandler.java
43.47% <0.00%> (-15.22%)
:arrow_down:

...ache/dubbo/remoting/transport/AbstractChannel.java
75.00% <0.00%> (-12.50%)
:arrow_down:

...ubbo/registry/client/AbstractServiceDiscovery.java
87.50% <0.00%> (-12.50%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
50.00% <0.00%> (-11.54%)
:arrow_down:

...moting/transport/netty4/NettyEventLoopFactory.java
22.22% <0.00%> (-7.78%)
:arrow_down:

...mmon/threadpool/support/fixed/FixedThreadPool.java
80.00% <0.00%> (-7.50%)
:arrow_down:

...ache/dubbo/remoting/api/NettyEventLoopFactory.java
30.00% <0.00%> (-6.37%)
:arrow_down:

.../threadpool/support/limited/LimitedThreadPool.java
83.33% <0.00%> (-5.56%)
:arrow_down:

... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a43fb9...b83bd60. Read the comment docs.


refactor the t36 test case

Changes to the T36 test case:
Created the istio-system2 namespace
Deployed the Multiple SMCP on that new namespace
Deleted Istio Operator pod, it will recreate the Webhook back again.
This is already reviewed by Marko. I have updated the latest changes, but unexpectedly this PR is deleted.
Here, is the previous PR - https://github.com/maistra/maistra-test-tool/pull/394

Probably we only need this test for a while because we are going to refactor all the code and make the test cases more flexible to execute in every branch


Running nlbwmon package on Openwrt CC

Hi,
I compiled and deployed the nlbwmon package on my router running Openwrt chaos calmer (I created my own Makefile to be able to compile the package).
When I start it via cli, I get the following error:
nlbwmon
No interval specified; assuming 1st of month
Unable to read protocol list /usr/share/nlbwmon/protocols: No such file or directory
Apparently, I need to create a file with the list of protocols. Can you please specify the list of config options needed to have it working correctly? do I need to specify the database-folder?
How can I also use the client utility (nlbw) in order to query the daemon for current statistics?
Thank you

try lede nlbwmon package. all file in it.

The usage is explained in https://github.com/jow-/nlbwmon/blob/master/README.md
An example protocols file can be found at https://github.com/jow-/nlbwmon/blob/master/protocols.txt


bugfix: avoid data race in set exec exit status

there are two goroutines response for changed exec config information,
if exec process got error, data race appears, exec exit hook runs in a
goroutine, it modify exec exit status, StartExec also modify exec exit
status in another goroutine since error happend. Fix it by only one
place can modify exec exit status.
Signed-off-by: Ace-Tang<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

The result may error depend on which goroutine run last
#./pouch exec 30f44535e526947d9e1cb41974f4fb944c596c385938d353002f0e44646ea7ea aaaaa
failed to exec process: OCI runtime exec failed: exec failed: container_linux.go:265: starting container process caused "exec: \"aaaaa\": executable file not found in $PATH": unknown

#echo $?
0

#./pouch exec 30f44535e526947d9e1cb41974f4fb944c596c385938d353002f0e44646ea7ea dsad
failed to exec process: OCI runtime exec failed: exec failed: container_linux.go:265: starting container process caused "exec: "dsad": executable file not found in $PATH": unknown
#echo $?
126

Codecov Report

Merging #2152 into master will increase coverage by 0.09%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master    #2152      +/-   ##
==========================================
+ Coverage   64.41%   64.51%   +0.09%
==========================================
  Files         209      209
  Lines       16662    16660       -2
==========================================
+ Hits        10733    10748      +15
+ Misses       4603     4588      -15
+ Partials     1326     1324       -2

Flag
Coverage Δ

#criv1alpha1test
32.74% <40%> (-0.25%)
:arrow_down:

#criv1alpha2test
33.56% <40%> (+0.01%)
:arrow_up:

#integrationtest
39.38% <40%> (+0.12%)
:arrow_up:

#unittest
23.86% <0%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

daemon/mgr/container_exec.go
77.66% <ø> (+9.4%)
:arrow_up:

ctrd/container.go
44.73% <40%> (+1.53%)
:arrow_up:

daemon/logger/jsonfile/utils.go
71.54% <0%> (-1.63%)
:arrow_down:

cri/v1alpha1/cri.go
63.3% <0%> (-0.7%)
:arrow_down:

daemon/mgr/container.go
56.51% <0%> (-0.42%)
:arrow_down:

daemon/containerio/container_io.go
75.69% <0%> (+1.1%)
:arrow_up:

ctrd/image.go
78.94% <0%> (+1.75%)
:arrow_up:

apis/server/exec_bridge.go
54.23% <0%> (+3.38%)
:arrow_up:

cri/stream/httpstream/spdy/upgrade.go
60% <0%> (+5.71%)
:arrow_up:

... and 1 more

fail with
" exited with 0.
$ bash <(curl -s https://codecov.io/bash) -cF ${TEST_SUITE} -y .codecov.yml
/dev/fd/63: line 1: html: No such file or directory
/dev/fd/63: line 2: syntax error near unexpected token `<'

@fuweid, deep copy may need, but for this case, we should keep the data race from the logic, deep copy won't avoid this.

LGTM


Added support for google image resolution

Params: resolution, Values: [l,m,i]
On another note, are you sure that Nighmare is releasing by itself all the memory/processes when done replying the results ?
I'm not seeing any
nightmare.teardownInstance(); or nightmare.end();
I will look into supporting more options from the image resolution options.
Google closed their deprecated public api for image searches today. So here I come!
Good job by the way!

@Elyx0 Thanks! Very good idea, I'll merge right away! :+1:

Nice, I can now use it in production from master !

Oh man such open source goodness here right before christmas, very pull, such request


Launching VM, but VM keep pending status

When launching VM use "kubectl create -f vm.json" , then the VM keep pending status.
[root@master ~]# kubectl get vms
NAME      KIND
testvm    VM.v1alpha1.kubevirt.io

[root@master ~]# virsh list
 Id    Name                           State
--------------------------------------------------

[root@master ~]# kubectl get events
LASTSEEN   FIRSTSEEN   COUNT     NAME      KIND      SUBOBJECT   TYPE      REASON       SOURCE                  MESSAGE
3m         1h          7         testvm    VM                    Warning   SyncFailed   {virt-handler master}   virError(Code=27, Domain=20, Message='XML error: missing network source protocol type')

[root@master ~]# kubectl get pods --all-namespaces
NAMESPACE     NAME                                READY     STATUS    RESTARTS   AGE
default       frontend-j1aaj                      1/1       Running   2          5d
default       frontend-ll60x                      1/1       Running   2          5d
default       frontend-xgjh9                      1/1       Running   2          5d
default       haproxy                             1/1       Running   7          5d
default       kubevirt-cockpit-3069757025-y1mga   1/1       Running   0          5h
default       redis-master-zljqa                  1/1       Running   2          5d
default       redis-slave-d8w0i                   1/1       Running   2          5d
default       redis-slave-y355j                   1/1       Running   2          5d
default       spice-proxy                         1/1       Running   2          5d
default       virt-api                            1/1       Running   2          5d
default       virt-controller                     1/1       Running   2          5d
default       virt-handler-ehv1v                  1/1       Running   2          5d
default       wordpress-1618093523-de8zj          1/1       Running   4          34d
default       wordpress-mysql-2379610080-5p0e6    1/1       Running   4          34d
kube-system   dummy-2088944543-lxi8s              1/1       Running   4          34d
kube-system   etcd-master                         1/1       Running   5          34d
kube-system   kube-apiserver-master               1/1       Running   6          34d
kube-system   kube-controller-manager-master      1/1       Running   6          34d
kube-system   kube-discovery-3670776889-793t6     1/1       Running   5          34d
kube-system   kube-dns-2924299975-8ic0c           4/4       Running   16         34d
kube-system   kube-proxy-ufd6z                    1/1       Running   4          34d
kube-system   kube-scheduler-master               1/1       Running   6          34d
kube-system   weave-net-tvs1l                     2/2       Running   9          34d

[root@master ~]# kubectl get vms -o json
{
    "apiVersion": "v1",
    "items": [
        {
            "apiVersion": "kubevirt.io/v1alpha1",
            "kind": "VM",
            "metadata": {
                "creationTimestamp": "2017-03-22T07:54:11Z",
                "labels": {
                    "kubevirt.io/nodeName": "master"
                },
                "name": "testvm",
                "namespace": "default",
                "resourceVersion": "2216964",
                "selfLink": "/apis/kubevirt.io/v1alpha1/namespaces/default/vms/testvm",
                "uid": "bc57dcd3-0ed4-11e7-909e-525400b58bb7"
            },
            "spec": {
                "domain": {
                    "devices": {
                        "disks": [
                            {
                                "device": "disk",
                                "diskSource": {
                                    "file": ""
                                },
                                "diskTarget": {
                                    "bus": "",
                                    "dev": ""
                                },
                                "driver": {
                                    "cache": "none",
                                    "name": "qemu",
                                    "type": "raw"
                                },
                                "shapshot": "",
                                "type": "network"
                            }
                        ],
                        "emulator": "/usr/local/bin/qemu-x86_64",
                        "graphics": [
                            {
                                "autoPort": "yes",
                                "defaultMode": "any",
                                "listen": {
                                    "address": "<IP_ADDRESS>",
                                    "type": "address"
                                },
                                "port": 4000,
                                "type": "spice"
                            }
                        ],
                        "interfaces": [
                            {
                                "source": {
                                    "network": "default"
                                },
                                "type": "network"
                            }
                        ],
                        "video": [
                            {
                                "Model": {
                                    "VGAMem": 16384,
                                    "heads": 1,
                                    "ram": 65536,
                                    "type": "qxl",
                                    "vram": 8192
                                }
                            }
                        ]
                    },
                    "memory": {
                        "unit": "MB",
                        "value": 64
                    },
                    "name": "testvm",
                    "os": {
                        "bootOrder": null,
                        "type": {
                            "os": "hvm"
                        }
                    },
                    "type": "qemu",
                    "uuid": "bc57dcd3-0ed4-11e7-909e-525400b58bb7"
                }
            },
            "status": {
                "nodeName": "master",
                "phase": "Pending"
            }
        }
    ],
    "kind": "List",
    "metadata": {},
    "resourceVersion": "",
    "selfLink": ""
}

@kenzhaoyihui thanks for reporting this.
It seems like you had the bad luck of checking out a commit from master, where the example vm.json and the internal schema mapping was not in sync.
I am pretty sure that in vm.json, you will see the diskTarget mapped to target and diskSource to source. These fields got lost and now libvirt is complaining about missing information.
Could you checkout latest master and run cluster/sync.sh again? That should resolve the issue ...
Since your version seems to be about a month old, it might also make sense to recreate the vagrant environment, but it should work without.

@kenzhaoyihui did you have the time to give it another try with latest master?

@rmohr yeah, I will have an other try with latest master tomorrow. Today I don't have the clean ENV. If I finish, I will give the feedback.

Due to deploy the latest git on fresh Fedora 25 blocked by some issues. So I just git pull the latest git and execute cmd ./cluster/sync.sh
Pods are all running
[root@dhcp-11-123 kubevirt]# ./cluster/kubectl.sh get pods --all-namespaces
NAMESPACE     NAME                                     READY     STATUS    RESTARTS   AGE
default       haproxy                                  1/1       Running   15         12d
default       haproxy-2737689567-lphrs                 1/1       Running   0          14m
default       iscsi-demo-target-tgtd-474016847-gd8hf   1/1       Running   0          14m
default       kubevirt-cockpit-3405564194-wy0gd        1/1       Running   0          14m
default       spice-proxy                              1/1       Running   6          12d
default       spice-proxy-3576158421-k0jw7             1/1       Running   0          14m
default       virt-api                                 1/1       Running   5          12d
default       virt-api-988471961-u8lmq                 1/1       Running   0          14m
default       virt-controller                          1/1       Running   6          12d
default       virt-controller-1177942624-tzrsg         1/1       Running   0          14m
default       virt-handler-vwb39                       1/1       Running   0          14m
default       wordpress-1618093523-de8zj               1/1       Running   8          41d
default       wordpress-mysql-2379610080-5p0e6         1/1       Running   8          41d
kube-system   dummy-2088944543-lxi8s                   1/1       Running   8          41d
kube-system   etcd-master                              1/1       Running   9          41d
kube-system   kube-apiserver-master                    1/1       Running   13         41d
kube-system   kube-controller-manager-master           1/1       Running   10         41d
kube-system   kube-discovery-3670776889-793t6          1/1       Running   9          41d
kube-system   kube-dns-2924299975-8ic0c                4/4       Running   30         41d
kube-system   kube-proxy-ufd6z                         1/1       Running   8          41d
kube-system   kube-scheduler-master                    1/1       Running   10         41d
kube-system   weave-net-tvs1l                          2/2       Running   18         41d

VM Info
[root@dhcp-11-123 kubevirt]# ./cluster/kubectl.sh get vms
NAME      KIND
testvm    VM.v1alpha1.kubevirt.io

[root@dhcp-11-123 kubevirt]# ./cluster/kubectl.sh spice testvm --details
Do: VM is not running

[root@master ~]# virsh list
 Id    Name                           State
----------------------------------------------------

Events errors
30m        30m         1         virt-handler                             DaemonSet                                       Normal    SuccessfulCreate          {daemon-set }              Created pod: virt-handler-12bdv
25m        25m         1         virt-handler                             DaemonSet                                       Normal    SuccessfulCreate          {daemon-set }              Created pod: virt-handler-vwb39
43m        43m         2         virt-launcher-testvm-----e7m9o           Pod                                             Normal    FailedScheduling          {default-scheduler }       Binding rejected: Operation cannot be fulfilled on pods/binding "virt-launcher-testvm-----e7m9o": pod virt-launcher-testvm-----e7m9o is being deleted, cannot be assigned to a host
21m        21m         1         virt-launcher-testvm-----r49rt           Pod                                             Normal    Scheduled                 {default-scheduler }       Successfully assigned virt-launcher-testvm-----r49rt to master
19m        19m         1         virt-launcher-testvm-----r49rt           Pod                                             Warning   FailedMount               {kubelet master}           Unable to mount volumes for pod "virt-launcher-testvm-----r49rt_default(8652e130-1457-11e7-95d9-525400b58bb7)": timeout expired waiting for volumes to attach/mount for pod "virt-launcher-testvm-----r49rt"/"default". list of unattached/unmounted volumes=[default-token-efw9d]
19m        19m         1         virt-launcher-testvm-----r49rt           Pod                                             Warning   FailedSync                {kubelet master}           Error syncing pod, skipping: timeout expired waiting for volumes to attach/mount for pod "virt-launcher-testvm-----r49rt"/"default". list of unattached/unmounted volumes=[default-token-efw9d]

VM on kubevirt-cockpit
kubevirt-cockpit
If any problems or needinfo, don't hesitate to contact me, I will have another try to follow and track.

@kenzhaoyihui are you still seeing this issue?


Improve mirroring metrics

Motivation
Remove remote repo tag for mirroring metrics to view metrics more easily.

Thanks, @jrhee17  😄


Article Update: Integrating django with tinymce

Article checklist
Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[ ] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes

Remove the backticks and add the issue number below to link and close your Topic Suggestion (issue) when your article has been published (PR has been merged). See this video for more details.

This closes #issue-number

Finally, delete the article checklist notes in blockquotes and submit your PR. We look forward to reviewing your article.

@Sajeyks can you confirm that the image paths I changed was indeed correct?
Also just want to double check - this PR was created after doing a git pull on your forked repo? 👍

@Sajeyks can you confirm that the image paths I changed was indeed correct?
Also just want to double check - this PR was created after doing a git pull on your forked repo? 👍

Yeah

@Sajeyks can you confirm that the image paths I changed was indeed correct?
Also just want to double check - this PR was created after doing a git pull on your forked repo? 👍

yes.


tour: Wording may be wrong for number advice

Context: http://<IP_ADDRESS>:3999/basics/11
This might just be me not understanding the language but shouldn't the following be "..a SIGNED or unsigned.." or is it correct as it is?
"When you need an integer value you should use int unless you have a specific reason to use a sized or unsigned integer type.

It's correct as is. A sized type would be int64, and an unsigned type would be uint.


Add surface mobs

(As is displayed in https://github.com/devs-immortal/The-Aether/projects/4)
Add:

[ ] Phyg, (Will be replaced)
[ ] Flying Cow, (Will be replaced)
[ ] Sheepuff, (Will be replaced)
[x] Swet, (Added, for the most part)
[x] Moa, (Added, for the most part)
[x] Aerbunny, (Added, for the most part)
[x] Aerwhale, (In, but non-functioning)
[x] Cockatrice, (In, but with incomplete animations)
[x] Aechor plant, (In, but with incomplete models and textures)
[ ] Zephyr,
[ ] Zephyroo,
[ ] Burrukai,
[ ] Glitterwing (?),
[ ] Glactrix (?),
[ ] Kirrid,
[ ] Carrion Sprout

Closed for the time being due to an unknown issue with the contents breaking REST Api retrieval.

Closing as no longer relevant


Downloading is very slow now .....!! please fix this

last year when I use udemy-dl it was blazing fast and I downloaded the whole course in around 3 hours I guess, now I have put a course to download around 5 pm its now 9 pm and its still hasn't reached halfway through.
please fix this it takes too much time to download course now. I am getting 20mbps speed still its really slow

@vivekpanchal udemy-dl also have an option with switch --save through which you can save links to download using external programs such as curl etc. but i will try to fix this issue as i get free time

@vivekpanchal i 'm closing this issue and will w8 for other to report / suggestion for now the downloading part is okay.


Toggle comment expansion does not toggle when comment has just been manually opened and closed

Testing #2931
Repro Steps:

From a comment close it using the - UI button on the comment
From the editor gutter expand the comment back out
Use the Toggle Comment Expansion command

Expected: Command toggles to hidden
Actual: Nothing happens
Gif below.

Note: After the first command run, it will then toggle correctly on the second run of the command.

Looking more closely now I believe that this behavior is intentional. But leaving the bug open just to mention that I think that the UI paradigm is a bit confusing. I would just say that the space on the top of the toolbar feels very "comment specific" so controlling a global setting from that location felt very odd to me kinda per #2940 . I get now that it's just swapping the setting, but I honestly didn't notice the + / - change on the icon so my GIF above felt wrong. Especially as I would consider that a Toggle command would always do something. Having a command "Expand All PR Comments" and another command "Collapse All PR Comments" would match the behavior more to me.

👍 two commands makes sense, I will add that.

Here's what I landed on:

The Toggle command has been removed in favor of a Collapse command and an Expand command
The setting is no longer changed when you run the Expand/Collapse commands or the use the action on the comment widget.
The action on the comment widget is always "Collapse All Comments".


Kay 2015

Pull Request
This PR is for a

[x] New Publication(s)
[ ] Correction

For the follow list (s)

[ ] ancientmetagenome-anthropogenic (README)
[ ] ancientmetagenome-environmental (README)
[ ] ancientmetagenome-hostassociated (README)
[x] ancientsinglegenome-hostassociated (README)

New Publication
Publication Information

This pull request is to add samples from the following publication(s):

Checklist

[x] Publication is published (preprints currently not accepted)?
[x] Checked the publication is not already in the database?
[x] Checked samples in this publication are not previously published data (newly re-sequenced metagenomes are OK!)?
[x] Samples are shotgun metagenomes (hostassociated-singlegenome may also contain whole-genome enriched data)?
[x] Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
[x] (If applicable) Updated the JSON files under /assets/enums with new categories (e.g. material or archive)?
[ ] Does your PR pass validation checks?
[x] Changelog is updated?

If you do not know how to check errors in failed validation checks, expand here

Press 'details' next to the failed check.
Expand the test ancient <list> line with the red X next to it.
Scroll to the bottom of the log, and look for a DatasetValidationError (usually the last line).
Read the error, and fix accordingly. Check the README for a given list for more guidance. If in doubt, ask!

Correction
This PR is for

[ ] ancientmetagenome-hostassociated
[ ] ancientsinglegenome-hostassociated
[ ] ancientmetagenome-environmental
[ ] ancientmetagenome-anthropogenic

Reference
This pull request is to correct samples from the following publication(s):

Description
The issue is:

Checklist

[ ] Checked the corrected entries follow conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)
[ ] Does your PR pass validation checks?
[ ] Changelog is updated?

@jfy133 there are several individuals with mixed infections of TB strains, for example several individuals have 2 or 3 TB strains - according to the authors’ analysis. Do I enter every strain  separately OR do I make one entry per individual?
Also, I have intentionally put 4 decimals for the lat long, or else it is not correct enough for the site location, but I can change if you need it o be 3 decimals or less ;)


Stream Browser top pane column spacing

Info is right justified and Retention is right justified, so they are too close

This looks fixed


search string

Hi
need to compare the search string , for example: link /search/query:abcd, string abcd
with given value, for example: {% if abcd == ' qwerty' %}
how I can get value  'abcd' in twig for copmpare?

I'm not sure about the colon syntax, but if you use ? for your query parameters (eg. /search?query=abcd), you can access the query as a string using grav.request.uri.query. If you have multiple parameters, you can split on &, and then split the elements on = to get the parameter names and values; if it's just the one parameter, you only need the latter split, but there's no real issue in doing both.
If you enable the debugger and add {{ dump(grav.request.uri) }} in your twig template (or page if you enable twig processing there), it'll print the to messages. You can adjust the dump command (or use multiple) to explore what other useful keys exist.

thanks


Fix: Converting all guides Github action (Staging branch)

fix for #2274

PR not ready - DO NOT MERGE!


Updated JumblrException to correctly parse errors from response body.

Fixes #91
In this version JumblrException correctly parses error objects and stores error details in a new JumblrError type, which makes the code, title and detail accessible to the end user.

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

Ah great. I had printed out that CLA file and was just about to scan it, but that online form is much easier! Done.

There are some pretty old PRs in here. I really need this fix, actually. So I'm wondering what the movement time is on these PRs? Am I better off just deploying my fork instead?


Added preloader

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state “None”] None
Fixes:  #1195
Description
I added a custom preloader to the webapp
#1195
Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
https://github.com/user-attachments/assets/92c24c17-f5fd-4d23-94bb-41d5e6227797
Checklist:

[x] I have made this change from my own.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

@PriyaGhosal
I have done my work kindly check it out
and give the GSSOC-24 EXTD, Hacktoberfest, and Level. It will be an honor

@Peart-Guy Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch.

@Peart-Guy Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch.

@PriyaGhosal  It is showing some issue related to my PR description. Can you please help me in this.

@Peart-Guy Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch.

@PriyaGhosal
I have resolved all the conflicts highlighted. Kindly check it out.

@Peart-Guy can you remove the preloader coming after the pop up as it is very time taking

@Peart-Guy Are you working on it

@Peart-Guy Are you working on it

Ya i am working on it

@Peart-Guy can you remove the preloader coming after the pop up as it is very irritating for user . only at the beginnig it is good and after clicking on no thanks in pop up preloader is not needed

@PriyaGhosal  I have tried several ways but couldn't figure it out

@Peart-Guy Did you get anyway to solve the problem ?
or Shall I close the issue

@Peart-Guy Did you get anyway to solve the problem ? or Shall I close the pr

@PriyaGhosal  The preloader  automatically gets removed when the page is loaded fully. It does not depend on pop up.

@Peart-Guy  Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile! Also Take a moment to ⭐ Star the repository if you haven't already.
Great contribution ! 🎉


add generation1-convenience-client flag

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check for Azure.IoT.Hub.Service
API changes are not detected in this pull request for Azure.IoT.Hub.Service

API change check for Azure.MixedReality.ObjectAnchors.Conversion
API changes are not detected in this pull request for Azure.MixedReality.ObjectAnchors.Conversion

API change check for Azure.MixedReality.RemoteRendering
API changes are not detected in this pull request for Azure.MixedReality.RemoteRendering

API change check for Azure.AI.MetricsAdvisor
API changes are not detected in this pull request for Azure.AI.MetricsAdvisor

API change check for Azure.Messaging.EventGrid
API changes are not detected in this pull request for Azure.Messaging.EventGrid

API change check for Azure.AI.Translation.Document
API changes are not detected in this pull request for Azure.AI.Translation.Document

API change check for Azure.Data.SchemaRegistry
API changes are not detected in this pull request for Azure.Data.SchemaRegistry

API change check for Azure.IoT.TimeSeriesInsights
API changes are not detected in this pull request for Azure.IoT.TimeSeriesInsights

API change check for Azure.Quantum.Jobs
API changes are not detected in this pull request for Azure.Quantum.Jobs

API change check for Azure.AI.AnomalyDetector
API changes are not detected in this pull request for Azure.AI.AnomalyDetector

API change check for Azure.AI.TextAnalytics
API changes are not detected in this pull request for Azure.AI.TextAnalytics

API change check for Azure.DigitalTwins.Core
API changes are not detected in this pull request for Azure.DigitalTwins.Core

API change check for Azure.AI.Language.Conversations
API changes are not detected in this pull request for Azure.AI.Language.Conversations

API change check for Azure.Security.KeyVault.Administration
API changes are not detected in this pull request for Azure.Security.KeyVault.Administration

API change check for Azure.AI.Language.QuestionAnswering
API changes are not detected in this pull request for Azure.AI.Language.QuestionAnswering

API change check for Azure.Monitor.OpenTelemetry.Exporter
API changes are not detected in this pull request for Azure.Monitor.OpenTelemetry.Exporter

API change check for Azure.Monitor.Query
API changes are not detected in this pull request for Azure.Monitor.Query

API change check for Azure.AI.FormRecognizer
API changes are not detected in this pull request for Azure.AI.FormRecognizer

API change check for Azure.Data.Tables
API changes are not detected in this pull request for Azure.Data.Tables

API change check for Azure.Containers.ContainerRegistry
API changes are not detected in this pull request for Azure.Containers.ContainerRegistry

API change check for Azure.Search.Documents
API changes are not detected in this pull request for Azure.Search.Documents

API change check for Azure.Security.Attestation
API changes are not detected in this pull request for Azure.Security.Attestation

API change check for Azure.MixedReality.Authentication
API changes are not detected in this pull request for Azure.MixedReality.Authentication

API change check for Azure.Storage.Blobs
API changes are not detected in this pull request for Azure.Storage.Blobs

API change check for Azure.Storage.Blobs.Batch
API changes are not detected in this pull request for Azure.Storage.Blobs.Batch

API change check for Azure.Storage.Files.Shares
API changes are not detected in this pull request for Azure.Storage.Files.Shares

API change check for Azure.Storage.Files.DataLake
API changes are not detected in this pull request for Azure.Storage.Files.DataLake

API change check for Azure.Storage.Queues
API changes are not detected in this pull request for Azure.Storage.Queues

We will set 'data-plane' as autorest.csharp codegen default tag. and will add new tag 'generation1-convenience-client' tag for the HLC Client Library.
This pull request is to add the new flag for all the .NET HLC Client Library package.
After the Pull request is merged, we will upgrade the autorest.csharp version which will add 'data-plane' as default tag. That is, if no flag(azure-arm or generation1-convenience-client) is set, the autorest.csharp will generate DPG library.

The check 'net-synapse -ci' failed because the 'Microsoft.Azure.Synapse' package has invalid CHANGELOG.md file. And the issue is not caused by the pull request.

/check-enforcer override

@chunyu3 can you describe what this new setting does? Ideally, it would make a nice PR description as opposed to the default PR template meant more for external contributors to read and replace.

@heaths, i see the explaination of this PR in the description, do you still have question related to the new settings?


should it actual be possible to join a network formed by an esp32-coordinator with a consumer device? (TZ-335)

I have two esp32-c6 boards and tried different scenarios. The examples/esp_zigbee_HA_sample/HA_on_off_light scenario works and that proofs my boards working.
I tried esp_zb_switch, esp_zigbee_cli as well as esp_zigbee_gateway/esp_zigbee_rcp to let https://www.zigbee2mqtt.io/devices/E1524_E1810.html and/or https://www.zigbee2mqtt.io/devices/ZTH02.html join the successfully formed network, but they do not join, or the leave the network after seconds and never send events.
I'm not an expert regarding zigbee, but i'm quite familiar with zigbee-herdsman and already got some unsupported devices integrated. Do i have a general misunderstanding?
Would it be possible to publish an example that uses esp_zigbee_cli that just dumps raw interview and event data to the console? That would be much appreciated!

Hai @mw75
I integrated https://www.zigbee2mqtt.io/devices/E1524_E1810.html  Ikia Button. But Not with the esp, I used Nordic chip.
But One thing I Found in many zigbee devices, We need to bind the clusters to get data.
Your Ikia button have ON/OFF , Level control. You need to bind on/off of button with on/off of coordinator. (Server & Client)
You need to do immediately, once device got joined. Other vice Device will leave or It will go to sleep mode.

Hello @mw75 ,
Have you found a resolution for your issue? If not, please feel free to discuss your problem further. Otherwise, consider closing this issue.


Change box-shadow class with built in shadows utilities for some example page

Since bootstrap added built in shadows utilities, I think some example like off-canvas, blog, etc page can remove box-shadow class and use bootstrap built in shadows utilities
And example page who not use box-shadow like checkout page can remove box-shadow class in css stylesheet file

Hi @adiramardiani  I want to work on this issue

Of course @parammittal16 , @mdo will glad :+1:

Thanks a lot.
Sir these are some builtin bootstrap utilites -
shadow-sm, shadow and shadow-lg
I have to apply which one of them and on which examples here

Sir, I cloned the project from master branch but I didn't get all the examples here like pricing example was not there. In the Contribution.md file, it is cleared that we should edit code on master branch but it does not contain all examples. What should I do now ??

ok sir thank you.

@adiramardiani @mdo I have opened the pull request https://github.com/twbs/bootstrap/pull/26493.


Failed to instantiate module app due to: Error: [$injector:modulerr] Failed to instantiate module ui.bootstrap.datetimepicker

Error while including the module

is there a plunker that reproduces the issue? was the latest version used? https://github.com/zhaber/angular-js-bootstrap-datetimepicker/blob/master/datetimepicker.js


Change users.yaml E-tender

Change

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


Dart outputs stdout to stderr

Is dart supposed to put standard command output to stderr?
This is what you get from running
Process.runSync('dart', ['--version']);

dart --version only prints to stderr:
$ dart --version 2>/dev/null
$

(nothing is printed)
Are you saying you think that the version number should be printed to stdout?

I do. Am I mistaken? Isn’t stderr for errors?
On May 30, 2020, at 4:40 PM, Sam Rawlins <notifications<EMAIL_ADDRESS>wrote:
dart --version only prints to stderr:
$ dart --version 2>/dev/null
$
(nothing is printed)
Are you saying you think that the version number should be printed to stdout?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/dart-lang/sdk/issues/42123#issuecomment-636398696, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFPYO7KSLFHPIR7434TQNB3RUGKNTANCNFSM4NORB7GA.

Some tools output --version and --help to stderr. There is no clear convention - so this is working as intended.


Add check to exit training on NaN

This will speed up curriculums and allow for higher-risk, higher-reward model settings (higher learning rate, higher weight decay, post-norm, etc).
Also fixes issue: https://github.com/ReaLLMASIC/nanoGPT/issues/92

Looks good


enable-weak-ssl-ciphers enable-ssl3 enable-ssl3-method

What version of Go are you using (go version)?

$ go version
go version devel +d5a36531b2 darwin/amd64

Could you clarify why do we need to compile openssl with weak ciphers enabled in order to run the test?
// src/crypto/tls/handshake_test.go
 75         println("***********************************************")
 76         println("")
 77         println("You need to build OpenSSL 1.1.1 from source in order")
 78         println("to update the test data.")
 79         println("")
 80         println("Configure it with:")
 81         println("./Configure enable-weak-ssl-ciphers enable-ssl3 enable-ssl3-method")
 82         println("and then add the apps/ directory at the front of your PATH.")
 83         println("***********************************************")

Thanks!

In order to test weak ciphers like RC4 and legacy protocols like SSLv3, which are off by default in a Go but still supported.
Note that tests are recorded, so you only need a special OpenSSL if you want to change or make a new recording. Otherwise you don’t need OpenSSL at all.

Appreciate the explanation there @FiloSottile


Please include a license

Hi there. It would be really helpful from a distribution packaging point of view if you could include a copy of the MIT license text with your software, usually in a file called LICENSE.
Thanks!

✔


Problem while doing go get

Summary
I tried doing go get github.com/wasmerio/go-ext-wasm/wasmer
but it throws me error:
../go/src/github.com/wasmerio/go-ext-wasm/wasmer/bridge.go:162:87: cannot use (*_Ctype_struct___13)(instanceContext) (type *_Ctype_struct___13) as type *_Ctype_struct___16 in argument to _Cfunc_wasmer_instance_context_data_get

Additional details
My go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/ubuntu/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/ubuntu/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build913563706=/tmp/go-build -gno-record-gcc-switches"

Initially, I was getting error:
ubuntu@ip:~/1$ go get github.com/wasmerio/go-ext-wasm/wasmer
# github.com/wasmerio/go-ext-wasm/wasmer
exec: "gcc": executable file not found in $PATH

Than I did sudo apt install gcc and installed gcc.
Post that the go get for wasmer is giving mentioned error.
Any pointer on what might have gone wrong?

Thanks for raising the issue. Unfortunately, I'm not able to reproduce. The CI server uses Ubuntu for the Linux tests, maybe you can find interesting info: https://circleci.com/gh/wasmerio/go-ext-wasm/80?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link.

Basic question: What Go version do you have?

Basic question: What Go version do you have?

go version go1.11 linux/amd64

Thanks for raising the issue. Unfortunately, I'm not able to reproduce. The CI server uses Ubuntu for the Linux tests, maybe you can find interesting info: https://circleci.com/gh/wasmerio/go-ext-wasm/80?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link.

I see the servers have go1.12. Is it a requirement to have go1.12.x + for wasmer?

I don't know. I never tried with Go 1.11. Can you try with 1.12 to see if it fixes the problem?

Thanks, it's working with 1.12

I just hit the same issue under Go 1.14 on NixOS, but it does not appear under 1.13.8.

I hit this or a similar problem in my own fork. Go 1.14 has better type checking for CGo. It caught a type errors in the bridge.go file that I had modified. I believe that is what is going on here.

@Hywan So I assume that means go-ext-wasm is not yet go 14 compatible?

The CI tests against Go 1.13. I'll try with Go 1.14.

Check https://github.com/wasmerio/go-ext-wasm/pull/129

I just tested on macOS with Go 1.14 and had no problem. @AdamSLevy Do you know what should change in bridge.go?

@Hywan Can also no longer reproduce this with v0.3.2 and Go 1.14.1. Thank you for looking into this.

@FlorianFranzen Good to hear!

This got closed but I think the issue is still present. The issue is here:
https://github.com/wasmerio/go-ext-wasm/blob/0e9bfcdfc7025cdafd17345047277387ef960d25/wasmer/bridge.go#L519-L524
That should be an instanceContext not an instance in that function.

Sorry for the late reply. @AdamSLevy Are you willing to open a PR to address the issue please?

Thanks for the opportunity but I'm too busy. Please don't wait for me to fix this.

:+1:

I'm closing this issue as there where no new feedback on this problem.


BH: investigate/tune dispatch performance

Primary issue here is l1 data cache invalidate and timeouts, fix pending.  See also:
[] #15666
[] #16007
after which we should tune branch prediction
[] #15386


React 17 doesn't work with dependency<EMAIL_ADDRESS>

Hi all, I am trying to include this beautiful library into my project, but I get the following error:

npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>|| ^15.0.0 || ^16.0.0" from<EMAIL_ADDRESS>npm ERR! node_modules/create-react-context
npm ERR!   create-react-context@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Does anyone have a solution for this, or is it safe to force the install?

It seems that the project would run React version 16 because of the limitation of "create-react-context"

Is it possible to remove "create-react-context" in this beautiful library for supporting react version 17 ?

@tikakwork I have just installed the library with --legace-peer-deps. It works even thought create-react-context wants version 16. React itself also tells that 16 to 17 doesnt break if I remember correctly.

@maxcww does it means the react library of timeline used is 16 instead of 17?

@davidtung383 If you look at the package.json file of this library, it says version "react": "^16.2.0", so I think it does use 16 yes.

@maxcww then this timeline library cannot enjoy the version upgrade of react now😥

@davidtung383 That does not really matter as according to React https://reactjs.org/blog/2020/08/10/react-v17-rc.html there are no new features ;)

sounds good~
however, still hope timeline library can support react 17 or later versions since there maybe many updates in the future.

@davidtung383 I dont know whether the creator of this library is still updating it, as the last release was in november 2019...

@maxcww Would you think re-open this issue can let creators know there is potential problem on timeline library on React version upgrade?


SAM0509 reports incorrect size

I have a Samsung UE32B7090WB tv/display which reports as SAM0509 with 16 cm x 9 cm (~7.2"). In reality it is  32" as can be seen in the original version string (not reported via EDID) and exists in other sizes as well.
Is there a database to collect faulty information?
What is the best way to request correction to the manufacturer?

FWIW I know size may possibly even be retrieved through ddc, and I found this neat script to help people with these problems.
But aside of a few quirks in the kernel files I couldn't locate another place for somebody to have systematically collected known broken/fixed edids.


FIX: replace circular-json with flatted

Changes

replace circular-json with flatted, as circular-json has been marked as deprecated, and based on the READ.ME, change to flatted
Add node 8 and 10 to the travis

If everyone approved it, can we merge it and release as a patch?

@ai, I believe this will have to be released as minor at least, since we're changing dependencies. Otherwise we will have to let the eslint team know about this been released as a patch, since this package is a dependency in file-entry-cache which in time is a dependency in eslint, just to avoid causing issues there.

Hi @royriojas, I'm from the ESLint team.
As long as the functionality of your package is unchanged, you can release as patch or minor if you wish. It would just help us to also have a new release of file-entry-cache with the flat-cache dependency set to use the updated version, so we can solve the deprecation warning on the ESLint side. But definitely no rush on this at all. Thanks!

published as<EMAIL_ADDRESS>Thank you guys!

@royriojas if I understand you correctly this fix will be released with the next major version?

I think we need to figure out why the cache structure changed with the upgrade and see if there's a way to avoid that, so that we could publish this as a minor release. I don't think there was an intention to change the cache structure, but it just happened due to the dependency exposing a slightly different API or something.
I'm happy to try to look into that when I have time.
None of this is to speak for @royriojas, who may have a different plan entirely.

@lenovouser yes, it should be on a new major, also we should upgrade the tests in eslint so they don't read the cache directly, because the format is an implementation detail, so it should not be something our tests rely on, I believe.
@platinumazure I'm not having enough spare time these days. But I'm sure the issue is that we should not read the cache directly from eslint tests but to find another way to test.


Add cv01 feature to test font

I was doing font-variant-alternates wrong, so Firefox was coming out looking worse than it actually is. Fixed now, just need to add the one last feature to the font.


Finalizer

Fix #3143
Add a finalizer for CSVs for cleanup, rather than the existing method.
Description of the change:
Motivation for the change:
Architectural changes:

Testing remarks:

Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Bug fixes are accompanied by regression test(s)
[ ] e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
[ ] tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
[ ] Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
[ ] Docs updated or added to /doc
[ ] Commit messages sensible and descriptive
[ ] Tests marked as [FLAKE] are truly flaky and have an issue
[ ] Code is properly formatted

I have not added a test file for the new reconciler, either.

Thanks @stevekuznetsov for your comments!

@tmshort can you dupe the issue / create one for the InstallPlan work since this PR will close #3143 but not implement that half?

@tmshort can you dupe the issue / create one for the InstallPlan work since this PR will close #3143 but not implement that half?

Yes.


I wonder how you make jni_prefix.patch for another webrtc ver.

Hi, I'm really thanksful your repo.
It is very helpful for me. Thank you.
I wonder that how you make jni_prefix.patch file for changing android package name.
I'm very interested in making build for another webrtc version(m120).
But too many files in webrtc was changed. so jni_prefix.patch doesn't  be affected in other version(m120).
I want to learn how you make jni_prefix.patch file and I'll make another jni_prefix.patch and share it.
Thank you so much. Please give me your thought 👍

There's not really much to explain here, as there isn't a process to making the prefix patch, just trial and error until everything is prefixed. The current jni_prefix patch is now on m125, but how to update it for another version is completely up to how the upstream changes between versions. Your best bet is to look at the current prefix patch and figure out how to adapt it for whichever version you need.


DEA Land Cover  notebook suite

Proposed changes
A collection of notebooks showing how to access and use the new DEA Land Cover product.
This contains 4 notebooks and one supplementary scripts file:

DEA_Land_Cover.ipynb (in DEA_datasets)
Animated_Land_Cover_plots.ipynb (in Frequently_used_code)
land_cover_change_mapping.ipynb (in Scientific_workflows/Land_Cover)
land_cover_pixel_drill.ipynb (in Scientific_workflows/Land_Cover)
land_cover.py (in Tools/dea_tools)

Checklist

[x] Notebook created using the DEA-notebooks template
[x] Remove any unused Python packages from Load packages
[x] Remove any unused/empty code cells
[x] Remove any guidance cells (e.g. General advice)
[x] Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
[x] Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
[x] Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
[x] Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
[x] If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with

Hey @bellemae, @margaretharrison, @Kooie-cate, this is incredible! Can't express how excited I am to get this content into the repo - I think it will be hugely useful for helping new users get started quickly with the data. Some feedback for each notebook below - they don't need many changes at all, and most of the stuff below is just minor consistency stuff and some ideas for future additions. I've also made some minor edits to the notebooks and scripts themselves (mainly PEP8/style guide stuff).

Introduction to DEA Land Cover
This is such a great introductory notebook - does a fantastic job of introducing the main features of the data and how to load/visualise it. Amazing! Only the tiniest bit of feedback:

Land cover is the observed physical cover on the Earth's surface - any way we can use a definition of land cover that doesn't include the word "cover"? Same thing in the following notebooks

Plotting animations of land cover

I love the stacked plot + animation! The only thing that's missing (as noted in the notebook) is being able to have a colour as well as the stacked plot, which does potentially make the colours a little harder to interpret. No need to do it for this PR, but in the future a nice compromise could be to use the stacked plot itself as a legend by plotting some data labels on the right hand side. That way the animations would be self-describing to anyone who isn't familiar with the colour scheme. E.g. something like this:

(the labels would jump around and update for each frame in the animation; you might need to only show the labels where a class is e.g. > 5% of the total in a given year so they don't overlap)

Could the Why is my animation producing an error or plotting no data? be removed if we had a slightly more detailed error message? Deliberately raising an error inside the notebook currently causes the notebook to bail before the end, and might eventually cause further issues if we expand our automated tests to cover this notebook. E.g. perhaps wording like this might make it clearer:

"Could not automatically determine colour scheme from array name 'ntv_only'. Please change the name of the array (e.g. da.rename(...)) to match one of the following options: 'level3', 'level3_change_colour_scheme', 'level3_change_colour_bar', 'lifeform_veg_cat_l4a', 'canopyco_veg_cat_l4d', 'waterstt_wat_cat_l4a', 'watersea_veg_cat_l4a_au', 'inttidal_wat_cat_l4a', 'waterper_wat_cat_l4d_au', 'baregrad_phy_cat_l4d_au', 'level4', or 'level4_colourbar_labels'. Alternatively, use the 'layer' parameter in lc_animation to manually specify the layer colour scheme: lc_animation(..., layer='level3', ...)."

(not sure whether the best place for this would be in the underlying lc_colourmap func, or by catching the assertion error using try/except and providing the more explanatory one instead inside lc_animation)

DEA Land Cover pixel drill
DEA Land Cover change mapping

Both super nice - particularly love the "land cover history" plots! Biggest comment here: I think they might be too nice to resign to the "Scientific workflows" folder. That folder is in some ways is where more complex experimental code goes to die (it's not event synced to the DEA Sandbox because we don't offer any promise that any of the code in there will work). I think both notebooks would be better placed in Frequently_used_code (in their current state), or even Real_world_examples if you wanted to add a little bit more of an imaginary case study flavour to them (e.g. how the pixel drill or land cover change maps could be used to answer a real-world problem).

If you do decide to promote these to one of those folders, they might need some minor tweaks to match the format of the other notebooks (changing file names from lower case to sentence case, removing the "1.", "2." etc in the pixel drill headers).

land_cover.py
Any chance we could rename this to landcover.py? (It's the only one there that uses the underscore at the moment, and it'd be nice to keep things consistent)

In Notebook Animations_Land_Cover_plots.ipynb, the program halted in Cell 10, with following error message:
"---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
/tmp/ipykernel_201/820435371.py in
15
16 # Generate plot
---> 17 lc_animation(xr_veg, file_name=file_name, colour_bar=True)
~/dev/dea-notebooks/Tools/dea_tools/land_cover.py in lc_animation(da, file_name, layer, stacked_plot, colour_bar, animation_interval, width_pixels, dpi, font_size, label_ax)
530
531     # Create colour map and normalisation for specified lc layer
--> 532     layer_cmap, layer_norm, cb_labels, cb_ticks = lc_colourmap(
533         layer, colour_bar=True)
534
~/dev/dea-notebooks/Tools/dea_tools/land_cover.py in lc_colourmap(colour_scheme, colour_bar)
331     colour_scheme = colour_scheme.lower()
332     # Ensure a valid colour scheme was requested
--> 333     assert (colour_scheme in lc_colours.keys(
334     )), f'colour scheme must be one of [{lc_colours.keys()}] (got "{colour_scheme}")'
335
AssertionError: colour scheme must be one of [dict_keys(['level3', 'level3_change_colour_scheme', 'level3_change_colour_bar', 'lifeform_veg_cat_l4a', 'canopyco_veg_cat_l4d', 'waterstt_wat_cat_l4a', 'watersea_veg_cat_l4a_au', 'inttidal_wat_cat_l4a', 'waterper_wat_cat_l4d_au', 'baregrad_phy_cat_l4d_au', 'level4', 'level4_colourbar_labels'])] (got "ntv_only")"
To fix the error, you can change the name of the xarray.DataArray to "level3".
Alternatively, you can use the layer setting to specify the layer. The below example demonstrates how to use the layer argument.

@robbibt @BexDunn @pjt554 I think we've now addressed all items raised.

moved and renamed notebooks
renamed .py file to remove _
reworded land cover definition
removed error example in animation notebook and replaced with helpful error message.

note, will leave the additional labels on the stacked plot for a feature enhancement


JBPM-4646 - Case management - extended ProcessContext to allow access…

… to case data and assignments
depends on https://github.com/droolsjbpm/droolsjbpm-knowledge/pull/176

+1


The following ArgumentError was thrown building DropdownButton(dirty, dependencies: flutter: [_LocalizationsScope-[GlobalKey#5a1bc], Directionality, _InheritedTheme], state: flutter: _DropdownButtonState#b0432): flutter: Invalid argument(s)

Steps to Reproduce

I am trying to implement a DropDownButton and facing an issue when i set isDense Property to true.

Thanks for the report. I have a fix working its way through the system (#33474), but if you need a workaround before then, you can manually set the fontSize the style you pass to the DropdownButton:
        child: DropdownButton<String>(
          underline: Container(),
          style: TextStyle(color: Colors.colorTextDark, fontSize: 16.0),

or better yet, base it off the default text style:
        child: DropdownButton<String>(
          underline: Container(),
          style: DefaultTextStyle.of(context).style.merge(TextStyle(color: Colors.colorTextDark)),


Wfm card list

wfm card list, with tidy up changes according Blandine suggestions

This directive does not work in the project since its still called Teleopti-card there

ok, I will update our project

Thank you :)
I am also a but curious about line 17 in cardlist.scss
"adsfasdf"
Can i remove this?

miss input, if it doesnt cost your much time,please help me to remove that thanks

Would it also be alright if i make the chevron icon rotate like in the accordion? to maintain that behaviour for expanding items?

yes. Actually we have rotated the icon in our project, but not in styleguide. sorry about that.
it will be great if style guide can be updated automatically...:)

Well its really the other way around, the project uses whats written in the styleguide so the project is "updated automaticaly" when you change the version number of the styleguide :+1:
If i add a rotation in the styleguide, will it conflict with the one in the project?

it wont conflict with the one in the project.

Ok, then i will commit that :)
Thank you

Would it be possible to not use md-content in the template? it has a big margin, solid white background and a high z-index that overlaps some elements.

I have check the md-content element, but seems it doesnt get those issue.
by the way, I have updated the card list with following features so that we keep the same behavior as how it is in our project:
1.support multi selected
2.remove max-height of the wfm-card-container
3.add hover and transition style on unselected card.


Allow url override for login, signup and unlink

Url attribute in opts was useless. Now used to override config if set.

Thanks.


V0.12.0.x block value/mn payment fixes

fix block value decrease calculation (was not accurate imo)
reschedule block value decrease and mn payments (otherwise we won't be able to run on mainnet)
fix comments (%% in block decrease)

Given the fact that we're going to reduce the block reward and use super blocks for the payout, I think it's a better idea just to go from 0% payments to 10% in 1 month rather than this slow progression. Also, I think it would be also much better for the coin in the short term to have the funds to work with. I was going to propose this to the community soon, which was why the code is broken atm. Can you change it to reducing the block reward size by 10% at block X and enabling super blocks?

We're still looking into this, I'm going to close this PR for now.


As Kraken Latte, I would like the Quest Reward equip automation to also handle equipment looted from NPCs

This should go out with the 2.0.8 update. However, quest rewards are the priority. I must get that working before adding support for loot drops.


Extent Report html not generated

Hi all
I am struggling to get the report to generate I have followed the documentation and no getting any build or runtime errors running for the automated test case, however Extent html report does not generate.
Installed version of Extent report nuget package is v4.1.0 and framework on the solution is .Net framework 4.7.2

add
extent.flush();
in teardown section