I would like to add props of

First of all I am Japanese and I am poor at English.
I am writing a sentence by specifying translation software. I am sorry if it does not pass
Please allow pushState when js file and query parameters in pages directory suffered

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
<Link { ...object } pushState>text</Link>

I want you to be pushState instead of replaceState when describing as described above
Steps to Reproduce (for bugs)
Precondition
/a/b/?query1=1 => express rewrite => /page1/?query=1&query=2

go to /
go to /page1/?query1=1 pushState
go to /a/b/?query1=1 replaceState

Context
An unintended replaceState occurred on the product page of EC site.
I want to return to the page in the order that it should be browser back
In particular
https://github.com/zeit/next.js/blob/canary/lib/router/router.js#L161
if (!this.urlIsNew(pathname, query))

Is it possible to add an option to switch whether to use pushState?
My Environment

Tech
Version

next
4.1.0

node
8.9.4

OS
mac high sierra

browser
all

Can you please expand on what you want ?
In any case, you can use Router.push (pushState) and Router.replace (replaceState) to navigate and Router.back() to navigate back


Question about 'kidney_align.draw_3D'

What a great tool for spatial slides alignment! :-)
I have met an error when I used draw_3D function to plot cell type alignment between two slides, an error occurred:
"TypeError: draw_lines() takes from 4 to 6 positional arguments but 7 were given."
Hope for your reply. Thanks!

Thanks for your interest and feedback !
I can not reproduce your error in my computer (with latest version of SLAT). Could you update to the latest version (0.2.1) following our tutorial. If updating can not solve your error, counld you please provide your codes?
Best!
Chen-Rui

We close this issue because key information is missing. If you need more help, please open it again.

Hi, @xiachenrui
After testing, this bug is caused by a function parameter error in version 0.2.1 on pypi, which is not reported if installed version 0.2.2 using the github repository.
Also, scslat 0.2.2 requires scipy<1.9,>1.3 seems to be an unnecessary limitation, I run scslat on scipy==1.11.4 and everything works fine.
Also, some of the arguments to the functions in the tutorial don't seem to work correctly when the version of scslat is 0.2.2. For example:
kidney_align = match_3D_celltype(adata1_df, adata2_df, matching, meta='celltype', highlight_celltype = [[''],['']],
                                 subsample_size=300, highlight_line = ['blue'], scale_coordinate = True )

ValueError: ['blue'] is not a valid value for colour

Sincerely,
Zehua

Many thanks @Starlitnightly , I have gotten the same issue with v0.2.1 and solved it by updating to v0.2.2.


Add weights compression to Florence-2 notebook

@l-bat  are you sure that it gives any speedup? Becuase florence2 is small model <1b parameters, I do not think that it can get any benifit from weight compession.

@eaidova, you're right; the speedup is quite small at 1.07x. However, we can still benefit from compressing the weights to 4 bits:

Model
FP16, Mb
U4, Mb
Compression rate

decoder
185
67
2.8

decoder_with_past
172
64
2.7

encoder
83
24
3.5

image_embedding
175
50
3.5

text_embedding
76
38
2

With PTQ, we can achieve a 1.13x speedup, but I think this isn’t sufficient to justify adding quantization in this notebook


HLZ Touchdown Points has validation error with Input Airframe Specification Table

HLZ Touchdown Points has validation error with Input Airframe Specification Table. If you open the tool in Pro (Final) the default Airframe selection comes from some previous run of the tool with an input Aircraft_Specification table (which doesn't exist).

But if we add a custom table the Input Airframe Specification Table has a validation error:

The error is misleading because the table DOES exist (just browsed to it), and why it is not supported is unknown. The problem might have something to do with the validation in one of the component tools in the HLZ model.
This is a problem for FedGC demo and is highest priority. Assigning to myself for now, but notifying @nfeuerstein

Testing this one out in ArcGIS Desktop 10.3.1 and ArcGIS Pro 1.2.

Created table in folder: .\Test_SGT_Issue_309\test_issue_309.gdb\test_issue_309.gdb
Open HLZ Touchdown Points in ArcMap.
point to double-named folder/gdb and it fails.

Created second table: .\Test_SGT_Issue_309\test_issue_309\test_issue_309.gdb
Open table in tool and it works.

OK. so the problem here is that there is a file geodatabase in a folder with the same name, including the ".gdb". Let's try it in a system tool, say Copy Rows:
6. Try to open the "bad" path, and it fails too.

But the "good" path works fine:

So in the end it seems that this is a data error with the path. Make sure you don't have a folder with a *.gdb extension.


fix: Don't publish diagnostics in crates.io or sysroot files

Fixes https://github.com/rust-analyzer/rust-analyzer/issues/9766
bors r+

This means we still compute them. It might be better to not do that at all.


Circular Dependency Issue with useNitroApp Export in nuxt-og-image

I encountered a circular dependency issue while working with the nuxt-og-image module in my Nuxt project.  The built projct is getting a runtime error.
Build Warning:
Export "useNitroApp" of module<EMAIL_ADDRESS>was reexported through module "virtual:#imports" while both modules are dependencies of each other and will end up in different chunks by current Rollup settings. This scenario is not well supported at the moment as it will produce a circular dependency between chunks and will likely lead to broken execution order.
Node.js v20.11.1
Environment:
Nuxt Version: 3.11 nightly
nuxt-og-image Version: 3.0.0-rc.45
nitropack-nightly Version: 2.10.0-28509108.fdf7e70
Node Version: 20.11.1
Error:
node:internal/modules/esm/resolve:853
throw new ERR_MODULE_NOT_FOUND(packageName, fileURLToPath(base), null);
^
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'nitropack' imported from /app/.output/server/index.mjs
at packageResolve (node:internal/modules/esm/resolve:853:9)
at moduleResolve (node:internal/modules/esm/resolve:910:20)
at defaultResolve (node:internal/modules/esm/resolve:1130:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:396:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:365:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:240:38)
at ModuleWrap. (node:internal/modules/esm/module_job:85:39)
at link (node:internal/modules/esm/module_job:84:36) {
code: 'ERR_MODULE_NOT_FOUND'
}
Node.js v20.11.1
Expected Behavior:
The application should correctly resolve and load nitropack as a dependency without throwing runtime errors, allowing the nuxt-og-image module to function as intended.
Actual Behavior:
A runtime error is thrown indicating that the nitropack module cannot be found, leading to a failure in the application's execution.

I just got this error again using:
"nuxt-og-image": "^3.0.0-rc.66",
"nuxt": "^3.13.1",
"vue": "^3.5.0",

Please ignore this useNitroApp import issue for now, currently Nuxt OG Image uses useNitroApp from nitropack/runtime but some other dependencies use nitropack/runtime/app which is deprecated.
It should hopefully be resolved in the Nitro major.


Prep for doc warden updates

At some point we may want to go through the exclusions in .docsettings.yml and remove the ones that are no longer valid.

/check-enforcer reset

/check-enforcer evaluate


Bumped all sub-crates

Preparation to do a release for all sub-crates.
Initially I was thinking that we could get away with only bumping individual crates as changes are made to them, but since the crates refer to each other with { version = "..." path = "..." }, I think this forces us to always bump all crate versions together.
Also, you might notice that two crates moved to 0.2.0 instead of 0.1.2. The reason for this is I'm trying very hard to follow SemVer. I'm using a cargo tool called cargo-semver-checks), and it's showing that I changed some public facing functions and therefore requires a minor version bump. This doesn't apply to the two other crates, so I instead just bumped their patch versions. Also this is a bit of an aside, but what should the version of the repo release?
And just as a sanity check, does specifying version with path give us anything? It's forcing all deps to be updated together when we make a change in just one.

We also need to update th change log


v5.0.0 was not actually released

This repository lists the latest version as being v5.0.0, but that version does not exist on npm.

Now it exists. But no tag in repo, and no release page... :-(

Scripts to update the readme with a release date and the push the release tags were run too early and too late. Sorry about that. Github/release/npm should be aligned now.
In general we'd recommend treating npm as the source of truth on the release.


Reproducing issue reported in https://github.com/intuit/karate/issues…

don't merge - just reproducing my comment here: https://github.com/intuit/karate/issues/1452#issuecomment-767943021
@ptrthomas  the second unit test in FeatureRuntimeTest.java calling test-with-js-function-2.feature is sufficient to reproduce. This is the error:
20:33:24.776 [pool-1-thread-2] ERROR com.intuit.karate - scenario [run] failed
Multi threaded access requested by thread Thread[pool-1-thread-2,5,main] but is not allowed for language(s) js.
20:33:24.797 [pool-1-thread-2] ERROR com.intuit.karate - scenario [run] failed
Multi threaded access requested by thread Thread[pool-1-thread-2,5,main] but is not allowed for language(s) js.
20:33:24.822 [pool-1-thread-3] ERROR com.intuit.karate - scenario [run] failed
Multi threaded access requested by thread Thread[pool-1-thread-3,5,main] but is not allowed for language(s) js.
20:33:24.844 [pool-1-thread-1] INFO  com.intuit.karate - [print] test

This is only reproduceable with Scenario Outline with dynamic data as Examples (if we use a static table, not an issue neither for normal scenarios).
If we comment both the following lines from the karate-config.js the issue isn't reproduced anymore.
configUtils: karate.call('classpath:com/intuit/karate/core/karate-config-utils.feature')
 configUtilsJs: {
      //someFun: function () {
      //  return 'hello world'
      //}
    },

My gut tells me it's related to the fact that we run the background section and then reattach all the variables from there into each iteration of the ScenarioIteration.

@joelpramos I think I fixed it, one of those rare cases where I'm not 100% sure how :S but hey.
fortunately didn't take much time, commented out that logic when background != null and saw it pass, then tried this

closing


VectorGeoJSON layers display

Hello.
I have an issue when representing VectorGeoJSON layers.
All the layers display with the same style
I have tried setting a value for the Styles property without any success.
This is the syntax I am using for the Styles property upon layer creation in the C# code
Layer vectorLayer1 = new Layer
{
    SourceType = SourceType.VectorGeoJson,
    Url = "https://localhost:8701/layers/1",
    Title = "Layer1",
    Visibility = true,
    Opacity = 1,
    Styles = "style:{'fill-color': 'darkgray'}"
};

I think the Styles string I am using might not be correct. This is because no matter what I type there, it will always display the same: blue border surrounding and white background.
What would be the format for that string?
I have not seen using this property being used for vectorGeoJSON layers in your application, hence the question.
In case this is not the right way to set the layer style, what would be the correct way to customize layer style?
Thanks in advance.
Best regards

The Styles property is for tile layers only. To apply a style for vector layers you can set style using Style property and assigning a StyleOptions object: Style="@(new StyleOptions() { Stroke = new StyleOptions.StrokeOptions { Color = "red", Width = 3 }})". A full example is in GeoJsonDemo.razor
or using the FlatStyle property with a Dictionary of styles (documented in openlayers API). You find an example in VectorLayersDemo,.razor.
Another option would be to implement a call back method for dynamic styles but this works only in WASM blazor scenarios.

Thank you.


Unable to handle KafkaException on commit

Description
I'm experiencing an issue where manually committing is throwing an exception (due to rebalance in progress) however I am unable to handle this exception which is causing the host application to crash
Confluent.Kafka Version: <IP_ADDRESS>
Kafka Version: confluentinc/cp-kafka:5.0.1 docker image
How to reproduce
This is the code that I have for doing the commit
void CommitTimerCallback(object state)
{
    try
    {
        IDictionary<IConsumer<TKey, TValue>, List<TopicPartitionOffset>> outstandingCommits = _outstandingCommits;

        foreach (var consumerOffsets in outstandingCommits)
               consumerOffsets.Key.Commit(consumerOffsets.Value);
    }
    catch (Exception ex)
    {
        _logger.Error(ex, "Error while committing kafka offsets");
    }
}

I'm able to catch the exception by using the UnhadledException event as follows
AppDomain.CurrentDomain.UnhandledException += (sender, eventArgs) =>
 {
    //log exception
};

and I get the this stack trace
Confluent.Kafka.KafkaException: Broker: Group rebalance in progress
at Confluent.Kafka.Impl.SafeKafkaHandle.Commit(IEnumerable`1 offsets)
at Confluent.Kafka.Consumer`2.Commit(IEnumerable`1 offsets)
at Polystream.Teleminion.Plugins.Kafka.KafkaConsumer`2.CommitTimerCallback(Object state)

It looks like you're trying to replicate functionality provided by Consumer.StoreOffsets, Config.EnableAutoOffsetStore=false, Config.EnableAutoCommit=true - you might want to consider that approach instead, which will work around this issue.
Commit is quite simple and completely synchronous - i can't think of any reason for what you're observing to be occurring. Marking this as enhancement to make an integration test to replicate.


Prefab Geometry vs. Instanced Geometry

Hello 😄 What is the difference between prefab geometry in three-bas and instanced geometry in three.js itself? They seem kinda similar to me, but I'm probably missing something basic.
I'm sorry, I know this is not really an issue. Is there a better place to ask these questions? Thank you ❤

Asking questions here is fine, at least for now.
When I first created this extension, THREE.js instanced geometries didn't exist (or I didn't know about them). Instanced geometries rely on a WebGL extension that changes how vertex attributes are used. This extension is fairly widely supported, but may be missing on some devices / browsers.
With instanced geometries, the default geometry attributes (position, normal, uv) are stored once (this defines the instance). Additional custom attributes (like a position / rotation / scale offset) are then stored once per instance.
With the prefab geometry, the default geometry attributes are simply duplicated, and custom attributes are stored once per vertex.
Instanced geometries are substantially more memory efficient, but you lose some flexibility; you can't have per-vertex variations for custom attributes, or per-instance variations for default attributes.
I recently added InstancedPrefabBufferGeometry, which which has a similar API as PrefabBufferGeometry, but uses the instanced geometry under the hood. See this example.

Yes, all three-bas materials should work with InstancedBufferGeometry (or any other buffer geometry). As you can see in the source, InstancedPrefabBufferGeometry is a thin wrapper that only copies the api from my other geometries.


 Right now even if you use v-if to not render computed data it is still being retrieved.
#247 - Example of  failing test

I do not know if this can be fixed if the current API is maintained. I managed to get an asyncComputed version that is lazy like computed but it doesn't provide the onCancel callback:
export function asyncComputed<T>(
  evaluationCallback: () => T | Promise<T>,
  initialState?: T,
  evaluatingRef?: Ref<boolean>,
): Ref<T> {
  return customRef<T>((track: Fn, trigger: Fn) => {
    let counter = 0
    let current = initialState

    const tracker = computed(() => {
      counter++
      const counterAtBeginning = counter

      // Defer initial setting of `evaluating` ref
      // to avoid having it as a dependency
      if (evaluatingRef) {
        Promise.resolve().then(() => {
          evaluatingRef.value = true
        })
      }

      Promise.resolve(evaluationCallback()).then((result) => {
        if (counterAtBeginning === counter)
          current = result
      }).finally(() => {
        if (evaluatingRef)
          evaluatingRef.value = false
        trigger()
      })

      return counter
    })

    return {
      get() {
        track()
        // eslint-disable-next-line no-unused-expressions
        tracker.value
        return current as T
      },
      set() {},
    }
  })
}

I do not know if this can be fixed if the current API is maintained. I managed to get an asyncComputed version that is lazy like computed but it doesn't provide the onCancel callback:
export function asyncComputed<T>(
  evaluationCallback: () => T | Promise<T>,
  initialState?: T,
  evaluatingRef?: Ref<boolean>,
): Ref<T> {
  return customRef<T>((track: Fn, trigger: Fn) => {
    let counter = 0
    let current = initialState

    const tracker = computed(() => {
      counter++
      const counterAtBeginning = counter

      // Defer initial setting of `evaluating` ref
      // to avoid having it as a dependency
      if (evaluatingRef) {
        Promise.resolve().then(() => {
          evaluatingRef.value = true
        })
      }

      Promise.resolve(evaluationCallback()).then((result) => {
        if (counterAtBeginning === counter)
          current = result
      }).finally(() => {
        if (evaluatingRef)
          evaluatingRef.value = false
        trigger()
      })

      return counter
    })

    return {
      get() {
        track()
        // eslint-disable-next-line no-unused-expressions
        tracker.value
        return current as T
      },
      set() {},
    }
  })
}

There was an issue about this in https://github.com/vuejs/rfcs/issues/163. If we would have a invalidableComputed helper that provides onInvalidate the above implementation could be extended to support the current API.
I tried using computed + watch to create this helper, but the watch ends up triggering the computed. watchEffect is not lazy so it will also trigger it. Maybe there is a way to do this but I couldn't find it... invalidableComputed could be a great addition to vueuse if there is a way to do it.
Just an idea, but one possible option is to offer the above version as asyncComputed without the onCancel callback, and keep the current implementation with another name. Maybe something like asyncRef?

The behaviour has already described as a caveat in the doc. I am not sure if it makes sense to have asyncComputed lazy as in that way you will always get the null on the first access (and need to wait for the promise get resolved from that time).

Re: invalidableComputed

With https://github.com/vuejs/rfcs/pull/212 (likely in Vue 3.1), it will expose effect to vue and we can make invalidableComputed easily with it. However, that would be a Vue 3 only thing (Vue 2 does not have effect).

Nice! I didn't know that effect was going to be exposed 🙌🏼
Maybe at one point, there could be a lazy option. I agree that with asyncComputed the current behavior should be the default.

Sorry, somehow missed caveat section in the docs.
I fixed my use case by extracting part of template that was hidden using v-if to separate component and moving asyncComputed there.
Should I close this issue or lazy option is being considered? It would be useful in some cases.

@Demivan Sure, let's have the lazy option. Do you mind to create a PR?

Sure, I'll work on it.


feat: check for exsisting downloads on download page mount

Description
Fixes the below issue by checking if there is an existing snap shot of the lesson (and therefore a download) on page mount.
Fixes:
https://www.notion.so/oaknationalacademy/Return-To-Downloads-ebbb8afc900148a79e102da9a9510c63

:tada: This PR is included in version 1.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update legacy docker.io links

docker.io now redirects to docker.com, and index.docker.io redirects to registry.hub.docker.com.
This patch reflects these changes.
The only non-trivial change is in the Links section, I tried my best to fix the obsolete links with their modern replacements.

Thanks!


Create Address Module Controller

Full Crud for Address
Ensure checks are put in place for proper response if the ID for the address is invalid or no id is provided.

fixed in commit 75baf2e186b82f3d232d72892ce43e1f71aa6adc


Release: decK 1.25.0

Description

deck 1.25 release version bump + nav file.
Add the new deck file render command

No other doc impacts, according to the changelog.
Testing instructions
Netlify link:
Checklist

[x] Review label added
[x] PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

Not fixing the last vale error, it's coming from the source file.


Could not get available persian subtitle

simply I'm doing the following command in cli
youtube_transcript_api LKvjIsyYng8 --languages fa
However I cant get the language I want that is available in subtitles.

That would probably be a problem with the captions. If the caption is not
available for a particular language, it can't be fetched along.
On Tue, May 7, 2019 at 1:10 AM hosnas<EMAIL_ADDRESS>wrote:

simply I'm doing the following command in cli
youtube_transcript_api LKvjIsyYng8 --languages fa
However I cant get the language I want.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jdepoix/youtube-transcript-api/issues/12, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AG7KQDXCRFQ24DKYUE6LQOTPUCCSRANCNFSM4HLC2JMA
.

@utkarshdubey  as I said, the caption is available. But its not being fetched.

Could you give me more information or the Tracebacks if you received any
errors?
On Tue, May 7, 2019 at 6:21 AM hosnas<EMAIL_ADDRESS>wrote:

@utkarshdubey https://github.com/utkarshdubey as I said, the caption is
available. But its not being fetched.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jdepoix/youtube-transcript-api/issues/12#issuecomment-489863845,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG7KQDQ2Y6U4QFKD24D6UD3PUDHAFANCNFSM4HLC2JMA
.

@utkarshdubey  the only error I'm getting is this:
ERROR:youtube_transcript_api._api:Could not get the transcript for the video https://www.youtube.com/watch?v=LKvjIsyYng8! Most likely subtitles have been disabled by the uploader or the video is no longer available. {}
Although its clearly not correct. cause I can pick fa language from list of subtitles by clicking on  persian

@hosnas I can not replicate this error.
Running youtube_transcript_api LKvjIsyYng8 --languages fa with the current version (0.1.4) prints the subtitles without errors, using python 2 and 3.
Could you please provide more information on the version of youtube-transcript-api and the version of python you are using?

@jdepoix very wierd. I changed my location in youtube pannel and was able to get the subtitle.

@hosnas so would you consider your problem to be solved, or should we investigate further?

@jdepoix  yes im considering it solved


Fix(Curriculum): Replaced curved backticks with straight backticks Eng blocks 1 to 4

I’ve replaced all curved backticks with straight ones to ensure the formatting aligns with fCC standards. This PR is for the B1 curriculum. There's another one for A2: https://github.com/freeCodeCamp/freeCodeCamp/pull/57568
Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Like I said in the other PR, you could maybe also check for “”

@moT01 and @ilenia-magoni I think I've fixed all curved double quotes from A2 and B1.


Doomfist Seismic Slam floor clip bug

Created by: UgandanF16
Doom's indicator slam sometimes will clip you into the ground and make you even fall off the map, similar to the 2017 bug, it happens when u indicator slam into a slanted ground structure, such as ramps, some stairs. So far it has happened to me on Lijiang tower and Havana. https://streamable.com/ya5r3c https://streamable.com/96k8o7 https://streamable.com/e8cjt8

moved from ow1_emulator_backup#594

Created by: MaxwellJung
Might be duplicate of MaxwellJung/ow1_emulator#600

mentioned in merge request ow1_emulator_backup!175

Created by: UgandanF16

Might be duplicate of MaxwellJung/ow1_emulator#600

no, because that is through a wall, but it is very similar, slam just has clip issues.


Support bcrypt hashing method?

Not sure how can I use bcrypt in stead of pbkdf2

Hi @longseespace
It is not currently implemented, but should be trivial to add: https://github.com/ericelliott/credential/blob/master/credential.js#L77-L79
A PR with your work would sure be much appreciated.
Feel free to reopen, if not sufficiently answered.


Need to documentation that Paloalto AMI are not supported IMDSv2

Documentation link
https://github.com/PaloAltoNetworks/AWS-GWLB-VMSeries/tree/main/terraform/README.md
Describe the problem
I think add to Prerequisites that paloalto ami are needs IMDSv1.
instance are can't read user-data of the aws instance parameters when first boot if restricted only allowed IMDSv2
(for example, SCP of the AWS organization)
Suggested fix

Make a sure IMDS settings

Paloalto AMI are need IMDSv1 for get user-data
aws_instance.http_tokens=optional

Does Palo Alto now support IMDSv2 via https://docs.paloaltonetworks.com/plugins/vm-series-and-panorama-plugins-release-notes/vm-series-plugin/vm-series-plugin-30/vm-series-plugin-300.html ?
I do not use any PAN products, but I've been tracking this via the IMDSv2 Wall of Shame: https://github.com/SummitRoute/imdsv2_wall_of_shame

@0xdabbad00
Finally, Yes! :)
But there are some limitation.
it's only supported above PAN-OS 10.2.0 version(need to upgrade from other version) and does not yet present on AWS marketplace.

I've tried to remediate using automation script through AWS CLI and it solved the IMDSv1 problem for VM-Series.
Currently I'm using the latest version of PanOS


correction README.md

PR description
Fixed Issue(s)

Changelog

[ ] I thought about the changelog and included a changelog update if required.

@saumyaagrawal2001 to commit this, you will need to signoff the commits. See https://github.com/hyperledger/besu/pull/1460/checks?check_run_id=1344322629

Closed in favor of https://github.com/hyperledger/besu/pull/1574


Icon styles sometimes break down

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected
2.1.2
Issue Description
Sometimes icons break down (Admin panel and Shop)
Preconditions
Nothing
Steps to reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected Result
No broken
Actual Result
Broken
Screenshots

Additional context
It solving after reloading the page.

@plyaskin
As per checking the concern related to the icons breakdown. we will discuss the same with team and we will get back to you for the same.
Thank you.

@plyaskin,
We are aware of this, but we are trying to reproduce the case and haven't been able to pinpoint the issue. It would be great if you could help us here. We think this might be a network issue, such as fonts not downloading properly.

This might be a issue due to failing request, i guess mostly this will happen in local not in live.


Cannot see deploy option

Even after performing all the steps before the section "Create the publish settings file in IIS on Windows Server" I cannot see the "Deploy" option under "Default Web Site" on the IIS Manager settings.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 62c014f3-7ada-66ae-1db4-c59982504159
Version Independent ID: 98041d92-c537-bf0a-9a11-ff50965d2cef
Content: Publish to IIS by importing publish settings - Visual Studio
Content Source: docs/deployment/tutorial-import-publish-settings-iis.md
Product: visual-studio-windows
Technology: vs-ide-deployment
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

As per the article "Web Deployment Agent Service" was running but "Web Management Service" was not running under the services. I had to restart the "Web Deployment Agent Service" and only after that "Web Management Service" started. After doing this I can now see the "Deploy" option.

@chintalpatel89 That is great feedback, thanks. I'll make an edit to the docs to clarify.


Modify resultRepo to adopt a streaming model

Is your feature request related to a problem? Please describe.
Right now, validation result exportation happens at the end of the applicaiton execution. As such, all notices are kept in memory and may potentially consume all of it. This PR work consist in modifying the in memory implementation to adopt a streaming model for notices export.
Describe the solution you'd like
Current JSON exporting already uses a streaming output JsonGenerator. As such, modifications should be minimal. Two leads

Have a new export use case ran regularly during in the main method execution
Have the repository itself pipe calls to its add methods to the exporter object

Both should be explored and this issue updated with the results before proceeding to implementation.
Additional context
https://github.com/MobilityData/gtfs-validator/issues/77

After discussion, the repository should abstract the export process through the use of an internal Exporter member. No specific use case should be used.

After discussion

https://github.com/MobilityData/gtfs-validator/issues/94#issuecomment-607495789
At present, a first attempt to implement the export behavior directly in the add methods could be possible. However, doing so leads us to loose the "single responsability principle " for these add methods.

Note: For now, using a thread to execute a use case to regularly export the notices is not possible.

I suggest we use the Observer pattern from the Design patterns . ValidationResultRepository would be observable, and an exporter object would be the observer. Every time an add method is triggered in ValidationResultRepository, a signal is sent to the exporter object. In this case, ValidationResultRepository methods would not break the "single responsibility principle" because they would only send a signal.

Good catch, Taking a look at this

After discussion (last week), it came up that the Observer API has been deprecated, so the Flow API could be used instead: https://docs.oracle.com/javase/9/docs/api/java/util/concurrent/Flow.Publisher.html

Closing - addressed in v2 architecture

Closing - addressed in v2 architecture


Research :  ValueError: cannot reindex from a duplicate axis

When running the provided BasicQuantBookTemplate.ipynb example in the research docker, the example stops at
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-3-2be348dae713> in <module>
      4
      5 # Gets historical data of indicator
----> 6 bbdf = qb.Indicator(bb, "SPY", 360, Resolution.Daily)
      7
      8 # drop undesired fields

ValueError: cannot reindex from a duplicate axis

Expected Behavior
The example notebook functions
Actual Behavior
The example notebook has a non-recoverable error
Reproducing the Problem

Follow instructions for Research docker installation
Start above example

System Information
MacOS X 10.15.7
Research docker image : ba23f2aa50f9
Checklist

[X] I have completely filled out this template
[X] I have confirmed that this issue exists on the current master branch
[X] I have confirmed that this is not a duplicate issue by searching issues
[X] I have provided detailed steps to reproduce the issue

Is there a difference between the environment used in the research container and the one used on the web?
Just came across this issue and noticed that the line bbdf = qb.Indicator(bb, "SPY", 360, Resolution.Daily) works as expected if run on the web.

No, but because the web IDE has access to QC data storage the issue does not reproduce.

No, but because the web IDE has access to QC data storage the issue does not reproduce.

@C-SELLERS I'm not sure I understand the reason for the issue not being reproducible in the web.
Are saying that there is an error in the SPY data in the Data folder that does not exist in the QC data storage?

Take a look at #4944 which attempted to address this issue.
The bug comes from a sub indicator of the BB being filled forwarded when it runs out of data. But when its filled forwarded the date is the same for those points, and when pandas attempts to place this in a matrix it throws the error about duplicate entries for one index (date)
Locally only the data included in the repo or separately downloaded is available to use. In the cloud it has access to QC's data which is updated daily so there is no need to fill forward.

Thanks @C-SELLERS  for clarifying things!


[client] Support jokers

The deck image that I am currently using for the "default source deck" doesn't include any jokers and so I did not make provision for having optional jokers in the playing decks.   This could be addressed

specifically by just finding joker images of the correct shape and incorporating them into the default source deck in code (there is no requirement that the deck be cut from a single image or using any particular pattern)
more generally by changing the source deck (and at the same time I should consider allowing the source deck to be a user choice)

In working on this I found it was easiest to add jokers to the existing source deck (I could not find good source deck images that included jokers).    So, I narrowed the scope to just adding jokers, not any additional tailoring.
As separate low priority additional work I think we can separate the following.

Support user-defined playing deck templates.   This is relatively easy because the templates are compact metadata (don't include any images).
Support alternate card graphics (source decks, possibly distinguishing the card back from the fronts).   This would be a developer task, by supplying the choices with the game.   End users could not add more art to an existing version of the game.
Support users ability to add card graphics without downloading a new version of the game.   Hard.   Probably out of scope for now.


Neogit no longer respects showUntrackedFiles

Description
Since #722 (specifically f7811cc2024a63e70d0dfcfccda73ac9482c9d6c), Neogit no longer respects showUntrackedFiles in .git/config. Previously, untracked files were not shown if showUntrackedFiles = no, but now they are always shown, irrespective of what this is set to.
Context:
I use git to manage my dotfiles, with the bare repository in the ~/.dotfiles folder, and the worktree at ~. In order to be able to use git from the command-line, I have a shell alias that wraps the git command to add the --git-dir argument.
I also have Neovim set up to export the GIT_DIR environment variable when I am editing my config files, which allows plugins like diffview, gitsigns and Neogit to work correctly. For Neogit specifically, this works great - I am able to stage, commit, push, etc without issue.
However, because the worktree is at ~, I need to be able to ignore untracked files, since every non-configuration file in my home directory is, and should be, untracked. For the git CLI, setting showUntrackedFiles = no does the trick, and before f7811cc2024a63e70d0dfcfccda73ac9482c9d6c, this also worked in Neogit.
Additionally, untracked files are now listed in Neogit individually instead of as directories, which means that now tens of thousands of files are loaded and displayed as untracked, making the status buffer extraordinarily slow - both to load and to navigate.
I have tried to disable the "Untracked files" section using the sections = { untracked = { hidden = false } } config option, but this just hides the section from being displayed - the data is still being loaded. The status page still takes forever to load, where it was close to instant before.
I think either showUntrackedFiles should be respected, or hiding the section should actually stop the data from being loaded. I would prefer showUntrackedFiles, since it would make my neovim config simpler, but either will work. Perhaps even an analogous config option to showUntrackedFiles, where you can specify whether to show nothing (git's no), files and root directories (git's normal - git's default) or all files in all directories (git's all - Neogit's new default).
Neovim version
NVIM v0.10.0-dev-882+gd7ae9ae3e5
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Operating system and version
Arch Linux
Steps to reproduce

Set status.showUntrackedFiles = no in a git repository (git config status.showUntrackedFiles no)
Add untracked files
Open the Neogit status buffer in that repository

Expected behavior
Untracked files should not be listed under "Untracked files".
Actual behavior
Untracked files are listed under "Untracked files".
Minimal config
-- N/A, no special config necessary

Thanks for the heads up - you're right, of course. Should be working now :)


Windows 11 23H2 - No matching Appx list file found for build Unknown Version

Expected Behavior
When you select the Enable app removal button it launches a window to select the apps you want to remove.
Current Behavior
When I click the select button I get an error that says
WARNING: No matching Appx list file found for build Unknown Version
Steps to Reproduce (for bugs)

Imported ISO from Volume License site, shows as
Edition: Windows 11 Pro
Arch: x64
Build: 10.0.22621.3155
Patch Level: 3155
Languages: en-US
Index: 5
Version: Unknown Version
Clicked on App Removal Tab
Checked box for Enable App Removal
Click Select button and get error message.

Context
Brand new version of WimWitch installed on a Fresh Windows 11 install.
Your Environment

Module version used: 4.0.1 version of the module installed
Operating System and PowerShell version: Running Windows 11 23H2 Volume License with PowerShell version 5.1.22621.2506

I spun up a Windows 10 VM and I get the same error when using the recently download ISO from the Volume License Center.

Seeing that this is still Open it's still being worked on but figured I'd just add my note that I'm in the same boat.

I am also having the same issue.  The version reported on the 'Source WIM' tab is coming back with 'Unknown Version', which is causing App Removal to fail because it won't resolve to one of the available txt files in "C:\Program Files\WindowsPowerShell\Modules\WimWitchFK\4.0.1\Private\Assets".  Copying appxWin11_23H2.txt and renaming it to appxWin11_Unknown Version.txt is a workaround.

@JasonCioffi thanks I will test that on Friday when I go back to the office.

@JasonCioffi this worked for me I was able to get a new install.wim setup. Hopefully it will be fixed in newer version but good for now.

@JasonCioffi , @seantdavidson I have PR #29 to fix this, just waiting for it to be merged.

@dan-hughes , I applied your changes from PR #29 into my copy of WWFunctions.ps1.
The Source Wim tab is reporting the ISO I downloaded today with a description of "Windows 11, version 23H2 (updated Mar 2024) x64 English" as 22H2.  Is this correct?
In addition, my iso and DotNet imports are applying '22H2' to the file path.  This is the same behavior I was seeing with v10.0.2261.3296.

@JasonCioffi, build 22621 is 22H2 according to this.

Any ideas on when a new version will be coming out?  I am also having the same issue with the March 2024 VLSC Windows 11 ISO reporting as "Unknown Version" in WIM Witch 4.01.  This then prevents the App Removal process from working as others above have reported.

Having the same issue on v4.0.1 and March 2024 Win 11 23H2 Enterprise from VLSC.

There's an on going issue with labelling the release in the UI based on the build number from the WIM. Initially caused by the Windows 10 and 11 having a build that started with the same build number causing issue. So I changed it to hard coded build numbers in 4.x which Server is not in. I'm looking into either just adding all the build numbers from wikipedia into the module. Or setting up a Github action to scrape wikipedia weekly to generate a JSON file of all build numbers for Win 10, 11 and Server and then calling that in the module. Not sure which way to go as of yet.

Does anyone know the revision numbers on the 22621 build where the changeover happens? Or are MS still pumping out WIM's with incorrect versions?
E.g. does a 22621.3000 = 23H2 and 22H2 = 22621.2000?

This is directly from the Install.Wim from the 23H2 ISO I downloaded yesterday:

Let me grab the latest 22H2 ISO and see how it identifies.

Hmm, all I can think of right now is ignoring 22H2 and defaulting the 22621 build to 23H2 so the rest of it will work until MS fix the WIM's.

I'm thinking of just adding a manual drop down to select the Feature Update version (e.g. 21H2, 22H2, 23H2 etc) at least in the short term while I figure out a way to reliably match the WIM build numbers.

I have a new download of Win 11 23H2 with April 2024 updates and it shows as 22H2 Build.

I'm assuming if you install, the OS will show 23H2?
Taking your idea, if the W11 22H2/23H2 case hits then use your dropdown idea otherwise fill in automatically everything is correct?

@alaurie The menu idea sounds like the best option. I doubt M$ will ever fix this.

@CheezWizTN @alaurie I had a ticket with Microsoft about this issue, it is by design that the 23H2 ISO WIM shows the 22H2 build number.  They said it is because it shares a codebase.  They also stated this is the same behavior as seen in the 21H2 and 22H2 ISOs for Windows 10. So this is likely something that won't be auto-detectable going forward and will need the menu as @alaurie  mentioned creating.

Good afternoon. Any update on getting this to work with current feature release?

Any update on this issue?


Test modules structure refactoring

Now all source code is being compiled even without -Ptests profile.
What this PR includes:

Profile tests renamed to itest (to keep consistent with other hawkular projects)
All integration tests renamed to *ITest.java
Profile itest is defined in separate poms not in parent.
Test artifacts can define unit tests and integration tests.
Introduced tests-parent-pom
Mock server moved to the tests-common

@pavolloffay Could you explain the issue you are solving in more detail, as not currently clear.
At present, the integration tests are only compiled when the 'tests' profile is specified.
Why do you want to include unit tests in the separate tests structure? Would it not be better to locate the unit tests with the component they are testing?

This PR would allow:

integration test are compiled with default build (so the whole code base is compiled with default build)
run only integration tests (mvn install -Pitest in tests directory)
it is possible to define unit tests in integration test which are executed with default build (possible use case: unit tests for testing instrumentation test framework)
cleaner project structure

@pavolloffay LGTM :+1:
Hopefully the test structure will be further simplified when the instrumentation tests are done through example applications - although we will need to see, and it may still require specific tests.

@objectiser Thanks!


Use an array instead of constants in favor to allow literals with dots and dashes

I think that store the translations in the cache file using some king of array instead constants will allow to use "dashed" and "dots" in the names.
For example, this is not possible with the current implementation
echo I::login.submit
and provide some king of (for example)
echo I::get('login.submit')
It is just a thought to know your opinion

This is a big change in how php-i18n works. It may even prevent some optimizations php caches can do now. Unless there is a bigger interest and a merge request for this, I don't think this feature will be added.


Refactoring streams and storage

This PR is attempting to simplify Kafka Streams design and removing the need for an additional Lucene store.
Changes:

Topics has been reduced to 3:

spans (partitioned by traceId),
traces (partitioned by traceId), and
dependency-links (partitioned by pair parent:child)

Kafka Streams topologies reduced to 2, 1 for aggregation, 1 for storage:

trace-aggregation: key topology to collect spans, aggregate, and emit traces and dependency links. Based on Session window.
trace-store: Stores for traces (Key value store), service names (Key value store), and dependency links (Time window based store).

Lucene full-index replaced by a time-based index (based on key-value store) to first get ids, and then apply filtering. [TODO: test performance]. This approach keeps the same limitation for stores: Only standalone instance supported.
Kafka Streams unit-testing added.

possible to add autocomplete tag support?

possible to add autocomplete tag support?

added :)

this might need a little work when you update to zipkin 2.16 because we changed the integration tests to jupiter

@adriancole a lot of clean up has been done :) Much happier with the current state, take a look when you have time. I feel is close to be ready to release.
Hope the design docs and the testing steps clarify the specifics of the storage as buffering for aggregation.
Thanks a lot for taking the time to review!

I noticed you've been a busy bee. I will pull it and give a spin in a bit.

We should think about if re-using the other kafka bootstrap servers
variable makes sense..
I thought about this at the beginning but if we do that, then it will
force to always consume spans collected, when we might want to define that
on a specific node, and do the aggregation/storage later.

having thought about what you said, I agree. however, this doesn't make it
a bad default. We have same concern in AWS ex what is the default region,
which may be different from the signing region. What do you think about
using the kafka bootstrap property by default? Also, if we are talking
about different nodes, they would have different properties anyway. one way
out is to add the option to disable the kafka collector. This seems simpler
than repeating everything here. wdyt?

any difference between the default zipkin topic and the spans one is
notable enough to mention somewhere (if not already mentioned).
I'll add the specifics on the docs. Main difference between them is
partitioning (trace ID as key). Have been thinking about it and I believe
is better to have this separate from Kafka Sender as it could became much
slower, as we already do batching there and this will involve and
additional loop to prepare records and batch them with Kafka; unless I'm
missing something.

much slower if i understand correctly, we are talking about the 1 second
batching interval in the kafka sender? what if we just implement
partitioning in the kafka sender? this is a new component anyway. I think
we discussed before to have compensating logic where if the kafka partition
(key) is not set we assume we have to re-group by trace ID. This is mostly
an exercise to see if we can simplify even if it means changing something
else. If someone can enter this.. and has simpler experience as a result,
this would be worth any upstream work at least that I can currently think
of. Sometimes we talk more about naming convention than work sounds like so
far :P

one way
out is to add the option to disable the kafka collector. This seems simpler
than repeating everything here. wdyt?

Yes, really like this idea, as it replaces span-consumer-enabled purpose :)

This is mostly
an exercise to see if we can simplify even if it means changing something
else. If someone can enter this.. and has simpler experience as a result,
this would be worth any upstream work at least that I can currently think
of

I will create an issue on the java reporter to draw my ideas about it. I've already played a bit on this and found some constrains like: spans already arrive as bytes to the sender, which make it hard to pick the traceId.

Fixes #26

@adriancole I've created https://github.com/openzipkin/zipkin/issues/2762 and https://github.com/openzipkin/zipkin-reporter-java/issues/158 to follow up some of the ideas we've discussed. Is there anything else missing from your pov?

Solo un par? 😂🍻
On Fri, 23 Aug 2019 at 11:42, Adrian Cole<EMAIL_ADDRESS>wrote:

@adriancole approved this pull request.
Te lo mereces un par de chelas!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jeqo/zipkin-storage-kafka/pull/25?email_source=notifications&email_token=ABPE6XOUYNUN2FDLHSKCJHLQF6WJRA5CNFSM4IKTYNT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCP2ZXQ#pullrequestreview-278899934,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPE6XMO4U6GTF3QGS4N4S3QF6WJRANCNFSM4IKTYNTQ
.

un par significa ocho, ya?
On Fri, Aug 23, 2019, 5:46 PM Jorge Quilcate Otoya<EMAIL_ADDRESS>wrote:

Solo un par? 😂🍻
On Fri, 23 Aug 2019 at 11:42, Adrian Cole<EMAIL_ADDRESS>wrote:

@adriancole approved this pull request.
Te lo mereces un par de chelas!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/jeqo/zipkin-storage-kafka/pull/25?email_source=notifications&email_token=ABPE6XOUYNUN2FDLHSKCJHLQF6WJRA5CNFSM4IKTYNT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCP2ZXQ#pullrequestreview-278899934
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ABPE6XMO4U6GTF3QGS4N4S3QF6WJRANCNFSM4IKTYNTQ
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jeqo/zipkin-storage-kafka/pull/25?email_source=notifications&email_token=AAAPVVYMEQT37T7NRN3TZV3QF6WXHA5CNFSM4IKTYNT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD47W4JA#issuecomment-524250660,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAPVVZMPEX3IGATZASKMLLQF6WXHANCNFSM4IKTYNTQ
.

Ahora si nos entendemos 😂😂😂
On Fri, 23 Aug 2019 at 12:01, Adrian Cole<EMAIL_ADDRESS>wrote:

un par significa ocho, ya?

Te lo mereces un par de chelas!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<

https://github.com/jeqo/zipkin-storage-kafka/pull/25?email_source=notifications&email_token=ABPE6XOUYNUN2FDLHSKCJHLQF6WJRA5CNFSM4IKTYNT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCP2ZXQ#pullrequestreview-278899934

,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/ABPE6XMO4U6GTF3QGS4N4S3QF6WJRANCNFSM4IKTYNTQ

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/jeqo/zipkin-storage-kafka/pull/25?email_source=notifications&email_token=AAAPVVYMEQT37T7NRN3TZV3QF6WXHA5CNFSM4IKTYNT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD47W4JA#issuecomment-524250660
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAAPVVZMPEX3IGATZASKMLLQF6WXHANCNFSM4IKTYNTQ
.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/jeqo/zipkin-storage-kafka/pull/25?email_source=notifications&email_token=ABPE6XLEQF5ENTKWSGFNISTQF6YRHA5CNFSM4IKTYNT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD47YDJQ#issuecomment-524255654,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPE6XP5KU4OWCZ3ZQTTBTLQF6YRHANCNFSM4IKTYNTQ
.


setBusy doesn't block user input until busyIndicatorDelay expires

OpenUI5 version: latest
Browser/version (+device/version): all
Any other tested browsers/devices(OK/FAIL):
URL (minimal example if possible): http://jsbin.com/gekod/edit?html,js,output
User/password (if required and possible - do not post any confidential information here):
Steps to reproduce the problem:

Enter text in the Input field
Click the "Save" button
Quickly click inside the Input field and type more characters until the busyIndicatorDelay
expires and finally disables the Input field

What is the expected result? There should be something to block user input during the timeout, and the mouse cursor should change to a busy cursor (if possible). This will prevent the user from changing the view state of the control (and potentially launching callbacks).
What happens instead? When setBusy(true) is called on a control, the method blocks the corresponding control and puts an animation over it after a given delay. The problem is that immediately after the call to setBusy(), the user still has full access to the control until the timeout expires. This is particularly problematic for things such as a Submit/Save button where you do not want the user to press it repeatedly during processing.
Any other information? (attach screenshot if possible)

Hello,
Thanks for pointing this out to us.
We are taking this as a feature request and will keep you posted!
Best regards,
Christiane

Just thinking - until we find a solution for this on our side, maybe you could just disable the button "manually" when you want to prevent it from being clicked twice in a row.
Hope this helps!
Christiane

Thanks Christiane. We could do that, but it's not very practical since we have a number of applications where this would need to be done, with each having a number of places where it happens, along with various controls that would need to be disabled. It would be much more helpful if this was addressed at the SDK level, but I appreciate the suggestion.

Hi @cmastrandrea ,
Sorry for the delay.
Let me know if you're still interested to implement this feature and I'll contact the control owners and will create internal ticket.
Thanks and Kind Regards,
Diana, openui5 dispatcher

Thanks Diana. Yes we would still be interested in getting this implemented as currently it allows the user to interact with components after setBusy is called.

Internally tracked:<PHONE_NUMBER>

Is there a reason why the default delay between calling set busy and actually disabling the control is set at 1000ms? I assume there must be some implementation detail that makes it impractical to disable immediately, but I don't see any notes in the code indicating what that reason is.

Not sure about the control-level BusyIndicator, but for the full-screen one this delay was added to prevent brief flickering of the entire screen when there are multiple very short busy phases. While some long calculations may take seconds and justify a full-screen display of progress and blocking, many smaller requests might just come back after 100 or 200 ms and showing busy indicators for these short periods of time would look very disturbing. After a second, however, chances are that it will take another second.
An obvious solution might be to have two phases of the busy indicators: first, blocking occurs, with no visual indication (apart maybe of the mouse pointer to somewhat indicate why the user cannot click anything). And after a delay it switches to visible blocking.

That explanation makes sense to me. Is this something that you expect to work on in a forthcoming release, or should we expect to prepare a proposed fix and submit it? Thanks again for the timely response.

Well, the responsible team has this issue report on their list now, but I don't know (nor can I influence) when they will get to this. So they'd need to respond and decide...

Hi @cmastrandrea,
It looks like the solution has finally been implemented.
Best regards
Benedikt

Thanks Benedikt. Is this in an existing release or will it be available in the next one?

I stumbled across this problem as well. Looking at the JS Bin example, this issue has not been fixed or reappeared.
My expectation of how the busy state would work: Setting a View/Control to busy immediately prevents any further user interaction.The visual indication that the view/control is busy will only be shown after a delay defined by busyIndicatorDelay.
@bendkt: Can you point to a commit that implemented the solution?

Include busyIndicatorDelay=0 in the definition of the container which busy property will be used.- Default is 1000ms
Details: https://sapui5nightly.int.sap.hana.ondemand.com/#/api/sap.ui.core.Control
Example:  https://jsbin.com/kizuxeboba/edit?html,js,output

Thank you for suggesting a workaround. Does your suggestion imply that the solution proposed by @akudev was not implemented (avoid flickering by separating disabling of UI and showing an actual busy indicator)?

An obvious solution might be to have two phases of the busy indicators: first, blocking occurs, with no visual indication (apart maybe of the mouse pointer to somewhat indicate why the user cannot click anything). And after a delay it switches to visible blocking.


Feature Request: Adding Abstract Page

Thanks for making this template.
I wanted to request adding an Abstract page to the template if possible.

Sorry, I think this question pertains contents, not style, so I don't think any changes to the template are required. In the kaobook template, you can simply create an unnumbered chapter called "Abstract", and you can put it wherever you want (befeore the table of contents, after the table of contents, at the end of the document...). Then, you can change the style of that page as you wish using standard LaTeX. Looking at the kaobook documentation, the "Preface" chapter can be seen as an abstract. I would just rename that chapter from "Preface" to "Abstract". Let me know if you need further help with the customisation, or ask on tex.stackexchange.com :)


Feature(CI): Test under PHP 7.3

Hey!
Thanks!

Coverage decreased (-0.3%) to 53.925% when pulling 108c4e2850da91f225186a25fc7d3a1563dc0578 on ovr:patch-1 into a607b5ccdbfb540b4b6a6bcf2919906834667b34 on zelenin:master.


AmazonSQSException after update from 1.3.14 to 1.4.1

After the update from 1.3.14 to 1.4.1 we started to receive following error when trying to publish a message into ElasticMQ.
No other parts of the code were modified, just update maven dep (from repo here)
Caused by: org.springframework.messaging.MessageDeliveryException: null (Service: AmazonSQS; Status Code: 500; Error Code: 500 Internal Server Error; Request ID: null; Proxy: null); nested exception is com.amazonaws.services.sqs.model.AmazonSQSException: null (Service: AmazonSQS; Status Code: 500; Error Code: 500 Internal Server Error; Request ID: null; Proxy: null), failedMessage=GenericMessage [payload={"event_id":">o<"}, headers={contentType=application/json, id=e6234d2c-0176-8b1d-c5ac-4874e63cb332, timestamp=1686301251634}]
Our version of spring-cloud-aws-messaging is 2.4.4
We are not able to find further details of the 500 errors when debugging the code 😕
Any idea what would be happening? Is there extra info that I could provide to help you understand the issue?

I think I was able to reproduce the issue.

Thanks for reporting the issue, it should be fixed in v1.4.2

Hi! Tested v1.4.2 and it works as expected! 🚀  Many thanks!


Introduce environments in the frontend

Using vite's ability to use different .env files we should support environment variables in the frontend.
For details see: https://vitejs.dev/guide/env-and-mode.html#env-files

This is implemented as part of #37.


IOSQE_IO_LINK and IOSQE_IO_HARDLINK

Curious, what happens if IOSQE_IO_LINK and IOSQE_IO_HARDLINK are both set together in sqe->flags?

HARDLINK implies LINK already, so won't be any different than if just HARDLINK was set.

I see, so IOSQE_IO_HARDLINK will override IOSQE_IO_LINK then

Not sure what you mean. There's no overriding, HARDLINK is LINK + don't break on error. Hence it implies LINK.

Let's say there is no difference b/w IOSQE_IO_HARDLINK|IOSQE_IO_LINK and IOSQE_IO_HARDLINK

Right, that's what I was saying in the first comment.

OK, thanks for clarifying. I just wanted to double check.


added fantom testnet

Added the fantom testnet + tests. Multicall address verified and FTMScan (Testnet)

Looks good, please fix linter and remove version change and I'll be happy to merge.

@maharshi365 Need lint fix and I am happy to merge

Any chance this can be merged? Need FTM testnet. Thx

@stoplion Needs a lint fix and I am happy to merge


0.95 Supply crates new removing from mission files

In some of the mission files there are placed supply creates that need remove due to causing problems when loading them into the fob supply storage areas

Thanks to report it here again.
During the "cleanup" after feature implementation and before release, we'll get through all official provided maps to prevent that.

Closed now, as they won't break the resource system anymore.
But I'll remove the decorative ones in the future, so it won't confuse someone.


[WIP] Unit test workflow using GitHub Actions

Description
Migrate unit tests from CircleCI to GitHub Actions
Motivation and Context
Why is this change required? What problem does it solve?
The direction is to move unit tests to GitHub Actions.

[ ] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes
What types of changes does your code introduce? Remove all that do not apply:
No change to functionality.
Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[x ] I have read the CONTRIBUTION guide (required)
[ ] My change requires a change to the documentation.
[ ] I have updated the tests accordingly (required for a bug fix or a new feature).
[ ] I have updated the documentation accordingly.

Hi @vmoens! @robandpdx works on  migration the "Unit-tests on Linux GPU" job to GitHub Actions.

Hi @vmoens! @robandpdx works on migration the "Unit-tests on Linux GPU" job to GitHub Actions. There is a problem with the smoke test smoke_test_deps.py::test_dm_control: ImportError: Cannot initialize a headless EGL.  Did you face such issue before?

Hi @vmoens! @robandpdx works on migration the "Unit-tests on Linux GPU" job to GitHub Actions. There is a problem with the smoke test smoke_test_deps.py::test_dm_control: ImportError: Cannot initialize a headless EGL. Did you face such issue before?

It's a common issue with dm_control and related. We provide some solutions here:
https://pytorch.org/rl/reference/generated/knowledge_base/MUJOCO_INSTALLATION.html#installing-mujoco


Daily figures appearing as Absolute values, not Daily delta values.

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Hi, I’ve got an issue with my setup (which I suspect could be an issue with the source) but what I’m seeing is that all the ‘daily’ values appear as absolute values, rather than daily delta values, despite apparently being set as ‘total_increasing’.
The reason I’m doubting it’s the card is that the default device card also shows the absolute values, although the Energy dash does show the delta values!
(  I don’t know where to find/access that HA config though, as been reluctant to ‘take over’ that boards config as it’s useful having it automatically managed and don’t know if I can revert it once taken over?  Any pointers, either in HA or even the HA source, btw?)
If someone has any ideas, I’d appreciate suggestions as what to look for…
Steps To Reproduce
No response
Expected behaviour
Values such as ‘3’ rather than ‘183’ for Daily Grid usage
Card Version
2.1.9.  (?)
Home Assistant Version
2023.9.0
Configuration
title: Home
views:
  - path: default_view
    title: SunSynk
    subview: false
    type: panel
    badges: []
    cards:
      - type: custom:sunsynk-power-flow-card
        cardstyle: lite
        show_solar: true
        battery:
          energy: 0
          invert_power: true
          shutdown_soc: 20
          show_daily: true
        solar:
          show_daily: true
          mppts: 2
        load:
          show_daily: true
        grid:
          show_daily_buy: true
          show_daily_sell: true
          show_nonessential: true
        entities:
          use_timer_248: switch.deye_sunsynk_sol_ark_use_timer
          priority_load_243: select.deye_sunsynk_sol_ark_energy_pattern
          inverter_voltage_154: sensor.deye_sunsynk_sol_ark_ac_output_voltage
          load_frequency_192: sensor.deye_sunsynk_sol_ark_ac_output_frequency
          inverter_current_164: sensor.sunsynk_inverter_current
          inverter_power_175: sensor.deye_sunsynk_sol_ark_load_power
          grid_connected_status_194: binary_sensor.sunsynk_grid_connected_status
          inverter_status_59: sensor.sunsynk_overall_state
          day_battery_charge_70: sensor.deye_sunsynk_sol_ark_battery_energy_in
          day_battery_discharge_71: sensor.deye_sunsynk_sol_ark_battery_energy_out
          battery_voltage_183: sensor.deye_sunsynk_sol_ark_battery_voltage
          battery_soc_184: sensor.deye_sunsynk_sol_ark_battery_state_of_charge
          battery_power_190: sensor.deye_sunsynk_sol_ark_battery_power
          battery_current_191: sensor.deye_sunsynk_sol_ark_battery_current
          grid_power_169: sensor.deye_sunsynk_sol_ark_grid_power
          day_grid_import_76: sensor.deye_sunsynk_sol_ark_grid_energy_in
          day_grid_export_77: sensor.deye_sunsynk_sol_ark_grid_energy_out
          grid_ct_power_172: sensor.deye_sunsynk_sol_ark_grid_power
          day_load_energy_84: sensor.deye_sunsynk_sol_ark_load_energy
          essential_power: none
          nonessential_power: none
          aux_power_166: sensor.sunsynk_aux_power
          day_pv_energy_108: sensor.deye_sunsynk_sol_ark_pv_energy
          pv1_power_186: sensor.deye_sunsynk_sol_ark_pv_power_1
          pv2_power_187: sensor.deye_sunsynk_sol_ark_pv_power_2
          pv1_voltage_109: sensor.deye_sunsynk_sol_ark_pv_voltage_1
          pv1_current_110: sensor.deye_sunsynk_sol_ark_pv_current_1
          pv2_voltage_111: sensor.deye_sunsynk_sol_ark_pv_voltage_2
          pv2_current_112: sensor.deye_sunsynk_sol_ark_pv_current_2

Relevant log output
No response

Example: state for the Daily load sensor (sensor.deye_sunsynk_sol_ark_load_energy) from developer tools:
state_class: total_increasing
unit_of_measurement: kWh
device_class: energy
friendly_name: Deye/SunSynk/Sol-Ark Load energy

HI
This is not a card issue. The card will display whatever the sensor provides. It sounds like you are using the total load energy sensor which is not reset every day. You can create a new utility sensor that resets daily and use sensor.deye_sunsynk_sol_ark_load_energy as the source.  Alternatively you need to use the correct sensor from your integration that reports daily totals (if it exists)

Thanks, will try that route...


Add rewriteTag to filter crd

rewriteTag is missing in filter crd files, so I added it

Thank you for your advice, this is good but this is not complete. Api should also be updated.
The last you need to run make manifests and update the files.

@seungkyua you'll need to solve the conflict, run the following command, and then submit the new modified files
make manager
make manifests

Repeat with #155, closed.


add docker dev files for local development

Trying to make it easier to contribute.
 Don't really understand the error though.
56.65    Compiling async-compression v0.4.1
56.94    Compiling tower-http v0.4.3
57.50    Compiling axum-prometheus v0.3.4
57.92    Compiling rustlog v0.1.0 (/app)
58.65 error: future cannot be sent between threads safely
58.65    --> src/migrator/mod.rs:105:47
58.65     |
58.65 105 |                       let handle = tokio::spawn(async move {
58.65     |  _______________________________________________^
58.65 106 | |                         let mut inserter = migrator
58.65 107 | |                             .db
58.65 108 | |                             .inserter(MESSAGES_TABLE)?
58.65 ...   |
58.65 155 | |                         Result::<_, anyhow::Error>::Ok(())
58.65 156 | |                     });
58.65     | |_____________________^ future created by async block is not `Send`
58.65     |
58.65     = help: within `[async block@src/migrator/mod.rs:105:47: 156:22]`, the trait `std::marker::Send` is not implemented for `*mut (twitch::Tag<'static>, &'static str)`
58.65 note: future is not `Send` as this value is used across an await
58.65    --> src/migrator/mod.rs:270:37
58.65     |
58.65 248 |         Ok(irc_message) => {
58.65     |            ----------- has type `twitch::Message` which is not `Send`
58.65 ...
58.65 270 |             inserter.write(&message).await?;
58.65     |                                     ^^^^^^ await occurs here, with `irc_message` maybe used later
58.65 271 |         }
58.65     |         - `irc_message` is later dropped here
58.65 note: required by a bound in `tokio::spawn`
58.65    --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.31.0/src/task/spawn.rs:166:21
58.65     |
58.65 166 |         T: Future + Send + 'static,
58.65     |                     ^^^^ required by this bound in `spawn`
58.65
58.68 error[E0599]: the method `par_iter` exists for reference `&[Message]`, but its trait bounds were not satisfied
58.68   --> src/logs/mod.rs:26:10
58.68    |
58.68 25 | /     irc_messages
58.68 26 | |         .par_iter()
58.68    | |_________-^^^^^^^^
58.68    |
58.68    = note: the following trait bounds were not satisfied:
58.68            `&[twitch::Message]: IntoParallelIterator`
58.68            which is required by `[twitch::Message]: IntoParallelRefIterator<'_>`
58.68            `&&[twitch::Message]: IntoParallelIterator`
58.68            which is required by `&[twitch::Message]: IntoParallelRefIterator<'_>`
58.68
58.77 error[E0277]: `*mut (twitch::Tag<'static>, &'static str)` cannot be sent between threads safely
58.77    --> src/logs/mod.rs:12:10
58.77     |
58.77 12  |         .filter_map(|raw| match twitch::Message::parse(raw) {
58.77     |          ^^^^^^^^^^ `*mut (twitch::Tag<'static>, &'static str)` cannot be sent between threads safely
58.77     |
58.77     = help: within `twitch::Message`, the trait `std::marker::Send` is not implemented for `*mut (twitch::Tag<'static>, &'static str)`
58.77     = note: required because it appears within the type `ParsedTags<'static>`
58.77     = note: required because it appears within the type `Option<ParsedTags<'static>>`
58.77     = note: required because it appears within the type `Message`
58.77 note: required by a bound in `rayon::iter::ParallelIterator::filter_map`
58.77    --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-1.7.0/src/iter/mod.rs:833:12
58.77     |
58.77 833 |         R: Send,
58.77     |            ^^^^ required by this bound in `ParallelIterator::filter_map`
58.77
58.78 error[E0599]: `rayon::iter::FilterMap<rayon::vec::IntoIter<std::string::String>, [closure@src/logs/mod.rs:12:21: 12:26]>` is not an iterator
58.78   --> src/logs/mod.rs:19:10
58.78    |
58.78 10 | /     lines
58.78 11 | |         .into_par_iter()
58.78 12 | |         .filter_map(|raw| match twitch::Message::parse(raw) {
58.78 13 | |             Ok(msg) => Some(msg),
58.78 ...  |
58.78 18 | |         })
58.78 19 | |         .collect()
58.78    | |         -^^^^^^^ `rayon::iter::FilterMap<rayon::vec::IntoIter<std::string::String>, [closure@src/logs/mod.rs:12:21: 12:26]>` is not an iterator
58.78    | |_________|
58.78    |
58.78    |
58.78   ::: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/rayon-1.7.0/src/iter/filter_map.rs:13:1
58.78    |
58.78 13 |   pub struct FilterMap<I: ParallelIterator, P> {
58.78    |   -------------------------------------------- doesn't satisfy `_: Iterator`
58.78    |
58.78    = note: the following trait bounds were not satisfied:
58.78            `rayon::iter::FilterMap<rayon::vec::IntoIter<std::string::String>, [closure@src/logs/mod.rs:12:21: 12:26]>: Iterator`
58.78            which is required by `&mut rayon::iter::FilterMap<rayon::vec::IntoIter<std::string::String>, [closure@src/logs/mod.rs:12:21: 12:26]>: Iterator`
58.78
58.83 warning: unused import: `IntoParallelRefIterator`
58.83  --> src/logs/mod.rs:6:44
58.83   |
58.83 6 | use rayon::prelude::{IntoParallelIterator, IntoParallelRefIterator, ParallelIterator};
58.83   |                                            ^^^^^^^^^^^^^^^^^^^^^^^
58.83   |
58.83   = note: `#[warn(unused_imports)]` on by default
58.83
58.84 Some errors have detailed explanations: E0277, E0599.
58.84 For more information about an error, try `rustc --explain E0277`.
58.85 warning: `rustlog` (bin "rustlog") generated 1 warning
58.85 error: could not compile `rustlog` (bin "rustlog") due to 4 previous errors; 1 warning emitted
58.88 error: failed to compile `rustlog v0.1.0 (/app)`, intermediate artifacts can be found at `/app/target`
------
failed to solve: process "/bin/sh -c cargo install --path /app" did not complete successfully: exit code: 101

Any hints?

Hi, sorry for taking a long time to respond.
Regarding the compile error: this is caused by cargo install (unfortunately) not using the lockfile by default, and instead pulling the latest versions of dependencies. This is fixed by using the --locked option.
As for the PR overall: I really like the idea of making it easier to contribute, but I have some questions.
How do you want the workflow to look when using the dev containers? Change code>rebuild image>start container>test? Or should it be a persistent container which recompiles the program automatically on code changes?
In the first case, IMO it would make sense to also build the frontend, at which point you might as well use the main Dockerfile for this purpose, as it also has caching configured to avoid recompiling all the dependencies every time.
In the second case, there would either need to be 2 containers, or a single container running 2 processes for recompiling rust (via cargo-watch for example) as well as the frontend with yarn start. This would let you test your changes faster, but is more complex.
Personally, I'm not a fan of doing this kind of development in Docker using either approach, as it creates an extra layer of friction between the program and the development environment (not using system compiler settings, can't attach a debugger easily, also it creates noticeable overhead on non-Linux systems due to running in a VM) and rustlog doesn't have many system dependencies that you need to install. Though I definitely agree that simplifying the database setup would be nice.
Would you be fine with having a ready-to-go docker-compose in the repo for setting up the database, and running rustlog itself with cargo run on the host? If yes, then that's the option that I would like to have. if not, then please tell me which of the "fully dockerized" approaches you would prefer.

Yeah, I agree, it's probably not wise to run the backend in a container in the dev environment. Equally with the frontend.
I think for ease-of-use it should just use a Makefile or some similar one shot command tool.
make watch-backend (also runs docker-compose up on the db)  and make watch-frontend or something like that.

@gempir I've added a guide and some setup files in #16 . Unfortunately making it a one-shot watch command would require several external tools installed, and that is something I would like to avoid. However there are step-by-step instructions on how to get it running, hopefully those will be helpful enough. Please take a look at the PR and tell me if it's clear enough for a first time contributor (it's kinda hard for me to judge this)

I think that's great! Thank you!


adding feels like temperature (I missed that before)

Clay pointed out that I forgot to add the feels like temperature.

@clajtayl This looks good to me. Wanna look it over too?


Add module plugin

Coverage remained the same at 98.913% when pulling fd82b7a86c41de3313f0e0d8ded21d6f4c64706e on module into bd0fab35590880600b2b56c1c0a71648e95c49ae on main.


Fix: docker image fix

Description

There were some issues in the way in which the docker images were being built. I have fixed them here.
Notes to reviewers
Checklist

[] Signed commits.
[] PR title includes [<name of area>]:<description>

@kanishkarj - a conflict in the makefile...

I shall fix it righaway.

Does that look good?

@kanishkarj fyi - https://github.com/layer5io/image-hub/runs/734518353#step:4:208

Oh its a minor mistake I made while merging the PR. Shall fix it right away...


ionic serve custom gulp commands

So I really like the mechanism to execute the sass and watch gulp tasks when serving the application. I was wondering if this could be expanded so any gulp task could be executed as a prerequisite to running the ionic serve command?
Maybe the sass flag in the ionic project file needs to be called something more generic like preserveor build giving the user the option of referencing multiple gulp tasks in their gulpfile?
{
  "name": "myApp",
  "app_id": "",
  "preserve": true
}

gulp.task('preserve', ['sass', 'angular-templates'])

In most use-cases it's not just sass which needs a preprocessing step, images, templates etc sometimes need to be passed through a gulp task. At present my work around is to declare sass: true in the ionic project file and amend the watch task to run:
gulp.task('watch', ['angular-templates'], function() {
  gulp.watch(paths.sass, ['sass']);
  gulp.watch(paths.templates, ['angular-templates']);
});

Of course this means in order for the watch task to be executed the sass: true flag is required.
On feedback, i'd be happy to submit a pull req.

Does the gulp integration work for ionic build commands?


Bump mobtest, add validation of what is in fs and fix no mob in metadata

Two changes in mobtest:

Fix issue present in here.
Add validation that everything what in fs is in manifest

Will test this in a few repos.

Being tested in movai_ot_ottobo, movai_drivers_joysticks, movai_mo_template and movai_ouster_ros. Lets wait a few days to confirm no issues arise.


Pipeline behaviors execution order / constrained behaviors

Hi there,
this is not really an issue and I assume that what I'm experiencing is by design, but I wanted to make sure:
I'm making extensive use of pipeline behaviors along my request path, whereby I have a number of generic behaviors which apply to all requests and some more specific requests which only apply to certain request types.
I thought I could achieve the latter by implementing IPipelineBehavior<MyType, Unit> and then registering this specific behavior. But it turns out that pipeline behaviors implementing a more specific type than IRequest (registered using open generics) get executed before any of the more generic IPipelineBehavior<TRequest, TResponse> behaviors.
The "workaround" is to use constraints when implementing IPipelineBehavior which results in all handlers being executed in the order they were registered.
Nevertheless, it makes behavior definition and registration a bit more cumbersome and forces me to register my constrained behaviors as open generics as well, despite them being closed.
Is there any way to influence the execution order of the behaviors or is this just by design that more specific behaviors are executed prior to more generic ones?
Any comments welcome!
Cheers
Alexander

Depends on the container, really
On Fri, Apr 26, 2019 at 7:17 PM Alexander Röthinger <
<EMAIL_ADDRESS>wrote:

Hi there,
this is not really an issue and I assume that what I'm experiencing is by
design, but I wanted to make sure:
I'm making extensive use of pipeline behaviors along my request path,
whereby I have a number of generic behaviors which apply to all requests
and some more specific requests which only apply to certain request types.
I thought I could achieve the latter by implementing
IPipelineBehavior<MyType, Unit> and then registering this specific
behavior. But it turns out that pipeline behaviors implementing a more
specific type than IRequest (registered using open generics) get executed
before any of the more generic IPipelineBehavior<TRequest, TResponse>
behaviors.
The "workaround" is to use constraints when implementing IPipelineBehavior
which results in all handlers being executed in the order they were
registered.
Nevertheless, it makes behavior definition and registration a bit more
cumbersome and forces me to register my constrained behaviors as open
generics as well, despite them being closed.
Is there any way to influence the execution order of the behaviors or is
this just by design that more specific behaviors are executed prior to more
generic ones?
Any comments welcome!
Cheers
Alexander
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jbogard/MediatR/issues/399, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAZQMQHWFXSCVHKGOVUWDLPSOLPZANCNFSM4HI3A6JQ
.

Unity

No idea tbqh. Some containers guarantee the order executed is the order registered, some don't.


Merge Both Apps Frontend and Backend on the same repo

Description
Merging the two repos in to one
Same repo for source code of backend https://github.com/eclipse-tractusx/vas-country-risk-backend and frontend https://github.com/eclipse-tractusx/vas-country-risk
Include charts in same structure for both
Merge readme.md and changelog of both Applications
Include workflows on both Applications
fix: https://github.com/eclipse-tractusx/vas-country-risk/issues/123
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

Pls fix your linting issue:
charts/country-risk/values.yaml
Error: 356:17 [new-line-at-end-of-file] no new line character at the end of file

Pls fix your linting issue:
charts/country-risk/values.yaml Error: 356:17 [new-line-at-end-of-file] no new line character at the end of file

Done


Add health check to subscriber

Hey @roblaszczak what do you think about this idea? The end goal here is add a health check for a router.

Hello @ahvargas! I think that it is not the responsibility of the Watermill to check the health of the brokers.
Can you share the use case for that?

Sorry for a bit delay @ahvargas ;-) Probably the best idea is to use a message router and wait for https://github.com/ThreeDotsLabs/watermill/blob/master/message/router.go#L396 (Running) for the readiness check.
Your application is healthy as long as https://github.com/ThreeDotsLabs/watermill/blob/master/message/router.go#L300 is running (Run), after Run exits probably it's the best idea to just kill the process.


add run_exports

This was thoughtless of me to forget, now that libecpint is a shared library. I've no urgency for this fix, so it's fine by me to let this PR sit for a while and accumulate more changes before consideration.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] ~Reset the build number to 0 (if the version changed)~
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

This was thoughtless of me to forget, now that libecpint is a shared library. I've no urgency for this fix, so it's fine by me to let this PR sit for a while and accumulate more changes before consideration.

I like to move fast, before we start rebuilding the dependent packages/


Add script to create new release JSON

This is a basic script that uses the osquery repo and tooling to generate the metadata and schema for a new release for the website.

Moved the script into a ./tools dir @directionless


dibs: I will implement the simple-linked-list exercise

dibs: I will implement the simple-linked-list exercise

That would be awesome, to have yet another new exercise.
I see that simple-linked-list.spec.js and example.js files have no content yet in the PR. I think this is a work in progress PR, so I think @javaeeeee will implement them.
Also, due to some recent merges, there is a conflict on config.json (two exercises have been added at the end of the list of exercises). Please, @javaeeeee, be careful with this.
Ideally, the PR branch should be rebased with the latest changes in xjavascript/master. So, it'd involve update your fork with xjavascript changes. Then rebasing your own branch, and then update this PR by pushing that branch. This is all git jargon, so feel free to ask for help if you need some.

Thank you.
On Wed, Dec 7, 2016 at 12:46 PM, Rubén Chavarría<EMAIL_ADDRESS>wrote:

That would be awesome, to have yet another new exercise.
I see that simple-linked-list.spec.js and example.js files have no
content yet in the PR. I think this is a work in progress PR, so I think
@javaeeeee https://github.com/javaeeeee will implement them.
Also, due to some recent merges, there is a conflict on config.json (two
exercises have been added at the end of the list of exercises). Please,
@javaeeeee https://github.com/javaeeeee, be careful with this.
Ideally, the PR branch should be rebased with the latest changes in
xjavascript/master. So, it'd involve update your fork with xjavascript
changes. Then rebasing your own branch, and then update this PR by pushing
that branch. This is all git jargon, so feel free to ask for help if you
need some.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/exercism/xjavascript/pull/311#issuecomment-265518190,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIezh1DDcizkci0AhalPqUjpgYizVD0tks5rFvDmgaJpZM4LEcyK
.

@javaeeeee Hi Dmitry,
Are you able to resolve this merge conflict?  I'm happy to help, or do it for you if you are busy-- let's get your work to the people!

Just a moment, please.
On Sun, Jan 22, 2017 at 8:36 AM, Matthew Morgan<EMAIL_ADDRESS>wrote:

@javaeeeee https://github.com/javaeeeee Hi Dmitry,
Are you able to resolve this merge conflict? I'm happy to help, or do it
for you if you are busy-- let's get your work to the people!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/exercism/xjavascript/pull/311#issuecomment-274331362,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIezh43iYkupyCLCSEovWv_DB02AG64Yks5rU1tggaJpZM4LEcyK
.

@matthewmorgan Hello, Matthew,
Done. Going to finish this piece this week.

👍

@matthewmorgan Hi. Did you have a chance to review this PR? It's pending for 5 months now, it's time to get it done - or close it if for some reason it became irrelevant.

Lemme know if you need some more work on this. We could ping @javaeeeee or I can continue his work if he's not available.

@joelwallis Lets wait for a week, if @javaeeeee does not turn up, you can pick this up.

@tejasbubane roger that!

@joelwallis Its been a while, looks like @javaeeeee hasn't turned up. I think you can go ahead and finish this one.

@joelwallis are you planning on bringing this one home?  Let me know if I can help....

@matthewmorgan I am! Sorry for taking so long. I'm prioritizing this PR now.

@joelwallis no apology necessary!  I was just doing a little housekeeping over the weekend :)

I'm closing this PR. The Simple Linked List was implemented in #372.


Add details field to Task class

Pull Request
What does this PR do?
Fixes #331
created new class Details with two fields, and added Details class object as a field in Task class

Hi @alallema,
Thanks for reviewing my PR, I have another idea, we can use Map<String, String> details  in Task class to add details field, whats your take on this?
Also i have issues with linting, i am not able to find what is the real issue is... If you dont mind Can you please help me with that?

There some types missing: See example

@kuruvasatya, I see you open a new PR #336 did I close this one?


Union (Typing) and Constr (Pydantic): issue

If you try to create for example:
from typing import Optional
from datetime import datetime
from pydantic import BaseModel, constr

# Shared properties
class AutonomousBase(BaseModel):
    number: constr(
        regex=r"^([1-5]\d{4}|[1-9]\d{0,3}|6[0-4]\d{3}|65[0-4]\d{2}|655[0-2]\d|6553[0-5])(\.([1-5]\d{4}|[1-9]\d{0,3}|6[0-4]\d{3}|65[0-4]\d{2}|655[0-2]\d|6553[0-5]|0))?$"
    ) = None

you have no problem
but if you try:
from typing import Optional, Union
from datetime import datetime
from pydantic import BaseModel, constr

class ASPLAIN(BaseModel):
    """ AS 16 Bits """
    number: constr(
        regex=r"^([1-5]\d{4}|[1-9]\d{0,3}|6[0-4]\d{3}|65[0-4]\d{2}|655[0-2]\d|6553[0-5])$"
    ) = None

class ASDOT(BaseModel):
    """ AS 32 Bits """
    number: constr(
        regex=r"^([1-5]\d{4}|[1-9]\d{0,3}|6[0-4]\d{3}|65[0-4]\d{2}|655[0-2]\d|6553[0-5])$"
    ) = None

# Shared properties
class AutonomousBase(BaseModel):
    number: Union[ASDOT,ASPLAIN]

Constr are not correctly interpreted in API and it's written any of string ... Constraint has disappear (regex)

I'm afraid I don't understand the problem, the following which I hope is a simplification of your problem works fine for me.
from typing import Optional, Union
from pydantic import BaseModel, constr

class A(BaseModel):
    x: constr(regex=r"^foo$") = None

class B(BaseModel):
    x: constr(regex=r"^bar$") = None

class C(BaseModel):
    whatever: Union[A, B]

print(C(whatever={'x': 'foo'}))
#> C whatever=<A x='foo'>
print(C(whatever={'x': 'wrong'}))
#> ValidationError


JavaScript

JavaScript
User Story
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I can see the four topics I learned listed along with a suggestion on what I should study first

Completed although , slightly confused with the array but completed anyway and somehow works.


plushie rubber toys

RubberChicken and ToyRubberDuck both inherit BasePlushie which is wrong, because rubber is not a plush

moth eating rubber chicken yummy


Support more expressive :root and html selectors

Selectors like :root[dir="rtl"] and html.foo are now supported
Support html selector for custom-style
Fixes #3902
Fixes #3924
Fixes #3991

@azakus : Let's fix the edge tests before merging