Installing of linter via pip fails

Hi y'all!
I've been having this problem for a while now and it only shows up when I'm working in a virtual environment but googling the problem didn't do anything for me and so here I am. I am not a professional and I am fairly new to working with VSCode so I am sorry if I miss important information or use the wrong nomenclature. Should you need more information I'd be glad to give it.
The problem:
I started a fresh new virtual environment (venv) in one of my working directories (my workspace contains multiple different folders) and I chose it as the interpreter for my project. Although before (working with the "standard" Python interpreter) the linting worked fine, VSC now tells me that "Linter flake8 is not installed". Of course I click on "Install" and the terminal pops up with the trusty ol' IDE calling "pip install -U flake8" like this:
 d:/Viktor/Dokumente/Diplomarbeit/DA_Coding/FUSIONFORGE_REPOSITORY/1_OBC/Modes/3_SCIENCE_Mode/.venv/Scripts/python.exe c:\Users\[REDACTED]\.vscode\extensions\ms-python.python-2020.12.424452561\pythonFiles\pyvsc-run-isolated.py pip install -U flake8
however, this fails with this error message:
C:\Python39\python.exe: can't open file 'C:\Users[REDACTED].vscodeextensionsms-python.python-2020.12.424452561pythonFilespyvsc-run-isolated.py': [Errno 2] No such file or directory
Now, this second path seems very weird to me, not like a "proper" path at all. I figured that there is no way that this file could be opened but I do not know what to do to correct this.
In the mantime I thought it might be smart to try and install flake8 in the venv manually so that is what I did. However, although pip lists flake8 as installed, nothing has changed...
So, any help would be much appreciated!
My environment:
VSCode Version: 1.52.1
Python Version: 3.9.0
OS:Windows 10; 64-bit

It has been a while and the error did not go away... Is there no one out there who could help me?

It has been a while and the error did not go away... Is there no one out there who could help me?

@GeneralMidiRotkiv, sorry for the delay.  That filename definitely looks strange.  It should be:  C:\Users\[REDACTED]\.vscode\extensions\ms-python.python-2020.12.424452561\pythonFiles\pyvsc-run-isolated.py.  The missing backslashes imply something strange is going on.
What version of the extension are you using?
As to installing it manually, make sure you install it using the virtual environment:
d:/Viktor/Dokumente/Diplomarbeit/DA_Coding/FUSIONFORGE_REPOSITORY/1_OBC/Modes/3_SCIENCE_Mode/.venv/Scripts/python.exe -m pip install -U flake8

@GeneralMidiRotkiv, sorry for the delay.  That filename definitely looks strange.  It should be:  C:\Users\[REDACTED]\.vscode\extensions\ms-python.python-2020.12.424452561\pythonFiles\pyvsc-run-isolated.py.  The missing backslashes imply something strange is going on.
What version of the extension are you using?
As to installing it manually, make sure you install it using the virtual environment:
d:/Viktor/Dokumente/Diplomarbeit/DA_Coding/FUSIONFORGE_REPOSITORY/1_OBC/Modes/3_SCIENCE_Mode/.venv/Scripts/python.exe -m pip install -U flake8

@ericsnowcurrently, thanks for your reply! Do you have any idea as to why there are no backslashes? Where could I look to correct this?
Actually, using the full path to the environment did do the trick. I was able to install both the linter and the formatter, so now at least this works as it should. Thank you for that! I just wish I'd have thought of this earlier...
But now I have an additional question: is there any way I could use both the linter and the formatter inside the venv but without actually having to install it inside the venv? The reason I'm asking is that this is my final thesis and after finishing it, I'd like to ship the software only with the packages necessary to run the software. Linting and formatting are nice to have but certainly not necessary. Is there a 'professional' way to do this or just the low-tech way of simply uninstalling the unnecessary packages before shipping?

@ericsnowcurrently, thanks for your reply! Do you have any idea as to why there are no backslashes? Where could I look to correct this?
Actually, using the full path to the environment did do the trick. I was able to install both the linter and the formatter, so now at least this works as it should. Thank you for that! I just wish I'd have thought of this earlier...
But now I have an additional question: is there any way I could use both the linter and the formatter inside the venv but without actually having to install it inside the venv? The reason I'm asking is that this is my final thesis and after finishing it, I'd like to ship the software only with the packages necessary to run the software. Linting and formatting are nice to have but certainly not necessary. Is there a 'professional' way to do this or just the low-tech way of simply uninstalling the unnecessary packages before shipping?

Is there a way to reuse the vscode-python extension to prompt installation additional linters that are python packages? I do need to add a number of additional linters and it makes no sense to replicate the complex logic around the process, considering that from the practical point of view they work and install the same way as the current hardcoded list of linters?
Is there any example of another extension that makes use of vscode-python code in order to trigger installation fo other python packages?
@brettcannon Any chance you may know something about this?
I could easily make a change to propose adding doc8, ansible-lint or pre-commit to the list of linters from this project but none of these target python code itself, they are all python based. An extension point for that would be ideal as other extensions could just build on top of vscode-python but I was not able to identify one.

@ssbarnea to directly answer your question: there is no specific way to either add your own linters to the prompt, and I am unaware of any users of our code outside of the extension for this sort of thing.
Now if you are looking for a way to just get people to install dependencies into an environment, we have some ideas about a better "getting started" experience. If it's more about wanting to get support for other linters, we have some ideas on that as well. All of this, though, has no planned timelines; these are things we definitely want to do as time permits.

@brettcannon I guess you are aware of how popular is the use of test-requirements.txt. Is there a chance we can get some help from vscode-python for installing additional test requirements mentioned by the project? -- maybe like a prompt to install it?
If we go this way, we may be able to address the issue of installing other test dependencies in a generic way, where the repository owner can control them, without having to add code specific for each one in the extension.
Please note that installing these dependencies is not a real problem for myself, or other more advanced users but I am more worried about people with less experience with python as I want to make their first-experience to be more of "just-worked" instead of "i wasted the entire day trying to make it work and gave up".

@ssbarnea yep, I'm aware (I personally use dev-requirements.txt) 😄 . We do have plans to help with the initial setup experience (e.g. detecting a requirements file and asking the user if they want us to use it to install things), but we have no ETA on that yet).

Hi @GeneralMidiRotkiv 👋 are you still experiencing this issue?
I tried installing a formatter and it used the following command on Windows:
"c:/Users/karraj/OneDrive - Microsoft/Desktop/folders/popopo/.v0/Scripts/python.exe" c:\Users\karraj\.vscode\extensions\ms-python.python-2021.4.720518580-dev\pythonFiles\pyvsc-run-isolated.py pip install -U autopep8

Which works fine for me. My selected terminal is command prompt. May I know the type of terminal you've selected? (Check the value of terminal.integrated.shell.windows in User settings) Note the default is command prompt.

Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on then we will be happy to re-open this issue to pick up where we left off.


Json and plain text with HTML Language mode stopped showing word auto complete

VSCode Version: 1.19.0
OS Version: Windows 10 Home 64 bit

Steps to Reproduce:
vscode used to show autocomplete option for words that existed int the file. I use vscode for keep track of my notes. I keep my plain texts (*.txt) with language mode html. Same thing is happening in JSON files.
I write a property (e.g. BusNumber) and when I try to retype the property it doesn't show up in autocomplte dropdown when I am typing in JSON and I have to retype the whole property again. It used to show up as soon as I started typing two letters. In plain text if an word existed in the file it used to come as an option for autocomplete now it is not.
I use vscodevim and Prettify JSON. Even after disabling those I am having the issue.

Reproduces without extensions: Yes

Make sure to have the setting "editor.wordBasedSuggestions" enabled.

I have that setting enabled by default. Even though I added that again as true in user settings. And still the issue exists.

I have updated VSCode to 1.19.1 and still the issue exists.


[FEATURE] Add FAQ page to the Harvester doc

Is your feature request related to a problem? Please describe.

Add FAQ page to the Harvester doc to includes common users questions
Describe the solution you'd like

Add new faq page to https://docs.harvesterhci.io/
Describe alternatives you've considered

Additional context

close in favor of https://docs.harvesterhci.io/v0.3/faq/


Investigate npx no install

npm i @xata.io/codegen -D
npm i @xata.io/client
xata pull
npx xata-codegen -c xata/config.json

vs
npx https://app.xata.io/sdk/my-project/db/branch

I play around this idea, we can easily provide a npx https://app.xata.io/sdk/my-project/db/branch by serving a tar.gz with a package.json inside. This can also works with npm i https://app.xata.io/sdk/my-project/db/branch (even cooler).
But the major problem is the auth, since the xata schema is not public. With this in mind, we could generate a unique token for this, but the DX is not as good (and this add a lot of complexity)
Anyway, playing a bit and thinking about it, I think a classic npm package is still better.
$ npx @xata.io/client
> What's your token?
> Select your workspace
> Select your database
> Select your branch
> Where do you want to generate the SDK?
> 🦋 You are ready to go! 🦋

This could generate the SDK and package.json, end of story!


Method to set per-variable defaults

Greetings,
Starting with @brianpm comment on this:
We need a way to specify defaults on a per-variable basis, as @andrewgettelman mentioned, and Adam Phillips brought up from the beginning. We didn’t build any support for this yet, but it could be as simple has having a file (json or yaml or csv or whatever), in which every entry looks something like this:
Variable, scale_factor, to_units, cmap.  , diff_cmap, cnLevels.   , diff_cnLevels, map_projection
PRECT   , 86400000.   , "mm/day", ‘BuGn’ , ‘BrBG’.  , (0, 100, 10), (-20, 20, 2), “Molleweide"

We can decide what fields need to be in there; this was just what occurred to me at this moment. Then plotting scripts could query this table if a flag (“amwg_defaults” ?) is set.

Does anyone have a strong opinion about whether to have one big file that has all the variables vs. @andrewgettelman's suggestion of one file per variable? I don't really, but I see the potential attraction to one file per variable because one could just add new custom entries that are used for particular diagnostics (and ignored by everything else).
Preference for YAML vs JSON vs something else?
I'm ambivalent, but YAML is a little easier to edit by hand than JSON. There are other options, but I'm not sure whether it would be worth adding another file format to ADF unless there were a good reason.

If we are using YAML already for scripts (and easier to edit) suggest we stick with it and not add a file format to ADF as Brian suggests.
I am ambivalent to one file per variable or not. Easier to customize as Brian notes, but harder to manage.
Maybe a compromise is a format where there is one file with a 'block' for each variable that could contain any number of things (so could be customized). E.g.:
var1
- attribute1 = X
- attribute2 = "Y"

var2
- attribute3 = Z
- attribute2 = "Q"

I agree that YAML is better than JSON.
Advantages of multiple files:

they can be developed in parallel, perhaps during a later hack-a-thon
if we went with the .py format Andrew mentioned before, the deriving
could happen in those files. There would be some disadvantage with
formatting though.
listing the files in a dir gives a more concise view than scrolling
through a file, and more customizable view (eg -ltr to find latest added)

On Tue, Nov 30, 2021 at 2:22 PM Andrew Gettelman @.***>
wrote:

If we are using YAML already for scripts (and easier to edit) suggest we
stick with it and not add a file format to ADF as Brian suggests.
I am ambivalent to one file per variable or not. Easier to customize as
Brian notes, but harder to manage.
Maybe a compromise is a format where there is one file with a 'block' for
each variable that could contain any number of things (so could be
customized). E.g.:
var1

attribute1 = X
attribute2 = "Y"

var2

attribute3 = Z
attribute2 = "Q"

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/NCAR/ADF/issues/50#issuecomment-983031690, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AHLJVQCA7BVSIKHA67JTRLDUOU57XANCNFSM5GRBE35A
.

I started to work on an example, but haven't made it very far yet. I think for now I will just use one YAML file, but that can easily be broken into multiple files if that turns out to be better/preferred. For the example, I won't even touch the "library" code that is the main structure of ADF; I'll just put in a YAML file and modify one of the plotting examples. That'll be more of a proof of concept. Realistically, I might be able to make progress on this on Friday; if anyone wants to beat me to it, please do and let me know.

@brianpm : thanks for diving into this. If there is something I can do to help, let me know. I probably can't do much except test and modify a template, but happy to help if I can. This would certainly help help new users to contribute to the hackathon and enable us to rapidly build out a usable package. Thanks!

Thanks for working on this @brianpm!  I agree that having a single YAML file in the format that @andrewgettelman laid out is a good idea, at least as a starting place.  @bitterbark raised some valid concerns, but there may be potential workarounds to at least some of those issues that we could implement using the YAML file itself if need be.
Otherwise, please let me know if you need any help or assistance!  Also, if you end up making some progress but then need to stop work on it please let me know and I might be able to get it over the finish line.  Just let me know if that situation arises.
Thanks!

This is addressed by https://github.com/NCAR/ADF/pull/80


Merge get-chatter-access.js and get-streamer-access.js

Currently with having those 2 files there is a lot of duplicate code, because the only difference between those files are the scopes. Maybe we can use the readline module to first ask if a chatter or streamer token is wanted and handle it accordingly

Other idea is to keep those two files but run an exported function from a merged file. So like the following for example:

get-chatter-access.js calls getAccountAccess(true) in get-account-access.js
get-streamer-access.js calls getAccountAccess(false) in get-account-access.js


Windows Build ENOENT Error.

Hi, I'm trying to build my app for windows from a mac.
These are my scripts, the Electron-packager version is 4.1.2:
"build-mac": "electron-packager ./ MyApp --platform=darwin --arch=x64 --version=0.28.1"
"build-win": "electron-packager ./ MyApp --platform=win32 --arch=x64 --version=0.28.1"
"build-win": "electron-packager ./ MyApp --platform=win32 --arch=ia32 --version=0.28.1"

The build for mac goes right, contrariwise both the builds for Windows gave me this error (just change the arch with x64, I modified slightly the output by masking directory paths):
Geyser:MyApp delvedor$ npm run-script build-win

><EMAIL_ADDRESS>build-win /.../.../MyApp
> electron-packager ./ MyApp --platform=win32 --arch=ia32 --version=0.28.1

Downloading electron-v0.28.1-win32-ia32.zip
[=================================================>] 100.0% of 38.79 MB (1.12 MB/s)
Packaging app for platform win32 ia32 using electron v0.28.1
[ { [Error: ENOENT, stat '/.../.../MyApp.app/Contents/Frameworks/Electron Framework.framework/Libraries/Libraries']
    errno: -2,
    code: 'ENOENT',
    path: '/.../.../MyApp.app/Contents/Frameworks/Electron Framework.framework/Libraries/Libraries' },
  { [Error: ENOENT, stat '/.../.../MyApp.app/Contents/Frameworks/Electron Framework.framework/Versions/Current/Libraries/Libraries']
    errno: -2,
    code: 'ENOENT',
    path: '/.../.../MyApp.app/Contents/Frameworks/Electron Framework.framework/Versions/Current/Libraries/Libraries' },
  { [Error: ENOENT, stat '/.../.../MyApp.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/Libraries']
    errno: -2,
    code: 'ENOENT',
    path: '/.../.../MyApp.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/Libraries' } ] undefined

npm ERR! Darwin 14.3.0
npm ERR! argv "node" "/usr/local/bin/npm" "run-script" "build-win"
npm ERR! node v0.12.0
npm ERR! npm  v2.7.6
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>build-win: `electron-packager ./ MyApp --platform=win32 --arch=ia32 --version=0.28.1`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build-win script 'electron-packager ./ MyApp --platform=win32 --arch=ia32 --version=0.28.1'.
npm ERR! This is most likely a problem with the myapp package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     electron-packager ./ MyApp --platform=win32 --arch=ia32 --version=0.28.1
npm ERR! You can get their info via:
npm ERR!     npm owner ls myapp
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!    /.../.../MyApp/npm-debug.log

And this is the npm-debug.log
0 info it worked if it ends with ok
1 verbose cli [ 'node', '/usr/local/bin/npm', 'run-script', 'build-win' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prebuild-win', 'build-win', 'postbuild-win' ]
5 info prebuild-win<EMAIL_ADDRESS>6 info build-win<EMAIL_ADDRESS>7 verbose unsafe-perm in lifecycle true
8 info<EMAIL_ADDRESS>Failed to exec build-win script
9 verbose stack Error<EMAIL_ADDRESS>build-win: `electron-packager ./ MyApp --platform=win32 --arch=x64 --version=0.28.1`
9 verbose stack Exit status 1
9 verbose stack     at EventEmitter.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:213:16)
9 verbose stack     at EventEmitter.emit (events.js:110:17)
9 verbose stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:14:12)
9 verbose stack     at ChildProcess.emit (events.js:110:17)
9 verbose stack     at maybeClose (child_process.js:1008:16)
9 verbose stack     at Process.ChildProcess._handle.onexit (child_process.js:1080:5)
10 verbose pkgid<EMAIL_ADDRESS>11 verbose cwd /../../MyApp
12 error Darwin 14.3.0
13 error argv "node" "/usr/local/bin/npm" "run-script" "build-win"
14 error node v0.12.0
15 error npm  v2.7.6
16 error code ELIFECYCLE
17 error<EMAIL_ADDRESS>build-win: `electron-packager ./ MyApp --platform=win32 --arch=x64 --version=0.28.1`
17 error Exit status 1
18 error Failed at the<EMAIL_ADDRESS>build-win script 'electron-packager ./ MyApp --platform=win32 --arch=x64 --version=0.28.1'.
18 error This is most likely a problem with the myapp package,
18 error not with npm itself.
18 error Tell the author that this fails on your system:
18 error     electron-packager ./ MyApp --platform=win32 --arch=x64 --version=0.28.1
18 error You can get their info via:
18 error     npm owner ls myapp
18 error There is likely additional logging output above.
19 verbose exit [ 1, true ]

It sounds like you need to ignore the output directories for previously generated packages. For example, add --ignore=MyApp.app.

It works, thank you!

@malept This is still broken if you add an icon file!
electron-packager ./ Report --platform=all --arch=x64 --version=0.31.1 --ignore=Report.app --overwrite --out=app --icon=docicon.icns
Packaging app for platform darwin x64 using electron v0.31.1
Packaging app for platform linux x64 using electron v0.31.1
Packaging app for platform win32 x64 using electron v0.31.1
spawn wine ENOENT

electron-packager ./ Report --platform=all --arch=x64 --version=0.31.1 --ignore=app --overwrite --out=app --icon=docicon.icns
Packaging app for platform darwin x64 using electron v0.31.1
Packaging app for platform linux x64 using electron v0.31.1
Packaging app for platform win32 x64 using electron v0.31.1
spawn wine ENOENT

Same thing as before, just using the command originally in this ticket and adding my icon file.
electron-packager ./ MyApp --platform=win32 --arch=x64 --version=0.31.1 --ignore=MyApp.app --overwrite --icon=docicon.icns
Packaging app for platform win32 x64 using electron v0.31.1
spawn wine ENOENT

cc @maxogden

@kylebrowning this is a different problem.

spawn wine ENOENT

This means that you do not have Wine installed.

@malept Thanks for clarification.


Extend templates

I have some problems extending the @SyliusShop/Checkout/Address/_form.html.twig Template. Because of the CompilerPass in PrometeeSyliusVIESClientPlugin, the common way to override templates is not working.
Is there an good way to override the form template without writing my own CompilerPass?

Normally you just have to add a new twig file into /templates/bundles/SyliusShopBundle/Checkout/Address/_form.html.twig and it will be overrode.
The CompilerPass used into PrometeeSyliusVIESClientPlugin is just a quick way to override the Sylius base template letting the user override it into /templates/bundles/*.
The file your are mentioning is not used into this plugin maybe you forgot to cache:clear because the list of overrides are built during the warmup, so if you add or delete an overrode file you should clear the cache.

Oh it was the wrong file. I mean @SyliusShop/Common/Form/_address.html.twig
I have a file in the /templates/bundles/* folder but after installing the plugin it is not recognized anymore.

Let me retest it

I have no easy way to avoid copying those templates overrides so I delete the CompilerPass, add a new section into the README to explain how to copy those overrides, and I move src/Resources/views/overrides/* one folder up.
New release is coming

Good solution. Thank you!


merge from opensuse

I planned to use opencc to convert zh_CN translations for yast/zypper to zh_TW, in order to fill the unmaintained zh_TW branch.
Here're the words I picked when manually comparing the human-translated text.

@marguerite ping?


Testing 2.7 windows build failure fix.

Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #542 (a3926f9) into 2.7 (74f3bc8) will increase coverage by 0.01%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##              2.7     #542      +/-   ##
==========================================
+ Coverage   32.65%   32.66%   +0.01%
==========================================
  Files         135      135
  Lines        4015     4016       +1
  Branches      695      695
==========================================
+ Hits         1311     1312       +1
  Misses       2564     2564
  Partials      140      140

see 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


serve mongodb on local server

https://github.com/mlp6/Medical-Software-Design/blob/master/Lectures/databases/examples/mongo/mongo-example.ipynb

Set up mongoldb on local machine (VM) successfully - completed


Generic Method Pattern: Handled

Microsoft preferred in the base app IsHandled instead of Handled.
I think this should be adapted in the generic method pattern examples.

Makes sense .. Pullrequest? 😉

Here it is!
#49


-Woverloaded-virtual warnings

When adding a GCC warning -Woverloaded-virtual I see following warnings:
grep 'was hidden' build.log  | sort  | uniq
./core/os/dir_access.h:74:17: warning: 'virtual String DirAccess::get_next(bool*)' was hidden [-Woverloaded-virtual]
./core/script_language.h:170:18: warning: 'virtual Variant ScriptInstance::call(const StringName&, const Variant&, const Variant&, const Variant&, const Variant&, const Variant&)' was hidden [-Woverloaded-virtual]
./core/script_language.h:172:15: warning: 'virtual void ScriptInstance::call_multilevel(const StringName&, const Variant&, const Variant&, const Variant&, const Variant&, const Variant&)' was hidden [-Woverloaded-virtual]
./editor/plugins/abstract_polygon_2d_editor.h:132:15: warning: 'virtual void AbstractPolygon2DEditor::_action_set_polygon(int, const Variant&)' was hidden [-Woverloaded-virtual]

I'm also attaching full build log:
build.txt
Note that the issue can cause serious issues as explained here:
https://isocpp.org/wiki/faq/strange-inheritance#hiding-rule

./editor/plugins/abstract_polygon_2d_editor.h:132:15: warning: 'virtual void AbstractPolygon2DEditor::_action_set_polygon(int, const Variant&)' was hidden [-Woverloaded-virtual]

That's a bug from #11019, cc @poke1024 @guilhermefelipecgs @groud.
_action_set_polygon(int p_idx, const Variant &p_polygon) isn't even defined, but it is used in various places which would likely produce wrong behavior if they end up calling _action_set_polygon(int p_idx, const Variant &p_previous, const Variant &p_polygon) (I don't think they do since there would be arity mismatch, but that means calls to _action_set_polygon(int p_idx, const Variant &p_polygon) don't add any polygon.

./core/script_language.h:170:18: warning: 'virtual Variant ScriptInstance::call(const StringName&, const Variant&, const Variant&, const Variant&, const Variant&, const Variant&)' was hidden [-Woverloaded-virtual]
./core/script_language.h:172:15: warning: 'virtual void ScriptInstance::call_multilevel(const StringName&, const Variant&, const Variant&, const Variant&, const Variant&, const Variant&)' was hidden [-Woverloaded-virtual]

CC @bojidar-bg @neikeq, I think you're more qualified than I am to handle this one.

I'm not sure how to test this. Is this still valid on master?

I'm not sure how to test this. Is this still valid on master?

Just add -Woverloaded-virtual somewhere next to "-Wlogical-op" in SConstruct.


Document precedence of Select and SelectAll when multiple futures ready

When future::Select and future::SelectAll have >1 futures ready, the first one will be picked (meaning the leftmost "future A" in the former, and the zero:th fut in the latter case). I'm not sure if this is a feature.
In the select! macro however, order is randomized at runtime (this is certainly a feature).
(There's a separate discussion to be had about the behavior, let's keep this one about the documentation).
I suggest we either document that a specific order can be assumed, or that no order can be assumed.

@betamos Thanks for sending #1641! Are you also interested in sending PRs for the existing Select and SelectAll combinator docs?


Error: linc_discord_rpc.cpp
C:\HaxeToolkit\haxe\lib\discord_rpc\git\linc\linc_discord_rpc.h(7): fatal error C1083: Cannot open include file: '../lib/discord-rpc/include/discord-rpc.h': No such file or directory

reinstall discord_rpc


Sizes struct and Colordata simplified with clone?

Hello!
I've recently tried to implement the Colordata struct (corresponding to libraw_colordata_t), and I had what I would call a "good idea".
Right now we form the Sizes struct (our libraw_image_sizes_t) by copying all of the structs members individually. That's a lot of typing. What I ended up doing was removing sizes.rs, replacing it's pub use in lib.rs with pub use libraw_sys::libraw_image_sizes_t as Sizes; and forming it in rawimage.rs by cloning the struct, unsafe { (*self.processor.inner).sizes }.clone().
I think this is a sane way to not have to type out all the colordata members, but maybe there's some giant issue I'm missing.
Do you think this is okay to do? All the tests passed and my project that uses libraw-rs worked perfectly fine.
(I can make a PR with relevant changes if my blabbering above didn't make much sense.)

Re-exporting structs from libraw-rs-sys could work for the simpler ones. I think the issue starts when we look at structs like libraw_data_t, which contain raw pointers, or libraw_processed_image_t, which contains C-like enums. These structs shouldn't be exposed to the user as-is, so for the sake of consistency I'm thinking we should probably avoid re-exporting any of the libraw-rs-sys structs from libraw-rs. This would also make them a bit easier to read, without having to think what types like ushort mean.

Re-exporting structs from libraw-rs-sys could work for the simpler ones. I think the issue starts when we look at structs like libraw_data_t, which contain raw pointers, or libraw_processed_image_t, which contains C-like enums. These structs shouldn't be exposed to the user as-is, so for the sake of consistency I'm thinking we should probably avoid re-exporting any of the libraw-rs-sys structs from libraw-rs. This would also make them a bit easier to read, without having to think what types like ushort mean.

Alright, that makes a lot of sense! I'll write the Colordata struct like Sizes, then.

Alright, that makes a lot of sense! I'll write the Colordata struct like Sizes, then.


Fix some warnings in examples/translation

These were some unused function and variable warnings.

Thanks, that's a work in progress hence the warning, I should have put this on a separate branch. Hopefully it will be all good in the next few days.


How can I scroll in only one direction?

Why always scroll horizontally and vertically at the same time? How can I scroll in only one direction? Most of the time just want to scroll in one direction.

It's my own problem..

how you have solved?

spreadView.isDirectionalLockEnabled = true


HSEARCH-3158 Define default index name and possibility to have index type

Add possibility to define Indexed Type Name for hibernate-search-elasticsearch by defining a new attribute type in @Indexed
Force hibernate-search-elasticsearch to use type as name if it defined or simple class name (without package)

Can one of the admins add this person to the trusted builders? (reply with: "add to whitelist" or "ok to test")

add to whitelist

@tbounsiar that's brilliant, thanks!
In this version though I'd prefer to not add an Elasticsearch specific attribute to the @Indexed annotation. We will improve the API in version 6 but so far we need to be very conservative.
May I suggest you to define this same attribute in a configuration property scoped by index name?
It could be for example
hibernate.search.default.elasticsearch.index_type x

which makes it overrideable for each index:
 hibernate.search.[indexname].elasticsearch.index_type y

Incidentally, the build failed because @apiNote is not a valid javadoc.

@Sanne  thank you for comment and your suggestion, but i think if we add hibernate.search.default.elasticsearch.index_type  to configuration it will be applied to all Entities, and we will have conflicts.

Thanks for the contribution, but as Sanne mentioned, this feature is inherently Elasticsearch-specific and we'd rather not introduce ES-specific bits in the common, abstract API.
Also, there are other problems related to the fact that metadata can also be provided through a programmatic mapping API, so we can't just use Java reflection to get it, we have to go through an abstraction layer. It's a bit complex, but if you want to have a look at how it's done, see org.hibernate.search.indexes.impl.IndexManagerHolder#getIndexName. Basically you need to use the ReflectionManager to turn the class to an XClass.
Sanne's configuration properties idea would indeed be a problem when you have multiple type mappings in a single index, so for now it's not an option. That being said, Elasticsearch 6.0 and above only allow one type per index, and our plans so far are to follow the same path in Hibernate Search 6.0 (i.e. allow only one type per index, even with Elasticsearch 5 and below or in embedded Lucene mode).
So, theoretically, we could make this a configuration property in 6. For now, in the Search 6 prototype, the type name is hardcoded, because I didn't see the point of naming the type if there's only one per index.
I think there's a more general problem we should think about in Search 6, though: passing backend-specific mapping options to the backend through a mapping API that is inherently backend-independent. I added a section about this to the "TODO" document for Search 6.
As to Search 5... I can only see two solutions:

Go with the configuration properties idea, but format the property key differently so that it's type-scoped. Something like hibernate.search.[fully-qualified class name].elasticsearch.index_type y instead of hibernate.search.[indexname].elasticsearch.index_type y
Use a separate, Elasticsearch-specific annotation, and add an SPI for the Elasticsearch integration to access this annotation.

EDIT: Submitted my comment too fast... Conclusion below.
Personally, I'd rather go with the configuration property idea (solution 1), since that's how most other Elasticsearch-specific features work. And the Elasticsearch-specific annotations (solution 2) would introduce a lot of complexity if we want to preserve them in 6, where we may support mapping data that doesn't come from POJOs...
@tbounsiar If you want to give it a try, know that index options are provided through org.hibernate.search.elasticsearch.impl.ElasticsearchIndexManager#initialize. Don't hesitate to ask if you need some guidance.

Hello @yrodiere, thanks for comments, i will take a look.

@tbounsiar regarding my previous suggestion: you're right, it shouldn't be coupled 1:1 to the index of course. Sorry I was in a hurry that day and didn't think clearly :+1:
I agree with @yrodiere 's summary and the preference for option 1.
There's a third option to consider:

don't have this feature in 5.x

I'm happy to have this in 5.x if the solution is doable and there are practical benefits. However I haven't understood if there are strong benefits?
The fact that 5.x doesn't have a perfect Elasticsearch mapping yet is no secret, that's why we are changing many APIs 6 in and why its integration is currently documented as experimental.
In short, happy to solve what's possible in 5.x - even with a "dirty" workaround if it's important for people - but let's not waste time on an itch to make the mapping perfect as it will never be in 5.x.
On the other hand, I expect it will take about a year to release 6 so if it's important for you then we're happy to help.
I hope that makes sense..

We thought about this use case and created this ticket to handle backend-specific, index-scoped configuration in Hibernate Search 6: https://hibernate.atlassian.net/browse/HSEARCH-3306
The implementation would be very different from this PR, though, so I will close this PR.
If you're interested in contributing this feature to Search 6, feel free to reach out to us and we'll help you getting started.


Do not attempt to transition before routing is ready

Currently, the ApplicationRouteMixin maps the session service's events to methods on the mixin (and thus the application route) in init. This leads to the problem that when the session is authenticated in an acceptance test before any route was visited (and the routing system is ready), the session service's event will be triggered which will cause a method on the application route to be called which will attempt a transition although the routing system is not ready yet. See this writeup of the series of steps by @0xadada.
We could maybe only map the session service's events to methods on the application route (via the ApplicationRouteMixin) in the activate method (as opposed to init) which I assume would only be called after the routing system is ready but that might potentially lead to errors in edge cases… This needs some further investigation but is generally something that should be cleaned up.

Spent the last couple of days researching this because it's affecting our application.
How can I help?

@alexander-alvarez  what does your test look like?

@0xadada https://github.com/alexander-alvarez/ember-cli-qunit-service-registering/compare/572fae2#diff-6902ce6b3192309e4080d20541f6fbfd

This should not happen when you're using the new acceptance test helpers introduced with 1.5.0. In order to fix this, the first thing to try would be moving the mapping of session service events from the init method to the activate method I think - if anyone wants to jump in and try that.

@alexander-alvarez I'm confused. Your test component invalidates the session upon init hook, then tests that yes is output, when no should be output because the session is not authenticated (because you called invalidate).

@alexander-alvarez per @marcoow, try the new test helper:
tests/integration/components/my-component-test.js:
import { authenticateSession } from 'ember-simple-auth/test-support';

then
-this.owner.register('service:session', Service.extend({
-      isAuthenticated: true,
-      invalidate() {
-        assert.ok(true);
-    }
-}));
+authenticateSession({
+        userId: 1,
+        otherData: 'some-data'
+});

@0xadada  yes I understand. The example test case is just a POC to assert whether my service or the actual service was being called.  So if I get a session authenticated error, the service I've defined isn't being called, but if everything is all green, then my service is being called (which should happen).
sorry for the confusion brought up by the test semantics.

@alexander-alvarez

the service I've defined
as in, the service you stubbed in the test?

correct. The "right-ness" I was evaluating was "here's this thing i've defined in the test, it should be used" not the specific logic of the test case.

fixed by #1547


Added new resource to Crash reporting & Tracking

Added Shake as a new resource to the "Crash reporting & Tracking" section.

Any update on this?

@aritraroy any update on this? thanks so much :)


libsql returning 502 on prod

LibsqlError: SERVER_ERROR: Server returned HTTP status 502
at mapHranaError (/var/task/node_modules/@libsql/client/lib-cjs/hrana.js:287:16)
at HttpClient.execute (/var/task/node_modules/@libsql/client/lib-cjs/http.js:87:48)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async m (/var/task/.next/server/chunks/651.js:6:3058)
at async /var/task/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:16:418
at async rP (/var/task/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:15:7978)
at async r5 (/var/task/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:18:1139)
at async ei (/var/task/node_modules/next/dist/compiled/next-server/server.runtime.prod.js:16:26320)
at async es.responseCache.get.routeKind (/var/task/node_modules/next/dist/compiled/next-server/server.runtime.prod.js:17:1026)
at async r3.renderToResponseWithComponentsImpl (/var/task/node_modules/next/dist/compiled/next-server/server.runtime.prod.js:17:508) {
code: 'SERVER_ERROR',
rawCode: undefined,
digest: '1139740358',
[cause]: HttpServerError: Server returned HTTP status 502
at errorFromResponse (/var/task/node_modules/@libsql/hrana-client/lib-cjs/http/stream.js:367:12)
at /var/task/node_modules/@libsql/hrana-client/lib-cjs/http/stream.js:256:24
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
status: 502
}
}

suddenly it started returning an 502 error, but I couldn't reproduce locally, only in prod
link to repo

i was trying to use zod's asyncSafeParse in a schema that didn't manage async functions mb


copyAs does not override events?

while copyAs does override helpers, it does not override events. is there a way to do this?

copyAs makes a new template that copies all helpers, events, and hooks from the source template. After you copy, any helpers, events, or hooks you add will go onto the copy only. It's not clear what this issue is without a reproduction, so I'm closing this

Actually, I think this might be referring to the fact that the event map is an array, so if you call events with the same key as already defined in the copied template, it will add another event for that rather than overwriting the first. I will clarify in the docs


Add a random string to skip packagist json cache

Why using cached packagist.json is bad?

In my current case - 5 hours left, still no updates. If I add some param I get the updated JSON

Does new version show on Packagist website? If it does, but not available via API then it's something wrong with Packagist API.

Yes, It does, instantly after the tag

You can report a bug to the https://github.com/composer/packagist then. Keep this issue open just in case.

I think this is the same bug as in https://github.com/humbug/phar-updater/pull/10

still have problem

I'm fine to merge and release it in 1.x if a PR is provided


Why are species and their chromosomes hardcoded ?

Rather than having a species argument referring to genome data in code, why not let this argument take a two column file (chromosone name, chromosome length) and parse it to let users process data of any genome.
In its current state the tool is limited to the set of species defined in GenomeData.py, making editing the source code necessary to treat any other species.
Cordially,
Adrien V.

Perhaps parsing a JSON file into a python dictionary in the same format as those in GenomeData.py would allow a simple way to provide a custom genome.

Even Json seems needlessly complicated. It's only two variables: chromosome name and length. 1 column less than a bed file. These are the only variables that are retrieved from the species argument from what i can tell.
A parser that reads the first two columns of a file would even be able to use samtools fasta indexes as an input.
Even easier for the user would be to just have the fasta be the input file and parse it to get chromosome name and length.
The preset species could also be kept for compatibility. 1 file each in a folder in the library and then look first in this folder for .tab and if not found then treat it as a path to a custom species table.


Handle out of scope dances

Description
This PR handles out  of scope dances
Fixes #341
Type of change
Please check the options that are relevant.

[x] Bug fix (non-breaking change that fixes an issue)
[ ] Proposes a change (non-breaking change that isn't necessarily a bug)
[ ] Refactor
[ ] New feature (non-breaking change that adds a new functionality)
[ ] Breaking change (fix or feature that would break some existing functionality downstream)
[ ] This is a unit test
[ ] Documentation only change
[ ] Datasets Release
[ ] Models Release

Type of requested review

[ ] I want a thorough review of the implementation.
[x] I want a high level review.
[ ] I want a deep design review.

Before and After
If this PR introduces a change or fixes a bug, please add before and after screenshots (if this is causes a UX change) or before and after examples(this could be plain text, videos etc ) to demonstrate the change.
If this PR introduces a new feature, please also add examples or screenshots demonstrating the feature.
Testing
Tested with repro'ing the command locally
Checklist:

[x] I have performed manual end-to-end testing of the feature in my environment.
[ ] I have added Docstrings and comments to the code.
[ ] I have made changes to existing documentation where needed.
[ ] I have added tests that show that the PR is functional.
[ ] New and existing unit tests pass locally with my changes.
[x] I have added relevant collaborators to review the PR before merge.

@aszlam Made the change, could you re-review please ?


Determining shared information

@hangyin2020 @zman811 I make the following calls to the  API:

GET to /products/:product_id
GET to /products/:product_id/styles

Shared information

GET to /products/:product_id
GET to /products/:product_id/styles

I make the following calls to the API:

GET to /products/:product_id
GET to /products
GET to /products/:product_id/styles
GET to /products/:product_id/related

I am working to add the following calls to the API:

GET to /reviews/meta?product_id, and then I will get a response, from which
get the response.ratings, something similar to:
"ratings": {
"1": "61",
"2": "57",
"3": "146",
"4": "118",
"5": "308"
}

and then loop through all ratings and calculate a value, for example, 4.2 then I will have

yup, I just found it in his Ratings, still learning what he is doing there haha

i send
GET : reviews/meta:id, /products/productid and one to get the reviews which I don't think is shared or I could make shared anyways

how about let me make it work on my end first and then we can talk about to share it tomorrow if we need to?


Why no_bias=True in Conv layers?

Why there is no_bias=True for conv layer?

because there is BN after every conv, and BN has bias, it should have the same effect, another no_bias=True will decrease the calc.

@tornadomeet OK, thanks.


If non existent frame and a refreshImg() is called, PyVexr crashes

If there is no frame // frame index in the timeLineDict and a refresh img is called, the PyVexr crashes
Easy to reproduce, load a single EXR, go out of range (next frame forward), and call an expo up or saturation tweak
Traceback (most recent call last):
File "pyVexr_gui.py", line 109, in mouseReleaseEvent
widget.refreshImg()
File "pyVexr_gui.py", line 1539, in refreshImg
shot =  self.timeLineDict[currentPos]["shot"]
KeyError: 1

This appens through the mouse scrubbing :
   File "pyVexr_gui.py", line 109, in mouseReleaseEvent     widget.refreshImg()   File "pyVexr_gui.py", line 1534, in refreshImg     shot =  self.timeLineDict[currentPos]["shot"] KeyError: 1
But also through the keypresses frame forward and backward :
   File "pyVexr_gui.py", line 154, in keyPressEvent     widget.jumpFrameForward()   File "pyVexr_gui.py", line 1127, in jumpFrameForward     if self.imgDict["buffer"][toCheckBuffer] != None: IndexError: list index out of range
Need to fix both methods.
PyVexr is trying to find a frame outside of the timeLineDict, and therefore also out of the imgDict["buffer"].

Fixed this issue in the following commit :
https://github.com/mteillet/PyVexr/commit/17edacff446210dd3b045907c810269f70148c22
Will be part of the next release


Extended format

Add support for a JSON format that support all of "keys", "newImage" and "oldImage" if they are defined, plus the eventName and other metadata fields.
Fixes typos and incompatibility between NEW_IMAGE and REMOVE events.

I thought these changes may be useful for people using this plugin. Will try to get the update on rubygems by other means.

hey @alexef haven't had time to review this. Can you give a briefly description what you wanted to achieve with this?. So I can better understand without following the code.

Hi @marcosnils !
Currently, there is no way to get both new and old images in JSON format. This PR introduces an "extended" format that will convert from Dynamodb internal format into plain JSON. This is useful for indexing both images in Elasticsearch, without going through extra filters.
Additionally, it fixes a typo and a wrong assumption that an image is always available (wrong if the event type is REMOVE).
I saw that you are the owner of the gem https://rubygems.org/gems/logstash-input-dynamodb/versions/2.0.5-java that's why I made the PR here. The upstream repo @awslabs looks dead.

k. that makes sense. I guess the missing part would be to add tests and it's good to merge.


Pip tools and pytest integration

This PR does the following

Uses pip-tools to manage dev dependencies

Helps avoid conflicts
Unpinned most of dependencies

Creates alias so tests can be ran via python setup.py test
Basic Makefile for easier development
coverage report on test runs

I'm just going to close this given all the changes are already in #71


[pthreads] Build error VS2022 arm64-windows-static

Package: pthreads[core]:arm64-windows-static -> 3.0.0#11
Host Environment

Host: arm64-windows
Compiler: MSVC 19.34.31921.1
vcpkg-tool version: 2022-10-12-b586c2752f75bcc3f6a243749e9a0d94d0d93ccd
vcpkg-scripts version: a2261f65e 2022-10-14 (2 days ago)

To Reproduce
vcpkg --triplet arm64-windows-static install pthreads
Failure logs
-- Using cached pthreads4w-code-v3.0.0.zip.
-- Extracting source C:/vcpkg/downloads/pthreads4w-code-v3.0.0.zip
-- Applying patch fix-arm-macro.patch
-- Applying patch use-mt.patch
-- Using source at C:/vcpkg/buildtrees/pthreads/src/49e541b66c-5fd69e67f1.clean
-- Building arm64-windows-static-rel
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:96 (message):
    Command failed: "C:/Program Files/Microsoft Visual Studio/2022/Preview/VC/Tools/MSVC/14.34.31921/bin/Hostarm64/arm64/nmake.exe" -f Makefile all install DESTROOT="C:\\vcpkg\\packages\\pthreads_arm64-windows-static"
    Working Directory: C:/vcpkg/buildtrees/pthreads/src/49e541b66c-5fd69e67f1.clean
    Error code: 2
    See logs for more information:
      C:\vcpkg\buildtrees\pthreads\nmake-build-arm64-windows-static-release-out.log
      C:\vcpkg\buildtrees\pthreads\nmake-build-arm64-windows-static-release-err.log

Call Stack (most recent call first):
  ports/pthreads/portfile.cmake:39 (vcpkg_execute_required_process)
  scripts/ports.cmake:147 (include)

C:\vcpkg\buildtrees\pthreads\nmake-build-arm64-windows-static-release-out.log
	"C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.34.31921\bin\Hostarm64\arm64\nmake.exe" /E clean VC-static
	if exist *.obj del *.obj
	if exist *.def del *.def
	if exist *.ilk del *.ilk
	if exist *.pdb del *.pdb
	if exist *.exp del *.exp
	if exist *.map del *.map
	if exist *.o del *.o
	if exist *.i del *.i
	if exist *.res del *.res
	if exist *_stamp del *_stamp
	cd tests && "C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.34.31921\bin\Hostarm64\arm64\nmake.exe" clean
	if exist *.dll erase *.dll
	if exist *.lib erase *.lib
	if exist _ptw32.h erase _ptw32.h
	if exist pthread.h erase pthread.h
	if exist semaphore.h erase semaphore.h
	if exist sched.h erase sched.h
	if exist *.e erase *.e
	if exist *.i erase *.i
	if exist *.obj erase *.obj
	if exist *.pdb erase *.pdb
	if exist *.o erase *.o
	if exist *.asm erase *.asm
	if exist *.exe erase *.exe
	if exist *.manifest erase *.manifest
	if exist *.pass erase *.pass
	if exist *.bench erase *.bench
	cl /errorReport:none /nologo /MT /I. /DHAVE_CONFIG_H /W3 /O2 /Ob2  /D__PTW32_STATIC_LIB /D__PTW32_BUILD_INLINED /D__PTW32_CLEANUP_C /Fopthread.o -c pthread.c
pthread.c
	rc /d__PTW32_ARCHARM64 /d__PTW32_RC_MSC /d__PTW32_CLEANUP_C version.rc
Microsoft (R) Windows (R) Resource Compiler Version 10.0.10011.16384

Copyright (C) Microsoft Corporation.  All rights reserved.

version.rc(132) : error RC2104 : undefined keyword or key name: __PTW32_VERSIONINFO_DESCRIPTION

C:\vcpkg\buildtrees\pthreads\nmake-build-arm64-windows-static-release-err.log

Microsoft (R) Program Maintenance Utility Version 14.34.31921.1
Copyright (C) Microsoft Corporation.  All rights reserved.

Microsoft (R) Program Maintenance Utility Version 14.34.31921.1
Copyright (C) Microsoft Corporation.  All rights reserved.

Microsoft (R) Program Maintenance Utility Version 14.34.31921.1
Copyright (C) Microsoft Corporation.  All rights reserved.

NMAKE : fatal error U1077: '"C:\Program Files (x86)\Windows Kits\10\bin\10.0.22621.0\\arm64\rc.EXE"' : return code '0x1'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.34.31921\bin\Hostarm64\arm64\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.34.31921\bin\Hostarm64\arm64\nmake.exe"' : return code '0x2'
Stop.

Is this fix solution from upstream?

Hi @Cheney-W.
No, the latest release of pthreads (v 3.0.0) was in 2018. Seems like this has to be made into a patch that changes version.rs, just like other arm fixes e.g. fix-arm-macro.patch.

Fixed by PR #27299.


Treemap support

Hello,
I love your library. Could you please create an implementation for treemaps?
They have a certain grace for representing proportions that pie charts just don't have.

I saw this issue is closed... Should I give up on my dream of treemaps with this library?

I saw this issue is closed... Should I give up on my dream of treemaps with this library?

Oh, not really!
We are changing the way we manage the issues, all that are triaged will be closed, but with the "needs votes" label, so you can +1 to it. This will create a ranking and show what is more needed by the community!

+1

+1

Oh, you need to click on the emoji of the issue and hit the +1 there!

OK. Just gave it a thumbs up.


Prevents references to nonexistant converstion object.

Fixes bug where Dispatch may reference a non-existent conversation object.

Since this PR touches the case creation hot path, could you locally test each case creation variation (via Slack, UI, and Signal Ingest) locally?

I believe this PR resolve the issue, https://github.com/Netflix/dispatch/pull/4092/files


hubble metric

Signed-off-by: Akshit42-hue<EMAIL_ADDRESS>Fixes #947

Hey @aanm, please do have a look :)

The corresponding issue was fixed in #955. Thanks for your contribution.


nightly-build version encountered an error: Assertion `!(srcMmaLayout && dstMmaLayout) && "Unexpected mma -> mma layout conversion"' failed

compile this script:
https://github.com/openai/triton/blob/main/python/tutorials/06-fused-attention.py
error is:

what's your GPU? Triton Flash attention only works on sm_80+...

what's your GPU? Triton Flash attention only works on sm_80+...

Emmm I'm sorry, my GPU architecture doesn't meet the requirements. Thank you for your reply!


Fix warnings generated by purescript 0.8.0

This is a breaking change, so I'll wait until the core libraries are updated, and merge everything together.


Syntax highlighting within ES6 template strings

Description
Is it possible to apply syntax highlighting (in my case HTML) to ES6 template strings? Take for example, an angular 1.x component file:
(function () {
    "use strict";

    angular.module("app").component("example", {
        template: `
            <div layout="row" layout-align="end center">
                <md-button class="md-raised md-default">Cancel</md-button>
                <md-button class="md-raised md-primary">Submit</md-button>
            </div>
        `,

        controller: function () {
            var ctrl = this;
        }
    });
})();

Relevant issue on the Atom GitHub: https://github.com/TypeStrong/atom-typescript/issues/818

That's highly specific to your use-case, but should be possible with nested modes. You could have a look at the JSX mode for inspiration.


Support aiobotocore >= 1.0

There are some forward compatibility issues with the new aiobotorcore package.  I've temporarily restricted the hsds build to use the old version (see: https://github.com/HDFGroup/hdf-docker/commit/e17a34671ba75edca7e42fe77a66363a567bf4b1), but code should be updated to use the newer version.

The latest version of aiobotocore is now supported.


Error in Tests [TypeError: Cannot read property 'scrollTop' of null]

[ x] The issue is present in the latest release.
[x ] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
Hi, I'm using the Tabs component and passing all the props that I require using my own wrapper component. Everything is working fine except when I add scrollable prop to the component.
const returnScrollable = () => {
  const [value, setValue] = useState(0);
  const handleChange = (event, newValue) => {
    setValue(newValue);
  };

  return (
    <>
      <Tabs
        tabItems={tabItemsScrollable} //array of tabs
        onChange={handleChange}
        value={value}
        variant="scrollable"
        scrollButtons="auto"
      />
    </>
  );
};

This works as it's supposed to be without any errors on the console but when I run tests through Jest of updating the snap-shots using storybook, I'm getting an error.
    Error: Uncaught [TypeError: Cannot read property 'offsetHeight' of null]
Error: Uncaught [TypeError: Cannot read property 'scrollTop' of null]
The above error occurred in the <ScrollbarSize> component:
        in ScrollbarSize (created by ForwardRef(Tabs))
        in div (created by ForwardRef(Tabs))
        in ForwardRef(Tabs) (created by WithStyles(ForwardRef(Tabs)))
        in WithStyles(ForwardRef(Tabs)) (created by SBTabs)
        in header (created by ForwardRef(Paper))
        in ForwardRef(Paper) (created by WithStyles(ForwardRef(Paper)))
        in WithStyles(ForwardRef(Paper)) (created by ForwardRef(AppBar))
        in ForwardRef(AppBar) (created by WithStyles(ForwardRef(AppBar)))
        in WithStyles(ForwardRef(AppBar)) (created by SBTabs)
        in div (created by SBTabs)
        in SBTabs (created by WithStyles(SBTabs))
        in WithStyles(SBTabs) (created by BaseStoryScrollable)
        in BaseStoryScrollable

Expected Behavior 🤔
The tests should pass just like it does when the scrollable prop is not passed on the Tabs component.

Steps to Reproduce 🕹

Steps:

Create a component using Tabs and try Jest snap-shot testing it.

Context 🔦

Your Environment 🌎

Tech
Version

Material-UI
v4.3.1

React
16.9.0

Browser
Chrome

TypeScript
NA

etc.

@Technologeek Thanks for opening this issue, this is related to #17070 and how we should improve our testing guide. I think that it's a topic we have already discussed in #16523. The solution we went for is to test all our components with:
import ReactTestRenderer from 'react-test-renderer';

ReactTestRenderer.act(() => {
  ReactTestRenderer.create(<Foo />, {
    createNodeMock: node => {
      return document.createElement(node.type);
    },
  });
});

+80% of our components are passing this test. We will work on raising it to 100%. The ones that don't are the components using react-transition-groups or mounting a Portal. It's not the case of the tabs.
I assume that you are using @storybook/addon-storyshots: https://storybook.js.org/docs/testing/structural-testing/, https://github.com/storybookjs/storybook/tree/master/addons/storyshots/storyshots-core.
Looking at the sources, it leads me to: https://github.com/storybookjs/storybook/blob/v5.2.0-beta.39/addons/storyshots/storyshots-core/src/frameworks/react/renderTree.js.
Alright, it seems that part of the solution is documented in: https://github.com/storybookjs/storybook/tree/master/addons/storyshots/storyshots-core#using-createnodemock-to-mock-refs.
Could you try the following?
import ReactTestRenderer from 'react-test-renderer';
import initStoryshots, { snapshotWithOptions } from '@storybook/addon-storyshots';

initStoryshots({
  test: snapshotWithOptions({
    renderer: storyElement =>
      ReactTestRenderer.act(() => {
        ReactTestRenderer.create(storyElement, {
          createNodeMock: node => {
            return document.createElement(node.type);
          },
        });
      }),
  }),
});

or
import initStoryshots, { snapshotWithOptions } from '@storybook/addon-storyshots'

initStoryshots({
  test: snapshotWithOptions({
    createNodeMock: (node) => {
      return document.createElement(node.type);
    },
  }),
})

@oliviertassinari Thanks a lot for your quick reply! As far as my use-case is concerned, I'm not getting any console-errors or warnings and the component seems to pass all other tests. I could apply your suggestion but it is not needed at the moment. We have multiple such third party elements which fail tests due to ForwardRefs but the component works great without any console errors. For now, I prefer to just ignore that story. If it helps anybody, this is how you ignore a story..
//In your storyshots.test.js file
import initStoryshots from "@storybook/addon-storyshots";

initStoryshots({
  storyKindRegex: /^((?!.*?NameOfYourStory).)*$/
});

Thanks again for your help!

Hey @oliviertassinari just wanted to say that the solution you provided with act and createNodeMock worked and helped out with our tests
Thanks 🙏

@carloscuesta Thanks for the feedback! Now, we need to update the testing guide: #17070. Any help would be appreciated.

this is also happening when using the unstable_createMuiTheme
Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

Check the render method of `Transition`.
    in Content (created by Transition)
    in Transition (created by ForwardRef(Grow))
    in ForwardRef(Grow) (created by ForwardRef(StrictModeGrow))
    in ForwardRef(StrictModeGrow) (created by ForwardRef(Snackbar))
    in div (created by ClickAwayListener)
    in ClickAwayListener (created by ForwardRef(Snackbar))
    in ForwardRef(Snackbar) (created by WithStyles(ForwardRef(Snackbar)))
    in WithStyles(ForwardRef(Snackbar)) (created by Snackbar___c2)
    in Snackbar___c2 (created by Snackbar)

Uncaught TypeError: Cannot read property 'scrollTop' of null
    at reflow (utils.js:2)
    at Object.handleEnter [as onEnter] (Grow.js:48)
    at Transition.performEnter (Transition.js:260)
    at Transition.updateStatus (Transition.js:231)
    at Transition.componentDidMount (Transition.js:174)

this is also happening when using the unstable_createMuiTheme

If you use this theme you need to make sure that children of transition components forward their refs to the outermost DOM node. The original plan was to add documentation for this but there were other StrictMode issues that weren't fixable so I didn't pursue this beyond internal usage.
Would greatly appreciate it if someone would add docs for unstable_createMuiTheme with caveats to https://material-ui.com/customization/theming:

unstable_ means use at your own risk and not in production
seriously don't use this in production. It only removes deprecation warnings.
children of transition components need to forward their refs (maybe with example for Drawer)

thanks for this explanation, now I know how to fix this
I'm using it only in Dev to test how it goes

import initStoryshots, { snapshotWithOptions } from '@storybook/addon-storyshots'

initStoryshots({
  test: snapshotWithOptions({
    createNodeMock: node => document.createElement(node.type),
  }),
})

This works fine for me. Thank you!

this is also happening when using the unstable_createMuiTheme
Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

Check the render method of `Transition`.
    in Content (created by Transition)
    in Transition (created by ForwardRef(Grow))
    in ForwardRef(Grow) (created by ForwardRef(StrictModeGrow))
    in ForwardRef(StrictModeGrow) (created by ForwardRef(Snackbar))
    in div (created by ClickAwayListener)
    in ClickAwayListener (created by ForwardRef(Snackbar))
    in ForwardRef(Snackbar) (created by WithStyles(ForwardRef(Snackbar)))
    in WithStyles(ForwardRef(Snackbar)) (created by Snackbar___c2)
    in Snackbar___c2 (created by Snackbar)

Uncaught TypeError: Cannot read property 'scrollTop' of null
    at reflow (utils.js:2)
    at Object.handleEnter [as onEnter] (Grow.js:48)
    at Transition.performEnter (Transition.js:260)
    at Transition.updateStatus (Transition.js:231)
    at Transition.componentDidMount (Transition.js:174)

Sooo, how fix it?

import initStoryshots, { snapshotWithOptions } from '@storybook/addon-storyshots'

initStoryshots({
  test: snapshotWithOptions({
    createNodeMock: node => document.createElement(node.type),
  }),
})

This works fine for me. Thank you!

I'm not really sure I understand what the internal problem is, but the code above didn't work for me.
It's crashing on the Zoom component:
  const transitionDuration = {
    enter: theme.transitions.duration.enteringScreen,
    exit: theme.transitions.duration.leavingScreen,
  };

    <Zoom in={true} timeout={transitionDuration} unmountOnExit>

I have the same issue when using Menu component. It seems a problem with Grow, but I really don't understand the problem. The children of Menu is a MenuItem which uses forwardRef internally, but I get exactly the same error:
Uncaught TypeError: Cannot read property 'scrollTop' of null
    at reflow (utils.js:2)
    at Grow.js:70
    at Object.onEnter (Grow.js:62)
    at Transition.performEnter (Transition.js:262)
    ...

My code:
return (
    <Menu
      {...menuProps}
    >
      <MenuItem onClick={handler}>
        {otherChildren}
      </MenuItem>
    </Menu>
);

this is also happening when using the unstable_createMuiTheme
Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

Check the render method of `Transition`.
    in Content (created by Transition)
    in Transition (created by ForwardRef(Grow))
    in ForwardRef(Grow) (created by ForwardRef(StrictModeGrow))
    in ForwardRef(StrictModeGrow) (created by ForwardRef(Snackbar))
    in div (created by ClickAwayListener)
    in ClickAwayListener (created by ForwardRef(Snackbar))
    in ForwardRef(Snackbar) (created by WithStyles(ForwardRef(Snackbar)))
    in WithStyles(ForwardRef(Snackbar)) (created by Snackbar___c2)
    in Snackbar___c2 (created by Snackbar)

Uncaught TypeError: Cannot read property 'scrollTop' of null
    at reflow (utils.js:2)
    at Object.handleEnter [as onEnter] (Grow.js:48)
    at Transition.performEnter (Transition.js:260)
    at Transition.updateStatus (Transition.js:231)
    at Transition.componentDidMount (Transition.js:174)

Same happened to me after upgrading to v5.0.0-alpha when I use createMuiTheme this way:
createMuiTheme({
  components: {
    MuiPaper: {
      defaultProps: { component: ForwardedRefComponent },
    },
  },
});

Later, some of my Menu elements crash with exactly same error as quoted.
I really don't understand why this occurs, as I DO use forwardRef for component prop, but the error still occurs.

@mui-org/core  I found this error when testing codemod migration with material-ui-store and takes a while to figure out what's wrong. Here is what I think we can help making migration smoother

prevent the crash in Transition (no transition) and display warning that the child should have forwardRef
no change, only add info to TroubleShoot section in migration docs about how to fix it.
add separate codemod for wrapping the component file by forwardRef (dev need to run file by file)

which options do you think it is worth to do?

@siriwatknp This issue is about the lack of ref in the test environment (react-test-renderer). I think that the issue you are talking about is related but different. I'm not sure we should discuss it here. Maybe it should happen in a new issue with a reproduction?

@siriwatknp This issue is about the lack of ref in the test environment (react-test-renderer). I think that the issue you are talking about is related but different. I'm not sure we should discuss it here. Maybe it should happen in a new issue with a reproduction?

Okay, will create a new issue with reproduction.

For me, issue occurs even in browser. It's very rare so I'm not able to reproduce. Probably happens after the Tabs are unmounted, which means that not all calls to updateScrollButtonState() are cleared properly. Also updateScrollButtonState is provided as callback in imperative handler so with calling action.updateScrollButtons() after lifecycle ended you can easily shoot yourself in the foot.
TypeError
Cannot destructure property 'scrollTop' of 'H.current' as it is null.

https://sentry.io/share/issue/8026280039644d4f9a4784928818290f/
Could we check  that tabsRef.current !== null in the beginning of updateScrollButtonState() function? So that calling updateScrollButtonState() would be safe.

For me, issue occurs even in browser. It's very rare so I'm not able to reproduce. Probably happens after the Tabs are unmounted, which means that not all calls to updateScrollButtonState() are cleared properly. Also updateScrollButtonState is provided as callback in imperative handler so with calling action.updateScrollButtons() after lifecycle ended you can easily shoot yourself in the foot.
TypeError
Cannot destructure property 'scrollTop' of 'H.current' as it is null.

https://sentry.io/share/issue/8026280039644d4f9a4784928818290f/
Could we check that tabsRef.current !== null in the beginning of updateScrollButtonState() function? So that calling updateScrollButtonState() would be safe.

Yes, I could detect it too on Sentry. It happens on Chrome Browser at least:
Cannot destructure property 'scrollTop' of 'be.current' as it is null.
I suspect the Tabs component too.

Could we check that tabsRef.current !== null in the beginning of updateScrollButtonState() function? So that calling updateScrollButtonState() would be safe.

Feel free to submit a PR.

With the switch to the Intersection Observer API for handling scroll button visibility since @mui/material version 5.14.2, I believe the error should no longer occur.


fix(datepicker): make touch UI calendar use 80% of width in portrait mode

fixes #5834

Lint error is not related to this PR, must've been part of an already merged PR. I'll rebase to see if its been fixed yet.

@mmalerba Should be fixed by: https://github.com/angular/material2/pull/5945


Dynamic slides loading

Thank you for the project. It's very great! Are you expecting to add a support for dynamic image loading/deleting. In January on stackoverflow you said that the slider doesn't support changing the number of pictures it operates on dynamically. Would you consider adding such support?

Hi guy!
I also want to make dynamic slider with this awesome library but it seem does not support.
Do you have any update on this?
Thank

@purepure You can dynamically fill html code and then initialize jssor slider.

yes, it can be. But in my case, I use javascript to load list of image then display. There are about 5 lists, each list contains difference amount of image. So it mean I have to initialize jssor everytime. Even I tried this way, but it still get error.
Is there any sample about this ?

For now, you need to initialize it every time. I will improve this feature to allow adding/removing slide later.
Note that when jssor slider initialize, it will reformat the hierarchy of raw html elements in the slider1_container. It is not reusable then, you need to remove and then repopulate the whole slider1_container to initialize the second slider.

I tried to re-init it every time but still get error. The list can repopulate success but cannot work (scroll,...). I am afraid I wrong somewhere. At least as you said, it can be dynamic
Thank

Not only repopulate the slide list, you'd repopulate the whole slider element.

got that point. I will try again. Thank


SAMZA-2332: [AM isolation] YarnJob should pass new command and additional environment variables for AM deployment

@shanthoosh FYI

@shanthoosh FYI

Just to make sure we are on the same page: The changes for SQL aren't going to immediately leverage general split deployment, because SQL does not want to make general split deployment a dependency right now. Eventually, SQL would converge to using general split deployment, but not right now.

@cameronlee314 Yup. @shanthoosh had a question about whether AM split deploy will continue working when we move planning to the AM, or if there would be further changes required.


Add security link for the user to check before starting the verification

https://www.idenfy.com/security/

Verified
IOS 18
version 4.0.0
Idenfy is now updated KYC is added to Threefold connect app
link is added in the first step in verification after you verify your email and mobile number

testcase


Make Lore capitalized

It shows up on the nav bar, and it was between "Status" and "About", so
it looked weird to be in all lower case.

Build failed.

http://logs.bonnyci.com/check_github/BonnyCI/bonnyci.org/19/1487016943.19/bonnyci.org : FAILURE in 24s


Add Open LaTeX Studio Version Number to About Page

Add the version number to the About page.

In my proposed fix (mentioned above), the app version string is hardwired into the ApplicationUtils class, probably this is not the best approach, but it might work for now.

Hello @stefansbv
Please open a pull request if you consider the issue finished. We will then proceed with review and/or testing.

Hello @sebbrudzinski
Done, thank you.

Fixed by @stefansbv  Thanks!


Basic authentication sample in test project

Please could someone create a working sample using Basic authentication (documentation and swagger UI)?
Doing a search gives a lot of conflicting samples, none of which seem to work with the .NET Core project.

See below configuration and accompanying Document Filter to enable Basic auth for all operations. If you need to assign more granular security requirements then use an Operation Filter instead.
// Startup.cs
services.AddSwaggerGen(c =>
{
    c.SwaggerDoc("v1",
        new Info
        {
            Version = "v1",
            Title = "Swashbuckle Sample API"
        }
    );

    c.AddSecurityDefinition("basic", new BasicAuthScheme { Type = "basic" });
    c.DocumentFilter<BasicAuthDocumentFilter>();
});

// BasicAuthDocumentFilter.cs
{
    public void Apply(SwaggerDocument swaggerDoc, DocumentFilterContext context)
    {
        var securityRequirements = new Dictionary<string, IEnumerable<string>>()
        {
            { "basic", new string[] { } }  // in swagger you specify empty list unless using OAuth2 scopes
        };

        swaggerDoc.Security = new[] { securityRequirements };
    }
}

@domaindrivendev  u rocks!

this also works:
                c.AddSecurityDefinition("basic", new BasicAuthScheme {Type = "basic", Description = "basic authentication" });                 c.AddSecurityRequirement(new Dictionary<string, IEnumerable<string>> {                 { "basic", new string[] { } },});


Where is the caffe.proto file ?

Hello,
In the README, I'm trying to find the proto folder containing this file but it's not there?
Thanks!

This refers to a file in the Caffe repository and not this repository, since you'll need to compile these into Caffe.
https://github.com/BVLC/caffe/blob/master/src/caffe/proto/caffe.proto
I can't guarantee that this still works with the latest version though, since this was written a few years ago.


onSubmit vs handleSubmit

using 6.0.0-rc.3
The way this works is pretty confusing. The docs don't help much: http://redux-form.com/6.0.0-alpha.4/docs/faq/HandleVsOn.md/ (i get the naming convention, but the way it works below is confusing)
not sure why this works:
parentComponent.js
handleLoginAttempt(values) {
    console.log(values);
}

render() {
  return (
    // HERE 1: prop name is "onSubmit", won't work if named "handleSubmit"
    <LoginForm onSubmit={this.handleLoginAttempt} {...this.props}/>
  );
}

formComponent.js
// HERE 2: why handleSubmit but not onSubmit like we named it above ?
const { handleSubmit } = this.props;
  return (
     <form className="login-form" onSubmit={handleSubmit}>
...

handleSubmit is a part of redux-form that will automatically look for and onSubmit prop and run it.

@OKNoah is there anyway to get around this? Default defaultProps or anything similar? I don't really have a desire for the component that houses this form to know anything about the form... but the way this is architected, I have no choice

I found this very confusing as well, as it relied on the user/developer knowing this convention; Would be great to use any prop name to define the handler function. Can imagine it is doing a handleSubmit null check to decide if to use async form submission atm?


Fix buggy testing process of test_from_xpublic_key

Fix buggy testing process
Public Key should not support hard derivations.
see bip-0032 Implications

The derivation process has been verified by iancoleman
can be testing.
BIP39 Mnemonic
avocado harsh input rack like desert mask nominee left atom original tower shy barely base
Account Extended Public Key
xpub6CnRmcvtuVkmYV7UrPbrrhpJaor6iy5cFLQHdsgYQsfz9338T6Wqy3vHP1MXCEPMKzq1C8fErhrGnzEYarzsF814HnCzNF6vqo9JiGjjvE2
Address
16W7JeQXEzmYKX8UMFMrg6FwNSPduVdYHo

Although they have the same path, the derived public key and private key are asymmetric, for example:
xprivate_key：m/44'/0'/0'/0/0
xpublic_key：m/44'/0'/0'/0/0

Due to the hardening derivation, the expected symmetric results cannot be obtained, even though they were initially symmetric.

Their paths are equal, and the public and private keys are also symmetric, for example:
xprivate_key：m/0/0
xpublic_key：m/0/0


1.1.1w still marked as dev in version info

It looks like README and include/openssl/opensslv.h were missed when the 1.1.1w tag was created yesterday.
Edit: CHANGES also has "[xx XX xxxx]", and NEWS "[under development]"

Actually it looks to me like the tag is on the wrong commit. Should be on e04bd3433f

That would do it

Fixed now.


code-gen(validator): sniff mimetypes when validating mime types

Instead of looking at the originalFilename

Since the validators are synchronous this shouldn't be done there, and we should probably advise to use something like https://github.com/sindresorhus/file-type instead.


Add -k option to closest

Closest will currently only report the closest hit. We want it to report the k closest hits.

Completed.


GeneSymbol, GeneName, GemmaId and NcbiId are not guaranteed to exist for getDatasetExpression endpoint

These columns are only generated if there is a file dump of the platform annotations, so gemma.R should not rely on their existence.
The only guaranteed columns (beside bioassays) are Probe and Sequence.
Relevant code in Gemma: https://github.com/PavlidisLab/Gemma/blob/ca0c625bda2feab9e6b6fca3deb95866ecf710a1/gemma-core/src/main/java/ubic/gemma/core/datastructure/matrix/MatrixWriter.java#L232-L256

Documentation update: https://github.com/PavlidisLab/Gemma/commit/902261d94dfb896020ec0e493a56ed0d38932c7f


Docs homepage needs banner linked to perl6.org

The problem
The way it is currently set up, the impression is given that The Docs are a different website than perl6.org.  Not having a prominent link to perl6.org is secluding unfamiliar guests from visiting perl6.org.  This choice is made even more obvious by how the banner currently just links to its self-same page.  So the "real-estate" is currently not being availed anyhow.
Suggestions
I propose that only the "homepage" of docs.perl6 have the banner click-able to the homepage of perl6.org.  All the other pages of docs.perl6.org can remain the same, and remain linked to the homepage of Docs.

Well, the banner links to the homepage, as it should. Maybe we can add a link somewhere else, or make Camelia link perl6.org.

Before acting on this, I'd like to hear more opinions about if this should be done, and if so, where. Please vote with thumbs up if you want a banner linked to perl6.org, thumb down if you don't.

See #1090 for a related issue

It's not raising a big response, but I guess it's mostly positive. Which begs the question: does it need to be a banner? That would need a major design change. What would be the best way of doing this?

Changes on things such as this need getting into htmlify.p6, thus refactoring it (#1823 ). This is less than awesome... A proper templating engine should be used, but I'm not sure there's one now in Perl 6


doc: document the required naming for models' constraints

Problem:
Since #65 It is necessary in some cases to explicitly name constraints as explained in #69. We need to document that. We should also say that the name should be less than 64 characters (see postgresql and mysql limitations) and that it should be as close as possible to the naming convention defined in shared.py
Note: the naming is needed both for models and alembic scripts.
Also the tests should be made with mysql. Postgresql seems to truncate the name by default so everything seems fine but it isn't.

@nharraud we can update the default naming scheme with function/class that check the length of the resulting name and raise and exception directly.
In [1]: class str_mod_limit(str):
   ...:
   ...:     def __mod__(self, *args, **kwargs):
   ...:         result = super(str_mod_limit, self).__mod__(*args, **kwargs)
   ...:         if len(result) > 64:
   ...:             raise RuntimeError('String limit reached')
   ...:         return result

@jirikuncar this would be a nice to have yes 👍
Just as a side note for the future implementation, the code should be if len(result) > 63 as it is "less than 64".
However I would do it after releasing invenio-db as it is. More and more PRs are being blocked because of invenio-db not being released (example: secret_key update feature), and we can't release it because some modules are still breaking the naming convention, which means users would not be able to test invenio-3/invenio-app-ils. I just finished investigating what needs to be done for those modules.

Closed by #97


perf: improve multi-thread synchronisation by using a thread pool

By adopting a thread pool, we can significantly reduce the overhead associated with dynamically spawning threads for each syncing operation we execute.

Can you specify which part of code needs the thread pool synchronization of this project I am new to this but would like to try my knowledge of rust.


GuzzleHttp\Promise\RejectionException ERROR when adding some items

Hi, we haven't changed our Any Cloud module, still running on 2.0.0 and Omeka S version 3.2.0, and we're getting this error that wasn't happening before when trying to add an item with media. I checked our Amazon Service credentials in the settings, which were correct. I also thought maybe it had to do with too large a file size at first, but that wasn't it. Any ideas as to why this is happening?  Note, this error happens when we run Omeka S on PHP 8, but the issue resolves if we roll back to PHP 7.4.
GuzzleHttp\Promise\RejectionException
The promise was rejected with reason: Invoking the wait callback did not resolve the promise
Details:
GuzzleHttp\Promise\RejectionException: The promise was rejected with reason: Invoking the wait callback did not resolve the promise in /home/schaffer/digitalcollections.union.edu/modules/AnyCloud/vendor/guzzlehttp/promises/src/functions.php:112
Stack trace:
#0 /home/schaffer/digitalcollections.union.edu/modules/AnyCloud/vendor/guzzlehttp/promises/src/Promise.php(75): GuzzleHttp\Promise\exception_for('Invoking the wa...')
#1 /home/schaffer/digitalcollections.union.edu/modules/AnyCloud/vendor/guzzlehttp/promises/src/Coroutine.php(65): GuzzleHttp\Promise\Promise->wait()
#2 /home/schaffer/digitalcollections.union.edu/modules/AnyCloud/vendor/guzzlehttp/promises/src/Promise.php(246): GuzzleHttp\Promise\Coroutine->GuzzleHttp\Promise{closure}(true)
#3 /home/schaffer/digitalcollections.union.edu/modules/AnyCloud/vendor/guzzlehttp/promises/src/Promise.php(223): GuzzleHttp\Promise\Promise->invokeWaitFn()
#4 /home/schaffer/digitalcollections.union.edu/modules/AnyCloud/vendor/guzzlehttp/promises/src/Promise.php(267): GuzzleHttp\Promise\Promise->waitIfPending()
#5 /home/schaffer/digitalcollections.union.edu/modules/AnyCloud/vendor/guzzlehttp/promises/src/Promise.php(225): GuzzleHttp\Promise\Promise->invokeWaitList()
#6 /home/schaffer/digitalcollections.union.edu/modules/AnyCloud/vendor/guzzlehttp/promises/src/Promise.php(62): GuzzleHttp\Promise\Promise->waitIfPending()
#7 /home/schaffer/digitalcollections.union.edu/modules/AnyCloud/vendor/aws/aws-sdk-php/src/S3/S3ClientTrait.php(34): GuzzleHttp\Promise\Promise->wait()
#8 /home/schaffer/digitalcollections.union.edu/modules/AnyCloud/vendor/league/flysystem-aws-s3-v3/src/AwsS3Adapter.php(611): Aws\S3\S3Client->upload('omekatest-union...', 'original/0412df...', Resource id #1221, 'public-read', Array)
#9 /home/schaffer/digitalcollections.union.edu/modules/AnyCloud/vendor/league/flysystem-aws-s3-v3/src/AwsS3Adapter.php(134): League\Flysystem\AwsS3v3\AwsS3Adapter->upload('original/0412df...', Resource id #1221, Object(League\Flysystem\Config))
#10 /home/schaffer/digitalcollections.union.edu/modules/AnyCloud/vendor/league/flysystem/src/Filesystem.php(102): League\Flysystem\AwsS3v3\AwsS3Adapter->write('original/0412df...', Resource id #1221, Object(League\Flysystem\Config))
#11 /home/schaffer/digitalcollections.union.edu/modules/AnyCloud/src/File/Store/AnyCloud.php(43): League\Flysystem\Filesystem->put('original/0412df...', Resource id #1221, Object(League\Flysystem\Config))
#12 /home/schaffer/digitalcollections.union.edu/application/src/File/TempFile.php(227): AnyCloud\File\Store\AnyCloud->put('/tmp/omekaZ0DJn...', 'original/0412df...')
#13 /home/schaffer/digitalcollections.union.edu/application/src/File/TempFile.php(238): Omeka\File\TempFile->store('original')
#14 /home/schaffer/digitalcollections.union.edu/application/src/File/TempFile.php(435): Omeka\File\TempFile->storeOriginal()
#15 /home/schaffer/digitalcollections.union.edu/application/src/Media/Ingester/Upload.php(62): Omeka\File\TempFile->mediaIngestFile(Object(Omeka\Entity\Media), Object(Omeka\Api\Request), Object(Omeka\Stdlib\ErrorStore))
#16 /home/schaffer/digitalcollections.union.edu/application/src/Api/Adapter/MediaAdapter.php(169): Omeka\Media\Ingester\Upload->ingest(Object(Omeka\Entity\Media), Object(Omeka\Api\Request), Object(Omeka\Stdlib\ErrorStore))
#17 /home/schaffer/digitalcollections.union.edu/application/src/Api/Adapter/AbstractEntityAdapter.php(630): Omeka\Api\Adapter\MediaAdapter->hydrate(Object(Omeka\Api\Request), Object(Omeka\Entity\Media), Object(Omeka\Stdlib\ErrorStore))
#18 /home/schaffer/digitalcollections.union.edu/application/src/Api/Adapter/ItemAdapter.php(257): Omeka\Api\Adapter\AbstractEntityAdapter->hydrateEntity(Object(Omeka\Api\Request), Object(Omeka\Entity\Media), Object(Omeka\Stdlib\ErrorStore))
#19 /home/schaffer/digitalcollections.union.edu/application/src/Api/Adapter/AbstractEntityAdapter.php(630): Omeka\Api\Adapter\ItemAdapter->hydrate(Object(Omeka\Api\Request), Object(Omeka\Entity\Item), Object(Omeka\Stdlib\ErrorStore))
#20 /home/schaffer/digitalcollections.union.edu/application/src/Api/Adapter/AbstractEntityAdapter.php(341): Omeka\Api\Adapter\AbstractEntityAdapter->hydrateEntity(Object(Omeka\Api\Request), Object(Omeka\Entity\Item), Object(Omeka\Stdlib\ErrorStore))
#21 /home/schaffer/digitalcollections.union.edu/application/src/Api/Manager.php(224): Omeka\Api\Adapter\AbstractEntityAdapter->create(Object(Omeka\Api\Request))
#22 /home/schaffer/digitalcollections.union.edu/application/src/Api/Manager.php(78): Omeka\Api\Manager->execute(Object(Omeka\Api\Request))
#23 /home/schaffer/digitalcollections.union.edu/application/src/Mvc/Controller/Plugin/Api.php(99): Omeka\Api\Manager->create('items', Array, Array, Array)
#24 /home/schaffer/digitalcollections.union.edu/modules/Collecting/src/Controller/Site/IndexController.php(71): Omeka\Mvc\Controller\Plugin\Api->create('items', Array, Array)
#25 /home/schaffer/digitalcollections.union.edu/vendor/laminas/laminas-mvc/src/Controller/AbstractActionController.php(77): Collecting\Controller\Site\IndexController->submitAction()
#26 /home/schaffer/digitalcollections.union.edu/vendor/laminas/laminas-eventmanager/src/EventManager.php(321): Laminas\Mvc\Controller\AbstractActionController->onDispatch(Object(Laminas\Mvc\MvcEvent))
#27 /home/schaffer/digitalcollections.union.edu/vendor/laminas/laminas-eventmanager/src/EventManager.php(178): Laminas\EventManager\EventManager->triggerListeners(Object(Laminas\Mvc\MvcEvent), Object(Closure))
#28 /home/schaffer/digitalcollections.union.edu/vendor/laminas/laminas-mvc/src/Controller/AbstractController.php(103): Laminas\EventManager\EventManager->triggerEventUntil(Object(Closure), Object(Laminas\Mvc\MvcEvent))
#29 /home/schaffer/digitalcollections.union.edu/vendor/laminas/laminas-mvc/src/DispatchListener.php(139): Laminas\Mvc\Controller\AbstractController->dispatch(Object(Laminas\Http\PhpEnvironment\Request), Object(Laminas\Http\PhpEnvironment\Response))
#30 /home/schaffer/digitalcollections.union.edu/vendor/laminas/laminas-eventmanager/src/EventManager.php(321): Laminas\Mvc\DispatchListener->onDispatch(Object(Laminas\Mvc\MvcEvent))
#31 /home/schaffer/digitalcollections.union.edu/vendor/laminas/laminas-eventmanager/src/EventManager.php(178): Laminas\EventManager\EventManager->triggerListeners(Object(Laminas\Mvc\MvcEvent), Object(Closure))
#32 /home/schaffer/digitalcollections.union.edu/vendor/laminas/laminas-mvc/src/Application.php(331): Laminas\EventManager\EventManager->triggerEventUntil(Object(Closure), Object(Laminas\Mvc\MvcEvent))
#33 /home/schaffer/digitalcollections.union.edu/index.php(21): Laminas\Mvc\Application->run()
#34 {main}

UPDATE:
Manually re-installing Any Cloud 2.0.0 seemed to have fixed the issue. We don't know exactly how, other than to chalk it up to some corrupted file in the plugin?

Since re-installing seems to fix the issue we will close this.


moving data off the lua stack entirely and into C++?

I only see references, objects, and the instruction to used shared pointer types in the docs so this question might be quite niche.
Essentially, I want to use scripting to return a UDT from lua and release ownership from the data created there. In my codebase, I have a very specific pipeline that ends with a pointer being de allocated a specific way. (think of a conveyor belt with no return!)
so something like
AbstractDevice* ScriptedDevice::OnExecute() {
    std::object obj = luaState["on_execute_impl"]();
    return obj->release(); // give me the pointer! (NOTE: program WILL delete when done!
}

and in the lua file
local function on_execute_impl
   return Engine.Devices.ExampleDevice.new() -- assume these namespaces and UDT are properly binded in my code
end

I'd rather have the ability to do this than refactor my code but I understand if that's what I'll have to do if this isn't possible.

I see that factories might be able to produce what I want. If I return a unique_ptr from the factory method, I could release() it later.
But how can I grab the unique ptr out of the lua state?
This fails for obvious reasons:
auto ptr = obj.as<std::unique_ptr<CardAction>>(); // no copies allowed...
AbstractDevice* device = ptr->release(); // what I want!

sol::object obj = luaState["on_execute_impl"]();
if (obj.valid()) {
     // notice the reference
     auto& ptr = obj.as<std::unique_ptr<CardAction>>();
     return ptr->release();
}
return nullptr;

// sol's optional, not the standard's
sol::optional<
     std::unique_ptr<AbstractDevice>& // Note the reference marker here
> maybe_device = luaState["on_execute_impl"]();
if (maybe_device.has_value()) {
     return maybe_device->release();
}
return nullptr;

auto& ptr = obj.as<std::unique_ptr<CardAction>();

still fails
attempting to reference a deleted function sol.hpp line 11800.
The second one:
U must be an lvalue
a value of type "sol::protected_function_result*" cannot be used to initialize an entity of type "std::unique_ptr<CardAction, std::default_delete<CardAction>>*"

'sol::optional<std::unique_ptr<CardAction, std::default_delete<CardAction>>&>::m_value' member could not be initialized
'initializing': cannot convert from '_Ty*' to 'T*'

in sol.hpp lines 5528-5529

Ah. Some funky interactions are stopping the 2nd one.
2 things:

Pull from the latest, I fixed a bug
Use the 1st example

Then you should be good to go.

are you the maintainer of the vcpkg of sol? That's what I was using.

Oh, no. I guess I'd have to send an update over there...

unfortunately I'm getting the same error.
I made sure I am now using the code from the latest commit b77f1a21020bc8a090081c69481b3fbb52c6b513
If it helps, I am building with C++17 on VS 2019 (Windows 10)
I have done the following:
  sol::object obj = script["execute_special_impl"](this);

  if (obj.valid()) {
  // as shown from https://github.com/ThePhD/sol2/commit/b77f1a21020bc8a090081c69481b3fbb52c6b513#diff-f31dfd6c1e73d3d45e20df66ecd2fffa7c093179004f631a023afda964f2fa26R723
    auto& ptr = obj.as<std::unique_ptr<CardAction>&>();
    return ptr.release();
  }

removed sol2 from my cmake. did a clear cache.
cloned sol2. Copied the single/include/sol header files and put them directly into my project source directory.
change my code as shown above

Error:
std::unique_ptr<CardAction, std::default_delete<CardAction>>::unique_ptr(const std::unique_ptr<CardAction, std::default_delete<CardAction>>&): attempting to reference a deleted function
So to be sure, I also did another round:

clear cmake cache,
ran single.py from the sol directory to ensure the contents of the header files were up to date!
complete project rebuild

And have the same error.


Add data tokens for link generation

3693002b0234a7df2c08be694b1514426e057c16
and
https://github.com/aspnet/Mvc/commit/27bdec40a6a26c83e8219b94f99c692f15dd126f


Investigate random fails with mod_proxy_balancer

Occasionally, there's a test failure due to a segmentation fault in mod_proxy_balancer tests. Find and fix the bug.

This is the corresponding log, I think
/usr/local/apache2
total 56
drwxr-xr-x  1 root root  4096 Jun 18 06:40 modules
drwxr-xr-x 14 root root 12288 Jun 18 06:40 manual
drwxr-xr-x  4 root root  4096 Jun 18 06:40 man
drwxr-xr-x  2 root root  4096 Jun 18 06:40 build
drwxr-xr-x  2 root root  4096 Jun 18 06:40 include
drwxr-xr-x  2 root root  4096 Jun 18 06:39 cgi-bin
drwxr-xr-x  2 root root  4096 Jun 18 06:39 logs
drwxr-xr-x  3 root root  4096 Jun 18 06:39 icons
drwxr-xr-x  3 root root  4096 Jun 18 06:39 error
drwxr-xr-x  2 root root  4096 Jun 18 06:39 htdocs
drwxr-xr-x  4 root root  4096 Jun 18 06:39 conf
drwxr-xr-x  2 root root  4096 Jun 18 06:39 bin
Starting httpd...
[Tue Jun 18 07:36:11.125108 2024] [manager:warn] [pid 13:tid<PHONE_NUMBER>96736] manager_init: can't find a ping/pong logic
[Tue Jun 18 07:36:11.126809 2024] [mpm_event:notice] [pid 13:tid<PHONE_NUMBER>96736] AH00489: Apache/2.4.59 (Unix) mod_cluster/2.0.0.Alpha1-SNAPSHOT configured -- resuming normal operations
[Tue Jun 18 07:36:11.126882 2024] [core:notice] [pid 13:tid<PHONE_NUMBER>96736] AH00094: Command line: '/usr/local/apache2/bin/httpd'

The issue should be fixed in the referenced commit.
The problem lied in missing lock around mod_proxy_balancer's workers managing function. That caused read_shared_by_node to fail (return NULL) sometimes because the balancer had number of workers set to 0 even though workers were present. (And because of that mod_manager reported some workers as NOTOK.)


Ignore no such container in testEnv.Clean

When moving the clean function there, this check was not ported and
generated some errors on the CI. deleteContainer now fail if any
error but the clean function won't if "no such container" (because of
some races -_-).
/cc @dnephin @cpuguy83 @thaJeztah @tonistiigi
🐸
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

@vdemeester erm,
14:54:52 # github.com/docker/docker/integration-cli
14:54:52 ./docker_utils_test.go:341: cannot use false (type bool) as type string in argument to deleteContainer


How to reverse it?

It would be nice to have a feature to reverse it.
For example:
var data = {
    apple: 'apple',
    bee  : 'bee'
}

ctrl+alt+r reverse it to
var data = {
    apple: 'apple',
    bee: 'bee'
}

I would use multi cursor on the semicolons. Select the first, then ctrl+d, then left_arrow then hit space so you should have:
var data = {
    apple : 'apple',
    bee   : 'bee'
}

Then shift+left_arrow to select all whitespace and then hit backspace

Great solution if it doesn't require the users to remember the shortcuts and hit the key so many times.

I guess I just find this sort of interaction to be second nature ever since I switched to sublime text some years ago. Atom and vscode adopted and extended this type of functionality


Make grammatical error corrections

@denpalrius Thank you for your contribution, I am merging this now and it should be live shortly, Thank you!

Thank you @steved0x. I see it live! It's a pleasure to contribute


Crash when attempting to split pane with insufficient space available

Environment
Windows build number: Microsoft Windows [Version 10.0.18362.175]
Windows Terminal version (if applicable):0.3.2171.0

Steps to reproduce

Map a key binding to splitHorizontal
Invoke the splitHorizontal key binding beyond the point where space is available for the split (~6-7 times)

NOTE: It also happens when splitting vertically but it appears to allow more before crashing.
Expected behavior
Worth discussing, but I'm guessing it would simply reject the command and perform a system beep (or some other indication of the failure)
Actual behavior
Application crash

I've confirmed that the root cause of the error is that splitting small panes results in a width/height of 0, which causes the DxRenderer to fail when creating the device resources.
I'd like to PR this if you don't mind. Here's my proposed implementation, but I'm happy to PR it as a spec if you think the issue warrants it:
App::_SplitPane will call focusedTab->CanAddHorizontalSplit/CanAddHorizontalSplit before it initializes the TermControl to avoid having to deal with the cleanup. If a split cannot occur, it will simply return. Question Should we beep or something here?
I'll follow the same naming conventions that already exist, so: Tab::CanAddHorizontalSplit -> Pane::CanSplitHorizontal ->Pane::_CanSplit. The public pane methods will handle leaf/child the same as the current Split methods.

If you're happy with my proposed design and don't think it needs a beep, I've submitted a PR.

Yea I definitely don't think we need a beep currently. We don't beep for anything else quite yet, so we could always add a (optional) beep here later when we add beeps to the rest of the app.
Good work with the PR!


DigitalTwin: Experience/Chat - Missing one part of the headphone

Missing one part of the Headphone
From AI File sent to @Vilnite

Done: Verified on Local