while getting n_gram_fingerprint_cluster data frame i am getting an exception.

I have a parquet file in HDFS and i am accessing it via optimus.load.parquet
after that i am performing keyCol.n_gram_fingerprint_cluster(df, "columnName", 3)
Please have a look at the stack trace below.
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/flask/app.py", line 2292, in wsgi_app
response = self.full_dispatch_request()
File "/usr/local/lib/python3.6/dist-packages/flask/app.py", line 1815, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/usr/local/lib/python3.6/dist-packages/flask/app.py", line 1718, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/usr/local/lib/python3.6/dist-packages/flask/_compat.py", line 35, in reraise
raise value
File "/usr/local/lib/python3.6/dist-packages/flask/app.py", line 1813, in full_dispatch_request
rv = self.dispatch_request()
File "/usr/local/lib/python3.6/dist-packages/flask/app.py", line 1799, in dispatch_request
return self.view_functionsrule.endpoint
File "/home/dimentrix/PycharmProjects/Optimus/OptimusSpark/start.py", line 93, in root
int(parameter.get('ngramSize')))
File "/usr/local/lib/python3.6/dist-packages/optimus/ml/keycollision.py", line 146, in n_gram_fingerprint_cluster
df = n_gram_fingerprint(df, col_name, n_size)
File "/usr/local/lib/python3.6/dist-packages/optimus/ml/keycollision.py", line 112, in n_gram_fingerprint
.cols.remove_accents(output_col)
AttributeError: 'function' object has no attribute 'split'

Hi @pallav1991,
I could replicate the error. I expect to send a patch today.


CodeIgniter Bypass

Hi Guys!
I had a chance to test CodeIgniter against XSS attack. I have found few things that might be interested for you guys:
I have created a test-bed here: http://xssplayground.net23.net/clean10.html
The area is protected by CodeIgniter but for testing purpose OUTPUT reflects in Standard HTML, Script, Attribute and URL context. In the following manner, in my test-bed output reflects in different context.
Output reflects here (Standard HTML Context): <?php echo cleanCode($_POST['name']); ?>

Output reflects in attribute context <div class='<?php echo cleanCode($_POST['name']);?>'>I am an attribute context

Output reflects in URL context <a href='<?php echo cleanCode($_POST['name']);?>'>I am URL context

Output reflects in script context
The following injection will BYPASS CodeIgniter in "attribute" and "URL" context:
'; onmouseover=confirm(location);//
OR
'; onmouseover=confirm(cookie);//
In CodeIgniter's black-list you guys are checking against "document.cookie" and "window.location". The same purpose can be achieved by using cookie and location word! In above cases, if I inject
'; onmouseover=alert(window.location);//
I got the following output which stops XSS:
Attribute context:

URL context:
Also in Chrome, the following injection bypassed URL context only:
j
a
vas
cript:confirm(1);
If I simply inject javascript:alert(1) then CodeIgniter works perfectly and removed javascript but in the above manner, injection works.
Let me know, if I missed something :)
Regards
@soaj1664ashar

As 2.x is open to XSS as described in this issue, I think it would be responsible to mention that is has known vuln/holes in the docs, as users are blindly trusting it atm and should not.

@RonnieSkansing We've just released version 2.2.1 with these and some other security fixes.
I'm closing this issue now that it's addressed in both version trees and it got hard to follow anyway. Thank you all.


Add CORS handling to query API

Requirement - what kind of business use case are you trying to solve?
I love jaeger I think it's a great tool,
I want to use jaeger data with Costume UI.
I think the best approach for me is to use HTTP JSON (internal) API

Problem - what in Jaeger blocks you from solving the requirement?
Without support CORS headers (Access-Control-Allow-Origin: *)
I can't use the query service from UI applications running on different hosts.

@yurishkuro do you think this is ok to move forward with?

sgtm


silx utils function

@pierrepaleo developed some functions that are actually on the gui interface for freeart.
It is actually being modified in order to deal with silx fbp.
On this code there is some function to compute the center of rotation of a sinogram, rescale intensity and enhance_contrast.
Do we want some (all ? ) of them to be moved to silx. It will probably interest some users.

+1

removed due to duplication with #1026


'save as' and 'open' styles

Ok!
I'm here again... updated to v 0.3.3 and the problem still there.
I create a style and when I save it which ever is the path I browse in it saves the style in the C: partition.
If I move the saved style to the path I need and then I try to open it, it says:
Couldn't open file at C:\Users\Stefano\Documents...\project.yml
It's becoming boring.

@Forna73 the fix didn't make it into the 0.3.3 release. Should come with the next one.
In the meantime could try to replace
C:\Program Files\mapbox-studio\resources\app\lib\middleware.js

with this:
https://raw.githubusercontent.com/mapbox/mapbox-studio-classic/b89994507338ae72540ebad74e9287d911420dbc/lib/middleware.js
and tell me, if it works for you?
Don't forget to make a backup of your existing middleware.js before replacing.

I'll let you know!
2015-11-23 16:27 GMT+01:00 Wilhelm Berg<EMAIL_ADDRESS>
@Forna73 https://github.com/Forna73 the fix didn't make it into the
0.3.3 release. Should come with the next one.
In the meantime could try to replace
C:\Program Files\mapbox-studio\resources\app\lib\middleware.js
with this:
https://raw.githubusercontent.com/mapbox/mapbox-studio-classic/b89994507338ae72540ebad74e9287d911420dbc/lib/middleware.js
and tell me, if it works for you?
Don't forget to make a backup of your existing middleware.js before
replacing.
—
Reply to this email directly or view it on GitHub
https://github.com/mapbox/mapbox-studio-classic/issues/1509#issuecomment-158967948
.

Hi!
No luck for me...
I opened a .txt file and copied all the script and them saved as .js
I'll wait  for the fix.
2015-11-23 16:27 GMT+01:00 Wilhelm Berg<EMAIL_ADDRESS>
@Forna73 https://github.com/Forna73 the fix didn't make it into the
0.3.3 release. Should come with the next one.
In the meantime could try to replace
C:\Program Files\mapbox-studio\resources\app\lib\middleware.js
with this:
https://raw.githubusercontent.com/mapbox/mapbox-studio-classic/b89994507338ae72540ebad74e9287d911420dbc/lib/middleware.js
and tell me, if it works for you?
Don't forget to make a backup of your existing middleware.js before
replacing.
—
Reply to this email directly or view it on GitHub
https://github.com/mapbox/mapbox-studio-classic/issues/1509#issuecomment-158967948
.

note: the fix @BergWerkGIS thought would address this was https://github.com/mapbox/mapbox-studio-classic/commit/b89994507338ae72540ebad74e9287d911420dbc and will be available in upcoming v0.3.4. So the next action is to have @Forna73 try and replicate again once v0.3.4 is officially released.

@Forna73 v0.3.4 is released now - can you please test again? If you hit the same issue please create a new ticket with details.


i18n: home, loading, checkurlbanner, basic notifications

Description
Added translation tags for home, loading, checkurlbanner, basic notifications components.
Related Ticket
https://github.com/KlimaDAO/klimadao/issues/157
Checklist

[X] Building the site with npm run build-site works without errors
[X] Building the app with npm run build-app works without errors
[X] I formatted JS and TS files with running npm run format-all

The loading component never shows on my computer, is it still needed?


Error in documentation example for .sbgrc file

In the Quickstart section of the documentation there is this example of an .sbgrc file:
[sbpla]
api-url = 'https://api.sbgenomics.com/v2'
auth-token = 700992f7b24a470bb0b028fe813b8100

[cgc]
api-url = 'https://api.sbgenomics.com/v2'
auth-token = 910975f5b24a470bb0b028fe813b8100

This example doesn't work (using a proper auth-token), because the URL should not be quoted. I'm using Python 3, apparently the issue does not come up in Python 2.

Will be fixed soon. Thank you for the report.

Hi @bjoernpollex
We fixed this in 0.2.0 release. You already communicated to me in another issue that you updated to that version so now there should be no problems.
Sorry for closing the ticket without communicating to you.


add ./nginx/pac:/usr/share/nginx/pac default share to webserver

let's organize default pac share and place sample pac file for proxying setup

that's seems to be mcloud or mcloud-agent (mcloud-android) sub-component which knows exactly all details about connected devices... otherwise we have to duplicate knowledge in both places which potentially leads to all kind of mismatch during upgrades etc.

moved to 2.0 to define valid location

it might be independent service related to mcloud-agent repo where we provide proxy_port for devices. there is no sense to duplicate the same values on global CE level because number of devices and locations almost uncontrollable.


segfault with incorrect let expression

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed.

Specifically, check out the wishlist, open RFCs,
or feature requests.

Reduced the issue to a self-contained, reproducible test case.

Description
Lean segfaults when an incorrect and overloaded let expression is given. (originally found by Tom Hales)
Steps to Reproduce
import data.vector
open vector

example (u : vector ℕ 2) : vector ℕ 2 :=
let [u1, u2] := u in
u

Expected behavior: Lean exits with error
Actual behavior: Segfault:
5:4: error: invalid pattern, 'choice (vector.cons u1 (vector.cons u2 vector.nil)) (list.cons u1 (list.cons u2 list.nil))' is overloaded, and this kind of overloading is not currently supported in patterns

Compilation segmentation fault (core dumped) at Mon Jul 17 13:07:10

Reproduces how often: 100%
Versions
Lean (version 3.2.1, commit 0579e68ab80b, Release). Ubuntu 16.04
Additional Information
The following does not give a segfault:
example (u : vector ℕ 2) : vector ℕ 2 :=
let (vector.cons u1 (vector.cons u2 nil)) := u in
u

A different question: is there a way to do something like this?

A different question: is there a way to do something like this?

We do not have any type information to disambiguate the choice expression at that point of processing. This could reasonably change with #1674.


Id mapping solution

https://github.com/biodiv-platform/cca/issues/83

Added id to solve null value template issue.

since I can't use permission with idmapping branch I'm going to merge this to staging for now


[13.0.x] ISPN-13421 Add approximate size metrics

https://issues.redhat.com/browse/JDG-4933
https://issues.redhat.com/browse/JDG-4270
Backport of https://github.com/infinispan/infinispan/pull/9693
Includes a fix for https://github.com/infinispan/infinispan/pull/9693#discussion_r799839741

Rebased and reworded the javadocs @oraNod.

Integrated into 13.0.x, thanks @danberindei ! Missing you already :(


Fix Typo in end to end CI config

Description
should be create not creace i presume
Tested
Other changes
n/a
Related issues
n/a
Backwards compatibility
I hope so

Thanks for catching my #dislexya


Add introduction to the resume

I'm Junior Software Test Engineer, looking for new opportunities to establish enjoyable career where I can use my hard and soft skills. I would like to find interesting and long-lasting project where I can improve my knowledge.  I enjoy testing, creating bug reports and retesting and I'm delighted when my bugs are fixed as I can see the results of my work. I would like to improve my technical skills, to test API, to work with backend. I strongly believe that learning something new, enhancing hard and soft skills, participating in webinars is crusial for Test Engineer.

Best regards
Aleksandr Raspopov


About total_step-1

Hi, I'm confused about this -1. It looks like a mistake to me. Can you explain the purpose?
https://github.com/lizhihao6/Forward-Warp/blob/27fe46cd766d960e10d07b3a3156816a8e63ed8e/Forward_Warp/cuda/forward_warp_cuda_kernel.cu#L35

It seems like a bug. Have you tried with total_step instead of total_step-1?

Yes, I use total_step. It seems ok.

Thx, I have fixed that.


Exception in _future_timeout_checker

I found this in my server logs, and I think it explains some of the stalls I've seen when calling executor.get_result:
- lithops.standalone.standalone[Thread-1] - standalone.py:201 - ExecutorID b36c9a-3 | JobID M000 - Remote log monitor started
2020-12-03 17:16:45,665 - INFO - lithops.standalone.standalone[Thread-1] - standalone.py:225 - ExecutorID b36c9a-3 | JobID M000 - Running job
2020-12-03 17:16:45,665 - INFO - lithops.standalone.standalone[Thread-1] - standalone.py:227 - View execution logs at /tmp/lithops/logs/b36c9a-3-M000.log
2020-12-03 17:16:45,920 - INFO - lithops.invokers[Thread-1] - invokers.py:151 - ExecutorID b36c9a-3 | JobID M000 - _load_ds() Invocation done - Total: 1 activations
2020-12-03 17:16:45,921 - INFO - lithops.executors[Thread-1] - executors.py:364 - ExecutorID b36c9a-3 - Getting results...
Exception in thread Thread-54:
Traceback (most recent call last):
  File "/opt/dev/miniconda3/envs/sm38/lib/python3.8/site-packages/lithops/wait/wait_storage.py", line 281, in _future_timeout_checker
    raise TimeoutError('HANDLER', msg)
TimeoutError: [Errno HANDLER] The function did not run as expected.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/dev/miniconda3/envs/sm38/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "/opt/dev/miniconda3/envs/sm38/lib/python3.8/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/dev/miniconda3/envs/sm38/lib/python3.8/site-packages/lithops/wait/wait_storage.py", line 290, in _future_timeout_checker
    pickled_exception = str(pickle.dumps(sys.exc_info()))
TypeError: cannot pickle 'traceback' object

It seems both wait_storage.py and wait_rabbitmq.py have this line: pickled_exception = str(pickle.dumps(sys.exc_info()))
sys.exc_info() returns a (exc_type, exc_value, exc_traceback) tuple, and the exc_traceback part can't be pickled. I noticed that Lithops includes the tblib library for adding support for pickling tracebacks, but tblib only seems to be installed on workers, not on the host.

@LachlanStuart I added the pickling_support in both wait_*.py files.
It's a bit weird because I ran some test forcing this exception, and in my case it  raises and pickles the exception correctly, and I didn't have the  pickling_support anywhere in my local machine.
In any case, it is  much better having it there to prevent possible pickling issues as in your case

Awesome, thanks @JosepSampe .
I find it a bit strange too. After finding this function exists, I'm surprised I haven't seen this exception message sooner, because I have been investigating cases where get_result has stalled and not recovered, even after several hours, due to unexpected VM shutdowns. This was the first time I saw this exception message, but I've had at least 2 other cases where there was no exception logged after 1 hour. I'll keep investigating.


feature_name V.01

This feature prints "hello world"

No instead of "hello world" say "hello I'm david"


"link" icon is displayed instead of the correct icon

I just updated Semantic UI, and I noticed that for some icons, when I want a link behaviour on my icon, I instead get the "link" icon.
<!-- Here, "link" icon is displayed instead of "retweet" icon -->
<i class="retweet link icon"></i>

I believe this is due to the "link" style definition overriding every previous single-named icon definition.

Either the name of the "link" icon or the "link" behaviour (pointer + opacity change on hover) has to change.

There shouldnt be an icon named link it should be linkify

This is fixed in next.


Added a warning admonition to the list of dependencies in the installation guide

Description
This PR adds a warning admonition in the documentation to notify users about potentially outdated dependencies listed in the requirements section. The change helps to ensure that users are aware that the dependencies listed may not be up-to-date and should be verified.
Fixes #4705
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[x] Documentation update (non-breaking change that modifies documentation)
[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)

Key checklist:

[x] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[x] All tests pass: $ python -m pytest (or $ nox -s tests)
[x] The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

Thanks, @RohitP2005!

Pleasure working with you

@agriyakhetarpal do u think, are there anything else that can be improved here


How to Move Model Files on an External Hard Drive?

How to Move Model Files on an External Hard Drive?
Due to insufficient internal storage on my Mac, I would like to store model files on an external hard drive to run them.

Set OLLAMA_MODELS to the path of where you want to store the models.  You can only have one path, so you need to have all models in the same place.  If you've already downloaded some models, copy them from the old path to the new path.

When I set the OLLAMA_MODELS into the ollama.service file, the systemctl restart is not work, ollama cannot restart, please give me some advice?

Server logs will help in debugging.

@jiushun If you are still having problems, open a new issue and add server logs.


Deny nil retrieve argument

The intent of this PR is to not make someone who passes nil as a value have to chase down a method missing on NilClass error but rather to be specific about what was provided.
@dkubb ready for review.

@tjchambers instead of pulling in a merge commit, I would suggest squashing these two commits using git rebase -i master. Make sure your master branch is up-to-date with the current upstream.

@tjchambers I have finished a pass over this code.

@dkubb I am unable so far to figure out a way with the current GIT branch stream to collapse the merge commit. I believe it has to do with how it looked before, but I would really appreciate you looking at my repo and giving me some insight into how to merge them. It is clear how there are 2 commits between Blockscore/master and this branches head. But that intermediate merge has 2 parents. ANy help would be much appreciated.

Added regex test for properly formatted resource arguments.
@dkubb ready for your re-review

@tjchambers the code looks good to me. I'm ready to merge, but it looks like CircleCI is stuck. I've asked @backus for access to CI so I can look into what is causing the problem.

@tjchambers Instead of working from a fork, I'd recommend working with normal branches within the project. It'll make things easier for us to collaborate. Technically you could grant me access to your repo, and when I need to rebase changes on top of master, I could do so, but it's just an extra layer of indirection.

@tjchambers This code will need to be rebased on top of master before it can be merged. I would do it myself, but I don't have access to your repo. Let me know when you've been able to rebase it so that the "Merge pull request" button becomes visible.
On another PR, it showed CircleCI as being required yet it was "stuck", but I was still able to merge it. That's a bit odd to me, I'm not sure why that was the case -- other projects I'm in have master locked, and it's not possible to circumvent and merge unless all checks have completed successfully.

The most plausible explanation of why the build is stuck is that CircleCI doesn't know how to build the commits from Tim's fork. CodeClimate seems to have no trouble though.
This won't be an issue once we're working in the same repo using feature branches.


Correct functionality? Naming not intuitive

I ran into this piece of code:
For bd, claim.AmountSold is stored in bought_amount and same for claim.AmountBought stored in sold_amount. I can't check it now, but this seems incorrect.
func (is *Session) tradeDetails(buyer, seller xdr.AccountId, claim xdr.ClaimOfferAtom) (bd map[string]interface{}, sd map[string]interface{}) {
	bd = map[string]interface{}{
		"offer_id":      claim.OfferId,
		"seller":        seller.Address(),
		"bought_amount": amount.String(claim.AmountSold),
		"sold_amount":   amount.String(claim.AmountBought),
	}
	is.assetDetails(bd, claim.AssetSold, "bought_")
	is.assetDetails(bd, claim.AssetBought, "sold_")

	sd = map[string]interface{}{
		"offer_id":      claim.OfferId,
		"seller":        buyer.Address(),
		"bought_amount": amount.String(claim.AmountBought),
		"sold_amount":   amount.String(claim.AmountSold),
	}
	is.assetDetails(sd, claim.AssetBought, "bought_")
	is.assetDetails(sd, claim.AssetSold, "sold_")

	return
}

You'll notice that we are producing two records, one for each trader.  When I trade with you, I buy with one currency to sell the other;  you do the inverse.


Environment: Fix glow hdr bleed scale being unused

The glow hdr bleed threshold was passed in its stead.
Fixed in master too with #40016.

TPS demo in 3.2.2-stable:

After this fix:

This "breaks compat" as before the Hdr Threshold value would be used (here 0.7) instead of Hdr Scale (here 2.0). But I think the visual difference is not too bad to be a deal-breaker for games that might rely on the bogus Environment for the look of their scene's glow.


Allow skipping of adding API key for etherscan

Is your feature request related to a problem? Please describe.
Getting started with MailChain is hard, lots of settings need adding. Etherscan seems to allow requests without an API key.
Describe the solution you'd like
If its not needed then remove the need for the API key
Describe alternatives you've considered
Creating an alternative for Etherscan
Additional context
https://etherscan.io/apis

Tasks

[ ] Allow skipping in mailchain init
[ ] Allow an empty passphrase
[x] Ensure that an empty API-Key will not cause problems

According to https://etherscancom.freshdesk.com/support/solutions/articles/35000022163-i-need-an-api-key, the limit applies to users who intend to exceed limits.
Mailchain calls the api every time we check the inbox.
Other solutions might be to proxy calls via an API that masks the mailchain api_key. A user who wishes to poll Etherscan can do by adding their own api-key.

I saw similar articles. Assuming it's done on an IP address to check the limit. It's difficult to maintain a service longterm built like that. They even call this out consistently with Note: The Ethereum Developer APIs are provided as a community service and without warranty, so please just use what you need and no more.

closed by #122


Build from source failed in MacOS

Hi,
I want to build from source in MacOS. Here's what I put in the command line
$ git clone https://github.com/deepmind/open_spiel.git
$ cd open_spiel/
$ ./install.sh
$ CXX=/usr/bin/clang++ CXXFLAGS="-std=c++17" ./open_spiel/scripts/build_and_run_tests.sh

Following the messages here and here
Here's the error message:
[some installation message, which seems fine] ...

Building and testing in /Users/andrew/UofT/open_spiel/build using 'python' (version 3.7.7).
-- The C compiler identification is AppleClang <IP_ADDRESS>01044
-- The CXX compiler identification is AppleClang <IP_ADDRESS>01044
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
Current build type is: Testing
BUILD_WITH_ACPC: OFF
BUILD_WITH_EIGEN: OFF
BUILD_WITH_HANABI: OFF
BUILD_WITH_JULIA: OFF
BUILD_WITH_LIBTORCH: OFF
BUILD_WITH_TENSORFLOW_CC: OFF
BUILD_WITH_PUBLIC_STATES: OFF
BUILD_WITH_PYTHON: ON
BUILD_WITH_XINXIN: OFF
BUILD_WITH_ROSHAMBO: OFF
BUILD_WITH_GAMUT: OFF
BUILD_WITH_ORTOOLS: OFF
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found Python3: /usr/local/bin/python3 (found version "3.7.7") found components: Interpreter Development Development.Module Development.Embed
Python include dirs: /usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/include/python3.7m
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/andrew/UofT/open_spiel/build
Building project
Scanning dependencies of target open_spiel_core
Scanning dependencies of target absl_strerror
[  0%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_strerror.dir/internal/strerror.cc.o
[  1%] Building CXX object CMakeFiles/open_spiel_core.dir/action_view.cc.o
[  2%] Linking CXX static library libabsl_strerror.a
[  2%] Built target absl_strerror
[  2%] Building CXX object CMakeFiles/open_spiel_core.dir/canonical_game_strings.cc.o
In file included from /Users/andrew/UofT/open_spiel/open_spiel/action_view.cc:15:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/action_view.h:20:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/spiel.h:36:
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:138:7: error: explicit specialization of 'value' in
      class scope
  int value() const {
      ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:142:10: error: explicit specialization of 'value' in
      class scope
  double value() const {
         ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:146:22: error: explicit specialization of 'value' in
      class scope
  const std::string& value() const {
                     ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:150:15: error: explicit specialization of 'value' in
      class scope
  std::string value() const {
              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:154:8: error: explicit specialization of 'value' in
      class scope
  bool value() const {
       ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:158:47: error: explicit specialization of 'value' in
      class scope
  const std::map<std::string, GameParameter>& value() const {
                                              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:162:40: error: explicit specialization of 'value' in
      class scope
  std::map<std::string, GameParameter> value() const {
                                       ^
Scanning dependencies of target absl_exponential_biased
[  2%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_exponential_biased.dir/internal/exponential_biased.cc.o
7 errors generated.
make[2]: *** [CMakeFiles/open_spiel_core.dir/action_view.cc.o] Error 1
make[1]: *** [CMakeFiles/open_spiel_core.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  3%] Linking CXX static library libabsl_exponential_biased.a
[  3%] Built target absl_exponential_biased
make: *** [all] Error 2
Exiting virtualenv

Some information of my machine:
$ cmake --version
cmake version 3.19.3

CMake suite maintained and supported by Kitware (kitware.com/cmake).

$ clang++ --version
Apple LLVM version 10.0.0 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin18.0.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

$ gcc --version
Configured with: --prefix=/Library/Developer/CommandLineTools/usr --with-gxx-include-dir=/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/c++/4.2.1
Apple LLVM version 10.0.0 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin18.0.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

I'ver referred to the issues from here and here, but still no luck.
Anyone has idea to help me out?

perhaps it's useful, my OS is macOS Mojave version 10.14

perhaps it's useful, my OS is macOS Mojave version 10.14

This is the longest recurring issue we have :( this is at least the 4th time it has been reported.
I really thought Clang 10 was high enough version; on Linux this seems to fix it, but it seems to happen on MacOS even with Clang 10.
I just compiled it last week on my new MacOS without a problem but I was using Clang 12.
I think upgrading XCode to version >= 11 should do it. I was using 10.3 before and never ran into this problem. What version do you have now?

This is the longest recurring issue we have :( this is at least the 4th time it has been reported.
I really thought Clang 10 was high enough version; on Linux this seems to fix it, but it seems to happen on MacOS even with Clang 10.
I just compiled it last week on my new MacOS without a problem but I was using Clang 12.
I think upgrading XCode to version >= 11 should do it. I was using 10.3 before and never ran into this problem. What version do you have now?

My macOS is version 10.14, so the latest Xcode that I can update to is 10.1
I remove the openspiel and re-run the commands again. Here's the error message:
Building project
Scanning dependencies of target absl_strerror
Scanning dependencies of target open_spiel_core
[  0%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_strerror.dir/internal/strerror.cc.o
[  1%] Building CXX object CMakeFiles/open_spiel_core.dir/action_view.cc.o
[  2%] Linking CXX static library libabsl_strerror.a
[  2%] Built target absl_strerror
Scanning dependencies of target absl_exponential_biased
[  2%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_exponential_biased.dir/internal/exponential_biased.cc.o
[  3%] Linking CXX static library libabsl_exponential_biased.a
In file included from /Users/andrew/UofT/open_spiel/open_spiel/action_view.cc:15:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/action_view.h:20:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/spiel.h:36:
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:138:7: error:
      explicit specialization of 'value' in class scope
  int value() const {
      ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:142:10: error:
      explicit specialization of 'value' in class scope
  double value() const {
         ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:146:22: error:
      explicit specialization of 'value' in class scope
  const std::string& value() const {
                     ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:150:15: error:
      explicit specialization of 'value' in class scope
  std::string value() const {
              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:154:8: error:
      explicit specialization of 'value' in class scope
  bool value() const {
       ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:158:47: error:
      explicit specialization of 'value' in class scope
  const std::map<std::string, GameParameter>& value() const {
                                              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:162:40: error:
      explicit specialization of 'value' in class scope
  std::map<std::string, GameParameter> value() const {
                                       ^
[  3%] Built target absl_exponential_biased
[  3%] Building CXX object CMakeFiles/open_spiel_core.dir/canonical_game_strings.cc.o
7 errors generated.
make[2]: *** [CMakeFiles/open_spiel_core.dir/action_view.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
Scanning dependencies of target absl_log_severity
[  3%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_log_severity.dir/log_severity.cc.o
make[1]: *** [CMakeFiles/open_spiel_core.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  3%] Linking CXX static library libabsl_log_severity.a
[  3%] Built target absl_log_severity
make: *** [all] Error 2
Exiting virtualenv

It does have some progress, but still they are nearly the same as previous one :(

My macOS is version 10.14, so the latest Xcode that I can update to is 10.1
I remove the openspiel and re-run the commands again. Here's the error message:
Building project
Scanning dependencies of target absl_strerror
Scanning dependencies of target open_spiel_core
[  0%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_strerror.dir/internal/strerror.cc.o
[  1%] Building CXX object CMakeFiles/open_spiel_core.dir/action_view.cc.o
[  2%] Linking CXX static library libabsl_strerror.a
[  2%] Built target absl_strerror
Scanning dependencies of target absl_exponential_biased
[  2%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_exponential_biased.dir/internal/exponential_biased.cc.o
[  3%] Linking CXX static library libabsl_exponential_biased.a
In file included from /Users/andrew/UofT/open_spiel/open_spiel/action_view.cc:15:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/action_view.h:20:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/spiel.h:36:
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:138:7: error:
      explicit specialization of 'value' in class scope
  int value() const {
      ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:142:10: error:
      explicit specialization of 'value' in class scope
  double value() const {
         ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:146:22: error:
      explicit specialization of 'value' in class scope
  const std::string& value() const {
                     ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:150:15: error:
      explicit specialization of 'value' in class scope
  std::string value() const {
              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:154:8: error:
      explicit specialization of 'value' in class scope
  bool value() const {
       ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:158:47: error:
      explicit specialization of 'value' in class scope
  const std::map<std::string, GameParameter>& value() const {
                                              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:162:40: error:
      explicit specialization of 'value' in class scope
  std::map<std::string, GameParameter> value() const {
                                       ^
[  3%] Built target absl_exponential_biased
[  3%] Building CXX object CMakeFiles/open_spiel_core.dir/canonical_game_strings.cc.o
7 errors generated.
make[2]: *** [CMakeFiles/open_spiel_core.dir/action_view.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
Scanning dependencies of target absl_log_severity
[  3%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_log_severity.dir/log_severity.cc.o
make[1]: *** [CMakeFiles/open_spiel_core.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  3%] Linking CXX static library libabsl_log_severity.a
[  3%] Built target absl_log_severity
make: *** [all] Error 2
Exiting virtualenv

It does have some progress, but still they are nearly the same as previous one :(

The Xcode version
$ xcodebuild -version
Xcode 10.1
Build version 10B61

The Xcode version
$ xcodebuild -version
Xcode 10.1
Build version 10B61

It seems strange that there's a "skipped" when checking for the C++ compiler.
Can you try all of the following (removing the build dir before each one with rm -rf build):

Try using CXX=clang++ (remove /usr/bin)
Try using CXX= /Library/Developer/CommandLineTools/usr/bin/clang++ instead
Try both of the above but remove the CXXFLAGS="-std=c++17"

It seems strange that there's a "skipped" when checking for the C++ compiler.
Can you try all of the following (removing the build dir before each one with rm -rf build):

Try using CXX=clang++ (remove /usr/bin)
Try using CXX= /Library/Developer/CommandLineTools/usr/bin/clang++ instead
Try both of the above but remove the CXXFLAGS="-std=c++17"

The "skipped" seems to be expected since the ABI is detected (according to the source here)
I tried the commands above, and here's the outputs
$ rm -rf build/ venv/
$ CXX=/Library/Developer/CommandLineTools/usr/bin/clang++ ./open_spiel/scripts/build_and_run_tests.sh
\e[33mRunning ./open_spiel/scripts/build_and_run_tests.sh from /Users/andrew/UofT/open_spiel\e[0m
Installing...
\e[33mInstalling a virtualenv to ./venv. The setup is long the first time, please wait.\e[0m
Running virtualenv with interpreter /usr/local/bin/python3
Already using interpreter /usr/local/opt/python/bin/python3.7
Using base prefix '/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7'
New python executable in /Users/andrew/UofT/open_spiel/venv/bin/python3.7
Also creating executable in /Users/andrew/UofT/open_spiel/venv/bin/python
Installing setuptools, pip, wheel...
done.
\e[33mInstalling the requirements (use --noinstall to skip).\e[0m
Ignoring dataclasses: markers 'python_version < "3.7"' don't match your environment
Requirement already satisfied: pip>=20.0.2 in ./venv/lib/python3.7/site-packages (from -r ./requirements.txt (line 15)) (20.3.4)
... [collecting other dependencies]

Building and testing in /Users/andrew/UofT/open_spiel/build using 'python' (version 3.7.7).
-- The C compiler identification is AppleClang <IP_ADDRESS>01145
-- The CXX compiler identification is AppleClang <IP_ADDRESS>01044
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
Current build type is: Testing
BUILD_WITH_ACPC: OFF
BUILD_WITH_EIGEN: OFF
BUILD_WITH_HANABI: OFF
BUILD_WITH_JULIA: OFF
BUILD_WITH_LIBTORCH: OFF
BUILD_WITH_TENSORFLOW_CC: OFF
BUILD_WITH_PUBLIC_STATES: OFF
BUILD_WITH_PYTHON: ON
BUILD_WITH_XINXIN: OFF
BUILD_WITH_ROSHAMBO: OFF
BUILD_WITH_GAMUT: OFF
BUILD_WITH_ORTOOLS: OFF
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found Python3: /usr/local/bin/python3 (found version "3.7.7") found components: Interpreter Development Development.Module Development.Embed
Python include dirs: /usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/include/python3.7m
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/andrew/UofT/open_spiel/build
Building project
Scanning dependencies of target open_spiel_core
Scanning dependencies of target absl_strerror
[  0%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_strerror.dir/internal/strerror.cc.o
[  1%] Building CXX object CMakeFiles/open_spiel_core.dir/action_view.cc.o
[  2%] Linking CXX static library libabsl_strerror.a
[  2%] Built target absl_strerror
Scanning dependencies of target absl_exponential_biased
[  2%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_exponential_biased.dir/internal/exponential_biased.cc.o
[  3%] Linking CXX static library libabsl_exponential_biased.a
[  3%] Built target absl_exponential_biased
Scanning dependencies of target absl_log_severity
[  3%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_log_severity.dir/log_severity.cc.o
In file included from /Users/andrew/UofT/open_spiel/open_spiel/action_view.cc:15:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/action_view.h:20:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/spiel.h:36:
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:138:7: error: explicit specialization of
      'value' in class scope
  int value() const {
      ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:142:10: error: explicit specialization of
      'value' in class scope
  double value() const {
         ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:146:22: error: explicit specialization of
      'value' in class scope
  const std::string& value() const {
                     ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:150:15: error: explicit specialization of
      'value' in class scope
  std::string value() const {
              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:154:8: error: explicit specialization of
      'value' in class scope
  bool value() const {
       ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:158:47: error: explicit specialization of
      'value' in class scope
  const std::map<std::string, GameParameter>& value() const {
                                              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:162:40: error: explicit specialization of
      'value' in class scope
  std::map<std::string, GameParameter> value() const {
                                       ^
7 errors generated.
make[2]: *** [CMakeFiles/open_spiel_core.dir/action_view.cc.o] Error 1
make[1]: *** [CMakeFiles/open_spiel_core.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  3%] Linking CXX static library libabsl_log_severity.a
[  3%] Built target absl_log_severity
make: *** [all] Error 2
Exiting virtualenv

$ rm -rf build/ venv/
$ CXX=/Library/Developer/CommandLineTools/usr/bin/clang++ CXXFLAGS="-std=c++17" ./open_spiel/scripts/build_and_run_tests.sh
\e[33mRunning ./open_spiel/scripts/build_and_run_tests.sh from /Users/andrew/UofT/open_spiel\e[0m
Installing...
\e[33mInstalling a virtualenv to ./venv. The setup is long the first time, please wait.\e[0m
Running virtualenv with interpreter /usr/local/bin/python3
Already using interpreter /usr/local/opt/python/bin/python3.7
Using base prefix '/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7'
New python executable in /Users/andrew/UofT/open_spiel/venv/bin/python3.7
Also creating executable in /Users/andrew/UofT/open_spiel/venv/bin/python
Installing setuptools, pip, wheel...
done.
\e[33mInstalling the requirements (use --noinstall to skip).\e[0m
Ignoring dataclasses: markers 'python_version < "3.7"' don't match your environment
Requirement already satisfied: pip>=20.0.2 in ./venv/lib/python3.7/site-packages (from -r ./requirements.txt (line 15)) (20.3.4)
... [Collecting other dependencies]

Building and testing in /Users/andrew/UofT/open_spiel/build using 'python' (version 3.7.7).
-- The C compiler identification is AppleClang <IP_ADDRESS>01145
-- The CXX compiler identification is AppleClang <IP_ADDRESS>01044
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
Current build type is: Testing
BUILD_WITH_ACPC: OFF
BUILD_WITH_EIGEN: OFF
BUILD_WITH_HANABI: OFF
BUILD_WITH_JULIA: OFF
BUILD_WITH_LIBTORCH: OFF
BUILD_WITH_TENSORFLOW_CC: OFF
BUILD_WITH_PUBLIC_STATES: OFF
BUILD_WITH_PYTHON: ON
BUILD_WITH_XINXIN: OFF
BUILD_WITH_ROSHAMBO: OFF
BUILD_WITH_GAMUT: OFF
BUILD_WITH_ORTOOLS: OFF
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found Python3: /usr/local/bin/python3 (found version "3.7.7") found components: Interpreter Development Development.Module Development.Embed
Python include dirs: /usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/include/python3.7m
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/andrew/UofT/open_spiel/build
Building project
Scanning dependencies of target absl_strerror
Scanning dependencies of target open_spiel_core
[  0%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_strerror.dir/internal/strerror.cc.o
[  1%] Building CXX object CMakeFiles/open_spiel_core.dir/action_view.cc.o
[  2%] Linking CXX static library libabsl_strerror.a
[  2%] Built target absl_strerror
[  2%] Building CXX object CMakeFiles/open_spiel_core.dir/canonical_game_strings.cc.o
In file included from /Users/andrew/UofT/open_spiel/open_spiel/action_view.cc:15:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/action_view.h:20:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/spiel.h:36:
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:138:7: error: explicit specialization of
      'value' in class scope
  int value() const {
      ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:142:10: error: explicit specialization of
      'value' in class scope
  double value() const {
         ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:146:22: error: explicit specialization of
      'value' in class scope
  const std::string& value() const {
                     ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:150:15: error: explicit specialization of
      'value' in class scope
  std::string value() const {
              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:154:8: error: explicit specialization of
      'value' in class scope
  bool value() const {
       ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:158:47: error: explicit specialization of
      'value' in class scope
  const std::map<std::string, GameParameter>& value() const {
                                              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:162:40: error: explicit specialization of
      'value' in class scope
  std::map<std::string, GameParameter> value() const {
                                       ^
Scanning dependencies of target absl_exponential_biased
[  2%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_exponential_biased.dir/internal/exponential_biased.cc.o
7 errors generated.
make[2]: *** [CMakeFiles/open_spiel_core.dir/action_view.cc.o] Error 1
make[1]: *** [CMakeFiles/open_spiel_core.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  3%] Linking CXX static library libabsl_exponential_biased.a
[  3%] Built target absl_exponential_biased
make: *** [all] Error 2
Exiting virtualenv

and
$ rm -rf build/ venv/
andrew@andrew-MacBook-Pro:~/UofT/open_spiel $ which clang++
/usr/bin/clang++
andrew@andrew-MacBook-Pro:~/UofT/open_spiel $ CXX=/usr/bin/clang++ CXXFLAGS="-std=c++17" ./open_spiel/scripts/build_and_run_tests.sh
\e[33mRunning ./open_spiel/scripts/build_and_run_tests.sh from /Users/andrew/UofT/open_spiel\e[0m
Installing...
\e[33mInstalling a virtualenv to ./venv. The setup is long the first time, please wait.\e[0m
Running virtualenv with interpreter /usr/local/bin/python3
Already using interpreter /usr/local/opt/python/bin/python3.7
Using base prefix '/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7'
New python executable in /Users/andrew/UofT/open_spiel/venv/bin/python3.7
Also creating executable in /Users/andrew/UofT/open_spiel/venv/bin/python
Installing setuptools, pip, wheel...
done.
\e[33mInstalling the requirements (use --noinstall to skip).\e[0m
Ignoring dataclasses: markers 'python_version < "3.7"' don't match your environment
Requirement already satisfied: pip>=20.0.2 in ./venv/lib/python3.7/site-packages (from -r ./requirements.txt (line 15)) (20.3.4)
... [Collecting other dependencies]

Building and testing in /Users/andrew/UofT/open_spiel/build using 'python' (version 3.7.7).
-- The C compiler identification is AppleClang <IP_ADDRESS>01145
-- The CXX compiler identification is AppleClang <IP_ADDRESS>01145
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
Current build type is: Testing
BUILD_WITH_ACPC: OFF
BUILD_WITH_EIGEN: OFF
BUILD_WITH_HANABI: OFF
BUILD_WITH_JULIA: OFF
BUILD_WITH_LIBTORCH: OFF
BUILD_WITH_TENSORFLOW_CC: OFF
BUILD_WITH_PUBLIC_STATES: OFF
BUILD_WITH_PYTHON: ON
BUILD_WITH_XINXIN: OFF
BUILD_WITH_ROSHAMBO: OFF
BUILD_WITH_GAMUT: OFF
BUILD_WITH_ORTOOLS: OFF
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found Python3: /usr/local/bin/python3 (found version "3.7.7") found components: Interpreter Development Development.Module Development.Embed
Python include dirs: /usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/include/python3.7m
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/andrew/UofT/open_spiel/build
Building project
Scanning dependencies of target absl_strerror
Scanning dependencies of target open_spiel_core
[  0%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_strerror.dir/internal/strerror.cc.o
[  1%] Building CXX object CMakeFiles/open_spiel_core.dir/action_view.cc.o
[  2%] Linking CXX static library libabsl_strerror.a
[  2%] Built target absl_strerror
[  2%] Building CXX object CMakeFiles/open_spiel_core.dir/canonical_game_strings.cc.o
In file included from /Users/andrew/UofT/open_spiel/open_spiel/action_view.cc:15:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/action_view.h:20:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/spiel.h:36:
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:138:7: error: explicit specialization of
      'value' in class scope
  int value() const {
      ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:142:10: error: explicit specialization of
      'value' in class scope
  double value() const {
         ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:146:22: error: explicit specialization of
      'value' in class scope
  const std::string& value() const {
                     ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:150:15: error: explicit specialization of
      'value' in class scope
  std::string value() const {
              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:154:8: error: explicit specialization of
      'value' in class scope
  bool value() const {
       ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:158:47: error: explicit specialization of
      'value' in class scope
  const std::map<std::string, GameParameter>& value() const {
                                              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:162:40: error: explicit specialization of
      'value' in class scope
  std::map<std::string, GameParameter> value() const {
                                       ^
Scanning dependencies of target absl_exponential_biased
[  2%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_exponential_biased.dir/internal/exponential_biased.cc.o
7 errors generated.
make[2]: *** [CMakeFiles/open_spiel_core.dir/action_view.cc.o] Error 1
make[1]: *** [CMakeFiles/open_spiel_core.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  3%] Linking CXX static library libabsl_exponential_biased.a
[  3%] Built target absl_exponential_biased
make: *** [all] Error 2
Exiting virtualenv

@lanctot do you think it worth a try to use clang12

The "skipped" seems to be expected since the ABI is detected (according to the source here)
I tried the commands above, and here's the outputs
$ rm -rf build/ venv/
$ CXX=/Library/Developer/CommandLineTools/usr/bin/clang++ ./open_spiel/scripts/build_and_run_tests.sh
\e[33mRunning ./open_spiel/scripts/build_and_run_tests.sh from /Users/andrew/UofT/open_spiel\e[0m
Installing...
\e[33mInstalling a virtualenv to ./venv. The setup is long the first time, please wait.\e[0m
Running virtualenv with interpreter /usr/local/bin/python3
Already using interpreter /usr/local/opt/python/bin/python3.7
Using base prefix '/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7'
New python executable in /Users/andrew/UofT/open_spiel/venv/bin/python3.7
Also creating executable in /Users/andrew/UofT/open_spiel/venv/bin/python
Installing setuptools, pip, wheel...
done.
\e[33mInstalling the requirements (use --noinstall to skip).\e[0m
Ignoring dataclasses: markers 'python_version < "3.7"' don't match your environment
Requirement already satisfied: pip>=20.0.2 in ./venv/lib/python3.7/site-packages (from -r ./requirements.txt (line 15)) (20.3.4)
... [collecting other dependencies]

Building and testing in /Users/andrew/UofT/open_spiel/build using 'python' (version 3.7.7).
-- The C compiler identification is AppleClang <IP_ADDRESS>01145
-- The CXX compiler identification is AppleClang <IP_ADDRESS>01044
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
Current build type is: Testing
BUILD_WITH_ACPC: OFF
BUILD_WITH_EIGEN: OFF
BUILD_WITH_HANABI: OFF
BUILD_WITH_JULIA: OFF
BUILD_WITH_LIBTORCH: OFF
BUILD_WITH_TENSORFLOW_CC: OFF
BUILD_WITH_PUBLIC_STATES: OFF
BUILD_WITH_PYTHON: ON
BUILD_WITH_XINXIN: OFF
BUILD_WITH_ROSHAMBO: OFF
BUILD_WITH_GAMUT: OFF
BUILD_WITH_ORTOOLS: OFF
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found Python3: /usr/local/bin/python3 (found version "3.7.7") found components: Interpreter Development Development.Module Development.Embed
Python include dirs: /usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/include/python3.7m
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/andrew/UofT/open_spiel/build
Building project
Scanning dependencies of target open_spiel_core
Scanning dependencies of target absl_strerror
[  0%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_strerror.dir/internal/strerror.cc.o
[  1%] Building CXX object CMakeFiles/open_spiel_core.dir/action_view.cc.o
[  2%] Linking CXX static library libabsl_strerror.a
[  2%] Built target absl_strerror
Scanning dependencies of target absl_exponential_biased
[  2%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_exponential_biased.dir/internal/exponential_biased.cc.o
[  3%] Linking CXX static library libabsl_exponential_biased.a
[  3%] Built target absl_exponential_biased
Scanning dependencies of target absl_log_severity
[  3%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_log_severity.dir/log_severity.cc.o
In file included from /Users/andrew/UofT/open_spiel/open_spiel/action_view.cc:15:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/action_view.h:20:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/spiel.h:36:
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:138:7: error: explicit specialization of
      'value' in class scope
  int value() const {
      ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:142:10: error: explicit specialization of
      'value' in class scope
  double value() const {
         ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:146:22: error: explicit specialization of
      'value' in class scope
  const std::string& value() const {
                     ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:150:15: error: explicit specialization of
      'value' in class scope
  std::string value() const {
              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:154:8: error: explicit specialization of
      'value' in class scope
  bool value() const {
       ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:158:47: error: explicit specialization of
      'value' in class scope
  const std::map<std::string, GameParameter>& value() const {
                                              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:162:40: error: explicit specialization of
      'value' in class scope
  std::map<std::string, GameParameter> value() const {
                                       ^
7 errors generated.
make[2]: *** [CMakeFiles/open_spiel_core.dir/action_view.cc.o] Error 1
make[1]: *** [CMakeFiles/open_spiel_core.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  3%] Linking CXX static library libabsl_log_severity.a
[  3%] Built target absl_log_severity
make: *** [all] Error 2
Exiting virtualenv

$ rm -rf build/ venv/
$ CXX=/Library/Developer/CommandLineTools/usr/bin/clang++ CXXFLAGS="-std=c++17" ./open_spiel/scripts/build_and_run_tests.sh
\e[33mRunning ./open_spiel/scripts/build_and_run_tests.sh from /Users/andrew/UofT/open_spiel\e[0m
Installing...
\e[33mInstalling a virtualenv to ./venv. The setup is long the first time, please wait.\e[0m
Running virtualenv with interpreter /usr/local/bin/python3
Already using interpreter /usr/local/opt/python/bin/python3.7
Using base prefix '/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7'
New python executable in /Users/andrew/UofT/open_spiel/venv/bin/python3.7
Also creating executable in /Users/andrew/UofT/open_spiel/venv/bin/python
Installing setuptools, pip, wheel...
done.
\e[33mInstalling the requirements (use --noinstall to skip).\e[0m
Ignoring dataclasses: markers 'python_version < "3.7"' don't match your environment
Requirement already satisfied: pip>=20.0.2 in ./venv/lib/python3.7/site-packages (from -r ./requirements.txt (line 15)) (20.3.4)
... [Collecting other dependencies]

Building and testing in /Users/andrew/UofT/open_spiel/build using 'python' (version 3.7.7).
-- The C compiler identification is AppleClang <IP_ADDRESS>01145
-- The CXX compiler identification is AppleClang <IP_ADDRESS>01044
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
Current build type is: Testing
BUILD_WITH_ACPC: OFF
BUILD_WITH_EIGEN: OFF
BUILD_WITH_HANABI: OFF
BUILD_WITH_JULIA: OFF
BUILD_WITH_LIBTORCH: OFF
BUILD_WITH_TENSORFLOW_CC: OFF
BUILD_WITH_PUBLIC_STATES: OFF
BUILD_WITH_PYTHON: ON
BUILD_WITH_XINXIN: OFF
BUILD_WITH_ROSHAMBO: OFF
BUILD_WITH_GAMUT: OFF
BUILD_WITH_ORTOOLS: OFF
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found Python3: /usr/local/bin/python3 (found version "3.7.7") found components: Interpreter Development Development.Module Development.Embed
Python include dirs: /usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/include/python3.7m
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/andrew/UofT/open_spiel/build
Building project
Scanning dependencies of target absl_strerror
Scanning dependencies of target open_spiel_core
[  0%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_strerror.dir/internal/strerror.cc.o
[  1%] Building CXX object CMakeFiles/open_spiel_core.dir/action_view.cc.o
[  2%] Linking CXX static library libabsl_strerror.a
[  2%] Built target absl_strerror
[  2%] Building CXX object CMakeFiles/open_spiel_core.dir/canonical_game_strings.cc.o
In file included from /Users/andrew/UofT/open_spiel/open_spiel/action_view.cc:15:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/action_view.h:20:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/spiel.h:36:
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:138:7: error: explicit specialization of
      'value' in class scope
  int value() const {
      ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:142:10: error: explicit specialization of
      'value' in class scope
  double value() const {
         ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:146:22: error: explicit specialization of
      'value' in class scope
  const std::string& value() const {
                     ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:150:15: error: explicit specialization of
      'value' in class scope
  std::string value() const {
              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:154:8: error: explicit specialization of
      'value' in class scope
  bool value() const {
       ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:158:47: error: explicit specialization of
      'value' in class scope
  const std::map<std::string, GameParameter>& value() const {
                                              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:162:40: error: explicit specialization of
      'value' in class scope
  std::map<std::string, GameParameter> value() const {
                                       ^
Scanning dependencies of target absl_exponential_biased
[  2%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_exponential_biased.dir/internal/exponential_biased.cc.o
7 errors generated.
make[2]: *** [CMakeFiles/open_spiel_core.dir/action_view.cc.o] Error 1
make[1]: *** [CMakeFiles/open_spiel_core.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  3%] Linking CXX static library libabsl_exponential_biased.a
[  3%] Built target absl_exponential_biased
make: *** [all] Error 2
Exiting virtualenv

and
$ rm -rf build/ venv/
andrew@andrew-MacBook-Pro:~/UofT/open_spiel $ which clang++
/usr/bin/clang++
andrew@andrew-MacBook-Pro:~/UofT/open_spiel $ CXX=/usr/bin/clang++ CXXFLAGS="-std=c++17" ./open_spiel/scripts/build_and_run_tests.sh
\e[33mRunning ./open_spiel/scripts/build_and_run_tests.sh from /Users/andrew/UofT/open_spiel\e[0m
Installing...
\e[33mInstalling a virtualenv to ./venv. The setup is long the first time, please wait.\e[0m
Running virtualenv with interpreter /usr/local/bin/python3
Already using interpreter /usr/local/opt/python/bin/python3.7
Using base prefix '/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7'
New python executable in /Users/andrew/UofT/open_spiel/venv/bin/python3.7
Also creating executable in /Users/andrew/UofT/open_spiel/venv/bin/python
Installing setuptools, pip, wheel...
done.
\e[33mInstalling the requirements (use --noinstall to skip).\e[0m
Ignoring dataclasses: markers 'python_version < "3.7"' don't match your environment
Requirement already satisfied: pip>=20.0.2 in ./venv/lib/python3.7/site-packages (from -r ./requirements.txt (line 15)) (20.3.4)
... [Collecting other dependencies]

Building and testing in /Users/andrew/UofT/open_spiel/build using 'python' (version 3.7.7).
-- The C compiler identification is AppleClang <IP_ADDRESS>01145
-- The CXX compiler identification is AppleClang <IP_ADDRESS>01145
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
Current build type is: Testing
BUILD_WITH_ACPC: OFF
BUILD_WITH_EIGEN: OFF
BUILD_WITH_HANABI: OFF
BUILD_WITH_JULIA: OFF
BUILD_WITH_LIBTORCH: OFF
BUILD_WITH_TENSORFLOW_CC: OFF
BUILD_WITH_PUBLIC_STATES: OFF
BUILD_WITH_PYTHON: ON
BUILD_WITH_XINXIN: OFF
BUILD_WITH_ROSHAMBO: OFF
BUILD_WITH_GAMUT: OFF
BUILD_WITH_ORTOOLS: OFF
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found Python3: /usr/local/bin/python3 (found version "3.7.7") found components: Interpreter Development Development.Module Development.Embed
Python include dirs: /usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/include/python3.7m
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/andrew/UofT/open_spiel/build
Building project
Scanning dependencies of target absl_strerror
Scanning dependencies of target open_spiel_core
[  0%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_strerror.dir/internal/strerror.cc.o
[  1%] Building CXX object CMakeFiles/open_spiel_core.dir/action_view.cc.o
[  2%] Linking CXX static library libabsl_strerror.a
[  2%] Built target absl_strerror
[  2%] Building CXX object CMakeFiles/open_spiel_core.dir/canonical_game_strings.cc.o
In file included from /Users/andrew/UofT/open_spiel/open_spiel/action_view.cc:15:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/action_view.h:20:
In file included from /Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/spiel.h:36:
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:138:7: error: explicit specialization of
      'value' in class scope
  int value() const {
      ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:142:10: error: explicit specialization of
      'value' in class scope
  double value() const {
         ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:146:22: error: explicit specialization of
      'value' in class scope
  const std::string& value() const {
                     ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:150:15: error: explicit specialization of
      'value' in class scope
  std::string value() const {
              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:154:8: error: explicit specialization of
      'value' in class scope
  bool value() const {
       ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:158:47: error: explicit specialization of
      'value' in class scope
  const std::map<std::string, GameParameter>& value() const {
                                              ^
/Users/andrew/UofT/open_spiel/open_spiel/../open_spiel/game_parameters.h:162:40: error: explicit specialization of
      'value' in class scope
  std::map<std::string, GameParameter> value() const {
                                       ^
Scanning dependencies of target absl_exponential_biased
[  2%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_exponential_biased.dir/internal/exponential_biased.cc.o
7 errors generated.
make[2]: *** [CMakeFiles/open_spiel_core.dir/action_view.cc.o] Error 1
make[1]: *** [CMakeFiles/open_spiel_core.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  3%] Linking CXX static library libabsl_exponential_biased.a
[  3%] Built target absl_exponential_biased
make: *** [all] Error 2
Exiting virtualenv

@lanctot do you think it worth a try to use clang12

Ok it's the same problem every time. Yes I think it is worth trying Clang 12, that will probably fix it, but I thought you needed to upgrade XCode to do that?

Ok it's the same problem every time. Yes I think it is worth trying Clang 12, that will probably fix it, but I thought you needed to upgrade XCode to do that?

Hi @andrewliao11 I'm going to try something, but I need you to test it because I don't have access to a machine where it fails.
Can you try the following:

Remove lines 137-164 in game_parameters.h  (starting here: https://github.com/deepmind/open_spiel/blob/244d1b55eb3f9de2ab4a0e06341ff2847afea466/open_spiel/game_parameters.h#L137). Make sure to leave lines 134-136.
Provide the specializations in the game_parameters.cc instead (insert the code below t line 245 of game_parameters.cc), before the closing brace of the namespace open_spiel

  template <>
  int GameParameters::value() const {
    return int_value();
  }

  template <>
  double GameParameters::value() const {
    return double_value();
  }

  template <>
  const std::string& GameParameters::value() const {
    return string_value();
  }

  template <>
  std::string GameParameters::value() const {
    return string_value();
  }

  template <>
  bool value() const {
    return GameParameters::bool_value();
  }

  template <>
  const std::map<std::string, GameParameter>& GameParameters::value() const {
    return game_value();
  }

  template <>
  std::map<std::string, GameParameter> GameParameters::value() const {
    return game_value();
  }

Does this fix the problem?

Hi @andrewliao11 I'm going to try something, but I need you to test it because I don't have access to a machine where it fails.
Can you try the following:

Remove lines 137-164 in game_parameters.h  (starting here: https://github.com/deepmind/open_spiel/blob/244d1b55eb3f9de2ab4a0e06341ff2847afea466/open_spiel/game_parameters.h#L137). Make sure to leave lines 134-136.
Provide the specializations in the game_parameters.cc instead (insert the code below t line 245 of game_parameters.cc), before the closing brace of the namespace open_spiel

  template <>
  int GameParameters::value() const {
    return int_value();
  }

  template <>
  double GameParameters::value() const {
    return double_value();
  }

  template <>
  const std::string& GameParameters::value() const {
    return string_value();
  }

  template <>
  std::string GameParameters::value() const {
    return string_value();
  }

  template <>
  bool value() const {
    return GameParameters::bool_value();
  }

  template <>
  const std::map<std::string, GameParameter>& GameParameters::value() const {
    return game_value();
  }

  template <>
  std::map<std::string, GameParameter> GameParameters::value() const {
    return game_value();
  }

Does this fix the problem?

If that last option doesn't work try keeping them in the header but outside the class, i.e. put them here instead: https://github.com/deepmind/open_spiel/blob/244d1b55eb3f9de2ab4a0e06341ff2847afea466/open_spiel/spiel.h#L1050
If it's not clear what I mean I can send you the edited files tomorrow, just let me know.

If that last option doesn't work try keeping them in the header but outside the class, i.e. put them here instead: https://github.com/deepmind/open_spiel/blob/244d1b55eb3f9de2ab4a0e06341ff2847afea466/open_spiel/spiel.h#L1050
If it's not clear what I mean I can send you the edited files tomorrow, just let me know.

This works!
Now it stucks at around 95%. It is complaining error: no viable constructor or deduction guide for deduction of template arguments of 'array'.
Here's the error message:
[ 95%] Linking CXX executable coop_to_1p_test
[ 95%] Linking CXX executable turn_based_simultaneous_game_test
[ 95%] Built target coop_to_1p_test
Scanning dependencies of target normal_form_extensive_game_test
[ 95%] Building CXX object game_transforms/CMakeFiles/normal_form_extensive_game_test.dir/normal_form_extensive_game_test.cc.o
[ 95%] Built target turn_based_simultaneous_game_test
Scanning dependencies of target misere_test
[ 95%] Building CXX object game_transforms/CMakeFiles/misere_test.dir/misere_test.cc.o
[ 95%] Linking CXX executable normal_form_extensive_game_test
[ 95%] Linking CXX executable misere_test
[ 95%] Built target normal_form_extensive_game_test
Scanning dependencies of target pyspiel
[ 95%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/algorithms_corr_dist.cc.o
[ 95%] Built target misere_test
Scanning dependencies of target tensor_view_test
[ 95%] Building CXX object utils/CMakeFiles/tensor_view_test.dir/tensor_view_test.cc.o
/Users/andrew/UofT/open_spiel/open_spiel/utils/tensor_view_test.cc:33:34: error: no viable constructor or deduction
      guide for deduction of template arguments of 'array'
  SPIEL_CHECK_EQ(view2.shape(), (std::array{2, 3}));
                                 ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__tuple:223:64: note:
      candidate function template not viable: requires 0 arguments, but 2 were provided
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
                                                               ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__tuple:223:64: note:
      candidate function template not viable: requires 1 argument, but 2 were provided
/Users/andrew/UofT/open_spiel/open_spiel/utils/tensor_view_test.cc:71:34: error: no viable constructor or deduction
      guide for deduction of template arguments of 'array'
  SPIEL_CHECK_EQ(view3.shape(), (std::array{4, 2, 3}));
                                 ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__tuple:223:64: note:
      candidate function template not viable: requires 0 arguments, but 3 were provided
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
                                                               ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__tuple:223:64: note:
      candidate function template not viable: requires 1 argument, but 3 were provided
/Users/andrew/UofT/open_spiel/open_spiel/utils/tensor_view_test.cc:104:34: error: no viable constructor or
      deduction guide for deduction of template arguments of 'array'
  SPIEL_CHECK_EQ(view1.shape(), (std::array{8}));
                                 ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__tuple:223:64: note:
      candidate template ignored: could not match 'array<_Tp, _Size>' against 'int'
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
                                                               ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__tuple:223:64: note:
      candidate function template not viable: requires 0 arguments, but 1 was provided
/Users/andrew/UofT/open_spiel/open_spiel/utils/tensor_view_test.cc:125:38: error: no viable constructor or
      deduction guide for deduction of template arguments of 'array'
  SPIEL_CHECK_EQ(view_keep.shape(), (std::array{2, 4}));
                                     ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__tuple:223:64: note:
      candidate function template not viable: requires 0 arguments, but 2 were provided
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
                                                               ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__tuple:223:64: note:
      candidate function template not viable: requires 1 argument, but 2 were provided
4 errors generated.
make[2]: *** [utils/CMakeFiles/tensor_view_test.dir/tensor_view_test.cc.o] Error 1
make[1]: *** [utils/CMakeFiles/tensor_view_test.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 95%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/algorithms_trajectories.cc.o
[ 95%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/bots.cc.o
[ 95%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/games_backgammon.cc.o
[ 96%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/games_bridge.cc.o
[ 96%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/games_negotiation.cc.o
[ 96%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/games_tarok.cc.o
[ 96%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/game_transforms.cc.o
[ 96%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/observation_history.cc.o
[ 96%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/observer.cc.o
[ 97%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/policy.cc.o
[ 97%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/pyspiel.cc.o
[ 97%] Linking CXX shared module pyspiel.so
[ 97%] Built target pyspiel
make: *** [all] Error 2
Exiting virtualenv

This works!
Now it stucks at around 95%. It is complaining error: no viable constructor or deduction guide for deduction of template arguments of 'array'.
Here's the error message:
[ 95%] Linking CXX executable coop_to_1p_test
[ 95%] Linking CXX executable turn_based_simultaneous_game_test
[ 95%] Built target coop_to_1p_test
Scanning dependencies of target normal_form_extensive_game_test
[ 95%] Building CXX object game_transforms/CMakeFiles/normal_form_extensive_game_test.dir/normal_form_extensive_game_test.cc.o
[ 95%] Built target turn_based_simultaneous_game_test
Scanning dependencies of target misere_test
[ 95%] Building CXX object game_transforms/CMakeFiles/misere_test.dir/misere_test.cc.o
[ 95%] Linking CXX executable normal_form_extensive_game_test
[ 95%] Linking CXX executable misere_test
[ 95%] Built target normal_form_extensive_game_test
Scanning dependencies of target pyspiel
[ 95%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/algorithms_corr_dist.cc.o
[ 95%] Built target misere_test
Scanning dependencies of target tensor_view_test
[ 95%] Building CXX object utils/CMakeFiles/tensor_view_test.dir/tensor_view_test.cc.o
/Users/andrew/UofT/open_spiel/open_spiel/utils/tensor_view_test.cc:33:34: error: no viable constructor or deduction
      guide for deduction of template arguments of 'array'
  SPIEL_CHECK_EQ(view2.shape(), (std::array{2, 3}));
                                 ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__tuple:223:64: note:
      candidate function template not viable: requires 0 arguments, but 2 were provided
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
                                                               ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__tuple:223:64: note:
      candidate function template not viable: requires 1 argument, but 2 were provided
/Users/andrew/UofT/open_spiel/open_spiel/utils/tensor_view_test.cc:71:34: error: no viable constructor or deduction
      guide for deduction of template arguments of 'array'
  SPIEL_CHECK_EQ(view3.shape(), (std::array{4, 2, 3}));
                                 ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__tuple:223:64: note:
      candidate function template not viable: requires 0 arguments, but 3 were provided
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
                                                               ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__tuple:223:64: note:
      candidate function template not viable: requires 1 argument, but 3 were provided
/Users/andrew/UofT/open_spiel/open_spiel/utils/tensor_view_test.cc:104:34: error: no viable constructor or
      deduction guide for deduction of template arguments of 'array'
  SPIEL_CHECK_EQ(view1.shape(), (std::array{8}));
                                 ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__tuple:223:64: note:
      candidate template ignored: could not match 'array<_Tp, _Size>' against 'int'
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
                                                               ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__tuple:223:64: note:
      candidate function template not viable: requires 0 arguments, but 1 was provided
/Users/andrew/UofT/open_spiel/open_spiel/utils/tensor_view_test.cc:125:38: error: no viable constructor or
      deduction guide for deduction of template arguments of 'array'
  SPIEL_CHECK_EQ(view_keep.shape(), (std::array{2, 4}));
                                     ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__tuple:223:64: note:
      candidate function template not viable: requires 0 arguments, but 2 were provided
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
                                                               ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__tuple:223:64: note:
      candidate function template not viable: requires 1 argument, but 2 were provided
4 errors generated.
make[2]: *** [utils/CMakeFiles/tensor_view_test.dir/tensor_view_test.cc.o] Error 1
make[1]: *** [utils/CMakeFiles/tensor_view_test.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 95%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/algorithms_trajectories.cc.o
[ 95%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/bots.cc.o
[ 95%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/games_backgammon.cc.o
[ 96%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/games_bridge.cc.o
[ 96%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/games_negotiation.cc.o
[ 96%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/games_tarok.cc.o
[ 96%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/game_transforms.cc.o
[ 96%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/observation_history.cc.o
[ 96%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/observer.cc.o
[ 97%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/policy.cc.o
[ 97%] Building CXX object python/CMakeFiles/pyspiel.dir/pybind11/pyspiel.cc.o
[ 97%] Linking CXX shared module pyspiel.so
[ 97%] Built target pyspiel
make: *** [all] Error 2
Exiting virtualenv

Excellent!!! Ok we will fix them all one by one, and then I will submit the fixes. Then, we won't run into this notorious bug any more :)
In utils/tensor_view_test, can you try to replace std::array{2, 3} with std::array<int, 2>{2, 3}?

Excellent!!! Ok we will fix them all one by one, and then I will submit the fixes. Then, we won't run into this notorious bug any more :)
In utils/tensor_view_test, can you try to replace std::array{2, 3} with std::array<int, 2>{2, 3}?

gracefully passed the test! Thanks @lanctot

gracefully passed the test! Thanks @lanctot

Great. Thanks for all the help testing, many future users will have you to thank!
Also couldn't help but notice the UofT affiliation in your path names. It's neat to see a user from there, I lurked as a remote Ph.D. student in Craig Bouthilier's group from 2008 - 2012. I taught CSC 192 for EngSci in '09 and '10. ;-)

Great. Thanks for all the help testing, many future users will have you to thank!
Also couldn't help but notice the UofT affiliation in your path names. It's neat to see a user from there, I lurked as a remote Ph.D. student in Craig Bouthilier's group from 2008 - 2012. I taught CSC 192 for EngSci in '09 and '10. ;-)

Wow. Glad to hear that there are so many UofT ppl out there! :)

Wow. Glad to hear that there are so many UofT ppl out there! :)


s2n_writev() or-alikes

I've searched for related issues and not found anything, sorry if this is a dupe!
I have some code that normally uses writev() to avoid constantly memcpy'ing a large amount of data. There's no equivalent interface as s2n_send() uses a linear buffer. Many of the iovecs are very small (a handful of bytes), so calling s2n_send() once per iovec would cause either a lot of small records to be written or just a lot of overhead in re-running all of the s2n_send() and s2n_flush() related code for 2-4 bytes, 20 bytes, then data, etc. (sorry if this is wrong, my understanding of the code is still basic).
This is the same as SSL_write() for OpenSSL, which causes similar programs to memcpy into an intermediate temporary buffer.
When used in a non-blocking case, s2n_send() can cause EAGAIN|EWOULDBLOCK partway through a buffer. Which ends up meaning each time we try to send a partial buffer we have to re-generate up to the max size buffer from the remaining iovecs. Then you try to optimize by using smaller buffers, then you lose on potential throughput and over-generate syscalls, etc :)
Any thoughts on adding an s2n_writev()/readv() or similar? Been reading through the s2n_send() code and it doesn't seem too awful. I need to understand better exactly when records are created and how partially sent records work/are buffered though.
thanks!

I think lovec I/O would be awesome to have!

Cool! Have you folks discussed how to approach this already? I can maybe take a whack at it, as well. Looks like it could be a little involved in the guts? Modifying/adding stuffers to avoid intermediate double copies.

I think the easiest way would be to change the current s2n_send / s2n_recv functions into s2n_sendv / s2n_recvv's - and then create back-combat s2n_send/s2n_recv that just use one-entry lovecs.
s2n_record_write and s2n_record_read will need to be modified to take vectors too, but it's not too hard from there.


FFTW Broken on MacOS runner CI

FFTW Broken on MacOS runners
See: https://github.com/MFlowCode/MFC/actions/runs/9290749453/job/25567695171?pr=443
This is new, I suspect has something to do with updated MacOS runners.
Both of the runners are new, and they may have changed the meaning of macos-latest

https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md
https://github.com/actions/runner-images/blob/main/images/macos/macos-14-arm64-Readme.md

See the table here:
https://github.com/actions/runner-images
and the updated MacOS runners here, released just as this change happened:
https://github.com/actions/runner-images/releases
Notably, it seems that they upgraded the runners to GCC13.3.0 from 13.2.0. Perhaps this is the issue.
Update:
I've tried the macos-12,13,14 runners and they all grab gcc13.3.0 and fail, which as far as I can tell is the only relevant change to these runners in the past few days. Strangely, gcc14 works fine with fftw on my machine, though I don't know if I ever checked gcc13.3.0 (perhaps only an older minor version).

Update: I installed<EMAIL_ADDRESS>on my machine and it works fine. I do see that the MacOS runners are x86 not arm, this is the only discernable difference between my machine and the runner (or the runner and previous MacOS runners, as far as I can tell). Arm MacOS runners are not in the free tier, though I'm doubtful that this is the issue to begin with.

https://github.com/MFlowCode/MFC/pull/443#issuecomment-2139392281

this was closed a long time ago...


DEBUG=nuxt:* won't work

Hi
I|m trying to run your changes on windows, and the DEBUG direktive in the dev target of package.json don't work very well. I get a list of erreors, the main point being "DEBUG" is not recognized as an internal or external command.

Using cross-env before the DEBUG statement worked well. Resolving


Envoy Filter Or Command %REQ(X?Y):Z% not working as expected

Hi, regarding the documentation: https://www.envoyproxy.io/docs/envoy/v1.22.5/configuration/observability/access_log/usage#config-access-log-format
If we have an envoy filter and we set a header with an or command %REQ(X?Y):Z%, the envoy filter will skip this configuration and will skip this header.
If we set the header without the conditional:
value: '%REQ(x-h1)%%REQ(x-h2)%'

# This is accepted
curl -H "x-ext-authz: allow" -H "x-h1: h1" -H "x-h2: h2" http://$GATEWAY_IP/get

# This is rejected
curl -H "x-h1: h1" -H "x-h2: h2" http://$GATEWAY_IP/get

# Now change the value in the envoyfilter for '%REQ(x-h1)%%REQ(x-h3?x-h2)%' , it will stop working, the header will not appear any more nor with h2 nor h3

cc @cpakulski I think this might be related to unified formatters

Looking into it. Thanks!

@edubonifs What is the version of Envoy you are using?

Hi, I am using version 1.23.2

@edubonifs I just tried 1.23.2 and everything seems to be working fine. I added basic access log to the
HttpConnectionManager:
              typed_config:
                "@type": type.googleapis.com/envoy.extensions.access_loggers.file.v3.FileAccessLog
                path: /dev/stdout
                json_format:
                  headers: "%REQ(x-h1)%%REQ(x-h3?x-h2)%"

And I get the right output for:
curl -H "x-h1: h1" -H "x-h2: h2" http://$GATEWAY_IP/get
I think I am missing something here. Can you provide a config snippet? I also do not understand what do you mean by rejected:

This is accepted
curl -H "x-ext-authz: allow" -H "x-h1: h1" -H "x-h2: h2" http://$GATEWAY_IP/get
This is rejected
curl -H "x-h1: h1" -H "x-h2: h2" http://$GATEWAY_IP/get

Hi sorry, by rejected I mean that the h2 header will not appear with the conditional form: "%REQ(x-h1)%%REQ(x-h3?x-h2)%"
But seeing that you managed to make it work, let me comment it in Istio in case this is an Istio problem


(BOLT-1109) Support puppetdb lookups in inventory2

This adds a primative plugin concept to Bolt. Currenlty this is closely
tailored to the needs of the 'puppetdb' plugin which is a bit magic
since it uses prexisting puppetdb configuration.
The key parts of the plugin framework are self.setup which returns a new
plugin library with plugins loaded and by_name which allows us to
fetch the puppetdb plugin. We should expect to refactor basically
everything else around how we load plugins as we develop more hooks and
external plugins.
This is currently based on the BOLT-1232 PR since it also needs to add pre-docs

CLA signed by all contributors.

Should we fail hard and not allow any tasks to be run when there is a problem loading a plugin?
For example:
version: 2
groups:
  - name: puppet_db
    target-lookups:
       - plugin: puppetdb
         query: inventory[foo]{facts.os.release.major = "7"}
    config:
      transport: pcp

cas@cas-ThinkPad-T460p:~/working_dir/bolt$ bolt task show
Failed to query PuppetDB: Can't extract unknown 'inventory' field 'foo'. Acceptable fields are 'certname', 'timestamp', 'environment', 'facts', and 'trusted'

Still digging in to this but I'm seeing some weird behavior nesting inventory:
version: 2
groups:
  - name: puppet_db
    target-lookups:
       - plugin: puppetdb
         query: inventory[certname]{facts.os.release.major = "7"}
    config:
      transport: pcp
    groups:
      - name: foo
        targets:
          - name: localhost
        config:
          transport: local
        target-lookups:
           - plugin: puppetdb
             query: inventory[certname]{facts.os.release.major = "7"}

The result reports it ran on all three targets but it appears to have just run three times on localhost?
cas@cas-ThinkPad-T460p:~/working_dir/bolt$ bolt command run whoami -n puppet_db
Started on c8jy9ikuuyf0g1r.delivery.puppetlabs.net...
Started on ...
Started on p7b9u0qbudxqvnh.delivery.puppetlabs.net...
Finished on :
  STDOUT:
    cas
Finished on c8jy9ikuuyf0g1r.delivery.puppetlabs.net:
  STDOUT:
    cas
Finished on p7b9u0qbudxqvnh.delivery.puppetlabs.net:
  STDOUT:
    cas
Successful on 3 nodes: c8jy9ikuuyf0g1r.delivery.puppetlabs.net,p7b9u0qbudxqvnh.delivery.puppetlabs.net,localhost
Ran on 3 nodes in 0.00 seconds


Class "Magento\Reward\Model\RewardFactory" does not exist

Impossible to process constructor argument Parameter #16 [  Magen
to\Reward\Model\RewardFactory $rewardFactory ] of Techyouknow\SocialLogin\M
odel\Social class
Class "Magento\Reward\Model\RewardFactory" does not exist

Hi @Kiwifu,
Thanks for pointing out this issue. I guess you are using the Magento Community Edition. I tested this on Adobe Commerce (Enterprise), where I forgot to add a condition to check the class for the Reward, which is actually not available in the Community Edition.
I will rectify this code shortly. However, if you urgently need to use this extension, you can utilize version 1.0.2 by running the following composer command:
composer require techyouknow/module-social-login:1.0.2
I will provide an update here once I have resolved this issue.

Thank you,  @amjadm61
I will go with the provided version (1.0.2).
Also, to have an idea about the extension, Please try to add screenshots for the plugin, like that other users can see the extension in action.
Thank you again.


Update circle position when drag circle center

When you drag circle center marker, the circle doesn't update its position

@mkondur oh wow.
Works fine for me on the demo page: leafletpm.now.sh.
Can you give me a link where it's not working for you?
If it's the demo page, I'd need browser info.
What would also help is:
open dev tools for that browser and check if there are JS errors - if yes, please screenshot them in here.
Also type L.PM.version into the console and check that it's the latest release: 0.20.0

@codeofsumit it's not working for me. Tested on Chrome 61.0.3163.100, Firefox 55.0.3 and Safari 11.0.
I tested it on demo page: leafletpm.now.sh where L.PM.version is 0.20.0 and also in my project where L.PM.version is 0.17.3 and there is the same effect when I click on circle center marker and drag it to another position and circle stays at the old position. There are no JS errors

@mkondur hmmm very weird. I just went to my coworkers, Linux, Windows 7 and Mac and tried it in Firefox, Chrome and Safari. It's all working 🤔 .
Any ideas what else we could try?

I'm working on Mac.
Step by step what I'm doing:

Choose to draw a circle
Click on map to start drawing
When circle center marker appear I click on it and drag to another position and then move mouse to draw circle.

Solution:
Disable to drag center marker when draw a circle or update circle position when drag this marker

ha! Thanks, now I was able to reproduce!
Will fix it - the marker shouldn't be draggable during draw - it's for editing only.


Use the GitHub API and OAuth

Using the API will keep you from being broken if GitHub changes their page layout, and OAuth will let users get notified for private repos.

Private repositories **are supported ** and users do get notifications for them through GitHub Notifier currently!
I chose to scrape the website over the GitHub API to prevent users from having to input their GitHub oAuth tokens, satisfying security concerns around entering oAuth tokens into third party applications.
oAuth isn't something I plan on implementing at this stage.

My mistake, I didn't realize that private repos were supported.
Using the API doesn't require users to input a secret token, you can do OAuth in an extension, see https://github.com/sindresorhus/notifier-for-github-chrome/issues/57 which I recently filed on a similar extension. This lets users logged in to GitHub programmatically send a token to your extension, then the extension can securely store it using chrome.storage.
The issue with scraping pages is that if GitHub changes their layout, which they will do without warning, your extension will break. They have no obligation to warn about DOM changes. This is what the API is for, programmatic access to user data.

@ImJasonH
I didn't realise that was possible with Chrome extensions. I'm going to tag this as an enhancement and take a look at it over the next week or so.
If you'd like to work on this let me know and I shall assign it to you.
Thanks for the explanation!
:+1:

:+1:
Also it would help with managing which repos the user gets notifications for