Import from Duolingo isn't finishing

I've imported lots of notes from Duolingo, but lately my import never finishes.  Anki tells me the new notes have been added, but the "Importing from Duolingo" progress bar never finishes (see photo).

When I eventually force quit Anki, the new notes aren't there.  Any ideas?

Hmm...does it seem like it could be stalling out on a particular word?
This weekend I'll try putting in an update that will make it list each word
as it's importing it. That could give some clues.
On Wed, Dec 23, 2020, 11:14 AM Catie Patterson<EMAIL_ADDRESS>wrote:

I've imported lots of notes from Duolingo, but lately my import never
finishes. Anki tells me the new notes have been added, but the "Importing
from Duolingo" progress bar never finishes (see photo).
[image: Screen Shot 2020-12-23 at 1 11 47 PM]
https://user-images.githubusercontent.com/5400992/103030073-af76ca80-4520-11eb-8d2b-bebb08671901.png
When I eventually force quit Anki, the new notes aren't there. Any ideas?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/JASchilz/AnkiSyncDuolingo/issues/28, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABO2Q4E6ZFIZ2D65Y2NNISLSWI6SDANCNFSM4VHK4TIA
.

I don't think it is a particular word.  I think I remember doing a big import of words recently, so maybe it's stalling out if there are only a few words?  Maybe the progress bar animation is taking longer to complete than the time it takes to download so few words?  I'm honestly not sure.  Once I build up more of a backlog of vocabulary, I'll try it again.  I definitely had this problem earlier this month, and then it randomly worked once.  So, that's why I'm thinking it may work with more words.  Unfortunately, I don't remember how many words I downloaded when it did work.
Really appreciate your help with this!  This is such a useful add-on!

I'm even more convinced now that it is stalling out on lower numbers of words.  I've been trying every couple days to sync, and it finally worked today with 123.

Here is my (failed) attempt on 12/20 with 100 words:

I'm even more convinced now that it is stalling out on lower numbers of words.  I've been trying every couple days to sync, and it finally worked today with 123.

Here is my (failed) attempt on 12/20 with 100 words:

Hi Catie! This helps me think through where the error might be. I'm unable to replicate this problem on my own machine: I've tried importing just 3 words and it's been successful each time. But I took a look at the plugin page on AnkiWeb and saw in the reviews that there were other people reporting this issue, so this isn't just you.
Since I can't replicate it, could you confirm or try a couple of things for me:

Could you upgrade to the latest version of Anki? You can download 2.1.38 from https://apps.ankiweb.net/ . There was a recent fix that might address this problem.
Could you make sure that you're on the latest version of Pull from Duolingo? You can re-install the plugin without losing any of your cards by going to "Tools" -> "Add ons" and then selecting and deleting the Pull from Duolingo add-on. Then you can re-install the latest version using code 557761805.

Just knowing that you're on the latest version of both of those will help us eliminate any easy problems.
Your error report is very detailed, and I'm still trying to think through what kind of problem could produce the issue that you're seeing.
And if anyone else is joining this ticket, I'm curious if you're seeing this problem on Windows or Linux. I'm on Windows, and I see that you're on Mac, so I'm wondering if it possibly this only shows up on Mac.

Hi Catie! This helps me think through where the error might be. I'm unable to replicate this problem on my own machine: I've tried importing just 3 words and it's been successful each time. But I took a look at the plugin page on AnkiWeb and saw in the reviews that there were other people reporting this issue, so this isn't just you.
Since I can't replicate it, could you confirm or try a couple of things for me:

Could you upgrade to the latest version of Anki? You can download 2.1.38 from https://apps.ankiweb.net/ . There was a recent fix that might address this problem.
Could you make sure that you're on the latest version of Pull from Duolingo? You can re-install the plugin without losing any of your cards by going to "Tools" -> "Add ons" and then selecting and deleting the Pull from Duolingo add-on. Then you can re-install the latest version using code 557761805.

Just knowing that you're on the latest version of both of those will help us eliminate any easy problems.
Your error report is very detailed, and I'm still trying to think through what kind of problem could produce the issue that you're seeing.
And if anyone else is joining this ticket, I'm curious if you're seeing this problem on Windows or Linux. I'm on Windows, and I see that you're on Mac, so I'm wondering if it possibly this only shows up on Mac.

Hi Joseph!  I upgraded to Anki 2.1.38, and then attempted to import 6 words, and got the same stalling issue as before:

I then deleted and reinstalled your add-on.  When I tried importing from Duolingo again, I got the same issue.
Since you aren't able to reproduce the issue on your end, feel free to let me know if you need me to test anything else out.  Thanks so much for your help!

Hi Joseph!  I upgraded to Anki 2.1.38, and then attempted to import 6 words, and got the same stalling issue as before:

I then deleted and reinstalled your add-on.  When I tried importing from Duolingo again, I got the same issue.
Since you aren't able to reproduce the issue on your end, feel free to let me know if you need me to test anything else out.  Thanks so much for your help!

OK. Thank you for verifying that!
I still don't get what kind of problem would cause it to freeze up like this. But I did take a look at the plugin code and I saw:

When my plugin says "6 Notes Added", it's just naively assuming that every note it tried to add was successfully added.
But it looks like there's a way that I can ask Anki whether or not a note was successfully added.

So I've made a version of the add-on that will actually ask Anki whether the notes it's trying to add made it in. To install it, you'll need to:

download the duolingo_sync.ankiaddon from https://github.com/JASchilz/AnkiSyncDuolingo/releases/tag/1.1.2
delete the add-on that you currently have installed using the same add-on manager toolbox you used earlier today
then use the "install from file" option in the add-on manager to install this add-on

I don't think that this will solve the problem, but I am hoping that the window that now says "6 notes added" will say something like, "2 notes added. Failed to add: merci, chatte". I agree with you it's probably not a problem with certain words, but just knowing that my plugin can tell whether it was successful at adding a note will help with the debugging.
In this version, I also close the progress bar before I present the "X Notes Added" screen. I don't think that this will solve the crash, but it will help me troubleshoot.
When you try running this, can you tell me:

Do you see "Failed to add: ..." in the box that says "X notes added"
Do you see all of the words that you expected to add or just some? If you try to add the same vocabulary multiple times, then do the same words appear in the "Failed to add"?
Did the progress bar close out this time?
Are you able to click the "OK" button on the "X notes added" box? If so, what happens?
I've also added some debug logging. After attempting an import, you should be able to access this log by selecting "Pull from Duoling" in the addons toolbox, and then clicking "view files". The log will named log.txt. This log will contain all of the words that you attempted to sync, but doesn't contain anything personal like your username or password. Could you e-mail that to me (my e-mail is on my profile https://github.com/JASchilz) or post that here?

If this doesn't make the problem obvious, then

OK. Thank you for verifying that!
I still don't get what kind of problem would cause it to freeze up like this. But I did take a look at the plugin code and I saw:

When my plugin says "6 Notes Added", it's just naively assuming that every note it tried to add was successfully added.
But it looks like there's a way that I can ask Anki whether or not a note was successfully added.

So I've made a version of the add-on that will actually ask Anki whether the notes it's trying to add made it in. To install it, you'll need to:

download the duolingo_sync.ankiaddon from https://github.com/JASchilz/AnkiSyncDuolingo/releases/tag/1.1.2
delete the add-on that you currently have installed using the same add-on manager toolbox you used earlier today
then use the "install from file" option in the add-on manager to install this add-on

I don't think that this will solve the problem, but I am hoping that the window that now says "6 notes added" will say something like, "2 notes added. Failed to add: merci, chatte". I agree with you it's probably not a problem with certain words, but just knowing that my plugin can tell whether it was successful at adding a note will help with the debugging.
In this version, I also close the progress bar before I present the "X Notes Added" screen. I don't think that this will solve the crash, but it will help me troubleshoot.
When you try running this, can you tell me:

Do you see "Failed to add: ..." in the box that says "X notes added"
Do you see all of the words that you expected to add or just some? If you try to add the same vocabulary multiple times, then do the same words appear in the "Failed to add"?
Did the progress bar close out this time?
Are you able to click the "OK" button on the "X notes added" box? If so, what happens?
I've also added some debug logging. After attempting an import, you should be able to access this log by selecting "Pull from Duoling" in the addons toolbox, and then clicking "view files". The log will named log.txt. This log will contain all of the words that you attempted to sync, but doesn't contain anything personal like your username or password. Could you e-mail that to me (my e-mail is on my profile https://github.com/JASchilz) or post that here?

If this doesn't make the problem obvious, then

It worked!  I was so shocked the first time it worked that I tried it again and recorded my screen.  I'll email you that recording since GitHub isn't letting me upload it.  I'll also include the log file in the email.  Thanks!

It worked!  I was so shocked the first time it worked that I tried it again and recorded my screen.  I'll email you that recording since GitHub isn't letting me upload it.  I'll also include the log file in the email.  Thanks!

Oh, I forgot to mention that I did search for the words that were supposed to be added, and they were in fact added.  Success!

Oh, I forgot to mention that I did search for the words that were supposed to be added, and they were in fact added.  Success!

Alright! Hmm...the only thing I really changed was the order of when the
progress bar window closes. So I'm also very surprised! :)
I'll try making a version with the logging, so that I can be sure that it's
not something mysterious about writing that log file that's saving the day.
--Joe
On Mon, Jan 4, 2021, 11:47 AM Catie Patterson<EMAIL_ADDRESS>wrote:

Oh, I forgot to mention that I did search for the words that were supposed
to be added, and they were in fact added. Success!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/JASchilz/AnkiSyncDuolingo/issues/28#issuecomment-754179024,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABO2Q4EIKQZMQTOYTHHFWUTSYILODANCNFSM4VHK4TIA
.

Alright! Hmm...the only thing I really changed was the order of when the
progress bar window closes. So I'm also very surprised! :)
I'll try making a version with the logging, so that I can be sure that it's
not something mysterious about writing that log file that's saving the day.
--Joe
On Mon, Jan 4, 2021, 11:47 AM Catie Patterson<EMAIL_ADDRESS>wrote:

Oh, I forgot to mention that I did search for the words that were supposed
to be added, and they were in fact added. Success!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/JASchilz/AnkiSyncDuolingo/issues/28#issuecomment-754179024,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABO2Q4EIKQZMQTOYTHHFWUTSYILODANCNFSM4VHK4TIA
.

@JASchilz Well, I had the exact same issue. I pulled down your latest build and now it works! Thanks! Love this plugin!

@JASchilz Well, I had the exact same issue. I pulled down your latest build and now it works! Thanks! Love this plugin!

Hi @cmcdevitt and @catie-patterson ! Thanks again for reporting this and helping me track it down.
I've made a release based on the version that solved your problem. I took out the logging/debugging and only left in the changes that I made to how the plugin closes the window.
I'm hoping that I left in the part that actually solves your problem! If you have an opportunity, could you re-install this from AnkiWeb? The code is 557761805. Could you let me know if this also works for you? Thank you! :)

Hi @cmcdevitt and @catie-patterson ! Thanks again for reporting this and helping me track it down.
I've made a release based on the version that solved your problem. I took out the logging/debugging and only left in the changes that I made to how the plugin closes the window.
I'm hoping that I left in the part that actually solves your problem! If you have an opportunity, could you re-install this from AnkiWeb? The code is 557761805. Could you let me know if this also works for you? Thank you! :)

@JASchilz Uninstalled and installed your new release. I will run this tomorrow after my Duo Lingo session.

@JASchilz Uninstalled and installed your new release. I will run this tomorrow after my Duo Lingo session.

@JASchilz I have had two pulls (over two days) successfully get the words from DuoLingo! Thanks

@JASchilz I have had two pulls (over two days) successfully get the words from DuoLingo! Thanks

It sounds like this issue was resolved last year. Feel free to re-open it if the problem is re-occuring.
Also note that I recently overhauled the add-on for better compatibility with Anki versions 2.1.50+. I'd recommend upgrading to the latest version of the plugin if you're running into any weird problems.


Add role locking support

This PR adds the ability for one to "lock" roles, thus making it that any ranking commands will refuse to rank people to that role
In case you're curious, here's what the different commands do in case of a locked rank

For setrank, if one were to supply a locked rank ID, the command will fail
For promote and demote, if one were to supply a locked rank ID, the command will ask the command author if they want to rank the user to the next rank available

If there are any bugs, please let me know

This would be very easy to implement on our own,
`
//  this is not actual code useable within QBot
if (personsRank +1 == ranktoskip){
rank(Use, personsRank + 2);
}
`


Level 12

I think this answer is correct, but it won't recognize. Is this a bug? Thank you

This isn't a correct answer. Segments AC = DJ, CB = JL, but AB =/ DL and none of the angles are necessarily equal. Try moving things around by holding the right mouse button, it should help you see what you need to do.


chore: bdd-gh-1587639967 to 0.0.1

chore: Promote bdd-gh-1587639967 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


first pass at [WB-10211]. Create new empty dir if no reqs found.

Fixes WB-10211
Description
When no requirement file is found, changes the requirement prefix from "" to now create an empty env/ folder so that the docker image build doesn't fail.
Testing
I created a github project with and without a requirements file (different branches)

@KyleGoyette Best way to debug CircleCI testing failures involving cuda (test_launch_cuda_flag)? Might I need access to a cuda enabled machine?

Good question, if you check the Tests tab on Circle, you can see that one has been marked flakey. Since no real changes have been made to the ticket since things were passing, you can assume that this is flake. You can test this locally to ensure it is indeed flake and if it is, just squash and merge it


Team #2 Review (VnV Report): Missing Automated Test

@samm82
Summary The automated tests running in the project only include 682 tests from 3rd party libraries, not the test 'the Mac-AR team has created'.

Also the unit test CI is not reporting the result of tests created by the team or the code coverage report. Not sure how the unit tests are conducted if the team is not using UTF

Deadline April 4th
Estimated Work Hours 10 hrs

Our own branch of unit testing has not been pushed to main as of yet

We have automated tests with CI/CD on Github, as well as automated tests that we have to run manually on Unity.


Trouble connecting dual web adaptors

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request

Module Version

4.1.0
Affected Resource(s)

ArcGIS_Server, Web Adaptor
Configuration Files

ags.json
{
    "AllNodes": [

        {
            "NodeName": "<IP_ADDRESS>",
            "Role": [
                "Server",
                "ServerWebAdaptor"
            ]
        },
        {
            "NodeName": "<IP_ADDRESS>",
            "Role": [
                "Server",
                "ServerWebAdaptor"
            ]
        }
    ],
    "ConfigData": {
        "Version": "11.1",
        "ServerRole": "GeneralPurposeServer",
        "ServerContext": "maps",
        "DownloadPatches": true,
        "ForceLicenseUpdate": false,
        "Credentials": {
            "ServiceAccount": {
                "Password": "***",
                "UserName": "svcaccount",
                "IsDomainAccount": false
            }
        },
        "Server": {
            "PrimarySiteAdmin": {
                "UserName": "theadmin",
                "Email"<EMAIL_ADDRESS>                "Password": "***"
            },
            "ExternalLoadBalancer": "sub.domain.com",
            "LicenseFilePath": "C:\\geo-cfn-init\\resources\\licenses\\generated.prvc",
            "Installer": {
                "Path": "C:\\geo-ami-resources\\ArcGIS_Server_Windows_111_185208.exe",
                "InstallDir": "C:\\Program Files\\ArcGIS\\Server",
                "InstallDirPython": "C:\\Python27",
                "PatchesDir": "C:\\temp\\patches",
                "PatchInstallOrder": [
                    ""
                ],
                "EnableArcMapRuntime": true,
                "EnableDotnetSupport":true
            },
            "ServerDirectoriesRootLocation": "\\\\<IP_ADDRESS>\\gis-server\\arcgisserver\\directories",
            "ConfigStoreLocation": "\\\\<IP_ADDRESS>\\gis-server\\arcgisserver\\config-store"
        },
        "WebAdaptor": {
            "AdminAccessEnabled": true,
            "Installer": {
                "Path": "C:\\geo-ami-resources\\ArcGIS_Web_Adaptor_for_Microsoft_IIS_111_185222.exe"
            }
        }
    }
}

Expected Behavior

Two AWS VMs, each with ArcGIS Server and Web Adaptor installed. Should configure both web adaptors with both servers.  (Although I'd be fine with each server having its own web adaptor)
Actual Behavior

11/29/2023 2:27:40 PM: [EC2AMAZ-XYZ]:                            [[ArcGIS_WebAdaptor]ConfigureServerWebAdaptor<IP_ADDRESS>] Output of execution:- ERROR: Unable to connect to Web Adaptor URL : https://<IP_ADDRESS>/maps/webadaptor.
11/29/2023 2:27:40 PM: [EC2AMAZ-XYZ]: LCM:  [ End    Set      ]  [[ArcGIS_WebAdaptor]ConfigureServerWebAdaptor<IP_ADDRESS>]  in 102.6170 seconds.
11/29/2023 2:27:40 PM: [EC2AMAZ-XYZ]: LCM:  [ End    Set      ]
11/29/2023 2:27:40 PM: Operation 'Invoke CimMethod' complete.
Trace-DSCJob : 11/29/2023 2:27:40 PM: PowerShell DSC resource ArcGIS_WebAdaptor  failed to execute Set-TargetResource

functionality with error message: [ERROR]:- ERROR: Unable to connect to Web Adaptor URL :

https://<IP_ADDRESS>/maps/webadaptor.

At C:\Program Files\WindowsPowerShell\Modules\ArcGIS\4.1.0\ArcGIS.psm1:261 char:5
+     Trace-DSCJob -Job $Job -JobName $ConfigurationName -DebugMode $De ...

+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
    + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Trace-DSCJob

Trace-DSCJob : 11/29/2023 2:27:40 PM: The SendConfigurationApply function did not succeed.
At C:\Program Files\WindowsPowerShell\Modules\ArcGIS\4.1.0\ArcGIS.psm1:261 char:5
+     Trace-DSCJob -Job $Job -JobName $ConfigurationName -DebugMode $De ...
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
    + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Trace-DSCJob

Steps to Reproduce

# Running as the same user that runs ags (see tpl)
$pw = ConvertTo-SecureString "***" -AsPlainText -Force
$credential = New-Object System.Management.Automation.PSCredential ($usr, $pw)

# Call DSC
Invoke-ArcGISConfiguration `
  -ConfigurationParametersFile ags.json `
  -Mode InstallLicenseConfigure `
  -Credential $credential `
  -DebugSwitch

Important Factoids

The end result looks to be fully functional. When I log into server manager I see both machines participating in the site, and both machines listed as web adaptors. The problem is that an ERROR log is being written, which it never did before, and my automation then passes that along.  Can work around I guess, but would love to know what's happening.
Also, the error message says I can't reach https://<IP_ADDRESS>/maps/webadaptor   but when I remote into the machine and try the URL, I can reach it. I get a cert warning from chrome, but if I click through I can see it fine. Makes me think there may just be a timing issue?  I can't say for sure.
References
NA

@jhevenor Maybe to see if it is a timing related issue, can you see if it connects successfully on a second run?
Thanks,
Cameron K.

Hi @cameronkroeker, a manual run goes smoothly
Output of execution:-
Configuring the ArcGIS Enterprise Web Adaptor with ArcGIS Server.

Configuring Web adaptor...

Instead of the Output of execution:- ERROR: Unable to connect to Web Adaptor URL I received on the first run.  Not 100% apples to apples, as this ran in a powershell admin window, verses being launched via cfn-init which I think runs as the SYSTEM user (windows server 2019).

@jhevenor is the <IP_ADDRESS> address an external ip or the private ip? This looks like its an AWS environment, so I suspect the <IP_ADDRESS> is the external EIP which may not work to configure the web adaptor. I believe you will need to use the private ip.
Thanks,
Cameron K.

Hi @cameronkroeker ,  the 10.155 is an internal IP address. No public IPs are available on the VMs (accessed through app gateway).

Hi, was there a solution for this? I'm experiencing the same issue! internal IP as mentioned above

Hi, was there a solution for this? I'm experiencing the same issue! internal IP as mentioned above


Improved BMI160 support

Implements proper data sampling.
Adds BMI160-specific defines, experimental magnetometer support, axis remapping, new accelerometer calibration method, initial temperature calibration support.
Limits send rate to 120hz for BMI160.

This is not the final version, and there will be breaking backwards compatibility changes due to lack of proper calibration config serialization, but consider merging this anyway - the current BMI160 implementation has many flaws.
This should be a minor version bump, as major version 0 implies initial development phase and should not be considered stable anyway.
Tested on ESP8266 and ESP32.
Needs basic testing with other IMUs.

i want some ppl to review it and test if it doesn't break BNO085

Actually @TheButlah what license should we put at the top of the files now?

You should just remove all of the license blurbs in the files. License blurbs are dumb, and aren't actually necessary. It only creates unecessary noise in the code.

they're useful when the file is copied from somewhere

they're useful when the file is copied from somewhere

If the file is copied from somewhere, thats a problem. Should not do that. Its no longer clear now which file is licensed under slimevr and which is licensed under another license.
I suggest that if a file is copied. Mark it as such and put a link to the original license in that file. but for slimevr authored files, don't do that.

@0forks can you summarize in this PR which if any third party libraries have been added, whether they were modified, and link to the commit that the code was from?

So, currently the third party code that was added/modified is the following:

VQF v2: https://github.com/dlaidig/vqf/commit/1f76231acd6410a1657c787d028779b1a14fc2fb
Modified updateGyr(const vqf_real_t gyr[3], double gyrTs) to add gyrTs time delta) to support gyro timestamps, everything else is assumed to be coming at fixed rate, as recomputing filtering coefficients for accel/mag would be very slow, and it seems to perform decently regardless.

Added a separate rest detection class for use during accel calibration and fusion where rest detection isn't provided:
https://github.com/SlimeVR/SlimeVR-Tracker-ESP/blob/4cd8cfe891374e9d15031b3f5eec6cd6394a795d/src/motionprocessing/RestDetection.h#L1-L10

Some fusion code was modified to compile with C++17:
The beta variable in Madgwick interferes with something global, needed simple renaming)
https://github.com/SlimeVR/SlimeVR-Tracker-ESP/blob/4cd8cfe891374e9d15031b3f5eec6cd6394a795d/lib/magneto/madgwick.cpp#L3

Mahony fusion uses static global variables, which won't work for multiple instances:
https://github.com/SlimeVR/SlimeVR-Tracker-ESP/blob/4cd8cfe891374e9d15031b3f5eec6cd6394a795d/lib/magneto/mahony.cpp#L32
Currently only 6DOF Mahony is moved to a separate class:
https://github.com/SlimeVR/SlimeVR-Tracker-ESP/blob/4cd8cfe891374e9d15031b3f5eec6cd6394a795d/lib/magneto/mahony.h#L32-L38

Some additions were made to BMI160 library, particularly magnetometer support, timestamp readout, FIFO header definitions, error handling. The library needs to be completely rewritten though.

I do realize that there are many code style and consistency issues with library code here, perhaps fixes could be done in another PR, if that is okay, as this one is already huge.
Maybe we should remove other fusion code in favor of (Basic)VQF. And as it will require modifying code for other IMUs and testing on hardware I don't have, I also think this goes slightly out of scope for this PR.

I do realize that there are many code style and consistency issues with library code here, perhaps fixes could be done in another PR, if that is okay, as this one is already huge.

I'm working on a fork based on v3dev that makes IMU count scalable and adds an SPI interface option for BMI160. I found that the bmi160 library was copied from a source with incompatible license, so I had to find a new library and fork that.
This requires at least some refactoring in multiple files. We could address the style issues there in some way.

IMU count scalable and adds an SPI

You may run into fusion scalability issues beyond 4 IMUs on 8266 as it doesn't have an FPU, I hope you have an ESP32 or something else with an FPU.

You may run into fusion scalability issues beyond 4 IMUs on 8266 as it doesn't have an FPU, I hope you have an ESP32 or something else with an FPU.

I do have esp8266, but I don't expect to need more than 4 IMUs connected. Maximums can be set for each combination of mcu, imu, and interface to prevent overloading hardware.

perhaps fixes could be done in another PR, if that is okay, as this one is already huge.

Agreed.

I found that the bmi160 library was copied from a source with incompatible license,

To confirm, @0forks you did not add any non-mit licensed code in this PR right? The incompatible license rexa is referring to predated this PR if I understand correctly?

To confirm, 0forks you did not add any viral licensed code in this PR right (LGPL, GPL, etc)? The incompatible license rexa is referring to predated this PR if I understand correctly?

The addition of BMI160 library associated with an LGPL predated this by PR by about 2 years based on the records I can see. I of course can't speak for anything 0 added.

you did not add any viral licensed code in this PR

VQF is MIT licensed, and the BMI library was already in the main branch. I think I did attribute all third party code I've added correctly.
Though I also did use some code from mag branches as reference, when adding mag support: https://github.com/deiteris/SlimeVR-Tracker-ESP/blob/hmc-mag/lib/bmi160/BMI160.cpp#L115


Improve queue page title for students

Currently, the queue page shows the total number of tickets in the queue for both TAs and students. While useful for TAs who are there to help all the students, the most pressing concern for a typical student — like me! — is “when will the TA help me?” This PR attempts to answer this question for students by showing them the number of tickets that are in line ahead of them, and hiding the number icon when the student doesn’t have any tickets waiting so they aren’t distracted while working.
This is my first time contributing to either this project or a Meteor project in general, so any feedback would be appreciated.

Thanks for the submission! What do you think about keeping the existing count for anyone that doesn't have a ticket in the queue, rather than just TAs?

This was my personal feeling about that, but I’m happy to change it too.

[hide] the number icon when the student doesn’t have any tickets waiting so they aren’t distracted while working.

Love it, thanks so much!

Hey @gregcarlin, what’s the process to get this deployed to signmeup.cs.brown.edu?

I have a meeting scheduled with @rc9575 on 11/17 - we should be able to deploy it then. Thanks for waiting!


npm module does not install on non-mac platforms

The newest version gives the following error on Ubuntu 14.04
pm ERR! notsup Unsupported
npm ERR! notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm ERR! notsup Valid OS:    darwin
npm ERR! notsup Valid Arch:  any
npm ERR! notsup Actual OS:   linux
npm ERR! notsup Actual Arch: x64

npm ERR! System Linux 3.13.0-74-generic
npm ERR! command "/usr/bin/node" "/usr/bin/npm" "install" "imply-pivot"
npm ERR! cwd /mnt/tmp
npm ERR! node -v v4.4.7
npm ERR! npm -v v2.15.8
npm ERR! code EBADPLATFORM
npm ERR! not ok code 0

ops, apologies about that. fsevents is a dev module and it was roped in due to npm shrinkwrap. The dev dependancies were removed from the shrinkwrap. Please try again with the latest 0.9.11 Pivot.


Dark mode visibility

The header (To-Do List) is not very visible in Darkmodel
I propose changing the color

Could you please assign me this

Could you please assign me this

please create your own issue will assign you !


[api-docs] fixed a small but annoying issue

A new commit was made into the api-docs repo. This issue was created automatically. Need to review if we made any change to the library for this commit.
https://github.com/discord/discord-api-docs/commit/9427d9e2801baf84096806e4f9c59780e29eac9a

ncn


How to deprecate a single parameter

https://github.com/palantir/tslint/issues/4281 is an example of a scenario where a single parameter is deprecated: moving from multiple standalone arguments to a single arguments object, while maintaining backwards compatibility.
Can we mark just that parameter as deprecated? Something like:
export interface IFormatter {
    /**
     * Formats linter results
     * @param failures - Linter failures that were not fixed
     * @param @deprecated fixes - Fixed linter failures. Available when the `--fix` argument is used on the command line.
     */
    format(failures: RuleFailure[], fixes?: RuleFailure[]): string;
}

Hmm... I find it odd to deprecate only part of an API signature.  Would this be a better approach?
export interface IFormatter {
    /**
     * Formats linter results
     * @param failures - Linter failures that were not fixed
     */
    format(failures: RuleFailure[]): string;

    /**
     * @deprecated Use {@link IFormatter.(format:1)} instead.
     */
    format(failures: RuleFailure[], fixes?: RuleFailure[]): string;
}

This way the new contract and deprecated contract are each clearly described.
Also it follows the standard convention that @deprecated should always include a recommendation of what to use instead.

That's a great suggestion, thanks @pgonzal! I can't think of a situation off the top of my head in which this wouldn't be doable, but will try.

I've noticed an issue. @deprecated will affect to the overloads.
In the below func(a) is also marked as @deprecated
interface Foo {
  /** @deprecated */
  func(a, b);
  func(a);
}

This can easily be fixed by inserting some TSDoc on func(a)
interface Foo {
  /** @deprecated */
  func(a, b);
  /** fixes being marked as deprecated  */
  func(a);
}

But this trick doesn't work on functions outside of interfaces/classes
/** @deprecated */
function func(a, b);
/** new stuff */
function func(a) {}

This would be greatly helpful for union types.
export type FormatName =
    | 'date-month-year-and-twelve-hour-time-with-period'
    | 'date-year-month-date'
    | 'month-name-with-day-number'
    | 'month-name-with-ordinal-date'
    /**
     * @experimental
     */
    | 'relative'
    | 'twelve-hour-time-with-period'
    | 'twelve-hour-time'
    | 'twenty-four-hour-time';


VSCode 1.18.1 and wslgit

Running Windows 10 with the Fall Creators update, removed the password requirement as per the documentation, and VSCode sort knows a version control system is in place, but it looks broken, and files are never flagged as dirty, and git blame doesn't work.
Is this potentially because the path to my files contains a space in it?

Filenames with spaces should work just fine. Are changed files listed correctly after manually clicking the "Refresh" button? If so, then this is most likely due to some git command waiting for input.
For example, the VS Code Git plugin tries to do a git fetch initially, which might require authentication. You can check with ps aux in a WSL shell if there are any running git commands that did not finish. You can then try to manually run these commands in a WSL shell to see if they require any user input.
Also, after killing these hanging git processes, the Git plugin should work correctly and list changed files, etc.
Regarding git blame, is this a separate plugin? I cannot find this functionality in the standard Git plugin.

I don't see any change files listed. None of the actual git functionality is working unfortunately. I am seeing a lot of what is showing up in #11
git blame is indeed a separate plug in. I can deal with this separately.

Are you already on VS Code 1.19 now? I just uploaded a new release which fixes #11.
Could you please try with the new version and report back?

Upgrade to both the newest version of VSCode (1.19) and wslgit. Still seeing the same thing.

In this screen shot, i added a new line -- const FURTHER = 50; and its not showing as changed, and not VSCode is still behaving odd under Source Control.

Unfortunately, I can't reproduce your problem.
A few things to test:

Post the output of running ps aux in WSL while VS Code is open (and showing the behaviour above)
Try opening a new, empty git repository in VS Code (i.e. create a new folder and run git init)
Start VS Code without any plugins by running code --disable-extensions on the command line
Does running wslgit.exe status etc. work from the windows command line?

I tried everything you suggested. Still no luck. Running wslgit.exe status does work which I find odd. I've attached screenshots of my setup, and the results of the questions you asked. Hopefully it helps.
Results of ps aux

Results of new empty repository. Adding a simple single file.

Settings. No Workspace settings exist.

I noticed you are using zsh. In #1 a user also had issues with a different shell.
Could it be that your shell writes something to stdout when a command is executed, i.e. a greeting message or something like that? Because this would prevent VS Code from correctly parsing the output of Git.
Can you post the output of the Git log from VS Code (View - Output - Choosing "Git" from the dropdown on the right). It should list all Git commands that VS Code tries to execute, and maybe also some errors.
What is the exact output if you run these commands manually from the command line, i.e.
cd git-repository
C:\tools\wslgit\wslgit.exe rev-parse --show-toplevel

This should just print the Windows path to the current Git repository, i.e. something like
c:\Users\someone\git-repository

Maybe you could also try to switch your shell back to bash.

You definitely seem to be on to something. I ran the command you suggested in zsh and bash and I did get the path in both cases, but differently.
In zsh, I got it in this format
/c/Users/someone/repo
In bash, I got it in this format
`C:\Users\someone\repo
Upon making the change to bash, things have begun to work as expected save for one thing. I'm still seeing numerous .Git entries under Source Control Providers. Good news is one of those is correct and changes are now properly being flagged per file.

Great! I wonder why it doesn't work with zsh. The zsh result is really strange, as the path inside WSL would be /mnt/c/Users/..., and wslgit translates that to c:\Users\... for Windows. I have no idea where this /c/Users/... format comes from.
How did you set zsh as your shell? AFAIK chsh does not work in WSL, does it? Do you exec it inside .bashrc or similar?
I also noticed these .Git entries occasionally. I see them for example then opening a file outside of the git repository, e.g. the user settings. I've already commited a possible fix for that, but did not yet release a new version of the executable.

Ah!
You're seeing /c/Users/... because I'm using docker on windows from the ubuntu docker-ce client (our build scripts are written in bash and this was the only way to make it work). This required me to do a mount --bind from /mnt/c to simply /c/ as docker mounts differently for windows as it does for ubuntu (Setting up docker for WSL
I got zsh working by simply creating a .bash_profile, and from within it I check that I have a .bashrc and if so, load it. Within the .bashrc I simply kick off zsh. This keeps everything consistent.
Hope this helps!

I can confirm the same issue as @riula. Me too had to do a mount --bind from /mnt/c to simply /c/

Ah, that's interesting. Why does Git return paths for the different mount points (/c/... vs. /mnt/c/...) depending on the shell? I guess it has something to do with how the shells setup the environment.
In any case, wslgit currently explictly checks for paths starting with /mnt/X, where X is a Windows drive letter, and only converts those. All other paths/strings are passed unchanged. That explains why it does not work.
Maybe you can only start zsh in your .bashrc if there is a terminal attached, like this:
if [ -t 1 ]; then
  exec zsh
fi

This way you should be able to use zsh as your interactive shell, but use bash when called from other processes (like wslgit). However, I haven't tested this.

@jupbarrera Do you also use zsh as your shell? Does it work with bash? If so, can you try the solution posted above to only start zsh when a terminal is attached?

@andy-5 I actually use that exact set up in my .bashrc file. Unfortunately that doesn't work.


[ISSUE #1700] Add shenyu-dashboard as submodule

For #1700

Codecov Report

Merging #1775 (e6ac035) into master (d350706) will decrease coverage by 0.29%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1775      +/-   ##
============================================
- Coverage     62.49%   62.20%   -0.30%
+ Complexity     2392     2383       -9
============================================
  Files           482      482
  Lines         10318    10318
  Branches       1043     1043
============================================
- Hits           6448     6418      -30
- Misses         3355     3382      +27
- Partials        515      518       +3

Impacted Files
Coverage Δ

...enyu/client/tars/TarsServiceBeanPostProcessor.java
32.43% <0.00%> (-27.03%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
55.78% <0.00%> (-8.43%)
:arrow_down:

...henyu/plugin/httpclient/NettyHttpClientPlugin.java
57.14% <0.00%> (-2.05%)
:arrow_down:

...elimiter/handler/RateLimiterPluginDataHandler.java
69.69% <0.00%> (-1.52%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d350706...e6ac035. Read the comment docs.


Logic and logging improvements; typo cleanup

I've made some minor updates to detect structure home/away state changes not made by the app so that it can respond accordingly. Otherwise nest.getPresence() was just a dummy function, returning the state of the structure at the time the app was initialized.
Unrelated: thank you, @aaronstaves, for this wonderful solution to a simple, but difficult-to-get-at problem. I now have much more control over situations where my Nest can't see me when I'm still home.

Thats a lotta commits! :)  I'll take a look at this tonight and try running it locally and make sure it all works.  When it does I'll probably merge it in later this week.
Thanks for the cleanup, and suggestions.  I'm still new-ish to node, and to be honest this project is still kind of a hack at moment.  Thanks for the input!

Sure thing! It's rare that I check out someone's code and don't get started tweaking at it, so I like to give back. I've been running my branch through its paces here at home for the last day with no trouble so far -- toggling states from other apps, watching it respond, putting my target device in Airplane mode -- and it's handled everything just as expected. Let me know how it works out for you. And thanks again. :+1:


feat: add fiveG Core gnB library

Description
This PR adds the fiveg_core_gnb library according to the interface specification.
Note: the library is committed but will be removed before merging and published via charmcraft publish-lib; then it will be fetched again via charmcraft fetch-lib and committed again.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that validate the behaviour of the software
[ ] I validated that new and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have bumped the version of the library

UT coverage can be increased. ie. empty plmns list, missing relations, invalid tac over the upper range limit , PLMNs range values....


Fixes for ModBrowser in non-active scenes

ModBrowser and ViewManager used UIUtilities.FindComponentInScene or FindComponentInScenes instead of GetComponent[s]InChildren. The problem with this, aside of significant performance impact, is that it only looks in the active scene but UIs may be loaded additionally as separate scenes, so this can easily break. The objects ModBrowser and ViewManager look for are currently children, so GetComponent[s]InChildren() works (and is much more efficient). Otherwise, you may want to consider using Resources.FindObjectsOfTypeAll().
This changeset does not replace the singleton lookups, where the same issue applies. With those, however, the current approach is really just a fallback, so it's much less critical.

Thanks Jashan! This is an issue that was at the top of my TODOs, as another developer was having a similar problem.


problems after uninstall plugin

After uninstlall ddlc plugin from PhpStorm all anime images have not been deleted and still clutter program interface. WTF?

Lol, so yeah that's a thing.
Here I got this for you
http://www.material-theme.com/docs/faq-troubleshooting/
Let me know if you need more help :)

Also, if that does not work do this.

Re-install the plugin

Toggle club member (this shows and hides the anime)

Re-Uninstall the plugin

????

Profit!

I'll also put something somewhere that should prevent this happening in the future :)


app cert and app templates

Docs Build status updates of commit b926ba5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/whats-new.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Persist @bind value state if tab closes accidentally

For example, suppose that someone works in a PlutoSliderServer notebook and accidentally closes the tab. It would be nice to save and reload the state when we reload the page, for example by saving in the localStorage

Hmmm, I found the resetting to be what I expected, it also helps recover from problems.
Maybe we could store the state, and upon refresh, show a button that offers to "Reset inputs to previous state"?


Run it from within Python

Hi,
I want to run it from within Python after installing smop. How do I do that? I have a number of matlab files in different folders that I would like to convert to python from within a python script.
Regards

Hello Crack
Normally you install smop and then use it from command line or from Makefile.  If you need python-level API, you can do this as follows:  assuming you have matlab file foo.m and you want to do whatever is equivalent to

smop -o- foo.m

or (which is the same,  but avoids the installation)

export PYTHONPATH=.
python main.py -o- foo.m

First, you set the arguments

import sys
sys.argv.append("foo.m")

If you have many arguments, use

sys.argv += "foo.m bar.m bzz.m".split()

Second, you play with location, installation params etc until the following works

import smop
smop.main.main()

This interface will probably change in the next version of smop

Thanks a lot. That was helpful.


bash, dash ash or whatever shell on docker container

So I'm running the docker version and sometimes I need to run some commands that require a response.
I can't seam to run any of the popular shells on the docker version (I'm using the latest docker container BTW), dunno if I missed something but the installation docks don't give much insight on what is available.
Is it possible to modify the latest container image to feature a common shell?
Cheers

Hi
I wanted to keep this, but we had some people insisting this was bad practice and we should not have it in the container. I disagree and only use the Dockerfile marked with Debug since it contains a shell.
I suspect I will ditch the current Dockerfile at some point in the future in favour of our build system, I'll keep this in mind to fix it.
In the meantime, I would use the Debug image if you need shell. Sorry for the inconvenience.
For reference, this is the discussion changing the container images: https://github.com/juanfont/headscale/pull/214
at the time, we gave in to the arguments, but they have been deemed highly impractical and when we have some time, we will revert this. Life is to short to deal with this.


oData v4 server messages encoding issue for header sap-messages

OpenUI5 version: 1.81.1
Browser/version (+device/version): chrome
Steps to reproduce the problem:
Just used the SAP CAP 4.x odata messages
req.warn({
  code: 'QUANTITY_WARNING',
  message: 'Menge 2 nicht möglich und auf 4 erhöht!',
  target: 'Quantity'
})

Sadly, CAP currently does not support bound messages (only errors), but anyhow,
errors from POST are shown correctly, but header messages like
HTTP/1.1 200 OK
x-powered-by: Express
x-request-id: kecyos25
x-frame-options: SAMEORIGIN
odata-version: 4.0
content-type: application/json;odata.metadata=minimal;IEEE754Compatible=true;ExponentialDecimals=true
sap-messages: [{"code":"QUANTITY_WARNING","message":"Menge 2 nicht möglich und auf 4 erhöht!","target":"Quantity","numericSeverity":3}]
date: Thu, 27 Aug 2020 15:28:11 GMT
connection: keep-alive
content-length: 280
Vary: Accept-Encoding

Is shown wrongly in message dialog.
What is the expected result?
Menge 2 nicht möglich und auf 4 erhöht!
What happens instead?
Menge 2 nicht mÃ¶glich und auf 4 erhÃ¶ht!
Any other information?
Using request.error, where message will be send as http post,
the text and german umlaute are shown correct.
BR
Holger

Hello @hschaefer123 !
"HTTP 1.1 says that the default charset is ISO-8859-1" The "content-type" header above does not specify a charset, like UTF-8. Are you sure your proxy/server is sending the right encoding?
Best regards,
Thomas

Hi Thomas,
i am using SAP CAP 4.x and created a ticket, because i CAP currently does not allow all kind of bound messages (only error).
See Ticket
Incident 561198/2020
The guys told me, that this is correctly from CAP side (nodejs).
So using CAP, the messages are correctly in MessagePopover, but not transfering messages using headers.
If this is wrong, maybe the SAP CAP team needs to fix this.
I am currently part of the SAP FE v4 Beta phase and testing something, but thiis seems to be a problem in general.
If the header is wrong, maybe you can explain it to them (see my issue response).
BR
Holger

IMO, this is a CAP issue. Our internal Wiki (which from my POV acts as a specification of the SAP extensions to the OData protocoll (for SAP colleagues: I refer to page odata/Error%2C+Warning%2C+and+Info+Messages)), says
OData 2.0:

The content of the SAP-Message header uses the same format (Atom/XML or JSON) as the response body and is encoded according to the rules for HTTP header fields:
All optional whitespace (indentation and line breaks) is removed, especially (in hex notation) 09, 0A and 0D
Control characters (00-1F / 7F) and Unicode characters beyond 00ff are encoded according to the content-type:

XML: � or &#xdddddd, with d being a hex digit
JSON: \udddd or \udddd\udddd (see  https://tools.ietf.org/html/rfc7159#section-7)

OData 4.0:

The content of the SAP-Messages header uses JSON (the preferred format in OData 4.0) and is encoded according to the rules for HTTP header fields:
All optional whitespace (indentation and line breaks) is removed, especially (in hex notation) 09, 0A and 0D
Control characters (00-1F / 7F) and Unicode characters beyond 00ff are encoded according to the content-type:

\udddd or \udddd\udddd (see  https://tools.ietf.org/html/rfc7159#section-7)

I first thought that the reference to content-type leaves some room for interpretation (as content-type also might contain a charset hint), but a) this wouldn't make much sense as other sources say, that only ASCII content is reliable in HTTP headers and b) after reading the OData 2.0 part again, I think the reference to content-type only aims at the difference between XML and JSON.
@ralfhandl maybe you can confirm (or correct) my interpretation.
If I'm not mistaken, then CAP needs to add a proper encoding of characters other than 0x20-0x7f). On the client, JSON.parse should already do the right decoding:
JSON.parse("{\"name\":\"" + "\\" + "u00ee\"}") // "î"

@codeworrior Your interpretation is correct, I added a reference to the RFC defining allowed header field values (only visible ASCII characters) and removed the reference to "content-type".

Hi,
unfortunately CAP only support UTF-8 right now. So a possible workaround would either be to use UTF-8 for the complete App i guess, or we could put charset=utf-8 into the Content-Type / Accept headers. Would that work for UI5?
For example if we modify the content-type header to look like this:
content-type: application/json;odata.metadata=minimal;IEEE754Compatible=true;ExponentialDecimals=true; charset=utf-8

BR
Samuel

@SamuelBrucksch You can give it a try, but per HTTP spec, the content encoding has nothing to do with the headers, Therefore the browser does not (or is not guaranteed to) decode UTF-8 in the header. And, proxies in between also might have issues with non-ASCII characters in the headers.
Aligning with the sap-message spec IMO is the only robust (and valid) solution.
Would https://stackoverflow.com/questions/31649362/json-stringify-and-unicode-characters be of any help for CAP?

Hi,
personally i would prefer @codeworrior solution, escaping the header values concerning odata v4 spec:
https://tools.ietf.org/html/rfc7159#section-7
The cap message api distinguishes between bound messages (part of the return) and unbound messages (sap-messages header),
so only for the header messages, non ascii chars needs to be encoded accordingly, while body messages still can be UTF-8 escaped (if i understood the discussion right ;-)
Doing it this way, we will not run in trouble with CAP2CAP, Cloud SDK, CPI or proxy scenarios in between the whole access chain.
@SamuelBrucksch
It is problematic, to encode just the values for the header messages?
At the moment, i can give it a try with my local project, because SAP FE v4 beta project is still on 3.x, where req.warn is not available.
I also asked Sandeed R (my beta contact person), if he maybe can push my request to control the severity of bound messages to be able to more fine granular control severity independent from bound/unbound.
BR
Holger

I will discuss this with the team and we will try to come up with a solution.

Hi,
we improved our impl like mentioned in the stackoverflow link to use unicode for special characters. This should be available in the next version of<EMAIL_ADDRESS>or 2.4.0 whichever comes first.
I think as it is not really related to openui5 this can be closed now.
BR
Samuel

I am closing this. Post a comment if there are new details

I am closing this. Post a comment if there are new details


Text align for header does not work

We started to use theming for the pdf output. Really nice feature but heading alignment does not work.
heading:
   align: right

does not result in heading text aligned to the right.
This does work for the title page:
title_page:
   align: right

Are you sure you're using alpha 12 or 13? This issue was resolved in alpha 12. See #343.
If you are still having a problem, can you share your whole theme file?

Thanks, for the clarification. I'm still using alpha11, as the Java wrapper has not been released for 12 or 13.

To allow you to test alphas quicker, why don't you switch to using the gem directly? AsciidoctorJ PDF just conveniently wraps up Asciidoctor PDF as a jar, but JRuby can still use the native gem.
Here's an example when using Gradle: https://github.com/asciidoctor/asciidoctor-gradle-examples/blob/5f88408e1788562ff363dbb61e2de04f0fd11121/asciidoc-diagram-to-html-example/build.gradle
Just replace asciidoctor-diagram with asciidoctor-pdf (or add it if you're also using asciidoctor-diagram).
plugins {
    id 'org.asciidoctor.convert' version '1.5.3'
    id 'com.github.jruby-gradle.base' version '1.3.3'
}

apply plugin: 'org.asciidoctor.convert'

dependencies {
    gems 'rubygems:asciidoctor-pdf:1.5.0.alpha.13'
}

asciidoctorj {
    version = '<IP_ADDRESS>'
}

asciidoctor {
    dependsOn jrubyPrepare
    requires = ['asciidoctor-pdf']
    gemPath = jrubyPrepare.outputDir
    backends 'pdf'
}

There's no need to wait on AsciidoctorJ for non-core modules.

Thanks for the tip with directly using  asciidoctor-pdf. It worked in the example code, but when I tried it in my "normal" document, it failed and I were not able to solve it. Fortunately @robertpanzer helped me to compile locally the j-wrapper, so I'm now using alpha.13.
I think margin-top does not work:
heading:
  h1:
   margin_top: 200
   align: right

align works now but "margin_top" does not. Should it work?

The margin top on heading currently only works when the heading follows other content. It doesn't work when the heading is at the top of the page. Let's open that as a separate issue.

Thanks for the tip with directly using asciidoctor-pdf. It worked in the example code, but when I tried it in my "normal" document, it failed and I were not able to solve it.

I'm really curious to know why it failed. That should not be. Can you give me access to the document / repository you're converting.

@mojavelinux we have our own little wrapper Gradle plug-in so that we configure the source location, etc. In this plug-in I was not able to change our logic to use asciidoctor-pdf. directly.
Repo: https://github.com/vogellacompany/com.vogella.gradle.plugins/tree/master/com.vogella.gradle.plugin.asciidoc
Document: Anything, use gradlew createPdfBook
But I don't expect you to invest in our build script, I think if necessary we can adjust it, the whole Ruby world is a bit strange for me. IIRC I had the error "svg something required Ruby 2.0.0" and ruby --version showed me ruby "2.3.1p112".

Indeed, since you have levels of abstraction, the setup is a bit more nuanced.

"svg something required Ruby 2.0.0" and ruby --version showed me ruby "2.3.1p112".

It's important to keep in mind that the Ruby on your system is not the Ruby that is being used by AsciidoctorJ. Instead, AsciidoctorJ uses the Ruby version provided by JRuby (via the classpath). By default, the JRuby used by AsciidoctorJ is JRuby 1.7, which is Ruby 1.9.3. The best thing to do, and something I recommend, is to switch to JRuby <IP_ADDRESS> (which is going to be the default in AsciidoctorJ 1.6.0). But again, since you are using plugins, it might be easier just to wait for the beta release of AsciidoctorJ.

It's important to keep in mind that the Ruby on your system is not the Ruby that is being used by AsciidoctorJ

Big ah! I was poking around this for a while. At least now this makes sense. Thanks for the clarification.

When converting with the asciidoctor-gradle-plugin it might already work to
add a dependency on org.jruby:jruby-complete:<IP_ADDRESS> to the classpath in
the buildscript configuration at the same place where you added the
dependency on asciidoctorj-pdf.
Just a wild guess though.
Am Donnerstag, 22. September 2016 schrieb Dan Allen :

Indeed, since you have levels of abstraction, the setup is a bit more
nuanced.
"svg something required Ruby 2.0.0" and ruby --version showed me ruby
"2.3.1p112".
It's important to keep in mind that the Ruby on your system is not the
Ruby that is being used by AsciidoctorJ. Instead, AsciidoctorJ uses the
Ruby version provided by JRuby (via the classpath). By default, the JRuby
used by AsciidoctorJ is JRuby 1.7, which is Ruby 1.9.3. The best thing to
do, and something I recommend, is to switch to JRuby <IP_ADDRESS> (which is
going to be the default in AsciidoctorJ 1.6.0). But again, since you are
using plugins, it might be easier just to wait for the beta release of
AsciidoctorJ.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/asciidoctor/asciidoctor-pdf/issues/572#issuecomment-249005474,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHBjpywEPnshkY6krNNP6V0mZiXcrqvks5qsthIgaJpZM4KDScV
.

Correct. In fact, you can just use a resolutionStrategy stanza to force the version of JRuby that Gradle picks when it performs the jar resolution.
buildscript {
  configurations.all {
    resolutionStrategy {
      force 'org.jruby:jruby:<IP_ADDRESS>'
    }
  }
}

That's the brute force approach. That gives you the latest version of Ruby.

Thanks. I keep this bookmarked for the next time I might try this approach. Currently I'm a happy and proud self-build AsciidoctorJ alpha.13 user


fix: Go syntax to add revive

This PR adds revive.
Please check after merging https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/1410 .
For example, this PR fixes the following warning.
pkg/resources/function_grant.go:149:21: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)

pkg/snowflake/user.go:36:31: unexported-return: exported func ScanUser returns unexported type *snowflake.user, which can be annoying to use (revive)
func ScanUser(row *sqlx.Row) (*user, error) {
                              ^
pkg/snowflake/user_ownership_grant.go:72:45: unexported-return: exported func ScanUserOwnershipGrant returns unexported type *snowflake.userOwnershipGrant, which can be annoying to use (revive)
func ScanUserOwnershipGrant(row *sqlx.Row) (*userOwnershipGrant, error) {
                                            ^
pkg/snowflake/user.go:42:44: unexported-return: exported func ScanUserDescription returns unexported type *snowflake.user, which can be annoying to use (revive)
func ScanUserDescription(rows *sqlx.Rows) (*user, error) {
                                           ^
pkg/snowflake/user.go:103:45: unexported-return: exported func ListUsers returns unexported type []snowflake.user, which can be annoying to use (revive)
func ListUsers(pattern string, db *sql.DB) ([]user, error) {

Reference

https://github.com/mgechev/revive

/ok-to-test sha=e89e10d6

pkg/snowflake/user.go:36:31: unexported-return: exported func ScanUser returns unexported type *snowflake.user, which can be annoying to use (revive)

Yeah theres not really a good  reason why these values are unexported, and it certainly was annoying to use them so I agree with this recommendation

@mnagaa thank you for your contribution. After the holidays, I would like to do a video call with you and my manager to discuss the future of the provider. Please contact me at<EMAIL_ADDRESS>if you would like to schedule something.


Ability to see the users most recent profile posts

This could be useful for verifying spigot accounts via a discord bot - However the cache limit would have to be alot lower as it would kinda suck if you had to wait 5 hours to be verified

This has been denied based on the prospective use-case of account verification. The identities PR could be used for such a purpose.


[ACR] Add upload/download code for blobs and manifests

ApiView diff - https://apiview.dev/Assemblies/Review/2d89f5fb7766481c928e41e65fbd4740?diffOnly=True&diffRevisionId=500d32ab2730498084dedadf61d740fc
We are integrating the changes that were made in feature/containerregistry/oci-blob-api and released earlier.
The branch diff shows that all changes have been picked up - https://github.com/Azure/azure-sdk-for-net/compare/mohitc/BlobUpdateToMain...feature/containerregistry/oci-blob-api

API changes have been detected in Azure.Containers.ContainerRegistry. You can review API changes here

API changes have been detected in Azure.Containers.ContainerRegistry. You can review API changes here

/azp run net - containerregistry - ci

API change check for Azure.Containers.ContainerRegistry
API changes have been detected in Azure.Containers.ContainerRegistry. You can review API changes here


Add Microsoft CredScan parser

Add CredScan parser
https://secdevtools.azurewebsites.net/helpcredscan.html

can you update the docs and PR desc with some info i.e. pointer to what scanner this is / their homepage?

@Maffooch I know it's already merged but could you take a look at these comments?


Unbalanced-tuple-unpacking in the from_constituency_trees

If the input tree list is empty, the function from_constituency_trees returns two elements. In the regular scenario, the function return three elements. Here

Unit test needs to be modified as well.


Handling IRTF Working Groups

Technically, "IRTF" documents should have "submission-type" "IRTF", and "workgroup" the name of an IRTF working group. However, the list of working groups now don't include them.
IRTF Groups can be found here: https://irtf.org/groups . We should accept abbreviations and also the full names of them.
From #85.

I have not done the groups under consideration for chartering in https://datatracker.ietf.org/group/chartering/ , because their HTML is less slurpable, and because it's not clear to me that those groups would have I.D's being authored against them anyway.
Otherwise, IRTF groups now also being screenscraped.


dineshbhai

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

only testing demo


Example Project loads, but tapping actions does nothing in iOS Simulator

See video of problem @ https://youtu.be/jkMxlnQwccg
macOS 10.13.1
iPhone 6 - iOS 11.1 Simulator
Xcode 9.1
Steps to reproduce:
# Get the code
git clone https://github.com/aksonov/react-native-router-flux.git
cd react-native-router-flux/Example

# Install dependencies
yarn

# Run it
react-native run-ios

Cannot reproduce. Probably some old cache / react-navigation version exist within your node_modules / watchman memory / etc


fix filter removal in listener patch

Fixes https://github.com/istio/istio/issues/36398

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

can you add some tests, since i can see the previous remove handling seems ok
	if networkFiltersRemoved {
		tempArray := make([]*xdslistener.Filter, 0, len(fc.Filters))
		for _, filter := range fc.Filters {
			if filter.Name != "" {
				tempArray = append(tempArray, filter)
			}
		}
		fc.Filters = tempArray
	}

I will add. But previous removing logic is not fine, it is considering the last filter status only

Will add tests then we can review

Listener patch removal seems to be working fine. So just added a test

@howardjohn VHOST remove is broken as well - It may be because we are catching the catchAllVirtualHost? Or are you thinking it is because of some other problem?

No I had the same issue I think? With empty name. But maybe also related to vhost cache. But if we remove it should not be a problem for the cache/

Ok. Let me try that Envoy filter and see what is going on.

I was able to reproduce virtual host removal issue in our environment. But not able to do it via unit test. It works correctly. I will continue to spend some time to reproduce it via unit test.

@howardjohn @hzxuzhonghu Fixed the issue for vhost and listeners. Added test for vhost - with out this change, the last test case in TestApplyRouteConfigurationPatches will have virtual host with empty name.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
8214d9954f2a32d02c81d14169d775861ff56cc2
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
daabeec79274490da170f6e8fa94a88471ff3acb
link
unknown
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio


Lock screen does not supported

When I try to unlock cinnamon-screensaver, HOWDY does not work. I can press "change user" and start with lightdm with face identity, but it's long way.

I've searched for similar issues already, and my issue has not been reported yet.
Linux distribution: 4.19.0-6-amd64 #1 SMP Debian 4.19.67-2+deb10u2
Howdy version: 2.5.1

Please use the search function. Take a look at this comment


[FEATURE] Minimum documentation for Docker

🚨🚨 Feature Request

[ ] Related to an existing Issue
[ ] A new implementation (Improvement, Extension)

A minimum documentation for Docker, with link to an official image. (Seems like there are both a Dockerfile and a docker-compose.yaml file, but not sure what is uploaded to Docker Hub?.)
Note that Official Images on Docker Hub has a special process.

Closing as this is low priority, unless someone can help.


OS X 10.10.5 Driveshare freezes shortly after startup first time initialization

Tried 3 times and waited for over 10 minutes. Get's stuck downloading. Solved on the 4th time by reloading from the view menu.

Unable to reproduce on OSX 10.10.5. Tried >10 fresh installs. I'd chalk this up to potential GitHub availability issues during the time this was experienced.
Please reopen if you experience this again.


找不到匹配“donsole”的模板或子命令。

Problem encountered on https://dotnet.microsoft.com/zh-cn/learn/dotnet/hello-world-tutorial/create
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

Hello,
Which problem you're facing with? Can you share with us a bit more?


Is there a way to sort by history (default), instead of by ranking (default)?

@evandrix just configure HSTR using:
export HSTR_CONFIG=raw-history-view,hicolor

Check man hstr for more settings and details. You may want to add command from above to .bashrc/.zshrc.

holy shit, nice! thanks, it works!


Dynamic widget

Hi,
how to add additional custom widget?
thanks

Need to add examples but this framework only provides users with a way to manage widgets. What comprises of the widgets themselves is totally up to the users.


Back to top link fails 2.4.11 Focus Not Obscured (Minimum)

The Back to top link component in government-frontend fails 2.4.11 Focus Not Obscured (Minimum).
Note: 2.4.11 is part of the new draft WCAG 2.2 criteria. The latest standard is WCAG 2.1. WCAG 2.2 isn't published yet, so this is potentially subject to change.
As mentioned by Andy Sellick in his 2018 blog post ‘Sticky elements: functionality and accessibility testing’, content can be obscured by a sticky element. 2.4.11 is specifically about focus that shouldn’t be obscured.
There was an effort with this component to minimise that already as the sticky ‘Contents’ link only appears when scrolling the page but not when only tabbing through the page. Although that fixes some of the issue, that doesn’t mean that the focus never gets obscured. The sticky link still appears when scrolling via the keyboard (for example, with the arrow keys) or when accidentally scrolling with the mouse or touchpad only for a second.
To replicate, open the preview of the 'Contents list with body' component, tab to the last link (‘Commencement of initial period notice’), scroll the page via the up arrow key so that the link is obscured, use tab and shift + tab to go back and forth to see how you can tab to a link that isn’t visible.
Screenshot of the issue (note that the focus is not completely obscured to make the issue more visible but it can be):

Transferring this to Government Frontend since the 'Back to top link' component belongs there, not in this repository.


Set timeout to 60 instead of 30 when downloading files

cc @ydshieh

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Teams Dev Portal - App with no owners

Hi,
Given that App Studio is deprecating, we are in the process of moving to use the Teams Dev Portal.
However, we are having issues with an app - the app appears to be using an old version of the manifest, but we cannot update it or delete as it appears it doesn't have any owners.

There appears to be a blank owner. I cannot leave the app as it gives the error at the top (which contrarily suggests I am the owner). I also cannot delete the app nor can I add anyone else.
Trying to upload a newer version of the manifest gives the following:

This is an issue because we have this app deployed in a few Tenants and we cannot update them if we use a different App ID.
Is there a way this app can be fixed/deleted from the backend?
App ID: ff579744-57b5-4a05-a8a5-05cb0ee7b9ec
Teams App ID (Internal): 80eb8e30-f6a5-4fea-92ee-bd29b65155cf

We are looking into this, we will update you.

Can you please try uploading/Deleting the app from the Teams admin center -
Update App :

Delete App :

Hi @Meghana-MSFT
When I try to upload this app in the Teams Admin Centre, I get the following error:

I noted that within the dev portal, I can see this manifest file has errors:

but I cannot update it as it does not recognise any user as an owner.

Could you Please check the below points?

Please check if you are mentioning the correct version of manifest - https://docs.microsoft.com/en-us/microsoftteams/platform/resources/schema/manifest-schema#manifestversion
Please check if this thread helps you - https://stackoverflow.com/questions/62383644/failed-to-load-the-package-the-add-in-package-provided-was-not-understood-verif

Hi @Meghana-MSFT,
I am able to 'fix' the manifest, and upload it via Teams admin centre, then remove it again per your initial suggestions, but this has no effect on the app in the Dev Portal.
The issue is that, within the Dev Portal, we have this app with no owners, that I cannot update (the prompt asks if I want to duplicate, which creates it under a new app Id) nor can I delete the app (no option for delete and cannot leave, as it throws the error above).
Note that this app also is NOT present in App Studio.

The engineering team has few queries, could you please help answer them -
The app owner field is not populated/empty because the person who has been the primary owner has left the organization.

Can you please confirm if this is the case with you?
What exactly are you looking for? Do you want to delete the app or fix this issue (meaning you want to assign an owner for this app?)

Team said that we can explore any workaround if we can understand what the exact ask is.

Hi @Meghana-MSFT - thanks for reaching out to the engineering team. In response to the queries:

I was pretty sure I was the owner of this application but it is possible - I honestly cannot recall
I want to be able to upload a new version of the manifest under the same app id (ff57...)
If it is possible to assign me as the owner, that would be preferred (let me know the best way for me to provide the email/UPN of the account)
otherwise, deleting it so it frees up the app Id and I can reupload a new version under the same app Id also works.

@YJasonY - Thanks for sharing the details.
We have already shared it with engineering team and they are looking into it.
We will get back to you once we get any update from engineering team.

Could you please confirm if the user is a Microsoft tenant user or external? Are you logged in as a user of a M365 tenant? Or are you logged in using personal MSA account?

Yup it's a user within the tenant, not a personal account.

Could you please try this suggestion and confirm if it helps?
Tenant admin can import an app with the exact same app id and overwrite the existing app and making the Tenant admin the owner of the app.

Could you please confirm if the above solution solved your issue?

Hi, unfortunately this didn't work and I am still getting the same error when I try to upload:

Confirming I was given the role of "Global Administrator" for the tenant.

Could you please share the network trace when this import fails?

Thanks for the details.

Hi @Meghana-MSFT - please see network trace and console at the time of upload:

Will you mind sharing the header of the request and response? There should be a correlation id.

Sure thing:
Request:
x-correlation-id: 69d4f234-1d03-4cca-9fb6-9d12e843d768_27
Full Request Header:
:authority: dev.teams.microsoft.com :method: POST :path: /apac/api/appdefinitions/v2/import?overwriteIfAppAlreadyExists=false :scheme: https accept: application/json, text/plain, */* accept-encoding: gzip, deflate, br accept-language: en-GB,en-US;q=0.9,en;q=0.8 authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiIsIng1dCI6IjJaUXBKM1VwYmpBWVhZR2FYRUpsOGxWMFRPSSIsImtpZCI6IjJaUXBKM1VwYmpBWVhZR2FYRUpsOGxWMFRPSSJ9.eyJhdWQiOiJodHRwczovL2Rldi50ZWFtcy5taWNyb3NvZnQuY29tIiwiaXNzIjoiaHR0cHM6Ly9zdHMud2luZG93cy5uZXQvYTE1YmQ0OWUtMjE2Ny00NjdiLWIyYWMtNzhkY2Y1N2NlNWNlLyIsImlhdCI6MTY1NzQ5MzY0MiwibmJmIjoxNjU3NDkzNjQyLCJleHAiOjE2NTc0OTkxNjAsImFjciI6IjEiLCJhaW8iOiJBVlFBcS84VEFBQUF1Wk9zd3k4cG1BL0psTGs1WnU5S1QxRGZ6Qkc2b2djN2pNSmFmSW4zSTFOcFJxY21nZTFpREVXNlErVVZGTHpsQ1dFZTVlNnEvdWxnNXBvZGFrbktob1FSeDZVSnpxUGRvTGlaeFlUYXkwST0iLCJhbXIiOlsicHdkIiwibWZhIl0sImFwcGlkIjoiZTE5NzljMjItOGI3My00YWVkLWE0ZGEtNTcyY2M0ZDBiODMyIiwiYXBwaWRhY3IiOiIwIiwiZmFtaWx5X25hbWUiOiJZYW5nIiwiZ2l2ZW5fbmFtZSI6Ikphc29uIiwiaXBhZGRyIjoiMTU5LjE5Ni4xNzAuMzMiLCJuYW1lIjoiSmFzb24gWWFuZyIsIm9pZCI6IjJkNDkwMDQ4LTkzMjItNGNmOS05NTFjLTdmMWU0NWM1OGRjYiIsInB1aWQiOiIxMDAzQkZGRDk1MDcxQzg3IiwicmgiOiIwLkFVRUFudFJib1djaGUwYXlySGpjOVh6bHppS2NsLUZ6aS0xS3BOcFhMTVRRdURKQkFFQS4iLCJzY3AiOiJBcHBEZWZpbml0aW9ucy5SZWFkV3JpdGUgQ2FyZHMuUmVhZFdyaXRlIiwic3ViIjoibC1WTnJsTzE1blRKUm9FX1FIbjhKdHQ4Y3lHa2FNUm9QeGFwWmNGX2NZTSIsInRpZCI6ImExNWJkNDllLTIxNjctNDY3Yi1iMmFjLTc4ZGNmNTdjZTVjZSIsInVuaXF1ZV9uYW1lIjoiamFzb255QGFudGFyZXNzb2x1dGlvbnMuY29tLmF1IiwidXBuIjoiamFzb255QGFudGFyZXNzb2x1dGlvbnMuY29tLmF1IiwidXRpIjoiQ2RkODhxRENTMGU2VkFmREFmZG5BQSIsInZlciI6IjEuMCJ9.ZPsGscYTCp-lEdDynX_QD6Z6TSFzQoF3DiVLoYltWl5ulbd4mlS65s5W-EKwSGXoA63FA4PXpBBd3zHHN79SspMesgBByQhEaaVgyLzSz-RuIsb2CpbPof1YCwRRsybttKZRDxYb8HjBTpgmXsZy8qg0UTxWmcWCy4VHgzfvyJOkRiCQulNDi6Vkjpe6Q2h_ABwm3_DWHhDUP2cXImNJWnYVLz12Aaxvj11ZTLv5H2QErUPamcVS5Fn0hSAErZ0fpPysBxG30ljCBLpdq8n5pAf8KDjHpa-xJK5nE9ZcMo_KvKMvTO8kWteZiv2UshsMcGRjpWihBgyYTbaDkZRrWw client-source: DeveloperPortal content-length: 3616 content-type: application/zip cookie: MC1=GUID=4aacd37d0fcc4f408dad8dbf6ea4a19d&HASH=4aac&LV=202111&V=4&LU=1636674049695; _ga=GA1.2.1991749888.1636674050; MUID=1B6A2D766D9C6E820D793D9A699C68D2; _cs_c=0; _uetvid=edd40760434a11ec8ab66d4035224499; __CT_Data=gpv=1&ckp=tld&dm=microsoft.com&apv_1067_www32=1&cpv_1067_www32=1; _cs_id=cbef4096-e7cb-a9b0-d46b-9c76e7f061f7.1636674973.3.1636684807.1636684807.1613561419.1670838973606; LPVID=MxNDM1MWE0ZjM1MTU1MjFl; clienttype=web; tenantId=a15bd49e-2167-467b-b2ac-78dcf57ce5ce; msresearch=%7B%22state%22%3A%7B%22name%22%3A%22IDLE%22%7D%2C%22userid%22%3A%2216533456346904638230904895246%22%7D; MicrosoftApplicationsTelemetryDeviceId=50b8f89d-db51-4b50-9725-a0ec1440ce55; AMCV_EA76ADE95776D2EC7F000101%40AdobeOrg=1176715910%7CMCIDTS%7C19181%7CMCMID%7C76357277441433707943092935066729226895%7CMCAAMLH-1655184517%7C8%7CMCAAMB-1657162912%7C6G1ynYcLPuiQxYZrsz_pkqfLG9yMXBpb2zX5dvJdYQJzPXImdj0y%7CMCOPTOUT-1657170113s%7CNONE%7CMCSYNCSOP%7C411-18950%7CvVersion%7C5.4.0%7CMCAID%7CNONE; mbox=PC#b0ed3943bfe04a0983c0c0f6fbdcef63.36_0#1691349612|session#b33c3b62944f43bfb2a749dddc2574fe#1657164774; MSFPC=GUID=4aacd37d0fcc4f408dad8dbf6ea4a19d&HASH=4aac&LV=202111&V=4&LU=1636674049695; MS0=3da6bf58088346cbabcc20db5d00c3af; ai_session=udJY85gxACbZv5SsofictZ|1657493941798|1657493943382 origin: https://dev.teams.microsoft.com referer: https://dev.teams.microsoft.com/apps sec-ch-ua: ".Not/A)Brand";v="99", "Google Chrome";v="103", "Chromium";v="103" sec-ch-ua-mobile: ?0 sec-ch-ua-platform: "Windows" sec-fetch-dest: empty sec-fetch-mode: cors sec-fetch-site: same-origin user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 x-correlation-id: 69d4f234-1d03-4cca-9fb6-9d12e843d768_27
Response:
x-correlation-id: 69d4f234-1d03-4cca-9fb6-9d12e843d768_27
Full Response Header:
access-control-allow-origin: https://dev.teams.microsoft.com access-control-expose-headers: x-correlation-id,date cache-control: no-cache, no-store content-type: application/json; charset=utf-8 date: Sun, 10 Jul 2022 23:02:05 GMT expires: 0 pragma: no-cache request-context: appId= strict-transport-security: max-age=31536000; includeSubDomains=31536000 vary: Origin x-cache: CONFIG_NOCACHE x-content-type-options: nosniff x-correlation-id: 69d4f234-1d03-4cca-9fb6-9d12e843d768_27 x-msedge-ref: Ref A: 2EC9AA074A224CAC982D94ECF0B5F411 Ref B: SYD03EDGE1316 Ref C: 2022-07-10T23:02:05Z x-xss-protection: 1; mode=block

Hi @ronwang01, @Meghana-MSFT - any updates on this or any additional information you need from me?
Thanks.

@YJasonY - Engineering team has created a bug for this issue. Team is working on the issue. We currently do not have any ETA to share. We will keep you posted on the updates.

Hello @YJasonY - Sorry for delay in response.
We are actively checking the updates on this issue with engineering team and let know the updates, if any.

@YJasonY - Tenant admin can now take over the app via Take ownership option in https://dev.teams.microsoft.com/apps.

Hi @Meghana-MSFT, this still isn't working.
I tried to use the "Take Ownership" function, but nothing seems to happen despite the success response.

{"teamsAppId":"b53c0d6f-[OMITTED]","tenantId":"a15bd49e-[OMITTED]","ownerAadId":"2d490048-[OMITTED]","userList":[{"tenantId":"a15bd49e-[OMITTED]","aadId":"2d490048-[OMITTED]","displayName":"jasony@[OMITTED]","userPrincipalName":"jasony@[OMITTED]","isAdministrator":false}] ... }
The "Take Ownership" doesn't appear to actually assign me as the owner.
There is no way for me to delete or even leave the app:

Happy to organise a screenshare session if there is any additional info you need.
At this point, we just want the environment completely clean (delete/remove everything) so we can start over - is there anyway the engineering team can manually do this from the backend?

@YJasonY - We have shared this with engineering team, I will keep you posted once I get any update from the team.

@YJasonY Sorry for the delay, the issue here is you are already a contributor to the app, and takeover ownership will basically be a no-op. A simple workaround is to have another Global admin or Teams tenant admin take over the app and elevate your rights from contributor to admin.
Meanwhile, we will be working on fixing this issue.

thanks @ronwang01 - we managed to resolve the issue with the help of another Global admin and have now successfully removed all the apps.


max_document_size check is not accurate

max_document_size currently checks document sizes based on Erlang's external term size of the jiffy-decoded document body.  This makes sense because that's what used to store the data on disk and it's what manipulated by the CouchDB internals.
However erlang term size is not always a good approximation of the size of json encoded data. Sometimes it can be way off (I've seen 30% off) and It's hard for users to estimate or check the external term size beforehand. So for example if max_document_size is 1MB, CouchDB might reject user's 600KB json document because Erlang's external term size of that document greater than 1MB.
Possible Solutions

Do nothing. If the current size check is to throttle or limit disk usage and disk usage is driven by the external size (though in most cases compression is used on it, so it will usually be less), then on that level it makes sense to keep it as is.

Re-encode the data using jiffy and check the size against that. That's a better check but will impact performance.  However this is also not an exact solution. Users' json encoder might insert more whitespace (say as indentation), or whitespace after commas, use a different algorithm for encoding floating point numbers (scientific notation, represent exact floating point numbers without a decimal point (5 instead of 5.0 etc.). So the size would still be off. Made a PR with this approach: https://github.com/apache/couchdb/pull/660

Like above but enhance jiffy to return an "encoded size" without actually doing the encoding. Or least have it do the encoding internally and just return byte size to Erlang instead of a full term which will have to be thrown away.

Here is at attempt to do a size check in Erlang. Since jiffy is pretty quick is might end being slower than doing the full encoding in jiffy:

encsize({[]}) ->
    2;  % opening { and closing }

encsize({Props}) ->
    % 2 is because opening { and closing }
    % Inside the lc 2 is for : and , but counts an extra , at end
    % -1 is to subtract last , from lc part
    2 + lists:sum([encsize(K) + encsize(V) + 2 || {K, V} <- Props]) - 1;

encsize([]) ->
    2;  % opening [ and closing ]

encsize(List) when is_list(List) ->
    % 2 is for [ and ]
    % inside the lc 1 is for , but it counts one extra , for last element
    2 + lists:sum([encsize(V) + 1 || V <- List]) - 1;

encsize(Float) when is_float(Float) ->
    % this doesn't match what jiffy does. so will be off
    byte_size(float_to_binary(Float, [{decimals, 16}, compact]));

encsize(Integer) when is_integer(Integer), Integer >= 0 ->
    trunc(math:log10(Integer)) + 1;

encsize(Integer) when is_integer(Integer), Integer < 0 ->
    % 2 is because 1 is for the - character
    trunc(math:log10(Integer)) + 2;

encsize(Binary) when is_binary(Binary) ->
    % count escapes and assume they'd be escaped with one extra escape character
    Escapes = [<<"\b">>, <<"\f">>, <<"\n">>, <<"\r">>, <<"\t">>, <<"\\">>,
        <<"\"">>],
    MatchCount = length(binary:matches(Binary, Escapes)),
    % 2 is for open and closing "
    2 + byte_size(Binary) + MatchCount;

encsize(Atom) when is_atom(Atom) ->
    encsize(atom_to_binary(Atom, utf8)).

Maybe modify it to provide an always underestimating check. So users get the benefit of the doubt. That is whatever encoding they pick, find a not too expensive check that will be accurate enough and always be smaller?

@nickva: There is an implementation in erlang here https://github.com/okeuday/erlang_term/blob/master/src/erlang_term.erl. MIT license.

Another implementation could be based on https://gist.github.com/iilyak/a11a481bd3f7311d8499e19f5e4c8f22

We don't really need it be that generalized in a way because we know we'd only get what jiffy decoded which is proplists, arrays and then integers, floats and binary (but unicode and escape sequences have to be accounted for). Oh maybe atoms but those are just translated to binary and handled that way.

Another option is to change chttpd:json_body to return {Size, Body} and pass Size through.

@iilyak
Interesting idea. It would depend how much the code would be affected _bulk_docs and possibly multipart/related PUTs might be an issue too.

This was fixed. Close it.


Rename button group property to button_group

The property for ButtonGroup on BaseButton was called group, but the getter and setter both end in _button_group, and the member is also called button_group, so rename the property to button_group for consistency and to avoid confusion with node groups. This change was prompted by someone on Discord who was very confused by "Group" not being related to node groups.

Thanks!


Extension count should round installs

Extension with 152,900 installs should be 153K and not 152K

Marketplace:

Millions also: Debugger for Chrome
7.9M => 8M

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


Some photos are never uploaded

I'm having some problems with photos which are not being uploaded to the server. As a context, if it is relevant, I recently went into a trip in which I was offline, so I tried to sync over 100 photos once I connected to the Internet.
I sent you logs by email (same subject as this issue), in which I manually tried to sync one of the photos that doesn't want to be uploaded.

Duplicate of https://github.com/savvasdalkitsis/uhuruphotos-android/issues/454


Copy / Paste image in TinyMCE / BookStack

Describe the feature you'd like
Hi !
It's possible to modify the TinyMCE for copy / past word file with image directly ? Actually we have to copy / past and after that add all image...
Describe the benefits this would bring to existing BookStack users
Convert all word file directly with just text adjustement
Can the goal of this request already be achieved via other means?
Copy word file after that we have to save all image in the word for upload to BookStack & place all image in the bookstack book... Take long time for long file...
Have you searched for an existing open/closed issue?

[x] I have searched for existing issues and none cover my fundemental request
https://github.com/BookStackApp/BookStack/issues/449
But it's closed and i thinks copy / past with image is a good tool for community

How long have you been using BookStack?
0 to 6 months
Additional context
No response

Hi @Arkantium,
I'm a bit confused by this. I does sound like you request is fundamentally the same as #449. That issue is still open, it is not closed. Does your request differ at all?

I'll go ahead and close this off as a duplicate of #449


Replace FxmlLoadException with DolphinRuntimeException and remove dep…

…recated FxmlException class.
In response to issue #630.

This change is

@h93xV2 cool :) THX

@hendrikebbers Anytime :D


Release notes - possibility of ongoing YZ support

Since first drafting the release notes there may be renewed interest in both using yokozuna beyon Riak 2.9, and helping maintian it.
The release notes now reflect the increased doubt over deprecation.

+1 I'm happy with this


Another weird case

This one seems to be protected with a recent version of the obfuscator.
de4dot can decrypt some of the strings but no resources or embedded assemblies at all.
EazFixer can decrypt most strings but that's it because only the StringFixer displays "Success".
I tried your fork of eazdevirt and it doesn't seem to find any traces of virtualizationr.
c.zip

try the new update with --keep-types
EazFixer.exe  --file Connectify.exe --virt-fix
The assembly itself does not have much virtualized you could try making whatever changes you are aiming for without devirting by patching unvirtualized CIL code.

Yeah it is possible to patch it as it is.
The new command line switches in the update didn't really improve the result though.

I assume you did deobfuscate the control flow with de4dot? Try that first, making sure to keep the mdtokens the same.

Yes. Results are the basically same even after control flow deobfuscation.
--keep-types only applies the string fixer, similar to when I use no command switches at all
--virt-fix fails to apply alll the patches and the string fixer error says "Cleanup error: VirtFix enabled, Cannot remove method"

I'll take a look at the sample.

Please try the latest master, I fixed multiple issues and it now works on my end.


[rediscuss] Remove *args and **kwargs from Resource methods

Since *args and **kwargs are now injected in the resource_requestctx there is no need for arguments to the Resource methods.
(To be honest I haven't seen cases with *args, so there may be a wrinkle here.) Everyhing is now accessible from the resource_requestctx.

This was closed in the last sprint!


Prevent webdrivercss() from modifying an array passed to it.

The commit includes a new test which failed before the fix. Let me know if you need more info.

Coverage remained the same at 99.51% when pulling 25f593851b058f52eac0fd05a3ac576da246053d on brettle:master into 8463f757a4d62bdc967d8d3cd1d5c1b974235485 on webdriverio:master.

@brettle thanks for contributing! I don't quite understand the fix as the test passed in the last build and on my local machine.

The commit has both the test and the fix. To see the test fail, revert the change I made to lib/workflow.js.
Note that this has nothing to do with the issue I recently reported with one of the existing tests failing.

ohh now I see the issue here. You've passed in a variable and that variable changed after executing the webdrivercss command. Should have read the issue title before looking at the change :smile:

This PR now includes a simple workaround for the unrelated failing test mentioned in issue #76. Sorry for combining PRs, but its probably easier to merge both in one shot anyway.

Coverage remained the same at 99.51% when pulling 9dae1e25889a10dec08aacf6f77fe125b0fdb0ba on brettle:master into 8463f757a4d62bdc967d8d3cd1d5c1b974235485 on webdriverio:master.

Awesome, thanks!

published with v1.1.4