convertFromHTML breaks after converting \n string, issue #1822

Summary
The core issue is here:
https://github.com/facebook/draft-js/blob/master/src/model/encoding/convertFromHTMLToContentBlocks.js#L376
A call to the let chunk = {...EMPTY_CHUNK}; create a shallow copy of the EMPTY_CHUNK object. It means that chunk.blocks array (and others) share the same reference to the EMPTY_CHUNK.blocks.
If code hit this line https://github.com/facebook/draft-js/blob/master/src/model/encoding/convertFromHTMLToContentBlocks.js#L633 EMPTY_CHUNK object will end up having block array with one element of {type: 'unstyled', depth: 0} which caused the aforementioned issue.
Next call to the convertFromHTML will start with polluted EMPTY_CHUNK object. :-(
Test Plan
Open a https://jsfiddle.net/m6z0xn4r/1190/
Put a breakpoint on convertFromHTML and see 2 different results while converting headers
Another way:
Open chrome dev tools and:

execute convertFromHTML('\n')
execute convertFromHTML('
H
')
Observe that second call return a block with unstyled type.

Thanks for the PR @yury-sannikov, I'm facing the same issue.
I'm just wondering what's the status of this PR? Are you planning to fix the conflicts soon? 🤔

Thanks for spotting the issue and submitting a fix @yury-sannikov. Please note the convertFromHTMLToContentBlocks.js converter is deprecated and will be replaced by convertFromHTMLToContentBlocks2.js.
May I ask you to update this PR by rebasing the commits on latest master, and write a test case for convertFromHTMLToContentBlocks2.js as well?


Tutorial groups: Usability issue for creating new tutorial for campus and language suggestions

Checklist
General

[X] I tested all changes and their related features with all corresponding user types on a test server.
[X] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[X] I chose a title conforming to the naming conventions for pull requests.

Server

[X] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[X] I followed the coding and design guidelines.
[X] I documented the Java code using JavaDoc style.

Client

[X] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
[X] I followed the coding and design guidelines.
[X] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[X] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.
[ ] I translated all newly inserted strings into English and German.

Motivation and Context

This PR is designed to improve usability when creating tutor groups. The PR offers the default selection of English and German. For the campus search, the default values have been extended. I.e. all possible values of the campus the instructor is involved in are now offered - not only the possibilities of the respective course
Description

fixes https://github.com/ls1intum/Artemis/issues/7292
Steps for Testing

Prerequisites:

1 Instructor
2 Courses where the user is instructor
2 Tutor Groups

Log in to Artemis
Navigate to Course Administration
Create one Tutorial --> check whether the default values for english and german are available.
Switch to 2nd course --> create another Tutorial
Check if the previouly inserted campus is visible.
Repeat steps for editing of a tutorial

Review Progress

Performance Review

[x] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
[x] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Screenshots

Maunal tested on legacy ts2. Worked mostly as expected.
But for the languages: If I added a new language (e.g. Russisch) it did not show up as a default value for the other tutorial (like it did with the locations). I don't know if this is something you want to happen or not. Please let me know.

Thanks for your review. Originally, the change was only meant for several campuses in different courses, but I have now included the change for the languages as well.


is kit b too aggressive in determining processes?

E.g. if i have a package containing
foo/
bar/
lib/

where lib/ is meant to be imported by foo/ and/or bar/ but is not itself a process, should there be a way to specify that lib/ is not a process?
Current workaround is to nest dirs, e.g.
foo/
bar/
crate/
  lib/

the code that identifies a process dir in the package:
https://github.com/kinode-dao/kit/blob/master/src/build/mod.rs#L414-L415
https://github.com/kinode-dao/kit/blob/master/src/build/mod.rs#L370-L371
so if it

is a dir in the package
has src/lib.rs
its assumed to be a rust process

https://discord.com/channels/1186394868336038080/1186421052071477428/1240714974930669760


Add tabs

Hey!
I'd love if this library could have the ability to display tablature, perhaps similarly to how this LaTeX library does it (http://tug.ctan.org/tex-archive/macros/latex/contrib/guitartabs/guitartabs-doc.pdf).
I'd be happy to help out with this if its a thing that you feel should be added?

Hi!
I'm gonna study how implement this feature.
For now, you can check conchord, this package in your v0.1.1 has a experimental tablature support.


Add benchmarks for the geosearch

closes #336
Should I merge this PR in #322 and then we merge everything in main or should we wait for #322 to be merged and then merge this one in main later?

Oops I forgot to update the README and the bench.yaml. I'm putting this in draft PR for now sorry

@Kerollmops, should I merge this in the #322, or should we first merge the geosearch and then the benchmarks on main? What do you prefer?

I prefer that we merge #322 and this one after :)

Ok so I guess we can merge now :grin:

Yes!
But now I'm wondering, maybe we could add a geosearch on a really small dataset? ~10.000 documents

How much time does it take to run this one? If it is much longer than the other ones, maybe we should indeed!

No, currently, all the bench related to the geosearch are super fast. It takes 20 minutes for the search and an insignificant amount of time in the indexing benchmark (1h50m5s before the geosearch vs 1h50m6s with this branch).
So I think it would be good to keep this dataset of 1M documents because it's what we want to improve.
But at the same time, add a really small dataset to ensure we don't lose any performance on small datasets.


Ability to choose action for all files when delete fails

What's the Problem?

When deleting big chunk of files this message is extremely annoying 'cause u have to dismiss it every time it shows, and there's no way to choose action for all files
Solution/Idea
Add "Ignore for all" button
Alternatives

Priorities
No response
Files Version
<IP_ADDRESS>
Windows Version
Windows 11 Home N Version	21H2 22000.434
Comments
No response

Tracked in #7060


Fusion UI allows users to enter an invalid date/time for Imagery Resources

Reproduction steps:

Create a new imagery resource
For date, enter "2000-00-00"
Save the resource

Expected: An error message indicating the date is invalid
Actual: The resource saves, using this resource in a historical imagery project breaks the timeslider functionality
Also check to see if CLI tools are affected by this bug.

Hi @eltonj96 I just saw you message. Let me make sure no one else wants to claim this one and I'll get back to you.


chore: Rebuild v0.2.0 and v0.2.1

@bo0tzz I figured out why /docker-entrypoint-initdb.d/ does not work.
In the postgres base image entrypoint, if pgdata existed it would not execute SQL in  /docker-entrypoint-initdb.d/.
I think postInitSQL  is a reasonable solution.
Of course, we can add the usage in README, I will add it in the next pull request. And I think we do not need to release an new image for v0.2.0 and v0.2.1, user can refer to our usage. We can delete /docker-entrypoint-initdb.d/ in the dockerfile in the next released version.

Thank you for looking into this!


[libuuid] disallow on osx

It conflicts with the version of the osx sdk and is not compatible and you are getting errors like this

I don't understand; it seems to work fine on my machine, and that's an error from 2019. Is this actually still an issue?

I don't understand; it seems to work fine on my machine, and that's an error from 2019. Is this actually still an issue? Do you have any examples of things breaking more recently?

Is this actually still an issue? Do you have any examples of things breaking more recently?

Yes this is still in issue. podofo for example fails when libuuid is installed.

Can you please resolve the file conflicts first?

Yep, alright this is correct.

@autoantwort could you merge with master?

/azp run


Added length to strings

I added length. Everything seems to be working. Not sure if the tests I've added are sufficient or if you'd like some more/different ones. Let me know if you want anything changed.

Thanks for this! Before we merge in, we need to consider the different ways to measure the length of a string. For instance, what should be the length of a string that contains characters that span more than one byte? For instance, length[text: "𝐁"] = 2 in the current implementation.
I think this function should take an additional parameter to specify how the length of the string is determined. We can call it "as" and it can take the values "symbol", "code-point", and "byte" with a default to "symbol".
In this case
length[text: "𝐁"] = 1
length[text: "𝐁" as: "byte"] = 2

I think this is less surprising in the common case, and anyone who wants to deal with byte lengths specifically can choose to do so.
Thoughts?

@jimmyhmiller Just wanted to check if you wanted to implement these changes or if  you wouldn't mind us picking it up?

I can pick it up. Sorry about the delay.

No worries! The only reason I asked was I didn't want to step on your toes, if you already had started the changes.

Wasn't 100% sure how you wanted to deal with the case of "as" that was wrong. Feel free to make any changes you need. I probably wouldn't be able to get back right away. Though I'm hoping to make more PR's soon with more string functions. I had mentioned a higher-order way of doing that. Was hoping to get your feedback on that sort of approach before I did.
(Another option would just be some helper functions to make it easier to implement these constraints in the common case.)

Okay, I fixed a couple issues, but the changes are in a new PR here: https://github.com/witheve/Eve/pull/700
Thanks for your help on this!


Test small buffers returned

We had a number of bugs in the benchmarks because the test expected the buffer returned to always be the size it had asked for. This is not always the case and sometimes the buffers will be smaller.
However, it appears the small buffers returned is quite rare, because when it happens some benchmarks hang indefinitely and some panic with 'index out of bounds'.
Since the API can return smaller buffers but usually doesn't there will likely be hidden bugs related to this in the future too. It would be useful to have a mechanism for forcing smaller buffers to be returned to ensure that handling code is properly written.

Since we have removed ByteQ this is no longer a significant problem.


It does not work on v3.6.0

After adding the plugin, building, and restarting, I only get a white screen in the Create Challenge menu.

Thanks for your issue,  I'm sorry that I just only test the plugin in v3.4.0. Maybe it has some changes in later version of CTFd causing the plugin could not work normally. And before discussing that, could your tell me if you change the name of folder? It must be named "ctfd-one-answer-challenge-plugin".

Oops, I renamed the folder without opening the script, I'll retest and close it myself if it's okay.
Thanks so much for the feedback!


Lifetime issues with component storages

I originally posted about this in the users forum and then on Reddit.
Terminology Note: When I say "owned X" in the text below, I mean that you have ownership of a value X of type T, not a reference to that value (e.g. &T or &mut T)
You can look at this issue from two perspectives:

It is hard to get a SystemData containing references to storages.
Example: You can get (ReadStorage<A>, ReadStorage<B>) by calling the system_data method on World but not (&ReadStorage<A>, &ReadStorage<B>)
It is not possible to use the Join trait with the owned versions of component storages.
Example: You can do (&a, &b).join() but not (a, b).join()

Both of these issues exist for good reasons, but they make code like the following very hard to write:
fn iter_components<'a>(world: &'a World) -> impl Iterator<Item=(&Position, &Velocity)> + 'a {
    // Two *owned* storages allocated on the stack of this function
    let (positions, velocities) = world.system_data::<(ReadStorage<Position>, ReadStorage<Velocity>)>();

    // Returning a reference to stack allocated data (does not and should not work!)
    (&positions, &velocities).join()
}

This doesn't work and you get the following error: (copied from users forum post, see that for the full code example)
error[E0515]: cannot return value referencing local variable `velocities`
  --> src/main.rs:22:5
   |
22 |     (&positions, &velocities).join()
   |     ^^^^^^^^^^^^^-----------^^^^^^^^
   |     |            |
   |     |            `velocities` is borrowed here
   |     returns a value referencing data owned by the current function

error[E0515]: cannot return value referencing local variable `positions`
  --> src/main.rs:22:5
   |
22 |     (&positions, &velocities).join()
   |     ^----------^^^^^^^^^^^^^^^^^^^^^
   |     ||
   |     |`positions` is borrowed here
   |     returns a value referencing data owned by the current function

If either of the two things I listed above weren't the case, this code could potentially compile:

If you could get a system data instance containing references to storages: (the storages would have to be owned within the world or something)

fn iter_components<'a>(world: &'a World) -> impl Iterator<Item=(&Position, &Velocity)> + 'a {
    // Two references to storages allocated somewhere by World
    // Notice the `&` before the `ReadStorage` types here
    let (positions, velocities) = world.system_data::<(&ReadStorage<Position>, &ReadStorage<Velocity>)>();

    // positions and velocities are both references, so we can use them here no problem
    (positions, velocities).join()
}

If it were possible to use the Join trait on owned versions of the storages:

fn iter_components<'a>(world: &'a World) -> impl Iterator<Item=(&Position, &Velocity)> + 'a {
    // Two *owned* storages allocated on the stack of this function
    let (positions, velocities) = world.system_data::<(ReadStorage<Position>, ReadStorage<Velocity>)>();

    // Storages are *moved* into this tuple that we call `join` on. This works!
    (positions, velocities).join()
}

A note about this: ReadStorage makes it pretty obvious that we are immutably borrowing here, but with WriteStorage we would probably need some methods like read_owned() and write_owned() to emulate what you could do with & and &mut before. See the following code for more details:
fn iter_components<'a>(world: &'a World) -> impl Iterator<Item=(&mut Position, &Velocity)> + 'a {
    // Two *owned* storages allocated on the stack of this function
    let (positions, velocities) = world.system_data::<(WriteStorage<Position>, WriteStorage<Velocity>)>();

    // You can join over either of these storages in two modes:
    // * `&positions` for read-only access to the components
    // * `&mut positions` for read-write access to the components
    // `write_owned()` could wrap the storage in a type that implements
    // the `Join` trait and allows access to mutable references
    // Instead of `read_owned()` we could default to the behaviour that
    // the owned version of a storage only allows reading

    // Storages are *moved* into this tuple that we call `join` on. This works!
    (positions.write_owned(), velocities.read_owned()).join()
}

I think this solution is probably the easiest to implement because it doesn't involve the World having to hold on to arbitrary storages for some extended amount of time.
The API I would suggest is:

ReadStorage<T> and WriteStorage<T> implement Join and produce &T
WriteStorage<T> provides a method (e.g. write_owned()) that returns an owned value that implements Join and produces &mut T (perhaps something similar to MaybeJoin?)

This may cause issues with World because it's probably not a good thing if a storage lives longer than expected. I am not familiar enough with the internals to comment on that.

Option 1 is much more serviceable in my opinion.  Join::join takes self as a parameter, consuming it, which is very likely to cause confusion for users who might start operating under the mistaken belief they can't use join twice on a storage.

Option 1 is much more serviceable

I'm happy with either. I don't actually know the internals well so my suggestion was just a guess :)

Thanks for filing this @sunjay!
I don't see a good way to implement Option 1. These values need to be held in memory because they protect memory from being accessed in an invalid manner.
What you can do though:
struct Iter<'a> {
    pos: WriteStorage<'a, Position>,
    vel: ReadStorage<'a, Velocity>,
}

impl<'a> Iter<'a> {
    fn iter(&mut self) -> impl Iterator<Item = (&mut Position, &Velocity)> + 'a {
        (&mut self.pos, &self.vel).join()
    }
}

fn iter_components<'a>(world: &'a World) -> Iter<'a> {
    let (pos, vel) = world.system_data::<(WriteStorage<Position>, WriteStorage<Velocity>)>();

    Iter {
        pos, vel,
    }
}

// Then:

iter_components(&world).iter().do_whatever();

This works because Rust will just keep the value in memory for as long as necessary and drop it once it's not borrowed anymore (so basically create the temporary for you).
As for the second option, that could be implemented, yes. I share @Xaeroxe's concern though.
I don't quite know what you're trying to achieve, but what I do usually is:
world.exec(|(vel: ReadStorage<Velocity>, pos: WriteStorage<Position>)| {
    (&vel, &mut pos)
        .join()
        .do_something()
});

If you want to hide the world and you plan on creating more of those convenience functions, one thing you can do is create RefJoin and MutJoin which wrap a T where &T / &mut T is Join and implement Join with that constraint. That would allow you to return (MutJoin(pos), RefJoin(vel)).join().

I don't quite know what you're trying to achieve

I have a bunch of components that I want to move from one World to another. I want to do this several times in different places, so I want one function/struct/something that deals with iterating through all the components. It's hard to do that starting from a world without first defining a system data for all the components.

If you want to hide the world and you plan on creating more of those convenience functions, one thing you can do is create RefJoin and MutJoin which wrap a T where &T / &mut T is Join and implement Join with that constraint. That would allow you to return (MutJoin(pos), RefJoin(vel)).join().

Could something like MutJoin or RefJoin be added to specs?

Ah, I see.

Could something like MutJoin or RefJoin be added to specs?

I'm not against it, but it's kind of a special case. I'd like to hear @Xaeroxe's and @WaDelma's opinion prior to merging it.

Let's revisit this after #523

We could also implement Join directly for the storages, making Storage<FetchMut> simply always mutable. I don't think that would be bad considering we consume it anyway. That way, this can be solved much more consistently.
Task

create to impl blocks of Join for Storage
look at how Storage abstracts over the mutability of D
implement one for the mutable and one for the immutable version

It turns out this is actually not as easy as I thought. The proposed solution does not work since we obviously can't borrow fields we're consuming.

If I understand this issue right, I've been meaning to file something similar. I basically want something similar:
fn iter_components<'a, T>(world: &'a World) -> impl Iterator<Item=&'a T> + 'a

The reason I want this is I want to treat the world as a black box, i start it, things happen, and then someone else can query what happened to a list of things inside, and iterate through them, and update some other data they might have that relates, etc.
If I attempt to write this function, I have lifetime errors; this just seems like a bug to me though, or the lifetimes aren't threaded correctly; not sure.
Otherwise, I'm forced to clone, or i'm forced to execute in the context of the world, which would require someone else to know that I'm using specs as the black box, which means the backend is leaking out imho.

There's nothing incorrect about the lifetimes, it's inherited by interior mutability. The same happens when you try to return a refefence to a value inside a Mutex. You need to keep the guard in memory so access can be controlled.
I do understand your concern though.

Any idea if there is something we can do about this? Maybe there could be another different type that gets returned from a different method that specially supports this?

There is no way to directly return multiple immutable references to resources.
What we can do, however, is returning a Ref<MyResource> which dereferences to the resource. Is that something that would work for you?

I think that's a reasonable compromise. Does that require a new method / struct? Or can it be integrated into the existing API?

I think it does work right now :)
Resources::fetch fetches the resource and gives you a Fetch<MyResource> (not Ref, confused that)

Is there anything more we want to do with this?

I'm not quite sure. I think Ref can be used just fine for this use case, and other than that I'm not sure what to solve here. Do you think there's still something left to do?

I just wanted to check to be sure. Thanks for your help! :smile:


Remove space for non-existant icons in the subcategories

Is your feature request related to a problem? Please describe.
We reserve space in the subcategories for icons even though there often aren't any.

Describe the solution you'd like
We only reserve space there if an icon exists. Toni agrees :)

Additional context
This came up in the context of #2767

@LeandraH should this only be done for subcategory items? How about category list items and search list items?


Move optional MakeConnection args into Options struct

The MakeConnection() function requires a database name, but it optionally takes grpc credentials and an endpoint string as well. It'll likely grow many more options in the future. We should factor the optional parts out into a ConnectionOptions struct that itself is optional.

There is already a spanner::ClientOptions that seems like it would fit?  It was intended for this purpose actually.
This should be done before Beta because it changes the API.


Remove secrets from the cache

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

/test all

/test all


increase size of config -> disk -> Size column

size column needs to be increased for up to 9PB of storage. make it wider by a few chars.

done, 60px -> 150px
fmadio/fmadio20@6bc1ea4


GE PMT: Clear out Payment Status and Token in 'Do Not Charge Card' Mode

Critical Changes
Changes

The payment status and payment authorization token will now be cleared out from Data Import records if the 'Do Not Charge Card' button is pressed while a single gift is entered.

Issues Closed
Community Ideas Delivered
New Metadata
Deleted Metadata

**lurch attach: W-040868

Tracking W-040868


Fixed typo

Hi @mbifulco, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;


Verify_SSRS_for_SCSM does not report error if  is not placed directly under

the script should check if  is placed directly under , if not it should error.
Otherwise, SCSM reports that use the SCDWMultiMartDataProcessor extension as their datasource will fail.

here's a sample where the script should show an error.

closing as of now. If other asks later, we can fix this.


Should pass the Locale from Localizations to Text/RichText/etc to painting.TextStyle to ui.TextStyle

cc @HansMuller who worked on i18n
cc @gspencergoog who may enjoy this one

Font selection is a very important thing for Japan and China. I sincerely hope that the font selection by language works fine.
I think that this issue is related to font selection. I expect that this issue will be fixed.

My understanding from @najeira's article:
https://medium.com/@najeira/flutter-and-cjk-font-selection-5dbc6a6164ba
is that this is a regression as part of moving to libtxt from blink?
@jason-simmons

This has never worked correctly in Flutter.

OK.  Is the correct understanding of https://medium.com/@najeira/flutter-and-cjk-font-selection-5dbc6a6164ba that the workaround for this bug(?) which worked with blink no longer works with libtxt?  Looks like @najeira is currently building a custom engine to enable blink. :)

I'm sure some equivalent workaround could be made to work, but that kind of workaround (pretty much anything involving building one's own engine) is definitely not supported use of the API.
The correct fix is to propagate the locale and the text direction together from the framework to the engine. I believe @HansMuller is looking at this as we speak.

I am indeed.

Thank you for reading my article!
It is not regression. My patch just does not work on the new libtxt.


BUG:

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Filters not working in the given website
say i only select intern option then the site must render the options only fitting the job description. Hence making it more responsive and user friendly
As u can see that even though I selected intern as option, it only shows full time offers

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Go Ahead @NalinDalal


v1.0 ArgumentOutOfRangeException for DateTime before 1970 if has milliseconds. Works in 0.9.X

The code snippet below works with versions 0.9.0, 0.9.1, 0.9.2, but faults on 1.0.0 with this error:
System.ArgumentOutOfRangeException: 'nanoseconds must be non negative value and lessor than 999,999,999. Parameter name: nanoseconds
It seems MsgPack-CLI version 1.0 faults for certain values of DateTime.
Fails: 1969-12-31T23:59:59.001 to 1969-12-31T23:59:59.999
Works: 1969-12-31T23:59:59.000
Works: 1970-01-01
It always seems to work after 1970-01-01 and always fail to serialize dates before 1970-01-01 if and only if the milliseconds are non-zero.
    public class MyClass
    {
        public DateTime MyDate;
    }

    public static void TestBrokenMessagePack()
    {
        var serializerMPMyClass = SerializationContext.Default.GetSerializer<MyClass>();
        using (var stream = new MemoryStream())
        {
            var my = new MyClass
            {
                MyDate =
                DateTime.Parse("1969-12-31T23:59:59.001")
            };
            serializerMPMyClass.Pack(stream, my); // << This line faults
        }
    }

Thank you for reporting. I will investigate this.

It looks a bug for conversion for new timestamp type, but this failure caused by unintended breaking change for date time serialization. I will add mitigation to this with timestamp conversion related bug fix.


Clean removal of MCADv1 and Instascale

https://issues.redhat.com/browse/RHOAIENG-5129

As expected the OLM Install and Upgrade test fails as the MCAD v1 CRDs were removed.

Just left a comment for the tests, otherwise LGTM.

/lgtm

/approve

does this PR consider the cleanup CRD in the upgrade path?
i see it does not install mcad for clean installation, but shouldnt be some logic does the removal for upgrade too?


Update URL for install_blockscout.sh in BlockScout setup guide

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [x] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

BlockScout setup (https://github.com/Azure-Samples/blockchain/blob/master/ledger/template/ethereum-on-azure/technology-samples/blockscout/README.md) has invalid URL to download install_blockscout.sh
Currently: http://www.github.com/azure-samples/blockchain/ledger/template/ethereum-on-azure/block-explorers/blockscout/install_blockscout.sh
Should be: https://raw.githubusercontent.com/Azure-Samples/blockchain/master/ledger/template/ethereum-on-azure/technology-samples/blockscout/install_blockscout.sh

Link updated.


mysql container not loading

Having issues with the mysql container during set up of resources.
=> Waiting for confirmation of MySQL service startup, trying 58/60 ...
=> Waiting for confirmation of MySQL service startup, trying 59/60 ...
Time out. Error log is shown as below:
150921 19:42:34 [Warning] Using unique option prefix myisam-recover instead of myisam-recover-options is deprecated and will be removed in a future release. Please use the full name instead.
150921 19:42:34 [Note] Plugin 'FEDERATED' is disabled.
150921 19:42:34 InnoDB: The InnoDB memory heap is disabled
150921 19:42:34 InnoDB: Mutexes and rw_locks use GCC atomic builtins
150921 19:42:34 InnoDB: Compressed tables use zlib 1.2.8
150921 19:42:34 InnoDB: Using Linux native AIO
150921 19:42:35 InnoDB: Initializing buffer pool, size = 128.0M
150921 19:42:35 InnoDB: Completed initialization of buffer pool
InnoDB: The first specified data file ./ibdata1 did not exist:
InnoDB: a new database to be created!
150921 19:42:35  InnoDB: Setting file ./ibdata1 size to 10 MB
InnoDB: Database physically writes the file full: wait...
150921 19:42:35  InnoDB: Log file ./ib_logfile0 did not exist: new to be created
InnoDB: Setting log file ./ib_logfile0 size to 5 MB
InnoDB: Database physically writes the file full: wait...
150921 19:42:36  InnoDB: Log file ./ib_logfile1 did not exist: new to be created
InnoDB: Setting log file ./ib_logfile1 size to 5 MB
InnoDB: Database physically writes the file full: wait...
InnoDB: Doublewrite buffer not found: creating new
InnoDB: Doublewrite buffer created
InnoDB: 127 rollback segment(s) active.
InnoDB: Creating foreign key constraint system tables
InnoDB: Foreign key constraint system tables created
150921 19:42:36  InnoDB: Waiting for the background threads to start
150921 19:42:37 InnoDB: 5.5.44 started; log sequence number 0
150921 19:42:37  InnoDB: Starting shutdown...
150921 19:42:38  InnoDB: Shutdown completed; log sequence number 1595675
150921 19:42:38 [Warning] Using unique option prefix myisam-recover instead of myisam-recover-options is deprecated and will be removed in a future release. Please use the full name instead.
150921 19:42:38 [Note] Plugin 'FEDERATED' is disabled.
150921 19:42:38 InnoDB: The InnoDB memory heap is disabled
150921 19:42:38 InnoDB: Mutexes and rw_locks use GCC atomic builtins
150921 19:42:38 InnoDB: Compressed tables use zlib 1.2.8
150921 19:42:38 InnoDB: Using Linux native AIO
150921 19:42:38 InnoDB: Initializing buffer pool, size = 128.0M
150921 19:42:38 InnoDB: Completed initialization of buffer pool
150921 19:42:38 InnoDB: highest supported file format is Barracuda.
150921 19:42:38  InnoDB: Waiting for the background threads to start
150921 19:42:39 InnoDB: 5.5.44 started; log sequence number 1595675
ERROR: 1064  You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'ALTER TABLE user ADD column Show_view_priv enum('N','Y') CHARACTER SET utf8 NOT ' at line 1
150921 19:42:39 [ERROR] Aborting

150921 19:42:39  InnoDB: Starting shutdown...
150921 19:42:43  InnoDB: Shutdown completed; log sequence number 1595675
150921 19:42:44 [Note] /usr/sbin/mysqld: Shutdown complete

150921 19:42:44 [Warning] Using unique option prefix myisam-recover instead of myisam-recover-options is deprecated and will be removed in a future release. Please use the full name instead.
150921 19:42:44 [Note] Plugin 'FEDERATED' is disabled.
150921 19:42:44 InnoDB: The InnoDB memory heap is disabled
150921 19:42:44 InnoDB: Mutexes and rw_locks use GCC atomic builtins
150921 19:42:44 InnoDB: Compressed tables use zlib 1.2.8
150921 19:42:44 InnoDB: Using Linux native AIO
150921 19:42:44 InnoDB: Initializing buffer pool, size = 128.0M
150921 19:42:44 InnoDB: Completed initialization of buffer pool
150921 19:42:44 InnoDB: highest supported file format is Barracuda.
150921 19:42:44  InnoDB: Waiting for the background threads to start
150921 19:42:45 InnoDB: 5.5.44 started; log sequence number 1595675
150921 19:42:45  InnoDB: Starting shutdown...
150921 19:42:46  InnoDB: Shutdown completed; log sequence number 1595675
150921 19:42:46 [Warning] Using unique option prefix myisam-recover instead of myisam-recover-options is deprecated and will be removed in a future release.
Version: '5.5.44-0ubuntu<IP_ADDRESS>'  socket: '/var/run/mysqld/mysqld.sock'  port: 3306  (Ubuntu)
=> Creating MySQL user ninja with preset password
=> Done!
========================================================================
You can now connect to this MySQL Server using:

    mysql -uninja -pninja -h<host> -P<port>

Please remember to change the above password as soon as possible!
MySQL user 'root' has no password but only allows local connections
========================================================================
Creating MySQL database douitsu
Database created!
tail -F $LOG

Hi, sorry I completely missed this issue until just now. Let me  know if this is still a problem and I will help you get to a resolution.

@kjetilhp this is 3 years later, but I've just committed a new PR (#5) which upgrades docker-compose to v3 format, which also includes a change from the tumtum mysql docker image to the official mariadb one, which may work for you.


Tenant Helper

As a MailOps admin, I need a straightforward way to configure tenants in a plaintext format.
Wez has already put together a draft format for the configuration TOML:
# Allow optional scheduled sends based on this header
# https://docs.kumomta.com/reference/message/import_scheduling_header
scheduling_header = "X-Schedule"
# Set the tenant from this header
tenant_header = "X-Tenant"
# Set the campaign from this header
campaign_header = "X-Campaign"
# The tenant to use if no tenant_header is present
default_tenant = "default-tenant"

[tenant.'default-tenant']
egress_pool = 'pool-0'

[tenant.'mytenant']
# Which pool should be used for this tenant
egress_pool = 'pool-1'
# Override age based on tenant; this overrides
# settings at the domain level
max_age = '10 hours'
# Only the authorized identities are allowed to use this tenant
# via the tenant_header
require_authz = ["scott"]

# The default set of parameters
[queue.default]
max_age = '24 hours'

# Base settings for a given destination domain.
# These are overridden by more specific settings
# in a tenant or more specific queue
[queue.'gmail.com']
max_age = '22 hours'
retry_interval = '17 mins'

[queue.'gmail.com'.'mytenant']
# options here for domain=gmail.com AND tenant=mytenant for any unmatched campaign

[queue.'gmail.com'.'mytenant'.'welcome-campaign']
# options here for domain=gmail.com, tenant=mytenant, and campaign='welcome-campaign'

Usage is: create one of more files using the syntax shown above, then in your init.lua:
local queue_module = require 'policy-extras.queue'
-- You can pass multiple file names if desired
local queue_helper = queue_module:setup({'/opt/kumomta/etc/queue.toml'})

kumo.on('smtp_server_message_received', function(msg)
  queue_helper:apply(msg)
  -- do your dkim signing here
end)


⚠ Fortnite has degraded performance

In 256923c, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1505 ms

Resolved: Fortnite performance has improved in c6b74b7.


IRGen: Set instanceStart correctly in ObjC rodata when first stored property is empty.

Give empty fields a notional byte offset so we can still use the offset of the first field as an approximation of the instanceStart of a class.
Fixes SR-1055.

@swift-ci Please test

@rjmccall, does this look like a reasonable fix for 2.2?

A type layout fuzzer would be nice :)

@swift-ci Please test

@swift-ci Please test

This looks good to me, but I'd like a review on this before it is pulled into Swift 2.2.1.

Yes, LGTM.


Update README.md

Hello,
I was unable to install proxalgs via pip as of today on OS X 10.11 with python 2 and 3 installed; git cloning appears to work though. Not sure if this is a general issue but if it is, perhaps these changes might help novice users.
Best,
Seth Green

Coverage remained the same at 68.75% when pulling cc5b1714fe474ae2eb70564d06c49d9e7cd81642 on setgree:master into<PHONE_NUMBER>e2f716ec5826558aa5ce4524263357 on ganguli-lab:master.

Hi Seth,
Thanks for bringing this to my attention! I didn't realize the pip install command was not working.
I've updated the pip package and it should now install without any problems, so I'm going to keep the README as is.
thanks!
Niru

Glad to hear it, I just installed it, executes without a hitch, thanks for the prompt reply!


proposal: time: support Colon for fractional seconds

What version of Go are you using (go version)?

$ go version
go version go1.12.7 windows/amd64

Does this issue reproduce with the latest release?
Yes, I can reproduce it on the playground
What operating system and processor architecture are you using (go env)?
GOOS=windows
GOARCH=amd64
GOHOSTARCH=amd64
go env Output
$ go env
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\N555074\AppData\Local\go-build
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=D:\Development\go
set GOPROXY=
set GORACE=
set GOROOT=D:\Go
set GOTMPDIR=
set GOTOOLDIR=D:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\N555074\AppData\Local\Temp\go-build289214998=/tmp/go-build -gno-record-gcc-switches

What did you do?
Attempt to parse a date/time string containing milliseconds preceded by a colon. Example:
https://play.golang.org/p/eY-B7yU7cbT

What did you expect to see?
Time is 02/12/2019 15:45:48:746
What did you see instead?

parsing time "02/12/2019 15:45:48:746" as "02/01/2006 15:04:05:000": cannot parse "746" as ":000"

This is not an issue. Please review the documentation for package time:

A fractional second is represented by adding a period and zeros to the end of the seconds section of layout string, as in "15:04:05.000" to format a time stamp with millisecond precision.

For your example, the format string must be 02/01/2006 15:04:05.000, not 02/01/2006 15:04:05:000. The input string must also be corrected.
Here is your example corrected: https://play.golang.org/p/E46bFklY7L3

I'm sorry but I have to disagree. I reviewed the documentation thoroughly before writing the original issue, and I am well aware that the problem does not occur if a period is used in place of a colon. That was the whole point of the report I filed. The generated file I am processing uses a colon instead of a period. Which is non-standard, I completely agree. But, that's kind of my point. Non-standard things happen "in the wild", and the library needs to be able to handle them.
Yes, I can work around it by doing a search and replace on the colon in the string. That's what I'm doing for now. But the whole point of a format string, is to... specify the format of the string you want to parse. It's seems we've missed the mark if we have cases like that that it is impossible to format for.
Please, I would ask you, give the issue some more consideration before dropping it again. I'm not expecting this will change tomorrow or anything like that, but isn't it better in the long term if the format strings are able to cover a wider variety of cases ?
This general theme seems to be a recurring issue, to wit:
https://github.com/golang/go/issues/6189
https://github.com/golang/go/issues/27746
https://github.com/golang/go/issues/26002
Couldn't some consideration be given to this? Alternatively, maybe this is a plus point for the priority of localization support

It seems like you want to file a proposal, rather than an issue. And from what I understand, your proposal is very similar to #6189. I'd suggest that you can subscribe to that issue for updates. Or if you feel the colon as a separator deserves its own proposal, please feel free to go ahead and file one.

All the details are here already—reopened and converted to proposal.

You can try this package: https://github.com/tengattack/jodatime ;)

Non-standard things happen "in the wild", and the library needs to be able to handle them.

Unfortunately, many things happen in the wild, and it is not a goal to handle all of them. That would lead to enormous libraries that are hard to learn to use.

Non-standard things happen "in the wild", and the library needs to be able to handle them.

Unfortunately, many things happen in the wild, and it is not a goal to handle all of them. That would lead to enormous libraries that are hard to learn to use.

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

Thank you for considering this further. I very much agree with exactly the sentiment expressed by @trbroyles1 above.

Unfortunately, many things happen in the wild, and it is not a goal to handle all of them.

I believe there is a very specific ask here, which is to make one specific separator configurable. It could likely be limited to a very small set of possible values, perhaps ., ,, ;, :, -.
While it is trivial to write a string replacement, it is a major performance hit when attempting to process millions of timestamps per second, for example.
Admittedly, it should be difficult to justify a general performance hit for all users of time.Parse, but it would seem reasonable to at least explore this use case further before ruling it out. Perhaps there is an implementation that is essentially performance neutral in most cases but also solves #6189, #27746, and #26002.

Thank you for considering this further. I very much agree with exactly the sentiment expressed by @trbroyles1 above.

Unfortunately, many things happen in the wild, and it is not a goal to handle all of them.

I believe there is a very specific ask here, which is to make one specific separator configurable. It could likely be limited to a very small set of possible values, perhaps ., ,, ;, :, -.
While it is trivial to write a string replacement, it is a major performance hit when attempting to process millions of timestamps per second, for example.
Admittedly, it should be difficult to justify a general performance hit for all users of time.Parse, but it would seem reasonable to at least explore this use case further before ruling it out. Perhaps there is an implementation that is essentially performance neutral in most cases but also solves #6189, #27746, and #26002.

If timestamp processing is a bottleneck, I would strongly encourage you to write a custom parser rather than using time.Parse.  time.Parse is not optimized for speed.  Writing for a specific known layout should be measurably faster.  Just feed the results into time.Date.

If timestamp processing is a bottleneck, I would strongly encourage you to write a custom parser rather than using time.Parse.  time.Parse is not optimized for speed.  Writing for a specific known layout should be measurably faster.  Just feed the results into time.Date.

My primary use case is distributed log processing, which involves consuming a wide variety of timestamp layouts. time.Parse is almost a perfect solution, with the current proposal covering the only gap I've seen.
Performance-wise, time.Parse has been fine. Timestamp parsing is not a bottleneck, but it is one step in a series of transformations that must be performed on each log. A string replacement operation on every timestamp would be purely additive, hence why I'd like to avoid it if at all possible.
Details of my use case aside, I mostly just wanted to draw focus to the fact that this proposal is a narrowly defined ask, and that is aligned with what I understand to be the purpose of time.Parse - to provide a mechanism for parsing many real-world timestamp layouts. Clearly, there are limitations to what layouts should be supported, but it would seem that the issues linked above collectively make a case for the notion that this particular separator should be configurable.

My primary use case is distributed log processing, which involves consuming a wide variety of timestamp layouts. time.Parse is almost a perfect solution, with the current proposal covering the only gap I've seen.
Performance-wise, time.Parse has been fine. Timestamp parsing is not a bottleneck, but it is one step in a series of transformations that must be performed on each log. A string replacement operation on every timestamp would be purely additive, hence why I'd like to avoid it if at all possible.
Details of my use case aside, I mostly just wanted to draw focus to the fact that this proposal is a narrowly defined ask, and that is aligned with what I understand to be the purpose of time.Parse - to provide a mechanism for parsing many real-world timestamp layouts. Clearly, there are limitations to what layouts should be supported, but it would seem that the issues linked above collectively make a case for the notion that this particular separator should be configurable.

We still can't do everything. To be worth making a special case here we'd need to know this was a very common thing to run into. A priori it sounds like it's not. But do you perhaps know what is generating these odd times? Is there some commonly-used spec we are unaware of?

We still can't do everything. To be worth making a special case here we'd need to know this was a very common thing to run into. A priori it sounds like it's not. But do you perhaps know what is generating these odd times? Is there some commonly-used spec we are unaware of?

Log4J has a default timestamp format that uses , as the separator. Applications that use the library commonly emit such timestamps. I've seen this format coming from Cassandra, Hadoop, Kafka, and Zookeeper, to name a few.
According to Wikipedia, ISO_8601 states that a comma is acceptable, even preferred. Presumably that may be why Log4J chose this default.
I have personally only run into the need for a comma as an alternate separator, but as an additional data point, here is a list of timestamp formats recognized by Sumo Logic, which appears to include at least one other separator.

Log4J has a default timestamp format that uses , as the separator. Applications that use the library commonly emit such timestamps. I've seen this format coming from Cassandra, Hadoop, Kafka, and Zookeeper, to name a few.
According to Wikipedia, ISO_8601 states that a comma is acceptable, even preferred. Presumably that may be why Log4J chose this default.
I have personally only run into the need for a comma as an alternate separator, but as an additional data point, here is a list of timestamp formats recognized by Sumo Logic, which appears to include at least one other separator.

Comma seems plausible, because of course many countries use decimal comma.  But that is not this proposal.
One thing to consider is that if we recognize other characters as introducing a fractional number of seconds, it will be possible to write formats whose behavior will change unexpectedly.  For example, time.Now().Format("05,000").  This doesn't prevent us from making a change, but it's worth bearing in mind.

Comma seems plausible, because of course many countries use decimal comma.  But that is not this proposal.
One thing to consider is that if we recognize other characters as introducing a fractional number of seconds, it will be possible to write formats whose behavior will change unexpectedly.  For example, time.Now().Format("05,000").  This doesn't prevent us from making a change, but it's worth bearing in mind.

In the absence of some kind of widely-used standard that uses : for a decimal point in this context, it seems like we should not add the complexity here. Comma is a separate issue (#43823).

In the absence of some kind of widely-used standard that uses : for a decimal point in this context, it seems like we should not add the complexity here. Comma is a separate issue (#43823).

Based on the discussion above, this proposal seems like a likely decline.
— rsc for the proposal review group

Based on the discussion above, this proposal seems like a likely decline.
— rsc for the proposal review group

No change in consensus, so declined.
— rsc for the proposal review group

I get that this issue is closed and sorry in advance for the necro but searching led me here, and I wanted to add a data point since the only data point that appears in this thread is log4j.
My use case is that Unreal Engine 4 formats logs in a custom way e.g. 2022.01.17-00.40.39:660 with the :660 part being milliseconds. I'll also emphasize here that this case isn't a loc issue, it's just a custom format.
The reason this is problematic is that I'm piping logs from a UE4 game server to a SaaS called Honeycomb (written in go, and it more or less passes timestamps through to time.ParseInLocation()). The closest I can get to making this work out of the box is 2006.01.02-15.04.05 but I wish I could've done 2006.01.02-15.04.05:000 and moved on.
Trying to make this work isn't as simple as modifying some of my application code which seems to be the workaround folks have settled on. To solve this, I'd either have to open a PR to Honeycomb, modify Unreal Engine's source, or create an entirely new log sink in my UE game code. So in my mind this issue represents a developer experience issue (not a loc issue) since all of those approaches are much higher effort than adding more flexible time parsing support.
I'm not intending to re-open this, I'll just say that as a person that's learning Go to investigate this issue, it feels like an odd choice to not allow decoupling of the seconds from the milliseconds in a time format string. For context, I'm coming from the .net world where you would use the string yyyy.MM.dd-HH.mm.ss:fff out of the box to parse those UE4 logs.


Sync screens draw order on set Priority.

Part of https://github.com/playcanvas/engine/issues/3514
This PR makes it so the raw order of UI Elements is refreshed properly when changing a Screen's priority attribute.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

We should expose priority as public API too :)

We should expose priority as public API too :)

Changed in JSDocs (so it appears in API Reference) and also changed the manual: https://github.com/playcanvas/developer.playcanvas.com/pull/411


Develop

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c75a928). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   54.76%
=========================================
  Files             ?        1
  Lines             ?       42
  Branches          ?        5
=========================================
  Hits              ?       23
  Misses            ?       14
  Partials          ?        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c75a928...9dfdb06. Read the comment docs.


Update passbolt.py

fix typography error on forder_parent_id to folder_parent_id creating ressource into a specific folder

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Oh my... Thank you for your PR and fixing this typo!

I just published version 0.0.8: https://galaxy.ansible.com/anatomicjc/passbolt


Pluralisation issue with the char and word count

A picture is worth a thousand words :)

What is browser version? Also which preview version you are using?

Is this information even relevant?

Yes, Browser Info. I am using Firefox 89 and I didn't meet same issue. Also which Link you viewed the project on.

This one. Chrome 91.0.4472.114. It should be "1 Char" and "1 Word" respectively.

Looks like a font issue. I have tested on Chrome 91.0.4472.114 (Same like yours) and also I didn't meat same issue. So Is there any errors in the console or block the fonts. I am using Google Fonts. Thank you for reporting.

For Reference, This is the Screenshot for Google Chrome:

Have you tried typing some characters?

@kevinmmansour it's line 74 that is faulty - you do not do any pluralization logic there. You need to wrap the pluralizable strings into a utility function (inability to do so bugs SE to this day, btw)

Have you tried typing some characters?

Yes.

@kevinmmansour it's line 74 that is faulty (and line 73 for that matter) - you do not do any pluralization logic there. You need to wrap the pluralizable strings into a utility function (inability to do so bugs SE to this day, btw).
A semi-naive implementation would look like this:
/**
 * @summary base pluralization
 * @param {number} amount
 * @returns {string}
 */
const pluralize = (amount, pluralSuffix = "s", singularSuffix = "") => amount !== 1 ? pluralSuffix : singularSuffix;

A less naive implementation could take into account different word forms English has in terms of pluralization

OK. I will try to implement that later. Thank you. :)

@double-beep Thank you for reporting. I understood now and I will try to solve in future versions.

Solved and deployed. Thank you. :)


Do I install this into the regular RE2 folder, or in dinput8?

I'm assuming the folder, but just to be sure.

correct, in regular RE2 folder.


Dailymotion Bid Adaptor: add support for user syncs & new fields

Type of change

[x] Feature

Description of change

Adding support for user syncs
Adding support for plcmt & playbackmethod
Adding support for additional contextual informations

More global comment, shouldn't we do one feature on PR? in this case one for the new fields and one for the user syncs?

@rumesh, to answer your comment, we are moving forward with grouped contributions to have Prebid org review a single PR for all features (no multi-assignments of reviewers, and everything in a single process). We'll ask them for feedback if they would prefer a one PR per feature approach.


#126 Add Organization Deletion Endpoint

Add Organization Deletion Endpoint
Description
This pull request adds an API endpoint to handle the deletion of an organization. The endpoint validates the organization ID and updates the specified organization's deleted attribute to true in the database upon successful validation.
GitHub Issue: Organization Deletion Endpoint
Acceptance Criteria

Endpoint: The endpoint is accessible at /api/v1/organizations/:org_id.
HTTP Method: The endpoint accepts HTTP DELETE requests.
Authentication: The endpoint is protected and requires authentication.
Ownership Check: The endpoint verifies that the user hitting the endpoint is the owner of the organization.
Authorization Header: Requests to the endpoint include a valid authentication token in the Authorization header (e.g., Authorization: Bearer <token>).
Database Update: Upon successful validation of the organization ID, the organization is marked as deleted by changing the deleted attribute in the database to true.
Data Integrity: All related data to the organization remains intact.

How to Test Manually
Prerequisites

Ensure you have the latest code from the main branch.
Ensure your environment variables for database and authentication are set correctly.

Steps to Test

Clone the repository: git clone <repository-url>
Checkout to the new branch: git checkout <your-branch-name>
Install dependencies: npm install
Run the application: npm start
Authenticate and obtain a valid token: Use the login endpoint to get a token.
Issue a DELETE request to the endpoint:

Use a tool like Postman or curl:DELETE /api/v1/organizations/<org_id>
Content-Type: application/json
Authorization: Bearer <token>

Replace <org_id> with a valid organization ID and <token> with your authentication token.

Verify the responses:

For a valid request, expect a 204 No Content status.
For an invalid organization ID format, expect a 400 Bad Request status.
For a non-existent organization ID, expect a 404 Not Found status.
For unauthorized deletion attempt, expect a 401 Unauthorized status.

Expected Outcomes

204 No Content: The organization is marked as deleted.
400 Bad Request: Invalid organization ID format.
404 Not Found: Invalid organization ID.
401 Unauthorized: User not authorized to delete this organization.

Checklist

[x] Developed server-side logic to handle organization deletion requests.
[x] Validated and sanitized incoming organization ID data.
[x] Validated that the user deleting the organization is the owner.
[x] Changed the specified organization's deleted attribute to true in the database upon successful validation.
[x] Maintained data integrity by keeping all related data of the specified organization intact.
[x] Wrote unit tests to ensure the organization deletion endpoint validates input correctly and removes the organization from the system.
[x] Tested various scenarios for submitting the organization ID (e.g., valid ID, non-existent ID, malformed ID, etc.).
[x] Verified that all unit tests pass.
[x] Ensured the code follows the project's style guidelines.
[x] Removed all console logs and comments.
[x] Updated the documentation as necessary.
[x] Informed relevant stakeholders of the changes.

fix pr name

Done

you're sending a pr from your dev branch. It should come from your own local branch of that issue e.g "feat/org-deletion-endpoint".
See other pr's for reference


GitHub actions 2020

Please help keep the CHANGELOG up to date by providing a one sentence summary of your change:
Testing GHA with lessons learned from another repo and adjusting @softprops ' 💯  work from: https://github.com/rusoto/rusoto/pull/1564
I can see this replacing both Azure Pipelines as well as Semaphore and Appveyor if things go well. 😄
By doing this we reduce reliance on my account for Azure Pipelines, SemaphoreCI and Appveyor.

I'd like to exercise build failures to ensure the builds fail when they should.

skeptic tests
unit tests
integration test cargo check
credential integration test w/warp
formatting issues/crategen overwriting hand-made changes to generated files

Once I can demonstrate it works as expected I'll squash this PR into a single commit. 😄
@iliana are you able to restart the jobs on github actions? That's another big reason for moving off Pipelines, Semaphore etc... that are tied only to my github account.

Yep, I get a "Re-run all jobs" menu item.

Interesting how one failure in a build will stop all others in the build matrix. rustls_unit_test failed on linux/beta first and all other rustc and OS jobs were cancelled right after. I bet we can tweak that behavior but it may cause issues where nightly fails and builds get marked as failed when it may be an issue we don't care about.

Thanks for bearing with this PR as it's turned out more fussy than I anticipated.
I found and fixed an issue where the credential provider integration test could fail and the build job for it still passed.
A push is coming later to hopefully turn all builds on GitHub Actions (GHA) back to green. When that happens I'll turn this into a ready-to-review PR from its current draft state. Once it's merged we can verify GHA builds for a push to our main branch.
Followup PRs can be made to turn off Azure Pipelines by deleting the files/folder for it.
Changing all our use of nightly compilers to use the GHA experimental flag so failing nightly builds don't stop the entire workflow could be done in another followup PR. I like that approach instead of adding it to this one because of my limited availability.
Once we've got that done I can ensure Semaphore, Appveyor and Azure Pipelines are all turned off for this project and we'll be entirely on GHA. 🎉

Wow it works! So exciting

🤞

:tada:
@matthewkmayer Are you disabling Semaphore after this merge?

Let's use https://github.com/rusoto/rusoto/issues/1553#issuecomment-693773182 to track the changes left to get off the other build services. 👍 If we need to disable Semaphore sooner rather than later, let me know in there. 😄


[Refactoring] Setting up CI/Dev tools.

We need a minimal CI/Development tools such as tox and github actions.
We can just apply https://github.com/scipp/copier_template and remove unnecessary things.

Done as main branch was updated.


HVAC problem with multiple commands at once

When i have an automation or script wher it turns on the AC sets the temperature and set the fan mode the ac turns off immediately after the power on and also sometimes if you send command for temp and fan while is on it increase the temp and after one second it reverts back to the original temp.

Hi,
Can you enable debug logging, run your script and then post the logs here?

Sorry my mistake i was using another hacs integration, injust tested yours and everything works great i’m switching to yours :)

Oh well that's great to hear! Let me know if anything else is off.


Enable 'explore" with knn classification

Would it be possible to enable 'explore' functionality that returns results based on knn classification?
So the explore query could (in pseudo code) look something like this:
knn_explore(explore_concept, target_class, nnn)

where:

explore_concept is the concept you try to classify
target_class is the class you try to classify to
nnn is the number of nearest neighbors

The result would be:
[ beacon_1, beacon_2, beacon_3]

presented in order of distance from the explore_concept

@michaverhagen do you mean nnn as in words or data-objects?

I think for most use cases data objects would be most relevant


Remove Yarn instructions

Don't need Yarn anymore - npm has the features now

@zaccolley happy to merge but can you just fix the conflicts pls 😄


optimize Document matching and add benchmarks;

A Cross-check with original(training) files is incredibly slow for various reason.
Todo:

Check the size of vocabulary - may be too big, (filter out by # of docs, add stemmers, ...) ;
Review the iterations in the matching process;

Add benchmarks:

matching functions;
creation of termVector from the document;

Here's docs for benchmarking: // https://doc.rust-lang.org/nightly/unstable-book/library-features/test.html

Done;


About oracles of arxiv

Hello, sorry to bother you. I have difficulty in processing oracles of arxiv training set. I just run arxiv_oracle.py and wait. I trained for 4 days and it only produces 4300 files in index_train.  Can you check this python files? I'm really confused now.

I‘ve find the problem.

The progress takes me 100% MEM, it may have some problems.....

Hi, @RIU-13, it is somewhat slow and we used more workers (and correspondingly more cpu cores) on our cluster. How much memory do you have on your server?


Fix ARMViolation Error for Microsoft.Authorization

Fix ARMViolation Error for Microsoft.Authorization

Can one of the admins verify this patch?

Automation for azure-sdk-for-python

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-go

Automation for azure-sdk-for-java

Automation for azure-sdk-for-node


How to print each jedis connection and commond in the log? Is there a way to do that?

How to print each jedis connection and commond in the log? Is there a way to do that?

Please ask this question in the mailing list. github is used for design discussions and bugs mainly.
http://groups.google.com/group/jedis_redis


Home grown Tokenization library vs. Microsoft Tokenizer library

Hello, just a quick question what is the purpose of using the tokenization that is ported vs. Microsoft Tokenizer Library?
Thank you 🙏

no particular reason, the library in the repo has been developed sooner (used to be here), it's a direct port of OpenAI lib and has been optimized over the time for performance. Tokenizers can be injected though, so if one prefers using a different implementation that's possible.


TypeError: Object of type Document is not JSON serializable

Any comments would be appreciated.
The issue is that the json module is unable to serialize the Document object, which is a custom class that inherits from BaseModel. The error message specifically says that the Document object is not JSON serializable, meaning it cannot be converted into a JSON string. This is likely because the json module does not know how to serialize the BaseModel class or any of its child classes. To fix the issue, we may need to provide a custom encoder or implement the jsonable_encoder function from the FastAPI library, which is designed to handle pydantic models like BaseModel.
def query_chromadb():
    client_settings = chromadb.config.Settings(
        chroma_db_impl="duckdb+parquet",
        persist_directory=DB_DIR,
        anonymized_telemetry=False
    )

    embeddings = OpenAIEmbeddings()

    vectorstore = Chroma(
        collection_name="langchain_store",
        embedding_function=embeddings,
        client_settings=client_settings,
        persist_directory=DB_DIR,
    )

    result = vectorstore.similarity_search_with_score(query="FREDERICK", k=4)
    print(result)
    print(json.dumps(result, indent=4, sort_keys=False)) // ERROR

def main():
    # init_chromadb()
    query_chromadb()

import json
from pydantic import BaseModel, Field

class Document(BaseModel):
    """Interface for interacting with a document."""

    page_content: str
    metadata: dict = Field(default_factory=dict)

doc = Document(page_content="Some page content", metadata={"author": "John Doe"})

print(json.dumps(doc)) // ERROR

Possible fixes:
import json

from pydantic import BaseModel, Field

class Document(BaseModel):
    """Interface for interacting with a document."""

    page_content: str
    metadata: dict = Field(default_factory=dict)

    def to_dict(self):
        return self.dict(by_alias=True, exclude_unset=True) # just an example!

    def to_json(self):
        return self.json(by_alias=True, exclude_unset=True) # just an example!

doc = Document(page_content="Some page content", metadata={"author": "John Doe"})

# Convert to dictionary and serialize
doc_dict = doc.to_dict()
doc_json = json.dumps(doc.to_dict())

## {"page_content": "Some page content", "metadata": {"author": "John Doe"}}
print(doc_json)

# Or use the custom to_json() method
doc_json = doc.to_json()
## {"page_content": "Some page content", "metadata": {"author": "John Doe"}}
print(doc_json)

Another approach:
import json
from fastapi.encoders import jsonable_encoder
from pydantic import BaseModel, Field

class Document(BaseModel):
    """Interface for interacting with a document."""

    page_content: str
    metadata: dict = Field(default_factory=dict)

doc = Document(page_content="Some page content", metadata={"author": "John Doe"})

print(json.dumps( jsonable_encoder(doc), indent=4))

Do we need an API like doc.to_json() or/and doc.to_dict()? Because in this case it will hide the details of model realization from the end user.

I'm experiencing this error "Object of Type Document is not JSON serializiable." I'm gonna bang my head against the wall until my head stops hurting. thanks.
#openai api key
openai_api_key =
Connect to Pinecone API
pinecone_key =
pinecone.init(api_key=pinecone_key, environment='us-east1-gcp')
check if index database already exists (only create index if it doesn't)
if 'index-test' not in pinecone.list_indexes():
print ('pinecone database not found')
# assign pinecone Index object
index = Pinecone.Index('index-test')
hasVectors = None

# check Index object stats (vector count)

indexStats = index.describe_index_stats()

# print(indexStats)

# assign vector count to variable

num_vectors = indexStats.total_vector_count

# print(num_vectors)

if num_vectors > 0:

    # print(f"The 'my-index' index contains {num_vectors} vectors.")
    hasVectors = True
else:

    # print(f"The index does not contain any vectors")
    hasVectors = False

bucket_name = 'text-test-000000010001'
file_key = 'Whole30-Slow-Cooker-Freezer-Meal-Plan-from-New-Leaf-Wellness.pdf'
#use the document loader
loader = S3FileLoader(bucket_name, file_key)
#load the document from the loader
documents = loader.load()
#split the document into text chunks
text_splitter = CharacterTextSplitter(
separator = "\n\n",
chunk_size = 1000,
chunk_overlap  = 200,
length_function = len,
)
split_texts = text_splitter.split_documents(documents)
#print(texts)
#call openai wrapper class
embeddings = OpenAIEmbeddings(model_name="text-embedding-ada-002")
#embed the texts from the s3 bucket using openai wrapper class
embedded_docs = embeddings.embed_documents(split_texts)
#push up to pinecone
Pinecone.from_documents()

Thanks, I figured out it has something to do with detectron2 ( so far ), as the unstructured reader I'm using for the S3 document loader. Nothing was mentioned in your docs about this package potentially not working...my largest difficulty has been dependencies upon dependencies of issues :/. Image not ready but Pillow works. Etc Etc. I'll let you know how detectron2 on Windows x86 goes...I'm sorry I don't think your docs are very clean or flushed out, use haystack as an example they have a much more .NET Microsoft looking UI/UX.  I'll keep this project going but I'm a determined person...

And the answer is .... The texts[0] is already an instance of the Document class. The print output is showing the default string representation of a Python object, which includes the class name and the memory address at which the object is stored. So there's no need to create a new instance. We can just use texts[0] directly: doc = texts[0]
Now your additions work perfectly for me sergerdn.. Thank you very much :)  I vote this to be added to the schema.py file.  Thanks again :)

This modification really needs to be adopted, because without it, my use case keeps throwing the error:- Object of type Document is not JSON serializable.
How can we push this up the list for adoption?

I am also being help back by this same issue. Please let me know when these changes are adopted into the codebase.

encountered this error when upgrading from v229 to v235
It works fine at v229
chain = create_structured_output_chain(OrderID, llm=ChatOpenAI(temperature=0, model="gpt-3.5-turbo-16k"), prompt=prompt)
OUTPUT
{'order_id': 123456789}
when I run this it outputs a dict with the extracted data and now with v235 its print output is
order_id=123456789 <class '__main__.OrderID'>
so I added this
    output_dict = {"order_id": run_chain.order_id}     print(output_dict)
to turn it back to a dict so that I would not get this error: TypeError: Object of type OrderID is not JSON serializable

This issue would have never happened in a non-strict-typed environment.
To stupidly workaround this when using a function that returns lots of Documents (e.x. Chroma) and get a dict from the document, you can do something like this:
        docs = db.similarity_search(input)
        docs_dict = [{"page_content": doc.page_content, "metadata": doc.metadata} for doc in docs]

This issue would have never happened in a non-strict-typed environment.
To stupidly workaround this when using a function that returns lots of Documents (e.x. Chroma) and get a dict from the document, you can do something like this:
        docs = db.similarity_search(input)
        docs_dict = [{"page_content": doc.page_content, "metadata": doc.metadata} for doc in docs]

Wow I was stuck on this and even decided to use pinecone client directly but then hit another roadblock.
Lucked into finding this thread and this is the only solution that works!
Thanks the page_content and json serializing error had me lost.

I don't get it why in one of the only placed where using pydantic made sense (so here), it is not used :(

can we get a fix for this please

This issue would have never happened in a non-strict-typed environment.
To stupidly workaround this when using a function that returns lots of Documents (e.x. Chroma) and get a dict from the document, you can do something like this:
        docs = db.similarity_search(input)
        docs_dict = [{"page_content": doc.page_content, "metadata": doc.metadata} for doc in docs]

Thank you @arash-bizcover. I sense that I might have eventually figured it out, but you saved me from a lot of frustration. This hiccup is just a byproduct of module development that's moving so fast things haven't had time to settle. I'm thankful for communities like GitHub where we can support each other and keep our sanity.

This issue would have never happened in a non-strict-typed environment.
To stupidly workaround this when using a function that returns lots of Documents (e.x. Chroma) and get a dict from the document, you can do something like this:
        docs = db.similarity_search(input)
        docs_dict = [{"page_content": doc.page_content, "metadata": doc.metadata} for doc in docs]

Thanks for this @arash-bizcover!
I suggest using the existing to_json function, this way if more class members are added to Document in future, the code won't need to be updated (otherwise we only save page_content and metadata)
docs_dict = [doc.to_json() for doc in docs]

Then to revive:
from langchain_core.load import load
reloaded_docs = [load(doc) for doc in docs_dict]

Note that to_json in fact returns a dict, which is then JSON serializable.

I get this with a List of langchain_core.documents.base.Document also
something like this?
import json
from typing import List

# from chromadb import Documents
from langchain_core.documents.base import Document

def pp_json(json_thing, sort=True, indents=4):

    if type(json_thing) is str:
        print(json.dumps(json.loads(json_thing), sort_keys=sort, indent=indents))
    elif type(json_thing) is list and type(json_thing[0] is Document):
        # List(Document):
        dict = [doc.to_json() for doc in json_thing]
        print(json.dumps(dict, sort_keys=sort, indent=indents))

    elif type(json_thing) is Document:
        dict = json_thing.to_json()
        print(json.dumps(dict, sort_keys=sort, indent=indents))
    else:
        print(json.dumps(json_thing, sort_keys=sort, indent=indents))
    return None

# print langchain documents
def pp_docs(docs: List[Document]):
    for n, doc in enumerate(docs):
        print(f"-- [DOC {n}]\n", doc.page_content)


refactor(travis): move E2E test to stage:test

fix #869

Deploy preview for js-primer ready!
Built with commit 5a7b560b7df7fff316f3591753100e238cd82b75
https://deploy-preview-870--js-primer.netlify.com


ArchTitus will not format my Patriot model: Viper M.2 VPN100

A few days ago I went to install ArchTitus on my machine and selected nvme1n1 to be formatted and the install would not format it. I exited out of the install, booted back into Manjaro, launched GParted and created a new GPT partition table on the Viper M.2 VPN100. I then proceed to reboot and attempt to install Arch using your script again and had the same issue. I've never had a issue with the drive and am willing to bet that if I choose to install any other OS on it there won't be any issues with the install. Any idea on how to address this would be greatly appreciated.  Root privileges required.
           ID-1: /dev/nvme0n1 maj-min: 259:1 vendor: Seagate model: XPG GAMMIX S11 Pro
           size: 476.94 GiB block-size: physical: 512 B logical: 512 B speed: 31.6 Gb/s
           lanes: 4 type: SSD serial: <filter> rev: 32B3T8EB temp: 34.9 C scheme: GPT
           ID-2: /dev/nvme1n1 maj-min: 259:0 vendor: Patriot model: Viper M.2 VPN100
           size: 238.47 GiB block-size: physical: 512 B logical: 512 B speed: 31.6 Gb/s
           lanes: 4 type: SSD serial: <filter> rev: ECFM22.6 temp: 31.9 C scheme: GPT
           ID-3: /dev/sda maj-min: 8:0 type: USB vendor: Seagate
           model: ST8000AS0002-1NA17Z size: 7.28 TiB block-size: physical: 4096 B
           logical: 512 B type: HDD rpm: 5980 serial: <filter> scheme: GPT
           ID-4: /dev/sdb maj-min: 8:16 type: USB vendor: Seagate model: Expansion HDD
           size: 7.28 TiB block-size: physical: 4096 B logical: 512 B type: N/A
           serial: <filter> rev: 1801 scheme: GPT
           ID-5: /dev/sdc maj-min: 8:32 type: USB vendor: Seagate model: ST330006 51NS
           size: 2.73 TiB block-size: physical: 4096 B logical: 512 B type: N/A
           serial: <filter> rev: 7101 scheme: GPT
           SMART Message: Unknown USB bridge. Flash drive/Unsupported enclosure?
           ID-6: /dev/sdd maj-min: 8:48 type: USB vendor: Seagate
           model: ST3000DM 001-1E6166 size: 2.73 TiB block-size: physical: 4096 B
           logical: 512 B type: N/A serial: <filter> rev: 7101 scheme: GPT
           SMART Message: Unknown USB bridge. Flash drive/Unsupported enclosure?
           ID-7: /dev/sde maj-min: 8:64 type: USB vendor: PNY model: USB 3.0 FD
           size: 115.38 GiB block-size: physical: 512 B logical: 512 B type: N/A
           serial: <filter> rev: PMAP scheme: MBR
           SMART Message: Unknown USB bridge. Flash drive/Unsupported enclosure?
Partition: ID-1: / raw-size: 476.64 GiB size: 476.64 GiB (100.00%)
           used: 94.22 GiB (19.8%) fs: btrfs dev: /dev/nvme0n1p2 maj-min: 259:3
           ID-2: /boot/efi raw-size: 300 MiB size: 299.4 MiB (99.80%)
           used: 568 KiB (0.2%) fs: vfat dev: /dev/nvme0n1p1 maj-min: 259:2
           ID-3: /home raw-size: 476.64 GiB size: 476.64 GiB (100.00%)
           used: 94.22 GiB (19.8%) fs: btrfs dev: /dev/nvme0n1p2 maj-min: 259:3
           ID-4: /var/log raw-size: 476.64 GiB size: 476.64 GiB (100.00%)
           used: 94.22 GiB (19.8%) fs: btrfs dev: /dev/nvme0n1p2 maj-min: 259:3
Swap:      Kernel: swappiness: 60 (default) cache-pressure: 100 (default)
           ID-1: swap-1 type: file size: 512 MiB used: 29.6 MiB (5.8%) priority: -2
           file: /swap/swapfile
Sensors:   Message: No sensor data found. Is lm-sensors configured?
Info:      Processes: 424 Uptime: 2d 39m wakeups: 311 Memory: 31.33 GiB
           used: 12.89 GiB (41.2%) Init: systemd v: 249 tool: systemctl Compilers:
           gcc: 11.1.0 Packages: 1701 pacman: 1657 lib: 446 flatpak: 33 snap: 11
           Shell: Zsh v: 5.8 default: Bash v: 5.1.8 running-in: konsole inxi: 3.3.08

You can try to run the commands manually and see what kind of error you possibly get

OK found a good tut on doing just that and creating both a fat32 and a BTRFS  had no issues. Then from my main desktop wiped the drive and tried again and no issues.

cd into the drive then just rm - rf everything then try again

cd is for navigating a file system. I'd want the drive either with just the GPT table or for the script to except a preformatted drive with the boot partition and the / partition.

cd is for navigating a file system. I'd want the drive either with just the GPT table or for the script to except a preformatted drive with the boot partition and the / partition.

This comment has nothing to do with the script. The script creates partitions and the the needed gpt table.
If it doesnt its a problem with your system

Again there is nothing wrong with the drive. I know that for a fact. Might actually get this solved faster if Chris would ever reply to peeps here and on his forum.

Fixed with today's commit


default other to one-time donation

this fix is not needed, as we already revert back to monthly when you come out of 'Other' dropdown.


Images start to mass download after a period of time leaving the program open

Bug description
After leaving Grabber open for a period of time, images start to mass download, seemingly at random. I do not believe I have any auto download settings on, and this behavior has not happened before. Seems to happen every time I launch the software, will not happen if closed quickly enough.
files.zip
Steps to reproduce
opening the application then leaving Grabber open for a while.
Expected behavior
just for an image to be saved and nothing more.
Context

Provide your main.log file to see if any obvious error occured.
Providing your settings.ini file will greatly help maintainers reproduce your problem if it may be caused by your configuration.
If the bug occured during a download, make sure to provide said download as an .igl file that Grabber can generate by clicking the Save button of the Downloads tab.

Note that both main.log and settings.ini files can be found in C:/Users/%USERNAME%/AppData/Local/Bionus/Grabber in Windows, and in the installation directory on Linux.
Screenshots
If applicable, add screenshots to help explain your problem.
System information

OS: Windows 10
Grabber version: 1.3.0 (x64)

Additional context
Add any other context about the bug report here.

Can you add your "monitors.json" file too ? You can rename it as a ".txt" to upload it here directly.

monitors.txt
is this correct?

Yep, your problem is right there, maybe you missclicked on "monitor" instead of "get all" or "get this page" at one time.
Your first two monitors are the same, set to download everything from multiple boards. The two others are the same too and set to download all of a tagged content.
What you have to do is to go in the "Monitors" tabs, right click on the one you don't want, likely the two empty first, and on the one if not both of the tagged ones, and click on "remove" (with the minus sign)

Oh wow, what a simple fix! I didn't realize that's what "monitor" did. Thank you so much for your help!


UI bug

I have no idea on how to replicate this bug, I believe this is a rare occurrence.
I simply joined a game and this happened:
https://imgur.com/a/mtz9m
Buggy character set?

were all other ui texts fine?

i had forgot to check, my apologies, this is the only other piece of evidence that i have
https://imgur.com/a/Ft5lE

likely just a windows issue then, not the core scripts.


dimensions with the same label (not name) get auto-linked axes in layout

Dimensions with different names but the same label; e.g. ('x_frequency', 'Frequency') and ('y_frequency', 'Frequency') should not automatically get linked axes in a layout.  In addressing #1776, I have found that in order to prevent automatic linking, I need to give different label names as well.

This was fixed in 1.11.0


not working correctly in createNamedWrapperReducer

here: https://redux.js.org/recipes/structuring-reducers/reusing-reducer-logic
function counter(state = 0, action) {
    switch (action.type) {
        case 'INCREMENT':
            return state + 1;
        case 'DECREMENT':
            return state - 1;
        default:
            return state;
    }
}

function createNamedWrapperReducer(reducerFunction, reducerName) {
    return (state, action) => {
        const {name} = action;
        const isInitializationCall = state === undefined;
 // so in initialization, it would return initial state. But after counterA, counterB, counterC
//initialized with a value, 0 or above, this if will return false (which should be true) when it's not
//the same reducerName because the state is not undefined now but it uses '&&'.
// In consequence, counterA, B, C would change at the same time.
        if(name !== reducerName && !isInitializationCall) return state;

        return reducerFunction(state, action);
    }
}

const rootReducer = combineReducers({
    counterA : createNamedWrapperReducer(counter, 'A'),
    counterB : createNamedWrapperReducer(counter, 'B'),
    counterC : createNamedWrapperReducer(counter, 'C'),
});

the problem exists in the createNamedWrapperReducer as described in comment.

This higher order reducer invokes counter only in the initializing stage or when name is matching reducerName.
Not sure if I understand your issue correctly.

When name is not matching reducerName, the reducerFunction still get called, which is not correct

When name is not matching reducerName, the reducerFunction still get called, which is not correct

That indicates !isInitializationCall is false, so isInitializationCall should be true.
if (name === reducerName || isInitializationCall) return reducerFunction(state, action)
return state

Above snippet is a equivalent with different conditional constructs, does it make it clear?

@theJian thx. I think I looked wrongly on !isInitializationCall in the origin snippet.


Fix deprecated functions, drop...

...compatibility with old settings method.
Also uses mod.conf for description, and deletes deprecated description.txt.

LGTM. Will merge in a few days unless there are objections (remind me if I forgot).

I'll remind you in a week (or perhaps 5 days).

@SmallJoker, ping.


Extract localization

Steps:

Run the po-extractor tool
Use the auto translation tool to get "good enough" translations
add translations to source

Make this a github action


[DOCFIX] Typo fix

@aaudiber
This PR fixes a typo.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17014/
Test PASSed.


clj-kondo: 2019.11.03 -> 2019.11.07

Motivation for this change
Update clj-kondo
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

LGTM!
cc: @FRidh, @worldofpeace (I hope this is okay due to busy state)

Yep, merging is pretty normal for me even when I'm busy :+1:


Add unittests w/more complex branch types

working on it at https://github.com/PerilousApricot/spark-ttree/tree/feature/better-nesting

Done


Switch to whisper base.en

Description

Updated the Whisper model used in voice processing from tiny.en to base.en for potentially improved performance or features.

Changes walkthrough
Relevant filesEnhancement

voice.pySwitch Whisper model to base.en

openduck-py/openduck_py/routers/voice.py

Changed the Whisper model from tiny.en to base.en.

+1/-1

💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

CI/CD baby!


EnumSeries for categorical data

Just like we have special optimized Series for primitives, let's create one for Enums:
enum X {a, b, c}

// regular series; no optimization
Series<X> s1 = Series.forData(X.a, X.b, X.c);

// optimized enum series
Series<X> s2 = Series.forEnums(X.a, X.b, X.c);

Other than how they are created, EnumSeries have no special API compared to regular object Series.

Upon a closer look, there's no benefit to specialized EnumSeries implemented over IntSeries. Both memory use and the speed of a few operations tested so far is the same between EnumSeries and Series


[Feature] Call Array.wrap on .in arguments

Syntactic sugar: It would be nice if this worked...
relation.where{position.in(1, 2)}
instead of having to do...
relation.where{position.in([1, 2])}
Yeah, Squeel makes me spoiled enough to ask for this.

I hear ya -- I like the consistency of passing in exactly what's going to go through to ARel, however.


Document how to download your own data

We currently have jupyter-tree-download
installed. This should be more prominent & documented, so users can download their
own data easily.

Nice - will add these do the pilot docs 👍
I added https://2i2c.org/pilot/about.html#what-happens-if-i-want-to-move-off-of-a-2i2c-hub yesterday but it is super barebones so will be helpful to add content like this

Thanks, @choldgraf :)

closed in https://github.com/2i2c-org/pilot/commit/5a9ab469d87aeb5704de7e6379d7a650ca3c7625


add github actions builds

related: https://github.com/AdoptOpenJDK/build-jdk
FYI @sophia-guo

can be seen to be working in https://github.com/gdams/openjdk-build/pull/2

Looks great. What about Windows? What's the objective of the PR? Making some PR testing builds on our infra obsolete, getting more coverage?

Looks great. What about Windows? What's the objective of the PR? Making some PR testing builds on our infra obsolete, getting more coverage?

Windows will come next. I need to work out the build environment first. The objective is to allow us to rely less heavily on the already heavily overloaded PR tester. Most build script changes can be tested with github actions.


character position on map wont change on 900 km/h

Thanks for the info but why would you move that fast!?

I just started a few bots for test purposes and found this issue. I just wanted to post this here, because it is hillarious.
BTW best way to get banned within minutes.

Ahah obviously :D
I didn't close this issue on purpose since it's indeed a bug.

Niantic won't unbann me, even tho i told them I was on a jet race through central park.


Incorrectly prompts for overwrite when re-labeling thumbnails

Clearly I introduced a bug in #428 :-(

resolved in 4.0.67


[WIP] Remaining simple operations

Codecov Report

Merging #54 into main will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           24        24
  Lines          935       939    +4
  Branches       137       137
=========================================
+ Hits           935       939    +4

Impacted Files
Coverage Δ

dask_sql/physical/rex/core/call.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429e823...610bf33. Read the comment docs.

Codecov Report

Merging #54 into main will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           31        31
  Lines         1187      1233   +46
  Branches       156       171   +15
=========================================
+ Hits          1187      1233   +46

Impacted Files
Coverage Δ

dask_sql/physical/rex/core/call.py
100.00% <100.00%> (ø)

dask_sql/utils.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5621a95...dcf6a53. Read the comment docs.


where is the function to unsubscribe from the watch?

Hi @roysG
Calling the RNLocation.subscribeToLocationUpdates method returns a function which, when called, will unsubscribe from location updates.
For example:
const unsubscribe = RNLocation.subscribeToLocationUpdates(locations => {
  // Do something with the locations
});

// Later on, call the returned `unsubscribe` method to stop receiving location updates
unsubscribe();

Ok thanks
On Mon, 18 Feb 2019, 11:20 Matt Oakes<EMAIL_ADDRESS>wrote:

Closed #45 https://github.com/timfpark/react-native-location/issues/45.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/timfpark/react-native-location/issues/45#event-2145677588,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG-RuhY0Hq3YwWoUIppfPy6FLa43l5Flks5vOnBsgaJpZM4bAQSv
.


replace simulate/call with gas estimate in writeContract/sendTransaction

I tried this in https://github.com/latticexyz/mud/pull/1717/commits/97fd6d792ad5a87aad47de30a54bd946730def61 but got caught up with weird error handling (the resulting error object didn't inherit from EstimateGasExecutionError even though constructor.name === "EstimateGasExecutionError" 🙈  Not sure if this is an issue on our end or viem's end but needs more digging and already spent a couple hours trying to figure it out and didn't make progress.

no longer relevant as we're using more of viem internals for this now


ZAP request without relays tags

I just received a zap originating from Amethyst 0.17.9, and couldn't send the zap note because there were no relays mentioned. I think this should not happen, following NIP-57 spec.
Unfortunately couldn't reproduce this a second time.

Hum... looks like the only way this could have happened is when the user has an actual Nostr event with empty relays. Literally "{}" in the contents of a kind 3 event.
I will make a fix for those cases.


get all features with fixme tags

Keys with FIXME and fixme indicate something should be fixed or need further attention.

this was happened! close here!


414 URI Too long on woopra calls

Seems all calls, even on subpages where referrer technically shouldn't contain the Token, to woopra somehow contain the token.
Could be history URL API is not called on inpage url change?

I'm pretty sure it's called, as that is how angular is manipulating the URL. The key to this is to get the referrer changed I think.

@aslakknutsen going to need a video or a reproduction instruction, as I don't see this trying either way of logging in.

Seems to be gone after cleaning Local Storage


Removing references to graph search API

Removing references to graph search API as it has been completely decommissioned

@DarrinEide : Thanks for your contribution! The author, @darrine, has been notified to review your proposed change.

@DarrinEide I'm merging this PR now. In the future, please make updates through the private repository so the updates can be staged and validated by the current validation rules. Read about authors working in the public repo for more information. Thank you.

Sorry about that Tami, and thank you for pointing me the right direction.
I have a few more changes that need to be made which I’ll do in the private repo as you suggested.
Thanks,
-Darrin
From: Tami Fosmark<EMAIL_ADDRESS>Sent: Tuesday, October 30, 2018 9:51 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Darrin Eide<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Removing references to graph search API (#17927)
@DarrinEidehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDarrinEide&data=02|01|darrine%40microsoft.com|e7dccae07e3440ffc90008d63e87e25a|72f988bf86f141af91ab2d7cd011db47|1|0|636765150671395248&sdata=OluMQr%2BzzE8LpmASwyiLbhbafPvxW%2Bhx6Si6SosbBHk%3D&reserved=0 I'm merging this PR now. In the future, please make updates through the private repository so the updates can be staged and validated by the current validation rules. Read about authors working in the public repohttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.docs.microsoft.com%2Fen-us%2Fhelp%2Fcontribute%2Fcontribute-authors-in-public-repo%3Fbranch%3Dmaster&data=02|01|darrine%40microsoft.com|e7dccae07e3440ffc90008d63e87e25a|72f988bf86f141af91ab2d7cd011db47|1|0|636765150671395248&sdata=cpTyNTLoLgcM7idCHeId58KAeUoAxlWqP1XH7QVsdLQ%3D&reserved=0 for more information. Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fpull%2F17927%23issuecomment-434379664&data=02|01|darrine%40microsoft.com|e7dccae07e3440ffc90008d63e87e25a|72f988bf86f141af91ab2d7cd011db47|1|0|636765150671405265&sdata=B0Ngwdril98RzFm%2FJqvalw2qF7tkPvFZyD4%2BtzbLgNI%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVK1WC0OmUQGc-DoOtgo2EDc6eF87IcBks5uqIN4gaJpZM4YCWZB&data=02|01|darrine%40microsoft.com|e7dccae07e3440ffc90008d63e87e25a|72f988bf86f141af91ab2d7cd011db47|1|0|636765150671405265&sdata=h4G1nzmm90x0IwQgHFffxCvV1SVXWnqWj7d83QjVuCg%3D&reserved=0.


WIP: Enable sharepoint cli

Description

Does this PR need a docs update or release note?

[ ] :white_check_mark: Yes, it's included
[x] :clock1: Yes, but in a later PR
[ ] :no_entry: No

Type of change

[x] :sunflower: Feature
[ ] :bug: Bugfix
[ ] :world_map: Documentation
[ ] :robot: Test
[ ] :computer: CI/Deployment
[ ] :broom: Tech Debt/Cleanup

Issue(s)

#

Test Plan

[ ] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

On local branch:
./corso backup create sharepoint --site <siteID> --data pages
Connecting to repository:      6s done
Connecting to M365:      0s done
Discovering items to backup:      0s done
∙ pages - <siteId>:         done
Backing up data:      0s done
  Started At            ID                                    Status              Resource Owner
  2023-01-21T00:01:08Z  <backupID>     No Data (0 errors)  <siteID>