YouTube block enhancements

This is significant update to the YouTube block, whilst not effecting already placed blocks:

The Flash/object embed method has been removed, as it was deprecated January 2015. The iframe method uses Flash when it needs to anyway.
The title field has been removed from the block interface as it wasn't being used anywhere (it remains in the block table/xml)
By default, the block is now to set to output 16:9 videos, with responsive embedding. A responsive 4:3 option is provided, as well as a fixed size. Existing blocks will have a width and height stored, so will continue to output at the previously defined sizing until changed. This makes the block directly compatible with the Elemental theme and removes the need for responsive scripts like fitvits.js. The goal was to make it so that someone only needs to cut and paste a youtube video url, and not have to think about sizing at all.
Now supports playlist URLs (e.g. https://www.youtube.com/playlist?list=PLC9B0FEBD6041328A), as well as comma separated lists of video IDs (which creates custom playlists).
Most iframe configuration values are now exposed as options, with sensible defaults. Options like hiding related videos, or hiding annotations can now be done directly on the block.
Language of iframe embed is set to the same language as the site itself
Unnecessary code from the block's controller has been removed. The view.php file has been made as clean as possible, so that further customisations can be made fairly easily.

We should probably consider keeping title around in the event that someone was using this in a custom block template?

+1

Good point Joe, I did consider the title field, a little tricky I reckon.
My thinking was that its inclusion only adds confusion, especially to newcomers to concrete5 because of its non use. "I put in a title, but it's not appearing anywhere". I really like the idea of someone being able to just paste in the youtube URL only, and it just works.
Whereas if someone has used it already in a custom template, it's a 30 second job to provide an override for the block editing screen to include that input field.
I'm thinking it's probably a rare scenario that someone would have done such a customisation, but if someone has they are also likely savvy enough to know that they can drop in an override to continue editing the field. A slight annoyance, but not hard to resolve.
That was my thinking anyway!

I went around and around on this. It is tricky.
I think we ought to kill the title field as you've done here, and add a note in the release notes about this as a backwards compatibility issue.

FYI: this pull request doesn't include an upgrade script, so I will add block type refresh to the existing upgrade script – otherwise this will break on updated sites.

Thanks, this is really nice.


math doesn't make sense for monitor positioning with variable size displays and varying scales including fractional scaling

Already reported ? *

[X] I have searched the existing open and closed issues.

Regression?
No
System Info and Version
 System/Version info
Hyprland, built from branch build-alpine at commit 4520b30d498daca8079365bdb909a8dea38e8d55 dirty (with patches:).
Date:
Tag: v0.44.1, commits:
built against aquamarine 0.4.2

flags: (if any)

System Information:
System name: Linux
Node name: tor-dev-01
Release: 6.6.58-1-lts
Version: #2-Alpine SMP PREEMPT_DYNAMIC 2024-10-23 16:48:22

GPU information:
00:02.0 VGA compatible controller [0300]: Intel Corporation CometLake-U GT2 [UHD Graphics] [8086:9b41] (rev 02) (prog-if 00 [VGA controller])

os-release: NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.21.0_alpha20240923
PRETTY_NAME="Alpine Linux edge"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://gitlab.alpinelinux.org/alpine/aports/-/issues"

plugins:

======Config-Start======

################
### MONITORS ###
################

# See https://wiki.hyprland.org/Configuring/Monitors/
# monitor = name, resolution, position, scale
# recommended rule for random monitor hot-plug: monitor = , preferred, auto, 1
monitor = eDP-1, 2560x1440@60, 0x0, 2
monitor = HDMI-A-1, 3840x2160@30, 0x-1730, 1.25

Description
I am not sure if what I am noticing is an indication of bad math in Hyprland, or lack of understanding the documentation on my end.
The documentation states:
Monitors are positioned on a virtual “layout”.
The position is the position, in pixels, of said display in the layout.
(calculated from the top-left corner)

I want to place display HDMI-A-1 above eDP-1. Based on the documentation stating that measurements are made from top-left corners with inverse y Cartesian axis, I would first assume that both my monitors top left corners are (0,0).
I then move my second display above the (0,0) of the first display by multiplying 2160 * 1.25, and setting the position as 0x-2700. This is very wrong.
Through trial and error the actual value should be 0x-1730. The closest I get to this is (1440 + (2880-2700) + 90)=1710 which makes no sense and uses redundant values that I shouldn't use.
The only thing I can think of is that either you are actually measuring from the center, or the scaling of the primary monitor does not maintain the (0,0) at the top left corner of said monitor.
If I correct for this, and do 2700 + or - (1440/2) for a position of 0x-3420 or 0x-1980, that is also incorrect.
If I instead decide to do math based on the (0,0) position as the center of the monitors, instead of the top left: Height after scaling for monitor A is 2880, height after scaling for monitor B is 2700, so I need to move B 2700 + difference of one side which is 90. 0x-2790 also doesn't work.
If someone could please point me to where in the code the math is done, that would be appreciated.
How to reproduce
Try to position monitors with fractional scaling for varying scales.
Crash reports, logs, images, videos
No response

multiplying 2160 * 1.25

dividing... 2160 / 1.25
assuming both are 4K (2160p?) and 1.25 scale:
top monitor: 0,0
bottom monitor: 0,2160/1.25

fwiw try wdisplays for a graphical tool to do this

I just wanted to understand the math. Because it doesn't seem to make sense which may mean problems for development in future.
The working value is 0x-1730, so none of this math adds up.

In my mind an anchor of (0, 0) stays at same point on primary display even after scaling. It shouldn't be too complex if that is the case. Just a matter of defining primary display which I don't see an option for?

fwiw try wdisplays for a graphical tool to do this

I like it in config, this doesn't change for me. Will definitely look into though, ty for tip. And loving hyprland so far!

position is top left of the display
its logical size is (pixel res / scale)
thats about it, you're just positioning rectangles

position is top left of the display
its logical size is (pixel res / scale)
thats about it, you're just positioning rectangles

Exactly, that's why it is weird that the math doesn't work. Multiplying or dividing scale, or measuring from center.
I am pretty confident in my abilities with this type of math haha.
Assuming both displays start with top left corners at same position that math would mean a translation of  about 3000px up, so 0x-3000. But i get 0x-1730 as working value. That is also why I tried to do math based on a detached origin, or from center.
Not worth worrying much about, I created this more so out of concern in case something may be fishy.

@vaxerski math error was on my end. Thanks for help here


issue with tree-sitter

Hi,
When I try to start bash-language-server in command line, I have the following error:
/usr/lib/bash-language-server/node_modules/tree-sitter/index.js:8
    throw e;
    ^

Error: The module '/usr/lib/bash-language-server/node_modules/tree-sitter/build/Release/tree_sitter_runtime_binding.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 67. This version of Node.js requires
NODE_MODULE_VERSION 57. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).
    at Object.Module._extensions..node (module.js:682:18)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/usr/lib/bash-language-server/node_modules/tree-sitter/index.js:3:13)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)

As they advise, in /usr/lib/bash-language-server/node_modules/tree-sitter I've executed npm install and npm rebuild without more result.
I've tested with node js lts version 8.13.0.
Thanks in advance :-)

Probably, it's the same issue that https://github.com/mads-hartmann/bash-language-server/issues/93.
I'm also with Arch Linux.

See https://github.com/mads-hartmann/bash-language-server/issues/93#issuecomment-442455951


Unit tests for validators

At the moment tests are written via Traces module.
it is looks more like integration tests approach, we run wallet code, which starts validators, and after that we test system state changes.
Issue is that we can not test validators in isolation. If my wallet code do some validation that duplicate validator checks - there is no way to ensure that validator checks are actually works as expected. (e.g if we expect price parameter to be greater than 0 in a wallet and in a validator, our unit test will cover only wallet part, there is no way to test validator check)
Ideally we should be able to test validator in isolation. Maybe api should provide some api to mock and test validator code.

On-and off-chain code can use the same functions, and you can unit-test those with any Haskell unit-testing framework like hunit.
Could you give a clearer example of a function that you would find it hard test?

I have wallet endpoint to set item on sell, it has price validation
sell ::
HasBlockchainActions s
-> SellParams
-> Contract w s Text Text
sell market SellParams{..} = do
when (spSellPrice <= 0) $ throwError "sell price should be greater than zero"
I have the same validation in the validator
traceIfFalse "price should be grater 0" (sellPrice outDatum > 0)
With provided test framework, I am not able to test Validato, as soon as I provide price with 0 value, it will fail in Contract, and can be asserted with assertContractError.
But I can not assert that with assertFailedTransaction, as it always fail in Contract monad.
It is feature of the Plutus, that we can do validation before submit to save fees on failed transaction, but we still need to ensure that Validator works as expected.
Would be good to have some samples of hunit in the uses cases, which covers Validator tests in isolation.

Basically you will have to build a ScriptContext  object and then and pass it to the validator. On the most basic level you will have to set all the inputs, outputs, signatures and  forge, other parameters are mostly ignored. and then call your validator with that ScriptContext object.
I've written a simple implementation for it.  The main function that executes the validator has following signature
executeContext :: (Data->Data->ScriptContext ->Bool)->TestContextBuilder-> POSIXTimeRange ->Value ->Bool
executeContext validatorFunction (TestContextBuilder cInputs cOutputs signatures) timeRange forge= ...

Relavent files:

VallidatorTestFramework.hs
Usage Example

I hope something like this will be include in the plutus test library

@mesudip thank you for jumping in and providing a workaround.
All the testing machinery has moved to the plutus-apps repo developed by the Plutus Tools team. I asked them a few days ago if they wanted to provide the functionality requested in this ticket and they didn't.
The requested functionality does sound useful to me, but I don't see any option regarding how to move this ticket forward, so I'm going to close it as "won't do" unfortunately.


clean up stale branches

Maybe there's a tool for this already but we should figure out how to delete all the branches from merged PRs to clean up the list of branches in the repo and the cost of cloning/pulling down the fresh codebase.

Looks like there is a GitHub setting https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-the-automatic-deletion-of-branches

Enabled! Would still like to clean up old ones.

Done!


Fix proj4.js not found

Version 1.1.0 fails loading proj4.js with the following error:
Failed to load resource: the server responded with a status of 404 ()

This is caused by a change in newer versions of grunt-contrib-bower that makes proj4.js being excluded from the packaged widget. This PR fixes it by adding a copy: true option on the bower task.

Coverage remained the same at 99.205% when pulling 1a3de092ddbaa67c263eb099c5a1ec0b1d274a5d on aarranz:fix/proj4js-not-found into a105f745900cdc3bc8d33ee682fe282b0b36f389 on Wirecloud:develop.


Ensure Email is required by register

Summary
Ensure email is marked required when regitering
Before Merge

[ ] Ensure you've rebuilt the docs with npm run build:docs

After Merge

[ ] Does this change invalidate any docs or tutorials? If so ensure the changes needed are either made or recorded
[ ] Does this change require a release to be made? Is so please create and deploy the release
[ ]

Haha... So glad you still include that reference. It's ok I've done similar with fast and loose gif approvals.


port over certdb

https://github.com/subfinder/subfinder/tree/master/libsubfinder/sources/certdb

Just wanted to document a super weird thing that happened to me:
$ nslookup certdb.com

** server can't find certdb.com: NXDOMAIN

After a little bit it has started working again.


feat: when html theme changes, mermaid theme updates accordingly

Closes #4
The proposed pull request offers the following changes:

Use a MutationObserver to watch for changes to html.data-theme to update mermaid config accordingly
Uses the mermaid api's render function, since it is the recommended way for integrating mermaid in a webpage (see: docs)

Thanks for your work in developing this. I really like mermaid and can't imagine not being able to use it in Docusaurus.
Example:

I refresh the page a number of times in the gif - seen when the page turns white.

Thanks for the review Sam! I've addressed some of the concerns :) . I'd like to improve the test coverage and double check everything. I'll do that tomorrow

Thanks for the review Sam! I've addressed some of the concerns :) . I'd like to improve the test coverage and double check everything. I'll do that tomorrow

All done. Added some more tests in https://github.com/sjwall/mdx-mermaid/pull/21/commits/d527a1684e45e922d4955a37397f7fa81bb020bc

Codecov Report

Merging #21 (980d704) into main (3d6784c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         3    +1
  Lines           41        69   +28
  Branches         7        15    +8
=========================================
+ Hits            41        69   +28

Impacted Files
Coverage Δ

src/Mermaid.tsx
100.00% <100.00%> (ø)

src/theme.helper.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d6784c...980d704. Read the comment docs.

Thank you for the PR, it has been released in v1.2.0


Change license header

replaced by #107 . That also configures the https://github.com/CadixDev/licenser plugin for checking licenses in CI.


Browse Page: Curate filter by maxEffectiveScore and maxToolScore

Fixes #501
Needs https://github.com/clearlydefined/service/pull/439 to be merged

superceded by #564


Download loras in python

pget is bad for small files. this tries to reuse connections across different downloads and not touch disk, changing exllama to accept io.BytesIO instead of paths and unzipping in memory.
the retry logic and error reporting is not quite perfect

most recent
https://replicate.com/replicate-internal/staging-llama-2-7b/versions/24563f3501393c944fc85bb52414cdc15be0035eb36d962badfae9ef2d14d874
https://replicate.com/replicate-internal/staging-llama-2-70b/versions/92b5437c84d63fb029e071034726859de691c26c099ad4d1a0b4c95353dd904f
needs to be tested some more with recently-completed trainings that might not be synced to coreweave, and maybe whatever was going on with storagebouncer timeouts, but otherwise should be good to go in
also needs to be timed for 70b downloads


nerdctl run -v fails with bind mount if the host folder doesn't exist

Description
# folder not exist
➜  compenv ls /tmp/nerdctl/non-exist-folder
ls: cannot access /tmp/nerdctl/non-exist-folder: No such file or directory
# nerdctl run fails
➜  compenv sudo nerdctl run -v=/tmp/nerdctl/non-exist-folder:/var/lib/random-folder alpine
FATA[0000] failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error mounting "/tmp/nerdctl/non-exist-folder" to rootfs at "/var/lib/random-folder": stat /tmp/nerdctl/non-exist-folder: no such file or directory: unknown
# create the folder
➜  compenv mkdir -p /tmp/nerdctl/non-exist-folder
# nerdctl run succeeds
➜  compenv sudo nerdctl run -v=/tmp/nerdctl/non-exist-folder:/var/lib/random-folder alpine

Steps to reproduce the issue
No response
Describe the results you received and expected
nerdctl creates the folder in host if not exist, and nerdctl run succeeds with expected bind mount.
What version of nerdctl are you using?
main
Are you using a variant of nerdctl? (e.g., Rancher Desktop)
None
Host information
No response

Fun fact: While -v /tmp/nerdctl/non-exist-folder:/var/lib/random-folder must create the src dir, --mount type=bind,src=/tmp/nerdctl/non-exist-folder,target=/var/lib/random-folder must NOT create the src dir


[Question] Flatpak version

Hi,
You are planned create a flatpak version?

Hi @Gandalf888 . Never heard of Flatpak before. I will look it up and see if it is something I can work on.

flatpak? what is that?

@FaisalUmair @apalm1341
More informations.
https://flatpak.org/
https://en.wikipedia.org/wiki/Flatpak
https://flathub.org/apps
http://docs.flatpak.org/en/latest/


Forcing IPv6 does not work

My domain has a A and a AAAA record but the challenge MUST use the AAAA because i can't control port 80 on IPv4 only on IPv6 because of my dual stack light. I can't remove the A record from the domain either because I need it to reach my home server from IPv4 only hosts (through a different port then). I used the --ipv6 flag (in addition to setting is in the config file) but it still prefers the IPv6 address:
dehydrated -c --ipv6
ERROR: Challenge is invalid! (returned: invalid) (result: {
  "type": "http-01",
  "status": "invalid",
  "error": {
    "type": "urn:acme:error:connection",
    "detail": "Could not connect to theissen.io",
    "status": 400
  },
  "uri": "https://acme-v01.api.letsencrypt.org/acme/challenge/_FUguK9WeyuwunmYAAihYXUwOF8Xr_2aMrxCX05e_Ng/350426455",
  "token": "",
  "keyAuthorization": "",
  "validationRecord": [
    {
      "url": "http://theissen.io/.well-known/acme-challenge/qdTdN0VnAd2_1QQjyGmNGzph5OPJx3s89IGonUj0n2U",
      "hostname": "theissen.io",
      "port": "80",
      "addressesResolved": [
        "<IP_ADDRESS>",
        "2a00:61e0:41f6:6a01:de:88ff:fe22:4e00"
      ],
      "addressUsed": "<IP_ADDRESS>"
    }
  ]
})

This is my config
# Resolve names to addresses of IP version only. (curl)
# supported values: 4, 6
# default: <unset>
IP_VERSION=6

# Path to certificate authority (default: https://acme-v01.api.letsencrypt.org/directory)
#CA="https://acme-v01.api.letsencrypt.org/directory"
#CA="https://acme-staging.api.letsencrypt.org/directory"

# Which challenge should be used? Currently http-01 and dns-01 are supported
CHALLENGETYPE="http-01"

# Base directory for account key, generated certificates and list of domains (default: $SCRIPTDIR -- uses config directory if undefined)
#BASEDIR=$SCRIPTDIR

# File containing the list of domains to request certificates for (default: $BASEDIR/domains.txt)
DOMAINS_TXT="${BASEDIR}/domains.txt"

# Output directory for generated certificates
CERTDIR="/usr/local/etc/ssl/dehydrated"

# Directory for account keys and registration information
ACCOUNTDIR="${BASEDIR}/accounts"

# Output directory for challenge-tokens to be served by webserver or deployed in HOOK (default: /usr/local/www/dehydrated)
WELLKNOWN="/var/www/letsencrypt"

# Default keysize for private keys (default: 4096)
KEYSIZE="4096"

# Path to openssl config file (default: <unset> - tries to figure out system default)
#OPENSSL_CNF=

# Program or function called in certain situations
#
# After generating the challenge-response, or after failed challenge (in this case altname is empty)
# Given arguments: clean_challenge|deploy_challenge altname token-filename token-content
#
# After successfully signing certificate
# Given arguments: deploy_cert domain path/to/privkey.pem path/to/cert.pem path/to/fullchain.pem
#
# BASEDIR and WELLKNOWN variables are exported and can be used in an external program
# default: <unset>
#HOOK=

# Chain clean_challenge|deploy_challenge arguments together into one hook call per certificate (default: no)
HOOK_CHAIN="no"

# Minimum days before expiration to automatically renew certificate (default: 30)
RENEW_DAYS="30"

# Regenerate private keys instead of just signing new certificates on renewal (default: yes)
PRIVATE_KEY_RENEW="yes"

# Which public key algorithm should be used? Supported: rsa, prime256v1 and secp384r1
KEY_ALGO=rsa

# E-mail to use during the registration (default: <unset>)
<EMAIL_ADDRESS>
# Lockfile location, to prevent concurrent access (default: $BASEDIR/lock)
LOCKFILE="${BASEDIR}/lock"

# Option to add CSR-flag indicating OCSP stapling to be mandatory (default: no)
OCSP_MUST_STAPLE="yes"

The "--ipv6" parameter is for forcing how the dehydrated script is accessing the Let's Encrypt servers, not the other way around.
In the latest ACME draft (draft-ietf-acme-acme-04)  I find only this:

As a domain may resolve to multiple IPv4 and IPv6 addresses, the server will connect to at least one of the hosts found in A and AAAA records, at its discretion.

So, I believe that there is no solution for this scenario at the moment.

That is correct. LE can choose any A or AAAA record at will; you cannot tell it to use only the AAAA record. If using the http-01 challenge method, you must (in effect) have the challenges reachable on every server process for which either an A or AAAA record exists.
For your use case, using the dns-01 challenge type might be a better solution. If you have a supported DNS provider, you might look into using lexicon; otherwise a semi-automatic solution like email-notify might at least get the job done.

Yea snap I guess we can close this. I was looking into DNS. Got other problems with this :( See #308  #309


Skip freetype build and bundling on Linux

Freetype itself has various dependencies on external libraries,
some of which are not present on certain Linux distros.
Better to use the system's freetype library, so the user can handle
their own affairs, reducing the risk of issues (e.g. segmentation
faults on Fedora 28 while starting Eclipse).
Signed-off-by: Adam Farley<EMAIL_ADDRESS>

Thanks.
Can I get a functional test in https://github.com/AdoptOpenJDK/openjdk-tests or (wherever @smlambert deems it appropriate) that ensures that the Freetype library isn't part of the JDK we ship on Linux but present on Windows probably macOS? I'm unsure about AIX.

Here's some basic testing for Linux x86-64 to ensure we haven't broken anything vital.
https://ci.adoptopenjdk.net/view/work-in-progress/job/adamf-linux-hotspot-build/8/
@aahlenst - To address your points:

Test? Sure thing. Will work that once Shelley has determined where such a test should go.
AIX? No, we don't bundle freetype there. I know that because we use the --skip-freetype option in the aix platform script much in the same way I did.
Build farm but not locally? Correct, As mentioned above,m the aix platform script does it this way. It's why I assumed that was the correct way to prevent freetype bundling.

run tests


ScaledObject ignoring triggers sometimes

Report
i have configured ScaledObject configuration to scale Statefulset based on pubsub metrics.
this is the configuration im using:
apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  name: mysvc-scaledobject
  namespace: utils
spec:
  scaleTargetRef:
    name: mysvc
    kind: StatefulSet
  minReplicaCount: 3
  maxReplicaCount: 3
  triggers:
  - type: gcp-pubsub
    authenticationRef:
      name: mysvc-auth-gcp-credentials
    metadata:
      mode: "SubscriptionSize"
      value: "3"
      subscriptionName: "projects/myproj/subscriptions/mysubscription1"
  - type: gcp-pubsub
    authenticationRef:
      name: mysvc-auth-gcp-credentials
    metadata:
      mode: "SubscriptionSize"
      value: "1"
      subscriptionName: "projects/myproj/subscriptions/mysubscription2"
---
apiVersion: keda.sh/v1alpha1
kind: TriggerAuthentication
metadata:
  name: mysvc-auth-gcp-credentials
  namespace: utils
spec:
  podIdentity:
    provider: gcp

deployed on one Env worked OK, deploying it on Env2 it seems to ignore my triggeres configuration and defined the scale based on cpu.
Expected Behavior
I should see the HPA with the pubsub metrics.
kubectl get hpa -n utils
keda-hpa-mysvc-scaledobject   StatefulSet/mysvc         0/3 (avg), 0/1 (avg)   3         3         3          31m

kubectl get scaledobject mysvc-scaledobject -o yaml -n utils
apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  annotations:
    meta.helm.sh/release-name: mysvc
    meta.helm.sh/release-namespace: utils
  creationTimestamp: "2022-01-27T14:22:47Z"
  finalizers:
  - finalizer.keda.sh
  generation: 1
  labels:
    app.kubernetes.io/managed-by: Helm
    scaledobject.keda.sh/name: mysvc-scaledobject
  name: mysvc-scaledobject
  namespace: utils
  selfLink: /apis/keda.sh/v1alpha1/namespaces/utils/scaledobjects/mysvc-scaledobject
spec:
  maxReplicaCount: 3
  minReplicaCount: 3
  scaleTargetRef:
    kind: StatefulSet
    name: mysvc
  triggers:
  - authenticationRef:
      name: mysvc-auth-gcp-credentials
    metadata:
      mode: SubscriptionSize
      subscriptionName: projects/myproj/subscriptions/mysubscription2
      value: "3"
    type: gcp-pubsub
  - authenticationRef:
      name: mysvc-auth-gcp-credentials
    metadata:
      mode: SubscriptionSize
      subscriptionName: projects/myproj/subscriptions/mysubscription2
      value: "1"
    type: gcp-pubsub
status:
  conditions:
  - message: ScaledObject is defined correctly and is ready for scaling
    reason: ScaledObjectReady
    status: "True"
    type: Ready
  - message: Scaling is not performed because triggers are not active
    reason: ScalerNotActive
    status: "False"
    type: Active
  - message: No fallbacks are active on this scaled object
    reason: NoFallbackFound
    status: "False"
    type: Fallback
  externalMetricNames:
  - s0-gcp-ps-projects-myproj-subscriptions-mysubscription1
  - s1-gcp-ps-projects-myproj-subscriptions-mysubscription2
  health:
    s0-gcp-ps-projects-myproj-subscriptions-mysubscription1:
      numberOfFailures: 0
      status: Happy
    s1-gcp-ps-projects-myproj-subscriptions-mysubscription2:
      numberOfFailures: 0
      status: Happy
  originalReplicaCount: 3
  scaleTargetGVKR:
    group: apps
    kind: StatefulSet
    resource: statefulsets
    version: v1
  scaleTargetKind: apps/v1.StatefulSet

Actual Behavior
kubectl get hpa -n utils
keda-hpa-mysvc-scaledobject   StatefulSet/mysvc          0%/80%    3         3         3          15m
kubectl get scaledobject mysvc-scaledobject -n utils -o yaml
apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  annotations:
    meta.helm.sh/release-name: mysvc
    meta.helm.sh/release-namespace: utils
  creationTimestamp: "2022-01-27T14:43:19Z"
  finalizers:
  - finalizer.keda.sh
  generation: 1
  labels:
    app.kubernetes.io/managed-by: Helm
    scaledobject.keda.sh/name: mysvc-scaledobject
  name: mysvc-scaledobject
  namespace: utils
  selfLink: /apis/keda.sh/v1alpha1/namespaces/utils/scaledobjects/mysvc-scaledobject
spec:
  maxReplicaCount: 3
  minReplicaCount: 3
  scaleTargetRef:
    kind: StatefulSet
    name: mysvc
  triggers:
  - authenticationRef:
      name: mysvc-auth-gcp-credentials
    metadata:
      mode: SubscriptionSize
      subscriptionName: projects/myproj/subscriptions/mysubscription1
      value: "3"
    type: gcp-pubsub
  - authenticationRef:
      name: mysvc-auth-gcp-credentials
    metadata:
      mode: SubscriptionSize
      subscriptionName: projects/myproj/subscriptions/mysubscription2
      value: "1"
    type: gcp-pubsub
status:
  conditions:
  - message: ScaledObject is defined correctly and is ready for scaling
    reason: ScaledObjectReady
    status: "True"
    type: Ready
  - message: Scaling is not performed because triggers are not active
    reason: ScalerNotActive
    status: "False"
    type: Active
  - status: Unknown
    type: Fallback
  originalReplicaCount: 3
  scaleTargetGVKR:
    group: apps
    kind: StatefulSet
    resource: statefulsets
    version: v1
  scaleTargetKind: apps/v1.StatefulSet

Steps to Reproduce the Problem

Logs from KEDA operator
2022-01-27T14:48:41.310Z	INFO	controller.scaledobject	Reconciling ScaledObject	{"reconciler group": "keda.sh", "reconciler kind": "ScaledObject", "name": "mysvc-scaledobject", "namespace": "utils"}
2022-01-27T14:48:41.325Z	INFO	controller.scaledobject	Updated HPA according to ScaledObject	{"reconciler group": "keda.sh", "reconciler kind": "ScaledObject", "name": "mysvc-scaledobject", "namespace": "utils", "HPA.Namespace": "utils", "HPA.Name": "keda-hpa-mysvc-scaledobject"}

KEDA Version
2.5.0
Kubernetes Version
1.19
Platform
No response
Scaler Details
PubSub
Anything else?
No response

hi @chenele
Is there any error in the logs? Could you try restarting keda pods (operator and metrics-server)? There is a known bug related with cache and restarting the pods solves it. If this is your case, next week we will release the v2.6 fixing this issue


Linking error on iOS

Env info:

Mac OS Sierra 10.12
Node v6.9.4
npm 3.10.10
react-native: 0.38.0
XCode 8.2.1

Error
CompileC /%project-directory%/ios/build/Build/Intermediates/RNVectorIcons.build/Debug-
iphonesimulator/RNVectorIcons.build/Objects-normal/x86_64/RNVectorIconsManager.o
RNVectorIconsManager/RNVectorIconsManager.m normal x86_64 objective-c
com.apple.compilers.llvm.clang.1_0.compiler

Description
I followed what your documentation says: at first I tried react-native link (which actually works well with Android), and discovered that the plist file and the font used by application section were alright. However, I had to manually add libRNVectorIcons.a to "Link Binary With Libraries". After all this steps, still no results at all. The same project can be built successfully on Android, an the iOS project did too until I added react-native-vector-icons. Please, I'm open to any suggestion. Also, thank you for your time spent developing this library.

Your error doesn't really look like an error, do you have any more info?

Give me a couple of minutes man, I'll show you the complete log

Found Xcode project example.xcodeproj
We couldn't boot your defined simulator due to an already booted simulator. We are limited to one simulator launched at a time.
Launching iPhone 6 (iOS 10.2)...
Building using "xcodebuild -project example.xcodeproj -scheme example -destination id=B4D81FA2-24AD-4549-BE33-952D413469F6 -derivedDataPath build"
User defaults from command line:
IDEDerivedDataPathOverride = /myproject/ios/build

=== BUILD TARGET RCTWebSocket OF PROJECT RCTWebSocket WITH CONFIGURATION Debug ===
Check dependencies
=== BUILD TARGET ReactNativeNavigation OF PROJECT ReactNativeNavigation WITH CONFIGURATION Debug ===
Check dependencies
=== BUILD TARGET RCTVibration OF PROJECT RCTVibration WITH CONFIGURATION Debug ===
Check dependencies
=== BUILD TARGET RNVectorIcons OF PROJECT RNVectorIcons WITH CONFIGURATION Debug ===
Check dependencies
CompileC /myproject/ios/build/Build/Intermediates/RNVectorIcons.build/Debug-iphonesimulator/RNVectorIcons.build/Objects-normal/x86_64/RNVectorIconsManager.o RNVectorIconsManager/RNVectorIconsManager.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
cd /myproject/node_modules/react-native-vector-icons
export LANG=en_US.US-ASCII
export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin"
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c -arch x86_64 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=gnu99 -fobjc-arc -fmodules -fmodules-cache-path=/myproject/ios/build/ModuleCache -fmodules-prune-interval=86400 -fmodules-prune-after=345600 -fbuild-session-file=/myproject/ios/build/ModuleCache/Session.modulevalidation -fmodules-validate-once-per-build-session -Wnon-modular-include-in-framework-module -Werror=non-modular-include-in-framework-module -Wno-trigraphs -fpascal-strings -O0 -fno-common -Wno-missing-field-initializers -Wno-missing-prototypes -Werror=return-type -Wunreachable-code -Wno-implicit-atomic-properties -Werror=deprecated-objc-isa-usage -Werror=objc-root-class -Wno-arc-repeated-use-of-weak -Wduplicate-method-match -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wconditional-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wshorten-64-to-32 -Wpointer-sign -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wundeclared-selector -Wno-deprecated-implementations -DDEBUG=1 -DOBJC_OLD_DISPATCH_PROTOTYPES=0 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator10.2.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -mios-simulator-version-min=7.0 -g -Wno-sign-conversion -Wno-infinite-recursion -fobjc-abi-version=2 -fobjc-legacy-dispatch -iquote /myproject/ios/build/Build/Intermediates/RNVectorIcons.build/Debug-iphonesimulator/RNVectorIcons.build/RNVectorIcons-generated-files.hmap -I/myproject/ios/build/Build/Intermediates/RNVectorIcons.build/Debug-iphonesimulator/RNVectorIcons.build/RNVectorIcons-own-target-headers.hmap -I/myproject/ios/build/Build/Intermediates/RNVectorIcons.build/Debug-iphonesimulator/RNVectorIcons.build/RNVectorIcons-all-target-headers.hmap -iquote /myproject/ios/build/Build/Intermediates/RNVectorIcons.build/Debug-iphonesimulator/RNVectorIcons.build/RNVectorIcons-project-headers.hmap -I/myproject/ios/build/Build/Products/Debug-iphonesimulator/include -I/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include -I/myproject/node_modules/react-native-vector-icons/../../React -I../react-native/React -I../react-native/React/Base -I../react-native/React/CSSLayout -I../react-native/React/Executors -I../react-native/React/Modules -I../react-native/React/Profiler -I../react-native/React/Views -I/myproject/node_modules/react-native-vector-icons/node_modules/react-native/React -I/myproject/ios/build/Build/Intermediates/RNVectorIcons.build/Debug-iphonesimulator/RNVectorIcons.build/DerivedSources/x86_64 -I/myproject/ios/build/Build/Intermediates/RNVectorIcons.build/Debug-iphonesimulator/RNVectorIcons.build/DerivedSources -F/myproject/ios/build/Build/Products/Debug-iphonesimulator -MMD -MT dependencies -MF /myproject/ios/build/Build/Intermediates/RNVectorIcons.build/Debug-iphonesimulator/RNVectorIcons.build/Objects-normal/x86_64/RNVectorIconsManager.d --serialize-diagnostics /myproject/ios/build/Build/Intermediates/RNVectorIcons.build/Debug-iphonesimulator/RNVectorIcons.build/Objects-normal/x86_64/RNVectorIconsManager.dia -c /myproject/node_modules/react-native-vector-icons/RNVectorIconsManager/RNVectorIconsManager.m -o /myproject/ios/build/Build/Intermediates/RNVectorIcons.build/Debug-iphonesimulator/RNVectorIcons.build/Objects-normal/x86_64/RNVectorIconsManager.o
In file included from /myproject/node_modules/react-native-vector-icons/RNVectorIconsManager/RNVectorIconsManager.m:9:
/myproject/node_modules/react-native-vector-icons/RNVectorIconsManager/RNVectorIconsManager.h:9:9: fatal error: 'React/RCTBridgeModule.h' file not found
#import <React/RCTBridgeModule.h>
^
1 error generated.
=== BUILD TARGET React OF PROJECT React WITH CONFIGURATION Debug ===
Check dependencies
=== BUILD TARGET RCTActionSheet OF PROJECT RCTActionSheet WITH CONFIGURATION Debug ===
Check dependencies
=== BUILD TARGET RCTLinking OF PROJECT RCTLinking WITH CONFIGURATION Debug ===
Check dependencies
=== BUILD TARGET RCTSettings OF PROJECT RCTSettings WITH CONFIGURATION Debug ===
Check dependencies
=== BUILD TARGET RCTGeolocation OF PROJECT RCTGeolocation WITH CONFIGURATION Debug ===
Check dependencies
=== BUILD TARGET RCTAnimation OF PROJECT RCTAnimation WITH CONFIGURATION Debug ===
Check dependencies
=== BUILD TARGET RCTNetwork OF PROJECT RCTNetwork WITH CONFIGURATION Debug ===
Check dependencies
** BUILD FAILED **
The following build commands failed:
CompileC /myproject/ios/build/Build/Intermediates/RNVectorIcons.build/Debug-iphonesimulator/RNVectorIcons.build/Objects-normal/x86_64/RNVectorIconsManager.o RNVectorIconsManager/RNVectorIconsManager.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
Installing build/Build/Products/Debug-iphonesimulator/example.app
Launching org.reactjs.native.example.example
org.reactjs.native.example.example: 2465

I've also tried with the podfile (clearly with the relative path, as you suggest in #394), however I ended up with errors anyway

OK, you need to upgrade RN to 0.40 or downgrade RNVI to 3.0

Ok, I've upgraded to RN 0.40 from 0.38, myproject keeps working on Android, however I still can get to compile to iOS when react-native-vector-icons is added.
Here's the log, I hope this can be helpful to give a hint on how to solve this issue.
Found Xcode project example.xcodeproj
We couldn't boot your defined simulator due to an already booted simulator. We are limited to one simulator launched at a time.
Launching iPhone 6 (iOS 10.2)...
 I've also pulled a request where I added some related info to the README file.


[Ask] Probe Sensor

Hi, nice work for your project, i just want to asking for this ATO. which better sensor?

HC-SR04
XKC Y25 SENSOR / XKC-Y23
Type NPN : 5-12V DC
or standar FLOAT SWITCH SENSOR

Hi @isnuryusuf
To be honest, HC-SR04 failed at it's task. It might not be a problem of hardware itself (distances between levels in my aquarium might be too small and usage of cm as a measurement unit was wrong).
After quick research XKC Y25 SENSOR / XKC-Y23 seems to be a really good "tool for it's job", although I have no experience with this sensor, so I cannot recommend or discourage you from using this sensor in your recreation of this project. Just so you know code is not prepared for usage of this sensor, but you can contribute to this repo and add compatibility.
I don't know what do you mean by "Type NPN: 5-12V DC", so if you could say something more, or just send me a link to this sensor it would be great.
I don't trust mechanical devices, such as float switches since they might lock in one position thus making false readings. Of course I might be just biased and this might be a really rare situation, but I wouldn't use this type of sensor.


Can't drag multiple files in Safari

Also can't drag single files in Windows WebKit, only in Safari BrowserStack

Possibly relates to https://github.com/DustinBrett/daedalOS/issues/287

Fixed by changing blur logic for dragged item. The tradeoff is now that if I drag something in Safari onto a file drop, it will also move it.


[ai-text-analytics] Repo Documentation Fixes for Preview 3

This PR:

adds more examples showing the usage of the library to the README
brings the README key concepts in line with newer conceptual copy
adds the release date to the CHANGELOG
renames TextAnalyticsClient in src/generated to GeneratedClient in order to avoid a name collision in generated reference documentation

/azp run js - textanalytics - tests


fix(Select): use a combination of label and value as key for options

Fixes: https://github.com/jamesmfriedman/rmwc/issues/387

Thanks!


Support KPI when option Choose Datasource is set

When KPI is set in termlist and being called in widget with Choose Dataset menu front-end should use /KPI endpoint

example please


test: Add table tests to validate different DID Method combinations

Add table test to validate different DID Method combinations
Signed-off-by: Rolson Quadras<EMAIL_ADDRESS>

Codecov Report
Base: 90.93% // Head: 91.10% // Increases project coverage by +0.17% :tada:

Coverage data is based on head (4d41b33) compared to base (82237ea).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   90.93%   91.10%   +0.17%
==========================================
  Files          36       38       +2
  Lines        1224     1270      +46
==========================================
+ Hits         1113     1157      +44
- Misses         66       67       +1
- Partials       45       46       +1

Impacted Files
Coverage Δ

cmd/wallet-sdk-gomobile/did/creator.go
82.35% <0.00%> (ø)

cmd/wallet-sdk-gomobile/did/wellknown.go
100.00% <0.00%> (ø)

pkg/did/wellknown/wellknown.go
94.44% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Open Redirection Vulnerability

When a logged-in user clicks on a specially crafted link with a redirect_url parameter, the user can be redirected to an external website. The user must take an action, such as clicking on a portal button or using the browser’s back button, to trigger the redirection. This could lead to phishing attacks, where an attacker tricks users into visiting a malicious website by crafting a convincing URL.

When logged-in, a victim clicks on the link: https://portal.caddysecurity.network/auth/whoami?redirect_url=https://nvmgpc54pak47d02e6a1l6c6wx2oqfo3d.oastify.com

Then, he clicks on the Portal button. He is redirected to the redirect_url through this request:

GET /auth/portal HTTP/2
Host: portal.caddysecurity.network
Cookie: AUTHP_SESSION_ID=REDACTED; access_token=REDACTED; AUTHP_REDIRECT_URL=https://nvmgpc54pak47d02e6a1l6c6wx2oqfo3d.oastify.com
Sec-Ch-Ua: "Not/A)Brand";v="99", "Google Chrome";v="115", "Chromium";v="115"
Sec-Ch-Ua-Mobile: ?0
Sec-Ch-Ua-Platform: "macOS"
Upgrade-Insecure-Requests: 1
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.7
Sec-Fetch-Site: same-origin
Sec-Fetch-Mode: navigate
Sec-Fetch-User: ?1
Sec-Fetch-Dest: document
Referer: https://portal.caddysecurity.network/auth/whoami?redirect_url=https://nvmgpc54pak47d02e6a1l6c6wx2oqfo3d.oastify.com
Accept-Encoding: gzip, deflate
Accept-Language: en-US,en;q=0.9,pl;q=0.8,ru;q=0.7

HTTP/2 303 See Other
Cache-Control: no-store
Location: https://nvmgpc54pak47d02e6a1l6c6wx2oqfo3d.oastify.com
Pragma: no-cache
Server: Fly/a0b91024 (2023-06-13)
Set-Cookie: AUTHP_REDIRECT_URL=delete; Domain=caddysecurity.network; Path=/; Expires=Thu, 01 Jan 1970 00:00:00 GMT;
Date: Wed, 19 Jul 2023 12:49:01 GMT
Content-Length: 0

When he uses arrows in the browser to come back to the authorization process, he can be redirected to the external domain by this request too:
GET /oauth2/google/authorization-code-callback?state=fad54088-4e3f-452b-bcdc-db409c64a703&code=4%sdfdsf-sdfsdfsdf&scope=email+profile+openid+https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fuserinfo.email+https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fuserinfo.profile&authuser=0&hd=caddysecurity.com&prompt=none HTTP/2
Host: portal.caddysecurity.network
Cookie: AUTHP_SESSION_ID=g36v1Ycxjb1bHcBJ3FK1C2xqUb1rLpeawaN0Nglf1bLk; AUTHP_REDIRECT_URL=https://l9ve3aj238y2lbe0s4ozz4q4avgm4lsa.oastify.com
Upgrade-Insecure-Requests: 1
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.7
Sec-Fetch-Site: cross-site
Sec-Fetch-Mode: navigate
Sec-Fetch-Dest: document
Sec-Ch-Ua: "Not/A)Brand";v="99", "Google Chrome";v="115", "Chromium";v="115"
Sec-Ch-Ua-Mobile: ?0
Sec-Ch-Ua-Platform: "macOS"
Referer: https://portal.caddysecurity.network/
Accept-Encoding: gzip, deflate
Accept-Language: en-US,en;q=0.9,pl;q=0.8,ru;q=0.7

HTTP/2 303 See Other
Authorization: Bearer ABC.REDACTED.REDACTED
Cache-Control: no-store
Location: https://l9ve3aj238y2lbe0s4ozz4q4avgm4lsa.oastify.com
Pragma: no-cache
Server: Fly/a0b91024 (2023-06-13)
Set-Cookie: access_token=eyREDACTED; Domain=caddysecurity.network; Path=/; Secure; HttpOnly;
Set-Cookie: AUTHP_SANDBOX_ID=delete; Domain=caddysecurity.network; Path=/; Expires=Thu, 01 Jan 1970 00:00:00 GMT;
Set-Cookie: AUTHP_REDIRECT_URL=delete; Domain=caddysecurity.network; Path=/; Expires=Thu, 01 Jan 1970 00:00:00 GMT;
Date: Wed, 19 Jul 2023 12:38:53 GMT
Content-Length: 0

To mitigate this vulnerability, perform proper redirect_url parameter validation to ensure that the redirection URLs are allowed only within the same domain or from trusted sources.
In addition, we also recommend the following long-term fixes:

Implement robust unit tests with different bypassing scenarios of redirect_url parameter validation. Refer to the potential URL Format Bypasses. Keep in mind that different components can use different URI parsers, which can lead to parsing confusion.
Use Burp Suite Professional with a scanner with both these settings enabled:

Audit coverage – maximum: to use the most extensive set of payload variations and insertion point options
Audit coverage – thorough: to try more payload variations

More information about our Caddy Security public disclosure:

https://blog.trailofbits.com/2023/09/18/security-flaws-in-an-sso-plugin-for-caddy/

Added trust logout redirect uri directive that validates the redirect URL. For example, trust logout redirect uri domain authcrunch.com path /foo/bar.
https://github.com/greenpau/caddy-security/blob/90049c80f2c048dfc1d493c221b9f53a1dca43d5/caddyfile_authn_misc.go#L70-L110
That, in turn, enables the verification of the redirect url.
./pkg/authn/handle_external_http_logout.go:     if redirects.HasRedirectURI(r.URL) && (len(p.config.TrustedLogoutRedirectURIConfigs) > 0) {
./pkg/authn/handle_external_http_logout.go:                     if redirects.Match(redirectURI, p.config.TrustedLogoutRedirectURIConfigs) {
./pkg/authn/portal.go:  if len(p.config.TrustedLogoutRedirectURIConfigs) > 0 {
./pkg/authn/portal.go:                  zap.Any("trusted_logout_redirect_uri_configs", p.config.TrustedLogoutRedirectURIConfigs),
./pkg/authn/handle_http_logout.go:              if redirects.HasRedirectURI(r.URL) && (len(p.config.TrustedLogoutRedirectURIConfigs) > 0) {
./pkg/authn/handle_http_logout.go:                              if redirects.Match(redirectURI, p.config.TrustedLogoutRedirectURIConfigs) {

@greenpau I tried adding trust logout redirect uri domain myhost path / to my authentication portal, but https://myhost/auth?redirect_url=https%3A%2F%2Fmalicoushost.com%2F still redirects to the other host. Am I doing something wrong?

@binarious, thank you for testing the directive. please reach out to me on Linkedin. Will troubleshoot over Google Meet. Also, please open another issue for this and reference this one.


Sync to upstream 3.0 - profile BT connectivity issues

Advantage 360 Pro PR template
What's changed:
Why has this change been implemented:
What (if any) actions must a user take after this change:

Sorry, made by mistake - meant to update my fork to upstream not issue PR against upstream.


[Proposal] bindable expression in if let must be available to borrow in else branch

Let's assume code
let mut map = HashMap::new();
for item in &items {
    if let Some(values) = map.get_mut(&item) {
        values.push(0);
    } else {
        // This is error now
        map.insert(item, vec![0]);
    }
}

map is borrowed in if let and being borrowed even if binding failed

While what you are proposing is potentially useful for other reasons, your specific example can be rewritten to use the entry API (which is additionally more efficient because it only performs one key lookup):
use std::collections::HashMap;

fn main() {
    let items = vec!['a', 'b', 'c', 'a', 'b', 'b'];

    let mut map = HashMap::new();

    for item in &items {
        map.entry(item).or_insert(vec![]).push(0);
    }

    println!("{:?}", map);
}

Prints:
{'c': [0], 'b': [0, 0, 0], 'a': [0, 0]}

duplicate of #811

Yes, @oli-obk is correct.


Converting toleration values from booleans to strings

Needed to be updated per this comment https://github.com/rancher/dashboard/issues/1244#issuecomment-695121332

I'm merging this one myself since it's fairly innocuous and a blocker for qa. If anyone has a problem with this please let me know and I won't do it for this kind of change in the future.


Update index.md

Added improvements from MxTemplates

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update Kruskals Minimum Spanning Tree.cpp

Please add description of change or the intent of the change. One line changes are very difficult to understand without any explanation.


Can dep resolve dependencies in other tools format (glide or godep for example)?

Can dep read the configuration from Glide, Godep, GB, GOM, and GPM (currently Glide can do this)?
We now using Glide for all internal packages, if dep can read the configuration from some of the current popular community tools, this will help the transition to this new tool (in some day).

Not right now, but it easily could. Initially, implementing reading other tools is all about init - #186. However, code that's written for init is likely to be trivially adaptable to also be used at dependency resolution time.
In discussions about this prior to opening up the dep project, the committee was generally more in favor of not supporting old tooling at all (except at init), with the concern that it would have the unintended effect of encouraging the ecosystem to remain fragmented between different tools.

tl;dr: dep probably won't read Glide config out of the box, but probably will convert from Glide config.

In discussions about this prior to opening up the dep project, the committee was generally more in favor of not supporting old tooling at all (except at init), with the concern that it would have the unintended effect of encouraging the ecosystem to remain fragmented between different tools.

I agree with that.
I think having some tools to convert from X to Dep would make sense.. those tools dont need to be part of dep even, they could be open source tools some create.

@arthurnn at present I'm hoping we can do it within dep, as I think that'll make for the smoothest community migration process - that's what #186 is about. But there are reasons that might not work out; if it doesn't, falling back to separate tools would be just fine.

This is pretty much a deal breaker.  If the projects I depend on are using glide, then how can I use dep if dep isn't going to read the glide.yaml of dependent projects during 'dep ensure'?  Generally the upstart provides compatibility with the incumbent systems to ease adoption.

dep parses glide files, but medium-term, projects should convert from glide to dep.

Is that a recent change?  Because up above, sdboyer's comments seem to suggest that glide files are only read during 'dep init' and not during 'dep ensure'.  And this issue (https://github.com/golang/dep/issues/821) was filed just a few days ago which is in-line with my own experience that dep does not seem to be using the glide.yaml files during 'dep ensure'.

yes, dep parses glide files, but only during dep init, and only the current project's glide files, not dependencies' glide files.
i'm going to close this one, though, as #821 is really a more detailed and complete writeup, and the use case described there convinced me that we definitely need to support on-the-fly conversion of dependencies' glide files during dep ensure.

Like others said, I moved to dep, but moving back to glide. I understand the need to discourage fragmentation, but when Google's own Kubernetes and GRPC is on Godep.json, it's a bit of irony that all our transitive dependencies get broken badly.


Docker based test dbs

Probably will still fail, because travis might not have oracle client libs installed yet.
Also found out that:

current test suite is not closing down all started databases (so mocha must be ran with --exit switch)
acquireConnectionTimeout doesn't work for some reason with oracledb

Only potential problem still here is that mysql server startup hangs some times... I'll try to rerun these to check out if that is still a problem.

Yep, still various tests are unstable with oracledb... I'll skip them on oracle and add an issue about them. Still seems like the problem is that the way how knex does transactions with oracle is not completely stable...

And still gotta fix those linting issues on sunday.

@elhigu Merged changes from master that enabled running tests on Node 12. However, Oracle driver still doesn't support Node 12. Can we not execute Oracle tests on it?

@elhigu Merged changes from master that enabled running tests on Node 12. However, Oracle driver still doesn't support Node 12. Can we not execute Oracle tests on it?

No, oracle tests cannot be ran with node 12 yet. Also looks like that something else came with you merge here, since there is new failing test (TypeError: qb(...).table(...).having(...).clearHaving is not a function)...

@elhigu Pull changes from master, I would expect that to fix clearHaving problem

@elhigu Pull changes from master, I would expect that to fix clearHaving problem

Yep... I'm rebasing back to top of master... now there are just bunch of conflict to fix 😬

@elhigu I can resolve conflicts if you want.

Looks like all of them was for package.json + travis (but had to fix them on every commit). You could check afterwards that they look fine after I'll update this branch (I might have lost some of the changes / package version there).

Again something really strange happens in travis that doesn't happen locally... created another simpler project to explore that https://github.com/elhigu/travis-node-oracle-18-xe
Basically locally installed libs are found in /usr/lib/oracle... inside docker container, but in travis that directory doesn't seem to be created, even that both uses the same docker image where to install them.

Finally green! Should we merge this?

huh finally its over.... I saw one random hanging after tests, which might mean that some connection is left open in some cases. or pool cannot tear down properly. If that happens we could add flag that forces mocha to exit even if there are connections left open and see if stuff works better when tests are written in a more clean manner with async / await .


corpus deletion doesn't work

when a corpus deletion is done, layers, annotations and media are remove but corpus isn't

Fixed in version 0.5.6


Queue backup stash

Timestamped queue backups should be stored somewhere so that if something royally fucks up I can restore from a backup.

Something with an actual UI would be nice, but that also might be overengineering things a bit.

Ａｎｄ　I'd need a domain for my server. And need to think about security.

Doing it via commands is a good start, anyhow.


Testing plugin at end user - Behat

Let's assume I am working on SyliusWalletPlugin which extends user to have wallet feature as follows
In my plugin, I have defined interface and walletableTrait
UserWalletInterface extends UserInterface
{
  public function getWallet();
}

Now the end user who uses the plugin needs to implement UserWalletInterface and include wallatable trait.
Now how one can do Behat scenario testing which doesn't have a working User class which can only be implemented at the end user.

Just create a working class inside of test folder. It will also work as a sample integration :)


Using up all Credits Available

What happens if I use up all the Credits Available and there is Low traffic or Heavy traffic ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0cd2e24b-0fd3-d698-2840-3f8206933026
Version Independent ID: 832dc371-480a-c74a-e956-e1904473af31
Content: B-series burstable - Azure Virtual Machines - Azure Virtual Machines
Content Source: articles/virtual-machines/sizes-b-series-burstable.md
Service: virtual-machines
GitHub Login: @ayshakeen
Microsoft Alias: ayshak

Thanks for the feedback! We are currently investigating and will update you shortly.

@joekhoo80 If all the credits are used, then only baseline performance can be used which will be around 20% of the original size.

@ayshakeen Can you please add your comments.

@VikasPullagura-MSFT , thanks for your clarification.
In the event that that happens and we find the baseline performance (20%) unacceptable, is there any way for us to purchase/top up additional credits to boost the performance ?

@joekhoo80 You cannot buy credits, they have to be built automatically with Idle VM. In your case you have to switch to other VM size.
I will have @ayshakeen add more insights on this.

@VikasPullagura-MSFT  Any further word on this?

Late reply, but in case anyone else is interested...
Say you have a single core machine, Standard_B1ms with 20% baseline. If you still have credits left, you can use up to 100% (i.e. your single CPU core at 100%). However, any time you spend more than 20% CPU you will be spending credits. Whenever you spend under 20%, you will be earning credits.
So the important thing to understand here is that your average CPU cannot be higher than your baseline, i.e. 20%.
If you have 0 credits then your only option is to wait. If you do not accumulate any credits over time, it is probable that your machine is under provisioned. You could try shutting down all applications for a few hours to earn some initial credits, but if you go back to spending more than 20% average, you will soon reach 0 credits.
In this case, you must either choose a higher spec B-series machine, of a normal machine (A, D, etc.) that is built for a more stable workload. Paying for a B-series machine and continuously keeping it at 0 credit, is a waste of money.

Note on that: better than "shutting your machine down for a few hours" (not always even possible), would be to temporarily change sizes until the issue is resolved as each instance comes with "starting credits" which might be enough to get you by until downtime that will allow the credits to reaccumulate. .

We are currently cleaning up old issues and closing out items that are greater than 90 days old. If an issue is still present, please open a new feedback item on the document so we can prioritize correctly.
#please-close


Zombies yet again spacing the entire station for no reason

Brushing aside the mass sabotage that are not enforced by the administration, here my proposal.
-Increase Steel wall and reinforced wall physical damage raw resistance to 20 (meaning each time they take blunt, slash or piercing damage they will reduce it by 20) or i guess increase every wall maximum health
-Increase glass Windows slash raw damage resistance
-Change Zombie attack type to slash/blunt hybrid
Note: this doesn't mean structural damage resistance should be changed, i propose these changes to prevent zombies from destroying the entire station without a good reason, they already can pry open doors and extremely fast compared to a crew member without crowbar why they are destroying every windows and doors?
-Each time a machine OR door take damage there is a change the maintenance panel plate is destroyed, leaving the cable bare.

Note: i propose these changes in order to fix multiple things, first being zombies destroying EVERYTHING in their way.
They are brainless creature and should not know why the cloner is useful or why the station is airtight.
Second granting an additional layer of protection again revolutionaries and other antags that will cause a lot of station damage, they'll have to pick what to destroy carefully and consider taking additional risk in order to not end up shocked to death.

I believe you are in the wrong repository. This is for the web panel admins have access to in order to perform some administrative actions outside the game. For your suggestions you should probably open an issue in https://github.com/space-wizards/space-station-14.
Also administrators are volunteers, we are not on 24/7 and as such can't handle every single violation as it happens. You are encouraged to simply leave an ahelp if you see someone violating the rules so that online admins can deal with the situation immediately, or so we can deal with it retroactively if nobody is on at the time.


[FSDE-936] DevOpsGCR - Fix SmokeTests

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Playpen/job/ChiGCR/job/ChiGCR/job/PR-17/1/. :white_check_mark:


VLAN Based Services are always VLAN Aware Bundles, if evpn_vlan_aware_bundles is true

Issue Summary
If i set evpn_vlan_aware_bundles to true, all vlan based services will be deployed as vlan aware bundles, too.
I would expect, that evpn_vlan_aware_bundles: true allows the configuration of vlan aware bundles only, but keeps vlan based services as is.  This behavior can be seen on avd 4.4.0
Something like this:
evpn_vlan_bundles:
  - name: 'BUNDLE1'
    id: 10000
    rt_override: 1234:1000
    rd_override: 10

tenants:
  - name: "TENANT1"
    evpn_l2_multi_domain: false
    l2vlans:

      - id: 301
        name: 'VLAN301'
        vni_override: 2000001
        evpn_vlan_bundle: 'BUNDLE1'

      - id: 302
        name: 'VLAN302'
        vni_override: 2000002
        evpn_vlan_bundle: 'BUNDLE1'

      - id: 303 # not in bundle
        name: 'VLAN303'
        vni_override: 2000003
        rt_override: 1234:1001
        rd_override: 23

would result in the following bgp configuration currently:

   vlan-aware-bundle BUNDLE1
      rd <IP_ADDRESS>:10
      route-target both 1234:1000
      redistribute learned
      vlan 301-302
   !
   vlan-aware-bundle VLAN303
      rd <IP_ADDRESS>:23
      route-target both 1234:1001
      redistribute learned
      vlan 303

The expected one is:
   vlan-aware-bundle BUNDLE1
      rd <IP_ADDRESS>:10
      route-target both 1234:1000
      redistribute learned
      vlan 301-302
   !
   vlan 303
      rd <IP_ADDRESS>:23
      route-target both 1234:1001
      redistribute learned

Which component(s) of AVD impacted
eos_designs
How do you run AVD ?
Ansible CLI (with virtual-env or native python)
Steps to reproduce
No response
Relevant log output
No response
Contributing Guide

[X] I agree to follow this project's Code of Conduct

@ClausHolbechArista thank you for the clarification.
I think we should narrow the documentation at least, as for my point of view it's a bit misleading.
Maybe be something like "Enable vlan aware bundles for EVPN MAC-VRF. This will use vlan aware bundle with a single vlan instead of vlan base service for l2vlan"
Maybe a solution would be to leave the knob evpn_vlan_aware_bundles: true for switching switching between the default behavior of deploying vlan base service and vlan aware bundle. As a configured bundle under a l2vlan is user intended i would suggest to deploy l2vlans with configured bundles as vlan aware bundle, regardless of the knob, always.

That is a good idea for an enhancement.
If the global knob is true, we do as today. If it is false and the bundle is set on the l2vlan, instead of raising errors (which I believe to do today) we should configure the vlan aware bundle for this vlan.


Add filter options to GetPipelines API

Separate this change from https://github.com/woodpecker-ci/woodpecker/pull/3506
I would like to get at least this change into v2.5.0 if possible.

Thanks. Will address this and need to fix the test before we merge it.

Thanks for the fast review.


Ensure localized slug creates index on expected locale field

Index for slug is created on default locale slug sub-field when "localize: true" is specified.  Otherwise, clients can specify a list of locales to create indices on.

Sounds good.  I'll make the changes here shortly

Needs a rubocop -a ; rubocop --auto-gen-config, see CI.

Bump @onomated, want to finish this?

I'll take this over.


CHORE - Remove Trailing Spaces

Remove Trailing Spaces

Thanks! However, since this file is autogenerated, it's best not to mess with it directly.


Functions of flush, flushInput, and flushOutput

I have recently cloned the project and I'm a bit confused by the documentation for flush, flushInput, and flushOutput when trying to implement the latter two for Windows.
Currently the comment for flush says it flushes the input and output buffers, while the comments for flushInput and flushOutput say that they flush only the input/output buffers. The Unix implementation of the three functions, however, uses tcdrain and tcflush, and according to this page, tcdrain() waits until all output written to the object referred to by fd has been transmitted., which I believe means that the data in the output buffer will be sent through the port before they get cleared, while the input buffer will be kept intact; tcflush() discards data written to the object referred to by fd but not transmitted, or data received but not read, depending on the value of queue_selector, which I believe means that the data in the input buffer will be cleared, and the data in the output buffer will be cleared without being sent through the port.
Anyway, if flush means sending the data and then clearing the buffer, "flushing" an input buffer makes no sense to me (It's already sent to me, right?). So the best interpretation I can make is that flush flushes the output buffer, while flushInput and flushOutput clear the input/output buffers.
By the way, flushInput and flushOutput are currently unimplemented on windows. If they are meant to clear the buffer without sending their contents, PurgeComm will do the job.

I'm also having trouble with flush. Bump


merged cell

when merged cell, the cell bord disappear,how to reserve cell bord

Thanks for your issue. Please set the new border styles for the merged cells after merging cells.

Thanks for your issue. Please set the new border styles for the merged cells by the NewStyle and SetCellStyle functions after merging cells.

Thanks for your issue. Please set the new border styles for the merged cells by the NewStyle and SetCellStyle functions after merging cells. I've closed this issue, if you have any questions, please let me know to reopen this anytime.


datepicker fix

when clicking the datepicker field, the date table opened with the current month instead of the initial value of the input field.

Added un needed commits to the pull request.


Enable HAProxy httplog option for Kibana access logs

This improves the HAProxy log output format to include the HTTP method and path
https://cbonte.github.io/haproxy-dconv/1.7/configuration.html#4-option httplog
Example log:
<IP_ADDRESS>:50005 [05/Feb/2020:10:40:33.619] kibana-in~ kibana/kibana0 0/0/1/97/99 200 28881 - - ---- 18/6/0/1/0 0/0 "POST /elasticsearch/_msearch?rest_total_hits_as_int=true&ignore_throttled=true HTTP/1.1"
We have tested this by manually editing the HAProxy config file and restarting the monit process

Thanks @peterellisjones !


Add support for icons on the left

Is your feature request related to a problem? Please describe.
No there is no problem.
Describe the solution you'd like
The title says it all but if you still don't get it basically there should be icons on the left
Additional context
Add any other context, screenshots or diagrams about the feature request here.

(this is from fluent icons btw)

This used to be a feature in the theme, but was removed a while ago as menu items can't be targeted consistently any more.
Currently, a major flaw is that there is no way to differentiate between user/channel/server settings navs

will it comeback or not


Update deploy.sh

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=dev:bd1b1ed13149b439e73ebdb72c8eae39419adf2d

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=dev:187ef00033c5e1cf1736ae5e7b738f6fd6efcb8f

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=dev:efb1bcf06d922efc8c2e9675e2ae568f66e93a23

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=dev:de701a00fd5d500f1730a99b8d7a2d5db327aaa9

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=dev:534bf93201763d475c4b789ef6f94c55dff2890e

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=dev:5da0ed8db8aaea5bc30cc43e662f21dc2df0ea3a

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=dev:ccab13f5dd1551afd05c730c729e5b79abe6b385

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=dev:251b4829a52793e6947791e76d48b43837e34557

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=dev:0a8aa6f0e1d6d3bbb4d756fe905510bb40cb87c6

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=dev:e332000edbebcccaed4f0c56b3aa26c65bcdd716

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=dev:a1dc3f83928599a1a2b67f997e1679669efebab4

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=dev:621c407d6eed6dce0cd818bad3011201c1005ade

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=dev:621c407d6eed6dce0cd818bad3011201c1005ade

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=0.0.6


Wrong speed with OsmAnd?

If I configure OsmAnd~ 2.7.5 online logging as follows:
http://example.com:5055/?lat={0}&lon={1}&timestamp={2}&hdop={3}&altitude={4}&speed={5}& bearing={6}&id=666&trip=Test+2
The speeds reported in Traccar are incorrect: it shows half the actual speed in km/h. For example, driving at 50 km/h results in values around 25 being displayed (see also #3486 concerning units). Driving at 70 km/h shows values around 35.
Car speeds were stable due to cruise control. Odometer speeds are unusually accurate (1 km/h slow). Speeds on OsmAnd are shown correctly as 50 km/h and 70 km/h (plus/minus GPS jitter).

What units does OsmAnd send speed in? Traccar expects knots.

What units does OsmAnd send speed in? Traccar expects knots

Metres per second. Not configurable, as far as I can tell.

I'm about to try this, see if works:

The intention being to

Nichts! Ne srabotalo at all 😢


Refactor Shuttle Location

ITS-Pro time category: https://its-pro.ucsd.edu/browse/MA-102
This is complete when:

[x] Shuttle has been broken up into appropriate model, service and provider files.
[x] The shuttle data provider does not use its own location package
[x] The shuttle data provider uses the locations data provider to access locations
[x] The shuttle data provider does not prompt the user for location services directly

[ ] PR 1264 Test Plan PASS on iOS
[ ] PR 1264 Test Plan PASS on Android (asg003) Smoke Test Failed

pushed most recent changes to: https://github.com/g9singh/campus-mobile/tree/bugs/shuttle-provider-refactor%231261
There still seems to be an issue with the coordinates being null in the way finding data provider. (See the debug output for more detailed info)


debugOptionsUseUndefinedVariableBreak broken

The runtimeConfig.sh that is still sourced, although the .parameter files contain all variables, may contain undefined variables. Thus the debugOptionsUseUndefinedVariableBreak option breaks the script in the runtimeConfig.sh.

The runtime config is not sourced anymore. I'll close this now.

Negative. The problem persists with the job-parameter files. Indeed the problems with sample, run etc. that I recently mentioned and partially fixed were related to this issue. The problem further is relevant for situations where e.g. general global configuration values (such as sequenceDirectory in the CO configs) reference variables that are only relevant in specific jobs, e.g. library in jobs working with tagmentation lanes, run in per-lane alignment jobs. For other jobs, such as merging jobs, these variables don't make sense and cannot be set to a reasonable value!

Ok, then I am sorry for closing this too fast :D.

For now the problem is postponed. We will fix this when changing the CORuntimeService class.
The idea is to always have checks turned on. We may consider changing Roddy in certain ways to resolve this problem.


Latest commit breaks LSP / TypeScript symbols

Hey,
I just updated to the latest fzf-lua and I am finding that with https://github.com/ibhagwan/fzf-lua/commit/c9ed5be563e07ef8d4ca1e650f3c091e19f4c5b2 running I am seeing far fewer results in a TypeScript project when looking up document symbols.
I have yet to debug more, and can try do when I get time, but this is the before (ignore the contents - this is a little side project game I am building):

And this is what it looks like with the latest commit, on the same source file, same TS version, same Neovim, etc.

I am on Neovim NVIM v0.10.0-dev-1114+g35e50d79c

That’s definitely a bug, checking.

https://github.com/ibhagwan/fzf-lua/commit/413c4192cca3ac9296ff4d4c2ca2a404bb07d33b
@jackfranklin, the above commit most likely fixes this bug, can you check and let me know?

Better yet, try the latest https://github.com/ibhagwan/fzf-lua/commit/ea6829bdcbd08e9387b6af6bda7d31964124c085, should also fix formatting alignment of files in lsp_workspace_symbols.

I can confirm that this issue manifests for lsp_document_symbols when used with clangd.
On commit 1e33086

@miklhh, doesn’t seem to be an issue in the screenshot your provided, the first screenshot (by @jackfranklin) shows the fzf interface still loading (the < arrow in the info line is still green), in the new, in the new screenshot you sent there is no loading indicator which tells me these are all the symbols in this document.
What makes you think the issue is still there, can you compare the result set with an earlier commit?

Sorry for being unclear. To me, a git bisection reveals: c9ed5be563e07ef8d4ca1e650f3c091e19f4c5b2 is the first bad commit
c9ed5be:

99684a6 (my expected result):

Ty @miklhh, that’s a slightly different  issue, all results are there, they symbol names are wrong (cut) - I’ll fix it.

https://github.com/ibhagwan/fzf-lua/commit/08a63827636b3169d60d14e458c98e758a77e937 - @miklhh, this should fix it, lmk?

08a6382 seems to have fixed the problem for me with clangd. Thank you! :)

Ty for the update @miklhh, closing.

Sorry for my slow reply, this is working perfectly now. Thank you so much for a speedy reply and for such a great plugin!

Ty for the update @jackfranklin!


Is it possible to get a callback on closing an alert 'success' or 'error'?

You mean like this:

Depends on the ajax response, you can do anything you like^^

I mean why can't you do this
sweet.show({'Thank you',   'Your form was submitted successfully',  'success',
function() {window.location.assign('/app/index.html')});
so when the popup OK is pressed the you are redirected to home page.
However I found this is working
sweet.show({title: ''Thank you',   text: 'Your form was submitted successfully',   type: 'success'},
function() {window.location.assign('/utp/index.html')});
Thanks for your immediate reply.


How to config IP during clone form template

help!

I think this blog post will help youpython pyvmomi

I think this blog post will help youpython pyvmomi

linux can work，but windows templeate's ip config not setted. machine is created but network not changed!


TypeScript load function example

Describe the problem
It took me a long time to figure out how to write a TypeScript load function for __error.svelte
Describe the proposed solution
Include an example :)
import type { ErrorLoadInput, LoadOutput } from "@sveltejs/kit";
export async function load({
  error,
  status,
}: ErrorLoadInput): Promise<LoadOutput> {
  return {
    props: {
      title: `${status}: ${error.message}`,
      stack: error.stack,
    },
  };
}

Alternatives considered
Don't include an example :(
Importance
nice to have
Additional Information
No response

You can import the Load type:
import type { Load } from "@sveltejs/kit"

export const load: Load = ({ error, status }) => ({
  props: {
    title: `${status}: ${error.message}`,
    stack: error.stack,
  }
})

But I agree that there should be an example for this.

that's much nicer -- thanks :)
tried it just now. using Load compiled and ran fine, but failed svelte-check.  had to use ErrorLoad.
import type { ErrorLoad } from "@sveltejs/kit";
export const load: ErrorLoad = ({ error, status }) => ({
  props: {
    title: `${status}: ${error.message}`,
    stack: error.stack,
  },
});

@benmccann do you guys like pull requests for things this small?
if so, is there support for code tabs in the sveltekit docs, or should i just write it after the javascript version in https://kit.svelte.dev/docs#layouts-error-pages?

if so, is there support for code tabs in the sveltekit docs, or should i just write it after the javascript version in https://kit.svelte.dev/docs#layouts-error-pages?

Feel free to open a PR for the javascript version on that section! Seems to be lacking the jsdoc typings in the code block example. I'm not sure if we'd want a typescript version soon (not my call), but a javascript version is a good start.

So just adding this on top?
/**
 * @type {import('@sveltejs/kit').ErrorLoad}
 */

I can add that if it's helpful :)
In that case, should we also add ErrorLoadInput to the list of types in the "Loading" section just below?
export interface ErrorLoadInput<
	PageParams extends Rec<string> = Rec<string>,
	Stuff extends Rec = Rec,
	Session = any
> extends LoadInput<PageParams, Stuff, Session> {
	status?: number;
	error?: Error;
}

Perhaps with a link to the code https://github.com/sveltejs/kit/blob/master/packages/kit/types/page.d.ts#L21
Though, from the perspective of someone new to both Svelte and Typescript, I still wouldn't have known how to translate the jsdoc typing into a typescript type import + function, and testing just now it appears to pass svelte-check even when it's wrong.

This got lost in my notifications :sweat_smile:

So just adding this on top?

Yep!

In that case, should we also add ErrorLoadInput to the list of types in the "Loading" section just below?

I think having them in the "Error pages" may be easier to follow. Don't think a link to the code is needed though, to keep it consistent with the "Loading" section.

Though, from the perspective of someone new to both Svelte and Typescript, I still wouldn't have known how to translate the jsdoc typing into a typescript type import + function, and testing just now it appears to pass svelte-check even when it's wrong.

For now SvelteKit is going full on jsdoc so a typescript version would clutter up the docs. Maybe in the future though if we implement a sort of language toggle.

Works fine, even with the latest change #4160

Yeah. It works but I think weh should add some docs for Typescript. Not only for javascript.

I am trying to use the generated-types from documentation, but I'm still getting any type for everything, including the parameters:
My route svelte file:

The generated route type file:

I am using the default latest sveltekit + typescript application.
tsconfig.json
{
	"extends": "./.svelte-kit/tsconfig.json"
}

svelte.config.js
import adapter from '@sveltejs/adapter-auto';
import preprocess from 'svelte-preprocess';
import path from 'path';

/** @type {import('@sveltejs/kit').Config} */
const config = {

	// Consult https://github.com/sveltejs/svelte-preprocess
	// for more information about preprocessors
	preprocess: preprocess({
		postcss: true,
	}),

	kit: {
		adapter: adapter(),
		vite: {
			resolve: {
				alias: {
					$components: path.resolve('./src/lib/components'),
					$stores: path.resolve('./src/lib/stores'),
					// $lib: path.resolve('./src/lib'),
				},
			},
		},
	},

	babel: {
		presets: [
			[
				'@babel/preset-env',
				{
					loose: true,
					modules: false, // No need for babel to resolve modules
					targets: {
						esmodules: true, // ! Very important. Target es6+
					},
				},
			],
		],
	},
};

export default config;

closing in favour of #4452

I am completely new to svelte and it just took me a while to get load running in typescript.
So here is a snippet that worked for me. Maybe it will help someone.
<script lang="ts" context="module">
	import type { LoadInput } from '@sveltejs/kit';
	export async function load({ fetch }: LoadInput) {
		const url = `https://example.com/data.json`;
		const response = await fetch(url);

		return {
			status: response.status,
			props: {
				// this needs to be an exported field in your component
				// https://svelte.dev/tutorial/declaring-props
				data: response.ok && (await response.json())
			}
		};
	}
</script>

hi @fokoenecke (or anyone 😀)is this still the way?  I have Module '"@sveltejs/kit"' has no exported member 'LoadInput'.

@GaryB432

@GaryB432 this works for me
<script context="module" lang="ts">
  import type { Load } from '@sveltejs/kit'

  export const load: Load = async (ctx) => {
    return { ... }
  }
</script>

@GaryB432
Changelog says it has been renamed from LoadInput to LoadEvent. Worked for me.

The docs say how to enable type-safety for params with the jsdoc comment.  Is there a better way?

The docs say how to enable type-safety for params with the jsdoc comment. Is there a better way?

If you are using typescript, the individual input params for load should be typed automatically:
<script lang="ts" context="module">
  import type { LoadEvent } from '@sveltejs/kit';
  export async function load({ fetch, params }: LoadEvent) {
  ...

fetch for example is this fetch(info: RequestInfo, init?: RequestInit): Promise<Response>; then.

The docs say how to enable type-safety for params with the jsdoc comment. Is there a better way?

If you are using typescript, the individual input params for load should be typed automatically:
<script lang="ts" context="module">
  import type { LoadEvent } from '@sveltejs/kit';
  export async function load({ fetch, params }: LoadEvent) {
  ...

fetch for example is this fetch(info: RequestInfo, init?: RequestInit): Promise<Response>; then.

If you type it like this, then all the type information about params is lost, because a generic Record<string, string> type is used. You can use the generated type and get proper typing instead:
<script lang="ts" context="module">
	import type { Load } from './__types/[slug]';

	export const load: Load = async ({ params, fetch, session, stuff }) => {
		const url = `https://cms.example.com/article/${params.slug}.json`; // slug will be properly typed

		return {
			status: response.status,
			props: {
				article: response.ok && (await response.json()),
			},
		};
	};
</script>

If you attempt to you use a param that doesn’t exist, you’ll get an error:

Thanks @jankalfus is there a similar way for the RequestHandler in an endpoint?  my get function<EMAIL_ADDRESS>still has the Record<string, string> typing for params after importing RequestHandler from @sveltejs/kit. I'm likely doing something wrong while I'm learning this amazing platform.

Thanks @jankalfus is there a similar way for the RequestHandler in an endpoint? my get function<EMAIL_ADDRESS>still has the Record<string, string> typing for params after importing RequestHandler from @sveltejs/kit. I'm likely doing something wrong while I'm learning this amazing platform.

same as importing the load type
import type { RequestHandler } from './__types/[slug]'


Malware Scanning - File Uploads

SIMS needs to have malware scanning for file uploads on the student account, to prevent malicious files from being uploaded.
Other teams on OpenShift have implemented ClamAV to comply with this requirement. https://github.com/bcgov/clamav
Acceptance Criteria:

[ X ] Research ClamAV and connect with other teams on RocketChat
[ X ] Implement or create new ticket for implementation on all file uploaders

Created ticket 3180 for implementation and research comments.


play-site: Add Game of Life to interact samples

Add an implementation of Conway's Game of Life to the interact
samples. While this is titled "game", it is not really a game so does
not really belong in the games section. It features a few different
modes of interaction, so let's place it there.
Link: https://en.wikipedia.org/wiki/Conway's_Game_of_Life

My only comment: this is snake_case where we have settled on
camelCase for most samples - but I'm happy to reconsider.

Yeah I meant to change that. For whatever reason I seem to write
snakes when writing evy. Fixed.


IoUring support

Create this issue for tracking and discussing the IoUring effort.
We did a third iteration of the IoUring implementation https://github.com/envoyproxy/envoy/pull/24958. We get all the IoUringAcceptSocket, IoUringServerSocket, and IoUringClientSocket implemented. We pass most of the tests in the CI. For the x86 test, we get a green https://github.com/envoyproxy/envoy/pull/24958/checks?check_run_id=14653030831
For other tests, we think it failed on an existing race issue in the Envoy https://github.com/envoyproxy/envoy/issues/15072, and that issue can't be fixed quickly and easily, we leave that alone for now.
So summarize the CI status as below:

Linux x86 Build and test: green
Linux x86 msan: green
Linux x86 clang_tidy: green
Linux x86 asan: failed due to ~~https://github.com/envoyproxy/envoy/issues/15072~~ https://github.com/envoyproxy/envoy/issues/29054
Linux x86 tsan: failed due to ~~https://github.com/envoyproxy/envoy/issues/15072~~ https://github.com/envoyproxy/envoy/issues/29054
Linux x86 gcc: failed due to ~~https://github.com/envoyproxy/envoy/issues/15072~~ https://github.com/envoyproxy/envoy/issues/29054
Linux x86 coverage:

listener_lds_integration failed due to ~~https://github.com/envoyproxy/envoy/issues/15072~~ https://github.com/envoyproxy/envoy/issues/29054.

The cds_integration_test and kill_request integration test need to be investigated

Linux ARM build and test: failed due to ~~https://github.com/envoyproxy/envoy/issues/15072~~ https://github.com/envoyproxy/envoy/issues/29054, sometimes flaky more

Also notes:

The IoUringAcceptSocket is disabled since the tsan will complain about the data race, since the FD will be closed in the main thread, but read/write is on the main thread. This is also something that should be resolved in the future.
There are some tests skipped(all are in the integrate tests), due to they doesn't work well for the IoUring, or some test implemented issues exposed by the IoUring.

We also benchmarked the current implementation:
Fortio <-> Envoy <-> Fortio server
Envoy runs in 1-thread, and Fortio generates requests for 300s with connections varying from 32 to 128.
Hardware: i9-9900HK
The RPS data are collected with max load condition and the latency data are collected with a fixed 5000 QPS, the CPU usage is around 50%.
| Connection RPS/Latency    | 32                | 64                | 128               |
|------------------------   |-----------------  |-----------------  |-----------------  |
| Default                   | 13945.3 / 2.007   | 14354.4 / 3.967   | 13515.7 / 8.323   |
| io_uring                  | 15582.6 / 1.808   | 16337.7 / 3.826   | 15963.7 / 7.171   |
| Delta%                    | 12% / 10%         | 14% / 4%          | 18% / 14%         |

Summary of the TODOs we left:
There are also missing a few features, and those are features that make IoUring finally production-ready:

Currently the io_uring entries size for the SQ ring is configurable. If the configured size is small, then the requests are too much, we will stop the Envoy directly. We should have a better way to handle this.
Currently we don't have watermark for the read/write buffer in the IoUring. We should use WaterMarkBuffer to protect them. Some tests (for example TcpProxyIntegrationTest/TcpProxyDownstreamFlush) can't be passed due to there being no limit in the read/write buffer, then those tests can't trigger the read-disable as expected.

Something may improve the performance

The Iouring's read buffer size for each read request is configurable, and the default value is 8k. But It is quite small compared to the current default socket. Currently using the default socket, we will allocate eight slices, each slice has 16k. And those slices are preallocated. So we may improve that in the IoUring also, preallocate memory, and large memory for reading more data once.
When using the Buffer::move in the IoUring write, we have to invoke the drain tracker since the up-layer expected the drain tracker to be invoked after the write. But that leads Envoy to crash when using the BufferFragement and use the drain tracker to release the memory. In Envoy we indeed use BufferFragment in some places and use the drain tracker to release the memory. (Fix by https://github.com/envoyproxy/envoy/pull/28770)

cc @zhxie

I'm thinking of what we should do next. Is it ok that we begin to merge the IoUring code? Then our implementation can be under the community's review, coaching and help, then we can resolve those existing issues in the correct way and flaky issues in the end. I'm worried about if we continue to fix those issues for months without the community feedback when we begin to merge the code, we will review the code again and may find something fixed in the incorrect way, then we spend more time.
We still see some flaky in the ARM CI (less in x86 CI), also thinking about whether we can run separate test tasks for the iouring, and those tasks won't block any PR merge for now. Until we fully implement the iouring and resolve the issue like https://github.com/envoyproxy/envoy/issues/15072, and the CI becomes steady enough, then we change those iouring test tasks will block the PR merge if they failed.
cc @KBaichoo @mattklein123 @yanavlasov @phlax looking for some feedback, thanks in advance!

This is great news! Thank you for working on this.

Is it ok that we begin to merge the IoUring code? Then our implementation can be under the community's review, coaching and help, then we can resolve those existing issues in the correct way and flaky issues in the end. I'm worried about if we continue to fix those issues for months without the community feedback when we begin to merge the code, we will review the code again and may find something fixed in the incorrect way, then we spend more time.

I agree we should break up the change into some smaller PRs and get those merged in. We can block certain failing tests from running with io_uring if not compatible yet while we go about this process.

Not stale


please remove python2.7 from the network-policy agent

What would you like to be added:
I don't want anything added, I want something removed.
Current python2.7 is the network policy agent.
❯ k exec -it -n kube-system aws-node-wt6mn -c aws-eks-nodeagent -- bash
bash-4.2# python2.7
Python 2.7.18 (default, Feb 28 2023, 02:51:06)
[GCC 7.3.1 20180712 (Red Hat 7.3.1-15)] on linux2
Type "help", "cop

Why is this needed:
We run in a regulated environment python2.7 has open CVEs that wont be resolved and now we have audit and infosec demanding that we fix the CVEs.

Transferred to Network Policy agent repo

@maxres-ch this comes from the AL2 base image, I assume: https://github.com/aws/aws-network-policy-agent/blob/main/Dockerfile#L32
I don't see an issue with uninstalling python2.7, as it is not actually used

This is a duplicate of #107.

@jdn5126 should I open a PR?

@jdn5126 should I open a PR?

sure, that would be great, thank you! You are just planning to yum uninstall it?

You are just planning to yum uninstall it?

I was. I don't yum much but, I'll try to see how deps can be uninstalled, how that does feel a bit dangerous I'm not sure what kind of existing test coverage that would catch it there.
FWIW I might do this via my personal account @grumps.

@jdn5126 I looked into this. It looks like the image is based on AL2 and within it yum requires python2.7.  It can't be removed until the base image moves to AL 2023.

Any chance you know when/if https://github.com/aws/aws-network-policy-agent/blob/main/Dockerfile#L44
Will move to AL 2023, there's no python2.7 here.

I see, thank you for the investigation. I did not realize that AL2 had a hard dependency on Python 2.7. I am not sure about the feasibility of the Network Policy agent moving to AL2023 or to a minimum image build. @jayanthvn @achevuru any thoughts here?

@maxres-ch as a side note, it is my understanding that AL2 is still providing patches for any Python 2.7 CVEs that are discovered, so even as we look to remove it from the image, you shouldn't have CVEs that will never be resolved. Can you share which CVEs you see and against which Network Policy agent image?
It sounds like you already have a support case open through your TAM, can you please share the details there for security reasons?

Thanks @jdn5126  sounds like they already reached out. Good to know that they are patching it. Means it's likely infosecs tooling problem. I'll send them the CVEs.

Thanks for your responsiveness @jdn5126

@maxres-ch For the long term, we are still working on moving the image to minimal bases that do not contain Python2.7, as it is not used by the application. These minimal bases will also decrease the surface area for CVEs in general. We are scoping that work out now, as the complexity comes from compiling eBPF programs in a minimal environment.

Thanks! It totally makes sense that this would be non-trivial. It took a long time to build locally.
I will battle this out with the infosec team for exceptions. Thanks for your efforts.
IMPORTANT NOTICE: This communication, including any attachment, contains information that may be confidential or privileged, and is intended solely for the entity or individual to whom it is addressed.  If you are not the intended recipient, you should delete this message and are hereby notified that any disclosure, copying, or distribution of this message is strictly prohibited.  Nothing in this email, including any attachment, is intended to be a legally binding signature.


ido/fix crash on windows

During Shrink, we try to move the temporary file which was created to the database's original location,
this may fail on windows because if you try to rename a file to a name that already exists, the operation will fail with an  "Access is denied" error (while succeed and overwrite the file on mac and linux).
Additionally, fixed a small typo in test

@tidwall, first of all, thanks for maintaining this project!
Another approach would be to first try to perform the renaming and only delete the file and retry on failure.
I think this one is more straight forward, but let me know if you prefer the one suggested here.

@tidwall - any chance you could take a look 🙏 ?

Can we do an optimistic check first and test for windows?
Such as :
var err error
if err = os.Rename(src, dest); err != nil {
    if os == WINDOWS {
        if err = os.Remove(dest); err == nil {
            err = os.Rename(src, dest);
        }
    }
}
return err;

This way we will effectively keep the same syscall operations on posix systems, and it won't break the atomicity guarantees with moving and unlinking files that are opened by multiple processes.

Thanks for the quick response @tidwall! I confirmed the (modified) fix on windows

Thanks!