[libpng] Build failure: zlib cannot be found by pkg-config

Host Environment

OS: Windows 10 20H2 (19042.685)
Compiler: VS2017 15.9.29; VS2019 16.8.3 (not sure which one is being used by vcpkg)

To Reproduce
Steps to reproduce the behavior:
./vcpkg install libpng
or:
./vcpkg install libpng:x64-windows
Failure logs
Starting package 1/1: libpng:x64-windows
Building package libpng[core]:x64-windows...
-- Using cached C:/repos/vcpkg/downloads/glennrp-libpng-v1.6.37.tar.gz
-- Extracting source C:/repos/vcpkg/downloads/glennrp-libpng-v1.6.37.tar.gz
-- Applying patch *snip*
-- Using source at C:/repos/vcpkg/buildtrees/libpng/src/v1.6.37-05658d6f1a.clean
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Using msys root at C:/repos/vcpkg/downloads/tools/msys2/c809757c94447846
-- Fixing pkgconfig file: C:/repos/vcpkg/packages/libpng_x64-windows/lib/pkgconfig/libpng.pc
-- Fixing pkgconfig file: C:/repos/vcpkg/packages/libpng_x64-windows/lib/pkgconfig/libpng16.pc
-- pkg_cfg_cmd call with:C:/repos/vcpkg/downloads/tools/msys2/c809757c94447846/mingw32/bin/pkg-config.exe --exists libpng failed
-- ENV{PKG_CONFIG_PATH}:C:/repos/vcpkg/installed/x64-windows/lib/pkgconfig;C:/repos/vcpkg/installed/x64-windows/share/pkgconfig;C:/repos/vcpkg/packages/libpng_x64-windows/lib/pkgconfig;C:/repos/vcpkg/packages/libpng_x64-windows/share/pkgconfig
-- pkg-config call failed with error code:1
-- pkg-config output:
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:79 (message):
  pkg-config error output:Package zlib was not found in the pkg-config search
  path.

  Perhaps you should add the directory containing `zlib.pc'

  to the PKG_CONFIG_PATH environment variable

  Package 'zlib', required by 'libpng', not found
Call Stack (most recent call first):
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:180 (vcpkg_fixup_pkgconfig_check_files)
  ports/libpng/portfile.cmake:138 (vcpkg_fixup_pkgconfig)
  scripts/ports.cmake:136 (include)

Error: Building package libpng:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: libpng:x64-windows
  Vcpkg version: 2020.11.12-nohash

Additional context

I have not set the $env:PKG_CONFIG_PATH environment variable.
The file zlib.pc is available in the following folders, but not in vcpkg/installed:

vcpkg/buildtrees/zlib/x64-windows-dbg/zlib.pc
vcpkg/buildtrees/zlib/x64-windows-rel/zlib.pc
vcpkg/buildtrees/zlib/x86-windows-dbg/zlib.pc
vcpkg/buildtrees/zlib/x86-windows-rel/zlib.pc

Possibly the libpng port can be fixed by having the zlib port install its .pc file.

vcpkg should install the zlib.pc files in the following locations:
[vcpkg-root]\installed\[triplet]\lib\pkgconfig
[vcpkg-root]\installed\[triplet]\debug\lib\pkgconfig
[vcpkg-root]\packages\zlib_[triplet]\lib\pkgconfig
[vcpkg-root]\packages\zlib_[triplet]\debug\lib\pkgconfig
It would seem something has gone wrong with the zlib installation, I would try removing and reinstalling port zlib
If that does not work, it is possible the vcpkg instance has become corrupt, I would then try creating a new instance of vcpkg
From one of my test instances of vcpkg:
My-UserID@My-PC 12/23/2020 15:32:23 D:\vcpkg_x64\vs2019\test
->dir /s zlib.pc
 Volume in drive D is Dev01
 Volume Serial Number is 72B7-8EE4

 Directory of D:\vcpkg_x64\vs2019\test\buildtrees\zlib\x64-windows-dbg

12/22/2020  23:30               509              My-PC\My-UserID zlib.pc
               1 File(s)            509 bytes

 Directory of D:\vcpkg_x64\vs2019\test\buildtrees\zlib\x64-windows-rel

12/22/2020  23:30               478              My-PC\My-UserID zlib.pc
               1 File(s)            478 bytes

 Directory of D:\vcpkg_x64\vs2019\test\downloads\tools\perl\<IP_ADDRESS>\c\lib\pkgconfig

05/22/2019  14:57               268              My-PC\My-UserID zlib.pc
               1 File(s)            268 bytes

 Directory of D:\vcpkg_x64\vs2019\test\installed\x64-windows\debug\lib\pkgconfig

12/22/2020  23:30               294              My-PC\My-UserID zlib.pc
               1 File(s)            294 bytes

 Directory of D:\vcpkg_x64\vs2019\test\installed\x64-windows\lib\pkgconfig

12/22/2020  23:30               290              My-PC\My-UserID zlib.pc
               1 File(s)            290 bytes

 Directory of D:\vcpkg_x64\vs2019\test\packages\zlib_x64-windows\debug\lib\pkgconfig

12/22/2020  23:30               294              My-PC\My-UserID zlib.pc
               1 File(s)            294 bytes

 Directory of D:\vcpkg_x64\vs2019\test\packages\zlib_x64-windows\lib\pkgconfig

12/22/2020  23:30               290              My-PC\My-UserID zlib.pc
               1 File(s)            290 bytes

     Total Files Listed:
               7 File(s)          2,423 bytes
               0 Dir(s)  584,097,222,656 bytes free

Hi @ShinNoNoir
Thanks for posting this issue.
Could you please remove zlib: x86-windows or zlib:x64-windows then try to rebuild libpng?
zlib.pc should be installed to installed\triplet\lib\pkgconfig directory as @StarGate-One said above.
I think you might have installed zlib before this change. https://github.com/microsoft/vcpkg/commit/273b5eddaa2d38b7df285efe915a0ce0ba12b7c5#diff-1ee0dc969989c37c35076df21135495f4ae6bcca0ccae404ecef27037077a98c

I'm currently unable to look into it, but I will when I get back on Monday.

Update: Removing zlib (and having it installed again when rebuilding libpng) fixed it.


Add switch 'Show in sidebar'

Please follow https://github.com/TradeFace/gismocaster/issues/54

I had started down the path of adding support for ingress to the add-on, but couldn't get it working because the tuyagateway itself has no idea that it is being wrapped and returns URLs that don't work. I'll put this on my todo list though, and see if I can get it working in the future.

Will this be addressed?  The sidebar switch is there but it gives an embedded error in FireFox and other main browsers plus the Android companion app


MediapipeException: mediapipe aborted

Hi. This is a truly awesome project - thanks you so much :)
It is running fine in the Unity Editor on MacOS but I'm having trouble getting iOS to work with the 'DesktopDemo' scene on 0.5.1( renamed iosMpipe12 in the log below ).  I've built the asset bundles & they seem to load okay.
Sorry if I've a simple mistake - any help you could give would be really appreciated.

2021-03-23 18:25:12.443825+0000 iosMpipe12[1497:367881] Built from '2019.4/release' branch, Version '2019.4.18f1 (3310a4d4f880)', Build type 'Development', Scripting Backend 'il2cpp'
-> applicationDidFinishLaunching()
PlayerConnection initialized from /private/var/containers/Bundle/Application/A0B1A755-5455-4163-8018-1E5F96B9FC77/iosMpipe12.app/Data (debug = 0)
PlayerConnection initialized network socket : <IP_ADDRESS> 55000
Multi-casting "[IP] <IP_ADDRESS> [Port] 55000 [Flags] 2 [Guid] 960316513 [EditorId]<PHONE_NUMBER> [Version] 1048832 [Id] iPhonePlayer(Harrys-iPhone):56000 [Debug] 0 [PackageName] iPhonePlayer [ProjectName] iosMpipe12" to [<IP_ADDRESS>:54997]...
Started listening to [<IP_ADDRESS>:55000]
PlayerConnection already initialized - listening to [<IP_ADDRESS>:55000]
2021-03-23 18:25:12.520528+0000 iosMpipe12[1497:367881] Metal GPU Frame Capture Enabled
2021-03-23 18:25:12.520659+0000 iosMpipe12[1497:367881] Metal API Validation Enabled
-> applicationDidBecomeActive()
GfxDevice: creating device client; threaded=1
Initializing Metal device caps: Apple A12 GPU
Initialize engine version: 2019.4.18f1 (3310a4d4f880)
2021-03-23 18:25:12.874181+0000 iosMpipe12[1497:368230] fopen failed for data file: errno = 2 (No such file or directory)
2021-03-23 18:25:12.874232+0000 iosMpipe12[1497:368230] Errors found! Invalidating cache...
2021-03-23 18:25:14.244045+0000 iosMpipe12[1497:368230] fopen failed for data file: errno = 2 (No such file or directory)
2021-03-23 18:25:14.244304+0000 iosMpipe12[1497:368230] Errors found! Invalidating cache...
-> applicationWillResignActive()
2021-03-23 18:25:14.447167+0000 iosMpipe12[1497:367881] Unbalanced calls to begin/end appearance transitions for <UnityViewControllerStoryboard: 0x159faff50>.
-> applicationDidBecomeActive()
UnloadTime: 2.399542 ms
[SRDebugger] No SRDebugger settings object found - using defaults.
No registered object with name: FaceDetectionFrontCpu; Unable to find Calculator "FaceDetectionFrontCpu"
*** Check failure stack trace: *****

Maybe this is the same issue as https://github.com/homuler/MediaPipeUnityPlugin/issues/87 .

Yes that works ! Thanks you so much.


Bring flag-only mods to the same version, and add a comment to identify them.

One more step toward #623's completion.

Any flag hosted on KS likely isn't there anymore as it's against their mod policy.

We should probably remove these. I'll leave this open so it can be attended to.

@techman83 Why would we remove them? There are only 2: 1 hosted on curse and 1 on KS as part of AlternateResourcePanel

@plague006 I mean remove the KS ones that are failing. (I thought they were all KS ones, sorry may not have looked hard enough).
KS Has the following policy:

Kerbal Stuff is a website for hosting mods. We have a couple of basic rules about what you can upload here

If you didn't write code (or parts), it probably doesn't belong here. No crafts. No flag packs. And so on.
Only upload mods you have the right to distribute. Check licensing!

That's it! If you upload something that doesn't adhere to these rules, we will remove it. Otherwise, you're good to go!

So I'd suggest that's why the Flags are failing to download.

You're right that's my mistake, I only tried downloading the most recent versions of each.
ModernChineseFlagPack-1.2 and ModernChineseFlagPack-1.3are dead links.

Can .ckans be deleted without causing issues to end users? I thought that was a big taboo?

Yeah they can be (if not we have bugs to squash). Removing ckan files  is not taboo as such, More there needs to be a good reason to do so.
The metadata for those ckans was likely only valid for a brief amount of time on KS so we need to either fix them by pointing them at their current location if it exists in an indexable manner or remove them.
If we use a PR that refers this issue we can always revert it if it turns not to be the best way to handle this.

What about adding Agar.io skins into KSP flags? Just a idea.
For more on Agario and its skins, check www.agarioguide.com and www.agarioguide.com/skins respectively. I say, maybe to parody the game. Also many skins are country flags, though my Brazil (homecountry) flag made specially for KSP is overall much better.

This issue isn't about adding flags, it's about modifying the flags already present.

Ops... Whatever I done an nice Brazil flag. Where do I post

Crossing fingers that removing the old versions of ModernChineseFlagPack doesn't cause issues for people. Passes local. Merging.


add functions for sending private messages to users

Thanks for the contribution.
Could you add some tests ? This won't be difficult, get the code from TestRoomNotification in room_test.go and adapt it in user_test.go.
Thanks in advance

Sure. Here you are.

Thanks, squashed and merged as 1dd13e154219c15e2611fe46adbb6bf65db419b7


KAFKA-6687: restrict DSL to allow only Streams from the same source topics

Followup to https://github.com/apache/kafka/pull/9582
Will leave the ability to create multiple KTables from the same source topic as followup work. Similarly, creating a KStream and a KTable from the same topic can be tackled later if need be

I don't want to spoil the party, but as this is a bug-fix PR, that we want to back-port, we should not to massive renaming... Happy, do rename in follow up for trunk only.

@mjsax it's not a bugfix PR, this is only going to trunk. Well technically it is fixing a bug, but that bug was only merged to trunk a few weeks ago. Otherwise I would agree, that would be merge hell 🔥

Merged to trunk


Update the list of code owners

Should be fixed now as I've invited you to the teemtee organization.

@psss test failures seems not related


Send partners notification when a request has been canceled

Resolves #2355
Description
This PR adds the logic to send an email notification to partners when a diaper bank cancels/discard/deletes one of their requests. It does this by:

Adding a RequestDestroyService that encapsulates that logic
Added a RequestMailer to be able to send the email (see snapshot for a copy)

Note - In the future, we should probably update the RequestDestroyService to erase the copy in partnerbase OR condense Partners::Request & Request to a single model
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Tested locally & via rspec
Screenshots
Here is what the email looks like. I got approval from Judi (the requestor of this feature) on the copy & text. I used https://codedmails.com/template-preview?template=notification-email-canaotes as a reference.

@albertchae or @scooter-dangle
May I please get a review on this :)

@albertchae thanks for the review. I've updated based on your comments. Plus added a browser spec


Unhandled Exception: Unable to RTCPeerConnection::setRemoteDescription: peerConnectionSetRemoteDescription(): WEBRTC_SET_REMOTE_DESCRIPTION_ERROR: Failed to set remote answer sdp: Called in wrong state: stable

Specify the sample to which the issue belongs (use [x]):
[] Chat sample
[X] P2P Call sample
[] Conference Call sample
Platform (use [x])
[X] Android
[X] iOS
[] macOS
[] Windows
[] Web
Device info
Manufacturer: Huawei
Model: P20 Pro
OS version:
Describe the bug:
Production IOS devices face multiple issues hearing audio from the other peer during audio and video calls, sometimes only one peer can hear the voice of the other peer, and sometimes none of the peers can hear anything
While trying to investigate this problem on IOS simulators and my android mobile, I have found this exception thrown among the log
E/flutter ( 4262): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Unable to RTCPeerConnection::setRemoteDescription: peerConnectionSetRemoteDescription(): WEBRTC_SET_REMOTE_DESCRIPTION_ERROR: Failed to set remote answer sdp: Called in wrong state: stable

I would appreciate any help on this issue, even audio calls are facing the same behavior issue even if this exception does not throw
Steps to Reproduce:

Start a one-to-one video call with another user

Logs:
Gist Log
Actual result:
The previously mentioned exception + audio problems for peers
Expected behavior:
Call going with booth peers able to hear each other

@Abdullah104  do you able to reproduce it on the real device? which devices do you use for it? Can you reproduce it on our sample? According to the provided log, it is your app, not our P2P Calls sample. If it reproduces on our sample, please provide a step-by-step guide on how we can reproduce it on our sample.

It reproduces on real iPhone devices, but not on Android.
We have uploaded the sample to TestFlight in order for the client to test it on their real iPhone devices and the problem did not reproduce.

sorry for the late answer ((( please try the latest version of our samples, if the issue still happens, please try to collect full logs from both sides and provide them here

no activity for a long time, closing.


add AXFR source to OctoDNS

Adds a new source requested in #239. This source allows a user to pull data from
a legacy system (Bind9, etc.) that does not have an API/existing provider via
AXFR Zone Transfer.
I tested it against NS1 via AXFR with a zone with ~6500 records and it worked like a dream, might be missing some record types, but it's a good start. Figured I'd get it up here for some review while I tweak/add tests.
Ideally, it could be highly configurable:

TSIG
Different Port
Timeout

Just checking that you're ready for this to :ship: before I merge...

Need to write the tests for it, it'll be a little confusing because I have to probably mock the response from the zone transfer, which is a bunch of dnspython objects, etc.
I'm not sure if this is the best spot to put it, but I added a ZoneFileSource as well, as the only difference with loading from a zone file or a zone transfer with dnspython is a method, so it was a quick win to add a source for a zone file.
It's a little confusing it being under the axfr module, but I'm not sure what would be the best place to put it. I'm open to any suggestions on better placement/organization.

 Both methods generate a dns.zone.Zone object.


"allOf" support

Should we support the allOf keyword in the Swagger 2.0 (now OpenAPI) specification?

+1

I've just tried adding a poll but it created this extra issue - leave your vote in either issue or make a pull request...

Yes, this would be great! I think @jjcross already has this implemented on his fork. Check it here please:
https://github.com/jjcross/swagger-model-validator/commit/f5d80a141133c6db6e9b1a8d6b810d1bb00f0b4f

Implemented getMergedModel works incorrectly. It breaks the original schema. it duplicates and injects pieces of schema from one place into another. Here is an example: http://take.ms/bFeun It compares schema object before validateModel execution and after it. As you can see, it injected piece from another place. Problem occurred after updating to new version, which supports allOf


Using with other fan manufacturers?

I took me a while to realize that Create was a fan manufacturer :)
I'm using the latest version (0.0.81) of your plugin in my homebridge 1.6.1 server, but my fan is just a generic Tuya based ceiling fan from a company called Eogifee.
I was curious how you made this plugin specific to Create to see if I could tweak it to work with my ceiling fan.
All of the steps you linked to to get the device to show up all work, but when I restart homebridge I get this warning - probably because this fan doesn't have a dimmable light.
This plugin generated a warning from the characteristic 'Brightness': characteristic value expected valid finite number and received "NaN" (number). See https://homebridge.io/w/JtMGR for more info.
Any pointers you could give me to connect the correct features up would be much appreciated.
All the info appears to be in the snapshot.json after running a scan, so I've got some information at least ;)

Hello,
Maybe you have the same problem explained here, your fan can manage brightness ? If not, I can add an option to disable brightness and have a toggle instead, What do you think ?

Thank you for replying :)
Yes I think you are correct, it sounds very similar indeed.
I think that because my fan isn’t a Create that most of the option codes are incorrect, so while it appears in Homebridge it doesn’t start the fan.
I think I have the codes from TinyTua so was going to try figuring out how to adjust the plug-in locally to see if I could get it going

Hi @moifort, I stumbled upon your plugin and it looks great. I have ceiling fans that uses a Tuya wifi adapter and the DPS / DPID are as follows:

DPID
Description
Example

1
Power
ON or OFF

2
Mode
NORMAL, NATURE or SLEEP

3
Fan Speed
1,2,3,4 or 5

22
Timer
1 Hour

8
Direction
FORWARD or REVERSE

15
Light
ON or OFF

16
Brightness
1,2,3,4,5

Product ID
vzj97d3m05yjhchn
Were in your code do I need to update the DPS values to work with my fans?
I will appreciate the help.


Extend XML documentation on Facade APIs

Is your feature request related to a problem? Please describe.
Developers struggle with using our facades in their applications. Eventhough the functions are described well, the parameters are not always self-explanatory. This causes unnecessary effort on our site to explain the usage of the facades and is difficult for newcommers to the project.
Describe the solution you'd like
Use parameter descriptions in xml comments which explain what they are used for in the function.
Additional context
A good example is the IWorkerSupport Interface, which requires an identifier to add an instruction, but specifies nowhere what this identifier is used for. In this case its the identifier of the VisualInstructor not of the instruction nor the source of the instruction which are both valid assumptions for the parameter as well.

Interesting example: The identifier for the facade is actually not the instructor (it could be, but makes little sense). It's intended as an additional way to display instructions independent from instructors. The module should also return those identifiers (sources) when there are any requests.

Does that mean that getting the Facade and adding an instruction with the identifier of the VisualInstructor resource is not the intended way of using the facade, but instead you would recommend to get the instructor from the ResourceManagement and using that to display or execute instructions?
The facade could then be used to add instructions from let's say a module which does not correspond to one VisualInstructor but uses its own identitfier for the  method calls? 🤔


Embedding api not working

https://beta.openai.com/docs/guides/embeddings/what-are-embeddings documented the newly available embedding api, but the examples are not working:
response = openai.Engine(id="babbage-similarity").embeddings(
    input="Sample document text goes here"
)
embeddings = response['data'][0]['embedding']

This is the error message:

Traceback (most recent call last):
  File "/home/whao/.virtualenv/openai/lib/python3.6/site-packages/openai/openai_object.py", line 96, in __getattr__
    return self[k]
  File "/home/whao/.virtualenv/openai/lib/python3.6/site-packages/openai/openai_object.py", line 136, in __getitem__
    raise err
  File "/home/whao/.virtualenv/openai/lib/python3.6/site-packages/openai/openai_object.py", line 124, in __getitem__
    return super(OpenAIObject, self).__getitem__(k)
KeyError: 'embeddings'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/whao/.virtualenv/openai/lib/python3.6/site-packages/openai/openai_object.py", line 98, in __getattr__
    raise AttributeError(*err.args)
AttributeError: embeddings

I'm facing the same error as @whaowhao, I'm resulted with AttributeError: embeddings when I try to obtain embeddings

Hey @whaowhao,
Thank you for the issue.  I can't seem to replicate this problem here.  What version of openai are you running?

I'm going to close this issue for now.  Feel free to reopen if you continue to have issues.


[Feature Request] Some way to enter barcode manually when it's not scanned automatically

Is your feature request related to a problem? Please describe.
Some barcodes which I scan are quite poor quality and the scanner cannot identify them. I would like to give my users some way to enter barcode manually in such cases.
Describe the solution you'd like
I would like to have a text field where users could insert a barcode manually. Since I want to customize the appearance of such a text field I think that it makes sense to not open barcode scanner fullscreen but rather provide a barcode scanner widget that developers will be able to insert wherever they want.
Additional context
See below how it works in MyFitnessPal. It looks ugly but it gives you an idea of what I would like to achieve.

I added a textfield and a button in the start page

Sorry, what start page you are talking about?

Sorry but this feature request is too specific. Maybe it'll be possible on your own when this was solved: https://github.com/mintware-de/flutter_barcode_reader/issues/187

If you mean that I will be able to insert the scanner inside a custom widget tree, then yes, that would definitely help.


colors rotation breaks at line 47

head -n 100 /dev/urandom | tr -cd '[:alnum:]' | fold | cat -n | lolcat

The same command prints fine here. What version of lolcat do you have?
Does the problem also occur with head -n 100 /dev/urandom | base64 | head -n 70 | lolcat?

version is lolcat 99.9.21 (c)2011<EMAIL_ADDRESS>happens also with that command, but is less visible:

Sorry, can't reproduce this here.
Weird wraps in the color cycle are normally due to unintended line-breaks, but
that doesn't seem to be the case here (still space left on the right of your screenshot).
Things you could try:

Different terminal emulator
Installing lolcat from rubygems (gem install lolcat) instead of using a packaged version

still happening with:

all  (terminal, shell) in {gnome-terminal, tilix, terminator} x {zsh,bash},
package (ver. 99.9.69) from rubygems

I won't dive deeper into this. leaving open just in case anyone experiments the same "feature" :smile:

Bug found and buried.
Latest lolcat should restore satisfaction 🌈


Create Tablesaw Dataset

Description

Create a new tablesaw DJL extension containing the tabular dataset support with Tablesaw.
The following functions have been implemented:

a TablesawDataset class extending RandomAccessDataset to support for importing tabular datasets in Tablesaw format.

closed #1587

Codecov Report

Merging #1679 (318917e) into master (bb5073f) will decrease coverage by 1.49%.
The diff coverage is 62.05%.

@@             Coverage Diff              @@
##             master    #1679      +/-   ##
============================================
- Coverage     72.08%   70.59%   -1.50%
- Complexity     5126     5458     +332
============================================
  Files           473      511      +38
  Lines         21970    24114    +2144
  Branches       2351     2626     +275
============================================
+ Hits          15838    17023    +1185
- Misses         4925     5779     +854
- Partials       1207     1312     +105

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...rc/main/java/ai/djl/modality/cv/output/Joints.java
71.42% <ø> (ø)

.../main/java/ai/djl/modality/cv/output/Landmark.java
100.00% <ø> (ø)

...main/java/ai/djl/modality/cv/output/Rectangle.java
72.41% <ø> (ø)

...i/djl/modality/cv/translator/BigGANTranslator.java
21.42% <ø> (-5.24%)
:arrow_down:

...odality/cv/translator/BigGANTranslatorFactory.java
33.33% <0.00%> (+8.33%)
:arrow_up:

...nslator/InstanceSegmentationTranslatorFactory.java
14.28% <0.00%> (-3.90%)
:arrow_down:

.../ai/djl/modality/cv/translator/YoloTranslator.java
8.33% <0.00%> (-0.50%)
:arrow_down:

.../modality/cv/translator/YoloTranslatorFactory.java
8.33% <0.00%> (-1.67%)
:arrow_down:

...i/djl/modality/cv/translator/YoloV5Translator.java
5.38% <0.00%> (-0.31%)
:arrow_down:

... and 251 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b43a10...318917e. Read the comment docs.

@zachgk can you take a look? LGTM


Witchery

Whenever attempting to use mutandis on a sapling it immediately turns into the dynamic trees version. Would it be possible to add like a 1 or 2 second delay to allow for mods that do things like this?

For those of us that haven't touched witchery in a while. What does mutandis do? What do you get out of it and why would the delay be nescesary?

Mutandis is an item than when used on certain saplings (oak, birch, and
jungle I believe) it turns them into a new sapling (such as Rowan,
hawthorn, and alder depending on the sapling). This delay would allow
someone to be able to change the type of tree before it changes into the
dynamic version.
On Sat, Jun 1, 2019, 01:38 Deshiba<EMAIL_ADDRESS>wrote:

For those of us that haven't touched witchery in a while. What does
mutandis do? What do you get out of it and why would the delay be nescesary?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ferreusveritas/DynamicTrees/issues/264?email_source=notifications&email_token=AME4JQU5AK6GPMDBWJXLIODPYIKNTA5CNFSM4HPLHC6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWW2FCY#issuecomment-497918603,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AME4JQQ26DODVCC7AZL7NULPYIKNTANCNFSM4HPLHC6A
.

And are you using default config?
You could try to force vanilla saplings trough configuration.
replaceVanillaSapling = config.getBoolean("replaceVanillaSapling", "vanilla", false, "Right clicking with a vanilla sapling places a dynamic sapling instead.");
If this doesn't work then I don't know what's going on.

Ok, thanks!
On Wed, Jun 5, 2019, 02:47 Deshiba<EMAIL_ADDRESS>wrote:

And are you using default config?
You could try to force vanilla saplings trough configuration.
replaceVanillaSapling = config.getBoolean("replaceVanillaSapling",
"vanilla", false, "Right clicking with a vanilla sapling places a dynamic
sapling instead.");
If this doesn't work then I don't know what's going on.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ferreusveritas/DynamicTrees/issues/264?email_source=notifications&email_token=AME4JQT73SBFMMLL24DJKLTPY5VRXA5CNFSM4HPLHC6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW64M2I#issuecomment-498976361,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AME4JQXJDBWHMPSLGGJN62LPY5VRXANCNFSM4HPLHC6A
.


Update README.md

This is really minor, but some other idiots like me may also get confused  at to which api key this reference points at :) You don't want to know how long it took me to wake up to the obvious...

Thanks @anegg0 !


build: fix itest parallelism

The latest ARM build seems to have only ran half of the itests: https://app.travis-ci.com/github/lightningnetwork/lnd/jobs/537407681
This PR attempts to fix itest parallelism by fixing the number of tranches to the parallelism param.

I think this needs to be documented better as I tend to forget it myself as well all the time.
But the idea of having two separate variables (NUM_ITEST_TRANCHES and ITEST_PARALLELISM) is to be able to run the same test in parallel multiple times as part of the flake hunting.
That way I could do make itest-parallel tranches=1 parallel=8 icase=whatever_test to run the same test 8 times in parallel.
So I think we should just fix the Windows and ARM builds by specifying tranches=2 parallel=2 and perhaps document the differences?

Thanks for noticing this by the way! Now I know why the Windows build was always successful, it also only ran half the tests (apparently the "easy" half).

So I think we should just fix the Windows and ARM builds by specifying tranches=2 parallel=2 and perhaps document the differences?

Ah, ok! Sorry I think I remembered this from before now that you said it because I reviewed the original PR adding parallelism just forgot! :)

Thanks for noticing this by the way! Now I know why the Windows build was always successful, it also only ran half the tests (apparently the "easy" half).

Funny because I didn't notice that the windows build was wrong :sweat_smile:

So I think we should just fix the Windows and ARM builds by specifying tranches=2 parallel=2 and perhaps document the differences?

Tbh I think our docs are good, I just didn't pay attention to the details: https://github.com/lightningnetwork/lnd/blob/master/docs/MAKEFILE.md#itest-parallel


Frontend: Add power consumption estimation, fix darkmode

This PR updates darkmode to remember user choice and lets clearing it. Power consumption is now estimated assuming static white color and taking brightness in linear dependency (50% brightness = 50% * 60 mA per LED)

Accidentally pushed some commits directly to main.


Unknow pool name

Ubuntu 14.04
yangyansheng@sensebox-52:~/NNPACK$ python configure.py
Detected root directory: /home/users/yyansheng/NNPACK
Configuring dependency pthreadpool
Configuring dependency fxdiv
Configuring dependency googletest
Configuring dependency googlebenchmark
Configuring dependency fp16
Configuring dependency psimd
Module default: 1 libraries, 5 executables, 46 tests (12 smoke tests)
yangyansheng@sensebox-52:~/NNPACK$ ninja
ninja: error: build.ninja:57: unknown pool name

see #54

With Maratyszcza/confu@6f50fda60ae27f27956a0336a01c1e92d593aff4 old Ninja versions would now report a clearer error message:
ninja: fatal: ninja version (1.5.1) incompatible with build file ninja_required_version version (1.7).


ToastConfig Options Gone with 6.0

Please check all of the platforms you are having the issue on

[] iOS
[] Android
[] UWP
[X] PCL

Please state the issue to the best of your ability below

Before version 6.0 ToastConfig had options such as SuccessTextColor, SuccessBackgroundColor and more for errors and for warnings. Those properties are not available anymore. I also do not see the properties after doing a quick GitHub search of the repo. Though I do see the properties listed under PromptConfig in the readme but they are not available in code.

Please copy and paste the exception details below.  If you are having a crash and this detail is missing, your issue will be closed without warning.

Cannot resolve symbol 'SuccessTextColor'

They have been removed as part of the new controls used.  I haven't had time to update the documentation.


-[UITableView setEmptyDataSetSource:]: unrecognized selector sent to instance 0x116137800

/*set */
self.tableView.emptyDataSetSource = self;
self.tableView.emptyDataSetDelegate = self;
it can not work.

I kept the agreement（DZNEmptyDataSetSource,DZNEmptyDataSetDelegate）

me too, I don't know why

@kvcc @LimingZou   set Build Phases -> Link Binary With Libraries Add libDZNEmptyDataSet.a   Done  亲测好用 (^o^)/~

@kvcc @LimingZou     You could have a try .

adding  libDZNEmptyDataSet.a gave too many errors

while working with DZNEmptyDataSet, TableView.emptyDataSetSource = self; is giving an error and i don't know why, any help?

It can work!

I also attacked this problem , is giving an error and crash , don't know why,  anyone had solved this issue ? any help?

@kvcc @LimingZou set Build Phases -> Link Binary With Libraries Add libDZNEmptyDataSet.a Done 亲测好用 (^o^)/~

libDZNEmptyDataSet.a 怎么制作？


Plugin does not show workflow error messages

What steps will reproduce the problem?
Define a workflow rule on issue state with an error message
Try to change issue state through YouTrack integration plugin
What is the expected result?
We expect to receive a notification in intellij with the custom error message
What happens instead?
Intellij shows a generic error with the stacktrace and not the custom error messate

In addition, if it helps, here's the stacktrace returned by the plugin

The fix is to be included in 0.9.6


Doc: Clarification of ACL filters

Describe ACL filters with https://github.com/apache/trafficserver/pull/11433. Separated PR to do not block the PR by documentation change.

Cherry-picked to v10.0.x


local file cache is not restart safe in some edge cases (SIGKILL of postmaster)

While developing https://github.com/neondatabase/autoscaling/pull/534 , it was discovered that the local file cache free space monitor can remain running after the rest of the postgres processes is gone, e.g., due to OOM kill.
If something then restarts the postgres process (init in the case of NeonVM), the old free space monitor process can interfere with the restarted postgres process.
Option A: remove free space monitor.
Option B: somehow make the file cache restart safe

I assume this issue has been resolved with https://github.com/neondatabase/neon/pull/5406? (Free free to reopen if I'm wrong)

It's released


Allow for predefined filter elements

For external filters, it would be nice to be able to

Specify a selector containing a predefined filter element.
Specify a function to obtain the selected filter value for a filter function.

This would allow for greater flexibility (looking through the other issues - it would allow the user to: define a time filter, radio button filter, placing filters in a popover, etc.) with a reduced need for Javascript manipulating the DOM (resulting in better performance).

You can easily achive it by using the exFilterColumn , you can use it with any input type you wish...


refactor(send): Refactored message send

PR related to this trello task --> https://trello.com/c/DZEfgcTr

:tada: This PR is included in version 1.9.0 :tada:
Your semantic-release bot :package::rocket:


[proposal] add docs how to deploy to gcp

Hi,
I was very impressed by livekit, especially when I saw that you have an official client package for flutter,  I saw that you have guides on how to deploy the server to aws, I'm just wondering if you can add docs to deploy on Google cloud platform?
Thank you

Hi, we do have guides now on GCP deployment (using a config generator). You can either deploy via VMs or Kubernetes. See docs


Prefix packages and classes with AI

Fixes #5

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-88.1%) to 0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-88.1%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


Not showing up in recource packs

When I download this, it does not show up in my resources to pick from in-game.

Uh this is a mod not a resource pack


Use after free in Michael-Scott queue?

Queues that suffer from the problem:

MsQueue
SegQueue
channel::unbounded() (see #237, thanks to @Pslydhh)
Queue in crossbeam-epoch

Consider the following scenario in MsQueue...
Suppose the current epoch is E. The queue is empty, meaning head and tail are pointing to the sentinel node (let's call it node0).
In other words, head = node0, tail = node0, node0.next = null.
The following happens next...
Thread T1 gets pinned in epoch E and pushes a new value into the queue by allocating a new node node1 and then it does node0.next.cas(null, node1). The next operation it needs to do is tail.cas(node0, node1), but the thread gets yielded first so tail is still node0.
The queue is now: head = node0, tail = node0, node0.next = node1, node1.next = null.
Thread T2 gets pinned in epoch E and pops a value from the queue with head.cas(node0, node0.next). The CAS succeeds and head becomes node1. Then we call defer_destroy(node0), which means node0 becomes garbage marked with epoch E. The thread then exits.
The queue is now: head = node1, tail = node0, node0.next = node1, node1.next = null.
The global epoch gets advanced to E+1.
Thread T3 gets pinned in epoch E+1 and attempts to push a new value into the queue. It allocates a new node called node2, loads the tail pointer and gets node0. Then, it would attempt to do node0.next.cas(null, node2), but first it yields...
Thread T1 resumes, sets tail to node1, and exits.
The queue is now: head = node1, tail = node1, node1.next = null.
The global epoch is advanced to E+2. Garbage from epoch E is collected and so node0 gets deallocated.
Thread T3 resumes and attempts to continue with node0.next.cas(null, node2), but node0 has been destroyed. This is use-after-free!

To solve this problem, I propose we just relax the invariant used by defer.
Currently, the invariant is: We may use defer to destroy an object only if it will become inaccessible when all active guards get dropped.
I propose we change it to: We may use defer to destroy an object only if it will become inaccessible when all active guards and future guards overlapping with them get dropped.
In other words, instead of saying "call defer if the object is inaccessible" we'd say "call defer if it is inaccessible or if it will become inaccessible before all active guards get dropped".
The PR fixing this would simply change the global_epoch - garbage_epoch >= 2 invariant to global_epoch - garbage_epoch >= 3.
cc @Pslydhh @jeehoonkang

It seems like based on the invariant:

If a thread accesses an unlinked object, it accesses it at most once.
So in the next epoch, it can't.

This looks right to me, now we no need to modify the source code to avoid such errors.

@stjepang If its okay, I would like to work on this

I think this issue is related to #221, especially "Using small epoch numbers" in https://github.com/crossbeam-rs/crossbeam/issues/221#issuecomment-502434210 .  This can also solve the problem of epoch wraparound.  I'll write down more details soon.

Thanks a lot @jeehoonkang. It will be much appreciated as I am new to rust and to crossbeam. I am very interested in concurrency and crossbeam. Thanks again.

@stjepang Thank you for reporting this.  It seems much deeper than I first expected...  I'd like to spend a little bit more thinking on this issue...

Any updates @jeehoonkang ? Anything I can start looking at ?
On Thu, Aug 8, 2019, 22:03 Jeehoon Kang<EMAIL_ADDRESS>wrote:

@stjepang https://github.com/stjepang Thank you for reporting this. It
seems much deeper than I first expected... I'd like to spend a little bit
more thinking on this issue...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/crossbeam-rs/crossbeam/issues/238?email_source=notifications&email_token=AG3EF4LODVPKUVNQQ75CMGTQDT3DXA5CNFSM4GGWVPYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD35THHI#issuecomment-519779229,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG3EF4O3RWARAYKS5QKV54LQDT3DXANCNFSM4GGWVPYA
.

Hi @blitzerr. I discussed this problem with @jeehoonkang and here is the summary.
TL;DR;

It's enough to tag the block with the local epoch in which it was defer_destroy'd. Using the global epoch is fine too, but it's an overkill.
If the garbage is tagged with E, it can be free'd in E+3.
We've already implemented above changes as a part of our recent project, along with many other things. We are planning to merge some of them into crossbeam upstream. The paper summarizes hazard pointer and EBR (with E+3 reclamation scheme as described above) and proposes a new scheme that integrates HP and EBR.

Details

I'll use some figures and notations from our paper.
It's basically a re-statement of the example @stjepang gave.

Requirement for retirement (defer_destroy) under "free when current_epoch -  garbage_local_epoch >= 3 scheme"

If a block b is retired in epoch E, then b should be unreachable in epoch >= E+2. That is, b should be unlinked from the shared memory (all references to b are removed) before the global epoch advances to E+2.

According to the figure 5 in the paper, use-after-free cannot occur if this condition is met. In fact, this requirement is just a direct description of the figure.
Note that Requirement 2.1 from the paper implies this requirement. Requirement 2.1 can be used for proving safety of some algorithm under EBR. However, Requirement 2.1 doesn't apply to MSQueue as you can see in the example by stjepang. (Queue::pop_internal fails to completely unlink the head from the shared memory if self.head and self.tail coincide.) So we have to show that the more general requirement presented above holds for MSQueue.
MSQueue satisfies the requirement
The only interesting situation is the setting where defer_destroy is called on head (snapshot of self.head in pop) when self.head and self.tail coincide, because this is the only case that doesn't satisfy Requirement 2.1.
Since it seems that the example stjepang gave is the only possible case, I'll use the notations from it.
Claim: All references to node0 in shared memory are removed before the global epoch advances to E+2.

In order for the global epoch to advance to E+2, T1 should quit epoch E.
In order for T1 to quit E, T1 should finish executing let _ = self.tail.compare_and_set(onto, new, Release, guard); in push_internal. The result doesn't matter since both cases imply that self.tail no longer points to node0.

Remark

I'm sorry for the late reply.
I think there might be a general way to characterize an algorithm that is compatible with EBR with "free when current_epoch -  garbage_local_epoch >= n" scheme.
Please let us know if you have any questions or opinions about this issue and our paper!

@stjepang We actually found out that E+3 free is still buggy because of the similar scenario in which
the thread 2 first pins at E and sleeps until the thread 1 pins at E+1 and gets yielded just before the pushing CAS as in your scenario. So in this scenario the actual sequence of modifications of the queue is identical but the epoch in which the "real unlinking" happens at E+1 instead of E. In this case, a thread that pins at E+2 may access the retired node0 via tail. So even if deallocation of node0 is deferred to E+3, there is no happens-before relation between this access and deallocation.
The real problem is that the implementation doesn't faithfully follow the original MSQueue algorithm. The original pop function advances tail pointer in cases like this scenario so that defer_destroy is called only for nodes that are actually unlinked. This is what other implementations do, e.g. libcds.
Another approach is to advance the tail pointer if the head CAS succeeds.

@twmb Well, actually there is, it's crossbeam-deque ;).

Use-after-free could be an exploitable security vulnerability. Please make a semver-compatible release with a fix and file a security advisory so that dependent crates would know to upgrade to a fixed version.


Race Condition found in Entity.AddException when Concurrently Adding Subsegments

I've identified a race condition in the Entity.AddException method when subsegments are being added concurrently. The issue arises from the concurrent access and modification of the _lazySubsegments list, which can lead to unpredictable behavior or exceptions during the execution of the DescribeException method within AddException. I am using powertools-lambda-dotnet, but after digging into the logs I found the issue originates from aws-xray-sdk-dotnet.

Steps to Reproduce:
While a definitive reproduction might be challenging due to the non-deterministic nature of race conditions, here's a scenario that increases the likelihood of encountering the issue:

Create an instance of Entity (e.g., a Segment).
In one thread, trigger the AddException method on the Entity instance.
Concurrently, in another thread or multiple threads, repeatedly call AddSubsegment on the same Entity instance to simulate concurrent modifications to the _lazySubsegments list.
Observe if any exceptions, such as InvalidOperationException, are thrown during the execution of AddException or subsequent operations.

I've setup the following code snippet to simulate the error:
var entity = new Segment("TestSegment");
const int EXCEPTION_ITERATIONS = 100;
const int SUBSEGMENT_ITERATIONS = 100_000;

var raceConditionOccurred = false;
string? exceptionMessage = null;
var cancellationTokenSource = new CancellationTokenSource();

// Thread 1: Trigger AddException
var addExceptionTask = Task.Run(() =>
{
    Parallel.ForEach(Enumerable.Range(0, EXCEPTION_ITERATIONS), _ =>
    {
        try
        {
            var exception = new Exception("Test Exception");
            entity.AddException(exception);
        }
        catch (InvalidOperationException ex)
        {
            raceConditionOccurred = true;
            exceptionMessage = ex.Message;
            cancellationTokenSource.Cancel();
        }
    });
});

// Thread 2: Add Subsegments concurrently using Parallel.ForEach
var addSubsegmentsTask = Task.Run(() =>
{
    try
    {
        Parallel.ForEach(Enumerable.Range(0, SUBSEGMENT_ITERATIONS), new ParallelOptions { CancellationToken = cancellationTokenSource.Token }, _ =>
        {
            entity.AddSubsegment(new Subsegment("TestSubsegment"));
        });
    }
    catch (OperationCanceledException) { }
});

Task.WaitAll(addExceptionTask, addSubsegmentsTask);

if (raceConditionOccurred)
{
    _output.WriteLine($"Race condition error occurred: {exceptionMessage}");
}

Assert.True(raceConditionOccurred, "Expected a race condition error but none occurred.");

Expected Behavior:
The AddException method should execute correctly even when subsegments are being added concurrently, without throwing any exceptions or causing data inconsistencies.
Suggested Fix:
Add a lock to ensure thread-safe access to the _lazySubsegments list during the execution of Entity.AddException(Exception e).
 /// <summary>
 /// Adds the exception to cause and set this segment to has fault.
 /// </summary>
 /// <param name="e">The exception to be added.</param>
 public void AddException(Exception e)
 {
     HasFault = true;
     Cause = new Cause();
     List<Subsegment> subsegmentsCopy;
     lock (_lazySubsegments.Value)
     {
         subsegmentsCopy = [.. _lazySubsegments.Value]; // Create a copy to avoid holding the lock during serialization
     }

     Cause.AddException(AWSXRayRecorder.Instance.ExceptionSerializationStrategy.DescribeException(e, subsegmentsCopy));
 }

Hi there,
Any updates on this issue? By the way, I already have an open PR addressing it: PR #307.

Hi Luiz, the PR has been reviewed and merged. Thank you for contribution!

Awesome! Thanks, Vastin.


Support collapsing adjacent borders into one

This would make things look better in elements like tables. For reference, see https://developer.mozilla.org/en-US/docs/Web/CSS/border-collapse.

This is no longer relevant because table cells no longer have borders by default; if there is ever a sufficiently frequent use case of table cell borders that requires this, this can be reopened.


Handle Decimal-128 Multiplication For Newer Spark Versions

This PR adds a new method for multiplying two Decimal 128-bit numbers without casting the interim result before casting to the scale the final answer is expected to be in.
When multiplying two decimal numbers with a precision of 38, earlier versions of Spark are capped by the precision of 38 which causes the answer to be casted twice essentially, once right after multiplication and once before reporting the final answer which leads to the answer being inaccurate.
For more details please look at the Spark issue which explains the issue in greater detail.
Changes Made:

Added a boolean param to control whether to apply the interim cast.
Added a new multiply128 method that takes in interimCast boolean.
Added a warning to the old method to highlight that it knowingly adds a bug to the multiplication to match Spark versions

Tests:

Added a unit test

related to https://github.com/NVIDIA/spark-rapids/issues/9859

@tgravescs I think I have answered your previous comment. Do you have any other comments?

build

build

build

CI failing because of
undefined reference to `cudf::jni::multiply_decimal128(cudf::column_view const&, cudf::column_view const&, int, bool const&, rmm::cuda_stream_view)'

but passes locally even after doing a clean build

build

build

Thanks @ttnghia I will file a follow-on for the line length! appreciate your help


CI: use bugtool and debuginfo to gather logs

Use the bugtool and debuginfo when tests fail and save the logs to the directory which is tar'd up and saved as an artifact in Jenkins. Move away from custom report generation scripts in favor of using these tools, as dogfooding them in the CI will allow for discovery of deficiencies / gaps.

[ ] Runtime tests
[ ] K8s tests

I've done this for runtime tests in https://github.com/cilium/cilium/pull/3030/ .


Remove hack around now fixed chrome bug in proxy config

We introduced a fix to work around a chrome bug in its proxy API. The bug (https://code.google.com/p/chromium/issues/detail?id=448172) has now been fixed. So we should now revert/simplify the fix we added here: https://github.com/uProxy/uproxy/pull/778

Done https://github.com/uProxy/uproxy/pull/1206


astuart.co is down

It seems to be up now, at least. If you have the issue again, you can always just import github.com/andrewstuart/goq. It should be the same thing. :-)

Seems to be down again.
Also note that just changing the import name wont work, you need to use replace for this.
Adding something like this to your go.mod should fix the problem:
replace astuart.co/goq => github.com/andrewstuart/goq v1.0.0


API Server Flags for Aggregation Layer

According to https://kubernetes.io/docs/tasks/access-kubernetes-api/configure-aggregation-layer/
This aggregator documentation says to use these flags, but I believe these flags require an authenticating proxy. The documentation doesn’t talk about an authenticating proxy. Can you help me understand if the authenticating proxy is required? Are all the flags required? If not, when are they required?
Particularly, I'm interested in the for the following flags:
--requestheader-extra-headers-prefix=X-Remote-Extra-
--requestheader-group-headers=X-Remote-Group
--requestheader-username-headers=X-Remote-User

The future of the Kubernetes aggregation layer is uncertain; prefer using CRDs where possible.

The metrics server, as documented at https://kubernetes.io/docs/tasks/debug-application-cluster/core-metrics-pipeline/ uses the API aggregation and recommends these flags. To use the metrics server, CRDs are not currently possible, are they?
Towards that end, we'd love to understand these flags better, if you can help us understand them.
Thanks!

/triage support
https://kubernetes.io/docs/reference/access-authn-authz/authentication/#authenticating-proxy
these flags defines how the delegated authenticator extracts user informations from the requests, they are optional.


Add sustain, octave shift, and volume control

Notes now have sustain, both via the mouse and keyboard. So you enter the Simon melody at your own pace.
The current octave can be shifted up or down with N/M or the mouse. Volume can be controlled with V/B or the mouse. (Lowering the volume helps with distortion.)
The Space key stops all active sounds. As a side effect of the new sustained notes and how the program handles them, you can now create an endless note by clicking a key and moving the mouse away, then releasing the mouse button.

Really awesome, thank you so much for your incredible contributions so far.
One thing I noticed is that the volume seems to max itself when you switch octaves, though the volume indicator still displays whatever volume level you were previously on. This would be worth looking into if you end up getting a chance. Thanks again!


Updating points of an imported skill that has selfReportTye of Quiz fails

Proj1: create a skill and associate a quiz to it; expor that skill to the catalog
Proj2: import that quiz-based skill
when /admin/projects/<project-id>/import/skills/<skill-id> endpoint is called it fails with 2 scenarios:
Scenario 1: project already has user with points
s.c.exceptions.RestExceptionHandler : PATCH uri=/admin/projects/withpointsprojid/import/skills/newquizthingSkill, Unexpected  Error

java.lang.IllegalArgumentException: Parameter of type String at index 0 in QuizDefRepo.findByQuizIdIgnoreCase must not be null at

Scenario 2: project doesn't have any users with points
s.c.exceptions.RestExceptionHandler      : PATCH uri=/admin/projects/emptyprojectid/import/skills/newquizthingSkill, Unexpected Error

java.lang.IllegalArgumentException: Parameter of type Integer at index 2 in UserAchievedLevelRepo.removeProjectLevelAchievementsIfUsersDoNotQualify must not be null

:+1:


Remove usage of Unsafe from UnscaledDecimal128Arithmetic

I don't think that benchmark is valid. I ran a subset of them several times with no code changes and saw large variations, well outside the error bounds. When comparing old/new, the new code was actually faster for some benchmarks, though I suspect this is due to instability in the benchmark.

You should increase the number of warmups, measurements and forks to get a a better sample

I guess the impact would be minimal anyway, so we can as well merge it


Add detection support for newer versions of VMProtect.

Since version 2.04, every protected file has a public signature (detected with a YARA rule) and
the checksum of the first 64 DWORDS in the last executable section is always constant despite the
bytes in that part being different.
In addition, the tests were added here

Let's run TeamCity tests.

Let's run TeamCity tests.

Let's run TeamCity tests.

That macOS fail is caused by #702 (not by the present PR). However, the Linux build is unfortunately still failing. I will try to debug it. There is either another bug, or the build did not run with the fix, or there is something else going on.

The build has run for ec1cc47c24003329373e540dd72393a14e7ccc24, which is currently the latest commit in this PR. So, the build has run with the fix.

I am able to reproduce the issue when using this Dockerfile. However, I was not yet able to determine the exact cause as when I start debugging the issue, the problems seem to go away. I will investigate it further. I just wanted to let you know about the progress.

Let's run TeamCity tests.

Alright, so, even after about 6 hours of debugging, I was unable to determine the real cause. Here is a couple of notes:

retdec-fileinfo was crashing due to the changes in PeHeuristics::getVmProtectHeuristics() in this PR. Here is a backtrace from gdb:#0  0x00005555558618b8 in retdec::cpdetect::PeHeuristics::getVmProtectHeuristics() ()
#1  0x000055555586f531 in retdec::cpdetect::PeHeuristics::getFormatSpecificCompilerHeuristics() ()
#2  0x000055555583ec12 in retdec::cpdetect::CompilerDetector::getAllCompilers() ()
#3  0x000055555584050b in retdec::cpdetect::CompilerDetector::getAllInformation() ()
#4  0x0000555555666ee1 in retdec::fileinfo::FileDetector::getCompilerInformation() ()
#5  0x00005555556677ac in retdec::fileinfo::FileDetector::getAllInformation() ()
#6  0x0000555555614bc0 in main ()

Line information is not available as the crashes are only reproducible in a release build.
The crash was only reproducible with GCC 7 in Ubuntu (this is what the Linux TC agent runs). I was able to reproduce it by using this Dockerfile.
The crash was only reproducible with the Release build type. If I tried a different build type (even RelWithDebInfo), it stopped crashing.
I have tried upgrading GCC 7 from 7.4.0 to 7.5.0, but to no avail (it did not fixed the crashing).
valgrind did not report any errors apart from retdec-fileinfo crashing with the backtrace above. I have tried several different build types with several different compilers.
When I tried to debug the code by manually inserting debug prints, the crashing stopped. The crashing also stopped when I modified the computing of the checksum.
The crash appeared to happen on the following line:checksum += *reinterpret_cast<const std::uint32_t*>(&data[i * 4]);

However, when I simply printed the obtained integers, the code worked without any issues.
The memory returned by section->getBytes() and stored in data seemed to be valid.

I do not know how to debug this further. I believe this to be a compiler bug. I would really like to know this for sure, but I do not have the time nor will to debug it further.
Nevertheless, I was able to modify the code so it is more readable and the Linux TC build no longer fails. @tamaroth: If the current code is OK from your point of view, we can merge the PR as all the tests pass now.

Thank you for your thorough investigation. If it crashed only on a specific version and only when placed directly in the checksum computing loop, perhaps there was a bug in optimisation? Hard to tell.
Again, thank you for your code review and updated code, it will be useful in the future.
The code looks good to me! :+1:


Script for seeding category data from S3

Description

#866
Depends on https://github.com/chanzuckerberg/napari-hub/pull/986
This PR adds a script for seeding category data from the S3 bucket. This works by adding a general purpose run_workflow.py script that can be run manually to run a particular workflow from CLI, or by importing the run_workflow() function. This will allow us to run the same scripts in our workflows locally and from the data-workflows lambda.
To seed category data from S3, run the run_workflow.py script:
AWS_PROFILE=sci-imaging \
  BUCKET=<bucket> \
  STACK_NAME=<stack-name>
  python run_workflow.py seed-s3-categories \
  --edam-version EDAM-BIOIMAGING:alpha06 \
  --s3_path category/EDAM-BIOIMAGING/alpha06.json

For example, this is the command I used for testing:
AWS_PROFILE=sci-imaging \
  BUCKET=napari-hub-dev \
  STACK_NAME=dev-test-cat \
  python run_workflow.py seed-s3-categories \
  --edam-version EDAM-BIOIMAGING:alpha06 \
  --s3_path category/EDAM-BIOIMAGING/alpha06.json

The workflow can also be run from Python using:
from run_workflow import run_workflow

run_workflow({
    'type': 'seed-s3-categories',
    'edam_version': 'EDAM-BIOIMAGING:alpha06',
    's3_path': 'category/EDAM-BIOIMAGING/alpha06.json',
})

Demos

List of first 50 categories in Dynamo

I believe we were holding off on incorporating changes from https://github.com/chanzuckerberg/napari-hub/pull/986 until Kevin's ETL PR was merged, to avoid conflicts that might be harder to resolve on his end.


Hide download PDF button when PdfGenerator is not available.

This broke in commit 7823ba2502995382cfd52946910e88dbc41d25ba where toolbar button images were replaced by font awesome icons
Fixes #5518
@dclarizio please review.

screenshots with Prince installed buttons is visible:

screenshots without Prince button is hidden:

One other minor comment...since Prince is nowhere in the code in this PR, change the it descriptions, PR title, and commit message to say "when PdfGenerator is not available"

@h-kataria : can we reformulate the test so that we do not depend on image or icon? there's an in, can we use that, please?

@martinpovolny please re-review

@h-kataria : cool, I think it's much better to test a list of IDs rather than icon or image
well at least before we refactor all of the toolbar building ;-)
please, merge, once travis is green


Inline css

Hi,
How can I add inline css in newsletter on click export.
Now export newsletter generate internal css but i want inline css.
Please help me regarding this.
Thanks,

Check https://github.com/artf/grapesjs-preset-newsletter/blob/master/src/openExportCommand.js to see how I've done it inside the newsletter preset

Thanks for Help this is nice example

Hi Team,
I have my own newsletter code imported to Grape JS with Internal CSS. When I click on view code the code is converted to inline. Is it possible to have my code as it is with internal

@artf How to do it in case of ReactJS?
const [editor, setEditor] = useState(null);
useEffect(() => {
const editor = grapesjs.init({
container: '#editor',
plugins: [gjsPresetNewsletter, thePlugin],
pluginsOpts: {
'gjsPresetNewsletter': {
tableStyle: {width: '600px', padding: '10px 10px 10px 10px'}
},
thePlugin:{}
  }
});
setEditor(editor);

}, [])
return (

  </div>
</div>

);


Do we still want to keep the .NET 5 as an option?

I'm now seeing this warning on compile in my experimental branch.

warning NETSDK1138: The target framework 'net5.0' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

Microsoft's Download .NET 5.0 reads:

This release has reached end of life, meaning it is no longer supported. We recommend moving to a supported release, such as .NET 7.0. See our support policy for more details.

I don't see any problem with leaving it available, except for the possibility that a security flaw might be discovered in .NET 5.
I will continue to work with .NET 5 until I hear otherwise.

Naw, there is no need to stay on .NET 5. Feel free to upgrade it and submit a PR, or if that's a bit of a hassle because of  changes made in your fork/branch then lemme know and I can git 'er don

Scratch that. Yeah, lets keep it.
I'm making all my math/numeric libraries have the same set of target frameworks, and this set includes .NET 5.
The reason I'm making all my libraries support the same set of target frameworks is because I have a 'generic arithmetic' library that performs arithmetic on the generic type T, which my GenericPolynomial and GenericMultivaritePolynomial libraries use, and the test projects for these generic polynomial libraries take a dependency on BigDecimal, BigRational, BigComplex, and so on and its hard to test against a target framework unless all these libraries also target it, so I'm standardizing the set of target frameworks across all of them.
In regards to security, I think it is unlikely that anything we are doing is going to result in a security problem; we are not deserializing arbitrary data, we are not writing to the filesystem or making system API calls, we are not elevating privileges and we are not using pointers or unsafe code or anything like that, so I think the risk is low.


Add ability to pass in arguments to resolve method

If user passes in an argument to the resolve method the library shouldn't treat this as an error. This may not be the best practice but just in case someone needs to wait till that promise has been resolved
to fire an action from there, this update will handle it appropriately.

Hmmm... This is how <v2.x did it, but it seemed like a better practice to force reject for errors.
You may not have noticed that there is a returnRejectedSubmitPromise config option that will let you run code after an error has been returned. Don't you think this is sufficient?
Excellent PR, btw; I'm just not sure it's the direction the library should go. But feel free to convince me otherwise.

Thanks for the review @erikras! I can only see two scenarios where this would be helpful. Debugging and using the value after the promise has been resolved using the then method.
While getting up to speed with the library I wasn't aware that if I passed a valid object to resolve that it would treat it as an error. Since I'm already handling the action, the success response still fired, but the rest of the form validation didn't. Once I realized this caused it, everything else worked as expected.
The second use case is probably not necessary in such a niche part of the validation flow since the user should only be firing one for the piece they want to validate. But just in case they did want to, they could here.
To give you a bit more context this is what my code looked like before and after.
const handleTwitterError = (result, resolve, reject) => {
  if (result.error && result.error.data) {
    return reject({username: 'Sorry, that user does not exist'});
  }
-return resolve(result);
+return resolve();
};

const handleEmailError = (data, resolve, reject) => {
  if (data) {
    return reject({email: 'Sorry, that email has already been used'});
  }
-return resolve(data);
+return resolve();
};

OH!! I didn't notice that this was just on asyncValidate.
So the main problem is:

It makes sense to force errors to come via promise rejection on submit, because your submit action might want to return a value, such as the canonical record from the database.
Your reasoning also makes sense for async to allow errors on promise resolution, since it doesn't make any sense to ever pass anything other than {} back from a successful async validation.
It feels a little inconsistent to have those behave differently.

I suspect that # 2 is strong enough to outweigh # 3.
Please add the test cases to handleSubmit.spec.js to make sure that the submit will not go through if asyncValidate returns a promise that resolves to anything other than {}.

Hey @erikras thanks again for helping think through the solution. Just so we are on the same path, my intention with this was not to resolve errors but to handle success responses. My functions could be named better to describe that it handles errors but also if the response is successful it would resolve those. Essentially handling either success or failure.
Users of the library probably shouldn't do anything with the successful response since that should be an action from the API call. But figured it would be best for the library to not stop async validation if they resolve with successful data.

I'm going to close this, because whatever comes of the discussion on #602 will probably supersede this.


All but the very top of the div crops out

With the whole image present and visible on screen in the canvas, html2cavas is cropping out most of the bottom of the image.
Console logs show cropping to a 1401 x 79 image, only showing the very top as a bar. This problem replicates nearly every time html2cavas is used but occasionally will show much more of the canvas and only missing a bit from the bottom.

The code snippet-
 if (canvas) {
	var saveLink = document.createElement('a');
	saveLink.href = canvas.toDataURL("image/png").replace("image/png", "image/octet-stream");
	saveLink.download = 'name.png';
	saveLink.click();
}

Hi @ngduser, it's possible you're running into the issue of offscreen rendering, which I've created a pull request to address here. If that is indeed your problem, you might find a solution by using my latest build here, which incorporates that PR as well as a few other bugfixes/features.
It's also worth checking that the root element you're sending to html2canvas has the size you think it does, because the final canvas will be cropped to the size of that element. So for instance if that element has a height of only 79px but has overflow: visible set, you may see more than 79px of content but the element is still only 79px tall.

Thanks for the response.
It doesn't look like either of those issues apply here, the image is entirely onscreen and the full size shows up and is added to html2canvas, as shown in the log above.
This is the image-

And after html2canvas crops it-

.
There is no single element or group which makes up the output I receive, it is strange.

From the logs you posted:

line 2: initial canvas size is 1920 x 653 (screen/window size)
line 15: top: 574 means that the top of your root element is at 574px (using getBoundingClientRect())
653 - 574 = 79px, the height you're receiving
all signs point to this being an "offscreen rendering" problem - if your window is 653px tall and the start of your element is at 574px, then most of your element is offscreen

Again, I recommend trying this build and see if it fixes your problem. Otherwise it would help if you could post a jsFiddle illustrating the issue.

@eKoopmans I was having a similar issue, that build fixed the issue. Thanks.


superRDP2 under virtual environement

does not work in a virtual machine
error message: "Sorry this application cannot run under a Virtual Machine"

#118 here


Changed the name of the setting 'Run Magic Commands'

to 'Run Startup Commands'.
For #6842

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[x] Has a news entry file (remember to thank yourself!)
[ ] Appropriate comments and documentation strings in the code
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated
[ ] Test plan is updated as appropriate
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #7163 into master will decrease coverage by 0.42%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #7163      +/-   ##
==========================================
- Coverage   58.48%   58.05%   -0.43%
==========================================
  Files         485      485
  Lines       21446    21446
  Branches     3462     3457       -5
==========================================
- Hits        12542    12450      -92
- Misses       8123     8211      +88
- Partials      781      785       +4

Impacted Files
Coverage Δ

src/client/common/types.ts
100% <ø> (ø)
:arrow_up:

...atascience/interactive-window/interactiveWindow.ts
7.38% <0%> (ø)
:arrow_up:

src/client/testing/serviceRegistry.ts
48.64% <0%> (-46.85%)
:arrow_down:

src/client/testing/codeLenses/main.ts
44.44% <0%> (-33.34%)
:arrow_down:

...t/datascience/jupyter/jupyterDataRateLimitError.ts
66.66% <0%> (-33.34%)
:arrow_down:

src/client/formatters/serviceRegistry.ts
75% <0%> (-25%)
:arrow_down:

src/client/api.ts
62.5% <0%> (-25%)
:arrow_down:

src/client/common/utils/platform.ts
64.7% <0%> (-23.53%)
:arrow_down:

src/client/common/utils/icons.ts
83.33% <0%> (-16.67%)
:arrow_down:

src/client/datascience/cellFactory.ts
75.86% <0%> (-13.8%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39cf9e0...047cc97. Read the comment docs.


Can't import an image in an existing sprite

The first one does almost nothing but may be related to another because they both used to not happen around the same time.
Steps to reproduce the bug

go to piskelapp.com
import an image
copy part of the image onto another frame

Environment details

operating system: Windows
browser (or offline application version): Google and Bing

Sprite details

number of frames: any
sprite resolution: any
session duration: any

---------------------------------Second---------------------------------
Whenever I try to drag & drop an image the browser tab refreshes automatically. This means I can only import a single image because the import tool can't add to existing sprites.
Steps to reproduce the bug

go to piskelapp.com
drag an image file over the browser

Environment details

operating system: Windows
browser (or offline application version): Google and Bing

Sprite details

number of frames: these are all consistent for me
sprite resolution: any
session duration: any

Feel free to include a screenshot of the bug, a .piskel file of the sprite or anything else that can help us investigate.

Thanks for filing.
The copy/paste is not really intuitive but normally works, so I'll just add the steps here:
1 - choose a selection tool
2 - select an area on the screen
3 - copy (ctrl+c) or cut (ctrl+x) (or cmd+c and cmd+x if on Mac)
4 - move your selection (don't switch tools, just click and drag the selected area, you should see the cursor change)
5 - paste (ctrl+v or cmd+v)

Whenever I try to drag & drop an image the browser tab refreshes automatically. This means I can only import a single image because the import tool can't add to existing sprites.

Drag and dropping images in Piskel should also add them to your sprite, provided your sprite size is big enough to contain them. Make sure your sprite resolution is bigger than the image resolution before trying to drag and drop any image.
Also a small precision, but you have to drop the image in the Piskel user interface. If you drag and drop the image on the actual browser tab, the tab will be reloaded and I can't do much about that.
When you say "Google and Bing", do you mean the search engines? I need to know the actual browser used: on Windows it's usually either Chrome, Firefox, Edge or Internet Explorer.

Thanks for the help! Turns out this is a problem with my browser for the
record.
On Fri, Feb 3, 2017 at 1:48 AM, Julian Descottes<EMAIL_ADDRESS>wrote:

Thanks for filing.
The copy/paste is not really intuitive but normally works, so I'll just
add the steps here:
1 - choose a selection tool
2 - select an area on the screen
3 - copy (ctrl+c) or cut (ctrl+x) (or cmd+c and cmd+x if on Mac)
4 - move your selection (don't switch tools, just click and drag the
selected area, you should see the cursor change)
5 - paste (ctrl+v or cmd+v)
Whenever I try to drag & drop an image the browser tab refreshes
automatically. This means I can only import a single image because the
import tool can't add to existing sprites.
Drag and dropping images in Piskel should also add them to your sprite,
provided your sprite size is big enough to contain them. Make sure your
sprite resolution is bigger than the image resolution before trying to drag
and drop any image.
Also a small precision, but you have to drop the image in the Piskel user
interface. If you drag and drop the image on the actual browser tab, the
tab will be reloaded and I can't do much about that.
When you say "Google and Bing", do you mean the search engines? I need to
know the actual browser used: on Windows it's usually either Chrome,
Firefox, Edge or Internet Explorer.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/juliandescottes/piskel/issues/632#issuecomment-277206338,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYVnhJjJ7se-ZUx1u7JuotYGOnSXSTpzks5rYvfwgaJpZM4L15iV
.

Thanks for the follow-up @TheOtherCyrus ! Closing.


Reject Brutal, Embrace the superior skiftos

SKIFT IS LOVE SKIFT IS LIFE

OK.

Why did I have to see this?


bugfix:consistent ordering of catalog operations

Closes #25667
In looking at addressing #25667 I found a class of race conditions related to inconsistencies between the ordering of catalog operations against the in-memory Catalog versus how they were written to the WAL. For example, if write calls A and B are both writing to table foo, one might create the table while the other adds some field. If the order of the WAL calls is different than the order of the original invocations the system will fail on restoration, as it'll receive a field addition for a table it hasn't yet created.
The new approach is for the WalOps to be take an OrderedCatalogBatch, which will have been produced by calling apply_catalog_batch. We then sort the WalOps by a newly defined order, putting the catalog ops first, sorted by catalog_sequence_number.
Following on the work in #25642, I've removed the dedicated methods add_meta_cache(), remove_meta_cache(), add_last_cache(), delete_last_cache(), instead relying on the apply_catalog_batch() method.  @hiltontj, can you take a look to make sure this was done safely?

PR and commit subject should be fix: consistent ordering of catalog operations with the space after the :


Cannot make any examples ran

Maybe I am doing something wrong or the versions are out of synch. I am using the latest binaries you have with Neo4j 2.3.3
The first graph traversal example is failing load with following error:
{
"errormessage": "javax.script.ScriptException: groovy.lang.MissingMethodException: No signature of method: org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversalSource.loadGraphML() is applicable for argument types: (java.lang.String) values: [https://raw.githubusercontent.com/tinkerpop/gremlin/2.5.0/data/graph-example-2.xml]"
"success": false
}

And consumption of existing data return some results, but trying to return a property gives following error.
{
"errormessage": "javax.script.ScriptException: groovy.lang.MissingPropertyException: No such property: F01 for class: org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.DefaultGraphTraversal"
"success": false
}

The script used is g.V().hasLabel('RecordEmployee').has('F01','Philip').F01

Try:
g.V().hasLabel('RecordEmployee').has('F01','Philip').values('F01')

Or simply:
g.V().has('RecordEmployee','F01','Philip').values('F01')

Thank you very much. That made it kinda work. But where can I find documentation on this? Both readme.md and gremlin site shows dotted notation no values pipe. I need to know the syntax to return map or something useful. Right now it is ```
{
"success": true
"results": [4]
0:  "Fry"
1:  "Philip"
2:  "Leela"
3:  "Turanga"
}
For two fields from two nodes.
`g.V().hasLabel('RecordEmployee').values('F01','F02')`

I am reading on Tinkerpop 3, it seems that is what this syntax is?

Yes, the latest docs can always be found under http://www.tinkerpop.com.


Add identifier property support for source entity type.

Issue description:

When running refactor on sources, in case if source name is not the same as identifier - we should use identifier, if available.

thanks for PR!


Create new sig for renderspritecard

This sig DOES work!!! is this the only sig that had weird not found issue i cant find issue that doesnt have it?

why even was wildcards there it works without or am i beign goofy

yers they are not even needed i stared at the asembylers

I don't see how this is better, since the signature with wildcards is unique and correct 🤔
Some of the wildcards are there to make the signature resistant to small code changes. For example 83 EC 28 (sub esp, 28) should use a wildcard for the 28, so the signature still works if they decide to add/remove local variables in the function.

That is fair.


[Feat. Req.] Server-Side filtering on Submodel-Descriptors

What is missing?
AssetAdministrationShellRegistries and SubmodelRegistries can get big. Clients may already know what they are looking for and benefit from server-side filtering. This would reduce processing effort and network load.
How should it be fixed?
Allow parameters on the /submodel-descriptors API in the AASRSS and SRSS  such as
/submodel-descriptors?semanticId=someSemanticId
It may make sense to allow the same mechanism for attributes other than semanticId. To what degree this collides with the /submodel-descriptors/{{submodelId}} endpoint - I don't know.

[x] I have signed the required Developer Certificate of Origin (DCO) already.

see also #7 and #204 and many more w.r.t. querying


[user-mover] fix update_metadata issues w/ orgs

This PR makes ImportJob class compatible with organization migrations, this feature was broken after adding update_metadata method in PR#7310, changes:

there are 2 new methods in charge of updating specific user or organization metadata
the generic update_metadata method now updates user, organization or both metadata accordingly
each ImportJob instantiation is stored to allow calling update_metadata after consistency-checks
update_metadata_* expect a non-referenced target_dbhost to support rollback in the future

IMPORTANT

this PR also enables back again some user-mover tests that were disabled on PR#7390
https://github.com/CartoDB/cartodb-platform/pull/1913 must be merged after merging this PR
make "if not nil" comparison more clear, related: https://github.com/CartoDB/cartodb/pull/7395/commits/1d300e07cc60e55440504b8a054e0d0fb5561e8e

@azamorano @luisbosque please review, thanks!

I get the following error when using this code from the "migrator-worker" tool:

PG::Error: ERROR:  cannot execute ALTER ROLE in a read-only transaction

It happens when calling set_database_search_path from configure_database, it works fine when using it the first time to apply on the organization admin but it fails when processing the first user, the reason is that database_host points to the source database and it's in read-only mode.

@zenitraM now it works fine with the migrator tool, I have performed several tests migrating normal users, enterprise users and organizations, etc. thanks!! :)
@azamorano can you review again this? thanks!


Only display 4 PR

Addressed #8

Also ran the file through a prettifier
Also get rid of the comma underneath each PR

Can you please resolve the merge conflict. Sorry for late reply.

Hey, this issue has already been resolved.


add reflexion agent

Was wondering if it made sense to add a reflection auxiliary method to be used within run_step? That way we can handle orthogonal reflection and run_step logics simultaneously. Specifically, if we do that then "CRITIC" can be a reflection implementation that can be used with any run_step logic? Not sure if that makes sense, but just throwing it out there as a thing to perhaps consider.

Was wondering if it made sense to add a reflection auxiliary method to be used within run_step? That way we can handle orthogonal reflection and run_step logics simultaneously. Specifically, if we do that then "CRITIC" can be a reflection implementation that can be used with any run_step logic? Not sure if that makes sense, but just throwing it out there as a thing to perhaps consider. CC: @logan-markewich

For CRITIC, I probably will just implement it for now within run_step to move this along. Self-Reflection can be viewed as a a special case to CRITIC (i.e., no tool use in critique phase, and just rely on the LLM itself to perform the reflection).

Yea I was trying to think of a generic way to do this. Adding a "reflection" method to the agent feels a little too specific though 🤔 unless you meant just a general utils function somewhere (then Maybe that's nice, like a little tool box of agent reasoning tools when building a custom loop?)

I agree having a public method reflection feels a bit too much. Was thinking of it to be a private method, but maybe thats not much different.
I like the sounds of the general utils approach for agents to use. How would you envision implementing something like this?

@nerdai Yea I don't know how feasible or extensible it is, but having a set of tools that have the same API interface to use when designing run_step loops might be useful
I tried doing this at one point, but everything is use-case specific that I wasn't finding it easy to generalize. Maybe a common API interface is just not possible

I've adapted the self reflection class and ported over to #13108 instead. I've listed you (@jerryjliu) as the author for it in the llamahub metadata 😀
As such, I'm closing this PR!

I've adapted the self reflection class and ported over to #13108 instead. I've listed you (@jerryjliu) as the author for it in the llamahub metadata 😀
As such, I'm closing this PR!

lol don't worry about attribution i'm going to say you made it on the outgoing socials

I've adapted the self reflection class and ported over to #13108 instead. I've listed you (@jerryjliu) as the author for it in the llamahub metadata 😀
As such, I'm closing this PR!

lol don't worry about attribution i'm going to say you made it on the outgoing socials

lol i figured as much -- excuse my pedantic nature haha


Remove dependency on sip

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

pyqt contains its own version of sip so depending on the sip package is not needed. In fact it appears to be causing problems since the version of sip in pyqt is a bit older (and needs to be) so installing both is a problem.
xref: https://github.com/conda-forge/pyqt-feedstock/pull/91#issuecomment-741592391

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

Thanks!


unable to install old versions of grails

Problem is described on sdkman slack in thread started by Mick Sickler
"Hi All, starting on 10/13, we have been unable to install grails 2.1.5 to 2.4.4. Error message: Stop! The archive was corrupt and has been removed! Please try installing again."
In ~/.sdkman/tmp/grails-2.3.11.headers.tmp we've got:
HTTP/1.1 302 Found
Server: nginx/1.19.1
Date: Tue, 01 Nov 2022 05:21:11 GMT
Content-Length: 0
Connection: keep-alive
X-Sdkman-ArchiveType: zip
location: http://dist.springframework.org.s3.amazonaws.com/release/GRAILS/grails-2.3.11.zip
HTTP/1.1 403 Forbidden
x-amz-request-id: FNVNJHVT899SP8E1
x-amz-id-2: QW05Gp8teyK0qstD423RG4FgEFOAf/MJkPk0Uxb9toNYQjLPra7GblayDfehVyJv81xc/joHydE=
Content-Type: application/xml
Transfer-Encoding: chunked
Date: Tue, 01 Nov 2022 05:21:11 GMT
Server: AmazonS3
I've checked that some old versions (2.4.3 and 2.3.5) are still available via https://grails.org/download.html

This is affecting me as well. There is a way to copy the zip file and skip the download? Doing this straightforward is not working probably because the script is overwriting the zip file when it is put manually into the ~/,sdkman/tmp directory.

same problem here.
It can install manually.

Download old grails(e.g. 2.3.7).
unzip in to $HOME/.sdkman/candidates/grails/
rename the directory name to 2.3.7 from grails-2.3.7

Then it can select with sdk(java must be 7.x)
But... if i create new Grails app with 2.3.7 and execute grails command, then aperar following error.
| Error Resolve error obtaining dependencies: Failed to read artifact descriptor for xalan:serializer:jar:2.7.1 (Use --stacktrace to see the full trace)
| Error Required Grails build dependencies were not found. This is normally due to internet connectivity issues (such as a misconfigured proxy) or missing repositories in grails-app/conf/BuildConfig.groovy. Please verify your configuration to continue.

(Of course this error is not belongs to SDKMAN.)

+1
Same issue.

+1

Hey all, I've opened an issue with the grails team about this, so hopefully, they will provide us with some new URLs soon. Please hang tight. I'll let you all know when I have some news from their end.

why the double zip extension expectation

@mckenzm That is what the unzip executable spits out by default. Notice the or in that error message.

Hi @puneetbehl, I'd suggest not doing that as this defeats the purpose of why people use SDKMAN. We should rather fix these broken URLs as soon as possible. Please give me a shout if I can help with this in any way.

@puneetbehl it seems like these links are broken again. Would you possibly be able to look into this?

Can you please confirm the exact versions that are experiencing issues? I recently attempted installations of both 2.4.4 and 2.1.5, and they seemed to function without any problems.

Not an sdkman issue, but the grails S3 location. If sdkman has a mirror, we are good?

Unfortunately we don't have a mirror, all the binaries are sourced directly from their source locations.


Basic game of life watchface

Codecov Report

Merging #59 (34ebd56) into main (0aa68fa) will increase coverage by 50.92%.
The diff coverage is 77.77%.

@@              Coverage Diff              @@
##               main      #59       +/-   ##
=============================================
+ Coverage     37.05%   87.98%   +50.92%
- Complexity        0        9        +9
=============================================
  Files            18        6       -12
  Lines           645      208      -437
  Branches         90       15       -75
=============================================
- Hits            239      183       -56
+ Misses          392       17      -375
+ Partials         14        8        -6

Impacted Files
Coverage Δ

.../alexvanyo/composelife/data/GameOfLifeAlgorithm.kt
88.88% <ø> (ø)

...vanyo/composelife/data/NaiveGameOfLifeAlgorithm.kt
95.65% <ø> (ø)

...lexvanyo/composelife/data/model/GameOfLifeState.kt
50.00% <0.00%> (ø)

...com/alexvanyo/composelife/util/BoundsExtensions.kt
100.00% <ø> (ø)

...n/com/alexvanyo/composelife/util/MathExtensions.kt
100.00% <ø> (ø)

...xvanyo/composelife/data/TemporalGameOfLifeState.kt
92.24% <100.00%> (ø)

...poselife/ui/util/CustomTransformGestureDetector.kt

.../com/alexvanyo/composelife/ui/InteractableCells.kt

...lin/com/alexvanyo/composelife/ui/ComposeLifeApp.kt

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aa68fa...34ebd56. Read the comment docs.


Running on ECS cluster

Hey,
I tried running these on Amazon ECS Cluster but they cant seem to reach the database. Can you please let me know if you know why this is happening?
Thanks,
Shreyas

@sachrekar21 do you solve your database issue?

Closing due to inactivity.


bot can't connect to pushshift.io

Following error on run. I was previously able to run this bot fine months ago. I just rebuilt it and ran it. Went through configuration fine, bot errors out trying to connect to pushshift.io. I'm not sure what the use of pushshift is in the bot but maybe an API key changed or something?:
Edit: just found this, and it looks like the cause: https://www.reddit.com/r/modnews/comments/134tjpe/reddit_data_api_update_changes_to_pushshift_access/
Please fix using a different API @MrPowerScripts I like the bot and had great success with it in the past.
root@debian:~# cd reddit-karma-farming-bot/
root@debian:~/reddit-karma-farming-bot# ls
deps  Dockerfile  docs	info.log  LICENSE  Pipfile  Pipfile.lock  README.md  run_linux.log  run_linux.sh  run_windows.bat  src
root@debian:~/reddit-karma-farming-bot# ./run_linux.sh
18/05/2023 13:52:52
system is Linux
Trying to run the bot
Running without menu
Loading .env environment variables...
info loggin
13:52:54 config root: /root/reddit-karma-farming-bot/src/config
13:52:54 repo root: /root/reddit-karma-farming-bot
13:52:54 src root: /root/reddit-karma-farming-bot/src
13:52:54 loading bot_reddit_client_id from envar. Value: z9IFX_QNFVwwfCyQfbYrCw
13:52:54 loading bot_reddit_client_secret from envar. Value: zrJDqQwWXyFaWtxpuhQJ1XcRCWfcwg
13:52:54 loading bot_reddit_username from envar. Value: mike-who
13:52:54 loading bot_reddit_password from envar. Value: pX4(6!wmZmaEFu*
13:52:54 REDDIT AUTH CONFIG:
 {
  "reddit_client_id": "z9IFX_QNFVwwfCyQfbYrCw",
  "reddit_client_secret": "zrJDqQwWXyFaWtxpuhQJ1XcRCWfcwg",
  "reddit_password": "pX4(6!wmZmaEFu*",
  "reddit_username": "mike-who"
}
13:52:54 REDDIT CONNFIG:
 {
  "reddit_comment_chance": 0.005,
  "reddit_comment_karma_limit": null,
  "reddit_crosspost_enabled": false,
  "reddit_karma_limit_check": 0.002,
  "reddit_low_score_threshold": 0,
  "reddit_post_chance": 0.005,
  "reddit_post_karma_limit": null,
  "reddit_remove_low_scores": 0.002,
  "reddit_reply_to_comment": 0.002,
  "reddit_shadowban_check": 0.002,
  "reddit_sleep_schedule": [
    2,
    4
  ],
  "reddit_sub_list": []
}
/root/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/psaw/PushshiftAPI.py:192: UserWarning: Got non 200 code 404
  warnings.warn("Got non 200 code %s" % response.status_code)
/root/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/psaw/PushshiftAPI.py:180: UserWarning: Unable to connect to pushshift.io. Retrying after backoff.
  warnings.warn("Unable to connect to pushshift.io. Retrying after backoff.")
Traceback (most recent call last):
  File "/root/reddit-karma-farming-bot/./src/init.py", line 6, in <module>
    import bot
  File "/root/reddit-karma-farming-bot/src/bot.py", line 3, in <module>
    from bots.reddit import RedditBot
  File "/root/reddit-karma-farming-bot/src/bots/reddit/__init__.py", line 3, in <module>
    from .bot import RedditBot
  File "/root/reddit-karma-farming-bot/src/bots/reddit/bot.py", line 3, in <module>
    from apis import reddit_api
  File "/root/reddit-karma-farming-bot/src/apis/__init__.py", line 9, in <module>
    pushshift_api = PS()
  File "/root/reddit-karma-farming-bot/src/apis/pushshift.py", line 13, in __init__
    self.api = PushshiftAPI()
  File "/root/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/psaw/PushshiftAPI.py", line 326, in __init__
    super().__init__(*args, **kwargs)
  File "/root/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/psaw/PushshiftAPI.py", line 94, in __init__
    response = self._get(self.base_url.format(endpoint='meta'))
  File "/root/reddit-karma-farming-bot/.venv/lib/python3.9/site-packages/psaw/PushshiftAPI.py", line 194, in _get
    raise Exception("Unable to connect to pushshift.io. Max retries exceeded.")
Exception: Unable to connect to pushshift.io. Max retries exceeded.
root@debian:~/reddit-karma-farming-bot#

you do know u just leaked your login right

It's a problem with psaw, the wrapper he's using for PushShiftAPI. It's broken and they stopped working on it. Apparently we have to move to pmaw.

It's a problem with psaw, the wrapper he's using for PushShiftAPI. It's broken and they stopped working on it. Apparently we have to move to pmaw.
Edit: It's not a problem with pmaw or psaw. PushShift API is down because of Reddit's API policy changes.

So what now?


Balances Differing when they shouldn't

Describe the bug
Players have different balances depending on game mode for some reason, and the configuration comments nor the wiki tell me how to set it so the balance the same in all worlds and game modes, but separate the inventories between creative and survival modes and worlds.
To Reproduce
See the description
Expected behavior
I want the players economy balance to stay the same game wide, but them not to be able to move items from creative to survival.
Plugin version
Using the latest released version of the plugin
Server version
Spigot 1.13.2
Additional context and logs

In the config.yml, set economy (line 35 by default) to false. this is indeed stated in its comment. ;)


test(words): adding unit tests over words and test runner

Description

Adding jest test runner
including on build
unit testing the words filter feature
upgrading github actions to node v12 because discord version 12 requires node v12 to work.

Thanks for the PR :+1: We Have had a lot of conversions about testing. @nhcarrigan @eddiejaoude @BOLT04 Could you give your opinion?

This is actually a really clever approach. I'm going to leave a couple of comments.

Thank you all 👍


Should track_prev_frame_range be equal to 1 to reproduce paper's results?

Hi.
Thank you for sharing your work.
I was going through the configuration files, and it seems that track_prev_frame_range is by default set to 5. However, in the paper (as far as I understood) you state that you are only feeding the previous immediate frame (or a few frames further back, in case of augmentation) to the model. Does this mean this value should be set to 1 (or 2) to reproduce your work?

You are mixing up two different concepts. track_prev_frame_range specifies the range from which we sample. but we only sample 1 (or 2 if multi_frame_attention=true) frames.

Got it! Thanks for the help.


Cannot read properties of null reading clampDate at set pickerMoment [as pickerMoment]

Hi,
Error message:
Cannot read properties of null reading clampDate at set pickerMoment [as pickerMoment]
This issue raised on Angular 16 standalone dialog form component for Full-calendar implementation.
Here is the component decorator:
@Component({
selector: 'app-form-dialog:not(o)',
templateUrl: './form-dialog.component.html',
standalone: true,
imports: [ CommonModule, ReactiveFormsModule, MatFormFieldModule, MatInputModule, MatSelectModule, MatIconModule, OwlDateTimeModule, OwlNativeDateTimeModule ],
providers: [CalendarService]
})
Some used packages versions:
"@angular/animations": "16.0.3",
"@angular/cdk": "16.0.2",
"@angular/common": "16.0.3",
"@angular/compiler": "16.0.3",
"@angular/core": "16.0.3",
"@angular/flex-layout": "15.0.0-beta.42",
"@angular/forms": "16.0.3",
"@angular/material": "16.0.2",
"@angular/material-luxon-adapter": "16.0.2",
"@angular/platform-browser": "16.0.3",
"@angular/platform-browser-dynamic": "16.0.3",
"@angular/router": "16.0.3",

"@danielmoncada/angular-datetime-picker": "^16.0.1",
"@fullcalendar/angular": "^6.1.9",
"@fullcalendar/core": "^6.1.9",
"@fullcalendar/daygrid": "^6.1.9",
"@fullcalendar/interaction": "^6.1.9",
"@fullcalendar/list": "^6.1.9",
"@fullcalendar/timegrid": "^6.1.9",

I also encountered the same problem


PsyLoop still use gint64 as timestamps

This Should be Psy.TimePoints instead

This was only how the signal was registered.


Update dependencies

Describe your changes
Bump dependencies versions:

bcprov-jdk18on: 1.77 -> 1.78.1
kotlin-stdlib-jdk8: 1.9.20 -> 2.0.0
kotlinx-serialization-json: 1.5.1 -> 1.7.1

Linked issues

Closes #495
Breaking changes

[ ] This issue contains breaking changes

Yup, I've seen it, thanks! Let's proceed with this one, as it includes all the updates. 🙂