Release on F-Droid

Is your feature request related to a problem? Please describe.
It would be great to see this Android app on F-Droid!
Describe the solution you'd like
F-Droid is an Android app store specifically for free/libre open-source apps. It would be great if your app could be released there, as it is the number one for getting FLOSS Android apps for many people.
F-Droid also builds all apps from source (optionally even reproducible), so downloads from there can be trusted.
The app developer FAQ or the quick start guide may help you to get started.
Describe alternatives you've considered
An APK release or so is not as convenient.
Additional context
BTW a release on F-Droid could also bring some (more) popularity (in case that is intended), as it will show up in the app (new apps are featured there).
Previous discussion: https://chaos.social/@maxammann/106918057710165736

Current blockers:

Switch from Mapbox to Maplibre. This is difficult because the flutter bindings are not ready for this and need to be forked: https://github.com/m0nac0/flutter-maplibre-gl
Nice to have: Reduce APK size
Create Git tags when a new version is released
Use a different geolocator for fdroid builds: https://gitlab.com/free2pass/flutter-geolocator-floss

As a preparation: I see there are already 2 releases tagged, but no APK provided. Could you provide one? I could send that through my scanner then to see how close it comes to the inclusion policy. And depending on its size, might even be able to provide it via my repo until it fully matches.

I'm setting up a new CI right now, so we're slowly getting closer :)
I'm a bit skeptical about the https://gitlab.com/free2pass/flutter-geolocator-floss because it is already quite a few versions behind the upstream library.

We are also using maplibre now :) Thanks to @m0nac0 :)

I'm a bit skeptical about the gitlab.com/free2pass/flutter-geolocator-floss because it is already quite a few versions behind the upstream library.

Maybe the other variant mentioned in my snippet has some alternative pointers? I cannot tell, I'm no Flutter dev.

@IzzySoft I tried an approach without using the above dependency. I just exclude the GSM dependency after compilation. We already did this for a MapBox dependency.
The only issue is that I had to add a "polyfill" for one GSM class. This means there is one class within the path com.google.android.gms in the final apk. This class is not by google, but by me.
Not sure whether this triggers the detection.
Can you maybe upload another APK? If this works, then I would create a the first Release which includes a FLOSS build. Right now I do not want to create a release with this.
(APK is currently uploading)

https://cloud.maxammann.org/index.php/s/irkRPyZpd29tMLw

signing key and application id have been changed in this version

there is one class within the path com.google.android.gms in the final apk. This class is not by google, but by me.

And probably rather a "stub" which just "nods" (i.e. it's a rather empty shell with all the methods to be called, but those methods to nothing but return "OK"). Yes, we've got several apps with such stubs at F-Droid (e.g. Crashlytics stubs). Yes, the scanner will yell – and for such cases we have scanIgnore settings. I don't have such in my repo, but would then simply add a hint to the app's description that the "alert" is a "false positive", explaining directly or linking to an explanation.

APK is currently uploading

Got it – and surprise, looks like you successfully "fooled" my scanner:
No offending libs found.

Now you got my attention, that was not what I expected (glad to, though!). Used apktool d to decompile – and I cannot see any GMS package in there, not even a stub. But I see several obfuscated classes, so it's probably in there (and would trigger F-Droid's scanner at build time; F-Droid has several additional layers a simple binary repo like mine cannot apply) – may wrath and fire rain on proguard for that :speak_no_evil: :see_no_evil:

signing key and application id have been changed in this version

As your app was not yet public, that's probably not an issue for most users. Did you want to say I may publish this APK via my repo already? While you're tagging v2.0.2 and then attaching the APK to the release? In return, I could provide you with the Fastlane structures you'll need for the F-Droid listing then.

Now you got my attention, that was not what I expected (glad to, though!). Used apktool d to decompile – and I cannot see any GMS package in there, not even a stub. But I see several obfuscated classes, so it's probably in there (and would trigger F-Droid's scanner at build time; F-Droid has several additional layers a simple binary repo like mine cannot apply) – may wrath and fire rain on proguard for that speak_no_evil see_no_evil

Ah yes, proguard makes this impossible. I suspect fdroid is building it without mangling and then the checks will reveal the truth.
I'll shortly post another apk which is not mangled via proguard. I think its interesting to know what your scanner is saying then.
It is a debug build, so it should not be released.

Did you want to say I may publish this APK via my repo already?

I thought it is already live in your repositories. So if it isn't so far, we can wait until I create the first release which could be published to F-Droid's main repository.

While you're tagging v2.0.2 and then attaching the APK to the release?
aah I actually forgot to tag that version. Good catch!
But I'm afraid I can not create a FLOSS version for this release without backporting my current changes. So I would propose to wait with uploading APKs to the releases section until we actually have a build ready for F-Droid (changing signing keys, applicaiton id). I'm working on it here: https://github.com/digitalfabrik/ehrenamtskarte/pull/427

In return, I could provide you with the Fastlane structures you'll need for the F-Droid listing then.

That would be great! We actually also need them for Google Play at some point

Unmangled Debug Build for running scanner: https://cloud.maxammann.org/index.php/s/E9y82rrSBmsRRJq

I suspect fdroid is building it without mangling and then the checks will reveal the truth.

I'm certain of that :smile:

I thought it is already live in your repositories.

It is. Now I see how much the package name changed. I was looking for *ehrenamt* and got no results :see_no_evil:

aah I actually forgot to tag that version. Good catch!

:smile:

So I would propose to wait with uploading APKs to the releases section until we actually have a build ready for F-Droid (changing signing keys, applicaiton id).

Totally fine with me. As the package name changes, this will essentially be an entirely new application – no simple updating, users have to perform a fresh (manual) install. I assume the old packageName is to be abandoned then entirely? Because if so, at that point I should place a note in the description of the "old one" to direct the users to its successor. Which at that point of course should be present.
As for Fastlane structures: shall I send you what I have now (for the "old name")? I'd skip screenshots then and leave it to you adding newer ones. For what is available, you can see here (just append lang=en-US to view the English or lang=de for German (this overrides browser settings).

Unmangled Debug Build for running scanner:

Wait: Mangling reduces size by 50% – what is that? The last one was 22.5M, this one has 52M… Nope, the last one you've sent was a release build, this is a debug build. Let me give you the full list:
Libraries detected:
-------------------
* Android Support v4 (/android/support/v4): Development Framework
* AndroidX Activity (/androidx/activity): Utility
* Android Jetpack Annotations (/androidx/annotation): Utility
* Arch (/androidx/arch): Utility
* AppCompat (/androidx/appcompat): Utility
* Android Support Library collections (/androidx/collection): Utility
* Constraint Layout Library (/androidx/constraintlayout): Utility
* Androidx Core (/androidx/core): Utility
* AndroidX Cursor Adapter (/androidx/cursoradapter): Utility
* Documentfile (/androidx/documentfile): UI Component
* Exifinterface (/androidx/exifinterface): Utility
* Androidx Fragment (/androidx/fragment/app): Development Aid
* androidx.legacy (/androidx/legacy): Utility
* Lifecycle (/androidx/lifecycle): Utility
* Loader (/androidx/loader): Utility
* AndroidX Local Broadcast Manager (/androidx/localbroadcastmanager): Utility
* Media (/androidx/media): Utility
* Print (/androidx/print): Utility
* Android Activity Saved State (/androidx/savedstate): Utility
* Transition (/androidx/transition): UI Component
* Vectordrawable (/androidx/vectordrawable): UI Component
* Android Jetpack VersionedParcelable (/androidx/versionedparcelable): Utility
* Flutter Geolocator Plugin (/com/baseflow/geolocator): Utility
* Google Mobile Services (/com/google/android/gms): Development Framework NonFreeDep
* Google Material Design (/com/google/android/material): Utility
* Google Core Libraries for Java 6+ (/com/google/common): Utility
* Error Prone (/com/google/errorprone): Utility
* Google Gson (/com/google/gson): Utility
* J2ObjC (/com/google/j2objc): Utility
* ZXing ('Zebra Crossing') (/com/google/zxing): Utility
* flutter_secure_storage (/com/it_nomads/fluttersecurestorage): Utility
* ZXing Android Embedded (/com/journeyapps/barcodescanner): Utility
* Mapbox Android SDK (/com/mapbox/mapboxsdk): Map
* Mapbox Maps SDK for Android (/com/mapbox): Map
* OkHttp (/com/squareup/okhttp): Utility
* Flutter (/io/flutter): Development Framework
* Flutter Android Lifecycle Plugin (/io/flutter/plugins/flutter_plugin_android_lifecycle): Utility
* Image Picker plugin for Flutter (/io/flutter/plugins/imagepicker): Utility
* PackageInfo (/io/flutter/plugins/packageinfo): Utility
* path_provider (/io/flutter/plugins/pathprovider): Utility
* shared_preferences (/io/flutter/plugins/sharedpreferences): Utility
* url_launcher (/io/flutter/plugins/urllauncher): Utility
* JavaX Annotation API (/javax/annotation): Utility
* Kotlin (/kotlin): Utility
* OkHttp okio Framework (/okio): Utility
* Checker Framework (/org/checkerframework): Utility
* MojoHaus AnimalSniffer Maven Plugin (/org/codehaus/mojo/animal_sniffer): Utility
* IntelliJ IDEA (/org/intellij): Utility
* Timber (/timber/log): Utility

Offending libs:
---------------
* Google Mobile Services (/com/google/android/gms): NonFreeDep

1 offenders.

Its happening :) https://gitlab.com/fdroid/fdroiddata/-/merge_requests/10382

Thanks for the donation btw (I felt like "little red riding hood" was asking me why I had so big eyes and a big open mouth :rofl:)

Done, thanks again @IzzySoft
https://f-droid.org/packages/app.ehrenamtskarte.bayern.floss/

Yupp! And the note was added right away to its predecessor if you want to check. Also added a reminder to remove that one from my repo after some overlap (note was needed due to change of package name, otherwise my framework would remind me automatically).


Using function_type on a reference gives a non-obvious error message

Instead of failing with something like function_type can't be used with ref-qualified types, we get a SFINAE error saying that the library is unable to determine the parameters. This is somewhat misleading, and it took me a good couple of minutes to figure this one out.

Ah, thanks.
Do you think the library should support reference types to function objects? We could simply remove reference at the top level, but at that point a case could be made to remove everything else as well.

I don't know. I don't think it should, but we should at least get  a clear error message.

@ldionne Do you think the "SFINAE errors" approach is more of a hindrance than a convenience?

I don't know, but here's what I get:
#include <boost/callable_traits.hpp>
struct F { void operator()(int) {} };
using XX = boost::callable_traits::function_type<F&>::type;

int main() { }

Error:
boost/callable_traits/detail/sfinae_errors.hpp:34:9: error:
      no type named 'type' in
      'boost::callable_traits::error::parameters<boost::callable_traits::cannot_determine_parameters_for_this_type_>::_'
        using sfinae_try = typename CALLABLE_TRAITS_DISJUNCTION(
        ^~~~~
boost/callable_traits/detail/utility.hpp:48:1: note:
      in instantiation of template type alias 'sfinae_try' requested here
using fail_if_invalid = sfinae_try<T,
^
boost/callable_traits/function_type.hpp:24:1: note:
      in instantiation of template type alias 'fail_if_invalid' requested here
using function_type_t = //implementation-defined
^
boost/callable_traits/function_type.hpp:33:18: note:
      in instantiation of template type alias 'function_type_t' requested here
    using type = function_type_t<T>;
                 ^
test.cpp:7:36: note: in instantiation of template class
      'boost::callable_traits::function_type<F &>' requested here
using XX = boost::callable_traits::function_type<F&>::type;
                                   ^
1 error generated.

I thought somehow function objects were not supported or something weird like that. It could be the way it's worded: "unable to determine parameters" makes it sound like it's something you COULD determine, but don't because of some defficiency in the library.

Pending CI testing, fixed via d87078752dd2769f444d1d2d531d6a500aae86d4.
SFINAE error message now reads:
error: no type named ‘type’ in ‘struct boost::callable_traits::error::reference_errorboost::callable_traits::reference_type_not_supported_by_this_metafunction_::_’


Review javadoc comments for DocLint Java 8 compliance.

Compiling with Java 8 requires to be DocLint compliant.

I've made the changes to fix the < > handling in a separate check-in.  I'm going to leave the  and .  Thanks.


Allow duplicate fragments

Currently if we have duplicated fragment use then we report an error, this could be because a component is used multiple times in different sub-components leading to a fragment being used multiple times. We should give people the option to filter out these warnings.

We use duplicated fragments & nested duplicates so this would be great.

Oh like two different fragments with the same name?
Never mind then. I think I just needed to restart my TS server.


Linking Sensi Themostats

Is there any chance you could make it so we can link multiple Sensi thermostats.  So if i change the temp on one, the other one changes as well to match it?  I have a spare sensi classic, and would like to have it on the wall downstairs and just run it off batteries and not wired to the HVAC.  And spending $ each month on Sensi plan isn't something I want or anyone should do.

Each sensi is a separate entity at this point. I will not be able to incorporate this feature but you can do this via an automation like this. You would want to do the same for the mode.
  - alias: update_target_temperature
    id: update_target_temperature
    trigger:
    - platform: state
      entity_id: climate.source
      attribute: temperature
    action:
      - service: climate.set_temperature
        data:
          temperature: >-
            {{ state_attr('climate.source', 'temperature') |float }}
        target:
          entity_id: climate.target

To clarify the above concept of "linking" as seen in the Sensi app as a paid feature, a linked thermostat doesn't just have the same set temperatures, it synchronizes when the systems are online.
In other words, even if the temperature readings vary, if one thermostat has the heat on, all linked thermostats have their heat on.

To clarify the above concept of "linking" as seen in the Sensi app as a paid feature, a linked thermostat doesn't just have the same set temperatures, it synchronizes when the systems are online.
In other words, even if the temperature readings vary, if one thermostat has the heat on, all linked thermostats have their heat on.

Exactly, something that I would like to see in this integration.  All it would have to do is monitor both Thermostats like normal, and when one of the thermostats temperature is changed.  Then it could set the temperature for the other one so that they stay synced.

I do not have resources to experiment with this and neither do I have the paid account to confirm what Sensi app does. You can however use automation to accomplish that, I posted a potential sample above.


Duplicate Content Items error

I tried adding this lib to our MAUI Blazor app and got the following error:
Error	NETSDK1022	Duplicate 'Content' items were included. The .NET SDK includes 'Content' items from your project directory by default. You can either remove these items from your project file, or set the 'EnableDefaultContentItems' property to 'false' if you want to explicitly include them in your project file. For more information, see https://aka.ms/sdkimplicititems. The duplicate items were: 'C:\Users\user\.nuget\packages\microsoft.playwright\1.38.0\buildTransitive\..\.playwright\node\LICENSE'	C:\Program Files\dotnet\sdk\7.0.401\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.DefaultItems.Shared.targets	213		Normal

Not sure how is it related to extra library.
Error points to core playwright itself. And by error message, i can just presume that you have conflict LICENSE file.
Maybe try to clean nuget cache and reinstall, other than that, i dont think i can help you with that, sorry.


vite-plugin-vue-i18n custom block messages aren't loaded

Reporting a bug?
Hi guys,
I have been using  custom blocks in sfc for a while.
I migrated from Vue 2 to 3 and Vue i18n from v8 to 9. I used vue cli and vue i18n loader for the custom block. Since the migration, i now use vue 3 + Vue i18n v9 + vite vite-plugin-vue-i18n.
I want to use the legacy api for i18n to minimize the page migration work. However, $t only picks up the global resources loaded from vite.config and my i18n setting below
export default defineConfig({
  plugins: [
    vue(),
    vueI18n({
      // if you want to use Vue I18n Legacy API, you need to set `compositionOnly: false`
      compositionOnly: false,
      include: resolve(__dirname, "./src/locales/**"),
    }),
  ],
});

import { createI18n } from "vue-i18n";
import messages from "@intlify/vite-plugin-vue-i18n/messages";

const i18n = createI18n({
  legacy: true, // you must set `false`, to use Composition API
  locale: 'en-US',
  fallbackLocale: 'en-US',
  messages,
});

The  custom block doesnt seem to be loaded into the instance for some reason.
Is it a bug or not supported or I missed something?
Expected behavior
 custom block messages should be loaded
Reproduction
see description above
Issue Package
vite-plugin-vue-i18n
System Info
System:
    OS: Windows 10 10.0.22598
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz
    Memory: 10.05 GB / 31.71 GB
  Binaries:
    Node: 16.14.2 - C:\Program Files\nodejs\node.EXE
    npm: 8.5.5 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22598.200.0), Chromium (101.0.1210.39)
    Internet Explorer: 11.0.22598.1

Screenshot
No response
Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the README
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.

I'm using vue-i18n-bridge with vite-plugin-vue-i18n in composition mode. Custom block messages aren't loaded either.

I tried to use custom block with vue3 in legacy mode, and it works，code below
https://stackblitz.com/edit/vitejs-vite-7wz2pl?file=src/App.vue

Same problem here. I'm trying to progressively a big project to Vue 3 and trying to at least get vue-i18n to work with SFC blocks and Vite with Vue 2.7 while relying on global $t() function. Global messages coming from files are ok, but SFC blocks are not interpreted.
I've tried a lot of variations, including unplugin-vue and the bundle tools.

Same with Nuxt3 + unplugin-vue-i18n

Vue's context.messages doesn't include locales defined in SFCs

Sorry I have not been able to reply for a while now.
I have been focused on nuxtjs/i18n for a while now. I recently released a nutxjs/i18n beta version of it and will be looking at an issue soon.
Pleases wait🙏

Sorry I have not been able to reply for a while now.
I have been focused on nuxtjs/i18n for a while now. I recently released a nutxjs/i18n beta version of it and will be looking at an issue soon.
Pleases wait🙏

Thanks for the hard work. Btw, will nuxtjs/i18n work with this plugin? What's the benefits of using it over pure plugin/i18n.ts with this plugin in a Nuxt project?

One year later, I am still experiencing this problem. Any progress? Anyone has found a workaround?

Sadly not. I tried to configure the plugin and wasted a lot of time today, because I couldn't explain why the custom block isn't working. Seeing now, that the problem has existed for so long, is very frustrating. Especially because the custom block is documented as a main feature :-(.

I also encountered this problem and I solved it with the composable useI18n. The composable works with custom block messages, but the $t function does not.
<template>
<h1>{{ t('headline') }}</h1>
</template>

<i18n lang="json5">
{
  de: {
    headline: 'Überschrift'
  },
  en: {
    headline: 'Headline'
  },
}
</i18n>

<script lang="ts" setup>
import { useI18n } from 'vue-i18n';

const { t } = useI18n();
</script>

@medialwerk I tried it the same way you showed - it does not work. Can you please share your nuxt config and i18n config files? I suspect that it doesn't work because I have mixed up configs of different approaches


feat(evm): Compile Etherscan Sources for use in Debugger

Motivation
Debugging with sources is helpful, pulling sources from etherscan expands amount of source code available. Built off of this PR.
Solution
1 . When identifying addresses for traces, collect addresses & sources.
2. Compile each contract address [and downloads the solc version required)
3. Provide them to the TUI debugger.
Still can't handle vyper, --via-ir, or multifile sources.
In order to make these changes, we migrate the compile module to the common module. This makes the dependecy pattern more obvious and removes cyclical imports. The compile from etherscan function is now in this module and can be imported into other crates.
Example from ethereum mainnet:
cargo run --bin cast -- run 0x1a3223af00bbbf09db3b84dcd7ed281e0b5fcc2a74c9afb04eb8a2f2289b529b --debug

Can we make this also work with forge test --debug?

@OmkarB bump, i think there's a bunch of conflicts on the CLI due to a recent refactor? we can merge this at current state and do the forge test --debug and forge debug in a follow up PR maybe?

sorry for the delay @gakonst -- works for me. I'll resolve conflicts in this one and follow up with a separate PR to include updates to forge test --debug and  forge debug.

@gakonst wyt? Fixed conflicts and cleaned up code a bit. Should we merge into master?

@OmkarB this generally looks good - can you take a pass at https://github.com/foundry-rs/foundry/pull/3006/commits/0e4f63977a48096d2c1e3c10ebb14e399c1a5a00 and see if it improves performance? It seems not to locally for me which surprises me. cc @mattsse this is good to merge if we like the code changes + agree on the followups

@gakonst it's definitely faster locally for me. Doesn't make much of a difference for 2/3 contracts but noticed a substaintial improvement when there were more.
If this looks good, should we merge? @mattsse or would it be better to merge the extracted code from #3235.   I can work on caching the artifacts as the immediate followup.

sgtm,
let's merge #3235, rebase this and merge,

@mattsse I dropped the changes to the compile module that I made in preference for what you pulled out, and combined any other changes with the second commit. Kept the debugger integration logic.

sorry for the delay @gakonst -- works for me. I resolved the conflicts in this one and follow up with a separate PR to include updates to forge test --debug and forge debug.

hiya @omkarb, browsing this topic and am wondering if the separate PR you anticipated got done.. Would be fantastic if sources would download in these contexts too. Thx!


Spinbox step has problems with floating-point imprecision

Wave SDK Version, OS
v0.17.0, Linux
Actual behavior
Setting the step value of ui.spinbox to 0.0001 causes the following issue with floating-point imprecision:
https://user-images.githubusercontent.com/13353204/129863667-f880a2c1-9491-4d65-8889-996c72c6a00b.mp4
Expected behavior
I would expect there to be no small floating-point errors shown in the UI.
Steps To Reproduce

Create a ui.spinbox with step=0.0001 (or smaller).
Try increment / decrement in the UI.

I believe possible solutions would be either passing a Decimal (or some other higher-precision value) to the ui.spinbox, or doing some clever rounding in the UI to avoid showing the imprecision artifacts.

Thanks for catching this @bminixhofer!


QFM Surface v2

Due to changes in master, the tests failed after merging the previous QFM pull request. So we undid the PR and are now opening this one to fix the tests. Lesson learned from this: we should always merge master into a PR branch and check that the tests are passing before we merge a PR.
Elizabeth and I also noticed some strange behavior of the QFM surface computed in the example (it is self intersecting), so maybe let's wait until we know a bit better what's going on there before merging.

Not my code, so I'm tagging @ejpaul here.

OK. I was thinking of scipy.optimize.minimize function where the method is
supplied as an argument. Both SLSQP and LBFGS are supplied via method
argument. However if you think its not worth, that comment can be ignored.
Bharat Medasani
Engineer
Princeton Plasma Physics Lab (PPPL)
On Tue, Jul 13, 2021 at 8:07 PM Elizabeth Paul @.***>
wrote:

@.**** commented on this pull request.
In src/simsopt/geo/qfmsurface.py
https://github.com/hiddenSymmetries/simsopt/pull/106#discussion_r669189209
:

   dr = qfm.dJ_by_dsurfacecoefficients()

   dl = self.label.dJ_by_dsurfacecoefficients()

   dval = dr + constraint_weight*rl*dl

   if derivatives == 1:

       return val, dval

   d2r = qfm.d2J_by_dsurfacecoefficientsdsurfacecoefficients()

   d2l = self.label.d2J_by_dsurfacecoefficientsdsurfacecoefficients()

   d2val = d2r  \

       + constraint_weight*rl*d2l + constraint_weight*dl[:, None]*dl[None, :]

   return val, dval, d2val

I added the docstring.
I am not sure what you want to achieve with
minimize_qfm_penalty_constraints. Right now,
minimize_qfm_exact_constraints_SLSQP solves a constrained problem while
minimize_qfm_penalty_constraints_LBFGS solves an unconstrained penalized
problem. For example, constraint_weight is not used for
minimize_qfm_exact_constraints_SLSQP.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/hiddenSymmetries/simsopt/pull/106#discussion_r669189209,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA62VEAVEECOJLQRSF7HXWDTXTILJANCNFSM477SAGFA
.


Fix 404 error during HandleSummaryAckError error

Description
This handle the flow where while summarizer is running into handleAcks flow and waiting for ack promise to get resolved, the summarizer can make a new summary. Now when we try to refresh the state from handles of previous ack, and try to fetch snapshot corresponding to that it might not be present in cache and server(server deletes previous snapshots) and we get 404 from server and run into "HandleSummaryAckError". So before giving up, we try one more time with refreshing the state from latest snapshot handle.

@jatgarg, can you please clarify scenario? Are you saying that the async flow of responding to summary ack may run when new summary starts? If so, I believe Nicholas is addressing it by adding locking mechanism

summary starts?

@vladsud The async flow of reacting to summaryAck A1 for summary S1, may kick in after a new summary S2 has already been submitted. Then in case of single commit summary, the previous summary S1(corresponding to Ack A1) may have been deleted from the spo, which causes the summaryAck A1 handling to fail as we try to fetch the snapshot from cache/storage corresponding to A1 during its handling and now it does not exists.


BUG-92674: Fix UI errors introduced by UI library updates

This PR is a backport PR against HDF <IP_ADDRESS> branch.

@shahsank3t Do not we want this to be pushed into HDF-3.0-maint?

@shahsank3t Can you push these changes into HDF-3.0-maint branch?

@satishd
These changes are already merged into HDF-3.0-maint branch by @arunmahadevan
https://github.com/hortonworks/registry/commit/f58e259a3b862bf6f4d57cfc6f4702850baf37c1 and https://github.com/hortonworks/registry/commit/379cd21b773579e487d5b76f82f4cab349f9bc8c


TS support?

Any reasons to drop it?
Any chances to have it back?

IMO the best way is to have separated TS-specific package with all TS stuff and TS maintainer. TS developers may install 2 packages (code and types). JS developers will not be affected at all, and will not have dead files in their node_modules.
There is a package with types for the library, but it is deprecated at the moment> I think it is possible to restore it.

Sorry, but no more TS support since version 3.


Integration specs for views and fix n+1 problems

We have completed the task of Integration specs for views and fix n+1 problems to the Blog Application according to the stipulated requirements: 🌱
Implementations:

[x]  Used Capybara to test the users, comments and posts views

[x]  Analyzed and Fixed n+1 problems

Analyzing N+1 : Users: 🔽

Analyzing N+1: Posts: 🔽

Analyzing N+1 : Comments:

N+1 issue in comments Identified: Before: 🔽

N+1 issue Fix: After: 🔽

[x] ### Implemented the following View Specs

User index page:

I can see the username of all other users.

I can see the profile picture for each user.

I can see the number of posts each user has written.

When I click on a user, I am redirected to that user's show page.

User show page:

I can see the user's profile picture.

I can see the user's username.

I can see the number of posts the user has written.

I can see the user's bio.

I can see the user's first 3 posts.

I can see a button that lets me view all of a user's posts.

When I click a user's post, it redirects me to that post's show page.

When I click to see all posts, it redirects me to the user's post's index page.

User post index page:

I can see the user's profile picture.

I can see the user's username.

I can see the number of posts the user has written.

I can see a post's title.

I can see some of the post's body.

I can see the first comments on a post.

I can see how many comments a post has.

I can see how many likes a post has.

I can see a section for pagination if there are more posts than fit on the view.

When I click on a post, it redirects me to that post's show page.

Post show page:

I can see the post's title.

I can see who wrote the post.

I can see how many comments it has.

I can see how many likes it has.

I can see the post body.

I can see the username of each commentor.

I can see the comment each commentor left.

In addition We have ensured the following general requirements:

Made sure that there are no linter errors.
Made sure that I have used correct flow Gitflow.
Made sure that I have documented my work in a professional way.
Followed list of best practices for Ruby.

Please kindly review this implementation.
Thank you 🙏🏻

Iterations
I have completed the changes requested by the reviewer:
Implementations

[x] Added spec to user_index: test to assert the scenario When I click on a user, I am redirected to that user's show page.

The following iterations have been implemented as requested by the reviewer
Iterations
post/index

can see the user's profile picture
can see the user's username
can see the number of posts the user has written
can see a post's title
can see some of the post's body
can see the first comments on a post
can see how many comments a post has
can see how many likes a post has
can see a section for pagination if there are more posts than fit on the view

post/show
can see the post's title
can see how many comments it has
can see how many likes it has
can see the post body
can see the username of each commentor
can see the comment each commentor left

The following iterations have been implemented as requested by the reviewer
Iterations
post/index

can see the user's profile picture
can see the user's username
can see the number of posts the user has written
can see a post's title
can see some of the post's body
can see the first comments on a post
can see how many comments a post has
can see how many likes a post has
can see a section for pagination if there are more posts than fit on the view

post/show
can see the post's title
can see how many comments it has
can see how many likes it has
can see the post body
can see the username of each commentor
can see the comment each commentor left

xcx


Improve OpenShift status in crc status

Currently, oc status will report the OpenShift cluster is stopped if one of the operators from oc get co is not in the ready state.
If the oc command manages to get a list of operators, this means the cluster is not "stopped", but merely that it's not fully ready.
It would be less confusing to report its state as "degraded" (for example).
We'll need to document what 'degraded' means. Mostly that the cluster is running but that some operations are likely to have issues (for example, if the auth operator is not operational, oc login will fail)

This is already fixed.


Incorrect autocomplete data typings

Please describe the problem you are having in as much detail as possible:
It seems like the Autocomplete types are incorrect/incomplete, if it is indeed incorrect, I'm willing to make a PR, if nobody else does.
Include a reproducible code sample here, if possible:
import { APIInteraction, InteractionType } from 'discord-api-types';

const interaction: APIInteraction = {} as APIInteraction;
if (interaction.type === InteractionType.ApplicationCommandAutocomplete) {
    // Property 'options' does not exist on type 'APIApplicationCommandInteractionData'.
    //  Property 'options' does not exist on type 'APIUserApplicationCommandInteractionData'.
    interaction.data?.options;
}

I expect i should be able to do this:
interaction.data?.options[0]?.value // string | number | undefined

Further details:
NodeJS Version: v16.9.1
discord-api-types Version: 0.25.0-next.bc1d03e.1635987681

CC @suneettipirneni

will be closed in #234


[4pt]  - Display number of likes for each item on the Homepage - Student A

When the page loads, the webapp the Involvement API to show the item likes and combines them with the data from the base API.
Remember that your page should make only 2 requests:

one to the base API
and one to the Involvement API.

This task does not include displaying the likes button (heart icon on the wireframe) for each item.

Hello @MussieTeka, No issues to report, everything is working well. Great job


"No GitHub repositories found." after updating to 0.0.7

Installation

Extension version: 0.7.0
VSCode Version: 1.34.0 (a622c65b2c713c890fcf4fbf07cf34049d5fe758, 2019-05-15T21:59:37.030Z)
OS: Windows 10 Pro 1903 (Windows_NT x64 10.0.18362)

Description
I tried to use a new token, but nothing seems to have changed.
Screenshot

I see the same. The output channel has the below
[Info] C:\Users\ramyar\.ssh\config: ENOENT: no such file or directory, open 'C:\Users\ramyar\.ssh\config'
[Info] Looking for git repository
[Info] Git repository found, initializing review manager and pr tree view.
[Info] No GitHub remotes found
[Info] Review> no matching pull request metadata found for current branch master
[Info] Found GitHub remote

FWIW, I'm using 0.8.0 and can't reproduce the issue anymore.

I see the issue in the latest 0.8.0 version on the latest Insiders

I ran into this issue myself. I was able to overcome the problem by creating an ssh config file which I did not have (under $HOME/.ssh/config)
After this the plugin started working

This should already be fixed in the latest version of the extension (0.12.0). If you run into this issue again, please open a new issue. Thank you!

It doesn't work for me. Is there anything to do to get logged in to github ?

@durdenx The extension should prompt you to log in when you open a folder that has a remote pointing to GitHub. If you have problems with the sign in process, it's also possible to manually provide a token following the steps here: https://github.com/microsoft/vscode-pull-request-github/wiki#personal-access-token-authentication
If you don't see a prompt to sign in or "Sign in to GitHub" in the status bar at the bottom, please file a new issue and include the text of the GitHub pull request view (from clicking on the icon in the activity bar), and the result of running git remote -v in the folder you open.


Vkplay Unsupported URL

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
WARNING: [generic] Falling back on generic information extractor
[generic] records: Extracting information
ERROR: Unsupported URL:
[in#0 @ 00000274e3899b80] Error opening input: Invalid data found when processing input
Error opening input file -.
Error opening input files: Invalid data found when processing input
Download is not working anymore?
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

Share a FULL verbose log. You didn't even share the URL

Share a FULL verbose log. You didn't even share the URL

yt-dlp -N 2 -R infinite --keep-fragments --file-access-retries infinite --limit-rate 1.0M  https://live.vkplay.ru/lebwa/record/33a4e4ce-e3ef-49db-bb14-f006cc6fabc9/records
[generic] Extracting URL: https://live.vkplay.ru/lebwa/record/33a4e4ce-e3ef-49db-bb14-f006cc6fabc9/records
[generic] records: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] records: Extracting information
ERROR: Unsupported URL: https://live.vkplay.ru/lebwa/record/33a4e4ce-e3ef-49db-bb14-f006cc6fabc9/records


Tags autocomplete-results limiter for performance boost

Fixes issue #12415. Adding a debouncer on client side and simple restriction to 10 tags on server side for now.

Messed up, will re open


[Draft] Support for large transactions in public folders (web only)

Making this to try and activate the PR workflow, feel free to ignore

Known issues

When Drag&Drop a folder, instead of showing an error modal, it treats the folder as a file

The previous method of detecting folders stalls with large files, and I haven't found another way of detecting folders. Would probably require a fork

Preparing upload for large-ish files (~2GB) takes a long time on Android (Samsung S8 physical device, development apk). Not really sure what it is doing here

When Drag&Drop a folder, instead of showing an error modal, it treats the folder as a zip file with incorrect length...
The previous method of detecting folders stalls with large files, and I haven't found another way of detecting folders. Would probably require a fork of the Drag&Drop package
For now we can keep the current behavior

Preparing upload for large-ish files (~2GB) takes a long time on Android (Samsung S8 physical device, development apk). Not really sure what it is doing here
That is probably happening because flutter_file_picker cache the files first. Basically, it reads the file stream to create a new file inside the app, after that this cached file is available to use. In this case the file stream used by your code is from the cached file. From what I remember this is used when the user selects a file from a private folder (Downloads for example). If you don't cache you lose the reference for that file.
In our case we could get the file stream directly from the original file bypassing the cache step.

For now we can keep the current behavior

👌

That is probably happening because flutter_file_picker cache the files first. Basically, it reads the file stream to create a new file inside the app, after that this cached file is available to use. In this case the file stream used by your code is from the cached file.

In other words it first copies the whole file from the user directory to the app's directory, and then uses that instead?

From what I remember this is used when the user selects a file from a private folder (Downloads for example). If you don't cache you lose the reference for that file.

Found in the flutter_file_picker changelog to support your claim:

In our case we could get the file stream directly from the original file bypassing the cache step.

Is your suggestion that by creating a Stream immediately, then it won't matter if the reference to the original file is lost? This is possible but would be very messy, as you'd have to grab the number of streams you're planning to use in advance (2 in our case)

For now we can keep the current behavior

I mean the behavior that's currently on dev.

In other words it first copies the whole file from the user directory to the app's directory, and then uses that instead?

Yep :(

Is your suggestion that by creating a Stream immediately, then it won't matter if the reference to the original file is lost?

Yes, that's it. I can't think on a clean way to implement this right now, but it's something that we will need to work on in the future.

This is possible but would be very messy, as you'd have to grab the number of streams you're planning to use in advance (2 in our case)

Exactly!

I mean the behavior that's currently on dev.

The current behaviour relies on readAsBytes so this would effectively negate the point of the PR (for Drag&Drop at least)
https://github.com/ardriveapp/ardrive-web/pull/841/files#diff-63710b60e8dbf717ede1b79e436c1138b5d17ab6e929e9437b66771f9818ee5bL81
For a quick hack, I could try and detect attempted folder uploads based on exact file size + file extension that is reported by flutter_dropzone? Will have a tiny false positive rate, but in those cases it can just point the user to use the upload button.

Yes, that's it. I can't think on a clean way to implement this right now, but it's something that we will need to work on in the future.

Fair enough. I'll do a bit of research myself to see if there's a cleaner way, otherwise I'll implement your suggestion.

Update: it seems like the maintaner of flutter_file_picker reverted the behaviour of skipping caching after regressions. I'm hesitant to try this now... will look into alternatives
Original PR: https://github.com/miguelpruivo/flutter_file_picker/pull/1123
Issue: https://github.com/miguelpruivo/flutter_file_picker/issues/1133

Regarding Drag&Drop folders
The only way to detect these reliably was by forking flutter_dropzone. See the fork here: https://github.com/deakjahn/flutter_dropzone/compare/master...elliotsayes:flutter_dropzone:folder-detect
Let me know if this is acceptable, and I will merge the required changes to ardrive-web: https://github.com/elliotsayes/ardrive-web/compare/stream-tx...elliotsayes:ardrive-web:stream-tx-folder-hack

Regarding Android file caching
@ abhi16180 is maintaining a fork of flutter_file_picker with cache skipping, over at https://github.com/abhi16180/flutter_file_picker
I've made a test branch of flutter_file_picker based on this fork (along with my previous changes) here: https://github.com/miguelpruivo/flutter_file_picker/compare/master...elliotsayes:flutter_file_picker:skip-cache-power-stream
Test branch of ardrive-web using this fork with required changes: https://github.com/elliotsayes/ardrive-web/compare/stream-tx...elliotsayes:ardrive-web:stream-tx-open-queue
A cursory test on my Android device proves that it does indeed skip the prolonged "Preparing..." screen. I didn't test a full large file upload however (both my device and internet are very slow atm!)


refactor: update request-id recipe to use contextvars

Summary of Changes
Migrate the request-id handling from threading.local() to contextvars to improve compatibility with async coroutines and avoid issues with threading. This change ensures that request-id is properly tracked in asynchronous environments, providing more robust handling in both sync and async contexts.
Previously, threading.local() was used, which does not handle coroutines effectively. By using contextvars, we ensure that the request-id remains consistent across async calls.
Related Issues
Closes https://github.com/falconry/falcon/issues/2260.

I wanted to apologize for the confusion with my pull request. This is my first time contributing to a public repository, and I made a mistake with the process. I had previously opened a PR with the changes, but I accidentally closed it and am unable to reopen it.


Failed to start Radarr on rpi4

Cloned the script
sudo sh pijarr/setup.sh
selected y (apt update part)
selected install Radarr only
Setup finished successfully
Radarr did not start

Logs attached:

I'll have a dig out and try on a raspberrypi, as it's currently working fine on normal Debian systems -
sudo journalctl --since today -u radarr
Jan 01 16:16:31 deblen systemd[1]: Starting radarr.service - Radarr Daemon...
Jan 01 16:16:41 deblen systemd[1]: Started radarr.service - Radarr Daemon.
Jan 01 16:16:42 deblen radarr[79907]: [Info] Bootstrap: Starting Radarr - /opt/Radarr/Radarr - Version <IP_ADDRESS>76
Jan 01 16:16:42 deblen radarr[79907]: [Debug] Bootstrap: Console selected
Jan 01 16:16:42 deblen radarr[79907]: [Warn] Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager: No XML encryptor configured. Key {ffa17d6f-2a2>
Jan 01 16:16:42 deblen radarr[79907]: [Trace] DiskProviderBase: Deleting file: /var/lib/radarr/.config/Radarr/radarr.pid
Jan 01 16:16:42 deblen radarr[79907]: [Trace] EventAggregator: Publishing ConfigFileSavedEvent
Jan 01 16:16:42 deblen radarr[79907]: [Info] MigrationController: *** Migrating data source=/var/lib/radarr/.config/Radarr/radarr.db;cache size=-20000;datet>
Jan 01 16:16:42 deblen radarr[79907]: [Info] FluentMigrator.Runner.MigrationRunner: VersionMigration migrating
Jan 01 16:16:42 deblen radarr[79907]: [Info] NzbDrone.Core.Datastore.Migration.Framework.NzbDroneSQLiteProcessor: Beginning Transaction
Jan 01 16:16:42 deblen radarr[79907]: [Info] FluentMigrator.Runner.MigrationRunner: CreateTable VersionInfo
Jan 01 16:16:42 deblen radarr[79907]: [Info] NzbDrone.Core.Datastore.Migration.Framework.NzbDroneSQLiteProcessor: CREATE TABLE "VersionInfo" ("Version" INTE>
Jan 01 16:16:43 deblen radarr[79907]: [Info] FluentMigrator.Runner.MigrationRunner: => 0.0254436s
Jan 01 16:16:43 deblen radarr[79907]: [Info] NzbDrone.Core.Datastore.Migration.Framework.NzbDroneSQLiteProcessor: Committing Transaction
Jan 01 16:16:43 deblen radarr[79907]: [Info] FluentMigrator.Runner.MigrationRunner: VersionMigration migrated
Jan 01 16:16:43 deblen radarr[79907]: [Info] FluentMigrator.Runner.MigrationRunner: => 0.0418347s

I used the latest bookworm lite version on a Raspberry Pi 4, and had not issues. Your errors possibly indicate it didn't grab source or extract correctly. Maybe try the latest Raspberry Pi OS image - https://www.raspberrypi.com/software/operating-systems/
Raspberry Pi OS Lite

    Release date: December 11th 2023
    System: 64-bit
    Kernel version: 6.1
    Debian version: 12 (bookworm)

pi@raspberrypi:~ $ uname -a
Linux raspberrypi 6.1.0-rpi7-rpi-v8 #1 SMP PREEMPT Debian 1:6.1.63-1+rpt1 (2023-11-24) aarch64 GNU/Linux
pi@raspberrypi:~ $ sudo journalctl --since today -u radarr
Jan 01 23:32:01 raspberrypi systemd[1]: Starting radarr.service - Radarr Daemon...
Jan 01 23:32:11 raspberrypi systemd[1]: Started radarr.service - Radarr Daemon.
Jan 01 23:32:12 raspberrypi radarr[6693]: [Info] Bootstrap: Starting Radarr - /opt/Radarr/Radarr - Version <IP_ADDRESS>76
Jan 01 23:32:12 raspberrypi radarr[6693]: [Debug] Bootstrap: Console selected

If anyone stumbles across this and is running the 32-bit Raspberry Pi OS, the issue appears to be that the uname is wrong and causes the script to believe it should download the 64 bit binaries. It is easy enough to fix inside setup.py by replacing arm64 with arm.
See https://forums.raspberrypi.com/viewtopic.php?t=364731


$scope.column.updateView is not a function

Hello folks,
I am getting the following error when using gantt:
$scope.column.updateView is not a function
http://prntscr.com/qyxnhh
JSON DATA:
https://www.writeurl.com/text/hofg84mrfuj6mwbkgu70/2p74i5jn9upycwaibn5k
the header is not displayed on the screen and has the following message:
{{::column.label}}
https://prnt.sc/qyxmuk
This happens only when viewing a project, the others are demonstrating normally. Does anyone have any tips of what it might be?

@danilovex I think i can help you on this one. For me, this errors occurs on a regular basis, when you are loading to much data in a to big gantt. Try sizing down the gantt. Both in terms of headers used, in the range shown, etc.
At a certain amount of data to be visualized, there is to much computation going on in the lib and the lib tries to cal updateView() before it is done processing the model AFAIK.

Not sure what your view-scale is set to but I just fixed a similar problem by changing the view-scale from days to weeks. Less columns to render.
The project was over a year long so it made more sense to view it in terms of weeks anyway.

I was also facing similar problem when colum count exceeds beyond 500. This is because by default columnLimitThreshold option is set 500 in angular gantt. I fixed my problem by setting columnLimitThreshold to -1 which disables column rendering limit.
Hope this helps. :)


Configure development mode OAuth

Devise provides a dev mode OAuth which simply asks for email and name and behaves like an OAuth provider. This lets us test against Google/Facebook/LinkedIn OAuth without having to actually hook that up.

@smellsblue Please add more explanation. I think this needs to be StockAid 0.2 milestone but am unsure.

Closing. Can be reopened at a later date.


fix: Abort test run instead of crashing when unable to preprocess file

Partially fixes #1213
This patch prevents karma from crashing when a file cannot be opened. Resaving the file will eventually run the tests.
Without patch:
INFO [watcher]: Changed file "c:/modified-file.js".
ERROR [karma]: { [Error: EBUSY, open 'c:\modified-file.js']
  errno: 10,
  code: 'EBUSY',
  path: 'c:\\modified-file.js' }
Error: EBUSY, open 'c:\modified-file.js'

$

With patch:
INFO [watcher]: Changed file "c:/modified-file.js".
WARN [preprocess]: Can not reload "c:/modified-file.js" (code: EBUSY)
PhantomJS 1.9.8 (Windows 7) ERROR
  TEST RUN WAS CANCELLED because this file contains some errors:
    c:/modified-file.js

Thanks, could you add a test for this please?

@backmask ping

Closing due to inactivity


chr vs no chr

Thanks for the script to convert a TruSeq manifest to bedpe file. I can confirm the script and bamclipper worked with my custom TruSeq files.
I did have to remove chr from the bedpe file as I aligned using GRCh37 instead of hg19. I initially didn't catch the chr vs no chr issue and bamclipper ran and output a "clipped" bam file, but the primers weren't clipped. I suggest error checking that the supplied primer file and the aligned bam both use chr or don't. Or internally harmonizing chr vs no chr in bamclipper.
While I was debugging when my primers weren't clipped, I noticed my manifest file has spaces and '+' in it. I initially thought this might be an issue so I modified 'manifest2bedpe.pl' by adding
my $target_key_clean = $target_key =~ s/\s/_/gr;
$target_key_clean =~ s/\+/_/g;

in the conversion for loop.
Thanks again for the program!

Mismatch in reference sequence names is a common scenario. For example, the manifest file mentioned chr1 but your BAM file mentioned 1 for chromosome 1. I just added a check in clipprimer.pl to compare those in SAM SQ header lines versus BEDPE: ea387ba. A warning will be given in your case and please help to try.
For manifest2bedpe.pl, I guess that the current version can properly parse and handle target names containing spaces and '+'. Could you provide any sample manifest lines of concern?

you're right manifest2bedpe.pl parsed my target names with spaces and '+' fine. I just wasn't sure if the spaces and '+' in the name field of the bedpe file was causing issues with clipprimer.pl (it wasn't). Thanks again.


Navigo is not defined

I'm probably just a noob but I dropped in navigo.min.js and Navigo just isn't being found. Both:
var router = new Navigo(root = null, useHash=false);
and
var router = new Navigo();
Is there another component like RequireJS that I'm missing here?

Got it, I had requireJS included in the page but wasn't using it yet which tricked the import conditionals you have at the top.


Count flops

Dear authors,
Thanks for sharing such an excellent work. I tried to count the flops by using the "analyze_model.py". But I find that there is a warnning for unsupported operators, such as "PythonOp.MSDeformAttnFunction". So how to count the whole flops of the models?

There is a PyTorch implementation for MSDeformAttnFunction, you can use it to count flops.
https://github.com/facebookresearch/Mask2Former/blob/9b0651c6c1d5b3af2e6da0589b719c514ec0d69a/mask2former/modeling/pixel_decoder/ops/modules/ms_deform_attn.py#L122-L123

Thanks for your reply. And there are many other unsupported operators. How to count flops for them?
 Could you give some suggestions?


should not accept parenthesized stmts

$ starlark -c "(print())"

$ python -c "(print())"
  File "<string>", line 1
    (print())
         ^
SyntaxError: invalid syntax

I'm not sure exactly where the error is here, but something is not right. :)
Found by go-fuzz, of course.

Haven't dug, but this might be because starlark is treating print as an expr rather than a stmt. This also showed up in go-fuzz output:
$ starlark -set -c "set(((),print))"
$ python -c "set(((),print))"
  File "<string>", line 1
    set(((),print))
                ^
SyntaxError: invalid syntax

The previous case is using the value of print, the built-in function. But evaluated print calls are also allowed in expression contexts:
$ starlark -set -c "set(((),print()))"

$ python -c "set(((),print()))"
  File "<string>", line 1
    set(((),print()))
                ^
SyntaxError: invalid syntax

looks like starlark implementation matches Python3 behavior:
$ python3 -c "(print())"

But unfortunately AFAIK starlark is aiming for Python2 compatibility, so I guess the issue is legit.

"print" is just a predeclared function in Skylark, so it returns a value (None) like any other expression, and, may be parenthesized.
I would not say that Skylark aims for compatibility with Python2 more than Python3. If both Pythons do the same thing, Skylark generally does too; where they differ we have more latitude to choose which one we follow, or do something yet different.


Add argument to optionally generate resource version

Related Issue
Supports #ISSUE_NUMBER
Related PRs
This PR is not dependent on any other PR
What this PR does / why we need it
This PR adds an argument to DryRunDeployManager to optionally generate resource version.
The resource version is generated with a random value, which may cause errors during unit testing.
Special notes for your reviewer
If applicable**

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

What gif most accurately describes how I feel towards this PR?

@HonakerM Thank you! I have signed off the commits.


Adding annotation @hypothesis

hi,
we can look at adding @hypothesis annotation. Would be good to see if annotations can get stored in repo too, along with version
S

This issue was moved to consortium/hybrid-publishing-research#56


Behaviors in this state is not translated

Describe the bug
It's translated in esES/esMX but still shows english
To Reproduce
Steps to reproduce the behavior:
See screenshot
Expected behavior
Should be ["Behaviors for state:"] = "Comportamientos de estado:"
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

I merged your translations

@Pazza that doesn't fix the problem. The addon isn't looking for that string

Should be fixed in 3.10.18


index_LoginRedirect sample does not work.

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Browser:

[ ] Chrome version XX
[x] Firefox version 68.02
[ ] IE version XX
[x] Edge (Chrome-based, latest)
[ ] Safari version XX

Library version

Library version: 1.1.2
(the version 1.1.3 is not available in the CDN at the moment)

Current behavior
When trying out locally the sample of login with redirection, upon clicking on the login button, it throws this exception in the console:
Uncaught ClientConfigurationError: No redirect callbacks have been set. Please call setRedirectCallbacks() with the appropriate function arguments before continuing. More information is available here: https://github.com/AzureAD/microsoft-authentication-library-for-js/wiki/MSAL-basics.
    at ClientConfigurationError.AuthError [as constructor] (https://secure.aadcdn.microsoftonline-p.com/lib/1.1.2/js/msal.js:1510:28)
    at ClientConfigurationError.ClientAuthError [as constructor] (https://secure.aadcdn.microsoftonline-p.com/lib/1.1.2/js/msal.js:1408:28)
    at new ClientConfigurationError (https://secure.aadcdn.microsoftonline-p.com/lib/1.1.2/js/msal.js:1046:28)
    at Function.ClientConfigurationError.createRedirectCallbacksNotSetError (https://secure.aadcdn.microsoftonline-p.com/lib/1.1.2/js/msal.js:1061:16)
    at UserAgentApplication.loginRedirect (https://secure.aadcdn.microsoftonline-p.com/lib/1.1.2/js/msal.js:2091:71)
    at loginRedirect (http://localhost:5000/index_LoginRedirect:84:34)
    at HTMLButtonElement.onclick (http://localhost:5000/index_LoginRedirect:23:54)

Expected behavior
Perform the login normally without any error.
Minimal reproduction of the problem with instructions

download https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-core/samples/VanillaJSTestApp/index_LoginRedirect.html
change the dist/msal.js to https://secure.aadcdn.microsoftonline-p.com/lib/1.1.2/js/msal.js and replace Enter_your_client_ID with a valid clientId
serve with a local HTTP server, like serve (npm i -g serve)

So I tried to come up with a minimal example of login flow using redirection by copy-pasting from existing samples, but the best and simplest of my attempts goes into a redirection loop. Is there a working example of this anywhere?
Here is the code I used:
<!DOCTYPE html>

    <meta charset="utf-8" />
    <link rel="shortcut icon" href="./favicon.ico" />
    <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">

    <link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.3.1/css/bootstrap.min.css"
        integrity="sha384-ggOyR0iXCbMQv3Xipma34MD+dH/1fQ784/j6cY/iJTQUOhcWr7x9JvoRxT2MZw1T" crossorigin="anonymous">

    <meta name="description" content="Expenses Application for M&P" />

    <link rel="apple-touch-icon" href="logo.png" />
    <title>Expenses</title>

    <button class="btn btn-primary" style="display: none">Logout</button>

@pviotti This sample currently is not up to date. There is some effort going on to clean up samples. For a working reference, you can check the index.html code under IE browser check (which works for redirect). We do plan to eventually clean up non working samples. Apologies for the inconvenience.

Would it be possible to post the link to the "index.html code under IE browser check" , unfortunately I'm not sure how to find that. @sameerag

@Dima11235813  I think they meant this example, which indeed has a working redirection flow (for IE): https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-core/samples/VanillaJSTestApp/index.html

@Dima11235813 @pviotti is right. Thanks for the same @pviotti.
I am also doing a quick clean up and will upload a separate sample for redirect flow, please see the PR #959.
The plan was to polish the sample and add more use cases and hence the delay, but looks like there is value in a quick sample that separates the redirect functionality only for now.

This was resolved by PR #959. Please comment if you find any further issues. Thanks.


Ruby 2.6 works with faraday-typhoeus now

Description
Ruby 2.6 (and JRuby) works with faraday-typhoeus now. Gemfile restrictions and README adjusted accordingly. No app changes. Adjusted some Patron test restrictions which were hidden before because Faraday 2 wasn't being tested with JRuby, due to the old faraday-typhoeus version restriction.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Looks like the patron tests weren't previously blocked off for JRuby, which is a no-no for Faraday 2. Fixing that, and also seeing if Typhoeus will work with JRuby the way it says it will.

@VachaShah and @dblock are you up for a review?

@VachaShah this has no app changes, but the README and test changes seem worth backporting to 2.0 and 1.x.


Add listed mentors to the website - Liliia

Task
Add the following mentors to the website
URL - https://womencodingcommunity.com/mentors
Mentors to be added
Liliia Rafikova
Reference: https://womenwhocode.github.io/london/mentors (helpful to get mentor details)
Acceptance Criteria
Screenshot showing the mentors

I can do this one if nobody is working on it already.


i18n(ko-KR): update routing.mdx

Description (required)

update routing.mdx
#9232
#9215

Related issues & labels (optional)

Closes #
Suggested label:

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

ko
guides/routing.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


[DEBUG] [Core AMQP] repro - retry discrepancy

Closing as there is no active next steps here. Please log an issue to track the needful

This repro is not applicable for the streaming receiver anymore because of the forever loop.
I've tested with the managementClient schedule operation.. that worked as expected, so not logging an issue.


Github Commit Profile Image Missing

From @RohanNagar on January 24, 2018 19:47
I know this is a small thing, but I was wondering if this was a bug. If you see here the profile image of dependabot is the default Github image, and not the bot image.
Perhaps this is a side effect of doing the "Squash and Merge"?
Copied from original issue: dependabot/feedback#77

Thanks for the feedback @RohanNagar.
@sbarnekow - one for someone from GitHub?

From @sbarnekow on January 30, 2018 1:2
Thanks for the ping @greysteil 😄  Could you pass that on to<EMAIL_ADDRESS>so it can get routed to people working on it?

Thanks @sbarnekow. Looks like this might be fixed now, though! 🎉


Make *Features work in \defaultfontfeatures

Status
For discussion.
Description
Potential fix for bug #436.
I do not claim this is the correct fix, in fact I'm pretty sure it is not. My intention is to draw attention to this 19 month old bug report and offer a possible explanation for what is going wrong, because it also affects me and I would like to see it fixed.
I have no clue whatsoever about LaTeX 3 code, keyval, or anything else; my expertise just reaches s/preparse/opentype/ as shown here.
Todos

[ ] Tests added to cover new/fixed functionality
[ ] Documentation if necessary
[ ] Code follows expl3 style guidelines

Minimal example demonstrating the new/fixed functionality
See bug #436.

sorry for the, er, slow response...


enforce test coverage

(screenshot from introducing a new untested bogus method)
a cheap/simple/helpful way to check if all the newly added logic is actually covered ... fails and shows what is missing covereage

Certainly appreciate this patch, and I've merged it in, but I'm noticing occasional crashes of Ruby, both locally, and on Travis. Previously, this hadn't been an issue, so I'm wondering if it's related to something SimpleCov is doing?

SingleCov, rather.

I've seen a few on pre 2.3.3 ... after that was never able to replicate, so
could deactivate on lower versions if you see them again ... coverage
should still be accurate.
On Mon, May 8, 2017 at 4:58 AM, Pat Allan<EMAIL_ADDRESS>wrote:

SingleCov, rather.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pat/gutentag/pull/33#issuecomment-299847685, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAsZ8fQBW_1TwvqAN68b3NSvqi5RlwKks5r3wNMgaJpZM4NRfHN
.

I'm still seeing occasional failures on 2.4.1 on my machine, and here's one from Travis: https://travis-ci.org/pat/gutentag/jobs/232660243#L323

... the library is just using ruby ... so idk how to fix that ... if you
find a way to reproduce we can open a ruby issue ... or we rescue the
segfault ;)
On Mon, May 15, 2017 at 7:16 PM, Pat Allan<EMAIL_ADDRESS>wrote:

I'm still seeing occasional failures on 2.4.1 on my machine, and here's
one from Travis: https://travis-ci.org/pat/gutentag/jobs/232660243#L323
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pat/gutentag/pull/33#issuecomment-301656184, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAsZ3m6CodHOa_pK8WUQuyhgVhboW2Kks5r6QbrgaJpZM4NRfHN
.


Instantiate Scanner/Lexer/Parser to isolate their ivars, fixes #45

Thanks for all the great enhancements, @janosch-x
I want to keep an eye on changes as I have an idea that requires regexp_parser. Soon, I hope. At the same time, I'd hate to become a bottleneck to your work with my busy work schedule these days. So please feel free to make decisions as you see fit. Of course I'm still happy to listen if you want to bounce ideas or want another pair of eyes. I just don't want to slow you down.
Cheers!

@ammar Ok, I will let you know only about the big stuff. Don't worry about my speed, though. I only get back to this in very occasional bursts. Regards, J.


Allow ".licensee.js" configuration file

For sharing configuration files between projects as NPM modules it is useful to use dynamic JavaScript files as configuration, in addition to JSON files.
ESLint Config Docs or Commitlint Config Docs can be used as reference.
The .licensee.js configuration file could look like this:
module.exports = {
  licenses: {
    spdx: ['CC-BY-3.0'],
    blueOak: 'bronze',
  },
  packages: {
    'deep-is': '0.1.3',
    diff: '1.4.0',
    doctrine: '1.5.0',
    esutils: '2.0.2',
    'json-schema': '0.2.3',
    wordwrap: '0.0.2',
    longest: '1.0.1',
    'repeat-element': '1.1.2',
  },
  corrections: true,
};

Why is it useful? All of this data is static (as should be all configuration, ideally)

I use it for sharing the configuration between projects by creating an "@project/licensee-config" NPM package, which I then export in the .licensee.js file.
It's also possible to override single keys in specific projects.
const config = require("@project/licensee-config");

module.exports = {
  ...config,
  somekey: "override",
};

For keeping the configuration up to date, I just need to update my dependencies and skip copying JSON files to all projects, which makes it also easy to automate with Dependabot or Renovate.

That's interesting. I wonder tho if eslint-style extension would be better, like this:
{
  "extends": "@project/licensee-config",
  "somekey": "override"
}


Cocoapods

Hey,
It would be great if you could support Cocoapods, would make my life a lot easier. :)
Thanks!

if you're still interested you can use pod 'Stylized', '~> 1.0.0'


-app-port for listen port, mm installation

Update order_processor to listen on -app-port vs. hardcoded port number of 6001. This hardwiring requires the documentation to be updated every time the port changes. Currently, the port used and the documentation are out of sync. By moving to listening on -app-port, order-processor can be run successfully irrespective of the port specified by the user.
Since quickstarts are for folks bootstrapping on Dapr it is good to automate dependency setup. To run make in quickstarts, mechanical_markdown is a hard dependency. This is not clearly documented and hence make fails. Updated validate.mk to install mechanical_markdown in case it is not already installed.

Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #656
##Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] The quickstart code compiles correctly
[ ] You've tested new builds of the quickstart if you changed quickstart code
[ ] You've updated the quickstart's README if necessary
[ ] If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

ping @akhilac1

This change applies universally across all the quickstarts. At least this PR should also apply to Go examples for HTTP and SDK for Pub/Sub, Service Invocation and State Management. This only fixes Pub/Sub currently.

@akhilac1 Can you rebase this PR with master and push the changes for the builds to be successful?

@amulyavarote - The tests are passing now. Can you please approve the PR so that merge can be completed.

This change applies universally across all the quickstarts. At least this PR should also apply to Go examples for HTTP and SDK for Pub/Sub, Service Invocation and State Management. This only fixes Pub/Sub currently.

@msfussell - Will cover this in #661


Add simple component test for ChemFormInput

Just testing this out for now, but otherwise could be useful for the development of #634 & #208

I fixed the cypress tests on the components. It should work now.
For this particular test, this still doesn't work because:

By default, “editable” is set to false, so the input does not appear when cypress mounts the component.
Chemical formulas don't format properly (Na3 stay Na3 and not Na3

Hmmm, not sure if I broke this again @BenjaminCharmes with my rebase + changes! I was just trying to get it to also show the e2e test results in GitHub again, but now the tests are back to failing because the component is not displayed. Perhaps you could work some magic again when you get a moment?


feat(aws): add additional Autoscaling Group prices and costs

Objective:
Add more options for aws_autoscaling_group.
Example output:
  aws_autoscaling_group.asg1
  └─ aws_launch_configuration.lc1
     ├─ EC2 detailed monitoring                           14  metrics      0.3000       0.0058        4.2000
     ├─ Linux/UNIX usage (on-demand, m3.medium)         1460  hours        0.0740       0.1480      108.0400
     └─ root_block_device
        └─ Storage                                        16  GB-months    0.1000       0.0022        1.6000
  Total                                                                                0.1559      113.8400

  aws_autoscaling_group.asg2
  └─ aws_launch_template.lt1
     ├─ EBS-Optimized usage                             1460  hours        0.0200       0.0400       29.2000
     ├─ EC2 detailed monitoring                           14  metrics      0.3000       0.0058        4.2000
     ├─ Inference accelerator (eia2.medium)             1460  hours        0.1200       0.2400      175.2000
     ├─ Linux/UNIX usage (on-demand, r3.xlarge)         1460  hours        0.3330       0.6660      486.1800
     └─ root_block_device
        └─ Storage                                        16  GB-months    0.1000       0.0022        1.6000
  Total                                                                                0.9539      696.3800                                                                                0.3541      258.4900

Pricing details:

EBS-optimized usage costs are charged for previous generation instances that have ebs_optimized = true set.
t3 and t4g instances launch by default in "Unlimited" mode which means that CPU credit costs can apply. This depends on the number of vCPU-hours that are used by these instances over the baseline. t2 instances also support "Unlimited" mode, but this is disabled by default.
Launch configurations have EC2 detailed monitoring turned on by default

Status:

[x] Add EBS-optimized costs
[x] Add EC2 detailed monitoring prices
[x] Add CPU credits prices
[x] Add a warning if tenancy is host
[x] Update "Compute" to "Linux/UNIX Usage" to be consistent with AWS pricing page
[x] Add Elastic inference accelerator costs
[x] Add spot pricing for Launch Configurations and Launch Template
[x] Fix tenancy costs
[x] Add integration tests

Useful links:

Pricing: https://aws.amazon.com/ec2/pricing
Terraform:

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/autoscaling_group
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/launch_configuration
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/launch_template

Looks like this will fix https://github.com/infracost/infracost/issues/104


Time field should show placeholder all the time

Time pickers don't show the placeholder, they have their own interface, so it needs to show the label above with the placeholder from the start.

Fixed by adding an option permanentTopPlaceholder to textfields and textboxes in PUR #36


Aggregate plugins to org

Would be great to migrate some of the popular plugins such as gulp-6to5 and grunt-6to5 over to the 6to5 org.
As of current I've been hesitant to bump major versions because it'd make upgrading all the major plugins a hassle.
@sindresorhus Would you be open to this? If not, just wanted to see if you had any ideas to improve this process. I'm more than willing to add you as a collaborator, whatever works for you.

[x] Broccoli
[x] Brunch
[x] Duo
[x] Gobble
[x] Gulp
[x] Grunt
[x] Jade
[x] Karma
[x] webpack

Ping @nightire


Performant graph plotting and benchmarking

I think it's time to start looking at the performance of GraphMakie.jl
I guess this mostly means rewriting most of the code to be type stable..
To do such a thing, I suggest that we first setup a benchmarking toolchain, to track improvements.
Such advancements will be very useful for interactions, animations, and big graphs.
In my use case now, I have a graph with 8814 nodes and 48583 edges.
The default plot requires 219.085997 seconds (1.97 M allocations: 122.813 MiB, 0.03% gc time) in my machine.
I am not sure how much better this can get..but it will be exciting to find out!

Wow thats a long waiting time... As a first step it might be interesting to sprinkle a few TimerOutputs.jl annotations in the recipe to get an idea of how much time is spent within GraphMakie and how much time is spent in the linesegments and scatter calls.

Or benchmark the layouting algorithm directly? I doubt that the plotting will be the bottleneck here ....

Also, during plotting the recipe code is always run twice (not exactly sure why though). Would be nice to somehow detect the first run and skip the layout algo there to not run an expensive layout twice. Simon do you have any idea on how to detect that?

Uh, we should just fix it in Makie...
The user can already avoid that by calling plot(...; axis=(type=Axis;)) or whatever axis type you want.
Right now we need to plot it one time to figure out the axis type :D But, we do hope to remove this in the next breaking release


Insert forced linebreaks in very long words overflowing their .errornote element

Before:

After:

Hi @matthiask this is a behaviour change. Can I get you to open a Trac ticket for it please? Ta.

@carltongibson Sure, will do. Thanks for the feedback.
(I'll do the same for the other CSS PRs too, then.)

@matthiask Thanks :+1: I think we should do the same for ul.errorlist li.

@felixxm Thanks for the feedback! I have updated the PR.

buildbot, test on selenium.


Get rid of advanced config options

From the beginning the separation of "simple" and "advanced" options felt wrong for me but some requirements wouldn't be met without that. In case we can resolve #271 there is no actual need in other options to be in config.

gitDir should be resolved automatically. See #271
I'm thinking of deprecating subTaskConcurrency since it's not safe to take any other value than 1
chunkSize can be set automatically depending on OS
concurrent can be deprecated since it is only misused ATM and make execution slower and there is no benefit in setting it
verbose should not be in config but a CLI argument IMO
globOptions is probably be coupled with each glob pattern separately and just go inside the single linter's config after #273 is merged

This would allow simplifying the configuration and validation of user configs and make it even more easier to use.
Any thoughts?

gitDir should be resolved automatically.
chunkSize can be set automatically depending on OS

Good improvements for UX, +1 for these..

verbose should not be in config but a CLI argument IMO

Why don't we support it both as CLI argument and also in the config file?

Why don't we support it both as CLI argument and also in the config file?

because this will require to keep the advanced config which I want to drop. Also feels wrong from the UI perspective: verbose mode is intended to be used when something doesn't work as supposed.

@okonet thank you so much for this fantastic library! I see you are figuring out what to do about ignore. Is there a place where we can see some working code with that? I am trying to ignore my test files in React and cannot seem to do so! The test files are being included in the linting itself. Any help would be appreciated, and I have also attached a screenshot of my project structure for reference :)
"lint-staged": {     "linters": {       "src/**/*.js": [         "npm run lint",         "npm run prettier",         "git add"       ]     },     "ignore": ["src/**/*.test.js"]   },

You can check #639

@okonet concurrent was actually useful to our use case because we couldn't have linting run in parallel across multiple files. Yes it is slower, but it actively prevents us from having collisions by Prettier and ESLint when they are combined in our CLI that we run. Should it not be the choice of the user to go slower in this case? I'd like to advocate that it be brought back, especially since you are just passing an option to Listr. I would have spoken up prior to v9, but I didn't follow along and know this was coming (sorry).
I wanted to reach out and post here first before having to decide how we refactor to support this now since we have users who all have concurrent set to disabled.

I have been running eslint, prettier, tslint and many other linters in parallel without issues for years now so I’m wondering why are you having them. Concurrent was only set to the different globs and was always false for the same glob. The only scenario where I could imagine collisions is when your globs match same files.


vite:hmr circular imports detected: /src/index.css -> /src/main.jsx -> /src/index.css

Describe the bug
This dependency chain needs to be more specific.
I'm finding cyclic dependencies of my vite-react project using --debug hmr flag, which works exceptionally well for other dependencies.
However, now I'm stuck on this one. It says /src/index.css uses /src/main.jsx which I don't understand.
I'm using Tailwind, and this is the content of my index.css file:
@tailwind base;
@tailwind components;
@tailwind utilities;

@layer utilities {
    .link {
        @apply underline text-blue-600 cursor-pointer
    }

    .link:hover {
        @apply text-blue-800
    }

    .link:visited {
        @apply text-purple-600
    }
}

I can't find out why and how this file uses main.jsx.
I also tried to create a reproduction, but I failed. I'll send the reproduction attempt, though.
Reproduction
https://stackblitz.com/edit/vitejs-vite-rf8vvv?file=src%2FApp.jsx,src%2Findex.css,src%2Fmain.jsx&terminal=dev
Steps to reproduce
No response
System Info
System:
    OS: Linux 6.2 Debian GNU/Linux 12 (bookworm) 12 (bookworm)
    CPU: (4) x64 Intel(R) Core(TM) i5-7600 CPU @ 3.50GHz
    Memory: 6.58 GB / 15.49 GB
    Container: Yes
    Shell: 5.2.15 - /bin/bash
  Binaries:
    Node: 20.10.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.4 - /usr/local/bin/npm
  npmPackages:
    @vitejs/plugin-react: ^4.2.0 => 4.2.0
    vite: ^5.0.4 => 5.0.4

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

It’s unbelievable that such simple code doesn’t support hmr
I thought only complex code is not supported

Just kidding, maybe the unborn Rolldown will solve it

@MuhammadHamzaChippa nope. We just suffer from a full reload for each character that we change in our source code.

@MuhammadHamzaChippa never. For us, CRA would take more than 70 seconds just to compile. Vite compiles in less than 500 milliseconds. We will never go back to CRA. But we're stuck at this Vite problem now.


[Cosmos] Retry options type should be Partial

We should not make users specify the full retry options object. It is ok to pass a partial object for this and omit properties they do not want to override.
@zfoster has context here. We will fix this in an upcoming release.

closing this issue


fix: Add fullWidth prop to <RadioGroupMinimal

Adding fullWidth prop so that by default <RadioGroupMinimal doesn't span 100% width of parent. When there was only a couple of radio options, the design looked a little wonky on account of options being spread to extreme left and right when direction was set to row.

BEFORE
AFTER (default)
AFTER (fullWidth)

UPDATED DOCS

UPDATED KNOBS

direction="row"
direction="column"

Closes #213

Looks great to me! Only suggestion is adding a test to ensure the right classes get applied when adding the fullWidth prop. Let me know if you need a hand!

✅


Paradoxical left recursion

I just tried the following grammar:
G { A = ~A "b" }

...and was surprised to see that it succeeds in matching "b". Isn't this a contradiction? We can match A at position 0 iff we can't match A at position 0.
It's not likely that anyone would write a rule like this directly, but I could see it happening more easily indirectly. I'm not sure what we could do about this -- would it make more sense to fail at the head when the left-recursive application is encountered? Arguably that's no better, but somehow failing seems more sensible to me.
A similar case is A = A? "b".

The second case A = A? "b" seems to be more plausible for me (the first A? simply is matched by nothing).
The first one though seems like a surprise... how does that work?

Our left-recursion algorithm works by (i) initially making left-recursive applications fail so that we can find and memoize a "seed parse", and then (ii) repeatedly evaluating the body of the left-recursive rule to until the result stops growing. (The second step is called Grow-LR in the paper.)
So your "paradoxical" rule will happily match a "b" because the ~A will initially succeed (because the left-recursive application A fill fail). The Grow-LR step won't do anything because the ~A will now fail (because the A will succeed), so the seed parse becomes the result of the entire application.

I totally understand why it happens -- the reason I opened the bug is to suggest that we handle it differently:

Would it make more sense to fail at the head when the left-recursive application is encountered? Arguably that's no better, but somehow failing seems more sensible to me.

(Of course, feel free to close again if you don't think that makes sense, or don't think it will work, or don't think it's worth the effort.)

Oh, sorry. Missed that part.
I think this is an interesting thought experiment, but I can't think of an (non-contrived) example where this would come up. Can you? If not, I'd rather spend time on other issues / desirables in Ohm, e.g., support for incremental parsing.


Inconsistent width for list selector

When choosing a "Temperature source"  for a "custom sensor" or a "curve", the selection list will dynamically change its width based on the widest entry in the list, depending on which part of the total list of available temperature sources are shown. This causes issues when using the scroll bar to move up and down in the list.
It would be better to keep the selection list wide enough to show the "widest" entry and keep that width when scrolling through the list.
See the attached screenshots that show the width when showing the first part of the list, and then the width when scrolling further down.

This was for FanCOntrol not FanControl.HWInfo


Bugs: hide-and-seek

STATUS: REQUIRED CHANGES ♻
Hi [@sebalp100  ]👋
Great job so far, There are some changes that need to be implemented in order to proceed to the next project 👍

Highlights:
Professional README file ✔
Correct Github flow ✔
Required Changes:
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

[ ]Please remove this parenthesis, the presence of this is not required https://github.com/sebalp100/Bugs-hide-and-seek/blob/92cae6b2c82cbba8e993ff9350403b02cf426cd5/script.js#L155

[ ] Please remove the extra letter  "s" into the word  "querySselector" https://github.com/sebalp100/Bugs-hide-and-seek/blob/92cae6b2c82cbba8e993ff9350403b02cf426cd5/script.js#L377

[ ] The class is empty, please insert the  the class ".menu-button" https://github.com/sebalp100/Bugs-hide-and-seek/blob/92cae6b2c82cbba8e993ff9350403b02cf426cd5/script.js#L1


Comments: 2023-03-20 託孤寄命

《三国志·魏书二十二·桓阶传》

This is a demo comment with link posted on the issue on GitHub. The epigraph is from 《三国志·魏书二十二·桓阶传》.


feature support range requests for blobs

#548

One suggestion is to use SectionReader to convert the ReaderAt to a Seeker.
https://pkg.go.dev/io#SectionReader
While the intention is to allow reading specific sections in a file we can use it to pass the full offset. It would remove the need to implement our own seeker.


haskell: make generic builder follow compiler’s shared config

enableShared in generic-builder.nix should default to what the GHC
compiler was compiled with. Add a passthru to all of the GHC compilers
to hold the value of enableShared. If enableShared is not set in the
GHC we just use false as the default value for enableSharedLibraries.
Note: I may have missed some compilers. Only GHC & GHCJS are covered
by this commit but this shouldn’t break evaluation of anything else.

Added 8.2.1-binary

enableShared in generic-builder.nix should default to what the GHC compiler was compiled with.

Why should it?

Why should it?

My understanding is that if you're compiler wasn't compiled with "enableShared", setting "enableSharedLibraries" to true, will break things.

enableSharedLibraries ? (ghc.isGhcjs or false) || stdenv.lib.versionOlder "7.7" ghc.version)

is always true today. I gather this is because old GHC didn't support dynamic linking, so that reads "true where possible". If anyone has a custom compiler that doesn't support dynamic linking, they can do passthru = { enableShared = false; }; just like with the prebuilt ones. If we want to add additional conditions we can do
enableSharedLibraries ? ghc.enableShared or false && additionalCondition

The point being deduplicating the logic like this doesn't tie our hands.

My understanding is that if your compiler wasn't compiled with "enableShared", setting "enableSharedLibraries" to true, will break things.

I see an argument to be made that you'd want things to break in that case. The enableShared default in the generic builder can be viewed as expressing a policy that compilers ought to fulfill and if someone uses the generic builder with a compiler that does not fulfill that policy then you ought to pass a proper enableShared setting along your custom compiler. That approach makes these choices more explicit, whereas the new scheme that @Ericson2314 chose to merge without waiting for my review makes this choice implicit.

Feel free to revert if you disagree. This was motivated by the need to have "enableSharedLibraries" set to false in prebuilt Android & iOS (which is the default for their config) and they are broken otherwise. I felt like this approach would avoid the most duplication but there are certainly other ways to accomplish this. If you do want to revert I hope it is okay to add an extra condition to enableSharedLibraries in generic-builder.nix.

Yeah we can revert this in the interim, but let me continue to argue for this approach.
@peti so first of all, are you OK with us adding the cross exceptions to the generic builder default? If we do, then the default becomes a verbose condition that doesn't to me express a policy other than "build shared libraries where possible". (Any other interpretation would strike me as an "overfit" one.) If we don't, then users must manually instruct generic-builder even when they don't actually care and just want working builds.

I just would have liked to have this conversation before the merge, not after. Anyway, I don't feel strongly enough about this issue to bother reverting those changes now. Both scheme have their advantages, and the state we have now feels just fine.


GTK example doesn't build on latest main

Describe the bug
GTK example doesn't build on latest main
To Reproduce
Steps to reproduce the behavior:
cargo run --features gtk
Expected behavior
For example to run
I tried to fix it but it seems there are multiple different compilation errors,

I believe our 0.7 release is still in progress on the main branch. Would recommend trying the 0.6.13 tag

(This is fine and I will update it -- I think we removed examples/gtk from CI at some point so I didn't notice that it needs an update. The version in the repo is also a weird hybrid I created for a demo, IIRC -- I will probably restore it to a purer GTK form.)


use symbolize_keys for legacy yajl-ruby compatibility

Version 1.1.0 of yajl-ruby uses symbolize_keys instead of symbolize_names to parse the JSON string into a hash where the keys are symbols.

Looks good to me I'll cut a release for 1.2.2.