Radarr

Hello,
Thank you for you work.
I have a question about how the chatbot on Discord works.
I use Requestrr and Radarr, which are not accessible from the WAN, I connect to it via VPN.
The chatbot works very well, I can add movie to Radarr.
I would like to understand technically how the request from discord can reach my server with Requestrr and Radarr.
Thank you

Hey @Nautilus34,
Fair enough, the bot connects to Discords API's using a library called DSharpPlus, this library allows the bot to receive messages and server updates.  I cannot explain how this works in detail as there a lot to go into depending on the depth, but all you really need to know is the bot will talk to Discords APIs and stay connected while the program is running, when it needs to send a notification it will send the message to Discord and who it is too.
When a message or command is sent to the bot, Discord will alert the program, causing it to respond to the command.  Each part of the command is checked and depends on what that command is, it will act accordingly, e.g., request or issue to report? A movie or a TV show?  What is the name of the media.
Requests asking for a movie are sent to the client setup with the bot, in your case, Radarr's API, Radarr will respond with movies found by the name given, the bot then turns those movies into a message for you to select, upon choosing a movie and requesting it, the bot will send the requested movie ID to the client application.
I hope that gives a rough outline of what is happening and answers your question, there is a lot of technical things going on here so it your question is quite broad.

Hello @thomst08
Thank you for your time and for the explanations. I understand how it works now, and I’ll continue to research further.


Make pip install process faster/smarter

I'm working on a project with a large number of large Python dependencies in requirements.txt and installation takes forever.
It would be nice if there was a way to bypass processing requirements.txt OR a way to say "only process if it's changed since last time" to avoid this overhead every time zpm "load" is called.

My quick solution for this in my local base lifecycle class:
Method InstallPythonRequirements(pRoot As %String = "", ByRef pParams)
{
  Set cmd = $Get(pParams("cmd"))
  If '$ListFind($ListBuild("install", "load"), cmd) {
    Quit $$$OK
  }
  Set tVerbose = $Get(pParams("Verbose"))
  Set pythonRequirements = ##class(%File).NormalizeFilename("requirements.txt", pRoot)
  If '##class(%File).Exists(pythonRequirements) {
    Quit $$$OK
  }
  If $Data(pParams("BypassPython"),bypass)#2 && bypass {
    Do ..Log("requirements.txt SKIPPED")
	Quit $$$OK
  }

Then run load with -DBypassPython=1

It looks great and I suggest using -DBypassPython to -DBypassPythonDeps or -DBypassPythonReqs. After all, who knows where else we need to use Python in the future 😄


:bug: Create inventory topic

Summary
Need to create kessel-inventory topic and grant the permission to global hub user.
Related issue(s)
Fixes #

/test test-integration

/lgtm

/test test-integration

/test test-integration


Plans for the future

@hunterjm any plans in continuing this auto buyer for FIFA 18??

Most likely.

👍

What this programs needs is a scheduler that lets you configure at what times the program runs, for how many hours, at random times etc.
All of my accounts have been banned after some time, even with RPM=4.
The autobuyer has to mimic human behaviour better than with the current version.

I hope you keep going with this ab for fifa 18!

@hunterjm is there any chance to make this work on a mobile device? that would be great.


Roll Engine from ac8b9c4c52ea to d1d848e8421e (15 revisions)

https://github.com/flutter/engine/compare/ac8b9c4c52ea...d1d848e8421e
2020-09-04<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from EN2ycWLxi... to sih5f60Gt... (flutter/engine#20999)
2020-09-04<EMAIL_ADDRESS>Roll Dart SDK from 0f0cff3922ad to f3a9ca88b664 (1 revision) (flutter/engine#21000)
2020-09-04<EMAIL_ADDRESS>adjust blur radius for HTML to match CanvasKit (flutter/engine#20840)
2020-09-04<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from 81O8Kg_Rw... to A0PKwETay... (flutter/engine#20998)
2020-09-04<EMAIL_ADDRESS>[Android R] Sync keyboard animation with view insets vs Android 11/R/API 30 WindowInsetsAnimation (flutter/engine#20843)
2020-09-04<EMAIL_ADDRESS>Roll Dart SDK from 016e8880f0ab to 0f0cff3922ad (7 revisions) (flutter/engine#20990)
2020-09-04<EMAIL_ADDRESS>improve sensitivity of BackdropFilter web tests (flutter/engine#20915)
2020-09-04<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from gOI3W1UNU... to EN2ycWLxi... (flutter/engine#20985)
2020-09-04<EMAIL_ADDRESS>Manual roll of Dart b29f228f62...016e8880f0 (flutter/engine#20967)
2020-09-04<EMAIL_ADDRESS>Update test Dart code to pass the latest Dart analyzer rules (flutter/engine#20986)
2020-09-04<EMAIL_ADDRESS>Let FlutterActivity/Fragment/FragmentActivity have an app bundle path override instead of eager resolving during construction (flutter/engine#20769)
2020-09-03<EMAIL_ADDRESS>Don't use GetTaskQueueId() in rasterizer as it breaks Fuchsia (flutter/engine#20983)
2020-09-03<EMAIL_ADDRESS>restore FML_DCHECK removed due to a code reviewing error (flutter/engine#20953)
2020-09-03<EMAIL_ADDRESS>Roll Skia from 1ee21cdfb6fe to 6763a713f957 (1 revision) (flutter/engine#20982)
2020-09-03<EMAIL_ADDRESS>Populates fuchsia node actions in semantics updates. (flutter/engine#20451)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 81O8Kg_RwUtu to A0PKwETaylAF
fuchsia/sdk/core/mac-amd64 from gOI3W1UNUuIU to sih5f60Gt1RX
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Gold has detected about 2 untriaged digest(s) on patchset 15.
View them at https://flutter-gold.skia.org/cl/github/65275


Add CodeQL workflow

De-lomboks before build
Runs extended security and quality suites

This failed b/c we're using Lombok's @Delegate in PollerSyncInvokerWrapper


Support domainIncludes and rangeIncludes

Hi!
A couple of things: really like the library! I also saw you are on vacation until 2018 (enjoy!), so no expectations of urgency here. So I've been using you're library to build a GraphQL API based on an ontology, while using your aquest repo as a guideline. As part of my ontology I would like to extend some schema.org classes, but I ran into a problem there. I was able to include their ontology, but it uses schema:domainIncludes and schema:rangeIncludes to indicate relationships between classes. I did some work on Google and found a discussion about the subject here, which seems to indicate that the Includes version is preferable, although I imagine supported both should be easy enough as well. Any thoughts on the matter? Would be happy to help out with a PR.

hey @steffansluis did you could use this library to work with schema.org? I am playing with some alternatives to work with schema.org on graphql.

Yes this lib can work with the schema.org ontology!

@dherault rdfs:domain/range are monomorphic, i.e. should take only one value. Eg your use of multiple rdfs:domain at https://github.com/dherault/aquest/blob/master/ontology/_shared.ttl#L13 and L19 is incorrect.
schema:domain/rangeIncludes are polymorphic.
Cheers!


Dockerfile: apt-get upgrade to get the latest packages

Fixes: https://github.com/scylladb/k8s-local-volume-provisioner/issues/42

Closing as it's already done as part of base image and executed as periodics.


Add DNS server collector

This PR adds a collector for the Windows DNS Server.
There's not much documentation for this one, sadly. I've tested it on my work environment, and also set up a pair of VMs to test the zone transfer stuff (we don't use that) and it all seems reasonable, but there may be some metrics that are actually overlapping (for instance IXFRSuccessReceived is likely the sum of IXFRTCPSuccessReceived and IXFRUDPSuccessReceived, so I skipped it, but I was unable to make my systems actually generate non-zero values for those counters).
Naming is up for debate, I'm not super-pleased with a lot of the names. I've created a gist here where the metrics, their labels and the included counters as well as some values from my production environment are shown.

@brian-brazil Updated with the new name suggestions. Anything else that could be better?
@martinlindhe Any comments?

:+1:

looks great, merging!


AST: simplify debug flag computation

Use an algorithmic approach to string concatenation rather than building the space delimited string manually. This allows us to extend the flags embedding more easily in the future.

@swift-ci please test


User input for Pin code required in configuration AND services in 3.0.0 Beta 2

@msp1974 The Pin code is required in the integration configuration and most of the service calls. Couldn't we just require the Pin code in the configuration and read it from configuration properties for each service call?

Yes, this probably makes sense.

More inputs on Pin code:

we should probably not set any default value(0000) for Pin code in the config flow. This is required field and there is really none default value for this field
Im not sure if Pin code 0000 is actually accepted or not when configured in the car. However, we shouldn't check and  assume that this is not accepted, like we do here.

In principle agree, however we have to migrate from the previous optional config.  I wonder if we set a default of 0000 in the migration if not already set but then remove pin requirement in services and raise error if not set when calling them.

OK, when looking at this, there is a slight issue if you have more than one car on the account with different pins.  Therefore made the pin in the service call optional.  So it should work like this:

When migrating from v2.2.7, the pin is set to 0000 if not set in options.
In v3.0.0, if pin not changed from 0000, it will error if pin not provided in service call
In v3.0.0, if pin is set to something other than 0000 in config and not provided in service call, will pass config pin
In v3.0.0, if pin is set to something other than 0000 in config but supplied in service call, will use service call pin (to allow for the multi vehicle scenario).

Do you think this is good logic to support migration of users not having set in options on older verison and also the multi vehicle on 1 account scenarios.  Will also ensure those migrating with service calls in automations will continue to work.

Hi Mark! Hope you enjoyed time off from computer for the past 6 weeks :)
Good point regarding multiple cars, I focused only on my own use case having one car. Before commenting on your suggestions, how does the integration (v3) handle multiple cars in HA? You setup the JLR integration with a Pin code and then you get one device per vehicle. Correct?
If so, how does the new Switch and Button (Charging, Climate, Guardian Mode, Climate, Service Mode etc) entities behave when you configure only one Pin Code in integration configuration flow? Service calls are just an alternative to the new Switch and Button entities automatically created for a device.

Hmmmm...that's a very good point.  Need to think about that and find a solution.  But yes, one device per vehicle with same set of entities.

Would it be possible to set restriction: one vehicle per integration entry? So if you have two vehicles you define two separate integration entries, with their own pin code and one single device? Then we could maybe read the pin code corresponding to the target entity / device in service calls?

Maybe. To do that we would have to read the vehicles during setup in the config flow, so I was thinking if we have to do that anyway, we could ask for a pin for each vehicle during config flow. I'll have a play this week and see which option works best.


Improved Clarity in Demonstration, Summarizer, and Command Configuration

Corrected minor phrasing issues in demonstration, summarizer, and command configuration docs for clarity.

The phrase "Observation output exceeding these number, will be summarized" corrected to "Observation output exceeding this number will be summarized."
"we only ingest demonstrations in the from of a trajectory file" corrected to "we only ingest demonstrations in the form of a trajectory file."
"You can also leverage third party libraries (check out how we do linting enabled edit in config/commands/edit_linting.sh)" corrected to "You can also leverage third-party libraries (check out how we enable linting in config/commands/edit_linting.sh)."

Thx


Refactored template to ES6+ syntax

I refactored the code for the default react template from ES5 syntax to ES6 syntax

Hi @samuelorobosa,
the template is using a function component on purpose, similar how they are introduced in the docs.
If you prefer class based components in the template, look into custom templates :) Thanks!


Create factory for converting non blocking MatchingChecker into an AsyncMatchingChecker

This would work for any situation where all matchers involved use non-blocking i/o on the WebContext

Not viable because of interface mismatch between Matchers and AsyncMatchers in parameter list. In short, we need to define async matching checkers.


Improve doc

Thanks for the official opensuse integration @jebhul ! I've updated our doc.

Thanks for the official opensuse integration @jubhal ! I've updated our doc.

Thanks for the official opensuse integration @jubalh ! I've updated our doc.


Please Can I Join This Organisation? : )

Name: Rithik Sarab

@rithik112
Our Website 🌐 | Repositories 📚 | LinkFree Profile 🔗
You have received an email to join, or press this link - https://github.com/App-Choreography - , and you'll see a banner, for you to join the organisation! 🎉
You can also show that you are part of this org, by making yourself public. This will show our profile org on your profile:
Follow This:

After you join the organisation, search your name in the list of people. 🔍
Follow this below: ⬇

When you join our org, you will be automatically be part of our community team, where you will get updates, and news about our org!
We are so happy you have joined! Welcome to App Choreography! 🥳


Daffodil 1444 runtime backpointers

Removes backpointers to parent from RuntimeData structures.
Turns out they are not used, except in one unparser to check an Assert.
This is a cleanup, as well as removes one need for the schema compiler to have backpointers. Now the only reasons it needs backpointers are its own.

Created wrong. Closing


Speed up simulation by removing connection with low weight

While an interesting idea I think we're going to allow this inefficiency


Add architecture ppc64le to travis build

Hi,
I had added ppc64le support on Travis-ci and Its been success added and build. Kindly review and merge same.
Changes done are added ppc64le arch and exclude LUANAME=luajit-2.0  since its not supporting ppc64le Arch.
The Travis ci build logs can be verified from the link below.
https://travis-ci.com/github/zazzel/lgi/builds/206977452
Please have a look.
Thank you

Hi,
thanks a lot for this PR.
However, I have to ask: Sorry, but what is the motivation for this? For example, one could add a Travis build with a big endian architecture because big endian causes much problems / has much differences. Or a reason could be "there were a couple of times where problems for ppc64 slipped through / could have been caught by CI". Is there something like this? Or are you just adding this PR "because".
My main issue with Travis in recent times has been build time. It only runs 3(?) jobs in parallel.
Random data point:

https://travis-ci.org/github/pavouk/lgi/builds/673164708 says "Total time 3 min 7 sec"
https://travis-ci.com/github/zazzel/lgi/builds/206977452 says "Total time 7 min 47 sec"

Hi Team,
This PR adds CI support for the IBM Power Little Endian (ppc64le) architecture. The idea is to ensure that the builds on this architecture are continuously tested along with the Intel builds (amd64) as this is part of the ubuntu distro on that architecture as well and detecting (and fixing) any issues or failures early would help to ensure that we are always up to date.
Thank you


Add VWAP indicator

I was very suprised to see that VWAP is not included in the Indicator list. What would it take to add this widely used indicator? Was it left out for a specific reason?
There are five steps in calculating VWAP:

Calculate the Typical Price for the period. [(High + Low + Close)/3)]
Multiply the Typical Price by the period Volume (Typical Price x Volume)
Create a Cumulative Total of Typical Price. Cumulative(Typical Price x Volume)
Create a Cumulative Total of Volume. Cumulative(Volume)
Divide the Cumulative Totals.

VWAP = Cumulative(Typical Price x Volume) / Cumulative(Volume)
source: https://www.tradingview.com/wiki/Volume_Weighted_Average_Price_(VWAP)

@lppkarl Could you provide some high-level guidance on this by chance?
I'm attempting to wire this indicator up on my own but it looks like the closest base class to what I need is CumulativeNumericAnalyzableBase, which provides a single means of accumulating data. It appears what I am after is a DualCumulativeAnalyzableBase since I need to accumulate both Typical Price and Volume separately to devide it later.
Am I thinking about this the correct way?
Any guidance would be greatly appriciated and I'll be happy to submit a pull request once the indicator is complete.

@codebeaulieu sorry for the late reply as I was very busy for my job. You may think it like this:
If you want to get the vwap, you have to get the Cumulative(Typical Price x Volume) & Cumulative(Volume) first, this will be treated as 2 different Cumulative indicators.
The vwap indicator should be implemented like this:
public class VWAP<TInput, TOutput>: NumericAnalyzableBase<TInput, (decimal High, decimal Low, decimal Close, decimal Volume), TOutput>
{
    private CumulativeTypicalPriceVolumeProduct _indicator1;
    private CumulativeVolume _indicator2;

    public VWAP(some parameters here)
    {
        _indicator1 = new CumulativeTypicalPriceVolumeProduct(...);
        _indicator2 = new CumulativeVolume(...);
    }

    protected override decimal? ComputeByIndexImpl(IReadOnlyList<...> list, int index)
    {
        return _indicator1[index]/_indicator2[index];
    }
}

And the 2 cumulative indicator should be implemented using the cumulativeNumericAnalyzableBase like this:
public class CumulativeVolume <TInput, TOutput>: CumulativeNumericAnalyzableBase<TInput, decimal?, TOutput>
{
    public CumulativeVolume(some parameters here)
    {
    }

    protected override decimal? ComputeCumulativeValue(IReadOnlyList<...> list, int index, decimal? prevOutputToMap)
    {
        return prevOutputToMap + list[index];
    }
}

Of course, the above 2 only shows a draft of the indicators, the central idea is to divide the indicator into different manageable sub indicators and solve the individual indicators. i.e. VWAP consists of 2 cumulative indicators, then we make VWAP a normal indicator which calls the 2 cumulative indicators.

@lppkarl Alright, I believe I may have this correct. The data I have at my disposal is IEX data, which, if I understand correctly doesn't reflect volume accurately. I'll seek out a better source here this evening so I can test properly.
Could you review my implementation and let me know if this looks correct to you.
VolumeWeightedAveragePrice
 public class VolumeWeightedAveragePrice<TInput, TOutput> : NumericAnalyzableBase<TInput, (decimal High, decimal Low, decimal Close, decimal Volume), TOutput>
    {
        private CumulativeTypicalPriceVolumeProductByTuple _indicator1;
        private CumulativeVolumeByTuple _indicator2;

        public VolumeWeightedAveragePrice(IEnumerable<TInput> inputs, Func<TInput, (decimal High, decimal Low, decimal Close, decimal Volume)> inputMapper) : base(inputs, inputMapper)
        {
            _indicator1 = new CumulativeTypicalPriceVolumeProductByTuple(inputs.Select(inputMapper));
            _indicator2 = new CumulativeVolumeByTuple(inputs.Select(inputMapper));
        }

        protected override decimal? ComputeByIndexImpl(IReadOnlyList<(decimal High, decimal Low, decimal Close, decimal Volume)> mappedInputs, int index)
        {
            if (_indicator1[index] == 0M || _indicator2[index] == 0M)
                return 0M;

            var result = _indicator1[index] / _indicator2[index];
            System.Diagnostics.Debug.WriteLine($"{result}");
            return result;
        }
    }

    public class VolumeWeightedAveragePriceByTuple : VolumeWeightedAveragePrice<(decimal High, decimal Low, decimal Close, decimal Volume), decimal?>
    {
        public VolumeWeightedAveragePriceByTuple(IEnumerable<(decimal High, decimal Low, decimal Close, decimal Volume)> inputs)
            : base(inputs, i => i)
        {
        }
    }

    public class VolumeWeightedAveragePrice : VolumeWeightedAveragePrice<IOhlcv, AnalyzableTick<decimal?>>
    {
        public VolumeWeightedAveragePrice(IEnumerable<IOhlcv> inputs)
            : base(inputs, c => (c.High, c.Low, c.Close, c.Volume))
        {
        }
    }

public class CumulativeVolume<TInput, TOutput>
       : CumulativeNumericAnalyzableBase<TInput, (decimal High, decimal Low, decimal Close, decimal Volume), TOutput>
    {
        public CumulativeVolume(IEnumerable<TInput> inputs, Func<TInput, (decimal High, decimal Low, decimal Close, decimal Volume)> inputMapper) : base(inputs, inputMapper)
        {

        }

        protected override decimal? ComputeNullValue(IReadOnlyList<(decimal High, decimal Low, decimal Close, decimal Volume)> mappedInputs, int index) => null;

        protected override decimal? ComputeCumulativeValue(IReadOnlyList<(decimal High, decimal Low, decimal Close, decimal Volume)> mappedInputs, int index, decimal? prevOutputToMap)
        {
            return prevOutputToMap + mappedInputs[index].Volume;
        }

        protected override decimal? ComputeInitialValue(IReadOnlyList<(decimal High, decimal Low, decimal Close, decimal Volume)> mappedInputs, int index) => mappedInputs.ElementAt(index).Volume;

    }

    public class CumulativeVolumeByTuple : CumulativeVolume<(decimal High, decimal Low, decimal Close, decimal Volume), decimal?>
    {
        public CumulativeVolumeByTuple(IEnumerable<(decimal High, decimal Low, decimal Close, decimal Volume)> inputs)
            : base(inputs, i => i)
        {
        }
    }

    public class CumulativeVolume : CumulativeVolume<IOhlcv, AnalyzableTick<decimal?>>
    {
        public CumulativeVolume(IEnumerable<IOhlcv> inputs)
            : base(inputs, c => (c.High, c.Low, c.Close, c.Volume))
        {
        }
    }

    public class CumulativeTypicalPriceVolumeProduct<TInput, TOutput>
        : CumulativeNumericAnalyzableBase<TInput, (decimal High, decimal Low, decimal Close, decimal Volume), TOutput>
    {
        public CumulativeTypicalPriceVolumeProduct(IEnumerable<TInput> inputs, Func<TInput, (decimal High, decimal Low, decimal Close, decimal Volume)> inputMapper)
            : base(inputs, inputMapper)
        {

        }

        protected override decimal? ComputeNullValue(IReadOnlyList<(decimal High, decimal Low, decimal Close, decimal Volume)> mappedInputs, int index) => null;

        protected override decimal? ComputeCumulativeValue(IReadOnlyList<(decimal High, decimal Low, decimal Close, decimal Volume)> mappedInputs, int index, decimal? prevOutputToMap)
        {
            var (High, Low, Close, Volume) = mappedInputs[index];

            var typicalPrice = (High + Low + Close) / 3;

            return prevOutputToMap + (typicalPrice * Volume);
        }

        protected override decimal? ComputeInitialValue(IReadOnlyList<(decimal High, decimal Low, decimal Close, decimal Volume)> mappedInputs, int index) => mappedInputs.ElementAt(index).Volume;

    }

    public class CumulativeTypicalPriceVolumeProductByTuple : CumulativeTypicalPriceVolumeProduct<(decimal High, decimal Low, decimal Close, decimal Volume), decimal?>
    {
        public CumulativeTypicalPriceVolumeProductByTuple(IEnumerable<(decimal High, decimal Low, decimal Close, decimal Volume)> inputs)
            : base(inputs, i => i)
        {
        }
    }

    public class CumulativeTypicalPriceVolumeProduct : CumulativeTypicalPriceVolumeProduct<IOhlcv, AnalyzableTick<decimal?>>
    {
        public CumulativeTypicalPriceVolumeProduct(IEnumerable<IOhlcv> inputs)
            : base(inputs, c => (c.High, c.Low, c.Close, c.Volume))
        {
        }
    }

One thing that I defnitely need to implement is the ability to start fresh each day, which is what VWAP typically does. Do you have an idea or an example on how to do this?
Thanks!

@codebeaulieu I will review it at this weekend. For your 2nd question, i don't really understand what you mean by "start fresh each day", does it mean for each day, it would be a new set of data and the data of old days would be ignored? If it's the case, just pass the minutes data in input per each day.

Just noticed you said this: If it's the case, just pass the minutes data in input per each day.
I'll give this a shot


Migrate all scarb packages to edition = "2024_07"

Which components does the task require to be changed? (think hard pls)
snforge, sncast
Description
Migrate all scarb packages to support edition = "2024_07"
Sollution:
for each

change edition to "2024_07"
run snforge test to check if the package compiles
if not make proper changes

Related: https://github.com/foundry-rs/starknet-foundry/issues/2632

Mind if I take this issue?

Could I take on this issue?

I'd love to give this a go.

Please can I be assigned to this issue

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
How I plan on tackling this issue

On it! thank you for the task.

Hi @pheobeayo , just wanted to check out on your progress. Do you need any assistance 😄 ?

but how do I build successfully locally?
What do you mean by that?

Hi @pheobeayo , how's the progress :) ?

@franciszekjob  still fixing the 507 bugs after changing the edition....
I have tried fixing some but still couldn't make the file public like this lib.cairo was initially like

but I decided to make it public like this

but still couldn't compile.....
Any clue to that

@pheobeayo I see you're updating edition in snforge_std. I think we can address this specific package in other PR, as it may require more work. So let's limit the scope to update edition in all packages, apart of snforge_std, ok?

okay

@franciszekjob Kindly check out the PR I created yesterday, I updated the edition in all packages apart from the snforge_std

Can I take care of this issue?

Can I try solving this issue?

May I take care of this?


LL-5429 Rename exported logs file

Added a more meaningful name for the exported logs on LLM, note that this does not work for iOS since there's a limitation on the library we use so it will continue to default to file.json for that platform. On Android however, it will now follow a naming format such as ledger-live-mob-2.26.0-(arm64-v8a 156)-2021-05-10-logs.json which should be a lot more meaningful.

I noticed while looking at the logs that the output was not a valid JSON string so I fixed that, but still, the exported logs are not as useful as the desktop ones and we should add more information to them such as the number of accounts, etc. Perhaps this is a good next iteration to consider cc @gre @cthepot-ledger

Type
Feature
Context
https://ledgerhq.atlassian.net/browse/LL-5429
Parts of the app affected / Test plan
Since triggering the generic error component was a pita, I've added a trigger to the Debug Crash screen on the hidden debug menu, which allows QA to render the component without triggering an actual error. Just go to the Debug menu ⇨ Mock & Test ⇨ Debug crash and trigger it from there.

I mentioned in the original message that iOS files could not be modified, it's a limitation of the library we use. We could rework the whole export so that it creates a new temporary file with a given name (maybe) but it's out of the scope of this task, to me, it improves the situation of android so it's a merge.
cc @gre up to core

Got the OK from @cthepot-ledger for the iOS limitation, I'm assigning him because I don't know who to assign otherwise


Progress bar implementation

I feel like to someone who doesn't want that much detail, a progress bar would help keep the audience engaged.

Do you mean during generation or during deployments? Or when?

During the deployment, I feel like deployments take a long time and if someone is uninterested in the logs they will have no idea when the deployment has finished. But this could be during generation also, but defang generate is usually pretty quick.

Alternatively, a better spinner that shows more activity. See also #56


[User Story] Docker Restart Policy

Task
Docker Restart Policy

Task Title
Docker Restart Policy

User Story

Epic
#213

T-shirt size default is S(mall)
S

Story Points - Fibonacci (1,2,3,5)
2

Description
Docker containers should restart on fatal errors

Business Need (the why):

Applications or Systems impacted

Dependencies

Assumptions

When we're ready to implement this we just need to add restart: unless-stopped to our Dockerfiles. Like this:
version: '3'
services:
    my-service:
        restart: unless-stopped


ci: Add windows server e2e test run

Based on https://github.com/actions/runner-images/issues/1143 I'm not sure we can test dcp on windows successfully. We can call the windows support experimental instead, skipping CI coverage.


Add a training tutorial: Training ResNet50 using Paddle compiled with CINN.

This is a beginner-friendly tutorial on how to train models using Paddle compiled with CINN.

LGTM


pynitrokey update for the v0.11 release

PRs with the pynitrokey update for the v0.11 release:

https://github.com/Nitrokey/pynitrokey/pull/393
https://github.com/Nitrokey/pynitrokey/pull/391
https://github.com/Nitrokey/pynitrokey/pull/384

All PRs merged. Closing as done.


CheckBoxWithLabels setup

For some reason my labels aren't showing up next to the checkboxes. The text of the label is in the variable theSpecialty, and appears as expected in name, etc.  Here's how I'm setting it up:
<Field
	id={theSpecialty}
	key={"ns_" + theSpecialty}
	label={theSpecialty}
	onClick={event => onChange(event)}
	name={theSpecialty}
	checked={values['specialties'].includes(theSpecialty)}
	value={theSpecialty}
	color="primary"
	component={CheckboxWithLabel}
/>

What am I missing?

I think I found it. This seems to work:
<FormControlLabel
	control={
		<Field
			id={theSpecialty}
			key={"ns_" + theSpecialty}
			label={theSpecialty}
			onClick={event => onChange(event)}
			name={theSpecialty}
			checked={values['specialties'].includes(theSpecialty)}
			value={theSpecialty}
			color="primary"
			component={CheckboxWithLabel}
		/>
	}
	key={"cb_" + theSpecialty}
	label={theSpecialty}
/>

Does that look like the best-practice way to do this?

You could pass the label like this:
                <Field   name={name}   component={CheckboxWithLabel}   Label={{ label: 'Example' }} />

Please add some documentation for Checkbox, CheckBoxwithLabel etc.
From the help of this issue I am using this code
                              <Field
                                    Label={{label: 'Remember me'}}
                                    checked={false}
                                    onChange={() => console.log('checked')}
                                    name="remember"
                                    value="1"
                                    color="primary"
                                    component={CheckboxWithLabel}
                                />

Invalid prop checked of type array supplied to ForwardRef(Checkbox), expected boolean.
I have tried with or without checked props but it doesn't seem to change anything.

Please add some documentation for Checkbox, CheckBoxwithLabel etc.
From the help of this issue I am using this code
                              <Field
                                    Label={{label: 'Remember me'}}
                                    checked={false}
                                    onChange={() => console.log('checked')}
                                    name="remember"
                                    value="1"
                                    color="primary"
                                    component={CheckboxWithLabel}
                                />

The error below happens when checkbox is checked. When checkbox is not checked false is returned. But upon checking the checkbox value is an empty array instead of true
Invalid prop checked of type array supplied to ForwardRef(Checkbox), expected boolean.
I have tried with or without checked props but it doesn't seem to change anything.

Having exactly the same issue "Warning: Failed prop type: Invalid prop checked of type array supplied to ForwardRef(SwitchBase), expected boolean."

@owlyowl Thanks for confirming. I thought it was only me. I have opened a separate issue #114 . Could you please comment on their as well.

This is caused by a missing type="checkbox"


NOREF: Include userAlias for processes

Description
The Atlas API has support for returning the userAlias as part of the response body for listing all the processes under a project.
Documentation reference: https://docs.atlas.mongodb.com/reference/api/processes-get-all/
This PR makes sure that field is returned as part of the processes List function.
Link to any related issue(s):
Type of change:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Required Checklist:

[x] I have signed the MongoDB CLA
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added any necessary documentation (if appropriate)
[x] I have run make fmt and formatted my code

Further comments

@gssbzn Good now? Took forever for the CI to run those tests lol

@gssbzn Thank you! Any idea when a git tag will be released? I need to create a branch against the signalfx agent repository that incorporates this change.

@howdoicomputer currently the plan was to release sometime around December as we coordinate these releases with the terraform provider, we are checking internally if we could do and out of band release but given we have a couple of breaking changes in the upcoming release we are still checking
in the mean time if you are use go modules you can update directly to master doing
go get -u go.mongodb.org/atlas@master


functions as virtual properties [moved]

This is Issue 1137 moved from a Google Code project.
Added by 2012-10-24T19:18:20.000Z by<EMAIL_ADDRESS>Please review that bug for more context and additional comments, but update this bug.
Original labels: Type-Enhancement, Priority-Low
Original description
Suggestion is to be able to associate a stored procedure with a class so it can be accessed as a property. When invoked, a reference to the parent object would be passed as the first parameter to the function, and the result returned.

For example..

1.  Create a function called 'idHash' which takes a record as an argument and returns a one way hash of it's id.
2.  Associate this function with an existing class schema like
       CREATE PROPERTY MyClass.hashId FUNCTION idHash
3. Then call this function as a virtual property of object to return the hashed Id of the e.g...
       SELECT id, hashId from MyClass

Not relevant anymore. Closing it.


Clean up logic with task names to use persistent state

This will fix the bug in Task Reconciliation.

@adam-mesos, please take a look at your earliest convenience. Thanks!

@elingg what bug in reconciliation? Is there an issue for it?
Also have you considered using curator to have the zk calls be less taxing?

@nicgrayson its #115

@nicgrayson, @abhay-agarwal sent you the issue. It seems some aspects of reconciliation got broken with the addition to task names, but this JIRA should fix it. Re curator, yes that could be one possibility to avoid calls to ZK. We might also have some cache. We currently have this issue for all of the persistent state.

LGTM. A couple of minor points about error-handling/propagation and moving a zk get() further into the if branch where it's actually used. Address those, and then :rocket:
I also think we should turn LiveState into a write-through cache for PersistentState, to restrict the scheduler to a single state abstraction. But that can be a separate issue/PR.


Standardize exit code/console.error behavior

Expected Behavior
Would address https://github.com/google/clasp/pull/175#pullrequestreview-121706530.
We can wrap all commander.action logic with something like https://github.com/tj/commander.js/issues/505#issuecomment-244988124
This would let us to catch and handle common errors across commands more easily.
Actual Behavior
clasp errors sometimes still return 0, exit code logic scattered throughout index.ts
Steps to Reproduce the Problem

Specifications

Node version (node -v)
Version (npm list -g | grep clasp):
OS (Mac/Linux/Windows)

I think a good direction this could take is finding any console.error(...) in index.ts and replacing that with logError(...) https://github.com/google/clasp/blob/2cd12253a9c77dcd8c021a4949110dc1b9057b41/src/utils.ts#L119
which for now will exit with status 1.
I think that if we are going towards a model of wrapping commands like that, we could use logError(...) and additionally wrap every command with checkIfOnline(), check if .clasp.json exits, check if logged in, etc.. Thus the wrapper function could handle the basic "prerequisites" for running commands.


React 15.0.x support

Hi all,
How about 15.0.x support? React made some changes in API and current version of react-redux doesn't work with latest React :)
Thanks

@akoshman It's supported https://github.com/reactjs/react-redux/blob/master/package.json#L98
How it doesn't work? Show your code and config.

Yeah, it is supported just fine!

Thanks for help guys


added quantum computing for the determined

http://michaelnielsen.org/blog/quantum-computing-for-the-determined/

Thanks for contributing!


fix:  using rtmp directly will cause circular references.

在sendFrame中直接使用_rtmp会产生循环引用。

Could you please update the status of this PR to clean up pull requests list?


Use directed graph in GCN_LSTM

Hi!
I am trying to use gcn-lstm model for a traffic demand prediction problem. But my graph is directed.
So I am wondering is it possible to use StellarDiGraph to set up an asymmetry adj matrix?
I will really appreciate your kind help!
Thanks,
Demi

Hi @demiding0729, thanks for getting in touch. Could you say how you're using the GCN-LSTM model? Are you passing in an adjacency matrix directly or are you using SlidingFeaturesNodeGenerator?
If you're passing in the adjacency matrix directly, I think it should be fine to pass in a directed (asymmetrical) adjacency matrix. This can be created using graph.to_adjacency_matrix().todense(), if graph is a StellarDiGraph (docs for the to_adjacency_matrix method).

Hi! Huno, thanks for a quick reply.
Currently, my network has N nodes and each node represents a city. The edge between each pair of nodes represents the traffic flow between them. Since the flow from node A to node B is different from the flow from node B to node A, my network is directed. In the adjacency matrix, 1 represents non-zero flow between two nodes and 0 means no flow between each other. I have several timesteps of flow data, each timestep's flow data is represented as a matrix (N*N).
I am trying to predict the traffic flow between each pair of nodes. I can pass in the directed adj matrix but I also noticed that in your example,  the target variable is in node level (speed of each node). Is it possible to change it to a pair of nodes level? So I will have N*N rows of flow value for each timestep instead of N rows of target value (in your case is speed of each node). Does that make sense to you?
Thank you very much!!!
Demi

Thanks for the context. The current demo is indeed focused on predicting traffic flow at nodes, representing traffic sensors. It's definitely the case that another way to phrase this sort of problem is to predict the attributes of edges between points of interests like cities (https://github.com/stellargraph/stellargraph/issues/1630 is slightly related).

Is it possible to change it to a pair of nodes level?

It's not built in, and edge features (like having a time series of traffic flows along an edge) aren't fully supported yet (#1326).

So I will have N*N rows of flow value for each timestep instead of N rows of target value (in your case is speed of each node). Does that make sense to you?

Yeah, that makes sense. This is how I would approach it (you may have already thought of this and tried it 😄 ) would be to have a multi-variate time-series associated with each node as its features, representing the flow to each of the other nodes. This means a feature matrix of shape N × T × N, where each of the N "rows" (of shape T × N) represents the T observations of flows to the N nodes, for a single node. The model then is making predictions of size N × N.
This will work best when N is relatively small because of the O(N^2) size of the features involved.
In this set up, the adjacency matrix is just capturing some sort of "closeness" between nodes, e.g. if there's an edge A -> B are connected, then we're suggesting to the model that data from A will help with the predictions and B. Notably, it's not necessary that the matrix is directed in this case, because I imagine that data from B would also help with predictions at A, in many cases.
What do you think?


append btn-* and input-* variables and extends their from input-btn-*…

Buttons and input inherit the padding from the $input-btn-padding-x and $input-btn-padding-y. For $input-btn-padding-y is entirely true, for there is a problem with $input-btn-padding-x, y buttons, large side indent and have indented input is much less.
Corrected this flaw and modified desires in #24265 (comment)
Fixes #23550.

So this is somehow merged into v4-dev now...  Good news is the changes are in v4-dev, so yay!


Self signed certificate issue (The remote certificate is invalid because of errors in the certificate chain)

The Question
Hi, I am reporting an issue that I am struggling to solve, I hope that someone can point me out the right direction.
Environment

SDK Version: 3.5.2
Package Version: <IP_ADDRESS>
OS Info: public.ecr.aws/lambda/dotnet:5.0 on Docker
Build Environment: dotnet cli
Targeted .NET Platform:  5.0

I have a dotnet Lambda handler that writes to DynamoDB and reads/writes files from/to S3.
Everything works out perfectly at first, but then there is another thing that I need: Matlab Runtime.
After I install the Matlab runtime it asks me to append values to LD_LIBRARY_PATH.
This action breaks SSL connection to both DynamoDB and S3:
INNER EXCEPTION: The remote certificate is invalid because of errors in the certificate chain: PartialChain

If I change the communication over http everything works again, but this is not acceptable.
Do you have any suggestions?

Hi @giacomorebonato,
Thanks for reporting the issue. This appears to be an issue with 3rd party runtime which after installing is having certificate issues. Have you tried contacting MatLab Runtime support? There was similar issue reported in Microsoft's .NET repository https://github.com/dotnet/runtime/issues/27703#issuecomment-485334384, not sure if it might help.
Also, could you provide the exact repro steps in the following format:

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

AWSSDK.Core version used:
Service assembly and version used:
Operating System and version:
Visual Studio version:
Targeted .NET platform:

.NET Core Info

.NET Core version used for development:
.NET Core version installed in the environment where application runs:
Output of dotnet --info:
Contents of project.json/project.csproj:

Thanks,
Ashish

Hi, it wasn't an issue with this SDK of course.
Here's the solution that I have found: https://stackoverflow.com/questions/65961176/ssl-broken-with-ld-library-path-and-matlab


Translated ontology in RDF/XML with an OWL Functional Syntax

This PR translates phyloref.owl into OWL Functional Syntax as phyloref.ofn. To prevent duplication, it also deletes the old phyloref.owl -- phyloref.ofn will become the definitive ontology, and consumers can recreate the RDF/XML file as needed.

I think those are both good reasons not to merge right away, and there isn't an urgent need to do so until we start adding terms to the Phyloref Ontology in earnest. Maybe we should close this PR for now and revisit it at that time?

Yup, that's what I meant! Closing this PR now; we can continue the discussion in #24 and re-open it when we're ready to build a proper release workflow.


Pointer Arithmetic - Difference Produces Unexpected Value

While writing a test program, I came across some behaviour when doing pointer arithmetic. Trying to minus one pointer from another ended up with a value that wasn't correct (at least, wasn't what I expected). I produced a test program to see if I could reproduce it, and I could.
Here's the program.
#import "fmt.odin";

main :: proc()
{
	b : [1000]byte;

	using fmt;

	println();
	println("Pointer of Address 0");
	println(^b[0]);
	println();
	println("Pointer of Address 50");
	println(^b[50]);
	println();
	println("Difference between 50 and 0");
	println(^b[50] - ^b[0]);
}

And the result for 50 - 0 was...

... 6. Not quite the result I was expecting. I wasn't able to cast them to numbers that I could manipulate either.

Have you tried println((^b[50]) - (^b[0]));?

Just tried it, it made no difference.

This has now been fixed in the latest commit. The bug was caused by not calculating the pointers "element" size correctly.


update dependencies

Please read and mark the following check list before creating a pull request (check one with "x"):

[x] I read and followed the CONTRIBUTING.md guide.
[x] I read and followed the New Feature Checklist guide.

Short description of what this resolves:
Closes #5930

I have a question. Why and how did you/is it decided to update so much dependencies while the error messages in #5930 only mentions a couple of the dependencies that are changed in this commit? Is it automated?

I have a question. Why and how did you/is it decided to update so much dependencies while the error messages in #5930 only mentions a couple of the dependencies that are changed in this commit? Is it automated?

It was decided to update all minor versions of dependencies from package.json.

I get this this error ->
Error: The Angular Compiler requires TypeScript >=4.2.3 and <4.4.0 but 4.6.4 was found instead.

I get this this error ->
Error: The Angular Compiler requires TypeScript >=4.2.3 and <4.4.0 but 4.6.4 was found instead.

Angular 12.2.x supports "typescript": "4.3.5", See -> https://github.com/angular/angular-cli/blob/12.2.x/package.json

Thanks, I've changed some dependencies https://github.com/akveo/ngx-admin/pull/5938#issue-1233755108

See  #5935.


Proposal: move to prettier organization to collaborate

As title.
cc @fisker

I know it would allow for better collaboration. However, I have worked on this plugin basically solo and I'd like to see if I can't get some sponsorship for my work.

I think you can just keep the sponsor sections in this repo, that's totally fine to me.

Welcome to join us.

@idahogurl Hi, if you're also interested, you can discus at https://github.com/prettier/prettier-eslint/issues/949.


create container with "constraint:node" failed

in my swarm cluster,i want to create a container with constraint filter.

i create with command:
docker -H :4000 create --env=["constraint:node==ansible-nodes-1.novalocal","constraint:node==ansible-nodes-2.novalocal"] <IP_ADDRESS>:5000/centos:6.6 bash
this command succeed, a container is created.

i create with command:
docker -H :4000 create -e "constraint:node==ansible-nodes-1.novalocal" -e "constraint:node==ansible-nodes-2.novalocal" <IP_ADDRESS>:5000/centos:6.6 bash
this command failed,the out push is
Error response from daemon: Unable to find a node that satisfies the following conditions  [available container slots] [node==ansible-nodes-1.novalocal node==ansible-nodes-2.novalocal]

when i create container using the rest api with the env parament:the request body contains:
"Env":["constraint:node==ansible-nodes-1.novalocal","constraint:node==ansible-nodes-2.novalocal"]
it failed again with this output:
Unable to find a node that satisfies the following conditions  [available container slots] [node==ansible-nodes-1.novalocal node==ansible-nodes-2.novalocal]

Is my method to create container with constraint wrong? or this is a bug? thanks.

i test create container with rest api with this parament.
"Env":["constraint:node==(ansible-nodes-1.novalocal|ansible-nodes-2.novalocal)"]
it succeed.


improve GC by avoiding FileInput/Output-Streams

bump compiler target from 1.5 to 1.7
see:  https://bugs.openjdk.java.net/browse/JDK-8080225

As far as I can tell, requiring 1.7 is still no option, because Fileupload is used in basically every application container, that I am aware of, and there are lots of them out in the wild, which are way below 1.7.  And, by reading the OpenJDK issue, I do not get the impression, that your issue is urgent.

as java < 1.7 is no longer supported through oracle it would be the question how many of the app-servers which would integrate this version (as in: latest-version) still support java < 1.7
i agree that this is not a critical issue - but also an example of progress being held back by these legacy system. I guess a new mayor version branch for these kind of issues would be a solution?

Note that Oracle still offers (paid) support for versions of Java before 7:
http://www.oracle.com/technetwork/java/javase/eol-135779.html#java-commercial-offerings

I don't see Oracle passing along that money to the ASF to continue maintaining Java 6 software, though. ;)

@jvz I don't see anyone passing along any money. This is true open source software. We're doing, what we consider to be best for our users in general.
@alexander-riss Please note, there's a workaround: By setting sizeThreshold sufficiently high on the DiskFileItemFactory, you prevent files being created at all.

Note that this might improve slightly the finalizer pressure however FileChannel(InputStreams) have pretty much internal overheads including locks and synchronized, so the actual performance might regress badly.

@ecki  Given a reasonable value for sizeThreshold, I'd expect that only very few files are actually being created (say one per request, which is the actual uploaded file), so I wouldn't care too much about that. Which is, on the other hand, another reason, why this isue isn't overly pressing.


Tracking: Group Chat - Prod (Mobile/LibXMTP)

LIBXMTP
MUST

[x] Push Notifications (SMALL) https://github.com/xmtp/libxmtp/issues/527 - @nplasterer
[x] Enforce 250 limit (SMALL) https://github.com/xmtp/libxmtp/issues/503 - @alexrisch
[x] Expose Message Kind (SMALL) https://github.com/xmtp/libxmtp/issues/522 - @nplasterer
[x] Who added me in a group (SMALL) https://github.com/xmtp/libxmtp/issues/501 - @zombieobject
[x] Message send state (SMALL) https://github.com/xmtp/libxmtp/issues/516 @nplasterer
[x] Mutable Metadata (MEDIUM) https://github.com/xmtp/libxmtp/issues/548 - @cameronvoell
[x] xmtp/libxmtp#651 - @nplasterer
[x] https://github.com/xmtp/libxmtp/issues/732 - @nplasterer
[x] Identity work - @nplasterer
[x] xmtp/libxmtp#752  - @nplasterer
[x] xmtp/libxmtp#650
[x] xmtp/libxmtp#664 - @cameronvoell
[ ] xmtp/libxmtp#701 - @insipx
[ ] xmtp/botkit#18

SHOULD

[ ] https://github.com/xmtp/libxmtp/issues/714
[ ] Message History (LARGE) https://github.com/xmtp/libxmtp/issues/619 - @tuddman *
[ ] https://github.com/xmtp/libxmtp/issues/504
[ ] https://github.com/xmtp/libxmtp/issues/671
[ ] Leave (self removal) (MEDIUM) https://github.com/xmtp/libxmtp/issues/441
[ ] Is Sender HMAC Verification (MEDIUM) https://github.com/xmtp/libxmtp/issues/422 *
[ ] Streaming Reliability

Becomes a must if multi clients launch

SECURITY
MUST

[ ] Key rotation after welcome (SMALL) https://github.com/xmtp/libxmtp/issues/347 - @lfzkoala
[ ] https://github.com/xmtp/libxmtp/issues/678

SHOULD

[ ] Key Package updates - https://github.com/xmtp/libxmtp/issues/366 https://github.com/xmtp/libxmtp/pull/541

[ ] Credential Validation (blocked on identity work)
[ ] Matching MLS spec https://www.rfc-editor.org/rfc/rfc9420.html#name-credential-validation
[ ] Matching identity doc
[ ] Not allowing credential updates/changes

[ ] Security Audit

BACKEND

[ ] Datadog Metrics
[ ] Dune Dashboards
[ ] Released on Production Network

DOCS

[ ] Push Notifications Docs
[ ] SDK Integration Docs
[ ] Technical Docs

[ ] Identity Docs

Production Ready Checklist

[ ] Can make a change to mutable metadata without needing a database wipe (or with a clear migration path setup to do so) Frames Link
[ ] Update MLS storage to be TLS serialization instead of json https://github.com/xmtp/libxmtp/issues/714
[ ] Validate Performance
[ ] Thorough testing of features (inbox mobile being used to find bugs)


STREAMS-580: Namespacing with fallbacks in ComponentConfigurator

STREAMS-580: Namespacing with fallbacks in ComponentConfigurator (https://issues.apache.org/jira/browse/STREAMS-580)

Basically this changeset unlocks the ability to make changes like this one:
https://github.com/steveblackmon/incubator-streams/commit/73240167909816be8fa464857240d140a4289432#diff-bac50d9f2ed1a154a60243a9511b6fb5
see especially streams-contrib/streams-provider-twitter/src/main/resources/reference.conf
within the streams repository, and in any code built with streams-config or using streams-contrib

+1


add lines from official codeigniter download

Added lines from the zip of Codeigniter-3.1.2

Reasons for making this change:
To stay up to date with the official gitignore
Links to documentation supporting these rule changes:
https://github.com/bcit-ci/CodeIgniter/archive/3.1.2.zip

@XnachO thanks!


Add axioms to analysis scope #1059

Summary of the discussion
Describe the findings of the discussion in the issue or meeting.
Type of change (CHANGELOG.md)
Updated
Add axioms:

'analysis scope' 'is about' some 'scenario year'
'analysis scope' 'is about' some 'scenario horizon'
'analysis scope' 'is about' some 'considered region'
'analysis scope' 'is about' some 'methodical focus'

Workflow checklist
Automation
Partial implementation of #1059. Issue stays open as this PR probably does not yet cover all aspects of the analysis scope.
PR-Assignee

[x] 🐙 Follow the Pull Request Workflow
[x] 📝 Update the CHANGELOG.md
[x] 📙 Add #'s to term tracker item

Reviewer

[ ] 🐙 Follow the Reviewer Guide
[ ] 🐙 Provided feedback and show sufficient appreciation for the work done

@adelmemariani : Could you please review this OEKG related PR?

Could anyone please review this simple PR?
As this PR is now open for three weeks and still was not reviewed, I added a few more reviewers.

Thanks for reviewing. Since the switch to numerical identifiers, it is always a bit hard to understand the changes. That is how it looks like now in Protégé:


Use GATEWAY_REQUEST_URL_ATTR value as tag in GatewayMetricsFilter

I am using the Gateway for a route service in Cloud Foundry by applying the CloudFoundryRouteService predicate and the RequestHeaderToRequestUri filter for forwarding the request. The GatewayMetricsFilter uses the URI attribute of the route for tagging, but this URI value is irrelevant with the RequestHeaderToRequestUri filter.
Would it make sense to use the GATEWAY_REQUEST_URL_ATTR value (probably only its scheme, host and port) either as an additional tag or even as a replacement for the route's URI attribute? I could create a PR as it is only a small change but I am not sure if I'm missing something.

I think that makes sense since that is the URL we actually use when routing the request.


Allow Nested Subcommands

I'm trying to port my code from clap, where I have a secondarily nested subcommand, but it seems like argh and argp (and gumdrop) are unable to do this. Here's the error, it seems to not like multiple enums that point to subcommands.
error[E0277]: the trait bound `MySecondSubCommandEnum: SubCommand` is not satisfied
  --> src\main.rs:18:10
   |
18 | #[derive(FromArgs, PartialEq, Debug)]
   |          ^^^^^^^^ the trait `SubCommand` is not implemented for `MySecondSubCommandEnum`
   |
   = help: the following other types implement trait `SubCommand`:
             SubCommandOne
             SubCommandTwo
   = note: this error originates in the derive macro `FromArgs` (in Nightly builds, run with -Z macro-backtrace for more info)

Here's a simple modified example from the docs, basically I want the base subcommand enum to be able to point to other subcommand enums.
use argp::FromArgs;

/// Top-level command.
#[derive(FromArgs, PartialEq, Debug)]
struct TopLevel {
    /// Be verbose.
    #[argp(switch, short = 'v', global)]
    verbose: bool,

    /// Run locally.
    #[argp(switch)]
    quiet: bool,

    #[argp(subcommand)]
    nested: MySubCommandEnum,
}

#[derive(FromArgs, PartialEq, Debug)]
#[argp(subcommand)]
enum MySubCommandEnum {
    One(SubCommandOne),
    Two(MySecondSubCommandEnum),
}

#[derive(FromArgs, PartialEq, Debug)]
#[argp(subcommand)]
enum MySecondSubCommandEnum {
    Two(SubCommandTwo),
}

/// First subcommand.
#[derive(FromArgs, PartialEq, Debug)]
#[argp(subcommand, name = "one")]
struct SubCommandOne {
    /// How many x.
    #[argp(option)]
    x: usize,
}

/// Second subcommand.
#[derive(FromArgs, PartialEq, Debug)]
#[argp(subcommand, name = "two")]
struct SubCommandTwo {
    /// Whether to fooey.
    #[argp(switch)]
    fooey: bool,
}

fn main() {
    let args: TopLevel = argp::parse_args_or_exit(argp::DEFAULT);
    println!("{:#?}", args);
}

You just need to use an intermediate struct with #[argp(subcommand)]:
use argp::FromArgs;

/// Top-level command.
#[derive(FromArgs, PartialEq, Debug)]
struct TopLevel {
    /// Be verbose.
    #[argp(switch, short = 'v', global)]
    verbose: bool,

    /// Run locally.
    #[argp(switch)]
    quiet: bool,

    #[argp(subcommand)]
    nested: MySubCommandEnum,
}

#[derive(FromArgs, PartialEq, Debug)]
#[argp(subcommand)]
enum MySubCommandEnum {
    One(SubCommandOne),
    Two(SubCommandTwo),
}

/// First subcommand.
#[derive(FromArgs, PartialEq, Debug)]
#[argp(subcommand, name = "one")]
struct SubCommandOne {
    /// How many x.
    #[argp(option)]
    x: usize,
}

/// Second subcommand.
#[derive(FromArgs, PartialEq, Debug)]
#[argp(subcommand, name = "two")]
struct SubCommandTwo {
    #[argp(subcommand)]
    nested: MySecondSubCommandEnum,
}

#[derive(FromArgs, PartialEq, Debug)]
#[argp(subcommand)]
enum MySecondSubCommandEnum {
    Three(SubCommandThree),
}

/// Nested subcommand.
#[derive(FromArgs, PartialEq, Debug)]
#[argp(subcommand, name = "three")]
struct SubCommandThree {
    /// Whether to fooey.
    #[argp(switch)]
    fooey: bool,
}

fn main() {
    let args: TopLevel = argp::parse_args_or_exit(argp::DEFAULT);
    println!("{:#?}", args);
}

$ ./nested_subcommands --help
Usage: nested_subcommands [-v] [--quiet] <command> [<args>]

Top-level command.

Options:
  -v, --verbose  Be verbose.
      --quiet    Run locally.
  -h, --help     Show this help message and exit.

Commands:
  one            First subcommand.
  two            Second subcommand.

$ ./nested_subcommands two --help
Usage: nested_subcommands two [-v] <command> [<args>]

Second subcommand.

Options:
  -v, --verbose  Be verbose.
  -h, --help     Show this help message and exit.

Commands:
  three          Nested subcommand.

$ ./nested_subcommands two three --help
Usage: nested_subcommands two three [-v] [--fooey]

Nested subcommand.

Options:
  -v, --verbose  Be verbose.
      --fooey    Whether to fooey.
  -h, --help     Show this help message and exit.

I figured I had to be missing something. Thanks for your help!


Missing CONTRIBUTING.md File in Repository

The repository currently lacks a CONTRIBUTING.md file, which is an important resource for guiding potential contributors on how to engage with the project effectively. A CONTRIBUTING.md file outlines the contribution guidelines, coding standards, and procedures for submitting pull requests, thus streamlining the contribution process and ensuring consistency across contributions.
Could you please assign this issue to me under GSSOC 24.

@suhanipaliwal Thanx for the issue but we already got Code_of_Conduct.md


Fix issue with multiple entity IDs

Spotted by @eleftherias in smoke tests. When evaluating a PR, the repo ID is also passed around. This violated the assumption that only one entity type would be specified.
Change the logic so that we try and find a PR or artifact ID first, then a repo ID later.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:

[x] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[x] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 52.746% (+0.02%) from 52.727%
when pulling 3bfda5c343232a0e2e8f5b68ec7a233023e4820e on fix-multi-id-issue
into 5f200ed126392f20292d9ca2fba8cfa756972bbc on main.

coverage: 52.736% (+0.009%) from 52.727%
when pulling 3bfda5c343232a0e2e8f5b68ec7a233023e4820e on fix-multi-id-issue
into 5f200ed126392f20292d9ca2fba8cfa756972bbc on main.


tools: Update cargo-about crate to the latest version

Update the cargo-about crate to v0.3.0, the latest version.
Include the generated updates for the
THIRD_PARTY_LICENSES_RUST_CRATES.html file.
Signed-off-by: Andra Paraschiv<EMAIL_ADDRESS>Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Could we not include the THIRD_PARTY_LICENSES_RUST_CRATES file if we can build it from scratch? It adds friction when updating and it really only needed when we distribute the binaries.

The THIRD_PARTY_LICENSES file is present in this GitHub repo and in the nitro-cli RPM spec https://github.com/aws/aws-nitro-enclaves-cli/blob/main/SPECS/aws-nitro-enclaves-cli.spec#L14. The THIRD_PARTY_LICENSES_RUST_CRATES.html file is present in the GitHub repo and the initial commit - https://github.com/aws/aws-nitro-enclaves-cli/commit/cff1eb9a902633e468b04e9f44ab2e03cf4cacd4 - included a check in the CI to have this file updated.

Could we not include the THIRD_PARTY_LICENSES_RUST_CRATES file if we can build it from scratch? It adds friction when updating and it really only needed when we distribute the binaries.

The THIRD_PARTY_LICENSES file is present in this GitHub repo and in the nitro-cli RPM spec https://github.com/aws/aws-nitro-enclaves-cli/blob/main/SPECS/aws-nitro-enclaves-cli.spec#L14. The THIRD_PARTY_LICENSES_RUST_CRATES.html file is present in the GitHub repo and the initial commit - cff1eb9 - included a check in the CI to have this file updated.

Sure, but the THIRD_PARTY_LICENSES file is generated by some other means and the binery files it talks about are actually distributed with the repository as well. The THIRD_PARTY_LICENSES_RUST_CRATES is written by this tool instead, and we distribute the binaries of aws-nitro-enclaves-cli only as part of the RPM, which is the only point where they are really relevant.

Could we not include the THIRD_PARTY_LICENSES_RUST_CRATES file if we can build it from scratch? It adds friction when updating and it really only needed when we distribute the binaries.

The THIRD_PARTY_LICENSES file is present in this GitHub repo and in the nitro-cli RPM spec https://github.com/aws/aws-nitro-enclaves-cli/blob/main/SPECS/aws-nitro-enclaves-cli.spec#L14. The THIRD_PARTY_LICENSES_RUST_CRATES.html file is present in the GitHub repo and the initial commit - cff1eb9 - included a check in the CI to have this file updated.

Sure, but the THIRD_PARTY_LICENSES file is generated by some other means and the binry files it talks about are actually distributed with the repository as well. The THIRD_PARTY_LICENSES_RUST_CRATES is written by this tool instead, and we distribute the binary of aws-nitro-enclaves-cli only as part of the RPM, which is the only point where this file is really relevant.

When would the THIRD_PARTY_LICENSES_RUST_CRATES file be generated? In which workflow logic would this be included e.g. steps from the RPM spec, during RPM build, which steps in this file generation would need access to network and which not?


Originally posted by @aliokfi in https://github.com/openid/AppAuth-iOS/issues/708#issuecomment-1144086652

I'm assuming this is test or spam, so closing


BF16 optimizer: Clear lp grads after updating hp grads in hook

This fix is to solve:

Previous iteration's lp grads will still alive during the next iteration's forward. This increases the memory footprint.
The hook behavior is not aligned to its name accumulate_hp_grads_and_remove_lp

Hi @mrwyattii @tjruwase , could you help to review this change?


Run the v4 mojo

This PR currently fail as expected, as the Maven 4 mojo cannot be run on Maven 3.
Not sure how to fix that...


Edit 'lung neuroendocrine cell'

Inspired by #2081.
After reviewing the Cell Guide "Experimental Description" for 'lung neuroendocrine cell' and finding cross-references to validate aspects of the description, the following edits are proposed:
CL:1000223 ‘lung neuroendocrine cell’

[x] add text definition:
"A neuroendocrine cell that is part of respiratory epithelium of the lung and can detect environmental stimuli, including hypoxic conditions through chemoreception. Ultrastructurally, this cell type is characterized by the presence of cytoplasmic dense core granules, which are considered the storage site of amine and peptide hormones. Lung neuroendocrine cells appear as solitary cells or as clustered masses, localized at airway bifurcation sites, called neuroepithelial bodies that can release serotonin in response to hypoxia. The lung neuroendocrine cell type is also reported to have stem cell properties."
PMID:33355253
doi:10.3109/01902148209069653

[x] add SubClass of axioms:

'chemoreceptor cell'

‘capable of’ some ‘serotonin secretion’

'capable of' some 'detection of hypoxia'

[x] add synonyms:

"pulmonary neuroendocrine cell", exact, PMID:33355253

"PNEC", related, abbreviation, PMID:33355253

UBERON:0010002 'pulmonary neuroendocrine body' (Uberon ticket: https://github.com/obophenotype/uberon/issues/3035)

[x] edit axiom:
CURRENT: 'has part' some 'neuroendocrine cell'
PROPOSED: 'has part' some ‘lung neuroendocrine cell'

[x] edit synonym:
CURRENT: "NEB", exact
PROPOSED: "NEB", related, abbreviation

chemoreceptor cell: "A cell specialized to detect chemical substances and relay that information centrally in the nervous system." Equivalent to: neuron and capable of some detection of chemical stimulus involved in sensory perception
Is there evidence that lung neuroendocrine cells relay chemosensory info to the nervous system / function in sensory perception? If not, the classification is not correct.

Thanks for the review.
PMID:33355253 provides evidence to align with the text definition of 'chemoreceptor cell':

The same reference states: "[pulmonary neuroendocrine cells] can detect hypoxic conditions through chemoreception".
CL also defines neuroendocrine cells as (possibly controversially) neurons, so that is aligned with the logical definition of 'chemoreceptor cell'.
Thank you for the GO term suggestion.
ACTIONS:

[ ] Add SubClass of 'capable of' some 'detection of hypoxia'

@dosumis, if you still have reservations of keeping SubClass Of 'chemoreceptor cell' after the justification above, kindly advise.

The text def should include information about the interaction of these cells with sensory (and other) nerve terminals and should be explicit about their sensory role.
(BTW: This is a good example of why standard citation practice in defs is a good thing - it would point me and anyone else directly to the relevant paper supporting specific assertions,.  Will get more important if the number of refs increases.)
(Note: The point of the EquivalentClass def of "chemoreceptor cell' is to support automated classification)

Could also add:
subClassOf: has_part some 'dense core granule' http://purl.obolibrary.org/obo/GO_0031045

The text def should include information about the interaction of these cells with sensory (and other) nerve terminals and should be explicit about their sensory role.

What is your proposed revision to a necessary and sufficient text definition?

(Notes - more minor issues:
• This is a good example of why standard citation practice in defs is a good thing - it would point me and anyone else directly to the relevant paper supporting specific assertions,. Will get more important if the number of refs increases.)

This point was discussed multiple times already in CL/EBI meetings and voted against. Currently CL text definitions are not intended to be discursive descriptions and should therefore not require a high number of cross-references. Feel free to add to future CL meeting agenda for further discussion.

The point of the EquivalentClass def of "chemoreceptor cell' is to support automated classification, so we could achieve it by adding another capable_of link here, but might be better to request a sensory detection of hypoxia term from GO.)

ACTION:

[ ] remove SubClass Of 'chemoreceptor cell'
[ ] add SubClassOf 'has part' some 'dense core granule'

remove SubClass Of 'chemoreceptor cell'

I agree with @bvarner-ebi  to maintain SubclassOf 'chemoreceptor cell', or at least add'part of' some 'mechanosensory system' (see https://doi.org/10.7554/eLife.78216).

What is your proposed revision to make this a necessary and sufficient text definition?

My point is that a sensory role should be clear to anyone reading the text def. It is currently not 'detecting enrvironmental stimuli != role in sensory perception.  Mentioning connection to afferent and efferent nerve fibers makes potential sensory and effector (neuroendocrine) roles much clearer. How about:
"A neuroendocrine cell that is part of respiratory epithelium of the lung and is involved in the sensory detection of environmental stimuli, including hypoxic conditions.. Ultrastructurally, this cell type is characterized by the presence of cytoplasmic dense core secretory granules. Lung neuroendocrine cells are associated with both afferent and efferent nerve terminals.  They appear as solitary cells or as clustered masses, localized at airway bifurcation sites, called neuroepithelial bodies that can release serotonin in response to hypoxia. The lung neuroendocrine cell type is also reported to have stem cell properties."
I'm also not keen on the last sentence. general we should avoid terms like  'reported'  in defs  and 'stem cell properties' is vague. If they evidence is strong enough, it should be stated that they are capable of acting as stem cells or giving rise to stem cells? Otherwise, this is better relegated to a comment.

I'm also not keen on the last sentence. general we should avoid terms like 'reported' in defs and 'stem cell properties' is vague. If they evidence is strong enough, it should be stated that they are capable of acting as stem cells or giving rise to stem cells? Otherwise, this is better relegated to a comment.

Thank you for the suggested revision.
Agreed on last sentence. Will change to:
"Lung neuroendocrine cells also function as reserve stem cells that repair the surrounding epithelium after injury."
doi:10.7554/eLife.78216

"Lung neuroendocrine cells are associated with both afferent and efferent nerve terminals."

If you would like this sentence added, please provide a reference that asserts this for both solitary cells as well as those in the neuroepithelial bodies. In my review, I've only read about the efferent connections in the neuroepithelial bodies.

My point is that a sensory role should be clear to anyone reading the text def. It is currently not 'detecting enrvironmental stimuli != role in sensory perception. Mentioning connection to afferent and efferent nerve fibers makes potential sensory and effector (neuroendocrine) roles much clearer.

Can you give an example in animals where detecting an environmental stimulus does not involve sensory perception?

Thank you for the feedback, @dosumis.
Hopefully the revised text definition reflects your suggestions.


In Java there is no pointers concept

pointers mentioned in roadmap

Please feel free to open a PR to update it to pass by reference vs pass by value.


UI - Services drop down seems to be wrong

Clicking on the services drop down seems to contain wrong information. not sure which services were intended to appear there.

solved by https://github.com/konflux-ci/konflux-ci/pull/815


Removes the unused sandbox. We have elected to use DP-Composer for a …

…sandbox.

Codecov Report

Merging #247 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   92.63%   92.61%   -0.02%
==========================================
  Files         136      133       -3
  Lines        2429     2397      -32
  Branches      127      126       -1
==========================================
- Hits         2250     2220      -30
+ Misses        179      177       -2

Impacted Files
Coverage Δ

...scala/hydra/kafka/ingestors/KafkaTopicsActor.scala
100% <0%> (+3.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a63420...b8513cf. Read the comment docs.


Howto Tap the screen with coordinates

OpenTest version number: 0.9.16
Issue description:
How do I add coordinates of a mobile screen that I want to be tapped? I have a test case that works fine, but the phone seems to be going to sleep. However, when I tap the screen during my delay it wakes back up and continues the test.
`- description: Delay for 8 seconds
script: $delay(8000)
      ##Check In OA

      - description: Tap the screen
        action: org.getopentest.appium.Tap
        args:
          locator: ##Tap the Screen with coordinates

      - description: Check In
        action: org.getopentest.appium.Tap
        args:
          locator: {xpath: "//android.widget.Button[@text='CHECK-IN']"}

`

You can tap at exact coordinates using the x and y arguments, which were recently introduced and are not yet documented:
- description: Tap the screen at exact coordinates
  action: org.getopentest.appium.Tap
  args:
      x: 100
      y: 100

Please keep in mind that tapping at coordinates is not exactly a best practice, because it might fail on screens with a resolution different than the one you are testing with.

Thank you for the heads up, and the fast response. I will give it a try and let you know what the results are.

It has failed on some attempts. I will create a new issue to see how we can resolve this or find another way around.


Infra: added the release-drafter for automation of release notes

Added two files:

.github/workflows : added the release-drafter.yml file
.github : added the release-config.yml file (contains the format for the release notes)

closes #491

Awesome, I'll do a proper review tonight after work =)

@all-contributors please add @sanskriti2005 for infra

Hey, it worked! 🎉 https://github.com/py-econometrics/pyfixest/releases It's really cool and will save me quite a bit of time going forward.
Please let me know if you'd be interested to keep contributing, and if yes, which topics would be particularly interesting for you @sanskriti2005 =)

@s3alfisc
I'm glad this is of help! I would love to work on more issues. I'm currently not very particular about the things I work on, as I'm interested in learning about them.


No comments on InvalidUrlException.php

There is no DocBlock comment

Make InvalidUrlException like that of InvalidUsernameException. Someone should be able to pass in a type of message, it shouldn't be hardcoded into the function in the class


5xx error with high traffic to pods

Describe the bug
I have deployed AGIC together with APP gateway in AKS cluster. The application pod can handle high traffic and it's already tested with Nginx controller. Sending just 200 requests/sec for 5 minutes without any scaling to the application pods and just 10% from required cpu and 30% from required memory we get back 500 errors on APP gateway logs and it's around 1.5 to 3 % from total responses.
I have also gave the APP gateway 3 instances which more than enough as it shows in the logs it's using maximum 2 to 3 capacity units during the peak time.
To Reproduce
No clear method to reproduce it.
My main question is if the APP gateway deployed with Agic limits traffic going to a pods or what is the reason of these 5xx responses. What I'm sure about that these errors are not coming back from application side.
Ingress Controller details

here is the ingress values
ingress:
enabled: true
annotations:
kubernetes.io/ingress.class: "azure/application-gateway"
#appgw.ingress.kubernetes.io/connection-draining: "true"
cert-manager.io/acme-challenge-type: "http01"
cert-manager.io/cluster-issuer: "letsencrypt-prod"

@akshaysngupta yes I'm getting serverstatus 500. I also have tested the same environment with Http routing enabled and ignoring the APP gateway and i didn't get any 500 responses while doing the test. Same also with Nginx ingress without any errors


do_not_fail_on_forbidden (dnfof) should not throw security exception when user has access to zero indices (ITT-1886)

Fix https://groups.google.com/d/msgid/search-guard/d2279b90-328b-4c9d-b2b4-b5f8c3e20a7d%40googlegroups.com?utm_medium=email&utm_source=footer

Reverted. Will be reapplied for 25.0 or for SG7


Update all references on a rename

Hi Daniel, for our "report breaking change" process (when we need to rename a measure for example) we need to hide the old measure, create the measure with the new name then on a later release finally delete the old measure to allow users time to update their reports.
I am trying to implement this by looping through all the measures, doing a rename (which should update all references) then a clone (to create the hidden version of the same measure).
If you imagine that I have measureA and measureB and measureA's DAX refers to measureB.
We want to rename measureA->measure1 and measureB->measure2
We will end up with all 4 measures and A and 1 should be identical and B and 2 should be identical.
I loop through and measureA is first, I rename it to measure1 and clone back to measureA, now I have measureA and measure1, both identical.
then measureB is next, I rename it and clone, but it only seems to update the references for measure1 (the origlnal one that was now renamed. So I end up with measure1 referring to measure2 (correct) but measureA referring to measureB (incorrect)
Is there something that I need to do to have the model update dependencies between each rename/clone to make sure that both measureA and measure1 get redirected to measure2?

It is all through a script

Just an update that I'm working around this right now by doing all my renames first, then in a seperate foreach afterwards doing the clone and hiding and this works as expected.
So I wonder if this is because I am getting the list of fields as a list (so that I can change them)... I wonder if I need to refresh my object after the rename somehow by re-getting the object from the model..


Advanced Text Editor UX changes

Summary
Adding multiple UX changes to the Advanced text editor to address issues user are facing and make it more future proof
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-44390
Fixes https://mattermost.atlassian.net/browse/MM-44457
Fixes https://mattermost.atlassian.net/browse/MM-44538
Fixes https://mattermost.atlassian.net/browse/MM-44393
Related Pull Requests
NONE
Screenshots

before
after

Release Note
* Adding multiple UX changes to the Advanced text editor to address issues users are facing and make it more future proof

@matthewbirtch this PR https://github.com/mattermost/mattermost-webapp/pull/10374 fix point 3, Rest I will fix here.

@AshishDhama could you also add a hover state (while not focused) to the input container - just change the border color to 24% center channel color while hovering. (make sure it stays at 32% opacity while focus-within and hover are happening though)

@AshishDhama can you also hide the 'Send' button for read-only channels?

@AshishDhama can you also hide the 'Send' button for read-only channels?

Yeah, we can hide send button as well.

One other thing I just noticed on mobile view: the left/right border changes on hover which causes things to jump around. On mobile widths, we don't need the left/right borders at all.

@koox00 Gentle reminder on this.

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/200484

@jgilliam17 This is ready for review.

Thanks @AshishDhama
E2E report looks good, no PR related failures
I'm having  trouble with the test server, randomly loosing connection

@AshishDhama
just two observation that we can address in a follow up

We could make the rhs textbox smaller on read-only channels (https://mattermost.atlassian.net/browse/MM-44458 will probably fix this)

On expanded RHS, additional formatting options remain collapsed even though there's enough space to show all

Let me know what is it that we decide to do (or not) for extra space when attachments are present
Formatting bar enabled

@jgilliam17 I will create a follow pr for this.
About point

Yeah please add this to the ticket you have mentioned,
For this have merged a PR in master today that will fix it, so I think we can try updating this PR and check.

/cherry-pick release-7.0

Cherry pick is scheduled.


VmOrTemplate supports_terminate instead of validate_terminate

Purpose or Intent
Replace VmOrTemplate.validate_terminate with supports_terminate

@miq-bot add_labels wip, refactoring, "pluggable providers"

@jameswnl I'm ok with having this called terminate for now, but IMHO it should be named closer to the actual method vm_destroy, but this would involve more refactoring.
So, could you either add this as comments to the supports :terminate method or even better refactor the calls to supports :vm_destroy? There is only a couple of occurences in the code, as I can see

@durandom yes, I can rename terminate to vm_destroy. I thought about that too but wasn't sure - you know naming is hard 😄
Since you also support, I'll do that.

@durandom About renaming terminate: I saw a previous test for validate_terminate was removed by your PR. Can you advise on how to confirm the name change is not breaking UI?

ok, :trophy: from my side.
@miq-bot assign blomquisg
@blomquisg merge?

Thanks @durandom 😄

@blomquisg do you need a physical ping? 😛

@jameswnl can you rebase, please, after that I'll make sure its merged asap :)

@miq-bot assign blomquisg
@blomquisg please merge, thanks

@miq-bot add_label euwe/no

@blomquisg This PR needs to go to Euwe to fix this BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1385587
I'm changing the label to euwe/yes

@miq-bot add_label euwe/yes

Euwe backport details:
$ git log -1
commit 084ecea58bfb4fa5481839c9a7196a3c018e4bdf
Author: Greg Blomquist<EMAIL_ADDRESS>Date:   Wed Oct 5 14:37:39 2016 -0400

    Merge pull request #11018 from jameswnl/validate_terminate

    VmOrTemplate supports_terminate instead of validate_terminate
    (cherry picked from commit 91d5c94c112abf7bcc3b73f743865f7ac682b3ca)

    https://bugzilla.redhat.com/show_bug.cgi?id=1414550


Provide a route where the issue occurs
N/A
openpilot version
release2-e2e 2022.11.02
Additional info
No response

Met the same problem.Eon(with battery)+blackpanda with op0813.
I set autoshutdonw_in to 2min, when time was running out, op would turn off the usb power of black panda. The strange point was, one or two seconds later, the usb power would be turned on again, then it came to the loop of on&off forever.
Then i did some research and found the reason but don't know why. In boardd.cc std: : call_once doesn't run as expected, the function is called several times.

Thanks for the feedback, I  will look into the issue :+1:

dp-priv commit 69f9bad,
Fixed! will be out with the new update!
Cheers,

Hi @rav4kumar, I think I have the same issue. After I shutdown the C2 manually or it auto-shutdowns, after roughly 10-20sec it powers on again. Was the fix merged to https://github.com/dragonpilot-community/dragonpilot? What branch or what commit should I have for the fix? Thanks!


glibc: 2.39-52 -> 2.40-36

Description of changes
Release announcement: https://sourceware.org/pipermail/libc-announce/2024/000042.html

So far it's looking pretty good: with the patches below I managed to build LLVM 12 to 19, gdb and Firefox on x86_64-linux and stdenv+hello on aarch64-linux.
cc @vcunat would you mind creating a jobset in the nixpkgs project for this?
cc @RossComputerGuy for the LLVM change.
cc @trofi for the GCC change.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I suppose it's too risky to just merge into the next iteration that already has gcc upgrade?

@vcunat IIRC we had that in the past and it made it harder to pin down regressions on -next, so this should wait.
That said, is it possible to get a Hydra jobset to build x86_64-linux (and probably aarch64-linux) once to make sure there are no obvious regressions?

I created it straight away, but it's still waiting on other big evals for now
https://hydra.nixos.org/jobset/nixpkgs/glibc-bump#tabs-evaluations

Hydra is basically done with this, no major regressions, we can fix up anything else we find during the staging cycle.


[6.X] Allow web-multi-logger port to be configurable

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:
@electron-forge/web-multi-logger is using port 9000, but same port is used by VSCode Extension on my machine. When I run yarn run start without killing the vscode process, I got this error:

An unhandled exception has occurred inside Forge:
listen EADDRINUSE: address already in use :::9000
Error: listen EADDRINUSE: address already in use :::9000
    at Server.setupListenHandle [as _listen2] (net.js:1290:14)
    at listenInCluster (net.js:1338:12)
    at Server.listen (net.js:1425:7)
    at Function.serverListen [as listen] (/Users/right/workspace/electron/electron-react-ts/node_modules/express-ws/lib/index.js:42:40)
    at listen (/Users/right/workspace/electron/electron-react-ts/node_modules/@electron-forge/web-multi-logger/src/Logger.ts:46:30)
    at new Promise (<anonymous>)
    at Logger.start (/Users/right/workspace/electron/electron-react-ts/node_modules/@electron-forge/web-multi-logger/src/Logger.ts:45:12)
    at start (/Users/right/workspace/electron/electron-react-ts/node_modules/@electron-forge/plugin-webpack/src/WebpackPlugin.ts:414:18)
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/Users/right/workspace/electron/electron-react-ts/node_modules/@electron-forge/plugin-webpack/dist/WebpackPlugin.js:46:103)
    at _next (/Users/right/workspace/electron/electron-react-ts/node_modules/@electron-forge/plugin-webpack/dist/WebpackPlugin.js:48:194)
    at process._tickCallback (internal/process/next_tick.js:68:7)
  electron-forge:plugin:webpack handling process exit with: { cleanup: true } +2s
  electron-forge:plugin:webpack cleaning webpack watcher +1ms
  electron-forge:plugin:webpack cleaning http server +0ms
  electron-forge:plugin:webpack stopping logger +1ms

Would you allow this port to be configurable or are there any workarounds for this?

PRs welcome 👍
The code in question is here --> https://github.com/electron-userland/electron-forge/blob/master/packages/utils/web-multi-logger/src/Logger.ts
An environment variable probably makes the most sense here

Also:
https://github.com/electron-userland/electron-forge/blob/7abca7d357713d5bd70396bb1b206073cc9e053a/packages/plugin/webpack/src/WebpackPlugin.ts#L428

Thank you for your reply, I'll address this issue.

I have this issue in a clean install of the latest version.

@tborychowski what is "the latest version"?

@malept version 5.2.4

As indicated in the issue title, this is for 6.x, not <= 5.

@malept In that case - sorry that I've got this problem in 5...

Well that's weird mostly because this feature doesn't exist at all in < 6.


Needs to have two seperate ingresses, one for the private interface, and one for "public" facing webhooks

The secure way to set up atlantis is to have two ingresses. One which is on the private network gives access to the web interface, which contains sensitive information and capabilities and needs restricted access.
The other should be used only for incoming webhooks, from github.com or similar things.
ArgoCD is set up this way. There's a applicationSet.webhook.ingress which is only for the ingress, and a server.ingress which is used for accessing the application.
With the current setup of the helm chart, someone is more likely to inadvertently expose their atlantis to the public.

@paul-civitas
Any chance you want to test this MR: https://github.com/runatlantis/helm-charts/pull/289

@jseiser I'd be happy to :)
I've made a ticket on our internal JIRA for testing this and we'll try and get to it soon.

@paul-civitas  any chance you guys got a chance to test this?

Unfortunately not yet. I just pinged my colleague who this is assigned to to remind him to take a look at this.

ingress:
  enabled: true
  ingressClassName: nginx
  host: atlantis.localdev.me
  path: /
secondary_ingress:
  enabled: true
  ingressClassName: nginx
  host: atlantis-webook.localdev.me
  path: /events

❯ kubectl get ingress -n atlantis
NAME                 CLASS   HOSTS                         ADDRESS   PORTS   AGE
atlantis-secondary   nginx   atlantis-webook.localdev.me             80      9s
atlantis             nginx   atlantis.localdev.me                    80      9s

❯ kubectl get ingress atlantis-secondary -n atlantis -o yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  annotations:
    meta.helm.sh/release-name: atlantis
    meta.helm.sh/release-namespace: atlantis
  creationTimestamp: "2023-05-25T16:21:36Z"
  generation: 1
  labels:
    app: atlantis
    app.kubernetes.io/managed-by: Helm
    chart: atlantis-4.13.0
    helm.sh/chart: atlantis-4.13.0
    heritage: Helm
    release: atlantis
  name: atlantis-secondary
  namespace: atlantis
  resourceVersion: "85793"
  uid: 3ac3c770-2c3e-4f30-881a-c6244e2c49aa
spec:
  ingressClassName: nginx
  rules:
  - host: atlantis-webook.localdev.me
    http:
      paths:
      - backend:
          service:
            name: atlantis
            port:
              number: 80
        path: /events
        pathType: ImplementationSpecific

Then as a post, we see it gets to atlantis
{"level":"debug","ts":"2023-05-25T16:43:07.708Z","caller":"server/middleware.go:45","msg":"POST /events – from <IP_ADDRESS>:59350","json":{}}
{"level":"debug","ts":"2023-05-25T16:43:07.708Z","caller":"logging/simple_logger.go:157","msg":"Ignoring request","json":{}}
{"level":"debug","ts":"2023-05-25T16:43:07.708Z","caller":"server/middleware.go:72","msg":"POST /events – respond HTTP 400","json":{}}

Hey we were trying to look at this, but we ran into some difficulties that are in our end, so there's some delay. Sorry about this. We hope to be able to test this this week though.

Hey your PR is working great in our tests! Sorry for all the delay.

Seems to be blocked by https://github.com/bats-core/bats-core/issues/737


Investigate Directory-Based Format for Intellij IDEA Project

Description
Adding this issue in favor of #193.
The gradle idea task works fine and probably does not need any adjustments as of now. Instead of relying on a Gradle plug-in to generate the IDEA project files we could investigate the use of the directory-based format.
There does not seem to be a Gradle plugin/task that creates the directory-based structure, the "new" way to go is to use IDEA's capabilities of importing the project. Would like to hear the opinion of @Cervator on this.
What's to be done?

[ ] discuss pros and cons of (1) gradle idea plugin, (2) directory-based project format, and (3) direct import of Gradle project via IntelliJ
[ ] tweak build.gradle accordingly
[ ] update documentation for project setup (Wiki and Readme)

Resources

Converting Projects into Directory-Based Format
IntelliJ Projects
SO/How to use an existing Gradle project in IntelliJ IDEA 13/14

From memory the latest state of this was that IntelliJ and Gradle (the projects) could not agree on who should spend the effort on enhancing the customizability of the directory format.
The idea target still works fine and the basics carry over purely based on the project tree and sourcesets. But the .withIpr style XML customization blocks no longer work, since, well, those files are not there with a directory-based approach.
IIRC some users were using such blocks to also make up for any shortcomings of the basic Gradle -> IntelliJ project interpretation, so some projects would encounter problems with the directory approach. You could likely go deeper and try to hack at all kinds of XML inside the .idea directory, but that gets messy fast.
I'd still like to convert and somehow safeguard our customizations. Have been wondering for some time if we could splice a Groovy environment in like with gradlew and move some of utility (and XML file hacking) in there (easier)

I've just imported the launcher project in IntelliJ Idea 2019.2.4 as Gradle project (without running ./gradlew idea beforehand). Building and running via Gradle tasks works fine, debugging is also no problem. I chose the directory-based project structure on import (using .idea folder) - also no problem there.
Thus, I think this issue can be closed. If there is no need for the Gradle idea task anymore we even might wan to remove that completely...


Support for Middleman 4.0.0?

Since upgrading to OS X El Capitan, I had to start using Middleman 4.0.0 RC1. I know Middleman 4 isn't released yet, but I was wondering if there was a plan to support it soon-ish.

+1

:+1:

+1

Hey everyone,
I’ve not been using Middleman for much lately and have been pretty stretched, so MM 4.x is not something that has really been on my radar. If anyone really wants this and is prepared to get their hands dirty I would be very much open to a PR, otherwise it will have to wait until I have some free time again.

:+1:  Any alternatives in the meantime?

+1

+1

+1

+1

+1

+1

+1

In the meantime, I've put a repo together using the new external pipeline and Gulp (which includes image optimisation) https://github.com/craigmdennis/middleman-gulp-starter

+1

+1

Anyone working on this?  If not I might pick this up as it would be nice to have on a personal project.

+1

+1

+1

@kmanzana did you fork it already?

@chrishough, I haven't and won't have time in the near future.  I'm assume by the lack of response to my question that no one else is working on it though.

+1

@Dmanz21, let's work on this together in the near future.

There is nothing directly actionable on this issue, merely a consensus that folks want support for v4. I propose we close this ticket and, instead, report the issues we find with v4 compatibility. Such as this... #51

Not supporting middleman 4.0 yet? :thinking:

@fxmountain the master branch of middleman-imageoptim does support 4.0, but the maintainer has not cut a new gem release yet. See this comment for 4.0 support - https://github.com/plasticine/middleman-imageoptim/issues/51#issuecomment-296867750
Secondly, I feel this ticket can be closed since the master branch does support 4.0. There is a separate issue for getting an updated gem on #56. @mmasnjak agree to close?

👍