added feature post_init_post_parse

Change Summary

Now you can have __post_init_post_parse__ that runs after pydantic has validated the input.
So __init__() -> __post_init__() -> pydantic object validation -> __post_init_post_parse__()
Related issue number
#566
Checklist

[x] Unit tests for the changes exist
[ ] Tests pass on CI and coverage remains at 100%
[ ] Documentation reflects the changes where applicable
[ ] HISTORY.rst has been updated

if this is the first change since a release, please add a new section
include the issue number or this pull request number #<number>
include your github username @<whomever>

Looking good, needs tests and docs.

I don't understand why tests fail tho, if I install it locally it works :/
    def test_post_init_post_parse():
        post_init_called = False
        post_init_post_parse_called = False

        @pydantic.dataclasses.dataclass
        class MyDataclass:
            a: int

            def __post_init__(self):
                nonlocal post_init_called
                post_init_called = True

            def __post_init_post_parse__(self):
                nonlocal post_init_post_parse_called
                post_init_post_parse_called = True

        d = MyDataclass("1")
        assert d.a == 1
        assert post_init_called
>       assert post_init_post_parse_called
E       assert False

please revert to single quotes, then I'll review.

Sorry, autoformatter on save ;)

Yeah you were right hasattr is not the way to go ;)
Also added a test which lays out the difference between post_init and post_init_post_parse:
def test_post_init_post_parse_types():
    @pydantic.dataclasses.dataclass
    class CustomType(object):
        b: int

    @pydantic.dataclasses.dataclass
    class MyDataclass:
        a: CustomType

        def __post_init__(self):
            assert type(self.a) == dict

        def __post_init_post_parse__(self):
            assert type(self.a) == CustomType

    d = MyDataclass(**{"a": {"b": 1}})
    assert d.a.b == 1

Will add some docs now

Added docs and update history.
I think this should be in a new version because it is a new feature? If not I update the version back to 0.27 and it my update to history to 0.27 aswell.

Idd it had no use

great, thanks.


Add loader for linked smart objects in photoshop

Closes OP-1206
Added new ReferenceLoader which loads published asset as a linked SmartObject (eg. any change to source file propagates into workfile).
How to test:

Use 'Load' option in Menu, select image or render subset, with right click select ReferenceLoader
Check that new layer was created (small chain icon highlights its linked, disk icon denotes embedded SmartObject)
Change content of loaded file, it should change in PS too (without restart)

Contains also #2118 changes  as it would create conflicts when 2 PR are opened for same areas. #2118 should be probably merged first.

Task linked: OP-1206 Add loader for linked smart objects in Photoshop


Add link to docs also in README

An explicit link on README to the docs will help users to find https://umami.is/docs/login for initial credentials e.g.

Done


Add link to ASV pvlib-benchmarker in documentation

Problem
I can't find any reference or links to the ASV benchmarker in the documentation
Solution
I think a small section with a link to the ASV benchmarker and some discussion about why we benchmark pvlib, how to use read the results, and whatever
Alternatives
There are links in the pull request #1049
Additional context
The benchmarks are really cool, and it's impressive that we have them, so we should advertise and help people use them and solicit their feedback on how we can improve, what's useful, what's not, etc.

ICYMI, there technically is a trail of breadcrumbs that gets you to the benchmark graphs page, but it's a little roundabout:

https://pvlib-python.readthedocs.io/en/stable/contributing.html#benchmarking
https://github.com/pvlib/pvlib-python/blob/master/benchmarks/README.md

But it's not very discoverable and can certainly be made more useful.

ICYMI, there technically is a trail of breadcrumbs that gets you to the benchmark graphs page, but it's a little roundabout:

https://pvlib-python.readthedocs.io/en/stable/contributing.html#benchmarking
https://github.com/pvlib/pvlib-python/blob/master/benchmarks/README.md

But it's not very discoverable and can certainly be made more useful.

Agh! I searched different variations of benchmark(s) and benchmarker, but not "benchmarking" and evidently the sphinx/rtd search engine is very picky.

Agh! I searched different variations of benchmark(s) and benchmarker, but not "benchmarking" and evidently the sphinx/rtd search engine is very picky.

How about adding to the table of badges in the main readme?

How about adding to the table of badges in the main readme?

Working on this issue @mikofski

opened pull request for this recommendation

closed by #1427


build: remove publishing of outputs to s3 bucket

The storage of outputs to s3 is not needed by provider repos.
Their important artifact is the container image which will still
be published to dockerhub.
Signed-off-by: Jared Watts<EMAIL_ADDRESS>Related to https://github.com/crossplane/crossplane/issues/1320
This PR will be tested by exercising the build process in CI on Jenkins.  Previous PRs have been publishing their output to s3, so we will verify that s3 does not get any output published to it from this PR.
Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[x] Updated any relevant documentation, examples, or release notes.
[x] Updated the dependencies in app.yaml to include any new role permissions.
[x] Updated the stack resources documentation to include any new managed resources or classes.

@hasheddan the integration tests failed on Jenkins, so I tried the change you suggested, hoping it would fix that issue too.  It did get rid of an earlier error output (ERROR: unknown flag: --name), but I still have what looks to be a real failure to track down:
>>>>>>> installing tiller
serviceaccount/tiller created
clusterrolebinding.rbac.authorization.k8s.io/tiller created
$HELM_HOME has been configured at /Users/jared/.helm.
Error: error installing: the server could not find the requested resource

I think this is root cause for the e2e failure since we've updated kind that now uses a new k8s node image (1.17) which removed extensions/v1beta1 that helm v2.10 in our integration tests is still using:
https://github.com/helm/helm/issues/6374
Maybe we bump the integration tests to use a newer version of helm.

Bumping to helm v2.16.0 (as per https://github.com/helm/helm/issues/6374#issuecomment-551189447) makes integration tests pass locally via make e2e.  Fingers crossed for Jenkins 🤞

@jbw976 i may follow this up by moving to helm 3 but that can be deferred for now :)

Sweet, CI is green and I verified that S3 bucket was not touched. https://releases.crossplane.io/build/PR-214/ is an old crossplane/crossplane build from Dec 2018.
This is ready for review! 🚀


test: fix netpoll ut in windows

What type of PR is this?
test
Check the PR title.

[x] This PR title match the format: <type>(optional scope): <description>
[x] The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.
修复 windows 环境允许netpoll相关单测报错的问题
(Optional) More detail description for this PR(en: English/zh: Chinese).

en:
zh(optional):
Which issue(s) this PR fixes:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: welkeyever:white_check_mark: li-jin-gou:x: AdminAdmin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


librewolf: move out of firefox directory

This is a proposal for moving Librewolf out of the Firefox directory while still sharing the Firefox build expressions between the two packages. See #160520

make the firefox common.nix available from the top level as buildFirefox
use new buildFirefox function in librewolf expressions
minor changes to update script

This doesn't cause any rebuilds.
cc @mweinelt

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Can you import common like thunderbird is doing it instead of reworking top-level?
https://github.com/NixOS/nixpkgs/blob/ed32ed96331c213ebc2a0c579008f96efc89dcc9/pkgs/applications/networking/mailreaders/thunderbird/packages.nix#L3-L8

Can you import common like thunderbird is doing it instead of reworking top-level?

Yes, I can do that.
I started out doing that but there was some code duplication. In particular, there would have to be an identical top-level newScope call in both places. So I wanted a way to reuse the scope, since I couldn't think of a reason they would be different.

Okay, I don't have a strong opinion really. Maybe wait for @lovesegfault's opinion.

Okay, I don't have a strong opinion really. Maybe wait for @lovesegfault's opinion.

I'm happy to do it either way. One argument for your proposal is that, maybe Librewolf will fall behind and require a different version of rustc or whatever else goes into the scope. It would be easier to handle this case. And we might want to optimize for this, since we don't want to delay Firefox updates if Librewolf lags.
If we do it with the rework, perhaps Thunderbird should also use the buildFirefox function.

Well, I agree that something like buildMach (for mozillas mach build system) would be more meaningful that import common.nix.

buildWeirdAnimal

As for rustc etc. I expect they're mainly about the version attribute passed to common.nix. We already maintain some variants because of ESR (and thunderbird also follows ESR schedule). But I'm only guessing what librewolf does here.

This is a good point. common.nix already supports an ESR release which is almost certainly older than Librewolf. So far I've seen Librewolf lag by a matter of days, not weeks or months.

Rebased and changed the function to buildMozillaMach

Thank you.


"composer" no longer works, modification between php 7 and 8

problem:
   - goaop/framework 2.3.4 requires php ~7.0 -> your php version (8.0.3) does not satisfy that requirement.

"compose" doesn't work anymore, it seems that there is no possibility to have the old builds of the previous versions, you have to create the dockerfile to use this version of php.    PHP_EOL; \
      exit(1); \
    }" \
  ; \
  php /tmp/installer.php --no-ansi --install-dir=/usr/bin --filename=composer --version=${COMPOSER_VERSION}; \
  composer --ansi --version --no-interaction; \
  composer diagnose; \
  rm -f /tmp/installer.php; \
  find /tmp -type d -exec chmod -v 1777 {} +

COPY composer/docker-entrypoint.sh /docker-entrypoint.sh

WORKDIR /app

ENTRYPOINT ["/docker-entrypoint.sh"]

CMD ["composer"]

in  composer/docker-entrypoint.sh
#!/bin/sh

isCommand() {
  # Retain backwards compatibility with common CI providers,
  # see: https://github.com/composer/docker/issues/107
  if [ "$1" = "sh" ]; then
    return 1
  fi

  composer help "$1" > /dev/null 2>&1
}

# check if the first argument passed in looks like a flag
if [ "${1#-}" != "$1" ]; then
  set -- /sbin/tini -- composer "$@"
# check if the first argument passed in is composer
elif [ "$1" = 'composer' ]; then
  set -- /sbin/tini -- "$@"
# check if the first argument passed in matches a known command
elif isCommand "$1"; then
  set -- /sbin/tini -- composer "$@"
fi

exec "$@"

i have not this best solution :)

@scwall The original line:
   - goaop/framework 2.3.4 requires php ~7.0 -> your php version (8.0.3) does not satisfy that requirement.

Points to an issue in your application's composer dependencies, not in composer itself. You're trying to run on PHP 8, when it looks like your application is expecting PHP 7. You can adjust the version of your php.dockerfile with the top line FROM php:7.4-fpm-alpine (or similar).
After that, I'd recommend running docker system prune and docker-compose build after saving those changes to re-build your containers with the new PHP version.
Let me know if there's anything else I can do to help!

Hello @aschmelyun
I think you missed the real issue here. The composer image which is defined in the composer service uses a different php version than the rest of the stack, which leads an ambiguities:  the most common scenario which led me to errors was using php:7.4.27-apache on my LAMP docker stack, and composer:2 (or composer latest) which internally uses php 8.1.1.
In order for my setup to work I had to explicitly define the last composer image that used php 7.4 and that was composer:2.0.8 image (it uses php 7.4.14, I mention it here for reference).
In the end I think the best solution would be something like the one @scwall offers, which is to build the image from the existing php image. However I am in no position to tell if there is any place for improvement!


Doc update with minor corrections

This PR corrects minor doc issues regarding

usage of VPC CNI custom networking
feature gate drift

Description
Documentation updates
How was this change tested?
Does this change impact docs?

[x] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks for picking this up! Could you please also add these changes to preview? https://github.com/aws/karpenter-provider-aws/blob/main/website/content/en/preview/concepts/nodeclasses.md?plain=1#L386 and https://github.com/aws/karpenter-provider-aws/blob/main/website/content/en/preview/reference/settings.md?plain=1#L48

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
128 unchanged lines in 10 files lost coverage.
Overall coverage decreased (-0.3%) to 83.064%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/bootstrap/bottlerocketsettings.go
2
93.55%

pkg/fake/utils.go
2
94.56%

pkg/providers/amifamily/bootstrap/bootstrap.go
2
92.98%

pkg/providers/amifamily/bootstrap/bottlerocket.go
4
92.59%

pkg/providers/instanceprofile/instanceprofile.go
7
80.77%

pkg/providers/instancetype/instancetype.go
8
94.48%

pkg/errors/errors.go
11
55.56%

pkg/providers/amifamily/bootstrap/eksbootstrap.go
24
72.27%

pkg/operator/operator.go
29
9.2%

pkg/fake/iamapi.go
39
64.23%

Totals

Change from base Build<PHONE_NUMBER>3:
-0.3%

Covered Lines:
5596

Relevant Lines:
6737

💛  - Coveralls


Fix AudioNode.connect method

See spec
Fixes Microsoft/TypeScript#14355

@bondz,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


Create RBAC tables

Create RBAC tables:
permission (id, name)
role (id, name)
role_permission (role-to-permission join table)
user_role (user-to-role join table)
Initial permissions: admin, user
role: administrator, user
role_permission: administrator <-> admin
role_permission: user <-> user
unique indexes on name should be CREATE UNIQUE INDEX idx_lower_xyz ON table (lower(name))

Done.


 not enforced

Modify the examples/worlds/apply_joint_force.sdf adding an effort tag:
<joint name="j1" type="revolute">
        <pose>0 0 -0.5 0 0 0</pose>
        <parent>base_link</parent>
        <child>rotor</child>
        <axis>
          <xyz>0 0 1</xyz>
          <dynamics>
            <damping>0.0001</damping>
          </dynamics>
          <limit>
            <effort>0.0001</effort>
          </limit>
        </axis>
      </joint>

Launch Gazebo:
ign gazebo -v 4 ../examples/worlds/apply_joint_force.sdf

Apply the theoretical max torque:
ign topic -t "/model/joint_force_example/joint/j1/cmd_force" -m ignition.msgs.Double  -p "data: 0.0001"

Observe how the joint starts spinning relatively slow.
Now, apply a bigger torque:
ign topic -t "/model/joint_force_example/joint/j1/cmd_force" -m ignition.msgs.Double  -p "data: 0.001"

The joint will start spinning faster than before but it shouldn't, as the first command was already applying the maximum allowed torque.

This sounds similar to #214 , but specific to <effort>.

True. Not sure if all elements of <limit> are ignored. If that's the case, we can close this ticket in favor of #214 .

I believe the issue #214 occurs only when using components::JointVelocityCmd, which is used by the JointController system. Fixing that will take some time since it requires a change in DART. The issue here is something we can fix in ign-physics, so it might be worth keeping them separate.

Fixed by https://github.com/ignitionrobotics/ign-physics/pull/74


[RFC] boring stuff: define a sampler interface

There's a lot of hot stuff in the pipeline re. MCTS, the vanilla sampler, etc.
One thing I'm afraid of is that there's going to be a lot of spaghetti involving bespoke/subtly different ways to call different samplers, which will make benchmarking and comparison painful.
I want to get ahead of this issue by defining a common interface to samplers. Since this is Python I think this should be a Protocol, something like:
class Sampler[Cfg](Protocol):
     def sample(gen_tokens: jax.Array, logits: jax.Array, attention_scores: jax.Array, cfg: Cfg) -> int:
          ...

which is a light touch (no need to inherit) but can still be checked. This should be a generic enough framework for people to be able to implement their favorite MuZero etc.  and have it all plug in to the same harnesses.
My goal here is to have an easy to maintain sampler benchmarking suite with easy plug and play samplers.

I am working on adding Entropix to vLLM so I can plug it into my inference workflows. Will reference this issue here


[OTHER] add prettier to GitHub actions

What would you like to share?
Problem: We have prettier, but it has to be run on NPM and can't be done every time because people can forget to run it
solution: Using a GitHub action to automatically run prettier every time a commit is made
Additional information
No response

It's great having you contribute to this project by creating an issue Make sure you are assigned to this before you work on it and you read the Contributing.md file, Thank you! Welcome to the community :nerd_face:

Hi @Dun-sin , I would suggest adding husky(pre-commit) hook to apply all the prettier changes to the staged files. If it works. Please, assign it to me.

@dsdeepak17 give it a try

@dsdeepak17 any updates?

@Dun-sin Sorry, I was busy, and thanks for reminding me. Will raise the PR today itself.

Hi @Dun-sin , In Contribution.md -> How to Make a PULL REQUEST, after point 8, it's mentioned that
⚠ Make sure not to commit package.json or package-lock.json file
Here, while adding husky and pretty-quick, they will be added to package.json, why do you want devs to not commit the package.json file?

Hi @Dun-sin , In Contribution.md -> How to Make a PULL REQUEST, after point 8, it's mentioned that
⚠ Make sure not to commit package.json or package-lock.json file
Here, while adding husky and pretty-quick, they will be added to package.json, why do you want devs to not commit the package.json file?

Because when you do npm install you install the latest version of the package which may mess with the whole code, only commit package.json if it's 100% needed like when you install a new package or in this case where it's needed.

:tada: This issue has been resolved in version 2.6.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Ukrainian localization

Ukrainian localization feature
django.po localization file has been edited. English phrases has been translated into ukrainian.
This PR has been made to provide ukrainian localization for crm's user interface.
Resolves: #45

@nikolayr1  ping?


Fix incorrect EFS information

Thanks for the review @bgdnlp !
@brwilson You can take bgdnlp's feedback and incorporate as best as you can? The two of you know more than I do on this. At this point, if you're both happy, I am. :)

@brwilson, just a friendly reminder about the link above. Or is it OK if this is merged and I change the link after that? Because it's good info, don't want to hold it off just for that.

Sorry for the delay! Feel free to merge/edit if there are any other changes you'd like to make.

LGTM. Thanks! Over to @ThanosBaskous to review/merge.

Merging now for expediency, as we've topic editor review already.


How to change  settings-ollama.yaml

settings-ollama.yaml is configured to user mistral 7b LLM (~4GB) and use default profile
for example I want to install
Llama 2 7B Llama 2 13B. How and where I need to add changes?

It works only Mistral 7b and only in english  everything else is "chruzemist" in Swiss German


Add doc comment for exported Format func

https://goreportcard.com/report/github.com/pkg/errors
Currently, there is only one issue on the report for github.com/pkg/errors above. This PR fixes that issue, which was an undocumented, but exported, Format function.

Thanks


Inputs and Outputs are not making it to the md files

when using the New-Markdown cmdlet, the inputs or outputs are not being populated (using a build as 2016-05-16, 9:11 EST).
I am digging into the code to see if i can determine why.

@dotps1
Let me know if you id root cause. I'm going to be submitting an update to the script that is used by New-Markdown addresses input and output objects, today. Lets see if the cause is fixed or not.

sounds good, i keep a look out for the merge to master.  thanks!

so, not sure what is going on.  here are my findings.
if i do things manually, and start in the psm1 on line 999.  and run this on my own advanced function, i have a few concerns.
on line 1001:
$Help = Get-Help $CmdletName

on line 1022:
if (-not $Help)
{
    .....

that if block will never get hit.  because even if there is no help written, $help with neither be $false or $null, so that code will never run.
so to my next point, if i run that if block code manually here is my output:
PS C:\Users\tmalkewitz\Documents\GitHub\platyPS> $MamlCommandObject

Extent      :
Name        : Add-GistFile
Synopsis    :
Description :
Inputs      : {String[]}
Outputs     : {Gist}
Parameters  : {}
Notes       :
Examples    : {}
Links       : {}
Syntax      : {}

and here is my output with the second half running:
PS C:\Users\tmalkewitz\Documents\GitHub\platyPS> $MamlCommandObject

Extent      :
Name        : Add-GistFile
Synopsis    :
Description :
Inputs      : {System.String
              System.String[]
              }
Outputs     : {Gist
              }
Parameters  : {}
Notes       :
Examples    : {}
Links       : {}
Syntax      : {}

so i really don't get this issue though, because the Inputs and Outputs have values either way, so i am really not sure why they are not being outputed.  the results are not consistent.  But i think there is bigger issues here with that if statement.
i hope this makes sense, we can chat on the gitter channel if you'd like.

I'll try to be on Glitter today. I think I'm on this most of the day trying to get it solved.
@vors and I got blocked on getting the changes merged in last night, so I am doing that now. Some of what you mentioned above is getting fixed, as we are approaching the inputs differently, taking it from the help file (if it exists) instead of trying to generate them via the Get-Command object.
Though you bring up good points and I should address them after the merge for the previous fix is complete.

@jongeller ok, lets chat on gitter.
I will take take care of this issue.
There is one trick that can be useful for you @jongeller and @dotps1
if you set $env:APPVEYOR = 1 and run tests, you will get a test run that includes some long-running tests. I only run them on CI to speed up development.
Particularly you can see the diff between what we generate and what we have inbox
windiff .\out\SMA.generated.txt .\out\SMA.original.txt

It highlights such problems very well.

@jongeller in the output of #83 it's still not right, but I'm going to merge it and then fix


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_ba34696a-fdd8-428a-ba9a-779a96de6040/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_ba34696a-fdd8-428a-ba9a-779a96de6040.git

Docs Build status updates of commit 0084f5a:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_main_2022-02-22-01-51-29 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


What Github API Key Scope(s) should be included

Just finished watching the webinar and checking out your example Gatsby web app.
Under the readme's setup instruction it lists to request/create a Github Token. However it might be helpful to include what scope(s) are necessary to include for this Github Token.
Thanks

@brentrobbins sounds great, and sorry about that!
Would you be interested in PRing it with this fix? Just a simple screenshot would be great, it just needs something like the following
Settings (top right profile picture) -> Developer Settings -> Personal Access Tokens -> Generate New Token and then the following scopes.


fix(clearThisRowInvisible) not using parameter reason

Not sure if intended but clearThisRowInvisible is not using the parameter "reason" when deleting the "invisible reason" but it always deletes the hardcoded parameter "user".
This shouldn't change any other behavior since ui-grid internal functions call this function only with the parameter "user" but it will fix any unexpected behavior when using this function with a custom invisible reason
Haven't put a check if the value exists since "delete" fails silently in that case

Thanks


fix: downgrade lint version temporarily

This pull request temporarily downgrades the GitHub workflow to align with the currently earliest version we test for with our Kokoro CI builds (1.20).
Beginning with Go 1.21, go mod tidy updates go.mod with Go version in x.y.z format. Our CI builds currently tests with Go 1.20 as the earliest version, which expects x.y format.
This mismatch creates a conflict because our lint/vet action currently uses 1.21 (and thus fail after after detecting a change after running go mod tidy if using the x.y format) or else fail in the Kokoro build on Go 1.20 if using the x.y.z format.
This issue will be resolved shortly when we move the sliding support window to Go 1.21 - 1.23.

Thank you @subfuzion -- Just to confirm that a quorum of Gophers (you, me, and @grayside ) met and agreed this was the best path forward.


Question: is inifinite scroll back instead of forward possible?

Our use case:
We enter the page at page 50, the user scrolls a bit down, and then back up. Is it possible to let the user infinite scroll back up to page 49, 48, etc. with keeping the history state?
Thanks for any help!

Hello! Sorry, no. Infinite Scroll does not support going back pages previous from the first page loaded.
From https://github.com/metafizzy/infinite-scroll/issues/728#issuecomment-339978291

Scrolling up on a previous page is a significantly more complex UX problem than scrolling down. You have to account for how the up-content affects the current scroll position. Also consider how unloaded images/media would throw off scroll position.
Scrolling up could be a nice feature, but I'm doubtful that Infinite Scroll is the correct plugin for it.


Use Orbit Alert message for emergency warnings

as mentioned in https://github.com/kiwicom/smart-faq/issues/557#issuecomment-413496072

:tada: This issue has been resolved in version 1.3.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Create Save/Load System

Create a system for saving and loading the game that triggers autosaves and allows for manual saves.
This system should save:

door states
puzzle states
dialog states
player state

While creating this system, also create a system for saving visual and control settings


add defer statement

will support swift like (block scope based) defer statement
also support value capture like the follow
defer($cwd = "$(pwd)") {
    cd $cwd    # restore directory
    rm -rf $cwd/tmp
}

cd $target_dir
do something ...

when reach defer statement, assign the result of "$(pwd)" to cwd variable which can be referred within defer block

due to implementation complexity, currently not support value capture


Update index.html

Per comment in #63 , closing this PR as we do not merge user solutions into exercise repos.


Adding a logo in the nav bar

Is your feature request related to a problem? Please describe.
No its not a problem. I tried to enhancing the look of navbar.
Describe the solution you'd like
The navbar is missing a logo and that makes it look very dull, I would like to add a logo in the navabar, similar to the one in the title

I would to work on this issue under GS'SOC21
Additional context
Add any other context about the feature request here.

I Would like to work on this issue as a GSSOC'21 participant.

@sagunjaiswal @shubhraagarwal  @Aanchal116 @0Faiz0 @ORKO06 @abhishek96k You all can suggest the logo designs.

Anybody interested or shall I close this issue !!


cloning made consistent

Cloning a study duplicates the whole folder, but cloning a single component does not duplicate the html file. There might be good reasons for this, but are there?

Yes indeed, there is a good reason for this. If JATOS clones a whole study
it knows exactly which files belong to the study, namely everything within
the study assets folder. But if JATOS has to clone a component it doesn't
know what files belong to the component. It knows the HTML file file, but
not CSS or JS files. JATOS could find out by parsing the HTML file. But
this would open hell's gates. What if the HTML isn't currently valid? What
if the JS has a syntax error. A parser would fail. Another point: What if
the user intends to use the same CSS/JS (quite likely). Should I clone
CSS/JS automatically too or let the user do it himself?
So I decided for now not to clone the HTML file. Although now that I'm
thinking about it, how about I clone the HTML together with the component
and display a message in the GUI saying the name of the clone HTML file and
the info that other files (CSS, JS) has to be cloned by the user.
On Tue, Mar 3, 2015 at 2:09 PM, elisafilevich<EMAIL_ADDRESS>wrote:

Cloning a study duplicates the whole folder, but cloning a single
component does not duplicate the html file. There might be good reasons for
this, but are there?
—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/59.

Would be a solution, but let's wait what people say. This might actually bring more confusion than not cloning anything.
Let's leave it on hold
On 3 Mar 2015, at 14:21, Kristian Lange<EMAIL_ADDRESS>wrote:

Yes indeed, there is a good reason for this. If JATOS clones a whole study
it knows exactly which files belong to the study, namely everything within
the study assets folder. But if JATOS has to clone a component it doesn't
know what files belong to the component. It knows the HTML file file, but
not CSS or JS files. JATOS could find out by parsing the HTML file. But
this would open hell's gates. What if the HTML isn't currently valid? What
if the JS has a syntax error. A parser would fail. Another point: What if
the user intends to use the same CSS/JS (quite likely). Should I clone
CSS/JS automatically too or let the user do it himself?
So I decided for now not to clone the HTML file. Although now that I'm
thinking about it, how about I clone the HTML together with the component
and display a message in the GUI saying the name of the clone HTML file and
the info that other files (CSS, JS) has to be cloned by the user.
On Tue, Mar 3, 2015 at 2:09 PM, elisafilevich<EMAIL_ADDRESS>wrote:

Cloning a study duplicates the whole folder, but cloning a single
component does not duplicate the html file. There might be good reasons for
this, but are there?
—
Reply to this email directly or view it on GitHub
https://github.com/JATOS/JATOS/issues/59.

—
Reply to this email directly or view it on GitHub.

I implemented a solution: The HTML file will be cloned together with the component. The file gets the suffix '_clone'. If the file doesn't exists or there is no file name entered nothing is done. All other files (CSS, JS, images) that might be used by this component won't be cloned.

Is it done?

Almost, once quality check is done!

Closed


Added a new handler for converting rgba(...) to rgb(...)

I didn't attempt to do anything with the Alpha value, though you could give it a default color to blend with instead, don't know how useful that would be.

This is my oldest still-open pull. Goodnight sweet prince!


A Reactive Renderer

Hi Vitaly,
I am working with React and would love to build a renderer for markdown-it that renders the AST into a react component tree.
Where shall I start if I want to do this?
Thanks,
Ge

No ideas, i'm still not familiar with react. Docs aboout markdown-it are here https://github.com/markdown-it/markdown-it/tree/master/docs. Also plugins can be searched via npm.

Thanks Vitaly.
I'm thinking about using the markdown-it parse function instead of the
render function. That way I am effectively making a customer renderer.
Best,
Ge
On Friday, June 24, 2016, Vitaly Puzrin<EMAIL_ADDRESS>wrote:

Closed #262 https://github.com/markdown-it/markdown-it/issues/262.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/markdown-it/markdown-it/issues/262#event-703910024,
or mute the thread
https://github.com/notifications/unsubscribe/AAme2hTxj3Pss_3N0YPW-586Wm516ltwks5qPKa9gaJpZM4I-QiT
.


Port over documentation on using flocker.restapi from HybridCluster

There was some internal user-facing docs that are still useful with new code.

We are moving our development planning to JIRA. This is issue is now being tracked at https://clusterhq.atlassian.net/browse/FLOC-920. You are welcome to file additional issues in GitHub if that's easier for you.


commit message creation /commit creates messages with unwanted text

Issue
Since the change to the commit message prompt, it does not seem to work properly for me.
I get messages like these running /commit:

feat(foo): add support for bar
The commit message follows the Conventional Commits guidelines:
feat(foo): add support for bar

This happened for multiple commit messages I tried to create.
Version and model info
Aider v0.47.0
Models: claude-3-5-sonnet-20240620 with diff edit format, weak model claude-3-haiku-20240307
Git repo: .git with 13,733 files
Repo-map: using 1024 tokens
AIDER_AUTO_COMMITS=false

This just got introduced in 0.47.0.
you can see the prompts here: https://github.com/paul-gauthier/aider/blob/main/aider/prompts.py
Also there was a change in 0.47.1. Maybe try again and report back, or edit the prompt.

Thanks for trying aider and filing this issue.
The latest 0.47.1 should be better for this.

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


TypeError: 'Tensor' object is not callable

torch.manual_seed(42)
An epoch is one loop through the data...
epochs=1
Training
1. Loop through the data
for epoch in range(epochs):
# Set the model to train mode
model_0.train() # turn on gradient requires gradient
# 2. Forward pass
y_preds = model_0(x_train)

# 3. Calculate the loss
loss = loss_fn(y_preds,y_train)
print(f"Loss: {loss}")

# 4. Optimize zero grad
optimizer.zero_grad()
# 5. Perform backpropagartion on the loss with respect to the parameters of the model
loss.backward()
# 6. set the optimizer
optimizer.step()
# Testing
model_0.eval() # turn off gradient

If you can paste whole cell code and complete error, it is easy to help

I received this error a couple of times.  Without more details difficult to pinpoint. When I got the errors most of the time the problem was with a conflicting 'type'  Could be the way arguments/parameters are passed between functions. By default the objects created may have a type of 'any' which work in most cases but not in functions that are particular about a specific type. For example a transform result passed into another tool function may result in an not callable object due to the 'type' conflict in one of the parameters.


Transfer the website to React

Current Behavior
Currently, the website is made with just HTML and CSS
Desired Behavior
I can transfer the whole code to React with maintain readability and cleanliness. It would be more efficient in its working.
Screenshots / Mockups

Please assign this issue to me under GSSOC

Hey @Palakkgoyal , thanks for stepping up!
Actually this was done in some PR, we will get back to u ,if we are going to shift to it.


Avionics CAD files

Adding Avionics individual CAD files and an assembly.

@Mike-Kimani  aren't the mounting cases same as those in Florida ght comtrol

Do you have a battery, FPV camera, ESP Camera?


Dim to warm

Set color temp based on sun position AND current brightness. see #78
Calculates color_temp first, then uses that value as a max to then calculate again based on brightness in the following eq:
color_temp_kelvin = ((min_ct-max_ct)/(min_brightness-max_brightness)**2)*(brightness-max_brightness)**2+max_ct
when brightness is the current brightness.
Just set dim_to_warm: true in the config to get started.

@basnijholt Why are the pre-commit filters so strict on formatting?
Example: custom_components/adaptive_lighting/switch.py:836:101: E501 line too long (106 > 100)
Do I need to fix all of these?

The strict formatting is such that one never needs to have discussions about style. The filters dictate the style and that's it :smile:
I just fixed the line lengths for you.

@basnijholt I don't quite understand these workflow actions. I'm confused by how to effectively use pre-commits but I'll figure it out as I get accustomed.
My main concern is: why is pytest failing on all commits we are pushing?  I'm using GitHub desktop, but even when I open the terminal and try that command, I get:
C:\Users\*****\Documents\GitHub\adaptive-lighting>pre-commit install
'pre-commit' is not recognized as an internal or external command,
operable program or batch file.

C:\Users\*****\Documents\GitHub\adaptive-lighting>git pre-commit install
git: 'pre-commit' is not a git command. See 'git --help'.

The most similar command is
        verify-commit

C:\Users\*****\Documents\GitHub\adaptive-lighting>

My main concern is: why is pytest failing on all commits we are pushing? I went back in the timeline and it seems to even be failing on the master branch - spanning back several months?

Yes there are 3 tests that are failing, which I want to get to. I am not sure whether the features that it is testing are actually broken or if it is because the test is bad.

Can you point out the last commit you've made where pytest and validate with hassfest worked correctly? Using the documentation on the hass developer website I might be able to look into that this weekend.

https://github.com/basnijholt/adaptive-lighting/commit/ce4503c9c6c8323802c7c6c350496e8fa883e042 is that commit. However, no Adaptive Lighting code changed. Rather Home Assistant core changed.

ce4503c is that commit. However, no Adaptive Lighting code changed. Rather Home Assistant core changed.

Ah I see. Hopefully it isn't too hard to solve, I'd love to be able to test locally rather than making my home patient 0 for a lighting test.
By the way, all pre-commits have been finished for all of my PRs.

This PR cannot continue until https://github.com/basnijholt/adaptive-lighting/issues/78#issuecomment-1476909412 has been addressed.

One thing we could do, is to approximate the equation that Adaptive Lighting is using in Apple HomeKit.
I personally have an unused Philips Hue Hub which I can set up with one of my Hue lights.
Then I would let a light run for 24h at 100% brightness and poll the light each minute for its state with https://github.com/studioimaginaire/phue.
Then I would set the light to 85% brightness and repeat.
Repeat again with decreasing brightness.
We would then have a dataset which with we can determine how to implement this as in HomeKit.

I can actually also come up with a scheme to sample all the brightnesses in a single day.
I just need to program the sampling and experiment a bit.

Brilliant!!

This functionality is similar to what I posted in #127 the intent is to allow parts of the day to change both brightness and color temp together instead of changing one or the other if the sun is above or below the horizon.


gitleaks --verbose

gitleaks --verbose option not working even not listing in all options using help.

Is this via the docker image by chance ?
I have a feeling the image needs to be updated and could be out of sync.
If you grab the latest release, it seems to work for me for remote and local repos.
$ ./gitleaks-darwin-amd64 --verbose https://github.com/zricethezav/gitleaks
2018/05/09 13:53:39 cloning https://github.com/zricethezav/gitleaks into /tmp/gitleaks...
{
   "line": "-\tleaks := doChecks(\"aws=\\\"AKIALALEMEL33243OLIAE\",",
   "commit": "fe977ea8577b739c34a0071ba34e98cf6b6fad38",
   "string": "AKIALALEMEL33243OLIA",
   "reason": "AWS",
   "commitMsg": "Merge pull request #57 from zricethezav/feature/external-regex",
   "time": "2018-03-10 13:34:57 -0600",
   "author": "Zachary Rice",
   "file": "checks_test.go",
   "repoURL": "https://github.com/zricethezav/gitleaks"
}

have clone your repo https://github.com/zricethezav/gitleaks but still won't get the verbose option

All, sorry for the hiatus. Updated travis to handle the docker builds. docker is now all up to date.
Try removing the binary and rebuilding if you are running from a build locally.
rm $GOPATH/bin/gitleaks
go build
./gitleaks

see if that works

Thanks @zricethezav ! its working :)

Great! closing


added face-recognition

This feature enables user authentication through face recognition using the webcam. It captures the user's image and compares it with the stored image to determine if access should be granted. The application also handles the following scenarios:
1: No face detected: If no face is visible, access is denied.
2: Multiple faces detected: If multiple faces are detected, access is denied.
3: Unauthorized face: If the detected face doesn't match the stored image, access is denied.

We have tested the feature and found that it works well, but it gets confused in some cases, giving us some false positives. FaceAPI.js is a good choice, but we would like you to improve  upon the component by testing with more cases. We expect at least 90% accuracy from the model. Please try tweaking some parameters and improving the performance of this component and let us know once done, and we will give it another review.

@Kapil-Mulay-1421 Got it,will work on it and will update soon.

@Kapil-Mulay-1421 kindly review the changes made

Hi Karan, we have tested the model and it seems to be working accurately now. Using multiple photos to improve the accuracy was a good approach. However, the component needs to be integrated into the main application. Please take a look at our proctoring components in 'frontend-cal/src/components/proctoring-components' and see how they are implemented in the 'sidebar-right.tsx' component. We can merge the PR once this integration is done. Feel free to let us know if you have any doubts.


auto-indent on close brace or paren

when you close a brace or paren, that should reindent the current line at its new indent level.

looks like this is best fixed by turning electricChars back on.  this was disabled some time ago because it was causing a problem with {} in strings https://github.com/twosigma/beaker-notebook/issues/1141 but i can't reproduce it now.  perhaps updating to a newer codemirror fixed it.


WebXR WebIDL

Summary
It looks like the upcoming W3C Standard WebXR is getting some support in browsers. I've been trying to implement the Web IDL based on the Draft Spec (which is the version being implemented in browsers, I believe): https://www.w3.org/TR/2019/WD-webxr-20190521/#idl-index. However I can't seem to produce the bindings - do you know anyone who's had success with this?
Additional Details
I've been following the contribution guide for Web IDL (https://rustwasm.github.io/docs/wasm-bindgen/contributing/web-sys/supporting-more-web-apis.html) and have come up with this attempt: https://github.com/kevthecoder/wasm-bindgen/pull/1/files
I don't seem to be getting any bindings appearing in bindings.rs, but I'm not seeing any Unsupported WebIDL interface warnings when I run:
cd crates/web-sys
RUST_LOG=wasm_bindgen_webidl cargo build -vv

I appreciate it's early days for the standard so this is probably a low priority, but thought I'd be check if anyone could spot a problem with the attempt above, or if anyone has had success implementing WebXR.
Thanks!

If you use the __WASM_BINDGEN_DUMP_FEATURES feature of the build script I think the feature should be named Xr instead of XR, and that should do the trick?

Thanks very much @alexcrichton.  Looks like I've got the bindings now.
I'll keep working on a basic example then submit a Pull Request once WebXR stabilises.

WebXR has shipped in Chrome and for the Oculus Browser. It'd be great to see support added here. Any update on this?

To add to this it seems like some modifications need to be made to the IDL to have full WebXR support.
While I didn't dig into what it means (I'm not an expert here) the WebXR IDL features a number of "FrozenArrays" that seem to be not supported. Other IDLs have examples of how to modify the FrozenArray lines, but I'm not sure what the implications are.
This is something that would need to be updated in @kevthecoder 's pull request.

I've closed the old Pull Request and opened https://github.com/rustwasm/wasm-bindgen/pull/2000 which matches with the "Candidate Recommendation" version of WebXR (https://www.w3.org/TR/2019/WD-webxr-20191010/).
This version of WebXR is supported by Chrome 80 without flags, but not supported by Firefox yet.
There's a new example project added to the examples/ directory. It mainly works - but I'm having trouble getting XrSession.request_animation_frame() working (I think the session goes out of scope before the animation loop is started).


Add gpt-4o

Hello,
How do I add gpt-4o to as the primary instead of gpt-4-turbo? I added a custom model, but I am not sure how to switch.
Thanks!

gpt-4o is the new default in 1.0.0 but in the future you can set a new model for a role using plandex set-model


slic3r gui fails

Issue description
When I issue:

slic3r --gui

I get the following error:
Gtk-Message: Failed to load module "overlay-scrollbar"
Gtk-Message: Failed to load module "unity-gtk-module"
Gtk-Message: Failed to load module "canberra-gtk-module"
Can't load '/nix/store/12j8ikqfhxp27bxrd55h2900cb277fzn-perl-OpenGL-0.6703/lib/perl5/site_perl/5.22.2/x86_64-linux-thread-multi/auto/OpenGL/OpenGL.so' for module OpenGL: /nix/store/12j8ikqfhxp27bxrd55h2900cb277fzn-perl-OpenGL-0.6703/lib/perl5/site_perl/5.22.2/x86_64-linux-thread-multi/auto/OpenGL/OpenGL.so: undefined symbol: glWindowPos4dMESA at /nix/store/xcp6lrq3ynj75cqcyy7b32jgizf9jr4b-perl-5.22.2/lib/perl5/5.22.2/x86_64-linux-thread-multi/DynaLoader.pm line 193.
at /nix/store/n73gf9sncjrv2aqj4lycd7b5qipvj3dp-slic3r-1.2.9/share/slic3r/lib/Slic3r/GUI/Plater/2DToolpaths.pm line 120.
Compilation failed in require at /nix/store/n73gf9sncjrv2aqj4lycd7b5qipvj3dp-slic3r-1.2.9/share/slic3r/lib/Slic3r/GUI/Plater/2DToolpaths.pm line 120.
BEGIN failed--compilation aborted at /nix/store/n73gf9sncjrv2aqj4lycd7b5qipvj3dp-slic3r-1.2.9/share/slic3r/lib/Slic3r/GUI/Plater/2DToolpaths.pm line 120.
Compilation failed in require at /nix/store/n73gf9sncjrv2aqj4lycd7b5qipvj3dp-slic3r-1.2.9/share/slic3r/lib/Slic3r/GUI.pm line 16.
BEGIN failed--compilation aborted at /nix/store/n73gf9sncjrv2aqj4lycd7b5qipvj3dp-slic3r-1.2.9/share/slic3r/lib/Slic3r/GUI.pm line 16.
Compilation failed in require at (eval 80) line 1.
Steps to reproduce
See above.
Technical details

System: (NixOS: nixos-version, Ubuntu/Fedora: lsb_release -a, ...)
Distributor ID: Ubuntu
Description:    Ubuntu 15.10
Release:    15.10
Codename:   wily
Nix version: (run nix-env --version)
nix-env (Nix) 1.11.4
Nixpkgs version: (run nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion)
17.03pre93030.548bcd0

I just tried out slic3r on a recent 16.09. Same problem here.

After some digging it looks like the glWindowsPos4* symbols are missing from libGL.so, but I am not sure they are supposed to be there in the first place. However, they are required by the perl OpenGL bindings.

Updating perlPackages.OpenGL to 0.70 did the trick on my machine.

Hm, I get segfault (after upgrading OpenGL to 0.70):
$ ./result/bin/slic3r --gui
Segmentation fault

I based my modifications on this commit:  45b2a6d88299bb5671e36a4239ec0097bc149fb3
I have the branch here if you want to try: https://github.com/timor/nixpkgs/tree/slic3r-gui
Also, it seems it is not working perfectly: The print surface is not rendered.  This may  be a problem with the graphics drivers though.  As far as I can tell, I am using the free ATI drivers (haven't changed anything in configuration.nix).

@timor: Hm, your opengl bump is exactly like mine, so there must be something else.

I cherry picked the commit from @bjornfor and can report the same results.  Slic3r works, but it doesn't render the print surface anymore.
Can we get someone from upstream involved?

@bjornfor Do you need any help with this issue?  I'm still having to patch nixpkgs due to this.  Thanks.

Pushed that commit to master and 17.03 as it definitely improves the situation

@globin That patch at least lets slic3r run, but it's missing the object platform.  That makes it very hard to use.  Do we need another issue to track that?


How to run ?

is not working bro how to run your project?

yarn install -g

yarn

yarn pepsi

is working 😊😁


Revise function and argument naming

To discuss:

plot functions naming
settingsColumns, strataColumns, ...
header, hide, groupColumn, excludeColumns, ...

visOmopTable(
  result,
  formatEstimateName --> estimateName
  header = character(),
  settingsColumns = character(), --> settings
  groupColumn = character(), --> groups
  renameColumns = character(), --> rename
  type = "gt",
  hide = character(),
  showMinCellCount = TRUE,
  .options = list(),
  split = lifecycle::deprecated(),
  minCellCount = lifecycle::deprecated()
)

formatEstimateName --> estimateName = character() # changes in formatEstimateName, visOmopTable, formatTable
settingsColumns --> settings # changes in visOmopTable, addSettings and tidySummarisedResult
renameColumns  --> rename # changes in visOmopTable, and formatTable
groupColumn  --> groups # changes also in visOmopTable, formatTable, gtTable, and fxTable
groupAsColumn  --> groupsAsColumn # changes also in  gtTable, and fxTable

difference between groupColumn and groupAsColumn?

RenameformatTable function to visTable
Add formatTable function which is = as gt and fx table but with "type" argument, and we reeport this one but not gt and fx

so we will have visOmopTable, visTable, formatTable ? difference between them:

visOmopTable: specific to summarised_result objects
visTable: not specific to summarised_result objects
formatTable ??

additionalColumns() → getAdditionalVariables() / getAdditionalVars()
groupColumns() → getGroupVariables() / getGroupVars()
settingsColumns() → getSettingsVariables() / getSettingsVars()
strataColumns() → getStrataVariables() / getStrataVars()
tidyColumns() → getTidyVariables() / getTidyVars()

I don't like get... But happy to discuss, my proposals:

namesAdditional()
columnsAdditional()
colnamesAdditional()
...

formatEstimateName --> estimateName = character() # changes in formatEstimateName, visOmopTable, formatTable
settingsColumns --> settings # changes in visOmopTable, addSettings and tidySummarisedResult
renameColumns  --> rename # changes in visOmopTable, and formatTable
groupColumn  --> groups # changes also in visOmopTable, formatTable, gtTable, and fxTable
groupAsColumn  --> groupsAsColumn # changes also in  gtTable, and fxTable

difference between groupColumn and groupAsColumn?

the first sets which are the grouping columns while the second is to set whether to have them as rows or columns

RenameformatTable function to visTable
Add formatTable function which is = as gt and fx table but with "type" argument, and we reeport this one but not gt and fx

so we will have visOmopTable, visTable, formatTable ? difference between them:

visOmopTable: specific to summarised_result objects
visTable: not specific to summarised_result objects
formatTable ??

substitutes gt/fx table (would be internal). is the last step in the format functions workflo

additionalColumns() → getAdditionalVariables() / getAdditionalVars()
groupColumns() → getGroupVariables() / getGroupVars()
settingsColumns() → getSettingsVariables() / getSettingsVars()
strataColumns() → getStrataVariables() / getStrataVars()
tidyColumns() → getTidyVariables() / getTidyVars()

I don't like get... But happy to discuss, my proposals:

namesAdditional()
columnsAdditional()
colnamesAdditional()
...

i dont rwally like any, i'll agree with what you consider best

group needs discussion
align groupAsColumns when decided the first

Agreement on visOmopTable, visTable and formatTable

For the moment we leave those functions as they are

pivotEstimates(pivotEstimatesBy) -> pivotEstimates(nameFrom/pivotFrom/pivotBy) [To consider, maybe next release if no agreement reached]

Agreed on this?
formatEstimateName --> estimateName = character()
settingsColumns --> settings
renameColumns --> rename
and I'd like to add:
colsToMergeRows --> merge

@catalamarti  settingsColumns --> settings can't be changed because it causes problems with the settings function


PyLSL in Docker

Hi, I'd like to run PyLSL to Docker, I was wondering which port of my container I should expose to get the data from the OpenBCI GUI ? Usually pylsl uses which port to establish the TCP connection ?

I'm afraid there's a bit more needed, unless you play around with the lab.KnownPeers configuration variable.
The firewall configuration page lists the ports (as for the multicast groups, only one is needed). Last time I checked, Docker doesn't really play well with multicast, but it might have gotten better.

I am running pylsl inside of a container which exposed the following ports, "16571-16604:16571-16604", however I am unable to resolve_stream(), e.g. the application does not detect the stream of data whne I do "Start LSL Stream" from the OpenBCI GUI. Could you clarify if I should expose other additional ports ? Which port does the OpenBCI GUI uses when connecting the LSL stream ?

Hi @mlej8
did u try ti configure the container with network_mode: host and privileged runtime capabilities? With those two enabled you won't need to expose any ports because you'll share the host network resources and devices.
https://docs.docker.com/network/network-tutorial-host/
https://docs.docker.com/engine/reference/run/#runtime-privilege-and-linux-capabilities

Hi @ddetommaso , thank you for your response, yes I tried running the container using the host's network with priviledged mode, but I still couldn't resolve_stream() using the OpenBCI_GUI Networking Test Kit LSL lslStreamTest.py. Have you tried and it worked?

Hi @mlej8
I don't have a specific experience with OpenBCI but I have with integrating LSL in dockers. Using the aforementioned options you should be able to use the same network capabilities of your host machine, so maybe the issue it's of a different kind (GUI issue?). Enabling detailed debug info inside your application we can investigate more.

@ddetommaso, I am trying to run the following script: https://github.com/OpenBCI/OpenBCI_GUI/blob/master/Networking-Test-Kit/LSL/lslStreamTest.py inside of a docker container with network=host and privileged mode. When I do start LSL stream from the OpenBCI Windows GUI I don't receive the stream inside of my container, whereas when I run the same script on WSL, everything works as expected and I am able to get the stream to my terminal.

@mlej8  could u please detail more your experimental setup? Specifically, if the docker container it's running on Windows on the same machine of the server or on a different operating system. Did u try to access the low-level API of OpenBCI from the docker container?

The docker container is ran using Docker Desktop for Windows on WSL 2. The container is running on my machine (on WSL 2). The OpenBUI GUI is also opened on my machine. I have not tried the low-level API of OpenBCI, could you point me to the repo where I can find it ?

Hi @mlej8
I don't have experience with WSL so I might be wrong but a few tests could make the situation clearer.
Running inside the same machine I suppose you have client and server on the same network. Did u test sending/receiving multicast packets between client and server? Specifically, you can verify if inside and outside the docker container you notice differences. If you're able to send/receive multicast packets then the issue is not network related.
The following command should tell you if multicast is enabled for your interface and the specific address
netstat -g
For testing if you are able to receive multicast packets you can combine the commands
ping <multicast address> in one end
and tcpdump -i <network interface> -s 65534 host <multicast address> in the other location.

Could you clarify if I should expose other additional ports ?

It's not about the ports, it's about multicast packets. Basically, the outlet listens for stream resolution packets sent to a multicast group and replies with it's connection details to the sender. Docker doesn't receive these packets properly, so streams in a docker container can't be found.

But shouldn't this be solved by setting network=host for the Docker container? I tried that and was still not able to receive the stream inside of the container.

@cboulay asked me to share my experience with a possibly-related issue
In my setup I have a stream generated inside WSL2 and I want to record it with LabRecorder on the host windows.  As mentioned in https://github.com/labstreaminglayer/liblsl-Python/issues/44#issuecomment-873459749 I was able to achieve this by specifying the IP address of the WSL instance (hostname -I from inside WSL) as a KnownPeer.
The other requirement was to allow LabRecorder through the firewall - both on private and public networks. This was done for the application rather than for any ports. I'm not using Docker at all but hope it helps anyway.

Hello! I have a similar problem. I'm exporting the data via LSL on my local computer and I'm trying to consume it in a script that is inside a Docker container. I already set network_mode: host and privileged: true, but it didn't work. I ran the script outside of Docker and the data was found without any problems. Has anyone ever experienced this? I'm sending some prints to illustrate what's going on:


Add missing tags for classes

I add missing tags for certain classes. Some bugs are fixed during the work such as incorrect hierarchy.
Progress

[x] Setpoint
[x] Sensor
[x] Status
[x] Parameter
[x] Command
[x] Equipment
Substance
Quantity
[x] Add Point to all point classes

I'd skip for substance/quantity in this PR if it's fine.
Issues

It is hard to define Lighting because it shares the same tags with Lighting_System. We need to address this in a separate PR.

I'm ok with merging this now and then picking up the issue of System in #100 after you fix the build. I can also maybe put together a PR today that demonstrates the System hierarchy I'm imagining. How does that sound?

@gtfierro Hi Gabe, I have a draft note to post at #100 but I'd be happy to see another proposal.
I am merging this one and let's continue the other discussions separately. Thanks for your review.


Exception during execution

Hello!
Congratulations on your code, it is helping me a lot!
I'm trying to connect the kafka and the data-stream, but it has not worked.
The zookeeper and Kafka are ok, I have a topic, consumer and producer.
Always get this error displayed below.
Can you help me please?
root@vinicius-vm-3:/home/vinicius/json-data-generator/files# java -jar json-data-generator-1.2.2-SNAPSHOT.jar producer.json 2016-10-06 15:27:01,636 INFO n.a.d.j.g.JsonDataGenerator [main] Overriding Simulation Config file from command line to use [ producer.json ] 2016-10-06 15:27:01,643 DEBUG n.a.d.j.g.JsonDataGenerator [main] Creating Simulation Runner using Simulation Config [ producer.json ] 2016-10-06 15:27:01,965 INFO n.a.d.j.g.JsonDataGenerator [main] Adding Kafka Producer with properties: {type=kafka, broker.server=<IP_ADDRESS>, broker.port=9092, topic=topico-json-data, sync=false} SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. Exception in thread "main" java.lang.NullPointerException     at net.acesinc.data.json.generator.log.KafkaLogger.<init>(KafkaLogger.java:49)     at net.acesinc.data.json.generator.JsonDataGenerator.<init>(JsonDataGenerator.java:51)     at net.acesinc.data.json.generator.JsonDataGenerator.main(JsonDataGenerator.java:107) root@vinicius-vm-3:/home/vinicius/json-data-generator/files#
Thanks
Sorry my english

Sorry for the delay in responding, I missed this issue!  It looks like you don't have the flatten property set in your config.  Can you set that to false (I assume since you don't already have it) and see if that fixes the issue?  I'll add a check to see if that's not set and default it to false in the future.

I just commited a check to stop that NPE you were getting.  so either try to pull a new baseline, or set flatten to false.

Closing based on lack of activity. If there is still an issue, please let me know.


About Add Atlas Service

Hi, Because OpenMetadata doesn't support Hive lineage，So I try atlas service，But I can't see hive lineage,
my OpenMetadata version is 0.13.2

so I try cli

info Cannot find service for hivedemo - type DatabaseService

Hey @bigdata-spec , have you tried passing value for authProvider.

Hi @bigdata-spec could you please check?

Hi @bigdata-spec could you please check?

@pmbrull @NiharDoshi99  Thank you for your help.
I'm sorry, but we won't go into that for now


Create method to style iframe

I needed an implementation to add a custom attribute in iFrame, so I created this functionality

Coverage decreased (-0.4%) to 93.039% when pulling 6c1cb3202b1ae18681e1225581b0d73ee041523f on omarkdev:dev-style into bd8e617713bda53ac0e9541296c597f18171d92d on davidjbradshaw:dev.

I'm afraid I think this creates a security issue, the parent page should not be allow to modify the contents of the iFrame

@davidjbradshaw But the idea is not to control the content but the style, just as you can control the position, right? The difference is the possibility of more options


[FEATURE] Ability to record the status of mitigations

Describe the feature
I would like to be able to capture the status of any mitigations that are documented within threat composer
Use Case
Mitigations are the "What are we going to do about it?" part of threat modelling. Whilst threat composer allows you to define mitigations, it does leave you with a fair amount of ambiguity regarding the actual status of the mitigations. If a mitigation is captured against a threat, the tool will indicate that the threat has been mitigated. But it fails to capture the fact that the mitigation may not actually have been implemented. This leads to a false sense of security.
Proposed Solution
Add a new "Status" field against each mitigation with the following values:

Backlog
In Progress
Implemented

Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

Hi @nguforw, Thanks for raising the feature request. We have added it into our backlog.

The following is a combined proposal for both the ask for Mitigation status (#61) and Threat status (#126) given the interplay between them.

Ask: @nguforw for your feedback (and anyone else reading this) on if the below proposal would address your use case.

Broad design philosophy and decisions
We propose the tool will:

Focus on capturing outcome states for threats (risks) and mitigations (actions). In our experience, the combination of interim states, their associated business logic and risk management making process is highly customer specific.
Have static system defined statuses to ensure portability of exports (.tc.json) between deployments, and to maximise the usefulness of any associated 'Insight dashboard' widgets that would be created.
Allow for a degree of organisational customisation of the status, support change of the status "title" and "description" shown in the UI. Note this is applicable only for self-hosted and deployed environments.
Have human readable (english only) values for the static system defined statuses that are human readable (english only) - example: threatIdentified, such that it  useful for diffs/PRs for those that use version control methods (which we encourage)
Not track (or of keep an audit log of) status changes. Given the client-side nature of the tool, we do not see this tool as a viable alternative for a workflow tracking or ITSM tool. Additionally, we need to be frugal with our data storage requirements within browser storage, and ensure .tc.json diffs do not become "noisy".

Threat status
Mental model

These are risks (not tasks)
We capture outcomes (not the process of getting to the outcome, which would require us to have knowledge of the consuming customers processes for risk acceptance, tolerance, escalations etc).
There is always an amount of residual risk acceptance (unless one avoids the risk) - hence we will not include a seperate status for "Risk Accept" it will form part of "Resolved"
We consider "Resolved" and "NotUseful" as both being outcome state - so both will include the term "Resolved" in their system defined code threatResolved and threatResolvedNotUseful respectively.

Proposed statuses

Status in .tc.json export (constant)
UI Label (can be changed in build)
UI Description (can be changed in build)
Comments

threatIdentified
"Indentified" (default) - Other possible values you may want in your build could include: "Open", "Active" etc
"Potential threat has been identified"
All newly added threats get this status

threatResolved
"Resolved" (default) - Other possible values you may want in your build include: "Mitigated", "Complete" etc
"All agreed risk response actions (mitigation, transfer, avoidance, risk acceptance) have been completed aligned to our risk tolerance"
As noted above there is always amount of residual risk acceptance (unless one avoids the risk) - hence we will not include a seperate status for "Risk Accept" it will form part of "Resolved"

threatResolvedNotUseful
"Not Useful" (default) - Other possible values you may want in your build could include: "False positive" etc
"This threat is invalid / not applicable to our use system"
We consider "Resolved" and "NotUseful" as both being outcome state - so both will include the term "Resolved" in their system defined code threatResolved and threatResolvedNotUseful respectively.

UI placement

Select within "Threat List" under "Metadata"
Select within "Threat Editor" under "Metadata"
Add "Threat status" column to Threat table (possible values to be the same as the labelsvalues - with the defaults being : Identified, Resolved, NotUseful)

Business logic

All new threats get the threatIdentified status
All imports of pre-feature .tc.json files do not have the status automatically set, and will have a runtime-only status of NotSet (see dashboard section for visibility)

Dashboard

Pie Chart - Threat status distribution (threatIndentified, threatResolved, threatNotUseful, NotSet)
Note: we did consider a dashboard widget that would aim to warn of threats marked threatResolved where at least one linked mitigation was not marked mitigationResolved - but given our proposed approach to not differentiate full risk acceptance of a threat versus a partial, this is not possible.

Mitigation status
Mental model

These are tasks (work to do)
We capture outcomes. It is assumed that the ITSM (IT Service Management) process is outside of this tool. However we do propose a broad "In-progress" status for those that choose to track course grained interim state within the tool.
We do not have the notion of "Partially Resolved" as we see that as" Resolved" where the mitigation has been completed to an agreed scope. Meaning if partial... that was agreed. We capture the outcome only.

We consider "Resolved" and "Abandoned" as both being outcome states - so both will include the term "Resolved" in their system defined code mitigationResolved and mitigationResolvedAbandoned respectively.

Proposed statuses

Status in .tc.json export (constant)
UI Label (can be changed in build)
UI Description (can be changed in build)
Comments

mitigationIdentified
"Indentified" (default) - Other possible values you may want in your build could include: "Idea", "Planned", "Backlog"
"Mitigation has been identified"
All newly added mitigations get this status

mitigationInProgress
“In-Progress" (default) - Other possible values you may want in your build include: "Doing"
"Mitigation is in-progress"

mitigationResolved
“Resolved" (default) - Other possible values you may want in your build could include: "Implemented", "Complete","Accepted" etc
“Mitigation has been completed to an agreed scoped”
We do not have the notion of "Partially Resolved" as we see that as" Resolved" where the mitigation has been completed to an agreed scope. Meaning if partial... that was agreed. We capture the outcome only.

mitigationResolvedAbandoned
"Abandoned" (default) - Other possible values you may want in your build could include: "Won't do" etc
"Will not be implementing this mitigation"

UI placement

Select within "Mitigation list" under "Metadata"
Add "Mitigation status" column to Mitigation table (possible values to be the same as the labelsvalues - with the defaults being : Identified, In-Progress, Resolved, Abandoned)

Business logic

All new mitigations get the mitigationIdentified status
All imports of pre-feature .tc.json files do not have the status automatically set, and will have a runtime-only status of NotSet (see dashboard section for visibility)

Dashboard

Digit - Mitigation Progress (e.g. 5/10 complete) - ((mitigationResolved + mitigationResolvedAbandoned) / total (inc NoSet))
Pie Chart - Mitigation status distribution (mitigationIdentified, mitigationInProgress,mitigationResolved, mitigationResolvedAbandoned, including NotSet)


Fix: Adding missing wrappers for uavvcan/node/port.

This fixes #110.

Codecov Report

Merging #115 (41c2592) into master (bcfda22) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   85.64%   85.64%
=======================================
  Files          17       17
  Lines         641      641
=======================================
  Hits          549      549
  Misses         92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcfda22...41c2592. Read the comment docs.


Low rate of sending to RabbitMQ

Has anyone used Beaver with RabbitMQ before?  I'm encountering only 300+ messages per second with RabbitMQ default config settings running only on one machine.  I never had an issue with Redis.  Redis was 3.5K messages per second.

As mentioned by zhenghao1, the answer is in the connection details.
Within rabbitmq_transport.py (https://github.com/josegonzalez/python-beaver/blob/master/beaver/transports/rabbitmq_transport.py)
on line 49...
"pika.adapters.BlockingConnection(parameters)"
to something like this
"pika.SelectConnection(parameters=parameters,
on_open_callback=on_open)"
Once I'm back at the office I will mess around and see if I can get it to work

@tspicer did you manage to dig any further into this?


PRs don't get reviewed :-)

Please have a look... :-)
Thank you!

Sorry of the delay, I've commented now :)


Fix CWE-78, Command built from user-controlled sources

Checking the command and args before running a native application

Signed-off-by: Taewan Kim<EMAIL_ADDRESS>Description
Fix CWE-78, Command built from user-controlled sources
Fixes #298
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Run TC
$ go test -v ./internal/controller/servicemgr/executor/nativeexecutor

Test Configuration:

Firmware version: Ubuntu 20.04
Hardware: x86-64
Edge Orchestration Release: Coconut

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Close this PR since this code is not enough to resolve the issue.


Add “deno.json” to configure support for JSR.

Just following directions at https://jsr.io/@netflix/x-element/publish.

Note that this got added as part of a separate effort so closing this down as a duplicate. For completeness — note that this does publish to JSR as part of our release pipeline via GitHub Actions 👌


Update crown assets and govuk-frontend to v4.8

adds a shim compiler to fix broken sass complication with sourcemaps introduced in govuk-frontend v4.8
This now brings new crown assets in (favicon, etc) but as these pages use govuk-frontend v3 manual fixes are required to address styling tweaks

We will close this for now.  We plan on updating this later to govuk-frontend v5 in the coming weeks.
Thanks for your help Jani.


trySuccess vs success

Within fileCreated (page 122), why use trySuccess instead of success (assumed -Ywarn-value-discard is off)?
Just before this example, you stated:

As long as we do not use the trySuccess, tryFailure, and tryComplete methods, and none of the success, failure, and complete methods ever throws an exception, we can use promises and retain determinism in our programs.

Can you elaborate why, e.g., trySuccess does not retain determinism?
Deterministic means that, given that no exception is thrown in the program, the result of the program will always be the same, regardless of the execution schedule of the parallel program.
So why does trySuccess violate here? Or, how does trySuccess depend on the execution schedule?

In this particular example, you need to have some determinism - nondeterminism cannot be avoided. The FileAlterationListener represents an external event source, which may trigger zero, one or more events. Since the Promise/Future can hold at most a single event, only the first (that is, the quickest) invocation of onFileCreate can complete the promise object p.
If we use success to complete the promise, then if the external event source emits to file creation events, the onFileCreate will be called twice, and one of the success calls will throw an exception.
With our definition of determinism, this is deterministic, but not particularly useful - if we ignore the exception, then the rest of the program that depends on the value in the promise becomes non-deterministic anyway.
If we use trySuccess, one of the calls will similarly not succeed, but an exception will not be thrown. In cases like this, where you cannot avoid determinism, it's sometimes better to just use trySuccess.

In this particular example, you need to have some determinism - nondeterminism cannot be avoided. The FileAlterationListener represents an external event source, which may trigger zero, one or more events. Since the Promise/Future can hold at most a single event, only the first (that is, the quickest) invocation of onFileCreate can complete the promise object p.

Good explanation.

If we use success to complete the promise, then if the external event source emits two file creation events, the onFileCreate will be called twice, and one of the success calls will throw an exception. With our definition of determinism, this is deterministic, but not particularly useful - if we ignore the exception, then the rest of the program that depends on the value in the promise becomes non-deterministic anyway.

If we use trySuccess, one of the calls will similarly not succeed, but an exception will not be thrown. In cases like this, where you cannot avoid determinism, it's sometimes better to just use trySuccess.

"where you cannot avoid nondeterminism", nor?

Yes, typo - "where you cannot avoid nondeterminism".


Create a development and production settings file

Things that need to happen:

automatically switch off debug in production / on debug in development.

Completed. Now have two setting files. settings and settings_local.
settings_local is run via python manage.py runserver --settings=project_tracker.settings_local

@yulqen in relation to the above should I set up a alias for the python manage.py runserver --settings=project_tracker.settings_local command or is there another/better way of doing this? I think you mentioned to me another method of running common commands via a particular file but can't remember the name.

Make. We'll discuss later.

Cool. See you at 15.15


Fix c++17 support

Describe the bug
std::random_shuffle has been removed in c++17 and should be replaced with std::shuffle:
https://github.com/LLNL/Umpire/blob/develop/benchmarks/file_resource_benchmarks.cpp#L66
https://github.com/LLNL/Umpire/blob/develop/tests/unit/resource/shared_memory_resource_tests.cpp#L214

Hi @adayton1, I went ahead and implemented a fix for this in the PR mentioned above.  I am not sure if you had a test for this that you were trying to use, but feel free to try this out.


redundancy in indoor3d_sem_seg_hdf5_data_test

Hi @AnTao97, thanks for your sharing!
For the semantic segmentation parts, maybe indoor3d_sem_seg_hdf5_data_test is a bit redundant, right?
Since
https://github.com/AnTao97/dgcnn.pytorch/blob/c2da60252eb84c634650f7ab2535fc1fcab67451/data.py#L156-L162

The main difference between training and testing set is that each block in training set overlaps with its neighbor blocks in 0.5m, i.e. all blocks in a given room are cropped with stride=0.5m, while all blocks in testing set are not overlap with others.
The data in https://shapenet.cs.stanford.edu/media/indoor3d_sem_seg_hdf5_data.zip is only for training set, not testing set. You are required to generate testing data data/indoor3d_sem_seg_hdf5_data_test/ from original S3DIS dataset Stanford3dDataset_v1.2_Aligned_Version.zip. This data generation will be done when you run training script main_semseg.py the first time with Stanford3dDataset_v1.2_Aligned_Version.zip downloaded.
See #1 for more details.

Oh, thanks for clarification, w.r.t #1 , actually I also think that the original implementation does not test on whole point set :)


Develop viz "showcase" mode

@alicefeng creating a new issue for this so we can keep track of what needs to be done to support this.
I have a PR lodged (https://github.com/Data4Democracy/crash-model/pull/184) that creates the new file that you've been working with, as part of the pipeline process. As it stands it gets created in /data/[city]/processed/preds_viz.geojson, is there anyway to reconfigure the webserver to be able to access this?

Domain hosting is live - https://demo.insightlane.org
@j-t-t @alicefeng @shreyapandit @bpben


the unicorn_env default typo

@lazybios It's not a typo, see http://unicorn.bogomips.org/unicorn_1.html#rack-environment


Confirm whether there is any changes to HTTPS  on GIthub

Confirm whether there is any changes to HTTPS  on GIthub forcing people to use keys

I don't think so?

Ah now I remember: this is on the page after an empty project has been created. I have seen that, too. We need to double-check this.


Federated Learning disconnection bug

What happened:
When using the Federade Learning API, if the server and client do not communicate for a while , then the conneciton between server and client will be disconnect.
What you expected to happen:
I hope the conection between server and client will last for a longer time or implement a heartbeat function.
Error message:

Does the development of PR#124 finally solve this bug?


Insert actions/cache v2.0

The actions/cache v2.0 has been released:

drop the actions/cache subrepo and use the npm package publicly available;
verify whether leveraging multiple paths is useful;

https://github.com/lukka/run-vcpkg/pull/21


Axes class no longer sets x_min, x_max, y_min, y_max values to self.x_min, self.x_max, self.y_min and self.y_max respectively.

Description of bug / unexpected behavior

When Axes class instance is created with kwargs -> x_min, x_max, y_min, y_max, they are not shown in the generated Axes animation.
This issue arose after migration from dictionaries.
P.S. I have also started getting a warning "Creating a dummy animation" which if I am right is because animation receives mobject as None.
Expected behavior

Previoulsy, it worked just fine. Thus, setting these kwargs to self.x_min, self.x_max, self.y_min and self.y_max was expected.
How to reproduce the issue

Code for reproducing the problem
from manim import *

class AxesExample(Scene):
    def construct(self):
        axes1 = Axes(
            x_min = 0,
            x_max = 5,
            y_min = -1,
            y_max = 1,
            axis_config = {
                "include_numbers": True,
                "include_tip" : False,
                "decimal_number_config" : {"num_decimal_places": 1, "color": LIGHT_GREY}
            },
            x_axis_config={
                # "x_min" : 0,
                # "x_max":5,
                "numbers_to_show": np.arange(1,6)
                },
            y_axis_config={
                # "y_min" : 0,
                # "y_max":5,
                "numbers_to_show": np.arange(-1,2)
                }
            )
        # axes1.stretch_to_fit_width(4)
        # axes1.stretch_to_fit_height(3)
        self.play(ShowCreation(axes1))
        self.wait()
        graph = axes1.get_graph(lambda x:np.sinc(x), x_min = 0, x_max = 5, color = RED)
        self.play(ShowCreation(graph))
        self.wait()

Additional media files

Images/GIFs

Logs
Terminal output

PASTE HERE OR PROVIDE LINK TO https://pastebin.com/ OR SIMILAR

System specifications
System Details

OS (with version, e.g Windows 10 v2004 or macOS 10.15 (Catalina)):
RAM:
Python version (python/py/python3 --version):
Installed modules (provide output from pip list):

PASTE HERE

LaTeX details

LaTeX distribution (e.g. TeX Live 2020):
Installed LaTeX packages:

FFMPEG
Output of ffmpeg -version:
PASTE HERE

Additional comments

It seems to be that the CoordinateSystem class is not able to find the "x_min", "x_max", "y_min" and "y_max" attributes in self thereby setting the self.x_min, self.x_max, self.y_min and self.y_max to the dimensions of the frame.
https://github.com/ManimCommunity/manim/blob/62f0147f8135e68323fd2a2a2f8258772faa8c9f/manim/mobject/coordinate_systems.py#L132-L148
https://github.com/ManimCommunity/manim/blob/62f0147f8135e68323fd2a2a2f8258772faa8c9f/manim/mobject/coordinate_systems.py#L26-L40

A quick print of the new_config dictionary showed that these values are indeed not set to the arguments passed.
https://github.com/ManimCommunity/manim/blob/62f0147f8135e68323fd2a2a2f8258772faa8c9f/manim/mobject/coordinate_systems.py#L157-L163

I see the issue.
This indeed looks like it was part of the digest_configs mess.
Thus the __init__ function of CoordinateSystem doesn't accept things like x_min as keyword arguments, but instead looks if the attributes self.x_min exists. With the digest_config system as it was, the keyword argument x_min, no matter where it was given, would lead to the attribute being set. No we have to pass the arguments explicitly.
To fix this issue:
We should add *kwargs to line 153 of coordinate_systems.py (the call to the CoordinateSystem.__init__) and change the __init__ to accept these keyword arguments.
To avoid breaking anything else with this fix:
Further we have to change ThreeDAxes (line 231) so that the relevant arguments are passed "upstairs", and we should check that no other class in this file also sets x_min for itself without passing the keyword to the parent.
To clean up further:
We should probably refactor the create_axis function too - there is too much merging of dicts going on for my taste. Perhaps a more thorough redesign of how to configure axes is also called for. However that can be a subsequent PR.

I am already working on a solution that makes the whole axes class a little better. My solution involves creating these attributes within the axes class and then assigning the keyword arguments passed directly to the Axes class or from the x_axis_config and y_axis_config dicts. While working I noticed a number of issues with Axes Class and now in the process of fixing them. I am almost done. I will PR once ready.

cool. awesome.
thanks for working on this.
My feeling is that it is best to have one canonical place where the attributes are set. Thus I think I prefer to accept the x_min keyword in Axes and other classes, (or accepting an x_axis_config from which we can calculate x_min) but then passing that "upstairs" as a keyword argument and only there setting it as an object attribute. Rather than just checking if the attribute has been set somewhere else - as the code is doing now.
So CoordinateSytem would take an x_min=None and then check: if x_min is None: x_min = -config["frame_x_radius"] and then self.x_min = x_min.
The child classes would just pass x_min = x_min_value up to the parent.
All this will help us further untangle where which attributes are set and aid us in the general cleanup and refactoring that is planned to happen next.
but I am open to other solutions too. looking forward to you PR.

I agree. I will see what I can do with the suggestions you provided @cobordism.


move docker dir to new repo to run all services

images are pushed, can also push helm charts https://helm.sh/docs/topics/registries/#enabling-oci-support


about using scenario in distributed training settings.

hi, i recently using continuum for distributing training(i.e. ddp with pytorchlightning), and i found that it seems every process of ddp will all create a scenario, which will cause not only a resource shortage problem, but also a intterupt in dataloader.
So i was wondering if the continuum is tested in distributed environment?

Hey,
That's weird because I also DistributedDataParallel and Continuum and I haven't seen any interrupt in the data loader.
Although I've never used PytorchLightning. Could you provide a minimal example with that library that uses DDP and continuum?

Hey,
That's weird because I also DistributedDataParallel and Continuum and I haven't seen any interrupt in the data loader.
Although I've never used PytorchLightning. Could you provide a minimal example with that library that uses DDP and continuum?

well, after i posted this problem, i began to realize that i might not be particularly clear about how ddp works.
i mean i know that ddp will create a process in each gpu, where there will be a same code and a same model parameters. for me, i think that every part of the code, unless you specify that certain code only runs on rank_zero, will all run on each gpu.
since we know that using continuum, one needs to create a "scenario" first. thus, this action will run on each gpu and get multiple copies of scenarios(not sure if i am correct, correct me if i am wrong.). is it possible that something went wrong here?
by the way, could you give me a glance(certain part is ok for me) about the code you used in ddp with continuum? i am afraid i can't find a minimal example due to the environment issue and code implementation problem.

The code is super big and messy so hard to share. But I've really didn't not make any changes to how continuum is used for ddp.
Although, I'm currently working only on CIFAR100 and not a large dataset. But It shouldn't be a problem because usually for large datasets like ImageNet only metadata are loaded (and thus would be duplicated) in RAM. What dataset do you use?
Could you try maybe to create the dataset on only one gpu? Likewise:
import torch.distributed as dist

if dist.get_rank() == 0:
  ... create dataset & scenario

The code is super big and messy so hard to share. But I've really didn't not make any changes to how continuum is used for ddp.
Although, I'm currently working only on CIFAR100 and not a large dataset. But It shouldn't be a problem because usually for large datasets like ImageNet only metadata are loaded (and thus would be duplicated) in RAM. What dataset do you use?
Could you try maybe to create the dataset on only one gpu? Likewise:

import torch.distributed as dist

if dist.get_rank() == 0:

  ... create dataset & scenario

i use cifar100 as well. i will try your code, but i wonder, will there be any sync issue, since the process of creating dataset and scenario only exists on rank 0 device?

How much RAM do you have?
Anyway for class incremental + cifar, continuum computes really nothing and is just a wrapper over torchvision's CIFAR100.
Have you tried to use the torchvision's cifar100 with your ddp system? I think you'll sill have your problem.

i use cifar100 as well. i will try your code, but i wonder, will there be any sync issue, since the process of creating dataset and scenario only exists on rank 0 device?

Yeah you're probably right.

How much RAM do you have?
Anyway for class incremental + cifar, continuum computes really nothing and is just a wrapper over torchvision's CIFAR100.
Have you tried to use the torchvision's cifar100 with your ddp system? I think you'll sill have your problem.

i use cifar100 as well. i will try your code, but i wonder, will there be any sync issue, since the process of creating dataset and scenario only exists on rank 0 device?

Yeah you're probably right.

torchvision cifar100 works well for me. well, i think maybe i will just not use pytorch-lightning instead.

Can you give me access to your code? Or a minimal example so I can reproduce the error?

Can you give me access to your code? Or a minimal example so I can reproduce the error?

it might need some time, i will post the code ASAP.

no worry

I close this issue because of inactivity feel free to reopen it if needed.