Confirm Causal Pathways fully functional

Use branch https://github.com/Display-Lab/precision-feedback-pipeline/tree/Info_Restriction_Dev to verify that API response variability is not due to errors in the function of the causal pathway or the test data sets used.

See instructions on branch's readme to test restricted API locally

Posting proof of successful testing with LDT

LDT output from tests against a local instance of the restricted PFP API:
Last login: Tue Sep 12 15:47:56 on ttys004
MacBook-Pro ~ % cd code/Display-Lab
MacBook-Pro Display-Lab % cd Leakdown-Tester
MacBook-Pro Leakdown-Tester % source LDTvenv/bin/activate
(LDTvenv) @MacBook-Pro Leakdown-Tester % python3 LDT.py --cpVerify --CP social_approach

		Welcome to the Leakdown Tester, Version 1.1.1-beta!
 Reading one JSON file from 'Causal Pathway Test Suite'...
 Sending 1 total POST requests...
 Sending POST request(s) to API at 'http://<IP_ADDRESS>:8000/createprecisionfeedback/'...

 Testing input_message file for causal pathway 'SOCIAL APPROACH'
 Thread 1, Test 1, Request 1:	Response recieved in 1.099 seconds.
 CAUSAL PATHWAY VERIFICATION:	PASS
		Specified Pathway:	social approach
		Accepted Pathway:	social approach
 PFP returns acceptable candidates: ['Social Approach']

		Leakdown test complete.

(LDTvenv) @MacBook-Pro Leakdown-Tester % python3 LDT.py --cpVerify --CP social_better

		Welcome to the Leakdown Tester, Version 1.1.1-beta!
 Reading one JSON file from 'Causal Pathway Test Suite'...
 Sending 1 total POST requests...
 Sending POST request(s) to API at 'http://<IP_ADDRESS>:8000/createprecisionfeedback/'...

 Testing input_message file for causal pathway 'SOCIAL BETTER'
 Thread 1, Test 1, Request 1:	Response recieved in 2.349 seconds.
 CAUSAL PATHWAY VERIFICATION:	PASS
		Specified Pathway:	social better
		Accepted Pathway:	social better
 PFP returns acceptable candidates: ['Social better']

		Leakdown test complete.

(LDTvenv) @MacBook-Pro Leakdown-Tester % python3 LDT.py --cpVerify --CP social_gain

		Welcome to the Leakdown Tester, Version 1.1.1-beta!
 Reading one JSON file from 'Causal Pathway Test Suite'...
 Sending 1 total POST requests...
 Sending POST request(s) to API at 'http://<IP_ADDRESS>:8000/createprecisionfeedback/'...

 Testing input_message file for causal pathway 'SOCIAL GAIN'
 Thread 1, Test 1, Request 1:	Response recieved in 2.030 seconds.
 CAUSAL PATHWAY VERIFICATION:	PASS
		Specified Pathway:	social gain
		Accepted Pathway:	social gain
 PFP returns acceptable candidates: ['Social Gain']

		Leakdown test complete.

(LDTvenv) @MacBook-Pro Leakdown-Tester % python3 LDT.py --cpVerify --CP social_better

		Welcome to the Leakdown Tester, Version 1.1.1-beta!
 Reading one JSON file from 'Causal Pathway Test Suite'...
 Sending 1 total POST requests...
 Sending POST request(s) to API at 'http://<IP_ADDRESS>:8000/createprecisionfeedback/'...

 Testing input_message file for causal pathway 'SOCIAL BETTER'
 Bad response from target API:
			Status Code:	500
Headers: {'date': 'Tue, 12 Sep 2023 19:57:21 GMT', 'server': 'uvicorn', 'content-length': '21', 'content-type': 'text/plain; charset=utf-8'}
'Internal Server Error'

		Leakdown test complete.

(LDTvenv) @MacBook-Pro Leakdown-Tester % python3 LDT.py --cpVerify --CP social_gain

		Welcome to the Leakdown Tester, Version 1.1.1-beta!
 Reading one JSON file from 'Causal Pathway Test Suite'...
 Sending 1 total POST requests...
 Sending POST request(s) to API at 'http://<IP_ADDRESS>:8000/createprecisionfeedback/'...

 Testing input_message file for causal pathway 'SOCIAL GAIN'
 Thread 1, Test 1, Request 1:	Response recieved in 1.246 seconds.
 CAUSAL PATHWAY VERIFICATION:	PASS
		Specified Pathway:	social gain
		Accepted Pathway:	social gain
 PFP returns acceptable candidates: ['Social Gain']

		Leakdown test complete.

(LDTvenv) @MacBook-Pro Leakdown-Tester % python3 LDT.py --cpVerify --CP social_loss

		Welcome to the Leakdown Tester, Version 1.1.1-beta!
 Reading one JSON file from 'Causal Pathway Test Suite'...
 Sending 1 total POST requests...
 Sending POST request(s) to API at 'http://<IP_ADDRESS>:8000/createprecisionfeedback/'...

 Testing input_message file for causal pathway 'SOCIAL LOSS'
 Thread 1, Test 1, Request 1:	Response recieved in 1.990 seconds.
 CAUSAL PATHWAY VERIFICATION:	PASS
		Specified Pathway:	social loss
		Accepted Pathway:	social loss
 PFP returns acceptable candidates: ['social loss']

		Leakdown test complete.

(LDTvenv) @MacBook-Pro Leakdown-Tester % python3 LDT.py --cpVerify --CP social_worse

		Welcome to the Leakdown Tester, Version 1.1.1-beta!
 Reading one JSON file from 'Causal Pathway Test Suite'...
 Sending 1 total POST requests...
 Sending POST request(s) to API at 'http://<IP_ADDRESS>:8000/createprecisionfeedback/'...

 Testing input_message file for causal pathway 'SOCIAL WORSE'
 Thread 1, Test 1, Request 1:	Response recieved in 1.968 seconds.
 CAUSAL PATHWAY VERIFICATION:	PASS
		Specified Pathway:	social worse
		Accepted Pathway:	social worse
 PFP returns acceptable candidates: ['Social Worse']

		Leakdown test complete.

(LDTvenv) @MacBook-Pro Leakdown-Tester % python3 LDT.py --cpVerify --CP worsening

		Welcome to the Leakdown Tester, Version 1.1.1-beta!
 Reading one JSON file from 'Causal Pathway Test Suite'...
 Sending 1 total POST requests...
 Sending POST request(s) to API at 'http://<IP_ADDRESS>:8000/createprecisionfeedback/'...

 Testing input_message file for causal pathway 'WORSENING'
 Thread 1, Test 1, Request 1:	Response recieved in 2.106 seconds.
 CAUSAL PATHWAY VERIFICATION:	PASS
		Specified Pathway:	worsening
		Accepted Pathway:	worsening
 PFP returns acceptable candidates: ['Worsening']

		Leakdown test complete.

As seen above, when causal pathways.json files are restricted, the data verifies correctly, the acceptable_by choices are as expected, the --cpVerify function shows a 'PASS', everything works as expected.


Add netlify api command

Add a new command that proxies to calls to underlying js-client based on the OpenAPI spec.
Example:
netlify api listSiteForms
# calls https://open-api.netlify.com/#/default/listSiteForms and returns json

netlify api --help
# list out available lower lvl CLI calls

netlify api listSiteFiles
# run https://open-api.netlify.com/#/default/listSiteFiles

This will give people an easy way to make netlify API calls in their CI processes.
I have a use case where I need to query the existing deploys in my CI process and right now I need to wire together my own custom scripts to achieve this. Where as with a simple CLI command I could get the data I need
netlify api listSiteDeploys | jq length
# returns number of deploys 2

Considerations
Deletion calls should require a --confirm flag to avoid accidentally destroying resources.
About
This is modeled off the AWS cli where you can call out directly to lower level commands. https://docs.aws.amazon.com/cli/latest/reference/acm/index.html

This is also an escape hatch for commands that don't have a top level CLI command (and likely never will)

this is cool :+1:

Sounds good, could be dangerous but fun.


Add an option to filter Copy-Only backups from Get-DbaLastBackup

Summary of new feature
Add an option to filter on Copy-Only backups in the Get-DbaLastBackup function.
Proposed technical details (if applicable)
Add a switch/parameter of some sort that will allow including all backups, copy-only backups, or non-copy-only backups - especially for the "Full" backup history.  This should allow for a way to see if the "last backup" chain seems to be okay without needing to check/verify all backups.
Latest version of dbatools as of writing
1.0.119

there's Get-DbaDbBackupHistory for that. Get-DbaLastBackup does not verify any "robustness" of the chain.
This function mirrors what SMO does.
If you need precision, use Get-DbaDbBackupHistory

That's not quite the same thing. Get-DbaDbBackupHistory gets everything. I don't really want that in most cases, but a high level overview of "My last full seems to match my last diff, seems to match my last log".  If I have some copy-only job running between the actual full/diff, it doesn't give me a good overview of whether that backup chain looks right or not.  I also may not know where that full backup was stored if it was done through some 3rd party backup tool.

Get-DbaDbBackupHistory gets everything

not really, it gets what you want, including being able to filter out copyonly, virtualdevices, etc.
What Get-DbaDbLastBackup does is not filter out anything, as SMO does, to make sure SOME backup has been taken.
If you do copy-only and you don't put them away and you wanna check your history of file-based backup without copyonly, just use
Get-DbaDbBackupHistory -Last -DeviceType Disk
Quote from the code of Get-DbaDbLastBackup :
SMO's (and this) report the last backup of this type irregardless of the chain

Just noting that all Get-DbaLastBackup does is call Get-DbaDbBackupHistory ...so adding in additional properties to note it is a copy-only backup can be done. We simply include -IncludeCopyOnly on every call.
The raw object we return includes is_copy_only so adding a property to the output object is reasonable; then the user has a property to filter with Where-Object.


antfs-cli: use python3Packages

Motivation for this change
https://github.com/NixOS/nixpkgs/issues/18185
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Success on aarch64-linux (full log)
Attempted: antfs-cli
Partial log (click to expand)
test_config_dir (tests.test_utilities.BasicUtilityTest)
Test if operating system-appropriate config directory is located ... ok
test_data_dir (tests.test_utilities.BasicUtilityTest)
Test if operating system-appropriate data directory is located ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.001s

OK
/nix/store/sddwglsv8wrywf10v5nbhrkr8vwkg7gq-antfs-cli-unstable-2017-02-11

Success on x86_64-linux (full log)
Attempted: antfs-cli
Partial log (click to expand)
test_config_dir (tests.test_utilities.BasicUtilityTest)
Test if operating system-appropriate config directory is located ... ok
test_data_dir (tests.test_utilities.BasicUtilityTest)
Test if operating system-appropriate data directory is located ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.001s

OK
/nix/store/l2xdr248nnwjsiw3sj7n82h8y15njx38-antfs-cli-unstable-2017-02-11


Support for delayed annotations

TL;DR
Support delayed annotations through from __future__ import annotations in python 3.8/3.9 task and workflow definitions.
Type

[X] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[X] Code completed
[ ] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
inspect.signature behavior changes in an awkward way in python 3.8/3.9 when applying from __future__ import annotations, where it returns the string values of the delayed annotations for type hints rather than the values themselves. This is fixed in 3.10. The recommended solution is to use typing.get_type_hints() for all annotations, and then join in inspect.signature for default values where necessary.
I modified transform_signature_to_interface to transform_function_to_interface, which was sensible anyway because 100% of the usages of this function called inspect.signature on a function before passing it into transform. transform_function_to_interface then owns the logic of correctly resolving type hints and default values through typing.get_type_hints and inspect.signature.
Tracking Issue
https://github.com/flyteorg/flyte/issues/1028
Follow-up issue
NA

Thanks for the fix @bethebunny!!  Let me play around with this later today/tonight.  This is super useful, been on our plate forever. 🙏

Tests should pass now :)

@bethebunny , presumably you're force-pushing because of the DCO warnings, but can you instead follow the instructions to fix those warnings instead?

Ah yes, I only got as far in the doc as option 1 and assumed that was happy path for contributors :) I'll re-read and stop squashing commits for future changes.

as is, this PR has a breaking change - let's toy around with this a bit more as a beta release before committing to it (perhaps merge it, perhaps not)
See the deleted unit test for an example of the break, basically json dataclasses with improper schemas were previously accepted as a schemaless generic and now will not be.
the current thinking is to request users to remove the dataclass_json in this case, and patch the typeengine code so that the Flyte pickle hander picks them up.  This still is a breaking change and since users will have to change code, but at least it's a workaround.
Another alternative is to continue to swallow the error.

Hmm - never mind.  I think too many things rely on this behavior.  Let me see about continuing to hide the error.


Remove Action.Http from v1, to revisit later

Action.Http is used to execute an HTTP action against an arbitrary 3rd party service. There are some inherent security issues with this, and thur far all consumers have decided to remove support for it.
We will gather the feedback and revisit adding it back in a future release.

If we remove Action.Http, then Action.Submit needs to be removed as well. Both are host specific at this point. What should remain in the schema are actions that are universally supported (e.g. Action.OpenUrl and Action.ShowCard.) All others should be done via extensibility.

Does Outlook use Action.Http or register custom actions? If they use Action.Http then that's my misunderstanding. I was under the impression every single host said they wouldn't support it


[Bug] Local Storage issue

At the moment when you click more under the lathe code to be able to save and load to local storage it will show anything in local storage in the list. This could include local storage from plugins and extensions etc.
To fix this I think maybe the names in local storage should be prefixed with latheCode_{name of save}
And when loading the page iterate only over those that has latheCode_ prefix.

Well, some folks already have stuff saved without the prefix. We can filter and only show multi-line values.

Could we maybe iterate over existing values to determine if they are lathe code, then “fix” the ones that are

Yeah, but then we'd have to keep that migration code around for some unknown period of time. Hope the issue is sufficiently mitigated :) Thanks!


Any plans for resolving JS function parameter types from .d.ts?

If somebody for various reasons needs to keep the code itself as plain ES6 javascript (in .JS files), but is using .d.ts files for VSCode assistance (which in indeed incredible!), would it be possible to derive the types of the function parameters not from the JSDoc @ param but from the .d.ts itself?
Right now, any other file, importing a module, can benefit from the type information in .d.ts - but the module itself cannot.
Is this something being cooked in the vscode secret labs, just not finished yet? Is there a roadmap item  for this?
Thanks vscoders for the awesome tool!

Thanks. I verified this issue and have opened https://github.com/Microsoft/TypeScript/issues/14342 to track this on the TypeScript side. I was not able to find a workaround for this, but perhaps the TypeScript folks will be able to suggest one.
Closing as upstream


doc/release-note-3.2: storage changelog

Summary on storage updates for 3.2 release.
Signed-off-by: Andrzej Puzdrowski<EMAIL_ADDRESS>

@mmahadevan108 I removed the deprecation report - it has own PR along with deprecation of these macros.

@nvlsianpu can you please help address the comment.

Hey, pushed it for you @nvlsianpu, just address Stephanos typo, hope you don't mind, trying to wrap on the release docs. :-)


ORC-814: Build and test Java module on Apple Silicon

What changes were proposed in this pull request?
This PR aims to build and test Java module on Apple Silicon.
Why are the changes needed?
Currently, the protocol buffer download fails on Apple Silicon.
How was this patch tested?
Manual
mvn package -Papplesilicon

BTW, @williamhyun . FYI, the latest protocol buffer seems to add M1 support officially. Upgrading Protoc version is a separate issue though. :)

https://github.com/protocolbuffers/protobuf/releases/tag/v3.17.3

Thank you, @williamhyun . I tested and backported this to branch-1.6.


supresses parser gem errors

see https://github.com/whitequark/parser/issues/283
if rubocop works around this bug then we can revert this patch.

yolo


symlinks in project/.ddev/custom_certs - maybe worth resolving symlink and copying source file(s)?

Is your feature request related to a problem? Please describe.

I attempted to symlink the crt and key files from /etc/letsencypt/live/domain.com/ into custom_certs but it doesn't seem to be properly picked up. In fact, the self-signed certificate is utilized instead.
I'm wondering if it's worth implementing resolving the symlinks and copying the source files instead so that when you start the container the next time, the copied certificate and key are always the latest - LE refreshes every 3 months (🤔 ?).
Describe the solution you'd like

I would like ddev to resolve the symlink and copy the actual source file into the router container.
Describe alternatives you've considered

I'm currently using a bash script to supplement the setup.
# this happens in project/.ddev/custom_certs
cp /etc/letsencrypt/archive/domain.name/$(basename $(readlink /etc/letsencrypt/live/domain.name/fullchain.pem)) project.domain.name.crt
cp /etc/letsencrypt/archive/domain.name/$(basename $(readlink /etc/letsencrypt/live/domain.name/privkey.pem)) project.domain.name.key

Additional context

I don't know anything about go unfortunately, but did look at the code, and it looks like the copy command resolves down to an external library otiai10/copy/copy.go:38 which implements a switchboard to properly issue the OS specific copy command for the resource type in question. It seems to handle symlinks but not sure if it resolves it first or it just does the equivalent of cp -P, meaning just copies the symlink while maintaining its target.
Thank you!

I'm glad you're using the custom certs, and would love to know more how and why you're using them.
But did you know that ddev has direct native Let's Encrypt support?  https://ddev.readthedocs.io/en/latest/users/alternate-uses/#casual-project-webhosting-on-the-internet-including-lets-encrypt

The code that copies in is at https://github.com/drud/ddev/blob/11f2eeec84f8de831d9ee5cb6b4df67ac41ff360/pkg/ddevapp/ddevapp.go#L975-L984
I'm sure it could resolve the symlink, and a PR would be welcome, but this is a very rarely used feature, and looking forward to hearing how and why you use it :)
Note that symlinks are questionable in environments like Windows.
Looks like dockerutil.CopyIntoVolume would need to check symlink and resolve it, not sure how good that would be for other usages.

Awesome stuff 👍 , I'll try to test it out, I guess any time is a good time to start fiddling with go. I know windows has some odd symlink stuff too but I doubt we'll have to support it since for now certbot is not a native windows utility.
I'm using custom certs because I already have a wildcard cert from LE, and I'm configuring ddev's project_tld to be the actual domain name. I'm playing around with a remote dev env complete with a hosted vscode, and with the help of the wildcard I don't have to worry about VPNs or running dnsmasq or anything of the sort. Not that the last couple options would not be good, they're both feasible options.
A second reason for which I chose wildcard vs native LE via ddev is the fact that I may bump into request limits with LE if each project gets its own cert.

I'm going to go ahead and close this for now, because it seems to have more to do with your scripting expectations than ddev's functionality. Happy to continue the conversation here or elsewhere though, and happy to reopen or help with a PR.


Support authentication to access private project

Hello everyone,
I hide my project using dot in front of the project name for example .private and I upload the files inside private folder.
Then I try to access it inside dashboard -> Index tab, then it asks me the to enter password and username.
Entering the alias/token that is generated from keygen with keygen /private m seems not work to access it.
Does reposilite support authentication to access private project?

You should be able to login into the dashboard, but you should not be able to see the content of private repository in file viewer. I've just checked the source and it is a bug. Thanks for reporting this.


toolbar need help to keep fixed while scrolling router components

Bug, feature request, or proposal:
What is the expected behavior?
What is the current behavior?
What are the steps to reproduce?
Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: http://plnkr.co/edit/o077B6uEiiIgkC0S06dd
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, browsers are affected?
Is there anything else we should know?

Either provide a proper description and/or a plunker with what you want to achieve. That issue template is there for a reason.

Looking for a solution where the main toolbar should be fixed while
scrolling data in components where the components are being called through
router
On Nov 28, 2016 11:16 PM, "Aleš"<EMAIL_ADDRESS>wrote:

Either provide a proper description and/or a plunker with what you want to
achieve. That issue template is there for a reason.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/angular/material2/issues/2007#issuecomment-263340829,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKF9fJfNkiSF4UicwFHORcyNe3jAbL4Mks5rCxNqgaJpZM4K9_gr
.

Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.


[mtv] MTV site changed

Checklist

[X] I'm reporting a broken site support
[X] I've verified that I'm running youtube-dl version 2020.09.20
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones

Verbose log
c:\support\youtube-dl.exe https://www.mtv.com/episodes/4iqsts/revenge-prank-the-prank-that-hits-the-jackpot-season-1-ep-16 --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://www.mtv.com/episodes/4iqsts/revenge-prank-the-prank-that-hits-the-jackpot-season-1-ep-16', '--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2020.09.20
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg N-92986-gaceb9131c1, ffprobe N-92986-gaceb9131c1, rtmpdump 2.4
[debug] Proxy map: {}
[mtv] revenge-prank-the-prank-that-hits-the-jackpot-season-1-ep-16: Downloading webpage
Traceback (most recent call last):
  File "__main__.py", line 19, in <module>
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpksi3o1r1\build\youtube_dl\__init__.py", line 474, in main
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpksi3o1r1\build\youtube_dl\__init__.py", line 464, in _real_main
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpksi3o1r1\build\youtube_dl\YoutubeDL.py", line 2019, in download
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpksi3o1r1\build\youtube_dl\YoutubeDL.py", line 797, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpksi3o1r1\build\youtube_dl\extractor\common.py", line 532, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpksi3o1r1\build\youtube_dl\extractor\mtv.py", line 287, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpksi3o1r1\build\youtube_dl\extractor\mtv.py", line 213, in _get_videos_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpksi3o1r1\build\youtube_dl\extractor\mtv.py", line 39, in _id_from_uri
AttributeError: 'NoneType' object has no attribute 'split'

Description
MTV changed their website recently. URLs are different and so is streaming format.

Can confirm is not working on windows.

have you tried logging in with your TV provider and then
try downloading the episode ??

I have, logging in still doesn't work.

have you tried logging in with your TV provider and then
try downloading the episode ??

Yes

might try using the cookies file addon for firefox

One step ahead of you. That didn't work either. I'm pretty sure MTV changed and youtube-dl needs to be updated

there's 2 more firefox addons to try  - one is called the stream detector and the other
is called videodownload helper try both and see of they'll pick up the video stream

there's 2 more firefox addons to try - one is called the stream detector and the other
is called videodownload helper try both and see of they'll pick up the video stream

Quit throwing out random suggestions!  MTV changed their site. Period! YouTube-dL must be updated for it to wok..

mtv.com is going DRM (> 9c9media) ..

mtv.com is going DRM (> 9c9media) ..

Its already been fixed by youtube-dlc.

mtv.com is going DRM (> 9c9media) ..

Maybe, but not yet. As mentioned above, MTV has changed their website and the YouTube-dL extractor for MTV needs to be updated to include the new web addresses for everything behind-the-scenes. They're not using DRM yet. I can use the Developer Tools in Chrome and pull the .m3u8 file addresses and then use ffmpeg to grab the streams successfully from there. It's messy and incredibly time consuming though.  I wish I knew more about python so I could contribute more to the project.

Just so you all know it has been fixed now. The new youtube-dl was just fixed/updated a few hours ago. This should probably be closed.

This is the same problem as with #26763 .
Seems like interally all of their sites got changed into one template.


Workaround when seeking in MSE strategy

https://github.com/bbc/bigscreen-player/blob/df6e3da0c200cd397074691f7f5edf8a4056c72f/script/playbackstrategy/msestrategy.js#L271
This is a workaround based on the windowType being sliding. Sliding here refers to the DASH manifest having a timeShiftBufferDepth value.
Ultimately when seeking, dashjs will set the current time on the underlying video element. However, something else, either in dashjs, or our interaction with it, was causing problems when seeking and the manifest has a timeShiftBufferDepth.
Therefore this workaround bypasses the dash media player seek code and sets the time directly on the video element.
It would be good to investigate this and ideally use the mediaPlayer.seek in all cases.

Fixed with #111


Hi, very nice work! Can you share the training data you used in your experiments?

So we can reproduce the results! Many thanks!

I mean, many data used here: https://github.com/msoedov/agentic_security/blob/cca85a5f7296fc509f0292d3566ada806c7881af/agentic_security/probe_data/data.py#L232
are now blocked by huggingface or the big company, do you have a backup of these resources? Thanks!


change platform to platform_family

This PR change platform to platform_family, this will save time for future refactoring default recipe and add new distributions. For example,  platform_family 'rhel' include centos / amazon / parallels servers and other rhel/rpm based distributes.

hello, can you update me?

looks good.

Can you release new version to supermarket?

I will release this in next few days. Please wait awhile :disappointed_relieved:

Released v2.0.1 including this fix. Thanks.


Inference Code

Hi. Do you have any plans to release the inference code?

Hi @isjwdu , Sorry that I haven't wrote inference code yet and am too busy at this period. It may become the TODO after serveral months, and you could write by yourself according to test code.

Hi @isjwdu may I know if you have written the inference code and could you share how its done. Thank you

Hi @isjwdu I would appreciate if you could share the inference code

anyone share the infereonce demo code?

please share an inference code


Added a safeguard in an example and fixed a test

Added a os.fork safeguard for Windows in the multiprocessing server example; fixed the test_web_functional test to pass in Windows.

thanks!


Add a link to the blog post describing what smartanswers do

I just learned about this blog post. We also do not have anything in the README that explains how we use smartanswers at GOVUK.

:+1:

Looks good to me.


ngMock - why does $httpBackend match the first and not the last mock definition?

Is there any reason why $httpBackend matches the first and not the last mock definition? If it worked the other way around (i.e. $httpBackend.when added new mock definitions to the beginning of definitions array instead of the end of it) it would be much easier to overwrite already mocked requests.
I've got some default mock definitions common for almost all tests that are loaded before each test and would like to be able to easily overwrite them in some specific tests.
I wanted to prepare PR that changes this, but there's even a unit test that explicitly checks for this behavior.
EDIT: In ngMock module unit tests like should match headers if specified or should match data if specified, the first mocks are more specific than the later ones. In a real app, I'd expect something opposite - one would create general mocks for most tests and then define more specific ones in selected tests.

I think this sounds like a good idea, but of course it would be quite a breaking change to applications.
Let's see if the rest of the team agrees and if so then aim to put it into 1.5

This is actually a really annoying feature when it comes to E2E testing with Protactor, as currently there's no module available that will allow you to keep reference the promise returned by the mock httpBackend to re-purpose the redirect after it's already been set.
So essentially, it's impossible to test a success response and then immediately test a failure without having to do a full browser refresh with browser.get('blah').
Allowing the option of matching the last added regex instead of the first would make this kind of testing trivial. But essentially for me at the moment, integrating Protractor into my tests is impossible due to the high number of tests that can't be changed easily.

@petebacondarwin Are there still any chances this could land in 1.5, as there already were 2 beta releases?
How does it work in Angular 2? Is there the same problem?

Why don't we just add something like resetDefinitions() along the lines of resetExpectations() ? This will at-least help in setting new definitions.

You could also add it as an option that would default to the current code, so it would be backwards compatible. It's really just a matter of changing push to unshift in one place (which we do ourselves after every release of Angular 1.x 😉 )

Am I reading this correctly - I see return; statement inside that while loop so then what purpose does holding on to several definitions of same {METHOD, URL} definition is served.
If we are going to return this loop on the first match then why even bother to push - perhaps it should be a map since there can be only one response.
    var i = -1, definition;
    while ((definition = definitions[++i])) {
      if (definition.match(method, url, data, headers || {})) {
        if (definition.response) {
          // if $browser specified, we do auto flush all requests
          ($browser ? $browser.defer : responsesPush)(wrapResponse(definition));
        } else if (definition.passThrough) {
          $delegate(method, url, data, callback, headers, timeout, withCredentials, responseType, eventHandlers, uploadEventHandlers);
        } else throw new Error('No response defined !');
        return;//why are we returning
      }
    }

I was also thinking of making this configurable. In any case, a PoC PR is very welcome.

We are happy to merge a PR that implements a non-breaking change form of this feature. It looks like something along the lines of resetDefinitions would be best - or perhaps something like whenOverride?

Personally, I'd prefer whenOverride, because this would allow me to keep my generic mocks for most requests and override just the ones I need in a given test. I'll try to find some time to come up with a PR.


reduce minimum macOS SDK version to 10.13

Please select one of the following

[ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
[ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
[X] I am making a fix / change for the macOS implementation of react-native
[ ] I am making a change required for Microsoft usage of react-native

Summary
According to the latest conversation on the Discord the minimum macOS SDK version can be safely reduced to the 10.13 release. This PR updates all the podspec files, project files, deployment targets and CI VM image (there is no CI image for 10.13) to the selected version.
For the link in the Readme file I have used the Apple release post, refs microsoft/react-native-windows-samples#196.
CC @alloy & @tom-un
Changelog

[macOS] [Changed] - reduce the minim macOS SDK from 10.14 to 10.13
Test Plan
After introducing the changes I was able to build and run RNTester locally.
Microsoft Reviewers: Open in CodeFlow

Apple PR CI failed because of unexpected return of brew link node@12 --overwrite --force in the "ensure node 12" step in the pipeline: https://github.com/microsoft/react-native-macos/blob/master/.ado/templates/apple-job-javascript.yml#L11

Apple PR CI failed because of unexpected return of brew link node@12 --overwrite --force in the "ensure node 12" step in the pipeline: https://github.com/microsoft/react-native-macos/blob/master/.ado/templates/apple-job-javascript.yml#L11

I hit this today in the 0.60-stable branch. I can push up the CI fixes I added there but that pipeline is still failing for other reasons so I can't guarantee it'll fully fix CI until I try it.

Apple PR CI failed because of unexpected return of brew link node@12 --overwrite --force in the "ensure node 12" step in the pipeline: https://github.com/microsoft/react-native-macos/blob/master/.ado/templates/apple-job-javascript.yml#L11

I hit this today in the 0.60-stable branch. I can push up the CI fixes I added there but that pipeline is still failing for other reasons so I can't guarantee it'll fully fix CI until I try it.

Here's the PR btw https://github.com/microsoft/react-native-macos/pull/557.

@HeyImChris It looks like I was very close to the actual solution in https://github.com/microsoft/react-native-macos/pull/555/commits/89d711baad8afdf4ee07aa17d48a559747ecbd84 🙂

Just an FYI that the CI pipeline should be up and running again

@Simek Looks like you’ll need to rebase/merge master for the CI issue to be fixed; can you do so please?


Hash Password to login

Hi, Is possible to send to instagram4j builder the hashed password insthead the plain text?

As far as I understand the login flow, the password is hashed serverside, so you have to give Instagram4j the plaintext password. I'm not sure though, let's wait for someone to confirm/correct me

Ok thank. Just another question. I have necessity to store the username and the password of a certain user/users in a database. As the login flow I can't store hashed password and reuse it to perform login...is there another method to do what I need?

I don't think so, unfortunately. Thought about storing the cookie as described here, turns out that requires the plaintext password aswell.
Your way to go is to either

login once to Instagram4j (using the plaintext password) and never quit the application or
not hash the password you store.

Maybe there is a way to store and reuse the internal token, but that's not implemented yet (and I wouldn't know how to do it either)

Unfortunately I can't store users's instagram passwords as plain text in my database, it's really unsafe...I'm thinking about another solution...I'll think of something.

Use a custom hash.
Take plain text password, hash the password, store the password and use the unhasher.

@Vioxini Yeah, I've already found a solution to fix my problem which is just what you propose 👍


[Android] Geolocator.getServiceStatusStream() not listen when disable service if before that are enable it

When my device enable service on status bar, i change it to disable but Geolocator.getServiceStatusStream().listen not working in first time. It only changes when I click it again after that. When my device disable, i change to enable, it working

I too faced this error.
I have my location turned on. I open the app and start listening to the status stream. I turned off location for first time..no event was received. Then again I turned on then onwards only the event was received.
@nguyencuong090896 did you find someone solutions.

i am having issue

i am facing same issue. any solutions?


Typos in color_encoding.h

Here, Rendering is misspelled as Renderig.

There seems to be a copy-paste error here, as the enum constant is called JXL_TRANSFER_FUNCTION_709, but the comment refers to SMPTE RP 431-2 instead of ITU-R BT.709-6.

Thanks!


[chore] Update dependencies, fix warnings during tests

I want to merge this change because once in a while every project needs a little bit of love.
Before:
npm i
found 337 vulnerabilities (331 low, 6 high)

npm run test printing wall of warnings
After:
found 309 low severity vulnerabilities
  run `npm audit fix` to fix them, or `npm audit` for details

npm run test + having only one issue left ;)
I advise to try out test deployment to check if there is any visual issue.
Other changes:

fixed fixture images in one of the stories
translation pages throw less errors in the console
removed unused testcafe leftovers
fixed smaller issues after bumping TS version

Screenshots

Pull Request Checklist

[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Translated strings are extracted.
[ ] Number of API calls is optimized.
[ ] The changes are tested.
[ ] Data-test are added for new elements.
[ ] Type definitions are up to date.
[ ] Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

Branch passed to QA for regression testing

Testing in Progress.
Text for invoices is moved

Tested on deployed environment. No more issues detected.

Fixed


Bug in test suite: Logging in against client that only allows SAML IDP should redirect

What version of UAA are you running?
This is a test suite bug
How are you deploying the UAA?
This is a test suite bug
What did you do?
This line declares SAML is the only allowed IDP:
https://github.com/cloudfoundry/uaa/blob/db47c2b1c4a66da22f75a9159076887cfb5adf41/uaa/src/test/java/org/cloudfoundry/identity/uaa/login/LoginMockMvcTests.java#L303
This test passes:
https://github.com/cloudfoundry/uaa/blob/db47c2b1c4a66da22f75a9159076887cfb5adf41/uaa/src/test/java/org/cloudfoundry/identity/uaa/login/LoginMockMvcTests.java#L281-L287
What did you expect to see? What goal are you trying to achieve with the UAA?
The test should fail.  UAA should redirect in this scenario.
What did you see instead?
The test passes.
Further details
I've created a branch with a properly failing test to illustrate what I think should happen here.
https://github.com/cloudfoundry/uaa/blob/611c0b42ca1e61c3b7ff7b1730ba916b0dfd34b1/uaa/src/test/java/org/cloudfoundry/identity/uaa/login/LoginMockMvcTests.java#L309-L333
I suspect the same problem exists for a client that only allows OIDC.
I believe this subtle bug was introduced in "Restructure login method to not read all IdentityProviders on login_hint"

Solved


[chore]: [Snyk] Security upgrade org.springframework.boot:spring-boot-starter-webflux from 2.7.0 to 2.7.7

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `maven` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

app/server/reactive-caching/pom.xml

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

611/1000  Why? Recently disclosed, Has a fix available, CVSS 6.5
HTTP Response Splitting SNYK-JAVA-IONETTY-3167773
org.springframework.boot:spring-boot-starter-webflux:  2.7.0 -> 2.7.7
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

/perf-test
Testing performance infra, ignore.

Let's hold off on this till the next cycle? We're going up a major version then anyway, would like to get proper regression done. Closing the PR for that reason.


[FLINK-8475][config][docs] Integrate HA-ZK options

What is the purpose of the change
This PR integrates the Zookeeper HA ConfigOptions into the configuration docs generator.
Brief change log

Add ConfigGroup for zookeeper HA config options
integrate zookeeper HA configuration table into config.md

Ok, looks good now. 👍

merging.


[ART-7959] Fix hotfixes not being reflected in dashboard

The dashboard didn't correctly reflect hotfixes, as observed with the recent 4.12 release.
The problem was due to the 'jira_link' variable being referenced before assignment. By ensuring that the variable has a default value, the issue was resolved.

/lgtm
/approve


Look into adding info about yielding and amount of data read to ScanInfo

For some use cases it may be useful if the new ScanInfo contains info about yielding and the amount of data read.  For example this could support the use case of moving scans that have yielded or read lots of data to another thread pool.

I am closing this because I was able to satisfy my use case w/o this information.  All I needed to know was the scans current run time (while is already available in 2.0.0-alpha-2) and using that info I could dispatch long running scans to another executor.   I created the following test while exploring this scenario.
apache/accumulo-testing#56


[CWS] fix hardlink for exec in overlayfs

What does this PR do?
This PR fixes the Nlink value of files for exec events in overlayfs. This value is used during the path resolution in order to determine if the cache has to be used or not. Before this PR exec events in busybox container, using hardlink, were having path resolution issue. The first entry in the cache for a busybox binary was used for all the subsequent resolutions whatever the command used.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

@safchain do we still need this ? Can I help rebasing it ?


multiline input blocks

Closes #93
Closes #385
Check the following

[x] Keep 100% code coverage
[x] Be properly formatted
[x] Documentation changes are included
[x] Include a change file if expected

Additional context
Waiting on an update from cqroot/prompt for validations.
Still need to write tests.
FYI @bephinix and @sheldonhull both of you requested this.

@miniscruff Thx for the PR! This makes it possible for me to use Changie for even more projects. :100:


Prometheus stats

This PR

adds prometheus stats reporting to workers (which is an enterprise only feature)
adds deployment helpers to deploy prometheus / grafana to view/see the stats
re-adds the src/server/worker tests to CI (they were not being run before)

Broadly, we are using both prometheus histograms and counters because:
Histograms let me answer questions like:

'What is the moving avg (given a time window) of the datum runtime for this pipeline or job?'
By executing the query rate(pachyderm_user_datums_sum[1m])/rate(pachyderm_user_datums_count[1m])

Counters let me answer questions like:

What is the total number of bytes uploaded by this job | pipeline ?
What is the total runtime of this pipeline? (Very helpful when computing scaling costs)

More specifically, we generate time series along the following dimensions:

datum state (started, errored, finished)
job ID
pipeline ID

So you can see your stat (size or time) filtered or aggregated by any of the above.

The diff is big bcz I had to add vendored deps, but most of the changes are in:
src/server/worker/stats.go
src/server/worker/api_server.go

I added a test suite, which was very helpful in vetting some of these queries, and will also serve as a good handoff to @gabrielgrant to hook this into the UI. The tests are a little funky (have timeouts in a few places) but are designed to generate data that is meaningful to look at.
Here are some example graphs that we can generate.
Upload time across jobs:

Upload time per job:

Avg runtime across jobs (by state ... finished  / errored):

Another question, why do all of these graphs end with the line trailing off to the right at a static value? I thought we figured out how not to do that.

Ok, I've integrated all the feedback, this is ready for another review @jdoliner

Few polish things left, other than that this is pretty much mergeable.

So I removed the k8s 1.7 compatibility test. This was consistently failing for me on CI. Locally it works most of the time, but sometimes doesn't work w kubectl 1.8.2
K8s is now at 1.10 so we're ok dropping this test.

Ok. I pulled all those things out into helpers. Ready for a final review @jdoliner


TypeError: Cannot read property '_tiles' of undefined

[2019-05-29 09:12:14.886] [FATAL] [default] - TypeError: Cannot read property '_tiles' of undefined
    at PointRenderer.setCartoCSS (/home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/torque.js/lib/torque/renderer/point.js:122:57)
    at new PointRenderer (/home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/torque.js/lib/torque/renderer/point.js:77:10)
    at /home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/windshaft/lib/windshaft/renderers/torque/png_renderer.js:90:29
    at /home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/windshaft/lib/windshaft/renderers/torque/renderer.js:173:17
    at ctor.PSQLAdaptor.ctor._handleResult (/home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/windshaft/lib/windshaft/renderers/torque/psq
l_adaptor.js:16:9)
    at Result.<anonymous> (/home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/cartodb-psql/lib/psql.js:325:24)
    at Result.Query.handleReadyForQuery (/home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/pg/lib/query.js:144:10)
    at Connection.<anonymous> (/home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/pg/lib/client.js:184:19)
    at Connection.emit (events.js:189:13)
    at Socket.<anonymous> (/home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/pg/lib/connection.js:135:12)
TypeError: Cannot read property '_tiles' of undefined
    at PointRenderer.setCartoCSS (/home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/torque.js/lib/torque/renderer/point.js:122:57)
    at new PointRenderer (/home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/torque.js/lib/torque/renderer/point.js:77:10)
    at /home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/windshaft/lib/windshaft/renderers/torque/png_renderer.js:90:29
    at /home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/windshaft/lib/windshaft/renderers/torque/renderer.js:173:17
    at ctor.PSQLAdaptor.ctor._handleResult (/home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/windshaft/lib/windshaft/renderers/torque/psql_adaptor.js:16:9)
    at Result.<anonymous> (/home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/cartodb-psql/lib/psql.js:325:24)
    at Result.Query.handleReadyForQuery (/home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/pg/lib/query.js:144:10)
    at Connection.<anonymous> (/home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/pg/lib/client.js:184:19)
    at Connection.emit (events.js:189:13)
    at Socket.<anonymous> (/home/ubuntu/www/node-windshaft/releases/20190521103931/node_modules/pg/lib/connection.js:135:12)
[2019-05-29 09:12:14.887] [INFO] [default] - Process is going to exit with code: 1

As with https://github.com/CartoDB/turbo-carto/issues/83, it's crashing in production.
cc/ @CartoDB/rt-managers

3 instances of this error so far today.

It seems that undefined layer in a torque renderer has caused problems before and has been handled by coping with undefined layers. I'm not sure that's the best option, but I'm not sure either if it's worth investigating the cause of the undefined layer.

I managed to reproduce the issue with a point dataset and the following cartocss:
Map {
  -torque-frame-count: 1;
  -torque-animation-duration: 30;
  -torque-time-attribute: "cartodb_id";
  -torque-aggregation-function: "count(1)";
  -torque-resolution: 4;
  -torque-data-aggregation: linear;
}
#layer {
  marker-width: 16.6;
  /*marker-width: ramp([temp], range(2, 40), jenks(6));*/
  marker-fill-opacity: 1;
  marker-file: url(http://cartodb-libs.global.ssl.fastly.net/cartodbui/assets/unversioned/images/alphamarker.png);
  marker-allow-overlap: true;
  marker-line-width: 1;
  marker-line-color: #FFFFFF;
  marker-line-opacity: 1;
  marker-comp-op: darken;
  image-filters: colorize-alpha(#4b2991,#872ca2,#c0369d,#ea4f88,#fa7876,#f6a97a,#edd9a3);
}

and then trying to Export image... from Builder.
That said, there are a few dark corners in this very specific use case:

Torque + Turbo-Carto is a half supported feature at best, and officially not supported. See https://github.com/CartoDB/cartodb/issues/10947 (it's a long discussion with branches, but very relevant).
Mind the commented out code: part of the work is done client-side (receiving the torque json info and rendering static or animated stuff in the browser), whereas another part is done by the tiler (see

https://github.com/CartoDB/Windshaft/blob/a9b3b6492c4e01b16b12c807bf10f6d5d2661d32/lib/windshaft/renderers/torque/png_renderer.js#L90
in the stack trace). Usually that works by "compiling" turbo-carto to plain cartocss and then handing it over to the tiler, but the commented out code messes it up as it believes it has a turbo-carto, here:
https://github.com/CartoDB/torque/blob/4d2540ef98018775cfcd8fee8df2c39c6fc13230/lib/torque/renderer/point.js#L121
and that does NOT happen when that code is uncommented.
So, I suspect the crash is triggered by some legacy "dead code" that is only reachable in this faulty condition: commented code that resembles turbo-carto.

There must be some bad interaction with Windshaft, cause it should have a layer defined anyway.

After much tinkering with Windshaft, adding traces to callbacks and so forth, I decided to go for the "safe preventive" approach: get rid of comments and do not attempt to read layers nor apply turbocarto if there's no layer definition: https://github.com/CartoDB/torque/pull/307

:rocket:


⚠ Jenkins Plugins Artifactory has degraded performance

In 7e7a7dd, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1028 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 89395ad after 26 minutes.


Cadence HiFi 4 Neural Network Library v2.4.1:

Updated the script to download HiFi 4 Neural Network Library v2.4.1.
Removed the hifi4 patch
Updates in v2.4.1 library:

Fixed the issue related to special case handling in xa_nn_dot_prod_16x16_asym8s.
Moved the special cases handling for vec_length=8/32 to the start of the function.
Removed legacy condition checks for depthwise_conv kernels.
Fixed the non-bit-exact issue related to xa_nn_conv2d_std_per_chan_sym8sxasym8s.
updated to select correct vec values in case of vec_align_val is 1 and

@advaitjain

Does this update also address https://github.com/tensorflow/tflite-micro/issues/329?

@advaitjain
Yes, I have verified with the unit test case as well (which is attached in #329 )

@advaitjain
Yes, I have verified with the unit test case as well (which is attached in #329 )

Thanks!


Add document into source code

fix #92

Pull Request Test Coverage Report for Build 510

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.486%

Totals

Change from base Build 506:
0.0%

Covered Lines:
677

Relevant Lines:
740

💛  - Coveralls


Blank page

when I go to https://bwenedianjr.github.io/s2js/ it's blank

It was a test to run an old GitHub that was broken by new GitHub updates

Did you complete Pixie?

I can’t bc I dont own the GitHub and idk how to fix it but if you’d like
you can fork it and fix

I have the visual.js code

https://zilbert.faris90.repl.co/lib/visual/visual.js

https://zilbert.faris90.repl.co/lib/visual/visual.css
And the CSS

@BwenedianJr

K bet, btw I have a replit account

https://bwenedianjr.github.io/pixie_updated/ This is my progress so far
Added sounds, if on edge bounce block, effect blocks, and fixed some bugs.


[AtomFormat] Remove redundant fallback content

Currently, the default content for an Atom feed is the title, which is redundant. This was added for compliance with RFC 4287, but this can also be solved by having an empty content element. The feed is still valid as tested by the validator at the top of the file.

Seems good. Didn't using the empty string work?

The validator recommended that the content tag have at least something in it, so I complied.
There is a separate issue that I didn't have enough time to investigate fully, so I opened an issue.


Invite Only Communities

Have some invite only communities where moderators can only invite other people ( local only ? )
Idea:
For sensitive communities, private communities e.g. for a friends minecraft server to have a private community for news, tutorials, updates....

Depends #342

Having authorized fetch enforced would serve as a basis to securing this, but due to the nature of federation different quirks would still need to be accounted for as well.


Diagnostic list flickers annoyingly when opening a document

In VSCode, if you display all diagnostics for your project (i.e. set the "python.analysis.openFilesOnly" to "false"), you can view the list in the "Problems" panel. If you open a Python file that contains a reported diagnostic the analysis diagnostics for that file briefly disappear and then reappear. This is not only aesthetically unpleasing, it's also disorienting if you just clicked on one of these items to open the file and view an error in the editor.
The problem appears to be that the PLS is reporting diagnostics in two phases: parsing and analysis. When a file is closed, the server sees version -1 of the file, but when it's opened, the server sees version 1. This causes the server to re-parse and re-analyze the file from scratch. (As an aside, this seems wasteful given that the file hasn't changed. Maybe it could be skipped altogether?) When the parse is complete, the server reports the incomplete diagnostics, which don't contain the analysis drags. Then shortly later it reports the full diagnostics. In the meantime, VSCode has updated the diagnostic list in the "Problems" panel.
I don't fully understand the original reason behind updating the parse and analysis errors independently, so I'm not sure of the correct fix. My attempt at a fix is to comment out the following three lines from EditorFile.UpdateParseDiagnostics:
// if (diags != null) {
//     PublishDiagnostics(diags);
// }

This skips the reporting of the partial diagnostics and waits for completion of the analysis. With this change, the annoying flicker, and I haven't noticed any bad side effects.

The parse errors are produced fast and the separate publishing allows users to see syntax issues like missing braces faster as they type. Analysis can take literally tens of minutes to complete. Live syntax check was a very popular request since the only alternative is to run PyLint on save (which is what happens with Jedi completion engine).

So, bottom line is that first reporting syntax errors and then combo of syntax + analysis is inevitable as this is how VS Code works. It has no API for incremental error list population like big VS has and the entire snapshot of diagnostics has to be sent each time. Delaying reporting until analysis completes deprives user from fast appearance of squiggles over syntax errors.
What we can do in the new code base is throttle reporting of syntax errors a bit so if analysis completes within, say, 200-300 ms which is realistic in the new analysis engine, then only combo will be reported thus reducing flicker.

The problem here is not with VS Code but in the way you're reporting the errors. It's fine to report the errors in two passes — syntax and then analysis. That's how most compilers and language tools work. The problem is that when you run the pass a second time (due to a change in the file), you're discarding all of the previous errors and reporting only the syntax errors for the new version of the file.
What you're doing now is this:

Report syntax errors [version 1]
Report syntax errors [version 1] + analysis errors [version 1]
Report syntax errors [version 2]
4.Report syntax [version 2] + analysis errors [version 2]

What you should be doing is retaining the analysis errors from the previous pass until they are replaced by new analysis errors. Like this:

Report syntax errors [version 1]
Report syntax errors [version 1] + analysis errors [version 1]
Report syntax errors [version 2] + analysis errors [version 1]
4.Report syntax [version 2] + analysis errors [version 2]

After step 3, there's a small chance the reported analysis errors will be out of date for a short period (until you get to step 4), but that's not a big deal. It's preferable to the current behavior. And most of the time the analysis errors won't change much (if at all) between steps 3 and 4, so the user won't notice any difference.

We could try that. However, openFilesOnly = true is the only option now. We no longer open and analyze all files in the workspace and the setting has no effect. Therefore difference most probably will be very small since new analysis engine adds very few messages at the moment, like unresolved imports.

Presumably, the analysis engine will add more diagnostics in the future. Even if you currently support only a few analysis errors at the moment, this change is still important because the annoying and disorienting error behavior will occur after an open file with analysis errors  are edited.

So the method below produces odd presentation, may not be desirable. Say, I type import pand. it gets squiggled as unresolved. Then I continue typing but squiggle may remain for a several seconds until analysis finishes. I'd rather take error list update, it is easy to hide it. Persistent stale squiggle is annoying and there is no way to get rid of it.

I'm surprised to hear that analysis of a single file can take several seconds. It should be at the front of the priority queue in this case. I'd expect it to take tens of milliseconds, or hundreds at most.
Even if it takes a couple of seconds, I still think it's preferable to retain the existing errors until they are replaced. The case you described is an edge case, and it's better to optimize the experience for the more common case.

When dependencies are loaded, yes. In the case above fixing import brings huge subsystem into the view. Its is analysis and analysis of all its dependencies may take 10-20 seconds.


iox-#2325 support bzlmod

Notes for Reviewer

Pre-Review Checklist for the PR Author

[x] Code follows the coding style of CONTRIBUTING.md
[ ] Tests follow the best practice for testing
[ ] Changelog updated in the unreleased section including API breaking changes
[x] Branch follows the naming format (iox-123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#123 commit text)
[ ] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[ ] Add sensible notes for the reviewer
[ ] All checks have passed (except task-list-completed)
[ ] Assign PR to reviewer

Checklist for the PR Reviewer

[ ] Consider a second reviewer for complex new features or larger refactorings
[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] Unit tests have been written for new behavior
[ ] Public API changes are documented via doxygen
[ ] Copyright owner are updated in the changed files
[ ] All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Closes #2325

@wep21 wow, this was fast. Thanks very much for taking care of this.
We have still users who are relying on the old WORKSPACE approach so we might need to restore some of the deleted files for the time being.
I'll check whether the users I know of are able to use dependencies which use bzlmod. If this is indeed the case, this can be merged as is (once the CI is green), if not the files from the bazel folder need to be restored.
Anyway, it's is great to move this forward :)

@elBoberido

I'll check whether the users I know of are able to use dependencies which use bzlmod. If this is indeed the case, this can be merged as is (once the CI is green), if not the files from the bazel folder need to be restored.

I restored old files once and added WORKSPACE.bzlmod for compatibility.

Edit: It seems that there are some issues with //:buildifier_lint_check

Let me check the error.

Just wanted to merge but then I noticed that there is no entry in the changelig.
Can you please add an entry to the feature section of doc/website/release-notes/iceoryx-unreleased.md. The format is the name of the issue which is fixed and the link to the issue.

Can you please add an entry to the feature section of doc/website/release-notes/iceoryx-unreleased.md. The format is the name of the issue which is fixed and the link to the issue.

added at https://github.com/eclipse-iceoryx/iceoryx/pull/2338/commits/417eabaf4b64580920179c8bce0212230e9b624a


[BUG] Git checkout fails on Windows

Describe the bug
Git checkout fails due to trailing dot in folder cli/src/test/resources/com/google/prefab/cli/packages/missing_artifact_id/modules/missing_id/libs/android./ which is illegal folder name in Windows
To Reproduce
Steps to reproduce the behavior:

Start Git Bash
git clone https://github.com/google/prefab.git prefab

Expected behavior
Clone and checkout complete without problems
Logs
$ git clone https://github.com/google/prefab.git prefab
Cloning into 'prefab'...
remote: Enumerating objects: 1473, done.
remote: Counting objects: 100% (373/373), done.
remote: Compressing objects: 100% (197/197), done.
remote: Total 1473 (delta 68), reused 330 (delta 49), pack-reused 1100
Receiving objects: 100% (1473/1473), 266.02 KiB | 2.31 MiB/s, done.
Resolving deltas: 100% (349/349), done.
error: invalid path 'cli/src/test/resources/com/google/prefab/cli/packages/missing_artifact_id/modules/missing_id/libs/android./.keep'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'
Environment:
Prefab version: 1.1.3
Host OS: Windows

That test is specifically testing the behavior for a folder name that ends with a dot, so the easy fix (rename the directory) breaks the test. The only way around it that comes to mind would be generating all the test inputs dynamically when running the tests and skipping this test on Windows. It would be a lot of work and since it's a JAR there's no actual need to build this on Windows. Given all my other responsibilities that's not going to be a priority any time soon, but I'd be happy to review a PR.

https://github.com/google/prefab/pull/168 fixed this a while ago.


perfectScrollbar not working over disabled

Firefox only:
If I have an  and attempt to scroll while my mouse is over it, nothing happens.

Seems like a Firefox issue. The same bug occurs in virtually all custom scrollbar plugins. Any idea why?

Isn't it caused by -moz-user-input: disabled; applied on (by default) input:disabled, textarea:disabled, option:disabled, optgroup:disabled, select:disabled:disabled?

You seem to be correct.
Is there something I should know about this? Any workaround maybe?

You can simply modify your CSS (or more specifically):
.ps-container input:disabled,
.ps-container textarea:disabled,
.ps-container option:disabled,
.ps-container optgroup:disabled,
.ps-container select:disabled:disabled {
  -moz-user-input: inherit;
}

Yeah, unfortunately it's not the same in a few ways:

Disabled inputs don't actually get submtited with the form (readonly do)
You can actually interact with a field with which you're not supposed to. That's bad UX.
This doesn't work too nicely, unfortunately.

I resolved my issue by adding a transparent div on top of my disabled inputs and scanning for it when necessary (more on that later).
I did find a few scrollbars that don't have the issue but unfortunately I'm not too savvy with javascript to commit anything more useful than opening an issue and giving some info.
This one works: https://github.com/jnicol/trackpad-scroll-emulator
This one also works: https://github.com/noeldelgado/gemini-scrollbar
There was one more but I lost it somewhere.
Not sure what they do differently but I'm hoping to give an idea or two.
As a workaround I did the following:

I put all my inputs inside
I wrote this:

var is_firefox = /Firefox/i.test(navigator.userAgent);
$.fn.inputDisabled = function() {
        var $this = $(this);
        var $parent = $this.parent();
        $parent.addClass('input-disabled');
        $parent.append('<div class="disabled-overlay" />');
        return $this;
}

if (is_firefox) {
        $('input:disabled, textarea:disabled').inputDisabled();
        $('.disabled-overlay').on('click', function(event) {
                event.preventDefault();
                var $this = $(this);
                var $input = $this.siblings('input');
                if (!$input.prop('disabled')) {
                        $input.focus();
                        $this.remove();
                }
        });

        $('.field').on('mouseover touchstart', function(e) {
                e.preventDefault();
                var $this = $(this);
                var $input = $this.children('input, textarea');
                if ($this.children('input:disabled').length != 0 && $this.children('.disabled-overlay').length == 0)
                        $input.inputDisabled();
        });
}

...and this:

.input-disabled {
 position: relative;
 .disabled-overlay {
  position: absolute;
  content: '';
  top: 0;
  bottom: 0;
  left: 0;
  right: 0;
 }
 input:not(:disabled) + .disabled-overlay {cursor: text;}
}

This works for me. For now, at least. Hopefully the author might work around the issue and this would really be a 'perfect' scrollbar.

Will be fixed in Firefox 47 which is coming in June.

Great news! Thanks for sharing.


Screenly Queue

The idea behind Screenly Queue is to develop a queue system for retail environments that is open source and cost effective.
tl;dr: The user walks in to the store and gets a number. The teller presses button in the user interface (teller interface)  and the number shows up on the screen (dashboard interface).
Design
There are four sides to the app:

Admin: Store manager
Teller: Day-to-day user
Dashboard: The signage side (Edge App)
Customer: A way to get a number in the line

Admin
The admin interface is simply the Django admin interface. You will be able to do the following:

Add/remove users
Add/remove counters
Reset/manage the ticket queue(s)

In the prototype we will only have one queue, but it would be interesting down the road to have different queues.
Teller
The teller interface is a Django page that allows you to do the following:

Select a counter (probably one page counter)
Skip to the next in the counter

Dashboard
This is the interface that will be shows on a big monitor. It's just an Edge App that pulls from the main server (to ensure rapid updates). It will show "Now serving X at counter Y". When the number is increased, the display will jump forward with very little latency.
Customer
This is where the customer gets the number from (if the client isn't using a physical printer). It's simply a page that will give you a session cookie and when you press "Request number" it return a number.  This is normally displayed used on a mobile phone.

Moved to the Egde App List.


feat: add slider component

fixes #13
Made it localy... then totally forgot about it :D
The slider component should be fully functional (desktop / mobile). However, I'm not sure about the usage of the handleRef utility or the variables injected in styles. Maybe slider should have its own variables ?

Thanks!


More changes for Numpy v1.24

Matt caught the np.float issues, but there were some np.int issues too.  Switched to np.int_
Before I could do this, there were also some differences between the master and dev branch that had to be resolved.  I would also recommend resolving the confusion between having two branches named master and main with some overall branch cleanup

Thanks Garrett. I'm working on a big update that changes a lot of the code in a discontinuous way. It should be ready in a day or two. I'm going to delay this merge until then, to see how the merge conflicts look. I'll get the branches cleaned up then too.

Sounds good. I will use this branch to get WEIS up and running again.

I just merged it. (I don't want to delay/complicate the process of getting WEIS up and running again)


chore: minimize import

It seems that this unused import isn't detected by shake

Thanks! (By the way: feel free to label such PRs as easy or tech debt in the future: not required at all, but that will get them reviewed faster.)
maintainer merge

bors merge


add support for rgb(a) colors

avoid adding any new javascript/native modules, at least for now (it's totally fine at this point to support only subset of what we might want to support in the future)
parse both rgb() and rgba()
add support for hex shorthand too (#000)
throw for anything else

hex colors support alpha too (#0008 & #00000088), rgb(a) function will be added later


[ARM-230] sentry logger integration

I've integrated the following features:

Set user info for the next sentry event from the AuthInfo struct on FromRequest
Add a breadcrumb for the next sentry event with info about the request
Send a message with level Error if a response has a status code gte 400 or the "success" property is false
Also, add the body of the response as extra data and set a tag "Service" to "invitations", "emergency", "http gateway" on each message so we know exactly on which service the error happened

@security-union/dev

@JasterV did you test that it is possible to log request for multiple users?

I feel that it might be dangerous to share the phone, first name and last name, could we leave only the device_id, and user_id?

For sure, Ill do it🙌

@JasterV did you test that it is possible to log request for multiple users?

What do you mean? If it is possible to relate an event with more than one user, or if there is conflicts if more than one user makes a call at the same time? If its the second one I dont think I can test that, but if its the first one, you only can add a user per request

@JasterV @griffobeid I think we should merge this one until sentry is up and running.

@JasterV @griffobeid I think we should merge this one until sentry is up and running.


fix: Partial state deserialization on simple islands

This PR fixes an issue with deserialization of Fresh Partial.
When no special type is used on __FRESH_STATE, the requiresSerialization variable is false, which causes thedeserialize function to be null, thus making a void state, thus not hydrating correctly the islands inside the fresh state.
This PR addresses this issue by using the good&old JSON.parse in these cases.

Hi @marvinhagemeister.
Looking at the code, I've noticed a test for serializes props. Taking a deeper look on why this test was not failing with mainstream code, I've figured out that the  component was making the deserialize function needed (since it's an island). Removing the  made the tests fail with mainstream code and pass with the proposed changes.
Since there's already a test for nested islands, removing  from routes/island_props test this case.
Tell me what you think, thanks!

Done, thanks @marvinhagemeister !


ISPN-13835 Non blocking methods for EmbeddedCounterManager

https://issues.redhat.com/browse/ISPN-13835

updated :+1:

Integrated into main, thanks @pruivo !


Updates for VS 2017 version

Updates to articles to move them from VS 2015 to VS 2017

OPS Build status updates of commit e31e650:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/powerpoint/use-document-themes-in-your-powerpoint-add-ins.md
:white_check_mark:Succeeded

docs/project/create-your-first-task-pane-add-in-for-project-by-using-a-text-editor.md
:white_check_mark:Succeeded

docs/project/project-add-ins.md
:white_check_mark:Succeeded

docs/word/create-better-add-ins-for-word-with-office-open-xml.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 3a10369:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/powerpoint/use-document-themes-in-your-powerpoint-add-ins.md
:white_check_mark:Succeeded

docs/project/create-your-first-task-pane-add-in-for-project-by-using-a-text-editor.md
:white_check_mark:Succeeded

docs/project/project-add-ins.md
:white_check_mark:Succeeded

docs/word/create-better-add-ins-for-word-with-office-open-xml.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 69c51b2:
:clock10: Preparing: average preparing time is 45 sec(s)

@kbrandl I changed to select. Merging PR. Thanks!

OPS Build status updates of commit 69c51b2:
:clock10: Incremental building: average incremental building time is 28 sec(s)

OPS Build status updates of commit 69c51b2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/powerpoint/use-document-themes-in-your-powerpoint-add-ins.md
:white_check_mark:Succeeded

docs/project/create-your-first-task-pane-add-in-for-project-by-using-a-text-editor.md
:white_check_mark:Succeeded

docs/project/project-add-ins.md
:white_check_mark:Succeeded

docs/word/create-better-add-ins-for-word-with-office-open-xml.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Conditions not working

Hello,
I want to add a condition, where the extension only clicks if a specific element on the website contains a specific number. But when I add the XPath of the other element as condition it says "Invalid XPath". Without the condition the extension works fine.
Can you please check if there's a mistake in your code?
Thank you so much!

fixed


Upgrade rubocop

Description
Rubocop is fixed to a pretty old version.
The purpose of this PR is to try upgrading it step by step.
Type of change
Please delete options that are not relevant.

Refactoring (improvements to code design or tooling that don't change behaviour)

Note to other contributors
One of the first offense to be fixed with a new version is done in lib/cucumber/glue/dsl.rb. Before we just had the extend(Cucumber::Glue::Dsl) instruction to extend the global Object class. This triggered an offense. I've fixed it by explicitly replacing it with the following:
class Object
  # TODO: can we avoid adding methods to the global namespace (Kernel)
  prepend(Cucumber::Glue::Dsl)
end

That way the extension of the global Object class is made explicit. Tests seems to be passing. Does that looks good to advanced ruby developers?
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

[ ] New and existing tests are passing locally and on CI
[ ] bundle exec rubocop reports no offenses

Rubocop has been bumped to the latest version, and offenses have been fixed.
To review this PR, I think it would be easier to look at the commits rather than the diff.
@luke-hill What do you think? I removed all inline magic comment I had added before except for one.

So yeh reviewing this was hell! Please don't give me a PR with 158 things again to review 😓
We should use the todo file to partially fix things up and then just click them off in the todo file.

Yeah, sorry for that 😓
I hate big PR myself.

So, to summarize:
What we could do as part of dedicated PR (I would open dedicated issues to make sure we do not forget those):

removing the unused _=nil from cli::main#initialize parameter list in v8
allowing inner slashes in RegexpLiteral rubocop configuration
formatter/ansicolor.rb need to be refactored
removing DataTable#map_column! in v8 which was planned to be removed in v2
refactor fake modules and classes in configuration_spec.rb, http_io_spec.rb, junit_spec.rb and fake_objects.rb to prevent defining those fakes globally

To merge the current PR:

make sure that calling super in the events initialize methods is safe as part of the actual PR (lib/cucumber/events/step_activated.rb and lib/cucumber/events/step_definition_registered.rb)
can we safely delete some code from proto_world.rb? I am still confused with this. It seems to be useless. What would make it useful? Cucumber::Glue#steps and Cucumber::Glue#inspect are just calling super without any other code.

Did I missed something? Does that looks like a plan?

Yep sounds great. I've attached a couple of additional comments where needed.

make sure that calling super in the events initialize methods is safe as part of the actual PR (lib/cucumber/events/step_activated.rb and lib/cucumber/events/step_definition_registered.rb)

Actually, Cucumber::Core::Event generates sub-classes with initializers dedicated to generate attribute readers.
So in derived classes as StepDefinitionRegistered or StepActivated, writing an initializer to initialize the attribute readers is doing what already does the base class.
Calling superis doing it twice.
Removing the initializer is removing duplicated code.
And this is actually covered with tests: when not properly initializing attribute readers for those two classes, some tests broke.

can we safely delete some code from proto_world.rb? I am still confused with this. It seems to be useless. What would make it useful? Cucumber::Glue#steps and Cucumber::Glue#inspect are just calling super without any other code.

I have restored the deleted methods. There purpose is actually documentation.

@luke-hill I guess I answer all your questions. Can we merge?


ERROR: cannot launch node of type [panda_simulation/robot_state_initializer_node]: Cannot locate node of type [robot_state_initializer_node] in package [panda_simulation]. Make sure file exists in package path and permission is set to executable (chmod +x)

after compile and source
roslaunch panda_simulation simulation.launch
ERROR: cannot launch node of type [panda_simulation/robot_state_initializer_node]: Cannot locate node of type [robot_state_initializer_node] in package [panda_simulation]. Make sure file exists in package path and permission is set to executable (chmod +x)

I  have some error. can you fix it ?


[Refactor] Minor improvements to type annotations and initialisations.

Closes #229.
The issue description is outdated. Some minor improvements to the codebase.

@jpmoutinho The issue is outdated but I took that opportunity to do minor changes. I can do more as per the description above if you wish.

Hey @jpmoutinho it looks like the engine strings are only used here so it might be an overkill to use StrEnums I think. I'll do that later if there is a need for it really. In the meantime I'll work on #244.


ARTEMIS-3771 - Rework destination handling for the OpenWire-protocol

This gives a significant performance increase for my use case but I could not find a good way to demonstrate it through testing, so the added tests only focus on functionality

@franz1981
Hi,
Do you like these changes better? I opted to add the connection-level cache again since after some more testing I found that I was wrong. Both the bitwise operation and the modulus one produces the same level of cache distribution (and clashing). The distribution "issue" increase with array size... this effect is probably only news to me though.
I should mention that the biggest performance gain here is from removing the "BindingQueryResult", because that becomes a very heavy operation with a large amount of destinations.

Let me try to understand...
you've created an Array on OpenWireprotocolManager that must be sized at the power of 2, you hash the queue and look for it on the ProtcolManager?
it would be better If you're implementing such cache it would be better to create some class... say.. name it as HashStringCache and have the logic encapsulated in there?

@clebertsuconic thanks for the feedback
Okay... at this point I'm basically just moving the current "session-level" destination cache and making it shared, but the way this cache is implemented now makes collisions happen so often that I'm not really sure it's worth it to be honest. I'm mostly doing this for a use case I have with a very large number of queues and chances of a cache-clash is really high already at "just" some few hundreds of destinations.
If you prefer I change this (and I can do that for sure), do you think it makes sense to just store all destinations in something like a hashmap instead that just holds all destinations, or should I revert this particular part of the change to it's old behavior, i.e Session-level? Either way is fine for me.

this sort off cache should be at session Level I think

@clebertsuconic @franz1981
Restored the cache to previous behavior, this PR now primarily just gets rid of the binding-query which was the real performance sink anyway.
Don't really know how to write a meaningful test to demonstrate the benefit though, but the easiest way to "real-life" demonstrate it is by loading the broker with thousands of queues and have a single producer send messages in individual sessions (such as some frameworks unfortunately tend to do it).

It seems you care about performance.  Why OpenWire though?

@clebertsuconic I'm running this on a pretty large scale (around 600 client applications or so in some environments, multiple environments interconnected globally) and all of which used to run against ActiveMQ 5. Most are supposed to get migrated over to Core but this is a pretty big undertaking so for some foreseeable future I have to support "backward" compatibility. I figure this is something I can do to make things run as smoothly as possible until such time that they can start to get migrated... and hopefully it might be helpful to someone else too.

@AntonRoskvist I was just curious.. thanks a lot...
probably I should have asked you in private though.. thanks

so, it seems we were doing two checks for the address/. queue, one was useless and not needed,, correct?
on that case can you rename the commit to something more accurate to the current state?
say:
ARTEMIS-3771 Avoid not needed lookup for address on OpenWire connections

I can of course use some Git-fu and do it myself... but if you do it yourself I guess you wouldn't have my trace as a contributor in your commit.
Also, if you could rebase (git pull --rebase upstream main) and git push -f?
I can then just run my private CI on top of your PR. (I have a parameterized build where I pass in GitHub address and branch name).

Of course, hope this does it. Otherwise let me know. Thanks @clebertsuconic

full pass on my CI.. merging it.


update for new pycharm build.

Incompatible with version 193.5233.109
Hasteit loaded in fine.

10:27 AM	Plugin Error: Plugin "DiscordBeam" is incompatible (target build range is 183.4284.148 to 192.*).

EDIT: I'm dumb, saw the change log.

Was it possible for you to just download an update for the working version or did had to uninstall it and download the plugin again?

Had to uninstall then reinstall, not a big deal :)

My intention was, that people just could upgrade from the now ---version to the normal version without a reinstall. I'm just a little sad, that it didn't work.
Anyways I guess, it would be good to write this to the README file of the repository.
Thank for your issue otherwise I wouldn't have noticed.


Add bytes.maketrans

hi,
there is a proposal for maketrans in #847. Please could you review it and tell me If I should remove it or change some things.
A bunch a bytes method are waiting review.
You can find not implemented  bytes method here : #736

Thanks. It looks a lot better. I will close this one


how to set the version of a qrcode

the version of a QR code indicates its size, data storage capacity, and potential error correction capabilities, with versions ranging from 1 to 40
so how to set the version

Hi @youpuyewolong my library does not support such versions, only error correction levels. You can look at the underlying library which generates the QR code matrix https://github.com/Bacon/BaconQrCode if such functionality is available. If so, maybe this can be implemented. Good luck and thank you for your question.


Update virus-detection-in-spo.md

clarity around the AV scan order of events and asynchronous wording.

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@AdwoodMicrosoft