Test with java 9

Add jdk9 run to travis.
Fixes #2337

@timmolter can you re-run travis build for this PR? There was some problem with travis :)

did it.

Looks like Java9 will require maven 3.5 and PowerMockicto is unsupported.
@timmolter WDYT?

We had similar issues to this when upgrading to Java 8.
Here's a related thread: https://github.com/grpc/grpc-java/issues/3633
I'm not really sure what to do at this point. Any help is appreciated.

The @generated isn't a big issue.
the problem is some tests using powermockito. The ones I've checked were
using it to go around (perceived?) limitations of rescu.
I'll have a another look at them and if they don't test to much, and
mocking up rescu is really necessary, I'll go ahead and make a PR to make
it possible with standard mockito.
On 19 Feb 2018 8:55 a.m., "Tim Molter"<EMAIL_ADDRESS>wrote:

We had similar issues to this when upgrading to Java 8.
Here's a related thread: grpc/grpc-java#3633
https://github.com/grpc/grpc-java/issues/3633
I'm not really sure what to do at this point. Any help is appreciated.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/timmolter/XChange/pull/2314#issuecomment-366624485,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADjyb3GMU1XuZExdsVzL2V3VxK44oza_ks5tWTcWgaJpZM4SHUDi
.

@timmolter right now it's failing on missing classes that I've just added to Rescu. Might be the cache on Travis or the new Rescu build is not yet in snapshot repo.
Anyway, even if it had compiled, it would still fail on Bleutrade tests as I've only refactored Bitmarket tests for now. I'll continue with the rest of failing exchanges in the coming days unless you want to do a code review and have any remarks.

Take your time. :) There is a new PR in the queue relying on Powermockito. Should I merge it and then you remove it or ask them to remove it before I merge the PR?

@timmolter, If you're talking about https://github.com/timmolter/XChange/pull/2356, I'm happy to remove the test altogether, however, writing the test without PowerMockito is probably too hard right now.

@brilliantnut I'd rather you keep the test and have it merged, it's easy enough for me to refactor it later on. I'll be merging from master every now and then anyway.

@brilliantnut Actually, you could change to standard Mockito once my the latest Rescu snapshot lands in public repo.
@mmazi, can you offer some help on this? I thought develop builds would deploy to snapshot repo. Did I miss something?

@rafalkrupinski merging my PR would also require merging your dependency changes in the parent pom.xml or me duplicating those changes in my PR. As my PR is already ready to merge, and this one is some way out, I feel that we should merge mine now, and then you include that in your refactoring later.
@timmolter your thoughts?

@mmazi, can you offer some help on this? I thought develop builds would deploy to snapshot repo. Did I miss something?

I've re-run the Travis build and the new snapshots are now available.
(There's a test in rescu that occasionally fails that has prevented push to snapshot repo.)
You should make sure, however, that you're using the 2.0.2-SNAPSHOT version of rescu. (I think the develop branch of XChange now uses 2.0.1.)

Splitting to smaller PRs to avoid long-running branch and conflicts


bug: Plugins broken with latest framework and crosswalk

Type: bug
Ionic Version: 1.x
Platform: android 5.0 webview
I installed the latest cordova, ionic, gulp and bower.
I created a new tabs application, I added crosswalk plugin.
When I deployed to mobile device I got "deviceready has not fired after 5 seconds" error. I removed "cordova-plugin-device", redeployed to the phone and the error was fixed. There is an issue with this key plugin and crosswalk.
Futher testing shows that using "cordova-plugin-network-information" also gives "deviceready has not fired after 5 seconds" error. The "cordova-plugin-camera" doesn't give an error but does not actually work with latest ionic/crosswalk.

This issue was moved to driftyco/ionic-native#762


Images with spaces don't work

Hi, thanks for great addon
It seems if you have images with spaces they are not processed correctly,
such images displayed as simple text

also, is there any chances of implementing custom width for images?

I think the issue might be with the alt text format. It is only matching images on ![[path/to/img.png]].
Foundry uses showdown for markdown-to-html, and it does support custom image widths, but I am not sure if they let you set the dimensions using the width only like Obsidian does. I'll look into it!

Oh it looks like the space is also a problem. Might be something with showdown. Now I've found two issues!

but I am not sure if they let you set the dimensions using the width only like Obsidian does

just checked, if you edit imported file, and add  =200x* to file path, it will render image with corresponding width value on image
### Resized
![obsidian_banner.png](assets/cos/uploads/obsidian_banner.png =200x*)

If you update to the latest version 2.1.0 (not to be confused with 2.0.1) this should be resolved. Added in support for resizing images, too!


Check Current Server Version Not Work

I try use function CheckCurrentServerVersion to get new version but not work because default version web whatsapp can not be used. So on session.go file, I change default WA version like this
var waVersion = []int{2, 2123, 7}
and it works

sadly we need to keep up with the whatsapp web version in order for this to work


Azure Storage Explorer is unusable due to AAD guest accounts (improve multi tenant sign in experience)

Storage Explorer Version: Using the latest 1.12.0.
Build Number: 20200116.10
Platform/OS: Windows 10
Architecture: x64
Regression From:  Unknown
Same results on multiple machines, with or without using the Microsoft Authentication Library (MSAL Preview).
Bug Description
Guest membership in other AAD tenants can make it impossible (or at least nearly so) to use Azure Storage Explorer.
Steps to Reproduce

From the "Account Management" screen, click "Add an account...".
Choose to "Add an Azure Account" from the "Azure" Azure environment.
Login once as my AAD login, including MFA.
Be continuously prompted a 10+ times for logins into additional AAD tenants where I've been added as a guest account, due to having their own MFA requirements set, Conditional Access Policies, etc.  It is not even clear what tenant I'm being prompted for (no tenant name or ID shown), unless indicated by custom tenant branding (background picture, etc.).  Many of these tenants do not even have Azure subscriptions.  Some logins may produce failures, due to the guest account being blocked or considered "at risk", etc.

This is the using same Microsoft Partner account that I've been using daily and elsewhere (Azure Portal, Azure CLI, PowerShell, etc.) for over 2 years without similar issues elsewhere, even with the contributing factors listed above (account is blocked in one or more directories).  These issues are specific to using Azure Storage Explorer.
Expected Experience
Azure Storage Explorer needs to provide an option to select which tenant(s) to attempt to login to.  Even if only as a supported configuration file.
Actual Experience
Any failure on any login to any tenant results in either the account failing to be added, or the error flow where "subscriptions for one or more tenants could not be retrieved" - in which case the filter checkboxes underneath the account are not even displayed.  Instead, only a "Reenter credentials" link is displayed, below "Subscriptions could not be loaded.  Please try reentering credentials or removing and readding the account."
Furthermore, the "Explorer" view get stuck in a state where it does list one or more subscriptions, though not even the ones I need.  A "Load more" link is available - but when clicked, I get 2 pop-up error dialogs:

Unable to retrieve child resources.
The requested action could not be completed.

... both with "Details: [{}]".
Additional Context
Prior research / related tickets:

#159

Note Jouni's comment specifically about this practically being a denial-of-service issue.

#153

Not the most critically related to this, but the "use the account panel to filter out the subscriptions you aren't working with" proposed there is part of what disappears with the issues mentioned above.

#74
#2570

Hey @ziesemer , we are aware of the uptick in users who are guests in large numbers of tenants, each of which has their own variety of conditional access policies (including MFA). We have plans in the future for providing the experience you suggest, specifically being able to filter out tenants, and making it more clear which ones require MFA and letting you perform that MFA at a time of your choosing.
Unfortunately the auth libraries haven't quite caught up to this need, so for now providing such an experience is not possible for us. Once it is available we'll get that work done. Thanks for the patience!

Same issue for us for Azure Stack Hub subscriptions, we cannot log in with a Guest Account as you cannot pass a different tenant ID...

Same issue here, please fix this 👍

I've been involved with this issue for a while. I have multiple accounts with multiple tenants each and MFA on several of them. I would love to see this feature. One thing that helps me is going into Settings --> Sign-In and enabling Microsoft Authentication Library (Preview). I did have to log in to each account/tenant again, but it does a MUCH better job of not making me repeat each login multiple times.

This is being address in #460


Allow sub-dependencies in base optimizeDeps.include

Fixes #232
This tweaks the way we do our optimizeDeps.include slightly, allowing us to add '@storybook/addon-docs > acorn-jsx'.  I needed to change our filter function to use the resolution that vite does (see https://github.com/vitejs/vite/blob/67d164392e8e9081dc3f0338c4b4b8eea6c5f7da/packages/vite/src/node/optimizer/index.ts#L182-L199), but in the end I think this is more reliable than what we were doing before, anyway.
With this syntax in place, we might also be able to avoid optimizing the storybook deps themselves, like @storybook/addon-docs, which already has an ESM export and doesn't really need to be pre-bundled at all, only its sub-dependencies do.  I haven't changed anything like that in this PR, though, since I wanted to take it one-step-at-a-time.  The only change made to the list itself is the addition of '@storybook/addon-docs > acorn-jsx'.
I also needed to prevent the vue alias from being added unless vue is actually being used, or else vite threw an error when I tried to resolve the config.

Hmmm, the vue example might be broken, investigating.

I tested all of the examples, and they're working now.  👍

@IanVS One reason for preoptimizing ESM dependencies is that the number of files served to the browser is lower, since it's one chunk per dependency. If we stop pre-optimizing, that could slow down Storybook performance in the browser.

Is that still true even for node_modules?  I thought those were still bundled into vendor.js.

I guess it's worth doing an experiment, to see what happens in the browser.


stdnet Crate

Hi all, last year I submitted a RFC to get mac addresses added to the std lib, it wasn't a good fit, but after seeing the stdweb crate's trajectory and becoming a part of this effort I suggest we create a stdnet crate.
This crate will attempt to be the natural home for Structs, Parsers and sundry for re-usable datatypes in the networking area.
There is no reason why everyone should re-implement something like a TCP or IP header, for example.
There is a lot of prior art out there, if you have crates, parsers, etc that already cover this please indicate if you would be interested in a re-usable crate, what criteria it would have to meet and if you would be interested in contributing?
Also interested in what should be in such a crate, I would start with all the OSI layer 2 and 3 protocols.

@dlrobertson would something like this "stdnet" idea be appealing in the embedded space?

There is no reason why everyone should re-implement something like a TCP or IP header, for example.

My experience has shown that everyone who goes near this level will just implement it themselves. @dlrobertson mentions several implementations. Yes, it's always the same, but you want full control over it. And the difficult part is the protocols build on top, not the packets themselves (save the bit-shifting, but that's easy to write once then forget about).
Perhaps a more interesting thing to think about would be a way to have these different implementations interoperate. It would be amazing to have a way to compose packets from different libraries, whether they're high level abstractions over the packets, or zero-overhead views.
I think there's definitely room for a stdnet, but I also think it's very difficult to figure out what to put in one.

@mrmonday and @dlrobertson thanks for the excellent feedback - I agree with the challenges this could face, I would also suggest to keep it really simple. I would even go as far as just starting with the Types themselves, I noticed mio supports extensions, that could be a way to implement serialization and serialization. Having a standard set of Types will enable some code interop, then one can dive into specialisation (how to parse, and use).
Some base that can be shared around between crates, as well as a set of Enums, etc for the meanings of the bit flags - etc. Simple stuff. A little bit like the role the http fulfills could be a starting point?

I like this idea. Two comments:

Is it a good idea to have this in a single crate, covering all protocols at different levels of the stack is a very disparate set of data types that only some crates will need. Instead should it be an organization defining API standards and sets of tools to easily create different crates for different protocols. Alternative structure could be to have a single crate with different feature flags for different protocols.

I started a crate for CoRE parameters a while back. I think this seems like exactly the sort of thing that this crate could be covering (although it's application layer/application layer+ not the 2/3 mentioned above). The next step I haven't gotten around to yet is to add scripts to pull down the data from the registry and actually generate associated constants for the different parameters. Building a generic framework for these sorts of scripts is one piece that could definitely be useful.

I agree with @Nemo157 that this should be an organization (rust-networking?), not a crate. Different protocols don't really share much datatypes in my experience. And it seems against rust philosophy (many small crates) to put a lot of unrelated stuff in one crate.

Does anyone know what the implications are on resulting binaries on a split-crate with good module use (like std) strategy? It there is no real cost to having a central place for the re-usable parts it would be an argument for crate features? The embedded folks might be affected, but I'm not sure how smart the compiler is.


Add an option to override Swift endpoint URL

Fixes #50

Hi, thank you for PR. I think it looks good.
Can you please rebase on master? I updated CI to run tests on PRs https://github.com/Lirt/velero-plugin-for-openstack/pull/52.
Maybe we can also add a small test for ReplaceAccount() function.

@Lirt done

Hi @kayrus,
I added one commit with tests - I hope it's OK (if not you can remove it and do by yourself). If yes, please check if those tests make sense or update them.
I think the change is good overall and we can merge it you're fine with it.
I will add update versions afterwards and release as v0.5.0. I don't yet have release process in CI (will try to add it soon), so I'll need to do it manually.

Thanks. Tests are fine with me.
As for the clouds.yaml, the endpoint override must be implemented in gophercloud/utils first. And at first glance it's not so trivial as it looks like.

Oh. One more thing. Could you please replace a bucket term with a container? Logs that contain bucket term confuse with S3 buckets.

As for the clouds.yaml, the endpoint override must be implemented in gophercloud/utils first. And at first glance it's not so trivial as it looks like.

Hi again, so for now can we skip clouds.yaml integration and merge as it is?

Yes, for now I think we can skip clouds.yaml.

Thanks. When can I expect a new release?

I just released it :tada:.


⚠ RPC server - Binance BSCT has degraded performance

In cd223a5, RPC server - Binance BSCT ($BINANCE_BSCT_RPC_URL) experienced degraded performance:

HTTP code: 504
Response time: 10622 ms

Resolved: RPC server - Binance BSCT performance has improved in c4e51c4.


Could we get a little more docutmentation addd for using this plug-in

I have my etherium wallet, but I'm not seeing where to put the provider and account show in the ledger.

You can have a look at https://github.com/interledger/interledger/wiki/Interledger-over-ETH


Improve Windows support.

SublimeText does not seem to include the \r in its internal representation of files using Windows line endings. This behavior causes GoGuru to send the wrong position information to the guru command.
This PR adjusts the offsets accordingly.

Also, some of the path operations were not Windows friendly.

thanks Chris!

Thank you for putting this together. I am a big go oracle user and want to switch to guru. No I can. I had made an attempt at what you've done here but couldn't quite get it all working.


Daemon does not own pool address

the address is owned by the pool wallet... I don't understand why it say it dosent own it.. I tried to erease wallet and close it reopen it change address for the new one but it still didnt work..
2019-12-09 11:33:07 [Payments]  [cpuchain] Daemon does not own pool address - payment processing can not be done with this daemon, {"isvalid":true,"address":"Cxxx9","scriptPubKey":"xxx","isscript":false,"iswitness":false}

Hi
For coins newer than BTC0.17, you may need to add the following to the pool config json file
    "BTCover17": true,
    "_comment_BTCover17": "If BTC 0.17 or higher, payment does not work please enable it",

And some coins may not work with P2SH addresse, so create a P2PKH address to make it a pool address.
Please try as follows.
cpuchain-cli getnewaddress" "" legacy "
Will you try these?

great thx that works for me :)


EditorConfigFiles vs GlobalAnalyzerConfigFiles

In https://github.com/dotnet/roslyn-analyzers/pull/3538/files#diff-c60b9590bdd1233ac95b74385a74024dbdfa9cde59acc6ec97f222b2c1dcd3d4R336, there is a change from GlobalAnalyzerConfigFiles to EditorConfigFiles.
Was the option renamed at some point? Which option is supported in which version? Or are will work?
cc: @mavasani

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ddb7b648-6f01-eaeb-1292-4baee5ae0666
Version Independent ID: cb44b30a-3fcc-3384-3fcd-1ac2675bf470
Content: Configuration files for code analysis rules - .NET
Content Source: docs/fundamentals/code-analysis/configuration-files.md
Product: dotnet-fundamentals
GitHub Login: @gewarren
Microsoft Alias: gewarren

@Youssef1313 Both property names should work. Please see https://github.com/dotnet/roslyn/blob/8637000fc35f01a453349147b71d5ecdae8d0bff/src/Compilers/Core/MSBuildTask/Microsoft.Managed.Core.targets#L80-L90. We can consider updating roslyn-analyzers post build tool to use GlobalAnalyzerConfigFiles for clarity.

@mavasani Thanks for clarification. Should both be documented?

GlobalAnalyzerConfigFiles is the only one that should be used by end users. Editor config files are implicitly discovered by compiler/project system, so EditorConfigFiles is primarily an implementation detail.

Thanks. I was confused by https://github.com/dotnet/aspnetcore-tooling/pull/3087/files#diff-50e91c82311ea26f2a73202525dfdf2b0a89c178ee666b2bf3ad4c84ac4c06dcR42.
Since the documentation is correct, I'll close.
Thanks again.


feat: create a mongodb cluster

Improve the current MongoDB deployment to support clustering.

You should add a line in the CHANGELOG


scheduler: fix disk allocated not balanced

这个 PR 实现什么功能/修复什么问题:
修复：调度器磁盘分配不均匀
是否需要 backport 到之前的 release 分支:

2.12

/cc @wanyaoqi

/area scheduler

Codecov Report

Merging #5511 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5511   +/-   ##
=======================================
  Coverage    6.87%    6.88%
=======================================
  Files         610      610
  Lines      103153   103153
=======================================
+ Hits         7088     7097    +9
+ Misses      95494    95483   -11
- Partials      571      573    +2

Flag
Coverage Δ

#aFlag
6.88% <ø> (+<0.01%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/cloudcommon/db/lockman/fifo.go
80.00% <0.00%> (-10.00%)
:arrow_down:

pkg/cloudcommon/cronman/cronman.go
54.85% <0.00%> (+5.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a3edfc...4f3d7c2. Read the comment docs.

/lgtm

/approve


cmd/compile: crash on an unusual program

What version of Go are you using (go version)?

$ go version
go version go1.18 linux/amd64

What did you do?

package main

func main() {
	_:
	_: // internal compiler error: label missing tag
}

What did you expect to see?
Compiles okay.
What did you see instead?
Fails to compile.
# command-line-arguments
./main.go:5:3: internal compiler error: label missing tag

Please file a bug report including a short program that triggers the error.
https://go.dev/issue/new

CC @golang/runtime.

Seems, the current implementation removes labels after processing them in func (e *escape) stmt(n ir.Node), so the 2nd blank label could not be found.


substrate-api-client is reporting a RuntimeMetadata:V12 even though I'm running it against a substrate-node with RuntimeMetadata:V14 in the source code.

I expected this error due to version disparity.
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: InvalidMetadata(InvalidVersion)

But when I debug the meta variable, it shows that it is reporting V12 variant.
metadata: RuntimeMetadataPrefixed(1635018093, V12(OpaqueMetadata([24, 83, 121, 115, 116, 101, 109, 1, 24])))

So the current master branch of substrate-node-template uses substrate branch polkadot-v0.19.20.
I grep that code of substrate for "RuntimeMetadata" and only see RuntimeMetadata::V14(metadata) and not of the V12 variant.
I also see that substrate-note-template is explicitly specifying v14 feature in it's Cargo.toml config.
frame-metadata = { version = "15.0.0", features = ["v14"], package = "frame-metadata" }

I'm baffled by this issue, because I couldn't wrap my head of where the reported V12 variant could have come from?

It turns out that if I put --dev as flag in running substrate-node-template, this error would not occur. Good thing I can now run the client against the substrate chain, but I'm still not quit sure if this is an intended behavior when --dev is used as a flag

This is still very weird. Have you checked if there is a diff in the metadata, when you use the flag?
(We use the api-client on our end with different nodes without dev flags, and we never had an issue like this).

I think I've found the issue. Without the --dev flag the substrate chain is using the old database located at <home>/.local/share/node-template/chains/local_testnet/db/full.
Using the --dev it creates a new database at a /tmp directory with a unique folder, so it is not reused in the next runs.
I issued a purge using cargo run --release -- purge-chain which removes the old data files from my previous runs. I'm suspecting the old database has the metadata stored there which at that time was at RuntimeMetadata::V12.
This would have been prevented also if I did all of this test in Dockerfile for ultimate reproducibility.
TLDR: issue a cargo run --release -- purge-chain to prevent this issue.


templates: Remove post hook init hack when CNI is disabled.

Didn't render anway...

This repository allows merge commits, if you're creating a Release, make sure to select 'Squash and merge'
When merging subtree updates, it is important to select 'Create a merge commit' when merging.

Title says it all. The hack is not required as long as there is another init container around.
Checklist

[x] Automated test are working (for chart changes)
[x] I am confident my changes don't break existing installations (for chart changes)
[x] Changelog entry has been added

CC @pipo02mix. WDYT?

No, you did not add the hack to the identity component at all.


AUR package issue with PGP key

~ ✗  paru -S ctpv-git
:: Resolving dependencies...
:: Calculating conflicts...
:: Calculating inner conflicts...

Aur (1) ctpv-git-r146.2d36fa4-1

:: Proceed to review? [Y/n]:

:: Downloading PKGBUILDs...
 PKGBUILDs up to date
 nothing new to review
fetching devel info...
==> Making package: ctpv-git r146.2d36fa4-1 (Sat 02 Jul 2022 09:24:21 CEST)
==> Retrieving sources...
  -> Updating ctpv git repo...
==> Validating source files with sha512sums...
    ctpv ... Skipped
==> Verifying source file signatures with gpg...
    ctpv git repo ... FAILED (unknown public key 6E656AC5B97B5133)
==> ERROR: One or more PGP signatures could not be verified!
error: failed to download sources for 'ctpv-git-r146.2d36fa4-1':
error: packages failed to build: ctpv-git-r146.2d36fa4-1

Could you run gpg --recv-keys 6E656AC5B97B5133 and see if it works?

~ ✗  gpg --recv-keys 6E656AC5B97B5133
gpg: key 6E656AC5B97B5133: public key "Nikita Ivanov (Git and GitHub<EMAIL_ADDRESS>imported
gpg: Total number processed: 1
gpg:               imported: 1

~ ➜  paru ctpv
1 aur/ctpv-git r146.2d36fa4-1 [+0 ~0.00]
    Terminal previewer
:: Packages to install (eg: 1 2 3, 1-3):
:: 1
:: Resolving dependencies...
:: Calculating conflicts...
:: Calculating inner conflicts...

Aur (1) ctpv-git-r146.2d36fa4-1

:: Proceed to review? [Y/n]:

:: Downloading PKGBUILDs...
 PKGBUILDs up to date
 nothing new to review
fetching devel info...
==> Making package: ctpv-git r146.2d36fa4-1 (Sun 03 Jul 2022 13:53:36 IST)
==> Retrieving sources...
  -> Updating ctpv git repo...
Fetching origin
==> Validating source files with sha512sums...
    ctpv ... Skipped
==> Verifying source file signatures with gpg...
    ctpv git repo ... FAILED (the public key 701DE74D84F87EE1BC91CD216E656AC5B97B5133 is not trusted)
==> ERROR: One or more PGP signatures could not be verified!
error: failed to download sources for 'ctpv-git-r146.2d36fa4-1':
error: packages failed to build: ctpv-git-r146.2d36fa4-1

Okay I changed the trust of the key as shown here
Now I get the following build error:
==> Making package: ctpv-git r152.2220d63-1 (Tue 05 Jul 2022 13:26:51 IST)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> WARNING: Using existing $srcdir/ tree
==> Starting pkgver()...
==> Removing existing $pkgdir/ directory...
==> Entering fakeroot environment...
==> Starting package()...
cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -O2 -MD -Wall -Wextra -Wno-unused-parameter   -c -o src/config.o src/config.c
make -C embed
cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -O2 -MD -Wall -Wextra -Wno-unused-parameter   -c -o src/error.o src/error.c
cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -O2 -MD -Wall -Wextra -Wno-unused-parameter   -c -o src/lexer.o src/lexer.c
make[1]: Entering directory '/home/adam/.cache/paru/clone/ctpv-git/src/ctpv/embed'
cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -O2 -MD -Wall -Wextra -Wno-unused-parameter  -L/usr/lib -lmagic -lcrypto  embed.c   -o embed
cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -O2 -MD -Wall -Wextra -Wno-unused-parameter   -c -o src/preview.o src/preview.c
src/preview.c: In function ‘run’:
src/preview.c:134:13: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  134 |             write(STDOUT_FILENO, buf, len);
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -O2 -MD -Wall -Wextra -Wno-unused-parameter   -c -o src/server.o src/server.c
cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -O2 -MD -Wall -Wextra -Wno-unused-parameter   -c -o src/shell.o src/shell.c
make[1]: Leaving directory '/home/adam/.cache/paru/clone/ctpv-git/src/ctpv/embed'
cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -O2 -MD -Wall -Wextra -Wno-unused-parameter   -c -o src/ulist.o src/ulist.c
cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -O2 -MD -Wall -Wextra -Wno-unused-parameter   -c -o src/utils.o src/utils.c
src/shell.c:6:10: fatal error: ../gen/helpers.h: No such file or directory
    6 | #include "../gen/helpers.h"
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [<builtin>: src/shell.o] Error 1
make: *** Waiting for unfinished jobs....
src/server.c:12:10: fatal error: ../gen/server.h: No such file or directory
   12 | #include "../gen/server.h"
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [<builtin>: src/server.o] Error 1
==> ERROR: A failure occurred in package().
    Aborting...
error: failed to build 'ctpv-git-r146.2d36fa4-1':
error: packages failed to build: ctpv-git-r146.2d36fa4-1

Note: I was able to use ctpv fine by just cloning and running sudo make install, but it would be nice to use the AUR package

Could you try building and installing the package without paru?
git clone https://aur.archlinux.org/ctpv-git.git
cd ctpv-git/
makepkg -si

makepkg -si  didn't work until I added options=('!makeflags') to the pkgbuild (source)
I have the following flags:
export MAKEFLAGS="-j$(nproc)"

Which comes from this section in the arch wiki.
Clearing this with export MAKEFLAGS=, and then running makepkg -si works fine.
So the issues seems to be with trying to compile in parallel.
It looks like the solution to the problem could be forcing single threaded in the pkgbuild, which the wiki section describes.

Indeed, I just tried to use the -j option and it failed to compile too. Thank you for finding the bug! I will not make any changes to the PKGBUILD because I managed to fix the bug in the Makefile (now -j option doesn't break anything).


Default log entry labels with HTTP context info

Would you consider a default ILogEntryLabelProvider implementation (or multiple) which populate some labels related to an HTTP request useful for searching and correlating logging entries? It could be registered when you use UseGoogleDiagnostics() by default. I was thinking of the following values:

The HTTP TraceIdentifier
The HTTP user identity name

Might be a privacy issue, perhaps make configurable or just whether a request was authenticated

Grab the exception from IExceptionHandlerPathFeature (when available) and add the exception type/message

I find myself adding this provider to all of my projects hosted in GCP:
public void Invoke(Dictionary<string, string> labels)
{
    var httpContext = _httpContextAccessor.HttpContext;
    if (httpContext == null)
    {
        // Not in the scope of an HTTP request
        return;
    }

    // Add the trace identifier to correlate log entries from a single request
    labels["trace_identifier"] = httpContext.TraceIdentifier;

    // Add authenticated user info
    if (httpContext.User?.Identity?.IsAuthenticated == true)
    {
        labels["user_authenticated"] = bool.TrueString;
        labels["user_name"] = httpContext.User.Identity.Name;
    }

    // Add any exception info when available to quickly inspect
    // and filter exceptions in the GCP Logging console
    var exceptionFeature = httpContext.Features.Get<IExceptionHandlerPathFeature>();
    var exception = exceptionFeature?.Error;
    if (exception != null)
    {
        labels["error_path"] = exceptionFeature.Path ?? "N/A";
        labels["error_type"] = exception.GetType().FullName;
        labels["error_message"] = exception.Message;
        labels["error_stacktrace"] = exception.ToStringDemystified();
    }
}

What are your thoughts about this?
cc @iantalarico

@henkmollema Definitely think this would be useful.  I need to think about this a little more in the context of defaults and privacy.

@henkmollema Thinking about this a little more I don't think we should put any of these in UseGoogleDiagnostics as adding a small amount of info to each log can add up (and logs aren't free).  It also would be pretty easy to add these after the fact.
I think splitting this up into 3 separate ILogEntryLabelProviders would be a good move.
I'm still want to think a little more about the User parts but I think it should be okay if we don't put it as a default.
@henkmollema Thoughts?

@iantalarico personally I think at least having a trace ID by default to correlate logs per request would be really useful. Today the logs for ASP.NET Core apps are just a big list of entries and it can be pretty difficult to correlate those messages.
I agree the other providers should be optional (and therefore split up).
As for the adding the exception information, I forgot about a little issue I ran into:  it requires for the IExceptionHandlerPathFeature to be set on the HTTP context. However, by default nothing is logged after it's being set. The ExceptionHandlerMiddleware of ASP.NET logs  its latest message before it's being set. In my own application I solved this by subscribing to the Microsoft.AspNetCore.Diagnostics.HandledException event of the diagnostics source and log another 'exception unhandled' message which causes the labels to be correctly populated. Although I personally find it useful, it might be out of scope and too opinionated  for this library. What do you think?

For what's it worth: I think beging able to filter log entries like this is pretty nice:

@henkmollema I think you are right about the trace ID. I'm okay to add it to UseGoogleDiagnostics as long as it's well documented.
As for the error reporting bits I think that's doing a little too much.  I'd rather keep the library to a small core set.

@iantalarico I agree. Have you thought about adding a label for authenticated users as well?

@henkmollema I think it's okay as long as it's never a default.
@jskeet Jon do you see any issues here?

Would the ILogEntryLabelProvider implementation just be available as public class or should we add an extension method to easily configure it. Such as AddUserInfoLoggingLabels() or something. If so, would it be an extension on IWebHostBuilder or IServiceCollection?

I think it should just be a public class.  It's really only 1 line of code and I think would get confusing otherwise.  This makes adding more in the future easy, we can just dump them in a shared folder.

Sounds good to me, I'll see if I can find some time this week to implement this 👍

@henkmollema Awesome, thanks!


Add Traditional Chinese translations

@sshane  thanks! :)

Thanks for the helpful comments!

This needs to be based against master, fixed here: https://github.com/commaai/openpilot/pull/25086


Adding Docker Support on an Existing 4.7.2 application does not change deploy options

I had an existing .NET 4.7.2 web application that I was going to containerize. I went through the built-in "Add Docker Support" option in Visual Studio 2019, and that worked great. It added the Docker file and I can debug in the container. However, when I looked to publish the image to ECR I realized that I do not have any of the expected AWS container support, and the only AWS publish option is to Elastic Beanstalk.
Thinking this was because of something in the app, I retried it with a sample ASP.NET 4.7.2 application created from VS template. Same behavior. Even though the application is now "container-bound" it is not treated as such by the Toolkit.
Edit: The same behavior is happening when using an already containerized 4.7.2 application. However, this means that I can not easily get these containers into ECR and that's a problem.

Hi @w-penberthy , the "Publish Container to AWS" feature in the Toolkit only has support for publishing .NET Core applications in Linux based containers. This is similar to the dotnet extensions for ECS tooling.


Update Model Version Information

This PR contains daily documentation updates based on the following suggestion: The documentation references gpt 4 turbo but should be updated to mention the change to gpt 4o, reflecting the latest default model version used in the codebase. Additionally, the use of Gemini's beta API features should be prominently marked as unstable and not recommended for production. These changes should be reflected in both the README and relevant config documentation.

there's a huge disconnect between the suggestion and the changes here..


syntax highlighting fails in new anonymous object with LINQ

Defining a new anonumous object having a field valued by LINQ breaks syntax highlighting.
Steps to reproduce: write the following code
public class Program {
    [Attribute1]
    [Attribute2(P = 1)]
    public static void Main(string[] args) {
        for(int i = 0; i < 10; i++) {}
        var a = new {Field1 = from a in b select a}};
        for(int i = 0; i < 10; i++) {}
    }
    [Attribute1]
    [Attribute2(P = 1)]
    public static void Method() {
    }
}

Note: found out that if i put parentheses around the LINQ it is fixed, but i think it should be working without the parentheses either, because the code also works that way!

It´s not just with Linq, it happens with any anonymous type.

happening here as well

Any update on this?

Since this issue was opened we have added semantic highlighting support as well as a much improved textmate grammar.


[Issue 13019][es-sink] Support event-time-based index name in ES Sink

Fixes https://github.com/apache/pulsar/issues/13019
Motivation
As described in the original issue, it's a common request to write data to event-time-based indices in logs and metrics use cases, therefore it would be very helpful to have builtin support in the ES sink.
Modifications
Describe the modifications you've done.
Verifying this change

[ ] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:

Added test cases for index name formatter

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)

Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[ ] no-need-doc
(Please explain why)

[x] doc
(If this PR contains doc changes)

Discussed w/ @fantapsody

@fantapsody  will add docs to Elasticsearch sink connector - configuration table

@fantapsody suggests generating configuration tables automatically rather than updating them manually. I've discussed w/ @urfreespace, found it is workable, and recorded an issue here.

@eolivelli @freeznet @nlu90 @tuteng Could you please take a look?

@tuteng @fantapsody @codelipenghui this pull is not present in Pulsar 2.10. I believe it has not been cherry-picked to branch-2.10 at all
I don't see it in the 2.10 release notes so there's no confusion for users. https://pulsar.apache.org/release-notes/#2100


Add cases for new flow parser AST statements

A pair of recent Flow commits have added some new AST types, DeclareTypeAlias and DeclareInterface. My recent local build of ReasonablyTyped started failing because the types of our test declarations have changed. Did you get this behavior too? If not, is it just that jbuilder doesn't constrain versions closely?
Anyway, this allows for those new types. I'm PRing it in case I've missed a piece of jbuilder arcana, since I assume builds with an older version of flow will fail if I just merge it.
P.S.  CI build is in fact failing; I assume it's the cached flow version of 0.47 instead of my 0.52. Maybe this is a good time for me to understand jbuilder; are we just not pinning versions? Do we just wipe the CI cache, or do we pin to an old flow version?
(Sorry for leaving it to you; severe ocaml ecosystem naivete!)

I'll check on this tonight 😊 Thanks for pointing it out!
What do you get when running "opam list"?

My flow_parser is at 0.52.0. In case you happened to want the entire list (!) may as well dump it below:
(big props to pbcopy for actually truncating the output to the width of my console window :| )
# Installed packages for 4.04.0:
base-bigarray                  base  Bigarray library distributed with the OCaml
base-bytes                     base  Bytes library distributed with the OCaml co
base-threads                   base  Threads library distributed with the OCaml
base-unix                      base  Unix library distributed with the OCaml com
biniou                        1.2.0  Binary data format designed for speed, safe
camomile                      0.8.5  A comprehensive Unicode library
cmdliner                      1.0.1  Declarative definition of command line inte
conf-m4                           1  Virtual package relying on m4
conf-which                        1  Virtual package relying on which
cppo                          1.5.0  Equivalent of the C preprocessor for OCaml
easy-format                   1.2.0  High-level and functional interface to the
flow_parser                  0.52.0  The Flow parser is a JavaScript parser writ
gen                             0.4  Simple and efficient iterators (modules Gen
jbuilder                 1.0+beta11  Fast, portable and opinionated build system
js_of_ocaml                     3.0  Compiler from OCaml bytecode to Javascript
js_of_ocaml-compiler            3.0  Compiler from OCaml bytecode to Javascript
lambda-term                    1.11  Terminal manipulation library for OCaml
lwt                           3.1.0  Concurrency based on promises
lwt_react                     1.1.0  Helpers for using React with Lwt
menhir                     20170418  LR(1) parser generator
merlin                        3.0.2  Editor helper, provides completion, typing
merlin-extend                   0.3  A protocol to provide custom frontend to Me
ocaml-migrate-parsetree       1.0.2  Convert OCaml parsetrees between different
ocamlbuild                   0.11.0  OCamlbuild is a build system with builtin r
ocamlfind                     1.7.3  A library manager for OCaml
ppx_tools_versioned           5.0.1  A variant of ppx_tools based on ocaml-migra
re                            1.7.1  RE is a regular expression library for OCam
react                         1.2.0  Declarative events and signals for OCaml
reason                        2.0.0  Reason: Meta Language Toolchain
reason-parser                 2.0.0  Reason Parser: Meta Language Toolchain
result                          1.2  Compatibility Result module
sedlex                       1.99.4  unicode-friendly lexer generator
topkg                         0.8.1  The transitory OCaml software packager
uchar                         0.0.2  Compatibility library for OCaml's Uchar mod
user-setup                      0.6  Helper for the configuration of editors for
utop                          2.0.1  Universal toplevel for OCaml
yojson                        1.4.0  Yojson is an optimized parsing and printing
zed                             1.5  Abstract engine for text edition in OCaml

Looks like it still wants to install 0.47 without cache 🤔

Looks like the docker image we're using for build is out of date for Opam! Also, the build system is kind of a hack right now, we're not using jbuilder to install deps. Just running an opam command manually!
I'm running the build locally to see if running opam update before opam install fixes the problem!


Bibtex

Hey Alexandre,
Thank you so much for your work in this repo! We are using it right now for our research because it allows us to change different components in Mamba much more flexibly than in the CUDA or now triton code for Mamba 2.
Could you put a bibtex in the readme so that we can give you proper attribution?
Best,
Julien

Hello Julien,
It's done, right at the end of the readme.
Also, thank you for taking the time to do it! This is a great honor for me and I'm pleased my work helps.
Best,
Alexandre

Congrats for the paper!
Wow, I wish I had more time to try out all the things that got published recently.
Wishing you the best of luck for the acceptance!


Inaccurate Value generated in offchain code datum

I have datum defined in my contract as such
struct Datum {
    sender: PubKeyHash
    recipient: PubKeyHash
    exchange_for: Value
}

When I generate the datum in offchain code like so:
const heliosDatum = new EscrowProgram.types.Datum(
    helios.hexToBytes(helios.Address.fromBech32(sender).pubKeyHash.hex),
    helios.hexToBytes(helios.Address.fromBech32(recipient).pubKeyHash.hex),
    helios.Value.fromCbor(helios.hexToBytes(recipientValue))
  );

Note that recipientValue above is a CBOR hex string of a Value created from Cardano Serialization Library and not a Helios Value therefore it had to be converted.
The resulting Value of the datum contains only the non-ADA assets even though the recipientValue is the CBOR hex string of the full value I'm interested in, including ADA. Indeed if I run console.log(helios.Value.fromCbor(helios.hexToBytes(recipientValue)).lovelace.toString()); I do get the full value including ADA and native tokens printed to console. The ADA portion just doesn't get included in the datum somehow.
I've tested a few different scenarios and it seems like if recipientValue contained only ADA or only native tokens, the Datum will be correct. However if it included both ADA and native tokens, the Value in the Datum will ignore the ADA portion.

I'm unable to replicate this using just the _toUplcData() method, so that part seems to be correct.
Do you have a more complete case with which I can replicate this?


Spouts are not working with CRIO

 Freshdesk Ticket ID: 254
 Freshdesk Ticket Agent: Dale Georg
 Freshdesk Ticket Agent Email<EMAIL_ADDRESS> Ticket Priority: Medium
 Freshdesk Ticket Description:
When attempting to create a spout pipeline, the init container fails to start with the following error in the pod:
"Warning  Failed     1s (x4 over 43s)  kubelet            Error: failed to create containerd task: OCI runtime create failed: container_linux.go:370: starting container process caused: process_linux.go:459: container init caused: rootfs_linux.go:59: mounting "/var/lib/kubelet/pods/7f143d92-2f82-423e-a117-e3b5d6141eec/volumes/kubernetes.io~secret/pachyderm-pachctl-secret" to rootfs at "/run/containerd/io.containerd.runtime.v1.linux/k8s.io/user/rootfs/pachctl" caused: not a directory: unknown"

Current workaround is to implement the spout as a a service outside of Pachyderm, which is not the preferred way.

Agent Dale Georg linked Freshdesk ticket 254 for this issue.


Documentation Linting and Image Size check

Is it worth putting in a documentation lint using vale.sh (https://vale.sh) and perhaps put @hturner's image script for some simple checking? This could be customised in future needs.

The image script was merged and I think it is the main tasks, unless anyone else disagrees?


Added mail to link at contact section

I have added the mail to link on the email address present at the contact section so the user can directly contact via click.

Issue Number is #49

@Kratika-Solanki please share a screenshot or screen record and please let me know that you update the sync fork.


Remove ms-appx:// from the Source

Hi,
Why do we need to add ms-appx:// when playing a local file?
<MediaElement Source="ms-appx://XamarinShow_mid.mp4" />
It will be great if you just change it to:
<MediaElement Source="XamarinShow_mid.mp4" />
and let Xamarin Forms itself to add the ms-appx://
Thanks,
Jassim

Thanks for your suggestion!
I see a couple of issues with this though; this should happen only for UWP. I think adding the ms-appx:// is a common practice whenever you want to access something within your app. I can also imagine scenarios where you might want to get it from maybe your filesystem with C:\ etc.
To be honest, I don't think the gain outweighs the costs here with all the potential bugs and unwanted behavior. Seeing that this has been open since Feb and it hasn't gained a lot of traction I don't think the ask for this is very big, so closing this for now.
I hope you will propose other great enhancements in the future though, I have seen a lot of ideas from you Jassim! Thank you!


[Feature] Softer or harder shadow

I needed a softer shadow... so had to change the Elevation and TranslationZ on Android and ShadowRadius and ShadowOpacity on iOS.
Any ideas on how to elevate that to some properties on the PancakeView itself? Maybe 1 value from 0 to 10 and that it will use a small scale to change the values on the platforms?

PancakeView already has its own Elevation property which directly translates to Android and mimics Android behavior on iOS. That might be what you need. Since shadows are so different cross platform it’s hard to abstract more away. I’d gladly expose all shadow properties of iOS on Forms but I think 90% of it wouldn’t translate to Droid :(

The elevation prop was not helpful enough :/ but yeah this is a difficult one to fix for sure.
Maybe like XF itself expose a small set off platform specific properties would indeed be nice.

On iOS and UWP the following shadow related options exist:

Color
BlurRadius
Offset
Opacity

On Android we have:

Elevation
TranslationZ

The question is what is the cleanest option for PancakeView to support these? I could add simple properties for them meaning that they would cover iOS and UWP without problems. On Android, however, none of those properties would do anything. I could also go the "platform specifics" route and make them prefixed or attached properties per platform. Or maybe another approach altogether? 🤔

I've been thinking that the cleanest version of this is probably something like:
public class DropShadow
{
   public Color Color { get; set; }
   public int Offset { get; set; }
   public float BlurRadius { get; set; }
   public float Opacity { get; set; }
   public int Elevation { get; set; }
   public int TranslationZ { get; set; }
}

Only thing with this is that a dev needs to know the inner workings so that only a few will have impact on iOS and others only on Android.
But for me personally, this looks ok :)

Yeah, guess we could make something like Intellisense at least suggest some of that through comments. Obviously documentation on here would also reflect it. Not sure if there's much else we can do about  it since it tries to abstract something that doesn't share a whole lot in common while still remaining fully functional 😂

Made a start on this. I have one weird little binding thing that I can't figure out yet though. I implemented it as I mentioned above with a DropShadow class that inherits from BindableObject. This is then bound to a new bindable Shadow property on PancakeView. However, when updating values on the DropShadow class in XAML through binding the re-drawing trigger never fires because the OnElementPropertyChanged for PancakeView doesn't see that a property in the DropShadow class changed. I must be missing something, but if you have any pointers I'll gladly take them :)

Implemented in 1.4.2.

@sthewissen is there a way to set the shadow from a xaml style?
For instance I'd like to be able to do something like this:
<Style x:Key="card" TargetType="yummy:PancakeView">
	<Setter Property="yummy:PancakeView.Shadow">
		<yummy:DropShadow BlurRadius="2" Opacity="0.2" />
	</Setter>
</Setter>

This fails at runtime with an invalid case somewhere in the ctor of pancake view.

@Redth What device/platform are you running this on. Just did a quick test on iOS simulator and it seems to be doing what it should as you wrote it (with the end tag being Style). I'll give Android a try in the morning as I'd need to dig the device up from somewhere.

@sthewissen it was iOS as well (simulatior)... Perhaps I did something wrong somewhere else in my code for it.  If it's working for you then great, I'll figure out why it isn't here :)

U can grab some insipration for implementing the needed properties for android from here


How I can set a size for  element?

By default  has width and height at 100%. How can I change it?

You can actually use these as configurable parameters. Whether that's new or not I don't know.
Example (obviously substitute 500px for whatever you'd like):
'''
particlesJS('particles-js', {
canvas: {
w: "500px",
h: "500px"
},
// rest of code
});
'''

@SamHH I think that it's already been, because releases not contain information of this method. But I don't know about that. Thanks!

Here's what worked for me:
/* particlesJS.load(@dom-id, @path-json, @callback (optional)); */
    particlesJS.load('particles-js', '/vendors/particles.js-master/particles.json', function() {
      let el = document.querySelector(".particles-js-canvas-el");
      el.setAttribute("height", "300px");
    });


CacheBackend: Use a configurable setting to specify cache key

Using a static class variable allows applications using django-health-check as a 3rd-party package to read the key's identifier used to read/write the cache entry.
This is in particular useful, if the application needs to know which keys are written from other packages and are not part of the application logic itself.

@skarzi Any news on this? I've resolved the threads as no more work needs to be done.


[CI 3929] Render Browse Collections

[WORK IN PROGRESS] Just putting this up for an initial look over
Still need to do:

Add unit tests
Improve story
add breadcrumbs component (once merged)

We need to decide if we want it separate/together and clean up the unused parts.
@stanlp1 I agree. I think it would be a better development experience to have the Grid component determine if it should use Browse or Search data based on some conditions. Either by passing a prop or by determining it in some other way. If we still want to have two separate components, I'd still abstracting the UI part into a reusable thing to avoid all the duplication


Support for read rspack.config.* file

This may be more intuitive for Rspack users to configure Rspack, who do not need to know about tools.rspack.

This issue will be closed as Rsbuild currently has no plans to support this.


Update to version 0.6

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Not sure why the bot has not picked up the new version, but here is my manual upgrade.

@conda-forge-admin, please rerender

I think the reason the bot did not pick up the version update is may related to the source distribution file name change?

@conda-forge/pint-pandas this is ready for review.

@znicholls @dopplershift can we merge now?

Yep let's go for it


Print form field help text and error messages with proper line breaks

Fixes #182
Instead of doing a simple string concatenation, help text and error messages are now printed inside their own help text blocks.

Coverage remained the same at 86.431% when pulling a2c38675b9e854827050318b59fac830fbf0ecc7 on Matoking:develop into 1ad2686c3d6eb43a14463a0676809046937d5aec on dyve:develop.


Image appears before text when img command comes after text

Given the following document:
\begin{document}
\script[src=packages/image]
Here is some text!
\img[src=separator.png, width=100%fw]
\end{document}

The output is:

There are a couple of problems:

The image is appearing BEFORE the text
The image is showing up indented, and running off the edge of the page (ideally I'd want it centered)

The image and the text are appearing on the same line. Maybe add a \par command after the text, or use a blank line to start a new paragraph, like this:
Here is some text!

\img[src=separator.png, width=100%fw]

Note also that paragraphs have an indentation applied to them by default. If you don't want your image to be indented, say:
Here is some text!

\noindent\img[src=separator.png, width=100%fw]

Simon's explanation is spot on for how to do this, but just in case it wasn't clear what happened, in your example the image is not actually coming before the text. The paragraph is being built up with items that get typeset from left to right. The text is getting spit out first, then the image. Because the image is aligned to the baseline of the text, the line height for that line is being expanded to fit the image. The text that you see on the left is on the same baseline as the image, and the text is before the image.
Stuffing an object that is 100% the width of the frame into the middle of a paragraph that already has horizontal items (words) is going to cause a frame overflow condition as the line breaker cannot find any location to break the text inside it's allowed constrains (such as being able to stretch spaces).


Fix C# glue generation for enums with negative values

Fixes https://github.com/godotengine/godot/issues/73004
The error can also happen with 4.x, not just on 3.x.
Test patch I used to trigger this error:
diff --git a/servers/text_server.h b/servers/text_server.h
index af6efb8c7dd..0cb1103722d 100644
--- a/servers/text_server.h
+++ b/servers/text_server.h
@@ -70,7 +70,7 @@ public:
 	};

 	enum Orientation {
-		ORIENTATION_HORIZONTAL,
+		ORIENTATION_HORIZONTAL = -1,
 		ORIENTATION_VERTICAL
 	};

Cherry-picks fairly cleanly onto 3.x (it's just a small fix)

Thanks!

Cherry-picked for 4.0.4.

There are some conflicts when cherry-picking, I prefer not to hazard resolving them without fully understanding the code, so a dedicated PR would be welcome for 3.x if this is an important bugfix.


Clarity around permissions - statusCode: 500

If you work on multiple AWS systems already and need to reference an AWS profile you can add the following two lines into your create.js.
var credentials = new AWS.SharedIniFileCredentials({profile: 'myprofile'}); AWS.config.credentials = credentials;

@coingraham Thanks for letting us know. I'll add a note to the chapter.

Added c647d7b974f9ff6941aacbb0ac15232a18c216f1
Thanks!


Make the user guide for sharing more apparent

Request
As it's not clear how to contribute without first reading the User Guide, the User Guide link effectively becomes a critical part of the call to action. My request is to add the User Guide link somewhere in the top left of the Sharing Page, and also on the Sharing Gallery page.
Additionally, I think that 'Sharing Gallery' might be better just named 'Gallery', and 'Sharing' as either 'Share' or 'Contribute' to make it more of a call to action.
Motivation
People need to read the User Guide to figure it out, and currently, there is a lot to parse through (from left to right and waiting for the app to render) on the Sharing page before people get over to the small 'User Guide' link.

Drawbacks
No response
Alternatives
Make it more clear how to contribute to the gallery without having to send people out to the github user guide
Additional Context
No response

Regarding renaming the Sharing Gallery/ sharing_gallery to Gallery/gallery, I am a bit hesitant because those terms have been taken for the last two year by the normal awesome panel gallery of apps running on the server. So there would be thousand of links shared on social media, discourse etc that suddenly would not link to the correct gallery.

Closed by https://github.com/awesome-panel/panel-sharing/pull/35#issue-1460498995
I hope you will take a look at it @droumis and let me know if you see more quick wins. Thanks.


Number of posts per type are hardcoded

Number of posts per type are hardcoded.  For now, this was not a problem, but with the number of releases, this will make a lot of pages.  Better to get this straight from the settings as it should so we can adapt in the near future.
Solution:

Change the python code not to hard code this
Put it in a settings file

Fixed with change in python code and an extra settings yaml file


[color theme] color theme 'D3 category 10' is duplicated in explore

color theme 'D3 category 10' is duplicated in explore
How to reproduce the bug

Go to explore
Click on color theme
See error

Expected results
color theme is unique in the drop down menu
Actual results
D3 category 10 is duplicated in color theme
Screenshots

Environment
(please complete the following information):

browser type and version:
superset version: superset master
python version: python --version
node.js version: node -v
any feature flags active:

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

This doesn't seem to be the case any more.


Fix dependency build when use repository with basic authentication

What this PR does / why we need it:
helm dependency build now is not support dependencies repository URL with basic authentication.
here I have helm chart in Git Repo: https://codingcorp.coding.net/public/wangwei_test_cd/bookinfo/git.
Chart.yaml:
apiVersion: v1
appVersion: "1.3"
description: Nocalhost Bookinfo Helm chart for Kubernetes
name: nocalhost-bookinfo
version: 1.2.2

dependencies:
  - name: nocalhost-rattings
    version: 1.2.2
    repository<EMAIL_ADDRESS>
when I use helm dependency build, get error:
Getting updates for unmanaged Helm repositories...
...Successfully got an update from the<EMAIL_ADDRESS>chart repository
Saving 1 charts
Downloading nocalhost-rattings from repo<EMAIL_ADDRESS>Save error occurred:  could not download https://codingcorp-helm.pkg.coding.net/wangwei_test_cd/helm/nocalhost-rattings/nocalhost-rattings-1.2.2.tgz: failed to fetch https://codingcorp-helm.pkg.coding.net/wangwei_test_cd/helm/nocalhost-rattings/nocalhost-rattings-1.2.2.tgz : 401 Unauthorized
Deleting newly downloaded charts, restoring pre-update state
Error: could not download https://codingcorp-helm.pkg.coding.net/wangwei_test_cd/helm/nocalhost-rattings/nocalhost-rattings-1.2.2.tgz: failed to fetch https://codingcorp-helm.pkg.coding.net/wangwei_test_cd/helm/nocalhost-rattings/nocalhost-rattings-1.2.2.tgz : 401 Unauthorized

so this PR will fix this error. It will use repository URL with username and password for download chart, without 401 Unauthorized error
Special notes for your reviewer:
empty
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

As discussed in #9874, this introduces a number of significant security flaws. I provided solutions in the issue instead. But thank you for the PR.


Related issues about GEF file

What are the meanings of geneExp, wholeExp, stat, callExp (Opt) and Attributes in the GEF file format documentation ?
Thanks!!

geneExp

In each binX, there are expression and gene two datasets that work together to record the gene expression matrix. expression for (x, y, count) and gene for gene information (offset, row count). They are combined with the same row index.
wholeExp

In exch binX dataset, every position has been recorded, including non-expression ones. It is like a complete matrix.
stat
This dataset records the spatial pattern enrichment for genes.
callExp
This part is about the expression matrix at cellbin level, which was generated from the cell segmentation result.


Should we set the maximum value of the wind turbine & solar parks sliders to the total area of a region?

@MartLubben, @michieldenhaan and I just had a discussion about the maximum value of the wind turbine and solar parks sliders. Currently the max values are based on a potential that can be set in the AREA-file with the attributes land_available_for_solar and onshore_suitable_for_wind.
The disadvantage of this is that it prompts a lot of discussion while generating a dataset, especially when the dataset is generated together with a municipality. Another disadvantage is that it is a hassle to update it every time when the potential changes.
We propose to cap the sliders to the total area of the region. Then the discussion about available land will be postponed to the moment when the scenario is made and that would be better. Now the subject is discussed several times.
What do you think? @jorisberkhout, @DorinevanderVlies, @AlexanderWirtz, @ChaelKruip & @antw
We also thought about capping the sliders on the available arable land, but in that case there is a chance that it is too limited; for example for cities like Amsterdam that have space for wind/solar in the harbour.

We propose to cap the sliders to the total area of the region.

:+1:

I am not necessarily opposed, but in my opinion it just postpones the inevitable discussion to a later moment. It will also allow users who are not aware to set an amount of production capacity that is physically not possible. That seems at odds with our intention of the ETM.

That seems at odds with our intention of the ETM.

I'm not sure I agree with that.
The ETM allows many irrelastic settings (demolishing all houses, electric heat pumps in non-insulated houses, using loads of green gas, etc)
The difficulty about setting restrictions to settings is that opinions about these restrictions vary a lot. So when in doubt I would go a high max slider setting.

So when in doubt I would go a high max slider setting.

I agree. The total area is a nice objective upper limit: if you demolish everything and only build wind turbines, this is what you can do.

Currently the max values are based on a potential that can be set in the AREA-file with the attributes

How is this potential determined?

For some areas this is a researched number (e.g. from a GIS study from one of our partners). For most areas it is set equal to arable_land (which sometimes leads to problems as some areas have almost no arable land). I've had multiple requests tho to override specific researched numbers as they were deemed too 'limiting' in scenario sessions.

I say we change the potential to the total area. It's clear and well-defined and easy to research.
@marliekeverweij can you make this happen?

Yes I can!

@michieldenhaan and I just had a short chat about this issue and thought that it would not be safe to do this before the mini-deploy today, because we would like to test it first!
Our proposal would be to delete the area-attributes land_available_for_solar and onshore_suitable_for_wind and add one area-attribute total_area on which the slider max is based. This would mean that the slider would always allow enough wind turbines / solar parks, no more discussions when creating datasets!  🎉 For national datasets it will then be possible to place an unrealistic high number of wind turbines / solar parks, but users can do more stupid stuff as Dorine mentioned above:

The ETM allows many unrealistic settings (demolishing all houses, electric heat pumps in non-insulated houses, using loads of green gas, etc)

How to fix this issue:

[ ] Delete area-attributes land_available_for_solar and onshore_suitable_for_wind and add area-attribute total_area
[ ] Find data for all regional datasets (2 hr)
[ ] Update ETLocal: remove land_available_for_solar and onshore_suitable_for_wind and add total_area (1 hr)
[ ] Update all regional datasets (1 hr)
[ ] Find data for all national datasets (0.5 hr)
[ ] Update area analysis on ETDataset and update all country datasets (1 hr)
[ ] Update input statements for number_of_energy_power_wind_turbine_inland and number_of_energy_power_solar_pv_solar_radiation (0.5 hr)
[ ] Check for fall-out! {1.5 hr)

So this would cost about a day for one person!
Maybe we could integrate it in an upcoming development project, @ChaelKruip ?

Maybe we could integrate it in an upcoming development project, @ChaelKruip ?

Yes. We are trying to make a project happen where the focus is to make the ETM more suitable for local energy transition.

I have an other opinion. For wind turbines I agree that the most logical input is a unit. For solar parks the discussion is more about the area or MW of the park. The current unit of 20 MW and 20-30 hectares creates a lot of confusion and extra preparation for a session. Would people agree to change it to MW input, just like we do in the hydrogen sector?

I have an other opinion. For wind turbines I agree that the most logical input is a unit. For solar parks the discussion is more about the area or MW of the park. The current unit of 20 MW and 20-30 hectares creates a lot of confusion and extra preparation for a session. Would people agree to change it to MW input, just like we do in the hydrogen sector?

I will create a new issue for this, as your proposal is about the unit of the slider and this issue is about the max value of the slide.


Export step problem

Export step fail
After ruling the surface, the export step file failed at Serialize the Edge with cur3d is "Path". Because path not impl IExportStep interface.
Here's the testcase file.
test_ruled.cdb.json.zip

This error happens because CADability.GeoObject.Path does not implement IExportStep.
Thus the cast (curve3d as IExportStep) will return null.
Either implement the interface or use a safe cast.
https://github.com/SOFAgh/CADability/blob/24181919cb5678058b73b3900441a07a826c7ac9/CADability/Edge.cs#L3567-L3575
System.NullReferenceException
HResult=0x80004003
Message= Object reference not set to an instance of an object
Source=CADability
StackTrace:
at CADability.Edge.CADability.IExportStep.Export(ExportStep export, Boolean topLevel) in C:\Development\Repos\SOFAgh\CADability\CADability\Edge.cs:line 3572

It looks like my file containing only a circular surface might have the same issue.
CADability can import correctly but it cannot export the surface as a STEP file.  The export fails and programs like NIST STEP File Analyzer and Viewer cannot even parse the exported STEP file.  It looks like the EDGE_LOOP has no reference entity and the B_SPLINE_CURVE_WITH_KNOTS & corresponding CARTESIAN_POINT are never written to the file.
fma_02-good.zip


Init download-esm

I've found the tool https://github.com/simonw/download-esm pretty useful to quickly download and import npm packages as esm modules.
By downloading the files directly as esm modules, we can import them without using a bundler.
So, I've just rewritten that tool above in js.
It's even faster, because I'm fetching the dependencies in parallel.
Why am I sending a pull request and not opening a personal repo?
Because this is a very little program, and it depends just on troll. Also, it fits with the other tooling available in this repo.

I've wanted to add http import support in gjspack. So you'd be able to do
import lodash from `https://whatever.example/lodash.js`

lodash(...)

and gjspack would download and cache dependencies
Similar to how Deno did it.
I'm not sure if a CLI is still useful then. The main difference with this is that it wouldn't rely on a specific cdn.

That's reasonable. I just think it takes a decent amount of time to do everything that Deno did: resolving and bundling the dependencies, creating a lockfile, ideally even an import map...
(The lockfile is necessary if you plan to allow using arbitrary URLs. Without a lockfile, the possibility of a MITM attack is even higher than using a single, trusted CDN, because there are multiple domains which could be compromised, instead of just one).
But I agree that's certainly a better and more versatile solution than what this little tool can provide.


icon: settings_application is rendered with a 208px width when inline="true"

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Expecting "settings_application" mat-icon  to render properly
What is the current behavior?
"settings_application" mat-icon renders 208 pixels wide
What are the steps to reproduce?
Stackblitz link here:
https://stackblitz.com/edit/angular-g1fvvq?file=src/app/icon-svg-example.html
A screenshot just in case:

What is the use-case or motivation for changing an existing behavior?
So that icon could be used properly
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Tested on the latest (2019 Nov. 14) Firefox, Chrome.
Angular version 8.2.3
Is there anything else we should know?
The "settings" icon is basically a functional version of the "settings_application" icon. Although the current icon for "settings_application" is missing the box around the cogwheel, that the Material Design icons specify (https://material.io/resources/icons/?search=settings&icon=settings_applications&style=baseline)

Here's an update to the demo:
https://stackblitz.com/edit/angular-mat-icon-settings-17701?file=src/app/icon-svg-example.html
As you linked at the end of your post, the icon is called settings_applications and not settings_application. Changing to the correct name fixes it.
Additionally, there is an unlisted settings icon as well that behaves properly.


Add some emojis to docs markdown

Demo at - https://github.com/anshumanv/SublimeNotebook/tree/emoread/sublime_notebook/docs


make contributions easier via fully automating the dev setup.

Type of PR:
Hi.
I work for Gitpod. This PR adds gitpod config to the repo to make contributions easier for newcomers i.e with a single click it will launch a workspace and automatically:

clone the lightweight-charts repo.
install the dependencies.
run npm run tsc-watch.

This can be helpful for beginners i.e they can start coding instantly without setting anything up.
You can give it a try on my fork of the repo via the following link:
https://gitpod.io/#https://github.com/nisarhassan12/lightweight-charts
This is how it looks:

PR checklist:

[ ] Addresses an existing issue: fixes #
[ ] Includes tests
[ ] Documentation update

Overview of change:
Is there anything you'd like reviewers to focus on?

Hi,
thanks for your interest in lightweight-charts!
I have several questions at the moment:

what popular projects have/use this feature?
what advantages this feature provides to both maintainers and contributors?
how exactly this thing makes "contributions easier"? where that dev setup is set up? who use it/how much people use it?
afaik npm run tsc-watch doesn't work well at the moment because of custom transformation :)

Thanks.

what popular projects have/use this feature?

A lot of projects out there are already using Gitpod to simplify contributors/maintainers onboarding experience some of them are:

https://github.com/freeCodeCamp/freeCodeCamp
https://github.com/facebook/docusaurus
https://github.com/mozilla/pdf.js/
https://github.com/gatsbyjs/gatsby/
https://github.com/mobxjs/mobx/

a subset of them can be found at https://contribute.dev

what advantages this feature provides to both maintainers and contributors?

Anyone interested in contributing can start with a single click i.e they don't have to: clone the repo and then make sure that they have correct version of Node installed and then install the dependencies and then finally start coding in the editor, with Gitpod everything is automated with a single click.
This can be quite helpful for those contributors who are on slow internet connections or low end devices i.e Gitpod only takes up as much memory or computing power as a single browser tab(process) would which is a lot more efficent then running a Code Editor, Some Node tasks in a terminal and in some cases a web browser all at the same time.
I had the experience of using a an old Laptop which would cease to function ocassionaly If I run VS Code, A Web Browser and Webpack together.
For maintainers, it allows them to review changes online without the need of switching contexts and so on i.e to review and test the changes you don't have to pull the code from the PR banch and then re-install the dependencies if the dependencies in the Prs were changed or updated.
With the Gitpod app installed you can enable comments like the following in the PRs:

see https://github.com/freeCodeCamp/freeCodeCamp/pull/40071 for instance.

afaik npm run tsc-watch doesn't work well at the moment because of custom transformation :)

We can remove that and add if something else is required to be running while development.

how exactly this thing makes "contributions easier"?

I hope that the above answers this well.  Let me know if you have further questions.

where that dev setup is set up?

In the .gitpod.yml file https://github.com/nisarhassan12/lightweight-charts/blob/master/.gitpod.yml which will be included in the repo once the Pr is merged. The point is to keep the configuration versioned alongside your project (same as with a CI file).

who use it/how much people use it?

We have around 200,000+ users though all of them are not contributors/maintainers. I think visting https://contribute.dev would give you a better idea of who uses Gitpod.

A lot of projects out there are already using Gitpod to simplify contributors/maintainers onboarding experience some of them are:

Do you have any stats how many contributions were made using this tool in that repos? It seems that just "having gitpod config in the repo" have nothing with "users use gitpod to contribute to the projects"?

This can be quite helpful for those contributors who are on slow internet connections or low-end devices i.e Gitpod only takes up as much memory or computing power as a single browser tab(process) would which is a lot more efficient than running a Code Editor, Some Node tasks in a terminal and in some cases a web browser all at the same time.

Yeah, makes sense.

Anyone interested in contributing can start with a single click i.e they don't have to: clone the repo and then make sure that they have the correct version of Node installed and then install the dependencies and then finally start coding in the editor, with Gitpod everything is automated with a single click.

Is that something like https://github.com/features/codespaces, right?
Don't get me wrong, but for me the main concern is that I don't known who will support this file since no one from maintainers (and probably from contributors either) doesn't use Gitpod, so we can't be sure that everything is fine and "potential contributors" wouldn't have pain in ass while they will try to set the project up in Gitpod just because something won't work because of changes we've done previously, but didn't check Gitpod config. For me personally it might be a stopper to make a contribution at all if I'd prefer to use Gitpod for that.

Type of PR:
Hi.
I work for Gitpod. This PR adds gitpod config to the repo to make contributions easier for newcomers i.e with a single click it will launch a workspace and automatically:

clone the lightweight-charts repo.
install the dependencies.
run npm run tsc-watch.

This can be helpful for beginners i.e they can start coding instantly without setting anything up.
You can give it a try on my fork of the repo via the following link:
https://gitpod.io/#https://github.com/nisarhassan12/lightweight-charts
This is how it looks:

PR checklist:

[ ]  Addresses an existing issue: fixes #
[ ]  Includes tests
[ ]  Documentation update

Overview of change:
Is there anything you'd like reviewers to focus on?

Type of PR:
Hi.
I work for Gitpod. This PR adds gitpod config to the repo to make contributions easier for newcomers i.e with a single click it will launch a workspace and automatically:

clone the lightweight-charts repo.
install the dependencies.
run npm run tsc-watch.

This can be helpful for beginners i.e they can start coding instantly without setting anything up.
You can give it a try on my fork of the repo via the following link:
https://gitpod.io/#https://github.com/nisarhassan12/lightweight-charts
This is how it looks:

PR checklist:

[ ]  Addresses an existing issue: fixes #
[ ]  Includes tests
[ ]  Documentation update

Overview of change:
Is there anything you'd like reviewers to focus on?

I'm going to close the issue. If you'll have any question or updates - feel free to re-open it.

I'm going to close the issue. If you'll have any question or updates - feel free to re-open it.


NoCredentialsError

Hi, could we get an update on this ? We've been having a similar error with this setup
import boto3
from dst_datamodel import Users
from moto import mock_s3
from moto.core import patch_client

from hub_backend.utils.s3 import s3_client
from tests import _TestCase

@mock_s3
class TestImageRoutes(_TestCase):
    new_image_url = (
        "https://s3.eu-west-1.amazonaws.com/preprod.dst-user-profile-pictures/0cdda46e515003126a2554044210242e.jpg"
    )

    def _setup_s3(self):
        # Connecting to mocked s3 instance
        conn = boto3.resource("s3", region_name="eu-west-1")
        # We need to create the bucket since this is all in Moto's 'virtual' AWS account
        conn.create_bucket(Bucket="preprod.dst-user-profile-pictures")
        # Patching the s3 client used in the route
        patch_client(s3_client)

    def test_upload_image(self):
        self._setup_s3()

        user: Users = Users.get_by_id(self.default_id)
        self.assertEqual(user.image_url, None)

        data = {"image": (open("tests/assets/test_image.jpg", "rb"), "test_image.jpg")}
        response = self.make_request(
            "/users/me/profile_picture", "POST", authed=True, data=data, content_type="multipart/form-data"
        )
        self.assertEqual(response.status_code, 200)
        self.assertEqual(response.get_json()["image_url"], self.new_image_url)
        user: Users = Users.get_by_id(self.default_id)
        self.assertEqual(user.image_url, self.new_image_url)

moto==4.1.2
boto3==1.26.8
botocore==1.29.73

Can you post a small reproducible test case @Seluj78? With the code you provided, it's hard to tell what's wrong without knowing what's happening inside Users/make_request

make_request is just really a wrapper to get "cleaner" code:
    def make_request(self, url: str, type: str, json=None, authed=False, token=None, data=None, content_type=None):
        headers = {}
        if authed:
            if token is not None:
                headers = {"Authorization": f"Bearer {token}"}
            else:
                headers = {"Authorization": f"Bearer {self.access_token}"}
        if type == "POST":
            response = self.test_client.post(url, headers=headers, json=json, data=data, content_type=content_type)
        elif type == "GET":
            response = self.test_client.get(url, headers=headers, json=json)
        elif type == "PUT":
            response = self.test_client.put(url, headers=headers, json=json)
        elif type == "PATCH":
            response = self.test_client.patch(url, headers=headers, json=json)
        elif type == "DELETE":
            response = self.test_client.delete(url, headers=headers, json=json)
        else:
            raise ValueError
        if response.status_code == 401 and response.get_json()["error"]["message"] == "Token has expired":
            self.access_token, self.refresh_token = self.login_with_user()
            if type == "POST":
                response = self.test_client.post(url, headers=headers, json=json)
            elif type == "GET":
                response = self.test_client.get(url, headers=headers, json=json)
            elif type == "PUT":
                response = self.test_client.put(url, headers=headers, json=json)
            elif type == "PATCH":
                response = self.test_client.patch(url, headers=headers, json=json)
            elif type == "DELETE":
                response = self.test_client.delete(url, headers=headers, json=json)
        return response

And as for inside users, here is the route being tested:
s3_client = boto3.client("s3")

def upload_file_to_s3(file, bucket_name, filename, acl="public-read"):
    try:
        s3_client.upload_fileobj(file, bucket_name, filename, ExtraArgs={"ACL": acl, "ContentType": file.content_type})
    except Exception as e:
        logging.error(str(e))
        raise e
    return f"https://s3.eu-west-1.amazonaws.com/{USER_PROFILE_PICTURES_S3_BUCKET}/{filename}"

@users_bp.post("/users/me/profile_picture")
@jwt_required()
def upload_user_profile_picture():
    if "image" not in request.files:
        raise BadRequestError("No image key in request.files")
    file = request.files["image"]
    if file:
        if file.filename == "":
            raise BadRequestError("Please select a file")
        file.filename = secure_filename(file.filename)
        file_extension = file.filename.split(".")[-1]
        output = upload_file_to_s3(
            file, USER_PROFILE_PICTURES_S3_BUCKET, f"{md5(current_user.email.encode()).hexdigest()}.{file_extension}"
        )
        current_user.image_url = output
        current_user.save()
        return SuccessOutput("image_url", output)
    else:
        raise BadRequestError("Please select a file")

The s3 client here is the one being imported in my first post. I've pasted it here for convenience

The problem I have is simply that botocore complains about no credentials, even though I have this on setup:
    def setUp(self):
        os.environ["AWS_ACCESS_KEY_ID"] = "testing"
        os.environ["AWS_SECRET_ACCESS_KEY"] = "testing"
        os.environ["AWS_SECURITY_TOKEN"] = "testing"
        os.environ["AWS_SESSION_TOKEN"] = "testing"
        os.environ["AWS_DEFAULT_REGION"] = "us-east-1"

And I've added a touch ~/.aws/credentials in my github action before running unittest

I don't mind doing some debugging @Seluj78, but there are too many gaps in your posted code to try this out myself.
A reproducible test case should be as small as possible, and should be runnable without having to guess what's what.
An open source repository on Github would be ideal.

Hmm, I understand. Sadly, this code is from my job so I cannot share the entire repository to you but I'll try and make a MRE on a gist or public repo and let you know

Hi,
Here's the repo
https://github.com/Seluj78/moto-issue-5941
And here's a failing run
https://github.com/Seluj78/moto-issue-5941/actions/runs/4221470787/jobs/7328799465

Also please note that I haven't been able to reproduce the error locally, as on my machine (and my coworkers). Only on Github action have I encountered those errors.

I've sent you an invite to the repository @bblommers so you can push to it to try the github action

Copied/adapted from my comment here: https://github.com/Seluj78/moto-issue-5941/pull/1
Fix/workaround:
A fix would be to create a fully valid ~/.aws/credentials file in the CI:
mkdir ~/.aws && touch ~/.aws/credentials && echo -e "[default]\naws_access_key_id = test\naws_secret_access_key = test" > ~/.aws/credentials
Debugging:
I've been able to reproduce the failure locally by simply removing the default credentials in my ~/.aws/credentials:
[differentprofile]
aws_access_key_id = test
aws_secret_access_key = test
This throws the same error. That explains why it works locally, when credentials are configured correctly.
It looks like Flask does not maintain the same environment variables in it's own thread, when processing the HTTP request (and executing the upload_file). And without environment variables, boto3 cannot find any credentials.
Moto is still active obviously, otherwise the test would still fail, but Moto only becomes active after boto3 finishes creating it's own HTTP request.

Amazing ! I will try it out immediately in my company's code and let you know

It worked, thank you very much for your time !
I think this should be noted in the documentation somewhere, maybe here ?

Happy to hear that! And thanks for providing the MRE @Seluj78 - that made debugging a lot easier.
This should indeed be mentioned in the docs - I'll just reopen this issue as a reminder that we have to improve that area.

Great ! Thank you all for your great work !


[Feature Request] Learn spells from items

I know you are able to add buffs to the wand but dropping the neither star that has buffs onto the wand. I would like to make a quest system were a player is presented with 3 spells for completing the quest and they would be able to select the spell they want and drag it on either their wand or quest book to learn the spell.

Nevermind. Just do magic give spell name


api-04-remote-and-local / fetch data from our API and the process it locally

[x] objective.json
[x] description.md
[x] validator.js
[x] walkthrough.md

For more details, reference the original objective planning doc.
Objective outline

Get all author names who have written a document longer than X pages where X is an argument passed into the function
depends on #53

This is done as of #59. Closing!


Model binding of datetime set value of Date  field to NULL if date is more than the 12th day of the month.

When any datetime field is posted the datetime always remains as mm/DD/yyyy format.
The startup.cs file contains the following code.
public CultureInfo EnGbCulture = new CultureInfo("en-GB");
 public void ConfigureServices(IServiceCollection services)
        {
 services.Configure<RequestLocalizationOptions>(options =>
            {
               options.DefaultRequestCulture = new RequestCulture(EnGbCulture);
                options.SupportedCultures = new List<CultureInfo> { EnGbCulture };
            });
        }
  public void Configure(IApplicationBuilder app, IHostingEnvironment env)
        {
            CultureInfo.DefaultThreadCurrentCulture = EnGbCulture;
            CultureInfo.DefaultThreadCurrentUICulture = EnGbCulture;
            app.UseRequestLocalization(new RequestLocalizationOptions
            {
                DefaultRequestCulture = new RequestCulture(EnGbCulture),
                // Formatting numbers, dates, etc.
                SupportedCultures = new List<CultureInfo> { EnGbCulture },
                // UI strings that we have localized.
                SupportedUICultures = new List < CultureInfo > { EnGbCulture },
                RequestCultureProviders = new List<IRequestCultureProvider>
                    {
                    new QueryStringRequestCultureProvider { },
                    new CookieRequestCultureProvider { },
            },
            });
}

This issue was moved to aspnet/Mvc#8159


Request for Exasol-style IP ranges for websocket connections

I noticed that the python EXASOL package seems to be limited to a single host/port combination when connecting to a database.
To sync this with all our other drivers, it would be nice if EXASOL.connect would accept a host range like
ws://<IP_ADDRESS>..16:8563.

The EXASOL package supplied is merely a sample and is not designed for direct application in a production environment. It should serve as a foundation for developing your own websocket driver. For a ready-to-use Python websocket-based driver, we suggest exploring the pyexasol package: https://github.com/exasol/pyexasol


Fix compileToBrokerRequest function by calling PinotQuery2BrokerRequestConverter

Description

Existing compileToBrokerRequest() implementation just set dataSource, but missing some logic such as:
     //Handle filter
    convertFilter(pinotQuery, brokerRequest);

    //Handle select list
    convertSelectList(pinotQuery, brokerRequest);

    //Handle order by
    convertOrderBy(pinotQuery, brokerRequest);

    //Handle group by
    convertGroupBy(pinotQuery, brokerRequest);

So, if I call new CalciteSqlCompiler().compileToBrokerRequest(query) to get a BrokerRequest, it will return an incomplete BrokerRequest (filterQuery==null, groupBy==null, selections==null, etc).
This PR fix this issue by call PinotQuery2BrokerRequestConverter.convert() to do the conversion.
cc @siddharthteotia
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

Codecov Report

Merging #6881 (09867ad) into master (d63b806) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6881      +/-   ##
============================================
- Coverage     65.50%   65.48%   -0.03%
  Complexity       12       12
============================================
  Files          1421     1421
  Lines         69980    69974       -6
  Branches      10112    10111       -1
============================================
- Hits          45841    45821      -20
- Misses        20861    20871      +10
- Partials       3278     3282       +4

Flag
Coverage Δ
Complexity Δ

unittests
65.48% <100.00%> (-0.03%)
12.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d63b806...09867ad. Read the comment docs.

@mqliang , we don't need this change. Since we are moving to SQL, PQL code will be deleted eventually
So on the SQL query compilation path, there is no need to get complete BrokerRequest (it is overhead for SQL)
SQL -> PinotQuery -> set this PinotQuery inside empty BrokerRequest is enough rather than full conversion.
Server side query execution already has changes to either look for full BrokerRequest or PinotQuery inside the BrokerRequest.
cc @xiangfu0 @Jackie-Jiang


Add 3D Lissajous Pattern Generator contribution

Community Contribution
https://jaredschiltz.github.io/3D-Lissajous-Pattern-Generator/
Sharing

[X] I would be happy to have my project shared on The Coding Train's social media!

Instagram:
https://www.instagram.com/jaredschiltz/

Fun to play around with. Thanks for sharing!


declare real variables with KINDs

You wrote about Fortran that it is "harder to find answers to questions". Please consider joining Fortran Discourse
I suggest not using default real declarations. You could define
integer, parameter :: wp = kind(1.0)
and then declare variables as
real(kind=wp)
That way you can change the entire code to double precision by writing
integer, parameter :: wp = kind(1.0d0)
This is discussed at https://stevelionel.com/drfortran/2017/03/27/doctor-fortran-in-it-takes-all-kinds/ .

Thanks you for the suggestion and the invitation. I made the edit as suggested.


Do not clear text on mobile devices - fix #26

I also added an option to forcefully clear the input, in case someone doesn't want this to happen while calling clearSelection in their event listeners.
Tested on my Firefox for Android, seems to work well.

Hey @mdibaiee,
A developer should what have the ability to clear a selection or not, regardless of platform. This kind of checking should be done in your success callback.

Thanks for your contribution anyways ;)

I think you don't want me to continue working on this, as you closed the Pull request and give me this:

Thanks for your contribution anyways ;)

It doesn't bother me much, but please be more polite to the community. You're doing it wrong.

Not every PR get merged @mdibaiee, you shouldn't feel offended by that. As I explained above, a developer should have control over selection, regardless of platform. That's why we expose the clearSelection function.

@zenorocha I know, I'm an active open-source contributor, there are two cases with a PR, you either close it as you "dont want it at all", or you ask the contributor to modify the patch to fit your needs, I've been through this kind of things a lot, the maintainer says he wants something, after you make a PR, he changes his mind.
Contributors are not work-less, life-less people with cheap time.


disallowCurlyBrace

This replaces #126. Essentially, this rule will throw an error when a control structure has a block with a single statement inside. .e.g:
// valid
if (x===1) foo();
else bar();

// valid
if (x ===1) {
  foo();
  bar();
}
else baz();

// invalid
if (x===1) { foo(); }
else { bar(); }

This replaces #126.

And #726

Associated PR https://github.com/jscs-dev/node-jscs/pull/880

This doesn't work for me for switch statements.
.jscsrc
{
  "disallowCurlyBraces": ["case", "default"]
}

example.js
switch(a) {
  case 1: {
    console.log('you got one');
  }
  default: {
    console.log('you got something other than one');
  }
}

This example passes with no errors from jscs.

Looking at the source - it was never implemented for case/default so they aren't valid options atm. If you want you can create a new issue to add them.
Although looking now they are valid in requireCurlyBraces (funny). If you want to make a PR for this go ahead! https://github.com/jscs-dev/node-jscs/blob/master/lib/rules/require-curly-braces.js

Yeah, that's what threw me off, haha. I'll take a look and see what I can do.