[BUG] Don't fail on huge diffs if write_output_files: true is set

Is there an existing issue for this?

[X] I have searched the existing issues

Does this issue exist in the latest version?

[X] I'm using the latest release

Describe the bug?
If I generate a huge diff, the action will fail due to GitHub Actions limits:
An error occurred trying to start process '/usr/bin/bash' with working directory '/home/runner/work/obsidian/obsidian'. Argument list too long

I get this error even if I set write_output_files: true. The issue is in https://github.com/tj-actions/changed-files/blob/main/get-changed-paths.sh, which is setting the output of git diff to GitHub variables even when they may not fit.
To Reproduce
Run the action on a diff with e.g. 5000+ files changed.
What OS are you seeing the problem on?
all
Expected behavior?
If write_output_files: true, I would expect the action to succeed on arbitrarily large diffs, because the output is written to disk rather than returned as GitHub actions outputs. However, this doesn't happen because the implementation currently still depends on GitHub actions outputs. I would suggest making it so that if write_output_files: true, then all string output values (e.g. added_files, copied_files, etc.) are blank and the user should read the outputs from files instead.
Relevant log output
See above.

Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Status here?

This would be resolved by the end of the week in a new version

Hi @JavaScriptBach @omer-za, this bug has been fixed in the latest v36 release.


Show more output in the console

Currently it looks as though the script is hanging when it is doing long installations. We need to show more output in the console.

Getting there, for some reason my \r in the verbose mode commit doesn't work. It prints all of the  "% complete" text on new lines when it is meant to go back and overwrite the previous line.

This should be fixed in 8274a67. Needs testing.

Fixed.


Enabling GLES2 forces clear background of controls in Editor

Godot version:
Godot 3.2 alpha 1
OS/device including version:
macOS Mojave v10.14.8
Issue description:
I opened a GLES2 mobile project that I'm working on in the new alpha build. The background color on the majority of controls in the editor itself are alpha = 0, regardless of which monitor I open the editor on. When I switch to GLES3, everything goes back to normal, so my assumption is that when you switch to GLES2 renderer, the renderer has an error on Macs, but I do not know specifically what yet.
Steps to reproduce:

Create a GLES2 project
Open it on a Mac

Minimal reproduction project:
BorkedGLES2Repro.zip

![Screen Shot 2019-10-09 at 5 35 12 AM](https://user-images.githubusercontent.com/148612/66470051-e9ac9700-ea56-11e9-8bc5-e533a36d4bd8.png)
![Screen Shot 2019-10-09 at 5 35 30 AM](https://user-images.githubusercontent.com/148612/66470052-e9ac9700-ea56-11e9-953b-91fa222a4d6d.png)
![Screen Shot 2019-10-09 at 5 35 50 AM](https://user-images.githubusercontent.com/148612/66470053-e9ac9700-ea56-11e9-8a51-9bfb57a60e32.png)

Odd that it didn't include my other screenshots. Suffice it to say, they look pretty bad too.

Duplicate of #32601 (fixed in master branch).

Thanks! I'll get the nightly build then. :)


Dead?

9 Pull requests, and no updates in 6 months. I know there are others trying to update this repo but seems the repo owner isn't interested . Hope I'm wrong though.

I've been wondering about this too, as the Discord also went dead.

The last update was 5 months ago, and the main issue is that this bot now primarily relies on opengsq-python. I managed to get a pull request through, but that was 2 months ago, and the main Python package still hasn’t been updated. From what I can see, the main developer is still active but working on other projects. I’m not sure if they’ve abandoned this one.

I'm guessing the main developer is @BattlefieldDuck, would love it if he could help with either updating what needs to be done.


Does this library support mocking the virtual function or only non-virtual ones?

This library is very similar to cppfreemock. I'm wondering if I can mock virtual methods using your library because using cppfreemock this has been proven to be imposible.
I am wondering how much work there is to port this library to linux env because if it supports the mocking of virtual function It would be very very interesting to use.
I would also would like to spent some time on extending it's functionality if you can confirm that mocking virtual methods should be possible.

I'm still investigating so I'm not going to confirm virtual methods mocking at this time. However, it would be possible on Windows as InjectorPP retrieving info from .pdb file. Think about the Visual C++ debugger. We can change variable values, step over methods (both virtual or non-virtual member functions). I'm still working on this feature, but theoretically it should be possible.
For Linux, I haven't started my investigation yet. However, I can tell we're able to leverage ptrace to implement almost all features except mocking virtual methods - as we don't know the address at compile time. We still need a debugger specific solution. For instance, with -g option, gdb is able to step in & step over virtual or non-virtual functions. That should be the way to achieve our goal.
The work load to port this library to linux should be huge. As I'm using debugger specific info (.pdb) on Windows. Although we can keep the interfaces, the core logic should be rewritten by leveraging ptrace and debugger specific info on Linux.

Yeah you're right about virtual methods.
I did some research on my own and the only solution to mock the virtual methods, in my opinion is the following one:

you must receive the exact object type that you want to mock, and the method that you want to mock
the "library , InjectorPP" should instantiate an object of the received type, just to have the vtable in order to be able to determine the real method address.
then, using the address received (this should be the id in the vtable) we should be able to find the real method address assigned by the compiler.
then the mocking procedure should follow the same pattern as you currently do for non virtual methods

Regarding the port to linux, I have in mind a solution that currently is working with cppfreemock

Just added the support for mocking virtual methods . It's not perfect yet, but works in most cases. Just leveraged the pdb file for retrieving virtual method name from address so it's a compiler specified implementation.

Closing it as we have already supported virtual method.


document CEL quantity library

Documents newly added library functions for resource.Quantity in CEL added by https://github.com/kubernetes/kubernetes/pull/118803
/sig api-machinery
/cc @jpbetz @cici37

/close
Closing this for dev-1.28 and immature feature.
Feel free to reopen and rebase it onto dev-1.29 if the feature can make it.


Issue 49150: Fix sample type upgrade from 23.07 to 23.12

Rationale
This seeks to address Issue 49150 where an upgrade directly from a 23.07 (or earlier) instance to 23.12 can fail due to some shared code that generates queries using RootMaterialLSID/RootMaterialRowId. This updates the shared code to accept an additional argument to switch the target column for the joins. The intent is for this to be effectively reverted when the upgrade path goes defunct with the release of 25.2.0.
Related Pull Requests

#4844 (upgrade that introduces RootMaterialRowId)

Changes

Introduce useRootMaterialLSID and generate subsequent JOINs in queries based off this flag.

@labkey-nicka FYI this upgrade code will actually get removed in 25.2.0. We've switched to an annual consolidation process that clears out old upgrade code every January.


Update Integration pages layout

Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit 732e18eb556120a5b2cccb2484bf414d60fea6ad at: https://65bd0927df4b2f009f651073--meshery-docs-preview.netlify.app

@iArchitSharma
Let's discuss this on website call at 6:30 PM IST / 7 AM Central time Today. Please add this as an agenda item in the meeting minutes.


chore: promote react-spring to version 0.0.26

this commit will trigger a pipeline to generate the actual kubernetes resources to perform the promotion which will create a second commit on this Pull Request before it can merge

react-spring
Changes in version 0.0.26
Chores

release 0.0.26 (jenkins-x-bot)
add variables (jenkins-x-bot)

Other Changes
These commits did not use Conventional Commits formatted messages:

in pr job (iMckify)
8 (iMckify)
7 (iMckify)
6 (iMckify)
Revert "Revert "GH_ACCESS_TOKEN"" (iMckify)
5 (iMckify)
Revert "GH_ACCESS_TOKEN" (iMckify)
GH_ACCESS_TOKEN 4 (iMckify)
GH_ACCESS_TOKEN 3 (iMckify)
GH_ACCESS_TOKEN 2 (iMckify)
GH_ACCESS_TOKEN (iMckify)
ui (iMckify)

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iMckify: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

verify
6f8a158b7af58bd7a68d28487d65ed9f63fba1cd
link
/test verify

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@iMckify: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

verify
4d5abd02a2cc16fe0f0db3d7ed3981d9ad86d2fa
link
/test verify

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test verify

@iMckify: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

verify
4d5abd02a2cc16fe0f0db3d7ed3981d9ad86d2fa
link
/test verify

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test verify

@iMckify: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

verify
0a51d792e42824be7703a6a7445d03f7b11eea84
link
/test verify

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


fix(spark): add all faulty servers into blacklist while writing for stage recomputing

What changes were proposed in this pull request?
add all faulty servers into blacklist while writing for stage recomputing
Why are the changes needed?
It will fail on retry when only one server is added into blacklist.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.

Could you help review this? @yl09099

LGTM~

Do you add a new ut for this case?

Do you add a new ut for this case?

I'm still reviewing this part.


Stop adding needs-triage for Issues created by Repo contributors

We can trust that they do the right thing - or at least don't add needs-triage if the creator added label(s) to the issue.

Here's an audit log entry showing that this works:
https://ossbot.computer/audit.html?org=firebase&repo=firebase-ios-sdk&key=-LvmaOZd5Zz1uMeaSVO-


Review the README file of the Signer

The readme file is still in review, @mrkara will take a look.


Error: Cannot read property 'rowCount' of undefined for google spreadsheets

Think there is some issue in the new release which causes 'this' property in the class GoogleSpreadsheetWorksheet in file GoogleSpreadsheetWorksheet.js not being set, and hence resulting in breaking and causing the above error. This issue is similar to another issue been raised in this package
  async getRows(options = {}) {
    // https://developers.google.com/sheets/api/guides/migration
    // v4 API does not have equivalents for the row-order query parameters provided
    // Reverse-order is trivial; simply process the returned values array in reverse order.
    // Order by column is not supported for reads, but it is possible to sort the data then read

    // v4 API does not currently have a direct equivalent for the Sheets API v3 structured queries
    // However, you can retrieve the relevant data and sort through it as needed in your application

    // options
    // - offset
    // - limit

    options.offset = options.offset || 0;
    options.limit = options.limit || this.rowCount  - 1;

    if (!this.headerValues) await this.loadHeaderRow();

    const firstRow = 2 + options.offset; // skip first row AND not zero indexed
    const lastRow = firstRow + options.limit - 1; // inclusive so we subtract 1
    const lastColumn = columnToLetter(this.headerValues.length);
    const rawRows = await this.getCellsInRange(
      `A${firstRow}:${lastColumn}${lastRow}`
    );

    if (!rawRows) return [];

    const rows = [];
    let rowNum = firstRow;
    for (let i = 0; i < rawRows.length; i++) {
      rows.push(new GoogleSpreadsheetRow(this, rowNum++, rawRows[i]));
    }
    return rows;
  }

The line   options.limit = options.limit || this.rowCount  - 1; results in error as 'this' is undefined.
Expected behaviour
'this' should be set and hence should access to the class functions

I am also getting a problem like this. When using the documentation, it is impossible to read rowCount as it always comes back undefined.

I am also getting a problem like this. When using the documentation, it is impossible to read rowCount as it always comes back undefined.

The issue which is similar to this one (liked in my comment above) still is in 'open' state since February I guess. Not sure if we would be getting a resolution anytime soon

Can you provide some more context on how you are calling the function?
I can assure you that calling sheet.getRows() without passing in options.limit does indeed work in most cases (have a look in the tests) so it must be something specific to how the rest of your usage is set up.
If you can provide a simple repro, I'll take a look!


add support for Linptech Wireless Button KS1Pro BLE KS1PBB

Xiaomi Multimode Gateway 2
https://home.miot-spec.com/spec?type=urn:miot-spec-v2:device:temperature-humidity-sensor:0000A00A:linp-ks1bp:1

Thanks!

https://github.com/AlexxIT/XiaomiGateway3/releases/tag/v3.3.5


Secret store is going to different realm api endpoint otherthen DRCC realm api endpoint

Hi Team,
We are trying to set up OCI-Secrets-store-csi driver in DRCC OKE, but when Application deployment tries to access secret in DRCC Oci Vault, it's going to the wrong realm API endpoint for Authentication.
Please find below the error message
Warning   FailedMount         pod/keep-secrets-alive-97dd8bf5b-hwttl     MountVolume.SetUp failed for volume "bootstrap-reposecrets" : rpc error: code = Unknown desc = failed to mount secrets store objects for pod argocd/keep-secrets-alive-97dd8bf5b-hwttl, err: rpc error: code = NotFound desc = unable to retrieve secrets: can not create client, bad configuration: failed to get security token: failed to renew security token: failed to get security token: failed to call: Post "https://auth.xx-dcc-<customregion).oraclecloud.com/v1/x509": dial tcp: lookup auth.xx-.oraclecloud.com on <IP_ADDRESS>:53:
Note: this endpoint URL should have been auth.xx-dcc-.oraclecloud-realmnumber.com
Kindly suggest, how can we define our realm API endpoint within OCI secret store.
Thanks,
Brajesh Kumar

@YashwantGohokar,  Can you look into this.

Addressed it with release
Please use the attached assets of the release to get the new image.


Code example attempts to initialize the list within a list and fails …

…with 'cannot initialize type EmailAddress with a collection initializer'
code attempts to build a collection within a collection. putting the address/name value pairs in parenthesis works fine.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@idMdev : Thanks for your contribution to the Azure documentation! The author, @thinkingserious, has been notified to review your proposed change.

@idMdev, @idMdev,
+1 LGTM
Thanks!

@erikre Hi Erik Please review these proposed changes. Thanks.

@cephalin This looks good. Could you double check the SendGridMessage object using a List of recipients just as the updated code shows in this doc? Thanks

@cephalin https://github.com/sendgrid/sendgrid-csharp/blob/master/src/SendGrid/Helpers/Mail/SendGridMessage.cs#L194

@thinkingserious Do you approve the change? You're the expert. :)

@cephalin Yes :)

@thinkingserious @cephalin Thanks, folks. Merging.


num_threads

is the --num_threads really working?
It's alway using only one core.

Try with a lower effort or lossy encode. For high-effort (e>3) lossless, most of the encode steps haven't been parallelized yet so you'll indeed see little difference in speed with more threads...

oh I see, it works with effor<=3 or lossy


Convert to an OTP Application?

How do you feel about converting the library to an OTP Application? It seems like it's not runtime configurable (Neopixel hotplug isn't a thing) and it's too dependent on low level hw to ever support multiple instances.
I think this would simplify things since Nerves.Neopixel would no longer have to be added to your application's supervision tree. A side effect would be that configuration would need to be moved to the config.exs. This simplifies my setup and seems like it should be ok for most users.

Yes, I agree that this library makes more sense as a singleton OTP app since the configuration will pretty much always be set at compile time to match how your actual hardware is wired up.

This is resolved now with #15, along with a complete re-write of pretty much the whole thing, and a rename from nerves_neopixel to blinkchain.
You can now also specify a 2-dimensional drawing surface with the pixels arranged however you want, and use drawing commands to draw the frame instead of transforming into an LED color list manually. I'd love to get your feedback if you have a chance to play with it at some point.


Not use react-dom

I was going to add react-dom to webpack external, but we don't need react-dom its only being used to findNode to set as input, which I have changed to ref as a method for same input.
This brings down dist min file from 230kb to 7kb (not gzipped)

ping @wubocong

Would love to see this merged, will use your fork for now. Cheers

Yea, You can use https://www.npmjs.com/package/@hasnat/react-upload-file for now.

Added another commit which adds optional prop inputName to help specify file input tag name


feat: containerize app with jib

Resolves #6

Travis push build failed because of this: https://travis-ci.community/t/install-of-oraclejdk11-is-failing/1856/13. But pr build is successful


Adds the improved performance Rsync version for Windows

This PR adds rsync2 as a replacement for the existing rsync package. rsync2 adds a ton of improvements, for the Windows operating system, to the upstream development branch of rsync. So many in fact that I'll summarize:

Large file/path name support (64k length, when running Windows Vista or higher.) Support for a Windows 10 registry key will enable very large file/path name support.
Full UNICODE support, including iconv for remote translations.
Supports UNC and UNC UNICODE source and destination command-line parameters; very useful when paired with VSS snapshots.
Supports correct handling when read-only files are encountered at the destination.
Timestamp accuracy to the second; the --modify-window flag is not needed.
Currently skips system files.
Currently skips reparse points for WSL symlinks.

DISCLAIMER: I have been personally using Rsync for Windows for a number of months without a major hitch and have self-proclaimed it is stable and production grade, even though it is based on a development point of the upstream Samba Rsync development repository.
The Rsync for Windows project is available here:
https://github.com/jbenden/rsync/releases
Comments, suggestions, and ideas are always welcomed!

Why is yodl failing on the CI server? Is there a work-around to having the CI pass these changes?
Thanks!

@jbenden Tea is outdated, ignore it.

How would you feel about this package replacing the actual rsync package?
The rsync2 package offer much improved support for Windows and I would like to see dependent (on MSYS2's packages) projects utilize this much improved package.


Move ServerTransport specific methods from Transport to ServerTransport

Why
Describe what prompted you to make this change, link relevant resources: Linear issues, Slack discussions, etc.
What changed
Describe what changed to a level of detail that someone with no context with your PR could be able to review it
Test plan
Describe what you did to test this change to a level of detail that allows your reviewer to test it

Current dependencies on/for this PR:

main:

PR #84

PR #85 👈

PR #86

This comment was autogenerated by Freephite.


Billboard outline

Requested on the forum: https://groups.google.com/forum/?hl=en#!topic/cesium-dev/EhTMZVX8SEI
Add the ability to draw an outline around images used for billboards

CC #4314.  Could also be done with post-processing, #3001, or when generating the billboard.


Open concierge chat links in the same tab

Fixed Issues
$ https://github.com/Expensify/Expensify/issues/237150
Tests

Make sure your local environment is setup to work with Guides (SO here)
Create a brand new account on a domain that has no billing card and no previous billing and no previously assigned guide.
Create a workspace
Go to the concierge chat and click the link for chatting with the setup specialist
Verify that the #admin room is opened in the same tab

[ ] Verify that no errors appear in the JS console

QA Steps

Create a brand new account on a domain that has no billing card and no previous billing and no previously assigned guide.
Create a workspace
Go to the concierge chat and click the link for chatting with the setup specialist
Verify that the #admin room is opened in the same tab

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/1228807/199550688-8fa06080-1fb9-4434-963b-e92e78369a04.mp4

Mobile Web - Chrome
https://user-images.githubusercontent.com/1228807/199550556-4094e6d8-154c-40d5-967f-ee4bc50e8d73.mp4

Mobile Web - Safari
https://user-images.githubusercontent.com/1228807/199550475-9b306031-1f99-46ef-be06-0d6dcad20d89.mp4

Desktop
https://user-images.githubusercontent.com/1228807/199550638-184a1445-e186-4855-a96f-bbc56b424de2.mp4

iOS
https://user-images.githubusercontent.com/1228807/199550514-b19ce700-92be-4926-8fe8-5def0f1ab33c.mp4

Android
https://user-images.githubusercontent.com/1228807/199550600-46712a91-9e4e-460e-9eef-3ff0d2a75b44.mp4

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Thanks! Looks good 👍
Testing on Android. Something looks broken

@MonilBhavsar

Testing on Android. Something looks broken

Are you looking into this? I was not sure what you meant by it or if it implied I needed to look into it as well. What looks broken?

I mean on my dev env 😅
For Android app, I was required to checkout to main, delete and reinstall node modules. The issue was fixed, it worked well and I updated the screenshot too.
For Android web, still no dice after some workaround. Have asked here

Ah, got it. @rushatgabhane Are you able to test this on Android mobile web for @MonilBhavsar?

Managed to fix it. All good here 👍

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @MonilBhavsar in version: 1.2.25-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @yuwenmemon in version: 1.2.25-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


chore(topology): remove migrated plugin topology

For RHIDP-4257

LGTM! Have you made sure that all changes made to the topology plugins in janus since the migration have also been added to the plugins in community-plugins?

Hi @04kash , thanks for the review, yes I have confirmed that all changes are moved to topology BCP 👌


CSS Lists Level 3

Trello: https://trello.com/c/ihoF34ET/172-css-lists-level-3-fx-70
Acceptance criteria

[ ] Check that counter() and counters() are fully documented
[ ] Check BCD up to date
[x] Find out if anything needs updating for https://bugzilla.mozilla.org/show_bug.cgi?id=1576821

PR to make the change in the formal syntax: https://github.com/mdn/data/pull/391

I don't think there is anything to do for BCD, this change was essentially to make the spec match CSS2.1.
the functions are documented, I have made some minor changes with regard to the syntax and tidying things up.
Added a line to release notes, once the PR is merged I'll mark the bug.


[Feature request] split one A3 page into two A4 pages?

This is a very useful feature, and hopefully the developers will consider joining it.
Thanks!

It can do to a4 to a a3 but not other way round, good idea !

This feature has been implemented, thanks to the developers!


Support mutations

Hey guys!
Just started looking into GraphQL and your project looks great! I was wondering if there were short term plans for mutation support. I'm looking into creating a project that would do CQRS via GraphQL and this framework looks good but lacks mutation for now!

Thanks for the issue!
Mutations are definitely in the plans, though I've been thinking about the best way to represent them in the API. There are a few changes to the current API that we've also been planning since all the additional features we want to add won't fit easily into the current Fluent interface.
However, if you're eager to try the library I can probably get rudimentary mutation support working before the end of the week. I should note that this is definitely still an alpha version so the API may change significantly between releases.

There's no rush for mutations. I'm starting with querying first and will end up with mutations in two or three weeks.
I already assumed this was alpha with the quantity of commits coming in!

Hey Andy,
I apologize that development of this project has slowed recently as I've
gotten busy with other things. I do have a pretty good idea of how I want
to handle mutations, I just need to get some time in front of the keyboard
to do it.
I'll work on getting mutations implemented within the next few days and
then push a new version to NuGet.
-Chad
On Wed, Jun 29, 2016, 11:30 AM andyroper<EMAIL_ADDRESS>wrote:

Hi,
I've just been playing with this project - any news on mutations support,
It would be awesome!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ckimes89/graphql-net/issues/16#issuecomment-229393503,
or mute the thread
https://github.com/notifications/unsubscribe/AB2KwlOVCHJnOQldgu31x_YBqVEGEYsQks5qQo96gaJpZM4IGori
.

Mutations have landed (in dev)!
The API is similar to the explicit query API. This is pretty much a requirement since we have to specify both a name and an explicit argument shape. I'll copy an example from the tests for this feature:
schema.AddMutation("mutate",
    new {id = 0, newVal = 0},
    (db, args) => db.MutateMes.AsQueryable().FirstOrDefault(a => a.Id == args.id),
    (db, args) =>
    {
        var mutateMe = db.MutateMes.First(m => m.Id == args.id);
        mutateMe.Value = args.newVal;
        db.SaveChanges();
    });

Going through it one by one, the first line specifies the name. The second specifies the shape of the arguments (used in the (db, args) functions). The third line is the query that will be executed after the mutation is completed. The fourth line(s) is the actual mutation, which is just a function to be executed given the Context and your arguments as parameters.
It's unfortunate that in this case (and I think probably in many others) that the query to be executed is an exact duplicate of an already defined query. I'm considering ways to improve that, but it's a bit difficult given that the arguments shape for a mutation is unlikely to be reused.

Excellent - Thanks!


Fix RangeAnnotations links in doc

Fixed links in documents.
I guess the syntax of these links were the opposite.

Thanks!


couldn't find the plugin "@typescript-eslint/eslint-plugin".

Hi, I don't know if I need to install @typescript-eslint/eslint-plugin manually, or there is something wrong on the side of this config. When I install it manually everything works. But this package is not in peer dept, it is in regular deps, so I thought it would work out of the box
here is my root config
{
    "extends": [
        "@yandex-cloud/eslint-config",
        "@yandex-cloud/eslint-config/prettier"
    ],
    "root": true,
    "env": {
        "node": true
    },
    "overrides": [
        {
            "files": "*.tsx",
            "rules": {
                "react-hooks/rules-of-hooks": "warn",
                "react/jsx-tag-spacing": "off"
            }
        }
    ],
    "rules": {
        "no-shadow": "off",
        "valid-jsdoc": "off"
        // "@typescript-eslint/naming-convention": "warn"
    },
    "ignorePatterns": ["dist/*", "build/*"],
    "settings": {
        "react": {
            "version": "16.0"
        }
    }
}

➜  monitoring npx eslint src

Oops! Something went wrong! :(

ESLint: 8.11.0

ESLint couldn't find the plugin "@typescript-eslint/eslint-plugin".

(The package "@typescript-eslint/eslint-plugin" was not found when loaded as a Node module from the directory "/home/leon-minasyan/arcadia/data-ui/monitoring".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

    npm install @typescript-eslint/eslint-plugin@latest --save-dev

The plugin "@typescript-eslint/eslint-plugin" was referenced from the config file in ".eslintrc » @yandex-cloud/eslint-config#overrides[0]".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

I tried forcing an override in out package.json and cleaned package-lock.json and reinstalled
{
  "overrides": {
    "@typescript-eslint/eslint-plugin": "^5.15.0"
  }
}

after this npm was able to simplify node_modules to be flat so the plugin worked
I think this either should be noted somewhere or maybe fixed :)


[Chore] Add tool to generate components database

Add a new cli tool to generate components database leveraging Storybook utils

This is temporarily blocked due to: https://github.com/storybookjs/test-runner/issues/489

:tada: This issue has been resolved in version 10.2.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


chore(deps): update common-dev-assets digest to ff4e109

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
8578394 -> ff4e109

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 4.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


test new issue again

test

Hi, I have some suggestions to help solving this issue!
Here is a list of similar issues:

1. [test new issue](https://github.com/fjsj/python-social-auth/issues/40)

2. [test new issue](https://github.com/fjsj/python-social-auth/issues/46)

3. [test new issue](https://github.com/fjsj/python-social-auth/issues/44)

4. [test new issue](https://github.com/fjsj/python-social-auth/issues/43)

5. [test new issue 123](https://github.com/fjsj/python-social-auth/issues/42)

Hope this is useful!
Cheers,
Cinnabot.


Feature/backoffice

Merged lastest devel 1.13.0
copied column name generation for CollectionList component from original vulcan-backoffice-builder.

Do you have a working version?
I am planning to finish up this feature, but currently I simply lack a left menu layout component for both Bootstrap and Material UI, in order to display all available collections in a single menu.
I somehow fell into a rabbit hole because I wanted to use Storybook to develop this component, and then I wanted to put Material UI into the core to test Storybook... and here al I.

Hi,
Thanks to your directions I could update to 1.13.0 and everything works.
It just generates the columns datatable property that was missing as you did.
There is no actions generation else default edit but it is enought for now.
I plan to make a material-ui Layout replacing VulcanBackofficeLayout, something very simple at first.

@Julien-Sytadelle could you share some screenshots about what deal new feature delivery?

It simply automatically adds a route to a list and an item for each registered collection using function registerBackoffice.
Then, once you set up a new collection you can directly interact with it and even reuse the component for quick prototyping.
Have a look at admin part of awesome-vulcan app from Eric.
Ex: https://www.awesome-vulcan.com/admin/articles
Le 16 avr. 2019 à 22:00, à 22:00, enzo - Eduardo Garcia<EMAIL_ADDRESS>a écrit:

@Julien-Sytadelle could you share some screenshots about what deal new
feature delivery?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/VulcanJS/Vulcan/pull/2276#issuecomment-483821357

@Julien-Sytadelle Regarding the material UI layout I've built this one based on Erik Dakoda's version. It is responsive .
It's the more the Bootstrap part that lacks now.

Hi,
I know, I used it as base start. Works great.
Thanks for this also.
Le 18 avr. 2019 à 11:33, à 11:33, Eric Burel<EMAIL_ADDRESS>a écrit:

@Julien-Sytadelle Regarding the material UI layout I've built this
one
based on Erik Dakoda's version. It is responsive .
It's the more the Bootstrap part that lacks now.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/VulcanJS/Vulcan/pull/2276#issuecomment-484426574


Could you give an example for NICE?

@VincentStimper
Awesome repo. Thanks
I want to work on NICE. Didn't find the NICE example here. Could you give NICE example?

Hi @AI-ML-Enthusiast,
NICE is simply Real NVP but without the scale in the affine map, so you can follow the Real NVP example and set the scale argument in the  AffineCouplingBlock to False. Note that this reduces the number of parameters by a factor of two, so in the example notebook you have to change the network outputting the parameters to
param_map = nf.nets.MLP([1, 64, 64, 1], init_zeros=True)

Best regards,
Vincent


Where is HARKManual.pdf?

It is referred to here: https://github.com/econ-ark/HARK/blame/master/README.md#L39
But I can't find it.

nm... found it. :-) https://github.com/econ-ark/HARK/tree/master/Documentation


Telemetry to determine advantage of this feature

Would restricting internet access by adding a vnet for an acr improve issues related to connection failures i.e. many incoming connection attempts?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5bb583eb-86b2-5383-350c-985f66de2dd6
Version Independent ID: d08f5439-4db8-f9d0-eeb4-c1f4656fe0fa
Content: Deploy an Azure container registry into a virtual network
Content Source: articles/container-registry/container-registry-vnet.md
Service: container-registry
GitHub Login: @dlepow
Microsoft Alias: danlep

@sonpeppers yes that would be one advantage. Since you can isolate who can access the private network that means you can lock down your clusters even further so only users who have access to that specific network can access the cluster. Thus, eliminating the need to public facing endpoints.

@sonpeppers I will close this for now. If you have further comments just let me know and we can always reopen and continue the discussion.


Header only - editor error

Hello, I have problem with basic usage

What's wrong?

This worked for me
std::string TokenSecurity::createToken()
{
    jwt::claim value(std::string("Test"));

      auto token = jwt::create()
            .set_type("JWS")
            .set_payload_claim("sample", value)
            .set_issued_at(std::chrono::system_clock::now())
            .set_expires_at(std::chrono::system_clock::now() + std::chrono::seconds{3600})
            .sign(jwt::algorithm::hs512{"secret"});

    return token;
}

@nicraMarcin The problem you faced is the fact that the constructor of "claim" is explicit.
You can pass -DJWT_CLAIM_EXPLICIT=0 on the commandline and add this define to your editor to override the default and make them not explicit.

@Thalhammer thanks for hint.


Fix document_object when objdoc is empty

Problem description:
When obj.__doc__ is empty, no mdx section for that doc gets generated.
Solution
https://github.com/huggingface/doc-builder/pull/96 fixes the problem by generating the signature str/svelte for that doc even if obj.__doc__ is empty.
I realize that #95 was overcomplicating things. Please let me know if the problem is clear 🙂

Sounds better. Just so I have the full picture, what part of the Datasets doc are you trying to fix with this?

All property methods have empty docstring https://github.com/huggingface/datasets/blob/b45dd77d01486e08731a0383aaf2c6140f85576c/src/datasets/table.py#L245-L263
However, they were listed to show in the doc as in https://huggingface.slack.com/archives/C02GLJ5S0E9/p1644339779420269?thread_ts=1644339518.387909&cid=C02GLJ5S0E9

They are not shown by sphinx (check here), so this is a change from sphinx. I'm fine with the change as you did, but I'm also fine ignoring the non-documented methods/properties like sphinx does.
Let's see what @lhoestq thinks!

They should be documented as the rest. Let me add docstrings for these ones in datasets
I'd rather be able to see what documentation is missing in the doc, so it's maybe better if we keep them even if they don't have docstrings

Let's go ahead and merge this then @mishig25 :-)


Unable to explicitly specify networking.hostName

If I have;
mkFlake {
  hosts.foo = {
    modules = [ ./hosts/foo.nix ];
  };
}

and then in foo.nix I have;
{
  networking.hostName = "bar";
}

I get an error;
error: The option `networking.hostName` has conflicting definition values:
          - In `/nix/store/path/to/foo.nix`: "bar"
          - In `<unknown-file>`: "foo"

There is (seemingly?) an attempt to support explicit hostName specification; https://github.com/gytis-ivaskevicius/flake-utils-plus/blob/4db80b033eaa02d8aae46844364b24e0375214f8/lib/mkFlake.nix#L138
However either I am not specifying networking.hostName correctly (e.g. it needs to be an argument to mkFlake in some way), or this logic is broken, or I am just misinterpreting the code :)

It is expected for hostname to be specified as hosts.<hostname> = {...} for consistency reasons. This is not a bug.
If you really wish overwrite it - you can do it via networking.hostName = lib.mkForce "bar";


[gardening] Make count on BlotSetVector const.

Just discovered this as I working on other code.

Windows failure is an unrelated test.


wrong dection

Either I traind the images by myself or download directly frome this raccoon_dataset/training/output_inference_graph.pb,
get this wrong dection

which script is used to run this detection?


Configure cloudwatch for EKS application logs

We need a centralized persistent storage & searching for our EKS application logs. Of course, the best long term solution is to use zqd & Brim, but we need an initial solution while we're getting the cloud service running. Cloudwatch seems like the best short to mid term solution for our EKS based cluster. And, Cloudwatch supports exporting to S3, so once we're ready, we can begin ingesting the logs from S3 into a Brim viewable space.

This helm chart looks promising.


Use update-only Federator in GN controllers

Use update-only Federator as the update status Federator was problematic.
The Reason field in metav1.Conditon must be non-empty
The AllocatedIPs field needs to specify "omitempty" as it's not required.

@tpantelis After this PR is merged, we should update submariner-operator to use latest Submariner repo right?

@tpantelis After this PR is merged, we should update submariner-operator to use latest Submariner repo right?

I don't think we need to yet - we haven't converted to the new controllers.

@tpantelis After this PR is merged, we should update submariner-operator to use latest Submariner repo right?

I don't think we need to yet - we haven't converted to the new controllers.

Yes, I meant to say when we move to new controllers.


Name of the website

@manankohlii have you already selected your website name means spacex data?

can I work on this issue ? and can you elaborate the issue ...

Hello, this issue does not need any work right now. The project was made with the purpose of getting data regarding SpaceX launches so the name for now will remain the same. I am closing the issue.

Okay!!!


libjxl: build against system lcms2

prevent accidentally building against vendored libs. Fixes build of pkgsMusl.libjxl.
Change-Id: I8f1cba112991b47f0951acc2a2471757a9c440bb

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I think it’s probably for the best to, as we’ve had some uncomfortably large channel bumps recently and Hydra has been on fire a little bit with the release.

The change broke patchPhase:

https://github.com/NixOS/nixpkgs/pull/359952


Removal of Zookeeper dependency

With the anticipated removal of Kafka's dependency on Zookeeper via KIP-500, are there any plans to remove kafka-monitor's current dependency on Zookeeper?

Hello opsj,
Thanks for submitting this issue!
Yes, there are plans to implement this in the next quarter (Oct~Dec of 2020 calendar year) for the anticipated removal of Kafka's dependency on Zookeeper via KIP-500.


Git Tags are being set locally but not on remote?

It appears git tags are only being  set locally and not pushed to remote.

This was an issue in local repos with Git / GitKraken.  SlugCI is working correctly.


fix: multiselect crashing (#18577)

Description
Hotfix from this commit https://github.com/appsmithorg/appsmith/commit/058500704efa72c901ff3d519cfa0cfd2be2e3e0
Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=cac5bac


Use ruff instead of flake8 and pylint

Upgrade to ruff instead of flake8 and pylint, using repo-conformance to handle cleanup.

Codecov Report

Merging #274 (1386484) into main (521663e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage   97.01%   97.01%
=======================================
  Files           9        9
  Lines         906      906
=======================================
  Hits          879      879
  Misses         27       27

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


pythran func compiled by g++ produces wrong output, clang OK

code here
https://gist.github.com/nbecker/071f130268881ea3cde8ec373a43a2a9
Compiled with g++ final assertion fails.  Passes on clang++
.pythranrc--------------
[compiler]
defines=USE_GMP USE_XSIMD
undefs=
include_dirs=/usr/include/openblas
libs=gmp gmpxx stdc++
library_dirs=
cflags=-std=c++17 -fno-math-errno -w -O3 -march=native -ffast-math
#cflags=-std=c++11 -O0 -w
ldflags=
#CXX=g++
CXX=clang++
#CC=gcc
CC=clang
blas=openblas
ignoreflags=-fstack-clash-protection -flto-partition=none
[pythran]
complex_hook=True

Tested on
 cat /proc/cpuinfo
processor	: 0
vendor_id	: GenuineIntel
cpu family	: 6
model		: 154
model name	: 12th Gen Intel(R) Core(TM) i7-1280P
stepping	: 3
microcode	: 0x423

also on
 cat /proc/cpuinfo
processor	: 0
vendor_id	: AuthenticAMD
cpu family	: 23
model		: 49
model name	: AMD EPYC 7262 8-Core Processor
stepping	: 0
microcode	: 0x8301025

Tested on
g++ --version
g++ (GCC) 12.2.1 20221121 (Red Hat 12.2.1-4)

 clang++ --version
clang version 15.0.6 (Fedora 15.0.6-1.fc37)

Can you try whithout -ffast-math

I can confirm that without -ffast-math the error is corrected.
This is the first time I've seen -ffast-math cause this behavior.  I
thought it was only supposed to make small differences in extreme corner
cases, for example, for denormalized values.  Here it's making a large
difference where I believe the values are not extreme.  Something is wrong.
On Sat, Dec 31, 2022 at 9:50 AM serge-sans-paille @.***>
wrote:

Can you try whithout -ffast-math
—
Reply to this email directly, view it on GitHub
https://github.com/serge-sans-paille/pythran/issues/2059#issuecomment-1368225288,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA4VUDSILJMY3Q373CI4ATWQBB3PANCNFSM6AAAAAATKN4FMM
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Those who don't understand recursion are doomed to repeat it

On Sat, Dec 31, 2022 at 11:54:44AM -0800, ndbecker wrote:

I can confirm that without -ffast-math the error is corrected.
This is the first time I've seen -ffast-math cause this behavior. I
thought it was only supposed to make small differences in extreme corner
cases, for example, for denormalized values. Here it's making a large
difference where I believe the values are not extreme. Something is wrong.

Can you check without XSIMD (but still fast math) too ?

no USE_XSIMD, -ffast-math: pass
USE_XSIMD -ffast-math: fail
USE_XSIMD, no -ffast-math: pass

On Sun, Jan 1, 2023 at 3:35 AM serge-sans-paille @.***>
wrote:

On Sat, Dec 31, 2022 at 11:54:44AM -0800, ndbecker wrote:

I can confirm that without -ffast-math the error is corrected.
This is the first time I've seen -ffast-math cause this behavior. I
thought it was only supposed to make small differences in extreme corner
cases, for example, for denormalized values. Here it's making a large
difference where I believe the values are not extreme. Something is
wrong.

Can you check without XSIMD (but still fast math) too ?
—
Reply to this email directly, view it on GitHub
https://github.com/serge-sans-paille/pythran/issues/2059#issuecomment-1368386957,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA4VUCEAAOPUXXIWRAMUVDWQE6U5ANCNFSM6AAAAAATKN4FMM
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Those who don't understand recursion are doomed to repeat it

SO the problem is definitively xsimd non-support for fast-math, which is a known problem (and not an easy one to solve). Please report on xsimd bug tracker, I'll close the pythran issue.


Refactor bind args ember cli fix

test failures are pre-existing, this makes it so /tests can be viewed in browser (likely improve productivity in fixing the existing bugs)

I'm pretty sure the last PR was passing in Travis.


Fixed typo in README.md

Hey @jooooel. Thanks for noticing and contributing a fix! We really appreciate it.

i think the "correction" ( For example, if you specify akamaki: propertySection papi you would set the following ENV variables:  ) may
need another correction
On Mon, Nov 20, 2023 at 6:10 PM Ian Wahbe @.***> wrote:

Merged #324 https://github.com/pulumi/pulumi-akamai/pull/324 into
master.
—
Reply to this email directly, view it on GitHub
https://github.com/pulumi/pulumi-akamai/pull/324#event-11018552477, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AB77TQWH2WWMUAJLQWJYAELYFQERHAVCNFSM6AAAAAA7CMYHZWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGAYTQNJVGI2DONY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Yes. Yes it does.


mesheryctl mesh tests

Notes for Reviewers
This PR fixes #
Mesheryctl unit tests for mesh pacakage
Signed commits

[ ] Yes, I signed my commits.

🚀 Preview for commit f847007355b2c45b0210557b0ffba1f095fb3bcc at: https://652555d8ce4de52f8de379ef--meshery-docs-preview.netlify.app

Thanks for raising the PR, let's Discuss this in the Meshery Development Call today,
Please add this as an agenda in the Doc  : Doc

// @zakisk @alphaX86


Import user watchlist and auto request it

Is your feature request related to a problem? Please describe.
Better user experience
Describe the solution you'd like
An implementation like Omni's - a user adds an entry to their watchlist and Ombi will automatically request it (Shows have an additional config option to auto request the full show or just the latest season)
Describe alternatives you've considered
N/A
Additional context
https://www.reddit.com/r/Ombi/comments/tx8w0s/plex_watchlist_integration/
https://github.com/Ombi-app/Ombi/pull/4576
https://docs.ombi.app/settings/plex/#enable-user-watchlist-requests

Would love to see this feature..


Continuation indent is doubled when indentation and function signature are enabled

Expected Behavior
I expect a single indent to be used for continuation indents.
The Kotlin style guide migration suggests that:

In Kotlin coding conventions, it's recommended to use a single indent in cases where the long continuation indent has been forced before.

Observed Behavior
A double indent is being used.
Steps to Reproduce
repro project
I'm using ktlint through detekt, using the command ./gradlew detektMetadataMain. In between each of these cases, I am running git reset --hard in order to reset the file to original formatting. The rules can be configured in the detekt.yml file.

Indentation and FunctionSignature enabled - two function bodies are moved inline with the signature and indentation is doubled for continuations
Indentation enabled and FunctionSignature disabled - no changes
Indentation disabled and FunctionSignature enabled - two function bodies are moved inline with the signature

Your Environment

Version of ktlint used: 0.46.1 (through detekt 1.22.0-RC1)
Version of Gradle used (if applicable): 7.5.1

OK I followed the cli instructions and when running ktlint at the root of that project the issue is present.

Also minimize your example file to contain the least amount of code that displays the problem. Finally, also enclose the expected output.

It is not clear to me what exactly you perceive as the problem. Please paste code, formatted as you would have expected it.

I forgot to configure ktlint the way I have detekt configured :see_no_evil:
After doing that, ktlint behaves correctly. I will raise the issue with detekt.

I forgot to configure ktlint the way I have detekt configured 🙈
After doing that, ktlint behaves correctly. I will raise the issue with detekt.

Tnx for confirming.


C1 vs C2 Surface Verification

keyword_APS2_City_verification   |    by<EMAIL_ADDRESS>
Relates to source code and job outputs in https://access-svn.nci.org.au/trac/nwp/browser/APS2/branches/verification/c1_c2/sfc
Just a ticket to record progress so far
Started out in access-svn Ticket 3 but email does not work from access-svn

Issue migrated from trac:210 at 2024-01-31 18:15:15 +1100

<EMAIL_ADDRESS>uploaded file C1_C2_sfc.xlsx (12.1 KiB)
Spreadsheet of C1 vs C2 Percentage Improvement in surface verifications


Incompatibility with Cython 0.22

Fiona is currently incompatible with the newest release of Cython (v0.22); this is only an issue for development using v0.22 and it compiles fine with v0.21.2.  Cython spits out a bunch of errors of the form
Cythonizing fiona/_geometry.pyx

Error compiling Cython file:
------------------------------------------------------------
...

cdef class OGRGeomBuilder:
    """Builds OGR geometries from Fiona geometries.
    """
    cdef void * _createOgrGeometry(self, int geom_type) except NULL:
        ^
------------------------------------------------------------

fiona/_geometry.pyx:138:9: Signature not compatible with previous declaration

Error compiling Cython file:
------------------------------------------------------------
...
    cdef build(self, void *geom)
    cpdef build_wkb(self, object wkb)

cdef class OGRGeomBuilder:
    cdef void * _createOgrGeometry(self, int geom_type)
             ^
------------------------------------------------------------

The problem is with non-Cython cdef declarations that end with except NULL, like here.  Apparently the new version of Cython is stricter about such declarations, see here.

@youngpm I ran into this with Rasterio, too. My temporary solution there was to pin cython==0.21.2 in requirements-dev.txt. Let's do that for Fiona and I'll take on the migration to Cython 0.22 when we get closer to a 1.6 release.


Update release workflow

As said in https://github.com/taiki-e/install-action/pull/42#issuecomment-1372184541, I would like to help improve release staff. (If work on this is in progress on your end and you do not need this patch, feel free to close this PR.)
This patch updates the release workflow and makes the release work on x86_64 linux-gnu/linux-musl/macos/windows and aarch64 linux-gnu/linux-musl/macos. The following are specific changes:

Add x86_64/aarch64 linux-musl

Closes https://github.com/xd009642/tarpaulin/issues/1130

Remove aarch64 windows.

aarch64 linux fails to build [^1]: https://github.com/taiki-e/tarpaulin/actions/runs/3875026523/jobs/6606999714 EDIT: fixed in https://github.com/xd009642/tarpaulin/pull/1174/commits/5476833acd2cf994ebecba6949d29aeb74a857e7
aarch64 windows doesn't support profiler_builtins

Enable vendored-openssl feature

At least on linux-musl we cannot build without it. [^1]
For now, I enabled this for all targets, but it is possible to control whether this is enabled or disabled per target.

Use the latest taiki-e/create-gh-release-action and actions/checkout
Update binstall metadata to match new archive names.

I tested this with a fork by temporarily disabling the configs around cargo publish; here is generated release: https://github.com/taiki-e/tarpaulin/releases/tag/0.23.1
I also confirmed that the binaries created in the above test pass install-action's CI in all environments: https://github.com/taiki-e/install-action/actions/runs/3875547860/jobs/6608244922
cc https://github.com/taiki-e/install-action/pull/42
fyi @thomcc @NobodyXu
[^1]: These targets are included in the test matrix in rust.yml, but the job is actually testing the host target instead of these targets because the --target option is not passed to cargo.

But maybe that's because they're building on target not via cross and my detecting of x64_64 in my build.rs doesn't work when cross compiling 🤔

Ah, #[cfg] in the build script refers to the host target on which the build script is run, so the following line seems to be causing the problem when cross-compiling.
https://github.com/xd009642/tarpaulin/blob/5f5e566e173d34afe7919b480b40336c4aaf6537/build.rs#L13-L14

Yeah that what I was concerned about... Is there a way in build scripts to access the actual target architecture you're compiling for :thinking:

Is there a way in build scripts to access the actual target architecture you're compiling for 🤔

Cargo sets those information via CARGO_CFG_* environment variables.

Fixed build scripts and re-added aarch64 linux/macos to the workflow.
I can confirm that the cross-compilation issue on aarch64 linux has been fixed: https://github.com/taiki-e/tarpaulin/actions/runs/3876026314/jobs/6609363516

If you just give me a ping when this is ready for final review/merge as I notice there's still an unresolved discussion RE mac. Looking forward to giving this a spin :tada:

This should now be ready for review.

LGTM, thanks a lot for this :tada:


Abbott Onboarding - Direct to ReportStream for STLT Reporting

Abbott wishes to start a pilot with ReportStream to begin reporting data to states. This is a placeholder to document the work and next steps for onboarding operations.

2/11: Staging key and updated instructions shared with user navicanonprod in keybase
Next steps are to review Abbott's current data schema, and update or create a new child schema from Direct.schema. Abbott still needs to confirm if they're sending CSV or HL7 files

3/28: Moving to product backlog. Meeting scheduled with Abbott this week.

3/31: Met with Abbott team on 3/30 to discuss next steps with onboarding. Awaiting sender's confirmation on outstanding questions and next steps.

Meeting scheduled with Abbott on 4/12 to provide demo of submission history API. Jim and Carlos from Pipeline also invited to provide the demo.

@jbiskie Do you recall any takeaways from the last meeting with Abbott on state reporting? I believe the last meeting Pipeline was going to demo the submission history API.

5/19: Higher level discussion between CDC and Abbott are pending. Iceboxing until we have more clarity on a roadmap.

Closing due to time line


docs: add docs on issuing jsonld credentials

Adds documentation on issuing JSON-LD credentials. Present Proof is todo and dependant on PR #1125.

Codecov Report

Merging #1136 (b6d7a28) into main (7541002) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1136   +/-   ##
=======================================
  Coverage   98.70%   98.70%
=======================================
  Files         430      430
  Lines       24195    24195
=======================================
  Hits        23881    23881
  Misses        314      314

Looks good. FYI - @ianco - perhaps you can extend this as you do the demo changes.

Yep will do just looking now

Present Proof is todo and dependant[sic] on PR https://github.com/hyperledger/aries-cloudagent-python/pull/1125.

Present Proof (JSON-LD Credentials) mentioned in the OP is still flagged TODO. PRs #1125 and this #1136 closed long ago. Maybe a new issue should be created for tracking that?


remove docs

remove documentation which was moved to the website

I prefer to have the low level documentation (running-modelix) next to the source code and only move the high level documentation to the website. This makes it easier to keep it up to date and you always have to correct instructions for your version.

Sounds good then I remove the running modelix part from the website and bring back that document here. What about the entities "tutorial" shall we have this here as well?

A tutorial is high level documentation. There the details are not so important. I will probably not update the tutorial every time I change something. Instead we can mention the version the tutorial was written for. The tutorial can be move to the website.


Dashboard: Focused grid items no longer initially cut off

Summary

prevents scrollable content being focused behind squishable content (headers)
Builds on PR #4488

Relevant Technical Choices

Adds a new value to LayoutProvider to track the vertical space taken up by the dashboard header in the Squishable component.
This value is updated when the Squishable children change and when scrolled so that we have the proper vertical pixel size that the header is taking up and can use it as the scrollable component's top position to keep scrollable content from reaching the actual top of the browser window.
Eliminates my early PR calculating the space to set table header to be sticky - now that can just be top: 0 which feels way better.

To-do

The trade off here is that now the popover menus inside of the scrollable container get cut off on overflow:scroll, but without the update to control the top we are back tot he focused items being under the header

User-facing changes

When you use the keyboard to tab into a grid it should no longer scroll up slightly, the entire grid should remain in view.
When you scroll down and then swap to list view on my stories you should get sent back to the top of the page (and vice versa)

Testing Instructions

Verify that focusing on grid items is no longer out of view when using a keyboard
Verify that when you switch layout views on my stories while scrolled down on the page that you get sent to the top of the view
Verify that table headers in list view of my stories are still fixed to the top available space on scroll
Verify all of the above without the telemetry banner and with it.

Addresses #4470

Closing in favor of: https://github.com/google/web-stories-wp/pull/4534 which solves this issue more elegantly without affecting perf.


Tackle application should be installed in the Tackle Operator namespace

It is not said explicitly to install the application in the tackle operator namespace:
https://tackle-docs.konveyor.io/documentation/doc-installing-and-using-tackle/master/index.html#installing-tackle-application_tackle
If you don't do that the application will not be deployed.

Hi any update of this?

Closing since doc has moved to another repo.


[controller] resurface bundledeployment errors

This PR enables the operator object to resurface the errors in Rukpak by setting its conditions as "BundleDeploymentFailed" if any of the BD errors.

/hold

/hold cancel

Have created an issue for follow-ups https://github.com/operator-framework/operator-controller/issues/127. Will have a PR ready for those as soon as this merges.


Can't build tensorflow

Issue type
Build/Install
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
2.18
Custom code
No
OS platform and distribution
Linux Gentoo
Mobile device
No response
Python version
3.11
Bazel version
Bazelisk 1.22.1 (bazel 6.5.0)
GCC/compiler version
llvm-17 clang17
CUDA/cuDNN version
12..6.1 / 9.5.0
GPU model and memory
RTX 3050 laptop 8GB, but compiling for RTX 6000 ADA
Current behavior?
Hello everyone.
I am new to tensorflow building and it seems that I can't manage to do it correctly. Whatever version of CUDA or CUDNN I choose the builds always fail. Currently, I am trying to compile from source using the command
bazel build -j 14 --local_ram_resources=HOST_RAM*.8 \
  --config=cuda_wheel \
  //tensorflow/tools/pip_package:wheel \
  --repo_env=HERMETIC_CUDA_VERSION="12.6.1" \
  --repo_env=HERMETIC_CUDNN_VERSION="9.5.0" \
  --repo_env=HERMETIC_CUDA_DRIVER_VERSION="550" \
  --repo_env=HERMETIC_CUDA_COMPUTE_CAPABILITIES="sm_89" \
  --repo_env=WHEEL_NAME=tensorflow_test \
  --verbose_failures

However, it returns the error "clang-17: error: cannot find libdevice for sm_89; provide path to different CUDA installation via '--cuda-path', or pass '-nocudalib' to build without linking with libdevice
clang-17: error: cannot find CUDA installation; provide its path via '--cuda-path', or pass '-nocudainc' to build without CUDA includes
clang-17: error: cannot find CUDA installation; provide its path via '--cuda-path', or pass '-nocudainc' to build without CUDA includes
Target //tensorflow/tools/pip_package:wheel failed to build
INFO: Elapsed time: 893.679s, Critical Path: 71.04s
INFO: 11895 processes: 5385 internal, 6510 local.
FAILED: Build did NOT complete successfully"
I must admit that don't understand why it fails. As I understand the recent updates to TF, it is supposed to download the necessary CUDA and CUDNN versions itself, so I don't see which path I am supposed to provide here. I have already tried to use the recommended CUDA and CUDNN versions, but it didn't help with my problem. I have read throughout the documentation in both https://github.com/openxla/xla/blob/main/docs/hermetic_cuda.md#environment-variables-controlling-the-hermetic-cudacudnn-versions and https://www.tensorflow.org/install/source?hl=en but it doesn't help much. Is there any tutorial I could follow for compiling tensorflow, or anyone that could help me with that?
Thank you very much.
 (I also think that using bazel build without --config flags should work too)
The build currently also fails because of an error in configure script. The fix should be upstream soon, the workaround before it lands is to change the following lines of .tf_configure.bazelrc from:
build --config=cuda
test --config=cuda

to:
build --config=cuda_clang
test --config=cuda_clang

This should be done after running configure. Thank you!


feat(win): add 2.206 timestamp and update gd in cmake

disables forward compat

mat impl'd the same thing in a7bf4ef5ae4cb0c4b8c896bcd9151a1680611bd6


Fix #19346 - avoid MoreThanOne Error

This simple commit will ensure that we specify the "Branch" prefix when we want to create new branch. Fix #19346
Otherwise git would check between /refs/heads/tags and /refs/heads/branch and return
error: src refspec mytest matches more than one.
error: failed to push some refs to 'branch'
when there is a tag sharing the same name than the branch.

Although I think this is worthwhile I suspect that there will be multiple other problems further down the line. Have you completely tested how Gitea behaves when there are similar branch/tag names?

Although I think this is worthwhile I suspect that there will be multiple other problems further down the line. Have you completely tested how Gitea behaves when there are similar branch/tag names?

I tested it manually on my built instance with latest main, and it worked :
Creating branches from the problematic branch, or creating from other branches
Even creating from branch of branch of the branch that is sharing the tag name.
Also creating a new file or a pull request in the branch that is sharing the tag name, and of children.

From the moment the Tag is created with the same name as the branch, I have seen no problems, but well...
If you want I can try to add more tests to this ?

By testing I meant general UI testing. e.g. How does open PRs from this duplicate branch work? Will do the correct thing? Can you create a PR from the tag and/or the branch? Does it just default to the branch? What happens when you view the branches page on the repository? Do the counts work correctly? How about the Tag page?

By testing I meant general UI testing. e.g. How does open PRs from this duplicate branch work? Will do the correct thing? Can you create a PR from the tag and/or the branch? Does it just default to the branch? What happens when you view the branches page on the repository? Do the counts work correctly? How about the Tag page?

Some of the questions seems more general to the PR modules (not affected by this one). Some questions like Can you create a PR from the tag and/or the branch? I think it's correct now (I have checked all calls to the CreateNewBranch before, all passed-in arguments are branch names).
Are these questions as blocker?

Codecov Report

Merging #19557 (31484c9) into main (1597e2d) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main   #19557   +/-   ##
=======================================
  Coverage   47.39%   47.39%
=======================================
  Files         952      952
  Lines      132577   132576    -1
=======================================
+ Hits        62829    62840   +11
+ Misses      62174    62156   -18
- Partials     7574     7580    +6

Impacted Files
Coverage Δ

modules/setting/log.go
58.23% <0.00%> (ø)

routers/api/v1/repo/language.go
57.14% <100.00%> (-0.76%)
:arrow_down:

services/repository/branch.go
55.38% <100.00%> (ø)

models/asymkey/gpg_key_common.go
52.63% <0.00%> (-3.95%)
:arrow_down:

modules/notification/mail/mail.go
39.04% <0.00%> (-2.74%)
:arrow_down:

modules/log/event.go
59.92% <0.00%> (-2.34%)
:arrow_down:

modules/notification/ui/ui.go
58.92% <0.00%> (-1.79%)
:arrow_down:

models/unit/unit.go
46.08% <0.00%> (-1.74%)
:arrow_down:

models/notification.go
63.17% <0.00%> (-1.09%)
:arrow_down:

models/repo_list.go
75.66% <0.00%> (-0.49%)
:arrow_down:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 094c8fd...31484c9. Read the comment docs.

please send backport


How do i access the rate limit information?

I'm running into rate limit issues. I want to check the rate limit before making more calls

Hi @corsacca,
You can monitor your current status by examining two HTTP headers that are returned with each request you make:
http
X-Rate-Limit-Limit: The ceiling for the request you just made
X-Rate-Limit-Remaining: The number of requests you have left for the current 1 hour window

You cannot currently see when your rate limit counter is reset.
Source: https://developers.podio.com/index/limits


Update to .NET 5

I think this pushes it forward (and closes out #77)- though I want to call a little attention to the targetting of Fornax.Core - which I have left at netstandard2.0 - as pushing it to net5.0 has implications for things like FSIRefs and its (current - 2) version compatibility handling.
That said, if we want to burn our ships on the shore of .NET 5, it's an easy enough update to the PR! 😉

Prior to opening the PR, I was waffling a bit on that netstandard / net5.0 switch - and having run stuff locally under net5.0.  Having sorted out the cause of that initial failed build, I figured I'd take a peek, and it sure does seem like without Core being targeted to net5.0, we don't get support for stuff like #r "nuget: Package" support.
Is there a way around this that I'm not immediately seeing? :)

Prior to opening the PR, I was waffling a bit on that netstandard / net5.0 switch - and having run stuff locally under net5.0.  Having sorted out the cause of that initial failed build, I figured I'd take a peek, and it sure does seem like without Core being targeted to net5.0, we don't get support for stuff like #r "nuget: Package" support.
Is there a way around this that I'm not immediately seeing? :)


Revert "less: Fix withSecure regression"

Reverts NixOS/nixpkgs#352298
Too many darwin rebuilds, moving to staging.

for anyone else who's lost: this will land in master (and should therefore just barely make it into 24.11) with #354201.


fix error on add badge-group to user (#2533)

The issue was closed, but this is still not fixed.
see #2533

I do not have any errors in 5.7.5RC1 when assigning a badge group to a user. Please verify with the latest release candidate. The existing code in there should absolutely work – it was the underlying functionality of the Action class that wasn't retrieving the class when calling getByHandle

Strange, I got errors on 4.2 and 5RC1 (updated)
I'll setup a fresh 5.7.5RC1 in a couple of days, test it again and get back here

Oh, I know why it is. We need to add something specific to the update
script that marks the action as having a custom class. Try running this in
your database:
update UserPointActions set upaHasCustomClass = 1 where upaHandle =
'won_badge';

Added this query to the update to 5.7.5 in 3820b69

ran the query, cleared caches, relogged, but still:
{"error":{"type":"Whoops\Exception\ErrorException","message":"Argument 2 passed to Concrete\Core\User\Point\Action\Action::addDetailedEntry() must be an instance of Concrete\Core\User\Point\Action\ActionDescription, instance of Concrete\Core\User\Group\Group given, called in /home/anchoric/domains/anchor-ict.com/public_html/5-7-4/updates/concrete<IP_ADDRESS>_remote_updater/concrete/src/User/User.php on line 515
If you can't reproduce it..maybe it is my setup...
I'm running out of time for now. Will test it again later on a fresh install.
Thanks for looking at this again, Willem

Looking at the error it seems clear you're running this on <IP_ADDRESS>, rather
than 5.7.5RC1.
On Mon, Jul 13, 2015 at 9:50 AM, Willem<EMAIL_ADDRESS>wrote:

ran the query, cleared caches, relogged, but still:
{"error":{"type":"Whoops\Exception\ErrorException","message":"Argument 2
passed to Concrete\Core\User\Point\Action\Action::addDetailedEntry() must
be an instance of Concrete\Core\User\Point\Action\ActionDescription,
instance of Concrete\Core\User\Group\Group given, called in
/home/anchoric/domains/anchor-ict.com/public_html/5-7-4/updates/concrete<IP_ADDRESS>_remote_updater/concrete/src/User/User.php
on line 515
If you can't reproduce it..maybe it is my setup...
I'm running out of time for now. Will test it again later on a fresh
install.
Thanks for looking at this again, Willem
—
Reply to this email directly or view it on GitHub
https://github.com/concrete5/concrete5/pull/2725#issuecomment-120991315.

aye, busted, too many open windows, sorry about that
Your query works like a charm on 5RC1.
Thanks !

Good to hear!
On Mon, Jul 13, 2015 at 10:26 AM, Willem<EMAIL_ADDRESS>wrote:

aye, busted, too many open windows, sorry about that
Your query works like a charm on 5RC1.
Thanks !
—
Reply to this email directly or view it on GitHub
https://github.com/concrete5/concrete5/pull/2725#issuecomment-120999069.


Move function to local class

In thinking about common user scenarios, I realized there is a whole use case that I overlooked, and this is the first in line:
User is doing one of the following:

Copying source from one place to another (for any number of reasons)
Migrating source from one design to another (related to 1)

A common case I see currently is people copy over functions and then one-by-one move them into a class. This could be push-button.

This behavior has been added as of the latest release:
https://github.com/cmstead/js-codeformer/releases/tag/v1.26.0


Compose paths are working relative to src root instead of relative to the file in which they are used

This demonstrates the issue:
https://github.com/hobbit125/aurelia-compose-issues/tree/master/src
Specifically here:
https://github.com/hobbit125/aurelia-compose-issues/blob/master/src/pages/welcome.html
What's committed is working, but the path is written relative to the src root instead of relative to the file.

Release coming in a just a minute...

aurelia-templating v0.15.3 is released. You can use jspm udpate to get the fix. Apologies for the issue!