The content property is not consistently implemented in all Stadust components

Bug Report
Steps
The content property is not consistent across all Stardust components. This can lead to confusion or incorrect usage of the Components when the content slot is in question.
Expected Result
I would expect that the content property should be used consistently in all Stardust components. As far as I remember, we decided to make the content property shorthand for the Slot component, and use it everywhere across our components. This would allow us to use the content as an actual shorthand slot inside each component.
On top of this, we are not even using consistent propTypes and interfaces for the content property. If we decide to go with the shorthand, then it can simple be defined as  customPropTypes.itemShorthand in the propTypes and ShorthandValue in the props' interface.
Actual Result
Not all components support it. Actually only few components are following this convention. Let's take a look into two examples of a Component that supports it (Button) and of Component that do not support this (Divider):
Button component
Example code:
<Button content={{content: "Some text", as: 'span'}} />

Result:

Divider component
Example code:
<Divider content={{name: "Some text", as: "span"}} />

Result:
Error thrown

Version
0.12.0
Proposal
Let's try to make the content property to be shorthand for the Slot component in all Stardust components. If we see that this is not possible for some of the components, I would suggest we document it explicitly in the docs site, so that it won't create confusion to the users.

fixes #504 correct me if I'm wrong @mnajdova

Exactly, it should solve that issue as well.

Couple of additional thoughts. As this proposal would add additional dom element in the component, we must be sure that we are okay with it for all components. It seems kind a strange for the component that contains just the content in their structure. For example, let's take the Text component. Previously the rendered html was the following:
 This text is light.

After the changes, we have additional span rendered:

  This text is light.

If we decide that we won't do this for some components however, we will stind end up with the previous problem. Any suggestions would be appreciated.

I think for some components (like Text, Label, Segment) it makes sense to have the content slot as a primitive type (mostly strings).
That's because it's pretty obvious (or should be) for the user that the content of a Text, Label (maybe less for Segment but it's not hard to grasp) should be just some text to be rendered in the main area.

Apart from the issue with the component containing only the content property, here is an overview for all other components regarding the content property:
Components not containing the content property:

Accordion
Attachment
Avatar
Chat
Form
FormField
Icon
Image
Layout
List
Menu
PortalInner
Provider
ProviderConsumer
RadioGroup
RadioGroupItem
Ref
Status

Components with custom content property

Grid
ItemLayout

Other problems found

Label is using ItemLayout – content is not refactored to be slot, but it is used as main inside the ItemLayout’s main property.
ListItem – same as Label

Question

Can the MenuItem be refactor to use the content as a shorthand?
Can the Portal be refactor to use the content as a shorthand?
Label inside RadioGroupItem is used as a contentShrothand, again because of item layout is adding additional spans – should be refactored as the ChatMessage

MenuItem currently renders as following:
<wrapper = li>
  <ElementType = a>
    <Icon />
    content
  </ElementType>
</wrapper>

If we refactor content to be a shorthand, it will be wrapper by span, resulting in every item being li > a > span.
Is that what we want? Or do we want, in MenuItem.tsx, to check typeof content and leave it untouched if it is a string and create a Slot otherwise?

For the Layout related issues:
I feel we should remove Layout and ItemLayout from our codebase altogether :)
Refactoring Chat.Message to not use them was not that difficult and we should think if these components provide more benefits than cons; related to #27, #241  and #477

Yes, this is a tough issue.  Here is more conversation and design on the same topic:
Standardize content prop: https://github.com/Semantic-Org/Semantic-UI-React/issues/1364
Standardize shorthand prop names for primary content: https://github.com/Semantic-Org/Semantic-UI-React/issues/391
The conclusion in those issues was to leave the inconsistency we have in favor of more correct markup.  After our offline discussions here at Stardust, we still think the same thing.

Here's another summary and comparison of the content prop:
REMOVE?        content is only aliasing children
NECESSARY? content is node composed into children
NECESSARY? body is a component
Shorthand usages:
Menu Item === { icon: '', content: '' }
Button === { icon: '', content: '' }
Divider === { children: '' }
Slot === { children: '' }
Popup === { body: {} }
Message === { body: {} }
This API would be more confusing to users.  Also, if the component changes its markup, it has to break its API typings.  Let's stick with content for now and only change typings 👍

@miroslavstastny I believe you had a closing comment on this topic after we discussed the above (see my last comment).  Can you post here and close this issue?

The conclusion in [Semantic UI React's] issues was to leave the inconsistency we have in favor of more correct markup. After our offline discussions here at Stardust, we still think the same thing.


fileName option isnt published to NPM!?

The version on NPM doesnt contain the fileName option, yet is 0.1.1, the same as the code in your repo.

I apologize for the long delay, the latest version of the code is now published to NPM as v 0.1.2


fwrite() expects parameter 2 to be string, object given

I was following : https://www.hellosign.com/api/signature_request/files
$client = new HelloSign\Client('SIGN_IN_AND_CONFIRM_EMAIL_TO_SEE_YOUR_API_KEY_HERE');
$client->getFiles('fa5c8a0b0f492d768749333ad6fcc214c111e967', $dest_file_path, HelloSign\SignatureRequest::FILE_TYPE_PDF);

but getting error:
exception 'ErrorException' with message 'fwrite() expects parameter 2 to be string, object given' in hellosign/hellosign-php-sdk/library/HelloSign/Client.php:228
Stack trace:
#1 /vendor/hellosign/hellosign-php-sdk/library/HelloSign/Client.php(228): fwrite(Resource id #3, Object(stdClass))
#2 HelloSign\Client->getFiles('515ffc0b46664ea...', '/...', 'pdf')

Hi @itsazzad -
How closely do your parameters match what you've provided in the stack trace #2 section above?, in particular I'm curious if perhaps you're passing a filename in your destination path -- you'll need to provide this.
Also, are you instantiating your client with a HelloSign API Key?

@renderf0x I am using proper API KEY, proper signature_id, dest_file_path like as /var/ww/html/uploads/signed_doc.pdf
But seems to be that the rest api request is not returning string but returning Object.

@renderf0x Any news?

Heya @itsazzad -- I see what you're running into here.
In addition to what you sent over, I'd guess you're also seeing this error:
PHP Fatal error:  Uncaught HelloSign\Error: [not_found] Not ready
This API endpoint has been changed so that if the files are not yet ready to be downloaded, we'll return an error such as this (as otherwise you can see incomplete results in cases of multiple signers).
I'd guess that if you take the Signature Request ID you're getting, and try this same getFiles request again a small bit later, that this would succeed (as the files would be ready then).
We should adjust the SDK to account for this by checking for the error here before attempting to write the file, but we'll still be returning this Not ready error up the chain.
You should be able to catch this, though, and have your application retry in the event of a not found error.
We'll take a look at passing the error better in the SDK, but a try/catch with a timed retry here should take care of this for you for now.
Cheers,
//Derek

Hi @itsazzad,
I checked our logs and it seems you're passing a signature_id instead of a signature_request_id, which is invalid. A single signature request can have multiple signature objects associated with it; This API endpoint expects the ID of the signature request itself.
Thanks,
Stephen

@itsazzad , @BHSPitMonkey probably has the answer you're looking for here -- please try his suggestion.
In the meantime, I've fixed error handling on that function as well.

@BHSPitMonkey and @renderf0x ,
Its working but unfortunately not getting the signature in the document even after firing the queue after one minute of the signature_request_signed event.
I was sending related_signature_id;
Now I am using $request_data['event']['event_metadata']['related_signature_id'] to track the related_signature_id and $request_data['signature_request']['signature_request_id'] to get the files.
if($request_data['event']['event_type']=='signature_request_signed'){
   //Matching $request_data['event']['event_metadata']['related_signature_id']
   Now in a queue trying to get files
    $client->getFiles($request_data['signature_request']['signature_request_id'], $dest_file_path, HelloSign\SignatureRequest::FILE_TYPE_PDF);
}

Trying with signature_request_all_signed event

Yes, waiting for the "all signed" event will allow you to grab the final
signed PDF. Note that if you call getFiles too close to the time the event
fires, you may get an error indicating the files are not yet ready. Ideally
your code will be able to handle this and try again.
On Sep 2, 2015 8:36 AM, "Sazzad Hossain Khan"<EMAIL_ADDRESS>wrote:

Trying with signature_request_all_signed event
—
Reply to this email directly or view it on GitHub
https://github.com/HelloFax/hellosign-php-sdk/issues/13#issuecomment-137136090
.


make message $M$ also an element in q-order subgroup

Hi @RyanRiddle
This is the final solution I found to secure the message space.
By squaring the message $M->M^2$, it becomes an element in q-order subgroup. Interestingly, by powering $(q+1)//2$, we can get the unique square root. So decoding is easy.
This makes this library semantic secure.
Disadvantage: no compatible with old ciphertexts.

Hi @weikengchen
Thanks for the PR!
Can you explain in more detail why this works?
Thanks!

I am going to write a blog about this -- recently.
Thanks for patience!


Update map-use-cases.md

Added a header

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/design/map-use-cases.md
86
26
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit a9e6b07:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/design/map-use-cases.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Closing this PR as it is a test PR


While watching streams on twitch, the first few seconds are repeated once

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.08.24. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x ] I've verified and I assure that I'm running youtube-dl 2016.08.24

Before submitting an issue make sure you have:

[x ] At least skimmed through README and most notably FAQ and BUGS sections
[x ] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x ] Bug report (encountered problems with youtube-dl)

Description of your issue, suggested solution and other information
Basically the first few seconds of the stream repeat themselves once.
https://i.lithi.io/cfXu.webm
It works fine if you use livestreamer however.

This should be addressed to mpv developers.

Are you sure, it's not youtube-dl? because livestreamer works perfectly fine.

livestreamer runs videoplayer on its own. Here you don't run youtube-dl directly. Instead you run mpv that somehow runs youtube-dl. Even with this approach it plays fine for me in mpv.

Since using help, or looking trough the options didn't give me a result on how to play videos on certain players.
I will go ahead and ask if you know the right command for it, I've look trough google and it seems that
I used  youtube-dl http://twitch.tv/godglove | "C:\mpv\mpv.exe" based on google results, but it gives me
$ youtube-dl http://twitch.tv/godglove | "C:\mpv\mpv.exe" Traceback (most recent call last):   File "__main__.py", line 19, in <module>   File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3vpw27pc\build\youtube_dl\__init__.py", line 433, in main   File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3vpw27pc\build\youtube_dl\__init__.py", line 423, in _real_main   File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3vpw27pc\build\youtube_dl\YoutubeDL.py", line 1786, in download   File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3vpw27pc\build\youtube_dl\YoutubeDL.py", line 691, in extract_info   File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3vpw27pc\build\youtube_dl\extractor\common.py", line 347, in extract   File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3vpw27pc\build\youtube_dl\extractor\twitch.py", line 406, in _real_extract   File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3vpw27pc\build\youtube_dl\extractor\twitch.py", line 55, in _call_api   File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3vpw27pc\build\youtube_dl\extractor\common.py", line 539, in _download_json   File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3vpw27pc\build\youtube_dl\extractor\common.py", line 507, in _download_webpage   File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3vpw27pc\build\youtube_dl\extractor\common.py", line 414, in _download_webpage_handle   File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3vpw27pc\build\youtube_dl\extractor\common.py", line 384, in _request_webpage   File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3vpw27pc\build\youtube_dl\extractor\common.py", line 564, in to_screen   File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3vpw27pc\build\youtube_dl\YoutubeDL.py", line 448, in to_screen   File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3vpw27pc\build\youtube_dl\YoutubeDL.py", line 462, in to_stdout   File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3vpw27pc\build\youtube_dl\YoutubeDL.py", line 451, in _write_string   File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3vpw27pc\build\youtube_dl\utils.py", line 1314, in write_string OSError: [Errno 22] Invalid argument Exception ignored in: <_io.TextIOWrapper name='<stdout>' mode='w' encoding='cp1252'> OSError: [Errno 22] Invalid argument
on CMD

youtube-dl -o - URL | mpv -.

`` youtube-dl -o - http://twitch.tv/goldglove | mpv
mpv git-6980575 (C) 2000-2016 mpv/MPlayer/mplayer2 projects
built on Tue Aug 23 10:05:22 BST 2016
ffmpeg library versions:
libavutil       55.28.100
libavcodec      57.48.101
libavformat     57.41.100
libswscale      4.1.100
libavfilter     6.47.100
libswresample   2.1.100
ffmpeg version: 3.1.2
Usage:   mpv [options] [url|path/]filename
Basic options:
--start=    seek to given (percent, seconds, or hh:mm:ss) position
--no-audio        do not play sound
--no-video        do not play video
--fs              fullscreen playback
--sub-file= specify subtitle file to use
--playlist= specify playlist file
--list-options    list all mpv options
[twitch:stream] goldglove: Downloading stream JSON
[twitch:stream] goldglove: Downloading channel access token
[twitch:stream] goldglove: Downloading m3u8 information
[download] Destination: -
ffmpeg version 3.0.1 Copyright (c) 2000-2016 the FFmpeg developers
built with gcc 5.3.0 (GCC)
configuration: --disable-static --enable-shared --enable-gpl --enable-version3 --disable-w32threads --enable-avisynth --enable-bzlib --enable-fontconfig --enable-frei0r --enable-gnutls --enable-iconv --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libdcadec --enable-libfreetype --enable-libgme --enable-libgsm --enable-libilbc --enable-libmodplug --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenjpeg --enable-libopus --enable-librtmp --enable-libschroedinger --enable-libsoxr --enable-libspeex --enable-libtheora --enable-libtwolame --enable-libvidstab --enable-libvo-amrwbenc --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxavs --enable-libxvid --enable-libzimg --enable-lzma --enable-decklink --enable-zlib
libavutil      55. 17.103 / 55. 17.103
libavcodec     57. 24.102 / 57. 24.102
libavformat    57. 25.100 / 57. 25.100
libavdevice    57.  0.101 / 57.  0.101
libavfilter     6. 31.100 /  6. 31.100
libswscale      4.  0.100 /  4.  0.100
libswresample   2.  0.101 /  2.  0.101
libpostproc    54.  0.100 / 54.  0.100
Input #0, hls,applehttp, from 'https://video-edge-8fa440.jfk03.hls.ttvnw.net/hls75/goldglove_22977895632_505387079/chunked/index-live.m3u8?token=id=2322442575789030747,bid=22977895632,exp=1472094198,node=video-edge-8fa440.jfk03,nname=video-edge-8fa440.jfk03,proto=https,fmt=chunked&sig=d34c4af5df9da662b9b86d88a1118fdca0454f0e':
Duration: N/A, start: 10890.933000, bitrate: N/A
Program 0
Metadata:
variant_bitrate : 0
Stream #0:0: Audio: aac (LC) ([15][0][0][0] / 0x000F), 48000 Hz, stereo, fltp, 116 kb/s
Stream #0:1: Video: h264 (Main) ([27][0][0][0] / 0x001B), yuv420p(tv, bt709/bt709/iec61966-2-1), 1280x720, 60 fps, 60 tbr, 90k tbn, 120 tbc
Stream #0:2: Data: timed_id3 (ID3  / 0x20334449)
Output #0, mpegts, to 'pipe:':
Metadata:
encoder         : Lavf57.25.100
Stream #0:0: Video: h264 ([27][0][0][0] / 0x001B), yuv420p, 1280x720, q=2-31, 60 fps, 60 tbr, 90k tbn, 90k tbc
Stream #0:1: Audio: aac (LC) ([15][0][0][0] / 0x000F), 48000 Hz, stereo, 116 kb/s Stream mapping:
Stream #0:1 -> #0:0 (copy)
Stream #0:0 -> #0:1 (copy)
Press [q] to stop, [?] for help
av_interleaved_write_frame(): Invalid argument
Error writing trailer of pipe:: Invalid argumentframe=    4 fps=0.0 q=-1.0 Lsize=
153kB time=00:00:00.05 bitrate=25051.1kbits/s speed=N/A
video:160kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: unknown
Conversion failed!
ERROR: ffmpeg exited with code 1``

Read closely what I post.

Yes, you definitely wrote more than a command line command telling me to only change the URL text for the URL.
Or add the path to where mpv is at the end too, or maybe  remove mpv for the mpv path. ( which I did )
So detailed. how can anyone go wrong, by guessing.
`` youtube-dl -o - http://twitch.tv/goldglove | mpv "c:/mpv/mpv.exe"
Playing: c:/mpv/mpv.exe
[ffmpeg/demuxer] nut: Error stream_count is (0)
[ffmpeg/demuxer] nut: No main startcode found.
[lavf] avformat_open_input() failed
[ffmpeg/demuxer] nut: Error stream_count is (0)
[ffmpeg/demuxer] nut: No main startcode found.
[lavf] avformat_open_input() failed
Failed to recognize file format.
Exiting... (Errors when loading file)
[twitch:stream] goldglove: Downloading stream JSON
[twitch:stream] goldglove: Downloading channel access token
[twitch:stream] goldglove: Downloading m3u8 information
[download] Destination: -
ffmpeg version 3.0.1 Copyright (c) 2000-2016 the FFmpeg developers
built with gcc 5.3.0 (GCC)
configuration: --disable-static --enable-shared --enable-gpl --enable-version3 --disable-w32threads --enable-avisynth --enable-bzlib --enable-fontconfig --enable-frei0r --enable-gnutls --enable-iconv --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libdcadec --enable-libfreetype --enable-libgme --enable-libgsm --enable-libilbc --enable-libmodplug --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenjpeg --enable-libopus --enable-librtmp --enable-libschroedinger --enable-libsoxr --enable-libspeex --enable-libtheora --enable-libtwolame --enable-libvidstab --enable-libvo-amrwbenc --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxavs --enable-libxvid --enable-libzimg --enable-lzma --enable-decklink --enable-zlib
libavutil      55. 17.103 / 55. 17.103
libavcodec     57. 24.102 / 57. 24.102
libavformat    57. 25.100 / 57. 25.100
libavdevice    57.  0.101 / 57.  0.101
libavfilter     6. 31.100 /  6. 31.100
libswscale      4.  0.100 /  4.  0.100
libswresample   2.  0.101 /  2.  0.101
libpostproc    54.  0.100 / 54.  0.100
[mpegts @ 000001c196188020] Could not find codec parameters for stream 1 (Video: h264 ([27][0][0][0] / 0x001B), none): unspecified size
Consider increasing the value for the 'analyzeduration' and 'probesize' options
[hls,applehttp @ 000001c1939a2900] Could not find codec parameters for stream 1 (Video: h264 ([27][0][0][0] / 0x001B), none): unspecified size
Consider increasing the value for the 'analyzeduration' and 'probesize' options
Input #0, hls,applehttp, from 'https://video-edge-a253d0.jfk03.hls.ttvnw.net/hls75/goldglove_22977895632_505387079/chunked/index-live.m3u8?token=id=6631670748439843762,bid=22977895632,exp=1472095143,node=video-edge-a253d0.jfk03,nname=video-edge-a253d0.jfk03,proto=https,fmt=chunked&sig=da7f92be7844783ba27f27f9136fbf24ac1b03fc':
Duration: N/A, start: 11820.831667, bitrate: 135 kb/s
Program 0
Metadata:
variant_bitrate : 0
Stream #0:0: Audio: aac (LC) ([15][0][0][0] / 0x000F), 48000 Hz, stereo, fltp, 135 kb/s
Stream #0:1: Video: h264 ([27][0][0][0] / 0x001B), none, 90k tbr, 90k tbn, 180k tbc
Stream #0:2: Data: timed_id3 (ID3  / 0x20334449)
Output #0, mpegts, to 'pipe:':
Metadata:
encoder         : Lavf57.25.100
Stream #0:0: Audio: aac (LC) ([15][0][0][0] / 0x000F), 48000 Hz, stereo, 135 kb/s Stream mapping:
Stream #0:0 -> #0:0 (copy)
Press [q] to stop, [?] for help
av_interleaved_write_frame(): Invalid argument
Error writing trailer of pipe:: Invalid argumentsize=       4kB time=00:00:00.23 bitrate= 134.6kbits/s speed=N/A
video:0kB audio:3kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 25.772539%
Conversion failed!
ERROR: ffmpeg exited with code 1 ``
This one gives the same error as the one I used before, except for this time.
It's okay though, I think I know what the problem is, so you can remove the label if you want to.

Yes, you definitely wrote more than a command line command telling me to only change the URL text for the URL.

And you even failed to copy paste it correctly omitting trailing -.

Well, I am sadden to tell you, that I tried it without removing that.
still the same error, but like I said, I think  I know why it's doing it, so you can completely closed the issue now.

Post the log of exactly this command.


Add io module to setup translator design + fixes to CLI tests

Closes #47
Work includes:

Fixing CLI tests for pytest's tmp_path - wasn't writing to a temporary directory and using .absolute() instead of .resolve() for pathlib calls
Added io module for file format read / write operations
Added io.formats to setup the translator design for different supported formats
Added read and write functions to .io to read in supported formats and write out to supported formats, respectively (currently none supported)

For the code coverage, I won't be able to add tests to cover all of io.formats until I added a supported format.
I will be able to do this with my next PR to address issue #48.
So, overall, I won't be able to add any additional test coverage to fix the codecov complaint in this PR.


Ability to View Logs via Machinaris WebUI

Want to see logs from services via the browser.  Examples:

Farming: mainnet/log/debug.log
Plotting: plotman/logs/plotman.log
for each running plot: plotman/logs/2021-05....log
Alerts: chiadog/logs/chiadog.log
Machinaris: machinaris/logs/webui.log

Possible implementation in Flask.  Should it be a tab on main window, or a pop-over log viewer that is in it's own browser window like Unraid does?

This will be available shortly in v0.3.0 release.


Upgrade to newest league/oauth2-client and phpunit

Upgrade to newest league/oauth2-client and phpunit.
Update to newest packages, due to conflict with older phpunit.

Closed due to files are fixed to PHP 7.3


build fails with 0.18.5 (worked in 0.17.4)

First, a related question that could help me: Where is the documentation for ncc?
The readme file leaves many open question (at least for me as a beginner). And due to this lack of documentation I don't even know how ncc is supposed to work or which questions to ask. So I'm afraid, I must explain the whole use-case.
The build on our CI server was still okay with version 0.17.4 - but now fails with 0.18.5.
To me it seems, that ncc is now somehow finding our top-level tsconfig.json file and it tries to build the whole source code - which will not work, because we have a mono-repo and thus have many different tsconfig.json files.
This is how our code is organized:

tsconfig.json - top level ts config
angular.json
.. other files
apps dir

client

tsconfig.app.json
tsconfig.json
tsconfig.spec.json

server

tsconfig.json

...

libs dir

shared
...

node_modules dir
dist dir

apps

server

main.js - created by the prod build
tsconfig-json - created by our ci-script for ncc - content from your readme file

The ci script will first do a regular ng build of the server app which creates dist/apps/server/main.js. Then the ci script will cd to apps/server/ and execute ncc build main.js --minify --out ncc to build ncc/index.js.
It seems that the newer ncc version will traverse the folder tree up, find the top-level tsconfig.json file and then tries to compile all source code: e.g. in apps/client/... - which will fail, because the top-level tsconfig.json file is not suitable for that source code.
As a workaround I tried to delete the top-level tsconfig.json file - then the build works.
Questions:

Why would ncc even try to start the typescript compiler? it already gets the main.js file?
Why would it use the top-level tsconfig.json, when there is a tsconfig.json file in the current directory?
Can I somehow configure which tsconfig.json file it should use?

It sounds like ncc is trying to read tsconfig.json for both .js and .ts source files when it should only look for tsconfig.json when the source file is .ts (or possibly .tsx.
@guybedford Can you explain why this was changed?

Nothing in ncc itself that does the tsconfig.json lookup has changed.
But because ncc builds its dependencies of ts-loader and tsconfig-paths, it could be due to an update of these dependencies in the release that cases the problem.
@johnnyreilly would value your thoughts on what this might be that the tsconfig lookup is going further up the folder hierarchy than previously, and if there is a configuration option in ncc that could resolve this?

Hey @guybedford,
I'm afraid I'm just leaving on my holidays and so I'm not going to spare too much time right now.
I've a couple of quick thoughts before I go though:

It looks like a change in the version of being used by ncc may be the cause of this? Which version change triggered this do you know? It's not obvious from "0.17.4 - but now fails with 0.18.5." which ts-loader versions are in play.

it's possible this may be related to the (excellent😄) work @andrewbranch did to fix a number of minor bugs in ts-loader https://github.com/TypeStrong/ts-loader/releases/tag/v6.0.1

Though given the date on this issue maybe that's not the case.

Thanks for the response here @johnnyreilly, we'll see if we can track it down further here first then.
@tmtron to find the root cause here we'll need to do a bisect on the dependency build. And for that we'll need a reliable replication. If you're able to share a simple repo that demonstrates the problem that would help a lot to get there, otherwise I will come around on this when I'm looking the TypeScript-specific stuff further in about a week or so.

I don' t have the time to make a reproduction repo now.
Bisect is less work, so I've tried that, but came to a strange result.
It seems that I now get the same issue also with ncc 0.17.4 - so my first thought, that the ncc version caused the issue is wrong: it seems that the issue is not caused directly by code changes in ncc, but by some other dependency that has changed.
on our CI-server I found a side-branch where I see one build that still works and the next one fails (on 24th, Aprli, 1 hour apart).

ncc is: 0.18.1 in both cases
in our code base there were only small changes - I am quite sure those are not related
package.json has not changed
pacakge-lock.json has changed a lot

ts-loader is in both cases 5.3.1

unfortunately the package-lock files are difficult to compare.
are there any other dependencies (besides ts-loader) in the package-lock that I should look for?
I could also post the package-lock files somewhere if this helps.

Can someone please confirm my basic understanding of the ncc build:

since I directly feed the main.js file to ncc, I think I don't need any typescript config at all.

i.e. I can delete dist/apps/server/tsconfig-json

ncc will search the parent dirs, until it finds the node_modules folder where it will search for dependencies used in my main.js file (I guess it scanns the require statements)
for some reason, it also picks up the top-level tsconfig.json file: this is a bug: it should ignore this file, since I feed a main.js file to it and not any ts files

for some reason, it also picks up the top-level tsconfig.json file: this is a bug: it should ignore this file, since I feed a main.js file to it and not any ts files

ncc will always read any tsconfig.json file and apply it, even for .js-only builds unfortunately, due to the way we plug in the TypeScript resolver. We could look at only applying the TypeScript resolver when loading a TypeScript module certainly.

@guybedford thanks for the response.
I can live with deleting my tsconfig files during the ci-build before starting ncc - but it would be great if you could improve the docs, so that this fact is clear - especially for new users.
Feel free to close this issue.


Bug 1185021: Part 2 - Let the validator handle errors, particularly soft timeouts

This is on top of #614, since they touch the same code, and requires mozilla/amo-validator#309. There's a temporary commit pointing requirements/prod.txt to that branch which will have to be removed before merging.

This PR needs a rebase.
I like the fact that the timeouts are handled in one place, and there's some good cleanup in there.
There's a few nits, and i'm not sure about making escaped_validation a property, instead of a get_escaped_validation() or escape_validation() methods. I'm not against, but I don't see the point. I know this is mainly a matter of taste, and I've yet to have arguments to convince me that this use case is a good reason to use a property.

There were a few reasons I changed escaped_validation to a property:

When it was tied to an actual database column, the function took arguments, but ignored them for second and subsequent calls. Which should never have been a possibility. The escaped validation results should always be the same, based on the properties of the file, not based on the caller.
And, given that it was, at that point essentially a cached property that was tied to a DB column, and was also created immediately, I didn't understand why it was a function at all.
The name suggested it should be a property.

So, when I was removing that code, I had the idea that it should be a property, and when I got to the point that it would work as a property, I decided to make it one. Beyond that, I was considering making it a cached property, if that turned out to be warranted. So, if it does, it's now a one line change.

OK, re-added settings.VALIDATE_ADDONS, but with a much less intrusive implementation.

Excellent! r+wc


Mixpanel (Export Events) Analytics (Source) initial commit

Mixpanel (Export Events) Analytics (Source) initial commit

Committed https://github.com/mohan-h/experience-platform.en/commit/eaae81af7fff3072e27e32d720d960b07177d57a

The documentation for the connector has been made live at:
https://experienceleague.adobe.com/docs/experience-platform/sources/connectors/analytics/mixpanel.html?lang=en


Compatibility Layer Removal Part 1/2

:hammer_and_wrench: Part 1/2: Compatibility Package Removal
This pull request primarily aims to remove a significant portion of the compatibility package situated at com.paneedah.weaponlib.compatibility.
:question: The Rationale
To understand the rationale for this removal, we first need to delve into the reason for the package's creation.
Vic's Modern Warfare started its journey as a 1.7 mod. When it was updated for newer Minecraft versions, a "compatibility layer" was introduced. This layer, in essence, was a collection of duplicated or modified 1.7 code, tailored to VMW's needs.
So, why is this removal necessary now?
The compatibility layer, initially an asset, has become a liability. It significantly clutters the codebase, making it harder to maintain and comprehend. Worse still, it has been the root cause of numerous compatibility issues, particularly with shaders and FoamFix. Further, it introduces unnecessary overhead, culminating in a drop in performance.
:dart: Key Objectives
The main goals of this removal are as follows:

:memo: Streamline the codebase, making it easier to work with and comprehend.
:shield: Mitigate compatibility issues with shaders and FoamFix.
:rocket: Reduce overhead, thereby enhancing performance.
:wastebasket: Eliminate bloated and redundant code.

:construction: Why Two Parts?
The task of removing the compatibility package is substantial, hence the decision to split it into two distinct parts. This strategy is not only practical but also beneficial in terms of project management and release scheduling.

:one: Part 1 focuses on the groundwork, which involves clearing out strictly duplicated code. This step is crucial in preparing the codebase for further modifications and doesn't require a deep understanding of the system's overall architecture. It is a relatively low-risk task that can quickly result in a cleaner, more maintainable codebase.

:two: Part 2 deals with the more challenging task of the compatibility package removal process. It involves heavier work and a higher level of complexity, specifically the implementation of Mixin. This step requires a deep understanding of the system's architecture and a careful approach to avoid introducing new bugs or breaking existing functionalities.

The separation into two parts allows for releasing improvements to the public earlier. If we embarked on this as a single task, it would take a significant amount of time before any changes would be seen. By dividing the work, we can provide incremental updates, giving users the benefit of the cleaned-up code from Part 1 while we continue working on Part 2. This approach reduces risk, provides value to users earlier, and allows for potential feedback that can inform the ongoing work.

 BIG Cleanup


Add automatic regression test to check for performance degradations

Discussed in https://github.com/orgs/gem5/discussions/446

Originally posted by dhschall October 12, 2023
After today's developers meeting discussion, I was wondering if there is a simple way to add some sort of regression test to the existing testing infrastructure. Those are orthogonal to the normal unit tests and will report some common statistics like IPC, Branch MPKI, I-cache or D-cache MPKI, and simulated instructions per second (KIPS/MIPS).
In addition, the test can issue a warning if one of the statistics exceeds a certain range (for simulation time in particular).
I only thought about a few benchmarks for the most common ISA's and CPU cores. (I.e. x86, Arm, RISC-V, O3, atomic, timing)
This would have three main advantages.

For developers to quickly encounter performance degradations. Either simulated performance or simulation speed
Would help reviewers to quickly see if the change alters behavior or degrades performance.
For people new to gem5 it would give them a reference to see spot misconfigurations. (There are too many parameters you can mess with)

Also, it would be great to see those metrics evolve over time (in addition to stars and clones). It might help to speed up the simulation time of gem5 and improve the models.

This is not high on my TODO list either, but is something I am interested in adding for the GPU tests too.


Minimize jekyll dependencies (remove github-pages)

Remove github-pages and other unused dependencies from the jekyll build,
leaving only the minimal dependencies required to build the website.
Also fix any newly broken links caused by changes in the way markdown
links to other markdown files were processed. Also update gitignore and
add a site description field that was previously automatically populated
by github-pages.

I noticed that the GitHub Actions was having trouble rebuilding the native extensions in the website's CI build, due to additional dependencies with the newer versions of github-pages gem. However, that gem isn't even needed by us. So, I figured it'd be better to just drop it.


bug: slidebox pager discounts if replace cached content

Type: bug
Platform: all
The problem happens with cached slidebox.
After:

using slidebox to move between slides
change view (so slidebox get cached)
returning to slidebox
replace its content on enter (and number of slides)

Then:
The sliderbox pager shows an incorrect number of slides.
Check this codepen: http://codepen.io/-kaik-/pen/KwZgOG

Seeing a very similar issue also.

using slidebox to move between slides
use a custom filter to change the set of data being viewed
a. wrap all the below in a scope.$applyAsync
b. empty data structure containing viewed data
c. fill structure with new data
d. call $ionicSlideBoxDelegate.update()
e. call $ionicSlideBoxDelegate.slide(0)
swipe to a new item
select a filter to do step 2 again. (pager will be hosed)

Seeing a very similar issue also.

using slidebox to move between slides
use a custom filter to change the set of data being viewed

wrap all the below in a scope.$applyAsync
empty data structure containing viewed data
fill structure with new data
call $ionicSlideBoxDelegate.update()
call $ionicSlideBoxDelegate.slide(0)

swipe to a new item
select a filter to do step 2 again. (pager will be hosed)

Seeing a very similar issue also.

using slidebox to move between slides
use a custom filter to change the set of data being viewed

wrap all the below in a scope.$applyAsync
empty data structure containing viewed data
fill structure with new data
call $ionicSlideBoxDelegate.update()
call $ionicSlideBoxDelegate.slide(0)

swipe to a new item
select a filter to do step 2 again. (pager will be hosed)

There are also visual artifacts that happen when swiping between cards after the pager gets hosed.

will this issue be solved if this commit is brought in? https://github.com/driftyco/ionic/commit/2ab776023d571d57d9b8a1d7878904b24b1364f8

I'm still getting this issue (as shown in the codepen) in version 1.0.0.

Greetings @kaikcreator!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


Unusual HTTP response in ASP.NET Core web application

Disclaimer
I'm not 100% the issue I'm seeing is caused by Kestrel, however as the web server returning the unexpected status code I thought I'd raise this here and see if anyone clever has any bright ideas about what could be causing my issue!
Problem
Our application is a ReactJS/ASP.NET Core web application hosted as a Web App in Azure. We use Okta for authentication and the login process looks like this:

User navigates to our website
On page load when not logged in, authorize attribute redirects to the '/api/auth/login' controller action
'/api/auth/login' invokes challenge and redirects to Okta
User logs in to Okta and is redirected back to callback URL specified in OpenID connect middleware
Web app redirects back to '/api/auth/login' to check if user is authenticated then redirects to '/' to render home page

When logging in to the Azure hosted application on Chrome using HTTPS, step 5 above does not redirect to '/' and instead the call to '/api/auth/login' is returning a 200. Nowhere in my controller action do I return a 200 here. This works locally when using chrome and HTTPS so it seems to be isolated to my application running in Azure.
I do not experience this issue on any other browser apart from Chrome.
Login action
[Route("login")]
[ResponseCache(Duration = 0, Location = ResponseCacheLocation.None, NoStore = true)]
public IActionResult Login()
{
    if (!this.HttpContext.User.Identity.IsAuthenticated)
    {
          return this.Challenge(OpenIdConnectDefaults.AuthenticationScheme);
    }

    return this.Redirect("~/");
}

Expected response when browsing over HTTP

Unexpected response when browsing over HTTPS

I would appreciate any ideas, thanks.

Status Code 200 OK (from ServiceWorker)

Looks like its a Javascript service worker on your page that's poxying and returning the 200 (possibly caching it also)

Super-star, I'm new to React and from your prompt and having a skim through our codebase it's pretty obvious that this is being registered by our React application.
Thanks for the swift reply.


not running on xcode 9

clang: error: unable to execute command: Illegal instruction: 4
clang: error: clang frontend command failed due to signal (use -v to see invocation)
Apple LLVM version 9.0.0 (clang-900.0.37)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
clang: note: diagnostic msg: PLEASE submit a bug report to http://developer.apple.com/bugreporter/ and include the crash backtrace, preprocessed source, and associated run script.
clang: note: diagnostic msg:

PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang: note: diagnostic msg: /var/folders/xk/wgkkgbt178l6b7kg6ybwlm3r0000gn/T/main-adba15.m
clang: note: diagnostic msg: /var/folders/xk/wgkkgbt178l6b7kg6ybwlm3r0000gn/T/main-adba15.cache
clang: note: diagnostic msg: /var/folders/xk/wgkkgbt178l6b7kg6ybwlm3r0000gn/T/main-adba15.sh
clang: note: diagnostic msg: /var/folders/xk/wgkkgbt178l6b7kg6ybwlm3r0000gn/T/main-adba15.crash
clang: note: diagnostic msg:

It's a LLVM 9.0 bug. I'm using LLVM 8.0 's clang complier in XcodeDefault.xctoolchain.And it can compile now.But  still have some other problems.

@oschanger I meet with the same problem, I've tried to comment code which's below TUPrint(@"Trace: %@\n", tracePath). This time compile is success, but it throwes out "Can't discover the application's bundle path" exception, it seems wrong with bundle path for Instruments plugins and packages.
@Qusic The code seems broken on Xcode9, how to fix it?

@pixuan simply add this TUPrint(@"Trace: %@\n", tracePath) seems does't work for compile?Which line did you add.   I've tried to fix PFLoadPlugin() problem. But fails

@oschanger  I comment all the code below this, not add it. The compile error may be caused by them.

@pixuan i comment this line but not work

this works ...

@pixuan this works ...

It may caused by the 'flattenTree' block in [instrumentID<EMAIL_ADDRESS>condition, I commented all code in this condition and no error appears.

@Aozorany  PFTLoadPlugins() yeah  but still have PFTLoadPlugins() problem

@Aozorany yeah but still have PFTLoadPlugins() problem

@oschanger change bundle path can fix PFTLoadPlugins() crash
[NSBundle<EMAIL_ADDRESS>but PFTTraceDocument still catch an error ，as same as use Instrument.app(8.3) to open the trace file
Error Domain=Supported Capability Problem Code=0 "Missing features" UserInfo={NSLocalizedDescription=Missing features, NSLocalizedRecoverySuggestion=This document was saved by a newer version of Instruments and the file format has significantly changed.  The document will need to be opened by the newer version. , XRCapabilityRangesKey={     "com.apple.dt.instruments.track_pinning" = "NSRange: {9223372036854775807, 0}"; }, XRRequiredVersionsKey={     "com.apple.dt.instruments.track_pinning" = "NSRange: {1, 1}"; }, NSLocalizedFailureReason=Forward compatibility checks have failed.}
seems 9.0 has different way to load trace file

this problem is same to me.

也是遇到了同样问题.  使用Xcode9编译, trace是iOS11.0的手机生成的.

@one2zero I add the bundle path but when loading plugin it will fail to load optimized model XRPackageModel 9.0.omo. Maybe this model is changed.

I don't know how the author digged out  the PFTLoadPlugins function. class-dump cannnot find it.
In my study, xcode 9 need to load more package other than plugin, but I cannot find the function to load packages.

@MarStarck This function is in Instruments.app  -->  InstrumentsPlugIn.framework

@oschanger How you find it?

@MarStarck cause this logic should be in Instruments.app
so I recursively class-dump every framework in it and grep

but my class-dump result doesn't contain this function, my reposite is https://github.com/MarStarck/xcode_instrument_headers
I use class-dump -H command

@MarStarck
#!/bin/bash
Run this with:
find /Applications/Xcode.app/ -type f -perm -100 -exec ./extract.sh '{}' ;
Afterwords run: (to remove all empty directories)
find . -d -type d -empty -exec rmdir {} ;
APP=$1
BASE_DIR=pwd
OUTPUT=$(file "$APP")
if [[ $OUTPUT == Mach-O ]]; then
TARGET_DIR=$BASE_DIR"/"$APP
mkdir -p "$TARGET_DIR"
class-dump -H -o "$TARGET_DIR" "$APP" > /dev/null
nm -g -U -j "$APP" > "$TARGET_DIR"/exported_symbols.h
fi

#!/bin/bash

# Run this with:
# find /Applications/Xcode.app/ -type f -perm -100 -exec ./extract.sh '{}' \;
# Afterwords run: (to remove all empty directories)
# find . -d -type d -empty -exec rmdir {} \;

APP=$1
BASE_DIR=`pwd`

OUTPUT=$(file "$APP")
if [[ $OUTPUT == *Mach-O* ]]; then
  TARGET_DIR=$BASE_DIR"/"$APP
  mkdir -p "$TARGET_DIR"
  class-dump -H -o "$TARGET_DIR" "$APP" > /dev/null
  nm -g -U -j "$APP" > "$TARGET_DIR"/exported_symbols.h
fi

@MarStarck
#!/bin/bash

# Run this with:
# find /Applications/Xcode.app/ -type f -perm -100 -exec ./extract.sh '{}' \;
# Afterwords run: (to remove all empty directories)
# find . -d -type d -empty -exec rmdir {} \;

APP=$1
BASE_DIR=`pwd`

OUTPUT=$(file "$APP")
if [[ $OUTPUT == *Mach-O* ]]; then
  TARGET_DIR=$BASE_DIR"/"$APP
  mkdir -p "$TARGET_DIR"
  class-dump -H -o "$TARGET_DIR" "$APP" > /dev/null
  nm -g -U -j "$APP" > "$TARGET_DIR"/exported_symbols.h
fi

I have figure it out. Just adding InstrumentsPackaging into your project is enough.
btw, I cannot change compiler to LLVM 8.0, you know how can I install it?

@MarStarck
I've tired to add InstrumentsPackaging.framework to "Link Binary With Libraries", but didn't work.
How did you do it?

try go to /Instruments.app/Contents/Packages/
and install .instrdst files

@MarStarck
Cool, it works!
Why you need LLVM8? I changed it before by replacing clang compiler in Xcode9 with the one in Xcode8

because I met the same compile error as you used to in LLVM 9 when compile flattenTree function.

I remember use LLVM8 will meet same version problem as Xcode8

new trace grabbed by xcode will report
2017-12-04 19:41:45.607648+0800 TraceUtility[91420:4712423] Cleaned up abandoned user-installed distribution lock
2017-12-04 19:41:45.607885+0800 TraceUtility[91420:4712423] Cleaned up abandoned user-installed distribution lock
2017-12-04 19:41:45.894098+0800 TraceUtility[91420:4712423] Month 13 is out of bounds
Error: Error Domain=Supported Capability Problem Code=0 "Missing features" UserInfo={NSLocalizedDescription=Missing features, NSLocalizedRecoverySuggestion=This document was saved by a newer version of Instruments and the file format has significantly changed.  The document will need to be opened by the newer version.
, XRCapabilityRangesKey={
    "com.apple.dt.instruments.track_pinning" = "NSRange: {9223372036854775807, 0}";
}, XRRequiredVersionsKey={
    "com.apple.dt.instruments.track_pinning" = "NSRange: {1, 1}";
}, NSLocalizedFailureReason=Forward compatibility checks have failed.}
Program ended with exit code: 1

older trace is ok

new trace grabbed by xcode9 will report
2017-12-04 19:41:45.607648+0800 TraceUtility[91420:4712423] Cleaned up abandoned user-installed distribution lock
2017-12-04 19:41:45.607885+0800 TraceUtility[91420:4712423] Cleaned up abandoned user-installed distribution lock
2017-12-04 19:41:45.894098+0800 TraceUtility[91420:4712423] Month 13 is out of bounds
Error: Error Domain=Supported Capability Problem Code=0 "Missing features" UserInfo={NSLocalizedDescription=Missing features, NSLocalizedRecoverySuggestion=This document was saved by a newer version of Instruments and the file format has significantly changed.  The document will need to be opened by the newer version.
, XRCapabilityRangesKey={
    "com.apple.dt.instruments.track_pinning" = "NSRange: {9223372036854775807, 0}";
}, XRRequiredVersionsKey={
    "com.apple.dt.instruments.track_pinning" = "NSRange: {1, 1}";
}, NSLocalizedFailureReason=Forward compatibility checks have failed.}
Program ended with exit code: 1

older trace is ok

@oschanger can you share your dumped .h files?  I met lots of exceptions when using class-dump...
There must be something wrong during the initialization.

@MarStarck
Your email?

@oschanger I need that dumped h too for traceUtility<EMAIL_ADDRESS>

@oschanger<EMAIL_ADDRESS>Thx!

@MarStarck   how did you find to delete .creq?

Summary:
1.change path in main.m
static NSBundle *NSBundle_mainBundle_replaced(id self, SEL _cmd) {
    //return [NSBundle<EMAIL_ADDRESS>    return [NSBundle<EMAIL_ADDRESS>}

2.comment all code in if block:
      if ([instrumentID<EMAIL_ADDRESS>
3.install packages in
/Applications/Xcode.app/Contents/Applications/Instruments.app/Contents/Packages
4.delete .creq file in .trace

Summary:
1.change path in main.m
static NSBundle *NSBundle_mainBundle_replaced(id self, SEL _cmd) {
    //return [NSBundle<EMAIL_ADDRESS>    return [NSBundle<EMAIL_ADDRESS>}

2.comment all code in if block:
if ([instrumentID<EMAIL_ADDRESS>
3.install packages in
/Applications/Xcode.app/Contents/Applications/Instruments.app/Contents/Packages
4.delete .creq file in .trace

@oschanger I have meet the same problem: PFTTraceDocument still catch an error ，as same as use Instrument.app(8.3) to open the trace file
Error Domain=Supported Capability Problem Code=0 "Missing features" UserInfo={NSLocalizedDescription=Missing features, NSLocalizedRecoverySuggestion=This document was saved by a newer version of Instruments and the file format has significantly changed. The document will need to be opened by the newer version. , XRCapabilityRangesKey={ "com.apple.dt.instruments.track_pinning" = "NSRange: {9223372036854775807, 0}"; }, XRRequiredVersionsKey={ "com.apple.dt.instruments.track_pinning" = "NSRange: {1, 1}"; }, NSLocalizedFailureReason=Forward compatibility checks have failed.}
Have you fix it? How to fix the problem?

Sadly !When I update to Xcode 9.2 PFTTraceDocument have not init.
PFTTraceDocument *document = [[PFTTraceDocument alloc]initWithContentsOfURL:[NSURL fileURLWithPath:tracePath] ofType:@"Trace Document" error:&error];
Console
Error: Error Domain=Instruments Plug-in Error Code=-6 "Document Missing Template Error" UserInfo={NSLocalizedDescription=Document Missing Template Error}
How to do bros!

crash with xcode 9.2 fixed in https://github.com/Qusic/TraceUtility/commit/98648d9d82940efab8f713c147bbcd1abfc4ce90#diff-0cad19250ae08acbc7488724c19cf9e9R34


unable to read external pdf from URL getting error ReferenceError: ReadableStream is not defined

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version:
Operating system and its version:
PDF.js version:
Is a browser extension:

Steps to reproduce the problem:
1.
2.
What is the expected behavior? (add screenshot)
What went wrong? (add screenshot)
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

Without the issue template filled out, this is closed as incomplete. Use the ES5-compatible version if ReadableStream is not available.


Add the "has meta" query condition.

Hi guys!
I added the hasMeta method in UserBuild because resulted in error getting the user logged in by remember token.
This simply adds nested whereHas by meta relationship, for verify if it exists.
Example:
$this->createModel()->newQuery()
    ->whereId($identifier)
    ->hasMeta('remember_token', $token)
    ->first()
;

Like this:
$this->createModel()->newQuery()
    ->whereId($identifier)
    ->whereHas('meta', function($query) use($token) {
        $query->where('meta_key', 'remember_token')
            ->where('meta_value', $token)
        ;
    })
    ->first()
;

If you have better solution, ignore this please! :smiley:
Thanks!
Sorry for bad english :confused:

Hi,
Thanks for the PR.
Could you only add the second where condition only if metaValue is not null ?
Also, could you write a quick unit test for this method ?
I'll merge it afterwards.
Thanks

Hi,
The idea is mainly fix the following error:
BadMethodCallException in Builder.php line 2405:
Call to undefined method **Illuminate\Database\Query\Builder::hasMeta()**

This presents to return in the application using remember token.
About the unit test, I think I can write yes, if necessary.
Thanks!

I realized that "hasMeta" has already been implemented.
I think this is what you're looking for

Hi @erickmcarvalho! Thanks for contributing with Corcel. Please send you PR again to the dev branch. I'm gonna close this one. Thanks.


Improve refund authorized status

The 'refund authorized status' could be improved. The function Adyen_Payment_Model_ProcessNotification::_setRefundAuthorized($order) sets the status of the order after the creditmemo has been created. A credit memo creation sets the order state and status to 'processing' in Mage_Sales_Model_Order_Payment::refund($creditmemo), see line 730, which is default Magento behaviour.
The line $status = (!empty($status)) ? $status : $order->getStatus(); in Adyen_Payment_Model_ProcessNotification::_setRefundAuthorized($order) thus always returns 'processing' when (!empty($status) is true. I'd rather see:
protected function _setRefundAuthorized($order, $orderStatusBeforeProcessingRefundCallback) {
   $this->_debugData['_setRefundAuthorized'] = 'Status update to default status or refund_authorized status if this is set';
   $status = $this->_getConfigData('refund_authorized', 'adyen_abstract', $order->getStoreId());
   $status = (!empty($status)) ? $status : orderStatusBeforeProcessingRefundCallback;
   $order->addStatusHistoryComment(Mage::helper('adyen')->__('Adyen Refund Successfully completed'), $status);
   $order->sendOrderUpdateEmail((bool) $this->_getConfigData('send_update_mail', 'adyen_abstract', $order->getStoreId()));
}

This version uses the original order status before the callback. I thinks it is strange Magento always sets the order back to a 'processing' status.

Hi Leeuwd,
We have now added an option to set a full refund status and partial refund status. By setting these two statuses will that solve your issue ?
Regards,
Rik
Adyen


CLOUD-51472 added metadata show

@keyki

Jenkins build failed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1981/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1982/


use highest version of package when found by provided files

Before, when a dependency was found not by package name, but by a provided file, we just took whichever version was first. That was inconsistent, and not the right answer anyways.
This consistently does the following:

If the package declaring the dependency also provides the dependency, do nothing, as we satisfy it ourselves.
If any of the packages providing the dependency are of the same origin o: as the package requesting the dependency, restrict our selection set to just those packages with a matching origin; else look in all packages providing the dependency
Of the packages remaining that provide the dependency (matching origin or, if none, then all), take the highest version (highest as defined by the package logic)

So far, I have tested the results of provided versions solely against apko-amd64. Am running checks against many others and will post here when done.

Ready to run.


Implement CLI methods for connect and disconnect

This PR addresses isssue #6

The code builds but might not give desired outputs.

What's remaining:

Adding unit tests for both of them.

Currently I'm facing this issue,
I'm not able to figure out exactly where I'm making mistake in the code.
The command connect works fine on the old eclair-cli, that confirms that the uri format that I'm using is correct:
claddy@claddy:~/Documents/eclair-cli$ eclair-cli connect --uri=023cb8d093f6475d8ddfb104b0591c18097045156d71eb1169d380b73a70a949b5@<IP_ADDRESS>:9737
Enter host password for user 'eclair-cli':
connected

But while running connect in the new eclair-cli I'm getting the following log(I disconnected the nodes that were earlier connected by old cli and this is reattempt):
claddy@claddy:~/Documents/eclair-cli$ eclair-cli.kexe connect -p password --uri=023cb8d093f6475d8ddfb104b0591c18097045156d71eb1169d380b73a70a949b5@<IP_ADDRESS>:9737
Uncaught Kotlin exception: kotlin.Exception: Error connecting to --uri=023cb8d093f6475d8ddfb104b0591c18097045156d71eb1169d380b73a70a949b5@<IP_ADDRESS>:9737: Failed to connect
    at 0   eclair-cli.kexe                     0x56084e           kfun:EclairClient.$connectCOROUTINE$1.invokeSuspend#internal + 2158
    at 1   eclair-cli.kexe                     0x41de01           kfun:kotlin.coroutines.native.internal.BaseContinuationImpl#resumeWith(kotlin.Result<kotlin.Any?>){} + 241
    at 2   eclair-cli.kexe                     0x4a27c6           kfun:kotlinx.coroutines.DispatchedTask#run(){} + 646
    at 3   eclair-cli.kexe                     0x487abb           kfun:kotlinx.coroutines.EventLoopImplBase#processNextEvent(){}kotlin.Long + 971
    at 4   eclair-cli.kexe                     0x4aa5d5           kfun:kotlinx.coroutines#runBlocking$default(kotlin.coroutines.CoroutineContext?;kotlin.coroutines.SuspendFunction1<kotlinx.coroutines.CoroutineScope,0:0>;kotlin.Int){0§<kotlin.Any?>}0:0 + 1173
    at 5   eclair-cli.kexe                     0x55ed5d           kfun:commands.ConnectCommand#execute(){} + 237
    at 6   eclair-cli.kexe                     0x55915d           kfun:kotlinx.cli.ArgParser#parse(kotlin.collections.List<kotlin.String>){}kotlinx.cli.ArgParserResult + 8477
    at 7   eclair-cli.kexe                     0x55dd25           kfun:#main(kotlin.Array<kotlin.String>){} + 1813
    at 8   eclair-cli.kexe                     0x58b837           Init_and_run_start + 503
    at 9   eclair-cli.kexe                     0x58b92a           Konan_main + 10
    at 10  libc.so.6                           0x7fe943229d8f     0x0 +<PHONE_NUMBER>49551
    at 11  libc.so.6                           0x7fe943229e3f     __libc_start_main + 127
    at 12  eclair-cli.kexe                     0x415962           0x0 + 4282722
Aborted (core dumped)

And the similar thing is happening with the disconnect command.
As far as I know, I've tried to implement the error handling at mosst of the places.

You should start by rebasing this PR on top of the latest version of master, a lot has changed and you should use the same architecture.

I'm not able to send the request properly. And I'm getting the following log:
claddy@claddy:~/Documents/eclair-cli$ eclair-cli.kexe connect -p password --uri=02f666711319435b7905dd77d10c269d8d50c02668b975f526577167d370b50a3e@<IP_ADDRESS>:9736
error: invalid request parameters (code=400)

I went through all the examples which were given on the ktor documentation about making requests.
I referred to the syntax of multipart data form from here.
A different httpClient was also introduced in EclairClient.kt so that we can avoid installing the content negotiation plugin here.

I've one doubt. In the Connect Manually method the commands look like:
curl -s -u :<eclair_api_password> -X POST -F nodeId=<node_id> -F host=<host> "http://localhost:8080/connect"

# with eclair-cli
eclair-cli connect --nodeId=<node_id> --host=<host>

Since we already have the host option in our BaseCommand class, do we need to add this method(for user to connect manually) separately?
Isn't it same as connect with nodeId except the fact that host is mandatory in connect manually.

I've one doubt that the host which we are taking as an option same as the host which needs to be mentioned in the connect manually command? According to me they are different, since the first one talks about the host of that particular node which we are running and the host used in the connect manually method specifies the host of target node(It's a guess). It isn't specified clearly in the documentation either.

There's a small issue:
I was trying to squash same types of commits(so that commits don't look messy), I was rebasing and in that process I made some mistakes, and now the commit messages are a bit messed up. Their name doesn't match what they did. I'm really sorry for this.
If this needs to be fixed, I'll try to do it by learning.

I've one doubt that the host which we are taking as an option in the BaseCommand is it same as the host which needs to be mentioned in the connect manually command? According to me they are different, since the first one talks about the host of that particular node which we are running and the host used in the connect manually method specifies the host of target node(need clarity). It isn't specified clearly in the documentation either.

Yes those are not the same hosts at all. That's why I suggested in my previous comment to call the new one address to avoid clashing with the API host parameter.

I was trying to squash same types of commits(so that commits don't look messy), I was rebasing and in that process I made some mistakes, and now the commit messages are a bit messed up. Their name doesn't match what they did. I'm really sorry for this.
If this needs to be fixed, I'll try to do it by tomorrow.

Yes, please clean up the commit history, it's a mess. This should be completely trivial to do and shouldn't take you more than a few minutes. You should get used to rebasing and squashing commits together, that's part of the day-to-day operations that developers do very frequently. If you don't know how to do this, there are a lot of tutorials available, just google "git rebase and squash commits".

I was trying to squash same types of commits(so that commits don't look messy), I was rebasing and in that process I made some mistakes, and now the commit messages are a bit messed up. Their name doesn't match what they did. I'm really sorry for this.
If this needs to be fixed, I'll try to do it by tomorrow.

Yes, please clean up the commit history, it's a mess. This should be completely trivial to do and shouldn't take you more than a few minutes. You should get used to rebasing and squashing commits together, that's part of the day-to-day operations that developers do very frequently. If you don't know how to do this, there are a lot of tutorials available, just google "git rebase and squash commits".

When I was trying to do the git interactive rebase what was happening is that the changes were implemented again instead of it replacing the earlier commits. What i mean is, suppose I have 5 commits:

commit1
commit2
commit3
commit4
commit5

Now if I do the interactive rebase and squash commit3 and commit4 together into commit3 and I decide to reorder commit5 to just below the commit1. Then what I expect is:
commit1
commit5
commit2
commit3

But what I was getting is
commit1
commit2
commit3
commit4
commit5
commit1
commit5
commit2
commit3

I also read in a tutorial that git interactive rebase is best, when you do it with the local commits(before you push to the remote origin). Therefore, I created a new Pull request . I'll practice these concepts in a dummy project, before doing them directly on this eclair-cli repo next time. Sorry for making it messy this time.


Lock Pip

Hello, there will be greate if LOCK OPTION of windows will be avaible
like "not clickable" "moveable" untile you press ur hot key combination to togge lock on or off

Looking for this 'click-through' option as well, could it be implemented?


feat: llama_index integration

evaluate llama_index QueryEngine with ragas metrics easily

Can you add a link to our docs explaining these metrics? @jjmachan

that is present in the notebook right? where should I add it?

Ok, the link was already added. Thanks.


UTF-8 filtered as well as ASCII
List the steps that must be taken to reproduce this issue
use the test from the description
Version
v1.6.9
Additional information
No response

Looks like a duplicate of #43 -- which likely has to do with the fact that UTF-8 characters can be more than one byte.

I attempted a fix on this here: https://github.com/TwiN/go-away/pull/63


sendwhatmsg_to_group close tab too fast

When using sendwhatmsg_to_group and setting the tab to close after send, the message appears on in the web.whatsapp page, but never sends to the phone.  When tabs are not closed everything works fine.  There is an extra dialogue popping up in windows but it's too fast for me to catch before the tab closes.
`pysend.sendwhatmsg_to_group(gId, message, hourtosnd, mintosnd, 25, True, False)

`will send the message and leave tabs open.
`pysend.sendwhatmsg_to_group(gId, message, hourtosnd, mintosnd, 25, True, True)

`closes the tab after writing the message but before it is sent from the phone.
I'm using:
Windows
Google Chrome  - Version 91.0.4472.164 (Official Build) (64-bit)
Python 3.8.5

Hey @IESKids , we'll release an update shortly with the option to configure tab closing time. Thanks for reporting this.

Thanks for being on it.
😀
On Fri, Jul 23, 2021 at 10:22 PM aryan @.***> wrote:

Hey @IESKids https://github.com/IESKids , we'll release an update
shortly with the option to configure tab closing time. Thanks for reporting
this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Ankit404butfound/PyWhatKit/issues/102#issuecomment-885715137,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APCL32MG4EQPGOKYS2O6A2LTZGCKLANCNFSM5A4GJLWA
.


Code-friendly license

I respect every developer’s right to pick their own license, but have you considered using a more code-friendly license?
Unfortunately, CC licenses are problematic for code, as they are more targeted at artwork and their definitions of „sharing“ and „mixing“ are ambiguous in the context of code.
My suggestion would be to switch to either the MIT or the LGPL license. MIT is rather permissive and very common these days, LGPL is more similar to CC-BY-SA.

Unfortunately, CC licenses are problematic for code, as they are more targeted at artwork and their definitions of „sharing“ and „mixing“ are ambiguous in the context of code.

Do you recommend a pointer to a page explaining those problems?
Thanks. --Martin

Sure, CC themselves say so:

We recommend against using Creative Commons licenses for software. Instead, we strongly encourage you to use one of the very good software licenses which are already available. We recommend considering licenses made available by the Free Software Foundation or listed as “open source” by the Open Source Initiative.
[…]

https://creativecommons.org/faq/#can-i-apply-a-creative-commons-license-to-software

Interesting. Is a JSON file  "software", "data" or "document"? Has anybody ever think about this?


feat: npm dependencies validations

lets target this to a new feature branch (not main) so we can incrementally merge sub-features.

merging this into the https://github.com/SAP/app-studio-toolkit/tree/main_versions_misalignment and will respond to CR fixes and comments async


Use myn instead of syn for the schema proc macro

This should make compile times shorter

ok maybe not


Add unlockable Frosthaven class to database

Hi! I'm new to software dev and this would be my first public contribution. Please let me know how these things normally go. My friends unlocked a new class in Frosthaven and I was really excited to test builds but I saw the site is not updated. I thought maybe I can figure out how to add it myself and save you some work.
I wanted to add Frozen Fist character to the database and follow all the rules so that the card abilities show up but only if you choose to show locked classes. I think I accomplished this. Please let me know if there's anything else you would like me to do. I copy pasted the info from the https://github.com/any2cards/frosthaven repo.

That's awesome! Just in time for our next Frosthaven session this weekend :D

I merged it to master today, you'll find your new class on the main build :)
Cheers, thanks for your PR !


EbMode and EbIsResetting need guarding

At the moment SSTabEx cannot be used in twinBASIC.  The first problem is that the calls to the VB5/6 IDE functions EbMode and EbIsResetting are crashing when called by your code.
The issue here is that twinBASIC is referencing your SSTabEx type library, which in turn references the type library inside VBA6.DLL.   This causes VBA6.DLL to be loaded as a module into memory, but the VB6 IDE is of course not initialized at all.  When the IDE hasn't been initialized/loaded, EbMode and EbIsResetting will hard crash.
Before calling the EbMode and EbIsRestting functions, you are correctly checking to see if either VBA5.DLL or VBA6.DLL is loaded (with GetModuleHandle), but that is not enough because the DLL can be loaded but not in an initialized state as above, so you will need to find a method to determine if it is actually safe to call EbMode/EbIsResetting, before calling them.
There's probably a few options here, but one way to do that is to use the EbGetExecuttingProj function.  If the returned project is Nothing, then don't bother calling EbMode or EbIsResetting:
' I don't have VB5 to test if EbGetExecutingProj exists there, but I assume it does.
Private Declare Function EbGetExecutingProjVBA5 Lib "vba5" Alias "EbGetExecutingProj" (ByRef hProject As IUnknown) As Long
Private Declare Function EbGetExecutingProjVBA6 Lib "vba6" Alias "EbGetExecutingProj" (ByRef hProject As IUnknown) As Long
Private Function IsVBIDEProjectLoaded() As Boolean
    Dim projectUnk As IUnknown
    Select Case VBAEnvironment
        Case 5
            EbGetExecutingProjVBA5 projectUnk
        Case 6
            EbGetExecutingProjVBA6 projectUnk
    End Select
    IsVBIDEProjectLoaded = Not (projectUnk Is Nothing)
End Function

After changing the InBreakMode and IsResetting procedures to first check IsVBIDEProjectLoaded, we can at least now add SSTabEx to a tB Form:

I think that code was only necessary when the control runs in source code.
Then I added:
    Dim iInIDE As Boolean

    Debug.Assert MakeTrue(iInIDE)
    If iInIDE Then
        ' code
    End If

That avoids to run the code compiled, that code does not even gets compiled (using that call  Debug.Assert MakeTrue(iInIDE)).
Let's see what happens.
I'm having trouble debugging the control for anything than VB6. I tried to add it to VBA Word and VBA Access and I get "Error 0".
I don't know how to debug for tB or VBA.
I've set in the VB6 IDE, in Project properties, Debugging, Start program the tB path, but could not get the SStabEx icon to appear in the toolbox in tB.
I tried with the VB6 IDE running as admin and also as normal user. No results.
Without being able to debug (run in source code), it is hard (almost impossible) for me to fix bugs.
IDK if Krool have been debugging his controls consuming them from tB and running in source code in VB6?
Thanks for your report. Perhaps that particular thing now is working?

Thanks. I probably won't get chance to check this until tomorrow, but I would expect that change you made to fix that issue.
With regard VB6 debugging, it will be tricky with tB because the controls get instantiated from the background compiler process, not from the root IDE process.

BTW, the next release of tB supports SSTabEx once this issue is fixed (including adding controls to tabs).   I had to ensure the exposed ContainedControls by tB support the VB6 Control interface to avoid the Error 0 error.  SSTab only required them to support IDispatch (Object).

With regard VB6 debugging, it will be tricky with tB because the controls get instantiated from the background compiler process, not from the root IDE process.

When we are able to compile the controls in tB, that won't be necessary anymore.
But now if we need to track bugs that only occur in tB but we are still compiling the controls in VB6, it will be very welcome to have the ability to run them the source code (if any there is chance at all).

tB IDE and compiler EXEs offer some undocumented debug command line switches so that you can launch them individually (and even on different machines if necessary).  So it should be possible to have VB6 launch the tB compiler process for debugging purposes.  I'll let you know the command line switches tomorrow.

I had to ensure the exposed ContainedControls by tB support the VB6 Control interface to avoid the Error 0 error.

Wayne, if you prefer I can change that to Object (instead of VBRUN.ContainedControls). I guess perhaps nobody is using that property still 😁
Anyway, sooner or later I think you'll need to support that type (for the UserControl quite surely).
But if it is complicate to do it now, and you want this control to be supported in tB now, I could change that to Object type. Just let me know.

The problem wasn't the ContainedControls collection itself, but the way you're enumerating the individual elements as Control types (which is an interface that non-VB6 controls won't support).
But anyway it's fine; it's fixed in the next tB release for tomorrow.  tB actually already supported the 'Control' interface on all controls at runtime, but the issue was that at IDE time the ContainedControls collection is specially simulated by the tB compiler to match the controls from the live form designer, and I forgot to allow for theControl base interface there.

Ahh, then it is entirely something else.
Do you mean that I should not use the As Control type when enumerating controls of the host or contained controls internally, I mean, in the private code?
Yeah, perhaps I should try to change to As Object to see if that can fix the compatibility with VBA environments too.

Yes, that's right.  It will help with compatibility to change it to Object for sure, but you might find some hosts still won't play nice.  For example, I know MS Access doesn't support container activeX controls.

Confirmed fixed in your latest release.  Thanks!    I'll close this, but I'll add a further comment here once I've published the details on the tB IDE/compiler command line switches mentioned earlier.

So I won't document this officially just yet because I couldn't get it to work with VB6 debugging at the moment.  But I'll detail how it should work, for now in case anyone wants to dig deeper:
To start the background compiler process manually, use the following command line:
bin\twinBASIC_win32.exe --hostPort=8075
(that is what you should put in the VB6 Project Properties > Debugging > Start Program entry)
Then to start the IDE and connect to that compiler instance, use the command line:
twinBASIC.exe --debug
(with the --debug switch, the IDE will listen on port 8075)
With having to run VB6 with the Run As Administrator option, you'll also need to ensure the IDE executable is launched from a command line with the the Run As Administrator option.  The compiler background process should be launched before the IDE process for this to work.
But unfortunately I couldn't get it to work here alongside the VB6 debugger.  As soon as you launch the VB6 debugger, it appears the COM class registration of the class is not quite right, with attempts to create an instance of SSTabEx resulting in 'class not registered' errors.  I haven't looked into it any deeper than that.  Perhaps you'll have more luck than me.

Wayne, thanks for the info.
I usually run the VB6 IDE not as admin, but as normal user.
Maybe that could work. I try to test that later.
BTW, I have been able to debug the problems with VBA, I did it the hard way: putting logging points in every procedure.
I already published the new version, I guess for tB there is no change.

To start the background compiler process manually, use the following command line: bin\twinBASIC_win32.exe --hostPort=8075 (that is what you should put in the VB6 Project Properties > Debugging > Start Program entry)
Then to start the IDE and connect to that compiler instance, use the command line: twinBASIC.exe --debug (with the --debug switch, the IDE will listen on port 8075)
With having to run VB6 with the Run As Administrator option, you'll also need to ensure the IDE executable is launched from a command line with the the Run As Administrator option. The compiler background process should be launched before the IDE process for this to work.

I followed the instructions but could not get it to work.


Request for a standalone vscode-editor npm package

Hello VSCode Team,
I've been greatly impressed with the capabilities of Visual Studio Code for the Web. Its seamless file editing, cross-file search, syntax highlighting, and other features make the web version a powerful tool.
To extend the reach of this wonderful product, would it be possible to consider releasing a standalone npm package, analogous to monaco-editor? A proposed name could be vscode-editor. This would enable developers like myself to effortlessly integrate the VSCode Web Editor experience into our JavaScript projects.
Thank you for your consideration and the remarkable work you do.

Thanks for reaching out. This isn't something we want to support long-term.

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


"Using Workflow Parameters" tutorial is missing a step.

Using Workflow Parameters tutorial is missing a step: before editing the tool in the workflow, you need to click the workflow and select "edit" from the menu. Or is this assumed to be obvious?

@jaidevjoshi83 thanks for spotting this! this step should definitely be added to the tutorial :+1:

It can be closed I think @mvdbeek.

Thanks everyone!


Beanstalkd - job priorities between tubes and for one tube. BUG?

Hi!
I have read protocol.txt and i work a long time with beanstalkd.
But to be reading the documentation i thought that if i watch one tube and there jobs with different priorities - i will get in 'reserve' command a first high-priority job before and only if i have same priority jobs - i will get a first from FIFO order.
But i saw the sources of version 1.9 and now i understand this as following:
The priority works only when we watch more than one tube! If we watch only one tube - i will get everytime first job from FIFO despite the priority!
Example: https://github.com/kr/beanstalkd/blob/v1.9/prot.c
The function process_queue() (line 419) calls the next_eligible_job()
The next_eligible_job() (line 395) sees all watched tubes and compares priority only of first element of each tube (line 409) and sees the first jobs from each watched tube and uses high-priority job from them! I not correctly understand the documentation? Where problem? Or everybody thinks except me that a priority works only between watched tubes?

The priority works within a single tube. Note that the items in a tube are kept in a min-heap ordered by priority, then id. So t->ready.data[0] (line 408) is the most high-priority job in the tube.

the highest priority job is always the first item in the tube. understand now?

Thank you very much!
I found it!


refactor function calls

Pull Request Test Coverage Report for Build 4ebf28cbfdf99db944b81157d7113a1e4bec999e-PR-310
Details

21 of 21 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 89.515%

Totals

Change from base Build 11747a3e4164b9e3e260d3abc7be9ccc84ebfd88:
0.3%

Covered Lines:
683

Relevant Lines:
763

💛  - Coveralls


Selecting Recipients for unique splits

Is your feature request related to a problem? Please describe.
After splitting our private key into n unique parts, we need to distribute them to specific peers. However, we don't know who the peers are.
Describe the solution you'd like
We can select 5 random peers from a group of 10, we will do this using javascript and not on chain to prevent information leakage.
Describe alternatives you've considered
We could also do this on chain using Chainlink VRF, however gas costs would be a problem.

@med-amiine does this look good? Any thoughts?

@med-amiine does this look good? Any thoughts?

This first relies upon #5

This first relies upon #5


Order page

Checkout page must come after place order is clicked
Order page is not in strcture

Can i work on this issue?

Yes thanks for contributing

Left a star behind

order component must come from the top to center

got it @johnbabu021


Filter not applied on raw query

File path: django/contrib/admin/views/main.py
class Name: ChangeList
method Name:get_queryset
If raw query is not supported filter, then why we are applying filter, ordering  and distinct etc.? in case of raw queryset is passed then it should not apply all these additional, simply it should return the same queryset?

I'm sorry, I think I'm missing out on some context here. Did you receive some sort of exception?


Remove deprecated decryption API code

This PR removes the old, deprecated decryption API code.
I'm not too sure if we should merge this right away, or wait for a grace period to allow adoption of the new API.

Pull Request Test Coverage Report for Build 630

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.7%) to 84.046%

Totals

Change from base Build 628:
1.7%

Covered Lines:
3756

Relevant Lines:
4469

💛  - Coveralls

I went ahead and removed the deprecated encryption API code as well :)


Support make update_chart_version on macOS

Support make update_chart_version on macOS
Update the image tag of values at the same time

Fixed in https://github.com/spidernet-io/egressgateway/pull/239


Applying Filter with no Types selected results in an error in the Project Achievement browser

PR: https://github.com/NationalSecurityAgency/skills-service/pull/514

:+1:


Faster encodedword unfold by 15x

15x faster unfold function:

Use the re object's instance method instead of re.sub to skip _compile. See: https://stackoverflow.com/a/47477439/3315725
Change replacing backref to only replace part with empty string (I don't understand why it was done that way in the first place)
Use non-capturing groups for another 10-20% boost

In [22]: _RE_FOLDING_WHITE_SPACES = re.compile(r"(\n\r?|\r\n?)(\s*)")

In [23]: def unfold(value):
   ....:         """
   ....:         Unfolding is accomplished by simply removing any CRLF
   ....:         that is immediately followed by WSP.  Each header field should be
   ....:         treated in its unfolded form for further syntactic and semantic
   ....:         evaluation.
   ....:         """
   ....:         return re.sub(_RE_FOLDING_WHITE_SPACES, r'\2', value)
   ....:

In [24]: %timeit unfold(x)
100000 loops, best of 3: 9.59 µs per loop

In [26]: _RE_FOLDING_WHITE_SPACES = re.compile(r"(?:\n\r?|\r\n?)")

In [27]: def unfold(value):
   ....:         """
   ....:         Unfolding is accomplished by simply removing any CRLF
   ....:         that is immediately followed by WSP.  Each header field should be
   ....:         treated in its unfolded form for further syntactic and semantic
   ....:         evaluation.
   ....:         """
   ....:         return _RE_FOLDING_WHITE_SPACES.sub('', value)
   ....:

In [29]: %timeit unfold(x)
1000000 loops, best of 3: 598 ns per loop

Can one of the admins verify this patch?


spacegun: init at 0.3.3

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/93

It builds. All 3 binaires run. I didn't test anything else since I don't use kubernetes.

@GrahamcOfBorg build spacegun

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/79

I cannot test this myself, but merging on the base that @bbigras has reviewed it and that @kampka uses the same approach here as in his package matrix-appservice-slack.

@nh2 @bbigras Thanks for reviewing!


Is there any way to support IE8? even NOT look so well.

Is there any way to support IE8? even NOT look so well.

IE 8 is missing too many features to be supported. You may include web/compatibility.js that includes polyfills for missing functionality in older IE versions, but we provide no support for IE 8 whatsoever.

I found compatibility.js it already included, but does NOT work. I tried include respond.js that includes polyfills but still does NOT work.


Feature request.  Give us more control over the jump trajectory.

Hey, I love the project and I'll definitely try to use it in the third bevy jam. I love how it's almost like dropping in a actor/controller in unreal engine and then things just works.  It's almost too easy. and most things I check out in your code has a big nice explaining comment. So just know your efforts aren't going unnoticed, and thanks a bunch!
Anyway, to the issue I'm trying to work around. Modifying the jump trajectory.
I'm using the 2d-features, and while I like how most things handle,
The part of the trajectory that is just before the peak of the jump feels very floaty and slow to me, like some Micheal Jordan air time... I recognize this might be the wanted trajectory for many, but I'm not making a basket ball game... 🏀 😭
I think it can be seen very easily in the 2d example demo by simply jumping and not releasing the jump button during the trajectory.
I've tried to poke around in the code and found the JumpState enum with SlowDownTooFastSlopeJump, MaintainingJump, and I figure one of those states are behind the jordan air logic
https://github.com/idanarye/bevy-tnua/blob/0686bb36366bf5aca730cab5af797a55340d5ba2/src/platformer.rs#L302-L306
I've seen your comments about jump_shorten_extra_gravity,  but it does not seem to do much - not in this context at least.
My next idea was to query on the TnuaPlatformerState and then replace the jumpState after some time in the jump, but since JumpState is private this isn't allowed. (maybe my dubious rust skills are at fault)
I hope this doesn't read too much like just a help request, but if you have some better idea of how I should approach this, then I'd love to hear it.

and if I might add another unrelated question (sorry!):
https://github.com/idanarye/bevy-tnua/blob/0686bb36366bf5aca730cab5af797a55340d5ba2/src/platformer.rs#L180-L184
How do I lock the characters rotation? I figure it's a rapier thing?

SlowDownTooFastSlopeJump is irrelevant here. This is something that happens at the start of the jump in order to solve an issue with jumping while running up a slope.
jump_shorten_extra_gravity is only applied when you leave the jump button before reaching the peak. When this happens, Tnua applies more gravity to make the jump shorter. Try it (in the demo or in your game) - do these shortened jumps fell like what you want a full jump to feel?
If so, I can try adding a feature where gravity increases before you reach the peak of the jump. This will make the calculation of the initial jump velocity more complex though, but it should be doable. It'll take some time before I'm available for it (I'm currently working on a huge refactor in one of my other plugins, which I want to finish before the jam), but if you want to try doing something yourself the relevant section of the code is:
https://github.com/idanarye/bevy-tnua/blob/0686bb36366bf5aca730cab5af797a55340d5ba2/src/platformer.rs#L635-L639
vertical_velocity is calculated from the speed of running up a slope, but basically if you add a small number to it then upward_velocity will get below vertical_velocity + your_new_number before reaching the peak, which should prevent the character from spending too much time with near-zero velocity on the Y axis.

How do I lock the characters rotation? I figure it's a rapier thing?

Yes: https://www.rapier.rs/docs/user_guides/bevy_plugin/rigid_bodies/#locking-translationsrotations
In your case (2D), this just means adding the LockedAxes::ROTATION_LOCKED component to the rigid body.

Super helpful!  I found the ROTATION_LOCKED in the example directly after posting - sorry for not doing my due diligence.
Next I'm looking to update sprites animation depending on where in the jump I am.
I'm using velocity.linvel.y but I'd still want to know if I'm in a jump state or not. Thus, intuitively I'd like to check the jump state... maybe something like this:
fn update_sprite(
    query: Query<&TnuaPlatformerState>,
    ....
) {
    let platformer_state = query.single();
    if platformer_state.jump_state != JumpState::NoJump {
        sprite.index = .....;
    }

This gives the error:  "field 'jump_state' of struct 'TnuaPlatformerState' is private".
Sorry if this is irrelevant to the issue, but again I find myself wanting access to jump_state (and also for it to implement PartialEq).
Am I going about things the wrong way?
Please let me know if I should take those questions to discord instead =)

TnuaAnimatingState is a helper utility, for operating whatever animation system you use. What you are actually looking for is TnuaPlatformerAnimatingOutput.


Log (un)successful attempts to connect

Similar to ssh, for fail2ban. Something like this will do :
May 24 10:52:45 dargor sshd[${pid}]: Disconnecting: Too many authentication failures for invalid user ${login} from ${ip} port ${port} ssh2 [preauth]
May 24 11:05:56 dargor sshd[${pid}]: Received disconnect from ${ip}: 11: Bye Bye [preauth]
May 24 11:21:28 dargor sshd[${pid}]: Connection closed by ${ip} [preauth]
May 24 12:13:06 dargor sshd[${pid}]: Accepted publickey for ${login} from ${ip} port ${port} ssh2: RSA ${fingerprint}
May 24 12:13:06 dargor sshd[${pid}]: Received disconnect from ${ip}: 11: disconnected by user

Either with syslog or a file to /var/log.

Fixed


Combine mutliple criteria in sorting order to show unread or starred first, then sort within.

Checklist

[X] I have used the search function to see if someone else has already submitted the same feature request.
[X] I will describe the problem with as much detail as possible.
[X] This issue only contains a request for one single feature, not multiple (related) features.

App version
6.701
Problem you are trying to solve
I'm trying to get a similar sorting order than in GMail or in Aquamail, with the Unread or Starred first then the sorting order within the 2 blocks. This is actually what is keeping me away from switching to K9.
Suggested solution
Be able to combine several criteria in the sorting order, or implement a feature like "Unread first" or "Starred first" that would take precedence over the sorting order itself
Thanks.
Screenshots / Drawings / Technical details
No response

Thank you, sure I will use the forum next time if I seek help
Actually, I've done some research (as I could not recall) and the new feature that I'm looking for may be specific to AquaMail so I don't know whether it's legit to implement it here as well, anyway, it is highly useful.
It is an option that has precedence over the sorting criterian called : "show unread and starred first". Assuming the time is the sorting order, the result would be:

UNREAD sorted by time (Most important are unread messages, whether they are starred or not!)
READ AND STARRED sorted by time (Second most important messages, read but kept visible as starred!)
READ AND NOT STARRED sorted by time (Not important anymore, have been read and handled -as unstarred)

This way, most important messages are always shown first, with UNREAD ones being more important than STARRED ones. Then the
AquaMail also has 2 other options : "show unread first" and "show starred first" but they are less useful IMHO.
Should I open another ticket for these options?


Update integration tests to use new controller setup func

Description of your changes

Updates the integration tests to use the new controller setup function that was changed during the logging and eventing work. This is currently causing integration tests to fail.
Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[ ] Updated any relevant documentation, examples, or release notes.
[ ] Updated the dependencies in app.yaml to include any new role permissions.
[ ] Updated the stack resources documentation to include any new managed resources or classes.

@negz successful run can be seen here: https://jenkinsci.upbound.io/blue/organizations/jenkins/crossplaneio%2Fstack-gcp-pipelines%2Fstack-gcp-integration/detail/PR-167/1/pipeline

@jbw976 not related, but it is failing because I have not rebase off master since #168 was merged. It would pass when merged, but I'll go ahead and rebase so that we get that verification here!