Risk Status Info stuck at "13 of 14 days active"

Avoid duplicates

[X] Bug is not mentioned in the FAQ
[X] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[X] Bug is not already reported in another issue

Describe the bug
I installed the CWA at the day of availability and opened it every day.
The counter how many days I use it correctly increased each day.
On Monday (29.6.), I correctly reached "13 of 14".
On Tuesday (30.6.), I stayed at "13 of 14".
And today (1.7.), it still shows the same.
Expected behaviour
14 of 14 days.
Technical details

Mobile device: Google Pixel 3 XL
Android version: 10

Additional context
In the iOS world, similar issues were reported (https://github.com/corona-warn-app/cwa-app-ios/issues/804, https://github.com/corona-warn-app/cwa-app-ios/issues/815).

Honor 10, Android 10
I have the same issue

Same issue on BQ Aquaris X with Android 8.1.

We can replicate and are investigating the issue.

I'm also experiencing this on a OnePlus 7 Pro running OxygenOS 10 (Android 10)

First off, your risk score calculation is NOT affected, this is only a display behaviour due to the Inactive Tracing Intervals reducing the tracing time and being rounded down.

Hi all,
We identified the issue that is causing the confusion.
The problem is that tracing was disabled for more than 1 millisecond in the retention period (the last 14 days).
In our current implementation we sum up the inactive tracing milliseconds in the last 14 days and subtract it from the 14 day time window.
Here is an example:
Day | Hours of tracing |
-- | -- | --
1 | 24 |
2 | 24 |
3 | 24 |
4 | 24 |
5 | 24 |
6 | 24 |
7 | 24 |
8 | 24 |
9 | 24 |
10 | 20 |
11 | 24 |
12 | 24 |
13 | 24 |
14 | 24 |
15 | 24 |
16 | 24 |
17 | 24 |
  | 332 | 13,8333333
  | Hours of tracing in the last 14 days |  Number of days
Because on day 10 tracing was disabled for 4 hours the total sum of traced hours is only 332 which means 13.833 days -> this will get rounded to 13 days.
So in fact the calculation is correct (you only traced 13.8 days in the last 14 days) and therefore it will only show the the 13 days. But the label is somewhat misleading of the actual meaning and it is not clear what you have to do in order to get the 14 out of 14 days.
In order to get 14 out of 14 days you would have to wait until day 10 is out of the retention period and do not disable tracing for any number of ms in the upcoming 14 days.
We are currently looking into possible changes in order to address this.

My suggestion would be to consider a "day" (counted from midnight to midnight according to the local device time) as "traced" when it has at least one period of active tracing (irrespective of how long it was). Only then the terminology of "days" makes sense.
If you however really want to make visible the distinction between "tracing on" and "tracing off" in this status, you could switch to a "%" notion.

Thanks for your suggestion. However, with this in mind, then even 10 minutes of active tracing would count as an active day, which is obviously also counter-intuitive. There are multiple possibilities in mind so we would ask for some patience until we have decided on the way forward. We will update here once we have progress to report.

@pwoessner Using your example https://github.com/corona-warn-app/cwa-app-android/issues/796#issuecomment-652381709, taking the first 10 days from your example:
10 days of tracing overall
9 days of 24 hours + 1 day of 20 hours = 236 hours
number of days active = 236 hours / (24 hours/day) = 9.83 days --> rounded to 9 days

So this would mean that in your example already on the 10th day after installation, when it should show 10 of 14 days active the app would actually show 9 of 14 days active. So this would get noticed directly on the day after missing some tracing time if the app is opened every day.
:arrow_right: That means if we all specifically start noticing a wrong 13 of 14 days active that we all missed that chunk of tracing time on the 13th day after installation (day 14 if counting the day of installation as day 1). So that on the 14th day after installation we all see the missing increment in days. Wouldn't that be a big coincidence?
Also how do these points fit into the picture?
Day of installation already 'broken'
I installed CWA in the afternoon on 16 June 2020. That means already on 17 June internally I didn't have a full day in the morning opening the app. Days active is displayed for the first time after 3 days, so latest then I should have seen a day missing, but on 20 June in the morning I saw 4 of 14 days active for the 4 days of 16th to 19th June. I saw days active steadily increase until it reached 13 of 14 days active on 29 June 2020 as expected. It did for the first time not increment on 30 June 2020 (possibly prevented by #788) and is since then stuck at 13 of 14 days active.
:arrow_right: Why doesn't the day of installation cause rounding down of the number of days?
Tracing temporarily off long before increment gets stuck
I also switched tracing off and on in CWA for testing purposes a couple of times long before 30 June 2020, and still I saw days active incrementing steadily and as expected until the 30 June 2020 came.
:arrow_right: Why was there no rounding down of days before 30 June?

Hi @aurisnoctis ,
the days will indeed be incremented just with a delay of the time the tracing was disabled. Example:

App Install on 01.06. at 10am
Active tracing until 01.06. at 12am
Disable tracing for 1h until 1pm, after that, tracing is active again

Next day (02.06.):

At 10am (24h after initial installation) the total amount of traced hours are 23h (24h since first tracing activation - 1h of disabled tracing) -> App will display 0 of 1 days active.
At 11am (25h after initial installation) the total amount of traced hours are 24h (25h since first tracing activation - 1h of disabled tracing) -> App will display 1 of 1 days active.

I don't think that this will be clearly visible to the user that the counter gets delayed by the amount of time the tracing was disabled (especially if the disabled tracing time were just a few minutes). But if you are unable to get the full 14 out of 14 days this will stand out to more users.
I cannot fully deny/confirm the behaviour that you had on your app because I don't think you can give me accurate times when you installed, activated/deactivated tracing and at which point in time the count switched the number of days.
But I was able to reproduce the behaviour I described above on a device with changing the time on the device (not recommended on a private/prod device).

Every night between about 0:00 and 8:00, I shut down my phone completely (Power Off). During this time, there is obviously also no tracing.  According to the calculations above, I should have never reached "13 days" until now, but should be in the area of 9 days up to now.
Obviously, in the calculation above, the status "tracing off" does not count this state, which makes the attempt to use this time for the final UX representation even more confusing.

I am still stuck at 13 of 14 days active as of today, with the Google API(20) #788 and Google API(10) #737 errors alternating until Google API (39508) makes an end to that for the day. It should have been 14 of 14 days active starting on 30 June 2020.
I had a steadily increasing number of days active starting on the days after CWA installation (17 June 2020) to the day it first and correctly showed 13 of 14 days active on 29 June 2020. On 30 June 2020, the days the Google API(20) error started, it didn't increase for the first time.

@jkrwdf Unfortunately we can only track the tracing duration when the tracing state is changed inside of the CWA app. So we are unable to record the deactivated tracing time when you turn off the phone because the app does not get the event. This is the same for disabling the tracing in the OS settings (we do not get an event that you deactivated tracing and therefore the app thinks you are still tracing).

@aurisnoctis
You are stuck at 13 out of 14 days active because as you mentioned in  https://github.com/corona-warn-app/cwa-app-android/issues/796#issuecomment-652502040 you have deactivated tracing multiple times for more than 1 ms. This causes the calculation to have a sum of 13.X days of active tracing which will be round to 13 days (described here: https://github.com/corona-warn-app/cwa-app-android/issues/796#issuecomment-652381709)
Days are incrementing to the 13 days because of the behaviour I described in https://github.com/corona-warn-app/cwa-app-android/issues/796#issuecomment-652807750
The increment will just be delayed by the amount of the deactivated tracing time but nevertheless the tracing time will be incremented.
I think the most important thing to understand is that we do not track if you had tracing on/off for x hours on a certain day. But instead we only track the amount of time that you have deactivated tracing (as long as you deactivate it directly in the CWA app). And then we take the time of active tracing (max. 14 days) and subtract the inactive time. That way we get an amount of hours which we will convert into days.

@pwoessner It only appeared on day 14 after installing CWA. The missing time (rounding down effect) never showed before. As explained in comment https://github.com/corona-warn-app/cwa-app-android/issues/796#issuecomment-652502040:

That means if we all specifically start noticing a wrong 13 of 14 days active that we all missed that chunk of tracing time on the 13th day after installation (day 14 if counting the day of installation as day 1). So that on the 14th day after installation we all see the missing increment in days. Wouldn't that be a big coincidence?

I deactived tracing via CWA settings sometimes for brief periods of time starting on the day of installation. So I should have noticed days active to be missing a day during those other 13 days after installation, but this was not the case. The first time days active seemed to be stuck / rounded down was on 30 June when it showed 13 of 14 days active but should have been 14 of 14 days active. Before that - even though I disabled tracing before for some minutes at a time - there was no rounding down.

@aurisnoctis yes because you were not able to recognise the rounding down effect because the time of initial tracing activation was shorter than the retention period (14 days). In that case the only thing that is happening is that the days are increased with a delay of the deactivated time as explained in https://github.com/corona-warn-app/cwa-app-android/issues/796#issuecomment-652807750.
Until the moment when you do exceed the retention period (initial tracing started more than 14 days ago) you will not see the rounding down effect but the delay effect (the increment of the day is delayed).
Only when you hit that point in time when the initial tracing activation was more than 14 days ago the rounding down effect will appear because there is no longer an increment of the active tracing time but this time is static (retention period = 14 days). An then every ms that you had deactivated tracing during that retention period will get subtracted from the 14 days and you will see the rounding effect.
Here is an example:
Calculated Tracing time after installation (still in retention period)
Day | Hours of tracing |
-- | -- | --
1 | 20 |
2 | 2 |
  | 22 | 0,9166666667
  | Hours of tracing in the last 14 days | Number of days
--> App will display 0 out of 14 days
Day | Hours of tracing |
-- | -- | --
1 | 20 |
2 | 4 |
  | 24 | 1
  | Hours of tracing in the last 14 days | Number of days
--> App will display 1 out of 14 days
Instead of switching to 1 out of 14 days at midnight of the first day the switch to 1 out of 14 days gets delayed by the missing hours of day 1. This means the switch to 1 out of 14 days occurs at 4am on day 2.
Day | Hours of tracing |
-- | -- | --
1 | 20 |
2 | 24 |
  | 44 | 1,8333333333
  | Hours of tracing in the last 14 days | Number of days
--> App will display 1 out of 14 days
Day | Hours of tracing |
-- | -- | --
1 | 20 |
2 | 24 |
3 | 24 |
4 | 24 |
5 | 24 |
6 | 24 |
7 | 24 |
8 | 24 |
9 | 24 |
10 | 24 |
11 | 24 |
12 | 24 |
13 | 24 |
  | 308 | 12,8333333333
  | Hours of tracing in the last 14 days | Number of days
--> App will display 12 out of 14 days
Day | Hours of tracing |
-- | -- | --
1 | 20 |  ignored because it is not in the retention period
2 | 24 |
3 | 24 |
4 | 24 |
5 | 24 |
6 | 24 |
7 | 24 |
8 | 24 |
9 | 24 |
10 | 24 |
11 | 24 |
12 | 24 |
13 | 24 |
14 | 24 |
15 | 24 |
  | 336 | 14
  | Hours of tracing in the last 14 days | Number of days
--> App will display 14 out of 14 days

FYI: with the change implemented this behaviour will change and as soon as you have X,5 days of tracing it will be displayed as one day. As a result if your tracing was deactivated for less than 12 hours in the last 14 days you will see the 14 out of 14 days.

@pwoessner Thanks, also for taking the time to explain it so well, much appreciated :+1:
I do not have screenshots to prove it, but I do have the following: firstInstallTime=2020-06-16 11:19:14 via adb and you have my word that I opened the app for instance on 25 June between 8 and 9 in the morning and saw a 9 days active, i.e. when it should have been only 8 according to your explanation: only 8 days plus less than 24 hours had passed since installation plus I had briefly inactivated the tracing during the first days, which further reduces the time tracing was active. With some exceptions I generally open the app between 8 and 9 for the first time on a given day, and in fact on any given day it showed the expected increase of a full day with respect to the day before until it did not switch from 13 to 14 on 30 Jun 2020. Again: in my case it should have been rounded down before according to your well-done explanation.
I am nonetheless looking forward to the new app version! Thanks again for taking time and being clear about the concepts!

The issue still exists in iOS!
I have updated the app days ago and it still shows 13 of 14 days.

Maybe this issue should be reopened?

The issue still exists in iOS!

Yes, that's why https://github.com/corona-warn-app/cwa-app-ios/issues/804 is still open...

Someone reported in a duplicate issue that the 13/14 issue is now fixed for their device https://github.com/corona-warn-app/cwa-app-android/issues/808#issuecomment-656173043

Issue is fixed in newest version. :+1:

(I can't confirm yet. After installing CWA 1.0.5 yesterday, the error mentioned in #737 continued blocking the risk update yesterday and today.)

The observation which I reported in this issue is not repeat not fixed with the current version 1.0.5
According to how the algorithm has been explained by the developers I assume that for the person who reported it being fixed the day where tracing was switched off for short time has moved out of the 14 day period.


add privacy link to .info | Medium importance

Sent by .̔̏𝗠𝗲𝗽𝗵𝗶𝘀𝘁𝗼#5558<PHONE_NUMBER>25055775) with bot<PHONE_NUMBER>02710047
title

completed in b292c8f


https://www.hackerrank.com/challenges/grading/problem

why?

 Maintainers of the repository can add the "hacktoberfest" topic to their repository if they wish to participate. Alternatively, an individual PR can be opted-in with a maintainer adding the "hacktoberfest-accepted" label to the PR.


Resolve symbolic links when looking up MAFIA_HOME

Cabal always uses absolute paths with symlinks resolved when referring to files, so we need to do the same.
This should hopefully fix the bug where we calculate the wrong jenkins hash for the sandbox directory when trying to build happy in a mafia cache that is symlinked to another path.
/cc @nhibberd @markhibberd

Seems legit :+1:


Option 2's dstros enable --start-on-windows-boot seems to require restarting WSL2

I followed the steps in Option 2 of README.
Step 1, downloading and installing scripts succeeded.
In step 2, I got this error.
[Distrod][WARN] whoami.exe had an error:
[Distrod][ERROR] Failed to enable the autostart on Windows boot.

Caused by:
    wslpath -w '/tmp/.tmpTQ234D' exited with error. stderr: /bin/wslpath: /tmp/.tmpTQ234D: Invalid argument

I checked whoami.exe and wslpath, and I found these commands do not work with sudo.
> /mnt/c/Windows/System32/whoami.exe
desktop-xxxxxx\tomyk
~
> sudo /mnt/c/Windows/System32/whoami.exe
((no output with exit status code 255))

> wslpath -w /tmp/.tmpTQ234D
\\wsl.localhost\Ubuntu\tmp\.tmpTQ234D
~
> sudo wslpath -w /tmp/.tmpTQ234D
wslpath: /tmp/.tmpTQ234D: Invalid argument

This is fixed by running /opt/distrod/bin/distrod enable, wsl --termiante Ubuntu, and wsl zsh, then run /opt/distrod/bin/distrod enable --start-on-windows-boot again.
Here these commands return the same results with and without sudo.
I suggest to put instructions to restart WSL2 for --start-on-windows-boot if it fails.

oops, thanks for the catch again! Maybe I'll fix the doc with sudo -E.

Unfortunately, this didn't reproduce in my environment. In general, sudo should not affect .exe interop. Perhaps you once enabled distrod by distrod enable and disabled it after it? In that case, this might happen.

Sorry for late response.

Perhaps you once enabled distrod by distrod enable and disabled it after it? In that case, this might happen.

I forgot the steps I took, but this was possible.
Thank you for checking.


Add not_eq comparators

see https://issues.redhat.com/browse/RHCLOUD-10991
Adds comparators for checking that for checking not_equal. Follows the same pattern as in nil and not_nil.
Strings

not_eq
not_eq_i

Integers

not_eq

Is ti possible to add some specs please? (also for array values) Thanks!

@lpichler Added! (I have spent a lot of time writing Docker compose file to run this project locally.. and then I found that the tests are very simple and I could let CI to run it... 😅  )

@lpichler Added! (I have spent a lot of time writing Docker compose file to run this project locally.. and then I found that the tests are very simple and I could let CI to run it... 😅 )

ah I am sorry for that :) so you have it ready for next time! :)


🌐 Add Portuguese translation for docs/pt/docs/deployment/server-workers.md

- Portuguese translation
docs/pt/docs/deployment/server-workers.md

Thanks for your contribution! @marcelomarkus :smile:
And thanks for the reviews @ceb10n @nazarepiedady :nerd_face:


Error on example build

stack build --flag yesod-job-queue:example
I get this error:
yesod-job-queue-<IP_ADDRESS>: configure
Configuring yesod-job-queue-<IP_ADDRESS>...
yesod-job-queue-<IP_ADDRESS>: build
Preprocessing library yesod-job-queue-<IP_ADDRESS>...
[3 of 4] Compiling Yesod.JobQueue   ( Yesod/JobQueue.hs, .stack-work/dist/x86_64-osx/Cabal-<IP_ADDRESS>/build/Yesod/JobQueue.o )

/Library/WebServer/Documents/haskell/yesod-job-queue/Yesod/JobQueue.hs:262:37:
    Exception when trying to run compile-time code:
      app/dist/app.bundle.js: openBinaryFile: does not exist (No such file or directory)
    Code: embedFile "app/dist/app.bundle.js"
    In the splice: $(embedFile "app/dist/app.bundle.js")

--  While building package yesod-job-queue-<IP_ADDRESS> using:
      /Users/amitai/.stack/setup-exe-cache/x86_64-osx/setup-Simple-Cabal-<IP_ADDRESS>-ghc-7.10.3 --builddir=.stack-work/dist/x86_64-osx/Cabal-<IP_ADDRESS> build lib:yesod-job-queue exe:yesod-job-queue-example --ghc-options " -ddump-hi -ddump-to-file"
    Process exited with code: ExitFailure 1

Thanks for your reporting!
oh, it's my mistake.
It need to build app.js before stack build.
I'll fix it as soon as.
-- quick-fix
you can build app.js by running following in app dir.
npm install
npm run build-js


treewide: cleanup; move packages to pkgs/by-name; format via nixfmt-rfc-style

Description of changes
Currently going over https://github.com/NixOS/nixpkgs/issues/43716 to figure out licenses for packages without one, and performing maintenance (as in cleanup and formatting) on packages before I update and add license in a separate PR.

Formatting refers to formatting a package with nixfmt-rfc-style.
"Cleanup" refers to removing rec, with lib and other bad patterns.

This'll probably be large as there are lots of packages to go over.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

What's the reason for closing this?

I was told in Matrix that such a PR would be discouraged not to step on others' toes.

I am happy to continue with this PR, but I would like to avoid roadblocks down the road stemming from a lack of consensus. If I can get a few more positive responses to this, I'll re-open and proceed.

Can you please ping the maintainer who advised not to do this?

That'd be @dali99 I believe.

@dali99 Could you please elaborate on this PR ?
The only issue I see here is the PR title, besides that, it looked legit to me.
I often do this kind of things myself, never had any issue with that.

For the right context see
See https://matrix.to/#/!kjdutkOsheZdjqYmqp:nixos.org/$PilZWDCiopphZRNWhHWCQ20bulZOY0ynW6nK5tPLElg?via=lossy.network&via=matrix.org&via=nixos.dev
and
https://matrix.to/#/!kjdutkOsheZdjqYmqp:nixos.org/$MACs3PednHwhc7EIDHG4DYWV9OW0hl2yBPcEApH8CzQ?via=lossy.network&via=matrix.org&via=nixos.dev
I believe the "stepping on toes" part comes from https://matrix.to/#/!kjdutkOsheZdjqYmqp:nixos.org/$c64jRjBheEYGyhl1XXNsZ-wUGfaahFwRkK3MsIXXG-o?via=lossy.network&via=matrix.org&via=nixos.dev
The main points are:

Moving packages as part of a "general cleanup" treewide is not encouraged
There has been significant historical turmoil around automatic formatting. And we are not at the point where automatic formatting is being done on the whole tree. We should wait for that.
Even still, doing these things might be okay, but I believe that doing so should be up to the owners/maintainers of these packages. Not as part of a individual persons' desire to "clean up" derivations around the repository.

This PR's main motivation seems to be the by-name/formatting. And thus I think these things should not be encouraged yet. Especially not done unilaterally without the real maintainer's involvement.
This contributor is new and the advice was more general than necessarily for only this package

You are not wrong that formatting and migrating is my motivation, but its not the main motivation.
I am more interested and adding missing licenses, but I'd rather also not leave the packages in their "legacy" state. Some derivations also urgently need maintenance updates, which I'd rather get out of the way while I am already here.

I'm also driven by fixing the issue when I see one, and I have my own personal rule.
If when I edit a Nix file to fix a specific problem AND if I see other issue, I fix them in the same PR, but in different commits.
Basically, every time I edit a Nix file in a PR, it should be totally valid at the end of the PR.

Btw, there is no such thing as ownership in nixpkgs; this is a collaborative project. What being a maintainer entails is that you are making yourself available to fix issues with the package, handle updates, approve PRs, etc. and that you ideally use the package and have some knowledge of whether any change will improve a package or not.
This does not preclude making changes to packages you are not a maintainer for; many of our contributions come from non-maintainers.
@NotAShelf, please feel free to reopen if you're interested in continuing work on this PR.

Btw, there is no such thing as exclusive ownership in nixpkgs; this is a collaborative project. What being a maintainer entails is that you are making yourself available to fix issues with the package, handle updates, approve PRs, etc. and that you ideally use the package and have some knowledge of whether any change will improve a package or cause a problem with it.
This does not preclude making changes to packages you are not a maintainer for; many of our contributions come from non-maintainers.
@NotAShelf, please feel free to reopen if you're interested in continuing work on this PR.

Voila quelqu'un d'eclairevoyant! (french pun intended!)
Please forgive me, it's been a while I wanted to do it...

Sure, how should I adjust it?

Since you're modifying only one derivation, I would do:
cue2pops: move to `pkgs/by-name`

I plan to move other derivations as well, though. So far I have 7 waiting to be pushed.

Ooh fair enough. Ignore my comment then.

Btw, there is no such thing as exclusive ownership in nixpkgs; this is a collaborative project. What being a maintainer entails is that you are making yourself available to fix issues with the package, handle updates, approve PRs, etc. and that you ideally use the package and have some knowledge of whether any change will improve a package or cause a problem with it.
This does not preclude making changes to packages you are not a maintainer for; many of our contributions come from non-maintainers.

It was never about exclusive ownership. I'm arguing for respecting each other's responsibilities and following the rules, guides, and plans we've agreed on. These are both crucial parts of a collaborative project. I'm just accepting there's nuance around ignoring the plan for the things you're actively responsible for.
Misconstruing my sentiment to imply anything else is - how should I say this - Totally uncool.

Basically, every time I edit a Nix file in a PR, it should be totally valid and following the current best practices at the end of the PR.

My own ethos is:
Fix problems, keep the local style, make it easy to accept. As if they wrote it.
Be non-controversial

What rule is this PR violating, exactly?

I think formatting files you touch is in the spirit of https://github.com/NixOS/nixpkgs/pull/322537, which will soon make it mandatory precisely to enable this kind of incremental transition; there’s clearly no question of ownership there and no real grounds to hold back on formatting any given leaf package that doesn’t have a ton of existing open PRs.
Moving into pkgs/by-name I can understand there being some maintainer discretion on; the story for doing that across the entire tree hasn’t been entirely worked out there, and CI ratchet checks means that there’s no easy way of undoing it in case some of the functionality that cannot be used with pkgs/by-name becomes required at a later date. Still, for simple leaf packages it also seems fine to me.
If a maintainer objects then of course their reasons should be taken into consideration, and I do think that those migrations should be in separate commits from any other changes to make reviewing the diffs easier. But, while I grant that there is some nuance here, I personally disagree with @dali99 about the extent to which there is any firm consensus or guideline against doing these clean‐ups, as long as you have another meaningful change to make to the packages anyway. The documentation for pkgs/by-name states:

Manual migrations should only be lightly encouraged if the relevant code is being worked on anyways. For example with a package update or refactoring.

…which, while hardly an urgent endorsement, certainly doesn’t advise against it.

ofborg called me to review this, since the package I maintain was touched by it.
Let's go:

Mere migration to by-name is OK to me. I would do this myself, however this was discouraged.
Migration plus modernization (remove nested with) is OK too.
nixfmt-rfc-style I am a bit reticent, since it can generate noisy patches.
Further, many people hate to review PRs with reformatting.

Some derivations also urgently need maintenance updates, which I'd rather get out of the way while I am already here.

This should be made on a per package basis, not as part of a treewide PR.

If every minor clean‐up has to be split into one PR per package, people just won’t clean things up. I understood the intent of this PR to be to handle the packages listed as lacking licence information in https://github.com/NixOS/nixpkgs/issues/43716; I think doing some tidying up along the way is reasonable. I do think there’s a threshold of change where it makes sense to split things up and get individual review but I’m not sure that would reach it.
That said, I see that the change currently in the PR is just a mechanical update and clean‐up of a package that isn't lacking licence information; for that kind of thing I agree that it should be either separated out into its own PR or done systematically in one go.

The more people we involve, the more we will have different opinionated overviews.
I'm here to improve nixpkgs, not for those politics and shenanigans, unsubscribing.

I think there is perhaps some confusion here because I believe “treewide:” in the PR is only meant to reflect that it touches multiple packages rather than an intent to touch every single package. But I don’t feel like I’m doing a good job at conveying the nuances of my position here, so I’ll bow out too.

@emilazy I feel you. I originally spent hours yesterday trying to convey my feelings as accurate as possible. Culminating in a very large wall of text and one light mental breakdown about the changing culture in nixpkgs over the last six years. I felt quite hurt by @eclairevoyant s comment. But I'm not good at writing accurately, concisely, and politely.
I'm sure we all actually have much more nuanced opinions than what we are managing to express here.
@NotAShelf I'm really sorry your PR was turned into this

When we don't have consensus

https://github.com/NixOS/rfcs/pull/140 (by-name structure) and https://github.com/NixOS/rfcs/pull/166 (nixfmt-rfc-style) getting merged represents net community consensus. There is nothing to tread lightly here about, as this follows the guidelines/plans/whatever as written in this very repo. @emilazy quoted the relevant guideline for the former; for the latter, we already have CI enforcing the formatter on certain paths:
https://github.com/nixos/nixpkgs/blob/d14441cfe1bba01699cd614d6ef82cf6bc6aac22/.github/workflows/check-nix-format.yml#L37-L56
So I'm not sure why you think there is a lack of consensus here.

If every minor clean‐up has to be split into one PR per package

I am not talking about every minor cleanup.
I am talking about "maintenance updates".
"Maintenance updates" has a large latitude of meaning.
I am doing a maintenance update on the SDL ecosystem, since the original maintainers retired.
I am not introducing any new package. I am merely reworking the code.
And it is causing mass rebuilds:

https://github.com/NixOS/nixpkgs/pull/308379
https://github.com/NixOS/nixpkgs/pull/324837

I tried to do maintenance updates to mesa expressions, and a single whitespace after a -D caused mass rebuilds.
Maintenance updates are not necessarily minor cleanups.

I think doing some tidying up along the way is reasonable.

I agree with you here.
However, there are many people - and among them, many people with commit bit - that don't.
And they can easily embargo a PR.

When we don't have consensus

NixOS/rfcs#140 (by-name structure) and NixOS/rfcs#166 (nixfmt-rfc-style) getting merged represents net community consensus. There is nothing to tread lightly here about, as this follows the guidelines/plans/whatever as written in this very repo. @emilazy quoted the relevant guideline for the former; for the latter, we already have CI enforcing the formatter on certain paths:
<EMAIL_ADDRESS>So I'm not sure why you think there is a lack of consensus here.

I have to believe you are being intentionally obtuse here and I will therefore disengage, this is the second time you've managed to carefully misunderstand my entire argument. This is entirely a question of how, when and not if, and has always been this. The fact that we've agreed on that this will happen does not mean we've agreed on it happening this way, or that it will happen now. There was discussion around enabling the formatting lint in for example python. But they can do that because the python team is responsible for the python tree.
We obviously disagree as to whether or not this fits the "exception" for by-name migrations. But the main crux of the argument isn't that a package can or can't be moved. It's that you might not the one who should be making that decision. I don't believe this light encouragement trumps giving that agency to our maintainers. You might believe something different.

I'm not misunderstanding anything; you seem to believe that maintainership is a form of ownership of a package and they have the final say on every change that happens on the package and can even block improvements, even if they don't actually cause problems to the packaging. I cannot agree with that, nor have I seen that being put into practice.
Especially when we have ratcheting checks that will eventually force the move and reformatting anyway, discouraging/bikeshedding someone that you refer to as a "new contributor" simply doing the sort of PR that has been done hundreds of times already seems unnecessarily hostile.


make prompt caching available through api for prompts with less than 1024 token

Confirm this is a feature request for the Python library and not the underlying OpenAI API.

[X] This is a feature request for the Python library

Describe the feature or improvement you're requesting
we could make great use of this awesome feature but our prompts are only around 700 tokens big
Additional context
No response

Thanks for reporting!
This sounds like an issue with the underlying OpenAI API and not the SDK, so I'm going to go ahead and close this issue.
Would you mind reposting at community.openai.com?


Support for Google offical Material Icons font

Google recently released an official font for Material Icons and I think material-ui's FontIcon component should be modified to support this.
This is what I'm using now but it's tricky to use with iconClassName.



or
// > IE 9

search

+1

I'm already using it like
<FloatingActionButton>
    add
</FloatingActionButton>

But integrating it would be really nice!

This solution also works great with .classname:before { content: '...' } for the cases where this library does not pass on children (typically the ligature name).

@MetalMatze
I use your solution, but the icon is not centered in the button. Do you have the same problem?

No, that not a problem. But when hovering the button, I get this annoying background.

Otherwise it all seems fine to me.

That kind of background is actually the same thing that happens when a button wraps an a tag tag (ref. discussion about <SomeButton><Link>...</Link></SomeButton> related to the react-router discussion in another issue.

@MetalMatze
I had this problem (with hover) when I used iconClassName . I don't know exactly why when I removed it and use your solution I didn't have this problem anymore.

I find out the center problem. It is when I use the 'send' icon, for exemple with 'home' icon ther is no problem of centering.


include the JVM path in the heartbeat

In addition to the JVM version, it will also be helpful to know the JVM path.

Just putting this out there.  It might be better to only put mutable variables in the heartbeat and have a separate call to get the immutable variables.  I'm thinking maybe a ServerInfo RPC and it can replace the Version RPC as that would be a subset of the new ServerInfo RPC.


Support for sqlite3_carray_bind

Are there plans to support sqlite3_carray_bind in the upcoming 2.0.5 release or is anyone actively working on it?  It would be pretty useful for my company's product, so I'd be happy to give it a go and submit a PR, but I just wanted to make sure that I wouldn't be stepping on anyone's toes before I do that.

No plans for that API yet.
Unfortunately, implementing it would be decidedly non-trivial.  Currently, the e_sqlite3 builds are done using the SQLite amalgamation, and the carray stuff is not included in it.  So, implementing this would require major changes to the build system I use for making e_sqlite3 native builds.

Yep, saw when I started really looking into this that this would best be handled on our side via a loaded SQLite extension.  Closing the issue...


Restore the custom double atomic add.

Fix failure on master.

Codecov Report

Merging #7198 (de8dc91) into master (7a1d67f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7198   +/-   ##
=======================================
  Coverage   82.67%   82.67%
=======================================
  Files          13       13
  Lines        4017     4017
=======================================
  Hits         3321     3321
  Misses        696      696

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a1d67f...de8dc91. Read the comment docs.


Add an option to hide bottom bar

What's the Problem?
Not really a problem. For those who got minimal tastes, you could add an option in preferences to Hide the bottom bar which displays number of items, as it is not really that necessary.
Solution/Idea
Settings > Appearance > Bottom Bar > Toggle on or off.
Alternatives
Settings > Appearance > Bottom Bar > Toggle on or off.
Priorities
This proposal will allow end users to accomplish X | Should |
Files Version
<IP_ADDRESS>
Windows Version
Windows 11 Home  21H2 22000.438
Comments

@KumarjitDey thank you for your feedback, we don't have plans to implement this option right now.


Fix diff signs' positioning

I saw today the diff signs were a little off in the PR files view. This PR fixes this behaviour (see the attached screenshot).

Live example: https://github.com/sindresorhus/refined-github/pull/1108/files

Sadly this breaks OctoLinker
Before

After

Does this work for you?

Thanks @bfred-it, I will take a look at it in a few minutes.

@bfred-it seems to be working fine for me!


Running multiple hexagon delegates sequentially.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: Snapdragon 855 running Android 9
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 2.2.0
Python version: 3.8
Bazel version (if compiling from source): 2.0.0
GCC/Compiler version (if compiling from source): 7.5.0
CUDA/cuDNN version: N/A
GPU model and memory: N/A

Describe the current behavior
Right now, I have two instances of TfLite interpreter created using the same tflite model. Some of the network is delegated to DSP using hexagon delegate. Both interpreters are initialized one after other. Then, Invoke() is called many times, on either one or the other interpreter. This works fine.
Describe the expected behavior
What happens if I create two instances of tfliteInterpreter from different models, both using hexagon delegate? Will this work as expected?

Yes this should work without issues.

Yes this should work without issues.

Can you briefly explain how sharing the same DSP between tflite interpreters work?

Can you briefly explain how sharing the same DSP between tflite interpreters work?

Each delegate instance creates separate hexagon graph with separate rpc calls to the dsp.

Each delegate instance creates separate hexagon graph with separate rpc calls to the dsp.

Closing this issue since it's addressed. Feel free to reopen if necessary. Thank you

Closing this issue since it's addressed. Feel free to reopen if necessary. Thank you


Create Starter Ruin

The starter ruin should be a small fortification, if possible set it to spawn custom NPCs which can sell basic items or provide simple quests.
If at all feasible, use a command to change the biome to a safe zone (such as a custom "town" biome), to include a named Waystone near the center. This town should be a neutral, mixed town, or possibly one of three pre-crafted aligned towns, featuring dwarves, humans, or dragonkin.
A list of features of interest for shorthand below:

[ ] 2-3 empty player-ready homes
[ ] 3-5 NPCs with homes/shops (if possible) to sell basic needs; at least one quest-giver
[ ] Bounty Board
[ ] Waystone shrine
[ ] Command block to set the biome
[ ] Full lighting and some form of mob-spawn suppression
[ ] A single low-level treasure chest keyed to the faction present

we could make a consumable item and give it to the player. Let the consumable item run a ruins command. Sound good?

We wouldn't specifically need to, I was intending to just tell it "spawn unique", "unique distance 0" to guarantee only one ever spawns, and set it to spawn at the worldspawn. All of that would just be in the ruin file and done as part of the normal setting finishers.
But if you prefer it to be an item, that's not a terrible alternative.
The item could even run a command to change the biome to one of our towns.


Missing alarm function description in SDK documentation

The function hardware_alarm_set_target is referenced is the <IP_ADDRESS>.5. hardware_alarm_set_callback function but its description is missing, also not listed in <IP_ADDRESS>. Function List.

Duplicate of #131 which is already fixed by #147 :slightly_smiling_face:

That's the sort of issue we like, one we've already fixed. Will be in the next SDK release.

Sorry, I only checked the open issue ...


See Project is button not working

When you click on the button you suppose to see the project view but instead, it throws an error saying
scripts.js:226 Uncaught TypeError: skillsUl.classList.adds is not a function

ClassList doesn't have adds a function it only supports add function and on add class one at a time you can why you are getting this error
Wrong way ❌
skillsUl.classList.adds('buttons', 'first-buttons');
Correct way ✔
skillsUl.classList.add('buttons');   skillsUl.classList.add('first-buttons');
Thanks 😃


update gradle (and Kotlin), remove some deprecated API

The goal is to get rid of API which isn't supported by the latest Gradle (as per as it was released recently). The easiest way to do this is to use the latest Gradle for compilation.

Can this be merged and published into a new release?

Bump

Bump

@imanushin can we merge this and trigger a release? this is blocking for upgrading to latest Gradle available.

I suspect this plugin is no longer being maintained. Last commit was years ago


rename hockeyapp

Closes #7606.
@ndr-qef Feel free to merge if #7606 ended up in agreement.

Truthfully, I am still rather uneasy about the naming convention as applied here. However, absent a discussion on the topic, this change is consistent and should be merged.

For what it's worth, I do agree with the change. Although I certainly follow your logic and do find it makes sense, naming (tokening) is so complex and there are so many possibilities, I believe a strict rule that can be applied uniformly and miss a few marks (mitigated by name) is better than relaxing the rule one too many times, and end up with duplicates or confusion for users submitting (since the implementation of the rules, I have seen way less submissions requiring correction in that area)

should either be amended or relaxed.

I take no issue with amending it. Relaxing it would lead to some inconsistencies, I feel. ack "app .*App.app", in an attempt to reveal how many apps use the “app” suffix, reveals way less than what I expected (likely I’m not considering something in that command).
CloudApp is probably the one that suffers the most from this rule, but in a way that’s a bigger fault of its name than of the rule itself. Naming it simply “cloud” does feel wrong and incomplete, but that’s greatly in part on it’s name consisting of two extremely generic terms pushed together (which likely makes for great marketing and makes it higher in search results). I’m not at all saying we shouldn’t accommodate the rule according to the casks we have, as we definitely should, but I do think either allowing or refusing all “app” sufixes is a rule that needs to be in place. Whichever it is, I don’t really care that much: the more we shift the focus to name and away from the token (which as stated, we ask too much of), the better.


[Feat] Create infographic: accidents by an hour

Hey there, a few questions:

What kind of information is shown here?
Is the information clickable?
Is there any numeric value?

In order for me to design it properly, I'm in need of a better understanding of it/

What kind of information is shown here?
For each hour (increments of 15min) there is a bar (the "rays" of the sun). It's height is the amount of accidents that happened in this 15min.

Is the information clickable?
Nope, at this stage we only focus on static information that will be downloaded as JPGs.

Is there any numeric value?
It might be a good idea to include number on the bars, but, if it creates too much clutter we can start seeing what results we get without it, and if the message is good enough without the actual number.

@yuvalbl maybe this can be a basis for it (while the clock is hiding the central part of the chart):
https://recharts.org/en-US/api/RadarChart

Product / design is required


Tasks with type process and a missing command fail too early to emit the right events

Issue Type: Bug
See the reproduction repo, which provides two tasks shell and process and a README with these steps.
Actual behavior

Run the task process
Run the task process again.
Note that each failed in its own terminal, despite what the message in the terminal said.
Focus the terminal and press a key to close it.
Run the task shell.
Run the task shell again.
Note that both failed in the same terminal, again not shared with the process task.
Without closing the terminal, run the task process again.
Note that the task reuses the terminal now, but doesn't fail. Instead it just produces no output at all, and doesn't seem to signal that it's finished.

Expected behavior
The process task doesn't hang, it just fails.
Its terminal gets reused like the one from shell.
Ideally both tasks would emit the exact same sequence events, including both onDidEndTask and onDidEndTaskProcess so the listener can determine that the task failed.
VS Code version: Code - Insiders 1.63.0-insider (c42793d0357ff9c6589cce79a847177fd42852ee, 2021-11-29T08:08:44.056Z)
OS version: Linux x64 5.15.4-201.fc35.x86_64
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (8 x 1567)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
23.24GB (2.03GB free)

Process Argv
--disable-extensions .

Screen Reader
no

VM
0%

DESKTOP_SESSION
gnome

XDG_CURRENT_DESKTOP
GNOME

XDG_SESSION_DESKTOP
gnome

XDG_SESSION_TYPE
wayland

Extensions disabled
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805:30301674
pythonvspyt200:30323110
bridge0708:30335490
bridge0723:30353136
pythonrunftest32:30365365
pythonf5test824:30361779
javagetstartedt:30350119
pythonvspyt187:30365360
vsaa593:30376534
vsc1dst:30396469
pythonvs932:30404738
vscexrecpromptt2:30397559
vscop804cf:30404767
vs360:30404995

@Tyriar or @meganrogge I think the cause of the problem is that ITerminalChildProcess onProcessExit doesn't fire when a process task exits with an error like this.
https://github.com/microsoft/vscode/blob/8d1b714a230dfeedb22f7d16bf55e4cc0c257ebf/src/vs/workbench/contrib/terminal/browser/terminalProcessManager.ts#L308-L309
I don't think there's anything suspicious in the shell launch configs:

Would you expect onProcessExit to fire if the process errors out early like this (the command to run doesn't exist)?

When the call to create/start the process fails, like when executable doesn't exist, it should fire the onProcessExit event here:
https://github.com/microsoft/vscode/blob/f86e5d14afe60ceddb339ebc73bbd501f5029312/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts#L1147-L1151

It does do that, but it seems that something is still not cleaned up somewhere as process tasks run in a re-used terminal don't output the message at all.

If you have this repro set up could you also log these?
https://github.com/microsoft/vscode/blob/f86e5d14afe60ceddb339ebc73bbd501f5029312/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts#L1193-L1194
This is where the output happens:
https://github.com/microsoft/vscode/blob/f86e5d14afe60ceddb339ebc73bbd501f5029312/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts#L1202-L1207

In a non-reused terminal:

this._exitCode is set to undefined there.
exitMessage is set to the expected message.
this._xtermReadyPromise.then gets run and xterm.raw.writeln gets hit.

In a re-used terminal:

None of those lines are hit.
When I kill the terminal manually they are all hit, but all those values are undefined.

@Tyriar is there a way I can tell on the tasks side if a terminal is being disposed vs. just had the above situation happen? I'd like to reuse it if it's not being disposed so that the user experience is consistent. Just iterate though the instances ITerminalService and see if the instance with the same ID is still there?

Internally we use ITerminalLaunchError to differentiate these:
https://github.com/microsoft/vscode/blob/695cbce42797381dee60be571b311095eebe9b14/src/vs/platform/terminal/common/terminal.ts#L540-L543
I guess we could just expose that as a type in onExit too, looks like tasks is still the only consumer that uses the value on the event I believe. If you want to try this, change this line:
https://github.com/microsoft/vscode/blob/33dc88051116ceceea42bdb7027a8989d3eeb763/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts#L1412
To this or similar:
this._onExit.fire(exitCodeOrError)

👍 I'll make the tasks changes in February: https://github.com/microsoft/vscode/issues/141728


Infographics / charts update

Updated charts
charts_2022.zip

Just as reminder - would be great if we could do sth about it.


Assigning and adjusting the zoom ratio does not seem to work

Hello, I need help.
I tried using the zoom percentage adjustment feature and it is not getting the new value received.
I followed the example:
Wheelzoom (document.querySelectorAll ('img'), {zoom: 0.05});
I changed the value of 'zoom: 0.05' to other values like '0.05', '0.50', '10.00' and others ... did not make any difference.
I tested by adding a new default variable to test with an 'Alert' inside the script and also did not change the value:
Wheelzoom (document.querySelectorAll ('img'), {direction: 5});
And added the default variable:
Window.wheelzoom = (function () {
Var defaults = {
Zoom: 0.10,
MaxZoom: false,
Direction: 1
};
Alert only shows '1' and not 5 assigned.
What could be the problem? Or what can I be doing wrong?
From now on, thank you very much for your contribution with this script, really very useful and has helped me a lot until now.

The fact that your direction value wasn't updated is fine and expected.  The script isn't merging the whole defaults object into a new settings object, it's just looking at the values it actually uses (zoom and maxZoom).
I don't know why changing the zoom value didn't work.  Since that's not something I can reproduce, it would help if you provided a link that demonstrates the problem.


[iOS]Multiline textinput can not pop toolbar on pressing the empty area.

Description
Multiline textinput can not pop 'Paste | Select ...' toolbar when pressing the empty area.
Reproduction
Simply render this:
      <View style={{flex: 1}}>
        <TextInput style={{flex: 1, backgroundColor: 'yellow', marginTop: 30}}
                   multiline={true}
                   value={this.state.text}
                   onTextChange={text => this.setState({text:text})}/>
      </View>

If I press the line with text or cursor it works, otherwise not.

It should pop the toolbar as the same as the iOS original APPs like Note.app do.
Single line textinput does not have this problem.
Additional Information

React Native version: 0.41.0
Platform: iOS (Android not test)
Operating System: MacOS

This is probably not the highest-priority issue.
If you can fix this in the native code and send a PR, we can probably get it landed for you.

I already have a fix for it. I hope I will land it soon after proper testing.

@ericvicenti
Here was the fix requested over a month ago.   https://github.com/facebook/react-native/issues/12740

Should be already fixed now.
@sohobloo Do you still experience this problem on master now?

@shergin Still in 0.43.3

0.43.3 !== master


[PE-D][Tester D] Email is not unique

For different people, email should also be unique. However I am able to edit a person's email to same as another person. As shown in below screenshots.
Before commands

After command to edit A's email

Labels: severity.Medium type.FunctionalityBug
original: yashma-sonara/ped#5

Not allowed to fix as current functionalities does not cause any bugs for this portion
According to Q5 of https://nus-cs2103-ay2324s2.github.io/website/schedule/week12/project.html


[Bug]: JSON.parse fails in List Widget, needs escaping single quotes

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

originalBinding - "((currentItem) => { navigateTo(currentItem.task, {})})(JSON.parse('{"step":"#1","task":"Drop a t'able","status":"✅","action":"'"}'))"

Whenever data has a single quote in it, JSON.parse,
root cause
// In ListWidget/widget/index.tsx line no. 461
  `{{((currentItem) => { ${next}})(JSON.parse('${escapedStringifiedListItem}'))}}`

  // here we have single quotes

Solution

Either change the way listWidget access its currentItem or
Escape the single quotes and after JSON parsing unescape them.

Steps To Reproduce

Add list widget to canvas and add a button to the item.
List widget options =

[
  {
    "step": "#1",
    "task": "Drop a t'able",
    "status": "✅",
    "action": "'"
  },
  {
    "step": "#2",
    "task": "Create a query fetch_users with the Mock DB",
    "status": "--",
    "action": ""
  },
  {
    "step": "#3",
    "task": "Bind the query using => fetch_users.data",
    "status": "--",
    "action": ""
  }
]

Add onClick of button {{navigateTo(currentItem.task, {})}}
Click on button and see the issue

Environment
Production
Version
Cloud

https://github.com/appsmithorg/appsmith/pull/11525 with this PR, we won't have JSON.parse inside list widget and hence this issue will be resolved.
cc: @hetunandu can you confirm this.

incidence of error missing ) after argument list, 6m: 1000
of these, ~400 encountered this error after first having placed a list widget on the canvas
Stats

Stat
Values

Reach
400

Effort (months)
<>

Removing app viewers pod tags here


Template Details: Reset images on navigation

Bug Description
@merapi had a great idea to reset the state of the template images when navigating to prevent the lag on the grid.
Expected Behaviour
No more lag on template images in detail modal
Steps to Reproduce

Screenshots
https://drive.google.com/file/d/1hW4zUkfNIX0X6f-4Y5zIn3Q8gzeQcJ66/view?usp=sharing
Additional Context

Plugin Version:
WordPress Version:
Operating System:
Browser:

Tested against https://stories-qa-wordpress-amp.pantheonsite.io/wp-admin/, using PR #10193.

Opened https://stories-qa-wordpress-amp.pantheonsite.io/wp-admin/
Clicked on Stories > Explore Templates
Clicked on See details on any template
Used arrows <- and -> to switch templates - images loading as expected, no images from previous template are displayed when a new template is open

https://user-images.githubusercontent.com/96055551/150090753-0d319ea7-0467-4e53-ae41-a4adcf3c3f5d.mp4


godot-llightmap vs official lightmapper

Hello,
I have a question for you related to the differences between your project and the official lightmapper. From the examples on youtube, your solution is clearly better at lighting dynamic objects.
In official, it looks as if objects going beyond the radius of the lamps in the scene drastically lose illumination.
No lightmap:
https://i.imgur.com/9U9Ywxf.png
Baked lightmap, dynamic sphere outside omni light radius:
https://i.imgur.com/erllWII.png
Baked lightmap, dynamic sphere inside omni light radius:
https://i.imgur.com/UCMf8Yn.png
Have you looked at how the 'Capture' data is calculated in the official lightmapper? Perhaps your experience could help clarify what the problem is? Voxel octree does not take indirect lighting into account? Or perhaps the propagation between cells is too small?
Related issue:
https://github.com/godotengine/godot/issues/69098
I don't currently see a way to properly light a scene in Godot in a project that will run in a web browser. In Godot 3 you can only use lightmaps in GLES2 with the problem as above, on the other hand in Godot 4 light probes only work under Vulcan.

I haven't really looked into how the core lightmapper (in 3.x and 4.x) does light probes, there are probably some bugs, it is more JFons and reduz area. I currently have a lot on my plate for 3.6, and I'm not really keen to spend time investigating core lightmapper as it isn't well geared for low end devices (which is more my interest).
Longterm I'll be aiming to move LLightmap (or similar) into my feature fork of 3.x, so it will be available as an alternative, and perhaps I can make it easier to use if integrated more into the engine (rather than just a module). Also bear in mind LLightmap uses some super shortcuts to make lightprobes super compact in terms of data, and fast at runtime. They don't work perfectly in all scenarios.
If you are struggling, I would suggest use LLightmapper rather than core (in 3.x at least, possibly in 4.x if you get creative) or possibly use a mix of the core lightmapper and lightprobes from LLightmap (you can bake lights in both, but only use the lightprobe file). It's a while since I wrote LLightmap (2-3 years ago) so I can't confirm this will work, but from memory it sounds feasible.

Thank you for your response.
I will try to work something out. Good luck with your work on 3.6 :)


Monitoring unconfirmed_transactions

Based on unconfimed_transactions we will try to look for some anomaly in the block-based unconfirmed transactions.
Also we are going to integrate this into a new API endpoint for network / chain monitoring.
To get a full list of our API got to: https://grinnode.live/faq

moved to https://github.com/MCM-Mike/grinnode-live-frontend/issues/6


MyersDiff: DEFAULT_EQUALIZER should not be reused per instance

Constants should be static. In this case, that doesn't work due to generics.
Since it's only used in one place, I just used it directly there with a comment.

To be honest I don't understand your issue. Is it because I named it DEFAULT_EQUALIZER, like a constant?

Yeah, the convention is part of it. Mostly I just noticed it was a waste of space to have duplicate copies for every instance.
It's kind of a minor issue, but this fix cuts the storage requirements in half.


Newly uploaded observations don't show up in list, even after refresh

The only way to see them is to restart the app. Have played a bit with staleTime and cacheTime to no avail.

fixed in #463


Fix false positive for valid css with space-around-operator

This PR fixes a bug where valid css would:
1 - Be flagged up as requiring a space
2 - Cause a error with the parser.
The css in question is negative values for margin, top etc
margin: -15px;
Ps. Thanks to @DanPurdy for catching it!
Closes #394
DCO 1.1 Signed-off-by: Ben Griffith<EMAIL_ADDRESS>

How about variable/selector names, I know they're not targeted but in anticipation of gonzales changes that may affect this it would be good to have them in?

I don't feel that's necessary. Since we're only ever targeting ['condition', 'atruleb', 'value', 'atrulerq'] to begin with, selectors should never come up. I know you could potentially future proof it (somehow?!) but I can't see any reason why a character within a selector would ever be classed as an operator.

'should' :wink:
Update this and it's good to go

grr update again and let me know.

I've clicked update. Now it's just waiting game...


Fix for docker-compose.yml

In Docker for Mac w/v1.12, you get the following error:
$ docker-compose up
ERROR: The Compose file './docker-compose.yml' is invalid because:
web.ports is invalid: Invalid port ":80", should be [[remote_ip:]remote_port[-remote_port]:]port[/protocol]
This PR fixes it.
cc @fermayo

@fermayo Ping


Definition of FIELDS_MANF missing distributors

When KiCost call say to not scrape some distributor, the definition of FIELDS_MANF of eda_tools.py will not have the name of the field of this distributor (e.g. digikey#).
This may create a "not grouping" issue if some of the parts designed have this field, because this part field will be not ignored to create the group and so, not propagated to the semi identical part without the manufacturer / distributors codes.
Also affect the subpart_split(), but in this case may not create a issue.
Propose of solution, do not pop the distributor from distributors_dict dispite, create a variable control with the information of the distributor to scrape / scraped (to use in the spreadsheet).

Fix this with the path of the issue #171 that will provide a modification on the group code.


Account for the different signal handler types.

This commit would be an API breaking change: nix::sys::signals::sigaction get's a different signature.
It currently leaves the responsibility of passing the SA_SIGINFO flag if necessary to the user.
This might solve part of #49.

Thinking more about this, the constructor function new is now unsafe. If you pass in a extern fn(SigNum, *mut siginfo, *mut libc::c_void) you also have to pass flags with SA_SIGINFO and for extern fn(SigNum) the flag must not be set.
I see two solutions: Either add/remove those flags everytime (just in case) change the return value to a Result and signal an error, if the flags are not appropriatly set. Both go against the idea of zero cost abstractions. However, we cannot provide a safe interface without them.
The third option is to mark the method unsafe and describe in a comment why. This whay the caller know what he has to do, to ensure safety.

I'm not following the reasoning behind not wanting to force the correct setting of SA_SIGINFO based on the enum variant. This seems like a perfect place for nix to help the user do the right thing.

My problem was (and still is) that it is no longer a zero cost abstraction. But all our error handling code already adds additional costs, so I opted to push a variant that sets or unsets the flag as necessary.

Regarding "zero cost", I think your commit comment captures what that means. It's ok to put in a few extra instructions for the infrequent thing, but the actual calling of the signal handlers will have no cost above what you'd expect in C. This differs from, say, Go which handles signals by passing them to channels, or Python, where the signal handlers are Python functions and so there's some per-signal overhead there.

Unless there are further concerns I would like to merge this, in particular, because I want to use it (and apparently others too).

Sounds good to me!

Merged as 645c48f2890cd5ef993f6a73970a693e26ca5f91...645e37d22e5453d9aaf8634095a4150789e74b0e.


[move-prover] Fixing order of pack arguments.

It appears the fields in a pack expression we get from move-lang expansion phase are not ordered by offset. This PR uses the order as found in the declaration instead of in the pack expression.
Motivation
Bug fix
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
As we don't yet translate Pack to Boogie, this is not easy to test, so it's kind of a blind flight.
Related PRs
NA

Look good!

@bors-libra r=junkil-park

:pushpin: Commit 5052dce has been approved by junkil-park

:hourglass: Testing commit 5052dce804c58077d71a6f047148bbb35512dc5e with merge 3a1a69a4f662a9e81dc1fd292860df4c25bfeca3...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: junkil-park
Pushing 3a1a69a4f662a9e81dc1fd292860df4c25bfeca3 to master...


rhel 8 in Azure

Error:
sudo dnf install dotnet-sdk-5.0
gives an error:
Last metadata expiration check: 2:44:52 ago on Mon 08 Feb 2021 10:06:03 AM UTC.
No match for argument: dotnet-sdk-5.0
Error: Unable to find a match: dotnet-sdk-5.0
yum list dotnet
gives an error:
Red Hat Enterprise Linux 8 for x86_64 - BaseOS - Extended Update Support from RHUI (RPMs)                                  0.0  B/s |   0  B     00:00
Errors during downloading metadata for repository 'rhel-8-for-x86_64-baseos-eus-rhui-rpms':

Curl error (58): Problem with the local SSL certificate for https://rhui-2.microsoft.com/pulp/repos/content/eus/rhel8/rhui/8.2/x86_64/baseos/os/repodata/repomd.xml [could not load PEM client certificate, OpenSSL error error:0200100D:system library:fopen:Permission denied, (no key found, wrong pass phrase, or wrong file format?)]
Curl error (58): Problem with the local SSL certificate for https://rhui-1.microsoft.com/pulp/repos/content/eus/rhel8/rhui/8.2/x86_64/baseos/os/repodata/repomd.xml [could not load PEM client certificate, OpenSSL error error:0200100D:system library:fopen:Permission denied, (no key found, wrong pass phrase, or wrong file format?)]
Curl error (58): Problem with the local SSL certificate for https://rhui-3.microsoft.com/pulp/repos/content/eus/rhel8/rhui/8.2/x86_64/baseos/os/repodata/repomd.xml [could not load PEM client certificate, OpenSSL error error:0200100D:system library:fopen:Permission denied, (no key found, wrong pass phrase, or wrong file format?)]
Error: Failed to download metadata for repo 'rhel-8-for-x86_64-baseos-eus-rhui-rpms': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 577ce9b2-5b48-4ed2-c309-a78880015dd2
Version Independent ID: 26300783-8df5-56a1-4ab6-4b8511e37f51
Content: Install .NET on CentOS - .NET
Content Source: docs/core/install/linux-centos.md
Product: dotnet
Technology: dotnet-install
GitHub Login: @adegeo
Microsoft Alias: adegeo

@freerider7777 I'm not sure what we can do for you here. It sounds more like you have some sort of problem with RHEL directly and/or the Azure machine. I would ask your question in a RHEL forum or Azure support ticket. I'm going to close this issue as I don't believe we can help. Sorry about that!


security HUD now shows a job icon on entities with a body

About the PR
security HUD now shows a job icon on entities with a body
https://github.com/space-wizards/space-station-14/issues/4967
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame

Changelog
:cl:

add: added an overlay for the security hud that displays job icons

It says 600 lines added but 400 of that is just the yml to define the icons, so don't be intimidated :)

You could probably remove all the job status icon prototypes by just creating instances of StatusIconData using the icon from the job prototype itself. It would not only reduce a lot of yaml but it would also ensure that the icon used for a job always mirrors the icon assigned in yaml on the job prototype.

You could probably remove all the job status icon prototypes by just creating instances of StatusIconData using the icon from the job prototype itself. It would not only reduce a lot of yaml but it would also ensure that the icon used for a job always mirrors the icon assigned in yaml on the job prototype.

Isn't the JobPrototype only on spawn?
I want to support the HoP's job changes as well.

Isn't the JobPrototype only on spawn? I want to support the HoP's job changes as well.

haven't looked into it much. I was thinking that the job prototype was on the ID somewhere, but if it's not then how you do it is probably fine.

This shouldn't be merged without AgentIDs also being made to be able to spoof your job icon

This shouldn't be merged without AgentIDs also being made to be able to spoof your job icon

Wouldn't this already break upon using inspect ID?

This shouldn't be merged without AgentIDs also being made to be able to spoof your job icon

Wouldn't this already break upon using inspect ID?

But with this change your don't have to physically search their ID to find out.

But with this change your don't have to physically search their ID to find out.

So agents wear an ID that says "SPY" on it and the issue you're having is that displays that more easily?

But with this change your don't have to physically search their ID to find out.

So agents wear an ID that says "SPY" on it and the issue you're having is that this displays that more easily?

The agent ID is customisable fake ID used when you want to impersonate people with jobs. If a sechud can see that it had the wrong icon it becomes kinda pointless.

The agent ID is customisable fake ID used when you want to impersonate people with jobs. If a sechud can see that it had the wrong icon it becomes kinda pointless.

Just type in the correct job name then?

what about nukies with the S next to them so other nukies can tell whos who

Does this have the unknown icon for people without an ID?

Does this have the unknown icon for people without an ID?

No the "NoId" icon, which is a question mark.

what about nukies with the S next to them so other nukies can tell whos who

That should likely be some FactionOverlayComponent that is attached to nukies on spawn.

@ElectroJr I processed your review comments in this PR.

Will review today

Going to fix the agent ids and hop screens first.


JuliaCon 2019 | Intelligent Tensors in Julia

Intelligent Tensors in Julia, https://www.youtube.com/watch?v=A2ypJkA26co
Sebastián Grijalva made timestamps for this video and put it in the comments to this video. Their are NOT made by me.
First the video need to edited again, four minutes at the beginning where nothing happens is too much. After that we can tweak there in appropriate way and add them to description.
04:00 Beginning of the talk
09:48 Definition Tensor Networks
12:33 ITensor using indices and basic operations
14:35 ITensor community and other higher level functions
15:38 Moving away from C++
16:42 Moving to Julia
18:46 Pain Points with Julia
19:34 Internal Details of ITensors
21:33 GPU functionality
25:24 Future Directions (2019)

Great, I just trimmed the first 4 minutes off, can you update these timestamps?

bumping this @KZiemian

Is this what you wanted
const exp = src.replace(/\d\d(?:\:)/g, (val) => ((Number.parseInt(val) - 4) + ":").padStart(3, "0"));

00:00 Beginning of the talk
05:48 Definition Tensor Networks
08:33 ITensor using indices and basic operations
10:35 ITensor community and other higher level functions
11:38 Moving away from C++
12:42 Moving to Julia
14:46 Pain Points with Julia
15:34 Internal Details of ITensors
17:33 GPU functionality
21:24 Future Directions (2019)
If it wasn't exactly 4 minutes that was trimmed off then the code can be modified a little.

Thank you @Andy2K11. In the last two weeks I have hand full of work, but I will try check this today.

Finally! After very long time I taken timestamps made by Sebastián Grijalva (see comments section on YouTube) and refined them a bit watching current version of the talk. Below you can seen a result.
00:00 Welcome!
00:44 Why we need packages for working with tensors?
02:12 We work with very big tensors
03:35 Notation used in this talk (we like it)
05:23 Question: can you write double line between A and B?
05:51 Definition of tensor networks
06:43 How we code tensor operations?
08:33 Basic functionality of ITensors.jl
10:38 ITensor community
11:18 Higher level features that we want to port to Julia
11:44 Moving away from C++
12:46 Moving to Julia
13:24 Julia strong points
14:50 Pain points with Julia
15:38 Internal details of ITensors.jl
17:27 Adding fully tensor aware GPU functionality
19:01 Benchmarking tensor contractions
20:27 Limitations of GPU-based ITensors.jl
21:27 Future directions (state from 2019)
22:05 Check out https://github.com/ITensors/ITensors.jl
22:24 Acknowledgments
23:23 Q&A: which of things mentioned if futures directions can attract new people to Julia?
24:24 Q&A: how ITensors.jl benchmarks against other tensors packages?
24:23 Q&A: do you have any BLAS 3 like operations written in Julia?
25:48 Q&A: how you handles internal indices during SVD?

@Andy2K11 I apologize for not mentioning you regular (expression) contribution. It was to late to think clearly.

@KZiemian I wasn't expecting you to, did it for practice really and thought it might be useful as I'd seen you were doing a bit of work on them (Issue #106). With JuliaCon happening I wasn't sure if there would be much need for processing the timestamp formatting from different contributors, I guess if it works then that's the main thing, but let me know if you think I can help.

Thank you. Timestamps were added to the video, we will close the issue, when we get access rights to this GitHub repository.

We can now close this issue.


added read aloud

Related Issue
#121
Description
added read aloud option so that users can listen to the articles
Type of PR

[X] Feature enhancement

Screenshots / videos (if applicable)
https://github.com/SiddharthBahuguna/NEWS-AGGREGATOR-PROJECT/assets/117447090/026110e5-daec-4c6b-84a2-be8b77bd48f5
Checklist:

[ X I have performed a self-review of my code
[X] I have read and followed the Contribution Guidelines.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

Additional context:
I also fixed base.html path specified in index.html and bookmarks.html

@anurag6569201 Please check.

@SiddharthBahuguna , is something missing ??

@rashiranjan22 what us the use of start stop pause

when one click on start button it fetches the article content on the website the url directs to and start reading it
with pause/resume one can pause it and resume it where it was left
stop button stops it completely

@SiddharthBahuguna , please label the PR


File perpetually marked as "unsaved"

After importing a URL, the document I import into seems to get stuck in an unsaved state.  Closing Figma completely and reopening it never seem to lose any changes, but I need to click to discard any changes which is a bit scary.

Hey @Subcide, thanks for reporting! I've been digging into this and have found the culprit, sometimes Figma lands in this state when it has trouble loading one of the images
I'm working on making a script to comb through the images and figure out which one Figma won't load and remove it. Will report back when I've found a reliable solution and the plugin is updated

Ok! I isolated the problem to a bug in Figma where you can upload an SVG file as a background image, but then it breaks saving. I now detect SVGs and convert them to SVG layers instead
I published the latest version of the plugin with this fix, give it a try and let me know if you have any other issues!

Thanks mate, the SVG issue I was going to file separately so glad to see they're related.  I'll re test later tonight.


chinese translate error

In zh-Hans, there is a simple translate error.
original:

Note:You can't register Babel in the same file that you want to compile. As node is executing the file before Babel has a chance to compile it.

to chinese:

注意：你不能在你要编译的文件内同时注册 Babel，因为 node 会在 Babel 编译它之间就将它执行了。

When I read the chinese version, it confuse me. Then check the original and make sure this is a translate error.
It's the

之间

should be

之前

We maintain the translations via crowdin, if you want to update it head over here: https://github.com/thejameskyle/babel-handbook/blob/master/CONTRIBUTING.md#translating-the-handbook

Got it. I added my suggestions at crowdin.

Cool thanks


Implement current_time Presto Function

Description
Add missing function to handle current_time prestosql function.
Please assign it to me, thanks!

I am working together with @minhancao on this issue, please assign it to me as well. Thanks.

+1. It would be nice to have a full implementation of the Presto function dialect for use cases outside of Prestissimo. @yiweiHeOSS @minhancao just assigned it to you.


input: Driver.Cancel Doesn't Work On Windows

Describe the bug
A clear and concise description of what the bug is.
The Input package has a Driver type that has a ReadEvents method and a Cancel method that seems like it is supposed to cause in-flight ReadEvents calls to die and return an error.  This does not work on Windows, because the underlying engine of ReadEvents is the github.com/erikgeiser/coninput ReadConsoleInput method, whose underlying engine is Windows' ReadConsoleInputW syscall.  This syscall has no cancellation or timeout mechanism and will hang forever until it receives some sort of input.
Setup
Please complete the following information along with version numbers, if applicable.

OS Windows 10
Shell Windows CMD
Terminal Emulator Windows Terminal

To Reproduce
Steps to reproduce the behavior:

Attempt to retrieve background color with lipgloss v2

Source Code
lipgloss v2's standalone color example
Expected behavior
Either retrieving the background successfully or time out

After digging around a bit:

The windows Driver seems to be built to specifically handle key and mouse input only, with the idea that full blocking on a goroutine waiting for that stuff makes sense
Unfortunately, non-windows Driver handles EVERYTHING.  Calling the Driver with an ANSI query will inevitably work on non-windows and fail on windows
The windows CancelReader seems to handle everything appropriately (? not sure on this) but nothing actually calls the windows CancelReader. The stdin handle is used by ReadConsoleInput, but the methods are not ever actually called.  This seems like an issue.

I have verified locally that removing the windows-specific code for Driver.ReadEvents fixes this issue (and also successfully retrieves the background color in the preview version of windows terminal) but I don't know what knock-on consequences that might have elsewhere. I see that bubbletea v2 has its own version of this code and has a readInputs method that calls ReadEvents and I suspect that that code actually intends to call the blocking ReadConsoleInput method, so I imagine that both are necessary.

Hi @CannibalVox, thank you for reaching out and reporting this issue. Indeed, Bubble Tea has its own version of x/input. We're planning on deprecating x/input since the code moved to Bubble Tea v2.
As for the issue, I suspect the problem was due to this hack. You see, when using the Windows Console API instead of their Virtual Terminal mode (the default), we need to parse escape sequences as if they were key events. The code in x/input is outdated and sometimes won't correctly read the responses. This was fixed in https://github.com/charmbracelet/bubbletea/pull/1163. We need to not use the Virtual Terminal input mode so that we can read window resize events and extended keyboard/mouse events.
I've opened https://github.com/charmbracelet/lipgloss/pull/429 to fix this issue in Lip Gloss.

Thank you! I've confirmed that the linked PR fixes the issue:

Standalone CMD does not hang and returns a nil background color immediately
CMD hosted in Windows Terminal does not hang and returns a nil background color immediately
MINGW hosted in Windows Terminal does not hang and returns a nil background color immediately
CMD hosted in Windows Terminal Preview returns the correct background color
MINGW hosted in Windows Terminal returns the correct background color


config: Add Memory slots config

When we try to update the memory more than one time the runtime will try to add another slot of memory. This will fail due to we only add one extra memory slot.
Because the amount of slots has to be defined at qemu startup lets define a amount of slots.

@grahamwhaley indeed, I missed those comments but totally related, by now 10 by default is a good number for me I dont want to increase the  memory footprint a lot at this moment but give to the admin a way to decide the times that memory can be increased.

@jcvenegas - we should probably pull in @clarecch then to make sure we all agree and co-ordinate these two PRs :-)  thx!

@grahamwhaley agree! @clarecch does it work for your proposal, I only tested for docker update but I guess will need to modify the default in does not fit with your findings. If that is the case it could be updated later in your PR.

@jcvenegas I am also agree with this PR. I think it would be coordinate with my PR https://github.com/kata-containers/runtime/pull/624.
But could you generate a report on how memory slots impact container memory footprint mentions in https://github.com/kata-containers/runtime/pull/580#issuecomment-418305751
@grahamwhaley WDYT

LGTM!
The CI failure is fixed in https://github.com/kata-containers/tests/pull/761. Sadly we did not catch it earlier because PRs in the test repo won't run UTs in other repos (and I agree we shouldn't run it either.)

@jcvenegas @clarecch - it would be great to see if we can measure the footprint impact. @jcvenegas - you could try using https://github.com/kata-containers/tests/tree/master/metrics/report to do a before/after comparison. You probably don't need the storage data, so run the grabdata with -d -t, as I think we may as well see if there is a visible boot time cost as well (for any setup - I suspect not, or not measurable, but it is cheap to look and check).

@jcvenegas Can you squash the commits? I think it's not a big PR and we can easily review it, so might to good to squash to one commit.

@Weichen81  done, lets wait for the CI, restarted fedora (network issue)

@grahamwhaley  @jodh-intel dump ready :)

metrics_report.pdf
10 slots vs 250 slots  density metrics.

metrics_report-2-250.pdf
Updated now compare 2, 10, 100, 250 slots

@grahamwhaley  @clarecch  based in the results from 2 slots to 10 we got 0.2828925 MB more per VM (without KSM)
For  2 to 250 we are getting 1.47520875 MB per VM  more.  I think we are safe to merge this by now.
Note: The difference is in MB not Mb

Thanks @jcvenegas Can you tell us what they are as a % figure (generally easier to assess say a '1% growth' vs '12% growth' rather than raw physical bytes :-)

Additional information the initial used memory in the VM is increased as well.
$ kata-runtime kata-env | grep Slots
  MemorySlots = 250
$docker run --rm --runtime kata-runtime -ti  busybox free -m
             total       used       free     shared    buffers     cached
Mem:          1995         56       1938          7          2          8
-/+ buffers/cache:         46       1949
Swap:            0          0          0
$ kata-runtime kata-env | grep Slots
  MemorySlots = 2
$docker run --rm --runtime kata-runtime -ti  busybox free -m
             total       used       free     shared    buffers     cached
Mem:          1995         46       1949          8          2          8
-/+ buffers/cache:         36       1959
Swap:            0          0          0

@chavafg jenkins got stuck ? jenkins-ci-ubuntu-16-04 Expected — Waiting for status to be reported

@jcvenegas no, that means someone needs a /test comment

/test

/test

so it seems something is broken for the runtime jobs, taking a look

/test

/retest

/test

fixed :) jobs already triggered

initrd failed on cri-o tests, restart CI job.
not ok 7 ctr logging [tty=true]
# (in test file ctr.bats, line 239)
#   `grep --binary -P "^[^\n]+ stdout F here is some output\x0d$" "$logpath"' failed
# time="2018-09-21T16:57:32Z" level=error msg="File descriptor 3 (pipe:[388378]) leaked on pvdisplay invocation. Parent PID 9151:

@sboeuf  @devimc @jodh-intel  @bergwolf  ready to merge.
@clarecch what are the next steps?

@jcvenegas all good, let's merge that!

Good job, thanks @jcvenegas


Moving a child to the the outermost level not possible

So I'm facing a problem where if an item is child I can't move to the outermost level. For example if the list consist of one item with a child. I'm not able to make that child a sibling of it's parent. Any idea on how I can make this possible?

I understand what you want. It is really not possible.

there was some css causing me the problem. Now I am able to move items out of their parents.

I had some css on the list that was causing some errors.

I dont understand. Top level is li element not new list.


Default page not loading ('/')

I have configured mead , db is created and when i access the www.yyy.com for which mead is configured , error meaasge: "The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application." .When I looked into apache log file I din get any error message. I have not changed any default mead config.
When tried in localhost, jinja2.exceptions.TemplateNotFound.

it's now working.
https://github.com/meadsof/mead/tree/5b61a88322cacc96aaa6cdb46e25bf4f34b7ccdb


Bug: applying formatting to table cells with mixed formatting does not make formatting consistent

Table selection containing a mix of text formatting toggles formatting per cell, rather than for the selection as a whole. The examples below talk about italics but the same applies for bold/underline/strikethrough, etc.

After pressing Italics button:

Lexical version: latest in Playground as of 2024-09-04
Steps To Reproduce

Insert a table with at least two cells
Put text in two different cells
Italicise text in one cell
Select the cells with text
Press the Italics button in the toolbar

The current behavior
For each cell, if the contents are italics, they become non-italics, and vice versa.
The expected behavior
The whole selection should become italicised or not, rather than cells toggling individually. This would match the behaviour of a range selection that contains a mix of italics/non-italics: it becomes all-or-nothing italics.
Impact of fix
It's not breaking any workflows, but the behaviour is unexpected as it differs from other text editors.

Was fixed in https://github.com/facebook/lexical/pull/6626


updated for Xcode 6.0, Swift 2.3

No source code changes where necessary, just updated the project files.

Thanks! :v:

Released with a pre-built binary!


CI

[x] C# Module

[x] Debug build
[x] Release build

[x] Rust Match Maker Server

[x] Debug build
[x] Release build

[x] Godot Example Project

[ ] ~Debug build~
[ ] ~Release build~
[x] 4.1.0
[x] 4.2.0.rc-1

Done with #18 #19 #20


(Bug) app is stuck long time on splash or on loading feed

this happens mostly on mobile devices
I saw that it mostly hangs around Appswitch initialize method

@sirpy App is still stuck long time on loading feeds
https://www.screencast.com/t/ldDo7jPDYvn
Checked on DEV V1.1.2
LG V30+ // Android 8.0 // Google Chrome 84.0.4147.111
iPhone 8 //13.3.1

@AnastasiiaOdnoshevna its fine a few seconds is ok
compare it to next where its either stuck or can take 30+ seconds


formula: add on_linux and on_macos blocks

for install and others

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?
[ ] Have you successfully run brew man locally and committed any changes?

@MikeMcQuaid I made the asked changes but the style check is not happy with that:
Library/Homebrew/extend/os/linux/formula.rb:8:5: C: Style/GuardClause: Use a guard clause (raise "No block content defined for on_linux block" unless block_given?) instead of wrapping the code inside a conditional expression.
    if block_given?
    ^^

I'll change it make it pass :)

This pull request is still a work in progress
Draft pull requests cannot be merged.

@iMichka Is this still true? If not: can you mark as "ready for review"?

@iMichka Is this still true? If not: can you mark as "ready for review"?

Done. Forgot to remove it.


With Tailwind: adding

Versions

nuxt: 2.15.7
node: 16.3.0

Reproduction
https://github.com/Akryum/nuxt-issue-9546
(Project created from create-nuxt-app with Tailwind selected.)
Steps to reproduce

Open components/home/Test.vue and make changes to the template
Save

What is Expected?

The component is updated on the page with HMR

What is actually happening?

The component is not updated on the page
Need to do a full page refresh

Everything works correctly with components/home/Test2.vue (without the style block).

Same here. It's updating some other file for me too. I'm using SCSS with Scoped styling in the component.
The first build isn't updating anything, then it updates again seeing a numeric file and then does a full page refresh.
This is the console output.
↻ Updated pages/any-page.vue                                                                                20:43:44

✔ Client
  Compiled successfully in 691.80ms

✔ Server
  Compiled successfully in 868.90ms

↻ Updated<PHONE_NUMBER>452                                                                                20:43:46

✔ Client
  Compiled successfully in 387.20ms

✔ Server
  Compiled successfully in 557.48ms

** This also happens when completely removing the style tag on the bottom of the page file.
Also it sometimes replaces the numeric file with .eslintcache. Maybe that's the problem?

same problem. have to do a full page refresh . also using Tailwind.

Happening to me too. I'm using tailwind, but disabling it seems to not really help I think.

After some testing, if you remove tailwind and delete the .nuxt folder it seems to fix itself so for now I too assume it's something to do with tailwind.

Possibly related: https://github.com/tailwindlabs/tailwindcss/issues/4968 and https://github.com/nuxt/postcss8/issues/18

Only downgrading seems to help for now

Possibly related: tailwindlabs/tailwindcss#4968 and nuxt/postcss8#18
Can someone try using TAILWIND_MODE=watch nuxt dev? ☺

Hi @manniL When will you solve this problem, because we are working inefficiently.

@manniL Thanks for taking the time to look into this. However, setting TAILWIND_MODE=watch does not make it work.

I wonder if it has something to do with eslint too. I am facing the same issue as @HenrijsS and sometimes I see .eslintcache is triggering a new build. This works:
  buildModules: [
    ...
    ['@nuxtjs/eslint-module', { cache: false}],
    ...
  ],

In the other hand, I guess disabling eslint cache will result in slower build times.
Anyone with a better solution? Since Tailwiund 3 only works on PostCSS8, downgrading doesn't seem to be a solution anynore.

Also experiencing the issue where .eslintcache is triggering a hot reload, causing an endless loop. It's also being triggered by Tailwind's Config Viewer, which is generating a timestamp file:
✔ Client
  Compiled successfully in 589.52ms

✔ Server
  Compiled successfully in 287.45ms

↻ Updated .eslintcache                                                                                22:44:04

✔ Client
  Compiled successfully in 563.40ms

✔ Server
  Compiled successfully in 217.34ms

↻ Updated<PHONE_NUMBER>793

Similar to @IsraelOrtuno's solution, it can be fixed with
export default {
  buildModules: [
    ['@nuxtjs/tailwindcss', { viewer: false }]
  }
}

Any idea why these files are suddenly triggering the hot reload? I haven't had any issues with this before, including on projects that use .eslintcache and have Tailwind's Config Viewer enabled.

I tried @slavanossar solution and enabling estlint cache:
export default {
  buildModules: [
    ['@nuxtjs/tailwindcss', { viewer: false }]
  }
}```

But still experiencing the infinite loop, this solution didn't work for me which makes this issue even more weird. Wondering if it has something with Tailwind 3 or PostCSS 8

I have an infinite loop during my builds since my update of @nuxtjs/tailwindcss which contains tailwind 3.

Console logs
ℹ Listening on: http://localhost:3000/                                19:24:34
↻ Updated layouts/default.vue                                         19:25:02
✔ Client
Compiled successfully in 1.61s
✔ Server
Compiled successfully in 1.68s
↻ Updated .eslintcache                                                19:25:05
✔ Client
Compiled successfully in 770.87ms
✔ Server
Compiled successfully in 774.74ms
↻ Updated<PHONE_NUMBER>762                                               19:25:07
✔ Client
Compiled successfully in 642.74ms
✔ Server
Compiled successfully in 778.50ms
↻ Updated .eslintcache                                                19:25:09
✔ Client
Compiled successfully in 786.75ms
✔ Server
Compiled successfully in 641.37ms
↻ Updated<PHONE_NUMBER>588                                               19:25:11
✔ Client
Compiled successfully in 621.53ms
✔ Server
Compiled successfully in 731.45ms
↻ Updated .eslintcache                                                 19:25:13

Sometimes its ".eslintcache", other times random numbers.
By setting the cache property of eslint module to false, it works perfectly again. I see this as a temporary fix...
  buildModules: [
    // https://go.nuxtjs.dev/eslint
    ['@nuxtjs/eslint-module', { cache: false }],
    // https://go.nuxtjs.dev/stylelint
    '@nuxtjs/stylelint-module',
    // https://go.nuxtjs.dev/tailwindcss
    '@nuxtjs/tailwindcss',
  ],

Thanks a lot @IsraelOrtuno , even if it is not ideal it is better than removing all eslint packages.

I tried @slavanossar solution and enabling estlint cache:
export default {
  buildModules: [
    ['@nuxtjs/tailwindcss', { viewer: false }]
  }
}

But still experiencing the infinite loop, this solution didn't work for me which makes this issue even more weird. Wondering if it has something to do with Tailwind 3 or PostCSS 8

Sorry I meant both your solution along with mine fixed my endless loop. However I just realised that I only needed my solution because the .eslintcache file was still present – deleting the .eslintcache file first and only using { cache: false } is sufficient.

any news?


Add collect to Option, Try and Future

Implement #1932

Codecov Report

Merging #1946 into master will decrease coverage by 0.01%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master    #1946      +/-   ##
============================================
- Coverage     98.04%   98.03%   -0.02%
- Complexity     5112     5118       +6
============================================
  Files            89       89
  Lines         11577    11591      +14
  Branches       1523     1525       +2
============================================
+ Hits          11351    11363      +12
- Misses          108      110       +2
  Partials        118      118

Impacted Files
Coverage Δ
Complexity Δ

...ang/src/main/java/javaslang/concurrent/Future.java
99.55% <100%> (ø)
112 <2> (+2)
:arrow_up:

...aslang/src/main/java/javaslang/control/Option.java
100% <100%> (ø)
44 <2> (+2)
:arrow_up:

javaslang/src/main/java/javaslang/control/Try.java
94.48% <71.42%> (-0.54%)
91 <2> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85d7373...cb1d021. Read the comment docs.

Thank you :) I will finish my review this evening!

Thanks for review, I applied comments

Great, many thanks!


Add explicit license to the repository

Currently there is no license defined. I suggest adding a MIT license like in https://github.com/librecores/librecores-ci-jenkins-server/blob/master/LICENSE

I'll be happy to add a license for this if no one else is currently working on it.

#14

Lets close this issue @oleg-nenashev!


Module not found: Error: Can't resolve 'redux/lib/createStore' in '/dnd-core/lib'

The following error occurred when I implemented npm i to upgrade dependencies.
Here is the error message.
ERROR in /Users/***/demo/node_modules/dnd-core/lib/DragDropManager.js
Module not found: Error: Can't resolve 'redux/lib/createStore' in '/Users/***/demo/node_modules/dnd-core/lib'

Below are the relevant libraries and versions.
"react-dnd": "^2.6.0",
"redux": "^4.0.0",

If possible, please match Redux 4.0

We're using Redux 4 and this is working on my end - can you verify what version of React-DnD you're using?

I have the same error @glud123 how did you resolve it ?

I have the same error @glud123 @medslt how did you resolve it ?

I have the same error @glud123 @medslt how did you resolve it ?