Cilium native hostport only listens on a internal IP, unlike CNI portmap

Bug report
Cilium v1.8 release candidates include a native bpf hostport feature to replace CNI portmap chaining (#10359) implemented in https://github.com/cilium/cilium/pull/10592. In testing, it seems this feature is a partial implementation of CNI portmap.
When CNI portmap is used in a CNI conflist (with any CNI provider, not just Cilium), Kubernetes Pods that set a hostPort proxy any traffic on that host port to the container.
          ports:
            - name: http
              containerPort: 80
              hostPort: 80

For example, a PodSpec above would allow the web app to be accessed via multiple host IPs - hostPort maps multiple interface addresses (unless a single hostIP is set https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#containerport-v1-core).
curl <IP_ADDRESS>:80  (works)
curl <IP_ADDRESS>:80 (works)
curl publicipv4:80 (works)
curl [someipv6]:80 (depends)

In Cilium v1.8.0-rc3 the hostport feature works as described in docs, but its always picking the node's own internal IP, which doesn't satisfy the use cases CNI portmap had.
curl <IP_ADDRESS>:80  (no)
curl <IP_ADDRESS>:80 (works)
curl publicipv4:80 (no)
curl [someipv6]:80 (no)

cilium service list
...
13   <IP_ADDRESS>:80      HostPort       1 => <IP_ADDRESS>:80

So its not a bug per-se, more that the implementation isn't a drop-in for CNI portmap yet, unless the node's internal IP is the only address you are interested in. (imo) Most uses of CNI portmap to support containers with hostPort are using it to listen on any of the available host addresses.

node with a private IP (kubelet internal IP, tunnels) and public IP (interfacing with LBs)
health checks may expect the hostPort to be available on <IP_ADDRESS> or ::1 as well
node with multiple addresses for other reasons

For myself, I have to fallback to certain pods that could use hostPort to just using full hostNetwork.
General Information

Cilium version: 1.8.0-rc3
Kernel version: 5.6.11
Orchestration system version: Kubernetes v1.18.3

Workaround attempts by setting an explicit hostIP field in the ContainerPort spec as <IP_ADDRESS> will not actually work either, despite appearances.
            - name: http
              hostIP: <IP_ADDRESS>
              containerPort: 80
              hostPort: 80
            - name: https
              hostIP: <IP_ADDRESS>
              containerPort: 443
              hostPort: 443

kubectl exec -it cilium-agent-rplt6 -n kube-system cilium service list
...
14   <IP_ADDRESS>:80          HostPort       1 => <IP_ADDRESS>:80
15   <IP_ADDRESS>:443         HostPort       1 => <IP_ADDRESS>:443

curl <IP_ADDRESS>:80  (no)
curl <IP_ADDRESS>:80 (no)
curl publicipv4:80 (no)
curl [someipv6]:80 (no)

Yes I did validate and I am seeing the same behavior as well for the Hostport. The service is only accessible through the HostIP:Port combination.

@dghubble Fixed via #12446. For testing feel free to use docker.io/cilium/cilium:latest for the time being until it ends up in 1.8.2. Thanks for reporting!

Hey! Could this also affect docker0 bridge compatability?
The I am using portmap i am able to reach curl <IP_ADDRESS>:hostPort
With cilium BPF implementation I cannot anymore

Hey! Could this also affect docker0 bridge compatability?
When I am using portmap i am able to reach curl <IP_ADDRESS>:hostPort
With cilium native hosrtport implementation I cannot anymore

Thanks for the report, how does your pod spec look like?

Hey! thanks for looking into it. This is the spec i used to replicate the issue:
apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: my-nginx
spec:
  selector:
    matchLabels:
      run: my-nginx
  template:
    metadata:
      labels:
        run: my-nginx
    spec:
      containers:
      - name: my-nginx
        image: nginx
        ports:
        - containerPort: 80
          hostPort: 8081
`
And what i tried is curl from other pod:

curl <IP_ADDRESS>:8081

The issue I reported was specific to accessing a host port service from the host in question. And was resolved back in v1.18.2 (checked, still correct with Cilium v1.9.0 and Kubernetes v1.19.4).
You're talking about pod-to-pod (possibly cross-node, firewalls, etc) access to a hostport service, so there are a lot of other cases you'll want to rule out. Might be better as a separate issue.

We have Cilium version 1.9.4 setup on our cluster. While trying to run sonobuoy conformance tests, one of them is failing. The testname: SchedulerPredicates [Serial] validates that there is no conflict between pods with same hostPort but different hostIP and protocol [Conformance]
3 pods are setup along with another hostNetworking pod. From the hostNetworking pod, while trying to connect to localhost, its not able to connect (Connection refused). However, connecting to hostIp is working fine. We have --enable-host-port set to true by default. Kindly help.

The current implementation differs from the one in the portmap plugin.
Here is the portmap's implementation. As you can see, the destination filter will only apply if port.HostIP is present.
Here is how Cilium implements the same thing. Notice the iteration over IPs that are physically present on OS interfaces. But what if the Node's ExternalIP is ephemeral and is present only in cloud's networking stack? OpenStack does this with Floating IPs.

Can we, perhaps, add addresses from the Node object to the list? Those are set via cloud-controller-manager and always display the correct configuration on the cloud's side.

Can we, perhaps, add addresses from the Node object to the list? Those are set via cloud-controller-manager and always display the correct configuration on the cloud's side.

Hey @zuzzas, as far as I understand, this is enough to add both—internal and external IPs (if present) for the list, right?
Or an anchor IP for a floating IP can be something else than the internal IP? In this case we need to list all addresses assigned to network devices, not only the internal,external pair

That's what I believe.
It's a job for the cloud-controller-manager's code to write these IPs (even ephemeral ones) onto the Node object. They should be correct and sufficient.

Looks like this was resolved years ago, closing. If you see something like this again, please reproduce with v1.16.x or later and file a new issue.


Update the software list

Added a new vendor, thank you for your time and consideration.

Hello @Ebennetteng. We have updated the way we intake the data now, so you will want to make the addition this YAML file: https://github.com/cisagov/log4j-affected-db/blob/develop/data/cisagov_L.yml. For any questions, please consult the contribution guidance: https://github.com/cisagov/log4j-affected-db/blob/develop/CONTRIBUTING.md OR reach out here :)

Hi there, I've added the info to that file instead and I've tried to delete my changes from last time, thank you


K8SPXC-699 fix container runtime

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Test name
Status

storage
passed

upgrade-haproxy
passed

haproxy
failed

big-data
passed

scaling
passed

recreate
passed

init-deploy
passed

self-healing
passed

scaling-proxysql
passed

restore-to-encrypted-cluster
passed

security-context
passed

limits
passed

upgrade-proxysql
passed

monitoring-2-0
passed

self-healing-advanced
passed

affinity
passed

demand-backup
passed

smart-update
passed

one-pod
passed

operator-self-healing
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

pitr
passed

tls-issue-self
passed

upgrade-consistency
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

demand-backup-encrypted-with-tls
failed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/829/commits/630c521cfb3891c3d11911d7a26ddccde3b57226
image: perconalab/percona-xtradb-cluster-operator:PR-829-630c521c

Test name
Status

big-data
passed

upgrade-haproxy
passed

storage
passed

recreate
passed

haproxy
failed

scaling
passed

init-deploy
passed

self-healing
passed

scaling-proxysql
failed

limits
passed

upgrade-proxysql
passed

monitoring-2-0
passed

self-healing-advanced
passed

security-context
passed

affinity
passed

smart-update
passed

restore-to-encrypted-cluster
passed

one-pod
passed

operator-self-healing
failed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

demand-backup
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

upgrade-consistency
passed

pitr
passed

demand-backup-encrypted-with-tls
passed

scheduled-backup
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/829/commits/9581905299cb8c30edc622b9fb8704cf8f5d332d
image: perconalab/percona-xtradb-cluster-operator:PR-829-95819052

Test name
Status

recreate
passed

haproxy
failed

restore-to-encrypted-cluster
passed

demand-backup
passed

pitr
passed

demand-backup-encrypted-with-tls
passed

scheduled-backup
passed

storage
passed

self-healing
passed

self-healing-advanced
passed

operator-self-healing
passed

upgrade-haproxy
passed

big-data
passed

scaling
passed

scaling-proxysql
failed

init-deploy
passed

limits
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

security-context
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/829/commits/9581905299cb8c30edc622b9fb8704cf8f5d332d
image: perconalab/percona-xtradb-cluster-operator:PR-829-95819052

Test name
Status

upgrade-haproxy
passed

big-data
passed

recreate
passed

haproxy
failed

restore-to-encrypted-cluster
passed

demand-backup
passed

pitr
passed

demand-backup-encrypted-with-tls
passed

scheduled-backup
passed

scaling
passed

scaling-proxysql
passed

storage
passed

self-healing
passed

self-healing-advanced
passed

operator-self-healing
passed

init-deploy
passed

limits
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

upgrade-proxysql
passed

security-context
passed

smart-update
passed

upgrade-consistency
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/829/commits/9581905299cb8c30edc622b9fb8704cf8f5d332d
image: perconalab/percona-xtradb-cluster-operator:PR-829-95819052

Test name
Status

recreate
passed

restore-to-encrypted-cluster
passed

demand-backup
passed

pitr
passed

demand-backup-encrypted-with-tls
passed

scheduled-backup
passed

scaling
passed

scaling-proxysql
passed

security-context
passed

storage
passed

upgrade-haproxy
passed

self-healing
passed

self-healing-advanced
passed

operator-self-healing
passed

big-data
passed

haproxy
failed

init-deploy
passed

limits
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/829/commits/9581905299cb8c30edc622b9fb8704cf8f5d332d
image: perconalab/percona-xtradb-cluster-operator:PR-829-95819052

Test name
Status

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/829/commits/a40c063f6e06d22aa4a42c0d0beecaf485cdccf9
image: perconalab/percona-xtradb-cluster-operator:PR-829-a40c063f

Test name
Status

big-data
passed

storage
passed

upgrade-haproxy
passed

haproxy
failed

scaling
passed

recreate
passed

init-deploy
failed

scaling-proxysql
passed

limits
passed

self-healing
failed

restore-to-encrypted-cluster
passed

monitoring-2-0
passed

upgrade-proxysql
passed

affinity
passed

one-pod
passed

demand-backup
passed

auto-tuning
passed

smart-update
failed

self-healing-advanced
passed

proxysql-sidecar-res-limits
passed

users
failed

operator-self-healing
passed

pitr
passed

security-context
passed

demand-backup-encrypted-with-tls
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

scheduled-backup
passed

validation-hook
passed

upgrade-consistency
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/829/commits/a40c063f6e06d22aa4a42c0d0beecaf485cdccf9
image: perconalab/percona-xtradb-cluster-operator:PR-829-a40c063f

Test name
Status

big-data
passed

scaling
passed

recreate
passed

haproxy
passed

storage
passed

upgrade-haproxy
passed

self-healing
failed

init-deploy
passed

restore-to-encrypted-cluster
passed

scaling-proxysql
failed

upgrade-proxysql
passed

limits
passed

monitoring-2-0
passed

demand-backup
passed

security-context
passed

smart-update
failed

affinity
passed

self-healing-advanced
passed

one-pod
passed

auto-tuning
passed

operator-self-healing
passed

proxysql-sidecar-res-limits
passed

pitr
passed

users
passed

demand-backup-encrypted-with-tls
passed

upgrade-consistency
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

scheduled-backup
failed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/829/commits/a86e55cd832bbf4002895daefc89a630e3218247
image: perconalab/percona-xtradb-cluster-operator:PR-829-a86e55cd


MyAP does not appear after successful flash

I used this a few months ago on a device with no issue. Recently revisited after receiving new Wemos D1's and flashed successfully via esptool. However after reset, myAP never appears. I attempted to add as a possible hidden network but this does not work, either. Any idea what might have changed?

Did you try to write the init sector?

Thank you that seems to have been it, I was sure I had done it earlier in a separate step in preparation but this appears not to have been the case. Much appreciated, and added to my notes!

I have the same issue: MyAP does not appear after flashing (also no serial communication through arduino IDE seems to occur). I've tried flashing the init file, the other two .bin files in a few variant settings (see screenshot for what I believe should be the correct settings) . When I reboot the wemos D1 after flashing, the led at the wifi chip seems to blink twice and then it's out.

Try DIO mode.
Am 28. August 2018 21:50:44 schrieb goosst<EMAIL_ADDRESS>
I have the same issue: MyAP does not appear after flashing (also no serial
communication through arduino IDE seems to occur). I've tried flashing the
init file, the other two .bin files in a few variant settings (see
screenshot for what I believe should be the correct settings) . When I
reboot the wemos D1 after flashing, the led at the wifi chip seems to blink
twice and then it's out.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.


[Backport v2.7] [BUG] ACI-CNI variables not configurable using Rancher server UI

Backport of https://github.com/rancher/rancher/issues/44980 to 2.7.x line of releases.

Validated that the ACI values do not disappear after provisioning the rke1 cluster on 2.7..13-rc4


Corrected the working_dir parameter...

...in the cloudshell/open URL

Thanks for the PR! 🚀✅ Lint checks have passed.


Result unwrap

Implement Result.unwrap(). Requires

if let (https://github.com/FuelLabs/sway/issues/624)
Control flow end on panic (https://github.com/FuelLabs/sway/issues/308)

I refactored panic into its own library, since otherwise chain::auth depends on result, which depends on chain::panic, which would be a circular dependency.

Stale, will make a new branch


6.1.1

Extracting pro2-ui's storagePolyfill lib

Will there be a PR to remove this from pro2-ui and replace it with this version?

yeap @kaicataldo making another pr for it now


Spacing in closures

Many of my Travis-tested repos just started failing due to the merge of #417. I see that WPCS now wants:
add_filter( 'excerpt_length', function() {
	return 40;
} );

to be:
add_filter( 'excerpt_length', function () {
	return 40;
} );

I see no mention of this in the WordPress Coding Standards. Is there a secondary guide that WPCS is using to make decisions like this? If it's a matter of opinion, I'd love to see the discussion so I can better understand why this format was chosen. I personally think function() { makes more, as it follows the non-closure function standard more closely, where the parens are adjacent to the function name like function foo() {. If it were just a matter of opinion, I would hide it in my ruleset, though it doesn't look like this can be ignored without also affecting other control structures (please correct me if I'm wrong) covered by WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceAfterStructureOpen and WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceBeforeOpenParenthesis.
Thanks!

Yes, this is ouch. I was just about to file the same issue.

I raised this at https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/417#discussion_r35848698 . In this case, I can only assume that @JDGrimes defaulted (or let the Squiz sniff default) to PSR-2, which does have spaces: http://www.php-fig.org/psr/psr-2/#6-closures
Anonymous functions / closures tend not to be found in Core, so things like this, namespaces and other non-core goodies are something that I've raised with @DrewAPicture so that we can get it clarified in the handbooks regardless of whether WP core is using it.
Drew, can this particular point be raised sooner with the Core team, so we can amend as necessary? FWIW, no-space (like WP CS JS uses) is my slight preference. The only occurrence I could see in core was in tests/phpunit/actions/closures where no-space is used twice. If this is sufficiently indicative, then a change will be needed in WPCS.

I don't have a strong preference either way, but I tend to use the space. ("When in doubt, space it out!" :smiling_imp:) But we can make 0 the default, or even have it default to no preference until core makes a decision.

The fact that 100% of instances have no-space in core (OK, so 2 out of 2, in tests (!)), named function declarations don't have a space, and anonymous functions in JS don't (and there being some intent to have consistency between JS and PHP), I think I'd prefer no-space to be expected for function(), until a decision is made otherwise.

OK, should we release a 0.7.1 with that change?

@JDGrimes great idea :+1:

+1 for 0.7.1. I meant to suggest that in my previous comment.

Thanks for the quick turnaround!

I'm not happy with the reasoning behind this decision, as I would argue that it does not make sense at all.
A named function declaration would be function whatever( $item ) { [...] }.
In a closure, what gets omitted is the name of the function, so you'd remove the whatever above. This leaves you with function ( $item ) { [...] }.
You're NOT passing arguments to function, you're declaring an unnamed entity of type function with so and so arguments, just like you would have int 5 instead of int5...

@schlessera also pointed out that PHPStorm doesn't even have the Coding Style option (yet?) to remove that space.

Haha, apparently they consider this to be a bug in PHPStorm...
Oh well, nevertheless, I maintain my arguments, it is not a call to function with arguments, it is function <no-name-here>( $item ) {}...

@schlessera I agree, which is why I use the space. But this project doesn't control the standards that WordPress uses, we just implement sniffs for those standards. We need to be compatible with WordPress's declared standards by default, which is why this change was made. Those of us that disagree with WordPress's standards can try to get them changed. Until that happens, you can override the default in your phpcs.xml config:
<rule ref="WordPress.WhiteSpace.ControlStructureSpacing">
    <properties>
        ...
        <property name="spaces_before_closure_open_paren" value="1" />
    </properties>
</rule>

Yes, I agree with that, but in this case, WordPress does not have any standard to speak of. The two instances that @GaryJones managed to find can't possibly be considered conclusive.
So, why not just ignore this until Core has made a decision?
Yes, I'll consider overriding it in my projects. Thanks!

Yes, I agree with that, but in this case, WordPress does not have any standard to speak of. The two instances that @GaryJones managed to find can't possibly be considered conclusive.

No, those instances aren't conclusive. I would have favored turning off this check entirely by default, except that it is a part of the JavaScript standards, and a strong emphasis has been placed on parity between the PHP and JS standards in regards to whitespace.
I'm still not against ignoring this check by default until it is clarified in the PHP standards. However, that will mean that everyone will need to implement a custom configuration if they want to sniff for that. @GaryJones @westonruter any thoughts?

I think it should be ignored by default. It can be an opt-in for now, and once Core has a standard for closure formatting, we can enable the check.

As per 24 days ago:

I think I'd prefer no preference to be expected for function(), until a decision is made otherwise.

Those of us that disagree with WordPress's standards can try to get them changed
Unfortunately, there isn't a Slack channel or other method that can deal with this, without conversations getting lost in core chat.

@DrewAPicture has taken my suggestions (raised in Docs chat) about the PHP CS listed in the Handbooks to core devs, but really, the choosing of standards for use in the community should be a separate group. They'd (core and non-core devs) decide on the standards (with strong influence from historical use in core, obviously), the standards are written up via the Docs team, given to WPCS to be programatically testable, and then core, plugin and theme authors could use them. This lack of the initial CS group is just frustrating.

As per 24 days ago:
I think I'd prefer no preference to be expected for function(), until a decision is made otherwise.

Ah, I must have missed that somehow. I don't know why I defaulted it to 0. (But don't blame me, you're the one who merged it :smile:).

But don't blame me, you're the one who merged it

I deferred to your expert decision :-)


Gauge doesn't always fit container

All numeric values on a gauge should always be visible.

cc @r1ckbrown

@zoesteinkamp what's happening with this issue? has it stalled?

@zoesteinkamp As a part of this work can we confirm behavior on mobile.

I was showing the visualisation to a colleague today, and my gauge still doesn't fit

@TCL735 has a new gauge implementation in giraffe. Would be worthwhile to get that in as a part of this.

PR for the new Gauge: https://github.com/influxdata/giraffe/pull/192
After that is published, influxdb will need to consume it and update its own code to use the additional view options. With the additional view options, a Gauge's value can be moved, so that it will not overlap with the rest of the rendering.


Messages read from stream not being passed to application

Bug Report
Current Behavior
RedisLabs advised me to raise this.
When messages are read from a stream consumer group using XREADGROUP intermittently (when under load) messages are being read by Lettuce but not passed to the application (Spring Boot using a ReactiveRedisTemplate). The messages concerned then end up on the pending entries list permanently as the application does not acknowledge.
In the below you can see an example of a problem message with an ID of<PHONE_NUMBER>691-0 being received followed by application logging showing other messages being received. The below Lettuce log message mentioning that ID is the only time that ID appears in the log and the message is left in the PEL. I'll include the code receiving the messages from the template. The problem seems to occur in short bursts with multiple messages being affected that arrive at similar times.

Log output with io.lettuce set to trace
io.lettuce.core.protocol.RedisStateMachine Decoded LatencyMeteredCommand [type=XREADGROUP, output=StreamReadOutput [output=[], error='null'], commandType=io.lettuce.core.RedisPublisher$SubscriptionCommand], empty stack: false
io.lettuce.core.protocol.CommandHandler [channel=0x5a5fa311, /<IP_ADDRESS>:45020 -> redis/<IP_ADDRESS>:6379, chid=0x1d02] Buffer: G>
*2
$15
1605114758180-0
*2
$7
payload
$31
<SF_MSG>FHSF2739171228</SF_MSG>
*2
$15
1605114758182-0
*2
$7
payload
$31
<SF_MSG>Y1SF617C171227</SF_MSG>

..... SNIP .....

*2
$15
1605114758684-0
*2
$7
payload
$39
<CA_MSG>VCCA053805322B87171229</CA_MSG>
*2
$15
1605114758691-0
*2
$7
payload
$31
<SF_MSG>X0SF405C171229</SF_MSG>
*2
$15
1605114758699-0
*2
$7
payload
$31
<SF_MSG>MPSF69F8171229</SF_MSG>
*2
$15
1605114758700-0
*2
$7
payload
$39
<CA_MSG>DYCAB30553321S52171229</CA_MSG>
*2
$15
1605114758704-0
*2
$7
payload
$35
<CC_MSG>ZGCCGDXT1P51171229</CC_MSG>
*2
$15
1605114758706-0
*2
$7
payload
$39
<CA_MSG>Q1CA042004182W43171229</CA_MSG>
*2
$15
1605114758709-0
*2
$7
payload
$31
<SF_MSG>A2SF1A18171229</SF_MSG>

immediately followed by (same thread) to show the application is receiving some messages:
reactor.Flux.Lift.1 onNext(ObjectBackedRecord{recordId=1605114757650-0, value=<CA_MSG>MECA007400705H60171226</CA_MSG>})
reactor.Flux.Lift.1 onNext(ObjectBackedRecord{recordId=1605114757616-0, value=<SF_MSG>X0SF53EB171226</SF_MSG>})
reactor.Flux.Lift.1 onNext(ObjectBackedRecord{recordId=1605114757577-0, value=<CA_MSG>DRCA024902554E24171226</CA_MSG>})
reactor.Flux.Lift.1 onNext(ObjectBackedRecord{recordId=1605114757538-0, value=<SF_MSG>DYSF4F00171226</SF_MSG>})
reactor.Flux.Lift.1 onNext(ObjectBackedRecord{recordId=1605114757513-0, value=<SF_MSG>D4SF2C0D171226</SF_MSG>})

.... etc

Receiving code
Here's the code that reads from the template (log() added temporarily). The ReactiveRedisConnectionFactory is setup by Spring Boot without any special config, the poll timeout is 1000ms.

Receiving Code
    private Publisher<Message<ObjectRecord<String, String>>> createTrainDescriberUpdatesPublisher()
    {
        return createPublisher(redisProperties.getTrainDescriberUpdates())
                .log()
                .map(objectRecord -> MessageBuilder.withPayload(objectRecord).build());
    }

    private Flux<ObjectRecord<String, String>> createPublisher(final StreamProperties streamProperties)
    {
        return StreamReceiver.create(reactiveRedisConnectionFactory, StreamReceiver.StreamReceiverOptions.builder()
                .objectMapper(new TypedJsonHashMapper(String.class))
                .targetType(String.class)
                .pollTimeout(redisProperties.getPollTimeoutInMillis())
                .build())
                .receive(createConsumer(redisProperties.getTrainDescriberUpdates()),
                         createStreamOffset(redisProperties.getTrainDescriberUpdates()))
                .doOnError(error -> LOG.error("Error reading message", error))
                .onErrorResume(RedisExceptionHelper::isNoGroupError,
                        (Throwable throwable) -> logErrorAndCreateConsumerGroup(throwable, streamProperties));
    }

Expected behavior/code
All messages to be received by application
Environment

Lettuce version(s): [e.g. 5.3.4.RELEASE]
Redis version: [e.g. 6.0.9]

Possible Solution
Additional context
I appreciate this is probably not enough information to diagnose, let me know if there's anything else I can provide.

Can you reproduce the issue with using Lettuce only? We need to sort out first, whether it's a Lettuce or a Spring Data issue.

Hi,
Thanks for that, this was verified as a Spring Data issue relating to StreamReceiver, when using Lettuce directly the problem went away.
Thanks!

Can you file the same issue at https://jira.spring.io/browse/DATAREDIS as that's the issue tracker for Spring Data Redis?


README update for Interactable Objects (Stabilization branch)

Overview
Adding additional details about the scripts and prefabs in the scene Interactable Object Examples and Receiver
Changes
Updated README page -
https://github.com/cre8ivepark/MixedRealityToolkit-Unity/blob/Stabilization/Assets/HoloToolkit-Examples/UX/Readme/README_InteractableObjectExample.md

@keveleigh Thanks, Kurtis! Updated all broken links.


Create dataset loader for UIT-ViON

Dataloader name: uit-vion/uit-vion.py
DataCatalogue: http://seacrowd.github.io/seacrowd-catalogue/card.html?uit-vion

Dataset
uit-vion

Description
UIT-ViON (Vietnamese Online Newspaper) is a dataset collected from well-known online newspapers in Vietnamese. The UIT-ViON is an open-domain, large-scale, and high-quality dataset consisting of 260,000 textual data points annotated with 13 different categories for evaluating Vietnamese short text classification. The dataset is split into training, validation, and test sets, each containing 208000, 26000, and 26000 pieces of text, respectively.

Subsets
-

Languages
vie

Tasks
Text Classification

License
Unknown (unknown)

Homepage
https://github.com/kh4nh12/UIT-ViON-Dataset

HF URL
-

Paper URL
https://ebooks.iospress.nl/DOI/10.3233/FAIA210036

#self-assign


Added differentiation between menus for roles

- Specify menu config for anonymous, user, admin and superadmins
- Corrected missing $barmenu parameter in pullNav func in pagehead.php
This was removed in the "Bug Fixes" commit (a4574e59b26c42d2dcd36381c1e99540457bf065), was this by mistake or was there any reason? (Needed for the override example in page_3.php)

Hey Daniel, I'll review this and do my best to integrate it. I've made some
huge changes in the dev branch, but I'll see how I can best pull it in,
thanks man.
On Sun, Apr 8, 2018 at 9:08 AM, Daniel Falk<EMAIL_ADDRESS>wrote:

@daniel-falk https://github.com/daniel-falk requested your review on:
therecluse26/PHP-Login#175
https://github.com/therecluse26/PHP-Login/pull/175 Added
differentiation between menus for roles.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/therecluse26/PHP-Login/pull/175#event-1562596535, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH24AvWjFl7rdR5dA-yOOING7_2jY_Ptks5tmgvBgaJpZM4TLiIs
.


Make sure to strip binary when doing a release build

That saves around 20% of the binary size in my case (55MiB → 44MiB)

Since we already use panic = "abort" it should have no negative impact to strip the binary.
Have you tested cross-compilation with a stripped one too? I sometimes run into problems when doing this.

I just tested all 4 release builds and it looks good so far.
Thanks!


Late initialize deletion policy

What problem are you facing?
When spec.deletionPolicy is left empty, managed reconciler makes a defaulting decision and assumes it's Delete. While the decision is not surprising, when a user gets the resource, it's not immediate to them that the policy is Delete.

How could Crossplane help solve your problem?
We can have an Initializer, the mechanism we use for defaulting, that will assign Delete policy to spec.deletionPolicy if it's empty so that it's more apparent to the user. Additionally, we can possibly remove the defaulting logic from managed reconciler but I feel that we'd want to keep it to handle edge cases.

iirc v1 CRDs support defaulting in their schema - we might consider bumping to v1 CRDs in our next release so that we can remove some of the simpler defaulting initializers. Not sure if controller-runtime supports this yet though.
https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#defaulting

We should be able to default this now, similar to what we did in https://github.com/crossplane/crossplane-runtime/pull/252


Helm annotations fail on kubernetes dashboard

Rancher versions:
rancher/rancher:v2.1.0-rc3
Steps to Reproduce:
Setting annotations in the UI does not work and causes a failure of deployment. This seems to be on multiple charts, but I have been mainly testing on the kubernetes dashboard.

Results:
This error shows in the UI:
Failed to install app kubernetes-dashboard. Error: release kubernetes-dashboard failed: Ingress in version "v1beta1" cannot be handled as a Ingress: v1beta1.Ingress.ObjectMeta: v1.ObjectMeta.Annotations: ReadString: expects " or n, but found t, error found in #10 byte of ...|irect\"":true},"labe|..., bigger context ...|","\"nginx.ingress.kubernetes.io/ssl-redirect\"":true},"labels":{"app":"kubernetes-dashboard","chart|... ;

Can "work around" by hard coding in values.yaml

Close in favor of https://github.com/rancher/rancher/issues/13158
You will be able to add it in values.yaml

@nathankodilla I just figured this out myself, please try escaping the periods, e.g. iam\.amazonaws\.com/role: "role". This is working for me for metallb service.

@LennardWesterveld
I have the exact same issue on Rancher 2.2.0-rc3 with Jenkins Helm package. Escaping the period doesn't work.
Did you find a solution?


fix: increase stability in resources/support-zip.sh

Description
This pull request changes the following:

increase stability in resources/support-zip.sh

Related Issues

Closes #680

:tada: This PR is included in version 0.31.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.31.1 :tada:
The release is available on:

npm package (@release-0.31.x dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


mac-41 lost external connection phone device.

Type of Request
bug
Infrastructure Environment
LUCI, Github, Cocoon scheduler, Autosubmit, etc...
What is happening?
mac-41 lost external connection phone device.

Steps to reproduce
Step 1:
Step 2:
..
Step n:
Expected results
I expect to see X when Y is finished.

Rebooting machine to restore connection.


refactor: remove pkg/extensions/search/common and move the code to th…

…e appropriate packages

What type of PR is this?

Which issue does this PR fix:
#1342
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Coverage change is unrelated to this PR (it is dedupe-related).


Support for basic and digest auth in core.http action

Currently there is no way to pass credentials (username and password) either in the header or in the command instead of hard coded Authorization value?
Sample cmd:  current supported version
st2 run core.http url="https://downloads.stackstorm.net" headers='{"Authorization": "Basic C2F0eWIxMg=="}'
In curl it is possible to pass credentials:
curl -X GET -u 'username:password' http://server:51527/api/v1/processes
Same like curl, if core.http supports that feature, It would be great
Reported by: Satyababu in slack

Thanks for the report / feature request.
I first thought we support it, but I glanced over code and it looks like we don't. We do support auth parameter, but the value can only be a string so I believe this won't work for traditional username and password basic / digest authentication.
@manasdk et al, please correct me if I'm wrong.

Merged to st2 with commit 71b7359bd014a789de325104f7213ab85ddba633.


[newrelic-k8s-metrics-adapter] Add HostNetwork as parameter for metrics-adapter deployment

Is this a new chart
Nope
What this PR does / why we need it:
Add option to enable HostNetwork for deployment.
Which issue this PR fixes
I haven't found issue for this scenario.
Special notes for your reviewer:
We are using the EKS cluster with Calico on top of it. Without the hostNetwork set to true, metrics adapter receive IP address from Calico pool and Kubernetes Apiserver is failing on DiscoveryCheck on the apiservice.
Checklist

[X] Chart Version bumped
[X] Variables are documented in the README.md
[X] Title of the PR starts with chart name (e.g. [mychartname])

Awesome! Thanks :)


Support central package management

Currently, does not support the  central package management feature https://docs.microsoft.com/en-us/nuget/consume-packages/central-package-management
When I try to upgrade my packages, it did not update the package version defined in Directory.Packages.props, but updated the package in the project with a new version

My project is here: https://github.com/WeihanLi/dotnet-httpie/tree/1898489d23a36b0764961e02e5a14929895fcbef

This should be resolved once we get #243 merged and releases 🤞

Thanks @slang25 , closing this since it's duplicate of #6


Functionality for parallel qml.expval(H) execution needed

In the VQE with parallel QPUs on Rigetti Forest demo, deprecated qml.ExpvalCost functionality is used that makes use of internally parallelizing the executions with dask. Currently, something similar is not available with qml.expval(H), and, more importantly, not possible manually with user-facing functions and dask.
@antalszava and I concluded that there is no point to re-write the ExpvalCost logic with non-user-facing functions now, but we should instead find possibilities to provide parallelization possibilities with qml.expval(H) in the near future.
For now, we leave the demo as is with a warning about the deprecation, see https://github.com/PennyLaneAI/qml/pull/506

@Qottmann I imagine the closest approach would be to do something like:
@qml.qnode(dev)
def circuit(x, h):
    qml.RX(x, wires=0)
    qml.RY(x * 2, wires=0)
    return qml.expval(h)

H = qml.PauliZ(0) + qml.PauliX(1)

results = [dask.delayed(circuit)(0.2, h) for h in H.ops]
results = dask.compute(*results, scheduler="threads") @ H.coeffs

Would this be sufficient in the tutorial? It avoids ExpvalCost, while making the Dask usage explicit.

In principle this would work, but do you see a way to incorporate the measurement optimization as well? Already in this example it is executing 2 expvals whereas only 1 is necessary. In many Hamiltonians you have big commuting Pauli groups, so executing all individual expvals in parallel is most likely slower (and wastes unnecessary hardware resources) than just default execution:
Zs = [qml.PauliZ(i) for i in range(10)]
Xs = [qml.PauliZ(i) for i in range(10)]
H = qml.Hamiltonian(coeffs = np.arange(20), observables = Zs + Xs, grouping_type="qwc")

results = [dask.delayed(circuit)(0.2, h) for h in H.ops]

>>> %timeit result = H.coeffs @ dask.compute(*results, scheduler="threads")
73.9 ms ± 5.17 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)

>>> %timeit circuit(0.2, H)
11.2 ms ± 289 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

As far as I understand it this tutorial was intended for parallel hardware execution so I would try to make sure to incorporate measurement optimization.

Oops! Yes, perfect @Qottmann :)

I created a PR for this here https://github.com/PennyLaneAI/qml/pull/510


Receiving VkImage as data.

Hello! I want to draw the depth buffer as a texture.
I'm using the vkCmdCopyImageToBuffer function to get data.
I have some questions:

Valid Usage - srcImage must have a sample count equal to VK_SAMPLE_COUNT_1_BIT.
Is it possible to customize image transitions when using MSAA? If yes, then how?
Are there other options for receiving VkImage as data?
When is the best time to receive VkImage? During a render pass or outside of it?

Please note that this place is for asking issues related to my samples, not general questions. For those use e.g. the Vulkan reddit.


Scrolling issues be gone

So... After weeks of studying the issue I've finally been able to come up with an all-around solution to our several scrolling issues. Closes #7088 #7271 #7088
Makes https://github.com/FreeCodeCamp/FreeCodeCamp/pull/7276 unnecessary.
Note: While using iOS devices, it temporarily redisables scrolling for the wiki on the sidecar, but they can always check the detached version. -> This will be corrected as we fix the wiki generator.
Come at me, evil bots!

I think we should tie this to the wiki-generator being fixed.  No point in inducing new bugs.

No new bug induced, as it was never solved to begin with.
This solves multiple issues, while putting the ipad's on hold.

I'd QA this but I've never been able to reproduce it.

Lol I know what you mean, @QuincyLarson. We're blissed like that

This looks good to me. The scrolling isn't perfect on the wiki in Safari, but it works well enough. Tested in Firefox, Chrome, Safari on OSX. Since this is a Safari-specific issue, I think it's safe to say this fixes the original issue.
I wish all of these browsers just handled scrolling contextually (based on cursor position) like Chrome does.


ns = data.plt.interact_spatial_scatter error

Hello, I have loaded a gem format file and used ins = data.plt.interact_spatial_scatter(width=800, height=800, poly_select=True) ins.show() to split the data, but it cannot be opened properly. Do you have any solution? My version is the latest.

Didn't the figure be displayed on broswer?


[Feature Request] Move theme Scss variables to CSS variables

Existing Component
Yes
Component Name
All components inheriting styles from the theme.
Description
It might be a good idea to move the Scss variables over to CSS variables.
We have a use case where we're using Element-UI as the base for an internal component library. We allow custom theming via the options passed to Vue.use(OurLibrary, ...), and the options passed in are then applied to CSS variables with style.setProperty.
Currently to be able to pass this theme onto any Element components, we're adding custom classnames to the relevant components, and then manually overriding the styles using the CSS variable. However this is getting painful as our library grows, as we have to check the full stylesheets of each Element UI component as we use them. As well as verifying there have been no classname changes each time we update the dependency.
If your theme variables were defined in CSS variables, it would mean any "level" could easily adjust them. Be that in:

A library consuming Element UI
An application consuming a library that consumes Element UI
Anything further up the stack, I think you get the gist...

I'd be willing to lend a hand on this 🙂

I also need this feature and would be willing to lend a hand.

Any news on this one?

This feature would be awesome!

please do this anybody, ASAP!


Request: Fresco implementation

First of all thanks for this beautiful library. But I observed that Picasso library is way slower and less efficient than Fresco when loading, displaying, and caching images. Can you please add Fresco as an alternative to Picasso?

Maybe this is a good suggestion. what do you think about it @daimajia ?

supported would be great :)

+1

great idea

Is the problem solved？

Well i forked this project and implemented frescolib. You can find the code here https://github.com/chan32167/AndroidImageSlider

also fixed memory leaks

You can check this library https://github.com/OpenSooq/Pluto
it has the ability to have full control over your views and layout
and not depending on  any image loading library


Add todo list project files to best-practice

In this pull request I: 😄

Added files from my to-do list project.

Congratulations Valentine, your project is outstanding, but as a part of requirements, especially, Best practices (HTML, CSS and JS), you can think of a way to make your project looks more organised and thus scalable in the future 👍 🥇
Please try to see each comment for more information 💪

Thank you for the feedback.. They are well appreciated.


Add header types for useCollapsibleOptions

Add StackHeaderProps to header field in useCollapsibleOptions.

Hey, Thanks. @ThukuWakogi Could you check the CI? It seems to be just a lint issue.

You can just run yarn prettier.

While working on it, I've noticed I can make types more navigationOptions more complete but I'm running into issues. I will come back once I have figured out the issues.
I will close this PR for now.


feat(new-docs): Start documenting the Page class

This PR starts exploring the Page class and how to best document it. It explores how best to document events in the system, and I think pulling them out into an enum is the best solution here. It lets us end up with a page of docs that explicitly lists all the events the page class can ever emit.

Nit for the commit message: feat(new-docs): → docs(new):. (feat is for new user-facing features/APIs.)


add primary-font to experience

overview
keeping font consistent with the rest of the experience section. it was defaulting to Lora (the default body font) but we are using Alata (the primary font) for the rest of the "experience" section.
questions
ideally, we'd want to have a strict style guide for the website where it's explicit what "primary" means (is it just meant for headers? for body? just for the hero? etc) and styles are used consistently throughout the site - or, just use all the same font everywhere, which also is a good alternative. current setup is a bit confusing (primary-font is used in the header, post titles, hero, menu, and experience body)
current state of example experience section

job section font before:

job section font after:

Thanks ❤


Add missing SeqNo and PrimaryTerm fields in SearchHit

Description
Adds the missing fields SeqNo and PrimaryTerm to the SearchHit struct.  These fields are optionally returned in the response as documented here with the seq_no_primary_term param: https://opensearch.org/docs/latest/api-reference/search/
Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This needs a rebase.
The proposal in #284 might be of interest. Also appreciate if you could take this opportunity to check https://github.com/opensearch-project/opensearch-api-specification for these fields and maybe add a test there.

Thanks! This needs a rebase.
The proposal in #284 might be of interest. Also appreciate if you could take this opportunity to check https://github.com/opensearch-project/opensearch-api-specification for these fields and maybe add a test there.

Thank you, I checked the spec and I see the fields under response for https://opensearch-project.github.io/opensearch-api-specification/#/default/search.0. Could you point me to where I could add a test for it in https://github.com/opensearch-project/opensearch-api-specification?

I think https://github.com/opensearch-project/opensearch-api-specification/blob/73d552477f8f006f5ff49f451494d150b8378b18/tests/_core/search.yaml would be a logical place. As long as these are mentioned somewhere.


Regarding #461, are there plans to integrate unsupervised methods into keras?

I know that there is the AutoEncoder layer, however important concepts such as DBNs + RBMs are not implemented. Is keras intended to be a framework for purely supervised learning methods? If not, I could propose working on integrating RBMs, Denoising Autoencoders with tied weights etc. into keras.
I would propose to implement 'transpose' operations for each layer, such that a layer can be used "in both directions", i.e. in a manner similar to

Dense with (W, bias) -> Dense.T with (W.T, bias)

or

Conv2d with (W, bias) -> Conv2D.T with (flipped(W), bias)

Another option would be to define special layers such as a TiedDense (that's how it is currently called in my code), subclassing the Dense layer class like
class TiedDense(Dense):
    def __init__(self, transposed_layer=None, **kwargs):
        self.transposed_layer = transposed_layer
        # ...

    def get_output(self, train=False):
        X = self.get_input(train)
        output = self.activation(T.dot(X, self.transposed_layer.W.T) + self.b)
        return output

The obvious downside of this solution is that one would have to implement such a class separately for every layer type.
Any opinions on this?

I've implemented unsupervised autoencoders with Keras, you just have to use input as desired or something like that. For noise things like variational autoencoders I wrote my own regularizers to add the noise. There is also one person saying he will work on generative adversarial networks.
Beyond that I think there's been a lot of interest in unsupervised learning.

I also wrote some examples of sparse coding in Seya. Yeah, that all that I heard about unsup around here.

This issue is a little old but I'll add my support for this.  An alternative to the OPs suggestion would be the ability to pass an expression in as an initial parameter value.  Thus, one could pass W from one Dense layer as W.T when initializing another.  Instead of adding a new parameter that gets updated via the gradient during learning, the gradient would continue to flow backward through the expression to the original parameter(s).
I've also ended up with something similar to your TiedDense.  The above would make a separate class unnecessary.


Reenforce code synchronization

For #1701
Force syncing the model in memory whenever

Saving (native and old webview)
Executing a cell (old webview only as VS code sends this value).

Comments in 1701 indicate saving seems to fail for VS code notebooks too.
Implemented this for old webviews by:

New messages to get code from cell(s) (not entire cell, took too long for large notebooks)
New messages to return code from cell(s)
Send these messages and wait for response before executing a cell or saving

Implemented this for native editor by:

Reasking for the source from the VS code cell documents when saving

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[x] Has a news entry file (remember to thank yourself!).
[x] Appropriate comments and documentation strings in the code.
[x] Has sufficient logging.
[x] Has telemetry for enhancements.
[x] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

With regards to the bug in native notebooks.
It is not necessary
Today when ever we generate the JSON, we get the raw cell code from the cell text document. I.e. the ICell is not used. We dropped usage of ICell in native editor. It is only required for initial load (couldn't remove ICell completely as we use that interface for reading & parsing ipynb files).
If it isn't working for a user I'd rather try to get to the bottom of that bug, and fix that. In this case it looks like the VSC API isn't returning the correct text, hence I'd say we should report this to VS Code.

With regards to the bug in native notebooks.
It is not necessary
Today when ever we generate the JSON, we get the raw cell code from the cell text document. I.e. the ICell is not used. We dropped usage of ICell in native editor. It is only required for initial load (couldn't remove ICell completely as we use that interface for reading & parsing ipynb files).
If it isn't working for a user I'd rather try to get to the bottom of that bug, and fix that. In this case it looks like the VSC API isn't returning the correct text, hence I'd say we should report this to VS Code.

Well I couldn't repro it myself. I thought since it was using the model it would be reading the cells from the code we loaded but you're right it eventually calls getJupyterCells. That should be using the notebook document unless the document isn't there? Doesn't seem likely though.

I think for now I'll leave the sync all cells method. It doesn't do much of anything in the native notebook case.

I think for now I'll leave the sync all cells method. It doesn't do much of anything in the native notebook case.

Actually it could be unnecessarily recreating the cell array. You delete it in the trust functions.


WIP: add verify-attached-builds command

This command is to detect non-shipping ("orphan") packages in images.
Currently blocked but I'd like to post this PR first.
See discussion at
https://coreos.slack.com/archives/GDBRP5YJH/p1607612241054200 and JIRA
https://projects.engineering.redhat.com/browse/RHELWF-2572 for tracking.

Codecov Report

Merging #173 (040b6d3) into master (4772e2e) will increase coverage by 21.55%.
The diff coverage is 1.19%.

@@             Coverage Diff             @@
##           master     #173       +/-   ##
===========================================
+ Coverage        0   21.55%   +21.55%
===========================================
  Files           0       46       +46
  Lines           0     3754     +3754
  Branches        0      737      +737
===========================================
+ Hits            0      809      +809
- Misses          0     2920     +2920
- Partials        0       25       +25

Impacted Files
Coverage Δ

elliottlib/cli/__main__.py
0.00% <0.00%> (ø)

elliottlib/cli/verify_attached_builds.py
0.00% <0.00%> (ø)

elliottlib/errata_async.py
0.00% <0.00%> (ø)

elliottlib/brew.py
54.59% <10.52%> (ø)

elliottlib/cli/tarball_sources_cli.py
0.00% <0.00%> (ø)

elliottlib/cli/change_state_cli.py
0.00% <0.00%> (ø)

elliottlib/pushd.py
100.00% <0.00%> (ø)

elliottlib/gitdata.py
18.78% <0.00%> (ø)

elliottlib/cli/rpmdiff_cli.py
0.00% <0.00%> (ø)

elliottlib/exceptions.py
100.00% <0.00%> (ø)

... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4772e2e...040b6d3. Read the comment docs.

Codecov Report

Merging #173 (040b6d3) into master (4772e2e) will increase coverage by 21.55%.
The diff coverage is 1.19%.

@@             Coverage Diff             @@
##           master     #173       +/-   ##
===========================================
+ Coverage        0   21.55%   +21.55%
===========================================
  Files           0       46       +46
  Lines           0     3754     +3754
  Branches        0      737      +737
===========================================
+ Hits            0      809      +809
- Misses          0     2920     +2920
- Partials        0       25       +25

Impacted Files
Coverage Δ

elliottlib/cli/__main__.py
0.00% <0.00%> (ø)

elliottlib/cli/verify_attached_builds.py
0.00% <0.00%> (ø)

elliottlib/errata_async.py
0.00% <0.00%> (ø)

elliottlib/brew.py
54.59% <10.52%> (ø)

elliottlib/cli/tarball_sources_cli.py
0.00% <0.00%> (ø)

elliottlib/cli/change_state_cli.py
0.00% <0.00%> (ø)

elliottlib/pushd.py
100.00% <0.00%> (ø)

elliottlib/gitdata.py
18.78% <0.00%> (ø)

elliottlib/cli/rpmdiff_cli.py
0.00% <0.00%> (ø)

elliottlib/exceptions.py
100.00% <0.00%> (ø)

... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4772e2e...040b6d3. Read the comment docs.


Bitbucket support

Add bitbucket support.

since bitbucket's api does not support commit, this can not be done


hassio_audio proper log handling, less spamming

Problem
The hassio_audio container continuously outputs info and debug data, that puts unnecessary load on downstream systems and contribute to reducing the lifespan of SD's / SSD's.
It is not possible (to my knowledge) to set the log level for hassio_audio. It does not seem to support the Home Assistant standard that allows the log level to be set in the Logger Integration in configuration.yaml, as explained in the Logger documentation.
Request

Remove the -vvv PulseAudio run parameter, to make the output less verbose. Or make it configurable.
Add a timestamp to the PulseAudio messages --log-time[=BOOL]
Set the correct level for stdout / stderr messages raised to journald. Currently ALL hassio_audio messages are raised as level 3 (i.e. error), whether "D" (debug), "I" (info), or "E" (error).
Support the Logger directive to allow the user to set the output log level, e.g. critical / error / info / debug.
Maybe this can be achieved using the "--log-level" PulseAudio command parameter?

Additional Information
Home Assistant logger filter setting has no effect on hassio_audio
Current logger settings in configuration.yaml.
logger:
  default: critical
  logs:
    homeassistant.core: fatal

Even with the log settings above, below are typical "D" (debug) and "I" (info) messages output by hassio_audio, retrieved from the Docker logs for the container. The "critical" default setting has no effect on the filtering of messages from hassio_audio. Or is there an (undocumented) setting that actually works to filter only real error messages?
docker logs audio_hassio
...
I: [pulseaudio] client.c: Created 14 "Native client (UNIX socket client)"
I: [pulseaudio] protocol-native.c: Client authenticated anonymously.
D: [pulseaudio] protocol-native.c: Protocol version: remote 34, local 34
D: [pulseaudio] protocol-native.c: SHM possible: no
D: [pulseaudio] protocol-native.c: Negotiated SHM: no
D: [pulseaudio] protocol-native.c: Disabling srbchannel, reason: No SHM support
I: [pulseaudio] client.c: Freed 14 "supervisor"
I: [pulseaudio] protocol-native.c: Connection died.
...

hassio_audio raises ALL messages as errors, regardless of their real level.
Below are the same hassio_audio log records, this time retrieved using journalctl.
NOTE:

In the journalctl command below only errors were retrieved (parameter -p err).
The messages returned from journalctl are information ("I") and debug ("D") level messages, but with an error log level.

journalctl CONTAINER_NAME=hassio_audio -p err

-- Logs begin at Mon 2021-03-08 22:43:29 CET, end at Sat 2021-03-13 12:44:51 CET. --
...
Mar 10 00:05:12 RPiHome<PHONE_NUMBER>e7[584]: I: [pulseaudio] client.c: Created 14 "Native client (UNIX socket client)"
Mar 10 00:05:12 RPiHome<PHONE_NUMBER>e7[584]: I: [pulseaudio] protocol-native.c: Client authenticated anonymously.
Mar 10 00:05:12 RPiHome<PHONE_NUMBER>e7[584]: D: [pulseaudio] protocol-native.c: Protocol version: remote 34, local 34
Mar 10 00:05:12 RPiHome<PHONE_NUMBER>e7[584]: D: [pulseaudio] protocol-native.c: SHM possible: no
Mar 10 00:05:12 RPiHome<PHONE_NUMBER>e7[584]: D: [pulseaudio] protocol-native.c: Negotiated SHM: no
Mar 10 00:05:12 RPiHome<PHONE_NUMBER>e7[584]: D: [pulseaudio] protocol-native.c: Disabling srbchannel, reason: No SHM support
Mar 10 00:05:12 RPiHome<PHONE_NUMBER>e7[584]: I: [pulseaudio] client.c: Freed 14 "supervisor"
Mar 10 00:05:12 RPiHome<PHONE_NUMBER>e7[584]: I: [pulseaudio] protocol-native.c: Connection died.
...

And the first record from the above output, now shown verbose to confirm PRIORITY=3:
journalctl CONTAINER_NAME=hassio_audio --since "2021-03-10 00:05:00" --until "2021-03-10 00:06:00" -o verbose

-- Logs begin at Mon 2021-03-08 22:43:29 CET, end at Sat 2021-03-13 12:44:51 CET. --
Wed 2021-03-10 00:05:12.194229 CET [s=e0ae8b76d4cd495caeca4d33ba3702ea;i=2ba;b=285f795042f04f8588bbdd5ce295afd7;m=15418de86b;t=5bd22952310d4;x=37ce5b2c89d83e4]
    _BOOT_ID=285f795042f04f8588bbdd5ce295afd7
    _MACHINE_ID=be042b18af4b495ca4957bfef9e53bfd
    _HOSTNAME=RPiHome
    _UID=0
    _GID=0
    _SYSTEMD_SLICE=system.slice
    _TRANSPORT=journal
    _CAP_EFFECTIVE=1ffffffffff
    PRIORITY=3
    _PID=584
    _COMM=dockerd
    _EXE=/usr/bin/dockerd
    _CMDLINE=/usr/bin/dockerd -H fd:// --containerd=/run/containerd/containerd.sock
    _SYSTEMD_CGROUP=/system.slice/docker.service
    _SYSTEMD_UNIT=docker.service
    _SYSTEMD_INVOCATION_ID=02eb6c5d4ad24576bd16a7252e7c8803
    CONTAINER_NAME=hassio_audio
    CONTAINER_TAG=5941937722e7
    IMAGE_NAME=homeassistant/armv7-hassio-audio:2021.02.1
    SYSLOG_IDENTIFIER=5941937722e7
    CONTAINER_ID=5941937722e7
    CONTAINER_ID_FULL=5941937722e730a3f0045de4a539addcca6209c9ef10d227499d2d843bebe0e0
    MESSAGE=I: [pulseaudio] client.c: Created 14 "Native client (UNIX socket client)"
    _SOURCE_REALTIME_TIMESTAMP=1615331112194229
...

Regarding request (3): "Set the correct log level for stdout / stderr messages raised to journald. Currently ALL hassio_audio messages are raised as level 3 (i.e. error), whether "D" (debug), "I" (info), or "E" (error)."
I just want to confirm that Docker does support logging stdout and stderr](https://docs.docker.com/config/containers/logging/) as different log levels in journald.

The stdout stream is logged with priority 6, which is the LINUX level for "information".
The stderr stream is logged with priority 3, which is the LINUX level for "error".

Do the following quick test to verify that Docker will assign different priorities to STDOUT and STDERR messages:

Connect and run a Bash shell in the hassio_audio container.
Output test messages to both stdout and stderr (using the stream of the process running as PID 1).
Confirm the priority of the two messages that were logged in journal, using journalctl.

# Connect as Bash, then send messages to both stderr and stdout.

docker exec -it hassio_audio bash
bash-5.1#
bash-5.1# echo "TESTING STDERR" >> /proc/1/fd/2
bash-5.1# echo "TESTING STDOUT" >> /proc/1/fd/1
bash-5.1#
bash-5.1# exit

---

# Search journalctl for all hassio_audio messages logged in the past hour, containing "TESTING" in the message.

journalctl CONTAINER_NAME=hassio_audio -S -1h | grep "TESTING"

---

# Search journalctl for all hassio_audio messages logged with PRIORITY 6 (i.e. log level "information"):
# (The "TESTING STDOUT" message should be in the output.)

journalctl CONTAINER_NAME=hassio_audio PRIORITY=6

---

# Verify the priority of the two "TESTING.." messages in the log detail.

journalctl CONTAINER_NAME=hassio_audio -S -1h  -o verbose

please, can you do something about it? This thing is logging like crazy and I don't even have audio enabled on pi.

@luka6000  As a workaround you could consider to implement this shell script. Or you can borrow the idea/adjust the shell script and do something yourself.
The key thing that it does is to change the PulseAudio run parameters inside the hassio_pulseaudio container after the container (re)started, then kill PulseAudio. PulseAudio will automatically be restarted, with the new parameters, and now only log error level messages (including a log timestamp).
These are the Docker commands executed from the host OS:
# update the PulseAudio parameters in the run file in the hassio_audio container:
docker exec -i hassio_audio sed -i 's/-vvv/--log-level=0 --log-time=true/' /run/s6/services/pulseaudio/run

# stop PulseAudio in the hassio_audio container:
docker exec -i hassio_audio pkill pulseaudio

I just got a disk space warning that I chased down to 4GB of exactly this. I'm surprised that this issue has been open for so long.

Is there a way to disable this pugin entirely? My Home Assistant is running on a headless machine that does no audio processing.
I don't think I need to label the graph to show the point at which the plugin started to cause issues with log size

Added pull request #85


Omnisharp Emacs LSP Error

Hello
Not sure how to go about debugging this, but this error is frequently seen on the eamcs LSP c-sharp mode on
Windows 10 64bit
Using Omnisharp 1.34.9
LSP :: Internal Error - System.NullReferenceException: Object reference not set to an instance of an object.

   at OmniSharp.LanguageServerProtocol.Handlers.OmniSharpSignatureHelpHandler.<Handle>d__3.MoveNext() in D:\a\1\s\src\OmniSharp.LanguageServerProtocol\Handlers\OmniSharpSignatureHelpHandler.cs:line 45

--- End of stack trace from previous location where exception was thrown ---

   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()

   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

   at OmniSharp.Extensions.LanguageServer.Server.Pipelines.ResolveCommandPipeline`2.<Handle>d__5.MoveNext()

--- End of stack trace from previous location where exception was thrown ---

   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()

   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

   at OmniSharp.Extensions.JsonRpc.RequestRouterBase\`1.<RouteRequest>d__6.MoveNext()

Same for me, but on Linux.

Hmm, I know the issue and I'll have to check a few things as to where to make the change.  I'll look at this tonight though for sure.

I just took a look, I'll get a fix out to the lsp lib and upgrade here and I'll drop a new release either tonight or tomorrow sometime.

Thanks!

Same issue here, any news on this @david-driscoll?

Has there been any progress on this? I'm having this issue as well. Everything still works, as far as I can tell, but the error is annoying.

Hey @joshbarth
I might be able to investigate the issue. Do you have a minimal repo with which to reproduce it?


Side menu back animation done on main view

While using nested views in side menus, back animation don't be done on side menu but on main view.
Unusual configuration, I take so log to keep it working.
Thanks to this pen.
http://codepen.io/anon/pen/iLqka
Maybe it should be an AngularJS issue.

Greetings @Takkuz!
Sorry but this issue may no longer be applicable to recent versions of Ionic.
If you are still experiencing this issue, please feel free to reopen and provide the following information so that I may assist you.

Can you provide a detailed description of this issue?
How would a robot go about replicating this issue?
What platform does this happen on? (iOS, Android, all, etc.)
What platform versions does this happen on? (Android 4.2, iOS 7, all, etc.)
Is this an issue with the Ionic Framework, or Ionic CLI?

Additionally, providing a codepen which replicates the issue is extremely helpful.
If you wish to get help using the framework itself, the recommended place is the forum.
Thank you for allowing me to assist you.


build + npm update

Please build the lib and update npm.
There are a lot of merged PR since the 0.1.6 version.
Thanks a lot

I think this repo is abandoned, it might need a fork to publish a maintained version?
The PRs merged since then are 22 (typo in README), 26 (dithering), and 27 (global palette).

The npm module is utterly useless for Node.js. Even if I compile .coffee files, it uses stuff like document, navigator, etc. Are there any forks that fix that?

There's a major performance degradation that was introduced with #26 and #27 that I was planning to resolve before updating... but I haven't found the time to do it yet (and it's not high on my priority list).
If anyone feels like stepping up as a maintainer that would be awesome!
@atomizer it was never intended to be used in node. The npm module is for browserify

@atomizer There are multiple GIF modules for node: gif, gif-encoder, gif-stream...

the performance degredation is in gifencoder.analyzepixels.
the change to remove color cacheing actually slows it down NOT speeds it up.  doing a 'findclosest' call for the var 'index' is slower on all my runs than the previous 'lookupRGB' call on the NeuQuant object...

Could do a prerelease, i.e. 0.2.0-1


color coding more generic

Make it more flexible for the color coding.
If colors are not the one described in readme how does it work.

Create an independent file containing the correspondence between the color code and traits name.
a sort of json file.


fix for privilege_target

It just got renamed to targets. Also regen diagrams.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/86910a95f60ebe5cfa4efb22e09a64aa3b3ad4ac/

 Thanks, @mjibson!

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


WebCam - no module named gst

New to PyBBIO - attempted to use webcam.py example - it failed saying cannot import several modules - gst, sys, object, pygtk, gst.video.  Search on my Beaglebone did not find these files.
Went into the init.ph and webcam.py under the WebCam directory and yep they expect those modules.  All docs say they are now included in the latest PyBBIO and bbio.
Beagle bone Black C  3.8.13-bone70 kernel
all updates and upgrades say they are already up to date.
pip install --upgrade PyBBIO
pip install --upgrade Adafruit_BBIO
Do i need to install these modules separately ? if so from where?

GStreamer has to be downloaded for this to work. Sorry I forgot to put that on the wiki. Its updated now.
apt-get install python-gst0.10
apt-get install gstreamer0.10-plugins


docs(setup): Adds Google I/O Codelab to quickstart page

@demobox, @lwander FYI, any objections/thoughts to this?

sgtm, or if you're inclined to, even remove this one and only add to codelabs. Just wanted it represented somewhere, and I thought quickstart was a decent one.
On a broader sense, it raises what the purpose of the quickstart section is vs codelabs. We had discussed the notion that a general purpose quickstart often sets up wrong expectations with the user.

even remove this one and only add to codelabs

I think adding it here risks confusing users in that the resulting instance here isn't accessible in the same way as one created by the Helm chart or Cloud Launcher, e.g. it's not created in a user's project or account.
+1 adding it guides and/or codelabs.

sgtm, closing.


bug(table): Header cell content generated by ngFor is not updated

Bug, feature request, or proposal:
As the title states, it seems like the mat-header-cell's interpolated content isn't recalculated when properties change.
What is the expected behavior?
That the id0 column generated by the *ngFor would behave like the id column and dynamically update when the week array changes.
For comparison, the <span> within the chevron buttons is also generated using an *ngFor and updates without issue.
What is the current behavior?
The id0 column's header content is not re-evaluated when the week array changes.
What are the steps to reproduce?
https://stackblitz.com/edit/material2-rc0-vb1rjf
Use the chevron buttons to navigate forward and backward.  The date of the second id column doesn't change, while the first does.
What is the use-case or motivation for changing an existing behavior?
My use case is that I'd like to have a table based around a week-view, where users can navigate forward and backward.  It'd be nice if the mat table headers could dynamically update.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Latest versions of Angular, Material, Typescript, Windows 10, and Chrome.
Is there anything else we should know?

tl;dr: Add an index trackBy function to your ngFor
Lots going on here in the template, I'll try to distill it a bit to show what the issue is.
ngFor is creating a set of columns (in this case, just one column). The table picks up this column id0 and grabs the template to stamp out into the DOM. This template will render changes according to your AppComponent's interpolation checks since it lives in its view.
When you change week, you are telling the ngFor to destroy the id0 column template and create a new one. This is because it assumes that due to a reference change (different week array) that the template is no longer valid and needs to be remade.
The table is told about the new column id0 and so it does register this new template. However, the mat-header-row was told to render the columns data, id, and id0, which it is already doing. As far as it knows, it doesn't need to change and so the table does not re-render with the new template constructed by the ngFor.
So now we are in a state where the table has stamped a particular set of content to the DOM that has been orphaned by its view. The table never re-stamped out the new ngFor column template, which would be updated by the AppComponent view.
So we have two options - (1) tell the table that it should re-stamp out the header cells by making a change to the columns we want to render or (2) do not destroy/build new column definitions when the week array changes.
Since option (1) means we have to actually change the columns (table will see there's no diff), let's go with option (2).
How do we tell ngFor that the template doesn't need to be changed if it already build a template for each array index? By adding a trackBy function that tells the ngFor to identify templates based on their index rather than by object reference.
In the AppComponent, create a TrackByFn that returns the array index:
trackByIndex = i => i;

If the syntax looks odd, this is the same as
trackByIndex = function(i) { return i; }

Now, tell the ngFor about this trackBy:
*ngFor="let d of week; let i = index; trackBy: trackByIndex"

And voila, now the template will be provided to the table and not re-created. Its content will be updated when the view's change detection is run and the table will be consistent with showing this template.


[wip] Redesign dispatch menu

as follow-up to some comments from #26... what do you think of this, @pkryger?

(somehow hard to copy/paste the text from the popup, so here's an image instead)

I like the new layout with logical groping much better. (I also like the theme - a solarized-light user here ☀).
I used a way to programmatically copy contents of *transient* buffer to a *scratch* and then copy text via clipboard. Thinking 🤔 of it now I should have probably been using (kill-new). Will find it and post later, when I get to a computer.
I've also noticed that in readme I put a code from a sample popup instead of the python-pytest-dispatch🤭. Will send a PR with an improved example.

some questions/doubts/thoughts:

using multiple columns for flags/options? magit doesn't do it, but usually has fewer of them i think it visually helps and since many of them are short it fits even on small screens, and saves a lot of vertical space

got rid of all key bindings starting with = since it's not required anymore, and some of the previous = flags didn't correspond to real pytest short options anyway.

use --foo options with double dash instead. some of them actually match (a prefix of) real pytest options (e.g. --lf), while others do not (--ft for --full-trace). is this too confusing or messy?

do the groupings make sense? maybe it can be reduced a bit?

should other options be added/removed?

Here's the trick to have a new kill item ready to yank rigth after invoking a popup/dispatch:
(define-advice python-pytest-dispatch (:after (&rest _))
  (with-current-buffer transient--buffer-name
    (copy-region-as-kill (point-min) (point-max))))

using multiple columns for flags/options? magit doesn't do it, but usually has fewer of them. i think it visually helps and since many of them are short it fits even on small screens, and saves a lot of vertical space

Same thoughts.

got rid of all key bindings starting with = since it's not required anymore, and some of the previous = flags didn't correspond to real pytest short options anyway.
use --foo options with double dash instead. some of them actually match (a prefix of) real pytest options (e.g. --lf), while others do not (--ft for --full-trace). is this too confusing or messy?

I like the idea of not having the = things anymore. The fact that some options double dash flags don't have corresponding pytest options is fine as well. As long as they don't step on any other pytest option I'm fine. I think that comes from the way I use transient: firstly it's  a helper to explore options (with reasonable defaults), later it's muscle memory - I don't even read it - just blindly hit P -f p to push an amended commit 🤗. Not sure how open the pytest would be to accept these new switches 🤔

do the groupings make sense? maybe it can be reduced a bit?

Perhaps the Exit early could be merged into Test selection and ordering. The exit early could be interpreted as a dynamic filter 🤔

should other options be added/removed?

Not an expert here as I don't do much python 🤭😜. And IDK a good way of measuring it, unless you want to snoop on users' choices into some analytic cloud... but somehow I don't like that. Perhaps having a paragraph in a prominent place in the readme asking people to send their requests for missing options?

i fiddled some more. this is what it looks like now:
Output
 -c color (--color)
 -q quiet (--quiet)
 -s no output capture (--capture=no)
 -v verbosity ([--verbose|--verbose --verbose])

Selection, filtering, ordering
 -k only names matching expression (-k=)      --dm run doctests (--doctest-modules)
 -m only marks matching expression (-m=)      --nf new first (--new-first)
                                              --sw stepwise (--stepwise)

Failures, errors, debugging
 -l show locals (--showlocals)                --ff failed first (--failed-first)
 -p debug on error (--pdb)                    --ft full tracebacks (--full-trace)
 -x exit after first failure (--exitfirst)    --mf exit after N failures or errors (--maxfail=10)
                                              --rx run xfail tests (--runxfail)
                                              --tb traceback style (--tb=)
                                              --tr debug on each test (--trace)

Run tests
 t all    r repeat         f file (dwim)    m files          d def/class (dwim)
          x last failed    f this file      m directories    d this def/class

pretty happy with it. unless @pkryger has some suggestions that need further work,
i'll likely merge this soon.

IMO, it looks really good 👍

cool, thanks for your review and previous input!


FEATURE REQUEST: Base folder as action parameter (not as hard-coded folder)

Currently the action uses a hard-coded folder ${{ github.workspace }}\vcpkg (the vcpkg part is hard-coded).
This has proved to be an issue for my case.
It would be nice to have a parameter like e.g. vcpkg_subfolder.

Feel free to propose a PR that includes a CI action.


feat:  component legend needs more postion options

G2 Version:
Platform:
Mini Showcase(like screenshots):
CodePen Link:

in our projects,   designers always make legend  lays from left to right , it is much more convinient for user to read the chart.    but g2 only provide four options includes  left , right , top , bottom, if g2 can provide more specific position opts like  ' left top' ,  'right bottom ' .   it would be consummate  and suit more cases .

thank u ~

https://antv.alipay.com/zh-cn/g2/3.x/api/chart.html#________参数


TOB6: Security Fix ; Include Checksum Validation Of Dragonwell JDK Download.

Fixes #999
Include an integrity check for the Dragonwell JDK8 download. the aarch64 dockerfile does this, so the fix is only required for x64.
Ref: TOB-TEMURIN-6

Thanks - that's one I was going to try and get to today :-)

Hehe, Im picking up little things, as I finish testing the installer changes.

Woohoo - congrats on having issue/PR 1000 in this repo ;-)


Add iiif manifest link to records

Directly under the Images section:

Not ideal placement but the whole record page is not ideal tbh so one to revisit later.

Text inspired by Yale's site, e.g. https://collections.britishart.yale.edu/catalog/tms:1079.

Requires https://github.com/NaturalHistoryMuseum/ckanext-iiif/pull/7


[AutoPR containerservice/resource-manager] chore: jsonfmt containerservice

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5998

Codecov Report

Merging #5284 into restapi_auto_containerservice/resource-manager will decrease coverage by 4.04%.
The diff coverage is n/a.

@@                                Coverage Diff                                 @@
##           restapi_auto_containerservice/resource-manager    #5284      +/-   ##
==================================================================================
- Coverage                                           53.54%    49.5%   -4.05%
==================================================================================
  Files                                               10484     6274    -4210
  Lines                                              217043   173320   -43723
==================================================================================
- Hits                                               116224    85804   -30420
+ Misses                                             100819    87516   -13303

Impacted Files
Coverage Δ

...afactory/azure/mgmt/datafactory/models/__init__.py
50.67% <0%> (-49.33%)
:arrow_down:

...ights/azure/applicationinsights/models/__init__.py
51% <0%> (-49%)
:arrow_down:

...e/cognitiveservices/vision/face/models/__init__.py
51.08% <0%> (-48.92%)
:arrow_down:

...services/language/textanalytics/models/__init__.py
51.16% <0%> (-48.84%)
:arrow_down:

...iveservices/search/entitysearch/models/__init__.py
51.25% <0%> (-48.75%)
:arrow_down:

azure-eventgrid/azure/eventgrid/models/__init__.py
51.25% <0%> (-48.75%)
:arrow_down:

...ration/azure/mgmt/datamigration/models/__init__.py
51.27% <0%> (-48.73%)
:arrow_down:

...ure/mgmt/recoveryservicesbackup/models/__init__.py
51.46% <0%> (-48.54%)
:arrow_down:

...ce/azure/mgmt/containerinstance/models/__init__.py
51.8% <0%> (-48.2%)
:arrow_down:

...tiveservices/search/videosearch/models/__init__.py
52.08% <0%> (-47.92%)
:arrow_down:

... and 4288 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27bed2b...78bc479. Read the comment docs.

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/5292


debug help!

How to debug the results layer by layer to determine the problems existing in the converted model during the Generation Session?

Pleaserefer the document here https://github.com/NVIDIA/TensorRT-LLM/blob/main/docs/source/2023-05-19-how-to-debug.md

您好，你的邮件我已经收到~


localizedPrice & price is null on Android

Hi, first of all thanks for this amazing package.
I am having an issue with localizedPrice & price being null after upgrading Flutter version from 3.3.1 to 3.7.5. Prices are setup correctly in Play Store. Previous version of the app behaves correctly on production that is built with Flutter version 3.3.1
Version of flutter_inapp_purchase:

5.0.4 (tried with the latest version 5.4.1, still null value)

Flutter 3.7.5 • channel stable
Platforms you faced the error:

Android

Expected behavior:

localizedPrice & price should not be null on Android

Actual behavior

localizedPrice & price is null on Android

Tested environment:

Real Device

Steps to reproduce the behavior:
FlutterInappPurchase.instance.getProducts(_productLists)

I'm having the same issue, any news about this?

Probabla this error? https://github.com/dooboolab-community/flutter_inapp_purchase/pull/392

Any assistance? This is a breaking issue guys, help would be appreciated. Tried to downgrade down to 4.0.0 but still, its all null now.

@KzumO36 not really. It would be nice to have it fixed, sure, but you can simply use:
var price = product.localizedPrice ?? product.introductoryPrice;

No, theres still an exception then. It's showing the price yes but if you tap on an item to buy it, theres still an error.
E/flutter (17774): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: PlatformException(InappPurchasePlugin, buyItemByType, null, null) E/flutter (17774): #0      StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:653:7) E/flutter (17774): #1      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:315:18) E/flutter (17774): <asynchronous suspension> E/flutter (17774): #2      FlutterInappPurchase.requestPurchase (package:flutter_inapp_purchase/flutter_inapp_purchase.dart:278:14) E/flutter (17774): <asynchronous suspension>

@KzumO36 That's a different problem, unrelated to the price display. I happened to have fixed it a few days ago. :-) See https://github.com/dooboolab-community/flutter_inapp_purchase/pull/423, it will be merged soon, hopefully, but until then, just fix it for yourself. It works, I already have my modified app in the store successfully.

@deakjahn I have used your repo now and it works, thank you!

@KzumO36  I am also getting same Exception , Any Update on this.

this seems to be related: https://github.com/dooboolab-community/flutter_inapp_purchase/issues/430
Workaround works for me.

@RomanSoviak Your decision, but 1) the other plugin is far from being equivalent, it lacks important features that this one supports, 2) this error has already been fixed.


uarti8250: make COM1 and COM2 poll, or any uart with poll or tbdf==-1

now that UARTs are showing up in #t again, any attempt to use them, e.g.
echo hi >> '#t/eia0'
will get a panic, as our interrupt support code no longer supports
ancient hardware with a tbdf of -1.
Note that, cleverly, uart interrupts are never even enabled until the
device is opened, which is why we did not see this problem earlier
We made this change I believe in the mod 2000s as part of the Fast-OS effort,
as we tried to drag the code forward from its 1990 base. It's a shame we
did not have code control back then.
i8250enable now checks to see if ctlr->tbdf is -1, or ctlr->poll is set;
if so, it disables interrupt enable.
The i8250poll code now runs, finally.
But what broke between 2011 and how such that serial consoles stopped working.
Therein lies a puzzle.
Signed-off-by: Ronald G Minnich<EMAIL_ADDRESS>

btw the second commit is only marginally better. It does, however, work for this trivial case of 2 uarts. And the old code did not.
The uarts are in a pre-defined array and element has a next pointer.  some of them might be working, some not.
consider this array of uarts in a linked list.
a->b->c->d
The for loop walks the list, and its goal is to test which ones work, and if they work, allocate io ports.
If not, delete the uart from the list by changing next pointers of the previous one. (it does this with the (uart-1) pointer kludge)
There may be 0, 1, or more working uarts. You might return this:
a->b->c->d
or
a->d (and in this case the (uart-1) pointer hackery is wrong
Anyway, in case you think the code is bogus, it is,  if there are more than 2 uarts. But there are only two, ever; so I doubt it matters much. I think it's too much effort for 2 uarts. But feel free to change it. Just be careful; it's been broken a lot.

don't merge this, just review, there's a debug print that has to be removed.

ok, feel free to merge if you want. It's not great, it's just better  than what we had.

let's take this in and, if we see a problem down the way, we can undo it.


Move initial work for earthquake realtime to here.

Coverage remained the same at 100.0% when pulling bdf67c7c86e2b27c60e05588b4c23afdd4603883 on akbargumbira:develop into c34ac411231871b64823b3e8c508c33d4518fdbc on AIFDR:develop.


refactor: [FC-0072] migrate project to swift 6

This commit updates the entire project to Swift 6, incorporating language features like Sendable conformance and improved concurrency support. Key changes include:

Sendable conformance added across the codebase for thread safety.
Extensive migration to async/await for modern concurrency handling.
New SwiftGen rule introduced to ensure compatibility with Swift 6.
Significant updates to the test suite:

Most tests refactored and optimized for reliability and faster execution.
Enhanced compatibility with CI/CD pipelines.

BREAKING CHANGE: The project now requires Swift 6, and dependencies or integrations using earlier Swift versions may need adjustments to ensure compatibility.

Thanks for the pull request, @IvanStepanok!
What's next?
Please work through the following steps to get your changes ready for engineering review:
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.

This process (including the steps you'll need to take) is documented here.

If it doesn't, simply proceed with the next step.

:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...

Blockers

This PR is waiting for OEP-1234 to be accepted.

Timeline information

This PR must be merged by XX date because ...

Partner information

This is for a course on edx.org.

Supporting documentation
Relevant Open edX discussion forum threads

:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
:radio_button: Let us know that your PR is ready for review:
Who will review my changes?
This repository is currently maintained by @openedx/openedx-mobile-maintainers.  Tag them in a comment and let them know that your changes are ready for review.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

Overview of Review Process for Community Contributions
Pull Request Status Guide
Making changes to your pull request

When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

@rnr Thanks for reviewing! All feedback are addressed


test-branch/execute-job/comment-from-wrong-user-on-pr/30dddae6-fe4e-4f25-a73c-6dd56aea2262

PR for testing 7bd67298587750fc253ea9e62d1c6e9e13536dcc

/canonical/self-hosted-runners/run-workflows 7bd67298587750fc253ea9e62d1c6e9e13536dcc


Upgrade to 1.20 seems not to be there?

I have a game (Stars without Number) which uses the sfrpgbb  module. When I launch it, it fails to load and a warning is given to upgrade sfrpgbb to 1.20

However, there seem to be no updates via the modules page or indeed on this github. The last release from Sep 20 2022 is still 1.11

Can someone explain why it is prompting for an update when none are available?
Thanks in advance.

Sadly, it does not seem to resolve the issue. I removed the module and reinstalled it. I even removed the World and created a new 'test' one, but the error is still there? I suspect the error is not with the module itself as I have scanned the files and there is no string "1.20" anywhere, but it might be the update mechanism Fvtt is using to check your manifest version, which might need to be updated on the website.
Hope that helps

Yup that fixed it.
Thanks


[SPARK-36895][SQL][FOLLOWUP] Use property to specify index type

What changes were proposed in this pull request?
use property to specify index type
Why are the changes needed?
to address this comment https://github.com/apache/spark/pull/34148#discussion_r731500964
Does this PR introduce any user-facing change?
Yes
  void createIndex(String indexName,
      String indexType,
      NamedReference[] columns,
      Map<NamedReference, Map<String, String>> columnsProperties,
      Map<String, String> properties)

changed to
createIndex(String indexName,
      NamedReference[] columns,
      Map<NamedReference, Map<String, String>> columnsProperties,
      Map<String, String> properties

How was this patch tested?
new test

Test build #144909 has started for PR 34486 at commit e282022.

Test build #144909 has finished for PR 34486 at commit e282022.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144909/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49379/

Test build #144910 has started for PR 34486 at commit f6decfb.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49379/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49380/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49379/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49380/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49380/

Test build #144911 has started for PR 34486 at commit b9ce735.

Test build #144912 has started for PR 34486 at commit 9ba3f8a.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49381/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49382/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49381/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49382/

Test build #144910 has finished for PR 34486 at commit f6decfb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144910/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49382/

Test build #144911 has finished for PR 34486 at commit b9ce735.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144911/

Test build #144912 has finished for PR 34486 at commit 9ba3f8a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144912/

Test build #144938 has started for PR 34486 at commit b2f1f90.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49410/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49410/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49410/

Test build #144938 has finished for PR 34486 at commit b2f1f90.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144938/

Test build #144984 has started for PR 34486 at commit 27939f8.

Test build #144984 has finished for PR 34486 at commit 27939f8.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144984/

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49455/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49455/

Test build #144987 has started for PR 34486 at commit 277e741.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49457/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49459/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49457/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49457/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49459/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49459/

Test build #144987 has finished for PR 34486 at commit 277e741.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144987/

thanks, merging to master!

@huaxingao @cloud-fan Sorry, but I'll revert this change because GA fails, which seems to be related this change.
https://github.com/huaxingao/spark/runs/4135539301?check_suite_focus=true#step:9:5083

sorry