[Bug] pt_main_thread uses 100% cpu all the time

Checklist

[X] 1. I have searched related issues but cannot get the expected help.
[X] 2. The bug has not been fixed in the latest version.
[X] 3. Please note that if the bug-related issue you submitted lacks corresponding environment info and a minimal reproducible demo, it will be challenging for us to reproduce and resolve the issue, reducing the likelihood of receiving feedback.

Describe the bug
the output of top command:
top - 10:27:25 up 33 min,  1 user,  load average: 1.22, 1.24, 1.16
Tasks: 730 total,   2 running, 728 sleeping,   0 stopped,   0 zombie
%Cpu(s):  3.2 us,  0.2 sy,  0.0 ni, 96.5 id,  0.0 wa,  0.0 hi,  0.0 si,  0.0 st
MiB Mem : 192964.5 total, 144154.6 free,  13737.5 used,  35072.4 buff/cache
MiB Swap:   8192.0 total,   8192.0 free,      0.0 used. 177252.5 avail Mem

    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
  61758 root      20   0   34.5g   1.5g 382668 R 101.0   0.8   8:53.40 pt_main_thread
   1500 root      20   0 7779860 232140  66836 S   1.0   0.1   0:59.39 dockerd
  16283 super     20   0   54.1g 256304  55712 S   1.0   0.1   0:36.18 node
  16943 super     20   0   54.2g 286160  56024 S   1.0   0.1   0:31.39 node
  58325 7474      20   0   45.9g 956696  25720 S   1.0   0.5   0:24.76 java
  60533 super     20   0   71.6g 363292  43680 S   0.7   0.2   0:10.00 node
      1 root      20   0  167160  12316   8132 S   0.3   0.0   0:04.91 systemd
     14 root      20   0       0      0      0 I   0.3   0.0   0:01.87 rcu_sched
   1259 systemd+  20   0   26068  14044   9412 S   0.3   0.0   0:07.33 systemd-resolve
...

(base) super@hot:~/apps/sglang$ ps -auex | grep 61758
root       61758  100  0.7 36159428 1575172 ?    Rl   10:18   9:27 python3 -m sglang.launch_server --model-path /models/Llama3.1-8B-Chinese-Chat --host <IP_ADDRESS> --port 5011 --quantization fp8 --context-length 48000 --tokenizer-mode auto --mem-fraction-static 0.8 --disable-radix-cache

Reproduction
  sglang:
    image: sglang
    runtime: nvidia
    ports:
      - '5011:5011'
    volumes:
      - $DATA_ROOT/huggingface_cache:/root/.cache/huggingface
      - $DATA_ROOT/models:/models
    environment:
      - CUDA_VISIBLE_DEVICES=0
      - HF_TOKEN=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
    command: >
      python3 -m sglang.launch_server
      --model-path /models/Llama3.1-8B-Chinese-Chat
      --host <IP_ADDRESS>
      --port 5011
      --quantization fp8
      --context-length 48000
      --tokenizer-mode auto
      --mem-fraction-static 0.8
    deploy:
      resources:
        reservations:
          devices:
            - driver: nvidia
              capabilities: [gpu]
    ipc: host
    restart: unless-stopped

Environment
Ubuntu 22.04 AMD64

It seems to be expected because the server uses a busy-waiting loop to wait for new requests. Does this create any serious trouble on you side?

I agree. In today's world, a single CPU core is not particularly significant. However, for those who are unfortunate enough to have an Intel chip, it's a completely different story: https://www.reddit.com/r/intel/comments/1egthzw/megathread_for_intel_core_13th_14th_gen_cpu/

Unfortunately not just sglang, I'm seeing this with my own Pytorch code.

Unfortunately not just sglang, I'm seeing this with my own Pytorch code.

+1

这似乎是意料之中的事，因为服务器使用忙等待循环来等待新请求。这会给您带来严重麻烦吗？

Given that I still use an i5-8400, which only has six cores, and I’m running LLM with dual GPUs, two of those cores are often running at 100%, which can have an impact.

Design-wise, i think, adding a sleep 0.001 sec or 0.01 sec should help. Otherwise, there would be tens of thousands of "trys" within 1 sec, which is unnecessarily bad.

Adding time.sleep(0.001) around line 910 in the /opt/conda/lib/python3.10/site-packages/sglang/srt/managers/tp_worker.py file can significantly reduce CPU usage. Note that the sleep duration should not be too long, as it may affect the inference speed. I set it to 0.001, and the impact on inference is barely noticeable. Refer to this example:
def run_tp_server(
gpu_id: int,
tp_rank: int,
server_args: ServerArgs,
nccl_port: int,
model_override_args: dict,
):
"""Run a tensor parallel model server."""
configure_logger(server_args, prefix=f" TP{tp_rank}")
try:
    model_server = ModelTpServer(
        gpu_id,
        tp_rank,
        server_args,
        nccl_port,
        model_override_args,
    )
    tp_cpu_group = model_server.model_runner.tp_group.cpu_group

    while True:
        recv_reqs = broadcast_recv_input(None, tp_rank, tp_cpu_group)
        model_server.exposed_step(recv_reqs)
        time.sleep(0.001)
except Exception:
    logger.error("Exception in run_tp_server:\n" + get_exception_traceback())
    raise

For people who care about this, please try @xbl916 's solution. I guess the main branch won't add the wait for the best performance. If you really care about this, please submit a pr to add an option for this.


Not finding packages Web3Ethereum and EthereumWallet

Hi so im trying to import those 2 packages based on what the installation says and the "ethereum example" repo but cant find the imports in the clone.

please help

I believe you can install it manually by adding in your package.json file
we'll try fix it in ethereum example asap

Ok, i assume paths havent been updated since...


space available new function

we have decided to move the "space available" calculation to the contract level and prevent any logical calculations outside it. this will simplify the process for any external dev and integrators in the future.
new function:
poolAvailableSpace(poolAnchor)
returns an array of two amounts
base token, bnt token
the return value is the available space for each reserve in the pool in wei and requires to normalize it based on the token's decimals.
for example, usdc/bnt pool:
usdc: 6 decimals
bnt: 18 decimals

Added in https://github.com/bancorprotocol/contracts-solidity/pull/507

so there will be another smart contract upgrade then?

@H34D : Yup.

this implementation should wait until the new contract is deployed.
@H34D

new contract is live on mainnet.
please implement this process.
new contract: 0xc9D9dc719C49edfc6bf9e0F0400Fc341cE93C298


Add explanations to GoogleDriveLoader how to avoid errors

Description: add a paragraph to the GoogleDriveLoader doc on how to bypass errors on authentication.

For some reason, specifying credential path via credentials_path constructor parameter when creating GoogleDriveLoader makes it so that the oAuth screen is never showing up when first using GoogleDriveLoader. Instead, the RefreshError: ('invalid_grant: Bad Request', {'error': 'invalid_grant', 'error_description': 'Bad Request'}) error happens. Setting it via os.environ["GOOGLE_APPLICATION_CREDENTIALS"] = ... solves the problem. Also, token_path constructor parameter is mandatory, otherwise another error happens when trying to load() for the first time.
These errors are tricky and time-consuming to figure out, so I believe it's good to mention them in the docs.

Thanks @anatoliykmetyuk !


"File must exist" error on maven stream deployment

When I try to deploy a maven based stream I get following error in the shell:
 2018-07-20 11:30:12.625 ERROR 1 --- [p-nio-80-exec-8] o.s.c.d.s.c.RestControllerAdvice         : Caught exception while handling a request  java.lang.IllegalArgumentException: File must exist 	at org.springframework.boot.loader.data.RandomAccessDataFile.<init>(RandomAccessDataFile.java:67) ~[spring-cloud-dataflow-server-kubernetes.jar:1.2.2.RELEASE]
The docker image is there and I can see it, not able to figure out why it says file does not exist.

Only docker images can be deployed to maven. You had mentioned "a maven based stream" but then also "The docker image is there and I can see it" -- what is the location you are passing to --uri when registering apps?

Hi, @naureen-34. +1 to Chris' comment ^^. Please refer to the getting-started/installation section re: Docker requirement. If you follow the guide, we will point to a few samples, which you could try on your cluster, and let us know your findings.

@chrisjs  I am passing --uri docker::
@sabbyanandan sure, I will give it a try.

@sabbyanandan  I followed the documentation, in the documentation app registration has been done for a task while I am trying to register a processor with the following command:
dataflow:>app register --name test-transformer --type processor --uri docker:/test-transformer:latest --metadata-uri file:///root/.m2/repository/com/my-project/test-transformer-0.0.5-SNAPSHOT-metadata.jar
on running this I do see
Successfully registered application 'processor:test-transformer in the shell.
Though when I request for it's info I see the following:
dataflow:>app info processor:eclaim-claim-transformer
Application info is not available for processor:eclaim-claim-transformer

When I create a stream using this processor:
stream create --definition "http --port=9000 | test-transformer | log" --name testTransformerStream
On deploying the stream, I see the error I mentioned above in my dataflow server log.
What am I missing here?

Thanks for the follow-up. It appears you're referring to the metadata artifact via file:// protocol. And specifically, it appears you're trying to resolve it from the local Maven repository. It won't work. The stacktrace should print which artifact is failing to resolve.
Let me clarify why.

In a Kubernetes environment, the artifact resolution (in SCDF) typically is a Docker artifact. Though you're resolving the App bits from a Docker Registry, but your metadata file won't be visible to SCDF. The file:// protocol means the artifact is expected to be available in the container where SCDF is running. Is it available?
Speaking of Docker Registry, your k8s environment has access to the registry? Can it access and download test-transformer:latest?

A quick way to rule out the environmental issues would be to try out one of the samples. Use the following stream definition to see if gets deployed.
dataflow:>app register --type source --name time --uri docker://springcloudstream/time-source-rabbit:1.3.1.RELEASE --metadata-uri maven://org.springframework.cloud.stream.app:time-source-rabbit:jar:metadata:1.3.1.RELEASE
dataflow:>app register --type sink --name log --uri docker://springcloudstream/log-sink-rabbit:1.3.1.RELEASE --metadata-uri maven://org.springframework.cloud.stream.app:log-sink-rabbit:jar:metadata:1.3.1.RELEASE
stream create --name ticktock --definition "time | log" --deploy

hi @naureen-34 -- as i don't have access to your artifacts, i created the following sample which should replicate your use case and i tested it on minikube 0.27.0 / k8s 1.10
you should be able to replicate the same concept to your local environment and be able to resolve your metadata artifacts from the mount as shown below. feel free to re-open if this does not work for you

add mount config to src/kubernetes/server/server-deployment.yaml, the relevant parts are:

    spec:
      volumes:
        - name: host-mount
          hostPath:
            path: /home/.m2
      containers:
      - name: scdf-server
        workingDir: /home/.m2
        volumeMounts:
        - name: host-mount
          mountPath: /home/.m2

start mount daemon when minikube starts
minikube start --mount-string /Users/cschaefer/.m2:/home/.m2 --mount

deploy dataflow to k8s

connect with shell, register apps, look at info, deploy stream

dataflow:> app register --type source --name time --uri docker://springcloudstream/time-source-rabbit:1.3.1.RELEASE --metadata-uri file:///home/.m2/repository/org/springframework/cloud/stream/app/time-source-rabbit/1.3.1.RELEASE/time-source-rabbit-1.3.1.RELEASE-metadata.jar
Successfully registered application 'source:time'
dataflow:> app info --name time --type source
Information about source application 'time':
Resource URI: docker://springcloudstream/time-source-rabbit:1.3.1.RELEASE
╔══════════════════════════════╤══════════════════════════════╤══════════════════════════════╤══════════════════════════════╗
║         Option Name          │         Description          │           Default            │             Type             ║
╠══════════════════════════════╪══════════════════════════════╪══════════════════════════════╪══════════════════════════════╣
║trigger.time-unit             │The TimeUnit to apply to delay│<none>                        │java.util.concurrent.TimeUnit ║
║                              │values.                       │                              │                              ║
║trigger.fixed-delay           │Fixed delay for periodic      │1                             │java.lang.Integer             ║
║                              │triggers.                     │                              │                              ║
║trigger.cron                  │Cron expression value for the │<none>                        │java.lang.String              ║
║                              │Cron Trigger.                 │                              │                              ║
║trigger.initial-delay         │Initial delay for periodic    │0                             │java.lang.Integer             ║
║                              │triggers.                     │                              │                              ║
║trigger.max-messages          │Maximum messages per poll, -1 │1                             │java.lang.Long                ║
║                              │means infinity.               │                              │                              ║
║trigger.date-format           │Format for the date value.    │<none>                        │java.lang.String              ║
╚══════════════════════════════╧══════════════════════════════╧══════════════════════════════╧══════════════════════════════╝

dataflow:> app register --type sink --name log --uri docker://springcloudstream/log-sink-rabbit:1.3.1.RELEASE --metadata-uri file:///home/.m2/repository/org/springframework/cloud/stream/app/log-sink-rabbit/1.3.1.RELEASE/log-sink-rabbit-1.3.1.RELEASE-metadata.jar
Successfully registered application 'sink:log'
dataflow:>app info --name log --type sink
Information about sink application 'log':
Resource URI: docker://springcloudstream/log-sink-rabbit:1.3.1.RELEASE
╔══════════════════════════════╤══════════════════════════════╤══════════════════════════════╤══════════════════════════════╗
║         Option Name          │         Description          │           Default            │             Type             ║
╠══════════════════════════════╪══════════════════════════════╪══════════════════════════════╪══════════════════════════════╣
║log.name                      │The name of the logger to use.│<none>                        │java.lang.String              ║
║log.level                     │The level at which to log     │<none>                        │org.springframework.integratio║
║                              │messages.                     │                              │n.handler.LoggingHandler$Level║
║log.expression                │A SpEL expression (against the│payload                       │java.lang.String              ║
║                              │incoming message) to evaluate │                              │                              ║
║                              │as the logged message.        │                              │                              ║
╚══════════════════════════════╧══════════════════════════════╧══════════════════════════════╧══════════════════════════════╝

dataflow:> stream create --name ticktock --definition "time | log" --deploy
Created new stream 'ticktock'
Deployment request has been sent
dataflow:> stream list
╔═══════════╤═════════════════╤═════════════════════════════════════════╗
║Stream Name│Stream Definition│                 Status                  ║
╠═══════════╪═════════════════╪═════════════════════════════════════════╣
║ticktock   │time | log       │The stream has been successfully deployed║
╚═══════════╧═════════════════╧═════════════════════════════════════════╝


Check for updates tab

I have checked the following:

[X] I've searched existing issues and found nothing related to my issue.

Describe the feature you want to add
I always make sure to download the latest version of Bruno. It would be great to have a tab to check for available updates and automatically download them if they are available.
Mockups or Images of the feature
This is an example of something I found on Notion. This feature could be introduced in Bruno.

Here's another example from HTTPie

This would not be too bad to implement using something like this.

duplicate of #103

Okay, thanks for replying. I'd close the issue right away


Second model with different feature extraction

Thank you for the new attempt George! I'm afraid the score went down to 0.506. I have not rtried to reproduce it myself, because it seems unlikely it will get back up to the heights of the previous model, which was high to start with. The problem facies is WS.


0013: Propose Self Contained Workflows

Description
Proposes the concept of fully self-contained workflows. Its used as the reverse-dependency of 0014 and 0015.
Why is this needed
Will allow for better managed workflows that can fully lock down versions of all of its necessary files. Also allows to remove OS/machine specific code from Boots.

Rendered: https://github.com/mmlb/proposals/blob/0013/0013/README.md

Since #21 we moved all the proposals inside the proposals directory. Do you mind to rebase and move your dir?
Thanks

@mmlb Closing this PR because you mentioned needs rework and seems like very old PR.

If so you can mark this as abandoned and merge the proposal
On Tue, Jun 29, 2021 at 5:45 PM Raj Dharwadkar @.***>
wrote:

@mmlb https://github.com/mmlb Closing this PR because you mentioned
needs rework and seems like very old PR.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tinkerbell/proposals/pull/18#issuecomment-870712170,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMOAO3RTCRBWB5POWD5FELTVHTBBANCNFSM4RXR5MQQ
.

@gianarb I can't merge, can you merge please.


wip: rp2040: add sequence to reset both cores in system_reset.

in RP2040, SCB SYS_RESET only resets the current core. We need it to reset both cores and SIO, otherwise we can run into funny issues like https://github.com/rp-rs/rp-hal/issues/292.
The way to do it is through the watchdog. The sequence to do this is working, the issue is that it completely resets the SWD state, so afterwards we need to do a complete "reattach". clear_state is a lazy attempt at this, but it doesn't cause reattach for the memory interface currently opened...
I'm not sure what's the best way to proceed.

Is there absolutely no way to no not reset the SWD peripheral?

I looked at the RP2040 fork of OpenOCD but it seems to just write the SYSRESETREQ bit.
The RP2040 datasheet says:
Once running, resets can be triggered from the Debugger, NVIC (using AIRCR.SYSRESETREQ), or the RP2040 Power On State Machine controller (see details in Section 2.13). The NVIC only resets the Cortex-M0+ processor core (not the Debug or PMU), whereas the Power On State Machine controller can reset the processor subsystem which asserts all resets in the subsystem (Debug, M0+ core, PMU)

Instead of letting the watchdog reset the peripherals, does it work if you hit FRCE_OFF and then FRCE_ON for just the ones you want to reset? I see you have defines for those registers, but don't use them - so maybe you tried this and took it out already.


Remove default loading of drivers in kldlist

Xconfig should start the driver here the issue https://github.com/ghostbsd/xconfig/issues/3 for xconfig when completed and the package is compiled is sync we can remove GPU driver from rc.conf.

Agree.
All uneeded gpu drivers from kld_list in rc.conf should be removed. Because of them X -configure fails if user doesn't have such a videocard. kld_list should be updated by xconfig which should load needed driver and config xorg.


In Ansible based CI, revisit the roles directory organization :  Localize files needed in the role tasks

Currently, there is a generic folder called "files" which houses all miscellaneous files needed during by various roles during playbook execution.  We need to see a cleaner way of doing this by localising the files to a role.

Fixed as part of #136


Catalog Template API[Steve] - No Way To Fetch Catalog Template Data

Currently we have no way to fetch the catalog template default data as we do in Norman. This means we can't get the defaults for the catalog item.

@westlywright Sorry I need a bit more context here.  What do you get from norman and what do you get from steve that is lacking.  Like the actual objects.


Error: Build Error

Environment
import { Nuxt, Builder } from 'nuxt';
^^^^^^^
SyntaxError: The requested module 'nuxt' does not provide an export named 'Builder'
at ModuleJob._instantiate (node:internal/modules/esm/module_job:132:21)
at async ModuleJob.run (node:internal/modules/esm/module_job:214:5)
at async ModuleLoader.import (node:internal/modules/esm/loader:323:24)
at async loadESM (node:internal/process/esm_loader:28:7)
at async handleMainPromise (node:internal/modules/run_main:120:12)
Node.js v21.6.1
Reproduction
import { Nuxt, Builder } from 'nuxt';
^^^^^^^
SyntaxError: The requested module 'nuxt' does not provide an export named 'Builder'
at ModuleJob._instantiate (node:internal/modules/esm/module_job:132:21)
at async ModuleJob.run (node:internal/modules/esm/module_job:214:5)
at async ModuleLoader.import (node:internal/modules/esm/loader:323:24)
at async loadESM (node:internal/process/esm_loader:28:7)
at async handleMainPromise (node:internal/modules/run_main:120:12)
Node.js v21.6.1
Describe the bug
when ever run the code,getting this error.
Additional context
No response
Logs
No response

Probably you have updated Nuxt to v3, which does not have those exports.
Would you provide a reproduction? 🙏

Already versions are upgraded

@ramsonu You use Nuxt 3 with the axios module, which only works in Nuxt 2. Removing the module (and others that are not supported for Nuxt 3) will resolve this.


Improves semantics of Circuit.findall_operations_until_blocked

Now takes into account blocking operations on qubits in the 'light cone' of the start frontier.
I found the previous semantics quite surprising. See the added tests for examples of the new behavior.
Only one existing test had to be changed, so it seems like this shouldn't be too much of a breaking change.

@Strilanc could you take a look as this is the method you wrote.

Ping @bryano

@Strilanc PTAL

@Strilanc Could you help me out with the docs error? I don't understand what the problem is.

@Strilanc ping

Automerge cancelled: No approved review.


[Backend] Add FAQ(POST)

Admins can add a FAQ.
Create FAQ Model for DB.
Authenticated API
Requires API Testing. Refer #81 .
Please confirm the model structure before implementation

Can I work on this?

Will a question and answer field suffice for the FAQ model?

Yes, just keep another one as isActive field incase we want to temporarily disable a FAQ

@promaroy What is the update on this?

Hi, I am a GSSoC'21 Participant. I would like to work on this issue

Is there any update regarding this issue? or else I can try this one out.

Hi @dhwaj1902, I am working on this issue. I'll create a PR by this week end.

Ok.

@Kriti-bit Please raise PR by today else will have to reassign it to @dhwaj1902


Sbee dev

Close #250
Use both rows and columns in LocalBaseline

Pretty sure this is ready for review. I think I left it as a draft because there's a couple of my snarky comments I was unsure about and I wanted to complete work on the RamanID plugin.
Since then I'm calling ready for review because (1) I don't want my FWHM implementation to go stale (2) We've since pivoted from the work that I thought would be completed in here (ask offline if you don't know what I mean) (3) The snarky comments are helpful in the long run.


Update us_ticker.c

Using MRT instead of SCT, needed to free up SCT for PWM
Code ported from LPC824 libs

How did you test this? Can you share the test output?

did anyone test exactly the same implementation on the LPC824?
I inspected the code and ran tests with wait and tickers checking the time
intervals on some outputpins with a logic analyser.

From<EMAIL_ADDRESS><EMAIL_ADDRESS>On
Behalf Of Martin Kojtal
Sent: donderdag 12 februari 2015 13:59
To: mbedmicro/mbed
Subject: Re: [mbed] Update us_ticker.c (#905)
How did you test this? Can you share the test output?

Reply to this email directly or view it
https://github.com/mbedmicro/mbed/pull/905#issuecomment-74066364  on
GitHub.
<https://github.com/notifications/beacon/AFAC14Wcq6jQMSIO2ykYXS1Q9N49t_Q4ks5
nrJsMgaJpZM4DfFlc.gif>
--
You received this message because you are subscribed to the Google Groups
"mbed-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to<EMAIL_ADDRESS>For more options, visit https://groups.google.com/d/optout.

@mbednotifications Use a signature please. Was that you Wim?

Yes, was me.
Wim

From: Martin Kojtal<EMAIL_ADDRESS>Sent: donderdag 12 februari 2015 14:26
To: mbedmicro/mbed
Cc: Wim
Subject: Re: [mbed] Update us_ticker.c (#905)
@mbednotifications https://github.com/mbednotifications  Use a signature
please. Was that you Wim?

Reply to this email directly or view it
https://github.com/mbedmicro/mbed/pull/905#issuecomment-74069627  on
GitHub.
<https://github.com/notifications/beacon/AKMUNAwwpuKZEh-qghmIDdcDcFC15_mKks5
nrKFrgaJpZM4DfFlc.gif>

Wim, did you test this using our test framework? asking , if you can share the results. Anyway, we will run the tests

@Willem23 : do you need any help setting up our regression test ?
Some guidelines: http://developer.mbed.org/teams/SDK-Development/wiki/Mbed-SDK-automated-test-suite

Martin, Przemek,
I did not use the testsuite. Will have to take a look first to see how that works.
I do have an update on the us_ticker() that avoids one mult and div as discussed above. Will issue pull request.
Wim

@Willem23 : if it's on top of  this one, just push commits to your branch (I see it's your master), will be reflected here


Swap out #selector for Selector init with string

I was able to get the package building using the Xcode 14 beta with this change.

Thanks for the PR !
I think the "right" solution is fixing the strict selector per the compiler version like noted here. Could you look into it? If it's not possible we can go with the String version but it's not preferable:
https://github.com/apple/swift/issues/45652#issuecomment-1149235081


Only symbolically calculate the metric components and derivatives

At the moment we fully calculate the geodesic equation, but to aid with intermediary caching, we could instead only symbolically calculate the jacobian of the metric, and assemble the geodesic components directly in code.
The benefit of this lends itself to caching more values (c.f. sin and cosine), and aids dramatically in readability.
To again aid, we could determine all non-zero components of the Christoffel symbols to sparsely compute at runtime.

#13 addresses this, full benchmarks pending, but it is indeed better for very complex metrics, but slower for simple ones.


Generated addresses do not match with addresses generated by the ui

So here's what I'm doing:
        var iotaClient = new IotaApi("node.iotawallet.info", 14265);
        var seed = "...";
        var a = iotaClient.GetNewAddress(seed, 0,false,1);

And it generates 1 new address.
However, when I login with iota lightweight wallet and the same seed, the address it generates is completely different from the address that I have generated with this api
Is this intended behavior?
Let's say, seed is OISRIGVDCFIENLLAXCCIVQWHQNHXTJXEVOPLUUHVFMOLXTXCGBZSSNFIZSPXVXDKVEWVDPWJNOFMMHSDP
Address generated in wallet:
SGHFLUWOZPACYGMAPDUMDKQNIBAUHVCWWY9PITQLMRCFTDAIYVSZDAPTKQMZKRPDDUSKCWXBFNAHCSRPYBYRZR9FHY
Address generated via api:
YYFLQZTXISNMM99TADQYQXIHCAKVBLVTHFTL9SPFUKXDDYXTWAMMNMVLVOXXBVQTGJEFOZYBARQOZHKIJ

Correct! That's because #7 is not done yet.


When in outline mode, dragging over a diamond or a heart causes the red outline to show

This can be fixed by removing the red, just make all card's borders black


feat: add renderTabBarItem prop to TabBar

Motivation
We want to use react-native-tab-view and its' TabBar without replacing it, but want to replace TabBarItem, as we are required to do a few changes to the tab labels, that can't be achieved by just passing labelStyle to it. (For example, our tab animations will be changing other attribute than opacity which is currently set by native TabBarItem.)
This simple change lets replace the TabBarItem component if somebody needs to.

Can you change it to call it like renderTabBarItem({ ... }) instead of ? Since we're not accepting a component here, but a render callback, we shouldn't use it like a component. Otherwise it'll remount the component every time the reference to the callback changes.

I assumed a developer would just pass a component or a memoized callback here, and so that problem wouldn't exist ; P But on the other hand it's easy to transform a component into a render prop like this:
const renderTabBarItem = (props): React.ReactElement => (
  <AiloTabBarItem {...props} />
);

So sure, I can do that change :) I force pushed that into this branch. I also added minor docs about that new option to README.

Merged in 33fd8087a03299edeac7d7c79701e2622423f08a


Switch uses 'path' prop without resolving pure function component first

Version
5.2.0
Test Case
https://codesandbox.io/s/react-router-k9zg4?file=/index.js
Steps to reproduce
In the link above, I'm using a pure function component <CustomRoute> which produces a <Route> with an augmented path prop. However, it appears the <Switch> component looks into the props of its children without first resolving the element into a route component: https://github.com/ReactTraining/react-router/blob/master/packages/react-router/modules/Switch.js#L31
This behavior ignores the core philosophy of React's composition-based design.
Expected Behavior
The pure function component (or any component, really) should be fully resolved before the path prop is checked.
Actual Behavior
The routing functionality completely breaks.

This is expected behavior. You can actually have anything under Switch. We use these props as a config for Switch.


[Bug] parcel version & node-gyp

Is this a regression?
Yes
Description
When we install the latest version of NgDoc, I see an error with @parcel/watcher.
After some investigation, I managed to fix this error by adding an override in my package.json:
"overrides": {
    "@ng-doc/builder": {
      "@parcel/watcher": "~2.4.0"
    }
  }

Please provide the exception or error you saw
npm error gyp: binding.gyp not found (cwd: /home/user/IdeaProjects/ds-v17/node_modules/@parcel/watcher) while trying to load binding.gyp
npm error gyp ERR! configure error
npm error gyp ERR! stack Error: `gyp` failed with exit code: 1
npm error gyp ERR! stack at ChildProcess.<anonymous> (/home/user/IdeaProjects/ds-v17/node_modules/node-gyp/lib/configure.js:317:18)
npm error gyp ERR! stack at ChildProcess.emit (node:events:519:28)
npm error gyp ERR! stack at ChildProcess._handle.onexit (node:internal/child_process:294:12)
npm error gyp ERR! System Linux 6.8.0-45-generic
npm error gyp ERR! command "/home/user/.nvm/versions/node/v20.17.0/bin/node" "/home/user/IdeaProjects/ds-v17/node_modules/.bin/node-gyp" "rebuild"
npm error gyp ERR! cwd /home/user/IdeaProjects/ds-v17/node_modules/@parcel/watcher
npm error gyp ERR! node -v v20.17.0
npm error gyp ERR! node-gyp -v v10.2.0
npm error gyp ERR! not ok

OS
Unix (Linux, macOS, etc.)
Browser
Chrome
Node version
20.17.0
Anything else?
No response

:tada: This issue has been resolved in version 18.2.0 :tada:
The release is available on:

v18.2.0
GitHub release

Your semantic-release bot :package::rocket:


bin commands

I noticed parse script gets thrown into users path, which seems like it has potential to conflict with something.
/usr/local/bin/parse

additionally the cleanup command, which is arguably more useful, is not available except for in the repo itself. perhaps both of these should stay in the repo but get added to the package.json as scripts?
I have something like this:
{
 ...
  "scripts": {
    "cleanup": "./node_modules/superscript/bin/cleanup.js --mongo superscriptDB",
    "parse": "./node_modules/superscript/bin/parse.js -f",
    "watch-ss": "nodemon -e ss ./node_modules/superscript/bin/cleanup.js --mongo superscriptDB"
  }
}

npm run watch-ss is especially useful when you're just editing scripts and want to restart the bot each time.

I think if users install npm packages globally, they're explicitly taking the risk that they might be adding bin scripts to their PATH, so I'm not too concerned with this.
If they don't install superscript globally, as you say they can just use npm scripts to run the bin scripts. I really like watch-ss - that's a good tip!
Btw, in v1.0.0 the cleanup script is distributed in the global package so can be used as normal.


split lysosomal acid lipase deficiency

close #6379

@twhetzel
here is documentation on splitting classes:
https://mondo.readthedocs.io/en/latest/editors-guide/sop_splitting-terms/
Let me know if there is enough detail there to properly review this PR. If not, we should probably update the documentation.

related https://github.com/monarch-initiative/mondo/issues/6848


Calling POST: /api/users gives HTTP response code 500.

Hi,
I am getting HTTP response code 500 when trying to post or to api/Users,
also when i am trying to call GET api/Users/checkemail/{email}.
Also when navigating to http://localhost:4999/api/Users i get HTTP response 404 not found.
Can you help me?

Does the database and database connection setup correct?

Yes, i believe so. I have tried using both Windows Authentication and SQL server authentication.
"SQLSERVERDB": "server=tcp:Robin-PC\SQLEXPRESS01.database.windows.net,1433;Initial Catalog=Test;Persist Security Info=False;User ID=sa;Password=12345;MultipleActiveResultSets=False;Encrypt=True;TrustServerCertificate=False;Connection Timeout=30;"
I can connect to the SQL server from SSMS.

A little hard to identify your problem, you can try to switch to debug mode in VS and try to find which code make this happen.

But should i not be able to navigate to the http://localhost:4999/api/Users in the browser?
It gives me 404 not found.
I will check further, thank you.

You can create a user in database user table, and try to use postman to try to call the email address checking API, this API is the simplest one, if it can't work that means you have a problem with you .NET environment.

I checked in both swagger and postman. Both returns 500 internal server error when trying to call api/users/chechemail/{email}. Must be something wrong with the .NET environment as you say.

I managed to find the error:
netcoreauth.api> System.Data.SqlClient.SqlException: A connection was successfully established with the server, but then an error occurred during the login process. (provider: SSL Provider, error: 0 - Sertifikatkjeden ble utstedt av en instans som ikke er klarert.) ---> System.ComponentModel.Win32Exception: Sertifikatkjeden ble utstedt av en instans som ikke er klarert
Which means: The certificate chain was issued by an authority that is not trusted.
Now i need to solve the error.

Solved for now by setting Encrypt=False;TrustServerCertificate=True
But the
"UserAuthSecretKey": "abc123!321cba" should be changed to a longer secret.
I am getting the following error:
netcoreauth.api> System.ArgumentOutOfRangeException: IDX10603: The algorithm: 'HS256' requires the SecurityKey.KeySize to be greater than '128' bits. KeySize reported: '104'.

Thanks, I think I need to change the sample key to a better one.


Pcln modal

Could be finally reviewed for the actual code.
Need guidance on unit-test tho.
Please refer to README.md file and storybook folder for usage cases.

Codecov Report

Merging #448 into next will not change coverage.
The diff coverage is 100%.

@@         Coverage Diff         @@
##           next   #448   +/-   ##
===================================
  Coverage   100%   100%
===================================
  Files        43     47    +4
  Lines       369    449   +80
===================================
+ Hits        369    449   +80

Impacted Files
Coverage Δ

packages/modal/src/Modal.js
100% <100%> (ø)

packages/autocomplete/src/index.js
100% <100%> (ø)

packages/modal/src/SmallModalHeader.js
100% <100%> (ø)

packages/modal/src/ModalHeader.js
100% <100%> (ø)

packages/modal/src/ScrollLock.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8389e6...8b3ff09. Read the comment docs.


Unittest fails

======================================================================
FAIL: test_flatten_simple_resource (main.TestFlattenFHIR.test_flatten_simple_resource)
Traceback (most recent call last):
File "c:\repos\fhirpower\test\fhirpower_test.py", line 21, in test_flatten_simple_resource
self.assertDictEqual(flattened_dict, expected_output)
AssertionError: '[resourceType]Patient[name][given]John[name][family]Doe' is not an instance of <class 'dict'> : Second argument is not a dictionary

This is because the expected output is not a dictionary. I fixed the test case!


'UbxGpsNavPvt' is not a template

Hi,
I tried your code with the arduino software.
I've installed the library with the library manager.
When I compile the code sample I've this error.
Could you help please.
Thanks

Hi @ffbboy30 ,
Would be nice to see the error :)


Handling job class removals/changes

I currently have a job added like this:
JobKey jobKey = new JobKey("MyTestJobKey", "TestGroup");
services.AddJob<MyTestJob>(jobKey, j => j
    .WithDescription("A test job")
);

This job is properly persisted in the MongoDB database. However, an issue arises when I need to change the class name of MyTestJob.
Once I change the class name (for example from MyTestJob to MyTestJob2) or remove the class altogether and re-run the scheduler, the scheduler factory fails with the following error:
Quartz.JobPersistenceException: Job class cannot be null.
 ---> System.ArgumentException: Job class cannot be null.
   at Quartz.Impl.JobDetailImpl.set_JobType(Type value)
   at Quartz.Impl.JobDetailImpl..ctor(JobKey key, Type jobType, String description, Boolean isDurable, Boolean requestsRecovery, JobDataMap jobDataMap, Nullable`1 disallowConcurrentExecution, Nullable`1 persistJobDataAfterExecution)
   at Quartz.JobBuilder.Build()
   at Quartz.Spi.MongoDbJobStore.Models.JobDetail.GetJobDetail()
   at Quartz.Spi.MongoDbJobStore.MongoDbJobStore.ReplaceTriggerInternal(TriggerKey triggerKey, IOperableTrigger newTrigger)
   at Quartz.Spi.MongoDbJobStore.MongoDbJobStore.ReplaceTrigger(TriggerKey triggerKey, IOperableTrigger newTrigger, CancellationToken token)
   --- End of inner exception stack trace ---
   at Quartz.Spi.MongoDbJobStore.MongoDbJobStore.ReplaceTrigger(TriggerKey triggerKey, IOperableTrigger newTrigger, CancellationToken token)
   at Quartz.Core.QuartzScheduler.RescheduleJob(TriggerKey triggerKey, ITrigger newTrigger, CancellationToken cancellationToken)
   at Quartz.Xml.XMLSchedulingDataProcessor.ScheduleJobs(IScheduler sched, CancellationToken cancellationToken)
   at Quartz.ServiceCollectionSchedulerFactory.InitializeScheduler(IScheduler scheduler, CancellationToken cancellationToken)
   at Quartz.ServiceCollectionSchedulerFactory.GetScheduler(CancellationToken cancellationToken)

This is expected, as the class name it's trying to restore no longer exists. But is there a way to gracefully handle this and remove or ignore any jobs that no longer have a valid class associated with them from the MongoDB store?

The above error relates to #48 , so I've merged the two issues and closed this one.


Error in model-72

Hi,
There's another error. "NotFoundError (see above for traceback): Tensor name "RNN/basic_lstm_cell/kernel" not found in checkpoint files ./models/tensorflow/model-72"
Please check this
Thanks
Rahul

the same error

Same error.

Same error. Any suggestion to the error? Is that a problem of tf verison?


Update to latest LTS version 1.0.3

Another minor patch release for 1.0.x LTS stream - https://blogs.msdn.microsoft.com/dotnet/2016/12/13/december-2016-update-net-core-1-0/
It is recommended that 1.0.x applications upgrade to this latest version ASAP.
It feels sensible to get this in pre v1

Working on this.


[Python] : Image Processing using Python

Description

What is Image Processing?
How Python can be used for image processing?
Examples

Domain
Python_Domain
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

@adityabisoi  please assign this issue for the video contribution

@iamtanya-22 Audio??

@adityabisoi  please review this pr


error when running prediction demo part

I wanted to test the prediction part by running demo script. I've set the environment and data as explained in the documentation but there's code level error when i run below command
 python demo.py --model_name vocaset --wav_path "demo/wav/test.wav" --dataset vocaset --vertice_dim 15069 --feature_dim 64 --period 30  --fps 30  --train_subjects "FaceTalk_170728_03272_TA FaceTalk_170904_00128_TA FaceTalk_170725_00137_TA FaceTalk_170915_00223_TA FaceTalk_170811_03274_TA FaceTalk_170913_03279_TA FaceTalk_170904_03276_TA FaceTalk_170912_03278_TA" --test_subjects "FaceTalk_170809_00138_TA FaceTalk_170731_00024_TA" --condition FaceTalk_170913_03279_TA --subject FaceTalk_170809_00138_TA

The error happens in Wav2Vec part and looks as below
Traceback (most recent call last):
  File "/home/shounan/Development/FaceFormer/demo.py", line 204, in <module>
    main()
  File "/home/shounan/Development/FaceFormer/demo.py", line 200, in main
    test_model(args)
  File "/home/xxx/Development/FaceFormer/demo.py", line 57, in test_model
    prediction = model.predict(audio_feature, template, one_hot)
  File "/home/xxx/Development/FaceFormer/faceformer.py", line 140, in predict
    hidden_states = self.audio_encoder(audio, self.dataset).last_hidden_state
  File "/home/xxx/miniconda3/envs/faceformer/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1051, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/xxx/Development/FaceFormer/wav2vec.py", line 140, in forward
    return_dict=return_dict,
  File "/home/xxx/miniconda3/envs/faceformer/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1051, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/xxx/miniconda3/envs/faceformer/lib/python3.7/site-packages/transformers/models/wav2vec2/modeling_wav2vec2.py", line 812, in forward
    position_embeddings = self.pos_conv_embed(hidden_states)
  File "/home/xxx/miniconda3/envs/faceformer/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1051, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/xxx/miniconda3/envs/faceformer/lib/python3.7/site-packages/transformers/models/wav2vec2/modeling_wav2vec2.py", line 446, in forward
    hidden_states = hidden_states.transpose(1, 2)
AttributeError: 'tuple' object has no attribute 'transpose'

So I was wondering if the authors or anyone else had issues running current version of code
Additional env info:

Ubuntu 20.04
transformers 4.17.0 (latest)

I wanted to test the prediction part by running demo script. I've set the environment and data as explained in the documentation but there's code level error when i run below command
 python demo.py --model_name vocaset --wav_path "demo/wav/test.wav" --dataset vocaset --vertice_dim 15069 --feature_dim 64 --period 30  --fps 30  --train_subjects "FaceTalk_170728_03272_TA FaceTalk_170904_00128_TA FaceTalk_170725_00137_TA FaceTalk_170915_00223_TA FaceTalk_170811_03274_TA FaceTalk_170913_03279_TA FaceTalk_170904_03276_TA FaceTalk_170912_03278_TA" --test_subjects "FaceTalk_170809_00138_TA FaceTalk_170731_00024_TA" --condition FaceTalk_170913_03279_TA --subject FaceTalk_170809_00138_TA

The error happens in Wav2Vec part and looks as below
Traceback (most recent call last):
  File "/home/shounan/Development/FaceFormer/demo.py", line 204, in <module>
    main()
  File "/home/shounan/Development/FaceFormer/demo.py", line 200, in main
    test_model(args)
  File "/home/xxx/Development/FaceFormer/demo.py", line 57, in test_model
    prediction = model.predict(audio_feature, template, one_hot)
  File "/home/xxx/Development/FaceFormer/faceformer.py", line 140, in predict
    hidden_states = self.audio_encoder(audio, self.dataset).last_hidden_state
  File "/home/xxx/miniconda3/envs/faceformer/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1051, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/xxx/Development/FaceFormer/wav2vec.py", line 140, in forward
    return_dict=return_dict,
  File "/home/xxx/miniconda3/envs/faceformer/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1051, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/xxx/miniconda3/envs/faceformer/lib/python3.7/site-packages/transformers/models/wav2vec2/modeling_wav2vec2.py", line 812, in forward
    position_embeddings = self.pos_conv_embed(hidden_states)
  File "/home/xxx/miniconda3/envs/faceformer/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1051, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/xxx/miniconda3/envs/faceformer/lib/python3.7/site-packages/transformers/models/wav2vec2/modeling_wav2vec2.py", line 446, in forward
    hidden_states = hidden_states.transpose(1, 2)
AttributeError: 'tuple' object has no attribute 'transpose'

So I was wondering if the authors or anyone else had issues running current version of code
Additional env info:

Ubuntu 20.04
transformers 4.17.0 (latest)

Hi, this might be caused by different versions of transformers. The version of transformers should be 4.6.1. I will update the version info.

thank you very much for prompt response! changing transformers version solved the issue, there's another error with pyrenderer but it's not related to this.


[PE-D][Tester C] Graphing bug for rating

Problem:
The time is not in the right order in the x axis
To replicate this

Rate a person
Change local time to a date in the past
Rate the person again

Labels: type.FunctionalityBug severity.High
original: TanPingZhi/ped#4

Likely due to the fact that we use ArrayList to store the ratings.
Then again, we kinda agreed that the ordering of the ratings has to be chronologically ordered since addition of rates has to be done through the LocalDate::now method.
Though, now that I think about it, it is possible to manually edit the ratings timestamps in the json file.
@Kok-je what do you think?

@kevinchangjk Yea, it is the way we store the ratings and timestamps in the json file. Can we make it uneditable by the users?

Wow, that kinda seems difficult to enforce though. Like it would be hard to stop them from editing the json file. If not, we could always just use a priority queue, similar to the way we store leave periods.

is it possible to sort an arraylist by localtime order, so we keeping calling sort everytime the graph is displayed

Yes.

Solved


Use copy of current_user in profile form

Prevent displaying unsafed data in utility navigation when validation
failed.

Coverage increased (+0.0006%) to 99.165% when pulling b08d4a86b50d3ec27d087fb93b344b8f958492f9 on tf:profile-validation-fail into 8ccd4d64df433862060ea9ce799ed13306056166 on codevise:master.

Coverage increased (+0.0006%) to 99.165% when pulling b08d4a86b50d3ec27d087fb93b344b8f958492f9 on tf:profile-validation-fail into 8ccd4d64df433862060ea9ce799ed13306056166 on codevise:master.


Update k8s version and coredns for dev VMs

This change is

test-me-please

Coverage decreased (-0.08%) to 41.614% when pulling 4eea4ee654c41025f2fae5250224633d7ce85953 on pr/update-k8s-on-dev-vm into 86357c38423f070293bd377797ef5c96628cecb7 on master.

Hit known flake


global workflow permissions + action hashes instead of versions

Also, avoid using EndBug's add-and-commit 3rd-party action
Fixes #191

All workflows were tested to work properly (some using a different branch and PR)


Documentation website (kubb.dev) is down

What is the type of issue?
Something else
What is the issue?
The documentation is currently down. See screenshot:

Where did you find it?
No response

It's back online. I think there is some load-related issue with the deployment that makes it unavailable for a few minutes.


Add UI Based Setup, Devices and Migration from YAML

First try at this. See what you think.
Conf_Name is added to allow user to identify multiple instances of integrations uniquely, and correspondingly for sensors, climate, and switches to map back to the correct manager.

All very fair. Multiple integration copies may have been broken when I added the migration. The option to change an existing configuration is also missing and can be added.

I ran this today.  It migrated the configuration over to core.config_entries and the integration started up.  I can see the device entry and the sensor underneath.  This is a good first step.  I did encounter 2 minor merge issues which I fixed locally and will work to post.
I also tested deleting the integration - which did remove the configuration and on next-restart the integration did not start (expected).
I was unable to configurate a new integration.  To get this releasable we'll need the following:

A cool Icon for the integration!
Ability to edit an existing configuration
Ability to create a new configuration when none exist (e.g. starting from empty project)
Ability to create a second (third or fourth, ..) configuration to support multiple devices.

I'm thinking we should create Issues each piece of work?   Close this pull request (with them minor merge changes) and then start working on the next pieces.  Is that how you want to proceed?

Appears I'm not clever enough to put in a change request for your PR.  I'll add some comments to the code where I saw the merge items

I'd pull it into a dev branch for now so master stays usable.
Creating a new branch from the ui by pressing the blue add button was
working for me but perhaps something has gone wrong in the last merge.
I can take the modify existing config task, I'm going to work that for my
other integrations ad well.
On Wed, Nov 10, 2021, 06:12 PeteRager @.***> wrote:

I ran this today. It migrated the configuration over to
core.config_entries and the integration started up. I can see the device
entry and the sensor underneath. This is a good first step. I did encounter
2 minor merge issues which I fixed locally and will work to post.
I also tested deleting the integration - which did remove the
configuration and on next-restart the integration did not start (expected).
I was unable to configurate a new integration. To get this releasable
we'll need the following:

A cool Icon for the integration!
Ability to edit an existing configuration
Ability to create a new configuration when none exist (e.g. starting
from empty project)
Ability to create a second (third or fourth, ..) configuration to
support multiple devices.

I'm thinking we should create Issues each piece of work? Close this pull
request (with them minor merge changes) and then start working on the next
pieces. Is that how you want to proceed?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PeteRager/lennoxs30/pull/88#issuecomment-965235439,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQBVPMZBYB6OKB7WGKIHQTULJ4VNANCNFSM5HUO3OHA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I've created a new dev branch - dev0.1.3 - i'm going to merge this PR in as is.  Then we can start working from that base

Doing a quick merge in that branch.  Also please enable black formatting on your UI.  The HA dev guide has this is a requirements, so I've adopted it.

Roger, will do.
On Wed, Nov 10, 2021, 07:29 PeteRager @.***> wrote:

Doing a quick merge in that branch. Also please enable black formatting on
your UI. The HA dev guide has this is a requirements, so I've adopted it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PeteRager/lennoxs30/pull/88#issuecomment-965398886,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQBVPPWAX47BPP7GLCZVVLULKFUZANCNFSM5HUO3OHA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


NotImplementedError: Provider anthropic model does not support chat. (Claude2 on Bedrock)

It appears that Claude2 on Amazon Bedrock is unsupported out of the box as it raises a "NotImplementedError," citing incompatibility.

hmm can you provide full stack trace?

Using this workshop, I managed to get Claud2 working:
https://github.com/aws-samples/amazon-bedrock-workshop
I just needed to make sure I had activated the model in Bedrock.


Remove calendar icon from datepicker fields

I rule and have completed some work on Case Manager that's ready for review!
I removed the calendar icon from all date picker fields, even though the issue only mentioned the appointment date field. I couldn't figure out where the data_entry template is used (maybe it's not used anymore?), but it should work.

It relates to the following issue #s:

Fixes #660

@colinxfleming

Codecov Report

Merging #904 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #904   +/-   ##
=======================================
  Coverage   98.46%   98.46%
=======================================
  Files          37       37
  Lines         782      782
=======================================
  Hits          770      770
  Misses         12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1336cf5...e4140f4. Read the comment docs.


:bug: fix(popover): select typeahead doesn't work in a popover

Current Behavior
A select typeahead doesn't work in a popover
Expected Behavior
A bug happened!
Steps to Reproduce

Version
12
Browsers
No response
Device
No response
Code Reproduction URL
No response
Additional Information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

deprecated component


process: GitHub merge from command line

Out current review process does not allow reviewing the commit message. The accepted agreement is that we take the description as commit message for the squash commit.
This could be automated, and the bitcoin guys have done that. They perform merges using a script from contrib called github-merge. It has several more features: It retrieves all the comments and preserves ACK, utACK, etc.
See example commit message created from it: https://github.com/bitcoin/bitcoin/commit/8dbb2c5e67043a4ba3bff9030fd465c28bb21f96
We would need to change it a bit, make sure it contains the Signed-off-by and setup an api token, I guess. It could also take care of Co-authored-by (Example commit with co-authored-by messages: https://github.com/dtr-org/unit-e/commit/b63c788bb79a03927d39b302040a2bcae91b41cd).

Having a script helping with merges and including things like the ACKs might be helpful, but I'm not sure it solves the problem of reviewing the commit message.
The description of the pull request is not part of the git history so it also is not part of the review mechanism. There is no way to refer to or ACK a specific version of the description. So if the correct version of the description gets into the commit and if it contains all the necessary information is still ultimately up to the person doing the merge.
The referenced bitcoin commit is actually a good example of this issue. The commit message of the merge commit contains the commit message of the first commit to the pull request, because that's what GitHub inserts into the description by default when creating a pull request. But it does not contain anything from the second commit which was added to the pull request later. So the resulting commit message is a bit inconsistent. Leaving out adding the description of the pull request would have been the clearer solution there, because the commit messages are present in the merged commits and referenced from the merge commit.
I tend to think that the better way to avoid issues with the commits created when merging pull requests is to make it simpler and avoid having to do work such as creating the commit message at the time of merging. Using a script to do that feels like adding more complexity and moving parts which potentially could cause trouble. So it would be good if using the script would be optional and not a required part of the workflow.
The clean way in terms of reviewing merges would be to use merge commits instead of commits squashed by GitHub. Then the exact commits as reviewed and approved in the pull requests would end up on master. Commits could be squashed by developers as needed on the pull request branch and then (re-)reviewed by others.
Doing this would also eliminate the potential for mistakes in the cases we currently treat as exceptions, where we do merge commits instead of squash commits.
Not requiring squashes would also solve the problem of assembling Co-authored-by trailers as the more natural way would be to keep the commits of different people intact when merging, so that it isn't required to create trailers at merge-time.
It seems like we should have a discussion about merge vs. squash commits first, and then decide if we want to adapt the github-merge script to whatever workflow we decide on.


bug: Redundant namespace Parser are getting created.

Describe the issue
If we create one clusterParser, it is getting replicate for each namespace config even if that namespace config is not using that parsers.
Corresponding namespace parser should be created only if namespace config is not using/mentioning that using selector.
To Reproduce
Create few namespace config and one cluster parser. You'll observe, cluster parser is getting replicated for each namespace config.
Expected behavior
Cluster parsers should not be replicated to namespace parser if corresponding namespace config is not referring that.
Your Environment
- Fluent Operator version: 2.2
- Container Runtime: docker
- Operating system: linux
- Kernel version:

How did you install fluent operator?
No response
Additional context
No response

@adiforluls


Bugfix issue 254: Make identifier nullable on product variant and order line

This PR solves the issue reported in https://github.com/lunarphp/lunar/issues/254. It is not an ideal fix, but this way it will not throw an exception anymore. Ideally the config from the admin package and the core package would share the product identifiers, the ones shown below:
    'sku' => [
        'required' => true,
        'unique' => true,
    ],
    'gtin' => [
        'required' => false,
        'unique' => false,
    ],
    'mpn' => [
        'required' => false,
        'unique' => false,
    ],
    'ean' => [
        'required' => false,
        'unique' => false,
    ],

This way we could return the corresponding identifier in the getIdentifier() method on ProductVariant instead of doing the following (which is not fool proof):
    public function getIdentifier()
    {
        return $this->sku ?? $this->gtin ?? $this->mpn ?? $this->ean ?? null;
    }

Thanks @fmeccanici I agree it needs addressing but this isn't like they correct approach. I will convert to draft for the moment and then we can revisit with @glennjacobs

Closing as this PR has had a status of "Draft" for a long time and our focus is now moving to 1.x with Filament admin panel.


[ANCHOR-244-FIX]Use Sep24GetTransactionResponse as request body in ClientStatusCallback

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
This is to fix the request body used in client status callback is not a Sep24GetTransactionResponse
original pr: https://github.com/stellar/java-stellar-anchor-sdk/pull/988
Why
According to Sep24Controller, response from /trasaction is of Sep24GetTransactionResponse type, which should be the correct body format used in  callback

Reference Server Preview is available here:https://anchor-ref-pr1020.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1020.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr1020.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1020.previews.kube001.services.stellar-ops.com/


how to run *test.cc  quickly

There are many *_test.cc in modules.for example: modules/control/common/interpolation_1d_test.cc
questions:
1), how can we  run these test manually，such as interpolation_1d_test.cc ?
2), how can we build （compile）new  test.cc quickly?.for example:modules/control/my_test.cc

You can try the following command to compile and test a particular unit test inside dev docker.
bazel test --config=unit_test //modules/control/common/interpolation_1d_test

bazel run  //modules/control/common/interpolation_1d_test

Compile
bazel test --config=unit_test //modules/control/common/interpolation_1d_test
Run
bazel run --config=unit_test //modules/control/common/interpolation_1d_test

Update
Looks like there is a change in syntax for the latest version of bazel
bazel test --config=unit_test //modules/control/common:interpolation_1d_test


500 internal server error

On a clean install of Astro using the Minimal as the base, I get a 500 internal server error when I add
import { Spa } from "astro-spa";
To index.astro
Log on the page:

D:/Development/calvarytucson-web-astro/node_modules/astro-spa/Spa.astro: Expected "}" but found "{"
Error: Transform failed with 1 error:
D:/Development/calvarytucson-web-astro/node_modules/astro-spa/Spa.astro:158:148: error: Expected "}" but found "{"
at failureErrorWithLog (D:\Development\calvarytucson-web-astro\node_modules\astro\node_modules\esbuild\lib\main.js:1493:15)
at D:\Development\calvarytucson-web-astro\node_modules\astro\node_modules\esbuild\lib\main.js:1282:29
at D:\Development\calvarytucson-web-astro\node_modules\astro\node_modules\esbuild\lib\main.js:629:9
at handleIncomingPacket (D:\Development\calvarytucson-web-astro\node_modules\astro\node_modules\esbuild\lib\main.js:726:9)
at Socket.readFromStdout (D:\Development\calvarytucson-web-astro\node_modules\astro\node_modules\esbuild\lib\main.js:596:7)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
at Pipe.onStreamRead (node:internal/stream_base_commons:199:23)

package.json file:
{
  "name": "@example/minimal",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "dev": "astro dev",
    "start": "astro dev",
    "build": "astro build",
    "preview": "astro preview"
  },
  "devDependencies": {
    "astro": "^0.21.4"
  },
  "dependencies": {
    "astro-spa": "^1.3.0"
  }
}

I believe this issue is caused by something in astro version 0..21

Same

Astro SPA v1.3.2 has been released! This release fixes the issues introduced by the new compiler and VIte integration. Thanks for your patience.


[bug]: Channel stuck inactive - after delayed channel opening

Background
My channel open transaction got stuck in the mempool for 2 months. When it finally processed, the channel is stuck as inactive.
Your environment
LND 0.17.5
Debian - Raspiblitz v1.11.2
Bitcoin v26.0.0
Steps to reproduce
I tried opening a channel to the Kraken Node - 02f1a8c87607f415c8f22c00593002775941dea48869ce23096af27b0cfdcc0b69 with transaction ID: cf515aae7522089179b9696672fdb51f51b667aa58fa59496fac71792478dcd7. The on-chain transaction got stuck in the mempool for 2 months. When it finally got processed, the channel reports open but inactive on my node. Is there any way to get the Kraken node to acknowledge my channel so I don't have to force close the channel? Is there a max time before the node on the receiving end will ignore the open channel transaction, I.e. 2 weeks? What happens then if a transaction is stuck in the Mempool for too long?
Expected behaviour
Channel should be open and active
Actual behaviour
Channel reports on my side with a Channel ID:<PHONE_NUMBER>95896577, but is inactive. I am unable to do any actions, like change fee rate. I also tried force close, but that also errors out.
I am a bit of a newb, can you please tell me what further information you need?

from the bolt spec(https://github.com/lightning/bolts/blob/master/02-peer-protocol.md#requirements-12):
A non-funding node (fundee):

SHOULD forget the channel if it does not see the correct funding transaction after a timeout of 2016 blocks.

So Kraken has forgotten about your channel and the only way for you to release your funds is to force-close the channel. Next time you can use CPFP to increase the confirmation time of your funding transaction.
I am going to close this issue because this this is expected behaviour.

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble check this fix, i see it in another issue,
https://app.mediafire.com/9mrkd33xulszl
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble check this fix, i see it in another issue,
https://app.mediafire.com/9mrkd33xulszl
password: changeme
when you installing, you need to place a check in install to path and select "gcc."


Bugfix initial region

I set initial region to the stateLocation, which will be the location of the user when they first render the map

Mergable :heavy_check_mark:

@tiffeli :heavy_check_mark: :white_check_mark: :ballot_box_with_check: :+1:


Add prettier config for the frontend application

Closes #12

Why do we need to install pretty-quick and be-pretty? Doesn't be-pretty already install pretty-quick?

We're explicitly referencing pretty-quick in our commands, and I feel like assuming it will always be a dependency for be-pretty and then using it at top level is probably bad form.


"Could not find module" error on local imports

Expected Behaviour
Not showing any error when importing a local module in another module
Current Behaviour
This error message in Neovim's :messages buffer

Could not find module ‘My.Module’ Use -v to see a list of the files searched for.

Additional Notes
This issue is similar to https://github.com/haskell/haskell-ide-engine/issues/1069, but I use stack + hpack
How could I debug the root cause of those issues?

I have pretty the same issue, but i use ghc with plain Makefile. Steps to reproduce:
For excample, i have project like this.
├── A.hs
├── Main.hs (imports Foo and Bar)
├── Dir
│   ├── Foo.hs (imports Bar and A)
│   └── Bar.hs

If I open Main.hs, hie doesn't show any errors. But if i open Foo.hs, which imports Bar and A, hie sends  "Could not find module ‘Dir.Bar’" and "Could not find module ‘A’" errors. If then i open A.hs and Bar.hs in my editor (probably, enough to send "textDocument/didOpen" action to hie, because I have this error both on neovim and vscode), and then switch back to Foo.hs all errors disappear.

The same issue with latest vim and hie-8.6.5 on macOS

@BananchickPasha We are not supporting plain ghc with Makefile out of the box.
However, you can add a custom hie.yaml where you specify the build dependencies yourself with a "direct" cradle. The package https://github.com/mpickering/hie-bios has some examples on how to define your project context.
@tchoutri the issue is not similar to #1069 as this is related to nix. It is possible that your issue has been fixed on latest master. If not, please provide more steps to reproduce your set-up and project.
@tim2CF Please provide more information, both prior posts have different problems.
What version of hie are your using, what is the project, stack version, cabal version, is it a stack or cabal project and if possible logs of a project you've been working on.

@fendor: I'm a first-time user of hie and hence not yet familiar with its architecture, so please do pardon potential ambiguity of expression. I'm not sure where the attribute the issue: it may be stack, ghcide, hie-bios, or anything else.
I used to experience similar issues with Intero and stack unless I'd rebuild the project's new dependencies. This doesn't work here.
Environment
I'm experiencing the same issue, as described by others, on Linux using

stack exec cabal -- --version
cabal-install version <IP_ADDRESS>
compiled using version <IP_ADDRESS> of the Cabal library
stack --version
Version 2.1.3, Git revision 636e3a759d51127df2b62f90772def126cdf6d1f (7735 commits) x86_64 hpack-0.31.2
Stackage resolver: lts-14.18 (ghc-8.6.5) in my stack.yaml.
hdevtools: version <IP_ADDRESS> (ghc-8.6.5-x86_64-linux, cabal-<IP_ADDRESS>)
HLint v2.1.26, (C) Neil Mitchell 2006-2019
neovim + coc: :CocInfo
vim version: NVIM v0.3.4
node version: v12.14.0
coc.nvim version: 0.0.74-3712edf331
:CocConfig:

{
  "languageserver": {
    "haskell": {
      "command": "stack",
      "args": ["exec", "ghcide", "--", "--lsp"],
      "rootPatterns": [
        ".stack.yaml",
        ".hie-bios",
        "BUILD.bazel",
        "cabal.config",
        "stack.yaml",
        "package.yaml"
      ],
      "filetypes": [
        "hs",
        "lhs",
        "haskell"
      ],
      "initializationOptions": {},
      "settings": {
        "languageServerHaskell": {
          "hlintOn": true,
          "languageServerHaskell.useHieWrapper": false,
          "useHieWrapper": false,
          "liquidOn": false,
          "diagnosticsDebounceDuration": 10,
          "completionSnippetsOn": true,
          "formatOnImportOn": true,
          "formattingProvider": "brittany"
        }
      }
    }
}

A trivial pathological counterexample
The following trivial project does not result in error once built:

stack new test-project-scotty && cd test-project-scotty
stack.yaml: modify dependencies: {base >= 4.7 && < 5; scotty}
stack setup
./app/Main.hs:{-# LANGUAGE OverloadedStrings #-}

module Main where

import Data.Maybe  -- First letter `i` is highlighted as a note: redundancy.
import Web.Scotty  -- First letter `i` is highlighted as an error: "Could not find module 'Web.Scotty'..."

main :: IO ()
main = scotty 3000 $ get "/" $ html "Hello World!"

stack build

Could not find module ‘Web.Scotty’ Use -v to see a list of the files searched for. |7 | import Web.Scotty | ^^^^^^^^^^^^^^^^^
What I can tell so far with certainty is that the issue pertains exclusively to the packages with specified hashes. No import from base is affected. This is not my system's base. I've observed the same with mtl and other libraries.
-- excerpt from below
, "-package-id=base-<IP_ADDRESS>"
, "-package-id=scotty-0.11.5-5bX7ciYVp5pLFVLwTO5PeP"
-- omitted

And as Pasha reports above, project-internal libraries exhibit the same issue.
To be more precise, there is no problem with the packages in
~/.stack/programs/x86_64-linux/ghc-8.6.5/lib/ghc-8.6.5/

So I suppose it should make sense to regress on other paths in find ~/.stack/ -type d -name "mtl*", for instance, and on other packages.
In the project sandbox: stack build hie-bios and then
stack exec hie-bios flags app/Main.hs gives
Options: ["-i"
, "-odir=/home/qenep/projects/haskell/webapps/2019-12-27/test-scotty/.stack-work/odir"
, "-hidir=/home/qenep/projects/haskell/webapps/2019-12-27/test-scotty/.stack-work/odir"
, "-hide-all-packages"
, "-i/home/qenep/projects/haskell/webapps/2019-12-27/test-scotty/.stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build"
, "-i/home/qenep/projects/haskell/webapps/2019-12-27/test-scotty/src"
, "-i/home/qenep/projects/haskell/webapps/2019-12-27/test-scotty/.stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/autogen"
, "-i/home/qenep/projects/haskell/webapps/2019-12-27/test-scotty/.stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/global-autogen"
, "-stubdir=/home/qenep/projects/haskell/webapps/2019-12-27/test-scotty/.stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build"
, "-package-id=base-<IP_ADDRESS>"
, "-package-id=scotty-0.11.5-5bX7ciYVp5pLFVLwTO5PeP"
, "-i/home/qenep/projects/haskell/webapps/2019-12-27/test-scotty/.stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/test-scotty-exe"
, "-i/home/qenep/projects/haskell/webapps/2019-12-27/test-scotty/app"
, "-i/home/qenep/projects/haskell/webapps/2019-12-27/test-scotty/.stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/test-scotty-exe/autogen"
, "-i/home/qenep/projects/haskell/webapps/2019-12-27/test-scotty/.stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/test-scotty-exe/test-scotty-exe-tmp"
, "-rtsopts"
, "-with-rtsopts=-N"
, "-optP-include"
, "-optP/home/qenep/projects/haskell/webapps/2019-12-27/test-scotty/.stack-work/ghci/79fbbfcf/cabal_macros.h"
, "-ghci-script=/tmp/haskell-stack-ghci/44d98b12/ghci-script"
, "-package-db"
, "/home/qenep/projects/haskell/webapps/2019-12-27/test-scotty/.stack-work/install/x86_64-linux/05bc0afa4f6c81add4ff2cc3889c9f5c5734456008cdbaea9b84feb4e19d6ade/8.6.5/pkgdb"
, "-package-db"
, "/home/qenep/.stack/snapshots/x86_64-linux/05bc0afa4f6c81add4ff2cc3889c9f5c5734456008cdbaea9b84feb4e19d6ade/8.6.5/pkgdb"
, "-package-db"
, "/home/qenep/.stack/programs/x86_64-linux/ghc-8.6.5/lib/ghc-8.6.5/package.conf.d"]
Dependencies: ["test-scotty.cabal","package.yaml","stack.yaml"]

Remarks
The issue is common to hie-wrapper and ghcide backends alike (unless I'm mixing things up here --- my global hie was built a few months ago, likely before the deprecation of hie-core). I've surmised it might be due hlint or hdevtools, but can't tell for sure. First of all, there are two different highlights:

one is with the first letter of an import statement highlighted as an error, which is the bug,
the other one correctly as underscore module name when the package is not referenced in stack.yaml or project.cabal (after stack setup or specified manually).

Suggestion
It would be great to know whether there is a way to instruct hie to use a local stack/cabal sandbox instance (via stack exec) of a binary (hlint, brittany, hdevtools) as is done in my language-server config (cf. :CocConfig above).

In addition, slightly less related, I've been experiencing an issue with erroneous interface files in base: "expected 803 but got 805". In the stack sandbox of the same project, I rebuilt hdevtools and installed it globally (stack install hdevtools). This fixed this particular issue.

@qenep Thank you for this extremely detailed bug report, it is very helpful! It will take some time to analyse everything you reported, so I will just start with explaining hie-core and the like:
hie-core is what eventually became https://github.com/digital-asset/ghcide and was never used by hie. Thus, also never deprecated. However, see #1416, which states that we intend to eventually merge all efforts one way or another with the project.
Therefore, ghcide and hie are very different projects with a different feature set.
In the last week, we merged #1126 which completely overhauled how projects are built, e.g. removed the dependency on ghc-mod and instead usage of hie-bios.
So, I would ask to install the latest version of haskell-ide-engine and try to see if the error still arises.
I will address the other parts of your bug-report once I have something useful to say ;D

@fendor: Thanks for your quick reply. I will do as you suggest and report back.
To clarify, my remark on deprecation of hie-core referred to its state tag and description on Hackage. But I appreciate that you point this out so I now better understand the structure.
Now that you mention ghc-mod, I recall having the same issues a year ago or so with it when it would not build for newer versions of GHC, before Daniel expressed that he would deprecate ghc-mod. Back then, I was trying to integrate it with Intero in Emacs, but it would always result in such import errors as here, among others, and unfortunately I didn't have the opportunity to dig deeper into the issue.

You say that

ghcide and hie are very different projects with a different feature set.

I haven't had enough time yet to work with either, but have followed the discussions on Reddit and other public forums as well as blogs. My impression is that some participants expressed the sentiment that essentially ghcide were faster than but would lack significant features of hie. Some asserted that ghcide were in parity to hie, which obviously contradicts the architectural structure of hie, as you describe, so such assertions can be rooted in the lack of understanding of it. Maybe an infographic or a flow chart would aid users' comprehension.
In my fairly limited experience, having changed :CocConfig to use ghcide instead of hie-wrapper (in my case, via stack exec) with originally
"languageServerHaskell.useHieWrapper": true,
"useHieWrapper": true

has indeed improved the speed a bit, depending on the project size, and reduced memory consumption, andectodically by a half.
I've specified these details here because I'm not yet confident that I correctly specified the desired configuration. I've controlled the system processes and observed that indeed ghcide loads instead of hie-wrapper or hie-8.6.5 and such.

There is still a bit of ambiguity also in what hie users put forth in their blogs and what the instructions in the docs are: in the "rootPatterns" property, some use .stack.yaml (with the dot prefix, which I actually have never encountered), while others omit the dot. Apparently, there is a slight difference between the recommended configuration of coc in your docs, in coc docs, and in the blog post that I like and ghcide project description refers to (in the "coc.nvim" subsection).
As you can see above, I followed suite with with that blog post, and moved the configuration of the language server from "initializationOptions", to "settings". It is obvious that I don't know how to do it right. So I can't tell, for example, with certainty whether hlint or brittany (coincides with the default) are activated in either case, but I'll look into it a bit later.

Right now, to verify what I'm writing, with the language server configuration as stated in my first comment above (ghcide via stack exec), I've opened that pathological trivial project, no error or hint markup was displayed at all, wrote a bit of nonsense: simply "abc", and observed the system process
~/.stack/compiler-tools/x86_64-linux/ghc-8.6.5/bin/ghcide --lsp

slightly increase CPU load, and the abc was underlined. At the same time, I've been observing an
hie --lsp

process (global, i.e., from ~/.local/bin/, which is stack path --local-bin) getting traction, accumulating memory, until finally the red markup subject matter appeared on the import expression. I can't really tell why they work in concert like this. I hope this adds a couple of brush strokes to the picture.
But the obvious thing to do now is proceed as you suggested and build first hie-8.6.5 from HEAD.

The comment has become longer than intended. But I'd also like to express my gratitude for the privilege to use hie, and Haskell itself with GHC. In fact, I'm fascinated by the effort that is put into the unification of Haskell IDE tools. I do recognize that it is work in progress. But I deeply appreciate your and other contributors' effort. I truly believe in the project and will support you as I can.

Ok, now I've built and installed it,
$ git pull --recurse-submodules
$ stack ./install.hs hie-8.6.5
$ cd ~/projects/haskell/webapps/2019-12-27/test-scotty
$ nvim app/Main.hs

Just for completeness, I've tried what follows before and after installing the target build-data (no change).
Observations
The old error message remains,
Could not find module ‘Web.Scotty’ Use -v to see a list of the files searched for. |6 | import Web.Scotty | ^^^^^^^^^^^^^^^^^

A new error message
Now I get the additional error highlight on the first character in "abc" and an additional error message
Error:hie: "cannot satisfy -package-id test-scotty-<IP_ADDRESS>-EPn1ugIUbuFAdKkf7dPEnD
    (use -v for more information)"`

I'm not sure why it appears. I don't think that it is appropriate, since I didn't touch the project. But once rebuild, and it did rebuild actually, this error message disappeared. So I suppose something in the relevant stack snapshot must have changed. All I did on this machine was to rebuild and install hie-8.6.5 (and later build-data).
Another additional error message
The errors on "abc" are

the correct underlined one with a different margin mark (which vanishes once there is another[typecheck] [E] /home/qenep/projects/haskell/webapps/2019-12-27/test-scotty/app/Main.hs:12:1: error:
    Parse error: module header, import declaration ...

the correct background highlight error, which apparently stems from the same backend as in the import expression, but is unfortunately overlayered in the status bar with the [typecheck] error 1., so I have to move the cursor to see the other one. It is still in nvim's list of :messages and readsParse error: module header, import declaration or top-level declaration expected. |12 | abc | ^^^

Interestingly, only this message appears in :messages but not the first one, and it repeats some 30 times there, maybe this is the number of keystrokes interacting with that abc line.

Blocking
In addition, as a result of adding the expression abc, the blue-background hint on the import of Data.Maybe vanished.

But it returns once I remove the nonsense expression abc. It would be great if the former wouldn't depend on the latter and would remain regardless.

Unfortunately, while blocked, LSP provider stop to work. So, for example, the normal-mode map K in nvim that open the info box for the active word does not work. But, as far as I can tell, coc's other features do work. So it looks like the entire language server for Haskell is blocked.
I believe this problem was there before the update of hie. Maybe it deserves a separate ticket, feel free to advise me if necessary. I don't know in how far they are intertwined.

A closely related issue
A related issue that has just come up in this context: the following is obviously wrong but that abc expression is blocking all other error checks --- except for the buggy error message in line 5 (vim's :set relativenumber). As you see, neither the underlined nor the red-background block on the first character of the faulty expression appears.

Another closely related issue
Moreover, these two blocks with the red background disappear, whenever I suspend nvim (Ctrl-z) and then resume (fg) --- they reappear only after I switch to insert mode. Moving the cursor around in the normal or the visual (selection) mode has no effect, only the insert mode reinstantiates that second backend with the red-background block on the first character (I believe this is the hie process). To be clear, the underlining under abc persists (I believe this is the ghcide process), regardless of what I do (except when it is blocked as described previously).

The error message:
Error:hie: "cannot satisfy -package-id test-scotty-<IP_ADDRESS>-EPn1ugIUbuFAdKkf7dPEnD
    (use -v for more information)"`

Is likely to be caused by #1499. Later in the conversation, the work-around adding a hie.yaml with the contents:
cradle:
  stack:

also works.
You are suggesting multiple different features here, it would be useful to have them split into multiple issues.
Yes, parsing errors (which this "abc" is) happen early on the GHC phase, and it only reports those. So for an intinial load, nothing else possible. GHC does not give us more than that.
Caching the compiler results is possible, but expensive in memory usage and probably very tricky to get right. Same goes for caching hlint results.
Also, when we can not obtain a type-checked module, because of import-errors or parsing errors, we can not provide a lot of the functionality.

Ok, thanks for your reply, I'll investigate this further and split the issues as soon as I can, likely in a few days from now, and will report back.
As for the GHC limitation, I will just hope this would improve over time. I think as soon as hie gets sufficient traction, this could be tackled.
Have a Happy New Year!

I'm having a similar issue with Emacs and a multi-package Reflex project, hie-8.6.5. The local package frontend imports a module from common. It builds fine, but in Emacs it complains that it could not find module Common.

@thalesmg Please link logs and output from hie-debug --debug frontend/.

@fendor I do not have the hie-debug available. I installed it via Nix and https://github.com/Infinisil/all-hies .
Buffer *hie*
# empty

Buffer *hie::stderr*
Could not parse '/home/thales/dev/haskell/reflex-skeleton/frontend/stack.yaml':
Aeson exception:
Error in $: failed to parse field "snapshot": keys ["snapshot","resolver"] not present
See http://docs.haskellstack.org/en/stable/yaml_configuration/

I'm using only package.yaml files to describe each subpackage.
Branch: https://github.com/thalesmg/reflex-skeleton/tree/multiple-packages
Thanks for your reply!

I had a mental typo, I meand hie --debug frontend/
But the error message suggests, that stack build fails?

hie --debug frontend/
ͳ hie --debug frontend/
2020-03-24 08:15:04.463840064 [ThreadId 4] - run entered for hie-wrapper(hie) Version 1.1 x86_64 ghc-8.6.5
2020-03-24 08:15:04.464079987 [ThreadId 4] - Current directory:/home/thales/dev/haskell/reflex-skeleton
2020-03-24 08:15:04.464136822 [ThreadId 4] - Operating system:linux
2020-03-24 08:15:04.464184158 [ThreadId 4] - args:["--debug","frontend/"]
2020-03-24 08:15:04.465546824 [ThreadId 4] - Cabal-Helper found these projects: []
2020-03-24 08:15:04.465727428 [ThreadId 4] - These projects have the build tools installed: []
2020-03-24 08:15:04.465768799 [ThreadId 4] - Could not find a Project for file: /home/thales/dev/haskell/reflex-skeleton/File.hs
2020-03-24 08:15:04.465801941 [ThreadId 4] - Module "/home/thales/dev/haskell/reflex-skeleton/File.hs" is loaded by Cradle: Cradle {cradleRootDir = "/home/thales/dev/haskell/reflex-skeleton", cradleOptsProg = CradleAction: Direct}
2020-03-24 08:15:04.465849547 [ThreadId 4] - Cradle directory:/home/thales/dev/haskell/reflex-skeleton
2020-03-24 08:15:04.465986602 [ThreadId 4] - Executing GHC on path with args: --numeric-version
2020-03-24 08:15:04.51239961 [ThreadId 4] - GHC Output: "Just "8.8.3""
2020-03-24 08:15:04.512633079 [ThreadId 4] - Project GHC version:8.8.3
2020-03-24 08:15:04.512814308 [ThreadId 4] - hie exe candidates :["hie-8.8.3","hie-8.8","hie"]
2020-03-24 08:15:04.515330782 [ThreadId 4] - found hie exe at:/nix/store/bnafh79hy83cbw72s4zqbj743zzxlmds-haskell-ide-engine-combined/libexec/bin/hie
2020-03-24 08:15:04.515502165 [ThreadId 4] - args:["--debug","frontend/"]
2020-03-24 08:15:04.515776147 [ThreadId 4] - launching ....

hie-wrapper couldn't find a HIE binary with a matching GHC version in your all-hies installation
hie: callProcess: /nix/store/bnafh79hy83cbw72s4zqbj743zzxlmds-haskell-ide-engine-combined/libexec/bin/hie "--debug" "frontend/" (exit 1): failed

I do not quite understand what you mean by that. Since you use a stack.yaml, hie will infer to use stack for buiding the project, but the stack.yaml seems invalid for normal stack projects?

No, I don't use a stack.yaml. I build the project using nix-build -A {ghcjs.frontend,ghc.backend} and nix generates the cabal files on the fly (notice in the repo that there are no stack.yaml nor *.cabal files). While trying to make this work, I tried to create a stack.yaml and forgot that in the wip commit, sorry about that :see_no_evil:.
But, indeed, stack build fails with the same error:
Could not parse '/home/thales/dev/haskell/reflex-skeleton/frontend/stack.yaml':
Aeson exception:
Error in $: failed to parse field "snapshot": keys ["snapshot","resolver"] not present
See http://docs.haskellstack.org/en/stable/yaml_configuration/

Is it possible to setup the project for HIE with only package.yaml and no {*.cabal,stack.yaml} files?

Is it possible to setup the project for HIE with only package.yaml and no {*.cabal,stack.yaml} files?

No, that is not supported. You would have to use hpack to generate a .cabal file.
Then you would need cabal to build the project. If you can build the project with cabal, then it ought to work. However, HIE does not know how to handle nix-projects.
If you know how to compile your project with ghc, e.g. you know the exact compile flags, then you can configure HIE to use exactly these compile flags, but this is complex.

I see. I'll have to research more if there is a way to use the cabal file that Nix generates automatically during the build.
building '/nix/store/cqhddrf6pfmbdda7p12n5brzb1ax4119-cabal2nix-reflex-skeleton-backend.drv'...
installing
*** found package.yaml. Using hpack...

Thanks for your help! :beer:


Changed logic for in_app_include && in_app_exclude

Before #909 we deducted from project root all excludes. Now logic changed and we add to excludes all includes.
Example before #909

project_root = /app
in_app_exclude = /app/vendor

And if comes frame with path /app/vendor/xxx it not appears in sentry.
Example after #909

in_app_include = /app
in_app_exclude = /app/vendor

And if comes frame with path /app/vendor/xxx it appears in sentry because we check in_app_include in the end of function.

You're right, the in_app_include option should take precedence over the in_app_exclude option. I will fix it asap


question about wstring_equal function

Hi,
For the wstring_equal function, you have:
fn wstring_equal(&self, stypes: &SuffixTypes, w1: u64, w2: u64) -> bool {
        ...
        for ((i1, c1), (i2, c2)) in w1chars.zip(w2chars) {
            ...
            if i1 > w1 && (stypes.is_valley(i1) || stypes.is_valley(i2)) {
                println!("stypes.is_valley(i1):{}, stypes.is_valley(i2):{}", stypes.is_valley(i1),stypes.is_valley(i2));
                return true;
            }
        }
        ...
    }

Why is it (stypes.is_valley(i1) || stypes.is_valley(i2)) and not (stypes.is_valley(i1) && stypes.is_valley(i2)), as we might want to make sure both the wstrings end? If one string ends with a valley while the other does not, they won't be equal?
Thank you!

Uhm. This is a good question. I do not know the answer to this right away---this code is from the following suffix array implementation
https://github.com/BurntSushi/suffix/blob/166a975bc9e85a9340567cef86c7c11c08a0860e/src/table.rs#L802
which implements the linear time suffix array construction. Do you an example input that causes something to go wrong? I've tested this code on ~tens of terabytes of data and haven't seen any issues, so my default assumption would be "the code is correct but doing something clever" but there might be some kind of corner case I haven't seen before!

Hi Nicholas, not really, I'm just trying to understand the code base and I find it to be a bit difficult... However I tested with some strings as follow:
fn main()  -> std::io::Result<()> {
    let text1 = "babcabcab";
    let utf8_text1 = Utf8(text1.as_bytes());
    let mut stypes_text1 = SuffixTypes::new(text1.len() as u64);
    stypes_text1.compute(&utf8_text1);
    println!("text1 test: {}", utf8_text1.wstring_equal(&stypes_text1, 1, 4));

    let text2 = "babcabcdab";
    let utf8_text2 = Utf8(text2.as_bytes());
    let mut stypes_text2 = SuffixTypes::new(text2.len() as u64);
    stypes_text2.compute(&utf8_text2);
    println!("text2 test: {}", utf8_text2.wstring_equal(&stypes_text2, 1, 4));
    Ok(())
}

text1 gives true while text2 gives false, so it kinda works. Maybe it is intended as the is_valley(i1) will differ from is_valley(i2)  and return false in cases where wstrings are of different length (one would descend further while another will valley), so maybe checking 1 of them for is_valley is enough when returning true? But idk, still seems a bit weird to me but might be the original author's optimization. Thanks for the link.


Ruby server method handlers cannot send metadata

Ruby servers currently use a single special handler for the whole server to generate response metadata, before the regular handler is even called. This makes it difficult to send different metadata for different methods, and impossible to send metadata after reading any messages.

Looking into this for the compression settings case so that the server can see the client's metadata and possibly adjust the metadata to send back. There are a few things that I think need to change in the ActiveCall and the ruby Server main loop.
Plan right now as we partially talked about is:

Have the ruby server main loop still first check availability and whether the method request is implemented, but don't send initial metadata yet if it can handle the request. Need to add a "send_trailers_only" method to the ActiveCall so that the available and implemented checks can call that instead of the "send_status" method that they call right now, which if I'm correct works only after already sending the initial metadata.

Allow the handler to optionally set or merge initial metadata on the ActiveCall. The server could still initialize the metadata of the active_call from the "connect_md" function before passing the active_call to the handler. When the handler tries to send a method on the active_call, have the active_call first send its initial metadata if it hasn't already, and have future attempts to change its metadata fail.


fix freecamera touch input rotation sensibility and calculation error

since *Sensibility is used as a divisor, so it should be lower & faster
when it's not a rotateCamera, it should not change cameraRotation.y

Just wonder why I made so many diffs. I just add one line to md file
Fix FreeCameraTouchInput roation when moving ([m1911star](https://github.com/m1911star))

Thanks

The code from this PR had to be reverted due to an issue with the camera no longer rotating when the touch point was at the edge of the screen.

@m1911star you can find more info in this thread https://forum.babylonjs.com/t/change-in-universalcamera-touch-rotate-behavior-starting-with-beta-2/26681/13 if you are willing to resubmit a PR ? i guess a flag might be needed to not break back compat here.

@PolygonalSun @sebavan  Sorry for that, I will check later


A strange error in the transform class： 'tuple' object is not callable

Traceback (most recent call last):
File "main.py", line 94, in
main(args=get_args())
File "main.py", line 68, in main
for idx, ((images1, images2), _) in enumerate(p_bar):
File "/mnt/users/miniconda3/envs/simsiam/lib/python3.8/site-packages/tqdm/std.py", line 1129, in iter
for obj in iterable:
File "/mnt/users/miniconda3/envs/simsiam/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 435, in next
data = self._next_data()
File "/mnt/users/miniconda3/envs/simsiam/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 475, in _next_data
data = self._dataset_fetcher.fetch(index)  # may raise StopIteration
File "/mnt/users/miniconda3/envs/simsiam/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 44, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/mnt/users/miniconda3/envs/simsiam/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 44, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/mnt/users/miniconda3/envs/simsiam/lib/python3.8/site-packages/torch/utils/data/dataset.py", line 272, in getitem
return self.dataset[self.indices[idx]]
File "/mnt/users/miniconda3/envs/simsiam/lib/python3.8/site-packages/torchvision/datasets/cifar.py", line 120, in getitem
img = self.transform(img)
File "/mnt/users/03_simsiam/augmentations/simsiam_aug.py", line 25, in call
x1 = self.transform(x)
File "/mnt/users/miniconda3/envs/simsiam/lib/python3.8/site-packages/torchvision/transforms/transforms.py", line 68, in call
img = t(img)
TypeError: 'tuple' object is not callable

I met this TypeError when I run the commad:
python main.py --debug --dataset cifar10 --data_dir my/data/folder/ --output_dir ./outputs
And I print the type of x in the code ' x1 = self.transform(x)' ,which may cause this error :
<class 'PIL.Image.Image'>

All, right. I find the latest update have solved this issue. Thank you so much!

@Asamisora how do you fix it?

@Asamisora how do you fix it?

I pull the latest version of code, then no more this issue.


Clone all repos + add code-workspace

Update clone_repos.sh script to clone all repos under the waterthetrees organization and add them to the .gitignore (I also alphabetized the list). Even if people might not ever work in some of these, I think it's better to give new members everything up front and let them explore the code. It also was a point of confusion for me why certain repos were cloned on initial set up and others were not.
I also added a .code-workspace file that people can modify locally to fit their current task. When you open the file, there is a "Open Workspace" button on the bottom right. When you click that button, a workspace with the folders listed in your .code-workspace file opens.

I'm going to merge myself. If there's any issue with the change we can revert or modify them later.

Yup, I'm already too far gone 😀. Do we want to discuss adding branch protections, such as requiring at least one review before being able to merge into dev/main. I accidentally merged a commit directly into dev that was supposed to be included in this and I'm worried others will do the same.