Generic/UnusedFunctionParameter: improve code coverage

Description
This PR improves the code coverage for the Generic.CodeAnalysis.UnusedFunctionParameter sniff.
It also includes three commits that change the sniff code directly.
The first commit removes an unused variable.
The second commit renames two $tmp variables to have more descriptive names (the new names are a bit long, so I ended up splitting two lines into multiple lines to improve the readability of the code).
The third commit removes an if condition that, as far as I could check, is not reachable. More information is in the commit message.
Happy to drop those three commits as they are outside of the scope of #146.
I might be missing something, but while working on the new tests, I noticed that the following code triggers the sniff while I believe it should not trigger it:
class InterfaceMethodNotImplement implements SomeInterface {
    public function notImplemented2($param) {
        return 'string' . 'concatenation';
    }
}

The sniff is not triggered for methods that are part of a class that implements an interface and that return on the first line. Is there are reason that I'm missing that would justify triggering this sniff for such methods when there is more than one non-empty token between the return statement and the semicolon?
Related issues/external references
Part of #146
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

[ ] This change is only breaking for integrators, not for external standards or end-users.

[ ] Documentation improvement

PR checklist

[x] I have checked there is no other PR open for the same change.
[x] I have read the Contribution Guidelines.
[x] I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
[ ] I have added tests to cover my changes.
[x] I have verified that the code complies with the projects coding standards.
[ ] [Required for new sniffs] I have added XML documentation for the sniff.

I might be missing something, but while working on the new tests, I noticed that the following code triggers the sniff while I believe it should not trigger it:
class InterfaceMethodNotImplement implements SomeInterface {
    public function notImplemented2($param) {
        return 'string' . 'concatenation';
    }
}

The sniff is not triggered for methods that are part of a class that implements an interface and that return on the first line. Is there are reason that I'm missing that would justify triggering this sniff for such methods when there is more than one non-empty token between the return statement and the semicolon?

@rodrigoprimo This may just have been an oversight when the sniff was originally created, though I'm not sure it is.
The code pattern being looked for is typically something like return false; when the interface method implementation does not contain any logic.
As soon as more is being done in the return statement than returning a simple value, it is an indication that the statement needs to be looked at and can not be presumed to be an interface method.
Think return is_something( $a ) ? $a : false;.
Keep in mind that the sniff cannot check whether a method being implemented is an interface method as it doesn't have access to the method names expected by the interface, it can only make assumptions based on common code patterns.
Note: might be an idea to open an issue for questions like this instead of tightly coupling them to a pull request, which can delay the pull request (as the question would need to be answered before the PR can be merged).

Pro-tip: when posting code samples add the language after the triple backtick to allow GH to highlight the code for better readability. I.e. ```php

Actually... I'm making one small change and that's removing a comment which is redundant in the last commit.


Fix/lint staged

fix lint-staged (runs eslint and prettier on committed files only.)
move /bin/ to /utils/
reimport nodemon config
reimport global dom typings (*.svg and window.ethereum)
run prettier and eslint on entire codebase (passes with ~60 warnings, no errors)
mobile sidebar (in the ui) enhancement. click off of sidebar to close it!

can we temporarily stop changing for contracts workspaces as of now? because it has a bunch of refactors.

can we temporarily stop changing for contracts workspaces as of now? because it has a bunch of refactors.

This is my first time using yarn workspaces so I presume that you're talking about changes in the packages/contracts directory.


added checks for duplicate interface names across bridges and per con…

…tainer nodes
implements checks as per #387.
Further checks interfaces per node are unique.

thanks @steiler
I will have a look
PS> discard Deepsource failures


sw_engine: support for radial grad focal attribs

Till now only the end circle values of the radial grad were supported. Now also the start circle values are. These are the focal point and the radius of the start circle.
In the svg_loader support for the 'fr' attrib of the radial grad is added.
@Issue: https://github.com/thorvg/thorvg/issues/1558
sample:
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 200 200">
  <defs>
    <radialGradient id="grad" r="50" cx="100" cy="100"
      fr="21" fx="80" fy="80"
      gradientUnits="userSpaceOnUse">
      <stop style="stop-color:#ff00ff;stop-opacity:1;" offset="0"/>
      <stop style="stop-color:#0000ff;stop-opacity:1;" offset="0.5"/>
      <stop style="stop-color:#00ff00;stop-opacity:1;" offset="1"/>
    </radialGradient>
  </defs>

  <circle cx="100" cy="100" r="50" fill="url(#grad)"/>
</svg>

result:

There are still some corner cases that need to be solved, that's why this is a draft

sample for the 'edgeCases':

<circle cx="100" cy="100" r="50" fill="url(#grad)"/>

I'd like to squash the commits once we have the final version of this pr.

@mgrudzinska if you need any patches that breaks apis, please make individual changes. I will cherry-pick to here. https://github.com/thorvg/thorvg/pull/1564

Replace the major changes with https://github.com/thorvg/thorvg/pull/1631


Add a test for bound of "vertices-texture"

now only for the geometries and "vertices" this is done

this was implemented a while ago with the textures


⚠ Bofrost.es has degraded performance

In e9e32ab, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1646 ms

Resolved: Bofrost.es performance has improved in 251a05a after 6 minutes.


luci-ssl-openssl mistake by "placing image" - can not be compiled into firmware package luci-ssl-openssl (px5g-* selected as a module)

@hnyman
make -j1 V=s
(...)
Configuring usbreset.
Configuring luci-i18n-base-en.
Configuring kmod-fs-cifs.
Configuring luci-i18n-firewall-pl.
Configuring ncdu.
Configuring picocom.
Configuring comgt-hso.
Configuring luci-i18n-ntpc-pl.
Configuring uhttpd-mod-tls.
Configuring wireless-tools.
Configuring kmod-crypto-sha1.
Configuring zip.
Configuring acme.
Configuring ppp-mod-pppoe.
Collected errors:
 * satisfy_dependencies_for: Cannot satisfy the following dependencies for luci-ssl-openssl:
 * 	px5g *
 * opkg_install_cmd: Cannot install package luci-ssl-openssl.
package/Makefile:56: recipe for target 'package/install' failed
make[2]: *** [package/install] Error 255
make[2]: Leaving directory '/home/sj/Pulpit/Projekty/WNDR4700-LEDE'
package/Makefile:125: recipe for target '/home/sj/Pulpit/Projekty/WNDR4700-LEDE/staging_dir/target-powerpc_464fp_musl-1.1.15/stamp/.package_install' failed
make[1]: *** [/home/sj/Pulpit/Projekty/WNDR4700-LEDE/staging_dir/target-powerpc_464fp_musl-1.1.15/stamp/.package_install] Error 2
make[1]: Leaving directory '/home/sj/Pulpit/Projekty/WNDR4700-LEDE'
/home/sj/Pulpit/Projekty/WNDR4700-LEDE/include/toplevel.mk:193: polecenia dla obiektu 'world' nie powiodły się
make: *** [world] Błąd 2

... Because when px5g requires polarssl, and when we "strem" fixed with uhhttpd-mod-tls for openssl a conflict - after the recent changes in opkg is unacceptable to install at the same time libustream-openssl and libustream-polarssl .... I mean I suppose that is causing the problem.
The ideal solution would be if luci-ssl-openssl required dependencies openssl-util, and some "automagically" library/program/script/pack type luci-app or luci-lib/etc., which included that in a script default to generate an SSL certificate on the basis of openssl-util - not as it is now solved that only px5g fully this role on the basis of cooperation with LuCI.
my .config:
.config.txt
Probably at this time luci-app-openssl needs in the Makefile the following syntax (only):
LUCI_DEPENDS: = +luci +libustream-openssl

Besides long erection is probably still a central issue - there are no write "+ px5g" only example:
"+px5g-polarssl" , "+px5g-mbedtls" or "+px5g-standalone" (testing/compile with LEDE r1737).
For example, the package luci-ssl  (Makefile) should look like:
#
# Copyright (C) 2008-2016 The LuCI Team
#
# This is free software, licensed under the Apache License, Version 2.0 .
#

include $(TOPDIR)/rules.mk

LUCI_TYPE:=col
LUCI_BASENAME:=ssl

LUCI_TITLE:=LuCI with HTTPS support (PolarSSL as SSL backend)
LUCI_DEPENDS:=+luci +libustream-polarssl +px5g-polarssl

include ../../luci.mk

# call BuildPackage - OpenWrt buildroot signature

Then everything is built without a problem.

I am working on a full "OpenSSL-only" version. But the solution will need modification of the uhttpd init script on the LEDE & Openwrt side, too. (I have already patched my own build and it works now without px5g.) See my patches and discussion at https://github.com/openwrt/luci/pull/807#issuecomment-251226934
Like I said in our earlier discussion, px5g has no connection to any of libustream- packages and uses only libpolarssl (or possibly libmbedtls in LEDE), which causes no conflict. Once again: you can have several SSL libraries installed, but not several libustream- packages.
You edited version of this issue contains the correct reason for the error, I guess: px5g vs. px5g-polarssl.
LEDE changed px5g a few months ago with https://github.com/lede-project/source/commit/a7f6dc9f8b9602441a1b56bbe73d80711e2c640f to to have a new mbedtls library variant for px5g in addition to the old polarssl SSL variant. At that point the old px5g was renamed to px5g-polarssl and the other variant px5g-mbedtls. However, in LuCI the SSL dependency in both by luci-ssl and luci-ssl-openssl collections uses the short "px5g", which package does not exist any more in LEDE but does exist in Openwrt. Changing the dependency to px5g-polarssl would break things for Openwrt users.
As the build time "make defconfig" throws no complaints, I guess that as both px5g-polarssl and px5g-mbedtls do "provide" px5g, one of them gets selected at the build time config.
Manual installation of luci-ssl and luci-ssl-openssl may thus be broken in LEDE, at the moment. And that can't be fixed in LuCI without then breaking the install in Openwrt. The easiest solution might be to rename px5g-polarssl variant back to px5g in LEDE.
Ps. To my knowledge, the package uhttpd-mod-tls is not needed any more, as uhttpd is built with TLS support by default.
Pps. There is no need to have the @ targeting on the issue title. When the @ target is in the message body, the person gets the notification message about the issue and that is enough.

Well, it is a bit strange. I can't trigger your exact error in my build.  Buildbot has built luci-ssl-openssl also for your platform, so I think that there may something on your config or build system that triggers your exact problem. (Have you run "make defconfig" or "make menuconfig" after editing .config? If not, please do that before building.)
I noticed yesterday that when I installed luci-ssl-openssl via opkg to a live LEDE router, it installed px5g-mbedtls, which surprised me as it should have installed px5g-polarssl. The confusion comes from the reason that there is no default defined for the px5g variant. Likely there should be more clearly just a px5g package plus the mbedtls variant.

@jow-
I am not sure if this should be fixed, but apparently the px5g-mbedtls creating commit https://github.com/lede-project/source/commit/a7f6dc9f8b9602441a1b56bbe73d80711e2c640f from cshore did not explicitly define one of the variants as default. Due to that the package dependency logic seems to pick the alphabetically first variant as the default, in this case mbedtls. I don't think that has been the intention, as I think that polarssl should still be the default.
From my tmp/.packagedeps:
package-$(CONFIG_PACKAGE_px5g-mbedtls) += utils/px5g
$(curdir)/utils/px5g/default-variant := mbedtls
$(curdir)/utils/px5g/variants += $(if $(CONFIG_PACKAGE_px5g-mbedtls),mbedtls)
package-$(CONFIG_PACKAGE_px5g-polarssl) += utils/px5g
$(curdir)/utils/px5g/variants += $(if $(CONFIG_PACKAGE_px5g-polarssl),polarssl)

For 99% of users that does not matter, as px5g is only selected by luci-ssl collections. There the px5g-polarssl variant seems to get selected first, likely due to libustream-polarssl being selected first. (but that px5g-polarssl selection seems to happen also for the luci-ssl-openssl collection, which I wonder)
px5g-mbedtls gets installed if you manually say just "opkg install px5g" in LEDE, where only px5g-polarssl and px5g-mbedtls packages actually exist. Then the default variant mbedtls gets installed, as the opkg logic seems to find it as the first of the two packages that "provide" px5g.
I am not sure if this should be fixed, and if the best solution would be

a third "px5g" variant that would be default and would currently use polarssl
px5g-polarssl being defined as the default variant
px5g-polarssl being renamed to just px5g

Ps. Additionally I noticed a possible error in the ustream-ssl package. It has two default variants...
https://github.com/lede-project/source/blob/master/package/libs/ustream-ssl/Makefile#L54
Possibly the copy-paste used to create the mbedtls variant has included that DEFAULT_VARIANT line by accident and also the DEPENDS in mbedtls variant looks different than the other two optional variants: https://github.com/lede-project/source/commit/d9494cdf6dab6cf4c1b74f4031e9492d31f1c3dc
When I look at my tmp/.packagedeps, that does not seem to hurt much, as polarssl gets evaluated last and survives as the default variant.
This does not probably hurt users much, but might still be straightened up.

(...)(Have you run "make defconfig" or "make menuconfig" after editing .config?(...)

No, I never editing .config and after run "make menuconfig" or/and "make defconfig" - only:
1.) git clone [LEDE]
2.) make package/symlinks V=s

I just tested cloning a new repo, updating & installing the feeds, and selecting luci-ssl-openssl via menuconfig. Works ok.
git clone https://git.lede-project.org/source.git
cd source/
./scripts/feeds update
./scripts/feeds install -a
make menuconfig

After selecting luci-ssl-openssl in menuconfig, px5g-polarssl was properly selected in .config.
The only way I have been able to reproduce your error is to manually edit .config to activate luci-ssl-openssl there and then start a build without first fixing the dependencies with make defconfig.
To me this still sounds like an user error, as the buildbots compile the package happily, too.

I downloaded the new source, installed feeds ... but ... how to use the old .config, you do not need to be set all over again ??? (For me apart from the sources and feeds there are symlinks to the local directory with packages and small changes in comgt, dnscrypt-proxy, additional scripts in the package/base-files/files/sbin, additional firmware for USB3, etc.).
So I used the "make defconfig" hoping that it will update my .config automatically - if not so ... how?

"make defconfig" basically just checks the dependencies starting from your current selections. the same is run when you use make menuconfig and save settings at the end.

how to use the old .config

I use a .config recipe ".config.init" that contains only the selection that I have done. I copy the short recipe as the new .config and then I use "make defconfig" to expand it to the full config.  See https://forum.openwrt.org/viewtopic.php?pid=301814#p301814 for explanation
To create such a recipe, you should start with the output of ./scripts/diffconfig.sh.  It shows the non-standard selections that you have currently made (or that have been enabled via dependencies due to your selections). That serves as the baseline and is much much more useful than the whole .config
You should then prune from that those automatic dependencies that have been pulled in due to your actual selections. E.g. selecting luci selects uhttpd, luci-mod-admin-full etc. Keeping just the short recipe enables you to apply new config defaults & options to your old selections.
You need to rebuild .config rather regularly. Otherwise it starts accumulating unnecessary crust and changes in defaults go unnoticed, leading you into rather non-standard build.

@hnyman
On the one hand, what you write is understandable and logical ... but highly impractical, confusing and cumbersome to perform "live" - perhaps easier I will torture ustwiając all over again - as far as possible, of course ... what I start slightly doubt ... (but clearly in need configurations is uhttpd-mod-tls-openssl - too much further configuration in the main system depends precisely on this choice).

It is actually rather simple, once you create the recipe.
I am closing this issue, because it sounds very likely that this is not an actual error in the build system sources or logic. worksforme.


Global/Project Effects Extension

I don't know if it's possible, but it would be cool to have an extension that can set effects like brightness, color, fisheye, etc. to the entire project or to all sprites at once instead of just one.

#299 is adding this.

Thank you! Would there be the possibility of adding more effects in the future?

These are all the effects possible with css. A more complex system would be needed if you want more, and I am not willing to do it, as it takes a lot of time.

Oh ok, thanks!

leave issues open until they are actually resolved

Oh ok

#299 is pretty close


Data is not properly collected

Good Afternoon @RichiH ,
When I try to get the data from the records of my Ingecon inverter from the modbus exporter I see that the values obtained are not correct. For example, the first 6 records correspond to the date (year, month, day, hour, minutes, and seconds). In modbus-exporter I am getting the value 2024 for all of them, but if I set a flow to node-red I get the data correctly.
This is the data i get from modbus-exporter:

And this is the configuration at modbus.yml:
modules:

  - name: "start"
    protocol: 'tcp/ip'
    metrics:

      - name: "ModBus_Actual_Year"
        help: "Actual Date. Year (Uint16)"
        address: 30000
        dataType: uint16
        endianness: big
        metricType: gauge
        labels:
          address: 30000

      - name: "ModBus_Actual_Month"
        help: "Actual Date. Month (Uint16)"
        address: 30001
        dataType: uint16
        metricType: gauge
        endianness: big
        labels:
          address: 30001

      - name: "ModBus_Actual_Day"
        help: "Actual Date. Day (Uint16)"
        address: 30002
        dataType: uint16
        metricType: gauge
        endianness: big
        labels:
          address: 30002

....

This is the data i obtanined at node-red:

The configuration at buffer parser is:

I think it would be necessary to add the offset byte option to the metrics settings as you can see in Node-Red's parser buffer so that you can get the data correctly with Node-Exporter.
Hope someone can help me.
Regards.

The registers you are trying to read from your device are input registers. These registers are read with the modbus function code 0x04, as you noted from the data sheet.
The function code used by this exporter is set with the first digit of the register number in the configuration file.
So for example, an address of 30001 set in modbus.yml will read a holding register, as the first digit "3" refers to the holding register function code of 0x03.
This is the table of function codes (taken from here) that are supported by the exporter:

Function Code
Register Type

1
Read Coil

2
Read Discrete Input

3
Read Holding Registers

4
Read Input Registers

Try changing all of your addresses to 40000, 40001, 40002... etc. and see what that returns.


AuthToken should be passed as header and not as query param

Currently authToken obtained from login API is used run other entity related APIs.
It is a security issue.

Replaced @RequestParam with @RequestHeader


Make cx16assem run as an external command inside cx16shell

Right, but it drops back to BASIC before doing so rather than running subordinate to the shell.  I know maybe you meant the shell solely as a “curiosity” but I think it is a contender to be the “primary” CLI for the Cx16 if stuff supports it.
From: Irmen de Jong @.>
Sent: Monday, February 6, 2023 3:30 PM
To: irmen/cx16assem @.>
Cc: mgkaiser @.>; Author @.>
Subject: Re: [irmen/cx16assem] Make cx16assem run as an external command inside cx16shell (Issue #1)
Can you elaborate?
Because you can already just launch it when you type the name.
—
Reply to this email directly, view it on GitHubhttps://github.com/irmen/cx16assem/issues/1#issuecomment-1419708412, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACEMI3MM2P2YRVIQ6LT54ETWWFNMJANCNFSM6AAAAAAUSH5YG4.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

I see. Well, the assembler is developed as a stand alone program.
And the shell is as well.
The X16 is not a platform to multitask / process switch easily, so this remains an impossibility right now.

Not looking for multitasking.  Just looking for a way to quickly move among the editor, assembler, run the program it built.  Think “CP/M”, not “Linux”.   The Cx16 is more capable than most CP/M machines ever were.  The SDCard is faster than any floppy back in the day was and CP/M rarely had more than 64k available and maxed out at 128k in 3.0
From: Irmen de Jong @.>
Sent: Monday, February 6, 2023 3:35 PM
To: irmen/cx16assem @.>
Cc: mgkaiser @.>; Author @.>
Subject: Re: [irmen/cx16assem] Make cx16assem run as an external command inside cx16shell (Issue #1)
I see. Well, the assembler is developed as a stand alone program.
And the shell is as well.
The X16 is not a platform to multitask / process switch easily, so this remains an impossibility right now.
—
Reply to this email directly, view it on GitHubhttps://github.com/irmen/cx16assem/issues/1#issuecomment-1419714570, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACEMI3ONMLUCJG6ODK4CIF3WWFOAJANCNFSM6AAAAAAUSH5YG4.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

I agree that the specs "could" allow it, but for now I think you have to stick with the edit/assemble/run cycle as it is supported in the command mode of the assembler itself...

I’m gonna give it a try.  Remember I had not gotten the assembler to run previously.  So far I like it.
From: Irmen de Jong @.>
Sent: Monday, February 6, 2023 4:00 PM
To: irmen/cx16assem @.>
Cc: mgkaiser @.>; Author @.>
Subject: Re: [irmen/cx16assem] Make cx16assem run as an external command inside cx16shell (Issue #1)
I agree that the specs "could" allow it, but for now I think you have to stick with the edit/assemble/run cycle as it is supported in the command mode of the assembler itself...
—
Reply to this email directly, view it on GitHubhttps://github.com/irmen/cx16assem/issues/1#issuecomment-1419741417, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACEMI3J2FSRPSLCF3JM7YCDWWFQ3HANCNFSM6AAAAAAUSH5YG4.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>


[BUG] - Bootstrapping private testnet from Byron into Alonzo through mkFiles and update-1 to update-5 scripts.

Internal/External
External
Area
Other
Summary
We are trying to bootstrap a private testnet from Byron into Alonzo by using the provided script from the cardano-node repo in scripts/byron-to-alonzo/mkFiles.sh. Everything starts fine and then we want to do the transitions into Alonzo, by using the update-1.sh to update-5.sh files. However during update-2.sh we get an error submitting the update proposal - the weird thing is that this error does not always show - sometimes the update goes through and we have no idea why it works/why it doesn't. Here is the output of our steps:
  1. invoke ./scripts/byron-to-alonzo/update-1.sh <N>
     if you are early enough in the epoch N = current epoch
     if not N = current epoch + 1. This applies for all update proposals
Transaction successfully submitted.
Transaction successfully submitted.
Update proposal TxId: upid:8244de85
Transaction successfully submitted.
Vote TxId: voteid: e7d5cf44
Transaction successfully submitted.
Vote TxId: voteid: 82d0e386
Transaction successfully submitted.
###############################################################################
  2. wait for the next epoch for the update to take effect
Waiting until epoch 1
Sleep 30 secs
Sleep 30 secs
Sleep 30 secs
reached epoch: 1
###############################################################################
  3. invoke ./scripts/byron-to-alonzo/update-2.sh
Update proposal TxId: upid:31317ecd
Error submitting update proposal: ByronTxSubmitError "ByronTxValidationError (MempoolUpdateProposalErr (Registration (InvalidProtocolVersion 2.0.0 (Adopted 0.0.0))))"

We checked LastKnownBlockVersion-Major in configuration.yml and it is always 1 (we use docker with a shared volume for the configs, therefore configuration.yml is mutable, but we set LastKnownBlockVersion-Major to 1 before starting the transition).
The other thing we update in our configurations are startTime in byron/genesis.json and systemStart in shelley/genesis.json otherwise testnet would not boot properly.
Steps to reproduce

Create the testnet configuration files with scripts/byron-to-alonzo/mkFiles.sh (no arguments!)
Start the resulting testnet
Wait for block production
Invoke the update-1.sh
Wait for next epoch
Invoke update-2.sh

Expected behavior
update-2.sh executing ALWAYS reliably without the error shown above.
System info (please complete the following information):

OS Name: Ubuntu
OS Version: 22.04
Node version:
cardano-node:
cardano-node 1.34.0 - linux-x86_64 - ghc-8.10
git rev c23d5d319cd3276575c6ac32458516232e8d2c48
CLI version:
cardano-cli 1.34.0 - linux-x86_64 - ghc-8.10
git rev c23d5d319cd3276575c6ac32458516232e8d2c48

Screenshots and attachments

If applicable, add screenshots, config files and/or logs to help explain the problem.

Additional context
We are running everything in a docker container.

So the issue was that we needed to wait a bit longer for the update to be successul. Also, make sure that protocolVersion.major in shelley-genesis.json is set to 2 - this is not done when generating the configuration using mkFiles.sh.
Ultimately we were successful by following this approach:

Start all nodes.
Wait until the socket is exposed and until the testnet has produced a few (10) blocks.
Invoke ./updates/update-1.sh
Wait 2 epochs for the updates to take effect. You can use sh ./updates/query_info.sh to query the tip information.
Invoke ./updates/update-2.sh. If you are too early this will fail with Error submitting update proposal: ByronTxSubmitError "ByronTxValidationError (MempoolUpdateProposalErr (Registration (InvalidProtocolVersion 2.0.0 (Adopted 0.0.0))))". You can re-run this command, and it will go through when the effects of the previous update have gone through.
Stop and start all nodes.
Wait for the testnet to enter Shelley era. You can use sh ./updates/query_info.sh to query the tip information.
Invoke ./updates/update-3.sh N where N is the next epoch. For example if you are in epoch 2 then you need to invoke ./updates/update-3.sh 3. If you are using a wrong epoch you will see an PPUpdateWrongEpocherror - simply adjust the epoch and re-run the command again.
Stop and restart all nodes.
Wait for the testnet to enter Allegra era. You can use sh ./updates/query_info.sh to query the tip information.
Invoke ./updates/update-4.sh N where N is the next epoch.
Stop and restart all nodes.
Wait for the testnet to enter Mary era. You can use sh ./updates/query_info.sh to query the tip information.
Invoke ./updates/update-5.sh N where N is the next epoch.
Stop and restart all nodes.
Wait for the testnet to enter Alonzo era. You can use sh ./updates/query_info.sh to query the tip information.

One thing we added in update-3.sh, update-4.sh and update-5.sh was calculate-min-fee so these scripts can be ran autonomously. We also needed to adopt tx-out, subtracting fees to make it work.


Features with partial support appear as "Not supported"

The Web Features Explorer displays a feature with partial support as a feature with no support. Is there a way to improve the status representation that can signal partial support?
On the ::marker entry, for instance (https://web-platform-dx.github.io/web-features-explorer/features/marker/) Safari shows an  ❌. The binary status is misleading.

The same applies to preview support. Perhaps a way to include preview support would be nice to have on the dashboard.


Deploy image only when Dockerifle was changed

otherwise small changes like tests will trigger a deploy

we deploy on release now


⚠ ClamAV has degraded performance

In 9f20329, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 492 ms

Resolved: ClamAV performance has improved in 46be850.


Rx Support

Hi, Excellent library to maintain the support of the UI state in the view model. I appreciate the support you have and I am currently using it in a personal project.
Even so, I am using RxJava and I see that the updateState method does not work well at all. As far as I could see, the state.value is called directly in this method. I think it would be great to have an updateState for the case of Rx using state.postValue. Everything else has worked wonders, except that method. The version of the library that I am using is 3.1.0.
Thanks.

Hey, thanks. I'm glad that you like the library. :)
I guess you're using RxJava for your business-logic "commands" and those return on a background thread? I'm not really familiar with RxJava to be honest and I personally use Eiffel together with Kotlin Coroutines. So I normally invoke updateState from a coroutine running on the UI thread inside the ViewModel.
Regardless, I already thought about adding a variant of updateState that uses postValue to make it usable from a background thread. From what I understand that would solve your issue?
Do you have any preferences concerning the API? I would go for something like below; effectively extending the current updateState function:
protected inline fun updateState(post: Boolean = false, update: (currentState: T) -> T)

That would provide you with the following call to synchronize a new state to the main thread:
updateState(post = true) { it.copy(sample = true) }

(The post = is optional, of course.)
I'm a bit hesitant to add the same to initState though, since the initial state should be set more or less immediately when the ViewModel is being initialized. Do you need any modifications there or just in updateState?

Yes, it seems perfect if you add that post parameter to indicate the status update from the bottom. And by default in false so that it is used only when you have Rx.
The initial state is not necessary. As you indicate it is done when the ViewModel is initializing and will be ready to be observed in the onCreate of the activity.
Thanks for the support.

I can wait, there's no problem. Please close the issue when the new library is available. Thanks for your help.

I created a pull request with the implementation. #17
If you want you can pull it into your project and see if it resolves your issue using JitPack's branch snapshots. You'll need the AndroidX version of Lifecycle Extensions, though and have to be on Android Studio 3.2 or higher if you're using Eiffel's Data Binding features.
implementation 'androidx.lifecycle:lifecycle-extensions:2.0.0-rc01'
implementation 'com.github.etiennelenhart:eiffel:updateState-postValue-SNAPSHOT'

I also added a note to the documentation, that states updated with post = true could be emitted after later ones updated without posting, since the main thread won't execute the update task immediately. Normally that shouldn't be much of a problem, but accessing currentState in subsequent updates may result in unexpected behavior.
I'll merge as soon as 3.2.0 is ready and will close the issue when 4.0.0 is released.

Hi @etiennelenhart , sorry for the delay. Everything is working well with the new library and the new AndroidX support. I suppose you will release version 3.3.x or something, right?

Hey, no problem. :)
Yes, I'm currently working on the next release which will contain some breaking changes and deprecations. So it will be 4.0.x.
I'm pretty confident that I'll be able to release it by the end of this week.

Excellent. I will wait for the new release. Thanks for your help.

Released in 4.0.0.


Wakeup Period appears backwards next to other jumpers

Jumpers for Node ID read from left to right MSB-LSB, but Wakeup Period bit values are LSB-MSB.
We should swap them around so D10 is Most Significant Bit and D9 is Least Significant so it reads correctly alongside the Node ID.

This has changed in V4 firmware, pins are labeled 1 and 2, but still map to D9 and D10.

As there is now only one direction to read (ID headers have gone in v4.1) I will close this.


[Sql] Missing required parameters | Sql Server Firewall create operation

Should parameters startIpAddress & endIpAddress be marked as required for creating or updating sql server firewall rules? @ firewallRules.json#L182
Not Including endIpAddress is returning following server response:
{
"code": "BadRequest",
"message": "Invalid value provided for parameter: endIpAddress",
"target": null,
"details": [],
"innererror": [],
}

@misosi-msft / @nathannfan / @mmacy Could you please take a look? Thanks

Thanks for reporting this issue. Looks like @nathannfan fixed it in commit 229323f52 .


Only expose template variables in dev mode

Hi @animaux just read your post in the Kirby Forum and took a quick look at the code.
It might be better to also check if Kirby is in debug mode and only expose the available template variables if this is case. You can check for debug mode with kirby()->option()->debug() === true.
People might create user accounts with limited or no panel access for their Kirby install. By appending the query variable these users could potentially see environment variables, api credentials, … which should not be exposed.
For reference
https://github.com/animaux/kirby-devkit/blob/82446549a541e06e2c7ff6687728409fbcd263f2/index.php#L14C1-L15C63

Fixed in https://github.com/animaux/kirby-devkit/commit/49ae0391751cd7060249f26bb47fecd16ab10149


Signing a tag

I am contributing OpenPGP signing for commits to gitui in https://github.com/extrawurst/gitui/pull/1544 and noticed that git handles tags in a different way.
Does someone have more information for me on how to achieve a signed tag with git2-rs?

some links i could dig up:

https://github.com/libgit2/libgit2sharp/issues/1309#issuecomment-214864630
https://git-scm.com/docs/signature-format

it very much looks like something we can do with what libgit2 provides without special extra support. just regular git hackery :D


python312Packages.opower: 0.3.1 -> 0.4.0

Diff: https://github.com/tronikos/opower/compare/refs/tags/v0.3.1...v0.4.0
Changelog: https://github.com/tronikos/opower/releases/tag/v0.4.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 292287 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.opower
python311Packages.opower
python311Packages.opower.dist
python312Packages.opower
python312Packages.opower.dist


Issue 1851: Upgrade org.apache.httpcomponents:httpclient to 4.5.13

Pull Request Description
This pull request closes #1851
Acceptance Test

[x] Building the code with mvn clean install -Dintegration.tests still works.
[x] Running mvn spring-boot:run in the strongbox-web-core still starts up the application correctly.
[x] Building the code and running the strongbox-distribution from a zip or tar.gz still works.
[x] The tests in the strongbox-web-integration-tests still run properly.

Questions

Does this pull request break backward compatibility?

[ ] Yes
[x] No

Does this pull request require other pull requests to be merged first?

[ ] Yes, please see strongbox/strongbox-parent/pull/128
[x] No

Does this require an update of the documentation?

[ ] Yes, please see strongbox/strongbox-docs#{PR_NUMBER}
[x] No

Code Review And Pre-Merge Checklist

[x] My code follows the coding convention of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented my code in hard-to-understand areas.
[x] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.

@carlspring: This is ready for review.

Thanks, @ptirador !
Closing, after successful testing.


sync cirque repo to connectedhomeip origin project

Problem
What is being fixed?  Examples:
cirque project is not the latest update in connectedhomeip
Change overview
What's in this PR
the changes to sync latest cirque to connectedhomeip

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Ming-Chi Kuo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for the PR @mingchik . Please sign the CLA so  we can finish review and merge of this PR.


fix: Remove positions from json_metadata

SUMMARY
This PR is a follow-up of PR #17570 in response to the issue that was brought in revert-PR #17753.
The changes in PR #17570 saved the positions in the json_metadata of a Dashboard even if that wasn't really necessary. It appears that very large dashboards might encounter an error as the positions might become too large.
This PR forcefully removes the positions from the metadata, while making sure that all the related logics remain in place. It also introduces a temporary fix to make sure that Dashboards currently affected by this issue should ignore the positions in their metadata entirely.
TESTING INSTRUCTIONS

Open a very large Dashboard
Edit and Save the changes
Make sure everything works as expected

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Confirmation that the issue is resolved will be very much appreciated. CC @serenajiang @etr2460 @graceguo-supercat

/testenv up

spinning up a testenv here to both try and repro the bug and to see if this resolves the issue we were seeing with doubling the position json in the database

Confirmed fix 🥳


Update spanish-verb-conjugator/src/components /Input.jsx

Enable ability to use arrow keys in input dropdown.

Started. Log file (https://devakeus.azurewebsites.net/api/log/0055fc26-e2c6-4718-acc3-db23871610c5.log).

CODAKE:
I will first find the file in the repository and then update it to enable the use of arrow keys in the input dropdown.

CODAKE:
You can search for the file 'Input.jsx' in the 'src/components' directory of the 'spanish-verb-conjugator' repository. The code snippet you need to find in the repo is the component or function that renders the input dropdown.

Cannot find
spanish-verb-conjugator/src/components/Input.jsx

code snippet in a repository.

I_would_search_the_repo_with_different_keywords
at Codake.API.Controllers.GitHubWebhookController.ProceedIssue(String owner, String repo, Int32 issueId, String gitHubApiKey, String openaiKey, String modelName, Boolean debug, Single temperature) in /home/runner/work/Codake/Codake/Codake.API/Controllers/GitHubWebhookController.cs:line 247

Started. Log file (https://devakeus.azurewebsites.net/api/log/af2c7729-4ac7-4fa3-985e-28db0ee0556d.log).

CODAKE:
Sure, I will update the Input.jsx component to enable the use of arrow keys in the input dropdown. I will use the 'keydown' event listener to capture the arrow key events and update the state accordingly.

CODAKE:
Here is the updated Input.jsx file with arrow keys enabled for the input dropdown.
spanish-verb-conjugator/src/components/Input.jsx

import React, { Component } from 'react';

class Input extends Component {
  constructor(props) {
    super(props);
    this.state = {
      selectedIndex: 0
    };
    this.handleKeyDown = this.handleKeyDown.bind(this);
  }

  handleKeyDown(e) {
    const { selectedIndex } = this.state;
    const { options } = this.props;

    if (e.key === 'ArrowDown') {
      this.setState({
        selectedIndex: (selectedIndex + 1) % options.length
      });
    } else if (e.key === 'ArrowUp') {
      this.setState({
        selectedIndex: (selectedIndex - 1 + options.length) % options.length
      });
    }
  }

  render() {
    const { selectedIndex } = this.state;
    const { options } = this.props;

    return (

        <input
          type='text'
          value={options[selectedIndex]}
          readOnly
        />

          {options.map((option, index) => (

              {option}

          ))}

    );
  }
}

export default Input;

CODAKE:
Great! Now, the next step is to create a pull request. This will allow the repository maintainers to review the changes made on the new branch and merge them into the main codebase if they are satisfactory.

CODAKE:
CODAKE INFO
Model: gpt-4-0613
- Cost Total: Tokens used: 2307, cost: 0.14 USD
- Input: Tokens used: 676, 0.06 USD for 1,000, cost: 0.11 USD
- Output: Tokens used: 507, 0.12 USD for 1,000, cost: 0.06 USD
Awesome! Now that the pull request has been created, the repository maintainers will review the changes. Once they approve the changes, they will merge your pull request into the main codebase. This concludes the task.


Strange formatting for Auth screen

Task
Strange formatting for Auth screen for secondbrain since newest mac version:

@tomsmith8 I will take a look. It's definitely related with Material Icons font. Not sure why it's not recognized but should be able to fix it easily and upload a new release

@tomsmith8 Uploading a new version now with fixes for this and other fixes related with joining jitsi calls from universal links


Cgrid

Define interface between SwanGrid higher-level object and SWAN grid component. Two methods have been implemented in SwanGrid to:

Create a GRIDREGULAR instance out of an existing SwanGrid instance (rompy.swan.grid.SwanGrid.component property method).
Create a SwanGrid instance from an existing GRIDREGULAR instance (rompy.swan.grid.SwanGrid.from_component class method)

Support specifying the numeric stopping criteria using ACCUR:

Implement ACCUR swan numerics subcomponent as an alternative to the STOPC
Change the field name in the NUMERIC component from stopc to stop and set both STOPC and ACCUR as valid options for that field

Bug fixes and small changes

Redefine validator in rompy.core.grid.RegularGrid to ensure grid attributes are defined correctly when instantiating the grid from x, y arrays rather than those attributes (this was actually implemented in the latest pull request https://github.com/rom-py/rompy/pull/49).
Fix bug calculation of spatial resolution / extension in regular grid classes.
Add an __eq__ method to the core RegularGrid class so grids can be correctly compared for equality.

LGTM


AMD Ryzen 7 3800X - Unknown Device

Brief description of your issue
In the RAPL Devices section of the Options menu my CPU was marked as an unknown device and it said to report this on GitHub.

In a similar bug report I saw a request to collect energy counters:
counters.txt
Steps to reproduce (optional)

Open Options window
Navigate to RAPL Devices
Verify CPU is listed and marked as unknown

Expected behavior (optional)
No response
Actual behavior (optional)
No response
Environment (optional)
AMD Ryzen 7 3800X 8-Core Processor
Windows 11 Pro | 22631.3235
System Informer Nightly | 3.0.7474

Thanks for the counter samples 👍
Follow the other thread for updates: #1558


ci: push image to dockerhub in github action

What problem does this PR solve?

Issue link:
What is changed and how it works?
TEST ONLY
Code changes

[ ] Has Go code change
[ ] Has CI related scripts change

Check List
Tests

[ ] Unit test
[ ] E2E test
[ ] Stability test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Breaking backward compatibility
[ ] Other side effects:

Note for reviewer

Codecov Report
Base: 5.34% // Head: 5.34% // No change to project coverage :thumbsup:

Coverage data is based on head (2014fa0) compared to base (781d70d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master      #1   +/-   ##
======================================
  Coverage    5.34%   5.34%
======================================
  Files          17      17
  Lines        2001    2001
======================================
  Hits          107     107
  Misses       1881    1881
  Partials       13      13

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix ln signing key, use guggero for old release, update roasbeef key

FIxes: #4818

Tested PR and it fixed the LND install. Merging for v1.11.3rc4


As a site admin, I can set data cleaning / data dump schedules for user profiles & survey data

This issue requires a conversation to hash out more.

@ChrisMarsh82 can you help set up this meeting?

Will need to be able to delete:
Individual user data
Survey and quizzes over 30 days
A subset group users


expired signing key for bazel APT repo

Describe the bug
expired signing key for bazel APT repo
Area for Triage:
Packages
Question, Bug, or Feature?:
Bug
Virtual environments affected

[ ] macOS 10.15
[ ] Ubuntu 16.04 LTS
[x] Ubuntu 18.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Expected behavior
apt-get update finish without error
Actual behavior
apt-get update shows the following error message:
Err:5 https://storage.googleapis.com/bazel-apt stable InRelease
  The following signatures were invalid: EXPKEYSIG 3D5919B448457EE0 Bazel Developer (Bazel APT repository key<EMAIL_ADDRESS>

Hello, @zhangyoufu
We are planning to roll-out a new image version this week where the gpg key was updated. As a  temporary workaround you can update manually the gpg for bazel:
curl https://bazel.build/bazel-release.pub.gpg | sudo apt-key add -
        echo "deb [arch=amd64] https://storage.googleapis.com/bazel-apt stable jdk1.8" | sudo tee /etc/apt/sources.list.d/bazel.list

Hello,
Do we know when the new image is going to be deployed?
Thanks

@jkfran we started deployment yesterday(the previous week's deployment was canceled due to bug in azure-cli). The propagation will take 2-3 more days.

Hello @miketimofeev ,
When do you think the deployment will be ready?

@jkfran Unfortunately we had to stop the deployment due to found issues so the new date is next Tue-Wed. The new release is this one:
https://github.com/actions/virtual-environments/releases/tag/ubuntu18%2F20200604.1
Thank you for your patience.


Reduce image sizes to smallest reasonable size

I can reduce the slogan images to 200x200, which works with the currently used image width. Where do I upload images? @JosephMcArthur

On Github.
It's worth saying that on the read me of /oab_static. Images and files can
just be uploaded to the repo and linked from there.
On Mon, 4 Jul 2016 at 01:44 chealsye<EMAIL_ADDRESS>wrote:

I can reduce the slogan images to 200x200, which works with the currently
used image width. Where do I upload images? @JosephMcArthur
https://github.com/JosephMcArthur
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OAButton/backend/issues/147#issuecomment-230185376,
or mute the thread
https://github.com/notifications/unsubscribe/AEuWZ7kxhCO_ngyVgvpeA5FluLyNdLCZks5qSFeGgaJpZM4JCim4
.


Discoverer refactoring

Main changes made to the discoverer:

Moved from Tomcat to Dropwizard
Divided the whole Discoverer into three main parts (Crawler Manager that manages crawlers, Offering Manager that manages the Offerings, Discoverer that manages the RESTful API and orchestrates the other components)
Fetching of more information from CloudHarmony and PaaSify
Added a configuration file (discovererconf.yml) in order to manage some configuration variables
Removed the usage of the alien4cloud library
Added the possibility to fetch all offerings in a single REST call (/fetch_all)
Mapping of the location field in order to be able to deploy the offerings

Thanks @PaoloCifariello for the PR, it is a good step ahead, IMHO.
I've commented in particular the pom.xml and the tests you added, which to be completely honest, are not covering enough the code base. Could you try to improve them?
I suggest to keep the discoverer even simpler than that: I think it has to be used as library rather than as-a-Service, so focus on the core, instead of focusing on the api for the time being.
Some design questions:

why are they crawlers? do we really need to fetch regularly those sources? Maybe this is true for Cloudharmony but PaaSify changes on a monthly scheduled so it is not clear why you check for updated every 24 hours.
why the Offering are saved on the filesystem? I guess the answer is for simplicity but maybe you could consider a different datastore at some point.
I'd promote Offering class at a more common level (at least shared across Planner components), what do you think?

Thanks

Please use the following pom.xml
Notice:

the build is broken because you have 644 Checkstyle errors! (skipping maven-checkstyle-plugin is not a great idea!)
you should refactor the discoverer maven component into core and service like:

discoverer (pom)
-- core (jar)
-- service (jar based on dropwizard)

similarly to the optimizer module.

For the second point (you should refactor the discoverer maven component into core and service):
I don't think it is feasible in the context of the Discoverer, since in the optimizer module it seems that a new instance of the Optimizer class is made everytime a proper API is called.
Here in the Discoverer i need to keep some information (like the ids of the Offerings fetched etc..) during the execution, so i need to keep the Discoverer as a Dropwizard application.

@PaoloCifariello not sure I follow, but you could also do something like
public FetchAPI(Discoverer discoverer) {
        this.discoverer = discoverer;
    }

instead of
public FetchAPI() {
        this.discoverer = Discoverer.instance();
    }

no?
The reason to push with that is that the discoverer-service will be just a wrapper around the discoverer-core that implements all the discovery functionalities. My two cents

Thank for your suggest, you are right and it seems reasonable.
I note of your proposal and I will try to deal with it for the next pr

@PaoloCifariello, your last message says that you are trying to address the comments, any update?

Thanks again for the comments.
I updated the PR in order to:

remove IAPI interface that was useless
change package names (and then folder names) to the lower case
remove the commented code
remove a useless test since alien4cloud is no more used inside the Discoverer
make the Discoverer fetching only on startup (configurable) and on demand (by using /refresh API)

I still have to refactor the Discoverer into core and service as suggested, but I plan to do it in a further PR.

thanks @PaoloCifariello, merging now.


building a PWA

Chrome had issues detecting the manifest

Hi Lawrence, can you clarify what kind of issues did you have to detect the manifest in Chrome? Thanks

Hi, thanks for getting back to me so quickly
Maybe it’s the service worker but I will try finishing the course then I
will revisit
On Wed, Feb 9, 2022 at 3:36 AM firtman @.***> wrote:

Hi Lawrence, can you clarify what kind of issues did you have to detect
the manifest in Chrome? Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/firtman/frontendmasters-pwa/pull/2#issuecomment-1032936192,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQUENASINC2GYAF3FSF34VLU2FPBLANCNFSM5NZ42OJQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

manifest not detected  but service workers worked. I think this is a chrome problem


Allow a default value for db.load

One should be able to provide a default value for db.load. This is beneficial when one does not want to handle an exception to get a value - as when await as seen in the example below.
let user = await db.load(userID, null);
if (!user) {
  user = {
  id: userID,
  username,
  bthKey: null
};
await db.save(user);

@AlexGustafsson Great change, thanks! Could you also add a test case for this to the unit tests?

@Morgul Done.

@AlexGustafsson awesome, thanks!


automated updating datasets.md file

Created a python script to automate the updating of datasets.md file every time there is update in Data folder
This can be connected to any bot that is in use to just run python create_datasets_md.py
@nikhil25803  PR Updated from #53
The issue is how systems generate relative path, windows use "\" and linux uses "/"
#53 contains "\" and git uses linux systems I think to go through this relative path.
This issue is fixed and PR is updated accordingly
Important Note:

Note that folder structure should not be changed
Please avoid spaces in the file or folder name

profile url: Vijay 'H'CN
@nikhil25803  merged this PR