BREAKING CHANGE: SqlDatabaseRole: Refactored to support adding/removing roles, managing membership

Pull Request (PR) description
This PR updates the SqlDatabaseRole resource to properly manage database roles, including adding/removing the role as well as managing role membership. The behavior has been updated to more closely represent what is done with SqlServerRole.
In addition to the change in functionality, the new resource also does not add users to the database. This will be implemented in a separate resource called SqlDatabaseUser.
This Pull Request (PR) fixes the following issues

Partially #845 (See #847)
Fixes #847
Fixes #1252
Fixes #1339

Task list

[x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[x] Resource documentation added/updated in README.md.
[x] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[x] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #1367 into dev will decrease coverage by 2%.
The diff coverage is 0%.

@@          Coverage Diff          @@
##            dev   #1367    +/-   ##
=====================================
- Coverage    98%     95%    -3%
=====================================
  Files        36      36
  Lines      5257    5319    +62
=====================================
- Hits       5187    5101    -86
- Misses       70     218   +148

Updated the PR description slightly so we are not auto-closing issue #845. 🙂 I modified issue #845.

Are you working on issue #846? If so, how far along are you with the new resource SqlDatabaseUser? Since we are introducing a breaking change here that won't create users, is there another way to create the users until we have that resource in-place? 🤔

@pshamus Thank you for this PR! It makes the resource so much more intuitive! 😃 I'm reviewing now.

Due to a recent merge to the dev branch there are merge conflicts since your PR is no longer based on the latest changes. Could you please rebase against branch dev using git rebase (not by using git pull or git merge, to keep the commit history). If you don't know how to rebase your local dev and working branch, please look at how to Resolve merge conflicts.
Let me know if you need any assistance.

Above it should have said “Ensure property means group exist or does not exist.”.  On the mobile writing the comment, and it tends to autocorrect wrong :smile:

Closing and reopening to kick off the tests again.


feat: Improve Error Handling of classifiers and regressors

Closes #153 .
Summary of Changes
The Error Handling of classifiers and regressors was not ideal. Now every classifier and regressor validates the data, especially when given non-numerical or missing values in the table.

🦙 MegaLinter status: ❌ ERROR

Descriptor
Linter
Files
Fixed
Errors
Elapsed time

✅ PYTHON
black
24
4
0
1.52s

❌ PYTHON
mypy
24

1
2.17s

✅ PYTHON
ruff
24
7
0
0.04s

✅ REPOSITORY
git_diff
yes

no
0.01s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by

:tada: This PR is included in version 0.14.0 :tada:
The release is available on:

v0.14.0
GitHub release

Your semantic-release bot :package::rocket:


create basic structure, fetch API and display dragons

In the milestone, I achieved the following:

Created the basic structure for dragons
Fetched dragons from the Dragons endpoint.
Displayed the dragons' List.

STATUS: APPROVED 🎉 🎉 🎉 🍾 🍾 🍾
Hello  @demix007   👋🏼
Your work is complete! You have done an excellent job in adding the required functionalities to the app.  There is nothing else to say other than, It's time to merge it ✅

Congratulations  🎉 🎉 🎉 🍾 🍾 🍾
Highlights 🟢

Correct workflow ✅
No Linters error ✅
Good job implementing the right functionalities ✅

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @BertrandConxy in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hello @blase147 😎 ,
Thank you for taking out time to review and approve this PR.


Downloading an ISO more simply

We need to transfer an ISO from one datastore to another.
The changes clean up a bit the code an adds a FileReadHandle as a source for copying it.

I think so too. It would be great if you could take care of it.

I think so too. It would be great if you could take care of it.

ok


[Features Request] Smart Pin Tagging and Search System for Wherostr

As a Wherostr user who is exploring new places, I would like to add and search for pins with specific tags, so that I can easily find and share relevant locations based on categories.
Is your feature request related to a problem? Please describe.
Currently, when using the map feature in Wherostr, users can't categorize or filter pins based on specific types of locations or services. This makes it difficult to quickly find relevant places or share themed collections of locations with others.
When does this problem happen?
This problem occurs when users are trying to find specific types of locations (e.g., restaurants, hotels, car services) on the map, or when they want to share a curated list of places with others based on a particular theme or category.
Describe the solution you'd like
I would like to implement a pin tag search function with the following features:

Allow users to add tags (e.g., food, car service, coffee, hotel) when creating a new pin on the map.
Enable users to search and filter pins based on these tags.
Provide a user-friendly interface to select and combine multiple tags for more refined searches.

Describe alternatives you've considered

Using a predefined list of categories instead of free-form tags. However, this might limit flexibility for users.
Implementing a full-text search on pin descriptions. This could work but might be less efficient and accurate than tag-based searching.

Additional context
This feature would greatly enhance the usability of the map function in Wherostr, making it easier for users to discover and share relevant locations. It would be particularly useful for travelers, locals sharing recommendations, or anyone looking to explore new places based on their interests.

Hi @sootisooti,
Thanks so much for your feature request! Just a heads-up, we’re currently migrating our web platform from React to Flutter. We’ve already rolled out our iOS and Android apps with Flutter, and the web update will be coming soon.
As for the feature you asked about, we’re planning to add it, and it may make it into the upcoming release. Thanks for your patience, and we can’t wait for you to check out the new web version when it’s ready!
Our new flutter repo.


reCaptcha v3

at the first load of the page, reCaptcha works correctly but when we try to reload/refresh the page it does not work.

Please provide more details.

we have 	<script src="js/ScriptLoader.js"></script> into _Layout.cshtml and
<GoogleRecaptcha SuccessCallBack="SuccessCallBack"
                                     TimeOutCallBack="TimeOutCallBack"
                                     ServerValidationErrorCallBack="ServerSideValidationError"
                                     ServerSideValidationHandler="ServerSideValidationHandler">
</GoogleRecaptcha>

on the razor page, at the first load it works,  we get a reCaptcha token, but when we hit the refresh page it has a problem

I cannot reproduce the error. Need more details ( The version that you are using , the NET version and whether it's Blazor Server or web assembly)

Blazor Server - .NET 7

I some how can't reproduce the problem. I refreshed to page thousand of times and each time it works as it should be. Is your captcha site token correct? can browser connect to google recaptcha service?

can you give us the example that you already tested?

I have tried your newest addition ReloadAsync Method but it still does not render the component once again , i am working on a same project as bkristesiashvili

I have tried your newest addition ReloadAsync Method but it still does not render the component once again , i am working on a same project as bkristesiashvili

Reload Method only works on V2 version. Are your domains defined in Recaptcha Admin Panel Correct?

can you give us the example that you already tested?

Blazor Server test project added to the repo.
I think I solved the bug. It was the cache container for script loader (which was registered as singleton. changed it to scoped to be registered once per connection instead of per application. And since scoped and singleton are same in WASM , hopefully it won't produce any bugs in WASM projects).
Please update to version 3.6.0 and check if this solves the issue


Google Maps route

Creates a link to a Google Maps route with all portals in bookmark
folder.

Really useful!

Please also take a look at the formatting; your indentation seems to have done something odd.


My webapp deployment was not successful

Describe the bug
Once I was satisfied with my development I proceeded to deploy it by clicking on the deploy button but I received the message «An unknown error occurred when deploying your project.»

Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-dubnun
Steps to reproduce
Click on 'Deploy'.
Expected behavior
I was expecting my webapp to appear on a website and receive its URL.
Screen Recording / Screenshot

Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 131
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 115821235,
  "usedJSHeapSize": 90765743,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = randradegh
Chat ID = 63f3b24c63bb

Additional context
Error:
An unknown error occurred when deploying your project.

I hope you can help me solve the problem.


Add examples

:sparkles: Enhancement
Add examples of server-side and client-side generated apps to the repo.
Closes #72.

:white_check_mark: Checklist

[x] Following CODE_OF_CONDUCT.md.
[x] Checked for duplicate pull requests
[x] Title is a summary of the change, in present tense, ideally < 50 characters
[x] Pulling from a branch (right side), not master.
[x] Pulling into master branch (left side).
[x] Changed relevant files in templates directory.
[x] Fixing a bug? An open bug report exists.
[x] Breaking API changes? Migration notes attached.
[x] Ready for review

:tada: This PR is included in version 3.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Added tests for checking optimisers boundary condition

Fixes #279
My contribution is licensed under the MIT license.

This will merge master into opusV/boundTests, wherefore no Pull Request is required/needed.


--discard-comments removes shellcheck directives

Description
When called using --discard-comments option, bashembler removes shellcheck directives. This causes the outputed script to show errors when checked using shellcheck.
Expected behavior
bashembler should keep comment lines containing a shellcheck directive.

Issue fixed.


Aria2c Integration

youtube-dl has two specific command flags which easily facilitate the usage of an external download manager. Specifically aria2c which enables you to specify x number of thread parts to download at once instead of simply using 1 thread. In some situations this can increase the downloading of audio data many fold.
youtube-dl -x --audio-format mp3 {youtube_url} --external-downloader aria2c --external-downloader-args --file-allocation=none --external-downloader-args -x6

Breakdown
-x

extracts audio from provided YouTube url
--audio-format mp3 {youtube_url}

specifies we want mp3 formatted audio
--external-downloader aria2c

specifies the external downloader we want to use
--external-downloader-args --file-allocation=none

disables pre-allocation of file space
--external-downloader-args -x6

we want to split the mp3 file into 6 parts and download them all simultaneously

Aria2c static builds.
Aria2c is ubiquitous--so it should work on just about any platform.

From downloader.py
def __init__(self, download_folder=None):
        self.thread_pool = ThreadPoolExecutor(max_workers=2)
            self.unsafe_ytdl = youtube_dl.YoutubeDL(ytdl_format_options)
            self.safe_ytdl = youtube_dl.YoutubeDL(ytdl_format_options)
            self.safe_ytdl.params['ignoreerrors'] = True
            self.download_folder = download_folder

It seems by default there are 2 parallel task running at once so this may not be necessary--but would still be nice to have.

Send me $113,000.
Sent from my iPhone

On Apr 24, 2017, at 7:52 PM, Zach Queal<EMAIL_ADDRESS>wrote:
youtube-dl has two specific command flags which easily facilitate the usage of an external download manager. Specifically aria2c which enables you to specify x number of thread parts to download at once instead of simply using 1 thread. In some situations this can increase the downloading of audio data many fold.
youtube-dl -x --audio-format mp3 {youtube_url} --external-downloader aria2c --external-downloader-args --file-allocation=none --external-downloader-args -x6
Breakdown
-x
extracts audio from provided YouTube url
--audio-format mp3 {youtube_url}
specifies we want mp3 formatted audio
--external-downloader aria2c
specifies the external downloader we want to use
--external-downloader-args --file-allocation=none
disables pre-allocation of file space
--external-downloader-args -x6
we want to split the mp3 file into 6 parts and download them all simultaneously
Aria2c static builds.
Aria2c is ubiquitous--so it should work on just about any platform.
From downloader.py
def init(self, download_folder=None):
self.thread_pool = ThreadPoolExecutor(max_workers=2)
self.unsafe_ytdl = youtube_dl.YoutubeDL(ytdl_format_options)
self.safe_ytdl = youtube_dl.YoutubeDL(ytdl_format_options)
self.safe_ytdl.params['ignoreerrors'] = True
self.download_folder = download_folder
It seems by default there are 2 parallel task running at once so this may not be necessary--but would still be nice to have.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Proper versioning import

Closes #59

Looks like these changes will solve your issues @germa89

Also, adding additional deps:

Codecov Report

Merging #61 (25b4c47) into main (6eb305b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   94.20%   94.20%
=======================================
  Files           3        3
  Lines          69       69
=======================================
  Hits           65       65
  Misses          4        4

Impacted Files
Coverage Δ

src/ansys/tools/report/report.py
96.66% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

If PR is merged, a new release will be required.


Update ESLint Config

After the changes made in #405, there is a lot of eslint config now in the package.json.
In effort to clean this up, there was a suggestion to move Slingshot to a baseline preset.
This issue is to capture that ask and open the discussion to others about what the eslint config preset should be set to.
Options

ESLint Recommended Baseline

Do we include other recommended baselines (ie. react, import, etc.)

ESList shared preset

Which preset?

AirBnB - No  - too opinoinated see #35
CRA?
Standard/Standard-Semi?

Package Slingshot Config

Is the current config at a place that is right sized and can be shared as a packaged config

Thanks @kwelch! I vote for ESLint recommended. If you prefer something else, enter a comment so people can upvote via a 👍

I would not mind seeing us incorporate prettier (or prettier-eslint) to have a simple consistent format and use baseline recommended for best practice / bug catching type linting.

I like Prettier, but also recognize it's a polarizing idea - As an anecdote, in our office, a significant portion of people find the idea of having their code changed automatically in any way is unsavory. Many prefer to "learn from their mistakes" by manually fixing what ESLint reports. I can appreciate that. And there are certainly things Prettier does that I don't like - such as splitting long imports into multiple lines. So I feel ESLint recommended is the most populous friendly approach at the moment.

I understand that. It also adds a bit more weight than I think we would stand to institute and support in a boilerplate. It is a better fit for library.

I think we are solid on the approach. Adding a help wanted and good first PR label.
😄

@coryhouse - you could have both, ESlint would still throw errors and warnings at you via your editor, while prettier can make sure the output of the file is exactly the same no matter who has written it.

@qborreda True, though it seems the recommended approach is to disable any formatting related warnings from ESLint to avoid the duplication. It would seem noisy to warn someone about something that will be automatically fixed on save/commit. I think that's the sales pitch for prettier - it makes coding more luxurious because you literally stop thinking about formatting altogether.

I am not a maintainer but I do use this boilerplate quite a bit at my 9-5 and on my side work.
I prefer standard and usually end up bundling it in along with stylelint-config-standard.

@mikedevita, I haven't done a project with either yet, but just curious why you prefer standard over prettier. I know prettier has a setting to kill semi-colons if you don't want them.

I have no pref over one or the other I've never used prettier.

I think for this project standard is too opinionated. I would recommend we move forward with a slim lint config that covers potential errors/bugs.

Regarding a standard you could incorporate airbnb's standard and rules. they have documented quite a lot and given their reasons.airbnb standards

so regarding your rules in this template. you based it off airbnb . But made some modifications?

This seems simple enough for a first PR.
So the consensus was to use ESLint recommended?
Seems like this was already done:
"extends": [
      "eslint:recommended",
      "plugin:import/errors",
      "plugin:import/warnings"
    ],

cc @coryhouse

The part we want to simplify is the rules section of the package.json

Okay so:

Remove rules from package.json
Use prettier or  prettier-eslint to format the code based on the rules we removed in step 1 ?

Not sure.
@coryhouse & @nickytonline,
How do you feel about the eslint rules? Should adopt or create a single preset that has all options needed? Or should we just remove rules and use the presets we currently have?
👍

Since this is a boilerplate, I'd either remove all rules or go with a standard preset.

Agreed. Any recommendations? I don't think the presets we have are very helpful safety for a starter.

I agree that the loose settings we have now aren't the ideal - they're really my unique preferences. I'd suggest just using a standard preset.

@coryhouse @kwelch so we would like to have a preset but Airbnb is not a good candidate? what about eslint-config-standard and eslint-config-standard-react. I would also move all the rules to a .eslintrc file. Happy to attempt a PR if you like.


shift $ while in visual mode selects beyond end of line error

Place editor into visual mode

shift $ to select to end of line - goes beyond end of line

This is the expected behavior. In vim's visual mode, the $ motion moves the cursor beyond the end of the line, highlighting the newline. In Atom, selections that extend beyond the end of a line are displayed like this. To display them differently would require implementing an alternative selection system, which I don't think makes sense for this package. Functionally though, this behavior is the same as vim's. The difference is only cosmetic.

Let me know if you have any suggestions for how to improve this. Currently though, I don't see a good way.

I believe you are wrong about that. I've never seen that in vim. Here a pic of vim in the terminal with the same file:

Big difference between real vim and atom. Atom extended the selection past the eol character, vim does not.

I'm pretty sure that in your screenshot, the selection extends beyond the end of the line. To test this:

Open a file with this text

line-1
line-2
line-3

Place cursor at the beginning of the line-2
Type v $
Type d
See that the line-break between line-2 and line-3 was deleted, leaving only two lines.

You are right v$d deletes to the end of line including the line ending
resulting in the line bellow on the current line.
Note this is different from d$ which does not delete the line ending.
This is inconsistent but it is also inconsistent in vim. So atom is showing
the correct yet annoying behaviour.
On Tue, 20 Jan 2015 23:29 Max Brunsfeld<EMAIL_ADDRESS>wrote:

I'm pretty sure that in your screenshot, the selection extends beyond the
end of the line. To test this:

Open a file with this text

line-1
line-2
line-3

Place cursor at the beginning of the line-2
Type v $
Type d
See that the line-break between line-2 and line-3 was deleted,
leaving only two lines.

—
Reply to this email directly or view it on GitHub
https://github.com/atom/vim-mode/issues/491#issuecomment-70756332.

You are correct. I stand corrected. Perhaps it is the amount past the eol that is throwing me off in atom. In any case, I apologize for the false alarm. I'm really stoked by atom's vim emulation. Thank you for your support of this excellent plugin.

@jeffschwartz, no problem at all; thanks for participating in the issues on this project!


HLIL removing firmware busy loops

Version and Platform (required):

Binary Ninja Version: latest dev (3.5.4409) + stable
OS: ubuntu
OS Version: 18.04
CPU Architecture: x86_64

Bug Description:
HLIL + Pseudo C removing busy loops
Steps To Reproduce:

Open a file like this: in binary ninja bin.zip, (built binary of this github example).
go to main in Dissasembly, LLIL or MLIL view, note the presence of busyLoop
change to HLIL or Pseudo-C, busyLoop is gone

Expected Behavior:

unconditional function call to busyLoop should still be there

Additional Information:
im assuming this is doing some elimination of functions that "don't have side effects", when in this case main makes a whole heck of a lot more sense with the call to busyLoop than without, it's little things like this that make using binary ninja a little more painful to use for firmware re.
I'm also assuming that this has been mentioned before and might be tracked somewhere, so apologies for duplication if so

This can be fixed by setting busyLoop to non-pure. Go to function busyLoop, right click, Edit function Properties.... In the dialog that shows up, uncheck the pure option. Then the HLIL of main should not included calls to it.


build(worker): upgrade to the latest angular version

This change is required to properly downlevel decorators to static properties. The previous version of angular/compiler-cli didn't do this correctly.


Corrected code for delete button

block was closed with parenthesis.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for fixing this. I took this opportunity to lock down the devDependencies in package.json as well.


samplerFilterMinmax enabled by default

Short info header:

GFX version: gfx-backend-vulkan 0.7.0
OS: Arch Linux
GPU: GeForce GT 730
Gfx and wgpu-rs examples fails with "Unknown device creation error: ERROR_FEATURE_NOT_PRESENT".
Short investigation showed me that samplerFilterMinmax feature enabled by default here
but for my GPU this feature is not supported.

vulkaninfo cut:
VkPhysicalDeviceVulkan12Properties:
driverID                                             = DRIVER_ID_NVIDIA_PROPRIETARY
driverName                                           = NVIDIA
driverInfo                                           = 460.56
conformanceVersion                                   = <IP_ADDRESS>
VkPhysicalDeviceVulkan12Features:
...
runtimeDescriptorArray                             = true
samplerFilterMinmax                                = false
scalarBlockLayout                                  = true
...

Oh snap, thank you for filing!
So Vulkan 1.2 includes the extension in the core, but there is still a flag to check, which we missed.
Would you want to make a PR to fix this? That would be wonderful!

What happens when sampler_filter_minmax is not supported? Since it (and imagless_framebuffer) aren't in hal::Features, would a user of gfx be able to tell if the support is available?

@tangmi I was thinking that we'd just not expose ImageFeature::SAMPLED_MINMAX in this case in any format.

@kvark I assume the image format feature flags we get from Vulkan just won't have SAMPLED_IMAGE_FILTER_MINMAX if the device feature is disabled.
This was definitely my mistake from the device creation refactor, I think the PR I opened addresses it.

@tangmi I'm afraid this may be a bit trickier than this. Vulkan clients are expected to ignore the flags they aren't supposed to know about. So if the client (which is gfx-backend-vulkan in our case) doesn't request any sampler reduction feature/extension, they can still get the format feature bits, but they are supposed to ignore them :/
This means even with the PR you made, gfx may return the SAMPLED_IMAGE_FILTER_MINMAX feature on some formats, erroneously.

@kvark Aight I'll make a follow-up PR soon to plumb supports_sampler_filter_minmax through to the image features functions


[Proposal] Ignore cells for testing

I use simple-excel to diff generated excels, this is an continious process. It would be nice if there is a ignore on defined cells.
Example
java.lang.AssertionError: Comparing DemoExcelFile
Expected: entire workbook to be equal
     but: cell at "B4" contained <"2013-12-05 12:40:49.309"> expected <"2013-12-06 12:41:29.424">,
[..]

Also asked for in #9.
Think it's a good idea but don't think I'll have any time soon to get to it. PRs welcome.


Spiral Traversal of Matrix

Solution to - Given a Matrix, print the given matrix in spiral order problem

@nikhildixit27  Thank You for your contribution


NIFI-12993 Add auto commit feature and add batch processing

NIFI-12993 PutDatabaseRecord: add auto commit property and fully implement Batch Size for sql statement type

Summary
NIFI-12993
PutDatabaseRecord: add auto commit property and fully implement Batch Size for sql statement type
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[X] Apache NiFi Jira issue created

Pull Request Tracking

[X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-12993
[X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-12993

Pull Request Formatting

[X] Pull Request based on current revision of the main branch
[X] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
I added unit tests to cover many significant combinations of property values
Build

[X] Build completed using mvn clean install -P contrib-check

[X] JDK 21

Licensing
No new dependencies added
Documentation

[X] Documentation formatting appears as expected in rendered files

Reviewing...

I recommend putting all the unit tests in one file and not using abbreviations for the test name.

@dan-s1 I accidentally hit a button that requested yoiu rereview this PR. That is up to you. I intended to ask for the rereview from mattyb149 and he intends to look at it.


Drop efi package from framework

The idea is that for the installation, the source rootfs already contain the needed efi files as they were installed from their own sources.
For bulding the iso the packages are still shipped as part of the osbulder, but the framework should not need it anymore

oh shit, the diff works also when removing packages, nice!


json: cannot unmarshal array into Go struct field Control.Skips of type map[string]bool

Environmental Info:
K3s Version:
k3s version v1.18.9+k3s1 (630bebf9)
Node(s) CPU architecture, OS, and Version:
Linux worker2 5.4.0-1019-raspi #21-Ubuntu SMP PREEMPT Mon Sep 14 07:20:34 UTC 2020 aarch64 aarch64 aarch64 GNU/Linux
Cluster Configuration:
1 master 4 workers
Describe the bug:
simple node can't connect to master after fresh install of k3s due to Oct 04 13:48:56 worker2 k3s[3397]: time="2020-10-04T13:48:56.690614656Z" level=error msg="json: cannot unmarshal array into Go struct field Control.Skips of type map[string]bool"

nvm, I noticed that k3s allows to join mastert with lower version which might be incompatible, the solution is to upgrade master


feat: hcp vault integration

Summary
HCP Vault integration. Includes a dashboard that uses data from audit logs and metrics.
The owners of this repo are not experts in the subject matter of the quickstarts. We review for the quickstart to be functional and for security risks. If you are seeking feedback on the content of the quickstart, please seek out a subject matter expert. If you are not an internal NR contributor, we can do our best to connect you with a content reviewer.

Pre merge checklist

[x] Did you check you NRQL syntax? - Does it work?
[x] Did you include a Data source and Documentation reference?
[x] Are all documentation links publicly accessible?
[x] Did you check your descriptive content for voice and tone?
[x] Did you check your descriptive content for spelling and grammar errors?
[x] Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

[x] Does the PR contain a screenshot for each of your dashboards?
[x] Do your screenshots show data?
[x] Has the sanitization script been run on each dashboard?

Alerts

[x] Did you check that your alerts actually work?

@rahulbasu-nr , trying to bring this back up to remove it from the stale category.


Maximum context length exceeded

Background
From the readme:

When the number of documents fetched leads to a request above the token limit, the library uses the following strategy -

It runs a preprocessing step to select relevant sections from each document until the total number of tokens is less than the maximum number of tokens allowed by the model. It then uses the transformed documents as context to answer the question.

Issue
I'm not finding that this preprocessing step is happening. I've run into these context length errors on both GPT 3.5 Turbo and GPT 4o.
I understand I can do these workarounds:

Set the search result limit with setSearchResultCount()
Roll my own preprocessor

But in order to take advantage of the described preprocessor, is there something specific I need to do?
My setup
I can confirm my setup works when I load less data. Essentially, I'm loading sanitized emails as a JSON objects. With 5 emails loaded, it's fine. With 10 emails loaded, I'm hitting the token limit.
My builder setup:
const ragInstance = await new RAGApplicationBuilder()
    .setModel(SIMPLE_MODELS.OPENAI_GPT4_O)
    .setEmbeddingModel(new OpenAi3SmallEmbeddings())
    .setVectorDb(new HNSWDb())
    .setCache(new MemoryCache())
    .build();

My loader:
// for each `message` object...
const loaderSummary = await ragApplication.addLoader(
   new JsonLoader({ object: message })
);

My EmbedJS version:
"@llm-tools/embedjs": "^0.0.91",

Actually, it seems like the error is happening when I load resources. Here is how I am loading the resources:
const loadResources = async (ragApplication, messages) => {
  console.log("RAG Application:", ragApplication);

  const loaderSummaries = await Promise.all(
    messages.map(async (message) => {
      console.log("Adding loader for:", message.subject);

      const loaderSummary = await ragApplication.addLoader(
        new JsonLoader({ object: message })
      );

      return loaderSummary;
    })
  );

  console.log(
    "\nLoader summaries:\n",
    loaderSummaries.map((summary) => JSON.stringify(summary)).join("\n")
  );

  return loaderSummaries;
};

The final console log is never called, so the error must be triggered during the addLoader() calls.
Adding a stack trace in case that's useful:
BadRequestError: 400 This model's maximum context length is 8192 tokens, however you requested 10387 tokens (10387 in your prompt; 0 for the completion). Please reduce your prompt; or completion length.
    at APIError.generate (file:///Users/ash/dev/email-rag/node_modules/openai/error.mjs:41:20)
    at OpenAI.makeStatusError (file:///Users/ash/dev/email-rag/node_modules/openai/core.mjs:268:25)
    at OpenAI.makeRequest (file:///Users/ash/dev/email-rag/node_modules/openai/core.mjs:311:30)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async file:///Users/ash/dev/email-rag/node_modules/@langchain/openai/dist/embeddings.js:268:29
    at async RetryOperation._fn (/Users/ash/dev/email-rag/node_modules/p-retry/index.js:50:12)

I think I'm zeroing in on the issue.
I'm not exceeding the context limit for the main model, but for the embedding model. This implied to me that the preprocessing step doesn't apply to the embedding process.
I'll keep poking.

Hey @ashryanbeats, yes - the preprocessing is not done for the embeddings. In embeding, its either all or nothing right now. The library usually breaks the loaded content sent into smaller chunks but that is not done for JSON loader.
I am thinking, we should have it auto break JSON into smaller embedding documents if the text is too large. But what chunking strategy to use needs more thought.


count glossary results and show in left hand menu

Fix for Issue #2605

Local tests were successful and the changes are approved.
Thank you @Crystalskulls !


libnfc: Support static builds

Description of changes
Makes building pkgsStatic.libnfc possible. I made it as part of static-haskell-nix.
Uses not-yet-merged patch from: https://github.com/nfc-tools/libnfc/pull/595
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Found via: https://github.com/nh2/static-haskell-nix/pull/116

@offlinehacker Short ping regarding this small PR :)


Dimitrifc patch 1

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes

0 out of 2 committers have signed the CLA.

[ ] Your Name
[ ] dimitrifc

Your Name seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.


Add to fdroid and/or google play

If you could get this app on fdroid and/or Google play, it would be awesome!

If you could get this app on fdroid and/or Google play, it would be awesome!

Thanks for mentioning it. I am working on it.


Support for databinding button attributedTitle or titleLabel.attributedText

It'd be great if it were possible to do either of the following:
<UIButton image="IconFacebook" class="signInButton" style="systemButton" titleLabel.attributedText="$signInWithFacebookAttrText" onPrimaryActionTriggered="..."/>
or
<UIButton image="IconFacebook" class="signInButton" style="systemButton" attributedLabel="$signInWithFacebookAttrText" onPrimaryActionTriggered="..."/>
Currently, the first seems to do nothing while the second crashes out. I'd love to take a crack at implementing and PRing this myself but I'm rather new to the project and don't know much about it.

You can't actually set a button's attributed text via the titleLabel property - you need to set it like this:
button.setAttributedTitle(NSAttributedString(string: "Press Me!"), for: .normal)

The same applies to a button's plain text and image. MarkupKit adds title and image properties to UIButton that internally call setTitle:forState: and setImage:forState: so you can set these values in markup:
<UIButton title="Hello" image="hello.png"/>

However, I have not added a similar property for attributed text since (to my knowledge) there's no standard way to declaratively represent an attributed string. I've considered supporting RTF or inline HTML, but neither one is ideal. RTF isn't very common, and this would be pretty ugly:
<UIButton title="Hello"/>

In any case, I'm still thinking about it since I do think it would be useful to support declarative attributed text. In the meantime, my suggestion would be to declare an outlet for your button and just set the attributed text programmatically.

Makes sense.
I agree that there's not a great way to handle attributed text, however the ability to databind the attributed text of a label to a variable is nice as it at least removes the need for an iboutlet and allows looser coupling of the code to the view, even if the attributed text string still has to be built programattically. Something like this for buttons would be excellent.

I could see potentially adding an attributedTitle property to UIButton that works similarly to how title and image currently work. You could actually do this in app code as well.

I just prototyped this and I think it makes sense to add it to the platform. I will probably try to include it in the next release.

This has been committed to the development branch and will be included in the next release.


Fix the bug: tensorrt-cpp input blob from BGR to RGB

Opencv imread operation reads the image in BGR format. So when creating the input blob, we should make sure it is in RGB format before inferencing on the network. I had a lower accuracy in the existing code and this conversion of input blob to RGB format improved the accuracy.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


OSError while installing through nimble

I'm on Windows 10, and while using the command nimble install gintro I'm getting the following error:
preparing gintro nimgrab.nim(35)          nimgrab nimgrab.nim(16)          syncDownload urldownloader.nim(413)   downloadToFile oserr.nim(110)           raiseOSError Error: unhandled exception: The specified protocol is unknown.  [OSError]

zetashift: update your Putty client

As it still seems not to work for you:
Try if a plain command like
exec("nimgrab 'https://raw.githubusercontent.com/StefanSalewski/oldgtk3/master/oldgtk3/gobject.nim' gobject.nim")
works for you. If it does not work, maybe try with other download files.
Generally that should work.
If we do not get that working, we have a bunch of possible solutions:

Add the needed files from oldgtk3 to gintro package

Download full oldgtk3 with a git clone command.

Require full oldgtk3 from nimble before install.

But the main question is, if after a successfully download gintro would work at all for Windows. I will investigate this issue further if someone is really interested of USING gintro on Windows, that is creating a larger GTK3 application.

I figured it out! Removing the single quotation marks around the 'https://raw.githubusercontent.com/StefanSalewski/oldgtk3/master/oldgtk3/gobject.nim
in gintro.nimble fixed it for nimgrab and wget. Now I'm just getting libglib-2.0.0.dll missing error but that's just a dependency I haven't installed yet.
Thank you :D

Alright so far:

Remove the quotation marks from the download url
Install msys2 and run: pacman -S mingw-w64-x86_64-gtk3 then run: pacman -S mingw-w64-x86_64-python3-gobject to get the other required dlls's.

Now I get the following error:
Remaining delayed methods: 0
Typelib file for namespace 'GtkSource' (any version) not found

** (gen.exe:2016): CRITICAL **: g_irepository_get_dependencies: assertion 'typelib != NULL' failed
Traceback (most recent call last)
gen.nim(1717)            gen
gen.nim(1400)            main
SIGSEGV: Illegal storage access. (Attempt to read from nil?)
stack trace: (most recent call last)
C:\Users\rskar\Documents\workspace\gintro\gintro.nimble(74) installBefore
C:\Users\rskar\Documents\workspace\gintro\gintro.nimble(62) prep

Great.
GtkSource is for GtkSourceView, which is used for editors like GEdit, Aporia, NEd...
It may be that you have to install it separately for your Windows GTK, maybe there is a separate package. But most people should not need GtkSource, basic examples should work without it.
So generally you could skip/remove line 1717 (main("GtkSource")) from file gen.nim.
Unfortunately I don't know how you can do it locally now -- with the older package variant it was easier, because that used "nimble prepare" followed by "nimble install" both executed from inside gintro directory. That was available for nearly one year, but no one has tried. Now it is gone, sorry.

It worked holy snap!
So after the previous steps I commented line 1717 out and then I had to copy-paste the .nimble from the gintro folder to my /AppData/Local/Temp folder.
Then I had to copy-paste the gintro folder(containing all the relevant nim files) to my /.nimble/pkgs/gintro-0.4.0/
All the examples work. Thanks again for your time :D.

Great.
I have just created a nimgrab issue about the single quotes. It was a bit strange that it worked fine for Linux. I should be able to push a updated gintro.nimble without the quotes in a few days, then a plain  "nimble install gintro" should work.
Can you tell us how you have installed the GTK libs for your Windows 10?
And what was special with package GtkSource?
I would like to add that information to tutorial.

For the GTK libs I did according these instructions(https://www.gtk.org/download/windows.php):
Install MSYS2
In the msys2 cmd I entered:
pacman -S mingw-w64-x86_64-gtk3
Then for some other necessary depencies(girepository.dll) you need to do:
pacman -S mingw-w64-x86_64-python3-gobject
I'm not sure about the GtkSource error, as I don't know that much about GTK.


Support beacon chain full withdrawals

Beacon Chain spec defines the withdrawal indices: https://github.com/ethereum/consensus-specs/blob/dev/specs/capella/beacon-chain.md#withdraw
Theses are the indices in the withdrawal queue, they are completely independent from deposit or validator indices.
By maintaining the nextWithdrawalIndex in the blockReward contract, we ensure that user cannot request to process withdrawals which haven't happened yet.
The overall logic behind withdrawal processing is then the following:

Validator $A$ exits from the beacon chain or is being slashed
After some timeout in the beacon chain, the withdrawal is created and placed onto the queue under index $B$
The withdrawal from the queue is included into one of the upcoming proposed EL blocks.
While processing EL block, the block reward contract is being called, which records the withdrawal in the contract storage. The nextWithdrawalIndex is being updated to a value larger than $B$
User calls depositContract.withdraw([A], wrapper, abi.encode(gno, receiver)). This will unlock/mint additional mGNO, send them to wrapper contract, which will in its turn burn received mGNO and unlock required amount of GNO.
If the amount of required GNO is not enough, user can exit to mGNO instead depositContract.withdraw([A], user, '0x').
Obtained mGNO can be then swapped to GNO by calling wrapper.unwrapTokens(gno, user, mGNO.balanceOf(user)).

Dedicated third-party that is responsible for GNO refills, monitors the available surplus of locked GNO token by using a read-only Lens contract.

Current dev team is finalizing the design of withdrawals and wanted to comment on the different trade-offs of this proposal.
Current goals

In the happy case, user should not be required to perform any transaction to have credited the final* token at the withdrawal address
System should handle insolvency gracefully, respecting goal 1.
System should require as little intervention from devops as possible, provided that GNO token is not mintable.

This PR's proposal
Uses POSDAO block processing existing system transaction infra add the withdrawal structs to contract state. Then requires an external actor to call withdrawal to actually credit stakers accounts. This approach breaks goal 1.
Alternative proposal
Use POSDAO block processing existing system transaction infra to credit user's accounts directly. Handle insolvency by queuing pending withdrawals and clear them on a future system transaction. For more details see: https://hackmd.io/@dapplion/gnosiswithdrawals


[Feature suggestion] GM background tint for notes not yet shared to players

Hello,
The GM lacks a way to actually know what has been shared to players or not.
I suggest a (GM only) background tint setting for not yet shared notes, like this (reds are not yet shared):

Without it, all notes looks the same, and the GM has to double-click a note to know what its state is.

Add in V2.3

@farling42
As the GM the tint doesn't change when I change the state of a note from "not shared" to "shared".
I have a tint for not shared notes, but left the color field blank for shared notes.

I think it only really works if you set both. Since it permanently changes the note's icon tint to the value that you specify in the window.
There is no memory of the "original" icon tint from before the module started changing the icon tint.

@farling42 but it should set the tint back to "blank".

Ah, my intention was that a blank entry for this module would not affect the note's tint colour at all, rather than setting it back to blank.
I will have to work out a way of having a different option to enable/disable tinting if a blank entry is a valid icon tint setting.

V2.4 now only changes the icon tint temporarily, so the original value from the Note Configuration window will be used if the module's icon tint is left blank.

Great! Thx :)


Shapely 1.6.x is not supported by MapProxy 1.10.*

I've receiving the following error message, when I've try to load coverages:

Traceback (most recent call last):
  File "/usr/local/mapproxy/bin/mapproxy-seed", line 11, in <module>
    sys.exit(main())
  File "/usr/local/mapproxy/lib/python2.7/site-packages/mapproxy/seed/script.py", line 360, in main
    return SeedScript()()
  File "/usr/local/mapproxy/lib/python2.7/site-packages/mapproxy/seed/script.py", line 218, in __call__
    seed_tasks = seed_conf.seeds(seed_names)
  File "/usr/local/mapproxy/lib/python2.7/site-packages/mapproxy/seed/config.py", line 201, in seeds
    seed_conf = SeedConfiguration(seed_name, seed_conf, self)
  File "/usr/local/mapproxy/lib/python2.7/site-packages/mapproxy/seed/config.py", line 282, in __init__
    ConfigurationBase.__init__(self, name, conf, seeding_conf)
  File "/usr/local/mapproxy/lib/python2.7/site-packages/mapproxy/seed/config.py", line 228, in __init__
    self.coverage = self._coverages()
  File "/usr/local/mapproxy/lib/python2.7/site-packages/mapproxy/seed/config.py", line 237, in _coverages
    coverages = [self.seeding_conf.coverage(c) for c in self.conf.get('coverages', {})]
  File "/usr/local/mapproxy/lib/python2.7/site-packages/mapproxy/util/py.py", line 79, in wrapper
    cache[key] = func(self, *args, **kwargs)
  File "/usr/local/mapproxy/lib/python2.7/site-packages/mapproxy/seed/config.py", line 153, in coverage
    coverage = load_coverage(coverage_conf)
  File "/usr/local/mapproxy/lib/python2.7/site-packages/mapproxy/config/coverage.py", line 81, in load_coverage
    require_geom_support()
  File "/usr/local/mapproxy/lib/python2.7/site-packages/mapproxy/util/geom.py", line 51, in require_geom_support
    raise ImportError('Shapely required for geometry support')
ImportError: Shapely required for geometry support

Context
I've installed MapProxy 1.10.4 and the latest version of the Shapely library (1.6.2). When I use the previous version Shapely 1.5.17, then it works as expected.
Expected Behavior
If MapProxy 1.10.x does not support the newer version of the Shapely library, I've expected a dependency error, when I run pip install Shapely or it automatically installs the max supported version of the library
Actual Behavior
If I install Shapely via pip install shapely, it installs automatically the latest version 1.6.2

MapProxy does work with Shapely 1.6.2. Can you reinstall Shapely 1.6.2 copy the output?

I think this is related to https://github.com/mapproxy/mapproxy/commit/928b185a9737bb9472920a3bedd0bc25ed80a80b
So this is fixed in master and will be fixed in 1.11.0.

Same here when working with GeoJSON or ESRI Shapefile coverages:
Traceback (most recent call last):
  File "c:\users\fdetsch\anaconda3\lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "c:\users\fdetsch\anaconda3\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "C:\Users\fdetsch\Anaconda3\Scripts\mapproxy-util.exe\__main__.py", line 9, in <module>
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\script\util.py", line 387, in main
    commands[command]['func'](args)
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\script\util.py", line 85, in serve_develop_command
    app = make_wsgi_app(mapproxy_conf, debug=options.debug)
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\wsgiapp.py", line 110, in make_wsgi_app
    services = conf.configured_services()
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\config\loader.py", line 211, in configured_services
    return self.services.services()
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\config\loader.py", line 1770, in services
    new_services = creator(service_conf or {})
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\config\loader.py", line 1921, in demo_service
    lyr = layer_conf.wms_layer()
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\util\py.py", line 78, in wrapper
    cache[key] = func(self, *args, **kwargs)
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\config\loader.py", line 1619, in wms_layer
    map_layer = self.context.caches[source_name].map_layer()
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\util\py.py", line 78, in wrapper
    cache[key] = func(self, *args, **kwargs)
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\config\loader.py", line 1536, in map_layer
    for grid, extent, tile_manager in self.caches():
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\util\py.py", line 78, in wrapper
    cache[key] = func(self, *args, **kwargs)
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\config\loader.py", line 1445, in caches
    request_format=request_format,
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\config\loader.py", line 1339, in _sources_for_grid
    source = source_conf.source({'format': request_format})
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\config\loader.py", line 949, in source
    coverage = self.coverage()
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\util\py.py", line 78, in wrapper
    cache[key] = func(self, *args, **kwargs)
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\config\loader.py", line 545, in coverage
    return load_coverage(self.conf['coverage'])
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\config\coverage.py", line 81, in load_coverage
    require_geom_support()
  File "c:\users\fdetsch\anaconda3\lib\site-packages\mapproxy\util\geom.py", line 55, in require_geom_support
    raise ImportError('Shapely required for geometry support')
ImportError: Shapely required for geometry support

MapProxy 1.11.0 is running in a conda environment:
(MapProxy) C:\Users\fdetsch\mymapproxy>mapproxy-util --version
MapProxy 1.11.0

Shapely has been installed using pip (as suggested here) and should hence be available:
(MapProxy) C:\Users\fdetsch\mymapproxy>pip show Shapely
Name: Shapely
Version: 1.6.4.post1
Summary: Geometric objects, predicates, and operations
Home-page: https://github.com/Toblerity/Shapely
Author: Sean Gillies
Author-email<EMAIL_ADDRESS>License: BSD
Location: c:\users\fdetsch\anaconda3\envs\mapproxy\lib\site-packages
Requires:


chore: add option to skip properties for a node

@losisin Would you interested in merging a feature like this ?
Usecase:
labels:
  default:
    app.k8s.io:/name: abc
    app.k8s.io/namespace: def

Ideally, in this case I would only want labels.default to be an object, and not have any  properties as the yaml is completely a user input blob, and can have any properties
So adding skipProperties: true here would not those in schema

@losisin Thanks for approving the changes, I think the Test CI workflow is waiting for your approval

I like the initial better. If you can add test cases I can merge it.

@losisin Have added tests and made sure coverage is at 100%
Let me know if anything else is required


Adopt MIDI 2.0

Currently @midi.channel only allows values up to 16, which complies with MIDI 1.0. MIDI 2.0 extends it to 256. this should also be allowed in MEI.

It seems to me that there is enough difference with MIDI 2.0 that it isn’t simply a matter of increasing the allowed values. We would probably want a way to signal that any MIDI encoding was 2.0, otherwise 1.0-only clients would try to interpret it and get it wrong.


only 0.26 is work for me now .. [0.26.0 + is not work for me .. ]

my project is https://github.com/sndnvaps/TelegramImageBot
php := 5.5

@my bot name is @nx511jbot

There was a lot of changes between 0.26.0 and the latest version, that bot might not be compatible with new version of the library.
You could either stick with 0.26.0 for your project (not recommended) or adjust your project's code to the new version of the library.
One thing for sure that needs to be changed: InlinequeryCommand.php now requires different usage.

@sndnvaps as jacklul said lot of things has change for 0.26.
You need also to change also the log system:
https://github.com/sndnvaps/TelegramImageBot/blob/master/webhook.php#L17
I think that you can be able to exploit the latest version without too much work since your project don't need the database!
Let us know if you manage!

@MBoretto you mean like this https://github.com/akalongman/php-telegram-bot/blob/master/examples/hook.php#L42
@jacklul -InlinequeryCommand.php this php should be remove ?...

change the webhook.php && sethook.php to make it support the latest version ,do it right ?

Should do the trick!

commit 34ad807ff2d8622f1b4bf0a5bfdb4d0563448c1e
Author: sndnvaps<EMAIL_ADDRESS>Date:   Mon Aug 1 20:13:52 2016 +0800

    test for v0.35.0

    Signed-off-by: sndnvaps<EMAIL_ADDRESS>
diff --git a/sethook.php b/sethook.php
index f90d98f..a3a88a2 100644
--- a/sethook.php
+++ b/sethook.php
@@ -23,4 +23,3 @@ try {
 } catch (Longman\TelegramBot\Exception\TelegramException $e) {
     echo $e;
 }
-?>
diff --git a/webhook.php b/webhook.php
index 0622152..c7d57bb 100644
--- a/webhook.php
+++ b/webhook.php
@@ -1,29 +1,58 @@
 <?php
-$loader = require __DIR__.'/vendor/autoload.php';
+//README
+//This configuration file is intended to run the bot with the webhook method.
+//Uncommented parameters must be filled
+//Please notice that if you open this file with your browser you'll get the "Input is empty!" Exception.
+//This is a normal behaviour because this address has to be reached only by Telegram server.
+// Load composer
+require __DIR__ . '/vendor/autoload.php';

 $API_KEY = '208507836:AAFMs8GPofnGePWCn3lnVkKutAyff2R-MYw';
 $BOT_NAME = 'nx511jbot';
-$COMMANDS_FOLDER = __DIR__.'/Commands/';

+$commands_path = __DIR__ . '/Commands/';
 $upload_path = __DIR__ . '/Upload/';
-
+//$mysql_credentials = [
+//    'host'     => 'localhost',
+//    'user'     => 'dbuser',
+//    'password' => 'dbpass',
+//    'database' => 'dbname',
+//];
 try {
-    // create Telegram API object
+    // Create Telegram API object
     $telegram = new Longman\TelegramBot\Telegram($API_KEY, $BOT_NAME);
-
-    // set up Upload pic path
-	$telegram->setUploadPath($upload_path);
-    // Log Telegram messages
-    $telegram->setLogRequests(true);
-	$telegram->setLogPath($BOT_NAME.'.log');
-	$telegram->setLogVerbosity(1);
+    //// Enable MySQL
+    //$telegram->enableMySQL($mysql_credentials);
+    //// Enable MySQL with table prefix
+    //$telegram->enableMySQL($mysql_credentials, $BOT_NAME . '_');
+    //// Add an additional commands path
+
+    $telegram->addCommandsPath($commands_path);

-	// Custom commands folder
-	$telegram->addCommandsPath($COMMANDS_FOLDER);
-
-    // handle telegram webhook request
+    //// Here you can enable admin interface for the channel you want to manage
+    //$telegram->enableAdmins(['your_telegram_id']);
+    //$telegram->setCommandConfig('sendtochannel', ['your_channel' => '@type_here_your_channel']);
+    //// Here you can set some command specific parameters,
+    //// for example, google geocode/timezone api key for date command:
+    //$telegram->setCommandConfig('date', ['google_api_key' => 'your_google_api_key_here']);
+    //// Logging
+    //\Longman\TelegramBot\TelegramLog::initialize($your_external_monolog_instance);
+    //\Longman\TelegramBot\TelegramLog::initErrorLog($path . '/' . $BOT_NAME . '_error.log');
+    //\Longman\TelegramBot\TelegramLog::initDebugLog($path . '/' . $BOT_NAME . '_debug.log');
+    //\Longman\TelegramBot\TelegramLog::initUpdateLog($path . '/' . $BOT_NAME . '_update.log');
+    //// Set custom Upload and Download path
+    //$telegram->setDownloadPath('../Download');
+    $telegram->setUploadPath($upload_path);
+    //// Botan.io integration
+    //$telegram->enableBotan('your_token');
+    // Handle telegram webhook request
     $telegram->handle();
 } catch (Longman\TelegramBot\Exception\TelegramException $e) {
-    // log telegram errors
+    // Silence is gold!
     // echo $e;
+    // log telegram errors
+    \Longman\TelegramBot\TelegramLog::error($e);
+} catch (Longman\TelegramBot\Exception\TelegramLogException $e) {
+    // Silence is gold! Uncomment this to catch log initilization errors
+    //echo $e;
 }

and change composer.json to 0.35, but not work for me ...

@sndnvaps I've edited your comment to remove your API key and bot name. Take care of them, they are to be kept secret.

[root@telbot bot]# composer update
You are running composer with xdebug enabled. This has a major impact on runtime performance. See https://getcomposer.org/xdebug
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Removing longman/telegram-bot (0.29)
  - Installing longman/telegram-bot (0.28.0)
    Loading from cache

Writing lock file
Generating autoload files

now work on botname v. 0.27.0

my composer.json is
{
    "require": {
        "longman/telegram-bot": "^0.28.0"
    }
}

when use other command , it will set whoami command to my bot , and get the loop of set it ..

Please try enabling the logging and see if there is any error output to help find the problem.
Just below initialising the $telegram object:
$telegram = new Longman\TelegramBot\Telegram($API_KEY, $BOT_NAME);

// Logging
Longman\TelegramBot\TelegramLog::initErrorLog(__DIR__ . '/' . $BOT_NAME . '_error.log');
Longman\TelegramBot\TelegramLog::initDebugLog(__DIR__ . '/' . $BOT_NAME . '_debug.log');
Longman\TelegramBot\TelegramLog::initUpdateLog(__DIR__ . '/' . $BOT_NAME . '_update.log');

Any news?

non... i just not use it ..
make me so confuse ..

Hmm, this is very strange.
Have you tried updating to the latest version 0.35?
It makes sense to keep your library up to date, because Telegram makes changes too that will otherwise not work properly.

i have try it , still not work ..
in 0.26,0.27, it can run .
but >= 0.28 it just not work for me ..

Could you post the current hook.php you're using?
I'll then modify it to include something to help debug the problem 👍

this is my sethook.php file
<?php
//Composer Loader
$loader = require __DIR__.'/vendor/autoload.php';

$API_KEY = 'you_api_token';
// botname cann't contain with '@'
$BOT_NAME = 'bot_name';
$hook_url = 'https://www.youdomain.com/path/to/webhook.php';
// you should put certificate under ./cert folder
// the server.crt should sign the nginx as same
//
#$certificate_file = __DIR__.'/cert/server.crt';
try {
    // create Telegram API object
    $telegram = new Longman\TelegramBot\Telegram($API_KEY, $BOT_NAME);
    // set webhook

    $result = $telegram->setWebHook($hook_url);
    //$result = $telegram->setWebHook($hook_url, $certificate_path);
    if ($result->isOk()) {
        echo $result->getDescription();
    }
} catch (Longman\TelegramBot\Exception\TelegramException $e) {
    echo $e;
}

That's the sethook.php, not hook.php.
Anyway, add the following line to the hook.php file, just under the $telegram = ... line, like so:
// create Telegram API object
$telegram = new Longman\TelegramBot\Telegram($API_KEY, $BOT_NAME);

// test with custom input
$telegram->setCustomInput('{"update_id":12345, "message":{"message_id":1,"from":{"id":<your-id>,"first_name":"First","username":"<your-username>"},"chat":{"id":<your-chat-id>,"first_name":"First","username":"<your-username>","type":"private"},"date":1,"text":"\/echo Working!"}}');

Be sure to change the <your-*> fields to the correct values. For a private chat, <your-id> and <your-chat-id> will be the same.
Now call the hook.php file directly in your web browser. You should get a Working! message on Telegram and the output of the page should be empty.
If there is an error there, post it here please.

@sndnvaps Any update on this?

closing feel free to reopen


Missing keys in state_dict

I am trying to test on my own images with the following code:
python test_sirs.py --inet dsrnet_l --model dsrnet_model_sirs --dataset sirs_dataset  --name dsrnet_l_4000_test --hyper --if_align --resume --weight_path "./weights/dsrnet_s_epoch14.pt" --base_dir "my data path"
And i load the model with the weights you provided but got this error:
Missing key(s) in state_dict: "lrm.blocks_merge.2.a", "lrm.blocks_merge.2.b", "lrm.blocks_merge.2.block1.0.weight", "lrm.blocks_merge.2.block1.0.bias", "lrm.blocks_merge.2.block1.1.weight", "lrm.blocks_merge.2.block1.1.bias", "lrm.blocks_merge.2.block1.2.weight", "lrm.blocks_merge.2.block1.2.bias", "lrm.blocks_merge.2.block1.4.ca.1.weight", "lrm.blocks_merge.2.block1.4.ca.1.bias", "lrm.blocks_merge.2.block1.5.weight", "lrm.blocks_merge.2.block1.5.bias", "lrm.blocks_merge.2.block2.0.weight", "lrm.blocks_merge.2.block2.0.bias", "lrm.blocks_merge.2.block2.1.weight", "lrm.blocks_merge.2.block2.1.bias", "lrm.blocks_merge.2.block2.3.weight", "lrm.blocks_merge.2.block2.3.bias", "lrm.blocks_merge.3.a", "lrm.blocks_merge.3.b", "lrm.blocks_merge.3.block1.0.weight", "lrm.blocks_merge.3.block1.0.bias", "lrm.blocks_merge.3.block1.1.weight", "lrm.blocks_merge.3.block1.1.bias", "lrm.blocks_merge.3.block1.2.weight", "lrm.blocks_merge.3.block1.2.bias", "lrm.blocks_merge.3.block1.4.ca.1.weight", "lrm.blocks_merge.3.block1.4.ca.1.bias", "lrm.blocks_merge.3.block1.5.weight", "lrm.blocks_merge.3.block1.5.bias", "lrm.blocks_merge.3.block2.0.weight", "lrm.blocks_merge.3.block2.0.bias", "lrm.blocks_merge.3.block2.1.weight", "lrm.blocks_merge.3.block2.1.bias", "lrm.blocks_merge.3.block2.3.weight", "lrm.blocks_merge.3.block2.3.bias".

This problem should be fixed by the new update. Please check it.

Since there are no further questions, we'll go ahead and close this issue for now. If you have additional questions in the future, feel free to open a new issue.


encoding differs

I am creating a base64pdf and passing it to Spatie's media library, it fails as decoding and reencoding do not match, it works when running browserShot locally.
it seems that the encode pdf returned uses a different encoder.
Sorry there's not much detail.

Thanks for reporting.
Could you at least share some code examples, what you're trying to do?
That would help me enormously as I then don't have to spend time recreating a code example from a single sentence.

Hi,
I have created a repo with a failing test.
I am trying to create a base64 version of a pdf
$pdf = SidecarBrowsershot::html($content)             ->margins(10, 18, 18, 10)             ->format('A4')             ->scale(0.8)             ->showBackground()             ->base64pdf();
and then pass it to Spatie's media Library.
$this->invoice->addMediaFromBase64($pdf,'application/pdf')->usingFileName($this->invoice->number.'.pdf')->toMediaCollection('invoices');
The issue occurs as the AddMediaFromBase64 method reencodes the base64 pdf if (base64_encode($binaryData) !== $base64data) {             throw InvalidBase64Data::create();         } this fails, which seems to indicate that the pdf is encoded differently in lambda.
Many thanks for your help.

@levisudak thanks this worked, I'll submit a PR.

Thanks for the PR @Silver343.
A new version has been tagged with this fix: https://github.com/stefanzweifel/sidecar-browsershot/releases/tag/v1.4.1.


⚠ Samsung has degraded performance

In 0986d49, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 3063 ms

Resolved: Samsung performance has improved in 1f538df.


bug: Increased stack memory usage in DemandAdder analysis

Bug Report
Cairo version: 2.0.0-rc4, also reproduces in older versions at least until 1.1.0
Scarb version: 0.5.0-alpha.2 down to 0.4.0 at least

Current behavior:
I suspect that the DemandAdder analysis is aggressively eating stack memory in some kind of recursion or looping. This seems not to be an issue in Rust release binaries, but with LTO enabled this ends up with stack overflow panics. Scarb has LTO enabled, while cairo-lang-binaries do not. macOS or Windows platforms are badly affected (1MB stack size ); Linux has higher stack size (8MB) and we didn't get any reports there.
This happens if you have Cairo code that has an array and then 10s of 1000s of appends in a row. See reproduction.
Here are the results of me trying to run Scarb over a debugger. LTO is messing things a lot :(

stack trace:
... about 20000 get_block_info entries ...
cairo_lang_lowering::borrow_check::analysis::BackAnalysis<TAnalyzer>::get_block_info 0x00000001046a6f94
cairo_lang_lowering::borrow_check::analysis::BackAnalysis<TAnalyzer>::get_block_info 0x00000001046a6f94
cairo_lang_lowering::borrow_check::analysis::BackAnalysis<TAnalyzer>::get_block_info 0x00000001046a6f94
cairo_lang_lowering::borrow_check::analysis::BackAnalysis<TAnalyzer>::get_block_info 0x00000001046a6f94
<cairo_lang_lowering::db::ConcreteFunctionWithBodyPostpanicLoweredQuery as salsa::plumbing::QueryFunction>::execute 0x00000001046d7bfc
salsa::derived::slot::Slot<Q,MP>::read_upgrade 0x0000000104668b50
<DB as cairo_lang_lowering::db::LoweringGroup>::concrete_function_with_body_postpanic_lowered::__shim 0x00000001046b7e4c
<cairo_lang_lowering::db::ConcreteFunctionWithBodyLoweredQuery as salsa::plumbing::QueryFunction>::execute 0x00000001046d8bfc
salsa::derived::slot::Slot<Q,MP>::read_upgrade 0x000000010467edfc
<DB as cairo_lang_lowering::db::LoweringGroup>::concrete_function_with_body_lowered::__shim 0x00000001046b8fd0
salsa::derived::slot::Slot<Q,MP>::read_upgrade 0x0000000104b63610
<DB as cairo_lang_sierra_generator::db::SierraGenGroup>::priv_function_with_body_sierra_data::__shim 0x0000000104bb6280
salsa::derived::slot::Slot<Q,MP>::read_upgrade 0x0000000104b61830
<DB as cairo_lang_sierra_generator::db::SierraGenGroup>::function_with_body_sierra::__shim 0x0000000104bb7404
cairo_lang_sierra_generator::program_generator::get_sierra_program_for_functions 0x0000000104b742bc
salsa::derived::slot::Slot<Q,MP>::read_upgrade 0x0000000104b6b2c0
<DB as cairo_lang_sierra_generator::db::SierraGenGroup>::get_sierra_program_for_functions::__shim 0x0000000104bb9aec
salsa::derived::slot::Slot<Q,MP>::read_upgrade 0x0000000104b66b14
<DB as cairo_lang_sierra_generator::db::SierraGenGroup>::get_sierra_program::__shim 0x0000000104bbaf1c
<scarb::compiler::compilers::lib::LibCompiler as scarb::compiler::Compiler>::compile 0x0000000104f4c9c4
scarb::ops::compile::compile 0x000000010501935c
scarb::commands::build::run 0x0000000105093854
scarb::main 0x00000001044def6c
std::sys_common::backtrace::__rust_begin_short_backtrace 0x0000000105095b4c
main 0x00000001044e00c4
start 0x000000018fb03f28

Expected behavior:
Reproduction should not cause the compiler to consume so much stack memory and thus trigger stack overflows on default stack sizes. Some state structures should probably be heap allocated.
Steps to reproduce:
Build this code in plain Scarb project (scarb new and paste this into src/lib.cairo)
https://gist.github.com/mkaput/9c39a620169de47c8365c67abfa79409
Related code:
https://github.com/starkware-libs/cairo/blob/f942db526e1d273fc10b6a8e261db2016380e776/crates/cairo-lang-lowering/src/destructs.rs#L235-L377
https://github.com/starkware-libs/cairo/blob/49637d619bbfdd339df29dae282e3a9f77014ebe/crates/cairo-lang-lowering/src/borrow_check/analysis.rs#L65-L84
https://github.com/starkware-libs/cairo/blob/f942db526e1d273fc10b6a8e261db2016380e776/crates/cairo-lang-lowering/src/destructs.rs#L135-L201

This is still happening as of 79b34bf 😭
cairo_lang_lowering::borrow_check::analysis::BackAnalysis<TAnalyzer>::get_block_info 0x0000000102cc7800
cairo_lang_lowering::borrow_check::analysis::BackAnalysis<TAnalyzer>::get_block_info 0x0000000102cc7800
cairo_lang_lowering::borrow_check::analysis::BackAnalysis<TAnalyzer>::get_block_info 0x0000000102cc7800
<cairo_lang_lowering::db::ConcreteFunctionWithBodyPostpanicLoweredQuery as salsa::plumbing::QueryFunction>::execute 0x0000000102cf878c
salsa::derived::slot::Slot<Q,MP>::read_upgrade 0x0000000102c89edc
<DB as cairo_lang_lowering::db::LoweringGroup>::concrete_function_with_body_postpanic_lowered::__shim 0x0000000102cd89dc
<cairo_lang_lowering::db::ConcreteFunctionWithBodyLoweredQuery as salsa::plumbing::QueryFunction>::execute 0x0000000102cf978c
salsa::derived::slot::Slot<Q,MP>::read_upgrade 0x0000000102c838f4
<DB as cairo_lang_lowering::db::LoweringGroup>::concrete_function_with_body_lowered::__shim 0x0000000102cd9b60
salsa::derived::slot::Slot<Q,MP>::read_upgrade 0x000000010318d824
<DB as cairo_lang_sierra_generator::db::SierraGenGroup>::priv_function_with_body_sierra_data::__shim 0x00000001031d6adc
salsa::derived::slot::Slot<Q,MP>::read_upgrade 0x0000000103185074
<DB as cairo_lang_sierra_generator::db::SierraGenGroup>::function_with_body_sierra::__shim 0x00000001031d7c60
cairo_lang_sierra_generator::program_generator::get_sierra_program_for_functions 0x00000001031952e8
salsa::derived::slot::Slot<Q,MP>::read_upgrade 0x0000000103189598
<DB as cairo_lang_sierra_generator::db::SierraGenGroup>::get_sierra_program_for_functions::__shim 0x00000001031da348
salsa::derived::slot::Slot<Q,MP>::read_upgrade 0x0000000103187240
<DB as cairo_lang_sierra_generator::db::SierraGenGroup>::get_sierra_program::__shim 0x00000001031db778
<scarb::compiler::compilers::lib::LibCompiler as scarb::compiler::Compiler>::compile 0x000000010357c104
scarb::ops::compile::compile 0x000000010363f8b4
scarb::commands::build::run 0x00000001036c2a60
scarb::main 0x0000000102afda60
std::sys_common::backtrace::__rust_begin_short_backtrace 0x00000001036c21a4
main 0x0000000102afebb8
start 0x00000001a6763f28

on next full release it won't.
this release was not over latest.


Attaching values to component context

I was trying to keep my unsubscribe handlers on the context object (like on the example: https://github.com/dekujs/deku/blob/master/docs/examples/counter/index.js#L23-L25), but i see the context object changes on each update: https://github.com/dekujs/deku/blob/master/lib/render.js#L987-L991 . How do you keep track of these from one render to another?

You could either store them in state, or you could keep a mapping in the module at the top level
handlers[component.id] = unsubscribe
Since it is state, I'd just keep it there personally.

Thanks, i forgot the id was there as well. However, i wouldnt consider handlers as part of state. I ended up attaching them to the dom element in afterRender for now.

Yeah, depends on how you define state really. I'd say because it's a type of state related to the component it belongs there even though it's not part of the render. But either way, it works :)
It's probably worth adding this sort of thing to the docs too.


Treat default gate families with tags_to_ignore or tags_to_accept as custom gate families in Gatesets

Fixes https://github.com/quantumlib/Cirq/issues/5543

@verult @pavoljuhas I've addressed all comments, this is ready for a re-review.


Add support for XQuery

Fixes #1888
Changes proposed:

[X] Add
[ ] Delete
[ ] Fix
[ ] Prepare

Note: I'm using temporary the xml icon for this one.

That said. We have to add a test to avoid duplicate declarations.

I prefer to use a different icon for xquery than the xml one.


Error fetching migration: context deadline exceeded

👉 Please describe what you were doing when this error happened.
Specifications

OS: win32
IPFS Desktop Version: 0.20.2
Electron Version: 17.1.0
Chrome Version: 98.0.4758.102

Error
Error: Initializing daemon...
go-ipfs version: 0.12.0
Repo version: 12
System version: amd64/windows
Golang version: go1.16.12
Found outdated fs-repo, migrations need to be run.
Looking for suitable migration binaries.
Need 1 migrations, downloading.
Downloading migration: fs-repo-11-to-12...
Fetching with HTTP: "https://ipfs.io/ipfs/QmdaCHYBDHEhXCMoynH5UcohEay6m1XayZCcxWZzKAHNVN/fs-repo-11-to-12/versions"
Fetching with HTTP: "https://ipfs.io/ipfs/QmdaCHYBDHEhXCMoynH5UcohEay6m1XayZCcxWZzKAHNVN/fs-repo-11-to-12/versions"
Fetching with HTTP: "https://ipfs.io/ipfs/QmdaCHYBDHEhXCMoynH5UcohEay6m1XayZCcxWZzKAHNVN/fs-repo-11-to-12/versions"
Error fetching: exceeded number of retries. last error was http.DefaultClient.Do error: Get "https://ipfs.io/ipfs/QmdaCHYBDHEhXCMoynH5UcohEay6m1XayZCcxWZzKAHNVN/fs-repo-11-to-12/versions": dial tcp <IP_ADDRESS>:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
Fetching with IPFS: "fs-repo-11-to-12/versions"
Error fetching: context deadline exceeded
could not get latest version of migration fs-repo-11-to-12: 2 errors occurred:
	* exceeded number of%2

@Garrick-hr does the problem go away when you quit and try to run it again?
Are you running any antivirus on MS Windows?

@Garrick-hr does the problem go away when you quit and try to run it again? Are you running any antivirus on MS Windows?

Same questions @OwenLittleWhite

I'm closing this as we improved error handling around migrations that recover via IPFS download, try 0.20.5 and open a new issue if you experience this again.

Continued in https://github.com/ipfs/go-ipfs/issues/8911

Duplicate of #2023


fix: file picker widgets removing files causing abnormal content

Description

fix filepicker widgets selects multiple files and then removes one of them, causing the final content of all file.data to be abnormal

PR fixes following issue(s)
Fixes # (issue number)

31411

Type of change

Bug fix

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.

Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
New and existing unit tests pass locally with my changes

Summary by CodeRabbit

New Features

Enhanced the File Picker widget to support more interactive functionalities like setting maximum file limits and custom data formats.

Tests

Added tests for new functionalities in the File Picker widget, including file uploading, setting restrictions, and file removal verification.

Bug Fixes

Fixed an issue with file data retrieval in the File Picker widget to ensure accurate data is presented after files are removed.

/build-deploy-preview skip-tests=true

/ok-to-test<EMAIL_ADDRESS>

@gzlinzihong Can you please pull latest release branch and merge it into this branch?

Hi @gzlinzihong Thank you so much for creating separate PRs, we can close this one now as all checks have passed 🚀


Add jsonifier as argument to app / api

This PR adds a jsonifier argument to the app and api to align it with other customization options. We also no longer pass it via the operation object, which brings us closer to operations as data class only.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

15 of 15 (100.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 92.388%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
3277

Relevant Lines:
3547

💛  - Coveralls


All DNS mapped to Azure API management DNS "azure-api.net" is showing as Dangling

Please check for Azure API management DNS "azure-api.net" in the script "Get-DanglingDnsRecordsPsCore.ps1"
Even tho Custom DNS from the domain's DNS zone is mapped to a DNS CNAME record of an Azure API Management service i.e azure-api.net it is showing as dangling.

Thanks for reporting this issue, this bug is fixed in PR #12


feat(@angular-devkit/architect): expose builder schema

Note: to get the schema json you can do:
const target = architect.getTarget(targetOptions);
architect.getBuilderDescription(target).pipe(
  concatMap(description => architect.getSchema(builderDescription.schema))
);

Superseded by https://github.com/angular/devkit/pull/497.


error when importing jax

I have jax and jaxlib with cuda installed on my computer running zorin os (Ubuntu 18), and I have had jax working for over a year and all of a sudden after doing some sudo updates, it no longer will work. I have cuda 11.5 installed, and have installed the GPU version according to the jax github instructions.
install method
(base) cvanwieren@ConnorPC:~$ pip install --upgrade "jax[cuda]" -f https://storage.googleapis.com/jax-releases/jax_releases.html
Looking in links: https://storage.googleapis.com/jax-releases/jax_releases.html
Collecting jax[cuda]
  Using cached jax-0.2.24-py3-none-any.whl
Requirement already satisfied: opt-einsum in ./anaconda3/lib/python3.8/site-packages (from jax[cuda]) (3.3.0)
Requirement already satisfied: typing-extensions in ./anaconda3/lib/python3.8/site-packages (from jax[cuda]) (<IP_ADDRESS>)
Requirement already satisfied: numpy>=1.18 in ./anaconda3/lib/python3.8/site-packages (from jax[cuda]) (1.20.3)
Requirement already satisfied: scipy>=1.2.1 in ./anaconda3/lib/python3.8/site-packages (from jax[cuda]) (1.7.1)
Requirement already satisfied: absl-py in ./anaconda3/lib/python3.8/site-packages (from jax[cuda]) (0.12.0)
Collecting jaxlib==0.1.73+cuda11.cudnn82
  Using cached https://storage.googleapis.com/jax-releases/cuda11/jaxlib-0.1.73%2Bcuda11.cudnn82-cp38-none-manylinux2010_x86_64.whl (138.6 MB)
Requirement already satisfied: flatbuffers<3.0,>=1.12 in ./anaconda3/lib/python3.8/site-packages (from jaxlib==0.1.73+cuda11.cudnn82->jax[cuda]) (1.12)
Requirement already satisfied: six in ./anaconda3/lib/python3.8/site-packages (from absl-py->jax[cuda]) (1.16.0)
Installing collected packages: jaxlib, jax
Successfully installed jax-0.2.24 jaxlib-0.1.73+cuda11.cudnn82

results of nvcc -V
(base) cvanwieren@ConnorPC:~$ nvcc -V
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2021 NVIDIA Corporation
Built on Mon_Sep_13_19:13:29_PDT_2021
Cuda compilation tools, release 11.5, V11.5.50
Build cuda_11.5.r11.5/compiler.30411180_0

results of nvidia-smi
(base) cvanwieren@ConnorPC:~$ nvidia-smi
Tue Nov  9 13:43:39 2021
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 495.29.05    Driver Version: 495.29.05    CUDA Version: 11.5     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  NVIDIA GeForce ...  On   | 00000000:01:00.0  On |                  N/A |
|  0%   39C    P8    19W / 270W |    482MiB /  7979MiB |      2%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A      1284      G   /usr/lib/xorg/Xorg                 26MiB |
|    0   N/A  N/A      1402      G   /usr/bin/gnome-shell               95MiB |
|    0   N/A  N/A      1827      G   /usr/lib/xorg/Xorg                210MiB |
|    0   N/A  N/A      1985      G   /usr/bin/gnome-shell               28MiB |
|    0   N/A  N/A      2634      G   ...AAAAAAAAA= --shared-files       38MiB |
|    0   N/A  N/A      3412      G   ...AAAAAAAAA= --shared-files       78MiB |
+-----------------------------------------------------------------------------+

error
(base) cvanwieren@ConnorPC:~$ python
Python 3.8.12 | packaged by conda-forge | (default, Sep 29 2021, 19:52:28)
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import jax
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/jax/__init__.py", line 37, in <module>
    from . import config as _config_module
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/jax/config.py", line 18, in <module>
    from jax._src.config import config
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/jax/_src/config.py", line 27, in <module>
    from jax._src import lib
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/jax/_src/lib/__init__.py", line 74, in <module>
    from jaxlib import xla_client
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/jaxlib/xla_client.py", line 29, in <module>
    from absl import logging
ImportError: cannot import name 'logging' from 'absl' (unknown location)

not sure how to procede.

It looks like your absl installation is somehow corrupted. Try running:
$ pip uninstall absl-py
$ pip install -U absl-py

and then try again.

@jakevdp after those changes, this is the error:
(base) cvanwieren@ConnorPC:~$ python
Python 3.8.12 | packaged by conda-forge | (default, Sep 29 2021, 19:52:28)
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import jaxd
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'jaxd'
>>> import jax
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/jax/__init__.py", line 37, in <module>
    from . import config as _config_module
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/jax/config.py", line 18, in <module>
    from jax._src.config import config
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/jax/_src/config.py", line 27, in <module>
    from jax._src import lib
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/jax/_src/lib/__init__.py", line 76, in <module>
    from jaxlib import pocketfft
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/jaxlib/pocketfft.py", line 18, in <module>
    from . import pocketfft_flatbuffers_py_generated as pd
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/jaxlib/pocketfft_flatbuffers_py_generated.py", line 1, in <module>
    import flatbuffers
ModuleNotFoundError: No module named 'flatbuffers'

and after trying to install flatbuffers this error comes up
(base) cvanwieren@ConnorPC:~$ python
Python 3.8.12 | packaged by conda-forge | (default, Sep 29 2021, 19:52:28)
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import jax
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/jax/__init__.py", line 127, in <module>
    from . import nn as nn
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/jax/nn/__init__.py", line 21, in <module>
    from jax._src.nn.functions import (
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/jax/_src/nn/functions.py", line 28, in <module>
    from jax.scipy.special import expit
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/jax/scipy/__init__.py", line 18, in <module>
    from . import signal as signal
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/jax/scipy/signal.py", line 17, in <module>
    from jax._src.scipy.signal import (
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/jax/_src/scipy/signal.py", line 15, in <module>
    import scipy.signal as osp_signal
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/scipy/signal/__init__.py", line 294, in <module>
    from ._max_len_seq import max_len_seq
  File "/home/cvanwieren/anaconda3/lib/python3.8/site-packages/scipy/signal/_max_len_seq.py", line 8, in <module>
    from ._max_len_seq_inner import _max_len_seq_inner
ImportError: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by /home/cvanwieren/anaconda3/lib/python3.8/site-packages/scipy/signal/_max_len_seq_inner.cpython-38-x86_64-linux-gnu.so)

It seems like your conda environment is hopelessly corrupted – this is unrelated to JAX (I suspect import scipy would give you the same error). You could ask for help in conda support channels, but my suggestion would be to start over in a clean environment:
$ conda create -n jax-env python=3.9
$ conda activate jax-env
$ pip install --upgrade "jax[cuda]" -f https://storage.googleapis.com/jax-releases/jax_releases.html


TODO: Info timeline

create info section of the frontpage
@WTFPUn helping this one (can some1 add him to this org?)

closed #4 to combine with this issue


Added: Change User to Service / Service to User

clarified on capabilities of the<EMAIL_ADDRESS>dept.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@CarolynRowe PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


添加innoreader

目前，inoreader连接不上

inoreader might be blocked by a well-known service, set a proxy and try it again.


type definitions from an editor

Although this seems to be a common problem when extending expect in jest, the editor can't find the type definition. (the test itself works since setupFilesAfterEnv is specified)
Explicitly import "expect-playwright" in the file works well, but do you know the other way?
To reproduce:
git clone -b repro-expect-playwright https://github.com/banyan/issue-repro.git
cd issue-repro
yarn
code .qawolf/myTest.test.ts # using vscode

Hey, there are types :)
You can use them at the top of your file e.g. via
/// <reference types="jest-playwright-preset" />
/// <reference types="expect-playwright" />

or at your central tsconfig.json either via files:
{
  "files": [
    "./global.d.ts",
    "node_modules/jest-playwright-preset/types/global.d.ts",
    "node_modules/expect-playwright/global.d.ts"
  ]
}

or via types:
{
  "compilerOptions": {
    "types": ["jest-playwright-preset", "expect-playwright"]
  }
}

not sure what the most elegant way is, probably types.

Thanks! The topmost reference works well, but other ways of going through files or types in tsconfig.json did not on my end.


Call the 'predictor.predictions().predictImage().withProjectId(UUID.fromString("..."))' found request error

I implement on the Android system application using Kotlin
I only want to call Predict from the byte array data only.
So, I don't need to create trainer object, and I have project/prediction keys thing.
Can I use .withProjectId(UUID.fromString("my_project_uuid_string") to call the service?
And the result of what I did with the question that I asked you, is got an error "Resource not found".
What is the thing I need to setting more? Resource ID? Application ID? Iteration ID?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d88c9656-681e-7f72-3ac7-8a1720356353
Version Independent ID: f2b8fd62-cfa7-b8a7-f257-f83bea5fc7a2
Content: Quickstart: Create an object detection project with the Custom Vision SDK for Java - Azure Cognitive Services
Content Source: articles/cognitive-services/Custom-Vision-Service/java-tutorial-od.md
Service: cognitive-services
Sub-service: custom-vision
GitHub Login: @areddish
Microsoft Alias: areddish

@xenogew Thanks for the question. We are investigating the issue and will update you shortly.

@xenogew Can you please share the sample that you are trying, please follow the below documents for using the predictions().
https://docs.microsoft.com/en-us/java/api/com.microsoft.azure.cognitiveservices.vision.customvision.prediction.predictions.detectimage?view=azure-java-stable#com_microsoft_azure_cognitiveservices_vision_customvision_prediction_Predictions_detectImage__
https://docs.microsoft.com/en-us/azure/cognitive-services/custom-vision-service/java-tutorial-od#use-the-prediction-endpoint

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Fix/handle wrong network

This PR tried to handle unsupported networks better.
If a user visit staking with an unsupported network in metamask we will ask them to swtich the ethereum mainnet.
We need this even before they are connected since we instanciate onboard before we connect.
If they are connected and switch to an unsupported network same thing.
I also added correct types for window.ethereum by installing @metamask/providers and removing @metamask/detect-provider since it was diluting the global ethereum with an incorrect type. I added this package in our utils folder
I'm still using the commit hash version from synthetix monorepo. If we get this https://github.com/Synthetixio/js-monorepo/pull/118 merged today I think we should do a patch release. And then I will upgrade the version here.

Yep cool I'll make sure to test

Metamask
Coinbase
Trezor
ledger
On both l1 and l2.. Do you think that will cover it?

I think it's all working. Basically all the same issues as mentioned here https://github.com/Synthetixio/staking/pull/781#issuecomment-964676916
Overall it's less error and correctly swiches network for you


Refactor transifex.api's exceptions for down/uploads

Previously, for uploads and downloads we could get a "successful" response that includes an error report for a download or upload. This means that as far as {json:api} semantics go, no error has happened. However, we intercepted this response and raised it as if it was a {json:api} exception.
This raising was buggy because it didn't use the JsonApiException.new invocation (and thus can't be captured with JsonApiException.get) and also it didn't have the third required argument which was the response.
Instead of fixing the aforementioned bugs however, we decided to implement new exception classes in transifex.api (which is the SDK itself, as opposed to transifex.api.jsonapi which is the "SDK library"). This makes it clearer to the user that as far as the {json:api} semantics are concerned, no error has occured. The problem is that the download or upload "job"'s status (which was successfully retrieved) is reporting an error.
The new exception classes give priority to their first argument which is the 'detail' field of the first error included in the response. The rest of the errors, if any, will be accessible from the exception's second argument. Keep in mind that at the time of writing, Transifex APIv3 will only include one error in the case of an unsuccessful upload or download.

Codecov Report

Merging #99 (a8a9b01) into devel (5fd1f97) will decrease coverage by 0.22%.
The diff coverage is 66.66%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##            devel      #99      +/-   ##
==========================================
- Coverage   77.99%   77.78%   -0.22%
==========================================
  Files          46       47       +1
  Lines        3827     3840      +13
==========================================
+ Hits         2985     2987       +2
- Misses        842      853      +11

Impacted Files
Coverage Δ

transifex/api/__init__.py
84.44% <33.33%> (+0.92%)
:arrow_up:

transifex/api/exceptions.py
73.33% <73.33%> (ø)

transifex/_version.py
41.93% <0.00%> (-3.23%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Moving lines down should not affect indentation

Have the following code
if (model) {
				model.sendRequest(messages, options, token)
				const messages = [
					vscode.LanguageModelChatMessage.User(`Not sure how the message is being used `),
					vscode.LanguageModelChatMessage.User(request.prompt)
				];

				const chatResponse = await model.sendRequest(messages, {}, token);
				for await (const fragment of chatResponse.text) {
					// Process the output from the language model
					// Replace all python function definitions with cat sounds to make the user stop looking at the code and start playing with the cat
					const catFragment = fragment.replaceAll('def', 'meow');
					stream.markdown(catFragment);
				}
			}

Move line mode.send request down via ctrl+down-arrow
Notice how the lines that have been passed change. Their indentation gets modified. The move line down command should not mutate lines it passes.
https://github.com/microsoft/vscode/assets/1926584/76af7e66-6422-4161-8841-c79838fd6f1e

See https://github.com/microsoft/vscode/issues/214569 and https://github.com/microsoft/vscode/issues/214562 for similar/duplicates.

should be fixed by https://github.com/microsoft/vscode/pull/214577

Thanks for the fix!