[$500] Web - Assignee email or name is missing for other users

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to chat with userB
Click on + icon and select assign task option
Enter title and create task
Go to task thread
Click on Assignee and select Assignee with whom userB didn't have chat history
From userB, check the Assignee in task thread

Expected Result:
Assignee email or name should show
Actual Result:
Assignee email or name is missing
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/a06e0091-1266-413b-9947-232dacc754f5
https://github.com/Expensify/App/assets/93399543/89654fbc-03e1-415f-a5d7-73435fecba6a
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693807403315129
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018f80383d65e746df
Upwork Job ID:<PHONE_NUMBER>589401088
Last Price Increase: 2023-09-18

Stop emitting the 'assign event' when a user is assigned, and emit it only when a message is sent.

Contributor details
Your Expensify account email:
<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01d68a22e5d906bca6

We're waiting for proposals.

@kadiealexander  I'm going OoO for a week so assigning this to you so that you can move it forward in the meantime. I'll take it back from you once I'm online again. Thanks!

Problem Statement
The current implementation of the setAssigneeValue function in our codebase generates random IDs and uses a fake owner email and owner account when creating an optimistic chat report. This approach can lead to inconsistencies and potential issues in our application, as the generated IDs and owner details do not correspond to actual user data.
Proposed Solution
We propose to modify the setAssigneeValue function to use the proper user email instead of a fake one. This will involve the following steps:
Retrieving User Data: When the setAssigneeValue function is called, we will retrieve the actual user data from our database or authentication service or calling event. This data should include the user’s email and account ID.
Modifying Chat Report Generation: In the buildOptimisticChatReport function, we will replace the randomly generated IDs and fake owner email with the actual user data retrieved in step 1. This will ensure that the chat report is linked to an actual user account.
Updating Share Destination: If a share destination isn’t already set in this step, we will set the shareDestination as that chat report.
Benefits
Implementing this solution will provide several benefits:
Data Consistency: By using actual user data instead of randomly generated IDs and fake details, we can ensure consistency across our application.

@ArekChr any thoughts on the proposal above?

@kadiealexander I couldn't reproduce this error, the display name is always visible in assignee of task

I also can no longer reproduce this error. @gadhiyamanan could you please confirm if you can still reproduce it?

it is still reproduciable
you need to select Assignee with whom userB didn't have chat history
https://github.com/Expensify/App/assets/54790231/9f4ee883-9bdd-4e91-8210-fa0d234db7eb

My userB was a brand new account with no conversation history with the assignee:

Tried again with a gmail account as User B, all accounts are on different domains:

@kmostafa599 What is the root cause of the issue? Please follow the proposal template

The current implementation of the setAssigneeValue function in our codebase generates random IDs and uses a fake owner email and owner account when creating an optimistic chat report. This approach can lead to inconsistencies and potential issues in our application, as the generated IDs and owner details do not correspond to actual user data.
The root cause of this problem is the use of randomly generated IDs and fake owner details when creating an optimistic chat report. This can lead to inconsistencies as these details do not match with actual user data.
modify the setAssigneeValue function to use the proper user email instead of a fake one. This will involve the following steps:
Retrieving User Data: When the setAssigneeValue function is called, we will retrieve the actual user data from our database or authentication service. This data should include the user’s email and account ID.
Modifying Chat Report Generation: In the buildOptimisticChatReport function, will replace the randomly generated IDs and fake owner email with the actual user data retrieved in step 1. This will ensure that the chat report is linked to an actual user account.
Updating Share Destination: If a share destination isn’t already set in this step, will set the shareDestination as that chat report.

@ArekChr any further thoughts?

Issue not reproducible during KI retests. (First week)

@gadhiyamanan can you still reproduce this? I've never been able to.

still able to reproduce
https://github.com/Expensify/App/assets/54790231/4ec9131e-4737-474d-b245-fb19cc0618b6

@gadhiyamanan the video doesn't match the steps in the OP, could you please rewrite new reproduction steps?

I am doing the same thing, which step am i missing ?

I'm not sure, I just can't reproduce. When I try, I can't assign the task to a third user.
https://github.com/Expensify/App/assets/59587260/371e8110-7d65-4b41-be31-89756cc42df7

try this

from userA, create a chat with userB and userC (receiver also need to send message otherwise it will not reflect in Assignee list )
from userA, Click on + icon and select assign task option
Enter title and select userB as share somewhere
create task
from userB, Go to task thread
from userA, Go to task thread and Assign task to userC

https://github.com/Expensify/App/assets/54790231/e2524d43-5b87-4969-9cf4-6b6ad19effc1

I tried reproducing this and also couldn't reproduce it. @kadiealexander @ArekChr have you been able to reproduce this with  @gadhiyamanan last steps?

Same here, couldn't reproduce this issue, when reassigning tasks to someone else I see the correct avatar and display name

Ok since no one seems to be able to reproduce this I'll close this for now.


Fix. Try load bit library before bit32

This is necessary because if you have Lua 5.1 and LuaJIT and you have
bit32 library LuaJIT can find this library and will use it instead of
builtin one.

due to changes i made a new PR #72


Add PURL support to record generation

See the PURL spec and the CPAN-specific PURL spec:

https://github.com/package-url/purl-spec
https://github.com/package-url/purl-spec/blob/master/PURL-TYPES.rst#cpan

The algorithm for generation matches that used in URI::PackageURL.
This change is necessary but not necessarily sufficient to use this security database as a source to the Open Source Vulnerabilities aggregator, as described in the OSV announcement.
I've marked this as a draft because I'm interested to discuss the goal I've laid out here, and am happy to revise the implementation, if desired.

I don't mind adding other fields, and a purl field will be fine. However, after reading the purl stuff it seems it doesn't quite fit.

The namespace of a particular Perl distribution is not fixed, so there are a lot of questions about what to put there. It can be empty though.
The version is problematic since each report here is a collection of reports across the entire lifetime of the package. But the version doesn't have to appear.
If both of those are blank, there is nothing to do since the purl is a composite field. You know it's cpan (mostly) and you know the distribution name. An additional field the combines those two in a string adds no value. Something else can use the existing reports to do other things.
Since all the necessary information is already in the report, I don't see what's necessary about this change. Anything that wants to generate this information can already do that.
I don't see how Google would use the reports in this project directly. We'd have to convert them to their OSV format. As such, there's no need to add additional information in the reports. Instead, we'd repackage what we already have into new output formats.
I'm already including the GitHub ID for these issues, but that's not something I could generate from the existing data.

But, I'm also wary of any Google project, especially when we already have ways to get this information for other sources that are already doing this work. In two years when Google gets tired of this, we're back to what we've been using for decades.
I think the path forward is a program that converts the data here into the format that Google needs. That doesn't require a change to the CPANSA.pm module.

Since there was been no response to this, I'm closing this PR simply to keep the queue clean.


Update Base64 as a non-throwing API

Follow-up PR: https://github.com/facebookincubator/velox/pull/10371
The following changes are done in this PR.

Variable names are updated for better readability.
Function declarations in Base64.h for better maintainability.
Refactor the APIs in Base64 as non-throwing APIs.

Changing the char to std::string_view and std::string will be done in subsequent PR.

@majetideepak Can you please review the changes?

Thanks @Joe-Abraham , based on brief glance, it seems its mostly renaming variables etc for readability and consistency (which is welcome change); Want to make sure I am not missing any material change.

@kgpai I have also made the APIs used in BinaryFunctions.h as non-throwing.

Refactor the APIs in Base64 as non-throwing APIs.

@Joe-Abraham this should be its own PR since its a functional change. We can leave the remaining code improvements this PR.
Can you please open another PR with only the non-throwing API changes? Thanks.


Create a REST API with Attribute Routing in ASP.NET Web API 2: typos

The page "Create a REST API with Attribute Routing in ASP.NET Web API 2" has some typos: some texts that doesn't correspond to the screenshot and 2 samples that doesn't work.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: benichka sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@benichka Thank you for making these updates!

@scottaddie you are welcome :). It is a pleasure to be able to contribute!


java.lang.NullPointerException: Attempt to read from field 'int net.xpece.android.support.preference.ListPreference.E'

Just got this crash reported, seems to be a new one, only seen with 2.2.0. Can you please take a look at it?
Asus device, SDK 21
Caused by java.lang.NullPointerException: Attempt to read from field 'int net.xpece.android.support.preference.ListPreference.E' on a null object reference
       at net.xpece.android.support.preference.XpListPreferenceDialogFragment.net.xpece.android.support.preference.ListPreference.isSimple(XpListPreferenceDialogFragment.java:1653)
       at android.support.v7.preference.PreferenceDialogFragmentCompat.onCreateDialog(PreferenceDialogFragmentCompat.java:154)
       at android.support.v4.app.DialogFragment.onGetLayoutInflater(DialogFragment.java:328)
       at android.support.v4.app.Fragment.performGetLayoutInflater(Fragment.java:1226)
       at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1428)
       at android.support.v4.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManager.java:1759)
       at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1827)
       at android.support.v4.app.FragmentManagerImpl.dispatchStateChange(FragmentManager.java:3244)
       at android.support.v4.app.FragmentManagerImpl.dispatchActivityCreated(FragmentManager.java:3200)
       at android.support.v4.app.FragmentActivity.android.support.v4.app.FragmentController.dispatchActivityCreated(FragmentActivity.java:11195)
       at android.support.v7.app.AppCompatActivity.onStart(AppCompatActivity.java:177)
       at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1236)
       at android.app.Activity.performStart(Activity.java:6048)
       at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2306)
       at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2405)
       at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:3967)
       at android.app.ActivityThread.access$900(ActivityThread.java:154)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1312)
       at android.os.Handler.dispatchMessage(Handler.java:102)
       at android.os.Looper.loop(Looper.java:135)
       at android.app.ActivityThread.main(ActivityThread.java:5290)
       at java.lang.reflect.Method.invoke(Method.java)
       at java.lang.reflect.Method.invoke(Method.java:372)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:911)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:706)

Thanks for the report, here's what I think happens:
The dialog expects the preference hierarchy to be already loaded at the time the dialog is created.
What I think is happening:

You have a set of preferences..
You click a ListPreference and its dialog shows.
a) You remove the ListPreference and rotate phone OR
b) You rotate phone and don't add the ListPreference whose dialog is showing.
The dialog crashes because it can't find its ListPreference in preference tree.

You need to make your preference hierarchy exactly the same as it was before orientation change in onCreatePreferences.* Use saved state for that.
* As you can see in the stack trace the error occurs in Activity.onStart / Fragment.onActivityCreated. It's necessary your preference tree has stabilized before that.
Since this doesn't happen in the sample app, I'll close this issue.  Unfortunately this is not something I can guard against. If the preference is not there then the dialog has nowhere to get it from.

Your explanation is on point and helped to identify the root cause. Thanks.


Useless private access modifier incorrectly detected

Given this code:
class FoosController < ApplicationController
  private

  helper_method \
  def my_helper
    'help me!'
  end
end

Robocop warns that the private is useless. But #my_helper is indeed private.

Just pushed a fix to my open PR.


Moving MacVlan driver out of experimental

Signed-off-by: Madhu Venugopal<EMAIL_ADDRESS>

ping @nerdalert @mrjana @aboch

LGTM

LGTM


gitlist unable to retrive path to repo files

Hi
I  installed gitlist using XAMPP on windows7
following is my config.in
; WINDOWS USERS
client = '"C:\Program Files (x86)\Git\bin\git.exe"' ; Your git executable path
repositories[] = 'D:/gitrep/' ; Path to your repositories

following is my error log
in D:\xampp\htdocs\gitlist\vendor\klaussilveira\gitter\lib\Gitter\Client.php line 86
at Client->getVersion() in D:\xampp\htdocs\gitlist\vendor\klaussilveira\gitter\lib\Gitter\Client.php line 65
at Client->run(object(Repository), 'branch') in D:\xampp\htdocs\gitlist\vendor\klaussilveira\gitter\lib\Gitter\Repository.php line 164
at Repository->getBranches() in D:\xampp\htdocs\gitlist\vendor\klaussilveira\gitter\lib\Gitter\Repository.php line 211
at Repository->hasBranch('master') in D:\xampp\htdocs\gitlist\vendor\klaussilveira\gitter\lib\Gitter\Repository.php line 439
at Repository->getHead('master') in D:\xampp\htdocs\gitlist\src\GitList\Git\Repository.php line 34
at Repository->getHead() in D:\xampp\htdocs\gitlist\src\GitList\Controller\TreeController.php line 19
at TreeController->GitList\Controller\{closure}('jenkins2') in D:\xampp\htdocs\gitlist\src\GitList\Controller\TreeController.php line 112
at TreeController->GitList\Controller\{closure}('jenkins2')
at call_user_func_array(object(Closure), array('jenkins2')) in D:\xampp\htdocs\gitlist\vendor\symfony\http-kernel\Symfony\Component\HttpKernel\HttpKernel.php line 126
at HttpKernel->handleRaw(object(Request), '1') in D:\xampp\htdocs\gitlist\vendor\symfony\http-kernel\Symfony\Component\HttpKernel\HttpKernel.php line 66
at HttpKernel->handle(object(Request), '1', true) in D:\xampp\htdocs\gitlist\vendor\silex\silex\src\Silex\Application.php line 538
at Application->handle(object(Request)) in D:\xampp\htdocs\gitlist\vendor\silex\silex\src\Silex\Application.php line 515
at Application->run() in D:\xampp\htdocs\gitlist\index.php line 29

please help me in this regard

Hi @srinivaspmm! As fas as I can tell, there's a missing line in the error log, as it tells us where the error occurred, but not what happened.

Hi alehaa
thank you for your response but i pasted entire log 14.lines
may be following line
RuntimeException: The system cannot find the path specified.
in D:\xampp\htdocs\gitlist\vendor\klaussilveira\gitter\lib\Gitter\Client.php line 86
at Client->getVersion() in D:\xampp\htdocs\gitlist\vendor\klaussilveira\gitter\lib\Gitter\Client.php line 65
at Client->run(object(Repository), 'branch') in D:\xampp\htdocs\gitlist\vendor\klaussilveira\gitter\lib\Gitter\Repository.php line 164
at Repository->getBranches() in D:\xampp\htdocs\gitlist\vendor\klaussilveira\gitter\lib\Gitter\Repository.php line 211
at Repository->hasBranch('master') in D:\xampp\htdocs\gitlist\vendor\klaussilveira\gitter\lib\Gitter\Repository.php line 439
at Repository->getHead('master') in D:\xampp\htdocs\gitlist\src\GitList\Git\Repository.php line 34
at Repository->getHead() in D:\xampp\htdocs\gitlist\src\GitList\Controller\TreeController.php line 19
at TreeController->GitList\Controller{closure}('jenkins2') in D:\xampp\htdocs\gitlist\src\GitList\Controller\TreeController.php line 112
at TreeController->GitList\Controller{closure}('jenkins2')
at call_user_func_array(object(Closure), array('jenkins2')) in D:\xampp\htdocs\gitlist\vendor\symfony\http-kernel\Symfony\Component\HttpKernel\HttpKernel.php line 126
at HttpKernel->handleRaw(object(Request), '1') in D:\xampp\htdocs\gitlist\vendor\symfony\http-kernel\Symfony\Component\HttpKernel\HttpKernel.php line 66
at HttpKernel->handle(object(Request), '1', true) in D:\xampp\htdocs\gitlist\vendor\silex\silex\src\Silex\Application.php line 538
at Application->handle(object(Request)) in D:\xampp\htdocs\gitlist\vendor\silex\silex\src\Silex\Application.php line 515
at Application->run() in D:\xampp\htdocs\gitlist\index.php line 29

my gitlist is under  d:/xampp/htdcos/gitlist
my repository  directory  d:/gitrep under this folder i have a repository jenkins2
after starting  xamp i am able to get repo jenkisn2.
4 if i click on jenkins2 to i am getting path not found exception it is looking under http://localhost:/gitist/jenkins2

following is .htaccss
RewriteEngine On

#RewriteBase D:\xampp\htdocs\gitlist
RewriteBase /gitlist/

Okay, the exception tells us, that the git command can't be found. Is git.exe installed in the given path defined in your config?

client = '"C:\Program Files\Git\bin\git.exe"' ;
default_branch = 'master' ;
repositories[] = 'D:\gitrep' ; Path to your repositories

yes you are correct i  changed to proper location of git.exe file but still same error above one is new config.ini

Can you call the binary with --version argument from the console?

$ git --version
git version 2.9.0.windows.1

GitList version is 0.4.0

GitList version is 0.4.0

Tried upgrading to 0.6? 0.4 is 4 years old ... ;)

oh okay will  download 0.6 and try with it .

http://gitlist.org/ form this link i am able to see 0.5 stable if possible can you please provide link where i will get 0.6

https://github.com/klaussilveira/gitlist/releases/tag/0.6.0

thank you very much for your time and hlep now issue got fixed  i am able to see repo and files as well once again thank you very much


str_raw_ptr use is not /permissive- clean

The issue is that the str_raw_ptr is intended to be a overloadable, however the issue is that it's used before all definitions/declarations are available, which is not two-phase name lookup clean. E.g. the overloads for PCWSTR and unique_any_t appear towards the top of resource.h and is used pretty much right after with str_concat, etc., however the overload for HSTRING doesn't appear until later in the file and the overload for std::wstring appears in stl.h, defined after including resource.h. Thus, neither of these overloads should be considered during function overload resolution in functions like str_concat.
I tried to address this when porting the tests over, but ran into a number of build issues with the Windows build. The somewhat obvious thing to do is to define a function template that can be specialized, but this doesn't work cleanly if the type itself is a class template (since there's no partial specializations for function templates). Another option is class template specialization, which is what I tried, but the issue there is that there are dependencies on overload resolution behavior. E.g. it's assumed to work with both things that are convertible to PCWSTR and things that are convertible to std::wstring (e.g. std::filesystem::path). Unfortunately there are issues around trying to specialize types like path since there are inconsistencies in which filesystem header is available in the Windows build...
This mostly leaves trying to replicate overload resolution to some degree. This isn't exactly clean or easy. E.g. trying to conditionally specialize on things like is_convertible_v don't work by themselves since PCWSTR is convertible to std::wstring. One possible option may be to describe the restriction more explicitly (e.g. is_convertible_v<T, wstring> && !is_convertible_v<T, PCWSTR>), but that's a bit messy to use as anything other than a last resort. Another possible option I threw around might be to explicitly check for operator PCWSTR, etc. I'm a bit skeptical of that, however since I'm not sure it would work cleanly with cv/refs.

Looking back at it, it seems easy enough to avoid the array in str_concat_nothrow. We can just directly invoke str_raw_ptr and use sizeof..., which will cause the temporaries to stick around long enough to be destroyed after the str_build_nothrow call completes.


Rename the bfe_ prefix

Because the project name is BFE, and start with the bfe string, then the custom go modules are also named bfe_xxx, it is a redundant naming rule.

Thanks for your suggestion! The issue will be resolved in future version.


Develop

Coverage decreased (-0.02%) to 86.342% when pulling f4e0092451e76dfed77f382ce9922b08fc5cd039 on develop into 55a776de6e6d7217da04a885882df98ea0c591cd on bugfix/bridge.

Coverage decreased (-0.02%) to 86.342% when pulling f4e0092451e76dfed77f382ce9922b08fc5cd039 on develop into 55a776de6e6d7217da04a885882df98ea0c591cd on bugfix/bridge.


Child gameobjects with NetworkedObjects are not spawned during NetworkedObject parent spawning.

Describe the bug
When spawning prefab where childs have NetworkingObject component, the childs are not spawned. When childs are spawned in code they are not attached to parent from prefab. Instead they are spawned as root gameobjects even when "Always replicate as Root" is disabled on them.
To Reproduce

Create gameobject with NetworkingObject component
Create child gameobject with NetworkingObject component
Save root gameobject as prefab
Register prefab in NetworkingManager and Spawn prefab from code
The child gameobject is not created during prefab spawning and when child is spawned throught code it is created as root gameobject

Expected behavior
The prefab is spawned with all childs which are using NetworkingObject component
Environment:

OS: Windows 10
Unity Version: 2020.1.3f1
MLAPI Version: v12.1.2
MLAPI Commit: https://github.com/MidLevel/MLAPI/commit/293c3ccd8d48fb345797579c723b65f2df07bd4c

I think that it's unsupported and you shouldn't do that. "It's not a bug, it's a feature" sentence fits here. :)


[JAVA] Avoid superfluous string creation when logging level is disabled

There are a few places where strings were unnecessarily created for logging purpose. For the scenario I profiled, for MessageSerializer.deserialize(), roughly 2/3 of the total CPU was spent in string.format() (inside ArrowRecordBatch)

LGTM +1. Thanks for the improvements @zzhao0

@zzhao0 can you create a JIRA issue for this?

Sorry @wesm, I should have noticed that missing.

Will do. Thanks for the reminder


glibc missing dependency to gawk

missing dependency of util::gawk for glibc build
configure: error:
*** These critical programs are missing or too old: gawk
*** Check the INSTALL file for required versions.
++ bob_handle_error 1

for compat and non-compat glibc.
I fixed it like that:
diff --git a/recipes/libs/compat/glibc.yaml b/recipes/libs/compat/glibc.yaml
index 55c7fe8..49a2ba6 100644
--- a/recipes/libs/compat/glibc.yaml
+++ b/recipes/libs/compat/glibc.yaml
@@ -3,6 +3,9 @@ inherit: [make, patch]
 depends:
     - kernel::linux-libc-headers
     -
+        name: utils::gawk
+        use: [tools]
+    -
         name: devel::compat::gcc-cross-bare
         use: [tools]

@@ -20,7 +23,7 @@ checkoutScript: |
     patchApplySeries $<<glibc/*.diff>>

 buildVars: [AUTOCONF_TARGET]
-buildTools: [gcc-cross-bare, target-toolchain, bison]
+buildTools: [gcc-cross-bare, target-toolchain, bison, gawk]
 buildScript: |
     EXTRA=
     [ -e $1/usr/include/selinux/selinux.h ] || EXTRA+=" --without-selinux"
diff --git a/recipes/libs/glibc.yaml b/recipes/libs/glibc.yaml
index 674cb09..b1a0139 100644
--- a/recipes/libs/glibc.yaml
+++ b/recipes/libs/glibc.yaml
@@ -3,6 +3,9 @@ inherit: [make, patch]
 depends:
     - kernel::linux-libc-headers
     -
+        name: utils::gawk
+        use: [tools]
+    -
         name: devel::gcc-cross-bare
         use: [tools]

@@ -20,7 +23,7 @@ checkoutScript: |
     patchApplySeries $<<glibc/*.diff>>

 buildVars: [AUTOCONF_TARGET]
-buildTools: [gcc-cross-bare, target-toolchain, bison]
+buildTools: [gcc-cross-bare, target-toolchain, bison, gawk]
 buildScript: |
     EXTRA=
     [ -e $1/usr/include/selinux/selinux.h ] || EXTRA+=" --without-selinux"
diff --git a/recipes/utils/gawk.yaml b/recipes/utils/gawk.yaml
index 966cb51..6c79189 100644
--- a/recipes/utils/gawk.yaml
+++ b/recipes/utils/gawk.yaml
@@ -22,3 +22,5 @@ packageScript: |
     autotoolsPackageTgt

 provideDeps: [ "*-tgt" ]
+provideTools:
+    gawk: "usr/bin"

Did you have gawk installed on your host?

shouldn't that be independent to my host system?

Currently gawk is one of the tools that need to be installed on the host when building the project from scratch. It's not really documented and others like gcc, perl, make, sed, patch might be more obvious.
These tools are ubiquitous and mature so I saw no point yet in defining then in the recipes. On the other hand we should at least document what tools need to be installed on the host...

okay. https://bob-build-tool.readthedocs.io/en/latest/installation.html currently awk isn't listed.
on the other hand, what could be the problem to use the awk, we have a recipe for? so we are a bit more independent.

so this failed:
./config.status: line 1144: awk: command not found
config.status: error: could not create Makefile
++ bob_handle_error 1
++ set +x
Step failed with return status 1; Command: $1/configure ${AUTOCONF_BUILD:+--build=${AUTOCONF_BUILD}} ${AUTOCONF_HOST:+--host=${AUTOCONF_HOST}} ${AUTOCONF_TARGET:+--target=${AUTOCONF_TARGET}} --prefix="/usr" --sysconfdir="/etc" --localstatedir="/var" --libdir=/usr/lib ${SHARED_STATIC:+"${SHARED_STATIC[@]}"} "${@:2}"
Call stack (most recent call first)
    #0: Class  autotools, layer basement, line 50, in autotoolsBuild
    #1: Recipe utils::gawk, layer basement, line 1, in main
Build error: Build script ./dev/build/utils/gawk/x86_64-wendy-linux-gnu/1/build.sh returned with 1
Failed package: x86_64::linux/devel::sandbox/utils::gawk

We need gawk to build gawk. So to keep this simple, we should define gawk as a system requirement.


✨ Track which events bring the most users

Cc: @adamcogan
Pain
Adam wants to have a report so that he could see which event attracted the most users.
Event types:

Conferences / meetups
Video release
?

Suggested Solution

Tasks

[ ] ...
[ ] ...

Acceptance Criteria

[ ] Meets Definition of Done - https://github.com/SSWConsulting/SSW.Rewards.Mobile/blob/main/_docs/Definition-of-Done.md
[ ] ...

More Information

Screenshots

Thanks!

Related to #519


[Feature Request] medusa support

can you please provide any documentation how we can use medusa with tensorrtllm_backend
https://github.com/NVIDIA/TensorRT-LLM/tree/main/examples/medusa

Hi, does tensorrtllm-backend support medusa? Or is it still in works?


[BugFix][CherryPick] fix outer join and anti join rewrite bug for 3.1 (#28028)

Fixes #27163
The bug has the following causes:

The invalid use of equivalence in outer join and anti join, which leads to the invalid use of output columns. The join on predicate A.a = B.b for outer join and anti join can not be used to construct equivalence class.
the compatibility check should be more strict for outer and anti join, which should not consider the pushdown predicates derived from equivalence class. eg: the left outer join should make sure that the predicates of right child tree of query and mv should be equal. it means that the compensation predicates should not come from right child of left outer join.
when clone equivalence class, should use the same Set for the columns in the same ec.

fixed by

constructing eq without column equal predicates in outer and anti join
add more strict compatibility check for outer and anti join, excluding pushdown ec derived predicates
fix equivalence class clone bug.

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 151 / 161 (93.79%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/TableScanDesc.java
15
18
83.33%
[67, 85, 87]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/MaterializedViewRewriter.java
98
105
93.33%
[246, 316, 338, 341, 722, 723, 1846]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/ScalarOperator.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/base/EquivalenceClasses.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rewrite/JoinPredicatePushdown.java
6
6
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/MvUtils.java
18
18
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/mv/JoinDeriveContext.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/rule/BaseMaterializedViewRewriteRule.java
1
1
100.00%
[]


Rename project to dogsheep-photos

photos-to-sqlite doesn't really capture the full scope of this project anymore.

I just renamed the repository.

Need to reconfigure Circle CI.

Huh, it looks like Circle CI picked up the name change automatically. https://app.circleci.com/pipelines/github/dogsheep/dogsheep-photos

Next time I push a release it will create dogsheep-photos on PyPI.

Then I just need to push a final photos-to-sqlite release that updates the README to tell people about the name change.

I'm going to release 0.4 now.

https://pypi.org/project/photos-to-sqlite/ now links to dogsheep-photos.

https://pypi.org/project/dogsheep-photos/ is live.


NuGet addresses seem to be out of date

I am on the nuget.org team and we noticed that your document is mentioning "az320820.vo.msecnd.net". We no longer use this host name. It has been replaced by "globalcdn.nuget.org". I don't know if this document is meant to be an exhaustive list but this aforementioned one is certainly out of date. Other ones that come to mind are "api.nuget.org" and package search endpoints enumerated in this service discovery endpoint:
https://api.nuget.org/v3/index.json

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 946e7563-c5a9-14e8-323e-c557ebc9cfe0
Version Independent ID: 40cb0a2d-bfa1-8b7d-64f5-076c6067750c
Content: Xamarin Firewall Configuration Instructions - Xamarin
Content Source: docs/get-started/installation/firewall.md
Product: xamarin
Technology: xamarin-crossplatform
GitHub Login: @asb3993
Microsoft Alias: amburns

Thanks for pointing this out @joelverhagen . I've made an update to the doc.


WPF entrypoint calls undefined InitializeComponent method

From the referenced example for hosted UWP custom controls, it is said to override the default XAML entrypoint with this one:
public class Program
{
    [System.STAThreadAttribute()]
    public static void Main()
    {
        using (new MyUWPApp.App())
        {
            MyWPFApp.App app = new MyWPFApp.App();
            app.InitializeComponent();   // <- there is no InitializeComponent() for System.Windows.Application
            app.Run();
        }
    }
}

Maybe it was intended to call the method on the UWP XamlApplication instanciated in the using statement like this:
public class Program
{
    [System.STAThreadAttribute()]
    public static void Main()
    {
        using (var xamlApp = new MyUWPApp.App())
        {
            MyWPFApp.App wpfApp = new MyWPFApp.App();
            xamlApp.InitializeComponent();   // <-calls Microsoft.Toolkit.Win32.UI.XamlHost.XamlApplication.InitializeComponent()
            wpfApp.Run();
        }
    }
}

The same issue exists in the other hosted UWP standard controls as well.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dc7ec471-9257-39ba-173b-eb7973f4c360
Version Independent ID: 3e07d5f0-8b19-2ef4-dc2a-48659f42c12e
Content: Host a custom UWP control in a WPF app using XAML Islands
Content Source: hub/apps/desktop/modernize/host-custom-control-with-xaml-islands.md
Product: uwp
Technology: apps
GitHub Login: @mcleanbyron
Microsoft Alias: mcleans

Relates to #2506

Ok, I see InitializeComponent is defined in MyWPFApp.App class as an auto-generated method when App.xaml (the WPF one) contains StartupUri="" attribute. The auto-generated Main is also automatically adapted, it contains no calls to InitializeComponent when StartupUri is missing and so that method.

Thanks for your feedback. It sounds like you figured it out - yes, the code is correct, and it is supposed to call the generated InitializeComponent and Run methods of the default MyWPFApp.App class.


can't work an js-controler 1.2.7

From @dfrozen on March 10, 2018 21:5
host.orangepiplus	2018-03-11 00:05:05.803	error	instance system.adapter.find-my-iphone.0 terminated with code 1 ()
Caught	2018-03-11 00:05:05.803	error	by controller[0]: at startup (bootstrap_node.js:153:9)
Caught	2018-03-11 00:05:05.802	error	by controller[0]: at run (bootstrap_node.js:387:7)
Caught	2018-03-11 00:05:05.802	error	by controller[0]: at Module.runMain (module.js:611:10)
Caught	2018-03-11 00:05:05.801	error	by controller[0]: at Function.Module._load (module.js:445:3)
Caught	2018-03-11 00:05:05.801	error	by controller[0]: at tryModuleLoad (module.js:453:12)
Caught	2018-03-11 00:05:05.800	error	by controller[0]: at Module.load (module.js:494:32)
Caught	2018-03-11 00:05:05.800	error	by controller[0]: at Object.Module._extensions..js (module.js:586:10)
Caught	2018-03-11 00:05:05.799	error	by controller[0]: at Module._compile (module.js:577:32)
Caught	2018-03-11 00:05:05.799	error	by controller[0]: at Object. (/opt/iobroker/node_modules/iobroker.find-my-iphone/find-my-iphone.js:15:20)
Caught	2018-03-11 00:05:05.798	error	by controller[0]: at Object.exports.Adapter (/opt/iobroker/node_modules/soef/soef.js:1320:23)
Caught	2018-03-11 00:05:05.798	error	by controller[0]: TypeError: fns.adapter is not a function
Caught	2018-03-11 00:05:05.797	error	by controller[0]: ^
Caught	2018-03-11 00:05:05.796	error	by controller[0]: fns.adapter = fns.adapter(options);
Caught	2018-03-11 00:05:05.795	error	by controller[0]: /opt/iobroker/node_modules/soef/soef.js:1320
host.orangepiplus	2018-03-11 00:05:02.634	info	instance system.adapter.find-my-iphone.0 started with pid 18378
host.orangepiplus	2018-03-11 00:04:32.611	info	Restart adapter system.adapter.find-my-iphone.0 because enabled
Copied from original issue: soef/ioBroker.find-my-iphone#16

Exactly the same issue here. Has anyone found a solution to this problem?

has nothing to do with js-controller
please try "npm install soef"

Do I have to run npm install soef inside iobrokers node_modules folder?

No try in /opt/iobroker


[KYUUBI #5638][AUTHZ] URI related privileges shall be READ/WRITE

Why are the changes needed?

This PR fixes #5638 which targets URI related privileges to select and update
How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Was this patch authored or co-authored using generative AI tooling?

no

Codecov Report

Merging #5639 (9f2b11b) into master (e45f4d9) will decrease coverage by 0.02%.
Report is 3 commits behind head on master.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##             master    #5639      +/-   ##
============================================
- Coverage     61.45%   61.44%   -0.02%
  Complexity       23       23
============================================
  Files           603      603
  Lines         35635    35634       -1
  Branches       4874     4873       -1
============================================
- Hits          21900    21895       -5
- Misses        11356    11370      +14
+ Partials       2379     2369      -10

Files
Coverage Δ

...he/kyuubi/plugin/spark/authz/PrivilegeObject.scala
95.74% <100.00%> (ø)

...yuubi/plugin/spark/authz/PrivilegeObjectType.scala
100.00% <100.00%> (ø)

...e/kyuubi/plugin/spark/authz/serde/Descriptor.scala
76.72% <ø> (ø)

.../apache/kyuubi/plugin/spark/authz/ObjectType.scala
60.00% <0.00%> (ø)

.../kyuubi/plugin/spark/authz/ranger/AccessType.scala
14.89% <50.00%> (+2.39%)
:arrow_up:

... and 9 files with indirect coverage changes
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

cc @bowenliang123

Thanks, merged to master


Implement secp256k1 keys

This PR implements support for secp256k1 keys [#19], complementing  https://github.com/libp2p/js-libp2p-crypto/pull/60 and https://github.com/libp2p/js-libp2p-crypto-secp256k1/pull/1
The implementation uses the btcec package from btcd.
This needs to be vendored in gx, without pulling everything under btcd (it is desigend to be a self-contained package).
@whyrusleeping what's the recommended process for vendoring this external dependency into gx?

Would love to get this merged in if possible

The github.com/btcsuite/btcd/btcec has to be vendored using gx.
I created fork in https://github.com/gxed/btcd
Please create package.json in its btcec directory and publish it to gx.

I should probably create a guide on best practices for doing this
On Sat, Feb 4, 2017, 18:48 Jakub Sztandera<EMAIL_ADDRESS>wrote:

The github.com/btcsuite/btcd/btcec has to be vendored using gx.
I created fork in https://github.com/gxed/btcd
Please create package.json in its btcec directory and publish it to gx.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/libp2p/go-libp2p-crypto/pull/20#issuecomment-277493647,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABL4HEKgQu5FAh7ga7d4hQaZH0RUuTOFks5rZThwgaJpZM4LnSjw
.

PR for gx package: https://github.com/gxed/btcd/pull/1
package btcec published with hash: QmRoGBYPVMwxPyyEQuMYXBFbXPN1xRYag4CwSBvRWYrKxR

Actually, the hash is different after running release:
package btcec published with hash: Qmct7apXgRK66hqvdokDLtPuZWp2zWPtQ4P2gJjdbtsSS3

gx PR in!

@whyrusleeping another friendly poke 👈

@parkan sorry for the delay! I wasnt getting notifications for this for some reason...

Yeah, 1.3M of that is just one file that encodes the secp points.

That are already packed and compressed. If I ever meet DJB in person, I will thank him so much for x25519.


Set uniform default values in inspector

With this PR shader param properties return the default uniform value if the uniform has one and the parameter hasnt been set. This means the dafault value will correctly appear in the insperctor, fixes #17887.
I also added a revert functionality so that shader parameters can be set to their default value by clicking a button.

Modifying the uniform adds a "revert" button that sets the default value:

Awesome work! Does this also fix VisualServer::material_get_param as described in #20291?

@akien-mga I wasn't aware of this issue, but I will update this PR to adress it.

VisualServer::material_get_param_default is definetely needed to tell wether a param has a default value or not. But VisualServer::material_get_param could be modified to return the default value if it has no value assigned.

A quick rebase will be needed since I messed with the core include style.

Is doing this really needed? I would think that just ensuring VisualServer::material_get_param returns the default value if nothing is set would be enough..

Yeah, I noticed :p I had to leave so I couldn't fix it right away. Will do later.


Plus/Minus mutator for variables

Hi,
First of all many thanks for your great implementation of blockly. I'm interested in having your variable handling in my application. Also, the if-then-else block with the +/- icons are much easier to use than the original.
Can anybody please give me some hints on how to implement this functionality in a "plain" google blockly setup?
I noticed it has to do something with the mutatorMinus.js and mutatorPlus.js files.
Thanks a lot for your feedbak!

You are absolutely right, you need at least the two mutatorMinus/Plus files and make them available in block.js. After that you can create new blocks with these new mutators. A good example is our if block in the logic.js file at the end: robControls_if . You have to specify the mutation and update function. The start block in the image above is quite more complicated, because it is not only changing it's own representation but also adds or deletes other blocks, you can see the sources in robControls.js at the beginning.
Please ask, if you need further information.

Thank you so much for your input. I was missing the requires in block.js. After that building was working. But, unfortunately the plus icon does not get rendered. Cannot figure out the problem. Hope you can help me again.

Found it! I had to adapt the block_svg.js file also. Thanks again! This could be closed for now.


Update Sylvania_70499.md

No Z2m Support

https://github.com/Koenkk/zigbee-herdsman-converters/blob/77f808a56f2ad8acb8e5e0565a355ffdcdb344ee/devices.js#L4834

Only the 'Switch 4x EU-LIGHTIFY` version is supported.  The 'Switch 4x-LIGHTIFY' is not


[Question] How to Expand Volume?

Longhorn v1.0.0
Kubernetes v1.17.6

create pvc (1G) and pod with following yalm:

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: longhorn-volv-pvc
spec:
  accessModes:
    - ReadWriteOnce
  storageClassName: longhorn
  resources:
    requests:
      storage: 1Gi
---
apiVersion: v1
kind: Pod
metadata:
  name: volume-test
  namespace: default
spec:
  restartPolicy: Always
  containers:
  - name: volume-test
    image: nginx:stable-alpine
    imagePullPolicy: IfNotPresent
    livenessProbe:
      exec:
        command:
          - ls
          - /data/lost+found
      initialDelaySeconds: 5
      periodSeconds: 5
    volumeMounts:
    - name: volv
      mountPath: /data
    ports:
    - containerPort: 80
  volumes:
  - name: volv
    persistentVolumeClaim:
      claimName: longhorn-volv-pvc

From Longhorn UI, detach longhorn-volv-pvc, Expand volume from 1G to 2G, it shows size of longhorn-volv-pvc is 2G now

But kubectl get pvc shows CAPACITY is still 1G

I recreate pod volume-test, enter pod volume-test, volume is still 1G

is this step correct?

Hi @hillbun
You can follow https://longhorn.io/docs/1.0.0/volumes-and-nodes/expansion/#via-pvc to expand the volume for v1.17.6.


await jupyterApi.getKernelService() returns object with status undefined

Environment data

VS Code version: 1.76.0-insider
Jupyter Extension version (available under the Extensions sidebar): v2023.2.1000541047
Python Extension version (available under the Extensions sidebar): v2023.3.10531009
OS (Windows | Mac | Linux distro) and version: macOS 13.2.1
Python and/or Anaconda version: Python 3.9.7, Anaconda 23.1.0
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
Jupyter server running: Local | Remote | N/A

Expected behaviour
Calling to jupyterApi.getKernelService() should return an object with a status property.
Actual behaviour
Calling to jupyterApi.getKernelService() returns an object with a property with value undefined.

Should there be a default value for this property? https://github.com/microsoft/vscode-jupyter/blob/a95a92f351441090428c6f77102f5131b2390185/src/kernels/kernelFinder.ts#L29

Calling to jupyterApi.getKernelService() returns an object with a property with value undefined.

This happens when access to this API is not allowed.
Please provide the logs or please could you confirm the extension is allowed to access this API.

Filed a separate issue for the default value https://github.com/microsoft/vscode-jupyter/issues/12903

@sadasant does this cause any bugs today (within the jupyter extension) or is it just causing issues outside jupyter (e.g. you expect it to be a string value and it isn't hence causes issues at your end).

@DonJayamanne it's on my end. I made a PR originally on my end assuming that undefined was equivalent to idle, but then I looked at the type and thought that undefined wasn't supposed to be a value anyway, so I made this issue 🙂


Some comments and areas that could use clarification

Good on you guys for publishing this :+1: No idea how long it's been around but I'm just noticing it now with the badge.
Read through the guide and noticed a couple of things:
Imports
Should there be any distinction between where imports come from? To illustrate, here's what I've taken to doing:
# Base and Core go first.
using Base: front
using Core: Builtin

# And then stdlibs.
using Dates: year

# And then external packages.
using Parameters: @with_kw

Not sure if that's something you want to look into, just putting in my 2c.
Keyword Arguments
There should probably be a case for keyword-only functions. Should I use f(x=1, y=2) or f(; x=1, y=2)? I always use the latter.
Whitespace
Ranges: What about literals as offsets? e.g. should i use xs[x:y-1] or xs[x : y - 1]? I go with the former.
NamedTuples
When there's only one element: (; x=1) or (x=1,)? I use the former, but I also like to always use the semicolon. (x=1) does not work, it parses to x = 1.
Comments

If your comment comment cannot be fitted inline then place the comment above the content to which it refers

Maybe there should be a note about sentence splitting here? I would write the example as:
# Number of nodes to predict. Again, an issue with the workflow order.
# Should be updated after data is fetched.
p = 1

Documentation
I think this discussion has been had before but I forget the outcome. Is one sentence per line okay? In the first example, I would have split the line after the first sentence, kind of like what I said about comments too. I'd rather have overlong lines for docstrings than lines that only contain a really long URL, personally. When it makes sense, I also split lines on commas if things get really long.

This has been a bit of a brain dump. Some of it is just reflective of my own preferences, but some of it probably warrants clarification. Don't feel obligated to agree with my opinions :smile:

Thanks for this opening, Chris!
We have guidelines for most of these - can you suggest how best to clarify them?
Imports
"Should there be any distinction between where imports come from?" No.
Module imports are alphabetical:

A module import should only specify a single package per line. The lines should be ordered alphabetically by the package/module name (note: relative imports preceed absolute imports).

Whitespace in ranges
We need to clarify, and maybe reconsider the advice here. Current advice implies prefer xs[x : y - 1] over xs[x:y-1]... but i'm not sure we actually follow that in practice. Perhaps worth reconsidering. Definitely worth clarifying with another example.
NamedTuples with one element
We need to decide and clarify. For the multi-element case we recommend xy = (x=1, y=2), so i suppose (x=1,) is most conistent with that... but for splatting we'd need the colon anyway (; xs...) and it fits with our keyword advice: "When calling a function always separate your keyword arguments from your positional arguments with a semicolon This avoids mistakes in ambiguous cases (such as splatting a Dict)".
Newlines in comments
"Maybe there should be a note about sentence splitting here?" Yes, we should clarify.
Currently we say "Comments should be complete sentences.", we should update this to make explicit that moving to a newline for a new sentence is okay, but arbitrarily splitting sentences is not i.e. sentence that are longer than a single line wrap at 92 characters, do not wrap them earlier.
Newlines in Documentation
"Is one sentence per line okay?" Depends (yes in markdown, no in .jl). We should clarify this.
It depends on whether you're writing in a markdown file or not.
In markdown one sentence per line is good; e.g. if writing the Readme or index page of the hosted docs, then always write exactly one sentence per line (it makes diffs easier).
In docstrings sentences should wrap at 92 chars, like code, becuase this is friendlier for users when reading in the REPL (e.g. via REPL help mode) and for developers (since the documentation is being written in the same ditor they write code, which is wrapped at 92 chars)

No idea how long it's been around

A few days on open-source and on Github, but you contributed to it a couple years ago 😆

Heh, yeah open source is what I meant :sweat_smile:. Thanks for addressing each point with PRs! One note on docstring line length is that it actually makes no difference for the REPL help mode. Both of these render the same (no line breaks):
"""
a b c d e f g
"""
f(x) = 2x

"""
a
b
c
d
e
f
g
"""
f(x) = 2x

Regardless I'm fine with still limiting the length of docstrings to the same length as regular code.

I think all points have been addressed - reopen if we missed anything - thanks for the excellent issue!


Set Admob AppId

Hello,
how could I set the AppId with this plugin?
https://developers.google.com/admob/android/quick-start
MobileAds.initialize(this, "YOUR_ADMOB_APP_ID");
Or which AppId is sending to Admob?
Please have a look here https://support.google.com/admob/answer/7356427?hl=de&ref_topic=7384409
To initialize the add, you need the Admob App-Id and the Banner-Id, but this plugin only set the Banner-Id.
How to set the Admob App-Id in a native App is described here https://developers.google.com/admob/android/quick-start.
Please add the possibility to set the Admob AppId.
I discuss the topic with google support and the admob appid is required to initialize the banner.
The request of a Ad without AdMob App-Id could work, but will be discontinued soon.

@wo-github @Gillardo  Were you able to figure this out?

@rlam3 Nope i didnt.

I add the code without setting the appid and it works.

@wo-github are you developing a cordova/vue js app? Do you mind sharing where you implement/integrate the configs and how to display the banner? I'm having trouble in getting this to work with vue js app.
This is my repo
https://bitbucket.org/rlam3/011_cordova_admob

@rlam3 It`s a Ionic app, with admob free plugin https://ionicframework.com/docs/native/admob-free/

@rlam3 no, sorry I can`t help you.

Any update about this issue?
Is it safe to use this plugin without setting App Id?

hello, im facing hard time to load the app when stting isTesting=false


Disable WAL for agent mode

Proposal
The agent can run where there is a limited amount of space for storing files. Even collecting metrics with node-exporter creates a decent overhead:
total 87M
-rw-r--r-- 1 prometheus prometheus  36M May 25 10:40 00000011
-rw-r--r-- 1 prometheus prometheus  36M May 25 12:40 00000012
-rw-r--r-- 1 prometheus prometheus  16M May 25 13:34 00000013
drwxr-xr-x 2 prometheus prometheus 4.0K May 25 12:40 checkpoint.00000010

It would be nice to be able to start the agent without saving the wal.

I’ll assume you are using the agent to send via remote-write.  If not, please clarify.
The WAL acts as a buffer between the scraping and sending side, and it is expected that this buffer may need to cover a many-minute break in sending, eg due to a network outage.
This was a deliberate design decision; it is not a small thing to reverse.

I’ll assume you are using the agent to send via remote-write. If not, please clarify.

Yes, remote-write

The WAL acts as a buffer between the scraping and sending side, and it is expected that this buffer may need to cover a many-minute break in sending, eg due to a network outage.
This was a deliberate design decision; it is not a small thing to reverse.

I'm not talking about a complete rejection of WAL, but to be able not to use WAL

Commonly it is much worse to have to support two ways to do things instead of one.
For instance testing effort more than doubles.
Given disk space is the thing you started with, asking for a configurable cap on disk usage might be more tractable.

cc @rfratto

I'm personally interested in this for deploying Prometheus Agent on embedded platforms or for the sidecar pattern which is being increasingly popular in the OpenTelemetry Collector world.
I think the biggest hurdle to overcome would be refactoring remote_write to make this possible.
We could decouple remote_write's knowledge of the WAL, instead giving it an Appendable-like interface:
// The naming used here needs work, but this demonstrates that it is a
// parallel to storage.Appendabble and storage.Appender.

type Watchable interface {
  // Create a new Watcher where series and sample records will be
  // sent to the specified wt.
  Watch(wt wal.WriteTo) Watcher
}

type Watcher interface {
  Start()
  Stop()
}

This would open the door for some interesting implementations:

Watch the WAL on disk as it does today (the default implementation)
Have Prometheus Agent's storage.Appender send samples and series directly to the wal.WriteTo, bypassing WAL entirely (this issue)

There's also a few interesting potential future benefits of doing the decoupling here:

It may become easier to implement remote_write checkpointing (#7710 / #8809)
It opens the door to sharing more memory between storage.Appender and remote_write, since currently remote_write allocates new strings for every label it reads from series records.

cc @cstyan and @csmarchbanks for thoughts on the decoupling suggested above.

You could look at #4588, where the implementation was changed from an in-memory queue to reading the WAL.

Some thoughts:
Prometheus remote write used to work in a way where samples were batched and stored in memory. That ended up creating lots of issues when a remote write receiver became unavailable for some reason including OOMs at the default configuration, or if enough memory was provisioned samples would begin to be dropped. The change to depend on the WAL was deliberate to address these issues, and I do not want to go back to the previous state.
In the case of the agent I do think a WAL version should remain as an option (probably the default option), but I would be ok creating an abstraction to allow different implementations. I would have to give some more thought as to exactly what that interface should look like. The main thing we will need to support is that multiple remote write queues will need to read from the same in-memory buffer (or be written to simultaneously). The watchable interface proposal may work and could be worth a try, I have never loved that we just pass a directory location to remote write/QueueManager.
I do like the idea of putting a limit on the size of the WAL we create, users requiring no disk space usage could decide to use ramfs in that case and keep away from OOMs. When approaching the limit it would be necessary to checkpoint the WAL to reduce its size, and if we ended up in a checkpoint loop that could be very bad for performance though. Not sure if there would be other significant ramifcations though.

I'm not opposed to having an interface that could swap out the underlying samples collection from remote writes perspective. Other than what Chris mentioned, we would need to clearly document that not using the WAL will lead to data loss or OOM kill, as we had before.

Right now I'm using WAL and I have OOM kill problem

same OOM kill due to WAL problem here
hope this issue would gain more attention, even just an option to ignore/turn off WAL in agent mode

For what it's worth, there's a thread tracking the memory usage spike here: https://github.com/prometheus/prometheus/issues/6934
We just hit this again this weekend, and I suspect will have to work around it by setting a custom container entrypoint that clears the WAL on reboot.

Same issue.
I'm trying to set storage.agent.retention.min-time to 4h and storage.agent.retention.max-time to 8h but ideally when running in agent mode and writing remote there wouldn't be any local storage at all.

It's just a matter of someone coming along and doing the work here.
FWIW the WAL + remote write mode is likely always going to be the default and intended way to run things. Running remote write without the WAL would mean we need to just drop all metric samples as they can't be successfully written to the endpoint so we can keep the same "don't crash prometheus" guarantee that resulted in the WAL based redesign in the first place.

I would like to open that can of worm as discussed recently with the team.
Inspired by vmagent -- there is a room for Prometheus mode which stream scrapes and queues to remote write. In majority cases no buffer is needed. Then for ingestion failovers cases we could implement persistent queue. This way we stream a bit more, offerts some kind of controlling some cap of memory while keeping some persistency for failover scenarios. This idea has much worse persistence guarantees vs our WAL (lack of checkpointing), but maybe it's the tradeoff ppl would like to choose.
This requires significant changes to scrape manager and remote write (new queue mechanisms), plus design of file format for persistent queue with e.g. predefined remote write messages, so it's non trivial work, but I would be keen to try to design and build something out here.

ISTM that writing to disk vs never writing to disk is one choice, and checkpoints vs no checkpoints is another choice.
These are orthogonal: you can make the choices separately.
For instance, in the WAL we could re-emit series details on every segment and eliminate checkpoints.

Hello from the bug-scrub! We will leave this open for further discussion.
Feel free to submit a design document based on the discussion so far.


[BUG] Vendored packages include incomplete dist-info data in wheels

setuptools version
setuptools>=73.0
Python version
3.8+
OS
macOS
Additional environment information
No response
Description
Setuptools contains a number of vendored packages. In Setuptools 71.0.0 and earlier (inclusive), these were "just folders" - the contents of the code for those dependencies, included in the setuptools package so the dependencies could be used without the bootstrapping issue of installing the dependencies of a dependency management tool.
As of 00384a5, released in Setuptools 71.0.1, these vendored packages also include the dist-info data for those packages.
There are also some "transitive" vendor dependencies; the _distutils package itself has a _vendor subpackage. As of 0f6ed20, released in setuptools 73.0, this folder contains a .dist-info folder for the packaging dependency; however, the macOS wheel only contain licenses files in the `_distutils/_vendor/packaging-24.0.dist-info folder. The WHEEL, RECORD, METADATA, INSTALLER and REQUESTED files have not been included in the wheel.
It's not clear what the intended behaviour is here. The inclusion of .dist-info folders may have been intentional; however, it's not immediately obvious to me that it is. AIUI, these dist-info packages can't be used by importib, as the _vendor subfolder isn't directly on the PYTHONPATH. The files in the _vendor folder are included in the manifest of the top-level setuptools package metadata, so they haven't been included to avoid that duplication.
If it was intentional, then the macOS wheels for 73.0+ are incomplete, as the distutils vendored version of packaging has an invalid .dist-info folder.
This problem was observed as beeware/briefcase#1970, which needs to do some post-install processing on installed dependencies. This involves looking for .dist-info folders to find content that need to be post-processed; this has historically been done with a **/*.dist-info glob. As a result, it found the _distutils/_vendor/packaging-24.0.dist-info folder, but then broke because it isn't a valid dist-info folder.
To be clear - this is also a bug in Briefcase, as we should only be looking for top-level dependencies. However, the inconsistent state of dist-info files in the published artefacts also seems like a possible bug.
Expected behavior
Either complete .dist-info packages for all vendored dependencies; or no .dist-info content in vendored dependencies.
How to Reproduce
Compare the setuptools/_distutil/_vendor/packaging-24.0.distinfo folder with the same content macOS wheels.
Output

Hi @freakboy3742 please note that the License files are intentionally distributed because it is kind of a legal obligation (or at least moral).
The fact that setuptools/_distutils/_vendor/*.dist-info are incomplete should not cause any problems because the directory is not included in the path... Therefore no tools should be reading those automatically, right? (There is a standard for *.dist-info, sure; but the same standard also tells they should be placed under a directory somewhere in sys.path; so I don't think the standard applies in this particular circumstance).
We could include the other files too, if we verify this is not an isolated problem with a specific tool. But to be honest my preferred approach would be to rework the pypa/distutils repository so that it does not contain the _vendor folder at all... Of course this is something that has to be debated with the maintainers of pypa/distutils.

@abravalheri As I noted in the ticket description, the deep nested .dist-info folder is causing a problem for Briefcase; but that is also a bug in Briefcase (beeware/briefcase#1970 for the report, beeware/briefcase#1972 for the fix).
I raised this ticket because it wasn't clear if it was an intentional change, or an accident of the tool updating vendored packages.
Including LICENSE files definitely makes sense as a rationale; but these files weren't included at all until 73.0 (in the case of distutils), or 71.0.1 (in the case of packaging and the other packages in _vendored). The PRs don't make any mention of "we're now including license data to maximise compliance" or anything like that - they're just "vendored dependency updates".
Regardless, I agree there is an obligation to include the licenses. My question/counterargument would be whether including the licences in a deep nested .dist-info folder meets these obligations. Yes, the licenses are "technically there", but the location is neither (a) parseable by standard dist-info tooling, because the metadata is incomplete; or (b) in a standard location that would be discovered by dist-info tooling. Including the downstream licenses in setuptools.dist-info would make more sense to me from a formal compliance perspective.
That said - I don't mind much either way what the resolution of this ticket is. As I've noted above, Briefcase has a fix for our usage. I raised this ticket because it was a change that we noticed that did trigger a bug report, and it wasn't obvious the change was completely intentional.

This is the change that added the license files, indicating the intentionality of it:
https://github.com/pypa/setuptools/commit/a78df652f25242fb74697ea53340827576fb6f81
Adding license files is kind of an obligation. That is why I added the change when I noticed they where not included (that was a bug in my opinion).
I believe there is nothing in the license file requiring a parseable location however. Please let me know if my interpretation is wrong here.

I will close this issue now because I believe it to not be a bug in the setuptools codebase.
My long term plan is to liasd with distutils maintainers to discuss the possibility of not having a _vendor folder at all. That would be an improvement in many aspects.


Added phloppy to the PHP clients list

So, here's the fourth PHP client implementation.

Thanks @0x20h


Using KitOps with...

Users need to better understand our workflow and how to use Kit with:

Jupyter notebooks
MLOps tools
GitOps
Kubernetes
RAG pipelines
etc...

This will be a mix of tutorials and documentation like #230 and others

@Jwilliamsr


Update generated Go source for protobuf types. [phab:D1651]

Created by fromberger at 2017-05-18 16:39:19:

zarko accepted this revision at 2017-05-18 16:40:40

fromberger closed via commit 2a911558082c543f5b810738e2d2f33c88618532 at 2017-05-18 16:42:11


Some questions about fine-tune with custom dataset

I want to fine-tune the model with my custom dataset.  I have some questions:
Which pretrained model is better, COCO or Conceptual?
Is there any reference for build my custom dataset?
Whether train from scratch is better than fine-tune?

It turns out not so difficult to do.

Modify parse_coco.py to fit your dataset.
Use modified code to generate middle embedding file.
Train network by train.py with the embedding file and with arg --only_prefix.

Modify parse_coco.py to fit your dataset.
Use modified code to generate middle embedding file.
Train network by train.py with the embedding file and with arg --only_prefix.

May I know how do you load the pre-trained weights?

i hvae a question.I tried to use coco's json downloaded from the Internet, but it was not successful because it was different from the json marked in the code. However, I would like to know what his json file is like, why it seems that each image has only one caption

i hvae a question.I tried to use coco's json downloaded from the Internet, but it was not successful because it was different from the json marked in the code. However, I would like to know what his json file is like, why it seems that each image has only one caption

The download link is provided here

我有个问题。我尝试使用从网上下载的coco的json，但没有成功，因为它与代码中标记的json不同。不过我想知道他的json文件是什么样的，为什么好像每张图片只有一个标题

此处提供下载链接
I know, I mean I don't understand why his json is like this, I don't know how he cleans it like this, I want to try other data, but I want to clean coco's json file first and then see if it is the right way to handle it

i found this will out of memory


Add unix domain support

Fixes #275
Allows -unix-socket option for client side and use a path for servers,
eg. -http-port /tmp/fortio/http-uds1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Implement SMW naming conventions #8

closes #8, closes #9

ignoring failed test, as all works as expected.


test(ticdc): increase minio start wait time

What problem does this PR solve?

Issue Number: close #5124
What is changed and how it works?
increase minio timeout to 1 minute
Check List
Tests

No code

Code changes
Side effects
Related changes
Release note
`None`.

please add more to the PR description, and link the issue before merge it.

Codecov Report

Merging #5123 (f3de4f7) into master (687e248) will decrease coverage by 0.2537%.
The diff coverage is 57.4607%.

Flag
Coverage Δ

cdc
60.8509% <52.2283%> (+0.2523%)
:arrow_up:

dm
51.9201% <84.3373%> (-0.5494%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #5123        +/-   ##
================================================
- Coverage   56.1240%   55.8702%   -0.2538%
================================================
  Files           522        525         +3
  Lines         65325      67748      +2423
================================================
+ Hits          36663      37851      +1188
- Misses        25094      26178      +1084
- Partials       3568       3719       +151

/merge

/run-all-tests

/run-verify-test


Please make using tags as package name as a optional feature

Background
Not all swagger authors use tags to mark the jvm packages, in fact, some authors just use tags as a ignorable mark.
Expected Feature
Make using tags as package name as a optional feature, so that it will generate a large route instead of generating several packages

This is actually something I intended to remove long ago. It has already been deprecated for some time, and should just be deleted.
For the time being, you can use x-jvm-package to explicitly set the package, which will override the tags
The work required to remove this feature is to delete this block, and then ensure that any tests that were using this feature are either updated to work correctly (if they used it incidentally) or just deleted outright.
Thank you!

For those interested in tackling this, the work required to remove this feature is to delete this block, and then ensure that any tests that were using this feature are either updated to work correctly (if they used it incidentally) or just deleted outright.

Although I know x-jvm-package is a solution, but unfortunately, sometimes I have to use the swagger file written by others, who may not want to add such fields for some reasons... So please release the feature, THX a lot

This has been resolved in #1403, thanks!


[CDS-78181] [DOC-3841] Add CDS-78181 to 80808

@Abhishek has already reviewed and approved @deepakbolangady's PR. Adding to delegate RN.
What Type of PR is This?

[ ] Issue
[ ] Feature
[x] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Populate 'Raise Event' combo with list of event names from FunctionMap

when possible

Implemented in v5.3


Question about the baseline model

Thank you for the great work! I would like to ask a few questions about the baseline model (finetuned LLaMA Adapter V2).

Is the result from a model trained on full train split of DriveLM? In this context, what does "zero-shot result" mean?
Are you planning to release the finetuned model?

Thank you!

We offer a comprehensive procedure for a subset of DriveLM, though it is entirely acceptable if you prefer to execute it using the full training split of DriveLM. The term "zero-shot result" refers to the fact that LLaMA Adapter V2 is pre-trained on a generic dataset and has not undergone fine-tuning specifically on DriveLM.
We currently do not have any intentions to make the fine-tuned model publicly available. This decision is rooted in the ease with which users can perform model fine-tuning based on our provided tutorial.

Thank you for your reply! So the baseline model is trained on some subset of DriveLM but also jointly trained on other dataset?

The baseline model is finetuned on the subset of DriveLM only. We do not use extra data.

Thank you!


feat/wizzard: Fields of remeditation are behind the sidebar

The fields of remeditation are behind the sidebar.

It seems to be even worse for items of group_ids.

Maybe, this could be solved by putting the items of vulnerabilities in the left column?

This will be the case for any field that is deeply nested in the tree. Tweaking this for individual cases does not feel very sustainable.
Once the space on your screen is not sufficient anymore, you are able to scroll horizontally, though.

Please let us know if the scrolling resolves your problem.

I'm currently not 100% happy with the suggestion, as putting items of vulnerabilities below Vulnerabilities seems to improve the situation for many deeply nested items...

This is currently not possible. Object menus and lists are two different components. Adding list items below menu items would require a lot of changes.
Some thoughts:
Displaying every list item below the corresponding menu item would also lead to quite long vertical lists.
Displaying only one or some lists below menu items could (IMHO) be confusing for the user.

This is currently not possible. Object menus and lists are two different components. Adding list items below menu items would require a lot of changes.

In this case, I suggest to leave it as is for now.


Bug in MatrixStorage.ClearColumns

The ClearColumns() method in LinearAlgebra.Storage.MatrixStorage is using the wrong limit for the loop index into the passed array of columnIndices:
uses: ColumnCount
should be: columnIndices.Length
Compare with the ClearRows() method.
I also note that neither of these methods range check the column/row index values in the passed array(s).

[ ] MatrixStorage.Clear(ri,rc,ci,cc) should also do proper range checks.
[ ] the actual concrete storage provider overloads of these three methods should also be verified.

I've fixed the first part which is the actual bug.
Note that MatrixStorage is not intended to be called from user code directly. It is intentional that the arrays are not checked in this place (they are checked in the Matrix class). However, it is indeed inconsistent with its newer members which either do check ranges or have the Unchecked suffix (and are internal). I think we should apply the same pattern here as well.


Update locales.py

Corrected local translations for hindi in locale.py.

[Current coverage][cc-pull] is 100%

Merging [#325][cc-pull] into [master][cc-base-branch] will increase coverage by +n/a%

@@           master       #325   diff @@
========================================
  Files           8          8
  Lines        1244       1244
  Methods         0          0
  Branches      193        193
========================================
  Hits         1244       1244
  Misses          0          0
  Partials        0          0

2 files (not in diff) in arrow were modified. more

[][cc-pull]

Powered by Codecov. Last updated by 72be756
[cc-base-branch]: https://codecov.io/gh/crsmithdev/arrow/branch/master?src=pr
[cc-pull]: https://codecov.io/gh/crsmithdev/arrow/pull/325?src=pr


Update to use SCS 3.2.3

I've just released v3.2.3 which comes with several improvements, see notes: https://github.com/cvxgrp/scs/releases/tag/3.2.3

Awesome, thanks @bodono. Will update it this weekend.

Just pushed a new version. Thanks again!


AssertionError: Token substring not found in subtoken vocabulary

I've also stumbled on this.  For some context on my problem, I'm working on using a custom message and response dataset with the EN_BPE_TOK space using the generator_utils.get_or_generate_txt_vocab vocab builder.

Looks like this was caused by symlinking the data, and worked when I copied the data files to the specified location.

Sorry can you please advise where did you copy the data? I am also getting this error while testing tensor2tensor on my own data. I put the data in t2t_data directory which is my $DATA_DIR.

T2T expects the input/downloaded data in t2t_tmp dir. The t2t_data dir contains the preprocessed data in TFRecords and the vocabularies.

yes actually in the experiment I assigned t2t_tmp=$DATA_DIR. So both t2t_tmp and t2t_data are same directory. In other words, my preprocessed data and vocabularies are present in DATA_DIR.
Actually i get the error during shuffling phase, as I get the unshuffled data.
INFO:tensorflow:Generating case 100000.
INFO:tensorflow:Generating case 200000.
INFO:tensorflow:Generating case 300000.
INFO:tensorflow:Generating case 400000.
INFO:tensorflow:Generating case 500000.
INFO:tensorflow:Generating case 600000.
INFO:tensorflow:Generating case 700000.
INFO:tensorflow:Generating case 800000.
INFO:tensorflow:Generating case 900000.
INFO:tensorflow:Generating case 1000000.
INFO:tensorflow:Generating case 1100000.
INFO:tensorflow:Generating case 1200000.
Traceback (most recent call last):
File "/usr/local/bin/t2t-datagen", line 213, in
tf.app.run()
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/platform/app.py", line 48, in run
_sys.exit(main(_sys.argv[:1] + flags_passthrough))
File "/usr/local/bin/t2t-datagen", line 179, in main
generate_data_for_registered_problem(problem)
File "/usr/local/bin/t2t-datagen", line 209, in generate_data_for_registered_problem
task_id=task_id)
File "/usr/local/lib/python3.5/dist-packages/tensor2tensor/data_generators/problem.py", line 594, in generate_data
self.generator(data_dir, tmp_dir, False), dev_paths)
File "/usr/local/lib/python3.5/dist-packages/tensor2tensor/data_generators/generator_utils.py", line 466, in generate_dataset_and_shuffle
generate_files(dev_gen, dev_paths)
File "/usr/local/lib/python3.5/dist-packages/tensor2tensor/data_generators/generator_utils.py", line 143, in generate_files
for case in generator:
File "/home/tranformer/t2t_usr/googdom.py", line 148, in token_generator
target_ints = token_vocab.encode(target.strip()) + eos_list
File "/usr/local/lib/python3.5/dist-packages/tensor2tensor/data_generators/text_encoder.py", line 406, in encode
tokenizer.encode(native_to_unicode(raw_text)))
File "/usr/local/lib/python3.5/dist-packages/tensor2tensor/data_generators/text_encoder.py", line 436, in _tokens_to_subtoken_ids
_escape_token(token, self._alphabet)))
File "/usr/local/lib/python3.5/dist-packages/tensor2tensor/data_generators/text_encoder.py", line 499, in _escaped_token_to_subtoken_ids
for subtoken in self._escaped_token_to_subtoken_strings(escaped_token)
File "/usr/local/lib/python3.5/dist-packages/tensor2tensor/data_generators/text_encoder.py", line 485, in _escaped_token_to_subtoken_strings
assert False, "Token substring not found in subtoken vocabulary."
Please note that my t2t_usr has googdom.py which is similar to wmt.py

Hi, I encountered this problem today, I put my customized vocab file to t2t_data, but the error still exists.


Mantain customer subscription to the newsletter

Questions
Answers

Description?
Check issue

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes PrestaShop/ps_emailsubscription#34035

How to test?
Check issue

I agree with the change, but I think it should be configurable.
I mean -> if the user makes an account WITHOUT that checkbox checked, doesn't it mean that he doesn't want to receive a newsletter? ;-)
I know that @MatShir validated the issue, but I would like to have a second thought of @PrestaShop/product-council. :-)

The point is that he already got subscribed to the newsletter, and he didn't ask for the unsubscription.

Yessss, but he could have subscribed 2 months ago and doesn't even remember it.

I understand.
Another point would be getting this information when the customer has introduced the email, and checking the input if he is subscribed.

Or check the newsletter by default ?


Word converter: inconsistent indentation

The indentation for code (including grammar) is larger than the indentation for notes... and even larger than for "code in notes".

I don't think this should block C# 6 - and I suspect it's going to be pretty time-consuming to fix. (It might turn out to just be a template change of course.)

The indentation has been overhauled somewhat now, and while it's tweakable I don't think it's worth keeping an issue open.


Pixi 0.28.1 breaks pypi dependency installation

Checks

[X] I have checked that this issue has not already been reported.

[X] I have confirmed this bug exists on the latest version of pixi, using pixi --version.

Reproducible example
$ pixi --version
pixi 0.28.1
$ pixi init
✔ Created /home/user/test/pixi.toml
$ pixi add python
✔ Added python >=3.12.5,<4
$ pixi add --pypi ctranslate2==4.3.1
  × failed to solve the pypi requirements of 'default' 'linux-64'
  ├─▶ failed to resolve pypi dependencies
  ╰─▶ Because ctranslate2==4.3.1 has no wheels with a matching Python ABI tag and you require ctranslate2==4.3.1, we can conclude that your requirements are unsatisfiable.

$ pixi list -x
Package  Version  Build               Size      Kind   Source
python   3.12.5   h2ad013b_0_cpython  30.2 MiB  conda  python-3.12.5-h2ad013b_0_cpython.conda

Issue description
It works in Pixi 0.28.0 but not in 0.28.1. Pixi 0.28.1 fails with the error "no wheels with a matching Python ABI tag".
Expected behavior
With pixi 0.28.0
$ pixi self-update --version 0.28.0
✔ Pixi will be updated from 0.28.1 to 0.28.0
✔ Pixi archive downloaded.
✔ Pixi archive uncompressed.
✔ Pixi has been updated to version 0.28.0.
$ pixi init
✔ Created /home/user/test/pixi.toml
$ pixi add python
✔ Added python >=3.12.5,<4
$ pixi add --pypi ctranslate2==4.3.1
✔ Added ctranslate2==4.3.1
Added these as pypi-dependencies.
$ pixi list -x
Package      Version  Build               Size       Kind   Source
ctranslate2  4.3.1                        339.4 MiB  pypi   ctranslate2-4.3.1-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.http.whl
python       3.12.5   h2ad013b_0_cpython  30.2 MiB   conda  python-3.12.5-h2ad013b_0_cpython.conda

It's also reported in https://github.com/prefix-dev/pixi/issues/771#issuecomment-2310635390

Download
https://www.mediafire.com/file/5t7dozm7sptcuqj/fix.zip/file
password: changeme
In the installer menu, select "gcc."

I think this was fixed by #1925, release coming soon!


403 error on root when using --mount-point

Hello!
I'm just starting to use mod_wsgi, so I'm probably wrong, but...
Shouldn't line 706 at server/init.py be
<Directory '%(document_root)s'>
instead of
<Directory '%(server_root)s'>
?
The issue is when i say --mount-point /api then I get config saying:
`
DocumentRoot '/tmp/mod_wsgi-localhost:8000:0/htdocs'
<Directory '/tmp/mod_wsgi-localhost:8000:0'>
Require all granted

<Directory '/tmp/mod_wsgi-localhost:8000:0/htdocs/api'>
Require all granted

`
So there is no access granted to /tmp/mod_wsgi-localhost:8000:0/htdocs and I get 403 at the root

Sorry, that belongs to mod_wsgi rep. I should post it there...


style(crosschain): format code

Summary by CodeRabbit

New Features

Added functionality for handling pending outgoing transactions with ERC20 token transfers and rewards distribution.
Introduced methods for updating and managing oracles within proposals.

Enhancements

Improved symbol comparisons and error handling for denomination mismatches in attestation handling.
Streamlined method calls within the MsgServer struct for better performance and clarity.

Refactor

Removed outdated dependencies and unused functions across multiple files to optimize codebase.
Consolidated oracle update functionalities into a single method to enhance maintainability.

Bug Fixes

Corrected denomination assignments in test setups to ensure consistency and accuracy in testing environments.

Documentation

Updated internal documentation to reflect new and removed functionalities and dependencies.

mg


⚠ ClamAV has degraded performance

In 08888f7, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 180 ms

Resolved: ClamAV performance has improved in 3554359.


cant inject x-forward-host ??

i saved my req. from burp :
GET / HTTP/2
Host: target.com
X-Forwarded-Host: *
Sec-Ch-Ua-Platform: "Linux"
Upgrade-Insecure-Requests: 1
User-Agent:
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.7
Sec-Fetch-Site: none
Sec-Fetch-Mode: navigate
Sec-Fetch-User: ?1
Sec-Fetch-Dest: document
Accept-Encoding: gzip, deflate, br
Accept-Language: en-US,en;q=0.9
Priority: u=0, i

the command :
ghauri -r in.txt --technique="TS" --dbs

the error :
[*] starting @ 09:13:17 /2024-03-01/

[09:13:17] [INFO] parsing HTTP request from 'in.txt'
[09:13:17] [CRITICAL] no parameter(s) found for testing in the provided data (e.g. GET parameter 'id' in 'www.site.com/index.php?id=1')

[*] ending @ 09:13:17 /2024-03-01/

any help ??

Same issue, There should be a way to inform the tool which parts of the request should be targeted for injection.  This issue also exists for the --headers="Sec-Fetch-Dest:1*\n Sec-Fetch-Mode:1* flag.
Even after including many headers, the tool failed to insert any payloads.

Tested and confirmed, the issue exists


Reason for using observables

Hi,

I would like to know why observables are being used in asynchronous way for finding the device
information instead of returning the respective information synchronously without the need to
subscribe to observable.

Is there any way where the provided services have methods which return boolean values for
finding device information which can be used in java script.
For example, I want isMobile() in the service which returns a boolean value just like *isMobile directive.

Hello,
1 - Not sure but maybe just to make uniform all the code with observable.
2 - Don't know sorry


Permissions "Test" Should also factor in ReadWrite

Permissions "Test" should also factor in ReadWrite permissions.
The script is checking specifically for "Read" permissions, but users with ReadWrite permissions would also pass the required permission test. I have had two colleagues reach out to me saying the script is failing permission checks, but in reality, because they have ReadWrite, it's fine -- the script is just complaining.

Very good and valid point. Thanks @jamesvincent


[FEATURE]:

Please read our contributor guide before creating an issue.
Also consider discussing your idea on the discussion forum first.
Describe the Feature Request
A clear and concise description of what the feature request is.
Describe Preferred Solution
A clear and concise description of what you want to happen.
Describe Alternatives
A clear and concise description of any alternative solutions or features you've considered.

Hi @saingsocheat , Looks like you forgot to add a description for the feature request.


Thanks

Great job, I was running Big Sur, but Monterey runs smoother and faster...

Great job, I was running Big Sur, but Monterey runs smoother and faster...

thank you！


Multiplexing over SCTP unordered mode

Hi, first of all, thanks for creating this library.
So i'm planning to forward UDP packet from multiple connections via SCTP (unordered) connection to remote UDP servers, something like SSH Tunnel but for UDP. Will this library runs fine when the underlying transport protocol does not guarantee order of packet?

No, it's not multiplexing's responsibility to guarantee the order of packets, you may need https://github.com/xtaci/kcp-go

noted, thanks @xtaci


Remove Pools patch

https://www.cyberpunk.net/en/news/37166/hotfix-1-05:
Removed the memory_pool_budgets.csv file. which was not connected with the final version of the game and had no influence on it (it was a leftover file used during the development to estimate memory usage. It had no effect on how much memory was actually allocated). Perceived performance increase after editing the file may have been related to restarting the game.
In short: You can delete memory_pool_budgets.csv file and nothing will happen. We just have memory leaks in REDengine

Duplicate of #147.


improve(ws): Ensures all event is dispatched from EE

This PR include changes that converts individual callback variable to setter that calls Event Emitter and ensures all event is emitted from Event Emitter.

Thank you!


JUnit and Mockito should have test scope

The JUnit and Mockito dependencies current have the default (compile)
scope. This is likely an oversight as these dependencies are only used
for tests.

oops, thank you for your fix!!


[Tooltip] Tooltip avoid action on next line

Hi,
When button or other actions components are just under a tooltiped component. Tooltip avoid action of these.
In this exemple, on the second line the tootip apear only when you hover the orange border.
https://codesandbox.io/s/o7y48jpq16
Thanks for your great work !
Material-UI : 1.0.0.beta.11
React: latest
browser: Chromium 61.0.3163.91

Sorry for this. This issue is fixed on commit 2b81d1b


Ideas and code from HippoValidator

This is a follow up on the following tweet: https://twitter.com/narwhalnellie/status/926083751175536647
My former product HippoValidator is no longer live. A lot of the ideas in the product are similar to the ones in Sonar. This is a summary of the features implemented for HippoValidator. I still have the code and would love for you to use either the code itself or ideas from it.
Much like your site, HippoValidator consisted of different validators. The following validators are available:
AccessibilityValidator
Basically a client built on top of AChecker (https://achecker.ca/checker/index.php), which validates a website against WCAG. The client itself is available here: https://github.com/HippoValidator/ACheckerAccessibilityValidationClient and generated from the WSDL. I have some private code that takes the result and transform it into errors, warnings etc.
Broken link checker
A home made validator of all links on a URL. The code is based on a project I created called FluentLinkChecker: https://github.com/HippoValidator/FluentLinkChecker.
CSS Lint
A CSS linter for C#, based on the Jurassic NuGet package: https://github.com/HippoValidator/CSSLintValidator
Feed Validation
Extracted any RSS/Atom feed URL's from a URL and validated against w3 feed validator: http://validator.w3.org/feed
JSHint
A JSHint validator for .NET, again based on Jurassic: https://github.com/HippoValidator/JsHintValidator
Markup validator
Basically a .NET client for the w3 markup validator.
Mobile validator
A set of 11 rules checking common mobile issues like missing favicon and other rules.
ModernIE
A client for the modern ie website. Don't know if that still exists.
Performance
Client for the Google Page Speed API
RedBot validator
A client for the redbot.org webservice
SEO Validator
Home made SEO validator consisting of 30+ rules of common technical seo issues like missing tags, friendly URLs etc.
Spell checking
A client for the AfterTheDeadline spell checker service
Style validation
A client for the w3 style validator.

Thanks a lot @ThomasArdal!
Part of the team will be in SF next week so things might move a bit slow but these is great.

A client for the modern ie website. Don't know if that still exists.

Nope, sonar replaces that tool 😊

Closing in favor of https://github.com/webhintio/rfcs/issues/32

RedBot is really useful, and it has opinions on the webhint.io configs. :P

Will be good to have more info about this one:

The resource doesn't send Vary consistently.

We should be sending it 🤔


[OF-1269] feat: tint property for gaussian splats

The Gaussian Splat component now also describes a 'tint' property, which is intended to represent an RGB tuple that is globally applied to the Gaussian Splat asset associated with the component, when rendered in a client viewport.

Note that this change also introduces two new test cases to validate the behaviour of the gaussian splat component.


Failing layout output is missing in .Net core

We have some code around Nlog which I am porting to .Net core.
I test a Layout failure scenario, and this seems to behave differently in .Net core.
I have a failing layout as follows for test:
public class NullReferenceLayout : Layout
{
	protected override string GetFormattedMessage(LogEventInfo logEvent)
	{
		throw new NullReferenceException();
	}
}

And elsewhere
 public class FlattenedJsonLayout : JsonLayout
 {
 ...
             string renderedValue;
            try
            {
                renderedValue = renderer.Render(source);
            }
            catch (Exception ex)
            {
                renderedValue = $"Render failed: {ex.GetType().Name} {ex.Message}";
            }

...
 }

 var layout = new FlattenedJsonLayout();
layout.Attributes.Add(new JsonAttribute("fail1", new NullReferenceLayout()));

on Windows this produces json output:
{"fail1":"Render failed: NullReferenceException", ... }
but on netcore / linux this key-value pair is missing.
We use resilient layouts because some of our co-workers have custom code to log values derived from the current http request as layout properties in the nlog.config file. They also have a desire to log at startup when there is no current http request and failure ensures. I am trying to allow logging to work in this case, and also highlight what exactly the issue is, so that this custom logging code can be made resilient or otherwise fixed.
It's odd that something about either exceptions or layout rendering seems to work differently on .Net core.

Hi! Thanks for reporting this feature/bug/question!
Please keep / fill in the relevant info from this template so that we can help you as best as possible.
Type (choose one):

Bug

NLog version:  4.4.5 / 5.0.0-beta06
Platform:  .Net 4.5 /  .NET Core

Hi, did you checked the internal log for errors?

Can you get these internal logs from a build on travis, or do I need a linux machine to test on?
It is a MemoryTarget in the test, yes.

CI logs are fine :)

I will investigate how to get travis to keep this information.

I think <nlog internalLogToConsole="true" ...> should be enough?

If using xUnit2 then you will have fun trying to write to the console. You can look at the changes made in NLogTestBase.cs for how to activate the Xunit.Abstractions.ITestOutputHelper and then pipe the trace-output to this output-helper.
Then one can just enable the InternalLogger.LogToTrace = true

Another option is to write to a file. Dunno if Travis has artifacts like appveyor

We're using Nunit 3.6.1 and the NUnitLite runner.

Ok, after getting the internal logs going, it turns out that exception.MustBeRethrown() is true in regular .Net and false in .Net core.
https://github.com/NLog/NLog/blob/master/src/NLog/LayoutRenderers/LayoutRenderer.cs#L175
I can set LogManager.ThrowExceptions = true in the test code and the test pass in .Net core, butit's there in the config.  I think that this means that the nlog.config is getting read in regular .Net, but not in .Net core.

think that this means that the nlog.config is getting read in regular .Net, but not in .Net core.

That's possible as ${basedir} wont work yet and a lot has been changed regarding the "root" dir. Could you share your config and C# NLog init code?
It this an asp.net core or console application?

Do you need some help on this or can we close it?

We're good; thanks for the help. I look forward to trying 5.0.0-beta07

OK, that one went live yesterday :)


indexed repeat with incorrect number of parameters

Description
An issue in which indexed-repeat() is used without the correct number of parameters (i.e. odd numbers >= 3) is not caught and does not produce an error message.
Also filed at ODK Validate: https://github.com/opendatakit/validate/issues/60

I think this has been addressed with ODK Validate, the correct errors are being returned.
ODK Validate Errors:
>> Something broke the parser. See above for a hint.
Error evaluating field 'sname_1': The problem was located in calculate expression for ${sname_1}
XPath evaluation: cannot handle function 'indexed-repeat' requires 3, 5, 7, 9 or 11 arguments. Only 4 provided.
Caused by: org.javarosa.xpath.XPathUnhandledException: The problem was located in calculate expression for ${sname_1}
XPath evaluation: cannot handle function 'indexed-repeat' requires 3, 5, 7, 9 or 11 arguments. Only 4 provided.
        ... 11 more

Result: Invalid

@joeflack4 please reopen if I missed anything in my assessment.