Select2 initializer calls other select initializers too early

If you load the JS file synchronously at the end of your body, and have a custom autocomplete-light-function, this initializer might not be called if you also include the Select2 initializer. This is caused by the fix for #820. The extra fix in #864 does not prevent this issue.
My scenario:
<html>
  <body>
    <select data-autocomplete-light-function="my-custom-initializer" data-autocomplete-light-url="/autocomplete/data" id="id_myfield" name="myfield" data-html required>
      <option value="" selected="selected">---------</option>
    </select>

    <script type="text/javascript" src="/static/autocomplete_light/jquery.init.js"></script>
    <script type="text/javascript" src="/static/autocomplete_light/autocomplete.init.js"></script>
    <script type="text/javascript" src="/static/autocomplete_light/vendor/select2/dist/js/select2.full.js"></script>
    <script type="text/javascript" src="/static/autocomplete_light/select2.js"></script>
    <script type="text/javascript" src="/static/my-app/js/my-autocomplete.js"></script>
  </body>
</html>

By the time the code in select2.js gets executed, my-autocomplete.js has not loaded yet. So when it executes this block of code:
$('[data-autocomplete-light-function]:not([id*="__prefix__"])').each(function() {
    window.__dal__initialize(this);
});

It will find the select box (because the JS is loaded at the end), and it will try to initialize it. The initialize (or __dal__initialize) method will mark it as initialized, even if the correct autocomplete-light-function to execute does not exist yet. So calling this block again will not work. The fix from #864 also does not work in this case, because __dal__initListenerIsSet is set by the select2.js script, but that is not the initializer I need!
Possible fix in select2.js
Either:

Wrap the code in $(document).ready()
Do not just query for [data-autocomplete-light-function], but for [data-autocomplete-light-function=select2]

I haven't tried this out yet (did not have time to look into running the test suite). It might be even better to just rewrite the initialization so the actual method that does the initialization can mark the element as initialized. I'm not sure what the cleanest way to do this is.
How I got here
I got into this situation because I have a custom widget that extends ModelSelect2 (mainly custom JS), and it only added to the existing Media.
Workarounds
My current workaround is to copy the whole Media block of the Select2WidgetMixin superclass and add extend = False. Another workaround would be to include the JS at the top of the page (then the block of code will not have an effect because the jQuery selector will not match anything yet).

I had this issue yesterday and changing it to use [data-autocomplete-light-function=select2] did the trick for me.

I had the same issue, and while I agree with the above solution, I wasn't comfortable overwriting the JS files from the package (because it will break on the next update). So until this is fixed, I've overwritten the name of the data attribute on the widget.
class MyModelSelect2(ModelSelect2):
    autocomplete_function = 'mySelect2'

    def build_attrs(self, *args, **kwargs):
        attrs = super().build_attrs(*args, **kwargs)

        fn_attr_name = 'data-autocomplete-light-function'
        if fn_attr_name in attrs:
            attrs[f'{fn_attr_name}-override'] = attrs[fn_attr_name]
            del attrs[fn_attr_name]

        return attrs

I also had to copy this into my custom script and update all the selectors of my custom initialisation function to target data-autocomplete-light-function-override instead of data-autocomplete-light-function.
Not as straight forward but not touching the source files.


Unexpected input 'publish-report' warning during post job cleanup

The used gdUnit4-action version
gdUnit4-action@v1
The used Godot version
v4.3.dev6
Operating System
ubuntu:latest
Describe the bug
According to the README, publish-report is a valid option, and needs to be set to false for forked pull requests. The run still completes successfully.
Relevant yaml snippet:
      # Run the tests in res://test/unit & generate test-results.xml report
      # with a unique name that includes the run ID & branch name to clearly
      # identify & distinguish between multiple test report files.
      - name: Setup GdUnit4 and run tests
        uses: MikeSchulze/gdUnit4-action@v1
        with:
          godot-version: '4.3'
          godot-status: 'dev6'
          paths: 'res://test/unit'
          publish-report: ${{ env.PUBLISH_REPORT }}
          # If we're on a fork, the report will be uploaded as an artifact named "artifact_<report_name>"
          report-name: 'test-results-${{ github.run_id }}-${{ env.SANITIZED_REF_NAME }}.xml'

Relevant log snippet:
Warning: Unexpected input(s) 'publish-report', valid inputs are ['godot-version', 'godot-status', 'godot-net', 'version', 'paths', 'arguments', 'timeout', 'retries', 'report-name']
Post job cleanup.
Post job cleanup.
Cache hit occurred on the primary key Linux-Godot_v4.3-dev6, not saving cache.

You need to update the action to v1.1.1

@MikeSchulze Thanks the reply! I thought that @v1 meant “use the latest version possible having major version 1”. Is that not the case then?

@MikeSchulze Thanks the reply! I thought that @v1 meant “use the latest version possible having major version 1”. Is that not the case then?

From the official NuGet documentation I have the same understanding, but the truth is that it does not work, you need to specify the full version uses<EMAIL_ADDRESS>


Don't clobber original library symbols

It appears that we can get a fun circle dependency on a shared object on
some system configurations causing issues with our 'fake' function
pointer names. This can lead to a crash.
The new wrapper generator renames all the symbols so this can't happen
anymore. See https://github.com/hpvb/dynload-wrapper/commit/704135e
This closes #46140

Thanks!


Detected Trojan:AndroidOS/ZkarletFlash

Firefox and Windows Security identify EmperorLauncher.v1.0 as containing a trojan, Trojan:AndroidOS/ZkarletFlash,
Alert level: Severe
Category: Trojan
Details: This program is dangerous and executes commands from an attacker.
Is this a false positive due to application hooks required to make Emperor compatible with Windows 11? Is it possible to fix this and recompile so it doesn't come up as a trojan? Thank you!

Yes, it's a false positive, no it's not possible to fix it unfortunately,  see #1


Cache dependencies in CI to speed up build times.

I am not sure how effective this is due mixing stable and nightly within a workflow and whether it was tried before, but I have had good experiences using the rust-cache action myself.

An unscientific experiment pushing the same commit with a different timestamp and hence hash leads to the following numbers:

job
cold
warm

coverage
22.5m
12m

test
13.5m
14m

So a significant win for the coverage job, but no improvement for the test job.

Codecov Report

Merging #1469 (be2f5c1) into main (8b3a6f6) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1469      +/-   ##
==========================================
- Coverage   94.09%   94.09%   -0.01%
==========================================
  Files         238      238
  Lines       44552    44552
==========================================
- Hits        41923    41921       -2
- Misses       2629     2631       +2

Impacted Files
Coverage Δ

bitpacker/src/bitpacker.rs
96.03% <0.00%> (-1.00%)
:arrow_down:

src/fastfield/reader.rs
87.73% <0.00%> (-0.62%)
:arrow_down:

src/store/index/mod.rs
97.83% <0.00%> (-0.55%)
:arrow_down:

src/postings/stacker/expull.rs
99.05% <0.00%> (+0.47%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adamreichold Great win! Thank you!


Updates to 1.14.2

Updated to 1.14

We can close this PR since https://github.com/dapr/test-infra/pull/235 was merged


Speech MediumEditor does not work in contentions

Actual rich text editing is functional but medium bar never appears

Done in latest speechEditorFix


Unable to communicate with GitHub Enterprise Server from Azure DevOps

I have updated the firewall rules for my organization to permit inbound connections from the 'Central US' IP address; my Azure DevOps organization is located in Central US.
However, when I attempt to verify a connection, I am unable to do so. I get the error as below.
Failed to query service connection API: 'https://github._<hidden>_.com/api/v3'. Error Message: 'A task was canceled.'
Interestingly, a Firefox debugger indicates that the connection is originating from <IP_ADDRESS> which is not in the list of IPs that MSFT has listed as source IPs for Central US region. (I did find a reference to this IP range in a different Azure DevOps doc but that seemed to indicate a range of IPs for being able to access Azure DevOps across a firewall; i.e., outbound from corporate network to Azure DevOps).
Is the list of IPs provided for Central US correct?
Should I expect that if my ADO organization is in Central US and the list of IPs are permitted to access my GitHub Enterprise, then a Service Connection verification should work? Or am I missing something here?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b14972b7-883c-37c8-96f9-114327f15e05
Version Independent ID: 00baf3e0-f225-dc97-a15d-f9d97dac28d2
Content: Build code from GitHub Enterprise Server - Azure Pipelines
Content Source: docs/pipelines/repos/github-enterprise.md
Product: devops
Technology: devops-cicd-repos
GitHub Login: @steved0x
Microsoft Alias: sdanie

@indranil-chakraborty-thd Thank you for the question and apologies for the issue.
Please refer to Allowed address lists for a list of required IPs.
The IP address <IP_ADDRESS> referenced above can be found listed under the express route connections.

Thanks for your question. It looks like you're working through an issue with your scenario or implementation, rather than an issue with the documentation. Here are a couple of options where you might consider asking your question:

Azure DevOps Support Bot
Azure DevOps Developer Community.

I have updated the docs with the new IP address ranges. Also, I clarified that you should include ExpressRoute ranges as well in case you rely on that.


Preventing right click activating drag.

Hey Martin,
Right clicking activates onDragStart, and the corresponding DragEventHandler doesn't seem like we can cancel the actual click event on our end. Is this something we'd intercept and preventDefault() with a custom Sensor or something?
To replicate, on the examples page, right clicking on a draggable object, then clearing the context menu ends up locking the draggable to the cursor until you either left or right click again.

Hey. This sounds like a generally useful thing that we should add into the default sensor (ignore right clicks). Feel free to submit a PR. Alternatively I'll add this in future.
In the meantime, yes, you could create your own sensor implementation that ignores right clicks.

In latest version I don't believe the behaviour happens anymore (due to improvements in the sensor logic), though there is no special handling for right clicks. Closing, but feel free to re-open if I am mistaken.

Yep, still happens. Just revisited this great package to try and implement something that didn't work beforehand, now with .7+ it works... but the right click issue still persists.
To replicate, select "Basic drag & drop" from the main examples area on the website, right click on the "Draggable" object, dismiss the context menu, and you'll find the object is stuck to the cursor.

@timothyallan I can't reproduce that 🤔 What OS and browser are you using? How are you dismissing the context menu?

Wellllll, that is interesting. I'm on Mac, tried Chrome/FF/Safari and all in private browsing to make sure I wasn't getting cached data.
https://user-images.githubusercontent.com/1995135/199383981-20a47a92-54f8-49e6-b6a2-ee9464408eb4.mp4

Hmm. I'm testing on Windows so that's a difference.
I'm happy to implement a check for right mouse button in the activation logic, but I'd like to understand what is happening here more first:
Has the click completed for you when the context menu shows? Or are you still pressing the mouse button down at that point?

It’s very odd that it happens with the OS being the difference! I’m simply single right clicking and releasing, then left clicking somewhere other than the context menu. Nothing is being held down.
Does it in my solid app as well, which is what got me to try it on your site again just for kicks.

That is odd indeed - logically the drag should not become stuck because on pointerup the listeners are removed and all drags stopped. The only way that could occur is if something else is intercepting and cancelling the pointerup event - I wonder if the contextmenu behaviour on mac is doing that 🤔
If you are able to build the solid-dnd library locally you could try adding some debugging to https://github.com/thisbeyond/solid-dnd/blob/main/src/create-pointer-sensor.ts to see what's going on.

Console.log all the sensor functions :)

Right click on a draggable object
Browser context menu pops up
DnD attach fires with a pointerEvent button:2
onActivate fires state.active.sensor:null isActiveSensor():false
moving mouse while context menu is up doesn't fire any events.
Single left click anywhere in the browser to dismiss the context menu, object is now locked to cursor, and moving fires a bunch of onPointerMoves.
Single left click again fires onPointerUp isActiveSensor():true with button:0
detach fires

Thanks! That does look like the contextmenu is intercepting the onpointerup we rely on.
I've released 0.7.3 now that should fix it - please give it a go.

Like a boss. No more sticky div's :)
That's a new one for me too. I usually just return right away on right clicks in my app so I never ran into it!


Failed to save add-on configuration, Invalid list for option 'EnforceDeviceTypes

I'm trying to configure the add-on but it always show the following mesage:
Failed to save add-on configuration, Invalid list for option 'EnforceDeviceTypes' in SwitchBot-Mqtt (cafb8c58_switchbot_mqtt). Got {'Mqtt': {'AutoConfig': True, 'Host': '', 'Port': 1883, 'Id': '', 'Pw': '', 'Tls': False}, 'SwitchBot': {'ApiKey': 'redacted', 'ApiSecret': 'redacted'}, 'EnforceDeviceTypes': 'Hub',
I've tried using default value of null, NULL and also tried using "hub" and "hub 2" but still the message is the same.
Am i missing something?

Please try entering it on the YAML input screen in the following format.
EnforceDeviceTypes: []

Essentially, it is a forced override when there is no DeviceType response in the API, such as Curtain 3.
Reference: https://github.com/hsakoh/switchbot-mqtt/issues/3#issuecomment-1712718641

Thanks for the quick response!!!
I was able to save the configuration after changing that line and i'm able to discover the devices now.
Thanks!!


Remove Cargo.lock and update bindgen to 0.68.1

Fixes #29

Thanks for the PR, but crates.io requires that crates have a Cargo.lock. I've gone ahead and merged #28. That gets us to bindgen 0.66.1 which is slightly older, but according to the comments on the rust-u2f issue this version should also resolve the issue you're seeing.


Message edit history breaks when message contain image

Message edit history shows weird behavior as shown in image.

To reproduce bug:

Compose message with at least one image
Edit the message by adding some content after image url

NOTE: I have not made any changes to image URL and it only shows if text is added after image URL. If you add text before image URL it works fine.
You can check this message edit history, for detail.
I am using Zulip desktop application.

@YJDave if you r not working on this, I would like to work on this.

@shreyanshdwivedi No, I am not working you can start working on this issue. :+1:

@zulipbot claim

@zulipbot abandon

@zulipbot claim

@zulipbot claim

After some digging I have found that the problem lies in zerver/lib/html_diff.py - highlight_html_differences. It uses function htmldiff from lxml.html.diff, which sometimes marks too many changes (those that never happened). I can't come up with some easy way to help htmldiff make proper markings, so the question is, should I try to make better function to compare original and edited message?
Here are some examples - edits use uppercase letters

And with images

Some of the output directly from htmldiff (added some 4's and then some 5's)

Hmm, I'm not sure.  I don't think we want to be in the business of writing and maintaining an HTML diff tool -- that seems like something better done by a third-party library.  We could look for whether there's a better Python library than the LXML one, or consider reporting an issue upstream.

Hmm, I'm not sure.  I don't think we want to be in the business of writing and maintaining an HTML diff tool -- that seems like something better done by a third-party library.  We could look for whether there's a better Python library than the LXML one, or consider reporting an issue upstream.

@zulipbot abandon


[WIP] Multi user invite link

[X] Implement backend
[x] Implement basic management command
[x] Tests for backend and management command

To test

Make sure to enable email invitations by opening http://localhost:9991/#organization/organization-permissions.

Then run

./manage.py migrate
./manage.py generate_invite_links --realm zulip

Now use the generated url to sign up for new accounts.

@rishig @showell @adnrs96 I can work on the tests and remaining stuff if this approach is fine with you guys :). I think the frontend to generate the link can be a separate PR of it's own.

Hi @hackerkid I haven't really read out the code into details and understood the changes, just tried repeating the steps mentioned.
I get this
(zulip-venv)vagrant@vagrant-base-trusty-amd64:/srv/zulip$ ./manage.py generate_invite_links --realm zulip
Traceback (most recent call last):
  File "./manage.py", line 29, in <module>
    execute_from_command_line(sys.argv)
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 363, in execute_from_command_line
    utility.execute()
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 355, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/core/management/base.py", line 283, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/core/management/base.py", line 330, in execute
    output = self.handle(*args, **options)
  File "/srv/zulip/zerver/management/commands/generate_invite_links.py", line 71, in handle
    url = generate_multiple_user_invite_link(realm)
  File "/srv/zulip/confirmation/models.py", line 51, in generate_multiple_user_invite_link
    InviteKey.objects.create(invite_key=key, realm=realm, date_created=timezone_now())
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/db/models/manager.py", line 85, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/db/models/query.py", line 394, in create
    obj.save(force_insert=True, using=self.db)
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/db/models/base.py", line 806, in save
    force_update=force_update, update_fields=update_fields)
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/db/models/base.py", line 836, in save_base
    updated = self._save_table(raw, cls, force_insert, force_update, using, update_fields)
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/db/models/base.py", line 922, in _save_table
    result = self._do_insert(cls._base_manager, using, fields, update_pk, raw)
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/db/models/base.py", line 961, in _do_insert
    using=using, raw=raw)
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/db/models/manager.py", line 85, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/db/models/query.py", line 1063, in _insert
    return query.get_compiler(using=using).execute_sql(return_id)
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 1099, in execute_sql
    cursor.execute(sql, params)
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/db/backends/utils.py", line 80, in execute
    return super(CursorDebugWrapper, self).execute(sql, params)
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/db/backends/utils.py", line 65, in execute
    return self.cursor.execute(sql, params)
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/db/utils.py", line 94, in __exit__
    six.reraise(dj_exc_type, dj_exc_value, traceback)
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/db/backends/utils.py", line 65, in execute
    return self.cursor.execute(sql, params)
  File "/srv/zulip/zerver/lib/db.py", line 32, in execute
    return wrapper_execute(self, super(TimeTrackingCursor, self).execute, query, vars)
  File "/srv/zulip/zerver/lib/db.py", line 19, in wrapper_execute
    return action(sql, params)
django.db.utils.ProgrammingError: relation "confirmation_invitekey" does not exist
LINE 1: INSERT INTO "confirmation_invitekey" ("invite_key", "date_cr...
                    ^

Should I be doing something else as well?

hmm, sorry I guess I need to run migrations.

@adnrs96 I will update the comment to include run migrations. Thanks for reporting :)

For testing
 ./manage.py generate_multi_user_invite_link --realm zulip

 ./manage.py generate_multi_user_invite_link --realm zulip --limit 3

@rishig Thoughts?

Hello @hackerkid, a Zulip maintainer reviewed this pull request over a week ago, but you haven't updated your pull request since. Please take a look at the requested changes and update your pull request accordingly.
Thank you for your valuable contributions to Zulip!

@rishig Updated the PR.
Some of the changes I made in this revision

Changed the model name to MultUseInvite invite.
Added tests as you suggested
Removed the mechanism of checking the number of times the link has used so far from the registration view.
Implemented mechanism to subscribe users to specified streams.
multisuser_invite replaced with multiuse_invite and similar.

What happens if a stream is deleted in between when the invitation is sent and when they go through the registration process?

We won't show any error or warning in case stream gets deleted. User would get subscribed to one less stream. This is similar to the case of normal user invite.
I have also updated the code :)

oh sorry, I meant pass it as an argument to the accounts_home function, so that we didn't have to store it in the session. E.g. accounts_home(request, multiuse_invite_object).

oh sorry, I meant pass it as an argument to the accounts_home function, so that we don't have to store it in the session. E.g. accounts_home(request, multiuse_invite_object).

I should not have used sessions here in first place. Updated. thanks :)

@rishig Fixed the merge conflicts :)

@rishig I have fixed the issues and merge conflict. :)

cool, this is looking good! I do want to get this into master soon, but it should wait for after the realms_have_subdomains work is merged, since it will simplify this code, and it is likely to create more merge conflicts.
That being said, I think the next part can proceed in parallel, which is adding a checkbox to the invitation form, which says "Allow invitation link to be used multiple times Learn more", where we'll link to the appropriate /help document.

This seems clean enough and has tests, so I merged all but the last commit, after fixing a few minor style issues are renumbering the migration.  There are 2 priority follow-up projects:

I think we should modify the management command to take the list of streams to use as an argument, and then we can merge that, too, which I think will be handy.
I think in many cases, folks will just want the multi-use invite link to use the default streams of the organization, i.e. streams=None, rather than specifying them in advance, since you can update the default streams for the organization with the UI, and you can't update this through the UI.  I think this code doesn't actually support that, and if you try, you'll get streams=[].  We need to fix that.

Once that's done, we should create one of these links and test it on chat.zulip.org.
Since we want to use this feature for the GSoC Mentor Summit (and the email with this link should go in the next few days!), this should be your top priority @hackerkid.

@timabbott Updated the management command.  The code we merged will sign up the users to default streams if no streams were mentioned in the invite.

Merged, thanks @hackerkid!


Multivariable option for the model

Add capability to have more than 1 metric in LoudML Grafana panel.

Wow....

Added a parser to use all fields from InfluxDB query in Grafana panel. And it converts these fields into features in ML model  then. And able to send it to server.
Example model:

{
    "bucket_interval":"10s",
    "default_bucket":"influxdb2",
    "features":[{
        "name":"mean_queryReqDurationNs",
        "measurement":"httpd",
        "field":"queryReqDurationNs",
        "metric":"mean",
        "io":"io",
        "default":"previous",
        "match_all":[]
    },{
        "name":"mean_queryRespBytes",
        "measurement":"httpd",
        "field":"queryRespBytes",
        "metric":"mean",
        "io":"io",
        "default":"previous",
        "match_all":[]
    }],
    "interval":"10s",
    "max_evals":10,
    "name":"_internal_httpd_mean_queryReqDurationNs__time_10s",
    "offset":"10s",
    "span":100,
    "type":"donut"
}

Right now one obstacle is a LoudML server support - "This model type supports one unique feature" error returned.
@regel may you please advice is it any principle issue with support for many features in 1 ML model exists.

Hi @vsergeyev, the multivariate implementation is not available today. I hope it will be in the future.
It’s nice to have Grafana setup and ready for testing even if the multi variable feature is not available yet. Should this be an option to enable in a configuration panel of Grafana?

@regel it works out of the box when you select fields in Query in panel.

One may give it a try with 1.3.0 in docker:
sudo docker run -d \
  -p 3000:3000 \
  --name=grafana \
  -e "GF_INSTALL_PLUGINS=https://github.com/vsergeyev/loudml-grafana-app/raw/master/grafana-loudml-app-1.3.0.zip;grafana-loudml-app" \
  grafana/grafana


Massively Inspiration

@silentrob thought you'd find their node-based approach really interesting:  https://vimeo.com/album/2964700/sort:preset/format:detail

Very cool, thanks for sharing. Closing as this is not an issue, if you want to chat about this, lets talk about it in slack.


Revert incorrect readme changes

Wasn't supposed to change that. oops

I think this change is fine!

I think this change is fine!


cant synchronize correctly with realtime database of firebase

i also ask in stack overflow so im waiting to an answer
here is a link

Fixed - used promise and callbacks to sync the database
see vesion code 1.12 here


AppVeyor - Cache Composer Installation

Some AppVeyor builds fail because of an SSL error while downloading Composer (example). Caching Composer installation should prevent this issue.

I remember when I asked you to cache it ;)
well, maybe it's worth to install it via choco ?

Hehe :)
Composer package available on Chocolatey is very outdated.

Thank you @julienfalque.


Rails 5 support

This hack to hook into layout rendering no longer works in rails 5.

Fixed by 163b090f27f92cbb3a1ab416e555ec548ffc4eb2


[TS] Serialize properties in declaration order

Related Issue
Fixes https://github.com/microsoft/AdaptiveCards/issues/4034
Description
This change serializes properties in the order they are declared in serializable object classes. The most important improvement this change introduces is that the type property is now serialized first, as used to be the case before the move to the PropertyBag model, making JSON payloads easier to read.
How Verified
Verified manually in adaptivecards-designer-app
Microsoft Reviewers: Open in CodeFlow

/azp run


Parse receipts reason in a better way

Motivation
Today when a transaction fails, we do not parse the reason in a proper way, making it very difficult to debug errors.
Receipt output example
[
  {
    "type": "Panic",
    "id": "0x0000000000000000000000000000000000000000000000000000000000000000",
    "reason": "733327132687597568",
    "pc": "12336",
    "is": "10352"
  },
  {
    "type": "ScriptResult",
    "result": "2",
    "gasUsed": "14773"
  }
]

edit: Hex string for the panic here is 0x000000000000000300000000000000000000000000000000000000000000000000000000000000000a2d4d245000000000000000000030300000000000002870
We should parse "reason": "733327132687597568", to the proper enum issue name https://docs.rs/fuel-asm/latest/fuel_asm/enum.PanicReason.html.

Can i take this issue?

Can I take this issue?

I just assigned it to you!

I parsed Panic Receipts from tests where fuel core returns an error and the decoded values do not make sense.
0x0000000000000003
00000000000000000000000000000000000000000000000000000000000000000a2d4d245000000000000000000030300000000000002870

a2d4d245 is the encoded reason, but decoding it doesn't make sense because the values should be between 0-255
Docs
https://github.com/FuelLabs/fuel-specs/blob/8bb43ae61aab69e72275c004792aef34efed1d9b/specs/protocol/abi.md#panic-receipt
https://docs.rs/fuel-asm/latest/fuel_asm/enum.PanicReason.html

I think we are handling the graphql response incorrectly.  I looked at the requests via wireshark and I can see the correct reason


Fix error message for failure to start editor

Before:
Can't start editor: / u s r / b i n / n a n o

After:
Can't start editor: /usr/bin/nano

Thanks! 🎉 👍


Testing & Close

Nice encrypter btw!

Nice encrypter btw!
It worked well in older versions of CPP. I need to fix the code


Combining EDS API with AED API

Problem description
In EDS API GET /application-endpoints (at first glance and because of the name, it might overlap with AED API) and GET /mecplatforms (at first glance it might overlap with SED API or GET /edge-cloud-zones of EAM API).
GET /application-endpoints ESD API vs GET /app-endpoints AED API:
GET /application-endpoints ESD API: Returns a list of optimal Application Endpoints that client devices can connect to. You can search based on Application Profile, Region, Suscriber Density or UEIdentity.
This method is very interesting and covers part of intent 21, which is outside the scope of the MVP proposal, but was considered for the improvement phase.
Expected behavior
GET /app-endpoints AED API: Returns the closest endpoint of the App Instance for an specific UE. Based on UEIdentity and AppID
This functionality can be merged to improve Application Endpoint Discovery capability, allowing endpoint discovery based on App Profile, Region, Subscriber Density, UEIdentity and AppId.

Hi @maheshc01, this is one of the issues that we discussed on the last meeting, as you can see the idea is to reuse the existing yaml(API), and add the funcionality of EDS to AED. Do you think is possible??
I think we can add this new funcionalities in AED adding the new funcionalities to the AED, create a PR and review the code and discuss in this PR about it,doing this we avoid to create a new API.

yes. I believe we can combine EDS in AED. it would increase the scope of AED. will discuss the updated yaml on the call and then create a PR.

have created a new branch(https://github.com/camaraproject/EdgeCloud/tree/Edge-Discovery-Service-API) and created a edge discovery service API yaml combining the discovery API available in AED and EAM. Also added a new discovery API for /regions.
As this consolidated discovery specific API yaml has API related to both edge cloud zone and application end points, i have used a generic name or edge discovery service. We can discuss on the call and get feedback from the team on how we want to handle the naming of the API.


Fix flaky visual studio completion test

Fix flaky visual studio completion test
Microsoft Reviewers: Open in CodeFlow

Thanks for fixing this up @bhsubra!


final.bam convert to fastq file

Hello,
I have a final.bam file, and i want to convert bam file back to the paired raw fastq file. So that i can re map agin.
I try to use samtools fastq, but it can not output paired fq file correctly. Further, i tried software bamtofastq, and it is useful to convert bam to fastq file in 10X scRNA-seq data. but it is fail to convert bam file generated by DNBelab_C platform.
how can i do that in DNBelab_C platform.  looking forward to your reply.
thank you!

Sorry, we don't have that feature yet. We discard reads that do not align and their quality scores when generating the BAM file. Fully restoring the raw reads is currently not feasible. @Gordonlu66

https://github.com/shiquan/PISA


Initialize Gremlin as a stand alone repo

I read your post on Medium and it was very impressive. Do you have any plans to implement gremlin as a stand alone go lib? Seems like it has the potential to make an impact in the Go community and including Gremlin independent from Octopus would maximize it's exposure, give you a chance to better articulate usage, benchmarks, and other documentation. Thanks!

I agree with @ddemoss222 . I read your post as well.

+1 same


Fix iptables update

If updates fail, the version should not be updated. This PR fixes that.

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "ffa602cd65ff12f1976ece68bd349f3678f537d4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "fa7f9a7a8067179d7a2b2a34a73f1702d366a209"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "ffa602cd65ff12f1976ece68bd349f3678f537d4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "370ea0576d4be9fa09455c1b90e9cf969d34bfd6"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "ffa602cd65ff12f1976ece68bd349f3678f537d4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "1134638eba2e19502eef88fb7584ef293107be02"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "ffa602cd65ff12f1976ece68bd349f3678f537d4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "32665f630996d59bc0671f59af6fa147d3fe1f77"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "ffa602cd65ff12f1976ece68bd349f3678f537d4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "ce4424cd92df8fc225c035672d8d5694950feda8"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "ffa602cd65ff12f1976ece68bd349f3678f537d4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "ce4424cd92df8fc225c035672d8d5694950feda8"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "9a1ba5c9828ee2fecd2c69516542684b2d8111bf"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "ce4424cd92df8fc225c035672d8d5694950feda8"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "9a1ba5c9828ee2fecd2c69516542684b2d8111bf"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "ce4424cd92df8fc225c035672d8d5694950feda8"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "9a1ba5c9828ee2fecd2c69516542684b2d8111bf"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "ce4424cd92df8fc225c035672d8d5694950feda8"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "9a1ba5c9828ee2fecd2c69516542684b2d8111bf"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "ce4424cd92df8fc225c035672d8d5694950feda8"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "522f96d5c6b724e595477e9aaf7dda14870c9c8d"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "ce4424cd92df8fc225c035672d8d5694950feda8"
  }
]


Party name support overflow & fix constituencySeats graph length

Resolve #85 #84

Thank you krubbbbbb :D


Support .m2ts filetypes

lookup('test.m2ts) returns false
Please add support to this extension as well.
Wiki Link: https://en.wikipedia.org/wiki/.m2ts

https://github.com/jshttp/mime-types#adding-types


Ubuntu 18.04 LTS - lack of bashdb

Seems that bashdb is missing from 18.04 repo.
Best way to workaround is to compile newest bashdb 4.4-0.94.
wget https://netix.dl.sourceforge.net/project/bashdb/bashdb/4.4-0.94/bashdb-4.4-0.94.tar.gz
tar -xvfz bashdb-*.tar.gz
cd bashdb-*
./configure
make
sudo make install

Heads up for build dependencies, since the provided ./configure does not list them as missing.
apt-get install texi2html texinfo

Testing package that would not require bashdb installation:
bash-debug-0.2.3.vsix.zip

nice!


Group Adder: computations created outside a createRoot or render will never be disposed

Describe the bug
There is a warning when adding new groups to the list stating "computations created outside a createRoot or render will never be disposed"
To Reproduce

Go to the group adder
Add a second group
warning

Expected behavior
There should not be a warning
Screenshots

Desktop (please complete the following information):

OS: Arch
Browser: Firefox

Rather than rendering the component and adding that to the list, just have a list of groups on its own. In the for component, use the list and render the UI there


Documentation example for templates suggestion function

Hello,
Is it possible to add a very simple example usage of the templates suggestion with custom html being returned please?

suggestion is a function that receives one argument, a suggestion to be displayed. It is used when rendering suggestions, and should return a string, which can contain HTML. warning Caution: because this function allows you to output arbitrary HTML, you should make sure it's trusted, and accessible.

Am I right in understanding that this could, for example, highlight the matching letters as bold text?

I had a similar thought - displaying the matching text in bold. It doesn't seem like this is possible though because the function isn't passed a query parameter like the source function is. Here's an example suggestion function from my code:
suggestion: d => {
	let text = `${d.HScode} - ${d.description}`
	if(d.hasEstimatedGain){ return text }
	return `<span style="color:gray;">${text}</span>`
}

We have an existing example for "custom results" in https://alphagov.github.io/accessible-autocomplete/examples/ but we don't have a good code example. We might want to include a realistic code example to show users how it can be used.


Spring Security 3.1.1 does not work with Grails 3.1.9

Attempted to use the Spring Security Core 3.1.1 plugin with Grails 3.1.9. Always get "Sorry, we were not able to find a user with that username and password." This is following the tutorial provided in the plugin documentation.

There's a small sample app in the source repo that I keep fairly current. I updated it to Grails 3.1.9 and everything worked fine. Take a look at https://github.com/grails-plugins/grails-spring-security-core/tree/master/secured and hopefully it can shed some light on what's misconfigured in your app. If you are still having problems I can take a look at your app. Can you push the code to a a GitHub repo?

Interesting. The plugin fails with a fresh app created with 'grails create-app'.
I've created a small sample application.
https://github.com/jasenj1/grails_s2_test.git


Look at using build_runner to generate Dart files

From @kevmoo on February 1, 2018 15:23
Could be useful to align with other source generation concepts in the platform
Copied from original issue: dart-lang/grpc-dart#54

Are there any plans for an official version of this to exist, it would be really helpful to have! :blush:

No current plans unfortunately. Currently we are busy looking into other things. It really would make the world much nicer though.

Are you open for creating PR to start on this builder function?
Should it be separate package for dev_dependencies?

I think it would fit more nicely as a separate package

https://github.com/pikaju/dart-protoc-builder looks like it might to part of this (as well as auto-installing protoc).


[SPARK-17920][SPARK-19580][SPARK-19878][SQL] Support writing to Hive table which uses Avro schema url 'avro.schema.url'

What changes were proposed in this pull request?
SPARK-19580 Support for avro.schema.url while writing to hive table
SPARK-19878 Add hive configuration when initialize hive serde in InsertIntoHiveTable.scala
SPARK-17920 HiveWriterContainer passes null configuration to serde.initialize, causing NullPointerException in AvroSerde when using avro.schema.url
Support writing to Hive table which uses Avro schema url 'avro.schema.url'
For ex:
create external table avro_in (a string) stored as avro location '/avro-in/' tblproperties ('avro.schema.url'='/avro-schema/avro.avsc');
create external table avro_out (a string) stored as avro location '/avro-out/' tblproperties ('avro.schema.url'='/avro-schema/avro.avsc');
insert overwrite table avro_out select * from avro_in;  // fails with java.lang.NullPointerException
WARN AvroSerDe: Encountered exception determining schema. Returning signal schema to indicate problem
java.lang.NullPointerException
at org.apache.hadoop.fs.FileSystem.getDefaultUri(FileSystem.java:182)
at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:174)
Changes proposed in this fix
Currently 'null' value is passed to serializer, which causes NPE during insert operation, instead pass Hadoop configuration object
How was this patch tested?
Added new test case in VersionsSuite

Test build #83984 has started for PR 19779 at commit 034b246.

Test build #83984 has finished for PR 19779 at commit 034b246.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83984/
Test FAILed.

Test build #83985 has started for PR 19779 at commit a59bd09.

Test build #83985 has finished for PR 19779 at commit a59bd09.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83985/
Test PASSed.

Test build #84011 has started for PR 19779 at commit 9beb53f.

Test build #84011 has finished for PR 19779 at commit 9beb53f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84011/
Test PASSed.

Hi, @vinodkc .
Thank you for taking a look at these issue. Since this PR contains multiple issues, could you add the followings in the PR description for reviewer and commit log?

SPARK-19580 Support for avro.schema.url while writing to hive table
SPARK-19878 Add hive configuration when initialize hive serde in InsertIntoHiveTable.scala
SPARK-17920 HiveWriterContainer passes null configuration to serde.initialize, causing NullPointerException in AvroSerde when using avro.schema.url

Ping @cloud-fan and @gatorsmile .

The fix looks good to me. You can address the comments left by @dongjoon-hyun

Test build #84065 has started for PR 19779 at commit f92f44c.

Test build #84065 has finished for PR 19779 at commit f92f44c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84065/
Test PASSed.

Merged build finished. Test PASSed.

Test build #84069 has started for PR 19779 at commit d09211f.

Test build #84071 has started for PR 19779 at commit b7d7a3c.

Test build #84069 has finished for PR 19779 at commit d09211f.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84069/
Test FAILed.

Merged build finished. Test FAILed.

Test build #84076 has started for PR 19779 at commit 68ee79d.

Test build #84071 has finished for PR 19779 at commit b7d7a3c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84071/
Test PASSed.

Merged build finished. Test PASSed.

Test build #84081 has started for PR 19779 at commit a2560b3.

Test build #84076 has finished for PR 19779 at commit 68ee79d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84076/
Test PASSed.

Test build #84081 has finished for PR 19779 at commit a2560b3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84081/
Test PASSed.

Test build #84090 has started for PR 19779 at commit 083e1b3.

Test build #84090 has finished for PR 19779 at commit 083e1b3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84090/
Test PASSed.

Test build #84092 has started for PR 19779 at commit 51999d0.

LGTM

cc @felixcheung This sounds critical for Spark 2.2 too.

Test build #84094 has started for PR 19779 at commit e3651ef.

Test build #84092 has finished for PR 19779 at commit 51999d0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84092/
Test PASSed.

Thanks! Merged to master.
@vinodkc Could you submit a separate PR for backporting it to 2.2?

@gatorsmile , @cloud-fan and @dongjoon-hyun
Thanks for the review comments and guidence
Sure, I'll submit a separate PR for backporting it to 2.2

Test build #84094 has finished for PR 19779 at commit e3651ef.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84094/
Test PASSed.

Merged build finished. Test PASSed.


MPS MPO multiplication issue

Consider, for instance,  ψ = randn(MPS{Float64}, 4, 5, 2) and W = randn(MPO{Float64}, 4, 5, 2). Now compare,
ψ = W * ψ and ψ *= W. Obviously, both should produce the same result. However, the latter does not work at all - could we fix that?

This is expected. ψ *=  W is in fact a shorthand for ψ = ψ * W. As this operation is ill defined it is not supported.

Well, ψ = ψ * W is actually well-defined but not defined (or rather defined by convention the other way around) in our repo. Can we make ψ *= W a shorthand for ψ = W * ψ?


Git commit hook should only verify what is staged for commit

If I have changes unrelated to the commit that don't pass the static validation of the pre-commit hook, this hook still prevents me from commiting the changes.
It's too wide and should only apply to whatever is being commited.

@p16 @paolochiodi @mihaidma how do you feel about this ? Should I go ahead and make the change ?

I would keep the hook against all repo on the idea that sooner or later we should fix the issues that are outstanding. You can always use the --no-verify flag to skip the commit check.
Did you encounter any special issues? Currently the hook checks seem to pass.

@nherment I thinks this would be useful for two reasons:
1- do not test local changes (like in your case)
2- make sure that all intended changes are actually staged (i.e. it happens to me from time to time to fix an issue found by the pre-commit only to forget to re-add the file before committing)
So... yes, please go ahead.

@paolochiodi this won't cover # 2 as the file on the file system is always the latest.
I'm sure somehow I could get to pass the files as git sees them so I'll have a look. The 5 minutes changes would only cover case # 1.

@nherment I think case 1 could be actually harder. A git stash...git stash pop may be enough to cover point 2


Page URL
https://dart.dev/tools/linter-rules/depend_on_referenced_packages.html
Page source
https://github.com/dart-lang/site-www/tree/main/src/content/tools/linter-rules/individual-rules.md
Describe the problem
Title: Lint Rule depend_on_referenced_packages Triggers Incorrectly in Multi-Module Flutter Project
Description:
I am encountering an issue with the depend_on_referenced_packages lint rule in a multi-module Flutter project. The linter is flagging imports of packages as not being declared dependencies, despite them being correctly specified in the respective module's pubspec.yaml file.
Steps to Reproduce:

Create a multi-module Flutter project with at least two modules.
Add dependencies any dependencies for example webview_flutter and webview_flutter_android only in one of the module's pubspec.yaml files.
Import these dependencies in a Dart file within that module.
Observe the depend_on_referenced_packages lint error.

Example is on the screenshot 1.
Expected Behavior:
The linter should recognize the dependencies specified in the module's pubspec.yaml file and should not flag imports of these packages.
Actual Behavior:
The linter flags the imports with the error:
The imported package 'webview_flutter' isn't a dependency of the importing package.
The imported package 'webview_flutter_android' isn't a dependency of the importing package.

However, when these dependencies are added to the main pubspec.yaml file, the lint warnings disappear.
Screenshots:
Screenshot 1: Module's pubspec.yaml and imports causing lint error:

Screenshot 2: Main pubspec.yaml resolving the lint error when dependencies are added:

Additional Information:

Flutter Version: Channel stable, 3.19.6,
Dart Version:  3.3.4 (stable)
IDE: VS Code (version 1.77.3)
Operating System: MacOS 13.3.1

I have tried clearing the cache, restarting the IDE, and running flutter clean followed by flutter pub get, but the issue persists.
Workaround:
Adding the dependencies to the main pubspec.yaml resolves the lint error, but this should not be necessary if the module's pubspec.yaml is correctly configured.
Request:
Please investigate this issue and provide guidance on how to correctly configure dependencies in a multi-module Flutter project without encountering this lint error.
Thank you!
Contact Information:

Name: Pavel Kriuchkov
Email<EMAIL_ADDRESS>GitHub: https://github.com/pvlKryu
LinkedIn: https://www.linkedin.com/in/pavel-kriuchkov01/

Make sure to replace the placeholders with your actual Flutter, Dart, IDE, and OS versions, as well as the correct paths to your screenshots. This will provide the Dart team with all the necessary information to investigate the issue.
Expected fix
No response
Additional context
No response
I would like to fix this problem.

[ ] I will try and fix this problem on dart.dev.

@pq does this issue belong in dart-lang/linter?


Trip_report_n

Multi-parser trip-report use-case. Tested in cosim with 1,2,3, and 4 parsers.

Tested with bitstream builds containing 2 and 3 parsers.


Returning keyword causes issue while using AWS Redshift DB

Related Issues: #IssueNumber if necessary

Introduction
I am using "bookshelf": "^1.0.0" along with "knex": "^0.19.4" and  "pg": "^7.12.1" and connecting to AWS Redshift database,  It fails with error for INSERT/UPDATE queries like this - error: insert into "job" ("company_id", "id", "title") values ($1, $2, $3) returning * - syntax error at or near "returning"
Issue Description
I am using "bookshelf": "^1.0.0" along with "knex": "^0.19.4" and  "pg": "^7.12.1" as suggested here [https://bookshelfjs.org/index.html#installation]  Actually I am trying to connect to AWS Redshift database, with this combination I can query data from tables and fetch the result successfully. However, problem occurs when I try to INSERT or UPDATE a record. The problem is - Bookshelf or Knex - adds "returning" keyword at the end of insert and update queries. AWS Redshift does not support "returning" keyword and as a result INSERT/UPDATE fails with error like this - error: insert into "jobs" ("company_id", "id", "title") values ($1, $2, $3) returning * - syntax error at or near "returning"
When I tried the same code with Postgresql DB it worked (as PostGresql supports returning keyword)
Sample code that I am trying to make work
var knex = require('knex')({
    client: 'pg',
    adapter: 'pg',
    connection: {
        host: 'my host url',
        user: 'my user name',
        password: 'my password',
        database: 'my database name',
        port: port of redshift DB
    }
  });

const bookshelf = require('bookshelf')(knex)
const Job = bookshelf.model('Job', {
    tableName: 'jobs',
})
new Job({id: '1234', company_id:'1234', title: 'test5'})
.save(null, {method: 'insert'})
.then((model) => {
  console.log(model)
}).catch(err=>{
    console.log('error ' + err)
}).finally(()=>{
    bookshelf.knex.destroy()
})

Expected behaviour
What I expect is - it would be great if I can configure easily if I want to use returning keyword or skip it.
Actual behaviour
I get the error as mentioned above

I took the liberty of editing sample code in OP (added correct markdown tags)

If the database used is pg it should support RETURNING. Is this some kind of mod that Amazon did to not support it?

According to https://docs.aws.amazon.com/redshift/latest/dg/r_INSERT_30.html it doesn't. To be fair, it only claims to support the protocol, not all its features. However, I've never used Redshift so I might be missing something here.

We could work around this by aliasing redshift to pg in case it's used as 'adapter'. That's the easiest way to support this use case that I can think of.

Thank you Ricardo and Martin,
I hope the problem I explained above is clear to both of you. Yes AWS Redshift does not support returning keyword. I forked the repository and in my fork i changed file lib/sync.js file as follows
current function has pg in the array
function supportsReturning(client = {}) {
if (!client.config || !client.config.client) return false;
return ['postgresql', 'postgres', 'pg', 'oracle', 'mssql'].includes(client.config.client);
}
just removed pg from the array.
function supportsReturning(client = {}) {
if (!client.config || !client.config.client) return false;
return ['postgresql', 'postgres', 'oracle', 'mssql'].includes(client.config.client);
}
This is working for me now but I know you can provide proper solution. Please help me with this because we have decided to go ahead with bookshelf.js as our ORM for AWS Redshift.

I think the better solution would be to add an alias of redshift as pg and then don't include redshift in the list of clients that support returning.
So, you would use this in your config:
var knex = require('knex')({
    client: 'redshift',
    // ...
  });

BTW, not sure why you're specifying the adapter parameter. I don't think that exists.

I did some more investigation and this is probably not something that we can solve in Bookshelf, but I think it's already been solved in Knex. Can you try with the 'redshift' client instead of pg?

Hi Ricardo,
As you suggested I tried to configure knex with redshift as client instead of pg but i get the same error because of returning key word

Hi Ricardo,
Can you please let me know if there will be any solution around this issue.
is there is any plan to handle it in better way than what i did ?
It does not work with the knex configuration that you suggested.
If not Bookshelf then whether knex will handle this issue ?
if yes then do i need to create an issue with knex ?
I need to take decision hence these are my queries. Please guide..
-Sachin

I'm a little busy at the moment but I'll get back to you next week. In the mean time if you'd like to investigate a solution that doesn't break the pg driver I would also take a PR for this.

Hi Ricardo,
I am also busy at the moment due to urgent deliveries. Hence, it would be difficult for me to investigate and find some solution around this issue. It would be great if you could help me out.
BTW, can I do something like this
function supportsReturning(client = {}) {   if (!client.config || !client.config.client) return false;   if(client.config.client == 'redshift'){     return ['postgresql', 'postgres', 'oracle', 'mssql'].includes(client.config.client);   }else{    return ['postgresql', 'postgres', 'pg', 'oracle', 'mssql'].includes(client.config.client);   } }

Hi Ricardo,
First of all I wish you Merry Christmas !! I hope you enjoying peaceful Christmas vacation time.
Currently I am bit occupied in the work/deliveries that I am assigned to.  I hope in the mean time you have come up with some solution around this issue.  In case there is no easy and quick solution available for this issue then can I go ahead with the solution that I mentioned above. I will make PR and submit to you and if that is fine then you can merge it. This will solve my issue and we can go ahead with this solution for now. Please let me know what you think I will be waiting for your response.
Once again best greetings of the season and wish you a happy New Year.
-Sachin

The solution you posted doesn't make sense to me. How can
['postgresql', 'postgres', 'pg', 'oracle', 'mssql'].includes(client.config.client) ever return true if client.config.client === 'redshift'? Clearly if it's redshift it's not in the array, therefore the current code should already be returning false.


Sending one unique push for iOS and Android

Expected Behaviour
Everything working
Actual Behaviour
Working only on one platform at a time...
Reproduce Scenario (including but not limited to)
Read underneath
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
All
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
All
Cordova CLI version and cordova platform version
Last
Plugin version
Last
Hi,
It is maybe not an issue but a clarification.
I am using only FCM for everything, last version of the plugin, on an ionic app
Reading the (otherwise very clear) docs, I am wondering something.
In the payload doc : https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md
It is explained that for android, you need to send the following, to be able to get the on(notification) handler working on android :
{     "data" : {         "title": "Test Notification",         "body": "This offer expires at 11:30 or whatever",         "notId": 10,         "surveyID": "ewtawgreg-gragrag-rgarhthgbad"     } }
and it is also written to never use the "notification" part in the payload, if you actually want the handler to work.
Now this is clear and it is working on Android.
But on iOS, it also clearly written to do exactly the opposite :
{     "registration_ids": ["my device id"],     "notification": {         "title": "My Title",     	"body": "My message"     }     "data": {     	"key1": "data 1",     	"key2": "data 2"     } }
So the big issue here is, the whole idea of using FCM is not having to handle (on a high level) the differences between iOS and Android.
Now I understand that it is totally the opposite that is needed. You have to know exactly which type of device is your user using (as the registration callback does not give it, you have to do it on your own).
That also means that if you want to send a notification to a FCM group (like "all users") you have to do it twice, one for all Android users, one for all iOS users.
Am I missing something?
Shouldn't it be explained in the documentation somewhere?
There is no way to make an FCM notification working for both environnement at once?
Thanks, no sure if it is the right place but it seems extremely strange from a user perspective.

@arimk No, you are not missing something. If you read:
https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#notification-vs-data-payloads
You should get an overview of why the plugin requires everything in the data section instead of notification. That's just a limitation of the way pushes are handled on Android and the need to pass along the event to the JS layer.
With iOS we are using FCM libs directly from Google which require the push in notification.
I really wish I could make this consistent but I can't.

@arimk it should be but in testing various version of Android/Play Services I haven't found it to be 100% consistent. As well if you put anything in notification then the OS takes over control of the look of the push so options like, icons, sound, action buttons, etc. will not be handled by this plugin.
Your suggestion of having this front and centre in the readme is a good one. I'm going to re-open this issue until I get a chance to add it to the docs. Thanks for the feedback.

@arimk can you give the README a quick look over and see if this makes sense?

@macdonst It does! Maybe just adding something about having to retreive platform information by yourself as it is not the plugin's role to do it?


[BUG] Sporadic timeouts sending to service bus with azure-messaging-servicebus

Describe the bug
I have an Azure Function with a queue trigger that creates a ServiceBusSenderClient and attempts to send a single message to a service bus topic via ServiceBusSenderClient.sendMessage. For around 10% of the function invocations, sendMessage times out with an IllegalStateException.
The function is able to send other messages to the service bus during the time that these timeouts are occurring. Retries of sendMessage help to alleviate the issue but some messages still timeout after 15 minutes of retrying.
Exception or Stack Trace
From application insights
java.lang.IllegalStateException: Timeout on blocking read for<PHONE_NUMBER>00 NANOSECONDS
	at reactor.core.publisher.BlockingSingleSubscriber.blockingGet(BlockingSingleSubscriber.java:123)
	at reactor.core.publisher.Mono.block(Mono.java:1727)
	at com.mycom.ForwarderFunction.forwardEventFromQueue(ForwarderFunction.java:108)
	at sun.reflect.GeneratedMethodAccessor184.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.microsoft.azure.functions.worker.broker.JavaMethodInvokeInfo.invoke(JavaMethodInvokeInfo.java:22)
	at com.microsoft.azure.functions.worker.broker.JavaMethodExecutorImpl.execute(JavaMethodExecutorImpl.java:54)
	at com.microsoft.azure.functions.worker.broker.JavaFunctionBroker.invokeMethod(JavaFunctionBroker.java:57)
	at com.microsoft.azure.functions.worker.handler.InvocationRequestHandler.execute(InvocationRequestHandler.java:33)
	at com.microsoft.azure.functions.worker.handler.InvocationRequestHandler.execute(InvocationRequestHandler.java:10)
	at com.microsoft.azure.functions.worker.handler.MessageHandler.handle(MessageHandler.java:45)
	at com.microsoft.azure.functions.worker.JavaWorkerClient$StreamingMessagePeer.lambda$onNext$0(JavaWorkerClient.java:92)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

To Reproduce
I haven't been able to reproduce the issue sending to our service bus topic while running the function app locally, but the error occurs sporadically with the function apps deployed in our Azure resource groups. Send a message to a service bus topic with ServiceBusSenderClient.sendMessage at regular intervals; a portion of the calls block and timeout.
Code Snippet
public class ForwarderFunction {
    String SERVICE_BUS_CONN_STRING = "...";
    String SERVICE_BUS_TOPIC = "...";

    @FunctionName("Forward-message")
    public void ForwardEventFromQueue(
            @QueueTrigger(name = "qmsg", queueName = QUEUE_NAME, connection = QUEUE_CONNECTION) String qmsg,
            final ExecutionContext context
    ) {
        String result = doSomeProcessing();

        ServiceBusSenderClient senderClient = ServiceBusClientBuilder()
                .connectionString(SERVICE_BUS_CONN_STRING)
                .retryOptions(retryOptions)
                .sender()
                .topicName(SERVICE_BUS_TOPIC)
                .buildClient();

        ServiceBusMessage serviceBusMessage = new ServiceBusMessage(result);
        senderClient.sendMessage(serviceBusMessage);

        senderClient.close();
    }
}

Expected behavior
The sendMessage function calls do not time out with an exception and messages are consistently sent successfully to the service bus topic.
I understand timeouts may be inevitable if there are issues on the service bus topic side but that doesn't seem to be the case as other messages are sent successfully in the same time frame as these timeouts.
Setup (please complete the following information):

Java version: 8
App Server/Environment: Azure Function
'com.azure', name: 'azure-core', version: '1.17.0'
'com.azure', name: 'azure-messaging-servicebus', version: '7.4.0'

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

@ki1729 could you follow up on @JunhaoSLi's github issue?
/cc @anuchandy


remove deletion flag

When restoring, it is often seen as not best practice to remove new content that differs from backup, but to evaluate that content after a restore. Please consider these changes.
With these changes, content can be in the source EFS volume that is not in the backup EFS volume, that isn't removed after a restore. However, files are restored that were removed from source EFS that are still available in backup EFS.

Thank you for your contribution! We will take these changes into consideration for future versions of this solution.

 We recommend that you evaluate AWS Backup for your specific use case before you use this solution.


Doubts when installing plugin.

Hello Guys,
Can you please help me?
I don't know if it possible to use this plugin in my local machine. I wanted to test it before going for the actual server where Redmine is going to be running.
I am trying to follow the instalation guide. I go through all steps until I have to test a ssh connection to my gitolite repository. I do not understand if Redmine have to be running or not, but when I try to do the ssh, it gives an error saying the connection refused on port 22.
I want to be able to test the plugin because it seems very usefull, but I have been all day long and could not go though.
If anyone can help me, I would be gratefull.

See https://github.com/redmine-git-hosting/redmine_git_hosting/issues/795


Review pane contains edits that took place outside of the current merge request

Prerequsities

[x] The "Troubleshooting" section of the README did not help
[x] I've installed the required dependencies
[x] I'm on the latest version of the plugin

Bug Description
When looking at the diff in gitlab.nvim I see files that are marked as modified which have been edited in the meantime and merged into the target branch, but not as part of the branch that is being reviewed. The current branch has not yet been rebased onto the target branch, which is probably part of why this is marked as a diff.
Reproduction Steps
I believe the following should reproduce this issue:

Create a branch off of an older version of the target branch
Create some modifications and commit them
Create a pull request
Open gitlab.cn

Screenshots
Nvim:

GitLab:

Other Details
It seems that gitlab.nvim displays the diff between the target and the source branch if I'm not mistaken, because after I checked out the target branch and pulled from origin, the diff in the review pane looks different. However, this may contain changes that were not part of the current pull request. This differs from what GitLab displays. Maybe it would be possible to fetch the Diff from GitLab itself?
Finally
Thank you very much for creating this tool! I greatly appreciate it. It looks like exactly what I've been hoping for but didn't have the time or expertise to write myself. If there is anything that I can help with in reproducing or fixing this then just let me know.

Thanks for reporting this, and for the kind words.
The reviewers for this plugin (Diffview and Delta) both operate on the local filesystem, so we'd have to find a way to pull down and even merge the target branch into the feature branch prior to doing the comparison.
I've got an MR open here to do the first step of that: To detect when your local branch is out-of-date compared to the branch that's remote, and will prompt you to pull down those changes.
https://github.com/harrisoncramer/gitlab.nvim/pull/61
However, you would still need to merge the target branch into your feature branch in order to see the difference between the two. Realistically I think that the simplest path here would be to (after that above MR is merged) add the additional step of merging the target branch into your feature branch prior to opening up the reviewer.
It looks like the online UI uses an external service called Gitaly and Redis to do some comparisons and parsing which isn't really feasible locally:
https://docs.gitlab.com/ee/development/merge_request_concepts/diffs/

actually based on behaviour from VSCode and GitLab itself - diff needs to be generated from the point of forking to the tip of the branch and not source_branch->target_branch.

If I could make gitlab.nvim connect to the view I launch with the command up above that would be perfect for me for 99% of reviews.

Thank you both. I've been doing a bit of research (thanks ChatGPT) and it seems like the following series of commands may provide us with the exact commit hashes we need to provide to the diffview plugin in order to generate the correct output. Please let me know if this sounds right to you, and I can work on implementing this.

Pull down the latest information from the remote repository:

$ git fetch origin

Use the git merge-base command to get the point two branches diverged. This seems like a simpler alternative than the approach that @droopy4096 outlined:

git merge-base origin/target-branch origin/source-branch

Get the last commit in the feature branch that's been pushed up to the origin remote:

$ git rev-parse origin/feature-branch

Run the diffview command with these two hashes:

:DiffviewOpen common_ancestor...last_commit

If there are merge conflicts with the branch (possible) then show a warning to the user. We already have merge conflict warning information in the project already, but I'm thinking it makes sense to flash a warning to the user if they open the reviewer and there are conflicts in the branch.

Ohhh, wait on second thought it looks like these commit hashes might already be available to us via the information response:
https://docs.gitlab.com/ee/api/merge_requests.html#response
They look like they are in the diff_refs field here? It seems like we'd just have to compare these fields:
:DiffviewOpen (diff_refs.start_sha)..(diff_refs.head_sha)

Would this work @droopy4096 @briandipalma?

Your change doesn't seem to be in main any longer?
https://github.com/harrisoncramer/gitlab.nvim/blob/main/lua/gitlab/reviewer/diffview.lua
This is weird...you're change didn't work so I thought I'd open up the file and make some changes to the code you changed to see if I could fix it and I can't see your change in there?!
I must be making a silly mistake, is that the wrong file?

Oh, the change wass still in a PR, I hadn't merged it yet. It's now in main, if you update the plugin you'll see it now.

Fantastic, it works as I'd expect, thanks!

Great! I'm going to close this issue out but anyone noticing similar issues like this please open up another one. Thanks all for your help figuring this one out!


Keep GitHub Actions up to date with Dependabot

https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem

@samar-hassan @specialunderwear Your reviews, please.  In #4213 we can see that many GitHub Actions are out of date.  It would be useful to bring them up to date before landing other pull requests.

#4213


MongoDB node lib update to 2.2.x

Not a bug necessarily but i went over changelog on mongodb node lib and found a few items:
1.Destroy connection on socket timeout due to newer node versions not closing the socket.
2.If only a single mongos is provided in the seedlist, fix issue where it would be assigned as single standalone server instead of mongos topology
3. A bunch of bugs were fixed when topology includes replicasets, shards
4. They improved on stateless detection
5. close event not emits during network issues using single server topology
And MANY more were resolved
Thank you !

As you can see, in the open pull requests, the new versions of the mongodb driver are not playing well with our test suite. We need to spend an bit of time on it to make sure everything work as intended with the newest versions of the driver

Ahhh my bad, i didn't see those. Wonder what has changed , i didn't see "breaking changes "notes in the driver change log

Yeah i see these guys failed:

Parse.Query testing lessThanOrEqualTo queries

Expected 6 to equal 8, undefined.

Parse.Query testing notEqualTo queries

Expected 8 to equal 9, undefined.

Yup... it's he _Schema updates that are not completing correctly

Were you thinking making 3.2 a minimum requirement for parse-server , that way you won't have to support differences like that?

3.2 as a minimum would be a huge win because then Parse.Query could get join functionality via the $lookup operator.

Given that Parse is shutting down officially within few weeks, migration was complete by everyone who needed to.
@flovilmart  how likely is it to just drop support for 3.0.x , 3.2 has been out for about 2 years i believe.
Thanks @emkman what do you think of those failures on test cases?

The mongodb version itself is not the problem at hands here. It's unlikely we'll drop support for older mongodb versions UNLESS there is a very good reason.

Parse.Query could get join functionality via the $lookup operator.

That would be nice, but not in the current focus, actually there is nothing preventing it to happen now, without dropping support of older mongodb  version.

Thanks for clarification , what is the focus? is there a roadmap for this library
It seems that having mongo driver follow the updates from MongoDB is pretty important.
Although i did notice postgres support seems to be prevailing

It seems that having mongo driver follow the updates from MongoDB is pretty important.

yes it is, but it's even more important to maintain stability in our own project than starting to notice unexpected behaviours.
We haven't had the time to correctly investigate and bump the mongodb package. Feel free to take a look at it.

I'll try and experiment locally with a modified version

Pardon my novice comment, but could support for mongodb 3.2 also result in GeoJSON support while still maintaining backwards compatibility with older mongodb versions? GeoJSON support (especially for making geo queries with polygons) would be absolutely awesome!

we support mongodb 3.2, that's not the question here. the question is about the driver version, not the database version.


Delayed availability of network security group

When running through this tutorial, the creation of the 2nd VM and configuration of the network security group may not be possible until after the Azure instance has had a chance to fully deploy the first VM and the corresponding NSG that was created in that previous step. Give the system a couple minutes or go back out to the Overview and re-select VM as a resource and click [CREATE] in order to make this available.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0f0990fc-9834-bde3-5e06-071c75fa89a5
Version Independent ID: 96f5df37-aa95-443d-2500-37665179ce89
Content: Quickstart: Use the Azure portal to create a virtual network - Azure Virtual Network
Content Source: articles/virtual-network/quick-create-portal.md
Service: virtual-network
GitHub Login: @asudbring
Microsoft Alias: allensu

@akersha
Thank you for bringing this to our attention.
I've delegated this to content author @asudbring, who will review it and offer their insightful opinions.

@asudbring
Could you please review add comments on this, update as appropriate.

Created PR to tweak that part of the quickstart to have user wait for first virtual machine to finish deploying.
#please-close


Make the file_system_buffer filter available

Commit Message: Make the file_system_buffer filter available
Additional Description: Finishes the file_system_buffer filter, and makes it available as an extension. Adds documentation.
Risk Level: Low - doesn't do anything unless filter is configured.
Testing: 100% coverage and an integration test. An earlier version has also been end-to-end tested.
Docs Changes: Adds documentation for this filter.
Release Notes:
Platform Specific Features: Windows is unsupported.

/retest

/assign mattklein123


Safe to not call InAppBilling.close?

This is more of a question. Is it safe to not call InAppBilling.close()? Basically, I want to just leave it while the app is øpen. And does it automatically close when the app is closed/killed?
Thanks for your time! Great lib, btw!

As per docs for the close-function:

Failure to close the service channel may degrade the performance of your app.

If at all possible, I would not leave it open while the app is open. But it's something you would have to test the impact of.

Thank you, @cbrevik


Inscribe on an Sat (with its UTXO) that already has ordinals inscription, is it doable by using Ord command, or I need to modify the code to achieve this?

Inscribe on an Sat (with its UTXO) that already has ordinals inscription, is it doable by using Ord command, or I need to modify the code to achieve this?  thank you.

ord wallet inscribe --reinscribe --satpoint <SATPOINT_THAT_HAS_INSCRIPTION> --file <FILE> --fee-rate <FEE_RATE>


Does Nitric mean that specs should have a 1.0 release?

Exactly what the title says.  If there's a successor to specs in the works, can we consider specs stable?

Yes, in fact I'm planning to release a 1.0 in the next weeks.

The only major change required for thaz is #523

Tracking progress in https://github.com/slide-rs/specs/issues/532


http hooks leave sockets behind

Hi and thanks for tile38, it's working splendidly for us keeping track of our moving units entering, exiting different areas.
We did however find an issue with using http hooks. It seems that the REST connection has a time to live which is checked with func (conn *HTTPEndpointConn) Expired(), if it has expired the connection is nil:ed (and subsequently recreated). The issue here is that the socket used is actually not closed, after running for a longer duration we hit the roof for open file descriptors as listed by lsof. I tried to find a way in this context to call some Close() method but didn't succeed.
We did solve it on our end by hijacking the http connection and closing down the tcp connection from our receiver, but probably the Close should be done on the server, maybe you have an idea on what can be done.
Thanks again

Expired() don't check anything in HTTPENpointConn, instead we have:
	return &HTTPEndpointConn{
		ep: ep,
		client: &http.Client{
			Transport: &http.Transport{
				MaxIdleConnsPerHost: httpMaxIdleConnections,
				IdleConnTimeout:     httpExpiresAfter,
			},
			Timeout: httpRequestTimeout,
		},
	}

But seems i need a check this issue, maybe it's related to client stuff.

Can you paste some example how you hadle connections ?

Ah, sorry, seems I didn't do my homework.
I thought I checked the git sources but apparently not. In the last release (which is what we are using), Expired() does: conn.client = nil. It seems to me that the checkin 0617593 from feb 10 probably fixes the problem we were seeing.
I can confirm that later but I think it is safe to close this issue as already fixed.

You can close it and feel free to open if you have some issues.

Hi @spamatica, This was fixed in the latest release. The new implementation should gracefully handle closed/expired connections, and also supports HTTP2 endpoints.
@m1ome Thanks for looking into this issue.


Remove the default medium-old size from buttons

Fixes

Related to #1187 by @obulat
Description

This PR makes the size prop for VButton required, and adds a value to all of the components that used the previously-default value of medium-old.
Testing Instructions

Check that the buttons look fine. The sizes will probably change, @fcoveram, could you verify that the buttons use the correct size?
Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat if you don't mind I'm going to draft this while the VR tests are failing. Do you want a preliminary review from @fcoveram before they are fixed?

@obulat if you don't mind I'm going to draft this while the VR tests are failing. Do you want a preliminary review from @fcoveram before they are fixed?

Thank you for drafting it, I should be doing that for PRs that fail VR tests :)
I marked the PR as ready now that the tests pass. I do want @fcoveram's review especially for the VNoResult's buttons, and the text buttons. Should we replace the old text variant with filled-transparent variant? (One of those buttons is the "Clear filters" text button on the filters sidebar on desktop.

review the VNoResult’s buttons, and the text buttons.

Which button is the “VNoResult”? and which are the “text buttons”?

Should we replace the old text variant with filled-transparent variant? (One of those buttons is the “Clear filters” text button on the filters sidebar on desktop.

Can you point out all the text variants?
I would appreciate a more specific review, otherwise I can't assess the time request for this review and might end up scanning all buttons in all pages.

@fcoveram , here is the list of buttons that use the "old" variants.
plain VButtons
plain VButton variant only adds a focus ring, all other styles are added by the component itself
VIconButton
VLogoButton

"Clear filters" in VSearchGridFilter

License explanation button with the question mark

The external sources buttons inside the external sources popover

text VButtons
"Clear" button in the Recent searches popover/modal

"Clear filters" button in the Content settings modal footer

Other
The "external sources" button that opens the sources popover uses a special variant because it it a white button with dark-charcoal border when resting, and dark-charcoal when hovered.


Assertj fixes

Summary of the changes / Why this improves CrateDB
See commit messages
Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

@mfussenegger Thx, fixed the commit messages.
Please take another look, I added one more commit to have a "tighter" check for class assertions.


Using InstantSearch in typescript requires to install algoliasearch

I'am trying to import types from instantsearch.js to create a custom client but unfortunately when I import any type I'm getting the following errors.
 Cannot find module 'algoliasearch' or its corresponding type declarations.

15 } from 'algoliasearch';
          ~~~~~~~~~~~~~~~

Error: ../../node_modules/instantsearch.js/es/lib/InstantSearch.d.ts:3:8 - error TS1259: Module '"events"' can only be default-imported using the 'allowSyntheticDefaultImports' flag

3 import EventEmitter from 'events';
         ~~~~~~~~~~~~

  node_modules/@types/node/events.d.ts:82:5
    82     export = EventEmitter;
           ~~~~~~~~~~~~~~~~~~~~~~
    This module is declared with using 'export =', and can only be used with a default import when using the 'allowSyntheticDefaultImports' flag.

Error: ../../node_modules/instantsearch.js/es/types/algoliasearch.d.ts:1:32 - error TS2307: Cannot find module 'algoliasearch/lite' or its corresponding type declarations.

1 import type algoliasearch from 'algoliasearch/lite';
                                 ~~~~~~~~~~~~~~~~~~~~

Error: ../../node_modules/instantsearch.js/es/types/algoliasearch.d.ts:2:37 - error TS2307: Cannot find module 'algoliasearch/lite' or its corresponding type declarations.

2 import type * as AlgoliaSearch from 'algoliasearch/lite';
                                      ~~~~~~~~~~~~~~~~~~~~

EDIT:
About the algoliasearch/lite error:
It seems that when I add the algoliasearch package the algoliasearch/lite errors disapear. Is it possible to use instantsearch.js in typescript without having to add algoliasearch npm package?
I feel like this makes instantSearch bound to AlgoliaSearch officially in a TypeScript env. I'm not sure if this was intended though.
About the eventEmitter errors:
When I change my tsconfig.json by adding "allowSyntheticDefaultImports": true the error disapears.

Hi there @HamzaInPerth, thanks for reaching out.
algoliasearch/lite is part of the algoliasearch npm package. I think you're right, InstantSearch types are using the client's types, so either it should reimplement them to be fully independent, or list the client as a peer dependency.
@Haroenv do you agree with this?
Question to @HamzaInPerth : are you not reusing the client types for your custom client?

Yes, this is expected, the types otherwise would have to be fully retyped here, which would be a source of confusion and possible errors. We might need to think of a special solution, as it's not really a dependency, but maybe it can be considered one. algoliasearch is required to be installed when using typescript, but doesn't need to be used.
Synthetic default imports are needed indeed.

Hello @tkrugg I'm using the client types for my custom client but I need to import it from algoliasearch.
Hello @Haroenv this stackoverflow might help to determine where to add the dependency: https://stackoverflow.com/a/63905376

Peer dependencies are listed now


Migrate from appdirs to platformdirs

platformdirs is a friendly, maintained fork of appdirs (which stopped development after ~2020) - This should be 100% compatible for the used methods.

Merged; there will be a release done (automatically) in a few minutes.

1.42 https://pypi.org/project/yowasp-runtime/1.42/


[docs] Update docs for v0.8 tiles

New pois for Int'l Womens Day: https://github.com/mapzen/vector-datasource/issues/526

childcare, clinic, dentist, doctors, kindergarten, midwife, phone, social_facility, toilets
But social_facility is special, because we end up replacing that with the the value it's set to in https://github.com/mapzen/TileStache/pull/115/files, which results in:
Common tags: ambulatory_care, assisted_living, food_bank, group_home, outreach, shelter, workshop
Less common tags, some of which are almost the same as some of the basic ones listed above: care_home, childrens_centre, club, dairy_kitchen, day_care, healthcare, nursing_home, refugee_camp, residential_home, soup_kitchen
There are some extremely rare tags from taginfo that we should skip because they are confusing.

New pois for Big Box stores: https://github.com/mapzen/vector-datasource/pull/544/files

hardware, trade

New water layer labels: https://github.com/mapzen/vector-datasource/issues/400

bay, strait, fjord

More layers include sort_key values (boundaries, buildings, earth, transit, and water).

sort_key: a suggestion for which order to draw features. The value is an integer where smaller numbers suggest that features should be "behind" features with larger numbers.

Make this new description consistent with existing roads and landuse sort_key descriptions.

Correct kind list in boundaries layer to read:

1st Order Admin Line, Admin-0 country, Admin-1 boundary, Admin-1 region boundary, city_wall, country, county, Disputed (please verify), fence, Indefinite (please verify), Indeterminant frontier, International boundary (verify), Lease limit, Line of control (please verify), municipality, Overlay limit, retaining_wall, snow_fence, state

@rmarianski @zerebubuth Is there any more documentation needed for this release?

We're adding min_zoom for buildings: https://github.com/mapzen/vector-datasource/pull/562

There's also some language in the docs about objects appearing at z17. We'll want to update those to say z16.


Make it possible to run the game without any visuals

Anything related to the visuals should be completely separate and optional.
This is important, because then:

The code will be cleaner
It'll be easy to run multiple game instances at once (e.g. for simulations)
We'll be one step closer to being able to write unit tests

Tasks (incomplete list?):

[x] Separate province visuals (#199)
[x] Separate autoarrow visuals
[x] Separate world visuals
[x] Separate game visuals
[x] Separate GamePlayer username synchronization (#229)

The game still stores information that's only used by visuals: a country's color, the icon texture associated with a game notification, and likely more I haven't thought of.
It doesn't prevent the game from running without visuals, so I'd say this is good enough.
If we really had to crack down on separating everything that isn't related to core game logic, then we'd have to remove autoarrows because they're just an automation tool, we'd have to rework game notifications because they're mostly just to notify players of things that happened, etc etc.


Added R package documentation to main docs site

First pass. Still really hacky to build, but the script is at lang/R/docs/build.R.

Added the docs to the main site.
Made the citations in the vignette manually entered, because auto-populating from the bibtex file wasn't working.
Some tweaks to layout in readme and news.

Made the citations in the vignette manually entered, because auto-populating from the bibtex file wasn't working

I will add manually in the future.

Thanks. The way you did the citations is better, but it wasn't working for the rst conversion. It might be possible to get it to work, but I took the low effort approach for now.  Will look into it more at a later date.


chore(storybook): swap to port 9000

This lets us run both vanilla and react repos at the same time without additional configuration

Bluemix toolchain: Delivery Pipeline deployed carbon-components-react to Bluemix Design System, including commit 5c1f71cf5ab7a3d713cb336ec29b8913182328e1


how to display storage content in laravel 5.3 from storage folder

Laravel Version:  5.3.30
PHP Version:5.6
Database Driver & Version:MySQL 5.6

Description:
i can't display image or playing mp3 file ,i have been struggling for this issue for hours on my localhost all files images,mp3 works fine in symbolic link at public/storage when i moved to the share hosting can't work this is sample code for image tag
tag img src="{{asset($track->image)}}" alt="{{$track->Name}}" data-toggle="tooltip" data-placement="bottom" title="{{$track->Name}}"
the value of $track->image
is a path :storage/images/avatars/artists/f9dc92344b57ec6b0bcb3ce601f9d134.jpeg
Steps To Reproduce:
NotReadableException in AbstractDecoder.php line 335:
Image source not readable

This doesn't seem to be a bug. You can use the forums or the slack channel to get your problem solved

I have been using defferent forums, I didn't find a solution that is why I used this channel

I think this is more related to Intervention\Image, please ask on their repository.

thanks let me check on Intervention\Image repository


[Feature] Support Integer-Types value in like predicate

Proposed changes
Support integer types value in like predicate.
The basic idea is adding a rewrite rule to rewriete the expr of SlotRef, which type is fixedPointValue, aka Integer-Types, to a CastExpr, it will cast the fixedPoint value to string.
Types of changes
What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
[ ] Code refactor (Modify the code structure, format the code, etc...)
[ ] Optimization. Including functional usability improvements and performance improvements.
[ ] Dependency. Such as changes related to third-party components.
[ ] Other.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have created an issue on (Fix #6578 ) and described the bug/feature there in detail
[ ] Compiling and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[ ] If these changes need document changes, I have updated the document
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

Merge the RewriteLikePredicateRuleTest with ExtractCommonFactorsRuleFunctionTest to save the time of running unit test.
calling UtFrameUtils.createDorisCluster will cost about 20 seconds.

Done.


Polkadot draft schedule

Scheduled some items but very open to moving/adding/removing things! If there's something missing feel free to raise it.

@Overkillus Is there any update any this?