[feature request] TLS support for redis messaging service

Description
Redis security guidelines state applications should use TLS where possible. I am currently using Luckperms on multiple servers that connect over the internet to my Redis server for messaging.
It would be nice to have the option to use client certificates in order to enable TLS connections to Redis. The Redis docs provide example Java code for connecting via TLS.
Proposed Behaviour
In config.yml, options could look something like this:
messaging-service: redis
# ...
redis:
  enabled: true
  address: redis.example.com
  username: ''
  password: ''
  tls:
    enabled: false
    ca-keystore: 'redis_ca.jks'
    ca-keystore-password: 'example'
    user-keystore: 'redis-user-keystore.p12'
    user-keystore-password: 'example'

When redis.tls.enabled is set to true, LuckPerms would use the CA/User keys specified to establish a TLS connection with the Redis server.
Extra Details
I'm not sure if a more concise approach could be used (i.e. one keystore/password for CA and user keys) but that is the general idea. The default values used here are taken from the Redis guide for using TLS with Java

Additionally, LuckPerms currently cannot establish a connection to a Redis server with TLS enabled, even if tls-auth-clients optional is specified in redis.conf:

redis.conf snippet
# By default, clients (including replica servers) on a TLS port are required
# to authenticate using valid client side certificates.
#
# If "no" is specified, client certificates are not required and not accepted.
# If "optional" is specified, client certificates are accepted and must be
# valid if provided, but are not required.
#
# tls-auth-clients no
tls-auth-clients optional

LuckPerms error message
[01:04:52 INFO]: [LuckPerms] Redis pubsub connection re-established
[01:04:54 WARN]: [LuckPerms] Redis pubsub connection dropped, trying to re-open the connection
me.lucko.luckperms.lib.jedis.exceptions.JedisConnectionException: java.net.SocketException: Connection reset
        at me.lucko.luckperms.lib.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:208) ~[?:?]
        at me.lucko.luckperms.lib.jedis.util.RedisInputStream.readByte(RedisInputStream.java:46) ~[?:?]
        at me.lucko.luckperms.lib.jedis.Protocol.process(Protocol.java:126) ~[?:?]
        at me.lucko.luckperms.lib.jedis.Protocol.read(Protocol.java:192) ~[?:?]
        at me.lucko.luckperms.lib.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:335) ~[?:?]
        at me.lucko.luckperms.lib.jedis.Connection.getStatusCodeReply(Connection.java:262) ~[?:?]
        at me.lucko.luckperms.lib.jedis.Connection.auth(Connection.java:446) ~[?:?]
        at me.lucko.luckperms.lib.jedis.Connection.initializeFromClientConfig(Connection.java:380) ~[?:?]
        at me.lucko.luckperms.lib.jedis.Connection.<init>(Connection.java:61) ~[?:?]
        at me.lucko.luckperms.lib.jedis.ConnectionFactory.makeObject(ConnectionFactory.java:68) ~[?:?]
        at me.lucko.luckperms.lib.commonspool2.impl.GenericObjectPool.create(GenericObjectPool.java:918) ~[?:?]
        at me.lucko.luckperms.lib.commonspool2.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:431) ~[?:?]
        at me.lucko.luckperms.lib.commonspool2.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:356) ~[?:?]
        at me.lucko.luckperms.lib.jedis.util.Pool.getResource(Pool.java:38) ~[?:?]
        at me.lucko.luckperms.lib.jedis.ConnectionPool.getResource(ConnectionPool.java:29) ~[?:?]
        at me.lucko.luckperms.lib.jedis.ConnectionPool.getResource(ConnectionPool.java:7) ~[?:?]
        at me.lucko.luckperms.lib.jedis.providers.PooledConnectionProvider.getConnection(PooledConnectionProvider.java:63) ~[?:?]
        at me.lucko.luckperms.lib.jedis.UnifiedJedis.subscribe(UnifiedJedis.java:3538) ~[?:?]
        at me.lucko.luckperms.common.messaging.redis.RedisMessenger$Subscription.run(RedisMessenger.java:125) ~[?:?]
        at java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1395) ~[?:?]
        at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?]
        at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?]
        at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?]
        at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?]
        at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?]
Caused by: java.net.SocketException: Connection reset
        at sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:328) ~[?:?]
        at sun.nio.ch.NioSocketImpl.read(NioSocketImpl.java:355) ~[?:?]
        at sun.nio.ch.NioSocketImpl$1.read(NioSocketImpl.java:808) ~[?:?]
        at java.net.Socket$SocketInputStream.read(Socket.java:966) ~[?:?]
        at java.io.InputStream.read(InputStream.java:218) ~[?:?]
        at me.lucko.luckperms.lib.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:202) ~[?:?]
        ... 24 more


User settings for Providers list

Depends on PR #102

Codecov Report
Base: 37.67% // Head: 38.08% // Increases project coverage by +0.41% :tada:

Coverage data is based on head (72c0d51) compared to base (4d82fb3).
Patch coverage: 78.12% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   37.67%   38.08%   +0.41%
==========================================
  Files          72       73       +1
  Lines        2426     2455      +29
  Branches      649      652       +3
==========================================
+ Hits          914      935      +21
- Misses       1400     1408       +8
  Partials      112      112

Impacted Files
Coverage Δ

pkg/web/src/app/queries/mocks/providers.mock.ts
100.00% <ø> (ø)

src/hooks/useSearchParams.tsx
36.36% <36.36%> (ø)

src/components/StandardPage/StandardPage.tsx
78.94% <100.00%> (ø)

src/components/StandardPage/useFields.tsx
100.00% <100.00%> (ø)

src/components/TableView/TableView.tsx
95.65% <100.00%> (+0.41%)
:arrow_up:

pkg/web/src/app/client/helpers.ts
28.86% <0.00%> (-0.31%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Layout -> RelativePanel [WinUI 3 v2.5.0]

Issue type
sample request
Which version of the app?
WinUI 3 Gallery
Description
I suggest explaining the RelativePanel control better, to distinguish it from StackPanel or Grid.
From Microsoft's website: https://learn.microsoft.com/en-us/windows/windows-app-sdk/api/winrt/microsoft.ui.xaml.controls.relativepanel?view=windows-app-sdk-1.6
Chapter: Conflicting relationships
It describes interesting events that I don't understand very well.

Screenshots
No response
Windows version
Windows 10 22H2 (19045)
Additional context
No response

Looks like the relative panel does not allow the expander to stretch properly, I'll have a look at that.
For adding better RelativePanel examples; @PRZEMPM is that something you'd like to work on? Or certain samples you had in mind?

@niels9001 As for the link I provided, I meant the implementation examples as an example for RelativePanel. You can use others, but in my opinion there is too much content explaining the meaning of controls, instead of presenting them with examples to engage the user in some change, to see how the operation causes changes in a specific control.

@niels9001 As for the link I provided, I meant the implementation examples as an example for RelativePanel. You can use others, but in my opinion there is too much content explaining the meaning of controls, instead of presenting them with examples to engage the user in some change, to see how the operation causes changes in a specific control.

Agreed, it could use some work, and ideally, doc samples are (somewhat) in sync with the Gallery samples.
Do you want to take a stab at it?

What do you mean?: Do you want to take a stab at it?

What do you mean?: Do you want to take a stab at it?

Is this something you would like to work on and contribute to the WinUI Gallery?

Is this something you would like to work on and contribute to the WinUI Gallery?

Thank you for the offer. In my current job I have projects related to WinUI 3. As for introducing improvements to WinUI 3 Gallery, it's a matter of agreement with the creators of this application ;)


Add CouchPotato cask.

Found a versioned url, looks like the source lives at https://github.com/RuudBurger/CouchPotatoServer/
Thus, download url can (and should) be changed to something like "https://github.com/RuudBurger/CouchPotatoServer/releases/download/build%2F#{version}/CouchPotato-#{version}.macosx-10_6-intel.zip"; and the version and shasum updated accordingly. You will also need a comment above url, and you can add in an appcast for good measure.
Sample cask -> https://github.com/caskroom/homebrew-cask/blob/master/Casks/aether.rb

Ok, thanks will do.
I wasn’t sure if the versioned url was preferred over the ‘latest’ url style.

On Oct 21, 2015, at 6:57 PM, Aditya Dalal<EMAIL_ADDRESS>wrote:
Found a versioned url, looks like the source lives at https://github.com/RuudBurger/CouchPotatoServer/ https://github.com/RuudBurger/CouchPotatoServer/
Thus, download url can (and should) be changed to something like "https://github.com/RuudBurger/CouchPotatoServer/releases/download/build%2F#{version}/CouchPotato-#{version}.macosx-10_6-intel.zip"; and the version and shasum updated accordingly. You will also need a comment above url, and you can add in an appcast for good measure.
Sample cask -> https://github.com/caskroom/homebrew-cask/blob/master/Casks/aether.rb https://github.com/caskroom/homebrew-cask/blob/master/Casks/aether.rb
—
Reply to this email directly or view it on GitHub https://github.com/caskroom/homebrew-cask/pull/14585#issuecomment-150091750.


SSL: Handshake read failed. End of TCP stream

My grpc client fails to connect to grpc server with handshake read failed error.
Security handshake failed: {"created":"@1533085202.848000000","description":"Handshake read failed","file":"C:\workspace\grpc-1.0.0\vsprojects..\src\core\lib\security\transport\handshake.c","file_line":237,"referenced_errors":[{"created":"@1533085202.848000000","description":"End of TCP stream","file":"C:\workspace\grpc-1.0.0\vsprojects..\src\core\lib\iomgr\tcp_windows.c","file_line":180}]}
Environment:
gRPC client: 1.0.0 (Cent OS) (C++)
gRPC server: 1.0.0 (Windows 2008R2) (C++)
Tried setting "grpc.initial_reconnect_backoff_ms" to 10000 ms (#8382) but still getting same error. This is happening only with Windows based server. I have servers running RHEL, Ubuntu without any issue.
Any help would be highly appreciated.

@nicolasnoble, won't be able to upgrade in near future.

It's going to be very difficult to diagnose anything in such an old codebase, really. The Windows support especially got rewritten several times.

@nicolasnoble, I can understand that. Do you have any suggestion for me to diagnose this issue?

Unfortunately there isn't enough information from the errors pasted to see what the issue is. Clearly, the 'read' operation from the socket failed on the client side (perhaps the connection was explicitly closed by server or some other error - can't say).
Try turning on grpc traces (flags are here: https://github.com/grpc/grpc/blob/master/doc/environment_variables.md)
set the following env variables
GRPC_VERBOSITY = DEBUG
GRPC_TRACE=all

@sreecha, I enabled grpc traces and below is the trace from the handshake:
I0823 17:25:16.708373169  148095 grpc_context.c:41]          grpc_census_call_set_context(call=0x325db00, census_context=(nil))
I0823 17:25:16.708468013  148095 call.c:1690]                grpc_call_start_batch(call=0x325db00, ops=0x3277190, nops=3, tag=0x32a82d0, reserved=(nil))
I0823 17:25:16.708485027  148095 call.c:1366]                ops[0]: SEND_INITIAL_METADATA
I0823 17:25:16.708505056  148095 call.c:1366]                ops[1]: SEND_MESSAGE ptr=0x31d6a00
I0823 17:25:16.708523758  148095 call.c:1366]                ops[2]: SEND_CLOSE_FROM_CLIENT
I0823 17:25:16.708582297  148095 client_channel.c:109]       OP[client-channel:0x325e108]: SEND_INITIAL_METADATA{key=3a 70 61 74 68 ':path' value=2f 63 6f 68 65 73 69 74 79 2e 6d 61 67 6e 65 74 6f 2e 61 67 65 6e 74 73 2e 73 74 75 62 2e 41 67 65 6e 74 52 70 63 53 65 72 76 69 63 65 2f 47 65 74 41 67 65 6e 74 49 6e 66 6f '/agents.stub.AgentRpcService/GetAgentInfo', key=3a 61 75 74 68 6f 72 69 74 79 ':authority' value=41 67 65 6e 74 20 28 67 52 50 43 20 73 65 72 76 65 72 29 'Agent (gRPC server)', key=67 72 70 63 2d 65 6e 63 6f 64 69 6e 67 'grpc-encoding' value=69 64 65 6e 74 69 74 79 'identity', key=67 72 70 63 2d 61 63 63 65 70 74 2d 65 6e 63 6f 64 69 6e 67 'grpc-accept-encoding' value=69 64 65 6e 74 69 74 79 2c 64 65 66 6c 61 74 65 2c 67 7a 69 70 'identity,deflate,gzip' deadline=2346737.278543174} SEND_MESSAGE:flags=0x00000000:len=6 SEND_TRAILING_METADATA{}
I0823 17:25:16.708798419  148095 call.c:1690]                grpc_call_start_batch(call=0x325db00, ops=0x3277230, nops=3, tag=0x32a8370, reserved=(nil))
I0823 17:25:16.708806780  148095 call.c:1366]                ops[0]: RECV_INITIAL_METADATA ptr=0x32a8398
I0823 17:25:16.708811534  148095 call.c:1366]                ops[1]: RECV_MESSAGE ptr=0x32a83c0
I0823 17:25:16.708816180  148095 call.c:1366]                ops[2]: RECV_STATUS_ON_CLIENT metadata=0x32a83e0 status=0x32a83f8 details=0x32a8400
I0823 17:25:16.708821997  148095 client_channel.c:109]       OP[client-channel:0x325e108]: RECV_INITIAL_METADATA RECV_MESSAGE RECV_TRAILING_METADATA
I0823 17:25:16.708859492  148094 completion_queue.c:333]     grpc_completion_queue_next(cc=0x323c500, deadline=gpr_timespec { tv_sec:<PHONE_NUMBER>854775807, tv_nsec: 0, clock_type: 1 }, reserved=(nil))
D0823 17:25:16.710726111  148096 connectivity_state.c:92]    CONWATCH: 0x31c3ad8 (null): get IDLE
D0823 17:25:16.710751810  148096 connectivity_state.c:156]   SET: 0x3202748 client_channel: IDLE --> IDLE [new_lb+resolver] error=(nil) null
D0823 17:25:16.710760462  148096 connectivity_state.c:109]   CONWATCH: 0x31c3ad8 (null): from IDLE [cur=IDLE] notify=0x32ca048
D0823 17:25:16.710769521  148096 connectivity_state.c:109]   CONWATCH: 0x32cc0c8 subchannel: from IDLE [cur=IDLE] notify=0x32214b8
D0823 17:25:16.710775949  148096 connectivity_state.c:156]   SET: 0x32cc0c8 subchannel: IDLE --> CONNECTING [state_change] error=(nil) null
D0823 17:25:16.710779095  148096 connectivity_state.c:183]   NOTIFY: 0x32214b8
D0823 17:25:16.710997283  148096 tcp_client_posix.c:305]     CLIENT_CONNECT: ipv4:<IP_ADDRESS>:50051: asynchronously connecting
D0823 17:25:16.711015548  148096 connectivity_state.c:156]   SET: 0x31c3ad8 (null): IDLE --> CONNECTING [connecting_changed] error=(nil) null
D0823 17:25:16.711018833  148096 connectivity_state.c:183]   NOTIFY: 0x32ca048
D0823 17:25:16.711022194  148096 connectivity_state.c:109]   CONWATCH: 0x32cc0c8 subchannel: from CONNECTING [cur=CONNECTING] notify=0x32214b8
D0823 17:25:16.711025449  148096 connectivity_state.c:156]   SET: 0x3202748 client_channel: IDLE --> CONNECTING [lb_changed] error=(nil) null
D0823 17:25:16.711028701  148096 connectivity_state.c:109]   CONWATCH: 0x31c3ad8 (null): from CONNECTING [cur=CONNECTING] notify=0x32ca1c8
D0823 17:25:17.711377133  148094 tcp_client_posix.c:104]     CLIENT_CONNECT: ipv4:<IP_ADDRESS>:50051: on_alarm: error=null
D0823 17:25:17.711514209  148094 tcp_client_posix.c:135]     CLIENT_CONNECT: ipv4:<IP_ADDRESS>:50051: on_writable: error={"created":"@1535070317.711489409","description":"FD shutdown","file":"src/core/lib/iomgr/ev_epoll_linux.c","file_line":948}
D0823 17:25:17.711662548  148094 connectivity_state.c:156]   SET: 0x32cc0c8 subchannel: CONNECTING --> TRANSIENT_FAILURE [connect_failed] error=0x32218b0 {"created":"@1535070317.711592326","description":"Connect Failed","file":"src/core/ext/client_config/subchannel.c","file_line":638,"referenced_errors":[{"created":"@1535070317.711489409","description":"Failed to connect to remote host","file":"src/core/lib/iomgr/ev_epoll_linux.c","file_line":948,"os_error":"Timeout occurred","target_address":"ipv4:<IP_ADDRESS>:50051"}]}
D0823 17:25:17.711697048  148094 connectivity_state.c:183]   NOTIFY: 0x32214b8
I0823 17:25:17.711705225  148094 subchannel.c:642]           Connect failed: {"created":"@1535070317.711489409","description":"Failed to connect to remote host","file":"src/core/lib/iomgr/ev_epoll_linux.c","file_line":948,"os_error":"Timeout occurred","target_address":"ipv4:<IP_ADDRESS>:50051"}
I0823 17:25:17.711711821  148094 subchannel.c:645]           Retry immediately
D0823 17:25:17.711726961  148094 connectivity_state.c:156]   SET: 0x31c3ad8 (null): CONNECTING --> TRANSIENT_FAILURE [connecting_transient_failure] error=0x32218b0 {"created":"@1535070317.711592326","description":"Connect Failed","file":"src/core/ext/client_config/subchannel.c","file_line":638,"referenced_errors":[{"created":"@1535070317.711489409","description":"Failed to connect to remote host","file":"src/core/lib/iomgr/ev_epoll_linux.c","file_line":948,"os_error":"Timeout occurred","target_address":"ipv4:<IP_ADDRESS>:50051"}]}
D0823 17:25:17.711732074  148094 connectivity_state.c:183]   NOTIFY: 0x32ca1c8
D0823 17:25:17.711753560  148094 connectivity_state.c:92]    CONWATCH: 0x32cc0c8 subchannel: get TRANSIENT_FAILURE
D0823 17:25:17.711758449  148094 connectivity_state.c:109]   CONWATCH: 0x32cc0c8 subchannel: from TRANSIENT_FAILURE [cur=TRANSIENT_FAILURE] notify=0x32214b8
I0823 17:25:17.711790848  148094 subchannel.c:609]           Failed to connect to channel, retrying
D0823 17:25:17.711797666  148094 connectivity_state.c:156]   SET: 0x32cc0c8 subchannel: TRANSIENT_FAILURE --> CONNECTING [state_change] error=(nil) null
D0823 17:25:17.711800894  148094 connectivity_state.c:183]   NOTIFY: 0x32214b8
D0823 17:25:17.711883032  148094 tcp_client_posix.c:305]     CLIENT_CONNECT: ipv4:<IP_ADDRESS>:50051: asynchronously connecting
D0823 17:25:17.711910797  148094 connectivity_state.c:156]   SET: 0x3202748 client_channel: CONNECTING --> TRANSIENT_FAILURE [lb_changed] error=0x32218b0 {"created":"@1535070317.711592326","description":"Connect Failed","file":"src/core/ext/client_config/subchannel.c","file_line":638,"referenced_errors":[{"created":"@1535070317.711489409","description":"Failed to connect to remote host","file":"src/core/lib/iomgr/ev_epoll_linux.c","file_line":948,"os_error":"Timeout occurred","target_address":"ipv4:<IP_ADDRESS>:50051"}]}
I set "grpc.initial_reconnect_backoff_ms" to 10000 ms but from this traces it seems it retries immediately.
Here is my code:
`const string host_and_port = host_ + ":" + to_string(port_);
{
grpc::SslCredentialsOptions options;
options.pem_root_certs = agents_keys_certs_ca_cert_pem();
options.pem_private_key = agents_keys_certs_magneto_key_pem();
options.pem_cert_chain = agents_keys_certs_magneto_cert_pem();
grpc::ChannelArguments args;
args.SetSslTargetNameOverride("Agent (gRPC server)");
args.SetInt("grpc.initial_reconnect_backoff_ms", 1000 * 10);
args.SetInt("grpc.max_reconnect_backoff_ms", 1000 * 10);

channel_ = grpc::CreateCustomChannel(
    host_and_port, grpc::SslCredentials(options), args);

}
`

.. have you disabled Windows' firewall ? This trace simply states you weren't able to do a simple TCP connect.

Yes, I did disable Windows' firewall.

Looks like found the root cause of this issue. It turns out to be grpc server running on Windows Server leaks network connections. There are thousands of network connections are in CLOSE_WAIT state. Upgrading grpc from 1.0.0 to 1.15.0 helped resolved this issue.


No visible app

Hi, I have a bmw f45 from 2017.
I have a problem, when I start the app on the vehicle I only see the Youtube app and nothing else (spotify or anything).
Why??
Sorry for my bad english.

Hi I can confirm the same issue.
I have Google, Youtube, Spotify, Samsung Music listed in the phone.
In the can in media I only see Youtube and Audioplayer (and inside again I only see Youtube).
(see attach photos).
Moreover, in Connected Drive menu I see  Audioplayer (with only youtube inside) and "Notofications" but only icon is present, no description.

Spotify no longer allows my app to connect and control it, you would need to install an older version of Spotify. Google Music and Samsung Music similarly don't allow my app to connect. In the README you'll find a list of known compatible apps, please try one of them!
The Notifications menu has a blank label on purpose. Because of how I'm reusing application certs to log in to the car, I don't have control over the main entrybutton's label, so I just choose to not show the label.

So maybe it'd be a good idea to gray out (or add some small text "incompatible") next to applications that are incompatible in the app instead showing them and allowing to press. This is confusing.

Hi, I tried also with the old version of Spotify that you indicated but didn't see, only Youtube is visible.

I will consider UI improvements, thanks! The only clue right now is the little play symbol in the app, which isn't very clear.
I have an idea for a future version to get control over more apps anyways, we'll see whether it's still needed.
After installing the older app, you might need to pull down to refresh the app list. It would automatically probe new apps, but it would have skipped Spotify if it had seen it already.


Add details of authenticating to ACR from AKS using MI

Hi folks. This page hints at something that should be made explicit. There are a couple of other pages that hint at a solution, but never quite get there. I'm happy to submit PRs, but you probably already have a plan in place and I wanted to get your input before I do.
I tried authenticating from AKS to ACR (AcrPull) using the MI that I created and assigned to the AKS cluster. That didn't work, but after some searching around I discovered that when you assign an MI to AKS, you get another MI (kubeletIdentity) that is the one you want. It's these details that I think should be made explicit somewhere. Especially for folks that want to use tools like Terraform rather than the az cli to set this up.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: df40e112-6cf4-f6ce-4d82-d36bbd561405
Version Independent ID: a68e6e7b-dfa2-8640-0a43-cd15f24facdb
Content: Registry authentication options - Azure Container Registry
Content Source: articles/container-registry/container-registry-authentication.md
Service: container-registry
GitHub Login: @dlepow
Microsoft Alias: danlep

Thanks for bringing this to our attention. I have assigned the issue to the content author to investigate further and update the document as appropriate.
If you are interested in creating a PR, just wanted to share that doing so will improve our documentation, and it will add you as a contributor to the document.
In case you're interested, these are the steps to do so:

Navigate to the page of interest
Select the "Edit" button at the top right of the page
Select the "Pencil" icon on the right
Modify the text within the text box in markdown format - more info: https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet
Name your file change and provide a description, if necessary
Select "Propose file change"
Select "Create pull request" on the 'Comparing changes' page
Select "Create pull request" on the 'Open a pull request' page
You can find a GIF that demonstrates the end-to-end process for submitting changes here: https://aka.ms/editsqldocs.

@sebastus, thanks for the feedback. Further details about the AKS managed identity used with ACR are in the AKS documentation. Does this information help?
https://docs.microsoft.com/azure/aks/cluster-container-registry-integration
https://docs.microsoft.com/azure/aks/use-managed-identity

More information about the kubelet managed identity used for access to ACR was added here:
https://docs.microsoft.com/azure/aks/cluster-container-registry-integration?tabs=azure-cli#configure-acr-integration-for-existing-aks-clusters
I will now proceed to close this issue. If you have further feedback, feel free to reopen this issue, or post a question to Microsoft Q&A. Thanks.
#please-close


Added Random Forest Classifier Algorithm

[x] DevIncept Participant
[ ] Contributor

Closes: #6
Describe the changes you've made
Give a clear description what modifications you have made

Added Random Forest Classifier Algorithm.
Practically implemented on a real world Dataset.
Created  Explanation and Documentation for the same .

Type of change
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
How Has This Been Tested?
Describe how have you verified the changes made

Checklist:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] I have made corresponding changes to the documentation.
[x]  My changes generate no new warnings.
[x] I have added test cases that prove my fix is effective or that my feature works.

Please follow the PR template given to your comment above and do the changes accordingly and also add up the issue number you worked on. @vaishnavipatil4848

I have made changes as per the given PR Template . Thank you.

I have made all the requested changes and updated the README file.

Hey in the form you had added the issue link instead of PR link. Kindly change it. @vaishnavipatil4848

I have changed it . Please check.


Update: Show ruleId in tips

Thank you for the excellent extension!
To show ruleId is helpful to developers.

If people want to know the rule's details, they can search with the
ruleId.
If people want to disable the warning, they can write a
disable-comment with the ruleId.

So I'd like to show ruleId in tips.

What should I do for this?

Thank you!

Thank you!!


Tellurium crashes Python when it tries to load a broken sbml

When tellurium tries to load a broken sbml, Python crashes and burns. We should handle this class of errors properly:
Steps to reproduce:
# shell
conda create --name py38 python=3.8
conda activate py38
pip install tellurium
ipython

# Ipython
import tellurium as te
sbml = """<?xml version="1.0" encoding="UTF-8"?>
<sbml xmlns="http://www.sbml.org/sbml/level3/version1/core" level="3" version="1">
  <model metaid="x" id="x">
    <listOfCompartments>
      <compartment sboTerm="SBO:0000410" id="default_compartment" spatialDimensions="3" size="1" constant="true"/>
    </listOfCompartments>
    <listOfSpecies>
      <species id="S1" compartment="default_compartment" initialConcentration="10" hasOnlySubstanceUnits="false" boundaryCondition="false" constant="false"/>
      <species id="S2" compartment="default_compartment" initialConcentration="1" hasOnlySubstanceUnits="false" boundaryCondition="false" constant="false"/>
    </listOfSpecies>
    <listOfParameters>
      <parameter id="kf" value="0.1" constant="true"/>
      <parameter id="kb" value="0.01" constant="true"/>
    </listOfParameters>
    <listOfReactions>
      <reaction id="_J0" reversible="false" fast="false">
        <listOfReactants>
          <speciesReference species="S1" stoichiometry="1" constant="true"/>
        </listOfReactants>
        <listOfProducts>
          <speciesReference species="S2" stoichiometry="1" constant="true"/>
        </listOfProducts>
        <kineticLaw>
          <math xmlns="http://www.w3.org/1998/Math/MathML">
            <apply>
              <times/>
              <ci> kf </ci>
              <ci> S1 </ci>
            </apply>
          </math>
        </kineticLaw>
      </reaction>
      <reaction id="_J1" reversible="false" fast="false">
        <listOfReactants>
          <speciesReference species="S2" stoichiometry="1" constant="true"/>
        </listOfReactants>
        <listOfProducts>
          <speciesReference species="S1" stoichiometry="1" constant="true"/>
        </listOfProducts>
        <kineticLaw>
          <math xmlns="http://www.w3.org/1998/Math/MathML">
            <apply>
              <times/>
              <ci> kb </ci>
              <ci> S2 </ci>
            </apply>
          </math>
        </kineticLaw>
      </reaction>
    </listOfReactions>
  </model>
</sbml>
2.0.6
"""

m = te.loads(sbml)

@hsauro pretty sure I fixed the blank line problem by chomping leading and trailing whites pace. Could only be in the experimental release though.

Okay I found a package which shows errors with this file as well:
ERROR:sbmlutils.validation:E3: SBML identifier consistency (core, L395, code)
[Error] Duplicate 'id' attribute value
Could this be the issue?

This could indeed be the problem with your model, yes:  all 'id' values among most SBML elements must be unique.
You could send your model to the SBML online validator at
http://constraint.caltech.edu:8888/validator_servlet/index.jsp
which should give you more information about which ids are duplicated.
This is also, to be clear, a bug in Tellurium/roadrunner:  it shouldn't crash when given an invalid SBML model; it should just report what the problem is.  But as a workaround until we fix that, fixing the validation errors in your model beforehand should work.

Perfect, thanks for the link!


sap-tv link broken

What this PR does / why we need it:
sap-tv.com video link is broken / Requires an updated link
Which issue(s) this PR fixes:
Fixes #
Updated link of sap-tv.com
Special notes for your reviewer:
Release note:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@karthikworld , could you please sign the cla?
Ref https://cla-assistant.io/gardener/gardener?pullRequest=1766

@ialidzhikov  Signed up the CLA


Add basic UI to Preloader and Landing Pages

Spinny Loader
Menu / Hamburger
Button
Video Player
Share Buttons

These have been separated out.


It would be awesome to have screenshots in docs

Hi,
I like the new documentation pages, but I wish there were screenshots on each page. This would make it much easier for users to understand what they will get by following the instructions.
Thank you very much!

Actually this is something what I was already considering but the problem is with the amount of resources (my time) which will such a small thing require. I did a quick math and it would require uploading around 40 screenshots which will already take a lot of time. The hardest part would be keeping the screenshot in sync with the current design.  Each time design is changed, I have to reupload screenshots reflecting new changes.
To solve this problem, I decided in the past to create a public demo repository where you can see all the combinations which Unfold provides. I understand this is not optimal solution but I want to focus on shipping new things for now.

An alternative would be to create a page for each functionality on the demo instance and add a link to that website.
But having a screenshot is extremely valuable in my opinion, even though might not be up to date all the time.. the idea is to help developers understand easier what they will get if they use that Unfold feature..


More examples

Need more examples to show what can be done with the plugin.
Please consider creating your own examples and publishing them using Github Gists: https://gist.github.com/ and http://bl.ocks.org/

It would be great to see an example map where points don't increase or decrease in size based on zoom level. In other words, points always stay the same size.
In addition, it would be good to see an example with a infoWindow attached to the marker.

@tdaubs in the second example: http://bl.ocks.org/xEviL/0c4f628645c6c21c8b3a the stroke width is kept 1px regardless of the zoom, using:
upd.attr('stroke-width', 1 / proj.scale);

You can use similar technique to keep whatever you're drawing in sync with zoom.

Hi, excellent knowledge/work, do you do freelance? I need a piece code, an editor, to put/edit/delete links to leaflet+d3 maps
<EMAIL_ADDRESS>


a option to increase space between player and health indicator

in some servers health indicator overlaps with player name, so i think you can solve this issue by adding a option to increase gap between player and health indicator.

Added in 1.1.0


Firebase and IDFA Apple Review

This is not an issue but a question :
Firebase includes admob and when you type fgrep -R advertisingIdentifier . You can see :

Binary file ./Pods/FirebaseAnalytics/Frameworks/FirebaseAnalytics.framework/FirebaseAnalytics matches

So even if you don't use Admob, the framework has "advertisingIdentifier" which could be a reason for Apple to reject your app. I can't find a clear answer saying "You should check YES to IDFA and cases 1 ... if you use Firebase / or NO" in case you don't use it.
Does anyone know what to do ? Thanks

Having such string doesn't mean that it uses advertisingIdentifier wrongly or Apple will reject your apps. I haven't seen Apple rejects apps with Analytics because of that. Analytics SDK respects users' choice if they opt out of Ad Tracking. Also, if users turn off the Ad Tracking, "the value of the advertising identifier is 00000000-0000-0000-0000-000000000000" (https://developer.apple.com/reference/adsupport/asidentifiermanager). If you don't link Ad Support framework, Analytics won't use the IDFA.

@baolocdo Thank you so much, finally a clear answer, I couldn't find an answer about this (maybe because it was obvious) but thanks.

@Aximem @baolocdo Hello, guys!
What is your solution?
Right now I can't submit an application with FirebaseAnalytics.framework (iTunes detects advertisingIdentifier). My application is Ad-free, so I can't click "Yes, I use" near "IDFA" too...

@bushev, did your app get rejected by Apple? What is their reply? Thanks

The Analytics SDK will only use the advertisingIdentifier if and only if the AdSupport.framework is linked into your app, following the rules that Apple sets out. If you are not including AdSupport.framework, then you don't have to worry about saying "Yes, I use IDFA" before submitting to Apple.
Firebase does recommend that you do include it, even if you aren't serving ads (it doesn't enable ads in your app). It provides some additional information about your user, that you can see in your Analytics. However, it's still totally optional.
https://firebase.google.com/support/guides/analytics-adsupport

@rsattar thanks a lot. I'm trying to pass review using this https://github.com/firebase/quickstart-ios/issues/298#issuecomment-309483700 recommendation.

@rsattar Thanks for the heads up. We have linked in AdSupport.framework in our app, for the purposes of enhanced Firebase Analytics (e.g. without serving adds)
Question: After selecting Yes to "Does your app use IDFA...?"
Are you aware which options should be selected for such case?
(Thanks in advance)

Also stuck in this situation; grepping the project folder says FirebaseAnalytics.framework and libAdIdAccessLibrary.a of GoogleIDFASupport pod uses the advertisingIdentifier.

@itsmeonline Im on this situation now. Which one did u select to get approved?

@iad24 Hey, I have submitted apps for review since my comment, and got through successfully with the following:
Does this app use the Advertising Identifier (IDFA)? -- selected Yes
Then from the three additional statements that appear:
Serve advertisements within the app -- selected No
Attribute this app installation to a previously served advertisement -- selected No
Attribute an action taken within this app to a previously served advertisement -- selected Yes
Our app does not serve any ads whatsoever but does use the Firebase SDK for analytics. Hope this helps!

@iad24
Yes I can also confirm 'similar to Luke', that I have published
successfully (multiple builds) via the following settings:
Does this app use the Advertising Identifier (IDFA)? -- selected Yes

Attribute an action taken within this app to a previously served
advertisement -- selected Yes
Attribute this app installation to a previously served advertisement --
selected Yes

On 30 August 2017 at 14:26, Luke<EMAIL_ADDRESS>wrote:

@iad24 https://github.com/iad24 Hey, I have submitted apps for review
since my comment, and got through successfully with the following:
Does this app use the Advertising Identifier (IDFA)? -- selected Yes
Then from the three additional statements that appear:
Serve advertisements within the app -- selected No
Attribute this app installation to a previously served advertisement --
selected No
Attribute an action taken within this app to a previously served
advertisement -- selected Yes
Our app does not serve any ads whatsoever but does use the Firebase SDK
for analytics. Hope this helps!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/firebase/quickstart-ios/issues/266#issuecomment-325989588,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAhJ3zql4tjsPd5FB2zZuWeUnbezIAMOks5sdWMcgaJpZM4NVy2_
.

@lsalvoni @itsmeonline thanks guys =)

One more proof from me.
Just passed apple review with a new app:

app contains Firebase
app doesn't use ads in any way (only for analytics).

Then, similar steps like @lsalvoni did
Does this app use the Advertising Identifier (IDFA)? -- selected Yes
Then from the three additional statements that appear:
Serve advertisements within the app -- selected No
Attribute this app installation to a previously served advertisement -- selected No
Attribute an action taken within this app to a previously served advertisement -- selected Yes

I am not sure which Pod specs others are using, but I am using Firebase/Core only and just submitted my app with the following:
Does this app use the Advertising Identifier (IDFA)? -- selected NO!
It got approved in one day.
Hope it helps.

Hello.
I use
pod 'Firebase/Core'
pod 'Firebase/Database'

And have the same problem.
I choose that:

Does this app use the Advertising Identifier (IDFA)? -- selected Yes
Serve advertisements within the app -- selected No
Attribute this app installation to a previously served advertisement -- selected No
Attribute an action taken within this app to a previously served advertisement -- selected Yes

But I not sure that is right.

@balkarov If you are not using any Ads or IDFA in your app, meaning you are not using any Firebase APIs to deal with ads in any way I don't think you should say Yes to the IDFA question.

If I choose NO, that Apple say me my app uses IDFA. But when I remove Firebase from app then all ok.

DISCLAIMER: I am not an expert at Apple Review policies, and this is just my personal educated guess:
If you've linked the AdSupport framework, then your app is using the IDFA.
For that first question (are you serving ads), that's really up to you and if your app is serving ads
If you've linked the AdSupport framework, Firebase automatically uses this IDFA in order to attribute the app install to a previously served advertisement, so you can say yes to the second question.
If you've linked the AdSupport framework, Firebase uses this IDFA to attribute in-app purchases and ecommerce purchases to advertisements, along with any other conversion events you might have added in Analytics. So you will probably want to say yes to the third question if your app has in-app purchases.
Firebase does honor the Limit Ad Tracking setting.

Exactly, I have had the same experience with Firebase. I’m not linking adSupport framework so I answered no.

Related discussion at https://github.com/firebase/firebase-ios-sdk/issues/1686 - since iOS11, apps that link SafariServices, will implicitly link the AdSupport framework.


Add Builder Method on Expressions + Update Proc Macro

Fixes #19.
Adds a method to handle adding a new expression while keeping the variables in-sync with the other methods
I also threw #12 in here as well.
I can break them up into separate PR's if you'd like.
Fact check me on the proc macro pls. This is like my second time writing one.
I tested everything locally and it seemed to work just fine. It worked both with a manually defined struct, and with one generated by struct-patch.

Thanks for this. I'll be a bit slow on review due to other commitments, but should be able to get an initial review in the next couple of days.


Сan't manage users and permissions in the interface

Describe the bug
When trying to create a user, an error occurs.

The user is created, but no changes can be made.
When you click on a user in the list, a blank page opens.

Similar behavior is observed on the Permissions tab

To Reproduce

Go to settings
Click on 'Users'
Click on User on list

Same way for Permissions

Go to settings
Click on 'Permissions'
click on one of Permissions

Expected behavior
On another server I can manage users. And I try change env/users/reinstal - this not help me.
Server:

OS: Ubuntu 18.04.6 LTS
venv
python 3.10.13
mage 0.9.55

Browser:

Device: Mac M1
OS: Ventura 13.2.1
Browser Chrome
Version 119.0.6045.199

What I tried to do:

Reinstall everything in another venv
Change user and grant rights to all folders and files to this user, which stores venv and pipelines
Delete the database from the user folder
Substitute a database from another working project (from another server)

As a result, for the new client I had to manually add rights via datagrip

Will try to reproduce

What environment variables did you enable to turn it on?

export PATH="/opt/mage/bin/python3.10:/home/serveradmin/.local/bin:$PATH"
export REQUIRE_USER_AUTHENTICATION=1
export ULIMIT_NO_FILE=81920
export USER_CODE_PATH="/opt/*****/"
HIDE_ENV_VAR_VALUES=1
MAGE_PUBLIC_HOST="http://mysite****.net:6789/"
exec mage start my_project
I start this with bash by systemmd
and I try start only for command in env - mage start my_project - same result

No error, when open Users, response code 304 or 200
Users

Permissions

when i add new user

405 code, when i try change password in profile

Method not allowed

Any ideas?

Hello, so sorry for the delay. Can you hop in our Slack and can we do a screen share?

Sorry, I don't have a slack account. I need you to add me or we can contact via zoom, skype, telegram.

I sent you an invite. If you didn’t get it, I can send another one or you can click this: https://join.slack.com/t/mageai/shared_invite/zt-1w5sv3y3n-iUOxd0dwyNY1SW~ikpevSw

Just to follow up on this ticket. Has this issue been resolved?

Close this issue since there's no followup. Feel free to reopen it if the issue is not resolved.


Issues with decorator plugin

I have been using swiftmailer for some time time and no problems until I needed to send to several recipients and needed to use decorator plug in. The first in the replacement array is working fine. But all others just use the particulars of the first instead of their respective particulars. like {title} and {surname}. Any help will be appreciated.

Sounds like your var is not being updated.


Cats should not drink dairy milk

taking a look, this appears to be true - a lot of cats are lactose intolerant, and food also fits better imo since the variable is isHungry


Qualified importing _ctypes

To avoid error on Kernel.__del__, see also #791

Sorry to be a bother on this, but this doesn't seem to have fixed the error on my travis build! Any thoughts?

Maybe as an alternative:
import weakref
...
class Kernel(object):
...
    # old __del__:
    def _cleanup(self):
        if self._lib is not None:
            print("cleaning up, ctp:", ctp)
            ctp.FreeLibrary(self._lib._handle) if platform == 'win32' else ctp.dlclose(self._lib._handle)
            del self._lib
            self._lib = None
            if path.isfile(self.lib_file) and self.delete_cfiles:
                [remove(s) for s in [self.src_file, self.lib_file, self.log_file]]

    def compile(self, compiler):
        """ Writes kernel code to file and compiles it."""
        with open(self.src_file, 'w') as f:
            f.write(self.ccode)
        compiler.compile(self.src_file, self.lib_file, self.log_file)
        logger.info("Compiled %s ==> %s" % (self.name, self.lib_file))

        weakref.finalize(self, self._cleanup)

From the docs for weakref.finalize:

Return a callable finalizer object which will be called when obj is garbage collected. Unlike an ordinary weak reference, a finalizer will always survive until the reference object is collected, greatly simplifying lifecycle management.

A finalizer will never invoke its callback during the later part of the interpreter shutdown when module globals are liable to have been replaced by None.

But perhaps the finaliser should be registered on the Kernel object, and it can be marked dead with finalizer.detach() if Kernel.remove_lib() is called?
Thoughts?

Does that solution with finalizer work on your Travis? If so, then it might be a good solution yes!
Note that we could also use a similar approach in ParticleFile.__del__, which can experience the same problem with unlinked objects that cannot be deleted

Just tested, and yes, using the finalizer seems to clean up correctly (no files left in /tmp/parcels-1000/...) and not throw errors, both on my test container and Travis. I think it might be a more robust solution for ParticleFile too: I think if you explicitly call the finalizer object, it will be dead and won't be called again, so it implicitly has the convert_at_end logic.
I can create a new PR for my Kernel changes?

Just tested, and yes, using the finalizer seems to clean up correctly (no files left in /tmp/parcels-1000/...) and not throw errors, both on my test container and Travis. I think it might be a more robust solution for ParticleFile too: I think if you explicitly call the finalizer object, it will be dead and won't be called again, so it implicitly has the convert_at_end logic.

OK, great. That's a good solution then

I can create a new PR for my Kernel changes?

Yes please

Fixed in #794


import tensorflow as tf

import tensorflow as tf
Traceback (most recent call last):
File "", line 1, in
import tensorflow as tf
File "C:\ProgramData\Anaconda3\lib\site-packages\tensorflow_init_.py", line 22, in
from tensorflow.python import pywrap_tensorflow  # pylint: disable=unused-import
File "C:\ProgramData\Anaconda3\lib\site-packages\tensorflow\python_init_.py", line 49, in
from tensorflow.python import pywrap_tensorflow
File "C:\ProgramData\Anaconda3\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 74, in
raise ImportError(msg)
ImportError: Traceback (most recent call last):
File "C:\ProgramData\Anaconda3\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 14, in swig_import_helper
return importlib.import_module(mname)
File "C:\ProgramData\Anaconda3\lib\importlib_init_.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 985, in _gcd_import
File "", line 968, in _find_and_load
File "", line 957, in _find_and_load_unlocked
File "", line 666, in _load_unlocked
File "", line 577, in module_from_spec
File "", line 938, in create_module
File "", line 222, in _call_with_frames_removed
ImportError: DLL load failed with error code -1073741795
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\ProgramData\Anaconda3\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\ProgramData\Anaconda3\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 17, in
_pywrap_tensorflow_internal = swig_import_helper()
File "C:\ProgramData\Anaconda3\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 16, in swig_import_helper
return importlib.import_module('pywrap_tensorflow_internal')
File "C:\ProgramData\Anaconda3\lib\importlib_init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
ImportError: No module named '_pywrap_tensorflow_internal'
Failed to load the native TensorFlow runtime.
See https://www.tensorflow.org/install/install_sources#common_installation_problems
for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.

Duplicate of https://github.com/tensorflow/tensorflow/issues/19584

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce
Mobile device


Fix multi-token type hints in line formatter

The line formatter handles the spacing of = inside of a function declaration with a type hint by looking two tokens behind the = to see if there's a colon. This works for simple declarations like def foo(a: str = "bar"), but does not work for more complicated types such as def foo(a: Union[int, str] = "bar").
A more correct method would be to look for a colon anywhere behind the = until reaching a ( or ,.

This is unfortunately not as simple as I originally thought, since you'd reach the comma in Union[int, str] before hitting the colon and then choose not to add spacing.


abiding-ifacconf:0.1.0

I am submitting

[x] a new package
[ ] an update for a package

Description: An IFAC-style paper template to publish at conferences for International Federation of Automatic Control.

I have read and followed the submission guidelines and, in particular, I

[x] selected a name that isn't the most obvious or canonical name for what the package does
[x] added a typst.toml file with all required keys
[x] added a README.md with documentation for my package
[x] have chosen a license and added a LICENSE file or linked one in my README.md
[x] tested my package locally on my system and it worked
[x] excluded PDFs or README images, if any, but not the LICENSE

[x] ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

Thanks, looks very nice!


Remove relaying messages directly from blocks

There are currently two functions for relaying messages. One that proves a message directly in a block and another that adds the extra step of proving a block exists in the history of another block first. Since we are now moving to a regular commit process, the direct block relaying option is hardly ever going to be used. It makes more sense to just remove it and simplify the code. We can also simplify the function name to just relayMessage too and we should also take this opportunity to change the name of the 'depositETH' function to not refer to ETH directly (either just deposit or sendDeposit).

Resolved in #30


Impurity calculation question

Here is the get_impurity method in decision_tree.rs:
for pair in sorted_data.iter() {
let (index, feature_value) = *pair;
if feature_value == VALUE_TYPE_UNKNOWN {
let cv: &CacheValue = &cache.cache_value[index];
s += cv.s;
ss += cv.ss;
c += cv.c;
unknown += 1;
} else {
break;
}
}
I wanna ask why use break instead of continue to break the loop. I think the purpose of this code is to count and calculate the unknown value of samples.

@litongxin1991

The sorted_data is sorted in ascending order based on the feature_value.  And the VALUE_TYPE_UNKNOWN equals to the VALUE_TYPE_MIN, that means, it's the minimum f32/f64 value.
The samples with unknown feature value will be in the beginning of the sorted_data. In the loop,  when current sample has non-unknown feature value, all the samples with unknown feature value has been counted, so it's ok to break the loop.


Refactor gameboy function to cpu, mmu & add cpu instruction debugger

gameboy.h __gb_execute_cb >> cpu.h __cpu_execute_cb
gameboy.h __gb_step_cpu >>  cpu.h cpu_step
gameboy.h __gb_draw_line >> cpu.h __gb_draw_line
gameboy.h __gb_write >>  mmu.h mmu_write
gameboy.h __gb_read >>  mmu.h mmu_read

Please read this article carefully and amend the commit(s): https://chris.beams.io/posts/git-commit/
I expect one pull request is associated with one functional change. e.g. split CPU emulation from single header. Don't mix several functional changes into single pull request and/or git commit. Otherwise, it is hard to perform code review.

I tend to close this pull request and wait for the incoming ones which enforce the above rules.

Ok I will get it done
On Thu, Dec 17, 2020 at 6:19 PM Jim Huang<EMAIL_ADDRESS>wrote:

I tend to close this pull request and wait for the incoming ones which
enforce the above rules.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sysprog21/gameboy-emu/pull/5#issuecomment-747348128,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIDGKIBDFFVA2JI5VFARTHLSVHLMXANCNFSM4U7KJNEA
.


Make NewTicker panic if d<=0, like time.NewTicker.

This more closely follows the standard library function behavior.
It is directly copied from the standard library: https://cs.opensource.google/go/go/+/refs/tags/go1.20.3:src/time/tick.go;l=23-25
Although panicking is generally bad, it is preferable to mimic the standard library so users see the same behavior between clockwork and the golang standard library.
Without this, some tests can pass with a no op where a real time.Ticker implementation would crash.

Hey @sagikazarmark, Wanted to send a friendly ping on this. Would you be willing to share your thoughts on this?
This had caught me once a few years ago, but I was lazy at the time and didn't upstream it.


rgw: add support for multiple rgw instances on a single host

With this, we could have multiple rgw instances on a single host
with a single run, don't have to use rgw-standalone.yml which does not
seems able to bind ports separately.
And if you don't want to have multiple rgw instances, just do not
define 'rgw_instances'.
Not compatible with Multi-Site yet.
Signed-off-by: guihecheng<EMAIL_ADDRESS>

@leseb thanks for your comments, and I think only use the  'rgw_instances' and set it default to 1 is possible, I'll update with this idea and try to and the test stuff as you pointed.

@guihecheng thanks

@leseb updated a single variable version, s/rgw_instances/radosgw_instances/g, thanks :)

jenkins test dev-docker_cluster

@guihecheng please rebase, thanks.

@leseb ok, I'll rebase soon.

@leseb patch rebased, but I found that the jenkins job failed, but this works in my own environment, is it related to the ansible version? I am using ansible2.7.2.

The job ran on 2.7.4. Looks like a jinja error.

@leseb sorry, but I failed to reproduce the problem reflected in the CI test, my env is very close to the testing env:
CentOS 7.5(1804)
ansible 2.7.4
I googled a lot about the ERROR :
coercing to Unicode: need string or buffer, list found
But I didn't got any workable solutions, It seems to point to the set_fact line above
https://github.com/ceph/ceph-ansible/blob/b13301ef90df6a68f8d270b478421bdc8fea4555/roles/ceph-facts/tasks/facts.yml#L275
Any ideas on this?

@guihecheng please, share the full log with verbose mode

@guits below is the error log from the CI result, I haven't reproduced in my own environment yet.
https://2.jenkins.ceph.com/job/ceph-ansible-prs-dev-purge_cluster_non_container/15/consoleFull#-729725784b5dd38fa-a56e-4233-a5ca-584604e56e3a

Here the issue above is solved by adopting the advices from @guits, thanks very much!
And it seems I should fix the test functions, since the rgw instances' names are changed by this patch.

e....so the non-container stuff passed the tests, now I am going to add the containerized support.

hi,@leseb @guits, here I've got an failed case , and it points to a failed ceph-rgw container.
As I detected, the container failed after startup and will restart again because of the Restart=always config.
I'm now checking why the ceph-rgw container failed.


Commented lab association prompt

commented lab association prompt function since its breaking installation and needs user interaction. Need to have function without any user interaction for uninterrupted installation of lab

@anilsingla As discussed, the lab env config file has to populated from the genesis file, please update the BLIman code accordingly.


botocore/data/efs/2015-02-01/waiters-2.json

What does this PR provide?
This PR adds the following waiters related to the EFS service:

EFSAvailable
EFSDeleted
MountTargetAvailable
MountTargetDeleted

These were previously unavailable and can now be used to make
blocking calls in order to create/delete the EFS and Mount Target
resources.

Codecov Report

Merging #1550 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1550      +/-   ##
===========================================
- Coverage    91.94%   91.91%   -0.04%
===========================================
  Files           50       50
  Lines         9024     9024
===========================================
- Hits          8297     8294       -3
- Misses         727      730       +3

Impacted Files
Coverage Δ

botocore/credentials.py
98.4% <0%> (-0.4%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5028b21...bf2b201. Read the comment docs.

Euh.. No idea why the codecov/project check is failing?
https://codecov.io/gh/boto/botocore/compare/5028b2106e078c4257be23db0905ac9a1593acf6...bf2b201b905613d658c61ab2c6477df9d8f993a6/changes
I did not change that file...

bump @awstools

bump @awstools

No response what so ever from team botocore, I have fixed this in code somewhere else, so I will be closing this PR.


use sphinx-gallery for example page generation

see https://github.com/jcrudy/py-earth/pull/77/files for a project that recently switched too.
I added support for mayavi. We to add support for slow example.
any volunteer?

I can do it at the sprint if not before. I don't think there's any rush.

sure. I want to make sure we don't forget

marked as 0.10, that's an easy way to make sure it gets done in the next 4 months :)

closes for #2279


Spring Boot Layered JAR for utilization of Docker build cache

Spring Boot Layered JAR for utilization of Docker build cache
Moved busybox from /bin to /usr/bin
Reduced size of application and its docker image by removing unused Spring Boot dependencies
Eager initialization of application (of Spring Boot MVC servlet)

Refer to pull request #9 for the minor fixes for this pull request.


User profile displays a list of all friends

Addresses issue https://github.com/uchicago-cs/chigame/issues/144
When a user goes to their profile page, they can see a table of their friends' usernames. The goal of this issue is first to set up a table view of all of a user's friends so that in the future, new features can be implemented in this table, such as friend rankings for who has won the most number of tournaments, etc. If the user is an admin or the User instance does not have a corresponding UserProfile instance, then the friends table will not show up on the profile page.

Update: we met two times during the sprint to work on this issue. The first was on November 8th when we decided what the specific goal of this task was. We wanted a user to be able to see their friends so that when the tournament pages are implemented, users can see their friends' rankings, etc. We met again on November 12 to finalize the task and figure out an issue that we had, which was the scenario where a User did not have a corresponding UserProfile instance.

Update November 30: Fixed merge conflicts and changed the position of the if statement on user_detail.html so that the Friends table only shows up if the user has friends.

The new commit changes the functionality so that admins can view a page with all users with the capability for users to see their friends provided in #357

Closing statement: the issue is completed. When a user goes to their profile page, if the user is not logged in as an admin and they have a corresponding UserProfile, they are able to see a table of all their current friends. This feature will allow future features to be implemented, such as seeing which friend is most highly ranked, etc. All the assignees worked together to write the code for this but I was in charge of making the GitHub PR.

Issue Score: Excellent
Comments:
Great job creating the FriendsTable. Like I said in the review comment, I'm marking this as minor.


Guava dependency

Guava has very poor binary compatibility so it is great disadvantage that Pebble use it as leads to unresolvable jar-hell.

I believe Guava is currently only used for the Caching functionality. While it would technically be possible to make it optional, working without a Template Cache would cause a significant performance hit.

Perhaps it should be some simple default cache and ability to customize cache service so user can include any cache

It is correct that guava is ONLY used for it's caching purposes and I've been careful to make sure it didn't creep it's way into other parts of the application. Implementing reliable, efficient, and highly customizable data structures to be used for caching is hard so I decided to delegate it to a third party library.
I'm open to the idea of replacing guava with something else but I don't want the burden of maintaining a complicated custom-built cache service and it's important that Pebble provide's a reasonable out-of-the-box default.

Have you considered using maven-shade-plugin and its relocation feature to "hide" Guava? I don't know if it's a good idea, I'm just asking...
I guess it would need a couple of unit tests to make sure this relocation doesn't break anything though. For example, if Guava dynamically loads some classes using their names, relocation may fail.

I did not know about that feature; I'll have to look into it. Thanks!

I don't think it is worth it for Pebble to be yet another library that bundles its own version of Guava.
Many bigger libraries already do that if they can't get away without it, but I don't think it's justified here.
Bundling Guava has two major disadvantages: one in build time, as the size of the JAR is incresed from 100-something-kb to over 2MB (the current size of Guava), and another in runtime, as you're causing what's effectively the same set of classes to be loaded multiple times.
If removing the explicit Guava dependency is that important, I would suggest either abstract the Cache, or do without it completely (by falling back to a simple ConcurrentHashMap implementation if Guava is not in the classpath).

Another alternative to Guava (although only available for Java 8) could be caffeine.
It provides a Cache API that is very similar to the one provided by Guava, and builds on its implementation (I believe the project to be maintained by the same Googlers that created Guava in the first place).

Yeah, you make some good points. It doesn't sound like it's worth it to bundle guava. That caffeine library does sound promising and I am wanting to switch to Java 8 at some point this year. It probably won't happen soon but I'll leave this task open in case there any other opinions on the matter.

I have to say that I really like the fact that Pebble works with Java 7... I'm launching a new web framework soon and I plan on making Pebble the main templating engine. But I want the framework to be compatible with Java7, at least for the first version. In general, I think more people will be able to use Pebble if you stay compatible with Java7 a little longer... But if you have real good reasons to "upgrade", I understand too!
@jcarvalho

"...and another in runtime, as you're causing what's effectively the same set of classes to be loaded multiple times."

Not true with relocation...

At this point in time I don't have a good reason to upgrade to java 8, it's just been something on the back of my mind, so your feedback on the matter is helpful. I'll keep that in mind, thanks.

Not true with relocation...

I might have understood it wrong, but doesn't relocation mean that Guava will be instead packaged as com.mbosecke.com.google.guava?
Because if that's the case, there are already several libraries who do that as well. For instance, if Pebble did that, and I bundled it in an application with both Jersey and Guava, I'd have 3 similar versions of Guava's classes (one rebundled in Pebble, one rebundled in Jersey, and the actual Guava one).

@jcarvalho Sorry about that, I updated my comment before reading your reply. I understand what you mean and you're right.

Those of us on Google App Engine are stuck with Java7 for now - they're working on Java8, but there's no announced timeline. That said, Pebble v2 doesn't work on GAE, so I guess we're stuck with 1.6 (or a fork) anyways.
Personally I think the right answer to this issue is to keep using Guava as-is and update to the latest with each release. The solution to jar hell is to keep moving forwards. Google manages to tolerate Guava's degree of binary compatibility and their codebase is certainly bigger than any of ours...

How I'd do it:
A PebbleCache interface should be introduced, its use shall be optional (off by default), and external package shall be provided with a default guava based implementation. Its version shall be the same as of the guava version it uses.
No shading and other hacks are needed. A different resource needs to be published to the maven repository.

It seems that Pebble only constructs Guava's cache in one place and uses it in another. It appears that only the maximum size is used, but its also not clear if other features of the cache are exploited by users.
To the best of my knowledge, no further changes to Guava's cache are planned. However Guava will be evolving rapidly again once it splits into an Android and Java 8 library. Unfortunately the cache under performs because some critical optimizations were planned but never introduced. Those of us who worked on Guava's cache are no longer involved and, now from the outside, I have been completely unsuccessful in getting changes made to correct its flaws.
If Pebble only needs a concurrent, bounded map then you may want to consider ConcurrentLinkedHashMap. That project proved out many of the foundational ideas adopted by Guava, though with higher performance. It is JDK6 compatible, still widely used, small, and has a stable API. However it has reached its EOL due to Caffeine and Guava. It does not support features like expiration, computation, etc. which have to be built on top via decorators.
A custom Cache interface with a default implementation seems reasonable. One might be tempted to adopted JCache but from my experience it is buggy, poorly designed, and a step backwards. I believe it is not GAE compatible because the official API changed since the JSR's original 10+ year old API by the same authors.

I don't want to spam, but since I told here I was working on a new web framework, here it is, first version : https://www.spincast.org .
Pebble if the default templating engine. Thanks a lot for Pebble, to all contributors!


Remove Job Type docker_params

Remove the docker_params field from the job type model. This is a security concern as it allows an algorithm author to inject arbitrary Docker parameters into their job containers.
Before starting this issue, make sure to implement alternative methods to cover any use cases for this (e.g. configurable settings for job types, setting shared memory size, mounting in extra data).

The job_type docker_params field will be removed as part of removing the v5 APIs.

Closed via #1534


Adding testing framework for rendering upstream to base

This pull request attempts to fill a gap in KOTS test coverage. We have very little coverage of combinations of application yaml and upstream configuration.
Currently kots has unit tests and e2e tests. Unit tests for renderReplicated can cover the same but are cumbersome to write because they are in code. E2e tests also can cover this but are slow.
This adds a testing framework for testing kots rendering of upstream yaml to base yaml. To add tests, the developer must include yaml files in the directories upstream and base, which include input yaml and expected output yaml respectively.

[ch36201]


Error when running

I get his error when I try to run it in a local dev env using vite:
npx react-scan localhost:1213
┌  [·] React Scan
node:internal/process/promises:391
    triggerUncaughtException(err, true /* fromPromise */);
    ^

page.goto: net::ERR_EMPTY_RESPONSE at http://localhost:1213
Call log:
  - navigating to "localhost:1213", waiting until "load"

woops sorry i was actually using https


isIndex in route config is not handled correctly.

Fixed by https://github.com/supnate/rekit-boilerplate/commit/47c4871b90dd4d8d4a3a85713d173bb9c41d6db3 .


Update esbuild to v0.18.20

Describe the solution
Update esbuild on next major wrangler update. We can update to 19 once this issue gets resolved

Oh I was literally about to raise this, since it’ll unlock support for Stage 3 Decorators. Thank you!

The latest esbuild is 0.20.1. Are we still limited to 0.18+?

Until that issue is resolved, yes. Has anyone in DevProd looked into putting up a PR against esbuild?


fira-go: init at 1.001

Description of changes
Add FiraGo, an extension to the Fira Sans font.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

On the homepage there is a (non-github) download link for 1.001, maybe it would make sense to use that version?

Thanks for the heads up. The 1.001 version is also available on GitHub but is not marked as a release. I updated the link.

Thanks I missed that. Updated.


Use threading lock object instead of commands_working counter

Fixes issue in #426
Instead of checking for the existence of the git index.lock file we can use a lock object from the threading module in the CommandThread class. It is unlikely that a git command is being run in parallel outside of the user using the sublime plugin so this should be ok.
are_commands_working was only used in one place and I'm guessing that the incrementing and decrementing of the counter in CommandThread is not thread safe.

Nice! Much nicer than retrying!


Update README

Update README with all working commands

Working on this

I added 10 new commands + examples, still need 2 more to have full coverage

Working on this issue, filling in the missing commands


[DEVOPS-22-165]  Switch to Nix for cardano-sl build used for genesis generation

We are slowly switching all deployment-related operations to operate from an environment established by nix-shell entered in iohk-nixops.
This is a part of this unification process, and it makes the genesis generation script use Nix to provide the cardano-sl build.
This makes the routine cd pkgs; ./generate.sh invocation (inside iohk-nixops) a prerequisite for genesis itself -- but this already is a prerequisite for deployment anyway.
Purely dev-based scenarios will change, though.

This script should really be refactored and part of iohk-nixops I think.
But for now we can use this change with nix-shell.

@domenkozar, the errors were transient, network-related -- restarting helped

@domenkozar, the CI passed --  a simple restart helped

@domenkozar, can you think of any further actions we need here?

yes, this has to wait until we have stack2nix based PRs as currently stack is the tool for building cardano-sl.

I changed base branch to cardano-sl-0.5. It shouldn't change anything. cardano-sl-0.5-rc will be removed.

yes, this has to wait until we have stack2nix based PRs as currently stack is the tool for building cardano-sl.
Agree

Ping all

Is it obsolete now?

@georgeee Is scripts/generate/genesis.sh obsolete now? If so, we can close this.


feat(accessibility): add focus accessibility action support

Summary:
I am working on an app that needs to check for accessibility focus events on TalkBack on Android.
There is no way right now to know when a view/text was focused with TalkBack.
Changelog:
[ANDROID] [ADDED] - add accessibilityFocus action support
Test Plan:

By adding
diff --git a/packages/rn-tester/js/components/RNTTitleBar.js b/packages/rn-tester/js/components/RNTTitleBar.js
index d6094056e75..68e35c547b4 100644
--- a/packages/rn-tester/js/components/RNTTitleBar.js
+++ b/packages/rn-tester/js/components/RNTTitleBar.js
@@ -73,7 +73,12 @@ const HeaderAndroid = ({
     <SafeAreaView>
       <View style={[styles.toolbar, {backgroundColor: theme.BackgroundColor}]}>
         <View style={styles.toolbarCenter}>
-          <Text style={[styles.title, {color: theme.LabelColor}]}>{title}</Text>
+          <Text
+            style={[styles.title, {color: theme.LabelColor}]}
+            accessibilityActions={[{ name: 'accessibilityFocus' }]}
+            accessible
+            onAccessibilityAction={(event) => { console.log('accessibility focus on title')}}
+          >{title}</Text>
           {documentationURL && (
             <RNTesterDocumentationURL documentationURL={documentationURL} />
           )}

and
diff --git a/packages/rn-tester/js/components/RNTPressableRow.js b/packages/rn-tester/js/components/RNTPressableRow.js
index 3db9460e152..62ffcbef4d4 100644
--- a/packages/rn-tester/js/components/RNTPressableRow.js
+++ b/packages/rn-tester/js/components/RNTPressableRow.js
@@ -53,6 +53,8 @@ export default function RNTPressableRow({
           ? {backgroundColor: theme.SecondarySystemFillColor}
           : {backgroundColor: theme.SecondaryGroupedBackgroundColor},
       ]}
+      accessibilityActions={[{name: 'accessibilityFocus'}]}
+      onAccessibilityAction={() => {console.log('accessibility focus on pressable')}}
       onPress={onPress}>
       <View style={styles.topRowStyle}>
         <RNTesterComponentTitle>{title}</RNTesterComponentTitle>

I get
https://github.com/facebook/react-native/assets/6313316/574d5fb1-60f7-4230-ad17-790bb70cc6f3
TODO

[ ] support iOS as well (I am waiting to be sure that this change is OK on Android)
[ ] update the documentation

Hey 👋
How can I get some attention to this PR? 😊
I'd like to at least know if it makes sense or not.
Thanks!

Hey! This PR is still relevant. I'd love to have some feedback on it 😁


Finish REAME file

This file deserves comprehensive yet on to the point content.

You should fix the issue asap.


Update spark-core to 2.4.8

Updates org.apache.spark:spark-core from 2.4.7 to 2.4.8.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.apache.spark", artifactId = "spark-core" } ]

labels: library-update, semver-patch

Codecov Report

Merging #970 (d113ec2) into develop (11493f3) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #970      +/-   ##
===========================================
- Coverage    89.67%   89.65%   -0.03%
===========================================
  Files          119      119
  Lines         9871     9871
  Branches       511      511
===========================================
- Hits          8852     8850       -2
- Misses        1019     1021       +2

Impacted Files
Coverage Δ

...in/scala/com/twitter/algebird/scalacheck/Gen.scala
91.66% <0.00%> (-8.34%)
:arrow_down:

.../main/scala/com/twitter/algebird/Applicative.scala
51.72% <0.00%> (-3.45%)
:arrow_down:

...src/main/scala/com/twitter/algebird/Interval.scala
81.73% <0.00%> (-1.74%)
:arrow_down:

.../scala/com/twitter/algebird/immutable/BitSet.scala
96.35% <0.00%> (-0.43%)
:arrow_down:

.../main/scala/com/twitter/algebird/HyperLogLog.scala
90.04% <0.00%> (+0.43%)
:arrow_up:

.../main/scala/com/twitter/algebird/BloomFilter.scala
95.13% <0.00%> (+1.32%)
:arrow_up:

.../main/scala/com/twitter/algebird/Approximate.scala
90.32% <0.00%> (+1.61%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11493f3...d113ec2. Read the comment docs.


Issue creating UFS file without a parent directory

Alluxio Version:
2.x
Describe the bug
We have been using default CreateOptions when creating a UFS file. This can fail in some configuration when a file is written to an Alluxio directory not backed by a UFS one.
To Reproduce
Create a file in Alluxio with CACHE_THROUGH and under a directory not backed by UFS.
Expected behavior
Creation should succeed and the parent directory should be created in UFS.
Urgency
Medium. Some data migration tasks may fail.
Additional context
N/A

fixed by https://github.com/Alluxio/alluxio/commit/81070b986ec0f5baecbd3156adace629a83df369


Scala Common Enrich: add adapter to pre-process Threat Stack webhooks

http://blog.threatstack.com/the-new-webhook-api-unleashing-the-power-of-real-time-alerts

Migrated to https://github.com/snowplow/enrich/issues/113


adding back the script tag that was inadvertently removed in #2350

Whoops, sorry!

@arkon I should have caught it... thanks @reidka

:-)  I'm feeling useful.


Add validation losses

rebased onto master, will merge this after I'm happy that the validation losses works


Add PHP RPC Lib Follow up

Project Abstract

PHP-RPC-Lib smart contract extension
follow up https://github.com/w3f/Grants-Program/pull/622

Grant level

[x] Level 1:  Up to $10,000, 2 approvals
[ ] Level 2:  Up to $30,000, 3 approvals
[ ] Level 3:  Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

[x] The application template has been copied and aptly renamed (project_name.md).
[x] I have read the application guidelines.
[x] A BTC, Ethereum (USDC/DAI) or Polkadot/Kusama (aUSD/USDT) address for the payment of the milestones is provided in the application.
[x] The software delivered for this grant will be released under an open-source license specified in the application.
[x] The initial PR contains only one commit (squash and force-push if needed).
[x] The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
[ ] I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for submitting this application.
One question from my end: how does your project differ from https://github.com/nitor-infotech-oss/parity-substrate-interface?
Thank you!

@randombishop Thank you for reply, parity-substrate-interface simply wraps the rpc and does not parse the return value. In addition, there is no support for wsam contract
https://github.com/gmajor-encrypt/php-substrate-api is more like a PHP version of polkadot.js package. He has a more comprehensive Data query and codec and transaction sending

@gmajor-encrypt Thanks for the clarification.

@Noc2 Hey, I have modified my project details, if there are still deficiencies, please tell me


1001 patient digest

Description
Jira Ticket: SARAALERT-1001
Creates an hourly email digest containing links to all patients reported as symptomatic in the last hour, delivered to superusers, public health users, and public health enrollers. The email is opt-in by jurisdiction: there is a nullable boolean field for the jurisdiction model called "send_digest", which defaults to false and determines whether the digest is sent.
(Feature) Demo/Screenshots

Important Changes
app/jobs/send_patient_digest_job.rb - new file containing the logic for the job.
app/mailers/user_mailer.rb - has the logic to send the email
app/views/user_mailer/send_patient_digest_job_email.html.erb - format of the email.
Testing
This fix was tested on the following browsers (submitter must check all those that apply):

[ ] Chrome
[x] Firefox
[ ] Safari
[ ] IE11

To verify the email job, run the command: bundle exec rake mailers:send_patient_digest. You will first have to set the send_digest variable of a jurisdiction in the database to true.
To verify end-to-end: modify the schedule.rb file at line 34 to a shorter timeframe (every 1.minutes, for instance), refresh the crontab, and run the server.

I'm a little concerned with sending full patient names outside the application. Should we be sending full patient names?

@Bialogs we aren't anymore, I just haven't updated the screencaps with the latest modifications. I switched to full urls per Adam's requested changes


Python Exception Types

I noticed that if input is too long in Python an Exception is thrown, but it's a plain Exception, not a ValueError or something. I see in the Rust code there are a variety of specific error types.
I'm not familiar with Rust, but surely it's possible to have the Python code throw something more specific like a InputTooLongException?

We will try to use better exception types later

is it possible to u16 -> u32 or more?
cant use for large text

@gulldan Your question is not actually related to the main issue here, which is not about length but types. You should open a new issue.
Separately, from experience, tokenizers like this aren't designed for long inputs like that and you should split yours up into multiple calls.

Adding to @polm, making the max sentence length to be u32::MAX will make it possible for Sudachi to crash with OOM because memory usage for long sentences will be very significant.
Also, getting to the original issue, I think that I changed all usages of Python Exception type to SudachiException during last 3-4 versions. The next version will fix last couple of usages.
SudachiError will be used instead.

Using a single generic error feels a little too general, but it's much better than a full Exception - thanks! I'll go ahead and close this.


Adding a sparsity regularizer

I've implemented a sparsity regularizer which seems to be working. If there's interest and someone can offer guidance, I can modify it as needed before submitting a pull request. I'd have it done fairly quickly once the semester ends (semester ends in ~10 days).
I used this to implement a sparse autoencoder. I think it works because on normalized data 3D (subtracted mean, divided by standard dev), with the sparsity parameter being 0 and the coefficient being 1, ADAM couldn't achieve better than 1 MSE (which is what we'd expect). I would need to implement real test cases though.
Code is below:
Update 1: Code is not currently working. If anyone can offer guidance, I'd appreciate it
Update 2: Code works! (I think).
from keras.regularizers import l2, ActivityRegularizer
import keras.backend as K

def kl_divergence(s_hat, s):
    s_hat += 10 ** -5
    val = s * K.log(s/s_hat) + (1 - s) * K.log((1 - s)/(1 - s_hat))
    return val

class SparsityRegularizer(ActivityRegularizer):
    def __init__(self, kl_coef=0.01, sparsity_param=0.05):
        self.coef = K.cast_to_floatx(kl_coef)
        self.target_sparsity = K.cast_to_floatx(sparsity_param)
        self.uses_learning_phase = True

    def __call__(self, loss):
        if not hasattr(self, 'layer'):
            raise Exception('Need to call `set_layer` on '
                            'SparsityRegularizer instance '
                            'before calling the instance.')
        regularized_loss = loss
        for i in range(len(self.layer.inbound_nodes)):
            output = self.layer.get_output_at(i)
            regularized_loss += self.coef * K.sum(kl_divergence(K.mean(output, 0), self.target_sparsity))
        return K.in_train_phase(regularized_loss, loss)

    def get_config(self):
        return {'name' : self.__class__.__name__,
                'coef' : self.coef,
                'sparsity_param' : self.target_sparsity}

Hi, does anyone know how to properly use set_layer() in the activity regularizer implementation? I can't find it documented anywhere.


Move oxide directory to root, remove InstanceCommandLines from oxide.config.json

This would allow for a more universal setup and easier to understand per game. Migration should only happen if +/-oxide.dir is NOT set in the command-line.

Implemented in the latest snapshot.


Update README.md

I guess commit rights changed upon repo name change?

yea, gave you the commit rights again. you should have gotten an invite to join the torch org or something

Just got it, thanks.


test(stress): Fix flaky test

Fixes a flaky test point values with a leading zero (0 or 0i) are generated
=== RUN   Test_typeArr
--- FAIL: Test_typeArr (0.00s)
    stress_test.go:86: Expected line protocol int got 0i

@zeebo you're right, changing it


[App] Resolve bug with download

What does this PR do?

This resolves a bug discovered while running the demo. The path of the objects was trailing and concatenation with destination path didn't work as expected.
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

The diff in this PR is empty


Wrong email address for MA State Sen. Becca Rausch

State Senator Rausch's email address is just<EMAIL_ADDRESS>https://openstates.org/person/rebecca-rausch-7ekOeXPYLP0nzyw4cNGdkX/.

Anyone here?

if you can submit a PR that would be great, otherwise we'll get to this in
the next batch of updates
On Sat, Aug 17, 2019, 7:19 PM JonathanCohn<EMAIL_ADDRESS>wrote:

Anyone here?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openstates/people/issues/166?email_source=notifications&email_token=AAAB6YSBO5MAXZDVPRAJBFLQFCBORA5CNFSM4IJBSOH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QVF4A#issuecomment-522277616,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAB6YXEHFR74QJ5C7M5TULQFCBORANCNFSM4IJBSOHQ
.

Thanks! What would be the proper coding for this in the PR drop-downs?
On Sat, Aug 17, 2019 at 10:17 PM James Turk<EMAIL_ADDRESS>wrote:

if you can submit a PR that would be great, otherwise we'll get to this in
the next batch of updates
On Sat, Aug 17, 2019, 7:19 PM JonathanCohn<EMAIL_ADDRESS>wrote:

Anyone here?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<
https://github.com/openstates/people/issues/166?email_source=notifications&email_token=AAAB6YSBO5MAXZDVPRAJBFLQFCBORA5CNFSM4IJBSOH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QVF4A#issuecomment-522277616
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAAB6YXEHFR74QJ5C7M5TULQFCBORANCNFSM4IJBSOHQ
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openstates/people/issues/166?email_source=notifications&email_token=AGMQRYB6JGP55X75MFV7TELQFCWMTA5CNFSM4IJBSOH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QW7DQ#issuecomment-522284942,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGMQRYFXNENZZ2AGYF4DDW3QFCWMTANCNFSM4IJBSOHQ
.

Sorry not sure I understand the question
On Sun, Aug 18, 2019 at 9:55 PM JonathanCohn<EMAIL_ADDRESS>wrote:

Thanks! What would be the proper coding for this in the PR drop-downs?
On Sat, Aug 17, 2019 at 10:17 PM James Turk<EMAIL_ADDRESS>wrote:

if you can submit a PR that would be great, otherwise we'll get to this
in
the next batch of updates
On Sat, Aug 17, 2019, 7:19 PM JonathanCohn<EMAIL_ADDRESS>wrote:

Anyone here?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<

https://github.com/openstates/people/issues/166?email_source=notifications&email_token=AAAB6YSBO5MAXZDVPRAJBFLQFCBORA5CNFSM4IJBSOH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QVF4A#issuecomment-522277616

,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/AAAB6YXEHFR74QJ5C7M5TULQFCBORANCNFSM4IJBSOHQ

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/openstates/people/issues/166?email_source=notifications&email_token=AGMQRYB6JGP55X75MFV7TELQFCWMTA5CNFSM4IJBSOH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QW7DQ#issuecomment-522284942
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AGMQRYFXNENZZ2AGYF4DDW3QFCWMTANCNFSM4IJBSOHQ
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/openstates/people/issues/166?email_source=notifications&email_token=AAAB6YTB2WPIZEWXQLI2HFDQFH4RTA5CNFSM4IJBSOH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4RPC2I#issuecomment-522383721,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAB6YQKSQWNDDESF2H6GO3QFH4RTANCNFSM4IJBSOHQ
.

Think I figured it out. Thanks!
On Tue, Aug 20, 2019 at 2:28 PM James Turk<EMAIL_ADDRESS>wrote:

Sorry not sure I understand the question
On Sun, Aug 18, 2019 at 9:55 PM JonathanCohn<EMAIL_ADDRESS>wrote:

Thanks! What would be the proper coding for this in the PR drop-downs?
On Sat, Aug 17, 2019 at 10:17 PM James Turk<EMAIL_ADDRESS>wrote:

if you can submit a PR that would be great, otherwise we'll get to this
in
the next batch of updates
On Sat, Aug 17, 2019, 7:19 PM JonathanCohn<EMAIL_ADDRESS>wrote:

Anyone here?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<

https://github.com/openstates/people/issues/166?email_source=notifications&email_token=AAAB6YSBO5MAXZDVPRAJBFLQFCBORA5CNFSM4IJBSOH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QVF4A#issuecomment-522277616

,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/AAAB6YXEHFR74QJ5C7M5TULQFCBORANCNFSM4IJBSOHQ

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<

https://github.com/openstates/people/issues/166?email_source=notifications&email_token=AGMQRYB6JGP55X75MFV7TELQFCWMTA5CNFSM4IJBSOH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QW7DQ#issuecomment-522284942

,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/AGMQRYFXNENZZ2AGYF4DDW3QFCWMTANCNFSM4IJBSOHQ

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/openstates/people/issues/166?email_source=notifications&email_token=AAAB6YTB2WPIZEWXQLI2HFDQFH4RTA5CNFSM4IJBSOH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4RPC2I#issuecomment-522383721
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAAB6YQKSQWNDDESF2H6GO3QFH4RTANCNFSM4IJBSOHQ
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openstates/people/issues/166?email_source=notifications&email_token=AGMQRYB3POQHHWM6JYAOY73QFQZUTA5CNFSM4IJBSOH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4XHSEI#issuecomment-523139345,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGMQRYH56UH4HAGTPZ352FLQFQZUTANCNFSM4IJBSOHQ
.


[FEAT]: SSO / OAuth with Microsoft

What would you like to see?
I will be great to have SSO & OAuth for easier user management in organization. Thanks.

#1193


Live

Docs Build status updates of commit 58f1c3e:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Test PR


Add syntax reference for comments

Fixes #32817
Add a syntax reference page for C# comment characters.
Oddly, we didn't have one. It appears to have been assumed throughout the guide.

/cc @Rick-Anderson


Revert "fix decision state machine"

Reverts uber-go/cadence-client#531
Will fix the issue by https://github.com/uber-go/cadence-client/pull/532

Coverage increased (+0.03%) to 68.856% when pulling 3d3a085b58b9ffb6ad6915d13b2a87aecd628dc6 on revert-531-fix_decision_sent_2 into dd3ec324391039eb62bc3428bb05ac84d796bb15 on master.


Upstream fixes

docker-library/python#121
docker-library/python#125

:+1:, although we'll need another review if you make the change I mentioned in the comment.


Loggers should attach more contextual information

The Loggers are still pretty plain, they could add more metadata (like user, channel, team etc) when the endpoints set them up.

The IncomingMessage.log is now mutable and additional metadata can be added. Should be done in the bodyParser's I suppose.

The IncomingMessage.log is now mutable and additional metadata can be added. Should be done in the bodyParser's I suppose.

It does now.

It does now.


Emit iterator for iterable/maplike/setlike

This emits iterators for interfaces with iterable<>, maplike<>, setlike<> declarations.

Can you also add NodeListOf, HTMLCollectionBase, HTMLCollectionOf, so that we can replace https://github.com/Microsoft/TypeScript/blob/master/src/lib/dom.iterable.d.ts with this file.

NodeList.prototype[Symbol.iterator] exits at runtime, but it does not show on NodeList

CSSRuleList is already there, so I added others.


Format code and other minor changes

Format code
Add font-awesome icons
Update texts

@mesaugat Thanks dai for giving your time on this :smile:. Merged.


New Pluign: r2ninja

Plugin to interact with r2 from binary ninja
https://github.com/alkali9/r2ninja

Sorry for the delay, plugin is added. Thanks for the submission!


[WIP] Placeholder for Structured Logging Enhancement

Placeholder for https://github.com/kubernetes/enhancements/issues/1602

Topic for future: I think it would make sense to split logging.md into separate files one describing logging of applications running on K8s, second one describing logging of kubernetes components?
I will try to propose file names/locations, but suggestions would be appreciated.

I'll mark this as WIP so that Prow notices too
/retitle [WIP] Placeholder for Structured Logging Enhancement

Hi @serathius , Thank you for creating the placeholder PR.
This PR is raised against master. However, it needs to be raised against dev-1.19 branch. Can you make the appropriate changes, please? TIA

Sure, Closing for https://github.com/kubernetes/website/pull/21202


Add counter how many days until the holiday

On dashboard we have a widget called "Najbliższe dni wolne"

It will be very useful if somewhere we add information how many days left to holidays.

Closed with  #189.


Appstudio update test-component-pac-zucb

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-zucb-on-pull-request has failed.

StatusDurationName

✅ Succeeded
9 seconds
appstudio-init

🏃 Running
---
clone-repository