Hi, I am not here for an issue but for a suggestion.

I really believe that, since now we can create reminders in Google Calendar phone app without the need of letting Google access all our data and they appear in amidst the other normal calendar events, I would like to be able to see those reminders as the events in the Chrome Extension. I would be thrilled if you added this tiny little option in the extension. Thank you very much, Andrey.
PS: Sorry for using a throwaway account, but I don't use github so it had to be a throaway.

PPS: I will still observe the replies and reply, if necessary, on this discussion even if this is a “fake” account. Thank you, and sorry again.


Timeout error while signing nuget packages

I'm following an article here https://docs.microsoft.com/en-us/nuget/create-packages/sign-a-package to sign my DotNet 48 nuget packages but couldn't. I get a timeout error:
This operation returned because the timeout period expired
I'm using code signing cert from GoDaddy.
This is my PowerShell task in TFS 2017.1 build pipeline:
Get-ChildItem $(PackageStagingDirectory)\nugetPackages -Filter "*.*nupkg" | ForEach-Object {
  $(Build.BinariesDirectory)\nuget.exe sign $_.FullName -Timestamper http://tsa.starfieldtech.com -CertificateFingerprint "$CertThumbprint" -OutputDirectory "$PkgOutputDir" -Overwrite -NonInteractive -Verbosity detailed
}

I don't see any option to bump up the timeout period.
Is this just me?

Problem was with GoDaddy TSA.

I'm experiencing this issue again hence re-opened. If I sign just one package, it works hower it times out with multiple package signing in a loop.

This is the error:
2019-09-04T16:13:30.6325997Z ##[error]This operation returned because the timeout period expired.

2019-09-04T16:13:30.6325997Z System.Security.Cryptography.CryptographicException: This operation returned because the timeout period expired.
2019-09-04T16:13:30.6325997Z
2019-09-04T16:13:30.6325997Z    at NuGet.Packaging.Signing.Rfc3161TimestampRequest.SubmitRequest(Uri timestampUri, TimeSpan timeout)
2019-09-04T16:13:30.6325997Z    at NuGet.Packaging.Signing.Rfc3161TimestampProvider.GetTimestamp(TimestampRequest request, ILogger logger, CancellationToken token)
2019-09-04T16:13:30.6325997Z    at NuGet.Packaging.Signing.Rfc3161TimestampProvider.TimestampSignatureAsync(PrimarySignature primarySignature, TimestampRequest request, ILogger logger, CancellationToken token)
2019-09-04T16:13:30.6325997Z    at NuGet.Packaging.Signing.X509SignatureProvider.TimestampPrimarySignatureAsync(SignPackageRequest request, ILogger logger, PrimarySignature signature, CancellationToken token)
2019-09-04T16:13:30.6325997Z    at NuGet.Packaging.Signing.X509SignatureProvider.CreatePrimarySignatureAsync(SignPackageRequest request, SignatureContent signatureContent, ILogger logger, CancellationToken token)
2019-09-04T16:13:30.6325997Z    at NuGet.Packaging.Signing.SigningUtility.<SignAsync>d__4.MoveNext()
2019-09-04T16:13:30.6325997Z --- End of stack trace from previous location where exception was thrown ---
2019-09-04T16:13:30.6325997Z    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
2019-09-04T16:13:30.6325997Z    at NuGet.Commands.SignCommandRunner.<ExecuteCommandAsync>d__1.MoveNext()
2019-09-04T16:13:31.1638153Z ##[error]Process completed with exit code 1 and had 1 error(s) written to the error stream.

@sameer-kumar - this is the docs repo and meant for issues on documentation. Use the Home repo to file product-related issues.


Disallow traits applied to public prelude shapes

Applying a trait to a prelude shape is a recipe for disaster. For
example, if someone marked the smithy.api#String shape as private,
virtually every model would break.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This closes #278, correct?


doc: GA experiment ruby SDK

Amplitude Developer Docs PR
Description
GA Experiment Ruby SDK
Deadline
N/A
Change type

[ ] Doc bug fix. Fixes #[insert issue number]. Amplitude contributors include Jira issue number.
[x] Doc update.
[ ] New documentation.
[ ] Non-documentation related fix or update.

PR checklist:

[x] My documentation follows the style guidelines of this project.
[x] I previewed my documentation on a local server using mkdocs serve.
[x] Running mkdocs serve didn't generate any failures.
[x] I have performed a self-review of my own documentation.

@amplitude-dev-docs
@caseyamp

Good catch @bgiori , just removed the --pre from install scripts


Map period interval codes to period names

the period intervals (d,w,m,y) are used to create a Carbon method to add the interval:
$test->addDays(3);
However the code generates: $test->addDs(3); and fails.

This is already fixed on the develop branch 🙂


rest: add transaction execution endpoint

Description
Add a transaction execution endpoint to the rest api that utilizes the new transaction execution 2.0 ability to ask for input/output objects from validators.
This PR also introduces a dependency on https://github.com/bmwill/sui-sdk which is a from-scratch implementation of the sui core types that includes compatibilities via bcs for all types as well as a newly designed, canonical, json representation for all core types.
One note is that we may or may not want to finish are conversions to/from these new types and the core types. Presently in this PR we leverage the bcs compatibility aspect and just convert via ser/de.
Test plan
How did you test the new or updated feature?

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:

Thanks!
Should we review sui-sdk first and get it into mysten repositories?

Thanks! Should we review sui-sdk first and get it into mysten repositories?

Just moved this repo to mystenlabs/sui-rust-sdk and setup CI/branch protections and the like there.


Symmetry operation specifications in Jones faithful notation (defined by PCRE)

Please have a look at the symmetry operation specification PR with the Jones' faithful notation of the symmetry operations.
Word description was added on top of formal PCRE definitions of the syntax.
To specify the semantics (interpretation) of the symmetry operations, I had to cite very specific places of the ITC vols. A and B. As a result, there are many references in the text now.
For now, I put the references after each definition section; this however results in scattered bibliography list and duplications (one duplication is present even now). I think it would be better to make a separate "Bibliography" section at the end of the text and place all bibliography sources there, with just references inserted into the text, using the Harvard referencing style (Author-year). If you agree (or are not much against this suggestion), I can rearrange references in this or in a separate PR.
I had to update also the definition of the Hall symbol; to be machine-parsable it needs to be more specific and allow the change-of-basis operations (COD has such entries).
There is currently no discussion on the rationale and intended use of H-M and Hall symbols. Basically the short Hall symbols are in 1:1 correspondence with the ITC space group numbers and fail to provide the setting and the cell choice information. The benefit of the H-M symbols however is that they are much more human-readable and allow to understand the properties of the space group without even looking into the ITC (unlike the pure ITC numbers). Good for searches.
The full (extended) H-M symbols, as well as Hall symbols (both with the c-o-b operations specified) should permit unique identification of the symmetry operation list (Hall symbols after algorithmic interpretation, H-M symbols after table lookup). If you think that this explanation would be needed in the definition text, please let me know, I'll add it.

NB: the text will be added/expanded later, for now its just the REs and the tests.

Workshop suggestion: we accept the syntax specification. The remaining fields from #416  https://github.com/Materials-Consortia/OPTIMADE/issues/416#issuecomment-1274498513 should be added to the PR and time given to symmetry description stakeholders to review. @rartino @sauliusg @vaitkus @merkys @giovannipizzi (feel free to post a comment below to add yourself to the stakeholders)

Thanks for all the work put into this.
I guess we could merge multiple PRs in succession; but as far as I can see, this addition doesn't work on its own but also needs asym_fractional_coords and asym_species_at_site to be defined according to #416 (comment)

IMHO the fractional coordinates and symmetry operations can be merged independently. The symmetry operation specification is essential for the fractional coordinate PR to be even composed correctly.

but as far as I can see, this addition doesn't work

Why not? The space group information and the symmetry are independent on any form of coordinate presentation.

Last web meeting we seemed to agree on that this PR is more or less finished, but to merge it, it needs some very brief statement that there currently is no standard way to communicate fractional coordinates for atoms in the asymmetric unit (despite the PR referring to that in a few places).
(Alternatively, the field definitions to do so could of course be added; the asym_fractional_coords and asym_species_at_site from https://github.com/Materials-Consortia/OPTIMADE/issues/416#issuecomment-1274498513 )
If the statement is added, the idea is obviously to merge asym_fractional_coords and asym_species_at_site shortly after and remove the statement.

Last web meeting we seemed to agree on that this PR is more or less finished, but to merge it, it needs some very brief statement that there currently is no standard way to communicate fractional coordinates for atoms in the asymmetric unit (despite the PR referring to that in a few places).
(Alternatively, the field definitions to do so could of course be added; the asym_fractional_coords and asym_species_at_site from #416 (comment) )
If the statement is added, the idea is obviously to merge asym_fractional_coords and asym_species_at_site shortly after and remove the statement.

Once more, I do not feel like adding "temporary" messages. Probably the better way is to make definition of symmetry operations independent of the fractional coordinate property.
I have attempted to rephrase conventions (requirements) for the symmetry operation property so that it specifies general conditions when this property SHOULD or MUST be provided (essentially, it SHOULD be provided whenever it is applicable, and MUST be provided when it is needed ;). The fractional coordinates are mentioned only as an example, or as a general crystallographic concept.
Actually, symmetry operations can also be applied to atoms when Cartesian coordinates are returned; in that case one needs to convert them to fractional coords (which is possible since the unit cell vectors are also provided), apply the symmetry operations and then convert back to Cartesian if needed.
Please have a look at the new version.

@sauliusg Thank you for also accepting the earlier changes.
I would like to note, that during one of the earlier meetings it was agreed that the approvals from neither me, nor @merkys should count on this issue given that all three of us work on the COD project.
That being said, I do not think that moving the mention of fractional coordinates to an example helps, because we are still mentioning a property that is not currently supported. Also, I found the earlier phrasing more succinct and easier to understand -- now the reader if left to wonder what are those different coordinate forms to which the symmetry operations can be applied. In your earlier comment you mention Cartesian coordinates as one such case, but that would clash with other statements presented in this PR, e.g.:
The symmetry operations are to be applied to fractional atom coordinates.

Finally, if the new phrasing is accepted, the can and must part should probably be rewritten to use either "can" or "must", because in this situation "must" encompasses "can". I would probably go with "can".

I would like to note, that during one of the earlier meetings it was agreed that the approvals from neither me, nor @merkys should count on this issue given that all three of us work on the COD project.

Since in these cases we are voting neither on personalities nor on policy statements in which we could have vested interest, but instead we vote on technical issues, affiliation of voters with the COD or any other project is not relevant, IMHO. Since there does not seem to be many participants who would be deeply interested in symmetry description, your comments on technical issues would be highly appreciated. But of course anybody is free to decline if they feel that they have a conflict of interest here.

@sauliusg wrote:

I cannot find the place where I mention application of symmetry operations to Cartesian coordinates; that would be also incorrect. Could you please give me the exact location of the text that you cite?

I was referring to part of the comment from (https://github.com/Materials-Consortia/OPTIMADE/pull/464#issuecomment-1739617585):

Actually, symmetry operations can also be applied to atoms when Cartesian coordinates are returned; in that case one needs to convert them to fractional coords (which is possible since the unit cell vectors are also provided), apply the symmetry operations and then convert back to Cartesian if needed.

But this has now been addressed with an additional sentence in the PR.

I disagree. The symops as given can be applied to fractional coordinates. They must be applied if fractional coordinates are given for the AU only and the user wants to reconstruct the full unit cell. Both cases are relevant.

Then it should be "which these operations can or must be applied" instead of "which these operations can and must be applied" ("and" -> "or").

Actually, symmetry operations can also be applied to atoms when Cartesian coordinates are returned; in that case one needs to convert them to fractional coords (which is possible since the unit cell vectors are also provided), apply the symmetry operations and then convert back to Cartesian if needed.

But this has now been addressed with an additional sentence in the PR.

OK, so this is hopefully resolved now.

I disagree. The symops as given can be applied to fractional coordinates. They must be applied if fractional coordinates are given for the AU only and the user wants to reconstruct the full unit cell. Both cases are relevant.

Then it should be "which these operations can or must be applied" instead of "which these operations can and must be applied" ("and" -> "or").

Good suggestion, thanks, I will apply it!

Let me also add a direct link to the CIF dictionary mentioned. Also I’d like to check, if the ops non-symbolic notation is discouraged (e.g. x+0.6666667 should be x+2/3).

@blokhin wrote:

Let me also add a direct link to the CIF dictionary mentioned. Also I’d like to check, if the ops non-symbolic notation is discouraged (e.g. x+0.6666667 should be x+2/3).

A link to the CIF_CORE dictionary is provided under the space_group_symmetry_operations_xyz  section as:
https://www.iucr.org/__data/iucr/cifdic_html/1/cif_core.dic/Ispace_group_symop_operation_xyz.html
The non-symbolic notation is not allowed at all by the regular expression, that is, x+2/3 is allowed, x+0.6666667 is not allowed.


ray.exceptions.RayActorError: The actor died unexpectedly before finishing this task.

Here is the error
Last test reward: 500.00. Training step: 8449/10000. Played games: 13. Loss: 3.642021-12-31 01:53:03,200	WARNING worker.py:1245 -- A worker died or was killed while executing a task by an unexpected system error. To troubleshoot the problem, check the logs for the dead worker. RayTask ID: ffffffffffffffff5c4f8fe95fa608ecc2d8b86b01000000 Worker ID: dea6505859cd12046772c48e3964b3de7cf585148696c1226c9b42bb Node ID:<PHONE_NUMBER>a2cae5bac8e5a217534c9754a749ce7832fbb054cf0b16 Worker IP address: <IP_ADDRESS> Worker port: 42079 Worker PID: 8537
2021-12-31 01:53:03,438	ERROR worker.py:85 -- Unhandled error (suppress with RAY_IGNORE_UNHANDLED_ERRORS=1): ray::Reanalyse.reanalyse() (pid=8542, ip=<IP_ADDRESS>, repr=<replay_buffer.Reanalyse object at 0x7fbc5452cb50>)
  File "/home/yaoappemail/mymuzero/replay_buffer.py", line 332, in reanalyse
    replay_buffer.sample_game.remote(force_uniform=True)
ray.exceptions.RayActorError: The actor died unexpectedly before finishing this task.
2021-12-31 01:53:03,439	ERROR worker.py:85 -- Unhandled error (suppress with RAY_IGNORE_UNHANDLED_ERRORS=1): ray::Trainer.continuous_update_weights() (pid=8543, ip=<IP_ADDRESS>, repr=<trainer.Trainer object at 0x7f7bb02fd890>)
  File "/home/yaoappemail/mymuzero/trainer.py", line 71, in continuous_update_weights
    index_batch, batch = ray.get(next_batch)
ray.exceptions.RayActorError: The actor died unexpectedly before finishing this task.

How to fix it? Many thanks!

Did you solve this?


[SPARK-26673][FollowUp][SQL]File Source V2: check existence of output path before delete it

What changes were proposed in this pull request?
This is a followup PR to resolve comment: https://github.com/apache/spark/pull/23601#pullrequestreview-207101115
When Spark writes DataFrame with "overwrite" mode, it deletes the output path before actual writes. To safely handle the case that the output path doesn't exist,  it is suggested to follow the V1 code by checking the existence.
How was this patch tested?
Apply https://github.com/apache/spark/pull/23836 and run unit tests

@gatorsmile @cloud-fan

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8277/
Test PASSed.

Test build #102756 has started for PR 23889 at commit 20210b9.

Test build #102756 has finished for PR 23889 at commit 20210b9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102756/
Test PASSed.

Hi, @gengliangwang . The PR looks reasonable, but do we need #23836 for this?
## How was this patch tested?
Apply #23836 and run unit tests

Hi, @gengliangwang . The PR looks reasonable, but do we need #23836 for this?

Otherwise, the V2 write path is not tested. I just tested it on my local ENV since the code  is so simple.


Inference on Single Image

Hi Piper, It's great to see such an amazing work is publicly available. However, When I run inference on test_set provded it worked perfectly. However, when I downloaded a single sentinel 2 L1C image, and running the inference on it using the weights provided for single image. I am getting.
Running inference on  0  images.
infer_example.yml.txt

Hello! Thanks for your interest in our work. If the code is not finding any images, that likely means your filepath structure is not the same as the provided test set. Could you add some print statements to your code so we can see what your filepath is versus what the code expects?

Hi, Kindly find the screenshot of the output. Is there are any other pre-prcoessing steps involved which i may have missed which can cause this issue.

My input File after passing it through, https://github.com/allenai/satlas-super-resolution#how-to-process-raw-sentinel-2-data

However, as it was pesudocode, i modified it, here i am also attaching that for the reference
`import rasterio
import numpy as np
from rasterio.warp import reproject, Resampling
Path to the Sentinel-2 JP2 file
tci_jp2_path = './delhi_test.jp2'
Open the Sentinel-2 image
with rasterio.open(tci_jp2_path) as src:
# Read the entire image as numpy array
img = src.read()
meta = src.meta.copy()
# Define target CRS and resolution
dst_crs = rasterio.crs.CRS.from_epsg(3857)
dst_resolution = (9.555, 9.555)

# Reproject the image
img_rep = np.zeros((src.count, int(meta['height']), int(meta['width'])), dtype=img.dtype)
for band_idx in range(src.count):
    reproject(
        source=rasterio.band(src, band_idx + 1),
        destination=img_rep[band_idx],
        src_transform=src.transform,
        src_crs=src.crs,
        dst_transform=src.transform,
        dst_crs=dst_crs,
        resampling=Resampling.bilinear
    )

Update metadata with new CRS and resolution
meta.update({
'crs': dst_crs,
'transform': rasterio.transform.from_origin(src.bounds.left, src.bounds.top, dst_resolution[0], dst_resolution[1])
})
Write the reprojected image to a new JP2 file
output_path = tci_jp2_path.replace('.jp2', '_rep.jp2')
with rasterio.open(output_path, 'w', **meta) as dst:
dst.write(img_rep)
print(f"Reprojected image saved: {output_path}")
`

Ah, I see. That section of code is just meant to document how to project raw Sentinel-2 images to Web-Mercator projection. Then you need to format the imagery as described here. So the imagery should be saved as [num_s2_images * 32, 32, 3] shaped pngs.
I will make the documentation clearer.

Hi,
This is my code to format the image as you mentioned:
  import skimage.io
  import numpy as np
  import glob
  import os

  # Path to the directory containing images
  image_dir = '/home/rd/Documents/projects/SATLAS/testing/'  # Replace with your folder path

  # Get a list of all image files in the directory
  image_paths = glob.glob(os.path.join(image_dir, '*.png'))  # You can adjust the file extension if needed

  # Read each image and convert it to a NumPy array
  images = []
  for image_path in image_paths:
      image = skimage.io.imread(image_path)
      image_np = np.array(image)
      images.append(image_np)

  # Stack all images along a new axis to create a single 4D array
  images_array = np.stack(images, axis=0)

  # Print the shape of the combined array
  print(f"Combined images array shape: {images_array.shape[0]}")
  reshape_arr = np.reshape(images_array, (images_array.shape[0]*32, 32, 3))   # reshape this array so we can save it as a png
  skimage.io.imsave('testing.png', reshape_arr)

I have tried with 2 images as well, and the stacked output generated by the code is as follows:

I also played around i.e. tested all permutations of N_LR, N_CH, and model weights in Infer_Example.yml, such as: N_LR: 1 or 2, N_CH, 3 or 6, Model_Weights: esrgan_1S2.pth or esrgan_2S2.pth .
However, When I run the inference I am still getting: Running inference on 0 images

The reason the code would print out "Running inference on 0 images" is the glob statement here. This means that your directory structure is not as this glob statement expects and/or your image filepaths do not match the expected ".png".
You want to edit the code or edit your data directory structure so that pngs is a list of filepaths of your Sentinel-2 images. Does that make sense?

Hi,
Yeah I figured it out, Sorry I forgot to update over here. The code is working now. Thanks for your quick responses. :) . However, when i run inference on URBAN Areas, the model is unable to generate satisfactory results.

However, the linear features are getting worked out.
Lodz where model worked great.

However, when I tried another area of lodz it again kind of hallucinated.

Could you shed some light on it. And what all the steps will be required to re-train the model on Sentinel Vs SKYSAT.

How many Sentinel-2 images did you use as input for these outputs? I have seen plenty of hallucinations in places that look far different from the USA and/or when I only us 1-4 images as input. There is certainly room for improvement in locations that the model has never seen before.
To re-train the model on SKYSAT, you will want to structure a dataset in the same way as our S2NAIP, write a dataset file to replace s2-naip_dataset.py that will load in your intended inputs and outputs ideally in the same format as S2NAIP, write a config file with updated paths to your data and any other variables that need to be changed, and finally start training with python -m ssr.train -config your_config.
I found that using the pretrained satlas-super-res weights transferred to other datasets improved performance, so might be worth trying to start your training from there.

Hi @piperwolters and @lokeshsk
Could you check my issue https://github.com/allenai/satlas-super-resolution/issues/45?
Thanks


[DAHDI]: kernel.h also found in patch cdd6ddd0fd08cb8b7313b16074882439fbb58045

In review patch cdd6ddd0fd08cb8b7313b16074882439fbb58045 also updates kernel.h, move this to be a custom patch as well.
Move phreaknet script to 0.2.3

This has conflicts since the first 2 commits were already merged, maybe a new PR is needed?


Add message_path() to Message trait

This branch annotates package names and adds message_path() function to Message trait.
This function returns the full path of each proto message.
This is useful for converting each message to Any.
Example:
syntax = "proto3";

package example.proto;

message Example {
    string value = 1;
}

use prost::{DecodeError, Message};
use prost_types::Any;

mod proto {
    include!(concat!(env!("OUT_DIR"), "/example.proto.rs"));
}

fn convert_to_any<T>(message: &T) -> Any where T: Message {
    Any {
        type_url: format!("example.com/{}", T::message_path()),
        value: message.encode_to_vec(),
    }
}

fn convert_from_any<T>(message: &Any) -> Result<T, DecodeError> where T: Message + Default {
    let expected_type_url = format!("example.com/{}", T::message_path());
    if &message.type_url == &expected_type_url {
        T::decode(message.value.as_slice())
    } else {
        Err(DecodeError::new("Invalid type_url"))
    }
}

let message = proto::Example {
    value: "abc".to_string(),
};

let message = convert_to_any(&message);
println!("{:?}", message);
// -> Any { type_url: "example.com/example.proto.Example", value: [10, 3, 97, 98, 99] }

let message: proto::Example = convert_from_any(&message).unwrap();
println!("{:?}", message);
// -> Example { value: "abc" }

I wonder if this can be achieved with https://docs.rs/prost-types/0.8.0/prost_types/struct.FileDescriptorProto.html instead of adding a new fn to the main prost trait which I would like to avoid.

message_path() returns only limited information compared to DescriptorProto, so it may need to be modified.
However, I think there is no method to make relation between each Message struct and DescriptorProto now.
In any case, I think we need to add a new function to get information for the Message trait.

@LucioFranco could we allow this change or something like it as a stop gap while a solution using the file descriptor proto is made? I'm tracking thinks like #336 and it seems like finishing a full solution for this will take time. Unfortunately without this, it's impossible to work with Any structs

At work we use any just fine so I don't see why not having this makes it impossible? I am not a huge fan of adding this method so its likely that this PR will not land.

@LucioFranco maybe it's more a function of how we use it at my job, but I can't find how, using prost, I can get a type_url for an arbitrary type. I can hard-code it in, but the solution doesn't seem very... Clean. Currently in C++ we just do an Any.Pack() and call it a day. Am I missing some other way of packing these? Frankly, I wouldn't be surprised if I glossed over something important :sweat_smile:

At work we use any just fine so I don't see why not having this makes it impossible? I am not a huge fan of adding this method so its likely that this PR will not land.

How do you serialize messages to and from google.protobuf.Any? It looks to me like the prost::Message type doesn't provide a way to retrieve the type_url or Descriptor for a given message to specify the type of the encoded Any message. Is there another way to pack them effectively into the Any type?

@LucioFranco Can you show an example on how do you use it?

At work we use any just fine so I don't see why not having this makes it impossible? I am not a huge fan of adding this method so its likely that this PR will not land.

How do you serialize messages to and from google.protobuf.Any? It looks to me like the prost::Message type doesn't provide a way to retrieve the type_url or Descriptor for a given message to specify the type of the encoded Any message. Is there another way to pack them effectively into the Any type?

The (awkward) solution I've been using to make this work is define a new trait with a type_url method:
pub trait ProstMessageExt {
    fn type_url() -> String;
}

and then implement it on the messages which I care to pack into a google.protobuf.Any.
let encoded = prost_types::Any {
    type_url: my_message::type_url(),
    value: element.encode_to_vec(),
};

This works fine but requires a definition on every message type, making it a bit hard to write a library, and expanding trait bounds to prost::Message + ProstMessageExt.

@isaacd9 This solution is indeed awkward and has the following problems:

You can always have a typo in the url string
If a message is renamed or moved under another package, you will not get any compilation errors if you forgot to update the url string.

In my opinion this is very error prune.

@vbkaisetsu Correct me if I'm wrong, but shouldn't type.googleapis.com/ always be the prefix in type url?

@oblique The prefix is required.
However, I think it should not be given automatically, but should be specified by the user.
In Java and Python, this prefix is optional argument. When it is not specified, type.googleapis.com/ will be set.
https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/Any
https://googleapis.dev/python/protobuf/latest/google/protobuf/any_pb2.html

If a message is renamed or moved under another package, you will not get any compilation errors if you forgot to update the url string.

Yes, it is.
The path part of type_url should be generated automatically by prost, and specifying it manually is just a cause of bugs.

I really suggest the team to consider this seriously, this kind of APIs are widely used and very useful in daily development. Previously it's discussed in #255 and #336 , both the PRs are rejected. People need to hack around this and even create another crate https://github.com/fdeantoni/prost-wkt for this.

Yeah, I think we can try to merge something to support this in the next release. I would like to formalize a proper road map. I'd like to evaluate our options here and educate myself on how other languages support this behavior.

Is this still needed? The trait Name exists now and is had the type_url method.
Does that cover the use cases for this PR? https://docs.rs/prost/latest/prost/trait.Name.html#method.type_url

Not needed anymore. The usecase was to convert Any to the message type. With Name and Any::to_msg this can be done now.

I close this issue as it seems to be solved. Please reopen if that is incorrect.


Restore ability to add more than one phone

Description
Restore ability to add more than one phone

def add_contact(args, book: AddressBook):
name, phone, *additional_phones = args
record = book.find(name)
message = "Контакт оновлено."
if record is None:
    record = Record(name)
    book.add_record(record)
    message = "Контакт додано."

if phone:
    record.add_phone(phone)

for additional_phone in additional_phones:
    record.add_phone(additional_phone)

return message

##Explanation:
name, phone, *additional_phones = args now unpacks the first two arguments into name and phone, and any remaining arguments into the list additional_phones.
The code first checks if a contact with the given name already exists. If not, it creates a new Record for the contact.
The phone variable is added to the contact, and then the loop iterates over additional_phones to add any other phone numbers provided in args.


1.0.0-RC2 marked as latest release not pre-release

Is 1.0.0-RC2 the latest stable version? If not, it would be good if that release on GitHub were marked as a pre-release so that it doesn't confuse Homebrew's live check. Thanks!

Done!

Much appreciated!


Fully trust ELF reported sizes aside from 0

When we landed da913a1f488c ("Report ELF symbols with bogus size if only conceivable match"), which effectively caused us to ignore ELF reported symbol sizes as part of symbol lookup, we were not considering the possibility of "partly available" symbols. Specifically, the "bogus size" that we saw believed to have seen was actually a misinterpretation of an instruction-to-symbolize residing in a stripped function that was located between two non-stripped symbols.
Given this new understanding of the situation, this change adjusts the ELF parser code to honor symbol sizes. The only exception is for size 0, which is treated specially by ELF and used for symbols with "no size or an unknown size".
Refs: #269

FYI @salvatorebenedetto


Move to a more standard style of HTML DSL for F# #689

I'd like us to review the F# FSharpPocketViewTags programming model (though the PocketView implementation can be used underneath)
The F# community have a fairly standard way of doing HTML DSLs, which is the same across many F# web programming technologies like Fable (client-side HTML) and Giraffe (server-side HTML).  Roughly speaking the end result is to always look like this
div
  [ ]
  [ p [ todoStyle ] [ str item.Description ]
    button [ ClassName "button is-info"; dispatchToggle ] [ str toggleText ]
    divider
    button [ ClassName "button is-danger"; dispatchDelete ] [ str "Delete" ] ]

That is, each HTML element is tag [...attributes...] [ ...content...]
This is how we should be descrbing HTML in the F# .NET Interactive programming model.  It doesn't have to be precisely the same as every other HTML DSL in F# (nor share code) but this is the standard syntax in the community and the one we should be using for window dressing.  It's also very, very effective as a DSL syntax, I and others absolutely love using it, particularly because it jives so well with F# list expressions.
I'd also like to make sure the namespace is not open by default, see #645, and that the way of opening is fairly simple. Currently it is
open Microsoft.DotNet.Interactive.FSharp.FSharpPocketViewTags

which is not great  - I'd like any of
open FSharpPocketViewTags
open PocketViewTags
open HtmlTags

I'll experiment with options

I think given that great HTML DSLs already exist in F#, we should remove the F# implementation of PocketViewTags.
The C# version is likely to support extension authors more often than notebook users and there as well I agree we shouldn't open the namespace by default.

I think given that great HTML DSLs already exist in F#, we should remove the F# implementation of PocketViewTags.

At the moment my feeling is we should replace it by an implementation of an F# DSL that is surface syntax for PocketViewTags and conforms to the HTML element part of Giraffe.ViewEngine exterior API. I'm trialling that right now.
I'm loathe to diverge on the actual HTML object because I suspect

there's devil in the detail
there may be c#-f# interop on this
Giraffe.ViewEngine is not yet something I'd  wouldn't want to take an actual dependency  on

BTW here's an example of the code (compare the C# code with explicit use of ResizeArray due to lack of list expression syntax):
open Html

let register (df:DataFrame) (writer:TextWriter)
    let take = 20
    table [] [
      thead [] [
        th [] [i [ str "index"]]
        for c in df.Columns -> th [] [c.Name]
      ]
      tbody [] [
        for i in 0 .. min take (int df.Rows.Count - 1) do
          td [] [ object i ]
          for o in df.Rows.[int64 i] do
            td [] [ object o ]
      ]  ]
    |> writer.Write
Formatter<DataFrame>.Register( (fun df writer -> register df writer), mimeType = "text/html")

DOne in #689


Problems with Form in Sticky Header

Hi,
when I have form inside the header I can no longer use it once I start scrolling down.
Reason is that it is then showing the cloned content instead of the real content.
:(

There's a bit of a bug in your pull request, but I'm pulling it in, and I'll fix the bug later.
Thanks!


Make animation / normal line widths consistent

It seems like there are some interaction bugs that can arise when the "sample coloring" and "animation" line widths differ. I also suspect that these are thickening lines in different ways; see here.
Related to #144.

This seems like it's more severe than I remembered for animation -- see below. Not sure if there were changes recently that impacted this.

I believe this was addressed in  #180. @fedarko feel free to open this issue up again if that did not address the issue.


Uncaught TypeError: Cannot read property 'date' of undefined for xAccessor

When  xAccessor={d => d.date} this is set and data = [{ date: new Date('2011-01-24').getTime() }, {date: new Date('2011-01-25').getTime() }], then below error occurs
'Uncaught TypeError: Cannot read property 'date' of undefined'

There is not enough information for me to provide any helpful reply. There are dozens of examples with xAccessor={d => d.date}
Kindly share a plunker/fiddle with your issue

@madhumurugan89 Are you by chance using redux?  And/or by chance is the initial data you send in equal to null?


Issue with Calender

I download this project and made absolutely no changes to the code. The time difference might be due to Time Zones, but the today/tomorrow issue seems weird.

@atulgoel126 There's a thread on Stack Overflow that mentions this error. Basically, you'll need to go into the Default Welcome Intent and switch-on the toggle for Use response from the DEFAULT tab as the first response and then redeploy.

@atulgoel126 Okay yes I'm seeing the same today/tomorrow. Thanks for letting us know!


Doesn't work in macOS 10.12.1

I think it doesn't work because the order Keyboard menu bar has changed. Use all F1, F2, etc
checkbox is now the last item on that menu.

click checkbox 1 of tab group 1 of window 1
I think this should be changed to:
click checkbox 4 of tab group 1 of window 1


feat(dlq): Revamped Invalid Message(s) Model

Overview

PR #61 and #57 both rely on a common implementation of what an Invalid Message looks like.
Pulling out that definition to this PR so it can be merged separately and there is no confusion on what it looks like.
This would be merged into those two PR's before they are merged to main so there are no conflicts.

Key is optional in the KafkaPayload class, leaving it as Optional[bytes] for InvalidKafkaMessage as well.


Jest Release | Dependency updates

🐛 Bug Report
I am getting an error across a lot of my repositories about an outdated handelbars vulnerability. To fix this dependabot is telling me to update to 4.3.0
However, I don't use handlebars. istanbul-reports is using handlebars. As of this PR handlebars is no longer included in istanbul-reports. Jest's outdated dependency tree around this was raised and addressed in this issue.
Unfortunately, this was commited on November 21st. The latest Jest available is for 24.9.0 which was released in August. Is there anything I have missed or can assist in to get this into master ASAP for both myself and others
Thanks Jest Team
To Reproduce
Install Jest 2.4.9 and push to a github repo
Expected behavior
No dependabot issues were expected.

For now, if anyone is looking to fix this, you'll be getting this error from istanbul-reports using handlebars in your yarn.lock file. To fix this head over to your yarn.lock and either change the version of istanbul-reports to 3.0.0 (when they fixed the handlebars) or the version of handlebars to 4.3.0 explicitly.
In my yarn.lock that looks like this:

Face the same problem. @builtbyproxy thanks for solution. But it is temporary solution, jest should be fixed.

Just delete the handlebars entry in your lockfile and rerun yarn/npm - that'll pull in the fixed version of handlebars.

As for a release, I don't have the permissions to make one. I've poked some FB people, hopefully a release will happen now the the holidays are over

@SimenB That's awesome, Thanks a lot! Looking forward to some responses then

New week, new problems. Just bumping you and your contacts @SimenB
Thanks a lot

I heard back on Friday, and the current plan is this week 🤞

Excellent! Thanks a lot for the persistance on this @SimenB

After we get this release out the door I'll be trying to setup a better system for releases. 25 has been painful for all involved

Happy to help within my capabilities on that @SimenB

Hi Guys,
I have the same problem. I have tried to fix it by deleting handlebars entry from lock file and also tried deleting the whole lock file and rerun npm, still "Istanbul-reports" always goes back to handlebars 4.1

@AlshymaaCS As mentioned in this comment you can explicitly change your lockfile. You'll have to make sure it's correct each time you run yarn, but this issue should be fixed this week so it's not a huge problem.

Correct accesses were granted Friday, but it seems it came abit too late for a release. Hopefully one will come next week.

When it comes to handlebars issue specifically, you can updated to the latest release of istanbul-reports (just delete its entry from your lockfile) which has removed the dependency on handlebars. Fresh installs of Jest 24 should no longer pull in handlebars at all

Thanks @SimenB
We have fixed the handlebars bug temporarily by editing our .lock accordingly.
Jest hasn't been updated for quite some time and there are numerous fixes and changes that have happened in some of its core dependencies, notably istanbul. It would be great if these could all be released into the npmjs version to mirror that of your Master branch

Tentative release day is Thursday this week


Fixing inspect problems, adding missing header file

@SAtacker Please verify that I have not broken anything

@SAtacker Please verify that I have not broken anything

Nope, thanks for the changes.

bors merge


[Bug report] User config dependencies are not watched on windows

Bug report
Modifying user config dependencies do not trigger the dev server to restart on windows.
Description
resolveDevUserConfig.ts contains a method resolveDeps which does not work on windows because the paths are not in the correct format. The filename passed into the method is in the format C:/dev/src/.../docs/.vuepress/config.js, whereas the require.cache is in the format C:\\dev\\src\\...\\docs\\.vuepress\\config.js.
Steps to reproduce
Create a config.js file which requires another dependency. Modify the dependency. The dev server does not restart.
Expected behavior
The dev server to restart.

For example:
require.cache[path.normalize(filename)]

I think that it is already using path.normalize earlier in the chain - and that's the issue. The path library being uses always creates linux style paths, whereas require.cache will always use the OS's path style

I'm talking about Node.js's path:
https://github.com/nodejs/node/blob/69f487efc734f2b9bb67f46f99cd98e1c1e13d9b/lib/path.js#L1543
Not VuePress's path:
https://github.com/vuepress/vuepress-next/blob/0934a5d6685922e0dc6391622b00a3b89140492c/packages/%40vuepress/utils/src/index.ts#L9

Node.js is OS-aware.

Apologies - I didn't follow your link to the node path lib and assumed you meant the upath lib. In which case, I agree that should hopefully do it!


azure: allow vnets from another resource group

This change adds support specifying Virtual Networks from another
Resource Group. Most Azure customers already have existing resource
groups and Virtual Network resources that they attach to the new
machines they create.
--azure-vnet flag will automatically work with [group:]name
format.
Fixes #3656.
@nathanleclaire please review.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "azure-xvnet" git@github.com:ahmetalpbalkan/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "azure-xvnet" git@github.com:ahmetalpbalkan/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "azure-xvnet" git@github.com:ahmetalpbalkan/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "azure-xvnet" git@github.com:ahmetalpbalkan/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

test this please

@nathanleclaire good2go

LGTM

Hey @ahmetalpbalkan dumb question but it looks like this PR hasn't shipped yet, correct?  If I wanted to play with the different resource group feature, what's the best way to get the bits?  Build from source?  Or are there nightly builds?  Thanks!

@jritsema I think it is shipped with 0.8.1

I just tried it on 0.8.1 and got the following error with the following configuration...
--azure-vnet common-services:vnet-xyz

Querying if virtual network already exists.  name="common-services:vnet-xyz" location="eastus2"
Error creating machine: Error in driver during machine creation:

network.VirtualNetworksClient#Get: Failure responding to request: StatusCode=400 -- Original Error: azure: Service returned an error. Code="InvalidDoubleEncodedRequestUri" Message="The request URI 'https://management.azure.com:443/subscriptions/xxxx/resourceGroups/xxxx/providers/Microsoft.Network/virtualnetworks/common-services%253Avnet-xyz?api-version=2015-06-15' is not valid, because it contains double encoding sequence '%25'." Status=400

I'm sure I'm doing something wrong...

@jritsema I just checked the 0.8.1 code tree, it looks like the feature did not make it to the release. Apologies about my earlier comment. AFAIK there are no nightly builds, but you can download the source code and just build it.

Ok no worries. I'll build from source. Thanks.


Question about back propagation in time-delayed recurrent models

The full question is available here: http://stackoverflow.com/questions/35733302/back-propagation-in-tensorflow
The question concerns whether I would have to implement a custom backward step in order to create something similar to the clockwork model. In the event that I would, I was wondering if there is reference code for how I might properly go about it.
Thank you in advance for your support.

Please don't cross post stack overflow questions as Github issues.

@girving just trying to get it in front of the only people who will have the answer.


Update go version to 1.18

Currently go version in go.mod is 1.17

Resolved in 5df58b9b842815d158865f63f65ca5b5e7587cef


New frame view

Hello.
You are did great addon! I love unitframe from modui.
If it possible you are can add new view for unitframe like a modui style?

Thx.

flat textures are available on my new project. https://github.com/Ko0z/zUI


token-holders api issue

Issue:

Incorrect balance: need to get on-chain balance
return duplicated addresses

https://github.com/tomochain/tomoscan/commit/fc327965fb118e04c0701ab0a8ec85572fa1c230
https://github.com/tomochain/tomoscan/commit/4a56ff9c9707bc5d4345d7ad759084fad727d86d


phantomjs 1.9x and 2 do not render utf8 chars on centos7

Hi there,
I've been trying to convert japanese web pages to PDF using the rasterize.js example. This does work on centos5/6 but not on centos7.
I've checked that japanese fonts are installed and rendering the same page as image does work fine.

I should perhaps add that I tried 1.9.2, 1.9.8 and 2.0.0, all compiled locally without any issues

After further testing it turns out that the rasterize.js example also fails to render japanese chars in a png.
I am pretty sure that it is not a fonts issue as another custom script can scrape the same page correctly.

I follow below procedures, there is below error
http://phantomjs.org/build.html
g++: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://bugzilla.redhat.com/bugzilla> for instructions.
make[2]: *** [.obj/inspector/InspectorAllInOne.o] Error 4
make[2]: Leaving directory `/home/ryoeng/phantomjs/src/qt/qtwebkit/Source/WebCore'
make[1]: *** [sub-Target-pri-make_first-ordered] Error 2
make[1]: Leaving directory `/home/ryoeng/phantomjs/src/qt/qtwebkit/Source/WebCore'
make: *** [sub-Source-WebCore-WebCore-pro-make_first-ordered] Error 2
after run ./build.sh in
git clone git://github.com/ariya/phantomjs.git
cd phantomjs
git checkout 2.0
./build.sh

I have the same problem, with Phantom 1.9.7, my letters are displayed like square boxes

Found something that works for me. In addition to
yum groupinstall Japanese Support

I had to install these fonts:
yum install cjkuni-fonts-common cjkuni-ukai-fonts cjkuni-uming-fonts

I made my own 2.0 and 1.9.7 builds on my centOS7 system and have the same square box issue. I'm just trying to get the pdf to generate a "hello world"
Based on what @DerManoMann has said maybe we are missing some font module?

I think it is the responibility of the OS to provide the fonts.
So, IMO the language groupinstall for CentOS7 is broken.

Eureka! I just solved the issue. It looks like I was missing some font modules. Was going to switch over to wkhtmltopdf and while installing it it complained that I was missing libXext libXrender xorg-x11-fonts-Type1 xorg-x11-fonts-75dpi. Installed those and on a hunch re-tested phantom and booya! It worked.
 Sigh.
So... solution for me was:
yum install libXext libXrender xorg-x11-fonts-Type1 xorg-x11-fonts-75dpi

@DerManoMann Can you see if the solution from @ldeavila also works for you?

Oh, sorry, I really should have closed this after my second last comment. Adding these additional fonts fixed things to me:
yum install cjkuni-fonts-common cjkuni-ukai-fonts cjkuni-uming-fonts

I suspect they are dependencies on what @ldeavila installed.
Bottom line for me is that with CentOS7 the group install is missing some libraries (at least compared to CentOS6), so this is an OS issue.
However, some documentation about additional fonts required would be good, IMO


bump win32 5.5.0, fix Deprecated, and drop resource_portable

Please fix the issues I the CI:
https://github.com/gmpassos/win32_gui/actions/runs/8866249287


Slow Zones map should reflect currently selected date

Right now there's still a shim new Date() here:
https://github.com/transitmatters/t-performance-dash/blob/29dcb8965f1da6b844ba87bada58b5c96234f47b/modules/slowzones/map/SlowZonesMap.tsx#LL68C1-L68C1
We'll want to pass in the upper bound of the currently selected date range. We'll also want to make it very clear in the UI that we're showing slow zones for that date (which could be far in the past).

Something like this:
(and if the date is today, show Today)
There's a function somewhere to check if date === today and convert to "Today" somewhere already.


#49 clap 4 support

#49 clap 4 support

TODO:

[ ] Fix test
[ ] Add new keys

[ ] Command
[ ] Arg
[ ] ArgGroup


Fixing issue with new matchmaking

Fixes #117
After doing some investigations, I found out that the new matchmaking system is using different messages whenever players are in parties or playing alone.
For instance, when you play alone, this is the line in the logs which is looked for:
[StateMatchmaking] Begin matchmaking solo
But when you play with a party, the logs now print the following:
[StateMatchmaking] Begin party communications
The code still uses the "Begin matchmaking" words to understand a new show is being played.
The solution I found is to look for "[StateMatchmaking] Begin" instead. There was some side effects on the party detection code, but easily fixable.

Hopefully now everything is fine.
Sorry for the trouble, maintainers.

Ill update the zip files later tonight when I have some time. Thanks for looking into this.


Fix uniform

Description
Fix uniform  LFP cases to note add 0.0s to all depletable.

Checklist

[x] This PR has only one purpose or idea.
[x] Tests have been added/updated to verify that the new/changed code works.

[x] The code style follows good practices.
[x] The commit message(s) follow good practices.

[x] The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
[x] The documentation is still up-to-date in the doc folder.
[x] The dependencies are still up-to-date in setup.py.

Note: We assumed that adding nuclides to components at a number density of 0.0 in #1257 would not have any adverse effects. However, it impacted our downstream integration testing pretty significantly so we're narrowing the scope of when this is done in this PR.

@onufer I've tested on downstream integration tests and this works. I also added a unit test that would have failed before this PR.


Fix #54 and #55

@TangleAccountant - can you please send 75 SOON to @emmap3-do for her contribution. See changes in the PR with all the details.

@emmap3-do - fyi, I had to close the #58 PR. It was conflicting with another branch name I've created in the past.

75 SOON has been sent: https://explorer.shimmer.network/shimmer/transaction/0x56489b51966ec95232993af2bc9a1e764bf9f478542e0c38c3a97097f4f534b6


Configure table-of-contents heading levels (h2, h3, h4...)

💥 Proposal
(A clear and concise description of what the proposal is.)
Have you read the Contributing Guidelines on issues?
I read the issue side.
Docs: ToC is created using only <h2> and <h3>.
After changing<EMAIL_ADDRESS>with the code below and setting minDepth and maxDepth, Users can display the ToC in the desired range.
This code has only been tested on my page. I am not familiar with javascript and I always write docs from <h1>(#). So I'm not sure if the code below is ok.
function search(node) {
  const headings = [];
  const minDepth = 1;
  const maxDepth = 4;
  const current = Array(maxDepth - minDepth + 1).fill(-1);
  let previousDepth = 0;

  const onHeading = (child, index, parent) => {
    const value = toString(child);

    if (parent !== node || !value || child.depth > maxDepth || child.depth < minDepth) {
      return;
    }

    const entry = {
      value: toValue(child),
      id: child.data.id,
      children: [],
    };

    if (!headings.length || previousDepth >= child.depth) {
      previousDepth = child.depth;
      current.fill(-1, child.depth - minDepth + 1)
    }

    index = child.depth - minDepth;
    let table = headings;
    for(let i = 0; i < index; i++) {
      table = table[current[i]].children;
    }
    table.push(entry);
    current[index] += 1;
  };

  visit(node, 'heading', onHeading);

  return headings;
}

Hey @hhk7734 I appreciate your suggestion, but I don't know if make sense allows the TOC in every level of Heading. The goal of the TOC is set highlights for sections, if you put a Head like h5, h6 sounds like less important, so for me is ok not include in TOC.

Hi @fanny
The range that user want to display may be different. I want to be able to set the range. So I used minDepth and maxDepth in the code.

I think this will be a useful feature, definitely we need it. However, the algorithm presented in the issue does not seem reliable, we need to work on a better solution. PR as always welcome.
Similar issue on Canny - https://docusaurus.canny.io/admin/board/feature-requests/p/configuration-option-for-table-of-content

A workaround to make it configurable is:
<!-- {tocMinDepth: 1, tocMaxDepth: 4} -->

# h1

const plugin = (options = {}) => {
  const name = options.name || 'toc';

  const transformer = (node) => {

    // Because frontmatter is not passed along we must use comments instead for config.
    const firstComment = node.children.find(node => node.type === 'comment')
    let config = {}
    if (firstComment) {
      config = require('json5').parse(firstComment.value)
    }
    // --

Have to use hacky comments because frontmatter is inaccessible. See: https://github.com/facebook/docusaurus/issues/3935

This feature would be very much appreciated for documentation regarding nested objects, such as a complex JSON schema.

This feature would help new electron docs.


Add a wiki: Enter the Gungeon Wiki

Link to origin wiki: https://enterthegungeon.fandom.com/wiki/Enter_the_Gungeon_Wiki
Link to destination (independent) wiki: https://enterthegungeon.wiki.gg/wiki/Enter_the_Gungeon_Wiki

Added in https://github.com/KevinPayravi/indie-wiki-buddy/commit/723b8957b26db9443a6eaf586fcd3534e665352e, will be in the next release. Thank you!

Also closes #474

Released in v3.6.0 (available for Chrome, and should be available for Firefox soon)


Revert "improve the logger and make tests pass"

Reverts Sujit-O/pykg2vec#118
I found that this creates this issue for my environment.
Traceback (most recent call last):
File "train.py", line 38, in
main()
File "train.py", line 34, in main
trainer.train_model()
File "C:\Users\louisccc\Anaconda3\envs\tf2\lib\site-packages\pykg2vec-0.0.50-py3.6.egg\pykg2vec\utils\trainer.py", line 116, in train_model
self.generator = Generator(self.model)
File "C:\Users\louisccc\Anaconda3\envs\tf2\lib\site-packages\pykg2vec-0.0.50-py3.6.egg\pykg2vec\utils\generator.py", line 299, in init
self.create_feeder_process()
File "C:\Users\louisccc\Anaconda3\envs\tf2\lib\site-packages\pykg2vec-0.0.50-py3.6.egg\pykg2vec\utils\generator.py", line 318, in create_feeder_process
feeder_worker.start()
File "C:\Users\louisccc\Anaconda3\envs\tf2\lib\multiprocessing\process.py", line 105, in start
self._popen = self._Popen(self)
File "C:\Users\louisccc\Anaconda3\envs\tf2\lib\multiprocessing\context.py", line 223, in _Popen
return _default_context.get_context().Process._Popen(process_obj)
File "C:\Users\louisccc\Anaconda3\envs\tf2\lib\multiprocessing\context.py", line 322, in _Popen
return Popen(process_obj)
File "C:\Users\louisccc\Anaconda3\envs\tf2\lib\multiprocessing\popen_spawn_win32.py", line 65, in init
reduction.dump(process_obj, to_child)
File "C:\Users\louisccc\Anaconda3\envs\tf2\lib\multiprocessing\reduction.py", line 60, in dump
ForkingPickler(file, protocol).dump(obj)
TypeError: can't pickle _thread.RLock objects

I think it is because the creation of the generator requires to pickle every member in the callee (trainer.py) and thus also need to pickle self.logger. but logger can't be pickled as it uses lock.
Take a look at this:
https://stackoverflow.com/questions/52019181/adding-logger-causes-cant-pickle-thread-rlock-objects-error
And one possible solution is probably this:
https://stackoverflow.com/questions/3375443/how-to-pickle-loggers


[Bug] mysql-connector-python-8.2.0 cannot connect to FE

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
2.0.3 (or may be all versions of doris)
What's Wrong?
Cannot connect to doris with mysql-connector-python-8.2.0 (install with pip3 by default on macOS ventura)
pip3 install mysql-connector-python

the following code does not work
import mysql.connector

cnx = mysql.connector.connect(user='gavin', password='pass', host='localhost', port=8030)
cnx.connect()
cursor = cnx.cursor()
cursor.execute("show databases;")
for i in cursor:
    print(i)
cnx.close()

it throws the following error
Traceback (most recent call last):
  File "/Users/user/workspace/python/mysql-connector/mysql_test.py", line 3, in <module>
    cnx = mysql.connector.connect(user='user', password='gavin', host='localhost', port=8030)
  File "/Users/user/Library/Python/3.9/lib/python/site-packages/mysql/connector/pooling.py", line 294, in connect
    return MySQLConnection(*args, **kwargs)
  File "/Users/user/Library/Python/3.9/lib/python/site-packages/mysql/connector/connection.py", line 169, in __init__
    self.connect(**kwargs)
  File "/Users/user/Library/Python/3.9/lib/python/site-packages/mysql/connector/abstracts.py", line 1237, in connect
    self._open_connection()
  File "/Users/user/Library/Python/3.9/lib/python/site-packages/mysql/connector/connection.py", line 355, in _open_connection
    self._do_auth(
  File "/Users/user/Library/Python/3.9/lib/python/site-packages/mysql/connector/connection.py", line 288, in _do_auth
    ok_pkt = self._authenticator.authenticate(
  File "/Users/user/Library/Python/3.9/lib/python/site-packages/mysql/connector/authentication.py", line 376, in authenticate
    pkt = bytes(sock.recv())
  File "/Users/user/Library/Python/3.9/lib/python/site-packages/mysql/connector/network.py", line 631, in recv
    return self._netbroker.recv(self.sock, self.address)
  File "/Users/user/Library/Python/3.9/lib/python/site-packages/mysql/connector/network.py", line 231, in recv
    header = self._recv_chunk(sock, size=PACKET_HEADER_LENGTH)
  File "/Users/user/Library/Python/3.9/lib/python/site-packages/mysql/connector/network.py", line 178, in _recv_chunk
    raise InterfaceError(errno=2013)
mysql.connector.errors.InterfaceError: 2013: Lost connection to MySQL server during query

however the older version works
 pip3 install --force-reinstall -v "mysql-connector-python==8.0.16"

What You Expected?
Get connected to doris FE with mysql-connector-python-8.2.0
How to Reproduce?
install with pip3 mysql-connector-python-8.2.0 (by default on macOS ventura)
pip3 install mysql-connector-python

run the following code
import mysql.connector

cnx = mysql.connector.connect(user='gavin', password='pass', host='localhost', port=8030)
cnx.connect()
cursor = cnx.cursor()
cursor.execute("show databases;")
for i in cursor:
    print(i)
cnx.close()

Anything Else?
A tcpdump shows that doris FE ended the connection prematurely

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi, can you please share fe.log? Also did you change default port config? 8030 is http config by default. For mysql default is 9030. Code snap shows 8030. Can you please recheck it?

Hi, can you please share fe.log? Also did you change default port config? 8030 is http config by default. For mysql default is 9030. Code snap shows 8030. Can you please recheck it?

@Vallishp  I've customized the query port in fe.conf, the port is for demonstration, and I've already mentioned that "the older version of mysql-connectory-python works". There is also a tcpdump what happened when mysql-connectory-python-8.2.0 tried to connect doris, please check the last section of the issue report.

@gavinchou  I was able to test with latest master version for Doris.

May be can you please check and share fe.log file. From tcpdump connection getting closed. We might get some clue from the fe.log about.

@Vallishp Thank you for your reply, I tried to reinstall 8.2.0 and cannot reproduce the issue I just reported, that's weird... There may be something wrong that I didn't notice.
This issue can be closed.

hi.
Is this problem related to https://github.com/apache/doris/issues/31857?
Is it solved by upgrading doris?


fix: handle multithreaded writes of pyarrow models

Multi-threaded writing of python models returning pyarrow.Table fails due to an upstream bug: https://github.com/duckdb/duckdb/issues/6584

add in the workaround to import pyarrow.dataset on materialization.
remove the round-trip conversion of python models returning a duckdbPyRelation to a pyarrow.Table/pandas.DataFrame and back. This will also enable polars or any other dataframe-like models to work within dbt-duckdb.

@jwills @tomsej is there some subtle detail I'm missing about why this round-trip logic was here in the first place? Some old bug with duckdb not finding bound DuckdbPyRelation variables?
Related: https://github.com/duckdb/duckdb/issues/5038 was fixed as of duckdb 0.6.0 so might want to go this route instead of relying on duckdb's magic variable binding.

@AlexanderVR I don't totally follow this-- why did the Pandas stuff come out too?

@jwills because I don't understand why it was there in the first place. Hence my question :-D
The line con.execute("create table {{...}} as select * from df") already will convert a DuckdbPyRelation, pandas DataFrame, or pyarrow Table into the duckdb table -- whatever the df variable is. Even a Polars Dataframe. Isn't this all we want when materializing a python model?
The old logic was first checking to see if it was passed a DuckdbPyRelation. If it was, it would then convert to pandas or pyarrow, whichever was available. Then the create table {{...}} as select * from df is taking this pyarrow Table or pandas DataFrame and converting it back into duckdb format!

Ah, I think I get you-- you're saying that there is no need for the checks, because there isn't really anything for them to do; either the conversion to a DuckDB table works or it doesn't?

Yes that is correct in that either the conversion works or it doesn't. But my larger question was why the choice of duckdbPyRelation -> pandas/pyarrow -> duckdb table instead of duckdbPyRelation -> duckdb table directly?
The former conversions will have issues with larger-than-memory datasets. They also cause issues with Union data types because duckdb will not convert Unions to/from arrow format https://github.com/duckdb/duckdb/issues/1742

yeah these are all good points and I don't have a good answer; going to merge this shortly. Thank you!

I expected this example to work, but it didn't:
def model(dbt, session):
    dbt.config(materialized = "table")

    df = dbt.ref("my_seed")

    return df

I got a Runtime Error:
Python model failed:
Invalid Input Error: Python Object "df" of type "DuckDBPyRelation" found on line "/.../tmpf2.py:76" not suitable for replacement scans.
Make sure that "df" is either a pandas.DataFrame, or pyarrow Table, Dataset, RecordBatchReader, or Scanner

My return statement needed to be this instead:
    return df.df()

or this:
    return df.arrow()

I wonder if this is why that isinstance(df, duckdb.DuckDBPyRelation) logic was in there?

Ah yeah I bet you’re right @dbeatty10– but it seems like we can/should just treat DuckDBPyRelations as valid objects (albeit ones that need to be handled a bit differently)


Return failure if no tests are run or ignored

Add helper function to TestResult
Make TestOutput report error based on it
Make runAllTests() return non-zero based on it

Fixes #1262

If (when?) new cpputest release is created, this change should be listed as significant/ breaking, I believe.

Coverage increased (+0.0002%) to 99.847% when pulling 4d0e7c4f3f7a0de0b63693a8be37c015420fdcd1 on nokia:fail-for-no-run into bc265416d3f4deab45259dbce0b640a26c3c62ec on cpputest:master.

Good and clear!

DOS build failed with timeout: The job exceeded the maximum time limit for jobs, and has been terminated.
No idea what's wrong, but seems all was passing before it got aborted.

Yeah, the dos build is because it needs to download something. We need to find a way to fix that.


Installation on windows

Thanks for the great tool !
I don't manage to build the solution in Visual Studio. When building, I get lots of errors such as "cannot open source file "assert.h" ".
I am using Visual Studio 2019.
I also have this warning : "Platform 'ORBIS' referenced in the project file 'lolremez' cannot be found.".

Did you get all submodules recursively as explained in README.md?
(note: platform “ORBIS” is a code name for the PlayStation 4, so you can safely ignore the warning if you do not have development tools for that platform)

Ok thanks !
Yes I did : "git submodule update --init --recursive"


HDFS-9106. Transfer failure during pipeline recovery causes permanent write failures. Contributed by Kihwal Lee.

(cherry picked from commit 6e7c76a5bd6e3376efad6763308932ae02917002)
Change-Id: I965a2e20ac3e44175313a9ebbf1b4d590a662387

+1


Fixed #25453 -- Reworded ask_not_null_alteration suggestion of makemigrations command

https://code.djangoproject.com/ticket/25453

merged in de31423130912a012513aad93ec805f8e08a0d5e, thanks!


No module named 'unetr_pp'

Hello, when I run the script run_training.py, this happens, what is going on? path is ok

Hello,
You have to run it from the main directory path of the repository:
Similar to this command: python unetr_pp/run/run_training.py 3d_fullres unetr_pp_trainer_synapse 2 0

Hello,
You have to run it from the main directory path of the repository:
Similar to this command: python unetr_pp/run/run_training.py 3d_fullres unetr_pp_trainer_synapse 2 0

I run it from the main directory, and it still reports an error. I try these two commands, but they don’t work.
 python unetr_plus_plus/unetr_pp/run/run_training.py，python unetr_pp/run/run_training.py
The error  as follows:

Hi @MOMOANNIE,
Please make sure to run the training from the provided training script in the repo "run_training_synapse.sh"
You can't just run the python file as there are the following variables you must set before running the training script:
DATASET_PATH=DATASET

export PYTHONPATH=./
export RESULTS_FOLDER=output_synapse_UNETR_GitHub
export unetr_pp_preprocessed="$DATASET_PATH"/unetr_pp_raw/unetr_pp_raw_data/Task02_Synapse
export unetr_pp_raw_data_base="$DATASET_PATH"/unetr_pp_raw

python unetr_pp/run/run_training.py 3d_fullres unetr_pp_trainer_synapse 2 0

Hi @MOMOANNIE,
Please make sure to run the training from the provided training script in the repo "run_training_synapse.sh"
You can't just run the python file as there are the following variables you must set before running the training script:
DATASET_PATH=DATASET

export PYTHONPATH=./
export RESULTS_FOLDER=output_synapse_UNETR_GitHub
export unetr_pp_preprocessed="$DATASET_PATH"/unetr_pp_raw/unetr_pp_raw_data/Task02_Synapse
export unetr_pp_raw_data_base="$DATASET_PATH"/unetr_pp_raw

python unetr_pp/run/run_training.py 3d_fullres unetr_pp_trainer_synapse 2 0

Ok thank you, after running run_training_synapse.sh, there is another problem, as follows:
  with open(file, mode) as f: FileNotFoundError: [Errno 2] No such file or directory: '/home/project/DATASET/unetr_pp_preprocessed/Task032/unetr_pp_Plansv2.1_plans_3D.pkl'
This is because I did not preprocess my data. If it is my own data, how should I preprocess it?

You should do it in the same way as nnFormer setting up the datasets.

Hello, I had the same problem, my folder structure is similarity with https://github.com/Amshaker/unetr_plus_plus/tree/main/unetr_pp
and i'm running the training script:"bash training_scripts/run_training_synapse.sh
", the problem still exists.
Can you help me to solv the problem?


Swiper not working on Internet Explorer

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 5.2.1

Platform/Target and Browser Versions: Windows 10, Internet Explorer Version: 11.476.18362.0.

What you did
We implemented Swiper library in our project. We tried to use Scroll Container on Internet Explorer Version: 11.476.18362.0.
Expected Behavior
Scroll Container should be working properly with the mouse scroll, but it doesn't.
Actual Behavior
You can't scroll with the mouse scroll because of Math.sign() is not supported for IE11. The official demo are not working on IE11 either - https://swiperjs.com/demos/.
Before you open an issue, please check if a similar issue already exists or has been closed before.

Sorry but Internet Explored is not supported by Swiper

@Jotomen91 when you can babel, you can add swiper and dom 7 , it work in ie11


object instead of classes for Mappers

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Difficult to debug extractors

I know a little bit of Python, so I decided to try to debug the bug I just filed, issue #6699.  I cloned the repo and did the following in a terminal (which, by the way, was very non-obvious, because doing what CONTRIBUTING.md suggested doing (python -m youtube_dl) loaded my distro's out-of-date module, not the one in the current directory):
$ python
>>> from youtube_dl.extractor.youtube import YoutubeUserIE
>>> e = YoutubeUserIE()
>>> e.extract("https://www.youtube.com/user/rhettandlink2")

The output I get is this:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "youtube_dl/extractor/common.py", line 287, in extract
    return self._real_extract(url)
  File "youtube_dl/extractor/youtube.py", line 1617, in _real_extract
    'Downloading channel page', fatal=False)
  File "youtube_dl/extractor/common.py", line 438, in _download_webpage
    res = self._download_webpage_handle(url_or_request, video_id, note, errnote, fatal, encoding=encoding)
  File "youtube_dl/extractor/common.py", line 345, in _download_webpage_handle
    urlh = self._request_webpage(url_or_request, video_id, note, errnote, fatal)
  File "youtube_dl/extractor/common.py", line 324, in _request_webpage
    self.to_screen('%s: %s' % (video_id, note))
  File "youtube_dl/extractor/common.py", line 495, in to_screen
    self._downloader.to_screen('[%s] %s' % (self.IE_NAME, msg))
AttributeError: 'NoneType' object has no attribute 'to_screen'

This doesn't seem to make sense, because the docstring says this:
>>> help(YoutubeUserIE)
...
 |  extract(self, url)
 |      Extracts URL information and returns it in list of dicts.

It would seem that the only thing this method should do is to return a list.  But instead, it also generates output to the screen, and fails if not run from...the executable script, I guess?
So, since I had run youtube-dl with --dump-pages earlier, I loaded one of the pages (which was a JSON playlist segment) into Python and tried to extract directly from the file:
>>> with open('/tmp/yt/test') as f:
>>>     testpage = f.read()
>>> e.extract_videos_from_page(testpage)
[]

This makes no sense, because, having looked at YoutubeChannelIE.extract_videos_from_page, it looks like it should parse out the videos from testpage, which looks like this:
>>> testpage
'{"content_html": "      \\n\\n\\n\\u003ctr class=\\"pl-video yt-uix-tile \\" data-set-video-id=\\"\\" data-title=\\"Awkward Elevator Situation (Wheel of Mythicality - Ep. 30)\\" data-video-id=\\"2DpaTtjq1II\\"\\u003e\\u003ctd class=\\"pl-video-handle \\"\\u003e\\u003c\\/td\\u003e\\u003ctd class=...

Now I see that there are double-escaped quotes in there, which will  mess with the regexp in YoutubeChannelIE.extract_videos_from_page.  So I try to follow the chain of functions that download pages and parse them and decode them to find out how the corrected HTML gets to extract_videos_from_page()...but I am lost in a maze of functions calling functions calling functions, from one file to another, across directories...
I will try to summarize:

The instructions in CONTRIBUTING.md are not helpful for trying to debug extractors from a current, cloned repo.
The aforementioned extract() method should do only what it says (return a list), not also output to the screen, which fails if not correctly initialized (for which there is no documentation).
Maybe I'm just a noob, but after about the 5th link in a method-that-calls-another-method-in-another-file-in-another-directory chain, I get lost.  All I want to do is import the appropriate module that contains the appropriate extractor, pass it a) URL, or b) some raw HTML, and see what the result is so I can figure out why its regexp isn't working.  This seems like it's harder than it should be.

If these issues could be addressed, I would imagine that more people would be able to contribute by fixing the inevitable broken extractors that happen when sites change.
Thanks for any help and for making youtube-dl.  I don't mean this to be rude or harsh criticism; I'm just trying to document how I tried to debug it and got stuck so that perhaps the process can be improved.

python -m youtube_dl works perfectly for me, make sure you are running it from the correct directory.
It's not too clear, but extractors only work if they have the .downloader correctly set (via set_downloader or the initialization). So if you really want to use directly the extractor you have to do something like:
from youtube_dl import YoutubeDL
from youtube_dl.extractor import YoutubeUserIE

ydl = YoutubeDL()
ie = YoutubeUserIE(ydl)
info = ie.extract("https://www.youtube.com/user/rhettandlink2")

But in general you shouldn't use the extractors directly:
from youtube_dl import YoutubeDL

ydl = YoutubeDL()
# this resolves redirects and extracts info from playlist import entries
info = ydl.extract_info("https://www.youtube.com/user/rhettandlink2", download=False)

Instead of writing python, the method I use (and probably other developers do the same) is to call the program with the correct parameters (python -m youtube_dl URL OTHER_ARGS) and if necessary I put some print(...) call in the extractors to debug them.
About the problem with all the function calls, most functions do a relatively simple thing (download a webpage, extract some value with a regex ...) which simplifies the process and others are used to reduce the complexity of some extractors (in the case of extract_videos_from_page it's called in two of the possible branches of the extraction). I don't think there's a better alternative.

Thanks for your kind answer.  That helps me understand it a lot better.  I'll see what I can do.
If I may, I suggest that some of this info be added to the CONTRIBUTING.md file.  :)

Thanks to your help here, I was able to fix the bug!