Small problem

While rewriting your script to python, I discovered a small problem
list_counter=1 will be make fail create lists if chunk lists > cloudflare current lists > 1
I think  change to list_counter = current_lists_count + 1 is better
Sorry about my English and thanks for your creations

Hi,
Maybe I'm misunderstanding but I think it's correct that list_counter=1.
list_counter is to keep track of the next list name, so it starts as "Block ads - 001".
First the code overwrites the existing lists. Here it doesn't use list_counter, it only updates with each list to list_counter += 1: https://github.com/jacobgelling/cloudflare-gateway-block-ads/blob/b3167d6d520db26999811b5edd8f34b69078385b/block_ads.sh#L81-L127
Then checks if more lists need creating (when chunk lists > cloudflare current lists > 1). It names the new list using list_counter: https://github.com/jacobgelling/cloudflare-gateway-block-ads/blob/b3167d6d520db26999811b5edd8f34b69078385b/block_ads.sh#L129-L157
Finally it checks if lists need deleting (when chunk lists < cloudflare current lists): https://github.com/jacobgelling/cloudflare-gateway-block-ads/blob/b3167d6d520db26999811b5edd8f34b69078385b/block_ads.sh#L246-L252

Oh, sorry. My mistake

I completed convert your repository. Please visit
https://github.com/luxysiv/ads

Thanks alot for your work


Example of adding PostCSS plugins?

Hello. I've tried to get codepan working with PostCSS plugins but I'm not sure how to configure it.
I tried adding a postcss.config.js file:
module.exports = {
  plugins: {
    'autoprefixer': {},
  }
}

but nothing happens so I think maybe I'm not configuring it correctly?
Do you have an example of adding a plugin?
Many thanks!

@mindthetic maybe this one https://github.com/egoist/codepan/commit/79755674611b7e7a0d7b7b21bf745add9505de6d


Add forced cuda version to workshop install

Background
It is sometime necessary to install PyG with CUDA, when if the current machine does not have CUDA support. For example, when setting up a development environment on a disk shared between a server and a GPU cluster.
Solution
Add optional argument --force-cuda-version for workshop install, overrides automatically detected CUDA version.

Indeed, I also faced this exact issue and manually had to install PyG instead of via the CLI. Would be good to automate this.


Using the same valueconverter on shared property causes an endless loop

I'm submitting a bug report

Library Version:
1.0.3

Please tell us about your environment:

Operating System:
Windows 10

Node Version:
5.9.1

NPM Version:
3.10.5

JSPM OR Webpack AND Version
Aurelia CLI

Browser:
Chrome

Language:
all

Current behavior:
I am using a valueconverter (sorter) on a dependency injected container-class. My use case is I have a list displayed with minimal details. When pressing a 'show details' button a dialog appears with the same list but more details. I want to show the list and re-use a custom valueconverter (sorter) to sort both the first list and the second.
When the list is rendered on the first view and sorted, there are no issues. However when the dialog is attached and the second list is rendered in the dialog, the valueconverter triggers a re-render of the first list. This results in both the lists triggering re-render on eachother and an endless loop hangs the browser.
Problem can be viewed here ( https://gist.run/?id=20e6fcd1e2b79ea16cf2a31606ade0eb )
Uncomment the second table and run, browser will hang.
Expected/desired behavior:
I expect to be able to re-use a valueconverter on a shared property without getting endless loop

What is the expected behavior?
Rendering of both views without problems.

What is the motivation / use case for changing the behavior?
Being able to re-use shared resources without having problems if they appear in the DOM at the same time.

Issue moved to aurelia/binding #482 via ZenHub


A lot of exceptions in Rider 2023.2 EAP*

Rider and R# 2023.2 contains breaking API change. Which produce a lot of exceptions when MoqComplete installed.
I will prepare fix for that issue.
--- EXCEPTION #1/2 [TypeLoadException]
Message = “Could not load type 'JetBrains.ReSharper.Psi.CSharp.Tree.IRegularParameterDeclaration' from assembly 'JetBrains.ReSharper.Psi.CSharp, Version=7<IP_ADDRESS>, Culture=neutral, PublicKeyToken=1010a0d8d6380325'.”
ExceptionPath = Root.InnerException
ClassName = System.TypeLoadException
HResult = COR_E_TYPELOAD=80131522
Source = Abc.MoqComplete.Rider
TypeLoadClassName = JetBrains.ReSharper.Psi.CSharp.Tree.IRegularParameterDeclaration
TypeLoadAssemblyName = “JetBrains.ReSharper.Psi.CSharp, Version=7<IP_ADDRESS>, Culture=neutral, PublicKeyToken=1010a0d8d6380325”
TypeLoadResourceID = -2146233054
StackTraceString = “
  at Abc.MoqComplete.CompletionProvider.MockVariableNameProvider.AddLookupItems(CSharpCodeCompletionContext context, IItemsCollector collector)
     at JetBrains.Util.Logging.Logger.CatchIgnoreException[TValue,TException](Func`1 F, TValue defaultValue) in CatchIgnoreException.il:line IL_0032 mvid B953
”

Many thanks for the PR, that's really helpful!
I'll release a new version soon, I just need to figure out how all of this works 😅 (the previous maintainer left and someone else needs to takes over).

I've submitted updates to the marketplace.

https://plugins.jetbrains.com/plugin/12659-moqcomplete/versions
Not sure what's going on, but Rider will install 2<IP_ADDRESS> instead of 2<IP_ADDRESS> when running latest 2023.2 EAP2.

Damn, I first submitted 2<IP_ADDRESS> and then 2<IP_ADDRESS> in order to fix #32. Looks like the JetBrains marketplace sorts extensions by date and not by version... 😕
@ArtManyak should I re-upload a copy of 2<IP_ADDRESS> as 2<IP_ADDRESS>, or is there a better approach?

Ok, I noticed I can edit the compatibility ranges of existing versions, so I fixed it that way.

Works fine now :+1:


Tabs Re-Rendering Child components when switching between tabs

Bug Report
Description

"Tabs.Pane" Component Re Rendering Child Component of "TabContentTemplate" when switching Between Tabs.

Steps to Reproduce

Create Tab Component
Create Tabs Pane Component With Child component
Switch Between Tabs

Additional Context / Screenshots

Our Use case is to use the Tabs for Screening, So we have each Tab denoting a particular Section, Each Section has a set of questions.
When we enter all the question inputs and switch to another tab and switch back. It Re-Renders the Tab content, therefore Re-Setting all the inputs which were already Screened.
Not sure if this is intentional, Can this be fixed or is there a workaround that we can use for this case.
First Tab Screened

Switching To Second Tab

Switching Back To Screened Tab

Expected Behavior

Expected the Tab to hide/show the content of Tabs.pane when switching between tabs instead of Re-Rendering.
Possible Solution

Environment

Component Name and Version:"terra-tabs": "^6.33.0"
Browser Name and Version: Chrome
Node/npm Version: 10
Webpack Version:"webpack": "^4.42.0"
Operating System and version (desktop or mobile): MAC OS 10.14.6

@ Mentions

@supreethmr

@shahabkhan10 unfortunately this a limitation of tabs and something that we do not have plans to change at the moment.  Our recommendation if you need to keep track of state across tabs is to keep the state at a higher level than the tabs themselves.  That way when things re-render, you will still have access to that state.


Json contains push tikv

What is changed and how it works?

Issue Number: Close https://github.com/tikv/tikv/issues/13468
What's Changed:
Implement json_contains function push down to tikv
I

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression

Consumes more CPU
Consumes more MEM

Breaking backward compatibility

Release note
Implement json_contains function push down to tikv

/run-DCO

/cc @xiongjiwei
/cc @sticnarf
/cc @AndreMouche

/tests

/cc @gengliqi

/tests

/tests

PTAL @sticnarf

/tests

/merge


Update README.md

NPMplus.md

Updated the Readme.

I have updated the readme to include better Goaccess and geoipupdate instructions
NPMplus.md


Improve Documentation - Add a new Section

Documentation is written using https://www.docz.site/ .
We wish to improve it by adding a new Section named Example .
Documentation is available at: https://iusehooks.github.io/usetheform/
Any help is welcome!

Ok. Leave it for me.

Finished : https://github.com/iusehooks/usetheform/pull/40

hey there , i was just thinking if this current issue is still open I would like to make the required changes you want?

It is still opened. Thanks

@iusehooks is this issue still open

Hi @yashdev9274 , it is still opened. Thanks

actually I'm new to github contribution can you guide me how can i help

You could start reading: https://github.com/iusehooks/usetheform/blob/master/CONTRIBUTING.md

Hi, this is my first time, hope I can contribute.

is this issue still open i would like to contribute @iusehooks

Hello @iusehooks , if this is still open please assign this to me. I am new to open-source and I would love to contribute.

is this issue still open i would like to contribute @iusehooks

is this issue still open i would like to contribute @iusehooks

is this issue still open i would like to contribute @iusehooks

Hi @salunkechetan issue is still open you can contribute. Thanks

Hello @iusehooks , if this is still open please assign this to me. I am new to open-source and I would love to contribute.

Hi @Ansh1372 issue is still open you can contribute. Thanks

is this issue still open i would like to contribute @iusehooks

Hi @DhirajGilda issue is still open you can contribute. Thanks

Hello @iusehooks , if this is still open please assign this to me. I am new to open-source and I would love to contribute.

Hi @Pratik-Mahajan257 issue is still open you can contribute. Thanks

Hello @iusehooks , if this is still open please assign this to me. I am new to open-source and I would love to contribute.

Hello @iusehooks  , I am interested in fixing this issue but facing difficulty in understanding it . Can you please tell me in detail what you want to add in the documentation and where do you want to add it ?

Hello @iusehooks , I am interested in fixing this issue but facing difficulty in understanding it . Can you please tell me in detail what you want to add in the documentation and where do you want to add it ?

Hi @Aryan123-rgb a possible improvement could be to write other examples in the following section:

https://iusehooks.github.io/usetheform/#codesandbox-examples

for instance:

https://codesandbox.io/s/shopping-cart-97y5k

Thanks.

Is this thread still open please assign it to me.. I would love to contribute

Hii @iusehooks , Is this still open then i would like to contribute

Hi @iusehooks, Is this thread still open? I would love to contribute.

Hi @iusehooks, Is this still open then i would like to contribute.

Hi , @iusehooks  Is it still available ?? Can I work on it ?

Hey @iusehooks, I have been following the thread and was wondering like the others above me if I:
1.) Can have a shot at this issue ticket? Of course, Assuming it's still open.
2.) Where do I go to ensure that I am following the projections contribution guidelines?
3.) If I have questions or get stuck, Where can I contact the time?

@iusehooks Is this still open ? I want to contribute.

/assign


Get comment Ajax working

i think it's still only finding the first div. might have to rethink page structure.

Finally fixed this.


GradCAM for SwinTransformer

I am using image models from timm package.
Similar to ViT, I tried accessing normalization layer of last block of last layer in SwinTransformer. After using GradCAM++ the results from ViT and swin transformer have a huge difference, Swin transformer's accuracy is better than ViT but the gradient map is very different. I would like to know am I using right layer of Swin Transformer or should change some configurations in the GradCamPlusPlus module.
from timm.models import swin_base_patch4_window7_224_in22k
from pytorch_grad_cam import GradCAMPlusPlus
from pytorch_grad_cam.utils.image import show_cam_on_image, preprocess_image
def reshape_transform(tensor, height=6, width=8):
    result = tensor[:, 1 :  , :].reshape(tensor.size(0),
        height, width, tensor.size(2))

    # Bring the channels to the first dimension,
    # like in CNNs.
    result = result.transpose(2, 3).transpose(1, 2)
    return result
model = swin_base_patch4_window7_224_in22k(pretrained=True,num_classes = 5)
model.cuda()
target_layer = model.layers[-1].blocks[-1].norm1
cam = GradCAMPlusPlus(model=model,
                      target_layer=target_layer,
                      reshape_transform=reshape_transform)

rgb_img = cv2.imread(img_path, 1)[:, :, ::-1]
rgb_img = cv2.resize(rgb_img, (224, 224))
rgb_img = np.float32(rgb_img) / 255
input_tensor = preprocess_image(rgb_img, mean=[0.5, 0.5, 0.5],
                                          std=[0.5, 0.5, 0.5]).cuda()
grayscale_cam = cam(input_tensor=input_tensor,
                    target_category=0,
                    eigen_smooth=True,
                    aug_smooth=True)

grayscale_cam = grayscale_cam[0, :]
cam_image = show_cam_on_image(rgb_img, grayscale_cam)
cv2.imwrite('save_path.jpg', cam_image)

Original Image

ViT GradCam++

Swin Transformer GradCAM++

What was class_index used in the example above?

I fine-tuned the model with a classifier head on a specific a dataset. It's not a part of ImageNet.

OK There are several different issues here.
The swin transformer, deviates from vit:

No class token, and the activations are 7x7.
def reshape_transform(tensor, height=7, width=7):   result = tensor.reshape(tensor.size(0),        height, width, tensor.size(2))   result = result.transpose(2, 3).transpose(1, 2)   return result

It seems they use the image-net normalization and not the vit normalization (but this may not affect you, however I was using the model from timm)

There seems to be a bug where every forward pass, the model returns something different,
even if the model is in eval.
This bug seems to be in timm.

I think I solved the case,
for ViT, in reshape_tranform you are excluding first token aka the cls_token because it is something used for classification purpose which is included in the input while instantiating the model.
In SwinTransformer there is no such concept for CLS token, therefore the 0th token is part of input not a cls token.
I would like to create a PR for example of Swin Transformer in which I will create an example to generate gradient maps using swin transformer, as well as update the readme file for info. Please allow me to do this.

Cool!

In the Readme it can be added to the "How it works with Vision Transformers" section.
Maybe add a new directory called usage_examples, and put the example for swin transformers there.

Closing this issue, since it seems resolved.

Hi @AmbiTyga, @jacobgil !
I used gradcam to get CAM from Swin-Transformer. About Swin-Transformer, I used this implementation, and I think it is same as timm package.
Following the example of Swin-Transformer, I would get some weird result like following:

I finetune swin-transformer with pascal voc 2012 dataset.
The heatmap of class is correct, horse and person. However, the CAM would cover a square region out of object, and it look like patch of Swin-Transformer?
Is these correct results of gradcam on Swin-Transformer?
Have you ever encountered such problem?
Thank you in advance for your help.

@scott870430 Hi， I had a similar problem with you, have you figured out why?

@SKBL5694 Unfortunately, I couldn't figure out how to solve it, and ultimately, I gave up.

@scott870430 Ok, I'll explore and let you know if I have any results, thanks for the reply


.Net Framwork instructions missing

Since the bot integration with no longer work using azure channel, there are instructions for integrate it using javascript/node js.
What about existing integrations using .Net Framework or .Net Core? Is it there an example to integrate it now?
Thanks

What did you mean by "no longer work using azure channel"? What specifically are you trying to accomplish? Is there any doc you are referring to? We need more details to answer your question. Thank you!

Hey, please provide us with more information as asked in the last thread so that we can better help you.

Hi I misunderstood the message added to the documentation. It says that workplace for facebook is which has no longer support. Facebook messenger will still working.


proposal: error vizualization and variable assing:

I start work with go for some time already and I really like the language. But a thing keeps annoying me for some time...
the main problem for me is the error handler for errors and I know that is a really well-debated point of many people that are developing in go. So I decide to write my idea here just to give my 2 cents for the discussion and if anyone thinks it's interesting we can proceed to make a proposal for that.
i understand that are 2 times in a error, been 1st one identifying and then handling then,
so for my development, I keep writing the same code(its just an example... i use log and all, but the idea is the same) or hiding the errors with _(I know that's not best practice, but we need to identify the errors before we handle then).
x, err := y() if err != nil {   print(err)  }
output: unexpected end of JSON input
and its not readable... because I have 3/4 of my lines of code on this error print stuff...
so my idea is to have a token like '_', lets call it '~' that when have a value attributed it self print on console log or any other way. That solution will cover all default console log for development and if you need a really error handler it will be in the code like...
propose
x, ~ := y()
output: unexpected end of JSON input

See https://github.com/golang/go/issues?q=+label%3Aerror-handling+ for all the previous related error handling proposals.
Please use the forums for general discussions
Closing as this does not appear to be a well fleshed out proposal that can be evaluated.


✨ Find/Replace in Document

Is your feature request related to a problem? Please describe.
We should be able to find strings of text in a document and browse different occurrences.
Concept

@RayZhao1998 Would you like to tackle this one since find is fresh on your mind?

Just a quick consideration, when a query has been entered in the Find input, pressing next after the last result will loop back to the first result and display a temporary HUD symbol in the center of the current editor pane.

Keep


Empty required textarea

An empty textarea has always instance.getType() === 'string' in jsv.js in my case (?) and the required option doesn't work because it is not "undefined" like an empty input string.
Did you notice the same thing?
I am building a tool based on jsonform.js and that works well excepted for the empty required textarea and the validator of jsv.js that I used.
          myitem: {
              type: "textarea",
              title: "Item {{idx}}",
              required: true,
              default:""
            },

https://github.com/jsonform/jsonform/blob/master/deps/opt/jsv.js
My quick fix for empty required textareas in json forms for the validator of jsv.js:
           "required" : {
			"type" : "boolean",
			"default" : false,

			"parser" : function (instance, self) {
				return !!instance.getValue();
			},

			"validator" : function (instance, schema, self, report, parent, parentSchema, name) {
                                    console.log('>> validator2:' + name + ' >> ' + instance.getType() );
				if ( instance.getType() !== "undefined") console.log('>> validator2 value: [' + instance.getValue() + ']');
				if ( ( instance.getType() === "undefined"
                                        || instance.getType() !== "undefined" && instance.getValue().trim() === '' )
				&& schema.getAttribute("required")) {
					report.addError(instance, schema, "required", "Property is required", true);
				}
			}
		},

Hi @alcabon
So this is more a bug with jsv ... unfortunately it is not maintained anymore so I guess your fix is the right solution

Hi @tchapi
https://github.com/garycourt/JSV/blob/master/lib/json-schema-draft-03.js  seems the last version indeed (10 years ago).

Thanks for your help

A bettter fix still limited but sufficient in my case for empty textareas.
|| instance.getType() === "string" && instance.getValue().trim() === ''    // prevent some pb with getValue() not defined
instance.getType() !== "undefined" is not restrictive enough in my case finally for other required fields.
"required" : {
"type" : "boolean",
"default" : false,
			"parser" : function (instance, self) {
				return !!instance.getValue();
			},

			"validator" : function (instance, schema, self, report, parent, parentSchema, name) {

				if ( ( instance.getType() === "undefined"
				|| instance.getType() === "string" && instance.getValue().trim() === ''
				 )
				&& schema.getAttribute("required")) {
					report.addError(instance, schema, "required", "Property is required", true);
				}
			}
		},


[BUG] Operator crashes with ISMPolicy

What is the bug?
A certain ISMPolicy is able to crash the operator, this should not happen.
How can one reproduce the bug?
Apply this policy
apiVersion: opensearch.opster.io/v1
kind: OpenSearchISMPolicy
metadata:
  creationTimestamp: "2024-11-08T12:37:11Z"
  finalizers:
  - opster.io/opensearch-data
  generation: 2
  labels:
    k8slens-edit-resource-version: v1
  name: ism-devops
  namespace: opensearch-testing
  resourceVersion: "369198011"
spec:
  defaultState: hot
  description: A basic policy that will immediately move data to warm, then delete
    after 365 days.
  errorNotification: {}
  ismTemplate:
    indexPatterns:
    - acr-logstash-*
    - github-logstash-*
    - azdevops-logstash-*
    priority: 1
  opensearchCluster:
    name: opensearch-cluster-testing
  policyId: ism_devops
  states:
  - actions: []
    name: hot
    transitions:
    - conditions: {}
      stateName: warm
  - actions:
    - {}
    name: warm
    transitions:
    - conditions: {}
      stateName: cold
  - actions: []
    name: cold
    transitions:
    - conditions: {}
      stateName: delete
  - actions:
    - delete: {}
    name: delete

What is the expected behavior?
Apply this policy and the operator crashes, manually removing the object is needed.
What is your host/environment?
Kubernetes 1.29.0
Do you have any screenshots?
{"level":"info","ts":"2024-11-08T12:38:31.097Z","msg":"Reconciling OpensearchISMPolicy","controller":"opensearchismpolicy","controllerGroup":"o
{"level":"info","ts":"2024-11-08T12:38:31.097Z","msg":"Reconciling OpensearchIndexTemplate","controller":"opensearchindextemplate","controllerG
{"level":"info","ts":"2024-11-08T12:38:31.097Z","msg":"Starting workers","controller":"opensearchuserrolebinding","controllerGroup":"opensearch
{"level":"info","ts":"2024-11-08T12:38:31.097Z","msg":"Reconciling OpenSearchCluster","controller":"opensearchcluster","controllerGroup":"opens
{"level":"info","ts":"2024-11-08T12:38:31.612Z","msg":"Observed a panic in reconciler: runtime error: invalid memory address or nil pointer der
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x17203ec]

goroutine 423 [running]:
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile.func1()
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:115 +0x1e5
panic({0x192c660?, 0x2c45b60?})
    /usr/local/go/src/runtime/panic.go:770 +0x132
github.com/Opster/opensearch-k8s-operator/opensearch-operator/pkg/reconcilers.(*IsmPolicyReconciler).CreateISMPolicy(0xc0066ab780)
    /workspace/pkg/reconcilers/ismpolicy.go:313 +0x36c
github.com/Opster/opensearch-k8s-operator/opensearch-operator/pkg/reconcilers.(*IsmPolicyReconciler).Reconcile(0xc0066ab780)
    /workspace/pkg/reconcilers/ismpolicy.go:172 +0x8f3
github.com/Opster/opensearch-k8s-operator/opensearch-operator/controllers.(*OpensearchISMPolicyReconciler).Reconcile(0xc0003b1ea0, {0x1e0f790,
    /workspace/controllers/opensearchism_controller.go:53 +0x385
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile(0x1e0f790?, {0x1e0f790?, 0xc000fc8210?}, {{{0xc00091a2b8?, 0x185
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:118 +0xb7
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc0006a0820, {0x1e0f7c8, 0xc0003b19a0}, {0x19aaae0, 0xc0
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:314 +0x345
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc0006a0820, {0x1e0f7c8, 0xc0003b19a0})
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:265 +0x1c9
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2()
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:226 +0x79
created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2 in goroutine 99
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:222 +0x50c

Do you have any additional context?

[Triage] @swoehrl-mw @prudhvigodithi Need to debug where we are getting the NPE. Fix should be simple after this is found.

Thanks @swoehrl-mw


Add CSV file with test registrations

Describe your changes
Add CSV file with test registrations for OCW without referenceids, so they do not result in duplicate externalReference when using them on Intersolve Test/Staging Env.
Checklist before requesting a review

[x] I have performed a self-review of my code
[ ] I have added tests wherever relevant
[ ] I have made sure that all automated checks pass before requesting a review
[ ] I do not need any deviation from our PR guidelines

Hi @PeterSmallenbroek , can you review this one?
Maybe we need help from Dom, since I accidentally did a merge instead of a rebase. No idea how to fix this.

@diderikvw Is this PR still relevant or can we close it?

@RubenGeo  I think it is useful as per see above. I guess @PeterSmallenbroek did not get to reviewing yet.

Closing, put the CSV file in another branch :)


Release v0.21.0

Issue #, if available:
Description of changes:
Release v0.21.0
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Code is fine by me 😎 Do it!


Count function doesn't return correct number of elements in range

The following code should print 51 and 52. It does, however, print 51 and 51.
Print(Count(Range(0, 50)))
Print(Count(Range(0, 51)))

The cause is a bug in the built-in function Count, which returns the number of elements in an array, in a string, or in a range created by the built-in function Range. However it incorrectly considers a range to be [min..max) instead of [min..max], leaving out the max element. Thus the current implementation of Count returns one element too little.
The reason lies in the following line, which should be r.end - r.start + 1 to include the range's max element.
https://github.com/eriksvedang/Sprak/blob/6e0340b5d5a27ebc78cc44f36cf4fb545bf42ddf/ProgrammingLanguageNr1/src/5. Run/SprakRunner.cs#L416
As the Range function only creates a real range (a C# Range object) when the range contains more than 50 elements (it creates an array otherwise), this bug only manifests itself with bigger ranges.

Oh, thanks for the find!
Do you feel like fixing this? @Kristine1975
I can do it otherwise, of course...

I've created pull request #3 with a fix.

Awesome.


multi-level routing?

I have multiple applications that I am trying to put together into 1 site.  Each application is a typical SPA with it's own routes to navigate to.
I would like to create a base HTML index page that contains the layout of the site.  So it would contain the directives for common elements like navbar, side menu, footer and a main view.  I want all my individual apps to use this 1 index.html page.
I am looking for a way to have routes that determine the application, followed by a 2nd tier of routes that determine the routing within the SPA.
For example:
http://mysite.com/app1/dashboard
The first route check will find app1, bootstrap it to the page and then "dashboard" is an inner route w/in the app1 SPA.
then:
http://mysite.com/app2/chartData
This will bootstrap the app2 module to the page (same index.html as above) and app2 will have it's own routes to "chartData"
I do not want all the scripts needed for app1 to load when I'm viewing app2, these are separate apps, just part of the same core site.
Is there... will there be... a way to do this?

This is something that I've been trying to achieve for a while and...
Short answer.... not right now.
Long answer: you can get close to what you want both with the new router and ui-router (I think that with the old router it will be harder), though you will need a main application that will include the rest of them (one to rule'em all :-) ).
With the new router you can make components for each application and you can easily implement a mechanism to lazy load the application parts needed. The big issue I see is the loading of the routes them self. I mean, you stated you don't want to load the code from app1 prior to resolving a route related to app1, and also I guess that you don't want the routing information of app1 contained inside the application itself.... Then, how will the router know that "/app1/dashboard" is a valid route of app1? Right now there's no router that I know that can handle this situation. It will require the router to include a childrouter for each component (which the new router has) but also a lazy loading step and a "reconfiguration of the grammar" when jumping from the parent router to the child one when needed.


How to get japi key

When I go to the website that says the installation tutorial, it gives me the following and I can't get that api key, what do I do in this case?
"Domain Misconfigured
The domain key.japi.rest is not configured to any website."

japi recently went offline. Remove the userInfo command and your code will run just fine!


Safari overlaps content

Hello,
I've been using addPage(); and setPage(1) in my document in order to create a cover page with some information before generating the desired content.
It works great in Chrome, but in Safari the content is overlapping with this cover page like it's ignoring those paramenters.
Is there something that can be done?

Please provide the code to reproduce the issue.

Sure. Thanks for the help.
Here's the piece of code covering this.
  const imgs = [...document.querySelectorAll('.image')]

      const doc = new jsPDF({
        orientation: "landscape",
        unit: 'px',
        format: 'a4',
      });

      doc.addPage();

    imgs.forEach((a, i) => {
        html2canvas(a)
        .then(canvas => {

            const img = canvas.toDataURL('image/jpeg', 1.0);
            const imgProps = doc.getImageProperties(img);

            const pageWidth = doc.internal.pageSize.getWidth();
            const pageHeight = doc.internal.pageSize.getHeight();

            const imgHeight = pageHeight;
            const imgWidth = (imgProps.width * imgHeight) / imgProps.height;

            const x = pageWidth / 2 - imgWidth / 2;
            const y = pageHeight / 2 - imgHeight / 2;

            doc.addImage(img, "JPEG", x, y, imgWidth, imgHeight);
            if (imgs.length > (i+1)) {
                doc.addPage();
            }
        })
        .then(() => {
            if ((i+1) === imgs.length) {

              doc.setPage(1);
              doc.text("Cover Page", pageWidth / 2, pageHeight / 2, "center");

              setTimeout(function(){
                doc.save(filename + '.pdf', {returnPromise:true}).then(generatedPDF());
              },3000);

            }
        })
    })

This looks a bit like an issue with the execution order of the promise callbacks. The callbacks are not guaranteed to run in any particular order. And i is probably always imgs.length - 1 in the callbacks.
I'm pretty sure this is not an issue of jsPDF. If you think otherwise, please reopen.


Qt: bug fixes and enhancement to traffic graph widget

All changes are connected to traffic graph widget.
Bug fixes:

clear traffic graph widget after clicking the clear button
set default sample height so after clearing graph has axis lines - currently it's just a black rectangle

Enhancement:

having 288 graph ranges available is probably unnecessary (for example can't imagine that some uses range 13h 25m), so I limited it to only 10:
5m, 10m, 15m, 30m, 1h, 2h, 3h, 6h, 12h, 24h
If more ranges are needed please let me know
added possibility to change graph range without losing collected traffic samples
data storage was designed to contain only necessary data to create graphs for all supported ranges
eg.
for 10m range only half of 10m samples are stored - the second half is calculated from 5m range samples,
for 1h range data is created based on:
all 5m samples,
2/3 of 15m samples,
1/2 of 30m samples,
1/2 of 1h samples
all traffic graph related data and logic were encapsulated into one class

Wow, thanks!
However 0.12.1.x branch is in release mode and it is open for critical fixes only now, so please rebase you branch on top of v0.12.2.x.

done

Errr... I'm not sure what you did exactly but it's a mess now (history wise).
Is that what git rebase -i v0.12.2.x produced for you? If so, it's quite surprising tbh... You might want to use it again but this time dropping all unrelated commits i.e. change it to be smth like this:
d 6bec60653 Don't add non-current wd's to seen map (#1417)
d b6f18282d Reject payment vote if masternode rank can't be calculated (#1422)
d d0ff35ee5 Fix ProcessVerifyBroadcast (#1423)
d 42aa1bb19 clear trafficgraph on clear button click
d d8de71f07 set default sample height
d 03dfb80d5 reduce available traffic graph ranges, add optimized graph data storage
d e6543b9c7 Don't add non-current wd's to seen map (#1417)
d 3069e0c81 bump to <IP_ADDRESS> (#1418)
d d8fd73fcd Reject payment vote if masternode rank can't be calculated (#1422)
d 7f4ff495c Fix ProcessVerifyBroadcast (#1423)
pick d27c640de clear trafficgraph on clear button click
pick 87b24a31a set default sample height
pick 10bb55778 reduce available traffic graph ranges, add optimized graph data storage

I've used git rebase v0.12.2.x before. Not sure why this mess in history has happened.
Now I did as you advised.
Thanks for your help!!

Np :) history looks good now 👍
Will test first and provide some review feedback after that.

Thanks!!
Code formatting has been corrected.
Hope it looks ok now.

The code definitely works well but looking at trafficgraphdata.cpp I find it quite hard to follow due to the complex recursion and lots of special case handling.
Don't you think there are simpler ways to implement this that wouldn't require special case code for the different ranges ?

The only simpler way is to store all samples for all ranges.
Then you can just keep it in some collection of queues, push a new one and pop the oldest above sample limit.
In a case when you store only necessary samples it's getting more complicated.
For ranges that I proposed (5m, 10m, 15m, 30m, 1h, 2h, 3h, 6h, 12h, 24h) there are 3 cases:

for the smallest range (5m) - all samples need to be stored,
for ranges that can be created by taking a sum of 2 samples from smaller range (10m, 30m, 1h, 2h, 6h, 12h, 24h) - 1/2 of samples needs to be stored, the rest is calculated based on sum of samples from smaller range
for ranges that can be created by taking a sum of 3 samples from smaller range (15m, 3h) - 2/3 of samples needs to be stored, the rest is calculated based on sum of samples from smaller range

Those 3 cases represent logic for all proposed ranges.
I used switch statement cointaining every range in order to express clearer what is being done for ech of them.
It could be implemented with switch statement using only 3 cases but I belive I would be harder to understand.
Adtionally sample set for bigger ranges is build based on smaler ranges (eg. for 30m we need to have 15m range, for 15m range we need to have 5m range ) so recursion seams to be natural here.

The ranges you defined form a sequence where range R_i is k_i*R_(i-1) where the k_i's are small integers (ie. 2 or 3).
For storing the data what if you did something like this (pseudo-code):
 // R is a vector of range buffers // K is a vector of subsampling factors // sampleCounter simply increments for each new sample addSample(sample) {   sampleFactor = 1;   for(i = 0; i < nranges; ++i) {     if(sampleCounter % sampleFactor == 0) {       R[i].addSample(sample);     }     else {       break;     }     sampleFactor *= K[i];   }   ++sampleCounter; }

I can see following problems with this approach:

defined ranges do not form sequence as you described. eg 15m is k_i*R(i-2)
i range does not contain only every K[i] sample, it contains a sum of K[i] samples from range R[i-1] or R[i-2]

Additionally, if you don't want to store unnecessary data, you have to add logic that will remove last K[i] add it to R[i] range. Those last K[i] must be samples above R[i-1] or R[i-2] size limit so you need to have some extra space to store them.

defined ranges do not form sequence as you described

Sorry, my mistake.
However each range is an integer multiple of the base range.
So we can do this, which is even simpler:
// R is a vector of range buffers
// K is a vector of subsampling factors
// sampleCounter simply increments for each new sample

K = {1, 2, 3, 6,12, 24, 36, 72,144, 288};
addSample(sample) {
  for(i = 0; i < nranges; ++i) {
    if(sampleCounter % K[i] == 0) {
      R[i].addSample(sample);
    }
    else {
      break;
    }
  }
  ++sampleCounter;
}

As for your second objection I think the easiest way to handle that is to store the cumulative byte counts instead of the instantaneous rates.  You can then compute the rate with
rate = (sampleBuffer[i] - sampleBuffer[i-1])/dt

where dt is the timestep for the selected range.
It does require a bit of thought to deal with the edge conditions but I don't think you need extra space since addSample should be storing all the data you need to compute any chosen range.

ok! that would work.
However, as I described in one of my previous answers this is a simpler approach to store all samples for all ranges.
Here you need to store nranges * DESIRED_DATA_SAMPLES.
I wanted to create a solution that you can store only a minimal amount of samples.
In my approach you need to store:
DESIRED_DATA_SAMPLES + n2ranges * DESIRED_DATA_SAMPLES/2 + n3ranges * DESIRED_DATA_SAMPLES*2/3
where:
n2ranges - number of ranges that are created based on sum of 2 samples from smaller range
n3ranges - based on 3 samples from smaller range

OK, but what is the rationale for storing fewer samples for some ranges than others ?
Why would you want to store (and display) fewer points for the 10 min range than for the 5 min range, for example ?

Because the rest we can calculate from other ranges.
for example for 10m range we just need to store half of the needed samples  - second half.
Frist half we can calculate using samples from 5m range.


Save selfie as previewed (Add)

Would you consider adding this feature?
"Save pictures with the same orientation seen in the viewer."

Flipping the image via EXIF is entirely possible just like how the orientation is set based on the device's rotation. It's entirely possible to do that on your own for the time being. The captured image is always in the same actual orientation with the metadata determining how it's shown.

Flipping the image via EXIF is entirely possible just like how the orientation is set based on the device's rotation. It's entirely possible to do that on your own for the time being. The captured image is always in the same actual orientation with the metadata determining how it's shown.

I know the details but this feature comes in handy, I like your camera app very much. I am using it on my Mi Note 10 Pro (OctaviOS - A12). In my opinion, this is the only missing feature, so I wanted to convey it to you.

A persistent option has been added to prevent the flipping of image.  The changes have been pushed to the repository and the option should be visible for the front-camera in the next release.
Thanks a lot for requesting this enhancement @bugycugy!

A persistent option has been added to prevent the flipping of image. The changes have been pushed to the repository and the option should be visible for the front-camera in the next release.
Thanks a lot for requesting this enhancement @bugycugy!

Thank you very much for adding this feature...


docs: Redirects for docs information architecture revamp

Redirects for docs site as part of the information architecture overhaul.
Should be merged together with https://github.com/eslint/eslint/pull/16665

oopsies made this PR to myself. closing


helm: set resource-policy to keep resources

Enables helm.sh/resource-policy: keep for certain resources.
Fixes: #14550

@kvaps Any reason this pull request is based on v1.9? Unless there's a good reason, we open all pull requests against master than backport if needed.

@kvaps Any reason this pull request is based on v1.9? Unless there's a good reason, we open all pull requests against master than backport if needed.

@pchaigno yeah sorry, I was just confused a little. PR rebased.

@pchaigno yeah sorry, I was just confused a little. PR rebased.

Unfortunately helm.sh/resource-policy: keep does not solves original problem, see: https://github.com/argoproj/argo-cd/issues/5206
however having this annotation is good form rule, since it will not allow to regenerate certificate each redeploy

Unfortunately helm.sh/resource-policy: keep does not solves original problem, see: https://github.com/argoproj/argo-cd/issues/5206
however having this annotation is good form rule, since it will not allow to regenerate certificate each redeploy

It seems I was wrong about this annotation, see https://github.com/helm/helm/issues/4824 and https://github.com/helm/charts/issues/5167.
Some projects are using https://github.com/jet/kube-webhook-certgen to generate certs in their charts to solve this problem (eg. nginx-ingress and prometheus-operator)
Alternatively the lookup function can be used, however lookup will not work with helm template

It seems I was wrong about this annotation, see https://github.com/helm/helm/issues/4824 and https://github.com/helm/charts/issues/5167.
Some projects are using https://github.com/jet/kube-webhook-certgen to generate certs in their charts to solve this problem (eg. nginx-ingress and prometheus-operator)
Alternatively the lookup function can be used, however lookup will not work with helm template

Hi @kvaps thanks for the PR!
Helm generating new certificates at each deploy is intended as a way to rotates the certificates. Admittedly, I lack knowledge about what "out of sync" means in the context of argo-cd and so I fail to understand the issue. Can you elaborate on that point?
You might want to try --set hubble.tls.method=cronJob which will deploy a k8s CronJob to generate and rotates the certificates independently from Helm, if that can help.

Hi @kvaps thanks for the PR!
Helm generating new certificates at each deploy is intended as a way to rotates the certificates. Admittedly, I lack knowledge about what "out of sync" means in the context of argo-cd and so I fail to understand the issue. Can you elaborate on that point?
You might want to try --set hubble.tls.method=cronJob which will deploy a k8s CronJob to generate and rotates the certificates independently from Helm, if that can help.

@kaworu, yeah argocd just running helm template to get the set of resources for the application. It gets confused when it returns the different output from the same commit, thus resources are running infinity loop to sync this state with the cluster.
--set hubble.tls.method=cronJob is working as expected, thank you, now cilium is deployed with no problems on all my environments:

@kaworu, yeah argocd just running helm template to get the set of resources for the application. It gets confused when it returns the different output from the same commit, thus resources are running infinity loop to sync this state with the cluster.
--set hubble.tls.method=cronJob is working as expected, thank you, now cilium is deployed with no problems on all my environments:


assertion error when ns-install-cli

I get the following error when running ns-install-cli
Traceback (most recent call last):   File "/opt/conda/envs/sdfstudio/bin/ns-install-cli", line 8, in <module>     sys.exit(entrypoint())   File "/mnt/localssd/sdfstudio/scripts/completions/install.py", line 284, in entrypoint     tyro.cli(main, description=__doc__)   File "/opt/conda/envs/sdfstudio/lib/python3.8/site-packages/tyro/_cli.py", line 177, in cli     output = _cli_impl(   File "/opt/conda/envs/sdfstudio/lib/python3.8/site-packages/tyro/_cli.py", line 432, in _cli_impl     out, consumed_keywords = _calling.call_from_args(   File "/opt/conda/envs/sdfstudio/lib/python3.8/site-packages/tyro/_calling.py", line 215, in call_from_args     return unwrapped_f(*positional_args, **kwargs), consumed_keywords  # type: ignore   File "/mnt/localssd/sdfstudio/scripts/completions/install.py", line 276, in main     _update_rc(completions_dir, mode, shell)   File "/mnt/localssd/sdfstudio/scripts/completions/install.py", line 177, in _update_rc     assert source_file.endswith(f"/completions/setup.{shell}") AssertionError

Hi, could you post the full trace. Don't know what's happening.


Add FrameDescriptionEntry::{initial_address, len} methods

And makes various tests and other methods use them to ensure our tests are exercising them.
r? @philipc

Coverage increased (+0.004%) to 94.116% when pulling b44d86e3d2205bd2cc47fb8d52465845e4058552 on fitzgen:more-cfi-apis into 3f0045dc1bf16c5d99edab91030b9782a60c3c7b on gimli-rs:master.


python38Packages.bleach build broken

Describe the bug
2012dd5734ef0f15a68794020283b112625b3f95 broke the build of python38Packages.bleach, see here, python37 is still fine.
This is probably an upstream issue in either bleach or python.
bleach master still has this behavior, though.
They do test on 3.8, that is however 3.8.0, not 3.8.1 as of writing this.
Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: python38Packages.bleach
# a list of nixos modules affected by the problem
module:

cc @FRidh

Upstream bugs:

https://github.com/mozilla/bleach/issues/503
https://bugs.python.org/issue27657


Filter unknown sampling kwargs in HybridRunnable

Fix #244.

Codecov Report

Merging #246 (a717ee2) into master (760e5fa) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
+ Coverage   89.51%   89.52%   +0.01%
==========================================
  Files          17       17
  Lines        1870     1872       +2
==========================================
+ Hits         1674     1676       +2
  Misses        196      196

Impacted Files
Coverage Δ

hybrid/core.py
98.61% <100.00%> (+0.01%)
:arrow_up:

hybrid/samplers.py
91.16% <0.00%> (-0.47%)
:arrow_down:

hybrid/flow.py
93.07% <0.00%> (+0.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760e5fa...a717ee2. Read the comment docs.

Hybrid runopts (runnable params) shouldn't be passed directly to samplers at all. So, better to pass only sampler-accepted ones.


more helpful Unsat report

What language and solver does this apply to?
All, CPSat
Describe the problem you are trying to solve.
Sometimes my code is buggy, and the model is unsatisfiable.  It is hard to figure out which constraint is broken.
The output looks like:

Starting presolve at 0.00s
Unsat after presolving constraint #2999 (warning, dump might be inconsistent): linear { vars: 421 vars: 675 vars: 812 vars: 1066 coeffs: 1 coeffs: 1 coeffs: 1 coeffs: 1 domain: -9223372036854775808 domain: -1 }

Usually I think I know where the problem is, but with thousands of constraints it is hard to be sure.
Describe the solution you'd like
I am pretty careful to always give the string names to constraints and the like.  Would be nice to see that.
Something like:

Starting presolve at 0.00s
Unsat after presolving constraint #2999 "Total souls assigned for demon Bob" (warning, dump might be inconsistent): linear { vars: 421 vars: 675 vars: 812 vars: 1066 coeffs: 1 coeffs: 1 coeffs: 1 coeffs: 1 domain: -9223372036854775808 domain: -1 }

Describe alternatives you've considered
Liberal print statements prior to calling solve.  Careful analysis of the model.
Additional context
Add any other context or screenshots about the feature request here.

Maybe only programatic access to what is written is needed. Sometimes it can be helpful to not just display a message but to do some action.
jmarca: do you know assumptions ?  in short, when you rewrite all constraints to be conditional via channeling constraints, you can get minimal set of infeasible constraints. boolean variables used in enforcements should be marked as an assumption. alternative model with assumptions can be helpful to catch infeasibility in input data.

I'm not sure that is relevant to what I'm asking.
When I create a variable, etc, I do:
var roomsCleaned = model.NewIntVar(minRooms, maxRooms, $"atndnt {attendant.Username}: assigned rooms");

All I want is that string at the end of the NewIntVar, etc to show up in the diagnostic output.
So when the constraint fails, the error says something that I can trace back in my code.  Constraint # 2345 is not helpful.

To state another way, I have a large solver project that is growing organically with additional requirements and conditions, etc.  If I just graft on a new feature, no big deal, it usually works or fails fast and I figure out what I've done wrong.  But as with any big project, occasionally the benefits of refactoring outweigh the pains, so I refactor.  This is when the mysterious error message drive me crazy, as I just touched lots of code and have no idea which part of the input conditions and constraints I've screwed up.
In this case I fixed it and moved on, and I don't even remember what the ultimate bug was.  I'm not arguing that it is some solver issue...it is absolutely a mistake on my part.
I'm not going to get anywhere by reformulating as channeling constraints etc., because exactly that sort of reformulating exercise is what got me into trouble in the first place!  I just want to find those mistakes faster when I'm refactoring/reformulating.

I agree we could improved model debugging.
It is progressing when we need to debug our models :-)
Le lun. 8 nov. 2021, 22:44, James Marca @.***> a écrit :

To state another way, I have a large solver project that is growing
organically with additional requirements and conditions, etc. If I just
graft on a new feature, no big deal, it usually works or fails fast and I
figure out what I've done wrong. But as with any big project, occasionally
the benefits of refactoring outweigh the pains, so I refactor. This is when
the mysterious error message drive me crazy, as I just touched lots of code
and have no idea which part of the input conditions and constraints I've
screwed up.
In this case I fixed it and moved on, and I don't even remember what the
ultimate bug was. I'm not arguing that it is some solver issue...it is
absolutely a mistake on my part.
I'm not going to get anywhere by reformulating as channeling constraints
etc., because exactly that sort of reformulating exercise is what got me
into trouble in the first place! I just want to find those mistakes faster
when I'm refactoring/reformulating.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/2886#issuecomment-963602569,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACUPL3NA3YXJ35PISEHXO3LULBAFTANCNFSM5HOPBUHQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I'm not sure that is relevant to what I'm asking.
When I create a variable, etc, I do:
var roomsCleaned = model.NewIntVar(minRooms, maxRooms, $"atndnt {attendant.Username}: assigned rooms");

All I want is that string at the end of the NewIntVar, etc to show up in the diagnostic output.
So when the constraint fails, the error says something that I can trace back in my code. Constraint # 2345 is not helpful.

You can trace it, since you can get the constraint by the index. Same is true for variables.
In case a method to programmatically get index of failed constraint and its variables will be available, it should be easy to produce string output that you want.

@gregy4 perhaps you are missing the issue tag of "Feature Request"?

Note that if the constraint is named, it should appear in the log message already with name:"xxx".
I suspect the failing constraint is one we create internally, it is why there is no name.
But yes, we are aware that the current messages are not the best :)


Adding Battlesnake Collection

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x ] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[ x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x ] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[x ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x ] My folder contains a *.png image (if applicable) and index.md
[x ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

I believe this collection should curated because it will help new battlesnake developer to find useful ressource.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Thanks for your contribution. However you are the maintainer off at least one of these projects and this violates our contribution guidelines.

Thanks for your contribution. However you are the maintainer off at least one of these projects and this violates our contribution guidelines.

Зедда

Зедда


Fix bar plot of proportions

It appears that this solution grouped by color only and each bar within each color still is reporting inaccurate proportions for the color cut combinations.  I believe this is the complete solution to solve this issue.

Thanks! I think this makes sense.


bug: picker does not select closest option when released at low velocity

Bug Report
Ionic version:

[x] 4.x
Current behavior:

When releasing the picker column while holding still it selects the next picker option.

Expected behavior:

When releasing the picker column while holding still it should select the closest picker option, similar to the default iOS behavior.

Steps to reproduce:

Best experienced on mobile.

Pick up the picker column.
Move it to the option to select.
Release the picker column while not moving the finger up or down.

Other information:

I will provide a pull request with an implementation of the expected behavior.
Ionic info:

Ionic:

   Ionic CLI : 5.4.2

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   NodeJS : v12.11.0
   npm    : 6.12.0
   OS     : macOS Catalina

Thanks for the issue. This issue has been fixed via https://github.com/ionic-team/ionic/pull/19660 and will be available in an upcoming release of Ionic Framework.


Revert etcd client version

Description
This is to fix https://github.com/apache/openwhisk/issues/5317 by reverting https://github.com/apache/openwhisk/commit/40077664ab3011e7a333b0197fa9a285502a1d81.
It seems the version of gprc-core module in the ETCD client conflicts with akka-grpc module.
I am curious how it passed all checks in the first place, but anyway it would be the easiest way to resolve it for now.
I think we need to upgrade both modules at once.
Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Scheduler
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[x] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[x] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

ok, I found there are only unit tests in the scheduler CI tests.
This will guarantee the sanity of the critical path of the scheduler.
https://github.com/apache/openwhisk/pull/5308

Codecov Report

Merging #5318 (ab25b6f) into master (9be427c) will decrease coverage by 76.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #5318       +/-   ##
==========================================
- Coverage   81.23%   4.56%   -76.68%
==========================================
  Files         239     239
  Lines       14242   14242
  Branches      604     604
==========================================
- Hits        11570     650    -10920
- Misses       2672   13592    +10920

Impacted Files
Coverage Δ

.../main/scala/org/apache/openwhisk/core/WarmUp.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...ain/scala/org/apache/openwhisk/spi/SpiLoader.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/scala/org/apache/openwhisk/utils/JsHelpers.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...scala/org/apache/openwhisk/common/Prometheus.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...scala/org/apache/openwhisk/common/time/Clock.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...scala/org/apache/openwhisk/core/FeatureFlags.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...ala/org/apache/openwhisk/common/ConfigMXBean.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...la/org/apache/openwhisk/http/BasicRasService.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/org/apache/openwhisk/common/ConfigMapValue.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/org/apache/openwhisk/core/entity/WhiskAuth.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 203 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I merged it as no activation can be invoked with the current master.


Request for example on treemap visualization

Hi Team,
I'm working on data visualization with Tree map.It will be a great help if anyone can upload a working example for tree map.

@deepabagewadi as far as I know, no one has created a Tree Map using Chart.js. I think you will have better luck finding an answer to this on stack overflow


D3: Updating Height Dynamically - Tests Not Passing

Describe your problem and - if possible - how to reproduce it
Tests are not passing with correct code. Curiously, the "The fifth div should have a height of 25 pixels" test is passing, but none of the others. DOM elements are rendering correctly with appropriate inline style.
Add a Link to the page with the problem
https://learn.freecodecamp.org/data-visualization/data-visualization-with-d3/update-the-height-of-an-element-dynamically/
Tell us about your browser and operating system

Browser Name: Chrome
Browser Version: 68
Operating System: Chrome OS

If possible, add a screenshot here

Oddly enough, no. I find it very strange that I can get the fifth test to pass, but none of the others, no matter what I do.

yea, im not sure - did you try resetting the code and doing it again? is there any errors in the console?

Yes to reset, no to errors. If it's a browser problem, that's an issue for people using Chromebooks like myself.

try to employ .attr() instead of style()

.style('height', d => `${d}px`)

does not work on Chromium - Version 75.0.3770.100 (Official Build) Arch Linux (64-bit)
works on Firefox 67.0.3

my browser: Versione 77.0.3865.120 (Build ufficiale) (a 32 bit) on Windows 10 Home v1803
no test passes with callback d => d + "px"

Pretty sure the problem is similiar to the problem on https://github.com/freeCodeCamp/freeCodeCamp/issues/18045

Yep looks like yet another zoom bug with Chrome. We can check the inline styles set instead for the test. I will make a PR.


Fix the build by remove the push to docker

I rule and have completed some work on Case Manager that's ready for review!
This pull request makes the following changes:

remove the deploy step that pushed docker

It relates to the following issue #s:

Fixes the build

For reviewer:

Adjust the title to explain what it does for the notification email to the listserv.
Tag this PR:

feature if it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.
dependencies if it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.

If it contains neither, no need to tag this PR.

Closing as dup - next time I'll check PRs first!


Enable support for windows-arm64

It's now possible to natively compile or cross-compile a flutter app for windows-arm64. It's possible to cross-compile windows-x64 from windows-arm64 as well.
Uses arm64 artifacts now available for Dart/Flutter. Platform detection is based on Abi class, provided by Dart. Depending if Dart is an arm64 or x64 binary, the Abi is set accordingly. Initial bootstrap of dart artifacts (update_dart_sdk.ps1) is checking PROCESSOR_ARCHITECTURE environment variable, which is the way to detect host architecture on Windows.

Added option --target-platform {windows-x64, windows-arm64} for flutter build windows command.
Without this option, it produces an x64 app on windows-x64, and arm64 app on windows-arm64.
This was successfully tested (on windows-x64 and windows-arm64) with: $ flutter create app
$ cd app
$ flutter build windows
$ flutter build windows --target-platform windows-x64 $ flutter build windows --target-platform windows-arm64
Flutter tests are running correctly on both windows-x64 and windows-arm64 platforms.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I signed the CLA.
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making, or this PR is test-exempt.
[X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@loic-sharma This is the first version of PR to support windows-arm64.
There are probably some missing tests, and some style issues. If possible, I would appreciate if we could focus on current content, and fill testing and tweak style once we all agree on this.
To complete PR description:

native and cross-compilation (x64 -> arm64 and arm64 -> x64) works!
current tests work on both platforms
native assets are implemented

Yours and flutter team comments are welcome :)

@pbo-linaro This looks good! My only concern so far is that only the "master" channel should allow targeting Windows Arm64. The "beta" and "stable" channels should...

Error if the --target-platform option is provided
Not download Windows Arm64 artifacts
Warn when compiling on Windows Arm64 that Arm64 is not a supported target platform and x64 will be used instead.

Excellent work! :)

@pbo-linaro This looks good! My only concern so far is that only the "master" channel should allow targeting Windows Arm64. The "beta" and "stable" channels should...

Dart-sdk is only built for master channel, which is what prevents us from doing all this for beta and stable channels.
Considering this, it means the update_dart_sdk.ps1 (or any .bat file) should not try to download any arm64 version at all. I'm not sure if checking the channel in this script is the right thing to do. Any opinion or advice?

@pbo-linaro This looks good! My only concern so far is that only the "master" channel should allow targeting Windows Arm64. The "beta" and "stable" channels should...

Dart-sdk is only built for master channel, which is what prevents us from doing all this for beta and stable channels. Considering this, it means the update_dart_sdk.ps1 (or any .bat file) should not try to download any arm64 version at all. I'm not sure if checking the channel in this script is the right thing to do. Any opinion or advice?

I definitely would discourage checking the branch name in a powershell script. I think we would need to discuss this further, perhaps in a doc, before merging this change.

I definitely would discourage checking the branch name in a powershell script. I think we would need to discuss this further, perhaps in a doc, before merging this change.

I agree checking this in script is not a good way. I added a new section in windows-arm64 design document, "Enable windows-arm64 support for master branch only".
After looking closely at this, I plan to not check current branch from powershell script, but simply fallback to windows-x64 engine if windows-arm64 one is not available. From there, we can check the channel in flutter code as normally expected.

I definitely would discourage checking the branch name in a powershell script. I think we would need to discuss this further, perhaps in a doc, before merging this change.

I agree checking this in script is not a good way. I added a new section in windows-arm64 design document, "Enable windows-arm64 support for master branch only".
After looking closely at this, I plan to not check current branch from powershell script, but simply fallback to windows-x64 engine if windows-arm64 one is not available. From there, we can check the channel in flutter code as normally expected.

This sounds reasonable :+1:

Thanks for the feedback @christopherfujino.

Updated comments and rebased.

@pbo-linaro You'll also need to update the Devicelab tests to pass post-submit verification. I would run the Devicelab tests locally on your Windows Arm64 machine to verify this.
Here are instructions on how to run Devicelab tests locally: https://github.com/flutter/flutter/blob/master/dev/devicelab/README.md#running-tests-locally
You can find Devicelab tests using the .ci.yaml file, all the builders whose name are prefixed by Windows_arm64 .
You'll want to use the task_name property for test_runner.dart's --task option. For example, for Windows_arm64 run_debug_test_windows:
cd dev/devicelab
rm C:\Code\f\flutter\bin\cache\flutter_tools.snapshot # Forces Flutter tool rebuild
../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t run_debug_test_windows

It looks like you'll need to update these files:
https://github.com/flutter/flutter/blob/45a4c7a4327046bbaa7d3800fae6af572b0c69da/dev/devicelab/lib/tasks/run_tests.dart#L180-L182
https://github.com/flutter/flutter/blob/45a4c7a4327046bbaa7d3800fae6af572b0c69da/dev/devicelab/lib/tasks/run_tests.dart#L208
https://github.com/flutter/flutter/blob/45a4c7a4327046bbaa7d3800fae6af572b0c69da/dev/devicelab/lib/tasks/perf_tests.dart#L956-L964
https://github.com/flutter/flutter/blob/45a4c7a4327046bbaa7d3800fae6af572b0c69da/dev/devicelab/lib/tasks/perf_tests.dart#L1756-L1763

Adressed open issues, and rebased on top of master.

After discussion, we decided that this PR would only target native compilation (x64 -> x64, arm64 -> arm64).
Thus, option --target-platform was removed, description was updated, and flutter artifacts are only downloaded for current arch.
Since we check in update_dart_sdk.ps1 script is native arm64 artifacts, it's not needed to check current channel from flutter code. Indeed, by design, we will be able to run a native windows-arm64 dart only on master channel. On other channels, windows-x64 will be automatically selected instead.

@loic-sharma Does the current implementation (out of testing) now looks good to you?

Implementation looks good to me on the Windows side. @christopherfujino, or someone with tool expertise, could you take a review the implementation? Pierrick will add tests once we know no major changes are necessary to this pull request.

Thanks for the review @christopherfujino. I'll address your issues, and update a new version fixing all this.
From there, we should be able to discuss about testing :+1:.

Fixed issues/nits raised by @christopherfujino, and rebased on top of master.

Fixed tests and analyze issue.

Fixed device lab tests on windows-arm64, taken from .ci.yaml file:

complex_layout_win_desktop__start_up
flutter_gallery_win_desktop__compile
flutter_gallery_win_desktop__start_up
flutter_tool_startup
flutter_view_win_desktop__start_up
hello_world_win_desktop__compile
hot_mode_dev_cycle_win_target__benchmark
platform_channel_sample_test_windows
platform_view_win_desktop__start_up
plugin_test_windows
run_debug_test_windows
run_release_test_windows
windows_home_scroll_perf__timeline_summary
windows_startup_test

This PR now builds, and pass tests on both windows-x64 and windows-arm64 platforms.
@loic-sharma @christopherfujino
Are there more things you would like to see changed/added?

Fixed regexp run_tests.dart and rebased on top of master.

The test failure we observe in CI does not seem related to any of this code. Is this a sporadic issue on CI infra?

The test failure we observe in CI does not seem related to any of this code. Is this a sporadic issue on CI infra?

I don't see any current failures, I'm guessing you re-ran the test? In the future, if you provide a link before, investigation can still happen in parallel with re-running.

I didn't re-ran it, but maybe someone else did :).

I secretly re-ran the test to see if I needed to investigate further. Looks like it passed, I'll queue this for merge!

@loic-sharma this PR is breaking google testing b/321094453; will revert in the mean time a fix is added

@Jasguerrero Is that possible to get a public link or details on the failure?

@pbo-linaro I'll try to handle this. I'll tag you on this thread if I need your help :)

Thanks very much!

@pbo-linaro Could you open a new pull request to re-land these changes? I have a fix pending on the Google side that I'll attach to this new pull request. That should allow us to reland your changes.

New PR is available at https://github.com/flutter/flutter/pull/141930.


Added buttons that can delete assets

The UI now includes buttons when accessing all the assets. These
buttons delete the assets they are associated with when they are
clicked.
Resolves #157
@ckadner

Thank you @Zachary-Fernandes -- could you add a screenshot as well?

Sure thing, I can demonstrate it by deleting Project CodeNet Language Classifier.
Here it is before deleting:

Here it is after deleting:

@Zachary-Fernandes does this screenshot reflect your latest changes?

Yes. It originally was red with a minus sign because I could not figure out how to spawn lowercase text, but after making a new style in Models.css, I figured out how to do this.


GUI success dialog formatting errors

https://i.imgur.com/7jyVwIP.png
Success dialog box show too many decimal places when printing space saved.

Should be fixed by commit 1e4d6e540c9d151b43f054cbd3fe520d594a5a5f


[1495] Added URN column into provider table

Context

This trello ticket
Added URN column to provider table

Changes proposed in this pull request

Added URN column to provider table

Guidance to review
Checklist

[x] Make sure all information from the Trello card is in here
[x] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[x] Tested by running locally

 [S] Add URN column to the provider table


Feedback from processing algorithms may be mistaken for plugin issue

Here's what I did

I issued an invalid request from the Directions from 1 Point Layer processing algorithm:
My input layer had duplicate points, which traveling salesman optimization doesn't allow, but I turned on traveling salesman.

I issued a request from the same algorithm to the public API, but without configuring a key first.

Here's what I got
As expected, the log contained information about the issue in both cases:

In both cases, this output seemed as if there was an issue with the plugin.
In both cases, the issue was not with the plugin, but with my input - one time it was faulty, one time I had no key configured.

Here's what I think could be improved
How can we give feedback from the processing plugins in a way that tells the user that something is wrong that they can fix themselves, rather than it being an issue with the plugin?

QgsProcessingInfo.pushFormattedMessage could be benefitial here. It prints formatted HTML.  We could keep the ordinary "developer" log message for people with those skills, but also provide Hints with links to further educational resources.


prove: Remove unused functions AddProof and hashSiblings

Another small remove-only cleanup PR. AddProof hasn't been used since commit a1c9bafa35e3695fee5edf4219229ed5b25e0d5d ("prove: Refactor updateProofRemove"), hashSiblings hasn't been used since commit 9aa42b5ecd2bf799e769233c1ea0c18f45962c02 ("prove: Remove unused RemoveTargets"). The function mergeSortedSlicesFunc was only used in AddProof and hence can also be removed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.8%) to 82.838%

Files with Coverage Reduction
New Missed Lines
%

prove.go
1
89.86%

Totals

Change from base Build<PHONE_NUMBER>:
0.8%

Covered Lines:
2090

Relevant Lines:
2523

💛  - Coveralls

NACK on removing AddProof as it's used in utreexod. https://github.com/utreexo/utreexod/blob/d50d80919b03393ef28bf5417fc961817f9614e9/wallet/watchonly.go#L1230
In Go, exported functions are capitalized so we generally don't wanna remove them.
ACK for removing hashSiblings. Could you refactor this to keep AddProof?

NACK on removing AddProof as it's used in utreexod. https://github.com/utreexo/utreexod/blob/d50d80919b03393ef28bf5417fc961817f9614e9/wallet/watchonly.go#L1230
In Go, exported functions are capitalized so we generally don't wanna remove them.
ACK for removing hashSiblings. Could you refactor this to keep AddProof?

NACK on removing AddProof as it's used in utreexod. https://github.com/utreexo/utreexod/blob/d50d80919b03393ef28bf5417fc961817f9614e9/wallet/watchonly.go#L1230
In Go, exported functions are capitalized so we generally don't wanna remove them.
ACK for removing hashSiblings. Could you refactor this to keep AddProof?

Thanks, done. Oops yes, I'm still not used to the fact that capitalization in function names have a semantic effect in golang :sweat_smile:

ACK e95382de35bc1ee6c7b4872cdc04e2923b587872


Add support for terminal colors for selenized colorschemes

As the selenized documentation notes, setting the proper terminal
palette is the preferred method of using selenized in terminal. This
patch enables that mode using airline's built-in flatten method, while
keeps the true color definitions for gui vim.

Please apply the changes to all the selenized themes, then.

Sorry, totally forgot about them :-)
maybe a consistent naming would also be beneficial, so that the following code works nicely:
augroup theme
  autocmd!
  autocmd ColorScheme * let g:lightline = { 'colorscheme': g:colors_name . '_' . &g:background }
                        \| call lightline#enable()
augroup END

This snippet, when colorscheme is selenized_bw, background is dark, then it sets lightline's colorscheme to selenized_bw_dark automatically, keeping fully consistent with the set scheme.

Thanks for your contribution. As for the names, I think selenized_black is much easier to understand what it is, and automatic theme switching is not at high priority in lightline.vim.