Sample code should have low cyclomatic complexity

Expected Behaviour
Sample code should follow all best practices, including low cyclomatic complexity and unit test support
Actual Behaviour
See IDE's reaction to the sample hello-world.js file:

Suggested solution
If we are trying to avoid ES6 classes (not sure why, because they're basically standard) then we should use a module pattern and flatten IFFE's in client libraries.  The reason is two-fold:

It helps cut down cyclomatic complexity.
Module pattern lends itself to unit testing (QUnit, Mocha, etc) whereas you cannot unit test anonymous functions such as IFFE pattern.

(ES6 = ES2015 -- but the point is here you can cut that cyclomatic complexity from 8 down to 3 for a constructor and 5 for an init function, either using ES2015 class or the older Prototype pattern.  Also should expose HelloWorld externally either by declaring the HelloWorld class in the outer scope or by returning it at the bottom of the IFFE such as:
    return {
        HelloWorld : HelloWorld,
        onDocumentReady : onDocumentReady
    };

and also at the top:
var HelloWorldComponent = (function() {
...

That way in a unit test we can access the HelloWorldComponent.HelloWorld and assert behaviors in a test and so on.

Hi @badvision, thanks for the feedback! Your contribution to improving that be very welcome, feel free to go ahead with a PR if you have the time to do so.

Hi @badvision, I'm closing this issue for now, but please reopen/clone this issue in case you're picking it up with a PR.


boards: up_squared_adsp: Add logging frontend

Fix pylint issue
Signed-off-by: Tedd Ho-Jeong An<EMAIL_ADDRESS>

@jhedberg  Amend this PR to https://github.com/thesofproject/zephyr/commit/25ffbb74e3ef2c9c1954757dac9ebe73cf30930b


Write ELLPACK pages to disk

Whew, that took a while. The compressed ELLPACK buffers are written to disk now. I haven't changed the gpu_hist updater to handle multiple pages yet. Will work on that next.
Part of #4357.
@RAMitchell @trivialfis @sriramch

Thank you for your contribution.
Could you provide some context on what kind of issue are you trying to solve? I am a bit lost (granted I am not very familiar with GPU specifics and pull requests seems to address this side of xgboost)

As the title indicates, this is a work in progress, not quite ready for review yet. :) Probably still a couple commits away from being fully functional. In any case, it's part of the effort to support external memory on GPUs. See #4357.

Codecov Report

Merging #4879 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4879   +/-   ##
======================================
  Coverage    71.4%   71.4%
======================================
  Files          11      11
  Lines        2305    2305
======================================
  Hits         1646    1646
  Misses        659     659

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab1df5...b34f3c2. Read the comment docs.

@rongou It looks like one of the Docker servers is temporarily rejecting the traffic from our CI server. Would you wait a little bit and try later?
Alternatively, are there things that you'd like to test that can be only run in the CI server? I'd like to improve the doc so that developers can run most tests locally.

@rongou Aside: I'm upgrading GPU workers to G4 this week.

@hcho3 The main thing is I don't have access to a windows dev machine. The windows compiler seems quite old and doesn't like some of the c++11 features. Anyway, I think I'm getting very close. I'll close this PR and open a new one when it's ready.

@rongou Ah got it. Yes, Windows is kind of special and harder to manage as part of DevOps. It would be really nice if NVIDIA docker supported Windows, but for now I manually manage Windows AMIs and install software packages by hand.

@rongou As for C++11 support in Visual Studio, we are using Visual Studio 2017, so C++11 should be fully supported (according to this link)

@rongou Thanks for your patience. I fixed issues in the CI in #4921 and now re-started the tests.

@trivialfis I added code comments. A few implementation notes:

In external memory mode, we first loop through all the CSR pages to build the quantile sketch and create an EllpackInfo to hold that information. Then we loop through the CSR pages again, this time compressing each CSR page into ELLPACK. The resulting compressed buffer is copied back to host and appended together. When the size reaches a threshold, the page is written to disk.
The EllpackInfo is actually kept in memory. When reading back the ellpack pages from disk, only the compressed buffers are read in and copied to GPU.
A few key methods are probably EllpackPageImpl::Push, EllpackPageImpl::InitDevice, EllpackPageSourceImpl constructor, and EllpackPageSourceImpl::WriteEllpackPages.

Hope this helps. Thanks!

Will review soon.  Thanks for the brief introduction.

@RAMitchell Do you need to review?

Merging.  @RAMitchell If you have some ideas on how to refactor please do share.

@rongou Looking forward to your next PR. ;-)


Reason for change: new hal api "wifi_startNeighborScan" implementation

Test Procedure:  use wifihal command options
eg : wifihal wifi_startNeighborScan 6 0 10 2 2412 2437

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.rnarayanan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

https://jenkins.code.rdkcentral.com/job/github-triggered/4307/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/22090/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/4308/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/22093/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/4464/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/22550/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/4549/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/22759/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/4703/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/23209/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/4704/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/23210/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/4705/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/23214/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/4709/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/23220/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/4718/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/23235/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/4922/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/23601/ started.

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/205/ started

Closed due to inactivity, please restore if still needed.


Bonus pictures should be found and modified according to the grid convention

There should not be any background in the picture, the format must bu .png and the size should be modified as 64*64 px.

We need to hurry on that issue since it is important even for debugging!!


[Migrated] Still packing pycache

Originally from: https://github.com/Miserlou/Zappa/issues/1433 by Northshoot
I am using lates zappa and set up environment as described in documentation.
When examining zip file,  pychache are packed in there.
according to https://github.com/Miserlou/Zappa/blob/cf8d09f7f286048e66c1f4da505876e2ea19c903/zappa/core.py
it should not be happening.

old migrated issue, assuming resolved.
closing.


unable to locate the "Style Editor" tab

hello,
I was getting the same error as #20,
I referred to the article and updated the gradio version to his 3.23.0 but still the same error.
Is it a problem with another module?

styles.csv

Installer now checks for gradio version

I ran an update, but I'm still at version 3.23.0 of gradio.
Attach the execution result.
thank you.
Execution result.txt

The execution results shows you at 3.31.0

In SD UI, there is no change.
Attached is the SD execution result.
thank you.

SD Execution result.txt

The gradio update was successful.
However, the gradio version displayed in the SD UI is still old.
Is this because the gradio update seems to have succeeded at first glance but actually failed? Or did the update succeed but the version displayed in the UI is still old for some other reason?
I've done some research on my own, but haven't found a solution yet.
thank you.

solved.
I solved it by deleting all the SD and doing a clean install.
thank you.


[PROD-37531] Exposing runtime credential provider without changing user namespace

Changes
Per discussion here, we need to expose the init_runtime_native_auth without modifying the user namespace. Both verified working with latest universe and not making the Python SDK explode in previous DBR.
Tests

[ ] make test run locally
[x] make fmt applied
[x] relevant integration tests applied

Codecov Report
Patch coverage: 87.50% and project coverage change: -0.01 :warning:

Comparison is base (136d7e1) 53.18% compared to head (e2259e7) 53.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
- Coverage   53.18%   53.18%   -0.01%
==========================================
  Files          29       29
  Lines       17900    17901       +1
==========================================
- Hits         9521     9520       -1
- Misses       8379     8381       +2

Impacted Files
Coverage Δ

databricks/sdk/runtime/__init__.py
64.00% <83.33%> (-1.22%)
:arrow_down:

databricks/sdk/core.py
66.51% <100.00%> (-0.20%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


module does not work on package.json

Expected Result
The module generator should create a module in the source root of a project configured in package.json
Actual Result

InvalidInputOptions [Error]: Schematic input does not validate against the Schema: {"name":"sound","directory":"sound","kind":"values","skipTests":false,"sourceRoot":"."}

Node : 18.7.0
OS   : win32 x64
npm  : 8.16.0
nx : 15.6.3
@nrwl/angular : Not Found
@nrwl/cypress : Not Found
@nrwl/detox : Not Found
@nrwl/devkit : 15.6.3
@nrwl/esbuild : Not Found
@nrwl/eslint-plugin-nx : Not Found
@nrwl/expo : Not Found
@nrwl/express : Not Found
@nrwl/jest : Not Found
@nrwl/js : Not Found
@nrwl/linter : 15.6.3
@nrwl/nest : Not Found
@nrwl/next : Not Found
@nrwl/node : Not Found
@nrwl/nx-cloud : Not Found
@nrwl/nx-plugin : Not Found
@nrwl/react : Not Found
@nrwl/react-native : Not Found
@nrwl/rollup : Not Found
@nrwl/schematics : Not Found
@nrwl/storybook : Not Found
@nrwl/web : Not Found
@nrwl/webpack : Not Found
@nrwl/workspace : 15.6.3
@nrwl/vite : Not Found
typescript : 4.9.5
Local workspace plugins:
Community plugins:
@gb-nx/svelte: 3.4.0
Logs

I tried adding a configuration to package.json
  ...
 "nx": {
    "root": ".",
    "sourceRoot": "src",
    "targets": {
      "build": {
        "outputs": [
          "{projectRoot}/dist"
        ]
      }
    }
  }

version 2.5.0 no longer throws the error but it uses an empty string sourceRoot because it is still not possible to configure the sourceRoot in package.json.  Use your source root as part of the directory argument. Leaving this open until maybe the nx issue referenced above is addressed.

please use the --directory option if your project is configured with package.json.  Nx does not want to provide the sourceRoot as part of the package.json configuration.


toggle between chat conversations

Describe the solution you'd like
I would like to be able to view all my chat conversations and toggle between them in the UI.
Describe alternatives you've considered
I currently use ChatALL for this but it doesn't have support for all the latest models.

LLM Playground is a playground, not a chat app.


Fix on action after delete, fix on auto close on hamburger

…urger window after each browse options

Bug fix - Browse Page was not displaying after a node deletion
Browse page will be displayed after the deletion of any node(term, office.. )
Bug fix - Hamburger side bar not auto closing for submenu options
Browse submenu options click would automatically close the side bar


Bug: Blank B sword in OOT in entrance rando settings

This apparently happens somewhat very rarely where if you swap games a lot during entrance rando (due to the shuffled entrances) you have a chance of losing your B sword? It can be any sword on your B button in OOT so Kokiri Sword, Master Sword, or Giant's Knife/Biggoron Sword. Just putting this here right now as it is an issue worth investigating at some point (may be necessary to make swordless adult Link a thing to fix this????? I don't know????)

Likely fixed by the recent changes to swordless & age equips, reopen if the issue appears again.


Add flowcharts to aid explanations of processes

E.g. Object Priority and Conflicts, currently being reworked by #331

I think that it's a better idea to generate those flowcharts from more usable data, rather than drawing them by hand (either using an editor program, or by hand like a madman).
A quick search yields diagrams, powered by flowchart.js, which looks serviceable enough. [NB: I also found mermaid and mdbook-mermaid, but I rejected them because they run client-side.]
Now, I'm wary of introducing too many build dependencies into Pan Docs, since we already have Rust (mdBook + "plug-ins") and Python (MBC graph generation), and this would add Node/JS to the list.

Is this acceptable?
If not:

Do we hand-roll our own generator in one of these two languages? (Pro: a custom generator may play better with #330.)
Do we replace one of our current languages with JS? (Given that getting rid of Rust would require switching to another infrastructure again, the Python script would likely have to be ported.)


Update consoles for new metric names.

Thanks, I'd missed that one. I'll wait for that to be vendored in, and then update this.

I've updated this with the new new names.


Fix Typo in Comments

Fixed a typo in the comments.
Removed the mention of "on line 44" because the line number reference became incorrect after code changes.

Nice!!  Could you please put your name in the CONTRIBUTORS file for me and keep the alphabetical ordering?

Thank you! I've added my name to the CONTRIBUTORS file and ensured it is in alphabetical order.


api: Upon failure abort the multipart upload.

Since we do not have resuming capabilities we
should not leave stale parts behind upon any
error during putObject(). This PR pro-actively
aborts the multipart upload created during
the putObject() for large files.

LGTM though I think this PR is not so much useful in practice. I think most of the stale uploads are due to a premature exit during multipart upload.

LGTM though I think this PR is not so much useful in practice. I think most of the stale uploads are due to a premature exit during multipart upload.

This is similar in behavior to how aws-sdk upload manager does. Lets say if one of the parts failed to upload we will never be able to clear it unless user explicitly does it on his own, most users are not aware. We should disallow that to happen and just abort the entire request similarly how aws-sdk does this.

This is similar in behavior to how aws-sdk upload manager does. Lets say if one of the parts failed to upload we will never be able to clear it unless user explicitly does it on his own, most users are not aware. We should disallow that to happen and just abort the entire request similarly how aws-sdk does this.

I know, but in practice if a part fails to upload due to a down server or internet connection (I don't see other possible errors here), I think that most likely the next call which aborts upload would fail (but I know not always).
I will approve this PR.
Can you rebase this @harshavardhana  ?

I know, but in practice if a part fails to upload due to a down server or internet connection (I don't see other possible errors here), I think that most likely the next call which aborts upload would fail (but I know not always).

Not necessarily with AWS a part might fail just because of some slow network whereas an abort might complete. it can also happen that input stream is somewhat corrupted as well due to a local filesystem error.  So there are valid cases.. not just network alone.

Any reviews ?

@donatello any reviews?


Splitting the response types in the generated client

According to discussion #1411

coverage: 100.0%. remained the same
when pulling 80dd01350b427fd909c42505d02c268949c1f745 on idea-1411-separate-response-types
into 2bdcd4f8af7e0d800a18d447216000496202e404 on prepare-v16.


Failed to run examples

Error is:
Uncaught TypeError: Cannot read property 'tcp' of undefinedmodbus.min.js:1 ModbusClientmain.js:17 (anonymous function)main.js:103 (anonymous function)
I'm on Windows/cygwin, with a fresh install of bower and chrome-modbus, running in Chrome Version 39.0.2171.95 m

Can you post some code pieces?

Sure thing. It is the "example_02" that I'm trying to run via a local WAMP
install.
<!doctype html>

jsModbus Chrome App Example 01

Host

Port

Register Offset

Connect

Write Single Register
Read Input Register

My Chrome javascript console is saying that line #1 of modbus.min.js
Am I using the wrong version of jquery? I'm not using the jquery included
in the examples, because Chrome was complaining about a missing ".map" file.
-J

<EMAIL_ADDRESS>+1<PHONE_NUMBER>
On Thu, Aug 27, 2015 at 1:27 PM, Cloud Automation<EMAIL_ADDRESS>wrote:

Can you post some code pieces?
—
Reply to this email directly or view it on GitHub
https://github.com/Cloud-Automation/chrome-modbus/issues/1#issuecomment-135529971
.

You need to run it as a chrome app or chrome extension. Otherwise there is no global chrome interface. That's why it is undefined.

sheepish
sorry, I guessed I missed that critical piece of info....
Are you aware of any cross-browser equivalent?

<EMAIL_ADDRESS>+1<PHONE_NUMBER>
On Thu, Aug 27, 2015 at 2:16 PM, Cloud Automation<EMAIL_ADDRESS>wrote:

You need to run it as a chrome app or chrome extension. Otherwise there is
no global chrome interface. That's why it is undefined.
—
Reply to this email directly or view it on GitHub
https://github.com/Cloud-Automation/chrome-modbus/issues/1#issuecomment-135540145
.

You mean like for a Firefox app? Nope, but feel free to fork :-)


fix: retrigger cdn panic

Signed-off-by: Gaius<EMAIL_ADDRESS>
Description

Fix retrigger cdn panic.

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist:

[x] Code compiles correctly.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #1034 (a6b5543) into main (759b1c6) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1034   +/-   ##
=======================================
  Coverage   45.95%   45.95%
=======================================
  Files         128      128
  Lines        9142     9145    +3
=======================================
+ Hits         4201     4203    +2
- Misses       4468     4469    +1
  Partials      473      473

Flag
Coverage Δ

Object-compatibility-e2etests
?

e2etests
?

unittests
45.95% <0.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

scheduler/service/callback.go
70.51% <0.00%> (-0.46%)
:arrow_down:

client/daemon/peer/peertask_conductor.go
56.90% <0.00%> (-0.39%)
:arrow_down:

cdn/supervisor/progress/progress.go
97.01% <0.00%> (+5.97%)
:arrow_up:


problem in downloading Resnet-50-model.caffemodel

I cannot download Resnet-50-model.caffemodel from your link.plz guide me....

Hi, Kaiming, microsoft onedrive seems to be blocked in mainland, China, consider give other options too? Thanks for your efforts. : )

same problem for me. : )

I have found a resnet-50-model.caffemodel in BAIDU YUN
here is the link : 链接: https://pan.baidu.com/s/1CPCkEiN-Uqh7dKGh7dJKgw 密码: 2gqp
Hope help for someone can not download from onedrive

@maozezhong The caffe model stored in Baidu Wangpan is same as the model in this repository.

I found something here. I hope it helps
https://gitlab.com/vgg/vgg_classifier/tree/master/caffe/imagenet_resnet-50-128


chore: Bring acvm_js package into the workspace

Description
Problem*
Dev workflow is less efficient with acvm_js being in separate repository as per #458
Resolves #458
Summary*
Pulls in noir-lang/acvm-simulator into acvm_js directory.
Additional Context

PR Checklist*

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray can you force this through?


Update esp_echo_http.yaml with proper region tags

[ b/347825429  ]
Updating illegal Region Tag: secret-2 with proper region which according to docs needs to start with:
region_tag_prefix: "endpoints"
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist

[x] I have followed Contributing Guidelines from CONTRIBUTING.MD
[ ] Tests pass:   go test -v ./.. (see Testing)
[ ] Code formatted:   gofmt (see Formatting)
[ ] Vetting pass:   go vet (see Formatting)
[ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
[ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
[ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
[ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
[ ] Please merge this PR for me once it is approved

PTAL now bro


Failed to export buffer to dma_buf: No such file or directory (2)

I have compiled ungoogled chromium without use_system_libopenjpeg2=true
Chromium runs fine but should I be worried about these?
[9707:9707:0427/063656.853336:ERROR:browser_switcher_service.cc(238)] XXX Init()
[9731:9731:0427/063657.019044:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.039402:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.040112:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.041255:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.041310:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.041361:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.041397:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.041426:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.041453:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.041482:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.042815:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.042879:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.042899:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.042912:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.042925:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.042952:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.042968:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.042981:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.042992:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.043018:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.043031:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.043043:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.043055:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.043083:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.043096:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.043107:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.043132:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.043146:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.043157:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.043169:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.043193:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.043216:ERROR:gbm_wrapper.cc(271)] Failed to export buffer to dma_buf: No such file or directory (2)
[9731:9731:0427/063657.047162:ERROR:sandbox_linux.cc(374)] InitializeSandbox() called with multiple threads in process gpu-process.

It seems to be GPU/UI related. The file used to be under ozone but I am not sure it is also the case in v81. @jstkdng Do you have any idea?

True, it seems GPU related. Here the log when I disabled hardware acc:
MESA-LOADER: failed to retrieve device information
MESA-LOADER: failed to open i915 (search paths /usr/lib/dri)
failed to load driver: i915
MESA-LOADER: failed to open kms_swrast (search paths /usr/lib/dri)
failed to load driver: kms_swrast
MESA-LOADER: failed to open swrast (search paths /usr/lib/dri)
failed to load swrast driver
[6269:6269:0427/071304.119153:ERROR:browser_switcher_service.cc(238)] XXX Init()

I have Intel Graphics HD and Mesa is at latest version.
OpenGL vendor string: Intel
OpenGL renderer string: Mesa Intel(R) UHD Graphics 620 (WHL GT2)
OpenGL core profile version string: 4.6 (Core Profile) Mesa 20.0.5

I have a deticated AMD GPU alongside my Integrated Intel GPU and It seems Failed to export buffer to dma_buf has been gone when I run chromium on my second GPU.
$ DRI_PRIME=1 LIBVA_DRIBER_NAME=radeonsi chromium
[10542:10542:0427/073252.506894:ERROR:browser_switcher_service.cc(238)] XXX Init()
[10566:10566:0427/073253.454109:ERROR:sandbox_linux.cc(374)] InitializeSandbox() called with multiple threads in process gpu-process.

So this is most likely related to my Intel GPU. I have intel-media-driver installed with LIBVA_DRIVER_NAME=iHD set. I haven't compiled ungoogled chromium for more than a month so Idk which version caused this.

That sounds like an AMD version of #48, not sure whether they are related but in that case setting LIBVA_DRIBER_NAME fixed the problem for me (I didn't have an Intel GPU on that machine though). I suspect video accelaration has some bugs we don't know.
For now probably try just disabling hardware accelaration as a workaround?

@wchen342  this is the log when I disable it though. Chromium still works somehow.
MESA-LOADER: failed to retrieve device information
MESA-LOADER: failed to open i915 (search paths /usr/lib/dri)
failed to load driver: i915
MESA-LOADER: failed to open kms_swrast (search paths /usr/lib/dri)
failed to load driver: kms_swrast
MESA-LOADER: failed to open swrast (search paths /usr/lib/dri)
failed to load swrast driver
[6269:6269:0427/071304.119153:ERROR:browser_switcher_service.cc(238)] XXX Init()

I think that I will just use chromium without Hardware Acceleration since its safer.

If you haven't compiled ungoogled chromium for a month and the error just appeared, then it isn't a problem with ungoogled chromium.
Mesa had an upgrade when 81.0.4044.92-1 came out that broke vaapi for many users. After that it became kinda stable and works for some people.
That warning can be ignored as chromium uses gbm when it is used under wayland.

@jstkdng I haven't compiled or used ungoogled chromium for a month before compiling it yesterday.
Well, now my CPU usage is back at 70% while watching a video since vaapi is broken ¯_(ツ)_/¯

Try adding this patches to your build @Rowisi
vaapi-build-fix.patch
From 5b2ff215473e0526b5b24aeff4ad90d369b21c75 Mon Sep 17 00:00:00 2001
From: Julien Isorce<EMAIL_ADDRESS>Date: Wed, 05 Feb 2020 17:59:59 +0000
Subject: [PATCH] Fix vaapi with GLX

The signature of ui's gl::GLImageGLX has changed a little bit
since "mplement GpuMemoryBuffers for EGL and GLX":
  https://chromium-review.googlesource.com/c/chromium/src/+/1984712

Bug: 1031269
Test: build with use_vaapi=true and run with --use-gl=desktop, see
Change-Id: I80b07294b9abdfa8233aaf79f7d9ec4c58117090
https: //chromium.googlesource.com/chromium/src.git/+/refs/heads/master/docs/gpu/vaapi.md#vaapi-on-linux
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036494
Reviewed-by: Thomas Anderson<EMAIL_ADDRESS>Reviewed-by: Miguel Casas<EMAIL_ADDRESS>Commit-Queue: Julien Isorce<EMAIL_ADDRESS>Cr-Commit-Position: refs/heads/master@{#738595}
---

diff --git a/media/gpu/vaapi/vaapi_picture_tfp.cc b/media/gpu/vaapi/vaapi_picture_tfp.cc
index 227c31b..b42620d 100644
--- a/media/gpu/vaapi/vaapi_picture_tfp.cc
+++ b/media/gpu/vaapi/vaapi_picture_tfp.cc
@@ -57,7 +57,7 @@
   if (make_context_current_cb_ && !make_context_current_cb_.Run())
     return false;

-  glx_image_ = new gl::GLImageGLX(size_, GL_RGB);
+  glx_image_ = new gl::GLImageGLX(size_, gfx::BufferFormat::BGRX_8888);
   if (!glx_image_->Initialize(x_pixmap_)) {
     // x_pixmap_ will be freed in the destructor.
     DLOG(ERROR) << "Failed creating a GLX Pixmap for TFP";
--- a/media/mojo/services/gpu_mojo_media_client.cc	2020-04-02 21:11:34.000000000 -0700
+++ b/media/mojo/services/gpu_mojo_media_client.cc	2020-04-09 00:44:58.871366432 -0700
@@ -158,6 +158,7 @@
       *d3d11_supported_configs_;

 #elif BUILDFLAG(USE_CHROMEOS_MEDIA_ACCELERATION)
+#if defined(OS_CHROMEOS)
   if (base::FeatureList::IsEnabled(kChromeosVideoDecoder)) {
     if (!cros_supported_configs_) {
       cros_supported_configs_ =
@@ -167,6 +168,7 @@
         *cros_supported_configs_;
     return supported_config_map;
   }
+#endif  //defined(OS_CHROMEOS)
 #endif

   auto& default_configs =

vdpau-support.patch
--- a/media/gpu/vaapi/vaapi_video_decode_accelerator.cc
+++ b/media/gpu/vaapi/vaapi_video_decode_accelerator.cc
@@ -641,6 +641,7 @@ void VaapiVideoDecodeAccelerator::AssignPictureBuffers(
   // |vpp_vaapi_wrapper_| for VaapiPicture to DownloadFromSurface() the VA's
   // internal decoded frame.
   if (buffer_allocation_mode_ != BufferAllocationMode::kNone &&
+      buffer_allocation_mode_ != BufferAllocationMode::kWrapVdpau &&
       !vpp_vaapi_wrapper_) {
     vpp_vaapi_wrapper_ = VaapiWrapper::Create(
         VaapiWrapper::kVideoProcess, VAProfileNone,
@@ -665,7 +666,8 @@ void VaapiVideoDecodeAccelerator::AssignPictureBuffers(
     PictureBuffer buffer = buffers[i];
     buffer.set_size(requested_pic_size_);
     std::unique_ptr<VaapiPicture> picture = vaapi_picture_factory_->Create(
-        (buffer_allocation_mode_ == BufferAllocationMode::kNone)
+        ((buffer_allocation_mode_ == BufferAllocationMode::kNone) ||
+         (buffer_allocation_mode_ == BufferAllocationMode::kWrapVdpau))
             ? vaapi_wrapper_
             : vpp_vaapi_wrapper_,
         make_context_current_cb_, bind_image_cb_, buffer);
@@ -1093,6 +1095,12 @@ VaapiVideoDecodeAccelerator::GetSupportedProfiles() {

 VaapiVideoDecodeAccelerator::BufferAllocationMode
 VaapiVideoDecodeAccelerator::DecideBufferAllocationMode() {
+  // NVIDIA blobs use VDPAU
+  if (VaapiWrapper::GetImplementationType() == VAImplementation::kNVIDIAVDPAU) {
+    LOG(INFO) << "VA-API driver on VDPAU backend";
+    return BufferAllocationMode::kWrapVdpau;
+  }
+
   // TODO(crbug.com/912295): Enable a better BufferAllocationMode for IMPORT
   // |output_mode_| as well.
   if (output_mode_ == VideoDecodeAccelerator::Config::OutputMode::IMPORT)
@@ -1105,7 +1113,7 @@ VaapiVideoDecodeAccelerator::DecideBufferAllocationMode() {
   // depends on the bitstream and sometimes it's not enough to cover the amount
   // of frames needed by the client pipeline (see b/133733739).
   // TODO(crbug.com/911754): Enable for VP9 Profile 2.
-  if (IsGeminiLakeOrLater() &&
+  if (false && IsGeminiLakeOrLater() &&
       (profile_ == VP9PROFILE_PROFILE0 || profile_ == VP8PROFILE_ANY)) {
     // Add one to the reference frames for the one being currently egressed, and
     // an extra allocation for both |client_| and |decoder_|, see
--- a/media/gpu/vaapi/vaapi_video_decode_accelerator.h
+++ b/media/gpu/vaapi/vaapi_video_decode_accelerator.h
@@ -204,6 +204,7 @@ class MEDIA_GPU_EXPORT VaapiVideoDecodeAccelerator
     // Using |client_|s provided PictureBuffers and as many internally
     // allocated.
     kNormal,
+    kWrapVdpau,
   };

   // Decides the concrete buffer allocation mode, depending on the hardware
--- a/media/gpu/vaapi/vaapi_wrapper.cc
+++ b/media/gpu/vaapi/vaapi_wrapper.cc
@@ -131,6 +131,9 @@ media::VAImplementation VendorStringToImplementationType(
   } else if (base::StartsWith(va_vendor_string, "Intel iHD driver",
                               base::CompareCase::SENSITIVE)) {
     return media::VAImplementation::kIntelIHD;
+  } else if (base::StartsWith(va_vendor_string, "Splitted-Desktop Systems VDPAU",
+                              base::CompareCase::SENSITIVE)) {
+    return media::VAImplementation::kNVIDIAVDPAU;
   }
   return media::VAImplementation::kOther;
 }
--- a/media/gpu/vaapi/vaapi_wrapper.h
+++ b/media/gpu/vaapi/vaapi_wrapper.h
@@ -79,6 +79,7 @@ enum class VAImplementation {
   kIntelIHD,
   kOther,
   kInvalid,
+  kNVIDIAVDPAU,
 };

 // This class handles VA-API calls and ensures proper locking of VA-API calls

These are the patches from chromium-vaapi. I have them in my fork and vaapi is working as expected.
This video https://www.youtube.com/watch?v=LXb3EKWsInQ plays without stuttering at 1080p60 and my cpu is at ~30%

@jstkdng I have tried to install your OBS package and VAAPI works fine, thank you.
Next time when I compile Ungoogled chromium, I'll make sure I'll add these patches.

@Rowisi Glad it works for you.
@jstkdng Maybe you can add those patches here too?

@wchen342 It's not like those patches are my intellectual property or something, just take them.
I'd PR but my fork has diverged quite a bit from here.

It seems the VAAPI bug is fixed in 81.0.4044.122 build without using those patches, closing.


Should boot_policy_manifest_*_get() return volatile pointers?

See this comment for context.

Closing this issue as obsolete as the bootstrap mechanism does not operate on the boot_policy_manifest_*_get() return values.

@moidx this issue is not really related to bootstrap and boot_policy still uses the return values of these functions.
I thought about this a little bit and also discussed this offline with @luismarques. My thoughts were:

These pointers point to a flash location but they are not modified within the ROM. So unless the compiler can optimize away the first read from a pointer I think we should be good but I don't think it can really do that without seeing a prior write to the same location.

@luismarques also agreed.
I think we can keep this closed. Please feel free to reopen if you don't agree.


ImageTable: add region name to new region message

FIX # https://github.com/RedHatInsights/image-builder-frontend/issues/1410
this commit add region name when user share to new region for image

/retest


OneBranch Pipelines for Geneva Configuration

Which issue this PR addresses:
USER STORY 10097812 - Configure Geneva Events to Forward to Public INT Kusto Cluster
What this PR does / why we need it:
This PR defines the OneBranch ADO pipelines used to generate the Ev2 rollout files for the Geneva Bootstrapper and Geneva deployments.
Test plan for issue:
Both OneBranch pipelines are already being used to generate the Ev2 rollout files that configure Geneva log and metric accounts in Public INT, FF INT, and FF PROD.
Geneva Bootstrapper
Geneva
Is there any documentation that needs to be updated for this PR?
No. The ARO Geneva Logging Ev2 Rollout will be documented in a separate set of PRs and work items.

/azp run CI


implement proper signal handling in C code

May be able  to follow what  petsc4py is doing.

This is  pretty low priority bit of functionality since the xdmf archive is rarely left in an unusable state, but it may happen more often as we scale up to larger core counts and writes take longer. As a practical solution, I think we need two things

A simple signal handler that will catch a user signal (e.g. USR1) and cleanly exit the time stepping loop (e.g. https://pymotw.com/2/signal/), thus allowing a user to signal a soft exit.
A time limit option to parun that will cleanly shutdown time stepping and close files before some outside system kills the run uncleanly.


Using shared network as the default network

@jframos @jesuspg
https://jira.tid.es/browse/CLAUDIA-5007

LGTM

LGTM


Minor improvements after testing with Commfides certificates

Better error message if keystore loading fails
Support multiple private keys in keystore (using aliases)

Ganske enkel og grei, denne. Kanskje @SindreNordbo har lyst til å være mergeminister.

Looks good to me :+1:
Suggest you do a git rebase -i HEAD~3 and edit the commit messages to English, since we've used it up to now.

Arf, of course! I get confused when jumping between the repos :grin:

Arf, then I'd have to make a new PR as well… I'll leave those two in Norwegian and promise to get it right the next time! :princess:

I shamelessly do force-pushs on "my own" branches all the time. I think Github handles it well on already-made PRs. Maybe the existing comments gets hidden for being outdated, but they should still stay with the PR. Anyway, it's not a big deal.


Timesheet - 30/05/2021 - James Pang

Task 1
Projects HIFI

Fixed mobile device issue in projects HIFI.
Fixed issue of project card width and tidy up css
Review code and fix missing stuffs

Proof of Work

https://github.com/thenewboston-developers/Website/pull/1753/commits/6197985d0ce9619162cc11c61bb1908bf7fdeca8

Time Spent
3.5 hours

Task 2
Fix another issue with twitter sharing SEO
Proof of Work

https://github.com/thenewboston-developers/Website/pull/1827

Time Spent
.5 hours

Total Time Spent
4 hours
Account Number
c54c04774efaae20746fd3f29cdd619fea512e119bc1082b863572b2e8844104

Hey @jamessspanggg is it ready?

Hey @jamessspanggg is it ready?

yep ready sorry


Fix create service tutorial

Description

https://jira.mesosphere.com/browse/DCOS_OSS-852
Urgency

[ ] Blocker
[ ] High
[x] Medium

Requirements

Test all commands and procedures.
Build content locally and test for formatting/links.
Add redirects to dcos-website/redirect-files.
Change all affected versions (e.g. 1.7, 1.8, and 1.9).
See the contribution guidelines.

I have a comma correction, otherwise, LGTM

@sascala k, ready for merge.


Increase test coverage to 90%

This could help us stabilize internal APIs.

First brach: #50.

More tests added: #53


deepfactor

Added

deepfactor action

Changed

moved some devDependencies to dependencies

Removed

2 unused deps

I moved storybook back out of dependencies, as it did this when installing in a consumer app, which I didn't want. `mike@Michaels-Mac-mini cover-ui % npm i -D https://github.com/silinternational/ui-components#12ab2480b951fa5e324cf5f1c84209694279b9e1
npm WARN idealTree Removing dependencies.@silintl/ui-components in favor of devDependencies.@silintl/ui-components
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN skipping integrity check for git dependency<EMAIL_ADDRESS>npm WARN deprecated<EMAIL_ADDRESS>This functionality has been moved to @npmcli/fs
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.
npm WARN deprecated<EMAIL_ADDRESS>This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-private-methods instead.
npm WARN deprecated<EMAIL_ADDRESS>This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-nullish-coalescing-operator instead.
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Use String.prototype.trim() instead
npm WARN deprecated<EMAIL_ADDRESS>This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-object-rest-spread instead.
npm WARN deprecated<EMAIL_ADDRESS>This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-chaining instead.
npm WARN deprecated<EMAIL_ADDRESS>This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-private-property-in-object instead.
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Package no longer supported and required. Use the uuid package or crypto.randomUUID instead
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated<EMAIL_ADDRESS>This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-object-rest-spread instead.
npm WARN deprecated<EMAIL_ADDRESS>some dependency vulnerabilities fixed, support for node < 10 dropped, and newer ECMAScript syntax/features added
npm WARN deprecated<EMAIL_ADDRESS>The v1 package contains DANGEROUS / INSECURE binaries. Upgrade to safe fsevents v2
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
added 1287 packages, removed 1 package, changed 5 packages, and audited 1840 packages in 1m`

As far as I can tell, this is fine, though I don't fully know the effects of things like removing sass-loader or svelte-loader.

These are webpack build tools we never used (probably mistakenly brought in for storybook config). Storybook build still works so shouldn't be a problem.

:tada: This PR is included in version 10.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Official way to prevent the explorer panel opening every time I switch active editor tabs?

Would love LOVE there to be an officially supported way to stop the explorer panel from re-opening each and every time I switch between active editor tabs. If I minimize while working on file A, it should be an option to keep it minimized when switching to file B. This causes so much needless time wasting by having to re-minimize it constantly.

Have you tried setting "explorer.autoReveal": false?

Yes, unfortunately it does not work. I have an extension that helps with the issue but the best that it does is allow the side panel to open but immediately close again.

I don't seem to have this problem, can you tell me if I'm missing any repro steps

@lramos15 thank you for taking the time to test on your end. This at least confirms the issue is on my end and probably the result of a plugin causing this to happen. I am going to start turning them off to see if I can isolate which one is causing my hair to grey faster than it naturally does.

F1 -> Troubleshoot issue might be helpful


UFAL/FE-Assetstore files are not loaded

Problem description
If the namespace is changed some images are not loaded properly. E.g. flags, images which has defined url in the style files.
Menu navbar links are also not loaded.

There wasn't problem only with images, but whole redirection system was broken because we used href redirection instead of routerLink and it ignored namespace property.

If you are setting up the namespace do not forget to set up namespace in the aai.js, check the doc: https://github.com/dataquest-dev/DSpace/wiki/Discojuice-set-up


Update about-wikis.md

For private and internal repositories people with access to the repository can also access the wiki.
Changing it to
For private and internal repositories people with access to the repository can only access the wiki.

Why:
It is mentioned that for private and internal repository people with access to the repository can also access the wiki.
This is a bit confusing. Hence updated it to people with access to the repository can only access the wiki
What's being changed:
Before Change:
For private and internal repositories people with access to the repository can also access the wiki.
After Change:
For private and internal repositories people with access to the repository can only access the wiki.
Check off the following:

[ ] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[yes ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@Vignesh-Seethapathy
Thanks so much for opening a PR! I'll get this triaged for review :zap:

Thanks for opening this PR @Vignesh-Seethapathy ✨ I've tweaked your suggested change slightly, and we will get it merged shortly 🚀


release-if-needed sent incorrect repository name to releasebot

In a recent workflow, release-if-needed misnamed the repository:
< HTTP/2 400
...
Could not parse/home/runner/work/pulumi-oci/pulumi-oci

We should not have send the full repository path to release-bot.

closing b/c I don't think we've seen this happen again recently


[quorum] Remove download of whole quorum repo to build geth and bootnode

Signed-off-by: nikhilayadav<EMAIL_ADDRESS>
Add logic to remove download of whole quorum repo to build geth and bootnode

Reviewed by
@sownak @suvajit-sarkar @jagpreetsinghsasan
Linked issue
#1836

Is the network deployment tested for both the consensus?

@nikhilayadav also fix everything first before re-requesting review, I can still see the molecule tests being failed. I am saying this because, to fix the molecule test, you have to do some changes to the ansible code and then I have to review the entire code again.

Closed as this has been fixed by PR #1905


Is allowance required?

I am wondering if the transfer by signature logic introduced here in combination with EIP 1271 removes the need for the approve + transferFrom flow and the allowance storage in the ERC20 standard if we were to start from scratch? Or is there some special cases when allowance still has extended functionality?
In a slightly tangential yet related note, is there any thought about introducing a transfer by signature scheme for custom defined data such as a UniswapV3Pool position. The benefit of this would be that custody of the position could be separated from the helper functions that allow you to enter and exit a position. I think you could then still go back and wrap this in the ERC721 standard after the fact too.

Hey @kyscott18, if I understand your first paragraph correctly, EIP 1271 + signature logic works great for contract wallets but not EOA's, but with Permit2 there's the option to sign a message w/ and EOA which performs a transfer without affecting allowances. I think the only downside to this is the EOA must sign this message and the tx, so that's two signatures (button presses) for every transaction, that might be seen as a UX downside.
The position could be separated from the helper functions mint/burn?


Add ElephantBird section to LICENSE file

Commit 9993450 brought in a section of LzoRecordReader.java from ElephantBird. The license for ElephantBird is ASL 2.0 so the inclusion is fine. We just need to add it to the root LICENSE file because it is included in the source distribution and in the parquet-hadoop binary LICENSE file because it is in that binary package.
Reporter: Ryan Blue / @rdblue
Assignee: Ryan Blue / @rdblue
PRs and other links:

PR #256

Note: This issue was originally created as PARQUET-356. Please see the migration documentation for further details.

Alex Levenson / @isnotinvain:
Issue resolved by pull request 256
https://github.com/apache/parquet-mr/pull/256


Stick navbar to top

Issue Template
Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

[x] I am running the latest version
[x] I checked the documentation and found no answer
[x] I checked to make sure that this issue has not already been filed
[x] I'm reporting the issue to the correct repository (for multi-repository projects)

Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Firmware Version: F240000
Operating System: windows
SDK version:
Toolchain version: gcc (Rev10, Built by MSYS2 project) 11.2.0

Expected Behavior
navbar should stick to top
Current Behavior
navbar is moving along with the content
Failure Information (for bugs)
Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.
Steps to Reproduce
Please provide detailed steps for reproducing the issue.

scroll to any section
you get it...

Failure Logs
Please include any relevant log snippets or files here.

Sure @An525ish


Create upside_risk and downside_risk macros

I'm not fully sure what these macros are doing.  Can you add more comments?  Also please indent code inside Macro If/then/Else blocks
%if blah %then %do;
   stuff
%end;
%else %do;
   other stuff
%end;


Nft1 parent functions

Creating parent NFT works but minting is not working. It gives this error { success: false, error: 'no minting baton UTXO in the minter wallet' }.
I remember we needed to make changes to UTXOs endpoint in watchtower but we didn't get to that point. At the moment, I don't the following API call is getting the response it expects:
  async getNftUtxos (handle, tokenId, rawTotalSendAmount, isCreatingChildNft, groupBaton = false) {
    let resp
    if (handle.indexOf('wallet:') > -1) {
      resp = await this._api.get(
        `utxo/wallet/${handle.split('wallet:')[1]}/${tokenId}/?&value=${rawTotalSendAmount}&baton=${groupBaton}`
      )
    } else {
      resp = await this._api.get(
        `utxo/slp/${handle}/${tokenId}/?&value=${rawTotalSendAmount}&baton=${groupBaton}`
      )
    }

    ...
  }

This will have to wait til the endpoint in watchtower being invoked is refactored to generate the response expected by the code above.

Did you run the example from the examples/mint_nft.js file?


Add Sahih international and Clear Quran translation

Add Sahih international and Clear Quran translation

Duplicates https://github.com/Waqar144/quran_memorization_helper/issues/4


Show full value transfers in history, in addition to outgoing txs

iotacooler-smidgen was adapted to retrieve full transaction history for a specific address. This is useful to store and show all past value transactions, including incoming transfers. A big issue is that the API call is crazy slow, especially for addresses with transfers involving big bundles (see carriota field donations).
So a quick "transfer retrieval" call was added to iotacooler-smidgen, which doesn't include the source addresses though, but at least it is usable and fast. I think if someone needs those, clicking the tangle explorer button is not too hard.
Maybe I could offer an option in the settings dialog to use the precise but slow method, if required...

history is not as clean as I wanted because change address filtering is not possible with the quick getTransfers API call


apply styles to immediate img children

fixes https://github.com/Dogfalo/materialize/issues/4435

Not sure if the markup could be different and they could be also not immediate children.

Thanks!


To change the UI of ToDo List

@iamrahulmahato  please assign me this task under GSSOC-EXT & HACKTOBERFEST

Hi @iamrahulmahato .I would like to work on this issue.Could you please assign me this task under the GSSOC-ext and Hacktoberfest-accepted tags?
Thanks so much!


Does cert-manager handle the api and *.apps certificates?

Howdy cert-manager people,
I'm trying to understand the scope of cert-manager: Does cert-manager currently handle (or, is cert-manager envisioned to handle) o custom certificates used with an OpenShift cluster's api and *.apps endpoints?
Specifically, does (or could?) cert-manager do what these procedures describe:

https://docs.openshift.com/container-platform/4.10/security/certificates/api-server.html
https://docs.openshift.com/container-platform/4.10/security/certificates/replacing-default-ingress-certificate.html

Any education appreciated -- Thanks!
patrick

It should be able to do that. Those certificates aren't special--as long as they exist (and are referred to by the apiserver and default ingress controller configuration custom resources) then it should work.
(Appropriate disclaimer: I'm only a user of OpenShift, so take that with the usual grain of salt!)

@pbrooksbcbsnc not an issue for the operator though, but for cert-manager itself.
Anyways, cert-manager just creates appropriate tls secrets, so yes you can use cert-manager for managing those. We use cert-manager in every cluster to manage API and Ingress certificates.


Nonlinear Reservoir HYMOD Integration - Squashed

Nonlinear Reservoir HYMOD Integration - Squashed
[Short description explaining the high-level reason for the pull request]
Additions

Removals

Changes
modified: models/hymod/include/Hymod.h
modified: models/kernels/Nonlinear_Reservoir.hpp
Testing

Screenshots
Notes

Todos

Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[ ] Code follows project standards (link if applicable)
[x] Passes all existing automated tests
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future todos are captured in comments
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist (automated report can be put here)

Target Environment support

[ ] Linux

@hellkite500 and @donaldwj I updated hymod to just work with mass in meters for now to keep everything simple. Please take a look at the changes when you have a chance.

Currently you are storing deltas not fluxes in the output fluxes structure. The timestep needs to be included in the calculation.

Thanks. I will fix in the morning. @jdmattern-noaa

@hellkite500 @donaldwj @ADHydro-devel I updated the output fluxes to velocities. I think this is what you were referring to, Donald. Per Fred's request, I added warning statements for whenever a reservoir goes below min or above max storage.
The Hymod TestWithKnownInput causes the reservoir to go below minimum storage about 800 times with the given timestep of 86400 seconds. I tried a few different timesteps. 300 seconds caused it to exceed maximum storage the same number of times, and 3600 seconds caused it to switch off going below min and exceeding max the same number of times. I assume these are known params and inputs for the test. The reservoirs seem to be very susceptible to exceeding their boundaries unless I am misinterpreting some of the params or inputs.

I will rebase this, per Nels request.

Rebased on top of master.


[Cloud SDK 5] Update extensibility and security tutorials

Context
The tutorials Extensibility, Type-Safe Expand, and Dependency Injection with the Virtual Data Model for OData and Secure Your Application on SAP Business Technology Platform Cloud Foundry have been updated to use the latest version of the Cloud SDK with it's associated code changes.
Those changes have been previously applied and reviewed in the QA repo.
For reviewers
.gitignore excludes rule.vr files used for the quiz questions, I added them in anyway, please let me know if this was an error.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


quick fixes, add possibility for multiple alternatives

in the current implementation each issue can only have one quick fix, but actually there might be multiple, eg one adding a pragma
add possibility to provide multiple fixes for each issue
maybe also a description that describes the quick fix

plus default indicator

missing: description


Fixing globo #2524

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Fixing #2524
Added 2 calls to download pages to setup cookies. First call is needed to set GLBEXP and glb_uid cookies. Second call is needed to set locksession
Changed playback video version to 2.
Fixed the JSON format for the new version.
Added a new test case.

Test Result:

D:\ytdlp\yt-dlp>python test/test_download.py TestDownload.test_Globo_all
C:\Users\User\AppData\Local\Programs\Python\Python38\lib\subprocess.py:946: ResourceWarning: subprocess 6268 is still running
_warn("subprocess %s is still running" % self.pid,
ResourceWarning: Enable tracemalloc to get the object allocation traceback
[debug] [Globo] Extracting URL: http://g1.globo.com/carros/autoesporte/videos/t/exclusivos-do-g1/v/mercedes-benz-gla-passa-por-teste-de-colisao-na-europa/3607726/
[Globo] 3607726: Getting cookies
[Globo] 3607726: Downloading JSON metadata
[Globo] 3607726: Downloading security hash for 3607726
[Globo] 3607726: Getting locksession cookie
[Globo] 3607726: Downloading m3u8 information
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[info] 3607726: Downloading 1 format(s): hls-2062
[info] Writing video metadata as JSON to: test_Globo_3607726.info.json
C:\Users\User\AppData\Local\Programs\Python\Python38\lib\subprocess.py:946: ResourceWarning: subprocess 6896 is still running
_warn("subprocess %s is still running" % self.pid,
ResourceWarning: Enable tracemalloc to get the object allocation traceback
[debug] [Globo] Extracting URL: http://globoplay.globo.com/v/4581987/
[Globo] 4581987: Getting cookies
[Globo] 4581987: Downloading JSON metadata
[Globo] 4581987: Downloading security hash for 4581987
[Globo] 4581987: Getting locksession cookie
[Globo] 4581987: Downloading m3u8 information
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[info] 4581987: Downloading 1 format(s): hls-2226
[info] Writing video metadata as JSON to: test_Globo_1_4581987.info.json
C:\Users\User\AppData\Local\Programs\Python\Python38\lib\subprocess.py:946: ResourceWarning: subprocess 2896 is still running
_warn("subprocess %s is still running" % self.pid,
ResourceWarning: Enable tracemalloc to get the object allocation traceback
[debug] [Globo] Extracting URL: https://globoplay.globo.com/v/10248083/
[Globo] 10248083: Getting cookies
[Globo] 10248083: Downloading JSON metadata
[Globo] 10248083: Downloading security hash for 10248083
[Globo] 10248083: Getting locksession cookie
[Globo] 10248083: Downloading m3u8 information
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[info] 10248083: Downloading 1 format(s): hls-2735
[info] Writing video metadata as JSON to: test_Globo_2_10248083.info.json
.
Ran 1 test in 1.495s
OK

Download Test.

 Install ffmpeg to fix this automatically


Deprecations in github CI

Several deprecations are mentioned on our CI jobs. We should tackle them before they are fully deprecated and jobs start to fail.
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: slackapi/slack-github-action
The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
EDIT(itxaka): This deprecation have a hard limit of summer 2023, then they will stop working.

[x] elemental-cli
[ ] elemental-operator

setup-kind seems almost abandoned :/

[x] elemental
[x] elemental-toolkit

under the elemental-operator there are actions that have no support yet for the deprecations:

engineerd/setup-kind
golangci/golangci-lint-action
mikefarah/yq (Fixed but waiting release)

setup-kind has no updates, sent a PR: https://github.com/engineerd/setup-kind/pull/197

elemental-operator:

anchore/sbom-action has a patch now, waiting for a release > 0.12.0

elemental-operator:

golangci-lint-action also seems to have been fixed, but no release yet.

@davidcassany IMO this should not have a milestone as its not really needed by that date. Nice to have ASAP yes, but not a such closer date. Its a pita to go over all actions ;)

Yes agree, the milestone was essentially added to avoid touching it before the 2.6.9 release.
In fact, my only concern is about running CI refactors while go/no-go tests for a release are expected to happen. However I think most, it not all, of the current deprecations are happening in non e2e tests and UI tests.
Removing the milestone.

For elemental-cli:

PR: https://github.com/rancher/elemental-cli/pull/345
golangci-lint-action also seems to have been fixed, but no release yet.

elemental-operator:

https://github.com/rancher/elemental-operator/pull/234

toolkit:

https://github.com/rancher/elemental-toolkit/pull/1639

once the toolkit PR is merged only the setup-kind action will be left from our main repos. We may need to move this to the blocked column. I pinged the main contributor for the repo in my PR to see if they are willingto merge and release a new version or we need to fork it and maintain it. I hope its done by summer 2023....

Have we looked at renovatebot to automate such updates ?

Have we looked at renovatebot to automate such updates ?

checking....

Mostly done. Will open individual issues as needed.

@kkaempf just a heads up, patch for setup-kind action was closed as there is no intention of updating it. Thankfully kind is now available preinstalled on the ubuntu-22 nodes so there is no need for the install action anymore :)


Writing a library to support both turbolinks classic and new

Is there any harm in setting the data-turbolinks-track when using Turbolinks 5?
Better to omit it for Turbolinks 5?
   <%= env_stylesheet_link_tag(static: 'application_static',
                               hot: 'application_non_webpack',
                               media: 'all',
                               'data-turbolinks-track' => true)  %>

     <%= env_javascript_include_tag(static: 'application_static',
                                    hot: 'application_non_webpack',
                                    'data-turbolinks-track' => true) %>

OK -- I see this is still in Turbolinks 5:
Reloading When Assets Change
Turbolinks can track the URLs of asset elements in <head> from one page to the next, and automatically issue a full reload if they change. This ensures that users always have the latest versions of your application’s scripts and styles.
Annotate asset elements with data-turbolinks-track="reload" and include a version identifier in your asset URLs. The identifier could be a number, a last-modified timestamp, or better, a digest of the asset’s contents, as in the following example.
<head>
  ...
  <link rel="stylesheet" href="/application-258e88d.css" data-turbolinks-track="reload">
  <script src="/application-cbd3cd4.js" data-turbolinks-track="reload"></script>
</head>

Note that Turbolinks will only consider tracked assets in <head> and not elsewhere on the page.

Right, but note that in Turbolinks 5 the attribute value must be "reload".


Submit pr to add to stylelint processors

https://stylelint.io/user-guide/processors/

Done! https://github.com/stylelint/stylelint/pull/2836


Revert "ast compressing for function body: #47, #45"

That commit doesn't fix the issues, so let's revert it.

I feel like to add you as a collaborator, then you can decide and perform these obvious things quickly. is that okay?

Sure thing. :-)

I've sent you the request(ゝ∀･)


Changed huntergate hash, build and run Adept GMM

Added CMakeLists.txt to build adept gmm
Modified Adept main.cpp to fit new structure (and added some output)
Changed to x64-debug because Adept/lib/Debug/Adeptd.lib was built in x64

Manual BA failed, seemingly due to missing Eigen package


Remove dependence of fs-extra

I found that fs-extra is not used. So it could be removed.

Ty

one moment and i will release new version with this fixed

Please install v0.0.5 of get-paths via npm install get-paths@latest.
This is also a dependency of email-templates and koa-views, and I am version bumping those packages right now as well.


V4 docs theme

Codecov Report

Merging #395 into v4-docs will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           v4-docs   #395   +/-   ##
======================================
  Coverage      100%   100%
======================================
  Files            1      1
  Lines          154    154
======================================
  Hits           154    154

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18449cd...050330a. Read the comment docs.


User feedback suggestions

Hey Kyle!!
I just tried moduloze with unist-util-visit. very simple CJS module. and it worked perfectly!!
there are some suggestions I have in order to make ir more user friendly:

If the target user requires it, it would be nice to have a simple walkthrough on how to use this package: I find something like a guided tutorial very good for something like this: example

Better (and more accurate error messages: I was testing moduloze with a "what I remembered was a " CJS module, but it was not. I was getting a config error when the actual error was that the module where I was trying to transform, was a ESModule already 🤦♂. I know this was a silly mistake by me, but if I was getting something else as an error, it could let myself to review the actual module, and not the moduloze config.

Simpler version of documentation: The current documentation is AMAZING, but for someone that is looking for a tool like this might be too much at first. I think this could led people to not even trying it...

I suggest a simpler version of it as an entry point that covers:

Installation
basic usage
reduced table of options (maybe the actual module help)

This are the main issues I found after trying it in a very simple module! Great job Kyle!, and thanks for sharing it 👏👏👏💪💪💪

great feedback, thanks!

Just curious, what error message did you get for (2)? Can you show the code and the error output? That would help identify how the error messaging should improve.

$ mz --from="./src"
Invalid config: /Users/horacio/workspace/oss/remark-slate/.mzrc

I tried it with this repo: https://github.com/hanford/remark-slate
this is an ES6 repo, I would expect something more on the lines of source code is not a valid entry or something similar?

Ahh, yes, that's a known issue. I was thinking maybe you got an obscure parsing error against an ES6 module file being parsed as a CJS file.

OK, I just published v0.4.2 which fixes the bugs with a missing .mzrc or dependency-map.
Perhaps you could re-try it now with the update?

hey @getify!
I was testing the module again with a cjs lib I have that I want to convert to esm and I couldn't find the config I need to make it work.
the library I want to convert is code generated from some Go code, but I need the code to be ESM because I'm using Snowpack for the JS App. apart from the code I have .d.ts files with it, dunno if that could help to generate the desired code?
I'm ok with sending the code if you want to test of give me some guidance! :)
thanks in advance and hope you and your family are safe and healthy!

heres's the files!
https://github.com/horacioh/test-moduloze/tree/main
not getting an error, but not getting the expected result either XD
hope the repo explains well the problem!, if not, please let me know to clarify anything!

I discovered a bunch of bugs in moduloze v0.7.0, a lot of them related to incorrect/naive path handling. Took quite a bit of work to rewrite all that handling logic, but I landed those fixes in v0.8.0
Any chance you might be able to re-try your conversion with v0.8.0+ to see if it resolves any of the problems?

sure thing!!
I did update to 0.8.0, and with the same config I'm getting this error:
→ yarn build
yarn run v1.22.5
$ ./build.js
/Users/horacio/workspace/playground/test-moduloze/node_modules/moduloze/src/esm.js:60
                        throw new Error(`Unknown module: ${ pathStr }`);
                        ^

Error: Unknown module: ./documents_pb.js
    at build (/Users/horacio/workspace/playground/test-moduloze/node_modules/moduloze/src/esm.js:60:10)
    at build (/Users/horacio/workspace/playground/test-moduloze/node_modules/moduloze/src/index.js:44:16)
    at Object.<anonymous> (/Users/horacio/workspace/playground/test-moduloze/build.js:17:15)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
    at internal/main/run_main_module.js:17:47
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Command failed: /Users/horacio/.yvm/versions/v1.22.5/bin/yarn.js build

Should I change something in the config? (build.js file)

Actually, just looked closer at your code. I think the real problem is that the original file (the input to moduloze) is not in CJS format... that is, it doesn't have any module.exports or require(..) statements. That's what moduloze operates on. From what I can tell, moduloze isn't really changing anything about the file, other than parsing it and then re-generating from the AST.

In your depmap, add:
"documents_pb.js": "someName"

what about node_module deps? getting Unknown dependency: grpc-web and Unknown dependency: google-protobuf
sorry if this questions seem to be too obvious :(

@getify Apologies for hijacking the thread, but today I tried running moduloze on a several repos I had and I keep getting:
npx -p moduloze mz --from=./src --build-esm
Invalid/missing dependency map (/path/to/project/package.json)

I've gone through the docs multiple times and I still don't quite get what a dependency map is, why it's needed or why is it trying to load it from package.json. Mapping or writing down every dependency of each project wouldn't really be feasible - or, rather, the effort to do so would be comparable to manually translate every module to ESM.

@nfantone could you please start a new thread? I just tried this in a fresh/clean directory and it worked fine, so I wanna track down what's going on for you. The dependency-map is only required for the UMD format, so getting that error seems to indicate you're trying to build UMD even though that's not part of your command line arguments. That likely means a config file telling it to build UMD.
In the new thread, please let me know:

what does npx -p moduloze mz --version report as the version?
what does npx -p moduloze mz --help report for the various default options (like paths and build options)?
if you have a .mzrc config in your project directory, what's its contents?
if you have a package.json in your project directory, does it have a "mz-dependencies" key, and if so, what's its contents?

@getify Here's the new issue: https://github.com/getify/moduloze/issues/17. Apologies again.


Deprecated node js runtime

Describe the bug
While running cdk deploy, getting an error - The runtime parameter of nodejs14.x is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs20.x) while creating or updating functions. (Service: Lambda, Status Code: 400, Request ID: 0c42d1e3-136b-4228-ac8e-ea06
fd84573a)" (RequestToken: f3a3d7ef-1187-9046-1e24-2b916cf1bcd8, HandlerErrorCode: InvalidRequest)
To Reproduce
Steps to reproduce the behavior:
Run the cdk deploy command from infra project
Expected behavior
The lambda functions and API GW should be provisioned.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS] Windows,Linux

Additional context
Upgrading the cdk lib version in infra.proj to 2.128.0 solved the issue.

@rajdban Done


Adds audio querying to MultimodalQ&A gateway

Description
Adds ASR endpoint, speech audio processing, prompt construction, and return of decoded audio in response metadata. This goes with GenAIExamples PR: https://github.com/opea-project/GenAIExamples/pull/1225.
Issues
Part of the MultimodalQnA Audio & Image Enhancements RFC
Type of change

[x] New feature (non-breaking change which adds new functionality)

Dependencies
N/A
Tests
Automated tests were added to GenAIExamples.

Labeling this as WIP since we may not need it after all.

Looking at new changes in GenAIExamples, it seems like we don't this PR after all since this PR https://github.com/opea-project/GenAIExamples/pull/1225 is self contained.


Docker

How do I run this app in a docker container?

There is an example in the wiki: https://github.com/tsl0922/ttyd/wiki/Example-Usage#docker-image

Thanks. Will check it.


feat(kafka): partition id as record metadata

Reason for this PR
We want to allow Kafka consumers to understand how many partitions they are poling from.
Partition id is not a concept tackled in other queues implementations managed here, so we only change the Kafka consumer logic.

We create a new un-exported string constant, with value partition_id. This will be populated in the context.Context attached to each kgo.Record via the queuecontext package.
Consumers will be ale to understand which partition a record was polled from by parsing the record's metadata.
Unrelated small performance improvement: pre-allocate map capacity to the length of headers.

Partition id is not a concept tackled in other queues implementations managed here

CMIIW, we only have 2 implementations, kafka and pubsublite. For kafka, we can use franz-go's OnPartition{Assigned, Lost} (ref) methods and for pubsublite we can use the ReassignmentHandler (ref). If we track independent of consumption then we will have a lot more flexibility in handling partition based logic.

For kafka, we can use franz-go's OnPartition{Assigned, Lost} (ref) methods and for pubsublite we can use the ReassignmentHandler (ref). If we track independent of consumption then we will have a lot more flexibility in handling partition based logic.

Trying to process your comment, I am fairly new to the codebase and the libraries so thanks fer being my rubber duck.
The goal of the PR is to allow consumers to know which partition each message is polled from. The reason to know such information is that when a client consuming from multiple partitions wants to have as many processing goroutines as partitions polled, each message can follow a different pipeline, landing in the parallel gorotuine (or processor) that is responsible to manage it.
Do you suggest that it is possible to achieve the same using the callbacks you mentioned?
This PR is specific for Kafka, but I'd be happy to extend the same concept to pubsublite.

If we track independent of consumption then we will have a lot more flexibility in handling partition based logic.

What do you mean exactly with "track independent of consumption"?
The goal is not just tracking (e.g. with metrics) but also to allow messages' consumers to actively place each record on a dedicated processing pipeline (thread/goroutine/interface) when reading off the queue.

@inge4pres Did you consider adding a new  Partition field to apmqueue.Record? It seems like a more explicit and robust API where the partition ID is passed down in each record. Implementations of apmqueue. Processor are free to do what they wish with that information during processing time.
type Record struct {
	// Topics holds the topic where the record will be produced.
	Topic Topic
	// Partition holds the partition where the record is consumed from.
	Partition uint32
	// OrderingKey is an optional field that is hashed to map to a partition.
	// Records with same ordering key are routed to the same partition.
	OrderingKey []byte
	// Value holds the record's content. It must not be mutated after Produce.
	Value []byte
}

In PubSub Lite, the partition ID is encoded in the Message.ID, which can be decoded using pscompat.ParseMessageMetadata.
https://github.com/elastic/apm-queue/blob/18bac8091d166fd6b079f6a7906af04a0c905f06/pubsublite/consumer.go#L293

What do you mean exactly with "track independent of consumption"?
The goal is not just tracking (e.g. with metrics) but also to allow messages' consumers to actively place each record on a dedicated processing pipeline (thread/goroutine/interface) when reading off the queue.

Ah, I misunderstood the PR a bit. I agree, the proposal in this comment was towards being able to track which partitions are being consumed by a consumer in advance of the consumption but it won't help towards the other objectives of the PR. Apologies about the misdirection.

Did you consider adding a new Partition field to apmqueue.Record? It seems like a more explicit and robust API where the partition ID is passed down in each record.

Good point, thanks 🙏🏼
I had not thought about it, and followed an implementation on the same principle as project_id being part of the record context.
I'll try that and see how it performs👍🏼 should we also make project_id a part of Record then?
What if we leave both on the metadata for now and proceed in extracting them as fields of Record in a future moment?

should we also make project_id a part of Record then?

While reasoning again on this I thought: while the partition is part of the queue domain, project Id is not.
Therefore it does not make any sense to add to apm-queue the project_id concept, it should be treated as any other record metadata.
The partition ID, instead, is entirely part of how records are being processed (they are inherently part of a partition) so I will follow the suggestion and make if part of the Record struct.

Are you planning on tackling pub/sub lite on another PR? Or simply open an issue to defer it?

Will implement pubsub also in this Pr, I was waiting for a confirmation on where to place the partition Id.
We agree it goes into Record, so I'll move ahead with that.
The only downside I see is this implmentation is that we're making the struct less mechanical-sympathetic , as we are moving it from a 64-bit aligned struct to 2 words.
I don't think this poses a performance concern, but i'll keep an eye on the tests for it.

The proposal is implemented 🎉
An additional function in queuecontext, with signature "Enrich(context.Context, string, string)" is added as a utility to transmute the field from Record into context.


Ideas for improvement

Add a class decorator to easily add classes to a register
Create base class for the auto-registering classes
Add a way to override/deregister a class
Allow creating a new field that handles the register

In a v2: Change label for key, verbose_name for label

Look into changing rest_framework to allow adding a new link to the serializer field


Fix errors found with pyflakes

While investigating https://github.com/NVIDIA/DIGITS/issues/1153, pyflakes pointed out a few real errors (not just style issues).

I had originally started fixing everything from pyflakes. But I stopped because (1) there are a TON of things to fix and (2) we should have a discussion about this first - if we fix all the errors we'll touch all the files and likely make merge conflicts with all the open pull requests.

@gheinrich will you take a quick look? Most of the errors are mine but a few are yours.


Lab4 1

Code for Lab4 parse_library_results_maven.py file

Thank you so much for creating this pull request. As there are around 14 commits, it's quite a lot of changes to review in a single PR :)
Could you please let me know following things:

For which issue are you making this change? Is it for issue #14?
In the PR, overall what are you trying to achieve? I am specifically concerned about few commits with messages like 'asdf', 'errors testing outside docker' etc. I would like to avoid merging such commits in to the repository.
Finally, if you are adding any unit test framework, could you please provide any reference which you are following to implement this? I can see a new file .yml is created and also few files inside _pycache folder is created.
Also it seems that important files such as settings.json/python-app.yml are created inside hidden folders .vscode/.github. I am not sure if this is what we want. That is why I have requested for the references also.

Thank you for the contribution!

Hi there, I am still waiting for your response for this pull request. I cannot accept or merge it without understanding the PR.

Hi there, I am still waiting for your response for this pull request. I cannot accept or merge it without understanding the PR.

As we have waited for a month for the discussion about the PR, we cannot unfortunately wait longer. The associated issue #14 is an important part of the project and we shall have to work on it. We are rejecting this pull request.


Cosmetic filter script lags Bromite after regaining focus

Steps to reproduce:

Enable only the cosmetic filter script in Bromite settings
Visit any webpage where the script is injected
Switch to another app (or the launcher)
Switch back to Bromite
The page is now frozen and doesn't work anymore.

The URL bar and home page button of Bromite still work
Tapping any element on the page (e.g. text inputs) will lead to the page being unfrozen, but only after a significant (more than 10 seconds) delay

I currently don't exactly know why this happens, but it appears to only happen with the cosmetic filter script.

Same for me.

This issue no longer reproduces in Bromite v101.0.4951.53 after https://github.com/bromite/bromite/pull/2037 was released (thank you Bromite devs ❤)


Assassin's Creed Odyssey Infrequent Crashes

Assassin's Creed Odyssey crashes infrequently but runs absolutely great otherwise (so thank you sooo much for DXVK!). That happens sometimes right after loading into the game and playing for 10 seconds and if I'm lucky I can even play an hour or more but it always ends in a crash. It the timing is totally inconsistent.
I tried to do an apitrace but I was unable to do so, because it either didn't do anything or when it seems to load the dlls the game was unplayable with 2-4 FPS. I even let it sit there for an hour and played for round about 15 minutes but didn't crash, of course why should it, right? Maybe I did something wrong I am not sure. A trace file wasn't created in any case either. I added the std output, maybe that helps a little.
Reports with no log files will be ignored.
Software information
Assassin's Creed Odyssey, game settings don't seem to matter, as well as wine version. Tried it why arch, fedora, Lutris and without Lutris and many different wine versions. I even encountered the same behaviour with my RX580 that I had before.
System information

GPU: AMD Radeon RX 5700
Driver: mesa 20.1
Wine version: 5.7
DXVK version: 1.7

Apitrace file(s)

I can't provide one sadly :( Maybe someone can help

Log files

d3d9.log:
ACOdyssey_d3d9.log

d3d11.log:
ACOdyssey_d3d11.log

dxgi.log:
ACOdyssey_dxgi.log

stdout:
wine.log

maybe related?:
https://github.com/KhronosGroup/Vulkan-Loader/issues/433#issuecomment-659920920

Make sure to disable the uplay overlay.
I haven't ever had problems with the game so this isn't really something I can work with; I'll leave the bug report open but don't expect anything to change unless someone else with the same problem actually figures out what's wrong.

maybe related?:
KhronosGroup/Vulkan-Loader#433 (comment)

It's definitely not related. Using lib32-vulkan-icd-loader version 1.2.147-1 (on Arch) the game never launches.
I did have crashes (very probably from my understanding) related to expiration of timed quests. Maybe check that out?

Make sure to disable the uplay overlay.
I haven't ever had problems with the game so this isn't really something I can work with; I'll leave the bug report open but don't expect anything to change unless someone else with the same problem actually figures out what's wrong.

Thanks, when I'm back home I'll try and make sure I really disabled the overlay since I thought that I already did.

maybe related?:
KhronosGroup/Vulkan-Loader#433 (comment)

It's definitely not related. Using lib32-vulkan-icd-loader version 1.2.147-1 (on Arch) the game never launches.
I did have crashes (very probably from my understanding) related to expiration of timed quests. Maybe check that out?

I'm not sure if I understand that right. Do you mean quests that have a limited time to be completed? How do I know it's related, don't they just disappear when the time's up?

Hello! Haha, reading that again I must admit it's quite hard to understand indeed.
Yeah, basically I had the game crash twice at the second the timer reaches 0 instead of just having the quest removed from the quest log.
Hope this helps...

Thanks for all of your help, but it is gpu related, I experienced the same crashing in Windows as well and have since send in the card for repairs! I'll close the issue.

I did have crashes (very probably from my understanding) related to expiration of timed quests. Maybe check that out?

I guess I've got to keep an eye on this, as I too am having random crashes with DXVK & this game. A curious thing I've been observing about the crashes is that the crashes involve the game permanantly freezing and when it freezes it seemingly displays the first frame that was rendered since I'd last alt-tabbed back in to the game which makes the freeze kinda jarring lol.


Data Loss: Compose from Other App

Expected behavior
Drafts started from other apps will be saved when See "saved as draft" alert.
Actual behavior
Draft is not saved.
Steps to reproduce

In chrome browser, click an email address on a web page.
K9 opens compose window
begin composing
Switch away from message
See "saved as draft" alert
open K9
go to drafts folder.

Environment
K-9 Mail version:
Current as of today. 5.010?
Android version:
Will post
Account type (IMAP, POP3, WebDAV/Exchange):
IMAP

Android firnware 4.1.2
Kernel 3.4.0

Is this still an issue with v5.201?

Yes, if sending from non-google IMAP account.
No problem with gmail account.

Any chance this can be fixed?
Thx!

Hi, as the person who started this thread: turns out this is not an issue for me. I had an old account set as "default" account, so my drafts WERE getting saved, in the old account.


Models not loaded into RAM on CPU-Only setup. Is the library using the disk as RAM?

Prerequisites
CPU Only setup on google colab. Link to notebook here:
https://colab.research.google.com/drive/1PXsYMNYLIkTLqrZRpKktGJ4YJu4cULMJ?usp=sharing
Keep an eye on resources during inference.
Running most recent version from pip in Colab.

[ No] I am running the latest code. Development is very rapid so there are no tagged versions as of now.
[Yes ] I carefully followed the README.md.
[Yes ] I searched using keywords relevant to my issue to make sure that I am creating a new issue that is not already open (or closed).
[No ] I reviewed the Discussions, and have a new bug or useful enhancement to share.

Expected Behavior
Inference should not be painfully slow on CPU-Only setup with enough RAM to store the model and it seems to be because the model is not fully loaded into RAM. Standard hugging face transformers do load the whole models into GPU RAM in order to maximize performance. A 7GB model should use at least 7GB on RAM during inference, as it happens with hugging face transformers with GPU RAM.
Current Behavior
Inference is painfully slow on CPU-Only setup with enough RAM to store the model and it seems to be because the model is not fully loaded into RAM.
Environment and Context
It's just basic inference on google colab

Physical (or virtual) hardware you are using, e.g. for Linux:

Google Colab 16GB RAM, CPU Only, Linux
Failure Information (for bugs)
Short inference from a short string takes about 2 minutes with 12GB RAM.
Steps to Reproduce
Please provide detailed steps for reproducing the issue. We are not sitting in front of your screen, so the more detail the better.

Click on the Colab Link provided
Select Runtime > Run all
Look at the size of the downloaded model (About 7GB)
Look at the resources during inference. RAM never goes above 1.2GB

Note: Many issues seem to be regarding functional or performance issues / differences with llama.cpp. In these cases we need to confirm that you're comparing against the version of llama.cpp that was built with your python package, and which parameters you're passing to the context.
I created the same issue on llama.cpp because I understand this probably is not an issue with this library but with llama.cpp:
https://github.com/ggerganov/llama.cpp/issues/2589
Can also be an issue with GGML (not sure if llama.cpp uses GGML):
https://github.com/ggerganov/ggml/issues/444
Failure Logs
No Failure.
Example environment info:
Check on the colab link

llama.cpp uses mmap so your RAM usage may be less than the model size in some cases.
This is not a llama-cpp-python issue.

@gjmulder Check the answer from the guys at llama.cpp, apparently they already have some options to allow loading the whole model into RAM.
Regardless of how memory is managed if a 7GB is using only 0.2 GB of RAM, and if every inference requires to perform operations with each and every weight on the model, that means, the software is reading the weights from disk as it needs them, and then freeing up that RAM, there is no escape to that. So that means the whole model is never loaded into RAM at the same time, which may be good for very low end devices. but if you´re trying to perform efficient inferences this is a killer.

This is an old issue, but have you tried setting use_mlock=True when initializing the model? I think that's exactly what mlock is supposed to do - keep the whole model in RAM.

Sometimes setting use_mlock=True may not have much impact, but if there is enough memory, use_mmap=False maybe can make the model fully loaded into RAM（source）


Add support for service principal login with certificates

Today we only support service principal login with secret/password. We need to support SP login with certificates as well.
For reference, you can take a look at this piece of code: https://github.com/Azure/azure-xplat-cli/blob/dev/lib/util/authentication/adalAuthForServicePrincipal.js#L55

fixed by #53

Does this support passport protected certificate ?

^+1 Same here we use password protected certs :(


tests: minor FCB re-ordering not to leave a random flash.bin behind

The last FCB test to run (fcb_test_last_of_n) uses uninitialized
test_data[] and leaves behind a flash.bin with random content. Pick
another one (fcb_test_reset) that leaves a deterministic flash.bin
behind and run that last instead.
Signed-off-by: Marc Herbert<EMAIL_ADDRESS>

The Shippable failures happened all in different, totally unrelated scheduler tests:
https://app.shippable.com/github/zephyrproject-rtos/zephyr/runs/44157/5/console
I will close/re-open later today, hopefully these glitches will be gone by then.


Support graphql.config.js

I want to share my config between projects. Can we support the JS config format?

@vjpr hi! The current plugin version uses legacy config format. We have an issue (https://github.com/jimkyndemeyer/js-graphql-intellij-plugin/issues/296) to migrate to the most recent v3 version, which supports .js config format. I think it's one of the top priorities in the next releases.


How to loadbalance on a Origin - Edge configuration?

Hello friend can you please tell me how do you do loadbalancing on a ORIGIN -> EDGE configuration?
I think better way for now is to read from HTTP API the number of connected clients and redirect to the less used server, what do you think?

Exactly right.
The origin must be a cluster which know each other, please read #464
Or, there is a more smple solution: user config the max connection on origin and redirect to next when exceed.
Origin can use RTMP 302, defined by Adobe to let edge to redirect to another origin.
About the RTMP 302, please read #369


Assertion failed while scraping a .pyd library

I have attempted to compile and test the latest version of PTVS to test the new scraping method.
Currently it throws an "Assertion failed" message when trying to load the .pyd file

I should note that I do not think its possible to load these libraries in general, they are from an API and meant to be run inside the .exe
Trying to load them from a Python cmd line gives:
# trying C:\Python34\lib\site-packages\NXOpen.pyd
Traceback (most recent call last):
 File "<stdin>", line 1, in <module>
 File "<frozen importlib._bootstrap>", line 2237, in _find_and_load
 File "<frozen importlib._bootstrap>", line 2226, in _find_and_load_unlocked
 File "<frozen importlib._bootstrap>", line 1191, in _load_unlocked
 File "<frozen importlib._bootstrap>", line 1161, in _load_backward_compatible
 File "<frozen importlib._bootstrap>", line 539, in _check_name_wrapper
 File "<frozen importlib._bootstrap>", line 1715, in load_module
 File "<frozen importlib._bootstrap>", line 321, in _call_with_frames_removed
ImportError: DLL load failed: The specified module could not be found.

Thanks for trying it out! Right now the assertion is there just to be extra noisy when scraping fails, but as it settles down we'll stop popping it up. Since you can't import the module manually either, it's obviously just one that we'll have to skip, though if you know a way to make it work (e.g. by importing another module first) you can add that into the initial_import function in scrape_module.py (like we already have for win32ui and tkinter).
Also, when you get a popup like this, you can press Ctrl+C to copy the full text of the dialog and paste it directly. There's no need to use screenshots.

Hi, thanks for the reply, sorry for the kind of dumb question, but your response did help me down the right path!
After playing with dependency walker and getting a bunch of DLLs in the same folder as the .pyd, it works!
The auto complete and function description popups are showing up perfectly.
Between this and the ability to debug in mixed mode (attaching to the .exe) PTVS is a really great tool.
Thanks for you work on this,
-Jesse