change(state): Stop re-downloading blocks that are in state queues or non-finalized side chains

Motivation
The sync task, inbound downloader, and the block verifier need to check if a block hash is present in the state to avoid redundant work and unnecessary errors. They currently call the state service with Depth requests, but this only checks if a block hash has been committed to the best chain, and returns None when the block is in a side chain or queued for validation.
This PR adds a Contains request to the state for checking if a block hash is present in any chain or state queue and uses it from sync, inbound and the block verifier instead of Depth.
Closes #862.
Solution

Add a Contains request to the state service that responds with an Option<BlockLocation>

Add and prune finalized block hashes to sent_blocks in drain_queue_and_commit_finalized
Checks if the block hash is in:

queued_non_finalized_blocks, queued_finalized_blocks, or sent_blocks
the non-finalized best chain
non-finalized side chains
finalized best chain

Call state with Contains request from sync, inbound, and block verifier to check if the block hash is in any chain or queue

Related changes:

Renames sent_non_finalized_block_hashes to sent_blocks

Review
Anyone can review.
Reviewer Checklist

[x] Will the PR name make sense to users?

[ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)

[x] Are the PR labels correct?
[x] Does the code do what the ticket and PR says?

[x] Does it change concurrent code, unsafe code, or consensus rules?

[x] How do you know it works? Does it have tests?

Oh and sorry for all the comments, I'm having a bit of trouble keeping up with the changes in this PR. (And it's a complicated part of the code, that really does need a better design eventually!)

did you want to catch up and talk it through?

Sure!

did you want to catch up and talk it through?

Sure!

Can we have an update here once you both have a catch up? :)

@teor2345 it only checks the chains now, I'll open a follow-up PR for checking the queues.

Can we have an update here once you both have a catch up? :)

We'll try merging this PR (which is low risk because it only checks for blocks that have been validated and committed), the follow-up PR that checks the queues is riskier and less important, so we'll try it if it works well without any further changes and close it otherwise.


Inconsisten number of measured qubits in IONQ device

Describe the bug
the results of an algorithm with 11 qubits (all the ones avaiable on IonQ), have an inconsistent number of measured_qubits. Some are 10 Qubits measurements, other 11.
To reproduce
The circuit we ran was simply: (Hadamard gate)
q0 : -StartVerbatim-GPi2(1.57)-GPi(0.00)-EndVerbatim-
repeated multiple times, (actually we ran it for 10,20,30,50,100 Hs) on 11 Qubits.
Trying to get the results of the task gives the following error message:
"""
braket/tasks/gate_model_quantum_task_result.py in measurements_from_measurement_probabilities(measurement_probabilities, shots)
199             )
200             measurements_list.extend(individual_measurement_list)
--> 201         return np.asarray(measurements_list, dtype=int)
202
203     @staticmethod
ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (100,) + inhomogeneous part.
"""
By looking at the "results.json" file of the task (and also inside "measurements_list" variable in the file producing the error it is clear that for some shots there are 11 measured qubits, for other ones only 10.
System information
A description of your system. Please provide:

Amazon Braket Python SDK version: 1.31.0
Amazon Braket Python Schemas version:1.10.2
Amazon Braket Python Default Simulator version:1.8.1
Python version:

results.odt

Thanks for reporting the issue @EmilioRui! We are currently looking into this and will report back with an update.

The issue should now be fixed. Please let us know if you still encounter an error while trying to run this task. Thanks!

I can confirm it is fixed.
May I know what was it? Just for my curiosity

We incorrectly processed results from IonQ for certain tasks in which all qubits were used in verbatim mode. Thanks again for reporting this issue and for your continued use of Braket.


Change recurrence

Hi all,
I have a bot who was making matches 2 times a month on a Tuesday. But now the want the bot making a match 1 time a month on a Tuesday any one knows how to add this in the logic app?

Some of app logs -
2021-05-21T07:56:35  No new trace in the past 4 min(s).
2021-05-21T07:56:39  PID[8560] Verbose     Getting "DefaultCulture" from ServiceRuntime: FAIL.
2021-05-21T07:56:39  PID[8560] Verbose     Getting "DefaultCulture" from ConfigurationManager: PASS.
2021-05-21T07:57:01  PID[8560] Verbose     SnapshotHelper::TakeSnapshotTimerCallback
2021-05-21T07:57:01  PID[8560] Verbose     SnapshotHelper::TakeSnapshotInternal - no new files in CodeGen
2021-05-21T07:57:01  PID[8560] Verbose     SnapshotHelper::TakeSnapshot time since last: 00:20:00.0225047
2021-05-21T07:58:35  No new trace in the past 1 min(s).
2021-05-21T07:59:35  No new trace in the past 2 min(s).
2021-05-21T08:00:03  PID[600] Verbose     SnapshotHelper::TakeSnapshotTimerCallback
2021-05-21T08:00:03  PID[600] Verbose     SnapshotHelper::TakeSnapshotInternal - no new files in CodeGen
2021-05-21T08:00:03  PID[600] Verbose     SnapshotHelper::TakeSnapshot time since last: 00:20:00.0365018
2021-05-21T08:01:35  No new trace in the past 1 min(s).
2021-05-21T08:01:40  PID[8560] Verbose     Getting "DefaultCulture" from ServiceRuntime: FAIL.
2021-05-21T08:01:40  PID[8560] Verbose     Getting "DefaultCulture" from ConfigurationManager: PASS.

@swapnild2111  what do you mean bij your app logs?

You can do this by going to the Logic App in the resource group in Azure and changing the trigger frequency. It's self explanatory once you start editing the Logic App. If you don't know how to get to the Logic App, ask the person in your organisation who installed the app for you into Azure.

Please refer this https://blog.thoughtstuff.co.uk/2019/07/how-to-adjust-the-pairing-schedule-of-the-icebreaker-bot-teams-app-template/


Parsing complex pdfs and outcomes

Hey there,
This thread is gonna show my expierence with LlamaParse method with and without gpt-4o argument set.
Short context: I'm trying to build RAG agent to complete user queries for natural medicines.
For now I'm parsing pdf to markdown and results are far from expected:

The senteces are sometimes alternated with different words with similar meaning, the sense is preserved but gets twisted a bit.
Despite clear instruction and several attempts to improve it, the text block starting from one page continued to another gets lost.
Headlines at the top are being read even though I instruct it not to do it.
Markdown formatting malfuntions from one page to another (you can see the plants and paragraphs on 2nd page marked differently)

Let me provide source pdf:
Encyclopedia of Herbal Medicine_part_4_p1-2_test_other_medicinal_plants.pdf
The markdown output with gpt-4o option:
Encyclopedia of Herbal Medicine_part_4_p1-2_gpt4o_other_medicinal_plants.md
The markdown output without gpt-4o:
Encyclopedia of Herbal Medicine_part_4_p1-2_test_other_medicinal_plants.md
Also the instruction for the parser:

The document is a collection of natural medicines knowledge. I want it to be parsed into markdown format by following this instruction: Omit botanical name in green rectangle at the top middle of a page. Read content from three columns; start from the left one and read to the bottom, then go to another column on the right. Some pages can start from the middle of text block from previous page so include it as it is. Ignore images, but include their captions. Save text blocks' headers with single hash mark and paragraphs' names with double hash mark. Don't include any HTML and CSS.

I'm sharing this because I hope it gets better and we eventually get a product that meets our needs. If AI is there to get a job done it at least should follow our definite instruction and not just interpret stuff for us. Please analyze for your own conclusions if you want.

I'll follow this issue, because results aren't sometimes weird with the type of complex layout PDFs I'm trying to parse. In my case I'm right now, for testing, I'm trying to parse this ttrpg manual into text. It's close though! I mean, it does a fairly decent job, but there are some issues present.
In my case I didn't sent any instructions for the parser LLM, and I'm testing without GPT4o option since it's way more cost effective.
Issues I'm noticing:

It introduces invalid characters (although not always) in place of a bullet point:
The API parameter do_not_unroll_columns="true" doesn't work on all pages. Some are unrolled, some are not.
The 'Territorial Ranger' part of the PDF (a character card is all) wrongly parsed (you can search for the term inside the uploaded .txt files and you'll see how LLMWhisperer does it well but Llamaparse struggles). There are some other places where Llamaparse struggles too.

Hopefully this serves you as a test file to make your product better, because it's a great initiative!
OUTPUT: parsedPdf_ttrpg-game_SW_Test_Drive_2020.pdf_parser-llamaparse-gpt4o-off_202407091839.txt
LLMWhisperer output (for comparison): parsedPdf_ttrpg-game_SW_Test_Drive_2020.pdf_parser-llmwhisperer_202407082018.txt


Uninstall nano

Since d65f973b7114d0eefe1aa3429c0d5042f627c996 we have not been bothered by
nano being installed on our systems. No one who is on call should need to
use nano to help them fix things anymore. Therefore we should remove nano.

See https://github.com/alphagov/govuk-puppet/pull/3972


Use 64-bit integers for OSM relation IDs in RelationMap classes.

fixes #381

As pnorman alludes to this would double the memory usage for everybody, even those who do do not have 64 bit relation IDs, so this isn't a viable solution. You'll need something more complex than this.


Docs cleanup

To try and separate the concept of contributing in the broad sense and developer docs we are removing the CONTRIBUTING.md file from the public docs and instead breaking down tech docs into smaller guides. This leaves space for a future, broader contributing guide within storybook.

Merged as discussed with @davidsauntson last week. We can do a post-merge review on this later.


It doesn't work for Windows

I don't know if this was intentional or not but I cannot open the .exe file without the message that it doesn't work on my PC

That .exe file can be only executed on ms-dos and 32 bit windows versions, because it's a 16 bit .exe file for ms-dos computers, this program has been made for that os afterall

you can run it with this:
WineVDM.zip

you can run it with this:
WineVDM.zip

if you're on modern

if you're on modern

You can use DOSBox!

Monotone is a DOS program and must be used in either real DOS, or in emulators.


Error: error:25078067:DSO support routines:win32_load:could not load the shared library

Let me start by saying I have followed all the protocols in step 1 and I neither got any replies from Stack flow, the forum nor Firebase support. I have had to work around this problem using temporary solutions, but I want to solve it once and for all.
Whenever I run Firebase admin everything works except for Firebase admin database and my app crashes with the following error when I run npm start for my node backend
internal/crypto/sig.js:110
[0]   const ret = this[kHandle].sign(data, format, type, passphrase, rsaPadding,
[0]                             ^
[0]
[0] Error: error:25078067:DSO support routines:win32_load:could not load the shared library
[0]     at Sign.sign (internal/crypto/sig.js:110:29)
[0]     at Object.sign (C:\Users\black\Documents\Programming\Acumen-Developers\Web\Highway420\node_modules\jwa\index.js:152:45)
[0]     at Object.jwsSign [as sign] (C:\Users\black\Documents\Programming\Acumen-Developers\Web\Highway420\node_modules\jws\lib\sign-stream.js:32:24)
[0]     at Object.module.exports [as sign] (C:\Users\black\Documents\Programming\Acumen-Developers\Web\Highway420\node_modules\jsonwebtoken\sign.js:204:16)
[0]     at ServiceAccountCredential.createAuthJwt_ (C:\Users\black\Documents\Programming\Acumen-Developers\Web\Highway420\node_modules\firebase-admin\lib\credential\credential-internal.js:102:20)
[0]     at ServiceAccountCredential.getAccessToken (C:\Users\black\Documents\Programming\Acumen-Developers\Web\Highway420\node_modules\firebase-admin\lib\credential\credential-internal.js:75:26)
[0]     at FirebaseAppInternals.getToken (C:\Users\black\Documents\Programming\Acumen-Developers\Web\Highway420\node_modules\firebase-admin\lib\firebase-app.js:66:73)
[0]     at FirebaseAuthTokenProvider.getToken (C:\Users\black\Documents\Programming\Acumen-Developers\Web\Highway420\node_modules\firebase-admin\node_modules\@firebase\database\dist\index.node.cjs.js:14954:27)
[0]     at PersistentConnection.establishConnection_ (C:\Users\black\Documents\Programming\Acumen-Developers\Web\Highway420\node_modules\firebase-admin\node_modules\@firebase\database\dist\index.node.cjs.js:12163:18)
[0]     at Timeout._onTimeout (C:\Users\black\Documents\Programming\Acumen-Developers\Web\Highway420\node_modules\firebase-admin\node_modules\@firebase\database\dist\index.node.cjs.js:12064:19) {
[0]   opensslErrorStack: [
[0]     'error:0E076071:configuration file routines:module_run:unknown module name',
[0]     'error:0E07506E:configuration file routines:module_load_dso:error loading dso',
[0]     'error:25070067:DSO support routines:DSO_load:could not load the shared library'
[0]   ],
[0]   library: 'DSO support routines',
[0]   function: 'win32_load',
[0]   reason: 'could not load the shared library',
[0]   code: 'ERR_OSSL_DSO_COULD_NOT_LOAD_THE_SHARED_LIBRARY'
[0] }

I don't have jsonwebtoken installed myself in my node package, so I know it is not a problem on my part. I have searched the internet and done everything from deleting node_modules and package-lock.json and reinstalling with npm install to updating all packages. It also isn't a case of my GOOGLE_APPLICATION_CREDENTIALS not being found because like is said, admin auth, admin storage work but not admin database

Operating System version: Windows 10
Firebase SDK version: 7.24.0
Firebase Product: database
Node.js version: 14.15.4
NPM version: 6.14
Thank you for your help

This is a problem with your local crypto/OpenSSL set up. Seems to be a fairly a common issue on Windows systems based on some Google search hits:
https://stackoverflow.com/questions/65689482/node-error25078067dso-support-routineswin32-loadcould-not-load-the-shared-l
https://github.com/nodejs/help/issues/848 (somewhat old, but seems to be the same issue)
https://www.gitmemory.com/issue/OpenSC/libp11/298/526593658
I'll assign to the RTDB team to see if they have seen anything like this before. But I'd also advise you to check with Windows and OpenSSL communities for more specific instructions.

I upgraded to Node 16.16.0 and it works.
Perhaps related to this issue. https://github.com/nodejs/node/discussions/43184#discussioncomment-3107873

You can check for OpenSSL version to your NodeJS version compatibility here

@ishowta  Thank you, It works for me too.


Make JsonPropertyAttribute allow multiple usages on same property

Hi,
I need to deserialize a series of documents that are almost similar but might change few details.
I was hoping to spare myself the need of creating multiple classes by decorating the same target property with more instances of the JsonPropertyAttribute but this is not possible.
Ideally it would be nice to be able to do something like
public class ResultList<T>
{
	[JsonProperty("items")]
	[JsonProperty("values")]
	[JsonProperty("results")]
	public IReadOnlyList<T> Items { get; set; }

	[JsonProperty("hasMore")]
	[JsonProperty("has-more")]
	public bool HasMore { get; set; }

	[JsonProperty("offset")]
	public long? Offset { get; set; }
}

Since most of the time this happens when deserializing a result list, the ambiguity introduced when serializing wouldn't a big issue. In that case, picking the value of the first attribute found would be good enough.

A simple solution which does not require a converter: just add a second, private property to your class, mark it with [JsonProperty("name2")], and have it set the first property:
public class Specifications
{
[JsonProperty("name1")]
public string CodeModel { get; set; }
[JsonProperty("name2")]
private string CodeModel2 { set { CodeModel = value; } }

}
Ref
https://stackoverflow.com/questions/43714050/multiple-jsonproperty-name-assigned-to-single-property

Been able to use something like this [JsonProperty("name1", "name2")] would be nice. I do this when I'm working with CsvHelper which allows me to set multiple columns to the same attribute [Name("column1", "column2")]

Since most of the time this happens when deserializing a result list, the ambiguity introduced when serializing wouldn't a big issue.

What are these assumptions based on?

Like Golang, that uses same field, but for json serializing uses on name, and for database uses other.
//IDValue - type IDValue struct { 	Identificator    int     db:"id"       json:"identificator" 	MoneyValue       float32 db:"numValue" json:"moneyValue" }
It would be nice to set a custom serialization based on purpose, other than creating new private fields or a clone class with JsonProperty values, and mapping then with Automapper
Example:
[JsonProperty("name1", "cache:name2")]
When serialize/deserialize default, use 'name1', for cache, use 'name2'. When serializing a big list with big names, it takes more than 50% of cache size

We could have an attribute called JsonAlias to do this.
The JsonProperty is still allowed to be used once, and will be used for serialization. However, we can have multiple JsonAlias attributes which would map to the variable when deserializing.
We then would get something like:
public class ResultList<T>
{
	[JsonProperty("items")]
	[JsonAlias("values")]
	[JsonAlias("results")]
	public IReadOnlyList<T> Items { get; set; }

	[JsonProperty("hasMore")]
	[JsonAlias("has-more")]
	public bool HasMore { get; set; }

	[JsonProperty("offset")]
	public long? Offset { get; set; }
}

This idea is taken from here:
https://stackoverflow.com/a/70781282/7568866

I would personally need this feature for:
[JsonProperty("hasData")]
[JsonAlias("has-data")]
[JsonAlias("has_data")]

or
[JsonProperty("hasData", "has-data", "has_data")]

And you can throw an Exception if variants of the name are available in the same object.


Set workspace resolver to version 2

Codecov Report

Merging #32 (cef694e) into main (81a4e5c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   87.23%   87.23%
=======================================
  Files           7        7
  Lines         478      478
=======================================
  Hits          417      417
  Misses         61       61


update submodules

Time spent on this PR:
Resolves: #
Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Testing

What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[ ] No

should we close this in favor of https://github.com/kkrt-labs/kakarot/pull/1200 ?

should we close this in favor of kkrt-labs/kakarot#1200 ?

Yes closing this


PENV-520: mem leak fix

- What I did
fixed the memory leak.
the problem was when we  didn't close gRPC stream and GC don't free the used memuary by goroutine
- How I did it
close streams
- How to verify it
with profiling on the stand
- Description for the changelog

Codecov Report

Merging #143 into master will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
- Coverage   74.15%   74.11%   -0.05%
==========================================
  Files          48       48
  Lines        3363     3365       +2
==========================================
  Hits         2494     2494
- Misses        720      722       +2
  Partials      149      149

Impacted Files
Coverage Δ

etl/extractor/platform_impl.go
75.21% <0.00%> (-1.31%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b711b7...e3ed1e6. Read the comment docs.


ci: don't compress using UPX for PRs

Save some CI time.

I have ~40+ amd64 cores sitting idle that I'd be happy to donate; and can be done in an afternoon, for self-hosted runners. That could potentially speed up builds quite a bit since each dedicated server machine has ~12 cores on it vs. the github hosted runners with only 4 cores. I use these machines for building code on my org (bottledcode), and are idle most of the time.

That would be awesome.


if a config file has .override appended to its name, it will override…

… and overwrite any existing config file
supersedes https://github.com/jenkinsci/docker/pull/184

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

thanks, FYI you can push to the same branch and the PR gets updated, no need to create a new one


Token API call failure returning stack trace with details from DB

Description:
In APIM 3.2.0 update level 153 when we invoke the Token API call when the Database is down we are getting a proper error message as below
Response to the client :

{
    "error_description": "Internal Server Error.",
    "error": "server_error"
}

But after around 15 min  if we invoke the same Token API call while the Database is down we are getting the below response from the APIM to the client
<ns1:XMLFault xmlns:ns1="http://cxf.apache.org/bindings/xformat"><ns1:faultstring xmlns:ns1="http://cxf.apache.org/bindings/xformat">org.wso2.carbon.identity.base.IdentityRuntimeException: com.mysql.cj.jdbc.exceptions.CommunicationsException: Communications link failure

The last packet sent successfully to the server was 0 milliseconds ago. The driver has not received any packets from the server.</ns1:faultstring></ns1:XMLFault>

As you can see in the above response the database information(host, port) and the JDBC error is given as the response to the client.
Steps to reproduce:
1.Get a WSO2 APIM 3.2.0 updated pack
2.Change the defualt database of APIM 3.2.0 to any RDBMS database [1]
3.Create an API
4.Subscribe to that API and invoke the Token API call
curl --location --request POST 'https://localhost:8243/token' \
--header 'Authorization: Basic VFJZTjFnVkJycGFDa3N4ckl0RHJBR0VXamhFYTozRUdENEVpTWlhVmxLYWpMTDBfWkN0V2RWeVVh' \
--header 'Content-Type: application/x-www-form-urlencoded' \
--data-urlencode 'grant_type=password' \
--data-urlencode 'username=admin' \
--data-urlencode 'password=admin'

you will see access token, refresh token information as the response.
5. Now shutdown the RDBMS database
6. invoke the token API call
curl --location --request POST 'https://localhost:8243/token' \
--header 'Authorization: Basic VFJZTjFnVkJycGFDa3N4ckl0RHJBR0VXamhFYTozRUdENEVpTWlhVmxLYWpMTDBfWkN0V2RWeVVh' \
--header 'Content-Type: application/x-www-form-urlencoded' \
--data-urlencode 'grant_type=password' \
--data-urlencode 'username=admin' \
--data-urlencode 'password=admin'

you will see the below response
{
    "error_description": "Internal Server Error.",
    "error": "server_error"
}

Now wait for 15 min and try the same, now you will see the below response not the internal server error

<ns1:XMLFault xmlns:ns1="http://cxf.apache.org/bindings/xformat"><ns1:faultstring xmlns:ns1="http://cxf.apache.org/bindings/xformat">org.wso2.carbon.identity.base.IdentityRuntimeException: com.mysql.cj.jdbc.exceptions.CommunicationsException: Communications link failure

The last packet sent successfully to the server was 0 milliseconds ago. The driver has not received any packets from the server.</ns1:faultstring></ns1:XMLFault>

Affected product version:

Affected component:

Environment details (with versions):

OS:
Client:
Env (Docker/K8s):

Optional fields
Related issues:

Suggested labels:

Suggested assignees:

@dushaniw / @isurul28 Any Updates on this?


fix(sentry-FLAGSMITH-API-4BN): update permission method

Thanks for submitting a PR! Please check the boxes below:

[x] I have run pre-commit to check linting
[ ] I have added information to docs/ if required so people know about the feature!
[x] I have filled in the "Changes" section below?
[x] I have filled in the "How did you test this code" section below?
[x] I have used a Conventional Commit title for this Pull Request

Changes
Update get_permitted_environments on APIKeyUser to add support for prefetch_metadata
Fixes:  FLAGSMITH-API-4BN
How did you test this code?

Adds/updates unit tests

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.97%. Comparing base (609deaa) to head (23b6bde).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3851   +/-   ##
=======================================
  Coverage   95.96%   95.97%
=======================================
  Files        1129     1129
  Lines       35816    35846   +30
=======================================
+ Hits        34371    34402   +31
+ Misses       1445     1444    -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[c2][store] Fixed some cts failures caused by monitor

case: android.media.decoder.cts.AdaptivePlaybackTest#test_adaptiveReconfigDrc
In some cases, codec will do start and stop many times even for one codec instance,
then it leads to exceed maximum codec instance number.
Moving to constructructor/desctructor can resolve the problem.
Tracked-On: OAM-118206

Please give detailed explain the root cause why previous code is not correct in commit message.

In previous commit, I had add a feature that is we can configure the concurrent-instances number and limits the max components we can create. Once over this number, we return a NO_MEMORY error to framework, and framework will check this process if it is a high or low priority process, if high, they will reclaim the resource and still keep creating this coomponent, if low, they will ignore   to create it. And I have to create a monitor class to count the created components number, and I can compare this number with the configured number. Ok, this is about previous commit what it do.
The root cause is the timing of count, in previous, I do it in start() function because I didn't think too much about it just for reclaiming the resource(you can see the comment in previous commit about this detail). But in this case, the codec will do start and stop many times after created. It will trigger the counter over max limit to return NO_MEMORY to fw. So I moved the count to constructor and destructor, that is very simple problem.

Updated commit message.

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web  for more details. For Binaries: /cactus-absp-or-local/celadon-merge/462


[AutoPR sql/resource-manager] Add new APIs (two List APIs) and update examples

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6640

(message created by the CI based on PR content)


Move Hardening guides out of concepts section

Regarding this comment https://github.com/kubernetes/website/pull/45080#discussion_r1751203955, we should consider moving security hardening guides out of concepts. It cannot be moved to references either. Should we move it to a new section?

/sig security

Out of all the sections we have, the concepts section feels like the least bad home.

it's explaining what you might need to consider to secure your cluster
it is not task documentation where following it unquestioningly produces a specific outcome
it is not really a tutorial or a setup guide
it is not reference documentation

@sftim what are your thoughts about moving them to docs/setup/best-practices https://kubernetes.io/docs/setup/best-practices/ ?

@sftim what are your thoughts about moving them to docs/setup/best-practices https://kubernetes.io/docs/setup/best-practices/ ?

We shouldn't move them to a section about good practice for large clusters. Even small clusters may need to have strong information security.

That section is not specific for large clusters 🤔 . For example since we already have Enforcing pod security standards, maybe the hardening guides could also be alongside this doc

Ah, I was wrong! Maybe that is OK then.

The content of the page fits into the best practices folder.
content/en/docs/setup/best-practices
For example, all sub-sections in the section "kube-scheduler configuration" describe some best practices while using those command line options.


Make sure there is at least a header in the frame storge of H2.

grpc_chttp2_maybe_complete_recv_trailing_metadata() moves at
least GRPC_HEADER_SIZE_IN_BYTES from the frame storage, whenever
the frame storage is non-empty.
Instead ensure that we have at least GRPC_HEADER_SIZE_IN_BYTES
in the frame storage.
This results in bugs detected by clusterfuzz in chrome:
https://bugs.chromium.org/p/chromium/issues/detail?id=984534
https://bugs.chromium.org/p/chromium/issues/detail?id=984478#c2

grpc_chttp2_maybe_complete_recv_trailing_metadata() moves at
least GRPC_HEADER_SIZE_IN_BYTES from the frame storage

Any reference to this claim?

@muxi updated the PR message with two references inside the if-block modified in this PR.

This change is purely internal to chttp2, so I'll let @yashykt review.

L2032-2035 limits the upper bound of output bytes rather than lower bound of input, so I am so surprised if it actually has to consume GRPC_HEADER_SIZE_IN_BYTES bytes.
For L2019-2021, yes that is a bug. Instead of waiting for GRPC_HEADER_SIZE_IN_BYTES bytes, I think it's probably better to change L2020 to min(GRPC_HEADER_SIZE_IN_BYTES, s->frame_storage.length).

Thank you @muxi ! That's a great idea. Updated the patch.

Thank you @muxi  for the suggestion!

Thank you @yashykt !

Existing issue #19422


Stable only when Debugger is open

Hi Guys!
First, thank you very much for your contribution.
I'm failing to use this since this won't work stable at all. Looks like, for some reason, the MutationObserver are not waiting for rendering.
Weird enough, this work flawlessly when Debugger is opened.
Tested an replicated on FF and Chrome.

Working with dev-tools open suggests a cache issue.

How did you install, HACS or Manually?
What options are you trying to use and how are you using them?
If you're installing manually are you grabbing the file from the releases page and increasing the version number in your resources?

Also, if you keep your dev-tools closed and it fails to work and then you open your dev-tools console are there any errors pertaining to kiosk-mode?

Again - thank you for the response.

Installation from HACS - using latest.
Using '?kiosk' (e.g. http://local:8123/lovelace/0?kiosk)
Happening on other devices as well.
Clean cache - fix the issue for One refresh only.

Before - Clean Cache:

Clean Cache:

Reload:

Does the same issue occur if you delete the gz file in /config/local/community/kiosk-mode and then replace the non-gz file with the uncompressed version here?

I've tried and getting
Uncaught TypeError: Cannot read property 'config' of undefined
at getConfig (kiosk-mode.js:8)
at kiosk_mode (kiosk-mode.js:48)
at kiosk-mode.js:88
main.querySelector("ha-panel-lovelace") is undefined :(

Do you use v0.117?

Yes, using 0.117.0

Seems like a strange race condition. Not only are you having issues with hui-root not existing when it should, but even stranger is the face that the lovelace panel wouldn't exist after this resource is loaded. You doing some pretty heavy customization?
As much as I hate timeouts, I added some to my latest commit. See if it helps, replace the js file like you did before with the one I just added commits to: https://raw.githubusercontent.com/maykar/kiosk-mode/master/kiosk-mode.js

On lines 85 and 114 are the two millisecond values for the timeouts. The one on 85 is for kiosk mode's run and the one on 114 is for the observer that waits to run when hui-root appears.
If you're still having issues after trying with the values that are there you can try increasing them to see if it helps.

Yes, using quite heavy UI extension, and running on a poor RPi3.
Will use some timeout for the kiosk_mode().
When I first read the code I was sure that you guys are monitoring using MutationObserver... Will try to optimize this later on this night. Thanks.

On first run there's really no need for a mutation observer as all those elements "should" exist before this is even loaded.  After that I add mutation observers to watch for dashboard changes as the script needs to rerun when you navigate to a new dashboard.

Your system seems to even have trouble with the mutation observer as well, though. As before I added the timeouts the observer watches for hui-root to appear and watches for elements to appear in it's shadowRoot, but on your system the element's shadowRoot doesn't appear in time for that observer to be added.
Again, strange race condition.

Yep, the timeout is not good enough, will need to find a good explanation.
Will close this, as this is probably related to my HASS.


@OnNeverAskAgain not being called

Annotating a method with @OnNeverAskAgain is not called. What is called is the method annotated with @OnPermissionDenied.
I think the generated code conditions checks are incorrect.
static void onRequestPermissionsResult(BaseActivity target, int requestCode, int[] grantResults) {
    switch (requestCode) {
      case REQUEST_INITIALIZESCANNING:
      // this would always be true if the permission was denied and on never ask again
      if (!PermissionUtils.hasSelfPermissions(target, PERMISSION_INITIALIZESCANNING)) {
        target.showDenied();
        return;
      }
      if (PermissionUtils.verifyPermissions(grantResults)) {
        target.initializeScanning();
      } else {
        if (!PermissionUtils.shouldShowRequestPermissionRationale(target, PERMISSION_INITIALIZESCANNING)) {
          target.showNeverAsk(); // this is NEVER called
        } else {
          target.showDenied();
        }
      }
      break;
      default:
      break;
    }
  }

Thanks. Great work BTW.

@emarc-m Ah, could u use 2.0.2 for the time being? It might works well. So sorry!

@hotchemi Thanks for that info.

It's time to add functional tests.

Right code is bellow.
static void onRequestPermissionsResult(BaseActivity target, int requestCode, int[] grantResults) {
    switch (requestCode) {
      case REQUEST_INITIALIZESCANNING:
      // this would always be true if the permission was denied and on never ask again
+     if (Build.VERSION. SDK_INT < 23 && !PermissionUtils.hasSelfPermissions(target, PERMISSION_INITIALIZESCANNING)) {
        target.showDenied();
        return;
      }
      if (PermissionUtils.verifyPermissions(grantResults)) {
        target.initializeScanning();
      } else {
        if (!PermissionUtils.shouldShowRequestPermissionRationale(target, PERMISSION_INITIALIZESCANNING)) {
          target.showNeverAsk(); // this is NEVER called
        } else {
          target.showDenied();
        }
      }
      break;
      default:
      break;
    }
  }

@shiraji Might be the good idea but it takes a bunch of costs...worrisome problem.

Wait, I think there is one more problem. PermissionDispatcher must take care of SYSTEM_ALERT_WINDOW and WRITE_SETTINGS.
This test case is not correct. Should be following:
if (!Settings.System.canWrite(target))

This line should check if it is in ADD_WITH_CHECK_BODY_MAP
We need to refactor fun addHasSelfPermissionsCondition(builder: MethodSpec.Builder, activityVar: String) as well in order to take care of this one.
Do you want me to send pull request for this?

@shiraji Umm, actually this line is just workaround for under M devices. See https://github.com/hotchemi/PermissionsDispatcher/issues/45#issuecomment-160058769 .
I'm not sure the same thing happens in SYSTEM_ALERT_WINDOW and WRITE_SETTINGS.
So, we should delete this line when exceptional permissions case.

Do you want me to send pull request for this?
Sure!

So, we should delete this line when exceptional permissions case.

That makes life easier!

@emarc-m Just released 2.0.4. Really appreciated for your report.

@hotchemi Thanks for the support.


Fix tests for gslib miniapps

This PR address #2940.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#2945
@kmittal2
@tzanio
@psocratis + @v-dobrev
3/30/22
⌛due 4/13/22
⌛due 4/20/22

PR Checklist

[x] Code builds.
[x] Code passes make style.

Quick question: This PR is primarily about adding tests to the gslib miniapps and not about fixing lingering bugs, right?

Quick question: This PR is primarily about adding tests to the gslib miniapps and not about fixing lingering bugs, right?

Quick question: This PR is primarily about adding tests to the gslib miniapps and not about fixing lingering bugs, right?

Hi @termi-official, yes the purpose of this PR is to add tests to the gslib miniapps. Can you please elaborate on what lingering bugs you are talking about?

Thanks for the quick response @kmittal2 !
I do not have a minimum working example at hand - Basically I run into issues that the "field-interp" miniapp messes up the transfer of L2 and H1 grid functions, at least on some of my meshes. I have it on my todo list to put together a detailed bug report, but I cannot find the time ATM to track down what goes wrong. I will try to put something together about mid may.
Regarding the changes: They look good to me.

Sounds good @termi-official. Please open an issue as soon as you get a chance.

@v-dobrev and @termi-official, can I get another review of this PR?

@v-dobrev, I double checked the gslib tests. All look ok now.
GSLIB miniapp [ mpirun -np 4 pfindpts ... ]: OK  (1.04s 18464kB)
GSLIB miniapp [ mpirun -np 4 schwarz_ex1p ... ]: OK  (1.23s 18508kB)
GSLIB miniapp [ findpts ... ]: OK  (0.96s 11056kB)
GSLIB miniapp [ field-diff ... ]: OK  (0.93s 15420kB)
GSLIB miniapp [ field-interp ... ]: OK  (1.00s 10880kB)
GSLIB miniapp [ schwarz_ex1 ... ]: OK  (1.01s 11812kB)

Tests are broken on my side due to a bug in Catch2 (see https://github.com/catchorg/Catch2/issues/2178).
I was able to resolve the issue locally by replacing the single header in the test folder with the latest single header version (i.e. https://raw.githubusercontent.com/catchorg/Catch2/v2.x/single_include/catch2/catch.hpp). Could you update the Catch2 dependency to a newer version?

☝ ping: @pazner

Merged in next for testing...


Second, third and fourth level domains

We can possible enhance internet provider to be able to generate fake domains like:

test.wemake.services
mail.google.com
app.test.example.com
example.co.uk
And others.

Link: https://en.wikipedia.org/wiki/Domain_name#Second-level_and_lower_level_domains

I'm all for it. I'll try work on it when I'll not busy.

Hi, can I have a go at this if nobody else is working on it already?

Perfect, thanks @lk-geimfari. I will attempt issue 484 first, but if nobody else has started to work on this by then I will try it.

@sadielbartholomew Great! Thank you!

I've now had time to start implementing this; I'm working on it in this branch. Once it is complete, tested & documented I will put in a PR. Thanks again.

@sadielbartholomew Great news! Thank you for your time and for your interest! We'll wait for your PR.

@sadielbartholomew 🏓

Sorry @lk-geimfari I am a bit busy at the moment but will get back onto this at the weekend. If I can't otherwise sort it I will post here so somebody else can take over (or do it their way).

@sadielbartholomew Sure! Thanks!

Update: I am committed to completing this, but I am short for time so it will likely be mid-week before I can put in the corresponding PR. I will ensure I get it submitted before next Monday, however. Thanks for your patience.

@sadielbartholomew no pressure! Take your time.

Hi, can I go for it if nobody else is working on it?
One thing I should only update the top_level_domain function, not the function which generates homepage right ??

@hvijaycse Feel free to work on it.

I'd love to give this a shot if no one else is currently working on it.

@terciero It would be great! Thank you!

Perfect! I'll pick up from the branch that @sadielbartholomew started.

Great! Thank you!

Slightly delayed by holidays, but still working on this!

@terciero 🏓

Have been away from an internet connection, but will be back on this
starting Monday.
If that is too much of a delay someone else can snag the issue.
On Fri, Jan 3, 2020, 2:36 PM Líkið Geimfari<EMAIL_ADDRESS>wrote:

@terciero https://github.com/terciero 🏓
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lk-geimfari/mimesis/issues/466?email_source=notifications&email_token=ACRUDSO7YFL36O7SRHV7PHDQ364YFA5CNFSM4FFJVKUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEICHXHQ#issuecomment-570719134,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACRUDSOONHAKA6R2B4Y3O2DQ364YFANCNFSM4FFJVKUA
.

This can be done, like this:
from mimesis import Internet

net = Internet()

net.hostname(subdomains=['one.two', 'one.two.tree'])

# Output: one.two.tree.marine.gov


Add whitelistPatternsChildren to config options

Proposed changes
Add whitelistPatternsChildren to config options. See https://www.purgecss.com/whitelisting#patterns
Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

Awesome! thanks for this


softmax fails with padded tile layout

The softmax in tt-lib will fail if the tensor is in tile layout with a shape of 8,2,2 padded to 8,32,32 using a padded value of zero instead of -inf.
We have a workaround, at the moment we fallback to moreh softmax in core.py with:
is_padded_and_using_tile = (
        input_tensor.layout == TILE_LAYOUT and list(input_tensor.shape)[-2:] != list(input_tensor.shape.padded())[-2:]
    )

Here is a sample test from ttnn
@skip_for_wormhole_b0()
def test_softmax_with_padded_tile_layout(device):
    torch.manual_seed(0)
    torch_input_tensor = torch_random((8, 2, 2), -10, 10, dtype=torch.bfloat16)
    torch_output_tensor = F.softmax(torch_input_tensor, dim=-1, dtype=torch.bfloat16)
    input_tensor = ttnn.from_torch(torch_input_tensor)
    input_tensor = ttnn.to_layout(input_tensor, ttnn.TILE_LAYOUT)
    input_tensor = ttnn.to_device(input_tensor, device)
    output_tensor = ttnn.softmax(input_tensor, dim=-1)
    output_tensor = ttnn.to_layout(output_tensor, ttnn.ROW_MAJOR_LAYOUT)
    output_tensor = ttnn.from_device(output_tensor)
    output_tensor = ttnn.to_torch(output_tensor)

    assert_with_pcc(torch_output_tensor, output_tensor, 0.997)

The issue here is that most ttl ops do not understand/check for padded shapes. They interpret the passed in data as if that were the true shape as a lot of these ops were written before padded shape was supported/widespread.
So if you pass in [8, 2, 2] in RM, the ttl softmax would pad internally and run, but when you pass in a padded [8, 32, 32], it interprets the 32 as the actual width.
We haven't gone back to update most ops to understand padded/true shapes after this was added, so this issue will mostly pop up on ops that do normalizing/computations on dims like ln, sm, etc.

how should we add the support for padded shapes? I guess can we need to get the unpadded shape, and calculate the scalers on host

@eyonland @yugaoTT , What's the status of this issue?
We use a padded tile layout input on softmax and we're seeing wrong softmax (last dim) output if the input in sharded. Specifically the issue seems to be when the sharding is by height.
I wrote a small-ish test using similar sizes of our model showcasing the issue.
The shard config I'm using is the following:
    shard_config = ttnn.create_sharded_memory_config(
        shape=(1024, 32),
        # shape=(32, 32),
        core_grid=ttnn.CoreGrid(y=4, x=8),
        strategy=ttnn.ShardStrategy.WIDTH,
        # strategy=ttnn.ShardStrategy.HEIGHT,
        orientation=ttnn.ShardOrientation.ROW_MAJOR,
        use_height_and_width_as_shard_shape=True,
    )

The tensor to be sharded is of shape [1,32,32,32].
If sharding by height, with shape (32,32) we're seeing bad PCC below. However, if sharding by Width instead with shape (1024, 32) PCC will be correct, when compared to interleaved approach.
After sharding, we slice the input input = input[:, :, :, :i+1] resulted in padded tile layout and then feed this into softmax.
import torch
import pytest
from loguru import logger

import ttnn
from models.utility_functions import comp_pcc

def test_softmax(device, use_program_cache, reset_seeds):
    iterations = 3

    pt_input = (torch.rand(1,32, 32, 32))
    tt_input_il = ttnn.from_torch(pt_input, dtype=ttnn.bfloat16, device=device, layout= ttnn.TILE_LAYOUT, memory_config=ttnn.L1_MEMORY_CONFIG)
    tt_input_sharded =  ttnn.from_torch(pt_input, dtype=ttnn.bfloat16, device=device, layout= ttnn.TILE_LAYOUT, memory_config=ttnn.L1_MEMORY_CONFIG)

    shard_config = ttnn.create_sharded_memory_config(
        shape=(1024, 32),
        # shape=(32, 32),
        core_grid=ttnn.CoreGrid(y=4, x=8),
        strategy=ttnn.ShardStrategy.WIDTH,
        # strategy=ttnn.ShardStrategy.HEIGHT,
        orientation=ttnn.ShardOrientation.ROW_MAJOR,
        use_height_and_width_as_shard_shape=True,
    )

    # Interleaved
    for i in range(iterations):
        tt_input_il = tt_input_il[:, :, :, :i+1]
        soft_il = ttnn.softmax(tt_input_il, dim=-1)

    # Sharded
    tt_input_sharded = ttnn.to_memory_config(tt_input_sharded, memory_config=shard_config)
    for i in range(iterations):
        tt_input_sharded = tt_input_sharded[:, :, :, :i+1]
        soft_shard = ttnn.softmax(tt_input_sharded, dim=-1)

    passing, pcc_message = comp_pcc(ttnn.to_torch(soft_il), ttnn.to_torch(soft_shard))
    assert passing, f"PCC = {pcc_message}"

we support padding in interleaved softmax now, not sharded currently. but your case does not requires padding. height sharding should be the correct way to do it, if you want your workload to spread to 32 cores.

see a relavant test here,
`
@pytest.mark.parametrize(
"in0_mem_config",
(ttl.tensor.MemoryConfig(ttl.tensor.TensorMemoryLayout.INTERLEAVED, ttl.tensor.BufferType.DRAM),),
ids=[
"in0_DRAM",
],
)
@pytest.mark.parametrize(
"in_dtype",
(
ttl.tensor.DataType.BFLOAT8_B,
),
ids=["BFLOAT8_B"],
)
def test_softmax(device, in_dtype, in0_mem_config):
torch.manual_seed(0)
sm_op =  ttl.operations.primary.softmax_in_place
grid_size = [8, 4]
input_shape = (1, 32, 32, 32)

input_tensor = torch.randn(input_shape).bfloat16().float()
in1_t = torch2tt_tensor(input_tensor, device, tt_memory_config=in0_mem_config, tt_dtype=in_dtype)
in1_t_shard = ttl.tensor.interleaved_to_sharded(
    in1_t,
    grid_size,
    [32, 32],
    ttl.tensor.TensorMemoryLayout.HEIGHT_SHARDED,
    ttl.tensor.ShardOrientation.ROW_MAJOR,
)

program_config = ttl.operations.primary.transformers.SoftmaxShardedMultiCoreProgramConfig(
    compute_with_storage_grid_size=grid_size,
    subblock_w=1,
    block_h=1,
    block_w=1,
)

tt_output_sharded = sm_op(
    in1_t_shard, program_config=program_config
)

tt_output = ttl.tensor.sharded_to_interleaved(tt_output_sharded, in0_mem_config)
tt_output_tensor = tt_output.cpu().to_torch().float()
tt_output_tensor = torch.Tensor(tt_output_tensor).reshape(input_shape)
tt_output_tensor = untilize(tt_output_tensor)

golden_output_tensor = torch.softmax(input_tensor, dim=-1)

allclose, output = comp_pcc(
    tt_output_tensor,
    golden_output_tensor,
)
logger.info(output)
assert allclose, f"FAILED: {output}"`

we support padding in interleaved softmax now, not sharded currently. but your case does not requires padding. height sharding should be the correct way to do it, if you want your workload to spread to 32 cores.

Thank you for the update!
In our case we do padding since we don't have an attention mask.


⚠ Bofrost.at has degraded performance

In d0d4c8b, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1549 ms

Resolved: Bofrost.at performance has improved in 032201b after 6 minutes.


Fix crash in res.send()

In commit c6fa25985b078ce0ba27da50d1d8676d3e18fe30, "var" usage
was replaced with const. The code previously worked because "var"
has function scoping unlike const which has block scoping.
TypeError: Cannot read property 'attributes' of null

The backtrace we got is
2020-12-01T17:39:21.517Z box:ldap TypeError: Cannot read property 'attributes' of null
    at /home/yellowtent/box/node_modules/ldapjs/lib/messages/search_response.js:100:12
    at Array.forEach (<anonymous>)
    at SearchResponse.send (/home/yellowtent/box/node_modules/ldapjs/lib/messages/search_response.js:99:29)
    at /home/yellowtent/box/src/ldap.js:113:17
    at Array.forEach (<anonymous>)
    at finalSend (/home/yellowtent/box/src/ldap.js:112:17)
    at /home/yellowtent/box/src/ldap.js:370:17
    at /home/yellowtent/box/node_modules/async/dist/async.js:473:16
    at replenish (/home/yellowtent/box/node_modules/async/dist/async.js:1006:25)
    at iterateeCallback (/home/yellowtent/box/node_modules/async/dist/async.js:995:17) %s failure to write message %j <IP_ADDRESS>:57498 { messageID: 1075,
  protocolOp: 'LDAPResult',
  status: 0,
  matchedDN: '',
  errorMessage: '',
  referrals: [],
  controls: [] }

I wonder if there are more cases of variable shadowing gone wrong. We should add a rule to the linter to prevent this.

This is what I was afraid of in https://github.com/ldapjs/node-ldapjs/pull/674.

I did a search with eslint and only found this shadowing to be a problem. I would prefer to move to eslint and use eslint-config-standard instead of using standard so we can add the no-shadow rule.
During that search I also found that the callback on getEntryChangeNotificationControl is never used. I'm not sure if that is a problem.
https://github.com/ldapjs/node-ldapjs/blob/da358a814c6001831807159f825e5ed877dbf899/lib/persistent_search.js#L80-L96

I would prefer to move to eslint and use eslint-config-standard instead of using standard so we can add the no-shadow rule.

🤔 the point of using standard though is that we shouldn't have to keep playing the "update rules" game. We can discuss in a separate issue.

During that search I also found that the callback on getEntryChangeNotificationControl is never used. I'm not sure if that is a problem.

I don't know if it is, but I'd just leave it. One day someone will work up the constitution to clean this whole mess up and these things will get resolved.

⚠ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.
Please include a minimal reproducible example
when opening a new issue.


.abort() not working properly when running deno task

Ran into a problem on a production pup instance running a web server using command deno task prod. Once started, the server cannot be killed programatically. Pup uses dax internally.
The problem is solved by starting the server using command deno run instead of deno task.
When aborting deno task prod using CTRL+C at the command line, everything works as it should.
Complete repro at https://github.com/Hexagon/dax-issue-146
Repro steps
Running deno run -A main.ts directly using dax works fine
# First start - all good,
> deno run -A works.ts
Listening...
... aborted with exit code 124

# Second start - all good
> deno run -A works.ts
Listening...
... aborted with exit code 124

Running deno task prod using dax seem to leave the actual deno process hanging
# First start - all good, running deno task prod using dax
> deno run -A failure.ts
Listening...
... aborted with exit code 124

# Second start - the server from the first start is still listening on the port, even though everything see fine?
> deno run -A failure.ts
AddrInUse: Address already in use
... aborted with exit code 124

Code for repro
deno.json
{
    "tasks": {
        "prod": "deno run -A main.ts"
    }
}

main.ts
const server = Deno.listen({ port: 8083 });
console.log(`HTTP webserver running.  Access it at:  http://localhost:8080/`);

/* ... the rest of the example server imlementation */

works.ts
import $ from "https://deno.land/x/dax/mod.ts";

const child = $`deno run -A main.ts`.spawn();

// abort the child after 3s
await $.sleep("1s");
child.abort();

await child; // Error: Aborted with exit code: 124

failure.ts
import $ from "https://deno.land/x/dax/mod.ts";

const child = $`deno task prod`.spawn();

// abort the child after 3s
await $.sleep("1s");
child.abort();

await child; // Error: Aborted with exit code: 124

I can't reproduce on linux, I can run failure.ts many times without error

Are you sure? The reproduction code fail on both a physical linux machine and codespaces for me.
Codespaces:
deno 1.34.1 (release, x86_64-unknown-linux-gnu)
v8 <IP_ADDRESS>
typescript 5.0.4

Local:
deno 1.33.4 (release, x86_64-unknown-linux-gnu)
v8 <IP_ADDRESS>
typescript 5.0.4

I made a repo out of it to keep it simple
https://github.com/Hexagon/dax-issue-146

yeah the repo you linked also work
but funny thing I found, turns out deno lsp listen to port 8084 by default, so that might be the issue ? can you try using a different port ?

or maybe no, let me pr some fixes to that repo, so we can test there more

Can you try here https://github.com/sigmaSd/dax-issue-146 (this makes sure that dax have the latest version)
and can you kill -9 deno before starting just for sanity check

Aaah, your version work fine. But it is because the server exit gracefully before dax tries to kill the process, if I add the server code to your version, it starts failing again (because the process is kept alive until it's killed by dax).

// Connections to the server will be yielded up as an async iterable.
for await (const conn of server) {
    // In order to not be blocking, we need to handle each connection individually
    // without awaiting the function
    serveHttp(conn);
  }

  async function serveHttp(conn: Deno.Conn) {
    // This "upgrades" a network connection into an HTTP connection.
    const httpConn = Deno.serveHttp(conn);
    // Each request sent over the HTTP connection will be yielded as an async
    // iterator from the HTTP connection.
    for await (const requestEvent of httpConn) {
      // The native HTTP server uses the web standard `Request` and `Response`
      // objects.
      const body = `Your user-agent is:\n\n${
        requestEvent.request.headers.get("user-agent") ?? "Unknown"
      }`;
      // The requestEvent's `.respondWith()` method is how we send the response
      // back to the client.
      requestEvent.respondWith(
        new Response(body, {
          status: 200,
        }),
      );
    }
  }

I see,  this is an issue with abortcontroller , here is a minimal example, I think you should close this issue and open one against deno repo
const control = new AbortController();
const child = new Deno.Command("deno", {
  // args: ["run","-A", "main.ts"], // works
  args: ["task", "prod"], // fails
  signal: control.signal,
}).spawn();

await new Promise((r) => setTimeout(r, 1000));
control.abort();

await child.status;

or maybe its an issue with how deno task works

actually here is the issue already https://github.com/denoland/deno/issues/18445

Ooh, cool. Thanks for checking it up :100:

Should work now with Deno 2.1.3 which was released earlier today


[Broker] Fixed wrong behaviour caused by not cleaning up topic policy service state.

Motivation
The current exception handler does not clean all states, which will cause some wrong behaviour.
E.g:
case 1:
https://github.com/apache/pulsar/blob/e20f34bd2a6b4bd7ce72390a593931a855f8e250/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java#L249-L264
When line 259 closes the reader with an exception, it doesn't remove namespace from policyCacheInitMap, so next time this method is called, they will do nothing because policyCacheInitMap.putIfAbsent(namespace, false) is not empty.
This will cause getTopicPolicies throw TopicPoliciesCacheNotInitException.
https://github.com/apache/pulsar/blob/e20f34bd2a6b4bd7ce72390a593931a855f8e250/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java#L193-L205
case 2:
When line 384 gets AlreadyClosedException, it doesn't remove namespace from policyCacheInitMap, but the current namespace value in policyCacheInitMap is true. Therefore, the next time prepareInitPoliciesCache  is called, a new reader is never created. This will cause getTopicPolicies get NULL value.
https://github.com/apache/pulsar/blob/e20f34bd2a6b4bd7ce72390a593931a855f8e250/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java#L376-L393
Modifications

Clean state when the reader gets an error.
Don't clean ownedBundlesCountPerNamespace when reader get AlreadyClosedException.

Verifying this change

[x] Make sure that the change passes the CI checks.

Documentation

[x] no-need-doc

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

@codelipenghui @Technoboy-  @eolivelli @lhotari  @michaeljmarshall @Jason918
PTAL, when you have time ~

Good work @mattisonchao
I guess it might be hard to reproduce with tests, but it would be useful to have a test case that reproduces the issue.
Penghui's comment about the thread safety (race condition) is valid. that might require more changes. Tests would help in that case too.

Good work @mattisonchao I guess it might be hard to reproduce with tests, but it would be useful to have a test case that reproduces the issue. Penghui's comment about the thread safety (race condition) is valid. that might require more changes. Tests would help in that case too.

Sure, Very thanks for your suggestions.
I will try to add a multi-thread test to verify race conditions.

As @mattisonchao is on holiday this week, how about merging this first and add test later?
@lhotari @Jason918 @codelipenghui

As @mattisonchao is on holiday this week, how about merging this first and adding test later?

Works for me, @JipeiWang could you please help create an issue for tracking the test?


plot is not the same between APDL and Pymapdl_reader

🤓 Before submitting the issue

[X] I have visited the Troubleshooting section.
[X] I have searched among the existing issues.
[X] I am using a Python virtual environment.
[X] I am using the latest version of PyMAPDL and its dependencies (fully updated virtual environment). You can update them using pip install --upgrade --upgrade-strategy eager ansys-mapdl-core in your activated virtual environment.

🔍 Description of the bug
Hello everybody,
When i plot my rst file with pyansys, it is not the same result as APDL plotting

Thanks in advance for your help
🕵 Steps To Reproduce
from ansys.mapdl import reader as pymapdl_reader

model = "C:/test_ansys/MODEL.rst"
result = pymapdl_reader.read_binary(model)
print(result)
result.plot_nodal_solution(0, 'norm', label='Displacement')

💻 Which Operating System are you using?
Windows
🐍 Which Python version are you using?
3.10
📝 PyMAPDL Report
Show the Report!

# PASTE HERE THE OUTPUT OF `python -c "from ansys.mapdl import core as pymapdl; print(pymapdl.Report())"` here

📝 Installed packages
Show the installed packages!

# PASTE HERE THE OUTPUT OF `python -m pip freeze` here

I have attached the .rst file here:
MODEL.txt
Just change the extension ".txt" to ".rst" ( github doesn't support .rst file)
📝 Logger output file
Show the logger output file.

# PASTE HERE THE CONTENT OF THE LOGGER OUTPUT FILE.

@mikerife updated


Tests

Write tests and create a travis file. I have currently not tested much.

Travis and codecov have been installed.


Don't mark ENV values as nil

Motivation

Fixes #3589.
Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_MG0dZHSjHwgWWH
→ https://go/builds/bui_MG0dTkw2HuwbgK

@froydnj from the doc you link:

If value is nil, deletes the environment variable:

that means that to_h will never have an environment variable that is set but whose contents are nil.

Note that we still have sigs for [] and []= that say "you might get a nil back"


CoRa Model v.3 with Texture

Design version 3 thanks to Rafi and Cole.
Fixes #5 with higher trunk bottom.
This PR also shifts sensors by z += 1 to account the offset added to dummy_linkin #4.
The number of files changed is because I restructured the meshes directory a bit.
We might want to move some sensors. Currently the Velodyne is picking up all the mounts.

Wow - that look slick!

One thing I've noticed is that if I send a thruster command, the propeller only spins for a second, and then, it stops.

One thing I've noticed is that if I send a thruster command, the propeller only spins for a second, and then, it stops.

Thanks for spotting that! This is only with rostopic pub right? The joystick still works. I wonder what is the difference.
Looks like that has been the case even in the initial PR. I can reproduce in hashes ab1b3a770a0dbfdb27bdfd8bc0f3065ac8a66dba and 735b5a5ac103f9b40ed85e1fb53becead0591c88
So looks like it's independent from this PR. I'm going to open an issue and unblock this PR.

Issue opened. Let me know if you think this PR is clear to merge to unblock #13. Or we could wait till I fix the issue but that should probably be in a separate PR anyway to keep things clear.

Issue opened. Let me know if you think this PR is clear to merge to unblock #13. Or we could wait till I fix the issue but that should probably be in a separate PR anyway to keep things clear.

Thanks! Let's merge!


pmount: new package at 0.9.23

Description of package
pmount ("policy mount") is a wrapper around the standard mount program which permits normal users to mount removable devices without a matching /etc/fstab entry.
Installed manifest of package
(kiss manifest pmount)
/var/db/kiss/installed/pmount/version
/var/db/kiss/installed/pmount/sources
/var/db/kiss/installed/pmount/patches/001-fix-musl-build.patch
/var/db/kiss/installed/pmount/patches/001-disable-intltool.patch
/var/db/kiss/installed/pmount/patches/
/var/db/kiss/installed/pmount/manifest
/var/db/kiss/installed/pmount/depends
/var/db/kiss/installed/pmount/checksums
/var/db/kiss/installed/pmount/build
/var/db/kiss/installed/pmount/
/var/db/kiss/installed/
/var/db/kiss/
/var/db/
/var/
/usr/share/man/man1/pumount.1
/usr/share/man/man1/pmount.1
/usr/share/man/man1/
/usr/share/man/
/usr/share/
/usr/bin/pumount
/usr/bin/pmount
/usr/bin/
/usr/

New package

[x] Latest upstream version.
[x] I agree to maintain this package.
[x] I agree to notify the @kiss-community maintainers if I can no longer maintain this package.

Why is autotools so gross.

I agree, unfortunately pmount is too comfortable for me.

If you could also remove the irrelevant commits :)

before I start, my git-flow (maybe buggy) is the following
$ git fetch upstream
$ git checkout main
$ git merge upstream/main
$ git branch -b <package>
$ .....
$ .....
$ .....
$ git push origin <package>

so I don't know what went wrong (libdvdread is already merged)
If you prefer I can reset my repo (but I would like to fix it)

I use rebase instead of merge.
If you rebase this branch onto upstream/main and then force push it should probably clean it up

All fixes are in place.
Thanks!!

Sorry for the delay;

Don't worry, we are all volunteers ;)

thank you for the fixes! Just two small nits and it'll be all set :)

fixed. Let me known.


Vapor 4 Support

Added Vapor 4 support. Please review and let me know if any changes required. Thanks.

Thanks @abhidsm, released under version 4.0.0.


Update insecure dependencies

Description of Change
Run npm audit fix.
Related Issue
None.
Motivation and Context
Insecure dependencies are undesirable.
Checklist

[x] Ran npm run lint and updated code style accordingly
[x] npm run test passes
[x] PR has a description and all contributors/stakeholder are noted/cc'ed
[x] tests are updated and/or added to cover new code
[x] relevant documentation is changed and/or added

Thanks @jpmckinney! Will merge this for now but will have further audit changes per #23.


Specify in Readme that Xcode sound files must be in Resources directory

The readme isn't clear on this - we moved files around within the project for a while before finding a thread that told us to put them in the Resources dir.
Recommend changing readme to say sound files should be added to Project -> Resources directory.

But the react-native-demo isn't put in the Resources folder. Sound file in demo project is in RNSoundDemo folder.


immitating sportify feature:  save articles to a chosen selection

Pls review

Many thanks for your reviews! :)


Support the CommonWA specification

Hello, maintainer of life & author of CommonWA and a few other WebAssembly-based projects here :)
The idea behind Dagger seems to be similar with that of CommonWA, both wanting to provide an OS-level abstraction over the underlying runtime environment for WebAssembly. Do you think it would be better if we work together on CommonWA and try to spread the support over all kinds of systems/runtimes, so that we'll have a unique standard of the WebAssembly runtime environment, and languages that compile to WASM will have a unified target with a full "OS" environment?

Yes, I am willing to work with the CommonWA specification, but there has been little movement on actual real-world tasks for it. All of the things described in CommonWA would be easy to implement using this existing environment.

I have implemented this in #8, but without a way to test it, verifying this is hard.

If you find a c or java implementation maybe it helps ?
Do they have a wasm binary that they use to test against ?
On Fri, 7 Sep 2018, 05:12 Christine Dodrill<EMAIL_ADDRESS>wrote:

I have implemented this in #8 https://github.com/Xe/olin/pull/8, but
without a way to test it, verifying this is hard.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Xe/olin/issues/7#issuecomment-419308838, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ATuCwiV0N53zecOkGYYT6xJPbbnWsGseks5uYeQ5gaJpZM4Wc1I-
.

Because the upstream CommonWA specification has no tests, I have written my own. I have everything passing but the resource tests because those haven't been written yet.


automate-ui: concurrent requests can cause undesired logouts

Describe the bug
When a session times out, i.e., the user's ID token expires, an ordinary API request can get a 401 response while or before the session refresh request (GET /session/refresh) has gotten the browser a fresh ID token. This will lead to a signout that is avoidable. For local and LDAP users, that means they'll have to provide their credentials again. SAML users with active IdP-session might just "flicker through" the process, but may still lose UI state (like filled in forms).
👉 This affects any IAM version (and any API request), but it's most prevalent in IAM v2.1 because of the periodic call to apply-rules.
To Reproduce
Steps to reproduce the behavior:

TODO

Expected behavior
A description of what you expected to happen.
Ideally, the same entity response for session refresh would also handle API requests. It could then react to 401s in a better way than a call to logout().
Additional context
This is not new, it's only become more apparent through the periodic API requests.

this work has been deprioritized, so closing.


[Feature request] Use rofi to request vault password

Hi !
I switch from bitwarden-pyro to rofi-rbw as pyro seems not maintained anymore.
Pyro can use rofi to request the vault password, this choice allows for a more integrated design as the window to display the credentials and the window to asks for the password are the same.
I was wondering if rofi-rbw could offer the same possibility ?
I did the modification for pyro here https://github.com/mihalea/bitwarden-pyro/pull/7 (it was never merged unfortunately).
I can make the modifications to rofi-rbw if you are ok

Hey, thanks for the idea :)
I just had a very quick look at rbw, and it seems that you can't pass it the password for unlock. However, maybe you can find some documentation for that, or open a feature request.

You are right. I'll try to create a FR in rbw

Blocked by https://github.com/doy/rbw/issues/65 :/

Since rbw hasn't seen a lot of development lately, I'll close this issue. When the feature lands there, we can open it again.


Migrate from "g2" to "sz"

See https://github.com/senzing-garage/sz-sdk-go/issues/177

Pull requests:

https://github.com/senzing-garage/explain/pull/71


Support for Unreal Engine 4.22

Support for UE version 4.22 would be great! :-)

It works in 4.22!

I had trouble installing it from source, and saw README.md listing 4.21 as the latest supported version, so thought hat was the problem. No binary version for 4.22.

I had trouble installing it from source, and saw README.md listing 4.21 as the latest supported version, so thought that was the problem. No binary version for 4.22.
EDIT: Installing from source does indeed work fine on 4.22 - my bad!

thats weird, i tried and I had gotten a few issues, will test again.

Has it made any progress?

4.22 is officially supported (you need to build from sources)

Thanks for the feedback...
But are there any tutorial/step-by-step on how to do that...  On version Unreal 4.21 I'd take the release files  UnrealEnginePython_20181128_4_21_python36_embedded_win64.zip version and it's ok, perfect...  but on version 4.22, I don't know how can I do.  Is there any way or tutorial explaining how can I do to install python on 4.22?
Thank a million.

I think you have to compile it from source. Follow the steps in the README, under "install from source".

I finished ”from the file explorer right click on the project main file and choose 'generate visual studio project files'” step. but ，open visual studio ，cont see  Plugins/UnrealEnginePython  in my solution explorer .  and cont run the compilation . Has anybody been in the same situation as me?

我在从源代码安装它时遇到了麻烦，并且看到README.md列出了4.21作为最新支持的版本，所以认为这是问题所在。没有4.22的二进制版本。
编辑：从源代码安装确实在4.22上工作正常 - 我的坏！

hi Man ！can you give me your compilation finished 4.22 " .dll " file    . Thank you very much.

I had trouble installing it from source, and saw README.md listing 4.21 as the latest supported version, so thought that was the problem. No binary version for 4.22.
EDIT: Installing from source does indeed work fine on 4.22 - my bad!

hi Man ！can you give me your compilation finished 4.22 " .dll " file    . Thank you very much.

@Sengunbanba updated binary releases are now available

@Sengunbanba updated binary releases are now available

Thank you very much.

Is it possible to use Python 3.7 with a 4.22 source build?


fuzz testing: add hello_events tests

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.508%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
13133

Relevant Lines:
20048

💛  - Coveralls


Add multi site support to a bench

Description
Multi site support for a bench, where use a bench with multiple sites.
Expected Behavior
WIP
Current Behavior (if applicable)
User is only able to create a bench with only one site.

One more use-case for this:

We require 11 containers per bench.
Keeping the number aside, the container spin up time is high. (Standard installation times)
Also, on MacOS, Docker containers consume a lot of resources.

When the requirement comes for spinning up a quick site for testing, that has 10+ apps, the standard setup time is high as we need to clone Apps, and then install them and then do the DB restore.
With this feature, the Apps will already be there, and a user just requires to do install-app. No need to setup everything from scratch.


Logs filter does not fire on "enter" key press

When I filter logs by clicking the "enter" key - nothing happens, it works only if I click on the magnifying glass icon:

Perhaps one more request: remove glowing line around edit as it does not cover a whole widget (button)

Hi @bora89. Thanks for the issue. Ok, we'll add the search action by "enter" key press.


Promisify everything

There are lots of HTTP requests to make, so promisifying will be worthwhile.

Made a start in c15dbe0.

This is pretty much done.


INFO

is there any preview of script pls ?

Not yet, as the script is very much in an early state of development and is not fully functional as intended..

ohh ok


Sorting slices alphabetically results in 500 - Internal Server Error

Make sure these boxes are checked before submitting your issue - thank you!

[X] I have checked the superset logs for python stacktraces and included it here as text if any
[X] I have reproduced the issue with at least the latest released version of superset
[x] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
Latest Version
Expected results
Sorting slice alphabetically
Actual results
500 - Internal Server Error
Steps to reproduce
Click on 'Slices', next to the slice title, click on the up/down arrow to sort.

What version is latest version?

version 20.4.
Stacktrace
Traceback (most recent call last):
File "/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask/app.py", line 1982, in wsgi_app
response = self.full_dispatch_request()
File "/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask/app.py", line 1614, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask/app.py", line 1517, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request
rv = self.dispatch_request()
File "/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request
return self.view_functionsrule.endpoint
File "/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/security/decorators.py", line 26, in wraps
return f(self, *args, **kwargs)
File "/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/views.py", line 475, in list
widgets = self._list()
File "/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/baseviews.py", line 877, in _list
page_size=page_size)
File "/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/baseviews.py", line 791, in _get_list_widget
count, lst = self.datamodel.query(joined_filters, order_column, order_direction, page=page, page_size=page_size)
File "/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/models/sqla/interface.py", line 109, in query
order_direction=order_direction)
File "/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/models/sqla/interface.py", line 71, in _get_base_query
query = query.order_by(self._get_attr(order_column).asc())
AttributeError: 'property' object has no attribute 'asc'

related: https://github.com/dpgaspar/Flask-AppBuilder/issues/610

I've also got the same error on version 0.20.4
Sorry, something went wrong
500 - Internal Server Error
Stacktrace
     Traceback (most recent call last):

File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1982, in wsgi_app
response = self.full_dispatch_request()
File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1614, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1517, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request
rv = self.dispatch_request()
File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request
return self.view_functionsrule.endpoint
File "/root/venv/lib/python2.7/site-packages/flask_appbuilder/security/decorators.py", line 26, in wraps
return f(self, *args, **kwargs)
File "/root/venv/lib/python2.7/site-packages/flask_appbuilder/views.py", line 475, in list
widgets = self._list()
File "/root/venv/lib/python2.7/site-packages/flask_appbuilder/baseviews.py", line 877, in _list
page_size=page_size)
File "/root/venv/lib/python2.7/site-packages/flask_appbuilder/baseviews.py", line 791, in _get_list_widget
count, lst = self.datamodel.query(joined_filters, order_column, order_direction, page=page, page_size=page_size)
File "/root/venv/lib/python2.7/site-packages/flask_appbuilder/models/sqla/interface.py", line 109, in query
order_direction=order_direction)
File "/root/venv/lib/python2.7/site-packages/flask_appbuilder/models/sqla/interface.py", line 73, in _get_base_query
query = query.order_by(self._get_attr(order_column).desc())
AttributeError: 'property' object has no attribute 'desc'

Warning: this issue has been inactive for 182 days and will be automatically closed on 2018-05-01 if there is no further activity. You can add the keepup label to the issue in order for this bot to keep it open.


Google Analytics

Don't forget to update privacy policy
Originally created by Tom Smyth at 2017-01-25 15:00, migrated from redmine-#5774

Description updated (diff)

By Tom Smyth at 2017-01-26 08:35

Category deleted ( ~~ Public Release~~ )

By Tom Smyth at 2017-09-06 13:58

Status changed from New to Closed

By Tom Smyth at 2018-01-01 15:20

Version set to 5.0

By Tom Smyth at 2017-12-31 14:16


Bug with numeric values

I don't know why the reported closed #223.
However it's a bug of NodeJs odbc. Is using this code to set the type (probably if you don't have decimals it's using integers):
    else if (value->IsNumber()) {
      double *number   = new double(value->NumberValue());

      params[i].ValueType         = SQL_C_DOUBLE;
      params[i].ParameterType     = SQL_DECIMAL;
      params[i].ParameterValuePtr = number;
      params[i].BufferLength      = sizeof(double);
      params[i].StrLen_or_IndPtr  = params[i].BufferLength;
      params[i].DecimalDigits     = 7;
      params[i].ColumnSize        = sizeof(double);

      DEBUG_PRINTF("ODBC::GetParametersFromArray - IsNumber(): params[%i] c_type=%i type=%i buffer_length=%lli size=%lli length=%lli value=%f\n",
                    i, params[i].ValueType, params[i].ParameterType,
                    params[i].BufferLength, params[i].ColumnSize, params[i].StrLen_or_IndPtr,
                                *number);
    }

Then is using as
        ret = SQLBindParameter(
          hSTMT,                    //StatementHandle
          i + 1,                    //ParameterNumber
          SQL_PARAM_INPUT,          //InputOutputType
          prm.ValueType,
          prm.ParameterType,
          prm.ColumnSize,
          prm.DecimalDigits,
          prm.ParameterValuePtr,
          prm.BufferLength,
          &params[i].StrLen_or_IndPtr);

basically is passing 8 as precision and 7 as decimal that is a number like X.XXXXXXX. Correctly 33.44 is not accepted as 33 cannot fit in X. They probably want SQL_REAL instead of SQL_DOUBLE.

See https://github.com/FreeTDS/freetds/issues/285

Hi there,
Any news on this ? It's huge problem !

Hello!
Sorry, I have been away at a conference and vacation for the last little bit, and haven't had a chance to work on this. I have read the freetds#285 thread and I think I have a sense for what is wrong. I will try to get something pushed out to odbc 2.0 branch today

Hi
Thanks  👍

Hi @qlecler,
Sorry, I initially misunderstood
From the code posted, I assume you are using v1.x of the odbc package. I actually haven't worked much on this on. I rewrote it to a v2.0 that is currently in beta, that uses the ODBC function SQLDescribeCol, which gets a lot of the data about the columns so it doesn't have to be assumed like in:
params[i].DecimalDigits     = 7;
params[i].ColumnSize        = sizeof(double);

I can try to go back and write a patch for v1.x, but it might be fragile. Would you consider trying to download v2.0 beta with:
npm install odbc@beta

and let me know if the issue persists in the new version? When I get done with the backlog on v2.0 work, I can look to see if I can easily change the code causing the issue in v1.x, but when 2.0 is released soon I probably won't support 1.x anymore

Hi markdirish !
I'm using the v1 for a project in production.
I can't use the v2 beta except for testing.
When do you expect to release a stable version of the v2 ?
Are they breaking changes between those two versions ?
Thanks 👍

v2.0 is out now, can be installed with
npm install odbc

The repo for 2.0 is at https://github.com/markdirish/node-odbc
There are many breaking changes: The API has been completely rewritten, but it should all be documented in the README (which should display on npm and on GitHub)


Includes seems to cause N + 1 query

With active_model_serializers, I get:
Profile Load (0.6ms)  SELECT "profiles".* FROM "profiles" WHERE "profiles"."user_i$
" IN (6, 25, 33, 14, 5, 53, 72, 75, 81, 113, 49)

With this library I get:
...
Profile Load (1.1ms)  SELECT  "profiles".* FROM "profiles" WHERE "profiles"."id" =
$1 LIMIT $2  [["id", 14], ["LIMIT", 1]]
Profile Load (0.6ms)  SELECT  "profiles".* FROM "profiles" WHERE "profiles"."id" =
$1 LIMIT $2  [["id", 5], ["LIMIT", 1]]
...

Here's how I used active_model_serializers:
render json: videos, scope: current_user, include: :profile

Here's how I use this library in my controller:
render json: FastVideoSerializer.new(videos, scope: current_user, include: [:profile])

Redacted serializers that I'm using:
class FastVideoSerializer
  include FastJsonapi::ObjectSerializer
  belongs_to :profile, serializer: :fast_profile
end

class FastProfileSerializer
  include FastJsonapi::ObjectSerializer
  attributes :user_id, :full_name, :username, :photo
end

I'm using v1.1.1

As a workaround, I'm doing this:
render json: {
  data: FastVideoSerializer.new(videos, scope: current_user).serializable_hash[:data],
  included: FastProfileSerializer.new(Profile.where(id: videos.map(&:profile_id)), scope: current_user).serializable_hash[:data]
}

I think you might be able to avoid N+1 by preloading profiles like below...?
render json: FastVideoSerializer.new(videos.preload(:profiles), scope: current_user, include: [:profile])

@shuheiktgw I tried this but it didn't help if I recall correctly.

@mhluska can you make a test case to show this? Generally we use the active record includes in our query to avoid N+1 queries https://apidock.com/rails/ActiveRecord/QueryMethods/includes

Here is generally how we write our activerecord query so that we avoid N + 1 queries
videos = Video.where(id: ids).includes(:profile).to_a

@mhluska did you try the above includes approach?

closing due to no response

This is happening to me as well. Let me show a simplified version of my code:
class CampaignsController < ApiController
  def index
    campaigns = Business.find(params[:id]).campaigns

    render json: CampaignSerializer.new(campaigns, include: [:campaignable])
      .serialized_json
  end
end

class CampaignSerializer
  include FastJsonapi::ObjectSerializer

  has_one :business
  has_many :venues
  belongs_to :campaignable, polymorphic: true

  attributes :name, :language, :budget, :start_date, :end_date
end

class GoogleAdsCampaignSerializer
  include FastJsonapi::ObjectSerializer

  has_one :campaign

  attributes :bidding_strategy, :max_cpc
end

That is generating the following N+1 query:
Campaign Load (0.8ms)  SELECT  "campaigns".* FROM "campaigns" WHERE "campaigns"."business_id" = $1 ORDER BY "campaigns"."created_at" DESC LIMIT $2 OFFSET $3  [["business_id", "8b1d3f87-b578-4c13-95c7-dcb644f6c537"], ["LIMIT", 25], ["OFFSET", 0]]
↳ app/controllers/api/v1/campaigns_controller.rb:76
GoogleAdsCampaign Load (0.7ms)  SELECT "google_ads_campaigns".* FROM "google_ads_campaigns" WHERE "google_ads_campaigns"."id" IN ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15, $16, $17, $18, $19, $20, $21)  [["id", "2d28b5fd-514f-409f-bd01-47a4948dd33f"], ["id", "365b6486-f70a-4ba5-b8cf-dc206418484d"], ["id", "1465087d-8c39-4954-9dc6-91d1c6fa239e"], ["id", "686fb4b8-8061-40ad-bbdc-075a8e85da44"], ["id", "4795ca4b-dab4-4a3c-8f82-7747231e52a8"], ["id", "d7bcf07d-110a-4e0c-918f-06941c8dd2c2"], ["id", "af3d5f3c-b65e-4825-b227-f68f35ec5015"], ["id", "de2d6fdf-531f-4a60-8eb2-1eccfccd4b5f"], ["id", "81d7e4e2-45b4-425d-9e81-c9f4666fb695"], ["id", "205cd143-30f3-498b-98b1-26808cd7827c"], ["id", "478df856-6858-4f17-9980-373a5e3aed0d"], ["id", "636100df-f59b-49f0-a124-beb6e11966bf"], ["id", "8f8a728f-d994-43c1-8dc6-a8c29dd6defe"], ["id", "ca179a49-7171-449e-badd-3163a99e6e5d"], ["id", "547ec32e-101c-40bd-b39e-d7a4372a9750"], ["id", "4f2e210c-a1be-4751-99b2-adf43f2a9dc7"], ["id", "2e5dd596-1b51-4e47-aa8e-6beedee58735"], ["id", "39860b85-5a81-435b-be54-8beeb49ee23c"], ["id", "7de497a4-7b4f-4fd6-8212-6c0e79149080"], ["id", "2f51047d-8914-423c-bcb1-0a606790b225"], ["id", "724d8e1c-8fa9-4d4e-b847-b18206792a9e"]]
↳ app/controllers/api/v1/campaigns_controller.rb:76
Campaign Load (0.6ms)  SELECT  "campaigns".* FROM "campaigns" WHERE "campaigns"."campaignable_id" = $1 AND "campaigns"."campaignable_type" = $2 LIMIT $3  [["campaignable_id", "2d28b5fd-514f-409f-bd01-47a4948dd33f"], ["campaignable_type", "GoogleAdsCampaign"], ["LIMIT", 1]]
↳ app/controllers/api/v1/campaigns_controller.rb:76
Campaign Load (0.4ms)  SELECT  "campaigns".* FROM "campaigns" WHERE "campaigns"."campaignable_id" = $1 AND "campaigns"."campaignable_type" = $2 LIMIT $3  [["campaignable_id", "365b6486-f70a-4ba5-b8cf-dc206418484d"], ["campaignable_type", "GoogleAdsCampaign"], ["LIMIT", 1]]
↳ app/controllers/api/v1/campaigns_controller.rb:76
Campaign Load (0.4ms)  SELECT  "campaigns".* FROM "campaigns" WHERE "campaigns"."campaignable_id" = $1 AND "campaigns"."campaignable_type" = $2 LIMIT $3  [["campaignable_id", "1465087d-8c39-4954-9dc6-91d1c6fa239e"], ["campaignable_type", "GoogleAdsCampaign"], ["LIMIT", 1]]
↳ app/controllers/api/v1/campaigns_controller.rb:76
Campaign Load (0.4ms)  SELECT  "campaigns".* FROM "campaigns" WHERE "campaigns"."campaignable_id" = $1 AND "campaigns"."campaignable_type" = $2 LIMIT $3  [["campaignable_id", "686fb4b8-8061-40ad-bbdc-075a8e85da44"], ["campaignable_type", "GoogleAdsCampaign"], ["LIMIT", 1]]
↳ app/controllers/api/v1/campaigns_controller.rb:76

I've detected that the problem comes from the GoogleAdsCampaignsSerializer, more precisely the line has_one :campaign. It loads the association, but I'm calling this serializer from the parent CampaignsSerializer, so the object is already loaded.
If I comment the aforementioned line it works as expected, but obviously doesn't work when I fetch the GoogleAdsCampaigns and want to make a reference to its related Campaign.

Can this be reopened?  We are running into this as well with a has_one/belong_to in serializers that call others, especially with join records where there's M:M relationships from the parent. In a separate case, we sometimes want to eager load associates for a single instance (say current user) because the necessary data is strewn across multiple models/serializers, but the has_one/belongs_to is causing those eager loads to be ignored. So for example:

UserSerializer.new(current_user,
        include: ['foos'],
        params: {
          includes: ['foos'],
          active_storage: {
            host: request.host,
            port: request.port,
            protocol: request.protocol
          }
        }

class UserSerializer < BaseSerializer
  has_many :foos, if: Proc.new { |record, params|
      params && params[:includes] && params[:includes].include?('foos')
    } do |record,params|
      record.foos.includes(logo_attachment: :blob)
    end
end

class FooSerializer < BaseSerializer
    attributes :start_at, :end_at

    belongs_to :bar, id_method_name: :bar_custom_id
  end

class BarSerializer < BaseSerializer
    attributes :name, :description

    attribute :logo_url do |record, params|
      if record.logo.attached?
        polymorphic_url record.logo
      end
    end

We have even tried instead using just has_many :foos by itself thinking maybe us setting the block would be the issue, but still returns N+1 queries.


Add headerDetail property for cc and bcc

Add headerDetail property for cc and bcc.
Usage
$imap->incomingMessage->headerDetail->cc
If there is no property in the returned object, then it is not present in this letter.

Looks good!!


vhost-user: add FS_IO request

This is defined by vhost-user-fs (virtio-fs), can be used by a client to
ask VMM to perform a read/write from an fd directly to GPA.
Fix: #10
Signed-off-by: Liu Bo<EMAIL_ADDRESS>

LGTM, thanks!


Added CHANGELOG for 1.10.1

https://github.com/ioam/holoviews/pull/2589 has just been merged. Do you think it is worth a CHANGELOG entry as this is supposed to be a rather obscure use case?

I'll leave that up to you, I've already glossed over some very minor issues.

Looks good. Time to release 1.10.1!


Free up space in Ubuntu actions

@louis030195 This is so the builds don't fail again, this frees up about 34GB which is enough and a bit more.

@Neptune650 thanks! did not see the error

@louis030195 You need to set large-packages to false btw.

@Neptune650 build does not work on windows, libiomp5md.dll missing after going through CI/CD and installing on my windows machine

@louis030195 Fixing it, I'll use the pre_build.js script. Pushing a fix soon.

@louis030195 Should the pre_build.js run everywhere or just GitHub Actions?

@louis030195 Should the pre_build.js script be able to run everywhere or just GitHub Actions?

everywhere
people use it to build the app

@louis030195 I might be going a little insane - I've spent some hours working on this, and so far I can't figure it out.
For example here: https://github.com/Neptune650/screenpipe/actions/runs/11603910078/job/32311762713
Even though we're installing libhwloc and copying it, somehow Tauri can't find it.

@Neptune650 hmm okay, ill have a look tomorrow it's fine for now


An important issue in pcb

what is connected to the green line coming from the "+"???

and still a question, it is possible as or to part a new payment, or to connect to the same at once 3 load cell independent from each other???


[FEATURE] Loading a Dataset as a tuple instead of a dictionary

🚨🚨 Feature Request

[ ] A new implementation (Improvement, Extension)

Is your feature request related to a problem?
Currently,, the generators for the Keras library uses batches of (x, y) tuples in order to feed data to the model. The Hub schemas only let us change the shape and/or datatype of the data within a dictionary. If we could extend this behavior to load data as batches of tuples as well the keras integration would be seamless.
If your feature will improve HUB
Hub would be seamlessly integrated with Keras. End-Users would not need to modfiy the data further after loading it via hub, when they are using Keras models and generators.
Description of the possible solution
We might need to restructure the APIs that are providing the data. Though unlikely, could be breaking.

Hi @DebadityaPal thanks for the request!
Are you looking for a better way to do this:  (X, y) = ds["data", i].compute(), ds["label", i].compute()?

Hi @DebadityaPal thanks for the request!
Are you looking for a better way to do this:  (X, y) = ds["data", i].compute(), ds["label", i].compute()?

This would certainly work for smaller datasets. However, with larger databases, we cannot load all the data into memory at once. It would be better if there was some way the dataset could yield tuples rather than having to manipulate the dictionary into a tuple. This would allow us to feed the dataset to the Keras model directly.

This would certainly work for smaller datasets. However, with larger databases, we cannot load all the data into memory at once. It would be better if there was some way the dataset could yield tuples rather than having to manipulate the dictionary into a tuple. This would allow us to feed the dataset to the Keras model directly.

That makes sense @DebadityaPal. Could you share some sample code of how you're doing it currently vs how you would want it to be after this feature is implemented? That should make the issue more clear

That makes sense @DebadityaPal. Could you share some sample code of how you're doing it currently vs how you would want it to be after this feature is implemented? That should make the issue more clear

Gotcha, so something more like this?
def load_data(ds, batch_size):
"""Return a generator to yield (X, y).
"""
   for i in range(n, batch_size):
       yield ds["data", i: i + batch_size].compute(), ds["label", i: i + batch_size].compute()

Gotcha, so something more like this?
def load_data(ds, batch_size):
"""Return a generator to yield (X, y).
"""
   for i in range(n, batch_size):
       yield ds["data", i: i + batch_size].compute(), ds["label", i: i + batch_size].compute()

Thanks, @mynameisvinn this works perfectly!
@AbhinavTuli what I was initially doing was something like this,  I converted the whole data to (X, y) pairs first.
def convert(...):
     ``` converts the whole data into (X,y)```
     ...
     return (X, y)

(X, y) =  convert(ds)
model.fit(X, y)

what I would like to do is:
```suppose this sets the schema to return tuples```
schema = (np.ndarray(int64), np.ndarray(int64))

ds = Dataset("activeloop/mnist", mode='w', schema=schema)

model.fit(ds)

I know that schema is supposed to give a structure to a local dataset that one is about to upload, but it would be good if we could use it to restructure retrieved datasets and especially convert them to tuples from dictionaries.
Although this problem is completely solved by the code snippet provided by @mynameisvinn, so I don't think it would be necessary to change the current flow of the software.

Thanks, @mynameisvinn this works perfectly!
@AbhinavTuli what I was initially doing was something like this,  I converted the whole data to (X, y) pairs first.
def convert(...):
     ``` converts the whole data into (X,y)```
     ...
     return (X, y)

(X, y) =  convert(ds)
model.fit(X, y)

what I would like to do is:
```suppose this sets the schema to return tuples```
schema = (np.ndarray(int64), np.ndarray(int64))

ds = Dataset("activeloop/mnist", mode='w', schema=schema)

model.fit(ds)

I know that schema is supposed to give a structure to a local dataset that one is about to upload, but it would be good if we could use it to restructure retrieved datasets and especially convert them to tuples from dictionaries.
Although this problem is completely solved by the code snippet provided by @mynameisvinn, so I don't think it would be necessary to change the current flow of the software.

Glad I was helpful! Let me know if you need anything else.

Glad I was helpful! Let me know if you need anything else.

@DebadityaPal I am closing this issue but let me (or @AbhinavTuli) know if you run into other memory-related issues.

@DebadityaPal I am closing this issue but let me (or @AbhinavTuli) know if you run into other memory-related issues.


Add simple Attention layer (attention.py)

- What I did
I added a keras implementation of attention with context.
- How I did it
- How you can verify it
I added unit tests.

This pull request fixes #issue_number_here

@SriRangaTarun , we'll wait for the outcome of the folowing PR which is extremely related: https://github.com/keras-team/keras/pull/11421 we don't want multiple ways to do the same thing in keras, so it's better to wait to make sure we're consistent.

Feel free to reopen this PR once https://github.com/keras-team/keras/pull/11421 is merged.


Feature Request: Wallpaper in all screens

When you select a general wallpaper it only displays in the settings and apps pages, the rest have a black background. Would be great that it would display everywhere.
(Also i only have the frontend in two android devices so i don't know if this is something only i am experiencing or indeed the wallpaper doesn't display in all screens)

Duplicate


Create example program: Blind computing

You'll see that lecture 15 here -> http://pwallden.gr/courseiqc.asp covers this topic. I wonder if a notion of 'client' and 'server' could be created with guppy? Then the approach taken in these lecture notes would make sense as it requires 2 quantum capable parties.
Alec mentioned a cryptographic approach, which would be along the lines of this -> https://arxiv.org/abs/2209.14316. This is becoming quite complicated though, and an implementation of this would be publication worthy :P
I probably would not worry too much about blindness as I don't see that it adds significantly more complicated control flow. This is unless there is a natural way of writing a client and a server, in which case this would be very interesting.


Election should also verify votes agree on previous block

Otherwise, you could fork.

More concretely, I think the idea was to verify that a majority of votes (on a block) agree on the id of the previous block (i.e. "previous_block"). If not, then the block is decided invalid, so all its transactions can get copied to the backlog.


Tilemap init

Contains basic asset packs and a work-shop scene.
Includes additions to the Readme, sets a baseline for folder structure

 [FEATURE] Basic Movement