[dargon2] Crash on Ubuntu 20.04.3 LTS

Using dargon2: ^3.2.0 on Ubuntu 20.04.3 LTS with Dart SDK 2.17.5 results in a crash.
Here is sample source:
import 'package:dargon2/dargon2.dart';

void main() async {
  await argon2.hashPasswordBytes(
    <int>[0,1,2],
    salt: Salt.newSalt(),
  );
}

Running this code (applying the temporary path fix from this issue) gives the following output:
===== CRASH =====
si_signo=Illegal instruction(4), si_code=2, si_addr=0x7efdd8c5da58
version=2.17.5 (stable) (Unknown timestamp) on "linux_x64"
pid=33638, thread=33647, isolate_group=main(0x56193f53b000), isolate=main(0x56193f5cd800)
isolate_instructions=56193d650060, vm_instructions=56193d650060
  pc 0x00007efdd8c5da58 fp 0x00007efdd40fd050 /home/test/.pub-cache/hosted/pub.dartlang.org/dargon2-3.2.0/lib/src/blobs/libargon2-linux.so+0x3a58
  pc 0x00007efdd8c5cd54 fp 0x00007efdd40fd290 /home/test/.pub-cache/hosted/pub.dartlang.org/dargon2-3.2.0/lib/src/blobs/libargon2-linux.so+0x2d54
-- End of DumpStackTrace
  pc 0x0000000000000000 fp 0x00007efdd40fd398 sp 0x0000000000000000 [Optimized]<PHONE_NUMBER>5696
  pc 0x00007efdd1e69323 fp 0x00007efdd40fd428 sp 0x00007efdd40fd3a8 [Optimized] FfiTrampoline
  pc 0x00007efdd1e645a3 fp 0x00007efdd40fd5e0 sp 0x00007efdd40fd438 [Unoptimized] DArgon2Native.hashPasswordBytesSync
  pc 0x00007efdd1e639d1 fp 0x00007efdd40fd680 sp 0x00007efdd40fd5f0 [Unoptimized] DArgon2Native.hashPasswordBytes
  pc 0x00007efdd1e6386a fp 0x00007efdd40fd778 sp 0x00007efdd40fd690 [Unoptimized] DArgon2Native.hashPasswordBytes
  pc 0x00007efdd1e247cc fp 0x00007efdd40fd7e0 sp 0x00007efdd40fd788 [Unoptimized] main
  pc 0x00007efdd1e23d6f fp 0x00007efdd40fd820 sp 0x00007efdd40fd7f0 [Unoptimized] main
  pc 0x00007efdd1e239c9 fp 0x00007efdd40fd848 sp 0x00007efdd40fd830 [Unoptimized] main
  pc 0x00007efdd1e238f9 fp 0x00007efdd40fd8a8 sp 0x00007efdd40fd858 [Unoptimized] _Closure@0150898.dyn:call
  pc 0x00007efdd1e22790 fp 0x00007efdd40fd8e0 sp 0x00007efdd40fd8b8 [Unoptimized]<EMAIL_ADDRESS>closure>
  pc 0x00007efdd1e2251c fp 0x00007efdd40fd948 sp 0x00007efdd40fd8f0 [Unoptimized] _Closure@0150898.dyn:call
  pc 0x00007efdd1e21d93 fp 0x00007efdd40fd998 sp 0x00007efdd40fd958 [Unoptimized] _RawReceivePortImpl@1026248._handleMessage@1026248
  pc 0x00007efdd8302a0c fp 0x00007efdd40fda10 sp 0x00007efdd40fd9a8 [Stub] InvokeDartCode
Aborted (core dumped)

As a test, I confirmed that I was able to build the reference implementation and run its command-line tool. Further, copying (with a rename) that compiled library to the .pub-cache/[...]/blobs/ directory allows the example code to run properly.

@AaronFeickert Does testing still work? Or is it both testing and running causing the crash? Since the tests on CI seem to pass fine

@tmthecoder Testing fails. I put that sample code directly into a test and ran dart test, which produced the same type of error.

@tmthecoder Could it be a difference in build environment between the ubuntu-latest environment and a fully-updated Ubuntu 20.04.3 LTS installation?
My colleague tested on his Ubuntu 20.04 installation, and my testing was done on a clean VM.

@tmthecoder Same error after updating pubspec.yaml as requested.

@AaronFeickert Can you update and check one more time? I ran the builder to reupload a library off of the latest argon2 reference repo commit

@tmthecoder Ran dart pub cache repair to download the latest from the repository, and dart test. Same error.

@AaronFeickert Interesting, now the CI's ubuntu test is broken too after building

@tmthecoder That's odd, since I was able to do a manual build from the reference implementation, copy it to the expected location, and run successfully.

@tmthecoder Just tried a reference implementation build again, and it worked after copying the resulting compiled library to the appropriate .pub-cache location.

@tmthecoder The only thing I can think of as a difference between the environments could be that ubuntu-latest is using gcc 10.3.0, whereas the default Ubuntu 20.04.3 LTS installation with build-essential is using gcc 9.4.0.

I can try to see if that leads to a fix anywhere. This still works from dart pub on ubuntu 22.04 where the first issue was filed from?

@tmthecoder Using the git reference to dargon2 on Ubuntu 22.04 tests just fine.

@tmthecoder I used gcc 10.3.0 for a reference implementation on Ubuntu 20.04.3 LTS and copied the resulting library into the cache, and testing still worked. So it seems unrelated to that.

@AaronFeickert Are you able to test on the branch now? It should work. If it's possible would you be able to test on both 22.04 and 20.04 to make sure both still work?

@tmthecoder Will test shortly on both! I also have VMs for older LTS releases, depending how far back you intend to support.

@AaronFeickert I'd say If this works on 20.04 I'd love to have you test farther back until it stops but I don't think I'll personally add support but can put up a guide to replace the .so in the case they encounter a crash

@tmthecoder Still works on 22.04. Still crashes on 20.04.3 LTS after dart pub cache clean && dart pub get && dart test.

@AaronFeickert Not sure what could cause this now since I built on a 20.04.1 Ubuntu server machine and pushed it up to GitHub. Any ideas?

@tmthecoder Looks like it's still grabbing commit 26c75d, despite me nuking the lockfile...

Ah wait make sure you set ref: update-dargon2-libraries

@tmthecoder Success on Ubuntu 20.04.3 LTS! Testing works correctly as expected. Running sample code with the dart run path/to/main.dart fix also works.

@tmthecoder Also happy to report success on Ubuntu 18.04.6 LTS.

@tmthecoder The Dart SDK only supports Ubuntu LTS versions under standard support, which excludes Ubuntu 16.04.7 LTS and earlier. So your fix works on all versions that the Dart SDK supports.

@AaronFeickert Alright, that's great to hear! I also heard back on #8, so I'll have a fix up there soon. After that's set I'll push a release to pub.dev
Thank you so much for all of the help!


Remove ApiPort.VisualStudio.2015

This removes our Visual Studio 2015 extension. We're motivated to do this now because we want to leverage WPF accessibility improvements in .NET Framework 4.7.1 in our controls.

Sorry to report it doesn't. Resolving the binding conflicts by upgrading to newer dependencies introduces ~40 warnings from VS SDK analyzers, which I haven't worked through.

Sorry to report it doesn't. Resolving the binding conflicts by upgrading to newer dependencies introduces ~40 warnings from VS SDK analyzers, which I haven't worked through.

Maybe we shouldn't upgrade them. Ahaha.

I'm thinking the same thing but haven't determined exactly which dependencies we need. We can hold off merging this until that's done, this work isn't really complete if we ship assemblies we don't use.

I used a newer version of the VS threading library which does not include the analyzers 🙈 and eliminates the binding warnings. Two birds, one hug.


Can't boot from ISO

I've tried to boot from iso on an VMWare infrastructure.
Tried with versions : 0.8.1 , 0.8.0, 0.7.1, 0.7.0 no one seem's work.
The most frequent error message is :
boot:
Loading ../vmlinuz-4.9.12-rancher... failed: No such file or directory

Ok forget that... looks to an VMWare issue.


Feature/url tweaks

:rocket: deployment of profiles-pr-106 in nhsuk-dev succeeded (http://profiles-pr-106.dev.c2s.nhschoices.net)


Roles on Admonitions Disappearing

If I use a role value to create a unique Admonition (similar to what's suggested in this issue in asciidoctor-pdf: https://github.com/asciidoctor/asciidoctor-extensions-lab/issues/9), that role value is not coming out in the resulting XHTML that's packaged within the epub file. It does work fine with the general HTML backend.
For example: [NOTE.references]
HTML:
<div class="admonitionblock note references">
epub3 XHTML:
<aside class="admonition note" title="Note" epub:type="notice">
Is there something additional that needs to be done to support this in asciidoctor-epub3?

The EPUB3 converter tends not to honor the role on a block in general. You can see there is no reference to it in the convert handle for an admonition block: https://github.com/asciidoctor/asciidoctor-epub3/blob/main/lib/asciidoctor-epub3/converter.rb#L525-L553 There are only a few blocks where the role is honored. Given that the stylesheet is configurable, I would think that the EPUB3 converter probably should always honor the role.


Links are broken when containing parenthesis character ")"

Expected behavior :
Valid and safe URL's  pasted or written should be converted to functional links ( as-is ) .
Actual behavior :
Valid and safe URL's that contain the parenthesis closing character " ) " without pairing are immediately  broken at the point of said character .
Steps to reproduce :

Open the markdown-it demo
Paste a URL ( or write one )
Manually add a closing parenthesis character in the link " ) " without a matched opening one  .

Note : As per my understanding , the parenthesis character " ) " IS considered safe and valid as per   rfc3986 ( see also here  and here )

That's a result of linkifier work. And it has reasons to consider unpaired ")" as outer char. If you don't like it - you can always define links via markdown syntax.
PS. online demos has possibility to create permalinks. Real example is better that description of steps to reproduce.

@puzrin I am not sure I understand why this was closed ( is it because the description or because it is not a bug or because it is in the wrong place ) and also what you mean by define link explicit .
In every way that I tried , the following link is somewhat broken ( as display or link itself )
http://stadtplan2.dresden.de/(S(p5l1235ice3cj3lspsbkmdnb))/spdd.aspx?TH=GA_KLG
Is that the real example you were referring to ?

Because that's not a markdown-it bug, and if you define your link according to commonmark spec, it will work as expected. That may be considered as linkify-it it bug, but it's known and nobody can give you 100% guarantee for heuristic anyway. If you need 100% guarantee, you should format links with commonmark syntax as described in spec.

Is that the real example you were referring to ?

The best way to show example

Understood .
Sorry for missing that permalink tab link .. :-)


Weird indentation in or_else/and_then chain

Using rustfmt 0.4.2-stable, on rust 1.26.1, I type this:
fn foo() {
    let bar = Some(0);
    bar.or_else(|| {
        // do stuff
        None
    }).or_else(|| {
        // do other stuff
        None
    }).and_then(|val| {
        // do this stuff
        None
    });
}

and rustfmt turns it into this:
fn foo() {
    let bar = Some(0);
    bar.or_else(|| {
        // do stuff
        None
    }).or_else(|| {
            // do other stuff
            None
        })
        .and_then(|val| {
            // do this stuff
            None
        });
}

I was wondering if we should apply the same combining behaviour to the }).and_then and/or that the second or_else block should be single indented like the first or_else block.

Having the second or_else block single-indented so it looked like this:
}).or_else(|| {
    // do other stuff
    None
})
    .and_then(|| {
        // do this stuff
        None
    )};

would be...less ugly, maybe? I think it would look better if all the calls in the chain were at the same indentation; I wonder if a case could be made for prioritizing the "Multi-line elements" guideline:

If any element in a chain is formatted across multiple lines, then that element and any later elements must be on their own line.

over the one that prevents "floating":

If the length of the last line of the first element plus it's indentation is less than or equal to the indentation of the second line (and there is space), then combine the first and second lines

so that you'd end up with
fn foo() {
    let bar = Some(0);
    bar
        .or_else(|| {
            // do stuff
            None
        }).or_else(|| {
            // do other stuff
            None
        }).and_then(|val| {
            // do this stuff
            None
        });
}


s3/s3manager: Buffer parts with io.SectionReader when possible

Improves memory consumption on io.ReaderAt streams (files, in memory
buffers) by avoiding creation of individual byte buffers.
Increasing concurrency threshold for seekable streams will no longer
impact memory usage.
Fixes #232

LGTM


AccessViolationException when getting a .NET 3.5 method

I'm using the latest master.
This happens when creating a new MetaDataImport. It gets a LegacyMetaDataImport value, but it seems that it has already been Release()'d and an exception (usually AccessViolationException) is thrown when calling queryInterface() in CallableCOMWrapper.
When hacking the code so it never calls RegisterForRelease(), the program works.
This happens when a ClrMethod gets created. Runtime = CLR35, x86 and x64.

This might be the struct related problem that @isakiev just fixed.  I am doing some 3.5 related testing this week (or weekend) and will be sure to test this as well.

Nope, I was wrong.  Fixed in https://github.com/Microsoft/clrmd/commit/8e1c8235a00f0d2be17d859128a105858110565e.


fixing closed-loop stepper motor alarm (for U4)

Due to the fact that U4 with Tornado has the only closed-loop stepper motor which is not adressed with CAN as later stepper motors. A fix for the internal alarm is necessary.

[x] Creating quick fix for U4
[x] Fixing the invert of the alarm with use of config file to set the hardware when setting up the robot.
[ ] Test on U4
[x] Test on other robot (should not have an influence)

Test steps:

[ ] Deploy code without updating the config. It should raise a KeyError
[ ] Update the config
[ ] Drive and reference the robot

As expected F13/RB36 runs without any errors

This must be tested on U4 and until then U4 must not be newly configured!


How can I catch timeout?

When I try to download a big file I get this: lua: [OPERATION_TIMEDOUT] Timeout was reached (28)
But the execution of the function stops right away. I want to be able to handle this error? How can I do it?

Sorry. I miss this somehow. I think it possible set CURLOPT_TIMEOUT option.
I am not sure it possible resume operation when you already get this error.


Create HTTP gate

Requirements:

1 million events per second on regular server hardware (~10 servers)
storage system is not defined yet, see vostok-project/core/issues/3

#3


[Request] Add https://wolfmax4k.com/ as a provider

Right now the streams with spanish audio found by torrentio are very lacking, with only 720p releases in a lot of cases.
I think the reason is that the spanish providers that stremio already scrapes from, like mejortorrent, don't add the 4K releases found in https://wolfmax4k.com/ (which afaik is the only source in Spain releasing in 4K right now), and in many cases they won't even add the 1080p versions, which makes watching content with spanish audio in stremio a not so good experience.
I kind of solve this by adding the wolfmax4k torrents to real debrid myself, but this has two drawbacks:
a) Not every user has a debrid
b) Since torrentio doesn't scrape from that source, the stream is not recognized as part of its own series in stremio, so it doesn't show up in the stream list for that series. I still can watch it from the debrid section in Discover, but it breaks the nice user experience from stremio.
If torrentio found torrents from that provider, suddenly every user would get 1080p with spanish audio versions in the stream list for almost every release, and finally get some 4k ones too. I think it would make a big impact.
There's no stremio addon for scraping from wolfmax4k right now, but I always find their magnets on search engines like solidtorrents (I don't know if that would make the implementation easier). Or maybe something easier can be done for getting all the torrents from there, i don't really know how torrentio works under the hood.

Hi @kevinfb92 even if I would be considering adding new language specific provider (which atm I'm not), this website is way to convoluted to scrape, to the point where it's not worth the time investment. You're welcome to make your own version scrapping this site and make a spanish specific addon.


fix(maker-squirrel): do not register the delta nupkg as an artifact when deltas are disabled

A better fix for f3d38e0dfbcb307355adfe5b2118ebedbdd91bcc that doesn't just drop all missing files for a single publisher, rather is ensures the maker does not erroneously add the file to the artifacts list in the first place.

@malept Adding testing infra for delta packages is a lot of either effort or test runtime or both.  We could probably test the "no delta" case but we can't easily test the "build me a delta" case without a valid remoteReleases URL and such.
There is generically a lot to do with our tests, in particular the init and make bits are missing extensive tests.  Hopefully we'll be able to take a swing at more extensive testing in the coming weeks and figure out a long term plan for How To Test This Annoying Stuff Better


[DNS-SD] Remove the singleton pattern from ServiceAdvertiser and Resolver

Problem
Although Resolver and ServiceAdvertiser are pure virtual interfaces, they still use the singleton pattern, so it's impossible to inject an arbitrary implementation at runtime.
Proposed Solution
As a minimal solution, let applications construct Resolver and ServiceAdvertiser objects and set them with some Resolver::SetInstance and ServiceAdvertiser::SetInstance methods.

Seems like it was done by #10181. @Damian-Nordic to confirm and close

Thanks @tcarmelveilleux , @Damian-Nordic please re-open if this is an issue.


Add router and global properties to collections config

Add router property on collections. This replaces the need for using the RouteMapper plugin.
...
  name: 'post',
  path: 'posts',
  ui: {
    router: ({ document }) => {
      // eg. post items can be previewed at posts/hello-world
      return `/posts/${document._sys.filename}`;
    },
  },
...

Add global property on collections. This replaces the need for formifyCallback in most cases
...
  name: 'post',
  path: 'posts',
  ui: {
    global: true
  },
...

Another small issue;
Seems like the other types for UI are being wiped out:

Maybe it needs to be wired up in the Admin UI?

Does formifyCallback currently run for stuff in the admin? I don't see where that would be happening?

Seems like the other types for UI are being wiped out:

Is global provided in your screenshot on line 60 (and isn't visible because of the intellisense box).
This is the first use of the ui property at the collections level isn't it?

Seems like the other types for UI are being wiped out:

Is global provided in your screenshot on line 60 (and isn't visible because of the intellisense box).
This is the first use of the ui property at the collections level isn't it?
Here's what I'm seeing

disregard my comment. I was thinking of the ui types for fields (validate, component, etc) not showing up. They don't show up here which is correct.

Maybe it needs to be wired up in the Admin UI?

Does formifyCallback currently run for stuff in the admin? I don't see where that would be happening?

No, I don't think it is being called. It might added. The other properties work like validate, component, etc, so it would be nice if this one worked in admin as well.

@logan-anderson if formifyCallback doesn't currently operate at the admin I'd like to continue that behavior and not support it there. The idea is that a form in the "global" sidebar is contextual, which wouldn't make sense in the admin.

@logan-anderson if formifyCallback doesn't currently operate at the admin I'd like to continue that behavior and not support it there. The idea is that a form in the "global" sidebar is contextual, which wouldn't make sense in the admin.

Yup! makes sense to me.


Prevent CookieOverflow errors for large urls

This occurs if an unauthenticated user requests an excessively long url. This was a problem I encountered with large forms that were submitted via GET and user sessions timing out. Granted, it's an edge case, but the fix is quite simple.
Thoughts?

Thanks, @danielfone, for your work on this, and @josevalim for maintaining this project. I appreciate you guys' work!
@josevalim can @danielfone's solution be improved at all? It seems like a rails app implementing devise would 5xx with ActionDispatch::Cookies::CookieOverflow if anyone submits at any random path that's too long for the cookie store. (Let me know if I am missing anything!)

@danielfone Interesting! That makes sense. I am getting that on all endpoints, even the ones that don't require authentication. I'll investigate further. Maybe something with how we have configured devise.
Thanks for your help 👍

The suggested monkeypatch by @danielfone doesn't seem to work anymore.
Does anyone have an updated version?


Decide about "call" API

Currently, a session.call will return a boost::future that resolves to boost::any.
We need to handle the cases where the RPC returns a anyvec, anymap or anyvecmap.
We might also need to handle how to return call result details ..

This is no longer applicable. The call result details can just be returned through the wamp_call_result. I have added support for call options on my fork including progressive call results.


JobExecutor should use an ExecutorService

as of version 4.x, the JobExecutor is a helper class with a static method execute to call method call on the Callable object Job. This is pretty basic and does not start a thread to run the job.
The JobExecutor should use an executor service behind the scene and allow to :

run a job synchronously and get a JobReport
run a job asynchronously and get a Future<JobReport>
run multiple jobs in parallel
gracefully shutdown the job executor

The JobExecutor class should be configurable with the number of worker threads at construction time.
The static method JobExecutor.execute should become non static.

implemented in a17ea8c4fa66d4763de6e5b388fd469909706d42


Nvidia gpu power in k8s!

So here is the followup on the PR #2478. This setup uses container_engine_accelerator.  Currently only Ubuntu Xenial (16.04) is supported.
To enable gpu capabillity set the following vars
all.yml
docker_storage_options: -s overlay2

k8s-cluster.yml
## Container Engine Acceleration
## Enable container accelartion feature, for example use gpu acceleration in containers
container_engine_acceleration_enabled: true
## Nvidia GPU driver install. Install will by done by a (init) pod running as a daemonset.
## Array with nvida_gpu_nodes, leave empty or comment if you dont't want to install drivers.
## Nodes won't get labels gpu labels if they are not in the array.
## Important: this should be set in all.yml 'docker_storage_options: -s overlay2'
nvida_gpu_nodes:
  - kube-gpu-001
## flavor can be tesla or gtx
nvida_gpu_flavor: gtx

This will label the nodes correctly (also setup taint for only scheduling gpu jobs to gpu). There is a container that installs the driver.
The container provided by the https://github.com/GoogleCloudPlatform/container-engine-accelerators is a bit simple and does not survive reboots. I've updated it and created a PR (https://github.com/GoogleCloudPlatform/container-engine-accelerators/pull/70)
For now the container to install the drivers can be found here: atzedevries/nvidia-ubuntu-driver-installer:10
I'm planning to add support for CentOS next.

there is currently a issue with scheduling (device plugin service is not detecting gpu's) and i'm working on it.

cc @squat

Google Updated their install container so it survives reboots. Set this as default install container. Also fixed a typo, but appierently GTX cards install correctly under TESLA drivers..

In case you are interested, we (NVIDIA) has just released a new set of container images on DockerHub:
https://hub.docker.com/r/nvidia/driver/
These images already bundle the driver installer and has prebuilt objects for the latest kernel supported by the distribution. If you are running the same kernel, installing the driver should only be a matter of seconds.
We have documentation on our wiki:
https://github.com/NVIDIA/nvidia-docker/wiki/Driver-containers-(EXPERIMENTAL)
You can find technical details in this presentation:
https://docs.google.com/presentation/d/1NY4X2K6BMaByfnF9rMEcNq6hS3NtmOKGTfihZ44zfrw/edit?usp=sharing

@flx42 I am happy to see NVIDIA adopting these approaches! From reading the slides and wiki I see that this new driver container currently relies on the NVIDIA container runtime, correct? For simplicity and maintainability, I am not sure Kubespray should be installing new runtimes.

@squat the driver container load the kernel modules and also expose the user-space driver libraries on the host through mount propagation. Technically you could use any method afterwards to enable GPU support in the runtime as long as you can point to this folder.
Also, when using CRI-O you can just register a hook, no need to swap the default runtime.

Ah I see. That’s in line with the model of other GPU installers :+1: the slides seemed to specifically indicate the NVIDIA runtime but I see now that was just implementation detail. That sounds like a good option for the OSs that NVIDIA is targeting with the builds.

@squat So i want to reopen the discussion on the extra initcontainer which unload the nouveau module. While working on the Centos version i ran into a issue unloading the nouveau module, it caused a reboot of the system. So to get is PR working i think it might be better to remove this unloading and add a readme with a how to on how to disable nouveau. What do you think?
I've also got the CentOS driver install working, but i want to rename a few variables, so a new commit on this will be comming soon.

I've been trying some stuff with the nvidia container-driver-installer. It seems really good and usefull if nvidia support installing drivers for ubuntu/centos. I also like the automatic update feature with dkms.
I don't (yet) see how it is usefull at the moment since k8s nvidia device plugin daemon requests a specific directory format which the nvidia container-driver-installer does not provide. The k8s nvidia device plugin daemon requests a bin/nvidia binaries and a lib64/nvidialibs and mounts them into the pod at the location which is requested by for example the nvidia/cuda:9.2 (https://gitlab.com/nvidia/cuda/blob/ubuntu16.04/9.2/base/Dockerfile) .
@flx42 and @squat do you agree on this, or am i missing something?

So i think this PR is pretty much ready.
I've removed the nouveau unload init container. I have a centos install container. I can deliver a Dockerfile for it so you can host until GCP will host it by them selves.
I can also provide a ansible playbook which disabled nouveau.

GCP won't build and test a CentOS driver installer:
https://github.com/GoogleCloudPlatform/container-engine-accelerators/pull/91

can we merge this?
Could you add a CI test on GCE ?

/assign ant31

please rebase

Is this able to be merged?

so vacation is over, time to get this fixed ;)

ci check this

/lgtm

https://gitlab.com/kargo-ci/kubernetes-incubator__kubespray/-/jobs/96868630

@AtzeDeVries can you reach me on the kubernetes slack @ant31

so this is now merged in #3304 . So i'll close this.


Class given does not implement DataObject::class

This is what I'm doing
`
class SignupData extends Data
{
public function __construct(
    readonly public string $email,
    readonly public string $password,
    readonly public string $first_name,
    readonly public string $last_name,

    #[DataCollectionOf(ServiceData::class)]
    readonly public DataCollection $personal_service_data,
) {
}

}`
And this is my ServiceData Class
`
class PersonalServiceData extends Data implements DataObject
{
public function __construct(
    readonly public string $dob,
    readonly public string $state,
    readonly public string $gender,

) {
}

}`
This is throwing me this following error:
Spatie\LaravelData\Exceptions\CannotFindDataClass: Class given does not implement DataObject::class in file /vendor/spatie/laravel-data/src/Attributes/DataCollectionOf.php on line 17
I have tried implementing the DataObject Class to both of these classes but the issue was not fixed.

Please do not create an issue when you've already created a discussion about the topic.


add Dependabot

To add Dependabot to a project, create a dependabot.yml file in project root. Configure it to check for updates in project's dependencies, and set up notifications for automated pull requests. Dependabot will then help keep dependencies up-to-date, enhancing project stability and security.

What are all the data dependabot.yml contains ?

A dependabot.yml file contains configuration data for Dependabot, an automated dependency management tool. It specifies details like which package managers to monitor, update schedules, and version constraints. This YAML file defines how Dependabot identifies and updates dependencies in a project, allowing users to customize the automated updating process.

Hi, @Akshayp02 I can see you closed this issue. Could you please check the PR which is attached to this issue?


F# requiring assembly binding redirects for FSharp.Core

I'm trying to benchmark some F# code. However, to work properly, the F# application requires an assembly binding redirect (App.config):
<?xml version="1.0" encoding="utf-8" ?>
<configuration>
  <runtime>
    <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
      <dependentAssembly>
        <assemblyIdentity name="FSharp.Core" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
        <bindingRedirect oldVersion="<IP_ADDRESS>-999.999.999.999" newVersion="<IP_ADDRESS>" />
      </dependentAssembly>
    </assemblyBinding>
  </runtime>
  <startup>
    <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.5.2" />
  </startup>
</configuration>

The supportedRuntime parts are not desirable of course, but if the assembly binding isn't done, the auto generated application will fail at runtime. The app.config generated won't include anything like this.
I'm not sure how to work around it, or suggest it could be fixed. Taking the app.config from the host app if one exists seems vaguely possible, but a bit random and risky, there's no reason why it should really be correct. Being able to specify app.config elements might be possible I guess...

If it helps to see this in-situ, the project i'm trying to benchmark is here: https://github.com/kolektiv/chiron/tree/benchmarks - https://github.com/kolektiv/chiron/tree/benchmarks/tests/Chiron.Benchmarks being the relevant project.
If you want to try and run that, you'll need to restore the packages first. The build.cmd in the root should sort all of that out and get a build done to start with.

Last bit of info, to confirm the thinking - if I build a version of BenchmarkDotNet which includes that assembly binding in the templated app.configs, the benchmark will run fine. I'm not sure how easy it will be to come up with an elegant fix though, I'll think on it.

Assembly binding redirects can be auto-generated. I used <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>  to get it working.
Some explanation

This still doesn't seem to actually work for me. Looking at the app.config generated there are no binding redirects, and without them the program simply fails. Auto generate binding redirects doesn't appear to do anything in this case!

The actual example where I'm seeing this: https://github.com/kolektiv/freya-benchmarks
Running build.cmd should pull down all appropriate dependencies, etc.

It is quite long story. For 0.9.5 I added fix for that. The problem was that you needed MSBuild 12/14 to get it working, which our .NET 4.5/4.6 taget was referencing. If you added depndency to our .NET 4.0 lib, then it did not work because we used MSbuild.v4 there.
Then we moved from dnx to dotnet cli for 0.9.7 and we were not able to target different versions of the same assembly, so we have removed our 4.5 and 4.6 targets. So it stopped working again for 0.9.7.
Now we will do this on our own, independent from installed MSBuild version. However if you don't want to wait for 0.9.8 which will have the fix you can downgrade to 0.9.5/0.9.6 for now.


Conflicting transactions involving mutual calls between contracts lead to memory-related issues

Describe the bug
I created two conflicting contracts to test the parallel mechanism of FISCO BCOS. They recursively call each other, and when a large number of conflicting transactions are submitted, rollbacks occur. During this process, server memory sharply increases, eventually exceeding the memory limit and leading to the system killing the nodes.
To Reproduce
Steps to reproduce the behavior:

create two conflicting contracts

// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.0;

import "./ContractOfRecursiveTwo.sol";

contract ContractOfRecursiveOne {
    function recursiveCall(address contractAddress, uint256 count) public {
        if (count == 0) {
            return;
        }
        ContractOfRecursiveTwo(contractAddress).recursiveCall(address(this), count - 1);
    }
}

// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.0;

import "./ContractOfRecursiveOne.sol";

contract ContractOfRecursiveTwo {
    function recursiveCall(address contractAddress, uint256 count) public {
        if (count == 0) {
            return;
        }
        ContractOfRecursiveOne(contractAddress).recursiveCall(address(this), count - 1);
    }
}

Write stress testing code similar to java-demo-sdk, which concurrently executes conflicting transactions involving recursive calls between two contracts

Expected behavior
A large number of transactions were rolled back, and the server memory usage increases rapidly. Ultimately, the nodes exceed the memory limit and are killed by the system.
Screenshots

Environment (please complete the following information):

OS: Ubuntu 20.04
FISCO BCOS Version 3.5.0

感谢反馈 👍
3.6.0已经pre-release，修复了一些内存问题。如果有时间可帮忙在3.6.0中再次验证一下是否已修复？


Fix for raspberry pi build - issue #12

A cleaner fix for the build issue observed at #12

Removed unncessary arg params in docker-compose and Dockerfile

Known perm issue with log - will take a look later today

This is ready to be merged providing we are happy.
I've removed the files:

crontab-docker-host
docker-compose.yml

The dockerfile has been modified such that you simply have to provide the "username/password/host num/debug lvl" args when running the image.
As they weren't really doing anything. Added an easy to follow shell snippet to the README for docker users to follow.


python3Packages.hatasmota: 0.2.10 -> 0.2.11

Motivation for this change
Update to latest upstream release 0.2.11
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 121127 run on x86_64-linux 1

3 packages built:

home-assistant
python38Packages.hatasmota
python39Packages.hatasmota

Result of nixpkgs-review pr 121127 at 1a3b58e7 run on aarch64-linux 1

3 packages built successfully:

home-assistant
python38Packages.hatasmota
python39Packages.hatasmota


Heading lineRule not set properly: h2 and h1 on multiple lines overlap

When H1 or H2 covers multiple lines, the space between two lines is too small. Second line touches or overlaps.

Steps to reproduce:

Generate a DOCX with a long h1 or h2, on multiple lines.
Convert if to PDF with libreoffice cli: soffice --headless --convert-to pdf test.docx

If I open the document with Word (16.55) do any change and save it, then I can convert it to PDF without any issue.
I suspect there must be some incompatibility in the way to document is generated by this lib.
Here's the h2 part of document.xml generated by this lib:
<w:p>
      <w:pPr>
        <w:pStyle w:val="Heading2"/>
        <w:spacing w:lineRule="exact"/>
      </w:pPr>
      <w:r>
        <w:rPr/>
        <w:t xml:space="preserve">I AM A VERY VERY VERY VERYVERY VERYVERY VERYVERY VERY LONG H2</w:t>
      </w:r>
    </w:p>

And same bloc on the same document after a new save in Word:
<w:p>
      <w:pPr>
        <w:pStyle w:val="Heading2"/>
      </w:pPr>
      <w:r>
        <w:rPr/>
        <w:t xml:space="preserve">I AM A VERY VERY VERY VERYVERY VERYVERY VERYVERY VERY LONG H2</w:t>
      </w:r>
    </w:p>

The only difference is the <w:spacing w:lineRule="exact"/> param.
From what I understand fron the OpenOffice XML documentation, it should be set to "auto" to avoid this problem.
I'll be happy to submit a PR but since I'm not an expert in OpenXML, I'd prefer if someone could validate my theory before I work on this PR.
For reference, here's where lineRule is set:
https://github.com/privateOmega/html-to-docx/blob/5e15d93fa5ae8fce0e63753244441ce552878642/src/helpers/xml-builder.js#L626

Has anyone seen this issue? I'm happy to work on a PR, just need to know if it will be merged.

@svandegar Yes I can merge it, thanks.

Hi!

Could you please attach sample inputs here as well?

@privateOmega Do you mean html strings? Any with h1 should do since upper part of letters disappears.

lorem ipsum


Setting the FSharp.analyzersPath settings option has no effect

Describe the bug
Setting the FSharp.analyzersPath settings option has no effect. It still looks for analyzers in the default locations.
To Reproduce
Steps to reproduce the behaviour:

Install the Npgsql.FSharp.Analyzer through paket on linux and the analyzer was installed to packages/analyzers
Override the FSharp.analyzersPath option to "packages/analyzers"
Observe from logs that the analyzer search path is still "packages/Analyzers", "analyzers"
Rename packages/analyzers to packages/Analyzers
Observe that the analyzer dlls are discovered.

Expected behaviour
Analyzers should be loaded from the analyzerPaths option.
Screenshots
setting.json
"FSharp.enableAnalyzers": true,
"FSharp.verboseLogging": true,
"FSharp.enableBackgroundServices": true,
"FSharp.analyzersPath": [
    "./packages/analyzers"
]

Logs after manually renaming packages/analyzers to packages/Analyzers.
3 dlls found
[03:46:27 VRB] [Checker] Current Queue Length is 0
[03:46:27 INF] [Checker] ParseAndCheckFileInProject - /home/admin/fshpg2/Program.fs
[03:46:27 INF] [Analyzers] Using analyzer roots of ["packages/Analyzers", "analyzers"]
[03:46:27 INF] [Analyzers] Loading analyzers from /home/admin/fshpg2/packages/Analyzers
[03:46:27 INF] [Compiler] Inside Compiler Function 3
[03:46:28 INF] [Analyzers] From packages/Analyzers: 3 dlls including 1 analyzers
[03:46:28 INF] [Analyzers] Loading analyzers from /home/admin/fshpg2/analyzers
[03:46:28 INF] [Analyzers] From analyzers: 0 dlls including 0 analyzers

Environment (please complete the following information):

OS: Debian bullseye/sid
Ionide version: 4.8.1
VSCode version: 1.43.2
dotnet SDK version: 3.1.100
mono / .Net Framework version: <IP_ADDRESS>
paket version:  5.242.2 (installed as global tool)

Additional context
I have tried clearing packet cache and also ionide project cache and reloading the project.
netcoreapp3.1

CC: @baronfel


Checking for necessary require on _spec files

We want to add rubocop check for our rails _spec files that will check if the necessary
require "spec_helper" or require "rails_helper" exists on files
This is usually not a problem if you run the entire rails spec suite but could be if one file does not have the specific require and you run that individually
How can I accomplish that?
Is this a new feature or rubocop-rspec already supports this? I couldn't find any information

Hi @danielnc. There's no cop that I know of that would enforce that, but you might consider adding rspec configuration to your project so that you don't have to. If you add a .rspec file, rspec will look for this before every test run and use the arguments you specify.
Sample .rspec contents that would always require your spec_helper.rb
--require spec_helper

I came looking for this too; thanks for the (much better) solution of configuring it via the .rspec file.
On the back of this, I had some thoughts;

I wonder if it's equally useful to have a cop to identify redundant require statements in cops (when the .rspec file already requires the file globally). Perhaps there is a valid use case to have the same require defined in the file itself too - I can't think of one.
If (as hinted in @danielnc's original question) he wanted to explicitly require either rspec_helper or spec_helper (depending on the context of the spec file), that could be a different problem for which a cop could be useful. Just speculation; it's not something I'm doing at the moment, anyway.


Add a news section to the homepage

I think the homepage should have a news section at the top of it. It makes it easier to see what's new with the engine without having to always click on the news page and also makes the page look more "active".
Screenshots (greatly appreciated if it’s a style issue)
Example of what I mean

im still thinking on the best way to add this, will arrive soon.

I agree we need this, currently the only way to notice new articles is to visit the News page manually, or use RSS.

soon is a relative term, 512ebd976dd980ffee48a847f65b9c8135d2b752


Error when selecting an item in a picker

invariant.js:39 Uncaught Invariant Violation: Ended a touch event which was not counted in trackedTouchCount.
This breaks all other interactions, buttons etc.
Reproducible in the UIExplorer

I have done some more investigation. The problem is not equal in all browsers, It seems chrome is the culprit. <select> and <option> elements don't dispatch events for mousedown, but do for mouseup. breaking react's ResponderEventPlugin. I have tried several workarounds but nothing works so far, I may have to make my own drop down component that doesn't use <select> or <option>

If the problem is reproduce we will reopen issue.


Release 1.0

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##             master    #17   +/-   ##
=======================================
  Coverage       100%   100%
- Complexity       71     72    +1
=======================================
  Files             3      3
  Lines           136    138    +2
=======================================
+ Hits            136    138    +2

Impacted Files
Coverage Δ
Complexity Δ

src/Validator.php
100% <100%> (ø)
33 <33> (+2)
:arrow_up:

src/SegmentChecker.php
100% <100%> (ø)
14 <12> (-1)
:arrow_down:

src/Expression.php
100% <100%> (ø)
25 <22> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c95954e...e05d626. Read the comment docs.


Pre-built browser version in README doesn't exist

If you want to use Lolex in a browser you can use the pre-built version available in the repo and the npm package. Using npm you only need to reference ./node_modules/lolex/lolex.js in your

Oh, it does exist, but only for us maintainers ;-) Sorry about that. Changed edit to blob in the PR. Thanks for the heads up!

:) thanks!


Add cmin parameter to the Histogram2D class.

This PR proposes the addition of the cmin parameter to the class Histogram2D to be able to modify the cmin parameter of the matplotlib.pyplot.hist2d function called by the data method.
This addition allows to avoid the display of bin with less counts than the cmin value. This will allow to modify the parameter externally, being able to make the background transparent and selecting afterwards the background color by setting the facecolor of the matplotlib axis.

Hi @zoccoler! I opened this PR as discussed. It's a small modification but others can benefit also from this. Please let me know if you want me to modify something and I'll update the PR.

Hi @bruno-pannunzio ,
Thanks for contributing here! I just changed the version and will merge now.
Please test it if it is useful for the napari-phasors and let me know, so that I make a new release here.
For the moment, please clone the repo, install the dev version and use the main branch to do the tests.

Awesome!!


Allow configuring extra dependencies directory for functions

Motivation
Functions offer interfaces (e.g. SecretsProvider) for users to provider their own implementations.
In order for runtime to load those customize implementation, we should allow users configuring extra dependencies.


show file location

currently not totally clear if a file is in cache or user folder, I think user/shared might show this?

#12


This module doesn't work anymore

I mean it dependencies have updated A lot and there are many breaking changes
webpack              ^4.29.3  →  ^5.74.0
webpack-cli           ^3.1.0  →  ^4.10.0
webpack-dev-server    ^3.1.5  →  ^4.11.1

I guess you shouldn't have used webpack then 😝
simply use --target web I suppose.

You can still run it using
node v12.22.12
npm 6.14.16

I used nvm install 12 and nvm use 12 to quickly install node 12.

Yes this template needs to be either updated or the tutorial and web book on rust+wasm (game of life) should not recommend this template. I have had to switch to using --target web instead

Has anyone found any good alternatives?

Please look at the changes in this PR-208 which helps resolve this issue.

With latest Node version: v20.11.0 and following dependencies it runs clean.
package.json:
"dependencies": {
"wasm-game-of-life": "file:../pkg"
},
"devDependencies": {
"copy-webpack-plugin": "^12.0.2",
"webpack": "^5.90.1",
"webpack-cli": "^5.1.4",
"webpack-dev-server": "^4.15.1"
}
And webpack.config.js should be replaced with:
const CopyPlugin = require("copy-webpack-plugin");
const path = require('path');
module.exports = {
entry: "./bootstrap.js",
output: {
path: path.resolve(__dirname, "dist1"),
filename: "bootstrap.js",
},
mode: "development",
experiments: {
syncWebAssembly: true // Enable WebAssembly experiments
},
plugins: [
new CopyPlugin({
patterns: [
{ from: "index.html", to: "index.html" }
]
})
],
};

what @ratulb suggested works. is this project not supported anymore?

Seems this book is unmantained

my solution (it's weird but works for me):
on your wasm-game-of-life directory,

npm install -g create-wasm-app
new a package.json file in root dir:

{
  "dependencies": {
    "create-wasm-app": "/usr/local/lib/node_modules/create-wasm-app"
  }
}

npm install
npm init wasm-app www
🦀 Rust + 🕸 Wasm = ❤

my environment:
npm verbose os Darwin 21.6.0
npm verbose node v22.5.1
npm verbose npm  v10.8.2

my solution (it's weird but works for me):
on your wasm-game-of-life directory,

npm install -g create-wasm-app
new a package.json file in root dir:

{
  "dependencies": {
    "create-wasm-app": "/usr/local/lib/node_modules/create-wasm-app"
  }
}

npm install
npm init wasm-app www
🦀 Rust + 🕸 Wasm = ❤

my environment:
npm verbose os Darwin 21.6.0
npm verbose node v22.5.1
npm verbose npm  v10.8.2

works for me but you have to change the folder of create-wasm-app to /Users/YOUR_NAME/.nvm/versions/node/v22.8.0/lib/node_modules/create-wasm-app if you're under nvm.


Showing loading while subscriptions are loading

What are options to show loading screen for bloc integration?
Current UX looks junky as user first sees a page without subscription and then it suddenly reloads with all subscriptions loaded from linkfive.
I tried to use fetchProducts in init and show loading spinner myself. However, when I did that and showed paywall only when loading is finished paywall calls loadSubscriptions again which causes the screen to blink once.
I made a video for both cases:

Flickr when fetchProducts is called manually
lack of loading state when relying on paywall to call loadSubscriptions itself.

Hey @Maxim-Filimonov thanks for reporting the issue!
Will investigate the blinking issue! But it indeed looks a bit strange when you just want to offer 1 product. I've started to work on a new screen for single products. It would be much cleaner but it's still under development yet.

@AlexanderThiele any updates?


typo: deploly -> deploy

@nschonni : Thanks for your contribution! The author, @rkarlin, has been notified to review your proposed change.

@nschonni Thank you.
Merging the typo fixes.


Frequent disconnects / requiring kill openvpn process and restart script (autoreconnect fails)

Every hour or two namespaced-openvpn drops it's connection without any clear reason. Normally it will automatically reconnect declaring Initialization Sequence Completed, but in these cases it never completes the reconnect. I have to manually kill the openvpn process and relaunch the script in order to reconnect every few hours.

Are you sure this isn't just an issue with your network connectivity, or your VPN provider?

It is probably the VPN provider. It would be great if I could force an auto reconnect every hour, maybe I'll try a script. Thanks.


support consul service discovery

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.chengguozhu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Please provide description of what this lib does and include usage docs/examples in Readme ;)

Thanks! Came here from https://github.com/pmndrs/jotai/issues/13 and https://github.com/pmndrs/jotai/issues/44

Hello Kristian,
Thanks for the feedback, yes, a Readme was really needed.
I’ve made one now.


Propagate schema to all operators

Propagate the schema information to all the operators. This PR shows that this works, using HashJoin, Projection, and Sink (with a minor change in WordCloud). Also, a pan-operator refactor that just passes in the SchemaInfo to all of them, from the WorkflowCompiler.
At the moment, no other operators consume the SchemaInfo (apart from the above mentioned ones), they just receive it. I will raise another PR for all the other operators.
Major Changes:

Refactored all operators to receive an object called SchemaInfo, which is a POJO-like object with input schemas and output schema.
Added new API on BuilderV2 to accept details related to an attribute and construct it, and then add.
Made the schema conforming requirement loose, when passing in a whole Tuple. It's still open as to whether I create an overloaded API or another parameter like strictSchemaMatch that defaults to true that does this loose matching. This mechanism is meant to avoid the need for a remove API on BuilderV2, as you can see in the ProgressiveUtils change.

Two other changes that I had to do. And I feel these changes are making the code more coherent and consistent, and leaving less room for error:

Added #@1 instead of 1 for the output of the HashJoin for duplicate attribute names, as it wasn't conforming to the schema.
Changed WordCloud's schema to have count instead of size as the output attribute name. Front-end was expecting count, but backend was passing count once and size another time.

@maazadeeb sorry I have just merged one PR that caused conflicts. If you have trouble fixing the conflicts, please let me know.
Also, I wonder, I am not following the details here yet, what is the new standard way to pass or expect schema information during runtime (in processTexeraTuple)? Maybe we can document such a standard way somewhere, or can you point me to an example operator code?

@maazadeeb sorry I have just merged one PR that caused conflicts. If you have trouble fixing the conflicts, please let me know.
Also, I wonder, I am not following the details here yet, what is the new standard way to pass or expect schema information during runtime (in processTexeraTuple)? Maybe we can document such standard way somewhere, or can you point me to an example operator code?

@Yicong-Huang Hey no problem. I will fix them. Shouldn't be too hard. Yes, I will write docs for how to use what I'm writing. For now, the Tuple continues to have a Schema. So you can access it using tuple.getSchema().


python3Packages.dulwich: 0.21.5 -> 0.21.6

Changelog: https://github.com/dulwich/dulwich/blob/dulwich-0.21.6/NEWS
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

That isn't really a mass rebuild, I think?

I agree, a grep does not show too many occurences:
$ grep -Flr dulwich pkgs | sort | xargs grep -Fc dulwich
pkgs/applications/networking/errbot/default.nix:1
pkgs/applications/version-management/rabbitvcs/default.nix:1
pkgs/development/python-modules/breezy/default.nix:2
pkgs/development/python-modules/dulwich/default.nix:5
pkgs/development/python-modules/dvc-studio-client/default.nix:2
pkgs/development/python-modules/hg-git/default.nix:2
pkgs/development/python-modules/klaus/default.nix:2
pkgs/development/python-modules/openstackdocstheme/default.nix:2
pkgs/development/python-modules/scmrepo/default.nix:2
pkgs/development/python-modules/simplekv/default.nix:2
pkgs/development/tools/poetry2nix/poetry2nix/overrides/build-systems.json:1
pkgs/development/tools/poetry2nix/poetry2nix/pkgs/poetry/poetry.lock:64
pkgs/development/tools/poetry2nix/poetry2nix/pkgs/poetry/pyproject.toml:1
pkgs/development/tools/reno/default.nix:1
pkgs/servers/web-apps/netbox/generic.nix:1
pkgs/servers/xandikos/default.nix:1
pkgs/tools/package-management/poetry/unwrapped.nix:2
pkgs/top-level/python-packages.nix:1

@ofborg build xandikos

Superseded by #253612.


Remove Django 1.4, and Python 2.6 and 3.2 support

:+1:

I'm not sure what's wrong with the merge build. I'm going to merge it in and see if it clears up on master.


fixed background colour algorithm

Fixed background colour rgb section checking causing a runtime error

LGTM! Thanks for finding this :)


add @throw tags to docblock

Fixes
Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation about the functionality in the appropriate .md file
[ ] I have added in line documentation to the code I modified

Short description of what this PR does:

add @throws to docblock

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.ipoul seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


csv export fails with "database is locked"

Describe the bug
Attempting to export two tables using csv, we consistently get a crash with database is locked.
To Reproduce
We're running in an alpine-based docker image, x64. Our ./export folder is an NFS mount (EFS).
We've run the same on local linux x64 and darwin ARM machines without issue, using the relevant binaries.
Config:
api:
    proxy_url: ""
    tls_cert: ""
    tls_skip_verify: false
    url: https://api.safetyculture.io
csv:
    max_rows_per_file: 1000000
db:
    connection_string: ""
    dialect: mysql
export:
    action:
        limit: 100
    incremental: true
    inspection:
        archived: "both"
        completed: "true"
        included_inactive_items: false
        limit: 100
        skip_ids: []
        web_report_link: private
    media: false
    media_path: ./export/media/
    modified_after: ""
    path: ./export/
    site:
        include_deleted: false
        include_full_hierarchy: false
    tables: ["inspections", "inspection_items"]
    template_ids: []
report:
    filename_convention: INSPECTION_TITLE
    format:
        - PDF
    preference_id: ""
    retry_timeout: 15

Logs:
2022-10-18T16:53:11.290Z	INFO<EMAIL_ADDRESS>Exporting data by user: <redacted>
2022-10-18T16:53:11.291Z	INFO<EMAIL_ADDRESS>... queueing inspection_items
2022-10-18T16:53:11.291Z	INFO<EMAIL_ADDRESS>... queueing inspections
2022-10-18T16:53:11.330Z	INFO<EMAIL_ADDRESS>exporting	{     "feed": "inspections",     "org_id": "<redacted>",     "modified_after": "Tue, 18 Oct 2022 08:07:24 UTC",     "web_report_link_type": "private" }
2022-10-18T16:53:11.338Z	INFO<EMAIL_ADDRESS>exporting	{     "feed": "inspection_items",     "org_id": "<redacted>",     "modified_after": "Thu, 10 Jun 2021 01:36:00 UTC" }
2022-10-18T16:53:11.904Z	INFO<EMAIL_ADDRESS>export batch complete	{     "estimated_remaining": 0,     "duration_ms": 438,     "export_duration_ms": 0 }
2022-10-18T16:53:12.189Z	INFO<EMAIL_ADDRESS>writing out CSV file	{     "feed": "inspections" }
2022-10-18T16:53:17.934Z	ERROR<EMAIL_ADDRESS>github.com/SafetyCulture/iauditor-exporter/internal/app/feed/exporter_sql.go:115 database is locked
[5567.463ms] [rows:878] INSERT INTO `inspection_items` (`id`,`item_id`,`audit_id`,`item_index`,`template_id`,`parent_id`,`created_at`,`modified_at`,`exported_at`,`type`,`category`,`category_id`,`organisation_id`,`parent_ids`,`label`,`response`,`response_id`,`response_set_id`,`is_failed_response`,`comment`,`media_files`,`media_ids`,`media_hypertext_reference`,`score`,`max_score`,`score_percentage`,`combined_score`,`combined_max_score`,`combined_score_percentage`,`mandatory`,`inactive`,`location_latitude`,`location_longitude`) VALUES (...) ON CONFLICT (`id`) DO UPDATE SET `item_index`=`excluded`.`item_index`,`template_id`=`excluded`.`template_id`,`parent_id`=`excluded`.`parent_id`,`created_at`=`excluded`.`created_at`,`modified_at`=`excluded`.`modified_at`,`type`=`excluded`.`type`,`category`=`excluded`.`category`,`category_id`=`excluded`.`category_id`,`organisation_id`=`excluded`.`organisation_id`,`parent_ids`=`excluded`.`parent_ids`,`label`=`excluded`.`label`,`response`=`excluded`.`response`,`response_id`=`excluded`.`response_id`,`response_set_id`=`excluded`.`response_set_id`,`is_failed_response`=`excluded`.`is_failed_response`,`comment`=`excluded`.`comment`,`media_files`=`excluded`.`media_files`,`media_ids`=`excluded`.`media_ids`,`media_hypertext_reference`=`excluded`.`media_hypertext_reference`,`score`=`excluded`.`score`,`max_score`=`excluded`.`max_score`,`score_percentage`=`excluded`.`score_percentage`,`combined_score`=`excluded`.`combined_score`,`combined_max_score`=`excluded`.`combined_max_score`,`combined_score_percentage`=`excluded`.`combined_score_percentage`,`mandatory`=`excluded`.`mandatory`,`inactive`=`excluded`.`inactive`,`location_latitude`=`excluded`.`location_latitude`,`location_longitude`=`excluded`.`location_longitude`
2022-10-18T16:53:17.959Z	FATAL<EMAIL_ADDRESS>Failed to write data to exporter: Unable to insert rows: database is locked

Context of the logs above: the sqlite database already has all the inspections and the process fails when it tries to write it out while still updating inspection_items.
Expected behavior
No failure.
Screenshots
The EFS file system metrics seem fine:

Desktop (please complete the following information):

OS: Docker on Amazon Linux (AMI amzn2-ami-ecs-hvm-2.0.20221010-x86_64-ebs), image node:16-alpine
Version 3.10.0

Probably happening due to some incompatibility between EFS and sqlite.
Exporting each table separately avoids the locking issue.
IAUD_EXPORT_TABLES=inspections ./bin/iauditor-exporter_... csv
IAUD_EXPORT_TABLES=inspection_items ./bin/iauditor-exporter_... csv

No longer seeing a deadlock after upgrading to 4.2.0.


Expose a method to return the session id from a runtime job

What is the expected feature or enhancement?
Provide a similar method to the job_id() method here which will return the session id of the job if the job is running as part of a session.
The sessionId is already exposed by the runtime API here
Acceptance criteria
A new method is exposed for runtime jobs which returns the sessionId of the job

While doing this it might also be nice to add the tags from the API to the RuntimeJob instance since you can set those when running a job then they should also be in the RuntimeJob instance when retrieving the job.


Log transform regression target: update automl to try both ways when applicable

Had convo with @bchen1116 and @chukarsten today about #2749, which tracks trying to improve the mathematical method we use in the log normal data check to recommend to users (and to automl) when to enable/disable log transformation for regression targets.
That work will continue, but filing a separate idea for improvement here:
If the data check recommends we apply log transform, perhaps automl should still try pipelines with both transformed and un-transformed targets, place all of those on the rankings leaderboard and let users select between them.
There's probably more complex heuristics we can try too now that we're moving towards @jeremyliweishih 's work on "DefaultAlgorithm": before scanning estimators, as part of the preprocessing/selection/eng discovery step, pick a pipeline to try both with and without log transform, and use the outcome of that experiment to decide whether automl should continue applying log transform for other pipelines or should just stop exploring that option.

Is this actually blocked by the automl algorithm upgrade? What if we add a hyperparameter to the LogTransform component called do_transform whose space is skopt.categorical(['yes', 'no']).
If no the AutoMLAlgorithm does not do the transform and if yes it does it.
The benefit of this approach is that it's not tied to a particular automl algorithm implementation and we delegate the decision of whether or not to do the transform to the tuner/optimizer as opposed to the DefaultAlgorithm.

Bumping my comment above. I don't think this is blocked by the automl algorithm upgrade and I don't think we need to manually add heuristics to determine whether or not the log transformer is worth exploring. If we expose wether or not the log transformer is run as a tunable hyperparameter,  the algo should make that decision for us?
@dsherry @bchen1116

Just wanted to document some thoughts and notes from our discussion during OH:
I love this idea a lot! I think this is a pretty nifty solution that would allow us to take advantage of the underlying optimizing algorithm without duplication of pipelines and without waiting for any additional algorithm changes. My main concern is that it might be difficult from a UX perspective to see a log transformer / detrender in the pipeline and understand that because do_transform is False, we don't actually do any transformations.
I also wonder if giving control to the optimizer means that it'll be difficult to bake in heuristics or our own decision-making about whether or not we want to add a specific component. @dsherry suggested that in a long, more extensive search, adding this hyperparameter might be harder to converge on an optimal solution.

@angela97lin Thanks for documenting the key points of our office hours discussion!
My plan is to write a design document that details/fleshes the proposals we talked about at OH:

The do_transform approach above.
Add pipelines with and without the component to the first batch of AutoMLSearch.
Add heuristics to our algorithm to pick out whether or not to add the component.

I'm planning to eventually meet with @dsherry to talk about what he has in mind for 3. I'll be happy to add you to that meeting if you'd like. My concern with 3 is that defining heuristics for whether or not to add these components is what prompted this issue in the first place!
My hope is that these approaches are not mutually exclusive. Maybe our UX ambitions for "fast" and "long" mode are compatible with 1. It's just a matter of which one we prioritize for "fast mode" (maybe by setting the default value of do_transform).

Another use case I just thought that is related to this issue:  the encoding strategy to use.
We have one hot encoding by default but target encoding may work better for some problems. I think we should eventually try both in AutoMLSearch and that will require making the same decision as LogTransformer/Detrender/etc.


fixing typo for navigationBarReducer

Pull Request Test Coverage Report for Build 587389936

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.678%

Totals

Change from base Build 509350601:
0.0%

Covered Lines:
249

Relevant Lines:
249

💛  - Coveralls


Setup integration testing

I want to setup automated integration testing

Ideally, I would like to utilize the web interface to conduct unit testing via QUnit framework


Update install procedure for Astarte Operator

Update the install procedure for Astarte operator as it can now be installed with helm.

Closed by #505


Remote Configuration

Reviewer: @jonathanKingston

Description:

Migrate the extension to the new remote config
Steps to test this PR:

Go through all the tests in http://privacy-test-pages.glitch.me/privacy-protections/index.html
All tests should appear the same as develop branch

Automated tests:

[x] Unit tests
[x] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

Nice thanks for cleaning this all up!


Copy edits for typos

Contributor's agreement previously signed.

Thank you @epc for fixing this!
Your changes look good.
One last thing before we can merge them: Unless you've done so before, could you please sign our contributor agreement http://rethinkdb.com/community/cla/ ? We require this for legal reasons before we can merge any changes.

Yes…as noted in my comment I've signed the CLA previously.

Oops missed that.
Merging. The fixes will go online as soon as we redeploy the website (this will happen on Monday I think).

@chipotle I merged this in. Hope I did so into the correct branch?

Yep, the master branch is the right one.


Fix documentation for plugin properties file

The sample which previously contained the properties file was removed since we
do not want to provide samples which do not use the conventional, supported method
of writing a plugin, java-gradle-plugin.
Instead, we leave the ‘behind the scenes’ documentation in-place, but hard-code
the content of the properties file, since no sample should need to include
the properties file itself.

@bot-gradle test BD

OK, I've already triggered the following builds for you:

BuildDistributions build

@bot-gradle test and merge

OK, I've already triggered a build for you.


Fix virtual products not being purchaseable due to missing shipping address

If only a virtual product is in the basket the shipping address is not set, this caused failure as required fields were not filled in. Change so that we use billing address if shipping address is not set and fail early if neither is set.

Tested and ok


Add common error notes due to locked IPs in Vivado

@Zhouzhou377 ran into a common error so I am documenting it in the docs.

The error can be resolved by following the instructions.


backup doesn't work

Since osixia/openldap-backup:1.2.3 is having some startup issue, I used 1.2.2 instead.
Here is my docker-compose.yaml. The two service works fine but ldap backup doesn't work.
No matter what cron expression I used, the backup folder is always empty.
version: '2'
services:
openldap:
image: osixia/openldap-backup:1.2.2
command: --loglevel debug
ports:
- "389:389"
- "636:636"
volumes:
- '/srv/ldap/database:/var/lib/ldap'
- '/srv/ldap/config:/etc/ldap/slapd.d'
- '/srv/ldap/backup:/data/backup'
environment:
- LDAP_ORGANISATION="riseye"
- LDAP_DOMAIN=riseye.com
- LDAP_ADMIN_PASSWORD=Initial0
- LDAP_BACKUP_CONFIG_CRON_EXP="0 0/5 0 ? * * *"
- LDAP_BACKUP_DATA_CRON_EXP="0 0/5 0 ? * * *"
networks:
- test
phpldapadmin:
image: osixia/phpldapadmin:0.7.2
ports:
- "6443:443"
environment:
- PHPLDAPADMIN_LDAP_HOSTS=openldap
networks:
- test
networks:
test:
external: true

That's exactly my issue, too.

I have the same problem with 1.2.5:
docker run --env LDAP_ORGANISATION="local.dev" `
    --env LDAP_DOMAIN="somecompany.com" `
    --env LDAP_ADMIN_PASSWORD="JonSn0w" `
    --env LDAP_BACKUP_CONFIG_CRON_EXP="0/5 * * * *" `
    --env LDAP_BACKUP_DATA_CRON_EXP="2/5 * * * *" `
    -p 389:389 `
    --volume $PSScriptRoot/database:/var/lib/ldap `
    --volume $PSScriptRoot/config:/etc/ldap/slapd.d `
    --volume $PSScriptRoot/backup:/data/backup `
    osixia/openldap-backup:1.2.5

No backup files are written.

I have the same issue with v 1.3.0, I don't see any cron start on the cron logs

I have the same problem with 1.2.5:
docker run --env LDAP_ORGANISATION="local.dev" `
    --env LDAP_DOMAIN="somecompany.com" `
    --env LDAP_ADMIN_PASSWORD="JonSn0w" `
    --env LDAP_BACKUP_CONFIG_CRON_EXP="0/5 * * * *" `
    --env LDAP_BACKUP_DATA_CRON_EXP="2/5 * * * *" `
    -p 389:389 `
    --volume $PSScriptRoot/database:/var/lib/ldap `
    --volume $PSScriptRoot/config:/etc/ldap/slapd.d `
    --volume $PSScriptRoot/backup:/data/backup `
    osixia/openldap-backup:1.2.5

No backup files are written.

Hi,
you have an issue with your cron expresion

--env LDAP_BACKUP_CONFIG_CRON_EXP="0/5 * * * *"
--env LDAP_BACKUP_DATA_CRON_EXP="2/5 * * * *"

you have to replace 0/5 & 2/5 with */5

--env LDAP_BACKUP_CONFIG_CRON_EXP="*/5 * * * "
--env LDAP_BACKUP_DATA_CRON_EXP="/5 * * * *"

You can validate a cron expresion via https://crontab.guru/

Hello, i'm using the 1.3.0 version, but the backup does not seem to be operating.
I've put the env var like this :
--env LDAP_BACKUP_CONFIG_CRON_EXP="* * * * *"
It's just to see if it will run, but the backup directory stay empty.
If i inspect the container, there's nothing in the crontab.
Does someone know which command is used to backup the openldap ?
Maybe we can make a derivative image and put the command again inside ?
Michaël

Hi I'm using 1.40 and I cant get the backups to work either -- the will run manually if invoked from the shell.
I see the cronjobs listed within /container/run/service/slapd-backup/assets listed as such:
# Backup OpenLDAP config
"0 */4 * * *" root /sbin/slapd-backup-config 2>&1 | /usr/bin/logger -t cron_backup_config

# Backup OpenLDAP data
"0 */4 * * *" root /sbin/slapd-backup-data 2>&1 | /usr/bin/logger -t cron_backup_data
# empty line

I can run both commands manually -- /sbin/slapd-backup-data and /sbin/slapd-backup-config and see the .gz files being created.  Other than running manually I do the jobs being run through cron.  Nothing shows in the logs.
I see the symbolic link located within /etc/cron.d/slapd-backup -> /container/run/services/slapd-backup/assets/cronjobs.
Is my expression in correct?
/var/log/cron only shows the following:
Dec 19 17:17:01 openldap CRON[374]: (root) CMD (   cd / && run-parts --report /etc/cron.hourly)
Dec 19 18:17:01 openldap CRON[379]: (root) CMD (   cd / && run-parts --report /etc/cron.hourly)
Dec 19 19:17:01 openldap CRON[385]: (root) CMD (   cd / && run-parts --report /etc/cron.hourly)
Dec 19 20:17:01 openldap CRON[390]: (root) CMD (   cd / && run-parts --report /etc/cron.hourly)

This issue is still persists in latest image


WMS-V Video Tile Rendering

I have developed in the distant past (2013) something we like to call WMS-V or Video Tiling. The idea is to provide videos instead of image tiles. This way time-series raster data can be visuaised on a map. In theory one can zoom and pan while the video is playing.
A proof of concept implementation (only works in Firefox) exists here:
http://npm.landcareresearch.co.nz/possums/anim/experiment.php
I propose to do a modernisation of the tool in OpenLayers 3. It is possible to render videos in a WebGL context as can be seen here: https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/Tutorial/Animating_textures_in_WebGL
I will attempt to implement it myself, but would be even more happy if I got some help and eventually accepted in form of pull requests. I will do my best to adhere to the guidelines etc.
Please indicate interest here and let me know if you are interested in helping or have a better implementation.

@geekdenz thanks for expressing your interest and intent to work on this.  I've also been planning on implementing video tile support.  Nothing specific to WMS though.  And I intend to focus on the Canvas (2D) renderer.  It could be a nice division of the work if you wanted to implement anything WMS specific or wanted to work on WebGL support.
I imagine it will take some experimentation to decide on the best way to expose playback control.  It is tempting to think of video sources being configured with start and end times (as Date).  And then the view could be given a time property.  Things will get sloppy if multiple video sources are added to a map with different playback rates.

@tschaub Thanks for your quick reply! As there is no funding for this work from my employer at the moment, I will/would have to do anything related to this on my own time, which may significantly slow me down. However, I'm quite keen on this feature whether WebGL or Canvas doesn't matter so much. Performance and stability are key though. If you need a backend service, please don't hesitate to use our data:
var proj2193 = new OpenLayers.Projection("EPSG:2193"),
        possumLayer = new OpenLayers.Layer.VideoWMS("Possum Videos", "http://npm.landcareresearch.co.nz/possums/anim/videoproxy.php?", {
              //map: "/opt/mapserver/mapfiles/possum_density.map",
              layers: "possum_videos_cache_nztm",
              transparent: "true",
              format: "image/png"
            }, {
              visibility: true//,
              //tileClass: OpenLayers.Tile.Video
            });

is the relevant OpenLayers 2 code. There an extension of WMS was used, but better for performance may well be canvas or webgl. I had problems with synchronizing the videos on the client.
You can find the code here:
https://github.com/geekdenz/openlayers/blob/videowms/lib/OpenLayers/Layer/VideoWMS.js
https://github.com/geekdenz/openlayers/blob/videowms/lib/OpenLayers/Tile/Video.js

Oh, and some examples are here:
http://npm.landcareresearch.co.nz/possums/anim/

If someone has time to review my commit please, I would appreciate it. I ran make lint and it passed. However, if I'm doing something else majorly wrong, please tell me now so I do it right the first time rather than having to muck about with git etc.

Hi, still/again looking into this. Just trying to see what the best way of implementing this is. As @tschaub pointed out and suggested, the canvas renderer seems like the way to go. It's simpler and supports more features at the moment like vector rendering.
I had a look at
https://github.com/openlayers/ol3/blob/master/src/ol/renderer/canvas/canvastilelayerrenderer.js#L51
in particular at
https://github.com/openlayers/ol3/blob/master/src/ol/renderer/canvas/canvastilelayerrenderer.js#L138
Am I right to assume that ol.renderer.canvas.TileLayer.prototype.composeFrame is called on every redraw, so for example after a zoom or pan?
Would it be too slow to just call that function on an animation frame? Maybe some of the logic there could be copied, but I really don't want to duplicate code unnecessarily.
I will read more of the source code and documentation to get a better idea of how things work to ensure I can contribute in the right way, but some pointers would be much appreciated.

Did you continue working on this?

YES Actually! Just that funding and time hasn't allowed me to. However, I have some funded hours on this and shall pursue this issue, so please don't close. Happy to see it was merged!

Ashamed to admit that I haven't made time for this earlier...
However, my interest in this has sparked again. But to make this perform and synchronize acceptably I need to understand how the rendering works and how it plays together with request animation frame. From what I understand, the sources and layers packages and classes only do either server side image / tiles rendering and vector layers behave completely differently again. I feel like there would need to be a new source type and an appropriate renderer on canvas.
Please let me know how i can better understand how the renderers work as I'm a bit overwhelmed with reading all the source code.

Hi there, I finally found some time to spend on this again.
Please see my efforts at https://github.com/geekdenz/openlayers/blob/geekdenz-videotiles/examples/video-xyz.js#L165 . Still messy and not refactored at all, but I thought I'd give it a shot with the postcompose event. I tried hacking the canvas tilelayer renderer, but didn't want to mess with it too much since it might break other things. Tried various things like setting view hints and setting preload, but that just made it unstable.
I do not quite understand how to easily get the tile information out of the event.frameState yet. Maybe one of you could give me a pointer at some documentation what is in the framestate and how I could find the tiles in the source that need to be rendered. I'll try to work it out anyway though. This is also to give you an update.
Cheers

Hi there,
Not long ago I made significant progress, not to say a few break-throughs with this. See
https://npm.landcareresearch.co.nz/new/
It runs pretty stable now after quite a bit of fiddling.
The source is available here:
https://github.com/geekdenz/openlayers/tree/geekdenz-videotiles
It needs some cleaning up and refactoring for me to be able to make a pull request, but I got the tile synchronisation working reasonably nicely now with not too much overhead.
Please let me know what you think!

video tiles would be a great additional to openlayers.

Please see my presentation at
https://2018.foss4g-oceania.org/program/presentations/wms-v-video-map-tiles-3rd-or-4th-dimension.html
and
https://youtu.be/fDz8H_a_Y9s


Installation requirements for SDK 2.1.515(Document)

The installation requirements for the SDK 2.1.515 listed on this page are "Visual Studio 2019 (v16.2 or later)".
And it also says Visual Studio 15.9.24.
Is this correct?
https://dotnet.microsoft.com/download/dotnet-core/2.1
Maybe it's related.
https://github.com/dotnet/core/blob/5c7c41d5007d7b740f7e11ab3357bbaafff051fd/release-notes/2.1/releases.json#L338

Hi,
I posted this too in the news announcement here. Would be lovely if this could be fixed, our automated process now skips retrieving the latest 2017 sdk due to this invalid value

This issue fixed.
Thanks #4897


urllib.error.URLError: <urlopen error [Errno -2] Name or service not known>

Hello,
OS: Linux
Distribution: ArchLinux
Installation method: pip install --upgrade plex-mpv-shim; version 1.7.2
Plex client: Plex for Android <IP_ADDRESS>78
Issue:
I am getting this error when I simply try to play a video on plex-mpv-shim:
Exception happened during processing of request from ('<IP_ADDRESS>', 37310)
Traceback (most recent call last):
  File "/usr/lib/python3.8/urllib/request.py", line 1319, in do_open
    h.request(req.get_method(), req.selector, req.data, headers,
  File "/usr/lib/python3.8/http/client.py", line 1230, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "/usr/lib/python3.8/http/client.py", line 1276, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.8/http/client.py", line 1225, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.8/http/client.py", line 1004, in _send_output
    self.send(msg)
  File "/usr/lib/python3.8/http/client.py", line 944, in send
    self.connect()
  File "/usr/lib/python3.8/http/client.py", line 1392, in connect
    super().connect()
  File "/usr/lib/python3.8/http/client.py", line 915, in connect
    self.sock = self._create_connection(
  File "/usr/lib/python3.8/socket.py", line 787, in create_connection
    for res in getaddrinfo(host, port, 0, SOCK_STREAM):
  File "/usr/lib/python3.8/socket.py", line 918, in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -2] Name or service not known

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.8/socketserver.py", line 650, in process_request_thread
    self.finish_request(request, client_address)
  File "/usr/lib/python3.8/socketserver.py", line 360, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/lib/python3.8/http/server.py", line 646, in __init__
    super().__init__(*args, **kwargs)
  File "/usr/lib/python3.8/socketserver.py", line 720, in __init__
    self.handle()
  File "/usr/lib/python3.8/http/server.py", line 426, in handle
    self.handle_one_request()
  File "/usr/lib/python3.8/http/server.py", line 414, in handle_one_request
    method()
  File "/usr/lib/python3.8/site-packages/plex_mpv_shim/client.py", line 195, in do_GET
    self.handle_request("GET")
  File "/usr/lib/python3.8/site-packages/plex_mpv_shim/client.py", line 173, in handle_request
    getattr(self, handler)(path, query)
  File "/usr/lib/python3.8/site-packages/plex_mpv_shim/client.py", line 298, in playMedia
    media = Media(url, play_queue=playQueue)
  File "/usr/lib/python3.8/site-packages/plex_mpv_shim/media.py", line 448, in __init__
    XMLCollection.__init__(self, url)
  File "/usr/lib/python3.8/site-packages/plex_mpv_shim/media.py", line 437, in __init__
    self.tree       = et.parse(urllib.request.urlopen(get_plex_url(url)))
  File "/usr/lib/python3.8/urllib/request.py", line 222, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.8/urllib/request.py", line 525, in open
    response = self._open(req, data)
  File "/usr/lib/python3.8/urllib/request.py", line 542, in _open
    result = self._call_chain(self.handle_open, protocol, protocol +
  File "/usr/lib/python3.8/urllib/request.py", line 502, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.8/urllib/request.py", line 1362, in https_open
    return self.do_open(http.client.HTTPSConnection, req,
  File "/usr/lib/python3.8/urllib/request.py", line 1322, in do_open
    raise URLError(err)
urllib.error.URLError: <urlopen error [Errno -2] Name or service not known>

Let me know if you need more details.
Cheers.

Sorry for not replying; life and all.
I've just tried the tip regarding dnsmasq/DDWRT and it's working! Added the following line in the "Additional DNSMasq Options" section:
rebind-domain-ok=/plex.direct/

I'll close this issue. Thank you for your help!


[FIXED] NatsBench

The tool is now inline with the other NATS clients bench tools.
The number of messages given in the command line is the total
number of messages to be sent. So if there is more than one publisher,
the per-publisher number is the number of messages divided
by the number of publishers (-np). The last publisher may get a
slight different number of messages to send due to the possible
fraction.
Each subscription is supposed to receive each message (pub/sub),
therefore each subscription receives the total number of messages
as given in the command line (-n).
Resolves #133

Coverage decreased (-0.03%) to 93.567% when pulling 5c7f1448b4f066ee49ee35ce15d8a2f91afe9082 on fix_nats_bench into e10590dbb039e51cfd549a9a2f0b272c5d33ccbf on master.

Coverage decreased (-0.03%) to 93.567% when pulling 5c7f1448b4f066ee49ee35ce15d8a2f91afe9082 on fix_nats_bench into e10590dbb039e51cfd549a9a2f0b272c5d33ccbf on master.

Here are 2 outputs, the first before the fix, the second after. Notice that I have commented out the removal of the shutdown hook so that total sent/received messages is printed.

Sent=5000000
Received=1000004

Notice the number of received messages was more than what was given in the command line since each subscription's callback was checking the total number of messages received.
Ivans-MacBook-Pro:java-nats ivan$ ./scripts/nats-bench -np 5 -ns 5 -n 1000000 foo
Starting benchmark [msgs=1000000, msgsize=128, pubs=5, subs=5]
NATS publish connection statistics:
   Bytes out: 25600000
   Msgs  out: 200000
Subscriber disconnected after 986921 msgs
Subscriber connection closed after 986130 msgs
NATS publish connection statistics:
   Bytes out: 25600000
   Msgs  out: 200000
Subscriber disconnected after 987165 msgs
Subscriber connection closed after 986130 msgs
NATS publish connection statistics:
   Bytes out: 25600000
   Msgs  out: 200000
Subscriber disconnected after 987868 msgs
Subscriber connection closed after 986384 msgs
NATS publish connection statistics:
   Bytes out: 25600000
   Msgs  out: 200000
NATS publish connection statistics:
   Bytes out: 25600000
   Msgs  out: 200000
NATS Pub/Sub stats: 2,802,326 msgs/sec ~ 342.08 MB/sec
 Pub stats: 468,191 msgs/sec ~ 57.15 MB/sec
  [ 1] 94,571 msgs/sec ~ 11.54 MB/sec (200000 msgs)
  [ 2] 94,493 msgs/sec ~ 11.53 MB/sec (200000 msgs)
  [ 3] 94,473 msgs/sec ~ 11.53 MB/sec (200000 msgs)
  [ 4] 93,694 msgs/sec ~ 11.44 MB/sec (200000 msgs)
  [ 5] 93,654 msgs/sec ~ 11.43 MB/sec (200000 msgs)
  min 93,654 | avg 94,177 | max 94,571 | stddev 412.20 msgs
 Sub stats: 2,321,945 msgs/sec ~ 283.44 MB/sec
  [ 1] 467,031 msgs/sec ~ 57.01 MB/sec (1000000 msgs)
  [ 2] 467,034 msgs/sec ~ 57.01 MB/sec (1000000 msgs)
  [ 3] 466,207 msgs/sec ~ 56.91 MB/sec (1000000 msgs)
  [ 4] 465,388 msgs/sec ~ 56.81 MB/sec (1000000 msgs)
  [ 5] 464,389 msgs/sec ~ 56.69 MB/sec (1000000 msgs)
  min 464,389 | avg 466,009 | max 467,034 | stddev 1,014.33 msgs

Caught CTRL-C, shutting down gracefully...

Sent=1000000
Received=5000000

Notice that now each publisher sends numMsgs/5 and each subscription receives exactly 1,000,000 messages.

Coverage decreased (-0.03%) to 93.567% when pulling b52f4dde812ddf40b4466c94ca506e9a009f8b8a on fix_nats_bench into e10590dbb039e51cfd549a9a2f0b272c5d33ccbf on master.


Failed build using build-mingw64.sh

I have tried building using msys64 with the usual procedure
`pacman -S git
git clone https://github.com/zynaddsubfx/zyn-fusion-build.git
cd zyn*
./build-mingw64.sh`

And had the same issue raised  #here
The output I get is this...
configure: WARNING: you should use --build, --host, --target
configure: WARNING: invalid host type: McGraw/zyn-fusion-build/fftw-3.3.4/../pkg/
configure: loading site script /mingw64/etc/config.site
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking build system type... Invalid configuration `McGraw/zyn-fusion-build/fftw-3.3.4/../pkg/': machine `McGraw/zyn-fusion-build/fftw' not recognized
configure: error: /bin/sh ./config.sub McGraw/zyn-fusion-build/fftw-3.3.4/../pkg/ failed

What can I do to fix this?

It looks like you have a space in your path which is causing an issues at https://github.com/zynaddsubfx/zyn-fusion-build/blob/master/z/build-fftw.sh#L5


Fix order of control plane and node pool upgrade

This change does two things:

Perform control plane upgrades first. This will make it possible
to upgrade both the control plane and node pool kubernetes versions
at the same time, because the controller will safely make the
control plane changes first.

Only make changes to the current upstream node pools in the
cluster's AgentPoolProfiles list during the control plane update.
Without this, if a node pool is added with a version different from
the current upstream control plane version, AKS rejects it with this
error:
OrchestratorVersion must be all specified or all unspecified. If
all specified, they must be stay unchanged or the same with
control plane.
Filter out the new ones, and then add them in the node pool update
section after the control plane update is finished.

https://github.com/rancher/rancher/issues/33426

for 2.6.1


banana-accounting: init at 10.0.12

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Now squash all commits into one.

GitHub claims there's an outstanding requested change, but I can't see what it is.

I don't agree with dumping everything into $out, it's not a proper installation tree, it looks like a dump of what would be inside an AppImage:
total 60
lrwxrwxrwx 1 root root    18 Jan  1  1970 AppRun.wrapped -> usr/bin/bananaplus
-r--r--r-- 1 root root   237 Jan  1  1970 README.txt
dr-xr-xr-x 2 root root  4096 Jan  1  1970 apprun-hooks
-r-xr-xr-x 1 root root   325 Jan  1  1970 bananaplus
-r-xr-xr-x 1 root root  1424 Jan  1  1970 bananaplus.desktop
lrwxrwxrwx 1 root root    49 Jan  1  1970 bananaplus.png -> usr/share/icons/hicolor/64x64/apps/bananaplus.png
-r--r--r-- 1 root root  1500 Jan  1  1970 bananaplus.svg
dr-xr-xr-x 2 root root  4096 Jan  1  1970 bin
-r--r--r-- 1 root root 28507 Jan  1  1970 env-vars
-r-xr-xr-x 1 root root  1564 Jan  1  1970 install-banana.sh
dr-xr-xr-x 8 root root  4096 Jan  1  1970 usr

And the existance of $out/usr is clearly a sign the wrong combination of PREFIX/DESTDIR is being used.

Any hints on what should and should not be dumped there?

Any hints on what should and should not be dumped there?

Any sensible FHS linux installation, perhaps?


Removing Test Items

Removing localStorage and sessionStorage test items.

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   93.75%   93.75%
=======================================
  Files           4        4
  Lines          64       64
  Branches        7        7
=======================================
  Hits           60       60
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ca2ce...bf986ba. Read the comment docs.


Error when using "Run x integration specs" in Cypress IDE

Current behavior
When running features individually from the Cypress IDE, they run successfully.  When using the "Run [x] integration specs" button, the tests launch but as soon as the first assertion finishes, the following error is displayed:
Expected to find an error message (this might be a bug, please report at https://github.com/badeball/cypress-cucumber-preprocessor)

Because this error occurred during a after each hook we are skipping all of the remaining tests.

Desired behavior
Tests should run the same as if they were executed individually.
Test code to reproduce
Assuming this is not repo specific, this should be reproduce-able with any suite that contains two or more features.  I am unable to create a repo at this moment, but could put one together in the next day or two if required.
Versions

Cypress version: 8.7.0
Preprocessor version: 9.0.0
Node version: 14.17.0

Hi Jody, I’ve released a more recent version with a fix for this issue, can
you try that?
On Wed, 13 Apr 2022 at 18:05, Jody Mickey @.***> wrote:

Current behavior
When running features individually from the Cypress IDE, they run
successfully. When using the "Run [x] integration specs" button, the tests
launch but as soon as the first assertion finishes, the following error is
displayed:
`Expected to find an error message (this might be a bug, please report at
https://github.com/badeball/cypress-cucumber-preprocessor)
Because this error occurred during a after each hook we are skipping all
of the remaining tests.`
Desired behavior
Tests should run the same as if they were executed individually.
Test code to reproduce
Assuming this is not repo specific, this should be reproduce-able with any
suite that contains two or more features. I am unable to create a repo at
this moment, but could put one together in the next day or two if required.
Versions

Cypress version: 8.7.0
Preprocessor version: 9.0.0
Node version: 14.17.0

—
Reply to this email directly, view it on GitHub
https://github.com/badeball/cypress-cucumber-preprocessor/issues/695,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFSKM652NEZFZMJ5R6Q77DVE3WF3ANCNFSM5TLE6N7Q
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Jonas Amundsen

Works with 9.0.2.  Thank you Jonas!