Exception throw during inspection when using Node 11.x

Summary of Problem
(Please answer all 3)

What are you trying to do?

Peek at the port object (returned by new SerialPort(...)) in the node 11.x (11.9.0) REPL.

What happens?

This causes an unhandled exception to be thrown up:
RangeError: Invalid count value
    at String.repeat (<anonymous>)
    at reduceToSingleString (internal/util/inspect.js:1216:27)
    at formatRaw (internal/util/inspect.js:777:15)
    at formatValue (internal/util/inspect.js:539:10)
    at inspect (internal/util/inspect.js:196:10)
    at Object.formatWithOptions (util.js:174:18)
    at Console.(anonymous function) (internal/console/constructor.js:274:15)
    at Console.log (internal/console/constructor.js:283:59)

What should have happened?

On Node 10.x (tested 10.15.1) no exception is thrown, and some interesting information about the object is returned:

Expected output
SerialPort {
  _readableState:
   ReadableState {
     objectMode: false,
     highWaterMark: 65536,
     buffer: BufferList { head: null, tail: null, length: 0 },
     length: 0,
     pipes:
      ReadLineParser {
        _readableState: [ReadableState],
        readable: true,
        _events: [Object],
        _eventsCount: 7,
        _maxListeners: undefined,
        _writableState: [WritableState],
        writable: true,
        allowHalfOpen: true,
        _transformState: [Object],
        includeDelimiter: false,
        delimiter: <Buffer 0d>,
        buffer: <Buffer > },
     pipesCount: 1,
     flowing: true,
     ended: false,
     endEmitted: false,
     reading: true,
     sync: false,
     needReadable: true,
     emittedReadable: false,
     readableListening: false,
     resumeScheduled: false,
     emitClose: true,
     destroyed: false,
     defaultEncoding: 'utf8',
     awaitDrain: 0,
     readingMore: false,
     decoder: null,
     encoding: null },
  readable: true,
  _events:
   [Object: null prototype] {
     end:
      { [Function: bound onceWrapper] listener: [Function: onend] },
     data: [Function: ondata] },
  _eventsCount: 2,
  _maxListeners: undefined,
  _writableState:
   WritableState {
     objectMode: false,
     highWaterMark: 65536,
     finalCalled: false,
     needDrain: false,
     ending: false,
     ended: false,
     finished: false,
     destroyed: false,
     decodeStrings: true,
     defaultEncoding: 'utf8',
     length: 0,
     writing: false,
     corked: 0,
     sync: false,
     bufferProcessing: false,
     onwrite: [Function: bound onwrite],
     writecb: null,
     writelen: 0,
     bufferedRequest: null,
     lastBufferedRequest: null,
     pendingcb: 0,
     prefinished: false,
     errorEmitted: false,
     emitClose: true,
     bufferedRequestCount: 0,
     corkedRequestsFree:
      { next: null,
        entry: null,
        finish: [Function: bound onCorkedFinish] } },
  writable: true,
  allowHalfOpen: true,
  binding:
   LinuxBinding {
     bindingOptions: { vmin: 1, vtime: 0 },
     fd: 21,
     writeOperation: null,
     openOptions:
      { vmin: 1,
        vtime: 0,
        autoOpen: true,
        baudRate: 115200,
        dataBits: 8,
        hupcl: true,
        lock: true,
        parity: 'none',
        rtscts: false,
        stopBits: 1,
        xany: false,
        xoff: false,
        xon: false,
        highWaterMark: 65536 },
     poller:
      Poller {
        _events: [Object],
        _eventsCount: 1,
        _maxListeners: undefined,
        poller: Poller {} } },
  path: '/dev/ttyUSB0',
  settings:
   { autoOpen: true,
     baudRate: 115200,
     dataBits: 8,
     hupcl: true,
     lock: true,
     parity: 'none',
     rtscts: false,
     stopBits: 1,
     xany: false,
     xoff: false,
     xon: false,
     highWaterMark: 65536 },
  opening: false,
  closing: false,
  _pool:
   <Buffer 30 30 35 30 0d 30 2e 30 30 45 2b 30 30 2c 30 30 35 30 2c 33 39 2e 30 2c 32 32 2e 30 2c 34 30 2e 30 2c 33 30 2e 39 2c 39 37 2e 35 2c 30 2e 30 2c 30 2e ... >,
  _kMinPoolSpace: 128 }

Code to Reproduce the Issue

Minimal program
const SerialPort = require('serialport');
const port = new SerialPort('/dev/null', { autoOpen: false });
console.log(port); // Throws
/*
RangeError: Invalid count value
    at String.repeat (<anonymous>)
    at reduceToSingleString (internal/util/inspect.js:1216:27)
    at formatRaw (internal/util/inspect.js:777:15)
    at formatValue (internal/util/inspect.js:539:10)
    at Object.inspect (internal/util/inspect.js:196:10)
    at REPLServer.self.writer (repl.js:514:33)
    at finish (repl.js:686:38)
    at finishExecution (repl.js:310:7)
    at REPLServer.defaultEval (repl.js:396:7)
    at bound (domain.js:393:14)
*/

Longer program
const SerialPort = require('serialport');
const Readline = SerialPort.parsers.Readline

console.log('test program started');
SerialPort.list().then((ports) => {
    console.log('list() resolved -->', ports);
    // Open first port we see
    const comName = ports[0].comName;
    const openOptions = {
        baudRate: 115200,
    };
    console.log(`About to open/create port using "${comName}"`, openOptions);
    const port = new SerialPort(comName, openOptions);
    const parser = new Readline({ delimiter: '\r', });
    console.log('Attaching parser');
    port.pipe(parser);
    console.log('Attaching receive event handler');
    parser.on('data', console.log.bind(console));

    port.write('command 1\r\n');

    new Promise(resolve => { setTimeout(resolve, 1000); }).then(() => port.write('command 2\r\n'));

    new Promise(resolve => { setTimeout(resolve, 2000); }).then(() => {
        console.log('Attempting to inspect "port" object throws error', port); // RangeError: Invalid count value
    });
});
console.log('waiting for .list() promise to resolve');

### Versions, Operating System and Hardware

SerialPort v7.1.4
Node.js v11.9.0 (works on 10.15.1)
Linux (4.9.0-8-amd64, Debian)
Hardware and chipset? FTDI but doesn't appear to matter (can reproduce with others too)

Just tested again and can confirm that this problem is still happening on node 11.13.0 and Linux x86_64 (Debian / kernel 4.9.0-8-amd64). Is no one else encountering this / able to reproduce?

I am also encountering this on Node v11.14.0 on macOS 10.14.4.

Just tested again (serialport v7.1.5) on Windows with Node v11.15.0 and v12.1.0. It looks like the problem happens for 11 but not 12. (I am no longer using Node 11 so am not too interested in investigating this further.)

Node 11
npm install serialport

><EMAIL_ADDRESS>install C:\Users\jacob\Documents\tmp\node_modules\@serialport\bindings
> prebuild-install --tag-prefix @serialport/bindings@ || node-gyp rebuild

npm WARN saveError ENOENT: no such file or directory, open 'C:\Users\jacob\Documents\tmp\package.json'
npm WARN enoent ENOENT: no such file or directory, open 'C:\Users\jacob\Documents\tmp\package.json'
npm WARN tmp No description
npm WARN tmp No repository field.
npm WARN tmp No README data
npm WARN tmp No license field.

+<EMAIL_ADDRESS>added 78 packages from 45 contributors and audited 143 packages in 4.086s
found 0 vulnerabilities

C:\Users\jacob\Documents\tmp>node
> const SerialPort = require('serialport');
undefined
> const port = new SerialPort('/dev/null', { autoOpen: false });
undefined
> console.log(port); // Throws
Thrown:
RangeError: Invalid count value
    at String.repeat (<anonymous>)
    at reduceToSingleString (internal/util/inspect.js:1365:27)
    at formatRaw (internal/util/inspect.js:791:15)
    at formatValue (internal/util/inspect.js:529:10)
    at inspect (internal/util/inspect.js:187:10)
    at formatWithOptions (internal/util/inspect.js:1408:12)
    at Console.(anonymous function) (internal/console/constructor.js:277:10)
    at Console.log (internal/console/constructor.js:287:61)
> process.version
'v11.15.0'

Node 12
C:\Users\jacob\Documents\tmp>npm install serialport
...
+<EMAIL_ADDRESS>added 78 packages from 45 contributors and audited 143 packages in 3.417s
found 0 vulnerabilities

C:\Users\jacob\Documents\tmp>node
Welcome to Node.js v12.1.0.
Type ".help" for more information.
> const SerialPort = require('serialport');
undefined
> const port = new SerialPort('/dev/null', { autoOpen: false });
undefined
> console.log(port); // Throws
SerialPort {
  _readableState: ReadableState {
    objectMode: false,
    highWaterMark: 65536,
    buffer: BufferList { head: null, tail: null, length: 0 },
    length: 0,
    pipes: null,
    pipesCount: 0,
    flowing: null,
    ended: false,
    endEmitted: false,
    reading: false,
    sync: true,
    needReadable: false,
    emittedReadable: false,
    readableListening: false,
    resumeScheduled: false,
    paused: true,
    emitClose: true,
    autoDestroy: false,
    destroyed: false,
    defaultEncoding: 'utf8',
    awaitDrain: 0,
    readingMore: false,
    decoder: null,
    encoding: null
  },
  readable: true,
  _events: [Object: null prototype] {},
  _eventsCount: 0,
  _maxListeners: undefined,
  _writableState: WritableState {
    objectMode: false,
    highWaterMark: 65536,
    finalCalled: false,
    needDrain: false,
    ending: false,
    ended: false,
    finished: false,
    destroyed: false,
    decodeStrings: true,
    defaultEncoding: 'utf8',
    length: 0,
    writing: false,
    corked: 0,
    sync: true,
    bufferProcessing: false,
    onwrite: [Function: bound onwrite],
    writecb: null,
    writelen: 0,
    bufferedRequest: null,
    lastBufferedRequest: null,
    pendingcb: 0,
    prefinished: false,
    errorEmitted: false,
    emitClose: true,
    autoDestroy: false,
    bufferedRequestCount: 0,
    corkedRequestsFree: {
      next: null,
      entry: null,
      finish: [Function: bound onCorkedFinish]
    }
  },
  writable: true,
  allowHalfOpen: true,
  binding: WindowsBinding { bindingOptions: {}, fd: null, writeOperation: null },
  path: '/dev/null',
  settings: {
    autoOpen: false,
    baudRate: 9600,
    dataBits: 8,
    hupcl: true,
    lock: true,
    parity: 'none',
    rtscts: false,
    stopBits: 1,
    xany: false,
    xoff: false,
    xon: false,
    highWaterMark: 65536
  },
  opening: false,
  closing: false,
  _pool: <Buffer 80 b5 37 46 5c 02 00 00 f0 c7 3a 46 5c 02 00 00 60 40 00 00 00 00 00 00 90 02 3d 46 5c 02 00 00 01 0e 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ff ff ... 65486 more bytes, used: 0>,
  _kMinPoolSpace: 128
}
undefined


samples/synchronization: fix thread b pinning

This PR adds a brief thread b suspend while the sample sets thread b's affinity mask.
If the call to k_thread_cpu_pin is being made while the thread is actively running, then we get -EINVAL and the affinity mask is left unchanged.
Tested with:
west build -p -b qemu_riscv64/qemu_virt_riscv64/smp samples/synchronization -t run

Logs with the fix:
*** Booting Zephyr OS build v3.7.0-rc3-122-g1bad1a04f839 ***
thread_a: Hello World from cpu 0 on qemu_riscv64!
thread_b: Hello World from cpu 1 on qemu_riscv64!
thread_a: Hello World from cpu 0 on qemu_riscv64!
thread_b: Hello World from cpu 1 on qemu_riscv64!
thread_a: Hello World from cpu 0 on qemu_riscv64!
thread_b: Hello World from cpu 1 on qemu_riscv64!
thread_a: Hello World from cpu 0 on qemu_riscv64!
thread_b: Hello World from cpu 1 on qemu_riscv64!
thread_a: Hello World from cpu 0 on qemu_riscv64!

Logs without the fix (current main):
*** Booting Zephyr OS build v3.7.0-rc3-121-g51c39d7d3f40 ***
thread_a: Hello World from cpu 0 on qemu_riscv64!
thread_b: Hello World from cpu 0 on qemu_riscv64!
thread_a: Hello World from cpu 0 on qemu_riscv64!
thread_b: Hello World from cpu 0 on qemu_riscv64!
thread_a: Hello World from cpu 0 on qemu_riscv64!
thread_b: Hello World from cpu 1 on qemu_riscv64!
thread_a: Hello World from cpu 0 on qemu_riscv64!
thread_b: Hello World from cpu 0 on qemu_riscv64!
thread_a: Hello World from cpu 0 on qemu_riscv64!
thread_b: Hello World from cpu 1 on qemu_riscv64!
thread_a: Hello World from cpu 0 on qemu_riscv64!

Just got the same issue and found this PR, I wonder if this is something that we can backport to v3.7?


[Feature] Automate CSV export of support data

At the moment the support requests are being stored in local db with no way of exporting them to the people that will contact those supporters.
We need to find a way to automate those exports so we can notify the team about new support requests

I have some questions:
What is the current workflow?
Perhaps we need to create separate endpoint for exporting db info into CSV?
Do we need some kind of admin page where non-technical people can export the support requests, I don't know what is the state of this project: https://github.com/podkrepi-bg/admin?

Why is a CSV even needed? We could make a simple front-end for that, I guess? I want to update the contact module a bit to setup linting, building etc. Then I was planning to create an issue to completely refactor it. @preslavgerchev was up for that. Set up logging, tests, split the json columns into dedicated tables where needed. Then we can look into making a front-end or something for it unless there is a specific reason why CSV is needed

@imilchev It will be best if we have an interface for the supporters and other records.
At the moment the admin is on hold as nobody is working on it

then I don't think CSV export will be of much use. We might as well give someone read credentials to the DB and a query to run

It looks like this depends on the system having permissions and user login. Adding dependency to: https://github.com/podkrepi-bg/infrastructure/issues/6

The team can browse the latest contributors at https://podkrepi.bg/admin
Closing the issue as the main goal is to have that list available for use, no matter the format.


chore: update from copier template

#279
#280  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MartinBernstorff and the rest of your teammates on  Graphite

Merge activity

Jul 29, 1:39 PM GMT+2: @MartinBernstorff merged this pull request with Graphite.


No arrows

Hi,
I've used fontconfig as recommended here : https://powerline.readthedocs.org/en/latest/installation/linux.html#font-installation
Now something strange happens: the fonts seem to be recognized (you can see the LN on the screenshot and the arrow on top), but there's no arrow on the bottom-bar...

If any Linux users find the same problem, try setting terminal font as powerline font.
For Ubuntu useres, goto
Edit -> Profiles Preference -> Custom font
Select powerline font out there.

If anyone comes across this in iTerm 2 for Mac OS I got the arrows to show adding @SlexAxton's settings and setting
iTerm2 > Preferences > Profiles > Text > Change Font
to Powerline.


Allow using Fn::ToJsonString without Transform

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Tell us about your request
It would be helpful if Fn::ToJsonString was a "proper" intrinsic, instead of provided by a transform. This would have two benefits:

We could properly JSONify {Fn::GetAtt}s which are anything other than strings (numbers, arrays, booleans, ...)
The intrinsic could be used in places where CloudFormation transforms are banned

We have spoken to a good number of customers during the investigation of a different feature which we were going to implement as a transform, and a surprising amount of them said that transforms were banned at their company, for fear of unpredictability ("no way to know what the transform would do") (list available upon request).
(Before shooting the messenger: yes, I personally am aware of ProcessedTemplate, and I personally also do think there is no reason to mistrust an AWS-provided Transform more than AWS-provided CFN engine. However, they are what they are, and we could hit 2 birds with one stone by making these functions proper intrinsics).
Tell us about the problem you are trying to solve. What are you trying to do, and why is it hard?
I'm from the CDK team. It would make our life A LOT simpler if we could rely on CloudFormation built-ins to produce JSON strings from object literals (given that 99.9% of AWS APIs run on JSON 😅).
However, as long as Fn::ToJsonString requires a mechanism that is banned by any company, we cannot switch over to it.
Are you currently working around this issue?
We are currently guessing at some JSONification of strings, and provisioning a Custom Resource Lambda into our customers' accounts if it looks like we'll need to JSONify arrays.
Customers also hate the Lambdas we put into their accounts for CFN deployment purposes, but we currently have no workaround.
What is the expect behavior with this new feature
The same as it does today (well, covering more of JSON and potentially even going beyond the standard to also encode top-level scalars), except without requiring a transform.

Hey @rix0rrr, thanks for raising this issue. I understand where you're coming from. I'd like to gauge the customer interest for your request. Maybe we can tweak the title to make it more discoverable and potentially see some :+1: or comments on this issue. That would help us prioritize. How about I change the title to "Allow using Fn::ToJsonString without Transform"?

Recently, the Serverless Framework started supporting the use of Fn::ToJsonString, so more people will likely start using it there as well (I'm one of them).

Language extensions is not supported by all regions. It's an another drawback to adapt it.

Hi @zxkane, I understand the concern. AWS::LanguageExtensions recently expanded into 5 more AWS regions and is now available in all public AWS regions. We are also working on making sure that AWS::LanguageExtensions will be immediately available whenever a new AWS region launches in the future.

@MalikAtalla-AWS will AWS China regions be included too?

Yes, @zxkane, AWS::LanguageExtensions is also available in the AWS China regions China (Beijing) and China (Ningxia).


[incubator-kie-drools-5918] [new-parser] Annotations can appear in lh…

…sOr and lhsAnd
Issue:

https://github.com/apache/incubator-kie-drools/issues/5918

@yurloc @mariofusco @gitgabrio Please review, thanks!

To be compliant with the old parser, we also need to process annotations from each expression joined by infix OR/AND:

Thank you! I added test cases and also fixed the implementation to collect the annotations.


spyder-terminal

Description of your problem
What steps will reproduce the problem?
1.installing spyder-terminal
2.spyder doesn't  connect to the kernel and  freezes
3.
What is the expected output? What do you see instead?
Please provide any additional information below
Versions and main components

Terminal Version:0.2.3
Spyder Version:3.2.3
Python Version:3.6
Operating system:windows 10

Could you post a screenshot of how Spyder looks after installing spyder-terminal?

@Mvanti Do you have any error message/trace printed on the internal console?

Nope, I have not been able to install the terminal yet. Spyder hangs after the kernel connection starts.

What's your Qt version?

Qt5

@ccordoba12 Shall we close also this one?

Sure.


⚠ ETF has degraded performance

In c7fc59e, ETF (https://markets.hankyung.com/equity-product/etf) experienced degraded performance:

HTTP code: 200
Response time: 9317 ms

Resolved: 신규상장 performance has improved in 26fcfe5.


Fails to build with default-features = false

Overview
When added as a dependency in another project with default-features = false, or when running cargo build --no-default-features, the crate fails to build:
error[E0432]: unresolved import `smartstring`
  --> /home/shnatsel/.cargo/registry/src/index.crates.io-6f17d22bba15001f/purl-0.1.1/src/lib.rs:12:5
   |
12 | use smartstring::{LazyCompact, SmartString, SmartStringMode};
   |     ^^^^^^^^^^^ use of undeclared crate or module `smartstring`

For more information about this error, try `rustc --explain E0432`.

How To Reproduce
Steps to reproduce this behavior:

cargo build --no-default-features

Expected Behavior
No compilation failures

Weird. We've got a test for this which isn't failing...
And indeed, cargo build --no-default-features succeeds at the workspace level. But cargo build --no-default-features -p purl fails.
Thanks for pointing this out. I'll get a PR up shortly to fix

Thanks for the quick fix!

@matt-phylum @kylewillmon
Does this repo still need another tag and release to crates.io?

Getting a crates.io release with the fix soon would be very nice.

v0.1.2, with these changes, is up on crates.io now. Thanks, @matt-phylum!


Show also end times of sessions

Originally we decided to only show start times of sessions, but after user feedback it seems better to also include the end time of sessions as people do not know how much "space time" is between sessions otherwise.
Therefore please implement to show session end times on all schedule, tracks, room pages.

@mariobehling I will make the changes, asap. Should i place the end time next to start time?

@geekyd Please use the format startime - endtime

@aayusharora Im'm on it :) Thanks

@mariobehling @aayusharora The schedule page has all the events starting at same time grouped together, they might have different end time. Should we ungroup them and make the list?
Please guide. Thanks

Hey @geekyd I guess there is a bug here too, if you see the timings for the two events on 17 March it stated them separately 00:00. If they have been grouped according to start time, they must be grouped together in the time without repetition of the timings.
Now, what I suggest is to ungroup them because the grouping seems already buggy and then too state the end time, be sure to sort them according to timings, same as it is done now.

@geekyd Good point. Let's keep the schedule page as is for now and only change tracks and rooms page for the moment. Cheers.

@mariobehling We have made changes to the schedule page please check http://fossasia.github.io/open-event-webapp/schedule.html
Please give your feedback
Thanks.


Added Runway Report and update italian translation

I've added the capability to show the Runway Report where sent with the message like this: "UUDD 060800Z 21005MPS CAVOK M09/M14 Q1032 R88/190050 NOSIG"
I've updated the italian translations (files in it/LC_MESSAGES/*) and the messages with three new strings

Hello @umpire274
Before submitting a PR you should open an issue explaining the bug or the feature requested with the documentation when available.
After checking your code, I see that you are implementing this PR. I merged the PR in the java project but forgot to backport it in the python project (my bad).
To ease the maintainability I prefer to implement things the same way in both project therefore the existing class RunwayInfo will also handle the deposit part.
Secondly as stated in the CONTRIBUTING.md, you have to use crowdin to update the translations.
I will do the backport regarding the runway deposit

Ok I'll close the pull request and I'm forward to your backport from Java. Thanks.


fix backup cluster has no operation logs

What type of PR is this?

/kind bug
What this PR does / why we need it:
Fix some bugs.
Which issue(s) this PR fixes:

Fixes #24 #25 #26
Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

Codecov Report

Merging #29 (2272b44) into master (f4c9251) will increase coverage by 0.09%.
The diff coverage is 32.81%.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   11.63%   11.72%   +0.09%
==========================================
  Files          91       91
  Lines       13868    13896      +28
==========================================
+ Hits         1614     1630      +16
- Misses      12044    12052       +8
- Partials      210      214       +4

Impacted Files
Coverage Δ

pkg/apis/core/v1/handler.go
0.43% <0.00%> (+<0.01%)
:arrow_up:

pkg/scheme/core/v1/k8s/cluster.go
0.12% <0.00%> (-0.01%)
:arrow_down:

pkg/simple/backupstore/s3.go
7.27% <0.00%> (-0.58%)
:arrow_down:

pkg/simple/backupstore/store.go
38.46% <44.44%> (+13.46%)
:arrow_up:

pkg/apis/core/v1/utils.go
56.87% <72.72%> (+0.17%)
:arrow_up:

pkg/simple/backupstore/filesystem.go
55.81% <100.00%> (+3.31%)
:arrow_up:


editing fixes

There was an error while validating job 21342c26-d28c-473f-8dc3-16b51d251eec Message:
Result status: Failed
There was a problem accessing Github repository 'https://github.com/Microsoft/cordova-docs.git'.
Details:Microsoft.LightweightJobEngine.Core.Language.ContextCommandBase+ContextCommandException:
Result status: Failed
There was a problem accessing Github repository 'https://github.com/Microsoft/cordova-docs.git'.
---> System.AggregateException: One or more errors occurred. ---> System.ArgumentException: Error clonning repository ---> LibGit2Sharp.NotFoundException: Branch 367 not found. Available branches: origin/master
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.GetBranch(Repository repo, String name)
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.<>c__DisplayClass30.<>c__DisplayClass35.b__2a(KeyValuePair2 branch)    at System.Collections.Generic.List1.ForEach(Action1 action)    at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.<>c__DisplayClass30.<CloneRepository>b__28()    at Microsoft.Practices.EnterpriseLibrary.TransientFaultHandling.RetryPolicy.<>c__DisplayClass1.<ExecuteAction>b__0()    at Microsoft.Practices.EnterpriseLibrary.TransientFaultHandling.RetryPolicy.ExecuteAction[TResult](Func1 func)
at Microsoft.Practices.EnterpriseLibrary.TransientFaultHandling.RetryPolicy.ExecuteAction(Action action)
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.CloneRepository(String url, IDictionary2 branches)    --- End of inner exception stack trace ---    at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.CloneRepository(String url, IDictionary2 branches)
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.CloneRepository()
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.GetVersionAsync(String path)
at Microsoft.DPS.Commands.IdentifyDocumentsToPublish.CheckExternalServicesCommand.Do(IDictionary2 context)    --- End of inner exception stack trace ---    --- End of inner exception stack trace ---    at Microsoft.LightweightJobEngine.Core.Language.ContextCommandBase.ThrowIfErrorsLogged()    at Microsoft.DPS.Commands.IdentifyDocumentsToPublish.CheckExternalServicesCommand.Do(IDictionary2 context)
at Microsoft.LightweightJobEngine.Core.Language.JobWorkflow1.RunCommands(Guid jobId, IDictionary2 context, CancellationTokenSource cancelSignal)


feat: low-level buffer allocation utilities for new storages

Description
Add new buffer allocation utilities and concepts definitions.
Main changes:

New definition of core concepts dealing with data: DType, Device, ScalarTypes
New BullerAllocator protocol to support different buffer allocation strategies depending on the device type.
Refactoring of existing cartesian storages allocation tools using the new buffer allocators

Pending

[ ] Make current unit tests pass
[ ] Add unit tests for new buffer allocation and core definitions
[ ] Fix typing with python 3.8 compatibility and code style errors

cscs-ci run

cscs-ci run

cscs-ci run

cscs-ci run

cscs-ci run

cscs-ci run

cscs-ci run

Can confirm that gt4py.storage.cartesian.dace_descriptor is not use in Pace.


Fix invalid forked repository condition

What this PR does / why we need it?
Fix invalid forked repository condition
Any background context you want to provide?
What are the relevant tickets?

Fixes #339
Checklist

[x] Added relevant tests or not required
[ ] Didn't break anything

LGTM


Support Disabling Privileged Pods

I would like to be able to disable privileged pods with a custom, purpose-built spec property.
Something like:
properties:
  privileged-pods: no

This should affect the (currently hard-coded) --allow-privileged=... line at https://github.com/jhunt/k8s-boshrelease/blob/master/jobs/control/templates/bin/api#L54

Turns out we can't just disable it at the apiserver; our kube-proxy daemonset relies on being able to do privileged pods.

This is a job for PSPs


Add UPBOUND_MARKETPLACE_PUSH_ROBOT_USR to env

Description of your changes
This PR added UPBOUND_MARKETPLACE_PUSH_ROBOT_USR to env
I have:

[x] Run make reviewable test to ensure this PR is ready for review.

Docker login is now not being skipped:


fix unqualified "@doc" for julia 0.4

Try to fix this issue.
My code looks ugly.... but with the same ability as the old.
May be I should simplify as below
if VERSION < v"0.4.0-dev"
    try
        using Docile
        eval(:(@docstrings(manual = ["../README.md"])))
    catch
        macro doc(ex)
            esc(ex.args[2].args[2])
        end
    end
end

Unless the problems @StefanKarpinski mentioned in f3d646770ee4302f3521322345c2db78d92f5780 are still around, I'd suggest just going with just
VERSION < v"0.4-" && using Docile

@yfractal can you try @MichaelHatherly's suggestion?

Also #52 seems like a duplicate

I merged #52. It fixed issue #54 with Docile usage in 0.4. Thanks for your time.


increasing the recurrence value beyond 9 makes the unit specifier disappear

App Version: 2.0.9
Platform: Linux
Installation Method: Direct Download (AppImage)
Expected Behavior:
Expect to be able to use any recurrence value like 5 or 10 or 999 whilst retaining the chosen/existing unit specifier.
Actual Behavior:
When either manually editing the recurrence value to '10d' (or '10m'), or when doing this via the UI with the up arrow button, you can see the unit specifier ('d' or 'm', etc) disappear in the todo item text as well as in the little recurrence UI widget. Values like '1d' or '9d' work fine, but values beyond 9 like '10d' seem to be problematic.
Steps to Reproduce:

Open the app.
Click on a todo item to edit it.
First set the recurrence value to 5d and save the todo item. No problem.
Edit the item again and use the recurrence UI widget's up arrow button to increase the value to 10d, and notice it transforming from '10d' to '10'. At this point you can see that the recurrence value in the todo item text has also changed in the same way (the unit specifier 'd' is gone).

Screenshots:
Left blank.

@bughunter2 can you please check if this issue is resolved in the latest pre-release: https://github.com/ransome1/sleek/releases/tag/v2.0.12-rc.3
I can also need some testing of a new feature, which is discussed over at https://github.com/ransome1/sleek/issues/609.
Feel free to participate, if you have the time to do so.

The problem seems to be partially solved:
On real hardware, I don't notice any problem with v2.0.12-rc.3 but I do with v2.0.9
In a virtual machine however, the problem is still there: once you increment beyond 9, the value keeps switching back/forth in the GUI. No graphical artifacts though, just a glitching UI element (you see the text in the todo item glitch as well, constantly switching). When you finally click Update it will choose a value at random from the range of values that you've been using by pressing the up/down arrows.
About testing, sure. I'll see what I can do.

On real hardware, I don't notice any problem with v2.0.12-rc.3 but I do with v2.0.9
In a virtual machine however, the problem is still there: once you increment beyond 9, the value keeps switching back/forth in the GUI. No graphical artifacts though, just a glitching UI element (you see the text in the todo item glitch as well, constantly switching). When you finally click Update it will choose a value at random from the range of values that you've been using by pressing the up/down arrows.

The text confuses me a bit. Are you using 2.0.9 or 2.0.12-rc.3 in that virtual machine?

On real hardware, I don't notice any problem with v2.0.12-rc.3 but I do with v2.0.9
In a virtual machine however, the problem is still there: once you increment beyond 9, the value keeps switching back/forth in the GUI. No graphical artifacts though, just a glitching UI element (you see the text in the todo item glitch as well, constantly switching). When you finally click Update it will choose a value at random from the range of values that you've been using by pressing the up/down arrows.

The text confuses me a bit. Are you using 2.0.9 or 2.0.12-rc.3 in that virtual machine?

Oh I'm sorry. To clarify: that was with v2.0.12-rc.3 as well.

Maybe found a new symptom. If we trigger this issue, and then close the todo editor widget by pressing Cancel, and then open it again by hitting the + (new) button, a leftover is visible: the new todo item widget contains a text like 'rec:4d' or 'rec:3d' (can be any number) rather than an empty line. This was with v2.0.12-rc.4


CLI options warning

Running serverless with this plugin results in a warning:
1 deprecation triggered in the last command:

CLI options definitions were upgraded with "type" property (which could be one of "string", "boolean", "multiple"). Below listed plugins do not predefine type for introduced options:
 - ServerlessDynamodbLocal for "seed"
Please report this issue in plugin issue tracker.
Starting with next major release, this will be communicated with a thrown error.
More info: https://serverless.com/framework/docs/deprecations/#CLI_OPTIONS_SCHEMA_V3

Thanks for reporting this! Looks like in fixing #13 we introduced a new problem. Will take a look at how we can improve this: think we need to introduce a breaking change here to workaround unless serverless changes this (see https://github.com/serverless/serverless/issues/12217).

 CLI options definitions were upgraded with "type" property (which could be one of "string", "boolean", "multiple"). Below listed plugins do not predefine type for introduced options:
   - ServerlessDynamoDBPlugin for "seed"


there was error in formula. Fixed the bugs

There was an error in this formula '(sum(hov_hourly_vmt) / nullif(sum(hov_hourly_vmt), 0)) * 100 as hov_vmt_penetration,. it will be actually '(sum(hov_hourly_vmt) / nullif(sum(ml_hourly_vmt), 0)) * 100 as hov_vmt_penetration. I fixed the error

The dashboard helps to figure it out


[In Progress] Feature: Create Circle

Created from #17, this PR creates a new tool "create-circle". Remaining issues:

[ ] When the create circle tool is selected, clicking the little button to open the classification dialog should not create a new circle
[ ] The circle tool icon should be a dotted circle
[ ] (optional) xr and yr should be locked to the image ratio such that the circle isn't an ellipsis

Note: Prettier should be run on any changed files, I installed the prettier extension to my IDE and set it to configure on save to make this easier

@seveibar, Will you be introducing ih and iw in the reducer's state variable?
If not how will you set the x-radius and y-radius properly in the region.

@seveibar , May I know if you're going to work on this in near future?


Move matplotlib imports to runtime

Summary
This commit moves all the matplotlib imports to runtime. Prior to this
commit when importing the qiskit namespace matplotlib would always be
imported if it was installed. This however adds a noticeable bottleneck
to the import time, even if visualization isn't used. To avoid this
overhead we can lazily import matplotlib at runtime when it is
available. This commit makes this change so that matplotlib is only
imported at runtime when visualization methods using it are called. This
does slow down the first visualization function call using matplotlib,
but since visualization isn't a performance critical path this an
acceptable tradeoff.
For backwards compibility the HAS_MATPLOTLIB module attribute has
changed from a bool to an object of a new class HasMatplotlibWrapper,
which implements a single method bool which returns true if
matplotlib is installed, otherwise it's false. However it does this at
runtime instead of at import time. This way it be used as a replacement
for the previous HAS_MATPLOTLIB boolean variable but without forcing
matplotlib be imported with the entire package.
Details and comments

Looking at the import times without this PR the profile looks like:

Then applying this PR speeds up the import noticeably to:

After this PR the only easy thing left is to remove the fastjsonschema usage. That is just a matter of time since it is deprecated (although only on master so the timer starts after the next release).


Update RxSwift & RxCocoa version

Can you update podspec  so that it can be installed with newer version of RxSwift and RxCocoa ?
In my fork repo, I changed the version to 4.3.1 and it's working properly.

Yes, I can. You can create pull request

I created a PR, please check it. Thank you
https://github.com/RxSwiftCommunity/RxBiBinding/pull/9

Thanks to all


Cloud optics g-point data files

This PR includes new data files containing cloud optics lookup tables by g-point. Two reference output files using this capability in the allsky test are also included.

Closing pull request for further additions


How to statically link on Windows?

Hi! Thanks again for the project.
I'm having trouble building a static library for windows and linking with it.
I notice that only the build scripts for iOS and Mac truly yield one static library. As far as I can tell the Windows script does build many static libraries but doesn't put them together into one. Since the dependency order matters I tried to infer some right order from what I saw in the onnxruntime cmake (i'm a total cmake noob) as well as what's in build-mac.sh and add as many add_library cmake directives to my project but I have to admit I failed to get it to build.
Do you have any pointers ? Thanks!
I also have no idea why the windows static libs are 100x bigger than on macOS (the "providers" lib which we thankfully don't need apparently is 2.8G!). I'm counting on the linker to remove all that extra :)

hello, yes - i haven't had time yet to do it but on windows we have to use libtool.exe to join all the static libs that are built into one onnxruntime.lib. Unfortunately the the .libs are very large as you have seen, but the final linked binary should be small

@olilarkin yeah I figured we need libtool and I have the setup to test it all, I guess my main question was what is the exact ordered list of .libs to be combined?

hopefully that is fixed now

Wow thanks for such a quick fix!
Unfortunately I'm having an obscure error: onnxruntime\test\shared_lib\test_nontensor_types.cc(681): fatal error C1001: Internal compiler error.
For more context:
$ ./build-win.bat

C:\Users\User\ort-builder>mkdir .\libs\win-x86_64\Release
A subdirectory or file .\libs\win-x86_64\Release already exists.

C:\Users\User\ort-builder>mkdir .\libs\win-x86_64\Debug
A subdirectory or file .\libs\win-x86_64\Debug already exists.

C:\Users\User\ort-builder>call onnxruntime\build.bat --config=MinSizeRel --cmake_generator="Visual Studio 16 2019" --parallel --minimal_build --disable_ml_ops --disable_exceptions --disable_rtti --include_ops_by_config model.required_operators_and_types.config --enable_reduced_operator_type_support --enable_msvc_static_runtime --skip_tests
2023-03-18 14:43:37,707 build [DEBUG] - Command line arguments:
  --build_dir 'C:\Users\User\ort-builder\onnxruntime\\build\Windows' --config=MinSizeRel '--cmake_generator=Visual Studio 16 2019' --parallel --minimal_build --disable_ml_ops --disable_exceptions --disable_rtti --include_ops_by_config model.required_operators_and_types.config --enable_reduced_operator_type_support --enable_msvc_static_runtime --skip_tests
2023-03-18 14:43:37,723 build [DEBUG] - Defaulting to running update, build [and test for native builds].
2023-03-18 14:43:37,739 build [INFO] - Build started
2023-03-18 14:43:37,754 reduce_op_kernels [INFO] - Deleting existing op reduction file root directory: C:\Users\User\ort-builder\onnxruntime\build\Windows\MinSizeRel\op_reduction.generated
2023-03-18 14:43:37,754 reduce_op_kernels [INFO] - Processing C:\Users\User\ort-builder\onnxruntime\onnxruntime\core\providers\cpu\cpu_execution_provider.cc

[...]

  Finished generating code
  onnxruntime_perf_test.vcxproj -> C:\Users\User\ort-builder\onnxruntime\build\Windows\MinSizeRel\MinSizeRel\onnxruntime_perf_test.exe
C:\Users\User\ort-builder\onnxruntime\onnxruntime\test\shared_lib\test_nontensor_types.cc(681): fatal error C1001: Internal compiler error. [C:\Users\User\ort-builder\onnxruntime\build\Windows\MinSizeRel\onnxruntime_test_all.vcxproj]
  (compiler file 'D:\a\_work\1\s\src\vctools\Compiler\Utc\src\p2\main.c', line 213)
   To work around this problem, try simplifying or changing the program near the locations listed above.
  If possible please provide a repro here: https://developercommunity.visualstudio.com
  Please choose the Technical Support command on the Visual C++
   Help menu, or open the Technical Support help file for more information

  Finished generating code
  onnx_test_runner.vcxproj -> C:\Users\User\ort-builder\onnxruntime\build\Windows\MinSizeRel\MinSizeRel\onnx_test_runner.exe
Traceback (most recent call last):
  File "C:\Users\User\ort-builder\onnxruntime\tools\ci_build\build.py", line 2737, in <module>
    sys.exit(main())
  File "C:\Users\User\ort-builder\onnxruntime\tools\ci_build\build.py", line 2634, in main
    build_targets(args, cmake_path, build_dir, configs, num_parallel_jobs, args.target)
  File "C:\Users\User\ort-builder\onnxruntime\tools\ci_build\build.py", line 1395, in build_targets
    run_subprocess(cmd_args, env=env)
  File "C:\Users\User\ort-builder\onnxruntime\tools\ci_build\build.py", line 764, in run_subprocess
    return run(*args, cwd=cwd, capture_stdout=capture_stdout, shell=shell, env=my_env)
  File "C:\Users\User\ort-builder\onnxruntime\tools\python\util\run.py", line 49, in run
    completed_process = subprocess.run(
  File "C:\Users\User\.conda\envs\ort\lib\subprocess.py", line 526, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['C:\\Program Files\\CMake\\bin\\cmake.EXE', '--build', 'C:\\Users\\User\\audio2midi-plugin\\ThirdParty\\ort-builder\\onnxruntime\\\\build\\Windows\\MinSizeRel', '--config', 'MinSizeRel', '--', '/maxcpucount:8', '/nodeReuse:False', '/p:CL_MPCount=8']' returned non-zero exit status 1.
**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.11.25
** Copyright (c) 2021 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x86_x64'
Microsoft (R) Library Manager Version 14.29.30148.0
Copyright (C) Microsoft Corporation.  All rights reserved.

LINK : warning LNK4044: unrecognized option '/-config=Debug'; ignored
LINK : warning LNK4044: unrecognized option '/-cmake_generator=Visual Studio 16 2019'; ignored
LINK : warning LNK4044: unrecognized option '/-parallel'; ignored
LINK : warning LNK4044: unrecognized option '/-minimal_build'; ignored
LINK : warning LNK4044: unrecognized option '/-disable_ml_ops'; ignored
LINK : warning LNK4044: unrecognized option '/-disable_exceptions'; ignored
LINK : warning LNK4044: unrecognized option '/-disable_rtti'; ignored
LINK : warning LNK4044: unrecognized option '/-include_ops_by_config'; ignored
LINK : warning LNK4044: unrecognized option '/-enable_reduced_operator_type_support'; ignored
LINK : warning LNK4044: unrecognized option '/-enable_msvc_static_runtime'; ignored
LINK : warning LNK4044: unrecognized option '/-skip_tests'; ignored
LINK : fatal error LNK1104: cannot open file '
call'
**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.11.25
** Copyright (c) 2021 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x86_x64'
Microsoft (R) Library Manager Version 14.29.30148.0
Copyright (C) Microsoft Corporation.  All rights reserved.

LINK : fatal error LNK1181: cannot open input file '.\onnxruntime\build\Windows\Debug\Debug\onnx.lib'

Which makes me wonder maybe the bat file should have a set -e equivalent. Apparently, there isn't, but adding || exit \b to each line will propagate the exit code to the caller.
I'll see if I can get it working.

Looks like the Debug version worked fine, but not the MinSizeRel one. Thank you very much at least I have the Debug version to work with!

Not sure... worked here! I'm wondering if it really needs to link these _test libraries since I thought tests were disabled by the build script params

It worked for MinSizeRel on my 32G RAM PC, not sure if it's related :)

@tiborvass I have discovered that by patching onnxruntime to turn of LTO (&LTCG) the resulting .lib is a reasonable size
diff --git a/cmake/adjust_global_compile_flags.cmake b/cmake/adjust_global_compile_flags.cmake
index 68522a7dda..9040c9b372 100644
--- a/cmake/adjust_global_compile_flags.cmake
+++ b/cmake/adjust_global_compile_flags.cmake
@@ -74,10 +74,7 @@ if (onnxruntime_MINIMAL_BUILD)
   endif()

   if (MSVC)
-    # turn on LTO (which adds some compiler flags and turns on LTCG) unless it's a Debug build to minimize binary size
-    if (NOT CMAKE_BUILD_TYPE STREQUAL "Debug")
-      set(onnxruntime_ENABLE_LTO ON)
-    endif()
+    set(onnxruntime_ENABLE_LTO OFF)

     # undocumented internal flag to allow analysis of a minimal build binary size
     if (ADD_DEBUG_INFO_TO_MINIMAL_BUILD)


Butcher axe is missing from VFP tools list

I noticed that VFP's butcher axe wasn't included in the list of tools in the mod's compat file:
https://github.com/blay09/CookingForBlockheads/blob/1.15.x/src/main/resources/data/cookingforblockheads/cookingforblockheads/compat/vanillafoodpantry.json#L48
Is there a reason for this, or would you accept a PR that adds it?

No reason, it was just missed / didn't exist yet when the compat file was created.


Overall dockwidget UI feedback

🚀 Feature

Plugins have very long names and when tabbed together are not very readable (if more than… 2 or 3).

Buttons on top are very small
Text contrast is not suficiente
movable splitters between dock areas are hard to grab.
dock widgets can be tricky to redock.

Pinging @liaprins-czi

Very related to this heuristic issue (possible duplicate on most fronts):
https://github.com/napari/product-heuristics-2020/issues/18
If useful we can still kepp this one open though

Overview of design need

Is there an existing GitHub issue this design work pertains to?
Layer panels layout #18

In a sentence or two, describe the problem to be solved for users
Very confusing interactions with the visibility + decoupling of the layer controls and layer list panels: The icon to click on to pop them out is very tiny and hard to click. This icon is also not very clear in communicating what will happen if click it. More importantly, when I try to drag popped-out panels back into the main viewer, they don't go back to the way they started: now they are "overlapped" and can only get to them by the tabs (also unexpected to have tabs at the bottom, usually tabs are at the top).

What level of design is needed? (Choose all that apply)

[X] User experience research:  high-level recommendation/exploration of user needs, design heuristics, and / or best practices to inform a design experience
(Use this option when you feel there’s a challenge to be solved, but you’re curious about what the experience should be — may involve research studies to understand challenges/opportunities for design)
[X] Information flow / conceptual: organizing and structuring of information flow and content, including layout on screen or across multiple steps
[X] Visual: creating mockups, icons, etc
(If choosing this level alone, it means that the content to be mocked up and its organization is already known and specified)

Is design a blocker?

[X] Yes: engineering cannot proceed without a design first
[ ] No: engineering can create a first version, and design can come in later to iterate and refine

If selecting Yes, how much design input is needed to unblock engineering? For example, is a full, final visual design needed, or just a recommendation of which conceptual direction to go?
Development of this issue is dependent upon design, however, there is no need for dev to work on this until it is ready.
T-shirt size

[ ] ●○○○○ XS: able to be done in a typical workday or two
[ ] ●●○○○ S: able to do within one sprint, if also working on other things in the sprint
[ ] ●●●○○ M: able to do within one sprint, if it is the sole focus
[X] ●●●●○ L: will likely take more than one sprint to complete, but less than two
[ ] ●●●●● XL: a very large experience to be determined or overhauled, will need to be broken down further

The icon to click on to pop them out is very tiny and hard to click.

agree... but difficult to make bigger without increasing the size of the title bar itself, which I wouldn't want to get much bigger (it's mostly dead space).

This icon is also not very clear in communicating what will happen if click it.

I don't know :) I think it says "window on top of window".  But always nice to have better ones!

More importantly, when I try to drag popped-out panels back into the main viewer, they don't go back to the way they started: now they are "overlapped" and can only get to them by the tabs

this depends on how you drop them (that flexibility is nice if you have more than a single widget, which can easily happen with multiple plugins open)
https://user-images.githubusercontent.com/1609449/130528361-9b59b108-3cfc-4053-bb0e-4b14c0050e5d.mov

(also unexpected to have tabs at the bottom, usually tabs are at the top).

agreed.  easy to change with https://doc.qt.io/qt-5/qmainwindow.html#setTabPosition


Slide error if projecting a motion block

slide error:  calculating key projection/3/content
Slide was:
{collection: undefined, data: {…}, stable: false, type: '', options: {…}, …}
collection: undefined
data: {error: 'calculating key projection/3/content'}
error: "calculating key projection/3/content"
options: {}
stable: false
type: ""

Reproduce steps:

Project a motion block
Add three motions to this motion block

At least two motions should be within a projected motion block, which have different states/recommendations.


[Bug] Rendering many Advanced Markers as map children is extremely slow

Description
On initial component render, even a few dozen Advanced Markers as map children will take ~ 10 seconds to initially render map. A few hundred can crash the browser.
Interestingly, a workaround is to render 1 marker, then set timeout for > 100ms and render many. OR use legacy Marker component.
Steps to Reproduce
Render 100 AdvancedMarkers as map children (just with key, position props)
Environment

Library version: 0.5.0
Google maps version: weekly (3.55.8)
Browser and Version: Chrome 120
OS: Mac

Logs
No response

Found another workaround, so issue must have something to do with the library loading. Hold the rendering of my component  until marker library is loaded.
  const markers = useMapsLibrary('marker')
  const isLoaded = useApiIsLoaded()
  return isLoaded && markers && children
}```

That's very helpful, thanks. I think I have an Idea what might be going wrong there...

I tried to somehow reproduce this issue, but even with 1000 advanced markers i can't see any problems. Even in the timeline recording I can only see that creating 1000 markers and adding them to the map takes about 190ms.

Are your markers rendered in the first map render? i.e. not added afterwards.

yep, this is the code i was testing with.
const App = () => {
  return (
    <APIProvider apiKey={API_KEY} libraries={['marker']}>
      <Map
        mapId={'bf51a910020fa25a'}
        zoom={3}
        center={{lat: 12, lng: 0}}
        gestureHandling={'greedy'}
        disableDefaultUI={true}>
        {Object.keys(Array.from({length: 1000}))
          .map(Number)
          .map(i => (
            <AdvancedMarker
              key={i}
              position={{
                lat: 20 - Math.floor(i / 50) * 4,
                lng: -100 + 4 * (i % 50)
              }}></AdvancedMarker>
          ))}
      </Map>

      <ControlPanel />
    </APIProvider>
  );
};

This is what it looks like in the profiler:

Tried with your test code and its crashing Chrome unless I lower count to ~100 (so same issue for me)

Ok, that's really weird. What kind of GPU do you have? Anything different when opening it in an incognito-tab? Or maybe chrome canary? Tried all the options I have and it works every time.

When its slow, its re-rendering my component hundreds of times before painting. So, if I added a console.log('render') in your test 'App' component, it would log a lot. I don't think it has anything to do with chrome or gpu .

I am having this same issue with over 100 advanced markers

Im not sure if this is the same issue, but I was having issues after rending clusters and trying to play around with the map. The map was presenting a slow performance. This was not happening on loading but after the cluster rendering.
The solution:
using useMemo for all the cluster improve the performance A LOT!!
const markerCluster = useMemo(() => {
    return (
      <>
        {data.map((point, index) => (
          <AdvancedMarker
              position={{ lat: point.latitude, lng: point.longitude }}
              ref={(marker) => setMarkerRef(marker, index.toString())}
            ></AdvancedMarker>
        ))}
      </>
    )
  }, [markers])

  return <>{markerCluster}</>

@luis-cicada in that case you're also missing the key-prop for the AdvancedMarker components, so react will recreate all markers with every change. Can you try just adding the key-prop and remove the useMemo?

@sspread @fc-jeremy I've been thinking about this and how it could be that me and my colleagues are unable to reproduce this. Do you have a way to provide an URL to something where you see the issue?
Which bundler and settings (babel-presets?) are you using? I was thinking that maybe this could be caused by not using native async/await in the bundled code. That would at least somewhat explain why just waiting once for the loaded-promise seems to resolve this issue.

@usefulthink I do have key-prop but Im using a custom component and even with key-prop it was extremly slow
<>
      {data.map((point, index) => (
        <BaseMarker key={index} index={index} point={point} setMarkerRef={setMarkerRef} />
      ))}
</>

I experienced the same slowness when using the marker clustering example from the docs out of the box and swapping out markers dynamically.
Just rendering the AdvancedMarker without any clustering works fairly fine even with a few thousand markers, but adding the Markers clustering component makes the app crash with a "call stack too deep" error when the marker data changes.

@bostrom interesting observation, but I think this is a separate issue, I gotta have a look into the marker-clustering at some point..

I have a similar observation. Initially, rendering markers is okay-ish in terms of performance, but after swapping markers for a while it's quickly getting slower and slower. And I am talking about 10 markers top, not 100 or 1000. After like 10 swaps, it takes ~5 seconds to render and the entire app becomes unusable.

Confirm @sspread workaround works for me with >80 Advance Marker

Any updates here? It's still very slow with >1000 of AdvancedMarker elements, though it's working faster with deprecated Marker element

Sorry, no updates from our side. There are so far no indications as to what could be the reason for this, and there hasn't been an example provided where we can see the problem occurring (I tried reproducing it myself, but I don't see any problems even with 1000 AdvancedMarkers).

@sspread You are an absolute G. I spent 2 full days trying to figure this out and that simple Loaded component did the trick. Thank you!

@jogoley since you also experienced this problem and we still haven't had any luck pinning it down, which react version are you using, and are you using the createRoot-API or still the older ReactDOM.render?

Solution provided by @sspread could be done like this as well:
<APIProvider apiKey={process.env.googleMapsApiKey} libraries={["marker"]}>
           {/* ... any components ... */}
</APIProvider>

It seems like there are still people experiencing this Issue and we would like to properly solve this without requiring any of these workarounds. To do this, we need to be able to reproduce it, which we haven't yet been able to do.
So, if someone subscribed on this thread could help by providing any more Information, that would be amazing.


Opening a subfolder of a git repo in Monokle

We should handle the case where we open a folder as a project that is a subfolder/subdirectory of a git repo.
Showing the absolute path of the files changed but not contained in the current project could be a solution ( similar to the screenshot below ).

We should also add the 3 states from the right: Deleted / Untracked & Modified

design for 3 statuses: https://www.figma.com/file/ysPkVjIsd1JA4cttEWcVJM/Git-for-Desktop?node-id=0%3A1

also, as commented around the paths - we avoid repearting the name of the file in the paths. We only show the path itself.


relative module not found during start

Describe the bug

Downloaded latest version.
npm install
npm run dev
During npm run dev a module was not found:

Failed to compile with 1 errors
This relative module was not found:

../.postwoman/version.json in ./node_modules/babel-loader/lib?ref--2-0!./node_modules/vue-loader/lib??vue-loader-options!./layouts/default.vue?vue&type=script&lang=js&

To Reproduce
Steps to reproduce the behavior:

npm run dev

#327

@fazzomurata if the above solution fixed your issue, please close the issue


Implemented reducers and UI styling

Amazing job! You have mastered it!!!
Congratulation, You can Merge it now.


Fix Dataset comment PUT API

local UI test

Coverage remained the same at 0.661% when pulling 843c432d0ac716585776353dd3fcf000154d91d8 on alyiwang:fe into 0d6f952d503032a483f137cea4956e5f7349679c on linkedin:master.

Coverage remained the same at 0.661% when pulling 843c432d0ac716585776353dd3fcf000154d91d8 on alyiwang:fe into 0d6f952d503032a483f137cea4956e5f7349679c on linkedin:master.


update softether.nix

softether: Fixed problems with using systemd services

@garbas Why this PR could not be merged?

@rick68 it was merged https://github.com/NixOS/nixpkgs/commit/9d9cb9f087c36f711f329fe02ddc435a964a94d7

@garbas oops, my bad


Memcached Tool dumping

Hello!
I was tried to use memcached-tool for dumping my memcached content and try to restore cache from this dump. I have terrible results - some keys are not restored. It's look like dump command don't create valid dump.

We have 9 buckets with 11 items in cache

./memcached-tool localhost:11211 display
  #  Item_Size  Max_age   Pages   Count   Full?  Evicted Evict_Time OOM
  1      96B        25s       1       1     yes        0        0    0
  3     152B        25s       1       1     yes        0        0    0
  5     240B        25s       1       2     yes        0        0    0
  9     600B        25s       1       1     yes        0        0    0
 11     944B        25s       1       1     yes        0        0    0
 12     1.2K        25s       1       1     yes        0        0    0
 13     1.4K        25s       1       1     yes        0        0    0
 14     1.8K        25s       1       1     yes        0        0    0
 15     2.3K        25s       1       2     yes        0        0    0

Dump them

./memcached-tool localhost:11211 dump > ~/mem.dump
Dumping memcache contents
  Number of buckets: 9
  Number of items  : 11
Dumping bucket 1 - 1 total items
Dumping bucket 11 - 1 total items
Dumping bucket 12 - 1 total items
Dumping bucket 13 - 1 total items
Dumping bucket 14 - 1 total items
Dumping bucket 15 - 2 total items
Dumping bucket 3 - 1 total items
Dumping bucket 5 - 2 total items
Dumping bucket 9 - 1 total items

Restart memcached service, or flush cache if you prefer
Restore dump

nc localhost 11211 < ~/mem.dump
STORED
STORED
STORED
STORED

Look for items

./memcached-tool localhost:11211 display
  #  Item_Size  Max_age   Pages   Count   Full?  Evicted Evict_Time OOM
  3     152B        36s       1       1     yes        0        0    0
  5     240B        36s       1       1     yes        0        0    0
 15     2.3K        36s       1       2     yes        0        0    0

4 items in total. Where other items?
I was looked for this issue in internet and found some:

Similar issue on SO: http://stackoverflow.com/questions/31186384/how-to-restore-dump-of-all-memcache-keys-stored-in-a-file-using-memcache-tool-co
Mailing list with possible explanation: http://lists.danga.com/pipermail/memcached/2007-April/003906.html

The tool dump is a debug command; it's not meant to dump every item from the cache.
There's a new command which will dump all metadata, but done loosely: https://github.com/memcached/memcached/wiki/ReleaseNotes1431
Closing this out.


Ignore Azure.AKS.Version for clusters with auto-upgrade enabled

Rule request
Suggested rule change
For managed clusters with auto-upgrade enabled (rapid/ stable/ node-image) the specific version installed for the cluster API server should be ignored unless the evaluation it occurring against an in-flight resource.
Update the existing Azure.AKS.Version rule to improve this behaviour.
Applies to the following
The rule applies to the following:

Resource type: Microsoft.ContainerService/managedClusters

I'd take it if you're not already working with it.

@BenjaminEngeset Absolutely. I haven't started working on it.


CholeskySolverD: Matrix is not positive definite

Thanks for this great codebase. One quick question:
Given some new triangle meshes as input, CholeskySolverD returns an error that the matrix is not positive definite. Did you encounter this at any point and if so do you know how to fix it? I've already double-checked that the  normals are properly oriented.
Thanks!

We did encounter this at some points, the most likely culprit in my experience is that the input mesh is not one connected component. While it is not too difficult to extend our method to multiple components (parametrize each component and render them together in the scene), our code does not handle this case.


All URL linked information isn't parsed by mongo-data

When within the same module, URL's that point to real objects are parsed correctly by the enclosing class. When outside of a module, they are not picked up by the various component scanners. After a long time I could not find the issue. So gave up and parsed them manually.


Add support for PXB 8

The repos are here:
https://github.com/percona/percona-xtrabackup/tree/8.0
https://github.com/percona/percona-server/tree/8.0

There is also experimental build:
https://www.percona.com/blog/2018/09/12/announcement-experimental-build-of-percona-xtrabackup-8-0/

Basic support implemented and merged to release_v1.5.4.
Can be closed.


Function expression or method is not inferable when we have mapped type with a conditional type

🔎 Search Terms
conditional method arrow function
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ

⏯ Playground Link
Playground Link
💻 Code
type Map<T> =  {
  readonly [P in keyof T]: T[P] extends boolean ? "boolean":  "other"
}
export function buildCommand<F extends Record<string, unknown>>(builderArgs: {
  func: (p: F) => void
  params: Map<NoInfer<F>>
}) {

}
type Foo = { foo: boolean };
// Function expression does not work
buildCommand({
  func: function (p: Foo) { },
  params: {
    foo: "boolean"
  }
})

// Methods don't work
buildCommand({
  func(p: Foo) { },
  params: {
    foo: "boolean"
  }
})

// Arrow function works
buildCommand({
  func: (p: Foo) => { },
  params: {
    foo: "boolean"
  }
})

🙁 Actual behavior
For the first two calls we get an error while the third one is successful
🙂 Expected behavior
All three calls should be successful
Additional information about the issue
Removing the constraint from F (Playground Link) or changing it to F extends Record<keyof F, unknown> (Playground Link) will remove the error.

cc: @molisani

I happen to know a PR that fixes this: https://github.com/microsoft/TypeScript/pull/56460


Fix releaseAllLocks and queryAllLocks methods to read all pages

releaseAllLocks - queries locks and sends release locks request in pages to release all existing locks for the given briefcase
queryAllLocks - queries locks in pages until all are retrieved
This fix is addressing #180 issue.
This fix will need to be expanded in the future as currently the memory limit might be reached, but further improvement requires iModels API changes - either to have continuation token, or have asynchronous operation on the server side to release all locks.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add Rust Markdown parser tutorial

To do:

[x]  Get it running 😅
[x] Add missing images

I’d like to see us take a pass at making it a bit more consistent with the other tutorials. For example how we handle prereqs and also using code block frontmatter for filenames, etc.


Add vendored DevServer library

WHY are these changes introduced?
Internal to Shopify, the CLI needs to support the new dev server infrastructure and hostnames for local development environments.
For any non-Shopifolk: there's no difference, it's an internal adjustment.
WHAT is this pull request doing?
Adds a copy of the DevServer library (with permission) and use it for FQDNs during local dev.
How to test your changes?
Run  SHOPIFY_SERVICE_ENV="local" p shopify app info --path=<path to an app> --verbose
You'll see the CLI exit, because the first thing it wanted to connect locally to wasn't there (probably identity). Confirm the error message and the URL it was trying to connect to.
Checklist

[x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[x] I've considered possible documentation changes

Measuring impact
How do we know this change was effective? Please choose one:

[x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

#4825  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shauns and the rest of your teammates on  Graphite

Merge activity

Nov 12, 10:08 AM EST: A user merged this pull request with Graphite.


Why there is a sharp decrease of PPL between two epochs of the transformer model?

Hi.
I found a strange phenomenon during training with the transformer model.
According to the output log, I found that there was a sharp decrease of PPL between two epochs:

{"epoch": 1, "update": 0.9892654178067776, "loss": "7.227", "nll_loss": "5.981", "ppl": "63.16", "wps": 43621, "ups     ": "1.5", "wpb": 28970, "bsz": 947, "num_updates": 4701, "lr": 0.0009224330820691299, "gnorm": "0.851", "clip": "0%     ", "oom": 0.0, "wall": 3154, "train_wall": 2983}
112 {"epoch": 1, "update": 0.9997895179962113, "loss": "7.207", "nll_loss": "5.958", "ppl": "62.17", "wps": 43629, "ups     ": "1.5", "wpb": 28968, "bsz": 947, "num_updates": 4751, "lr": 0.0009175663546331154, "gnorm": "0.847", "clip": "0%     ", "oom": 0.0, "wall": 3187, "train_wall": 3014}
113 {"epoch": 1, "loss": "7.207", "nll_loss": "5.958", "ppl": "62.17", "wps": 43629, "ups": "1.5", "wpb": 28968, "bsz":      947, "num_updates": 4751, "lr": 0.0009175663546331154, "gnorm": "0.847", "clip": "0%", "oom": 0.0, "wall": 3187, "     train_wall": 3014}
114 {"epoch": 1, "valid_loss": 4.9541451967353405, "valid_nll_loss": 3.3313119157728357, "valid_ppl": "10.07", "num_upd     ates": 4751, "best": 4.9541451967353405}
115 {"epoch": 2, "update": 1.0105241001894338, "loss": "5.260", "nll_loss": "3.732", "ppl": "13.29", "wps": 44956, "ups     ": "0.9", "wpb": 29004, "bsz": 978, "num_updates": 4802, "lr": 0.0009126808071427712, "gnorm": "0.486", "clip": "0%     ", "oom": 0.0, "wall": 3244, "train_wall": 3046}
116 {"epoch": 2, "update": 1.0210482003788677, "loss": "5.285", "nll_loss": "3.761", "ppl": "13.56", "wps": 44880, "ups     ": "1.1", "wpb": 29142, "bsz": 964, "num_updates": 4852, "lr": 0.0009079660281786226, "gnorm": "0.482", "clip": "0%     ", "oom": 0.0, "wall": 3277, "train_wall": 3078}
117 {"epoch": 2, "update": 1.0315723005683015, "loss": "5.268", "nll_loss": "3.741", "ppl": "13.37", "wps": 44665, "ups     ": "1.2", "wpb": 29093, "bsz": 941, "num_updates": 4902, "lr": 0.0009033235699638438, "gnorm": "0.488", "clip": "0%     ", "oom": 0.0, "wall": 3310, "train_wall": 3109}

The PPL falls from about 60 to 13. The data I used is the WMT14 en-de data, and both the base and big models have the similar phenomenon.
So, Is this normal?  What the possible reasons for this?
Thank you !

Hello,
I believe it is normal and the reason is that the ppl metric you see during training is averaged across all batches in the epoch.
So the first batches (were the model is weaker) of the epoch 1 contribute negatively to the average loss you see.
However,  when the epoch ends, the ppl metric counter resets and you start to see much better performance from the first batch.
Hope it helps.

hello, I have some questions about output log .
what is  the meaning of 'wps'、'wpb'、'ups'、‘wall’ and 'train wall'
Thank you


Lots of duplicated code and several typos.

Lots of duplicated code and several typos. The gac commands have random periods in them and the code for the c# library has duplicated sections.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 432d0552-7fd9-7220-c5b2-3dd726ce54fa
Version Independent ID: fa375dbe-43da-abcc-bc52-87f48b3d0b0c
Content: Build a Custom Authentication Method for AD FS in Windows Server
Content Source: WindowsServerDocs/identity/ad-fs/development/ad-fs-build-custom-auth-method.md
Product: windows-server
Technology: ad-fs
GitHub Login: @billmath
Microsoft Alias: billmath

I am not a real coder, but I get what you are talking about (e.g. DRY coding).
Would you like to create a Pull Request to have the offending code improved, or only add comments here about what needs to be changed?

#assign:IngridAtMicrosoft
gh issue comment 4748 -b #assign:IngridAtMicrosoft

Thanks again for contacting Microsoft. We value your feedback. A documentation change has been made and will be live after the next business day. We will be closing this as resolved. Thank you and have a most pleasant day. #please-close


Lab steps need to correct

Lab steps ordering need to correct, Screenshot is attached

Fixed on Commit :
https://github.com/awslabs/aws-well-architected-labs/commit/444ea10b3981e15fd2e2bc55ac01a46c6a9978f0
Thanks for bringing this to our attention.


Feedback for code quality of A0122460W

main

Lacks comments. Write header comments for classes and methods, and inline comments for points that should be taken note of.
Try refactoring more. For example, for the following three places, you can try using enums.

Format violates coding standards.

Inconsistent spacing.

docs

You can create new lines in markdown just by adding an empty line without the need for a <br> tag.

test

Check the naming convention in our coding standards. Names of test methods are different from names of code methods.
More cases should be considered.

You may want to take note that you have very limited number of codes/docs/tests. Is this a collate problem?

and empty line and  has different spacing. Not sure how to use enum... currently adding more code to collate.


Internal labels displayed to user

On the edit my address screen, the form labels are the internal json labels. We should have user friendly labels instead.

Should the internal json lables provide default user friendly UI text?

Also covered by #11 and #12

Closing issue as #11 and #12 both cover this more specifically, as mentioned by @antonypope


LoRA+ SFT Error

Reminder

[X] I have read the README and searched the existing issues.

System Info

llamafactory version: 0.9.2.dev0
Platform: Linux-4.19.113-15.nfs4.x86_64-x86_64-with-glibc2.35
Python version: 3.10.15
PyTorch version: 2.5.1+cu124 (GPU)
Transformers version: 4.46.1
Datasets version: 3.1.0
Accelerate version: 1.0.1
PEFT version: 0.12.0
TRL version: 0.9.6
GPU type: NVIDIA A800-SXM4-80GB

Reproduction

launch command:

llamafactory-cli train examples/train_lora/qwen2p5_instruct_loraplus_sft.yaml

qwen2p5_instruct_loraplus_sft.yaml

### model
model_name_or_path: Qwen/Qwen2.5-32B-Instruct
trust_remote_code: true

### method
stage: sft
do_train: true
finetuning_type: lora
lora_target: q_proj,v_proj
lora_rank: 8
# lora_alpha: 16
loraplus_lr_ratio: 16
loraplus_lr_embedding: 1e-6

### dataset
dataset: identity,alpaca_zh_demo,alpaca_en_demo
template: qwen
cutoff_len: 4096
max_samples: 1000
overwrite_cache: true
preprocessing_num_workers: 16

### output
output_dir: save/Qwen2.5-32B-Instruct-LoRAplus-adapter
logging_steps: 5
save_steps: 500
plot_loss: true
overwrite_output_dir: true

plot_loss: true

### train
per_device_train_batch_size: 4
gradient_accumulation_steps: 4
learning_rate: 5.0e-6
num_train_epochs: 3.0
lr_scheduler_type: cosine
warmup_ratio: 0.1
bf16: true
ddp_timeout: 180000000

weight_decay: 0.1

### eval
val_size: 0.1
per_device_eval_batch_size: 1
eval_strategy: steps
eval_steps: 500

stack traces:

...
[INFO|2024-12-20 03:48:57] llamafactory.model.loader:157 >> trainable params: 8,388,608 || all params: 32,772,264,960 || trainable%: 0.0256
Detected kernel version 4.19.113, which is below the recommended minimum of 5.5.0; this can cause the process to hang. It is recommended to upgrade the kernel to the minimum version or higher.
[INFO|trainer.py:698] 2024-12-20 03:48:57,513 >> Using auto half precision backend
[INFO|2024-12-20 03:48:57] llamafactory.train.trainer_utils:157 >> Using LoRA+ optimizer with loraplus lr ratio 16.00.
Traceback (most recent call last):
  File "/public/home/znwlzx_test/.conda/envs/llm-transformers/bin/llamafactory-cli", line 8, in <module>
    sys.exit(main())
  File "/public/home/znwlzx_test/workspace/jiangchengzhi/LLaMA-Factory/src/llamafactory/cli.py", line 112, in main
    run_exp()
  File "/public/home/znwlzx_test/workspace/jiangchengzhi/LLaMA-Factory/src/llamafactory/train/tuner.py", line 50, in run_exp
    run_sft(model_args, data_args, training_args, finetuning_args, generating_args, callbacks)
  File "/public/home/znwlzx_test/workspace/jiangchengzhi/LLaMA-Factory/src/llamafactory/train/sft/workflow.py", line 101, in run_sft
    train_result = trainer.train(resume_from_checkpoint=training_args.resume_from_checkpoint)
  File "/public/home/znwlzx_test/.conda/envs/llm-transformers/lib/python3.10/site-packages/transformers/trainer.py", line 2122, in train
    return inner_training_loop(
  File "/public/home/znwlzx_test/.conda/envs/llm-transformers/lib/python3.10/site-packages/transformers/trainer.py", line 2223, in _inner_training_loop
    self.create_optimizer_and_scheduler(num_training_steps=max_steps)
  File "/public/home/znwlzx_test/.conda/envs/llm-transformers/lib/python3.10/site-packages/transformers/trainer.py", line 1129, in create_optimizer_and_scheduler
    self.create_scheduler(num_training_steps=num_training_steps, optimizer=optimizer)
  File "/public/home/znwlzx_test/workspace/jiangchengzhi/LLaMA-Factory/src/llamafactory/train/sft/trainer.py", line 85, in create_scheduler
    return super().create_scheduler(num_training_steps, optimizer)
  File "/public/home/znwlzx_test/.conda/envs/llm-transformers/lib/python3.10/site-packages/transformers/trainer.py", line 1631, in create_scheduler
    self.lr_scheduler = get_scheduler(
  File "/public/home/znwlzx_test/.conda/envs/llm-transformers/lib/python3.10/site-packages/transformers/optimization.py", line 550, in get_scheduler
    return schedule_func(
  File "/public/home/znwlzx_test/.conda/envs/llm-transformers/lib/python3.10/site-packages/transformers/optimization.py", line 175, in get_cosine_schedule_with_warmup
    return LambdaLR(optimizer, lr_lambda, last_epoch)
  File "/public/home/znwlzx_test/.conda/envs/llm-transformers/lib/python3.10/site-packages/torch/optim/lr_scheduler.py", line 336, in __init__
    super().__init__(optimizer, last_epoch, verbose)
  File "/public/home/znwlzx_test/.conda/envs/llm-transformers/lib/python3.10/site-packages/torch/optim/lr_scheduler.py", line 146, in __init__
    self._initial_step()
  File "/public/home/znwlzx_test/.conda/envs/llm-transformers/lib/python3.10/site-packages/torch/optim/lr_scheduler.py", line 151, in _initial_step
    self.step()
  File "/public/home/znwlzx_test/.conda/envs/llm-transformers/lib/python3.10/site-packages/torch/optim/lr_scheduler.py", line 238, in step
    values = self.get_lr()
  File "/public/home/znwlzx_test/.conda/envs/llm-transformers/lib/python3.10/site-packages/torch/optim/lr_scheduler.py", line 384, in get_lr
    return [
  File "/public/home/znwlzx_test/.conda/envs/llm-transformers/lib/python3.10/site-packages/torch/optim/lr_scheduler.py", line 385, in <listcomp>
    base_lr * lmbda(self.last_epoch)
TypeError: can't multiply sequence by non-int of type 'float'

Expected behavior
SFT with LoRA+
Others
No response

Seems like the "loraplus_lr_embedding: 1e-6" in configuration will raise this error, comment this line to solve the problem.
It's weird in "torch/optim/lr_scheduler.py", line 384, in get_lr", the value is a string.

use 1.0e-6


Different Average

Hey there Christian,
we use your tool and get the same results as you do.
But when i calculate the portfolio-weights with my Excel-Solver i get different results.
Maybe the reason is that we calculate the average differently.
When i calculate the average returns for asset_a in Excel i get 0,008056.
In your examply.py the average for asset_a is -0,001237.
Can you please tell me how you get this average?
Thank you in advance and thank you for the good work!
LinkFoxMario64

I checked that Excel indeed also calculates -0.001237 as the mean for Asset A, so I'm not sure what you calculated.


Building v0.25.3 fails at MacOS

How to Repoduce
bash-5.1$ cat Cargo.toml
[package]
name = "object-test"
version = "0.1.0"
edition = "2018"
[dependencies]
object  = "0.25.3"

bash-5.1$ cargo build --release

Build Log
   Compiling object v0.25.3
error[E0583]: file not found for module `read_cache`
  --> /Users/inksplatters/.cargo/registry/src/github.com-1ecc6299db9ec823/object-0.25.3/src/read/mod.rs:14:1
   |
14 | mod read_cache;
   | ^^^^^^^^^^^^^^^
   |
   = help: to create the module `read_cache`, create file "/Users/inksplatters/.cargo/registry/src/github.com-1ecc6299db9ec823/object-0.25.3/src/read/read_cache.rs"

error[E0583]: file not found for module `dyld_cache`
 --> /Users/inksplatters/.cargo/registry/src/github.com-1ecc6299db9ec823/object-0.25.3/src/read/macho/mod.rs:8:1
  |
8 | mod dyld_cache;
  | ^^^^^^^^^^^^^^^
  |
  = help: to create the module `dyld_cache`, create file "/Users/inksplatters/.cargo/registry/src/github.com-1ecc6299db9ec823/object-0.25.3/src/read/macho/dyld_cache.rs"

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0583`.
error: could not compile `object`

To learn more, run the command again with --verbose.

Workaround?
Funny, but I followed rustc advice to create the files
bash-5.1$ touch /Users/inksplatters/.cargo/registry/src/github.com-1ecc6299db9ec823/object-0.25.3/src/read/mod.rs
bash-5.1$ touch /Users/inksplatters/.cargo/registry/src/github.com-1ecc6299db9ec823/object-0.25.3/src/read/macho/mod.rs

and I've got the compilation succeeded:
bash-5.1$ cargo build --release
   Compiling object v0.25.3
   Compiling object-test v0.1.0 (/private/tmp/object-test)
    Finished release [optimized] target(s) in 3.06s

environment
OS
bash-5.1$ sw_vers
ProductName:	macOS
ProductVersion:	11.4
BuildVersion:	20F71

rustc
bash-5.1$ rustc -vV
rustc 1.53.0 (53cb7b09b 2021-06-17)
binary: rustc
commit-hash: 53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b
commit-date: 2021-06-17
host: x86_64-apple-darwin
release: 1.53.0
LLVM version: 12.0.1

According to the source view on docs.rs, src/read/read_cache.rs is included in the published crate for 0.25.3:
https://docs.rs/crate/object/0.25.3/source/src/read/read_cache.rs

I don't have macOS some unable test your reproduction there, but it isn't a problem on Windows.
It's not a problem with the published crate. You can verify it contains these files with:
curl https://crates.io/api/v1/crates/object/0.25.3/download -L --output object.tar.gz
tar tzf object.tar.gz

This crate is used widely enough that people would have been complaining about it already if this was broken.
So I think your local registry is corrupted somehow. You could try deleting ~/.cargo/registry, but I can't provide more help than that.


Skill and icon fixes

Fixed some upside down skill icons in Monk.
Fixed Monk background file name so it shows now.
Fixed file name of the Master of Ice icon so it loads now.
Fixed skill text and icon for Poison Cloud.
Also ran "npm audit fix".  Things still seem to work but I don't know enough react or js to do anything else.  I honestly don't know what the changes to package-lock.json, package.json, and yarn.lock do, but I bumped the version number up to 1.1.5 because why not.

Awesome, thanks for fixing this stuff! 🎉
You didn't make any changes to skills.json did you? I'm guessing the diff is just because of formatting, but I wanted to check because that is just a generated file. The source of truth is actually a spreadsheet outside of this project, so it would overwrite the json.

This has been deployed, thanks again!

Sure, no problem!
Ah I did actually edit skills.json. The only one that was changed in there was Poison Cloud since it differs quite a bit from what's in game at the moment.

Got it, I will update the spreadsheet with that so it doesn't get lost.


When scope is disabled or deleted, Obo flow can still get access token

For the existing scope, two circumstances:

after disabling the scope
after deleting the scope

I expect the error can be returned immediately when I disable or delete a certain scope, instead of continuing to return available tokens.

@moarychan What do you mean by "scope is disabled or deleted"?

Hi @sangonzal , I have a web application as a resource server, then I want to disable a certain scope to deny access to the resources, AAD should protect my resources in real-time according to the current scope definition.

@moarychan After you disable the scope, you are still able to acquire tokens for that scope?
After you disable or delete the scope, and acquire a new token, can you paste the access token in jwt.io and share the value of 'scp' claim?

Hi @sangonzal ,  thank you for your feedback, I hope to explain in detail:

The simple case is that will access the resource directly, when I disable the scope, I can still acquire a new token that contains the same scope.

eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiIsIng1dCI6IjVPZjlQNUY5Z0NDd0NtRjJCT0hIeEREUS1EayIsImtpZCI6IjVPZjlQNUY5Z0NDd0NtRjJCT0hIeEREUS1EayJ9.eyJhdWQiOiJhcGk6Ly9jdXN0b20tY2xpZW50LWlkIiwiaXNzIjoiaHR0cHM6Ly9zdHMud2luZG93cy5uZXQvMWQxYTA2YTktYjIwYS00NTEzLThhNjQtZGFiMDhkMzJjOGI2LyIsImlhdCI6MTYwOTM4MjY4NSwibmJmIjoxNjA5MzgyNjg1LCJleHAiOjE2MDkzODYzOTQsImFjciI6IjEiLCJhaW8iOiJBU1FBMi84U0FBQUFST1VGNm4vOWdvbTlJRkhpY243VTBzTEVuZ3RPZlAxQjh1UGxUOTF5ZDJRPSIsImFtciI6WyJwd2QiXSwiYXBwaWQiOiIwZWUyYTg0ZS1iMjU1LTQxOGYtOTNiNi1lMmY1ZmU4NTBmODQiLCJhcHBpZGFjciI6IjEiLCJmYW1pbHlfbmFtZSI6ImNoZW4iLCJnaXZlbl9uYW1lIjoiYW15IiwiaXBhZGRyIjoiMTY3LjIyMC4yNTUuNzMiLCJuYW1lIjoiYW15IGNoZW4iLCJvaWQiOiJhYmQyOGRlMS05YzM3LTQ4OWQtOGVlYy1mZWVlZjRkMjc0YTMiLCJyaCI6IjAuQUFBQXFRWWFIUXF5RTBXS1pOcXdqVExJdGs2bzRnNVZzbzlCazdiaTlmNkZENFI0QUFJLiIsInNjcCI6IkZpbGUucmVhZCIsInN1YiI6InVnR0NDeGN2Z1JaM01aSmthQXNoWkhsNTlaSjY4WEJSMnZ5b2hEbjE5Y2ciLCJ0aWQiOiIxZDFhMDZhOS1iMjBhLTQ1MTMtOGE2NC1kYWIwOGQzMmM4YjYiLCJ1bmlxdWVfbmFtZSI6ImFteUBtb2FyeS5vbm1pY3Jvc29mdC5jb20iLCJ1cG4iOiJhbXlAbW9hcnkub25taWNyb3NvZnQuY29tIiwidXRpIjoiS2gyb3U4SmVBMDZFMzNEbXFVNWJBQSIsInZlciI6IjEuMCJ9.WjqVNemeaghNhRWVHWMoLto5RNDp6ayPxXZKK3mqprXC5jkyiVJayfzIhkDAYd-5JKGWwlj0FMYubb17rm9eKVTS1gYF59RMEJ4WlSojmGfn5WeEBePFW-uM3gS1qtSliXTVeqjYcPCs92D3ZuxjMlnIU4xTSwu_NVlnRoNzyqyvk1FgG3WB1VyWF7F5L_I5v8Ml6S5v8f27o1ulML-lU4ve41rbCSsvreW781mTW14Dq5wJsKWzIqUEWu6ovSSp35OMDNvPnlJwLzFpVLgiaiZhEeNjHPcmDZa4JaTUsYjQoYy-n7515Y_Fx8LBQ8dOwNXFRkoUCCGIYlN45zv1DA

If I use the same usage with the below case 2, the access token will also be returned successfully.

Complex case
There are 2 resource server applications protected by AAD, one is res1, another one is res2, res1 will depend on res2. Normally res1 can access res2 successfully when the exposed api of res2 are added to the api permission of res1.

But when I disable or delete the exposed api of res2(scope), the Obo flow to acquire the access token of res2 still works.
In both cases, the same problem is the access token should not be returned successfully.

@moarychan I was able to reproduce this behavior on my end. I have reached out to the team that owns the "Expose an API" blade in the portal and I'm waiting to hear back.

@moarychan I was able to reproduce this behavior on my end. I have reached out to the team that owns the "Expose an API" blade in the portal and I'm waiting to hear back.

MSAL uses token caching, the token will be sent for a while from the cache. The correct solution here is to forbid users in the organization from getting access token to the downstream api.


parameter reference origin

The reference origin parameter must have increment number part with 10 digit long (instead of 14 today)

Waiting confirmation of fix from GLS


massively flesh out cycle docs

This kinda got out of hand.

This is incredible. Thank you so much.


All WSA app crashes after "Starting WSA" splash screen, only WSA settings is working

System: Windows 11 22000.348, WSA version: 1.8.32828.0
After patching all four IMG files with the script (no error messages shown) and registering the modded AppxPackage, the WSA Settings app will appear in start menu and can be launched. However, clicking "Files" or "Show developer options" and WSA will immediately crash after "Starting WSA" splash screen. The Amazon App Store start menu entry also won't be created.
There's no related error message in Windows Event log, either under "Windows Protocols\Applications" or "Program and service protocols\Microsoft\Apps".
Unmodded WSA will launch properly.

After I clicked "Turned Off" in settings, it started working for me.

Didn't work for me... stopping and resetting WSA won't help.

Same here. The file was successfully edited and modded. Install went through. Can't manage developer options or launch Play Store because it is simply not there.

Same problem :(
"Turned Off" doesn't work for me. i have the same version WsaPackage_1.8.32828.0_x64_Release-Nightly

same here.

At this point i used the Magisk on WSA. also has GApps and Works....

Same issue here.

Same issue. I double checked and rerun patching and installation instructions

Same for me..
WSA 2203.40000.3.0_x64_Release-Nightly with GApps

did you find any solutions guys?

Magisk

how can i do that?

Turned OFF WSA from WSA Settings, Changed the GPU to Different Open Files or any app, If not working Turn off and change GPU to another and Open Files

Turned OFF WSA from WSA Settings, Changed the GPU to Different, Click Files or any app, If not working Turn off and change GPU to another and Open Files
worked, thank you!

Maybe my issue is unrelated, however I had a similar problem, wsa crashing upon starting, its caused by third party software listening for DNS on port 53, such as acrylic dns. Only when this is disabled does WSA stop crashing.

This was the solution for me! Thank you very much.
I figured that a software called DNSService.exe was running in the background all the time and it was taking port 53.
To find out if your port 53 is taken or not run cmd as administrator and then run this command: netstat -ab
The list of softwares that are listening on different port will be shown and you can close them using task manager

Yeah help me


Substitution on runOnReady

Which version are you using?
v1.6.0 docker with ffmpeg
Which operating system are you using?

[ ] Linux amd64 standard
[x ] Linux amd64 Docker
[ ] Linux arm64 standard
[ ] Linux arm64 Docker
[ ] Linux arm7 standard
[ ] Linux arm7 Docker
[ ] Linux arm6 standard
[ ] Linux arm6 Docker
[ ] Windows amd64 standard
[ ] Windows amd64 Docker (WSL backend)
[ ] macOS amd64 standard
[ ] macOS amd64 Docker
[ ] Other (please describe)

Describe the issue
Description
Describe how to replicate the issue
I encounter a problem, I want to format the name of the file generated by ffmpeg
Everything works normally with this line:
runOnReady: ffmpeg -loglevel verbose -use_wallclock_as_timestamps 1 -rtsp_transport tcp -i rtsp://localhost:$RTSP_PORT/$RTSP_PATH  -fflags nobuffer -vcodec copy -f segment -reset_timestamps 1 -strftime 1 -segment_time 30  /recordings/PARA456_123_%Y-%m-%d_%H-%M-%S.mp4
ffmpeg generates these (correct) files:
PARA456_123_2024-03-22_09-18-22.mp4
PARA456_123_2024-03-22_09-17-52.mp4
...
Info:
echo $RTSP_PATH : PARA456/123
echo ${RTSP_PATH////_} : PARA456_123
I change the line to:
runOnReady: ffmpeg -loglevel verbose -use_wallclock_as_timestamps 1 -rtsp_transport tcp -i rtsp://localhost:$RTSP_PORT/$RTSP_PATH  -fflags nobuffer -vcodec copy -f segment -reset_timestamps 1 -strftime 1 -segment_time 30  /recordings/${RTSP_PATH////}%Y-%m-%d_%H-%M-%S.mp4
ffmpeg generates these (wrong) files:
_2024-03-22_09-22-27.mp4
_2024-03-22_09-22-54.mp4
The substitution does not seem to be operational.
Do you have an idea ?

start the server
publish with ...
read with ...

Did you attach the server logs?

no
Did you attach a network dump?

no

You should use the MTX_PATH and not RTSP_PATH in the expression for the file name. For each hook (in the README but also in mediamtx.yml ) the variable you can use in the expressions are specified, and you can see there there's no RTSP but rather MTX_PATH.

Hello, in order to provide inter-operability between Linux and Windows, we're not using Bash and its features (like variable replacement, i.e. ${RTSP_PATH////_}) but a simpler system that only provides $RTSP_PATH and ${RTSP_PATH}. If you want to use  ${RTSP_PATH////_}, put everything into a bash script and call it with runOnReady:
runOnReady: /my/home/my_script.sh

with my_script.sh:
#!/bin/bash
ffmpeg -loglevel verbose -use_wallclock_as_timestamps 1 -rtsp_transport tcp -i rtsp://localhost:$RTSP_PORT/$RTSP_PATH -fflags nobuffer -vcodec copy -f segment -reset_timestamps 1 -strftime 1 -segment_time 30 /recordings/${RTSP_PATH////}%Y-%m-%d_%H-%M-%S.mp4


improve player-mpv

Some work is to do here. The Script uses not the skeleton template at this moment. The reason for this is simply that it was copied from the Polybar wiki and was never touched since then.

[ ] use skeleton
[ ] rewrite if neccessary

@x70b1 How come this was removed? I thought it worked fine.

We had this code:
ARTIST=$(ps -u | less | grep -v vim | grep -v grep | grep 'mpv' | head -n1 | cut -d '-' -f 3- | cut -d ' ' -f 2- | cut -d '-' -f -1 | head -c -2)

Thats not very clean even if it works. That's why I've decided to drop it for now.
tl;dr: We need a better one. :wink:


Why ef keeps generating a nullable foreign key to an extended IdentityRole class?

I am trying to add another key to my roles identity table, DatabaseId. ef keeps generating the key as nullable, I tried to enforce it with DataAnnotations using [Required] tag but its not working, what am I doing wrong here?
I followed this article as well, Relationships, Navigation Properties, and Foreign Keys but its not working in this case,
These are my entities,
    public class PracticeDatabase
        {
            public PracticeDatabase()
            {
                UserDatabases = new Collection<UserDatabase>();
                PracticeOccupation = new Collection<PracticeOccupation>();
                ApplicationUserRole = new Collection<ApplicationRole>();
            }
            [DatabaseGenerated(DatabaseGeneratedOption.Identity)]
            public Guid Id { get; set; }
            [Required]
            public string Name { get; set; }
            public string NormalizedName { get; set; }
            public string UrlPath { get; set; }
            public ICollection<UserDatabase> UserDatabases { get; set; }
            public ICollection<PracticeOccupation> PracticeOccupation { get; set; }
            public virtual ICollection<ApplicationRole> ApplicationUserRole { get; set; }
        }

    public class ApplicationRole : IdentityRole
    {
        [Required]
        public Guid DatabaseId { get; set; }
        [ForeignKey("DatabaseId")]
        public virtual PracticeDatabase Database { get; set; }
    }

this is the migration build part,
            migrationBuilder.CreateTable(
                name: "AspNetRoles",
                columns: table => new
                {
                    DatabaseId = table.Column<Guid>(nullable: true),
                    Id = table.Column<string>(nullable: false),
                    ConcurrencyStamp = table.Column<string>(nullable: true),
                    Discriminator = table.Column<string>(nullable: false),
                    Name = table.Column<string>(maxLength: 256, nullable: true),
                    NormalizedName = table.Column<string>(maxLength: 256, nullable: true)
                },
                constraints: table =>
                {
                    table.PrimaryKey("PK_AspNetRoles", x => x.Id);
                    table.ForeignKey(
                        name: "FK_AspNetRoles_PracticeDatabases_DatabaseId",
                        column: x => x.DatabaseId,
                        principalTable: "PracticeDatabases",
                        principalColumn: "Id",
                        onDelete: ReferentialAction.Cascade);
                });

@embryologist This is because there is now an inheritance hierarchy which needs to be mapped to the database. EF uses a TPH mapping strategy for this, which means that the same table can have rows for the base class and the derived class. Any properties on the derived class must be mapped to nullable properties in the database because they will have no value when the row is for the base class.


If an exception has a cause, have this cause as part of the "problem", too

Closes #34

please rebase


[request] Button "+" not needed

In my opinion, the "+" button is unnecessary after entering the settings for synchronized lists.
It is confusing for the user that he can add synchronization lists for the Nextcloud server. Although there is adequate information for the user after his activation.

Answers were given in #920. I close.


Single namespace for senders (ports, nodes and constants)

Besides message literals and different kinds of expressions/statements we have these 3 types (at the syntax level) of senders - ports without nodes, nodes without ports and constant references - that could be simplified
:port -> ...
node -> ...
$const -> ...

Existing syntax simplifies compilation - at the parsing step it's obvious what we are referring to. However, it makes programs a bit noicer. What if there would be single namespace, like in most programming languages?
const c1 int = 42

def Main(start any) (stop any) {
    n1 Node1
    n2 Node2
    n3 Node3
    ---
    start -> c1 -> n1 -> n2 -> n3 -> stop
}

This is especially significant if we use features such as deferred connections, binary/ternary operations or match expressions
(:a + :b) -> match {
    :c: :d
    :e: :f
} -> :h

vs
(a + b) -> match {
    c: d
    e: f
} -> h

(This is made up example but it's possible to imagine that some stuff could become noisy rather quickly)

I don't think it's gonna happen. It takes a lot of changes and makes everything much harder, I don't think existing syntax is bad