Specific macro that works on macOS is not working with latest Linux snapshot

Edit: More specific info is available in comments down below: https://github.com/apple/swift/issues/68345#issuecomment-1712458495
Description
Latest Linux snapshot is supposed to have linux support, but build of DiscordBM macros PR fails in latest linux snapshot (see the logs below)
The same PR works as expected in Xcode 15 beta 8.
The logs:
macro-linux-failure.txt
Steps to reproduce
Use what is used in the attached CI (here).
Expected behavior
To work fine like on Xcode.
Environment

Swift compiler version info (macos):

swift-driver version: 1.87.1 Apple Swift version 5.9 (swiftlang-<IP_ADDRESS>.106 clang-15<IP_ADDRESS>)
Target: arm64-apple-macosx14.0

Xcode version info: Xcode 15 beta 8

Update: Added the logs

IMO the issue title there is misleading, I don't see any failures related to macros per se in the build log. The build errors mention Codable synthesis, but no specific macros. If macros are involved, they might be expanding to code that's invalid on Linux, but that should be filed as an issue against packages that provide those macros, not on the Swift repository itself.

So first thing to just repeat is that these all work on macOS unlike on Linux.
I do believe this is a macros on Linux problem as the UnstableEnum macro does have some stuff to do with Codable.
I also do think the errors might be quite misleading, but i still believe they must be something related to the macro on Linux.

The macro comes with some documentation: https://github.com/DiscordBM/DiscordBM/blob/31a17d916b22d5efddd0f383d9c617b348883f36/Macros/UnstableEnumMacro/Macro.swift#L29

So first thing to just repeat is that these all work on macOS unlike on Linux.

The fact that some code works on macOS is by no means a guarantee that it will work or even build on Linux. Each platform may need some adjustments to make arbitrary code build and run correctly. The issue should be filed against the package that implements UnstableEnum macro to add Linux support, unless you're able to show that a specific underlying macro infrastructure as specified in Swift Evolution macro proposals does not work on Linux.

I understand that not every macOS thing will work on Linux.
I believe the problem comes from the macro implementation on Linux and I don't think anything in the proposal notes that Linux and macOS macros will not have feature parity.
The implementation of the macro-related stuff do not use anything special that works on Linux but not macOS as far as i can tell.
UnstableEnum is an internal macro of DiscordBM. I wrote the macro and i believed it's a problem in the code, i would have just fixed my code 😅

Would you be able to attach a self-contained reproducible sample code that's smaller than the whole DiscordBM package?   It should only include a specific macro that you can show builds correctly on macOS, but not on Linux. That would make diagnosing this much easier than reviewing a build log of a relatively big package that has multiple dependencies.

Unfortunately I'm in a place with pretty bad internet connection. I've already disconnected 5+ times trying to files this issue in the hopes that in incomplete macros implementation doesn't reach the 5.9 release.
I understand I should provide a minimal reproducible sample code and that's what i always try to do, but i don't think i'll be able to provide that this time, unfortunately.
I understand if it's too much to ask to investigate this issue until i provide the sample code, although i hope otherwise as it might already be too late by the time i'm able to provide that (in 48+ hours?).

Here is a repo to reproduce the inconsistency between macOS and Linux behavior:
https://github.com/MahdiBM/linux-macro-issue
Try to build on macOS and Linux and you'll notice the inconsistency.
It appears something is wrong in conformance-synthesizations in macros on Linux. In this case, it's an Equatable conformance.
On linux you'll see the following error using swift-5.9-nightly (swift-5.9-DEVELOPMENT-SNAPSHOT-2023-09-05-a) :
/workspaces/linux-macro-issue/Sources/Macro/Kind.swift:17:27: error: value of optional type 'Kind?' must be unwrapped to a value of type 'Kind'
        if Optional<Self>.some(.announcementThread) == .announcementThread {
                          ^
/workspaces/linux-macro-issue/Sources/Macro/Kind.swift:17:27: note: coalesce using '??' to provide a default when the optional value contains 'nil'
        if Optional<Self>.some(.announcementThread) == .announcementThread {
                          ^
                                                    ?? <#default value#>
/workspaces/linux-macro-issue/Sources/Macro/Kind.swift:17:27: note: force-unwrap using '!' to abort execution if the optional value contains 'nil'
        if Optional<Self>.some(.announcementThread) == .announcementThread {
                          ^
                                                   !
error: fatalError

More news. I simplified the whole macro, and found out what triggers the bug.
In the non-working code, i declare the macro as:
@attached(
    extension,
    conformances: RawRepresentable, Equatable, Hashable
)
macro UnstableEnum() = #externalMacro(module: "UnstableEnumMacro", type: "UnstableEnum")

This makes it not work on Linux, but work on macOS.
If I change the macro declaration to this, the macro will work on both platforms:
@attached(
    extension,
    conformances: RawRepresentable
)
macro UnstableEnum() = #externalMacro(module: "UnstableEnumMacro", type: "UnstableEnum")

Basically removing Equatable and Hashable from the conformances list.
On linux it apparently doesn't synthesize a conformance if the macro claims to provide it? But on macOS it'll synthesize the conformance as if it's some normal code when an explicit conformance is not provided.

Generally it seems like macros on macOS provides synthesized conformance even when the conformance is explicitly claimed by macro. Linux is probably having the correct-er behavior? If yes, I would expect some macro errors when a macro claims a protocol conformance but doesn't provide it. Though these errors might already be too late to happen on Swift 5 since 5.9 will be released soon?

cc @DougGregor @hborla

Just so it's public knowledge: Someone mentioned this to me a while ago, and i think the problem comes down to the fact that this macro adds a new enum case to enum, and there are some bugs around that in the compiler.

If there is already a proper issue for that, feel free to close as duplicate.

Now that i'm looking, i can find these 2 similar issues: https://github.com/apple/swift/issues/69216, https://github.com/apple/swift/issues/67862

I added some comments in this issue that were supposed to be in another issue. I've removed them now to prevent confusion considering they weren't related to this issue.


APIProject.Run fails with "inappropriate ioctl for device" error

I'm trying to run libcompose to start some Docker containers in some Go integration tests.
Here's the TestMain function that uses libcompose to set up and tear down the containers:
func TestMain(m *testing.M) {
        project, err := docker.NewProject(&ctx.Context{
                Context: project.Context{
                        ComposeFiles: []string{"docker-compose.yml"},
                        ProjectName:  "ts2kusersvc",
                },
        }, nil)

        if err != nil {
                log.Fatal(err)
        }

        err = project.Up(context.Background(), options.Up{})

        if err != nil {
                log.Fatal(err)
        }

        // Without this blog, the code runs successfully
        var code int
        code, err = project.Run(context.Background(), "ts2kusersvc",
                []string{"-h"},
                options.Run{},
        )
        // End problematic code block

        if err != nil {
                log.Fatal(err)
        }

        code = m.Run()

        // Tear down Docker containers
        err = project.Down(context.Background(), options.Down{})

        if  err != nil {
                log.Fatal(err)
        }

        os.Exit(code)
}

The call to Run() in the above code fails with an "inappropriate ioctl for device" error, which I believe trickles up from Container.Run when calling term.SetRawTerminal.
I'm able to successfully execute the equivalent to my call to APIProject.Run via docker-compose run ....

can you specify what version your docker daemon is running?

$ dockerd --version
Docker version 1.13.0, build 49bf474

sorry for not being able to address this.  I want to suggest an issue with a volume bind (are you mapping a local path) but I haven't had any time to put any real thoughts together.
If you are using any volume binds, or custom volume plugins, can you specify:

do all local volume paths exist (are any of them symlinks or cross partition links)
what volume plugins you are using
if you are populating any system volumes from image volumes.

Hi,
so I think I just encountered the same bug here. I use libcompose to build our apps and when it's run inside Gitlab CI it fails with inappropriate ioctl for device. docker-compose run used to work, it was the setup we used before this tool.
I do bind 2 volumes to perform my tests. For example, I bind the src directory and pom.xml to my container when running a maven container for my tests.
Not sure where to go from there


Blazor: Support prerendering for static sites

Is your feature request related to a problem? Please describe.
There is prerendering for server-side Blazor and for client-side using Index.cshtml (#8842, #10626), but this requires a web server (Razor Page). I hope there is a way to also perform some sort of prerendering for sites that are served completely statically from Azure Storage, dotnet serve or similar.
Describe the solution you'd like
The basic premise would be that there is a way to prepopulate the <app> component(s) in index.html replacing the default Loading... text either at build or publish time (msbuild) or through a gesture from the CLI or tooling.
Since there can be only one index.html to be served as the index.html on a static site, there are a number of ways to let the code run to prerender index.html with some basic presumptions or perhaps static configuration and save it in the appropriate place in index.html.
Describe alternatives you've considered
There is no suitable way to do this today afaik besides hacking it through manually opening a client-side blazor web page and then copying say the content of the <app> element from the browser developer tools after loading the / page into index.html or to do this (semi-automanually) with a browser control in e.g. WinForms, but this is troublesome to keep updated and/or to integrate into an automatic build/deploy.
Additional context
It would be great to serve a default pre-populated index.html, especially for simple sites.

Thanks for contacting us, @ericwj.
This is not something we plan to do in the near future.


[Migration Required][QA Prep Required] Feature/Fix incorrect last_logged date on existing forks [PLAT-1131]

❗ Before merging, make sure this is up-to-date with develop! (is in same release as https://github.com/CenterForOpenScience/osf.io/pull/8808/ - which also has migrations)
Purpose
Currently, newly created forks receive an incorrect last_logged date. We should find the affected forks and fix the dates.
Changes
Migration iterates over all forks and find those where the most recent log is the fork log and sets last_logged date to the date of that log
QA Notes
Create a few forks and note the last_logged date, as well as noting the last logged date of a few nodes.   Make sure the last action that has occurred on the forks was the node_forked action.  Verify that last_logged is the same date as the node_forked action.  If the last log was not related to forks the last_logged date should not have changed.
Documentation
None needed
Side Effects

Ticket
https://openscience.atlassian.net/browse/PLAT-1131

@Johnetordoff, that's my understanding, if a fork has had something else changed, you would expect it's last_logged date to be correct already.

Headed to staging3

Double check if migration needs to be rebased again before merging

Double check if migration needs to be rebased again before merging


Is it possible to do text to code with BERT model?

Hi, I want to generate codes with the BERT model. Do you plan to share the BERT model for text code?

You can use this repo for generation. You just need to change input to text and output to code.

I appreciate it. Thank you so much.


Enable Mypy

Changes
enable and comply with mypy type checking

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.362%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
901

Relevant Lines:
916

💛  - Coveralls


Flyout: make it obvious there are features inside it

The logo takes up a lot of space and doesn't exactly communicate "click here for hosted features".

(@agjohnson in https://github.com/readthedocs/addons/pull/360#issuecomment-2286908369)

I agree that the logo would benefit from some change. The current state looks more like an advertisement for RTD than a feature of the opened project’s docs; this disturbs users' focus.

(@orangesunny in https://github.com/readthedocs/addons/pull/360#issuecomment-2288462774)

I'm opening this issue here to talk more about this and find a way to keep the Read the Docs branding on the flyout while communicating there are hosting features behind a click on the it.
There is an issue opened about re-designing the flyout completely as well at #53

It's also worth mentioning that we lost the dropdown caret in this version of the flyout. Without this visual clue, it's not clear the menu even expands:

I think the collapsed menu is not the best place to advertise RTD -- at very least for our full wordmark and logo combo. The user hasn't interacted with any features yet, which makes the full logo and wordmark on the flyout feel more like subtle brand placement than a feature users should interact with.
I think a solution is to move our full branding into the flyout, where the reader is interacting with our features. This leaves the most valuable real estate, the collapsed menu, open for features the reader/maintainers need. We're limited on how big we can make the flyout before it will become a nuisance.


quick grid (FancyZones) configuration transition

Description of the new feature / enhancement
I would like to be able to change the grid configuration AND keep snapped the windows already in place.
Scenario when this would be used?
Say I have variations of a 3 zones grid eg., 1/2/1 (for columns, (or /2/* in XAML)) and 1/1/1 but I want to rearrange the windows from one configuration to the other quickly, so far I need to change the configuration and the resnap each window, which take time and many automatizable operations.
In the case of several variations of eg., 2 zones or 3 zones (2 zones, versions a,b,c, 3 zones, versions d,e,f,g) that would be very practical in order say to have bigger area for one app which need more attention or magnification.
Supporting information
No response

@mprevot this is already possible by selecting the option highlighted below from the FancyZones tab in the Settings menu:


molecule always reports docker based hostnames as localhost

Issue Type

Bug report

Molecule and Ansible details
molecule, version 2.19.0

Molecule installation method (one of):

pip

Desired Behavior
Be able to see a meaningful hostname in the output, so you would figure out on what platform you got a failure.
Actual Behaviour (Bug report only)
--> Scenario: 'default'
--> Action: 'destroy'

    PLAY [Destroy] *****************************************************************

    TASK [Destroy molecule instance(s)] ********************************************
    changed: [localhost] => (item=None)
    changed: [localhost] => (item=None)
    changed: [localhost] => (item=None)
    changed: [localhost] => (item=None)

All steps report "localhost", even when hostname is mentioned in platform definition. In fact I would argue that the platform.name should be the default value used for hostname, in order to avoid haiving to write something like:
platforms:
  - name: centos-7
    hostname: centos-7
    image: centos:7
  - name: fedora-28
    hostname: fedora-28
    image: fedora:28

Isn't this because the create.yml has a connection: local option configured, so each task is executed on the localhost and not on the centos-7 or fedora-28 host? This is Ansible specific, not Molecule.

Ok, lets not close it and move it to ansible. We need to find a way to make the UX better here because if I cannot distinguish between various platforms the output become close to useless.
It may be tricky to solve but we need to find a way to do it.

ssbarnea Yes the task is running on the localhost that is why you see changed: localhost.
You could run molecule with --debug to see more output (it adds -vvv to ansible) or specify the amount of v in the molecule.yml:
provisioner:
  name: ansible
  options:
    v: true

But the changed: localhost is only visible in create, destroy, or other stages which run with connection: local. Thinks of these stages as preparation for the the converge which is the main test of the role.
The converge playbook runs on the the specified platform and returns the hostnames instead of localhost.

The create and destroy actions are executed on the localhost. You can see the playbook here. So basically, the change is on the localhost, so the hostname reflects. Altough I'm not sure I understand why the item is none. Shouldn't the dictionnary of the molecule instance appear instead of none?
@wilmardo  I tried running the test scenario with the vvv option in molecule.yml. However, I think the verbosity only affects the execution on ansible in the docker containers, because nothing changed in the output, except when gathering the facts of the instance (I don't have anything else in the role, I juste created a dummy...). I don't have any more information on the create or destroy action. In any case, I'm not sure this is a bug. Maybe some tests could be conducted with the docker_container module in ansible to see its behavious outside of molecule, see wether instances are shown or not.

@AlexisLessard The verbosity in the molecule.yml indeed only effects the tasks executed in the docker containers. To see output of the molecule actions like create and destroy you should add --debug to the molecule command:
molecule --debug test


Ci migrations

See https://github.com/mrc-ide/packit/actions/runs/10834351430/job/30063312461 for an example of a failed run.


Investigate: move off dependency on sync SQLite (and multi-node scaling)

Using better-sqlite3 for synchronous writes also meant that writes block reads for the whole server, which is convenient from an abstract standpoint but also bad from a scaling and adaptability standpoint. Feels like being backed into a corner. I'll have a hard time supporting any kind of multi-node scenarios with this limitation.
I definitely relied on this back before server_order, but now that I have that in place, do I still need it?
The big question is... how do I be sure that by the time I've gathered operations for a sync response, that if any more come in, they are appropriately propagated to the client? Supposing new messages arrive between the query and the result... the client hasn't finished sync so it ignores op-re... right now it seems it won't get those gap messages until it next does full sync.
I could do bookkeeping about in-flight syncing clients on the server and put in some buffers. But this feels less than elegant. Not out of the question, though. Not like everything in this project is elegant.

Another thing that would block multi-node scaling is server order (unless I did something like LiteStream and only allowed one writer node, but that kind of feels too rigid when I've already got CRDTs in use...).
Besides a centralized server order, how can I ensure that server nodes or clients don't miss messages?
Seems like a parent system might be helpful here. If the parent ID (timestamp) isn't recognized, ask the sender for it, ad infinitum. Are there edge cases? And who decides parent - client or server?
1 option... server decides parent (most recent operation). Only servers worry about parent chains. But with server order gone, I need to fill in that gap for client sync.
(need to keep stewing on this)
Ultimately it would be great to just have servers join some discovery network and start replicating all incoming messages out to their peers, with no other necessary plumbing for multi-node. Normal initial sync still needs to happen for nodes as they join the network. This will be a much larger sync since servers presumably hold all possible libraries.
Another way to approach might be to shard libraries onto different servers. That may be a more scalable way to go. It loses the nice locality of being able to connect to a nearby server and participate in a library that's distributed globally, though. Perhaps a hybrid where libraries can be replicated to different nodes but aren't necessarily required to. If a particular node gets a request to sync to an unknown library it consults a registry and establishes a new sync relationship with another node that has that library. This makes a distributed sub-network for that library in only the regions which have participants.
(....still need to keep thinking!)

Parent references in operations would make baselines kind of confusing. What is the parent of the first op after the baseline? What happens when ops are flattened to baseline?
Adding parent references may make baselines obsolete, though, if they enable another way to do history garbage collection.
e.g. compressing a longer chain of ops to one new op and reparenting. but anything that changes history like that seems incredibly fragile.

I'm going to punt on parenting for now, as well as any multi-node ideas.
For the moment this effort will focus on removing dependence on synchronous behavior of better-sqlite3, so at least async storage can be supported, opening up other backends like postgres or durable objects, etc.
To that end I've made progress on the async-server-storage branch. Tests all pass after converting to kysely (still sqlite backed). However, I'm not totally assured here. I'm also not sure if this has made performance worse.
TODO:

[ ] Run before/after benchmarks with async-server-storage branch
[ ] Create a unit test suite which tests the exact messages received from the server under different conditions to make assertions about things like server order and messages - e2e tests can only approximately replicate behavior here, I'd like to know for sure that particular scenarios produce sensible message ordering and content (i.e. you get all operations)

As for scaling, I think sharded databases has more potential here. Keep libraries on a single node, but load-balance them across multiple nodes as scale grows.
To that end I'm thinking more about scaling in #365


Ghidra Server Not Working in version 9.1.2

Describe the bug
Seems as though Ghidra server connection from clients is not working in Version 9.1.2.
To Reproduce
Steps to reproduce the behavior:

Start the Ghidra server on a cloud instance
Open ports 13100-13002
Try to connect to from your host machine's Ghidra client on the default port (13100)

Expected behavior
The login prompt is presented. However, it is not.
Environment (please complete the following information):

OS: Ubuntu 18.0.4
Java Version: open jdk 11
Ghidra Version: 9.1.2

Additional context
Upon bumping down to Ghidra server version 9.0 and attempting also a failing. Seems as though the Ghidra client version must match the server version? Unclear. I did not also decrement my client version when after degrading my server version.

Could you provide more details about how its "not working"?
I would suggest setting up a server on your local machine, verifying that you can configure it and connect to it, and then trying your real setup.
If you are still having problems, please attach log files from the server that show the failed connection attempts, etc.

Waiting for response.  Feel free to re-open this issue.


Cannot disable Desktop notifications

I just upgraded to Version 2.4.0, and under "My Account" --> "Messages"  --> "Desktop Notifications", I see they are enabled and they are definitely working.  However, I don't see anyway to disable them?

You probably meant to post this issue under RocketChat/Rocket.Chat, as this is the repository of the docs?

Please Reopen this on RocketChat/Rocket.Chat. Thanks!


[Bug]: Kebab menu of the application overlaps on the application when the browser is minimised

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When the website is minimized the and user navigates to the home page and tries to open the menu of the application it is observed that the menu overlaps on the application and changes can not be viewed by the user.
Expectation:
We can open it to the right of the application making the changes visible to the user
Steps To Reproduce

Navigate to home page
open the menu of any application
Minimize the browser
and observe

Environment
Release
Version
Cloud

This is fixed.


Opening console from AWS Apps Portal not working

Extension Version
1.8.8
Description
With this extension enabled in Firefox, the sso portal sits loading for a while after clicking into an account. "Signing into account xxxxxx"
Eventually 404's
Code: NoSuchKey
Message: The specified key does not exist.
Key: start/undefined

Trying a second time does make this work, however it does not open the console in a Firefox container - just in the main session
Disabling the extension removes the unexpected behaviour.
Browsers
Firefox
OS
Mac

I'll check this out soon, likely related to the new AWS access portal.

I'm not able to reproduce this yet, but I know the page you're talking about.

Something of note - when upgrading the version I was hit with this error in the console.

Again disabling the plugin allowed the roles to load correctly.
I remove the plugin and re-installed it and the console appears to be functioning correctly now, so thanks!
Is it expected behaviour that clicking into a profile from the sso portal opens the console not in a container. Using the extension popup correctly opens the console in a session as per the settings.

@georgepstaylor I think I may have messed up portions of the user config during versions that caused this.

Is it expected behaviour that clicking into a profile from the sso portal opens the console not in a container.
Hmm, I didn't realize it wasn't working from the directory page. I'll check that out.


Content tree item has a grey border

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have read the contributing guidelines

Describe the issue
The default content tree we-component currently has a grey border. Looks like a similar bug as what was happening with the dropdown menu.

Reduced test cases
No response
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome
What is the issue regarding ?
@trimble-oss/modus-web-components
What version of npm package are you using ?
No response
Priority
Medium
What product/project are you using Modus Components for ?
Trimble Creator
What is your team/division name ?
Nexus
Are you willing to contribute ?
No
Are you using Modus Web Components in production ?
No response

@davidtsilcock What is the bug ?

The grey border. I assumed it was a bug as the grey border around items in a dropdown was also labeled as a bug. Might be a feature though?

@davidtsilcock issue # https://github.com/trimble-oss/modus-web-components/issues/1454 is a bug because the dropdown list items are not supposed to have borders, so are you proposing a borderless Content tree?

Yep! I suppose it is a feature then.

A few images for context. In Trimble Creator, we'd like our content tree to go from this:

to looking more like this:


Added a bunch of additional self-governing overseas territories

to the list of countries, even though their status as independent countries is somewhat ambiguous.
Any objections?

Coverage remained the same at 92.653% when pulling 3895dcfabb8725d4f217c6307903e5fccffebe3a on add-other-overseas-territories into b9aa1fb1860d040a3ebb368783f89cf659bf76e5 on master.

Looks reasonable to me.

Thanks, Nathan.
On Sat, Oct 22, 2022 at 1:59 PM Nathan Wilson @.***>
wrote:

Looks reasonable to me.
—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/1182#issuecomment-1287870296,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYTNNKDPKXFKAHNSQF6HF3WEQTPRANCNFSM6AAAAAARLV3PJM
.
You are receiving this because you authored the thread.Message ID:
@.***>


[SMALLFIX] Modify PrimarySelector.java  SECONDARY; --> SECONDARY,

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17138/
Test PASSed.


Support next v15

Fixes #71
See blog post and upgrade guide.
Changes:

Bump next and eslint-config-next version to 15.0.0
Use async/await for headers()
Add new examples for next v15 (copied from v14 examples, modified for async/await)

 ⚠ Invalid next.config.js options detected:
 ⚠     Unrecognized key(s) in object: 'swcMinify'
 ⚠ See more info here: https://nextjs.org/docs/messages/invalid-next-config

https://github.com/kubetail-org/edge-csrf/issues/71

in next15-approuter-html-submission:
We detected TypeScript in your project and reconfigured your tsconfig.json file for you.
   The following suggested values were added to your tsconfig.json. These values can be changed to fit your project's needs:

   	- target was set to ES2017 (For top-level `await`. Note: Next.js only polyfills for the esmodules target.)

https://github.com/kubetail-org/edge-csrf/issues/71

pnpm lint and pnpm build seem to be failing for me on the v14 and v15 sentry examples @amorey FYI

what error are you getting when you run pnpm lint & pnpm build on the sentry examples?

It's possible I have something messed up with how I've installed the examples

View terminal output
><EMAIL_ADDRESS>lint /Users/Stef.Jones/src/edge-csrf/examples/next15-approuter-sentry
> next lint

./app/api/sentry-example-api/route.js
Error: Parsing error: [BABEL] /Users/Stef.Jones/src/edge-csrf/examples/next15-approuter-sentry/app/api/sentry-example-api/route.js: Requires Babel "^7.22.0", but was loaded with "7.18.0". If you are sure you have a compatible version of @babel/core, it is likely that something in your build process is loading the wrong version. Inspect the stack trace of this error to look for the first entry that doesn't mention "@babel/core" or "babel-core" to see what is calling Babel. (While processing: "/Users/Stef.Jones/src/edge-csrf/node_modules/.pnpm/next@15.0.0_react-dom@18.2.0_react<EMAIL_ADDRESS>
./app/global-error.jsx
Error: Parsing error: [BABEL] /Users/Stef.Jones/src/edge-csrf/examples/next15-approuter-sentry/app/global-error.jsx: Requires Babel "^7.22.0", but was loaded with "7.18.0". If you are sure you have a compatible version of @babel/core, it is likely that something in your build process is loading the wrong version. Inspect the stack trace of this error to look for the first entry that doesn't mention "@babel/core" or "babel-core" to see what is calling Babel. (While processing: "/Users/Stef.Jones/src/edge-csrf/node_modules/.pnpm/next@15.0.0_react-dom@18.2.0_react<EMAIL_ADDRESS>
./app/layout.tsx
1:37  Error: Missing semicolon.  @typescript-eslint/semi
2:41  Error: Missing semicolon.  @typescript-eslint/semi
3:23  Error: Missing semicolon.  @typescript-eslint/semi
5:44  Error: Missing semicolon.  @typescript-eslint/semi
10:2  Error: Missing semicolon.  @typescript-eslint/semi
21:4  Error: Missing semicolon.  @typescript-eslint/semi

./app/page.tsx
1:31  Error: Missing semicolon.  @typescript-eslint/semi
49:26  Error: Strings must use singlequote.  @typescript-eslint/quotes
55:25  Error: Strings must use singlequote.  @typescript-eslint/quotes
66:26  Error: Strings must use singlequote.  @typescript-eslint/quotes
72:25  Error: Strings must use singlequote.  @typescript-eslint/quotes
83:26  Error: Strings must use singlequote.  @typescript-eslint/quotes
89:25  Error: Strings must use singlequote.  @typescript-eslint/quotes
100:26  Error: Strings must use singlequote.  @typescript-eslint/quotes
106:25  Error: Strings must use singlequote.  @typescript-eslint/quotes
112:4  Error: Missing semicolon.  @typescript-eslint/semi

./app/sentry-example-page/page.jsx
Error: Parsing error: [BABEL] /Users/Stef.Jones/src/edge-csrf/examples/next15-approuter-sentry/app/sentry-example-page/page.jsx: Requires Babel "^7.22.0", but was loaded with "7.18.0". If you are sure you have a compatible version of @babel/core, it is likely that something in your build process is loading the wrong version. Inspect the stack trace of this error to look for the first entry that doesn't mention "@babel/core" or "babel-core" to see what is calling Babel. (While processing: "/Users/Stef.Jones/src/edge-csrf/node_modules/.pnpm/next@15.0.0_react-dom@18.2.0_react<EMAIL_ADDRESS>
info  - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules
 ELIFECYCLE  Command failed with exit code 1.

It's possible I have something messed up with how I've installed the examples
View terminal output

The errors might be coming from running the linter in the same pnpm workspace as the package source. It passes for me when I run it outside the workspace so I think it's ok.

Can you merge my suggestions? https://github.com/stefee/edge-csrf/pull/1 Then I'll merge the PR into main.


testing GA

Description

A clear and concise summary of the change and which issue (if any) it fixes. Should also include relevant motivation and context.
Resolved or fixed issue:
Affirmation

[ ] My code follows the CONTRIBUTING.md guidelines

this is a test

dont


feat(external-node): add helm chart

Tested in a previous stage. It has to be fully tested whenever we have the database for the external nodes up and running, and the snapshots created.
closes #2

LGTM
You need to do GPG/SSH signing set-up, amend your commit and force-push it.
Info on how to do that with GPG:
brew install gpg

and then follow these two docs:

https://docs.github.com/en/authentication/managing-commit-signature-verification/generating-a-new-gpg-key
https://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key


Consider protection against concurrent invocation of ReceiveMessage and ReceiveAlarm

There are two stateful methods in the participant API exposed to the host: ReceiveMessage and ReceiveAlarm. If invoked concurrently, unpredictable things might happen.
What, if anything, should we do about this? The simplest answer is probably to declare that these messages are not safe for concurrent use and expect the host, Lotus, to use them safely.

My understanding is that ValidateMessage is the only one safe to be invoked concurrently.
Honestly, adding an atomic flag to these methods may not be a bad idea (so we can return an error if they get invoked concurrently). It should have no noticeable performance impact.

Considering the sensitivity of that code path I would use a simple mutex for safety alone. That seems like the path of least resistance.
At a higher level it would be nice to refactor the protocol as a simple set of actors (as in actor model). But that's a bigger body of work with an unclear ROI.

Considering the sensitivity of that code path I would use a simple mutex for safety alone. That seems like the path of least resistance.

I suggested an atomic plus an error (or a TryLock plus an error) because the user is not supposed to call these methods concurrently and I'd rather catch that early. However, I don't feel strongly about this.

At a higher level it would be nice to refactor the protocol as a simple set of actors (as in actor model).

GPBFT is almost an actor. Unfortunately, ValidateMessage needs to (a) be synchronous and (b) callable concurrently. We could send a message on a channel to some reactor loop, then wait for a reply... but that's adding a bunch of complexity and overhead for little gain.
In general (speaking from experience, pain, and misery), don't attempt to go full-actor-model in Go. It looks like it should be perfect for the language, but it really isn't: channels are not the same as an event bus (blocking with fixed capacity), it's too easy to share memory, you're missing all the sugar that makes coding in actor languages bearable, and mixing actor-like code and non-actor-like code never ends will.
For some context:

Libp2p was originally written with channels all the way down. It was rewritten because performance sucked.
Bitswap has gone through many "actor model" phases and is currently an absolute mess.
Gossipsub is probably the most actor-model-like library we have, and it's still a mess.

an atomic plus an error... I don't feel strongly about this.

Indeed 👍 Nor do I.
Interesting, thank you for pointing out the prior work. I would instinctively think that actor model would be a good fit. "Full-actor-model" is subjective 🤷 What I had in mind was certainly more than one actor to handle things like validation. I also think that it is too early to do major refactoring; not until we get it all "correct" at least once.

Interesting, thank you for pointing out the prior work. I would instinctively think that actor model would be a good fit.

So did we. But performance, the fact that the queues are bounded, and the fact that there's no built-in (efficient) request/response idioms make it difficult.

We all discussed this and resolved to use a tryLock with a panic if concurrent access is detected.


Fix typo in docs yml: "fail" → "false"

Thank you for your contribution! It appears this issue was fixed in another PR so I'm closing this one. Please reach out if you have any questions!


Latest version seems to break mypy

when running mypy on my project, I get this error:
Error importing plugin sqlmypy
When debugging a little bit, the problem seems to be here:
    def get_dynamic_class_hook(self, fullname: str) -> CB[DynamicClassDefContext]:
  File "/usr/lib/python3.5/typing.py", line 546, in __getitem__
    "Cannot subscript an existing Union. Use Union[u, t] instead.")
TypeError: Cannot subscript an existing Union. Use Union[u, t] instead.

You need to update Python to a newer version (I think at least 3.5.2, but better just the latest 3.5 version).

I have this same error on Python 3.7.2:
$ python --version
Python 3.7.2

$ mypy --version
mypy 0.670

$ pip show sqlalchemy-stubs
Name: sqlalchemy-stubs
Version: 0.1
Summary: SQLAlchemy stubs and mypy plugin
Home-page: https://github.com/dropbox/sqlalchemy-stubs
Author: Ivan Levkivskyi
Author-email<EMAIL_ADDRESS>License: MIT License
Location: /Users/aru/.virtualenvs/portal/lib/python3.7/site-packages
Requires: typing-extensions, mypy
Required-by:

In my setup.cfg:
[mypy]
plugins = sqlmypy

You can't have the same error on Python 3.7.2 because that line of code simply doesn't exist in Python 3.7.2, can you post exactly the traceback you see?

I'm sorry, I don't know how I missed the traceback portion of the OP's error.  I seem to be unable to generate a traceback?
$ mypy --tb package_name
setup.cfg:8: error: Error importing plugin 'sqlmypy'

Do you have sqlalchemy-stubs and mypy installed in the same virtualenv?

I do...  however, I discovered that, for whatever reason, my shell was using my global mypy.  Forcing a re-hash fixed things.  Sorry for the confusion!

I fixed this issue by adding sqlalchemy-stubs explicitly in .pre-commit-config.yaml, like this:
-   repo: https://github.com/pre-commit/mirrors-mypy
    rev: 'v0.910'
    hooks:
    - id: mypy
      additional_dependencies:
        - 'pydantic'
        - 'sqlalchemy-stubs'


Console Spam

Hi there,
I am using the most recent Dev build of Quests, and I am constantly being spammed in Console with the following:
http://pastebin.com/cyaN4k0j
I have tried removing the things from console, along with changing them and reloading the plugin multiple times...
How can this be fixed?

From what it looks like, you tried to blacklist certain players from doing a specific quest by typing in their username under "Quester-Blacklist"
The issue here is saying that you typed their Usernames, when the document requires their UUID. (Which is a long string of code that is unique to each player.) My best bet would be to remove the usernames from the quester-blacklist, run the server, and then blacklist them in-game from doing quests by using /questadmin commands. If that is not possible, find a way to get there UUIDs, and then copy paste those into the document. If neither of these work, post back under this thread. (Again I am not an admin, I just try to help.)

@TheOtakuJames Zalakoth's answer is likely the proper fix.

i have the same problem and it did not work.

It worked for me

Please create a new, updated ticket if this is still an issue. Thanks!


Notification bot 'Subscribe' button does not work for streams punctuation in the name

The subscribe button helpfully posted by the notification bot will not allow subscription in these cases. You can subscribe the to streams in the stream management interface.
Strangely, you can unsubscribe from a stream using the notification bot's button, but still not resubscribe.
Observed for the stream names where@ and 100:10:1.

Definitely a bug; I think switching this button to use stream IDs would solve both this and #426 and thus might be a good path forward here.


[Enhancement] Rank window function optimization supports multi partition columns

Signed-off-by: ZiheLiu<EMAIL_ADDRESS>What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Relates to #17553.
Problem Summary(Required) ：

Test
Environment
3 BE (16vCPUs, 64GB RAM)
ssb 100g
Queries
-- Q1 low cardinal (63), HashMapWithSerializedKeyFixedSize
with w1 as (select lo_tax, lo_linenumber, row_number() over(partition by lo_tax, lo_linenumber order by lo_orderkey) as rn from lineorder_flat)
select
    ifnull(sum(murmur_hash3_32(lo_tax)), 0)
    + ifnull(sum(murmur_hash3_32(lo_linenumber)), 0)
    + ifnull(sum(murmur_hash3_32(rn)), 0)
from w1 where rn = 1

-- Q2 low cardinal (225), HashMapWithSerializedKey
with w1 as (select lo_tax, s_nation, row_number() over(partition by lo_tax, s_nation order by lo_orderkey) as rn from lineorder_flat)
select /*+ SET_VAR(cbo_enable_low_cardinality_optimize=false) */
    ifnull(sum(murmur_hash3_32(lo_tax)), 0)
    + ifnull(sum(murmur_hash3_32(s_nation)), 0)
    + ifnull(sum(murmur_hash3_32(rn)), 0)
from w1 where rn = 1

-- Q3 high cardinal (13998451), HashMapWithSerializedKeyFixedSize
with w1 as (select lo_custkey, lo_linenumber, row_number() over(partition by lo_custkey, lo_linenumber order by lo_orderkey) as rn from lineorder_flat)
select
    ifnull(sum(murmur_hash3_32(lo_custkey)), 0)
    + ifnull(sum(murmur_hash3_32(lo_linenumber)), 0)
    + ifnull(sum(murmur_hash3_32(rn)), 0)
from w1 where rn = 1

-- Q4 high cardinal (49984917), HashMapWithSerializedKey
with w1 as (select c_name, s_nation, row_number() over(partition by c_name, s_nation order by lo_orderkey) as rn from lineorder_flat)
select /*+ SET_VAR(cbo_enable_low_cardinality_optimize=false) */
    ifnull(sum(murmur_hash3_32(c_name)), 0)
    + ifnull(sum(murmur_hash3_32(s_nation)), 0)
    + ifnull(sum(murmur_hash3_32(rn)), 0)
from w1 where rn = 1

-- Q5 very high cardinal (600037902), HashMapWithSerializedKeyFixedSize
with w1 as (select lo_orderkey, lo_linenumber, row_number() over(partition by lo_orderkey, lo_linenumber order by lo_orderkey) as rn from lineorder_flat)
select
    ifnull(sum(murmur_hash3_32(lo_orderkey)), 0)
    + ifnull(sum(murmur_hash3_32(lo_linenumber)), 0)
    + ifnull(sum(murmur_hash3_32(rn)), 0)
from w1 where rn = 1

-- Q6 very high  cardinal (150000000), HashMapWithSerializedKey
with w1 as (select lo_orderkey, c_name,  row_number() over(partition by lo_orderkey, c_name order by lo_orderkey) as rn from lineorder_flat)
select /*+ SET_VAR(cbo_enable_low_cardinality_optimize=false) */
    ifnull(sum(murmur_hash3_32(lo_orderkey)), 0)
    + ifnull(sum(murmur_hash3_32(c_name)), 0)
    + ifnull(sum(murmur_hash3_32(rn)), 0)
from w1 where rn = 1

Test Result
As for the low cardinal, this PR can gain higher performance, but doesn't reduce  too much memory usage.

Name
Time (s)
Peak Memory (GB)
Time (s)
Peak Memory (GB)

Before PR

After PR

Q1
16.00
34.59
1.23
29.27

Q2
20.82
42.40
4.47
35.42

Q3
11.24
37.10
11.33
38.09

Q4
OOM
59.44
OOM
58.64

Q5
8.15
33.93
8.13
34.89

Q6
12.08
52.64
12.25
56.87

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

run starrocks_admit_test

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

@Mergify backport branch-2.5


function GetVideo() got "unexpected status code: 404"

go version 1.16.5
github.com/kkdai/youtube/v2 v2.7.0
video https://www.youtube.com/embed/wmqJYHH-hvI

I have the same problem. If I try several times, it works (about 1 out of 5 times).
Go 1.16.4, youtube v2.7.0, video https://www.youtube.com/watch?v=dfkdRBAik0o (actually all the videos I've tried)

Looks like the video_info endpoint this relies on is being shutdown.
Possible the work being done on https://github.com/tombulled/innertube my be a way forward.

Looks like the video_info endpoint this relies on is being shutdown.
Possible the work being done on https://github.com/tombulled/innertube my be a way forward.

That's not a good news...Do you have any info about it ?

I think I have a workaround for this. If you make a request like this:
curl -o mobile.html -A iPad https://m.youtube.com/watch?v=NMYIVsdGfoo

Inside the HTML, you have a node like this:
<script nonce="rnllSB3lBoQNKekJVVmrOA">var ytInitialPlayerResponse = {"respons...
...NOWN"}}}],"timestamp":{"seconds":"1624028141","nanos":546973023}}}};</script>

That has basically all the same data as the old endpoint. I am working on a solution (in Go) as we speak. Please be patient. I have my own package for this here:
https://pkg.go.dev/github.com/89z/mech/youtube
but again, I have not pushed anything yet.

YouTube now uses a different API located at https://www.youtube.com/youtubei/v1/<ep>. The guys from Pytube are also working on a solution: https://github.com/pytube/pytube/issues/1021

Ok, with all the talk, I am not sure about the future of get_video_info, but I seemed to have fixed the issue with my package:
https://github.com/89z/mech/commit/640df95604684bf74633c68fe9c676f69fa17112
For me, the solution was just adding these:
val.Set("c", "TVHTML5")
val.Set("cver", "4.19700101")

With cver, the first number needs to be 4 or more, and the rest is just any date, I used Unix epoch. If anyone want to test my package (or command line tool), help yourself. I pushed a new tag.

Ok, with all the talk, I am not sure about the future of get_video_info, but I seemed to have fixed the issue with my package:

Are you sure? Because the concensus right now is that get_video_info still works sometimes but is on the way out. I also thought I'd fixed it with some tweaks to the URL but turned out I was just getting good responses at the time and later it stoppped working again.

Are you sure? Because the concensus right now is that get_video_info still
works sometimes but is on the way out. I also thought I'd fixed it with
some tweaks to the URL but turned out I was just getting good responses at
the time and later it stoppped working again.

Here is result with<EMAIL_ADDRESS>PS C:\> youtube -i youtube.com/watch?v=NMYIVsdGfoo
GET  https://www.youtube.com/get_video_info?c=TVHTML5&cver=4.19700101&eurl=https%3A%2F%2Fwww.youtube.com&html5=1&video_id=NMYIVsdGfoo
author: Aphex Twin - Topic
title: Goon Gumpas
countries: []

itag 137, height 1080, 501.1 kb/s, 7.0 MB, video/mp4; codecs="avc1.640020"
itag 248, height 1080, 336.6 kb/s, 4.7 MB, video/webm; codecs="vp9"
itag 136, height 720, 236.7 kb/s, 3.3 MB, video/mp4; codecs="avc1.64001f"
itag 247, height 720, 113.9 kb/s, 1.6 MB, video/webm; codecs="vp9"
itag 135, height 480, 107.7 kb/s, 1.5 MB, video/mp4; codecs="avc1.4d401e"
itag 244, height 480, 65.0 kb/s, 919.2 kB, video/webm; codecs="vp9"
itag 134, height 360, 57.1 kb/s, 810.0 kB, video/mp4; codecs="avc1.4d4015"
itag 243, height 360, 40.3 kb/s, 574.1 kB, video/webm; codecs="vp9"
itag 133, height 240, 30.0 kb/s, 435.3 kB, video/mp4; codecs="avc1.4d400c"
itag 242, height 240, 25.7 kb/s, 368.9 kB, video/webm; codecs="vp9"
itag 160, height 144, 16.3 kb/s, 225.1 kB, video/mp4; codecs="avc1.4d400b"
itag 278, height 144, 17.9 kb/s, 260.7 kB, video/webm; codecs="vp9"
itag 140, height 0, 131.2 kb/s, 2.0 MB, audio/mp4; codecs="mp4a.40.2"
itag 249, height 0, 54.8 kb/s, 788.1 kB, audio/webm; codecs="opus"
itag 250, height 0, 72.3 kb/s, 1.1 MB, audio/webm; codecs="opus"
itag 251, height 0, 139.0 kb/s, 2.0 MB, audio/webm; codecs="opus"

EDIT: Oh hang on, I should have read you're link. You don't use the get_video_info. Hah.

Yeah, I do:
https://github.com/89z/mech/blob/640df956/youtube/video.go#L31

EDIT: Oh hang on, I should have read you're link. You don't use the get_video_info. Hah.

Yeah, I do:
https://github.com/89z/mech/blob/640df956/youtube/video.go#L31

Huh. I followed you're link to the commit and the first thing I see in the readme is https://www.youtube.com/youtubei/v1/<ep> which made me think you were using that instead of get_video_info.
Oh well. It'll be nice if that is a fix but I suspect youtube is moving to drop that API entirely, unless there's a bunch of devices that require it and can't be updated?

Huh. I followed you're link to the commit and the first thing I see in the readme is https://www.youtube.com/youtubei/v1/<ep> which made me think you were using that instead of get_video_info.

I am considering adding or replacing get_video_info with the other API. But as I just learned of its existence today, its not done yet.

It'll be nice if that is a fix but I suspect youtube is moving to drop that API entirely, unless there's a bunch of devices that require it and can't be updated?

As you have literally no evidence to back up this claim, I would strongly suggest you stop pushing it. All youre doing at this point is just gossip and pushing FUD.

As you have literally no evidence to back up this claim (and from your profile, no programming experience [1]), I would strongly suggest you stop pushing it. All youre doing at this point is just gossip and spreading FUD, and actively wasting peoples time who are actually working on the problem.
1. https://github.com/drunlade

That's a rather juvinile response, as was deleting the quoted message, as well as linking to my profile as some sort of attack on my ability to have comments and input. You won't see anything on there because it's all on company repositories, which are private. Personally I think sixteen years of experience is enough to have some input.
Having read the threads, comments and issues raised on other projects, the conclusion by many (most?) developers is that the API is being retired and replaced with the youtubei API. They of course could be wrong, but I trust that people making all these libs have some idea what they're talking about.

As an actual contributor on this project [1], and as someone with actual experience in the different YouTube APIs [2][3], I would advise anyone reading this thread to ignore @drunlade, as they have no provable experience with YouTube API, or even computer programming in general.
It seems their only goal is to spread doubt and uncertainty about the current situation.

https://github.com/kkdai/youtube/commits?author=89z
https://pkg.go.dev/github.com/89z/mech/youtube
https://superuser.com/a/773998

I have far better things to get on with than argue with someone who turns a discussion about code or implementation into a personal attack and an "I'm the superior developer" competetion.  Just consider for a moment the community you're part of and how you're actions reflect on it.

@drunlade did you have any constructive, referenced information to bring to the table? Otherwise I think the only reasonable conclusion, is that you are here to distract from anyone actually solving the issue.

Related issues:

https://github.com/ytdl-org/youtube-dl/issues/29333
https://github.com/ytdl-org/youtube-dl/issues/29086
https://github.com/pytube/pytube/issues/1021

If I add c=TVHTML5&cver=7.20201028 to the get_video_info request, I get a 200 response, but metadata like release date and duration is missing in the response.

@corny I tested over 800 combinations yesterday [1], so I dont think its possible anymore to get that data from get_video_info anymore. So it will need to be gotten from an normal /watch request (m.youtube.com) ok too, or maybe the new youtubei request.

https://github.com/89z/mech/blob/47a0d63c/research/2021-06-18/get_video_info/youtube.go

After much research, it seems the best current option for getting the media, is making a POST request as ANDROID to /youtubei/v1/player:
https://github.com/89z/mech/blob/master/youtube/android.go
and for just getting video information, making a POST request as WEB to /youtubei/v1/player:
https://github.com/89z/mech/blob/master/youtube/web.go
in both cases, you get a pure JSON response (or Protobuf if you want), and with the ANDROID option, the signatures are already decrypted, which means no JavaScript mess.

I created a PR, which seems to fix the issue (#197).

#197 is honestly a poor fix, and not worth committing even temporarily in my opinion.

Well, it's been four days, and you still haven't come up with a better solution.

same problem, waiting fix


chore(nuxt): document div wrapper in client-only page

🔗 Linked issue
https://github.com/nuxt/nuxt/pull/30355

📚 Description

Maybe we also can add display: contents to div wrapping the page, so it is transparent to css styles ?


'Add reminder' doesn't work fix

#111 fixed

Seems like you messed up some pushed commits.

Can you rebased against develop?

I did it. It seems you have already fixed this issue in develop.

The problem was in https://github.com/prooph/proophessor-do/commit/ea4ffdefb65942859745eb2d4b763cfbb7d01ba4#diff-5044c9fa2c209be2ffef808d5a49edbdR39
Anyway, at least I added a test :)

Changes Unknown when pulling 104eb15d394255626c3d7a3bd055ddcb1e366570 on akireikin:issue-111 into ** on prooph:develop**.

Thanks :+1:


python3Packages.gpxpy: 1.5.0 → 1.6.2

Description of changes
Changelog
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 277398 run on x86_64-darwin 1

4 packages marked as broken and skipped:

python310Packages.opensfm
python310Packages.opensfm.dist
python311Packages.opensfm
python311Packages.opensfm.dist

6 packages built:

fit-trackee
fit-trackee.dist
python310Packages.gpxpy
python310Packages.gpxpy.dist
python311Packages.gpxpy
python311Packages.gpxpy.dist


Update manifest and add SEO elements

https://web.dev/add-manifest/
Manifest file: client/public/manifest.json

Need to complete #58 first

Need to complete #58 first

Manifest updated already with pr #120, but we still need SEO components

Manifest updated already with pr #120, but we still need SEO components


please include openvino iGPU support for hardware acceleration

as seen on frigate, openvino support highly accelerate ai computing (equivalent to google coral) even on old/small/cheap architectures (> gen6)
combined to faster-whisper or whisper.cpp could higly fluidify the experience of assistant.
iGPu can be easily passed to docker container as done on frigate.

Upstream doesn't support anything but CUDA unfortunately:
https://github.com/OpenNMT/CTranslate2/issues/1072

Dunno if it would bé helpful
https://github.com/ggerganov/whisper.cpp/blob/master/models/convert-whisper-to-openvino.py

Totally Newb in thus domain, Dunno if it would bé helpful :
https://github.com/ggerganov/whisper.cpp/blob/master/models/convert-whisper-to-openvino.py
https://github.com/openvinotoolkit/openvino_notebooks/blob/main/notebooks/227-whisper-subtitles-generation/227-whisper-convert.ipynb

That's whisper.cpp, a different project.

This is more applicable to this project: https://github.com/rhasspy/wyoming-whisper-cpp

I'm too noob to understand the différence between Whisper/Whisper.cpp except it's a C version.
From what i ser it could bé possible to compile whisper.cpp with openVINO support and t'en serve it with Wyoming ?

For those interested in this thread, I made use of a fork of CTranslate2 to build a Wyoming Faster Whisper for ROCm container.
Check it out here if you are interested. I don't have much hardware to test with, so All I have tested is my APU.
This performs about 15x faster than CPU faster-whisper for me, and about 5x faster than the Whisper.cpp implementation that can be found here.


Task to update the versions one by one

Thanks for the PR on http4k - looks like it will be super useful. But now that I'm manually updating (some) dependencies, I'd really like a way in which I could update them in an interactive way without manually copying the strings.
I'd imagine running a gradle task which asks me (one-by-one) if I'd like to upgrade an out-of-date dependency from the old version to the new. Maybe with an option to just "accept all updates". This would then regenerate the source file containing the versions.

I'm glad you like it @daviddenton  thanks for your kind words!
I don't think this task of updating the versions should be left to a software.
I did want to automate what it is the latest version because that part is super boring.
But as an Android developer, I had my share of Android Studio automatically updating my build,
and the negatives of when it doesn't work are vastly superior to the benefits for when it works.
For example it's usually a good idea to read the CHANGELOG.md before updating (and that's why I added a link to the website in the generated code!)
Your thoughts on that?
Maybe it's enough to make it just a bit convenient by having the code like this

Select the same part as me, press delete, and that's it, you have updated the dependency!

@daviddenton the release 0.2.4 now implements what I just described above ^^


How to change deployment branch via config file

Seen the docs entry that show an example using CURL, but Id' like a config that could be setup using a config file, is it possible?

If you look at D:\home\site\deployments\settings.xml in Kudu Console, there is a setting for the branch. e.g.
<?xml version="1.0" encoding="utf-8"?>
<settings>
    <deployment>
        <add key="branch" value="master" />
    </deployment>
</settings>


Could not parse YouTube response

Something broke between 1.3.3 and 1.3.6, at least in CustomSearch(), nearly every results returns 0 results or throws a "Could not parse YouTube response." in 1.3.6. What makes no sense is why some keywords work, but most fail. Forgive the language but I was pulling my hair out and just started throwing words at it, with a bit of trial and error I found two words that either always worked or always failed. On 1.3.6 searching with CustomSearch() with the search param "CAASBAgBEAE", "music" currently returns 48 results but "fuck" returns 0 results, on 1.3.3 with the exact same code "fuck" returns 48 results.
The code is a bit to granular for me to trace it back quickly. but I would guess something from commit 4c731bbd86d8cef2ea1431c2843b2d88ffc176db is to blame as _youtubesearchpython/handlers/requesthandler.py -> _parseSource() is throwing the exception.

Thankyou for letting me know. Let me see what I can do about this.

Thankyou for letting me know. Let me see what I can do about this.

print(CustomSearch("fuck", "CAASBAgBEAE").result())

According to you this script should return zero results or throw an exception.
But, it works fine for me & I'm unable to reproduce it.
May you please provide a sample reproducing code for me to regenerate the issue.

print(CustomSearch("fuck", "CAASBAgBEAE").result())

According to you this script should return zero results or throw an exception.
But, it works fine for me & I'm unable to reproduce it.
May you please provide a sample reproducing code for me to regenerate the issue.

Just ran my test script again and it worked so I need to run a bunch more keywords again, I will update when I find something consistent again.

Just ran my test script again and it worked so I need to run a bunch more keywords again, I will update when I find something consistent again.

Feel free to reopen as you reproduce.

Feel free to reopen as you reproduce.

seeing the same issue, again and again, it's not reproducible for any specific use case, just happens randomly and mostly happens when you call next page results(pagination).

@rajorpratyush, it's impossible to fix anything without reproduction of issue.
Or even give code that fails randomly.
I can only help if one provides the faulty code not just comments.

The issue happened between 1.3.3 and 1.3.6, I still use 1.3.3 without issue.

Just a hint for this - I got the same issue when passing in a non-string into the VideoSearch constructor:
In [3]: videosSearch = VideosSearch({"id": "Send Me on My Way Rusted Root"}, limit=1)
'NoneType' object is not subscriptable
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
File ~/.local/lib/python3.9/site-packages/youtubesearchpython/handlers/requesthandler.py:54, in RequestHandler._parseSource(self)
     53         self.responseSource = self._getValue(json.loads(self.response), fallbackContentPath)
---> 54         self.continuationKey = self._getValue(self.responseSource[-1], continuationKeyPath)
     55 except Exception as e:

TypeError: 'NoneType' object is not subscriptable

During handling of the above exception, another exception occurred:

Exception                                 Traceback (most recent call last)
Input In [3], in <module>
----> 1 videosSearch = VideosSearch({"id": "Send Me on My Way Rusted Root"}, limit=1)

File ~/.local/lib/python3.9/site-packages/youtubesearchpython/search.py:148, in VideosSearch.__init__(self, query, limit, language, region, timeout)
    146 self.searchMode = (True, False, False)
    147 super().__init__(query, limit, language, region, SearchMode.videos, timeout)
--> 148 self.sync_create()
    149 self._getComponents(*self.searchMode)

File ~/.local/lib/python3.9/site-packages/youtubesearchpython/core/search.py:30, in SearchCore.sync_create(self)
     28 def sync_create(self):
     29     self._makeRequest()
---> 30     self._parseSource()

File ~/.local/lib/python3.9/site-packages/youtubesearchpython/handlers/requesthandler.py:57, in RequestHandler._parseSource(self)
     55 except Exception as e:
     56     print(e)
---> 57     raise Exception('ERROR: Could not parse YouTube response.')

Exception: ERROR: Could not parse YouTube response.

vs this worked fine:
In [4]: videosSearch = VideosSearch("Send Me on My Way Rusted Root", limit=1)

In [5]:


Testing Armorcoat_b1_mac

Hello,
i'm testing it on old iMac but i will test on other systems soon:
i try to run the app with double click on iMac® late 2009 OSX® 10.12.5 but i see this message:
“Armorcoat” is damaged and can’t be opened.
If i open Krom from the terminal it starts!
`imacs-iMac:~ imac$ /Users/imac/Downloads/Armorcoat.app/Contents/MacOS/Krom
deviceBufferSize = 4096
mSampleRate = 44100
mFormatFlags = 00000009
mBytesPerPacket = 8
mFramesPerPacket = 1
mChannelsPerFrame = 2
mBytesPerFrame = 8
mBitsPerChannel = 32
`
During the test i see some graphic glitches ( GPU AMD 4670 )

Migrated this repo functionality to the armorpaint. :)


Need clarity on credentialz.proto host certificate rotation

The ServerKeysRequest message has auth_artifacts that holds a field for 'certificate'.  But there are no fields to know the type of certificate. So while writing this new certificate to the file system, how do we establish the file name ? whether it should be /etc/ssh/ssh_host_rsa_key-cert.pub or /etc/ssh/ssh_host_ecdsa-cert.pub?
Is the RPC handler supposed to parse the certificate as in ssh-keygen -L -f  and determine the type and do this?

Are you proposing that we add to the ServerKeysRequest a key-type, like: (perhaps just require this enum actually)
https://github.com/openconfig/gnsi/blob/a43096008ba06570eddbdd64531d775a9b25a4b3/credentialz/credentialz.proto#L628
in order to tell what form key is being sent?
(I don't think openconfig itself cares a ton about 8.3 filenames.. eh? but it may be handy to know: "oh this is a widget-form key" for other reasons?)


Add Dockerfile and docker-compose file.

I've tested this on Debian Stretch and it seems to work fine. It would probably work great with an SMTP server, too. I haven't added a directory mapping to the mongodb data files to keep them persistent by default, but I can do that soon.
Also, I can add whatever documentation you want to the wiki for this.

Ah, I just realized that deploying with docker is not quite obvious, since the appsettings.json file has the mongodb host as localhost by default - the docker compose would have the mongo db database on host mongo. I think it just needs a separate config file and have docker copy it over when docker-compose is run.

Thank you! Docker is a nice addition for this. Will you extend the docker tasks for the config change? Im not very familiar with Docker so this would be great.


fix(createTransaction): use filtered utxos

Filtered utxos were not properly updated and subsequent calls in createTransaction failed due to missing utxos.

:tada: This PR is included in version 4.7.1 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


Make kernel and sampling explainers have consistent nsamples defaults

In writing a wrapper for the shap library so people can specify default solver (e.g. kernel or sampling) I ran into an error which turned out to be an inconsistency in the "nsamples" default value between the two methods. This PR makes nsamples="auto" be the common default.

Great, thanks!


Thread 'tokio-runtime-worker' panicked at 'Storage root must match that calculated.'

Client version: 1.6.2
Role: Non-collating node
ParaId: 2048
Node doesn't crash it affects on networks responsibilities in mostly.

====================

Version: 1.6.2-7937f3d5-x86_64-linux-gnu

   0: sp_panic_handler::set::{{closure}}
   1: std::panicking::rust_panic_with_hook
             at rustc/02072b482a8b5357f7fb5e5637444ae30e423c40/library/std/src/panicking.rs:610:17
   2: std::panicking::begin_panic_handler::{{closure}}
             at rustc/02072b482a8b5357f7fb5e5637444ae30e423c40/library/std/src/panicking.rs:500:13
   3: std::sys_common::backtrace::__rust_end_short_backtrace
             at rustc/02072b482a8b5357f7fb5e5637444ae30e423c40/library/std/src/sys_common/backtrace.rs:139:18
   4: rust_begin_unwind
             at rustc/02072b482a8b5357f7fb5e5637444ae30e423c40/library/std/src/panicking.rs:498:5
   5: core::panicking::panic_fmt
             at rustc/02072b482a8b5357f7fb5e5637444ae30e423c40/library/core/src/panicking.rs:107:14
   6: <main_runtime::Runtime as sp_api::runtime_decl_for_Core::Core<sp_runtime::generic::block::Block<sp_runtime::generic::header::Header<u32,sp_runtime::traits::BlakeTwo256>,sp_runtime::generic::unchecked_extrinsic::UncheckedExtrinsic<sp_runtime::multiaddress::MultiAddress<<<sp_runtime::MultiSignature as sp_runtime::traits::Verify>::Signer as sp_runtime::traits::IdentifyAccount>::AccountId,()>,main_runtime::Call,sp_runtime::MultiSignature,(frame_system::extensions::check_spec_version::CheckSpecVersion<main_runtime::Runtime>,frame_system::extensions::check_tx_version::CheckTxVersion<main_runtime::Runtime>,frame_system::extensions::check_genesis::CheckGenesis<main_runtime::Runtime>,frame_system::extensions::check_mortality::CheckMortality<main_runtime::Runtime>,frame_system::extensions::check_nonce::CheckNonce<main_runtime::Runtime>,frame_system::extensions::check_weight::CheckWeight<main_runtime::Runtime>,pallet_transaction_payment::ChargeTransactionPayment<main_runtime::Runtime>)>>>>::execute_block
   7: sc_executor::native_executor::WasmExecutor::with_instance::{{closure}}
   8: sp_state_machine::execution::StateMachine<B,H,Exec>::execute_aux
   9: <main_runtime::RuntimeApiImpl<__SR_API_BLOCK__,RuntimeApiImplCall> as sp_api::Core<__SR_API_BLOCK__>>::Core_execute_block_runtime_api_impl
  10: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
  11: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
  12: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
  13: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
  14: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
  15: <futures_util::future::future::Map<Fut,F> as core::future::future::Future>::poll
  16: <tracing_futures::Instrumented<T> as core::future::future::Future>::poll
  17: tokio::runtime::task::raw::poll
  18: std::sys_common::backtrace::__rust_begin_short_backtrace
  19: core::ops::function::FnOnce::call_once{{vtable.shim}}
  20: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once
             at rustc/02072b482a8b5357f7fb5e5637444ae30e423c40/library/alloc/src/boxed.rs:1694:9
      <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once
             at rustc/02072b482a8b5357f7fb5e5637444ae30e423c40/library/alloc/src/boxed.rs:1694:9
      std::sys::unix::thread::Thread::new::thread_start
             at rustc/02072b482a8b5357f7fb5e5637444ae30e423c40/library/std/src/sys/unix/thread.rs:106:17
  21: start_thread
  22: clone

Thread 'tokio-runtime-worker' panicked at 'Storage root must match that calculated.', /usr/local/cargo/git/checkouts/substrate-7e08433d4c370a21/d36550a/frame/executive/src/lib.rs:488

This is a bug. Please report it at:

	https://github.com/airalab/robonomics/issues/new

2022-01-20 22:12:30 [Parachain] panicked at 'Storage root must match that calculated.', /cargo-home/git/checkouts/substrate-7e08433d4c370a21/d36550a/frame/executive/src/lib.rs:488:9
2022-01-20 22:12:30 [Parachain] Block prepare storage changes error:
RuntimeApiError(Application(Execution(Other("Wasm execution trapped: wasm trap: unreachable\nwasm backtrace:\n    0: 0x203c - <unknown>!rust_begin_unwind\n    1: 0x1caf - <unknown>!core::panicking::panic_fmt::h6314b5c91abe7349\n    2: 0x74f1b - <unknown>!frame_executive::Executive<System,Block,Context,UnsignedValidator,AllPalletsWithSystem,COnRuntimeUpgrade>::execute_block::hf5feea85a388513e\n    3: 0x16eff0 - <unknown>!Core_execute_block\n"))))
2022-01-20 22:12:30 [Parachain] 💔 Error importing block 0xec0ee7708ecabd76dd989b640ae28e83d9a8fcf40f1cd5280b811f358d380690: Err(Other(ClientImport("Error at calling runtime api: Execution failed: Other(\"Wasm execution trapped: wasm trap: unreachable\\nwasm backtrace:\\n    0: 0x203c - <unknown>!rust_begin_unwind\\n    1: 0x1caf - <unknown>!core::panicking::panic_fmt::h6314b5c91abe7349\\n    2: 0x74f1b - <unknown>!frame_executive::Executive<System,Block,Context,UnsignedValidator,AllPalletsWithSystem,COnRuntimeUpgrade>::execute_block::hf5feea85a388513e\\n    3: 0x16eff0 - <unknown>!Core_execute_block\\n\")")))

Try to run it with --state-cache-size=0

Note that you need use --state-cache-size=0 in the collator's service launch. This parameter is important for the stability of the collator. You can see more info in the related issue on github.
https://wiki.robonomics.network/docs/en/how-to-launch-the-robonomics-collator/

#234


Accurate problem

Thank you for your open source project. I used Readme to train the Mocodad model, and then Eval_mocodad found that on the Ubnormal dataset, the accuracy rate was about 64-65%. It was much different from the best performance in the paper. I trained 4 times in the default parameter, each time it was very different from the best performance. I used visual data and found that the best AUC on the Ubnormal verification set was about 75%, and the initial code PL only saved the TOP2 CKPT. Is there any problem with my experiments? Can you give specific experimental details or the specific parameter details on the UBNORMAL verification set?

Dear @sssserious, thank you for your interest in our project!
While the provided checkpoints yield the results we reported in the paper, we could not recover the right hyperparameters to reproduce the best checkpoint from scratch. The publicly released hyperparameters allow us to match our results more closely, but some more tuning may be required; unfortunately, we don't have much time at the moment to carry out some more experiments.
I apologize for the inconvenience and hope our work can be helpful with your research anyway.
Best regards,
Stefano


UHF-9708: Survey content type

UHF-9708

What was done

Granted ad role Drupal_Helfi_Etusivu_kayttajakyselyt survey_editor role on Drupal

How to install

Make sure your instance is up and running on correct branch.

git checkout UHF-9708

Change platform config to correct branch:

composer require drupal/helfi_platform_config:dev-UHF-9708
make fresh

Run make drush-cr

How to test

[ ] Login to the site and make sure that there is now a new content type Survey.
[ ] Make sure there is also a new role Survey editor that has permissions for the Survey content type.
[ ] Check that code follows our standards.

Continuous documentation

[ ] This feature has been documented/the documentation has been updated
[ ] This change doesn't require updates to the documentation

Translations

[x] Translations have been added to .po -files and included in this PR

Other PRs

https://github.com/City-of-Helsinki/drupal-helfi-platform-config/pull/773
https://github.com/City-of-Helsinki/drupal-helfi-etusivu/pull/642
https://github.com/City-of-Helsinki/drupal-helfi-asuminen/pull/419
https://github.com/City-of-Helsinki/drupal-helfi-tyo-yrittaminen/pull/409
https://github.com/City-of-Helsinki/drupal-helfi-kasvatus-koulutus/pull/650
https://github.com/City-of-Helsinki/drupal-helfi-kuva/pull/365
https://github.com/City-of-Helsinki/drupal-helfi-kymp/pull/887
https://github.com/City-of-Helsinki/drupal-helfi-rekry/pull/496
https://github.com/City-of-Helsinki/drupal-helfi-sote/pull/849
https://github.com/City-of-Helsinki/drupal-helfi-strategia/pull/647

AD Groups were not implemented on KASKO so closing this.


feat(importable): Make this library importable into other projects

This aims to be the beta version of the library. In the near future, there will still be some breaking changes without increasing the major version number.
Tested by creating the documentation project: Demessifier/demessifier-gui-example.
#3

:tada: This PR is included in version 1.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Tolerate multiple messages being read from client during connection

Type of change

Bugfix

Description
Enqueue further messages handled by KafkaProxyFrontendHandler while it is in the CONNECTING or CONNECTED state before it has received the OUTBOUND_ACTIVE signal from the outbound channel. Then write them all to the outbound when it becomes active and null out the queue.
Resolves #513
Additional Context
It is possible for clients to send multiple messages to the broker immediately. In this case, even though we try to disable autoread of the inbound channel we can still read multiple messages from the socket and have to handle multiple messages while we are establishing the connection to upstream.
The Kafka Broker handles this case fine so we should too.
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Review performance test results. Ensure that any degradations to performance numbers are understood and justified.
[ ] Make sure all Sonar-Lint warnings are addressed or are justifiably ignored.
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).


Events manager

This ticket should include models and initial serializers

Hi @neosergio , environment set up, I see there is models for events and talks. The scope of this task will be to generate an api for those? or which is the exact work we should do here. Thx

Yes, you should create endpoints just for events, Event list sorted by -date (GET), Event Detail (GET).

Hi @neosergio pull request of simple listing done, please let me know if something else necesary in procedure. And what else is needed in terms of the requirement.

Thank you @jboneu, I will review and merge your pull request after this friday demo, when we closed 1.3 version.

Merged

BUG: https://github.com/belatrix/BackendAllStars/issues/143

BUG: https://github.com/belatrix/BackendAllStars/issues/142


imporve test case

Coverage increased (+18.05%) to 74.384% when pulling c4e8109ad6a63cbdc1d6391b27176ca9c68cd657 on develop into b120c8673e6b837afb516b85352875cbadf48d80 on master.


Datepicker: dateChange event returns null or undefined in Firefox

I am having issues with the dateChange event in the datepicker for Firefox. We are currently using version 6.4.7, however, a brief test on the demos confirms that this issue is still happening on the latest version.
Here are the screenshots for this issue:
On Chrome

On Firefox

Addendum: Do note that the format that we use is MM.DD.YYYY.
EDIT: Quickly checked and it seems that dot and dash delimiters are broken in Firefox. Slashes are good though.

Closing this issue as it does not follow the issue template. Please file a new issue that follows the template, which gives the team the information needed to investigate


[INFO] Deployment in docker behind a nginx proxy

What we have:
We deployed a graph-node with docker on our server behind a nginx proxy. The graph-node is connected to our private blockchain. The node is working, and we were able to deploy a subgraph.
Our proxy redirects:

https://our-address/graph to port :8000
https://our-address/graph-ws to port :8001
https://our-address/graph-admin to port :8020

Problem 1:

When we try to access our subgraph on https://our-address/graph/subgraphs/name/... the page doesn't load because it can not successfully establish a WebSocket connection. It tries to access https://our-address:8001/graph/subgraphs/name/...
I'm interested if there is an option to change this address to https://our-address/graph-ws/subgraphs/name/...

Problem 2:

When accessing https://our-address/graph/subgraphs/name/... it also fails to get graphiql.css and graphiql.min.js files, because it tries to get them from https://our-address/

Any help would be greatly appreciated. Thank you!

Found out " https://our-address/graph/subgraphs/name/.../graphql" only exposes an example app where you can try out queries on the deployed subgraph.
We successfully deployed our own example app to try out some queries on the subgraph, so closing the issue now.


Add option for generating bindings using marshaling

Use MarshalAs attribute for strings, arrays, etc. Don't use CString in this case in bindgen.

It would be awesome to support the new C# 11 UTF-8 strings!


Hiero: python3 compatibility

also reorganization of host folder to match other hosts
unification of string quotations
fixing thirdparty plugins to be python3 compatible

Task linked: OP-1629 Hiero 13 compatibility


Package configuration file not applied to the reporters

It looks like packageConfigurationProvider (https://github.com/oss-review-toolkit/ort/blob/master/docs/config-file-package-configuration-yml.md) provided by ReporterInput is not being used anywhere except for SpdxDocumentReporter. The reports are not excluding licenses from subfolders of dependencies. Example:
packages.yml:
\- id: "NPM::esprima:4.0.1"
  vcs:
    type: "Git"
    url: "https://github.com/jquery/esprima.git"
    revision: "0ed4b8afdf2abd416f738977672c6232836f410a"
  path_excludes:
  - pattern: "test/**"
    reason: "TEST_OF"
    comment: "This directory contains documentation which is not distributed."

scan-result.yml

\- id: "NPM::esprima:4.0.1"
  results:
  - provenance:
    download_time: "2020-11-19T14:09:41.489156Z"
    vcs_info:
      type: "Git"
      url: "https://github.com/jquery/esprima.git"
      revision: "0ed4b8afdf2abd416f738977672c6232836f410a"
      resolved_revision: "0ed4b8afdf2abd416f738977672c6232836f410a"
      path: ""
    original_vcs_info:
      type: "Git"
      url: "https://github.com/jquery/esprima.git"
      revision: "0ed4b8afdf2abd416f738977672c6232836f410a"
      path: ""
....
\- license: "MIT"
  location:
    path: "test/3rdparty/jquery-1.9.1.js"
    start_line: 9
    end_line: 10

reporter call:
./cli/build/install/ort/bin/ort --debug --stacktrace report -f CycloneDX -O CycloneDx=single.bom=true -O CycloneDx=omit.excluded=true -i ./work/scan-result.yml -o ./work/Downloads --package-configuration-file ./work/packages.yml

I can confirm that there was an issue in the CycloneDxReporter (and also in AmazonOssAttributionBuilderReporter and AntennaAttributionDocumentReporter), but esp. the new AsciidocTemplateReporter should not have this issue.
Can you confirm that https://github.com/oss-review-toolkit/ort/pull/3384 fixes your issue, and that the AsciidocTemplateReporter was not affected?

It looks like packageConfigurationProvider (https://github.com/oss-review-toolkit/ort/blob/master/docs/config-file-package-configuration-yml.md) provided by ReporterInput is not being used anywhere except for SpdxDocumentReporter.

The packageConfigurationProvider is not used directly by the reporters, instead it is used by the LicenseInfoResolver class which is the interface reporters use to get license and copyright information. The SpdxDocumentReporter you mention was just recently changed to not use the packageConfigurationProvider directly in 7889caf.
I can confirm that package configurations definitely work for the Static HTML, Web App and Notice Template reporters, #3384 should fix the issue for the remaining reporters.

@sschuberth @mnonnenmacher I can confirm that CycloneDx and AntennaAttributionDocumentReporter works as it should now. I could not test AmazonOssAttributionBuilder i havent got this configured at all so it will take some time for me to introduce. I could also confirm that StaticHTML and WebApp also works as it should (it marks package licenses as excluded within the report).
But the new PDF AsciidocTemplateReporter reporter does not work, at least on this branch. This are the outputs of
AsciidocTemplateReporter
Package: esprima:4.0.1
The following copyrights and licenses were found in the source code of this package:
License:
• BSD-2-Clause
• Copyrights:
◦ Copyright JS Foundation and other contributors, https://js.foundation
License:
• BSD-3-Clause
• Copyrights:
License:
• GPL-2.0-only
• Copyrights:
License:
• LGPL-2.0-or-later
• Copyrights:
License:
• MIT
• Copyrights:
StaticHTML
NPM::esprima:4.0.1 | dependencies                 devDependencies Excluded: DEV_DEPENDENCY_OF - Packages for development only. | Declared Licenses:                                                   BSD-2-Clause                                               Detected Licenses:                                                   BSD-2-Clause (exemplary link to the first of 7 locations)                   BSD-3-Clause (link to the location)                   GPL-2.0-only (Excluded: TEST_OF - This directory contains documentation which is not distributed.) (exemplary link to the first of 2 locations)                   LGPL-2.0-or-later (Excluded: TEST_OF - This directory contains documentation which is not distributed.) (exemplary link to the first of 2 locations)                   MIT (Excluded: TEST_OF - This directory contains documentation which is not distributed.) (exemplary link to the first of 42 locations)
CycloneDx

esprima
4.0.1
ECMAScript parsing infrastructure for multipurpose analysis
required

13b04cdb3e6c5d19df91ab6987a8695619b0aa71

BSD-2-Clause
declared license

BSD-2-Clause
<![CDATA[Redistribution and use in source and binary forms, with or without modification,
 <origin xmlns="ort">detected license

BSD-3-Clause
<![CDATA[Redistribution and use in source and binary forms, with or without modification,
 <origin xmlns="ort">detected license

pkg:npm/esprima@4.0.1?classifier=sources
transitive

without license text

I could not test NoticeTemplate too as i dont have archive folder populated on the system where i performed tests.

Note, however, that the new AsciidocTemplateReporter actaully also makes use of archived license files.
@mnonnenmacher would you have some time today helping me to find out what's going on in the Asciidoc template as I'm not yet very familiar with Freemarker?


Need better 422 errors for PG::ProgramLimitExceeded

Why?
Some Farmwares are using the points.meta field beyond their size limit. This leads to a PG::ProgramLimitExceeded error at runtime, which goes uncaught.
What Needs to Change
The API controller should rescue_from(PG::ProgramLimitExceeded) with a descriptive error message.

Fixed in #1341


Revert multiple assembly functionality

This reverts the functionality to add multiple assemblies. (Most of #14, although it keep a couple of unrelated, minor changes.)
Rob, this update will sort out nunit/dotnet-test-nunit#86 once released.

OSX CI is broken, in what I believe is an unrelated problem. Tried a couple of quick fixes to no avail - we're running on a deprecated image right now, but that doesn't seem to be the only problem unfortunately!

Wow, totally forgot about this. I was just checking previous PR's so I could back this stuff out and found this. Thanks for saving me the work 😄


Markers: the first session in trackers sometimes contains only one event action: action_session_start which produces noisy marker statistics.

Problem:
After fixing the MarkerTrackerLoader to load full trackers including all sessions, I noticed that the first session usually only contains a single event action: action_session_start, followed by session_started: null which we use to create new sessions.
This produces noisy statistics. For example, I created three dialogues using rasa shell. The statistics show 6 sessions (which also messes up the percentages), and the per session statistics contain events for these noisy sessions with lots of nans.
Example:
trackerstore.csv
stats-per-session.csv
stats-overall.csv
extracted.csv
Solution:
When splitting sessions, consider both action: action_session_start and session_started: null as part of the same session.
Otherwise, discard sessions containing only a single event equal to action: action_session_start.

Example:
trackerstore.csv
stats-per-session.csv
stats-overall.csv
extracted.csv

@usc-m @ka-bu
I can look into the this and submit a PR/fix. I can also address other small Marker issues at the same time (renaming a column and chaning CLI). WDYT?

Just to avoid confusion: The “nan”s in the per session results are not noisy per se. If there are no events, then “nan” is only reasonable default (same as used in cases where events exist but no relevant event for the respective marker exist). -- The requirement that had been extracted from the initial implementation was to output "summary statistics" for every session, even if no relevant event was extracted (this case will still exist and will still produce some "nans").
The statistic that suffering from the noise caused by empty sessions is the percentage of sessions where a marker applies at least once, since the empty sessions count towards the total number of sessions.


Add missing volume mounts

Add volume mounts (empty directory for now) according to the generated server configuration. This makes the operator independent of whether the directories actually exist inside the container images for FDO servers.
This should solve the server-side part of issue #118 when using quay.io/fido-fdo images.

FYI @morvencao


vim template errors

Upon loading the colorscheme it throws an error about missing arguments related to the Mail highlighting functions.

Here https://github.com/base16-builder/base16-builder/pull/91

Closed by #91


buid openH264 failed in win10 (make ARCH=x86_64 OS=msvc )

hi， I execute the comand make ARCH=x86_64 OS=msvc  to build in win10，but error occurs
rc -fo openh264.res openh264.rc
make: rc: No such file or directory
make: *** [build/msvc-common.mk:54: openh264.res] Error 127
I already set as following, but  error is still  there...
export PATH="$PATH:/D/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.27.29110/bin/Hostx64/x64"
export INCLUDE="D:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.27.29110\include;D:\Windows Kits\10\Include\10.0.19041.0\um;D:\Windows Kits\10\Include\10.0.19041.0\shared;D:\Windows Kits\10\Include\10.0.19041.0\ucrt"
export LIB="D:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.27.29110\lib\x64;D:\Windows Kits\10\Lib\10.0.19041.0\um\x64;D:\Windows Kits\10\Lib\10.0.19041.0\ucrt\x64"
I guess the problem should be here (msvc-common.mk),  but I have no idea how to fix it
STATIC_LDFLAGS=
CODEC_UNITTEST_CFLAGS=-D_CRT_SECURE_NO_WARNINGS
%.res: %.rc
$(QUIET_RC)rc -fo $@ $<

Works for me.
Are you doing that under visual studio command prompt?
https://docs.microsoft.com/en-us/visualstudio/ide/reference/command-prompt-powershell?view=vs-2019

check environment variables,  particularly Windows Kits (rc.exe)


[release-1.19] Update coredns to 1.8.3

Update coredns on branch release-1.19 to v1.8.3

https://github.com/rancherlabs/image-scanning/issues/248

Assigning to myself since @rmweir can't merge

Validated on v1.19.12-rc1+k3s2
$ k3s -v
k3s version v1.19.12-rc1+k3s2 (0064a396)
$ kubectl describe pod -n kube-system coredns-5d69dc75db-z229s  |grep -i image
    Image:         rancher/coredns-coredns:1.8.3


Remove dockerfile-common.sh from generating tarball

dockerfile-common.sh is removed by #16101. Remove it from generate tarball script.

Failures:
Error: 2.028 [ERROR] alluxio.client.cli.fsadmin.command.QuorumCommandIntegrationTest.elect
Error: 2.028 [ERROR]   Run 1: QuorumCommandIntegrationTest.elect:216 expected:<... ddf3fc6ff5bb:11465
[Successfully elected ddf3fc6ff5bb:11465 as the new leader
Resetting priorities of masters after successful] transfer of leaders...> but was:<... ddf3fc6ff5bb:11465
[Failed to elect ddf3fc6ff5bb:11465 as the new leader: client-11BBA6AD741A is already CLOSED
Resetting priorities of masters after failed] transfer of leaders...>
Error: 2.029 [ERROR]   Run 2: QuorumCommandIntegrationTest.elect:216 expected:<... ddf3fc6ff5bb:11471
[Successfully elected ddf3fc6ff5bb:11471 as the new leader
Resetting priorities of masters after successful] transfer of leaders...> but was:<... ddf3fc6ff5bb:11471
[Failed to elect ddf3fc6ff5bb:11471 as the new leader: client-98869FD4A6F1 is already CLOSED
Resetting priorities of masters after failed] transfer of leaders...>

Error: 0.880 [ERROR] Failures:
Error: 0.880 [ERROR] alluxio.client.cli.job.DistributedCommandsStatsTest.testAsyncPersistCancelStats
Error: 0.881 [ERROR]   Run 1: DistributedCommandsStatsTest.testAsyncPersistCancelStats:234 expected:<Status: [CANCE]LED> but was:<Status: [FAI]LED>
Error: 0.882 [ERROR]   Run 2: DistributedCommandsStatsTest.testAsyncPersistCancelStats:234 expected:<Status: [CANCE]LED> but was:<Status: [FAI]LED>

alluxio-bot, merge this please


feature: allow for dynamic default values

Implements #500.

can this also fix https://github.com/Incendo/cloud/issues/455 ?

can this also fix #455 ?

I think this would get fixed automatically as of #498 rather than this PR, as it'd append to the input, spaces and all. With this PR you now have the option of supplying a location object as well if you're using builders. Either way, it should be resolved in 2.0.


Document supported Data types

What data types (ie. string, date, int, float, image, objectId, etc) are supported by the Data Service?

@pragmaticivan Do you know the answer to this?

@jonnilundy so far the ones I know it supports are: Boolean, Double, Float, Integer, Long, NestedDocument, String

@pragmaticivan K, I'll just work off this list. Thanks!
Is this list easily derived from the source code anywhere so we can verify in the future?

I will include this in my data doc revamp (#362)

Closing since #362 was merged.


Loading catalog failes under https

The page at 'https://workspace.com/4711' was loaded over HTTPS, but requested an insecure resource 'http://schemastore.org/api/json/catalog.json'. This request has been blocked; the content must be served over HTTPS.

https://schemastore.org/api/json/catalog.json has an invalid certificate. maybe it will still work.

https://schemastore.azurewebsites.net/api/json/catalog.json is the "real" location we could use. see https://github.com/SchemaStore/schemastore/issues/12#issuecomment-190398346


SARIF explorer does not update when multiple issues on the same line

I have a SARIF file with multiple findings on a single line at the same column. When I double click the first time on an issue on line x, column, then the SARIF explorer updates. However, when I double click on another issue on the same line and column, then the explorer does not update.

VSCode Version: 1.21.1
OS Version: MacOS 10.14

Steps to Reproduce:

Have a SARIF file with several issues with the same line and column number

I have a video with the issue demonstrated, but it won't let me attach. Happy to share video and SARIF file via another method.
SARIF file was exported from CodeSonar.

Does this issue occur when all extensions are disabled?: Irrelevant

Sorry, this should have been submitted to the SARIF viewer, not the general VSCode repository. I'll close this and reopen in the appropriate location.


Does it work for you?

I am interested in hearing from folks using this integration and how good or bad it's working. Post here please.

Just hooked this up tonight on my RT-340. Looking good so far.

Got an email yesterday from Dan who says it's working with his RT-700.

Didn't see this 'issue' before I sent my email or I would have posted here. It's working good for me so far.  One thing I noticed was when I turned off the grill, the fan didn't run to clear the firepot like normal. This is probably because I didn't let it get to temp and run it for a while. I'll use it later in the week for a real cook and see how it behaves.

As you can imagine, I turned mine on and off many times during development. I saw the same thing with the fan only continuing to run after it had actually been on long enough to warm up.

Seems to work fine on mine. I'd really like to figure out how to detect when the alarm on temp probe a/b is hit so I can broadcast to google home. Thanks for all you have done so far!

Seems to work fine on mine. I'd really like to figure out how to detect when the alarm on temp probe a/b is hit so I can broadcast to google home. Thanks for all you have done so far!

@mclever an automation using a template trigger something like below should fire when the actual temp is within 5 degrees of the target. Probably need to wrap that in a test to ensure the unit is powered on; i.e. not is_state('sensor.smoker_actual_temperature', 'unavailable') or something like that.
(states('sensor.smoker_actual_temperature')|float) > (states('input_number.smoker_probe_a_target')|float) - 5

@mclever an automation using a template trigger something like below should fire when the actual temp is within 5 degrees of the target. Probably need to wrap that in a test to ensure the unit is powered on; i.e. not is_state('sensor.smoker_actual_temperature', 'unavailable') or something like that.
(states('sensor.smoker_actual_temperature')|float) > (states('input_number.smoker_probe_a_target')|float) - 5

I am having problems getting it connected to my RT-700. I tried with an IP I got from the logs on my phone and with an IP I got from my router. Also, used the deviceID and localKey I got from the logs on my phone. In the UI the status for the entities all show unavailable. Do I have to be connected to the network in the same way the device is, for example 2ghz vs 5ghz vs network cable? Are there ways to troubleshoot the connection?

If you can ping the IP of the recteq from the HA box then I would assume the issue is not the network. You may want to fiddle with the tuyapower command line tool to see if you can communicate with it.

If you can ping the IP of the recteq from the HA box then I would assume the issue is not the network. You may want to fiddle with the tuyapower command line tool to see if you can communicate with it.

I tried the tuyapower but couldn't find any devices when I was wired or on wifi. I also tested pinging the device from inside the HA container and I got a response.

You could enable more detailed logging.
# /root/config/configuration.yaml
logger:
  default: info
  logs:
    custom_components.recteq: debug
    pytuya: debug

Works brilliantly with my RT-590, thanks! :)