[BUG] Stretched / very low resolution map in some files

Which Glance version and IDEA version?

Latest stable IDEA & latest rustrover. codeglance pro 1.8.0 and 1.8.1 at least.

Could you show Glance config picture and minimap picture?

Bug:

Settings:

What steps will reproduce the issue?

This bug commonly seems to appear in consistently in certain files, usually files with more lines. It happens across multiple machines and jetbrains IDEs.
When the bug is occurring, the codemap may render correctly for a moment when the file is first opened, or when codeglance is toggled. When the editor is next focused it will switch back to the stretched, broken appearance. Sometimes while typing the minimap will flicker between several different "resolutions", smearing the minimap's pixels across smaller or larger heights.

Please provide the complete settings page and the file type where the problem occurs. It would be better to provide the corresponding text.

Sorry, the settings page was indeed cut off on the top line. Setting is 3 pixels per line, editor size proportional, alignment right, and render style accurate. When render style and pixels per line are changed the bug still occurs. "Experimental: Use FastMinimap For Main Editor" does not prevent the bug in either setting. Disabling markers render, markup highlight, filter markup highlight, syntax highlight, and vcs highlight does not prevent the bug.

File types vary. I have had this happen for source files in Rust, C++, and golang. The files it happens on are typically more than 2,000 lines long, sometimes 15,000+. One example of a file that has the problem when I view it is this one; on the laptop that has the problem with this file, the minimap works perfectly until the editor has finished coloring the syntax on startup. As soon as all symbols are colored, the minimap becomes broken and stays that way.

Thank you for the information. I'll check it later.

https://github.com/Nasller/CodeGlancePro/assets/26132153/2dc45bd0-157b-4c72-8a47-8ee9bbcbd8e5
hello, i have tried to reproduce the problem, but it did not occur. What should I do to reproduce the problem

If you can develop plugin, you can try to debug by yourself to find the problem, about develop plugin you can contact me through discord.

I've reached out there. I've also started looking at the source code a little bit, but I'm not familiar with JWT and am not confident in finding where the images are buffered and then drawn.
I've determined that the minimap, when it is corrupted, is showing a very stretched out version of the top few pixels of the correct image of the colored text, stretched out to many times its correct height. Markup, selection, and character position are then drawn in what would have been the correct locations on top of that background. The bug only happens in "editor size: proportional" mode, not in "fit".

Here you can see, I've inserted a distinctive looking brightly colored line of text on line 12; we just see the very bottom of it, very stretched out, when we scroll to the very bottom of the file.

Here's a recording of its behavior, with all extra markup and highlighting disabled:
Screencast from 02-25-2024 04:26:11 PM.webm

I can make this happen even on my bigger desktop, merely by copying and pasting the contents of a file to make it longer:
Screencast from 2024-02-25 16-53-53.webm

i have contact you by discord

well. doesn't quite fix it. but maybe it will. someday soon...


What was the dataset used for testing in the paper?

Hi,
In the paper, you mention that the dataset used for testing is newstest2014: https://arxiv.org/abs/1706.03762
While in the code, I can only see references to newstest2013 for both En2Fr and En2De:
https://github.com/tensorflow/tensor2tensor/blob/45a787e46b32bdb18b70f835cba0b3270267e19b/tensor2tensor/data_generators/wmt.py#L208
https://github.com/tensorflow/tensor2tensor/blob/45a787e46b32bdb18b70f835cba0b3270267e19b/tensor2tensor/data_generators/wmt.py#L238
Is the code out of date?

Hi. No, the code is fine: we only include the development (evaluation) set in our prepared data, never the training set. We only run once on the training set, after training the best model. And we only run decoding, so we only need the test set in the raw form (detokenized).

I mean: never the test set, sorry.


Add repo commands workflow

I can use https://github.com/PrismarineJS/prismarine-meta to PR that to all repos if you want

https://github.com/PrismarineJS/prismarine-template/actions/runs/5501992704 failed ?

https://github.com/PrismarineJS/prismarine-template/actions/runs/5501992704 failed ?

fixed in #14, wrong secret name was used

I can use https://github.com/PrismarineJS/prismarine-meta to PR that to all repos if you want

yeah, that can be done


Join the team readme file

does it need any modifications?

Thank you for that precious work mate.


Use WindowChrome Class with MicaWPF

Hello,
I'm new in using your project in my WPF project. Is it possible to use WindowChrome with MicaWPF?
This is how I want my app to look like and it works like a charm...

I set my MainWindow.xaml as
<controls:MicaWindow
        ----
        xmlns:controls="clr-namespace:MicaWPF.Controls;assembly=MicaWPF"
        TitleBarHeight="7"
        TitleBarType="Win32"
        ---- />

But when I enable the Windows Setting "Show accent colour on title bars and window borders", my program looks like this, which looks inconsistent...

On Windows 10, absolutely nothing happens (I understand that the Mica doesn't work on Windows 10, that is fine)

I also want this to run on Windows 10 systems too...

In order to circumvent that want to create my own TitleBar. I read online on how to create a Custom Title Bar using the WindowChrome class. I did exactly what it told me to do but that didn't work on my end.
<WindowChrome.WindowChrome>
      <WindowChrome CaptionHeight="34" />
</WindowChrome.WindowChrome>

So is there a way where I can achieve it? Am I missing something which was not mentioned on the documentation?
I honestly like your version, compared to lepoco's WPF UI, because your version more realistic to WinUI 3.
Additional information

I also use Kinnara's ModernWPF together with MicaWPF
My app's target platform is x86

Thank you.

The issue is the  TitleBarType="Win32" I would recommand the  TitleBarType="WinUI" the Win32 is the default titlebar as I need to play alot with the WindowChrome I can't allow users to change it as it will break some other things but the WinUI ones has a field to allow you to add things in the titlebar:
<controls:MicaWindow
    x:Class="MicaWPF.Test.MainWindow"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:local="clr-namespace:MicaWPF.Test"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
    xmlns:controls="clr-namespace:MicaWPF.Lite.Controls;assembly=MicaWPF.Lite"
    x:Name="mainWindow"
    Title="MainWindow"
    TitleBarType="WinUI"
    mc:Ignorable="d">
    <controls:MicaWindow.TitleBarContent>
        <Button>Test</Button>
    </controls:MicaWindow.TitleBarContent>
</controls:MicaWindow>

Actually after experimentation I added this property to MicaWindow:
CustomWindowChrome
So you can now add a Custom WindowChrome will get released in version 6.1.0

Pushing version 6.1.0 if you ever have issue or questions don't hesitate to reopen the issue.


Async Behaviour varies between nsq and Nats

nsq

if i kill the service, send a few messages from the client, and then restart the service, the client gets the messages back that were stored inside nsqd

nats

if i do the same, nats does not. The messages that were sent by the client are lost.

BTW since the API is meant to be agnostic to the underlying MQ, then can we use a string based Service factory i wonder :) I know its not proper golang, but well its a neat trick and will make testing / benching easier one might assume.

Nats is fire and forget with no persistence. That's by design.
If you send messages and no one is there to receive the messages the messages are lost.
NSQ has a default mem-queue-size of 10.000 messages.
I think that is the reason for your observed behavior.
NSQ-Doc:
-mem-queue-size int
    number of messages to keep in memory (per topic/channel) (default 10000)

ok makes sense. thanks

NATS provides a clustered persistence option these days. I think its out of beta too.
Might be worth trying out. Apparently the API has no changes at all, so if true its more just a matter of supplying he ability to boot it.

I've created a pull request to support nats streaming: #32

woooo :)

@joeblew99 are you happy?

well i tried it and it worked well for me. SO yes.
Will close this..


Only lowercase boolean values are accepted when importing CSV

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.28.1
Regression From
1.27.0
Architecture
x64
Storage Explorer Build Number
20230309
Platform
Windows
OS Version
Windows 10
Bug Description
TRUE/FALSE in boolean column cannot be imported from CSV
Steps to Reproduce

Export a table with a Boolean column (storage explorer shows lowercase 'true'/'false'
Open in excel (the boolean column shows uppercase 'TRUE'/'FALSE'
Save the file so that the uppercase booleans are written to the disk
Import the csv

Actual Experience
Import fails
Expected Experience
Import should succeed
Additional Context
No response

@craxal can you figure out if this is indeed a regression? If so let's see how much risk will come from adding it to 1.29.

@francotiveron I am not able to reproduce this in 1.28.1 or in our dev builds. The import succeeds as expected. Can you share a small file or data sample that reproduces the error? Can you also share the error message you get along with any log files?

Market1.csv
Unable to import batch beginning at entity with partition key 'Asset' and row key 'AP' and ending at entity with partition key 'Asset' and row key 'AP'.
Error details:
{
"name": "RestError",
"message": "0:An error occurred while processing this request.\nRequestId:229d755a-eaae-41a2-a43f-5a0351fb5b0c\nTime:2023-04-24T22:56:32.679Z",
"stack": "RestError: 0:An error occurred while processing this request.\nRequestId:229d755a-eaae-41a2-a43f-5a0351fb5b0c\nTime:2023-04-24T22:56:32.679Z\n    at handleBodyError (C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\node_modules\se-table-extension\dist\src\Jobs\TableJobsHandler.js:2:273578)\n    at C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\node_modules\se-table-extension\dist\src\Jobs\TableJobsHandler.js:2:272755\n    at Array.map ()\n    at parseTransactionResponse (C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\node_modules\se-table-extension\dist\src\Jobs\TableJobsHandler.js:2:272423)\n    at C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\node_modules\se-table-extension\dist\src\Jobs\TableJobsHandler.js:2:273069\n    at process.processTicksAndRejections (node:internal/process/task_queues:96:5)\n    at async Object.withSpan (C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\node_modules\se-table-extension\dist\src\Jobs\TableJobsHandler.js:2:186387)\n    at async #t (C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\node_modules\se-table-extension\dist\src\Jobs\TableJobsHandler.js:2:3332)\n    at async TableClient.runOperation (C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\node_modules\se-table-extension\dist\src\Jobs\TableJobsHandler.js:2:352855)\n    at async ImportBatchWithTypesState.importEntities (C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\node_modules\se-table-extension\dist\src\Jobs\TableJobsHandler.js:2:31674)",
"code": "InvalidInput",
"statusCode": 400,
"request": {
"url": "http://<IP_ADDRESS>:10002/devstoreaccount1/$batch",
"body": "--batch_cbd123f5-b4ba-4c59-a6fe-06daa43c97a8\r\ncontent-type: multipart/mixed; boundary=changeset_9d22c39b-00ba-4f95-83ae-26627d7b8c64\r\n\r\n\r\n--changeset_9d22c39b-00ba-4f95-83ae-26627d7b8c64\r\ncontent-type: application/http\r\ncontent-transfer-encoding: binary\r\n\r\nPATCH http://<IP_ADDRESS>:10002/devstoreaccount1/Market(PartitionKey='Asset',RowKey='AP') HTTP/1.1\r\nContent-Type: application/json\r\nDataServiceVersion: 3.0\r\nAccept: application/json\r\n\r\n\r\n{"PartitionKey":"Asset","RowKey":"AP","Active":"FALSE","Active@odata.type":"Edm.Boolean","SessionStart":"18:00,America/New_York","SessionStart@odata.type":"Edm.String","Reference":"","Reference@odata.type":"Edm.String"}\r\n--changeset_9d22c39b-00ba-4f95-83ae-26627d7b8c64--\r\n--batch_cbd123f5-b4ba-4c59-a6fe-06daa43c97a8--\r\n",
"headers": {
"accept": "application/json",
"x-ms-version": "2019-02-02",
"dataserviceversion": "3.0;",
"maxdataserviceversion": "3.0;NetFx",
"content-type": "multipart/mixed; boundary=batch_cbd123f5-b4ba-4c59-a6fe-06daa43c97a8",
"accept-charset": "UTF-8",
"connection": "Keep-Alive",
"accept-encoding": "gzip,deflate",
"user-agent": "Microsoft Azure Storage Explorer/1.28.1 (win32) azsdk-js-data-tables/13.1.2 core-rest-pipeline/1.9.0 Node/v16.17.1 OS/(ia32-Windows_NT-10.0.19044)",
"x-ms-client-request-id": "a6b8299f-1d68-4fc9-88d5-5148a60524fb",
"x-ms-date": "Mon, 24 Apr 2023 22:56:32 GMT",
"content-length": "762",
"authorization": "Signed SharedKeyLite Redacted="
},
"method": "POST",
"timeout": 0,
"disableKeepAlive": false,
"withCredentials": false,
"tracingOptions": {
"tracingContext": {
"_contextMap": {}
}
},
"requestId": "a6b8299f-1d68-4fc9-88d5-5148a60524fb",
"allowInsecureConnection": true,
"enableBrowserStreams": false
},
"response": {
"status": 202,
"headers": {
"server": "Azurite-Table/3.23.0",
"content-type": "multipart/mixed; boundary=batchresponse_cbd123f5-b4ba-4c59-a6fe-06daa43c97a8",
"x-ms-request-id": "229d755a-eaae-41a2-a43f-5a0351fb5b0c",
"x-ms-version": "2022-11-02",
"date": "Mon, 24 Apr 2023 22:56:32 GMT",
"connection": "keep-alive",
"keep-alive": "timeout=5",
"transfer-encoding": "chunked"
},
"request": {
"url": "http://<IP_ADDRESS>:10002/devstoreaccount1/$batch",
"body": "--batch_cbd123f5-b4ba-4c59-a6fe-06daa43c97a8\r\ncontent-type: multipart/mixed; boundary=changeset_9d22c39b-00ba-4f95-83ae-26627d7b8c64\r\n\r\n\r\n--changeset_9d22c39b-00ba-4f95-83ae-26627d7b8c64\r\ncontent-type: application/http\r\ncontent-transfer-encoding: binary\r\n\r\nPATCH http://<IP_ADDRESS>:10002/devstoreaccount1/Market(PartitionKey='Asset',RowKey='AP') HTTP/1.1\r\nContent-Type: application/json\r\nDataServiceVersion: 3.0\r\nAccept: application/json\r\n\r\n\r\n{"PartitionKey":"Asset","RowKey":"AP","Active":"FALSE","Active@odata.type":"Edm.Boolean","SessionStart":"18:00,America/New_York","SessionStart@odata.type":"Edm.String","Reference":"","Reference@odata.type":"Edm.String"}\r\n--changeset_9d22c39b-00ba-4f95-83ae-26627d7b8c64--\r\n--batch_cbd123f5-b4ba-4c59-a6fe-06daa43c97a8--\r\n",
"headers": {
"accept": "application/json",
"x-ms-version": "2019-02-02",
"dataserviceversion": "3.0;",
"maxdataserviceversion": "3.0;NetFx",
"content-type": "multipart/mixed; boundary=batch_cbd123f5-b4ba-4c59-a6fe-06daa43c97a8",
"accept-charset": "UTF-8",
"connection": "Keep-Alive",
"accept-encoding": "gzip,deflate",
"user-agent": "Microsoft Azure Storage Explorer/1.28.1 (win32) azsdk-js-data-tables/13.1.2 core-rest-pipeline/1.9.0 Node/v16.17.1 OS/(ia32-Windows_NT-10.0.19044)",
"x-ms-client-request-id": "a6b8299f-1d68-4fc9-88d5-5148a60524fb",
"x-ms-date": "Mon, 24 Apr 2023 22:56:32 GMT",
"content-length": "762",
"authorization": "SharedKeyLite devstoreaccount1:fr6TA0aM2Nvkh9AecVOSEyKs0i7g4K2+2fEyPYx1GcI="
},
"method": "POST",
"timeout": 0,
"disableKeepAlive": false,
"withCredentials": false,
"tracingOptions": {
"tracingContext": {
"_contextMap": {}
}
},
"requestId": "a6b8299f-1d68-4fc9-88d5-5148a60524fb",
"allowInsecureConnection": true,
"enableBrowserStreams": false
},
"bodyAsText": "--batchresponse_cbd123f5-b4ba-4c59-a6fe-06daa43c97a8\r\nContent-Type: multipart/mixed; boundary=changesetresponse_9d22c39b-00ba-4f95-83ae-26627d7b8c64\r\n\r\n--changesetresponse_9d22c39b-00ba-4f95-83ae-26627d7b8c64\r\nContent-Type: application/http\r\nContent-Transfer-Encoding: binary\r\n\r\nHTTP/1.1 400 Bad Request\r\nContent-ID: 1\r\nDataServiceVersion: 3.0;\r\nContent-Type: application/json;odata=minimalmetadata;charset=utf-8\r\n\r\n{"odata.error":{"code":"InvalidInput","message":{"lang":"en-US","value":"0:An error occurred while processing this request.\nRequestId:229d755a-eaae-41a2-a43f-5a0351fb5b0c\nTime:2023-04-24T22:56:32.679Z"}}}\r\n--changesetresponse_9d22c39b-00ba-4f95-83ae-26627d7b8c64--\r\n--batchresponse_cbd123f5-b4ba-4c59-a6fe-06daa43c97a8--\r\n"
}
}

@francotiveron Thanks for sharing. Still not able to reproduce on my end. Since the error message isn't very helpful, let me see if I can get in touch with someone on the Azure end and demystify some things.

@craxal
Don't know if is relevant... backend is azurite. With the old storage emulator this wasn't a problem

Ah, that is relevant. That would therefore, be a bug with Azurite.

I have created an issue for you: https://github.com/Azure/Azurite/issues/1947.


Running slip pdf generation

Running slips from competition data

Need special markers to improve OCR

https://jsfiddle.net/dFrHS/1/
Could be useful for manual ore-OCR warping


Error after install

I got this:
Error detected while processing function SpaceVim#commands#install_plugin[4]..SpaceVim#plugins#manager#install[36]..66_install[19]..12[43].
.67_systemlist:
line    3:
E706: Variable type mismatch for: cmd
On OSX Sierra.

what's your Vim version?

VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Dec  6 2016 12:07:41)
Included patches: 1-898, 8056
Compiled by<EMAIL_ADDRESS>

@ixodie you're not on the right repo. Your error is related to SpaceVim/SpaceVim.
There are 3 spacevim: SpaceVim/SpaceVim, liuchengxu/space-vim and mine. All of them are independant from each other.


[SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Test cases mentioned in issues have done by hand and can not run automatically now.

Coverage decreased (-0.01%) to 87.26% when pulling fc10389f8068140c46eae68d850a22558beabf2e on liubao68:registry-build into bbe18e493aa3fb3d1531f7e6bee806e22d9994b4 on apache:master.


fix: Fix to create a new planner for each query

(Continuation of PR #917: implemented additional changes based on feedback.)
Hi team,
The ExecutionEngine reuses the planner, but this approach sometimes causes incorrect states. To address this issue, similar to the method used in Cosmos, the implementation has been modified so that a planner is created and processed for each query.

After further testing, I've discovered that this pull request causes issues in other parts of the application. Therefore, I am withdrawing it for now.

After further investigation, I have determined that the issues were not related to this fix. Therefore, I would like to reopen this pull request.

Since this issue has been resolved by pull request https://github.com/wundergraph/graphql-go-tools/pull/925, I am closing it.


Added placeholder to HTMLInputElement

placeholder attribute was missing from HTMLInputElement.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Closing in favor of https://github.com/facebook/flow/pull/1767


Buttons cannot be customized: Can we make them generic over a containing widget?

As it stands, the current implementation of widget::Button cannot be meaningfully customized. Some things that would be nice:

Containing other visual cues, such as a icon
Increasing the size for buttons that are meant to be prominent

Proposal:
The current implementation nests a Label<T> but aside from Button::dynamic() (which we can keep as its a builder method) doesn't do anything label-specific in layout/paint. What if we made Button generic over its contained widget?
That would allow us to keep the button-specific logic we know and love (the hovering, rounded edges, click visuals etc) but enable custom contents as well as some control over sizing.
Happy to send a PR if this works.

I agree, it would be nice to have a clearer strat on what the next-gen improvements & patterns are across our widget base. Agree that discussion might make more sense as a supplementary issue. Do you have something in mind?
At least for this issue around buttons, I'm fairly confident that this fits the existing model of composing widgets within other widgets through a builder method, delegating the non-core events/logic down to descendant widgets while handling whats important for itself (in a buttons case, thats the hover effect, the rounded corners, and the on_click handler).

I've popped the comment above into a new issue (#2160) – if you have any thoughts regarding the above, do add them there as well!


Display a warning message if "noscript" is blocking JS

A colleague at BIDS mentioned that the experience on Binder for people running noscript is a bit confusing. Because JS won't run if "noscript" is present, users generally just see a frozen spinner of the Binder logo after they click a Binder link.  There's no notice that JS is needed for the page etc.
I wonder if it's possible to have a default text show up if the JS doesn't load, e.g. "Binder uses javascript to build and launch your Binder. It doesn't seem to be running. Try unblocking Binder from any javascript-blocking plugins you may have, and refreshing the page!"
Anyone know how tough that'd be?

I think the way to do this is to have the warning in the HTML source and then have a bit of JS to hide it. This way it will always appear if you don't have JS but be hidden if you have it.


Dynamically choose the connectivity channel to perform

Feature Request
In customized version of Android OS if the Device is connected to wifi and it has no internet connectivity it will not try to perform the HTTP call using the cellular data. if this is handled in the library itself it will be helpful. ie. when an HTTP call is triggered the Okhttp choose through wifi channel or cellular data the call must perform. In early Android versions they supported ConnetivityManager.setPerference(). But now this is deprecated. If this feature is implemented. it will be very helpful.
I mean to loop through the NetworkInterfaces and check the destination address is reachable or not and then if reachable the call must perform through that interface.

I recommend you use an interceptor for this. It's not reasonable for OkHttp to do this because there’s no simple policy that would work for most apps.


Why we have slow (unwanted) rerender on setTime()?

Please, could you explain why when calling setTime() within an RxJs stream (values are emitted rapidly due to requestAnimationFrame), there is a significant performance hit with a long rerender of all elements, whereas with drag, the time change happens at the same speed, but there is no noticeable rerendering?

   this.replayComposer.currentTime$
      .subscribe(t => {
        if (!this.timeline) {
          return
        }

        const isSet = this.timeline.setTime(t);
        if (isSet) {
          this.timeline.redraw();
        }
      })

@Maksclub maybe rxjs is called it too often?
To ensure that this is a root cause, you can remove all other redraw calls.
RxJs has a denounce method, please try use and see whether issued Is gone
this.replayComposer.currentTime$.pipe(
    debounceTime(200),
  )
      .subscribe(t => {
        if (!this.timeline) {
          return
        }

        const isSet = this.timeline.setTime(t);
        if (isSet) {
          this.timeline.redraw();
        }
      })

Pipe timers (with setTimeout, setInterval) is very slowly then it is not variant for me. If I make debounce without timers I see rerender all elements while when dragging the timeliner, only it is redrawn

Solution
  this.replayComposer.currentTime$
      .pipe(filter(() => !!this.timeline))
      .subscribe((t) => {
        // @ts-ignore
        this.timeline._setTimeInternal(t)
        // @ts-ignore
        this.timeline.redraw()
      })

Result:


Promote AOTAutograd decompositions to the main set

I want there to only be one set of decomps, so get rid of the out of line AOTAutograd decomps and clean them up.
Signed-off-by: Edward Z. Yang<EMAIL_ADDRESS>

Oh, these decompositions are meant to be "hacky"/"not necessarily correct" decompositions.
For example, previously I put a "decompositions" from aten::_s_where to aten::where here.

New plan on record is to make it easy for uses of tracers to both say what decomps they want, as well as define behavior by their own decomps. However, I do think these two decomps morally should be in our decompositions set.


Re-enable email notification for forum replies

See ReggieN second post here - https://myapnea.org/forum/myapnea-forum-is-dying
Particularly thinking about a new user signing up, creating a forum topic (detailing his/her issue/question), and then getting an email ping (instead of in-app) when a user replies. This would be a reversion to make things (i.e. notifications) more like how they were before the in-app notifications came around. There are a few old issues regarding the notification changes (https://github.com/myapnea/myapnea.org/issues?q=notifications).
(Requested per SR/ASAP)

Thanks, these two will potentially cause myapnea emails to start getting black-listed again (and cause posts to be necro'd), we may need to find other solutions for those cases. I'll make sure this only happens if emails are opted-in to in settings.


BUG: isinstance calls property success before status object is done

Causes problems in ophyd-epics-devices when tying to create stage methods that return AsyncStatus objects.
    Traceback (most recent call last):
      File "/path/ophyd-epics-devices/tests/test_area_detector.py", line 233, in test_async_stage_single_trigger
        RE(async_stage_plan())
      File "/path/bluesky/bluesky/run_engine.py", line 895, in __call__
        plan_return = self._resume_task(init_func=_build_task)
      File "/path/bluesky/bluesky/run_engine.py", line 1034, in _resume_task
        raise exc
      File "/path/bluesky/bluesky/run_engine.py", line 1664, in _run
        raise err
      File "/path/mrbluesky/bluesky/bluesky/run_engine.py", line 1499, in _run
        msg = self._plan_stack[-1].throw(stashed_exception or resp)
      File "/path/ophyd-epics-devices/tests/test_area_detector.py", line 228, in async_stage_plan
        yield from bps.stage_all(det1, det2)
      File "/path/bluesky/bluesky/plan_stubs.py", line 753, in stage_all
        ret = yield Msg('stage', obj, group=group)
      File "/path/bluesky/bluesky/run_engine.py", line 1584, in _run
        new_response = await coro(msg)
      File "/path/bluesky/bluesky/run_engine.py", line 2368, in _stage
        if not isinstance(ret, Status):
      File "/path/python/anaconda/4.6.14/64/envs/python3.8/lib/python3.8/typing.py", line 1014, in __instancecheck__
        if all(hasattr(instance, attr) and
      File "/path/python/anaconda/4.6.14/64/envs/python3.8/lib/python3.8/typing.py", line 1014, in <genexpr>
        if all(hasattr(instance, attr) and
      File "/path/ophyd/ophyd/v2/core.py", line 84, in success
        assert self.done, "Status has not completed yet"
    AssertionError: Status has not completed yet

In the protocol part of the typing module:
    class _ProtocolMeta(ABCMeta):
        # This metaclass is really unfortunate and exists only because of
        # the lack of __instancehook__.
        def __instancecheck__(cls, instance):
            # We need this method for situations where attributes are
            # assigned in __init__.
            if ((not getattr(cls, '_is_protocol', False) or
                    _is_callable_members_only(cls)) and
                    issubclass(instance.__class__, cls)):
                return True
            if cls._is_protocol:
                if all(hasattr(instance, attr) and
                        # All *methods* can be blocked by setting them to None.
                        (not callable(getattr(cls, attr, None)) or
                         getattr(instance, attr) is not None)
                        for attr in _get_protocol_attrs(cls)):
                    return True
            return super().__instancecheck__(instance)

I can also see the case for returning None here, its falsy, but makes no other claim...

Decided to leave it as False


Add options to configure snapshot preid format

I took the liberty to implement feature that was requested in some opened issues (can't remember which): to allow . to separate timestamp part of the snapshot preid, and to allow timestamp part to come first.

Could you refresh my memory on the motivation behind this being configurable? I know some~ relevant context but would love to hear out your arguments first.

Could you refresh my memory on the motivation behind this being configurable? I know some~ relevant context but would love to hear out your arguments first.

AFAIK the reason for having the timestamp first in the preid is to be able to predictably sort prereleases, and using . is also related to sorting, because according to semver:

Precedence for two pre-release versions [...] determined by comparing each dot separated identifier [...].

A competing PR has been created, you might find it interesting: https://github.com/changesets/changesets/pull/858

The mentioned completing PR has been merged in and thus we can close this PR. Nevertheless, thank you for your contribution! It's very much appreciated.


Error in Website documentation

On your website https://arendjr.github.io/selectivity/  you mention the event for when the dialogue is closed is: selectivity-closed
but it is  selectivity-close

Good catch, thanks!


Added the Strange Stories JSON Task

Strange Stories Task: A Psychological Battery for Emotional Intelligence
This task measures NLP models' emotional intelligence (Theory of Mind) with the Strange Stories Task developed by Happe (1994). Her original psychological battery includes 20 naturalistic short stories and approximately 40 questions. Each story is at most a few paragraphs long (< 1024 tokens) and can be consumed by the recent neural NLP models.
This pull request submission includes the original 40 questions as well as approximately 100 additional hand-crafted questions to test for ToM abilities, including belief state attribution, emotion inference, intention inference, and etc.
Please let me know if you have any comments. Thank you!
Original Paper:
[1] An advanced test of theory of mind: Understanding of story characters' thoughts and feelings by able autistic, mentally handicapped, and normal children and adults
Example
A burglar who has just robbed a shop is making his getaway. As he is running home, a policeman on his beat sees him drop his glove. He doesn't know the man is a burglar, he just wants to tell him he dropped his glove. But when the policeman shouts out to the burglar, "Hey, you! Stop!", the burglar turns round, sees the policeman and gives himself up. He puts his hands up and admits that he did the break-in at the local shop.
Q: Did the burglar know the policeman just wants to tell him he dropped his grove?
"target_scores": {
"no": 1,
"yes": 0
}
Another Example
On Christmas Eve Alice’s mother takes her to the big department store in town. They go to look in the toy department.  Alice thinks she recognises Mr. Brown, so she runs up to him and asks, “Who are you?” Mr. Brown answers, “I’m Santa Claus!”
Q: Why did Alice go talk to Mr. Brown?
"target_scores": {
"because she thought she recognized him": 1,
"because Mr. Brown is giving out sweets to all the children": 0,
"because Alice's mother takes her to the big department store in town": 0,
"because Mr. Brown is shopping in the mall": 0
}
Last Example
Daniel and Ian see Mrs Thompson coming out of the hairdresser’s one day. She looks a bit funny because the hairdresser has cut her hair much too short. Daniel says to Ian, “She must have been in a fight with a lawnmower!”
Q: How would Mrs Thompson feel if she heard what Daniel said?
"target_scores": {
"upset": 1,
"joy": 0,
"neutral": 0,
"tired": 0
}
My Tests
I ran a GPT-3 model on a subset of the tests. GPT-3 performed worse than both human children and adult baseline accuracies. GPT-3 performs reasonably well at detecting/guessing emotional states but often fails to attribute belief states.

Thanks for the comment! The model does see the targets (keys) before
responding: they are added to the query string as described here
https://github.com/google/BIG-bench/blob/main/docs/doc.md#query-composition
.
Best,
Guy
On Tue, May 11, 2021 at 5:01 PM Richard Barnes @.***>
wrote:

My understanding of the target_scores dict is that there's some kind of
comparison between the each key of the dict and the model's response, but
that the model itself isn't offered the dictionary's keys.
This is potentially problematic since the comparison function used might
make mistakes miscrediting the model either positively or negatively. I
wonder if it wouldn't be better to somehow prompt the model to choose from
a set of multiple-choice answers?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/BIG-bench/pull/262#issuecomment-839304552, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADGRN7EKTK6TR67QN3TC2LTNHAMXANCNFSM44V34K6A
.

Really appreciate the discussion here. Please feel free to let me know if there's something I need to change. Thanks!

Thanks for submitting such an interesting task. You can also avoid from the choices to appear appended to the inputs by setting append_choices_to_input=False.
It is totally up to you but might I suggest that you split the questions into an easy and hard subtask? It seems like the questions with 4 options and full justification are harder and splitting it might help tell whether the model does better than random.
I actually also wrote some multiple answers for the "Revisiting strange stories" paper (except for the Unlinked Sentences). I was hesitating with respect to submitting it but I would be happy to add the extra questions to your PR if you think this could improve the coverage of the task.

Hi @lewkowycz ,
Thank you for your comments. Sure, please feel free to add the questions you wrote! Can you please advise me on what to do next?
I am happy to split the task into a easy and hard subtask – does that mean I will create two new PRs? Which PR would you like to add to?
Thanks a lot,
Yifu

@chen-yifu Perfect, I will add my questions after the split.
You can do it in one PR and two json files. The file structure should be (see more details here ):
-strange_stories_json/README.md
-strange_stories_json/hard_task/task.json
-strange_stories_json/hard_task/README.md
-strange_stories_json/easy_task/task.json
-strange_stories_json/easy_task/README.md

The subtask README can be just be one line describing why it is different. I don't know if easy and hard is the right naming, you could call it boolean and multiple choice. The reason is that in the current format if a model gets a question 50% right on the multiple choice or 50% right on the yes/no answers, it gets the same score, but getting 50% right on the multiple choice is clearly smarter.

Hi @lewkowycz ,
Sorry for the delayed response. I just created a new pull request at #352 , which categorized the questions into either boolean or multiple-choice groups.
If you have any comments on how to improve, please let me know. I'm also willing to help with adding your questions too!
Thanks so much for your time.
Regards,
Yifu (Charles)

@chen-yifu  Thanks for doing that. You could have added the changes to this PR. I will close this PR and will continue the thread in the other one.


"This function is only for training. For inference, please use forward_flashattn_inference."

I want do validation every epoch in training phase, so i do some change in the code.
but in the training i receive the follwoing error, i have see the source code, and know why.
i have delete the raise error code in llama_attn_replace_sft.py, but obviously this is not the best way to solve the problems.
so please ask, what should i do to make the model can use different attention in training and validation?

I think it is all right to do so if you mean it. Based on my understanding, full attention is the best way for inference. S^2 attention is OK, but might be inferior.

我明白您的意思，全量attention肯定是比稀疏的更好一些。我目前是在训练中验证时采用S^2，根据验证集指标来早停训练以及选择最好的模型，然后在测试集做推理时采用全量attention，那这种不一致会影响很大吗？
换句话说，在验证阶段是否也必须采用全量attention，这样才能保证推理时全量attention效果最好？您在实验中有这方面的观察吗？

您好，
一般来说，用S^2 attention测试得结果越好的模型，用full attention测试的结果一般来说也都越好。此外，我感觉不用保存最好的模型，因为我这边的观察是总是最后一个iters的模型最好。
祝好
陈玉康

好的，感谢！


Helpful error logging on JSON mapping

When this error is logged as debug level, by default developer will not see root cause of the error, and I struggled several hours because the only response was "Unable to process JSON" and logs for io.dropwizard ERROR level did not show any problems.
Invalid jackson mappings are quite common and should be more visible at least Error level.

Hey, thank you for your interest in supporting dropwizard.
The reason why it's under debug is for the same reason you mention:

Invalid jackson mappings are quite common

I'd be annoyed with all the stack traces in my logs (and being woken up at 2am) due to client issues.
If you'd like your clients to see the details, you can register (pseudo-code) new JsonProcessingExceptionMapper(showDetails: true)

If I remember correctly, this issue popped up a couple of years ago. Please see the discussion in #1052.

showDetails: true
Is not sufficient, I don't want to expose to the world about error details in json response. This part is fine.
But I need to have information about Error that caused this.
So if there was some error at 2am, I'm unable to see anything from error log,
even if I configure logger io.dropwizard.jersey.jackson.JsonProcessingExceptionMapper: DEBUG
This will be still logged as debug not an error.
If you annoyed about these errors, you can turn off logger for JsonProcessingExceptionMapper, and sleep well ;)
But rest of developers should not suffer and struggle by swallowed exceptions in log.

I'm not convinced.
If you want to see the details, enable debug logging.

So if there was some error at 2am, I'm unable to see anything from error log,

Because it's logged under debug. Ensures there's an appender which receives those events.

But rest of developers should not suffer and struggle by swallowed exceptions in log.

No one other than the client is suffering from client inflicted problems.
If the solutions provided thus far are still insufficient, you can always override the exception mapper, but we will not be changing the default level.

The appender will still output log message starting with
... DEBUG : ....
And you should avoid logging DEBUG level messages in prod.

If you want to see the details, enable debug logging.

I would argue that its much easier to pinpoint from log output what class logs you don't want to see and add those classes to certain level.
as  io.dropwizard.jersey.jackson.JsonProcessingExceptionMapper: NEVER
rather than specifically googling and figuring out that there should be some DEBUG level logging switched on.
Right now initially it's hard to figure out what's wrong with api, Unable to process JSON clearly indicates that there is something wrong and error log should be place to take a look, but if developer has not specifically configured
io.dropwizard.jersey.jackson.JsonProcessingExceptionMapper: DEBUG it's only guessing and stumbling without any help from logs or anywhere.
Also, by seeing something like this in prod log config
io.dropwizard.jersey.jackson.JsonProcessingExceptionMapper: DEBUG
is wierd and it feels wrong.
What I'm trying to say is that helpful error messages are really important, and useful for rapid issue resolving.
This issue caused me approx 4 hours of stumbling without any clue what's wrong with the api.
I had no clue that there is needed such hack, to set specific class to DEBUG level, to see an internal binding error real cause, and I'm trying to help other developers in future, avoiding being stuck with no clue what's wrong with JSON binding.

Yes, I agree, 4 hours debugging client issues would not be fun. If your clients can't figure out the error, and you don't want to return details to the client so they can fix the issue -- we've presented several methods to help.
Logging exceptions under a debug level is not uncommon -- here's an example from Jetty among many.  I'm fine if you want to pivot the discussion to allowing a configurable log level for client JsonProcessingException issues, but we won't be changing the default.

I'm closing this PR due to lack of activity.
@llyys Please leave a comment if you want us to reopen this pull request.


labels with URLs containing öäü don't work in handleURLTap

For example www.göögle.de will color the url blue but you can not use it in
label.handleURLTap {url in
}. It jumps right out. Is there a known workaround?

Use the custom regex


Severe performance regression of the Engine after Comparator API

After #4067 was merged, there is a severe performance regression of the Engine. Looking at some benchmarks, they seem to regress by roughly 100x. The benchmarking jobs are even failing with Error: The operation was cancelled, maybe because the jobs takes too long now. An example of a recent successful benchmark job is https://github.com/enso-org/enso/actions/runs/4134490767/jobs/7145690994, and the failing job is https://github.com/enso-org/enso/actions/runs/4142523782/jobs/7163290560. Note that all the Engine-benchmark jobs since that time are failing.
We should investigate what is happening in these benchmarks and why the performance is so slow ASAP.

See points 10 and 11 to quickly scan for deoptimizations https://github.com/enso-org/enso/blob/develop/docs/runtime-guide.md#tips-and-tricks

Analyzing performance of Any.==. Comparing a revision before Comparator API (https://github.com/enso-org/enso/commit/4f70bcc5ff42a898cc61a83e8daae988f11d6f57) [old] with most recent revision (6971dd08506adf0cb07c0f7da1cc859b2137e7bc) [new]. The source is:
from Standard.Base import all

my_func x =
    x == True

main =
    n = 100000
    iter_size = 100

    integer_vec = Vector.new n (ix -> ix)
    boolean_vec = integer_vec.map (x-> x % 5 == 0)

    res = 0.up_to iter_size . map _->
        boolean_vec.map bool->
            my_func bool

    res.first.first

Run with:
env JAVA_OPTS='-Dpolyglot.engine.CompilationStatistics=true -Dpolyglot.engine.TracePerformanceWarnings=all -Dpolyglot.engine.TraceCompilationDetails=true -Dpolyglot.engine.TraceInliningDetails=true' enso --no-ir-caches --log-level INFO --run tmp.enso

These are the outputs:

new.txt
old.txt

At first sight, there are no performance warnings neither in old, neither in new. In new, everything in Any.== is inlined, as expected. Looking at the compilation statistics, new has 3x more compilations (151) than old (46). So far, I have not found a simple bottleneck, it just seems that there is just more Enso code to compile.

@Akirathan why the regressions were not discovered before merging PR? We should always run benchmarks before PR is merged - what happened here?

@wdanilo There was a lot of pressure to finalize #4067, as it should be the last API-breaking change from the engine side. With @JaroslavTulach, we decided that we want to merge it as soon as possible, and deal with all the performance regressions as follow-up.

@wdanilo Moreover, benchmarks are run as post-merge jobs. Usually, this job takes several hours, so running it as a pre-merge check would not be a good idea. In the engine team, we run benchmarks locally, if we know that there might be some regressions. I just have not done that as part of #4067, because of the time pressure, and postponed it as a follow-up.

@Akirathan gotcha. How much time does it take to run benchmarks locally? I still think we should run them for all the PRs. Merging a PR even couple hours later is probably better than not discovering perf regressions. What do you think about it?

... a lot of pressure to finalize #4067, as... @JaroslavTulach, ... decided that we want to merge it as soon as possible,
and deal with all the performance regressions as follow-up.

It is my decision and my fault. Pavel did a magnificent work of providing hashcode support for all Enso objects. It took more than two months and (even when split to multiple sprints and pivotals) it turned out to be too huge. At the end I decided to not wait anymore, integrate and make sure all the API changes are in.
The regression is unfortunate, but it shall not affect ability of other teams to more forward - the API is there. We just need to find out what's wrong in the engine and speed it up - it is not going to be a non-solvable issue - we shall be able to get on par with speed of the previous behavior in a week or two. We'll have a pair programming with Pavel on Thursday - we'll focus on finding the cause.

@JaroslavTulach oh, no worries. Look, I was only worried that we can in the future overlook some regressions if we are not running benchmarks with every PR. That's my motivation behind asking these questions. I'm happy that we discovered the regression here, but if we are not running benchmarks before merging the a new code, we might (and probably will) not discover similar cases in the future. Thanks @Akirathan and @JaroslavTulach for taking care of it! <3

@JaroslavTulach oh, no worries. Look, I was only worried that we can in the future overlook some regressions if we are not running benchmarks with every PR. That's my motivation behind asking these questions. I'm happy that we discovered the regression here, but if we are not running benchmarks before merging the a new code, we might (and probably will) not discover similar cases in the future. Thanks @Akirathan and @JaroslavTulach for taking care of it! heart

I am afraid running benchmarks as part of pre-merge checks is simply not possible. Currently, engine benchmarking job takes roughly 3 hours. But not only that, I suppose that the job has some special scheduling policies (at least they should) - for example, you may want to schedule a benchmarking job on a node without any other jobs, so that stuff like HW perf counters work as expected, and are not interfered with. Moreover, we currently have just one benchmarking job taking 3 hours, these are just micro benchmarks, I expect this number to grow significantly in the future.

I tried to verify and while an visible improvement is there, I had to report:

#5712

as a needed continuation of the effort.


Dashboard & start staking info improvements #85ztq9u8a

fix dashboard logic with badges: show badge if more then 1 staking active for asset, don't show asset in more options if staking is inactive for the asset (not testnet), show badges for staking options in more options;
fix timers update to properly display time dependent value;
time formatters now display days and hours as on all the screens
fix styles on the screen

Task linked: CU-85ztq9u8a iOS. Start staking UI fixes


filterReports by parsing sourceCode.

Hello,
I am looking for a help. I am trying to use filterReports, although my predicate function has to be a bit more involved then any readme example or tests I saw in the lib.
I actually need to parse a whole sourceCode in similar way I would have parsed for a eslint rule.
Here is somewhat pseudocode to illustrate what I need.
const ruleComposer = require('eslint-rule-composer');

const noUnusedPropTypesReact = require('eslint-plugin-react').rules['no-unused-prop-types'];

const getPropsUsedInRedux = (sourceCode) => {
  const usedInRedux = [];

  somehowRunThis({
    FunctionDeclaration(node) {
      if (node.id && node.id.name === 'mapDispatchToProps') {
        usedInRedux.push[node.body];
      }
    },
  });

  return usedInRedux;
};

module.exports = ruleComposer.filterReports(
  noUnusedPropTypesReact,
  (problem, metadata) => {
    const usedInRedux = getPropsUsedInRedux(metadata.sourceCode);
    return !usedInRedux.contains(problem.node)
  },
);

It seems like I need some combination of filterReports and joinReports. Or maybe there is some other obvious way or another util I can use. Would be very grateful for any suggestions.
Thanks,
Diana

Hi, thanks for creating an issue.
Would it work to put the mapDispatchToProps check inside the filterReports call? Then you wouldn't need to have the separate FunctionDeclaration listener.
module.exports = ruleComposer.filterReports(
  noUnusedPropTypesReact,
  (problem, metadata) => {
    const node = problem.node;
    if (node.parent.body !== node) {
        return true;
    }
    return !(node.parent.id && node.parent.id.name === 'mapDispatchToProps');
  },
);

I do need that FunctionDeclaration listener and some others. I pretty much need to filter result of one rule by the result of another rule. Just problem.node is not enough, I need to analyze whole sourceCode to make a decision.
Here is particular issue I am working on: https://github.com/DianaSuvorova/eslint-plugin-react-redux/issues/28

I have created a function for what I need to get done.
It unfortunately requires a lot of helper functions copied from your lib and might not be generic enough, but it works for my purpose.
I will follow up if I get to cleaning it up, so I can offer it as a contribution for your library.
const filterReports = (rule, filterNode, filterAll) => Object.freeze({
  create(context) {
    const removeNodesFromReport = [];
    let allNodesFiltered = false;
    return getRuleCreateFunc(rule)(Object.freeze(Object.create(
      context,
      {
        report: {
          enumerable: true,
          value() {
            const reportDescriptor = getReportNormalizer(rule)(...arguments);
            if (filterAll(reportDescriptor)) {
              allNodesFiltered = true;
            }
            if (filterNode(reportDescriptor)) {
              removeNodesFromReport.push(reportDescriptor.node);
            } else if (!allNodesFiltered && !removeNodesFromReport.includes(reportDescriptor.node)) {
              context.report(removeMessageIfMessageIdPresent(reportDescriptor));
            }
          },
        },
      },
    )));
  },
  schema: rule.schema,
  meta: getRuleMeta(rule),
});

module.exports = (rules, filterNode, filterAll) => filterReports(ruleComposer.joinReports(rules), filterNode, filterAll);

Thanks a lot for creating this library - it was super helpful for me!
Diana


Kill refmt_merlin

refmt_merlin is not used anymore as merlin is now smart enough to figure out reason files. Let's remove all the references to it in our codebase.

@tekknolagi Do you mind take a look at this?

Yep, can do.

Gone since a while now


[libvirt_manager] Fix undefined variable cifmw_reproducer_basedir

This change removes the reference of cifmw_reproducer_basedir in libvirt_manager role. Referencing the tasks from start_manage_vms throws undefined variable name.
As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running

/approve

/lgtm


Splunk Custom Steps

The changes relate to Splunk custom steps. The intention is to let dev teams to assert some of the events also in Splunk logs.
Please note that the test runs against mocked Splunk instance and the development was conducted with locally running Splunk Docker image.
There have been some talks with EIT Splunk Monitoring team to let us to use java sdk, but it may take a while until we are capable to use it in EIT domain.

Solves #398

FYI, I was also discussing with Pavel possibility to use @ConditionalOnProperty or @ConditionalOnExpression that would check on the presence of particular Splunk property in env in case of SplunkClient instantiation.
Both annotations are from spring.boot.autoconfigure and we decided that we will skip it as well as we wont also implement own conditional.


Resend email while onboarding user

[ ] Resend Verification Email functionality for the user to be able to resend the verification link
[ ] Resend button/hyperlink

On Hold due to API Refactor priority.


docs: how to install into a spring boot project

To be merged once the modules are published to maven central.

Thanks!


Add reference to base image

DeeZone

Should I move these details to the README as a PR or the repo wiki?

sergii-tkachenko

Yes, thanks! Sounds great!

@sergii-tkachenko Does it make sense that these values are in the README or should they be in the wiki with a link from the README?

:+1:


[GLUTEN-2031][VL] Enable lag window function

What changes were proposed in this pull request?
Support lag window function.
How was this patch tested?
Spark UT.

Is there any test to ensure lag can be offloaded?

Just added the test. Thanks!

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_2737_time.csv
log/native_master_02_27_2024_94c8e7e0e_time.csv
difference
percentage

q1
32.94
33.59
0.645
101.96%

q2
24.40
24.40
-0.003
99.99%

q3
38.89
38.91
0.018
100.05%

q4
37.65
36.13
-1.514
95.98%

q5
71.79
70.98
-0.812
98.87%

q6
5.49
7.08
1.599
129.15%

q7
83.54
84.44
0.904
101.08%

q8
85.08
86.39
1.304
101.53%

q9
127.30
121.48
-5.823
95.43%

q10
44.22
44.06
-0.161
99.64%

q11
20.42
19.96
-0.459
97.75%

q12
25.16
29.43
4.277
117.00%

q13
45.30
45.22
-0.082
99.82%

q14
17.06
16.33
-0.737
95.68%

q15
28.98
28.90
-0.085
99.71%

q16
13.82
15.96
2.148
115.54%

q17
102.31
103.10
0.796
100.78%

q18
148.86
148.22
-0.643
99.57%

q19
14.21
12.53
-1.683
88.16%

q20
26.09
26.71
0.617
102.36%

q21
226.06
224.21
-1.854
99.18%

q22
13.68
13.66
-0.016
99.88%

total
1233.28
1231.71
-1.567
99.87%


SQL Server crashes continually

I'm getting a frequent crash, almost daily, with logs like this:
2023-04-13 10:24:39 04/13/2023 18:24:39.675370569 Info [paldumper] <0000000009/0x00000000> Executing PalDumper against PID: 10
2023-04-13 10:24:39 04/13/2023 18:24:39.675378076 Info [paldumper] <0000000009/0x00000000>                       Dump type: miniplus
2023-04-13 10:24:39 04/13/2023 18:24:39.675380904 Info [paldumper] <0000000009/0x00000000> Stopping target
2023-04-13 10:24:39 04/13/2023 18:24:39.675384910 Info [paldumper] <0000000009/0x00000000> Target stopped
2023-04-13 10:24:39 04/13/2023 18:24:39.675386730 Info [paldumper] <0000000009/0x00000000> Attaching to target threads
2023-04-13 10:24:39 04/13/2023 18:24:39.675441688 Warning [paldumper] <0000000009/0x00000000> Yama PTRACE mode: 1-Restricted
2023-04-13 10:24:39 04/13/2023 18:24:39.675510624 Error [paldumper] <0000000009/0x00000000> Attempt to execute ptrace command (16) for pid=10 failed - EPERM process cannot be traced.
2023-04-13 10:24:39 04/13/2023 18:24:39.675523257 Error [paldumper] <0000000009/0x00000000> errno: 0x00000001
2023-04-13 10:24:39 04/13/2023 18:24:39.675538039 Info [paldumper] <0000000009/0x00000000> Parsing /proc/10/maps for region coverage
2023-04-13 10:24:39 04/13/2023 18:24:39.675555400 Info [paldumper] <0000000009/0x00000000> Virtual memory region count: 0
2023-04-13 10:24:39 04/13/2023 18:24:39.675568328 Error [paldumper] <0000000009/0x00000000> Unable to load region map
2023-04-13 10:24:39 04/13/2023 18:24:39.675570896 Info [paldumper] <0000000009/0x00000000> Detaching from target threads
2023-04-13 10:24:39 04/13/2023 18:24:39.675573732 Warning [paldumper] <0000000009/0x00000000> Attempt to execute ptrace command (17) for pid=120 failed - ESRCH process does not exist.
2023-04-13 10:24:39 Executing: /opt/mssql/bin/handle-crash.sh with parameters
2023-04-13 10:24:39      handle-crash.sh
2023-04-13 10:24:39      /opt/mssql/bin/sqlservr
2023-04-13 10:24:39      10
2023-04-13 10:24:39      /opt/mssql/bin
2023-04-13 10:24:39      /var/opt/mssql/log/
2023-04-13 10:24:39
2023-04-13 10:24:39      b8525ccc-ee46-4e48-bf15-581f3a1d9bd8
2023-04-13 10:24:39      2832529a-ed42-43c9-b06c-72c77d2588ff
2023-04-13 10:24:39
2023-04-13 10:24:39
2023-04-13 10:24:39
2023-04-12 16:05:19 This program has encountered a fatal error and cannot continue running at Thu Apr 13 00:05:19 2023
2023-04-12 16:05:19 The following diagnostic information is available:
2023-04-12 16:05:19
2023-04-12 16:05:19          Reason: 0x00000004
2023-04-12 16:05:19         Message: RETAIL ASSERT: Expression=(!"A timeout or deadlock was encountered while waiting" " for a thread to terminate/suspend/resume.") File=NtumWaiter.cpp Line=829
2023-04-12 16:05:19     Stack Trace:
2023-04-12 16:05:19                  file://package5/windows/system32/sqlpal.dll+0x0000000000209902
2023-04-12 16:05:19                  file://package5/windows/system32/sqlpal.dll+0x0000000000208C61
2023-04-12 16:05:19                  file://package5/windows/system32/sqlpal.dll+0x0000000000218565
2023-04-12 16:05:19                  file://package5/windows/system32/sqlpal.dll+0x00000000002774AD
2023-04-12 16:05:19                  file://package5/windows/system32/sqlpal.dll+0x00000000002538F9
2023-04-12 16:05:19                  file://package5/windows/system32/sqlpal.dll+0x000000000024947D
2023-04-12 16:05:19                  file://package5/windows/system32/sqlpal.dll+0x0000000000246E1B
2023-04-12 16:05:19                  file://package5/windows/system32/sqlpal.dll+0x0000000000201F5E
2023-04-12 16:05:19                  file://package5/windows/system32/sqlpal.dll+0x000000000039F6D8
2023-04-12 16:05:19                  file:///Windows/SYSTEM32/KERNELBASE.dll+0x000000000007EDD0
2023-04-12 16:05:19                  file:///binn/sqlservr.exe+0x000000000000459A
2023-04-12 16:05:19                  file:///binn/sqlservr.exe+0x0000000000006DF3
2023-04-12 16:05:19                  file:///binn/sqldk.dll+0x000000000018E920
2023-04-12 16:05:19                  file:///binn/sqldk.dll+0x0000000000015007
2023-04-12 16:05:19                  file:///binn/sqldk.dll+0x000000000018C619
2023-04-12 16:05:19                  file:///binn/sqldk.dll+0x0000000000008B1B
2023-04-12 16:05:19                  file:///binn/sqldk.dll+0x0000000000009128
2023-04-12 16:05:19                  file:///binn/sqldk.dll+0x0000000000008C84
2023-04-12 16:05:19                  file:///binn/sqldk.dll+0x000000000002A463
2023-04-12 16:05:19                  file:///binn/sqldk.dll+0x000000000002A50C
2023-04-12 16:05:19                  file:///binn/sqldk.dll+0x00000000000299EF
2023-04-12 16:05:19                  file:///binn/sqldk.dll+0x0000000000029F15
2023-04-12 16:05:19                  file:///Windows/SYSTEM32/KERNEL32.DLL+0x0000000000017DF4
2023-04-12 16:05:19                  file:///windows/system32/ntdll.dll+0x000000000005B7C1
2023-04-12 16:05:19         Process: 10 - sqlservr
2023-04-12 16:05:19          Thread: 129 (application thread 0x1f4)
2023-04-12 16:05:19     Instance Id: b8525ccc-ee46-4e48-bf15-581f3a1d9bd8
2023-04-12 16:05:19        Crash Id: 2832529a-ed42-43c9-b06c-72c77d2588ff
2023-04-12 16:05:19     Build stamp: da729593fa9bc048da0037e5e85e1b296f1e5a8fbc8e1385d683b5b22fa891e1
2023-04-12 16:05:19    Distribution: Ubuntu 20.04.5 LTS
2023-04-12 16:05:19      Processors: 10
2023-04-12 16:05:19    Total Memory:<PHONE_NUMBER> bytes
2023-04-12 16:05:19       Timestamp: Thu Apr 13 00:05:19 2023
2023-04-13 10:24:39 Monitor was signaled to collect dump. However monitor failed to take down the child process. Exiting.
2023-04-13 10:24:39 Capturing a dump of 10
2023-04-13 10:24:39 FAILED to capture a dump. Details in paldumper log.

So far since I've installed this—about a week ago—I've had to restart the container every morning when I come to my desk.
I'm not sure what to make of it. Please advise.

which version of sql server ?

Pardon me, I should have included better information.
Here's my init command:
docker run -e "ACCEPT_EULA=Y" -e "MSSQL_SA_PASSWORD=<SQL Password>" -e "MSSQL_DATA_DIR=/var/opt/mssql" -p 1433:1433 --name mssql -h C52893-F -v D:\SQL\:/var/opt/mssql -d mcr.microsoft.com/mssql/server

So I'm using the latest version of SQL Server 2022, Developer Edition. I'm also running it under Hyper-V backend, as I can't connect to it under WSL, even after creating a brand new container (error: Connection forcibly closed by host).

cause of problem is Developer Edition

OK, I switched to Express.
I'll give that some time to bake and see how it goes. I'm hopeful.

That seems to have done the trick.
Thank you.

not at all. can you follow me?

Thanks for the invitation, but I'm on information overload already 🙂

How did you switch the mssql image to Express edition?

@mplaksyuk
Here's my full docker run command:
docker run -e "ACCEPT_EULA=Y" -e "MSSQL_SA_PASSWORD=<password>" -e "MSSQL_DATA_DIR=/var/opt/mssql/data" -e "MSSQL_BACKUP_DIR=/var/opt/mssql/backup" -e "MSSQL_PID=Express" -p 1433:1433 --name mssql -h <hostname> -v D:\SQL\:/var/opt/mssql -d mcr.microsoft.com/mssql/server

Naturally you'll want to replace the <password> and <hostname> placeholders with your own values.
Also, this command assumes that you want to persist your databases in D:\SQL. I haven't tested that with spaces in the path.
Reference: https://learn.microsoft.com/en-us/sql/linux/sql-server-linux-configure-environment-variables?view=sql-server-linux-ver16


Unsupervised Learning, Week 2 Practice Lab 2: Programming Assignment: Deep Learning for Content-Based Filtering

Hello,
Thank you so much for providing such content. Again, it seems that the programming assignment of Deep Learning for Content-Based Filtering has been changed and I want your help with that lab and to share with me the .ipynb file.
It would be much more appreciated if you could help me further with that.

Hey !
You have the solution here : https://studytrics.com/content/c1798be4-1cd3-4c0a-852c-d7f5f2b17bdb


Advanced responsiveness for mobile screens

Any chance for something like this?
https://jsfiddle.net/ryanoc/Vb99a/

This is pure CSS, completely under your control.


not found in type: 'mutation_root': Undefined location when used with hasura

Describe the bug
I am trying to use the package with hasura qraphql, when I try to insert data using mutation I have the following error:
I/flutter ( 3689): [field "insert_mobile_tokens" not found in type: 'mutation_root': Undefined location]
are there any options that I miss?

this is my code

    String addToken =  r'''
    mutation addToken{
  insert_mobile_tokens(objects: {token_string: "dgdfg", os_type: "android"}) {
    returning {
      id
    }
  }
}

''';

    final MutationOptions options = MutationOptions(
      document: addToken,

      variables: <String, dynamic>{
//        'token': push_token,
      },
    );
    final QueryResult result = await Client.mutate(options);

    if (result.hasErrors) {
      print(result.errors);
      return;
    }

    final bool isStarrred =
    result.data['action']['starrable']['viewerHasStarred'] as bool;

    if (isStarrred) {
      print('Thanks for your star!');
      return;
    }

I haven't worked with Hasura before, so am not able to help you since the error is being generated by Hasura. One thing i have noticed, is that you are passing a variable to you mutation, which doesn't accept variables. Also can you try and run the query on GraphiQL and see if it works.
For more help, please provide a reproducible example.

Probably you figure it out. However for any future questions. This error is thrown by Hasura when you don't have permissions. You must add in this case Insert permissions for the table you are inserting into. Also important since you are returning id, you must have permissions also for select. Since Hasura does first Insert and then select for your returning.
I am sure this can be closed now. @mainawycliffe

closing as this looks more like a server side / usage issue

you don't have relevant permission. change the permission of the table and it should work


Trainer without generative model

Feature: Option to create a Trainer instance without a generative model for offline learning.
Use Case: Simulate the data outside of Python (e.g. C++/Matlab) but use the BayesFlow library in offline learning mode.

resolved in commit  6334c454229005c8ac05469b37e76e2fcf382dcb


Use proper variable for nsqadmin_interface

Currently the default nsqadmin_addr value will use the interface defined for nsqd, however it should be using the defined nsqadmin_interface

@nrmitchi thanks! somehow I missed this PR.  Apologies for the late merge.


Adapt Semantic Versioning

Last week there's been a new version 1.10.0 released which included breaking changes. This violates semantic versioning, a standard you should stick to when releasing a package for SPM.
see https://docs.swift.org/package-manager/PackageDescription/PackageDescription.html:

The version rule requires Swift packages to conform to semantic versioning. To learn more about the semantic versioning standard, visit semver.org.

The problem which arises here is that this update broke every setup where this package was referenced with upToNextMajor which is unexpected when following semantic versioning.
I would therefore like to encourage you to consider this for future releases.

Hi @rlindner! We actually do our best to maintain backwards compatibility, regardless of SemVer. Our swift-composable-architecture library is pre-1.0 but has maintained source compatibility over all of its releases, with large windows for deprecations to be migrated.
SemVer guidelines are generally taken to mean "source compatibility," of which this Snapshot Testing release has none: we don't believe there are any APIs that have changed that would lead to existing projects not build. We try to be very aware of non-source breaking changes, though, and try to communicate them appropriately. In the case of updates listed under "breaking changes," there are a few categories:

Bug fixes that may change the output of a snapshot: bug fixes are generally "patch" concerns, but almost always come with behavioral changes. This is actually a big criticism of SemVer, since a patch update that fixes a bug can still break an app when it updates. Please note that snapshots already "break" frequently due to environmental changes: Apple regularly changes how UI renders over OS updates (minor and major), and different devices may output different results. In fact this release comes with a new API that will hopefully provide users with a more stable snapshot suite when run on both Intel and M1 devices.
Deprecations to tooling we no longer support, i.e. CocoaPods and Carthage, or changes to tooling, i.e. SPM. These tools are ancillary to the library source.

Is there a particular breaking change that you are having issues with or consider source-incompatible?

Also, I'm going to convert this to a discussion since we try to reserve issues for bug tracking.


Fix to MoneyInput

First, thanks for making this plugin. The native handling for money in Filament is lacking! Maybe this plugin will be pulled into Filament core one day? :smile:
I was having a similar issue to #9. As stated in the requirements for this plugin, I am storing my money as an integer value of minor units, and the MoneyColumn looked great, but the MoneyInput was not showing the decimal value correctly, even with the mask. For example, the integer value 400023 was becoming 400,023 instead of 4000.23.
So on the input field hydration, essentially copied what you did for MoneyColumn. However I also created a new static method on the MoneyFormatter to output the intl. decimal format instead (i.e. without the currency symbol), so it will work with and without the mask applied. I added some tests for this new method. Oh, and in the tests, I changed the metadata in the comments to attributes to avoid deprecation notices (apparently support for metadata in the comments will be removed in PHPUnit 12).
Also, I added minValue and maxValue overrides that use the MoneyFormatter to parse the decimal input before comparing with the passed-in max and min values. The base minValue and maxValue methods that are built-in to numeric inputs in Filament were not working because validation seems to occur before dehydration, where the input gets parsed.
I tested the MoneyInput with GBP, USD, and SEK, with and without the mask, and it seemed to work well. Please let me know if I've missed something, and feel free to make edits if needed.

Thank you!
Yes, that was one of the first things I noticed when I started using Filament.
I just skimmed through the PR quickly now, and it looks good. I need to take a closer look, test and make a new release. Hopefully I can do that this weekend.

Thanks, Peter! And I'd be happy to help add some tests for the components themselves in the near future.
16 Feb 2024, 08:18 by @.***:

Thank you!
Yes, that was one of the first things I noticed when I started using Filament.
I just skimmed through the PR quickly now, and it looks good. I need to take a closer look, test and make a new release. Hopefully I can do that this weekend.
—
Reply to this email directly, > view it on GitHub https://github.com/pelmered/filament-money-field/pull/11#issuecomment-1947939417> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/AIICCZZAUW3MLN6BUOQESZ3YT4I6VAVCNFSM6AAAAABDIDB73KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBXHEZTSNBRG4> .
You are receiving this because you authored the thread.> Message ID: > <pelmered/filament-money-field/pull/11/c1947939417> @> github> .> com>

@npbreland  I made a pre-release with this included if you would like to check it out. I would like to receive some feedback or do some more testing before full release.

@npbreland I made a pre-release with this included if you would like to check it out. I would like to receive some feedback or do some more testing before full release.

@pelmered Sounds good to me. I may have a little time this evening to work on some feature tests for the form input and table column. Looks like Filament has some documentation:
Testing forms
Testing tables

@pelmered I made a start on creating some feature tests this evening, but I'll need more time. I'm somewhat new to Livewire, so this a good chance to learn a bit. I'll keep you updated.

Hello @npbreland , thanks for the fix version 1.2.0.
Already try USD, IDR and EUR, seems okay and it work as expected.
But it breaks some of the currency, like
UEA Dirham => currency: AED, locale: ar_AE.
Saudi Riyal => currency: SAR, locale: ar_SA.

Hello @npbreland , thanks for the fix version 1.2.0.
Already try USD, IDR and EUR, seems okay and it work as expected.
But it breaks some of the currency, like UEA Dirham => currency: AED, locale: ar_AE. Saudi Riyal => currency: SAR, locale: ar_SA.

No problem @jinbatsu! Thanks for the report. I think the tests only cover SEK and USD at moment, so I definitely want to add some more and figure out how it can support as many currencies as possible. Could you tell me which components you're seeing this in: the table column, form field, etc.?

It is on form field.

Thanks for reporting @jinbatsu and thanks for helping out @npbreland!
Yes, the mask feature is a bit experimental at the moment as stated in the readme and it is probably the problem here like @npbreland said.
I have mostly just tested this with common currencies like USD, EUR etc and SEK as I'm from Sweden. It would be great if we could add some more tests with formatting for more currencies. However, I guess the mask could be a bit tricky to test as a lot of that happens in the front end.

@npbreland, I already create sample repo.
https://github.com/jinbatsu/sample-filament-money-input
And here is the screenshot:
Mask: False

Mask: True

@pelmered, thanks for this great plugin, yes it seems the problem with mask and it is right-to-left.

If I'm using Version 1.1.0
composer require pelmered/filament-money-field:1.1.0
It is worked with mask, the display using standar numeric, not arabic, and it is left-to-right.
Screenshot:


Rename Predicate to NSPredicate

Following work done in, and blocking, https://github.com/apple/swift-corelibs-foundation/pull/567
Both commits need to be merged at around the same time to keep CI from breaking

CI currently running in linked PR

(Tested manually, though, so it should work)


convert CRC16 to Scala

Maybe fix #225 ?
> java -version
openjdk version "11.0.1" 2018-10-16
OpenJDK Runtime Environment 18.9 (build 11.0.1+13)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.1+13, mixed mode)

> sbt ++2.13.0 publishLocal

> unzip rediscala_2.13-1.9.0.jar

> javap -verbose redis/util/CRC16.class | grep version
  minor version: 0
  major version: 52

Coverage increased (+0.3%) to 90.776% when pulling 22ba50bf48d3b685069506bd7a09ceef5392cb98 on zaneli:refactor/crc16-scala into 5600b0023c44fea410afe6c7d2d89b6ec26a0533 on etaty:master.

@etaty Hello, I am mentioning you here to hopefully draw your attention.
Is there any interest in merging this PR? This would be helpful as I do not think we need any features from JDK11 (am I right ?).
I am here to give you a hand if any help is needed

@etaty Hello, I am mentioning you here to hopefully draw your attention.
Is there any interest in merging this PR? This would be helpful as I do not think we need any features from JDK11 (am I right ?).
I am here to give you a hand if any help is needed


simplify parsing of the configuration options

This trivial patch simplifies option parsing by using std::getline.

imho:

amend commit message to [hud] Simplify parsing of the configuration options
variable name eq is a bit misleading, because = character here is a parameter delimiter.
Something like if (hasParam) {m_options.insert({...});} else {m_enabled.insert(...);} would improve readability.

does this solve any problem in practice other than us now potentially having to worry about locale issues?

No feel free to close.


[BUG] Bulk update error when trying to save

When submitting form post request to save the modified data I get this error without error code.
Database updated just fine and unsure why its trying to do bulk update.

Versions
Laravel: 9.6
Scout: 9.4
Scout Elasticsearch: 6.0
Elasticsearch: 8.4.3

Actually went to check the log file from Laravel, there is proper elasticsearch error for failed to parse field.
I will close the issue probably not related to the library.


[Balancing] Some feedback after testing your items

Hi ! First of all I really like most of the ideas you have for your items, plus you put extra effort to actually do models for the items. So I wanted to give you some feedback after thoroughly testing your mod !
[Spine Implant] : Feels good to use, situationnal as all whit items should be. Is there any sound feedback like for the Repulsive Armor ? If not it might be good to add some. (I'm not sure as I tested it with other mods) Might be a bit too good with characters like the Enforcer !
[Scratch Ticket] : It feels quite strong for a white Item, if you put it as green you can make it a bit more powerful but the fact that it affects all allies feels quite good already.
[Relentless Vendetta] It's a really cool item but it feels a bit too dependent on other items such as drones or specific equipment. I don't really know how to fix this while keeping the idea alive though 😅
[Contraband Gunpowder] This one feels really weak sadly. I really love the idea to add some explosions here and there but it's not really good because you need to actually kill enemies to have a chance to activate it. I thought about a few ideas for this one : the first would be to make it a on-hit proc item, but it would make it feel a lot like will'o and other explosive items. Another idea would be that the item actually gets stacks everytime you pick up a powder flask and then it explodes for damage when you get hit/use an equipment. Last one would be a Lunar conversion for this item : ennemies have more chance to drop pickups but pickups explode when they do drop. Tell me how you feel about this !
[Faulty Spotter] Once again great idea, it feels really powerful however ! Maybe turn the crit chance down to 50% ? I'd have to playtest it more to give you an accurate percentage.
[Crystallized World] This is craaaazy good. I know red items are supposed to be op but 7 seconds freeze is bonkers ! Especially considering the fact that enemies can be killed way quicker that way. 1.5-2 seconds would already be enough tbh, especially considering the size of the teleporter ! So yeah, shorter freeze would feel more balanced.
[Timely Execution] 6 seconds of invincibility feels like a lot in this game, but the fact that it's a really situationnal item makes it feel balanced.
[Treasure Map] This one feel quite underpowered, waiting 2 minutes in the same spot is probably too difficult to make it really usable, especially considering that you need to farm to open the chest after this. I really like the idea though ! You could maybe turn this into some sort of OP rusty key or something. Like it grants access to a chest with a red item in it but the item disappear when you open the chest. (Of course you can't get another treasure map inside that chest)
[Rift Lens] I think the slow is really annoying and turns this good idea into a average one. Maybe make the character take double damage or something ? Like some chest addict that doesn't feel safe without having found his free chest. Also maybe add some feedback to the free chest like the rusted key chest !
[Gate Chalice] While I like the general Idea behind it, being able to skip a stage/boss feels probably too powerful for a 140s cooldown, I'd say it should be around 180-200s. Otherwise the feeling for this one is the same as the rift lens, you should probably turn it into an effect that can stack like the Tonic Affliction !
[Ratio Equalizer] This item is so good !! Crazy good even, being able to heal yourself so much if used properly is making it op, especially with a 20s cooldown. A 35-45s cooldown would probably make this more balanced.
And that's it for me ! I really like your ideas, please keep up with the good work and tell me if my feedback was useful or not !
(I'd be happy to playtest stuff for you if you ever need help !!)

Closing all suggestion/enhancement/balancing/feedback issues. A new, actual discussion board will be set up after the next mod update.


Added lofi-radio.co connector

Adding a basic connector for the lofi-radio website!

👌

That should fix things. 🤔

Yes, now test is passed for me.

Also, please add an URL pattern w/o "www".

Well, I meant to add the pattern and keep the one with "www", like:
	{
		label: 'Lofi Radio',
		matches: ['*://lofi-radio.co/*', '*://www.lofi-radio.co/*'],
		js: ['connectors/lofi-radio.js'],
	},

The extension doesn't recognize the website in certain case without this change (I type "lofi-radio.co" in the adress bar and Chrome redirects to http://www.lofi-radio.co, but the website is also available at http://lofi-radio.co).

oh I was certain I could do that, two moments.

Thanks 👍


request: increase minor version after fixing vulnerabilities

I am not sure if this belongs to the win32-installer repo or here (see #359, sorry for the duplication).
Problem
In my company installed software (eg vim) is scanned regularly. For the installed version of each software component a lookup with known vulnerabilities is done, and in case of any findings the user is urged to update.
For version 9.1.0000 there were 4 known CVEs, that were fixed soon afterwards (thanks!).
When I upgraded to the latest vim version the following scans kept reporting those 4 CVEs, since the windows registry only names 9.1 as the vim version, but not eg 9.1.0837.
So the scanner is not able to differentiate between the fixed and the vulnerable version. Of course the scanning is automated and will mercilessly escalate this (informing my boss about it).
Describe the solution you'd like
If the release policy could be changed to increase the minor version after fixing of CVEs, that would very certainly help.
Alternative
If the installer could be changed to put the patchlevel part also in the version as seen in the registry, that maybe might help.
Thanks!

Each change of the C source core, increments the patch number. I am not planning to increase the minor number, just because a vulnerability has been reported, sorry. As mentioned in the other issue, the patchlevel is already part of the version number inside the registry.


Support Publishing via the Central Portal instead of legacy OSSRH

Sonatype changed their publishing method for new artifacts and now it has to be done via the Central Portal. On their website, it says that there is no official Gradle plugin yet but that we can use JReleaser, which does support the new method.,

+1

+1

Fyi: I managed to fix it in https://github.com/Ivy-Apps/di
A few notes:

key-id must be only the last 8 chars
the key must be uploaded on a keyserver and its email verified

We have completely overhauled this and are addressing the issue now.


Control panel not working

I'm assuming this is related to #662 , but I'm getting the following error when I try to run m.controlpanel():
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-5-1284bb9e590e> in <module>()
    237 # sol=m.localsolve()
    238 # sol = m.solve()
--> 239 m.controlpanel()

/Users/codykarcher/Dropbox (MIT)/Research/gpkit/gpkit/constraints/costed.pyc in controlpanel(self, *args, **kwargs)
     83         """
     84         from ..interactive.widgets import modelcontrolpanel
---> 85         return modelcontrolpanel(self, *args, **kwargs)

/Users/codykarcher/Dropbox (MIT)/Research/gpkit/gpkit/interactive/widgets.py in modelcontrolpanel(model, *args, **kwargs)
    101     """
    102
--> 103     sliders = model.interact(*args, **kwargs)
    104     sliderboxes = []
    105     for sl in sliders.children:

/Users/codykarcher/Dropbox (MIT)/Research/gpkit/gpkit/constraints/costed.pyc in interact(self, ranges, fn_of_sol, **solvekwargs)
     74         """
     75         from ..interactive.widgets import modelinteract
---> 76         return modelinteract(self, ranges, fn_of_sol, **solvekwargs)
     77
     78     def controlpanel(self, *args, **kwargs):

/Users/codykarcher/Dropbox (MIT)/Research/gpkit/gpkit/interactive/widgets.py in modelinteract(model, ranges, fn_of_sol, **solvekwargs)
     89             #     print(out)
     90
---> 91     resolve()
     92
     93     return widgets.interactive(resolve, **ranges)

/Users/codykarcher/Dropbox (MIT)/Research/gpkit/gpkit/interactive/widgets.py in resolve(**subs)
     68         try:
     69             try:
---> 70                 model.solve(**solvekwargs)
     71             except (AttributeError, ValueError):
     72                 model.localsolve(**solvekwargs)

/Users/codykarcher/Dropbox (MIT)/Research/gpkit/gpkit/constraints/prog_factories.pyc in solvefn(self, solver, verbosity, skipsweepfailures, *args, **kwargs)
     77                       solver, verbosity-1, *args, **kwargs)
     78         else:
---> 79             self.program, solvefn = genfunction(self, verbosity-1)
     80             result = solvefn(solver, verbosity-1, *args, **kwargs)
     81             solution.append(result)

/Users/codykarcher/Dropbox (MIT)/Research/gpkit/gpkit/constraints/prog_factories.pyc in programify(self, verbosity, substitutions, **kwargs)
     32         if not substitutions:
     33             substitutions = self.substitutions
---> 34         prog = program(self.cost, self, substitutions, verbosity, **kwargs)
     35         if return_attr:
     36             return prog, getattr(prog, return_attr)

/Users/codykarcher/Dropbox (MIT)/Research/gpkit/gpkit/geometric_program.pyc in __init__(self, cost, constraints, substitutions, verbosity)
     63             constraint.substitutions = self.substitutions
     64             try:
---> 65                 constr_posys = constraint.as_posyslt1()
     66             except TypeError as err:
     67                 if err.message == ("SignomialInequality could not simplify to"

/Users/codykarcher/Dropbox (MIT)/Research/Conceptual_Design_Tool/CDT/Models/GPkitModels/XFOIL.pyc in as_posyslt1(self)
     11
     12     def as_posyslt1(self):
---> 13         raise TypeError("This CD model is not allowed to solve as a GP.")
     14
     15     def as_gpconstr(self, x0):

TypeError: This CD model is not allowed to solve as a GP.

should be resolved by #667. @cjk12, please close if so.

Yup, we're good.


Add more software

Sushi uses snapcam quite a bit, Resolume is a lesser known part of his set up. Could probably do with some rewording.

I'm okay with adding both of the technologies into the list, no real wording changes from me.


support for php

i'm not a big user but i'd like to have it covered if i could. how to?

 php           https://github.com/asdf-community/asdf-php.git#1eaf4de


TPH does not use the New Name property

BaseEntryExit is TPH and the fields have New Name set to Booleans and Doubles.

ArcAutoRadius Base Type is BaseEntryExit.  Resulting code for ArcAutoRadius show Expected Name instead of New Name

public virtual ICollection<EntryExitBoolean> EntryExitBooleans { get; set; } = new List<EntryExitBoolean>();

public virtual ICollection<EntryExitDouble> EntryExitDoubles { get; set; } = new List<EntryExitDouble>();

Also, using the EDMX the Booleans and Doubles properties would reside in the BaseEntryExit.  With EF Core it resides in ArcAutoRadius.  Is there a reason the properties can no longer be in BaseEntryExit?

Another issue with default EF Core mapping.  Fixed in v1.2.8 (which is building now)

I just tries 1.2.9 but still see this issue.  Thoughts?

Most of the methods like GetProperties() are recursive, meaning they include the props of base type entities automatically. You need to adjust your T4 to filter out the props to only that of the declaring type such as:
EntityType.GetProperties().Where(o => o.DeclaringEntityType == EntityType)

Same for indexes, foreign keys, etc in the configuration:
EntityTypeConfiguration.t4
Same for EntityType.t4


io: copy fails with EOPNOTSUPP on NFSv4.1

What version of Go are you using (go version)?

$ go version
go version go1.15 linux/amd64

Does this issue reproduce with the latest release?
Yep.
What operating system and processor architecture are you using?
linux/amd64
This seems to be an issue specific to RHEL/CentOS 7.8 (and possibly other RHEL/CentOS 7 versions), and specifically with copying between files on the same NFSv4 filesystem.
What did you do?
In a directory that is on an NFSv4.1 mount on a host running CentOS 7.8
src, err := os.Open("src.txt")
if err != nil {
    panic(err)
}
dst, err := os.Create("dst.txt")
if err != nil {
    panic(err)
}
_, err:= io.Copy(dst, src)
if err != nil {
    panic(err)
}

What did you expect to see?
No error.
What did you see instead?
Error EOPNOTSUPP.  In some cases it can be intermittent, depending on server behavior.
The copy_file_range syscall is supposed to fail with ENOSYS, EXDEV, or EINVAL if there isn't appropriate support from the kernel/filesystem, in which case internal/poll.CopyFileRange will return a value indicating that the copy was not handled, and copying will proceed with a fallback implementation from there.
Unfortunately, for some versions of NFSv4, including the implementation present on CentOS/RHEL 7, if the server does not support range copies, NFSv4 will instead return EOPNOTSUPP, and due to a workaround in the kernel used by CentOS/RHEL 7.8.
There is a nearly identical issue open for the Rust standard library, which unfortunately some of our customers have already encountered.  We haven't started shipping anything with Go 1.15 yet.
The conclusion of the issue thread in Rust appears to be that the best thing to do here is treat EOPNOTSUPP as the same as ENOSYS.  I personally agree with that conclusion.  Pedantically speaking the bug is definitely in those kernels, not in Go, but unfortunately CentOS 7 is far too popular to ignore.

At the rate we have to work around broken kernels, I wonder if copy_file_range will be used at all.

cc @thoeni

Happy to create a CL for this one, I think I'm now familiar with the issue.

Also, I just noticed that this has been already addressed by: https://github.com/golang/go/issues/40731
I got confused between the two EOPNOTSUPP and ENOTSUP in the title of the other issue. I'd say this will be fixed/resolved with the next release?

Yes, this does seem to duplicate that issue.


Fix schema compare include/exclude behavior

Previously, the schema compare differences table wasn't updating the inclusion state of other differences that were affected by the checking/unchecking of a different row. This fixes that by updating the checkboxes of affected dependencies and also resetting the checkbox state if the include/exclude request failed.

since we are very close to the final code freeze and the feature is only used by schema compare, I am ok with merge as is and open an issue to track the refactor work after the nov release.


Use Checkstyle for travis-CI

I saw that it was mentioned in passing on #24 but nothing seemed to come of it. As Travis-CI is now in use since that issue, I feel it would be beneficial to reconsider the use of Checkstyle as Checkstyle would then be run against every PR. My suggestion would to use Google's coding standard as it is one of the more popular ones.
I'd be happy to work on this but just want some confirmation that such a change is desired.

Sounds good to me :)


Update issue templates

Updated the issue templates to resolve an issue
where the only option for the 'Do I have a custom
or modified version of the application?' question
was 'Yes'.

resolve copy/paste mistake

Resolved


Doesn't work under Python 3.7 due to warning

In utils.py
DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

If it's a warning, it should just work with 3.7? Certainly something we will fix though!