AttributeError: 'LPCCondorJob' object has no attribute 'env_dict'

Trying to migrate my condor implementation from work_queue which doesn't play nice with LPC temp directories.
In the simple example the line
cluster = LPCCondorCluster()

needs to be
cluster = LPCCondorCluster(shared_temp_directory='/tmp', worker_extra_args=['--worker-port 10000:10070', '--nanny-port 10070:10100', '--no-dashboard'], job_script_prologue=[])

My job starts waiting for workers and then I get a never ending loop of
Singularity> python ZZ4b/nTupleAnalysis/scripts/coffea_lpcjobqueue.py
WARNING: GSI authentication is enabled by your security configuration! GSI will not work in future releases.
For details, see https://htcondor-wiki.cs.wisc.edu/index.cgi/wiki?p=PlanToReplaceGridCommunityToolkit
Waiting for at least one worker...
Task exception was never retrieved
future: <Task finished name='Task-46' coro=<_wrap_awaitable() done, defined at /opt/conda/lib/python3.8/asyncio/tasks.py:688> exception=AttributeError("'LPCCondorJob' object has no attribute 'env_dict'")>
Traceback (most recent call last):
  File "/opt/conda/lib/python3.8/asyncio/tasks.py", line 695, in _wrap_awaitable
    return (yield from awaitable.__await__())
  File "/opt/conda/lib/python3.8/site-packages/distributed/deploy/spec.py", line 63, in _
    await self.start()
  File "/srv/.env/lib/python3.8/site-packages/lpcjobqueue/cluster.py", line 106, in start
    job = self.job_script()
  File "/srv/.env/lib/python3.8/site-packages/lpcjobqueue/cluster.py", line 87, in job_script
    quoted_environment = quote_environment(self.env_dict)
AttributeError: 'LPCCondorJob' object has no attribute 'env_dict'
2022-09-12 11:45:41,124 - tornado.application - ERROR - Exception in callback functools.partial(<bound method IOLoop._discard_future_result of <tornado.platform.asyncio.AsyncIOLoop object at 0x7fa7907636a0>>, <Task finished name='Task-45' coro=<SpecCluster._correct_state_internal() done, def
ined at /opt/conda/lib/python3.8/site-packages/distributed/deploy/spec.py:319> exception=AttributeError("'LPCCondorJob' object has no attribute 'env_dict'")>)
Traceback (most recent call last):
  File "/opt/conda/lib/python3.8/site-packages/tornado/ioloop.py", line 741, in _run_callback
    ret = callback()
  File "/opt/conda/lib/python3.8/site-packages/tornado/ioloop.py", line 765, in _discard_future_result
    future.result()
  File "/opt/conda/lib/python3.8/site-packages/distributed/deploy/spec.py", line 358, in _correct_state_internal
    await w  # for tornado gen.coroutine support
  File "/opt/conda/lib/python3.8/site-packages/distributed/deploy/spec.py", line 63, in _
    await self.start()
  File "/srv/.env/lib/python3.8/site-packages/lpcjobqueue/cluster.py", line 106, in start
    job = self.job_script()
  File "/srv/.env/lib/python3.8/site-packages/lpcjobqueue/cluster.py", line 87, in job_script
    quoted_environment = quote_environment(self.env_dict)
AttributeError: 'LPCCondorJob' object has no attribute 'env_dict'

Fixed with:
cluster = LPCCondorCluster(shared_temp_directory='/tmp')

pip install<EMAIL_ADDRESS>


Improve rootElement default

At the moment, rootElement defaults to body, which is not particularly smart. It can be set manually, but we can improve the experience here.

If we're willing to make undefined a special case we could have the default be:

Look for [ng-app], [ng:app], and if exactly one result is found use that
Otherwise, use body (or maybe throw an error?)

Whoa, I was just about to open an issue on this topic, good to see this is something the protractor team is looking into.
I continually get errors like:
Error: Error while waiting for Protractor to sync with the page: "root element (body) has no injector. this may mean it is not inside ng-app."
Stacktrace:
Error: Error while waiting for Protractor to sync with the page: "root element (body) has no injector. this may mean it is not inside ng-app."
at Error ()
==== async task ====
Protractor.waitForAngular()
at [object Object]. (/home/ubuntu/skraphaug/angular/test/e2e/home_page_spec.js.coffee:39:37)
==== async task ====
Asynchronous test function: it()
Error
at [object Object]. (/home/ubuntu/skraphaug/angular/test/e2e/home_page_spec.js.coffee:38:7)
at [object Object]. (/home/ubuntu/skraphaug/angular/test/e2e/home_page_spec.js.coffee:28:5)
at Object. (/home/ubuntu/skraphaug/angular/test/e2e/home_page_spec.js.coffee:6:3)
at Object. (/home/ubuntu/skraphaug/angular/test/e2e/home_page_spec.js.coffee:127:4)
at Object.loadFile (/home/ubuntu/skraphaug/angular/node_modules/coffee-script/lib/coffee-script/register.js:16:19)
at require (module.js:380:17)
at Function.promise (/home/ubuntu/nvm/v0.10.33/lib/node_modules/protractor/node_modules/q/q.js:650:9)
at _fulfilled (/home/ubuntu/nvm/v0.10.33/lib/node_modules/protractor/node_modules/q/q.js:797:54)
at self.promiseDispatch.done (/home/ubuntu/nvm/v0.10.33/lib/node_modules/protractor/node_modules/q/q.js:826:30)
at Promise.promise.promiseDispatch (/home/ubuntu/nvm/v0.10.33/lib/node_modules/protractor/node_modules/q/q.js:759:13)
at /home/ubuntu/nvm/v0.10.33/lib/node_modules/protractor/node_modules/q/q.js:525:49
at flush (/home/ubuntu/nvm/v0.10.33/lib/node_modules/protractor/node_modules/q/q.js:108:17)
at process._tickCallback (node.js:419:13)
While for us, our homepage declares ng-app on the html tag,

Which lead me to this thread on SO
http://stackoverflow.com/questions/20059943/running-into-error-while-waiting-for-protractor-to-sync-with-the-page-with-basic
Would you suggest just adding root-element of body in my conf.js file?

If body is not the root element of your ng-app, you should specify what element is in your conf.js, yes

@sjelin thanks, I've specified rootElement: 'html' now in my cont.js file, just extremely curious as to why protractor 90% of the time never complained that it was looking for the rootElement on body, with my ng-app being defined on html

I'm seeing errors that don't appear to happen in either local runs of my tests, or on Travis. But, on a Jenkins slave running firefox, xvfb and Protractor 1.7.0, I'm getting this error quite frequently. At least once a test.
I've updated my conf file to point to '[ng-app]' as my rootElement, and now my stacktrace looks like this:
    Error: Error while waiting for Protractor to sync with the page: "root element ([ng-app]) has no injector. this may mean it is not inside ng-app."
      at Error (<anonymous>)
      at /home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1526:15
      at newFrame.onAbort (/home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1679:7)
      at [object Object].webdriver.promise.Frame_.notify_ (/home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1914:5)
      at [object Object]._onTimeout (/home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1887:13)
      at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)
  ==== async task ====
  Protractor.waitForAngular()
      at [object Object].webdriver.WebDriver.schedule (/home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/webdriver.js:345:15)
      at [object Object].Protractor.executeAsyncScript_ (/home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/protractor/lib/protractor.js:251:26)
      at [object Object].Protractor.waitForAngular (/home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/protractor/lib/protractor.js:274:15)
      at [object Object].to.(anonymous function) [as getCurrentUrl] (/home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/protractor/lib/protractor.js:60:7)
      at Context.<anonymous> (/home/tester/workspace/EncoreUI_Template_PR_Builder/test/stories/loggingIn.js:37:32)
      at /home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/protractor/node_modules/selenium-webdriver/testing/index.js:121:22
      at [object Object].webdriver.promise.ControlFlow.runInNewFrame_ (/home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1654:20)
      at [object Object].webdriver.promise.ControlFlow.runEventLoop_ (/home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1518:8)
      at [object Object].wrapper [as _onTimeout] (timers.js:258:14)
  ==== async task ====
      at Context.ret (/home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/protractor/node_modules/selenium-webdriver/testing/index.js:119:12)
      at Test.Runnable.run (/home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/mocha/lib/runnable.js:218:15)
      at Runner.runTest (/home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/mocha/lib/runner.js:374:10)
      at /home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/mocha/lib/runner.js:452:12
      at next (/home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/mocha/lib/runner.js:299:14)
      at /home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/mocha/lib/runner.js:309:7
      at next (/home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/mocha/lib/runner.js:248:23)
      at Object._onImmediate (/home/tester/workspace/EncoreUI_Template_PR_Builder/node_modules/mocha/lib/runner.js:276:5)
      at processImmediate [as _immediateCallback] (timers.js:336:15)

I see in the angular getTestability docs that it is thrown "often because the root element is outside of the ng-app", but in this case the selector comes back OK, so I'm wondering what some other reasons why the root element wouldn't have an injector.

Please ask questions like this on stack overflow. (Also I think that angular isn't loading properly)

@sjelin I think I've got a fix that works. I'll post (and answer) a stackoverflow question and delete this.

+1 for looking for [ng-app], [ng:app] and defaulting to body if 0 or >1 results found.

I've set rootElement: 'html' but I still get the error in a test that involves a redirect/reload not triggered by the control flow. I posted detailed information on http://stackoverflow.com/questions/30783518/protractor-test-sometimes-fails-when-reloading-angular-app

Hello, I have been reading about this issue that randomly, my protractor test is failing because of the same error mentioned above (Error while waiting for Protractor to sync with the page: "root element (body) has no injector. this may mean it is not inside ng-app.) Is there a solution there that guarantees consistency? My application does the bootstrapping manually, so the ng-app is set to body but sometimes I get this error. I have tried to set rootElement: 'html' but the tests fail sometimes. Can you please advise guys if you have found a solution for this? Thanks in advance.

Please ask support questions on stack overflow.  Also, you probably want rootElement: 'body'

Ok, thanks!

I updated to Protractor 3.2.1, and I get the following error:
Error while waiting for Protractor to sync with the page: "window.angular is undefined.  This could be either because this is a non-angular page or because your test involves client-side navigation, which can interfere with Protractor's bootstrapping.  See http://git.io/v4gXM for details"
ng-app is on html tag, and there is an ng-controller directive on the body tag.
I tried setting rootElement: 'html', but that did not seem to make a difference.
I did not get this error in Protractor 3.1.1

Does your test involve a non-angular page?  Or client-side navigation (i.e. clicking on a link)?  Did you check the URL for details?

The test does not involve a non-angular page.  By client-side navigation, I'm confused.  Do you mean navigation that uses ng routing?  i.e. we are using angular-ui-router, so the only links we have keep the user on the same page, just a different path after the /#/
But those links are everywhere in our app, and we need to test them in our automated tests.  And the confusing part about the link is:

issue is closed
description says to just add a better error message

The workaround seems to be calling browser.refresh() after clicking on a link - does that actually add another browser refresh in this instance?  It seems like a risky workaround.
I guess I should be adding this info to that (closed) issue, but I thought that it had more to do with my rootElement being in the html tag, and controller in the body tag.  And I could not recreate in 3.1.1, only 3.2.1.
I also tried the workaround mentioned in the link below, but that did nothing:
http://stackoverflow.com/questions/34600052/protractor-throwing-error-now-that-ng-app-directive-is-on-html-tag
workaround I tried:  rootElement: '[ng-app="ourApp"]'
Hey, thanks for the quick response!  Protractor is amazing, but it is really hard keeping up with browser and selenium versions.  New stuff keeps coming in and breaking everything!!

If the links never cause a page to unload then it's not a client-side navigation problem (probably).  Could you get me a small reproduction of this problem?  Preferably in a small github repo?  And make a separate issue for it (since this is a discussion not a bug report)?

Sorry for my messages, please disregard them.  I was using gulp-protractor, and assumed that it was using protractor as a peer dependency.  My issue is related to my own setup; nothing with protractor itself.

This is also going to become interesting as Angular2 hits, where we have no ng-app helper. I'm not sure there's much we can do there. But we can still help out for 1.5.

Pending  and version 5.0, we'll be changing this to the following:

config.rootElement now defaults to ''
If you are an ng2 app, '' is equivalent to useAllAngular2AppRoots
If you are an ng1 app, and you are using version ~1.3.12 or >=1.4.0-beta.3 of angular.js, '' defaults to the element you bootstrap to.
If you are an ng1 app, and you are using an older version of angular.js, we will automatically search for injectors in <body> and elements tagged with either ng-app or ng-controller.

This should find your root element almost all the time.


Add new grpc handler functionality, refactor and add tests

New Functionatlity

Protobuf supports an empty type, add support for those types in
graphql
Protobuf messages can be defined in a nested way. Support this
nested way of defining and referencing proto messages.

Refactor

Move helper functions to utils into their own file.
Move scalar related stuff into it's own file. This will allow for
manipulating scalar mappings externally.

Tests

Add helper function unit tests.
Add tests for valid proto file use cases.

@rufman Thank you! That's awesome contribution!


Switch from accepting signed URL to GS URL in data explorer import

Currently BVDP data explorers such as Nurses and AMP-PD are sending json files for import into Saturn via signed URL. This has been deemed unacceptable as it is possible that any 3rd parties who obtained these URLs and access this content
A suggestion from the DE team is to instead provide a gs path to the json file. Our system service account would be given permissions to read it. Permissions would otherwise be restricted.

Signed URLs are temporary passwords. Third parties who obtain passwords may access content. We make efforts to not disclose passwords to third parties. The alternative, eliminating password use, is not a feasible solution.

@kleighwe Can you organize a conversation around this topic with Melissa from Verily? It should include @panentheos and @dmohs, possibly @zarsky-broad given the work with signed URLs from Martha

@bradtaylor scheduled something for next week! :)

Not doing this for now. Fine with signed URLs for the moment. Moving this out into the future provides us more flexibility once entity service arrives, etc. There exist a number of options. Closing this until P&S requires it

FYI -- Andrea said the new EntityService will eventually accept GCS file as input. So Data Explorer could give the user proxy group or pet SA read access to the entity file.


change SSSynth to Korg everywhere

Upon merging, we will have to change the repo name for the readme links and badges to not be broken.


update ui library version to 0.3.92

update ui library version to 0.3.92

Coverage decreased (-0.03%) to 54.246% when pulling 39ffff7c84a3e79deff54c3efe1495cf040572b2 on steven-zou:master into d5a6d250828082673cdb6f1f699b26cae710b5ad on vmware:master.


Gltf animation is abnormal and can't control by index

I have a gltf model file, it have five animations.
I want to control any one of the animation's independent.

I use below code,the animation is abnormal.
applyAnimation(0, elapsedTimeSeconds.toFloat())

Use the code below,there no any animation being show.
applyAnimation(1, elapsedTimeSeconds.toFloat())
or
applyAnimation(3, elapsedTimeSeconds.toFloat())

The window 10 software 3D viewer and gltf-viewer in web can show all animation very well.
Thanks for any suggestion or other help.
The filament is very good and has helped me a lot with my work.

I used the release v1.10.6 and the latest sample-gltf-view for test.

Please rename morphtest.z01.zip to morphtest.z01 and do the same for others.
morphtest.zip
morphtest.z01.zip
morphtest.z02.zip
morphtest.z03.zip
morphtest.z04.zip

@fanbinnet is this the same model that you attached to #4268?

@fanbinnet is this the same model that you attached to #4268?

Not exactly the same. We do some change for animations.
In #4268 , just one animation in the model, the new model we separated the animation of “D，L，R，U”

Note to self: on macOS you can we recombine the zip files with: zip -s 0 morphtest.zip --out=unsplit.zip
unsplit.zip

babylonjs won't let me look at the model at all due to an error: "Offset is outside the bounds of the DataView"
At https://gltf-viewer.donmccurdy.com/, it doesn't look normal either.

If this issues is still be anaylsing ？

gltf-transform shows a bunch of errors in the model when running the validator (MESH_PRIMITIVE_MORPH_TARGET_INVALID_ATTRIBUTE_COUNT).


New version v1.2.3 doesn't allow to vote

The new version sets the votes to 0 and doesn't allow to vote.

This screenshot was taken using the same contracts as the previous screenshot

I'm closing this in favour of #153 to prevent any confusion and clearly focus on the issue


maven plugin: unable to configure scanset from the command line

I might be doing something wrong, but it doesn't appear setting the scanSet from the command line of the maven plugin works:
mvn --batch-mode -DscanSet=src --DversionCheckEnabled=false -DskipProvidedScope=true -DskipSystemScope=true org.owasp:dependency-check-maven:3.3.0:check
....
[ERROR] Failed to execute goal org.owasp:dependency-check-maven:3.3.0:check (default-cli) on project hadoop-main: Unable to parse configuration of mojo org.owasp:dependency-check-maven:3.3.0:check for parameter #: Cannot find default setter in class org.apache.maven.shared.model.fileset.FileSet -> [Help 1]
...

My ultimate goal is to scan "every directory but target", but I can't seem to get a basic 'src' working.
Thanks!

As the ScanSet is a complex data type - I have no idea how one would set that via the command line. The configuration can be added to the pom.xml as:
<configuration>
   <scanSet>
      <fileSet>
         <directory>src</directory>
      </fileSet>
   </scanSet>
</configuration>

I'm trying to do scans without modifying the project as part of adding dependency checker support to some Apache Software Foundation build and release tools (specifically under the Apache Yetus umbrella).  Adding support to Yetus will automate scans for a variety of ASF projects (Apache Hadoop, Apache HBase, and more).
The non-plugin doesn't do maven dependencies and the maven plugin doesn't scan every potentially relevant file without modifying the pom.  Currently, to get a full list of potential vulnerabilities, it means running dependency checker in its "two modes" (i.e., effectively twice).  If the maven plugin had the ability to specify scan sets from the CLI (and, even better, an "everything but" scan set), this would eliminate the need for two runs.

I too have this issue where I invoke the maven plugin as part of a jenkins pipeline. The project is well served by the plugin for those dependencies expressed through the pom, but other parts of the build aggregates OSGi bundles through karaf feature files, which are not detected by the plugin (and can't reasonably be expected to be). The ability to point to various locations or results from the command-line would be beneficial to me too.

The functionality to specify other scan sets exists. If there are organizational issues with modifying the pom.xml (or even the parent pom.xml) to add additional configuration for dependency-check is a different problem.  Have you considered putting this configuration into a profile so most developers do not run dependency-check as part of the build?
Failing that - PRs are welcome. This would be a fairly low priority item for the dependency-check team as there are a ton of other enhancement requests.

-DscanSet.fileSet=['src/main'] worked for me

The previous code to resolve this issue is not working. Please see #2671 for the new configuration option that will be available when 6.0 is released.


Release 7.6.2

This is a reminder for me and for all contributors, ES 7.6.2 has been released today.
Seeing the changelog (https://www.elastic.co/guide/en/elasticsearch/reference/7.6/release-notes-7.6.2.html), this is mainly a bugfix version.

Release is available here: https://github.com/vvanholl/elasticsearch-prometheus-exporter/releases/tag/<IP_ADDRESS>


granted: 0.25.0 -> 0.26.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/common-fate/granted/releases.
meta.description for granted is: The easiest way to access your cloud
meta.homepage for granted is: https://github.com/common-fate/granted
meta.changelog for granted is: https://github.com/common-fate/granted/releases/tag/0.26.0
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.26.0 with grep in /nix/store/xfg5vz65vvqjkb5pwnx96lfidsw689d6-granted-0.26.0
found 0.26.0 in filename of file in /nix/store/xfg5vz65vvqjkb5pwnx96lfidsw689d6-granted-0.26.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

granted

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/xfg5vz65vvqjkb5pwnx96lfidsw689d6-granted-0.26.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A granted https://github.com/r-ryantm/nixpkgs/archive/0f898b8ce645cb7dcaf402455b0088a14509a11d.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/0f898b8ce645cb7dcaf402455b0088a14509a11d#granted

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/xfg5vz65vvqjkb5pwnx96lfidsw689d6-granted-0.26.0
ls -la /nix/store/xfg5vz65vvqjkb5pwnx96lfidsw689d6-granted-0.26.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

granted

Maintainer pings
cc @ivankovnatsky for testing.

Result of nixpkgs-review pr 311964 run on x86_64-linux 1

1 package built:

granted


feat: accept labelledById prop to provide label for input tags

ADDED
labelledById: a required prop. This is the ID of the label of the input field and the tag container
FIX
Issue: For assistive technology users

when they input value to a  tag name, they will not have any context on what they are inputting for
When they edit pre-added tags they will not know what they are editing and the context of tags.

Solution :

accept a mandatory prop labelledById an id to label for both tag and input.

Screenshot VO when editing tag

accessibility tree when editing tag

then
now

screenshot of VO on input

This fixes the label related accessibility issue in https://github.com/react-tags/react-tags/issues/999

Also @shrilakshmishastry please merge the branch with master so the conflicts are gone :)


ng g c with non-default flags throws error

Bug Report or Feature Request (mark with an x)
- [X] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [x] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions
"@angular/cli": "6.1.1",
"@ngrx/schematics": "5.2.0",
"@nrwl/schematics": "6.1.1",
Repro steps
ng g c -is -it component-name
(trying to generate component without InlineStyle or inlineTemplate). In Angular.json, these are set as default: true, which may be causing the problem (in which case is there a better way to set the defaults that allow them to be overriden?)
Can generate component without flags (ng g c component-name)
Schematics default setting at end of angular.json
"schematics": {
    "@nrwl/schematics:component": {
      "styleext": "scss",
      "spec": true,
      "flat": true,
      "changeDetection": "OnPush"
    }
  }

Is this a nx issue vs a cli issue?
The log given by the failure
Schematic input does not validate against the Schema: {"inlineStyle":true,"inlineTemplate":true,"i":[true,true],"path":"/apps/admin/src/app/corporate/containers","styleext":"scss","spec":true,"flat":true,"changeDetection":"OnPush","skipImport":false,"export":false,"entryComponent":false}
Errors:
Data path "" should NOT have additional properties(i).
Desired functionality
should be able to generate a component different than the default setting using flags like -it and -is
Mention any other details that might be useful

This seems to be a bug with Nrwl. I was not able to reproduce it using our schematics. Are they using
Please note that -it and -is are not the proper flags anymore. You seem to want -t and -s, respectively. We changed the semantics of a single dash back in 6.0, and changed the aliases that weren't correct. Now there's no single dash double letter shortcuts, they're all single letters.
Closing this as working as intended.
Cheers!


Add the ability to download not only html, but also all site assets: css, js, imgs, etc

Add the ability to download not only html, but also all site assets: css, js, imgs, etc

Hi @namen3645 this is available with the feature full_resources.


Very slow inference (with local LLM) during agent work

Describe the bug
Very slow inference during agent work in comparison to usual LLM interaction
I'm using local setup with API connection to TextGen WebUI in local network
Each iteration of TaskWeaver is very-very slow
generation speed is drastically decreased to around 1-2 t/s (usual speed on same setup 15-20 t/s)
At this communication rate this tool is net very useful, simple coding task like print numbers executed in 20-30 mins.
Is there any tweak to solve it. I guess it could because of relatively large context in each request?
To Reproduce
Steps to reproduce the behavior:

Start the service
Type the user query "any listed query from example description"
Wait for the response forever

Expected behavior
Similar inference speed as Autogen
Environment Information (please complete the following information):

OS: MacOS
Python Version 3.11
LLM that you're using: number of different 7b models

hi bro, how to run with local llm?

Describe the bug Very slow inference during agent work in comparison to usual LLM interaction I'm using local setup with API connection to TextGen WebUI in local network Each iteration of TaskWeaver is very-very slow generation speed is drastically decreased to around 1-2 t/s (usual speed on same setup 15-20 t/s)
At this communication rate this tool is net very useful, simple coding task like print numbers executed in 20-30 mins. Is there any tweak to solve it. I guess it could because of relatively large context in each request?
To Reproduce Steps to reproduce the behavior:

Start the service
Type the user query "any listed query from example description"
Wait for the response forever

Expected behavior Similar inference speed as Autogen
Environment Information (please complete the following information):

OS: MacOS
Python Version 3.11
LLM that you're using: number of different 7b models

hi bro, how to run with local llm

Close inactive issues.


Resolve imported CSS files from anywhere

#103
cc @gaearon @keyanzhang

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

@gaearon I've just updated the PR

Awesome, thanks Glenn!

@glennreyes Just noticed CLA label isn’t set, can you sign the CLA please? See https://github.com/facebookincubator/create-react-app/pull/105#issuecomment-234667767.

@gaearon Sure... done ;)

Thanks!

Sorry, my bad @gaearon!

Hi,
It looks like the node_modules folder added (nodeModulesPath) is the one relative to the react-script inner module (unless the config has been ejected).
A more flexible path could be
path.resolve(__dirname, relativePath, 'node_modules');

Oops, good catch. @breaddevil Would you like to make a PR?

Good catch @breaddevil! 👍


fix(ci): try enable corepack before setup-node action

close #3607
Advanced the corepack enable step.
I'm not sure if it's fully resolved. I have checked to see if anyone else has raised this issue, but found nothing.

All failed and canceled jobs are python related.


molecule_docker could not resolve module/action "docker_login"

Hello,
i have recently updated my ansible/molecule setup and now im hitting a weird error which it seems i cannot resolve
INFO     docker scenario test matrix: dependency, create, prepare, converge
INFO     Running docker > dependency
WARNING  Skipping, missing the requirements file.
WARNING  Skipping, missing the requirements file.
INFO     Running docker > create
INFO     Sanity checks: 'docker'
ERROR! couldn't resolve module/action 'docker_login'. This often indicates a misspelling, missing collection, or incorrect module path.

The error appears to be in '/opt/venv/lib/python3.8/site-packages/molecule_docker/playbooks/create.yml': line 11, column 7, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

  tasks:
    - name: Log into a Docker registry
      ^ here

molecule version:
❯ molecule --version
molecule 3.2.3 using python 3.8
    ansible:2.10.5
    azure:0.5.0 from molecule_azure
    delegated:3.2.3 from molecule
    docker:0.2.4 from molecule_docker
    ec2:0.3 from molecule_ec2
    gce:0.2 from molecule_gce
    vmware:0.3.3 from molecule_vmware

❯ ansible --version
ansible 2.10.5
  config file = None
  configured module search path = ['/home/dockeruser/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /opt/venv/lib/python3.8/site-packages/ansible
  executable location = /opt/venv/bin/ansible
  python version = 3.8.7 (default, Feb  4 2021, 01:39:45) [GCC 10.2.1 20201203]

ansible collections installed
        community.general:=1.3.6
        ansible.windows:=1.4.0
        community.windows:=1.3.0
        azure.azcollection:=1.4.0
        community.azure:=1.0.0
        google.cloud:=1.0.1
        community.google:=1.0.0
        amazon.aws:=1.4.0
        community.aws:=1.3.0
        kubernetes.core:=1.1.1
        community.vmware:=1.7.0
        community.docker:=1.2.2

i also tried community.general 2.1.1 with the same results.
My scenario does not contain a create.yml , only molecule.yml, converge.yml
Any ideas why I suddenly get this error?

How did you install your collections? If they are not in one of the default locations, Ansible might have trouble finding them when executed under molecule.

Well it was working earlier - before i did update ansible+molecule and everything.
I didnt change any path so it should technically just be the same, no?

Well it was working earlier - before i did update ansible+molecule and everything.
I didnt change any path so it should technically just be the same, no?

Well, recent versions of molecule started isolating things a bit more during testing. And if I remember correctly, limiting what directories are searched for installed collections is one of the things molecule plays with.

TThey have been installed with ansible-galaxy collection install --collections-path /usr/share/ansible/ansible_collections ... and you say this is causing issues?

thanks for the hint, it seems you are right. I ran molecule with --debug
and got
ANSIBLE_COLLECTIONS_PATH: /home/dockeruser/.cache/molecule/enable_ntp_client/docker/collections:/home/dockeruser/.ansible/collections:/usr/share/ansible/collections:/etc/ansible/collections
seems thats the path I set in ansible is not recognized ( it was /usr/share/ansible/ansible_collections ) so i changed it to just /usr/share/ansible/collections and it works again!
So thanks a lot

For others who may stumble across this issue:
An obvious thing to check is you have the collection installed. You can install it with:
ansible-galaxy collection install community.docker


Syncing stars/updated broken

It looks like this commit failed due to rate limiting  2 days ago, and the sync hasn't been run since even though it should have run yesterday.
cc/ @JasonEtco @bkeepers

My poor todo listing doesn't have any stars on the website 😭
It is entitled to its meager 2 stars.


Updatet spring boot version to 2.3.3

Thanks for the patch. The sample apps are still using 2.3.2 though. Did you forget to update them?

Thanks for the patch. The sample apps are still using 2.3.2 though. Did you forget to update them?

Yea i wil fix that also


Android update frameworks

Updates to latest Android frameworks, and latest master for required changes.

App is closed on background - temp workaround for loss of GL context
Set OnScreenKeyboardOverlapsGameWindow for Android
Add null check for Debug build check on Android

Tested on Pixel 3 XL - no issues found so far

Just to note: Only changes I have added was to the Android.props file - I needed to merge in master to be able to compile and run. If this needs to be removed for the PR, that can easily be done - though it would not compile without it.

No longer required, I pushed the commits directly to the branch.

Testing this branch @swoolcock - and all looks fine here :)


Delayed Jobs and Retry Jobs with Backoff

I wanted to open this ticket to discuss the proposal for adding both delayed and retry jobs with exponential backoff.
I think both delayed and retry with backoff are similar in that they can be scheduled to be executed at a later date.
Looking at the diagrams below, I think we can put both features in the same category.

The Postgres implementation is the easier out of three JobQueue drivers currently available (Memory, Postgres, Redis)
1 - Postgres Driver:
I am proposing of adding one more column to the _hb_pg_jobs table called scheduled_at with Nullable value.
2 - Redis Driver:
This will require one of two new row keys swift_jobs::scheduled::${JobID} and swift_jobs::ready${JobID} we can use Redis scripts to atomically move jobs from state (scheduled) to another state(ready). I am not too familiar with the RedisStack yet to know of this limitation.
I welcome some feedback on how to proceed further @adam-fowler @Joannis

I think you can build the retry with back off on top of delayed jobs. That is why I was suggesting we do a PR for delayed jobs first. Once we are happy with that we can implement the retry with back off.
Regarding the implementation we would need to separate the delay out from the data passed to the job driver as the different drivers will need access to this value.

Regarding drivers, yeah Postgres is easy. I also think the memory one is easy enough as well. A Redis script could be used for moving delayed jobs, but we'd have to be careful it doesn't lock the database too long. I am also a little concerned about moving logic onto the redis server.

First pass of delayed job implementation here I will follow up with the Postgres Driver then Redis.

I think we can close this ticket now!


Use HTTP gzip compression for the Agent telemetry payloads

What does this PR do?
Adds compression to Agent telemetry payloads
Motivation
Decrease network utilization
Describe how you validated your changes

Add TestUsingGZipCompressionInAgentTelemetrySender unit test
Possible Drawbacks / Trade-offs
Additional Notes

Small payloads ~600 bytes decreased by 2x+, medium payloads ~3k are decreased by ~6x

/merge


bumped nodemon version to remove vulnerable event-stream lib

As per https://snyk.io/blog/malicious-code-found-in-npm-package-event-stream

I signed it!

I signed it! (again)

I signed it!


Feature Request: Features from WallPanel Application

I'd like to request you implement a few things from your other application on the play store (WallPanel).

Battery Sensor Ouput via MQTT
Open on Device on Boot
Specify Browser Engine
Additional Camera Settings

Not sure if this should be split into multiple Issues or not.

All available sensor output via MQTT is already implemented.
I decided not to implement support for older browsers at this time.  However it’s an open source project and someone else could add this feature.
Can you explain what additional camera features are missing between the two applications?

About the sensor data: https://imgur.com/a/D2yVz4F
Those were both taken at the exact same time with each app side by side. Battery is missing from AlarmPanel (maybe this is a bug).
After investigating more thoroughly the Increase Brightness on Motion or Face Capture appears to be the only missing camera feature.

I decided not to implement the feature Brightness on Motion or Face Capture because the Alarm Panel application has built in screen savers and also that feature requires dangerous permissions for Android as it deals with the device screen.   I would have removed this feature from WallPanel if it were not already implemented when I took over the project.
I tested the battery sensor, and its reporting correctly from the Alarm Panel application.  I think you may have something incorrect in your Home Assistant configuration, here is what I have for my battery sensor in HA:
- platform: mqtt
  state_topic: "alarmpanel/sensor/battery"
  name: "Alarm Panel Battery Level"
  unit_of_measurement: "%"
  value_template: '{{ value_json.value }}'

It's important that the state_topic include the unique identifier "alarmpanel" and that this matches your device's base topic in the application MQTT settings.

The battery indicator isn't a sensor, it's always available.  So in WallPanel I added it to the list, but I didn't in Alarm Panel.   However, the data is available through MQTT as outlined in the documentation.  Its not a bug, meaning it does work, its just not displayed as a sensor in the sensor list because its technically not a sensor, its just a state that gets broadcast from the Android device.


[release-4.14] OCPBUGS-27403: fix: add missing permissions to cluster scoped resources

(cherry picked from commit ac3ea44d0d6175254f3cc0ba99a4997198c2a281)

/lgtm
/approve


Invulnerability doesn't work in race mode

Super late to the party, I'm guessing there's no VOD on this at this point?  Was trying to recreate, but invuln was working in my two player test case

You can pick it up, and the client will show it's working.  But then try to shoot them and they take damage like they don't have it.  I've seen it in nearly every ORL that had it.

I'll play with this more - regular Super pickup of invuln (i.e. visibly an invuln on your screen) behaves like expected, randomized L2 upgrade point landing on invuln is giving the bad behavior you described


Tutorial 02 Database Setup Documentation update

Trac ticket number
N/A
Branch description
I removed some unnecessary text about setting up a different database than the default SQLite to prevent overwhelming new Django users. This information can be found in more relevant parts of the documentation when the user is ready to experiment with different databases.

@evildmp

@evildmp, there should be no more traces of "toast" now!

As the author of many third-party database backends, I'm -1 on removing this. It's perfectly reasonable that newcomers to Django may not want to use SQLite. I don't think it's much of a burden for people to skip this section if it's not relevant to them.

It's perfectly reasonable that newcomers to Django may not want to use SQLite. I don't think it's much of a burden for people to skip this section if it's not relevant to them.

In a tutorial we should not be including material that users might want to skip, and definitely not be including material that the vast majority of users will want to skip.
In ~12 years of running introductory Django workshops and working with hundreds of beginners, I don't believe I have ever seen someone opt to use anything but SQLite. If someone is interested in using another database, they are very unlikely to want to know about it at this stage, because this is not a tutorial about Django and databases but about basic concepts in Django. That material, however important, belongs elsewhere and not here.
It's not just a burden on the user, it's also a burden on the maintainer. The tutorial needs to be a bullet-proof experience in which we take responsibility for the users' success, which we can only do if we know what's going on. If we introduce options, we have to take responsibility for guaranteeing success in all those different pathways.
It's a reasonable contract with the user to say: if you want to learn Django, follow our directions, so that we can help you. SQLite is built-in and doesn't require anything more.

I don't feel the audience of the tutorial should be limited to introductory Django workshops. I'm sure there are plenty of users who are new to Django and want to use it with their favorite database.

I don't feel the audience of the tutorial should be limited to introductory Django workshops. I'm sure there are plenty of users who are new to Django and want to use it with their favorite database.

Completely agree! But a tutorial is not the place for this. The tutorial should by all means contain pointers to such information, where the people who would benefit from it will find it, without making the vast majority of the people have to think about whether it applies to them.

This looks good to me. @nessita your thoughts?

I agree that the extra database setup details are disctracting, but I also didn't want to just loose them.
So I spent quite a while on this finding a new "home" for the removed part. I'm happy with the result, I have extended the db install docs with the relevant details taken out tutorial 2. No information was lost but at the same time each piece is at a more accurate location.
Merging when CI is green.


feat: Why Koda artist landing V1

PR Type

[ ] Bugfix
[x] Feature
[ ] Refactoring

Context

[x] Closes #9992
[x] Closes #10017

Needs Design check

@exezbcz please review

Did your issue had any of the "$" label on it?

[x] Fill up your DOT address: Payout

Screenshot 📸

[x] My fix has changed something on UI;

hello sir
nice job!
few things:
should have a black stroke

could you please also remove the hover?

Buttons

thought you will make it a button like this one but with different dimensions

hello sir
nice job!
few things:
should have a black stroke

could you please also remove the hover?

Buttons

thought you will make it a button like this one but with different dimensions

@exezbcz fixed

yup, works
one last detail, the row is incomplete
one nft is missing on bottom right place

letsgo, tablet and other sizes can be followup
thank you

https://github.com/kodadot/nft-gallery/pull/10016#discussion_r1559411064

nft background no longer there:

nft background no longer there:

code got updated https://github.com/kodadot/nft-gallery/pull/10016#discussion_r1559411064
now https://github.com/kodadot/stick/pull/272 is needed to fetch the recent nfts

is only the resolver needed for this to be ready?
if yes, we can probably hardcode some nfts and go on?

Imo lets go without resolver :). The query is not something I wanna merge to indexer

nft background no longer there:

reverted changes , it's working again


Retry Attempt without data loss when sink side solr is down during runtime

Need to retry ( without any data loss) based on count from connector config if solr server is down  during runtime.
In my case, Its working perfectly whenboth connector and solr are in running state [Active].
But while only solr server is down, there is no retry process until my data passed to the solr leads to  data loss..
Sample Connnector config
curl -X POST -H "Content-Type: application/json" --data '{
"name": "t1",
"config": {
"tasks.max": "1",
"value.converter": "org.apache.kafka.connect.json.JsonConverter",
"value.converter.schemas.enable": "false",
"key.converter.schemas.enable": "false",
"key.converter": "org.apache.kafka.connect.json.JsonConverter",
"connector.class": "com.github.jcustenborder.kafka.connect.solr.HttpSolrSinkConnector",
"topics": "TRAN",
"solr.queue.size": "100",
"solr.commit.within": "10",
"solr.url": "http://<IP_ADDRESS>:27052/solr/TRAN",
"errors.retry.delay.max.ms":"5000",
"errors.retry.timeout":"600000",
"errors.tolerance":"all",
"errors.log.enable":"true",
"errors.log.include.messages":"false",
"errors.deadletterqueue.topic.name":"DEAD_TRAN",
"errors.deadletterqueue.topic.replication.factor":"1",
"retry.backoff.ms":"1000",
"reconnect.backoff.ms":"5000",
"reconnect.backoff.max.ms":"600000"
}
}' http://localhost:8083/connectors
Error Information

Could Someone please give me the reply or suggestions ?...


Ethereum bridge says "Binance"

This message, If you want to swap your Stellar TFT to Binance Chain TFT, appears on the Ethereum bridge.

f2cb4aff9071dbf18b188e1ffd0d76da372b5016


core: support automatic installation of custom CA certs.

Still some cleanup left, but good enough for feedback. TODOs:

[x] finish description
[x] dedupe some of the distro ca installation code
[x] make ca installation/uninstallation non-fatal and cleaned up in case of failure partial way through
[x] make final call on whether to only selectively enable or just apply to all containers when custom CAs are installed in the engine (at /usr/local/share/ca-certificates)

I'm personally good with this now. These codepaths only get hit when users have a custom engine w/ CA certs installed and I made the install best-effort with cleanup in case of errors. Still open to feedback from others on this though.

[ ] expand test coverage a bit more (more debian/rhel derivatives, cover cleanup in case of install failure)
[ ] test ubuntu gpu image (manually for now since we don't have any automated tests for that yet)
[x] double check umask clearing mentioned here: https://github.com/dagger/dagger/pull/7067#discussion_r1558135886
[x] add more comments to extra gnarly/subtle parts of code

This adds support for automatic installation of custom CA certs to containers. Originally this was gonna just be the first step outlined here but as I started implementing the CA certs part it required enough complication that it seemed best to just implement the full support for automatic CA installation for all containers.
Helpful docs/prior art

https://wiki.archlinux.org/title/Transport_Layer_Security
https://go.dev/src/crypto/x509/root_linux.go
@vito's bass CA autoinstall https://github.com/vito/bass/blob/bf53c90d467e0eaf7125cfbfd005c65349125481/pkg/runtimes/shim/tls.go
https://github.com/containers/podman/issues/2317
https://github.com/flatpak/flatpak/pull/1757
https://github.com/flatpak/flatpak/issues/2721
https://p11-glue.github.io/p11-glue/p11-kit/manual/remoting.html

we don't do this in our implementation, but an interesting possibility for systems/libs using p11 kit

https://minikube.sigs.k8s.io/docs/handbook/untrusted_certs/

https://github.com/kubernetes/minikube/blob/master/pkg/minikube/kubeconfig/settings.go#L85

CA Certs
I learned a lot about the various nuances surrounding CAs as part of this (and I'm sure I've only scratched the surface), braindump below.
CAs are not standardized in any way; the way they are configured depends on a few (sometimes orthogonal) factors:

Consuming software/TLS library

"Generic" - includes openssl and many/most language stdlibs

The closest thing to a generic default is the use of a "bundle" file, which is a single file containing each CA cert that should be trusted along with a dir containing individual files for each of those CAs and symlinks of the hash of those files to the file (created with the c_rehash command)
Typically there will also be a command that can be used to automatically update the bundle file and CA dir when custom CAs are installed in another directory.
The location of the bundle file and other dirs and the name of the command to update CAs depends on the distro. Typically the distro will compile packages like curl with options that point to the right bundle file and/or CA dir to use.

PKCS #11 and p11-kit

Have not gone too deep into this yet, but my limited understanding is PKCS 11 is an attempt at a standard around trust/key-management and includes CA certs. Not all distros/libraries use the standard, but those that do can load CA certs that are configured via the trust or update-ca-trust command.
RHEL-based distros typically use this for example
The trust command has an extract subcommand that creates a layout compatible with the above "generic" setup, for better compatibility with libs that don't use libp11-kit

Other TLS implementations like GnuTLS and LibreSSL do their own thing
The JVM has it's own CA cert store
Browsers typically also have their own CA store
Different versions of a given TLS lib may also have their own CA trust store (i.e. the alpine base image has both /etc/ssl/certs and /etc/ssl1.1/certs

Distro

As mentioned above, all the paths used for each TLS implementation (bundle file, CA dir, etc.) depend on compile-time options set by each distro when building packages
CA functionality is typically implemented as optional packages (rather than as pseudo-required packages like libc) and whether said package is installed in base images varies from distro to distro:

the rhel based base images seem to usually come with ca-certificates fully installed
debian comes without it installed
alpine does not have it installed, but nonetheless does have a base bundle file installed (though no separate cert files)

Implementation Notes

Automatic install

If the user puts certs at /usr/local/share/ca-certificates in their custom engine image, the engine will attempt to install that in all containers (but only if it can identify the distro of the container, fallback is a nop right now)
would like to leave this in, but requires that any failure during install/uninstall can be made non-fatal and cleanup-able. Otherwise will change this to be configurable somehow

Uninstall + cleanup

It's important that we follow the "leave no trace" rule here; any CAs that we autoinstall in a container should be auto-uninstalled so they don't pollute the final container result unexpectedly
This becomes extra complicated in cases where the user's exec actually modifies the state of bundle files/CA dirs, in which case we also want to be very careful to not uninstall anything that the exec actually purposefully modified.

This isn't an obscure case; e.g. if you apk install curl off the base alpine image the ca-certificates package will be installed as a dep and modify the bundle file and CA dir.

Execution location

At first, I implemented all this in the shim process that we currently run as the init of each container. However, this didn't end up working/was not ideal:

If the container user was not root, we would not have permissions to modify certain files/dirs and couldn't run update command like update-ca-certificates
We have a long-term goal of removing the need to inject our own init to each container (https://github.com/dagger/dagger/issues/4989), but this approach buries us even deeper into that dependency

Instead, we had the option to either A) run it exclusively in the part of the shim that executes outside the container or B) implement our own custom buildkit Executor (which runs in the dagger-engine process). I ended up going with the Executor approach for a few reasons:

In the long-term, we can migrate all of the current shim functionality to this Executor. This should result in a much simpler overall architecture since we will be able to avoid all the messy hacks around passing special env vars to the shim process and trying to sneak uncached data into the container via ftp_proxy
As mentioned below, ca cert install/uninstall may need to run actual commands as root inside the container, which is much simpler to implement from the Executor relative to the shim (which would need to have new logic for creating a separate bundle for each command, whereas the Executor already has all that logic)

The biggest annoyance here is that we need to read/write certain files/dirs from the container before/after the container has actually run, which meant either A) creating all the container mounts temporarily (and unmounting them before the container starts to avoid various corner cases around multiple mounts of overlay) or B) a "vfs" approach that maps read/write operations on files/dirs to the correct underlying source mount even though those haven't been mounted yet.

I went with B) because A) is a bit too frought with weird cases and felt like more performance overhead (mount/unmount can be expensive in some cases). This is implement in cmd/engine/cacerts/fs.go as containerFS. The main complication comes from needing to very carefully handle symlinks so that any symlinks in parent dirs of a given path are always resolved correctly to the final mount where they actually point to.

Commands

Have to support running command like update-ca-certificates and similar by actually starting separate container that reuses the same rootfs+mounts as the "actual" user exec container.
This is done from the Executor level so there's no extra layers and overhead is relatively minimal, but still does impose some latency unfortunately. This currently only happens when the engine actually has any custom certs installed, so it's relatively safe and won't slow down all users immediately.
I think we can optimize this in time to skip running these commands in cases where we are sure we can manually implement the same functionality via file/dir operations directly. Went with this approach for now to be extra safe to start.

Distro detection

We need to positively identify which distro is in use because some don't come with a base image containing any bundle file/ca dir/ etc. (e.g. debian), but other packages may still try to check those (we need to manually set those up in these cases).
This requires checking various /etc/ files. Used https://github.com/dekobon/distro-detect/blob/master/linux/distrochecks.go as a reference
Currently only implemented support for alpine/debian-derivatives/rhel-derivatives

Uninstall + cleanup
[...]

Oof, yeah that sounds rough. Is there any way we can isolate "our" changes to a separate layer and then rebase it out somehow? (Haven't looked how it works yet, maybe it's not so bad, just thinking out loud)

Commands
[...]

Is the update-ca-certificates operation cached? i.e. if I repeatedly use the same base image, will it only have to have run once?
Or does it install-then-uninstall on each withExec or something like that? (Guessing that's the case based on the description?)
Would it be too weird to install certs as part of .from and then somehow "drop" the layer at export/publish time? (Building on the previous question)

Uninstall + cleanup
[...]

Oof, yeah that sounds rough. Is there any way we can isolate "our" changes to a separate layer and then rebase it out somehow? (Haven't looked how it works yet, maybe it's not so bad, just thinking out loud)

Not that I am aware of. At the beginning I was trying to use overlay mounts to do that but quickly realized that:

overlay is not always available
we'd need to do some annoying stuff with making sure that we always use the right set of overlay options (which can vary host to host and on the setup, doable but complicated)
it doesn't work for bundle files since those can be re-written with new contents by the user's exec but overlay's granularity is on the whole-file level (whereas we need to look at the "diff" in terms of contents in this case)

Commands
[...]

Is the update-ca-certificates operation cached? i.e. if I repeatedly use the same base image, will it only have to have run once?
Or does it install-then-uninstall on each withExec or something like that? (Guessing that's the case based on the description?)

The update commands have to re-run on each withExec, yeah; but:

they will be cached in the same way the withExec is cached since buildkit's solver doesn't know about any of this
changing the CA certs won't invalidate the cache (mainly matters for remote cache cases)
there's only one layer for the exec overall; we aren't adding more layers each time these update commands run
this will all only get triggered if the user has a custom engine with custom CAs installed, so won't leak out to every user yet

Would it be too weird to install certs as part of .from and then somehow "drop" the layer at export/publish time? (Building on the previous question)

I considered that too but ruled it out since I want to avoid leaving those files around even in the intermediate layers. Leaving them in will still leak them to the layers of the published image (even if we append an extra layer on top cleaning them up).

There's also not really any ways to hack around that since the snapshotter correctly prevents you from modifying layers after they are committed.

I think the best we can do is optimize in follow-ups to not always run these update commands and instead selectively just directly fixup files/dirs in the same way the update command does. We can obviously only do this when we are really really sure we know what the update command is (i.e. probably have to match on distro versions too), so still need to support running these commands in each withExec for other cases.

Just FYI that I was adding more tests last night and did find some cases where we were incorrectly leaving around some parent dirs. This is pretty minor, so should be fine to address in follow up.
I am getting close to finishing the fix there but am mentioning this since apparently my planes wifi is gonna cut off once we are too far into the pacific ocean... so we'll see if I have enough time to fix it before my vacation actually starts. Probably should work out.

I'm gonna take this out of the milestone - given @sipsma is now on holiday, I'd rather we wait to merge this.

I'm gonna take this out of the milestone - given @sipsma is now on holiday, I'd rather we wait to merge this.

Fixed the aforementioned issue of leaving parent dirs and not resetting mtime on files (which results in the diff being non-empty when it should be empty) and added test coverage for all that. Will merge this once green. There's going to be a few more immediate follow ups to add GOPROXY and http proxy support too.

The test failure is https://github.com/dagger/dagger/issues/6111 which is being debugged separately here: https://github.com/dagger/dagger/pull/7128 So gonna merge as is rather than keep rerolling forever


Low Contrast Between Disabled and Regular Text

Just a nit: the contrast between 'muted' and regular text could be higher. Please see this gif for an example:

Totally agree @notfelineit ! Feel free to PR it :)

@mshwery Is anyone working on this?

@sdoan16 go for it!

Closing as this is quite stale (and can be themed)


Multiple calls to FromSql with stored procedure results in errors

Composing on a FromSql call to a stored procedure with another FromSql call results in errors. Calls to Include have already been disabled by throwing in RelationalEntityQueryableExpressionVisitor and it is probably appropriate to throw for additional FromSql query annotations in the same place.
[Fact]
public virtual void From_sql_queryable_with_multiple_stored_procedures()
{
    using (var context = CreateContext())
    {
        var actual
                = (from a in context.Set<MostExpensiveProduct>().FromSql(TenMostExpensiveProductsSproc)
                   from b in context.Set<MostExpensiveProduct>().FromSql(TenMostExpensiveProductsSproc)
                   where a.TenMostExpensiveProducts == b.TenMostExpensiveProducts
                   select new { a, b })
                .ToArray();
            }
}

Multiple stored produce calls produce the following:
---------------------------
Assertion Failed: Abort=Quit, Retry=Debug, Ignore=Continue
---------------------------

   at Microsoft.Data.Entity.Relational.RemappingUntypedValueBufferFactory.CreateValueBuffer(DbDataReader dataReader) in C:\src\aspnet\EntityFramework\src\EntityFramework.Relational\RemappingUntypedValueBufferFactory.cs:line 28

   at Microsoft.Data.Entity.Relational.Query.QueryingEnumerable.Enumerator.MoveNext() in C:\src\aspnet\EntityFramework\src\EntityFramework.Relational\Query\QueryingEnumerable.cs:line 87

   at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()

   at System.Linq.Enumerable.<SelectManyIterator>d__1`2.MoveNext()

   at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()

   at Microsoft.Data.Entity.Query.LinqOperatorProvider.ExceptionInterceptor`1.EnumeratorExceptionInterceptor.MoveNext() in C:\src\aspnet\EntityFramework\src\EntityFramework.Core\Query\LinqOperatorProvider.cs:line 134

   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)

   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)

   at Microsoft.Data.Entity.Relational.Functi......

<truncated>
---------------------------
Abort   Retry   Ignore
---------------------------

[Fact]
public virtual void From_sql_queryable_stored_procedure_and_select()
{
    using (var context = CreateContext())
    {
        var actual
            = (from mep in context.Set<MostExpensiveProduct>().FromSql(TenMostExpensiveProductsSproc)
                from p in context.Set<Product>().FromSql("SELECT * FROM Products")
                where mep.TenMostExpensiveProducts == p.ProductName
                select new { mep, p })
                .ToArray();
    }
}

Stored procedure followed by a select produces the following:
Test 'Microsoft.Data.Entity.SqlServer.FunctionalTests.FromSqlSprocQuerySqlServerTest.From_sql_queryable_select_and_stored_procedure' failed:
	System.InvalidOperationException : The required column 'ProductID' was not present in the results of a 'FromSql' operation.
	Query\Sql\RawSqlQueryGenerator.cs(104,0): at Microsoft.Data.Entity.Relational.Query.Sql.RawSqlQueryGenerator.CreateValueBufferFactory(IRelationalValueBufferFactoryFactory relationalValueBufferFactoryFactory, DbDataReader dataReader)
	Query\CommandBuilder.cs(77,0): at Microsoft.Data.Entity.Relational.Query.CommandBuilder.<>c__DisplayClass7_0.<NotifyReaderCreated>b__0()
	at System.Threading.LazyInitializer.EnsureInitializedCore[T](T& target, Func`1 valueFactory)
	at System.Threading.LazyInitializer.EnsureInitialized[T](T& target, Func`1 valueFactory)
	Query\CommandBuilder.cs(74,0): at Microsoft.Data.Entity.Relational.Query.CommandBuilder.NotifyReaderCreated(DbDataReader dataReader)
	Query\QueryingEnumerable.cs(81,0): at Microsoft.Data.Entity.Relational.Query.QueryingEnumerable.Enumerator.MoveNext()
	at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
	at System.Linq.Enumerable.<SelectManyIterator>d__1`2.MoveNext()
	at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
	Query\LinqOperatorProvider.cs(144,0): at Microsoft.Data.Entity.Query.LinqOperatorProvider.ExceptionInterceptor`1.EnumeratorExceptionInterceptor.MoveNext()
	at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
	at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
	FromSqlSprocQueryTestBase.cs(22,0): at Microsoft.Data.Entity.Relational.FunctionalTests.FromSqlSprocQueryTestBase`1.From_sql_queryable_stored_procedure_and_select()
	FromSqlSprocQuerySqlServerTest.cs(22,0): at Microsoft.Data.Entity.SqlServer.FunctionalTests.FromSqlSprocQuerySqlServerTest.From_sql_queryable_select_and_stored_procedure()

[Fact]
public virtual void From_sql_queryable_select_and_stored_procedure()
{
    using (var context = CreateContext())
    {
        var actual
            = (from p in context.Set<Product>().FromSql("SELECT * FROM Products")
                from mep in context.Set<MostExpensiveProduct>().FromSql(TenMostExpensiveProductsSproc)
                where mep.TenMostExpensiveProducts == p.ProductName
                select new { mep, p })
                .ToArray();
    }
}

Select followed by a stored procedure produces the following:
Test 'Microsoft.Data.Entity.SqlServer.FunctionalTests.FromSqlSprocQuerySqlServerTest.From_sql_queryable_select_and_stored_procedure' failed:
	System.Data.SqlClient.SqlException : Incorrect syntax near ')'.
	at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
	at System.Data.SqlClient.SqlInternalConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
	at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)
	at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
	at System.Data.SqlClient.SqlDataReader.TryConsumeMetaData()
	at System.Data.SqlClient.SqlDataReader.get_MetaData()
	at System.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString)
	at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async, Int32 timeout, Task& task, Boolean asyncWrite, SqlDataReader ds, Boolean describeParameterEncryptionRequest)
	at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method, TaskCompletionSource`1 completion, Int32 timeout, Task& task, Boolean asyncWrite)
	at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method)
	at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior, String method)
	at System.Data.SqlClient.SqlCommand.ExecuteDbDataReader(CommandBehavior behavior)
	at System.Data.Common.DbCommand.ExecuteReader()
	Query\QueryingEnumerable.cs(79,0): at Microsoft.Data.Entity.Relational.Query.QueryingEnumerable.Enumerator.MoveNext()
	at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
	at System.Linq.Enumerable.<SelectManyIterator>d__1`2.MoveNext()
	at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
	Query\LinqOperatorProvider.cs(144,0): at Microsoft.Data.Entity.Query.LinqOperatorProvider.ExceptionInterceptor`1.EnumeratorExceptionInterceptor.MoveNext()
	at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
	at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
	FromSqlSprocQueryTestBase.cs(47,0): at Microsoft.Data.Entity.Relational.FunctionalTests.FromSqlSprocQueryTestBase`1.From_sql_queryable_select_and_stored_procedure()
	FromSqlSprocQuerySqlServerTest.cs(22,0): at Microsoft.Data.Entity.SqlServer.FunctionalTests.FromSqlSprocQuerySqlServerTest.From_sql_queryable_select_and_stored_procedure()

Appears to be fixed by other changes in Query, added tests to catch any regressions in this area.

I don't now if anybody will see this, but I'm seeing this error and I'm not exactly sure why this is happening.  I'm sending in a few User Defined Table Types (with the help of NReco.Data) and as far as I can tell that is working, but when the data is returned I see this error:  "Exception thrown: 'System.InvalidOperationException' in Microsoft.EntityFrameworkCore.dll
Additional information: The required column 'InventoryCapacityGroupSecondaryId' was not present in the results of a 'FromSql' operation."
That column is the first column in my resulting SELECT statement at the end of the stored procedure.  That is also the first property in my data entity class.  I wasn't sure how to contact anybody or post something new?  Maybe the UDTT are affecting the results.

@SpilledMilkCOM this issue is closed, please open a new issue with details of the problem you are encountering.

I don't now if anybody will see this, but I'm seeing this error and I'm not exactly sure why this is happening. I'm sending in a few User Defined Table Types (with the help of NReco.Data) and as far as I can tell that is working, but when the data is returned I see this error: "Exception thrown: 'System.InvalidOperationException' in Microsoft.EntityFrameworkCore.dll
Additional information: The required column 'InventoryCapacityGroupSecondaryId' was not present in the results of a 'FromSql' operation."
That column is the first column in my resulting SELECT statement at the end of the stored procedure. That is also the first property in my data entity class. I wasn't sure how to contact anybody or post something new? Maybe the UDTT are affecting the results.

Its saying the said primary key is not present in the list of select column, if you could add it for the sake of it...I had a weird situation, the count by group, so I could not add Pkey, stuck at that.:(


Map filter and map functions

Proposal
Add common "functional" functions to iterable objects SASS.
There are several functions of this class that could be added and would provide significant benefit. E.g.

[ ] map
[ ] filter
[ ] reduce

Use Case
When writing sass, I find that I spend a significant amount of time writing things that look like:
$map: (test: 100, test: 200);
$newMap: ();
@each $key, $value in $map {
    $newMap: map-merge(
        $newMap,
        ($key: (someFunction($value)))
    );
}

This common structure is often known as "map" in many functional languages.
In an ideal world I'd write something like:
$map: (test: 100, test: 200);
@function mapFunction ($key, $value){
 @return ($key: someFunction($value));
}
$newMap: map($map, mapFunction);

Side notes
There are some odd language semantics here (lambdas), that I've not yet seen in SASS, but may be possible (first class functions).
Additionally, if SASS could support anonymous lambdas (probably difficult), that may also be cool.
Edge cases
There's also probably some edge cases around providing values that are not args to the callback as values inside the callback function.

I'm going to mark this as a duplicate of https://github.com/sass/sass/issues/472. Higher-order functions like map() and filter() don't really make sense without the ability to write anonymous functions, and if we added anonymous functions we'd definitely add library functions that supported them.
This is difficult for a number of reasons, though. Anonymous functions are syntactically and semantically complex, especially for a userbase that is often coming from a pure CSS background and unfamiliar with more general-purpose programming languages. At the same time, because Sass is not general-purpose, the set of circumstances where these features are applicable is narrower than in other languages. It's not a priori clear to me that this feature would pull its weight, especially if we consider alternatives like a dedicated list comprehension syntax.


Allow to run filebeat pods as privileged

This is required to run filebeat on OpenShift

/assign @mgoodness

guys... rebase and merge please ... handy !

@rendhalver could you please merge this?

@rendhalver is there something I can do to have this PR merged?

Hi. Can someone please merge this PR if there is no further issue?
It is very small and is necessary to use this chart on Openshift!
@rendhalver ?

Rebased. Again...

/approve
/lgtm


nixos/prometheus-exporters/openvpn: init

Motivation for this change
Allow monitoring openvpn
Things done

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@ofborg test prometheus-exporters


We should add a standard comment block to each Benchmark to detail exactly how it publishes data.

Today we have a schema does that is not broadly shared, and reading the code to figure of the metrics published is slow.
We should create a comment block in each benchmark file detailing how it publishes.  In particular we should detail:
test - this is the name of the bechmark
owner - who is running the numbers
labels - This data is a '|' separate list of extra meta data to understand the data point.  There are some common labels like 'zone' and 'machine_type'.  We should detail all of them for the given benchmark.
metric - What is being reported
units - Units of the metric.  There is a pretty standard list here we should not expand unless really needed.
value - the number being reported.

Can we publish the result data also in HTML format in addition to json (perfkitbenchmarker_results.json), similar to side-by-side tool :-)?

Would you mind opening a bug?
On Fri, Mar 20, 2015 at 4:18 PM, Hung<EMAIL_ADDRESS>wrote:

Can we publish the result data also in HTML format in addition to json
(perfkitbenchmarker_results.json), similar to side-by-side tool :-)?
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/issues/123#issuecomment-84189261
.

--
Connor McCoy | Software Engineer |<EMAIL_ADDRESS>|<PHONE_NUMBER>


Write list of e-Services

Similar to List of basic services

@jnehring please have a look to http://api-dev.freme-project.eu/doc/knowledge-base/freme-for-sysadmins/e-services.html

Thank you this is a great start. I will take over from here.

I added some information to the article. This issue is finished.


Replace --auto-bump with --bump [ patch | minor | major ]

Auto-bump for delivery review is really handy! Would be great if it could handle other version point releases
Thinking that --auto-bump flag could be deprecated for a --bump flag that could be provided with or without args. Without an arg, it would default to patch type, but minor and major could also be specified.

Created ticket here, as it didn't seem possible yet with clap-rs:
https://github.com/kbknapp/clap-rs/issues/892

@patcon Thank you so much for your feedback! The auto-bump mechanism is meant to be a helper for quick simple changes, but if the change requires a minor or major version bump, the believe the user should be in charge of modifying the metadata.rb manually.
I'm closing this issue, but if you feel like this is something we need to code I would encourage you to give this feedback at: https://feedback.chef.io/ where more users can vote for ideas and our Product Team can visualize them and move them to in development. Thank one more time.


1.29.0 "files to exclude" in Search not working

Just updated to 1.29.0 and the "files to exclude" in the search bar isn't working.
Before the update I could just put in a folder name: ./app and this would exclude the app folder, since the update this isn't working, and is being ignored.
Appears that if I select the "Use Legacy Search" option, then this fixes it. However, this is stated as being legacy/deprecated so would appreciate a better solution.
I am using Mac macOS Mojave 10.14, connecting to a network drive running Linux Ubuntu 16.04
Thanks, Adz

I think app should still work (although it will exclude **/app/**)

Hi, yes putting in just app works, however, if I want to drill down any further app/test then this would stop this from working, and obviously, I want it to trigger from the root of the project folder I'm in, thus the ./
Thanks for looking at this :-)

app/test should also still work (as **/app/test/**) if I understand you correctly


Swift 5 version?

Hi there, where is the lib sources? the master and swift-5 branches are empty...

code is pushed to master branch, and Rx version and document for swift 5 is on the way.


[To unblock another team] removing tags and location as they are already defined in CommonTracke…

…dResource
ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.

[ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).

[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)

[ ] Update existing version to fix OpenAPI spec quality issues in S360.

[ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).

[x] Other, please clarify:

Another team sent us this issue they were facing while generating their sdk. Hence, removing the duplicate properties: error   | PreCheck/PropertyRedeclaration | Schema 'VerifierWorkspace' has a property 'tags' that is conflicting with a property in the parent schema 'CommonTrackedResource' differs more than just description : [additionalProperties.$ref => '#/components/schemas/schemas:102',x-ms-mutability => '']

and I see that the ARM spec it was trying to parse had duplicated properties  "tags" and "location".
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.

This will cause breaking change. Please  follow the steps here
"The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch."

Hi @ms-bogdan-rotaru could you please help in reviewing this. I already have a merged PR https://github.com/Azure/azure-rest-api-specs/pull/29998 and due to location and tags being duplicated it's causing Declarative framework and Default UX sdk generation issues.
The changes are being flagged as breaking changes but we aren't actually removing them only removing duplicates


fixing TIR in microfacet_evaluate() (regression from<PHONE_NUMBER>)

microfacet_evaluate() produces black/zero for TIR, which seems to be a regression from<PHONE_NUMBER> (ie previous versions worked fine).  This commit fixes it.

Thank you very much for your report. We have fixed the issue in our internal sources and will release the fix with an upcoming version of the MDL-SDK.


[Jtreg/FFI] Enable test suites in JDK22+

The change enables the FFI specific test suites in JDK22+
given the issue with the heap arguments is resolved via
https://github.com/eclipse-openj9/openj9/pull/18930.
Signed-off-by: ChengJin01<EMAIL_ADDRESS>

By removed the disabled issue, I'd like to know how many issues (newly added for JDK22+) left to be addressed in JDK22+ except the heap argument related PR at https://github.com/eclipse-openj9/openj9/pull/18930.

Reviewer: @llxia
FYI: @ShelleyLambert, @tajila, @pshipton


device reporting r0.0 revision

Hello,
my device is reporting an incorrect hardware revision.
Detected a Cynthion device!
        Hardware: Cynthion r0.0
        Serial number: BGZNYS2MGJJVCIBAEA3C6HAP74
        Firmware version: v1.0.6
        USB API version: 1.1
        Flash UID: 264e27df30c460de

This seems to lead to the flasher not finding the right bitstream causing update to not work.

Can you show us the output of dmesg when the device is first connected and after pressing PROGRAM?

[136761.265542] usb 2-1: new full-speed USB device number 31 using xhci_hcd
[136761.415656] usb 2-1: New USB device found, idVendor=1d50, idProduct=615c, bcdDevice= 0.00
[136761.415662] usb 2-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[136761.415664] usb 2-1: Product: Cynthion Apollo Debugger
[136761.415666] usb 2-1: Manufacturer: Great Scott Gadgets
[136761.415667] usb 2-1: SerialNumber: BGZNYS2MGJJVCIBAEA3C6HAP74
[136761.418767] cdc_acm 2-1:1.0: ttyACM0: USB ACM device

No change in dmesg when pressing program.
As far as LEDs on connection A,B,D and 0-5 are lit, D goes out a moment later, and B turns off when program is pressed
3 and 4 are pretty dim so I'm not 100 percent sure it's on

Thank you! LEDs 0-5 are normally in that state (dim but with some brighter than others) when the FPGA is offline (which is indicated by LED B being off).
It looks like the Apollo firmware on your Cynthion's MCU is generally working, but for some reason it is unable to detect the board revision.
Can you please try installing this experimental firmware?: https://github.com/mossmann/apollo/actions/runs/9940795202/artifacts/1702047943
To install, extract firmware.bin from firmware-binaries.zip and then do:
fwup-util --device 1d50:615c firmware.bin

Alternatively, if you would like to build the firmware from source, you can use this branch: https://github.com/mossmann/apollo/tree/adc-debug
This experimental firmware hard-codes the board revision to r1.4 and also provides a method to retrieve the ADC value that is normally used to detect the board revision.

Detected a Cynthion device!
	Hardware: Cynthion r1.4
	Serial number: BGZNYS2MGJJVCIBAEA3C6HAP74
	Firmware version: 9fc364c
	USB API version: 1.1
	Flash UID:<PHONE_NUMBER>000000

definitely promising! I assume that's not the fix though?

I think that firmware should work fine for you. However, things will likely break again the next time you do a firmware update. I suspect that there is hardware failure preventing automatic hardware revision detection. Can you please show me the output of this test program?
#!/usr/bin/env python3

from apollo_fpga import ApolloDebugger
import usb

d=ApolloDebugger(force_offline=True)
reading = d.device.ctrl_transfer(usb.ENDPOINT_IN | usb.RECIP_DEVICE | usb.TYPE_VENDOR, 0xff, 0, 0, 2)
print((reading[0] << 8) + reading[1])

I'm running to a very similar issue. I was not able to get the cynthion tool to connect and the USB device is at /dev/ttyACM0 instead of /dev/ttyUSB. Updating to the experimental firmware does allow the cynthion tool to connect and appears to have resolved the issue, but I am still seeing the USB device at /dev/ttyACM0.

Detected a Cynthion device!
Hardware: Cynthion r1.4
Serial number: 53BTZKKMGJJVCIBAEA3DMHYO74
Firmware version: v1.0.6
USB API version: 1.1
Flash UID:<PHONE_NUMBER>000000

dmesg output

[ 6728.285217] usb 1-5.4.1: USB disconnect, device number 22
[ 6728.538070] usb 1-5.4.1: new full-speed USB device number 23 using xhci_hcd
[ 6728.670095] usb 1-5.4.1: New USB device found, idVendor=1d50, idProduct=615c, bcdDevice= 1.04
[ 6728.670112] usb 1-5.4.1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[ 6728.670117] usb 1-5.4.1: Product: Cynthion Apollo Debugger
[ 6728.670121] usb 1-5.4.1: Manufacturer: Great Scott Gadgets
[ 6728.670124] usb 1-5.4.1: SerialNumber: 53BTZKKMGJJVCIBAEA3DMHYO74
[ 6728.679069] cdc_acm 1-5.4.1:1.0: ttyACM0: USB ACM device

output of the test python script
3235

@ConceitedCode Can you please run cynthion update --mcu-firmware and then show us the output of cynthion info --force-offline?

Sure thing!
(env) cam@lotus:~/cynthion$ cynthion update --mcu-firmware
Updating device firmware with 13816 bytes...
Operation complete!
(env) cam@lotus:~/cynthion$ cynthion info --force-offline
Detected a Cynthion device!
        Hardware: Cynthion r1.4
        Serial number: 53BTZKKMGJJVCIBAEA3DMHYO74
        Firmware version: v1.0.6
        USB API version: 1.1
        Flash UID:<PHONE_NUMBER>000000

@ConceitedCode That looks as expected. Hardware version detection is working on your board. What problem are you having?

I wasn't able to connect using the cynthion cli tool until I flashed the experimental firmware you provided above. It showed a "backend not available" error when running any commands.
Updating to the experimental firmware you provided above resolved the immediate issue.  Just making sure it won't have a problem if I update the board later like you mentioned above 🙂
Side note - Is my flash UID supposed to be all 0's?

That sounds like https://github.com/greatscottgadgets/cynthion/issues/136, not like this issue. I don't think the experimental firmware itself had anything to do with solving "backend not available", though perhaps something you did along the way affected pyusb's ability to find libusb.
The flash UID is a known bug: https://github.com/greatscottgadgets/cynthion/issues/125

I think that firmware should work fine for you. However, things will likely break again the next time you do a firmware update. I suspect that there is hardware failure preventing automatic hardware revision detection. Can you please show me the output of this test program?
#!/usr/bin/env python3
#
# for use with experimenatal firmware only

from apollo_fpga import ApolloDebugger
import usb

d=ApolloDebugger(force_offline=True)
reading = d.device.ctrl_transfer(usb.ENDPOINT_IN | usb.RECIP_DEVICE | usb.TYPE_VENDOR, 0xff, 0, 0, 2)
print((reading[0] << 8) + reading[1])

3266

Thank you! That is great information! Those numbers are only slightly outside the expected range, so we may be able to fix this in firmware, though we would also need to widen the designed range in future revisions.

@nsluhrs This should be fixed for you in the next release of Apollo and Cynthion.


Ats update ci/cd with new example

@zwartd Please refork development so you are not sending old commits with future PRs.


Provide deep-clean target to remove folders git clean cannot

use rimraf instead of noisier, slower robocopy-delete
_rimraf.shade is modeled after bower.shade

:shipit:

Commit 3de5db0c78af819d6834336a5dfe1ec137adaf1f


ports in codespace

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.80.0 (Universal)
OS Version: Darwin x64 20.6.0,  macOS Big Sure 11.7.8

Steps to Reproduce:

no ports on panel in codespace

/gifplease

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

Many thank for respond.  Hope gif is in.

@PavelPrist thanks for the gif. In your gif, you don't appear to be connected to a Codespace. The remote indicator (the blue item in the far left of the status bar) doesn't show that you're connected to a Codespace.

can you help me understand how to connect to codespace?

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


Document correlogram subsampling in app - and add opts for level of subsampling

Subsampling for correlograms is now implemented for sortingview >= 0.2.30. Perhaps later we can have a toggle option for this. Also we'll want to indicate somewhere that the histograms are subsampled.
Originally posted by @magland in https://github.com/magland/sortingview/issues/31#issuecomment-883294526

@jsoules I was thinking we need some sort of asterisk in the correlograms view that tells the user that subsampling has occurred. I was thinking a question mark icon in the corner that yields a popup window that has that info.
For an example of this type of thing, see: https://github.com/magland/sortingview/blob/f111a7f7b704e9006482624bd5f1ee5b06daf797/src/labbox-react/HomePage/ChannelSection.tsx#L32

Fixed in PR #51.


Can't install FinRL

I got following issue during install finrl.
ERROR: Package 'finrl' requires a different Python: 3.10.10 not in '<3.9,>=3.7'
I have already git clone code and  open Go to FinRL Folder, then py -m pip install .
Please help me.
Thank you for your kind attention.

Potentially because of https://github.com/AI4Finance-Foundation/FinRL/blob/master/pyproject.toml (Line 27)?

pls do not use pip intall.
git clone, and move finrl to your local dir

Colab updated it's python version to Python 3.9.16, my runtime was interrupted sometime at noon today. I tried a couple of methods to revert the python version back to 3.8 but have no success so far (Sad).

Thanks for your advice.
I didn't install finrl in Global python, but I successfully installed in anaconda.
-Update pyproject.toml as following:
python = "^3.9" of line 28.

some developers said that, python 3.9 is not compatible with some libs. therefore, we set python < 3.9.

But you know, python 3.10 is the best version for machine learning?

The fix works for Google Colab for the Stock_NeurIPS2018 example.
There is, however, an error:

cvxpy 1.2.3 requires setuptools<=64.0.2, but you have setuptools 67.6.0 which is incompatible.

--> Add requirement
cvxpy >=1.3.0 (see https://github.com/cvxpy/cvxpy/releases/tag/v1.3.0; support up to Python 3.11)

I'm able to install FinRL on colab again today!

hi! Could you help with my installing on Colab? It was ok on Mar 23rd, but after that date i see the error. Thanks a lot for your help.
!pip install git+https://github.com/AI4Finance-Foundation/FinRL.git
error: subprocess-exited-with-error
× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
Preparing metadata (setup.py) ... error
error: metadata-generation-failed

I have the same error msg on Colab and don’t know how to fix it yet.
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> See above for output.

  note: This error originates from a subprocess, and is likely not a problem with pip.
  Preparing metadata (setup.py) ... error
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

I tried, and got the same error on Colab. I looked at the instructions for how to use finrl on Colab. They're pretty bad, tbh. I created a notebook that appears to work. The tricks:

Use conda on Colab.
Install the requisite .debs
Manually install wrds, because finrl doesn't list it as a dependency

I tried, and got the same error on Colab. I looked at the instructions for how to use finrl on Colab. They're pretty bad, tbh. I created a notebook that appears to work. The tricks:

Use conda on Colab.
Install the requisite .debs
Manually install wrds, because finrl doesn't list it as a dependency

thanks @ndronen! Your work around solved the error!

thanks for your effort @ndronen .
some libs may be updated, so that some errors are raised, and we have to update accordingly every several months.
we will update the notebooks later

fixed.
pls try again

hmmm. I still get following error @zhumingpassional :
Collecting gym>=0.17
Downloading gym-0.21.0.tar.gz (1.5 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.5/1.5 MB 77.5 MB/s eta 0:00:00
error: subprocess-exited-with-error
× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
Preparing metadata (setup.py) ... error
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.

@Kadokoda
which notebook did you run?

hi @zhumingpassional! i was not update the script. Now it's running ok but the session crash so I can't run All cells, I need
to Part 1 then other parts separately
Here is the message of Part 1: Install FinRL steps:
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
WARNING: Upgrading ipython, ipykernel, tornado, prompt-toolkit or pyzmq can
cause your runtime to repeatedly crash or behave in unexpected ways and is not
recommended. If your runtime won't connect or execute code, you can reset it
with "Disconnect and delete runtime" from the "Runtime" menu.
WARNING: prompt-toolkit > 1.0.16 is incompatible with IPython < 7.0
WARNING: The following packages were previously imported in this runtime:
[cycler,dateutil,google,importlib_resources,kiwisolver,matplotlib,matplotlib_inline,mpl_toolkits,pexpect,pickleshare,prompt_toolkit,psutil,pygments,six,wcwidth,zipp]
Run "pip install -U ipython" before restarting to avoid repeated crashes.

I guess the python version raises the error.
if you use colab, pls refer to the installing instruction in https://github.com/AI4Finance-Foundation/FinRL/blob/master/examples/Stock_NeurIPS2018_SB3.ipynb

thanks a lot @zhumingpassional! it's working perfectly!


Add the type to the name of the variable for base class variables.

This is required for VSCode because it makes sure all variables are unique
by the name.
/cc @jacdavis @gregg-miskelly @chuckries

Hi @edumunoz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

 If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

This seems fine. I don't think we really need to special case clrdbg. :+1:


Height is not controllable

The image should adjust itself according to the screen and the browsers navigation bar

Actual behaviour: the captions gets cut in mobile screen

I will be very thankful to anyone for help. Really got stuck. no external styling is working and not able to override the internal styling

@nidhi-tandon v1 will allow consumers to replace any component, please see #199


Add ls -l in node catalogs ls

This is a Training PR demo of catalog. It add ls -l result in node catalogs.

:+1:


Create sv.ts

Swedish translation if wanted.

LGTM, but it'd be nice if you could add an entry for your translation into languages/translations.json. This way it'll appear in translation credits screen and appropriate settings menu.

Done! Hope it's ok.  :)

Looks great, thanks for the contribution.

Thank you, for making my Jolla so great.  :+1: