Cogljj/rook config

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #1034
What are the significant changes in functionality due to this change request?
Adds the ability for rook to have a configuration file.

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Job Test Ubuntu 16 on 680ca6b : invalidated by @joshua-cogliati-inl
probably machine error

The modifications are good to me.
@joshua-cogliati-inl is it worth to add the config file in RAVEN for testing the feature?

The modifications are good to me.
@joshua-cogliati-inl is it worth to add the config file in RAVEN for testing the feature?

Yes, and I moved qsub to the config file for RAVEN.

Job Test CentOS 6 on 7bc2c0b : invalidated by @joshua-cogliati-inl
VARMA

PR can be approved.
CheckList passed...


Add uic and rcc entry points

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

I remember we manually had to move scripts around for pyside2.

I also noticed that the script did little other than to call
uic -g python

Most of the script tried to work around issues of finding the binary when shipped within python's virtual environments.

@hmaarrfk Thanks for the hints. I managed to get something working on linux and osx, but the build is failing for some reasons in windows and aarch64. These failures does seem to be related to my modifications.

Does or "does not"?

Could you try rebase ? the clang pinning and patch should not be necessary anymore

@jschueller I was trying to rebase but it seems you are working on it in #182

yes, I included your work


Cast window to a new type (instead of extending it) to prevent collisions.

This PR changes the env.d.ts files that extend the Window interface to create a new interface instead and cast window to that type whenever anything needs to read one of these extra properties. This prevents the types for the polyfill interfaces from conflicting internally. I've also removed the ShadowRoot property because it's already part of Window.

I restarted the tests because the IE11 ones had more failures than the expected "timed out at the very end" problem.

The new ones were also timeouts, but I'm not sure if they were newly introduced here somehow or if it was just a bad run.


Upgraded to latest available version of raven-logback.

Sentry has recently started to display a friendly "This event was reported with an old version of the java SDK." message alongside events.  Hopefully this update will make those messages stop.

Thanks for the pull request @Sounie, i've noticed those messages too but hadn't gotten around to updating the dependency just yet. This is nitpicky, but would you mind updating the commit message to something like "upgrade raven-logback dependency to 8.x..." Thanks!

I see what you mean, I'll drop this PR and submit another one with the commit message worded differently.


"rg" is consuming MAX CPU cycles

Type: Bug
WIth this latest update, I am experiencing an issue where, after launching VSC and attaching to WSL - a program called "rg" gets started and is consuming > 900% CPU (I have a 14C/20T Intel i7 Part) - this basically "kills" the setup.
I suspect that this is tied to one of the parsers that is installed as an extension.  I have modified the setup to ignore certain files in our setup (build artifacts) but this continues  hog the system.
Thank you for your assistance.

Upon starting VSCode, I get this process which maxes out the CPU like op wrote:
/Applications/VSCodium.app/Contents/Resources/app/node_modules/@vscode/ripgrep/bin/rg --files --hidden --case-sensitive --no-require-git -g /[tj]sconfig.json -g !**/.git -g !**/.svn -g !**/.hg -g !**/CVS -g !**/.DS_Store -g !**/Thumbs.db -g
Why doesn’t VSCode use the native ripgrep binary which is present in my PATH? Maybe that would be more efficient / avoid the issue? Or related to this issue?
Probably related:

#193927
#225767

See https://github.com/microsoft/vscode/wiki/Search-Issues for troubleshooting tips

See https://github.com/microsoft/vscode/wiki/Search-Issues for troubleshooting tips

Cheers! The symlinks setting did the trick for me.

Version: 1.95.3
Commit: f1a4fb101478ce6ec82fe9627c43efbf9e98c813
Date: 2024-11-13T14:50:04.152Z
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Code/1.95.3 Chrome/128.0.6613.186 Electron/32.2.1 Safari/537.36
I'm experiencing the same thing, and it happens on npm install / yarn install / pnpm install with all extensions disabled and all settings reset.


chocolatey: Bump Headlamp version to 0.23.2

Signed-off-by: Joaquim Rocha<EMAIL_ADDRESS>

I have tested it already and pushed to chocolatey.org.


Consider supporting list sessions feature

https://github.com/Azure/azure-service-bus/issues/275

Closing in favor of https://github.com/Azure/azure-sdk-for-net/issues/20569


Implement the incentive layer and client.

This is our code from the internal Truebit hackathon. It specifically does the following:

Implement ClaimManager and DepositsManager contracts.
Integrate ScryptVerifier contract with ClaimManager.
Make tests more modular.
Implement the client.
Write truffle tests.

I've created issues for outstanding questions (https://github.com/TrueBitFoundation/scrypt-interactive/issues/22, https://github.com/TrueBitFoundation/scrypt-interactive/issues/23).
Wanted to merge back into the main repo, before we continue with fixes and refinement.
The test_manual/ tests are broken right now, due to changing web3.js dependency to it's latest stable release, and needing to increase time-outs in geth. We will investigate these as immediate next steps.

I just browsed the pull request, perhaps we should set up a call to go through it in detail.

@chriseth – sounds like a plan. Today / tomorrow are a bit hectic, do you want to try for early next week? Maybe after our dev call on Monday? Or maybe share a few times that work for you, and we can pick one. :)
That will give us some time to investigate changing geth's timeout to make the verification tests work as well.
cc @hswick @shrugs

@chriseth – following up on today's meeting, we did two things:

wrote code for small changes as discussed.
created issues for larger changes.

Let me / @hswick / @Shrugs know if you need clarification on anything!

Hey @chriseth – are we ready to merge this into the main repo? We are beginning to work through the issues, and could add them in as new PRs on the main repo. :)
cc @hswick @Shrugs


Add support for the "allowed user fields" API schema

This adds support for REST API calls to the alloweduserfield endpoints, and adds a helper method for looking up an allowed user field by name.
We'll use this to support syncing ControlShift member IDs into a custom user field.

Build failures are because of bundler nonsense. Looking into fixing it.


Confusing sentence

The section "Set and check flow output" starts out with "When the flow is complicated,..."
This doesn't seem right....  :)

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b9fa5b9a-4f3b-65eb-619a-439502dbea4e
Version Independent ID: 106ffc2f-679e-83c8-c440-407f5e5fb499
Content: Get started in Prompt flow (preview) - Azure Machine Learning
Content Source: articles/machine-learning/prompt-flow/get-started-prompt-flow.md
Service: machine-learning
Sub-service: core
GitHub Login: @ishinzhang
Microsoft Alias: yijunzhang

@bstollnitz
Thanks for your feedback! We will investigate and update as appropriate.

@bstollnitz  Thx for your feedback to prompt flow. I submitted a pr to fix this. You will see the updated doc soon.

@bstollnitz
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


RuntimeError: Resource temporarily unavailable after start and end of ~350 clients

Hi,
I encountered "RuntimeError: Resource temporarily unavailable" for the line initializing a new client client = carla.Client('localhost', 2000) after I start, run simulation, and end ~350 clients sequentially on the same carla server.
I noticed that the opened files by the carla server process will always increase by 2 after each start and end of one client. Meanwhile, TCP connection will increase by 1 each time. Thus, these numbers keep going up as I run more client sessions.
It seems that they are not used after the end of corresponding clients but are not destroyed properly. Is there a way to manually release these resources? Is it possible to run more client sessions (>350) sequentially on the same server?
Thanks!

@bernatx could you please look into this issue?


build.sh only works on ubuntu

not on debian

just cd src ; make -f makefile.unix like normal works though ;)

Thanks buzztiaan!


Object Scaling

Object that are supposed to be bigger are bigger now.
(This has not been tested however)

no more 19 dollar fortnite card??????????


Include replica of iMessage curved lines connecting replies

Hi @ekazaev
I have tried to implement the solution you pointed out in the last issue, but without any good outcome.
Below I will add screenshot of how I have went on to implement the solution and results.
New variables in MainContainerView class:

setupSubviews()

updateContainerView() & resetContainerView()

CurvedLineView

Data source createTextCell (here I check if message is a reply so that curve line view can be created or not)

Results:
It seems like the width of the line is just off, even if I try get the width of the bubble view then subtract it from the screen size so that I get get the remaining width that the bubble view is not occupying. When I scroll, weird behaviours start occurring with the curve line, it starts changing in width and height size, affect the bubble view size as well. The weird behaviours make me think if reuse of cells without clearing the curved line is the cause, but not sure.
Unexpected result marked with red, expected result marked with blue.

Please help. Thanks.

@ElrB Unfortunately I cant write code for you. I can give you only some directions. It looks like you are on the right path but I cant sit and debug your code. I am sorry.
If I can suggest something: take constraints from the layout like TextMessageView does
    func apply(_ layoutAttributes: ChatLayoutAttributes) {
        viewPortWidth = layoutAttributes.layoutFrame.width
        setupSize()
    }

Pass it somehow (create a multiple delegate listener for example) and pass it up to the all views that might be interested. In your example It is unclear why do you set up width to 310. Iphones have different screen sizes.
Here it seems that the cell is not handling reuse properly. Because there is no reply in the previous cell.
https://private-user-images.githubusercontent.com/66596779/303429475-589b45fc-a51e-4977-8ef9-4abdded7a26e.JPG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDc0MjQ3NzYsIm5iZiI6MTcwNzQyNDQ3NiwicGF0aCI6Ii82NjU5Njc3OS8zMDM0Mjk0NzUtNTg5YjQ1ZmMtYTUxZS00OTc3LThlZjktNGFiZGRlZDdhMjZlLkpQRz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjA4VDIwMzQzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFmYTVkMDI1NDY2MmRiZmIyNjYxZGZhOWVjMGQ2ZGJkMGZkMDQyZWMwZmE2YmNiNTk3ODc3NGY3YWUwMTE0MzAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.l8RSAVO-inFM2c1qkJrPBtzVNPR-OAm6QsiD7K2diyU
I see you decided not to move the reply bubble into the message bubble. That means that you also need to pass somehow the information where is the reply in the previous cell is positioned and act accordingly. I am also not sure how you are going to handle the situation is the reply bubble is short. Even if the curve will work correctly it will point into the void, not the best visual decision imho.
That is as much as I can help you unfortunately. It hard to look at the code without an ability to put a breakpoint and check the constraints and values.
Keep trying.
Best of luck.

Hi @ekazaev
I will leave this route, and take the WhatsApp reply style.
I just have one question or seek your last help then we can close the issue.
Right now I see bubble view is create like; let bubbleView = cell.customView.customView.customView in the createCell methods.
How can create a BezierMaskedView (message bubble view) without having to dequeue/initialise a cell?
Thanks.

@ElrB

How can I create a BezierMaskedView (message bubble view) without having to dequeue/initialise a cell?

Do you mean like this?
let view =  BezierMaskedView<UIView>(frame: CGRect(origin: .zero, size: .init(width: 300, height: 50)))
view.customView.backgroundColor = .green

The second I do not understand. I need to see the code to try. Fork the example app, modify it and Ill have a look.
But I suggest you to use an extra container view rather than modifying the TextMessageView. I a similar way like I added an extra stack view in the container in your previous question.

Hi @ekazaev
Thanks for answering the first part. Feel a bit dumb now :D
For the second part. Try add a constant for the text view top anchor like in below image, then scroll the chat up and down. The constraints are not consistent after scrolling. I want to push the text view down so that I can make space to add the reply message view. I tried activating the top anchor constraint in reloadData method but issue was still there.

@ElrB I do not see such behaviour. Everything is as expected.

diff --git a/Example/ChatLayout/Chat/View/Text Message View/TextMessageView.swift b/Example/ChatLayout/Chat/View/Text Message View/TextMessageView.swift
index c9a704f..6d226fb 100644
--- a/Example/ChatLayout/Chat/View/Text Message View/TextMessageView.swift
+++ b/Example/ChatLayout/Chat/View/Text Message View/TextMessageView.swift
@@ -23,6 +23,7 @@ final class TextMessageView: UIView, ContainerCollectionViewCellDelegate {
     private var controller: TextMessageController?

     private var textViewWidthConstraint: NSLayoutConstraint?
+    private var textViewTopConstraint: NSLayoutConstraint?

     override init(frame: CGRect) {
         super.init(frame: frame)
@@ -74,7 +75,8 @@ final class TextMessageView: UIView, ContainerCollectionViewCellDelegate {
         guard let controller else {
             return
         }
-        textView.text = controller.text
+        textView.text = "\(controller.text.count % 2 == 0 ? "[Odd]" : "[Even]") \(controller.text)"
+        setupSize()
         UIView.performWithoutAnimation {
             if #available(iOS 13.0, *) {
                 textView.textColor = controller.type.isIncoming ? UIColor.label : .systemBackground
@@ -112,18 +114,25 @@ final class TextMessageView: UIView, ContainerCollectionViewCellDelegate {
         textView.font = UIFont.preferredFont(forTextStyle: .body)
         addSubview(textView)
         NSLayoutConstraint.activate([
-            textView.topAnchor.constraint(equalTo: layoutMarginsGuide.topAnchor),
             textView.bottomAnchor.constraint(equalTo: layoutMarginsGuide.bottomAnchor),
             textView.leadingAnchor.constraint(equalTo: layoutMarginsGuide.leadingAnchor),
             textView.trailingAnchor.constraint(equalTo: layoutMarginsGuide.trailingAnchor)
         ])
+        textViewTopConstraint = textView.topAnchor.constraint(equalTo: layoutMarginsGuide.topAnchor, constant: 80)
+        textViewTopConstraint?.priority = UILayoutPriority(rawValue: 999)
         textViewWidthConstraint = textView.widthAnchor.constraint(lessThanOrEqualToConstant: viewPortWidth)
         textViewWidthConstraint?.isActive = true
+        textViewTopConstraint?.isActive = true
     }

     private func setupSize() {
         UIView.performWithoutAnimation {
             self.textViewWidthConstraint?.constant = viewPortWidth * Constants.maxWidth
+            if (controller?.text.count ?? 0) % 2 == 0 {
+                textViewTopConstraint?.constant = 80
+            } else {
+                textViewTopConstraint?.constant = 0
+            }
             setNeedsLayout()
         }
     }

Thanks @ekazaev
I think am good to finish coding replies now.


tracking: Custom SSL certificate with secret

After https://github.com/risingwavelabs/risingwave/pull/17456, RisingWave has gained a certain level of capability in managing certificates for administration. User can write options like xxx.location = SECRET yyy AS FILE. But there is still work to be done to support SSL configurations with secrets in different places.
We at least need to prioritize support for the following distinct requirements, and then additional connectors can be supplemented as needed afterward. We should provide support for the following and add corresponding tests and docs.

Source

[ ] Kafka
[ ] MySQL
[ ] https://github.com/risingwavelabs/risingwave/issues/17785

Sink

[ ] Kafka
[ ] MySQL
[ ] PostgreSQL

schema registry

[ ] https://github.com/risingwavelabs/risingwave/issues/17173

Also link to #17202

cc. @tabVersion Can you please help to support SECRET in those connectors that already has SSL support? such as Kafka.

cc. @tabVersion Can you please help to support SECRET in those connectors that already has SSL support? such as Kafka.

We've supported using secret for any attr in with clause. You can define the broker addr as secret if you want.


[HELP]

Duplicate issue

[X] I've searched for any related issues and avoided creating a duplicate issue.

Description

after cloning the code I have given npm install on root directory.
then npm start to start the server.
started the client side server also.
after clicking the start simulator button on client side in console it shows the error WebSocket connection to 'ws://localhost:8080/' failed:

e-mobility-charging-stations-simulator version
1.1.88
Node.js Version
v16.17.1
System
OS: macOS 12.5
CPU: (8) arm64 Apple M1
Memory: 91.77 MB / 8.00 GB
Shell: 5.8.1 - /bin/zsh
Expected result
Expected to start the webSocket connection and able to view the list of charging stations after clicking the start simulator.
Actual result
Actually it shows the error like WebSocket connection to 'ws://localhost:8080/' failed:
Attachments

You need do not have an OCPP-J server to connect to (here at ws://localhost:8080/).
robohydra in the repo can be used as WS server. But you then will have to manually do the OCPP-J message sequence on robohydra message endpoint.

but after giving npm start in root folder it shows simulator started.

Sorry, I confounded WebSockets server. You need to enable the UI server in the main configuration file with authentication enabled:
"uiServer": {
    "enabled": true,
    "type": "ws",
    "authentication": {
      "enabled": false,
      "type": "basic-auth",
      "username": "admin",
      "password": "admin"
    }
  },

Thanks for your kind response.

I have changed the configuration as per your instruction.

I'm still getting the same error.

Please follow the simulator README.md and read it thoroughly: the configuration file template must be copied to config.json.

Thank you so much, it worked.


Transposing chords by a number of semitones

I'm creating a simple ukulele composition tool and need a way to transpose chords by a numerical offset in semitones (this is common in lots of tablature sites/apps).
In order to transpose a Chord, you must pass an Interval object to the .transpose or .interval method, but I don't know how to create such an Interval that correctly represents the operation I'm trying to achieve.
I'm not very familiar with music theory, but I determined that I can achieve this with a lookup table of interval names that achieve what I want:
var INTERVAL_NAMES = [
  'P1',
  'm2',
  'M2',
  'm3',
  'M3',
  'P4',
  'A4',
  'P5',
  'm6',
  'M6',
  'm7',
  'M7',
  'P8',
];

// Handles modulo correctly for negative numbers:
function mod(n, m) {
  return ((n % m) + m) % m;
}

function intervalFromSemitoneOffset (n) {
  return teoria.interval(INTERVAL_NAMES[mod(n, 12)]);
}

This seems to work, but feels sloppy. What would you suggest? Personally, I'd love it if .transpose/.interval could simply take an integer value, but I'm probably misunderstanding something about how intervals work.

Hi Louis, thanks for writing!
Well, you don't "misunderstand" how intervals work - it's just that they're ambiguous in music theory. You could argue that you can't hear any difference, but there are several intervals that represent the same amount of semitones (in western equal temperament). E.g. A "major" third and a "diminished fourth" "contains" the same amount of semitones, but are theoretically different.
Anyways. I'd probably do it in a different way, since it seems that you don't care whether you get a "C#" or a "Db". What about transposing the root by key number?
var root = teoria.note('E');
var chordE = teoria.chord(root, '7');
var chordF = teoria.note.fromKey(root.key() + 1).chord(chordE.symbol)

var chordG = teoria.note.fromKey(chordF.root.key() + 2).chord(chordF.symbol)

// general function
function transposeChord(chord, semitones) {
  return teoria.note.fromKey(chord.root.key() + semitones).chord(chord.symbol)
}

Here I'm just reusing the Chord.symbol property, and creating a new root by key number.
It might not be ideal, and I'm open to suggestions on how to do it better.

Much better! However, I'm having issues with slashed chords. Should the expected behavior be such that the bass note remains the same when a slashed chord is transposed?
For instance:
var transposed_DF = transposeChord(teoria.chord('D/F'), 1);

console.log(transposed_DF.name); // "Eb/F"
console.log(transposed_DF.symbol); // "/F"

My instincts tell me that the transposed chord should actually be Eb/F#, right?
Note: using .interval has the same problem, because the .bass and .symbol properties are not considered in transposition methods. The slashed chord problem might be worth opening a separate issue for...

Yes it should - an oversight :)
Let's fix that soon.

I'd be happy to write some tests for these edge cases!

(Whoops, didn't mean to close the issue there)

Yes please do! It might need some rethinking on how we handle "slash chords".
My initial thought is if the voicing doesn't have the root in voiced lowest, then display as a "/ chord", and don't let the slash be part of the .symbol?

Closing this instead of #92


ASP.NET Core with Windows Authentication not returning 403

Hi,
I am trying to set up a MVC project to use windows authentication & authorization but I am struggling with the correct setup.
The app should only allow users of a particular AD group: "PlatformUser", but whenever I try to implement this, I get the error below.
Here's my startup:
    public void ConfigureServices(IServiceCollection services)
    {

        services.AddAuthorization();

        services.AddAuthenticationCore(options => {

            options.DefaultScheme = IISDefaults.AuthenticationScheme;
            options.DefaultAuthenticateScheme = IISDefaults.AuthenticationScheme;
            options.DefaultChallengeScheme = IISDefaults.Negotiate;
            options.DefaultForbidScheme = IISDefaults.AuthenticationScheme;

        });

        services.AddMvc(config =>
        {
            var policy = new AuthorizationPolicyBuilder()
                             .RequireAuthenticatedUser()
                             .RequireRole("PlatformUser")
                             .Build();

            config.Filters.Add(new AuthorizeFilter(policy));
        });

        services.Configure<IISOptions>(options =>
        {
            options.AutomaticAuthentication = true;
        });
    ...
    }

As soon as I add .RequireRole("PlatformUser") my app, I get the following error, where I expected a 403:

Having searched the issues here and rigorous Googling, I am struggling to find any examples of the correct setup to do this with Windows Authentication (There are plenty for OAuth and JWT, but few if any for Windows).
More about my environment:
The app is set up with IIS as the Proxy host with Windows Authentication enabled and Anonymous disabled. Project properties => Debug is also configured as follows:

Web.Config:

Launch Settings:

Can anyone identify what I have missed or point me towards some sample code?

Looks like I was simply missing a Nuget Package.  After adding Microsoft.AspNetCore.Server.IISIntegration, the application appears to be behaving as expected.


[WIP] Mini language tweak

Just some random tweak because I want to see the CI in action!

The rest looks good to me!


Updated readme to include information about potential lifecycle conflicts

As discussed with @mweststrate there's a gotcha that can sneak in when using arrow functions for React lifecycle hooks so this PR adds a small note with link to relevant issue to the docs to help other users that run into this situation.

Thanks!


Added dogfact

Are dogs better than cats?

Also I got facts from here is that fine?

Looks good, thanks.


[23.05] samba: 4.17.7 -> 4.17.10

Description of changes
https://nvd.nist.gov/vuln/detail/CVE-2023-34967
https://nvd.nist.gov/vuln/detail/CVE-2022-2127
https://nvd.nist.gov/vuln/detail/CVE-2023-34968
https://nvd.nist.gov/vuln/detail/CVE-2023-3347
See #244505 for master
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Unfortunately this broke build of libvlc on aarch64-linux, blocking the channel.
https://hydra.nixos.org/build/230258161#tabs-buildsteps
(I also reproduced the failure on the community machine.)
Notably, the samba version merged to nixpkgs master did not cause this:
https://hydra.nixos.org/build/229889399

Unfortunately I don't see indication what's wrong, just these lines:
collect2: error: ld returned 1 exit status

Ah, this earlier line most likely belongs to the error as well (a different attempt had them consecutive):
/nix/store/pndi5gr1b9p591vmr7dvijymi8faclck-binutils-2.40/bin/ld: cannot find -lvlc_vdpau: No such file or directory

Pushed as e9ca92b55bed.

So many parallel-make issues lately.


Matrices and Determinant Calculator

Matrices
Add information and create  matrix multiplication, inverse matrix, transpose of a matrix calculator.
###Determinants
Add information on determinants and create determinant calculator.

Hello, I am a GSSOC'22 participant and I have knowledge about matrices and determinants and would like to contribute in this issue.

@aku1310 the definition should be copied from other sites and also add the solution steps for the calculator as done in physics calculators like force.

Hello, I am a GSSOC'22 contributor i would like to contribute here please assign me this issue . I can add step by step procedure to solve matrix problem i.e. multiplication, inverse matrix, transpose addition  subtraction too

I want to work on this issue

@riyajaiswal25 u can work

is this issue still unresolved?

if yes, then i would like to work on it.

@the-illuminatus u can work

I want to work on this issue. I can make a matrix and determinant calculator.

Hello, I am a SSOC'22 participant, and would like to work on this issue. Since matrices is a big topic, I can first start on the determinant calculator of square matrices.

@Samiksha-Garg u can work


keyboard input events

we don't have the map of keycodes to keynames setup so the whole
input.on('KEYDOWN_A', () -> {});

doesn't work currently

possibly use Reflect inside the input keyboard plugin constructor to build the map? no good idea on this one currently


[Service Bus] Stress/Perf testing for track 2 API

Perf

Receive: Initial state: 1M Messages are in the queue

Use streaming receive, receive 1M messages

peeklock
receiveAndDelete

Receive messages in a loop with a single receiver for X duration(X=3hs)

peeklock
receiveAndDelete

Send: send messages with a single sender in a loop for X duration - sendMessages (- single message)

Compare results with track 1 SDK
Stress Scenarios

Message lock renewal

Keep sending messages in a stream, keep receiving them and

manually keep renewing the lock for X duration
Use auto renew for X duration
(Variation - load the queue with a set of messages initially)

Session lock renewal

Multiple sessions

manually keep renewing the lock for X duration
Use auto renew for X duration

Single sender

Loop over sendMessages for X duration with Y delay in between
Loop over Z parallel sendMessages for X duration with Y delay
Large messages

Array of messages
Batch message

Single Receiver (Note the Sequence number and match with the received ones)

Keep sending messages in a stream, keep receiving them with a single receiver

ReceiveBatch in a loop with a single receiver for X duration(X=3hs)

Peeklock (random settlement method)
receiveAndDelete
maxMessageCount = 1 and Y

Streaming receiver left open for X duration to keep receiving the messages

Peeklock (random settlement method)
receiveAndDelete
maxConcurrentCalls = 1 and Y
(As you increase the number, it should scale up)
Validation

Any of the managementLink operations (Validate the sequence numbers)

Keep making peekMessage calls for X duration with Y delay in between

Relaxed tests - X is relatively longer (1hr/1day)

Do an operation, wait for X duration, do the operation again, repeat

Operation can be

Send
Receive

min_duration < X < max_duration

Closes and Opens

Create, open, close in sequence - repeat for X duration

Sender
Receiver
Session receiver
(Variation - add closing the client too)

Done implementing the tests with #11546 and #12229


Add readonly field for MongoDB

Support for creating MongoDB read only users - merge is dependent on feature flag enablement.

@andrewsomething Hey, this looks fine to me, but is the Add New Read Only User (MongoDB Only) line actually gonna show up in the docs? The Add New User with MySQL Auth Plugin doesn't show up as far as I can tell. Just worried about making it confusing.

I do see the Add New User with MySQL Auth Plugin in the dropdown of the request samples. Are you expecting to see it somewhere else?


When JSON Wrapped by Array

[
  {
     "aa": 123
     "bb": 234
  }
]

Could I send a POST Request with this body ?
I want to send [ [String:AnyObject] ]. I need your help.
Thanks

public func POST(url: String, parameters: Dictionary<String,AnyObject>?, completionHandler:((HTTPResponse) -> Void)!) {
    if let opt = self.create(url, method:.POST, parameters: parameters,completionHandler: completionHandler) {
        opt.start()
    }
}

Yeah it is setup right now to take a Dictionary for the requestSerializer as HTTP parameters are in key/value form and most JSON bodies I have seen are usually JSON objects. Changing it to take AnyObject would have some considerations as some of the serializer methods would have to change to support arrays as well. Pull Request is welcomed or if you have access to the API you could always change it to be something like {"array": ["value1","value2"]}

I rolled this into the Swift 2 update. Should be able to pass either dictionary or an array as the parameter. Thanks for the report, help improve the Swift 2 release.


PyTorch version in conda.yml

conda.yml installs PyTorch 1.0.1 but this throws in AttributeError with torch.nn.Identity(). PyTorch 1.1.0 used in the Singularity definition file works.

Changed Pytorch version in conda.yml


Remove Discontinued SpyEye Tracker Bots

SpyEye: The SpyEye tracker was discontinued quite some time ago. Clean up unneeded code.

Thank you for cleaning these. Merging commits.


What do references to the 17763 SDK in project files have to do with the building requirement of a 18362 SDK?

Your Windows build number:  (Type ver at a Windows Command Prompt)
10.0.18362.86

What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots)

:: commit d5b8e7c32f7a419a7d467eab038251ee529056e6
> grep -r . -I -Fwe 17763
./build/scripts/Create-AppxBundle.ps1:    $MakeAppxPath = "C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x86\MakeAppx.exe"
./packages/Microsoft.UI.Xaml.2.1.190405001-prerelease/build/Microsoft.UI.Xaml.targets:        Text="Microsoft.UI.Xaml nuget package requires TargetPlatformVersion >= 10.0.17763.0 (current project is $(MicrosoftUIXamlTargetPlatformCheckValue))"
./packages/Microsoft.UI.Xaml.2.1.190405001-prerelease/build/Microsoft.UI.Xaml.targets:        Condition="$(MicrosoftUIXamlTargetPlatformCheckValue) < 17763" />
./pkg/appx/OpenConsolePackage.wapproj:    <TargetPlatformVersion>10.0.17763.0</TargetPlatformVersion>
./samples/ConPTY/EchoCon/EchoCon/EchoCon.vcxproj:    <WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion>
./src/cascadia/CascadiaPackage/CascadiaPackage.wapproj:    <TargetPlatformVersion>10.0.17763.0</TargetPlatformVersion>
./src/cascadia/CascadiaPackage/CascadiaPackage.wapproj:    <TargetPlatformMinVersion>10.0.17763.0</TargetPlatformMinVersion>
./src/cascadia/TerminalCore/lib/terminalcore-lib.vcxproj:    <WindowsTargetPlatformMinVersion>10.0.17763.0</WindowsTargetPlatformMinVersion>
./src/cascadia/TerminalCore/lib/terminalcore-lib.vcxproj:    <WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion>
./src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj:    <WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion>
./src/common.build.pre.props:    <WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion>
./src/cppwinrt.build.pre.props:    <!-- 17763 is RS5 -->
./src/cppwinrt.build.pre.props:    <WindowsTargetPlatformVersion Condition=" '$(WindowsTargetPlatformVersion)' == '' ">10.0.17763.0</WindowsTargetPlatformVersion>
./src/cppwinrt.build.pre.props:    <WindowsTargetPlatformMinVersion>10.0.17763.0</WindowsTargetPlatformMinVersion>
./src/tools/vtpipeterm/VtPipeTerm.vcxproj:    <WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion>

What's wrong / what should be happening instead:
What do those references to the 17763 SDK in the project files have to do with the building requirement of a 18362 SDK?

Contrasting to the grep above, searching for the string "18362":
> grep -r . -I -Fwe 18362
./README.md:* You must be running Windows 1903 (build >= 10.0.18362.0) or above in order to run Windows Terminal
./README.md:* You must have the [1903 SDK](https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk) (build 10.0.18362.0) installed
./src/cascadia/CascadiaPackage/Package.appxmanifest:    <TargetDeviceFamily Name="Windows.Universal" MinVersion="10.0.18362.0" MaxVersionTested="10.0.18362.0" />

This is confusing.  I guess this repo can actually be built with the 17763 SDK, since it has been referring to 17763 all along whilst being able to build?

@fghzxm yes, you could build Terminal with 17763 SDK, tested it. But no chance to run it on same run-time version.

@hapylestat Have you tried building with 17763 and running on 18362 (which is my configuration)?

I build it with SDK 18362. You have to retarget the OpenConsole solution to that SDK version and toolset. Open the solution file in VS and right click on the solution icon, click retarget solution. Otherwise just sed -i '/s/17763/18362/g it.

I build it with SDK 18362. You have to retarget the OpenConsole solution to that SDK version and toolset. Open the solution file in VS and right click on the solution icon, click retarget solution. Otherwise just sed -i '/s/17763/18362/g' it.

@hapylestat I can build it with 17763 and run it on 18362.  I'm yet to do some further testing but everything seems fine now.

That might just be an artifact of our dev process that never got updated. IIRC we were using the 17763 SDK for a while, but since the package required 18362 to run, we switched to that SDK, yet clearly didn't get all the references updated.

You know, I think we changed this with #1012.


Invalid asm.js

After running basic set up and getting angular-cesium up and running,
warning in the console:
Invalid asm.js: Invalid member of stdlib        globe:557

looks like a chrome issue.
https://github.com/AnalyticalGraphicsInc/cesium/issues/5847

thanks! hopefully gets figured out soon.


Specify serial number for macOS guests using Apple Virtualization

I want to specify a serial number for macOS 12 virtual machine. I remembered reading somewhere that this seems to be supported by Apple Virtualization framework but can't find any documentation about it.
Note: In Parallels Desktop (Intel only), you set the boot flag "devices.smbios.serial= to specify a serial number. There is no such option for the ARM version of Parallels Desktop, which is what I've tried.
Is this possible to implement in UTM?

Unfortunately, as you may have suspected, this isn't permitted by Apple APIs. You may check out https://github.com/saagarjha/VirtualApple for an implementation that uses private Apple APIs.

https://github.com/saagarjha/VirtualApple do not provide any documentations. Do you have any more information to share as to how I can specify a serial number?

I have no idea. I’m saying that’s the project you should reach out to if you want to do things outside of what apple has allowed. I don’t know if it’s actually possible to do at all (even outside of public apis). But this isn’t the right project to ask.

OK. Thank you for your help and clarifications!


python310Packages.drf-yasg: 1.21.5 -> 1.21.7

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.drf-yasg is: Generation of Swagger/OpenAPI schemas for Django REST Framework
meta.homepage for python310Packages.drf-yasg is: https://github.com/axnsan12/drf-yasg
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.21.7 with grep in /nix/store/y8i8q4qapzz3r4qpd912qdnvzxb2vh7w-python3.10-drf-yasg-1.21.7
found 1.21.7 in filename of file in /nix/store/y8i8q4qapzz3r4qpd912qdnvzxb2vh7w-python3.10-drf-yasg-1.21.7

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
netbox
netbox_3_3
python310Packages.drf-yasg
python311Packages.drf-yasg

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/y8i8q4qapzz3r4qpd912qdnvzxb2vh7w-python3.10-drf-yasg-1.21.7 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.drf-yasg https://github.com/r-ryantm/nixpkgs/archive/9262b8ab0543b422fa6d88501bd8e14abcf32a27.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/y8i8q4qapzz3r4qpd912qdnvzxb2vh7w-python3.10-drf-yasg-1.21.7
ls -la /nix/store/y8i8q4qapzz3r4qpd912qdnvzxb2vh7w-python3.10-drf-yasg-1.21.7/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

netbox
python310Packages.drf-yasg
python311Packages.drf-yasg

Maintainer pings

Result of nixpkgs-review pr 252253 run on x86_64-linux 1

1 package marked as broken and skipped:

netbox_3_3

5 packages built:

netbox
python310Packages.drf-yasg
python310Packages.drf-yasg.dist
python311Packages.drf-yasg
python311Packages.drf-yasg.dist


Manually start jobs from Sonarr instead of automatically, in bulk

Is your feature request related to a problem? Please describe.
My current workflow is downloading thru Sonarr & then importing manual subs through Bazarr, I just wish I could control when a sickbeard's mp4 automator is started for the new episodes since it processes them automatically after downloading, so I can't "prepare" the media for processing
Describe the solution you'd like
I'm not sure if it's possible, but if it is perhaps a button on sonarr's webui or like a command of some sort, or like when I add subs through bazarr it automatically triggers it (would be cool), basically the same of the current automatic flow but with a manual "approval" button, even better if it's per episode
Describe alternatives you've considered
I have considered dumping the media into a folder & then run a bulk script to process all of them... but it would be much better if there was a more integrated option that only starts jobs when I finish working on my media (so sonarr's trigger waits)
Additional context
None

I have no control over this request, you would be better served putting in a feature request for Bazarr to run custom scripts or to have Sonarr/Radarr add a rerun/re-postprocess option/button but I can't change Sonarr/Radarr's webui or the internal workflow of these applications
You could try using the subliminal integration that's included with the script to get your subtitles before processing and circumvent Bazarr or write a scheduled task of some kind that looks through your media folder and processes based on certain conditions
You also just disable completed download handling in Sonarr/Radarr so they don't get automatically imported and then use the 'manual import' button whenever those files are 'ready' to be brought in which will then delay the post processing

the thing is I import the subtitles manually because %90 of the time bad subs get picked up, but I like your idea, I may just do that and try to schedule tasks (and then simply readjust them after finishing), if that doesn't work I'll just make a batch bash script to process it after finishing

It probably wouldn't be too difficult to write a simple scheduled script to just search through your media directories and if a subtitle file is found to find the associated media file and run it through manual.py to merge the sub and media file into a single file (which I assume is what you're aiming for here)


Cannot install ZDrive using pip

Hello.
I'm trying to install ZDrive using pip. However, I am getting the following error. I can install any package just not this one. I'm on Windows 11 Pro.
pip install ZDrive
Collecting ZDrive
  Using cached ZDrive-2.1.2-py3-none-any.whl (9.8 kB)
Collecting pathlib>=1.0.1
  Using cached pathlib-1.0.1.tar.gz (49 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [1 lines of output]
      ERROR: Can not execute `setup.py` since setuptools is not available in the build environment.
      [end of output]

  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [1 lines of output]
      ERROR: Can not execute `setup.py` since setuptools is not available in the build environment.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details

same issue here. Pathlib is unmaintained, breaks the install, and is also unneeded. Removing it from the requirements.txt should fix the issue


API v1: update getImageData() and LoadImages()

getImageData(id) in infoPopupModule.js and loadImages() in bookmarkModule.js uses the image search endpoint of the cc catalog API (old docs and new doc). Update and mould the implementation of these function in accordance of the new API version.

change the url from http://api.creativecommons.engineering/image/{id} to https://api.creativecommons.engineering/v1/images/{id}
Since provider_code key is removed in the new version, use source in loadImages().
Since provider key is removed in the new version, use source in getImageData().
Also, change the instances of provider variable to source in these functions.

I would like to work on this issue

@Arunhari333 Thanks for showing the interest to contribute to this project! Let's work on a single issue at a time. You already have submitted a PR for a different issue.

@Arunhari333 You can take this up. Please confirm by commenting if you start working on this.

@makkoncept Yes, I am still interested

Should only provider_code in loadImages() and provider in getImageData() be changed? Or should provider be changed to source in other places like popupProvider, css classes etc?

@Arunhari333 Just stick to the code that is logically connected to the function loadImages() and getImageData(). For example the variable providerImageElement needs to be changed to sourceImageElement but changing something not connected (for eg providerAPIQueryStrings object name)) is not needed.

Ok done, but before I commit, there is a variable provider used in bookmarkModule.js. Since provider_case was renamed to source, provider cannot be given the same name, so I did not change it, is that ok?

I think that you can change variable name of provider to source as being a local variable to the function loadImages it won't create a problem?

Right.

Ok. Done.


There was an issue connecting to Ollama ("POST /chat HTTP/1.1" 400 Bad Request)

Bug Report
After image génération, unable to send new request.
Always get the "Uh-oh! There was an issue connecting to Ollama."
Description
After generating an image with AUTOMATIC111 (txt2img), all new requests results in the error "Uh-oh! There was an issue connecting to Ollama." which ever LLM selected.
The corresponding error on Ollama side is a 400 for the "POST /api/chat".
When starting a new chat, all is OK, but going back to the chat with image is still NOK
Steps to Reproduce:
Ollama v0.1.27, OpenWebUI v0.1.111, Stable-Diffusion-webui v1.8.0
Generate a prompt for image generation (repeat this : ....) then click on "image generation".
When image is shown, try to ask anything => error
Logs and Screenshots
Screenshots (if applicable):

Installation Method
[Docker]

This issue has been resolved on our dev branch! #1137 We'll be merging to main soon, but feel free to switch to our dev branch in the meantime!


fix image url in docs

update docs, fix image url

Thanks so much for the contribution @zirconias!


Not covering all files

https://codecov.io/gh/Coding-Doctors/sudobot-rs/src/ci/src only has one of the like 5 files that are used, better seen in the CI build where tarpaulin runs (verbose output)
https://travis-ci.org/Coding-Doctors/sudobot-rs/jobs/302635711
https://github.com/too-r/sudobot-rs/tree/master/src

So this seems a bit weird. This is what I got when I cloned your project and ran tarpaulin on it on my own machine:
Launching test
running /home/xd009642/code/rust/meta_tarpaulin/sudobot-rs/target/debug/deps/sudobot_rs-dc0dcb6f375221b1
Working dir /home/xd009642/code/rust/meta_tarpaulin/sudobot-rs/Cargo.toml

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

Coverage Results
src/commands/mod.rs: 0/2
src/handlers/mod.rs: 0/11
src/handlers/moderation.rs: 0/20
src/main.rs: 0/21

0.00% coverage, 0/54 lines covered
Tarpaulin finished

Four out of five files but that may always be down to macro use. I'll try cloning your project and running it on travis myself to see if I can get to the bottom of it.

So this is down to #70 which is caused by rust-lang/rust#46467. So I'm hoping as this is a regression in the compiler once the issue is closed in the compiler you should see all the source files in coverage results. I'm going to close this issue because of that but you can follow developments in #70 or if you like I can tag you when it's closed.


Drag and Drop support for grid

Bug, feature request, or proposal:
This is one feature request
What is the expected behavior?
cdkDragList support for grid. like:

the from angular blob
What is the current behavior?
Current only horizontal or vertical lists are support

I have a horizontal list of photos that needs to wrap (using fxLayout="row wrap"). However, when it spans multiple lines, it breaks:

Also, is this a duplicate of https://github.com/angular/material2/issues/13372


Port ONNX to runtime

Amend predict test
Introduce ONNX model wipe endpoint

I've changed the code so that an ONNX runtime is used now.
There was no way described to do predictions with ONNX without saving these intermediate .onnx files.
Therefore, I created a new directory for them, which can be wiped thanks to a new endpoint.
I did not touch the train function yet since you said this would be done elsewhere in the future.

Thanks for the PR, I will look over it!
One minor thing: Any particular reason why 'requests' was removed from requirements.txt? I added that because otherwise the tests fail on GitHub Actions (see https://github.com/isaac-project/isaac-ml-service/pull/6/checks?check_run_id=945082658).

Sorry, that must have happened accidentally when I put in the two new requirements.
I was already wondering why the tests fail.
I put requests back in, hopefully it works now.

Thanks, that particular problem is gone now. test_predict is still failing, it looks like the model file is not there, you might need to push it as well.

The problem was that the onnx_models directory was not pushed to git because it is initially empty.
I added a .keep file to the directory to make git take it into account.

The joblib dependency is removed now.
I was able to apply your suggestion to send meta data with the ONNX models (by means of metadata_props).
Also, I changed the behavior of the clf dictionary. It is not populated completely everytime that main.py is started.
Instead, clf is only populated with the model that is needed for prediction when the /predict endpoint is called or when a new model is trained.
I think this change makes sense because prediction with ONNX runtime relies on file reading anyway.
The ONNX model must (inconveniently) only be stored in clf to retrieve the output classes and columns.
Otherwise the clf dictionary could be removed completely.

As we discussed yesterday, I kept all parts that are responsible for training in the repo and also changed the code in the do_training function.

Tests:
I removed the test that tested whether clf was empty because this is functionally checked when looking for the model ID in clf and the existence of a file with the corresponding model ID.

Thanks, changes are looking good! The only thing that remains from my perspective is where you say:

Also, I changed the behavior of the clf dictionary. It is not populated completely everytime that main.py is started.
Instead, clf is only populated with the model that is needed for prediction when the /predict endpoint is called or when a new > model is trained.
I think this change makes sense because prediction with ONNX runtime relies on file reading anyway.
The ONNX model must (inconveniently) only be stored in clf to retrieve the output classes and columns.
Otherwise the clf dictionary could be removed completely.

The purpose of clf was to hold the models in memory so that they have to be read only once, because disk I/O and model deserialization/construction takes time, and should hence not be done for every predict request. I'd like to keep this feature if at all possible. Can you simply store InferenceSession objects instead of the sklearn classifiers we used to have?

Ok I didn't know that it was important that all models need to be loaded in memory all the time.
I changed it back so that now model objects and inference session objects are loaded every time main.py is started.

Thanks! Actually it seems we do not need to hold both models and InferenceSessions in memory. You can access the metadata you saved with the model through the InferenceSession.get_modelmeta().custom_metadata_map attribute. So keeping a dictionary of InferenceSessions around should be enough.

Cool, thanks for looking that up!
There is only one dictionary with inference session objects left now.
The columns and output classes are retrieved from the inference session object directly.

Looks good! Just one oddity: in the 'output_classes' metadata attribute, I only see one class ('1') instead of two. Could you look into why this is the case?

I don't know why it is one class only but it has been one class only since I started working with the repository if I remember correctly.
Are there supposed to be 2 classes?
I must admit I don't know how a Random Forest Classifier works exactly but I can read up on it.

There should be '0' for incorrect answers and '1' for correct ones, as it's a binary classification problem. Both have in the past been returned by the model.

Great analysis, thanks! Separating the testing procedure makes good sense to me. You could also make sure that the tests "clean up after themselves" so that there aren't any byproducts lying around.

There seems to be a problem with the model loading from the CAS string. When the tests are run, the default model is always created again on the basis of this CAS training. When training with it, only one output class is returned. Since I do not have insight into CAS object, I could not find out why.
I did comment out the test for train_with_CASes for now, though.

I'm guessing that's because one CAS only represents one classification instance, and a model trained from just this instance then only contains one class. So that's actually not a problem, because we'd never use such a model in practice anyway, it's only created for unit-testing purposes.

Would it be ok if I worked some time on clearly separating the testing procedure from the logic in main.py?
The fact that the testing procedure affects the default model and retrains it everytime the tests are run will be something that will fall on my feet again in the future, I'm quite sure. I think if I invest some time to have the tests operate on a model that is not in the main ONNX model directory, this could make things easier from now on, I guess. This way we could also take the hardcoded file name and include variable out of the main file.
Would that be ok?

Sounds good to me.

EDIT
I forgot: If you are wondering why the output_classes are not passed as metadata anymore.
The predict_proba equivalent provides the output classes by default so this is not necessary anymore.

Nice, that means less manual coding in the metadata.

Alright, I have separated the test procedure from the actual running of the service.
What changed?

/train is tested with a dataset with input data that I had created randomly.
This way we can test the endpoint without revealing real data to git.
There is a new subdirectory in the testdata directory that contains this new data.

The hard-coded filename was removed.
Instead I changed the /train endpoint from get to post method and introduced a pydantic model that demands the input of a filename.

Test changes:

they do not affect the onnx-model directory anymore (exception: /predict ; see explanation in docstring of test_predict)
all tests actually work now, no tests are skipped anymore
in some of the tests only the response status was checked, now outputs are checked as well

The pydantic names have snake-cased names again.

Thanks! One little thing: it was "modelId" before, not "modelID". Could you adjust that?

Sure, sorry I oversaw that.
This is fixed.


Fix gem crashing when content_block_delta contains partial_json inste…

When using tools with the Anthropic API ( https://docs.anthropic.com/en/docs/build-with-claude/tool-use ), the API will return a second set of content that doesn't contain text in the "content_block_delta" and will crash the gem.
This PR patches the error by checking if the text is present in the "content_block_delta"
All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?

Thanks very much @Leteyski - released in v0.3.1


FileMaker JDBC input issue - No suitable driver found

Hi
I am running Logstash with FileMaker JDBC connection as the input.
Here is the config file I am using:
input {
jdbc {
jdbc_driver_library => "C:\fmjdbc.jar"
jdbc_driver_class => "com.filemaker.jdbc.Driver"
jdbc_connection_string => "jdbc:filemaker://SERVER/DATABASE"
jdbc_user => "Username"
jdbc_password => "Password"
schedule => "* * * * *"
statement => "SELECT * FROM Table_Name;"
}
}
output {
elasticsearch {
hosts => ["localhost:9200"]
index => "My_Index"
}
stdout { codec => json }
}
I am getting the following error:
Unable to connect to database. Tried 1 times {:error_message=>"Java::JavaSql::SQLException: No suitable driver found for jdbc:filemaker://SERVER/DATABASE"}
{ 2010 rufus-scheduler intercepted an error:
2010 job:
2010 Rufus::Scheduler::CronJob "* * * * *" {}
2010 error:
2010 2010
2010 Sequel::DatabaseConnectionError
2010 Java::JavaSql::SQLException: No suitable driver found for jdbc:filemaker://SERVER/DATABASE
2010 java.sql.DriverManager.getConnection(java/sql/DriverManager.java:689)
2010 java.sql.DriverManager.getConnection(java/sql/DriverManager.java:247)
2010 java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:498)
2010 org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:423)
2010 org.jruby.javasupport.JavaMethod.invokeStaticDirect(org/jruby/javasupport/JavaMethod.java:355)
I tried to connect to FileMaker with DbVisualizer and other tools, by providing the same .jar file and driver class name and it worked.
Is there a hard-coded list of supported DB engines?
Can you please help?

This isn’t the repository for the JDBC input plugin. The output and input plugins are totally unrelated and I don’t use the jdbc input at all myself. You might want to ask over at https://github.com/logstash-plugins/logstash-input-jdbc
Sorry

Thanks
Closing issue


[create] remove @types/node dependency for TS component/app

Currently we include<EMAIL_ADDRESS>in the package.json because of some problem: https://github.com/DefinitelyTyped/DefinitelyTyped/issues/44019
Whenever this gets resolved we should not need to depend on this specific version anymore, and remove it from the package.json in  wc-lit-element-ts and app-lit-element-ts.

shoo stale


updated thumbnails for features, footer, pricing

Updated three images in public/images/ui

I have reviewed the changes and have the following suggestions:
The increased width of the card component has made the breadcrumb menu appear quite large. To improve the layout, you could consider one of the following options:

Revert the width size back to the previous setting.
Provide an image that is more proportionate to the new card size.


Update documentation generation script to get dev/rc version too

Update documentation generation script to get dev/rc version too

/release-doc/0.0.0

/release-doc/v0.0.0

/release-doc/v0.0.0.rc0

When I originally wrote this script, I didn't hope for it to behave this way, but since it now works as intended, I will close this PR."


add pronoun field in player config

tested locally

yup, straight copy paste.
I'll check the template to be sure.

there is nothing else we are missing!


Added leo

5/7 not enough description

Leo? This bot is becoming more and more like a rebus :-)
Why not a complete reference word, like "leon" or "leone"?


No module Found error

I getting this no module fond error

Thanks for raising this @Nithin745. I haven't done maintenance on this for a while now. I'll get this resolved most likely next week (just because of work, family, ...etc)

That's would be great, thanks for the quick reply.

Merged in fix in #3 @Nithin745 and published 0.1.2 to pip. Sorry about long wait, work is a bit hectic right now 😅

Thank you, for fixing the issue, It's working fine now.


VirtualService: Ability to choose a scheme for redirect target

Describe the feature request
VirtualService's redirect feature does not support choosing the scheme and always redirects to http. However, Envoy supports a scheme field, which I believe can be easily supported by Istio also.
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Just curious what the use case is? https://istio.io/latest/docs/reference/config/networking/gateway/#ServerTLSSettings does have httpsRedirect which is somewhat related and may cover your case

I was wrong with saying „always redirects to http“ in the issue description. Envoy detects the current scheme of the request and then redirects to that scheme. For https requests it will always return to https also. But the request scheme does not have to necessarily be the scheme of the redirect target.
The potential use case is, users may need to redirect to an http endpoint from a https request. After all envoy has this setting and it wouldn‘t hurt to support it with Istio, I guess.

sounds reasonable

Maybe not stale?

Here's another use case: traffic inside a cluster is "http://" scheme, even though encrypted via Istio's mutual TLS. When redirecting from e.g. non-www to www addresses, you want your location to include the scheme so that browsers don't have to first hit a http URI and a http->https redirect.


Add Get started section in the README

It would be useful to add a "Get started" section describing how to install it (also to clarify if Java needs installed to use it, it may seems a requirement for the development)

The language server by itself doesn't really have an install process. The build instructions are in the readme


Escape names in MySQL using backtick.

The default identifier quote character for MySQL is the backtick (`)
https://dev.mysql.com/doc/refman/5.7/en/identifiers.html
instead of the double quote (") used in Postgres
https://www.postgresql.org/docs/current/static/sql-syntax-lexical.html
Add a MyEscape function that uses backticks, tests and update the
mysql template files to use double quotes for strings instead of
backticks.

This is a fix for #90

It's funny that you're submitting this now. I had, just yesterday, written something almost identical.
The issue, however, is that causes problems with other databases, and if other modes are set for MySQL. The workaround that I found here is to execute the following SQL prior to running any xo generated queries:
SET sql_mode='ANSI';

You can see this in the recently added pokedex/main.go example.

Sorry, to clarify, I need to think about whether or not this should be added or not. There are issues with the templates and generating Go code in general, as any generated string now would need to be escaped.
This is a problem in the "custom queries". At the moment, there is no way to define the surrounding string quote identifier (you have to just specify it in the template), and wrapping all the various SQL calls would make the templates, in my opinion, practically unusable/understandable. This is partly a limitation of the Go template syntax.
Imagine if every SQL call in the templates had to look like this:
{{quotestr `SELECT * FROM` }}

Thanks for the quick reply! I had a feeling this might be controversial :) We don't use custom queries at the moment so I don't know how this would interact with those.
My thinking was that the default in MySQL should be the default in XO so that new users don't fall on the same "trap" and have to spend time figuring things out the same way I just did.
Either way, please let me know what you decide so that I make changes in our repo accordingly.

It's not controversial -- it just requires a certain amount of code maintenance. I agree, the --escape-* parameters should work out of the box with all the databases. The primary problem is that the same *.query.go.tpl is used for all the databases, and you'd at minimum need to add one for MySQL as well. I only realized the limitation of the existing xo templates yesterday, when I wrote up the pokedex example, as it has fields named order in the pokedex schema. I have no idea why this hasn't come up in the ~1 year existence of MySQL (or maybe it has, but I've not paid attention to it).
To be honest, forcing the ANSI mode seems like the right approach to me, as MySQL is the odd man out vs the other databases. One problem that I see is that there's a certain expectation that the code generated with xo' will be used in conjunction with other SQL already written -- that other SQL (whether targeted for MySQL or otherwise) I would, hypothetically, like to be uniform with what xo` generates.
Also, of note, is that there is only a "need" to escape the fields when there's a conflict with a reserved keyword. This is really one of those things where there are problems with either including this, or not including it. Not including it would require more documentation / handling further "support" inquiries via GitHub issues.

I'm thinking something like a general  --escape-mode=ansi is in order, which is default option that gets changed for MySQL. So maybe --escape-mode=<ansi|mysql|smart> or some such. With smart as the default. I really am trying not to add any more additional options to xo that aren't 100% necessary. I'll think about this over the next day and figure out if what you have here is the best approach or not.

A reserved keyword is exactly what just bit me and prompted this, we have a column named "Key".
I did add a mysql.query.go.tpl in this change, so that I could change the quote character there as well. I can totally see how having multiple copies of that template would be a maintenance burden if you're making regular changes to it.
I'm now testing what happens if we set the sql_mode=ANSI in all our connections (using Params in https://godoc.org/github.com/go-sql-driver/mysql#Config). That seems to be working so far, so that might be an option, which could be documented in the README.

Yes; I'm updating the README.md now.

I've updated the README.md, and think that the right way to go is to just tell users to use the sql_mode=ansi. It will keep the different database loaders more or less the same.

Sounds good, thanks for the quick turnaround.


buttons on Prompt Gallery don't work (AxiosError: Network Error)

Thanks for the great feature set. I'm dying to get this working.
I managed to get this working all the way up until the point where I click "send to webui" or "copy negatives" or any of  those buttons. They all return this error in the console:
AxiosError: Network Error
    at u.onerror (http://localhost:5173/assets/index.bed48b02.js:42:4558)

I did use the command prompts as described (cors, api). Any thoughts appreciated

I forgot to mention that the terminal didn't do anything, so nothing to copy/paste from there. Just the chrome terminal.

No, was local only. Do you think it could have something to do with certificates/https?

Maybe port 5173 closed?

I just noticed that you mentioned you use it on Colab. Please make sure you could visit port 5173.

This was actually on my home machine. Port 5173 was available to me (i.e. going to localhost:5173 resolved to the extension page). Also, the extension page loads when running the webui, it's only when you click on the buttons at the bottom of the page that it doesn't do anything.
Maybe there's something preventing the app from accessing 5173, how could I check that?

Just to be clear: this was not on Colab. It was a local install (not a jupyter notebook).
This might not be a cors issue, I think it might be an iFrames permissions issue. The page loads, and it's able to read the thumbnail file from the /preview/ folder, this wasn't happening in colab. I think because of cors issues.
On the local machine, I think cors is working, it just doesn't do anything when clicking the button. I fixed this problem for the copy/paste buttons (by changing the iFrame permissions in the html file). But I don't know what to try for the other buttons.

Digging a little more. Found this issue\ in the console:
ICookie samesite not set: Specify SameSite=None and Secure if the cookie should be sent in cross-site requests. This enables third-party use.

Cookies affected (are these your cookies?)

_xsrf | localhost/
username-localhost-8888 | localhost/

please also add allow="clipboard-read; clipboard-write" to the iframe tags

CORS should be workaround by add param  --cors-allow-origins http://localhost:5173/ to webui

Thanks! I added allow="clipboard-read; clipboard-write" . Unblock the copy and paste now. But I still do not understand why I could not repro:
AxiosError: Network Error
at u.onerror (http://localhost:5173/assets/index.bed48b02.js:42:4558)

I think 8888 might be your local jupyter notebook. This is not affected.
Web page do not store cookies. Web browser does. I checked the code of xsrf. Axios requests an xsrf protected action from http://'+ip+':'+port+'/sdapi/v1/txt2img' via a POST request. This happens when calling web-ui API.
From your description.  It might be your browser setting that block this activity. One assumption is your are using browser like firefox which has a STRICT samesite config. Try lower ths level or use chrome. I dont th

I think I found it!!!! Webui is running on <IP_ADDRESS> and the extension is runnning on localhost. Apparently Chrome thinks these are different domains!
I'll see if I can figure out how to run webui on localhost and see if that fixes it.

Okay, I added the flag --listen to the command arguments. The error message changed slightly but the main error remains.
I think it's because the extension is running on http and automatic1111 webui is running on https. If I can figure out how to change either one of them I think it will work.
Any ideas?

Okay, I'm pretty sure the issue is the cookies from your extension aren't https.

I could not use https since webui is not https. Do you by any chance know how to make it work?

On my env. AUTOMATIC1111 webui run in http

Interesting, mine runs in https automatically. I wish I could get it to run in http

Could you try alter param http in this line.

@muunkky  @charliehaydenhicks
I added some instructions in Readme on how to update the ip and port.
Please upgrade the extension and follow the exeact instructions. I checked that webui do not add any setup to contraint it to https/http. This might be a environment issue. Clould service might redirect http to https.
It is not considered as an extension issue as running locally it is good.


Favor Docker over Compose for CodeClimate command

When nib was hosted inside of a container the Docker client library was not available so we used Compose as a proxy. Now that nib is a gem running on the host system we can use Docker client directly.

👏


I dont want to execute sails lift command everytime to start server from terminal..  Is there any way to make server contineous on and dont write everytime sails lift ...command ..  Which file can enable sails lift always on ???

Why is this not included in sails like it is for example in emberjs?


Fix insecure request warning

Summary
Fixed the insecure request warning by ensuring ssl verification is enabled in all of our api calls. In addition, I've added a new config option called verify_ssl so that this behaviour is configurable by the user.
Description
The new config option is set to true by default. I've added this option to the Parameters class, which we already pass to each api call, instead of passing ssl_verify as a separate option.
Test Results
Ran all functional tests against Dremio Cloud:

Basic tests were flaky at first with one random test failing each time. But eventually all tests passed. The flaky tests may be related to #91
All other func tests passed without an issue

Changelog

[x] Added a summary of what this PR accomplishes to CHANGELOG.md

Related Issue
https://github.com/dremio/dbt-dremio/issues/142

@ravjotbrar how does the user change this new variable? Do you expect this to be an option when creating a profile when calling dbt init?
Should there be any unit tests added?

@ravjotbrar how does the user change this new variable? Do you expect this to be an option when creating a profile when calling dbt init?
Yup, I've added it in as part of the credentials. If nothing is specified it'll default to true.
Should there be any unit tests added?
Good point. I believe the component test that checks to see if the profile config is set needs to be updated.

@ArgusLi

Would it be better for us to roll verify_ssl into DremioAuthentication? Verifying SSL is technically authentication as it is server authentication and it would reduce the number of verify_ssl values in methods by 2 instances (I believe).

This is a great suggestion and one I do agree with, just not entirely sure if I should redesign and reimplement. @jlarue26 thoughts on whether this is worth the effort?

Should verify_ssl be always on when use_ssl is on? Certificate validation should always be on as it could be a hazard to have it off. Is just defaulting it to on enough?

What would you suggest here?

Should verify_ssl be always on when use_ssl is on? Certificate validation should always be on as it could be a hazard to have it off. Is just defaulting it to on enough?

Actually I think we should default it to on and remove the option from profile_template. We can update the Wiki for instructions to not verify certificates by manually adding use_ssl=false in the profile.

Would it be better for us to roll verify_ssl into DremioAuthentication? Verifying SSL is technically authentication as it is server authentication and it would reduce the number of verify_ssl values in methods by 2 instances (I believe).

What would the effort be to make this change?

What would the effort be to make this change?

To move verify_ssl into dremio authentication, removing it as a profile option, testing, and re-review should take at least half a day of effort. But worst case, we should have this change merged in by Monday.

Actually I think we should default it to on and remove the option from profile_template. We can update the Wiki for instructions to not verify certificates by manually adding use_ssl=false in the profile.

Do you mean by manually adding verify_ssl=false in the profile? use_ssl is for enabling/disabling encryption.
I like this idea - disabling certificate validation is such a niche case that it makes sense to hide it from most users.


Update parser.ex

Fix deprecation warning of use instead of import

@nacengineer let's take the opportunity to fix this on in the Encoder module as well.

@devinus This a really simple and harmless change that will help the community to avoid debugging issues in CI builds when warnings are treated as errors. Thanks in advance!

I've open the same PR last year https://github.com/devinus/poison/pull/208 but still not yet merged


Fixing header annotation in README

Only now I see that this PR has many, many duplicates. Merge already guys! :)


Introspection query issued repeatedly even while idle

This issue pertains to the following package(s):

[x] GraphQL Playground - Electron App
[x] GraphQL Playground HTML
[ ] GraphQL Playground
[ ] GraphQL Playground Express Middleware
[ ] GraphQL Playground Hapi Middleware
[ ] GraphQL Playground Koa Middleware
[ ] GraphQL Playground Lambda Middleware

What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?
1.7.20
What is the expected behavior?
Issue introspection request on load / on refresh button click / once in 5m or something reasonable
What is the actual behavior?
Playground is issuing introspection requests each 3s or so. It's too often for my taste, especially when developing locally it heats cpu a lot when schema is not cached on server.
What steps may we take to reproduce the behavior?
Launch Playground Electron or React (probably every version does that)

I found out it's probably because of low schema.polling.interval settings which is 2000ms by default. Low value for my taste. Dunno, maybe reconsider and eventually close this.

I started facing this issue recently. It is happening with "<EMAIL_ADDRESS>


atmospheric transmission modeling

Incorporate atmospheric transmission models to the end stage of the reduction pipeline. Primarily for generation of reflectance spectra for small bodies, but also applicable to other communities with poor airmass matches.

is this beyond scope of baseline project? will need some ideas on what this might look like e.g., grid of telluric models & stellar models - this feels like an UG project


cp: skip duplicate source check when --backup is given

When duplicate sources and the --backup option are provided to cp, GNU cp skips the duplicate source check and proceeds with copying the files. However, uu-cp does not currently behave this way.
For example
touch a; mkdir d;
cp --backup a a d/

GNU's cp would skip duplicate source check and tries to overwrite the "just-created" file and give us the error, (if backup--numbered is given then this won't file).
cp: will not overwrite just-created 'd/a' with 'a'

While uu-cp would give us
cp: warning: source file 'a' specified more than once

Fixed by https://github.com/uutils/coreutils/pull/6825


Install issues

Bug Information
Version Number of Plugin: 2.2.1
Device Tested On: Forms Android API 25
Simulator Tested On:  Android API 25
Version of VS:  2017
Version of Xamarin:  2.51.527436
Versions of other things you are using:
Getting error with
global::Plugin.CurrentActivity.CrossCurrentActivity.Current.Init(this, bundle);
ICurrentActivity' does not contain a definition for 'Init' and no extension method 'Init' accepting a first argument of type 'ICurrentActivity' could be found (are you missing a using directive or an assembly reference?

Also, when I tried using the latest version, it would not build.  it gave an error for droid about Plugin,Permissions.Abstractions could not be found.

If you upgraded to current activity 2.x then you need to use: <IP_ADDRESS>-beta


Show selected group on reload

Suggestion
I think we can show last selected group on welcome message instead of go to group selection again. If that's too big, we can auto route user to the group feed page after reload page for first iteration.

Yeah it should be done easily. Actually it's covered here as well https://github.com/hellowin/kanca/issues/120 on improve welcome message part.
Actually what I'm expected is go to Summary page metric instead of Feed, so we can keep audience focused on Summary as a Dashboard for first impression after selecting group.
Would you create PR for it? Keep in mind that when reloading it need to load the posts and comments first, it's still happens on Welcome page. Simple approach are:

Create function that handle data recovery from blank state, injecting to Redux. It's happens on Welcome page now. Just copy and paste it into something like Loading page (create new page).
In Loading Page handle the state.group.loading from Redux, implement the loading animation when there are loading happening.
Load (restore) data from local storage to redux after loading.
Redirect from empty state to Loading Page instead of Welcome Page.
Now we can redirect audience from here as we like, and easier to maintain when next time we want to change the redirection, noew redirect to /metric/summary if loading is done and data is recovered from local storage.

Current flow
First Load -> Check Auth -> Welcome Page

Expected flow
First Load -> Check Auth -> Loading Page -> Summary Page

yep, that works too. Will create PR for this 😄

Thank you @reyhansofian 👍

Nice idea! PR will come shortly ☺
On May 9, 2017 6:16 PM, "Andi N. Dirgantara"<EMAIL_ADDRESS>wrote:
Yeah it should be done easily. Actually it's covered here as well #120
https://github.com/hellowin/kanca/issues/120 on improve welcome message
part.
Actually what I'm expected is go to Summary page metric instead of Feed, so
we can keep audience focused on Summary as a Dashboard for first impression
after selecting group.
Would you create PR for it? Keep in mind that when reloading it need to
load the posts and comments first, it's still happens on Welcome page.
Simple approach are:

Create function that handle data recovery from blank state, injecting
to Redux. It's happens on Welcome page now. Just copy and paste it into
something like Loading page (create new page).
In Loading Page handle the state.group.loading from Redux, implement
the loading animation when there are loading happening.
Load (restore) data from local storage to redux after loading.
Redirect from empty state to Loading Page instead of Welcome Page.
Now we can redirect audience from here as we like, and easier to
maintain when next time we want to change the redirection, noew redirect to
/metric/summary if loading is done and data is recovered from local
storage.

Current flow
First Load -> Check Auth -> Welcome Page
Expected flow
First Load -> Check Auth -> Loading Page -> Summary Page
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hellowin/kanca/issues/137#issuecomment-300133444, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFGxgbO43VChfL_Xc0GtI8C-edzA-Qg5ks5r4Er2gaJpZM4NVEtK
.

Wow, we can use email to contribute? This is cool 👍 TIL

yep, we can reply this issue via email 😄

closed due to #153


Optimize PNGs before serving them to the user (aka reduce filesize losslessly)

While I've absolutely no coding ability whatsoever (my expertise is much more in hardware), I couldn't help but notice that simply running something like "APNG Optimizer" (which works for non-animated PNGs as well) at even the default settings easily cuts down the filesize of a waifu2x'd image by like 10 to 20% while being quite fast to process as well (it also includes a zopfli implementation that gives a bit smaller size but is way slower to process).
As a real-world web app example, ezgif.com's APNG maker seems to implement the same libraries that APNG Optimizer relies on.
For reference, here's a link to the APNG Optimizer program, source, libraries: https://sourceforge.net/projects/apng/files/

If you're interested in reducing file sizes, why not go straight for WebP?

If you wanted to sacrifice compatibility in the name of an even lower file size, then you might as well go straight for AVIF.
The way I see it, if the priority is compatibility, then PNG is king.
If file size is priority, then AVIF is king.
If neither is priority and you want something that only has middling compatibility and middling file size improvements, then sure I 𝘨𝘶𝘦𝘴𝘴 WebP could work...

WebP support only reached decent cross-browser support (~80%) in January 2019 with FF65 and Edge 18. Safari still doesn't support it yet.


Lint in Astrobee

The astrobee code passes the code through a linter when committing, which usually results in lots of complaints about formatting. Some of the formatting issues are fixed automatically by clang-format-8, but it can't fix such obvious things as whitespace at the end of lines, empty lines, missing space before brace, etc.
I propose adding a homegrown python tool to fix these. With such a refactoring tool one risks the danger that one's precious code gets messed up and lost, so the tool I have in mind would be very conservative. It would take as input the linter's output in a text file, which looks like this:
code.cc:1026: Line ends in whitespace.  Consider deleting these extra spaces.
code.cc:1034: Missing space before {
code.cc:968: At least two spaces is best between code and comments
code.cc:939: Redundant blank line at the start of a code block should be deleted.
It will first make a backup file called code.cc.bk, then modify precisely the lines the linter complains about while not touching anything else.  (When it comes to blank lines, those will be flagged for wiping but will be removed after everything else, to not mess up the bookkeeping.)
I propose to also add to the "Contributing" section at:
https://github.com/nasa/astrobee#contributing
a link to a document describing our style, how to get clang-format-8, and how to use the little python tool as a second step.
Any thoughts?
This will go to the related ISAAC repo as well.

Hi Oleg, which config file are you using for clang-format-8?  I copied the clang format used by the linter and haven't had issues except for having to manually add missing headers.  Let me know if you'd like me to send the file to you to test out.

Nvm, I realize you're using the output of the githook.  I wonder if that somehow behaves differently, I'll send you the config and let me know if that fixes your issues.

Your clang-format-8 config file seems to be identical to what astrobee uses already. I tried it with the command:
clang-format-8 -style=file -i myfile.cc
and it does not remove these:
Line ends in whitespace.
Missing space before {
Redundant blank line at the start of a code block
It does remove a lot of other stuff though.
Could you make a file with a space at the end and see if it wipes it for you?

It looks that clang-format-8 won't remove trailing spaces. https://stackoverflow.com/questions/44482062/removing-trailing-spaces-with-clang-format?rq=1

Hi Oleg, I added those items to a cc file and ran clang and the file reverted back to its normal state, I'm not sure what we're doing differently.  Can you send me the cc file you're testing with so I can confirm if it fixes the file you're having issues with?

I figured out what is going on. The clang-format-8 program refuses to clean code within #if 0 blocks, but cpplint complains about those. I can confirm that clang-format-8 cleans up the code once such statements are removed.

One think to keep in mind too is that the clang-format-8 that runs with the githook, only formats the error lines. It was specified like this to avoid cases where we align the code to be more readable and the program destroys it, even if it is not a problematic area.

This is a little dangerous. If multiple passes of clang are used and some of them wipe lines, the bookkeeping for the range of lines will be wrong.

Well, because the linter only runs on the problematic lines, empty lines will not be fixed (by their own there is no lint error)

We could run clang on the whole code base once people have merged their large outstanding prs so that the rest of the code is properly formatted

If we run the code on the whole base to start with, it does not make sense to run it on pieces. People may think their code is safe when clang is not run on some chunks now, and later it will be messed up anyway.
The clang formater can be quite aggressive on things like messing up whitespace alignment and rewriting function prototypes by packing as many arguments as what fit on a given line which is terrible for readability.

My concerns were satisfied by the recent pull requests.
The documentation now says that the code to be contributed must be clean according to cpplint, that clang-fortran-8 is used to do the cleanup with a provided config file, and it was verified to work.
Wording was also added to the hook which does the cleanup saying that the commit should be attempted again in case clang-format-8 fixed the errors cpplint complained about.


Add phantom's signAndSendTransaction method

The base signTransaction method:
https://github.com/solana-labs/wallet-adapter/blob/75388bd6774e0b5ed68cf0a4737d656adf14110f/packages/core/base/src/signer.ts#L13-L40
This sets the fee payer, recent blockhash, and partially signs if signers are provided.
Does this need to be added to the overridden implementation for Phantom also?

@jordansexton Phantom will already add this stuff internally https://github.com/phantom-labs/sandbox/blob/main/src/App.tsx#L155

Successfully published:

<EMAIL_ADDRESS>


Proposal to help automate categorisation of release notes in github

Motivation

The process to produce release notes for zebra releases can be quite time consuming and it can sometimes be hard to figure out which category a PR falls under.
Solution

We can leverage the new github automated release notes feature together with a release.yml file to try to pre-categorise some PRs according to their label or author.
Looking at PRs included in previous releases I could detect a pattern in the labels used for a  PR and the final category used in the release notes.
This change is related to and may be compatible with #2839
Review

This is not high priority at all and just intended to start a discussion. We can also merge this without any adverse impact as this will only be used if and when we choose to use the automated release notes feature in github when tagging a new release

Follow Up Work

PR authors should try to appropriately tag their PRs with the relevant tags according to the PR category for the release notes.
We may also want to create specific labels in github to be used for the release notes.

Let's also consider release-please as an alternative, because it automates version bumps as well as changelogs.
https://github.com/googleapis/release-please

I like this idea for the long term when we have a devops onboarded and we're looking at automating releases.
In the short term, I think this could be a quick win to help us speed up our current release process

Thanks, that makes the goals and scope of this change much clearer to me.

Let's also consider release-please as an alternative, because it automates version bumps as well as changelogs.
https://github.com/googleapis/release-please

I like this idea for the long term when we have a devops onboarded and we're looking at automating releases.

You're right, release-please would involve a bit of tool churn.
But changing to GitHub automated release notes also involves some tool churn.

In the short term, I think this PR could be a quick win to help us speed up our current release process

Can we configure our existing release notes tool with these tags instead?
Our release-drafter config looks very similar to the changes in this PR:
https://github.com/ZcashFoundation/zebra/blob/main/.github/release-drafter.yml


Safari support

I'm using the player on Safari 13.1, and it's not working so well in this browser. When I try to execute the player, the console shows this message:
ReferenceError: Can't find variable: AudioContext
... I think that AudioContext needs to be replaced by the webkitAudioContext in Safari. The Player works when I explicit pass the proper AudioContext in the PlaybackEngine constructor but it crashes when I try to stop it:

Thanks for the information. I have not done any testing in Safari myself but it's not very surprising since there are currently no polyfilling at all applied for the dist build. A fix for the AudioContext constructor should be rather straight forward.
When it comes to the issues with the stop event it seems to be thrown from the dependency soundfont-player. The plan is to move away from it though.
The error source is likely related to Safari's behavior for AudioBufferSourceNodes. stop() is marked to have unknown behavior on Safari (https://developer.mozilla.org/en-US/docs/Web/API/AudioScheduledSourceNode/stop) and Safari seems to be quite strict to how it's allowed to be invoked: https://stackoverflow.com/a/59653104/1308385. In this case I think it's most likely being called for an object which hasn't been started yet.
I'm afraid fixing that would need some extra logic to manage the audio nodes and keep track of which ones are in a state that allows stopping in Safari. I think it could be done in a more convenient way if I handled the more low level audio parts myself, which is one reason to the plan of moving away from soundfont-player.
But I could look into it a bit more since the stop method is accepting specific audio notes to be passed in. So saving them after schedule and then keeping track of which nodes are stoppable instead of stopping all should supposedly solve it.

@grosmanjs Will you please help me out with just verifying this supposed Safari fix? I've checked it in Browserstack and I think the initialization and stop events should be working: https://deploy-preview-32--osmd-audio-player-demo-vue.netlify.app/

Hi @jimutt, it's working now. With your demo, I can play and stop without any problems :)
When are you planning to release this fix?

Nice! Tried a few different options but found the standardized-audio-context package and decided to go with that. Seems like it solves most browser inconsistencies so no logic changes were needed.
I'll merge it to master now but might not publish a new version to NPM right away, will have it done soon though. To use it immediately before a new version is released you can reference the Github URL in your package.json:
    "osmd-audio-player": "https://github.com/jimutt/osmd-audio-player/"

Alright, thanks dude! :)

@grosmanjs 0.6.0 is published to NPM now


Streamline deployment

This is the second part of improving the dev environment. In the first part, I updated all the modules/libraries and we already merged that.

What we have here is that the deployment procedure is streamlined with a hardhat deploy module and all scripts for that are in /deploy folder. These scripts are also used for tests. In those scripts we also have verifying part which uploads code to etherscan clones and we have local data creation which creates mainet_deployed.json as well as tesnet_deployed.json.  For reviewing convenience I made  an example that I run locally with same code, left is current file, right is new file. https://www.diffchecker.com/5bS7YZxw/   structure and values are the same, there are minor differences in formating and also as I actually didnt deploy this there are no URLs to scan page and chain ID is different.
Also bare in mind that there are some code updates from currently deployed contracts so ABI is different in few places.

Also a note on codegen/generate_src.sh  file. Not sure if this  is correct but I suppose we don't need it, mainet_deployed.json as well as tesnet_deployed.json can be fully generated from TS code. We have saved ABI and the rest of the data for deployed BZZ and gBZZ which I put to reside in helper-hardhat-config.ts
If I am missing some logic here that is important please inform me, my logic is that this rarely changes, it can be stored as vars once deployed and reused in future deployments.  I could also retrieve it from chain and etherscan with saved deployed address and trx hash but seems to me obsolete in this case to make those calls.

I superficially checked the old deployer.ts and I would keep its console.log messages. The hardhat scripts multiple times change the same role that may need a refactor. there are multiple unused imports and other stuff that I commented below.

The reason for using log instead of console.log is we are using this library
https://github.com/wighawag/hardhat-deploy
where is a common way to log out info with that method.
About the roles, please give more info on that, I would gladly refactor what is needed.

The TestToken related changes can be sorted out in a different PR.
For roles, I meant e.g. PRICE_ORACLE_ROLE is set two times at postage and oracle contract deployments. This is useful when only one of the scripts is executed, but takes an additional unnecessary cost when the other script has run before. This is just a slight optimization in the code, it can happen later in a different PR.

ohh yeah, that is excellent remark, was thinking about that, but slipped my mind. Roles should be more streamlined and this has some obsolete code.

I am refactoring ROLES setters when deploying, tests are falling at this moment, so don't CR tests until I improve that.