tailscale: Fails to detect nftables firewall mode

Describe the bug
Tailscale fails to detect firewall backend using default heuristic mode. The NixOS Wiki also describes switching to nftables to fix IPv6 issues.
Steps To Reproduce
Steps to reproduce the behavior:

Set networking.nftables.enable = true; in NixOS configuration
Reboot to really get rid of iptables
Connect to tailnet
Check IPv6 connectivity using tailscale netcheck and journalctl -u tailscaled.service | grep 'router:'

Expected behavior
Tailscale uses nftables instead of iptables.
Additional context
Maybe we're just missing nftables binary dependency in tailscale/default.nix or enforcing nftables by setting TS_DEBUG_FIREWALL_MODE=nftables?
Tailscale's detectFirewallMode, using google/nftables <- mdlayher/netlink package, so no cli invocation
[user@system:~]$ journalctl -u tailscaled.service | grep 'router:'
tailscaled[3205]: router: using firewall mode pref
tailscaled[3205]: router: default choosing iptables
tailscaled[3205]: router: v6nat = true

Notify maintainers
@danderson @mbaillie @twitchyliquid64 @mfrw
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.69, NixOS, 23.11 (Tapir), 23.11.3684.f4a8d6d5324c`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixos-23.11"`
 - channels(user): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

We should not set TS_DEBUG envvars in normal configuration, like they name suggests they are debug settings whose meaning can change (or break) at any time.
From the source code of the logic that picked the behavior, tailscale's nftables mode is currently experimental and not enabled by default except one corner case. I don't think we should enable experimental code by default for nixos users.
The names "iptables mode" and "nftables mode" may also be misleading from the outside: it doesn't mean that it uses the iptables kernel facility, just that it shells out to the iptables binary. If you enable nftables, the iptables binary should be switching to the iptables-nft implementation, which translates the iptables invocations into nftables rules on the backend. So, the fact that the logs say "choosing iptables" doesn't mean nftables is not being used, just that tailscale is configuring nftables by shelling out to a binary, instead of using a netlink socket.
If the nixos module isn't giving tailscaled access to the appropriate iptables derivation when networking.nftables is enabled, that's definitely a bug we should fix. Aside from the misleading log statement, are you seeing any issues with how things run? If so, what?

I totally agree with not enabling experimental code by default! I have understood it like just use nftabels when available. However the used package description "This package is in very early stages(...)" does not does not assure much security.
I'm aware of these iptables to nftables fallback and can confirm the provided iptables derivation is working properly. On my system I've got these rule sets:
[user@system:~]$ nft list tables
table inet nixos-fw
table ip filter
table ip nat
table ip6 filter
table ip6 nat

So the obvious difference might be just insignificant chain names. Beside broken IPv6 exit node support. Maybe this is more an issue within Tailscale itself than setup or configuration.

For now, I think we want to keep using the iptables fallback, until upstream decides that the new netlink mode is ready for prime time. Hopefully soon!
It is normal that when you use iptables-nft, you end up with rulesets named similar to the legacy iptables rulesets. It should be harmless though, although I agree it will be nice when we can get rid of the legacy things :)
For your ipv6 issues, if you need help the best bet is to email<EMAIL_ADDRESS>and see if it's a known issue or if they recognize what you're seeing.


swap the data collator for evals if not using sample packing

when sample packing is enabled, but eval sample packing is disabled, we need to handle the data collator separately.

Does this resolve the error with using sample packing for training but not for evaluation? If so, could it be useful to add a test specifically for this scenario?

what error are you referring to? This should resolve an NCCL issue when there is a mismatch on multi-gpu

Does this resolve the error with using sample packing for training but not for evaluation? If so, could it be useful to add a test specifically for this scenario?

what error are you referring to? This should resolve an NCCL issue when there is a mismatch on multi-gpu

I remember there was an error when the validation size was too small. Then I swapped to using eval without sample packing and there was some other issue where it would not work.

I'll come back and add e2e tests for this once we have multi-gpu runners for CI.


Remove ARTIS sigma1 and ARTIS tau1 since they are dead #6720

Closes #6720

Also, need to edit README.md to remove the reference to Artis.

not sure if i can find it, could u please point me?

There’s a reference to “artis” in https://github.com/AlphaWallet/alpha-wallet-ios/blob/ef7aed2a1c375f16da841b71ea3412ce67280892/README.md


Make TxBodyContent an instance of Monoid

TxBodyContent is now an instance of Monoid, allowing things like

foo :: TxBodyContent BuildTx BabbageEra
foo = mempty { txValidityRange = someValidityRange }

bar :: TxBodyContent BuildTx BabbageEra
bar = mempty { txIns = someTxIns, txOuts = someTxOuts }

baz :: TxBodyContent BuildTx BabbageEra
baz = mempty { txOuts = someMoreTxOuts }

transaction :: TxBodyContent BuildTx BabbageEra
transaction = mconcat [foo, bar, baz]

@LudvikGalois Is @Jimbo4350's comment the only thing preventing from merging this PR?

@koslambrou I think so? I haven't come back to this because the reason I wanted it disappeared.

Hmm, this actually doesn't work.  For example when I try to rewrite TxBodyContent to mempty here:
  dummyTx :: TxBodyContent BuildTx era
  dummyTx = TxBodyContent {
      txIns = [( TxIn "dbaff4e270cfb55612d9e2ac4658a27c79da4a5271c6f90853042d1403733810" (TxIx 0)
               , BuildTxWith $ KeyWitness KeyWitnessForSpending )]
    , txInsCollateral = TxInsCollateralNone
    , txInsReference = TxInsReferenceNone
    , txOuts = []
    , txFee = mkTxFee 0
    , txValidityRange = (TxValidityNoLowerBound, mkTxValidityUpperBound 0)
    , txMetadata = metadata
    , txAuxScripts = TxAuxScriptsNone
    , txExtraKeyWits = TxExtraKeyWitnessesNone
    , txProtocolParams = BuildTxWith Nothing
    , txWithdrawals = TxWithdrawalsNone
    , txCertificates = TxCertificatesNone
    , txUpdateProposal = TxUpdateProposalNone
    , txMintValue = TxMintNone
    , txScriptValidity = TxScriptValidityNone
    , txReturnCollateral = TxReturnCollateralNone
    , txTotalCollateral = TxTotalCollateralNone
    }

I get the error:
src/Cardano/Api/TxBody.hs:2618:5: error:
    • Ambiguous type variable ‘build0’ arising from a use of ‘mempty’
      prevents the constraint ‘(Monoid
                                  (BuildTxWith build0 ()))’ from being solved.
      Probable fix: use a type annotation to specify what ‘build0’ should be.
      These potential instances exist:
        instance Monoid a => Monoid (BuildTxWith BuildTx a)
          -- Defined at src/Cardano/Api/TxBody.hs:1207:10
        instance Semigroup a => Monoid (BuildTxWith ViewTx a)
          -- Defined at src/Cardano/Api/TxBody.hs:1204:10
    • In the expression: mempty
      In the expression:
        mempty
          {txIns = fromLedgerTxIns era body,
           txInsCollateral = fromLedgerTxInsCollateral era body,
           txInsReference = fromLedgerTxInsReference era body,
           txOuts = fromLedgerTxOuts era body scriptdata,
           txTotalCollateral = fromLedgerTxTotalCollateral era body,
           txReturnCollateral = fromLedgerTxReturnCollateral era body,
           txFee = fromLedgerTxFee era body,
           txValidityRange = fromLedgerTxValidityRange era body,
           txWithdrawals = fromLedgerTxWithdrawals era body,
           txCertificates = fromLedgerTxCertificates era body,
           txUpdateProposal = fromLedgerTxUpdateProposal era body,
           txMintValue = fromLedgerTxMintValue era body,
           txExtraKeyWits = fromLedgerTxExtraKeyWitnesses era body,
           txProtocolParams = ViewTx, txMetadata, txAuxScripts,
           txScriptValidity = scriptValidity}
      In an equation for ‘fromLedgerTxBody’:
          fromLedgerTxBody era scriptValidity body scriptdata mAux
            = mempty
                {txIns = fromLedgerTxIns era body,
                 txInsCollateral = fromLedgerTxInsCollateral era body,
                 txInsReference = fromLedgerTxInsReference era body,
                 txOuts = fromLedgerTxOuts era body scriptdata,
                 txTotalCollateral = fromLedgerTxTotalCollateral era body,
                 txReturnCollateral = fromLedgerTxReturnCollateral era body,
                 txFee = fromLedgerTxFee era body,
                 txValidityRange = fromLedgerTxValidityRange era body,
                 txWithdrawals = fromLedgerTxWithdrawals era body,
                 txCertificates = fromLedgerTxCertificates era body,
                 txUpdateProposal = fromLedgerTxUpdateProposal era body,
                 txMintValue = fromLedgerTxMintValue era body,
                 txExtraKeyWits = fromLedgerTxExtraKeyWitnesses era body,
                 txProtocolParams = ViewTx, txMetadata, txAuxScripts,
                 txScriptValidity = scriptValidity}
            where
                (txMetadata, txAuxScripts) = fromLedgerTxAuxiliaryData era mAux
     |
2618 |     mempty
     |     ^^^^^^

Closing this PR in favour of some other strategy.  Ongoing work will be tracked by https://github.com/input-output-hk/cardano-node/pull/4941


Core plugins not updated at first install

Hi,
I'm using the 1.4.0 release of this module.
I'm using the plugin code like this:
include jenkins
The yaml file i've put the list of plugins as followed:
jenkins::plugin_hash:
credentials:
version:      '1.22'
I'm finding that only core plugins do not update
When puppet runs, it says it installed the plugin:
Notice: /Stage[main]/Jenkins::Package/Package[jenkins]/ensure: created
Notice: /Stage[main]/Jenkins::Plugins/Jenkins::Plugin[credentials]/File[/var/lib/jenkins/plugins]/ensure: created
Notice: /Stage[main]/Jenkins::Plugins/Jenkins::Plugin[credentials]/Exec[download-credentials]/returns: executed successfully
Notice: /Stage[main]/Jenkins::Plugins/Jenkins::Plugin[credentials]/File[/var/lib/jenkins/plugins/credentials.hpi]/owner: owner changed 'root' to 'jenkins'
Notice: /File[/var/lib/jenkins/plugins/credentials.hpi]/seluser: seluser changed 'unconfined_u' to 'system_u'
Info: /Stage[main]/Jenkins::Plugins/Jenkins::Plugin[credentials]/File[/var/lib/jenkins/plugins/credentials.hpi]: Scheduling refresh of Service[jenkins]
Info: /Stage[main]/Jenkins::Plugins/Jenkins::Plugin[credentials]/File[/var/lib/jenkins/plugins/credentials.hpi]: Scheduling refresh of Service[jenkins]
Info: Class[Jenkins::Plugins]: Scheduling refresh of Class[Jenkins::Service]
Info: Class[Jenkins::Service]: Scheduling refresh of Service[jenkins]
I've done some research and i discovered that jenkins creates the *.jpi files on startup. In the puppet class jenkins the jenkins service is started after the plugins are installed.
So when the plugins are installed no *.jpi files for the core packages are available and that means that no .jpi.pinned files are created by the following code when a plugin is installed
# create a pinned file if the plugin has a .jpi extension
#   to override the builtin module versions
exec { "create-pinnedfile-${name}" :
command => "touch ${plugin_dir}/${name}.jpi.pinned",
cwd     => $plugin_dir,
require => File[$plugin_dir],
path    => ['/usr/bin', '/usr/sbin', '/bin'],
onlyif  => "test -f ${plugin_dir}/${name}.jpi -a ! -f ${plugin_dir}/${name}.jpi.pinned",
before  => Exec["download-${name}"],
}

I believe that #389 should resolve the pinning issues.  I'm going to close this issue but please reopen it if this is still reproducible with the current master.


How to sort comments from submission by New

How do I sort a thread's comment by "new" or "top" or whatever?
Is there a CommentPaginator or something I can use?

I don't have too much experience using JRAW but I do see a CommentStream class extending Paginator. You should be able to create a comment stream and set the sorting on the stream.
CommentStream stream = new CommentStream(redditClient);
stream.setSorting(Sorting.NEW);

See PaginatorTest#309. Maybe someone else can chime in to confirm.

Thanks for the response zglazer but I found a solution before seeing yours. Here it is:
SubmissionRequest.Builder b = new SubmissionRequest.Builder(sID);
b.sort(CommentSort.NEW);
SubmissionRequest sr = b.build();
Submission submission = redditClient.getSubmission(sr);


Flutter Video Recording Problems

I've recently been testing the new video recording functionality added to flutter's camera plugin v0.2.0 (Flutter version 0.4.4) and I am running into inconsistent problems when I try to record a video using the supplied example on a few Android devices.
On a Samsung Galaxy S7 (Android Version 8.0.0):
I'm not getting any errors or exceptions but if I record a video and then navigate to the outputted .mp4 in my phone's directory, the file seems corrupted in that the audio and video are not in sync. The entire audio will play over the first frame of the video and then the video will playback with no audio. The quality of the produced video is also fairly low.
On a Google Pixel 2 (Android Version 8.1.0):
Again, no errors or exceptions thrown. When playing back the outputted .mp4 the audio and video are in sync, however the forward facing camera produces a video that is darker than normal. Again, video quality of the produced videos is fairly low.
I've also reached out to the Tengio team that contributed the pull request to add the functionality. I was wondering if anyone is aware of these issues or can offer advice on how to work around them. Thanks!
Output of the flutter doctor:
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel beta, v0.4.4, on Microsoft Windows [Version 10.0.16299.431], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[√] Android Studio (version 3.0)
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
[√] VS Code, 64-bit edition (version 1.23.1)
[√] Connected devices (1 available)

• No issues found!

Regarding the bad quality:
I suggested using better default values for https://github.com/flutter/plugins/blob/master/packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java#L408 but it was said that this is something for another pull request after it is merged.
So your option for solving this yourself: Fork the repository, change the values (the video bitrate is important) and use your fork instead - ideally create a pull request.

@Hixie

I figured out that the issue I was having regarding the video freezing on the first frame was a problem involving Android's native camera packages not working correctly with certain Samsung phones. The work-around mentioned by cybaker in this issue ended up being a decent solution.


Add new script 'ng update'

Feature Request
- [X] feature request

Description
When update the version of angular/cli, use ng update to update the configuration files like tsling.json and tsconfig.json etc. or and postinstall hooks to auto update the configuration files.

That would be great, but any of these things could have been manually changed. What if the author wants those changes preserved? Then any time angular-cli is upgraded their changes would be overwritten.
Currently when I upgrade angular-cli, I generate an entirely new project structure and then compare every file I can find against my own files, including:

versions in package.json
new packages in packages.json
.angular-cli.json
karma.conf.js
protractor.conf.js
tsconfig.json
tslint.json
src/polyfills.ts
src/test.ts
src/tsconfig.app.json
src/tsconfig.spec.json

It's some manual work but I'm not sure how this could be automatically done.

There are many issues that have as a root that developers do not update their apps properly, probably because they think that just changing the version in package.json is enough. One of the many issues that exist.

This is something that we talk about every now and then... It's true that a lot of issues are due to bad upgrades. Configuration items like the ones listed by @BurningDog could be upgraded automatically. A health check would also be nice, like verifying incompatible options or packages aren't set.


Hammerhead changes a behaviour of original XHR status code evaluation

What is your Test Scenario?
Looks like testcafe(or testcafe-hammerhead) evaluates some XHR statuses not like it happens in "real world". Here are the steps that my testcafe test performs:

Open a login page
Execute login with a valid creds
Wait until all resources are loaded up

After that I'm getting a "Server Error" popup inside my app because it thinks(front-end controller) that something went wrong and some of the XHRs have 403/404/500/504 error. If I execute the same steps in my browser or even in the same browser that was instanciated by testcafe but without using the testcafe-hammerhed proxy prefix I wouldn't see the same error. Why it happens: if you open the Network tab you will see that some of XHRs really got 403/404 errors and they were evaluated by testcafe-hammerhead.js. Response bodies has the error nodes as well. But in "real world" the same XHRs get 200 response code even though it has the same errors in response bodies. It happens because they were evaluated by VM or in other words - by custom/native script and they got its custom response codes.
What is the Current behavior?
Testcafe doesn't evaluate a response code of XHR like it would be evaluated in "real world". Some of XHRs get 403/404 errors because these request were executed and processed by testcafe separately from the app-custom script.
P.S. Real world - outside the testcafe proxy.
What is the Expected behavior?
Testcafe should emulate a native browser behaviour. Probably something related was fixed and discussed here - https://github.com/DevExpress/testcafe/issues/1973
Your Environment details:

testcafe version:                   1.8.3
node.js version:                    v12.16.1
command-line arguments: testcafe chrome <name_of_spec_file>.js
browser name and version: Chrome 80.0.3987.16
platform and version:          macOS 10.15.3 Catalina

This information is not sufficient to reproduce the issue. Could you please share a minimal project with us? We will examine it and check for a suitable solution.


[B] Fix item and collection layout loading issue

WIP
Current behavior:
Clicking tabs on item pages bumps user back to the top of the page.
Expected behavior:
Clicking tabs should only load the new page, and hero elements should not reload.
Technical Issues:
Each page runs a query that gets the layout data, including any header elements that appear on each child page. The item layout fragment isn't caching, or isn't caching in a way we expect. We can either:

Separate queries for the app/item layout and any child routes (pages, browse, etc)
Fix the caching issue

It's preferable if we fix the caching issue and make any long term improvements to the fragments rather than split queries. The backend currently gets around this by using getLayout. This fix attempts to use getLayout effectively in the frontend.

@1aurend This is a huuuuuge update, so the review here is for testing the frontend preview for any regressions.
Some of the major changes:

Wrapped item and collection routes in the layouts CollectionLayoutQuery and ItemLayoutQuery
Moved EntityLayoutFactory from other layout factories into CollectionLayoutQuery and ItemLayoutQuery. This is so heros and bar navigation doesn't reload when the sub route changes
Changed the page loading to only show a spinner if the LayoutQuery is loading. Child components take care of their own loading states


Default values for Int in driver schema are incorrect

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

Go to https://YOURHOST/v3/schemas/amazonElasticContainerServiceConfig.
Scroll down to "maximumNodes" field.

Result:
The values are all 0, but they should reflect how they are declared in the EKS driver:

Other details that may be helpful:
For Testing
When testing, kubernetes should be restarted to view the corrections in the schema. This is related to another bug: https://github.com/rancher/rancher/issues/17712
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
master branch 1/29/19

Observed the issue in v2.1.6 where the schema for amazonElasticContainerServiceConfig showed the defaults as zero
"maximumNodes": {
"create": true,
"default": 0,
"type": "int",
"update": true
},
"minimumNodes": {
"create": true,
"default": 0,
"type": "int",
"update": true
},

Tested with master build from Feb 7th. The schema for amazonElasticContainerServiceConfig showed the defaults correctly as below:


Problem when instantiating a exp: new Date('2021-01-01') in some situations

Hello everyone,
First of all, I don't really know if this is the correct place to post this, but the case is the following:
When instantiating a new Date() in the crhome console using javascript, for example, with the values '2021-01-01' the result is as it follows in the image bellow:

But, and correct if I'm wrong, the correct value should be, when considering that I'm from São Paulo - Brazil:

The differences between the environment of the two images above is:

In the first image we're using windows 8.1
In the second image we're using windows 10
-all the screenshots has been taked in the same location
Notice that the chrome versiong in the both of images are the same, 88.0.4324.104:

in windows 8:

in windows 10:

Relates to:
https://bugs.chromium.org/p/chromium/issues/detail?id=1169325

Relates to:
https://bugs.chromium.org/p/chromium/issues/detail?id=1169325

Sorry, this is not the right place for this issue—crbug is, and it seems like it's been filed there already.

Sorry, this is not the right place for this issue—crbug is, and it seems like it's been filed there already.


clang-analyzer: use current LLVM version

Fixes #349404 by updating clang-analyzer to the latest version of LLVM (which has https://github.com/llvm/llvm-project/commit/1be4db73642fa0658d3b1e1dad7ec95259d1d261).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:

clang-analyzer

Is there a reason to use LLVM 17 specifically here? The current default on most platforms is 18 and we have 19.

Oops! I thought it was the latest for some reason. I've updated it to just use llvmPackages now, as it seems to work fine with that (and means it should stay up to date).

Looks like you’ve accidentally reformatted the entire all-packages.nix file.

:facepalm: fixed, sorry!

I’m actually wondering why we have this package. Our main clang package ships scan-build, though we do patch it additionally in this derivation to respect NIX_CFLAGS_COMPILE. Does the scan-build in clang work? Maybe we should just move the patch into there instead if it’s necessary. cc @Mic92 who added the patch

@emilazy historically we had all clang tools in the clang-tools package. At some point clang started to have them as well in their own package but unwrapped. I think we should move the wrapper all to the clang package because we sometimes end up with the unwrapped version in devshells if both packages are included.

However this might cause a mass-rebuild, so maybe we want to merge this pull request before.

Thanks for the context. I agree on the correct direction forward and that it seems fine to merge this until that is achieved.


Laravel 11.23.5 Shift

This pull request includes updates for the recent minor version release of Laravel as well as updates to your package dependencies. Feel free to commit any additional changes to the shift-ci-v11.23.5 branch.
Before merging, you need to:

Checkout the shift-ci-v11.23.5 branch
Review all pull request comments for additional changes
Run composer update
Thoroughly test your application (no tests?, no CI?)

:warning: The Shift build servers run PHP 8.2. If you are running a different version of PHP you should run composer update locally to ensure you have the proper versions of your dependencies to reflect your PHP environment.


Restrict the valid identifiers to UUID4.

Change the regexp in order to be more strict and accept just UUID4:
Version 4 UUIDs have the form xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx
where x is any hexadecimal digit and y is one of 8, 9, A, or B.
Also:

Make tests pass with uppercase UUIDs
A little bit of refactoring.

@joelebwf Good point, I removed that part.


Fetch tags from publishing-api instead of content-api

When editing an edition, editors can select a "specialist sector" (which we call topics now). They are currently loaded from the content-api, which is deprecated.

This commit makes the form use the publishing-api to fetch all topics, via the linkables endpoint.
I'm reasonably unhappy with the LinkableTopics class as it does a lot of things and has a bunch of magic-looking strings in there. I've tried to mitigate that with some commenting. In the short-to-medium term our team will revisit this class (and similar in mainstream publisher and content-tagger) to extract some common functionality for the population of select-boxes.
Part of https://gov-uk.atlassian.net/wiki/x/FYCoBQ
Follow up will be to remove whitehall's dependency in the development repo, and remove the /tags.json endpoint in content-api.

Possibly beyond the scope of this PR, but would it be possible to store the content ids for topics against editions, instead of the topic slug? That way we don't need to look up the content id by base path in publishing api every time we do a publish or sync check

Yeah, I agree, that'll simplify a lot of things. I've made a follow up ticket for this here:https://trello.com/c/QYgPe6kn

👍


Timer API

Added a code which MME Containers can use. Application can initialize the library and can start getting callbacks based on timeouts.

Can one of the admins verify this patch?

I had some local changes which are updated here..I will raise new pull request.


Browser history has incorrect titles

I have defined:
<title ng-bind="MetaTags.title">Default title</title>

Let's suppose I have a state with title A defined, b with B and c with C.
When I enter my website and click a -> b -> c, then my browser history (when I right click the "Back" button in Chrome) is C and B.
It should be B and A.
I hope I'm clear :-)

I am not really sure what you mean, does the title not reflect the state title?

The title always reflects the state title.
However, the first entry in the browser history also has the title of the current state. It should have the title of the previous one.


Failed to execute: 'mcomix'

Describe the bug
Can't run mcomix3 via desktop file
To Reproduce
Steps to reproduce the behavior:

nix-shell -p "dex" --run "dex $(nix-build -A pkgs.mcomix3)/share/applications/mcomix.desktop"

Expected behavior
mcomix3 application started
Screenshots

Notify maintainers
@con-f-use

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: mcomix3
# a list of nixos modules affected by the problem
module:

Okay, have seen it, will look into it, but little busy right now. First glance it seems, that we need the nix store path in Exec=... and, while we're at it Icon=....

Absolute paths in desktop file break menu editing functionality in DE, and are undesirable. https://github.com/NixOS/nixpkgs/pull/68035#issuecomment-532710033
I suspect that current behavior is as expected.
Solution:
nix-shell -I nixpkgs=. -p dex mcomix3 --run "dex $(nix-build  -A mcomix3)/share/applications/mcomix.desktop"
... and it appears the real problem is that the executable is called mcomix3 not mcomix.


[REQUEST] Allowing custom color palettes to be used

Allowing the user to pass in custom color palettes into both the 'graph_view' and 'layered_view' functions.

Already a feature


[service] Do not parse app_info in service api

Let parsing app_info (resolving rpk path) be done in the mlops-agent, not here in ml apis

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #547. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.


[Question] Storing value for later reuse in select

Hi,
First of all, many thanks for your excellent library!
Suppose I have the following map:
{:tabs [{:id 1 :value "A"} {:id 2 :value "B"}]
:active-tab 2}

I would now like to select the tab whose :id is equal to :active-tab.
Is it possible to do so in one select query, or do you always need two queries for this (because you essentially walk down one level to :active-tab, then need to go up again, and then one level down again for :tabs)?
If not possible in one go, then it would be great if you could store the result of a subselect (perhaps even as a kind of "named variable"?) in order to later on reuse it.

Sorry for being so late on responding. Somehow this slipped by me.
Currently you would need to do two selections.... though in theory Specter is all set up to be able to do something like this. With collect-one you can capture values to be used by the transform-fn at the end, or in the case of selection to be part of the return. Navigators don't currently expose a way to access those collected values even though internally they're passing them around. I'll leave this issue open as I think about how such functionality might be exposed and whether that's a good idea.

Found a pretty elegant solution to this, with the new features required now in master. With the next release, the code to solve your problem looks like this:
(def data
  {:tabs [{:id 1 :value "A"}
          {:id 2 :value "B"}]
   :active-tab 2})

(select [(collect-one :active-tab)
         :tabs
         ALL
         (collect-one :id)
         (collected? [a i] (= a i))
         DISPENSE]
        data)
;; => [{:id 2, :value "B"}]

The collected? macro creates a filter function that takes in the collected values as input. The DISPENSE navigator drops all collected values for subsequent navigation (which in this case prevents the collected values from being part of the return).

Awesome, thanks!


[iOS] Installation Issue: 'React/RCTBridgeModule.h' file not found

This is the first time i am interacting with cocoapods. Thanks for any guidance.
I took the following steps in setting up react-native-heap-analytics.

npm install --save react-native-heap-analytics
sudo gem install cocoapods
pod setup --verbose
This is my Podfile

platform :ios, '9.0'
target 'displayer' do
use_frameworks!
pod "react-native-heap-analytics", path: "../node_modules/react-native-heap-analytics"
end

pod install

At this point i saw two warnings:
[!] The displayer [Debug] target overrides the HEADER_SEARCH_PATHSbuild setting defined inPods/Target Support Files/Pods-displayer/Pods-displayer.debug.xcconfig'. This can lead to problems with the CocoaPods installation
[!] The displayer [Release] target overrides the HEADER_SEARCH_PATHS build setting defined in `Pods/Target Support Files/Pods-displayer/Pods-displayer.release.xcconfig'. This can lead to problems with the CocoaPods installation

I followed https://stackoverflow.com/questions/18376416/the-target-overrides-the-other-ldflags-build-setting-defined-in-pods-pods to solve the issue.
When i try to build, RNHeamp.m fails because it imports RNHeap.h which imports 'React/RCTBridgeModule.h'. The error is 'React/RCTBridgeModule.h' file not found.

If it helps,
my RCTBridgeModule.h is in node_modules/react-native/React/RCTBridgeModule.h
and my RNHeap.h is in node_modules/react-native-heap-analytics/ios/RNHeap.h

Hi @YangLeoZhao sorry for the issue. Can you try adding these two lines to your podfile and re-run pod install?
https://github.com/negativetwelve/react-native-package-showcase/blob/master/ios/Podfile#L5-L6
If this works, I'll update the README. This information should be there

Hey @negativetwelve Thanks for the quick response.
pod install gives me the following error now.

[!] Unable to satisfy the following requirements:
React/BatchedBridge (from ../node_modules/react-native)required byPodfileNone of your spec sources contain a spec satisfying the dependency:React/BatchedBridge (from ../node_modules/react-native).
You have either:

out-of-date source repos which you can update with pod repo update or with pod install -->repo-update.
mistyped the name or version.
not added the source repo that hosts the Podspec to your Podfile.
Note: as of CocoaPods 1.0, pod repo update does not happen on pod install by default.

pod install --repo-update and pod repo update didn't help

Ah, I forgot to ask, what version of react-native are you running?

React/RCTBridgeModule.h this style of import is only available on react-native 40+

I am using react-native: 0.44.3

@YangLeoZhao did you by chance run react-native link on this package? Since you're using cocoapods, you should not have it under "Libraries" in the xcode sidebar and it should not be under "Linked Frameworks and Libraries" since cocoapods handles this for you

Another thing, make sure in your xcode schema, "React" should be listed above your application and "Parallelize Build" should be unchecked. This is all under the "Build" step when clicking on your application and hitting "Edit Schema"

Hey @negativetwelve, i didn't run react-native link and here is a picture of my build schema: http://imgur.com/a/HgHl4.

Here is a screenshot that shows both 'BatchedBridge' and 'Core' folders exists under node_modules/react-native/Libraries. http://imgur.com/a/lVZJt

If i run pod "React", path: "../node_modules/react-native", subspecs: ["Core"] it is ok, but if i run pod "React", path: "../node_modules/react-native", subspecs: ["BatchedBridge", "Core"] it complains about unable to satisfy the dependency: React/BatchedBridge (from ../node_modules/react-native)

Ahh, on your version, you don't need the BatchedBridge. does it run correctly without that?
Here's the changelog where they introduced that:
https://github.com/facebook/react-native/releases/tag/v0.45.1

Yoga is in your version so you should still need that as well

Great, we are one step closer! However, i am getting Apple Mach-O Linker (Id) Error now.
Btw i also noticed in the Podfile u linked, there was no use_frameworks! under target, am i suppose to remove that as well?

can you paste the error?
You can remove it, but I believe you'll need it if your project uses swift. The podfile I linked is for a demo app I use to test all the native modules I create so you can pull it and run the application on your machine if you want

@negativetwelve Thanks a lot for the help. Here is the error i get when i try to build http://imgur.com/a/jRUAX

the warnings (yellow) are actually okay, can you show the error (red)? Make sure to click on it so we can see the whole stack trace as well

This is prob what you wanted. http://imgur.com/a/9JBL5

Nvm i found the issue everything is working now! I just uninstalled package earlier that's why it was complaining. Thanks so much @negativetwelve really appreciate your help!

no problem! that's great to hear! glad I could help :)

Just to lend more support to this solution, I also ran into this issue, and it was solved by adding those two lines to my Podfile.
https://github.com/negativetwelve/react-native-package-showcase/blob/cff5ee1808b698f6b65c5aa6697f3b85a9e614d0/ios/Podfile#L5-L6
I needed to rename pod "Yoga" to pod "yoga" first before it built correctly, however.


1777 validate amendment number

Implements #1777
Also updated some change request form styles. Please check this closely for bugs, especially in the handleSave section there was a lot more logic I had to add than expected 🙇♂

When you add a new amendment and then edit the number, the UI will temporarily show correct as an update but a new one gets created. For example, if I create amendment 19, then realized it should have been 18, go to edit and change to 18 it will show ok on the UI but after a refresh both 18 and 19 will be visible and exist on the DB.

Damn, nice catch. I updated the mutation to accept the old rowId of the previous change request and use that to archive instead of the amendment.
Only small caveat I noticed is that if you edit a change request to a new amendment number, then try and reuse the old one it says it is taken until you refresh the page. Though I kind of think that could be it's own ticket if we see it as an issue.

@rafasdc can you check this out again when you have time, I think the edit change request amendment number issue is taken care of thanks.

The edit is still being weird for me, I can reuse a previous amendment number on the same screen before refreshing, seems the UI is updating properly but the DB is still not archiving or updating the edited amendment.

@rafasdc ah sorry about that 😓  I guess I had too many change requests and didn't notice. It was a couple issues, I needed to use the rowId for the change request plus it was using the wrong old_change_request_id in the postgres mutation itself.


contributors page not found

contributors page not found. please solve this bug

I worked on it please check and merge it

solved by #41


Initial barycentric Langrange interpolation

Implements barycentric Lagrange interpolation. Uses algorithm (3.1) from the
paper "Polynomial Interpolation: Langrange vs Newton" by Wilhelm Werner to find
the barycentric weights, and then evaluates at Gf256::zero() using the second
or "true" form of the barycentric interpolation formula.
I also earlier implemented a variant of this algorithm, Algorithm 2, from "A new
efficient algorithm for polynomial interpolation," which uses less total
operations than Werner's version, however, because it uses a lot more
multiplications or divisions (depending on how you choose to write it), it runs
slower given the running time of subtraction/ addition (equal) vs
multiplication, and especially division in the Gf256 module.
The new algorithm takes n^2 / 2 divisions and n^2 subtractions to calculate the
barycentric weights, and another n divisions, n multiplications, and 2n
additions to evaluate the polynomial*. The old algorithm runs in n^2 - n
divisions, n^2 multiplications, and n^2 subtractions. Without knowing the exact
running time of each of these operations, we can't say for sure, but I think a
good guess would be the new algorithm trends toward about 1/3 running time as n
-> infinity. It's also easy to see theoretically that for small n the original
lagrange algorithm is faster. This is backed up by benchmarks, which showed for
n >= 5, the new algorithm is faster. We can see that this is more or less what
we should expect given the running times in n of these algorithms.
To ensure we always run the faster algorithm, I've kept both versions and only
use the new one when 5 or more points are given.
Previously the tests in the lagrange module were allowed to pass nodes to the
interpolation algorithms with x = 0. Genuine shares will not be evaluated at x =
0, since then they would just be the secret, so:

Now nodes in tests start at x = 1 like scheme::secret_share deals them out.
I have added assert statements to reinforce this fact and guard against
division by 0 panics.

This meant getting rid of the evaluate_at_works test, but
interpolate_evaluate_at_0_eq_evaluate_at provides a similar test.
Further work will include the use of barycentric weights in the interpolate
function.
A couple more interesting things to note about barycentric weights:

Barycentric weights can be partially computed if less than threshold
shares are present. When additional shares come in, computation can resume
with no penalty to the total runtime.
They can be determined totally independently from the y values of our points,
and the x value we want to evaluate for. We only need to know the x values of
our interpolation points.

Wow, that's great work, thank you so much!
These performance improvements are very welcome, as the previous implementation was pretty much useless for "big" secrets (eg. > 2MB) because of its slowness.
I have merged this manually, as I actually got rid of the old interpolation method, because the absolute performance improvement for k < 5 did not seem big enough to warrant keeping the old code around, but thanks for being so thorough and paying such close attention to detail :)

Previously the tests in the lagrange module were allowed to pass nodes to the
interpolation algorithms with x = 0. Genuine shares will not be evaluated at x =
0, since then they would just be the secret, so:
Now nodes in tests start at x = 1 like scheme::secret_share deals them out.
I have added assert statements to reinforce this fact and guard against
division by 0 panics.
This meant getting rid of the evaluate_at_works test, but
interpolate_evaluate_at_0_eq_evaluate_at provides a similar test.

Good point!

A couple more interesting things to note about barycentric weights:

Barycentric weights can be partially computed if less than threshold
shares are present. When additional shares come in, computation can resume
with no penalty to the total runtime.
They can be determined totally independently from the y values of our points,
and the x value we want to evaluate for. We only need to know the x values of
our interpolation points.

That is very interesting indeed! Let's keep this in mind if we see good use case for it on the Sunder/CLI side.

Merged in<PHONE_NUMBER>c54581e27477fd868eee9a0d3127aa.


Check enabled/disabled by using getAttributes() for TouchableOpacity

Please correct me if I'm wrong with the understanding document.
I need to check the button (enabled/disabled) by using getAttributes(), but it seems the enabled value is always returned TRUE, even though I send prop disabled: TRUE to TouchableOpacity.
But I see it works with a View go with prop: pointerEvents="none".
I'm using RN 0.64 vs Detox 18.16.0
MacOS 11.3
iPhone 12 Simulator - iOS 14

@alon-ha, could you check, please, whether the logic for enabled property gets the value from the native view hierarchy code or we have some custom implementation there?
@hqdai, it might be that this is an implementation detail of a specific React Native component. If so, the fix is going to be very debatable and not straightforward. Get some patience with it, it might take longer to look into this properly.

@noomorph Yes, we are checking for the native view userInteractionEnabled
Can see in those links:
https://github.com/wix/Detox/blob/1e26e4b1d61fea47a6e690d8222dfaa48bf93b30/detox/ios/Detox/Utilities/NSObject%2BDetoxUtils.m#L304
https://github.com/wix/Detox/blob/4531220db9c22692df515c8ffe7fbbd7cd682e18/detox/ios/Detox/Utilities/UIView%2BDetoxUtils.m#L350

@alon-ha should we be inspecting a different prop, then? With disabled: true, it must leave a mark somewhere on the native side such that the view is not tappable. I presume with can be easily checked with xcode's hierarchy analyzer.

I think it's related to how react native "draw" TouchableOpacity view. Maybe it's a view inside another one.

@hqdai Did you find a way to resolve this problem, eventually?

No, not yet, please take a look at this, and consider to re-open this issue. Thank you <3

@hqdai has there been any movement on this issue? Do we know what the enabled property on a TouchableOpacity is mapped to?

This is indeed important because
<AnimatedPressable disabled={true}>...</AnimatedPressable>

won't work.

Any update on this issue?
I am facing this problem as well.

Has anyone been able to figure this issue out? I am having the same problem where a button that is disabled returns enabled=true when using getAttributes()


Enable deleting/disabling unused environment

What would you like to be added:
Why is this needed:

/assigne @nakabonne

/assign @nakabonne

(btw, this issue number 1997 is the year I was born)

Then it's supposed to be your from the time you were born 😁


Implement Runtime.getHeapUsage for hermes chrome inspector

Summary
I was looking at the hermes chrome devtools integration and noticed requests to Runtime.getHeapUsage which was not implemented. When implemented it will show a summary of memory usage of the javascript instance in devtools.

Changelog
[General] [Added] - Implement Runtime.getHeapUsage for hermes chrome inspector
Test Plan
Before

After

I realized most of the code is generated using tools/run_msggen. I was able to adapt the script to make it usable outside fb, except for the signedsource part. So someone will have to re-run the codegen in the fb repo. (cd ReactCommon/hermes/inspector/tools && ./run_msggen).
I also added support for including experimental commands to msggen since Runtime.getHeapUsage is considered experimental.

Hey, @janicduplessis, seems like update of the devtools version made the "params" field required for the resume command, breaking some internal tooling. Would it be possible to either implement the same command without upgrading the version or update codegen to make sure params field is optional?
I am reverting it for now, as we have a cutoff for internal tooling release in a hour :)

Sadly the command does not exist when using the current devtools protocol version. I checked and it was added after the params object to resume, so there is also no version that exist where it would work.
Would it be hard to update the internal tool to pass params? Other option would be to make the codegen check if params exist, but would cause lots of changes to the codegen output.

Would it be hard to update the internal tool to pass params?

It seems like we have quite a few tools that use this codegen as a source of truth, so probably it is better to modify codegen to check for optional param :)
Does input for the codegen specify whether the param is optional or not? I believe we can add this check to only apply when the parameter is not required, so it should be negligible here.

Actually it might be possible to address with minimal changes by checkout if all parameters are optional, then make the whole params object optional.

Does input for the codegen specify whether the param is optional or not? I believe we can add this check to only apply when the parameter is not required, so it should be negligible here.

Yep https://github.com/ChromeDevTools/devtools-protocol/blob/master/json/js_protocol.json#L641


Do not convert first char to upper on type names during code model construction

Types are sometimes created with an upper case type name and sometimes with a lower case type name. This has no functional effect on the resulting code, because the writers will do this, but the converted name can end up in the comment. The comment should follow the spec and should be stable as much as possible.
This pull request fixes spurious changes like in models/group.go in this PR https://github.com/microsoftgraph/msgraph-sdk-go/pull/523/files .

I'm looking into it. It seems the writers in some places inconsistently handle type names. I've located the issue with Python, looking into PHP now.

yes from what @ndiritu was telling me the PHP issues are a side effect of the PR I've just reverted. Do you mind rebasing for sanity please?


"Voineasa" is listed in the drop-down menu

Description:
"Voineasa" is listed in the drop-down menu alongside its corresponding county according to the law
Precondition:
The website is up an running.

Step 1
Type "Voineasa" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Voineasa, OLT".


Caching issue

Not passing because it looks like we might need to create the cache dir if it doesn't already exist?

Not passing because it looks like we might need to create the cache dir if it doesn't already exist?

Yes, stdpopsim does it using os.makedirs: https://github.com/popsim-consortium/stdpopsim/blob/28fb59f2cbd16794de257c5fda15d143c547853e/stdpopsim/genetic_maps.py#L102

We now create a cache directory, passes tests too. What do you think @hyanwong ?

Need to go now, but merge if you think it's OK.


Better test

UsePredicate and predicates modifier are intuitively hardher to get how to use from the current test.

[] State Fuzzing
[] Mock Contracts
[] Debugger

I will manage these tasks as #25


Duplicate Entry "Power Rename" from Microsoft PowerToys

Shell : v 1.8.1
PowerToys : 0.69.1
The entry Power Rename (a function included in Microsoft PowerToys) is added twice in Shell right click.
Right click on an empty space

Right click on a file

Please refer to this topic #210

Thanks a lot, i should have noticed  the other topic. My bad.


AddressBook.saveContract do not overwrite previously save contract address

AddressBook.saveContract should overwrite a contract address if called again with the same contract name and network name, currently it does not do so.

Fixed in #31


Where is moleculer's protocol? How to implement it in other language(go) ?

NATS is beased on go language. I think it should be easy implement moleculer-go.
But i can't find the molecular's protocol.

I'm working on API documentation of Moleculer right now. I plan to add protocol docs as well.
Currently you can check the protocol from the packets.js and from packets.proto

@icebob thanks

@roytan883 I created it: https://github.com/ice-services/moleculer/blob/master/docs/PROTOCOL.md

Published on site: http://moleculer.services/api-0.9/protocol.html


Staff View

Create a way for supervisors to only see their direct staff timesheet reports. Administrators can see all staff reports.

Created!


Automated cherry pick of #8322

Cherry pick of #8322 on cloud.
/cc  @Willyfrog

/release-note-none


14/controller cleap up

Coverage remained the same at 57.143% when pulling 3dfaaf48a51382f878a7c33ff795bba138b9d204 on 14/controller-cleap-up into 5cc4120800082df87a93fe9a95762d2cad6feae7 on master.

Coverage remained the same at 57.143% when pulling fd2e208bfd2ce6502fcd76c41570312e807176bf on 14/controller-cleap-up into 64788e4ebce894e368b52f09833d39ac56680114 on master.


resize disk space...

I'm fighting with command line since yesterday to resize the disk to apply the macOS 12.1 update.
with "hdiutil resize -size 80g -imageonly disk.img" I was able to increase the size but inside the VM I don't find the good command to extend the APFS partition
I was betting on "diskutil apfs resizeContainer disk0s2 0" but it's not working ...
any idea?

These commands have let me resize a disk inside a macOS VM hosted on ESXi.
sudo fsck_apfs -n -l /dev/rdisk1
sudo diskutil apfs resizeContainer /dev/disk1 0


compare to CvT

Hi
Thanks for sharing this good work. I'm curious about why the proposed loss function can outperform CvT, which contains a depthwise convolution that is capable to learn local features.

Hi @liyunsheng13,
Good question. It's also similar on the results of ResNet, where there are only convolution layers. We guess that the proposed loss acts as a regularizer, which helps both VTs and CNNs learn local features better, especially in the earlier epochs. You're right the convolutional layers are capable to learn local features. In our experiments, we can see only marginally or the same performance with longer training.

Besides, if you in our supplementary materials, we also show a figure about the training with different VTs on CIFAR-100.

It shows that the gain of our loss for the architecture with depthwise convolution is obviously less.

Got it. Thanks for your response.


Pull import date from database to report

Change from "generated at" to something like "uploaded at"

This will be fixed in #21 where I add update_at date for each sample


Revert "[SPARK-41765][SQL] Pull out v1 write metrics to WriteFiles"

This reverts commit a111a02de1a814c5f335e0bcac4cffb0515557dc.

What changes were proposed in this pull request?

SQLMetrics is not only used in the UI, but is also a programming API as users can write a listener, get the physical plan, and read the SQLMetrics values directly.
We can ask users to update their code and read SQLMetrics from the new WriteFiles node instead. But this is troublesome and sometimes they may need to get both write metrics and commit metrics, then they need to look at two physical plan nodes. Given that https://github.com/apache/spark/pull/39428 is mostly for cleanup and does not have many benefits, reverting is a better idea.
Why are the changes needed?

avoid breaking changes.
Does this PR introduce any user-facing change?

Yes, they can programmatically get the write command metrics as before.
How was this patch tested?

N/A

cc @ulysses-you

also cc @xinrong-meng , this is not a blocker but it's better if we can make it into 3.4.0.

thanks for review, merging to master/3.4!

+1 for reverting decision. Thank you, @cloud-fan and all.


Spam

"Please don't suggest adding sorting, grouping, and options.
There are already plenty of ugly managers with all of that."...Would be valid if you have minimal extensions; However, when you have dozens lack of grouping is unmanageable, so...You COULD suggest other tools, OR, you could listen to people who use your product...Seems pretty simple to me....

This is not a product, it's a free extension.  What kind of reasoning is that?
You like it? Use it. Don't like it? Find something else or build it.

Here, this extension looks good and has groups. We can't guarantee its safety though: https://chromewebstore.google.com/detail/extentie-extension-manage/bhjkadebkpcekfbjkkmcjhhlfidajfmi


add initial org mapping

What this PR does / why we need it
This PR computes the org mapping for all organizations
Checklist

[x] Update changelog in CHANGELOG.md.
[x] Follow deployment test procedure in the tests/manual_e2e directory and have a working branch.

@TheoBrigitte I made everyone admin for now because you need admin rights to be able to add datasources but we can change this :)


shell script to delete git branches

Below is the script which I'm executing but unable to succeed. the task is delete branch date specific
ECHO='echo '
for branch in $(git branch -a | sed 's/^\s*//' | sed 's/^remotes///' | grep -v 'master$'); do
if [[ "$(git log $branch --since "20 Jun 2021" | wc -l)" -eq 0 ]]; then
if [[ "$DRY_RUN" = "false" ]]; then
ECHO=""
fi
local_branch_name=$(echo "$branch" | sed 's/remotes/origin///')
$ECHO git branch -d "${local_branch_name}"
$ECHO git push origin --delete "${local_branch_name}"
fi
done

Help would be appreciated


Print timestamps when listing activations in CLI

From @nauerz-ibm :
During workshop of openwhisk Users asked for timestamps when doing wsk activation list.

closing as duplicate of #20.


feat: Sticky canvas implementation for DrawToSelect Canvas

Description
Improving UI logic for canvas used for draw to select to support larger(in height) applications.
Fixes #5364

if no issue exists, please create an issue and ask the maintainers about this first

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.

Test A
Test B

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: feature/sliding-canvas

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
54.85 (0.03)
36.86 (0.04)
33.91 (0.02)
55.44 (0.03)

:green_circle:
app/client/src/components/editorComponents/DropTargetUtils.ts
100 (10)
66.67 (0)
100 (0)
100 (11.11)

:sparkles: :new:
app/client/src/pages/common/CanvasArenas/CanvasDraggingArena.tsx
100
75
100
100

:sparkles: :new:
app/client/src/pages/common/CanvasArenas/CanvasMultiPointerArena.tsx
24.05
5.88
0
25

:sparkles: :new:
app/client/src/pages/common/CanvasArenas/CanvasSelectionArena.tsx
91.71
73.12
89.29
91.49

:sparkles: :new:
app/client/src/pages/common/CanvasArenas/StickyCanvasArena.tsx
100
100
100
100

:sparkles: :new:
app/client/src/pages/common/CanvasArenas/utils.ts
94.12
77.78
100
93.75

:sparkles: :new:
app/client/src/pages/common/CanvasArenas/hooks/useBlocksToBeDraggedOnCanvas.ts
95.5
92.19
86.36
95.28

:sparkles: :new:
app/client/src/pages/common/CanvasArenas/hooks/useCanvasDragToScroll.ts
97.67
88.37
100
97.62

:sparkles: :new:
app/client/src/pages/common/CanvasArenas/hooks/useCanvasDragging.ts
96.51
78.11
88.89
96.43

:sparkles: :new:
app/client/src/sagas/CanvasSagas/DraggingCanvasSagas.ts
98.61
71.43
100
98.48

:sparkles: :new:
app/client/src/sagas/CanvasSagas/SelectionCanvasSagas.ts
97.83
86.36
87.5
97.56

:x:
app/client/src/pages/common/CanvasDraggingArena.tsx
100
87.5
100
100

:x:
app/client/src/pages/common/CanvasMultiPointerArena.tsx
24.05
5.88
0
25

:x:
app/client/src/pages/common/CanvasSelectionArena.tsx
91.49
71.98
89.66
91.21

:x:
app/client/src/sagas/DraggingCanvasSagas.ts
98.57
71.43
100
98.46

:x:
app/client/src/sagas/SelectionCanvasSagas.ts
100
72.22
100
100

:x:
app/client/src/utils/hooks/useBlocksToBeDraggedOnCanvas.ts
95.41
92.19
85.71
95.24

:x:
app/client/src/utils/hooks/useCanvasDragToScroll.ts
97.67
90.7
100
97.62

:x:
app/client/src/utils/hooks/useCanvasDragging.ts
96.48
78.24
90.48
96.41

@marks0351
After delete and undo inside container the widget shifts.  https://www.loom.com/share/0f299069e3fa45ccac3387ac96ca3807 and https://www.loom.com/share/962ae38fa0d84a2fbdcbbd568171429b

@marks0351 2. When the widget is deleted from the bottom of the canvas the canvas do not update and white space is displayed.
https://www.loom.com/share/7f696a7f348d4b6c80bd8b66d0621801


Reverse

how to reverse the increment or decrement?

nvm, it can be done using rotated box, but it'll be good if it can be tweak at default


Can the search in the laionFace20M or laionFace50M?

Can it be search the API by the indice_name by laionFace (https://github.com/FacePerceiver/LAION-Face)?
Example:
client = ClipClient(
url="https://knn5.laion.ai/knn-service",
#indice_name="laion5B",
indice_name="laionFace50M",
aesthetic_score=9,
aesthetic_weight=0.5,
modality=Modality.IMAGE,
num_images=1,
)
At the moment it give me an error.

not possible but would be cool, please help creating these indices


How do I exit EMU

During the running of the script, there will be a case where the script is in an infinite loop, and then the script cannot be canceled at this time. How can I solve it?

In the case of not ending the process, because I want to see the log that has been run

g_objEmu = None
g_objTimer_StopEmu = None
NUM_TIMEOUT = 5 * 60      # 5分钟
def stopEmu():
    if g_objEmu != None:
        g_objEmu.stopEmulation()

g_objTimer_StopEmu = threading.Timer(NUM_TIMEOUT, stopEmu)
g_objTimer_StopEmu.start()

You can set the "verbose" variable for your EmuHelper object to 1 to enable debug logging of all emulated instructions from flare-emu, or 2 to also enable logging of thread context for each emulated instruction. flare-emu uses the logging Python module: https://docs.python.org/2.7/library/logging.html.

Thanks


Add proposer to MultisigExecutionInfo

Summary
This adds the MultisigTransaction['proposer'] from the Transaction Service as MultisigExecutionInfo['proposer'] (AddressInfo) for the client to reference for deletion. (Only the proposer can delete a transaction.)
Changes

Add proposer to MultisigTransaction entity (null pre-deletion integration)
Add validation for proposer to multisigTransactionSchema
Forward proposer in MultisigTransactionExecutionInfoMapper['mapExecutionInfo']
Add proposer to multisigTransactionBuilder
Add/update associated tests

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 93.649%

Files with Coverage Reduction
New Missed Lines
%

src/routes/transactions/entities/tests/human-description.builder.ts
4
60.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
6112

Relevant Lines:
6315

💛  - Coveralls


Consider using FROM instead of OF for conversions

Hello.
Reading the docs I was excited about the human readable first thing. That's why I am surprised to see book.ofInt rather than Bool.fromInt. Isn't the latter easier to read and understand ? What is the motivation?
Maybe you can just provide aliases ?

Thanks for opening the issue danielo515.
My reasoning was:

ofX is already a convention in OCaml's standard library (Float.of_int)
of is shorter than from

I would rather provide a single function than creating aliases.
I'm not super attached to of though, and could be convinced from is the way to go.

Well, I can't argue against a language idioms. It is just that from feels more human and less academic. Probably it has something to do with the fact that English is not my main language.
Thank your for providing your reasoning.
If nobody else wants to say anything you can close the issue whenever you consider

@danielo515 we are going to merge the repository with https://github.com/darklang/tablecloth, and in doing so, adopt the fromType / toType convention. @sarna did you disagree with this?

@Dean177 I just like the foo_of_bar idiom more, is all :)

@danielo515 we are going to merge the repository with https://github.com/darklang/tablecloth, and in doing so, adopt the fromType / toType convention. @sarna did you disagree with this?

Awesome!

Yes

Over the next couple of weeks the extra functionality will be ported over


Ability to have camera pass-through for Mixed Reality glasses

I've been plugging away on my AR app for a while, was getting close to done, but now I'm worried about compatibility with all the "Mixed Reality" devices coming next month.  I've been designing with the Hololens in mind, and being able to see your room and real surfaces and mapping on top rather than a VR house, but the more I look into the Mixed Reality Portal, it seems like our Unity apps will run in the Lake House environment rather than what the camera sees in front of you.  I don't have my glasses until the 17th, but would like to know how this gets handled and can't find the info anywhere.
Do we have to code something special to project the right and left cameras as the video background for the two eyes and align it up to the spatial mapped surfaces in real world, or is that automatic to simulate how a Hololens works?  My app would not be the same in a psudo MR world without the Augmented part of it.
I found that Vuforia supports the camera projection to left and right eye with some setup, but would rather not have to go that route if I can do it with the MixedRealityToolkit, or if there's something that I'm missing.. I prefer the Hololens way of AR much better, but I know that the majority of users will be on the cheaper consumer devices, so we gotta make it work.  Thanks..

@Skquark Unfortunately there is confusion with the terminology of Mixed Reality and how the immersive headsets compare to the HoloLens. These new $300 headsets are basically VR headsets. There is no passthrough capability. The cameras on the front are depth sensors like the HoloLens (so you don't run into a wall), but you won't be able to see through. Experiences on these devices are totally virtual. The Mixed Reality terminology refers to the "spectrum" of realities from physical to purely virtual and everything in between. Microsoft is set on using this term. While it is accurate, there are too many expectations that these cheaper headsets have similar functionality to the $3,000 HoloLens and that just is not the case. They share the sensor technology, much like the kinect, but the immersive headsets do not have AR capabilities.

Damn, that's what I was afraid of... So to make our Hololens applications function on the Mixed Reality headsets, we would have to emulate a fake room like in the editor's SpatialMapping component's Room Model, and we build a 3D set to match the room mesh surfaces?  Or are we limited to only use Microsoft's Lake House in the portal to place our objects into?  Trying to figure out how to adapt to this in-between fake AR and still provide a functional experience.. When I first saw the headsets I was all excited thinking they would give a similar experience to the Hololens by faking the real world in the black transparency with the camera view aligned, and I hope we'll have a workaround in the near future.
So what parts of the Toolkit won't work with the consumer headsets?  Can we still use the SpatialProcessing to create surfaces from scanned or fake mesh?  Are the Anchor Manager locations based on physical points or virtual points?  Are we forced to use the Boundaries to fence our workspace in VR?  Will there be a way to port our MRTK development project to Tango or Apple ARKit since those are made for real-world augmentation with the camera?  Sorry for all the questions, but I haven't found these dev issues covered clearly anywhere.. Just when I thought I was in the home stretch for releasing my app, I gotta worry about being compatible with every other device since most people are not going to invest $3000 vs ~$300, and I would hate to see all the hard work I've put in only work for the rich.....

it seems like our Unity apps will run in the Lake House environment rather than what the camera sees in front of you.

This is not true.  The HoloLens workflow and experiences are not changing.  We're just adding the VR headset support to the toolkit.  You shouldn't see much of a change as far as the look and feel of HoloLens apps.

That's reassuring to hear, glad the VR headset features will be integrating soon.. What should I be planning for to adapt my app (which relies on the generated surface planes) to work best on the Mixed Reality headsets? When the VR support is implemented, will we still be scanning the room and generating the world mesh with access to the cameras that we can project in the background view? Or do we skip the spatial scanning and load up a decorated room or house environment with the Surface Planes set static?
Just trying to get a jump on the workflow since millions of people are about to have a new toy in their hands in a few weeks, and we're all trying to give them something tangible to play with..  Can't wait to see everyone else's projects here out in the wild when the time comes, a new paradigm is being born..,

Didn't Microsoft just announce an in-library method for determining the hardware capabilities to allow developers to understand what type of platform they are running on?  Immersive or see-through?

Unity did.
HolographicSettings.isOpaque


AsyncForEach

Currently it's possible to create a foreach-statement with CodeGenerator.ForEach, but it's not possible to create an async foreach-statement.
Suggestion
Create a new method in CodeGenerator named AsyncForEach that does the same as ForEach but for IAsyncEnumerable.
Example
C#
IAsyncEnumerable<string> elements;

async foreach (var element in elements)
{
	// use element
}

DotNext.Linq.Expressions
Expression elements;

CodeGenerator.AsyncForEach(elements, element =>
{
	// use element
});

The actual statement is await foreach, not async foreach. This statement is already supported, take a look at this doc.

The actual statement is await foreach, not async foreach. This statement is already supported, take a look at this doc.

Oops, seems like it was a long day that I didn't notice this 🤦♂. Thanks!

Oops, seems like it was a long day that I didn't notice this 🤦♂. Thanks!


Auto add filtered entities to graph

Hello,
thanks for the awesome add-on, this is much needed!
I see there is the option to filterEntities config options, but I was curious if there was a way to automatically add all the filter options to the graph. My use case is with the hass docker monitor add-on, I would love to chart the CPU / Memory of each of my containers. but it is annoying to have to manually add each sensor to the chart. It would be awesome to be able to take the filtered entities lists and "add all" of them to graph.
Thanks!
Joseph

Type * into the entity selector field and hit +. This will add all entities that match the current filter(s).

Oh, that is helpful, thank you for that info!

Does this solve this issue and can it be closed ?


WIP general: fix LESS_RUN_IN_DEBUG behaviour

Allows LESS_RUN_IN_DEBUG to have effect for more than one
reload.  (fixes #2777)

Signed-off-by: Jacopo Notarstefano<EMAIL_ADDRESS>(CC: @jmartinm)

@jacquerie what is the status of this pull request? Did @jmartinm or @bouzlibop test it?

I spoke with @jmartinm and I know he didn't. I don't know about @bouzlibop. In any case, this has low priority for me, since it won't fix the real issue I have: generating the source maps for easier debugging.

I gave it a try, but it seems that it's not working for me. Instead of previous behaviour I'm getting this error:

Ugh, I was able to reproduce that error for one reload, but now I see it running on every reload.

I can confirm I get the same error as @bouzlibop
The correct logic here is to leave:
bundle.filters = None

As we don't have to apply any filters on the server side (run lessc) when running in debug mode (all the work is left for the client side less.js).
Somehow this is what is breaking the code on the client side (see the wrong URL in the screenshot: http://gen/invenio.css)
Now the problem I can see here is the following:

First time the code runs, this condition is True so the page has the correct rel=stylesheet/less and all is good.

Second time the code runs (after page refresh), the bundles have been cached here so for the same invenio.css Bundle now this condition is not True because we have set previously here filters to None so the page has rel=stylesheet and less.js does not compile those assets.

@jirikuncar maybe it would be best when running in DEBUG mode to not do any caching? Suggestion on where to do the changes?

Thanks @jirikuncar . I have created a new PR https://github.com/inveniosoftware/invenio/pull/2864 which works for me.

Tested, and working for me.

Working, for me too :+1:

Closed by #2864, I guess.


Allow editor to access Flarum search query results

When using the native editor, Flarum will perform a search for users and posts when entering @. It will also perform a search for emoji when entering :. It would be nice to not lose this functionality when this plugin is enabled.

New version has this feature man!


How to cache queries based on URL (e.g. using cloudflare)?

Is it possible to configure the middleware to receive request data as URL parameters instead of in the body?
I'm looking to make use of cloudflare's URL caching for some of my request endpoints, but if the body must be used, it's a non-option.

hi @faceyspacey
we've introduced GET support on latest version,
so basically you can now send GET requests to the server,
as far as i know, cloudflare's should cache them.
please give it a try and update here ;)

Yup, this is entirely dependent on the type of HTTP request. See the HTTP 1.1 RFC (specifically Section 13, which describes caching correctness) for more details on when HTTP caches will cache the request.


Improve the interactive menu

This adds a > at the end of the message to denote the program is waiting for user input.
This also tweaks colors for better readability.
Preview

TravisCI checks aside, LGTM. Tested on RHEL 7.x and CentOS environments. Example pictures should be updated if this pull request is approved to reflect the new menu changes.

Going back to this for a bit since it hasn't been merged in yet, and I'd like to include it. I started testing it on different terminal window themes, and on light themes, the cyan gets a bit washed out. In the currently implemented theme, the yellow tends to get washed out on light themes. So I started thinking about how we could possibly add different themes for people, as it could help greatly with accessibility and people who have issues seeing certain colors.
I was thinking it could just be a global variable a user can set akin to how we are already doing it with _GIT_SINCE and _GIT_UNTIL. Example code I'm thinking of in my head on how it could work:
function show_menu() {
    local normal=$(tput sgr0)
    local bold=$(tput bold)
    local cyan=$(tput setaf 6)
    local red=$(tput setaf 1)
    local yellow=$(tput setaf 3)
    local white=$(tput setaf 7)
    local titles=""
    local text=""
    local nums=""
    local help_txt=""

    if [[ "${THEME}" == "light" ]]; then
        titles="${cyan}"
        text="${white}"
        nums="${bold}"
        help_txt="${cyan}"
    else
        titles="${red}"
        text="${white}"
        nums="${yellow}"
        help_txt="${white}"
    fi

    echo -e "\n${titles} Generate: ${normal}"
    echo -e "${nums}   1)${text} Contribution stats (by author) ${normal}"
    echo -e "${nums}   2)${text} Git changelogs (last $_limit days) ${normal}"
    echo -e "${nums}   3)${text} Git changelogs by author ${normal}"
    echo -e "${nums}   4)${text} My daily status ${normal}"
    echo -e "${titles} List: ${normal}"
    echo -e "${nums}   5)${text} Branch tree view (last $_limit)${normal}"
    echo -e "${nums}   6)${text} All branches (sorted by most recent commit) ${normal}"
    echo -e "${nums}   7)${text} All contributors (sorted by name) ${normal}"
    echo -e "${nums}   8)${text} Git commits per author ${normal}"
    echo -e "${nums}   9)${text} Git commits per date ${normal}"
    echo -e "${nums}  10)${text} Git commits per month ${normal}"
    echo -e "${nums}  11)${text} Git commits per weekday ${normal}"
    echo -e "${nums}  12)${text} Git commits per hour ${normal}"
    echo -e "${nums}  13)${text} Git commits by author per hour ${normal}"
    echo -e "${titles} Suggest: ${normal}"
    echo -e "${nums}  14)${text} Code reviewers (based on git history) ${normal}"
    echo -e "\n${help_txt}Please enter a menu option or ${bold}press enter to exit. ${normal}"
    read -r opt
}

We could then update the documentation and possibly add screenshots to show different themes available to the user. Thoughts?

@tomice Sounds good to me. Unfortunately, there's no real standard I know of when it comes to setting application-specific themes in CLI applications. Detecting the background color is possible, but it's not particularly trivial (see https://github.com/vim/vim/issues/869).

I think the two themes (current one and the proposed one in this PR) would be sufficient for a basic implementation at the moment. If more users would like to see this expanded, be made more intelligent by detecting current terminal colors, and whatnot, then I may further investigate on how something more complex could be implemented. Or someone who might already know could make a PR and do it, as well.

Let me know your thoughts on this latest commit I just pushed to your fork @Calinou and if it looks okay to you.

The default theme's text appears darker, is this intended?
Default theme

Alternative theme

I redid it with another terminal application on a different system as WSL isn't showing me the full color range of tput. I think they're closer now, but if you got a moment, could you double-check to make sure everything looks okay?

The alternative theme looks good now, but the default theme's colors look all over the place to me. The main intent of my PR was to use less distracting colors (and avoiding red/yellow as these tend to be used for errors and warnings).

When you say that the colors are "all over the place," do you mean that there is an extreme diversion from the original theme vs the one in this modified PR, or do you just vastly prefer the alternative theme to the original theme? I'm having a hard time following where there are issues at the moment. Here is what the default theme looks like on OS X for me:

Here is what the default theme looks like in WSL for me:

And here is the original theme from v2.0.4:

I now see there's an issue with "Suggest:" having a weird looking colon after it after reviewing these screenshots. The white help text (Please enter a menu option...) was intentional, but that can be changed to be more akin to how the original theme if feel it is too much of a diversion and makes things look too weird.

When you say that the colors are "all over the place," do you mean that there is an extreme diversion from the original theme vs the one in this modified PR, or do you just vastly prefer the alternative theme to the original theme?

I meant the latter :slightly_smiling_face:

Newly proposed theme now the default theme. In order to go back to the old theme, _MENU_THEME will need to be set to legacy for those who prefer it. It's hard to say if users will prefer this or not since we don't have any A/B testing, but your comment on leaving red text exclusive for errors is a solid reason for experimenting with other color schemes, IMO. Double-check everything and make sure it looks kosher if you got a moment.

Looks good to me! Thanks :smiley:

I tried 2.0.8 now, and the colors are very unsuitable for light-themed terminals, apparently.  For my default the menu options have exactly the same color of text and background.  With xterm it's not as bad, but still not well usable.

@vcunat Shouldn't light terminal themes display white colors as black (and vice versa)?

I have no idea how colors on terminals work :woman_shrugging:

In the README.md, there is a section on color themes. It shows how to revert back to the original theme should you wish to do so. You can put this in your .bashrc if it is something you would like all of the time.


iOS 无法选择文本后播放

iOS 上选择文本后点播放无效果。
下面是用 AI 找到的解决办法，亲测有效：
Unfortunately, there is no direct way to get the selected text in Safari on iOS as it is not currently supported by the JavaScript API. However, you may try to implement a workaround by creating a custom selection mechanism within your web page. Here is an example of how you can achieve this:
document.addEventListener("touchstart", function(e) {
  // Initialize the start position of the touch
  var start = e.touches[0].clientX;

  document.addEventListener("touchend", function(e) {
    // Get the end position of the touch
    var end = e.changedTouches[0].clientX;

    // Check if the touch was a swipe
    if (start > end + 5) {
      // Get the selected text
      var selection = window.getSelection().toString();

      // Do something with the selected text
      console.log(selection);
    }
  });
});

In this example, we are using the touchstart and touchend events to detect a swipe gesture. When a swipe is detected, we use the window.getSelection().toString() method to get the selected text. Note that this will only work if the user swipes to select text within the web page.

牛，确实是我没测试到的地方，这就修复。谢谢

啊，我还想问一下，你在iOS端看的是哪部影片，因为我看手机端豆瓣通常都是不需要选择的，因为标题都是正常的不像电脑端豆瓣会夹杂外文。


Support Python 3.11

Git made breaking change related to file ownership, so this had to be silenced.
There were a couple of places where 3.6 was still referenced. Those have been removed.

CC @xuanwang-amos


Relax FFT tests tolerance

This PR relaxes the FFT tests tolerance. It seems that Cuda and FFTW do not provide consistent results from one machine to another (even using the same software versions).
Changelog:
Fix FFT tests tolerance

For info the tests used to pass on my computer


Bug: Mark as unread not being synced on web and mobile app platforms @chauchausoup

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to any chat on web
Press Mark as unread
Check mobile app LHN

Expected Result:
Mark as unread should have been synced in mobile app too from web.
Actual Result:
Mobile apps doesn’t shows BOLD headline in chat users
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android

Version Number: 1.2.11-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
https://user-images.githubusercontent.com/43996225/193432493-f804c1da-f90d-4a1a-8da2-081283a9b442.MP4

Notes/Photos/Videos:
Expensify/Expensify Issue URL:
Issue reported by: @chauchausoup
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1664606700652429
View all open jobs on GitHub

Was able to repro!

Gonna look tomorrow

Discussed this with Marc and albeit it is not instantaneous, it works after a while when the chats sync, I have confirmed that. I dont think this is something super valuable to work on right now since it works with some delay which depends on when the app syncs new chats. Gonna close this one out.

@mountiny here at my end not even a time delay but the issue is there even on multiple refresh of both web and mobile platforms.
Don't you think thats a bug, that even on refreshing both platforms multiple times the mark as unread is not being synced ?

@chauchausoup I wasnt able to reproduce unfortunately :/ for me it syncs fine after couple seconds. However, this can depend on internet speed I am sure.
Additionally we have an internal initiative which will refactor how the logic of unread (amongst other things) works so I would prefer not to dig into this, until that is done. And we also reworking how notifications are handled which might also touch this codebase.
Once the project is finished, we can come back to these and see how consistent they are to reproduce

@mountiny similar issue is being recognized by internal testers too in here: https://github.com/Expensify/App/issues/11951

Hmm I think the issue you have linked is quite different than this one


＜＞Fragments instead of divs ＜/＞

Issue
So one issue I've run into was getting console erros saying that div's can't be a child of a paragraph tag or anchor link etc. Would it be possible to render a fragment instead of a div so that one could edit only the text and not the HTML structure of an element?
Potential Solution
Another thought is similar to how React Bootstraps component library allows you to pass an "as" prop and you can render the prop as whatever element you choose.
<EditTextArea as="p" name="sectionTitle" onSave={updateValue} />
Which then outputs a paragraph tag that then becomes editable for just the content.
Let me know if clarification is needed.
Kudos
Awesome package by the way!

Hi Christoph,
Thanks a lot for your constructive feedback.
I will definitely consider this issue for the next update!
Regards,
Brian.

Sounds good! Let me know if I can help, I'd be happy to contribute if wanted/needed!

Sounds good! Let me know if I can help, I'd be happy to contribute if wanted/needed!

Please feel free to be the first contributor to this open-source package! 🥇

Did not even see this response or I would have jumped on it!

@christoph-codes Hey, no worries.
Just hold on a bit before starting anything as i'm currently working on refactoring the whole project.
I'm migrating from classes to functional components using React hooks.

Perfect! Let me know if I can help in anyway!

Hey @christoph-codes
Please feel free to start contributing as https://github.com/bymi15/react-edit-text/pull/23 has been merged just now!
For this issue you raised though, now that I think again I'm not sure of a good use case for why the EditText or EditTextarea component would be a child of
 or  tags.
Although, what would make more sense is to be able to provide a render function for the display mode.
For example,
<EditText renderDisplay={(value) => {value}}/> showEditButton
which would allow for an editable and clickable URL component.

Gotcha. So the use case that we had before is let's say styling is handled on the element being rendered and we want that text editable, the issue comes when that element, let's call it a p tag for now, now injects a div into a p tag which renders incorrect HTML markup and could eventually effect the styling.
If I style the p tag we would assume the styling gets inherited inside the injected div... but to be more specific we would need to style the p > div...
By rendering nothing the injection just adds the fragment to add the edit text functionality but doesn't eliminate the native styling...
Does this make sense?

Yeah that makes sense. You can have a go at implementing this and raising a PR.
But U guess my example above also covers your usecase since you can pass in whatever element you wish in the renderDisplay function.

 I was looking at something else in your example and overlooked the solution!


bond: fix to match the mac address with appropriate interface

When running 'os-net-config -i' getting below error ERROR os_net_config.objects.mapped_nics mac
f8:f2:1e:03:a5:c2 not found in available nics
Fixing the path of the appropriate interface.

Without the changes we get below error
[cloud-admin@compute-1 ~]$ sudo os-net-config -i
2024-12-23 13:24:04.207 ERROR os_net_config.objects.mapped_nics mac f8:f2:1e:03:a5:c2 not found in available nics (eno1, eno2, eno3, eno4, enp4s0f0np0, enp4s0
f1np1, enp6s0f0, enp6s0f1, enp6s0f2, enp6s0f3, enp130s0f0, enp130s0f1, enp130s0f2, enp130s0f3)
2024-12-23 13:24:04.247 WARNING os_net_config.objects.mapped_nics no mapping for interface enp130s0f1 because nic10 is mapped to enp6s0f3
{"nic1": "eno1", "nic10": "enp6s0f3", "nic11": "enp4s0f0np0", "nic12": "enp4s0f1np1", "nic2": "eno2", "nic3": "enp130s0f0", "nic5": "enp130s0f2", "nic6": "enp
130s0f3", "nic7": "enp6s0f0", "nic8": "enp6s0f1", "nic9": "enp6s0f2"}
[cloud-admin@compute-1 ~]$
After the change the output is as below
[cloud-admin@compute-1 os-net-config]$ sudo os-net-config -i
{"nic1": "eno1", "nic10": "enp6s0f3", "nic11": "enp4s0f0np0", "nic12": "enp4s0f1np1", "nic2": "eno2", "nic3": "enp130s0f0", "nic4": "enp130s0f1", "nic5": "enp130s0f2", "nic6": "enp130s0f3", "nic7": "enp6s0f0", "nic8": "enp6s0f1", "nic9": "enp6s0f2"}
[cloud-admin@compute-1 os-net-config]$


Lock the stack and use the same working thread to set/get attributes

!!!!!!!!!! Please delete the instructions below and replace with PR desription
If you have an issue number, please use a syntax of
Fixes #12345 and a brief change description
If you do not have an issue number, please have a good description of
the problem and the fix. Help the reviewer understand what to expect.
Make sure you delete these instructions (to prove you have read them).
!!!!!!!!!! Instructions end

The current PR failure logs has been expired and cannot see what errors happened in workflow.  I'll create a new one to replace it.

It seems that all workflow passed except "Cirque" . However, I think this failure has nothing to with this PR, so I approved and merged it.


provide noVerify input param

I am using this great github action to upload an extension for both openvsx and vsce. In my extension I need the setting enableProposedApi: true because I use the Noteboook Api. However, when publishing, this setting is blocked by vsce and noVerify must be explicitly enabled.
According to vsce#469 this setting is also the suggested solution
The best solution would probably be to be able to directly specify all possible parameters for both ovse and vsce.
- name: Publish to Visual Studio Marketplace
      uses: HaaLeo/publish-vscode-extension@v0
      with:
        pat: ${{ secrets.VSCE_TOKEN }}
        registryUrl: https://marketplace.visualstudio.com
        extensionFile: ${{ steps.publishToOpenVSX.outputs.vsixPath }}
        vsceOptions:
            noVerify: true
        openvsxOptions:
            ...

But if I read the api of @action/core correctly, only string is supported here and implementing the solution seems rather complex.

Hi @AnWeber thx for raising this feature request. I also searched the docs and it seems it is only possible to pass string values to the actions/core API.
I think there are two main options here:

Passing in the vsce options as stringified JSON and parse them during runtime. This would allow us to clearly seperate between openvsx and vsce specific options. However, imho I think passing a JSON datastructure could be quite error prone and is quite unintuitive.   - name: Publish to Visual Studio Marketplace
     uses: HaaLeo/publish-vscode-extension@v0
     with:
         pat: ${{ secrets.VSCE_TOKEN }}
         registryUrl: https://marketplace.visualstudio.com
         extensionFile: ${{ steps.publishToOpenVSX.outputs.vsixPath }}
         vsceOptions:  '{"noVerify": true}'
         openvsxOptions: '{}'

Introduce noVerify as top level option. Then vsce and vsx options will be mixed up at top level. I think this approach fits better into the specification of GitHub action inputs. And maybe we could clearly name it as vsceNoVerify or similar.   - name: Publish to Visual Studio Marketplace
     uses: HaaLeo/publish-vscode-extension@v0
     with:
         pat: ${{ secrets.VSCE_TOKEN }}
         registryUrl: https://marketplace.visualstudio.com
         extensionFile: ${{ steps.publishToOpenVSX.outputs.vsixPath }}
         noVerify: true

I also thought of variant 1, but I don't find it a nice api. I would implement variant 2, but extends ActionOptions
import { IPublishVSIXOptions as VSCEPublishOptions } from 'vsce';
import { PublishOptions as OVSXPublishOptions } from 'ovsx';

export interface ActionOptions extends OVSXPublishOptions, VSCEPublishOptions   {
    dryRun: boolean;
}

The ActionOptions interface is meant to represent only the inputs of this GitHub action. When I originally implemented this action I thought it would be good practice to align the action's inputs with the ovsx CLI.
When we now extend the interface as you suggested, the interface suggests that all those options are valid inputs to the action, although they may are not. Therefore, I would like to keep the interface as restrictive as possible and only indicate inputs which are truly supported by the action.
So maybe something like this:
export interface ActionOptions extends OVSXPublishOptions   {
    dryRun: boolean;
    noVerify: boolean;
}

or even completely decouple the interface from the ovsx CLI options:
export interface ActionOptions   {
    dryRun: boolean;
    extensionFile: string; // ovsx's extensionFile option for backwards compability
    // ... many more
    noVerify: boolean;
    web: boolean;  // Must be added to the acion.yml file as well.
}

"When we now extend the interface as you suggested, the interface suggests that all those options are valid inputs to the action"
yes, that was intentional:-) But if it should be restrictive, I would decouple the interface from OVSXPublishOptions and explicitly name all options. Both sound good for me.

Sounds good to me :). I'd love to review a PR for this issue, including some unit tests.

Released with v0.4.0

thanks. did work
Run HaaLeo/publish-vscode-extension@v0
  with:
    pat: ***
    registryUrl: https://marketplace.visualstudio.com
    extensionFile: httpbook-0.10.0.vsix
    noVerify: true
    yarn: false
    dryRun: false
Specifically, running GitHub Action<EMAIL_ADDRESS>Package the Extension
  The extension was already packaged. Skip packaging.

Publish the Extension
  (node:1768) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
  Publishing<EMAIL_ADDRESS>   INFO  Extension URL (might take a few minutes): https://marketplace.visualstudio.com/items?itemName=anweber.httpbook
   INFO  Hub URL: https://marketplace.visualstudio.com/manage/publishers/anweber/extensions/httpbook/hub
   DONE  Published<EMAIL_ADDRESS>


optimize: issue5228 print Stack Trace in EnhancedServiceLoader.loadFile#cahtch

[ ] I have registered the PR changes.

Ⅰ. Describe what this PR did
issue5228中遇到的问题，无法通过seata日志直接定位到问题根因。
主要原因在于EnhancedServiceLoader.loadFile#cahtch 中的日志打印没有打印详细堆栈信息。
优化了日志打印。
Ⅱ. Does this pull request fix one issue?

fixes #5228
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.yuruixin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #5236 (84c790c) into develop (886f439) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #5236      +/-   ##
=============================================
+ Coverage      48.48%   48.49%   +0.01%
- Complexity      4139     4140       +1
=============================================
  Files            743      743
  Lines          26518    26518
  Branches        3294     3294
=============================================
+ Hits           12857    12860       +3
+ Misses         12262    12260       -2
+ Partials        1399     1398       -1

Impacted Files
Coverage Δ

.../io/seata/common/loader/EnhancedServiceLoader.java
58.18% <0.00%> (ø)

...n/src/main/java/io/seata/common/util/IdWorker.java
83.33% <0.00%> (+6.25%)
:arrow_up:


Checks the custom model is an instance of Model

This probably won't work. $permissionModel is just a string.


[elastic] [WIP] Respect the vendor folder even if we enable the deps download explicitly

Go langserver convert the repos into modules mode to get rid of the
$GOAPTH/src limitation. For the pure vendor repo, we should find the
dependencies from the 'vendor' folder rather than download them according
to the 'go.mod' we created manually.
For now, even if we enable the deps download, we should put
'ENABLEVENDOR' to the context to notify 'go list ...' find the deps in
the local
Btw, a little refactor the 'ManageDeps' function, this change will speed
up the initialize request handler a little bit for most cases.

:white_check_mark: Build go-langserver 1.0.217 completed (commit https://github.com/elastic/go-langserver/commit/aabba926a4 by @movie-travel-code)

:white_check_mark: Build go-langserver 1.0.235 completed (commit https://github.com/elastic/go-langserver/commit/ff8134669d by @movie-travel-code)

ping @zfy0701 Could you take a review?

I should provide the more sophisticated control about the dependencies, like when the vendor folder is not self-contained.


Add link and spellchecker, fix links, and drop unnecessary Java examples

Regarding the Java examples they have been superseded by the samples directory.

[X] I am very sure this PR could not affect performance.

Thanks!


router - add db name in context queries to avoid collision

features
CI

skips CI on release phases that were not being skipped on PRs

postgres adapter

extends current interface, allowing to pass context on queries
fallbacks to currentDB if no dbname found on context
adds mocks to new extended interface
fixes linter errors
adds GetFromPool func here

API

moves most implementations to use queries with Ctx from the postgres adapter
allows setting request timeout

router

new route /_QUERIES/{database}/{queriesLocation}/{script} that should be used to deprecate the old one

Oh my good!
I am very very happy with your proposal 🎉

local testing results:

query on not existant db:

[negroni] 2022-08-13T18:26:54-03:00 | 200 |      30.278041ms | localhost:6000 | GET /prest/public
[negroni] 2022-08-13T18:28:23-03:00 | 400 |      190.083µs | localhost:6000 | GET /newDB/public

config file used:
migrations = "./migrations"

debug = true

[http]
port = 6000

[jwt]
key = "secret"
algo = "HS256"

[auth]
enabled = false
type = "body"
encrypt = "MD5"
table = "prest_users"
username = "username"
password = "password"

[pg]
host = "<IP_ADDRESS>"
user = "prest"
pass = "prest"
port = 5432
database = "prest"
single = true

[ssl]
mode = "disable"
sslcert = "./PATH"
sslkey = "./PATH"
sslrootcert = "./PATH"

thanks for reviewing @DiegoSantosWS , what do you think about these router changes? I think we should take some decision about it
https://github.com/prest/prest/pull/713/files#diff-c399d26e7f23b713ce01946ac9e0e6f1fc94d692e8a086180191901da91b6964R27-R42

🚀


Bugfix: must zero all values in all slices

Only first 2d slice was zeroed out leading to wrong convolution results. Window method might not be the most efficient?

The changed std::fill_n parameters solve the problem. I updated the commit accordingly.


Add skeleton CI

Skeleton GH Actions workflow that runs Black and Flake8, and pytest on PRs to master.
Closes #8

Not having to write this myself is the best part of open-source. Thanks for contributing!