disable the pip cache when building docker images

Describe your changes
Checklist before requesting a review

[ ] Add unit tests for this change.
[ ] Make sure all tests can pass.
[ ] Update documents if necessary.
[ ] Format your code by running pre-commit run --all-files
[ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes.

(Optional) Issue link

BTW should we add these to the other dockerfile we have too?

BTW should we add these to the other dockerfiles we have too?

IMO, we can add this flag for all these files that has the issue.


How to receive a limited number of chats?

Hello.
I am trying to build an app for watchOS based on TDLib, and I've encountered the problem with loading chats using getChats() (https://core.telegram.org/tdlib/docs/classtd_1_1td__api_1_1get_chats.html). I specify the limit for messages (for example, to load 5 messages), but the app still loads all messages at once, which highly decreases the performance.
I found a similar issue on this matter (https://github.com/tdlib/td/issues/899). Is it possible at all to limit the number of received messages?
I use getChatList() function from this example: https://github.com/modestman/tdlib-swift/blob/master/tdlib-ios/Service/Service/ChatListService.swift

getChats returns specified number of chats. Updates about some other chats may be sent any time. This shouldn't directly affect app performance.

Hello.
Sorry, maybe I was not clear in the explanation. getChats returns a specified number of chats, that's right. But, inside onUpdate (more specifically, in .updateNewChat case), TDLib fetches new and new chats, in my case - all existing chats. By doing this, the performance of the app drops significantly for a certain amount of time (because the app loads all existing chats from my account, which is more than 600 conversations).
The question is - how to prevent the library from loading new and new chats automatically? Or is it not allowed?

New chats are preloaded from the database by 20 chats at a time with delay 200 milliseconds between loads, which shouldn't create significant load. The preload can't be disabled, because it is needed for implementation of a lot of app features, for example, filters/folders and updateUnreadChatCount/updateUnreadMessageCount updates, If you don't need these features, you can edit TDLib's source code and disable chat preloading by returning early from the function MessagesManager::preload_folder_dialog_list.

Hello. Thank you very much for your help and the explanation.


[FEAT] Support null equal safe join in SQL

One follow-up of #3161: add on a <=> b support for SQL's Join operation.

@advancedxy, #3161 is merged now, so feel free to ping me once this one has all conflicts resolved & ready for review!


test(robot): add v2 degrade volume replica rebuilding test

Which issue(s) this PR fixes:

Issue https://github.com/longhorn/longhorn/issues/9194
What this PR does / why we need it:
add v2 degrade volume replica rebuilding test
Special notes for your reviewer:
Additional documentation or context

@yangchiu Could you please help resolve the conflicts?

LGTM. We can merge the PR after resolving the conflicts. @yangchiu

LGTM. We can merge the PR after resolving the conflicts. @yangchiu

Conflicts resolved. Thank you!


Div Repulse effect

I've checked the Div Repulse effect but the effect is not perfect.
I've created a new sample to check the effect.
The issue is in the repulse effect, it works on the position instead of the velocity.

The issue is fixed in dev branch, a code cleanup of Repulser.ts could be a good idea


How to organize a lynda downloaded course ?

** this is not an issue its just a question **
Hi
I have used youtube-dl to download from pluralsight and I use this regular expression to organize folder structure as well as videos names
/home/user-name/data/pluralsight/%(playlist)s/%(chapter_number)s. %(chapter)s/%(playlist_index)s. %(title)s.%(ext)s
however, this doesn't work with Lynda Idk why?
Thank you.

Carefully read new issue template and provide all requested information.


Encryptions and Handshaking will release

after many many bugs get fixed and some new things I need to learn

Added


Use bind mount volumes

I recently migrated my deployment to rootless and could not get the config to work as described in https://docs.gitea.io/en-us/install-with-docker-rootless/ when running as an unprivileged user.
My environment is:
Ubuntu 20.04
Docker 20.10.3
Docker-Compose 1.25
The problem appears to be that the direct bind-mount we suggest in ./data:/var/lib/gitea overrides the line in the dockerfile.rootless RUN chown git:git /var/lib/gitea /etc/gitea because it can only mount these with the permissions of the host user (which is root in the docker image). See the related upstream issue
Here I use a different method to bind the volumes. It adds some bloat to the config, but it works as intended.
Note: this might only work for Linux, so another option is I can revert most of the doc, but add a section "## Binding Volumes on Linux Host"

This will work only on Linux. The alternative is to set --user so that the container's user matches with owner of mounted volume.

overrides the line in the dockerfile.rootless RUN chown git:git /var/lib/gitea /etc/gitea

The RUN happens during container build, not on runtime, so nothing on runtime can override it. I don't see a point of doing chown on /var/lib/gitea however as it will be replaced (along with its permissions) by mounted volume.

The linked issue refers to named volumes (docker volume), which indeed are always owned by root (but are just directories so can be chown'd on host if necessary). For mounts, the container see permissions of files and directories inside the same as host, which is the same behavior as you would do normal mount on Linux (so, chown git:git /mnt/test has no meaning if you mount something on that directory)

This will work only on Linux. The alternative (or rather, requirement for rootless) is to set --user so that the container's user matches with owner of mounted volume.

In the docker container there are two users: root (which has the same UID as the host user running docker) and git (created in dockerfile). Setting --user root does indeed work, but kind of defeats the security benefits of using docker rootless.

overrides the line in the dockerfile.rootless RUN chown git:git /var/lib/gitea /etc/gitea

The RUN happens during container build, not on runtime, so nothing on runtime can override it.

Maybe I worded this poorly. As you say, when you mount the directory in dockerfile the above chown has no meaning.

@CirnoT Can you take a look at the updates? Essentially, I just called out a section for linux. I haven't tested rootless on MacOS.

In the docker container there are two users: root (which has the same UID as the host user running docker) and git (created in dockerfile). Setting --user root does indeed work, but defeats some of the benefits of using docker rootless.

Sorry but I believe you are missing the point of --user flag. https://docs.docker.com/engine/reference/run/#user
The provided UID:GID should match your HOST user that owns the directory with Gitea files, it does not have to exist in container.

Sorry but I believe you are missing the point of --user flag. https://docs.docker.com/engine/reference/run/#user
The provided UID:GID should match your HOST user that owns the directory with Gitea files, it does not have to exist in container.

It's entirely possible I'm mistaken on this front (I'm far from a docker expert). However, I spent quite a bit of time trying to get this to work. From the link you sent "root (id = 0) is the default user within a container... operator can override by passing the -u option" This is essentially what I found - it only works when I set user=root. In the case of rootless root (id = 0) in the container is mapped to the host user running docker.
Yes, I can run as container root, but that user still has elevated permissions compared to the git user in the container.

As such, this PR is unnecessary, the requested scenario is possible right now out of the box, you just had wrong assumptions on what you could and could not do.

The basic instruction we provide in the docker rootless documentation fails on Linux. Can you show me the commands to run to make it work without using --user=root?

The basic instruction we provide in the docker rootless documentation fails on Linux. Can you show me the commands to run to make it work without using --user=root?

# ls -l
drwx------ 7 git  git  4096 Mar  7 07:05 gitea
drwx------ 5 git  git  4096 Mar  7 07:06 repos

# ls /home/git/gitea
conf  custom  data  git  log

# id git
uid=1001(git) gid=1001(git) groups=1001(git)

# docker run -d --restart=always --pull=always --user 1001:1001 \
-v /home/git/gitea:/var/lib/gitea \
-v /home/git/gitea/conf:/etc/gitea \
-v /home/git/repos:/var/lib/repos \
-v /etc/timezone:/etc/timezone:ro \
-v /etc/localtime:/etc/localtime:ro \
--publish <IP_ADDRESS>:3000:3000 --publish 22:2222 \
--name=gitea gitea/gitea:latest-rootless

RUN_MODE = prod

[repository]
ROOT           = /var/lib/repos

[server]
DOMAIN                   = gitea.com
HTTP_PORT                = 3000
SSH_PORT                 = 22
START_SSH_SERVER         = true
SSH_LISTEN_PORT          = 2222
BUILTIN_SSH_SERVER_USER  = git

[picture]
AVATAR_STORAGE_TYPE            = local
REPOSITORY_AVATAR_STORAGE_TYPE = local

[security]
INSTALL_LOCK          = true

[ssh.minimum_key_sizes]
ED25519 = 256
ECDSA   = 256
RSA     = 2048
DSA     = -1

[lfs]
STORAGE_TYPE = local

[attachment]
STORAGE_TYPE  = local

I may have not be especially clear but if you run without --user  or docker-compose equivalent you need to make sure that the folder is owned by 1000:1000 (default uid:gid of user git in the image) and it will work perfectly.
Using $(id -u):$(id -g) feel not better as it is less likely to be the default mode to run with the same uid:gid as the user you are logged. For example, on my machine it is 69201586:69200513 which far from what it will be in the running container by default.
(To be verified) If the folder is not created, you need to create it first or docker will create with root ownership.
The docs may definitively lack for corner cases.


DGA Performance fix

This PR contains fix for DGA performance as suggested here https://github.com/splunk/security_content/issues/2744
Tested the fix and it greatly improves the performance

The fix is tested by @nsreekanta and is similar to the proposed fix by @dglauche


[microNPU] Enable the codegen tests for 256 mac Arm(R) Ethos(TM)-U65 NPU

This patch has necessary changes to the Makefile and test
infra to run the FVP based codegen tests on a newer NPU variant.

cc: @manupa-arm @grant-arm @lhutton1

The CI failed because the upstream CI docker image has not yet absorbed the changes to the FVP and driver version, so this PR can't progress before https://github.com/apache/tvm/issues/9762 is complete...


Add manual CI action for custom wheels

For now only ARM64 wheels for MacOS.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.55%. Comparing base (c8818c8) to head (cdc2e6f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1216   +/-   ##
=======================================
  Coverage   86.55%   86.55%
=======================================
  Files         176      176
  Lines       13017    13017
=======================================
  Hits        11267    11267
  Misses       1750     1750

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


sync from master to feature-istio_adapter branch.

Issues associated with this PR
Your PR should present related issues you want to solve.
Solutions
You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result.
Code Style

Make sure Goimports has run
Show Golint result

Codecov Report

Merging #1045 into feature-istio_adapter will increase coverage by 1.31%.
The diff coverage is 45.89%.

@@                   Coverage Diff                    @@
##           feature-istio_adapter   #1045      +/-   ##
========================================================
+ Coverage                  55.09%   56.4%   +1.31%
========================================================
  Files                        245     242       -3
  Lines                      23718   22909     -809
========================================================
- Hits                       13067   12922     -145
+ Misses                      9457    8833     -624
+ Partials                    1194    1154      -40

Impacted Files
Coverage Δ

pkg/protocol/conv.go
0% <ø> (ø)
:arrow_up:

pkg/types/network.go
0% <ø> (ø)
:arrow_up:

pkg/proxy/retrystate.go
75.51% <ø> (ø)
:arrow_up:

pkg/protocol/types.go
13.04% <ø> (ø)
:arrow_up:

pkg/upstream/cluster/original_dst.go
83.67% <ø> (ø)
:arrow_up:

pkg/xds/conv/update.go
9.3% <ø> (+9.3%)
:arrow_up:

pkg/config/v2/config.go
40% <ø> (ø)
:arrow_up:

pkg/xds/conv/convertxds.go
42.48% <ø> (+16.95%)
:arrow_up:

pkg/variable/var.go
94.11% <ø> (ø)

pkg/upstream/healthcheck/factory.go
73.33% <ø> (ø)
:arrow_up:

... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4482612...f23e3a6. Read the comment docs.


cert-manager url change

kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.7.1/cert-manager.crds.yam
error: unable to read URL "https://github.com/jetstack/cert-manager/releases/download/v1.7.1/cert-manager.crds.yam", server reported 404 Not Found, status code=404
For Rancher (product) docs only
When contributing to docs, please update the versioned docs. For example, the docs in the v2.6 folder of the rancher folder.
Doc versions older than the latest minor version should only be updated to fix inaccuracies or make minor updates as necessary. The majority of new content should be added to the folder for the latest minor version.

Thanks for the contribution @sterni1971.
As for the error you quoted, it looks like you left off the l at the end of yaml. The current URL, while not up-to-date, should work due to redirects.


Set a variable from the output of a command line

Hey,
I'm wondering if that'd be possible to set a variable from a command line ?
For instance i would like to use the short commit tag as the docker tag.
How would you do that please ?
Regards,

Another usage would be:
In an autoscaling environment, get the current number of replicas before to apply the new deployment.

You can use --set to perform this action, depending if the chart has made the field template-able or not. There are several examples of this in the documentation.

nvm, i just figured it out
TAG=$(git rev-parse --short HEAD)
--set image="image:xxxxxx",


Parallelise GraphQL document validation

Purpose
Related to:  #3430
Examples
Checklist

[ ] Linked to an issue
[ ] Updated the changelog
[ ] Added tests
[ ] Updated the spec
[ ] Checked native-image compatibility

PR sent to a new branch: https://github.com/ballerina-platform/module-ballerina-graphql/pull/990


Time duration offset not working when using now

This is a valid query in influx db:
SELECT count(build_number) AS total_builds FROM jenkins.autogen.jenkins_data WHERE time >= '2017-09-10T10:40:00Z' AND time < '2017-09-11T10:40:00Z' GROUP BY time(7h,now()), project_name fill(0)

While this tick does not work
batch
    |query('''SELECT count(build_number) as total_builds FROM "jenkins"."autogen"."jenkins_data"''')
    .groupBy(time(7h,now()),'project_name')
    .fill(0)
    .align()
    .every(5m)
    .period(1d)

This is needed to shift the partial window at the end when using group by time.
Currently Kapacitor throws this error:
no global function "now" defined

Duplicate of https://github.com/influxdata/kapacitor/issues/169. So closing


[WFCORE-6039] Upgrading JBoss MSC to 1.5.0.Beta2

https://issues.redhat.com/browse/WFCORE-6039

@ropalka I put the 20.x label (i.e. WF 28) on this as we are past the point of integrating Betas into WildFly 27. We need to be getting the existing beta components moved to final releases over the next 10 days.

Sure, no problem @bstansberry .


[Feature] need ipv6 support

Motivation
mqttx needs to support ipv6 domain name or ipv6 address
mqttx需要支持ipv6域名或者ipv6地址
Detailed design
When I enter a domain name that only has AAAA resolution, or enter a pure ipv6 address, I hope that the connection can be successful
当我输入一个只有AAAA解析的域名时，或者输入一个单纯的ipv6地址，期望可以连接成功
Alternatives
More detail (optional)
Add any other context or screenshots about the feature request here.

sorry，mqttx is support ipv6. this error is my  emqx conf error.
this is error conf：listener.tcp.ipv6 = ::1:1883
this is right conf：listener.tcp.ipv6 = ::0:1883

Happy for your :)


[Concurrency] SILGenModule::emitEntryPoint crashes when exit hasn't been imported

If exit hasn't been imported, SILGenModule::emitEntryPoint crashes because it doesn't synthesize an exit function like SILGenFunction::emitCallToMain does. Make it do so.
rdar://122413238

@swift-ci smoke test

Hmm, I guess we don't have any test cases that test async top-level code in an environment that doesn't have an exit imported already. I think we should be able to create one with -parse-stdlib and maybe a few other flags. Something like swiftc -parse-stdlib <foo.swift> and the below should at least get close to repro'ing the assert:
import _Concurrency
func foo() async { }
await foo()

Would this work from async_main_no_concurrency.swift?
// RUN: %target-typecheck-verify-swift -parse-as-library -disable-availability-checking -parse-stdlib

Should I also add a @main struct?

Would this work from async_main_no_concurrency.swift?
// RUN: %target-typecheck-verify-swift -parse-as-library -disable-availability-checking -parse-stdlib
Something like that, yeah.

Should I also add a @main struct?
To test emitEntryPoint, no. We want to emit an async top-level code snippet which uses that path instead of emitAsyncMain.

Would this work from async_main_no_concurrency.swift?
// RUN: %target-typecheck-verify-swift -parse-as-library -disable-availability-checking -parse-stdlib

Something like that, yeah.

Should I also add a @main struct?

To test emitEntryPoint, no. We want to emit an async top-level code snippet which uses that path instead of emitAsyncMain.

We should probably have an explicit test for both though. Can we do that in a single test, i.e. with a top level @main struct and a top level async func, or do we need two tests for that?

We should probably have an explicit test for both though. Can we do that in a single test, i.e. with a top level @main struct and a top level async func, or do we need two tests for that?

I believe it needs to be in two tests since the #if directives don't just delete syntax like in C. The @main will not parse, even if we do something like this:
// RUN: %target-typecheck-verify-swift -parse-as-library -disable-availability-checking -parse-stdlib
// RUN: %target-typecheck-verify-swift -disable-availability-checking -parse-stdlib -DTOP_LEVEL_TEST

func foo() async {}

#if TOP_LEVEL_TEST
await foo()
#else
@main struct Main {
  static func main() async {
    await foo()
  }
}

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test

@swift-ci test


GUVNOR-2388: Chars being removed from metadata when lock is acquired

@manstis please ;). 6.4.x and 6.3.x to follow.

Great stuff; thanks. +1 to merge.

master: bb4f4a746cd93826213d146e92c75513be9d977c


Flutter atom plugin should have a one-click way to run tests

If I have a "_test.dart" file from a Flutter project open in Atom, rather than offering to run that file in the Dart cli (as the "run" toolbar does currently), Atom should offer to run that file as a flutter test.  Specifically, flutter test path/to/file_test.dart.
Bonus points for an option to run with the forthcoming --merge-coverage option (see https://github.com/flutter/flutter/pull/4726) to make it super fast to iterate on test coverage.
/cc @devoncarew @Hixie

Looking at the help for --merge-coverage it says it's linux only - I'm curious why?
Also, will the --merge-coverage option apply to flutter project in general, or just to the flutter repo?

Looking at the help for --merge-coverage it says it's linux only - I'm curious why?

The command line tool we're using to merge lcov files is a Linux utility.  We could also just write some Dart code to merge lcov files.

Also, will the --merge-coverage option apply to flutter projects in general, or just to the flutter repo?

It's something that can be used by any Flutter project, but I wouldn't expect that many developers to interested in test coverage.  (Although I might be wrong about that.)

@cbracken, @kevmoo, does the merge code already exist in a package somewhere? Perhaps in https://pub.dartlang.org/packages/dart_coveralls?

There's separate code for this internally. I'll take a look at getting this externalised as part of package:coverage.

This is landed; I'll probably iterate on the UI a bit. In any case, there's a button in the toolbar to run tests (it's visible when a test file is open). There's also a keybinding to run the current file (ctrl-option-cmd-t on the mac).
The --merge-coverage  option is semi-hidden for now. To enable it, open the Atom > Config file, and add mergeCoverage: true to the flutter section.

Thanks!

Sweet!  Works.

This now looks to see if there's a clear mapping from the current editor, to a test library for that file. If so, the keybinding (and button) will run tests for the associated test library. It uses a few common file naming conventions to try and find an associated test file.


Run image builds as separate jobs

Signed-off-by: Paul S. Schweigert<EMAIL_ADDRESS>We found that running all image builds as a single job could create a bottleneck, so we decided to split them into separate jobs. This should also make reviewing logs easier, as there should be less output for the web UI to have to render.

Summary
Details and comments

Should we give it a go?

yeah, let me rebase...


Create Covid_19_data

Description
create a file
Checklist

[] I've read the contribution guidelines.
[] I've checked the issue list before deciding what to submit.
[] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Analysis of Covid_19 https://github.com/The-Data-Alchemists-Manipal/MindWave/issues/241

Hi @khusheekapoor , I have create a file in data analytics so I have done PR for that please review that.

Hi @khusheekapoor , actually the link has been created in readme of the data analytics directory "Covid_19_data".
But the file is not displayed in data analytics.

Please push it in then, thanks!


SCSI driver memory leak

Describe the bug
I've obtained drivers from the FedoraPeople virtio group, as described in Proxmox's documentation. What I've found is that in all version above virtio-win-0.1.185 (v<IP_ADDRESS>00), the VirtIO SCSI Controller driver (viostor) appears to have some sort of memory leak, as far as I've been able to trace. Using the version ending in 18500, my VM idles around 3GB memory usage and does not spike. Using any newer available version (v<IP_ADDRESS>00 - v<IP_ADDRESS>00), memory usage at idle is 5GB, spiking at least as high as 8-10GB, though if I recall in testing, I've seen it spike upwards of 15GB.
To Reproduce
Steps to reproduce the behaviour:

install Windows 10, any build between 1909-22H2 [I'm running Enterprise, though I've seen it in Pro as well]
install the appropriate virtio drivers from the fedora people archive [I'm running the network, ballon, and storage drivers, as well as QEMU guest]
observe memory usage with task manager, or any appropriate memory usage tool, such as RAMMap.
for extra confusion, install the vioserial driver (of any versions listed here) and reboot until your memory usage inside the VM is all available memory.

Expected behavior

memory usage should remain similar to its usage under driver version v<IP_ADDRESS>00

Host:

Disto: Proxmox 8.0.4 [Debian 12]
Kernel: Linux 6.2.16-14-pve #1 SMP PREEMPT_DYNAMIC PMX 6.2.16-14 (2023-09-19T08:17Z)
QEMU version: QEMU emulator version 8.0.2 (pve-qemu-kvm_8.0.2-6)
QEMU command line: ???
QEMU server: qemu-server 8.0.7
libvirt version: ???
libvirt XML file: ???
all proxmox version bits: https://pastebin.com/raw/xN0cAPar

VM:

Windows version: Windows 10 Enterprise 22H2 [19045.2728]
Which driver has a problem: viostor (and possibly vioserial)
Driver version: <IP_ADDRESS>00+

Additional context
Oddly, I've seen strange memory usage of nearly all 16GB assigned to the VM when the vioserial driver is installed. I'm uncertain whether this is related to the issue, though I am certain there's a leak in the SCSI driver, given it's necessary for VM functionality -- whereas the serial driver shouldn't be from what I've read.
Additional info available upon request.

@elderlabs
Thank you for reporting the issue.
Can you please tell what kind of tools did you use to discovery the memory leakage in viostor driver?
Is it related to the storage read/write activity or the memory leakage happens all the time?
Can you please confirm that  the problem can be reproduced with v<IP_ADDRESS>00 but not with v<IP_ADDRESS>00? I'm asking you because there were no changes in viostor code between builds 185 and 187.
Best regards,
Vadim.

Closing as there is no response on the request for more info


use a more terse template code

Use an Array() cast and always do the same instead of checking if it's an array and acting consequently

Hello,
Unfortunately, the unit-test fails on this new PR:
https://travis-ci.org/camptocamp/puppet-bind/jobs/54236943#L2308
Would be great if you could correct either the template code, or the unit-test content.
Thank you!

Mmmmh I cannot see the travis build error, the link points to a blank page. Maybe because I've just rebased the PR to include similiar changes to the master zone template?

Possible — you might check the overall build status here: https://travis-ci.org/camptocamp/puppet-bind

It was a problem with my Firefox ;) Ok, fixed the spec after removing some spaces (I kinda prefer this indentation anyway), now the build passes 100%

Sorry for the mess with the new feature implementation in master, my bad, I shouldn't have merged it so soon. I reverted the commit

Sorry, I'll redo everything in branches, I just messed it up with git/github. Sorry


Realm Training Time

Hi,
Could you please tell how long it takes to train a realm from scratch including ICT with the number of TPUs mentioned in the paper? Thanks so much

Hi I am also trying to train realm form scratch and had some problems doing that? do you want to chat? My email is<EMAIL_ADDRESS>

Sure man, I emailed you


This adds a custom Arc type for stable reason

This includes: https://github.com/gfx-rs/gfx-rs/pull/719 (Feel free to cherry-pick this change if you want to include it what that changeset).
This creates a custom Arc type so that we can use is_unique in our codebase.
This could be a breaking change as I do not have the full Arc for example Display is missing.

Superb! Thanks @csherratt !
I'm wondering, does cfg(unstable) set automatically by rust? I'm happy to see Travis green on both rust-beta and nightly :)

Might be a good idea to put the custom Arc in its own library, in case this is needed elsewhere.

@bvssvni somehow, I feel that we are the sole major users of is_unique, so everyone else can just use the stock Arc.


Convert UTF-16 from e.g. comments into UTF-8?

Hi,
I'd like to print the comment field to the console (under Windows in this case). This doesn't really work well^^ if that field was stored with UTF-16 BOM encoding before, e.g. by MP3Tag.
Is there any way to tell the library that I get a (converted) UTF-8 string instead?
The console supports UTF-8 and with the right font this would result in some readable text :)
                comments := tag.GetFrames(tag.CommonID("Comments"))
                for _, v := range comments {
                    comment, ok := v.(id3v2.CommentFrame)
                    if !ok {
                        log.Fatal("Couldn't assert comment frame")
                    }
                    fmt.Printf("\nComment: %s", comment.Text)
                    fmt.Printf("\nComment: %s", comment.Encoding)
                }

ATM it looks like this:
Comment: �C o m m e n t
Comment: UTF-16 encoded Unicode with BOM

The original comment is really "Comment" for testing purposes...

Hi! id3v2 should automatically convert UTF-16 text to UTF-8 and it should correctly print the comment. So it's a bug, but the latest release should fix some UTF-16 issues. Do you use the latest version? Try to go get -u github.com/bogem/id3v2

Hi,
yeah, I'm already on the latest version:
git log
commit 3da57733453b434afc02a084236bbe86209c6974 (HEAD -> master, tag: v1.1.2, origin/master, origin/HEAD)
Author: Albert Nigmatzianov<EMAIL_ADDRESS>Date:   Tue Mar 10 08:47:07 2020 +0100

    Support older versions and 32bit

Hm okay, that's weird. Can you please send the file, so I can reproduce the bug?

Here is the link for the zip file that contains the mp3: https://filebin.net/eemwrdr40a27e876
The ID3v2.3 + ID3v1 tags have been created with MP3Tag.
Settings:
[x] ID3v1
[x] ID3v2
    (o) ID3v2.3 UTF-16

I have the same problem.
Go 1.14.1
macOS 10.15.3

(Information for me)
Reason of problem: description of comment is empty string encoded in UTF-16 with BOM. id3v2 doesn't consider this situation.

Should be fixed in https://github.com/bogem/id3v2/commit/051e4b2ea87f4646bab6d86642dce1448346a402. Please check 🙏

This works for me.
Thanks!
Please add a new release for use with go mod.

Works for me as well, tested all combinations of MP3Tag options, the output is encoded fine (for comments).
Thanks!

@qkveri Done!
You're welcome guys 🙂


feat: Add AWS Approval to Fabric Connection Resource

Update Additional Info Schema type to accept AWS Secrets
Add AWS PATCH Request to resources that include the AWS Secrets to Approve AWS Connections immediately after creation
Enhance Fabric Connection Resource Update method to allow AWS secret update after resource creation
Fix Go Type Conversion errors for Hashicorp Hashing process

Codecov Report
Attention: 149 lines in your changes are missing coverage. Please review.

Comparison is base (872618d) 59.56% compared to head (436d501) 60.13%.
Report is 17 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
+ Coverage   59.56%   60.13%   +0.56%
==========================================
  Files          98       99       +1
  Lines       19754    19975     +221
==========================================
+ Hits        11767    12011     +244
+ Misses       7684     7664      -20
+ Partials      303      300       -3

Files
Coverage Δ

equinix/data_source_metal_port.go
100.00% <100.00%> (ø)

equinix/data_source_metal_spot_market_request.go
86.86% <100.00%> (+3.03%)
:arrow_up:

equinix/fabric_connection_schema.go
100.00% <100.00%> (ø)

equinix/helpers_device.go
84.91% <100.00%> (+7.34%)
:arrow_up:

equinix/provider.go
82.14% <100.00%> (+0.05%)
:arrow_up:

equinix/resource_metal_port.go
89.84% <100.00%> (+1.64%)
:arrow_up:

equinix/resource_metal_spot_market_request.go
65.80% <100.00%> (+8.12%)
:arrow_up:

equinix/resource_metal_vrf.go
86.40% <100.00%> (-0.53%)
:arrow_down:

equinix/data_source_metal_device_bgp_neighbors.go
97.65% <94.11%> (+26.56%)
:arrow_up:

equinix/data_source_metal_vrf.go
89.58% <33.33%> (ø)

... and 4 more

... and 5 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@thogarty with more PRs like this and #397, what are your thoughts on https://github.com/equinix/terraform-provider-equinix/issues/384#issuecomment-1744847620


Automatically retrieve PAA certificates for device attestation

For commissioning a device its PAA certificate is required to do device attestation checks.
With the certificate missing, device commissioning will fail. Now that Matter devices are hitting the market every week, we'd like to keep the certificates up to date.
This change fetches all certificates at startup.
When starting a commissioning, it will do  quick delta sync of certificates to ensure we have the latest set.
The full sync at startup happens before initializing the device controller.
For the delta sync at commissioning-stage I'm not so sure that any new certificates get picked up by the device controller. By some basic testing, it seemed to me that the device controller needs a restart/reload in order to pick up new certificates. This is a bit tricky due all the C bindings so I did not implement that for now.

It doesn't look like this passed the CI checks successfully.

It was green, maybe GH slow ?


Need to get RESULTANT (Rendered) HTML from dynamic pages...

Hi,
Some very important problems can be solved by gaining access to the RESULTANT (Rendered) HTML.
This means that the page is loaded, and javascript is executed, THEN the HTML result is returned.
There is a way to do this.
It is based around creating a PhantomJS (http://phantomjs.org/) bridge.
There are problems deploying this on shared server environments or any method that does not allow shell+compile access.
There are a couple of solutions I am toying with.
ONE:
Create a Micro-Appliance.
This can be done by setting up a beaglebone with access via dynamic domain name to act as a PhantomJS bridge.  This allows you to deploy these yourself to friends and family etc.
Beaglebones are between $35 and $65 depending on which flavor you get.  With case and power supply add another $15 per unit.  This is a one time charge if you have people volunteering bandwidth and power.
TWO:
Create a Cloud Deploy Image.
This can also be done via dynamic cloud spinups (such as on Amazon AWS).
This is easier but more costly over time.
Automated proxy list maintenance can be included on these also, to move this coding/overhead into the appliance, preventing the need to set up CRON for this task with this rss-bridge app.
Questions/Comments: get at me.
ghostofzigz

I'm really interested into developing some phantomjs integration, because more and more websites now require javascript, like Thingiverse since last update 😒


missing minimum scipy version in requirements

scikit-optimize seems not to have any requirement on the scipy version it depends on:
pip install scipy==0.13.3
pip install scikit-optimize
works but when importing skopt I get:
>>> import skopt
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File ".../anaconda/envs/test/lib/python2.7/site-packages/skopt/__init__.py", line 54, in <module>
    from . import optimizer
  File ".../anaconda/envs/test/lib/python2.7/site-packages/skopt/optimizer/__init__.py", line 1, in <module>
    from .base import base_minimize
  File ".../anaconda/envs/test/lib/python2.7/site-packages/skopt/optimizer/base.py", line 16, in <module>
    from .optimizer import Optimizer
  File ".../anaconda/envs/test/lib/python2.7/site-packages/skopt/optimizer/optimizer.py", line 20, in <module>
    from ..utils import check_x_in_space
  File ".../anaconda/envs/test/lib/python2.7/site-packages/skopt/utils.py", line 4, in <module>
    from scipy.optimize import OptimizeResult
ImportError: cannot import name OptimizeResult

The scikit-optimize version installed by pip is 0.4 .
Googling around I found that also other projects have this problem, see e.g. https://github.com/lmfit/lmfit-py/commit/956f29c6df462bcc80529671cece8f49598b9b69#diff-78c72422c390b5018fb25e5402cd89a2R16
On the other hand, when doing the following instead (on a newly initialized python environment):
pip install scipy==0.14.0
pip install scikit-optimize

importing skopt works without problem.
I'm not an expert in packaging python code but I suspect that adding >=0.14.0 after scipy in requirements.txt could solve this problem ?
(the above tests were made with python 2.7, I noticed this problem earlier today while downloading dependencies by hand, working behind a firewall with no http proxy)

The right place to put this requirement would be in setup.py. That is where pip and friends look. The requirements.txt is more for people wanting to run the "dev" version..
Do you know what the minimum version of scipy is that scikit-learn works with? So far I had assumed that because we depend on a new-is version of scikit-learn we would automatically get a "new enough" version of scipy as well.

Good question, the minimal scikit-learn version (0.18) required by scikit-optimize seems not to require anything.  Doing (again on a fresh environment) pip install scikit-learn==0.18 I get:
Collecting scikit-learn==0.18
  Using cached scikit_learn-0.18-cp27-cp27m-macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl
Installing collected packages: scikit-learn
Successfully installed scikit-learn-0.18

but it does not even install numpy (let alone scipy) and as a consequence importing sklearn gives me an exception complaining about missing numpy.
pip show scikit-learn says:
Name: scikit-learn
Version: 0.18
...
Location: .../anaconda/envs/test/lib/python2.7/site-packages
Requires:

so nothing in the 'Requires' field.
I'll check if there is an issue open about this in scikit-learn because even in the latest version I get with pip (0.19.0) the problem is still there.
Doing pip show scikit-optimize I see the dependencies from setup.py in the Requires field (but not the version numbers) so this is a valid way of getting the list of dependencies.

I just saw on http://scikit-learn.org/stable/install.html that the way to get the dependencies of scikit-learn installed is to do install scikit-learn[alldeps].
Doing
pip install 'scikit-learn[alldeps]==0.18'

on a fresh environment I see:
Collecting scikit-learn[alldeps]==0.18
  Using cached scikit_learn-0.18-cp27-cp27m-macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl
Collecting numpy>=1.6.1; extra == "alldeps" (from scikit-learn[alldeps]==0.18)
  Using cached numpy-1.13.3-cp27-cp27m-macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl
Collecting scipy>=0.9; extra == "alldeps" (from scikit-learn[alldeps]==0.18)
  Using cached scipy-0.19.1-cp27-cp27m-macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl
Installing collected packages: numpy, scipy, scikit-learn
Successfully installed numpy-1.13.3 scikit-learn-0.18 scipy-0.19.1

So the minimal scikit-learn version required by scikit-learn[alldeps]==0.18 is 0.9 which is below 0.14. In the above example I get a newer version but this is not always guaranteed.

With scikit-learn[alldeps] I actually get another error on import related to importing something from sklearn (probably implying that the minimum scikit-learn version required should be higher). Should I report this here or open a separate issue ?

With scikit-learn[alldeps] 0.18 I actually get another error on import skopt related to importing something from sklearn (probably implying that the minimum scikit-learn version required should be higher). Should I report this here or open a separate issue ?

New issue is probably best.

scikit-learn does not directly depend on numpy and scipy because of something related to how setup.py works (this might be knowledge left over from a pre-historic python world though).
Interesting to see that the dependency calls for >=0.9 but 0.19 gets installed. I wonder why. Naively I'd assume that pip will always try to install the lowest possible version???
In principle I have no problem with adding some requirement directly in skopt, from a practical point of view, the less we have to "hardcode" the less we have to maintain things :) So if "in practice" installing sklearn>=0.18 gets the user the right version of the other dependencies I'd be tempted to leave things as they are. Maybe mention in the documentation what the real minimums are. Mostly because downloading "by hand" the packages for work behind a firewall is "super rare". But yeah, I don't have a strong opinion either way.

Interesting to see that the dependency calls for >=0.9 but 0.19 gets installed. I wonder why. Naively I'd assume that pip will always try to install the lowest possible version???

Actually, I would expect pip to installs the latest (and greatest) version of a package which is compatible with the requirements and which it can find in the repository or cache (if not already installed).

In principle I have no problem with adding some requirement directly in skopt, from a practical point of view, the less we have to "hardcode" the less we have to maintain things :) So if "in practice" installing sklearn>=0.18 gets the user the right version of the other dependencies I'd be tempted to leave things as they are. Maybe mention in the documentation what the real minimums are.

I have no strong opinion on this ... (note however that mentioning the minimum level in the documentation also requires some maintenance :-) )

Mostly because downloading "by hand" the packages for work behind a firewall is "super rare". But yeah, I don't have a strong opinion either way.

yes, I agree that this is an edge case. Once I found out the minimum needed version of numpy I thought it was a useful opportunity to make the requirements of scikit-optimize more accurate.

I suggest you create a PR modifying setup.py to include the requirement and we see if someone else has a strong opinion either way. If no one is violently opposed we merge it :)

scikit-learn does not directly depend on numpy and scipy because of something related to how setup.py works (this might be knowledge left over from a pre-historic python world though).

Probably because it used to be difficult to specify build time requirements. The landscape is going to change very soon with the release of pip 10, which implements PEP 518 (the last bit left is https://github.com/pypa/pip/pull/4764)

I added the requirement for scipy in the above pull request. Let me know if you think also requirements.txt should be changed.


disallowed Series | AnyArrayLike as Series is already array-like

Issue #42359 in the pandas-dev repo

Thanks @Pydare for doing this! Looks like CI is red (insufficient coverage), could you fix it up please?

any idea on what I could do?

check that all the branches in the code you've added are covered by the tests - e.g. put breakpoints in them and check that the tests reach them

check that all the branches in the code you've added are covered by the tests - e.g. put breakpoints in them and check that the tests reach them

I've been able to see what branches are not well covered, am I to write tests for each of these individual branches? Kind of unsure of what to do from here

Hmm looks like for the file you've added, it's already at 100% - the issue's probably somewhere else then, I'll take a closer look tomorrow, it's probably unrelated to this PR
Well done anyway, this generally looks really good!

Looks like coverage for pandas_dev_flaker/_ast_helpers.py is less than 100% - I'd suggest, check that all the code you've added in that file is covered by at least one test

$ coverage report --show-missing
Name                                Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------------------
pandas_dev_flaker/_ast_helpers.py      34      4     22      4    86%   63, 69, 74, 76
-------------------------------------------------------------------------------
TOTAL                                 758      4    220      4    99%

58 files skipped due to complete coverage.
Coverage failure: total of 99 is less than fail-under=100

Looks like coverage for pandas_dev_flaker/_ast_helpers.py is less than 100% - I'd suggest, check that all the code you've added in that file is covered by at least one test

I suspected this was the problem. I tried looking for the file that contained tests for _ast_helpers.py but couldn't find any.

There's no file that directly tests _ast_helpers.py, but the functions defined in _ast_helpers.py are used in other files which are tested.
So, you need to make sure that the test cases in pandas_dev_flaker/_plugins_tree/disallow_argument_types.py are comprehensive enough that they cover all the code you've added to _ast_helpers.py

I inspected which lines weren't properly tested and my new functions do not affect it.

Looks like there's still a few missing branches:
(venv) marcogorelli@OVMG025 pandas-dev-flaker % coverage report
Name                                Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------------------
pandas_dev_flaker/_ast_helpers.py      30      0     20      4    92%   53->70, 54->60, 63->65, 67->53
-------------------------------------------------------------------------------
TOTAL                                 754      0    212      4    99%

58 files skipped due to complete coverage.
Coverage failure: total of 100 is less than fail-under=100

Looks like there's still a few missing branches:
(venv) marcogorelli@OVMG025 pandas-dev-flaker % coverage report
Name                                Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------------------
pandas_dev_flaker/_ast_helpers.py      30      0     20      4    92%   53->70, 54->60, 63->65, 67->53
-------------------------------------------------------------------------------
TOTAL                                 754      0    212      4    99%

58 files skipped due to complete coverage.
Coverage failure: total of 100 is less than fail-under=100

To see this locally, you can run
coverage erase
coverage run -m pytest
coverage report

If there's a branch which you think can't be covered, then you can raise an AssertionError and it'll be ignored in the coverage report

Well done muscle ! I think we've got the logic in parse_annotation down
Last thing (I promise smile ) to address is the return type, e.g.
def foo(arg) -> Series | AnyArrayLike

currently isn't caught
There's a couple of possible solutions - either change visit_arg to also check the return type, or by registering two functions, one for ast.Attribute and the other for ast.Name, see
https://github.com/asottile/pyupgrade/blob/fd230e8c64cfd990e1e9231522ed3e4c4e08cb58/pyupgrade/_plugins/typing_pep585.py#L30-L66
for an example
The second solution would be better, because it would also catch annotations outside of function definitions

I'm kinda unsure why we should register ast.Atrribute and ast.Name to enable us catch return annotations or annotations outside of function definitions. The first option is clear to me.
From my understanding according to docs, Attribute majorly deals with class attributes or variable attributes, etc, and Name majorly deals with variables.
Just trying to understand how I can link them to catch the annotations outside functions

UPDATE: so i broke down the logic into 3 different functions in the same disallow_argument_types.py file. i'm kind of having some trouble testing the 2 new functions. should i split them into 2 different files?

I think a single file is fine, as until now I've been keeping it to 1 file for each check

From my understanding according to docs, Attribute majorly deals with class attributes or variable attributes, etc, and Name majorly deals with variables.

In general, my way of checking what to use is to make some test file, like t.py
var: int
def foo(bar: str) -> None: ...

then running
pip install astpretty
astpretty t.py

and checking from the output what the objects are

Nice! I'll take a closer a look at the weekend, but this might be it!

looks good to me too. we can merge :)

Awesome, thanks (cc @jreback for visibility, as I think @Pydare effort has done great work here!)


Discussion: How to handle S3 Config in Catalog

...perhaps I am missing something, but currently I prototype the HMS Catalog like:
let metadata = TableMetadataBuilder::from_table_creation(creation)?.build()?;
let metadata_location = get_metadata_location(&location, 0)?;

let file_io = FileIOBuilder::new("s3a")
    .with_props(vec![
        (S3_ENDPOINT, "http://<IP_ADDRESS>:9000".to_string()),
        (S3_ACCESS_KEY_ID, "minioadmin".to_string()),
        (S3_SECRET_ACCESS_KEY, "minioadmin".to_string()),
        (S3_REGION, "us-east-1".to_string()),
    ])
    .build()?;
let mut file = file_io.new_output(&metadata_location)?.writer().await?;
file.write_all(&serde_json::to_vec(&metadata)?).await?;
file.shutdown().await?;

@liurenjie1024 @Xuanwo
Has there been any discussions or thoughts about where to set those configuration params?
Currently I don't see anything setup - but I might be missing something?
One way to handle this would be to pass the params (or even the complete FileIO) into the HmsCatalogConfig?
pub struct HmsCatalogConfig {
    address: String,
    thrift_transport: HmsThriftTransport,
}

struct HmsClient(ThriftHiveMetastoreClient);

/// Hive metastore Catalog.
pub struct HmsCatalog {
    config: HmsCatalogConfig,
    client: HmsClient,
}

We may use a Hashmap for properties like the RestCatalogConfig and load_file_io
pub struct HmsCatalogConfig {
    address: String,
    thrift_transport: HmsThriftTransport,
	props: Hashmap<String, String>
}

let file_io = FileIO::from_path(url)?.with_props(config.props).build()?

@odysa @Xuanwo
this is the way I implemented it for now - and I think its fine. PR will be up for review once #271 has been resolved.
thanks again for your feedback.

@marvinlanhenke Sorry for late reply. I think this approach is fine, and java/python also follows this approach.


Extended description

Currently, the offer message has a lot of not critical parameters (such as the floor, etc..) and lacks a description.
The task is to rework the message appearance to include only critical data and add a button to show the full description + all the parameters.
Todo list:

Add a shortened description to the message.
Merge the additional_payment with a base payment so it looks like this:

Payment: 1000 (+ 350)

Remove the floor and other miscellaneous stats from the message.
Add a button to show all the stats and a full description of the offer.

Also, the price/area would be a great statistic to include.


feat(kbreadcrumb): add icon slot

Summary

Add icon slot for each breadcrumb (needed for Runtime Manager breadcrumbs).

PR Checklist

[x] Conventional Commits all commits follow the conventional commit standards outlined in the main README.
[x] Functional: all changes do not break existing APIs and if so, bump major version.
[x] Tests pass: check the output of yarn test
[x] Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
[x] Framework style: abides by the essential rules in Vue's style guide
[x] Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
[x] Docs: includes a technically accurate README, uses JSDOC where appropriate

LGTM ⭐


Shared module for lightning flash rate computation

Consolidate the calculation of lightning flash rates (LFR). This module was created by Megan Damon to bring together a suite of LFR parameterizations, which are called from various parts of the model (e.g., MOIST, chemistry).
This PR has no dependencies and should result in zero-diff.

Any chance we can move forward with this pull request? This pull request needs to be merged before two other pull requests can be moved forward ( PR187 in GEOSgcm_GridComp and PR46 in GEOSchem_GridComp ). I would like to start adding additional updates to GEOSCHEMchem but would like this PR to be completed first.

I think the problem is simply that there is no real gatekeeper for GMAO shared.   Anyone can click the button so ... no one does.

Perfect, thanks!


Node properties

Can we use setattr and getattr to move more of the op classes into Node? For example, if we lists of the input names, attribute names, and output names (including info about which inputs/outputs are optional) Node could handle node_input_values, node_attributes  and node_output_values making op definition a matter of providing strings, which we may be able to obtain directly from onnx.

This is now done for all but Placeholder, Cast and Constant.

Done based on schema.


Unwrapped runCmd Output

I think the UX is kind of neat but clicking the little disclosure box next to "Run command in container" all the time to see the runCmd outputs is kind of a chore. Do you think this could be removed, set as optional, or do y'all have some other thoughts here? Maybe related:

https://github.com/devcontainers/ci/issues/188
https://github.com/devcontainers/ci/issues/185

cc @stuartleeks

Still curious for this feature. Did #188 solve it in any way?

Still watching 👀


Settings option to hide tray icon (PowerToys and PowerToys Awake)

Description of the new feature / enhancement
Hello,
I would like to suggest a feature that enables user to customize in settings whether tray icons should be displayed or not.
Application should still work in the background. Goal of this feature request is to minimize amount of applications in tray and maximize immersion (feeling that actual power toys are integrated in Windows instead of being an additional application).
Scenario when this would be used?
Daily basis, quality of life improvements, fewer applications running in tray section
Supporting information
No response

Duplicate of #9526

Duplicate of #9526


Modify create_prediction()

Pull request summary

The list outcomes must contain a minimum of 2 choices and up to a maximum of 10 choices.
Checklist

[x] If code changes were made then they have been tested.

[x] I have updated the documentation to reflect the changes.
[ ] I have updated the changelog with a quick recap of my changes.

[x] This PR fixes an issue.
[ ] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

This is a breaking change and in the current state won't be accepted.
In order for this to be acceptable you need to not change the original behaviour and add to it in a reasonable design.


Not all the links  all movies and series

Not all the links to Stremify all movies and series appear

Could you give more context?

Stale.


Some inconsistent asset naming (OoT  big key)

big_key_item_name_ger.ia4.png
bigkey_item_name_unused_eng.ia4.png
Also I can't seem to find a "Boss Key" english texture, only
boss_key_item_name_fra.ia4.png

The game assets are described in xmls in the game's repositories, ZAPD is only the tool to read these xmls and process the assets. The zapd repo doesn't include assets descriptions
For example the images you're refering to are described in assets/xml/textures/item_name_static.xml in the oot repo: https://github.com/zeldaret/oot/blob/master/assets/xml/textures/item_name_static.xml

So should the XML file be modified?
I also found:
deku_nut_item_name_eng.ia4.png
deku_nut_item_name_fra.ia4.png
dekunut_item_name_ger.ia4.png

My point was this issue is not related to ZAPD, which this is the repository of


update redirection link

The link for Egyptian brackets is broken. This PR will update it to correct one.

thanks, both should be fixed now in the latest tree

Thanks @vapier, Happy to help!


Add a small section in the README about what steps gets registered and what they do

For a quick overview it would be great to have a table like @semantic-release/git and other official plugins already do for this plugin.
Screenshot for TL;DR:

for example without looking into the code it is not clear what steps this plugins registers or what gets executed when (though it could be implied that cargo publish is in publish)

I think this parity with other semantic-release plugins is a great idea!
Contributions are very welcomed 🙂


GH-38206: [CI] Remove more pre-installed files

Rationale for this change
We need more disk space...
What changes are included in this PR?
Remove more pre-installed files.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.

Closes: #38206

@github-actions crossbow submit centos-9-stream-amd64 ubuntu-focal-amd64

Did gh reduce default disk size or something, this is crazy ...

https://github.com/actions/runner-images/issues/8166#issuecomment-1693424389

I talked to my colleagues, they told me that "sometimes" vm is provisioned with small disk. it is bug.

:exploding_head: :see_no_evil:

@github-actions crossbow submit centos-9-stream-amd64 ubuntu-focal-amd64

@github-actions crossbow submit centos-9-stream-amd64 ubuntu-focal-amd64

@github-actions crossbow submit centos-9-stream-amd64 ubuntu-focal-amd64


UI: Display status condition message on package details page

Is your feature request related to a problem? Please describe.
If a package is in the state "installation failed" a user has no further information why the installation failed or if he should do something. Most users won't be able to look up the package status conditions.
Describe the solution you'd like
On the package detail page there should a message with the latest status description
Describe alternatives you've considered
Linking to the Kubernetes Dashboard for example (but this makes not that much sense)
Additional context
Related cli issue:  https://github.com/glasskube/glasskube/issues/899

Hello @pmig @kosmoz I would like to work on this issue.

Hey @Aryakoste! Let's finish #874 first, alright?

just an idea, but the status could become a "special" badge next to (or in front of) repository, installed version etc.
if it's okay, the badge is similar to the "Installed" button now – that one would be removed. i didnt like this anyway because at that position sometimes an action is possible (open) and somtimes its status information.
on click on that status badge, a proper popover appears and shows all details. maybe when the status is failed, there is an extra badge that shows the message directly. something like that. not a huge fan of the popover though (https://getbootstrap.com/docs/5.3/components/popovers/ )
open for discussion how to do this.

Sounds good to me. Alternative to the popover would be a tooltip: https://getbootstrap.com/docs/5.3/components/tooltips/

Sounds good to me. Alternative to the popover would be a tooltip: https://getbootstrap.com/docs/5.3/components/tooltips/

Thought about it too, but copying from a tooltip is difficult, except if we do an additional little "copy" button.

@kosmoz Can I work on this issue. PR has been completed.

So should I show tooltip or a popover. @kosmoz

let's start with a popover

Hello @kosmoz @christophenne  So should i show the badge only when status failed or the badge should be shown on all status. And if so then the badge should be of danger color when Failed and normal when other statuses right. And Secondly i want to ask i have integrated the code and logic but the boostrap popover isnt working do we have to include the js bundle for popover from bootstrap or what else can we do. Below is my code of template.

Status: {{ .Status.Status }}

@Aryakoste I didn't see this when making the suggestion for popovers, but apparently it relies (or relied) on a third party js library (popper.js), which now seems to have been migrated to Floating UI.
I don't really like where this is going, it seems a bit too complex / too far away just to create an easy popover? It looked easier on the (now outdated) bootstrap docs.
I think I'm rooting for a custom solution here instead of including a new library, similar to this: https://www.w3schools.com/howto/howto_css_tooltip.asp – maybe even a "regular" browser-based tooltip (with the title attribute https://www.w3schools.com/tags/att_global_title.asp) will do. If we go for this, I think there should be a little "copy" button next to it, such that the content can easily be copied into the clipboard. Alternatively, we could tease the first part of the status message and truncate it (https://getbootstrap.com/docs/5.3/helpers/text-truncation/).
Completely different alternative: show an alert banner below the package detail header (similar to the error message banner), including the status, only if the package has status Failed. Otherwise, simply don't show the message for now.
What do you all think about that?

I think having the status in the header makes sense, but showing the status message in an alert in case the status is failed would be a good compromise imo

So should i show the badge of status (danger color when Failed) and only show the tooltip with message when the status is failed right.
I will create a custom tooltip / change the styling of abbr tag to create a custom tooltip but where should i define its styling:- in the style tag, create a css file or use inline bootstrap css classess but it will be messy with this i think. @kosmoz @christophenne

I think you could also display a

 showing the message below the header, instead of implementing a tooltip.

Ok will do that. But should I keep the status badge with it or only the alert. @kosmoz

Let's keep the status badge but we don't need a tooltip/popover/..., since we have the alert as a replacement


tsserver mangels output when more than one request is pending

We are sending quite some requests to the tsserver. We make sure that what to put onto stdin is always one request, however we don't queue them on the sending side.
The output send from the tsserver mangels different response. See the attached msg.json. Interesting lines are: end of line 1 (e.g {"nContent-Length: 214 )or 125 (e.g. {"Content-Length: 70021 )
From the output it looks like the inference comes mostly from the syntax and semantic events send from the server.

@steveluc since I can't attach files I will send you the msg.json by mail

So far we can't only reproduce under Mac. Doesn't reproduce under Windows so far. One additional thing to note is that under Mac we execute on atom.exe which is based io.js instead of node.js

You could potentially post a gist for the log.

how are you reading the input? are you checking if content-length < size of message to keep reading?
is it something like: https://github.com/Microsoft/TypeScript-Sublime-Plugin/blob/master/libs/nodeclient.py#L178

Based on what you've told us so far, that looks like a case in which two 'threads' are both trying to write to stdout.  For example, the syntax and semantics diagnostics happen in a timer 'thread' that writes events to stdout, whereas the readline handler processes requests and writes responses to stdout.  Is it possible that io.js will allow a timer interrupt to take place in the middle of a readline handler?  This doesn't seem like correct node behavior, but it does match the scenario you are describing.

@DanielRosenwasser thanks for the gist tip. Wasn't aware of the feature. The log can be found here https://gist.github.com/dbaeumer/53d84d04d787aa23bd50

@mhegazy yes, we are handling content-length . We already receive a mangled buffer

@steveluc: I don't think this is a threadding problem after scanning through the code (I first thought it is a async/callback problem but TS isn't async :-). I think the problem is in the TS System implementation for node. The TSServer calls System.write which is implemented as
write(s: string): void {
// 1 is a standard descriptor for stdout
_fs.writeSync(1, s);
}
But writeSync returns the number of bytes written. So we need to have a loop around this. I will see if implementing this correctly will fix it (test with our Mac setup on Monday) and provide a pull request if it does.

Great, Dirk!  Looking forward to the results.

@dbaeumer can we make sure that this is the root of the cause? In other words, verify that the number of bytes written is indeed doesn't match the length of the data when something goes wrong.

@dbaeumer thanks for digging into this! would you be interested in sending a PR for it?

OK. Here is what I did so far: I changed the implementation to have a loop around writeSync which checks the written bytes. This now sends more data, but revealed another bug: sometimes the writeSync fails with: -1 EAGAIN (Resource temporarily unavailable). However this is only seen under atom not under node.
In general writeSync is IMO bad since it requires that someone on the receiving side reads which might not always be the case.
Since we send a lot of data over stdout I think the implementation should not use write from System. Instead the tsserver should do the following.

maintain an output queue containing responses
have a function that sends the output in an async way and considers the drain event.

If you think that is the right thing to do I am happy to work on a PR (after //build) to get this into the tsserver.

@dbaeumer i agree with the approach. @steveluc any objections?

Worth pointing out from http://www.daveeddy.com/2013/03/26/synchronous-file-io-in-nodejs/:

If you want to open a file for synchronous IO, you'll have to use the lower level fs functions that Node offers such as fs.open() and fs.fsync().

I agree we should move to asynchronous I/O, since this is the preferred node model.  I think though that we should simultaneously consider re-factoring the protocol if we find we are regularly sending messages larger than 64K.  writeSync on stdout only blocks if the 64K buffer fills (the buffer can also be made bigger).  It makes sense to use async I/O for rare cases where we might fill that buffer, but performance will suffer if we are regularly stuffing that buffer so full that the client reader thread isn't draining it, whether or not the I/O is async.  So I would like to understand what response message(s) are sending large amounts of data and whether we can re-factor the protocol to avoid this.

Completions can send a lot of data when triggered in cases where no prefix exists and where the global scope is available. var foo:
We can still implement the queue and send small messages using writeSync. I wouldn't change the protocol since it might require changing it when implementations change

thanks @dbaeumer

This problem happens again with Node v4.2.1 on OSX, which starts to throw the EAGAIN exception and truncates the output if the string we send to writeSync is too long. Considering node v4 is the first long-term supported version, we should probably figure out a way to work around this issue. Reopening it.

This has not been an issue. closing.


Option to disable logging of "Server" in audit log

when log level < 9.
[Issue #1070 - Marc Stern]

Merged! Thanks!


node js

node:internal/modules/cjs/loader:1080
throw err;
^
Error: Cannot find module 'xtend'
Require stack:

Hi @Joseph-Ambooken,
Hope you've already found a fix - but in case not, would you mind to share more details on the issue you've encountered so we could help to see if there's a bug with create-react-app?
Thanks


ObjectMapper configuration

Hi!
Thanks for the answer on my previous issue, it worked nicely.
I think the extension would be more reusable if it was possible to supply own configuration of: com.fasterxml.jackson.databind.ObjectMapper
In my case usage fails with the following:

org.jboss.resteasy.spi.UnhandledException: javax.ws.rs.ProcessingException: com.fasterxml.jackson.databind.exc.InvalidFormatException:
Cannot deserialize value of type java.util.Date from String "2020-12-11T13:15:23.000 +0100": not a valid representation
(error: Failed to parse Date value '2020-12-11T13:15:23.000 +0100': Cannot parse date
"2020-12-11T13:15:23.000 +0100":
while it seems to fit format 'yyyy-MM-dd'T'HH:mm:ss.SSSX', parsing fails (leniency? null))

If I could apply my own configuration, something like this would solve my case:
@ApplicationScoped public class LogObjectMapper { 	@Inject 	ObjectMapper mapper; 	public ObjectMapper createForLogging() { 		mapper.setDateFormat(new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSX")); 	} }
I think the same configuration would be nice for jsonb also.

Hi can you describe the use case where you need this?

Hi can you describe the use case where you need this?

Use case:
The application makes an outgoing rest call to an external service and receives a response.
The response contains data and one of the fields is a Date field on the format:
2020-12-11T13:15:23.000 +0100
And in order to be able to successfully deserialize this field, it must be possible to configure it
New DateFormat(new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSX")
Another cases:
The possibility to skip logging of byte[]:

registerModule(new SimpleModule("CustomByteArraySerializer").addSerializer(byte[].class, new CustomByteArraySerializer()));

Include only non empty:

setSerializationInclusion(JsonInclude.Include.NON_EMPTY);

Disable failing on empty beans:

disable(SerializationFeature.FAIL_ON_EMPTY_BEANS);

Example of content in CustomByteArraySerializer class:
`public class CustomByteArraySerializer extends ByteArraySerializer {
@Override
public void serialize(byte[] value, JsonGenerator gen, SerializerProvider provider) throws IOException {
gen.writeString("truncated original size: " + value.length);
}
}`

Use case:
The application makes an outgoing rest call to an external service and receives a response.
The response contains data and one of the fields is a Date field on the format:
2020-12-11T13:15:23.000 +0100
And in order to be able to successfully deserialize this field, it must be possible to configure it
New DateFormat(new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSX")
Another cases:
The possibility to skip logging of byte[]:

registerModule(new SimpleModule("CustomByteArraySerializer").addSerializer(byte[].class, new CustomByteArraySerializer()));

Include only non empty:

setSerializationInclusion(JsonInclude.Include.NON_EMPTY);

Disable failing on empty beans:

disable(SerializationFeature.FAIL_ON_EMPTY_BEANS);

Example of content in CustomByteArraySerializer class:
`public class CustomByteArraySerializer extends ByteArraySerializer {
@Override
public void serialize(byte[] value, JsonGenerator gen, SerializerProvider provider) throws IOException {
gen.writeString("truncated original size: " + value.length);
}
}`

There are 2 options based on CDI to allow you to do that easily:

use the ObjectMapperCustomizer core infrastructure with a specific qualifier (I think this would work, if it doesn't we will probably fix it in core) and you would do something similar to the core ObjectMapperProducer but with this specific qualifier.
you could produce a @DefaultBean ObjectMapper with a specific qualifier and the user could produce another one and it would replace the @DefaultBean one.

There are 2 options based on CDI to allow you to do that easily:

use the ObjectMapperCustomizer core infrastructure with a specific qualifier (I think this would work, if it doesn't we will probably fix it in core) and you would do something similar to the core ObjectMapperProducer but with this specific qualifier.
you could produce a @DefaultBean ObjectMapper with a specific qualifier and the user could produce another one and it would replace the @DefaultBean one.

What I think of  as the most simple solution is that you use your existing ObjectMapper to convert your object to a JsonNode.
Like this:
@Path("/hello")
public class ExampleResource {
    private Logger log = LoggerFactory.getLogger(ExampleResource.class);

    private ObjectMapper mapper;

    @Inject
    public ExampleResource(ObjectMapper mapper) {
        mapper.setDateFormat(new SimpleDateFormat("yyyy-MM-dd HH:mm:sss")); // Just for simplify example
        this.mapper = mapper;
    }

    @GET
    @Produces(MediaType.TEXT_PLAIN)
    public String hello() {
        // Mapping object to JsonNode using existing ObjectMapper resulting in same json as actual send/received.
        final JsonNode jsonNode = mapper.valueToTree(new Testing());

        log.info("Test", KeyValueStructuredArgument.kv("KEY", jsonNode));

        return "Hello RESTEasy";
    }

    static class Testing {
        private Date now = new Date();

        public Date getNow() {
            return now;
        }
    }
}

Resulting in a log like this:
{"timestamp":"2021-01-26T12:19:45.441+01:00"....,"processId":884,"KEY":{"now":"2021-01-26 12:19:045"}}

What I think of  as the most simple solution is that you use your existing ObjectMapper to convert your object to a JsonNode.
Like this:
@Path("/hello")
public class ExampleResource {
    private Logger log = LoggerFactory.getLogger(ExampleResource.class);

    private ObjectMapper mapper;

    @Inject
    public ExampleResource(ObjectMapper mapper) {
        mapper.setDateFormat(new SimpleDateFormat("yyyy-MM-dd HH:mm:sss")); // Just for simplify example
        this.mapper = mapper;
    }

    @GET
    @Produces(MediaType.TEXT_PLAIN)
    public String hello() {
        // Mapping object to JsonNode using existing ObjectMapper resulting in same json as actual send/received.
        final JsonNode jsonNode = mapper.valueToTree(new Testing());

        log.info("Test", KeyValueStructuredArgument.kv("KEY", jsonNode));

        return "Hello RESTEasy";
    }

    static class Testing {
        private Date now = new Date();

        public Date getNow() {
            return now;
        }
    }
}

Resulting in a log like this:
{"timestamp":"2021-01-26T12:19:45.441+01:00"....,"processId":884,"KEY":{"now":"2021-01-26 12:19:045"}}

gsmet: Thanks for your proposal
From what I can see in the code quarkiverse.loggingjson it use:
JacksonJsonFactory, which configure ObjectMapper
I was not quite sure how to use your suggestion, but was able to use the other suggestion easily, with minor modification in my code.
SlyngDK: Thanks for your proposal, it worked perfect!

gsmet: Thanks for your proposal
From what I can see in the code quarkiverse.loggingjson it use:
JacksonJsonFactory, which configure ObjectMapper
I was not quite sure how to use your suggestion, but was able to use the other suggestion easily, with minor modification in my code.
SlyngDK: Thanks for your proposal, it worked perfect!


chore(ci): pre-commit mypy

Addresses #37

Need feedback on which mypy arguments are relevant.

Hi @elliotwutingfeng, great work, thanks!
Reviewing your contribution will take some time, as I need to understand why mypy doesn't find stubs for packages that should have stubs.
I will reach back to you asap ;-)

Well, I think it's fine to merge this now @elliotwutingfeng
Making mypy happy is a long term goal, so I won't bother having some errors for now.
Thanks!


Create SwiftShell Terminal

Besides the commands in swift playground, we should create a terminal like ipython or powershell (windows).

The is a good idea but not the primary goal. It will take a lot of time to create an interactive playground.

I didn't mean another playground!
Actual terminal like powershell or a package that can be installed on bash terminal like ipython

I understand. It's still a lot of work and we will lose what we will get for free using Xcode (syntax highlighting, auto completion, for example). They are the reasons to experiment with SwiftShell.


Added some more information to the README

Thank you! This is great, good with the BOM notes as well.


What versions of Python are supported? Not 2, right?

That can be read from inspecting the setup.cfg file but it would make sense to have the usual setup classifiers in that file.
BTW, some other classifiers are probably missing as well. To be checked.

This has been addressed.
The changes are only on the update banch for now, but it will be merge to master soon.


Alignment procedure explanation blog is offline

Hello,
The blog mentioned in the readme is offline. (https://www.samtalksml.net/aligning-vector-representations/)
Would it be possible to make thet blog available again?
Thank you

Hi Filipe,
You can reach the blog (text) for now with the help of WayBackMachine.
https://web.archive.org/web/20201111222742/https://www.samtalksml.net/aligning-vector-representations/
I will look into sourcing and storing this within the repo.


Raknet incompatibility with Geyser / Floodgate

When using Raknet and Geyser + Floodgate the console gets flooded with error messages. The server doesn't crash, and people can still connect. It just makes tracking everything else extremely difficult due to the console flood.
https://paste.gg/p/anonymous/14576c3a89ff4ed7a59e1f6e8ad1fca0

latest.log

https://github.com/GeyserMC/Geyser/issues/2898

it's impossible for it to work if geyser and raknetify are on same port

because both use raknet so packets get mixed up


How to get debug log for bosh create-env

For bosh-init, we can set BOSH_INIT_LOG_LEVEL=debug environment variable  to get full debug log.
How to get full debug log for bosh create-env using boshcli v2?

The environment variable was renamed to BOSH_LOG_LEVEL.
BOSH_LOG_LEVEL=debug bosh create-env ...


Fix legacy_uid

Looking at 31523ce4d04759a12b54dd1ff9f781e63a4b6888, we used to do it differently, and it turns out that the new way seems to return a "00000000000000" value with the H520
I'll try to get this tested on an H520 before merging it :smile:

Oh, actually uid is already a uint64_t in the AUTOPILOT_VERSION message :thinking:.


Improved translation and GUI layout

Improved French translation sentences
Improved English translation sentences and reordered lines to ease comparison between translations files
Removed duplicate keys in translation files and added spaces at some locations to ease comparison between translations files
Reworked a bit some GUI controls layout to improve readability and allow longer sentences

It seems that there is a conflict due to the capital letter of the word "Français" (that should be kept).

Thanks 👍


（WIP）feat:XA transaction basic shelf construction

What this PR does:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report
Base: 35.28% // Head: 35.28% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (59d872d) compared to base (88a5f06).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #579   +/-   ##
=======================================
  Coverage   35.28%   35.28%
=======================================
  Files         182      182
  Lines       21131    21131
=======================================
+ Hits         7456     7457    +1
+ Misses      12837    12836    -1
  Partials      838      838

Impacted Files
Coverage Δ

pkg/runtime/runtime.go
2.14% <0.00%> (ø)

pkg/sequence/snowflake/snowflake.go
12.37% <0.00%> (ø)

pkg/dataset/priority_queue.go
77.61% <0.00%> (+1.49%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

需要rebase一下吗


Cannot add multiple incident reports to one incident ticket in 2016 instance

In trying to create an incident to attach an unattached incident report to, I was unable to enter more than one incident report to the same incident ticket.  This might be a problem.

Closing, can't reproduce now.


Defer Vulkan CPU sync until the next frame begins

Reduces the impact of the pipeline stall by moving it after presentation, and provides a simple test for whether a runtime properly synchronizes presentation with application work.

Thanks, merging! (had a chance to test it with Monado finally)


Can't serve content outside of localhost when following the production instructions

New user here. I'm using a Linode Ubuntu VPS and I've followed the instructions in the README, then those at http://support.ghost.org/installing-ghost-linux/ (prefixing most commands with sudo, which is overlooked in the guide), to get Ghost started. In both cases, navigating to myDomain.com:2368 fails with ERR_CONNECTION_REFUSED.
http://support.ghost.org/installing-ghost-linux/#starting-ghost claims that node will listen to 2368, but in actuality I see Your blog is now available on http://my-ghost-blog.com. Is there an interface binding issue going on? I don't have a firewall installed on that host yet and I have verified that other node apps work (e.g. Meteor apps listen to port 3000 just fine).
I've tried more things in the production instance: change the server in config.js to my domain, change the port to 80 (and make sure nginx was stopp). No luck.
dandv:/var/www/ghost$ sudo npm start --production

><EMAIL_ADDRESS>start /var/www/ghost
> node index

Migrations: Up to date at version 003
Ghost is running...
Your blog is now available on http://idorecall.com
Ctrl+C to shut down

In another terminal:
 $ wget http://idorecall.com
--2015-05-09 18:43:14--  http://idorecall.com/
Resolving idorecall.com (idorecall.com)... 2600:3c01::f03c:91ff:fe37:344d, <IP_ADDRESS>
Connecting to idorecall.com (idorecall.com)|2600:3c01::f03c:91ff:fe37:344d|:80... failed: Connection refused.
Connecting to idorecall.com (idorecall.com)|<IP_ADDRESS>|:80... failed: Connection refused.

Accessing the blog on the VPS server works (lynx http://localhost:2368).
Next, I've changed config.production.server.host to my domain name (idorecall.com), left the port to 80, and Ghost serves content. Totally understandable of a change, but nothing mentioned at http://support.ghost.org/installing-ghost-linux/#starting-ghost, which doesn't suggest that Ghost should be proxied by a web server either.

Hey @dandv, welcome!
First, there's no su/sudo in the docs because in general it's better to install and run as a user other than root.
Second, I'm pretty sure the trouble you're having is that by default Ghost (node) is going to bind to your loopback interface (<IP_ADDRESS>) and won't be accessible externally without a proxy (the recommended setup). If you change config.js to point to <IP_ADDRESS> Ghost will bind to all available interfaces.

Thanks @jaswilli! That does seem to be the case (I've edited the end of my OP after I got Ghost running). The Ghost live instructions should be updated perhaps?

The "next" link at the bottom of that page of installation instructions takes you to the instructions for how to get started running Ghost and there's a section about using a proxy server.  Perhaps it should also be added to the other documentation as well.  The people that write those docs see these issues so if they agree they can do it.
Anyway, I'm going to close this as I think everything has been sorted out.  If you run into more trouble feel free to give a shout, or head over to the Slack channel (https://ghost.org/slack/) and there are usually people around to answer questions.

Perhaps default config should consider this use-case (or should be noted in install guide). Makes for a frustrating first time dev experience when server is unavailable outside of localhost.

Or at least add a line of description in official guide, http://support.ghost.org/getting-started/

Gah.  I'm mostly loving Ghost, and trying to overlook warts, but 2 years later on this thread (but right now for me) and still no mention of editing the config.development.json file in the docs!  It does make for a frustrating initial experience to have to struggle with this issue.


fix: Downscope permissions in the 1-click launch template

Describe your changes

Downscope permissions in the 1-click launch template

Checklist before requesting a review

[x] I updated CHANGELOG.MD with a description of my changes
[x] If the change was to a module, I ran the code validation script (scripts/validate.sh)
[x] If the change was to a module, I have added thorough tests
[x] If the change was to a module, I have added/updated the module's README.md
[x] If a module was added, I added a reference to the module to the repository's README.md
[x] I verified that my code deploys successfully using seedfarmer apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
Commit ID: e6a2e675b8002d2f86e3aa634abdff52bd88bdb6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
Commit ID: 573194a40d6e3726e9b9b3388e342554b54b53a5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
Commit ID: 68304aa1f458928e0361ed0ed1358d273f883ae0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


[MINOR][CORE] Log committer class used by HadoopMapRedCommitProtocol

What changes were proposed in this pull request?
When HadoopMapRedCommitProtocol is used (e.g., when using saveAsTextFile() or
saveAsHadoopFile() with RDDs), it's not easy to determine which output committer
class was used, so this PR simply logs the class that was used, similarly to what
is done in SQLHadoopMapReduceCommitProtocol.
How was this patch tested?
Built Spark then manually inspected logging when calling saveAsTextFile():
scala> sc.setLogLevel("INFO")
scala> sc.textFile("README.md").saveAsTextFile("/tmp/out")
...
18/05/29 10:06:20 INFO HadoopMapRedCommitProtocol: Using output committer class org.apache.hadoop.mapred.FileOutputCommitter

Can one of the admins verify this patch?

ok to test

Test build #91286 has started for PR 21452 at commit 9881d9c.

Test build #91286 has finished for PR 21452 at commit 9881d9c.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds the following public classes (experimental):
    logInfo(s\"Using output committer class $

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91286/
Test FAILed.

Seems like the test build failed for an unrelated reason, right? This is my first contribution in a long time; have the tests been flaky lately?

@felixcheung or @jiangxb1987, do you know what's going on with the tests? Should they be retried?

Jenkins, retest this please

Test build #91379 has started for PR 21452 at commit 9881d9c.

Test build #91379 has finished for PR 21452 at commit 9881d9c.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
    logInfo(s\"Using output committer class $

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91379/
Test PASSed.

Can one of the admins verify this patch?

Test build #91640 has started for PR 21452 at commit 9881d9c.

Test build #91640 has finished for PR 21452 at commit 9881d9c.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
    logInfo(s\"Using output committer class $

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91640/
Test PASSed.

Merged to master


in memory CRUD

Hi is there a way to use the crate with sqlite memory? I was looking at create_table_from_entity but not sure how to combine it with sqlx-crud

All of the doc tests I have in the code use the sqlite in memory database. Just start a sqlx connection.
SqlitePool::connect(":memory:")

It looks like create_table_from_entity uses SeaORM. This project is designed to work with sqlx. I'm not familiar with SeaORM but if you can share the same sqlx connection pool between sqlx-crud and SeaORM then it should work fine.


This is a useful subreddit if someone wants to explore embedded syste…

…ms and work on hardware level.

Thank you so  much for you time 😊


Update hype to 3.6.3

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as fec5d1d1f83d9d655e71070d3b0586c68147d17e. Your contribution is still credited to you.


Clean up "new members" stream concept for where you land after tutorial

Currently, right after the tutorial, we land you in a narrow to the default announce stream.  This is a holdover from the fact that we renamed announce to zulip at some point; the latter name made more sense for this application.
In https://github.com/zulip/zulip/pull/3377, we added support for a "new members" stream, controlling which stream users land in when they join a Zulip organization.  This fixes the problems for chat.zulip.org, but we should think more about the broader issue.
Options include:

Making zulip be a different default stream from announce
Making this admin-configurable
Not landing you in a stream narrow at all
Other ideas

Thoughts?

I think this is generally resolved by initial narrow into PM + hotspots system (which will take you to a new members stream if it exists). Closing, since I think no longer useful to keep track of the work here.


S3: HTTP error when uploading

I recently upgraded to v1.1 and am running into issues with S3.upload in my integration tests. Before the upgrade everything was working, but now I keep getting the following error when uploading/putting objects to S3
ExAws: HTTP ERROR: :nxdomain
Also, I use fake-s3 (https://github.com/jubos/fake-s3) for stubbing purposes. Here's my test config (test.exs)
config :ex_aws, :s3,
  access_key_id: "some_fake_key",
  secret_access_key: "some_fake_key",
  scheme: "http://",
  host: "localhost:4569",
  region: ""

I'm pretty sure fake-s3 is running and resolvable. Any idea what's going on here?

If you do ExAws.Config.new(:s3) what do you get? This would be in your MIX_ENV=test environment.

@benwilson512
iex(1)> ExAws.Config.new(:s3)
%{access_key_id: "some_fake_key", host: "localhost:4569",
  http_client: ExAws.Request.Hackney, json_codec: Poison, region: "",
  retries: [max_attempts: 10, base_backoff_in_ms: 10, max_backoff_in_ms: 10000],
  scheme: "http://", secret_access_key: "some_fake_key"}

Looks legit to me.

Ok, if you add
config :ex_aws, debug_requests: true

what output do you get prior to the nxdomain error?

I should add that you'll need to set your log level to debug as well

Ahh I can see something weird with the constructed URL
11:02:26.660 request_id=7noka0qqlvg9l50iumcdro2gil82kuv0 [debug] Request URL: "http://[localhost:4569]/foo/bar/baz.jpg?uploads=1"

aha! You want
config :ex_aws, :s3,
  access_key_id: "some_fake_key",
  secret_access_key: "some_fake_key",
  scheme: "http://",
  host: "localhost",
  port: 4569,
  region: ""

We could definitely handle that better though.

D'oh! Pretty sure port wasn't there in 1.0, or am I mistaken?

At any rate it works now. Cheers @benwilson512!


Build pipeline

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: jipakash sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Customization of modal

Hi,
is there a way to add checkboxes or radio buttons for the modal, currently only input field is allowed/generated.
I would like to add the option to choose some custom styles (classes) for the image upload, to allow the user to decide sizes (large, medium, small), as well as position (left, center, wide, right)
It's possible if he enters the text manually but i would like him to choose some radio buttons, or dropdown.

Dropdown and radio are not supported because useless for the core.
Checkbox are implemented.
I you case, you should generate the form yourself in your plugin and use: http://alex-d.github.io/Trumbowyg/documentation.html#modal-box

Is there a way to pass like "values: ['a', 'b', 'c']" to the checkbox, since now it takes the name of the class as the value. And does not allow multiple options. (also multiple labels would be nice):
Example:
Position: [] Left, [] right, [] middle
label: 'Position',
values: { 'left': 'Left', 'right': 'Right', 'center': 'Middle'},
type: checkbox (or radio, since it works too)

Nope. In the core, only checkbox logic is supported. Radio works yep but are not used / tested.
You can't pass an array of values. You need to create a radio for each item :/

I am aware that currently it's not possible, it's just a few extra lines of code to support $.each on values (around line ~1380). I will give it a try. Should not increase the codebase so much.

Should not increase the codebase so much.

I will need to refine the code but it looks like this:
http://b3.ms/06j9d0YO9abK
Also, i will propose a new CSS at some point (removed dark theme too).
Modals should not be harcoded fonts and fontsizes, since you use it already in a skinned environment.

I just offer a default theme built-in. Feel free to made your own.
If your modification cannot be merged, it's OK. Do not feel obliged to make a pull request.


Remove using namespace tt::tt_metal from common header

We have using namespace tt::tt_metal in one the most common headers.
We also have many classes which are called the same.
During past 4 weeks multiple folks hit several similar issues because symbols were not resolved correctly by the compiler.
Need to remove this using namespace and consider some check on CI to make sure nobody else ever adds this again.

Consider using
https://clang.llvm.org/extra/clang-include-fixer.html


fix typos in README docstring replace

Markdown format
Fix typo on docstring replace line 387

Perfect, thank you! 👍
The README should also be updated on pub.dev, where most people will see it. @justkawal

Sure, I'll update it.


Issues with baseline PeakFP

Hi, I'm trying to use PeakFP to the best of my understanding. I took 35 songs (roughly 120 minutes of audio), ran extractor.py on each one, then ran indexer.py in order to generate an index (I provided a txt file containing the paths to all the fingerprint files). The generated index is ~20MB. Next, I tried to run matcher.py on an 8-second query, however the script never finishes.
If I break it after a long time (e.g. >10 minutes), it's busy adding to the interval tree itree.addi(match['start'], match['end'], match). I let it run for >3h and it still did not finish a single 8-second query.
I reduced sensitivity from 5 matches minimum to 12 matches, which reduces the amount of matches by a factor of x10, and even then it gets stuck at itree.split_overlaps() - I gave up after some 10s of minutes, as from what was reported in the paper, I was expecting a runtime that's only, say, a x10 factor slower than real-time, but I'm getting well over x100.
Any ideas why? Am I using the library incorrectly?

Hi @shenberg,
Thanks for your interest in baf, right now I am a bit busy with other things but I will try to take a look into it.
In the meantime can you provide some information to reproduce your error? like Os platform, python and package versions, exact commands you are running, etc.
Many thanks!

Sure, thanks for the response!
I'm running on an M1 max Macbook pro with  MacOS Ventura 13.6.2, installed PeakFP in a virtualenv with Python 3.8.18.
i had to change the requirements a bit in order to get a functional install - older versions of numpy don't work smoothly with ARM-based macs so I changed the requirements file to be:
intervaltree==3.1.0
librosa==0.8.1
scikit-image

And then everything installed smoothly.
I don't know if it's normal, but for me, run_matching() in matcher.py would end up with on the order of 300k matches in processed_matches with the default settings, then spend an incredibly long time in the interval tree. I tried modifying the code to create an interval tree per reference id, and then to coalesce matches between references, but I still ended up having to reduce the sensitivity by a ton (min_peak_threshold 13 instead of 5 where necessary) and results were pretty bad...


Fix linter missing .htmlhintrc if not in the active directory

Auxiliary directory kill the hierarchy folder search.
Here, the plugin will only look for .htmlhintrc in "~" or the directory of the inspected file, missing a .htmlhintrc file at the root of the project.
Removing the auxiliary directory will still find a .htmlhintrc file in "~" if no other config file are found while moving up from the directory of the inspected file.

Thanks!


Bug: Format errors with QA modals

Steps to Reproduce
Issue 1:

Log in to ECMPS
Select a config
Select Linearity Summary as a test type
View a protocol gas record

The following issues are present In Modal view:

Expiration Date is showing "undefined/undefined/"
Remove Summary Type from in front of Gas Level Code under Protocol Gas Code section

Issue 2:
The system is not showing the test type code. Instead, it is displaying select a value. This is happening for Fuel Flow to Load, Test Qualification, and Flow to Load Check

Log in to ECMPS
Select a config
Select Fuel Flow to Load, Test Qualification, or  Flow to Load Check as a test type
View a record

1/5/2022: @JanellC @mosesdeeCVP Corey and I tried recreating the issue with the Expiration Date and Test Type Code. We couldn't in the dev env, but please ping us if you see it when testing. Thanks

Expiration Date is showing up fine. The Gas Type code is not showing up due to it having multiple codes. This will be resolved in a different ticket.

Bug Fixed

Test Type Code

Protocol Gas