Text Style: Changing font family should result nearest font weight

(Updated 6/12/2020)
Summary

When there is only 1 font weight in an entire text element and you switch font families, you will not end up with "mixed" - formerly "multiple" (placeholder was updated over the lifespan of this branch).
When an existing font weight is not available when you make said switch of font families, we will get the closest available weight to that previously existing weight.
When you have multiple font weights and you switch weights, if you have the entire text element in focus you will still see "mixed", BUT when you enter that text element, if you had "light" selected but now only regular or bold are options, it'll update the selected weight to be regular when you make that portion of text element active again.

Relevant Technical Choices

This has been tricky! I added notes inline to the useEffect hook that's handling these updates. I think walking through that is the easiest way to note what happened. Here's the TL;DR

new util called getClosestFontWeight that will return the weight value closest to the desired value should that desired value be unavailable.

Created refs for both fontWeight and fontFamily because we get a flash of default fontWeight and family that flashes bad values for the weight dropdown as well as interrupting our check of if the set font weight is available. By having refs we can check and see if what we are looking at is current or not based on if the font family or weight changed actively by the user.

Added a useEffect hook that does the following in this order (returns if a criteria is met):

1. If the `fontFamily` doesn't match the `fontFamilyRef` then we ignore any potential weight changes. `fontFamilyRef` stays true to the `fontFamily` chosen by the user regardless of default content or flashes back to reset depending on where you are clicking or selecting.
2. if there is only 1 available weight in the given set of `fontWeights` then we know that's the weight we want. Check to see if this weight was already updated to (this check only needs to be there for when the font family or font weight select menu is expanded again with that default value sneaking through). If the available weight doesn't match the ref weight then we update the font weight and ref.
3. if the `fontWeight`'s true value is "multiple" then we just leave it at this point. We know there are more than one available weight values, that's enough.
4. If we have gotten this far it means we are inline to the text element. So we check to see if the `fontWeight` that was/is selected is available to our list of weights and then we check to see if that value is the same as the existing value. If they are different, we update the value and the ref with the new value.
5. Lastly, if we got here we can trust the content and should just keep the ref current.

Anddd I memoized the visible value of the font weight on select menu. This was getting a little complicated and I didn't want to add a second ternary to do a check on how many available font weights were present. Now we are doing that same check for flashing default font family/return back to the old font family value when updating it, and then within the "multiple value" we're making sure that there are more than 1 option for value, when it's just the one i'm forcing that as the value.

This bug is tricky because we can't possibly know where in the text element is active. It could be the entire element, a highlight of text, or just the cursor active in the field. I tried really hard to stay contained in this specific new piece of functionality to avoid a trickle of potential new bugs stemming from altering functionality of how anything is focused. I couldn't just update the font weight for when "mixed" was set without having the text element blow up on me when i entered into it occassionally. I've found this approach to be more congruent, if more involved.

I did make one update outside of textStyle/font that I want to draw attention to - richText/useSelectionManipulation. I was noticing that the text elements were trying to update with old/null data sometimes if you click too fast on an element. I added an early return for if the oldState doesn't exist in the updateWhileUnfocused check, this prevents the editor error-ing out for me when I'm just waiting for data to return.

To-do

I'm hoping that my novel above helps point out a better way to handle this without needing early escapes for out of date data in the future
Also, if this is an appropriate solution then I have some unit tests to add and update.
Sometimes the font weight that's shown as the value in the dropdown doesn't update from "mixed" - I've found that this stems from swapping a font family, then adjusting inline weight and then changing the font family again without clearly updating the focus of the text element to the whole thing. If anyone else can point out how to manage this without having other issues pop up I'm all ears, for me, this is an OK edge case for the sake of the main fix. it seems like something to do with the currently selected item not being current - last week i traced this towards the fauxSelection process but I don't know enough about how that whole process works and this feels like a separate issue.
Also of note, if you have mixed font weights and swap fonts to a font that doesn't support 1 of the weights but it still has some weight that was set inline, if you swap back to a font family that does support that existing inline weight, it'll still exist.I don't really think there's a way to fix that here within the existing structure of how focus is obtained and maintained. It's one of the reasons why this has gotten so tricky.

User-facing changes

See summary

Testing Instructions

If a text element has multiple weights applied to it, when a new font family is picked the weight for the entire text element should  remain "mixed" if you have the entire text element in focus.
if a text element has multiple weights applied to it, but you are INLINE of the text element when a new font family is picked then the shown font weight value in the dropdown will be the font weight that it was in the previous font family selected OR if that weight is no longer available it will be the closest weight to that old value.
If you have a nice, simple text element that only has one weight and you update the font family, if that font weight is not available in the new family's weights then the closest weight to the weight that was selected will be applied and visible. aka no more 'mixed'. The caveat here is that note in the "to do" section, where sometimes the set selection focus is out of sorts with what you're trying to update and you might see Mixed.

Bug reproduction:
Add text element
Assign font family Open Sans Condensed, font weight Light
Now change the font family to Playball
See "multiple" as the font weight.

Now:
Add text element
Assign font family Open Sans Condensed, font weight Light
Now change the font family to Playball
**See "Regular" as the font weight.**

Addresses #1899

Hm, the intent of the original ticket here was to simply do:

When the font family changes, make the entire text "font-weight: 400" regardless of the previous font-weight.

I'm still confused about how this PR addresses that goal?

Perhaps this ticket warrants more conversation, when I read through the comments of #1899 I saw this as the new acceptance criteria: https://github.com/google/web-stories-wp/issues/1899#issuecomment-652080018 (from Omar)

We discussed this in a recent call and agreed to fixing this. No "multiple" shown, we'll just have to do approximations in some cases. When switching fonts it is ok to approximate to closest supported weight and/or default to "normal".

So in the cases where part of a font has a weight that was supported that is no longer supported I was opting to let the spans set with inline weights exist since they are doing no harm, then when the user goes back to the text element the font will update with the current weight. This allows the "multiple" set weights to coexist still as they would for roboto with parts of a text element set to light, normal and bold.
If I am misunderstanding and we just want to scrub the font weights when a new font family is picked that sounds way easier to fix!

ok, @barklund ! I think I'm maybe finally tracking with what you're saying? Fast forward from my earlier comments and look here: https://github.com/google/web-stories-wp/pull/4734/commits/83889d2686d0b1f7d33d2a092e6b37d4eb770700
Instead of using a useEffect hook to wait and see when there's updates I updated the check for the fontWeight to exist to be a callback and put it in with handleFontPickerChange to be able to use the newFont's available weights and eliminate some dependencies for the callback.  So using those available weights to find the one closest to the currently selected weight.
And i think this is where our disconnect is. I am operating under the impression that we want to find the weight closest to the currently selected weight. HOWEVER, this will not work if I have many weights in one text element and my cursor is on one part of the text element (let's say a bold part but the rest isn't) - so when i update my font the current weight is bold and if bold is available in the new font family the maybeUpdateFontWeight won't see the need to update the font weight as a whole and skip over updating. See the two gifs attached.
So if we want to just reset the font weight to regular or 400 and if that font family does not have a regular or 400 then the closest weight to regular or 400 (NOT the closest weight to the currently selected weight) would be a whole heck of a lot easier to do!
This updates the whole font weight (and if you swap back to Roboto it'll all be regular again)

This doesn't update the whole font weight because my cursor is IN the text and current weight is found in new font family.

(sorry for the weird element outlines, please ignore - it's just something weird my browser does when i have dev tools open that I haven't taken the time to look into fixing)

So if we want to just reset the font weight to regular or 400 and if that font family does not have a regular or 400 then the closest weight to regular or 400 (NOT the closest weight to the currently selected weight) would be a whole heck of a lot easier to do!

I believe that's what we agreed to do as summarized in the ticket. I can see that Omar's comment is confusing though. This was discussed with Sam, but maybe on call or on Slack. If you change font, you have to re-select weights, as the new font will most likely look completely different anyway - it is an acceptable tradeoff.

This doesn't update the whole font weight because my cursor is IN the text and current weight is found in new font family.

Not sure I understand this restriction? Why can't we convert the whole font to 400 even if you're editing? I can see that we might have to do some magic to restore the cursor position, but it should definitely be doable.

(sorry for the weird element outlines, please ignore - it's just something weird my browser does when i have dev tools open that I haven't taken the time to look into fixing)

Thanks for the quick reply last night! This:

. If you change font, you have to re-select weights, as the new font will most likely look completely different anyway

is what i was missing, woo!
Instead of basing the relative new font off of the previously selected font I'll just pass a constant in for regular/400 and if that doesn't exist as a weight in the new font weights array then it'll find the closest one. Happy we could get to the bottom of this.
(also thank you for the screenshot of why i get boxes everywhere 🕵♂ )

I'm still not sure I understand the approach here.
I don't understand why we don't just always convert the entire text content to the base font-weight of the new font (most likely 400). The current result is pretty weird, IMHO with supporting non-supported font-weights for a font, that you can't see and can't use, but they'll re-appear if you switch to a new font, that has that particular weight.
What's the issue with simply always converting the entire text content to 400 (or equivalent)?
Also, when converting a multi-weight text field to a font, that doesn't support all the weights, there are still some issues with the font-weight dropdown displaying mixed while editing, even though only a single font-weight is selected:

@barklund

What's the issue with simply always converting the entire text content to 400 (or equivalent)?

I ran into problems with this because of inline weights and being unable to determine the selection at times when swapping font families. The selection is different depending on if it's the whole element, a highlight, or a cursor in the element.
I don't have enough knowledge surrounding the faux selection functionality here to be confident in an update of that nature. If you want to lend expertise I'm happy to make changes or pass this ticket on to you.

I ran into problems with this because of inline weights and being unable to determine the selection at times when swapping font families. The selection is different depending on if it's the whole element, a highlight, or a cursor in the element.

My thought here would be to just exit edit-mode if in edit-mode, then convert entire contents to new font-weight and that's it. Yes, it would mean that you would be "forced" out of edit-mode if you changed font-family while editing, but given that font-family is a pretty big change (as it changes something major for the entire text field), I feel it's warranted.
Also, if the user doesn't like it, they can undo the whole thing with a single quick key- or button-press.

exit edit-mode if in edit-mode, then convert entire contents to new font-weight

Can you point me to an example of where edit-mode is exited?

exit edit-mode if in edit-mode, then convert entire contents to new font-weight

Can you point me to an example of where edit-mode is exited?

That happens in the <EditLayer /> when esc is pressed. It actually just a call to clearEditing() from the CanvasProvider.


Update completion submodule to latest revision

All Git submodules are updated periodically.

Thanks but I update submodules periodically, and by the time I do, such pull requests are already out of date.


Sweep:  ObjectBucketClaim with maxObjects incorrectly set to an integer will break the operator & prevent all new object creation

Is this a bug report or feature request?
Bug Report

Deviation from expected behavior:
If a user creates an invalid objectbucketclaim with an integer for .spec.additionalConfig.maxObjects, this is accepted into the cluster. When the operator starts, it will log a warning repeatedly warning of an invalid bucketclaim:
E0328 13:00:32.118449   14728 reflector.go:147] pkg/mod/k8s.io/client-go@v0.28.4/tools/cache/reflector.go:229: Failed to watch *v1alpha1.ObjectBucketClaim: failed to list *v1alpha1.ObjectBucketClaim: json: cannot unmarshal number into Go struct field ObjectBucketClaimSpec.items.spec.additionalConfig of type string
and eventually timeout on start with a last error:
2024-03-28 13:02:52.055424 C | rookcmd: failed to run operator: gave up to run the operator manager: failed to run the controller-runtime manager: [failed to wait for ceph-block-pool-controller caches to sync: timed out waiting for cache to be synced for Kind *v1.CephBlockPool, failed waiting for all runnables to end within grace period of 30s: context deadline exceeded]
The rook operator then exits and the pod is restarted (crashLoopBackoff)
Expected behavior:
The objectbucketclaim should be rejected and/or the operator should be able to overlook this and start correctly, continuing to log warnings.
How to reproduce it (minimal and precise):
Create an objectbucketclaim ike this:
apiVersion: objectbucket.io/v1alpha1
kind: ObjectBucketClaim
metadata:
  name: this-breaks-cluster
spec:
  generateBucketName: sample
  storageClassName: general-s3
  additionalConfig:
    maxObjects: 1000   # should be maxObjects: "1000"

Restart the operator & observe logs and crashloopbackoff
This is tested on
$ rook version
rook: v1.13.5
go: go1.21.7

$ ceph versions
{
    "mon": {
        "ceph version 17.2.7 (b12291d110049b2f35e32e0de30d70e9a4c060d2) quincy (stable)": 3
    },
    "mgr": {
        "ceph version 17.2.7 (b12291d110049b2f35e32e0de30d70e9a4c060d2) quincy (stable)": 2
    },
    "osd": {
        "ceph version 17.2.7 (b12291d110049b2f35e32e0de30d70e9a4c060d2) quincy (stable)": 366
    },
    "mds": {
        "ceph version 17.2.7 (b12291d110049b2f35e32e0de30d70e9a4c060d2) quincy (stable)": 2
    },
    "rgw": {
        "ceph version 17.2.7 (b12291d110049b2f35e32e0de30d70e9a4c060d2) quincy (stable)": 10
    },
    "overall": {
        "ceph version 17.2.7 (b12291d110049b2f35e32e0de30d70e9a4c060d2) quincy (stable)": 383
    }
}

Environment:
OS (e.g. from /etc/os-release): Ubuntu 22.04 / Flatcar 3850
Kernel (e.g. uname -a): 6.5 / 6.6
Cloud provider or hardware configuration:
Rook version (use rook version inside of a Rook Pod): 1.13.5
Storage backend version (e.g. for ceph do ceph -v): 17.2.7
Kubernetes version (use kubectl version): 1.26.12
Kubernetes cluster type (e.g. Tectonic, GKE, OpenShift): onprem bare metal
Storage backend status (e.g. for Ceph use ceph health in the [Rook Ceph toolbox](https://rook.io/docs/rook/latest-release/Troubleshooting/ceph-toolbox/#interactive-toolbox)): ok

If you adjust the OBC to have maxObjects: "100" then on the next start of the operator the crashloop goes away and the operator runs.
The problem is, a random user of our cluster can create a broken yaml which is accepted (/not validated) by the CRD. This then kills the operator on the next restart and breaks all operator operations for all users until we discover/fix it. Worse, the log doesn't mention which OBC has this problem so our search is manual to find which namespace and OBC has this integer. And our inital search today was difficult because the offending OBC was created weeks ago, and the operator was only restarted recently.

use the x-validation for the object-bucket CRD


Make dedicated g/w node default in GCP

Makes the dedicated gateway node as the default option in GCP.

Signed-off-by: Aswin Suryanarayanan<EMAIL_ADDRESS>

/cc @vthapar @skitt @sridhargaddam @mkolesnik

@aswinsuryan this is still in draft. Are you planning to make any additional changes before its ready for review?

/cherrypick release-2.5


Allow for the selection of icon pack icons for individual keys.

Reported by aph3rson on 2 Oct 2014 06:30 UTC
I know that, in a number of different contexts in Android, different apps to use to upload/select an image are presented in a "Choose app..." menu when selecting an image for a task - e.g. a file explorer, the gallery app, etc. However, with FreeOTP, it seems as if it only shows the gallery app (and automatically opens it), without presenting any other options.
Is there a way around this? I would like to be able to use icons from my icon pack (applied through the CM Theme Engine) as pictures for my individual keys.

Closing as outdated, this was reported for Android.


fix: default mink environment variables

for cleaner OOTB integration with mink

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Can't get asyncProgressHandler to work with UI components

Hi,
First of all, great library. thanks.
I'm updating UI components in the main thread as recommended but still can't get the UIprogressView work although console print works fine.
What is wrong here?
 Just.post("https://httpbin.org/post",
                   files:["sample": .url(sampleFile, nil)],
                   asyncProgressHandler:{ p in
                       print(p.percent)
                       DispatchQueue.main.async(execute: {
                               self.progressView.setProgress(p.percent, animated: false)
                        })
          })

Hi @alperkal, thanks!
Let's see, does the progress view update if you set it on a timer? Something like this
var percent: Double = 0
let timer = Timer.scheduledTimer(withTimeInterval: 1, repeats: true) { _ in
    print(count)
    self.progressView.setProgress(percent, animated: false)
    count += 0.1
}

yes, progressView does update when triggered via a timer:
        var count = 0.0
        _ = Timer.scheduledTimer(withTimeInterval: 1, repeats: true) { _ in
            print(count)
            self.progressView.setProgress(Float(count), animated: false)

            count += 0.1
        }

BTW, I haven't extracted the code from an existing big project. That was the most basic view Controller running in a clean project.
import UIKit
import Just
class ViewController: UIViewController {

    @IBOutlet weak var progressView: UIProgressView!
    @IBOutlet weak var button: UIButton!

    @IBAction func buttonClicked(_ sender: AnyObject) {
        let sampleFile = Bundle.main.url(forResource: "sample", withExtension: "jpg")!
        Just.post("https://httpbin.org/post",
                                     files:["sample": .url(sampleFile, nil)],
                                     asyncProgressHandler:{ p in
                                        print(p.percent)
                                        DispatchQueue.main.async(execute: {
                                            self.progressView.setProgress(p.percent, animated: false)
                                        })
            })
       print("Complete!!")
    }
}

ok, I got it working finally. I don't know why it only works like this:
 Just.post("https://httpbin.org/post",
                                     files:["sample": .url(sampleFile, nil)],
                                     asyncProgressHandler:{ p in
                                        print(p.percent)
                                        DispatchQueue.main.async(execute: {
                                            self.progressView.setProgress(p.percent, animated: false)
                                        })

        }){ r in
         print(r.ok)
        }

Looks like UI gets updates only if the call is issued asychronously

When Just work synchronously, it needs to block on current thread. If it blocks on the main thread, then any other operation dispatched onto the main thread won't execute until the network is finished. The print statement works because it's not on main thread.


[loc][Query][AzureStorageExplorer] Localizability of 0; "MessageInspectingEntitiesIn"

Hi,
please help localization team to answer question from translator.
In case translator is not sure about context/meaning/localizability of string we raise a question to Core team.
Can you help, please?
Thanks!
Source:
Inspecting %1$s entities in '%2$s'
File Name:
loc\en\src\Standalone\resources\Activities.json
Query:
We need more info about the placeholders.
Does "%1$s" stand for quantity of entities?
Thanks.

Yes, the first placeholder is a number. For example, "Inspecting 2 entities in 'sometable'".

Perfect, thanks


Remove old maintainers from gitlab-plugin deploy permissions

Description
Remove old maintainers from deploy permissions for https://github.com/jenkinsci/gitlab-plugin
In addition, please remove the following from the GitHub Developers group for the plugin, as they are no longer active maintainers:
@slide
@batmat
@bassrock
@colourmeamused
@omorillo
@coder-hugo
@xaniasd
@trance1st

Submitter checklist for changing permissions

Always

[x] Add link to plugin/component Git repository in description above

As discussed with @omehegan I'll leave this for a day or two to give affected people a chance to response.

:+1: from me

:+1: from me

Removed the specified users from the team. Left are: @argelbargel, @mreichel, @christ66, @omehegan, and @dblessing


command influx not found

./veeam_backup_and_replication.sh: row 63: influx: command not found
i installed jp

Do you have influxdb2-client installed? If not please try after installing the package.

I have the same error. I have influx installed in docker. How to solve it?
thank you


Support for multi-track EDLs

The EDL format supports submasters and virtual edits and virtual source references, which could be mapped to multiple tracks or nested compositions in OTIO.
You can see details of how submasters and virtual edits work in Annex C of SMPTE 258M-2004 "For Television −− Transfer of Edit Decision Lists".

If anyone wants to revisit this, please feel free to file a new issue, or re-open this one.


AnimationTree  BlendTree: fail when reimport blender file with new animations

Godot version
4.0 beta6 mono
System information
Blender 3.3.1 on Win11
Issue description
AnimationTree. BlendTree fail when reimport blender file with new animations.
When I try to change the old animations for the new ones I cannot edit the node property. The node is not editable gray color.
Fortunately it is solved by restarting the editor.
Steps to reproduce
minimum  steps to reproduce:
Import blender file: mesh+armature+1 animation.
Create AnimationTree with BlenderTree and create node animation linked with output node.
Now edit blender file create a new animation and delete last.
Reimport blender file on godot editor.
When select AnimationTree you cant edit animation node.
Restart solve this issue 👍🏽
Minimal reproduction project
Sorry  i cant now. Reproducing the issue is quite a lot of work, ask for it if you think it is necessary.

cc @SaracenOne

Sorry for not getting around to this sooner. I've tested this and I'm not sure if I can reproduce it, though I may be misunderstanding your problem. Are you saying that the option for selecting an animation can't be selected in the animation node if you create a new animation in exported glb file and delete an old one? In which case, I haven't yet been able to reproduce that behaviour. What I can reproduce is the new animation not immedately being avaliable after reimport which requires the current scene to be closed and reopened, which a PR is in the pipeline for, but I can't seem to reproduce the specific behaviour you describe of the option to select an animation becoming an uneditable grey color under these conditions.

now I'm working with the old workflow:
(blender -> glb -> godot project).
It gives me less problems than the blender file directly in the project.
I don't know if currently (beta13) it can be reproduced.


Appfile: Extensible, User-friendly Application Config Format

fix #239
Vela supports a user-friendly docker-compose style config format called Appfile. It allows you to define an application's workloads and traits with an opinionated, simplified API interface.
Additionally, the Appfile could be extended with more configurations by adding more capabilities to the OAM system.
For more details, please look at the design proposal in this PR as well.

Merging it first, and we're going to refactor the rest part together in the following PRs.


How to use multiple execution platforms

I have a project that can be built for either Linux or Windows, without any cross-compilation so Linux and Windows are also the two execution platforms. Since there is remote execution, I wanted to be able to build for Linux from my Windows machine using RE.
To keep this short I created a sample project: https://github.com/facebook/buck2/compare/main...Overhatted:buck2-strip-prefix:multiple_target_platforms
It takes inspiration from the following issue: #487
The project just runs some Linux commands which obviously doesn't make sense to do on Windows but it's just a sample for me to understand the execution platform resolution.
When running "buck2 build --target-platforms root//platforms:linux tests:tests" on Windows, I wanted it to select the Linux execution platform automatically (since it's the only one with the "config//os/constraints:linux" constraint) but it tries to run it on the Windows platform, presumably because it is the first one declared, so I don't think I'm using the constraints correctly.
To reproduce the project above:

Initialize the repository by running: buck2 init --git, cd prelude and then git reset --hard 3b5706b425a88a8641aad8d8ffcc6cdf441b9db0.
Fill the correct remote execution information in .buckconfig
Change the "container-image" value to point to a Windows and a Linux docker image available on the RE, depending on the value of platform_name.

Running the command, "buck2 build --target-platforms root//platforms:linux tests:tests", I wanted the genrule commands to be ran on Linux but instead they are ran on Windows, demonstrated by the error message I receive: 'Failed to start process: exec: "sh": executable file not found in %PATH%'
How can I add constraints to the execution platform so that Buck2 automatically selects the correct execution platform for the selected target platform?

I wanted it to select the Linux execution platform automatically (since it's the only one with the "config//os/constraints:linux" constraint) but it tries to run it on the Windows platform, presumably because it is the first one declared

Correct.

How can I add constraints to the execution platform so that Buck2 automatically selects the correct execution platform for the selected target platform?

There is no general way to do that, but I'll explain how to solve your problem before I explain why.
You have a couple options and the best one depends on the particular situation. For this one, you have a :tests target that uses a bunch of cmd_args that assume things are running on Linux. In that case, it's appropriate to just set exec_compatible_with = ["config//os:linux"] on the target. This tells buck that that target can only be built on a Linux execution platform, and so it will not pick an execution platform that doesn't have the Linux constraint. This sort of case is somewhat common.
An equally common case is that someone has a build tool like a compiler that only supports running on a particular platform. This comes up particularly for things that don't support cross-compilation, where you end up with something like "I have to choose between three different compilers based on target platform, and all of them can only run on a specific execution platform." In that case, the preferred thing to do is to say target_compatible_with = ["config//os:windows"] on the compiler's target. Because the compiler's target should be an exec_dep of the target running the compiler (possibly via a toolchain), that target compatibility restriction will effect the execution platform of the target using the compiler.
Now getting back to why there's no way to express these restrictions on the platform definition: Note that in all of the above cases, the restrictions that we told buck about only apply to a specific target or a family of targets that all share some exec dep. This acknowledges the general principle that "which platform can this be built on" is a property that is local to a specific build step, and does not apply universally across a build, a target platform, or the repo. As a result, buck is in general happy to cross-compile only some parts of your build and not others. Coming from other build systems that might be surprising, but it is actually a good thing. It can help you make efficient use of resources by compiling things locally or using a cheaper remote execution platform (ie not mac). It also allows you to do things like have a single build which packages one component that must be built on Mac and one component that must be built on Windows.


Bug in how the variables tx.inbound_anomaly_score is used?

Describe the bug
It seems to me there is a bug in how the variables tx.inbound_anomaly_score is used.
The variable tx.inbound_anomaly_score is only set if the condition TX:ANOMALY_SCORE "@ge %{tx.inbound_anomaly_score_threshold}" is fulfilled (see Rule 949110) or in case of reputation blocking but this is not relevant here as this might be disabled.
IMO this basically breaks Rule 980120. There, the condition is TX:INBOUND_ANOMALY_SCORE "@lt %{tx.inbound_anomaly_score_threshold}".
The condition of Rule 949110 requires TX:ANOMALY_SCORE to be larger than tx.inbound_anomaly_score_threshold for TX:INBOUND_ANOMALY_SCORE to be set. Rule 980120 requires TX:INBOUND_ANOMALY_SCORE to be smaller than tx.inbound_anomaly_score_threshold. But if TX:INBOUND_ANOMALY_SCORE is smaller than tx.inbound_anomaly_score_threshold it is likely unset.
The same is not the case for tx.outbound_anomaly_score as it is calculated differently.

CRS version (e.g., v3.2.0): v3.3.0

This is all a bit hairy. Thank you for trying to clear things up.
I'm making a proposal for radical simplifiction in #1898. Would that be a solution for this problem here too?

No I do not think this would be a good solution. If I understand correctly, you would either have no log entry or an entry on every request. We have tried this and it lead to logs that became very large.
I think there is a problem with how tx.inbound_anomaly_score is used as stated above. Instead of creating a workaround for that specific problem, the problem should be solved at the root.
The way tx.outbound_anomaly_score is used for example seems much more sensible and more intuitive to me. I think this could be implemented analogously for tx.inbound_anomaly_score.
And maybe a small correction: With the fix in https://github.com/coreruleset/coreruleset/pull/1898 the Rule 980120 is not broken anymore by this here issue. It works as intended, though the actual reason it works is not intuitive and not what you would expect.

I see 3 types of requests / scores:

no alert, no score
alerts and a score below the anomaly limit
alerts and a score meeting or exceeding the anomaly limit

All this combined with inbound and outbound score and possibly execution paranoia level.
Do you see other requests?
949/959 address the 3rd category. 980 addresses the 2nd category. On nginx I see an additional need for the first category. Ideally, we find a solution that addresses all needs and can be configured in a granular way.

Actually, this relates to https://github.com/coreruleset/coreruleset/issues/1083 (which was originally https://github.com/SpiderLabs/owasp-modsecurity-crs/issues/1083) which points out that tx.anomaly_score is reused for different purposes. It appears that this in fact contributes to the unintended side-effects here; the two issues overlap.
I agree with your list of request types. And I also acknowledge the need for nginx to log scores on every request. However, I am sceptical about adding too much complexity.
How would you implement this?

I'll try to come up with a PR before 3.4. I've been pondering over this too long. We need to support NGINX in a better way than we do now.

Probably it is a good idea to talk about this in the next meeting.

Closing this in favor of #2319


Add Meetings API examples

Hi.
I added Meetings API example in __example/meetings.
I'd be glad to merge these example.

@rafecolton
Hi.
How is this pull request?

@rafecolton
Hi.
Thanks for your review comment!
Fixed it in https://github.com/zoom-lib-golang/zoom-lib-golang/pull/32/commits/54bd9af1d412ef0bdb0767ce2ff458e8c7c526bf


Add width to edit dialog

Ticket: Notion
Feature flag: n/a

Purpose
Added a width to the edit dialog box
Summary of Changes

Add local class
Add width to style of local-class

Screenshot(s)
Before:

After:

Side Effects
Nope


Missing copy image option in desktop client

I confirm (by marking "x" in the [ ] below: [x]):

[x] This is not a troubleshooting question. Troubleshooting questions go here: http://www.mattermost.org/troubleshoot/.
[x] This doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[x] I have read contributing guidelines.

Summary
Right clicking on an image only shows "save image" no option to copy.
(I also think that the "click on image" starts the download is a bug, but it is there on the web as well)
Environment

Operating System: Windows 1
Mattermost Desktop App version: 4.1.12
Mattermost Server version: 5.20.1

Steps to reproduce
send a message with an image, click the image in the sent message, right click,
Expected behavior
See copy image option.
Observed behavior
There is no copy image option on desktop app, in web browser it is.
Possible fixes
Can you show the raw browser menu instead?

can you upgrade to 4.4 or 4.4.1 (will be available today), I see the copy option on my right click menu.

Indeed 4.4 has copy image. Thanks and sorry for the nioise.
The whole client still hangs for several minutes tho when I accidentally click on the image after it pops open, it won't respond until the save dialog is closed (but before being able to close it it takes several minutes) The dalay and hang part is a windows issue due to filesystem over a slow network link. However, opening the save dialog in cases other than clicking download or save image, should bee seen as a bug.


example/trivial panic

Hi! When trying to run the trivial example. The following error was given:
thread 'grt-core-worker-9' panicked at 'called `Result::unwrap()` on an `Err` value: "read_option: expected 0 for None or 1 for Some"', src/librustc_metadata/rmeta/decoder.rs:226:9

sys_info
os: ubuntu 18.04 kernel 5.3
rocm: 3.3
rust used to compile geobacter: 1.44 stable
build_command:
cargo run --manifest-path rust-builder/Cargo.toml -- --target-dir ../geobacter-rust

You have to set RUSTFLAGS=-Z always-encode-mir -Z always-emit-metadata so that the metadata is present for the runtime.

Thanks it's working now!!!


[com.google.fonts/check/glyph_coverage] Update to follow glyphset overhaul

Similar to how the check_languages check uses the new glyphset definitions, the glyph_coverage check also needs to be updated to follow the new definitions for glyphsets that have already been transformed successfully (which is just GF_Latin_Core for now, but will grow).

thanks, @yanone


dora-19-downloadable-csv

Users should be able to download all their flashcards in a CSV format.

check this out: https://django-import-export.readthedocs.io/en/latest/index.html

tutorial here: https://simpleisbetterthancomplex.com/packages/2016/08/11/django-import-export.html


Travis tests failing sometimes

Tests fail on travis sometimes, I wasn't able to reproduce it:
  hoodie.account
  ✓ .isSignedIn returns false (307ms)
  ✓ .id persist page reload (1409ms)
  ✓ .signIn(options) with invalid credentials (402ms)
  ✓ signUp(options) (717ms)
  ✓ signIn(options) (683ms)
  ✓ .id does not change after signUp & signIn (324ms)
  ✓ .username set after signIn (283ms)
  ✓ .isSignedIn() returns true after signIn (298ms)
  ✓ .update({password: newPassword}) resolves with account properties (878ms)
    - .update({username: newUsername}) resolves with account properties
      https://github.com/hoodiehq/hoodie-account-server/issues/79
  ✓ .signOut() resolves with account properties (693ms)
  ✓ .id changes after .signOut() (277ms)
  ✓ .id gets set after signIn (380ms)
  ✓ .destroy() resolves with account properties (672ms)
  ✓ .id changes after .destroy() (297ms)
[17:41:39]:  ERROR	ServerError	unknown error: Cannot set property 'id' of undefined
RuntimeError: unknown error: Cannot set property 'id' of undefined
    at execute(<Function>) - integration.js:355:6
[17:41:39]:  ERROR	ServerError	expected 'Error' to equal 'UnauthorizedError'
Error: expected 'Error' to equal 'UnauthorizedError'
    at execute(<Function>) - integration.js:355:6
  1) .fetch with UnauthorizedError
  2) .hasInvalidSession()
  ✓ .signIn() when unauthenticated (675ms)
  15 passing (50s)
  1 pending
  2 failing
  1) hoodie.account .fetch with UnauthorizedError:
      undefined: expected 'Error' to equal 'UnauthorizedError'
      + expected - actual
      -Error
      +UnauthorizedError

  2) hoodie.account .hasInvalidSession():
     undefined: expected null to equal true

This thing really becomes annoying :/

I can reproduce this locally by running
SAUCELABS_ACCESS_KEY=1f6164de-f3d1-4af9-83d0-5358b42fbe56 SAUCELABS_USERNAME=hoodie CLIENT=saucelabs:chrome npm test

looks like b259427 fixed it

ugh, seems like it’s not yet resolved after all:
https://github.com/hoodiehq/hoodie-account/pull/33

oh I think I found the actual problem that is causing these issues. Just having an old school "how da funk could this ever work"-momenet

false alarm ¯\_(ツ)_/¯ didn’t update hoodie-account-client locally and one of the new tests failed


Refresh access token

Currently, if wrapper is running and is idle for more than 30 minutes then session token expires. We need to have a refresh mechanism in place.

this has been taken care of.


fix(proxy): lazy discovery of rest mapping to avoid throttling at start

Closes #102

:tada: This PR is included in version 1.3.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Repo contains compiler-generated class files

This repository needs a major cleanup. I found a lot of compiler-generated files (.class) files that got checked into the repo in the develop branch. For example, files in the components/bin/main/com/opensourcewithslu/components/controllers directory. In fact, it seems that the entire bin directory should not be part of the repository (bin, indicates binary, meaning generated files).
Please remove these files from the repo and update the .gitignore file to no longer allow such files into the repo.

Resolved with PR #66


Only the last 500 calls are backed up

I observed that version 1.5.11-BETA12 only backed up the last 500 call logs, while I have more on my phone. Considering that there is a setting for the amount of SMS messages being backed up, which defaults to 500: Could it be that there is the same default value for call logs, but no menu to change it?

Yes, this was changed as part of #586. For call logs, I need to check.

Actually, #586 is about the restore count, so it doesn't apply.

I have some additional information now:
New calls are backed up as expected, giving me ~520 calls in my IMAP folder. Also I was able to restore all of them (checked newest, oldest and some random samples) , so I confirm it's not the restore count but backup up count only.

@Woi the setting is called "Items per backup" and applies to all item types (added together). The default should be "All".

It was set to "All", since SMS were completely backed up.


[enhancement]: Add support for Eufy SmartDrop

Describe the solution you'd like
Currently after setting up Eufy SmartDrop device I get the following error in plugin startup:
This accessory is not compatible with HomeBridge Eufy Security plugin: SSP SmartDrop Type: 90
Is adding this device to the plugin doable. Thanks in advance.

will check but not on priority list.

there is a PR for that on @bropat lib :
https://github.com/bropat/eufy-security-client/pull/364

according to [eufy-security-client library]()
Smart Drop S300 (T8790; SmartDrop) is now supported.
I have one of these devices and I have it deployed if you need access to develop for it and/or test.


triggering switch does not wake screen up when in battery save mode..

first off, THANK YOU!
second, in the firmware that i ran from karoo when the integration was still there, i could wake up the karoo screen by triggering one of the switches on the top of my shifting hoods.
i frequently run my karoo in battery save mode so this was an important/nice/necessary (chose one) feature.
now, if i am in battery save mode and i trigger an event from the hood, the screen does not wake up.
i have confirmed that when the screen is on, the events from D-Fly channel 1 and 2 both work as expected.
it would be great if the trigger event would start by waking the screen up no matter the event.
i am running 1.395.1557.12; it is probably not (yet) supported by you; but i was forced into a new device due to crash with the old one, and was hence forced to update.
i would attempt a PR; but my java skills are basically non-existent.
thanks in advance.

I'll second this request.

Hi, thank you!
That is very nice suggestion, I will work on that when I have some spare time 🙂

Still need to do some testing. This should be available in the next Ki2 update.

any idea when the next update might be?  curious minds are....  curious!

Hi, sorry for the delay. This part is actually done but I want to finish some other things before releasing the update. Unfortunately I didn't have much spare time on the last few months for that, but thanks for the nudge. I will try to release it soon :)


Updated the reference to blueprint service

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Understanding the Insides of the SMTP Mail Protocol

Introduction paragraph (2-3 paragraphs):
Anyone who owns a computer or a mobile device is familiar with email. The mail system is based on a simple protocol that has been around for a long time. The goal of this tutorial is to show you how to create the SMTP protocol in C#.
SMTP and POP3 were the first two mail protocols. IMAP was added after that. SMTP is covered in this article. SMTP stands for Simple Mail Transfer Mechanism. It is a protocol that allows you to send email.
Key takeaways:
-Open connection
SocketClient.cs
-Authenticate
-Hello
-Authenticate
-From
-RcptTo
-Data
-Quit
References:
N/A

Good afternoon and thank you for submitting your topic suggestion. @Amoh-writer
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it.

Unfortunately, you can only propose one topic at a time. Thanks


Update README.md

Done Git

Please ensure alignment with the format of the math file from the course previews and keep the quality of the resources provided.


[wip] feat(forge): isolated execution

Motivation
aka authentic execution described in https://github.com/foundry-rs/foundry/issues/6910
The idea is to execute all test/script-level calls as separate transactions initialized with empty journaled state and triggering all pre/post transaction actions and clean-ups, such as: including calldata, base 21k gas cost, clearing transient storage, correctly processing selfdestructs, etc
Solution
All calls of depth 1 are getting caught in InspectorStack and executed as following:

Commit all changes from journal to db.
Create a separate EVMImpl with TxEnv for the current call/create context.
Transact
Collect state changeset
Merge changeset to the existing journal

When we are transacting the inner EVM, the call depth decreases from 1 to 0, and because of that, I've added logic to adjust journaled_state.depth which inspectors receive if we are in inner EVM context.
revm will also call InspectorStack hooks for the second time for the call that's being delegated (first time in main context with depth 1, second time for inner context with depth 0), but we want it to be processed only in the main context.
Open questions
I've been testing it on several codebases with a lot of various tests and it seems to work, however, there are some issues with that approach (and ci will probably show more):

Performance. Earlier we could have ran some tests without ever requiring mutable access to db, because everything was kept in the journal. Right now, we have to commit changes -> clone and it becomes more expensive. I've observed 40-50% test execution time increase in some cases.
Pranks. Currently, by using prank cheatcodes it's possible to craft test-level contract interaction where tx.origin != msg.sender. It's not possible when the call is a top-level transaction. Some of foundry and forge-std tests breake because of that
Gas reports. Right now we collect gas usage data for function calls on all depths. With this impl, test-level calls will cost more because of 21k+other additional costs, thus we should probably only use gas cost of those calls.
Commiting. Right now my impl always commits changes in-between calls and it seems to be working fine. But I am wondering if we have any logic relying on assumption that InspectorStack does not commit?

This solution seems overly complicated, why clone and merge states? Wouldn't it be simpler to maintain two separate VMs: the test runner & the actual environment. Then you map calls from the test environment as transactions in the actual and vice versa map results/receipts as return values.

Thanks for kicking off this work klkvr. Commenting so I am subscribed

So right now CI passess except for 1 test from sablier v2 which I believe has incorrect assumptions about the foundry EVM. On latest nightly that call reverts with MemoryOOG which I believe is unrealted to gas limit, and with isolated execution call executes without halts and reaches revert in contract with custom error type, causing revert reason mismatch in expectRevert
The current impl has several workarounds to make its behavior closer to how non-isolated EVM works now. I believe that it was important to create a PoC showing that we still can execute calls in isolated manner without breaking changes, however, not sure if all semantics of non-isolated mode should be kept:

Nonces. When executing CALL as a separate transaction, it increases sender nonce, which does not happen when CALL is performed in scope of another transaction. This was breaking some external tests hardcoding addresses.
tx.origin. Right now tx.origin is patched to match the tx.origin which we had before starting isolated call. This is needed for tx.origin pranks to work correctly and for some external tests with hardcoded tx.origin assertions (optimism has some)
Gas limits. Not sure how we should treat tests using .transfer and .send or simply hardcoded .call{gas: XXX}() relying on default 21K cost not being present. Right now tx gas limit is being manually increased by 21K so that we have all our tests pass, but this does not feel as a decent fix https://github.com/foundry-rs/foundry/blob/9f10bae9a40fa64d14b0bc99e9b1a8555dd13a8d/crates/evm/evm/src/inspectors/stack.rs#L440

In general, the final impl inspecor call chain looks like this:
-> root call/create hook is called (depth 0)
-> inspectors are called
    -> test-level call/create hook is called (depth 1)
        -> inspectors are called
        -> journaled state is commited to db
        -> tx env is adjusted and transaction is initiated
            -> call/create hook is called for test-level call again, this time in scope of isolated tx (depth 0 is adjusted to 1)
                -> inspectors are not called, because we already called them for depth 1 outside of isolation
                -> tx.origin and sender_nonce are patched to match values outside of isolation
                    ... deeper calls are processed as usual, with only difference being depth adjustment
                -> call_end/create_end hook is called for test-level call
                     -> inspectors are not called, we simply skip this inspector invocation as we want to process it outside of isolation
         -> After transaction is completed, we merge new isolated journaled state into previous state and return tx result (Halt/Success/Revert) from the inspector's `call/create` hook
     -> test-level call_end/create_end hook is called (depth 1)
         -> Here we notify inspectors about the end of the call, at this point we already have updated gas data received from call/create hook which executed tx in isolation

```

I will do more experiments with optimism codebase as there are some tests that are failing, and I am still not sure why.
After that, I plan to make this an opt-in, look into performance and gas metering

Performance
snekmate:
latest nightly:

this pr:

solady:
latest nightly:

this pr:

optimism (with failing tests excluded):
latest nightly:

this pr:

That way, we are looking at 20-30% execution time increase
Gas reports
I've made isolated execution an opt-in, currently it is enabled only when running tests via --gas-report. Also, we are now only filtering out traces on depth 1 when constructing gas report, to avoid deeper calls executed in a non-isolated manner affecting reports.

I've added a couple tests for tstore/tload and selfdestructs which are only passing with isolation mode.
It's possible now to enable isolation by either using --isolate flag for forge test or forge script or via setting isolate = true parameter to config.
Isolation is enabled automatically when gas report is requested for tests via --gas-report

@klkvr When running tests with --gas-report, I think I've hit a 30mm gas limit in setUp(), which I wasn't before:
    ├─ [30000000] → new <unknown>@0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f
    │   └─ ← 0 bytes of code

There are a bunch of contracts being forked and setup
Adding forge test --gas-report --block-gas-limit<PHONE_NUMBER>0000000000 didn't help.
Any ideas?

So this can be reproduced with the following test:
import "forge-std/Test.sol";

contract C is Test {}

contract GasWaster {
    function waste() public {
        for (uint256 i = 0; i < 100; i++) {
            new C();
        }
    }
}

contract GasLimitTest is Test {
    function test() public {
        vm.createSelectFork("mainnet");

        GasWaster waster = new GasWaster();
        waster.waste();
    }
}

What happening here is that we are setting block gas limit to the real gas limit of the forked chain: https://github.com/foundry-rs/foundry/blob/4a91072e326126cd852b9c43f577e98c8e13f84f/crates/evm/core/src/fork/init.rs#L68
However, without isolation we are never really validating gas usage because such checks are performed in revm::EVMImpl::preverify_transaction_innner.
With isolation, we are capping transaction gas limit at block gas limit value to not hit CallerGasLimitMoreThanBlock:
https://github.com/foundry-rs/foundry/blob/4a91072e326126cd852b9c43f577e98c8e13f84f/crates/evm/evm/src/inspectors/stack.rs#L472
IMO, revert here is a correct behavior, that one failing sablier v2 test tries to test exactly this (tx exceeding block gas limit)
However, users might need to disable those checks because it's pretty easy to go beyond 30M with various utility testing contracts.
I can see 3 approaches for this:

Expose CfgEnv::disable_block_gas_limit flag to allow disabling block gas limit checks.
Set CfgEnv::disable_block_gas_limit to true by default to fully avoid any reverts due to block gas limit violations. Allow enabling those checks for tests which rely on that via cheatcode/config.
Always override block gas limit with --block-gas-limit value, if provided.

All approaches are pretty similar, it will be easier to decide once we figure out if we want this to become a breaking change or keep backwards compatibility
@mattsse wdyt?

Thanks for the simple reproduction. imo this is already a breaking change in master since isolated-execution is on by default with --gas-report (this broke some other tests in my repo where I wanted to explicitly check gaslimit() was under a threshold)

fwiw @frontier159 foundry is not stable and breaking changes can happen—albeit we try hard not to rip the bandaid if necessary.
I think adding a flag to disable the block gas limit here might be the move @klkvr. I'm also for the opposite (disable it by default, enable with flag) if we want to "remove" the breaking change.

Allg - I enjoy living my namesake and on the Frontier. Appreciate the work you kings are doing here


Ambassador Helm Chart repo doesn't work???

Describe the bug
I'm trying to install Ambassador via Helm Chart. Not the latest version but it doesn't matter none of them are not working right now:
Error: Get https://getambassador.io/helm/ambassador-6.5.10.tgz: dial tcp <IP_ADDRESS>:443: i/o timeout
helm.go:84: [debug] Get https://getambassador.io/helm/ambassador-6.5.10.tgz: dial tcp <IP_ADDRESS>:443: i/o timeout!
To Reproduce
helm install ambassador datawire/ambassador
Expected behavior
Ambassador installs correctly :)

The hosting provider for getambassador.io is currently down. 😢   We're looking into workarounds as we speak, stand by.

Ah, here we go:
helm repo remove datawire
help repo add datawire https://www.getambassador.io

should get you going again (and it should continue working even after the outage is over).

Whoops, didn't mean to close until I get confirmation that that works for you. 🙂

OK, the main repo should be back up again -- thanks for the report!!


Update EO examples to be consistent with coming EO profile

We have a few different examples, from landsat, planet, cbers, etc that all share common fields, but right now the definitions are all over the place.
I don't think we need a full EO profile for the 0.4.0 release, but it'd be good to at least have the samples be consistent with one another and point to where we're going. If we can get to a full EO profile in the release that'd be great too.

I'm working on the EO profile today, and will at least hit the updated Landsat example today as well to go along with it.

@cholmes PR added for an initial EO extension
https://github.com/radiantearth/stac-spec/pull/80

I think this is mostly there, though would be good to flesh out the 'collection' stuff on some a bit more. To really do this we probably need #94 (or at least I do).


Disable final part of tests/feature/Object.js pending wider adoption …

…of node 4.1; see issue #1991
@arv TBR

LGTM


Add an "open Commafeed on a new tab" button to the popup

Hi,
Thanks for rewriting the code for this, I really missed the browser extension.
I see we have multiple ways of using it in the extension options, I have the default "Show CommaFeed in a popup" set (I'm in Chrome).
Can't we "combine them"? If I open the popup, I can't see a button to open Commafeed itself in a new tab.
Let's say I'm just taking a quick look, which is the popup great for, but if I want to go for it longer and read more, I'd love to have it open in a new tab (or at least resize the popup, but it isn't allowed either). Just another button here:

If you're there, maybe a button to open the extension's options too?
BTW, is it possible to label the buttons there, so if I hover them it tells me what they mean? Eg. for the first the "Refresh" text would come up...
Also is there a dark mode planned for the extension and/or the webapp itself? I see the webapp can take custom CSS, but something out of the box?
Thank you!

I see we have multiple ways of using it in the extension options, I have the default "Show CommaFeed in a popup" set (I'm in Chrome). Can't we "combine them"? If I open the popup, I can't see a button to open Commafeed itself in a new tab.
Let's say I'm just taking a quick look, which is the popup great for, but if I want to go for it longer and read more, I'd love to have it open in a new tab (or at least resize the popup, but it isn't allowed either). Just another button here:
If you're there, maybe a button to open the extension's options too?

That a great idea, I'll see what I can do.

BTW, is it possible to label the buttons there, so if I hover them it tells me what they mean? Eg. for the first the "Refresh" text would come up...

Yes I can add something like this https://mantine.dev/core/tooltip/#close-and-open-delay

Also is there a dark mode planned for the extension and/or the webapp itself? I see the webapp can take custom CSS, but something out of the box?

There should already be an entry in the profile menu :)

Done! I'll deploy on commafeed.com once the Chrome team approves the new version of the extension on the store.

The extension has been published and commafeed.com has been updated :)

Thank you very much for addressing all this, plus for this speed was amazing! 🍺
Re dark/light mode: Is there a way to get Commafeed and/or the extension to check what mode the OS/Browser is in currently, and follow that? Usually called follow system. I can raise a separate issue for that if you want.

I can raise a separate issue for that if you want.

Yes, please :)


Fix dashboard panels datasource

Current dashboard uses hardcoded name of prometheus datasource, so if it differs from that value, dashboard won't work. This fix allows all panels to use datasource name, defined by user during the import.

It's a Grafana thing. @neetkee can you explain what you would need to do in Grafana parlance what you need to do to set the variable value?

When importing the dashboard into Grafana, it will ask you to select a Prometheus type datasource from the currently configured datasources. It will replace the variable with the selected datasource name on import.

Yes, this fix allows to use variable instead of hard-coded value.


python38Packages.node-semver: 0.7.0 -> 0.8.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.node-semver is: "A port of node-semver"
meta.homepage for python38Packages.node-semver is: "https://github.com/podhmo/python-semver"
meta.changelog for python38Packages.node-semver is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.8.1 with grep in /nix/store/i77f1jjhxm0b78ckrdd1qhak1b13yrbm-python3.8-node-semver-0.8.1

found 0.8.1 in filename of file in /nix/store/i77f1jjhxm0b78ckrdd1qhak1b13yrbm-python3.8-node-semver-0.8.1

directory tree listing: https://gist.github.com/e53d16af65307c59d3c990dbb621cf89

du listing: https://gist.github.com/28ba3f524a7fdc0e495fbdf328b8a062

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python38Packages.node-semver
python39Packages.node-semver

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/i77f1jjhxm0b78ckrdd1qhak1b13yrbm-python3.8-node-semver-0.8.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.node-semver https://github.com/r-ryantm/nixpkgs/archive/88531b67a2a5f969c4803b37a66c7d6303fdc6b9.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/i77f1jjhxm0b78ckrdd1qhak1b13yrbm-python3.8-node-semver-0.8.1
ls -la /nix/store/i77f1jjhxm0b78ckrdd1qhak1b13yrbm-python3.8-node-semver-0.8.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python38Packages.node-semver
python39Packages.node-semver

Maintainer pings

Result of nixpkgs-review pr 138002 at 88531b67 run on aarch64-linux 1

2 packages built successfully:

python38Packages.node-semver
python39Packages.node-semver

1 suggestion:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/node-semver/default.nix:14:3:
   |
14 |   meta = with lib; {
   |   ^


tensorflow: dont include cudatoolkit unless cudaSupport is used

Motivation for this change
tensorflow support broke on macOS with recent commit
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

cc @abbradar

I suppose this is not applicable anymore after the recent merge.

Yeah, should be irrelevant now -- if CUDA is not enabled TensorFlow shouldn't reference cudatoolkit. I can't test by merge on Darwin though -- I wait for Hydra to do that for me but appreciate any help.

I've tried to run this:
nix-build -E 'with import <nixpkgs> { system = "x86_64-darwin"; }; python.pkgs.tensorflow.override { cudaSupport = false; }'

and it fails with:
error: Package ‘cudatoolkit-8.0.61’ in /home/abbradar/nixpkgs/pkgs/development/compilers/cudatoolkit/default.nix:125 is not supported on ‘x86_64-darwin’, refusing to evaluate.

But I don't see where does that cudatoolkit evaluation come from. When I run it on x86_64-linux, there is no mention of cudatoolkit in the resulting .drv. Any ideas?

@abbradar it evaluates and installs for me at 5c11622348ecdc5c7ed9aad2b86b8733342f10c7.

@FRidh On Darwin?

@abbradar no, on NixOS. But what is downloaded/build is the Darwin version, right? At least the hash is different.

@FRidh Ah, you mean system = "x86_64-darwin" thing. Weird then, why does it fail for me?...

Ah, it's because of https://github.com/NixOS/nixpkgs/issues/7541 and me having cudaSupport = true; in config.nix.


Fixes to Peer->send() to allow other networks

Resubmission of #73, cherry picking commits for clarity.

is there anything more necessary to merge the pr? I would like to use the lib via composer as e.g. <IP_ADDRESS>, would be great if you could merge and add a tag, otherwise I need some workarounds inside composer, which create some problems in my deployment...

Oops, sorry just forgot about it while tests were running!

It was just tagged as v<IP_ADDRESS>


Auto-center Wox on the screen.

Currently you can center the app by hand. That's ok, but if you plug external monitor, change resolutions often or use a multiple-desktop app, Wox position start to drift.
On option to always center Wox could be welcome.

Same with #227, I will add this option before official v1.2.0.

Excellent, thanks!


export MultiStats type

What kind of change does this PR introduce?
Export the MultiStats type for use in TypeScript project:
import type {MultiStats} from 'webpack'
// ...
compiler.run((err?: WebpackError, stats?: MultiStats) => {});

Did you add tests for your changes?
No, I think it's not needed.

Does this PR introduce a breaking change?
Nope.

What needs to be documented once your changes are merged?
Nothing.

Thanks


increase size of checkboxes

at edit courses. checkboxes: online course, show course in registry

@IvdL22  @PixlTracer
As requested a while ago, the size has been increased ;) Can you review this?
This applies to all check boxes, everywhere in the application, for example both add and edit course pages and the registration form.
Examples:

https://dev-dhcr.clarin-dariah.eu/users/register
https://dev-dhcr.clarin-dariah.eu/courses/add

Can you change the label to Done if satisfied?

@patrickakk Looks good, thank you!

Implemented in 2023-05.


HD44780 documentation

Info about different display types.

Great addition. Documentation PRs are rare but really valuable.


Add setting to adjust HMC API request timeout

When hosts have lost their connection to an HMC, the Managed System(s) APIs will take 2+ minutes to respond. The default response timeout for the rest-client gem is 60 seconds. Adding a user configurable setting to override the API request timeout allows inventory refresh to succeed, even when the responses are slow due to disconnected systems (or possible other reasons).
~The default value of 180 seconds should be enough to allow inventory refresh to pass in most cases, but still fail in a timely manner in the event of a "real" timeout.~
After further discussion, I set the default timeout value to 60 seconds. The intention is to leave existing behavior unchanged unless the user changes the setting introduced here.
Depends on:

https://github.com/IBM/ibm_power_hmc_sdk_ruby/pull/82
[ ] Release ibm_power_hmc v0.12.1 with ^

Hi @jaywcarman, before merging this PR, I suggest a fix for the pcm problem we had, I tested this and it worked :
Replace this : code block
by this :
    if collector.pcm_enabled[sys.uuid]
      persister.hosts_advanced_settings.build(
        :resource     => host,
        :name         => "pcm_enabled",
        :display_name => _("PCM-enabled"),
        :description  => _("Performance and Capacity Monitoring data collection enabled"),
        :value        => collector.pcm_enabled[sys.uuid].aggregation,
        :read_only    => true
      )
    end

Maybe we can add it to this PR ?
(worked on it with @vfebvre)

@CallisteH can you expand on what the "pcm problem" is?  If it is unrelated to the api timeout I suggest opening an issue for it and creating a standalone PR rather than combining with this one.

@dberg1 Do you have details about the pcm problem ?

Once this goes green I'm going to merge as is and we can discuss any other issues in separate PRs

@Fryguy on backport this will require updating the Gemfile.lock.release

Backported to oparin in commit 89a7202dfb19a9bb577488d1eb9dfd304554f86c.
commit 89a7202dfb19a9bb577488d1eb9dfd304554f86c
Author: Adam Grare<EMAIL_ADDRESS>Date:   Tue Sep 20 10:19:03 2022 -0400

    Merge pull request #76 from jaywcarman/fix_request_timeouts_when_hosts_are_not_connected

    Add setting to adjust HMC API request timeout

    (cherry picked from commit 04e1911e748a9f66d90471d593970940d0de5319)


Add Twitch keys to configuration files

We missed out on these, see https://github.com/badges/shields/pull/3683#issuecomment-530070731.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @PyvesB!

  Generated by :no_entry_sign: dangerJS against e8aa1e696d08ba93b3768745ad7bde3031c06d60

Looking much better now:


Fix scroll response

as titled.

@delvedor , the docs state that the response body of scroll is identical to search link. The tests also run through, hence I removed the failed_shards prop.


docs: Update Support SRML to link to StorageDoubleMap in Rustdocs

You omitted the backticks.

I've pushed a commit that adds the backticks for consistency and fixes a typo

it seems better to me to put trait not in the link as we do in decl_module

do you agree Basti? should i make the change?

it seems better to me to put trait not in the link as we do in decl_module

do you agree @bkchr ? should i make this further change?

@bkchr @thiolliere i've pushed a commit with this change


KerbalVR does not start when clicking "Enable VR"

I ran this on a minimally reproducible setup.

KSP v1.4.5
KerbalVR 3.2.1
SteamVR beta 1.1.4
Windows 10 1809

(No mods beside KerbalVR.)
KSP.log
Of note is the following block, right at the beginning:
[LOG 19:05:52.871] Load(Assembly): KerbalVR/KerbalVR
[LOG 19:05:52.872] AssemblyLoader: Loading assembly at C:\Users\Forest\Games\KSP\VR-1.4.5\GameData\KerbalVR\KerbalVR.dll
[LOG 19:05:52.895] Load(Assembly): KerbalVR/openvr/win32/openvr_api
[LOG 19:05:52.895] AssemblyLoader: Loading assembly at C:\Users\Forest\Games\KSP\VR-1.4.5\GameData\KerbalVR\openvr\win32\openvr_api.dll
[ERR 19:05:52.897] Failed to load assembly C:\Users\Forest\Games\KSP\VR-1.4.5\GameData\KerbalVR\openvr\win32\openvr_api.dll:
System.BadImageFormatException: Format of the executable (.exe) or library (.dll) is invalid.
  at Mono.Cecil.PE.ImageReader.ReadOptionalHeaders (System.UInt16& subsystem, System.UInt16& dll_characteristics) [0x00000] in <filename unknown>:0
  at Mono.Cecil.PE.ImageReader.ReadImage () [0x00000] in <filename unknown>:0
  at Mono.Cecil.PE.ImageReader.ReadImageFrom (System.IO.Stream stream) [0x00000] in <filename unknown>:0
  at Mono.Cecil.ModuleDefinition.ReadModule (System.IO.Stream stream, Mono.Cecil.ReaderParameters parameters) [0x00000] in <filename unknown>:0
  at Mono.Cecil.ModuleDefinition.ReadModule (System.String fileName, Mono.Cecil.ReaderParameters parameters) [0x00000] in <filename unknown>:0
  at Mono.Cecil.ModuleDefinition.ReadModule (System.String fileName) [0x00000] in <filename unknown>:0
  at AssemblyLoader.ScanForBadTypeRefs (System.String file) [0x00000] in <filename unknown>:0
  at AssemblyLoader.LoadExternalAssembly (System.String file) [0x00000] in <filename unknown>:0

[LOG 19:05:52.898] Load(Assembly): KerbalVR/openvr/win64/openvr_api
[LOG 19:05:52.898] AssemblyLoader: Loading assembly at C:\Users\Forest\Games\KSP\VR-1.4.5\GameData\KerbalVR\openvr\win64\openvr_api.dll
[ERR 19:05:52.899] Failed to load assembly C:\Users\Forest\Games\KSP\VR-1.4.5\GameData\KerbalVR\openvr\win64\openvr_api.dll:
System.BadImageFormatException: Format of the executable (.exe) or library (.dll) is invalid.
  at Mono.Cecil.PE.ImageReader.ReadOptionalHeaders (System.UInt16& subsystem, System.UInt16& dll_characteristics) [0x00000] in <filename unknown>:0
  at Mono.Cecil.PE.ImageReader.ReadImage () [0x00000] in <filename unknown>:0
  at Mono.Cecil.PE.ImageReader.ReadImageFrom (System.IO.Stream stream) [0x00000] in <filename unknown>:0
  at Mono.Cecil.ModuleDefinition.ReadModule (System.IO.Stream stream, Mono.Cecil.ReaderParameters parameters) [0x00000] in <filename unknown>:0
  at Mono.Cecil.ModuleDefinition.ReadModule (System.String fileName, Mono.Cecil.ReaderParameters parameters) [0x00000] in <filename unknown>:0
  at Mono.Cecil.ModuleDefinition.ReadModule (System.String fileName) [0x00000] in <filename unknown>:0
  at AssemblyLoader.ScanForBadTypeRefs (System.String file) [0x00000] in <filename unknown>:0
  at AssemblyLoader.LoadExternalAssembly (System.String file) [0x00000] in <filename unknown>:0

I don't know the details of Unity's plugin architecture (or that of KerbalVR or KSP for that matter), but a cursory search brought up a similar looking issue.

The "failed to load assembly" errors are a bit misleading, this is "normal" behavior, Unity tries to load the openvr dll but fails because it's not supposed to be trying to load it. But that's fine.
I saw this line in your log:
[ERR 19:05:53.006] [KerbalVR] HMD not found on this system.
for some reason the plugin is not finding your VR set. I'm not sure how else to diagnose this... What VR system are you using? I assume it works fine for other games? SteamVR is running when you launch KSP? (actually if it's not running beforehand, it's supposed to automatically launch SteamVR)

OK, so I've done some digging and found that the SteamVR runtime isn't discovered for some reason:
[ERR 19:53:03.887] [KerbalVR] SteamVR runtime not found on this system.

Which would explain the early shutdown. I'm looking into it now and will update this issue as soon as I find out more.

Oh hey, I think I solved it. It has to do with running as administrator (which I was doing for an unrelated issue.)
When you run as admin, it looks for the SteamVR vrpath config file in the administrator's AppData folder. All that vrpath config file does is point to C:\Program Files (x86)\Steam\steamapps\common\SteamVR, but if that file is not found, I'd guess the OpenVR API just gives up.
So the solution would be to either:

Install SteamVR as an administrator and run it once, just to create the config file; or
Don't run as an administrator.

I'll close the issue, as it's been resolved.

thanks for looking into this!


[BUG] Confirm and cancel buttons should be on bottom

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
[BUG] Confirm and cancel buttons should be on bottom.

Screenshots [optional]
No response
Steps To Reproduce
1- Go to https://www.stacksats.how/podcast and click on Alby extension button
Expected behavior
Confirm and cancel buttons on bottom
Alby information
Alby: 3.0.0
Device information
No response
Additional context
No response
Are you working on this?
No

Can be fixed in here:
https://github.com/getAlby/lightning-browser-extension/blob/master/src/app/screens/LNURLPay/index.tsx

heyy! I would love to solve this issue

@tiwariParth Are u still working on this?
If not I am ready to work on this.
@rolznz @reneaaron

@tiwariParth Are u still working on this?
If not I am ready to work on this.
@rolznz @reneaaron
I have fixed it locally.

Ohh Sure you can work on it


Not Logged In Error

This appears to be more of an error with Chromium than the downloader. Curiously, I've had a similar issue with Chromium itself of a Raspberry PI.
When I try to download content from any Patreon the app seems to hang for a bit then I get a notification that I am not logged in and it errors out. Which is understandable.
Since Chromium didn't open a window to let me log in I went to the .local-chromium folder and ran it myself. I went to Patreon but as soon as I logged in the browser crashed. I think the profile is corrupted as that was the closest I could ever determine on Raspberry PI.
I deleted the .local-chromium folder and now it can't properly download a new copy. I have a zip file but its corrupted.

I fixed the issue with Chromium not downloading properly. I downloaded a copy myself and dropped the zip file into the proper folder within the PatreonDownloader folder and everything is working now.
Not sure if that was the "right" way to do it but it worked so I'm not omplaining.

Can someone reset the working version of the program with normal chromium, otherwise I tried everything and nothing helped.


Failed to resolve: com.estimote:scanning-sdk:0.1.0

Added
  compile 'com.estimote:sdk:1.3.0'

fails as dependency is not found.

compile 'com.estimote:sdk:1.2.0'

seems to work

Hi @Zhuinden
Thank you for reporting this. Confirmed - it's our bug.  By mistake one of our new SDK components (scanning-sdk) was released internally only, so we (Estimoters) were able to use it without any issues however it wan not accessible publicly - our bad :( .
I've just requested to add scanning-sdk component to jCenter repo so the issue should be resolved in several hours (as soon as the Bintray process repos population)
We're in the middle of huge architectural refactoring of our SDK, which - we hope - will bring our SDKs quality and overall experience on whole new level. Stay tuned - new releases fully build up on new architecture will be available in upcoming weeks.
In the mean time there might be some glitches in the build process - we're apologise for that.
Regards
Wojtek

Hi @Zhuinden
Check com.estimote:sdk:1.3.0 now - it should be fixed now.
Regards
Wojtek

Yup, it works, thanks!


Track charge with properties function name in docs not correct

Hey,
juts a tiny typo in the docs I guess. To track a charge with properties I needed to call trackChargeWithProperties instead of just trackCharge.

thanks, updated!


[docs] add the config file in the wiki

Today we don't have docs that cover what all the values in the config files are for - we should author that page.

closing this out, we have detailed info in https://github.com/CatalystCode/3dtoolkit/wiki/JSON-Config-Files now


Preview/2.0.0

:white_check_mark: Build TheIdServer 2.0.2-preview1-0004 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/5bb077311a by @aguacongas)


new translations

GRIB2 precipitation_amount
and
implied height for stash m01s03i227
replaces #1924
derived from
https://github.com/metarelate/metOcean/issues/61
https://github.com/metarelate/metOcean/issues/70

Perhaps it would be helpful to embed the corresponding metarelate/metOcean commit hash in lib/iris/fileformats/grib/_grib_cf_map.py?

Perhaps it would be helpful to embed the corresponding metarelate/metOcean commit hash in lib/iris/fileformats/grib/_grib_cf_map.py?

I am concerned that this level of traceability would be complicated to implement, given the current functionality of the gen_translations tool whilst the searchability of metarelate enables fine grained analysis of translations and their history, e.g.
http://www.metarelate.net/metOcean/list_mappings/False/?ref=[{"predicate"%3A+""%2C+"rdfobject"%3A+"precipitation_amount"}]
(search on precipitation_amount)
I'm don't think there is enough value in having the github commits embedded and referenced within these map files in Iris to be worth the effort to implement such referencing.

I'm don't think there is enough value in having the github commits embedded and referenced

To be clear, I'm not talking about including a list of commits that correspond with a change in Iris. I'm simply suggesting that the mappings in the file are created from a particular state of the metOcean database, and that state can be succinctly expressed with a single commit hash.
For example, the header of lib/iris/fileformats/grib/_grib_cf_map.py would look like:
# DO NOT EDIT: AUTO-GENERATED
"""
Provides GRIB/CF phenomenon translations.

Generated from metarelate/metOcean @ cf419fba84a70fba5f394f1481cfcdbba28877ff

"""

from __future__ import (absolute_import, division, print_function)

ah, i see; I was overcomplicating my interpretation
I think this is plausible, we'd need a small tweak to the metarelate API to get the commit sha.  I will try to get to that and get it running properly soon.
Would you be content to take this PR as is and aim for a follow up providing the commit sha?
cheers
mark

Would you be content to take this PR as is and aim for a follow up providing the commit sha?

Absolutely. :+1:

https://github.com/metarelate/metarelate/issues/36

thank you


Allow to set retry_count and wait_time outside the function

@maximilien This PR is separated from PR 151, it's a dependency to addressing long hostname issue. I will submit another PR after this PR is merged. I added the unit test, please review. Thanks.

@maximilien The travis problem disappeared after moving to go 1.6.3. Please review this PR. Thanks.

Looking better. However, I am wondering if the RETRY_COUNT and WAIT_TIME values could be set once for all parts of softlayer_go and reset when the default or value in environment variable is not not good enough. If not and you reset these values then that prevents users from being able to try different values since right now you are hardcoding them.

@maximilien I don't think it's proper to externalize these 2 values to be set by environment variables, since these 2 values are common ones which would be used by multiple functions, and the appropriate values for these functions would be different. In addition, I think the user may confuse what these values are used for, especially they would be used for different functions.

@mattcui then make specific versions of these for this function. Use the same prefix and use a suffix specific for this. I am not for hard coding values...

OK, merged 151, please let me know when to review this one.

@maximilien Got some problem with trying to update softlayer-go into bosh-softayer-cpi Godpes last night, will you help do that or let me try to do that? Thanks.

@mattcui Godeps updated. Let me know when this is ready to review again.

@maximilien Yes, it's ready for review. Thanks.

OK cool. Thanks 👍

@maximilien After this PR is merged, I will submit another PR for printing warning message when the deployment fails as well as the length of hostname is greater than 64 characters. Thanks.

OK merging. Cheers 👍


Primitive operations proof refactoring

Refactor proof code for primitives to make it easier to verify the remaining operations

could you also fix the formatting (indentation) in the primitives file?


[KYUUBI #1269] Online documentation section in the readme is outdated

Why are the changes needed?

Closes https://github.com/apache/incubator-kyuubi/issues/1269
How was this patch tested?
docs only

Codecov Report

Merging #1270 (4b15c2c) into master (f0f065b) will decrease coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head 4b15c2c differs from pull request most recent head 7a597e6. Consider uploading reports for the commit 7a597e6 to get more accurate results

@@             Coverage Diff              @@
##             master    #1270      +/-   ##
============================================
- Coverage     78.30%   78.28%   -0.02%
  Complexity      110      110
============================================
  Files           176      176
  Lines          6886     6886
  Branches        843      843
============================================
- Hits           5392     5391       -1
  Misses         1037     1037
- Partials        457      458       +1

Impacted Files
Coverage Δ

...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala
89.89% <0.00%> (-1.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f065b...7a597e6. Read the comment docs.

aslo cc @aajisaka @yaooqinn @turboFei if you have time to take a look


Warning message from telemetry

Accessing the database for just about anything using pgo gives a warning -
Using execute/3 with a single event value is deprecated. Use a measurement map instead.
On checking around a bit, this error message seems to be from telemetry. Some other apps seem to have had the same issue, e.g. https://github.com/nats-io/nats.ex/issues/85
But I am uncertain if their solution strategy of simply hiding telemetry warning is the right one..

Ah ok, I'll get that fixed, just need to update the use of execute.

It should be fixed now in master and hex package 0.8.0.

Just checked it again, it works! Thank you 👍


registration_form.html

html code to create a registration form.

please accept my pull request.

https://github.com/DeepanshuGoel1122/CodeEasy
like this repository please
and https://github.com/DeepanshuGoel1122  follow him, let's build connection strong


Linear Evaluation on VOC07

Hi,
I have installed VISSL using conda pre-built binaries and have successfully trained SimClr on ImageNet following https://vissl.readthedocs.io/en/v0.1.5/getting_started.html. Next, I evaluated the saved model checkpoint on ImageNet Linear Evaluation following https://vissl.readthedocs.io/en/v0.1.5/evaluations/linear_benchmark.html#benchmark-imagenet-1k.
 However, I am not sure how to register the voc07 dataset in my python interpreter, and what is the expected data format. For Imagenet, I followed the following steps:
>>> json_data = {
        "imagenet1k_folder": {
            "train": ["<img_path>", "<lbl_path>"],
            "val": ["<img_path>", "<lbl_path>"]
        }
    }
>>> from vissl.utils.io import save_file
>>> save_file(json_data, "/tmp/configs/config/dataset_catalog.json")
>>> from vissl.data.dataset_catalog import VisslDatasetCatalog
>>> print(VisslDatasetCatalog.list())
['imagenet1k_folder']
>>> print(VisslDatasetCatalog.get("imagenet1k_folder"))
{'train': ['<img_path>', '<lbl_path>'], 'val': ['<img_path>', '<lbl_path>']}

What will be the commands for registering voc07?

I found it - https://github.com/facebookresearch/vissl/blob/main/configs/config/dataset_catalog.json
Thanks.


Consider switching from python "toml" package to "tomli"

The toml package appears to be abandoned by its maintainer, and getting co-maintainership apparently is a very slow process, despite the package seeing an incredible amount of use.
See for example:
https://github.com/uiri/toml/issues/361
tomli should be a fork that works, from what I read, black switched to this one already:
https://github.com/hukkin/tomli
Edit: Ah and I see tomli became a part of the standard library  of Python from 3.11 onwards.
https://github.com/hukkin/tomli#building-a-tomlitomllib-compatibility-layer

Thanks Joeri, like you I've heard that toml handling will be part of the stdlib.
As soon as 3.11 is out we can drop the toml dependency then :)

Yes, alternatively you could consider switching already, and use tomli's suggested compatibility layer:
https://github.com/hukkin/tomli#building-a-tomlitomllib-compatibility-layer

Yes, alternatively you could consider switching already, and use tomli's suggested compatibility layer:

Fine by me.
Would you mind opening an issue at Jira with same component, version and label as here?

Done :-) https://issuetracker.deltares.nl/browse/IMOD6-839

Thanks :)


Fixing moderation endpoint per #83.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Problem/Feature
Fixes #83.
Description of Changes:

Fixes new events to use the correct column
Includes shim to support older, mislabeled events

Checklist

[x] My code follows the Contribution Guide
[x] I have self-reviewed the changes being requested
[x] I have made comments on pieces of code that may be difficult to understand for other editors
[x] I have updated the documentation (if applicable)

this did not add a shim to fix ban events
https://github.com/twitchdev/twitch-cli/pull/85/files#diff-7229736c3ae0951e4549402e58f96d4756e06636c8f894754be00163ed919d81L221-L256

Ah! Great catch, will get it added.


Adding Frames blurr the existing frames

Hi, i have a problem with blurred Frames.
When i try to add small scenes (1-5 frames) to my project, i have an issue that the existing frames become blurred. It get worse from picture to picture.
The problem is easy to reproduce: Simply add images frame by frame (snap mode or normal) then look at the previous ones.
I found out that the issue did not exist in version 2.12.1

Sorry for my bad english :)

Can you try exporting your project to APNG format to see if it's any different?

@serJOOga Would you mind to share the project and the frames that you are trying to insert? If so, you can email me at<EMAIL_ADDRESS>

Closing as inactive.
Try using the latest version, v2.26.1 or send to the images that you were trying to import.
It looks like it was an issue with images having different DPI, an issue which was fixed with the current available version.


Milestone 5: Events

Completed:

[x] Gitflow
[x] ESLint
[x] Stylelint
[x] App component
[x] ButtonPanel
[x] Button

:wave: @Forison. Thanks for the review. :+1:
I have applied all required changes; the calculator is now fully functional.
Thanks for the optional suggestion to use an arrow function for handleClick in App.js. However, I have kept with my initial implementation as the React Docs on Handling Events recommends binding in the constructor, or using class fields, to avoid performance issues with using arrow functions.
I remain to be convinced :smiley:
Happy coding!

Thanks, @bellom. 👍


IRGen: Fix capture of indirect values in [onstack] closures

A [onstack] closure does not take ownership of its arguments. It is
therefore not correct to use an initWithTake copy of indirect arguments.
Instead we just capture the address of the indirect argument.
rdar://61261982

@swift-ci Please test os x

@swift-ci Please test source compatibility


[Bug Report][Android] library "libavcodec.so" not found

Device:
Samsung A7-2017
Android 8.0
dependencies:
  media_kit: ^1.1.8
  media_kit_video: ^1.2.1
  media_kit_native_event_loop: ^1.0.8
  media_kit_libs_android_video: ^1.3.5
  media_kit_libs_ios_video: ^1.1.4

WidgetsFlutterBinding.ensureInitialized();
MediaKit.ensureInitialized(); // error

error is:
ArgumentError (Invalid argument(s): Failed to load dynamic library 'libavcodec.so': dlopen failed: library "libavcodec.so" not found)
i tried adding
packagingOptions {
                pickFirst 'lib/arm64-v8a/libavcodec.so'
                pickFirst 'lib/arm64-v8a/libavformat.so'
                pickFirst 'lib/arm64-v8a/libavutil.so'
                pickFirst 'lib/arm64-v8a/libswscale.so'
                pickFirst 'lib/x86/libavcodec.so'
                pickFirst 'lib/x86/libavformat.so'
                pickFirst 'lib/x86/libavutil.so'
                pickFirst 'lib/x86/libswscale.so'
                pickFirst 'lib/x86_64/libavcodec.so'
                pickFirst 'lib/x86_64/libavformat.so'
                pickFirst 'lib/x86_64/libavutil.so'
                pickFirst 'lib/x86_64/libswscale.so'
            }

into build.gradle.
and i tried
MediaKit.ensureInitialized(libmpv: '/app/lib/libmpv.so.2');

but neither of them solved the issue.

I'm very-very confused, we statically link libav*. Why is it looking for separate libavcodec.so?

I didn't understand either, I don't know. If there's something I need to do, just let me know. I'll do what you ask and get back to you.

is it solved?

I can't reproduce this issue on any of my Android devices or emulators. Not sure how should I proceed.

@Priyanshu-Bej
Can you share your device details e.g. model, architecture & version?

As answered by @zezo357 on Discord:
The implementation is correct & we handling the fallback etc. by catching the exception. There's nothing better that can be done. Modify your Visual Studio Code settings:


KREST-1346: Add option to apply rate-limit globally across all connections.

Also removes dos.filter.track.session option, since Kafka REST does not use sessions, so that option has no effect.

@rigelbm f1921b2 belongs to #261, and should not be in this PR, right?

@rigelbm f1921b2 belongs to #261, and should not be in this PR, right?

That's just GitHub inability to set diff-bases. I will merge #261 and update this PR soon.

Once this goes in, we'll need some cc-spec-kafka changes, right?
That's correct.


Translation status shows whether node is published or not, not whether translation is published or not

Translation status indicates that all translations of "I am Woman, Hear Me Score" are published, however when I go to the translate tab of this campaign, I can see that the US English version is not translated.
related to: #5371

we might have to do some tricky view_alter to this to pull in Entity translation: Translation status for each one


Create Türkçe.json

Not fully done yet but ¯_(ツ)_/¯

hey lasse, should we use english names with the translation language in ()?

idk you guys but i think language names should be the same language as the translation. but doesn't really matter ¯_(ツ)_/¯


[New feature] add dynamic voxelizer implementation

Add dynamic voxelizer implementation
Add a training config with the dynamic voxelizer for centerpoint

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.luoqianhui seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

This PR conflicts with the latest code, please fix it


Question: Which one of the pretrained models should I use for 'in the wild' images

Which one of the pretrained models should I use - which model is the 'best' one for 'in the wild' images ?
Are the HRNet models better than the respective ResNet models ?
Should I use the 'V1' variant or the 'V1_ft_3DPW' variant ?
For me, it seems that 'V1_ft_3DPW' is slightly better.

It is totally up to you. I think that HRNet models are better than ResNet models.

Thanks for the information. And thanks for your implementation, the algorithm works great !


make :route_patterns a dependency of :site app

Summary of changes
Asana Ticket: Look into schedule 500 error on dev
The application build is crashing because :route_patterns was never added as a dependency to the :site application after the modules were referenced.
A similar issue happened recently with the :services application.

Assigned to: @meagonqz

verified on dev-green


feat: Reverse save games order - issue 211

Fixes https://github.com/godot-escoria/escoria-issues/issues/211

Funny that I didn't do that in the first time. Thanks!


Misc project maintenance updates

Read per commit

This change is

Coverage increased (+0.005%) to 44.693% when pulling 0f497a097e6fcdef3f5dcd8d5b05dc48b4be4059 on pr/master-cilium-actions-update into bcdbd0c352856489313855720a406903c59148c2 on master.


Add Vertical Align for text in LineEdit

Add Vertical Align for text in LineEdit

You put the file in the wrong place, it should be in godot/scene/gui/

Not sure what github did but should be fixed now.

There seem to be 5 commits on this PR now. Could you please squish them into 1?

AFAIK I can't unless I close this PR and open another one. Should I do it?

Well, If you can't manage to squash the commits, yes, go ahead.


RHIDP-3447: Audit log doc enhancements

Version(s):
1.2.2
Issue:
https://issues.redhat.com/browse/RHIDP-3447
Link to docs preview:
https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-407/getting-started-rhdh/#assembly-audit-log
Reviews:

[x] SME: @Zaperex @schultzp2020 @kim-tsao
[x] QE: @gustavolira
[x] Docs: @gwynnemonahan

/cherrypick 1.2.x

/cherrypick 1.2.x