Make fails while trying to re-make glossary

I edited body.txt, then I hit make. Error message ensued:
pjm@PPA-PC92478 > make
make: Circular aglossary.tex <- aglossary.tex dependency dropped.
rm -f meta.tex
touch meta.tex
echo '% GENERATED FILE -- edit this in the Makefile' >>meta.tex
/bin/echo '\newcommand{\lsstDocType}{RTN}' >>meta.tex
/bin/echo '\newcommand{\lsstDocNum}{005}' >>meta.tex
/bin/echo '\newcommand{\vcsRevision}{5b0e1db-dirty}' >>meta.tex
/bin/echo '\newcommand{\vcsDate}{2020-08-20}' >>meta.tex
generateAcronyms.py  -t "OPS" -g RTN-005.tex aglossary.tex body.tex meta.tex
/bin/sh: generateAcronyms.py: command not found
make: *** [aglossary.tex] Error 127

From the README, I tried re-making the acronyms - that failed too:
pjm@PPA-PC92478 > make acronyms.txt
make: *** No rule to make target `acronyms.txt'.  Stop.

I'll commit and push without making the PDF. Let's hope my blind latex editing skills are good!

had not seen this - its fixed now :)


Added news

Added news to the home page
Redid the home page
Added a smooth transition between light and dark theme
Made the character limit more visible
The server now checks message length

LGTM :slightly_smiling_face:


Taunts

Can we please have them back for debugging at least? :)

:+1:

working on it see #30

This has been merged into master, will be in the docker image some time today. We haven't constrained the text yet, so I need to get that done before it gets into the docker image.


Implement a sUDT sender with pw-core

Noob me sent BNB from ForceBrdige to a PW address, I later realized that although the funds are safe however they are stuck due to the PW not supporting sUDT. My question is, will it be possible for someone to help implement a sUDT sender with pw-core, which has a built-in support for transferring sUDT,

 as pw-lock is public and not bound to portal wallet?

This tool will help: https://github.com/homura/pw-up


Item: Alchemical Coal

Alchemical Coal is a more efficient form of coal (equal in burn time to 8 pieces of coal)

Textures merged in https://github.com/pahimar/Equivalent-Exchange/pull/54


Update devenv-adding-filter-tokens.md

Correct reference to parameter for matching token.

Learn Build status updates of commit 30c7fec:
:bulb: Validation status: suggestions

File
Status
Preview URL
Details

dev-itpro/developer/devenv-adding-filter-tokens.md
:bulb:Suggestion

Details

dev-itpro/developer/devenv-adding-filter-tokens.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Thanks for the contribution!


Test documentation code snippets during CI

Much like what's done with mdbook test.
I think the most important part is the web framework integration page because that's an external integration point.
One complication is that the documentation build doesn't include the web framework support. And for good reason – the build with --all-features takes twice as long. So this test step will have to be stuck on the end of the "All features" build, which I guess is okay but kind of strange.

My current approach is to have a dummy crate that imports the book's contents using #[doc = include_str!("...")]. Then running cargo test on that crate will test all the code snippets in the book.
An alternative is to invoke rustdoc directly, with something like:
rustdoc --edition=2018 --test -L maud/target/debug docs/content/*.md

mdBook uses this approach. But this bypasses Cargo, which leads to two disadvantages:

I have to arrange for all the dependencies to be built before running the test.
The extern prelude is not populated automatically. This means I have to maintain the --extern flags by hand, or litter the examples with extern crate maud;.

My current approach is to have a dummy crate that imports the book's contents using #[doc = include_str!("...")]. Then running cargo test on that crate will test all the code snippets in the book.
An alternative is to invoke rustdoc directly, with something like:
rustdoc --edition=2018 --test -L maud/target/debug docs/content/*.md

mdBook uses this approach. But this bypasses Cargo, which leads to two disadvantages:

I have to arrange for all the dependencies to be built before running the test.
The extern prelude is not populated automatically. This means I have to maintain the --extern flags by hand, or litter the examples with extern crate maud;.

Another alternative is to use rust-skeptic, but I think our hand-rolled approach is simple enough that it's not worth bringing in another dependency to do it.

Another alternative is to use rust-skeptic, but I think our hand-rolled approach is simple enough that it's not worth bringing in another dependency to do it.


pull request for e2e test at 01/17/2017 13:45:13

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Investigate Impact of supporting WeDo 2.0

Lesson Learnt from #48
Note: Note to everyone: I do not have the hardware and have in the foreseeable future no interest in purchasing them. If you want support for this hardware in this library, please contribute. I will guide you through the process and assist with everything needed.

Managed to get this working with my Bluegiga dongle and the new 88012 hubs that came with the Liebherr Excavator, but it was not simple to make work as the Bluegiga acts as a singleton on a serial port and this meant some of the async connection tasks broke... I got around it by making a separate repository and translating to/from the sharpbrick objects, but this will need cleaning up. The TechnicMediumHub ports work for the internals (LED light, etc), but the motors appear to be on different ports, so am probing the HubAttachedIO to try and work out where they are... Anyway, https://github.com/Sodoshi/SharpBrick.PoweredUp.Bluegiga is where I am at...

@Sodoshi can you open a separate Issue for this. Very interested in how this further evolves. I was confused first but then I realized you talk about Control+ and not WeDo 2.0.
The motors however, should work. A bit concerned about that.
I also took a mental note that the Bluetooth Abstraction is now an external contract. At the current early state, I cannot promise that I - or you 😀 - will not break it.

I've just started using the library with my Mercedes Zetros Truck .
I think it has this motor (it's the bottom one):

It is reported on the hub as device type 'Motor (id 1)'. Which doesn't seem supported.
I would love to help adding support for this motor, I am an experienced c# programmer, but I have no clue what needs to be done here :)

@mennolodder
So this is the "LEGO 6290182 - 21980 - Electric, Motor WeDo 2.0 Medium". But it seems to operate on a Technic Medium Hub. Which is good since the communication partner of this library is the hub not the motor.
The first thing you should do, is use the command line to dump the motor self-description. Let us see what that provides.
https://github.com/sharpbrick/powered-up/blob/master/docs/development/adding-new-device.md

I'm afraid for my system the commandline tool hangs on receiving messages (also if I do devices.list):
I'm sure it is on port 2, the others motors I can access.
>poweredup device dump-static-port -p 2
Scan Started. Please select the Hub (using a number keys or 'q' to terminate):
1: TechnicMediumHub (with address<PHONE_NUMBER>45109)
1
Selected TechnicMediumHub with key 1
Discover Port 2. Receiving Messages ...
........

That is ugly. I do not have a device and my knowledge is a bit rusty to read raw traces. Maybe you can try first running the it on the raw Lego Wireless Protocol (that is the Bluetooth Library) and write power on/off into the device.
The technic motors have three levels. Try using the raw messages against the WeDo 2.0 motor. That might work. The README has a tutorial.

BasicMotor which is purely power based using StartPowerAsync with PortOutputCommandStartPower2Message
TachoMotor which extend with speed using StartSpeedAsync with PortOutputCommandStartSpeedMessage
AbsoluteMotor which extend with position.

Yeah, the poweredup device list fails always, unless I unplug all motors (so just the hub with nothing attached).
I will give that a try, might take a while to get back to you though. Thx for all the quick responses.

I just run the tool on TechnicXLargeMotor on the TechnicMediumHub on port A. Still works here. No idea if they screwed up the firmware maybe meanwhile.
I have checked the code with the JavaScript library. They support the WeDo 2.0 motor. However, that library is not as "sophisticated" as this library (I tried to implement the protocol not just make the devices work). That is the reason that library works. Which is good news, because it can work in theory.
I also checked there the code (either 1 or 2) and both only support power messages with this function. In this library the equivalent function is here. So I am quite confident that this message will work.

I tried your suggestions, I think :)
With respect to the raw messages, do you mean: 'Connect to Hub and Send a Message and retrieving answers (directly on protocol layer)'. This seems to be a bit outdated, as it doesn't compile (and the examples dir doesn't have a compiling example that does the same).
For instance: BluetoothKernel does not have a property  BluetoothAddress
SendMessageAsync requires a LegoWirelessMessage
I adapted it like this, but it fails to connect:
     var kernel = scope.ServiceProvider.GetService<BluetoothKernel>(); // .BluetoothAddress = bluetoothAddress;
     kernel.BluetoothDeviceInfo = new PoweredUpBluetoothDeviceInfoWithMacAddress()
     {
         MacAddressAsUInt64 = adressAsLong
     };

     var protocol = scope.ServiceProvider.GetService<ILegoWirelessProtocol>();

     await protocol.ConnectAsync(); // nullpointer thrown here

The error is:
System.ArgumentNullException
  HResult=0x80004003
  Message=Value cannot be null. Arg_ParamName_Name
  Source=SharpBrick.PoweredUp.WinRT
  StackTrace:
   at SharpBrick.PoweredUp.WinRT.WinRTPoweredUpBluetoothDevice..ctor(BluetoothLEDevice device)
   at SharpBrick.PoweredUp.WinRT.WinRTPoweredUpBluetoothAdapter.<GetDeviceAsync>d__1.MoveNext()
   at SharpBrick.PoweredUp.Bluetooth.BluetoothKernel.<ConnectAsync>d__12.MoveNext()
   at SharpBrick.PoweredUp.Protocol.LegoWirelessProtocol.<ConnectAsync>d__15.MoveNext()
   at LegoCar.Program.<RunRawSingleMotor>d__4.MoveNext() in C:\Repos\lego_automated_car\LegoCar\LegoCar\Program.cs:line 78
   at LegoCar.Program.<MainAsync>d__2.MoveNext() in C:\Repos\lego_automated_car\LegoCar\LegoCar\Program.cs:line 41
   at LegoCar.Program.Main(String[] args) in C:\Repos\lego_automated_car\LegoCar\LegoCar\Program.cs:line 26

I'm pretty sure I know my devices mac adress, I converted it to long using the helper class BlueGigaBLEHelper, double checked it with the Hub.PrimaryMacAddress  and it is the same as the  hex input there. (note that I use the default WinRt bluetooth).
However, I also can't connect to it using but it also fails when I try to connect it in the way the ExampleTwoHubsMotorControl does:
  var host = serviceProvider.GetService<PoweredUpHost>();

  //var hub = await host.DiscoverAsync<TechnicMediumHub>();
  var hub = await host.CreateByStateAsync<TechnicMediumHub>(adressAsLong);
  await hub.ConnectAsync();

Also after that I can't use the style  var motor = technicMediumHub.A.GetDevice<BasicMotor>();, because BasicMotor is not a IPoweredUpDevice.

Yeah seems like the README needs some update. Discovery and DI scope creation works easiest when re-using host logic and host functions. I justed tested this with a TechnicMediumHub and a TechnicXLargeMotor.
using SharpBrick.PoweredUp;

using Microsoft.Extensions.DependencyInjection; // SharpBrick.PoweredUp uses the DI system
using Microsoft.Extensions.Logging;
using SharpBrick.PoweredUp.Bluetooth;
using SharpBrick.PoweredUp.Protocol;
using SharpBrick.PoweredUp.Protocol.Messages; // SharpBrick.PoweredUp also logs stuff

var serviceProvider = new ServiceCollection()
    .AddLogging()
    .AddPoweredUp()
#if WINDOWS
    .AddWinRTBluetooth() // using WinRT Bluetooth on Windows (separate NuGet SharpBrick.PoweredUp.WinRT; others are available)
#endif
    .BuildServiceProvider();

// getting utilities
var bt = serviceProvider.GetService<IPoweredUpBluetoothAdapter>();
var host = serviceProvider.GetService<PoweredUpHost>();

// discover a LWP bluetooth device
var tcs = new TaskCompletionSource<ILegoWirelessProtocol>();

bt.Discover(async deviceInfo =>
{
    if (!tcs.Task.IsCompleted)
    {
        var p = host.CreateProtocol(deviceInfo);

        tcs.SetResult(p);
    }
});

var protocol = await tcs.Task;

// connect the protocol
await protocol.ConnectAsync();

// send a raw message which should work with ANY motor connected to a hub
var response = await protocol.SendPortOutputCommandAsync(new PortOutputCommandStartPowerMessage(
    0, // PORT A
    PortOutputCommandStartupInformation.ExecuteImmediately, PortOutputCommandCompletionInformation.CommandFeedback,
    100
)
{
    HubId = 0, // as if we ever see another one
});

await Task.Delay(2000);

await protocol.DisconnectAsync();

with the following csproj
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">net8.0-windows10.0.19041.0;net8.0</TargetFrameworks>
    <TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">net8.0</TargetFrameworks>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
  </PropertyGroup>

  <ItemGroup>
    <ProjectReference Include="..\..\src\SharpBrick.PoweredUp\SharpBrick.PoweredUp.csproj" />
  </ItemGroup>

  <ItemGroup Condition=" '$(TargetFramework)' == 'net8.0-windows10.0.19041.0' ">
    <ProjectReference Include="..\..\src\SharpBrick.PoweredUp.WinRT\SharpBrick.PoweredUp.WinRT.csproj" />
  </ItemGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.Extensions.Configuration.CommandLine" Version="8.0.0" />
    <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="8.0.0" />
    <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
    <PackageReference Include="Microsoft.Extensions.Logging" Version="8.0.0" />
    <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="8.0.0" />
  </ItemGroup>

</Project>

and the following invocation
dotnet run -f net8.0-windows10.0.19041.0

I fixed the problem with the manual connection, the address conversion is wrong (at least for the WinRT version).  I just used the commandline logged one from poweredup device list. that works.
I ran your example, it works!
I get the following errors (I updated the not supported messages in the Device.GetStaticPortInfoMessages to add some info, I can make a PR if you want it):
// Device 'RgbLight' does not support Systemtype 'LegoWeDo20_WeDoHub' on Hardware '<IP_ADDRESS>' and Software '<IP_ADDRESS>'
// Device 'Current' does not support Systemtype 'LegoWeDo20_WeDoHub' on Hardware '<IP_ADDRESS>' and Software '<IP_ADDRESS>'
// Device 'Voltage' does not support Systemtype 'LegoWeDo20_WeDoHub' on Hardware '<IP_ADDRESS>' and Software '<IP_ADDRESS>'
You also get those? (I also get them if I run without any motors, should be the same as you have).

Added PR #194  which is needed to support this.
The output of discovery now works (for this, not yet for my large lineair motors.
Discover Ports Function: 9 / 9
LegoTechnic_MediumHub
##################################################
0B-00-43-02-01-01-01-00-00-01-00
05-00-43-02-02
11-00-44-02-00-00-4C-50-46-32-2D-4D-4D-4F-54-4F-52
0E-00-44-02-00-01-00-00-C8-C2-00-00-C8-42
0E-00-44-02-00-02-00-00-C8-C2-00-00-C8-42
0E-00-44-02-00-03-00-00-C8-C2-00-00-C8-42
0A-00-44-02-00-04-00-00-00-00
08-00-44-02-00-05-00-10
0A-00-44-02-00-80-01-00-04-00
##################################################

Are you interested in a PR that adds some improved error messages?

And here is the output from device list:
 - Port: 0x02 / 2
    - IOTypeId: Motor / 0x0001 / 1
      Revision: SW: <IP_ADDRESS>, HW: <IP_ADDRESS>
      Capabilities: Output
      ModeCombinations: []
    - Mode 0: Name: LPF2-MMOTOR, Symbol: , Capability: Output
      - DataSet: 1x SByte, TotalFigures: 4, Decimals: 0
        Output Mapping: Absolute
        Raw Min:    -100, Max:     100
        Pct Min:    -100, Max:     100 (pass-through)
        SI  Min:    -100, Max:     100 (pass-through)

I lost a bit oversight of what you all did. Let me try to summarize

The device enumeration hung because of the string termination bug you fixed in #194. Is that closing #193 ?
In #193 you talk about the technic linear motors showing an error during discovery. That would be a different issue than what you originally describe in #193 and fix in #194, correct? If yes, we should put it in a separate issue. I tend to agree, that this is a firmware version issue. There are unknown / undocumented modes in the motor I used originally (see docs) and patching them out over time makes sense.
Since discovery works, we could now create a new device for the motor. It would be awesome if you file a pull request for this! I can not test it due to lack of hardware.

Yeah I can image, I'm doing everything at the same time and didn't really know what I am doing lol :)

WeDo devicelist / port dump hang and threw an error because of the fix in #194
The TechnicLargeLinearMotor device list hang because it used different static port info messages, described here #193 . I will make a PR for that later.
a, Perhaps the port dump device list would also be helped if it didn't use the static messages here.
I made good progress with supporting the WeDo motor, I guess we should name this 'SimpleMediumLinearMotor'. Can you easily see from the dump /device list if this is a BasicMotor or anything of the other motor types? If not I will investigate.
Will make a separate PR for some better error messages.

used different static port info messages

This should not be. Either we discover the device OR use static port inform messages. Do not remember why the behavior is like that. Device enumeration not necessarily need to discover the devices but my just pretty print our existing knowledge.

Ok I'll make a separate ticket for that then, I really think it did both. It was requesting port mode information and got a reply for 5 modes, but actually requested information for 6 modes, which is the amount in the static port info.


🐛 fix: wrong history url for gitlab and codeberge

Fixes: https://github.com/welpo/tabi/issues/293

Summary

Related issue

Changes

Accessibility

Screenshots

Type of change

[X] Bug fix (fixes an issue without altering functionality)
[ ] New feature (adds non-breaking functionality)
[ ] Breaking change (alters existing functionality)
[ ] UI/UX improvement (enhances user interface without altering functionality)
[ ] Refactor (improves code quality without altering functionality)
[ ] Documentation update
[ ] Other (please describe below)

Checklist

[X] I have verified the accessibility of my changes
[ ] I have tested all possible scenarios for this change
[ ] I have updated theme.toml with a sane default for the feature
[ ] I have made corresponding changes to the documentation:

[ ] Updated config.toml comments
[ ] Updated theme.toml comments
[ ] Updated "Mastering tabi" post in English
[ ] (Optional) Updated "Mastering tabi" post in Spanish
[ ] (Optional) Updated "Mastering tabi" post in Catalan

I don't know about gitlab, but it's make sense to put the full path of the index.md file, right?

Thank you!


Add tip to check the qemu firmware blob

Added a tip admonition for the QEMU instruction template to check that
the file is a firmware blob or not. This was based off of feedback we
received.
Built html to check that content rendered.
This applies to Jira 1036
Signed-off-by: Katrina Prosise<EMAIL_ADDRESS>

Docs for 55e636f6a6001af445a8e9a6a609308b1c09b58e are browesable at: https://ci.foundries.io/projects/fio-docs/builds/1231/docs/artifacts/html/index.html

Obsolete, fioctl prints error message now.


External links to open in new tab

All links to external google docs open in the same tab - so the reader loses the guide.
Here is how to do it in reStructuredText, there does not seem to be an easy solution: https://stackoverflow.com/questions/11716781/open-a-link-in-a-new-window-in-restructuredtext

Hi Aleks, I would rather have clarity in the code and the format - I want to avoid magic - I can wait for reStructuredText to catch up or just live with it for now - or for something in the official theme to change. So I am labelling this wontfix for now. If we get lots of feedback then we can revisit.


Capture all mTLS traffic in permissive mode

Currently, our ALPN matching logic is not complete. As a result,
requests that come in with the wrong ALPN will be forwarded to the
application.
This changes our filter chains such that in permissive mode, Istio mTLS
traffic is always captured by a filter chain that will terminate the
TLS. Note that the traffic may not be valid - for example, raw TCP on a
filter chain with HCM, but we will fail at the Envoy level rather than
in the users application.

/test all

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
c3cc9933c9765411fcc9c26096b14713da9b67a0
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
c3cc9933c9765411fcc9c26096b14713da9b67a0
link
/test lint_istio

gencheck_istio
d70ec71ff7bcf8c0f5bd4038990edcc6d314f0d4
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
d70ec71ff7bcf8c0f5bd4038990edcc6d314f0d4
link
/test gencheck_istio

lint_istio
d70ec71ff7bcf8c0f5bd4038990edcc6d314f0d4
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

do we need a release note for this change?

I suppose we could. In theory it shouldn't impact users unless they have an strange cluster setup - it should never happen in general

Not sure i understand, for protocol detection, isn't the filter chain match has covered all the application protocol for http and tcp?

Yes, this is changing explicitly declared TCP and HTTP ports to capture
all. So if we get unexpected mtls ALPN we will capture it in envoy instead
of passing it to the server
On Mon, Mar 29, 2021, 7:56 PM Zhonghu Xu @.***> wrote:

Not sure i understand, for protocol detection, isn't the filter chain
match has covered all the application protocol for http and tcp?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/31774#issuecomment-809866860, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXLUHYOBUHPMSTJ6WM3TGE4W5ANCNFSM42A2JGPA
.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8bc9655840df1a37dfc1e963d74c2fa3d407aa15
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8bc9655840df1a37dfc1e963d74c2fa3d407aa15
link
/test release-notes_istio

integ-pilot-multicluster-tests_istio
8bc9655840df1a37dfc1e963d74c2fa3d407aa15
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Errors don't show the exact location of the error

[2] Template file: /code/nexus/portal/server/views/unsupported-browser.pug
[2] Possible reason: in the template may be used undefined variable.
[2] Solution in this case pass a variable into a pug file via the query parameter.
[2] For example, if you use in pug the external variable, like title= customData.options.title,
[2] then pass it into pug 'template.pug?customData=' + JSON.stringify({options:{title:'My title'}})
[2] TypeError: Cannot read properties of undefined (reading 'undefined')
[2]     at processResult (/code/nexus/node_modules/webpack/lib/NormalModule.js:750:12)
[2]     at /code/nexus/node_modules/webpack/lib/NormalModule.js:855:5
[2]     at /code/nexus/node_modules/loader-runner/lib/LoaderRunner.js:399:11
[2]     at /code/nexus/node_modules/loader-runner/lib/LoaderRunner.js:251:18
[2]     at runSyncOrAsync (/code/nexus/node_modules/loader-runner/lib/LoaderRunner.js:156:3)
[2]     at iterateNormalLoaders (/code/nexus/node_modules/loader-runner/lib/LoaderRunner.js:250:2)
[2]     at /code/nexus/node_modules/loader-runner/lib/LoaderRunner.js:223:4
[2]     at /code/nexus/node_modules/webpack/lib/NormalModule.js:829:15
[2]     at Array.eval (eval at create (/code/nexus/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:12:1)
[2]     at runCallbacks (/code/nexus/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:27:15)
[2]  @ ./server/views/index.ts 84:19-55
[2]  @ ./server/main.ts 29:16-34
[2]  @ ./server/mainPublic.ts 8:15-32 9:13-30

It only shows the main file where the error is, but it uses a layout which then uses a layout .. the error is hard to find.

Are you using HtmlWebpackPlugin in your project? If yes, whether using in PUG external variabbles, e.g.:
div= htmlWebpackPlugin.options.title

I need the source of unsupported-browser.pug and webpack.config.js

In this case I am using the default function output. I discovered the problematic code is:
link(rel="preload" href=require('assets/fonts/ibm-plex-sans-v7-latin-regular.woff2') as="font" type="font/woff2" crossorigin)

which then goes to the webpack file-loader
This code worked with webdiscus 1.4 but broke with 1.6. I think perhaps the version should have been bumped to 2.x?
Perhaps 1.6 is doing something funky with require.

the error Cannot read properties of undefined (reading 'undefined') has not a relation with it the require().
If the required resource is not found (e.g. wrong resolved path), it will display some like Can't resolve the file ....
To locate the problem I need more information:

Are you using the HtmlWebpackPlugin in your project? If yes, are external variables used in the pug template? e.g.:

div= htmlWebpackPlugin.options.title

Is used Webpack 4 or 5?
What version of pug-loader was used? 1.6.0, 1.6.1, 1.6.2, 1.6.3?

I have created the test case for require fonts.
With Webpack 5 it works
index.pug, where the 'assets/fonts/ is relative path by the the template
html
  head
    link(rel="preload" href=require('assets/fonts/ibm-plex-sans-v7-latin-regular.woff2') as="font" type="font/woff2" crossorigin)
  body
    p Hello World!
    img(src=require('image.jpeg'))

webpack.config.js
const path = require('path');
const PugPlugin = require('pug-plugin');

module.exports = {
  output: {
    path: path.join(__dirname, 'public/'),
    publicPath: '/',
  },

  entry: {
    index: 'src/index.pug', // the `pug-plugin` is required
  },

  plugins: [
    new PugPlugin() //  extract HTML from pug defined in webpack entry and save to separate file
  ],

  module: {
    rules: [
      {
        test: /\.pug$/,
        loader: PugPlugin.loader, // `@webdiscus/pug-loader` is already included in PugPlugin
        options: {
          method: 'render', // export the HTML string, rendered at compile time
        },
      },

      {
        test: /\.(png|jpg|jpeg)/,
        type: 'asset/resource', // <= must be exact this to handles an image
        generator: {
          filename: 'assets/images/[name].[hash:8][ext]', // save required image under this filename
        },
      },

      {
        test: /\.(eot|ttf|woff|woff2)/,
        type: 'asset/resource',  // <= must be exact this to handles an font
        generator: {
          filename: 'assets/fonts/[name][ext]', // save required font under this filename
        },
      },
    ],
  },
};

What is difference by usage require() to compare with your case? I think the problem is elsewhere.
The file-loader is deprecated for Webpack 5, link to file-loader doc.
For Webpack 5 should be used assets module.
From ver 1.6 I have "improved" the resolving of required resources. The "interpolation" of paths was replaced with "evaluation" of once. Now is possible use a variable in require('path/to/images/${myImage}') at compile time.  Added resolving of paths from tsconfig.js.

Thank you for the investigation. Unfortunately I can't use the assets modules as it's not as flexible when it comes to the output paths.
I am trying to make a reproducible small test case, which is not that easy. :)

I suspect method: "compile" is for some reason not being used.
https://github.com/Rush/webdiscus-issue-9-repro
I also suspect file-loader has nothing to do with it. It's an issue purely in pug-loader. Please check out my repo and follow README.

In regards to file-loader I need more granularity as for where to output the files. I believe webpack doesn't expose such granular options for assets.
  const fileLoader = {
    loader: 'file-loader',
    options: {
      esModule: false,
      outputPath: '../public-built',
      context: path.resolve(__dirname),
      publicPath: '/',
      name: '[hash].[ext][query]'
    },
  };

Just wondering if you were able to run my repo and reproduce?

Just wondering if you were able to run my repo and reproduce?

Sorry, I am just very busy, I try your repo tomorrow.
Thank you for the repo!

Sorry, I am just very busy,

Good luck with whatever keeps you occupied! :)

I try your repo tomorrow.

Thanks!

yes, I can reproduce the issue and I found the place in the code. I will fix it.
Thank you for very important issue report.

The problem is by usage variables in template.
At pre compile time the usage of variables like opts.prop1.prop2 or opts[prop1] has issue because they are not defined. Only in runtime will be passed variables available. This is the BUG :-/
Temporary solution
Anywhere in PUG use ?. notation (node >= 14) by each variable with a property. Use this only in JS context, not in PUG context, e.g.:
you use already the correct chained properties with ?.:
 - const osName = parsedUA?.os?.name; // RIGHT!

In your template unsupported-browser.pug you should change:
this
span.browser-icon
  +svgIcon(browserIcons[recommendedBrowser])

to
span.browser-icon
  - const icons = browserIcons?.[recommendedBrowser];
  +svgIcon(icons)

and in mixin self use properties with ?.:
mixin svgIcon(iconData, currentColor = 'currentColor')
  - const [width, height, _, __, paths] = iconData?.icon || [];
  ...

I understand, this is not comfortable and tricked, sorry, but currently this works with this limitation.
P.S. I try to fix it, but it is not easy and not quick.

The workarounds seem really messy. I will stick with the old version.
Probably variable existence check should only be applied for html render mode.

Hello @Rush,
in the new version 1.7.0 I have fixed the issue undefined variable by usage the compile method.
This was a compromise for compile method:

(v1.6.x) full support for resource resolving, but object property must be used with ?.
-VS-
(v1.4.x, v.1.7.x) limited support for resource resolving ( see in resolve resources the table below ) but usage an object property is w/o ?.

But the same limitation has original pug-loader. The problem is with webpack require. My solution in v1.6. was a mega useful "killer-feature", no other pug-loader does this.
Do you can please try to test the version 1.7.0?

Yes thank you. This is now solved. There is another issue for which I'll open a different ticket.

https://github.com/webdiscus/pug-loader/issues/10


Order by metadata when orderIndex is the same

Closes #26
Fixes an issue where items that have the same orderIndex (like vanilla stone and wool for example) are shown in a random order.
Before

After

Looks good to me, will likely change it up a bit when I'm changing up IngredientOrderTracker but this is a good foundation.


Fix to enable insert-selected-text on mac

ctrl-enter on a mac is not mapable due to OS restrictions.

Thanks!


Fix CUDA tests on Numpy 1.10

Fix confirmed on my cuda-enabled osx.  Not going to wait for travis-ci, which doesn't test cuda.


Extend line chart width without labels

I'm using withHorizontalLabels=false
Is there a way to remove the extra space on the sides of the chart?
I want the chart to extend entirely from the left to the right.
E.G.

I don't think there is a way right now, curious what a PR for this would look like

@ighormartins You have to go into line-chart.js in the package and manually set the paddingTop and paddingRight to 0.

style={{
paddingRight:0
}}

not working


Http response sometimes ignores content-header

An HTTP response created in code will not always return as the correct content-type. This can result in output being formatted incorrectly or a 406. Root cause: https://github.com/Azure/azure-functions-host/issues/2552
The issue is currently being addressed in azure-functions-host, and the workaround is to add the following property to the response: isRaw: true

It looks like we already do that:
https://github.com/Azure/azure-functions-python-worker/blob/0e7acf09193e7ad94586180a92b389141f464117/azure/worker/bindings/http.py#L96-L101

Awesome!! :) We'll be making a change soon to get rid of the "is_raw" flag and default it to true on the functions-host side.
I'll submit a PR for corresponding changes when the time comes, but wanted to file this issue in the meantime, since java and javascript have this issue.


Write some article what "Preliminary support for dotnet test" means and how to use it.

Release notes of latests omnisharp-vscode mentions 'Preliminary support for dotnet test', however i haven't seen any further information what it is and how it can be used for development. Short post about it could be nice and usefull.

This is a good idea. In the meantime, here is some information about dotnet test in general.

@chuckries
Granted this is over 6 months old, but the issue is still open and the link is bad. I got a 404 page. Please update the link.


Stealth Address Disappears from Wallet List after closing and reopening app

Not sure if it's supposed to do this @justinvforvendetta but wanted to make you aware either way.
Occurs on Mac OS X 10.13

@vvillait88  - My wallet does not sync with network, are you facing the same issue?

it syncs perfectly

I am seeing the same, stealth wallet disappears in Mac client

@akramtariqkhan can you delete your comment, this has nothing do with the issue this is open for

Same behavior here.
Mac OS X 10.13.2 and Ubuntu 16.04.3 LTS xenial

I got something even weirder. My stealth address changed & shortened. I also have video. https://youtu.be/eDpPSTUrmHU

Similar problem on Linux Wallet. Stealth address goes away. perhaps because it was generated through console getnewstealthaddress
Since Issue #184 problem where you cant generate Stealth address directly from UI

Super stealthy wallet it seems. lol

this was fixed today.


Update to 1.4

Add instrumentation dep

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin please rerender


fix(sdk-node): move @opentelemetry/exporter-jaeger to dev dependencies

Which problem is this PR solving?
@opentelemetry/sdk-node depends on @opentelemetry/exporter-jaeger despite never using it directly.
This increases the number of dependencies required to install @opentelemetry/sdk-node even if
@opentelemetry/exporter-jaeger is not used.
Fixes #3759
Short description of the changes
The change moves @opentelemetry/exporter-jaeger to the dev dependencies to resolve it in tests
but avoid requiring it for general usage of @opentelemetry/sdk-node. This is consistent with the
@opentelemetry/sdk-node documentation which states
that exporters must be explicit dependencies.
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Locally building and testing the package after running npm install in opentelemetry-js/experimental/packages/opentelemetry-sdk-node.

Checklist:

[X] Followed the style guidelines of this project
[ ] Unit tests have been added - N/A
[ ] Documentation has been updated - NA (already consistent)

Hi @open-telemetry/javascript-maintainers, would you please take a look at this change?

As you can see in the test run a changelog entry is needed.
Not sure if this should be marked as breaking. At least a clears statement in the changelog should me made that an explicit dependency is needed now. Maybe even improve the corresponding section in readme to make this clearer.

Thank you @Flarna! Will add the changelog entry shortly and will update the readme as well.

Thank you for your contribution @Vadman97, removing this exporter has been long overdue :slightly_smiling_face:
The exporter is lazy-required in sdk-node to allow sdk-node to work with bundling tools as the Jaeger exporter does not support them. We can remove it, but it will break users with the environment variable set.
https://github.com/open-telemetry/opentelemetry-js/blob/d3436bfac5fb2bf739808afef305530fce88ef61/experimental/packages/opentelemetry-sdk-node/src/TracerProviderWithEnvExporter.ts#L76
We'll also have to adapt the error message that the exporter has to be installed manually.
https://github.com/open-telemetry/opentelemetry-js/blob/d3436bfac5fb2bf739808afef305530fce88ef61/experimental/packages/opentelemetry-sdk-node/src/TracerProviderWithEnvExporter.ts#L79-L81
Previously we've gone the way of releasing a version that adds a postinstall script that alerts users that a feature will disappear in the next release (see #3833).
As @opentelemetry/sdk-node is widely used, I propose we do the same before merging this PR. It will delay this PR for a bit, but it will give users some advance notice that their telemetry will go missing when they update. :thinking:
See also:

#2618
#3739
#3833
#3759
#3521

Thanks for your help @pichlermarc , and sorry for the delay here. I'm updating the branch now to change TracerProviderWithEnvExporter.ts as you described.

@pichlermarc - is this ready to merge now that #4068 is in?

@pichlermarc - is this ready to merge now that #4068 is in?

Yes, but we still need to cut a release first to get #4068 out :slightly_smiling_face:
I'm going to release 0.42.0 on Monday (trying not to release on Friday) - after that is done we can merge this in.
Sorry for the delay.

hey @pichlermarc , sorry to pester here - is there any estimate as to when the next version will be released to npm so that we can update our dependency on @opentelemetry/sdk-node?

The release with the warning message went out last week; I'd cut another release mid-next week.

Hey @pichlermarc , any updates here on the next release being shipped?

@Vadman97 release PR is open at #4183


Update CONTRIBUTING.md

Updating contributing guide to be consistent with travis config for running linters.

Coverage remained the same at ?% when pulling 23afade4fe1925165c0d2b610d0dfacee950e533 on jmeulemans-contributing-update into 4a97610efcd5c11601d706dbd8fcecf8c0214711 on master.


disable bevy default features

this speeds up compile time, and allow usage of this library in a wasm build

Looks like a small change in master caused a test failure in multiple_windows on lines 42/43 (add a ".0" to make window size a float).
Does this change have any other implications you're aware of? I'm not well versed in the use of cargo features. I assume all this is doing is minimizing the number of feature dependencies, which is useful in applications like wasm.

It doesn't change anything except reducing the number of dependencies for applications that are already limiting the number of dependencies
The important (and undocumented) thing about rust features is that cargo treats them as additive, so it will use the union of all features enabled to a dependency. you can't have mutually exclusive features, you can't have features enabled for one transitive dependency and not for the other (ie if I depend on bevy and on bevy_mod_picking which depends on bevy, bevy will be compiled with the union of enabled features from both dependencies).
I tested this PR in a wasm build and it works 👍

Thanks for the explanation - really appreciate that! Would you mind either:

including the small fix to resolve the failed test
or, pointing to a previous bevy git commit in the cargo.toml, prior to this breaking change

I can then merge in this PR. Thanks!

Turns out this is causing a runtime panic for the examples:
thread 'thread 'mainthread '' panicked at 'Compute Task Pool (1)Resource does not exist alloc::boxed::Box<dyn bevy_render::renderer::render_resource_context::RenderResourceContext>.' panicked at 'Compute Task Pool (3)', Resource does not exist alloc::boxed::Box<dyn bevy_render::renderer::render_resource_context::RenderResourceContext>.C:\Users\aevyr\.cargo\git\checkouts\bevy-f7ffde730c324c74\45e2be3\crates\bevy_ecs\src\resource\resources.rs', ' panicked at 'C:\Users\aevyr\.cargo\git\checkouts\bevy-f7ffde730c324c74\45e2be3\crates\bevy_ecs\src\resource\resources.rs::Resource does not exist alloc::boxed::Box<dyn bevy_render::renderer::render_resource_context::RenderResourceContext>.282282::32',
32C:\Users\aevyr\.cargo\git\checkouts\bevy-f7ffde730c324c74\45e2be3\crates\bevy_ecs\src\resource\resources.rsnote: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
:
282:32
thread 'main' panicked at 'Task thread panicked while executing.: Any', C:\Users\aevyr\.cargo\git\checkouts\bevy-f7ffde730c324c74\45e2be3\crates\bevy_tasks\src\task_pool.rs:75:18

I think this means we need to figure out which dependency is needed, then add it as a required feature for examples.

sorry about that, it's done in #71


Code will be uploaded by November 1st 2023

Hi @LouisSF,
You said the code will be uploaded by November 1st 2023. Do you have any update ?
Clément

Hi,
Sorry for the inconvenience. Due to deadlines from other incoming projects, the work on the upload is going at a slower pace for now. I am aiming for an upload in the first quarter of 2024.
I will update the README for now accordingly.
Thank you for your inquiry !
Louis


VirtualCluster should support to sync specific conditions of PodStatus from tenant to super

User Story
As a developer, I would like VirtualCluster to support to sync specific conditions of PodStatus from tenant to super, for some user-defined condition types are designed to be added by users or controllers from tenant cluster.
For example, OpenKruise provides some workloads that support in-place update for Pods, so we define a InPlaceUpdateReady type readinessGate and add the condition of it into Pod status. However, now syncer will only sync Pod status from super to tenant, which will overwrite the custom condition and lead to Pod always be NotReady because Kubelet can not see this condition in super cluster.
Detailed Description
VirtualCluster syncer should support to sync specific conditions of PodStatus from tenant to super.
/kind feature

Interesting idea, I'm trying to think of how we could accomplish something, it leads us a little into a more split-brain super & tenant then have context that matters vs making spec tenant authoritative for the .spec and super for the .status. How does this function under the hood when an update actually happens? Would the syncer need to push patches/updates to the pod specs for that in-place upgrade to be fulfilled? I don't believe we support that as of today at all.

Thanks for filing the issue, I understand the request and I think we should address it. One problem is that both tenant control plane and super cluster may update the conditions specified in the readiness gate. The bigger problem is that the status now has two sources of truth in two etcds, which makes it difficult to avoid overwriting under races.

@FillZpp, a workaround is to add a Pod label by Kruise controller when the readiness gate is ready, to indicate the syncer to set the condition in the super cluster, which I admit is definitely a hack.  I cannot think of a more elegant solution at the moment.

Thanks for all your replying.

Would the syncer need to push patches/updates to the pod specs for that in-place upgrade to be fulfilled? I don't believe we support that as of today at all.

Alright, forget about the in-place upgrade, which is just a case we noticed. Actually this is a common request, for Kubernetes provides readinessGate feature to let users control whether a Pod should be ready or not.
kind: Pod
...
spec:
  readinessGates:
    - conditionType: "www.example.com/feature-1"
status:
  conditions:
    - type: Ready                              # a built in PodCondition
      status: "False"
      lastProbeTime: null
      lastTransitionTime: 2018-01-01T00:00:00Z
    - type: "www.example.com/feature-1"        # an extra PodCondition
      status: "False"
      lastProbeTime: null
      lastTransitionTime: 2018-01-01T00:00:00Z
  containerStatuses:
    - containerID: docker://abcd...
      ready: true
...

When we set a custom conditionType in spec.readinessGates, kubelet could set Pod as ready only if the custom condition with True has been added into status.conditions.
However, if syncer can only push the whole status from super to tenant, the custom condition which user adds in tenant cluster will never be synced to super, which means the Pod will never be ready.
Since this is a basic feature provided by Kubernetes, it will be nice if VirtualCluster could support it.

a workaround is to add a Pod label by Kruise controller when the readiness gate is ready, to indicate the syncer to set the condition in the super cluster, which I admit is definitely a hack. I cannot think of a more elegant solution at the moment.

Yeah, it is a workaround that we can deploy two controllers in both super and tenant clusters. The one in tenant adds a specific label into Pod, then the other one in super watches the label and adds condition into status.
I don't know much about the implementation of VirtualCluster, so maybe this is impossible... I'm wondering if we can have an optional white list to let user choose which condition types that should be synced from tenant to super?

Maybe we can use some tricks like protectedMetaPrefixes to setup a list to determine which status conditions should be sync from tenant cluster to super cluster?

@Fei-Guo  @FillZpp I agree there should be a mechanism to config the down/up  syncing behave，but can we  let a default configuration to support a quite common scenario ? The most common one is  :The kurise is only installed  in Tenat Cluster, let it work as it works as in Super Cluster, while Kurise needn't to any change anying.
Other scenario, for example some controller will work in Super ,even both Tenant and Super,we can support them by configing some special Labe to guide the complex  behavior.

already supported in this pr https://github.com/kubernetes-sigs/multi-tenancy/pull/1294
did you meet some bug in testing?

already supported in this pr kubernetes-sigs/multi-tenancy#1294 did you meet some bug in testing?

This implementation is straightforward but there is a very tiny race window in theory such that tenant condition can be overwritten. If the readiness condition is updated by tenant at the time between CheckUWPodStatusEquality and vPod.Update(), the readiness condition can be overwritten by the  vPod.Update() call. Syncer was not designed to handle all kinds of races, it uses periodic scanning to find the mismatches the fix them. The problem here is that once the readiness condition is removed accidentally, no one is going to reconcile and recover it because none of the tenant controller expects the condition can be removed once it is set. To eliminate the race, the tenant controller can notify syncer and let the syncer update the readiness conditions in the super cluster and reconcile for them.
Not sure if Kruise controller hits this race though.


Side effects in functions

The specs seem to use different types of signatures for functions. for instance:
Case 1:
def state_transition(state: BeaconState, signed_block: SignedBeaconBlock, validate_result: bool=True) -> BeaconState:
 block = signed_block.message
    # Process slots (including those with no blocks) since block
    process_slots(state, block.slot)
    # Verify signature
    if validate_result:
        assert verify_block_signature(state, signed_block)
    # Process block
    process_block(state, block)
    # Verify state root
    if validate_result:
        assert block.state_root == hash_tree_root(state)
    # Return post-state
    return state

and case 2:
def process_slots(state: BeaconState, slot: Slot) -> None:
    assert state.slot < slot
    while state.slot < slot:
        process_slot(state)
        # Process epoch on the start slot of the next epoch
        if (state.slot + 1) % SLOTS_PER_EPOCH == 0:
            process_epoch(state)
        state.slot = Slot(state.slot + 1)

In case 1, it seems redundant to return a BeaconState because the state variable is passed by reference (I am not Python expert, but AFAIK state is mutable and hence passed by reference.) But the fact that the function's return type is a BeaconState also gives a false sense of immutability of the input object state. The result is actually in state (side-effect and in the returned value.
In case 2, the mutability of the parameter state is used and instead of returning a state, process_slots modifies state, so the result is obtained by a side-effect on input parameter state (passed by reference).
Main question: How is the choice of a function signature determined in the specs?
Some functions rely on side-effects, and some may not.
Python parameters' passing and the interference with local storage is known to be rather cumbersome as described in the additional comment below, so a clear and principled way of specifying functions may help reducing of problems that can arise in implementations.
Additional comment
For instance (again, I am not a Python expert, so if this is wrong, please correct me), the following code may not have any side-effect on state and leave the input parameter (although passed by reference) state unchanged:
class BeaconState:
    def __init__(self, slot):
        self.slot = slot

def process_slots(state: BeaconState, slot: int) -> None:
    s = BeaconState(0)
    s.slot = state.slot
    # the value of s is the same as the initial value of state
    state = s
    while state.slot < slot:
        state.slot = (state.slot + 1)

# k is a BeaconState
k = BeaconState(2)
print (k.slot) # Result is 2
process_slots(k, 4)
print (k.slot) # result is still 2

The specs may benefit from a clearer definition of the functions (without side-effects).

I wonder if there is a way to tag additional markers like var or mut in MyPy?
def state_transition(state: mut BeaconState, signed_block: SignedBeaconBlock, validate_result: bool=True) -> BeaconState:
 block = signed_block.message
    # Process slots (including those with no blocks) since block
    process_slots(state, block.slot)
    # Verify signature
    if validate_result:
        assert verify_block_signature(state, signed_block)
    # Process block
    process_block(state, block)
    # Verify state root
    if validate_result:
        assert block.state_root == hash_tree_root(state)
    # Return post-state
    return state

Yeah, I felt the same.
Old issue and some options: https://github.com/ethereum/eth2.0-specs/issues/1059
Although I feel it's a bit late to make it side-effect-free in phase 0, I'd differ to the client teams.

Sorry did not see there was another issue with the same topic.
Altogether, this is probably dangerous to delegate a lot to client teams, and it does not make their life easy, nor does it open the door to implementations in side-effect free languages like Haskell.
This seems to indicate that Python may not be the best candidate to develop easy-to-read and sound specifications.
There are lots of specification-friendly languages, in which we can write readable, verifiable, and documented specs, without bothering about Python specific side-effect problems.
An example is Dafny, and we have already written dozens of function specifications like state_transition, with a clear semantics, easy to read, documented and machine checked.

@franck44
But the fact that the function's return type is a BeaconState also gives a false sense of immutability of the input object state. The result is actually in state (side-effect and in the returned value.

I agree with this. In fact, on a first reading of the spec, I also interpreted state_transition to be a pure function based just on it's signature.

@franck44
The specs may benefit from a clearer definition of the functions (without side-effects).

Again, I agree with this.
As a first step, I think that documenting the current behavior will largely help first-time readers to understand the spec swiftly & correctly. I also support the larger goal of making the spec more "functional" in it's behavior.
I'll bring up this issue in the next spec team call & post updates in this thread.

@adiasg if there is anything we can do to help in the discussion (e.g. present the work we are doing with Dafny) let me know.
We have written a functional formal spec for almost all of the functions and we are happy to share our experience.

Update from spec team call:
The general view is that re-writing the Python specification to be more functional will change its structure significantly, and deviate from the primary goal of serving as an implementation guide for client teams. There are some things which are undesirable in the current version of the pyspec, such as the misleading function signature of state_transition, which should be rectified in the coming versions.
On the other hand, this Python specification should have a "how to use" manual that helps newcomers to correctly understand it.
For users that require a more formal specification, there is Runtime Verification's K model, and now a Dafny model from @franck44 & PegaSysEng.

There are some things which are undesirable in the current version of the pyspec, such as the misleading function signature of state_transition, which should be rectified in the coming versions.

Just wanted to highlight that this should definitely be done. Reading some client code I found it very confusing and then saw that they copied one for one what the spec does. Doesn't look great.

Very informative thanks I was just thinking same thing what is the best solution to house ETH2 as real-time holographic code ....

closing via #2104


Add recursive fibonacci example/benchmark (RFC)

I've noticed there are not too many benchmarks in this repo. I wanted to port some of the existing ones so a comparison can be made with 'native' implementations. This benchmark is based on https://github.com/oneapi-src/oneTBB/tree/master/examples/migration/recursive_fibonacci
This is, of course, a very inefficient way to calculate Fibonacci numbers, but it is quite a good benchmark for use cases where new tasks are created recursively. I've implemented this using a custom sender. This is probably not the most idiomatic way but I couldn't figure out how to achieve the same performance by just using existing algorithms (and without start_detached) - perhaps you have some ideas? Any feedback is welcomed.
When running on my computer (on i9-7940X) I get:
# ./examples/example.benchmark.fibonacci 16 46 10 static
Avg time: 4377ms. Result:<PHONE_NUMBER>
# ./examples/example.benchmark.fibonacci 16 46 10 tbb
Avg time: 763ms. Result:<PHONE_NUMBER>

When running the 'native' tbb example (from the tbb repo) I get:
Fibonacci two tasks impl N =<PHONE_NUMBER> Avg time = 311 ms
Fibonacci single task impl N =<PHONE_NUMBER> Avg time = 310 ms

I think this highlights that the any sender template class should probably have a way to customize the allocator. There are two allocations here, one for the sender and one for the operation.
I havent looked into this particular benchmark but I have implented and profiled this example stdexec in the past and the allocations dominate everything.
Note, IIRC tbb tasks use an internal pooling to allocate memory

I think this highlights that the any sender template class should probably have a way to customize the allocator. There are two allocations here, one for the sender and one for the operation. I propose to use a template argument to specify the allocator for the type erased sender and maybe consider the allocator in the receivers environment to chose the allocator for the resulting operation state.
I havent looked into this particular benchmark but I have implented and profiled this example stdexec in the past and the allocations dominate everything.
Note, IIRC tbb tasks use an internal pooling to allocate memory.

I can confirm your numbers. The static_thread_pool performs very badly here relative to the TBB thread pool. I wonder if @maikel is interested in this benchmark.

@igchor if you agree with the changes in this PR, pls merge. https://github.com/igchor/stdexec/pull/1

@igchor if you agree with the changes in this PR, pls merge. igchor#1

Done. Interestingly, after those changes (specifically calling 'stdexec::on' for children vs calling it for when_all) the difference between tbb and static thread pools is lower (tbb sheduler is 1.5x slower) but I think this is because the existing implementation is not really optimal. I will probably submit some improvements to the tbb sheduler after some more testing.

@igchor if you agree with the changes in this PR, pls merge. igchor#1

Done. Interestingly, after those changes (specifically calling 'stdexec::on' for children vs calling it for when_all) the difference between tbb and static thread pools is lower (tbb sheduler is 1.5x slower) but I think this is because the existing implementation is not really optimal. When tweaking how the tasks are submitted in tbb sheduler I can achieve ~450 ms for the configuration I mentioned in the first comment. I will probably submit the improvement to the tbb sheduler after some more testing.
Also, I think it confirms what Eric wrote, that the performance difference is not necessarily related to the allocations (but probably to the scheduling algorithm/overhead).

Indeed. There is some logic regarding the submission queues, which depends on the thread id. Each scheduler caches a pointer to an internal SPSC queue and upon submission the thread id will be used to check whether the current thread is allowed to use this submission queue. If the cached pointer does not match the current thread id the correct SPSC will be searched for, which might cause the overhead here.
This benchmark is helpful for me to improve on the algorithm. Thank you for this.

/ok to test

Hi,
I took a closer look today and from what I see the problem is somewhere else. For this benchmark the load balancer is basically not working and work is being done on 2 or 1 threads independent on the number of threads in the pool.
One simple solution is to change the bwos_params in the constructor of static_thread_pool. The default values are
struct bwos_params {
  std::size_t num_blocks = 8,
  std::size_t block_size = 1024
};

In the bwos algorithm one has num_blocks many buckets and the owner of the workstealing bwos queues claims ownership of one bucket at the time. While having this ownership no other threads can steal from this bucket.
The depth of the fibonacci tree is not big enough (it is around 15-16) until the serial algorithm kicks in. So the buckets never get full and no workstealing can happen.
I ask you to play around with the numbers. I tried num_blocks = 32 and block_size = 4 and I got good results.

@maikel I've tried the parameters you suggested, and the performance is indeed much better. (better than the existing tbb thread pool and similar to a version with my tweaks). I think it would be good to have a few more benchmarks/examples to cover different parallel patterns and see what's the performance like for them.

@maikel I've tried the parameters you suggested, and the performance is indeed much better. (better than the existing tbb thread pool and similar to a version with my tweaks). I think it would be good to have a few more benchmarks/examples to cover different parallel patterns and see what's the performance like for them.

Thats a great idea.

/ok to test

/ok to test

The numbers are looking good. I'd like to merge this. Objections?

approved


Alert Popup feature imported successfully in contact page

Fixes Issue #725
I successfully added an alert which will pops up and will tell the user that message was delivered successfully with a green tick along with I also added a feature without back end with which user would be sent to a fresh new page on clicking Send button where the message is displayed as  "Thank you We received your submission , Return ".
https://user-images.githubusercontent.com/61961107/122445187-ed7c1500-cfbe-11eb-89e3-ef63e3d3ff12.mp4

Hey @anushbhatia as you have already merged my updated PR so I request you to kindly close this PR


set AllowedDomains as the Limit way may be better

There are many subdomains for some sites, it's convenient to set the AllowedDomains by match, like this
// c.AllowedDomains = []string{"hackerspaces.org", "wiki.hackerspaces.org"}
c.AllowedDomains = []string{"*hackerspaces.org"}

@cctse I agree, but it would require API change to be effective, because glob expressions have to be compiled and we have to track manually when the AllowedDomains list changes. Perhaps we could add a SetAllowedDomainsGlobs(domainGlobs string...) error function to the Collector for this purpose.

@asciimoo  use release version to keep it in old version, master branch only for development and release version for stable in different stage, like go-redis/redis does, but this will take you more time

@cctse as an alternative solution you can use Collector.URLFilters:
c.URLFilters = []*regexp.Regexp{
	regexp.MustCompile(`^https?://[a-z]+\.httpbin\.org/`)
}

Full example: http://go-colly.org/docs/examples/url_filter/
I think this functionality covers your needs and maybe adding domain globs too would be redundant. What do you think?

@asciimoo thanks, this can works well, I'm using glob check before visit a link in onResponse.   I'm still thinking add a function like SetAllowedDomainsGlobs may be better

It would require less boilerplate than URLFilters but the feature it provides is only a subset of URLFilters's functionality. I think it is more important to keep the API clean and small than optimizing for edge cases by adding new functions without new functionality. Feel free to reopen if you still disagree.


Remove buying power check when reducing position size

Checks whether a new order reduces a position size (without changing from long to short and vice-versa), if so do not consider the mechanics to verify sufficient capital for order.

I'm curious on the background here.  Is this bug indicative of a problem with his we calculate sufficient capital for order? I think the margin calculations are supposed to account for the direction of the trade. @jaredbroad - maybe I'm not understanding something here?

When we calculate sufficient capital for order, we account for direction of the trade. However it does not account for closing long positions that is independent of margin.
I thought on modifying how initialMarginRequiredForOrder is calculated, because it takes into account the whole order value as a cost but part of the cost is covered by selling current positions. However, it could be higher than the free margin (if it is negative) and prevent selling long positions.

@mchandschuh there were some edge cases for margin calls where the SufficientCapitalRemaining method was returning false and preventing liquidating the margin.
@AlexCatarino Please submit supporting tests which fails before and pass after your fix.

@jaredbroad thanks for the background, and I dig the red, green refractor.
On Jul 12, 2016 9:23 AM, "Jared"<EMAIL_ADDRESS>wrote:

@mchandschuh https://github.com/mchandschuh there were some edge cases
for margin calls where the SufficientCapitalRemaining method was returning
false and preventing liquidating the margin.
@AlexCatarino https://github.com/AlexCatarino Please submit supporting
tests which fails before and pass after your fix.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/QuantConnect/Lean/pull/478#issuecomment-232045549,
or mute the thread
https://github.com/notifications/unsubscribe/AAgb2PZbSzqjGmnrR35fXCEvkEjiHfarks5qU5VRgaJpZM4JJ-_p
.


feat(tests) - add lang heuristics testing

most of them are blind todos for now

I shouldn't have to put all those files within code changes. So here are the files you need to check:
src/test/kotlin/test/tests/extractors/HeuristicsTest.kt
build.gradle
src/main/kotlin/app/extractors/Heuristics.kt


Encryption and Decryption of Read and Write Keys

Is your feature request related to a problem? Please describe.
As a way of improving security with regards to our data, there is need to add another security layer to our data so that access to the keys of our devices is not straight forward. As we move towards stricter access control.
Describe the solution you'd like
Show encrypted keys in the UI that can be decrypted by us on the side.
Describe alternatives you've considered

Decrypt the keys from the app during data fetch
Enable the decryption of the keys based on user role.
Just have the decryption formula given to the network manager on the side......for manual decryption

Additional context
This is also related to the fact that our Get Events returns alls values with the keys which are supposed to be somehow private.

this was resolved.


Fix typos and formatting in docs. Add Godoc badge.

Signed-off-by: Dave Tucker<EMAIL_ADDRESS>

@dave-tucker Tried look at the godoc package and the package doc doesn't seem to rendering as expected. Can you take a look?

@mrjana, looks fine to me...  I'm using godoc -http=:6060
Then browsing to:  http://localhost:6060/pkg/github.com/docker/libnetwork/

@dave-tucker The page in github when you click on the godoc badge doesn't look right

@mrjana ah ha! Yes that's what this commit will fix... those docs are generated from master where the code block above isn't indented properly.

Thanks Dave. LGTM.

LGTM


Show absolute file path on detailed view

That's a feature we have in atom-filesize. It should be available in the vscode version as well.

Done in 40d19f2c8ee054c3ee858578358a5372c0431bed


Option to control AKS default nodepool sku_tier

Need to surface sku_tier - https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/kubernetes_cluster#sku_tier to allow users to switch from 'Free' tier to meet SLAs for deployments.

This feature was implemented in #269. Closing the issue.


CPU/CUNN version of NIN is not supported

Hi Sergey,
The CPU or Cunn version of NIN seems not working. The native SpacialAveragePooling layer does not support ceil() method yet. Simply remove :ceil() will result in 7x7 instead of 8x8 for each plane after the first averaging pooling layer and thus making the after layers broken.
Is there any quick way to fix this without changing the network design?  Using SpatialAveragePooling(2,2,2,2) can made the code work but is different from the original network. I am running experiment to see its performance.

Thanks for reporting, I am aware of this. Adding ceil mode to SpatialAveragePooling is on our list, meanwhile your fix should work fine.

Thanks, Sergey! I see similar issues reported elsewhere.


Improve compiling in Docker container

Here is a simpler setup to compile and run the ippsample in a Docker container.

Renamed ippsample.docker to Dockerfile to avoid -f option during build.
Removed MAINTAINER instruction in Dockerfile as this keyword is deprecated.
COPY the local sources into the Docker image to be able to compile local changes in the container.
Added an entrypoint to start dbus and avahi-daemon
Splitted the ./configure and make ; make install into two RUN instruction to use Docker build cache
Updated DOCKER.md to show how to directly run the ippsample binaries (eg. changing into the examples folder)

With the latest commit I also have added a docker-compose.yml which makes it easy to run the IPP server with the configuration given in the test folder and a specific hostname.
Run the IPP server (it will also build or update the Docker image):
$ docker-compose up ippserver

In another terminal run eg. the IPP find tool
$ docker-compose up ippfind
ippsample_ippserver_1 is up-to-date
Creating ippsample_ippfind_1 ...
Creating ippsample_ippfind_1 ... done
Attaching to ippsample_ippfind_1
ippfind_1    |  * Starting system message bus dbus
ippfind_1    |    ...done.
ippfind_1    |  * Starting Avahi mDNS/DNS-SD Daemon avahi-daemon
ippfind_1    |    ...done.
ippfind_1    | ipp://ippserver.local:8991/ipp/print/ipp-everywhere-pdf
ippfind_1    | ipp://ippserver.local:8991/ipp/print/bar
ippfind_1    | ipp://ippserver.local:8991/ipp/print/foo
ippfind_1    | ipp://ippserver.local:8991/ipp/print/ipp-everywhere-raster
ippsample_ippfind_1 exited with code 0

Or run the IPP Everywhere test:
$ docker-compose up ipptest

I have also added an example for the IPP Proxy in the docker-compose.yml to point back to the IPP server, just for an example:
  ippproxy:
    build:
      context: .
      dockerfile: Dockerfile
    command: ippproxy -d ipp://ippserver.local:8991/ipp/print/foo ipp://ippserver.local:8991/ipp/print/bar
    depends_on:
      - "ippserver"

But when I run docker-compose up ippproxy it only shows
$ docker-compose up ippproxy
ippsample_ippserver_1 is up-to-date
Creating ippsample_ippproxy_1 ...
Creating ippsample_ippproxy_1 ... done
Attaching to ippsample_ippproxy_1
ippproxy_1   |  * Starting system message bus dbus
ippproxy_1   |    ...done.
ippproxy_1   |  * Starting Avahi mDNS/DNS-SD Daemon avahi-daemon
ippproxy_1   |    ...done.
ippproxy_1   | ippproxy: UUID for 'ipp://ippserver.local:8991/ipp/print/foo' is 'urn:uuid:01000000-597f-3000-541e-6051597f000'.
ippproxy_1   | ippproxy: Infrastructure printer at 'ipp://ippserver.local:8991/ipp/print/bar' is not responding, retrying in 30 seconds...
ippproxy_1   | ippproxy: Infrastructure printer at 'ipp://ippserver.local:8991/ipp/print/bar' is not responding, retrying in 30 seconds...
ippproxy_1   | ippproxy: Infrastructure printer at 'ipp://ippserver.local:8991/ipp/print/bar' is not responding, retrying in 30 seconds...

What am I doing wrong? 😅

The proxy/infrastructure support is currently not completed, so it won't work out of the box. Working on it...

I also added the new dependencies listed in BUILD.md to the Dockerfile.


It doesn't work for the sidecar display with ipad

Before opening the issue, have you...?

[X] Searched for existing issues
[X] Read through the Monitor-Troubleshooting Wiki
[X] Updated MonitorControl to the latest version (if applicable)

Describe the issue
Hi Bro,
Does anyone has ever tried the monitorcontrol for the iPad sidecar display with mac book pro?
it doesn't work in this scenario, or maybe it doesn't support it well. when I tried in this way, it popup with an error message asking me to decide eighter to quit the blocking program or stop something with gamma which i don't understand.... but anyway, it just can not adjust the sidecar iPad brightness as it does with any other monitor else.
wish it can support the sidecar approach, thanks, guys !!

Best regards,
Jeff Yu
Expected behavior
hope it can support sidecar display brightness control
Anything else?
nothing else ~
Environment Information (please complete the following information)
- macOS version: 12.1
- Mac model: MBP 2019
- MonitorControl version: latestone
- Monitor(s): ipad
- Monitor Cable(s)/Connection(s): wifi/cable
- Apple Silicon/M1 (yes or no): No

Sidecar brightness change should work in software mode. Sidecar does not support gamma mode so there should not be a popup like that.

Hi Bros~
it does give an error message like what I mentioned above, I tried to replicate the same error by using another mac book pro, please see the message below:

Is there any workaround that I can do to make it works under the sidecar scenario, thanks, man!
Best regards,
Jeff

Sidecar control should work just fine. The message (I think - I can't read Chinese) is about some other app interfering with MonitorControl when trying to use gamma control - this method of control is not used with Sidecar. What happens if you just allow the app to disable gamma control?

I'll close this one for now due to inactivity. If there is any more info about this, please let me know!


iPhone X, 12.4, unc0ver 3.5.3 - reboots upon attempted jailbreak

Describe the bug
Thank you for the hard work! Issue: When attempting jailbreak, phone almost immediately reboots without executing jailbreak. Have attempted 10+ times. I've disabled Siri, enabled Airplane mode, and exited all apps each time before trying.
To Reproduce
Steps to reproduce the behavior:

Click to open  "unc0ver" app.
Click "jailbreak"
Phone reboots

Screenshots
If applicable, add screenshots to help explain your problem.
Device (please complete the following information):

iOS Version: 12.4
iOS Device: iPhone X
unc0ver Version: 3.5.3

Place an "x" between the brackets if true:

[x] this is a bug others will be able to reproduce
[ ] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[ ] this issue is present after a rootfs restore
[ ] this issue is present on the latest version of unc0ver

Logs
Taken from deviceconsole before reboot:
Aug 19 18:54:34 the-titanic Undecimus[231] : [] Current task: 0xffffffe005f8f840
Aug 19 18:54:34 the-titanic Undecimus[231] : [] Kernel's IPC space: 0xffffffe0003e6370
Aug 19 18:54:34 the-titanic Undecimus[231] : [] Pipe buffer 9: 0xffffffe03ebc0000
Aug 19 18:54:34 the-titanic Undecimus[231] : [] Pipe buffer 11: 0xffffffe00680b000
Aug 19 18:54:34 the-titanic Undecimus[231] : [] Dummy kernel task port: 0xffffffe0021db678
Aug 19 18:54:34 the-titanic Undecimus[231] : [] Port pointer overwritten
Aug 19 18:54:34 the-titanic Undecimus[231] : [] Stage 1 read64 succeeded
Aug 19 18:54:34 the-titanic Undecimus[231] : [] Kernel VM map: 0xfffffff11ab22320
Aug 19 18:54:34 the-titanic Undecimus[231] : [] Stable kernel task port 25607: 0xffffffe0021d9b90
Aug 19 18:54:34 the-titanic Undecimus[231] : [] Exploit succeeded, cleaning up
Aug 19 18:54:34 the-titanic Undecimus[231] : [] Cleanup done
Aug 19 18:54:34 the-titanic Undecimus[231] : [] tfp0: 0x6407
Aug 19 18:54:34 the-titanic Undecimus[231] : [] Successfully exploited kernel.
Aug 19 18:54:34 the-titanic Undecimus[231] : [] Finding kernel offsets...
Aug 19 18:54:34 the-titanic Undecimus[231] : [] Progress: Initializing jailbreak...
Aug 19 18:54:34 the-titanic Undecimus[231] : [] kCFCoreFoundationVersionNumber: 1575.170000
Aug 19 18:54:34 the-titanic Undecimus[231] : [] offsets selected for iOS 12.0 or above
Aug 19 18:54:34 the-titanic kernel(apfs)[0] : apfs_load_inode:4337: *** reset ino 36366695 size back to 0 (from 34525184)
Aug 19 18:54:34 the-titanic locationd[62] : {"msg":"CLWifi1SystemLogic::apply", "event":"elapsed", "begin_mach":3195686054, "end_mach":3195692919, "elapsed_s":"0.000286042", "event":"Motion::CoarseMovement", "now_s":"587958874.704206944"}
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Escaping sandbox...
Aug 19 18:54:35 the-titanic Undecimus[231] : [] myProcAddr = 0xffffffe0059f3790
Aug 19 18:54:35 the-titanic Undecimus[231] : [] kernelCredAddr = 0xffffffe0006b9dd0
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Shenanigans = 0xffffffe0006b9dd0
Aug 19 18:54:35 the-titanic Undecimus[231] : [] myOriginalCredAddr = 0xffffffe0006bab50
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Successfully escaped sandbox.
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Setting HSP#4 as TFP0...
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Successfully set HSP#4 as TFP0.
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Setting kernel task info...
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Successfully set kernel task info.
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Platformizing...
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Successfully initialized jailbreak.
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Successfully unexported kernel task port.
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Successfully wrote a test file to UserFS.
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Progress: Unexporting kernel task port...
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Successfully dumped APTicket.
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Progress: Writing a test file to UserFS...
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Progress: Dumping APTicket...
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Successfully logged slide.
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Progress: Logging slide...
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Progress: Logging ECID...
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Successfully logged ECID.
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Progress: Disabling Auto Updates...
Aug 19 18:54:35 the-titanic Undecimus[231] : [] modifyPlist: Will modify plist: /var/mobile/Library/Preferences/com.apple.Preferences.plist
Aug 19 18:54:35 the-titanic Undecimus[231] : [] modifyPlist: Writing to file: /var/mobile/Library/Preferences/com.apple.Preferences.plist
Aug 19 18:54:35 the-titanic Undecimus[231] : [] modifyPlist: Success
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Successfully disabled Auto Updates.
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Initializing kernel code execution...
Aug 19 18:54:35 the-titanic locationd[62] : {"msg":"CLWifi1SystemLogic::apply", "event":"elapsed", "begin_mach":3218676868, "end_mach":3218683684, "elapsed_s":"0.000284000", "event":"Motion::CoarseMovement", "now_s":"587958875.662150979"}
Aug 19 18:54:35 the-titanic Undecimus[231] : [] Successfully initialized kernel code execution.
Aug 19 18:54:35 the-titanic Undecimus[231] : [*] IODTNVRAM obj at 0xffffffe0004c8ec0

I am having the same issue with an iphone 8 plus, also running 12.4.

I am having the same issue with an iphone 6 running 12.4 and restarts at "8"

fearlesspixel try unc0ver 3.5.2 it worked for me iphone 6 12,4

I am having the issue with an iphone 6s running 12.4 and restarts at "2"

unc0ver 3.5.2 worked! Thank you!

unc0ver 3.5.2 worked! Thank you!

I'm having the same issue, but also version 3.5.2 is not working. It will reboot after a few seconds. It's an iPhone 7 with 12.4

I'm having the same issue, but also version 3.5.2 is not working. It will reboot after a few seconds. It's an iPhone 7 with 12.4

Ahhh it worked now. It helped to active the option "Reinstall Cydia" and disable "Reload Daemons"

not worked:
unc0ver: 3.5.3
iphone 5s
update to 12.4 via OTA from 12.3
tested on unc0ver 3.5.2 not worked too
phone restarted during jailbreaking around 8/31 process or sometimes hang on 1/31

@msairul Try to enable "Reinstall Cydia" and disable "Reload Daemon" in the options menu. This worked for me.

thanks for sharing. unfortunately didn't work for me.
unc0ver: 3.5.2
iPad Pro 9,7" 2016 (A9X)
IPSW-Update to 12.4


Build fails for iOS (RN 0.60.3) with an App extension

Building the app results in an error in RCTRedBox.m
'sharedApplication' is unavailable: not available on iOS (App Extension) - Use view controller based solutions where appropriate instead.
Since RN 0.60.3 we moved to a newer RedBox error which uses sharedApplication. This is not allowed in an App extension for iOS. Everything builds fine for Android. This is the only thing blocking us from pushing 0.60.3 to production. Any suggestions would be appreciated. Thanks!
React Native version:

System:
OS: macOS 10.14.5
CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Memory: 26.13 MB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 11.12.0 - /usr/local/bin/node
Yarn: 1.15.2 - /usr/local/bin/yarn
npm: 6.7.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
Android SDK:
API Levels: 23, 25, 26, 27, 28
Build Tools: 23.0.1, 25.0.1, 25.0.2, 26.0.3, 27.0.3, 28.0.2, 28.0.3
System Images: android-23 | Intel x86 Atom_64, android-23 | Google APIs Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-Q | Google APIs Intel x86 Atom
IDEs:
Android Studio: 3.4 AI-183.54<IP_ADDRESS>52501
Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.6 => 16.8.6
react-native: 0.60.3 => 0.60.3
npmGlobalPackages:
react-native-asset: 1.1.2
react-native-cli: 2.0.1
react-native-create-library: 3.1.2
react-native-git-upgrade: 0.2.7
Steps To Reproduce

Create an iOS project with an app extension (share extension)
Try building the project

Describe what you expected to happen:
Build successfully
Snack, code example, screenshot, or link to a repository:

@deorukhkarchaitanya Thanks for the catch, will fixed in #25769 .

I'm having a similar issue in App extension as well after upgrading to 0.60.4, will your PR fix that as well? if not, do you know how can it be fixed?

It works with this:
facebook/react-native#25792 (comment)


Would be great if bignumber.js have a "convert integer to bytes method"

I think would be very helpful if bignumber.js have a toBytesLE() and toBytesBE() method just like long and jsbn modules. I'm not talking about buffers, maybe just Uint8Array or maybe just a simple array of numbers to represent a Uint8Array instance. If not possible, a good example of how to do it using bignumber.js would be great as well

Those libraries are integers only - how do you think a number such as 123.456 should be represented as an array of bytes?
It could be done, but what is the goal, what is the use-case?

Hi there,
I am on the same request. It is necessary for saving BigNumber into file, and then read it later
Thank you

Same here @VictorQueiroz .This would be very useful when hashing bigNum (SHA-256). Commonly done on the blockchain

@alvaro-alonso
I did some work on this but it is incomplete and I haven't time to work on it at the moment.
I haven't used it but try this.


Incorrect classification - Ice

http://thronesdb.com/card/01153
This card is marked as a character when it should be an attachment

Fixed, thanks.


Draft: First setup of a sphinx based documentation coupled with ReadTheDocs

Why
Except of an rst file, documentation is missing. Not only the content but the structure as well.
What
This merge request concerns the structure, i.e. a common sphinx based documentation that is hoped to allow people to focus on writing the content in an easy and familiar manner.

change from RST to MyST, easier to use, more similar to markdown
examples are provided for commonly used documentation components (feel free to edit and/or even remove them)

automatic code documentation: api.md (a few examples are provided)
installation instructions: installation.md
references: references.md and references.bib, LaTeX like citation system
code examples and gallery: examples\

coupling with ReadTheDocs is set up but could not be completed because I do not have sufficient rights to the repo; @aklawonn I think you will need to set this up in ReadTheDocs.

Testing

locally
ReadTheDocs: to be done by someone with the right permissions

Other

probeye version number is added to init.py to store it only at one place (needed in setup.cfg and sphinx as well), only need to change it at one place

I made a fork of this repo to be able to test the coupling with ReadTheDocs. The build fails with the following error:
Unexpected failing examples:
/home/docs/checkouts/readthedocs.org/user_builds/probeye/checkouts/latest/docs/examples/plot_linear_regression.py failed leaving traceback:
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/probeye/checkouts/latest/docs/examples/plot_linear_regression.py", line 83, in <module>
    problem = InferenceProblem("Linear regression with normal noise")
  File "/home/docs/checkouts/readthedocs.org/user_builds/probeye/envs/latest/lib/python3.8/site-packages/probeye/definition/inference_problem.py", line 84, in __init__
    print_probeye_header()
  File "/home/docs/checkouts/readthedocs.org/user_builds/probeye/envs/latest/lib/python3.8/site-packages/probeye/subroutines.py", line 579, in print_probeye_header
    with open(header_file, 'r') as f:
FileNotFoundError: [Errno 2] No such file or directory: '/home/docs/checkouts/readthedocs.org/user_builds/probeye/envs/latest/lib/python3.8/site-packages/probeye/probeye.txt'

This seems to be an error with the logging and unrelated to the documentation.

Thanks a lot, Arpad, for setting this up! This is a big help. I have no experience with ReadTheDocs stuff, so I just changed your rights to maintain. Maybe that's already sufficient. On the error you encountered: that's weird - it seems like this probeye.txt file was not included into the build. I don't know why. Maybe it's because it's not a python-script. I don't know. If this problem also occurs for the non-forked repository, I might have to convert the txt-file into some py-file, or copy the content directly into the script that uses it (this probeye.txt file just contains the probeye name in some ascii-art font which is used at the beginning of the logging).

Thanks for the maintain rights. Unfortunately, I get the same error when I directly connect ReadTheDocs with this repo instead of using the fork. I also do not understand why the txt file is missing. I will try out a few things with the fork (to avoid littering this repo).

I can confirm that the issue is solely caused by the attempt to read probeye.txt. When I comment out that part of the code the documentation is built: https://probeye.readthedocs.io/en/latest/ (this built from my fork).

Great! The documentation page looks good! And I will take care of that txt-file, and simply include it in the code. I'll push that modification to this branch then.

I hope it was okay to merge your last draft into this one, Arpad. Also, you now have admin access, so there shouldn't be a rights hurdle anymore with setting up ReadTheDocs.

I had to run
pip3 install --user ".[docs]"

with quotes, but that is probably related to my shell
I was unable to run it with the "-e" editable option. Probably also a mistake on my side or do others have the same?

Anyways, cd docs && make html works nicely.

I hope it was okay to merge your last draft into this one, Arpad. Also, you now have admin access, so there shouldn't be a rights hurdle anymore with setting up ReadTheDocs.

Sure, it is fine. I marked it as a draft because I wanted to wait until the build succeeds. It passed. The connection to ReadTheDocs is there: https://probeye.readthedocs.io/en/fix_probeye_txt/ (you can switch between branches at the bottom left, we do not build a documentation from all branches  but new branches can be added if needed).
ReadTheDocs complains about some webhooks (the build is not yet triggered automatically). I still need to figure this out (with my other repos it worked without the need to manually set this up). I will probably do some experimentation in the pull request.

Probably also a mistake on my side or do others have the same?

I tested on Windows. In the installation section of the documentation we could have one tab for Windows and another for Linux.

If one of you have a ReadTheDocs account, I could add you to the probeye project so you could also manage the builds.

The ReadTheDocs-GitHub webhooks are set. The documentation is automatically rebuilt and published upon each commit. Please check if something is missing from the documentation structure, otherwise, in my opinion it can be merged.

Thanks Arpad! Looks really good to me. Btw, I just made a ReadTheDocs account with the user name aklawonn. If you could add me to probeye, that would be great.


Run tests in a conda environment for the histopathology workflow.

Run histopathology test in a conda virtual environment instead of installing packages with pip.

Duplicate of #479


1.4.x not showing notification on Android

Sending the exact same payload. 1.3 works fine, 1.4 just call the .on('notification, fn) with all keys in additionalData

so after changing body to message I get
{
    "image": "urltopicture.jpg",
    "message": "test",
    "additionalData": {
        "summaryText": "There are %n% new notifications",
        "gcm.notification.notId": "121",
        "gcm.notification.title": "Title 1",
        "id": "121",
        "tag": "121",
        "style": "inbox",
        "coldstart": false,
        "collapse_key": "org.company.app",
        "foreground": false
    }
}

The message should be body see https://developers.google.com/cloud-messaging/concept-options#notifications_and_data_messages
Also not sure why title and notId are not being properly parsed?

Shouldn't this break for more people? :O

@AdriVanHoudt can you send me an example of data you are sending to GCM. That will really help me debugging this.

Also @AdriVanHoudt do you see different results if the app is closed vs forground vs background
@macdonst I suspect this is caused by the GcmListenerService code. I think that it displays the notification if there is a gcm.notification.title or gcm.notification.body key in the message. I wonder if it is bypassing our normlize in those cases?

@smdvdsn I see nothing, only difference is that when in foreground it immediately handles the message and otherwise it waits for the app to open
this is (roughly, I use a lib which accepts the registration ids as a different param) what I send to gcm:
{
    data: undefined,
    notification: {
        title: 'Title 1',
        body: 'test',
        image: 'http: //urltopicture.jpg',
        id: 121,
        tag: 121,
        style: 'inbox',
        summaryText: 'Thereare%n%newnotifications',
        notId: 121
    }
}

@AdriVanHoudt thanks, I can reproduce it now using node-gcm to send a push with your test data. Stay tuned.

Cool, I will, also debugging this myself (at least trying :D)

@AdriVanHoudt it's something weird when we iterate through the key set of the extras coming in from GCM. For some reason we skip a few.

jup managed to get this out of debugger:
D/PushPlugin_GCMIntentService(26109): onMessage - from:<PHONE_NUMBER>99
D/PushPlugin_GCMIntentService(26109): mormalize extras
D/PushPlugin_GCMIntentService(26109): key = gcm.notification.image
D/PushPlugin_GCMIntentService(26109): replace key gcm.notification.image with image
D/PushPlugin_GCMIntentService(26109): key = gcm.notification.style
D/PushPlugin_GCMIntentService(26109): replace key gcm.notification.style with style
D/PushPlugin_GCMIntentService(26109): key = gcm.notification.summaryText
D/PushPlugin_GCMIntentService(26109): replace key gcm.notification.summaryText with summaryText
D/PushPlugin_GCMIntentService(26109): key = image
D/PushPlugin_GCMIntentService(26109): key = style
D/PushPlugin_GCMIntentService(26109): key = gcm.notification.body
D/PushPlugin_GCMIntentService(26109): replace key gcm.notification.body with body
D/PushPlugin_GCMIntentService(26109): key = gcm.notification.tag
D/PushPlugin_GCMIntentService(26109): replace key gcm.notification.tag with tag
D/PushPlugin_GCMIntentService(26109): key = gcm.notification.id
D/PushPlugin_GCMIntentService(26109): replace key gcm.notification.id with id
D/PushPlugin_GCMIntentService(26109): key = collapse_key

@AdriVanHoudt @smdvdsn I'm pretty sure it is a concurrent modification problem. When the body property is replaced with message it screws up the iterator we are using. Testing a fix now.

@AdriVanHoudt @smdvdsn Yup, that was it. Can you test branch issue299. I'm getting on a plane for Europe in a couple of hours and would like to push a fix if possible but it would be good if someone else took a look at this as well.

on it

it is working now, big thank you @macdonst for fixing this so quickly, you doing a patch release now?

Yes, I will do a patch and release to NPM in the next 10 minutes. It didn't surface in my testing as I wasn't mixing data and notification.

@AdriVanHoudt published version 1.4.2

This should be in the readme or in a visible place... I've spent several hours until I found this fix...

How so? This fix is to make it working like it should/like in the readme

I mean, just adding a little section with notices for regressions and breaking changes in the readme (the first thing one reads when arrives to the repo) so newcomers don't spend 5 hours banging their heads against the wall before realising they have to install the plugin via git clone.

This fix was published as 1.4.1 so need to git clone, are you allowing pathes in your config.xml? I have it set at 1.4.x. It is possible you need to reinstall the plugin to get the right version

I've been using this plugin only since yesterday. First I installed the plugin via
cordova plugin add phonegap-plugin-push (stable)
and I wasn't receiving the notifications, then after finding this issue I finally installed with
cordova plugin add https://github.com/phonegap/phonegap-plugin-push (unstable)
and started working. I was just just suggesting to include a section with references to major breaking changes (like this one) in the readme of the repo, maybe pointing out to the corresponding issues...

hmm weird I have <plugin name="phonegap-plugin-push" spec="1.4.x" /> in my config.xml and that works fine. I personally see no point in listing issues in the readme, this is fixed if you still have a problem I would suggest opening another issue about the fix not working when installing via the cordova command line

@Telemakhos Yeah, I don't think we need to add it to the README as it is already fixed. Whenever I do a minor release I do a blog post with all the changes/fixes.
It's really odd that cordova plugin add phonegap-plugin-push did you get you the latest 1.4.2 release which includes the fix. Can you try again and do cordova plugin ls to see what version it installs?


STORM-828 HdfsBolt takes a lot of configuration, need good defaults

Removing configs from HDFSFileTopology example. I have made neccessary config and constructor changes as per my understanding. It will be nice to know if there is anything I need to look at.

@redsanket why we need CSVBolt and TSVBolt when there is DelimitedRecordFormat which users can configure

For futher clarification, I was further thinking over this issue and I presume currently the spout emits tuples in the form of fields and the csv or tsv bolt joins them with the specified record format delimiter. If it is a ",", all tuples will be appended by a comma. The HdfsBolt actually does this implementation when the execute is called upon it. The TSV or CSV are just abstractions to get the intended values based on the record delimiter. Can you please let me know what exactly has to be done with an example, I thought I got your point but right now I cannot clearly picture it. It will be great if you can get back with a reply. Thanks a lot.

ok that seems to be true, I will change that. Mostly it will be down to refactoring a piece of code, we might not have to make it more specific then. Thanks

@redsanket I am not sure why this patch needs to change all these files. Why can't we just add default values to the variables here https://github.com/apache/storm/blob/master/external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java#L53 similar to what we have in hive connector https://github.com/apache/storm/blob/master/external/storm-hive/src/main/java/org/apache/storm/hive/common/HiveOptions.java#L33

Yes I have made the changes, I will change my pull request soon

Sorry it took me so long to review this.  For the most part things look good.  I made a few comments on the HdfBolt that I would like to see reflected in the SequenceFileBolt too.  Also an upmerge would be good.
Thank you for being so patient with us.

@redsanket Are you still working on this?