Fix Rust example 'iter()' function

The iter() function in the Rust language example lib_guide.rs was failing (see below). This was caused by incorrect syntax for an iterator in the clause as outlined in the documentation: https://docs.osohq.com/rust/reference/polar/classes.html#iterators
Updating the clause to use the correct syntax seems to fix the issue (thanks @samscott89!)
➜  rust git:(main) ✗ RUST_BACKTRACE=1 cargo run --example lib_guide
    Finished dev [unoptimized + debuginfo] target(s) in 0.19s
     Running `/Users/joshrotenberg/GitHub/oso/target/debug/examples/lib_guide`
thread 'main' panicked at 'assertion failed: oso.is_allowed(user, \"foo\", \"bar\")?', languages/rust/oso/examples/lib_guide.rs:176:5
stack backtrace:
   0: rust_begin_unwind
             at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/panicking.rs:493:5
   1: core::panicking::panic_fmt
             at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/core/src/panicking.rs:92:14
   2: core::panicking::panic
             at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/core/src/panicking.rs:50:5
   3: lib_guide::iters
             at ./oso/examples/lib_guide.rs:176:5
   4: lib_guide::main
             at ./oso/examples/lib_guide.rs:185:5
   5: core::ops::function::FnOnce::call_once
             at /Users/joshrotenberg/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

PR checklist:

[ ] Added changelog entry.

I have read the CLA Document and I hereby sign the CLA

@samscott89
@joshrotenberg


read the docs started

Codecov Report

Merging #154 (5402e93) into main (de41bf3) will increase coverage by 0.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   77.32%   77.35%   +0.02%
==========================================
  Files          33       33
  Lines        3749     3749
==========================================
+ Hits         2899     2900       +1
+ Misses        850      849       -1

Files Changed
Coverage Δ

symmer/utils.py
71.52% <0.00%> (ø)

symmer/operators/base.py
64.41% <66.66%> (ø)

... and 1 file with indirect coverage changes


FW-392. Fixed.

Move timeCorrection IE into header.

@changtengfei, does this fix require #187 to be merged?

Yes, I would like to merge this request.


Tests fail on 1-core VM

Describe the bug, including details regarding any error messages, version, and platform.
While working on reproducible builds for openSUSE, I found that
our apache-arrow-12.0.1 package failed tests when run on a 1-core VM:
Here is an extract from the log:
 /home/abuild/rpmbuild/BUILD/arrow-apache-arrow-12.0.1/cpp/src/arrow/csv/reader_test.cc:190: Failure
 Expected equality of these values:
   -1
   row.number
     Which is: 961
 /home/abuild/rpmbuild/BUILD/arrow-apache-arrow-12.0.1/cpp/src/arrow/csv/reader_test.cc:190: Failure
 Expected equality of these values:
   -1
   row.number
     Which is: 981
 /home/abuild/rpmbuild/BUILD/arrow-apache-arrow-12.0.1/cpp/src/arrow/csv/reader_test.cc:190: Failure
 Expected equality of these values:
   -1
   row.number
     Which is: 1001
 [  FAILED  ] StreamingReaderTests.InvalidRowsSkippedAsync (2 ms)
 [ RUN      ] StreamingReaderTests.BytesRead
 [       OK ] StreamingReaderTests.BytesRead (0 ms)

 [==========] 253 tests from 44 test suites ran. (978 ms total)
 [  PASSED  ] 252 tests.
 [  FAILED  ] 1 test, listed below:
 [  FAILED  ] StreamingReaderTests.InvalidRowsSkippedAsync

  1 FAILED TEST
 ~/rpmbuild/BUILD/arrow-apache-arrow-12.0.1/cpp/build/src/arrow/csv

       Start 39: arrow-acero-plan-test
 39/78 Test #39: arrow-acero-plan-test ....................***Failed    1.78 sec
 Running arrow-acero-plan-test, redirecting output into /home/abuild/rpmbuild/BUILD/arrow-apache-arrow-12.0.1/cpp/build/build/test-logs/arrow-acero-plan-test.txt (attempt 1/1)
 Running main() from /home/abuild/rpmbuild/BUILD/googletest-release-1.12.1/googletest/src/gtest_main.cc

 [ RUN      ] ExecPlanExecution.SegmentedAggregationWithMultiThreading
 /home/abuild/rpmbuild/BUILD/arrow-apache-arrow-12.0.1/cpp/src/arrow/acero/plan_test.cc:1615: Failure
 Value of: _st.IsNotImplemented()
   Actual: false
 Expected: true
 Expected 'DeclarationToExecBatches(std::move(plan))' to fail with NotImplemented, but got Invalid: Group-by aggregation with field 'i32' as both key and segment key
 /home/abuild/rpmbuild/BUILD/arrow-apache-arrow-12.0.1/cpp/src/arrow/acero/plan_test.cc:1615: Failure
 Value of: _st.ToString()
 Expected: has substring "multi-threaded"
   Actual: "Invalid: Group-by aggregation with field 'i32' as both key and segment key"
 [  FAILED  ] ExecPlanExecution.SegmentedAggregationWithMultiThreading (0 ms)

 WARNING: Logging before InitGoogleLogging() is written to STDERR
 W20390831 20:38:32.254076 25012 source_node.cc:76] An input buffer was poorly aligned.  This could lead to crashes or poor performance on some hardware.  Please ensure that all Acero sources generate aligned buffers, or change the unaligned buffer handling configuration to silence this warning.
 [       OK ] ExecPlanExecution.UnalignedInput (0 ms)
 [----------] 50 tests from ExecPlanExecution (1584 ms total)

 [----------] Global test environment tear-down
 [==========] 60 tests from 4 test suites ran. (1716 ms total)
 [  PASSED  ] 59 tests.
 [  FAILED  ] 1 test, listed below:
 [  FAILED  ] ExecPlanExecution.SegmentedAggregationWithMultiThreading

  1 FAILED TEST
 ~/rpmbuild/BUILD/arrow-apache-arrow-12.0.1/cpp/build/src/arrow/acero

Steps to reproduce on Debian or openSUSE:
osc co openSUSE:Factory/apache-arrow && cd $_
osc build --vm-type=kvm --noservice -j1 standard

Component(s)
C++, Other

cc @westonpace

It seems OMP_THREAD_LIMIT=1 taskset -c 0 <test command> should be enough to reproduce locally without relying on the OpenSUSE build infrastructure.

Also @bmwiedemann could you give a link to the full test logs?

full build+test log

Ok, so these are the same errors that can be reproduced locally as described above.

Both tests assume a multi-threaded environment without checking the actual threading capacity. Given that they intend to check the behavior of multi-threaded execution, I think they should be skipped if there is only one thread available:
if (internal::GetCpuThreadPool()->GetCapacity() < 2) {
  GTEST_SKIP() << "Test requires at least 2 threads";
}

The above patch works on my machine. Should I submit a PR for this? @pitrou

In principle you can run multiple threads on a single CPU through the kernel scheduling one part after another. But that might already be covered in a different test, then skipping should be fine.


Adjust button layout to match Nintendo's layout

As discussed in #3, I made changes to how inputs from controllers are handled. They now match Nintendo's layout as described in 632d957. Also, the NintedoControllerService.java was removed as it is (according to my testing) not needed anymore and the inversion of the y-axis in ButtonService.java was also removed for the same reason.

LGTM!


Native Token Bridging Support

In reference to this issue
https://github.com/0xPolygon/core-contracts/issues/299
Tests are coming

wouldn't it make more sense to wrap native tokens into WETH and bridge WETH over? WETH could be mapped to the native token on child. Because otherwise there would be potentially three types of ETH on child, the native token, WETH that was bridged over from root and WETH that was wrapped on child.

This requires users to do an extra transaction for wrapping
I mean it would look something like this:

function depositNativeTo(address receiver) external payable {
  weth.deposit(msg.value);
  // todo: deposit and bridge WETH
}

There wouldn't be any additional user action required for wrapping, as this would be handled by the function automatically. Same for unwrapping when a user wants to withdraw WETH as the native token

@gretzke
I poc'd that approach but two problems come up:
You have to do specialised handling here for WETH to make sure you don't try to transferFrom if the token is weth:
https://github.com/0xPolygon/core-contracts/blob/47c733efd2eec232ab25ae55d6f126aa9dd7208b/contracts/root/RootERC20Predicate.sol#L120
This is manageable
During withdrawals, you also can't tell whether a user wants WETH or ETH on the rootchain (without changing the childchain contract)

You have to do specialised handling here for WETH to make sure you don't try to transferFrom if the token is weth

Not necessarily, because the native ETH and WETH transfer look identical to the bridge (a normal ERC20 deposit), it shouldn't matter if a user uses native ETH or WETH to bridge. It works the same.

During withdrawals, you also can't tell whether a user wants WETH or ETH on the rootchain

That is true, in that case a user would always receive back WETH. But also requires only 1 additional transaction without approvals to unwrap

@gretzke

Not necessarily, because the native ETH and WETH transfer look identical to the bridge (a normal ERC20 deposit), it shouldn't matter if a user uses native ETH or WETH to bridge. It works the same.

More specifically, the _deposit function at the moment does a transferFrom``msg.sender. However, for WETH, by this point the owner of the WETH is already the bridge contract (since the bridge became the owner of the ETH when msg.value was passed and attempting to do transferFrom again from the msg.sender, which is the end user, wouldn't make sense

Instead of calling the _deposit function the functionality of that function could be replicated while omitting the transferFrom

reasonable @gretzke
Could you confirm having both ETH and WETH map to the same token on the child-chain is MUST have requirement for you? If so, my team will have to align on the UX impact of that with withdrawals.

I would have to align with my team as well, it just seems like a more efficient solution to me personally.

I would have to align with my team as well, it just seems like a more efficient solution to me personally.

Yea I can understand you're perspective. Tradeoff is "Unified ETH and WETH on chilchain" vs "Extra step unwrapping during withdrawals"
From our perspective, UX is our highest priority and we found that most people get confused as to why they need to 'wrap' or why they have WETH instead of ETH etc. We are only planning to asking users to deposit 'ETH' from our User interfaces to avoid the WETH confusion.
Regardless, let me know what you land on after aligning with your team. Appreciate the discussion @gretzke

I think either way there are compromises in UX. If there are both, ETH and WETH on the child chain users might get confused why they aren't able to exchange bridged ETH for bridged WETH for example. It might lead to one of the tokens being primarily used for applications resulting in the liquidity of the other tokens to dry up. Or as I previously mentioned, if native ETH becomes the native token on child, this might result in three types of ETH, the bridged native ETH, bridged WETH and wrapped native bridged ETH.
So yeah, we'll discuss and come back to you.

Just a thought, account abstraction might easily solve the withdrawal UX in the future through multicalls

So after aligning with the team we would prefer to go with my suggested solution

So after aligning with the team we would prefer to go with my suggested solution

Thanks, will close the PR then


Switch back to golangci

This switches rancher back to golangci and runs the same linters we were running before. It also adds a change to stop printing the rancher logs after the tests run if the tests do not fail. This saves ~6 min in build time.

https://github.com/rancher/rancher/issues/18638

LGTM


Please add support to sentencepiece

sentencepiece : https://github.com/google/sentencepiece

Added by this PR https://github.com/microsoft/vcpkg/pull/6533


iOS app crashes at start on iOS 12 (iPhone 6)

Summary
iOS app crashes at start on iOS 12 (iPhone 6)
Environment Information

Device Name: iPhone 6
OS Version: 12.5.7
Mattermost App Version: 2.15.0
Mattermost Server Version: not pertinent

Steps to reproduce
Update the application to 2.15.0 on an iPhone 6 running iOS 12.
Expected behavior
The app should open as expected.
Observed behavior (that appears unintentional)
Apps open then closes without any possible interaction. No error messages whatsoever.
Possible fixes
Mattermost is still declared compatible with iPhone 5s and up, iOS >= 12. The issue might come from the SDK update? If there is a compatibility change and no more support for iOS 12 is planned, and given that downgrade is not possible on iOS, the previous compatible version should be republished with a new version number to allow users to "upgrade" to it and keep working, before proceeding with republishing the new version but after correcting the iOS version compatibility.

@hb9tst Are you using the official app or the Beta app?

It's the official one. Not even sure how to install the beta...

Just updated to 2.16.0. Still crashing at startup on iPhone 6.

We haven't determined the root cause for this issue so far.
Related to this, we are updating our minimum iOS version to v13.4+ in the next release (v2.17.0 June) as part of this PR https://github.com/mattermost/mattermost-mobile/pull/7863, but it shouldn't affect v2.15 or v2.6 releases.

Ok thanks for your comment -- I hope that a working version on iIOS12 will still be published as it's not possible to downgrade the app to a working version...

iOS 12 went out of support a year ago https://endoflife.date/ios. Would you be able to share more details on the preference to use iOS 12?

It may be related to this
<EMAIL_ADDRESS>


Support memory mapped files on Windows

Currently we just disable memory mapped files on Windows.  With larger files this can be a bit hard on RAM (and likely a bit slower since I/O can't be done in parallel with processing).  Windows has an API for memory mapped files; we should use it.

Hey is anyone working on this issue and Is this project is still active cuz the previous edit is six years old


Build: ensure tag isn't accidentally overwritten

Going to close this and automate the docker push with GH Actions.

@stefanprodan sounds good, I had totally forgotten about this dangling PR.


Updated Tracker Icons

Added SlimeVR-specific tracker icons to be used and removed old icons which were unused.
I'm unfamiliar with where exactly the icons are being loaded from currently, so although I changed the paths for the tracker icons, I believe "placeholder_tracker_status.png" will still be loaded.

Why some of the files have suffix b4bfb144?
I was following in the convention of icon naming as others use. The b4bfb144 portion designates that it's in the standard SteamVR blue-green gradient, whereas those without are pea green, with the exception of "tracker_status_off.png", which is a dark gray.

I'm unfamiliar with where exactly the icons are being loaded from currently, so although I changed the paths for the tracker icons, I believe "placeholder_tracker_status.png" will still be loaded.

we should check this and fix it, otherwise this PR does nothing and can't be accepted. at the very least we need to create a separate issue to fix it. i love the icons and i want them 🥺

Just tested the driver build from CI, it looks like it works fine to me :3

Also just noticed that we're actually missing the icon for "Not Detected" (when a tracker position is disabled in SlimeVR)
Here I disabled feet, you can see what the result is:


max_tokens must be at least 1, got -160

Your current environment
The output of `python collect_env.py`

How you are installing vllm
pip install -vvv vllm

Please provide more information regarding your problem, including your current environment and installation (read the instructions), and also how you ran vLLM.

Closing as stale. It may be reopened if you provide more information.


[youtube] «video doesn't have subtitles»

Trying to grab the automatically generated subtitles yields nothing.
youtube-dl --write-srt --write-auto-sub "https://www.youtube.com/watch?v=yCoRzJY_ejw"
[...]
[debug] youtube-dl version 2015.12.06
[debug] Python version 2.7.10+ - Linux-4.2.0-1-amd64-x86_64-with-debian-stretch-sid
[debug] exe versions: avconv 2.8.3-1, avprobe 2.8.3-1, ffmpeg 2.8.3-1, ffprobe 2.8.3-1, rtmpdump 2.4
[...]
WARNING: video doesn't have subtitles
[...]

It only has automatic subtitles but you also request the normal subtitles, that's why it shows the warning. Therefore it only downloads automatic subtitles.


Old Content

This content is out of date with current library implementation. Please update this documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8dd3492a-d52b-d231-d647-cb73328c9df1
Version Independent ID: e5d3d05f-1c8c-22f4-288d-6642288dbd4e
Content: How to use Azure Service Bus topics with Java
Content Source: articles/service-bus-messaging/service-bus-java-how-to-use-topics-subscriptions.md
Service: service-bus-messaging
GitHub Login: @spelluru
Microsoft Alias: spelluru

@droidkfx Thanks for the feedback! We are currently investigating and will update you shortly.

@axisc
Hi Ashish - please look into it when you get a chance. Thanks.


Add support for ORTModelForVision2Seq

Feature request
I would like to use VisionEncoderDecoderModel (such as Donut or TrOCR) for vision2seq-lm tasks.
Motivation
I use HuggingFace's TrOCR for an vision2seq-lm task and would love to improve my inference speeds. ONNX conversion of such model is already supported by executing
python -m transformers.onnx --model="microsoft/trocr-base-printed" --feature=vision2seq-lm trocr_onnx/ --atol 1e-3

I hope to leverage onnx support for ORTModelForVision2Seq.
Example usage:
from transformers import TrOCRProcessor
from optimum.onnxruntime.modeling_vision2seq import ORTModelForVision2Seq

processor = TrOCRProcessor.from_pretrained('microsoft/trocr-base-printed')
onnx_model = ORTModelForVision2Seq.from_pretrained(
    "microsoft/trocr-base-printed",
    from_transformers=True,
    use_cache=True,
)
pixel_values = processor(images=image, return_tensors="pt").pixel_values
generated_ids = onnx_model.generate(pixel_values)
generated_text = processor.batch_decode(generated_ids, skip_special_tokens=True)[0]

Your contribution
Please let me know what needs to be done to add this support!

Hi @entropy2333 !
Thanks for bringing the request, we are definitely interested in adding ONNX Runtime support for vision encoder-decoder models.  Gently pinging @mht-sharma for some inputs.

Hi @entropy2333 , thank you for your interest in contributing ORTModelForVision2Seq class in optimum. Currently we are in process of doing some refactor in optimum which will change how the existing integration of ORTModel works.
Would suggest to wait for that update before integrating the above class.

Hi,
Are there any updates on this feature request?
Thanks!

Hi @arj7192  the PR for ORTModelForVision2Seq is merged here https://github.com/huggingface/optimum/pull/742

May I ask why Donut model could not supported still, as mentioned in the PR

Thanks @mht-sharma! May I ask why Donut model could not supported still, as mentioned in the PR

Thanks a lot @mht-sharma  I've been working with Donut model, have succeeded up-to now to convert to onnx model. but curretnly stuck with making the inference part work with the onnx model. any ideas how to proceed ? thanks.


Where are ServiceWorker data stored?

Hey,
I'm playing with ServiceWorker api for quite a while, but cannot figure out, where are the cached files stored on my hard drive and if they're accessible from outside of browser context. Any tips highly appreciated! Here's also a link to SO, if you'd like to earn some points :) http://stackoverflow.com/questions/36597140/where-are-serviceworker-data-stored
Cheers, Wojtek

This is completely dependent on the browser implementation and may change over time.  In Firefox it's something like:
/storage/default//cache
You really should not touch these files externally, though.  All bets are off on the browser working if you do. (Please don't.)

That path was supposed to be:
[Profile dir]/storage/default/[origin]/cache

hi @wanderview thanks for your answer. I'm just curious if that files are stored in clear text, so if they are readable outside of browser.

They're not really in plaintext.  Various files are in sqlite or compressed format.  We don't normally encrypt profile data, though.  If an attacker has access to the file system then all bets are off.  They can modify the firefox executable itself.
Again, the format of these files may change at any time.


Switch to eslint

I think it's time to start exploring some other/newer tools.  ESLint seems like it's quite usable now, so we should at least try it.

jscs seems to be gaining traction as well.
https://www.npmjs.com/package/jscs

Interesting, thanks for the link.  It looks like they could be complimentary: eslint for warnings/errors and jscs for code style?

Yes, though there is some overlap in functionality.

Closing, since we switched a while ago to eslint.


nano-wallet: 15.2 -> 16.0

Motivation for this change
Upgrade Nano cryptocurrency wallet.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval

@GrahamcOfBorg build nano-wallet

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: nano-wallet
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on aarch64-linux (full log)
Attempted: nano-wallet
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7bwg02x215p6f335sq0x8prbj6vg6048-nano-wallet-16.0
shrinking /nix/store/7bwg02x215p6f335sq0x8prbj6vg6048-nano-wallet-16.0/bin/rai_node
shrinking /nix/store/7bwg02x215p6f335sq0x8prbj6vg6048-nano-wallet-16.0/bin/nano_wallet
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7bwg02x215p6f335sq0x8prbj6vg6048-nano-wallet-16.0/lib  /nix/store/7bwg02x215p6f335sq0x8prbj6vg6048-nano-wallet-16.0/bin
patching script interpreter paths in /nix/store/7bwg02x215p6f335sq0x8prbj6vg6048-nano-wallet-16.0
checking for references to /build in /nix/store/7bwg02x215p6f335sq0x8prbj6vg6048-nano-wallet-16.0...
postPatchMkspecs
/nix/store/7bwg02x215p6f335sq0x8prbj6vg6048-nano-wallet-16.0


Can make run the README.md's example

Hello!
I want to use this package.I have started following the guide's example (https://github.com/nflaig/loopback4-migration#example). but nothing happens when I type npm run migrate or npm start.
My package.json is on version 1.0.0. v14.5.0 node version. Updated loopback4.
Those are the changes I made:

Create the migration inside src/migrations with 1.0.1.migration.ts name.

import {repository} from "@loopback/repository";
import {MigrationScript, migrationScript} from "loopback4-migration";
import {UserRepository} from "../repositories";

@migrationScript()
export class AddUserFullName implements MigrationScript {
  version = "1.0.1";
  scriptName = AddUserFullName.name;
  description = "add full name to users by combining first and last name";

  constructor(
    @repository(UserRepository)
    private userRepository: UserRepository
  ) { }

  async up(): Promise<void> {
    console.log("migrating")
    // retrieve all users without fullName property
    const users = await this.userRepository.find({where: {fullName: {exists: false}}});

    // add fullName property to each user
    const updateUsers = users.map(user =>
      this.userRepository.updateById(user.id, {
        fullName: `${user.firstName} ${user.lastName}`
      })
    );

    await Promise.all(updateUsers);
  }

  async down(): Promise<void> {
    console.log("migrating end")
    // remove fullName property from all users
    await this.userRepository.updateAll(<any>{
      $unset: {fullName: 0}
    });
  }
}

I add those line in src/application.ts:

import {MongoDataSource} from "./datasources";
import {MigrationBindings} from "loopback4-migration";
import {AddUserFullName} from "./migrations";
...
export class BtcExplorerApplication extends BootMixin(
  ServiceMixin(RepositoryMixin(RestApplication)),
) {
...
   this.bind(MigrationBindings.CONFIG).to({
      appVersion: "1.0.0",
      dataSourceName: MongoDataSource.dataSourceName,
      modelName: "User",
      migrationScripts: [AddUserFullName]
    });

When I type npm run migrate or npm run start, not "migrating" not "migrating end" is printed
in the console and User collection has not a new "fullName" on any of their documents.

¿What I'm doing wrong? Thanks! :)

Hi @aitorjs 👋
based on the code snippets you provided it looks like you forgot to bind the component in application.ts. Also the migration scripts will run when the application starts not when you run npm run migrate. You can check in the database if a migration record was created if it already exists for 1.0.1.migration.ts the script won't be executed.
One other thing is the config you are setting in application.ts:

appVersion: "1.0.0" should not be required to set manually if you maintain the version in package.json as the app version will be automatically discovered
dataSourceName: MongoDataSource.dataSourceName if you only have one data source this can also be omitted
modelName: "User" the module creates migration records in the database to keep track of applied migrations and this is the model name that should be used for the collection in mongodb, the default is Migration
migrationScripts: [AddUserFullName] since you follow the naming convention the migration script will be automatically discovered

I hope that helps, let me know if you are facing any further issues

Hello @nflaig !
Thanks for the fast reply! :)

I add this line: this.component(MigrationComponent); inside src/application.ts  before this line: this.projectRoot = __dirname;. I have deleted:

this.bind(MigrationBindings.CONFIG).to({
  appVersion: "1.0.0",
  dataSourceName: MongoDataSource.dataSourceName,
  modelName: "user",
  migrationScripts: [AddUserFullName]
});

I type npm start.

I see a console.log I put inside 1.0.1.migration.ts but no new "Migration" collection in mongodb.

¿Could be the versioning the problem? 1.0.0 on package.json. Migration version on 1.0.1. I would say no. ¿Any idea?
Thanks! :)

@aitorjs your migration script should not have a higher version then the application itself, so if you app is on version 1.0.0 only scripts lower or equal that version will be executed.

I see a console.log I put inside 1.0.1.migration.ts but no new "Migration" collection in mongodb.

does your app have multiple data sources?

I have change migration script version to 0.9.0 and the migration script name to 0.9.0.migration.ts and I see the "migrating" console.log inside up(). :)
Two more little questions, please:

¿When down() is called?
I have 5 documents inside User collection. No one has fullName in it. ¿Why await this.userRepository.find({where: {fullName: {exists: false}}}) gets an empty array?

Thanks for all! :D

I have change migration script version to 0.9.0
Ideally you want to use the version of the app when the scripts needs to run, lets say you add new feature which requires to updat the data in the database. You would then increase your app version to 1.1.0 and the script would also have version 1.1.0

¿When down() is called?

Whenever your db version is higher then your app version which happens if you run migration for 1.1.0 for example and then you downgrade your app back to 1.0.0. The down method should always revert the changes done by the up method. In some cases downgrading might not be possible, it really depends on the changes you are doing in the up method. Most of the time it should not be required to implement the down method.

I have 5 documents inside User collection. No one has fullName in it. ¿Why await this.userRepository.find({where: {fullName: {exists: false}}}) gets an empty array?

Based on the code it should give you the 5 users without a fullName property. Maybe in your case the property does exist but is null? Hard to tell what the issue, I would need further information for that

Ideally you want to use the version of the app when the scripts needs to run, lets say you add new feature which requires to
updat the data in the database. You would then increase your app version to 1.1.0 and the script would also have version 1.1.0

This is what I do :)

Whenever your db version is higher then your app version which happens if you run migration for 1.1.0 for example and then >> you downgrade your app back to 1.0.0. The down method should always revert the changes done by the up method. In some >> cases downgrading might not be possible, it really depends on the changes you are doing in the up method. Most of the time it >> should not be required to implement the down method.

OK.

Based on the code it should give you the 5 users without a fullName property. Maybe in your case the property does exist but >> is null? Hard to tell what the issue, I would need further information for that

With null, the same result. Dont worry! :)
I would like to read the code and understand how the component was made.
Thanks for all


Not getting same/similar results by using your code & database at Frame Prediction Visualizations section

I was training the same database with author'scode but I'm not having the same or similar results at Frame Prediction Visualizations
section from https://keras.io/examples/vision/conv_lstm/ Seems that the images are getting a gray background, I'd love to see if you could support me by mentioning me if I failed in a certain part of implementing author's code :)
Here's my colab : https://colab.research.google.com/drive/1S8JN9WBwAFaSuuPd28X8697EoYHWHGfN?usp=sharing
Thanks for your efforts and all in advance :)

Closing it as duplicate of https://github.com/keras-team/keras-io/issues/732


I shouldn't be asked for a LUIS region before I opt-in to LUIS when creating publish profile

Describe the bug
I shouldn't be asked for a LUIS region before I opt-in to LUIS when creating publish profile.  Right now the regions selection phase is before the services selection phase
Version
Version:  1.4.0-nightly.230964.e5e5020
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0
Browser

[X] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[X] Windows
[ ] Ubuntu

To Reproduce

Create a bot
Create a publish profile
In step 1 start choosing regions
Uncheck LUIS in the next UI

Expected behavior
I shouldn't be asked about the LUIS region before I choose to include it
Screenshots

Additional context

@JaskeeratBedi-cmk , could you please help take a look at this?

Thanks. I will take a look and see if this issue will be resolved in the updated designs for provisioning.


How is this different to grunt.config.merge?

Am I missing something or does grunt.config.merge do the same thing?
http://gruntjs.com/api/grunt.config#grunt.config.merge

grunt.config.merge was introduced in Grunt 0.4.5 while grunt-extend-config exists since a longer time. AFAIK grunt.config.merge() does the same now, yes.


Issue: missing meta file.

First of all,
Thanks :))))
I have a little problem.
When I downloaded the pre-train model file I can't found the hourglass_bn_100.meta file,
So how can I restore the model ?
Thanks a lot :)

The meta file is too big. You do not need it to restore the model, check the predictClass.py file. By running it with the good config.cfg file you will be able to restore the pretrained model.
Next commit should be available on September, Friday 8th


Add a better tooltip for trend charts

LGTM, just the string change and I think this is good to go


Cleanup rule 1100 removes base

Copied from https://youtrack.jetbrains.com/issue/RSPL-6925
When applying code clean up with rule 1100 ticked, in some instances "base" is changed to "this" incorrectly.
We have a class which inherits from List and a new Add(T item) method
We have the last line calling base.Add(T item) which is changed to this.Add(T item)
This causes (caused !!!) us an infinite loop (unit tests missing........)
public class ThingList : List<T>
{
    public void Add(T item)
    {
        ... custom code

        base.Add(item);
    }
}

StyleCop plugin is checking for new or override. I already changed this to compare the called member against the members of the declaring type.


purldb scan worker: have worker thread send scan results back to purldb

When using the purldb scan worker command, the main worker loop gets the next job from purldb and creates a scan project for it. It then polls the project until it is complete and then sends the results back to purldb. It would be better for the main worker loop to just collect new download urls from purldb and whenever we create a new scan project, we append a pipeline at the end of the list of pipelines to be run that sends the results back to purldb. This way, the main worker loop does not need to poll and see if the scan project is done. It would also behoove us to implement some scan counter to ensure we do not have more than a few package scans running at the same time.

We now use the webhook subscriptions to send package scan results back to purldb. A new webhook endpoint has been created on purldb for this purpose.


Bump to stylus 0.53 is needed!

I see that Stylus was updated to 0.53 and contains lots of interesting enhancements: https://github.com/stylus/stylus/blob/dev/History.md#0530--2015-12-14
Could you update grunt-contrib-stylus according with latest changes?
Thank you in advance.

Can you send a PR?

@sapegin Please check it out.


answers

i have absolutely no idea how to use this, does it give you answers to questions? how do i get them? I have it bookmarked and i know its on because the colours switched

Hi @Jms2069,
This program does not "give you answers to question". The program is not a method of cheating in any way of form. I suggest reading the Terms and Conditions before continuing your use of the program.
Thanks, Najm


Don’t use assert_nil in tab_test.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

Use assert_equal, which is more semantically correct in these cases.
References https://github.com/Homebrew/brew/pull/1914.

Thanks @reitermarkus. For future reference I'd split large whitespace-only changes into another commit or PR to make review easier.


Questions about reproducing

Hi, really nice work. I want to reproduce the results you have in your paper. Would you mind writing a little more detailed tutorial, like links to the training test set, and the commands for training? Thanks！

Hi @Volodymyr233 , thank you so much. I am working on it. I will upload the full dataset and write a detailed tutorial how to install and run the code.

@Volodymyr233 Hi, you can check out the README.md for more details.
I will add more examples

Thanks!!!!


Add support for SSL

This PR adds support for IPC over SSL. The server can load an X509Certificate2 object as the certificate, and the client can either rely upon the system certificate validation or implement a custom validation callback.
I have included code in the ConsoleClient, ConsoleServer, and WebServer projects to provide examples of using the SslIpcServiceClient and SslIpcServiceEndpoint classes. There are testing certificates included.
Usage information and security guidance has been added to the readme.
While the code doesn't currently implement client certificates, it was written with the expectation that this functionality could be added later.

This is a first pass approach that gets the feature up and working.
I realised this morning that there's a somewhat more elegant and extensible approach to this. Instead of duplicating most of the class code for the TCP transport, I could instead modify the TCP classes with an overloaded constructor to take a Func<Stream, Stream> that wraps a user-specified stream around the NetworkStream. The SSL feature would then be a set of convenience classes wrapped around this, offering the same API as this PR does.
The bonus of the stream wrapping approach is that users can provide their own wrapping stream for whatever purposes they like. For example, if the user wished to implement a custom handshake outside of the normal IPC mechanism, they could subclass Stream and do so.
Assuming this feature is something you're interested in, I'm now in two minds as to whether we should merge this to get the initial SSL feature set in and rework towards the stream-wrapping model later, or do the rework before merging anything. Let me know what you think.

@gsuberland Thanks for your suggestion and PR!
Indeed, SSL basically only makes sens for TCP and I would prefere it be an option on the existing Tcp endpoint/client. Creating new SSL endpoint/client types seems not be DRY enough for me.

Agreed. I'll rework this so that it's a constructor overload on the TCP classes, offering either SSL or a Func<Stream, Stream> for custom stream wrappers.

Added PFX file in new PR.


Investigate whether gha-installer fails when there's a draft release

Observed a failure in setup-gflows step on build against automated changelog commit prior to publishing release.

Fixed by https://github.com/jbrunton/gha-installer/pull/24


Terminal visually broken after 1.66.0

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.66.0
OS Version: MacOS Monterey 12.3 - MacBook Pro M1 Max

Steps to Reproduce:
The terminal (currently working well on terminal.app, iTerm2 or Hyper, using OhMyZsh got visually 'broken' with the last update:
You can notice the triangular shapes not respecting colors:

/duplicate #146168


Fixed Issue 931

Pull request for Issue Fix #931

Hello Team,
Is there anything I need to do get it merged?
Regards,
Malligarjunan S.


fix: [#4520] Upgrade restify to fix error on Node version 18+

Fixes #4520
Description
This PR upgrades the restify dependency to version 11.1.0 to avoid the error on Node 18+.
It also updates the target in TS bots, as the new version of restify introduced a breaking change.
Additionally, it upgrades botbuilder packages to version 4.20.0 and fixes an eslint issue in the core bot's index.ts.
Specific Changes

Updated remaining TS and JS bots to use restify version 11.1.0.
Upgraded botbuilder packages to version 4.20.0.
Updated the tsconfig.json's target property to es2017.
Fixed a lint issue in templates/core/index.ts.

Testing
These images show the generated bots working and the tests in core-with-tests passing.

@ceciliaavila This is failing during the Node 16 tests:

CloudAdapter
process
throws exception on expired token:
AssertionError: expected false to be true

expected - actual

-false
+true
at Context. (libraries/botbuilder/tests/cloudAdapter.test.js:153:81)
at runMicrotasks ()
at processTicksAndRejections (node:internal/process/task_queues:96:5)


don't upgrade any gatsby libs

All the gatsby stuff needs node 10+ now

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @chris48s!

  Generated by :no_entry_sign: dangerJS against 38dd8876fb1113c2d3e34cc380293c93d780e5f6

We're rapidly approaching a point where Dependabot will be ignoring all of our dependencies because everything will require Node 10+ 😄


feat: [CURLRequest] add option for Proxy

Description

add request option proxy

Checklist:

[x] Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[x] User guide updated
[x] Conforms to style guide

Can flexible option with basic below?

It seems not. Document Guzzle gives an example as below:
$client->request('GET', '/', [
    'proxy' => [
        'http'  => 'http://localhost:8125', // Use this proxy with "http"
        'https' => 'http://localhost:9124', // Use this proxy with "https",
        'no' => ['.mit.edu', 'foo.com']    // Don't use a proxy with these
    ]
]);

However, I think the documents of this PR should clearly indicate how to set these things.

@ddevsr

This class is modeled after the Guzzle HTTP Client library since it is one of the more widely used libraries. Where possible, the syntax has been kept the same so that if your application needs something a little more powerful than what this library provides, you will have to change very little to move over to use Guzzle.
https://codeigniter4.github.io/CodeIgniter4/libraries/curlrequest.html

I think CURLRequest is a lightweight Guzzle, and if you need more functionality, use Guzzle.
Therefore, we should avoid extensions of our own.

@kenjis thanks for this. I really need this as soon as possible in my app.

@ddevsr If someone needs it, s/he can implement and send a PR.


Back to questions does not redirect back to entity page

If you have embedded Q&A page as a tab into entity page, like this:

After selecting question there is a button called Back to questions.
But that redirect the user back to all questions, not the ones that relates to the entity to begin with.
Should we embed question page under the entity page as well, so there would be no reason to have the button in the first place or is there any other ideas how to handle? Maybe carry entity reference in URL?

No, there's no reference in URL. Other option is to use the navigation history from browser but that might lead to weird places. Maybe adding the reference to URL could be the best option. Or some combination of these.

Should be fixed in 1.13.0


[DOC] cuml/README.md does not cover all the notebooks

Report incorrect documentation
Location of incorrect documentation
https://github.com/rapidsai/notebooks/blob/master/cuml/README.md
Describe the problems or issues found in the documentation
It does not mention other algorithm sample notebooks, such as pca, ridge, linear regression...
Steps taken to verify documentation is incorrect
I have read the README.md, and compare its content to the cuml content.
Suggested fix for documentation
Add documentation for the new notebooks.

Report needed documentation
Report needed documentation
A clear and concise description of what documentation you believe it is needed and why.
Describe the documentation you'd like
A clear and concise description of what you want to happen.
Steps taken to search for needed documentation
List any steps you have taken:

fixed! thanks @miguelangel


Binary Tree Inorder Traversal

Great work @amishaagg please give this repo a star if it really helped you to complete your PR.
Also follow me for follow back if you want to get connected with me for any such open source contribution program. Thank you 😊


add minor completions Universal-Variability-Language/uvl-lsp#37

Fixes #37
Added support for the completion of "cardinality", "String", "Integer" and "Real" of Features
There are many completion features that would be helpful (e.g. only suggesting String Features for String functions within constraints, ...)
However, this will take a lot more effort to do.
If this is required, I will create an additional issue that acquires all needed completion features and focuses on this.

This works for now and should be sufficient für #37. Creating an issue for more sophisticated autocomplete suggestions still makes sense though.


Sources Test

Closes #14

Would we need to do anything more besides basic asserts for the tests?

Would we need to do anything more besides basic asserts for the tests?

I don’t think so


[BugFix] Fix clip_fraction in PO losses

cc @albertbou92 @wbinventor

This one also need to be corrected
https://github.com/pytorch/rl/blob/main/torchrl/objectives/ppo.py#L864


Review supported_drivers for Fiona 1.9

The following drivers moved to gdal-extra-drivers:
AeronavFAA, BNA, SEGY, SUA

This repository contains legacy drivers for GDAL/OGR, which are built as a GDAL plugin. They used to be included in the GDAL core library in versions prior to 3.3, but they have been removed due to lack of interest to maintain them and because of their marginal values for the majority of users.

The ARCGEN driver was removed with GDAL 3.5.0.
I would suggest removing these drivers from https://github.com/Toblerity/Fiona/blob/maint-1.9/fiona/drvsupport.py#L17 for Fiona 1.9.

Fiona 1.9 is released.


[gelly] removes generic type constraints

As per discussion in FLINK-1962, I removed the generic type constraints from the Gelly API.
This will hopefully make the development of the Scala API easier.
This PR also removes the isWeaklyConnected() method from the Graph class, because it required a Comparable vertex key. We could re-introduce this functionality as a library method, if needed.

+1 Looks good

Thanks @aljoscha!
This might mess up existing Gelly PRs, but I think all of them should be trivial to rebase, except maybe for #537. I'll take care of rebasing and finishing this PR :-)
If no objections, I'll merge this tonight.


Can't Mint DOI in draft state

Only mint a DOI on a published work

The DOI is actually minting correctly. The cause of this bug is the following:
class Work < ApplicationRecord

  def count_view!
    raise ArgumentError, 'work must have a published version' if latest_published_version.nil?  # 👈 this

    latest_published_version.count_view!
  end

end

What happens is the following:
Given:

Only Works can have DOIs, not Versions

When:

I create a Work that only has a single, unpublished draft version
And I go to its resource page: GET /resources/:draft-version-uuid
And I click the button to mint a doi: POST /dois/:parent-work-uuid (see Given 1)
The DOI mints correctly

Then:

The DoisController, given the parent Work's uuid (see When 3), will redirect back to the parent Work's resource page: '/resources/:parent-work-uuid`
The view analytics code in Work#count_view! raises an ArgumentError

We should definitely fix Work#count_view! to simply do nothing if there is not a published work, rather than raise an Exception (OR we should catch that exception in the controller code). Doing so would fix this problem.
However, we should perhaps consider what the DoisController is doing as well. One thing we could do is redirect back to the calling page, rather than redirecting to the Work resource page explicitly. Redirecting back to the calling page is not always guaranteed to work (it relies on the Referrer header to be present in the HTTP request), but 80% of the time it works every time, and we can provide a fallback.

@awead ☝


Uncaught Error: Class "SpreadCompat" not found

Hi! I'm having trouble starting/using spread-compat, I already installed the package and added this line already
`use LeKoala\SpreadCompat;
use LeKoala\SpreadCompat\Xlsx\Simple;
use LeKoala\SpreadCompat\Xlsx\XlsxAdapter;
SpreadCompat::$preferredXlsxAdapter = SpreadCompat::SIMPLE; `
But I keep getting Uncaught Error: Class "LeKoala\SpreadCompat" not found

use LeKoala\SpreadCompat\SpreadCompat;
this should do it :) you have the class and the namespace which are the same

use LeKoala\SpreadCompat\SpreadCompat;
this should do it :) you have the class and the namespace which are the same

i did that before too and this is the error that i encountered:
Fatal error: Uncaught Error: Access to undeclared static property LeKoala\SpreadCompat\SpreadCompat::$preferredXlsxAdapter

I'm not sure what's your issue but the static variable is there and should be easily discoverable by your ide
https://github.com/lekoala/spread-compat/blob/68d32ee0bbe6e89a317d51553ccc0a6d8c96b6ff/src/SpreadCompat.php#L28
and here is an example of this being used
https://github.com/lekoala/silverstripe-excel-import-export/blob/2b3e21ddf6b0060b9b64949700d8a1d8c5231f57/_config.php#L3-L11

closing this i think it should be fine


RM  / Profile Integration

"Save Opportunities" to Profile. Apply CTA should be in source contact copy above

Will upload wireframe images once I get better internet


use TLS 1.2

Meetup.com expects you to use TLS 1.2.  The library does not enforce this (yet).
Hence you'll get an error message "The request was aborted: Could not create SSL/TLS secure channel."
Before calling the code in your code, you'll need to call
System.Net.ServicePointManager.SecurityProtocol = System.Net.SecurityProtocolType.Tls12

Hi @dampee and thanks fro creating this issue 👍
I don't believe this is an issue directly related to this package or something that is should enforce, but instead something the implementer of a site or program should be aware of.
I could possibly document it somewhere, but if people see the exception message, I think they are more likely to Google it, and find an answer on Stack Overflow.
Overwriting the SecurityProtocol could also have undesired consequences - eg. if other services doesn't yet support TLS 1.2 (although they should), calls to these services will instead fail as TLS 1.1 is no longer allowed. Adding TLS 1.2 via a boolean operator would arguably be a better solution, as it adds TLS 1.2 to the already allowed protocols:
System.Net.ServicePointManager.SecurityProtocol |= System.Net.SecurityProtocolType.Tls12

But again, I think this should be something that is up to the implementer, as it's affects the entire application.
It's also no longer an issue with newer versions of .NET (possibly from 4.7 and up, can't remember the exact version).
Hope that makes sense 😉


Bootstrap Switch is outdated

Bundled version: 3.0.2
Upstream version: 3.3.2
Since development of YiiBooster appears to be reaching the end of its life, I find it unlikely that this (along with many other bundled assets) will ever be updated again. What is the best way to include the latest version of bootstrap-switch without modifying yiibooster?

@vercotux: @hijarian and @amrbedair have been good about accepting PRs still...
Generally, the process for updating is:

Read the changelog of the updated library to identify potential conflicts or changes in API
Clear existing YiiBooster assets directory for the library (https://github.com/clevertech/YiiBooster/tree/master/src/assets/bootstrap-switch)
Move new library files to YiiBooster assets
Update packages.php to point to CDN assets (https://github.com/clevertech/YiiBooster/blob/master/src/components/packages.php)
Test, Test, Test.


Remote sources

Revision of loadFromRemoteSources app compat element
This PR replaces #4970 and attempts to clarify the precise effect of the config setting and the reason for setting it.
It isn't clear to me, though, @jeffschwMSFT,when the exception is thrown -- whether it's thrown when loading the assembly with Assembly.LoadFrom, or whether it's thrown when attempting to invoke the assembly's code. It's also not clear to me which exception is thrown.
In addition, the Assembly.LoadFrom documentation should be modified to explain that executing code from remote sources is disabled by default and a link to the loadFromRemoteSources topic included.
@breyed, we'd really appreciate your feedback about the clarity of this topic. I thought that the previous version had all of the essential information, but it was so verbose and disjointed that it came close to being unintelligible.
Replaces #4970
//cc @BillWagner @breyed @jeffschwMSFT @jkotas @DnlHarvey

Here is an example of the exception thrown (at LoadFrom time).
System.IO.FileLoadException: Could not load file or assembly 'file:assem.dll' or one of its dependencies. Operation is not supported. (Exception from HRESULT: 0x80131515)
File name: 'file:assem.dll' ---> System.NotSupportedException: An attempt was made to load an assembly from a network location which would have caused the assembly to be sandboxed in previous versions of the .NET Framework. This release of the .NET Framework does not enable CAS policy by default, so this load may be dangerous. If this load is not intended to sandbox the assembly, please enable the loadFromRemoteSources switch. See http://go.microsoft.com/fwlink/?LinkId=155569 for more information.
at System.Reflection.RuntimeAssembly._nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, RuntimeAssembly locationHint, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks)
at System.Reflection.RuntimeAssembly.InternalLoadAssemblyName(AssemblyName assemblyRef, Evidence assemblySecurity, RuntimeAssembly reqAssembly, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks)
at System.Reflection.RuntimeAssembly.InternalLoadFrom(String assemblyFile, Evidence securityEvidence, Byte[] hashValue, AssemblyHashAlgorithm hashAlgorithm, Boolean forIntrospection, Boolean suppressSecurityChecks, StackCrawlMark& stackMark)
at System.Reflection.Assembly.LoadFrom(String assemblyFile)

Thanks, @jeffschwMSFT! I'll revise the topic  accordingly.


docs: Fix typo in bru-lang-overview.md

Added a missing 'we' in docs/bru-lang-overview.md

# Before:
If you are wondering why had to...
# After:
If you are wondering why we had to...

Closing this PR since it has already been updated in the documentation.


[AutoRelease] t2-network-2023-03-07-64775(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/2985
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1031
BuildTargetingString
azure-mgmt-network
Skip.CreateApiReview
true

issue link:https://github.com/Azure/sdk-release-request/issues/2985


Create release with updated Playwright & dependencies

Create release with updated Playwright & dependencies:

Playwright 1.49
grpcio 1.68.0
grcpio-tools 1.68.0
protobuf 5.28.3 (The " Protobuf gencode version 5.27.2 is older then the runtime version 5.28.1 at playwright.proto. Please avoid checked-in Protobuf gencode that can be obsolete" warning that was present in 5.28.1 is solved in 5.28.3)

Yes, release is planned when few last things are ready. 1) The coverage report new few changes before it, #3887 can be merged
2) @Snooz82 planned to implement the https://playwright.dev/docs/api/class-tracing#tracing-group for the library
But most likely we are able to push release latest next week out.


reuse running ANALYZE result

re-use running ANALYZE if another one is triggered by a user or scheduled automatically.
scheduled/scheduled is already covered by https://github.com/crate/crate/pull/9351/commits/96302017a462f4be259faf052dc0e0a3779c85d5
this PR addresses
manual/manual, scheduled/manual, manual/scheduled

I think a way around this would be to change the request-handler thread-pool from SEARCH to SAME and do manual dispatching to the SEARCH thread-pool to acquire a future of the operation running in the thread.

Thanks, pushed a fixup

some tests are failing, will take another look

some tests are failing, will take another look

./gradlew :server:test --tests "io.crate.integrationtests.CreateTableIntegrationTest.test_intervals_in_generated_column" -Dtests.seed=B8325865683FB975 -Dtests.locale=gl -Dtests.timezone=Etc/GMT-3
passes locally and is unrelated
but ./gradlew :server:test --tests "io.crate.integrationtests.GroupByAggregateTest.test_optimized_topn_distinct_returns_2_unique_items" -Dtests.seed=33DBEA92CA2B62F0 -Dtests.locale=ti-ET -Dtests.timezone=Asia/Yekaterinburg
fails, will check it

unrelated https://jenkins.crate.io/job/CrateDB/job/crate_on_pr/4014/testReport/junit/org.elasticsearch.indices.recovery/IndexRecoveryIT/testTransientErrorsDuringRecoveryAreRetried/
retest this please

retest this please (cancelled prev run as it hung)


use --password-stdin to prevent process table leaking

Modifies the helm registry login command to use the --password-stdin flag which prevents leaking the password on the process table.
This might also be the cause of a bug: https://github.com/aws/eks-anywhere-packages/issues/923
Though as far as I can tell, the helm registry login command still accepts the --password flag, though it prints a warning.
Issue #, if available:
Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Alpha Release for easy_manipulation_deployment

This pull request is to upload the alpha release of easy_manipulation_deployment.
The codebase code quality standard is verified with tests conducted with industrial_ci and provides detailed documentation including step by step tutorials for new users to follow.

The code under this pull request has been verified via internal peer review under the ROSI-AP team.

The code under this pull request has been verified via internal peer review under the ROSI-AP team.


Garbled text (encoding)

I tried to use emailconverter-2.2.1-all.jar on Linux with eml that embeds HTML that specifies UTF-8 charset everywhere and no other charsets. This produces partially garbled text in my case; however, using version 2.1.1 with the same document works fine for me.
I can share the eml but not in public.
Results
2.2.1

2.1.1

Please send it to<EMAIL_ADDRESS>

Sent.

@SteffenL Can you check if it works again with 2.2.2? I don't have the fonts locally I suspect

Version 2.2.2 works as expected. Thank you for the swift fix!


[UI] ui class of repository-summary : top and bottom borders are not aligned

Gitea version (or commit ref):  1.12.0+dev-24-ged5140d23
Git version: 2.24
Operating system: docker
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
ui class of repository-summary : top and bottom borders are not aligned
suggestion:

.repository .repository-summary {
    /* height: 48px; */
    overflow: hidden;

...
before

after

Screenshots

if looks good to you , I will give a pr later

Issue is .repository-summary is also used on the main repo page where this explicit height is needed to for https://github.com/go-gitea/gitea/issues/10474. I'd suggest renaming the one one the main page to .repository-summary-with-languages and move the 48px style to that name as well.

@silverwind Thanks for your advice , I found when remove the 48px from .repository-summary, the main repo page seems looks good!
can I just to remove this ? not add a new css name just like .repository-summary-with-languages ?

Removing it will re-introduce https://github.com/go-gitea/gitea/issues/10474. I will take a look later.

@silverwind sorry , I don`t have a full dev environment，
Some code dependencies are not well checked

already fixed by #10754,


Delay origin index alias promotion until after filtered index is created

Problem

https://github.com/WordPress/openverse/issues/2306 describes the technical issue in depth. To re-summarise, there is a gap between when the origin index is promoted and when the filtered index is finished. During this gap, the previous filtered index will still be being used for queries against the new origin index. This means that new documents in the origin index that have never been processed by the filtered index creation could get through with an incorrect sensitive text designation even if they do not have sensitive text. This is because we derive a document's text sensitivity based on its non-presence in the filtered index.
To restate: the consequence of this problem is that documents could be incorrectly designated as having sensitive text, not the other way around. To my mind, that significantly reduces the severity of this issue. If documents with sensitive text were incorrectly being left out of the sensitive text designation, then it would be a more severe issue.
Description

To goal needs to be to minimise the gap between the origin index having new documents and the filtered index not having yet been updated to reflect the new origin index.
The best way to do this is to delay the origin index alias switch until after the filtered index is created. This will result in a world where filtered queries (the vast majority of our queries) receive up-to-date information before unfiltered queries. It also completely removes the possibility of any documents being incorrectly labelled as having sensitive text.
Move the data refresh's promote alias step to after the filtered index creation. This will require some rather complex changes as the data refresh DAG's design assumes that alias promotion can happen immediately after index creation. It will also require adding a sensor to wait for filtered index creation to finish.
This should probably be done before, with, or immediately after https://github.com/WordPress/openverse/issues/2071 (so long as that issue is implemented with this one in mind) as they'll both be changing the timing of the alias promotion.

Resolved by https://github.com/WordPress/openverse/pull/3303


Add tests of nunit-summary

These will necessarily be functional tests, most likely running the command-line and examining the output produced.

Fixed by #11


Fix focused publishing

This change:

Fixes an issue around publishing the focused value within view update (i.e. Xcode runtime purple warning)
Moves the library iOS requirement to iOS 15 (in order to use FocusState and remove the need of an external focused binding)
Adds a UI test for toggling the focus state (i.e. simulates the interaction with a hosting app updating from outside)
Revamps a bit how the buttons for debug actions of the example app work to save some place for debug AST / sent message, etc:

Codecov Report
Patch coverage: 100.00% and project coverage change: +1.47% :tada:

Comparison is base (555d7f1) 88.38% compared to head (8749483) 89.86%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #761      +/-   ##
============================================
+ Coverage     88.38%   89.86%   +1.47%
============================================
  Files           150      113      -37
  Lines         17638    16222    -1416
  Branches        836      606     -230
============================================
- Hits          15590    14578    -1012
+ Misses         1841     1624     -217
+ Partials        207       20     -187

Flag
Coverage Δ

uitests
80.51% <100.00%> (+5.39%)
:arrow_up:

uitests-android
?

uitests-ios
80.51% <100.00%> (-0.13%)
:arrow_down:

unittests
88.55% <0.00%> (+1.01%)
:arrow_up:

unittests-android
?

unittests-ios
76.25% <0.00%> (+0.74%)
:arrow_up:

unittests-rust
89.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

...ents/WysiwygComposerView/WysiwygComposerView.swift
76.85% <100.00%> (-1.82%)
:arrow_down:

... and 37 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Additional permission required in example IAM policy

Creating an ec2_instance doesn't seem to work out of the box with the IAM policy in examples/iam-profile/profile.json
Applying the Getting started example from the README results in:
"Error: Could not set 'present' on ensure: You are not authorized to perform this operation."
I enabled cloudtrail logging on our account to discover which specific action was being denied, it appears to be the ec2:DescribeAccountAttributes action. Once I added this to the IAM policy associated with the puppetmaster, I was able to create an ec2_instance successfully. Perhaps this should be added to the example IAM policy?

Thanks for the fix! Looks like this can be closed.


bump go version to 1.18 #65

Close #65

Codecov Report

Merging #69 (92ac0a5) into main (8b06938) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   97.63%   97.63%
=======================================
  Files          19       19
  Lines         633      633
=======================================
  Hits          618      618
  Misses         10       10
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b06938...92ac0a5. Read the comment docs.


How to cancel range download

Hi,
In https://dev.onedrive.com/items/download.htm range download is possible with response 206. Does there is any specific API to cancel range download as in case of Upload there is cancel Upload session?
Thanks.

There's no need to cancel a range download from the service perspective, since downloading a file range is a stateless operation. However, if you start downloading a range and decide you don't need to continue to download the range, the client can abort the connection using the semantics of your HTTP client. Not all HTTP clients allow cancelling transfers however.

ok. Thank you. If I have any further cliarifications, I will come back.


Support Zeebe's user tasks

Since Zeebe 1.0.0, user tasks are supported: https://docs.camunda.io/docs/reference/bpmn-processes/user-tasks/user-tasks
In order to support user tasks, the app must watch for jobs of the type io.camunda.zeebe:userTask.
The new job type replaces the previous job type user.

Is there any ETA for this feature?

I plan to work on it at the end of Jun or the beginning of July.
I've some other projects which need some love before :smile:
But I'm happy if someone wants to contribute here :wink:

When will a new version be released

The task list is empty when connected

Unfortunately, I didn't have time yet. I hope to work on it in December.

The task list is empty when connected

Now, I can get task list. But can't show taskform with luck!

The task list is empty when connected

Now, I can get task list. But can't show taskform with luck!

https://github.com/camunda-community-hub/zeebe-simple-tasklist/issues/88
some update.

Done by #91 :rocket:


Add Data Artefact for the Zarr DB

Need to write the data definition for the output Zarr DB and expose it somewhere

Satip has been simplified with #7 with the EUMETSAT data transformation and such now taking place in nowcasting-dataset


[BUG] koordlet continues reporting errors: error write cpuset.cpus: no space left on device

What happened:
koordlet continues reporting errors like:
I0710 16:18:11.021831  492950 container_context.go:183] set container xxx/xxx/xxx cpuset  on cgroup parent kubepods/besteffort/podb481a53f-9b99-485e-9438-f975c9dc26e7/3eb53be8450b7a1b30070b1d74fdc1892d470535c0e446fed2dfa6faecf383f5 failed, error write /host-cgroup/cpuset/kubepods/besteffort/podb481a53f-9b99-485e-9438-f975c9dc26e7/3eb53be8450b7a1b30070b1d74fdc1892d470535c0e446fed2dfa6faecf383f5/cpuset.cpus: no space left on device

What you expected to happen:
koordlet should not report these errors.
How to reproduce it (as minimally and precisely as possible):
use command like below, you could find some error logs:
kubectl logs <koordlet-pod> -nkoordinator-system | grep "no space left"

Anything else we need to know?:
Environment:

App version: 1.1.1
Kubernetes version (use kubectl version): 1.18.6
Install details (e.g. helm install args):
Node environment (for koordlet/runtime-proxy issue):

Containerd/Docker version:
OS version:
Kernal version:
Cgroup driver: cgroupfs/systemd

Others:

I find the reason is that koordlet assign BE containers with cpuset value = string("")，https://github.com/koordinator-sh/koordinator/blob/06b2f5ba2582aaab8d922f51a84d22306a642473/pkg/koordlet/runtimehooks/hooks/cpuset/rule.go#L98
The command like below could also trigger this error:
echo "" > /host-cgroup/cpuset/kubepods/besteffort/podb481a53f-9b99-485e-9438-f975c9dc26e7/3eb53be8450b7a1b30070b1d74fdc1892d470535c0e446fed2dfa6faecf383f5/cpuset.cpus

The output of this command is:
-bash: echo: write error: No space left on device

Sorry, I see it has been fixed here: https://github.com/koordinator-sh/koordinator/blob/06b2f5ba2582aaab8d922f51a84d22306a642473/pkg/koordlet/runtimehooks/protocol/container_context.go#L212C79-L212C79   , close it

it just fixed in main branch,not in v1.2.0


Fix minor

[ ] Fix blocking at test_tasks.py
[ ] Support relative path
[ ] Support single GPU tuning
[ ] Bump FLAML version

Codecov Report

:exclamation: No coverage uploaded for pull request base (ray/v2.1.0@789ca62). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##             ray/v2.1.0     #100   +/-   ##
=============================================
  Coverage              ?   66.14%
=============================================
  Files                 ?       61
  Lines                 ?     1545
  Branches              ?      222
=============================================
  Hits                  ?     1022
  Misses                ?      441
  Partials              ?       82

Flag
Coverage Δ

unittests
66.14% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Restored HttpAdminClient with host head and no proxy settings

Wasn't sure if you wanted tests for the constructors over in HttpAdminClientTest, so I left them out for now.

Normally I'd insist on a test, but this is a trivial enough case not to bother IMO.
However, I would suggest only having one constructor that actually does the work and the rest referencing this(....) rather than two with mostly duplicated code. Please could you make that change?

 Thanks!

Great, thanks!


Update To Support Zustand 4.30+

Love this library but it does not work with Zustand versions over 4.3.0

https://github.com/udecode/zustood/discussions/53

https://github.com/udecode/zustood/pull/57


Feature: Gallery Section

What feature or improvement do you think would benefit Files?
It would be nice if we had a gallery section like in the new files explorer. It would work a bit like the issue #5058 but for all the pictures on the pc and with the same options as in the file explorer

Requirements

This proposal will accomplish X
This proposal will accomplish Y
This proposal will accomplish Z

Files Version
<IP_ADDRESS>
Windows Version
10.0.26002.1000
Comments
No response

Thanks for the feedback, The gallery is just a pinned pictures library (Right click the sidebar > Click libraries. If you want you can go up one directory and just pin the pictures library to the favorites bar) and you can rename it if you want. As for the photos layout it uses that's tracked here https://github.com/files-community/Files/issues/5058. You can check there or click subscribe in the right sidebar for updates.


opt-out to open access check box

Story
Add opt-out of open access checkbox for auto accepted manuscript versions of journal articles.
Success criteria

[ ] Show check box for opt-out when publication type = "Journal Article" AND publication version = "AAM"
[ ] After access level panes and embargo
[ ] Visible to reviewers as well
[ ] Link to research tip

Implementation
Opt out off

Opt out on

Text
Checkbox label
Opt out of making the Auto Accepted Manuscript version of this scientific journal article open access automatically.
Help text
Ghent University assumes permission from authors to make the AAM version of their scientific journal articles published in 2023 or later publicly accessible in Biblio after embargo, based on the Belgian Open Access regulation.
Research tip [TODO]
Temporary link: https://onderzoektips.ugent.be/en/tips/00001734/
Component
Checkbox and help text
Code example

      <input class="custom-control-input" id="customCheck2" type="checkbox">

        Opt out of making the Auto Accepted Manuscript version of this scientific journal article open access automatically.
        Ghent University assumes permission from authors to make the AAM version of their scientific journal articles published in 2023 or later publicly accessible in Biblio after embargo, based on the Belgian Open Access regulation.

Context
Belgian regulation
Context for researchers and supporting staff:
The Belgian Open Access regulation [add link to research tip when available] gives authors of scientific journal articles the right to make their AAM publicly available after an embargo of 6 or 12 months (depending on discipline), regardless of publisher policies or terms of publishing agreements.
Without opt-out, Ghent University assumes permission from authors to make the AAM version of their scientific journal articles published in 2023 or later openly accessible in Biblio after embargo, in line with the Belgian Open Access regulation. See university policy [add link to research tip when available].
If you do not opt out, a Biblio reviewer will set the "access level after embargo period" for your AAM to open access and set an embargo period if you forget to do so yourself.
Current implementation

@nics & @netsensei Based on Stefanie's input I've created an example of what the opt-out for AAM versions of journal articles could look like. It does imply conditional behaviour, as it's only for AAM versions of journal articles. What do you think?
@sdebodt as a placeholder I've added the current researchtip that speaks about open access regulation, we can add the other link when it's available. If we can point to a better spot than this one in the meantime, give me a shout.

Suggestion:

"Fix it for me"
"I know what I'm doing"

The check box should reflect whether authors wish to actively opt-out, as this possibility is described in the publication policy. In practice, it has value in knowing whether reviewers need/can fix it, but that is not what we want users to indicate.

@sdebodt no worries, it's more the mindset that I noted down during a meeting – as it's clear that this is complex for a lot of people.

Related https://github.com/ugent-library/biblio-backend/issues/538


Add configurable timeouts

Terraform supports configurable timeouts since v0.9.0.
With this commit, it's possible to configure the timeout for the
creation of a libvirt domain. It defaults to 5 minutes, but can be as
short as 10 seconds.

Coverage increased (+0.6%) to 49.667% when pulling 8428bee91d7b072ce967063d8d64a67cee67538f on monstermunchkin:feature/configurable-timeouts into a286dc5494691c2b04c48ef6695ed0c902912c0f on dmacvicar:master.

LGTM

@inercia it's rebased now. Travis fails because of apt-get, perhaps you could restart the test.

Coverage increased (+0.4%) to 54.037% when pulling 88145c1cc8ad8c977cb74792de37cce98ad349c3 on monstermunchkin:feature/configurable-timeouts into 527fbf5b82d4baea0f26571d29da0cc20fad6ea7 on dmacvicar:master.

Coverage increased (+0.4%) to 53.997% when pulling 1739e29f4a59ce2c610aa86983edb73866549f04 on monstermunchkin:feature/configurable-timeouts into 527fbf5b82d4baea0f26571d29da0cc20fad6ea7 on dmacvicar:master.


create github actions

@Richardson-e Are you able to address the changes we discussed in the last Grails Engineering meeting?

@guillermocalvo yes, I used grails-core as a template. Would it be better if I started fresh using  as a template?

@guillermocalvo yes, I used grails-core as a template. Would it be better if I started fresh using this as a template?

Yeah, it may be worth starting fresh 🤔 WDYT @puneetbehl?

As previously suggested, it is advisable to review each file and comprehend every step. While starting from scratch may not be necessary in this scenario, gaining this understanding will facilitate the creation of a new workflow if the need arises. I am not opposed to starting afresh or modifying what you have?
You can draw inspiration from project workflow configurations, such as those in grails-core, grails-gsp, grails-views, grails-data-mapping, grails-spring-security-oauth2, etc. If any step or workflow is unclear, please don't hesitate to reach out for clarification.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: guillermocalvo:x: EmrichardsoneYou have signed the CLA already but the status is still pending? Let us recheck it.


Seperate Bot's Mass and Human's Mass

I don't think this is duplicated, I searched and couldn't find any duplicates but:
How can you make it so bots can spawn in with x mass, while humans can, for example, spawn in with 5000 mass?

This is similar to minions spawning with a different mass to the players,
So just replace the addBot function within BotLoader.js with the following:
BotLoader.prototype.addBot = function () {
    var BotPlayer = require('./BotPlayer');
    var s = new FakeSocket(this.gameServer);
    s.playerTracker = new BotPlayer(this.gameServer, s);
    s.packetHandler = new PacketHandler(this.gameServer, s);
    s.playerTracker.spawnmass = 100;

    // Add to client list
    this.gameServer.clients.push(s);

    // Add to world
    s.packetHandler.setNickname(this.getName());
};

Replace the 100 with any other value, or create a config for it.

I will try this.

@FantasyIsBae Not working.

Working, but it's size not mass.
Closing.


Restrict creation of analyses to non-demo/guest accounts

Once the demo/guest account is added, we need to make sure that they can't actually do anything once logged in other than view things.

I think read only should exist in the system, is there a use for this?

Analyses that are public is my first thought. Those should be direct links given though, and would possibly require making an authenticated and non-authenticated results page.

Agree. Note that I forgot a not in my last message, it should be I think read only should NOT exist in the system,

That does change the meaning then, yes. Also, read only effectively does exist in the system already as the "public" status currently.

The more I think about this, the more I feel like we don't need guest accounts. What do you guys think? Note that the demo user is in the main deploy and if we agree I can delete it (checked and it seems that nothing is linked to this account) to close this issue.

We need it for reviewers.

On Oct 12, 2015, at 9:25 AM, Antonio Gonzalez<EMAIL_ADDRESS>wrote:
The more I think about this, the more I feel like we don't need guest accounts. What do you guys think? Note that the demo user is in the main deploy and if we agree I can delete it (checked and it seems that nothing is linked to this account) to close this issue.
—
Reply to this email directly or view it on GitHub https://github.com/biocore/qiita/issues/213#issuecomment-147452240.

I think the demo user should be removed from the main deploy - it can be a mess if multiple users use it as its account.
In order to provide access to reviewers, the demo account doesn't work because it doesn't have access to those studies. I think we can create special accounts that expire in some time and have only access to reviewed studies/analysis. Does it makes sense?

I don't think guest accounts are the solution for this. As far as I can understand it a guest account is basically an account that have limited privileges in the system. What we need is to be able to create "difficult" links to studies and analysis.

IMO, "difficult" link is not the way to go, as anybody with the link can access to that data publicly - which shouldn't be.
Guest accounts - as you defined, an account that have limited privileges in the system is what will make more sense here. It will be an account that cannot do anything - just check the information on those studies/analysis that we provide access (the ones to be reviewed)

OK. The motivation for those is for people to try out the system without signing up, which is a substantial barrier for many people (whether you believe this or not, it’s definitely true).

On Oct 12, 2015, at 9:33 AM, Jose Navas<EMAIL_ADDRESS>wrote:
IMO, "difficult" link is not the way to go, as anybody with the link can access to that data publicly - which shouldn't be.
Guest accounts - as you defined, an account that have limited privileges in the system is what will make more sense here. It will be an account that cannot do anything - just check the information on those studies/analysis that we provide access (the ones to be reviewed)
—
Reply to this email directly or view it on GitHub https://github.com/biocore/qiita/issues/213#issuecomment-147453951.

Consensus is to have create single links for pages that we want to share:

[ ] analysis
[ ] study main pages
[ ] ... add others ...?


Augmenting catalog data with non-ingestion sources

Start Date
Project Lead
Actual Ship Date

TBD
TBD
TBD

Description

Getting content safety/reports back to the catalog
Any external validation we do on content safety
Dead link ETL
The project relates to all of the above, so setting up a mechanism for this is a prerequisite for any of those processes
This might require a “deleted” table in the catalog to reference which media we’ve removed for various reasons
Possible dependents:

Data normalization
Dead link ETL

Prerequisites

#416

Documents

[ ] Project Proposal
[ ] Implementation Plan

Issues

Prior Art

This project was not completed in 2023 but will be incorporated into a new project idea for 2024. Closing this issue.


Add helper scripts to setup rook-ceph

With RBD mirroring, VolumeReplication bits

This builds on ocm-minikube.sh which sets up the OCM
based minikube clusters 'hub' and 'cluster1'
Use as follows,

Setup rook on hub:
'hack/minikube-rook-setup.sh'
Setup rook on cluster1:
'PROFILE=cluster1 hack/minikube-rook-setup.sh'
Setup hub to cluster1 mirroring:
'hack/minikube-rook-mirror-setup.sh'
Setup cluster1 to hub mirroring:
'PRIMARY_CLUSTER=cluster1 SECONDARY_CLUSTER=hub hack/minikube-rook-mirror-setup.sh'
Test hub to cluster1 mirroring:
'hack/minikube-rook-mirror-test.sh'
Test cluster1 to hub mirroring:
'PRIMARY_CLUSTER=cluster1 SECONDARY_CLUSTER=hub hack/minikube-rook-mirror-test.sh'

Signed-off-by: Shyamsundar Ranganathan<EMAIL_ADDRESS>

NOTE: Once rook is setup with the scripts, to stop and start minikube instance (more importantly start) use the script provided targets,

hack/minikube-rook-setup.sh stop|start

Rook stores data in /var/lib/rook and that needs to be softlinked before starting rook, the start script above does the necessary in that regard.

Use as follows,

Setup rook on hub:
'hack/minikube-rook-setup.sh'
Setup rook on cluster1:
'PROFILE=cluster1 hack/minikube-rook-setup.sh'

It seems minikube-rook-setup.sh now requires a sub-command: [create|start|stop|delete].  create for the above examples, I presume.

Use as follows,

Setup rook on hub:
'hack/minikube-rook-setup.sh'
Setup rook on cluster1:
'PROFILE=cluster1 hack/minikube-rook-setup.sh'

It seems minikube-rook-setup.sh now requires a sub-command: [create|start|stop|delete]. create for the above examples, I presume.

Ouch! yes..

@hatfieldbrian @vdeenadh based on latest testing and setting up e2e, does this script do what is required>? if so can we ack and merge this?


Markdown updates for 3.1.1

Replace of the steps from #3932 to update the markdown formatting and links for 3.1.1
(mysterious python script needed a few additions, included in a comment)

Script to update anchors and rewrite all our links:
from sys import argv
from pathlib import Path
import re

# this script tries to inflect the old links, some are just missing and we need to use the title's version instead
updates = {}
updates["revision-history"] = "appendix-a-revision-history"
updates["data-type-conversion"] = "appendix-b-data-type-conversion"
updates["using-r-f-c6570-implementations"] = "appendix-c-using-rfc6570-implementations"
updates["serializing-headers-and-cookies"] = "appendix-d-serializing-headers-and-cookies"
updates["percent-encoding-and-form-media-types"] = "appendix-e-percent-encoding-and-form-media-types"
updates["document-structure"] = "openapi-description-structure"
updates["oas-object"] = "openapi-object"
updates["components-security-schemes"] = "security-scheme-object"
updates["schema-composition"] = "composition-and-inheritance-polymorphism"
updates["http-codes"] = "http-status-codes"
updates["oas-document"] = "openapi-description"
updates["rich-text"] = "rich-text-formatting"
updates["relative-references"] = "relative-references-in-urls"
updates["relative-references"] = "relative-references-in-urls"
updates["runtime-expression"] = "runtime-expressions"
updates["runtime-expression-examples"] = "examples"
updates["relative-references"] = "relative-references-in-urls"

updates["relative-references-u-r-i"] = "relative-references-in-api-description-uris"
updates["relative-references-u-r-l"] = "relative-references-in-api-urls"
updates["binary-data"] = "working-with-binary-data"
updates["base-vocabulary"] = "oas-base-vocabulary"

def kebab_it(c):
    if c.lower() != c:
        return f'-{c.lower()}'
    return c

if __name__ == '__main__':
    text = Path(argv[1]).read_text()

    names = {}
    removals = {}
    for match in re.finditer(r'\n(.*)<a name="([^"]*)"', text):
        name = match.group(2)
        names[name] = ''.join([kebab_it(c) for c in name])

        # was it a heading? file it for removal
        if len(match.group(1)) and match.group(1)[0] == "#":
            removals[name] = True

    for current, replacement in names.items():
        if replacement in updates:
            replacement = updates[replacement]
        text = text.replace(f'(#{current})', f'(#{replacement})')

        # only remove if removal is indicated, otherwise update
        if current in removals:
            text = text.replace(f'', '')
        else:
            text = text.replace(f'', f'')

    print(text)


Video

Use libtheora most likely (other video formats don't seem to be free to use).

How would this interact with, say, a video stream player object inside of a game? Example: VRChat allows you to create video players that can take in URLs from various websites and stream (synced over the network!) YouTube videos so everyone in a room can watch together. YouTube uses H.264, as do nearly all video streaming platforms.
For local video playback, Theora is fine since you can encode videos that you want to put into your project ahead of time. But for streaming content, H.264 is the de facto standard and I think it would be really, really awesome to be able to support that.
A non-social example could be something like putting tutorial videos on YouTube that new players can access if they need help figuring something out. This would allow you to upload as many tutorials or other videos as you need without having to bundle them with the game, increasing the filesize by incredible amounts. It also allows for much higher quality videos since the files are being streamed so you don't need to worry so much about file size or compression to fit them into your game's assets.

h264 would be awesome.  Unfortunately, it is quite a beast.

It's heavily patented.  I don't know the exact details but if someone made a commercial project using LÖVR that included h264 video decoding, either they or lovr would be required to pay royalties to the MPEG LA company.  That's pretty unacceptable, and goes against the open-source aspects of LÖVR.
I don't know of any small libraries that offer h264 decoding under a permissive license.  I haven't researched extensively, but options that come to mind are ffmpeg, libav, or x264.  All of those are GPL/LGPL and are quite large.
For optimized decoding, Intel, AMD, and NVIDIA each have their own proprietary SDKs for decoding video on the GPU.  I think Windows has an API for it too.  We'd probably want to use those so the work can be done in hardware, but that's 4 new (closed) libraries to integrate.

How does VRChat stream its youtube videos?  Does youtube have an API that provides video streams?  Do they embed a web browser?
Oh, since this issue was created this library was released for MPEG-1 Video decoding.

I don't know the exact implemnentation of VRChat's video players, but I do know that there are youtube downloader sites that you can use to expose direct access to mp4 files on the youtube servers, so i suspect they probably do something like that in the background since none of the video players i've seen have seek bars (it's difficult to seek through a massive mp4 file when streaming; youtube servers tiny chunk mp4 data streams when viewing over youtube, but store full mp4 files as well).
As for the licensing issues, I 100% understand. I think perhaps an optional ffmpeg/h.264 variant module could be created so projects that need it can use it, but it is not shipped directly. this also would (probably?) eliminate any risk of lovr being responsibe for licensing things and require anyone who includes it in their game tobe responsibe. this is one of the reasons why audacity ships LAME separately.
We were speaking in slack the other day about pulling enet out of the main distribution and making it an optional add-on. perhaps several optional add-ons could be created for lovr that are generally useful but perhaps too big or too risky to ship directly. h.264, enet, physics, etc

Relevant article about the MPEG-1 lib mentioned above: https://phoboslab.org/log/2019/06/pl-mpeg-single-file-library

Maybe lovr could integrate with gstreamer, gstreamer is plugin based so that you can support multiple different video, audio, and streaming formats.
The only problem being that this wouldn't work on web.

libvpx is practical and would let you deal in webm. this has the nice benefit of not needing to ship the library on web at all, since you should be able to use the native decoding in the browser (which, in all likelihood, will also be libvpx wrapped up in a different api)

This feature won't be integrated into "core" LÖVR, instead it should use the plugin system.

Vulkan video encode/decode extensions were released today.  Might make some of this possible on some GPUs and it wouldn't require extra libraries.


Add git_libgit2_opts binding for get/set search path

Prepare these bindings in order to fix https://github.com/rust-lang/cargo/issues/8863.
Due to the same reason mentioned https://github.com/rust-lang/git2-rs/pull/126#discussion_r57835890 , the bindings do not split strings to paths and leave the work for callers to call std::env::join_paths themselves.

Not sure how to handle path on Windows. Should it returns OsString directly? Or just throw an invalid UTF-8 error like util::byte2path?
https://github.com/rust-lang/git2-rs/blob/68805637017da2fb59bc7dc600e89614db016c32/src/util.rs#L91-L95

Not sure how to handle path on Windows. Should it returns OsString directly? Or just throw an invalid UTF-8 error like util::byte2path?
https://github.com/rust-lang/git2-rs/blob/68805637017da2fb59bc7dc600e89614db016c32/src/util.rs#L91-L95

Also, 0075b12 makes it thread-safe to access global state of search path, but have no idea is that necessary.

Also, 0075b12 makes it thread-safe to access global state of search path, but have no idea is that necessary.

Not sure how to handle path on Windows. Should get_search_path returns CString directly? Or just throw an invalid UTF-8 error like util::byte2path?

e5d8643 fix: get_search_path will returns CString
I think returning a CString is more straight foward since set_search_search also accept an IntoCString type.

Not sure how to handle path on Windows. Should get_search_path returns CString directly? Or just throw an invalid UTF-8 error like util::byte2path?

e5d8643 fix: get_search_path will returns CString
I think returning a CString is more straight foward since set_search_search also accept an IntoCString type.

This seems generally fine but the global-state-ness is worrisome with respect to how this is being used in https://github.com/rust-lang/cargo/pull/9035. If this doesn't work for that PR would you still like to land this?

This seems generally fine but the global-state-ness is worrisome with respect to how this is being used in https://github.com/rust-lang/cargo/pull/9035. If this doesn't work for that PR would you still like to land this?

This seems generally fine but the global-state-ness is worrisome with respect to how this is being used in rust-lang/cargo#9035. If this doesn't work for that PR would you still like to land this?

If i didn't get it wrong, from the view of git2-rs itself, the global state in git2-rs just reflects the global state in libgit2. To make git2-rs as safe as possible (that's one of it's goal 😂), I would choose an approach like this one no matter how callers use it.

This seems generally fine but the global-state-ness is worrisome with respect to how this is being used in rust-lang/cargo#9035. If this doesn't work for that PR would you still like to land this?

If i didn't get it wrong, from the view of git2-rs itself, the global state in git2-rs just reflects the global state in libgit2. To make git2-rs as safe as possible (that's one of it's goal 😂), I would choose an approach like this one no matter how callers use it.

Ok, in that case though I think it may be better to flag these functions as unsafe. They're not safe to mix with other configuration functions in multiple threads and this probably has to happen near the front of libgit2's usage rather than later. I think the synchronization can only really be left up to the caller since we don't know about all the calls to libgit2's configuration functions.

Ok, in that case though I think it may be better to flag these functions as unsafe. They're not safe to mix with other configuration functions in multiple threads and this probably has to happen near the front of libgit2's usage rather than later. I think the synchronization can only really be left up to the caller since we don't know about all the calls to libgit2's configuration functions.

Got it. I'll remove the synchronization part. Thanks!

Got it. I'll remove the synchronization part. Thanks!

Looks good! As one final thing though, I think the test may wantt to move to an integration test in something like tests/foo.rs? Otherwise I don't think we can guarantee that it's synchronized with all other tests.

Looks good! As one final thing though, I think the test may wantt to move to an integration test in something like tests/foo.rs? Otherwise I don't think we can guarantee that it's synchronized with all other tests.

Thanks for your advice. The test has been moved to a integration test at adc0ee8.
 If I understand it correctly, the reason moving it to a integration test is that if people what to mutate the same global state, it can edit the "integration test" directly without touching "unit test" part, right?

Thanks for your advice. The test has been moved to a integration test at adc0ee8.
 If I understand it correctly, the reason moving it to a integration test is that if people what to mutate the same global state, it can edit the "integration test" directly without touching "unit test" part, right?

👍

👍


tidying the homepage a bit - index for lessons

I was a bit confused by the current homepage, since it wasn't clear to me where the lessons were!

Judging from the name of the repo/url, i am assuming that we'll want to have a number of different lessons in here over time? It made sense to me to have those be in the top bar with links out to other pages in the dropdown, so then it becomes clear that i am "in" one lesson or another by the top nav bar, and then the left bar is what part of the lesson i'm a part of. I would think that this whole site is "lessons" so it wasn't immediately obvious to me that i needed to click 'lessons' to go to the clean code lesson.
I also tidied up the rest of the index page, moved the contributors into a badge like the others, and added a card for the lesson like we have on the package guide. I think the header links are a little goofy just hovering in the center, so i aligned them to the left too.

The thing that i wasn't sure about here is whether the "functions conditionals and checks" is a different lesson than "clean, expressive, code" or whether it was a subsection of it? The folder structure says that it's a subsection, but ig the hierarchy there was a little ambiguous to me so lmk if that's supposed to be considered a separate lesson.

@all-contributors please add @sneakers-the-rat for code, review


[Testerina] Implement an alternative for LogLeacher

Description:
There are issues with running several tests in testerina framework when using the Log Leacher implementation. We need to find an alternative approach to achieve the log comparison for the test framework.
Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

This PR removes logleecher from standard test cases.
https://github.com/ballerina-platform/ballerina-lang/pull/28133