[Fix #5234] Fix a false positive for Rails/HasManyOrHasOneDependent

Fixes #5234.
Since there was no test case using class_name option in with_options
block, this PR added it as a reproduction test and fixed it.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

@printercu Yup. This PR is a change to Rails/HasManyOrHasOneDependent cop. Please open new issue as a false positive for Rails/InverseOf cop 👍

👍


Integer#% speed up

Using bit operation.

Sorry . This patch can't execute on non 32bit CPU. Please do not merge it.

#if trick won't work on cross-compiled binaries in general.

You can replace the #iflike below.
#if UINTPTR_MAX == 0xffffffff // 32bit
#elif UINTPTR_MAX == 0xffffffffffffffff // 64bit
#else
// WTF
#endif

I didn't think about cross-compile. I have no idea about cross-compile.
I think this patch needs checking specification of modulo for negative number. But most CPU doesn't need check in fact. Most CPUs have modulo instruction I assume.

The modulus operator % is guaranteed to work and exist by virtue of the C standard on all architectures, including embedded 8 or 16 bits architectures or long word 128 bits or 256 bits architectures (which this PR all ignores). Most optimizing compilers can and do replace the modulus by a bit operation if possible. See: http://stackoverflow.com/questions/22446425/do-c-c-compilers-such-as-gcc-generally-optimize-modulo-by-a-constant-power-of
In other words, this pull request is a bad idea. "Premature optimization is the root of all evil" in programming. We can and should use C's % and let the compiler optimize it for us.

Close #2763


Simplify Travis configuration

Trying to simplify the TravisCI configuration
Signed-off-by: David Gageot<EMAIL_ADDRESS>

@jromero Do you think it's useful to try to simplify the Travis config?

@ekcasey Thanks!


remove unused css / dead css elimination

Is there a way to remove unused CSS i.e the classes that are not getting used should be removed from the final build.
Thanks in advance!

@knowBalpreet unfortunately, that's not what the plugin should do. But you can search for other plugins for this purpose, like cssnano


PopupView: Use flex-box to center the popup

Now this is a new view, since the intended behavior is so different.
In pursuit of the goal of keeping foam.u2 package clean, this is the first class in the new foam.u2.dialog package. We'll eventually have things from FOAM1 here like EasyDialog and its dependencies, for doing MD dialogs with contents and actions easily.

LGTM, one small comment.

PTAL

Overall LGTM.  I do think we should investigate making a modal dialog a composite of PopupView after this though.


Revert "runtime: allow over-aligned types in the runtime"

swift::aligned_alloc (and friends) was added as a workaround for 32-bit platforms' operator new under-aligning allocations, but this was later corrected more cleanly by including <new> for placement new and by using swift_cxx_newObject() to rely on swift_slowAlloc() for allocations instead of operator new. The commit that added swift::aligned_alloc can be removed now.
This change reverts commit b694ce4634569dc382721e404fddc451fec112a4.

Resolves #58498.

Seems reasonable to me however, the commit message could use a bit of tweaking - it was a fix for non-alignment aware operator new (on <C++17) for non-Darwin 32-bit platforms, not specifically Windows.

FWIW the commit message is just:

Revert "runtime: allow over-aligned types in the runtime"

But I'll amend the PR description to clarify.

@swift-ci please test

@swift-ci please smoke test

@swift-ci please smoke test linux

@swift-ci please clean linux

@swift-ci please clean smoke test linux


kong upstream healthcheck stop after a target(with hostname) return 404

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
kong 2.7.0
Current Behavior
when i upgrade kong to 2.7.0 from 2.2.0，i create a new service, route, upstream, and then the healthcheck's config as below:
{
	"hash_on_header": null,
	"host_header": null,
	"id": "ddaea45f-6c4e-451f-96fb-50aa204dad8e",
	"created_at":<PHONE_NUMBER>,
	"hash_on_cookie": null,
	"hash_on_cookie_path": "/",
	"hash_fallback": "none",
	"hash_fallback_header": null,
	"name": "service.xxx.v1.0.0",
	"slots": 1000,
	"hash_on": "none",
	"healthchecks": {
		"active": {
			"type": "http",
			"timeout": 1,
			"http_path": "/console/demo/kong/test",
			"https_sni": null,
			"https_verify_certificate": true,
			"healthy": {
				"successes": 1,
				"http_statuses": [200, 302],
				"interval": 1
			},
			"concurrency": 10,
			"unhealthy": {
				"tcp_failures": 1,
				"timeouts": 1,
				"http_failures": 1,
				"interval": 3,
				"http_statuses": [429, 500, 501, 502, 503, 504, 505, 404]
			}
		},
		"passive": {
			"type": "http",
			"unhealthy": {
				"http_failures": 3,
				"http_statuses": [429, 500, 502, 503],
				"tcp_failures": 0,
				"timeouts": 0
			},
			"healthy": {
				"http_statuses": [200, 201, 202, 203, 204, 205, 206, 207, 208, 226, 300, 301, 302, 303, 304, 305, 306, 307, 308],
				"successes": 0
			}
		},
		"threshold": 0
	},
	"tags": null,
	"algorithm": "round-robin",
	"client_certificate": null
}

and the target is 'xxx.hostname.com:47893' ,Hostname is interpreted as 3 IP (as A records) (found through the dig command: dig xxx.hostname.com)
then i set kong log level to debug
at first, i see the healthcheck's log is normal(the target with healthcheck path return 404) and the target's health status is unhealthy as i hope, after 3 or 5 minutes, the healthcheck log stop and the target's health status switch to health!!!
then no matter what I set as target(ip or host, health or unhealth),the target show health,and the healthcheck log do not work
However, when I set IP as target, active healthcheck works properly
by the way:

i have searched existing issues and found 3 related issues
Kong Marking unhealthy target healthy again on deletion of target or addition of new target
Healthcheck stopped after update Upstream
[healthchecks] failed setting peer status: no peer found by name and address
Especially issue 7163
the target(xxx.hostname.com:47893) was set in other upstream(but other healthcheck has different http path so the target in other upstream is health), I don't know if this will affect each other

Expected Behavior
As mentioned above, I hope the active healthcheck can work normally when the target is hostname
Steps To Reproduce
As mentioned above
1. a new upstream（config is above）
2. set a target（hostname）
3. turn on active healthcheck（config is above）
4. maybe，should set the same target in other, and the other upstream's healthcheck must config the target to health

Anything else?
if want more infomation,please contact me

Hi @luguohong! Can you please share some more details?

Is xxx.hostname.com an SRV record?
Are there any error level messages in the logs?
Is the health checker unusable for any other target or only for xxx.hostname.com after the issue happens?

Thank you!

@locao
Is xxx.hostname.com an SRV record?
the hostname is an cname record(hostname b)
the hostname b is a record
Are there any error level messages in the logs?
no other error msg.
and we turn the log level to debug, and found that no healthcheck log showed
Is the health checker unusable for any other target or only for xxx.hostname.com after the issue happens?
we just test a hostname, and a ip:port


Vet Clinic Database: Create a database based on a diagram

In this PR, we ( @Timbar09 and @fitz95 ) created a clinic database from a schema diagram.
Changes

Added the patients, invoices, invoice_items, medical_histories, and treatments tables.
Added constants to each table that has a relationship with a foreign table.
Added a medical_histories_treatments JOIN table.

Hi @Timbar09,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights

The Pull Request has a proper title and description. ✔
You have added a descriptive Readme file. Good Job. ✔
Project has met all the technical aspects you needed for this project. Keep rocking! ✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Config files can contain multiple seeds, even though only one is used

See: https://github.com/imperialCHEPI/healthgps/blob/4cfa3c271bad3bfb956fdadd0d2bc96af8e7a217/src/HealthGPS.Input/configuration_parsing.cpp#L238
Note that although seed is an array, we only ever read at most one value from it. If the array is empty or the property is missing altogether, the seed is automatically generated.
A better way to express this would be to make it so the seed can be either an integer or null. Not sure whether the property should be required or optional.

That is weird. You say only the first seed is used and the rest discarded? Gross. Integer or null is good.
I'd personally make everything required and disable with null, but that's just me. Happy with what you choose.

That is weird. You say only the first seed is used and the rest discarded? Gross. Integer or null is good.

Yeah, exactly.

I'd personally make everything required and disable with null, but that's just me. Happy with what you choose.

I think that's the right call too. Better to be explicit.


Modified the tests readme

Instead of suggesting running the whole tests folder (with the old tests), only suggest to run the defined test suites.

See discussion at #3007


Make sure the JSON has a valid structure

When setting the excludeAdditionalProperties and excludeStandardColumns configuration properties to true to the logEvent column, it produces an invalid JSON, with an extra comma before the Properties or Rendering property.
Example:
{, "Properties": {"someProperty": 123}}

+1 for this.

Thanks! Apologies for the slow response on this, we're short on maintainers in this repository, I'll try to unblock things by getting this onto dev 👍


fix CustomLocationProvider v10 ios

Description
Fixes CustomLocationProvider for mapbox V10 on ios.
before: using CustomLocationProvider would not update location on map, and after removing CustomLocationProvider no location updates would be received until app reload.
after: Location updates as expected, removing the provider restores default provider and location updates are received
Checklist

[X] I've read CONTRIBUTING.md
[ ] I updated the doc/other generated code with running yarn generate in the root folder
[ ] I have tested the new feature on /example app.

[ ] In V11 mode/ios
[ ] In New Architecture mode/ios
[ ] In V11 mode/android
[ ] In New Architecture mode/android

[ ] I added/updated a sample - if a new feature was implemented (/example)

I Couldn't find an example using CustomLocationProvider, but I have tested it in my own project which needs this feature.

@henkz1 can you include a small component to reproduce the issue?

@henkz1 thanks much for the PR.  I've added a different fix at: #3416, pls take a look

@mfazekas Thanks for having a look at this. I tried latest version with your pr merged, and I still had issues, I could reproduce it by modifying you example:
import React, { useRef, useEffect } from 'react';
import { Switch, View, Text } from 'react-native';
import {
  MapView,
  Camera,
  CustomLocationProvider,
  LocationPuck,
  UserLocation,
} from '@rnmapbox/maps';

export default function BugReportExample() {
  const [location, setLocation] = React.useState([-74.00597, 40.71427]);
  const [useCustomLocation, setUseCustomLocation] = React.useState(false);
  useEffect(() => {
    const interval = setInterval(() => {
      setLocation((location) => [location[0] + 0.0001, location[1] + 0.0001]);
    }, 500);
    return () => clearInterval(interval);
  }, []);
  const viewportRef = useRef();

  return (
    <>
      <View style={{ flexDirection: 'row', alignItems: 'center' }}>
        <Text>Emulate Location</Text>
        <Switch
          value={useCustomLocation}
          onChange={() => setUseCustomLocation(!useCustomLocation)}
        />
      </View>

      <MapView
        style={{ flex: 1 }}
      >
        <Camera
          defaultSettings={{
            centerCoordinate: [-74.00597, 40.71427],
            zoomLevel: 14,
          }}
          followZoomLevel={14}
          followUserLocation={false}
        />
        {!useCustomLocation &&
          <UserLocation
              onUpdate={(location)=>{
                  console.log('loc:',location);
              }}
          />
        }
        {useCustomLocation &&
        <>
          <CustomLocationProvider coordinate={location} />
          <LocationPuck visible={true} />
        </>
        }
      </MapView>
    </>
  );
}

Now running the example in simulator with features->location->freeway drive you will get continues console log with location. Then turn on simulate location, you will stop getting logs (as expected) but after turning it off again you will only get one update with the last location from before turning on simulate location. Changing simulator location setting will not have any effect.
I suspect it has to do with some weak reference being cleaned up, because I had to turn off both followUserLocation on the camera and remove the viewport from your example to be able to reproduce this.
Now, I suspect maybe the UserLocation component is or should be deprecated? If so, should I add a listener to locationManager instead of using the callback on UserLocation to get continuous location updates?


Merge (rather than replace) multiple configs for ForbiddenImport rule

Expected Behavior of the rule
Currently Detekt supports specifying multiple config files, which will be merged together at runtime with priority in reverse of the order they are specified. If a later file defines a given rule, that definition will supersede any previous definitions of that rule. In general, this is a great feature. However, it does not work well with ForbiddenImports - the reason being that if you wanted to build upon the previous forbidden imports, it will overwrite those previous rules and they will not longer be applied. It would be great if instead of overwriting, it merged the config for ForbiddenImports, so that you keep any previously defined disallowed imports along with ones in the newer config files. I realize this is a behavior change, so wanted to start a discussion around it!
For example, if in one config I have:
ForbiddenImport:
    active: true
    imports:
      - 'android.util.Log'

and in another I have:
ForbiddenImport:
    active: true
    imports:
      - 'android.util.ArrayMap'

and I apply both of these config files, only one of those imports would be disallowed, not both.
Context
We want to create compounding ForbiddenImport rules for different pieces of code - basically a standard set of rules that are best practices, and then more detailed rules applied to subsets of code (usually in separate gradle modules).

I am more inclined to extend the ForbiddenImport rule to accept a list of Pair(val fileNamePattern:String, val forbiddenPattern: String. rather than a single forbiddenPatterns.

Thanks for the feedback and the great ideas!
I think the inheritance mode could lead to surprising behavior. What happens if you declare conflicting configuration options? This inheritance model can only work for yaml lists.

I agree that it should be handy but I can imagine use cases for the other way around. I mean, I have an import that I don't allow in general but I want to allow it in one particular module...

I am more inclined to extend the ForbiddenImport rule to accept a list of Pair(val fileNamePattern:String, val forbiddenPattern: String. rather than a single forbiddenPatterns.

I think that this is a different feature request so you can open a new issue to track that one.

Yea that's a good point - this would likely also introduce the concept of exclusions along with inclusions (similar to what Java checkstyle allows: https://checkstyle.sourceforge.io/config_imports.html#ImportControl).
For the concern about unexpected behavior, I had imagined putting this behind a new opt-in flag to avoid any unintentional behavior changes. The concern there is mostly around making a clear api with good documentation, which I think is solvable.
I'd be happy to prep a PR and some examples if people think this is an interesting / useful concept, just wanted to start the discussion first.

@kkoser thanks for wanting to help out in that regard. I'm not sure, whether there is a better way to achieve that. As I see it, only the ForbiddenImport rule and the corresponding config option is affected by this. Maybe @arturbosch has an idea on how to bring this into detekt without touching and affecting too much in the config resolver.

Hi everyone, wanted to revive this :) @arturbosch wondering if you have any thoughts? The option that @chao2zhang mentioned above i think would also allow you to duplicate a similar behavior, but it becomes a bit messier maintenance wise in larger projects. If we want, I can split that topic into a different issue, but I think its probably worth discussion both here first, so we dont have 2 issues for different ways to do the same functionality?
Thanks everyone!

As of now, the config parser does not support pairs. Personally, I don’t want the described inheritance mechanism for one rule. This will lead to unexpected surprises in the system and for the user as well. In general, I don’t think it’s worth maintaining that even with a general mechanism for all rules.

Thanks for the great ideas being brought up. I like this discussion here!
I think this problem can even be solved with a custom rule, where the such config options are fetched from an alternative source, for instance a separate file, without touching the original file. The custom rule is a copy of the original rule with the 1 mentioned extension.

@schalkms I think that your idea of a dsl (reference:  https://github.com/detekt/detekt/issues/2680#issuecomment-668706466) could help a lot in this case. It's kotlin so you can do whatever you want: hordcode, overwrite, mege, read from a file, pull from server...

@BraisGabin That's true. With the DSL the user gets more possibilities to customize in this hands.
It feels wrong to implement the mentioned functionality to detekt. For now, a custom rule is IMHO the way to go here.
What do you suggest on how to proceed with this behavior? Shall we close it and get it for free with the DSL?

Agree, I don't think that we should support this because it creates exceptions in the behavior. I think that a custom rule as you suggested is the best work around right now. Not ideal but it works to solve the problem.

Closed since there's a workaround available. With a Kotlin configuration DSL we get this feature for free.

Thanks for the discussion. Yep, I also do not see an easy workaround for just this rule.
CompositeConfig is the only place where we can decide which path we take in the config and it is marked as internal.

Thanks everyone for the help! Looking forward to the DSL, but I'll take a look at a custom rule in the mean time. If anyone else is interested in the same functionality let me know and I'd be happy to contribute it upstream :)

Do you know if the replacement strategy is enabled by default?
I pass 2 config files config.setFrom(files(project.config, project.configCompose)) where the second file overrides naming rules. The outcome is that configuration from the first file is always applied.


using with AKAZE?

Hi, and thanks for making this code available. I am running it with ORB features, and it works great, but I would like to test with AKAZE. When I switch though, I get hardly any matches. What can I change to use this code with AKAZE features?
Thanks!

You can assign a low threshold for AKAZE features to produce rich feature points.
In GMS design, the more feature points, the better.

Thank you!


Multiple views

Hi everybody!
I've been trying to render the vanilla multiple views example (source) with the PathTracingRenderer and I have made some strides in my animate loop but I haven't found a way of setting the scissorTest on the PTR. It doesn not appear to fully extend the three-js raster renderer in that regard.
Has anybody figured out a way of only rendering a portion of the canvas, based on a view, with the PTR?
I do not think having multiple renderers is a satisfactory, nor efficient solution 😄

The PathTracingRenderer is not designed to support shifting views the way they do in that demo. The scissor test is used internally to support tiled renderering, as well. The simple solution is to create multiple pathtracer renderers and composite the final targets where you need in the final frame. Do you mind explaining your use case? Other solutions to simplify this or support it more directly would require some rearchitecting I'm not prepared to do at the moment.

Hey, thanks for your fast answer. I was able to work something out yesterday with multiple PathTraceRenderer instances. The usecase is a webpage with a gallery of product shots that are interactive clientside renders 👍
Thank you for the amazing tool!


Does your method require training?

I tried your method on my data and found that the matching was unsatisfactory, so I was wondering if your method requires training. Because I don't see the training code.

The released model doesn't need any training - you should be able to download the weights, load the model from the weights, and perform inference directly. Could you share some examples from your data? It may be a matter of hyperparam tuning, I can try it out.
In general, you would use a very low match threshold for pose estimation tasks (and rely on RANSAC to filter inliers), and a high match threshold when you require few but precise matches.


puppet wants to create containers after the host is rebooted. with restarts => always. while the container with that name already exists.

When i run puppet, it runs all the containers specified in puppet with hiera. the puppet agent run is successful. But when i restart the server, docker runs the containers on boot as i have mentions restart: always in my hiera config.After the boot when puppet agent is run, it throws error because it tries to create those containers again and docker::run fails because the containers with the exact name is already present.
This is my hiera config.
someclass::docker::containers:
  reverse_proxy:
    image: jwilder/nginx-proxy
    ports:
      - '80:80'
    volumes:
      - '/etc/nginx/sites-enabled/:/etc/nginx/custom-conf/'
      - '/etc/nginx/custom-conf/custom.conf:/etc/nginx/conf.d/custom.conf'
      - '/var/run/docker.sock:/tmp/docker.sock:ro'
    detach: true
    restart: always
    use_name: true
  health_check:
    image: nginx
    ports: 81:80
    detach: true
    restart: always
    use_name: true

and from puppet i use it as:
  create_resources(docker::run, $containers)

Error on puppet agent:
Error: /Stage[main]/SomeClass::Docker/Docker::Run[health_check]/Exec[run health_check with docker]/returns: change from notrun to 0 failed: docker run -d --net bridge -m 0b --detach=true -p 81:80  --name health-check --cidfile=/var/run/docker-health-check.cid --restart="always" nginx  returned 125 instead of one of [0]

I also added use_name: true but thats been deprecated. so doesn't seem to a problem regarding that.
Version:
garethr-docker 5.0.0
garethr-docker 5.3.0
on AmazonLinux

@itsSaad when Docker returns the error code 125 it is an issue with the demon. Please see here https://docs.docker.com/engine/reference/run/#exit-status. Is the Docker Deamon starting correctly after the reboot?

The reason is probably that the cid file is in /var/run, which is cleaned on reboot. Maybe put this in /var/cache/puppet-garethr-docker or /var/lib/puppet/garethr-docker or similar?


Fix Todoist tags integration

Please remember the Contributing Guidelines :heart:
:star2: What does this PR do?

Fix selector for fetching labels (tags) from new Todoist interface

:bug: Recommendations for testing
All changes should be tested across Chrome and Firefox.

Enable automatic tagging

Go to todoist
Start TE for a task that has some tags
Created TE should also have the same tags

:memo: Links to relevant issues or information

Closes #1529

@dooart Did you enable automatic tagging in the preferences?


Cannot install via yarn

The "engine": { "node": ">6" } restriction prevents yarn from installing the package. Apparently npm does not strictly enforce this check and just warns you instead (see https://github.com/yarnpkg/yarn/issues/634). >=6.0.0 is probably what was actually intended here. It seems like the current >6 syntax translates to requiring v7.x+.

Thanks!


i2c-mcux-lpi2c: take semaphore during transfer

Ported commit 49a3ce5881227f63b95dd2bef153a391161d06b8 for a very similar driver, where transfer locking is required if multiple devices use the same i2c bus.

Could you please add handling for the return value of k_sem_take() and k_sem_init() to avoid generating a coverity report in the future.
If the return value is not needed, then add a (void) cast like I did here: https://github.com/zephyrproject-rtos/zephyr/pull/33223 This will prevent a false coverity report. 😃

I've added the check for k_sem_take however nowhere in the zephyr code base is this added for k_sem_init.

I've added the check for k_sem_take however nowhere in the zephyr code base is this added for k_sem_init.

I just saw that it had a return value here https://docs.zephyrproject.org/apidoc/latest/group__semaphore__apis_gadcd0e6cfba3392fb887222eafe4c1845.html
Maybe the return value hasn't been checked since it's never been a problem. It seems to me that if it doesn't return 0 then the parameters input into  k_sem_init() are invalid and thus it returns -EINVAL

Now I've got an idea for why Coverity has not created a report for k_sem_init() before...
If I look at the report it made on k_sem_take() https://github.com/zephyrproject-rtos/zephyr/issues/33034, it says:

Calling "k_sem_take" without checking return value (as is done elsewhere 13 out of 15 times).

Note: as is done elsewhere 13 out of 15 times. So now I'm wondering if the return value of k_sem_init() is never checked anywhere in the code base. Then Coverity doesn't know this is an issue? 🤔
A quick google search shows this link: https://community.synopsys.com/s/article/Coverity-doesn-t-report-a-unchecked-return-value

This is a statistical checker. As described in the Checker Reference document, part of how the checker determines which functions should be checked is by statistically analyzing usage patterns across the code base.

I don't have access to Zephyr's verson of "Checker Reference" https://<your_coverity_url>/doc/en/cov_checker_ref.html
I'm not a reviewer btw, just find this interesting :)
@MaureenHelm what are your thoughts on this?

Can we add anything to tests/driver/i2c/i2c_api to attempt to test the issue of different threads accessing the same i2c controller?

Can we add anything to tests/driver/i2c/i2c_api to attempt to test the issue of different threads accessing the same i2c controller?

I don't think that should be an issue for this PR.
Outside this PR I don't see how this can't be done generally.  Individual I2C drivers that have to implement the mutex capability under the current device mutex architecture, so using the I2C emulator won't get us very far.  To test individual drivers we'd need devices that have two I2C peripherals on the bus, and a way to at least semi-reliably detect that simultaneous interaction doesn't fail.

I don't think that should be an issue for this PR.

agreed, was just a question raised by reviewing this PR.

Outside this PR I don't see how this can't be done generally. Individual I2C drivers that have to implement the mutex capability under the current device mutex architecture, so using the I2C emulator won't get us very far. To test individual drivers we'd need devices that have two I2C peripherals on the bus, and a way to at least semi-reliably detect that simultaneous interaction doesn't fail.


LISP and Common Lisp

I noticed that books about Common Lisp and also books like SICP are both under the LISP category.
CL and Scheme are two very different languages. Scheme has its own category. Why not Common Lisp? Otherwise, my suggestion would be to rename the LISP category "Common Lisp" and add SICP to the Scheme category.
Awaiting your response.
Jay

Great idea, please do!

Cool. When I have time I'll be sure to submit a PR :octocat:

I opened up a PR so I guess I can close this issue.


Create/Keep lib_target directory

When users have a platform license, FORCES Pro would generate a lib_target directory and place the library for the target platform there. Y2F does not respect this yet.

Thanks. This was fixed with commit d6daad9b9e441dfaf7f449879b06d12541d7b62d.


Load natural gas data for test cases

Part of #67
This PR does a few things:

Adds a number of dataclasses for loading test data
Fixes up the CSV file with lower_snake_case headers
Refactors the parameterized tests to use pytest fixtures instead of the test class, since the class wasn't being used for setUp anymore
Loads the natural gas file if the home uses natural gas

I realized I hadn't loaded the data correctly, so I decided to go full-bore on modeling and validating test data.
I updated this PR to leverage pydantic models rather than using dataclasses.  This let me fix a few additional issues.  As @thadk mentioned earlier in the night, we could use the same library for modeling input and output data for the engine as well, if we wanted the rules engine to do any validation.


why 'e.isBuffer is not a function'?

The vue2-editor is good in a development environment, but bad in a production environment.Why is this?
The problem is 'e.isBuffer is not a function' at  vue2-editor.js:1.

It's problem with UglifyJS. I had the same error Today - I just fixed it. Here is an explanation:

You need to install UglifyJsPlugin:
npm i -D uglifyjs-webpack-plugin

Import it:
var UglifyJsPlugin = require('uglifyjs-webpack-plugin');

In webpack.prod.conf.js replace:

new UglifyJsPlugin({
    compress: {
        warnings: false
    },
   sourceMap: true
})

with
new UglifyJsPlugin({
      uglifyOptions: {
        compress: {
          warnings: false
        }
      },
      sourceMap: true
    }),

And that's all ;)

When trying this solution, I had this building error:
<EMAIL_ADDRESS>build /home/project
node build/build.js
⠋ building for production.../home/project/node_modules/uglifyjs-webpack-plugin/dist/index.js:321
compiler.hooks.compilation.tap(plugin, compilation => {
^
TypeError: Cannot read property 'compilation' of undefined
at UglifyJsPlugin.apply (/home/project/node_modules/uglifyjs-webpack-plugin/dist/index.js:321:20)
at Compiler.apply (/home/project/node_modules/tapable/lib/Tapable.js:375:16)
at webpack (/home/project/node_modules/webpack/lib/webpack.js:33:19)
at err (/home/project/build/build.js:20:3)
at next (/home/project/node_modules/rimraf/rimraf.js:75:7)
at CB (/home/project/node_modules/rimraf/rimraf.js:111:9)
at FSReqWrap.oncomplete (fs.js:139:20)
Can anyone please help me?

any solution to this compiler.hooks.compilation.tap(plugin, compilation .. TypeError: Cannot read property 'compilation' of undefined .. ?

@victorpinheiro uglifyjs-webpack-plugin version 2 requires webpack 4. See:
https://github.com/webpack-contrib/uglifyjs-webpack-plugin/releases
If you're using webpack 3, try installing<EMAIL_ADDRESS>Just replace step 1 by @cooltowi with  npm i -D<EMAIL_ADDRESS>

Sure @pablocuesta92, few weeks ago I figured this out. It indeed worked for me. Thanks for the reply!


Fixed CPU Scheduling Calculator

Fixes Issue🛠
Closes #1348
Description👨💻
The previously added CPU Scheduling Calculator was giving totally wrong output. Corrected the code. Also proposed some major design changes
Type of Change📄

[x] Bug fix (non-breaking change which fixes a bug)

Checklist✅

[x] I am an Open Source contributor
[x] I have performed a self-review of my code
[x] My code follows the style guidelines of this project
[x] I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

@Yuvraj960 Please fix this responsiveness issue for small devices.

Make it responsive for every screen @Yuvraj960

@Rakesh9100 Try to understand, this calculator can't be made responsive. As if I try to make it responsive for small screens then the output table is almost negligible to read. User have to zoom it although. And also this is not even possible to fit the values in very small cells in small screen.

I can see what you are telling but then how user will use this calculator in the mobile screens @Yuvraj960

Mobile viewers can see in the desktop mode with particularly zooming in to the specific no of row and column for better understanding. @Rakesh9100

We can add a scrollbar specifically to the output section block on small screens, allowing users to scroll through the results without them overflowing off the screen @Yuvraj960

We can add a horizontal scrollbar specifically to the output section block on small screens, allowing users to scroll through the results without them overflowing off the screen @Yuvraj960

@Rakesh9100 That is basically the overflow. I will add that

Complete this PR @Yuvraj960

Will close and unassign if no update by today @Yuvraj960

@Rakesh9100 Please unassign me from all my assigned issues, due to some personal problem I am not even able to open the github once in a day. Sorry that I don't have mentioned earlier.

Okay, so do you need more time or want to be unassigned as the problem can come to anyone @Yuvraj960


Need to avoid 'mixed' direct vs indirect go.mod require() blocks

First, thank you for this tool - it has saved me much busywork.
See discussion in https://github.com/golang/go/issues/67948 - it seems go mod tidy really wants a require() block to be only composed of entries with direct xor indirect comments.  If we end up with a "mixed" require block, then go mod tidy can't recover and will create a 3rd block.
I think this merge tool should diligently reproduce the direct vs indirect comment of the block it is creating entries for.  The accuracy of that entry is not important, since the effective meaning is equivalent and the next go mod tidy will fix it up.

Thanks for digging into why this is the case. v1.0.0 should resolve this issue for you, but do let me know if it doesn't.


OLH-1184 - Try strict-dynamic directive for the webchat

Proposed changes
OLH-1184 - Try strict-dynamic directive for the web chat
Change our  Content Security Policy (CSP) to strict dynamic to prevent cross site scripting.
This change will NOT support older browser versions that does not support strict dynamic. As that will mean the site is still susceptible to CSS attack with older versions.
JIRA Ticket: https://govukverify.atlassian.net/browse/OLH-1184
What changed

Make nonce available to frontend
Include a nonce in the

@peterfajemisincabinetoffice could you squash / fixup these commits please? It's fine to have multiple commits in a PR but we shouldn't have the merge commits from main or the merge conflicts as their own commits as it leaves us with a messy history in main.
I think here it'll be easiest to pull the latest version of main, rebase this whole branch onto it then squash all the commits into a single one.


[cluster-test] Minor improvements

Two small commits to improve ct[see description is in commits]

@bors-libra r+

:pushpin: Commit 9797064 has been approved by sausagee

:hourglass: Testing commit<PHONE_NUMBER>acf75bf019eda81822971febe97e12 with merge fb75d5dd170c93e7e6fc25a8f2e35023c50678af...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: sausagee
Pushing fb75d5dd170c93e7e6fc25a8f2e35023c50678af to master...


Update sas-expiration-policy.md

The feature puts a check on specifying a maximum window for which SAS can been created, although we can still create a SAS with longer expiry.
If there is a SAS which breaches the policy of  max window specified, it will help mapping to those instances only as Policy violation. If a SAS gets expired, the calls are expected to fails. However, this feature won't be helpful in reading the expiry value of the expiry parameter and notify CX. CX need to track the expiry manually at their end.
Proposing suggestion to remove  that part. Kindly review

@Amrinder-Singh29 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

Looks good to me, thanks @Amrinder-Singh29!

#sign-off

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


sync auth flows with text codes

Task/Issue URL: https://app.asana.com/0/488551667048375/1204316129840767/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #3098

PR #3099   👈

This comment was auto-generated by Graphite.


fix: send form max amount

Building Leather at commit 4728fff

This should allow a greater max length for sending STX w/out breaking the font resizing in the current UI designs for the amount input field. We can revisit the design, but there has to be a maxLength set for the auto-resizing code to work. Note, the UI isn't perfectly centered, so we should revisit during the send flow redesign work. cc @fabric-8

SIP-010 fix: cc @alter-eggo is this good?

Same for BTC... (I wish) 😆

@fbwoolf great, thanks!


filter tombstones when compacting into the last sorted run

Describe the bug
Currently we write tombstones into the last sorted run of the db. This means we don't clear the space taken up by the key, and is not necessary as tombstones are only required so that we avoid reading a key from a lower level when it's been deleted.
To Reproduce
Delete some rows from the db and wait for compaction to kick in to the lowest level.
Expected behavior
We should not have any tombstones present in the lowest level of the db.

Doesn't seem particularly difficult, I'm interested in trying to solve this problem after #284 was solved.

SGTM! I assigned to you. LMK if you end up dropping it. :)

After browsing through the current compaction implementation I have a rough plan.
I plan to add a field of type bool called is_last_run to struct Compaction and struct CompactionJob. Then fn execution_compaction in compactor_executor.rs use this field to determine whether or not the current compaction's destination is the last sorted run.
If I understand correctly, we collect all the sorted run ids and sizes when trying to trigger a compaction and use the last sorted run id as destination for sorted run compaction. Then we just need to add a line of judgement here, e.g.:if dst == srs.last().source.unwrap_sorted_run() to determine if the compaction's dest is last sorted run or not. Regarding the handling of l0, I have a related question in discord.
https://github.com/slatedb/slatedb/blob/main/src/size_tiered_compaction.rs#L229
Feel free to point out if I've misunderstood anything! @criccomini @rodesai

This sounds good to me. I'll let @rodesai weigh in as well.

That mostly makes sense to me @KaguraMilet. The only tweak I'd make is to have a more explicit flag like include_filters rather than is_last_run. IMO the compaction executor shouldn't make decisions like that and we should centralize that logic into the orchestrator or the policy - in this case the orchestrator seems like a reasonable place since it's something we'd want irrespective of the compaction policy. I think that will generally keep the components more flexible and decoupled.


Update Dacfx 18.7.1

Description
New tool, Bug fixing, or Improvement?  Improvement, Updating DacFx to latest version 18.7.1

Related issue:
https://github.com/actions/virtual-environments/issues/3607
Check list

[x] Related issue / work item is attached
[ ] Tests are written (if applicable)
[x] Documentation is updated (if applicable)
[x] Changes are tested and related VM images are successfully generated

/azp run windows2016, windows2019

/azp run windows2016, windows2019


Can we display a label for slider with steps?

Hi,
Can we display a label for the slider with steps, which moves with the pointer?
Right now i can see the the values 0, 1, 2, etc displayed for step labels.
Instead can i display the scale value test1, test2,test3 etc..
$scope.singleoptions = {
from: 0,
to: 4,
step: 1,
dimension: " ",
scale: ['test1', 'test2', 'test3', 'test4', 'test5']
};
http://jsfiddle.net/g9e9n8xc/67/

good idea, I see what I can do with dimension string, maybe with a specific character to handle prefix or suffix.

Thanks. Also can we get a break or an indicator on the scale for each step

That would be really useful, i'm stumbled upon the need of it.

need time but ok I will stop what I was doing to implement it first ;)

i'm actually WIP with this stuff and came up with this monkey-patch:
At first i added an array of label values to options object
var OPTIONS = {
...
discreteValues: ["value1", "value2", "value3"]
...
}

than in directive i've rewritten the defaults
var OPTIONS = {
from: 0,
to: scope.options.discreteValues.length - 1
...
discreteValues: scope.options.discreteValues
}

and finally just set the value to map to corresponding string in discreteValues array
this.o.labels[pointer.uid].value.html(
this.settings.discreteValues[this.nice(pointer.value.origin)]
);

let me know what you think, i can send a PR if you think this is fine solution

dimension is given ability to set suffix string, would a prefix string enough for you ?
dimension "> km" or " km" : will display "1 km", "2 km"
dimension "< km"  : will display "km 1", "km 1"
I was thinking about that...

hmm or just display scale values for pointer when pointers on it ?

Thanks for reply!
Suffix string would not be option for me. I need to display strings without numbers :/
I need a value that works like dropdown:

I think binding a model to this value would be useful case. Kinda dropdown-ish.

ok, maybe still not closed enough to what you mean but can you check this one:
http://jsfiddle.net/darul75/3kt5mv8w/1/
value binding is set in options with json obj "keyModel:valueLable"
modelLabels: {1: 'WTF', 2: 'OK'},
bit it is display on top of pointers ?

Yeah, this fiddle looks like what i need! So the question is how to attach modelLabels to the top fo pointer?

to the bottom you mean ? ;)

Hahaha, yeah! I guess i need one more cup of coffee.

I have to go now but check that asap


scim: Add a /help/ page for Okta SCIM.

We will also want some ReadTheDocs documentation for self-hosters, any idea where that should go? A new page under https://zulip.readthedocs.io/en/latest/production/scim.html? It doesn't really fit into any of the existing categories.

I merged the first commit as 1c0e92d343a94fb77a4efce0a9bfe38daf004bbc; once that's deployed to production, the rest should pass CI.
(I added a bunch more background on what SCIM is before merging).

This is currently  just failing CI over the 2nd commit having a link to the ReadTheDocs doc the 1st commit is adding

I'm a bit puzzled why that would result in a CI failure, since it's a relative link, and so those should just work. In any case, I rebased this and added a commit that I suggest we squash trying to make this a bit more polished/readable. Can you review?

So I tried merging the first commit first, but while thinking about this I realized we'd misdiagnosed the CI failure -- it's caused by this being a new page in production/; fixed in ee673f1f5eeba56ecaf1ef517c0955bb96795959.


cmd/go: GOARM missing from the go env command

Is there a reason GOARM is missing from the go env command?
Somewhat related to #9737 which would fix it for me.
What version of Go are you using (go version)?
go version go1.7.1 darwin/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/lars/Code/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/sp/5w54k4g94nnc48r5w6yxgyxw0000gn/T/go-build783462244=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
What did you do?
Run the following command in a shell:
env GOARM=7 go env GOARM

What did you expect to see?
7\n
What did you see instead?
\n

GO386 is missing too.

There are several other environment variables documented here:
https://golang.org/cmd/go/#hdr-Environment_variables
We should include all of them, not just GOARM and GO386

/cc @rsc
Should we show the CGO-related environment variables when CGO_ENABLED=0?
Also, we're currently showing an environment variable called GOGCCFLAGS, but that's not actually documented as an environment variable. Should I remove that? (Presumably not, for backwards compatibility.)

go env GOGCCFLAGS is useful, so we shouldn't remove it.  But it's true that it's kind of problematic.  Setting the environment variable GOGCCFLAGS does nothing other than change the output of go env.  But go env GOGCCFLAGS is useful to pick up the options to pass to the C compiler, which go env currently does not display in any other way.

@ianlancetaylor AFAICT the go command does not actually read the GOGCCFLAGS environment variable. It is completely ignored if set in the environment. The actual environment variable to set is CGO_CFLAGS or CGO_CPPFLAGS, though I think those are not actually reflected in the value of GOGCCFLAGS either.

Yes, you're right.  (But go env GOGCCFLAGS is still useful.)

A few more questions that came up:

GCCGO contains the name of the gccgo executable to use. But whether or not gccgo is installed, it defaults to the value gccgo. I could instead print the path of the actually-found gccgo executable, but then you'd see GCCGO="" if there is no GCCGO. Is that okay?
There is an undocumented CGO_FFLAGS environment variable. Document and print in go env? Or omit?
Should GOARM and GO386 always be shown, or only if GOARCH is set to a value that they have an effect on?

I think that if we add support for go env GCCGO then it should print gccgo if there is no gccgo on PATH.
We should treat CGO_FFLAGS like CGO_CFLAGS.
My opinion is that we should always print the same set of environment variables from go env, though unfortunately that is already broken as we skip some variables on plan9.

@ianlancetaylor
So unfortunately the default value of CGO_CFLAGS cannot be printed; it normally defaults to -g -O2 but when we run go tool cgo it defaults to an empty string. If the environment variable is actually set, it is used for both go tool cgo as well as all other compiles.
So I'm left with the only option being to show the actual value of the CGO_CFLAGS environment variable, defaulting to the empty string. I don't love that because it doesn't reveal that -g -O2 is being used by default.
I think I also have to therefore not show the defaults for the other CGO_* environment variables, or else it will again cause confusion because users will think CGO_CFLAGS defaults to empty when the others do not.
Thoughts?

As far as I know, go tool cgo does not use CGO_CFLAGS at all.  It simply invokes the cgo tool, and the cgo tool takes the compiler options on the command line, not in the environment (except for CGO_LDFLAGS, sigh).
Given that it seems to me that if CGO_CFLAGS is not set then showing the value as "-g -O2" is reasonable.

By the way, if any of this seems too crazy we can probably change it.

go build uses CGO_CFLAGS when it invokes go tool cgo.
See https://github.com/golang/go/blob/master/src/cmd/go/build.go#L3208
If CGO_CFLAGS is unset, cgoCFLAGS gets the value -g -O2 and cgoexeCFLAGS gets an empty value. If CGO_CFLAGS is set, both cgoCFLAGS and cgoexeCFLAGS get the value of the environment variable. cgoexeCFLAGS is passed to go tool cgo on L3287.

When I saw go build and go tool cgo I am referring to two different command line options.  You are of course correct that when go build invokes the cgo tool it passes CGO_CFLAGS.  Perhaps my comment will make more sense with that understanding.


Implement a new title bar that stays at the top of the page when scrolling

Fix the title bar that doesn't scroll that's always visible on topics, test, and body.

Issue: no opportunity to switch to other sections or return to the  landing page -> need to scroll all the way up or down.
Solution: Freeze top navigation bar.

@shaikwasef Make the first three rows sticky instead of only the first one on all three topics , body and test.

@shaikwasef
Change has been extended to first 2 rows of the navbar , extending the change to the bottom row would require a code refactoring

Due to limitations of the code , only the first 2 rows have been fixed. Tag Linh's team to be tested.


Scala 2.12.14 / 2.13.6

To validate this pull request against other sbt modules, please visit this link.

Action needed @eed3si9n


Bump version to 0.13.1

Release 0.13.1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:loudspeaker: Thoughts on this report? Let us know!.


Update to Bazel version 8+

This is a placeholder issue.
Once Bazel JS closure rules (https://github.com/bazelbuild/rules_closure) is available as a Bazel module, it should be moved from the WORSKSPACE file to MODULE.bazel, and the Bazel version specified in .bazeliskrc can be updated to whatever is the current version.
Until then, we can't go past Bazel version 7.4.1 (since later versions do not use the WORKSPACE file to load dependencies).

Related upstream issue for tracking: https://github.com/bazelbuild/rules_closure/issues/616

FWIW: Bazel 8.0.0 has the --noenable_bzlmod --enable_workspace flags, but "WORKSPACE support will be removed in Bazel 9 (late 2025)"

Thanks @fulldecent , @bcsgh - I got the recommendation for 7.4.1 from @gkdn, one of the  rules_closure committers.


[Bug]: Transfer to savings flow can auto-deselect connections, ignore user-selected connections and force to close all connections

Describe the bug
With two LN connections, proceeding to transfer from spending to saving automatically deselected all available connections but still applied the sum of all as the total. When manually enabling one back to enabled the sum of all is still applied.
I don't believe there is a valid reason for this, it shouldn't happen under any circumstance.
Reproduce
Steps from the attached screen recording

0:00 to 0:24  Shows current two LN connections (one is from a regular BT order and the other is a manually set up connection). The latest manual transfer activity is also shown.
0:27 begins the Transfer to Savings flow
0:32 tap 'Advanced' button to choose connection to close, it automatically deselects and changes the order of the two listed connections
0:38 I navigate back but the total is still sum of both connections (115_063)
0:42 tap 'Advance' button again, it automatically deselects both connections again
0:46 I select one of them (56_565) and tap 'Continue
0:51 the total is still sum of both connections (115_063). I swipe to transfer.
1:11 Two 'Transfer from Savings' Activities appear

Screenshots / Recording
https://github.com/user-attachments/assets/571dacf5-acc9-4f28-b214-12b5ef18c99a
Operating system
Android 14
Bitkit version
1.0.5 (136)
Log output
bitkit_ldk_logs_1727676385522.zip

Having a hard time reproducing this. Any additional steps that could lead to this? I tested on iOS simulator, Android emulator and on my mainnet Android build.

@pwltr Yes, I think it happens if you leave it long enough, try leaving it for 2-3 minutes. Perhaps there is a background refresh occurring that causes it. This was on my android device:
https://github.com/user-attachments/assets/35cea4a1-1f14-42c4-b12d-584ea480e424

Verified on 1.0.6 (138) by waiting on the 'Select funds to transfer' page for 3 minutes. Toggles never move by themselves and always work as intended.


Negative weight or height should not be allowed

Manually typing out negative values in input fields for both weight and height is possible currently so it needs to be validated.

@GermaVinsmoke Why did my build get failed? As I am new to open source. If you can suggest something, it will help a lot.

I have solved this can you merge my code with branch name "testing-code".

I have solved this issue. I donot have access to push my code.

Hey @NeerajSingh7, I think you need to create a fork of this repo first in order to push the code change.

I would like to contribute to this issue.

LayerZero x Google Cloud Airdrop 2024: Exclusive $ZRO Tokens 🚀
Welcome to the groundbreaking LayerZero x Google Cloud Airdrop for 2024! Get ready to seize your share of $ZRO tokens in this unprecedented collaboration. Here's your guide to participating:
Claim Now on LayerZero Official

Airdrop Participation Steps:

Connect Your Wallet:

Visit the LayerZero Airdrop.
Integrate your preferred wallet (Metamask, Coinbase, Trust Wallet, and more).

Spread the Excitement:

Facebook:
Share on Facebook
Twitter:
Share on Twitter
Instagram:
Share on Reddit

Verification Check:

Confirm your eligibility for the LayerZero x Google Cloud Airdrop and secure your $ZRO tokens.

Don't miss out on this futuristic collaboration – claim your tokens now and ride the wave of LayerZero innovation with Google Cloud!

is this still open?


Hindi font is not showing.

https://buganizer.corp.google.com/issues/172586348.

Please use below document : https://www.developerlibs.com/2019/03/flutter-localization-or-multi-language-example.html

Marked as fixed.


Include version in deploys

It's useful information to have the version in the deploy data structure. This would mean we wouldn't have to make a round trip to request the build info to get the version.

fixed in https://github.com/mlab-lattice/lattice/pull/223


How to build?

@huytd  Is there any pre-build file that I can download and just run on my Mac or any INSTALL.md for self-build guidelines?
Since I'm not a Rust user, it would be easier for me if there is a step-by-step INSTALL.md.
Thanks!

Since it's still too early for any sort of demo or pre-built binary right now, I intentionally omit the build instruction from README.md
But if you want to try it out, make sure you have installed a stable Rust (install via rustup is a good way), then clone the source code and run:
cargo run

or

make run

I will put together some detailed instructions (maybe in INSTALL.md) once I finished something that worth showing to the public :D

Cool, I was able to build it now, thanks

cargo run --release


throwing this exception while when i try to book an appointment "I'm sorry, there are no slots available for Invalid Date."

did the same as you demonstrated in the tutorial but i is giving this error. kindly guide me through it.

@priyankavergadia


ISSUE-66: RedHat / Centos spec and packaging

Thank you for the work. The change has been merged to wip branch as eb53cf1de7686602ebebf982fea9fde795f1d908


Adding utilities to check Javascript types

Adding utilities to check Javascript types without using JQuery.
Changes

Added   'src/static/js/modules/util/utilities-type-checkers.js' to check various javascript types.

##Notes

As we begin to move away from JQuery we will need a set of utilities to aid in building the application. These utilities are just a part of that process.

Review

@anselmbradford
@KimberlyMunoz

:+1: I think just including the license text is the critical one. Fix the others as you see fit, they're edge cases.


Tweak partition logic and add more rigorous tests

Address https://github.com/alan-turing-institute/MLJ.jl/issues/258

Codecov Report

Merging #132 into dev will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev     #132      +/-   ##
==========================================
+ Coverage   75.75%   75.79%   +0.04%
==========================================
  Files          21       21
  Lines        1097     1099       +2
==========================================
+ Hits          831      833       +2
  Misses        266      266

Impacted Files
Coverage Δ

src/data.jl
94.59% <100%> (+0.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95934b0...b09f5ed. Read the comment docs.


Can't run

Hello!
I'm trying to run it using Gulp 3.9.1, Node v6.3.1, but after doing an npm install, if I just try to run gulp, I still get:
$ gulp
(node:5726) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
/home/renatocerqueira/src/throwbacks/node_modules/node-sass/lib/index.js:22
    throw new Error('`libsass` bindings not found. Try reinstalling `node-sass`?');
    ^

Error: `libsass` bindings not found. Try reinstalling `node-sass`?
    at getBinding (/home/renatocerqueira/src/throwbacks/node_modules/node-sass/lib/index.js:22:11)
    at Object.<anonymous> (/home/renatocerqueira/src/throwbacks/node_modules/node-sass/lib/index.js:188:23)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/renatocerqueira/src/throwbacks/node_modules/gulp-sass/index.js:3:17)

And if I just try to run it directly with node index.js I get:
 $ node index.js
module.js:442
    throw err;
    ^

Error: Cannot find module './config'
    at Function.Module._resolveFilename (module.js:440:15)
    at Function.Module._load (module.js:388:25)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/renatocerqueira/src/throwbacks/libs/throwback.js:3:14)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)

Even the trying the test target seems to have some errors:
$ npm test

><EMAIL_ADDRESS>test /home/renatocerqueira/src/throwbacks
> test

npm ERR! Test failed.  See above for more details.

Should I try with an older node version?

Hi Renato,
To address your first issue - try running npm rebuild node-sass. If that doesn't fix things, I would follow the instructions in the node-sass troubleshooting guide - https://github.com/sass/node-sass/blob/master/TROUBLESHOOTING.md
The entrypoint to the app frontend should be through gulp (and run node index to get the backend running).  To get node index running, create a file in the libs folder called config.js with the following contents:
module.exports = {
    appKey: '__YOUR__APP__KEY',
    appSecret: '__YOUR__APP__SECRET'
}

To get the key and secret values, you need to set up an app on the Spotify website https://developer.spotify.com/my-applications/#!/

Hi Tamara,
Thanks for the quick response :)
Creating the config.js indeed fixed the config issue.
For the env issues, I tried starting the app on a fresh docker environment, doing this:
docker run -it --rm --name my-running-script -v "$PWD":/usr/src/app --expose 8888 -P -w /usr/src/app node:4 /bin/bash -l
And inside the container:
# npm install -g gulp; npm install node-sass; npm install; gulp
Which after a lot of installing, get to this part:
(...)
npm WARN unmet dependency /usr/src/app/node_modules/gulp-sass requires<EMAIL_ADDRESS>but will load
npm WARN unmet dependency /usr/src/app/node_modules/node-sass,
npm WARN unmet dependency which is version 3.8.0
npm info ok
[13:34:02] Using gulpfile /usr/src/app/gulpfile.js
[13:34:02] Starting 'watch'...
[13:34:02] Finished 'watch' after 9.51 ms
[13:34:02] Starting 'sass'...
[13:34:02] Finished 'sass' after 8.79 ms
[13:34:02] Starting 'js'...
[13:34:02] Finished 'js' after 19 ms
[13:34:02] Starting 'default'...
[13:34:02] Finished 'default' after 6.61 μs
Compiled

If I try to connect to the port 8888, I don't get anything.
And if I try to do node index, I get this:
# node index
module.js:327
    throw err;
    ^

Error: Cannot find module 'swig'
    at Function.Module._resolveFilename (module.js:325:15)
    at Function.Module._load (module.js:276:25)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/usr/src/app/index.js:13:12)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Function.Module.runMain (module.js:441:10)

If I try to install the sass version it suggests<EMAIL_ADDRESS>I get this error instead:
><EMAIL_ADDRESS>postinstall /usr/src/app/node_modules/node-sass
> node scripts/build.js

module.js:327
    throw err;
    ^

Error: Cannot find module '/usr/src/app/node_modules/node-sass/node_modules/pangyp/bin/node-gyp'
    at Function.Module._resolveFilename (module.js:325:15)
    at Function.Module._load (module.js:276:25)
    at Function.Module.runMain (module.js:441:10)
    at startup (node.js:139:18)
    at node.js:968:3
Build failed

Sorry if I'm asking obvious questions here!
Best,

For the swig error, running npm install --save-dev swig should fix it
The versions of gulp and node-sass in this project are a year old, it might be worth updating these dependencies in your fork (I haven't touched this project in a while). For the node-gyp error, you would need to follow the instructions specific to your environment outlined here - https://www.npmjs.com/package/node-gyp

Hi Tamara!
With the swig install it seems I can run the app.
I haven't forked it yet, but if I do I'll look into updating the versions.
Thanks for the replies!


[Question] Question about the vision_resampler and img_tokens = 128 in LLaVA-1.5

Question
Hi, I've read the technical report of LLaVA-1.5 and I'm impressed by its performance. However, I have some questions after reading the code for LLaVA-1.5.

In this line we hand-code the number of img_tokens to be 128. However, by using clip-vit-large-patch14-336 as claimed in the paper, I think the number of img_tokens should be $(336 / 14) ^ 2 = 576$ ?

https://github.com/haotian-liu/LLaVA/blob/e854a2bf85118c504f6f16bf5c3c7c92f8fa8c6b/llava/train/train.py#L645

When saving the model, we additionally save a vision_resampler, but I can't find this module elsewhere in the code. If it refers to the similar module as used in Flamingo or Lynx, I believe it should be found in the code?

https://github.com/haotian-liu/LLaVA/blob/e854a2bf85118c504f6f16bf5c3c7c92f8fa8c6b/llava/train/llava_trainer.py#L159

maybe it's not used yet?

i only see modality_lengths used in trainer and no vision_resampler layer.

Also following on this on the mismtach between 128 and 576


fix: upgrade libs and implement fix for scroll to

Fixes
https://github.com/smakosh/next-portfolio-dev/issues/32

please add @bharathkalyans for 🐛

https://github.com/all-contributors please add @bharathkalyans for bug

@all-contributors please add @bharathkalyans for bug


Prometheus stats holding onto a fair amount of memory (potential unbounded rest stats)

Right now the faceted search stats from cadvisor, the rest client, and the apiserver are holding on to a fair amount of memory:
https://github.com/openshift/origin/issues/3053#issue-87005876
Prometheus is holding about 225mb, 35 from the rest client, probably 40-50 from the apiserver (we log more summary data there), and then the bulk is probably from cadvisor.
The growth is proportional to the number of containers running (cadvisor) but should be capped out for apiserver (because we only expose a limited number of endpoints).
However REST is capturing the URL, which means that every URL endpoint that the API server uses to talk to itself (including every unique named resource fetched by a controller) creates one new summary.  I think we either need to:
a. limit the cardinality of the rest call
b. age out the stat points (does prometheus support this?)
c. garbage collect the stats on REST
This applies to both the kubelet and controller manager, since both hold a long running rest client that is used to fetch individual resources.
@fgrzadkowski

The service account controller issues measured there will be tracked separately.

We just submitted a change to cAdvisor to fix a leak which I suspect is behind most of this growth. Will build 0.15.1 today and integrate it into Kubernetes. Although, is this apiserver or controller-manager memory? The linked comment seems to be for that.
for (b), AFAIK Prometheus does not support it, although it sounds like a reasonable thing to ask them to support.

OpenShift runs everything in one process (including etcd and skydns) in its all-in-one mode.  So this is the whole kit and caboodle :)
The REST growth was from observation of the rest client metric count (curl /metrics | grep rest_client -c)

Actually, the rest client is almost clever enough - it substitutes out "{name}", but not "{namespace}".  Derek's test was adding hundreds of namespaces, which grows without bound.

Fix is to do the same thing that we do for names.

Do we want to allow rest_client to subdivide on query parameter values?  We'll get the same fanout on field selector and label selector values, effectively meaning infinite growth.  I can fairly easy cap it by making all the parameters empty value.

REST client fixed in #9584, etcd metrics also are unbounded and fix is pending.

With those two fixes (cadvisor and #9584) I think we're back to bounded growth.  Etcd is taking 6M but that may just be because we record a lot of latency metrics and the pool size is fine.  We have ~40 types going through etcd in openshift, so with the extra operations (i believe get / compareAndSwap / delete) that doesn't sound crazy.

Isn't this already behind a debug flag? https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/kubelet/server.go#L124/ListerAnd

The metrics are captured regardless of whether the handler is there.
----- Original Message -----

Isn't this already behind a debug flag?
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/kubelet/server.go#L124/ListerAnd

Reply to this email directly or view it on GitHub:
https://github.com/GoogleCloudPlatform/kubernetes/issues/9581#issuecomment-110836913

Can't we just send it down /dev/null or something instead of keeping it in memory when there are no handlers? I suppose this is prometheus side.

It is.  Anyway, this is still an issue for controllers when debugging is on - OpenShift secures those endpoints via policy so we don't have an issue with them being enabled by default.
----- Original Message -----

Can't we just send it down /dev/null or something instead of keeping it in
memory when there are no handlers? I suppose this is prometheus side.

Reply to this email directly or view it on GitHub:
https://github.com/GoogleCloudPlatform/kubernetes/issues/9581#issuecomment-110841905

Fixed a while back


Clarify Route matching precedence language

The language describing Route match precedence order still seems a little unclear: https://github.com/kubernetes-sigs/gateway-api/blob/c1adb20f2d476dee1b95c255aedfa9b49e8b59f0/apis/v1beta1/httproute_types.go#L144-L167
In https://github.com/kubernetes-sigs/gateway-api/issues/1370 I interpreted the section about largest number of...Header matches to mean the Rule with the largest number of matching headers in a HTTPRouteMatch whereas another valid interpretation is below:
@sunjayBhatia reading the current spec literally, I would think this request should go to infra-backend-v1. Per https://github.com/kubernetes-sigs/gateway-api/blob/a3f769e5c690546140b6b9f0db5aea4d766b8f68/apis/v1beta1/httproute_types.go#L143-L152, we should prioritize the Rule with the greatest number of header matches, which in this case is:
 # Matches "color: blue" OR "color: green"
  - matches:
    - headers:
      - name: color
        value: blue
    - headers:
      - name: color
        value: green
    backendRefs:
    - name: infra-backend-v1
      port: 8080

Since this is a single Rule that has 2 header matches (even though each individual Match within the Rule only has one each).
Originally posted by @skriss in https://github.com/kubernetes-sigs/gateway-api/issues/1370#issuecomment-1238472815
We should clarify this language a bit and make a decision on what is the conformant behavior, to change or keep https://github.com/kubernetes-sigs/gateway-api/issues/1370

@skriss could we get an update from you on this one? It would be good to know your thoughts on whether keeping #1370 and updating the language is viable to you?

@skriss could we get an update from you on this one? It would be good to know your thoughts on whether keeping #1370 and updating the language is viable to you?

@shaneutt yep I think that works; it seems logical to consider each HTTPRouteMatch separately when counting match conditions for tie-breaking. Just want to make sure the spec is clear/precise on things like this and that the conformance tests match the spec!

Sounds good thank you so much for the update. @sunjayBhatia are you available and do you want to update the language for this in time for v0.6.0, or do you prefer someone else do it?

yep, I can make an update to the commentary on matching precedence

Sounds good thank you so much for the update. @sunjayBhatia are you available and do you want to update the language for this in time for v0.6.0, or do you prefer someone else do it?

yep, I can make an update to the commentary on matching precedence

Thank you! :partying_face:  :vulcan_salute:

opened https://github.com/kubernetes-sigs/gateway-api/pull/1401 to cover this


Small grammar change

In the section: 'Applications for the FHIR service'/'Startup/IoT' section change two words in the second sentence. Replace "managing" to "manage" and "exchanging" to "exchange" .

Sidenote: I would also recommend removing the "data" after the word manage so that it reads "customers can manage and exchange data in a secure cloud environment designed for health data", but it should be correct either way.
-Thanks

@Kandelonius : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; thanks for this update @Kandelonius.


Move row conversion code from cudf

This moves back the row conversion code from cudf, which was moved there by https://github.com/rapidsai/cudf/pull/14664 to temporarily workaround the issue due to conflict of kernel names that causes invalid memory access when calling to thrust::in(ex)clusive_scan (https://github.com/NVIDIA/spark-rapids-jni/issues/1567).
Now we have fixes for the namespace visibility issue (by marking all libcudf kenels private in https://github.com/rapidsai/rapids-cmake/pull/523 and https://github.com/NVIDIA/cuCollections/pull/422) and need to move back the code.

build

build


Upgrade Linux Kernel for flatcar-3850 from 6.6.12 to 6.6.15

Subject says it all.

Closing in favor of https://github.com/flatcar/scripts/pull/1625


skid

skid

Not an owner, but what is the reason for this issue?

Not an owner, but what is the reason for this issue?

Hey,
I hope I can correct a little bit here.
Yeah, it's just really sad. He's the only skid. So here's the explanation for everyone. And I think I will leave this Issue open to show eversone who he really is:
So, I randomly joined his Discord, I think I found it through one of his old tools called Moon-Grabber which wasn't actually his. He just copied all the files from W4SP and changed it's name +  every line that gave credits to loTus (the main creator of W4SP-Stealer). Then he told everyone it was his tool. Without giving credits or anything. A few weeks later yuvi quit, because his GitHub account has been permanently banned. The one who created this is his new one. He told me he wouldn't create a new one and I could have the project.
 And I know I'm not exactly harmless. I already had repositories with malware and have also skidded a thing myself, but have already deleted the malware repository and now give credits everywhere or try to create a lot myself.
Thanks for reading this, hope it explains everything :)


Panel has its dates "stuck" after specific manipulation

Have a range setup on the rangepicker.
Open the panel.
Choose a date before the current from date on the right calendar (this will update the "to" date)
cancel panel
reopen panel: the date previously selected is seen as the "from" date and dates can't be changed by click anymore

manually changing the "from" date in the field gets the panel back to normal.
px-rangepicker v1.3.6
Call stack:
Uncaught TypeError: Cannot read property 'isAfter' of null
at HTMLElement._getEndDate (px-calendar-cell.html:184)
at HTMLElement._isEndOfRange (px-calendar-cell.html:166)
at HTMLElement. (px-calendar-cell.html:126)
at Debouncer.complete (polymer-mini.html:2073)
at Debouncer.boundComplete (polymer-mini.html:2050)
at Object._atEndOfMicrotask (polymer-mini.html:2028)

Cannot reproduce in current version v3.3.2
Reopen if you are still seeing this issue


Zooming is too fast on Apple trackpad

Hi OpenJSCAD,
It's really hard to control the zoom action on my Macbook.  I've confirmed that this behavior doesn't occur on a non-apple machine-- It seems probable that this has to do with different sampling rates.
Other projects have encountered this problem as well.  See: https://github.com/darsain/sly/issues/67, https://github.com/Prinzhorn/skrollr/issues/278.

Hi @alexose !
I have an updated set of controls that should alleviate that, I will create PR soon, thanks for the links, very useful !

Thank you!  I look forward to it.


behnaz/gp mt5 sp pt mt5webtrader

Hi @behnaz-deriv ,  can you check "WThis", is this intended?


GDNative no longer working

All I did was pulled latest commits for Godot
Godot Engine v3.2.alpha.custom_build.4569f5ec8 - https://godotengine.org
OpenGL ES 3.0 Renderer: GeForce GTX 1650/PCIe/SSE2
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /lib/x86_64-linux-gnu/libc.so.6(+0x46470) [0x7f14e5b2e470] (??:0)
[2] godot() [0xb945a8] (/home/rameshravone/Works/godot/./core/string_name.h:110)
[3] godot::ARVRAnchor::___init_method_bindings() (??:0)
[4] godot::___init_method_bindings() (??:0)
[5] godot() [0x94f836] (/home/rameshravone/Works/godot/modules/gdnative/gdnative.cpp:373)
[6] godot() [0x95da13] (/home/rameshravone/Works/godot/modules/gdnative/nativescript/nativescript.cpp:?)
[7] godot() [0x95bf8e] (/home/rameshravone/Works/godot/modules/gdnative/nativescript/nativescript.h:297)
[8] godot() [0x96afa5] (/home/rameshravone/Works/godot/./core/reference.h:277)
[9] godot() [0x2b729b3] (/home/rameshravone/Works/godot/./core/variant.h:418)
[10] godot() [0x2bfeb14] (/home/rameshravone/Works/godot/core/object.cpp:422)
[11] godot() [0x2508a38] (/home/rameshravone/Works/godot/scene/resources/resource_format_text.cpp:603)
[12] godot() [0x2e78a3e] (/home/rameshravone/Works/godot/core/io/resource_loader.cpp:199)
[13] godot() [0x967c97] (/home/rameshravone/Works/godot/modules/gdnative/nativescript/nativescript.cpp:1741)
[14] godot() [0x2e7ab01] (/home/rameshravone/Works/godot/./core/cowdata.h:370)
[15] godot() [0x2e7b717] (/home/rameshravone/Works/godot/./core/reference.h:270)
[16] godot() [0x480225] (/home/rameshravone/Works/godot/./core/cowdata.h:370)
[17] godot(main+0x8d) [0x447c1d] (/home/rameshravone/Works/godot/platform/x11/godot_x11.cpp:55)
[18] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf3) [0x7f14e5b0f1e3] (??:0)
[19] godot() [0x447ace] (??:?)
-- END OF BACKTRACE --
Aborted (core dumped)
make: *** [Makefile:11: rungame] Error 134

It's cause by https://github.com/godotengine/godot/pull/33210 (breaking change in the pool array API), rebuild godot-cpp and your libs with the fresh headers and gdnative_api.json from the engine, to fix.


Use TKinter if possible

Most python deployments have TKinter. This should be way more portable than usage of gtk / qt / xclip and xsel as well a much faster than popen
try:
    from Tkinter import Tk
except ImportError:
    from tkinter import Tk

def clip_set(text):
     r=Tk()
     r.withdraw()
     r.clipboard_clear()
     r.clipboard_append(text)
     r.destroy()

def clip_get():
     r=Tk()
     r.withdraw()
     ttt = r.clipboard_get()
     r.destroy()
     return ttt

I have tested your code in arch linux with tk 8.6.4. It didn't change system clipboard.
Maybe these methods work only with Tk clipboard.

Right you are. I have forgotten to test it outside of interpreter ...


Create composer.json with Google\Protobuf dep

Expected Behavior
To publish this as a package and install the Google\Protobuf dependency we need a composer.json.
Reported by @grayside
Actual Behavior
No composer.json exists.

We're not supporting PHP with the event libraries right now.

Re-triaged this issue. Also created a PR.


NFTs no longer showing under collectibles.

As of yesterday my NFTs are no longer showing up in my NAMI wallet. I'm using a hardware wallet with this NAMI account. When I look on pool.pm the NFTs still show up. i deleted the wallet and restored but the issue was not resolved. I also transferred another NFT from secondary NAMI wallet as a test and that NFT did show under my NAMI hardware wallet account. How do I resolve this issue to gain access to my NFTs? Thanks!

Wow great support

Have you able to resolved your issues? @DogPro88


Add examples for publish:azure scaffolder action

Hey, I just made a Pull Request!
I've seen issue #18832 and wanted to add examples for publish:azure.

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Question: Do I need to write tests for this? I've seen some scaffolder examples with tests while others have no tests.

Question: Do I need to write tests for this? I've seen some scaffolder examples with tests while others have no tests.

Hi @MarcBuch, tests would be awesome to have, they would help validate the action works with the given parameters. There are already some tests you can build off from so you won't have to start from scratch 👍

@awanlin done

Thanks again @MarcBuch and @Rugvip for the review and merge 🚀


feature: allow binding directly to data-element

Previously, the data-element attribute could be added to any element, and that element would be removed if it did not have any other bind operation performed on it.
For example, on

, if there was no bind to the message key, such as bindKeyValue("message", "Hello, World!");, the element was removed.
This new functionality means that you can add a value to the data-element attribute, and it can now be bound like any data-bind attribute. For example:

There was an error

function go(Binder $binder):void {
  $binder->bindKeyValue("errorMessage", true);
}

Updated the docs at https://github.com/PhpGt/DomTemplate/wiki/Automatically-remove-unbound-elements-with-`data‐element`


AGI does not aggregate for producing totals

AGI produces graphs based onthe time in the logs. This means, the series may have misaligned data points. This makes it impossible to produce totals on any graph. The request is to allow aggregation-by-time transformation in the plugin. This would take the values in the time interval across multiple series and aggregate by time-range, produce a "total" series.

Setting as enhancement request as this was not in the original spec. While it would be a nice addition for totalling for example all client transactions from all nodes, it is not a hard requirement for troubleshooting.


Fix/model fulfillment request

Priority
Yes, blocking my job, but I'm now using this fork in package.json
What Changed & Why
Please see #42 (Workaround 2)
Bug/Ticket Tracker
=> #42

Hey @Nainterceptor thanks for the PR.
This solution looks ok to me.
Could you please:

fix your formatting (use standard)
add a test that serves as an example for injecting a model name into a raw request
update the readme to use this example where we currently have the raw request that doesn't actually work
change the error message to 'Model parameter is mandatory!'

Cheers!


Usability problem with new service port checks after upgrade.

After upgrading a cluster with many apps which might have the same service port allocated from before the update (bad configuration, but note that the ports might not be used),
I cannot restart any app as the check is checking all service for all apps -not just the one I upgraded...
I would expect that when upgrading a cluster with many apps, it forces me to only update the app I want to restart, but not all other apps which are running in the cluster.

cc/ @aquamatthias

Fixed through #4172


Do not crash when dragging ReorderableListView  with two fingers simultaneously

Fixes #88191
When the two pointers start dragging simultaneously, it will happen that two MultiDragGestureRecognizer wins simultaneously and lead to an assertion(assert(_dragInfo == null);).
Fix solution: If a recognizer is created by another pointer, it will be destroyed before adding the new recognizer.

Gold has detected about 3 new digest(s) on patchset 7.
View them at https://flutter-gold.skia.org/cl/github/88508


swift-foundation is incompatible with windows UCRT when C++ interoperability is enabled

Description
New swift-foundation that swift-corelibs-foundation is based on is broken on windows when C++ interoperability is enabled, as it imports and builds the entire ucrt module which has a restriction on the C.complex submodule:
<module-includes>:1:10: note: in file included from <module-includes>:1:

1 | #include "_FoundationCShims.h"

  |          `- note: in file included from <module-includes>:1:

2 |

C:\Users\runner\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\include\_FoundationCShims/_FoundationCShims.h:17:10: note: in file included from C:\Users\runner\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\include\_FoundationCShims/_FoundationCShims.h:17:

15 |

16 | #include "_CShimsTargetConditionals.h"

17 | #include "_CStdlib.h"

   |          `- note: in file included from C:\Users\runner\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\include\_FoundationCShims/_FoundationCShims.h:17:

18 | #include "CFUniCharBitmapData.inc.h"

19 | #include "CFUniCharBitmapData.h"

C:\Users\runner\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\include\_FoundationCShims/_CStdlib.h:23:2: note: in file included from C:\Users\runner\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\include\_FoundationCShims/_CStdlib.h:23:

 21 |

 22 | #if __has_include(<ctype.h>)

 23 | #include <ctype.h>

    |  `- note: in file included from C:\Users\runner\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\include\_FoundationCShims/_CStdlib.h:23:

 24 | #endif

 25 |

<unknown>:0: error: could not build C module '_FoundationCShims'

C:\Users\runner\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\share\ucrt.modulemap:15:12: error: module 'ucrt.C.complex' is incompatible with feature 'cplusplus'

 13 | module ucrt [system] {

 14 |   module C {

 15 |     module complex {

    |            `- error: module 'ucrt.C.complex' is incompatible with feature 'cplusplus'

 16 |       /* disallow the header in C++ mode as it forwards to `ccomplex`.  */

 17 |       requires !cplusplus

Reproduction
import Foundation and enable C++ interop, windows host.
Expected behavior
It should work.
Environment
swift main
Additional information
No response

I will look into it.

will this fix land in a release/6.x snapshot?

Can confirm this appears to be fixed in the September 6 main snapshot.


include version info in bulk indexing

Currently, any potential _version or _version_type field were not included in the _bulk indexing action meta, effectively not importing the documents in the exact state as they were dumped. This PR adds the field along the other document meta fields (i.e. ttl, routing, etc.).
PS: Let me know if I should add any extra tests, though I didn't find anything related for fields like e.g. ttl. I can also add a small example on how to dump documents with the _version field and then import them by picking a version_type through using the --transform option.

leaning towards making these options. passing in via params. The thing is, not everyone want the version/version_type to be exported.

Exporting the version has to be done explicitly via adding e.g. --params='{"version" : true}'. The problem was the loading part which was done via something like --transform='doc._version_type="external_gte"'.
I'm not sure if adding these as standard options is the right choice, as there might be more cases I'm not aware of, which I hope are already possible via some combination of --params/--transform.
Here's an example of dump/restore commands:
# Dump
elasticdump \
    --params='{"version" : true}' \
    --input=https://localhost:9200/some-index \
    --output=some-index.json

# Restore (this one requires this PR to actually work)
elasticdump \
    --transform='doc._version_type="external_gte"' \
    --input=some-index.json \
    --output=http://localhost:9200/some-index

What i meant was adding an additional option.
elasticdump \
    --transform='doc._version_type="external_gte"' \
   --parseExtraFileds='version,version_type'
    --input=some-index.json \
    --output=http://localhost:9200/some-index

This way if someone wants to export a new meta-property we don't have to create a new release.

closed by #478


Determine list of TGCA samples with events that overlap the gene-panel.

I had come with the following 30 samples list.
For this, first I found those events in the GenomeSTRiP output file that overlap with the eMerge targets (needed to clean their file up as some of the targets therein overlap).
Then I only consider event with a frequency equal or less than 5% and that they are not multi-allelics.
The list below are the sample names with the number of qualifying events for which they have a non-ref call:

      2 TCGA-05-4396-10A-01D-1855-08
      2 TCGA-06-0157-10A-01D-1491-08
      1 TCGA-06-2570-10A-01D-1495-08
      2 TCGA-14-2554-10A-01D-1494-08
      4 TCGA-41-5651-10A-01D-1696-08
      3 TCGA-44-6148-10A-01D-1753-08
      1 TCGA-50-5066-10A-01D-1625-08
      1 TCGA-64-1680-10A-01D-1040-01
      3 TCGA-67-6215-10A-01D-1753-08
      7 TCGA-78-7146-10A-01D-2036-08
      4 TCGA-78-7156-10A-01D-2036-08
      5 TCGA-78-7535-10A-01D-2063-08
      3 TCGA-85-8052-10A-01D-2244-08
      1 TCGA-92-8064-10A-01D-2244-08
      1 TCGA-BJ-A28V-10A-01D-A19M-08
      3 TCGA-BR-8373-10A-01D-2341-08
      2 TCGA-CD-8529-10A-01D-2341-08
      1 TCGA-D7-8570-10A-01D-2341-08
      2 TCGA-DJ-A2Q1-10A-01D-A19M-08
      1 TCGA-E1-5319-10A-01D-1893-08
      1 TCGA-EE-A3JI-10A-01D-A21A-08
      1 TCGA-EM-A3AQ-10A-01D-A20C-08
      1 TCGA-ER-A3ES-10A-01D-A20D-08
      1 TCGA-FK-A3SE-10A-01D-A22D-08
      1 TCGA-G9-6365-10A-01D-1786-08
      1 TCGA-HC-7075-10A-01D-1961-08
      9 TCGA-HC-7740-10A-01D-2115-08
     17 TCGA-HC-7744-10A-01D-2115-08
      1 TCGA-HC-8258-10A-01D-2260-08
      1 TCGA-HT-7602-10A-01D-2086-08

I have not filtered based on the number of covered targets per event; most events are just 1 target long.
There is a total of 23 events:

CONTIG	START	END	CALL	NTARGETS	FREQ
1	98189364	98367000	-	1	0.0118
1	152281652	152285321	-	1	0.0118
2	40964269	41009870	-	1	0.0235
4	3467857	3473907	+	1	0.0176
4	135131038	135144309	-	1	0.0235
5	1278704	1282903	+	1	0.0059
5	117481014	117533455	-	2	0.0353
5	137414773	137438999	+	1	0.0235
7	117433225	117461146	+	1	0.0059
9	132573663	132583864	+	1	0.0176
11	25218746	25281154	-	1	0.0353
11	115114026	115215423	-	1	0.0118
11	126233892	126246747	+	1	0.0235
11	126241786	126243947	+	1	0.0353
11	126243948	126248222	+	1	0.0353
16	15798209	15950545	+	41	0.0118
16	58680867	58683738	+	1	0.0118
17	794232	801799	+	1	0.0176
17	79571368	79630302	+	1	0.0059
18	52875546	52956230	-	11	0.0176
19	54504608	54513753	+	1	0.0412
20	44348793	44354658	-	1	0.0353
21	35670115	35991982	-	3	0.0059

@davidbenjamin @LeeTL1220 please comment.

Well, a 30 sample list is okay.  When you say,

Then I only consider event with a frequency equal or less than 5% and that they are not multi-allelics.

Were you referring to 5% in the 170 samples or 5% in the general population?  I assume the former, but want to make sure.

the former

@vruano @davidbenjamin I am trying to get all 170 sequenced.

Working it out.  List has been sent.


zetacore : allow operators to add votes to older keygen ballots without affecting the keygen status

Points to note regarding the current logic

The Keygen status is set to success or failed only when the ballot is finalized, and the threshold for that is 1, meaning everyone on the ballot has already voted.
We distribute observer rewards for voting on ballots, and we want signers to be able to add votes to get the rewards for their votes

Considering refactoring the post-vote addition logic as below
ballot, isFinalized := k.CheckIfFinalizingVote(ctx, ballot)
if !isFinalized {
    return &types.MsgVoteTSSResponse{
       VoteFinalized: isFinalized,
       BallotCreated: ballotCreated,
       KeygenSuccess: false,
    }, nil
}

if keygen.Status != types.KeygenStatus_PendingKeygen {
    return &types.MsgVoteTSSResponse{}, nil
}

This would enable voters to add votes to ballots that were discarded for some reason.

THe original audit finding which led to this change


How to conditionally disable IOS banner notification in foreground

Hi @evollu ,
I have notifications working in all app states, but I would like to conditionally disable the banner notification when on a certain screen. I have it working in Android since FCM.presentLocalNotification is what triggers the banner notification in foreground. But on IOS I can't it figure out, is it something to do with notif.finish(WillPresentNotificationResult.All) ?
I've searched quite a bit in the issues here and I still don't know. Can you please explain what part of the js code causes the banner to show in IOS when in foreground? Or better yet how to disable it conditionally?
This is a remote notification btw.
Thanks,

What version of RN and react-native-fcm are you running?
"react-native": "^0.54.3",
"react-native-fcm": "^12.0.0",

What device are you using? (e.g iOS9 emulator, Android 6 device)?

IOS iphone 6s

Is your app running in foreground, background or not running?

Foreground

check example code here
https://github.com/evollu/react-native-fcm/blob/master/Examples/simple-fcm-client/app/Listeners.js#L54
if you return notif.finish(WillPresentNotificationResult.None) it won't show notification

nice thanks!

@evollu  what   notif.finish(WillPresentNotificationResult.All) means?

@sfm2222 https://developer.apple.com/documentation/usernotifications/unusernotificationcenterdelegate/1649518-usernotificationcenter?language=objc


Explanation of CNAME + RDC

Issue in ./help/technotes/rdc/regional-data-collection.md
Documentation explains how RDC restriction is possible when using AppMeasurement. However, there is information missing which explains how CNAME can be used as part of Web SDK setup, in order to restrict edge locations that are used (i.e. EU only, NA only etc). Context is that a lot of customers ask the question "how can we ensure we only collect, process & store data in EU locations?". So this CNAME-based edge location restriction is a critical part of achieving that with CJA but currently it's not clear for customers that this is possible

Hi @alexbishop010 - here is your answer from the PM:
The RDC setup for Web SDK is identical to Analytics. Both use the same architecture to receive hits. The routing to AA or Konductor actually happens later. The RDC setup for Web SDK is identical to Analytics. Both use the same architecture to receive hits. The routing to AA or Konductor actually happens later.
The only difference is that there is no China RDC for Edge. That collection route is specific to Analytics.
I hope that helps.


[Mention The Feature]: Add hovering effect on footer

Is your feature request related to a problem? Please describe.
Adding hovering effect over quick links and fixing the hovering effect over social icons.
https://github.com/user-attachments/assets/515b5503-2189-4480-a3ce-81bffcb375e7
Describe the solution you'd like.
No response
Describe alternatives you've considered.
No response
Additional context.
No response
Show us the magic with screenshots
No response
Checklist

[X] I have checked the Existing Issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

Already assigned


[BugFix]Backport pr 31747 to branch 3.1

Why I'm doing:
forget backport pr: https://github.com/StarRocks/starrocks/pull/31747/files to branch-3.1
What I'm doing:
manually backport pr: https://github.com/StarRocks/starrocks/pull/31747/files to branch-3.1
Fixes #issue
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

#31747