feat(@angular/pwa): add content for when javascript is not available

Adding this line to the body will give us a 100 score in lighthouse for PWA.

Hosted site (with added <noscript> tag): https://angular-cli-pwa.firebaseapp.com/
Thanks so much to @Brocco for providing a great example to follow for manipulating the html file. A few of the updates are to make the variable names more semantic given the similar usage.

@markgoho Nitpicking: Could you change the casing of Javascript to JavaScript? That would be excellent. Thank you.

@christianliebel will change later today 👍


[Remove] LegacyESVersion.V_7_2_* and V_7_3_* constants

Removes all usages of LegacyESVersion.V_7_2_ and LegacyESVersion.V_7_3 version constants.
relates #2747

The test failure is fixed by #2768 which is ready for review / merge.

Codecov Report

Merging #4702 (cb3110c) into main (a2f95ce) will increase coverage by 0.01%.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##               main    #4702      +/-   ##
============================================
+ Coverage     70.61%   70.63%   +0.01%
+ Complexity    57622    57585      -37
============================================
  Files          4661     4660       -1
  Lines        277144   276970     -174
  Branches      40546    40466      -80
============================================
- Hits         195719   195636      -83
+ Misses        64988    64954      -34
+ Partials      16437    16380      -57

Impacted Files
Coverage Δ

.../src/main/java/org/opensearch/LegacyESVersion.java
68.69% <ø> (-2.14%)
:arrow_down:

...ode/hotthreads/TransportNodesHotThreadsAction.java
9.09% <ø> (ø)

...in/cluster/node/info/TransportNodesInfoAction.java
100.00% <ø> (ø)

...load/TransportNodesReloadSecureSettingsAction.java
8.62% <ø> (ø)

.../cluster/node/stats/TransportNodesStatsAction.java
100.00% <ø> (ø)

.../cluster/node/usage/TransportNodesUsageAction.java
23.80% <ø> (ø)

...napshots/status/TransportNodesSnapshotsStatus.java
6.06% <ø> (ø)

...min/cluster/stats/TransportClusterStatsAction.java
70.83% <ø> (ø)

...ion/admin/indices/alias/IndicesAliasesRequest.java
73.79% <0.00%> (+2.12%)
:arrow_up:

...s/close/TransportVerifyShardBeforeCloseAction.java
68.75% <0.00%> (+4.04%)
:arrow_up:

... and 513 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Needs a rebase, thx.

Reproducible test failure introduced in #4669
REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.OpenSearchExceptionTests.testFailureToAndFromXContentWithNoDetails" -Dtests.seed=95EAFFE028A5D654 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=mt -Dtests.timezone=Antarctica/Palmer -Druntime.java=17

org.opensearch.OpenSearchExceptionTests > testFailureToAndFromXContentWithNoDetails FAILED
    org.junit.ComparisonFailure: expected:<...exception, reason=In[valid argument]]> but was:<...exception, reason=In[ternal failure]]>
        at __randomizedtesting.SeedInfo.seed([95EAFFE028A5D654:99BA15775F82EA2C]:0)
        at org.junit.Assert.assertEquals(Assert.java:117)
        at org.junit.Assert.assertEquals(Assert.java:146)
        at org.opensearch.OpenSearchExceptionTests.testFailureToAndFromXContentWithNoDetails(OpenSearchExceptionTests.java:818)

Documented and Fixed in this PR.


Insufficient Permission Issue when trying to change /pwarp name.

Describe the bug
Trying to change /pwarp name gives you a insufficient permission message.
To Reproduce
Steps to reproduce the behavior:

Type /pwarp
Go to manage my warps.
Right click to edit, Click "Rename warp"
Rename warp. However it says "Insufficient Permission"

Expected behavior
To be able to type Nagamichi Town Mall and the /pwarp name will change to said name.
Screenshots

Username:
Strideii
Server name (all applicable):
Orion

@StrideMate and @Deathnight7976 do you still have this issue?  I tested on Orion and was able to make a pwarp and change the name with no issues.

Seems to be fixed!  Closing!


Msch pre init proxy

Code review checklist

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[x] Commit messages are meaningful (see this for details)
[x] Tests have been included and/or updated
[ ] Docstrings have been included and/or updated, as appropriate
[ ] Standalone docs have been updated accordingly
[ ] Changelog(s) has/have been updated, as needed (see CHANGELOG.md, no need
to update for typo fixes and such).

I created a proxy based API for the _(get|set|has)attr methods. You can wrap an object which will give you a proxy object which you can read from and write to using the normal syntax obj.attr, which gets translated behind the scenes into calls to _(get|set|has)attr. Any objects that get returned will equally be wrapped, so first.second.third works fine. If the attribute is a list, tuple, or dictionary a special class is used for wrapping in order to implement the full interfaces for these objects. Things that don't work for these wrapped objects are type(obj) and obj.__class__ (use get_attrs_class(obj) instead), obj.__dict__ (use get_attrs_dict(obj) instead), as well as isinstance(obj, something) (use textx_isinstance(obj, something) instead, which has expanded functionality).
I noticed that textx_isinstance was often imported locally, and I am unsure if I handled this correct in the instances where I added it. I also didn't check if this was necessary in every instance where I replaced isinstance with textx_isinstance.
@goto40 @igordejanovic, I would love to hear your feedback

@markusschmaus Thanks Markus.
Didn't do a deep dive in your implementation so please take these comments with a grain of salt.
If I understand you are wrapping user object into proxies for making a backward compatible API. You are probably not doing unwrapping at the end of the process as that would require reconnecting all references in the object graph.
While proxy wrappers might seems like a good solution they introduce many problems, I think more than they are trying to solve:

The biggest issue with proxy wrappers is runtime overhead, both in memory consumption and in speed (due to indirection) which defies the very purpose of using __slots__ in the first place.

Another issue, maybe even more critical is that users end up with objects which are not actually instances of classes they provided.

Arguably: complexity

If I misunderstood the implementation please correct me.

Objects get wrapped before being handed to to scope providers and unwrapped afterwards.

I tried to time the different access methods and it appears that while the _getattr function is significantly slower than direct access, the access via the proxy doesn't incur additional slowdown. https://gist.github.com/84b77036eccf90c6f0b2c8e2c43ded56. The wrapper class certainly incurs some memory overhead, but only the objects accessed by the scope provider get wrapped and after it returns garbage collection should take care of it. One simple optimization is of course to change the wrapper classes to __slots__ classes. Both memory and speed impact only apply while executing the scope providers
Objects are only wrapped when passed to scope providers and unwrapped afterwards, so users will indeed get objects of the classes they provided
That's a fair argument

@markusschmaus Thanks for clarification and detailed analysis.
I'm sorry, I misunderstood the implementation. The proxies are used for scoping providers to provide an easier navigation over the object graph while the object returned to the users are the real objects. Sounds good, and the implementation is great.
If we don't hit problems I'm currently more in the favor of #256  as the solution is simpler and should be fully backward compatible.

Superseded by https://github.com/textX/textX/pull/256


HELP !!!!!!! PR= #20555

I'm submitting a NEW Token on solana token-list...
It through auto-merged error on PR. Kindly merged this PR for new token.

{
"chainId": 102,
"address": "5UyMNrQCmXpWkg1Ew7VaTm8fuQXkA5nsaZHo6hKKTBQk",
"symbol": "NOIDA",
"name": "N token",
"decimals": 8,
"logoURI": "https://raw.githubusercontent.com/solana-labs/token-list/main/assets/mainnet/5UyMNrQCmXpWkg1Ew7VaTm8fuQXkA5nsaZHo6hKKTBQk/logo.png",
"tag": [
"social-token"
]
}
i cannot seem to add my coin Can you please help me

please include link to your PR

PR_LINK: https://github.com/solana-labs/token-list/pull/20555

"tag" should be "tags". try again with the fix


release: version 0.9.1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
390

Relevant Lines:
390

💛  - Coveralls


bump version to force an OSX rebuild

OSX build did not succeed with initial build. Attempt to force a new build.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Editorial: Direct abrupt completion suggestion

This brings in just the execution initialization change component from #90 in throwing abrupt completions for all synchronous errors in InnerModuleEvaluation, instead of running through the rejection handler of CyclicModuleExecutionRejected.
I do still prefer to inline the completion handlers in this case as well and specialize them to the async cases only (and will gladly add those changes back), but have kept to the small diff for review.

It turns out this is actually more of an editorial preference in how the executions are handled, so certainly let's stick to the approach originally started in https://github.com/tc39/proposal-top-level-await/pull/76.


Wrap the cancellation token in throttled cancellation token from server

Restores the removal of throttled cancellation token

@uniqueiniquity can you give this a try on your outlining test

much better. back down below 500 ms.


Remove GetX as dependency

This package has great potential, unfortunately it's using GetX as the internal state management.
Probably best to just stick with setState or at most use provider.

I have rewritten it using provider , You can find it here: https://github.com/huuduong99/wrap_and_more


Further donation refactoring

As discussed with @ahmadabdolsaheb there are a few minor improvements we can make to follow up https://github.com/freeCodeCamp/freeCodeCamp/pull/46379, specifically, https://github.com/freeCodeCamp/freeCodeCamp/pull/46379#pullrequestreview-1222780020
In summary

Use stricter types to ensure that postPayment is only ever passed arguments that are compatible with a single payment provider
Create helper functions that can be called by postChargeSaga to handle individual providers and get passed only the data they need

I read through the pr linked above and I think the requested changes were already made in that pr? Or is there more work needed here? @ojeytonwilliams ?

It's still open for a bit of refactoring @jmetev1. There's possibly a nicer solution, but the suggestion I made, https://github.com/freeCodeCamp/freeCodeCamp/pull/46379#pullrequestreview-1222780020, has not been implemented.


Fixes issue with template literal and simple quote

Sorry @justinvdm I let an issue with my last commit. I replaced template literal by string using simple quote without escaping potential simple quote already inside the template literal.

@justinvdm Also I figure out it was silly to use template literal with gettext, because things like
`${foo} is the best`

Will add an entry ${foo} is the best to the .pot whereas the call when running could be anything, like jspot is the best which will found no match in the .pot :(
It is still nice to support template literal for those using template literal everywhere even when simple string suffice, but one cannot use it with all its power with gettext, still need a sprintf above.

@miltontony / @nathanbegbie: hi :) could you perhaps take a look at this?

@justinvdm @miltontony @nathanbegbie any news?

@miltontony @nathanbegbie ?

@justinvdm @JSteunou Apologies, I've been on leave and this fell of my radar,taking a look now

welcome back ;)


Discuss conventions for naming and content (here Quickstart)

The three "QuickStart"s are currently

QuickStart on ARCs
ARC Commander QuickStart
Swate QuickStart

I would suggest to stick to the same naming convention (in titles and articles), e.g.

QuickStart on ARCs or ARC QuickStart
QuickStart ARC Commander  or ARC Commander QuickStart
QuickStart Swate or Swate Quickstart

And to me "Quick Start" implements that the user can follow this to get quickly started. So I would reserve the term for "hands-on" tutorials.
The "QuickStart on ARCs" is more a user story / use-case / user scenario.

@andreaschrader @Martin-Kuhl @CMR248

Added the Hackathon label as it is an aftermath of this and it reminds us of the discussion there related to the reordering of the sidebar also after a break.
Both points agreed on from my side.
I suggested the "QucikStart on ARC" ... version as this improves to find the Quickstarts in the sidebar on one glance.
We could eventually have one QuickStart for all, also for DataHUB and DataPLAN if possible. Is this feasible to add this to the knowledgebase?

We could eventually have one QuickStart for all, also for DataHUB and DataPLAN if possible. Is this feasible to add this to the knowledgebase?

Yes and yes! We should get started to (draft) write those contents and invite the respective people to contribute.

Added the Hackathon label as it is an aftermath of this and it reminds us of the discussion

I was honestly going to ask, if we still need the hackathon label as it looks like we didn’t finish up on those tasks and it’s not really saying anything. :)
Next time we could formulate a Hackathon Milestone.

I guess this issue is finished, or @Brilator

IMO the different uses of „quickstart“ is not solved.
The Quickstarts to ARC Commander and Swate are conceptionally different

ARC C: Follow these exact steps to come to a clear goal.
Swate: These are things you can do, try out yourself.

Okee. I understand. Do we need to discuss this point collectively in the JF?

@Brilator Yes, but I doubt that it is useful to supply a similar quickstart for Swate as for the ARC Commander, as the first steps for the AC are almost always identical. In Swate it makes more sense to give a quick overview on the options you have in Swate. Maybe we just need to rename the quickstart for Swate?
Or maybe rename it and provide additionally a minimal example for Swate.

Or maybe rename it and provide additionally a minimal example for Swate.

I'd suggest to do that. With a few example terms and tasks, that definitely work well. Instrument model -> pick from list. Temperature, add unit. File picker -> add your files, etc.


Table showing distributions/versions in which ADE is supported is outdated

Table showing distributions and versions in which Azure Disk Encryption is supported is outdated (https://docs.microsoft.com/en-us/azure/virtual-machines/linux/disk-encryption-overview#supported-operating-systems).
At least OpenLogic:CentOS:7.2n:latest doesn't exist. And there are newer versions on which ADE is probably supported but are not enumerated in that list.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 358673f9-fd9a-3357-bf50-4d9b7fbe6cc6
Version Independent ID: a4978908-6539-17f7-8fb6-3d88cad7237c
Content: Enable Azure Disk Encryption for Linux VMs - Azure Virtual Machines
Content Source: articles/virtual-machines/linux/disk-encryption-overview.md
Service: virtual-machines
Sub-service: disks
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@nachoalonsoportillo Thank you for bringing this to our attention!  We are reviewing the table in the documentation and will get back to you shortly.

Seems the page has since been updated so I will close this out. If issues are still present, just let me know.
#please-close


Remove misleading pages, add updated troubleshooting guides

Proposed changes

Update v2.5 and v2.6 "Troubleshoot DTR" pages based on RethinkCLI removal from RethinkDB image

Deploy preview for docsdocker ready!
Built with commit 7881024eed5975028995ba1d350c4de7cc6cbcdf
https://deploy-preview-8320--docsdocker.netlify.com

I have rebased and squashed - I updated the TOC entries for DTR 2.6 and 2.5. Can you please have a final look, @ingshtrom ?

@bermudezmt I'm still not seeing updated on the netlify app listed originally. Will a new one become available or should the original one be updated?

@ingshtrom - Hi  Alex - I just updated the TOC titles - you should see them in preview shortly. Thank you for your help!


problem with update

I updated my editor to the latest code from develop branch and now I'm getting
this.getContentElement(...).getNativeElement is not a function

on AbstractScrollPane.js:123.
This happens immediately after the page load and first selection. Not sure why that is happening and maybe you have some tips.
Full stack trace:
Uncaught TypeError: this.getContentElement(...).getNativeElement is not a function
    at BodyScrollPane._getContentRect (http://localhost:5555/app.js:37545:37)
    at BodyScrollPane._onDomSelectionRendered (http://localhost:5555/app.js:37453:28)
    at BodyScrollPane._onDomSelectionRendered (http://localhost:5555/app.js:37793:61)
    at ContainerEditor.send (http://localhost:5555/app.js:15653:38)
    at ContainerEditor.rerenderDOMSelection (http://localhost:5555/app.js:41799:14)
    at SurfaceManager._recoverDOMSelection (http://localhost:5555/app.js:6908:20)
    at EditorSession._notifyObservers (http://localhost:5555/app.js:18024:19)
    at http://localhost:5555/app.js:17939:14
    at Array.forEach (native)
    at EditorSession.performFlow (http://localhost:5555/app.js:17938:22)```

Hey I don't see this problem when using the BodyScrollPane. Do you have code we could run to see what's happening?

Ok, I see what the problem was.
I had local copy of BodyScrollPackage, don't remember for what reason.
And since API changed a bit it didn't work after the updates.


race condition in io_uring scheduler

One of my local test runs yielded this:
[ctest] 579/579 Test #575: After -1s .........................................................................................Subprocess aborted***Exception:   0.08 sec
[ctest] test.stdexec: /workspaces/stdexec/include/exec/linux/./__detail/io_uring_context.hpp:280: bool exec::__io_uring::__context::submit(exec::__io_uring::__task*): Assertion `__prev > 0' failed.
[ctest] Filters: After -1s
[ctest]
[ctest] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ctest] test.stdexec is a Catch v2.13.6 host application.
[ctest] Run with -? for options
[ctest]
[ctest] -------------------------------------------------------------------------------
[ctest] After -1s
[ctest] -------------------------------------------------------------------------------
[ctest] /workspaces/stdexec/test/exec/test_io_uring_context.cpp:222
[ctest] ...............................................................................
[ctest]
[ctest] /workspaces/stdexec/test/exec/test_io_uring_context.cpp:222: FAILED:
[ctest]   {Unknown expression after the reported line}
[ctest] due to a fatal error condition:
[ctest]   SIGABRT - Abort (abnormal termination) signal
[ctest]
[ctest] ===============================================================================
[ctest] test cases: 1 | 1 failed
[ctest] assertions: 2 | 1 passed | 1 failed
[ctest]
[ctest]
[ctest]
[ctest] 99% tests passed, 1 tests failed out of 579
[ctest]
[ctest] Total Test time (real) =   0.78 sec
[ctest]
[ctest] The following tests FAILED:
[ctest] 	575 - After -1s (Subprocess aborted)
[ctest] Errors while running CTest

attn: @maikel

Can you tell me which compiler and which compile options you used?

I could reproduce it once on my machine. Looking :mag: 👀

Luckily, this was an error which I already fixed in PR #815
This happened:

io_thread: the io thread starts and attempts to run the io_uring context
main thread: Meanwhile a schedule_after op enters the game and submits itself into the context, it increases the __n_submissions_in_flight_ from 0 to 1
io_thread: We enter run and set unconditionally (caution this is the error) __n_submissions_in_filght to 0
main thread: We have pushed the op to the atomic intrusive queue and decrease the __n_submissions_in_flight counter... oh its already 0, the assertion fires

The solution is to reset the __n_submission_flight in step 3 only if it was __no_new_submissions before.
I love assertions. :heart:

Can this be closed?


13.3.2> versions (+ others) of cypress/included were updated 15 days ago

https://hub.docker.com/r/cypress/included/tags?page=1
Every version13.3.2 (and more versions) of cypress/included has been updated 15 days ago. Was this a mistake. Where are the release notes for this? This is causing failures in CIs:
ERROR  Unable to resolve cypress configuration

make sure that 'cypress-cloud/plugin' is installed
report the issue together with cypress stdout and stderr

@HarryAnkers There were updates which is covered in this blog post. If you're using the cypress-cloud plugin, you'll need to remove it and all configuration files/settings in order to continue to run Cypress.


Is there a usesable Helvetica korean font?

We used only handwriting Korean fonts, so we did not use it.


[bug] unable to connect to an http based socketio server

it can't connect to this socketio server
https://github.com/msgbyte/tailchat/blob/master/server/mixins/socketio.mixin.ts#L542-L550
even with disable msgpack parser

Can you please give more context? E.g. what error are you observing.

It's file, it's mine problem
whish you have a happy day(


NamedExec cannot handle column names with hyphens

I have a database column defined as :
`NS-Var-ID` char(50) DEFAULT NULL,

I have a struct with
NSVarID         string         `db:"NS-Var-ID"`

Trying to use NamedExec with this name fails, something like this:
q := "INSERT INTO table (`NS-Var-ID`) VALUES (:NS-Var-ID)"
_, err := dstDbh.NamedExec(q, d)

panic: could not find name NS in ...........

I have tried all sorts of quoting, but I am unable to find anything that works. The biggest downside is that Im unable to use batch inserting which seems to only be supported by NamedExec.

When you have a dash in a tag, the Go sqlx package's name mapper treats it as a word separator. Therefore, "NS-Var-ID" is being interpreted as three separate words: "NS", "Var", and "ID". Unfortunately, it is not possible to escape the dashes in the tags.
If you can, change the column name to not include dashes.
Alternatively
q := "INSERT INTO table (`NS-Var-ID`) VALUES (?)"
_, err := dstDbh.Exec(q, d.NSVarID)

@richardvk if you have no more questions, please close this issue.

Thanks for the help and explanation. If anyone else is interested, I solved this with
SELECT NS-Var-ID AS ns_var_id FROM table

so that i could create my struct as
NSVarID         string         `db:"ns_var_id"`

This then worked fine, bearing in mind I specifically wanted to use NamedExec to do batch inserts with a slice of db rows:
q := "INSERT INTO table (`NS-Var-ID`) VALUES (:ns_var_id)"
_, err := dstDbh.NamedExec(q, d)


Develop

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 65.878%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
585

Relevant Lines:
888

💛  - Coveralls


Adding family_name and given_name to person serializer

Looks like I missed a couple new fields from pupa. Is there anything else that is going on over there that we should be looking at here?
Also, any chance we can get this merged ASAP? Thanks @paultag and @jpmckinney

I added these to Pupa, but didn't update Imago. Looks fine to me!

Hey, thanks for this.

Awesome, thanks!
On Fri, Sep 18, 2015 at 11:40 AM, Eric van Zanten<EMAIL_ADDRESS>wrote:

Hey, thanks for this.
—
Reply to this email directly or view it on GitHub
https://github.com/opencivicdata/imago/pull/67#issuecomment-141485737.

--
:wq


Refactor Volume control, allow for a fixed volume option

This is a (long) overdue follow up to https://github.com/librespot-org/librespot/pull/286#issuecomment-509263437.
I have refactored the old --linear-volume flag to a more generic --volume-ctrl option that takes the options of [linear, log, fixed]. It defaults as previously to log.
What fixed does is disable the client side volume control, by setting kVolumeSteps to 0, so no volume events are passed to the client.

As usual, this will need a update of the wiki, and should be considered a "breaking change" when considering the versioning.
Fixes #48, Closes #286

Thanks for this, will give it a test. W.R.T the breaking aspect, we might have to hold off merging this for a bit. We might be best off considering this for the v1 release, along with #134. Also, at some point we need to start thinking about fleshing out librespotd, and stabilising librespot as the core library. That way changes such as these can be added to the former without breaking the latter.

@sashahilton00 just to clarify the "breaking" change here would be the flag passed into the binary, and the VolumeCtrl enum that libraries using spirc will need.
Not sure if this would be considered a version bump, and we are still merging to the dev branch anyway..

This can be reviewed and merged to dev now that v0.1.2 is released.

@ashthespy since the docs are broken and shouldn't really be, I think we can just merge this into dev along with #504 (assuming this is actually a fix) and release it as v0.1.3 - let's face it, we're not exactly rigorously sticking to semver atm ;)

Sounds like a plan, I'll fix the conflicts later today.

Rebased on dev, and fixed the conflicts. I was a bit trigger happy with the merge, but it should be all good now. Wiki has also been updated.


fix: Add hover colour on confirm button in delete WI modal

fix: Add hover colour on confirm button in delete WI modal
#571

Current coverage is 60.95% (diff: 100%)

Merging #573 into master will not change coverage

@@             master       #573   diff @@
==========================================
  Files            33         33
  Lines          1688       1688
  Methods         343        343
  Messages          0          0
  Branches        337        337
==========================================
  Hits           1029       1029
  Misses          659        659
  Partials          0          0

Powered by Codecov. Last update b370955...4d72025

Just a thought:
Can we add these type of css properties in custom.scss or in some other common scss file because in future we may need these same style at many places? So that we can reuse it.

We can add it later if all the buttons need same css...

Ok


about readme

Did you forget to add self as the first arguement in both functions of CLS class in README.md file?
 Thanks pal.

true, thx

2: no, inside class only

Thanks for your answer and plenty of shared neatly written codes :+1:


Upgrade to Spring Security 5 RC1

After upgrading to Spring Security 5, it seems like the Okta Spring Boot Starter isn't working. With the previous version, I was given an error message when I hit localhost:8080.

Now I get prompted with a login screen.

Any ideas @bdemers?

Not 100% sure on the specifics, but it looks like this is related to the restructuring of the OAuth support in Spring Sec 5


Plaintext List of Domains?

Please consider creating an option that has one domain per line.
(no filtering rules, e.g. no || at start of line)

Thanks so much 🍰


forc new and forc init should match cargo new and cargo init behaviour respectively

Currently forc init acts more like cargo new. We should change it to forc new, and then add a new forc init command that behaves like cargo init.
Adding critical label as this is a large breaking change that should be done before we start getting more users.
cc @JoshuaBatty @adlerjohn does this sound OK?

@mitchmindtree @JoshuaBatty

Are there any default flags/opts we want from cargo init, as a merge-able MVP?
https://doc.rust-lang.org/cargo/commands/cargo-init.html

Those flags sound good to me @ra0x3.


Adding IrokoTv and Paga to the doc

@Chaos10001 Please resolve your conflicts in the techCompanies.js file


feat: Support bill query, get the balance of the current token

target api
https://api.openai.com/dashboard/billing/credit_grants

This API is not documented. It may be unofficial.
Refs: https://community.openai.com/t/get-the-remaining-credits-via-the-api/18827/5


Signing transaction bug when required signatures is greater than one.

I'm trying to make a transaction where I pay fee for another user's transfer.
txBuilder := solana.NewTransactionBuilder()
transferInstruction := token.NewTransferCheckedInstruction(100, 6, userMintAccountPublicKey, mint, destinationMintAccountPublicKey, userPublicKey, nil).Build()

sendTransaction, err := txBuilder.
		AddInstruction(closeInstruction).
		SetFeePayer(feePayerWallet.PublicKey()).
		SetRecentBlockHash(blockHash.Value.Blockhash).
		Build()

In this case because the fee payer and the user are actually different wallets, the transaction needs two signatures.
So I sign the transaction using both the feePayer and the owner of the account I'm transferring from as follows
	sendTransaction.Sign(func(key solana.PublicKey) *solana.PrivateKey {
		return &feePayerWallet
	})

	sendTransaction.Sign(func(key solana.PublicKey) *solana.PrivateKey {
		return &userPrivateKey
	})

When I check the transaction signatures, there are four signatures provided instead of just two, the signatures provided are actually just repeating twice. So I checked the Sign function, turns out
func (tx *Transaction) Sign(getter privateKeyGetter) (out []Signature, err error) {
	messageContent, err := tx.Message.MarshalBinary()
	if err != nil {
		return nil, fmt.Errorf("unable to encode message for signing: %w", err)
	}

	signerKeys := tx.Message.signerKeys()

	for _, key := range signerKeys {
		privateKey := getter(key)
		if privateKey == nil {
			return nil, fmt.Errorf("signer key %q not found. Ensure all the signer keys are in the vault", key.String())
		}

		s, err := privateKey.Sign(messageContent)
		if err != nil {
			return nil, fmt.Errorf("failed to signed with key %q: %w", key.String(), err)
		}

		tx.Signatures = append(tx.Signatures, s)
	}
	return tx.Signatures, nil
}

That's the reason why there are double the number of unique signatures.
So the transaction verification fails.
When I manually remove the repeating signatures and send the transaction it broadcasts just fine and it's a valid transaction.
Wondering if this is a bug or my mistake maybe for this kind of transaction I need to sign the transaction differently

From your code, I understand that you're calling the Sign method twice; is that correct?
How about trying something like this:
	signers := []solana.PrivateKey{feePayerWallet, userPrivateKey}

	_, err = tx.Sign(func(key solana.PublicKey) *solana.PrivateKey {
		for _, candidate := range signers {
			if candidate.PublicKey().Equals(key) {
				return &candidate
			}
		}
		return nil
	})

Thanks for the help, closing this.
It was my bad. Didn't pay attention to Sign function it actually gets called multiple times so I should only call it once.


Update SQLServer_Parser.txt

Fixed #3969

@aprakash13 - Could you please help in approval & merge.

Thank you for the approval & merge @aprakash13 .


Research trust and authentication system for the communication layer

Authentication can be done based on the public keys we get from the phonebook, however this inevitably ties in to the trust problem: how do we now we can trust the phonebook to provide correct data.
We will need to define how the notion of trust will work in a system where we have multiple of these services running (with other services on top)

It has been defined that the phonebook is the source of truth


[For discussion] Examples of how you could move more resources into serverless

I don't recommend this being included in the tutorial but it could be useful at the end of the tutorial to explain how things such as identity roles to be configured in serverless yaml instead of manually doing so on the AWS console.
Could also consider explaining how/if s3 buckets,cognito pool and dynamo DB inside serverless.

#107

thx mate!

@QuantumInformation Yeah we are working on a chapter that we will add to the "Extra Credits" section.


Pass --run-forever to flutter-tester to ensure it doesn't quit after executing main

This additional test uses an empty flutter app and waits for 3 seconds then checks the device process has not quit. Without the --run-forever flag the test will fail (note: it may be slow if you don't have the packages cached) on the expectation that isRunning=true. With --run-forever it will pass.
I don't know if these tests currently run on any servers anywhere, I'm just running manually.

@scheglov I fixed the output issue (784d058). Happy for me to merge this?


arduino-cli: add zlib to the fhsenv

fixes #128604
zlib is needed for the espressif toolchain
Motivation for this change
make arduino-cli work with the esp32-toolchain
Things done
added zlib to targetPkgs of buildFHSUserEnv

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 128610 at 4dfdf93e run on x86_64-linux 1

2 packages built successfully:

arduino-ci
arduino-cli


Wrong cache path (missing slash)

Hi,
after the last composer update something happened in the asset_compress or the way how CakePHP 3.0 works.
This is my asset_compress.ini
[General]
cacheConfig = false

[js]
cachePath = WEBROOT/cache/
timestamp = true
paths[] = WEBROOT/
paths[] = WEBROOT/js/
paths[] = WEBROOT/vendor/
paths[] = WEBROOT/vendor/js/
filters[] = JShrinkFilter

[application.js]
files[] = jQuery/jquery-1.11.0.js
# ... other files ...

[css]
cachePath = WEBROOT/cache/
timestamp = true
paths[] = WEBROOT/
paths[] = WEBROOT/css/
paths[] = WEBROOT/vendor/
paths[] = WEBROOT/vendor/css/
filters[] = \App\Lib\AssetCompress\Filter\SassFilter
filters[] = CssMinFilter

[application.css]
files[] = bootstrap/bootstrap.min.css
# ... other files ...

This is how I include those files in the .ctp:
echo $this->AssetCompress->css('application.css');
echo $this->AssetCompress->script('application.js');

The path that is currently generated to the cached files is:
http://localhost/maple/cacheapplication.css
http://localhost/maple/cacheapplication.js

Obviously there is missing slash. Therefore the files cannot be loaded by browser.
This is on my development machine, so the debug = true is set in config.
I'm running on PHP 5.6, Windows 7, IIS 7.

It is likely a mistake in the recent changes I've been doing to the 3.0 code. I can get that fixed as the URLs should be correct.

I wasn't able to reproduce this on my machine. What does $this->AssetCompress->url('application.js') give you? It might be incorrect there, and if it is take a look inside that method and see where it is going wrong? There are some path separator checks in _getRoute(). Unfortunately I can't get my windows VM working right now as an OS upgrade broke VMWare.

I've found something and created a pull-request. However the code I'm changing was there since Januray 3 so it couldn't cause my problem. But still the pr fixes it and to me it makes more sense.


Appdynamics docker

calling docker:build on the whole project fails because appdynamics-collector does not have files to support this method and hygieia-jenkins-collector does not have handler for maven-docker.

i did a tidier version of this pull request


NTR: "resistance to itraconazole"

https://redmine.apidb.org/issues/49648
the more appropriate term for the column will be "resistance to itraconazole" PHIPO_0000675
[PHIPO_0000675] is not loaded in VEupathDB

Need to import "resistance to itraconazole" PHIPO_0000675


Support jar:file:/ path for sourcePaths

We want to generate POJOs based on JSON Schema files in a jar file. Basically we want to just have the artifact that contains the schemas as a Maven dependency, and then generate POJOs from the schemas we need by using the jsonschema2pojo maven build plugin.
You already have support in the code for specifying classpath resources as input, by using something like "classpath:/myfile.json" in the <sourcePath> of the maven plugin.
To make this work, however, requires registering a custom URL protocol handler (VM option), as "classpath" is not a protocol that is supported by default in Java. Setting this up is cumbersome, particularly when running as a maven build plugin.
Java already has a way to create a URI pointing to a resource in a jar file - using the "jar:file:/" protocol. So if you added support for using this scheme in the <sourcePath>, alongside the current "file:" and "classpath:" schemes, we would be able to use json schemas from inside a jar without having to somehow configure the VM with "classpath:" support.

You can achieve it by unpacking the jar with schemas before generation.
<plugin>     <groupId>org.apache.maven.plugins</groupId>     <artifactId>maven-dependency-plugin</artifactId>     <version>3.1.1</version>     <executions>         <execution>             <id>unpack</id>             <phase>initialize</phase>             <goals>                 <goal>unpack</goal>             </goals>             <configuration>                 <artifactItems>                     <artifactItem>                         <groupId>my.package</groupId>                         <artifactId>conversions-api</artifactId>                         <version>1.0.0</version>                         <type>jar</type>                         <overWrite>true</overWrite>                         <outputDirectory>${project.build.directory}/schema</outputDirectory>                         <includes>**/*.json</includes>                     </artifactItem>                 </artifactItems>             </configuration>         </execution>     </executions>     <dependencies>         <dependency>             <groupId>my.package</groupId>             <artifactId>conversions-api</artifactId>             <version>1.0.0</version>         </dependency>     </dependencies> </plugin> <plugin>     <groupId>org.jsonschema2pojo</groupId>     <artifactId>jsonschema2pojo-maven-plugin</artifactId>     <version>1.0.1</version>     <configuration>         <sourceDirectory>${project.build.directory}/schema/v1.0.x</sourceDirectory>         <targetPackage>my.package.cs</targetPackage>     </configuration>     <executions>         <execution>             <goals>                 <goal>generate</goal>             </goals>         </execution>     </executions> </plugin>


PytorchStreamReader error failed reading zip archive

Hi,  thanks for all your hardwork.
However, as I launch python app.py --device cuda:0
'RuntimeError: PytorchStreamReader failed reading zip archive: failed finding central directory' occurs.
Since the urls have been successfully downloaded, can you help figure out how to deal with this issue? Thanks for your time.

Problem solved

How was the problem solved? I am also running into this issue

@vedantroy maybe your .pth file is not incomplete, I suggest you download them again


Flutter 3.16 having bug on overriding the iOS systemOverlayUI statusBarBrightness

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Upgraded to flutter 3.16.0
Try to change the statusBarBrightness inside ThemeData -> AppBarTheme -> systemOverlayStyle
Doesn't has any effect
Change the appearance in device setting, will changes the statusBar text to contrast with the theme selected.
Previously it was working in Flutter version 3.13.9

Expected results
The statusBarBrightness should change when set in ThemeData, no like only follow the system setting.
Actual results
The statusBarBrightness does nothing in the ThemeData -> AppBarTheme -> systemOverlayStyle
Code sample
Code sample
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

import 'color_config.dart';
import 'dimen_config.dart';
import 'text_style_config.dart';

class ThemeConfig {
  static final lightTheme = ThemeData.light().copyWith(
    appBarTheme: AppBarTheme(
      systemOverlayStyle: const SystemUiOverlayStyle(
        statusBarColor: Colors.transparent,
        statusBarIconBrightness: Brightness.dark,
        statusBarBrightness: Brightness.light,
      ),
      titleTextStyle: TextStyleConfig.boldTextStyle(
        fontSize: DimenConfig.textSize_22,
        color: ColorConfig.blackColor,
      ),
      iconTheme: const IconThemeData(
        color: ColorConfig.blackColor,
      ),
    ),
    scaffoldBackgroundColor: ColorConfig.whiteColor,
  );

  static final darkTheme = ThemeData.dark().copyWith(
    appBarTheme: AppBarTheme(
      systemOverlayStyle: const SystemUiOverlayStyle(
        statusBarColor: Colors.transparent,
        statusBarIconBrightness: Brightness.light,
        statusBarBrightness: Brightness.dark,
      ),
      titleTextStyle: TextStyleConfig.boldTextStyle(
        fontSize: DimenConfig.textSize_22,
        color: ColorConfig.whiteColor,
      ),
      iconTheme: const IconThemeData(
        color: ColorConfig.whiteColor,
      ),
    ),
    scaffoldBackgroundColor: ColorConfig.darkCharcoalColor,
  );
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.16.0, on macOS 14.1.1 23B81 darwin-arm64, locale en-US)
    • Flutter version 3.16.0 on channel stable at /Users/dev/Desktop/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision db7ef5bf9f (3 days ago), 2023-11-15 11:25:44 -0800
    • Engine revision 74d16627b9
    • Dart version 3.2.0
    • DevTools version 2.28.2
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] Connected device (3 available)
[✓] Network resources

Might be related to https://github.com/flutter/flutter/issues/138604

Same issue here.

Hi @issacbot1499
Can you please provide a completed and minimal reproducible code sample that doesn’t include 3rd party plugins or complex production code?
Also, it would be more intuitive if there was a demo video for this. Thanks!

Same problem

Same issue. Not the AnnotatedRegion() not the SystemChrome seems to have any effect on IOS

I had the same issue. I wanted to create a new app that shows the problem:
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key});

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  Brightness statusBarBrightness = Brightness.light;

  @override
  Widget build(BuildContext context) {
    return AnnotatedRegion<SystemUiOverlayStyle>(
      value: SystemUiOverlayStyle(
        statusBarBrightness: statusBarBrightness,
        statusBarIconBrightness: statusBarBrightness,
      ),
      child: Scaffold(
        body: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              const Text('Status bar demo'),
              ElevatedButton(
                onPressed: () => setState(
                  () {
                    if (statusBarBrightness == Brightness.light) {
                      statusBarBrightness = Brightness.dark;
                    } else {
                      statusBarBrightness = Brightness.light;
                    }
                  },
                ),
                child: const Text('Change status bar brightness'),
              )
            ],
          ),
        ),
      ),
    );
  }
}

However, this code worked for me on Flutter 3.16. So I thought it may be the iOS config.
Turns out I had the following entries in Info.plist:
<key>UIStatusBarStyle</key>
<string>UIStatusBarStyleLightContent</string>
<key>UIViewControllerBasedStatusBarAppearance</key>
<false/>

Removing them made the code above work in my app.

I had the same issue. I wanted to create a new app that shows the problem:
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key});

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  Brightness statusBarBrightness = Brightness.light;

  @override
  Widget build(BuildContext context) {
    return AnnotatedRegion<SystemUiOverlayStyle>(
      value: SystemUiOverlayStyle(
        statusBarBrightness: statusBarBrightness,
        statusBarIconBrightness: statusBarBrightness,
      ),
      child: Scaffold(
        body: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              const Text('Status bar demo'),
              ElevatedButton(
                onPressed: () => setState(
                  () {
                    if (statusBarBrightness == Brightness.light) {
                      statusBarBrightness = Brightness.dark;
                    } else {
                      statusBarBrightness = Brightness.light;
                    }
                  },
                ),
                child: const Text('Change status bar brightness'),
              )
            ],
          ),
        ),
      ),
    );
  }
}

However, this code worked for me on Flutter 3.16. So I thought it may be the iOS config.
Turns out I had the following entries in Info.plist:
<key>UIStatusBarStyle</key>
<string>UIStatusBarStyleLightContent</string>
<key>UIViewControllerBasedStatusBarAppearance</key>
<false/>

Removing them made the code above work in my app.

Thanks, work for me.

I had the same issue. I wanted to create a new app that shows the problem:
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key});

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  Brightness statusBarBrightness = Brightness.light;

  @override
  Widget build(BuildContext context) {
    return AnnotatedRegion<SystemUiOverlayStyle>(
      value: SystemUiOverlayStyle(
        statusBarBrightness: statusBarBrightness,
        statusBarIconBrightness: statusBarBrightness,
      ),
      child: Scaffold(
        body: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              const Text('Status bar demo'),
              ElevatedButton(
                onPressed: () => setState(
                  () {
                    if (statusBarBrightness == Brightness.light) {
                      statusBarBrightness = Brightness.dark;
                    } else {
                      statusBarBrightness = Brightness.light;
                    }
                  },
                ),
                child: const Text('Change status bar brightness'),
              )
            ],
          ),
        ),
      ),
    );
  }
}

However, this code worked for me on Flutter 3.16. So I thought it may be the iOS config.
Turns out I had the following entries in Info.plist:
<key>UIStatusBarStyle</key>
<string>UIStatusBarStyleLightContent</string>
<key>UIViewControllerBasedStatusBarAppearance</key>
<false/>

Removing them made the code above work in my app.

I didn't have UIViewControllerBasedStatusBarAppearance, but I do need UIStatusBarStyleLightContent to fix an issue with status bar text contrast when showing the splash screen of my app.

Same problem

Turns out I had the following entries in Info.plist:
<key>UIViewControllerBasedStatusBarAppearance</key>
<false/>

Removing them made the code above work in my app.

Also works for me, thanks! 🙏🏽

@LinXunFeng Have you requested a cherry-pick for that fix?

@LinXunFeng Have you requested a cherry-pick for that fix?

@stuartmorgan I'm working on it : )

android same problem

The problem remains at this date.


Feeds example. Use of ".parsed" changed.

I make some changes suggested by @GriceTurrble.

I've written merge commit with slight edits:

Adjusted print statements to Python 3 style.
Corrected MSW_MARKETPLACE_ID to MWS_MARKETPLACE_ID.
Changed marketplace_usa variable up top to MWS_MARKETPLACE_ID, which seemed to be the intention.

Codecov Report

Merging #66 into develop will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           develop   #66   +/-   ##
=====================================
  Coverage       79%   79%
=====================================
  Files           18    18
  Lines          824   824
  Branches        78    78
=====================================
  Hits           651   651
  Misses         165   165
  Partials         8     8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a18583...393ea2a. Read the comment docs.


Log In Failed Problem

I created a .env file and also inputted email address and password in correct format but still getting this issue. May I know why? Do I need to input auth token ? or what ?

xD


remove automated formatting checks

We are removing the automated formatting checks before merging CI/CD changes in other repos, see for example: https://github.com/KhronosGroup/OpenCL-CLHPP/pull/262/commits/94eb4dfbd742afe0f36b29c9e562a2e479a0f784.
But, we've already merged the CI/CD changes for this repo, so this PR is needed to remove the automated formatting checks.
Removing the automated formatting checks is is helpful for this repo especially since it has a large amount of auto-generated code that is already formatted consistently.

Although I don't object to removing the clang-format CI at the moment, should we create an issue to decide whether we want to clang-format the headers at some point in the future? A solution where we add clang-format to the existing header generation script, or clang-format headers as a step in the CMake generate build target I think would integrate into a development flow more effectively than the current manual step we are disabling.
It's not completely analogous but examples of these two solutions are:

Unified Runtime runs clang format as part of the generation script  of ur_api.h - https://github.com/oneapi-src/unified-runtime/blob/main/scripts/run.py#L179
OCK runs clang-format as a CMake command when generating it's internal HAL API - https://github.com/codeplaysoftware/oneapi-construction-kit/blob/be5dd74a5328d6b7e57bdcb739d13567d442a986/modules/mux/tools/api/CMakeLists.txt#L86


CDEF RDO skip fix

Due to shared code, CDEF currently has a bug in RDO; skipped blocks are not copied to output, causing LRF to optimize partially on garbage blocks.

AWCY results incoming, hold off on review until it confirms

@xiphmont do you think this refs #1399 ?

Doesn't build, something got lost in a rebase?

Yes.  Required rust version got bumped so I can't yet build/test locally, I
got a little too optimistic.  But I won't be able to fix until rustc build
finishes.
Monty
On Wed, Aug 21, 2019 at 4:40 PM Luca Barbato<EMAIL_ADDRESS>wrote:

Doesn't build, something got lost in a rebase?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/xiph/rav1e/pull/1571?email_source=notifications&email_token=ACWMHEDVRQ7JTBCB6Z2UNITQFWR4LA5CNFSM4IONTVJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD43BZ7Y#issuecomment-523640063,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWMHECFXZHNYXI25B65P4TQFWR4LANCNFSM4IONTVJQ
.

No.  Different bug.
Monty
On Wed, Aug 21, 2019 at 4:37 PM Tristan Matthews<EMAIL_ADDRESS>wrote:

@xiphmont https://github.com/xiphmont do you think this refs #1399
https://github.com/xiph/rav1e/issues/1399 ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/xiph/rav1e/pull/1571?email_source=notifications&email_token=ACWMHEDCA33YEXRKBB62BBLQFWRQBA5CNFSM4IONTVJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD43BQ3Y#issuecomment-523638895,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWMHECIITAZRRRVMLCMKVDQFWRQBANCNFSM4IONTVJQ
.

Coverage increased (+0.02%) to 71.311% when pulling 596a703835e18c590c7cb5a4fd2a71289785371b on xiphmont:lrf-rebase2 into 2de7d88f36509e6a0bae0df0c06db5c0df057ba4 on xiph:master.

cdef-lrf-skip-fix-baseline@2019-08-22T23:25:34.279Z -> cdef-lrf-skip-fix-test@2019-08-22T23:25:51.426Z
PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-0.3268 |  0.0929 |  0.1608 |  -0.1944 | -0.3945 | -0.3608 |    -0.4063
Pending checks finishing, this is ready for review and merge now.  More fixes incoming after.

@lu-zero Depends if someone starts on the PGO research before then. :)


bug : Add Label to Contact Form Fields for Enhanced User Experience

Description of Issue:
The contact form currently lacks labels for input fields such as Name, Email, and Message. This can cause confusion for users as they may not immediately understand the purpose of each field, especially on small screens or in assistive technologies.
Adding labels will improve the overall user experience by making the form more accessible and user-friendly.
Actual Situation:

Fields in the contact form (Name, Email, and Message) do not have descriptive labels.
Users might find it unclear which information to enter in each field.
This might affect usability and accessibility.

Expected Situation:

Each input field should have a clearly visible and associated label (e.g., "Name", "Email", "Message").
Labels should align with the fields and follow a consistent styling to match the overall UI theme.
This should help users better understand which information is required and improve accessibility for screen readers.

Screenshots

hey @tushargupta1504 , could you please assign this to me ?


Ikigai Mangas NSFW?!

Describe your suggested feature
Ikigai Mangas has some mangas inaccessible if you don't choose the option 'NSFW' on the top right of the page. Those include action Manga and manhwas for some reason. It is possible to add an option in the app to access that mode? (I'm sorry if my English is kinda trash)
Other details

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] If this is an request for a feature in the original Tachiyomi, I am opening because multiple versions of Yōkai have been released without this feature.
[X] If this is an issue with an extension, or a request for an extension, I should be contacting the extensions repository's maintainer/support for help.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have checked through the app settings for my feature.
[X] I will fill out all of the requested information in this form.

Extension issue (not even an issue tbh), next time please check extension settings first before asking for help (Browse > Extensions > Find Ikigai Mangas > NSFW, toggle that on) and this is definitely not the right place to ask about extension, if issue persists, please contact extension maintainer instead.

I had no idea, I'm so sorry for the inconvenience
El mié., 10 de julio de 2024 21:58, Ahmad Ansori Palembani <
@.***> escribió:

Extension issue (not even an issue tbh), next time please check extension
settings first before asking for help (Browse > Extensions > Find Ikigai
Mangas > NSFW, toggle that on) and this is definitely not the right place
to ask about extension, if issue persists, please contact extension
maintainer instead.
—
Reply to this email directly, view it on GitHub
https://github.com/null2264/yokai/issues/121#issuecomment-2221787099,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYDRBMSFCI2VUJBRGTT6NMDZLXKD3AVCNFSM6AAAAABKVAR2LWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRRG44DOMBZHE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Implement basic Protocol structure using ellipsis

Description:
Implement the basic structure for defining Protocols in Python using the ellipsis (...) syntax.

[ ] Create a Polynomial Protocol with evaluate and degree methods
[ ] Use ellipsis (...) for method bodies
[ ] Provide example usage with a QuadraticPolynomial implementation
[ ] Demonstrate type checking capabilities

Ran into my first problem here. Actually the test will pass using isInstance. but mypy will not be happy. And this is where it is useful to add the @runtime_checkable decorator to the protocol.


Moving IsSupportedAlgorithm api from SignatureProvider to SecurityKey

#336

:shipit:

Hem, we're seeing weird errors with the RC2 bits. Was this PR included in the upcoming release?

@PinpointTownes Yes, this PR is part of Rc2 bits. Version: 305061149

Marvelous. Now, we're blocked by an incomplete IsSupportedAlgorithm. I assume there's no point to address the missing algorithms before RC2?

@PinpointTownes How is this blocking you? The set of supported algorithms is same as before (what was in SignatureProviders). The encryption/key wrap algorithms are not supported by default as signature providers do not know how to create a crypto provider for them.

It's blocking us because we rely on IsSupportedAlgorithm to determine if a particular key is compatible with key wraps/symmetric algorithms. With the introduction of this method in RC2, our static helper (that handles correctly all the supported algorithms) is now ignored, which will cause much pain until we rename it.
I'm not sure why this method should be limited to what the signature provider supports. These are two different classes, and a key can be used for something else than signing.

@PinpointTownes
Good points as it is going to be difficult to extend algorithm support without deriving.
Extensiblility for the algorithms a key can exist as a static default list on the key OR we could use a delegate to answer the question.
Also, if the AsymmetricAlgorithmResolver is set, we shouldn't check here: https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/KDev/src/Microsoft.IdentityModel.Tokens/AsymmetricSignatureProvider.cs#L126

@brentschmaltz so what's the plan? Are you going to add the precious missing algorithms in RC2 or is this something we need to work around ourselves?

@PinpointTownes my current thought is to role back the change, make the fix that we check for AsymmetricAlgorithmResolver before faulting and rethink it. We are always going to have the situation where users need to extend algorithm support. The model we put in requires deriving both Provider and Key. I am thinking all the key votes on is does the algorithm match my class: Symmetric or Asymmetric. Even then, with all the specs it will be hard to have a comprehensive solution over time. A natural extensibility model is needed here.


Update check-loc-encoding checkout action

Fixes Node.js 12 deprecation.

I didn't even realize it was a race, lol; I thought you left...


Add getSchema method

User can get formatted or raw data types in a json response from this method.

@dmitry-grechko please check the changes.


tensorflow.contrib.layers.feature_column_ops with tf.placeholder tensors

Following up on the TF.Learn tutorials demonstrating linear models with categorical variables (https://www.tensorflow.org/versions/r0.9/tutorials/linear/overview.html), I have tried to re-use the functions & abstractions from tensorflow.contrib.layers.feature_column_ops to hash, encode & cross my input categorical columns while still handling the rest of the computing in low-level TensorFlow.
However, when I pass a normal Tensor (or placeholder) as values of the columns_to_tensors parameters of weighted_sum_from_feature_columns (https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/layers/python/layers/feature_column_ops.py#L460), it fails because of the shape parameter being not available.
Is there any way or plan to enable passing any Tensors other than SparseTensors to this function?

Please ask this question on StackOverflow as many users of TensorFlow contribute answers to those questions.. If you discover a concrete feature or bug in behavior, please repost here. Thanks!


Added a filter_type called range_number_to

It is a copy of range_number that hides the fromId input field and sets
its value.
An optional parameter - range_number_from - can be passed to set the
"from" value, otherwise it is defaulted to 0.
Default
{column_number : 1,  filter_type: "range_number_to",
filter_container_id: "external_filter_container"}
Parameterised
{column_number : 1,  filter_type: "range_number_to",
filter_container_id: "external_filter_container", range_number_from: 30}

Thanks, but this kind of filter type can be easily achieved by using several lines in css... just hide the from field and the span used to separate the from[ ]to inputs...


Unable to find sourcemap

I could see the following issue being logged when I install this library in create-react-app version 5:
WARNING in ./node_modules/amazon-connect-streams/release/connect-streams.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/zlksnk/mytmp/my-app/node_modules/amazon-connect-streams/release/amazon-connect-websocket-manager.js.map' file: Error: ENOENT: no such file or directory, open '/home/zlksnk/mytmp/my-app/node_modules/amazon-connect-streams/release/amazon-connect-websocket-manager.js.map'
 @ ./src/App.tsx 7:0-32
 @ ./src/index.tsx 7:0-24 11:33-36

To reproduce

Clone this repo
Run yarn to install dependencies (uses yarn 1, but you could use any package manager you want)
Run yarn start

While the repo uses latest v2 of connect streams, I originally reproduced it with v1.6.11.
Expected behavior
Sourcemap must be present
Actual behavior
We see the issue mentioned at the top of the ticket

Are there any solutions temporary? @ctwomblyamzn  Thanks for replying


Implemented Food Per Agent Ratio

Closes #175
Added UseFoodPerAgentRatio and FoodPerAgentRatio config parameters to allow to automatically set the amount of food depending on the number of agents.
If UseFoodPerAgentRatio is true, then it multiplies FoodPerAgentRatio by number of agents to calculate total food. It ignores the FoodOnPlatform parameter if it is set
If  UseFoodPerAgentRatio is false, then it uses FoodOnPlatform and ignores FoodPerAgentRatio
I updated the config.json to include default parameters for them, and added error handling in case any of these three parameters are not set correctly.

Thanks. Would be great to have a wiki page for the config!

Done, we now have a Config wiki page


Signpost from “Hello, Minikube” back to Kubernetes Basics tutorials

This is a Feature Request

What would you like to be added
Link to https://k8s.io/docs/tutorials/kubernetes-basics/deploy-app/deploy-intro/ at the end of https://k8s.io/docs/tutorials/hello-minikube/
Make this link particularly prominent. It should come before the other three links in the What's Next section of the page.
Why is this needed
https://k8s.io/docs/tutorials/kubernetes-basics/ directs readers to visit https://k8s.io/docs/tutorials/hello-minikube/
However, people who get to the end of https://k8s.io/docs/tutorials/hello-minikube/ do not see any link back to https://k8s.io/docs/tutorials/kubernetes-basics/deploy-app/deploy-intro/
Comments
This is a consequence of the Katacoda shutdown - https://kubernetes.io/blog/2023/02/14/kubernetes-katacoda-tutorials-stop-from-2023-03-31/ - and our response to that shutdown.
/language en
/kind feature

/assign
Proposed fix in #41842

/good-first-issue
(retrospectively)


set default storeId to 1 instead of 0 so default magento storeId is q…

…ueried instead of 0 which never has chance of existence as primary key
Related issues
none
Short description and why it's useful
cmsModule by default uses endpoint:
https://github.com/DivanteLtd/vue-storefront/blob/master/config/default.json#L405
but the storeId is set to 0. This PR is made for default magento storeId 1 to be queried instead of 0.
0 storeId doesn't exist in default magento instances (nor any instance which usually supports primary keys).
Screenshots of visual changes before/after (if there are any)
no changes
Screenshot of passed e2e tests (if you are using our standard setup as a backend)
none, but storeId is nowhere compared to fallback value 0
Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility)
[ ] I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

[x] I read and followed contribution rules
[x] I read the TypeScript Action Plan and adjusted my PR according to it
[x] I read about Vue Storefront Modules and I am aware that every new feature should be a module

@patzick rebased on master and added changelog


kapp fails to update resource when update cannot be applied due to conflict

We are seeing updates to some of our k8s resources failing. It seems to happen most often with a cronjob that we have run every minute, but we also have seen it with our deployment.
Example error message

Applying update cronjob/my-cronjob (batch/v1beta1) namespace: nondefault: Updating resource cronjob/my-cronjob (batch/v1beta1) namespace: nondefault: Operation cannot be fulfilled on cronjobs.batch "my-cronjob": the object has been modified; please apply your changes to the latest version and try again (reason: Conflict)

At first we thought that two kapp deploys were happening at the same time, but once we prevented that we still saw the error.
Is kapp perhaps checking something it isnt showing the the diff that is causing this conflict?

this error will arise when something else in the system (eg cronjob controller itself, or kubectl deploy, or parallel kapp deploy ...) modified resource between kapp's diff and apply steps. this ultimately results in metadata.resourceVersion field being different from what kapp has in memory, hence update fails.
kapp v0.15.0+ includes a change that eliminates most of these errors by "rebasing" against updated resource but at the same time making sure that diff is still the same, and if it is, continuing on.
since i do not see (tried multiple times) inside the error above [1], what version of kapp are you using? additionally, do you happen to use fallback-on-replace update strategy for this resource?
[1] https://github.com/k14s/kapp/blob/master/pkg/kapp/clusterapply/add_or_update_change.go#L161

Good question. We are running
kapp version
Client Version: 0.21.0
We do not have the update-strategy defined, so  I believe that would be a plain update call.
Do we need to do anything special to enable 'tried multiple times'?

how frequently is this error happening? are you seeing this problem with latest kapp as well? ive tried to create cronjob myself and not seeing this error even though im hammering with kapp deploys and changes to cronjob.

Do we need to do anything special to enable 'tried multiple times'?

nothing specific. it should be happening on its own. i do see that if for whatever reason error is not considered to be a Conflict it will not be annotated with tried multiple times.
our next step would be to try to see why are we not hitting correct err msgs. i've made branch debug_num86. you can build the local copy of the binary this way:
go version
git clone https://github.com/k14s/kapp kapp-go/src/github.com/k14s/kapp
export GOPATH=`pwd`/kapp-go
cd kapp-go/src/github.com/k14s/kapp
git checkout debug_num86
./hack/build.sh
./kapp version # <--- make sure you are using local binary built

change made is following: https://github.com/k14s/kapp/commit/6dbc646b098b6c199075659b2628c75a8e1a6842. i'd like to see if we are hitting this other paths.

(if you are open to a faster debug cycle, find me in #k14s slack channel in k8s slack; im dkalinin there).

@computeracer any update on this?

@cppforlife sorry, I got caught up is some other priorities, I am hoping to pick this up again this week. Thanks for mentioning the slack option as well. I will update with my findings.

@cppforlife  here is the notes from the testing. Turns out we did have an update strategy in our command, just had to find where it was being set. What are your thoughts on the strategy?
From our experiment with a 1.14 kind cluster
$ kind create cluster --image=kindest/node:v1.14.2
$ mkdir -p /tmp/test/app
$ echo '
---
apiVersion: batch/v1
kind: Job
metadata:
  name: migrate
  annotations:
    kapp.k14s.io/update-strategy: "always-replace"
    kapp.k14s.io/change-rule: "upsert before upserting web"
    kapp.k14s.io/change-rule.1: "upsert before upserting jobs"
    kapp.k14s.io/nonce: "" # Always replace, even if image is the same.
spec:
  backoffLimit: 2
  template:
    spec:
      restartPolicy: OnFailure
      containers:
      - name: job
        image: alpine
        command: ["sh"]
        args: [ "-c", "sleep 60" ]
---
apiVersion: batch/v1beta1
kind: CronJob
metadata:
  name: cleanup-sessions
  labels:
    maintainer: admin
  annotations:
    description: "Clean up"
    kapp.k14s.io/change-group: "jobs"
    kapp.k14s.io/nonce: "" # Always replace, even if image is the same.
spec:
  schedule: "* * * * *"
  concurrencyPolicy: Forbid
  successfulJobsHistoryLimit: 1
  failedJobsHistoryLimit: 1
  jobTemplate:
    spec:
      template:
        metadata:
          labels:
            maintainer: admin
        spec:
          restartPolicy: Never # Alternative is OnFailure
          containers:
          - name: job
            image: alpine
            command: ["sh"]
            args: [ "-c", "sleep 1" ]
' > /tmp/test/app/cronjob.yml
$ kapp app-group deploy -g test --directory /tmp/test --dangerous-allow-empty-list-of-resources --dangerous-override-ownership-of-existing-resources=true --apply-default-update-strategy=fallback-on-replace --diff-changes
# Then a 2nd time
$ kapp app-group deploy -g test --directory /tmp/test --dangerous-allow-empty-list-of-resources --dangerous-override-ownership-of-existing-resources=true --apply-default-update-strategy=fallback-on-replace --diff-changes
--- deploying app 'test-app' (namespace: default) from /tmp/test/app

Target cluster 'https://<IP_ADDRESS>:32768' (nodes: kind-control-plane)

--- update job/migrate (batch/v1) namespace: default
  ...
  5,  5       kapp.k14s.io/change-rule.1: upsert before upserting jobs
  6     -     kapp.k14s.io/nonce: "1587586241218308980"
      6 +     kapp.k14s.io/nonce: "1587586334522076904"
  7,  7       kapp.k14s.io/update-strategy: always-replace
  8,  8     creationTimestamp: "2020-04-22T20:10:45Z"
--- update cronjob/cleanup-sessions (batch/v1beta1) namespace: default
  ...
  5,  5       kapp.k14s.io/change-group: jobs
      6 +     kapp.k14s.io/nonce: "1587586334522076904"
  6,  7     creationTimestamp: "2020-04-22T20:01:31Z"
  7,  8     labels:

Changes

Namespace  Name              Kind     Conds.  Age  Op      Wait to    Rs  Ri
default    cleanup-sessions  CronJob  -       10m  update  reconcile  ok  -
^          migrate           Job      1/1 t   1m   update  reconcile  ok  Completed

Op:      0 create, 0 delete, 2 update, 0 noop
Wait to: 2 reconcile, 0 delete, 0 noop

Continue? [yN]: y

4:12:17PM: ---- applying 1 changes [0/2 done] ----
4:12:17PM: update job/migrate (batch/v1) namespace: default
4:12:18PM: ---- waiting on 1 changes [0/2 done] ----
4:12:18PM: ongoing: reconcile job/migrate (batch/v1) namespace: default
4:12:18PM:  ^ Waiting to complete (1 active, 0 failed, 0 succeeded)
4:12:18PM:  L ongoing: waiting on pod/migrate-zlcqp (v1) namespace: default
4:12:18PM:     ^ Pending: ContainerCreating
4:12:19PM: ongoing: reconcile job/migrate (batch/v1) namespace: default
4:12:19PM:  ^ Waiting to complete (1 active, 0 failed, 0 succeeded)
4:12:19PM:  L ok: waiting on pod/migrate-zlcqp (v1) namespace: default
4:13:18PM: ---- waiting on 1 changes [0/2 done] ----
4:13:20PM: ok: reconcile job/migrate (batch/v1) namespace: default
4:13:20PM: ---- applying 1 changes [1/2 done] ----
4:13:20PM: update cronjob/cleanup-sessions (batch/v1beta1) namespace: default

kapp: Error: Applying update cronjob/cleanup-sessions (batch/v1beta1) namespace: default: Updating resource cronjob/cleanup-sessions (batch/v1beta1) namespace: default: Operation cannot be fulfilled on cronjobs.batch "cleanup-sessions": the object has been modified; please apply your changes to the latest version and try again (reason: Conflict)

We adjusted the resources update strategy in our yaml file:
---
apiVersion: batch/v1beta1
kind: CronJob
metadata:
  name: cleanup-sessions
  labels:
    maintainer: admin
  annotations:
    description: "Clean up"
kapp.k14s.io/update-strategy: ""

We no longer get the error message:
app app-group deploy -g test --directory /tmp/test --dangerous-allow-empty-list-of-resources --dangerous-override-ownership-of-existing-resources=true --apply-default-update-strategy=fallback-on-replace --diff-changes
--- deploying app 'test-app' (namespace: default) from /tmp/test/app

Target cluster 'https://<IP_ADDRESS>:32768' (nodes: kind-control-plane)

--- update job/migrate (batch/v1) namespace: default
  ...
  5,  5       kapp.k14s.io/change-rule.1: upsert before upserting jobs
  6     -     kapp.k14s.io/nonce: "1587586334522076904"
      6 +     kapp.k14s.io/nonce: "1587586440046221008"
  7,  7       kapp.k14s.io/update-strategy: always-replace
  8,  8     creationTimestamp: "2020-04-22T20:12:17Z"
--- update cronjob/cleanup-sessions (batch/v1beta1) namespace: default
  ...
  5,  5       kapp.k14s.io/change-group: jobs
      6 +     kapp.k14s.io/nonce: "1587586440046221008"
      7 +     kapp.k14s.io/update-strategy: ""
  6,  8     creationTimestamp: "2020-04-22T20:01:31Z"
  7,  9     labels:

Changes

Namespace  Name              Kind     Conds.  Age  Op      Wait to    Rs  Ri
default    cleanup-sessions  CronJob  -       12m  update  reconcile  ok  -
^          migrate           Job      1/1 t   1m   update  reconcile  ok  Completed

Op:      0 create, 0 delete, 2 update, 0 noop
Wait to: 2 reconcile, 0 delete, 0 noop

Continue? [yN]: y

4:14:03PM: ---- applying 1 changes [0/2 done] ----
4:14:03PM: update job/migrate (batch/v1) namespace: default
4:14:03PM: ---- waiting on 1 changes [0/2 done] ----
4:14:04PM: ongoing: reconcile job/migrate (batch/v1) namespace: default
4:14:04PM:  ^ Waiting to complete (0 active, 0 failed, 0 succeeded)
4:14:04PM:  L ongoing: waiting on pod/migrate-d4r42 (v1) namespace: default
4:14:04PM:     ^ Pending: ContainerCreating
4:14:05PM: ongoing: reconcile job/migrate (batch/v1) namespace: default
4:14:05PM:  ^ Waiting to complete (1 active, 0 failed, 0 succeeded)
4:14:05PM:  L ongoing: waiting on pod/migrate-d4r42 (v1) namespace: default
4:14:05PM:     ^ Pending: ContainerCreating
4:14:08PM: ongoing: reconcile job/migrate (batch/v1) namespace: default
4:14:08PM:  ^ Waiting to complete (1 active, 0 failed, 0 succeeded)
4:14:08PM:  L ok: waiting on pod/migrate-d4r42 (v1) namespace: default
4:15:05PM: ---- waiting on 1 changes [0/2 done] ----
4:15:06PM: ok: reconcile job/migrate (batch/v1) namespace: default
4:15:06PM: ---- applying 1 changes [1/2 done] ----
4:15:06PM: update cronjob/cleanup-sessions (batch/v1beta1) namespace: default
4:15:06PM: ---- waiting on 1 changes [1/2 done] ----
4:15:06PM: ok: reconcile cronjob/cleanup-sessions (batch/v1beta1) namespace: default
4:15:06PM: ---- applying complete [2/2 done] ----
4:15:06PM: ---- waiting complete [2/2 done] ----

Succeeded

We believe it may be this line that is causing our issue:
--apply-default-update-strategy=fallback-on-replace
Test without the --apply-default-update-strategy=fallback-on-replace flag being used succeeds:
kapp app-group deploy -g test --directory /tmp/test --dangerous-allow-empty-list-of-resources --dangerous-override-ownership-of-existing-resources=true  --diff-changes
--- deploying app 'test-app' (namespace: default) from /tmp/test/app

Target cluster 'https://<IP_ADDRESS>:32768' (nodes: kind-control-plane)

--- update job/migrate (batch/v1) namespace: default
  ...
  5,  5       kapp.k14s.io/change-rule.1: upsert before upserting jobs
  6     -     kapp.k14s.io/nonce: "1587587017683604375"
      6 +     kapp.k14s.io/nonce: "1587587097906026553"
  7,  7       kapp.k14s.io/update-strategy: always-replace
  8,  8     creationTimestamp: "2020-04-22T20:23:43Z"
--- update cronjob/cleanup-sessions (batch/v1beta1) namespace: default
  ...
  5,  5       kapp.k14s.io/change-group: jobs
  6     -     kapp.k14s.io/nonce: "1587586440046221008"
  7     -     kapp.k14s.io/update-strategy: ""
      6 +     kapp.k14s.io/nonce: "1587587097906026553"
  8,  7     creationTimestamp: "2020-04-22T20:01:31Z"
  9,  8     labels:

Changes

Namespace  Name              Kind     Conds.  Age  Op      Wait to    Rs  Ri
default    cleanup-sessions  CronJob  -       23m  update  reconcile  ok  -
^          migrate           Job      1/1 t   1m   update  reconcile  ok  Completed

Op:      0 create, 0 delete, 2 update, 0 noop
Wait to: 2 reconcile, 0 delete, 0 noop

Continue? [yN]: y

4:25:02PM: ---- applying 1 changes [0/2 done] ----
4:25:02PM: update job/migrate (batch/v1) namespace: default
4:25:02PM: ---- waiting on 1 changes [0/2 done] ----
4:25:02PM: ongoing: reconcile job/migrate (batch/v1) namespace: default
4:25:02PM:  ^ Waiting to complete (1 active, 0 failed, 0 succeeded)
4:25:02PM:  L ongoing: waiting on pod/migrate-w88bh (v1) namespace: default
4:25:02PM:     ^ Pending: ContainerCreating
4:25:02PM:  L ok: waiting on pod/migrate-cm9z6 (v1) namespace: default
4:25:04PM: ongoing: reconcile job/migrate (batch/v1) namespace: default
4:25:04PM:  ^ Waiting to complete (1 active, 0 failed, 0 succeeded)
4:25:04PM:  L ongoing: waiting on pod/migrate-w88bh (v1) namespace: default
4:25:04PM:     ^ Pending: ContainerCreating
4:25:05PM: ongoing: reconcile job/migrate (batch/v1) namespace: default
4:25:05PM:  ^ Waiting to complete (1 active, 0 failed, 0 succeeded)
4:25:05PM:  L ok: waiting on pod/migrate-w88bh (v1) namespace: default
4:26:02PM: ---- waiting on 1 changes [0/2 done] ----
4:26:05PM: ongoing: reconcile job/migrate (batch/v1) namespace: default
4:26:05PM:  ^ Waiting to complete (1 active, 0 failed, 0 succeeded)
4:26:05PM:  L ok: waiting on pod/migrate-w88bh (v1) namespace: default
4:26:07PM: ok: reconcile job/migrate (batch/v1) namespace: default
4:26:07PM: ---- applying 1 changes [1/2 done] ----
4:26:07PM: update cronjob/cleanup-sessions (batch/v1beta1) namespace: default
4:26:07PM: ---- waiting on 1 changes [1/2 done] ----
4:26:07PM: ok: reconcile cronjob/cleanup-sessions (batch/v1beta1) namespace: default
4:26:07PM: ---- applying complete [2/2 done] ----
4:26:07PM: ---- waiting complete [2/2 done] ----

Succeeded

thanks for such a clean repro. i've made a change (https://github.com/k14s/kapp/commit/ce4d990ff2a8822b84b54fbbe1bb73e662dd88cf) and verified with given that it fixes this problem. what was happening is that if update-strategy was fallback-on-replace, kapp was not as aggressive (compared to default update strategy) for retrying on a conflict. change will be included in upcoming release.

included in https://github.com/k14s/kapp/releases/tag/v0.25.0


Improve error messages

What do you think of adding minitest assertions, to improve the automated tests output?
Before
  1) Error:
TestZsh#test_process_completion:
RuntimeError: timeout
    test/test_go.rb:47:in `wait'
    test/test_go.rb:118:in `until'
    test/test_go.rb:2025:in `test_process_completion'

After
  1) Failure:
TestZsh#test_process_completion [test/test_go.rb:2047]:
Expected: "kill 16358"
  Actual: "kill 1"

@junegunn I've rebased this change: Would you consider giving it another look?

@junegunn I've brought this change up to date.

Nicely done, thanks for all the work.


Updates to makefile

Update makefile to share some code.
Fix lint errors uncovered.
Ensure that it is not possible to check in unformatted code.

Pull Request Test Coverage Report for Build 111567271

-30 of 31 (3.23%)  changed or added relevant lines in 5 files are covered.
18 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.006%) to 29.417%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

hack/generator/pkg/astmodel/package_reference.go
0
1
0.0%

hack/generator/pkg/astmodel/struct_definition.go
0
1
0.0%

hack/generator/pkg/astmodel/enum_definition.go
0
2
0.0%

hack/generator/pkg/jsonast/jsonast.go
1
3
33.33%

hack/generator/pkg/astmodel/package_definition.go
0
24
0.0%

Files with Coverage Reduction
New Missed Lines
%

hack/generator/pkg/astmodel/package_definition.go
18
0%

Totals

Change from base Build 110997802:
0.006%

Covered Lines:
1342

Relevant Lines:
4562

💛  - Coveralls


custom default fallback is not working

Description
"utter_default" as text is displaying for end-user,
instead of text set in the bot response for the utter_default
To Reproduce
Steps to reproduce the behavior:

Click to 'Responses' in side navigation
Click on "Add bot response" button located at top-right
Set text in "utter_response_name" as "utter_default"
Set any custom fallback text eg:"sorry,what do you mean?" in bot-response-input,
Navigate to Stories and train the bot
Now chat with bot & Enter some random text for which the bot is not trained
Observer the behavior is not modified and "utter_default" is uttered instead of bot-response set
for it

Expected behavior
custom fallback text set in  bot-response-input for utter_default should uttered instead of 'utter_default'
Screenshots

Desktop (please complete the following information):

OS: ubuntu 18.04
Browser chrome
Version 83.0.4103.61 (Official Build) (64-bit)

How are you running Botfront? What do the logs (botfront logs) say?

Hi @c-akhil , what fallback policy did you use? Are other responses working as expected or do you get utter-... for everything ? If this is the case the problem is that Rasa can't connect to the NLG server. You can fix that by checkling the logs )botfront logs and fixing the NLG in your endpoints


Please allow including configuration snippets

Hi,
Related to #1648, I would like to be able to import configuration snippets from other files. In particular, if I am managing the configuration files with ansible or a similar system, I need to split responsibilities (I have an ansible role for each exporter), and also I need a way to include manual configuration that won't be overwritten by the config management system.
Currently, not having this feature makes it very awkward to manage prometheus.yml with ansible..

This sort of topic has been discussed before. Prometheus is not a configuration management system, and this is the responsibility of systems like ansible. In this particular case I'd suggest using its assemble module, which is designed for exactly this.

Brian, I understand that argument, and I have seen the discussions in the past. But this is not about making it a cfg mgmt system, just adding a very common and very useful functionality... And it is something that would make integration at the system (debian) package level much easier (by having exporter packages dropping sample configurations for localhost scraping in the right place).
Plus, your suggestion is not really useful, as it requires running that ansible module every time something changes any part of the configuration, manual or not. It is almost like the sendmail scripts that ran M4 every time you changed configuration..

Why can't file_sd cover?

Why can't file_sd cover?

Because for that I need to have defined all the scrape configurations in advance in the main template. Instead, I would like to separate the general configuration from the scrape configuration, and drop a file that contains -say- all the configuration to scrape node-exporters. Right now, I have a simple ansible configuration for node/blackbox/selfmonitoring and alertmanager. But if I want to add one instance of one exporter, even to test it out, I need to create new ansible configuration and modify the main template to add it.
These are common problems for sysadmins for a long time, and that is why most important packages in debian use this mechanism, which works great for integration with other packages, while giving lots of freedom to the sysadmin and guaranteeing that manually added snippets are never touched by the packaging system.
I think this is so useful that I would probably add it to the Debian package myself when I get the time, but I really like to avoid deviating from upstream. Or maybe do it with a pre-processor hooked into the init script/service file, but that is a hack.

Closing for now as a dupe #5519 (which also links to previous requests).
However, given that this topic comes up now and then again, we'll put it on the agenda of the Prometheus dev summit to discuss it in more detail.


Remove handheld crew monitor

It's supposed to be a CMO computer.
It's getting powercrept and added everywhere.

I don't care much about the syndie but it baits people into shoving it into NT again.
Also I just found out there's massive copy-paste in head lockers so woopy.
(Discussed on discord).
:cl:

remove: Remove handheld crew monitors in lieu of computers.

Would it not be better to remove from tech instead and mark as objective? If its tech it makes sense paramedics every now and then get it, especially when medical can print them, albeit they cost a good chunk of materials.

Would it not be better to remove from tech instead and mark as objective? If its tech it makes sense paramedics every now and then get it, especially when medical can print them, albeit they cost a good chunk of materials.

Actually yeah, it could be tried as an objective, like the QM's digiboard, for instance.

Restricting + stealing a CM board is better as an objective than any number of pre-mapped handheld CMs.

So, crew monitor will be only in CMO office now? I do not envy paramedics unless its going to be special kind of monitor even if functionally same to the ones you can get from cargo for 2k.

I dont believe Origin has a crew monitor computer, though there is a board that spawns in maints.

Why not leave it as a researchable thing? It would make science more useful...why do we ever remove anything instead of adding something new?

I guess we need a disscussion label, i mean this notable change need to be discussion before implemeting, because it will hit a lot of stones in a water:

Rotting round remove, a lot of crew died in maints due of spacing, a lot of bodies,  under the shadow, paramed without monitor will not see the others bodies around.

Body could just be moved by shitters from a to b, that also spend paramedic time.

In conclusion parameds will just use crew monitor console as "portable" one, now this would be a bit out of character situation, yikes.

It seems to me a dubious decision. Anyone who is afraid of being found simply turns off the sensors. If it gets in the way, just remove the prescription from the technology, as before it will be the only one for the entire station, at the CMO or at the paramedic.

I think this change is too damaging to parameds, their job is already hard enough with most people not having coords on and them not having a mobile crew monitor will make it even harder. If you really want to remove it make it researchable by science or unmap it and put it into parameds locker/bag. Or maybe make a new item that isn't as strong? like maybe a special hud made for parameds which highlights crit people (with coords) with an arrow pointing to them or something.

billions must rot :trollface:

Also, my next sentence will be offtopic, but in another way it will be related on topic.
Powergaming and powegamers are not valid argument to these kind prs. I know that no one can teach people to not doing that stuff, but turning game into a "pillow room" because people are doing people stuff out of control, is not a variable answer. Deleting stuff that people over-using it, will not make anything good.
There is no variable option to fix powergaming, only co-exist with it. Cause powergaming is somehow but a dna of the space station.
I said my word about it.
But to stay in topic, so what about to add crew monitor as app in paramed and cmo pdas, hope there will be not a pesky powegamers, whom will beat to death crewmates to get it :trollface:

If you want something handheld pr a significantly nerfed version instead of free portable roundstart maphacks for all non-antags.

i understand why would you remove the roundstart monitor, but why remove it from the syndicate observation kit, making it pretty much useless, and from biochem tech? biochem is already research-starved and i don't think this is a good decision

biochem is already research-starved and i don't think this is a good decision

We don't add content for the sake of content as that's just unnecessary tech debt.

but why remove it from the syndicate observation kit

I'm going to remove the kit.

Now these will bring another type of question:
Why you anyway waited it for 6 hours, if you could just self-merge it from start?
Why you imade it in first place, if you ignored people?
These is kinda rude behavior imho, cause people brought thoughts and ideas to not just straight deleting it... it feels like that getting betrayed.

Why you anyway waited it for 6 hours, if you could just self-merge it from start?
Why you imade it in first place, if you ignored people?

I talked about it on discord with other maintainers. Once talking was done it got merged but more talking can also happen later as that's how development goes.

This is a sad day for all paramedics and rotting people.

This is a sad day for all paramedics and rotting people.

We don't add content for the sake of content as that's just unnecessary tech debt.

Highly disagree. The one thing space station needs the most is more random events and more content


Where are the backend logs?

How do I turn on logging or change the logging level of the backend and where/how can I see the logs?

That would be outside the scope of this example project. Logging could be at the API or database level. There are dozens of approaches. Here's an article I found using Google...
https://jeffmcmorris.medium.com/awesome-logging-in-sveltekit-6afa29c5892c
Generally, the place to log API calls would be in hooks.server.ts...
https://kit.svelte.dev/docs/hooks


Update getdata() to exit when query complete

My open-retractions didn't after completing an npm run update.
The CrossRef API page keeps returning cursors, beyond the final page (e.g., this page, if the link doesn't expire). It seems like this made the program go into an infinite cursor follow.
By adding this if clause, the query seemed to exit properly (from my limited testing).

Good catch

:shipit: shipped in v0.0.9


feature request: mark artwork/sourcecode's use of RFC 8792 line folding

That would allow to enhance the display; see for instance https://www.ietf.org/archive/id/draft-ietf-httpbis-digest-headers-10.html#section-2 for how intrusive the current notes are.

(I assume that this is a vocabulary request?)

Potentially, so that the renderers can insert the "NOTE..." automatically, and style it less intrusively.
(Of course this could be done with heuristics, which I'll try in my XSLT as a POC)

I mentioned the kramdown-rfc functionality because xml2rfc might also want to provide some authoring support that would be triggered by some new vocabulary, although that might be a more radical idea.

FWIW, here's a POC for rendering: https://greenbytes.de/tech/webdav/draft-ietf-httpbis-digest-headers-latest.html#rfc.section.2.p.3

Proposed grammar: fold = none | end | both

Good folding is way more elaborate.  I prefer to do this before committing to RFCXML.
(Yes, there needs to be some rendering assist, but only that.)

This thread has confused me a bit, so here's my understanding of what is being asked for:

<artwork> needs to have a new attribute that can be used to indicate that the content of the artwork has been folded.
This is so that the folding does not need to be noted inside the <artwork> and can be managed by styling.
It is explicitly not asking for automated folding inside <artwork> as that is best left to authors.

So the question is then which of the following three grammar constructs is better:

<artwork folded="true">
<artwork format-notes="folded">   (could then be expanded to format-notes="folded,rtl" or other format hints)
<artwork fold-delimeter="\">  (in case we ever use another delimeter)

Proposed grammar: fold = none | end | both

@martinthomson - what would these values mean? Am I missing something here?

Note that RFC 8792 has two kinds of folding (Section 7 and Section 8); which of them is being used needs to be indicated ('' or '\' folding).

Note that the spec of this would need to update RFC 8792, Sections 7.1.1 and 8.1.1.

Note that RFC 8792 has two kinds of folding (Section 7 and Section 8); which of them is being used needs to be indicated ('' or '' folding).

Which suggests that the grammar change should be <artwork fold-delimeter="\">

Note that the RFC 7991 way of naming attributes is studlyCaps (camelCase).
(There are counter-examples, such as quote-title/suppress-title and subitem/fullname/colspan/rowspan, but the studlyCaps way is the dominant one.)
I would avoid monsters like "fold-delimiter" and just use "fold" anyway.

FWIW, RFC 7991 uses "quoteTitle", but somebody preferred to rename it.

FWIW, RFC 7991 uses "quoteTitle", but somebody preferred to rename it.

Actually, xml2rfc has both:
       attribute quoteTitle { "true" | "false" }?,
       attribute quote-title { "true" | "false" }?,

You can't make this up.

@reschke,

Proposed grammar: fold = none | end | both

@martinthomson - what would these values mean? Am I missing something here?

none = no folding
end = RFC 8792 "" folding with "" only at the end of the line
both = RFC 8792 "\" folding with "" at the end of the line followed by "" at the start of the line

Because this is a request that impacts grammar, I suggest removing the rpat label from this issue and applying the rswg label.


[YUNIKORN-2503] Use internal annotation prefix for placeholder pod

What is this PR for?
Based on the design doc in YUNIKORN-1351 .

Remove label 'placeholder' in placeholder pod
Reanme placeholder's annotation to 'yunikorn.apache.org/placeholder' to  'internal.yunikorn.apache.org/placeholder'

(2024/03/30 Update eb274a458e3a431bc27b44a272f43bdc922317f6)

Support old placeholder metadata until v1.7.0.

What type of PR is it?

[x] - Improvement

Todos
NA
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2503
How should this be tested?
All existing e2e test should pass.
Screenshots (if appropriate)

Questions:
NA

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.80%. Comparing base (8be3910) to head (9b58d89).
Report is 6 commits behind head on master.

:exclamation: Current head 9b58d89 differs from pull request most recent head 848ac36. Consider uploading reports for the commit 848ac36 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #808   +/-   ##
=======================================
  Coverage   71.79%   71.80%
=======================================
  Files          43       43
  Lines        6351     6353    +2
=======================================
+ Hits         4560     4562    +2
+ Misses       1589     1588    -1
- Partials      202      203    +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Update to latest codebase.
@chia7712 @brandboat Could I have your review?

I guess we need a follow-up to update docs, right?

Yes. I will remove the internal placeholder label/annotation from user guide without any deprecated warning.
(Since we don't expect any users to be using the internal placeholder. )

https://yunikorn.apache.org/docs/next/user_guide/labels_and_annotations_in_yunikorn


log level check implemented

Fix for https://github.com/chaos-mesh/chaosd/issues/98

@WangXiangUSTC @Hexilee please review