chore: release main

:robot: I have created a release beep boop
@markdown-confluence/cli: 5.5.0
5.5.0 (2023-06-29)
Bug Fixes

yargs is a dep of lib not cli (aca0a8b)

Dependencies

deps: bump puppeteer/puppeteer in /packages/cli (2cd503f)
deps: bump puppeteer/puppeteer in /packages/cli (9af5ed9)
deps: bump puppeteer/puppeteer in /packages/cli (bd8fa02)
deps: bump puppeteer/puppeteer in /packages/cli (6a6fc35)
deps: bump puppeteer/puppeteer in /packages/cli (ccb7cc0)
The following workspace dependencies were updated

devDependencies

@markdown-confluence/lib bumped from 5.4.0 to 5.5.0
@markdown-confluence/mermaid-puppeteer-renderer bumped from 5.4.0 to 5.5.0

@markdown-confluence/lib: 5.5.0
5.5.0 (2023-06-29)
Features

FolderNote: Add README.md and readme.md as options for folder note file names (81ee277)

Bug Fixes

yargs is a dep of lib not cli (aca0a8b)

Dependencies

deps: bump @atlaskit/adf-schema from 25.6.2 to 25.6.4 (fa96d3d)
deps: bump @atlaskit/adf-utils from 18.2.1 to 18.2.3 (ebc6895)
deps: bump @atlaskit/adf-utils from 18.4.1 to 18.4.2 (2d63294)
deps: bump @atlaskit/editor-common from 72.9.0 to 74.0.1 (769f692)
deps: bump @atlaskit/editor-common from 74.1.1 to 74.2.1 (366135b)
deps: bump @atlaskit/editor-common from 74.2.1 to 74.7.8 (6287545)
deps: bump @atlaskit/editor-json-transformer from 8.8.4 to 8.9.1 (cc6b4a9)
deps: bump @atlaskit/editor-json-transformer from 8.9.1 to 8.9.3 (ce755a7)
deps: bump @atlaskit/editor-json-transformer from 8.9.3 to 8.9.4 (dee45c7)
deps: bump formdata-node from 5.0.0 to 5.0.1 (16322c8)
deps: bump glob from 10.2.2 to 10.2.4 (94bbf5b)
deps: bump glob from 10.2.4 to 10.2.7 (ecb7c77)
deps: bump prosemirror-markdown from 1.10.1 to 1.11.0 (9d6ac07)

@markdown-confluence/mermaid-electron-renderer: 5.5.0
5.5.0 (2023-06-29)
Dependencies

deps: bump mermaid from 10.1.0 to 10.2.0 (d2b2080)
deps: bump mermaid from 10.2.0 to 10.2.3 (d04cd97)
The following workspace dependencies were updated

dependencies

@markdown-confluence/lib bumped from 5.4.0 to 5.5.0

@markdown-confluence/mermaid-puppeteer-renderer: 5.5.0
5.5.0 (2023-06-29)
Dependencies

deps: bump mermaid from 10.1.0 to 10.2.0 (d2b2080)
deps: bump mermaid from 10.2.0 to 10.2.3 (d04cd97)
deps: bump puppeteer from 20.1.2 to 20.3.0 (37c8524)
deps: bump puppeteer from 20.3.0 to 20.7.2 (7ca65d5)
deps: bump puppeteer in /packages/mermaid-puppeteer-renderer (cbebca5)
deps: bump puppeteer in /packages/mermaid-puppeteer-renderer (146597b)
The following workspace dependencies were updated

dependencies

@markdown-confluence/lib bumped from 5.4.0 to 5.5.0

obsidian-confluence: 5.5.0
5.5.0 (2023-06-29)
Miscellaneous Chores

obsidian-confluence: Synchronize obsidian packages versions

Dependencies

The following workspace dependencies were updated

dependencies

@markdown-confluence/lib bumped from 5.4.0 to 5.5.0
@markdown-confluence/mermaid-electron-renderer bumped from 5.4.0 to 5.5.0

obsidian-confluence-root: 5.5.0
5.5.0 (2023-06-29)
Features

FolderNote: Add README.md and readme.md as options for folder note file names (81ee277)

Bug Fixes

yargs is a dep of lib not cli (aca0a8b)

Dependencies

deps: bump @atlaskit/adf-schema from 25.6.2 to 25.6.4 (fa96d3d)
deps: bump @atlaskit/adf-utils from 18.2.1 to 18.2.3 (ebc6895)
deps: bump @atlaskit/adf-utils from 18.4.1 to 18.4.2 (2d63294)
deps: bump @atlaskit/editor-common from 72.9.0 to 74.0.1 (769f692)
deps: bump @atlaskit/editor-common from 74.1.1 to 74.2.1 (366135b)
deps: bump @atlaskit/editor-common from 74.2.1 to 74.7.8 (6287545)
deps: bump @atlaskit/editor-json-transformer from 8.8.4 to 8.9.1 (cc6b4a9)
deps: bump @atlaskit/editor-json-transformer from 8.9.1 to 8.9.3 (ce755a7)
deps: bump @atlaskit/editor-json-transformer from 8.9.3 to 8.9.4 (dee45c7)
deps: bump actions/checkout from 3.5.2 to 3.5.3 (ccf0820)
deps: bump actions/dependency-review-action from 3.0.4 to 3.0.6 (550a22f)
deps: bump docker/build-push-action (f6eaf6d)
deps: bump docker/build-push-action (a3274e8)
deps: bump docker/build-push-action from 4.1.0 to 4.1.1 (a8c1037)
deps: bump docker/login-action (c81bf32)
deps: bump docker/metadata-action from 4.4.0 to 4.5.0 (161e8fd)
deps: bump docker/metadata-action from 4.5.0 to 4.6.0 (ff4d14b)
deps: bump formdata-node from 5.0.0 to 5.0.1 (16322c8)
deps: bump github/codeql-action from 2.3.3 to 2.3.5 (c227142)
deps: bump github/codeql-action from 2.3.5 to 2.13.4 (7736586)
deps: bump glob from 10.2.2 to 10.2.4 (94bbf5b)
deps: bump glob from 10.2.4 to 10.2.7 (ecb7c77)
deps: bump google-github-actions/release-please-action (40bb951)
deps: bump google-github-actions/release-please-action (bb40179)
deps: bump mermaid from 10.1.0 to 10.2.0 (d2b2080)
deps: bump mermaid from 10.2.0 to 10.2.3 (d04cd97)
deps: bump ossf/scorecard-action from 2.1.3 to 2.2.0 (9ae6b39)
deps: bump prosemirror-markdown from 1.10.1 to 1.11.0 (9d6ac07)
deps: bump puppeteer from 20.1.2 to 20.3.0 (37c8524)
deps: bump puppeteer from 20.3.0 to 20.7.2 (7ca65d5)
deps: bump puppeteer in /packages/mermaid-puppeteer-renderer (cbebca5)
deps: bump puppeteer in /packages/mermaid-puppeteer-renderer (146597b)
deps: bump puppeteer/puppeteer in /packages/cli (2cd503f)
deps: bump puppeteer/puppeteer in /packages/cli (9af5ed9)
deps: bump puppeteer/puppeteer in /packages/cli (bd8fa02)
deps: bump puppeteer/puppeteer in /packages/cli (6a6fc35)
deps: bump puppeteer/puppeteer in /packages/cli (ccb7cc0)
deps: bump snyk/actions (27a13fa)
deps: bump step-security/harden-runner from 2.4.0 to 2.4.1 (5e17ce0)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/markdown-confluence/markdown-confluence/releases/tag/obsidian-confluence-v5.5.0 :sunflower:

:robot: Release is at https://github.com/markdown-confluence/markdown-confluence/releases/tag/%40markdown-confluence/lib-v5.5.0 :sunflower:

:robot: Release is at https://github.com/markdown-confluence/markdown-confluence/releases/tag/%40markdown-confluence/mermaid-electron-renderer-v5.5.0 :sunflower:

:robot: Release is at https://github.com/markdown-confluence/markdown-confluence/releases/tag/%40markdown-confluence/cli-v5.5.0 :sunflower:

:robot: Release is at https://github.com/markdown-confluence/markdown-confluence/releases/tag/%40markdown-confluence/mermaid-puppeteer-renderer-v5.5.0 :sunflower:

:robot: Release is at https://github.com/markdown-confluence/markdown-confluence/releases/tag/obsidian-confluence-root-v5.5.0 :sunflower:


MINOR: Update jetty to 9.4.33

Jetty 9.4.32 and before are affected by CVE-2020-27216. This vulnerability is fixed in Jetty 9.4.33, please see the jetty project security advisory for details: https://github.com/eclipse/jetty.project/security/advisories/GHSA-g3wg-6mcf-8jj6#advisory-comment-63053
Unit tests and integration tests pass locally after the upgrade.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

For applying this fix to older branches, this commit can be cherry-picked to
2.7 branch. For branches 2.6 and earlier, jersey version also needs to be
upgraded to 2.31 based on the following note in 2.5 and 2.6 branches
that are on jetty 9.4.24: https://github.com/apache/kafka/blob/2.6/gradle/dependencies.gradle#L71
For validating that this change can be backported, I have prepared commits in
my own fork for older branches going back till 2.4 and ran the tests locally.
To assist in applying the fix to older branches, these can serve as a reference
for what the exact change is. Or I can create new pull requests to the older
branches if that's easier.

For 2.7, unit/integration tests pass locally. Reference commit: https://github.com/niteshmor/kafka/commit/8b51bd18f4541d1edb7d423a01314f78f1988fe8
For 2.6, 2 tests failed locally, but I believe they are unrelated. The failed tests are:

SslAdminIntegrationTest.testCreateTopicsResponseMetadataAndConfig
ReplicaManagerTest.testFencedErrorCausedByBecomeLeader
Reference commit: https://github.com/niteshmor/kafka/commit/a0d3dc0f2e490d04b324ad72c47cd1363cc9dd6c

For 2.5, unit/integration tests pass locally. Reference commit: https://github.com/niteshmor/kafka/commit/f8f68c334132dd293d96d5be1a1c3d307896cefa
For 2.4, unit/integration tests pass locally. Reference commit: https://github.com/niteshmor/kafka/commit/9c08944c3c793c7733e0971a68dcb580dd4c288f

cc @ijuma @kkonstantine @rhauch @C0urante

Test failure seems to be unrelated.
java.nio.file.DirectoryNotEmptyException in org.apache.kafka.streams.integration.StreamTableJoinTopologyOptimizationIntegrationTest

Merging to trunk and older branches.

Thanks @omkreddy
For older releases, feel free to use the commits noted in https://github.com/apache/kafka/pull/9556#issuecomment-721898016 as a reference. Git cherry-picking didn't work for me, and older versions required jersey upgrade anyways.


Build currently failing due to Central version; consider JitPack?

This is just a suggestion, but...
I've started using JitPack (a Maven-Central-like jar repository that builds GitHub releases of Maven, Gradle, and other projects whenever someone depends on them, and also allows building and depending on individual commits) often for my Java code, and it seems to be holding up well. The build status on Travis CI currently seems to be failing due to 0.2.1 not yet being uploaded to Maven Central, and I know some of the Central requirements are annoying and time-consuming. At least during development, maybe you could try changing the dependencies of projects to JitPack? 0.2.1 is ready to build once a project depends on it and requests it from JitPack, since there's a GitHub release; see this for more https://jitpack.io/#jtransc/jtransc/0.2.1 .Central doesn't allow other repositories to be used on projects hosted on their repository, but you could switch out the JitPack repository for Central if you have a stable build you want available via the standard way.
Only downside is, the first person to request a version or commit needs to wait for the project to build, and if any of the Maven projects depend on Haxe to complete a mvn install step (without running tests), there probably won't be any way for JitPack to build each release. Although, Travis CI seems to be doing fine, and I don't know if it has Haxe installed. If you log in to JitPack with your GitHub account, you can tell JitPack to try to build a release or commit early, in case you want a release to build "in the background" and then be available to other projects when they request it in a few minutes.
I don't know if this is a valid suggestion for this particular project, but I think it might help ease the hassle of releasing.

I will check JitPack.
Since I'm installing jtransc-rt-core and jtransc-rt before the proper installing (because I'm using JAR files from .m2 folder in jtransc) I thought it would work. But it seems that jtransc-rt-core has jtransc as its parent and it seems to fail there).
I should try to relax the requirement of installing rt and rt-core before. Maybe tests could use target folder with class files instead of jar files from the m2 folder. Because packaging+installing happens after test have passed.
This repo should not have dependencies (aside from kotlin, asm and junit).
And you are right that central is pretty picky and time consuming. And I didn't know about JitPack, and seems pretty cool :) I will try. Probably with https://github.com/jtransc/gdx-backend-jtransc and other projects.

BTW: Theee days I had several meetings and I had to work on other stuff. Now I'm again with jtransc and probably will work on it a bit this weekend. I'm going to fix this first and later I will check the gdx opengl c++ problem. It seemed that it was working, but nothing was shown.  Did you find out something about it?

Ah, sorry for the late reply. I was just looking for open source ahead-of-time compilers for Java code, somehow it slipped my mind that JTransc does that too. In fact, other than GCJ, which is compatible only with Java 1.5 (maybe not even that?), there's almost no projects that do this kind of work. It seems like you've found an excellent way to reuse the stable, proven Haxe compiler for what would otherwise seem like mad science; targeting "every platform ever" with Java is not something even existing commercial tools do (i.e. Excelsior JET).
I'll try to build and run the C++ GDX demo again. Does hxcpp cache pre-built standard library files? The first build took a very long time to even get to an error. I'll clean the project anyway to ensure nothing old and broken gets used again.

Yeah. There is no other opensource multitarget aot for jvm as far as I know.
Last version of jtransc (without minimized names) should reuse files between hxcpp compilations. Previously adding/removing methods caused everyhting to compile again. Due to method ids changing for every method in every class. Now method ids are local to classes. Also release builds and debug builds with lime are in different folders now. So changing release type do not trigger everything to recompile.
Haxe 3.2 has a bug in c++ target that I trigger in some cases. Not sure if it was in Java Std or Kotlin Std related to inheritance. It doesnt happen in other targets. You will have to use Haxe 3.3. That means nightlies until they release 3.3Rc1, which I expect they release soon. I can assist you getting it in the mean time.
I have to check wether gdx backend is updated to the lastest git version.

Sometime ago we were evaluating options:

Using KotlinJs to target js everywhere and use Apache Cordova for mobile. KotlinJs was not too much mature by then, and didn't provide the reflect capabilities we needed. Also that was not allowing us to target to flash to do some integrations.
Native for Android + TeaVM for JS + RoboVM for iOS + totally ignore WP and flash. TeaVM is just a great piece of software, but it has a metaprogramming approach instead of reflection and it is focused on javascript. We wanted reflection, and have several targets. For peace of mind to avoid another huge rewrite of everything. Didn't want to depend on RoboVM (which turned to be a right decision). So we ended discarding that option too.
Not using Kotlin at all. Kotlin is one of the most productive language to date and allowed us to share code with our extensive backend server that we were not going to change.

So creating JTransc was the best option.

Since builds/tests are fixed and are already self-contained and not depending on maven. I'm going to close this.
Thanks for the JitPack suggestion. I know a couple of sites I'm going to use it (for example here https://github.com/EsotericSoftware/spine-runtimes/tree/master/spine-libgdx ) :) But I think it is not required for jtransc anymore.


[Theme] Setup A/B/C Sign up button test

Run a test on our global header sign up button again  with Start now / Free account / Sign up as the button terms.
Acceptance Criteria

[ ] Setup a split test to run for 2 weeks on different button language
[ ] Start now / Free account / Sign up

Please add your planning poker estimate with ZenHub @roadlittledawn

I created a new split in Split IO called deven_signupbutton_text with a 50/50 rule on "Start now" vs "Free account."


Fix typo in test

I'm troubleshooting a situation on Tembo cloud. I'm manually breaking an instance on purpose to check how error reporting will work.
I ran ALTER SYSTEM SET shared_preload_libraries = 'oopsies';, then restarted my instance using the restartedAt annotation. Now, my instance is stuck in readiness 0/1 but liveness probe is passing, however I expected liveness probe to fail because pg_isready is not success. I found liveness probe is passing because the condition "MightBeUnavailable" is true, but I don't know why that is yet, currently I suspect it's related to triggering a restart.
I noticed this typo in the test while reviewing how "MightBeUnavailable" works.

After deleting pod manually, liveness probe is failing, so I think this is indicates that MightBeUnavailable is set during restart, and it doesn't know if restart is in progress or if pod is failing to start due to some change applied during restart. I can check docs or code for some setting like "restart timeout"

Hi, yes that's intentional, the operator waits for the instance to come back up after a restart, as that could take an arbitrary amount of time depending on how much data it has to replay.


Openload File not found error

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.10.29. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[ X ] I've verified and I assure that I'm running youtube-dl 2017.10.29

Before submitting an issue make sure you have:

[ X ] At least skimmed through the README, most notably the FAQ and BUGS sections
[ X] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ X] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
youtube-dl https://openload.co/f/9fvzmtdyTpA (WARNING: NSFW)
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'https://openload.co/f/9fvzmtdyTpA', u'-v']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.10.29
[debug] Python version 2.7.10
[debug] exe versions: ffmpeg 3.4, ffprobe 3.4, phantomjs 2.1.1
[debug] Proxy map: {}
[Openload] 9fvzmtdyTpA: Downloading webpage
ERROR: 9fvzmtdyTpA: File not found
Traceback (most recent call last):
  File "youtube_dl/YoutubeDL.py", line 784, in extract_info
    ie_result = ie.extract(url)
  File "outube_dl/extractor/common.py", line 434, in extract
    ie_result = self._real_extract(url)
  File "youtube_dl/extractor/openload.py", line 309, in _real_extract
    raise ExtractorError('File not found', expected=True, video_id=video_id)
ExtractorError: 9fvzmtdyTpA: File not found

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.

This looks like a copyrighted video. Any other examples?

@yan12125 fixed

This seems to be an issue with openload itself as the embedded link seems to be dead even though the file link is alive.
ex:
You linked: https://openload.co/f/e-Ixz9ZR5L0/ which is very much live and I can see the video on it
The extractor is attempting to pull the video with the embed link of: https://openload.co/embed/e-Ixz9ZR5L0/ which for some reason is saying the file is removed
I'll work on a patch for openload extractor to try both links as extracting with the openload.co/f/ link works I just need to make sure it doesn't introduce any unexpected bugs.

@zachee Thank you for the patch!!


Hover displays X label with a wrong offset

Normally I want to display the following graph:

When I move the mouse cursor to see the upper values, I get the following result:

Where I can not see the X Label, because Y Label overrides it.
Expected behavior should be something like this:

Could you provide an example, for this? I'm worried that the proposed fix may affect surrounding HTML elements negatively.

An example that demonstrates the issue, right? There is no special code required here, the following graph produces the same issue: http://code.shutterstock.com/rickshaw/examples/lines.html


[FEATURE REQUEST] Allow VirtualizedScrollRectList to be reused

Problem
Based on my understanding, during runtime, once a VirtualizedScrollRectList is created, it cannot be reset. I would like to be able to reuse the menu for different list of items.
The OnValidate method already seems to do this. A solution could be to make this public method
https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/blob/f669f5aef4141ed3f949a2913a40e386c5444b2e/org.mixedrealitytoolkit.uxcore/Experimental/List/VirtualizedScrollRectList.cs#L314-L324

Hi @ahmed-shariff  thank you for your request.   This seems like a valid feature worth investigating.


Add /skip-build to automated release commits

What can be improved
The automated release commits are all related to release notes and build is not really needed to run.
Why
Add /skip-build to bot commits

Fixed by https://github.com/maistra/istio-workspace/commit/87a9b23e1c7c75c928c960b3ebe76ab84ea13e88


Add missing readme files

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   91.47%   91.47%
=======================================
  Files          70       70
  Lines         985      985
  Branches      194      194
=======================================
  Hits          901      901
  Misses         36       36
  Partials       48       48


Add auto-snooze option to alarms

What the title says: this adds an "auto-snooze" option to the alarm editor which, if enabled, schedules a new round of buzzing 10 minutes later as if the snooze button was clicked.
I also added a behaviour fix for snoozing: the way it's implemented currently, snoozing adds 10 minutes to the alarm time and saves it; this means that, for repeating alarms, the next run will be 10 minutes * number of snoozes later, which is not something the user would expect.

This looks great - thanks!


set-output is deprecated

I'm getting the following warning:
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I suspect the @github/actions package needs to be updated, since it seems set-output is being used under the hood.

@mikestopcontinues I'm not seeing this warning on any of my workflows using this action. The @actions/core package is currently on version 1.10.0 which should already contain a fix according to this comment and the release notes.  Are you using the newest version of this action and sure that the warning is caused by it ?

I'm as confident as I can be. If I disable just the plugin, the warning disappears. (I just tried again.)
Is it possible one of the conditions in the comment aren't being met? In particular, does $GITHUB_OUTPUT need to be set manually in addition to core.setOutput()?
Here's the error:

Here's my config:
      - name: Lookup Last Success
        id: last-success
        uses: SamhammerAG/last-successful-build-action@v2
        with:
          branch: ${{github.ref_name}}
          workflow: ${{github.workflow}}
          token: ${{github.token}}
          verify: false

The Update of @actions/core to 1.10.0 was in version 3. Can you try using the current version (@v4) and see if the warning still appears?

I'm sorry, @domi2120, I was just looking at the docs for the version number. It works now! Thanks for the help!


Support anyof between href and hw reservation in device

For metal-go, we took a different approach with the patch in order to avoid introducing the XOrHref pattern in places where it's not strictly necessary: https://github.com/equinix-labs/metal-go/pull/80
The approach taken in that patch is likely what we would do upstream for simple cases like this where a property does not require polymorphism (a device.hardware_reservation will always be a HardwareReservation, even if the only property defined for it is device.hardware_reservation.href).  By contrast, we'll always have something that looks like XOrHref for virtual circuits, because a VirtualCircuit could be either a VlanVirtualCircuit or a VrfVirtualCircuit, so when a virtual_circuit property only contains an href, we can't tell which one it is.)

@ctreatma @displague
I found semantic issue, with not following ModelOrHref pattern.
In the spec, HardwareReservation model leverages Device model for attribute device, whereas with Device model leverages HardwareReservation causing a cyclic dependency between two models. And if either of them add required parameter in future then we start facing deserialisation issue across both model because passing only href response won't be enough.
HardwareReservation  schema : https://github.com/equinix-labs/metal-java/blob/main/spec/oas3.stitched/oas3.stitched.metal.yaml#L11891
Device schema : https://github.com/equinix-labs/metal-java/blob/main/spec/oas3.stitched/oas3.stitched.metal.yaml#L11248


Error when using preferred Attribute Routing api versioning in .net core 1.1

I created a new api controller containing 2 namespaces with the following route attribute on it:
namespace Apps.Api.Core.Controllers
{
    [ApiVersion("2.0")]
    [Route("api/v{version:apiVersion}/[controller]")]
    public class FooController : Controller
    {
         [HttpGet]
        public IActionResult Get()
        {
            return Ok(testset);
        }
    }
}

namespace Apps.Api.Core.Controllers.Deprecated
{
    [ApiVersion("1.0", Deprecated = true)]
    [Route("api/v{version:apiVersion}/[controller]")]
    public class FooController : Controller
    {

       [HttpGet]
        public IActionResult GetLegacy()
        {
            return Ok(testset);
        }
  }
}

In my startup.cs i have the following code to define versioning:
services.AddApiVersioning(o => {
                o.ReportApiVersions = true;
                o.AssumeDefaultVersionWhenUnspecified = true;
                o.DefaultApiVersion = new ApiVersion(2, 0);
            });

This works correctly and I am able to hit both of these endpoints via postman at:
http://localhost:28293/api/v2/Foo
and
http://localhost:28293/api/v1/Foo
However, I am getting the following error when generating swagger:

NotSupportedException: HTTP method "GET" & path "api/v{version}/Foo" overloaded by actions - Apps.Api.Core.Controllers.FooController.Get (Apps.Api.Core),Apps.Api.Core.Controllers.Deprecated.FooController.GetLegacy (Apps.Api.Core). Actions require unique method/path combination for Swagger

Commenting out the legacy namespace does resolve this issue.
According to the article you call out on similar issues here:
http://blogs.msdn.com/b/webdev/archive/2014/08/22/customizing-web-api-controller-selector.aspx
attribute routing is the preferred method of doing this.

Have you configured SB to split each API version into a separate Swagger document as described here - https://github.com/domaindrivendev/Swashbuckle.AspNetCore#generate-multiple-swagger-documents?
NOTE: You should read through that whole section and pay special attention to the sub-section entitled "Customize the Action Selection Process" as that provides a hint around specifically doing this with ApiVersion attributes.

Ah thanks, was reading much further down in the doc about Listing multiple swagger docs and not generating multiple swagger docs. Confirmed working now.


#143 - Inline code completion feature

@dishankjindal1 we have merged the commits with some improvements in #186


Auto correlation of telemetry events

We have our own SDKs built on top of application insights, earlier we have talked on correlation and distributed tracing, we were doing some custom implementation on handling a cross correlation id which is similar to operationId.
We did some progress on this for .net core application, we are finding it difficult to do the same for .net application.
In .net core we used Activity and System.Diagnostics intercepted the Http calls to attach the cross correlationid the way it is done in Application insights SDK, but when it comes to .net application (For ex: ASP.net webapi)  we are facing issues in retaining the Activity baggage values, when the Http request completes the Activity becomes null.
I wanted to understand if there is any limitation specifically for .net applications (from 4.5 to 4.6.2) or in the dependent libraries like Diagnostics

I am not sure if this is a question for this repo. This repo is just a consumer of the DiagnosticSource events emitted by the actual libraries/frameworks. So if you find an issue with .NET or Asp.NET WebApi 'losing' baggage and Activity becoming null - its an issue to be opened with the corresponding repo.
An if the issue is real bug - then application insights (in this repo) is also likely affected. We are interested in it, but cannot investigate it. If you share a minimal repo, then we can try to investigate, but its best opened in the corresponding repo.


IMPORT FAILED

No module named 'torchvision.transforms.v2'
No matter what I do, uninstalling comfy, or updating it, I can't get it to work

you have an old version of torch or you are installing the dependencies in the wrong environment. Be sure to execute the python inside the comfyui installation

solved. For anyone encountering this, in \venv\Scripts I updated to the latest torch


Feat: migrate local data via postMessage

This PR adds a new HTML file that helps perform the migration of locally stored data to another domain.

Listens to postMessage events
Check that the event comes from an allowed host
Sends the entire localStorage back to that window

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 40.46%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4395

Relevant Lines:
9937

💛  - Coveralls

I suggest we merge it already now to test the integration on prod on the web-core domain.


Union type incorrectly narrowed to only default value type in catch block

TypeScript Version:  3.2.2 (However, I believe it exists in typescript@next as well)

Search Terms:
Incorrect type narrowing in catch
type narrowing union catch
type narrowing union default
union default incorrect type
Code
function otherWork() { throw new Error("Hi!"); }
function getNum() { return 3; }

function foo() {
    let x: number | null = null;
    try {
        x = getNum();
        otherWork();
    } catch (e) {
        console.log(x && x.toString()); //Error, type of x is null, not number | null
    }
    x;
}

Expected behavior:
The type of the first x in console.log(x && x.toString()) should have type number | null, the second x in x.toString() should have type number.
Actual behavior:
The first x has type null, the second x has type never (as expected if the first x has type null).  The type of the last x, in x; has the correct type number | null
Playground Link:
https://typescript-play.js.org/#code/GYVwdgxgLglg9mABHKALApgJwOp0wawAoBKRAb0TUzgHdEx06BRTazQgIgAkYBCD4gG5EAXwBQoSLASIA5uigA5EAFsS5RJgUhMSAMzDxE8NHhJgcOOrJjEdxABsFiAB4AueqoBGWRAB9PBwdEAF5Ah0FbeyhMAE9yKPt7F1C5BWU1IUSk5DQsXAISSKSRRAgAQygIVERCdFIbHPsIBABnOCcAOgc4WUIUgDIB106oOABlGJgwPuIhRAB6BZY2ABpKWIAHdGRgV0QYVvD1sBRPFR9Mf3Ds8SSXSJEgA
Related Issues:
None

I don't know enough about the ts compiler to know for sure, but it does appear that the PR to fix #28153 should also fix this.  Should this be marked as a dup of #28153?


[FIX] dai.ImgTransformations is None for RVC2 device

This PR adds a hotfix for using RVC2 device with depthai v3_develop. The issue is that the dai.NNdata has self.transformation set to None. This is a know issue in depthai and will be fixed in comming updates.
The PR was tested on both RVC2 and RVC4 on the following models:
lane detection, depth anything, face landmarks, yolov8 instance seg, selfie seg, scfrd face detection, yolo v6, text detection

Codecov Report
Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 33.31%. Comparing base (37a2d92) to head (93f1e60).
Report is 16 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines
Patch %
Lines

depthai_nodes/ml/messages/classification.py
0.00%
3 Missing :warning:

depthai_nodes/ml/messages/clusters.py
0.00%
3 Missing :warning:

depthai_nodes/ml/messages/img_detections.py
0.00%
3 Missing :warning:

depthai_nodes/ml/messages/keypoints.py
0.00%
3 Missing :warning:

depthai_nodes/ml/messages/lines.py
0.00%
3 Missing :warning:

depthai_nodes/ml/messages/map.py
0.00%
3 Missing :warning:

depthai_nodes/ml/messages/prediction.py
0.00%
3 Missing :warning:

depthai_nodes/ml/messages/segmentation.py
0.00%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   33.40%   33.31%   -0.09%
==========================================
  Files          68       69       +1
  Lines        3739     3836      +97
==========================================
+ Hits         1249     1278      +29
- Misses       2490     2558      +68

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I suggest that we dont merge features to main if they dont work with alpha releases because they can break the code and parsers dont work. Can we keep features in separate branches till alphas support them? Thoughts?

Agreed, it was done on alpha6, just that I did not tryout RVC2 afterthe fact.


PyInstaller cause bug, exception and no toast displayed(with workaround)

When trying to pack into an exe with pyinstaller many user got an error that something went wrong despite everything working correctly on script. I have found the issue to be the preconfigured icon because pyinstaller does not recognize it as a resource when running as an exe.
Solution:
just pass a custom icon in the toast. you will get an error not finding it if it's not in exe's folder but it will work

Thanks you for your reply . It works with icon path mention .
icon won't be add to exe file but can be used if put inside dist folder :)


HomeKit buttons won't work unless i press any button on my LG remote first - then they all work as expected.

Is this a known issue?

That is quite strange, not sure why it is like for you but that should not be the case. Maybe some settings on your TV?


Incompatible with Composer 2.0

Upstream Report of https://github.com/OpenMage/magento-lts/issues/1290
Related: https://github.com/Cotya/magento-composer-installer/issues/191

@AydinHassan @Flyingmana we can close this out as it has been resolved in issue 2.0.0.


Question: How does mui-tiptap maintain text selection when controls are clicked

Hey, sorry this isn't a feature request but I couldn't figure out the best way to ask a question!
I haven't actually been using it, but this package is great! I've been working on my own implementation of TipTap for Chakra UI, and this package has provided a lot of useful examples of how to make custom extensions and properly type some of the examples they have in the original demos.
The one thing I have not been able to figure out though, is how you manage to maintain the text selection inside the editor when other elements are focused. In my case specifically, I'm trying to prevent a selected block of text from unselecting as soon as I click on the font selector dropdown. I've found some hacky ways to do it by re-selecting the current selection after the dropdown opens, but it prevents my dropdown from being interactable (using my chakra wrapper for react select). I'd be very grateful if you could provide any info on how you managed to accomplish this, even if that's just to point me somewhere in this repo where you handle that.

Actually, not that I'm looking at it, I think this might be an issue with react-select specifically breaking the default selection behavior and have nothing to do with something specific you did. I'm going to close this, sorry

@csandman glad mui-tiptap has been useful as a reference! No worries about opening the issue, and glad you found the underlying cause. Like you suggested, I don't believe I'm doing anything special. In general, my approach is to just focus() the editor again once the action is complete. e.g. for font size, it calls focus() on change of the value:
https://github.com/sjdemartini/mui-tiptap/blob/82271b8e2a66cba742762fda1cdb80f7414130c2/src/controls/MenuSelectFontSize.tsx#L196-L203
I think a primary reason this "works" and doesn't show the selected editor text as deselected is MUI's use of a popover for the Select UI, where there is no focus on the actual options or interaction with them until the user clicks one to select (at which point onChange is called and it then calls focus() again anyway). I believe when I tried to use MUI's Autocomplete component (https://mui.com/material-ui/react-autocomplete/, which is seemingly more similar to your chakra react-select dropdown), I ran into a similar inconvenient UX problem as you, where the user's caret changed focus to the Autocomplete element and therefore the browser removed the visual text selection in the editor. If you happen to find a good workaround, I'd be interested to hear it!

Thanks for getting back! Yeah I believe that was the main issue, that react select is primarily a combobox (autocomplete) so it pulls in focus to it's input. There is an option to disable the search part, but it still drew focus. My solution was honestly just to use a different component haha.


Feature/produce kafka event

What
Describe what you have changed and why.
How to review
Describe the steps required to test the changes.
Who can review
Describe who worked on the changes, so that other people can review.

closing as I don't think we need this draft PR anymore


misa.v for zve* extensions?

Dose misa.v will be set if zve* extension is available?
Some software like linux kernel and glibc use that to determine the vector extension is enabled or not, so it would be problem if misa.v is not set for zve*, but it's kind of violate the definition in misa.
The Extensions field encodes the presence of the standard extensions,
with a single bit per letter of the alphabet (bit 0 encodes presence
of extension ``A'' , bit 1 encodes presence of extension ``B'',
through to bit 25 which encodes ``Z'').

Potential options:

Do not set misa.v for zve* and wait https://github.com/riscv/configuration-structure to resolve the detection issue?
Set misa.v for zve*, and add new rule for misa.v in priv spec.

How could Linux kernel or glibc determine V-extension via misa.v which is a M-mode CSR? And I don't see SBI calls defined for getting misa too.

I think the normal expectation is that the relevant information is passed in the DeviceTree.

I guess I am confused by qemu implementation https://github.com/qemu/qemu/blob/master/linux-user/elfload.c#L1446 .
Regardless linux and glibc, this issue still wroth to clarify I think?

The qemu implementation is just reading a single bit, and passing it to glibc, but that is unlikely to be good enough.  Your C API pull request says we need 3 values: min vector length, max int element width, and max FP element width.
https://github.com/riscv-non-isa/riscv-c-api-doc/pull/21
it isn't possible to get these 3 values from the single misa.v bit.  And passing 3 integers via the aux vector isn't as easy as passing down a single bit in AT_HWCAP.
Hence the suggestion to put vector info in the DTS for the linux kernel.  For glibc, we might want RISC-V specific additions to the aux vector, or else try to encode the info and stuff it into AT_HWCAP2 which is currently unused for RISC-V.

Regardless linux and glibc, this issue still wroth to clarify I think?

Yes, this issue is still valid :) It's just the reason that confused me.

Hence the suggestion to put vector info in the DTS for the linux kernel. For glibc, we might want RISC-V specific additions to the aux vector, or else try to encode the info and stuff it into AT_HWCAP2 which is currently unused for RISC-V.

I think it would be an important topic to discuss on linux plumber :)

For consistency with previous standards, the misa.V bit will be set for the single-letter V extension, but not for others.
https://github.com/riscv/riscv-v-spec/commit/1bfee80bbb5415bf25641bcc014e0ffc24d2e451


Allow easy switching to english version

I landed on your machine-translated german docs page. I could not find an easy option of simply displaying the article in english without switching the language of the whole page. The mouse-hover feature is just distracting.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d3824263-5c49-03e9-9063-b44b1c636540
Version Independent ID: 31684400-9100-b442-8957-c1300ad35cb8
Content: AD FS Scenarios for Developers
Content Source: WindowsServerDocs/identity/ad-fs/overview/AD-FS-Scenarios-for-Developers.md
Service: unspecified
GitHub Login: @billmath
Microsoft Alias: billmath

Thanks for the comment - to make sure the right people see it, can you open it as feedback against the docs.microsoft.com site? Here's where you can do that: https://aka.ms/sitefeedback


[Proposal]: Site Title instead of Logo

Summary
There should be an option to show Site Title instead of Site Logo. Some users might like to use only Site Title.

Hey @fakirlalon! I've not had this request before, so I'm a little reluctant to add another option in. However you can customise your site to show the site title by creating the following file in your Jekyll project and updating the HTML with the site title instead of logo:
https://github.com/daviddarnes/alembic/blob/main/_includes/site-logo.html


Angular v16 two consequent redirects

Core Library
MSAL.js (@azure/msal-browser)
Core Library Version
3.0.0-alpha.2
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
3.0.0-alpha.2
Public or Confidential Client?
Public
Description
I'm using Angular v16 full standalone. In AppComponent.ngOnInit I've placed
this.#msalService.handleRedirectObservable().subscribe().
When I first load the page a request to sections is made which triggers redirect to AD. After I authenticate I am redirected back to localhost. After that I'm redirected once again back to AD. Again, I have to authenticate and am redirected back to localhost.
After that I observe two requests for token and a request to sections with the token attached.
Error Message
No response
Msal Logs
No response
MSAL Configuration
{
  auth: {
    clientId: '',
    authority: '',
    redirectUri: 'http://localhost:4200'
  }
}

Not sharing id & authority for security reasons.

Relevant Code Snippets
app.config.ts is following
export const appConfig: ApplicationConfig = {
  providers: [
    provideHttpClient(withInterceptorsFromDi()),
    {
      provide: HTTP_INTERCEPTORS,
      useClass: MsalInterceptor,
      multi: true,
    },
    importProvidersFrom(
      MsalModule.forRoot(
        new PublicClientApplication({ ... }),
        { interactionType: InteractionType.Redirect },
        {
          interactionType: InteractionType.Redirect,
          protectedResourceMap: new Map([ ['sections', ['']] ])
        }
      )
    )
  ]
}

app.component.ts
export class AppComponent {
  #http = inject(HttpClient)
  #msal = inject(MsalService)

  ngOnInit() {
    this.#msalService.handleRedirectObservable().subscribe()
    this.#http.get('sections').subscribe()
  }
}

Reproduction Steps

Scaffold Angular v16 app in standalone
Add the MSAL libs that support Angular v16
Provide the required providers like in my samples
Handle the redirect in ngOnInit for AppComponent and make a request to the protected route

Expected Behavior
I would expect that I am redirected only once and there only one request to the token instead of two (sequential).
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
Chrome
Regression
No response
Source
External (Customer)

@gultyayev Is this on the sample we provided? Can you share logs? You can email them to me.

Could this be related to #6080 and #6099 - do you @gultyayev use a standalone bootstrapped app?

Could this be related to #6080 and #6099 - do you @gultyayev use a standalone bootstrapped app?

Yes. I use a standalone bootstrapped app. However, I don't experience any errors. Only double redirection.

Is this on the sample we provided?

No this is on our internal project.

Right now it stopped making 2 redirects all of a sudden. However, in the Network tab I still see 2 requests for the token. The interesting thing is that the second request starts only when the first is finished. Response size is the same for both of the requests. Second request contains way more fields in FormData.
This happens only after the login. If I refresh the page the token obtained only once.

Is it possible there is a re-authentication in any of the routes?

Is it possible there is a re-authentication in any of the routes?

Currently, there are no routes. The app is just being created and there is just one AppComponent. It has one single request to sections to test the SSO integration.

Hi @gultyayev.
There are not enough details about your standalone app to reproduce the issue. May I ask you to reproduce it with our sample and share the result? Providing us with the verbose logs would be of great help as well.
Thank you.


[INLONG-739] Create a temporary 0.10.0 development branch

Codecov Report

Merging #556 (8eb586a) into master (ece4ce5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #556   +/-   ##
========================================
  Coverage      7.72%   7.72%
  Complexity      563     563
========================================
  Files           355     355
  Lines         31081   31081
  Branches       4972    4972
========================================
  Hits           2400    2400
  Misses        28191   28191
  Partials        490     490

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ece4ce5...8eb586a. Read the comment docs.


Syntax differences from thtk in seqmap syntax

thtk eclmaps use _ to denote an empty strings.  This is part of the seqmap syntax itself, documented at https://github.com/thpatch/thtk/pull/63.
I didn't realize this, and used _ to mean something else.  (the dummy args in STD)
So in thtk where you have
!ins_signatures
0 _
1 S
2 So

in truth it is
!ins_signatures
0
1 S
2 So

There's some other issues here.  That PR further goes to explicitly document what should happen if a section header appears twice, or if an individual entry gets redefined.  I'm fairly certain that both of these will make truth report an error.
While truth obviously needs to extend signature syntax to support more fine-grained types, it is unfortunate that it diverges from thtk on such basic properties of the text file itself...

This is a "tentative wontfix" because I'd kind of rather just replace mapfile syntax as it doesn't really feel like much of a standard for anything >_>

Well Egor made a ninja change and apparently _ in thtk is now deprecated, so that's convenient.
There do remain some problems with redefinitions within a file.  The plan is that truth should treat these identical to the way it already treats the same thing defined in two different files.


split tools in individual packages

package tools brings all available external tools, which causes other packages to import more than they need.
For example, one package might only need to know about the ExternalTool interface, but it imports all the types and functions from tools package.  Because of this, circular dependencies are very common.
This PR breaks the tools packages into sub-packages that allow other packages to import and consume just what they need.
This is a requirement for supporting azdo as a provider, as some implementation changes are blocked by this.

Azure Dev CLI Install Instructions
Install scripts
MacOS/Linux

May elevate using sudo on some platforms and configurations

bash:
curl -fsSL https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/495/uninstall-azd.sh | bash;
curl -fsSL https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/495/install-azd.sh | bash -s -- --base-url https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/495 --version '' --verbose

pwsh:
Invoke-RestMethod 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/495/uninstall-azd.ps1' -OutFile uninstall-azd.ps1; ./uninstall-azd.ps1
Invoke-RestMethod 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/495/install-azd.ps1' -OutFile install-azd.ps1; ./install-azd.ps1 -BaseUrl 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/495' -Version '' -Verbose

Windows
powershell -c "Set-ExecutionPolicy Bypass Process; irm 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/495/uninstall-azd.ps1' > uninstall-azd.ps1; ./uninstall-azd.ps1;"
powershell -c "Set-ExecutionPolicy Bypass Process; irm 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/495/install-azd.ps1' > install-azd.ps1; ./install-azd.ps1 -BaseUrl 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/495' -Version '' -Verbose;"

Standalone Binary

Linux - https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/495/azd-linux-amd64.tar.gz
MacOS - https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/495/azd-darwin-amd64.zip
Windows - https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/495/azd-windows-amd64.zip

Container
docker run -it azdevcliextacr.azurecr.io/azure-dev:pr-495


Bugfix: the value in test cases should be invariable

Fix the bug imported in #1937
Reason: the #1936 's regression case use the Date.now() as a param of a function, and then cause the assert fail. Then I debug on it and fix the original bug. But the value of Data.now() changes with time changes. Do the patch can pass the CI last time, but failed this time.
JerryScript-DCO-1.0-Signed-off-by: Zidong Jiang<EMAIL_ADDRESS>

@akosthekiss please review it.


Peer review

Summary
The paper titled "The Impact of Interview Disruptions on Data Quality in Social Surveys" examines how various disruptions during interviews affect respondent comprehension and the reliability of survey responses. Employing Bayesian hierarchical logistic regression, the study identifies critical factors such as family-related interferences, interviewer characteristics, and interview methods. The findings emphasize the importance of managing interview disruptions and optimizing survey conditions to enhance data quality.
Strong positive points:

Comprehensive analysis using Bayesian hierarchical logistic regression provides nuanced insights into the impact of disruptions.
Practical implications for survey management are clearly outlined, offering actionable strategies to enhance data collection quality.
The inclusion of robust diagnostics, such as variance inflation factors and posterior predictive checks, ensures methodological transparency.

Critical improvements needed:

Discussion of Model Limitations: The manuscript briefly mentions moderate predictive performance (R² ~ 0.32) but could expand on strategies to address unexplained variance, such as incorporating additional predictors or alternative modeling approaches.
Data Accessibility: While the dataset is sourced from the European Social Survey, providing a clear link or documentation on how to access the data ensures reproducibility.

Suggestions for improvement:

Cite data
Minor typographical issues, such as inconsistent use of terms (e.g., "Partner Interference" vs. "partner_interference"), should be standardized.
Clarify the definitions of effort levels (e.g., "Respondent Tried Best") to ensure readers understand the categorization and implications.
Visualizations like bar plots (Figures 2 and 3) could benefit from annotations to highlight key insights directly on the graphs.
Include more details on the practical steps for minimizing disruptions, such as specific training modules or environmental adjustments for interviewers.

Evaluation:
R/Python cited (1/1 pts)
Data cited (0/1 pts)
[Data need to be cited]
Class paper (0/1 pts)
[README title is Starter folder]
LLM documentation (1/1 pts)
Title (2/2 pts)
Author, date, and repo (2/2 pts)
Abstract (3/4 pts)
[Comprehensive but could better highlight the statistical methodology]
Introduction (4/4 pts)
Estimand (1/1 pts)
Data (9/10 pts)
[Well-described but could benefit from a table summarizing key variables.]
Measurement (4/4 pts)
Model (9/10 pts)
[Thorough but lacks exploration of interaction effects.]
Results (9/10 pts)
[ Detailed with effective use of tables and credible intervals.]
Discussion (10/10 pts)
Prose (4/6 pts)
[Generally clear, with minor typographical issues.]
Cross-references (1/1 pts)
Captions (2/2 pts)
Graphs/tables/etc (4/4 pts)
Surveys, sampling, and observational data appendix (0/10 pts)
[No this appendix]
Referencing (4/4 pts)
Commits (2/2 pts)
Sketches (0/2 pts)
[No Sketches]
Simulation (4/4 pts)
Tests (4/4 pts)
Parquet (1/1 pts)
Reproducible workflow (3/4 pts)
Enhancements (0/4 pts)
[No Enhancements]
Miscellaneous (0/3 pts)
Estimated overall mark:
87 out of 112.
Any other comments:
No

Thank you for your comments, I have updated the data citation, survey, sampling, and observation data appendices


add back copy stageout plugin

Not just the same old Backends/CPImpl, but a rewrite. Added stagein support since this exists in XRDCPImpl, which this new version is based on. Do we even still support stagein? If not maybe we should clean that up, it makes the code much more complicated than it has to be.
The Plugins/CPImpl is similar to the old version, with a few minor tweaks/changes.
@amaltaro , what do you think?

Completely untested, just wanted to get some early feedback on code structure etc. Also not sure how I would test this.

Dirk, I think we can also copy back those 3 test changes. BTW, you have pushed in an empty CPImpl at the root directory as well.

Added back CPImpl unit test as-is and also adjusted the other unit test. Seems to me we might want to get rid of the special test-copy unit test implementation altogether since it isn't really used now anymore.

@amaltaro , how can I get cmsdmwmbot to actually give me the output of the unit test?

Given the list of failures in the report.html, you look them up here:
https://cmssdt.cern.ch/dmwm-jenkins/job/DMWM-WMCore-PR-test/8732/#showFailuresLink
which gives you a link to, for instance:
https://cmssdt.cern.ch/dmwm-jenkins/job/DMWM-WMCore-PR-test/8732/testReport/junit/WMCore_t.Storage_t.Backends_t.CPImpl_t/CPImplTest/testCreateOutputDirectory_simple/
I'm not sure how up-to-date this is, but it might be helpful as well:
https://github.com/dmwm/WMCore/wiki/Understanding-Jenkins

Thank, that helps, I see what's wrong now. Would be good if the report that is linked in the standard reply would contain that link...

Ok, this looks good now. @amaltaro , can you review?
Also, what about the other uses of "test-copy"? Should we clean this up?

The link is made available via "default" check, just push the "Details" link.
If "test-copy" is no longer used anywhere, then I think we can remove it (but I have the impression there are still a few tests using it).

BTW, you can ask for reviewers at the top right button "Reviewers". It's easier than to find what is waiting for your review.

I don't think test-copy is actually used anywhere now. There are a few references left though:
[hufnagel@lxplus717 WMCore]$ grep -r test-copy test
test/python/WMCore_t/WMRuntime_t/Scripts_t/SetupCMSSWPset_t.py:
test/python/WMCore_t/WMSpec_t/samples/site-local-config.xml:
test/python/WMCore_t/Misc_t/site-local-config.xml:
[hufnagel@lxplus717 WMCore]$ grep -r test-copy src
src/python/WMCore/Storage/Backends/UnittestImpl.py:registerStageOutImpl("test-copy", LocalCopyImpl)
src/python/WMCore/Storage/Registry.py:                'test-copy': 'TestLocalCopyImpl',

Ok, requested a review. Even if we want to get rid of these last "test-copy" reference (which at first glance don't seem to be functional to me), that should happen in a separate PR.

There is no site that uses this as a stageout plugin, that's why I said testing this right now is hard.

Ok, we shall eventually see whether it works or not. Thanks


Events, when being created an error is shown, and no image is uploaded to Event

After event was created an error was shown, event appears in system but the image uploaded is missing.
Pls fix the error message should not be there and Image must be uploaded, and cropped horizontally to fit the gallery object.

I have fixed this issue. Added loading while save new event or delete event.

Solved


Instruction: CloseAccount Error

When trying to create_associated_token_account, it is automatically trying to CloseAccount after instruction 3 which should not happen. what's the issue?
let create_account = spl_associated_token_account::instruction::create_associated_token_account(
       base_pubkey,
       base_pubkey,
       &Pubkey::from_str(&basemint).unwrap(),
       &Pubkey::from_str("TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA").unwrap(),
   );

   let associated_address =
       get_associated_token_address(base_pubkey, &Pubkey::from_str(&basemint).unwrap());```

       Logs:

      `{
 "error": {
   "request": "SendTransaction",
   "kind": "RpcError",
   "details": {
     "code": -32002,
     "message": "Transaction simulation failed: Error processing Instruction 1: invalid account data for instruction",
     "data": {
       "failureType": "SendTransactionPreflightFailure",
       "simulationResult": {
         "error": {
           "type": "InstructionError",
           "instructionIndex": 1,
           "errorType": "InvalidAccountData"
         },
         "logs": [
           "Program ATokenGPvbdGVxr1b2hvZbsiqW5xWH25efTNsLJA8knL invoke [1]",
           "Program log: Create",
           "Program TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA invoke [2]",
           "Program log: Instruction: GetAccountDataSize",
           "Program TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA consumed 1569 of 394603 compute units",
           "Program return: TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA pQAAAAAAAAA=",
           "Program TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA success",
           "Program<PHONE_NUMBER>1111111111111111111111 invoke [2]",
           "Program<PHONE_NUMBER>1111111111111111111111 success",
           "Program log: Initialize the associated token account",
           "Program TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA invoke [2]",
           "Program log: Instruction: InitializeImmutableOwner",
           "Program log: Please upgrade to SPL Token 2022 for immutable owner support",
           "Program TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA consumed 1405 of 388166 compute units",
           "Program TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA success",
           "Program TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA invoke [2]",
           "Program log: Instruction: InitializeAccount3",
           "Program TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA consumed 4188 of 384284 compute units",
           "Program TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA success",
           "Program ATokenGPvbdGVxr1b2hvZbsiqW5xWH25efTNsLJA8knL consumed 20187 of 400000 compute units",
           "Program ATokenGPvbdGVxr1b2hvZbsiqW5xWH25efTNsLJA8knL success",
           "Program TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA invoke [1]",
           "Program log: Instruction: CloseAccount",
           "Program log: Error: InvalidAccountData",
           "Program TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA consumed 3983 of 379813 compute units",
           "Program TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA failed: invalid account data for instruction"
         ],
         "accounts": null,
         "unitsConsumed": 20187,
         "returnData": null
       }
     }
   }
 }
}`

@taimurey, I can see from the logs that the CloseAccount instruction is being invoked after the Associated Token Account program has completed its processing. So this is certainly not a bug in create_associated_token_account.
You haven't shared enough of your code for me to be sure exactly what transaction you are submitting.
We want to make sure to keep signal strong in the GitHub issue tracker – to make sure that it remains the best place to track issues that affect the development of Solana itself.
Dev questions like yours deserve a purpose-built Q&A forum. Unless there exists evidence that this is a bug with Solana itself, please post your question to the Solana Stack Exchange using this link: https://solana.stackexchange.com/questions/ask


How to make it work with ExtJS 6.2?

Hi,
i just tried to use your component with ExtJS 6.2 but I'm gettting the following error message:
[ERR] C2008: Requirement had no matching files (Ext.ux.DateTimePicker) -- packages/DateTimeField/src/DateTimeField.js:9:1
I just added it to my packages folder and added it to the "requires" part of app.json. I'm not using sencha architect.
Do I miss something?
Cheers,
Julian

Check this issue, this may address your question: https://github.com/gportela85/DateTimeField/issues/9


Is this still usable?

I’m trying to gain root access. Is this project still viable?

Couldn’t get google WiFi to turn on at all after flash, it seems like newer updates brick and/or overwrite galeforce

Couldn’t get google WiFi to turn on at all after flash, it seems like newer updates brick and/or overwrite galeforce

Use the Google Restore Tool to restore the firmware on the puck if you have any more issues.

Yeah, bricks mine too. Guess this is dead after all
Sent from my iPad

On Dec 29, 2019, at 10:29 PM, StruggleBuddies<EMAIL_ADDRESS>wrote:

Couldn’t get google WiFi to turn on at all after flash, it seems like newer updates brick and/or overwrite galeforce
Use the Google Restore Tool to restore the firmware on the puck if you have any more issues.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.


NPE on objects move

That's not related to the library per se, but it'd also be nice to fix for the sample app.
When you delete chips from the recyclerview spinners aren't getting updated and you can get a NPE on Move.
Caused by: java.lang.IndexOutOfBoundsException: Index: 38, Size: 31 at java.util.ArrayList.add(ArrayList.java:457) at beloo.recyclerviewcustomadapter.MainActivity.onMoveClicked(MainActivity.java:162)    at java.lang.reflect.Method.invoke(Native Method)        at android.support.v7.app.AppCompatViewInflater$DeclaredOnClickListener.onClick(AppCompatViewInflater.java:288)

Yep. My problem is that i maintain sample in the least. So such issues could appear time to time.
Have fixed in dev branch


add modular add/sub/mul ops to arith_ext

As discussed in #724

Test failure seems to be unrelated and due  to the switch to upstream polynomial:
ERROR: /home/runner/work/heir/heir/tests/openfhe/end_to_end/BUILD:18:24: Action tests/openfhe/end_to_end/simple_sum_lib.h failed: (Segmentation fault):

Rebased onto current main


pruneMusic bug

Type

[X] Functions: $pruneMusic (Whenever I use it returns the error of the print)
[ ] Callbacks: <Callback Name>
[ ] Handlers: <Handler Type>
[ ] Others: ______

Code used:
$playSong[$message]
$pruneMusic

More:

Aoi.js version: 1.0.6
Node.js version: v12.16.1

Screenshots (If any): https://cdn.discordapp.com/attachments/835715920504029217/846047799589208075/Screenshot_20210523-1231102.jpg

Type

[X] Functions: $pruneMusic (Whenever I use it returns the error of the print)
[ ] Callbacks: <Callback Name>
[ ] Handlers: <Handler Type>
[ ] Others: ______

Code used:
$playSong[$message]
$pruneMusic

More:

Aoi.js version: 1.0.6
Node.js version: v12.16.1

Screenshots (If any): https://cdn.discordapp.com/attachments/835715920504029217/846047799589208075/Screenshot_20210523-1231102.jpg

@LueyCoder
make it
$pruneMusic
$playSong[$message]

ok, wait

No response.


Zend Cache: Overview and Theory Of Operation with examples would help

I have started diving into the Zend\Cache component and I notice that it takes me more time to puzzle together how to work with the component compared to when having overview documentation.
The existing pieces of documentation are too technical an assume a basic understanding of the component. For example the first line of patterns: Cache patterns are configurable objects to solve known performance bottlenecks; I need read the rest of the document to determine the intention of this line.
A separate Overview of Theory Of Operation providing a bird's eye view of the component might help to provide insight in the system as a whole and how it works.

if I can spare some time I will try to write a chapter but at this moment I cannot promise anything due to time constraints

Ping @Maks3w @marc-mabe @mvriel


Vulkan: GPU Particles dont work

GPU Particles are not working on the Vulkan 4.0 branch.
Ticking the enable check box doesn't turn the particle system on.

With #41711 merged, 3D particles are back. 2D particles are waiting for 2D engine rewrite, so they still don't work.


Matcher for stubbing and expectation

I am playing with this expect { subject.action }.to request(:get, "http://pls.com").with(options) and I feel it's specially useful for API clients but also for real unitary tests.
  RSpec::Matchers.define(:request) do |method, url|
    match do |action|
      @stub = stub_request(method, url)
      @stub = @stub.with(@with) unless @with.nil?
      action.call
      expect(@stub).to have_been_requested
    end

    chain(:with) do |options|
      @with = options
    end

    def supports_block_expectations?
      true
    end
  end

  describe "services" do
    it "adds service" do
      expect { client.add_service(a_hash) }.
        to request(:get, "#{base_url}/addpsp").with(query: a_hash)
    end
  end

Some interesting ideas, however nothing to act on, so I am closing this issue. Thanks for submitting!


Feature dropboxpaper

Hello @6uhrmittag! Thanks for submitting the PR.

In the file taskbutler.py, following are the PEP8 issues :

Line 15:80: E501 line too long (99 > 79 characters)
Line 23:80: E501 line too long (86 > 79 characters)
Line 29:80: E501 line too long (84 > 79 characters)
Line 30:80: E501 line too long (94 > 79 characters)
Line 47:80: E501 line too long (91 > 79 characters)
Line 49:80: E501 line too long (87 > 79 characters)
Line 50:80: E501 line too long (88 > 79 characters)
Line 55:80: E501 line too long (97 > 79 characters)
Line 58:80: E501 line too long (113 > 79 characters)
Line 70:80: E501 line too long (98 > 79 characters)
Line 71:80: E501 line too long (92 > 79 characters)
Line 74:80: E501 line too long (127 > 79 characters)
Line 75:80: E501 line too long (90 > 79 characters)
Line 108:80: E501 line too long (86 > 79 characters)
Line 110:80: E501 line too long (93 > 79 characters)
Line 116:80: E501 line too long (109 > 79 characters)
Line 124:80: E501 line too long (104 > 79 characters)
Line 130:80: E501 line too long (84 > 79 characters)
Line 148:80: E501 line too long (81 > 79 characters)
Line 165:80: E501 line too long (123 > 79 characters)
Line 166:80: E501 line too long (102 > 79 characters)
Line 170:80: E501 line too long (98 > 79 characters)
Line 220:80: E501 line too long (123 > 79 characters)
Line 221:80: E501 line too long (104 > 79 characters)
Line 223:80: E501 line too long (89 > 79 characters)
Line 225:80: E501 line too long (83 > 79 characters)
Line 247:80: E501 line too long (99 > 79 characters)
Line 260:80: E501 line too long (102 > 79 characters)
Line 261:80: E501 line too long (94 > 79 characters)
Line 265:80: E501 line too long (89 > 79 characters)
Line 278:80: E501 line too long (94 > 79 characters)
Line 295:80: E501 line too long (102 > 79 characters)
Line 296:5: E125 continuation line with same indent as next logical line
Line 307:80: E501 line too long (92 > 79 characters)
Line 317:80: E501 line too long (93 > 79 characters)
Line 323:80: E501 line too long (112 > 79 characters)
Line 324:80: E501 line too long (97 > 79 characters)
Line 346:80: E501 line too long (87 > 79 characters)
Line 348:80: E501 line too long (99 > 79 characters)
Line 349:80: E501 line too long (100 > 79 characters)
Line 354:80: E501 line too long (81 > 79 characters)
Line 367:80: E501 line too long (83 > 79 characters)
Line 369:80: E501 line too long (93 > 79 characters)
Line 372:80: E501 line too long (106 > 79 characters)
Line 376:80: E501 line too long (93 > 79 characters)
Line 377:80: E501 line too long (106 > 79 characters)
Line 386:80: E501 line too long (91 > 79 characters)
Line 389:80: E501 line too long (89 > 79 characters)
Line 395:80: E501 line too long (82 > 79 characters)
Line 399:80: E501 line too long (87 > 79 characters)
Line 403:80: E501 line too long (96 > 79 characters)
Line 414:80: E501 line too long (96 > 79 characters)
Line 415:80: E501 line too long (91 > 79 characters)
Line 417:80: E501 line too long (81 > 79 characters)
Line 422:80: E501 line too long (109 > 79 characters)
Line 425:80: E501 line too long (89 > 79 characters)
Line 428:80: E501 line too long (80 > 79 characters)
Line 429:80: E501 line too long (81 > 79 characters)
Line 433:80: E501 line too long (83 > 79 characters)
Line 465:80: E501 line too long (106 > 79 characters)
Line 466:5: E125 continuation line with same indent as next logical line
Line 469:80: E501 line too long (87 > 79 characters)
Line 478:80: E501 line too long (107 > 79 characters)
Line 479:5: E125 continuation line with same indent as next logical line
Line 479:80: E501 line too long (90 > 79 characters)
Line 481:80: E501 line too long (112 > 79 characters)
Line 484:80: E501 line too long (111 > 79 characters)
Line 486:80: E501 line too long (113 > 79 characters)
Line 494:80: E501 line too long (80 > 79 characters)
Line 496:80: E501 line too long (113 > 79 characters)
Line 501:80: E501 line too long (110 > 79 characters)
Line 507:80: E501 line too long (82 > 79 characters)
Line 508:80: E501 line too long (113 > 79 characters)
Line 513:80: E501 line too long (108 > 79 characters)
Line 514:80: E501 line too long (108 > 79 characters)
Line 522:80: E501 line too long (121 > 79 characters)
Line 535:80: E501 line too long (85 > 79 characters)
Line 538:80: E501 line too long (115 > 79 characters)
Line 548:80: E501 line too long (93 > 79 characters)
Line 549:21: E125 continuation line with same indent as next logical line
Line 550:80: E501 line too long (93 > 79 characters)
Line 551:80: E501 line too long (96 > 79 characters)
Line 552:80: E501 line too long (84 > 79 characters)
Line 554:80: E501 line too long (87 > 79 characters)
Line 555:80: E501 line too long (84 > 79 characters)
Line 572:80: E501 line too long (89 > 79 characters)
Line 573:17: E125 continuation line with same indent as next logical line
Line 574:80: E501 line too long (94 > 79 characters)
Line 575:80: E501 line too long (97 > 79 characters)
Line 576:80: E501 line too long (83 > 79 characters)


show only image in profile activity

Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Bugfix

Needs QA

@prury please review
@JustLuuuu

Context

[x] Ref #10030

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

pay 20 usd

😍 Perfect, I’ve sent the payout
💵 $20 @ 8.26 USD/DOT ~ 2.421 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0x2a942178bb0519b064ea80fda43ea8d88333d2d732411d6b74a4de9e664b70c8
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


tmt tests lint should identify and possibly fix references to upstreamed beaker libraries

When importing a test using library distribution/nvr the main.fmr file is updated with
require:
 - library(distribution/nvr)

This library has been upstreamed already at https://github.com/beakerlib/nvr. It would be nice if tmt tests lint would:

warn that the library is already upstreamed and suggest using it instead (library(nvr/nvr))
--fix could do the change above in main.fmf and say also that rlImport should be fixed too (possibly help user at least by grepping for rlImport in current directory)
allow custom configuration where user could add other converted beaker libraries that are not upstreamed directly in https://github.com/beakerlib/ but at a different location, e.g. https://src.fedoraproject.org/tests/opencryptoki/blob/main/f/Library/token-manipulation

IMHO all we need (for github/beakerlib location) is a way how to note the original name(s) and conversion rule.
I'd vote for tmt lint to autoupdate as having it only in rpm will be slow and manual updates just be just an optional step.

Added label for import as well - While the fix itself should be done by lint (as list of libraries will increase over time) import should make sure to run the lint after the import (at least).


[QST] Compress on CPU then decompress on GPU, and compress on GPU then decompress on CPU

What is your question?
Hi, currently, I need to to a work like the issue title descripted, and I just use LZ4 algorithm. But I found something very strange, for example, the compressed output size with nvcomp is a little larger than the compressed output size with https://github.com/lz4/lz4 for same data(100 bytes in my test), I get the compressed output size with method nvcomp_manager.get_compressed_output_size(cmp_buffer).
I don't understand why this happened, and does my idea is ok to implement with nvcomp?

What is your question? Hi, currently, I need to to a work like the issue title descripted, and I just use LZ4 algorithm. But I found something very strange, for example, the compressed output size with nvcomp is a little larger than the compressed output size with https://github.com/lz4/lz4 for same data(100 bytes in my test), I get the compressed output size with method nvcomp_manager.get_compressed_output_size(cmp_buffer).
I don't understand why this happened, and does my idea is ok to implement with nvcomp?

I found there is a common header in the beginning of the compressed buffer, from the common header, I can get the compressed data size, but the data size is still four bytes larger than the compressed data size by lz4, I don't know why.

What is your question? Hi, currently, I need to to a work like the issue title descripted, and I just use LZ4 algorithm. But I found something very strange, for example, the compressed output size with nvcomp is a little larger than the compressed output size with https://github.com/lz4/lz4 for same data(100 bytes in my test), I get the compressed output size with method nvcomp_manager.get_compressed_output_size(cmp_buffer).
I don't understand why this happened, and does my idea is ok to implement with nvcomp?

I found there is a common header in the beginning of the compressed buffer. From the common header, I can get the compressed data size, but the data size is still four bytes larger than the compressed data size by lz4, I don't know why.

Because there are LZ4FormatSpecHeader after common header.

How can I copy all the compressed data without metadata like headers?

Looks like the algorithm LZ4 implement is different from https://github.com/lz4/lz4, because for the same data, I checked the   compressed output data both of them, and they are different.

@ucasfl LZ4 on the GPU will produce different compressed output as it has a different algorithm for finding matches. Were you finding that data compressed on the GPU was not decompressible correctly the CPU lz4 implementation?

@ucasfl LZ4 on the GPU will produce different compressed output as it has a different algorithm for finding matches. Were you finding that data compressed on the GPU was not decompressible correctly the CPU lz4 implementation?

Yes.

Currently, I following the lowlevel api in lz4_cpu_compression.cu and lz4_cpu_decompression.cu can do compress and decompress between CPU and GPU.

Thanks @ucasfl, this sounds like a bug. Can you provide information such what dataset you see this on, the CUDA version, the host compiler version (e.g., gcc 9.3.0) and on what GPU?

See here for the LZ4 block: https://github.com/lz4/lz4/blob/dev/doc/lz4_Block_format.md
and here for the LZ4 frame: https://github.com/lz4/lz4/blob/dev/doc/lz4_Frame_format.md

See here for the LZ4 block: https://github.com/lz4/lz4/blob/dev/doc/lz4_Block_format.md and here for the LZ4 frame: https://github.com/lz4/lz4/blob/dev/doc/lz4_Frame_format.md

OK, thanks


FancyZones Cannot save the layout when there are more than one screen

Microsoft PowerToys version
0.60.0
Running as admin

[X] Yes

Area(s) with issue?
FancyZones Editor
Steps to reproduce
Cannot save the layout when there are more than one screen
All screens use same layout
✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

I also see this on 0.60.0

/bugreport


Validator: v.array() weird experience

import { Hono } from "hono";
import { validator } from "hono/validator";

const app = new Hono();

app.post(
	"/",
	validator(
		(v) => ({
			response: v.object("response", (v1) => ({
				content: v1.json("content").isOptional().isLength({ max: 2000 }),
				embeds: v1
					.array("embeds", (v2) => ({
						title: v2.json("title").isOptional(),
						description: v2.json("description").isOptional(),
						url: v2.json("url").isOptional(),
						timestamp: v2.json("timestamp").isOptional(),
						color: v2.json("color").asNumber().isOptional(),
						author: v2
							.object("embeds.[*].author", (v3) => ({
								name: v3.json("name").isOptional(),
								url: v3.json("url").isOptional(),
								icon_url: v3.json("icon_url").isOptional(),
							}))
							.isOptional(),
						footer: v2
							.object("embeds.[*].footer", (v3) => ({
								text: v3.json("text").isOptional(),
								icon_url: v3.json("icon_url").isOptional(),
							}))
							.isOptional(),
						image: v2
							.object("embeds.[*].image", (v3) => ({
								url: v3.json("url").isOptional(),
							}))
							.isOptional(),
						thumbnail: v2
							.object("embeds.[*].thumbnail", (v3) => ({
								url: v3.json("url").isOptional(),
							}))
							.isOptional(),
						fields: v2
							.array("embeds.[*].fields", (v3) => ({
								name: v3.json("name"),
								value: v3.json("value"),
								inline: v3.json("inline").isOptional().asBoolean(),
							}))
							.isOptional(),
					}))
					.isOptional(),
				flags: v1.json("flags").isOptional().asNumber(),
			})),
		}),
		{
			done: (res) => {
				if (res.hasError) {
					return new Response(res.messages.join("\n"), { status: 400 });
				}
			},
		}
	),
	(c) => {
		return Response.json(c.req.valid());
	}
);

app.notFound(() => {
	return new Response("Not found", { status: 404 });
})

export default app;

Issues:

[x] 1. I have to use fields: v2.array("embeds.[*].fields") despite the fact it's already under embeds - if you don't it incorrectly looks under response. #683
[ ] 2. v.array() won't accept an empty array - even with it being marked as isOptional, the validator will error. This also occurs when null is provided.
[x] 3. "Invalid Value [64]: the JSON body \"response.flags\" is invalid - should be \"number[]\"" - this is not under an array field - it should not be counted as an array? It turns out this can be fixed by putting response.flags before response.embeds in the validator - this is odd.  #680

I appreciate this issue description is pretty awful - but I feel like I'm running into a combination of bugs here with nested arrays and objects

An example of some weird behaviour:

Hi @Skye-31
Okay. I will investigate and fix it. It may take a little bit of time.

I had a little play with it and I've opened a PR for point 3 :slightly_smiling_face:

Hi @Skye-31 :slightly_smiling_face: , I am having a hard time understanding points 1 and 2, could you elaborate a bit? and could you maybe also please provide the requests you make and the expected vs actual response? :pray:
Also you mention that for the fields you need to provide 'embeds.[*].fields' but it should be just 'fields' right? You specifically mention the fields, but doesn't the same apply for author, footer, image and thumbnail as well? is adding the prefix there ok?

Hi @dario-piotrowicz, of course. Thanks very much for looking at this!
The request body is here:

{
    "response": {
    "content": "static response",
    "flags": 64,
    "embeds": [
      {
        "title": "Hi",
        "fields": [
          {
            "name": "field name",
            "value": "field value"
          }
        ]
      }
    ]
  }
}

For point 1, it appears that any deeper nested fields (for example an object, inside an array, inside an object), still require the prefix of the 2nd field to be included. In this case, if it was just fields (or author, footer, etc.), it incorrectly looks for response.[*].fields, when it should instead be looking under response.embeds.[*].fields. In all of these cases, I receive Invalid Value [undefined]: the JSON body \"response.[*].<property> is invalid - should be <type>.
For point 2, if I provide { "response": { "content": "test", "embeds": [] } }
I get the following: Invalid Value [undefined]: the JSON body \"response.embeds.[*].title\" is invalid - should be \"string[]\" - even though an empty array (as well as undefined) should be accepted as a value.
Please let me know if I can clarify things any further

@Skye-31 thanks a bunch! :slightly_smiling_face:  I think I get it now :smiley::+1: I'll try to have a play around to see if I can spot the bugs :slightly_smiling_face:
Regarding #680, I just tried the build locally and it doesn't seem to solve point 1 and 2 :sweat:

It seems that the point 2 is caused because it returns false if it's "array && optional && undefined".

@Skye-31 point 1 should be ok now :slightly_smiling_face::+1:

I've done some testing - and the experience seems much better than before so a big ❤ for @dario-piotrowicz on this. There's still the issue of it rejecting empty embeds, but that's much more easy to get around than the other two

@Skye-31 Awesome! I'm so glad! :smiley:
I'll look into the empty embeds issue soon :slightly_smiling_face::+1:
(unless @yusukebe has already started and prefers to look into it? PS: @yusukebe I didn't fully understand your previous comment :sweat:)

@dario-piotrowicz
I haven't worked on that yet!
Sorry for the lack of clarity. I suspect the problem is that it does not return false when array && optional && undefined in the validateType. I think.
https://github.com/honojs/hono/blob/07efdb5103c4cdb37585724945e26d93f33de383/src/validator/validator.ts#L304

@dario-piotrowicz
I haven't worked on that yet!
Sorry for the lack of clarity. I suspect the problem is that it does not return "valid" when this.isArray && this._optional && typeof value === 'undefined' in the validateType. I think.
https://github.com/honojs/hono/blob/07efdb5103c4cdb37585724945e26d93f33de383/src/validator/validator.ts#L304

Ah ok I see, thanks for explaining, I'll have a look there then :smiley::+1:
Anyways yeah if you haven't started on it I'll gladly try to fix the issue :slightly_smiling_face:

PR Opened :slightly_smiling_face:

Thanks again for taking a look at these @dario-piotrowicz!
If it accepts undefined & empty arrays that's okay for me - While looking at the code for the validator earlier today I realised it doesn't accept null for optional objects, so it's consistent between the two.

Hi

ok if you're good with null not being accepted then I guess we can do with that

Ah, null... I think this is a different issue whether it will be accepted or not, so let's go with this for this issue!


How to turn off connection logging now in new release?

For logs like this:
<IP_ADDRESS> - - [19/Apr/2016:15:01:19 +0000] "GET /service/async HTTP/1.1" 404 43 "-" "Jersey/2.22.2 (HttpUrlConnection 1.8.0_45)" 105
<IP_ADDRESS> - - [19/Apr/2016:15:02:01 +0000] "GET /async HTTP/1.1" 200 12 "-" "Jersey/2.22.2 (HttpUrlConnection 1.8.0_45)" 5027

how do we suppress these in the logs? In 0.9.2, we did it with adding the following under the server section in the YML file:
requestLog:
  timeZone: UTC
  appenders: []

But now, during startup a validation error pops up:
klslave.yml has an error:
  * Unrecognized field at: server.requestLog.timeZone
    Did you mean?:
      - appenders

Nevermind. Just remove the timeZone: UTC line and the connection logs are suppressed.


feat: Add documentation on dataspaces, control plane, and data plane concepts

What this PR changes/adds
Adds documentation for core EDC concepts for adopters.

maybe's better to keep an unique format for file names, like everything-lowercase.md with dashes instead of empty whitespaces.

Let's do that from now on, but for the existing cases, we will need a cleanup pass. This also touches on a larger issue which is consistent writing conventions. I'll come up with something when I am back.


Update README.md

📃 Description
Just a suggestion ;)
Looking at the amount issues that has been created due to people using the latest tag with auto updates. Pin the version in the README, and link the LSIO page to check for the last version number.,

If you agree i will as well submit a PR for the docs :)

I'm thinking this is probably a good idea, now am I going to remember to do this during a release? 🤷♂

I'm thinking this is probably a good idea, now am I going to remember to do this during a release? 🤷♂

Maybe, maybe not hahaha


migrations: Add migration to migrate pronouns custom profile fields.

This PR adds a migration to migrate SHORT_TEXT type profile fields for pronouns to
recently added PRONOUNS type.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

lgtm; I'm going to defer merging until an updated mobile release has been out for a bit.

Added commit to handle the Pronouns type fields for mobile clients. A couple of points to note -

I have not added it to client_capabilities dict and we instead calculate it in the server code itself from User-Agent value.
Not sure how we want to document those changes and do we want to bump the API_FEATURE_LEVEL for this.

I have not added it to client_capabilities dict and we instead calculate it in the server code itself from User-Agent value.
Not sure how we want to document these changes and do we want to bump the API_FEATURE_LEVEL for this.

Yeah, good questions.
Adding a client capability would be the more formal way to do this. The advantage would be that arbitrary other clients, beyond just web and mobile, would get the benefit of this compatibility logic.
The cost is that it'd be one more item that modern clients have to pass in their client_capabilities lists forever. (Until some future where we start sunsetting those, but that itself would be a slow, multistage process.) Anyone writing a new client would have to remember to pass it, or else get this subtly quirky behavior where this one type of custom profile field, namely pronouns, doesn't show up properly.
And back on the benefits side, custom profile fields are a rather long-tail feature, which it's unlikely any client other than web, mobile, and terminal is much concerned with. (And I don't know the state of terminal's interaction with them.) So the practical cost of limiting the compatibility logic to those known clients is very low.
For those reasons, the strategy we've chosen for this particular compatibility shim is this hackier approach of just looking at the User-Agent.

Re the feature level… I'm inclined to just not document this compatibility behavior, in keeping with the fact that it's kind of a hack.
Or to perhaps put the reasoning better: from the perspective of someone consuming the API docs, writing an API client, there's nothing really actionable to do about this compatibility hack -- so there's no benefit to having it in the docs.
That's because in a client, the thing to do is to handle the Pronouns type as well as the other types described in the docs. You can't elicit the compatibility hack except by pretending in your User-Agent to be an outdated version of the Zulip mobile app… and it's really much easier to just handle Pronouns and give them the same treatment as Short Text, like the current mobile app does.

I just copied the client_capabilities and docs/API_FEATURE_LEVEL questions, and my replies, to #api design:
https://chat.zulip.org/#narrow/stream/378-api-design/topic/new.20pronouns.20field.20type/near/1458472
Let's have any further discussion of them there -- these relate to important API-design principles, and I think it's helpful to have the discussions over in Zulip where we have good search so we can find them again later.

I pushed back some updates to comments; this lgtm other than the bug @gnprice caught.

Merged, thanks @sahil839!


Update CoreELEC install instructions

Update CoreELEC installation instructions

I am not sure but maybe you should change the cabernet/.github/workflows/docker-image.yml to only execute 'on release' instead of 'on push'
Currently your docker-image.yml starts with the following:
name: Build & Push Cabernet

on:
  push:
    # Publish `master` as Docker `latest` image.
    branches:
      - master

This might stop the workflow from executing when a PR is submitted and only execute it when you do a release:
name: Build & Push Cabernet

on:
  release:
    types: [published]

I deleted my last comment beacuse I have never used a git workflow to create a docker image so I have no idea how to fix this.


Template secrets and joins

Issue #43
Description of changes:
I added few changes over @martinhaus commits.

I merged current master branch
One is to not override main secret, as that one in json format is used if no change is detected (specially interesting for sync).
The other is I added the option to join all templated secrets into one file. I needed because I was mixing some secrets into a single YAML file.

It's properly working, but I don't know Golang and I didn't changed tests, so code can surely be improved.

is there any ETA when can we get this feature available?


Prevent Whitelist/Blacklist Checker button from appearing in pages with no users to check

Description
A clear and concise description of what the bug is.
Steps to Reproduce

Go to Giveaways -> Create a New Giveaway

Expected Behavior
I think there is supposed to be only one icon - View/Apply Templates
Console Errors
No erros
Screenshots

System (please complete the following information):

ESGST: Extension 8.1.6 (Dev.3)
Browser: Chrome 71.0.3578.80

If I click on the icon of the image viewer a screenshot of an conversation of mine will appear. That's crazy. I think I did the screenshot, upload it to imgur.com (I used an extension called Image Uploader for uploading it there) and sent a lint to it to moderators. I can see the icon immediately when I enter the new GA page. It's very strange.

There's no source link for the image? Try opening the source code of the page and seeing if you find an image there somewhere.

Ahhh, I think it's from Quick Inbox View.

Don't know, I'll look into it.


Adding py3.13 to tests

Adding python 3.13 to the test matrix.  Updating old references to versions of python <3.9 which we don't support any more.

Can you wait for https://github.com/groundlight/python-sdk/pull/279 ? This includes all the updates to 3.8 -> 3.9

Can you wait for https://github.com/groundlight/python-sdk/pull/279 ? This includes all the updates to 3.8 -> 3.9

Sure thing.  I can rebase on top of it even.

Tyler beat me to it!


question mark icon throughout app

This should be a new component, like a modal, that shows up when you hover over various question mark icons that will be embedded throughout the app. Basically, just a text box with some instructions for how to do whatever it is that is being displayed.

I've added the tooltip, which does some of this. But need to think about if this would be useful elsewhere


radialNetwork graph crash - R tools feedback report

Please briefly describe what you were doing that led to the issue, if applicable:
See Issue:"radialNetwork graph crash #2945" for a description. This is in response to a request there to report the issue via R Tools feedback as that apparently attaches logs (although I don't see any so far).
...
If you have any screenshots demonstrating the issue, please include them as well to help us diagnose it better.
Additional information:
OS Information
Version:       Microsoft Windows NT 10.0.14393.0
RTVS Information:
Assembly: Microsoft.VisualStudio.R.Package, Version=0.5.21008.800, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
R Install path:
C:\Program Files\R\R-3.3.2

When you click on the frown menu item, it should create a zipped log file in your temp folder, and open an Explorer window with the file selected. The file is called RTVSlogs.zip by default.

I see, didn't try the frown. Ok, attached the RTVSLogs.
RTVSLogs.zip
zip file.

The call stack does not apply to 0.6 since code path changed a lot. Please reactivate if you encounter this in 0.6.


Can't return a function as a named "callback!" from Rust

I am in a situation where I cannot figure out how to have a function to return a named callback type.
Somewhere in my internal Rust code I will have something like:
extern "C" fn exposed_sum(x:i32, y:i32) -> i32 {
    x + y
}

Naturally, I would expose it like this:
#[ffi_function]
#[no_mangle]
pub extern "C" fn rust_to_csharp() -> extern fn(x: i32, y: i32) -> i32 {
    exposed_sum // return rust method
}

but this gets me a Unsupported type at interface boundary found for rval: [.....] error.
Doing the following solves the issue, but on the C# side generates a name for the delegate that is not "SumDelegate":
// Define the function pointer type
type SumDelegate = extern "C" fn(i32, i32) -> i32;

// exposing a Rust callback that can be called from outside
#[ffi_function]
#[no_mangle]
pub extern "C" fn rust_to_csharp() -> SumDelegate {
    exposed_sum
}

However, if I do this instead to keep the naming I want:
callback!(SumDelegate(x: i32, y: i32) -> i32);

// exposing a Rust callback that can be called from outside
#[ffi_function]
#[no_mangle]
pub extern "C" fn rust_to_csharp() -> SumDelegate {
    exposed_sum
}

I cannot get it to compile in any way, because "exposed_sum" is not compatible with the SumDelegate type:
expected SumDelegate, but found fn(i32, i32) -> i32 {exposed_sum}
Am I missing something?

I haven't used that feature in a while, but can you try

// exposing a Rust callback that can be called from outside
#[ffi_function]
#[no_mangle]
pub extern "C" fn rust_to_csharp() -> SumDelegate {
    SumDelegate(Some(exposed_sum))
}

I've added a bit more documentation and an example in the reference project. I think this is wontfix for now, until Rust changes function item and pointer handling. I happily reopen and fix this if there is a better solution.


support custom object

Codecov Report

Merging #88 (3cbc175) into main (a2c0be4) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   23.93%   23.90%   -0.04%
==========================================
  Files          14       14
  Lines        1362     1364       +2
==========================================
  Hits          326      326
- Misses        988      990       +2
  Partials       48       48

Impacted Files
Coverage Δ

emctl/cmd/client/util/visitor.go
30.10% <0.00%> (-0.32%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d6366...3cbc175. Read the comment docs.

Need unit test for the coverage

test cases added.


quill:0.1.0 fix readme for dark mode

This PR fixes the issue of the images in the readme not being readable in GitHubs darkmode due to them being transparent.
It does not affect the package's code in any way.

Thanks!


missed lib directory

This issue respects the following points:

[X] This is a bug, not a question or a setup/configuration issue.
[X] This issue is not already reported on Github (I've searched it).
[X] I use the latest release of the Monitoring Plugins (https://github.com/Linuxfabrik/monitoring-plugins/releases).
[X] I agree to follow Monitoring Plugins's Code of Conduct.

Which variant of the Monitoring Plugins do you use?

[ ] .rpm/.deb package from repo.linuxfabrik.ch
[ ] Compiled for Linux (.tar/.zip from download.linuxfabrik.ch)
[ ] Compiled for Windows (from download.linuxfabrik.ch)
[ ] Source Code from GitHub

Bug description
I get this error:
./strongswan-connections
Traceback (most recent call last):
  File "./strongswan-connections", line 18, in <module>
    import lib.args  # pylint: disable=C0413
ModuleNotFoundError: No module named 'lib'

why there is no lib directory in repository? how can I fix it?
Steps to reproduce - Plugin call
./strongswan-connections
Steps to reproduce - Data
No response
Environment
prod
Plugin Version
latest
Python version
No response
List of Python modules
No response
Additional Information
No response

sorry my bad