20230206

Pull requests without a rationale and clear improvement may be closed
immediately.
Please provide clear motivation for your patch and explain how it improves
Ferrite Core user experience or Ferrite Core developer experience
significantly.

Any test improvements or new tests that improve coverage are always welcome.
All other changes should have accompanying unit tests (see src/test/) or
functional tests (see test/). Contributors should note which tests cover
modified code. If no tests exist for a region of modified code, new tests
should accompany the change.
Bug fixes are most welcome when they come with steps to reproduce or an
explanation of the potential issue as well as reasoning for the way the bug
was fixed.
Features are welcome, but might be rejected due to design or scope issues.
If a feature is based on a lot of dependencies, contributors should first
consider building the system outside of Ferrite Core, if possible.
Refactoring changes are only accepted if they are required for a feature or
bug fix or otherwise improve developer experience significantly. For example,
most "code style" refactoring changes require a thorough explanation why they
are useful, what downsides they have and why they significantly improve
developer experience or avoid serious programming bugs. Note that code style
is often a subjective matter. Unless they are explicitly mentioned to be
preferred in the developer notes, stylistic code
changes are usually rejected.

Ferrite Core has a thorough review process and even the most trivial change
needs to pass a lot of eyes and requires non-zero or even substantial time
effort to review. There is a huge lack of active reviewers on the project, so
patches often sit for a long time.

Moving to v2


Terminal suggest: pwsh keywords are not suggested

exit in particular is commonly run and might be annoying that it's not there:

exit is at the bottom of the suggestion list. I would have expected it to rank higher.

@lszomoru this is actually by design because it's a (very) destructive action. It should be the first suggestion on an exact match though to work well with all runOnEnter settings.


Some minor fixes for the first release

Firstly, let me please say that I love this new mod!  Modded Minecraft is in great need of excellent mods like this to spice up the End.  Thank you!
Several minor issues I noticed so far, in order of severity:

Currently, both of the new biomes are set as PLAINS for their Biome Dictionary types.  This confuses some other mods that determine their behaviour based on the Biome Dictionary.  For example, Ender IO Zoo prevents some of its overworld mobs from spawning in any biome with the END tag.  Since these new biomes don't currently have that tag, you can end up with zombies, skeletons, and creepers spawning in the End in these new biomes.

Suggestions for Biome Dictionary tags, though modify as you see fit of course:
Stygian Growth: END, HOT, WET, FOREST
Acidic Plains: END, COLD, DRY, HILLS
There are various other Biome Dictionary tags that caught my eye as possibly appropriate, like SPOOKY, DEAD, MAGICAL, WASTELAND, LUSH, SAVANNA.  But I'm not sure what effect those have, if any.

The Acidic Plains biome currently spawns drastically less often than the Stygian Growth.  I tried flying tens of thousands of blocks and saw dozens of Stygian Growth biomes, but I could only find an Acidic Plains by using a Nature's Compass.  Since visual variety of the End is a large part of the purpose of this mod, it would be great if the Acidic Plains frequency could be bumped up a little, even if you want it to remain less common than Stygian Growth.

The name of the Acidic Plains still references what looks like an in-development name, End Volcano, in several places.  For example, using a Nature's Compass, you have to find the biome listed as End Volcano, or seeing the Biome name from the Journeymap HUD.

Thanks again!

Follow-up with another minor issue I noticed.  Not sure if this doesn't occur on default settings, or is just less noticeable.  I tried increasing the biome size in the config from 4 to 6, and I noticed some of these straight-line biome borders like in this screenshot.

I'll try the normal biome size again to see if it goes away.  But I thought it might be worth posting to see if there is a way to blend the biome borders to produce a fuzzier edge.

Thanks for the helpful feedback, I'll look into these.


Change Logo: Notification Bar, and More Tab

Describe your suggested feature
On the notification and more page, Aniyomi still has the Tachiyomi app logo.
Suggestion: Because it is so basic, it should have its own logo to make it more distinct.
Other details
You'll be confused with the Main Tachiyomi app if you don't check the notification bar.
On Notification Bar

On More Tab

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I will fill out all of the requested information in this form.

closed by 171772a0a82fb3949c46e7400306de5a592d6bf1


v1.1.6 does not work with vue 3.2.45

I cannot get this install to work
Uncaught Error: Cannot create panzoom for the current type of dom element
at Proxy.createPanZoom (vue-panzoom.js?v=59f1ef57:632:15)
at Proxy.mounted (vue-panzoom.js?v=59f1ef57:1473:36)
....
I tried with older version, different error message at 1.1.3, 1.1.4,
Can anybody help
My final goal is to get it run on Nuxt 3.0, advice would be also welcome

Any update? Dealing with the same issue.

@Winston-Guess did you fix?


Gestures does not works when the Navigator size is small

Dear All,
The gestures in modal mode does not works if the size of the Navigator is small (less than a half of the screen aprox):
<View style={{flex:1, backgroundColor: 'blue'}}>
          <View style={{flex:1, backgroundColor: 'red'}}>
          </View>
          <View style={{flex:1, backgroundColor: 'red'}}>
            <MyNavigator />
          </View>
        </View>
class HomeScreen extends Component {
  static navigationOptions = {
    title: 'Welcome',
    gesturesEnabled: true
  };
  render() {
    const { navigate } = this.props.navigation;
    return (
      <View>
        <Text>Hello, Chat App!</Text>
        <Button
          onPress={() => navigate('Chat')}
          title="Chat with Lucy"
        />
      </View>
    );
  }
}

class ChatScreen extends React.Component {
  static navigationOptions = {
    title: 'Chat with Lucy',
    gesturesEnabled: true
  };
  render() {
    return (
      <View>
        <Text>Chat with Lucy</Text>
      </View>
    );
  }
}

export default  MatchesNavigation = StackNavigator({
  Home: { screen: HomeScreen },
  Chat: { screen: ChatScreen }
},{
    mode: 'modal',
    headerMode: 'none'
  });

Pinging OP @AdriaRios  since this issue is quite old and related to an old version of the lib. If no answer I'll close in 7 days.

Hi there @AdriaRios ,
In an effort to cleanup this project and prioritize a bit, since this issue had no follow up since my last comment I'm going to close it.
If you are still having the issue with the latest version (especially if it's a bug report) please check the current open issues, and if you can't find a duplicate, open a new one that uses the new Issue Template to provide some more details to help us solve it.


Mono random crash (possibly related to threads)

Godot version
3.* (tested with all 3.. versions)
System information
Windows 11
Issue description
I have been trying to resolve this for more than a month but the debug info is very limited and i'v had no luck so far.
There seem to be random crashes and the only clue i have is that they might be related to threads. That is the only error i get:
ERROR: Mono: FATAL ERROR '* Assertion at /root/mono-<IP_ADDRESS>/mono/metadata/sgen-mono.c:2329, condition `stack == NULL || mono_handle_stack_is_empty (stack)' not met
 (in domain , error)', ABORTING! Logfile: '***/mono/mono_logs/2022-07-23_12.28.36_2544.log'.
   at: mono_log_callback (modules/mono/mono_gd/gd_mono_log.cpp:91) - Mono: FATAL ERROR '* Assertion at /root/mono-<IP_ADDRESS>/mono/metadata/sgen-mono.c:2329, condition `stack == NULL || mono_handle_stack_is_empty (stack)' not met
 (in domain , error)', ABORTING! Logfile: '***/mono/mono_logs/2022-07-23_12.28.36_2544.log'.

Mono log:
The request to load the assembly System.Net.Http v<IP_ADDRESS> was remapped to v<IP_ADDRESS> (in domain Mono, warning)
The request to load the assembly mscorlib v<IP_ADDRESS> was remapped to v<IP_ADDRESS> (in domain Mono, warning)
DllImport unable to load library 'libc'. (in domain Mono, warning)
* Assertion at /root/mono-<IP_ADDRESS>/mono/metadata/sgen-mono.c:2329, condition `stack == NULL || mono_handle_stack_is_empty (stack)' not met
 (in domain , error)

Any clues are appreciated and also if there is a way to get a more meaningful error message 🙏
Steps to reproduce
Still trying to replicate this outside of my project.
Minimal reproduction project
No response

This seems to be related to: https://github.com/godotengine/godot/issues/55528. After replacing https://github.com/Cysharp/MessagePipe which i was using as an in memory message bus (i was suspecting might have caused some threading issues since you cant know which thread the message comes from) with Godot Signals i seemed to get a more meaningful error:
ERROR: FATAL: Condition "!GDMonoUtils::is_thread_attached()" is true.
   at: free_instance_binding_data (modules/mono/csharp_script.cpp:1323)

which led to https://github.com/godotengine/godot/issues/55528. Hopefully the issue is gone but we'll have to wait and see.

It seems to have been stable so far. What fixed this for me:

Locking the thread when creating textures
locking the thread alone doesn not work unless the thread model is set to "Single threaded safe" instead of "Multi threaded".


Improve italian locale

Short description of what this resolves:
This pull request improves the IT locale that has been generated using a translator.
Changes proposed in this pull request:

Improve IT locale

Fixes: N/A.
How Has This Been Tested?

Ran the test suite through the debugger menu.
Ran through the command palette to see if changes were applied.

Screenshots (if appropriate): N/A.
Checklist:

[x] I have read the contribution guidelines.
[ ] My change requires a change to the documentation and GitHub Wiki.
[ ] I have updated the documentation and Wiki accordingly.

这是来自QQ邮箱的假期自动回复邮件。你好，我最近正在休假中，无法亲自回复你的邮件。我将在假期结束后，尽快给你回复。


:bug: Fix readme status badge

Before:

After:

Good

@UlisesGascon sorry for the ping, are you accepting contributions? Should I change anything to get this merged?


KRKS with MDF fails to converge

I'm trying to run examples/pbc/21-k_points_all_electron_scf.py, but the KRHF job with MDF fails to converge. Then I tried KRKS with 6-31gs and three different DFs, and found that only KRKS with MDF fails, while GDF and RSDF works well.
My input looks like
 lib.num_threads(28)

cell = gto.M(
    a = numpy.eye(3)*3.5668,
    atom = '''C     0.      0.      0.
              C     0.8917  0.8917  0.8917
              C     1.7834  1.7834  0.
              C     2.6751  2.6751  0.8917
              C     1.7834  0.      1.7834
              C     2.6751  0.8917  2.6751
              C     0.      1.7834  1.7834
              C     0.8917  2.6751  2.6751''',
    basis = '6-31gs',
    verbose = 4,
)

nk = [4,4,4]  # 4 k-poins for each axis, 4^3=64 kpts in total
kpts = cell.make_kpts(nk)

# Mixed density fitting
#
kmf = scf.KRKS(cell, kpts).mix_density_fit()
# In the MDF scheme, modifying the default mesh for PWs to reduce the cost
# The default mesh for PWs is a very dense-grid scheme which is automatically
# generated based on the AO basis. It is often not necessary to use dense grid
# for MDF method.
kmf.xc = 'bp86'
kmf.with_df.mesh = [10,10,10]
kmf.kernel()

# Density fitting
#
kmf = dft.KRKS(cell, kpts).density_fit(auxbasis='weigend')
kmf.xc = 'bp86'
kmf.kernel()

# Range-separated density fitting (RSDF)
# RSDF uses the same amount of memory & disk as GDF and achieves a similar
# accuracy as GDF but is often 5~10x faster than GDF in the DF initialization
# step. The following run should give an energy very close to the one above.
# see '35-range_separated_density_fitting.py' for more details of RSDF.
#
kmf = dft.KRKS(cell, kpts).rs_density_fit(auxbasis='weigend')
kmf.xc = 'bp86'
kmf.kernel()

The last part of output of MDF:
cycle= 48 E= -303.852099067206  delta_E= 0.000118  |g|= 5.63  |ddm|= 3.24
HOMO = 0.503518440799  LUMO = 0.650701422235
cycle= 49 E= -303.852167596699  delta_E= -6.85e-05  |g|=  5.6  |ddm|= 0.882
HOMO = 0.503541680834  LUMO = 0.650693150238
cycle= 50 E= -303.852098370327  delta_E= 6.92e-05  |g|= 5.63  |ddm|= 1.12
SCF not converged.
SCF energy = -303.852098370327

while GDF and RSDF both converges to an energy around -304.914.
I'm using version d096d6f.

MDF may break the symmetry between k-points. For example, integrals (i_k1,j_k2|k_k2,l_k1) should be conjugated to (i_k2,j_k1|k_k1,l_k2). If they are computed with GDF or regular FT, we can find the symmetry. This symmetry is not strictly held in MDF. It may produce large errors when computing KHF exchange . It should not affect integrals in pure DFT. I'm not clear why bp86 shows such big numerical error. So the best solution for the moment is to use GDF only in your calculations

Should we add a warning about this, e.g. when someone wants to do MDF with KHF or any DFT that requires KHF exchange?

Should we add a warning about this, e.g. when someone wants to do MDF with KHF or any DFT that requires KHF exchange?

I agree. And example pbc/21 should also be modified because it contains a KRHF-MDF job.
But, the numerical error of BP86 with MDF is still unsolved. I'm not sure whether it's my mistake or anyone can reproduce this.

PR #1168 largely solves the numerical issue in MDF. This system can be converged with MDF

Hi Qiming,
I pulled the latest master and re-ran this example, but MDF looks terrible
cycle= 1 E= 20400.2011177092  delta_E= 2.07e+04  |g|= 1.59e+06  |ddm|= 5.82e+04
cycle= 2 E= 6349227.6994518  delta_E= 6.33e+06  |g|= 3.32e+07  |ddm|= 8.63e+04
cycle= 3 E= 2906280.16576458  delta_E= -3.44e+06  |g|= 1.65e+07  |ddm|= 3.15e+04
cycle= 4 E= 7983883.36850945  delta_E= 5.08e+06  |g|= 3.71e+07  |ddm|= 5.06e+04
cycle= 5 E= 5027186.51047931  delta_E= -2.96e+06  |g|= 3.44e+07  |ddm|= 6.39e+04
cycle= 6 E= 4475985.59712399  delta_E= -5.51e+05  |g|= 3.19e+07  |ddm|= 5.41e+04

So did GDF. But RSGDF has no problem.

You may need to clean c extensions in lib and recompile the c libraries again.

Re-compiling doesn't help. Using 2.1.0 whl from pip still gives such divergence.

After pulling #1402, there's no problem for GDF. But MDF still cannot converge,
cycle= 45 E= -303.85210079551  delta_E= 3.63e-05  |g|= 5.63  |ddm|=  0.7
cycle= 46 E= -303.852077607401  delta_E= 2.32e-05  |g|= 5.64  |ddm|= 1.53
cycle= 47 E= -303.85221789706  delta_E= -0.00014  |g|= 5.58  |ddm|= 2.67
cycle= 48 E= -303.852075261412  delta_E= 0.000143  |g|= 5.64  |ddm|= 3.29
cycle= 49 E= -303.85216038947  delta_E= -8.51e-05  |g|= 5.61  |ddm|= 1.09
cycle= 50 E= -303.852100570743  delta_E= 5.98e-05  |g|= 5.63  |ddm|= 1.01

looks like the condition I met at the beginning of this issue.

Pulling #1429 (and using odd number of mesh) resolves this problem. Thanks!


404 everywhere

I'm trying to run it locally with MAMP on mac Sierra. After installing successfully it's redirected to the initial page but everything else (page, post, admin area) I get:
Not Found
The requested URL /indesol/post/first-post was not found on this server.
Anyone with a similar situation?

How is it /indesol/post/first-post ? The directory path should be /bl-content/posts/first-post
Also make sure .htaccess is present at root of the installation.

@anaggh changed from MAMP to XAMPP and, after some struggle, started working. Thanks for your help.


Bluetooth: Mesh: Fix net_find_and_decrypt() function

The function return type was declared incorrectly. Also, the magic
checking for i after exiting the loop could cause some false positive
compiler warnings. Instead, return directly from the loop (with the
downside of duplicating a few lines of code).
Signed-off-by: Johan Hedberg<EMAIL_ADDRESS>

@michal-narajowski FYI


Bump ROCM RBE container

The new container has ROCM 4.3.1 instead of ROCM 4.2

@av8ramit Can you please merge this PR?

@mihaimaruseac Can you please merge this PR?

Sorry, was OOO and then didn't get some chance to look over GitHub.


Support the type-annotations group in sort-comp.

This PR supports the type-annotations group described in https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/sort-comp.md

Thank you!


WorkerGroup update behavior in ReplicaSet pattern

/area control-plane
/area auto-scaling
/area scalability
/area usability
What would you like to be added:
We would like to encourage to allow optionally the workerGroups updates without that the updates are immediately applied (rolling update like a Deployment), but that the version or generation of the current configuration is stored next to the new configuration, initially scaled to 0, while the older generation stays available in the current scale (ReplicaSet update behavior).
With an optional taint it might be possible to prevent new workload to be scheduled on older nodes. Otherwise existing nodes could be continued to be used. However, every new nodes should be only using the newest configuration generation. Node groups offering older configuration might be excluded from scale-up for the cluster-autoscaler.
It should also be possible to not have the older nodes tainted or cordoned so that workload can freely float through the nodes as managed by the services layer.
From application side, one needs to remove nodes from the system after a while. This could be application infrastructure and explicitly kept open from Gardener side. We think that this would be totally fine as the user disables the rolling behavior explicitly and might as well enable it again. The user can remove nodes from the system with kubectl drain for example, or could just turn back on the rolling update behavior.
Why is this needed:
We have to manage and update different configuration dimensions with regular updates: kubelet version, OS version, worker configurations at IaaS (like IMDSv2). Every update is applied immediately. That means when the configuration is changed outside of a maintenance window, the system might encounter an unwanted customer visible unavailability.
To manage updates, we have to create a new workerGroup for every update to host manually next to the current configuration (blue/green). This either limits us to 2 versions, or we create as many workergroups as we want to have different versions in the system. This is multiplied by the rather static configuration of workerGroups.
The static configuration dimensions of worker type, worker size, etc. we maintain 30+ variants respectively as we cannot forecast which combination will be actually used at runtime. All those variants would be offered as node groups to the cluster-autoscaler, most of them scaled to 0 and only available as fallback measures or for corner-cases. This multiplied by the number of versions would easily outperform the cluster-autoscaler.
The system would scale better and would be easer to use if the replica set behavior from above is applied. We would just have the 30+ static configurations maintained and every version update of kubelet or os would create a new generation. The existing workers keep their respective configuration generation and thus, the customer would not see downtime. We could apply the change anytime. The majority of static workerGroup configurations are fallbacks and might have scale 0 at the moment of the event. Those older configurations can directly be removed from the system, which limits the available options for the cluster-autoscaler.
With an optional taint on the older workerGroup configurations we can enforce the current blue/green pattern and move any restarted workload directly to the new configurations to push for the update. This mode would not be active all the time as this this can create holes in the utilization.
To tackle security updates for only specific versions, e.g. the oldest or one in the middle which comprises a problem, the application layer could have an own logic to drain specific affected nodes from the system.
Figure 1 "Rolling Update Deployment for WorkerGroups"
sequenceDiagram
    actor deploymentUpdater
    deploymentUpdater ->> Shoot: update worker.kubernetes.version
    activate Shoot
    participant MachineSet gen1
    participant node gen1
    create participant MachineSet gen2
    Shoot ->> MachineSet gen2: create
    create participant node gen2
    MachineSet gen2 ->> node gen2 : create
    destroy node gen1
    MachineSet gen1 ->> node gen1 : delete
    destroy MachineSet gen1
    MachineSet gen1 -->> Shoot : finished update
    Shoot -->> deploymentUpdater : shoot healthy
    deactivate Shoot

Figure 2 "ReplicaSet update for WorkerGroups"
sequenceDiagram
    actor deploymentUpdater
    deploymentUpdater ->> Shoot: update worker.kubernetes.version
    activate Shoot
    participant MachineSet gen1
    participant node gen1
    create participant MachineSet gen2
    Shoot ->> MachineSet gen2: create
    create participant node gen2
    MachineSet gen2 ->> node gen2 : create
    MachineSet gen1 -->> Shoot : finished update
    Shoot -->> deploymentUpdater : shoot healthy
    deactivate Shoot

    actor updateService
    destroy node gen1
    updateService ->> node gen1 : drain
    destroy MachineSet gen1
    Shoot ->> MachineSet gen1 : delete empty outdated

Prerequisite: Ability to specify many more worker pools than is possible today, reflected by https://github.com/gardener/gardener/issues/9545 -> https://github.com/gardener/gardener/pull/9722, and notably https://github.com/gardener/gardener/issues/9545#issuecomment-2124980103.
We could use the time to implement the following:

With the prerequisite hitting the landscapes and assuming no other showstopper is found, you will then be able to specify more/all worker pools you need, keep the old undesired ones and have the new desired ones (with the latest K8s version, OS type or version).
Now, you don’t want the old undesired worker pools to grow, so we would provide you with a way to disable CA scale-out per worker pool (while scale-in could still happen). This way, you could taint the old undesired worker pools and let them shrink down over time. They would not be eligible for scale-out, so CA would be able to scale them in whether or not there is unscheduled workload.
As mentioned in the call, if you go with that many worker pools, you may have to pay a lot for the machines (more fragmentation is ultimately one side effect) or not get them (out of capacity), but you are always free to proactively migrate workload if you see the need to.
Once a worker pool has no nodes anymore, you can drop it from the spec, whenever you want, e.g. in between your maintenance windows or when you do the next maintenance.

Would that help you?

We discussed different options internally and agreed on a way forward to implement means to generate and manage the workerGroups in our deployment infrastructure in a way which fits to your proposal 👍 .

Now, you don’t want the old undesired worker pools to grow, so we would provide you with a way to disable CA scale-out per worker pool (while scale-in could still happen). This way, you could taint the old undesired worker pools and let them shrink down over time. They would not be eligible for scale-out, so CA would be able to scale them in whether or not there is unscheduled workload.

Agree. Can I ask for an issue link for this, which we can link to our development activities, as this is certainly a requirement for the solution, please?


Refactor FFCAPI to a local API interace, and FFTM to a utility package

This is quite a big change.

Removes the Docker build from this package - this means the existing builds will stay for those using them
Reinstates the FFCAPI definition here, which was recently moved to FF common, and now removed in https://github.com/hyperledger/firefly-common/pull/15
Refactors the FFCAPI to be a local interface, rather than remote

This is because it's just too complex to having the potential of state mismatch in event state between the FFCAPI and the FFTM, and build a clean interface

Removes the fftm and cmd directories
Moves the internal/manager to be pkg/fftm for use by FFCAPI connectors

They will inject their implementation into the fftm.Manager to start their server

Moving to draft until we have confirmed correct operation with the latest alpha code and the old FFTM codestream

Codecov Report

Merging #7 (837a4a9) into main (9ab5b7a) will decrease coverage by 6.63%.
The diff coverage is 85.84%.

@@             Coverage Diff             @@
##              main       #7      +/-   ##
===========================================
- Coverage   100.00%   93.36%   -6.64%
===========================================
  Files           15       19       +4
  Lines         1045     1627     +582
===========================================
+ Hits          1045     1519     +474
- Misses           0      101     +101
- Partials         0        7       +7

Impacted Files
Coverage Δ

pkg/fftm/api_types.go
0.00% <0.00%> (ø)

pkg/fftm/changelistener.go
100.00% <ø> (ø)

internal/events/webhooks.go
77.04% <77.04%> (ø)

internal/events/websockets.go
80.39% <80.39%> (ø)

internal/events/eventstream.go
91.87% <91.87%> (ø)

internal/ws/wsconn.go
98.96% <98.96%> (ø)

internal/confirmations/confirmations.go
100.00% <100.00%> (ø)

internal/events/listener.go
100.00% <100.00%> (ø)

internal/tmconfig/tmconfig.go
100.00% <100.00%> (ø)

internal/ws/wsserver.go
100.00% <100.00%> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab5b7a...837a4a9. Read the comment docs.


3.3.0 Release

#62 - README update, fix custom name resolver example (@warrenbuckley)
#67 - support aliasing of built in property names, to ease migration from Serilog.Filters.Expressions (@nblumhardt)

Do you have an ETA for this rolling out @nblumhardt mate ?

🚀


Equal and Not Equal validators compare dates properly

If both value and param are instances of dates, to compare equality we need to call .getTime(): http://stackoverflow.com/a/493018/1389202

Yes in deed it does not work with dates however better solution would be using the valueOf method which returns "plain/primitive" value from object, thanks to that it will work not only with Date objects but also with Number, String, Boolean etc.
var d1 = new Date(2000, 0, 1);
var d2 = new Date(2000, 0, 1);
d1 === d2 // false
d1.valueOf() === d2.valueOf() // true

var n1 = new Number(5);
var n2 = new Number(5);
n1 === n2 // false
n1.valueOf() === n2.valueOf(); // true

The problem is when to use valueOf and when do not. As every object has the valueOf method we could just use it for all values. However as I think about equality people may want to compare two objects. If references are the same then they will be equal but what about same objects but with not the same reference.
var o1 = {a: 'a'};
var o2 = {a: 'a'};
o1 === o2 // false
o1.valueOf() === o2.valueOf() // false

They should be equal. So in some situations we should use EJSON.equals(). Or maybe we should use it in all possible cases.
EJSON.equals(5, 5) // true
EJSON.equals({a: 'a'}, {a: 'a'}) // true
EJSON.equals(Number(5), Number(5)) // true

I'm happy to update the PR to use EJSON.equals() and !EJSON.equals() as it is a very comprehensive check. Should I go ahead and do that?

I've updated the PR to use EJSON.equals

Ok thanks! I just have to make sure that it works in all most common use cases and I will merge it

Hi @jagi,
Thanks, I appreciate you looking into this.
It may be impertinent to ask, but will you be able to release this as 2.0.2?  This is required for our application, along with another fix for setting non plain objects (i.e. this.set('start', new Date()) is not causing isModified() to return true.  I believe this was fixed in a16ff415cbfd651e81c4cbfb53c2115508e9c986 ).

I can probably release it as 2.1 tomorrow. I can spend some time on Astronomy as it took me quite a lot of time from 2.0 release. Maybe this week is a good time to release 2.1.


libR.so

I was trying to get rtichoke to work today and having trouble - it could not find the shared library.  My path was set up correctly so that it found the R installation directory, but I just didn't have a libR.so
Eventually, after some googling, I found that the issue is I compiled R from source and didn't enable the compilation flag "--enable-R-shlib".  Apparently, with out this, you don't get a libR.so file.
I'll probably recompile sometime soon so I can start using rtichoke (because it looks awesome), but I was thinking it may be useful to include this info in the FAQ or as part of the error message to save other people some time who might have the same issue.

You are right. It requires R to be compiled with the flag --enable-R-shlib so that it prepares the shared library libR.so. It would be great if you could tell me the error that you encountered.

The specific place it error'd was actually inside the rapi codebase:
https://github.com/randy3k/rapi/blob/e5819e5dc8d75d296b25553a5d2e0241c3dfe823/rapi/utils.py#L71
And I was running Ubuntu 16.04


Flaky unit test: TextFileEditor text file editor preserves viewstate

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=97355&view=logs&j=672276a2-8d3a-5fab-615d-090c51352f92&t=6ad30dce-518e-54c1-94da-00d19cce9354

Files - TextFileEditor text file editor preserves viewstate:
Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.

No clue where this timeout kicks in, I have to instrument and throw on each await, starting with:
https://github.com/microsoft/vscode/blob/018b924fee2b2eff2d803c55faf54d30f1293c15/src/vs/workbench/contrib/files/test/browser/textFileEditor.test.ts#L77


StoreManager, save position (reading line) in rk script

Create a func in storemanager and rakugo, to save rk script position

Do #124 before :)

@Jeremi360 Imagine we have saved the name of last script have run and the number of last line it read. We close the game and restart it. When a user do Rakugo.load_game(...), do you want it execute last script from line where it was ? Or do other thing ?

Imagine we have saved the name of last script have run and the number of last line it read. We close the game and restart it. When a user do Rakugo.load_game(...), do you want it execute last script from line where it was ? Or do other thing ?

So yes, at first I thought that getting the script from the last line where it ended is not enough,
because we also need to somehow restore the state of the stage from the moment of save.
But as I thought about it, I understood that there is no such need.
Simply put, adding signal game_loaded will enough and
this way the user will load what he needs from Rakugo.variables and apply on stage, e.g. player position.

I create new issue for it #187
So to be sure, when Rakugo.load_game, it parse last script have run and start at last line it read ?

So to be sure, when Rakugo.load_game, it parse last script have run and start at last line it read ?

Yes.

After consideration, I split it in 2 func. One for load and parse last script. And second to start script. In this case you can call load, to have access to rakugo vars. Then load your scene with background, characters sheets, sounds, etc... And finaly call Rakugo.execute_last_script(). I am afraid if we do it in one func, we send say signal (by example) to early.
I need your help to search a name for Rakugo.execute_last_script(). I think is not enough explicit. Maybe Rakugo.execute_last_script_after_load() ? What do you think ?

After consideration, I split it in 2 func. One for load and parse last script. And second to start script. In this case you can call load, to have access to rakugo vars. Then load your scene with background, characters sheets, sounds, etc... And finaly call Rakugo.execute_last_script(). I am afraid if we do it in one func, we send say signal (by example) to early.

I also think that spliting them is a good idea.

I need your help to search a name for Rakugo.execute_last_script(). I think is not enough explicit. Maybe Rakugo.execute_last_script_after_load() ? What do you think ?

I think we can call it Rakugo.resume_last_script() ?

Resume is a great idea ! What do you think about Rakugo.resume_loaded_script() ?

Resume is a great idea ! What do you think about Rakugo.resume_loaded_script() ?

Yes, this sound good,


display a Polygon in the Map component

Discussed in https://github.com/lovasoa/SQLpage/discussions/105

Originally posted by tomtomkratos October 19, 2023
Hello,
First of all, thank you for your work.
SQLpage is amazingly efficient.
Here is my question:
Concerning the map component, is it possible to visualize polygonal geometry?
That would be interesting, because in Spatialite, you can have points, lines or polygons.
Thank you very much for your reply.

v0.15.1 greatly improves the map component, and supports all GeoJSON geometries, including polygons :tada:
@tomtomkratos and @flosigime , I think you are going to like it !

Great !!! i'll try as soon as possible !
Le mer. 8 nov. 2023 à 00:05, Ophir LOJKINE @.***> a
écrit :

v0.15.1 greatly improves the map component, and supports all GeoJSON
geometries, including polygons 🎉
@tomtomkratos https://github.com/tomtomkratos and @flosigime
https://github.com/flosigime , I think you are going to like it !
—
Reply to this email directly, view it on GitHub
https://github.com/lovasoa/SQLpage/issues/119#issuecomment-1800341956,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOYEXY3WLPNAYSWDQS7I4ETYDK5CFAVCNFSM6AAAAAA6RVMKC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBQGM2DCOJVGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Florent Mercey *
- Responsable d'opération Protohistoire, Etudes céramique
Bronze/Hallstattt
- Référent SIG, Référent NAS, collectif ramen @.>
(Recherches Archéologiques en Modélisation de l'Enregistrement Numérique)
Inrap - Orléans
525 avenue de la Pomme de Pin
45590 Saint Cyr en Val
tel : 02 38 69 96 58 ; port : 06 08 90 00 62
http://www.inrap.fr

It's great !!!
I'm going to watch this new version very carefully !
Thanks again for your work...


Update MicrosoftTeamsTransport.php

Code caused following error - 'Unable to post the Microsoft Teams message: ... Summary or Text is required. '. The structure of the message needs to fit the templates defined by Microsoft Teams. Attribute $message->subject is specified as string, json_decode($message->getSubject()) solve the issue and helps generate fully defined cards in Teams canals.

Not applicable- the path for current version of the feature will be proposed in the next pull request.


Improve ZooReader/ZooReaderWriter

Inline a ClientContext method used only for the deprecated
ConnectorImpl from ClientContext into ConnectorImpl
Move construction of most new ZooReader objects into ClientContext
Avoid constructing zoo-related objects when one is available from an
existing ClientContext or ServerContext
Allow efficient conversion of ZooReader into ZooReaderWriter, with a
provided secret to avoid some object construction for ZooReaderWriter

This is an intermediate step on the way to cleaning up #2298 . It was starting to get too big, so I thought it best to stop here for now.


Stopped working and crashed loop on Macbook Pro 13 2015

Describe the bug
Since v1.6 the OrbStack start stopped working/crashed loop on my Macbook Pro 13 2015 using chip set Dual-Core Intel Core i7
When I install the OrbStack v1.5.1 then it works flawlessly
To Reproduce
Using latest version of OrbStack since v1.6
Expected behavior
The OrbStack working
Diagnostic report (REQUIRED)
OrbStack info:
Version: 1.6.1
Commit: bfaddc6839de8b00b7aff767dbd673ac6ad4259e (v1.6.1)
System info:
macOS: 12.7.5 (21H1222)
CPU: amd64, 4 cores
CPU model: Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz
Model: MacBookPro12,1
Memory: 16 GiB
Full report: https://orbstack.dev/_admin/diag/orbstack-diagreport_2024-05-29T06-09-05.755485Z.zip

Screenshots and additional context (optional)

I got this problem too, here is error log:
🌲 vmgr | time="05-29 15:36:23" level=error msg="failed to unmount nfs" error="operation not permitted"
🌲 vmgr | time="05-29 15:36:23" level=info msg="using proxy: none"
🌲 vmgr | time="05-29 15:36:23" level=info msg="forwarding SSH agent" sock=/private/tmp/com.apple.launchd.bMZREWpRXs/Listeners
🌲 vmgr | time="05-29 15:36:23" level=info msg="starting VM"
thread 'vcpu0' panicked at src/vmm/src/macos/vstate.rs:768:10:
Can't create HVF vCPU: VcpuSetRegister
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
2024-05-29 15:36:23.973 OrbStack Helper[67659:1440959] [brnet] guest read error: 54
2024-05-29 15:36:23.973 OrbStack Helper[67659:1440960] [brnet] write error: 39
panic: Internal error while starting VM: Cannot create a vCPU handle. vCPU thread failed to initialize [recovered]
panic: Internal error while starting VM: Cannot create a vCPU handle. vCPU thread failed to initialize [recovered]
panic: Internal error while starting VM: Cannot create a vCPU handle. vCPU thread failed to initialize
goroutine 1 [running]:
main.runVmManager.func3()
github.com/orbstack/macvirt/vmgr/main.go:481 +0x54
panic({0x10e593100?, 0xc00032e490?})
runtime/panic.go:920 +0x270
github.com/orbstack/macvirt/vmgr/util/errorx.RecoverCLI()
github.com/orbstack/macvirt/vmgr/util/errorx/errorx.go:29 +0x6b
panic({0x10e593100?, 0xc00032e490?})
runtime/panic.go:920 +0x270
main.check(...)
github.com/orbstack/macvirt/vmgr/main.go:93
main.runVmManager()
github.com/orbstack/macvirt/vmgr/main.go:758 +0x354b
main.main()
github.com/orbstack/macvirt/vmgr/main.go:996 +0x65
Check logs for more details.

Duplicate of #1229


wrong number of downloads are logged

Number of downloads is reported in an information log when syncing. Currently this number equals the number of extensions found, should be number of actual extensions that had any downloads.

Figure out what to actually log, downloaded versions per extension or extension that had any download?


SelfHost Stremio Error

I ran the elfhosted version first and setup and installed, I can see the comet sources.
I then installed as selfhost docker and able to run the URL and get to the config screen.
I setup the same as I did for the elfhosted version.
I uninstalled elfhosted addon.
Then I clicked install button on mine which launched to Stremio but get error:
ERR_OPENING_MEDIA
Failed to fetch

need more info, any error in console?

this problem does not come from Comet, I saw several posts on Reddit today with the same problem on other addons.

ok so logs were useless. but i started searching stremio addons on reddit like you mentioned and found one:
https://www.reddit.com/r/StremioAddons/comments/1alcwhk/error_installing_addons/
pointed me to DNS. I use Adblock DNS in my router. So I I turned off wifi on my phone and used mobile network and i was able to attach the application. Weird that elfhost version worked but my own hosted version didnt, same PC and same DNS.
That being said, the addon is added and running. but when a search is done it does not give results.
Checking logs shows:
2024-07-22 21:28:35 2024-07-22 17:28:35 | 📰 INFO | stream.stream - No cache found for IF with user configuration 2024-07-22 21:28:36 2024-07-22 17:28:36 | 📰 INFO | stream.stream - Start of prowlarr search for IF with indexers ['bitsearch', 'yts', 'therarbg', 'eztv'] 2024-07-22 21:28:41 2024-07-22 17:28:41 | ⚠ WARNING | general.get_indexer_manager - Exception while getting prowlarr results for IF with ['bitsearch', 'yts', 'therarbg', 'eztv']: Cannot connect to host prowlarr:9696 ssl:default [Try again] 2024-07-22 21:28:41 2024-07-22 17:28:41 | 📰 INFO | stream.stream - 0 torrents found for IF with prowlarr
I have prowlarr but looks like i need to fiddle with the URL, i am using the internal http docker URL so probably need to tweak that. but i was thinking that i would rather user torrentio anyways maybe. but it says false, but i dont see a config for that. where do I change that?
2024-07-22 21:02:56 2024-07-22 17:02:56 | 🌠 COMET | main.start_log - Server started on http://<IP_ADDRESS>:8000 - 1 workers 2024-07-22 21:02:56 2024-07-22 17:02:56 | 🌠 COMET | main.start_log - Database: data/comet.db - TTL: 86400s 2024-07-22 21:02:56 2024-07-22 17:02:56 | 🌠 COMET | main.start_log - Debrid Proxy: http://<IP_ADDRESS>:1080 2024-07-22 21:02:56 2024-07-22 17:02:56 | 🌠 COMET | main.start_log - Indexer Manager: prowlarr|http://Prowlarr:9696 - Timeout: 30s 2024-07-22 21:02:56 2024-07-22 17:02:56 | 🌠 COMET | main.start_log - Indexers: bitsearch, yts, therarbg, eztv 2024-07-22 21:02:56 2024-07-22 17:02:56 | 🌠 COMET | main.start_log - Get Torrent Timeout: 5s 2024-07-22 21:02:56 2024-07-22 17:02:56 | 🌠 COMET | main.start_log - Zilean: Disabled 2024-07-22 21:02:56 2024-07-22 17:02:56 | 🌠 COMET | main.start_log - Torrentio Scraper: False 2024-07-22 21:02:56 2024-07-22 17:02:56 | 🌠 COMET | main.start_log - Debrid Stream Proxy: False 2024-07-22 21:02:56 2024-07-22 17:02:56 | 🌠 COMET | main.start_log - Custom Header HTML: False

i changed prowlarr URL to my https version in the docker compose:
"INDEXER_MANAGER_URL=https://prowlarr.mydomain.org",
I also added the line:
"SCRAPE_TORRENTIO=True",
now when i search i get errors for both of them:
2024-07-22 17:43:37 |[38;2;252;95;57m[38;2;252;95;57mINFO | stream.stream -[38;2;252;95;57mNo cache found for The Bear S03E08 with user configuration 2024-07-22 17:43:38 |[38;2;252;95;57m[38;2;252;95;57mINFO | stream.stream -[38;2;252;95;57mStart of prowlarr search for The Bear S03E08 with indexers ['bitsearch', 'yts', 'therarbg', 'eztv'] 2024-07-22 17:43:38 |[38;2;220;95;0m[38;2;220;95;0mWARNING | general.get_torrentio -[38;2;220;95;0mException while getting torrents for The Bear S03E08 with Torrentio, your IP is most likely blacklisted (you should try proxying Comet): Failed to perform, curl: (7) Failed to connect to <IP_ADDRESS> port 1080 after 0 ms: Couldn't connect to server. See https://curl.se/libcurl/c/libcurl-errors.html first for more details. 2024-07-22 17:43:38 |[38;2;220;95;0m[38;2;220;95;0mWARNING | general.get_indexer_manager -[38;2;220;95;0mException while getting prowlarr results for The Bear S03E08 with ['bitsearch', 'yts', 'therarbg', 'eztv']: 0, message='Attempt to decode JSON with unexpected mimetype: text/html; charset=utf-8', url=URL('https://prowlarr.mydomain.org/cosmos-ui/login?notlogged=1&redirect=/api/v1/indexer') 2024-07-22 17:43:38 |[38;2;220;95;0m[38;2;220;95;0mWARNING | general.get_indexer_manager -[38;2;220;95;0mException while getting prowlarr results for The Bear with ['bitsearch', 'yts', 'therarbg', 'eztv']: 0, message='Attempt to decode JSON with unexpected mimetype: text/html; charset=utf-8', url=URL('https://prowlarr.mydomain.org/cosmos-ui/login?notlogged=1&redirect=/api/v1/indexer') 2024-07-22 17:43:38 |[38;2;252;95;57m[38;2;252;95;57mINFO | stream.stream -[38;2;252;95;57m0 torrents found for The Bear S03E08 with prowlarr and Torrentio


[4pt]  Fetch rockets - Fetch data

Fetch data from the Rockets endpoint  (https://api.spacexdata.com/v3/rockets) when the application starts (as Rockets is the default view).
Once the data are fetched, dispatch an action to store the selected data in Redux store:

id
name
type
flickr_images

NOTE: Make sure you only dispatch those actions once and do not add data to store on every re-render (i.e. when changing views / using navigation).

Hi @Kidd254 Please I kindly ask you to review this PR: https://github.com/NitBravoA92/space-travelers-hub/pull/32


perfdash code for storageURL to nfs server

What would you like to be added:
Hi dear experts,
Could we add nfs support for perfdash storage?  Not sure whether we can add  potential implementation there.  We want to use nfs storage ,in pervious only support gcs and s3. Many thanks in advance.
Why is this needed:
We use  nfs server due to it deploy very fast and easy to maintain, and cost saving.

@marseel @mborsz Many thanks for helping check this.


Update client3:async-http-client-backend-zio, ... to 3.8.5

Updates

com.softwaremill.sttp.client3:async-http-client-backend-zio
com.softwaremill.sttp.client3:circe
com.softwaremill.sttp.client3:core
com.softwaremill.sttp.client3:slf4j-backend
com.softwaremill.sttp.client3:zio

from 3.3.18 to 3.8.5.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.client3" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.softwaremill.sttp.client3" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #430.


Notifications Beta: open-all-notifications is broken

open-all-notifications doesn't support the new notifications beta. This should be solved once it leaves the beta.

Duplicate of https://github.com/sindresorhus/refined-github/issues/2911


travis badge shows only results for master branch

Codecov Report

Merging #296 into master will not change coverage.
The diff coverage is n/a.


check windows

Codecov Report

Merging #93 (87dcdee) into master (3d7561d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   51.13%   51.13%
=======================================
  Files           1        1
  Lines         483      483
=======================================
  Hits          247      247
  Misses        209      209
  Partials       27       27

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

As it seems to me, these lines:
https://github.com/kevincobain2000/action-gobrew/blob/master/action.yml#L17-L19
do not worked on windows. What do you think?

Yea, I have tbh no idea about windows.

Interesting, I have the same change you made on a branch here and it worked:

probably failing at gobrew version on windows.

Oddly enough, gobrew version consumes lot of time on Mac
╰─$ time gobrew version
[INFO] gobrew version is 1.7.9
gobrew version  0.01s user 0.01s system 0% cpu 6.308 total

ah because gobrew version calls github api to get the latest version and can also lead to api rate limit exceeded, making it fail

Raised issue here #94

This pull req is ready for review and merge

Interesting, I have the same change you made on a branch here and it worked:
https://github.com/beppler/gobrew/actions/runs/3939062367

Because my workflow had gobrew version which failed due to rate limit exceeded as it calls api.github.., therefore your workflow passed with no worries.

Very intresting


[FIX]: crash on android 14

Changes

Check if the device's Android version is Oreo or higher. If Oreo or higher, register the broadcast receiver with additional parameters to request permission for sending SMS. If below Oreo, register the broadcast receiver with basic parameters (without permission request).
Troubles (optional)

Fix issue: https://github.com/surfstudio/flutter-otp-autofill/issues/70
Note (optional)

Checklist for self-check

[x] Commits and PRs have been filed according to the rules on the project.
[x] The author is marked as an assigne and assigned mandatory reviewers.
[x] Required labels marked
[ ] Specified related tasks and/or related PRs.
[x] Specified Changes.
[ ] Attached videos/screenshots demonstrating the fix/feature.
[x] All unspecified fields in the PR description deleted.
[ ] New code covered by tests.

Checklist for reviewers

[ ] CI passed successfully (with a green check mark).
[ ] PR is atomic, by volume no more than 400 (+-) corrected lines (not including codogen).

Design:

[ ] System design corresponds to the agreements on structure and architecture on the project.
[ ] The code is decomposed into necessary and sufficient components.

Functionality:

[ ] The code solves the problem.
[ ] Any changes to the user interface are reasonable and look good.

Complexity:

[ ] The code is clear, easy to read, functions are small, no more than 50 lines.
[ ] The logic is not overcomplicated, there is no overengineering (no code sections that may be needed in the future, but no one knows about it).

Tests:

[ ] Updated or added tests for mandatory components.
[ ] The tests are correct, helpful, and well designed/developed.

Naming:

[ ] The naming of variables, methods, classes and other components is understandable.

Comments:

[ ] The comments are understandable and helpful.

Documentation:

[ ] All labels are correct
[ ] Technical documentation updated (after approval, updates last reviewer).

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6d152e6) 96.34% compared to head (899b0d4) 96.34%.

:exclamation: Current head 899b0d4 differs from pull request most recent head f243355. Consider uploading reports for the commit f243355 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   96.34%   96.34%
=======================================
  Files           4        4
  Lines          82       82
=======================================
  Hits           79       79
  Misses          3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Feature Request] Adding Visualizations for better understanding of Shortest Path Graph Algorithms

🚀 Feature Request
Is your feature request related to a problem? Please describe.
Currently, the Shortest Path Graph Algorithms section (Not just this section) primarily contains theoretical content and code implementations, which can make it challenging for users to fully grasp the concepts. Users, especially beginners may struggle to visualize how the algorithms work in practice, leading to potential misunderstandings or difficulties in applying the algorithms to real-world problems.
Describe the solution you'd like
I propose incorporating visualizations for each of the Shortest Path Graph Algorithms using Mermaid diagrams and Docusaurus
Describe alternatives you've considered
.
Additional context
.
Screenshots of samples

Would you like to work on this feature?

[x] Yes
[ ] No

@J-B-Mugundh, can you add a visualization like https://ajay-dhangar.github.io/algo/docs/basic-dsa/array/arrays-in-dsa#visualizations-of-arrays-in-data-structures-and-algorithms-dsa and code like https://github.com/ajay-dhangar/algo/tree/main/src/components/DSA/arrays? If you can do that, I'll assign you level 3. For now, I'll assign you level 2.

@ajay-dhangar Could u elaborate? I could add the code by creating a folder let's say GraphVisualizer and inside that folder, i'll have a file called index.tsx . Then, i'll mention as  in the md code? Is that it?

@ajay-dhangar I've resolved the issues and implemented like this.. is it fine?
https://drive.google.com/file/d/1DE9iJOQCstLYPAmWNUsBlDlub1oypFv9/view?usp=sharing


Steps for next prime number

Related Issue

Info about Issue or bug

fix: #2662
Describe the changes you've made
Added Steps for next prime number
Checklist:

[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.

Screenshots

Original
Updated

original screenshot
updated screenshot

@sairish2001 please review


Question: Admins editing registrations and the requirement of current password.

Whats the best pattern to allow for admins to edit registrations.
IE override current_password requirement.
Do I just need to make a new changeset in my user schema?

Yeah, make a new changeset method for admin.
The default changeset can be changed so current password isn't required, but it's much better to just have an explicit changeset method for admin (you can always DRY up the two with a combined private method).

Thanks


Alerts Management Python SDK - [Patch Method] on Smart Detector Rule - Cannot set 'state' to Enabled

Package Name: azure-mgmt-alertsmanagement
Package Version: 1.0.0b1
Operating System: Mac OS / Ubuntu
Python Version: 3.9.0

Describe the bug
When using the Patch method in Smart Detector Operations, it does not seem possible to set the 'state' of the Smart Detector Rule from:
Disabled -> Enabled.
However, it is possible to set the 'state' of the Smart Detector Rule from:
Enabled -> Disabled
Please refer to the following code being used to call the Patch method:
patch_sdr_response = client.smart_detector_alert_rules.patch(
     my_rg_name,
     my_alert_name,
     {
          "state": "Enabled" # Trying to set the 'state' of a currently "Disabled" Smart Detector Rule, but has no effect - remains in Disabled state.
     }
    )
logger.debug('Updated scheduled query rule successfully!')
logger.debug(f'Call returned: \n{patch_sdr_response}')
logger.debug(f'Alert enabled status: {patch_sdr_response.state}') # Returns "Disabled" with no error. If state isn't changed, should this emit an error?

To Reproduce
Steps to reproduce the behavior:

Run the above code sample to set an existing alert in an Enabled state to "Disabled" or set state to "Disabled" via Azure portal.
Run the above code again, to set the Smart Detector Rule that was Disabled in step (1) to "Enabled".
Smart Detector stays in a "Disabled" state.
Activity log in Azure portal only shows logs for cases where Smart Detectors move from Enabled -> Disabled state, but never for Disabled -> Enabled.

Expected behavior
Given the above piece of code, I would expect the Smart Detector Rule to move from a Disabled state to an Enabled state.
Screenshots
N/A
Additional context
N/A

Thanks for the feedback, we’ll investigate asap.


updated the top section of about us page + readme adoc file + setup coveralls and appveyor + added shorthand command for clear and find (with updated tests and userguide)

conflicts resolved!


Run Without SSL Cert?

I'm also using Traefik in my setup and so don't need an SSL cert as Traefik is handling all that. Do you have any instructions on how to run the Docker image without creating a dev cert?

I'm also using Traefik in my setup and so don't need an SSL cert as Traefik is handling all that. Do you have any instructions on how to run the Docker image without creating a dev cert?
For reference, I'm intending to access the site at presenceligt.redacted.com, but presencelight.local would be acceptable as well, so I have both set up for now. I'm running in a docker swarm and my stack is below:
version: '3.3'
services:
presencelight:
image: isaaclevin/presencelight:debian-arm64
environment:
ASPNETCORE_ENVIRONMENT: Development
ASPNETCORE_URLS: https://+:5001;http://+:5000
AzureAd__RedirectHost: https://presencelight.local/signin-oidc
TZ: America/Chicago
volumes:
- /dockervolumes/presencelight:/app/config
networks:
- web_public
logging:
driver: json-file
deploy:
labels:
traefik.docker.network: web_public
traefik.enable: 'true'
traefik.http.routers.presencelight.entrypoints: https
traefik.http.routers.presencelight.rule: Host(presencelight.redacted.com, presencelight.local)
traefik.http.routers.presencelight.service: presencelight
traefik.http.services.presencelight.loadbalancer.server.port: '5000'
networks:
web_public:
external: true

You will need a cert for https redirection from Azure AD, so you will need to follow the steps outlined here
https://github.com/isaacrlevin/PresenceLight/blob/main/worker-README.md#how-are-you-handling-ssl


Change nextUri slug for every request

Fixes https://github.com/prestosql/presto/issues/1654

What's the risk if we leave slug same for every request? Browsers for instance use the same cookie for the entire session duration and it's not posed as a great security risk?

@sopel39 i added the rationale to the issue

squashed


Parse multifile COMPOSE_FILE envvar, w/ side effect

Fixes #212
urfave/cli does not distinguish whether the first string in the slice
comes from the envvar or is from a flag. Worse off, it appends the flag
values to the envvar value instead of overriding it. To ensure the
multifile envvar case is always handled, the first string must always be
split. It gives a more consistent behavior, then, to split each string
in the slice. With this side effect, the following is possible and
would merge the compose files left to right:
$ COMPOSE_FILE=a.yml:b.yml ./libcompose-cli -f c.yml -f d.yml:e.yml up

Signed-off-by: Dustin Chapman<EMAIL_ADDRESS>

Nice!

LGTM :cat:


add decorators; add scope to current_user to rails app that use devis…

add decorators
add scope to current_user to rails app that use devise with another scoped

This is great! Just what I was looking for.

https://github.com/code-mancers/rapidfire/commit/ecc7a5b9d127e887ec500fcc10eca68e120b03db

@altherlex please add specs if you have time. Thanks for PR 👍


Badge association

Utils for supporting locationIds as well

Codecov Report

Merging #382 into release-1.14-sp3 will decrease coverage by 0.07%.
The diff coverage is 5.55%.

@@                  Coverage Diff                   @@
##             release-1.14-sp3     #382      +/-   ##
======================================================
- Coverage               40.74%   40.66%   -0.08%
  Complexity                772      772
======================================================
  Files                     110      110
  Lines                    7587     7604      +17
  Branches                  864      867       +3
======================================================
+ Hits                     3091     3092       +1
- Misses                   4164     4180      +16
  Partials                  332      332

Impacted Files
Coverage Δ
Complexity Δ

...sunbird/common/models/util/GeoLocationJsonKey.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...mmon/request/orgvalidator/OrgRequestValidator.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../org/sunbird/common/responsecode/ResponseCode.java
94.23% <100%> (+0.01%)
14 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 415d29e...986363b. Read the comment docs.


Unusual lines in Bootstrap modal while hovering/clicking on Input/button controls

Hi,
This is in continuation to Defect #15677. Our application has heavy usage of bootstrap modal. However, Internet explorer 11 has some unusual behavior at 150% zoom level.
For instance, If a modal has input/button controls placed on it then there are some unusual black lines appear on the modal. I have tested this issue with demo examples available on bootstrap official website and it is reproducible. Additionally, If you would click multiple times on any text block, you would find these unusual lines.
I use bootstrap v3.3.7, however, I am able to replicate the issue with latest version as well.
Below are the list of links where issue is reproducible in IE 11 with 150% zoom level:
https://getbootstrap.com/docs/4.0/components/modal/
https://dojo.telerik.com/IdozEHUR/2
https://getbootstrap.com/docs/3.3/javascript/#modals
Attached here are few snapshots of the issue from above links:

Looking forward to any concrete solution.

@cvrebert could you please have a look?

Finally checked this out on my PC—no issues in IE11 here on v4.0 or v4.4 docs.


Docs

Maybe we should copy over the docs from the orginal project and modify them for our needs

Added simple docs


Updating my repo

Hello @kmader! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pycore/tikzeng.py:

Line 5:31: E201 whitespace after '('
Line 5:54: E202 whitespace before ')'
Line 37:1: E302 expected 2 blank lines, found 1
Line 37:14: E201 whitespace after '('
Line 37:70: E202 whitespace before ')'
Line 39:59: E225 missing whitespace around operator
Line 39:65: E225 missing whitespace around operator
Line 39:70: W605 invalid escape sequence '\i'
Line 39:80: E501 line too long (172 > 79 characters)
Line 39:96: E225 missing whitespace around operator
Line 39:128: E225 missing whitespace around operator
Line 39:155: E225 missing whitespace around operator
Line 39:167: E225 missing whitespace around operator
Line 176:1: W605 invalid escape sequence '\p'
Line 176:11: E225 missing whitespace around operator
Line 176:17: E225 missing whitespace around operator
Line 176:36: E225 missing whitespace around operator
Line 176:42: E225 missing whitespace around operator
Line 176:72: E225 missing whitespace around operator
Line 176:80: E501 line too long (108 > 79 characters)
Line 176:84: E225 missing whitespace around operator
Line 176:93: E225 missing whitespace around operator
Line 176:99: E225 missing whitespace around operator


EChart version is too old Can you update version of EChart

This project using EChart 3.1.5, but that version is so buggy.
In my case, textStyle.color doesn't work.
I tested it with EChart 3.3.1 and then It works fine.
Can you update lastest version of EChart?

Just published<EMAIL_ADDRESS>


FieldError when using select_related with enable_only_optimization

When trying to use select_related on a field, I am getting an error when the DjangoOptimizerExtension is used with its default enable_only_optimization=True.
This happens because only() is used with "id", and then select_related is issued on top:
https://github.com/blb-ventures/strawberry-django-plus/blob/9a54dd0378b31302b99754704ccd9f1025f43fbd/strawberry_django_plus/optimizer.py#L529-L533

django.core.exceptions.FieldError: Field Foo.bar cannot be both deferred and traversed using select_related at the same time.

A workaround is to add the field also to only, but that could be done automatically then also.
@django_type(models.Foo, filters=FooFilter, pagination=True)
class Foo:
    bar: Bar
    special_bar: Bar | None = gql.django.field(
        only=["bar"],  # workaround
        select_related=["bar"]
    )

I am not sure about the select_related being necessary/useful here yet (maybe because of the Optional/None it might be necessary), but I think it's a generic issue.
I also wondered what's the point of enable_only_optimization.  Is it to reduce the amount of data being selected/transferred only?
(related)

This is related to https://github.com/blb-ventures/strawberry-django-plus/issues/154, i.e. it is with a non-model field, and specifying field_name fixes it / helps there.

Is that special_bar a property?
And yes, the only optimization is to reduce the amount of data being selected and transferred. It does make some difference in speed, but it is the least important optimization indeed.

Is that special_bar a property?

Yes.
It's to a FK's property, which I am turning into an actual field, but field_name="bar__special" is not supported (no splitting by field separators).. but here select_related (or rather model properties as you mentioned in https://github.com/blb-ventures/strawberry-django-plus/issues/154#issuecomment-1357934958 should work better then).

Should I close this issue then since the model property solves the issue? Or is there something extra that we should support here?

I think having to specify only as a workaround should/could be handled automatically.


TST: integration tests on ODFE

Issue #, if available:
#52
Description of changes:
This PR largely follows: https://github.com/opendistro-for-elasticsearch/anomaly-detection/blob/master/src/test/java/com/amazon/opendistroforelasticsearch/ad/ODFERestTestCase.java
except for flatten the multi-fold inheritance out.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chenqi0805 Is this still good to go? Also should we call this as /.github/workflows/elasticesearch-sink-integ.yml

@kowshikn I will doublecheck if there is any breakage.

Also should we call this as /.github/workflows/elasticesearch-sink-integ.yml

You mean a separate github action/workflow on this? Yes

@kowshikn There is no breakage based off latest master. This is good for a review. I will do refactoring of CI in a separate PR if necessary.


Add AMD support

Add support for using es6-promise-polyfill as a AMD module.
Note: I couldn't create a new promise.min.js because there are no instructions on how to do so (See #7).

AMD is already supported. Use something like this:
define(["./path/to/promise.min.js"], function(Promise) {
    var promise = new Promise();
});

A bit of a misconfusion here: AMD is indeed supported but it doesn't work in browser (Using RequireJS). See #9 .


chore: upgrade version 0.4.0-alpha.6

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4aa7a05) 6.49% compared to head (8378886) 6.49%.
Report is 56 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #241   +/-   ##
=====================================
  Coverage   6.49%   6.49%
=====================================
  Files         72      72
  Lines       3985    3985
  Branches     781     781
=====================================
  Hits         259     259
  Misses      2972    2972
  Partials     754     754

Flag
Coverage Δ

unittests
6.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


DOD

[x] Fix most of the critical code smells
[x] Fix "Unexpected var, use let or const instead." code smells.
[x] Fix "Extract this nested ternary operation into an independent statement." code smells.
[x] Code Smells on Request Description, Divisional Stages etc.
[x] Fix some of the "Remove the unused function parameter" code smells.

To a regression with sync and state change and notifications.

Basic regression complete - no issues found - closing ticket.


Add Affinity logos and Roblox

New icons added:

Affinity Designer, Affinity Photo and Affinity Publisher #59
Roblox #68

Thanks 🚀✨


Domain management: Remove the support of Elasticsearch engine

Describe the feature
Amazon OpenSearch Service historically provide Elasticsearch engine v7.10. Starting from CLO v2, we remove the support of Elasticsearch. For existing customers, we recommend to upgrade to OpenSearch engine to get the timely support from AWS.
Use Case
N/A
Proposed Solution
No response
Other Information
No response
Solution version used
v1.0.3

https://github.com/aws-solutions/centralized-logging-with-opensearch/releases/tag/v2.0.0


possible problem with SoftmaxWithLoss

I'm trying to convert a NIN model and post conversion while saving source i get this error:
"Error encountered: No handler found for node kind: SoftmaxWithLoss (expected: map_softmax_with_loss)"
Is that a problem with the SoftmaxWithLoss support or is this a problem with my specific model?
thanks
S.R.H

Currently, caffe-tensorflow primarily supports inference-mode conversions.
Conversion for many of the "training layers", including SoftmaxWithLoss, has not been implemented.
Taking out the SoftmaxWithLoss layer, or using the "deploy" version, should work


Using gstatic URLs

Hello,
When using these URLs for Noto Emoji PNGs,
https://fonts.gstatic.com/s/e/notoemoji/latest/1f3f3_200d_26a7/128.png
Is there a way to replace "latest" with a snapshot of Unicode 13.0 ?
Also, there appears to be some PNGs that don't seem to be available through those URLs, yet they are generated when building the source code.
Two examples:
https://fonts.gstatic.com/s/e/notoemoji/latest/1f3fb/128.png
https://fonts.gstatic.com/s/e/notoemoji/latest/1f1e7/128.png
Any ideas why?
Thank you very much.

There's no versioning on gstatic currently.
The push to gstatic is now a bit outdated (Unicode 12.1) and I would personally recommend against using it, as it's not documented.
@rsheeter feel free to re-open if you'd like to push the 13.1 to gstatic.

@rsheeter I would appreciate it if you could update the version on gstatic... Also it seems that while 1f3fb has been added, regional indicators are still missing for some reason... (1f1e7). I would be using the git repository, but that's missing the flags... Some guidance would be appreciated :)
A little looking around reveals that Google voice use their own copy, but that's only available in PNG form: https://www.gstatic.com/voice-fe/emoji/noto_v2/emoji_u1f1ed.png

fonts.gstatic should be up to 13.1. If naked region indicators are in RGI_Emoji (going from memory I believe not) then it's a bug if we don't support. Flags should be in https://github.com/googlefonts/noto-emoji/tree/main/third_party/region-flags.


Recommended Changes + Some information about some bugs.

As for the bug, line numbers don't necessarily break entirely when switching tabs. When text is entered after switching tabs the line numbers come back.
Also, some fancy vertical tabs on the side instead of the top would look cool!

Thanks for the info about the bug. I think I can fix it now. My sidebar component isn't very good, so until I can make a better one; I will leave the tabs at the top. Plus, I'm not sure how a three paned workspace would work.


Update external shuffle service docs

Using the design doc as base
cc @erikerlandson @mccheah @ash211

LGTM


Remove Linq.

You have a couple of places there you use System.Linq -- particularly, in Animator class. Linq is very slow and generates garbage. You're making a library for games, where performance matters. It won't be hard to replace Linq,

Did you even check HOW Linq is being used?

Yes. You're converting an array to a dictionary, which can be done with a for loop, and trying to get first element of that dictionary (???) while having access to that original array (???).
Instead of overengineering you can do this:
// Instead of
Animations = entity.Animations.ToDictionary(a => a.Name, a => a);

// Do:
Animations = new Dictionary(string, SpriterAnimation);
for (var i = 0; i < entity.Animations.Length; i += 1)
{
  Animations.Add(entity.Animations[i].Name, entity.Animations);
}
_defaultAnimationName = entity.Animations[0].Name;

// Instead of
Play(Animations.Keys.First();

// Do:
Play(_defaultAnimationName);

What I meant is how it's being used in terms of impact. More precisely, in the Animator class it is used:

In the constructor, which is invoked only once by definition
In the update function it is called once, and only in the edge case where the animation is not explicitly set which is very unlikely in a real world scenario

Based on this, talking about it not being performant in this case makes little sense especially since it would make it less readable. However, if you do think this is causing a bottleneck, feel free to prove it with actual code and numbers and not just a generalised statement about it. This is computer science after all, not computer opinions.
That being said, in the version 2.0 most likely there won't be any Linq.


#SW-12850

Fixed loading of article-download attributes.
Why?
Attributes are needed to extend the functionality of article-downloads
What?
LegacyStructConvert.php changed to convert the attributes as well as the other fields.

Sorry, i changed the spacings for some functions in the last commits. This is fixed now with the new commit.

Hi guys. Any update on this PR?

Hi @roman-1983, the PR looks fine to me.
We will go through all the open PRs after we released SW 5.1.1.

Thanks for the feedback.

It's almost 3 months ago from now - any feedback on that PR?

Sorry for the delay. We will actively work on the open github issues now.
Your PR is imported in our internal systems and is waiting for QA now.

Merged with commit https://github.com/shopware/shopware/commit/662199774b57af47ee0e0abe488922d0643e78d9.
Thank you @roman-1983.


Gibbs Free Energy

Given we have an entropy call, it seems relatively trivial now to add a Gibbs free energy call to the EOS base class that automatically converts between potentials.
$$G(\rho, T) = \varepsilon(\rho, T) + \frac{P(\rho, T)}{\rho} - T S(\rho, T)$$

That's fine with me. We can also think about the density-energy call too:
G(\rho, \epsilon) = \epsilon + \frac{P(\rho, \epsilon)}{\rho} - T(\rho, \epsilon) S(\rho, \epsilon)


I would like to know how long your model was trained on a single RTX 3090？

I would like to know how long your model was trained on a single RTX 3090?

It takes less than one day to train and test the refcocog dataset. Using fewer negative samples (e.g., 3) can also boost the training speed, but the model's performance may be slightly degraded.


Remove channel memberships when a user is removed from a team

Summary
Remove channel memberships when a user is removed from a team
Ticket Link
MM-19414
Related Pull Requests

Has redux changes (mattermost/mattermost-redux#951)

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-4022.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Test server destroyed

need to figure out why the build is failing


Update Get-CsOnlineDialInConferencingUserInfo.md

The cmdlet documented in this page will be deprecated on December 31, 2021. This updates adds a note notifying readers of the upcoming change.

Docs Build status updates of commit 09996db:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineDialInConferencingUserInfo.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@tseward @dariomws @get-itips Please review. Thanks

@tseward

@tiburd Please merge this PR. Thanks

Docs Build status updates of commit 3e460fa:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineDialInConferencingUserInfo.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


fix: misprint in svg-spites article

Thank you for trying to help, but this is not a mistype, this is a (bad) joke: fix for Firefox is Firefix.


Update readme.md

The _error.js works only if it is in the /pages folder, thought it would be good to state it in the readme

Yep sure. Thanks for clarifying it.


hud: always reset when closing

Hello @landism, @maiamcc,
Please review the following commits I made in branch nicks/reset:
8ec1200b7f898879e5c486c020b5ec5832072907 (2018-10-18 16:42:49 -0400)
hud: always reset when closing

this fixes a bug where the demo would finish, and call cancel(), but the terminal would end in a weird state


consistency

Hi. Just noticed that for the BME280 driver, the registers are defined with the READ bit set, therefore init is always success but writes are not being done. At the same time for BMG160, registers are defined without the READ bit set. BMG160 driver makes more sense to me since you have to SET the read bit in the spi read routine instead of UNSET the bit in the write routine. Maybe it would be a good ideea to have consistency over your drivers. Thanks!

Thanks for the input.
Register definition in the API is following the data sheet. The bit mask for SPI read should be handled in the platform side.
Please refer the BME280_SPI_bus_read in bme280_support.c file.


Neato Botvac D5

Hello,
I recently install your plug-in, to integrate my Botvac D5 to my homeKit scenes. However, if the plug-in seems to works, and the accessory appear in my Home App, there are two switchs wich appear for the Neato and none of them seems to works. I can activate any of them, but the Neato doesn't move.
In the same time, the Dock detector seems to works perfectly.
How can I help you to debug it ?
Best regards,

Hello lolfr,
thank you for posting here. I appreciate that. First of all, please make sure you use the latest version 0.3.0 of the plugin that i published 4 days ago.
What App do you use for homekit? Can you try "Elgato Eve"? You should see 4 switches, the dock state and battery state. Do you see all that?

It would be really helpful if you could start your homebridge with the debug command for my plugin (just change the path to your directory):
sudo DEBUG=homebridge-neato homebridge -U /var/lib/homebridge
Then please check the console output for messages from the robot. Like this:

[5/17/2017, 7:14:23 PM] [Sam] Found robot: Sam

There will also be an output of all available commands for the robot (some null). Ignore that for now. Set the switch for "Go To Dock" to off and the available commands will be output in the console again (all true or false). That should look like this:

homebridge-neato Robot {
homebridge-neato   _baseUrl: 'https://nucleo.neatocloud.com/vendors/neato/robots/',
homebridge-neato   name: 'Sam',
homebridge-neato   _serial: '',
homebridge-neato   _secret: '',
homebridge-neato   eco: false,
homebridge-neato   spotWidth: 100,
homebridge-neato   spotHeight: 100,
homebridge-neato   spotRepeat: false,
homebridge-neato   isCharging: false,
homebridge-neato   isDocked: true,
homebridge-neato   isScheduleEnabled: false,
homebridge-neato   dockHasBeenSeen: false,
homebridge-neato   charge: 98,
homebridge-neato   canStart: true,
homebridge-neato   canStop: false,
homebridge-neato   canPause: false,
homebridge-neato   canResume: false,
homebridge-neato   canGoToBase: false } +880ms

Can you paste that here? But please REMOVE YOUR SERIAL AND SECRET before pasting, otherwise i might clean your house :) .
Best wishes
Arne

Another question. Does an exclamation mark occur when you try to start cleaning with the Eve App? Can you enable and disable the schedule and does it change properly on the robot?

Hey, you might not need to debug. I checked the neato docs and created a pull request for the underlying neato node which the creator instantly published. So after an update to 0.3.1 the plugin should work with your D5 now. Just run sudo npm update -g homebridge-neato

Whoa 😲 you're fast.
I'll have plan to do the test this weekend. But in the meantime I have to debug my system, because I installed a bunch of plug-ins for homebridge and now it's quit inexplicably really often.
I'll check this and keep you in touch.
Laurent
On 18 May 2017 at 19:23:55, Arne (notifications@github.com(mailto:notifications@github.com)) wrote:

Hey, you might not need to debug. I checked the neato docs and created a pull request for the underlying neato node which the creator instantly published. So after an update to 0.3.1 the plugin should work with your D5 now. Just run sudo npm update -g homebridge-neato
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub(https://github.com/naofireblade/homebridge-neato/issues/1#issuecomment-302482352), or mute the thread(https://github.com/notifications/unsubscribe-auth/AXyg-MsnzoGbwq8hLqavSUA05IKii265ks5r7H6rgaJpZM4Ndo_u).

So I do the update and it's works fine now.
Next step for me is to create scripts. 😁
Thanksgiving a lot for the terrific job !! 👍👍👍
On 18 May 2017 at 19:58:23, Laurent Peronnet (lolfrgm@gmail.com(mailto:lolfrgm@gmail.com)) wrote:

Whoa 😲 you're fast.
I'll have plan to do the test this weekend. But in the meantime I have to debug my system, because I installed a bunch of plug-ins for homebridge and now it's quit inexplicably really often.
I'll check this and keep you in touch.
Laurent
On 18 May 2017 at 19:23:55, Arne (notifications@github.com(mailto:notifications@github.com)) wrote:

Hey, you might not need to debug. I checked the neato docs and created a pull request for the underlying neato node which the creator instantly published. So after an update to 0.3.1 the plugin should work with your D5 now. Just run sudo npm update -g homebridge-neato
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub(https://github.com/naofireblade/homebridge-neato/issues/1#issuecomment-302482352), or mute the thread(https://github.com/notifications/unsubscribe-auth/AXyg-MsnzoGbwq8hLqavSUA05IKii265ks5r7H6rgaJpZM4Ndo_u).

Great to hear that. Thanks for your feedback.

Yes, i updated the plugin meanwhile to support multiple robots at once. You have to put your config now into "platforms". In the readme is an example for the new config.

Damn… I knew i would have to read the readme file… always RTFM !! 😅
Sorry, and thanks again for your terrific work.
Cheers
On 6 June 2017 at 21:10:30, Arne (notifications@github.com(mailto:notifications@github.com)) wrote:

Yes, i updated the plugin meanwhile to support multiple robots at once. You have to put your config now into "platforms". In the readme is an example for the new config.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub(https://github.com/naofireblade/homebridge-neato/issues/1#issuecomment-306587439), or mute the thread(https://github.com/notifications/unsubscribe-auth/AXyg-In19cmAkwQobvZeCPHD52Km4oP3ks5sBaQmgaJpZM4Ndo_u).


State Comments section of email

Table
State_Comments
Relationship

1:M using GlobalID on RDCC Project Layer and RelGlobalID on the State_Comment Table

Included in email:
State Comment(s) Published (section heading)
     Project # ProjectID - project_abstract
     Sponsor: sponsor

"Download State Comment(s)..."  line and link removed b/c there is no longer a way to link directly to individual projects on the new RDCC dashboard.

That query doesn't have a filter and would get every record. What is the filtering criteria?

I am not understanding the database model.

It only looks like a 1:M lookup table. Do I need to traverse into another table for any information? Or am I simply querying all the data in this table and showing the projects and there is some other process that manages the records?
The hibernate code references uploadDate and attachments. Do those need to be involved?
SELECT p from Project p where p.id in (SELECT distinct p2.id from Project p2 join p2.attachments as att where att.uploadDate > [7 days ago] and att.uploadDate < [today]);

I spoke to jason and he mentioned using the status of
{
"name": "State Comment Published",
"code": "7"
}```

along with the `last_edited_date ` field.

I'm going to code this up for the time range of today minus 7 days for the time being.

Validated with client, including

I'm going to code this up for the time range of today minus 7 days for the time being.

Any changes to this email section will be tracked in separate issue(s).


ngAtomicNotify is undefined

I tried this but i am getting ur directive undefined when it gets to "displayNotify" function in your service.
On further debugging i found that
angular.element('ng-atomic-notify').isolateScope() return nothing.
FYI all my view and controller are under parent controller
Update:- The issue is if we use this directive under parent controller it doesn't work coz of scope issue but in a lot of cases you would maintain ur whole application via one parent controller not via rootscope.
I will wait for your thoughts

Already fixed in version 1.0.2
Thank you.