Unselect events after action in Events view

This is intended to fix to https://github.com/sensu/uchiwa/issues/258.
This PR adds unselectEvents(), which sets event.selected to false for each event in an array of events. resolveEvents() and silenceEvents() have been updated to call unselectEvents(selectedEvents) to ensure that events are properly unselected after an action is performed on them.

This can be made more generic and thrown into factories.js or services.js (@palourde - not sure which file is best). This way it can be reused for events, clients, and more.
Aside from that, :+1:

@amdprophet, happy to refactor this after input from @palourde on which location would be preferred.

Most recent commit is a stab at generalizing this as @amdprophet suggested.

:+1:

Awesome work, thanks!


Black list XDG_SESSION_TYPE from doom-env

The variable is obsolete once we switch between "x11" and "wayland".
Also Emacs can infer it perfectly without setting it first.

Makes sense to me, thanks!


Lidar array

OVERVIEW
Adds documentation for the lidar array.
CHANGES
Creates a page for the mono_lidar_array.vi
TEST
You can see at the results in this link.

Thanks for the review. It should be ready for another look.


KeyError: 'filename' running simple inference example

Hi,
after successful installation, I am trying to go through the inference example in:
https://github.com/open-mmlab/mmdetection/blob/master/docs/GETTING_STARTED.md#high-level-apis-for-testing-images
However, at line:
result = inference_detector(model, img)

I get:
KeyError                                  Traceback (most recent call last)
<ipython-input-1-8b1fc4b49116> in <module>
     10 # test a single image and show the results
     11 img = 'test.jpg'  # or img = mmcv.imread(img), which will only load it once
---> 12 result = inference_detector(model, img)

~/Kaggle/open_images_2019_object_detection/mmdetection/mmdet/apis/inference.py in inference_detector(model, img)
     75     # prepare data
     76     data = dict(img=img)
---> 77     data = test_pipeline(data)
     78     data = scatter(collate([data], samples_per_gpu=1), [device])[0]
     79     # forward the model

~/Kaggle/open_images_2019_object_detection/mmdetection/mmdet/datasets/pipelines/compose.py in __call__(self, data)
     22     def __call__(self, data):
     23         for t in self.transforms:
---> 24             data = t(data)
     25             if data is None:
     26                 return None

~/Kaggle/open_images_2019_object_detection/mmdetection/mmdet/datasets/pipelines/test_aug.py in __call__(self, results)
     23                 _results['scale'] = scale
     24                 _results['flip'] = flip
---> 25                 data = self.transforms(_results)
     26                 aug_data.append(data)
     27         # list of dict to dict of list

~/Kaggle/open_images_2019_object_detection/mmdetection/mmdet/datasets/pipelines/compose.py in __call__(self, data)
     22     def __call__(self, data):
     23         for t in self.transforms:
---> 24             data = t(data)
     25             if data is None:
     26                 return None

~/Kaggle/open_images_2019_object_detection/mmdetection/mmdet/datasets/pipelines/formating.py in __call__(self, results)
    147         img_meta = {}
    148         for key in self.meta_keys:
--> 149             img_meta[key] = results[key]
    150         data['img_meta'] = DC(img_meta, cpu_only=True)
    151         for key in self.keys:

KeyError: 'filename'

Any idea what may cause this?
Thanks!

Thanks for report! It should be fixed in #1255.

yup, it works now!
Thanks!


lib.equal can compare cdata

Cdata values are equal if they have the same size and their bytes are
the same.

Cool! Two things come to my mind:

The documentation of lib.equal should probably say what types it supports to make more prominent that this feature exist. E.g. I would not expect it.
Extending the unit tests of lib.equal to test this case would not hurt, even though as is the code looks trivial.

I merged this as is, but if you decide to append anything let me know and I will merge the new commits.


Add vm.max_map_count to startup checks

Problem Statement
CrateDB has a user friendly feature where it will check various ulimit settings and log an error if they are not changed to meaningful scalable database-in-production values. Recently we had a case where we would hit failures due to too low vm.max_map_count. For some reason this wasn't caught in the startup checks.
Possible Solutions
Add vm.max_map_count to the startup checks already done to other ulimit or other configuration.
Considered Alternatives
No response

It's already part of the startup checks:
https://github.com/crate/crate/blob/299f276f541e498d44d28f8504ac82b796554f40/server/src/main/java/org/elasticsearch/bootstrap/BootstrapChecks.java#L398-L418
https://cratedb.com/docs/guide/admin/bootstrap-checks.html

Also noting while waiting for response to the previous: We also at some point suspected vm.overcommit_memory to be the culprit, but concluded it was not. Just noting it for the record. (Given that map_max_count was already checked...)

what is our max file size for the lucene index files? It seems like we are trying to ensure a node can hold and mmap enough files so that 4GB * "enough files" = about 10 TB? (Enough files = 262144).

The number of mappings depends on the number of segments and their size.
Since Lucene 9.10 it mmap's Lucene indexes in chunks of 16 GB (before it was 1 GB).
So in an ideal scenario:
>>> 262144 * 16GB -> TB

  262144 × 16 GB ➞ TB

   = 4194.3 TB

Caveat that you need to subtract quite a bit from that for other files, and more importantly because not all segments will have their max sizes depending on how merges are going on the system.

IIRC because they had created completely new installs, it was set to the system default of 65530; they had updated the value to 262144 in the various conf files but hadn't restarted the node, so the new value hadn't taken.  Possibly this means that /proc/sys/vm/max_map_count was reporting the new version, so the bootstrap check didn't fail?

chunks of 16 GB (before it was 1 GB).

Small correction, GiB not GB.
>>> 262144 * 16GiB -> TB

  262144 × 16 GiB ➞ TB

   = 4503.6 TB

they had updated the value to 262144 in the various conf files but hadn't restarted the node, so the new value hadn't taken. Possibly this means that /proc/sys/vm/max_map_count was reporting the new version, so the bootstrap check didn't fail?

If it was changed via sysctl -w vm.max_map_count=262144 it should take immediate effect, no reboot required.
And afaik /proc/sys/vm/max_map_count shows the currently active value, not a configured but unapplied value.


Unable to find "The Devil"

Minecraft 1.18.2
TarotCards 0.71-Alpha
I'm using the lootr mod, so there have been several opportunities on my server for all seven of us to find it, but no luck so far (we have multiple of each of the other cards).

https://github.com/shiroroku/TarotCards/commit/8528fb66b8f1e5625e72754c4a2a7a83c97b84cd


Improve and simplify metadata filtering.

Get the value from the metadata hash only once instead of
multiple times using metadata[key].
Try === method instead of treating regular expressions
as special.

Nice!


Can't load DOM definitions on playground

@DanielRosenwasser

TypeScript Version:  3.7.x-dev.201xxxxx

Search Terms:
Code
Uncaught (in promise) Error: Could not find source file: 'file:///output.js'.
    at g (tsWorker.js:21)
    at Object.getSyntacticDiagnostics (tsWorker.js:21)
    at e.getSyntacticDiagnostics (tsWorker.js:21)
    at t.fmr (workerMain.js:159)
    at e._handleMessage (workerMain.js:99)
    at Object.handleMessage (workerMain.js:99)
    at e._handleMessage (workerMain.js:97)
    at e.handleMessage (workerMain.js:96)
    at e.onmessage (workerMain.js:99)
    at self.onmessage (workerMain.js:159)

Expected behavior:
Actual behavior:
Playground Link: http://www.typescriptlang.org/play/index.html?ts=3.9.0-dev.20200219#code/CYUwxgNghgTiAEA3W8oC54DkD2oDcQA
Related Issues:

@DanielRosenwasser @RyanCavanaugh What are you doing


Client Allocation Request for: Chengdu Xingshuo Technology Co., Ltd.

Client Allocation Questions
Core Information

Name: Chengdu Xingshuo Technology Co., Ltd.
Website / Social Media: https://www.sinso.io/
Region: Greater China
DataCap Requested: 5TiB
Addresses to be Notarized: f12m4wzu4ynkpilkh5bv4zaadigmr6hml4zg46dhq
Notary Requested: philippbanhardt

@sinso2021-io Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Closing - dup of https://github.com/filecoin-project/filecoin-plus-client-onboarding/issues/491


Only content trans

add 10 api translation
only translate the content. I don't know whether the translation is accurate.
the format will be tackled tomorrow Nov.12

Looks like something wrong with this file, please check

close via #338


import { Explore } from 'components' not working but with './components';

I think i am missing something related to webpack. A lot of "import" requires to prepend './'.
please help.

@SheikhG1900 How your file structure looks like? And from which file that you are trying import that component?
If you modified the webpack config, sharing it might help.

@SheikhG1900 If you modified src/components/index.js file, can post the modifed code? Because sometime, I also encounter that but mostly due to the index.js file not exporting the components correctly.

I didn't modify anything. I just tried to run it by following the instruction given in Readme file. Exception is throwing at following location.
https://github.com/xkawi/react-universal-saga-modular/blob/8d74e6bc3b9985552c558725aca3cac0221474c4/src/containers/App/App.js#L4.
Same code is written in react-universal-saga project. It is working fine there. Really strange :(
https://github.com/xkawi/react-universal-saga/blob/ab49f28b4cb772ee19b59b9fd2a74ccc950dc624/src/containers/App/App.js#L4

closing this for now, as can't replicate or at least need more information. feel free to open it again if it's not resolved yet.

I am also having this issue. I have modified the webpack scripts, or the default seed module structure or imports. The issue is not present when running as admin, but that is not an option for a hosted solution. I have ensure the user running the process has full access rights to the directory, even after running build and run seperately. This was reproduces on 2 individual ubuntu 16.04 LTS EC@ boxes hosted on Amazon. Issue doesn't occur in my local development environment.


2018-01-22 13:17:18.397760: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/encdec_attention/layer_prepostprocess/layer_norm/layer_norm_bias/Adam not found in checkpoint
2018-01-22 13:17:18.399169: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/encdec_attention/layer_prepostprocess/layer_norm/layer_norm_bias/Adam_1 not found in checkpoint
2018-01-22 13:17:18.399926: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/symbol_modality_8044_512/shared/weights_13/Adam_1 not found in checkpoint
2018-01-22 13:17:18.401000: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/encdec_attention/layer_prepostprocess/layer_norm/layer_norm_scale/Adam not found in checkpoint
2018-01-22 13:17:18.402758: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/encdec_attention/layer_prepostprocess/layer_norm/layer_norm_scale/Adam_1 not found in checkpoint
2018-01-22 13:17:18.405682: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/encdec_attention/multihead_attention/k/kernel/Adam not found in checkpoint
2018-01-22 13:17:18.407768: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/symbol_modality_8044_512/shared/weights_13/Adam not found in checkpoint
2018-01-22 13:17:18.408609: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/encdec_attention/multihead_attention/k/kernel/Adam_1 not found in checkpoint
2018-01-22 13:17:18.409439: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/encdec_attention/multihead_attention/output_transform/kernel/Adam not found in checkpoint
2018-01-22 13:17:18.411014: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/encdec_attention/multihead_attention/output_transform/kernel/Adam_1 not found in checkpoint
2018-01-22 13:17:18.412415: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/symbol_modality_8044_512/shared/weights_12/Adam_1 not found in checkpoint
2018-01-22 13:17:18.412656: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/encdec_attention/multihead_attention/q/kernel/Adam not found in checkpoint
2018-01-22 13:17:18.418792: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/encdec_attention/multihead_attention/q/kernel/Adam_1 not found in checkpoint
2018-01-22 13:17:18.419662: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/encdec_attention/multihead_attention/v/kernel/Adam not found in checkpoint
2018-01-22 13:17:18.421113: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/symbol_modality_8044_512/shared/weights_12/Adam not found in checkpoint
2018-01-22 13:17:18.421127: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/encdec_attention/multihead_attention/v/kernel/Adam_1 not found in checkpoint
2018-01-22 13:17:18.424391: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/ffn/conv1/bias/Adam not found in checkpoint
2018-01-22 13:17:18.425134: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/ffn/conv1/bias/Adam_1 not found in checkpoint
2018-01-22 13:17:18.428854: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/symbol_modality_8044_512/shared/weights_11/Adam_1 not found in checkpoint
2018-01-22 13:17:18.431078: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/ffn/conv1/kernel/Adam not found in checkpoint
2018-01-22 13:17:18.433034: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/ffn/conv1/kernel/Adam_1 not found in checkpoint
2018-01-22 13:17:18.433147: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/ffn/conv2/bias/Adam not found in checkpoint
2018-01-22 13:17:18.439181: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/symbol_modality_8044_512/shared/weights_11/Adam not found in checkpoint
2018-01-22 13:17:18.440295: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/ffn/conv2/bias/Adam_1 not found in checkpoint
2018-01-22 13:17:18.441708: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/ffn/conv2/kernel/Adam_1 not found in checkpoint
2018-01-22 13:17:18.442132: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/ffn/conv2/kernel/Adam not found in checkpoint
2018-01-22 13:17:18.445227: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/symbol_modality_8044_512/shared/weights_10/Adam_1 not found in checkpoint
2018-01-22 13:17:18.446008: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/ffn/layer_prepostprocess/layer_norm/layer_norm_bias/Adam not found in checkpoint
2018-01-22 13:17:18.449370: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/ffn/layer_prepostprocess/layer_norm/layer_norm_bias/Adam_1 not found in checkpoint
2018-01-22 13:17:18.450139: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/ffn/layer_prepostprocess/layer_norm/layer_norm_scale/Adam not found in checkpoint
2018-01-22 13:17:18.452332: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_3/encdec_attention/multihead_attention/v/kernel/Adam not found in checkpoint
2018-01-22 13:17:18.455035: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/ffn/layer_prepostprocess/layer_norm/layer_norm_scale/Adam_1 not found in checkpoint
2018-01-22 13:17:18.455962: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/self_attention/layer_prepostprocess/layer_norm/layer_norm_bias/Adam not found in checkpoint
2018-01-22 13:17:18.456449: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/self_attention/layer_prepostprocess/layer_norm/layer_norm_bias/Adam_1 not found in checkpoint
2018-01-22 13:17:18.460374: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_3/encdec_attention/multihead_attention/q/kernel/Adam_1 not found in checkpoint
2018-01-22 13:17:18.461379: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/self_attention/layer_prepostprocess/layer_norm/layer_norm_scale/Adam not found in checkpoint
2018-01-22 13:17:18.462082: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/self_attention/layer_prepostprocess/layer_norm/layer_norm_scale/Adam_1 not found in checkpoint
2018-01-22 13:17:18.462687: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/self_attention/multihead_attention/k/kernel/Adam not found in checkpoint
2018-01-22 13:17:18.467189: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/self_attention/multihead_attention/k/kernel/Adam_1 not found in checkpoint
2018-01-22 13:17:18.468006: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_3/encdec_attention/multihead_attention/q/kernel/Adam not found in checkpoint
2018-01-22 13:17:18.468128: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/self_attention/multihead_attention/output_transform/kernel/Adam not found in checkpoint
2018-01-22 13:17:18.469620: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/self_attention/multihead_attention/output_transform/kernel/Adam_1 not found in checkpoint
2018-01-22 13:17:18.471352: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/self_attention/multihead_attention/q/kernel/Adam not found in checkpoint
2018-01-22 13:17:18.472990: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/self_attention/multihead_attention/q/kernel/Adam_1 not found in checkpoint
2018-01-22 13:17:18.472990: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_3/encdec_attention/multihead_attention/output_transform/kernel/Adam_1 not found in checkpoint
2018-01-22 13:17:18.478606: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/self_attention/multihead_attention/v/kernel/Adam not found in checkpoint
2018-01-22 13:17:18.479917: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_2/self_attention/multihead_attention/v/kernel/Adam_1 not found in checkpoint
2018-01-22 13:17:18.480992: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_3/encdec_attention/multihead_attention/output_transform/kernel/Adam not found in checkpoint
2018-01-22 13:17:18.481232: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_3/encdec_attention/layer_prepostprocess/layer_norm/layer_norm_bias/Adam not found in checkpoint
2018-01-22 13:17:18.484182: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_3/encdec_attention/layer_prepostprocess/layer_norm/layer_norm_bias/Adam_1 not found in checkpoint
2018-01-22 13:17:18.488938: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_3/encdec_attention/layer_prepostprocess/layer_norm/layer_norm_scale/Adam not found in checkpoint
2018-01-22 13:17:18.491249: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_3/encdec_attention/multihead_attention/k/kernel/Adam_1 not found in checkpoint
2018-01-22 13:17:18.491249: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_3/encdec_attention/layer_prepostprocess/layer_norm/layer_norm_scale/Adam_1 not found in checkpoint
2018-01-22 13:17:18.492776: W C:\tf_jenkins\workspace\tf-nightly-windows\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1198] Not found: Key training/transformer/body/decoder/layer_3/encdec_attention/multihead_attention/k/kernel/Adam not found in checkpoint
Traceback (most recent call last):
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\client\session.py", line 1350, in _do_call
    return fn(*args)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\client\session.py", line 1329, in _run_fn
    status, run_metadata)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\framework\errors_impl.py", line 473, in __exit__
    c_api.TF_GetCode(self.status.status))
tensorflow.python.framework.errors_impl.NotFoundError: Key training/transformer/body/decoder/layer_4/ffn/conv2/bias/Adam not found in checkpoint
         [[Node: save/RestoreV2_167 = RestoreV2[dtypes=[DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2_167/tensor_names, save/RestoreV2_167/shape_and_slices)]]

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\Lib\site-packages\tensor2tensor\bin\t2t_trainer.py", line 241, in <module>
    tf.app.run()
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\platform\app.py", line 124, in run
    _sys.exit(main(argv))
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\Lib\site-packages\tensor2tensor\bin\t2t_trainer.py", line 237, in main
    execute_schedule(exp)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\Lib\site-packages\tensor2tensor\bin\t2t_trainer.py", line 217, in execute_schedule
    getattr(exp, FLAGS.schedule)()
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\contrib\framework\python\framework\experimental.py", line 64, in new_func
    return func(*args, **kwargs)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\contrib\learn\python\learn\experiment.py", line 770, in continuous_train_and_eval
    saving_listeners=self._saving_listeners)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\contrib\learn\python\learn\experiment.py", line 868, in _call_train
    saving_listeners=saving_listeners)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\estimator\estimator.py", line 324, in train
    loss = self._train_model(input_fn, hooks, saving_listeners)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\estimator\estimator.py", line 849, in _train_model
    log_step_count_steps=self._config.log_step_count_steps) as mon_sess:
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\monitored_session.py", line 381, in MonitoredTrainingSession
    stop_grace_period_secs=stop_grace_period_secs)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\monitored_session.py", line 788, in __init__
    stop_grace_period_secs=stop_grace_period_secs)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\monitored_session.py", line 512, in __init__
    self._sess = _RecoverableSession(self._coordinated_creator)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\monitored_session.py", line 973, in __init__
    _WrappedSession.__init__(self, self._create_session())
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\monitored_session.py", line 978, in _create_session
    return self._sess_creator.create_session()
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\monitored_session.py", line 669, in create_session
    self.tf_sess = self._session_creator.create_session()
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\monitored_session.py", line 441, in create_session
    init_fn=self._scaffold.init_fn)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\session_manager.py", line 273, in prepare_session
    config=config)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\session_manager.py", line 205, in _restore_checkpoint
    saver.restore(sess, ckpt.model_checkpoint_path)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\saver.py", line 1750, in restore
    {self.saver_def.filename_tensor_name: save_path})
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\client\session.py", line 895, in run
    run_metadata_ptr)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\client\session.py", line 1128, in _run
    feed_dict_tensor, options, run_metadata)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\client\session.py", line 1344, in _do_run
    options, run_metadata)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\client\session.py", line 1363, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.NotFoundError: Key training/transformer/body/decoder/layer_4/ffn/conv2/bias/Adam not found in checkpoint
         [[Node: save/RestoreV2_167 = RestoreV2[dtypes=[DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2_167/tensor_names, save/RestoreV2_167/shape_and_slices)]]

Caused by op 'save/RestoreV2_167', defined at:
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\Lib\site-packages\tensor2tensor\bin\t2t_trainer.py", line 241, in <module>
    tf.app.run()
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\platform\app.py", line 124, in run
    _sys.exit(main(argv))
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\Lib\site-packages\tensor2tensor\bin\t2t_trainer.py", line 237, in main
    execute_schedule(exp)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\Lib\site-packages\tensor2tensor\bin\t2t_trainer.py", line 217, in execute_schedule
    getattr(exp, FLAGS.schedule)()
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\contrib\framework\python\framework\experimental.py", line 64, in new_func
    return func(*args, **kwargs)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\contrib\learn\python\learn\experiment.py", line 770, in continuous_train_and_eval
    saving_listeners=self._saving_listeners)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\contrib\learn\python\learn\experiment.py", line 868, in _call_train
    saving_listeners=saving_listeners)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\estimator\estimator.py", line 324, in train
    loss = self._train_model(input_fn, hooks, saving_listeners)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\estimator\estimator.py", line 849, in _train_model
    log_step_count_steps=self._config.log_step_count_steps) as mon_sess:
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\monitored_session.py", line 381, in MonitoredTrainingSession
    stop_grace_period_secs=stop_grace_period_secs)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\monitored_session.py", line 788, in __init__
    stop_grace_period_secs=stop_grace_period_secs)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\monitored_session.py", line 512, in __init__
    self._sess = _RecoverableSession(self._coordinated_creator)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\monitored_session.py", line 973, in __init__
    _WrappedSession.__init__(self, self._create_session())
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\monitored_session.py", line 978, in _create_session
    return self._sess_creator.create_session()
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\monitored_session.py", line 669, in create_session
    self.tf_sess = self._session_creator.create_session()
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\monitored_session.py", line 432, in create_session
    self._scaffold.finalize()
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\monitored_session.py", line 212, in finalize
    self._saver.build()
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\saver.py", line 1297, in build
    self._build(self._filename, build_save=True, build_restore=True)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\saver.py", line 1334, in _build
    build_save=build_save, build_restore=build_restore)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\saver.py", line 789, in _build_internal
    restore_sequentially, reshape)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\saver.py", line 501, in _AddShardedRestoreOps
    name="restore_shard"))
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\saver.py", line 448, in _AddRestoreOps
    restore_sequentially)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\saver.py", line 269, in bulk_restore
    self.restore_op(filename_tensor, saveable, preferred_shard))
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\training\saver.py", line 296, in restore_op
    [spec.tensor.dtype])[0])
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\ops\gen_io_ops.py", line 1111, in restore_v2
    shape_and_slices=shape_and_slices, dtypes=dtypes, name=name)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\framework\op_def_library.py", line 787, in _apply_op_helper
    op_def=op_def)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\framework\ops.py", line 3172, in create_op
    op_def=op_def)
  File "C:\Users\Artem\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\framework\ops.py", line 1617, in __init__
    self._traceback = self._graph._extract_stack()  # pylint: disable=protected-access

NotFoundError (see above for traceback): Key training/transformer/body/decoder/layer_4/ffn/conv2/bias/Adam not found in checkpoint
         [[Node: save/RestoreV2_167 = RestoreV2[dtypes=[DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2_167/tensor_names, save/RestoreV2_167/shape_and_slices)]]```

No, I tried with the same versions. I just ran, stopped and ran again without any delays between these actions.
Anyway, now with current versions installed by pip it works great. So it is not actual anymore.


Remove leftover .tmp folders after backup/snapshot

Closes #16289
When creating a backup on an installation with a large database the leftover .tmp folders created during the backup/snapshot will fill up the disk. See #16289 for details.
This PR will cleanup the leftover .tmp folders if there is no concurrent backup/snapshot running.

[ ] CHANGELOG.md updated with a link to the PR (not the Issue)
[x] Well-formatted commit messages
[x] Rebased/mergeable
[x] Tests pass
[ ] http/swagger.yml updated (if modified Go structs or API)
[x] Documentation updated or issue created (provide link to issue/pr)
[x] Signed CLA (if not already signed)

Sorry wrong branch


Cli exit failure

Pull Request Description
CLI will exit with a non-zero code on compile errors
Important Notes
I mean... see the diff.
Checklist
Please include the following checklist in your PR:

[x] The documentation has been updated if necessary.
[x] The code conforms to the Luna Style Guide.
[x] The code has been tested where possible.

Fixes #398


A 2 byte Motorola signal that is signed is decoded wrong

We get a wrong value when decoding the raw can data.
Enclosed is a minified *.dbc file for 1 message only, and below you can find the simple steps to reproduce.
The problem is with this signal:
 SG_ signal_2 : 23|16@0- (0.1,0) [-300|600] "%" Vector__XXX
To prove the issue, the following commands are used in a Terminal session on a MacBook with Python 3.9.7 installed:

Install latest version of cantools lib: python3 -m pip install cantools==39.4.2
Start a python session: python3
Import lib: import cantools
Add DBC file: db = cantools.database.load_file('candb.dbc')
Decode the raw bytes, as has been observed with a CanKing from Krasser: db.decode_message(42, bytes.fromhex("0000803200000000"))

Overview of the above with the returned signal values:
>>> import cantools
>>> db = cantools.database.load_file('candb.dbc')
>>> db.decode_message(42, bytes.fromhex("0000803200000000"))
{'signal_1': 0.0, 'signal_2': -3271.8, 'signal_3': 0.65, 'signal_4': 0.65, 'signal_5': 'No Errors', 'signal_6': 'No Errors'}

The problem is with signal_2 that returns a value of -3271.8 ❌
The raw 2 byte value 0x8032 should return -5.0, as explained:
The DBC specifies that it is a signed signal. This means that if the MSB of the raw data is 1, it is a negative value.
0x8032 in binary is:

The MSB (bit 15) is indeed high, so this is a negative value.
The remaining 15 bits  represent decimal value 50 (0x32).
According to the DBC file, there is a multiplier of 0.1 and 0 offset. Hence the value should be -50 * 0.1 = -5.0  ⚠
This has been also verified with CAN monitors, which show a value of -5.0 ✅
Why is the library showing a decoded value -3271.8 ❓

Your explanation is wrong. Signed values are stored in 2s complement. If you consider this, the decode is correct.

It is also intuitive that the result must be very negative as negative values closer to 0 would have more of their more significant bits set and not just the 0x80 bit.

@juleq Thank you for your prompt response. I have analysed this more and I must admit that you are correct. Thanks for pointing this out. I'm fine with closing this issue.


Typescript error TS5055

TypeScript Version:  nightly (2.1.0-dev.20161027)
Simulation
Create a project with the following configuration:
{
  "compilerOptions": {
    "module": "commonjs",
    "target": "es5",
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "noImplicitAny": true,
    "noUnusedParameters": true,
    "noUnusedLocals": true,
    "noEmitOnError": true,
    "skipLibCheck": true,
    "declaration": true,
    "sourceMap": true,
    "outDir": "out/",
    "rootDir": "src",
    "baseUrl": "src",
    "moduleResolution": "node",
    "lib": [
      "es5",
      "es2015",
      "dom"
    ]
  },
  "exclude": [
    "node_modules"
  ]
}

The directory structure should be:

project

src

index.ts
hello.ts

out

The content of the hello.ts could be:
export function hello(name: string) {
  return `Hello, ${name}`;
}

The index.ts should re-export the hello module contents:
export * from "./hello";

After that, compile twice using the vscode or the tsc:

tsc -p .
tsc -p .

Expected behavior:
Compile and produce again the js and the definitions.
Actual behavior:
In the first compilation, it will compile normally. But at the second one, it will file with a message like `error TS5055: Cannot write file '.../hello.d.ts' because it would overwrite input file.

Just to point out, it works with the current production release version.

add your  "outDir" to your exclude list. i.e.:   "exclude": ["node_modules", "out"]

Ohhh man, what a mistake! Thanks! ;)


no configuration possible, File index.html not found

Describe the bug
"Adapterkonfiguration: sma-em.0"
File index.html not found
i have installed the Adapter, but i can't reach the configuration.
Versions:

Adapter version: 0.6.1-beta.0
JS-Controller version: 3.1.6
Node version:  v12.20.1
Operating system: ioBroker in Docker Synology DSM

@Sniplow
Did you install 0.6.1-beta.0 over an existing previous version? If so, you could try uninstalling the adapter completely and reinstall 0.6.1-beta.0. It would be helpful if you would provide a screenshot  of the installation and of the iobroker log.

i had no installed previous version, but i tried one in the past.
i have already tried to reinstall the Adapter last time, but nothing has changed.
i have just reinstalled the adapter for the log, and now it works.
Thank You!


Relative Date filters in Tableau fail

Issue
Cannot filter relative date from Tableau on a date type field.
Steps To Repeat

From Tableau Connect to CH data source with a date column
Drag the date field to filters, select relative date, last X month, click Ok

Error message in Tableau
HTTP status code: 404 Received error: Code: 50, e.displayText() = DB::Exception: Unknown data type family: TIMESTAMP, e.what() = DB::Exception
SELECT SUM(`a`.`val`) AS `sum_val_ok`
FROM `a`
WHERE ((CAST(`a`.`_date` AS TIMESTAMP) >= {ts '2018-05-01 00:00:00'}) AND (CAST(`a`.`_date` AS TIMESTAMP) < {ts '2018-11-01 00:00:00'}))
HAVING (COUNT(1) > 0)

Software

Tableau Desktop 2018.1.3 (64bit)
Clickhouse db version: 18.12.17 revision 54407
Clickhouse ODBC driver downloaded latest on 12th of July, 2018

Should be fixed in server : https://github.com/yandex/ClickHouse/pull/3390


fix: make policy-server binary auditable

When creating the policy-server image, build using cargo auditable.
This will enrich the policy-server binary with its bill of material.
Fixes https://github.com/kubewarden/policy-server/issues/971
Testing
I tested the fix by doing a local build of the policy-server image and then
running syft against the image.
The output I got was complete.

I changed the code to not use the alias, it turned out this is not needed if you call cargo auditable install


fix: all backlog fixes for ads v2

Description

Text shift

https://github.com/appsmithorg/appsmith/assets/13763558/cbc1e668-83db-4b52-9691-67ce0f2c8e15

Evaluated Value popup copy button compressed

https://github.com/appsmithorg/appsmith/assets/13763558/6cdbd0af-a509-4df2-8fe5-128716ef9013

Select placeholder in git merge

https://github.com/appsmithorg/appsmith/assets/13763558/a78fc5b2-eebb-4e53-834c-757102bb3f81

Replace gif in Pagination

https://github.com/appsmithorg/appsmith/assets/13763558/2e1d3962-24cf-40a4-88ff-718614e87c87

Toast stays put on hover

fixed by https://github.com/appsmithorg/design-system/pull/492 on design-system
https://github.com/appsmithorg/appsmith/assets/13763558/f562f151-f569-46a7-8cc2-1d2b48d332ea

spacing between widget name and entity name

before:

after:

Type of change

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/build-deploy-preview skip-tests=true env=release

/ok-to-test

/build-deploy-preview

/build-deploy-preview env=release skip-tests=true

/build-deploy-preview env=release skip-tests=true

Tested this PR:

Issue 1 - Still exists: https://www.loom.com/share/f680a3c9eb894bfb8710e8c3e4764ea6
Isue 2 - Fixed

https://github.com/appsmithorg/appsmith/assets/39921438/599d8c96-800a-4a22-bf8c-b90195983b56

Issue 3 - Fixed

Issue 4 - Fixed

Issue 5 - Fixed

https://github.com/appsmithorg/appsmith/assets/39921438/b2506615-60d1-473b-85c8-9233a0ac1255

Issue 6 - Fixed

/ok-to-test

/ok-to-test

Issue 1 - Still exists: https://www.loom.com/share/f680a3c9eb894bfb8710e8c3e4764ea6

This is a different issue because it's for text area - can you please create a different issue and I'll pick it up? And we can merge this one?

Created a bug: https://github.com/appsmithorg/appsmith/issues/24338 for the same.
Rest looks good.


Cursor Placement and Node Placement don't work well together

https://drive.google.com/file/d/1AWb27xrliuGa6JqOdHvSro59sNsdmjqC/view?usp=sharing
PFA the link to the video demonstrating cursor placement and placing a 3D model with it. I have a use case of placing a 3D model and capturing the object within it. However, when I try to place the 3D model on a real life object, the cursor doesn't allow that and most of the times, the 3D object we placed firstly, moves along with the cursor.
Please fix this bug, or direct me where we could fix this and I could help with a pull request for the same.

Thanks for the quick reply @ThomasGorisse , updated the link.

https://drive.google.com/file/d/1w737XAcX4YuDyEdrAZOmjrKQZEC1FwO1/view?usp=sharing
@ThomasGorisse and anyone looking at this, I have made this iOS app which successfully fulfils my usecase. However, making the same on Android using your library is buggy. But this library is a gem, I want to make my use case possible with this. Please let me know if this can be done, I am ready to contribute and make it possible.

For sure we need contributions and for sure we are not Apple. Just people working FREELY days and nights on it.
If you have 1 million dollars, we can do the same thing as Apple by hiring developers but please don't say that our framework is buggy.
If you have issues with it, first, this can be because of a wrong usage and secondly you are as a developer as we are so yes PR are welcome.

@akshaaatt
When the cursor is red it means that no trackable object is hit. At some point the device loses AR tracking completely. Try moving further away from the table so that the device can see more features and where is more movement in space.

The testing I was performing was done on a Redmi Note 9 Pro, hence the work seemed this way. Recently tested things on a Samsung device and everything works perfectly! Wow.
Thanks for looking into this but it seems to have been a device issue. Closing this issue.

Thanks for the report.
We will be happy to have some help if you want to contribute in code.


EDU548 - Show overlay on chapter end

Closes https://educandu.atlassian.net/browse/EDU-548

Very nice and short solution :heart:


Move cleanup script to use local CLI

As of Terraform 0.13, we can no longer access any Terraform variables during the destroy-time provisioner (see #55). We are currently using this to SSH into the management node to call a clean-up script to delete hanging nodes.
This PR changes the destroy provisioner to use the cloud CLI locally to delete hanging resources (via a script called cleanup.sh) instead of SSHing to the management node.
The potential issue with this is that we have to assume that the locally-running CLI's default configuration has the permission to delete the resources. There seems to be no way to pass from Terraform into the script, which credentials it is using to do its destruction.
On Google we can pull down the cluster-internal service account with gcloud iam service-accounts keys create, but even this depends on the default config being able to pull down that SA.
If the cleanup.sh script fails to destroy the resources, then the Terraform destroy will fail with a message. This means that the error should not go unnoticed, we will just have to make sure that we document how to solve the problem.
Pros:

Allows us to update to latest version of Terraform
We don't have to store a private key with admin permissions with the Terraform state

Cons:

The credentials for the cloud CLI (aws/gcloud/oci) must be set up correctly at destroy-time. Terraform can't guarantee this

Mitigations:

Using an (un)installer script would allow us to ensure that the credentials are set up correctly. All cloud providers not have web shells so we can expect a consistent interface.

Does any one have any thoughts on this solution?

I'm going to go ahead with this change. It's needed in order to use any modern version of Terraform. I think we can manage the clean up, either via the changes in this PR, or some other future method.


evaluation metrics

Hello,
Thanks for sharing your code! Could you share the code for calculating Executability and Correctness as well?
Thank you!

Thanks for the interest in the project! Executability is calculated by Evolving Graph Simulator of the VirtualHome Environment. We plan to release the interface code soon. Correctness is evaluated by humans in the form of questionnaires, and there isn't code for it.

Thank you very much!

Hello, is there any plan to release the interface code for evaluation? Thank you!

Hi is there any plan to release the code?

Thanks for the interest and apologies that we haven't got to do the full cleaning of the code to release it. If you would still prefer a version anyway, please reach out to me via email<EMAIL_ADDRESS>and I'm happy to share the code.


ValidatedRequest acquires first Request object which makes impossible to perform multiple different GET queries in Tests

Test method:
	public function testAvailability() {
		$response1 = $this->get('/api/v1/users');
		$response1->assertStatus(Response::HTTP_OK);

		$response2 = $this->get('/api/v1/candidates');
		$response2->assertStatus(Response::HTTP_OK);
	}

Both response1 and response2 returns user list which is not expected. Response2 must return candidate list.
I walked by stack trace. For response1 the $router parameter in ControllerDispatcher::dispatch method has uri = "api/v1/users". For response2 it has uri = "api/v1/candidates". But when program goes to JsonApiController::index, the $request parameter contains nested request object with $request->request->request->requestUri = "/api/v1/users".

Found the reason in \CloudCreativity\LaravelJsonApi\ServiceProvider::bindInboundRequest method:
   protected function bindInboundRequest()
    {
        $this->app->singleton(RequestInterface::class, IlluminateRequest::class); // IT IS SINGLETON
        $this->app->alias(RequestInterface::class, 'json-api.request');

Changed to 'bind' and it solved my problem.

Hm, seems like singleton is used for performance reason. Without singleton the IlluminateRequest object instantiated 5 times to 1 request

Workaround is rebind classes in startUp method
$this->app->bind(RequestInterface::class, IlluminateRequest::class);

The framework boots only once per test so you should make only one request per test. This is not a bug or issue of this package nor it's an issue of the framework itself. See https://github.com/laravel/framework/issues/23996 and https://github.com/laravel/framework/issues/24155 etc.

Thanks! This issue can be closed.

Yes, this is a problem with your test rather than a bug in this package. In a real HTTP request, the application is booted and torn down in the one request. Therefore tests that run multiple requests in one test are not realistic and risk state bleeding from one request to the next, which would not be the case for real HTTP requests.


v0.6.0-rc2 User Folder Share Still Not Working on Linux

Tested on v0.6.0-rc2 shared user folder still not working on Linux using the local Virtualbox driver.
I've gone through some of the older issues for this and it appears a fix should have been merged by now.
Maybe I missed something?

Hm, it should work.  Maybe you have an older version of boot2docker.iso in the cache?  If it's not a recent one it won't work.

If I delete ~/.docker directory v0.6.0-rc2 downloads boot2docker from https://github.com/boot2docker/boot2docker/releases/download/v1.9.1/boot2docker.iso
$docker-machine create -d virtualbox ehlo
$docker-machine ssh ehlo ls /home
docker

There is no /home/atomi folder :(

OK thanks.  Do you see the share as created in the VirtualBox GUI?

cc @chantra Can you please take a look?

Here's the Shared Folders settings:

Argh, I thought the relevant modification had been merged into boot2docker, but it looks like it hasn't yet: https://github.com/boot2docker/boot2docker/pull/1086

In the meanwhile, you could build your own boot2docker.iso using that branch and use --virtualbox-boot2docker-url, then shared folders should work like a charm on Linux.

Thanks @nathanleclaire - I'll build boot2docker locally for the time being as I doubt the PR will make it to 1.10.

@nathanleclaire @atomi yeah, until boot2docker/boot2docker#1086 get pulled in, this will not work.


Support suffixes for ReplaceRewriter

The ReplaceRewriter should support suffixes for replacements. Suffixes can be indicated by a wildcard at the beginning of a term, e. g.
*phones => phone
Use cases:

Compensate limitations of stemmers due to language dependencies, e. g. *kameras => kamera
Facilitate the definition of subsequently applied synonyms, e. g *phones => phone

The ReplaceRewriter will replace the matched suffix (sub)string by the sequence on the right side. In order to avoid abusal usage leading to ambiguous behavior, we could consider some limitations for the usage of the suffixes.
As I currently see no use case for using those suffix definitions within sequences of terms (e. g. apple *phones => apple $1phone or the like), using wildcards only will be allowed for single term input definitions.

Hi @JohannesDaniel,
Sounds good to me! If you are looking for a way to implement the lookup for the suffixes: TrieMap can handle prefix lookups (phone*). So maybe you could just use a second TrieMap for the suffix lookup but reverse the characters (*phones  - put into TrieMap as  senohp* and look up smartphones as senohptrams) - but probably you already knew this trick ;-)

I already did some tests here, I will either implement something like a ReversedCharSequence or ReversedTrieMap or both.

Implemented, PR #87


Razor intellisence not working in new module  because of Orchard.Framework.csproj not copied locally

To repro
Create a new module using codegen create module
Create a razor view file . Intellisense is not working
To fix
From references change the Orchard.Framework reference property "Copy Local" from false to true.
<ProjectReference Include="..\..\..\Orchard\Orchard.Framework.csproj">
  <Project>{2D1D92BB-4555-4CBE-8D0E-63563D6CE4C6}</Project>
  <Name>Orchard.Framework</Name>
  <Private>True</Private>
</ProjectReference>

Now intellisence is restored.

Isn't only that you have to build the solution first? I think this is the case with Copy Local = true still.

Nope , Tried it.
Maybe if we change the web.config to point to correct base razor file it might work. Will have to try.
I like the fact the it has reduced the size of files with this setting, but not having  intellisence is bad.
Thanks.

Just to be clear, whats not working is the base orchard stuff for razor view.
For example writing:
Style.Include("mystyle") is not working.

I see. This is some serious problem then.

A solution to make it work is to  add in web.config of project which has  CopyLocal=false the
Orchard.Framework assembly reference as shown below.

Found the answer here.
http://stackoverflow.com/questions/4953330/razor-based-view-doesnt-see-referenced-assemblies
Maybe it would need to be done for Orchard.Core as well since it also has CopyLocal=False

That works.

I consider Copy Local to be extremely annoying feature for web projects and I always turn it off for all internal references in my Orchard modules. I welcomed change in 1.x that turned it off for Orchard.Core and Orchard.Framework, but I'd take it further and modify all core modules as well.
It's a small change to all web.configs (necessary only for intellisense), but huge reduction in size. There are hundreds of duplicates, just Orchard.Tokens.dll after publish has cca 28 duplicates scattered in different module bin folders. Why? Module dependency already ensures those assemblies are present in App_Data/Dependencies no?

I agree that we should apply the same changes for the most commonly used core modules such as Tokens and Forms as well to reduce the build output size even further.

I updated lmost all project references by setting CopyLocal=False, but I didn't see a huge gain in terms of smaller build output - only about 30 megabytes. Are you seeing something else?

Yes I do, hundreds of megs, have you deleted bin folders before rebuilding? Visual Studio doesn't clean it up automatically, I have created new issue for this #5272


Fixed link to apple touch icon

Should not be relative path

Are you certain? You could very well be right, but does this still work when you're on a subpage, and choose to bookmark the site?

The url of the icon is: http://www.php-fig.org/apple-touch-icon.png
So if you were on a subpage, you would need to reference this from the path relative to the root of the site.
Happy for you to wait for a second opinion, I created the PR because when I was on a sub page and clicked the link in the source I got a 404 :)

Oh my goodness, I misread this. I thought you were removing the slash, not adding it. My bad. Yes, this is totally correct.
@philsturgeon Please merge in good sir.

Thanks @simensen ;)

Not a problem, good work on the site - looks awesome


[$4000] Last message in the report shows for a brief moment when the keyboard opens while clicking on password text Input in password-protected pdf

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Sign in to NewExpensify Chrome on an Android or use Browserstack
Select a chat
Send a password protected pdf
Click on  password protected pdf
Click on blue hyperlink to "enter password"
As the keyboard slides up, you can see briefly the chat behind.

You can continue to reproduce this just by tapping outside of the password input and then tapping on the input again, making the keyboard slide out and in again.
Expected Result
last chat should not show when keyboard opens
Actual Result
last chat flashes for a very brief moment when keyboard opens
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ]  Android / Chrome
[ ]  iOS / native
[ ]  iOS / Safari
[ ]  MacOS / Chrome / Safari
[ ]  MacOS / Desktop

Version Number: 1.2.75-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/220753992-02b7f0d0-7939-46ab-84c1-53f9878eb6e9.mp4
https://user-images.githubusercontent.com/43996225/220754023-ad06ea87-35e4-41fa-8433-d962714baa78.mp4
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1676983368278249
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b4d787358ad1fd5f
Upwork Job ID:<PHONE_NUMBER>284430336
Last Price Increase: 2023-03-15

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

I'm not sure if this is something we want to fix now or put on hold as it's a pretty minor flicker and might be fixed with something else so going on right now (although I can't find any GHs that might relate). Adding Engineering label for a second opinion.

@kavimuru
Can you confirm that this is only on android?

Not to step in, but I could only reproduce this on Android/Chrome.
I've tried downloading the Android Beta URL into BrowserStack, but I can't get it to work, so I'm unsure about Android/Native.

@Christinadobrzyn could you do me a huge favor and get this re-assigned?
For next steps, I'd highly recommend seeing if this is an issue with the keyboard itself. And if there are other instances or past instances. It seems strange that it would happen here.

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

I reproduced this in Android native, didn't reproduce anywhere else.
hmmm, my theory: this is happening because the keyboard slides up taking some time, meanwhile, I'm guessing we adjust the pdf modal's height instantly, so there is a brief moment where there is a space between the pdf modal and the keyboard that is opening. This space allows you to see the screen behind, the chat.
I does look a bit weird, so I'll make it External in case a contributor finds an easy solution.

Job added to Upwork: https://www.upwork.com/jobs/~01b4d787358ad1fd5f

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

Current assignee @aldo-expensify is eligible for the External assigner, not assigning anyone new.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Modal does not fully cover the screen when keyboard opens.
What is the root cause of that problem?
The root cause of this issue is setting statusBarTranslucent prop of the Modal in AttachmentModal to false here.
What changes do you think we should make in order to solve the problem?

We can set statusBarTranslucent as true in all models where it is set as false. Doing this fixes this issue. However, it causes another issue. To fix this new issue, we can add a gap in the Modal content. This is currently being done for mobile web using the HeaderGap component. We can use a similar component on android as well.
What alternative solutions did you explore? (Optional)
None

Proposal
Please re-state the problem that we are trying to solve in this issue.
When we type in the password to open a password-protected PDF, the content behind the modal is briefly visible.
What is the root cause of that problem?
This happens due to a bug fix being done incorrectly.
The statusBarTranslucent when false makes the modal does not cover the screen completely when the keyboard is opening, causing the brief flicker where we can see the content behind it.
It's set to false only for the AttachmentModal due to this PR. The explanation for that is here.  Specifically we don't want the modal to go over the status bar in the AttachmentModal.
That fix is not fixing the root cause of the styling issue modal will go over the status bar. The root cause of it is that we're making the modal full screen, overlapping the status bar when statusBarTranslucent is true (in https://github.com/Expensify/App/blob/d5f4caa0aae0a3ab3e6242a810ffc4ec620f4453/src/components/Modal/BaseModal.js#L110) but we're not adding a proper safe area padding for our content. So the content can overlap with the status bar.
What changes do you think we should make in order to solve the problem?

We need to do 2 things:

Remove statusBarTranslucent={false} in AvatarCropModal and AttachmentModal so that it will get the default true value, then the flickering issue here will be fixed.
Calculate the paddingTop of the modal correctly based on the statusBarTranslucent so we don't reintroduce this  style issue .
We can do this by fixing the paddingTop calculation logic in https://github.com/Expensify/App/blob/daf163e04435e293f3f7290edea86c76877e18ee/src/styles/StyleUtils.js#L317

We can update this to something like
let paddingTop = shouldAddTopSafeAreaPadding
        ? (modalContainerStylePaddingTop || 0) + safeAreaPaddingTop
        : modalContainerStylePaddingTop || 0;

    if (statusBarTranslucent) {
        paddingTop += StatusBar.currentHeight;
    }

(a.k.a we add StatusBar.currentHeight to paddingTop so that our content never overlaps with the status bar, we're doing the same thing for the safe area in iOS. If statusBarTranslucent is false we don't need this since the modal already excludes the status bar in this case.)
What alternative solutions did you explore? (Optional)
NA

Result
Working well after the fix:
https://user-images.githubusercontent.com/113963320/222473347-09d65c84-c1cd-48d1-a4fa-7f4bc80ec2cb.mov

👋  @mananjadhav do you have some thoughts on the proposals?

Sorry I missed these. I will review these proposals today.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Modal height is resized earlier when keyboard opens, which makes bottom part transparent and previous screen partially shows
What is the root cause of that problem?
The root cause is well explained by @tienifr here.
So if statusBarTranslucent set to false in Modal, it handles keyboard avoiding automatically and therefore screen is already resized before fully opening keyboard.
What changes do you think we should make in order to solve the problem?
We can completely remove conditional statusBarTranslucent prop in Modal and pass this value true always.
After making status bar translucent, we should handle top safe area padding in android similar to iOS on these modals:

AttachmentModal
AvatarCropModal

Here's final solution:

remove android specific getModalStyles file on which shouldAddTopSafeAreaMargin and shouldAddTopSafeAreaPadding was always set to false. Now these margin/paddings are optionally needed in android

In BaseModal, completely remove statusBarTranslucent prop and update relevant codes accordingly

define const statusBarHeight = StatusBar.currentHeight || 0; globally
update this line to deviceHeight={this.props.windowHeight + statusBarHeight}
https://github.com/Expensify/App/blob/7e8e8a1d881914abe7c13768eb13e4930cb8546b/src/components/Modal/BaseModal.js#L125
pass statusBarTranslucent value always true
https://github.com/Expensify/App/blob/7e8e8a1d881914abe7c13768eb13e4930cb8546b/src/components/Modal/BaseModal.js#L133
add more padding of android status bar height to safeAreaPaddingTop (this is the key to fix https://github.com/Expensify/App/issues/9280)
https://github.com/Expensify/App/blob/7e8e8a1d881914abe7c13768eb13e4930cb8546b/src/components/Modal/BaseModal.js#L145
to
safeAreaPaddingTop: safeAreaPaddingTop + statusBarHeight,
remove statusBarTranslucent in modalProptypes

remove statusBarTranslucent prop in AttachmentModal and AvatarCropModal which are no longer needed

@situchan your approach is basically the same as mine. My proposal is supposed to illustrate the approach, not intended as a whole PR ready to be merged so yes, some tweaks here and there are needed to make sure there's no regression.

Looks like I am already running a good amount of backlog, so I'll unassign myself here. @Christinadobrzyn @aldo-expensify

Ohh Yes! I remember. I think @aimane-chnaif would be a good C+ for this one.

@mananjadhav @aimane-chnaif thanks, I'll assign @aimane-chnaif then!

📣 @aimane-chnaif You have been assigned to this job by @aldo-expensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

@aimane-chnaif assigned as the C+

@Christinadobrzyn @aldo-expensify @aimane-chnaif this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Christina is OoO, so I'm assigning myself to keep this moving!

Sorry, I started too early on this and thought that a proposal had been accepted! I've hired @aimane-chnaif as C+ already, my bad.
Sorry for adding confusion here, I'll do nothing until a proposal is accepted.

Issue not reproducible during KI retests. (First week)

We should use a new flag like shouldAddStatusBarPaddingTop and enable it on full-screen modals instead, and use it to decide if we want to add the status bar padding top to the modal in https://github.com/Expensify/App/blob/daf163e04435e293f3f7290edea86c76877e18ee/src/styles/StyleUtils.js#L317.

@aimane-chnaif I've explained my approach above, here's my branch for you to test out https://github.com/tienifr/App/pull/26
Please let me know if you need any other info.
Thanks!

@aimane-chnaif so this would be the new platform values table (notice the new StatusBarPaddingTop, StatusBarMarginTop columns)

Platform
isSmallScreenWidth
margin:20
StatusBarPaddingTop
StatusBarMarginTop
topSafeAreaMargin
bottomSafeAreaMargin
topSafeAreaPadding
bottomSafeAreaPadding

iPhone
Yes
❌
❌
❌
❌
❌
✅
❌

Android
Yes
❌
✅
❌
❌
❌
❌
❌

iPad
No
✅
❌
❌
✅
✅
❌
❌

Tablet
No
✅
❌
✅
❌
❌
❌
❌

Web/Desktop
No
✅
❌
❌
❌
❌
❌
❌

(Now that @Christinadobrzyn is back from OoO, I'm going to unassign myself again here!)

@Christinadobrzyn @aldo-expensify @aimane-chnaif this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@aimane-chnaif sure, I think the SafeArea for iOS is sort of equivalent to the statusBarHeight in Android, so if we want to we can reuse our existing shouldAddTopSafeAreaMargin and shouldAddTopSafeAreaPadding field for the status bar while still remaining safe.
What I suggest is:

We make shouldAddTopSafeAreaMargin and shouldAddTopSafeAreaPadding available on Android similar to iOS (rather than always setting it to false)
We define our own definition of top inset for Android, the top inset will be set to statusBar height for Android, and insets.top (from react-native-safe-area-context) for iOS
This can be done by defining a getSafeAreaPaddingTop util similar to here and here

@aimane-chnaif you can check the diff for this solution from this branch, it's quite clean and easy to understand.

@aimane-chnaif sure
Proposal updated

@aimane-chnaif yeah I meant the same in the RCA, maybe my explanation was a bit confusing, I updated it to be more clear.
Thanks.

I'd love to contribute to work on this issue. Could I possibly ask you to start work on it? Thanks!

📣 @ienjoyjs! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@aldo-expensify thanks for asking me. I already gave 👍 ❤ to suggestions.

I think you tagged wrong person. you meant @tienifr?

@aldo-expensify thanks for asking me. I already gave 👍 ❤ to suggestions.

ok!, I just wanted to confirm because the emojis doesn't really say with which option you are agreeing :P

I think you tagged wrong person. you meant @tienifr?

oops, you are right

📣 @situchan You have been assigned to this job by @aldo-expensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

@tienifr @situchan I assigned you both. How would you prefer to split the work?

I agree if @tienifr can quickly raise PR.

@situchan The PR is ready, Could you help to take a look at it?

sorry @aimane-chnaif I'm working on the PR changes right now. I must have missed out some notifications.

PR merged

@Christinadobrzyn , for clarity:

@aimane-chnaif is the C+
@tienifr and @situchan are going to share the compensation

@tienifr and @situchan , about the speed bonus (if there is?), do you agree with also splitting in half?

I agree

OK - Hired in upwork

@aimane-chnaif $4000 as C+
@tienifr $2000 shared comp for fix
@situchan $2000 shared comp for fix
@gadhiyamanan $250 as reporter

Hi @aimane-chnaif @aldo-expensify @situchan
Regression Test Proposal
Bug: Last message in the report shows for a brief moment when the keyboard opens while clicking on password text Input in password-protected pdf
Proposed Test Steps:
Sample password protected PDF: password-protected.pdf
Password: 1234

Sign in to NewExpensify Chrome on an Android
Select a chat
Send a password protected pdf
Click on password protected pdf
Click on blue hyperlink to "enter password"
As the keyboard slides up, verify that you will not see the chat behind.

Do we :+1: or :-1:

Sign in to NewExpensify Chrome on an Android

@tienifr I think this is wrong. It's native issue, not mWeb

@situchan updated. Many thanks

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.89-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/16332

If no regressions arise, payment will be issued on 2023-04-03. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@aimane-chnaif / @aldo-expensify] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@aimane-chnaif / @aldo-expensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@aimane-chnaif / @aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@Christinadobrzyn] Determine if we should create a regression test for this bug.
[ ] [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Paid this out! Looks like a speed bonus applies

@aimane-chnaif $4000 + 50% bonus for C+
@tienifr $2000 + 50% bonus shared comp for fix
@situchan $2000 + 50% bonus shared comp for fix
@gadhiyamanan $250 as reporter

closed the job in upwork
@aimane-chnaif and @aldo-expensify can you give your thoughts on the test regression proposal here? Thanks!

@aimane-chnaif / @tienifr  do you know which change introduced this bug exactly?

It seems that this PR caused a regression https://expensify.slack.com/archives/C049HHMV9SM/p1680745076761309

Oh really? Didn't imagine our fix affected storybook.
I commented on that regression issue.

@Christinadobrzyn, @aldo-expensify, @aimane-chnaif, @situchan, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Christinadobrzyn, @aldo-expensify, @aimane-chnaif, @situchan, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

I confirmed that storybook issue existed before our PR so not a regression.
I would say https://github.com/Expensify/App/pull/13580 is only the offending PR which caused regression.

Hi @situchan sorry I'm not quite sure where we are at this point, can you provide an update? Thanks!

Hi @situchan sorry I'm not quite sure where we are at this point, can you provide an update? Thanks!

We can go as normal. Our PR didn't cause any regression.
I think BZ checklist is just remaining and then close the issue.

Thanks @situchan!
@aldo-expensify and @aimane-chnaif are we happy with the test regression here - https://github.com/Expensify/App/issues/15373#issuecomment-1480721110

Regression test here - going to close this out!


Update schedule with upcoming releases

Changes

Update schedule with upcoming releases

@pierDipi @creydr if you already have an idea for the next Eventing release leads, feel free to add the names. I can alter between Serving and Eventing as well. Or not be there at all. :)
/cc @knative/knative-release-leads

@dsimansk you can also add me for Serving. I'll shadow the next one to get into this for Serving.

@dsimansk you can also add me for Serving. I'll shadow the next one to get into this for Serving.

Cool, thanks! Done.


Error during Cuda Extensions install: arch_list[-1] += '+PTX' IndexError: list index out of range

I am using cuda 11.4 and found the following error?
Anyone ran into this too?
(torch) user@AILAB-U-0029:/media/user/precp1/prob_centerpoint$ bash setup.sh No CUDA runtime is found, using CUDA_HOME='/usr/local/cuda-11.4' running build_ext building 'deform_conv_cuda' extension Traceback (most recent call last):   File "/media/user/precp1/prob_centerpoint/det3d/ops/dcn/setup.py", line 4, in <module>     setup(   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/setuptools/__init__.py", line 153, in setup     return distutils.core.setup(**attrs)   File "/home/user/anaconda3/envs/torch/lib/python3.9/distutils/core.py", line 148, in setup     dist.run_commands()   File "/home/user/anaconda3/envs/torch/lib/python3.9/distutils/dist.py", line 966, in run_commands     self.run_command(cmd)   File "/home/user/anaconda3/envs/torch/lib/python3.9/distutils/dist.py", line 985, in run_command     cmd_obj.run()   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/setuptools/command/build_ext.py", line 79, in run     _build_ext.run(self)   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/Cython/Distutils/old_build_ext.py", line 186, in run     _build_ext.build_ext.run(self)   File "/home/user/anaconda3/envs/torch/lib/python3.9/distutils/command/build_ext.py", line 340, in run     self.build_extensions()   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 709, in build_extensions     build_ext.build_extensions(self)   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/Cython/Distutils/old_build_ext.py", line 195, in build_extensions     _build_ext.build_ext.build_extensions(self)   File "/home/user/anaconda3/envs/torch/lib/python3.9/distutils/command/build_ext.py", line 449, in build_extensions     self._build_extensions_serial()   File "/home/user/anaconda3/envs/torch/lib/python3.9/distutils/command/build_ext.py", line 474, in _build_extensions_serial     self.build_extension(ext)   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/setuptools/command/build_ext.py", line 202, in build_extension     _build_ext.build_extension(self, ext)   File "/home/user/anaconda3/envs/torch/lib/python3.9/distutils/command/build_ext.py", line 529, in build_extension     objects = self.compiler.compile(sources,   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 525, in unix_wrap_ninja_compile     cuda_post_cflags = unix_cuda_flags(cuda_post_cflags)   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 424, in unix_cuda_flags     cflags + _get_cuda_arch_flags(cflags))   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 1562, in _get_cuda_arch_flags     arch_list[-1] += '+PTX' IndexError: list index out of range No CUDA runtime is found, using CUDA_HOME='/usr/local/cuda-11.4' running build_ext building 'iou3d_nms_cuda' extension Traceback (most recent call last):   File "/media/user/precp1/prob_centerpoint/det3d/ops/iou3d_nms/setup.py", line 4, in <module>     setup(   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/setuptools/__init__.py", line 153, in setup     return distutils.core.setup(**attrs)   File "/home/user/anaconda3/envs/torch/lib/python3.9/distutils/core.py", line 148, in setup     dist.run_commands()   File "/home/user/anaconda3/envs/torch/lib/python3.9/distutils/dist.py", line 966, in run_commands     self.run_command(cmd)   File "/home/user/anaconda3/envs/torch/lib/python3.9/distutils/dist.py", line 985, in run_command     cmd_obj.run()   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/setuptools/command/build_ext.py", line 79, in run     _build_ext.run(self)   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/Cython/Distutils/old_build_ext.py", line 186, in run     _build_ext.build_ext.run(self)   File "/home/user/anaconda3/envs/torch/lib/python3.9/distutils/command/build_ext.py", line 340, in run     self.build_extensions()   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 709, in build_extensions     build_ext.build_extensions(self)   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/Cython/Distutils/old_build_ext.py", line 195, in build_extensions     _build_ext.build_ext.build_extensions(self)   File "/home/user/anaconda3/envs/torch/lib/python3.9/distutils/command/build_ext.py", line 449, in build_extensions     self._build_extensions_serial()   File "/home/user/anaconda3/envs/torch/lib/python3.9/distutils/command/build_ext.py", line 474, in _build_extensions_serial     self.build_extension(ext)   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/setuptools/command/build_ext.py", line 202, in build_extension     _build_ext.build_extension(self, ext)   File "/home/user/anaconda3/envs/torch/lib/python3.9/distutils/command/build_ext.py", line 529, in build_extension     objects = self.compiler.compile(sources,   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 525, in unix_wrap_ninja_compile     cuda_post_cflags = unix_cuda_flags(cuda_post_cflags)   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 424, in unix_cuda_flags     cflags + _get_cuda_arch_flags(cflags))   File "/home/user/anaconda3/envs/torch/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 1562, in _get_cuda_arch_flags     arch_list[-1] += '+PTX' IndexError: list index out of range

could you build the nms? The dcn is not used in current repo now (and you can ignore it).
You can change the setup.sh to the following
cd  det3d/ops/iou3d_nms
python setup.py build_ext --inplace

could you build the nms? The dcn is not used in current repo now (and you can ignore it).
You can change the setup.sh to the following
cd  det3d/ops/iou3d_nms
python setup.py build_ext --inplace

I found it's a torch version problem. The official torch website's conda install command leads to a cpu version. Install the pip one solved my problem. Thanks


Feature request: access to the IllustratedMessage as noData in the UploadSet

Currently, it is very difficult to access the IllustrateMessage as noData aggregation in the UploadSet.
In 1.119 only following properties are available:

noDataDescription
noDataIllustrationType
noDataText

Developers need to be able to change the size, illustration etc. of the IllustratedMessage inside. I have found a workaround but that is certainly not ideal:
let oList = this.byId("uploadSet").getDependents()[0]; let oIllustratedMessage = new IllustratedMessage({     illustrationSize: IllustratedMessageSize.Dot,     illustrationType: IllustratedMessageType.NoMail,     title: 'No Data' }); oList.setAggregation("noData", oIllustratedMessage);
The UI5 API should make this straightforward, also for at least version 1.108 which is Long-term Maintenance, Q4/2027.

Hello @jvanattedev,
Thank you for sharing your enhancement proposal. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Niya

Hello @jvanattedev,
Thank you for reaching out for the Feature Request on the UploadSet, Currently we are discussing with our Architect / PO a better way to handle this use case. We have created a Backlog item for the same: FIORITECHP1-28989
Currently as you have mentioned dUploadSet does provide properties such as :

noDataText maps to -> sap.m.IllustratedMessage.Title
noDataDescription maps to -> sap.m.IllustratedMessage.Description
noDataIllustrationType maps to -> sap.m.IllustratedMessage.illustrationType

Which can be used to update certain properties of IllustratedMessage. Access to sap.m.IllustratedMessage.illustrationSize has yet not been provided.
Currently untill the backlog is completed the mentioned workaround can still be used.
However as you have mentioned you would require the changes for 1.108, Performing the downport to 1.108 would not be possible as this would be a new enhancement on the UploadSet Control.
Adding of a new API / Properties /  Aggregation would be considered an enhancements and as per guidelines they would not be down ported to Long Term Releases.
Thanks,
Ashwin

This issue will be covered in backlog item FIORITECHP1-28989.

Hello @jvanattedev,
Thank you for reaching out for the Feature Request on the UploadSet, Currently we are discussing with our Architect / PO a better way to handle this use case. We have created a Backlog item for the same: FIORITECHP1-28989
Currently as you have mentioned dUploadSet does provide properties such as :

noDataText maps to -> sap.m.IllustratedMessage.Title
noDataDescription maps to -> sap.m.IllustratedMessage.Description
noDataIllustrationType maps to -> sap.m.IllustratedMessage.illustrationType

Which can be used to update certain properties of IllustratedMessage. Access to sap.m.IllustratedMessage.illustrationSize has yet not been provided. Currently untill the backlog is completed the mentioned workaround can still be used.
However as you have mentioned you would require the changes for 1.108, Performing the downport to 1.108 would not be possible as this would be a new enhancement on the UploadSet Control. Adding of a new API / Properties / Aggregation would be considered an enhancements and as per guidelines they would not be down ported to Long Term Releases.
Thanks, Ashwin

Just to add some information. On initial load, the workaround is ok. But when you add an attachment, and then remove it again (so the list is empty). The original size is showing again. We can reset the size again in AfterItemRemoved using a timeout(0), but then you can see the large drawing first very shortly, followed by the size you have (re)set. It results in a flickering effect. BeforeItemRemoved is too soon.


Parallelize and prioritize model inference on ARM CPU with tensorflow lite.

I have two different neural networks running with tensorflow lite on an embedded device, using an arm cpu.
My questions are: How can I execute both models at parallel? How can I give one of the two models a higher priority than the other one? The background is: I do not want one model to block or interrept execution of the other model.

This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.
Thanks!

Excellent


Make funkyheatmap header text white

Describe your changes
Issue ticket number and link
Closes #171
Checklist before requesting a review

[X] I have performed a self-review of my code

Check the correct box. Does this PR contain:

[ ] Breaking changes
[ ] New functionality
[ ] Major changes
[ ] Minor changes
[X] Bug fixes

[ ] Proposed changes are described in the CHANGELOG.md
(no, because it's fixing something that has not yet been released)

[x] CI Preview succeeds and looks good!

This seems to do the opposite of what we want -- Now the text is always black. Originally, the text was always white.

Can we discuss how you want the funkyheatmap to look with the night theme? I can adapt different elements and use css variables for styles

Weird. I'll look into this tomorrow.
Re: other issues, what are they? Should be easy enough to fix.


Is there a way to perform implicit joins using navigation properties (a-la EF)?

Most ORMs will allow me to write expressions like this:
var query_where3 =
	svcContext.ContactSet
	          .Where(c => c.LastName.Contains("Smith"))
                  .Where(c => c.Account.Name.Contains("Contoso"))
                  .Select(c => new { account_name = c.Account.Name, contact_name = c.LastName })
                  .ToList();

Removing the need to use explicit joins.
Is there any way to do this using the CrmServiceContext?

Edit: for some reason docs.microsoft.com escaped my code, so I edited it manually here on GitHub.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f00eab4b-fb63-761f-2a30-eba6aaaa9a0a
Version Independent ID: c2cf2b11-010d-0e9b-199a-f269dd2085f2
Content: Sample: Complex LINQ queries (Developer Guide for Dynamics 365 Customer Engagement)
Content Source: ce/customerengagement/on-premises/developer/org-service/sample-complex-linq-queries.md
Service: crm-online
GitHub Login: @KumarVivek
Microsoft Alias: kvivek

Duplicate of #1054


Create Scientific Notation input

Using the new input #3476 and the new number utils #3467
Create a component to enter numbers.

I just reviewed number.spec.ts and made some comments on a few cases that may be missing.
Def not a priority, there may be a need in the future to support complex numbers
possibly: 1 + i2 and -1 234.567 8e+2 - i 9.012 345e+1
Lovely


Improved runtime/syntax/tcl.vim

This PR updates the runtime/syntax/tcl.vim file:

added @Spell to limit spell checking to Tcl comments and strings
rather than spelling checking everything.
removed broken link to source of the upstream tcl.vim
replaced things like [0-7] with \o, [0-9a-f] with \x (etc.) as
the atom from are documented to be faster than the [..] alternative,
at least with regexepengine=1

I emailed the maintainer of runtime/syntax/tcl.vim providing a link to this PR.

ping me in a couple of weeks if the maintainer is unresponsive.

@brammool wrote:

ping me in a couple of weeks if the maintainer is unresponsive.

No response from maintainer. I had emailed on Oct 3, 2021 so about 40 days ago.
I suppose we should merge in the PR in such case.

OK, I'll include it and add a note to the header.


Replace FindBugs by SpotBugs, and suppress current issues

The new dependabot issues are failing. The GitHub action is running SpotBugs, while Travis runs just mvn.
This PR updates the GitHub action to run mvn. Also replaces FindBugs by SpotBugs (using Lang as example), and suppresses the issues reported by SpotBugs so that build passes (there are issues in JIRA for that already).
BinaryConstants also implemented the clone() method without implementing Cloneable. This PR removes the clone method as that was not used.

Coverage increased (+0.005%) to 76.315% when pulling 84f21f27186cd456828632490d02ca7dd69c892a on kinow:findbugs-2-spotbugs into 10b3edbcf780ac33a8afe2ed861241aad9dd806d on apache:master.

Interesting. When I use JDK 14 I get more errors, just like in Travis. Fixing those now.

Getting some issues due to incompatibilities of SpotBugs with newer JVM versions, e.g. https://github.com/spotbugs/spotbugs/issues/756
Converted PR to draft. Let me see if I can fix the GitHub workflow.

Java 16 error is due to FindBugs not supporting that JVM version.


SNAPSHOT Version Not Up-To-Date

The SNAPSHOT version is not up-to-date in Sonatype.  The most recent version available is 3.1.5-SNAPSHOT, built on January 5, 2017.  The 3.1.6-SNAPSHOT is not available at all.
https://oss.sonatype.org/content/repositories/snapshots/com/github/kongchen/swagger-maven-plugin/

Up-To-Date now.
2017-09-07 6:11 GMT+08:00 Matthew Lawrence<EMAIL_ADDRESS>
The SNAPSHOT version is not up-to-date in Sonatype. The most recent
version available is 3.1.5-SNAPSHOT, built on January 5, 2017. The
3.1.6-SNAPSHOT is not available at all.
https://oss.sonatype.org/content/repositories/
snapshots/com/github/kongchen/swagger-maven-plugin/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kongchen/swagger-maven-plugin/issues/532, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABar6BKomrsCu0u3CtGGZJ15TjTjUK-3ks5sfw4ZgaJpZM4PO_nU
.

--
Regards,
Kong

Thanks! I have confirmed this is working.


[WFLY-6854] Upgrade to Hibernate ORM 5.1.2

Replacement for https://github.com/wildfly/wildfly/pull/8984.

Issue list for this pull request : https://issues.jboss.org/browse/WFLY-6854
https://issues.jboss.org/browse/EAP7-582
https://issues.jboss.org/browse/JBEAP-5678
https://github.com/wildfly/wildfly/pull/8984 also had some discussion for this change.

Once we have a Hibernate ORM 5.1.3 release, this pull request should be updated to include 5.1.3.  We should also update Javassist to  3.20.0-GA, which Hibernate 5.1.x is using (as well as Jetty).

Could this pull request be updated to use 5.1.3.Final?  5.1.3 isn't released yet but will be soon.  That way, we can ask for this pull request to be tested again after Hibernate ORM 5.3.1.Final is released.  Thanks Frank!


JsonSchema.Net.Generation: Stack overflow when resolve List as children

Environment

Nuget Package: JsonSchema.Net.Generation
Nuget Version: 1.2.1
OS: Win10
.Net Target: netcoreapp3.1

Describe the bug
I met a Stack overflow exception when  I using Json.Schema.Generation to generate schema from dotnet types.
I'm not sure whether it is suitable to describe my schema in dotnet types.
To Reproduce
create a class as below:
    public class TestMenu
    {
        public string Name { get; set; }

        public List<TestMenu> Children{ get; set; }
    }

and call JsonSchema actual = new JsonSchemaBuilder().FromType<TestMenu>();
Expected behavior
output schema success
Additional context
none.

Thank for reporting this!  I'm pretty sure I have a test for this, but I'll dig in and see what I can find.

hi, @gregsdennis ,tks for reply.
See  https://github.com/gregsdennis/json-everything/blob/master/JsonSchema.Generation.Tests/SchemaGenerationTests.cs#L164
Add public List<GenerationTarget> Children { get; set; }  below it, and the test GeneratorForObject()  not response, it's stack overflow.

@personball look out for v1.2.2.  Should be available in a few minutes.

@gregsdennis  Thank you very much.

@gregsdennis Hi, here is another  stack overflow
using System.Text.Json.Serialization;
public class TestMenu
    {
        public string Name { get; set; }

        [JsonPropertyName("children")] // This line cause Stack Overflow Exception
        public List<TestMenu> Children{ get; set; }
    }

This is actually a similar but different issue.  I'm going to re-close this and open a new issue.