EIP 1559 support for transactions - mainnet

Description
In order to support eip 1559 transactions on mainnet, the gas configuration should take in an object that includes the following:
{
    maxPriorityFeePerGas,
    maxFeePerGas
}

on all other networks (ie optimism) the gas object should take the following configuration:
{
    gasPrice
}

by adding this functionality to the useGas hook, the transactions that get queued in the app should be able to support both 1559 and non 1559 transactions. Keep in mind that users can set their own customGasPrice in the app.
Related issue
https://github.com/Kwenta/kwenta/issues/361
Motivation and Context
refactoring gas logic into a useGas hook and setting up kwenta transactions to support EIP-1559.
I have created an object that can be used for gas configurations called gasConfig. you can see this being swapped in the transactions across these Kwenta components:

ManageShort
useExchange#1
useExchange#2
ManageShortAction

the main changes for this pr are in the useGas hook here. I refactored all the consistent gas related items into the following object for useGas:
const useGas = () => {
  ...
  return {
    gasPrice,
    gasPriceWei,
    getGasLimitEstimate,
    maxFeePerGas,
    maxPriorityFeePerGas,
    gasPrices,
    gasSpeed,
    setGasSpeed,
    isCustomGasPrice,
    customGasPrice,
    setCustomGasPrice,
    gasConfig,
  }
}

How Has This Been Tested?
** I repeated the same process described below on dev and this branch.

on mainnet:

visit the exchange
select two currencies to exchange and input a value
select Submit Order
inspected the transaction to make sure a relatively appropriate Max Base Fee and Max Priority Fee are set

Screenshots (if appropriate):
BEFORE changes on dev branch(mainnet):

AFTER changes on this branch(mainnet):

BEFORE changes on dev branch(optimism):

AFTER changes on this branch(optimism):

in regards to this one -- useExchange is a large file so the places where some of these values are not obvious from the pr
gasPrice is calculated in useGas now,
gasPriceWei is calculated in useGas based on the value of gasPrice,
line 523-526
line 554
line 592-618
line 697-790
line 1099

@Tburm Can you look over these changes here that way you're across it when we merge into V2

just an fyi - i added this to the tooltip - see discussion on tick 361


Fixed issue #2527, now main menu music looping infinitely

Contains
Fixes #2527, now music looping infinitely, simple and efficient.
How to test
Go to main menu, enjoy the music till it ends and  restarts again.. the music is about 3 minutes..
Outstanding before merging

Can one of the admins please verify this patch?

The music does loop infinitely, but not only in the main menu, when you start playing it just re-loops as well....

You would want to kill the thread in instances when the game is started etc.

Ah ok I thought that it would be nice to have a background music all along hahaha, I'll make the modifs!

@nihal111  the problem is solved for all the possible navigations from the menu and stops when we start the game, however, I found another bug that stops the music if the main menu is kept open for too long in the background, looks like if the game goes on a hibernation mode or something. I'll push when I find out if it's normal. I'll keep you informed.

Are you sure that you can reproduce it reliably?
There is also the case when the music stops abruptly (mostly at start), and I believe that is IntelliJ doing some optimizations, followed by a "Delta too great.." message. Have a look at the discussion in the issue and a related issue- https://github.com/MovingBlocks/Terasology/issues/2364.
The above issue doesn't seem to happen when running the game from the binary though.
Not sure whether what you discovered is the same, just fyi.

Yes I think the two are related, got the same log trace, will probably solve both at the same time.

Hello Nihal, tried to reproduce the problem in various ways, I think that it should be fine now, what happens is that for some reason the music was stopped, now the Listener ensures that the music is looping till we explicitly quit the menu.

Closing as finished by #2945 - added you to the credits for your efforts @omomthings thanks again :-)


Fix(Snackbar): Add Support for Hold, Check, Delete, and Create notification

Enhance the Snackbar component to support Hold, Check, Delete, and Create operations for improved functionality.
Tasks

[ ] Implement functionality to handle the Hold notification in Snackbar.
[ ] Add support for Check notification to verify Snackbar actions.
[ ] Include functionality for Delete notification directly through Snackbar.
[ ] Enable Create notification as part of Snackbar actions.

Additional Notes

Ensure that all notificationare properly integrated and trigger the correct state changes.
Use Recoil or existing state management to handle these operations efficiently.
Test each operation for reliability and user experience.

Can you share more details about it?

Hi Zaheer I am a student at the University of Michigan and doing a class project where I need to contribute to an Open Source project. Do you mind if I address the issue?

Hi Narain I am a student at the University of Michigan and doing a class project where I need to contribute to an Open Source project. I would like to address this issue. Could you maybe provide more detail on the issue?

@vsanthapur @zaheer-Khan3260 . The issue is I've used Snackbar API of MUI in the sticky memo application. Where I get the Snackbar notification in creation of notes. I want the Snackbar notification for deleted, held and checked notes, boards and rows.

@vsanthapur @zaheer-Khan3260 . The issue is I've used Snackbar API of MUI in the sticky memo application. Where I get the Snackbar notification in creation of notes. I want the Snackbar notification for deleted, held and checked notes, boards and rows.

This sounds doable. Can you please assign me this issue. I will get the PR out by Sunday. Thank you!

Sure @vsanthapur, test completely and then give me a PR.

Thank you, @vsanthapur, for submitting the PR! Your valuable contributions are helping the sticky-memo project grow stronger. Looking forward to more from you, feel free to explore and work on other issues! 🤝 #70 PR successfully addressed this issue.


Adding scope to error reporting client.

/cc @jonparrott
Fixes #3263
FWIW I have no idea if this is the correct scope, I couldn't find one in the official docs but I just based it off the scopes in the discovery doc

@waprin I take your merging as an affirmation that the scope I picked was correct?

It's right as far as I know and the docs go.


Auto-completing path ending with & causes prompt to hang

Windows Build Number
Microsoft Windows [Version 10.0.19043.985]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
Linux version 5.4.72-microsoft-standard-WSL2 (oe-user@oe-host) (gcc version 8.2.0 (GCC)) #1 SMP Wed Oct 28 23:40:43 UTC 2020
Distro Version
Ubuntu 20.04
Other Software
No response
Repro Steps

Enter a path into bash prompt that ends with an ampersand (&), the path doesn't have to exist (e.g. /test/&), the issue occurs with non-existing and existing paths alike.
Hit tab for autocompletion of path.
Note that the prompt is now frozen, no shurtcut can bring back the prompt (like Ctrl + c or Ctrl + z).
After a significant amount of time the prompt seems to reset while showing an error (because of the ampersand).

-bash: d: command not found

One real life example is navigating to a folder that contains an ampersand (nothing unusual, like the name of a company).
Expected Behavior
Auto-completion should work fine (or skip when path doesn't exist).
Actual Behavior
Prompt hangs for a significant amount of time and can't be reset.
Diagnostic Logs
No response

& is bash operator. if you want, create folder with '&'.

Learn more here: https://linuxhint.com/bash_operator_examples/#o21

You are right. But what if you just want to autocomplete a path ending with &?
Can you reproduce this issue?
Enter a path (doesn't have to actually exist) ending with & and hit Tab for autocompletion.
For me in Ubuntu 20.x default bash the whole terminal hangs for a long time and with no way resetting it.

Just type in cmd.exe: wsl --shutdown , then launch again Ubuntu distro.
Simple way to solve your problem, just rename that folder.
It's same for Windows.

I was able to reproduce here, but wasn't curious enough to look what bash completion is up to specifically under strace(1). This is a variation /dupe #4234 or #5696 (others). Whatever bash is doing, it is doing it faithfully, but slowly. Which is #4197. Prompt returns reasonably with $PATH absent all the /mnt/c entries. The prompt did return for me eventually with a really fast ssd and all the Windows paths.
FWIW, it isn't really all that fair to punt these ultimately cause #4197. It just isn't a particularly contemplated scenario on Real Linux™ to have two dozen (or more) paths to a slow network drive. You'd get the same behavior on a native box if that were a thing. Even if the /mnt/c performance on WSL2 improved by an order of magnitude, the OP repro would still be "slow" by design. Maybe there is a way to coerce bash_completion to skip certain paths (never looked into it). Or if there isn't, maybe such a thing could be invented. Worthy enough discussion to explore that much some more.
Tab after the ampersand below...


Add DateTimeFormat polyfills with timezone abbreviations

Details

Add DateTimeFormat polyfills to support backward timezones and display them as modern, canonicalized timezone names. This PR adds support for timezone abbreviations which was not covered in https://github.com/Expensify/App/pull/29113.
Fixed Issues

$ https://github.com/Expensify/App/issues/27392
PROPOSAL: https://github.com/Expensify/App/issues/27392#issuecomment-1721053555
Tests

How to change local timezone
MacOS
Chrome (or Chormium-based browsers) on MacOS Sonoma is failing to retrieve timezone. Reported issue here: https://support.google.com/chrome/thread/231926653/timezone-return-undefined. So if you're using Mac Sonoma, please use Safari for testing; or use other Mac OS versions.

Open Date & Time settings
Turn off Set time zone automatically using your current location
Under Closest city, choose the desired timezone

iOS
MacOS's timezone settings also applies to simulator. For physical device:

Open Settings >> General >> Date & Time
Turn off Set automatically
Under Timezone, choose the desired timezone

Android

Open Settings >> System >> Date & Time
Under Time zone, turn off Set automatically
Under Time zone, choose the desired region/timezone

Test steps
Automatic timezone detection requires app restart/refresh to take effects.
All platforms

Close app
Change local timezone to Kolkata - India
Open app
Go to Settings >> Profile >> Timezone
Turn on Automatically determine your location.
Verify the automatic timezone is Asia/Kolkata
Repeat step 1 to 6 with Hanoi - Vietnam city and verify Asia/Ho_Chi_Minh timezone
May test with other cities-timezones pairs here

More for iOS

Set account A's timezone to Asia/Ho_Chi_Minh on Web
Open app on iOS, already login with A, OR with any account that has chat with A before
Open any existing chat joined by A
Verify that app does not crash

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Same as Tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@situchan Don't forget to review this PR asap

@situchan It's been 2 weeks, please review asap!

Auto-assigning the review so I can follow the progress and I can make sure it gets reviewed.

reviewing

Timezone is not updated automatically after turning on "Automatically determine your location"
https://github.com/Expensify/App/assets/108292595/af6fc7ee-3d6f-477f-856d-c953cb3fe61c
I think this can be out of scope as already happens on main

Performance tests are failing. It's random so let's see if success after pull main

Sorry @tienifr I was on vacation last week, I will review it today!!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.4.24-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.24-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Default VPCs not being deleted

AFT Version:
(Can be found in the AFT Management Account in the SSM Parameter /aft/config/aft/version)
1.4.2
Terraform Version & Provider Versions
Please provide the outputs of terraform version and terraform providers from within your AFT environment
terraform version
Terraform v1.2.2
on linux_amd64
+ provider registry.terraform.io/hashicorp/archive v2.2.0
+ provider registry.terraform.io/hashicorp/aws v4.20.1
+ provider registry.terraform.io/hashicorp/local v2.2.3
+ provider registry.terraform.io/hashicorp/random v3.3.2
+ provider registry.terraform.io/hashicorp/time v0.7.2

terraform providers
Providers required by configuration:
.
├── provider[registry.terraform.io/hashicorp/aws] > 4.9.0, < 5.0.0
└── module.account_factory_for_terraform
    ├── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0, < 5.0.0
    ├── provider[registry.terraform.io/hashicorp/local]
    ├── module.aft_lambda_layer
    │   ├── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   ├── provider[registry.terraform.io/hashicorp/random]
    │   └── provider[registry.terraform.io/hashicorp/local]
    ├── module.aft_account_provisioning_framework
    │   └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    ├── module.aft_code_repositories
    │   ├── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   └── provider[registry.terraform.io/hashicorp/local]
    ├── module.aft_customizations
    │   ├── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   └── provider[registry.terraform.io/hashicorp/local]
    ├── module.aft_feature_options
    │   └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    ├── module.aft_iam_roles
    │   ├── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   ├── module.audit_service_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   ├── module.ct_management_exec_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   ├── module.ct_management_service_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   ├── module.log_archive_exec_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   ├── module.log_archive_service_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   ├── module.aft_exec_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   ├── module.aft_service_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   └── module.audit_exec_role
    │       └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    ├── module.aft_account_request_framework
    │   ├── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    │   └── provider[registry.terraform.io/hashicorp/time]
    ├── module.aft_ssm_parameters
    │   └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0
    ├── module.packaging
    │   └── provider[registry.terraform.io/hashicorp/archive]
    └── module.aft_backend
        └── provider[registry.terraform.io/hashicorp/aws] >= 4.9.0

Providers required by state:

    provider[registry.terraform.io/hashicorp/archive]

    provider[registry.terraform.io/hashicorp/random]

    provider[registry.terraform.io/hashicorp/time]

    provider[registry.terraform.io/hashicorp/aws]

    provider[registry.terraform.io/hashicorp/local]

Bug Description
Newly provisioned accounts have VPCs when aft_feature_delete_default_vpcs_enabled = true
To Reproduce
Steps to reproduce the behavior:

Provision Account
View VPCS in ALL Regions
See that default VPCs exist

Expected behavior
I expect there to be no default VPCs in all regions of an account
Related Logs
Provide any related logs or error messages to help explain your problem.
Additional context
Related to https://github.com/aws-ia/terraform-aws-control_tower_account_factory/issues/142 but is different because VPC is still in default region

Hey Calvin,
We've become aware of an issue wherein the Delete Default VPCs feature option is not behaving in a manner that is consistent with AFT documentation. The documentation communicated that the feature option should delete default VPCs in all accounts managed by AFT. In reality AFT deletes default VPCs within the AFT management account, but not in accounts that AFT manages.
While a change to update the behavior to delete VPCs in all AFT vended accounts is relatively straightforward, we've deemed it risky to update to this behavior at this time. Customers have enrolled existing accounts in AFT and have not seen their default VPCs deleted with this feature enabled. Changing the behavior of the feature option to delete those default VPCs could put those customers at risk.
To alleviate the immediate miscommunication, we've updated the AFT docs to reflect the actual behavior. We're exploring other options for how to introduce functionality to delete default VPCs in vended accounts in a manner that is safe for our customers. In the meantime, the Control Tower service itself will delete default VPCs in accounts you vend in regions managed by Control Tower. You can read more about this process here.
We apologize for the inconvenience caused by this miscommunication. Further updates to this behavior will be communicated on the AFT GitHub page and through public AWS documentation.

Thanks for the clear explanation of what was going on, and the guidance on how to resolve this situation within control tower.

I spent this morning going through the code and wonder how the heck can it work? since it's overwritten the client to aft session instead of teh remote account session.


Replace fatfs::io traits with embedded-io traits

This slotted in fairly easily, due to how similar the two sets of traits were. The only real difference is how UnexpectedEof is handled. Previously this crate had methods on the IoError trait to create an UnexpectedEof error, in embedded-io the read_exact method actually returns an entirely different enum, one which handles the UnexpectedEof or other io errors.
I believe this is a good change, for a number of reasons. Firstly embedded-io is almost a drop-in solution, and by switching more of the ecosystem can use this crate. embedded-io is established in the community and growing in popularity. embedded-io has a set of  async traits which may allow this crate to take advantage of async io in the future.

Hmm, I guess one small downside to this is that we need edition 2021, I'll bump that and the MSRV too.

Converting to draft as embedded-io needs to properly support WriteZero errors, relevant PR: https://github.com/embassy-rs/embedded-io/pull/18

the io traits (both std::io and embedded-io) represent "any byte stream". Perhaps a "block device" trait would make more sense here?
For example, the contract of the io traits doesn't specify all seeks/reads/writes have to be aligned to the block size, but for io implementations for block devices they have to be...

the io traits (both std::io and embedded-io) represent "any byte stream". Perhaps a "block device" trait would make more sense here?

Good point! When I used version 0.3 of this crate with core_io, I ended up having to write a BufferredSdCard Wrapper which would ensure that any byte stream access went through as aligned block size reads and writes. I guess it is up to @rafalh whether it should be handled inside rust-fatfs as a block device or if the wrapper approach would be preferred.

Wrapper approach is probably better as I wouldn't want to have to conform to aligned reads for non block devices like EEPROMs.

FYI embedded-io has now been moved into rust-embedded/embedded-hal, where it will be used for the Serial traits and general I/O, further cementing the value of the crate.

0.5.0 was recently released so WriteZero is now available for use here

I won't be updating this PR any longer, as I have decided to hard fork to add async support here: https://github.com/MabezDev/embedded-fatfs. My fork uses the embedded-io traits, if you need blocking support I'd happily accept a PR which adds a blocking layer over the async API.
I hope this PR is still useful, anyone is welcome to salvage it to get e-io support in rust-fatfs.


Toml vs Dependabot :)

This should get the dependabot work with our toml file, they finally implemented it in a rudimentary way. It's not super nice to read, but I'm willing to take that if we get dependabot PRs for all of our dependencies with it.
I'd like to test this in this project, if it works out, I would use this notation in our other projects too.

@DanielW1987 This can be reviewed now!


Aggregation Method

Thanks for your nice work, but I'm curious if there's been any experimentation with traditional aggregation methods? Like Conv downsampling or MeanPooling/MaxPooling, what is the effect?

We haven't tried these simple aggregation methods, but there has been work 2404.16994 using pooling to aggregate video tokens

We haven't tried these simple aggregation methods, but there has been work 2404.16994 using pooling to aggregate video tokens

Thanks for your quick reply! I will check it out.


Refactor hold/resume code to live in MediaHandler

Hi.
Still not quite there with making a pull request for our solution to reINVITE, but one thing we have discovered along the way is that the current handling of hold/resume is pretty messy.
I suggest moving all mangling/munging of the sdp to the mediahandler.
On setDescription it is very easy to store the SDP and inspect what changed if anything changed at all.
We can roll this into our new-mediahandler-per-transaction (if something changed that required an actual reINVITE or a handling of a reINVITE) way of doing things if the development team approves.

Moving SDP mangling out of the Session sounds good.  One of the MediaHandler's main roles is to take the knowledge of SDP away from the Session.  Not only should the MediaHandler be able to use a different backend, which may not need mangling, but it should also be free to specify a completely different content type for session description.
I'm not sure how tightly couple this would be to your MediaHandler-per-transaction work.  This would certainly be a smaller change, overall, and could be added or merged more quickly than the larger branch.

@wakamoleguy I totally agree with

Not only should the MediaHandler be able to use a different backend, which may not need mangling, but it should also be free to specify a completely different content type for session description.

I am currently looking at some "mixed/multipart" use cases described in RFC 5261, Section 4.1, and moving the message handling from Session—specifically the Content-Type header checks and .body accesses—into the MediaHandler would be a big win.
I think there may also be some interesting use cases for ORTC applications that do not natively support SDP. For example, once the MediaHandler takes over more of the description handling, an application could specify some JSON blob instead of SDP or use "multipart/alternative":

The transition from SDP to new session description protocols could be
implemented using 'multipart/alternative' bodies.  SIP messages
(e.g., INVITE requests) could carry a 'multipart/alternative' body
with two body parts: a session description written in SDP and a
session description written in a newer session description format.
Legacy recipient UAs would use the session description written in
SDP.  New recipient UAs would use the one written in the newer
format.

Where is this on the SIP.js roadmap? Glancing over the code, it seems like step 1 could be to change the signature for setDescription to accept a SIPMessage and to add a method to get a description from a SIPMessage. The getDescription name is already taken, so maybe getDescriptionFromMessage?

I think that this was sufficiently covered in #231. Going to close it, please re-open if there is anything outstanding.


use given creationTime for containers

NOTE: This is more of a question than a PR.
What does this PR do?
Fixes annotation of containers as from "Before" or "After" the agent started.
Motivation
pkg/autodiscovery/listeners/workloadmeta.go calculates creationTime based on the WLM semantics, which are that the first EventBundle a subscriber receives represents everything that happened "Before" the subscription, and all subsequent bundles are "After."  It passes this value to createContainerService in pkg/autodiscovery/listeners/container.go.  However, before this PR, that value was ignored and all containers were represented as services with creationTime: After.
I've verified this experimentally -- I see CreationTime: 1 (= After) in some debug logging of the integration.Config received by the logs agent's scheduler, for a container created before the agent was started.
Additional Notes
It looks like, before #9196, this was set to Before in init and to After in createService, presumably called after init.  Did this just get missed in the translation?
It appears this is broken in 7.33.0.
Possible Drawbacks / Trade-offs
All of this code is super-fragile and I do not have a complete understanding of the agent, so this "fix" may in fact be incorrect, or even if correct may have undesirable side effects.
Describe how to test/QA your changes
Start a container before the agent, and log some output from it.
Start the agent, configured to log that container (do this once each for container_collect_all,  container labels, and an integration config), and observe that it does not log the most recent output from the container.
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] The appropriate team/.. label has been applied, if known.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

A bunch of people did some deep digging on this, and it appears that, since 7.31.0 (and specifically #8637), docker-API-based tailing of containers running before the agent started (and which aren't in registry.json) are tailed from the beginning.  This has always been the case for file-based tailing of docker containers.
So, it's likely that merging this change will result in a behavior change, and that may not be what we want.


add feature matrix

Adding the initial feature matrix with some descriptions of the features captured in the matrix.
Signed-off-by: Alex Boten<EMAIL_ADDRESS>

@tsloughter @avzis updated the matrix based on your feedback, please take a look


 Add Pink End Crystal Beams from Legacy

Extracted Texture:

Here is the texture for textures/entity/end_crystal. However, End Crystal beams do not support semitransparent pixels by default on Java, so you may have to change it to allow those pixels like the Slime.

Added in version 1.3.3.


version conflicts when installing checks-superstaq and cirq-superstaq in series

What is happening?
I get a pip warning when trying to install checks-superstaq and cirq-superstaq in series from a fresh environment:
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
referencing 0.30.2 requires attrs>=22.2.0, but you have attrs 21.4.0 which is incompatible.

How can we reproduce the issue?
From a fresh python environment:
pip install checks-superstaq
pip install cirq-superstaq

This command ends with the above pip error, after which
$ pip check
referencing 0.30.2 has requirement attrs>=22.2.0, but you have attrs 21.4.0.

NOTE: there is NO ERROR if I instead run
pip install checks-superstaq cirq-superstaq

so we can plausibly declare this to be an issue with pip...
What should happen?
Everything should install without version conflicts
Environment
Fresh (empty) conda environment:
conda create --name test python=3.11
conda activate test

Any additional context?
No response

i think this is due to a downstream dependency of cirq-rigetti - hotfix is to pin
jsonschema~=4.17.3

to checks-superstaq/requirements.txt

Confirming that this pin does indeed solve the problem.  Should we add it?  Or just let the problem fix itself on the cirq-rigetti end?

With https://github.com/Infleqtion/client-superstaq/pull/883, cirq-superstaq has no dependency on cirq-rigetti (by only requiring cirq-core) so it seems this is no longer an issue.


Squash database migrations prior to v2.3

Issue type
[ ] Feature request
[ ] Bug report
[ ] Documentation
[x] Housekeeping
Environment

Python version:  3.5.2
NetBox version:  2.3.5

Description
Each time we make a change to the database schema (for example, adding a new field to a model), a migration containing the details of the change is generated. Over time, these migrations accumulate such that it takes slightly longer to construct a database with each new migration. Although migrations are applied only once each, either during the initial installation or an upgrade, they must all be applied each time a test is run. This means tests take somewhat longer than they need to.
It is possible to compress multiple migrations into one, provided they are linear in nature and reside in the same section of NetBox. Ideally, this should be done routinely, however we currently maintain all 120 or so individual migrations dating back to the original release. I'd like to begin squashing migrations with every minor release, beginning with v2.4.

make sense


v0.5.9

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

I'm closing this PR and will open the same against the 0.5.x branch.


slim-scroll scroll bar is not showing when using ng-repeat

slim-scroll scroll bar is not showing when using ng-repeat

Please give more details. may be a fiddle so that I can say something. AFAIK, this should work irrespective of ng-repeat or anything else.

Not showing at me to. :(
But I think that slimscroll cant get the height of the parent container and than the scroll bar get display:none; and height of the container.
If put to display:block; and add height:25px; itt will work, in my case.
Sorry for my bad english.

@BDominik please provide a simple test fiddle so that I can help you.

Hi.
I actually used ng-slimscroll from this site.
https://www.npmjs.com/package/ng-slimscroll
Not your version. But i think the promblem might be the same with booth

            {{logs.email}}
            {{formatDate(logs.created) | amCalendar }}

.items_holder div{
	display: block !important;
	height:25px !important;
}
Its helped for me.

This is really a problem.

@acivan  Hey can you please create a simple test fiddle to show the issue? I am good with JavaScript but not related frameworks like AngularJS. A fiddle help me a lot. Thanks.

Closing this ticket as there is no reply for long time.


Do you have a Flutter version?

Hi,
I hope you could provide a Flutter sersion.

https://github.com/AgoraIO/Flutter-RTM


Find with Regex Lookbehind

Issue Type: Bug

Regex for find:

(?<=\n)\w

Results:

Find (by currnet file editor) 🠊 normal.
Find in Files 🠊 Regexp parse error: lookbehind assertion is not fixed length

Regex for find:

(?<=\s)\w

Results:

Find (by currnet file editor) 🠊 normal.
Find in Files 🠊 normal.

VS Code version: Code 1.46.0 (a5d1cc28bb5da32ec67e86cc50f84c67cc690321, 2020-06-10T09:03:20.462Z)
OS version: Windows_NT x64 10.0.19041
Remote OS version: Linux x64 4.19.84-microsoft-standard

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-4200H CPU @ 2.80GHz (4 x 2794)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.92GB (1.35GB free)

Process Argv

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: ubuntu-19-04-server

OS
Linux x64 4.19.84-microsoft-standard

CPUs
Intel(R) Core(TM) i5-4200H CPU @ 2.80GHz (4 x 2793)

Memory (System)
6.14GB (4.78GB free)

VM
0%

Extensions (23)

Extension
Author (truncated)
Version

Angular-BeastCode
Mik
8.1.2

vscode-apache
mrm
1.2.0

remote-wsl
ms-
0.44.3

vscode-nginx
wil
0.7.2

commit-message-editor
ada
0.13.0

vscode-intelephense-client
bme
1.4.1

gitignore
cod
0.6.0

vscode-eslint
dba
2.1.5

githistory
don
0.6.5

vscode-powertools
ego
0.60.1

apacheconf-snippets
eim
1.3.0

php-cs-fixer
jun
0.1.154

vscode-phpfmt
kok
1.0.30

sshextension
kon
0.5.0

vscode-docker
ms-
1.3.1

sqltools
mtx
0.22.7

sqltools-driver-pg
mtx
0.0.5

vscode-yaml
red
0.8.0

format-html-in-php
rif
1.6.2

vscode-scss-formatter
sib
2.0.1

sass-indented
syl
1.8.6

language-stylus
sys
1.11.0

markdown-all-in-one
yzh
3.0.0

This is because I try to normalize the newline to \r?\n

I "stumbled" on this as a workaround:
(?<=[\n])\w
Making the \n into a character class of its own seems to work.  At least on Windows10.  Test on your OS.
Perhaps @roblourens can explain why.  Does the character class version not get expanded to \r?\n.?  Will [\r\n] work in more situations?

It does get expanded but in that case, \r is also inside the character class and the whole thing matches a single character, thus is still "fixed length"

A possible solution that comes to mind, is to instead of directly expanding \n in a lookbehind, expand it to ((LOOKBEHIND_WITH_R)(...))|((LOOKBEHIND_WITHOUT_R)(...))
This would probably be terrible for performance, but maybe better than having to use [\n] in lookbehind (and actually being unable to search exactly only for \n).
Example
Instead of (?<=\n)\w ↦ (?<=\r?\n)\w,
do (?<=\n)\w ↦ ((?<=\r\n)\w)|((?<=\n)\w).

We will no longer normalize CRLF in lookbehinds. And will do so more intelligently in other cases.

Issue Type: Bug

Regex for find:

(?<=\n)\w

Results:

Find (by currnet file editor) 🠊 normal.

Find in Files 🠊 Regexp parse error: lookbehind assertion is not fixed length

Regex for find:

(?<=\s)\w

Results:

Find (by currnet file editor) 🠊 normal.

Find in Files 🠊 normal.

 However on windows I only see a workspace search for (?<=\n)\w returning results from open files. This may be expected but it seemed odd

Actually nevermind, I still see errors in the developer tools:
Repro

On windows in the VS Code Codebase
Do a workspace search for (?<=\n)\w
Open Developer tools

I see lots of errors that look like:
[IPC Library: Search] Uncaught Exception:  TypeError: Cannot read property 'startLineNumber' of undefined
    at c:\Users\matb\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\search\node\searchApp.js:172:869
    at new t.TextSearchMatch (c:\Users\matb\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\search\node\searchApp.js:172:966)
    at Object.t.createTextSearchResult (c:\Users\matb\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\search\node\searchApp.js:183:949)
    at y.createTextSearchMatch (c:\Users\matb\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\search\node\searchApp.js:210:624)
    at y.handleLine (c:\Users\matb\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\search\node\searchApp.js:209:618)
    at y.handleDecodedData (c:\Users\matb\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\search\node\searchApp.js:209:312)
    at y.handleData (c:\Users\matb\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\search\node\searchApp.js:209:133)
    at Socket.<anonymous> (c:\Users\matb\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\search\node\searchApp.js:208:77)
    at Socket.emit (events.js:228:7)
    at addChunk (_stream_readable.js:309:12)
    at readableAddChunk (_stream_readable.js:290:11)
    at Socket.Readable.push (_stream_readable.js:224:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:181:23)
t.log @ workbench.desktop.main.js:sourcemap:310

There errors are not shown to the user so I was not aware they were happening until checking the dev tools

That looks like a quirk in ripgrep, they return results without any submatches. This would have had the same error before my changes (if it were possible to execute the search) and I'm sure there are other times people ran into this. It seems like a questionable bug in ripgrep. I put in a small patch to have the range behavior be the same as what the file matcher does, just showing the first character as the selection

cc @roblourens

That upstream issue is https://github.com/BurntSushi/ripgrep/issues/1412, thought it was handled, maybe it got lost. Thanks for the fix @connor4312


Please provide external table support for Oracle's TIMESTAMP and CLOB field types

Feature request
Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

dup with #21702


Git changes not show in the file explorer

VSCode Version:
OS Version:
Version: 1.41.1
Commit: 26076a4de974ead31f97692a0d32f90d735645c0
Date: 2019-12-18T14:57:51.166Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 17.7.0

Steps to Reproduce:

I can't see the git changes in a specific folder

But I can see the changes in source control

Does this issue occur when all extensions are disabled?: Yes/No

I think I found the issue, before, I changed my folder names.
Originally there were src/pages but I changed it to src/Pages. Renaming to pages working for me.
Thank you for your time and help.

I had the same issue, had to use the terminal until I found the fix. Turns out one of the extensions was initialising or trying to but couldn't. In my case it was the angular language service extension and since I was working on a react project, I disabled this for the workspace (from extensions, click on the gear button then select Disable (Workspace)) and after the reload Git explorer was back.
Maybe this could help someone.


Fail execution if output_variables has invalid entries

Current behavior

In the output_variables list at the multi_bmi level, if the user provides a variable that does not exist in the BMIs, then the framework ignores that high-level output_variables list and outputs the variables of the vary last BMI instead of throwing an error

Expected behavior

If a variable listed in the output_variables at the multi_bmi level does not exist, the framework should stop the execution and let the user know that the variable(s) provided does not exist in any of the BMI output variables

Screenshots
If all variables in the output_variables exist in the BMIs, the output looks like this

and when a variable var_DNE does not exist, the output looks like this -- a mismatch between the header size and the data points.

The realization file used in the above examples is attached here (CFE+PET+SLoTH example).
realization_cfe_pet.json.zip

@stcui007 ... Per discussion we had earlier, I double-checked and in this example file the output_variables and output_header_fields are in the right place--that is, the top-level of the multi-BMI formulation, not on the last BMI module inside the multi-BMI. So this is a valid issue and the example is good.

@Matthew Williamson - NOAA Federal @.***>   I did
run some tests with the provided config file last week. So we want to make
the change to the ngen code so that it complies with the Expected behavior?
On Fri, Jul 7, 2023 at 3:35 PM Matt Williamson @.***>
wrote:

@stcui007 https://github.com/stcui007 ... Per discussion we had
earlier, I double-checked and in this example file the output_variables
and output_header_fields are in the right place--that is, the top-level
of the multi-BMI formulation, not on the last BMI module inside the
multi-BMI. So this is a valid issue and the example is good.
—
Reply to this email directly, view it on GitHub
https://github.com/NOAA-OWP/ngen/issues/535#issuecomment-1626057467, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACA4SRL3BNC2UYVPKWYE7NLXPBXJBANCNFSM6AAAAAAZN57HQU
.
You are receiving this because you were mentioned.Message ID:
@.***>


[Feature Request] Readline or equivalent for search prompt in terminal.

It would be nice for the program to have support for GNU Readline or some equivalent tool. That would allow access the search history, make changes and corrections efficiently, etc.

This is already implemented, using https://metacpan.org/release/Term-ReadLine-Gnu
Make sure to have that module installed and set history => 1 in the configuration file.

I installed the package on my system and changed the config file. It's working great, thank you.


Add the Day/Night Theme in the navbar

Description
Is your feature request related to a problem? Please describe.
As i want to add the Day / Night Button to the nav bar with attractive look and animation in the button
Describe the solution you'd like
It looks attractive and eye catches
Screenshots or Mockups (optional)

Want to add Day/Night Button in the navbar


ctrl+left & ctrl+right enabled, but not working

/etc/inputrc shows the forward-word and backward-work shortcuts are enabled, but they do not actually work. The expected behavior is ctrl+left and ctrl+right should move the terminal cursor by an entire word at a time.

Not sure if this is related, but CTRL+A also doesn't move to the beginning of the line.

Hmmm. I came here about Ctrl+A (which is absolutely essential for me), but the fact that /etc/inputrc isn't apparently honored is interesting. Must check termcap and its funny little quirks when I have time.
Meanwhile, maybe this issue should be used to consolidate console input bugs?

So @sunilmut has a fix on the way for Ctrl+A (as well as Ctrl-@ and Ctrl+Space which was also misbehaving).
I'm looking at Ctrl+Arrows right now and I think I have a fix on the way as well.

That is awesome news for those of us with those reflexes hard-wired in. Thanks for letting us know!

On 20 Apr 2016, at 17:52, Mike Griese<EMAIL_ADDRESS>wrote:
So @sunilmut has a fix on the way for Ctrl+A (as well as Ctrl-@ and Ctrl+Space which was also misbehaving).
I'm looking at Ctrl+Arrows right now and I think I have a fix on the way as well.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub

Working on a fix.

@bitcrazed @zadjii-msft  Ctrl+A is working in 14366, but ctrl+left and ctrl+right are not.  Is this expected?

This should have been fixed in AU, and support for Shift/Alt+Arrows should also be in insiders as well.


File permissions validations

What this PR does / why we need it:
Adds validations to ensure 600 permissions on id_rsa, ssh_config and vault_root_token
fixes #170
/assign @charlieegan3
NONE

I've looked over this and the code changes look fine.
When I have the incorrect permissions set now I get the following error:
FATA[0005] Tarmak exited with an error: failed to validate tarmak: 2 errors occurred:

* vault root token file '/home/charlieegan3/.tarmak/charlie/vault_root_token' does not match permissions (0600): -r--------
* '/home/charlieegan3/.tarmak/charlie/id_rsa' does not match permissions (0600): -r--------  error="failed to validate tarmak: 2 errors occurred:\n\n* vault root token file '/home/charlieegan3/.tarmak/charlie/vault_root_token' does not match permissions (0600): -r--------\n* '/home/charlieegan3/.tarmak/charlie/id_rsa' does not match permissions (0600): -r--------"

Clearly a huge improvement on the output in #170.

/lgtm

/unassign
/assign @simonswine

@simonswine

/assign @simonswine

/unassign


lootr loot table errored out and had nothing in it

The error code i got in my server
loot table 'dungeons_arise:chests/mines_treasure_medium' couldn't be resolved! Please search the loot table in latest.log to see if there are errors in loading.
[29Nov.2024 19:56:19.435] [Server thread/ERROR] [noobanidus.mods.lootr.api.LootrAPI/]: Unable to fill loot barrel in minecraft:overworld at BlockPos{x=151, y=98, z=2} as the
i was on a multiplayer server alone.

This is an issue with dungeons_arise: their structure refers to a loot table that no longer exists in the mod (or the mod itself has been removed). While Lootr can report this, it's not an issue with Lootr, but rather the mod mentioned. I'd suggest updating the mod, or checking out its issue tracker to see if it's a known problem.


CVE-2023-24329 on slim-bullseye

Getting CVE-2023-24329 on these newly downloaded images when scanning with Twistlock:
python:3.7.16-slim-bullseye
python:3.8.16-slim-bullseye
python:3.9.16-slim-bullseye
Is this a false positive?

It is not wrong, but there are no backported fixes in Python upstream for those release series. They may not even consider it a vulnerability: https://github.com/python/cpython/issues/102153#issuecomment-1462714212 and maybe it isn't even fixed in 3.11 either :shrug:.


login button is disabled in the login page

on playground.dev.grid.tf
there're also no errors in the console

should be fixed in https://github.com/threefoldtech/tfgrid-sdk-ts/pull/661

fixed and verified


The daytona api-key new cannot be copy pasted.

Describe the bug
The daytona api-key new cannot be copy pasted.
To Reproduce
daytona api-key new
You can connect to the Daytona Server from a client machine by running:
daytona profile add -a \
https://api-XXXXX.try-eu.daytona.app \
-k **********************************
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. Ubuntu 22.04]
Daytona Version: 0.25.2

Additional context
Add any other context about the problem here.

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

@Tpuljak

I can see that If we don't use backslash( \ ) then the commands works perfectly fine. also we if we print it in single line then that would be useful because copying text from terminal also add terminal trailing whitespaces which causes problem with the command along with backslash. We can also add ' text copied to your clipboard to improve UX'

@Tpuljak  I can see that If we don't use backslash( \ ) then the commands works perfectly fine. also we if we print it in single line then that would be useful because copying text from terminal also add terminal trailing whitespaces which causes problem with the command along with backslash. We can also add ' text copied to your clipboard to improve UX'

@divgro9 all valid points! I also like the auto-copy to clipboard feature.

@divgro9 no requirements. You are free to suggest changes in a PR while keeping in mind good code practices.

@Tpuljak Thank you for your input! I've integrated the clipboard functionality into the api-key new command, making it easier to copy and paste. This update should improve user experience by avoiding issues with trailing whitespaces. Let me know if any further adjustments are necessary, and I’m happy to make changes as needed.

@idagelic The auto-copy to clipboard is definitely a game changer


can't run atomkraft without .atomkraft directory

The project directory logic includes .atomkraft/config.toml file.
https://github.com/informalsystems/atomkraft/blob/e18c3ab78f04d7431180aab82495e390cd7dddb1/atomkraft/utils/project.py#L17-L27
This creates problems when someone tries to git-clone a project and execute atomkraft in it.
You are outside of Atomkraft project
...

I suggest checking only for a valid atomkraft.toml in a directory.

Hi @rnbguy,
Cloning https://github.com/informalsystems/atomkraft-cosmos does include .atomkraft/ dir and atomkraft command does identify it as valid project.
If a project does not have these 3 toml config files, then giving user the prompt to populate these config files with default config might work. Or this can be done in atomkraft init . after doing cd <projectDir> just like git init . does.

hey @udit-gulati , cloning a fresh atomkraft-cosmos works fine at my end, but I only tried the main branch. can you share any details of your set up?

This creates problems when someone tries to git-clone a project and execute atomkraft in it.
You are outside of Atomkraft project
...

I suggest checking only for a valid atomkraft.toml in a directory.

@rnbguy it works fine on my end too. I was just mentioning that git cloning atomkraft-cosmos does include .atomkarft/ directory so this issue does not occur.

ah yes, you're right - I misread your comment.
When I created atomkraft-cosmos I was aware of this, so I manually fixed it by creating an empty .atomkraft/config.toml.
Thanks for your suggestions. We wanted .atomkraft/config.toml to represent the local atomkraft project config and execution state. That's why we wanted to exclude it from git history. So prompting the user when it is not present is a good idea :+1: Thanks


Provide function to rerun current route

If I'm currently at /foo, Router.go 'foo' does nothing. I would like some way to rerun /foo's action hooks and rendering. I know I could make a dependency, mention it in an action hook, and invalidate it when I need to reload, but it would be cleaner if there was a Router.* api.

Reference: http://stackoverflow.com/questions/28338091/how-do-i-reload-the-current-ironrouter-route


Tests are much slower since 22

Version
1.0.0-beta.22
Steps to reproduce
VueTestUtils + Jest + snapsnots are slower since beta 22
What is expected?
My tests use to last 70 seconds (900 tests, 70 snapshots) during VTU beta 20.
What is actually happening?
Now they last 170 seconds (900 tests, 70 snapshots) during VTU beta 22

I don't know why it is so slow, but I believe this should be fastened

Yes we should make sure tests are as fast as possible.
Are you able to provide me a repo that demonstrates the slower tests? That way I can investigate perf improvements.

Sorry I am not allowed.
Maybe I will create a personal project to help.

We have inconsistence when passing tests. (some simple tests needs 8seconds)
Sometimes all tests on our pipeline lasts more than 1 hour
Sometimes all tests on our pipeline lasts 170-250 seconds...
I don't know what happen but I think we will go back to beta 20.

This is one test that lasts 8 min on our pipeline https://codesandbox.io/s/308vv8l08p

Long tests are fixed in beta 24. I don't know why. Thanks for that.
But I stil have test times that is multiplied by 2. I will investigate

After investigation, I notice that Jest RAM consumption has exploded from beta 20 to beta 24.
That provokes long tests, timeout on my Docker, ...

Thanks for the reproduction.
I'm failing to replicate your results on my machine, I actually get a shorter time on beta.24 (~10s) compared to beta.20 (~13s).
I've been profiling the vue-test-utils tests and can't see any obvious expensive function calls. I'll keep investigating, because it's important that Vue Test Utils is fast.

Are you using the good branch? the branch vue-test-utils-perf?
On my Mac with 16 Go of RAM, it's 32seconds.
The time of 10 seconds is close to my time without the thousands of duplicated tests...

Thanks, I switched branches and profiled. The functions that are taking the longest are internal calls to createLocalVue, and external calls to Vue.use.
I'm going to open a PR to minimize internal createLocalVue calls. I'll continue investigating and improving performance.

I don't know if it's related to this, but when running tests with mocha-webpack --watch, we occasionally see tests slow to a crawl, and node sometimes dies entirely with a stack trace/core dump. This points (in my mind) to a memory leak somewhere, but I have no clue if it's in mocha, mocha-webpack, vue-test-utils, or elsewhere.
I'd be happy to post the stack trace or do some other investigation next time this happens - if you have any debugging/profiling recommendations, I would be appreciative!

I haven't been noticing tests slowing down, but I only have 300 tests so it might not be noticiable yet, but lately the node heap has been running out of memory. I'm running the tests with using Karma and mocha and this plugin for Vue CLI 3 (https://www.npmjs.com/package/vue-cli-plugin-unit-karma). When running with the watch flag the heap runs out of memory after running two or three times.

You just need to duplicate 4-5 times your tests (especially the one with
mounting options and snapshots...) to replicate and see the difference...
Personally I increased the RAM level on my Gitlab
And it works.
Le mer. 28 nov. 2018 à 18:14, Brian Brenner<EMAIL_ADDRESS>a
écrit :

I haven't been noticing tests slowing down, but I only have 300 tests so
it might not be noticiable yet, but lately the node heap has been running
out of memory. I'm running the tests with using Karma and mocha and this
plugin for Vue CLI 3 (
https://www.npmjs.com/package/vue-cli-plugin-unit-karma). When running
with the watch flag the heap runs out of memory after running two or three
times.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vuejs/vue-test-utils/issues/892#issuecomment-442528196,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH-dRlFYXWd1ygZHgR8q0WhV6RkGM4Moks5uzsRwgaJpZM4VslAS
.

--
Pierre Trollé


Export a Result<T, Error> alias?

I find myself putting:
pub type Result<T> = std::result::Result<T, Error>;

everywhere I'm setting up failure error types. I ended up doing that so much that I created a failure_ext crate that just re-exports failure and adds a few things, including that.
Should it just be moved to failure itself?

Why are you using full path std::result::Result? It's the part of language prelude, you can use it just like Result

type Result<T> = Result<T, Error>;

doesn't work: "unsupported cyclic reference between types/traits detected"

You make great points, @withoutboats.

My own opinion is that shadowing the names Result and Error has been a big mistake.

Yeah, I definitely agree with this. It was a stumbling block for me, too. I remember staring at the docs for io APIs and trying to make sense of the fact that Result only took one argument.

Is it really preferable to use FailureResult or ErrorResult

I agree that FailureResult and ErrorResult are baffling. :)

or Fallible?

I think Fallible is pretty beautiful! The idea of this library is to sort of create a universal adapter representing failure, and so it can be thought of as a general encoding of fallibility. We can even refer in English to "a fallible T" to mean a Result using the failure library whose success value is of type T.
I think it's especially nice that "Fallible" is a bit of unclaimed territory in the "global namespace" of the Rust ecosystem. At least for me it would me I'd be less inclined to explicitly namespace it. Today, I tend to import failure and then refer to Error as failure::Error since "Error" is such a generic name. But this gets really noisy.
Just to get a realistic feel, I took a module from a project I'm working on and did an A/B comparison so we could see how Fallible would look in the wild:
https://gist.github.com/dherman/960c27c6eff32b3c3686ebca9956d85e
See what you think!

I always create an alias too, and I generally call it Fallible.

(That said, the E type in my alias is usually my library's private error type.)

I'm super duper late to this, and the time has long since passed for this. That in mind though, this is something I just ran across today (the Fallible type alias) and was somewhat surprised it existed with that name! I'd love to use "vanilla failure" in Cargo but I'm somewhat resistant to lose the word "result" in the return type of all functions (currently called CargoResult for weird historical reasons).
I completely agree though in that io::Result and fmt::Result are a little odd and I'm not always comfortable with them. That being said, one thing we can do with the 2018 edition is:
// no extern crate

// ...

// no `use`!

fn foo() -> failure::Result<()> {
}

In the 2018 edition no imports are necessary (and no shadowing!). Just food for thought :)


FatOscillator: unknown behavior changes since 13.8.25

May not exactly be a bug, but FatOscillators played in a PolySynth sound different compared to 13.8.25, and I don't see them mentioned in the changelog so I'm having a hard time understanding what changed. I see we no longer specify voiceCount for PolySynth, so it may be related to that, but I don't see why that would change how FatOscillators are played/how they sound.
It sounds to me like "phase collision" (probably my made up name), where multiple oscillators play at the same phase so we get this odd beam/lazer sound in the background, it kind of sounds like there's a pitch bend going downwards for a part of the synth.
https://jsfiddle.net/uLptm5ck/5/
This example (in 14.7.40, the latest) will first play a chord with a fatsawtooth, where you can hear the odd phasing sound.
Afterwards, it plays the same chord with a regular sawtooth, which sounds clean.
With the same code in 13.8.25 (with an added voiceCount argument to the PolySynth constructor), the fatsawtooth chord would sound more "clean" similarly to the regular sawtooth one here, without the odd phasing noise: https://jsfiddle.net/9ejh4mtr/
You will probably need to re-run the fiddle to ensure the first chord's notes are played simultaneously. When they're slightly offset (whether it's intentional or from lag), it sounds clean which reinforces that this is likely related to the osc's phases.
This is very possibly the expected/desired default behavior, but I would like to see it mentioned in the changelog or explained otherwise because I'm not too sure how to approach this "problem". I could think of ways to randomize each voices' phase, but since they're dynamically created and disposed, it seems like that would be a very tedious and needlessly intensive process.
edit: the problem may be that the phases are offset rather than synced, I forget which causes this kind of sound. Either way, I mostly just want to understand what has changed so I could reliably go back to the old behavior

Good catch! the phase was not being offset correctly which was causing the phaser-y sound of the oscillators. Just pushed a change which should fix that.


M3-5614: Update stories for Tags

Description
Cleanup the stories for Tags and convert the components to FC
How to test

Run yarn storybook and go to http://localhost:6006/?path=/docs/ui-elements-tags-tag--tag
Check the app for regressions

Oops, didn't realize this was a WIP, I'll make sure to re-review.


Which driver for Eurolite USB-DMX512 Interface?

Can I use one of the preset drivers for an Eurolite USB-DMX512 Interface or do I have to find/develop a new one?

To my findings the Eurolite usb dmx512 pro mk2 works using the enttec-usb-dmx-pro driver.
No modifications needed. I tested on Mac and Linux.

Thank you for testing, but the problem is, in our school we only have the "normal" version of the interface, not the Pro (mk2).
But maybe this works as well. I think I test it out, when I'm in school next time.


add hindi Language to website

I would like to add one more Language to the website which will help the users of India and increase userbase from India

please assign it to me


I have a requirement to show more than 100 nodes to be shown on an jstree.Can you help me out how to acheive it ? Problem here is all the 260 nodes are child to a single node.

No duplicate IDs and all that nodes are there in Database

Please keep the discussion to a single ticket - I already answered there.


Construct a set of data types to test data-model from SDKs side

The Problem
There are a lot of data types in Iroha Data Model. Each SDK (Java, Swift, JS etc) has to generate the schema and test generated codecs with heavy e2e tests to cover ideally each data type.
The Solution
Core team could generate a set of data type samples with their encoded form, thus SDK developers can re-use it on their own to ensure the correctness of their SCALE infrastructure.
It could:

reduce tests duplication between SDKs
reduce amount of heavy e2e tests in SDKs
increase e2e tests "precision" due to moving of "data-model failure noise" into another scope

Created such samples for JS SDK: output.json.

@appetrosyan, here is a permalink.


Fix/requirements update

Codecov Report

Merging #62 (5760113) into master (597cdcd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   81.93%   81.93%
=======================================
  Files          25       25
  Lines        1046     1046
=======================================
  Hits          857      857
  Misses        189      189

Flag
Coverage Δ

unittests
81.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


[UI] Add spinners to import buttons

Currently the import buttons on any of the admin interfaces do not show that they're working. Change the UI to where the button:

Is Disabled (we don't want them clicking multiple times)
Is Yellow (to indicate something changed)
Has a spinner icon (to indicate "progress")

Once the loading is done, restore the button to its previous state.

Repro steps

Login with username and password from seeds.rb
Click on ADMIN button
Import buttons are under Speakers, Stories, and Places


reInitLayer does not accept geojson layer

I tried to create a GeoJSON layer and it was immediately grabbed by geoman allowing me to edit shapes. Though I don't need it to be editable all the time. So I added the pmIgnore option to the geojson layer. Then I tried to use these lines from docs
layer.options.pmIgnore = false;
L.PM.reInitLayer(layer);

Though seems like reInitLayer doesn't accept geojson layer.
Actual: nothing happened if you use geojson layer
Expected: geojson layer becomes editable
Reproduction example

You are right, a LayerGroup ( GeoJSON too) not working to reinit the layers, it's a bug. Currently it loops through all layers in the LayerGroup and reinit each layer instead of the whole group.
So if you call layer.options.pmIgnore=false the property is only on the GeoJSON-layer changed. If you use setStyle() the option pmIgnore is passed to all childs of the group too and it works.
Workaround for the layer childs:
layer.setStyle({pmIgnore: false});
L.PM.reInitLayer(layer);

If you need Geoman working on the GeoJSON-Layer you can call:
layer.pm = new L.PM.Edit.LayerGroup(layer);


Reversing Links

Program for a singly linked circular List which reverses the direction of the links

@bhaveshlohana  This PR isn't getting counted for hacktober-fest, can u add the label


Another way to implement _AFURLSessionTaskSwizzling

The implementation looks unreliable currently. The following way will be more reliable in my opinion. Accept it if you think so.  I find all subclasses of NSURLSessionTask in CFNetwork framework, and add af_resume method if subclass has define resume, then exchange af_resume and resume method. Suspend method do in the same way.
// Find CFNetwork framework. Subclasses of NSURLSessionTask define in CFNetwork framework currently.
unsigned int imageCount = 0;
const char *imageName = NULL;
const char * _Nonnull * _Nonnull imageNames = objc_copyImageNames(&imageCount);
for (int imageIndex = 0; imageIndex < imageCount; imageIndex++)
{
imageName = imageNames[imageIndex];
size_t nameLength = strlen(imageName);
if (nameLength >= 9 && strcmp(imageName + nameLength - 9, "CFNetwork") == 0)
{
break;
}
imageName = NULL;
}
free(imageNames);
if (imageName == NULL) return;
Method resumeMethod = class_getInstanceMethod(self, @selector(af_resume));
Method suspendMethod = class_getInstanceMethod(self, @selector(af_suspend));

unsigned int classCount = 0;
const char * _Nonnull * _Nullable classNames = objc_copyClassNamesForImage(imageName, &classCount);
for (int classIndex = 0; classIndex < classCount; classIndex++)
{
    // Check whether currentClass is a subclass of NSURLSessionTask
    Class class = objc_getClass(classNames[classIndex]);
    Class currentClass = class;
    while (currentClass != NULL && currentClass != NSObject.class)
    {
        if (currentClass == NSURLSessionTask.class)
        {
            currentClass = class;
            break;
        }
        currentClass = class_getSuperclass(currentClass);
    }

    if (currentClass == NULL || currentClass == NSObject.class) continue;

    // If currentClass define resume method, add af_resume method for currentClass and exchange them. Suspend method do in the same way.
    unsigned int methodCount = 0;
    Method *methods = class_copyMethodList(currentClass, &methodCount);
    for (int methodIndex = 0; methodIndex < methodCount; methodIndex++)
    {
        Method method = methods[methodIndex];
        SEL methodName = method_getName(method);
        if (sel_isEqual(methodName, @selector(resume)))
        {
            class_addMethod(currentClass, @selector(af_resume),  method_getImplementation(resumeMethod),  method_getTypeEncoding(resumeMethod));
            Method exchangeMethod = class_getInstanceMethod(currentClass, @selector(af_resume));
            method_exchangeImplementations(method, exchangeMethod);
        }
        else if (sel_isEqual(methodName, @selector(suspend)))
        {
            class_addMethod(currentClass, @selector(af_suspend),  method_getImplementation(suspendMethod),  method_getTypeEncoding(suspendMethod));
            Method exchangeMethod = class_getInstanceMethod(currentClass, @selector(af_suspend));
            method_exchangeImplementations(method, exchangeMethod);
        }
    }
    free(methods);
}
free(classNames);

Does this fix https://github.com/AFNetworking/AFNetworking/issues/3303?
Although that issue is closed for lack of activity, it is still affecting people today - see most recent comments

Does this fix #3303?
Although that issue is closed for lack of activity, it is still affecting people today - see most recent comments

I don't test the problem in fix #3303 , but i think this problem are caused by allocating object and calling method in load method. The object you alloc may not ready in that time, that will cause  some uncertain case. I think my implementation can avoid this problem. You can try it.


incorrect documentation in README for installing github.com/elastic/go-elasticsearch/v8@master

The README suggests adding the following to the go.mod file during installation:
require github.com/elastic/go-elasticsearch/v8 master

However, doing do will result in the following error:
go.mod|8| require github.com/elastic/go-elasticsearch/v8: version "master" invalid: must be of the form v1.2.3

Instead you should run go get github.com/elastic/go-elasticsearch/v8
It also seems the latest stable version if v7.3.0, so should we be fetching github.com/elastic/go-elasticsearch/v7 instead?

It seems that the error:
go.mod|8| require github.com/elastic/go-elasticsearch/v8: version "master" invalid: must be of the form v1.2.3

is actually an issue with my editor.
However, the product page refers to v7.3.2 as the latest stable version, so it might be useful for the README to reference that client version as well.

Hello, I’m currently on a vacation, will have a proper look when I’m back.
One thing to note is that the README on the master branch intentionally lists v8/master, since that particular branch follows the Elasticsearch master.
The 7.x and 6.x have a different version in README, since they target corresponding versions of Elasticsearch.

On 19 Sep 2019, at 23:17, Julie Qiu<EMAIL_ADDRESS>wrote:
It seems that the error:
go.mod|8| require github.com/elastic/go-elasticsearch/v8: version "master" invalid: must be of the form v1.2.3
is actually an issue with my editor.
However, the product page refers to v7.3.2 as the latest stable version, so it might be useful for the README to reference that client version as well.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi, returning to this issue. The Compatibility part of the README says clearly, to my eyes, that you have to use a major version of the client corresponding to the major version of Elasticsearch. I'm not sure if I can make the text any more clear... I'll close the issue if it's OK — please re-open or open a new one if you run into issues.


Inactive GH users

Background
Latest list of inactive GH users is ready at https://github.com/ministryofjustice/remove-inactive-users/runs/7517130271?check_suite_focus=true
Additionally users to contact / remove: https://github.com/ministryofjustice/remove-inactive-users/runs/7520434903?check_suite_focus=true
Proposed user journey
Attempt contact with users or team to see if user requires a GH seat, if not remove.

Email each user in the list from the above url ^^^^

Email each user in the list from the above url ^^^^

Do not remove these user accounts:
Jude-Luckett

Removed users:
myerscough
djeade

Users with no Email
AndrewRichardson76
JessBuildsTech
madan-thapa

On Leave:
haroonadalat

Email sent to users 23/08/2022 for end of Sept check:
andy-gg
beckthompson
ChandraSinghMoJ
creesedgw
Cybersun256
Ed-Bajo
Ethan-McDowall
jefferson-MoJ
JPSpencer
Kieronski
kiranannavarapu
mikekeen1
nathanrussell-moj-digital
paulmcqueen
peterscottreid
richardHattonMOJ
seanbusby
UchennaN

Updated the ^^^ document with users that have been removed, users that have been contacted to log in and the users that have no email and have no activity


npx expo-doctor giving plugin error

Describe the bug
npx expo-doctor command suddenly started giving PluginError: Failed to resolve plugin for module "@bugsnag/plugin-expo-eas-sourcemaps" relative to "/Users/expo/workingdir/build"
Steps to reproduce
run npx expo-doctor
Environment

Bugsnag version: 50:
Expo SDK version (SDK 50):
Device : iphone 15, xcode 15.2
expo-env-info 1.2.0 environment info:
System:
OS: macOS 13.6.4
Shell: 5.9 - /bin/zsh
Binaries:
Node: 20.11.0 - ~/.nvm/versions/node/v20.11.0/bin/node
Yarn: 1.22.21 - ~/.nvm/versions/node/v20.11.0/bin/yarn
npm: 10.2.4 - ~/.nvm/versions/node/v20.11.0/bin/npm
Managers:
CocoaPods: 1.15.2 - /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 23.2, iOS 17.2, macOS 14.2, tvOS 17.2, visionOS 1.0, watchOS 10.2
IDEs:
Xcode: 15.2/15C500b - /usr/bin/xcodebuild
npmPackages:
babel-preset-expo: ^10.0.2 => 10.0.2
expo: 50.0.21 => 50.0.21
expo-router: ~3.4.10 => 3.4.10
react: 18.2.0 => 18.2.0
react-native: 0.73.6 => 0.73.6
npmGlobalPackages:
eas-cli: 12.5.3
expo-cli: 6.3.10
Expo Workflow: bare

Error messages:
Running "expo doctor"
/Users/expo/.npm/_npx/c15e4b19a90d9797/node_modules/expo-doctor/build/index.js:89549
throw new (_errors().PluginError)(Failed to resolve plugin for module "${pluginReference}" relative to "${projectRoot}", 'PLUGIN_NOT_FOUND');
^
PluginError: Failed to resolve plugin for module "@bugsnag/plugin-expo-eas-sourcemaps" relative to "/Users/expo/workingdir/build"
at resolvePluginForModule (/Users/expo/.npm/_npx/c15e4b19a90d9797/node_modules/expo-doctor/build/index.js:89549:9)
at resolveConfigPluginFunctionWithInfo (/Users/expo/.npm/_npx/c15e4b19a90d9797/node_modules/expo-doctor/build/index.js:89598:7)
at resolveConfigPluginFunction (/Users/expo/.npm/_npx/c15e4b19a90d9797/node_modules/expo-doctor/build/index.js:89589:7)
at withStaticPlugin (/Users/expo/.npm/_npx/c15e4b19a90d9797/node_modules/expo-doctor/build/index.js:88669:70)
at /Users/expo/.npm/_npx/c15e4b19a90d9797/node_modules/expo-doctor/build/index.js:88510:84
at Array.reduce ()
at withPlugins (/Users/expo/.npm/_npx/c15e4b19a90d9797/node_modules/expo-doctor/build/index.js:88510:18)
at withConfigPlugins (/Users/expo/.npm/_npx/c15e4b19a90d9797/node_modules/expo-doctor/build/index.js:91158:47)
at fillAndReturnConfig (/Users/expo/.npm/_npx/c15e4b19a90d9797/node_modules/expo-doctor/build/index.js:90080:78)
at getConfig (/Users/expo/.npm/_npx/c15e4b19a90d9797/node_modules/expo-doctor/build/index.js:90137:10) {
isPluginError: true,
code: 'PLUGIN_NOT_FOUND',
cause: undefined
}
Node.js v18.18.0

Hi @yash2code
The error you’re seeing, PluginError: Failed to resolve plugin for module @bugsnag/plugin-expo-eas-sourcemaps, indicates that the Expo Doctor tool is unable to locate the @bugsnag/plugin-expo-eas-sourcemaps plugin.
Please try installing the plugin using npm install @bugsnag/plugin-expo-eas-sourcemaps
Clean your node folder and then running npm install.
If after installing the plugin using npm the issue still persists then please let us know and we can investigate further.

was issue from expo side. they have resolved it. closing this.


Stimuli

This is only partially functioning stimulus viewing functionality, but needing to merge into main due to some changes on the Stimulus model.


Updating the coding guidelines to recommend PoshStyle as the PowerShell coding guidelines

Our PowerShell code is currently using some random style (which is somewhat consistent within the files themselves, but are not necessarily consistent across files). This change updates our coding guidelines to recommend/reference the PoshCode style.
I've looked at some other resources both internal to Microsoft and externally visible as well (i.e. https://docs.microsoft.com/en-us/powershell/scripting/developer/cmdlet/strongly-encouraged-development-guidelines?view=powershell-6, and https://docs.microsoft.com/en-us/contribute/powershell/powershell-style-code) however none were as extensive as PoshCode.

/azp run mrtk_docs

/azp run mrtk_docs

Seems reasonable to me! Do we want to go through and update existing scripts to this style?

Short answer I think is yes, though I don't think I would trigger an immediate fixing of everything to match the style right now.
i.e. it makes sense to do it as folks make changes in the space, as they will already be testing stuff. Otherwise you run the risk of making style changes and introducing bugs. If you're already making changes and can consolidate the testing it probably makes sense


Deprecated Discord RPC

Operating system
Microsoft Windows [Versione 10.0.22631.3593]
YouTube Music Desktop App Version
v0.12.11
Bug description
Discord deprecated Discord RPC, in favor of GameSDK
So it doesn't work anymore
Steps to reproduce

Play track
No rich presence even if enabled

Relevant log output
No response

only the library has been deprecated, gamesdk still uses the activity of discord-rpc

still works but i'll migrate once libraries have been made

Okay, so it's probably a me issue, sorry! Closing the issue


Appreciation

Hey! I'd like to express my gratitude for this really well-made plugin, among several raw analogs it is definitely the best and very well done, thanks a lot to the developer! Despite the small number of stars I hope that the author did this project for himself among others and is not going to abandon it:) If you need any help - please create issues! and I'm sure there will be some kind enthusiasts among users (including me) to help you out. Thank you!

Hey @yahorbarkouski , thank you for the kind words! ❤  I try to keep this plugin's maintenance as low effort as possible, so that I don't burn out from it. But I'll keep your offer in mind. Thanks a lot!


Reuse parsed tree instead of import only

A simple fix of #228
This PR adds two field to LibrarySource

Ref<ImmutableSeq<Stmt>> as concrete trees which is initialized after resolving library imports
Ref<ResolveInfo> which I don't know whether can be reused by LSP (if not, we remove it then)

Coverage decreased? but how can it be?

bors r+ as it's good enough


Write metadata as well as read.

This package would be particularly useful if it could be used to write XML metadata as well as read it into python dataclasses.  Both @jmuhlich and @jacksonmaxfield have expressed an interest in for that in their applications, so just wanted to pin the topic here and connect you both.

Closed by #44 :tada:


[AzureMonitorExporter] add Activity Exception demo and test

Working on examples of recording an Exception with Activity.
Changes

add activity?.RecordException(ex); to our TraceDemo
add activity?.RecordException(ex); to unit test.

added helper method to verify exception.

API change check
API changes are not detected in this pull request.


choosing between pip2 and pip3

Is there a nice way to choose between reviewing package states for python 2/3?  I currently hack the source to switch between calling out to pip2 and pip3.
Maybe allowing multiple versions to coexist like pip does? I'd then be able to run pip3-review and pip2-review and have it see the "correct" packages.

Use separate virtualenvs for python2 and python3
Sent from my iPhone

On 24 июня 2015 г., at 18:13, Sam Mason<EMAIL_ADDRESS>wrote:
Is there a nice way to choose between reviewing package states for python 2/3? I currently hack the source to switch between calling out to pip2 and pip3.
Maybe allowing multiple versions to coexist like pip does? I'd then be able to run pip3-review and pip2-review and have it see the "correct" packages.
—
Reply to this email directly or view it on GitHub.

I've been putting off learning virtualenv for too long, looks like it's time to take the plunge…

@smason Sam, virtualenv is must have for python devlopment. I'm wincing remembering days when virtualenv didn't exist.

Alexander Artemenko wrote:

@smason Sam, virtualenv is must have for python devlopment. I'm
wincing remembering days when virtualenv didn't exis

Package/version dependencies haven't been much of an issue for
me—but then again, I've generally stuck with Python's standard
library…
Sam


[Blog Post] Tables are Hard, Part 1: History

Signed-off-by: Nick Lanam<EMAIL_ADDRESS>

The hero image referenced doesn't exist yet, but it will be added once it's ready (separate diff). The default hero image will be shown until then.


[2.6.4] Support certificate rotation for v2 clusters

issue: #35343
PROBLEM
The certificates on the machines need to be rotated at the user's request.  This may be because they are going to expire or the user has a new CA.  This feature allows users to update all or some of the certificates on their cluster via the rancher API.
SOLUTION
Using the same certificate rotation object as rke1 clusters You can define what certificates to rotate.  The rotation is controlled by the generation field on the certificate rotation object.  Once certificates have been rotated the controlplane status will be updated with the latest certificate generation.
In my testing I also discovered a bug where clusters would get stuck deleting if they have a bad machine-config.  The fix for this was small and is included in this pr.
TESTING

3 node rke2 cluster with all roles on all nodes
3 controlplane, 3 etcd, and 3 worker rke2 cluster

I tested these two cases with node drain enabled and disabled and on k3s clusters as well.
kubectl patch -n fleet-default --patch '{"spec":{"rkeConfig":{"rotateCertificates":{"caCertificates":true,"generation":1}}}}' --type=merge cluster/<cluster name>

@paynejacob From these changes, it looks like the cluster/control plane will not have any condition updates to indicate that something is happening with the cluster. Is this the case?
If it is, then I think it would be good to have a way to indicate to the user that certificates are rotating and when rotation is finished.

Talked about this offline: the cluster goes into an updating state while the plan is applied.