Refactor and fix IDE comments and warnings.

Would be great to use new C# features and fix warnings to fix possible errors. (Also maybe optimize a little the program (not sure about this one)).

I'd hold off on tackling thus until all major pull requests are out the way. I also disagree with microsoft's push for certain features such as always using the shorthand new in areas where it makes it difficult to read

I'd hold off on tackling thus until all major pull requests are out the way. I also disagree with microsoft's push for certain features such as always using the shorthand new in areas where it makes it difficult to read

at least is suggest to do caching in some areas.

Also when we will fix the JSON model classes like bosses and github related classes with new .NET 8 Json it will benefit with loading speed of classes since .NET 8 improved JSON.

I'd hold off on tackling thus until all major pull requests are out the way. I also disagree with microsoft's push for certain features such as always using the shorthand new in areas where it makes it difficult to read

Ye sometimes the new makes it worse rather than better 😓 in most places it is understandable though.

I'd hold off on tackling thus until all major pull requests are out the way. I also disagree with microsoft's push for certain features such as always using the shorthand new in areas where it makes it difficult to read

at least is suggest to do caching in some areas.

Things are starting to get cached more but it's more a case of doing it when and where it's needed rather than just doing caching for the sake of caching.
Overall I'm not strictly against resolving most of the warnings/messages Visual Studio is putting out, some of them are not helpful or more accuratly not relevant for what we are doing so would probably make more sense to disable those if it is that much of a bother.
What I would object to though is having them all in one PR as while Visual Studio is helpful sometimes some of the things it tells you to fix can actually just cause issues. So I'd suggest doing things in a targeted manner, like the first one which would probably remove most of these would be the JSON models BaseLocation and GiteaRelease you deal with them 95% of the things the IDE is saying will go away.

I'd hold off on tackling thus until all major pull requests are out the way. I also disagree with microsoft's push for certain features such as always using the shorthand new in areas where it makes it difficult to read

Ye sometimes the new makes it worse rather than better 😓 in most places it is understandable though.

I'd hold off on tackling thus until all major pull requests are out the way. I also disagree with microsoft's push for certain features such as always using the shorthand new in areas where it makes it difficult to read

at least is suggest to do caching in some areas.

Things are starting to get cached more but it's more a case of doing it when and where it's needed rather than just doing caching for the sake of caching.
Overall I'm not strictly against resolving most of the warnings/messages Visual Studio is putting out, some of them are not helpful or more accuratly not relevant for what we are doing so would probably make more sense to disable those if it is that much of a bother.
What I would object to though is having them all in one PR as while Visual Studio is helpful sometimes some of the things it tells you to fix can actually just cause issues. So I'd suggest doing things in a targeted manner, like the first one which would probably remove most of these would be the JSON models BaseLocation and GiteaRelease you deal with them 95% of the things the IDE is saying will go away.

Not really, it's saying to change the variable names and use JSON attribute as how class looked before. It will work the same.

I'd hold off on tackling thus until all major pull requests are out the way. I also disagree with microsoft's push for certain features such as always using the shorthand new in areas where it makes it difficult to read

Ye sometimes the new makes it worse rather than better 😓 in most places it is understandable though.

I'd hold off on tackling thus until all major pull requests are out the way. I also disagree with microsoft's push for certain features such as always using the shorthand new in areas where it makes it difficult to read

at least is suggest to do caching in some areas.

Things are starting to get cached more but it's more a case of doing it when and where it's needed rather than just doing caching for the sake of caching.
Overall I'm not strictly against resolving most of the warnings/messages Visual Studio is putting out, some of them are not helpful or more accuratly not relevant for what we are doing so would probably make more sense to disable those if it is that much of a bother.
What I would object to though is having them all in one PR as while Visual Studio is helpful sometimes some of the things it tells you to fix can actually just cause issues. So I'd suggest doing things in a targeted manner, like the first one which would probably remove most of these would be the JSON models BaseLocation and GiteaRelease you deal with them 95% of the things the IDE is saying will go away.

Not really, it's saying to change the variable names and use JSON attribute as how class looked before. It will work the same.

It might not seem like it but some suggestions can actually break things (first hand experience)
Either way a lot of code is going to replaced when all pull requests are closed out and they won't be up to date so my point stands that it's probably best to hold off

The main source of compiler noise left comes from the BaseLocation.cs file, at least after #207 is merged.
So I'm gonna close this now. If you want to tidy up that file please feel free, it'd also probably be an idea at the same time to give some love to the whole LocationEditorView as that's where it gets used but it doesn't seem to work that well :/


Remove password parameter from documentation

The -P command line parameter was removed with SSMS 18.0 due to security concerns. See this post on the SQL Server blog.
In the documentation, the parameter was still listed, which confused me while trying to automate opening SSMS connections.
Whether the extra paragraph with the explanation is necessary can be discussed, but it could make things clearer for people trying similar things.

@ymekesser : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ymekesser
Sorry for the delay, but this change has already been made to this article.
Thank you for your suggestion.
We will continue to close this PR.


Use /:path instead of ?path=:path to get contents

Passing path in the query string does not seem to work anymore with the Github API (I'm admittedly guilty of not seeking to know why). The API documentation says to use:
GET /repos/:owner/:repo/contents/:path

which is what this patch does (and it works ;-)).

@raphink Howdy, I'm helping maintain this. Mind updating your PR? Would love to merge it. Thanks! :+1: :shipit:

Also, this is a dupe of #127, or rather, that is a dupe of this. I don't care which I merge, will merge the one fixed fastest whilst closing the other. Thanks!

@aendrew Just rebased it.

:boom: :shipit: Merging! Thanks!


faster membership convergence

Look at membership convergence via membership update fanouts, with (at least) 2 known possible mechanisms:

burst increase of ping rate
manual/alternate additional update messages, possibly w/ NOOP instead of PING as underlying message?

Looking at initial baselining via https://github.com/uber/ringpop/pull/56, with the note that it is localhost only, and we will ultimately need something closer to reality.

:+1:  Fancy work w/ Github issues!


OpenFlow 1.5 support

Describe the problem/challenge you have
Antrea uses github.com/contiv/libOpenflow to configure Openflow rules to OVS. Currently the library only supports OpenFlow 1.3. It becomes a problem when we need some features introduced in new versions. For example, when fixing https://github.com/vmware-tanzu/antrea/issues/2092, the ideal solution is to use "insert-buckets" to update groups but the operation is only available in OpenFlow 1.5.
When introducing OpenFlow 1.5 support, we also need to take care of its impact on compatibility, like whether it requires more recent kernel module support.

There is a PR in libOpenflow to support OF1.5 https://github.com/antrea-io/libOpenflow/pull/13

Done in https://github.com/antrea-io/antrea/pull/3770


fix: add greenkeeper postpublish hook

Coverage remained the same at 100.0% when pulling 61c81b948d0b3445d6e49088a86f3c712f1a5841 on greenkeeper-postpublish into 835f4869ae9e02483c6397b3f60b64d70c312926 on master.


Provide PHP 8

[x] use extensions supporting PHP 8

[x] yaml #3
[x] vips #3
[x] redis #3
[x] imagick - blocked by https://github.com/Imagick/imagick/issues/358
[x] xdebug #4

[x] build support for PHP 8 #5

Testing will follow, then this can be closed…


Add option to send the user to a login box for the landing page

Summary: allow another configuration choice for the default landing page.
Changes: adds a new configuration choice login for the LandingPage option in pkg/setting/setting.go
Rationale: I send users directly to the login page when they visit the site rather than requiring them to click 'Sign in'. I am sharing this PR in case you thought that would be useful to others.

I believe you can accomplish the same thing with
REQUIRE_SIGNIN_VIEW = true

Ah. Even better. Thanks - I'll do that instead.


Use custom JSONEncoder / JSONDecoder on json decorators

When pulling data from a database (using PynamoDB, for example) we are often left with a "model" object which can not be directly serialized with json, unless a custom JSONEncoder is written.  Normally we pass this class in to the json.dumps() function.
It would be extremely useful to pass this special Encoder into the dump_json_body and similar decorators

See https://github.com/dschep/lambda-decorators/commit/5d6891f70483ee2d78ef023331677ed8a9619e61 which i'll release soon.


WXITime classes

We are currently supporting multiple time formats in several places:

pandas (DateTimeIndex, TimedeltaIndex, Timestamp)
numpy (time dtypes)
pint quantities
xarray structures with "time" and "time_ref" fields

Dealing with time as an additional dimension can actually be quite challenging when trying to enhance, understand or write new code. But also having to deal with those different types turns it into hell. For example, if I just want to compare if the last entry of a time array is less than the first entry of another one I need to figure out if I have relative (time delta) or absolute (dates) values and if they have matching types. Then I need to treat all cases separately. This bloats the code and makes it hard to understand.
Furthermore, the time property of our classes is not consistent regarding its return type. For example, the LCS returns a xarray structure, while the TimeSeries returns a TimedeltaIndex. The LCS also provides a special method to get time as a quantity to take away the need for type casts from the user.
My suggestion is, that we define a Time wrapper class, that serves multiple purposes. First, it should be an interface class that is always used when any public function returns a time type. Second, it should be constructable from all the classes that we currently use and provide methods to cast back to all those types like WXRotation does for rotations. Lastly, it should provide all the functionalities that we frequently need like calculating time unions and synchronizing reference times.
I would also like to keep time deltas and date times in a single class instead of having two separate classes (possibly three with timestamps). The class method implementations should deal with the compatibility of relative and absolute times so that we do not have to cover it separately every time we deal with time formats.
To make a suggestion of some of the possible interfaces:
class WXTime:

    def __init__(
        self,
        time : Union[DateTimeTypes, TimedeltaTypes, TimestampTypes, WXTime],
        time_ref : Union[TimestampTypes, WXTime],
    )

    def to_pandas(self) -> Union[TimedeltaIndex, DateTimeIndex, Timestamp]:

    def to_quantity(self) -> Quantity:

    @property
    def length(self) -> int:

    @property
    def has_reference_time(self) -> bool:

    @property
    def is_timestamp(self) -> bool:
        return self.lengt == 1 and self.has_reference_time

    @property
    def reference_time() -> WXTime:

    @reference_time.setter
    def reference_time( time_ref : Union[TimestampTypes, WXTime]):

    @staticmethod
    def time_union(times = List[WXTime]) -> WXTime:

    def __eq__(self, other:  Union[DateTimeTypes, TimedeltaTypes, TimestampTypes, WXTime]) ->bool:

    def  __le__(self, other:  Union[DateTimeTypes, TimedeltaTypes, TimestampTypes, WXTime]) ->bool:

    def all_close(self, other:  Union[DateTimeTypes, TimedeltaTypes, TimestampTypes, WXTime]) ->bool:

    def overlaps_with(self, other:  Union[DateTimeTypes, TimedeltaTypes, TimestampTypes, WXTime]) ->bool:

I think this will make our life and of our possible users a lot easier since it bundles all the time-related stuff in one place and unifies the code. What do you think?

I agree that this kind of interface/helper class should make things a lot easier in our codebase. We probably have all those code snippets needed in some point of the code already
it should also simplify things if we decide to change the backend of storing/working with time classes for performance reasons or similar
I'm not sure if we should use this class for all return values, specifically in cases where we already have an xarray structure with a time coordinate (which I think is the most common).
as an alternative (or extension) maybe we could define interfaces for classes that actually can have a time property and work from there?

We should also implement the corresponding __add__ and __sub__ functions

can you create a branch and open up a PR only containing the interface definitions for now with pass @vhirtham ? I would like to start discussion on the class definition soon and it is easier to follow in that format
for reference it might also be good to take a look at basic pandas index methods and see which of those could be convenient to implement as well (like min(), max() etc. )

can you create a branch and open up a PR only containing the interface definitions for now with pass @vhirtham ? I would like to start discussion on the class definition soon and it is easier to follow in that format

I was looking forward to finally start with this class the whole last week. Since all the 0.4.1 issues are finished (I will open the release PR later), we are finally there. I would suggest we proceed as follows:
I create a new branch in the WelDX repo for this issue and add all the interfaces and open a PR to discuss the details as you required. Then I already start drafting some implementations on a separate branch where I think that the behavior is pretty much clear (__init__ and type-specific accessors like .quantity, .timedeltaindex etc.) and open a PR targetting the main weldx.Time branch. We proceed the same way with the other implementations that we have discussed by then. This way we can review the implementations in small pieces rather than a large chunk.
I also think, that once the class is more or less feature complete, we merge it into master first without using it anywhere. Afterward, we add it class by class using separate branches to keep the mess as small as possible. This is probably a rather large task since time classes are used all over the place.

for reference it might also be good to take a look at basic pandas index methods and see which of those could be convenient to implement as well (like min(), max() etc. )

For now, I would like to focus on the functionality that we need for our already implemented classes. This is probably the largest task of the 0.5.0 milestone and there is already a lot to do. I guess the min() and max() will be required anyways (at least I know where we might need it) but I like to avoid implementing additional features we do not need yet. We can do this later.

I suggest putting the code into a new module weldx.time for now

Agreed. In the long run, I suggest refactoring the core module into multiple files and adding it there since it is such an important and basic class that it feels natural to me to look there first. Also, with the GenericSeries on the radar, the core module will need this refactoring anyways at some point 😉

yes, let's have a longer talk tomorrow going over the interfaces before diving into the implementation, we can see how complicated it will get with the individual features
also eager to have that tool ready 🔥
moving the discussion to #433 from here


multiple arch docker images support

🚀 Feature Request
Relevant Package

all services docker images
Description

It is not a good idea to use different docker images to distinguish different CPU architectures.
edgexfoundry/docker-core-data-go:1.2.0
edgexfoundry/docker-core-data-go-arm64:1.2.0

Describe the solution you'd like

Why we don't use different image layer to distinguish different CPU architectures.

Docker 19.03+ support docker buildx to build images of multiple architectures at once, and it doesn't need to change something many.
At least our official images can support multiple architectures.
Describe alternatives you've considered

If we use  multiple arch images, we don't need to maintain multiple compose files or other k8s files.

BTW, we can use docker manifest to merge different images into one image.
#!/bin/bash
version=1.1.0
image=csedge/device-serial-go

docker manifest create ${image}:${version}-dev ${image}:${version}-arm64-dev ${image}:${version}-amd64-dev
docker manifest annotate ${image}:${version}-dev ${image}:${version}-arm64-dev --os linux --arch arm64
docker manifest annotate ${image}:${version}-dev ${image}:${version}-amd64-dev --os linux --arch amd64
docker manifest push -p ${image}:${version}-dev

@ernestojeda could you please bring this issue to DevOps meeting?  Thanks

@ernestojeda could you please bring this issue to DevOps meeting? Thanks

We discuss this a few weeks ago. We said we will are going to implement first in the app-service-configurable docker images. Once we get an OK from the App WG, we would implement this for other projects. Works is slated to begin in a few weeks. Just need to finalize the new edgex-go pipeline first.

Putting this in Core WG icebox until we get word from App/Analytics WG and DevOps on success.

Per TSC meeting of 7/29/20, with consultation of community members and users, this request is on indefinite hold.  There are two key issues that do not warrant moving in this direction at this time.

Losing visibility into DockerHub stats par architecture amd64 vs arm64 vs …
Potential increased developer complexity working with individual images (ex: I am on Windows but want to pull down and work with an ARM image).

This can be reassessed in future roadmapping discussions.

I'm glad that we discuss this issue.
I think docker has two major features, isolation and cross-platform.Unfortunately, we cannot make full use of it.

Losing visibility into DockerHub stats par architecture amd64 vs arm64 vs …

Yes, we will lose it, but i think we should not care it.

Potential increased developer complexity working with individual images (ex: I am on Windows but want to pull down and work with an ARM image).

For docker
docker pull --platform xxxx xxxx

Usage:  docker pull [OPTIONS] NAME[:TAG|@DIGEST]

Pull an image or a repository from a registry

Options:
  -a, --all-tags                Download all tagged images in the repository
      --disable-content-trust   Skip image verification (default true)
      --platform string         Set platform if server is multi-platform capable
  -q, --quiet                   Suppress verbose output

For docker-compose(added 2.4, not 3.5,3.6, will support3.7#1050)
Target platform containers for this service will run on, using the os[/arch[/variant]] syntax, e.g.
platform: linux/arm64/v8

Since windows can run linux containers(LCOW), cross-platform has become more and more complicated.
Splitting docker images is much easier for windows.


nsp command needs update in the build process

The nsp command has been updated and the .travis.yml file needs an update in this direction as well.

Coverage remained the same at 63.165% when pulling ac6678fb94fc0b14b2f48e195a15d27614ebc248 on lirantal:fix/travis-nsp-script into 7be191042066e58850899000ee02b6557d744c18 on meanjs:master.

LGTM


can the user customize the order of SSH authentication methods ?

Authentication Methods and Their Order in SSH
How to set the preferred authentication method for SSH

for server:
How can I list MACs, Ciphers and KexAlogrithms supported by my ssh server?
sshd -T | grep "\(ciphers\|macs\|kexalgorithms\)"

for client:
     PreferredAuthentications
             Specifies the order in which the client should try authentication methods.  This allows a client to prefer one method
             (e.g. keyboard-interactive) over another method (e.g. password).  The default is:

                   gssapi-with-mic,hostbased,publickey,
                   keyboard-interactive,password

for client:
           1.   command-line options
           2.   user's configuration file (~/.ssh/config)
           3.   system-wide configuration file (/etc/ssh/ssh_config)

plan to support only two auth methods: publickey, password.

verified.


Make Sanic app instance accessible to blueprint

Blueprints are supposed to be some kind of pluggable components, it should be able to access current app instance to read configurations and do other useful things.

Hey @messense I think this should be closed in favor of #476, which will add a reference to app on every request object.

@subyraman Wouldn't that be overkill? For simple usage, direct access global app varialbe should good enough.

@messense I still think having the currently running app in the request handler is valuable. If not for the sole fact that it allows you to be explicit in that you do want the running app and not just an app that sits globally.

I am ok with having currently running app in the request handler.


deleted marks appear again when reopen the file

I use neovim, and open a file such as init.vim and mark some, then m<Space> clear all marks and :q exit, it will be OK here, but all marks appear again when I reopen the file.

Seems like it's a neovim issue : https://github.com/neovim/neovim/issues/4295


Registering a target from a second consul service group deletes all other targets

I have two consul loader service groups setup with different subscriptions and configuration. If I register a device in the second group, gnmic deletes all devices from the first group and only monitors the new device.
loader:
  type: consul
  datacenter: lon
  address: <IP_ADDRESS>:8500
  enable-metrics: true
  services:
    - name: junos-targets
      subscriptions:
        - interfaces
        - junos-bgp
    - name: cumulus-targets
      config:
        encoding: JSON
        skip-verify: true
      subscriptions:
        - interfaces

I have 30+ devices in the junos-targets group working correctly. If I add a device to cumulus-targets the logs show all the junos-targets being deleted despite them still being active in Consul. If I restart gnmic, it registers devices from both services.
<IP_ADDRESS> - - [15/Jun/2023:15:48:22 +0000] "DELETE /api/v1/config/targets/router1 HTTP/1.1" 404 57
<IP_ADDRESS> - - [15/Jun/2023:15:48:22 +0000] "DELETE /api/v1/config/targets/router2 HTTP/1.1" 404 59
<IP_ADDRESS> - - [15/Jun/2023:15:48:22 +0000] "DELETE /api/v1/config/targets/router3 HTTP/1.1" 404 59
<IP_ADDRESS> - - [15/Jun/2023:15:48:22 +0000] "DELETE /api/v1/config/targets/router4 HTTP/1.1" 404 51
<IP_ADDRESS> - - [15/Jun/2023:15:48:22 +0000] "DELETE /api/v1/config/targets/router5 HTTP/1.1" 404 59
<IP_ADDRESS> - - [15/Jun/2023:15:48:22 +0000] "DELETE /api/v1/config/targets/router6 HTTP/1.1" 404 58
2023/06/15 15:48:22.735425 [gnmic] adding target {"name":"cumulus-test01","address":"<IP_ADDRESS>:9339","username":"","password":"****","timeout":10000000000,"insecure":true,"skip-verify":true,"buffer-size":100,"retry-timer":10000000000,"log-tls-secret":false,"gzip":false,"token":""}

Thanks for catching this, I will push a fix in the coming days.

@jasonyates-thg v0.31.1 should have a fix for this issue, please give it a go.

@karimra - Confirmed this works as expected now. Thanks for the fix.


inconsistency with builds

In a Swift scripts folder under my project-directory , I have a few swift files that generate build errors (from the error: "statements are not allowed at the top level") when I run "swift build" in the project folder. However when running "marathon run myfile.swift" in the Swift script folder , it runs and generates the proper output.

Yeah, that's exactly why I created Marathon 🙂 Only main.swift in a command line application or a single script file can contain top level code in Swift. When you use swift build you are compiling all of your source files as a Swift package, and such files can't contain top level code. So I would suggest either using a main.swift file for all your top level code, or use Marathon.

Another alternative is to place the files in a folder that is NOT under the Sources folder.


Remove ConfigMap permissions (IAM/Cert)

ConfigMap permissions were only necessary for legacy leader election, which was removed.
ref: https://issues.redhat.com/browse/ACM-5042

Related to:

https://github.com/open-cluster-management-io/governance-policy-addon-controller/pull/91


dev: server/engine/engine.g0:29 - register with MODM

create private method on engine, registerDeploymentManager

call SDK Create() and CreateEventHook()
get back deploymentId and set on to Step 0's execution ModmData

Bob has this implemented.


Working docker-compose?

Somebody able to share a working docker-compose (that use docker hub image, not localy builded) with volumes, port mapping, etc...
I try to figure out, how to set it with portainer stack, but no success....

https://github.com/archef2000/rdpgw

@TEDSv
Thanks, but it is a bit out of date not?

Docker compose files have been updated. Please read the instructions on how to use it.


feat(ISV-5130): add Atlas secrets to e2e tests

Description
In ISV-5130, the rh-advisories pipeline gained the ability to upload component and product-level SBOMs to the Atlas release instance.
The upload of SBOMs requires a new k8s Secret containing the SSO account and token for the stage Atlas release instance. The secrets have been added to the QE vault.
This PR makes the e2e test use the new secrets and refactors secret creation to avoid duplicate code. I left the other tests use the old way of creating the secrets but I can refactor those as well if you wish.
Issue ticket number and link
ISV-5130 - Add new pipeline steps in rh-advisories for sbom upload
ISV-5394 - Update rh-advisories pipeline e2e tests
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[x] I have updated labels (if needed)

Looks good to me, will let Jing approve if it looks good to her as well

@johnbieren still waiting on @.shebert's manual action before the tests can work

The indent issues seems not has fixed. Please leave the conversation to unresolved.  And can you please squash the commits in the PR to one commit?

@jinqi7 I will squash the commits once I'm sure nothing will change. As of now I'm still waiting on the manual creation of secrets, so we cannot test yet.

/retest

@jinqi7 I squashed the commits and added the secrets to the Vault. The tests should run now.

/ok-to-test

/test images

@johnbieren Could you please run the tests again? There was a last minute change in the catalog PR.

/ok-to-test

/retest

/retest

@jinqi7 I did not realize some secrets have to be base64-encoded in the vault. Could you please rerun the tests?

/retest

@jinqi7 I disabled the false gosec positive, it should be ready to go now

/ok-to-test

/retest

/retest

The konflux-e2e-tests failed for ""pod status "PodScheduled":"False"; message: "0/11 nodes are available: 3 node(s) had untolerated taint {node-role.kubernetes.io/infra: }, 3 node(s) had untolerated taint {node-role.kubernetes.io/master: }, 5 node(s) didn't match Pod's node affinity/selector. preemption: 0/11 nodes are available: 11 Preemption is not helpful for scheduling.." in staging cluster.  So, some test in CI will fail."   It's out of resource in staging cluster now.

/retest

/retest

/retest

/lgtm


Usage Example for Accounts-UI

I have implemented the meteor accounts-ui package and was wondering if you had any usage examples to show how to add a role to a new user sign up if you are using the accounts-ui package. Any help would be appreciated. I'm looking forward to using this package with my next project. thank you for your time. -Chris

In all your examples, you have implemented the Accounts.createUser method yourself server-side, which is perfect if I were to implement all the user creation myself. However, I'd like to use the accounts-password package (along with accounts-ui) to save me a lot of hassle.
But when I do, I can no longer assign roles on account creation since I do not know when accounts-password is done creating the user. The next best thing is to require email verification and run the Roles.addUsersToRoles method inside Accounts.onEmailVerificationLink.
Or this is what I am trying:
Accounts.onCreateUser(function (options, user) {
	if (options.profile) {
		user.profile = options.profile;
	}
	user.roles = {__global_roles__: []};
	return user;
});

Inside the onCreateUser method, I am manually adding a roles property and inserting the key myself, before returning the user document to be inserted into the users collection. This works, but it it an acceptable hack in your opinion?
In either case, it would be nice to see an example where meteor-roles integrates with accounts-password and accounts-ui?

Hi Daniel,
I've found most people eventually need to make their own signup form and end up calling Accounts.createUser on the server.
But this has come up before so I've added an example of using roles with accounts-ui:  https://github.com/alanning/meteor-roles/tree/master/examples/rolesWithAccountsUI
In the example, I extended the Roles object with a new method setRolesOnUserObj which does the same thing as Roles.setUserRoles but adds them directly to the passed-in object instead of updating the database.
The existing roles methods expect you to have a user _id already and I'm leery of changing those to update just the object since if the _id is not found, the object would then have the roles but the database wouldn't.  I'll probably ask on the meteor-talk group and see whether people think its better to have a separate method or update the existing ones.
Hope this helps.

Dear Adrian,
Thank you for your time and help, the setRolesOnUserObj method works great. I don't understand the point you made in your last paragraph though. The user object passed into the onCreateUser method will always have an _id, and this will get written to the database.
Thanks once again!

Hi Alaning,
Any chance Roles.setRolesOnUserObj  making it to roles package itself so that I don't have to keep a copy of the method.

Hi @mtikmani, yes I'll include something like setRolesOnUserObj in the next release of the package but I don't have an estimate on when that will be right now.  Sorry!  :-/

Hi Alanning
I've seen the example that you have done integrating roles with accounts-UI, but i still don't quite get how do we set the role of a user. For example, i would like to set the role of the user with _id = "xxxxxx" to 'admin',  how do i use that example to achieve this?

@weijian19391, if the user record already exists in the database then:
Roles.setUserRoles(userId, 'admin')

Source - http://alanning.github.io/meteor-roles/classes/Roles.html#method_setUserRoles
If the user record does not exist yet, such as in Accounts.onCreateUser, then:
  Accounts.onCreateUser(function (options, user) {
    Roles.setRolesOnUserObj(user, ['admin']);

    if (options.profile) {
      // include the user profile
      user.profile = options.profile
    }

    // other user object changes...
    // ...

    return user;
  });

Source - https://github.com/alanning/meteor-roles/blob/master/examples/rolesWithAccountsUI/server/startup.js#L6

@alanning Thanks for your help! I must have missed out the part about the case when user exist, i only have to the roles. Thanks!

I have removed setRolesOnUserObj in v2.0 branch in 484e08fc6afbc1fdbb2b63def25666b3d0159447 because it cannot really work with subroles.
One should use postSignUpHook from useraccounts package (a community version of accounts UI with many improvements). So instead of creating your own custom form you can use that package which then provides with the necessary hook.


This repository is over its data quota. Purchase more data packs to restore access.

I got this error while trying git clone. I'm not sure if this is from my end or not.

git clone https://github.com/udacity/self-driving-car-sim.git
Cloning into 'self-driving-car-sim'...
remote: Counting objects: 7608, done.
remote: Total 7608 (delta 0), reused 0 (delta 0), pack-reused 7608
Receiving objects: 100% (7608/7608), 132.32 MiB | 1.40 MiB/s, done.
Resolving deltas: 100% (1987/1987), done.
Checking connectivity... done.
Downloading Assets/1_SelfDrivingCar/Sprites/Background.png (6.83 MB)
Error downloading object: Assets/1_SelfDrivingCar/Sprites/Background.png (36e4565): Smudge error: Error downloading Assets/1_SelfDrivingCar/Sprites/Background.png (36e4565319a778a53538a2c1419174cac59597859e5a8616c1b94a08d6221ac3): batch response: This repository is over its data quota. Purchase more data packs to restore access.

I also experience similar problem

+1 on this issue

+1 here too

Same problem here, any fix?

any answer?

instead of cloning download this repository as a zip and unzip it.

This issue has been resolved and cloning is working.


LiveShare not working - network requirements not documented enough

Issue Type: Bug
I don't see which hostname cannot be parsed. Would be usefull to document what is required to be open on firewall or proxy to get LiveShare working in an enterprise network behind corporate firewall and proxy.
Extension version: 1.0.988
VS Code version: Code - Insiders 1.40.0-insider (6a2d035b7157cb135b51d2d3ca3b3c0ee0fc4ad6, 2019-10-17T05:28:00.123Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz (4 x 2496)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.41GB (17.95GB free)

Process Argv
D:\git\ZIS-CA-Groupware-SP19\IPM.code-workspace

Screen Reader
no

VM
0%

Thank you for filing this issue. We have information on how to deal with proxy issues behind a corporate firewal here: https://docs.microsoft.com/en-us/visualstudio/liveshare/reference/connectivity#requirements-for-connection-modes
Please let us know if this does not solve the issue and we can get back to you.

Closing with no new activity


Automatic transcoding feature, RecordID, and $enter without args.

Implemented the following features:
Automatic transcoding feature

Runs merge.js on record stop.
Merge.js runs ffmpeg to transcode.
This requires a record id feature to be implemented.

You can now enter without args. This will join the user's current voice channel.
Added JSON metadata.

This contains who started the recording, and timestamps of voice start/end.

@capthndsme hey there, thanks for contributing!
I'm a little busy with school atm, the changes look good on first glance (thanks to the detailed info), I'll go through it in detail sometime soon, hopefully before this month :)


Reduce default cover thumbnail resolution to 256x256

It turns out there's a reason why I decide to use 512x512 as default size for cover thumbnail. On high-DPI display, with current layout implementation it will create blurry thumbnail if resolution is <= 256px. I'll keep using 512px as default thumbnail size. We can add query parameter to change thumbnail size if needed.


Filtering with an or operator...

I'm trying to set up a function that determines how many fantasy points a kicker gets each week. I'm having trouble determining the difference between games and bye weeks and was hoping to keep my code as simple as possible. I would like bye weeks to show up as nan and scoreless weeks to show up as zero. I would be closer to accomplishing this if there was a way to do:
for play in plays.filter((kicking_fga__ge=1) or (kicking_xpa__ge=1)):
However, that does not work. Setting both parameters like:
for play in plays.filter(kicking_fga__ge=1, kicking_xpa__ge=1):
returns nothing, because obviously you can't have a field goal attempt and an xp attempt on the same play. Here is my full code. If anyone can help me do this, it would be greatly appreciated.
def get_kicker_pts(year, week, fullName):
    games = nflgame.games(year, week=week)
    plays = nflgame.combine_plays(games)
    kicking_fgm_yds = np.array([])
    kicking_fgmissed = np.array([])
    kicking_xpmade = np.array([])
    kicks_0 = np.nan
    kicks_40 = np.nan
    kicks_50 = np.nan
    kick_pts = np.nan
    for play in plays.filter(kicking_fga__ge=1):
        for p in play.players:
            if p.player.full_name == fullName:
                kicking_fgm_yds = np.append(kicking_fgm_yds,
                                            play.kicking_fgm_yds)
                kicking_fgmissed = np.append(kicking_fgmissed,
                                             play.kicking_fgmissed)
    # Seems to not calculate xps after defensive td
    plays = nflgame.combine_plays(games)
    for play in plays.filter(kicking_xpmade=True):
        for p in play.players:
            if p.player.full_name == fullName:
                kicking_xpmade = np.append(kicking_xpmade, 1)
    plays = nflgame.combine_plays(games)
    for play in plays.filter(kicking_fga__ge=1, kicking_xpa__ge=1):
        for p in play.players:
            if p.player.full_name == fullName:
                kicks_0 = len(kicking_fgm_yds[kicking_fgm_yds < 40])
                kicks_40 = len(kicking_fgm_yds[(kicking_fgm_yds >= 40) &
                                               (kicking_fgm_yds < 50)])
                kicks_50 = len(kicking_fgm_yds[kicking_fgm_yds >= 50])
                kick_pts = (kicks_0 * 3 + kicks_40 * 4 + kicks_50 * 5 +
                            kicking_xpmade.sum() - kicking_fgmissed.sum())
    return(kick_pts)

Well, I was able to just query the plays without any filter and that worked. It's probably not the most elegant solution, but considering the low number of kickers in the league, speed it not that important. Here is the code I ended up with. The only issue is that extra points after defensive touchdowns don't seem to be calculated.
def get_kicker_pts(year, week, fullName):     games = nflgame.games(year, week=week)     plays = nflgame.combine_plays(games)     kicking_fgm_yds = np.array([])     kicking_fgmissed = np.array([])     kicking_xpmade = np.array([])     kicks_0 = np.nan     kicks_40 = np.nan     kicks_50 = np.nan     kick_pts = np.nan     for play in plays.filter(kicking_fga__ge=1):         for p in play.players:             if p.player.full_name == fullName:                 kicking_fgm_yds = np.append(kicking_fgm_yds,                                             play.kicking_fgm_yds)                 kicking_fgmissed = np.append(kicking_fgmissed,                                              play.kicking_fgmissed)     # Seems to not calculate xps after defensive td     plays = nflgame.combine_plays(games)     for play in plays.filter(kicking_xpmade=True):         for p in play.players:             if p.player.full_name == fullName:                 kicking_xpmade = np.append(kicking_xpmade, 1)     plays = nflgame.combine_plays(games)     for play in plays:         for p in play.players:             try:                 if p.player.full_name == fullName:                     kicks_0 = len(kicking_fgm_yds[(kicking_fgm_yds > 0) &                                                   (kicking_fgm_yds < 40)])                     kicks_40 = len(kicking_fgm_yds[(kicking_fgm_yds >= 40) &                                                    (kicking_fgm_yds < 50)])                     kicks_50 = len(kicking_fgm_yds[kicking_fgm_yds >= 50])                     kick_pts = (kicks_0 * 3 + kicks_40 * 4 + kicks_50 * 5 +                                 kicking_xpmade.sum() - kicking_fgmissed.sum())             except AttributeError:                 pass     return(kick_pts)


Update/change fields of a reflected/dynamic type

What problem does this solve or what need does it fill?
I can only get a &mut dyn Reflect from field_mut from DynamicTupleStruct (and similar) which I can modify, but e.g. changing the field from being a DynamicStruct to a DynamicEnum isn't possible.
What solution would you like?
Add the option to replace fields
What alternative(s) have you considered?
I currently have no idea of how to do that externally..
Additional context
Might be easier when unifying fields (https://github.com/bevyengine/bevy/issues/14847#issuecomment-2301674088) ?

The possible desire for this actually came up recently in #14776 where we'd want to have a way to replace Box<dyn Reflect> fields with a different Box<dyn Reflect>.
However, for this I think it might be cleaner to introduce this ability on the dynamic types directly (i.e. add a DynamicStruct::replace_field method). Then we'd need to add the ability to somehow downcast a dyn PartialReflect to one of the dynamic types.
I think it should be okay to move the dyn Any conversion methods from Reflect to PartialReflect since that doesn't necessarily break the contract that dyn Reflect is never a dynamic type. That would allow us to either modify the downcast methods on dyn PartialReflect to use dyn Any instead of dyn Reflect or just tell users to cast to dyn Any manually if they want to downcast to a dynamic type.


Add support of MultiPolygon and GeometryCollection to 'orient' function

Fix for https://github.com/Toblerity/Shapely/issues/635.

Coverage increased (+0.05%) to 80.836% when pulling 7d79fd35b10f2327544a7c0983001105053445c3 on drnextgis:gh635-orient into 322daf7463f069312f71508902e6aaf9df915d94 on Toblerity:master.

Coverage increased (+0.05%) to 80.836% when pulling 7d79fd35b10f2327544a7c0983001105053445c3 on drnextgis:gh635-orient into 322daf7463f069312f71508902e6aaf9df915d94 on Toblerity:master.

Shouldn't it've been added to the docs?

Docs added in 053df24.

@drnextgis This saved me a ton of headache today! 🍰


Sum Of numbers from 1 to given number

Hii I'm a GSSoc22 contributor and I'm willing to make a pull request in this repository on my project which is Sum Of Numbers.
The idea behind this project
This is a very mini project which can be used to know the Sum Of Numbers. from 1 to given number
###How does it work
Whenever you enter a number in the input box and click submit, we can see the result in a box below .

@swapnilsparsh Why was this issue closed?

Try to be more innovative with your project idea as we already have many projects like this.


DOCS-1191: Updating SSE params, general fixups

Closes #1191
Summary
Finally getting around to this mc release

Added docs for enc-c, enc-s3, enc-kms
Some docs are making assumptions around behavior that needs to be fixed first
Drive-by linker fixes

Staged: http://<IP_ADDRESS>:9000/staging/DOCS-1191/linux/index.html

An existing issue in the original: this doesn't appear in the TOC anywhere?
source/reference/minio-mc/mc-idp-ldap-accesskey-create.rst

@zveinn if there's nothing obviously wrong here I'll merge this up. Thanks!


Update to dynamic features.

This PR contains multiple changes. The two biggest changes are the separation of feature flags and dynamic features and the renaming of types to respect dynamic feature terminology. Most other changes follow as consequence. Details of the included changes are below.
Documentation updates, including the new configuration schema, to follow in a subsequent PR.

Update types to respect dynamic terminology. E.g. IFeatureManager -> IDynamicFeatureManager.

Updated property/method summaries to distinguish dynamic features and feature flags.

Separate feature flags and dynamic features in configuration schema

Backward compatability support for old configuration schema.

Breaking: Update custom feature definition provider to return feature flags and dynamic features.

Added DynamicFeatureDefinition class
renamed FeatureDefinition to FeatureFlagDefinition.

Breaking: IFeatureManager.GetFeatureNamesAsync renamed to IFeatureManager.GetFeatureFlagNamesAsync
Corrected namespace for built-in feature variant assigners.

Microsoft.FeatureManagement -> Microsoft.FeatureManagement.Assigners

Added IDynamicFeatureManagerSnapshot
Added test for custom feature definition provider.
Added test for backcompat support for v1 configuration schema.

Old configuration schema example
{
    "FeatureManagement": {
        "FeatureFlag1": true,
        "FeatureFlag2": {
            "EnabledFor": [
                ...
            ]
        }
    }
}

New configuration schema example
{
    "FeatureManagement": {
        "FeatureFlags": {
            "FeatureFlag1": true,
            "FeatureFlag2": {
                "EnabledFor": [
                    ...
                ]
            }
        },
        "DynamicFeatures": {
            "DynamicFeature1": {
                "Assigner": "Targeting",
                "ConfigurationReference": "SomeSettings",
                "AssignmentParameters": {
                    ...
                }
            }
        }
    }
}

using System;

Missing copyright header

Refers to: src/Microsoft.FeatureManagement/NameHelper.cs:1 in ba664ee. [](commit_id = ba664ee550b4d1d1068eba7713a159bad3516879, deletion_comment = False)


Market Creation Bug

I created a new market and added pre-liquidity (passed the spread filter)....My market gets created (and I get a toast message to confirm this) I sign my pre-liquidity orders.....they do show up in open orders, but I do NOT get a toast/bell message for them and my newly created market still shows liquidity depleted.
liquidity depleted goes away after refreshing......but i still get no bell messages for those orders being created

The liquidity label is based on a property that is calculated in the sdk, it gets re-calculated (it’s an Resource intensive calculation) every minute or so. Therefore the label will go away a minute or so after orders have been created.

Seeing it in the bell now


Rasa Training problem

Hi all,
I got an issue.
I got this error when training my data.json use mitie.

and here's my project file.

plese help me fix this error.
Thanks,
Cheers

mitie.dll which you have copied to python/lib has conflict compiled version: note if you're using x64 python than you've to compile with defined Win64:
cmake -G "Visual Studio 10 Win64" ..

Let me know if this is still an issue

Hi @tmbo,
There's no more issue here. I solve the problem already.
Sorry for late respond and thanks for closing the thread.
Thanks,
Cheers

I am having the issue can you help me here how to resolve it?


[closure size] X11 and OpenGL libs are always in closure

Issue description
Even with environment.noXlibs = true; X11 and OpenGL libs are always in closure via
udisks -> libblockdev -> libbytesize -> gtk-doc -> dblatex -> texlive -> cairo

Maybe environment.noDocs is to be introduced to rule out all the heavy gtk-doc, pandoc, texlive
It is useful especially for the embedded targets (ARM/MIPS/i686)

The libbytesize -> gtk-doc looks like it should be avoidable.

If you aren't running a graphical system, disabling udisks is probably the best solution. I did it for the minimal ISO today: 571fb74f449aa173e231166515b41feb778524b8

If you aren't running a graphical system, disabling udisks is probably the best solution.

I ended up with
      services.udisks2.enable = lib.mkDefault (!config.environment.noXlibs);
      security.polkit.enable  = lib.mkDefault (!config.environment.noXlibs);

Perhaps these lines are candidates for inclusion to https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/config/no-x-libs.nix

yes, that might only cross-compilation issue
close for a while


Support line breaks in chat messages

Support adding line breaks to chat messages. (Roll20's API supports
 in sendChat() messages.)

This leaves the question how to specify a line break in a chat message.
It would have to be something that isn't stripped by Roll20 before the message even gets to MMM, i.e. it can't be HTML
.
Observation: Especially with "!mmm combine chat" existing, it seems unlikely it'll be necessary to add line breaks anywhere else than at the end of a "!mmm chat: ..." command. Maybe parametrize "chat:" somehow to say "...with a line break between this and the next chat: segment".

...or Markdown-style – just leave an empty chat line where you want your line break:

Line
Command

1
!mmm combine chat

2
!mmm     chat: first paragraph

3
!mmm     chat:

4
!mmm     chat: second paragraph

5
!mmm end combine

produces:
Finn: first paragraphsecond paragraph
(That would have to be a line that's syntactically empty, not one that just happens to produce no output.)

For what it's worth, if you sneak a
 past Roll20's chat line parser, you can already do that now:

Line
Command

1
!mmm chat: first paragraph${"<"}br>second paragraph

No, not winning any beauty contests with that one.
Slightly more polished:

Line
Command

1
!mmm script

2
!mmm     set BR = "<" & "br>"

3
!mmm     chat: first paragraph${BR}second paragraph${BR}third paragraph

4
!mmm end script

Heh, I just realized that this is truly a backwards-compatible change since chat: without anything behind it is currently a syntax error. Yay!

I've also realized that only
 makes actual sense as the result of an empty chat: line – not \n because that just splits the line into several chat messages (and there's an easier way to achieve that already).


Sort queue map list by display name

Can we also show only maps that are in the player’s rating bracket?
Like if my mean is 700, only show the maps from pools up to that mean. And if I have less than 10 games only show the pool for a mean of 0.

That is just a little different so might put it in a different issue which I believe exists


Brightened up line number and changed WildMenu selection text (guifg) color.

Change 0
Line numbers felt a bit dark to me. So replaced the old color with the one that was used for comment #424c50.
Change 1
The text color (foreground) of wildmenu selection was bright above a bright color (background). So it was replaced by color0 #232a2d.
Here is the Before and After:

Thanks.


[BUG] TLS handshake timeout running kubectl cluster-info due to ufw firewall rules

What did you do

How was the cluster created?

k3d cluster create

What did you do afterwards?

kubectl cluster-info
Unable to connect to the server: net/http: TLS handshake timeout

This issue just started popping up on one of our deployment machines today. Prior to today, this process was working flawlessly. A reboot does not fix it. I tried this on an older version of k3d, v4.3.0 and I get the same issue.
What did you expect to happen
The cluster can be communicated with.
Screenshots or terminal output
https://gist.github.com/chris13524/7f5a393e84fb3edcb826e63894f4d8f2
Which OS & Architecture

Linux amd64
Ubuntu 20.04.3

Which version of k3d
k3d version v5.0.3
k3s version v1.21.5-k3s2 (default)
Which version of docker
https://gist.github.com/chris13524/d50dbe5eba2697e666f66b35b11c817d

So I can actually interact with the cluster fine if I exec into the server pod directly: docker exec -it k3d-k3s-default-server-0 kubectl cluster-info. Furthermore, if I copy in the kubectl binary and kubeconfig into the serverlb container, I'm able to use kubectl there to both connect to the server container and to connect to the serverlb nginx service running on <IP_ADDRESS>:6443. So it seems like the issue lies closer to the Docker port forward (<IP_ADDRESS>:41593->6443/tcp). I added stream access logs to Nginx and requests from the serverlb container are logged there as expected, but when using wget from the host I get a "connected" but no logs are seen:
user@host:~$ wget -vO - https://<IP_ADDRESS>:41593
--2021-11-04 10:54:48--  https://<IP_ADDRESS>:41593/
Connecting to <IP_ADDRESS>:41593... connected.
Unable to establish SSL connection.

So I'm not sure if the "connected" above is for connection to the Docker proxy or if it actually reaches Nginx but the stream session simply isn't logged if it doesn't complete properly due to some TLS issue. Running a regular Nginx container with similar port forwards to k3d's serverlb doesn't reveal any immediate issues, but I haven't tried this using streams or TLS.
This could be a ufw issue, but we do not have control over this configuration so are investigating further. Are there any existing docs on using k3d with ufw?

I'm closing this issue since we seem to have resolved it using either of these two options:
ufw allow in on cni0 to any
ufw allow out on cni0 to any

ufw allow in from <IP_ADDRESS>/16 to any
ufw allow out from <IP_ADDRESS>/16 to any

Hi @chris13524 , thanks for opening this issue!
I'm very sorry that I never got to comment/work on this!
Just got the backlog worked up to this point now.
I'm glad you resolved it yourself in the meantime :+1:

Thanks @iwilltry42. The issue was that we changed the default UFW policy to block outgoing connections. This broke communication in various ways, but adding the allow rules above mitigated this issue.

Hmm, just ran into this, with a fresh ubuntu 23.10 install and k3ds installed from nixpkgs.
ufw is inactive in my case.
iptables:
$ sudo iptables --list
Chain INPUT (policy ACCEPT)
target     prot opt source               destination

Chain FORWARD (policy ACCEPT)
target     prot opt source               destination
NETAVARK_FORWARD  all  --  anywhere             anywhere             /* netavark firewall plugin rules */

Chain OUTPUT (policy ACCEPT)
target     prot opt source               destination

Chain NETAVARK_FORWARD (1 references)
target     prot opt source               destination
ACCEPT     all  --  anywhere             <IP_ADDRESS>/24         ctstate RELATED,ESTABLISHED
ACCEPT     all  --  <IP_ADDRESS>/24         anywhere

nf-tables rulesets:
$ sudo nft list ruleset
# Warning: table ip nat is managed by iptables-nft, do not touch!
table ip nat {
        chain POSTROUTING {
                type nat hook postrouting priority srcnat; policy accept;
                counter packets 9790 bytes 1325950 jump NETAVARK-HOSTPORT-MASQ
                ip saddr <IP_ADDRESS>/24 counter packets 275 bytes 21688 jump NETAVARK-2EE7F3DEE5FA2
        }

        chain NETAVARK-HOSTPORT-SETMARK {
                counter packets 1 bytes 60 meta mark set mark or 0x2000
        }

        chain NETAVARK-HOSTPORT-MASQ {
                 meta mark & 0x00002000 == 0x00002000 counter packets 1 bytes 60 masquerade
        }

        chain NETAVARK-HOSTPORT-DNAT {
                tcp dport 33977  counter packets 6 bytes 360 jump NETAVARK-DN-2EE7F3DEE5FA2
        }

        chain PREROUTING {
                type nat hook prerouting priority dstnat; policy accept;
                fib daddr type local counter packets 316 bytes 22502 jump NETAVARK-HOSTPORT-DNAT
        }

        chain OUTPUT {
                type nat hook output priority -100; policy accept;
                fib daddr type local counter packets 2467 bytes 181491 jump NETAVARK-HOSTPORT-DNAT
        }

        chain NETAVARK-2EE7F3DEE5FA2 {
                ip daddr <IP_ADDRESS>/24 counter packets 0 bytes 0 accept
                ip daddr != <IP_ADDRESS>/4 counter packets 247 bytes 16150 masquerade
        }

        chain NETAVARK-DN-2EE7F3DEE5FA2 {
                ip saddr <IP_ADDRESS>/24 ip daddr <IP_ADDRESS> tcp dport 33977 counter packets 0 bytes 0 jump NETAVARK-HOSTPORT-SETMARK
                ip saddr <IP_ADDRESS> ip daddr <IP_ADDRESS> tcp dport 33977 counter packets 0 bytes 0 jump NETAVARK-HOSTPORT-SETMARK
                ip daddr <IP_ADDRESS> tcp dport 33977 counter packets 0 bytes 0 dnat to <IP_ADDRESS>:6443
        }
}
# Warning: table ip filter is managed by iptables-nft, do not touch!
table ip filter {
        chain NETAVARK_FORWARD {
                ip daddr <IP_ADDRESS>/24 ct state related,established counter packets 52106 bytes 153831198 accept
                ip saddr <IP_ADDRESS>/24 counter packets 40762 bytes 2399333 accept
        }

        chain FORWARD {
                type filter hook forward priority filter; policy accept;
                 counter packets 411233 bytes 520621661 jump NETAVARK_FORWARD
        }
}
table ip6 filter {
}


Get a shared file system safe signal file name

Use the previously added utils to get a signal file name that is safe on shared file systems. Previously the name would clash.
Tested simple train and load (don't have a multinode shared fs to actually test that part on):
train: dist-utils-train-1-UExzEF
load: dist-utils-load-2-Uoq35b
See also https://github.com/mosaicml/composer/pull/3485

Hey, what was the reason to revert the commit? :)
Doesn't the reversion basically re-introduce the error that was explained in #1253?

Hi, yes we reverted due to a bug in the released version of the helper function (did not work on systems where distributed was not initialized). That bug has since been fixed, and this commit should be reapplied. Thanks for the reminder!


Added explanation that Quarkus-amazon-lambda can not be used by aws2-…

@cunningt this is just a docs fix, no prod rebuild needed because of that


Initial server

The initial version of the server and helper utility. Server endpoints are probably what they will be, albeit with placeholder implementations.
This is not production-ready, but fixing issues before moving to the new development targets.

Codecov Report

Merging #2 (bff02cc) into master (699922d) will decrease coverage by 31.32%.
The diff coverage is 34.00%.

@@             Coverage Diff             @@
##           master       #2       +/-   ##
===========================================
- Coverage   99.49%   68.17%   -31.33%
===========================================
  Files           4       13        +9
  Lines         599     1040      +441
===========================================
+ Hits          596      709      +113
- Misses          3      331      +328

Impacted Files
Coverage Δ

mobile_api_server/src/api_v1.rs
0.00% <0.00%> (ø)

mobile_api_server/src/api_v1/commands.rs
0.00% <0.00%> (ø)

mobile_api_server/src/api_v1/device.rs
0.00% <0.00%> (ø)

mobile_api_server/src/device_status.rs
0.00% <0.00%> (ø)

mobile_api_server/src/state.rs
0.00% <0.00%> (ø)

create_device_info/src/main.rs
1.05% <1.05%> (ø)

mobile_api_server/src/main.rs
1.47% <1.47%> (ø)

mobile_api/src/configs.rs
99.31% <97.14%> (ø)

mobile_api/src/security.rs
99.45% <97.67%> (ø)

mobile_api/src/error.rs
100.00% <100.00%> (ø)

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


OError: [Errno 19] Operation not supported by device

I am getting this error. Whats going wrong?
Traceback (most recent call last):
  File "<pyshell#19>", line 1, in <module>
    apns.gateway_server.send_notification(token_hex, payload)
  File "/Library/Python/2.7/site-packages/apns.py", line 544, in send_notification
    self.write(self._get_notification(token_hex, payload))
  File "/Library/Python/2.7/site-packages/apns.py", line 273, in write
    return self._connection().write(string)
  File "/Library/Python/2.7/site-packages/apns.py", line 254, in _connection
    self._connect()
  File "/Library/Python/2.7/site-packages/apns.py", line 230, in _connect
    self._ssl = wrap_socket(self._socket, self.key_file, self.cert_file)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ssl.py", line 891, in wrap_socket
    ciphers=ciphers)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ssl.py", line 509, in __init__
    self._context.load_cert_chain(certfile, keyfile)
IOError: [Errno 19] Operation not supported by device

Refer this : http://stackoverflow.com/questions/33826649/pyapns-throws-ioerror-operation-not-supported-by-device


Mixer not loading

When trying to load a mixer in hardware (tested Pixracer + CF2), the file is incorrectly parsed:
NuttShell (NSH)
nsh> mixer load /dev/pwm_output0 /etc/mixers/quad_x.main.mix
[mixer] remaining in buf: 138, first char: M
[mixer] unrecognised geometry '4x 1000'
ERROR [mixer] failed to load mixers from /etc/mixers/quad_x.main.mix
ERROR [mixer] failed to load mixer
nsh>

This commit seems to be causing it: https://github.com/PX4/Firmware/commit/db44129ec099a05debf9187da2fd09035c9a67d7
Proposed fix: https://github.com/PX4/NuttX/pull/86
Would be nice if someone could test to validate this. Thanks!

I dont know how the mixer looks like but it is obvious to me that the line for the quad mixer starts with letter M in the mixer so after M it could not recognize the 4x geometry. The MC mixer should look like this:
R: 4x 10000 10000 10000 0

The "M" in the output is referring to the next unparsed character of the line after the "R: 4x 10000..." line failed to parse. The issue was that sscanf was not working correctly which is fixed by an open PR on this repo updating the NuttX libraries.

OK then it is something else. Sorry.


Unable to delete pod group before admission

What happened:
If I create 3 pods for a pod group of size 4 and then decide to delete it, there's no way for me to manually delete pods in the group, since all of the pods contain the finalizer.
What you expected to happen:
If all of the pods in the group have a deletion timestamp, the group is not finished, and there's no related workload, the pods should be finalized.
How to reproduce it (as minimally and precisely as possible):

Create 3 pods with kueue.x-k8s.io/pod-group-total-count=4:
apiVersion: v1
kind: Pod
metadata:
  generateName: kueue-sleep-
  annotations:
    kueue.x-k8s.io/pod-group-total-count: "4"
  labels:
    kueue.x-k8s.io/queue-name: user-queue
    kueue.x-k8s.io/pod-group-name: example-group
spec:
  containers:
    - name: sleep
       image: busybox
       command:
        - sleep
      args:
        - 5m
      resources:
        requests:
          cpu: 1m

Delete all pods in the group:
kubectl delete -l kueue.x-k8s.io/pod-group-name=example-group -n default

Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version): v1.28.3
Kueue version (use git describe --tags --dirty --always):
Cloud provider or hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

cc @alculquicondor

I think if a Pod is deleted before the number of pods equals the group size and a Workload doesn't exist, we might be ok finalizing it.

/assign

/close
Fixed by https://github.com/kubernetes-sigs/kueue/pull/1573

/unassign @achernevskii
/assign


all: code that needs to be cleaned up

https://github.com/4ad/go/commit/53506458aa79fed23a5db0b4f4ec31ee342a1b15#commitcomment-9807610
https://github.com/4ad/go/commit/d7dcc3829662dd7be157097e7f603d9cef6e0fcd#commitcomment-9799083
See also the commit message for another idea.

https://github.com/4ad/go/commit/efc789831ec19cfcac34f849b6601564bd39f5bb#commitcomment-9807692


SANE module should allow editing backend configs

Issue description
Some SANE backends require additional configuration, e.g. an address of a network scanner.
Currently I’m using my custom module — https://github.com/michalrus/dotfiles/commit/d943be3089aa436e07cea5f22d829402936a9229 — to configure Sane on various devices. Using it, you can do:
{
  hardware.sane.extraConfig = {
    "some-backend" = ''
      # some lines that will be appended to
      # the `${config.hardware.sane.configDir}/some-backend.conf` file
    '';
  };
}

Technical details

System: 16.09pre85931.125ffff (Flounder)
Nix version: nix-env (Nix) 1.11.2
Nixpkgs version: "16.09pre85931.125ffff"

I am currently doing the same. Until this feature is included into upstream i will document it into the nixos-users wiki: https://github.com/nixos-users/wiki/wiki/Scanners

@michalrus There's this netConf option. This issue is ancient and stale so I'm closing.

fair enough, thanks for following up!

How is netConf supposed to replace configuration of backend that user uses?
For example, I am trying to use sane-airscan, it has its own config file in /etc/sane.d/airscan.conf. How netConf can know about it and create the config with my parameters which are not just simple IP address?

I'm using the airscan backend my self and I've just verified it works a few days ago. @tex look at this:
https://github.com/NixOS/nixpkgs/blob/ddb59ca5ccfefd97920db682e165d0e3f226b2ec/pkgs/applications/graphics/sane/config.nix#L7-L28
If a sane backend package has a either of the common files (see lines 16-17):

$out/etc/sane.d/dll.conf
$out/etc/sane.d/net.conf
$out/etc/sane.d/saned.conf

Their contents are merged by this derivation, and then, after a rebuild (and a logout-login) SANE_CONFIG_DIR should point to a derivation with this backend available, both thanks to the configs symlinked and the shared object libraries symlinked to $SANE_CONFIG_DIR/lib.
For sane-airscan, there's supposed to be $SANE_CONFIG_DIR/airscan.conf and $SANE_CONFIG_DIR/dll.conf which should contain at the end of it the lines:
# sane-dll entry for sane-airscan
airscan

Concatenated by the derivation's installPhase.
If you do not see this evidence that sane-airscan is configured, then there's something wrong with the way you use (or not use) the NixOS option hardware.sane.backends.
If you do see this evidence for airscan "installed" in $SANE_CONFIG_DIR, and you still don't see your airscan compatible scanner, then perhaps you are missing some avahi related settings. These work for me:
    services.avahi.enable = true;
    services.avahi.nssmdns = true;
    services.avahi.reflector = true;

I'm quite new to NixOS and have quite a few difficulties installing my network scanner. With the sane-airscan backend and netConf option I can configure my scanner but get an I/O Error while scanning. On Arch Linux I configured the backend as described by @michalrus, so I used the custom module method as described in NixosWiki. But a nixos-rebuild switch produces an BadStorePath Error. Has anyone the same problem, or can someone give me some hints how to debug these errors?
The scanner I'm using is a Samsung M2885FW and my system is on version 20.09.

I have this and it works for me. Does your scanner works with sane-airscan on Arch? Is NixOS sane-airscan older version?
    hardware.sane =
      { enable = true;
      extraBackends = [ sane-airscan ];
    };
    services.saned.enable = true;

On Arch I never tested the sane-airscan backend. But it worked with the samsung-unified-driver and with the static IP-Adress added to /etc/sane.d/xerox_mfp.conf. After reading the NixosWiki article I saw that my scanner should also support sane-airscan. So I tried that with the same settings you have. With that the scanner was found, but I get an I/O Error every time I try to scan.

I have WorkCentre 3025 and that was not supported by sane-airscan, but I provided a communication dump during attempt to scan (via Ethernet and Wireshark) and author of sane-airscan was able to find out what is wrong and added support for it. He is very active and nice.

 With the sane-airscan package from the unstable branch of nixpkgs it works. Thank you for your help.

@michalrus There's this netConf option. This issue is ancient and stale so I'm closing.

This is not the same. netConf/net.conf is for specifying other hosts running saned, not networked scanners. These need to be specified in their sane driver configs. Currently it is not possible to add lines to these config files (except for net.conf). This ticket suggests adding a config option to allow adding lines to the other drivers.

@returntoreality I'm not sure I understood what you were trying to explain. Could you please perhaps open a separate issue, explaining why netConf isn't what you need?

I created ticket #295008 which hopefully explains it a bit better.


Make remote query cache timeout configurable

Fixing the problems with multi-collins queries as described in #396 (and reverted in #400) is taking a bit longer than i had hoped. So, in the meantime, this PR re-introduces the config parameter for the remote query cache timeout from the previous PR.
@tumblr/collins

LGTM

:+1:


Update Contributors.md

@mommothazaz123, there is a merge conflict for this pull request and apparently I am unable to resolve it from my side. Could you try from your end?


\newenvironment hightlight not working

Although \renewenvironment is properly highlighted, \newenvironment is not

What editor are you using?
(The reason is that \newenvironment -- which takes three mandatory arguments, by the way -- is a separate node, while \renewenvironment is a generic command. These should be treated the same, in any case.)

The grammar now treats \renewenvironment and \newenvironment the same way (e4112094b3dbaae246236b586073729d98699043).

Should be working now: https://github.com/nvim-treesitter/nvim-treesitter/pull/2783


content test: Skip source-file-reading test on Windows

This fails there, or at least does in the flutter/tests CI environment, with an error like:
::group::❌ C:/Users/RUNNER~1/AppData/Local/Temp/flutter_customer_testing.zulip.4a7c3de6/tests/test/model/content_test.dart: all content examples are tested (failed)
FileSystemException: Cannot open file, path = '/C:/Users/RUNNER~1/AppData/Local/Temp/flutter_customer_testing.zulip.4a7c3de6/tests/test/model/content_test.dart' (OS Error: The filename, directory name, or volume label syntax is incorrect.
, errno = 123)
dart:io                               _File.readAsStringSync
test\model\content_test.dart 1082:39  main.<fn>
::endgroup::

I'm not sure what's wrong, but don't really feel like finding out (or working out how to fix it) -- and, conveniently, there's really no need to do so.  See comment.

This is needed for #239. See https://github.com/flutter/tests/pull/368 and its CI result at https://github.com/flutter/tests/actions/runs/9197725826/job/25298839228?pr=368#step:3:9762 .

Sure; merged.


Code coverage doesn't get uploaded to coveralls.io

Arguably it's almost certainly a problem in my setup, but I'm not finding it...
Could someone have a look at https://github.com/pierrechevalier83/matrix_display and tell me if I'm missing a crucial bit of setup?
I tried to follow the example in the readme. Travis runs, prints "Uploading coverage" in its log and exit successfully but still I'm not able to see any coverage generated on coveralls.io...

same here. Just tried to set it up for https://github.com/projectfluent/fluent-locale-rs and travis reports "Uploading coverage" but nothing happens.


🐛 [Bug] Send Notification E-Mail on staging failed

:bug: Bugreport
On staging sending Gradido or create Gradido failed if email isn't disabled.
Error from community server
Could not send email: unknown Cake\Network\Exception\SocketException
todo:

Check why E-Mail sending failed
Find a way to make a warning instead of error from it, because transaction is working, but interface say not working.

I have found out why email sending was failing.
It was simply a wrong configuration in config/app.php
The default community server config will be fixed with #485

I have try to make a warning instead an Error if sending email failed with  #485.
The Problem is with php or cakephp I'm not entirly sure, it exist multiple Error Models.
This specific Error by sending E-Mails I cannot catch. My Catch-Handler will be simply ignored.
The only thing I could archive (already in the past) that cakephp return me this type of error as json not as html.
So currently the only fix  I see for it where to move the email function into login-server.
But with the new Apollo Server in sight, I don't think it's worth the effort.


[Metrics::GitHub] Fix issue in calculation of github metrics

This should fix https://github.com/CocoaPods/metrics.cocoapods.org/issues/31 I hope

cc @orta, @floere

:+1:

Cool

:tada:


Ensure sources path is added to sumo file post deploy.

This update ensures that sumo can find the sumo_sources.json file. The sumo.conf file is being generated by terraform.  # Interested parties
Tag (@ mention) interested parties or, if unsure, @duracloud/committers

We don't want to do this.


TOTP Does Not Redirects To The Authentication Page

Issue

Configure basic auth as the first step and the TOTP as the second step for a service provider, with OAuth2 as the inbound authentication protocol.
Try to log in to the application.
Once you are successfully authenticated with the basic auth, you will be redirected to the TOTP authentication page with the redirected URL having the oauth2 path parameter appended.

Probable cause for this issue is we are using the relative path for the redirection[1]. We can fix this by changing [1] as shown below.
response.sendRedirect(IdentityUtil.getServerURL(totpLoginPageUrl, true, true));
[1] -  https://github.com/wso2-extensions/identity-outbound-auth-totp/blob/v2.0.14/component/authenticator/src/main/java/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticator.java#L180
Related Issue - https://github.com/wso2/product-is/issues/6431
Affected Versions

IS-5.8.0
totp.connector-2.0.14

The reproduce steps for IS-5.8.0 is as follows.

Configure two service provider with OIDC as the inbound protocol.
For one sp configure basic auth as the first step and the TOTP as the second step, for the second sp configure basic auth.
Login to the second sp,then in another tab try to login to the first sp you will be redirected to the TOTP authentication page with the redirected URL having the oauth2 path parameter appended.


Question: Can I import partials / content from another file?

There is the include function (that requires some setup), is it what you are looking for?

Yeah I had a look at that, I'm embedding some templates into the assembly,, which is not compatible with the ITemplateLoader interface
public string Load(TemplateContext context, SourceSpan callerSpan, string templateName, out string templateFilePath)

In the end I just made my own extension which was totally sweet.
script.Import("include_css", function: (Func<string, string>)(fileName =>
{
    return cssFiles.GetOrAdd(fileName, _fileName =>
    {
        var css = assembly.ReadFile(x => x.EndsWith(_fileName));
        return $"<style>{css}</style>";
    });
}));


MySql5 view parenthesis

Describe the bug
A consistent failure on view creation within MySQL5.x, especially those containing UNION, throws
1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'union

A traceback to /target/run shows the offending *.sql of form:
create view schema.table__dbt_tmp as (
  (
    select *
    from schema.table_1A
  )
  union
  (
    select *
    from schema.table_1B
  )
);

Removing the first parenthetical grouping, so that the query reads
create view schema.table__dbt_tmp as
  (
    select *
    from schema.table_1A
  )
  union
  (
    select *
    from schema.table_1B
  )

results in a working query. Likely a final parsing step just needs amending, but not certain yet where that is in the adapter stack...

also running into this problem
changing the offending model to {{config(materialized="table")}} rather than {{config(materialized="view")}} works fine as no parenthesis are added.
obviously a table is not as useful as a view, but just figured it was worth adding more data points.

Same here. Will this be fixed somewhere soon?
The syntax in Mysql 5.7 should be  as simple as. So the wrapping brackets must be removed.
create view [view_name] as
select * from table


Duplicating code if wrapping start and end HTML tag in separate if statements

The following minimal example code ...
{{ if .url }}{{ end }}

Content

{{ if .url }}{{ end }}

... duplicates to the following upon format:
{{ if .url }}{{ end }}

Content

{{ if .url }}{{ end }}

Content

{{ if .url }}{{ end }}

My current workaround is this:

{{ if .url }}{{ end }}

Content

{{ if .url }}{{ end }}

Hey there, sadly this is notoriously hard to fix as currently the template is parsed as a tree. The go formatter invokes the prettier html formatter for the contained text, but that one struggles when there are missing tags etc.
I'll try to find a solution to work around this. Thanks for reporting the issue.

@schnerring sorry, I have this nearly fixed – but until the HTML formatter has an option to disable auto-closing tags, I'll have to keep this open.
Related prettier issue: https://github.com/prettier/prettier/issues/5665

Would it be possible to error & link to this issue instead of duplicating code?
I'm pretty sure this pattern isn't allowed in JSX.. it seems reasonable to not allow it until there's a workaround.

It moght be worth looking at how handlebars was implemented 🤔

@schnerring sorry, I have this nearly fixed – but until the HTML formatter has an option to disable auto-closing tags, I'll have to keep this open.

As I've mentioned, I have a workaround, so no pressure. 😄 Thanks for looking into this!


🚀 Feature: Set Author for GitHub Pull Request

🔖 Feature description
Allow users to specify the author's name and email when opening a PR using the template action publish:github:pull-request.
🎤 Context
Implementing this would make the action publish:github:pull-request achieve greater parity with other similar actions that already support this feature, such as publish:gitlab and github:repo:push.
Having a company email associated with a commit & PR is mandatory at many organizations, and is often enforced using tests. Because the publish:github:pull-request action defaults to using the Primary email on the GitHub account, for many users (such as myself) this results in PRs that are impossible to merge.
✌ Possible Implementation
Support this feature is as simple as upgrading a dependency and then adding inputs to an action:

Update plugin-scaffolder-backend to use version 4.1.0 or higher of its dependency octokit-plugin-create-pull-request, which added support for author and committer options.
Update githubPullRequest.ts to take the inputs gitAuthorName and gitAuthorEmail and pass them to octokit.

👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, but I'm happy to collaborate on a PR with someone else

Requesting that we re-open this issue. I think this would be useful. Looks like the 2 PRs to implement it did not quite make it across the line.

Sure

@freben I also currently stumbled upon this and would appreciate this to be implemented.

It looks like this has been implemented by https://github.com/backstage/backstage/pull/24628


How to use theme in next js with  next-themes

import { useTheme } from "next-themes"
this usage in shad/cn ui

@kalimacpro Hi,
As I known, "next-theme" just wrap logics of modification of data-theme attribute on the html element.
Luckily, sira use same attribute to control theme.
So you can use it like its documentation shown as well.


[SPARK-25102][SQL][2.4] Write Spark version to ORC/Parquet file metadata

What changes were proposed in this pull request?
This is a backport of https://github.com/apache/spark/pull/22932 .
Currently, Spark writes Spark version number into Hive Table properties with spark.sql.create.version.
parameters:{
  spark.sql.sources.schema.part.0={
    "type":"struct",
    "fields":[{"name":"a","type":"integer","nullable":true,"metadata":{}}]
  },
  transient_lastDdlTime=1541142761,
  spark.sql.sources.schema.numParts=1,
  spark.sql.create.version=2.4.0
}

This PR aims to write Spark versions to ORC/Parquet file metadata with org.apache.spark.sql.create.version because we used org.apache. prefix in Parquet metadata already. It's different from Hive Table property key spark.sql.create.version, but it seems that we cannot change Hive Table property for backward compatibility.
After this PR, ORC and Parquet file generated by Spark will have the following metadata.
ORC (native and hive implmentation)
$ orc-tools meta /tmp/o
File Version: 0.12 with ...
...
User Metadata:
  org.apache.spark.sql.create.version=3.0.0

PARQUET
$ parquet-tools meta /tmp/p
...
creator:     parquet-mr version 1.10.0 (build 031a6654009e3b82020012a18434c582bd74c73a)
extra:       org.apache.spark.sql.create.version = 3.0.0
extra:       org.apache.spark.sql.parquet.row.metadata = {"type":"struct","fields":[{"name":"id","type":"long","nullable":false,"metadata":{}}]}

Why are the changes needed?
This backport helps us handle this files differently in Apache Spark 3.0.0.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the Jenkins with newly added test cases.

Test build #120897 has started for PR 28142 at commit 18e6932.

cc @cloud-fan and @HyukjinKwon
Also, cc @gatorsmile

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25589/
Test PASSed.

Test build #120897 has finished for PR 28142 at commit 18e6932.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120897/
Test FAILed.

looks like the file statistics is a bit different between 2.4 and 3.0 and causes some test failures.

Oops. Thank you! I'll fix them.

Test build #120921 has started for PR 28142 at commit 65c2a32.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25613/
Test PASSed.

Test build #120921 has finished for PR 28142 at commit 65c2a32.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120921/
Test PASSed.

Merged to branch-2.4. Thank you, @cloud-fan and @HyukjinKwon .


ProcessorTopology unit tests

@ymatsuda

Enforce unique topic names in sinks.
Du-duplicate sink / source nodes in sources() / sinks().

Why do you think we have to enforce uniqueness of sink topic names?

I think we shouldn't require uniqueness of sink topic names. And if I remember correctly, I intensionally removed such a restriction.

lgtm


fix: typo

This typo was leading to me scratching my head for a while on why the operator can't get the ocirepositories although the role needed is already there. cc: @dirien

@budimanjojo awesome catch! Let me release this under version 0.7.2

hey @budimanjojo,
0.7.2 chart is out! Thanks for your contribution! 🥳


filter storageClass by provisioner

Summary
test step:

install env: https://github.com/harvester/harvester/issues/2405#issuecomment-1549634520
Create a volume with non-default storageClass
Use volume to generate snapshots
Restore the volume using a snapshot

PR Checklist
~- Is this a multi-tenancy feature/bug?
- [ ] Yes, the relevant RBAC changes are at:~
~- Do we need to backport changes to the old Rancher UI, such as RKE1?
- [ ] Yes, the relevant PR is at:~
~- Are backend engineers aware of UI changes?
- [ ] Yes, the backend owner is:~
Fixes #

https://github.com/harvester/harvester/issues/3949

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

@mergify backport release-harvester-v1.2 release-harvester-v1.3


snk-cli

Create a seperate snk-cli project so you can generate a cli without depending on the full snk app

This would also stop the SNK CLI from being installed when you install a cli build with snk.


feat(cloud-masthead): HC-1993 Expose a new authentication checking method for the docs/console team

Related Ticket(s)
https://jsw.ibm.com/browse/HC-1993
Description
The goal of this PR is to expand the utility for checking the Cloud login cookie to also provide an option for checking against the console API. Additionally, a prop should be added to the cloud-masthead-container component that allows for selecting between the two auth methods.
This is currently a work in progress.
Changelog
New

added additional auth checking method to existing cloud login utility

Changed

changed filenames to encompass broader usage of utility
stubs out some tests for new auth method
adds prop for selecting auth method

Removed

n/a

@annawen1 @jeffchew @proeung
Posting this work in progress in order to get some guidance. I've expanded the cloud login utility to include an option for checking against the console API instead of using the cookie method. The goal is to provide a prop to cloud-masthead-container that allows for selecting between the two options. I'm not certain how to provide this prop and could use some help. Please look over what I have so far and advise.

@annawen1 @jeffchew @proeung @asudoh
Ok, I've added the prop we need. Curious how complex this needs to get with regard to the new auth API method, being an async operation. Should this "utility" instead be wrapped into a larger "service" a la the ProfileAPI and tied into the store as that is?

@annawen1 @jeffchew @proeung
Ok, I've added the prop we need. Curious how complex this needs to get with regard to the new auth API method, being an async operation. Should this "utility" instead be wrapped into a larger "service" a la the ProfileAPI and tied into the store as that is?

Yeah, I think we should follow with what we've done for the global masthead. Maybe set up a service specifically for cloud console for now, and then tie that into the store.

Ok. Ready for proper review.

@huntermacd Thanks for the update!
@annawen1 and @gptt916, can you both help review this PR? Thanks!


[CHANGE ME] Re-generated  to pick up changes in the API or client library generator.

This PR was generated using Autosynth. :rainbow:
Here's the log from Synthtool:
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:7231f27272231a884e09edb5953148c85ecd8467780d33c4a35c3e507885715b
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/redis/artman_redis_v1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/redis-v1beta1.
synthtool > Running generator for google/cloud/redis/artman_redis_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/redis-v1.
.eslintignore
.eslintrc.yml
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.jsdoc.js
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/docs.cfg
.kokoro/continuous/node10/lint.cfg
.kokoro/continuous/node10/samples-test.cfg
.kokoro/continuous/node10/system-test-grpcjs.cfg
.kokoro/continuous/node10/system-test.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node11/common.cfg
.kokoro/continuous/node11/test.cfg
.kokoro/continuous/node6/common.cfg
.kokoro/continuous/node6/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/presubmit/node10/common.cfg
.kokoro/presubmit/node10/docs.cfg
.kokoro/presubmit/node10/lint.cfg
.kokoro/presubmit/node10/samples-test.cfg
.kokoro/presubmit/node10/system-test-grpcjs.cfg
.kokoro/presubmit/node10/system-test.cfg
.kokoro/presubmit/node10/test.cfg
.kokoro/presubmit/node11/common.cfg
.kokoro/presubmit/node11/test.cfg
.kokoro/presubmit/node6/common.cfg
.kokoro/presubmit/node6/test.cfg
.kokoro/presubmit/node8/common.cfg
.kokoro/presubmit/node8/test.cfg
.kokoro/presubmit/windows/common.cfg
.kokoro/presubmit/windows/test.cfg
.kokoro/publish.sh
.kokoro/release/publish.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.nycrc
.prettierignore
.prettierrc
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
codecov.yaml
renovate.json
synthtool > Replaced 'https:\\/\\/cloud\\.google\\.com[\\s\\*]*http:\\/\\/(.*)[\\s\\*]*\\)' in src/v1beta1/doc/google/protobuf/doc_timestamp.js.
synthtool > Replaced 'https:\\/\\/cloud\\.google\\.com[\\s\\*]*http:\\/\\/(.*)[\\s\\*]*\\)' in src/v1/doc/google/protobuf/doc_timestamp.js.
synthtool > Replaced 'toISOString\\]' in src/v1beta1/doc/google/protobuf/doc_timestamp.js.
synthtool > Replaced 'toISOString\\]' in src/v1/doc/google/protobuf/doc_timestamp.js.

><EMAIL_ADDRESS>install /tmpfs/src/git/autosynth/working_repo/node_modules/grpc
> node-pre-gyp install --fallback-to-build --library=static_library

node-pre-gyp WARN Using needle for node-pre-gyp https download
[grpc] Success: "/tmpfs/src/git/autosynth/working_repo/node_modules/grpc/src/node/extension_binary/node-v57-linux-x64-glibc/grpc_node.node" is installed via remote

><EMAIL_ADDRESS>postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs
> node scripts/postinstall

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 1105 packages from 1301 contributors and audited 6740 packages in 21.975s
found 1 low severity vulnerability
  run `npm audit fix` to fix them, or `npm audit` for details

><EMAIL_ADDRESS>fix /tmpfs/src/git/autosynth/working_repo
> eslint --fix '**/*.js'

synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@JustinBeckwith @alexander-fenster looks like we're missing a proto file (google/api/resource.proto) here. I can manually add it for now, but this PR makes me think that it might not get updated in the future?

@jkwlui do you know how we decide which protos get included at synth time?  Is this a gapic config thing?

I believe it needs to be added to gax-nodejs. @alexander-fenster can you help?

Something similar to this?

Nope. This one is different. api/resource.proto is a new file (added 5 days ago). The whole api/ folder is listed as common protos but looks like somewhere we are just stuck with the old version of the folder. Looking.

We need to roll out new google-proto-files first. When we publish it, it will rebuild the tarball that has all the common protos. It's actually a good thing to do it time to time to catch the latest updates to common directories. https://github.com/googleapis/nodejs-proto-files/pull/161

Just a heads up - there are some problems with adding this new resource.proto (it breaks proto files loading in gax), I'm still working on it but it's likely won't work till tomorrow.

@callmehiphop It worked! I'm not sure if we need to merge it since it's an incompatible change that breaks compatibility for v1 API - it's Yoshi's call. But the new proto package works.

I assume we still want it but we'll have to make a semver major bump? I'm actually not really sure what our policy on breaking gapic changes is.

Not sure on the current status here.  Will follow up with the team today, but for now lets not merge this one.


global style on next.js not being applied

Bug report
Describe the bug
Hey there, first time user here 👋  (although an avid follower from the start)
I just tried creating a GlobalStyles component on a next.js app, but no matter what i put it there (body, html, .someGlobalClass) it doesn’t seem to be applied.
am i doing something wrong?
To Reproduce
Either see this codesandbox example or:

Follow the Using Next.js with Stitches post
Add a css.global call
See error

Expected behavior
Global styles should be applied on Next.js apps
Screenshots

System information

OS: macOS and codesandbox
Version of stitches: tested stable 0.0.2 and 0.0.3-canary.4
Version of Next.js: 9.5.3
Version of Node.js: 12.16.3

Thanks for raising this.
The css.global API changed a little since 0.0.2 (which is the documented version right now)
css.global now returns a function that needs to be invoked within your top level component.
I see you're trying to wrap it in a Component. We're also considering that API for the react layer. There's a discussion about this here: https://github.com/modulz/stitches/discussions/285
The Sandbox you linked is not starting for me, probably an issue on their side. But can you try returning css.global instead of returning null?
If that doesn't work, then I suggest:
const globalStyled = css.global({ ...styles })

const App = () => {
  globalStyles();

  return <div />
}

wow, amazing response time 😱
yep, that definitely did the trick ✨
if you need any help writing docs for the next version, just ping me here ✌

@vitordino awesome, thanks so much