Not fully compatible with Yarn PnP

https://github.com/remigailard80/Storybook-Vite

Env : Node 14.17
MacBook Air (M1, 2020) Big Sur 11.3.1
I tried to start storybook project with vite with this flow.

yarn create vite
cd vite-project
npx sb@next init --builder storybook-builder-vite
yarn storybook

and saw this error.
Error: storybook-builder-vite tried to access @storybook/core-common, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

After saw this error, I tried install @storybook/core-common, @storybook/client-api, @storybook/client-logger(?).
Eventually, it succeeded in running the development server, but it was caught in infinite loading.
But when i use nodeLinker: node-modules,  It works fine.

but it was caught in infinite loading

Was there an error in the console?

No, just
Info @storybook/react v6.3.12
info
info => Loading presets
info => Using prebuilt manager
Pre-bundling dependencies:
  react
  react-dom
  @mdx-js/react
  @storybook/addon-docs
  @storybook/client-api
  (...and 3 more)
(this will be run only when your dependencies or config have changed)
╭──────────────────────────────────────────────────────╮
│                                                      │
│   Storybook 6.3.12 started                           │
│   1.38 s for preview                                 │
│                                                      │
│    Local:            http://localhost:6006/          │
│    On your network:  http://<IP_ADDRESS>:6006/    │
│                                                      │
╰──────────────────────────────────────────────────────╯
Sourcemap for "/Users/kimminseok/viteproject/Storybook-Vite/.yarn/__virtual__/markdown-to-jsx-virtual-59b0b6127e/0/cache/markdown-to-jsx-npm-7.1.3-7b61f9f1da-9809d898ef.zip/node_modules/markdown-to-jsx/dist/index.module.js" points to missing source files
Sourcemap for "/Users/kimminseok/viteproject/Storybook-Vite/.yarn/__virtual__/react-element-to-jsx-string-virtual-452a1c2117/0/cache/react-element-to-jsx-string-npm-14.3.4-47e7176d93-42bcd4423f.zip/node_modules/react-element-to-jsx-string/dist/esm/index.js" points to missing source files
[BABEL] Note: The code generator has deoptimised the styling of /Users/kimminseok/viteproject/Storybook-Vite/node_modules/.vite/chunk-SYLNUZW7.js?v=b3c9673a as it exceeds the max of 500KB.
Sourcemap for "/Users/kimminseok/viteproject/Storybook-Vite/.yarn/cache/<EMAIL_ADDRESS>points to missing source files
[BABEL] Note: The code generator has deoptimised the styling of /Users/kimminseok/viteproject/Storybook-Vite/node_modules/.vite/@storybook_addon-docs.js?v=b3c9673a as it exceeds the max of 500KB.
Sourcemap for<EMAIL_ADDRESS>points to missing source files
Sourcemap for<EMAIL_ADDRESS>points to missing source files
Sourcemap for "/Users/kimminseok/viteproject/Storybook-Vite/node_modules/.vite/react.js" points to missing source files
Sourcemap for<EMAIL_ADDRESS>points to missing source files
Sourcemap for<EMAIL_ADDRESS>points to missing source files
Sourcemap for "/Users/kimminseok/viteproject/Storybook-Vite/node_modules/.vite/react_jsx-dev-runtime.js" points to missing source files
Sourcemap for "/Users/kimminseok/viteproject/Storybook-Vite/node_modules/.vite/chunk-VJ6LBEXO.js" points to missing source files
Sourcemap for<EMAIL_ADDRESS>points to missing source files

The exact errors were,

Required package: @storybook/core-common
ERR! Required by: storybook-builder-vite@virtual:c56b46d83dc705f61d645efafd50b5dd10b694a413a2075f2bfa433bbaa41df431f824c0f747468efbf1694d7d2f15adbae617c2c5c3f6b6e0b1978b92526b7c#npm:0.1.5 (via /Users/kimminseok/viteproject/Storybook-Vite/.yarn/__virtual__/storybook-builder-vite-virtual-9b0feccb35/0/cache/storybook-builder-vite-npm-0.1.5-e8799e026b-ee76a1b16a.zip/node_modules/storybook-builder-vite/)

[vite] Internal server error: Failed to resolve import "@storybook/client-api" from<EMAIL_ADDRESS>Does the file exist?

File<EMAIL_ADDRESS>  5  |  import '/Users/kimminseok/viteproject/Storybook-Vite/.yarn/__virtual__/@storybook-core-client-virtual-dce2e9bb6b/0/cache/<EMAIL_ADDRESS>*/
  6  |
  7  |  import { addDecorator, addParameters, addLoader, addArgTypesEnhancer, addArgsEnhancer } from '@storybook/client-api';
     |                                                                                ^
  8  |  import { logger } from '@storybook/client-logger';
  9  |  import * as config_0 from '/@fs//Users/kimminseok/viteproject/Storybook-Vite/.yarn/__virtual__/@storybook-addon-docs-virtual-0c38f8d288/0/cache/<EMAIL_ADDRESS>

[vite] Internal server error: Failed to resolve import "@storybook/client-logger" from<EMAIL_ADDRESS>Does the file exist?
  Plugin: vite:import-analysis
  File<EMAIL_ADDRESS>  6  |
  7  |  import { addDecorator, addParameters, addLoader, addArgTypesEnhancer, addArgsEnhancer } from '@storybook/client-api';
  8  |  import { logger } from '@storybook/client-logger';
     |                          ^
  9  |  import * as config_0 from '/@fs//Users/kimminseok/viteproject/Storybook-Vite/.yarn/__virtual__/@storybook-addon-docs-virtual-0c38f8d288/0/cache/<EMAIL_ADDRESS>  10 |  import * as config_1 from '/@fs//Users/kimminseok/viteproject/Storybook-Vite/.yarn/__virtual__/@storybook-addon-docs-virtual-0c38f8d288/0/cache/<EMAIL_ADDRESS>

This might be solved by https://github.com/eirslett/storybook-builder-vite/pull/160.
Can you please try updating to v0.1.9 and trying again?  Thanks!

I'm on ^0.1.10 and still seeing this using storybook ^6.4.0

We needed to revert #160.  If you have a minute, could you try using version 0.1.9 to see if it does solve this particular issue?

Still same bug using 0.1.9,
{
  "name": "vite-project",
  "version": "0.0.0",
  "scripts": {
    "dev": "vite",
    "build": "vite build",
    "serve": "vite preview",
    "storybook": "start-storybook -p 6006",
    "build-storybook": "build-storybook"
  },
  "dependencies": {
    "react": "^17.0.0",
    "react-dom": "^17.0.0"
  },
  "devDependencies": {
    "@babel/core": "^7.16.0",
    "@storybook/addon-actions": "6.4.7",
    "@storybook/addon-essentials": "6.4.7",
    "@storybook/addon-links": "6.4.7",
    "@storybook/react": "6.4.7",
    "@vitejs/plugin-react": "^1.0.0",
    "babel-loader": "^8.2.3",
    "storybook-builder-vite": "0.1.9",
    "vite": "^2.6.4"
  }
}

Can Confirm the bug still exists, my packages are
{   "name": "vite-project",   "version": "0.0.0",   "scripts": {     "dev": "vite",     "build": "tsc && vite build",     "preview": "vite preview",     "storybook": "start-storybook -p 6006",     "build-storybook": "build-storybook"   },   "dependencies": {     "clsx": "^1.1.1",     "react": "^17.0.2",     "react-dom": "^17.0.2"   },   "devDependencies": {     "@babel/core": "^7.16.5",     "@mdx-js/react": "^1.6.22",     "@storybook/addon-actions": "^6.5.0-alpha.4",     "@storybook/addon-docs": "^6.4.9",     "@storybook/addon-essentials": "^6.4.9",     "@storybook/addon-links": "^6.5.0-alpha.4",     "@storybook/client-api": "^6.4.9",     "@storybook/client-logger": "^6.4.9",     "@storybook/core-common": "^6.4.9",     "@storybook/react": "^6.4.9",     "@types/babel__core": "^7.1.17",     "@types/mdx-js__react": "^1.5.5",     "@types/react": "^17.0.37",     "@types/react-dom": "^17.0.11",     "@vitejs/plugin-react": "^1.1.3",     "autoprefixer": "^10.4.0",     "babel-loader": "^8.2.3",     "glob": "^7.2.0",     "postcss": "^8.4.5",     "storybook-builder-vite": "^0.1.11",     "tailwindcss": "^3.0.7",     "typescript": "^4.5.4",     "vite": "^2.7.3",     "webpack": "^5.65.0"   },   "packageManager"<EMAIL_ADDRESS>}
Falling back to nodeLinker: node-modules works.

It seems that dependency is really missing in the package.json, I'll create an MR adding it and will try running the fork.

~It seems that dependency is really missing in the package.json, I'll create an MR adding it and will try running the fork.~
It's actually already added by one of the latest MRs but not yet released to NPM.

Any update on when it will be released?

I'm not sure what PR @erykpiast is talking about, but I've just released 0.1.14 of this project.

You fixed it here @IanVS https://github.com/eirslett/storybook-builder-vite/pull/195/files thanks for releasing it! :)

Not fixed for me with Yarn 3, PNP and Zero Installs:
info @storybook/react v6.4.15 info  ERR! Error: storybook-builder-vite tried to access @storybook/core-common (a peer dependency) but it isn't provided by your application; this makes the require call ambiguous and unsound. ERR!  ERR! Required package: @storybook/core-common ERR! Required by: storybook-builder-vite@virtual:a51224646ccff2cb8e208bda6e4beeb81384f7c6ddd74e69a01386f1a661bd5684f4b1659d343f4da6250c7c59e4efcd224ed1f5b2a06dd9fe5048fe7d3e1523#npm:0.1.14 (via /Users/jt/Developer/onex-design/.yarn/__virtual__/storybook-builder-vite-virtual-45b03745a2/0/cache/storybook-builder-vite-npm-0.1.14-a14c8b1d4b-97c1b8eeb8.zip/node_modules/storybook-builder-vite/dist/)

It kind of works now when you add @storybook/core-common as a dependency to your project (exactly as it asks for). For me, it runs with 0.1.14, but Storybook fails at runtime :/
<EMAIL_ADDRESS>net::ERR_ABORTED 404 (Not Found)

Another issue I'd say.

I actually got this working, although it does take some effort. Here's what I did:
1: Add this to your viteFinal function in main.js
config.optimizeDeps.include = [
      ...(config.optimizeDeps?.include ?? []),
      "@mdx-js/react",
      "@storybook/addon-docs",
      "@storybook/react",
      "@storybook/client-api",
      "@storybook/client-logger",
      "fast-deep-equal",
      "lodash",
      "lodash-es",
      "lodash/isPlainObject",
      "lodash/mapValues",
      "lodash/pickBy",
      "lodash/pick",
      "lodash/startCase",
      "lodash/isFunction",
      "lodash/isString",
      "util-deprecate",
      "@storybook/csf",
      "global",
      "synchronous-promise",
      "memoizerific",
      "stable",
      "doctrine",
      "html-tags",
      "escodegen",
      "acorn",
      "acorn-jsx",
      "@base2/pretty-print-object",
      "prop-types",
      "react-dom",
      "qs",
      "uuid-browser",
      "uuid-browser/v4",
      "jest-mock",
    ];
    config.define = { ...config.define, global: {} };

Install the following libraries:
"@mdx-js/react",
    "@storybook/addon-docs",
    "@storybook/react",
    "@storybook/client-api",
    "@storybook/client-logger",
    "fast-deep-equal",
    "lodash",
    "lodash-es",
    "util-deprecate",
    "@storybook/csf",
    "global",
    "synchronous-promise",
    "memoizerific",
    "stable",
    "doctrine",
    "html-tags",
    "escodegen",
    "acorn",
    "acorn-jsx",
    "@base2/pretty-print-object",
    "prop-types",
    "react-dom",
    "qs",
    "uuid-browser",
    "jest-mock",

Install and unplug object-inspect. I also had to add this resolution to package.json:
"resolutions": {
    "object-inspect": "1.10.2"
  }

Go to the unplugged object-import's index.js and remove .custom from line 32.
Remove any existing node_modules directories and run yarn storybook
After these steps the default stories showed up for me.

Right now im stuck here
Uncaught SyntaxError: The requested module '/node_modules/@storybook/vue3/node_modules/@storybook/core/client.js?v=69109ef5' does not provide an export named 'start'

I dont know how to fix this. Currently i am trying to use latest
"storybook-builder-vite": "^0.1.22",
"@storybook/vue3": "^6.5.0-alpha.52"

@samydoesit thanks for the report, but this issue is about problems with yarn. Would you mind opening a new issue and including a link to a reproduction repo?  That's the best way for us to help you out.

Hi, is anyone still having this issue?  If not, I'd like to close this issue.  If so, can you please share what versions you are using?

Going to close for now, speak up if you think this should be re-opened.

Getting the same issue with 0.1.33
5:29:28 PM [vite] Internal server error: Failed to resolve import<EMAIL_ADDRESS>from<EMAIL_ADDRESS>Does the file exist?
  Plugin: vite:import-analysis
  File<EMAIL_ADDRESS>  12 |      } from '@storybook/client-api';
  13 |      import { logger } from '@storybook/client-logger';
  14 |      import * as config_0 from<EMAIL_ADDRESS>     |                                 ^
  15 |  import * as config_1 from<EMAIL_ADDRESS>  16 |  import * as config_2 from '@storybook/react/dist/esm/client/preview/config'
      at formatError (/Users/yonatanbd/Code/clients/openreel/balloon-web/app/node_modules/vite/dist/node/chunks/dep-59dc6e00.js:38663:46)
      at TransformContext.error (/Users/yonatanbd/Code/clients/openreel/balloon-web/app/node_modules/vite/dist/node/chunks/dep-59dc6e00.js:38659:19)
      at normalizeUrl (/Users/yonatanbd/Code/clients/openreel/balloon-web/app/node_modules/vite/dist/node/chunks/dep-59dc6e00.js:56830:26)
      at async TransformContext.transform (/Users/yonatanbd/Code/clients/openreel/balloon-web/app/node_modules/vite/dist/node/chunks/dep-59dc6e00.js:56979:57)
      at async Object.transform (/Users/yonatanbd/Code/clients/openreel/balloon-web/app/node_modules/vite/dist/node/chunks/dep-59dc6e00.js:38900:30)
      at async doTransform (/Users/yonatanbd/Code/clients/openreel/balloon-web/app/node_modules/vite/dist/node/chunks/dep-59dc6e00.js:55857:29)

Fixed it with installing @storybook/addon-docs manually npm i @storybook/addon-docs -D

yes, version ^6.4.22 in package.json

Wild.  Could you reproduce the problem and share the output of npx sb@next info?  That should show the versions of storybook packages.  If that doesn't work, can you share the versions out of your package.json?  And even better, if you can share a repo that reproduces the error.

this is the storybook packages I have currently installed (after fixing the error):
    "@storybook/addon-actions": "^6.4.22",
    "@storybook/addon-docs": "^6.4.22",
    "@storybook/addon-essentials": "^6.4.22",
    "@storybook/addon-interactions": "^6.4.22",
    "@storybook/addon-links": "^6.4.22",
    "@storybook/builder-vite": "^0.1.33",
    "@storybook/react": "^6.4.22",
    "@storybook/testing-library": "^0.0.11",

Before that, everything was up to date and working, it started to have errors after deleting package-lock.json and reinstalling all packages (recreating package-lock.json ) I guess that somewhere there storybook didn't link to the right @storybook/addon-essentials version, so installing it manually with the latest version fixed it

https://github.com/remigailard80/Storybook-Vite
Env : Node 14.17
MacBook Air (M1, 2020) Big Sur 11.3.1
I tried to start storybook project with vite with this flow.

yarn create vite
cd vite-project
npx sb@next init --builder storybook-builder-vite
yarn storybook

and saw this error.
Error: storybook-builder-vite tried to access @storybook/core-common, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

After saw this error, I tried install @storybook/core-common, @storybook/client-api, @storybook/client-logger(?). Eventually, it succeeded in running the development server, but it was caught in infinite loading.
But when i use nodeLinker: node-modules, It works fine.

I still have the exact same problem using storybook 6.4.22 and yarn 3.2.1

@capozzid can you please share a reproduction so I can help troubleshoot what's happening?

Env: Node 14.19.1
yarn version: 3.2.1

.yarnrc.yml
yarnPath: .yarn/releases/yarn-3.2.1.cjs

Installation
npx sb init --builder @storybook/builder-vite

When running yarn storybook right after I get:
ERR! Error: @storybook/builder-vite tried to access @storybook/core-common (a peer dependency) but it isn't provided by your application; this makes the require call ambiguous and unsound.
ERR!
ERR! Required package: @storybook/core-common
ERR! Required by: @storybook/builder-vite@virtual:959e19889900d57733d0cc61e2a11c0681f159f2cf02f7c004bf73acfd312192a0ea4761b6e5c52cdd1a95b6abd0c5f437e57a7739b5bee5185722f01cb63061#npm:0.1.33 (via /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-builder-vite-virtual-08bca85baf/0/cache/@storybook-builder-vite-npm-0.1.33-e5da27d507-1c8fb0f9e2.zip/node_modules/@storybook/builder-vite/dist/)
ERR! Ancestor breaking the chain: user_interface@workspace:.
ERR!
ERR!
ERR! Require stack:
ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-builder-vite-virtual-08bca85baf/0/cache/<EMAIL_ADDRESS>ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-builder-vite-virtual-08bca85baf/0/cache/<EMAIL_ADDRESS>ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-core-server-virtual-d7c53a3d04/0/cache/<EMAIL_ADDRESS>ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-core-server-virtual-d7c53a3d04/0/cache/<EMAIL_ADDRESS>ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-core-server-virtual-d7c53a3d04/0/cache/<EMAIL_ADDRESS>ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-core-virtual-d0e4899fb0/0/cache/<EMAIL_ADDRESS>ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-core-virtual-d0e4899fb0/0/cache/<EMAIL_ADDRESS>ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-react-virtual-f3aa693647/0/cache/<EMAIL_ADDRESS>ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-react-virtual-f3aa693647/0/cache/<EMAIL_ADDRESS>ERR!     at Function.require$$0.Module._resolveFilename (/opt/erx-soft/code/typescript/user_interface/.pnp.cjs:31111:13)
ERR!     at Function.require$$0.Module._load (/opt/erx-soft/code/typescript/user_interface/.pnp.cjs:30965:42)
ERR!     at Module.require (internal/modules/cjs/loader.js:974:19)
ERR!     at require (internal/modules/cjs/helpers.js:101:18)
ERR!     at Object.<anonymous> (/opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-builder-vite-virtual-08bca85baf/0/cache/@storybook-builder-vite-npm-0.1.33-e5da27d507-1c8fb0f9e2.zip/node_modules/@storybook/builder-vite/dist/transform-iframe-html.js:4:23)
ERR!     at Module._compile (internal/modules/cjs/loader.js:1085:14)
ERR!     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
ERR!     at Object.require$$0.Module._extensions..js (/opt/erx-soft/code/typescript/user_interface/.pnp.cjs:31155:33)
ERR!     at Module.load (internal/modules/cjs/loader.js:950:32)
ERR!     at Function.require$$0.Module._load (/opt/erx-soft/code/typescript/user_interface/.pnp.cjs:30995:14)
ERR!  Error: @storybook/builder-vite tried to access @storybook/core-common (a peer dependency) but it isn't provided by your application; this makes the require call ambiguous and unsound.
ERR!
ERR! Required package: @storybook/core-common
ERR! Required by: @storybook/builder-vite@virtual:959e19889900d57733d0cc61e2a11c0681f159f2cf02f7c004bf73acfd312192a0ea4761b6e5c52cdd1a95b6abd0c5f437e57a7739b5bee5185722f01cb63061#npm:0.1.33 (via /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-builder-vite-virtual-08bca85baf/0/cache/@storybook-builder-vite-npm-0.1.33-e5da27d507-1c8fb0f9e2.zip/node_modules/@storybook/builder-vite/dist/)
ERR! Ancestor breaking the chain: user_interface@workspace:.
ERR!
ERR!
ERR! Require stack:
ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-builder-vite-virtual-08bca85baf/0/cache/<EMAIL_ADDRESS>ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-builder-vite-virtual-08bca85baf/0/cache/<EMAIL_ADDRESS>ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-core-server-virtual-d7c53a3d04/0/cache/<EMAIL_ADDRESS>ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-core-server-virtual-d7c53a3d04/0/cache/<EMAIL_ADDRESS>ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-core-server-virtual-d7c53a3d04/0/cache/<EMAIL_ADDRESS>ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-core-virtual-d0e4899fb0/0/cache/<EMAIL_ADDRESS>ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-core-virtual-d0e4899fb0/0/cache/<EMAIL_ADDRESS>ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-react-virtual-f3aa693647/0/cache/<EMAIL_ADDRESS>ERR! - /opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-react-virtual-f3aa693647/0/cache/<EMAIL_ADDRESS>ERR!     at Function.require$$0.Module._resolveFilename (/opt/erx-soft/code/typescript/user_interface/.pnp.cjs:31111:13)
ERR!     at Function.require$$0.Module._load (/opt/erx-soft/code/typescript/user_interface/.pnp.cjs:30965:42)
ERR!     at Module.require (internal/modules/cjs/loader.js:974:19)
ERR!     at require (internal/modules/cjs/helpers.js:101:18)
ERR!     at Object.<anonymous> (/opt/erx-soft/code/typescript/user_interface/.yarn/__virtual__/@storybook-builder-vite-virtual-08bca85baf/0/cache/@storybook-builder-vite-npm-0.1.33-e5da27d507-1c8fb0f9e2.zip/node_modules/@storybook/builder-vite/dist/transform-iframe-html.js:4:23)
ERR!     at Module._compile (internal/modules/cjs/loader.js:1085:14)
ERR!     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
ERR!     at Object.require$$0.Module._extensions..js (/opt/erx-soft/code/typescript/user_interface/.pnp.cjs:31155:33)
ERR!     at Module.load (internal/modules/cjs/loader.js:950:32)
ERR!     at Function.require$$0.Module._load (/opt/erx-soft/code/typescript/user_interface/.pnp.cjs:30995:14)

I was able to get this working, but it's not pretty.  First of all, it seems necessary to set pnpMode: loose in .yarnrc.yml.
Then, because yarn pnp prevents us from relying on the correct packages being installed in node_modules from other storybook packages, it's necessary to install many of the internal storybook packages into your project as well.  This is what I ended up with after hitting a "not found" error, adding the package, running yarn install and repeating the process:
"devDependencies": {
	// ...
    "@storybook/addon-actions": "^6.5.0-rc.0",
    "@storybook/addon-backgrounds": "^6.5.0-rc.0",
    "@storybook/addon-docs": "^6.5.0-rc.0",
    "@storybook/addon-essentials": "^6.5.0-rc.0",
    "@storybook/addon-interactions": "^6.5.0-rc.0",
    "@storybook/addon-links": "^6.5.0-rc.0",
    "@storybook/addon-measure": "^6.5.0-rc.0",
    "@storybook/addon-outline": "^6.5.0-rc.0",
    "@storybook/addons": "^6.5.0-rc.0",
    "@storybook/builder-vite": "^0.1.33",
    "@storybook/channel-postmessage": "^6.5.0-rc.0",
    "@storybook/channel-websocket": "^6.5.0-rc.0",
    "@storybook/client-api": "^6.5.0-rc.0",
    "@storybook/core-common": "^6.5.0-rc.0",
    "@storybook/node-logger": "^6.5.0-rc.0",
    "@storybook/preview-web": "^6.5.0-rc.0",
    "@storybook/react": "^6.5.0-rc.0",
    "@storybook/testing-library": "^0.0.11",
	// ...
  },

When you do this, it might be best to remove the ^ from the versions, because it's very important that the core storybook packages all end up resolving to the exact same version.
If anyone else here has a good understanding of yarn pnp and how to make things work more cleanly, I'd love to hear from you!

Using your solution I still get errors. The first one is the @mdx-js/react missing and then, once added, I get the following:
[vite] Internal server error: Failed to resolve import "global" from<EMAIL_ADDRESS>Does the file exist?
Plugin: vite:import-analysis
File<EMAIL_ADDRESS>1  |  import global from 'global';

I tried for a few days now, the last try I installed the not found packages then I got can not read custom of undefined from object-inspect. I am going to try set pnp mode to loose, but this change may break other workspaces

@capozzid oh right, I forgot about the global thing, I had to adjust that.  You can try adding it to your devDependencies for now, but I'm going to push a change to this builder to avoid using it, and use globalThis instead.

Thanks for your help @IanVS unfortunately I still have " TypeError: require_util_inspect() is undefined" error where storybook builds but can't display my stories

Honestly, it seems like vite support for yarn PNP is not terribly good. :(

Yeah, there's an unfixed compatibility problem, that breaks optional node-only modules usage within dependency packages.
I have a PR here https://github.com/vitejs/vite/pull/6493 but it's kind of blocked by the need to change how Vite's replacement module with usage warnings is implemented.
Meanwhile, I have a cleaned up fix here: https://github.com/swandir/vite/commit/927f524940cc24e3ea1cc0e50aa7c65d293ef573
Which I periodically apply on top of Vite releases and publish as tags
https://github.com/swandir/vite/releases/tag/v2.9.9-pnp
You can build and pack a tarball from a tag and use it via Yarn's file: protocol
https://yarnpkg.com/features/protocols

Having same issue.
Using: Storybook + SvelteKit
 16:40:06 [vite] Internal server error: Failed to resolve import "@storybook/client-api" from<EMAIL_ADDRESS>Does the file exist?
Deps:
"devDependencies": {
		"@babel/core": "^7.19.1",
		"@playwright/test": "^1.25.0",
		"@storybook/addon-actions": "^6.5.12",
		"@storybook/addon-essentials": "^6.5.12",
		"@storybook/addon-interactions": "^6.5.12",
		"@storybook/addon-links": "^6.5.12",
		"@storybook/addon-postcss": "^2.0.0",
		"@storybook/builder-vite": "^0.2.2",
		"@storybook/svelte": "^6.5.12",
		"@storybook/testing-library": "^0.0.13",
		"@sveltejs/adapter-auto": "next",
		"@sveltejs/kit": "next",
		"@types/cookie": "^0.5.1",
		"@typescript-eslint/eslint-plugin": "^5.27.0",
		"@typescript-eslint/parser": "^5.27.0",
		"autoprefixer": "^10.4.7",
		"babel-loader": "^8.2.5",
		"eslint": "^8.16.0",
		"eslint-config-prettier": "^8.3.0",
		"eslint-plugin-storybook": "^0.6.4",
		"eslint-plugin-svelte3": "^4.0.0",
		"postcss": "^8.4.14",
		"postcss-load-config": "^4.0.1",
		"prettier": "^2.6.2",
		"prettier-plugin-svelte": "^2.7.0",
		"svelte": "^3.50.1",
		"svelte-check": "^2.7.1",
		"svelte-loader": "^3.1.3",
		"svelte-preprocess": "^4.10.7",
		"tailwindcss": "^3.1.5",
		"@storybook/addon-svelte-csf": "^2.0.7",
		"tslib": "^2.3.1",
		"typescript": "^4.7.4",
		"vite": "^3.1.0"
	}

I have a PR open in the main storybook repo which will address this for storybook 7.0. For now the workaround is to add the missing packages to your package.json.

Piling onto this, when using Vue and PnP, builder-vite errors out completely even if @vitejs/plugin-vue is installed in the root project.
ERR! Error: @storybook/builder-vite requires @vitejs/plugin-vue to be installed when using @storybook/vue or @storybook/vue3.  Please install it and start storybook again.

afaik @vitejs/plugin-vue should be in peerDependencies along with a peerDependenciesMeta entry making it optional, same with @sveltejs/vite-plugin-svelte.

Opened a PR to add the missing peer deps into this repo: #500

As others have said, adding the dependency it's complaining about to package.json and then running yarn install again fixed the issue.
Under devDependencies add:
"@sveltejs/vite-plugin-svelte": "next". Like so:

As a TLDR for anyone visiting this thread: I can confirm that adding a ton of storybook packages with pnpMode: loose works without enabling nodeLinker: node_modules but I've added almost all @storybook packages and still have warnings - hope this can get fixed soon:
"dependencies": {
    "@zmvp/app": "*",
    "react": "^18.2.0",
    "react-dom": "^18.2.0"
  },
  "devDependencies": {
    "@babel/core": "^7.19.6",
    "@joshwooding/vite-plugin-react-docgen-typescript": "^0.0.5",
    "@storybook/addon-actions": "7.0.0-alpha.46",
    "@storybook/addon-backgrounds": "7.0.0-alpha.46",
    "@storybook/addon-docs": "7.0.0-alpha.46",
    "@storybook/addon-essentials": "7.0.0-alpha.46",
    "@storybook/addon-highlight": "7.0.0-alpha.46",
    "@storybook/addon-interactions": "7.0.0-alpha.46",
    "@storybook/addon-links": "7.0.0-alpha.46",
    "@storybook/addon-measure": "7.0.0-alpha.46",
    "@storybook/addon-outline": "7.0.0-alpha.46",
    "@storybook/addons": "7.0.0-alpha.46",
    "@storybook/blocks": "7.0.0-alpha.46",
    "@storybook/builder-manager": "7.0.0-alpha.46",
    "@storybook/builder-vite": "7.0.0-alpha.46",
    "@storybook/channel-postmessage": "7.0.0-alpha.46",
    "@storybook/channel-websocket": "7.0.0-alpha.46",
    "@storybook/client-api": "7.0.0-alpha.46",
    "@storybook/codemod": "7.0.0-alpha.46",
    "@storybook/core-client": "7.0.0-alpha.46",
    "@storybook/core-common": "7.0.0-alpha.46",
    "@storybook/core-server": "7.0.0-alpha.46",
    "@storybook/docs-tools": "7.0.0-alpha.46",
    "@storybook/instrumenter": "7.0.0-alpha.46",
    "@storybook/preview-web": "7.0.0-alpha.46",
    "@storybook/react": "7.0.0-alpha.46",
    "@storybook/react-vite": "7.0.0-alpha.46",
    "@storybook/source-loader": "7.0.0-alpha.46",
    "@storybook/store": "7.0.0-alpha.46",
    "@storybook/telemetry": "7.0.0-alpha.46",
    "@storybook/testing-library": "0.0.13",
    "acorn": "^8.8.1",
    "acorn-jsx": "^5.3.2",
    "react-docgen-typescript": "^2.2.2",
    "storybook": "7.0.0-alpha.46",
    "typescript": "^4.8.4",
    "vite": "^3.2.1"
  },

➤ YN0000: ┌ Resolution step
➤ YN0002: │ @devtools-ds/themes@npm:1.2.0 [bed0c] doesn't provide react-dom (paf1c0), requested by @design-systems/utils
➤ YN0002: │ @storybook/addon-docs@npm:7.0.0-alpha.46 [f53fc] doesn't provide @babel/core (p386ab), requested by @babel/plugin-transform-react-jsx
➤ YN0002: │ @storybook/addon-highlight@npm:7.0.0-alpha.46 doesn't provide react (p64130), requested by @storybook/addons
➤ YN0002: │ @storybook/addon-highlight@npm:7.0.0-alpha.46 doesn't provide react-dom (p7ed89), requested by @storybook/addons
➤ YN0002: │ @storybook/blocks@npm:7.0.0-alpha.46 [f53fc] doesn't provide react-dom (p2409b), requested by @storybook/theming
➤ YN0002: │ @storybook/blocks@npm:7.0.0-alpha.46 [f53fc] doesn't provide react-dom (p70599), requested by @storybook/api
➤ YN0002: │ @storybook/blocks@npm:7.0.0-alpha.46 [f53fc] doesn't provide react-dom (pa6103), requested by @storybook/components
➤ YN0002: │ @storybook/blocks@npm:7.0.0-alpha.46 [f53fc] doesn't provide react-dom (p79127), requested by @storybook/store
➤ YN0002: │ @storybook/blocks@npm:7.0.0-alpha.46 [f53fc] doesn't provide react-dom (p44138), requested by react-colorful
➤ YN0002: │ @storybook/builder-manager@npm:7.0.0-alpha.46 doesn't provide react (p09cf6), requested by @storybook/core-common
➤ YN0002: │ @storybook/builder-manager@npm:7.0.0-alpha.46 doesn't provide react-dom (pe7770), requested by @storybook/core-common
➤ YN0002: │ @storybook/builder-vite@npm:7.0.0-alpha.46 doesn't provide react (p1c84e), requested by @storybook/core-common
➤ YN0002: │ @storybook/builder-vite@npm:7.0.0-alpha.46 doesn't provide react (p20711), requested by @storybook/client-api
➤ YN0002: │ @storybook/builder-vite@npm:7.0.0-alpha.46 doesn't provide react (p7f539), requested by @storybook/source-loader
➤ YN0002: │ @storybook/builder-vite@npm:7.0.0-alpha.46 doesn't provide react-dom (p55850), requested by @storybook/core-common
➤ YN0002: │ @storybook/builder-vite@npm:7.0.0-alpha.46 doesn't provide react-dom (p51d21), requested by @storybook/client-api
➤ YN0002: │ @storybook/builder-vite@npm:7.0.0-alpha.46 doesn't provide react-dom (pf3d2d), requested by @storybook/source-loader
➤ YN0002: │ @storybook/builder-vite@npm:7.0.0-alpha.46 doesn't provide typescript (peff78), requested by @joshwooding/vite-plugin-react-docgen-typescript
➤ YN0002: │ @storybook/cli@npm:7.0.0-alpha.46 doesn't provide react (p56057), requested by @storybook/core-common
➤ YN0002: │ @storybook/cli@npm:7.0.0-alpha.46 doesn't provide react (pe3d22), requested by @storybook/core-server
➤ YN0002: │ @storybook/cli@npm:7.0.0-alpha.46 doesn't provide react-dom (p8085c), requested by @storybook/core-common
➤ YN0002: │ @storybook/cli@npm:7.0.0-alpha.46 doesn't provide react-dom (p0341f), requested by @storybook/core-server
➤ YN0002: │ @storybook/codemod@npm:7.0.0-alpha.46 doesn't provide @babel/preset-env (pbe658), requested by jscodeshift
➤ YN0002: │ @storybook/core-client@npm:7.0.0-alpha.46 [69c15] doesn't provide react (pa6103), requested by @storybook/addons
➤ YN0002: │ @storybook/core-client@npm:7.0.0-alpha.46 [69c15] doesn't provide react (pb4b62), requested by @storybook/store
➤ YN0002: │ @storybook/core-client@npm:7.0.0-alpha.46 [69c15] doesn't provide react (p01bfe), requested by @storybook/client-api
➤ YN0002: │ @storybook/core-client@npm:7.0.0-alpha.46 [69c15] doesn't provide react-dom (pc23df), requested by @storybook/addons
➤ YN0002: │ @storybook/core-client@npm:7.0.0-alpha.46 [69c15] doesn't provide react-dom (p90f10), requested by @storybook/store
➤ YN0002: │ @storybook/core-client@npm:7.0.0-alpha.46 [69c15] doesn't provide react-dom (p26bc7), requested by @storybook/client-api
➤ YN0002: │ @storybook/core-client@npm:7.0.0-alpha.46 [f53fc] doesn't provide react (pf306b), requested by @storybook/addons
➤ YN0002: │ @storybook/core-client@npm:7.0.0-alpha.46 [f53fc] doesn't provide react (pf6013), requested by @storybook/store
➤ YN0002: │ @storybook/core-client@npm:7.0.0-alpha.46 [f53fc] doesn't provide react (pa9755), requested by @storybook/client-api
➤ YN0002: │ @storybook/core-client@npm:7.0.0-alpha.46 [f53fc] doesn't provide react-dom (p40a7d), requested by @storybook/addons
➤ YN0002: │ @storybook/core-client@npm:7.0.0-alpha.46 [f53fc] doesn't provide react-dom (pec679), requested by @storybook/store
➤ YN0002: │ @storybook/core-client@npm:7.0.0-alpha.46 [f53fc] doesn't provide react-dom (pcd233), requested by @storybook/client-api
➤ YN0002: │ @storybook/docs-tools@npm:7.0.0-alpha.46 doesn't provide react (p25ad6), requested by @storybook/core-common
➤ YN0002: │ @storybook/docs-tools@npm:7.0.0-alpha.46 doesn't provide react (p48079), requested by @storybook/store
➤ YN0002: │ @storybook/docs-tools@npm:7.0.0-alpha.46 doesn't provide react-dom (pb0185), requested by @storybook/core-common
➤ YN0002: │ @storybook/docs-tools@npm:7.0.0-alpha.46 doesn't provide react-dom (p389f1), requested by @storybook/store
➤ YN0002: │ @storybook/instrumenter@npm:6.5.13 doesn't provide react (pa4be4), requested by @storybook/addons
➤ YN0002: │ @storybook/instrumenter@npm:6.5.13 doesn't provide react-dom (pa0dd2), requested by @storybook/addons
➤ YN0002: │ @storybook/instrumenter@npm:7.0.0-alpha.46 doesn't provide react (p081dc), requested by @storybook/addons
➤ YN0002: │ @storybook/instrumenter@npm:7.0.0-alpha.46 doesn't provide react-dom (p02c37), requested by @storybook/addons
➤ YN0002: │ @storybook/preview-web@npm:7.0.0-alpha.46 doesn't provide react (p238df), requested by @storybook/addons
➤ YN0002: │ @storybook/preview-web@npm:7.0.0-alpha.46 doesn't provide react (pd8e52), requested by @storybook/store
➤ YN0002: │ @storybook/preview-web@npm:7.0.0-alpha.46 doesn't provide react-dom (p80f40), requested by @storybook/addons
➤ YN0002: │ @storybook/preview-web@npm:7.0.0-alpha.46 doesn't provide react-dom (pfbd32), requested by @storybook/store
➤ YN0002: │ @storybook/react-vite@npm:7.0.0-alpha.46 [f53fc] doesn't provide typescript (pbca0f), requested by @joshwooding/vite-plugin-react-docgen-typescript
➤ YN0002: │ @storybook/telemetry@npm:7.0.0-alpha.46 doesn't provide react (p7302c), requested by @storybook/core-common
➤ YN0002: │ @storybook/telemetry@npm:7.0.0-alpha.46 doesn't provide react-dom (pad005), requested by @storybook/core-common
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed in 0s 486ms
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed in 0s 580ms
➤ YN0000: ┌ Link step
➤ YN0000: │ ESM support for PnP uses the experimental loader API and is therefore experimental
➤ YN0000: └ Completed in 0s 814ms
➤ YN0000: Done with warnings in 2s 19ms

I was having trouble after upgrading a project to use Yarn PnP, I was getting similar errors to others who've had problems with Yarn PnP + Storybook, so I just spun up a fresh React + TypeScript + Tailwind project on Yarn 3.3.0 with PnP and then ran yarn dlx storybook init, all was successful during install and I got the "To run your Storybook, type: yarn storybook" message, which I did.
It seems like everything works fine as far as building storybook goes, then I get an error in the viewport:
  [vite] Internal server error: Failed to resolve import "@storybook/preview-web" from<EMAIL_ADDRESS>Does the file exist?
  Plugin: vite:import-analysis
  File: /virtual:/@storybook/builder-vite/vite-app.js:1:45
  1  |  import { composeConfigs, PreviewWeb } from '@storybook/preview-web';
     |                                              ^
  2  |      import { ClientApi } from '@storybook/client-api';
  3  |      import<EMAIL_ADDRESS>      at formatError (file://[***]/.yarn/__virtual__/vite-virtual-ac8ceaae23/0/cache/vite-npm-3.2.4-bd281d599b-0f3e8f89c1.zip/node_modules/vite/dist/node/chunks/dep-67e7f8ab.js:39975:46)
      at TransformContext.error (file://[***]/.yarn/__virtual__/vite-virtual-ac8ceaae23/0/cache/vite-npm-3.2.4-bd281d599b-0f3e8f89c1.zip/node_modules/vite/dist/node/chunks/dep-67e7f8ab.js:39971:19)
      at normalizeUrl (file://[***]/.yarn/__virtual__/vite-virtual-ac8ceaae23/0/cache/vite-npm-3.2.4-bd281d599b-0f3e8f89c1.zip/node_modules/vite/dist/node/chunks/dep-67e7f8ab.js:36839:33)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at async TransformContext.transform (file://[***]/.yarn/__virtual__/vite-virtual-ac8ceaae23/0/cache/vite-npm-3.2.4-bd281d599b-0f3e8f89c1.zip/node_modules/vite/dist/node/chunks/dep-67e7f8ab.js:36972:47)
      at async Object.transform (file://[***]/.yarn/__virtual__/vite-virtual-ac8ceaae23/0/cache/vite-npm-3.2.4-bd281d599b-0f3e8f89c1.zip/node_modules/vite/dist/node/chunks/dep-67e7f8ab.js:40228:30)
      at async loadAndTransform (file://[***]/.yarn/__virtual__/vite-virtual-ac8ceaae23/0/cache/vite-npm-3.2.4-bd281d599b-0f3e8f89c1.zip/node_modules/vite/dist/node/chunks/dep-67e7f8ab.js:36615:29)

This is the same error I was getting on my previous build, and if I fix this missing module by installing it, I get another, and another until all of these modules are added, then I end up with another error in the viewport:
SyntaxError: The requested module '/node_modules/.vite-storybook/deps/@mdx-js_react.js?v=xxx' does not provide an export named 'mdx'

Similar to this issue (https://github.com/storybookjs/builder-vite/issues/398) which seems to be closed with no real fix and I can't seem to resolve this last one.
I've tried some of the workarounds such as seting packageExtension resolutions in .yarnrc.yml but with no luck.

@nedkelly many of these issues have been fixed in storybook 7.0, if you're willing to give that a shot you'll have much better luck when using pnp or pnpm. I think you still have to instll one extra MDX dependency, but we're trying to find a way to avoid that. npx sb@next init if you want to try it.

Thanks @IanVS, I'll give it a go!

@IanVS Unfortunately with a clean build starting with Storybook v7.0.0-alpha.53 I get the same error Failed to resolve import "@storybook/preview-web", this is a completely clean from scratch project with minimal config.

That might be a regression, we'll take a look, thanks!

@IanVS  You might be pleased to know that I just spun up another project with the same base source code, but this time I built it on a fresh Webpack 5 config and I get the exact same error from Storybook v7.0.0-alpha.53, so I don't think this is related to the vite-builder at all, looks like Yarn PnP + Storybook is the culprit.

Ok, that's the last mdx dep that I mentioned were still finding a way to deal with. For now you can just install it manually in your project.

I've installed the dependencies manually when doing storybook next 7.0.0-alpha.62.
I still get errors saying: "Expected your framework's preset to export a renderToCanvas field.
I'm not sure if that's related to PnP issues however. My .yarnrc.yml looks like this:
packageExtensions:
  "@storybook/core-common@*":
    dependencies:
      "@storybook/react-vite": "^7.0.0-alpha.62"
  "@storybook/react@*":
    dependencies:
      "react-dom": "*"
      "react": "*"
  "@storybook/react-vite@*":
    dependencies:
      "webpack": "*"
      "react-dom": "*"
      "@storybook/client-api": "*"
  "@emotion/use-insertion-effect-with-fallbacks@*":
    dependencies:
      "react": "*"
  "@mdx-js/react@*":
    dependencies:
      "react": "*"
  "@storybook/addon-docs@*":
    dependencies:
      "react": "*"
      "react-dom": "*"
  "@storybook/blocks@*":
    dependencies:
      "react": "*"
  "@storybook/components@*":
    dependencies:
      "react": "*"
      "react-dom": "*"
  "@storybook/theming@*":
    dependencies:
      "react": "*"
  "@babel/plugin-transform-react-jsx@*":
    dependencies:
      "@babel/core": "*"
  "eslint-config-next@*":
    dependencies:
      "next": "*"

I initlalized storybook using npx sb@next init --builder=vite --parser ts
My dependencies look like this:
    "@storybook/addon-essentials": "^7.0.0-alpha.62",
    "@storybook/addon-interactions": "^7.0.0-alpha.62",
    "@storybook/addon-links": "^7.0.0-alpha.62",
    "@storybook/addons": "^7.0.0-alpha.62",
    "@storybook/blocks": "^7.0.0-alpha.62",
    "@storybook/builder-vite": "^0.2.5",
    "@storybook/channel-postmessage": "^7.0.0-alpha.62",
    "@storybook/channel-websocket": "^7.0.0-alpha.62",
    "@storybook/client-api": "^7.0.0-alpha.62",
    "@storybook/preview-web": "^7.0.0-alpha.62",
    "@storybook/react": "^7.0.0-alpha.62",
    "@storybook/react-vite": "^7.0.0-alpha.62",
    "@storybook/testing-library": "^0.0.13",
    "serve": "^14.1.2",
    "storybook": "^7.0.0-alpha.62",
    "typescript": "4.9.3",
    "vite": "^3.2.5"

Here is another workaround with [pnpm hook](see https://pnpm.io/faq#solution-3) to dynamically add devDependencies to your project. This makes the temporary fix more explicit and can be removed easily once this is fixed.
// .dynamically
const { name: projectName } = require('./package.json');

module.exports = {
  hooks: {
    readPackage: (pkg) => {
      if (pkg.name === projectName) {
        const storybookVersion = pkg.devDependencies['@storybook/react'];

        pkg.devDependencies = {
          ...pkg.devDependencies,

          // fix @storybook/builder-vite dependencies
          // see https://pnpm.io/faq#solution-3
          // see https://github.com/storybookjs/builder-vite/issues/141
          '@storybook/core-common': storybookVersion,
          '@storybook/client-logger': storybookVersion,
          '@storybook/client-api': storybookVersion,
          '@storybook/addon-docs': storybookVersion,
          '@storybook/addon-actions': storybookVersion,
          '@storybook/addon-measure': storybookVersion,
          '@storybook/addon-outline': storybookVersion,
          // ...
        };
      }

      return pkg;
    },
  },
};


building cheetah software hangs the laptop after 82 % ?

I am using the command make -j as given in documentation to make the project. However at 82% my laptop hangs and becomes unresponsive.

Please see issue 79.


Remove the node dependency from the runtime docker after browser upgraded to pnpm

Line up the compile docker with runtime docker
clean the deps in runtime docker


Add kp2r

If you want to create a space follow this guide
https://docs.snapshot.page/guides/create-a-space

Duplicate with #574


Bump PandcGUI to 1.1

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

changing manifests/o/Ombrelin/PandocGui/1.1/* to be manifests/o/Ombrelin/PandocGui/1.1.35/* to match the version number should fix the error

Accepted #40111 as that is correct


New Term Request: LHAV4

For new term requests, please provide the following information:
Preferred term label
adult lateral horn AV4 neuron (paper needs a general term for LHAV4 neurons)
Synonyms
LHAV4
Textual definition
FBrf0255018 - parent class for all LHAV4 neurons (the line in the paper probably labels some subset)
Suggested parent term
adult lateral horn neuron
Attribution
If you would like a nanoattribution, please indicate your ORCID id

I haven't done this in the past - all LH neuron terms are specific ones rather than having grouping terms for each tract. I can see the advantages of having the grouping terms, but always a balance for useful terms v bloat.
If we make this, we probably want to make all of the other grouping terms by tract too.


Task sometimes left in Waiting with no waker

Sometimes tasks are left Waiting without wating on something which causes them to stall for ever
Below tty1 leaves it's driving loop as Waiting but is not waiting on anything
2024-05-08T07:56:15.280314Z TRACE read_config:Parsing task files:async_io::block_on: async_io::driver: completed
2024-05-08T07:56:15.281376Z TRACE async_io::block_on:grow_pool{queue_len=1 idle_count=0 thread_count=0}: blocking: spawning a new thread to handle blocking tasks
2024-05-08T07:56:15.283154Z TRACE async_io::block_on:Driving{task="tty1"}: alfad::task: state=Waiting
2024-05-08T07:56:15.283185Z TRACE async_io::block_on:Driving{task="check-mounts"}: alfad::task: state=Waiting
2024-05-08T07:56:15.285637Z  INFO async_io::block_on:Driving{task="check-mounts"}: alfad::task: 'check-mounts' waiting for 'mount-sys-fs' to be Done
2024-05-08T07:56:15.286816Z  INFO async_io::block_on: alfad::task: check-mounts is Waiting
2024-05-08T07:56:15.283208Z TRACE async_io::block_on:Driving{task="add-user"}: alfad::task: state=Waiting
2024-05-08T07:56:15.288475Z  INFO async_io::block_on:Driving{task="add-user"}: alfad::task: 'add-user' waiting for 'mount-sys-fs' to be Done
2024-05-08T07:56:15.283258Z TRACE async_io::block_on: polling::epoll: created eventfd for notifier
2024-05-08T07:56:15.290340Z TRACE async_io::block_on: polling::epoll: new epoll_fd=3 notifier=EventFd(OwnedFd { fd: 4 })
2024-05-08T07:56:15.283233Z TRACE async_io::block_on:Driving{task="mount-sys-fs"}: alfad::task: state=Waiting
2024-05-08T07:56:15.292465Z TRACE async_io::block_on:Driving{task="mount-sys-fs"}: alfad::task: state=Starting
2024-05-08T07:56:15.293541Z TRACE async_io::block_on:Driving{task="mount-sys-fs"}: alfad::task: state=Running(0)

Investigate:

Sporadic, so seems to be a race condition
Driving loop may exit to soon when waiting on lock

fixed in #12


Implement Node classes.

Nodes might have a specific class e.g. Person. They should be displayed in another color.

Implemented with 0.0.42


StackSetsResource: TemplateURL to another account and ergion

Hi,
StackSetsResource template is really great and helps a lot, so thank you for creating it.
I would like to report a problem that I am having. I have an account "A" in a region - eu-central-1, which holds a template that is to be referenced by the StackSet Custom Resource (i.e. via the Lambda) in account 'B' in region us-west-1. I am getting this error:
Failed to update resource. Unexpected error: An error occurred (ValidationError) when calling the UpdateStackSet operation: Must reference a valid S3 object to which you have access. (See CloudWatch Log Stream:
the TemplateURL is pointing to: https://s3.eu-central-1.amazonaws.com/<bucket>/tempate.yaml
I have customised the Custom Resource Lambda to use TemplateBody and I use:
  TemplateBody:
    Fn::Transform:
      Name: AWS::Include
      Parameters:
        Location: !Sub 's3://${ArtifactBucket}/https-certificate.yaml'

and this works. However, there are some limitations due to using AWS::Include, such as one cannot use Ref in the Outputs section and also the size of the template

Cleaning up stale issues in preparation for refreshing this repository. Please re-open if this still needs to be addressed.


Error when resting on an imported character with spell gems

Foundry: 9.280
D&D Beyond Importer: 2.9.65
Magic Items: 2.2.1
If I import a character that has a Spell Gem in their inventory, I then get this error on a long rest and items fail to recharge for the character with Magic Items:
       Uncaught (in promise) TypeError: formula.replace is not a function
[Detected 1 package: magicitems]
    at Roll._extractFlavors (foundry.js:7314:23)
    at Roll._splitGroup (foundry.js:7204:35)
    at Roll._splitParentheses (foundry.js:7121:17)
    at Roll.parse (foundry.js:7041:22)
    at new Roll (foundry.js:6597:35)
    at OwnedMagicItem.doRecharge (magicitem.js:706:21)
    at OwnedMagicItem.onNewDay (magicitem.js:690:25)
    at magicitemactor.js:168:26
    at Array.forEach (<anonymous>)
    at MagicItemActor.onLongRest (magicitemactor.js:165:24)
    at Actor5e.longRest (magicitemactor.js:110:16)

The gems get created with this flag:
magicitems:
{
    "enabled": true,
    "charges": 1,
    "chargeType": "c1",
    "rechargeable": true,
    "recharge": 1,
    "rechargeType": "t2",
    "rechargeUnit": "r2",
    "destroy": false,
    "destroyCheck": "d1",
    "spells": {},
    "feats": {},
    "tables": {},
    "equipped": true,
    "attuned": false,
    "destroyFlavorText": "reaches 0 charges: it crumbles into ashes and is destroyed.",
    "sorting": "l"
}

Which more or less corresponds to the gem being set to recharge its one charge at dawn.  This isn't great - because it's not how spell gems recharge.  But even if it was, that "recharge" property seems to need to be a string in order to keep Magic Items from throwing that error.
Edit: Also note that just looking at the item is enough to convert it to a string and make the error go away - but you'd have to know to do that, and it breaks recharging for other items on the character - which may be more of a Magic Items problem.

OKay, I see, I can't do much about the daily recharge on this - although I'd argue that's probably what's represented here, i.e. can you store/cast a spell in it.
I will force that field to be a string, which should avoid the error. This will be in the next release, which is v10 only.


More Detailed Documentation

Hey, recently discovering MaterialUI I think it's a great source and i'd like to use it in my next project.
But I am struggling to get it set up due to the lack of introductory documentation. Apart from the Get Started page on the website and the Example repository, is there anything else I could use to get started that is more detailed?

+1 The CSS could definitely use more docs.

dupe of #195


Improvements for legacy benchmark tools (closes #1249)

Improvements for legacy benchmark tools #1249

@mod I didn't get what you mean by "Will run the same benchmark code with ruby-prof". The code is almost the same only the difference is that we need to run the benchmark under Benchmark.benchmark { } block and 'ruby-prof' under RubyProf.profile { } block.
Also for this "rake profiling:matching" currently to run this we use rake benchmark:profiling['matching']. Here you mean to change this to rake profiling:matching.

you are duplicating code can you make the feature without duplicating the code ?
@dinesh-skyach

@mod  we need different files for profiling and benchmark, as they run under different blocks and also as we use 'ruby-prof' gem and this prints very large output because it  tracks the recursively called methods. So we save the output in a file.

@dinesh-skyach I still think you could have refactored the code in order to get less repeating code


[Backport] remove unneeded TaskLogStreamer binding override

Backport of #14176 to 26.0.0.

Merging this since the failure is unrelated.


added stack to folder

please tag hacktober-accepted
Added implementation of stack

@Astrodevil

mention issue no. if assigned

#67


[ 🚧 WIP ] Created FindSumOfCubesOfNumbersByRecursion.java

Returns the sum of cubes of elements in the array
Why:
Closes #1795
What's being changed:
Wrote a program to get the sum  of cubes of elements in an array

The file is moved to the correct directory now .


Select onValueChange will called with empty string when side <form/>

Bug report
Current Behavior
Button change a value state will call onValueChange callback
Expected behavior
onValueChange should not called

Reproducible example
https://github.com/himself65/selectissue
Suggested solution

Additional context

Your environment

Software
Name(s)
Version

Radix Package(s)
@radix-ui/react-select
2.1.2

React
n/a
19.0.0-rc-66855b96-20241106

Browser
chrome

Assistive tech

Node
n/a

npm/yarn
pnpm
9

Operating System
macos
15

Potential duplicates #3135


Code Review Module 2 Week 5 Day 4

Hi @gealsanchez ,
Congratulations! 🎉
Your project is complete! There is nothing else to say other than... it's time to merge it
Highlights
✔ Descriptive Readme
✔ Passing Linters
✔ Correct Gitflow


Add Task.labeledTimeout

Current coverage is 100% (diff: 100%)

Merging #17 into master will not change coverage

@@           master   #17   diff @@
===================================
  Files           4     4
  Lines          29    32     +3
  Methods        28    31     +3
  Messages        0     0
  Branches        1     1
===================================
+ Hits           29    32     +3
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update d16b499...2f5c44e


Social preview image

Create and set social preview image for this repository

ref: https://docs.google.com/presentation/d/1Qq2tR6ZQbFSW6gLbGEdwW5VyeNQC3ADDt_fd2DIhS2s/edit?usp=sharing


WIP: Profiler as lifecycle hook

@achew22
Let me know what you think.
I renamed TargetDecider to RunTarget as I think the former is confusing given that it is only called for run targets and not for build and test targets. Personally don't think there is that much value in having iBazel keep track of which lifecycle listeners are turned on/off. Seems like an anti-pattern. Its cleaner to have the listeners themselves worry about which events they care about and which ones to ignore.
IBazel itself conforms to the Lifecycle interface so it can be passed in to the certain lifecycle hooks (ChangeDetected, BeforeCommand, AfterCommand and ReloadTriggered right now) so that lifecycle events can create other lifecycle events. This is use inside livereload AfterCommand which fires off a ReloadTriggered event that is consumed by the profiler.
Also added a few some more parameters to various events that listeners can choose to use.
Usage looks like this: ibazel -profile_dev=profile.out run devserver
Output file looks something like the following in concatenated JSON with the iteration UUID marking a command loop in iBazel. This output includes REMOTE_EVENTs that come back from the browser:
{"type":"IBAZEL_START","iteration":"b595909a-33d7-4bbe-a5a0-808d0d187bd7","time":1513021938425,"bazelVersion":"release 0.8.1-homebrew","maxHeapSize":"3817MB","committedHeapSize":"1141MB"}
{"type":"RUN_START","iteration":"b595909a-33d7-4bbe-a5a0-808d0d187bd7","time":1513021938825,"targets":["devserver"],"elapsed":400}
{"type":"RELOAD_TRIGGERED","iteration":"b595909a-33d7-4bbe-a5a0-808d0d187bd7","time":1513021939462,"targets":["devserver"],"elapsed":1037}
{"type":"RUN_DONE","iteration":"b595909a-33d7-4bbe-a5a0-808d0d187bd7","time":1513021939462,"targets":["devserver"],"elapsed":1037}
{"type":"REMOTE_EVENT","iteration":"b595909a-33d7-4bbe-a5a0-808d0d187bd7","time":1513021942099,"targets":["devserver"],"elapsed":3674,"remoteType":"PAGE_LOAD","remoteTime":1513021942095,"remoteElapsed":379,"remoteData":"{\"pageLoadTime\":379,\"fetchTime\":11,\"connectTime\":0,\"requestTime\":9,\"responseTime\":4,\"renderTime\":357,\"navigationStart\":1513021941716,\"unloadEventStart\":1513021941730,\"unloadEventEnd\":1513021941732,\"redirectStart\":0,\"redirectEnd\":0,\"fetchStart\":1513021941719,\"domainLookupStart\":1513021941721,\"domainLookupEnd\":1513021941721,\"connectStart\":1513021941721,\"connectEnd\":1513021941721,\"secureConnectionStart\":0,\"requestStart\":1513021941721,\"responseStart\":1513021941726,\"responseEnd\":1513021941730,\"domLoading\":1513021941738,\"domInteractive\":1513021942025,\"domContentLoadedEventStart\":1513021942025,\"domContentLoadedEventEnd\":1513021942026,\"domComplete\":1513021942095,\"loadEventStart\":1513021942095}"}

{"type":"SOURCE_CHANGE","iteration":"2e8370f1-2d81-4950-8728-70a1fa804de2","time":1513021966893,"targets":["devserver"],"change":"/Users/greg/google/gregmagolan/webpack-typescript-benchmarking/src/package0/timer0.ts"}
{"type":"RUN_START","iteration":"2e8370f1-2d81-4950-8728-70a1fa804de2","time":1513021966995,"targets":["devserver"],"elapsed":102,"changes":["/Users/greg/google/gregmagolan/webpack-typescript-benchmarking/src/package0/timer0.ts"]}
{"type":"RELOAD_TRIGGERED","iteration":"2e8370f1-2d81-4950-8728-70a1fa804de2","time":1513021970618,"targets":["devserver"],"elapsed":3725,"changes":["/Users/greg/google/gregmagolan/webpack-typescript-benchmarking/src/package0/timer0.ts"]}
{"type":"RUN_DONE","iteration":"2e8370f1-2d81-4950-8728-70a1fa804de2","time":1513021970618,"targets":["devserver"],"elapsed":3725,"changes":["/Users/greg/google/gregmagolan/webpack-typescript-benchmarking/src/package0/timer0.ts"]}
{"type":"REMOTE_EVENT","iteration":"2e8370f1-2d81-4950-8728-70a1fa804de2","time":1513021971005,"targets":["devserver"],"elapsed":4112,"remoteType":"PAGE_LOAD","remoteTime":1513021971001,"remoteElapsed":382,"remoteData":"{\"pageLoadTime\":381,\"fetchTime\":7,\"connectTime\":0,\"requestTime\":5,\"responseTime\":5,\"renderTime\":363,\"navigationStart\":1513021970619,\"unloadEventStart\":1513021970630,\"unloadEventEnd\":1513021970631,\"redirectStart\":0,\"redirectEnd\":0,\"fetchStart\":1513021970622,\"domainLookupStart\":1513021970622,\"domainLookupEnd\":1513021970622,\"connectStart\":1513021970622,\"connectEnd\":1513021970622,\"secureConnectionStart\":0,\"requestStart\":1513021970624,\"responseStart\":1513021970624,\"responseEnd\":1513021970629,\"domLoading\":1513021970637,\"domInteractive\":1513021970943,\"domContentLoadedEventStart\":1513021970943,\"domContentLoadedEventEnd\":1513021970944,\"domComplete\":1513021971000,\"loadEventStart\":1513021971000}"}

{"type":"SOURCE_CHANGE","iteration":"dc9c57a7-33f1-46ad-8827-fe07ccfd348f","time":1513021986328,"targets":["devserver"],"change":"/Users/greg/google/gregmagolan/webpack-typescript-benchmarking/src/package0/timer0.ts"}
{"type":"SOURCE_CHANGE","iteration":"dc9c57a7-33f1-46ad-8827-fe07ccfd348f","time":1513021986328,"targets":["devserver"],"change":"/Users/greg/google/gregmagolan/webpack-typescript-benchmarking/src/package0/timer1.ts"}
{"type":"SOURCE_CHANGE","iteration":"dc9c57a7-33f1-46ad-8827-fe07ccfd348f","time":1513021986328,"targets":["devserver"],"change":"/Users/greg/google/gregmagolan/webpack-typescript-benchmarking/src/package0/timer2.ts"}
{"type":"RUN_START","iteration":"dc9c57a7-33f1-46ad-8827-fe07ccfd348f","time":1513021986429,"targets":["devserver"],"elapsed":101,"changes":["/Users/greg/google/gregmagolan/webpack-typescript-benchmarking/src/package0/timer0.ts","/Users/greg/google/gregmagolan/webpack-typescript-benchmarking/src/package0/timer1.ts","/Users/greg/google/gregmagolan/webpack-typescript-benchmarking/src/package0/timer2.ts"]}
{"type":"RELOAD_TRIGGERED","iteration":"dc9c57a7-33f1-46ad-8827-fe07ccfd348f","time":1513021988091,"targets":["devserver"],"elapsed":1763,"changes":["/Users/greg/google/gregmagolan/webpack-typescript-benchmarking/src/package0/timer0.ts","/Users/greg/google/gregmagolan/webpack-typescript-benchmarking/src/package0/timer1.ts","/Users/greg/google/gregmagolan/webpack-typescript-benchmarking/src/package0/timer2.ts"]}
{"type":"RUN_DONE","iteration":"dc9c57a7-33f1-46ad-8827-fe07ccfd348f","time":1513021988091,"targets":["devserver"],"elapsed":1763,"changes":["/Users/greg/google/gregmagolan/webpack-typescript-benchmarking/src/package0/timer0.ts","/Users/greg/google/gregmagolan/webpack-typescript-benchmarking/src/package0/timer1.ts","/Users/greg/google/gregmagolan/webpack-typescript-benchmarking/src/package0/timer2.ts"]}
{"type":"REMOTE_EVENT","iteration":"dc9c57a7-33f1-46ad-8827-fe07ccfd348f","time":1513021988469,"targets":["devserver"],"elapsed":2141,"remoteType":"PAGE_LOAD","remoteTime":1513021988465,"remoteElapsed":373,"remoteData":"{\"pageLoadTime\":373,\"fetchTime\":10,\"connectTime\":0,\"requestTime\":8,\"responseTime\":7,\"renderTime\":348,\"navigationStart\":1513021988092,\"unloadEventStart\":1513021988105,\"unloadEventEnd\":1513021988106,\"redirectStart\":0,\"redirectEnd\":0,\"fetchStart\":1513021988095,\"domainLookupStart\":1513021988095,\"domainLookupEnd\":1513021988095,\"connectStart\":1513021988095,\"connectEnd\":1513021988095,\"secureConnectionStart\":0,\"requestStart\":1513021988097,\"responseStart\":1513021988098,\"responseEnd\":1513021988105,\"domLoading\":1513021988117,\"domInteractive\":1513021988405,\"domContentLoadedEventStart\":1513021988405,\"domContentLoadedEventEnd\":1513021988406,\"domComplete\":1513021988465,\"loadEventStart\":1513021988465}"}

Can one of the admins verify this patch?

Replaces #87

@alexeagle Profiler client-side script is served from /profiler.js. To turn this on in devserver it will be a small change:
	// Include the profiler script if IBAZEL_PROFILER_URL is set.
	profilerUrl := os.Getenv("IBAZEL_PROFILER_URL")
	if profilerUrl != "" {
		fmt.Printf("Serving profiler script from %s\n", profilerUrl)
		profilerLoaderSnippet := fmt.Sprintf(`(function(){
	const script = document.createElement('script');
	script.src = "%s";
	document.head.appendChild(script);
})();`, profilerUrl)
		preScripts = append(preScripts, profilerLoaderSnippet)
	}

@achew22 Update the PR so that the profiler listens for an the ReloadTriggered event from livereload itself instead of going throught the Lifecycle interface. This will be a much cleaner pattern. Stay tuned.

@achew22 Ok. Its been updated with a better pattern. Ready for another look when you have a chance. I'll work on an e2e in the meantime.

@achew22 Ping. Can you have another look when you have time? Would like to land this next week as part of the current ABC sprint.

Profiler e2e test added. Also updated the livereload e2e test to check the /livereload.js result instead of ibazel_test.go doing it.

@achew22 Thanks for you comments. Cleaned up the code and I think I addressed everything you mentioned.
Renamed event.elapsed to event.timeSinceNavigationStart but it seems a bit verbose so maybe you have a better name?

I'll update the README.md today with some details of how to use the profile_dev mode. Seems like the best place for the documentation on it.

@achew22 readme updated with --profile_dev documentation

@gregmagolan, I'm not seeing your latest round. Did you maybe push it to a different branch?

@achew22 On its way. I'm working late tonight

@achew22 Changes are in. Thanks for all of the great feedback. Appreciate the detail you went into. Ran clang-format on profile.js as well.

Test this please

@achew22 Ready to go. Thanks!

Test this please

Test this please

@googlebot Confirm that this author is ok with their commits being contributed to this project

For @gregmagolan

Yes, you can accept code from this contributor.
We found the following CLAs for your query.

For @achew22

Yes, you can accept code from this contributor.
We found the following CLAs for your query.

Good work, Greg. This is some really well done code. I appreciate your patience and really look forward to working more with you in the future.

Yay nice job Greg! :tada:


Detect user-agent for mobile firefox and show app download page

Summary
Show app download page on mobile firefox.
Ticket Link
https://github.com/mattermost/mattermost-server/issues/8783
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-07934fa2f39d3d34a.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-07934fa2f39d3d34a

Thanks @tejasbubane, appreciate the PR. @lindalumitchell can QA please help queue this for testing on a firefox mobile browser?

Spinmint test running for more than 7 days. This test server was terminated.

Spinmint test server destroyed

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-05a8d73bafacd95df.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-05a8d73bafacd95df

@tejasbubane @esethna
Thanks, I've tested the PR on Android Firefox and the "Mattermost works best if you switch to our Android app" page shows up when going to the spinmint URL.  Tapping on "Continue" takes me to the Playstore to download the MM app.  Looks good to me!

Spinmint test running for more than 7 days. This test server was terminated.

Spinmint test server destroyed

@hmhealey I have rebased the PR.

@tejasbubane Excellent. Thanks!


WIP: Annotate std/bigint.d and std/internal/math/biguintcore.d to please d…

…lang/dmd#12520
Part of #8076

What is the correct parameter qualification of
    static void divMod(scope return BigUint x, scope return BigUint y,
                       scope out BigUint quotient, scope out BigUint remainder) pure nothrow @safe
    {
        if (y.data.length > x.data.length)
        {
            quotient = 0uL;
            remainder = x;
        }
        else if (y.data.length == 1)
        {
            quotient = divInt(x, y.data[0]);
            remainder = BigUint([modInt(x, y.data[0])]);
        }
        else
        {
            BigDigit[] quot = new BigDigit[x.data.length - y.data.length + 1];
            BigDigit[] rem = new BigDigit[y.data.length];
            divModInternal(quot, rem, x.data, y.data);
            quotient = BigUint(removeLeadingZeros(trustedAssumeUnique(quot)));
            remainder = BigUint(removeLeadingZeros(trustedAssumeUnique(rem)));
        }
    }

, @Geod24 ? I can't find any references on assigning return scope parameter to out scope parameters in the DIP-25 and DIP-1000 specs.

As far as I understand:
return qualified parameters on a void returning function are nonsensical.
out parameters don't make sense as scope in a pure function since they can only be derived from either a pure allocator (e.g. the GC) or from other input parameters. scope on function parameters means that that reference shall not escape the scope of the function.

As far as I understand:
return qualified parameters on a void returning function are nonsensical.
out parameters don't make sense as scope in a pure function since they can only be derived from either a pure allocator (e.g. the GC) or from other input parameters. scope on function parameters means that that reference shall not escape the scope of the function.

Ok, thanks. I'll adjust.

Why does divMod need scope parameters, is there any existing code calling it with scope BigInts?
If you have to make it work, you can do:
// biguintcore.d(977):
remainder = BigUint(x.data.idup);
// biguintcore.d(981):
quotient = divInt(BigUint(x.data.idup), y.data[0]);

If you do that, maybe add a comment that the redundant allocation is due to the limitation that return scope for out parameters is not supported.

Why does divMod need scope parameters, is there any existing code calling it with scope BigInts?
If you have to make it work, you can do:
// biguintcore.d(977):
remainder = BigUint(x.data.idup);
// biguintcore.d(981):
quotient = divInt(BigUint(x.data.idup), y.data[0]);

If you do that, maybe add a comment that the redundant allocation is due to the limitation that return scope for out parameters is not supported.

This seems like a severe limitation. Has return scope for out parameters been considered, @WalterBright?

I've reverted to a the @safe defensive variant
static void divMod(BigUint x, scope BigUint y,
                       out BigUint quotient, out BigUint remainder) pure nothrow @safe

that passes locally with dmd on master my machine.

Why does divMod need scope parameters, is there any existing code calling it with scope BigInts?
If you have to make it work, you can do:

Thanks for highlighting this. I've reverted to non-x-scope variant
static void divMod(BigUint x, scope BigUint y,
                       out BigUint quotient, out BigUint remainder) pure nothrow @safe

that doesn't require any @trusted and that passes locally with dmd master my machine.


[crypto] Add a test for malicious ECDSA-P256 keys.

Description
Test the logic discussed here with a standalone OTBN test that ensures the expected ILLEGAL_INSN error happens.

Hi @jadephilipoom - now that 17287 has been marked as merged is it safe to close this issue or are there remaining items for completion? If the latter - please add a brief explanation of what is still needed. TIA


Support event loop load-sharing with revised API

Both the classes SQLiteConnectionSource (https://github.com/vapor/sqlite-kit/blob/master/Sources/SQLiteKit/SQLiteConnectionSource.swift#L3-L29) and SQLiteConnection (https://github.com/vapor/sqlite-nio/blob/master/Sources/SQLiteNIO/SQLiteConnection.swift#L60-L64) take a thread pool and a single event loop as init arguments. The core query method (https://github.com/vapor/sqlite-nio/blob/master/Sources/SQLiteNIO/SQLiteConnection.swift#L86-L112) appears to submit a WorkItem to the thread pool which then jumps back to the same eventLoop for every query.
This is not great for multi-threaded workloads where the work is split across multiple event loops (think cores) (e.g. based on incoming HTTP requests) since it means one event loop asymmetrically handles returns from all the DB reads/writes and there is a lot of undesirable event loop switching when e.g. handling an incoming HTTP request.
It looks like it might be a simple change to allow the event loop to be specified per query? (I am also using https://github.com/swift-server/async-http-client which as a comparison allows event loop options (even preference) in execute() calls and whose top-level object, HTTPClient, is instanced with eventLoopGroupProvider (https://github.com/swift-server/async-http-client/blob/master/Sources/AsyncHTTPClient/HTTPClient.swift#L52-L66)).
Interested in your thoughts....

Okay, I chatted with @tanner0101 about this and he was very helpful. Turns out the architecture is designed so you set up a separate pool for each event loop! Here is the revised StorageManager that will be added shortly to https://github.com/finlabsuk/open-banking-connector with irrelevant detail removed. I'm adding it here to help others who might want to SQLite-Kit as an independent package.
final class StorageManager {

    var db = ThreadSpecificVariable<ConnectionPool<SQLiteConnectionSource>>()
    var dbThreadPool = ThreadSpecificVariable<NIOThreadPool>()

    init(
        file: String
    ) {
        eventLoopGroup.makeIterator().forEach { eventLoop in
            try! eventLoop.submit({
                let threadPool = NIOThreadPool.init(numberOfThreads: 2)
                self.dbThreadPool.currentValue = threadPool
//                self.dbThreadPool.currentValue = NIOThreadPool.init(numberOfThreads: 2)
                let source = SQLiteConnectionSource(
                    configuration: .init(storage: .connection(.file(path: file))), // creates file if missing?
                    threadPool: threadPool,
                    on: eventLoop
                )
                let pool = ConnectionPool(config: .init(maxConnections: 8), source: source)
                self.db.currentValue = pool
            }).wait()
        }

    }

    deinit {
        eventLoopGroup.makeIterator().forEach { eventLoop in
            try! eventLoop.makeSucceededFuture(())
                .flatMap({_ in
                    self.db.currentValue!.close()
                }).flatMapThrowing({_ in
                    try! self.dbThreadPool.currentValue!.syncShutdownGracefully()
                }).wait()
        }
    }
}


tcmur: Add and convert to handle_generic_cbk to simplify the code

Signed-off-by: Xiubo Li<EMAIL_ADDRESS>

Nice. Thanks.


[TextField] Add "pointerEvents: none" to outline and filled variants

Closes #12997

@byronluk It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!


I need to define/know the URL of container app before its created

I'm hosting a nextjs app in an Azure Container App.
I have a need to use the default azurecontainerapps.io provided domain name to access the app instead of custom domains.
Azure container app is created via a Bicep module (including environment variables for the container).
I need to define an environment variable NEXTAUTH_URL which should match the host name the app uses. (more info)
I'm using single revision mode and defining a custom revision prefix.

The problem is:
Application URL is something like this: https://<defined app name>.jollyriver-592af9d6.<defined region>.azurecontainerapps.io
Where jollyriver-592af9d6 is a generated string not defined by me, so I can't know it beforehand to set the environment variable NEXTAUTH_URL as part of provisioning the whole container app.
Question
What is  jollyriver-592af9d6 and why it is needed?
Feature request
Can we control that string, for example pass it through when the Container App or Container App Environment is created?

You can get the default domain in Bicep from properties.defaultDomain in the environment. See this example: https://github.com/Azure/aca-landing-zone-accelerator/blob/f46047fa2e136621f7e8a13fd5e50b05274000ab/scenarios/aca-internal/bicep/modules/06-front-door/deploy.front-door.bicep#L81
You can also use the CONTAINER_APP_HOSTNAME environment variable to get this value for the current app. There's also CONTAINER_APP_ENV_DNS_SUFFIX if you just need the suffix without the app name. However, it doesn't look like NextAuth.js is able to read the value from a variable that's not named NEXTAUTH_URL.
Each Container Apps environment has a unique generated default domain. One reason it's needed is to prevent subdomain takeovers.

I'm in the same boat. Container Apps seems to be built on Kubernetes, does it also allow (variable expansion)[https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/#using-environment-variables-inside-of-your-config]?
This would allow for NEXTAUTH_URL=$(CONTAINER_APP_HOSTNAME).

I'm in the same boat. Container Apps seems to be built on Kubernetes, does it also allow variable expansion?
This would allow for NEXTAUTH_URL=$(CONTAINER_APP_HOSTNAME).

I did a quick test and the above did work.

Update:
While I solved NEXTAUTH_URL using a workaround based on previous comments. I'm facing another blocker now:

I'm building a solution template that creates an Azure Container App with an optional custom domain in the same ARM template run.
I need to provide consumers of the solution template instructions to create TXT and CNAME records for domain validation and bindings While they are configuring template parameters.
The CNANE records needs the default URL of the Container App, and there's no way for me to know beforehand or seed the default URL so I can provide CNAME information to my customers. If we can only optionally define those unique values that would have been possible.

FYI @anthonychu

Any update on this team? I would like to add that I don't think it makes any differences that customers define this unique part of host name or Azure platform, in both cases Azure platform can ensure the unique part of the host name is in fact unique even if it was defined by customers when creating the container app. I would love if this feature is added.
@anthonychu


Use HTTPS links for CDN - http://dev.office.com/fabric/get-started

The topic should encourage the use of HTTPS for CDN links as Add-ins are generally built using HTTPS.

We've made this change to the documentation site (see #444) – it should be deployed over the next week or so. Thanks!


Another error after the new commit

I updated to the latest version then just tried print(client.lessons("2021-01-30")) then i get this error:
Traceback (most recent call last): File "C:\Users\karim\Documents\Python Projects\Pronotepy\main.py", line 13, in  print(client.lessons("2021-01-30")) File "C:\Users\karim\AppData\Local\Programs\Python\Python38-32\lib\site-packages\pronotepy\pronoteAPI.py", line 191, in lessons first_week = self.get_week(date_from) File "C:\Users\karim\AppData\Local\Programs\Python\Python38-32\lib\site-packages\pronotepy\pronoteAPI.py", line 171, in get_week return 1 + int((date - self.start_day).days / 7) TypeError: unsupported operand type(s) for -: 'str' and 'datetime.date'

Hello, this is not a problem with pronotepy.
client.lessons expects datetime.date, not str. Correct example:
import datetime # built-in datetime library
...
print(client.lessons(datetime.date(day=30, month=1, year=2021))

Hello, this is not a problem with pronotepy.
client.lessons expects datetime.date, not str. Correct example:
import datetime # built-in datetime library
...
print(client.lessons(datetime.date(day=30, month=1, year=2021))


Second delete folder operation does not work in Insiders 1.41.0

Hei!👋
Found issue with folder delete operation. The point is, when you delete folder (first time), no matter how, via mouse or keyboard combination, then select another folder and try to delete it, you will get popup message saying "Cannot read property 'isDirectory' of undefined"🤔🧐
Only when you select another folder again (second time), delete operation will be successful.
Tried several times with same results.
And as i remember, this bug i found some time ago, so it is not introduced exactly in last insiders build.
Visual Code Insiders 1.41.0 from 2019-12-02, commit: 7cf4cca47aa025a590fc939af54932042302be63
macOS 10.15.1

@ZaJarv thanks for filling this great issue. You should have the fix tommorrow in vscode insiders

@joaomoreno the problem was that it was happening that the tree would sometimes set the trait on one element two times.
In this particular case Selection would be set on the element A and A. So if I say tree.getSelection I would get the same item twice. Instead of the array with one item.
I decided to fix this with a workaround on the trait level.
Repro steps: set compact tree to true. Go up and down with the focus always ending up with the focus on the one select item.
Put a conditional breakpoint here tree will try to set the double selection trait

@isidorn This seems to be coming from here
Where the selection would already contain the folder, but as oldSelection/oldFocus also has the id, it will push the same object to the selection again.
You could also fix it there by doing some sort of duplicate filtering or selection.indexOf to prevent duplciates being added

@jzyrobert great pointer. I think you are right, give me a sec and I will push a better fix. Thanks a lot!

@isidorn I was planning to submit something along the lines of
`if (oldSelection.has(id)) {
const element = compressedNode.elements[compressedNode.elements.length - 1].element as T;
if (selection.indexOf(element) === -1) {
selection.push();
didChangeSelection = true;
}
}
				if (oldFocus.has(id)) {
					const element = compressedNode.elements[compressedNode.elements.length - 1].element as T;
					if (focus.indexOf(element) === -1) {
						focus.push();
						didChangeFocus = true;
					}
				}`

But I'm not sure if this is considered good code, it might be better to create a set of Ids (like oldSelection) does, but as selection is of type T, I could not access the id parameter.

@jzyrobert  If you would like to create a PR you are more than welcome to! It would be great if you could do it today since we are wrapping up the milestone and we need this fix.
Just make sure to remove my wokraound introduced with https://github.com/microsoft/vscode/commit/6d2eeee28aba86c329ac659acf8bfe2ab0390ab9
Thanks!


Publish first release

Release
Create a release candidate and push to prod.
Make sure to convert peer dependencies
Milestone
MVP

With v0.1.3, The first fully-functioning release is public!


[Question] Too Many Requests!

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question
I still get HTTPError 429: Too Many Requests! although I use --sleep-interval 5 as shown below:
youtube-dlc --newline -i --force-ipv4 --age-limit 30 -R 99 --hls-prefer-native -o /home/laptop/Downloads/youtube-dl/downloads/Documentary/DW/%(title)s.%(ext)s -f mp4 --merge-output-format mp4 --write-sub --sub-format srt --sub-lang en --embed-subs --continue --sleep-interval 5 --download-archive /home/laptop/Downloads/youtube-dl/downloads/Documentary/DW/ytdl-archive.txt https://www.youtube.com/channel/UCET6sWl4Xcu-U8Ka9PJPrwA/videos

How can I bypass this issue?
UPDATE: youtube-dlc ver. 2020.11.7

I have found that using cookies fixes the issue

On a sidenote, channel extraction is currently broken. See https://github.com/blackjack4494/yt-dlc/issues/148

I have found that using cookies fixes the issue

How can I do it (example please)?

How can I do it (example please)?

https://stackoverflow.com/a/62213935

Question
I still get HTTPError 429: Too Many Requests! although I use --sleep-interval 5 as shown below:
How can I bypass this issue?

Send less requests, obviously 😆
Jokes aside. --sleep-interval is only dealing with audio/video downloads. If you download lots of subtitles you could use --sleep-subtitles as well - it should take some number as input.
What I have been experimenting with is actually to throttle the actual api requests that usually helps. But there is no parameter for that as of now and I am unsure whether this can be implemented globally or for youtube only (will need quite some work either way).
When I was fixing the history feed I noticed that when I reach 50-60 of 100+ pages it will return me some 429s. However when I put a 1-2s timeout in between each request I did not get any 429s.
For cookies you can use this
https://chrome.google.com/webstore/detail/editthiscookie/fngmhnnpilhplaeedifhccceomclgfbg
export as netscape

im getting same error (too many requests)
by running this
youtube-dlc -f 140 --embed-thumbnail 'https://www.youtube.com/playlist?list=RDCLAK5uy_kLWIr9gv1XLlPbaDS965-Db4TrBoUTxQ8'

im getting same error (too many requests)
by running this
youtube-dlc -f 140 --embed-thumbnail 'https://www.youtube.com/playlist?list=RDCLAK5uy_kLWIr9gv1XLlPbaDS965-Db4TrBoUTxQ8'
running version 2020.11.11-3
edit: cookies is the solution

Why do you get that error?

Why do you get that error?

idk but maybe bcz of my vpn(before that yt showed me that capcha thing).

idk but maybe bcz of my vpn(before that yt showed me that capcha thing).

I found why, is is because you have downloaded for extensive amount of times, so you are getting a warning (too many requests)
It just happened with me right no, so slow down the download or change the ip address using a vpn, that way you have to do a good amount of download before you get another warning for that up address and so on

I found why, is is because you have downloaded for extensive amount of times, so you are getting a warning (too many requests)
It just happened with me right no, so slow down the download or change the ip address using a vpn, that way you have to do a good amount of download before you get another warning for that up address and so on

you dont have to download a lot for this to happend. its VPN. many users may get same ip. maybe they are doing a lot of downloads and this will happend to everyone who is connected to same vpn server and using google services. anyway i have to use vpn to access yt since its censored/sanctioned here. i have to reconnect another server when this happens

Did the issue get resolved?


Relationships with default(auth().id) are still marked as required in the DMMF passed to the plugin

Description and expected behavior
Starting from version 2.8.0, the DMMF passed to the plugin does not respect the auth() function with the default attribute. As a result, relationships with a default value are still marked as required in the OpenAPI plugin.
Environment (please complete the following information):

ZenStack version: 2.9.3
Prisma version: 5.22.0
Database type: Postgresql

Additional context
I believe this issue is related to the release of version 2.8.0, which introduced a change where custom attributes in ZModel are no longer automatically passed to the generated Prisma schema as comments.

fixed in 2.10.0


"Click here to continue" feature doesn't work

It tries to click forever on that.
I also tried with my Jitbit Macro Recorder, it sometimes works, sometimes doesn't. Perhaps something on my end?

There is a new release; please consider updating.


Optimize parameter parsing in text chunking processor

Description
There PR optimizes the parameter parsing step in chunking algorithms. For both algorithms, all runtime parameters for text chunking processor is always available. Therefore, default value is not needed.
Issues Resolved
Optimize parameter parsing in text chunking processor.
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zane-neo This PR resolves your comment in https://github.com/opensearch-project/neural-search/pull/717:

In fact, with field_map and document, we can always calculate a chunk_string_count, we don't need a default value here. Suggesting optimize this code in next PR
Please help review thanks.

We need to rerun the CI checks to check if there are any flakey tests.

Hi maintainer, please attach backport-2.x label to this PR.

Overall code looks good to me. One comment - can you add a unit test for ChunkerParameterParser class? As we're adding more methods to it having specialized test class will give more confidence

Sure. I will add unit tests today.

HI @zane-neo and @martin-gaievski ! I have implemented the unit tests for chunker parameter parser. Can you help review again?

@martin-gaievski Can you merge the PR?

The last approver is expected to merge the PR.


Large image uploads crashing

Everything on this library has been working wonderfully, so first of all: thank you so much!
I noticed recently that we're failing on large image uploads (somewhere in the range of 3mb+) on the server side. Above is a log on the server.
Is this an inherent issue with post requests coming through gql? Or is there something we should be doing to handle larger images better?
Thank you!

Great report, this is almost certainly the default maxFieldsSize option of formidable working.
I need large uploads to work too, so I'll get started on adding a new option for it to our API.
The reason we don't just pass through a formidable config object is to abstract the internal implementation – there is a real chance that formidable will be swapped out sometime in the future and it would be great if that were not a breaking change.

This is weirder than I thought. In theory, maxFieldsSize should not count the size of the actual files, so I'm not sure why you would get that error.
I have been testing < 1MB, 2.5MB and 12MB files and get something else weird happening. The < 1MB file works flawlessly while the larger ones somehow upload twice. This is in my actual app, which is using Koa and a few other things are going on too so I am trying to work out the cause.

So my double upload issue seems to be relating to something different about my project, because testing large files in jaydenseric/apollo-upload-examples everything work fine. No sign of either issue.

Thanks so much for digging in! To clarify, you're no longer seeing errors for large files failing? Any ideas why I'd be running into that original error?

I think there must be something unique about the setup of your project. It's hard to say without debugging the problematic code; I can't recreate the specific error in a simple project.
That warning is supposed to happen when the non-file fields of the multipart form are over 2MB. So if you're Mutation had huge amounts of text or something in it or something that would cause it.
I spent a day trying to work out my issue. Something about my use of MongoDB GridFS and large files is triggering the Koa middleware to run twice in a row. No idea why, I might even try upgrading Node from 8.1 to 8.1.1 because there are some timeout related bugfixes.

For those curious, updating Node.js from v8.1 to v8.1.2 fixed my issue. There were some nasty bugs introduced in Node 8 that have affected quite a few projects, i.e. HMR in Next.js.
@brianlovin any news on the error? I'll close this issue until it can be reproduced.

 You mentioned this above, but just wanted to provide the feedback in case it ever comes up again:
I was accidentally sending a FileReader().result() in the form object - which of course sends a massive base64 encoded string in the payload. I was doing this because I'm doing optimistic client-side rendering of images using that reader.result(), but obviously I don't need to send that to the server.
The fix was to just make sure to not send that reader result over the wire. Duh :P

@brianlovin thanks for the update 🙂

@brianlovin, what did you send instead of reader result base64?

@ifalldev I think you just need to send the file directly from the input now - the client docs have it like this:
export default graphql(gql`
  mutation($file: Upload!) {
    uploadFile(file: $file) {
      id
    }
  }
`)(({ mutate }) => (
  <input
    type="file"
    required
    onChange={({ target: { validity, files: [file] } }) =>
      validity.valid && mutate({ variables: { file } })
    }
  />
))

Thank you for your attention!
Nowadays browsers do not pass the attribute path or filePath neither webKitRelativePath for security purpose.
'Cause of that we have to use FileReader on client side to consume the file.preview (I'm using React Dropzone) and generate the result (readAsBinaryString) to send to back end (Express) and save on S3.
The problem was indeed the size of the payload, not exactly the maxFieldSize configuration on apolloUploadExpress middleware. To fix that, I putted the limit option on bodyParser, eg bodyParser.json({ limit: 1024 * 1024 * 2000, type: 'application/json' }). Now it works like a charm!
If you think that my solution could get better, please tell me!


Reorganize the Archive

Reorganized the summary page based on Wikipedia's list of algorithms.
Also working on reorganizing the content itself, so WIP.

I agree on re-organizing the summary page and such; however, once we decide on which scheme we are working with, the urls will change and I will need to update all my links on youtube (and other places) to match the new archive. In addition, we'll lose our search presence because of it.
I tried to get this conversation going in #57, because it's incredibly important... but there wasn't much discussion then. Ultimately, whatever scheme we go with, we need to stick to.
The idea of the Algorithm Archive was to provide a cohesive curriculum for all areas of computational science. We can still do this, regardless of the directory scheme by providing "guides" for (for example) computational physics, which provides links for all the chapters in the area and secondary commentary.

the urls will change

Luckily, I don't think so. All I moved around was the SUMMARY.md which as far as I know doesn't affect the URLs. Not 100% sure though, someone should test this.

Oh, you are right. As long as we don't change the directory scheme, we are fine; however, I would like to have an introductory blurb to each area. I suppose we could have a different SUMMARY.md to the directory scheme. I feel like if we change the directory scheme, all the PR's will have merge conflicts.

You added a bunch of commits that are unrelated to the PR. Please try to work with branches and keep PRs focused on one topic. Everything else makes them difficult to review and merge.

I'm not in favor of this PR. It is quite rushed, and I would leave jobs like reorganizing the AAA to @leios. Start with contributing by submitting or reviewing code and getting to know other members, not by tearing the house down.

To be fair, I do think the chapters need re-ordering and I think something like this makes sense. I just don't know the best scheme to go with for now.

I must admit I'm with @jiegillet on this one. In addition to that, we should first discuss the matter, come up with a solution and then start to work on it, not the other way around.

Even if we decide to make this change, I strongly suggest to update the directory structure as well and add redirects for the old links. But before we put in all this work, let's discuss this topic.

So we have some pseudo organization (for example sorting and searching and physics solvers), which might conflict with other organizational schemes. No matter what organizational scheme we go with (maybe even allowing all algorithms to be in the main directory, while only touching the SUMMARY.md file for re-organization), we'll have to modify some directories.
If all the algorithms are just sitting in the main directory, then the urls will never change no matter how we change the SUMMARY.md file. I don't think that's a bad solution.

I actually like the idea of a very flat directory structure. It would make the future-proof regarding potential reorganizations. A directory structure complying to the website structure is obviously nice as well.

Yup, that's what we're working with right now. It's a flat directory structure and a modified summary.md.
Our current pseudo-organization also fits with the Wikipedia organization, so that works.
Are there any other ways we could organize things?

I meant that we need to remove that organization too and create a separate introductions/ directory or something and have an markdown introduction file for each heading.
If we are going for a flat structure, we need to move all the algorithms to the base directory, in my opinion.

Yeah, so a flat directory structure could consist of all algorithms having an own directory just below base. Then having all the introduction markdowns in an introductions directory seems good as well.
The only special case is the principles_of_code thingy tho. Maybe we make everything in there flat as well? Just having priciples_of_code with all mds in it.

To be honest, the principles_of_code section might need a rework as well. The way I see it, we can have that as an exception for now

I mean making it flat wouldn't be much of an issue.

I would suggest making the reorganization after https://github.com/algorithm-archivists/algorithm-archive/pull/170 tho, since I add a few res folders there.
I should start finishing that...

Ok, this PR implements flat hierarchy and therefore paves the way for a reorganization.

Yeah this PR is pointless now. That change can be addressed in a different PR.


Add default Discourse signature key

This is a dummy key used for testing
and local development.
Change-type: patch
Signed-off-by: Josh Bowling<EMAIL_ADDRESS>

@balena-ci I self certify!

@balena-ci retest


Extend color to the edge

Describe the solution you'd like
Now, if we're setting up some buttons, it'll be nice to have an option to extend color up the edge.
Additional context

Example:

How it's set right now.
New feature.

Thanks.

Maybe a better representation:

When light is on, icon change color and also the edges are glowing.
I have it like this but with custom cards.

Can you share the yaml?


versions difference between 1.2.5 and lastest

There is a running difference in SerializerFeature:
public static final int WRITE_MAP_NULL_FEATURES
            = WriteMapNullValue.getMask()
            | WriteNullBooleanAsFalse.getMask()
            | WriteNullListAsEmpty.getMask()
            | WriteNullNumberAsZero.getMask()
            | WriteNullStringAsEmpty.getMask()
            ;

The lastest version will take WriteMapNullValue, WriteNullBooleanAsFalse, WriteNullListAsEmpty, WriteNullNumberAsZero, WriteNullStringAsEmpty as WriteMapNullValue while old version take SIMPLE WriteMapNullValue.
This will result different output when we set WriteNullStringAsEmpty with no WriteMapNullValue setted.
Nulled fields will be skipped in old versions but they will be "null" in newer versions.
Does it make sense?

update:
I have seen the latest changes in 1.2.48 and it do make sense for BEANS serialization.
But it still don't make sense in serialization of Maps.
I make some small changes to make it in PR #1837

https://github.com/alibaba/fastjson/releases/tag/1.2.49
问题已修复，请用新版本


Security Data Issues Secrets in clear text

Hi,url : https://github.com/davekolian/Manga-RSS-App/blob/c7375af7714ae32ebb204ac79d31d066711ca829/Database-Script-Heroku/database_update.py You have commit that need to remove from the github historyattacker can see it and use it ...encrypt your secrets !!!!Our Bug Help you to be more Secure and protect your data ?Buy me a coffee (or more likely a beer)https://www.paypal.com/paypalme/bugbounty1/150USDhttps://www.buymeacoffee.com/bugbounty☕☕☕☕☕

Hello,
Thank you for your time, I understood the security issue and have fixed it!

Hello,
Thank you for your time, I understood the security issue and have fixed it!

gald to be help :)
Liked my Bug ? Buy me a coffee (or more likely a beer)
https://www.paypal.com/paypalme/bugbounty1/150USD
https://www.paypal.com/paypalme/bugbounty1/150USD
https://www.buymeacoffee.com/bugbounty
https://www.buymeacoffee.com/bugbounty
and help me to continue help small websites.
בתאריך יום ב׳, 1 בפבר׳ 2021 ב-0:00 מאת Dave Kol <
notifications@github.com>:

Hello,
Thank you for your time, I understood the security issue and have fixed it!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/davekolian/Manga-RSS-App/issues/1#issuecomment-770458304,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASRHGYQ5XGIKZFWTQCKBGZTS4XHHLANCNFSM4W3YGVMQ
.


Feature Request: GUI with nwjs

https://nwjs.readthedocs.io/en/latest/For Users/Getting Started/

Please feel free to contribute

Youre a collaborator now ;)