Refactors legacy MAPL_Generic

Description
This PR refactors the legacy MAPL_Generic. This includes the following changes:

Moving MAPL_Generic.F90 and MAPL_GenericCplComp.F90 into generic and removing the MAPL prefix.
Moving MAPL_ExtDataGridCompMod.F90, MAPL_OrbGridComp.rc, and MAPL_OrbGridCompMod.F90 from base into generic due to their dependency on MAPL_GenericMod.
Removes mapl.generic dependency from Base. Mapl.generic now depends on mapl.base.
Moved MaplGrid.F90 to base directory since base depended on it.

Related Issue

#954
Motivation and Context
Refactor work of MAPL
How Has This Been Tested?

Tested by running GEOSgcm for a day and for longer than 5 days and 5hrs because I'm still traumatized lol. No differences were observed in either test.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Trivial change (affects only documentation or cleanup)

Checklist:

[x] I have tested this change with a run of GEOSgcm (if non-trivial)
[x] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
[x] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

Latest commit addresses the majority of the comments made in this PR. The caveat is that it is currently segfaulting when running. Currently investigating the source. Traceback excerpt is copied below:
forrtl: severe (174): SIGSEGV, segmentation fault occurred
Image              PC                Routine            Line        Source
GEOSgcm.x<PHONE_NUMBER>15136A  Unknown               Unknown  Unknown
libpthread-2.22.s  00002AAAC3E57C10  Unknown               Unknown  Unknown
libMAPL.profiler.  00002AAABDD05CD0  mapl_baseprofiler         143  BaseProfiler.F90
libMAPL.generic.s  00002AAABA20FAA5  mapl_genericmod_m        1862  Generic.F90
libesmf.so         00002AAABF0902E4  _ZN5ESMCI6FTable1     Unknown  Unknown
libesmf.so         00002AAABF093ABF  ESMCI_FTableCallE     Unknown  Unknown
libesmf.so         00002AAABF620D45  _ZN5ESMCI2VM5ente     Unknown  Unknown
libesmf.so         00002AAABF09173A  c_esmc_ftablecall     Unknown  Unknown
libesmf.so         00002AAABF8B0D4D  esmf_compmod_mp_e     Unknown  Unknown
libesmf.so         00002AAABFBB2FE1  esmf_gridcompmod_     Unknown  Unknown
libMAPL.generic.s  00002AAABA27818E  mapl_genericmod_m        1512  Generic.F90
GEOSgcm.x<PHONE_NUMBER>504791  geos_agcmgridcomp        1117  GEOS_AgcmGridComp.F90
libesmf.so         00002AAABF0902E4  _ZN5ESMCI6FTable1     Unknown  Unknown
libesmf.so         00002AAABF093ABF  ESMCI_FTableCallE     Unknown  Unknown
libesmf.so         00002AAABF620D45  _ZN5ESMCI2VM5ente     Unknown  Unknown
libesmf.so         00002AAABF09173A  c_esmc_ftablecall     Unknown  Unknown
libesmf.so         00002AAABF8B0D4D  esmf_compmod_mp_e     Unknown  Unknown
libesmf.so         00002AAABFBB2FE1  esmf_gridcompmod_     Unknown  Unknown
libMAPL.generic.s  00002AAABA20F66F  mapl_genericmod_m        1845  Generic.F90
libesmf.so         00002AAABF0902E4  _ZN5ESMCI6FTable1     Unknown  Unknown
libesmf.so         00002AAABF093ABF  ESMCI_FTableCallE     Unknown  Unknown
libesmf.so         00002AAABF620D45  _ZN5ESMCI2VM5ente     Unknown  Unknown
libesmf.so         00002AAABF09173A  c_esmc_ftablecall     Unknown  Unknown
libesmf.so         00002AAABF8B0D4D  esmf_compmod_mp_e     Unknown  Unknown
libesmf.so         00002AAABFBB2FE1  esmf_gridcompmod_     Unknown  Unknown
libMAPL.generic.s  00002AAABA27818E  mapl_genericmod_m        1512  Generic.F90
GEOSgcm.x<PHONE_NUMBER>47CEF5  geos_gcmgridcompm        1203  GEOS_GcmGridComp.F90
libesmf.so         00002AAABF0902E4  _ZN5ESMCI6FTable1     Unknown  Unknown
libesmf.so         00002AAABF093ABF  ESMCI_FTableCallE     Unknown  Unknown
libesmf.so         00002AAABF620D45  _ZN5ESMCI2VM5ente     Unknown  Unknown
libesmf.so         00002AAABF09173A  c_esmc_ftablecall     Unknown  Unknown
libesmf.so         00002AAABF8B0D4D  esmf_compmod_mp_e     Unknown  Unknown
libesmf.so         00002AAABFBB2FE1  esmf_gridcompmod_     Unknown  Unknown
libMAPL.generic.s  00002AAABA20F66F  mapl_genericmod_m        1845  Generic.F90
libesmf.so         00002AAABF0902E4  _ZN5ESMCI6FTable1     Unknown  Unknown
libesmf.so         00002AAABF093ABF  ESMCI_FTableCallE     Unknown  Unknown
libesmf.so         00002AAABF620D45  _ZN5ESMCI2VM5ente     Unknown  Unknown
libesmf.so         00002AAABF09173A  c_esmc_ftablecall     Unknown  Unknown
libesmf.so         00002AAABF8B0D4D  esmf_compmod_mp_e     Unknown  Unknown
libesmf.so         00002AAABFBB2FE1  esmf_gridcompmod_     Unknown  Unknown
libMAPL.cap.so     00002AAAB97E793E  mapl_capgridcompm         631  MAPL_CapGridComp.F90
libesmf.so         00002AAABF0902E4  _ZN5ESMCI6FTable1     Unknown  Unknown
libesmf.so         00002AAABF093ABF  ESMCI_FTableCallE     Unknown  Unknown
libesmf.so         00002AAABF620D45  _ZN5ESMCI2VM5ente     Unknown  Unknown
libesmf.so         00002AAABF09173A  c_esmc_ftablecall     Unknown  Unknown
libesmf.so         00002AAABF8B0D4D  esmf_compmod_mp_e     Unknown  Unknown
libesmf.so         00002AAABFBB2FE1  esmf_gridcompmod_     Unknown  Unknown
libMAPL.cap.so     00002AAAB97E1D10  mapl_capgridcompm         934  MAPL_CapGridComp.F90
libMAPL.cap.so     00002AAAB97D1666  mapl_capmod_mp_ru         259  MAPL_Cap.F90
libMAPL.cap.so     00002AAAB97CF422  mapl_capmod_mp_ru         218  MAPL_Cap.F90
libMAPL.cap.so     00002AAAB97CD7AD  mapl_capmod_mp_ru         152  MAPL_Cap.F90
libMAPL.cap.so     00002AAAB97CD45A  Unknown               Unknown  Unknown
GEOSgcm.x<PHONE_NUMBER>46C34F  MAIN__                     34  GEOSgcm.F90
GEOSgcm.x<PHONE_NUMBER>46A1D2  Unknown               Unknown  Unknown
libc-2.22.so       00002AAAC462C725  __libc_start_main     Unknown  Unknown
GEOSgcm.x<PHONE_NUMBER>46A0E9  Unknown               Unknown  Unknown
>> Error << /usr/local/intel/2020/compilers_and_libraries_2020.4.304/linux/mpi/intel64/bin/mpirun  -np 24 ./GEOSgcm.x --logging_config logging.yaml: status = 174; at /gpfsm/dnb32/gvillami/GEOSgcm_GenericRefactor/GEOSgcm/build/install/bin/esma_mpirun line 378.
GEOSgcm Run Status: -1

The crash has nothing to do with the profiler. The compiler messes up without the instruction of "recursive". Add "recursive" before this
https://github.com/GEOS-ESM/MAPL/blob/d4ad08482955b9f0a690c0be56d8de545eec5f00/generic/MAPL_Generic.F90#L1708

@Gvilla1000-nasa and @weiyuan-jiang came up with this fix independently in a similar window.    I've also tested on my laptop, so the fix seems to be robust.  There's a bit of a mystery why it "worked" before, but ... maybe this explains the confusion we had with moist before.   (@atrayano to bring to his attention.)

Note NAG would have detected this, were we able to run a case that exercise the generic layer ... (@mathomp4 and @bena-nasa maybe we want to create a test gridcomp hierarchy inside MAPL so that we can use NAG - bypassing FMS.)


Fix #415 (reltool vsn check)

Refactor reltool version check to use vsn app key if ebin/reltool.app
exists.
OTP releases prior to R14 didn't install the app file, so we still
have to support getting the version string from the lib_dir path. If
you're using an R13B03 or R13B04 install that doesn't have version
strings in lib_dir paths (lib/reltool vs lib/reltool-0.5.3), we won't
be able to retrieve the version string. Given R13's age and that it's
unusual to have vsn-less lib_dir paths, this shouldn't be problem.

While at it, delete trailing white space.

Works on local tests, merging.


Light Rig

For the lighting department:
Aim:
New Family to add, not yet decided but for now called light rig or light-rig
New Family for the asset creator
New Family for the asset loader
The idea is to implement a workflow for lighters and render artists so that they can export lighting setups called light-rigs so that the same setup can be imported and used across multiple shots of a project and also saved for later use such as turntables or demos.

What is needed.

add family
add new maya "set"
add scheme update
research if lights for different render engines will become a issue for instance collector
add new collector
add new validators
add new extractors
add functions if needed

Digration.
This is for now meant to be only on maya hosts and not all apps. (Reasons being that maya is the only app we use today for lighting) If this can be created to be future proof and to work across different hosts then that would be great.
Prio is for now to get it to work for Octane first, followd by Redshift, then mental ray

Consider whether there is any difference between a Light-Rig and Rig. There might be dedicated validation and export, if so it could be helpful to list those differences. Otherwise a normal rig may work, as the exported file is in Maya's own format (.ma) it would take into account lights as well.
On a cosmetic note, consider using only one word separator - CamelCase, mixedCase, snake_case or dash-case. E.g. LightRig or light-rig rather than Light-Rig. At the moment, there are two separators being used at once, which can be superfluous.

cosmetic note taken.
Will try and unlearn that bad habit and try and remember to be more concise.

so the LightRig could use all the pipeline.py commands that normal Rig does.
just a diffrent family and name ?

Try making a rig in Maya for lights using the Rig family. The things you find that differs from normal chatacter rigs are the things you would make a new family, such as LightRig, for.
A new family would allow you to dedicate unique plugins to it, but at the same time increase complexity for you the maintainer.
In general, the fewer families you have, the less work there is for you to maintain and customise.

Did you get anywhere with this?

Feel free to re-open should the issue appear again.


Limit scope of api keys to reduce account takeover risks

Is your feature request related to a problem? Please describe.
With API Keys being introduced, I thought about the potential ramifications if an API Key got into the wrong hands (not from a SN leak, but if the user accidentally exposed it).
Obviously there is always some risk, such as draining the SN wallet funds, etc. But maybe there's some APIs that we can restrict access to via API keys?
Describe the solution you'd like
I think it might make sense to disallow certain API actions to be performed by API keys, most notably:

unlinkAuth - should an API Key be compromised, the attacker could use this API to remove existing auth methods, locking the account owner out of their account
Whatever APIs are used to register new auth methods, which when used with (1) above would allow a complete account takeover (I think)?
Since we're limited to a single API key right now, I don't think there's any reason to limit access to the generateApiKey and deleteApiKey APIs, since the attacker would basically be locking themself out if they deleted the only API key.

Describe alternatives you've considered
In the long term, following a model like OAuth scoping is probably a good idea, but I imagine we should not roll our own, or if we do, it is a much larger effort to:

Enumerate different scopes/roles
Assign APIs to each scope/role
Generically/abstractly enforce API Key scopes on each API

This is more of a stop-gap/band-aid to give a little more security for us clumsy stackers ;)
Additional context
N/A
As always, I'm open to input. Maybe I'm making a bigger deal out of this than is warranted.

As always, I'm open to input. Maybe I'm making a bigger deal out of this than is warranted.

No, I think it's great that you wrote this down. I agree, we should do this at some point but I don't think it's a priority right now. We could add some warnings how sensitive this API key is in the short term though.
Regarding implementation: I have some experience with @casl/ability and I think it was easy to use so I think we would make no mistake with trying to use it for this. It even integrates with Prisma via @casl/prisma though I am not sure how long we'll continue using Prisma as part of our queries.
It's also what NestJS recommends to use. Meanwhile, the authorization section of NextJS only mentions middleware which seem to be implemented as an afterthought ime. Middleware wouldn't work anyway for this in our case since it executes before we initialize sessions iirc.
In general, I think our existing "authorization layer" which consists of if (!me) in every resolver needs some love first before we can make it more complex. There is also a section about authorization on graphql.org here.

To start, we could just outright prevent zapping/withdrawals and unlinking/linking of auth methods via an api key.

To start, we could just outright prevent zapping/withdrawals and unlinking/linking of auth methods via an api key.

Makes sense! I'll self-assign this one :)


Added a few tests.

Signed-off-by: m-aslam-mj2<EMAIL_ADDRESS>

Coverage increased (+0.7%) to 66.46% when pulling 6269f86a86adaa2dc25c2fd17b1d0c264f165d07 on m-aslam-mj2:staging13 into 7a133d167223ca5fadac280ebe84cb5e059c6105 on CS2113-AY1819S1-T16-1:master.


refactor(ast): oxc_ast crate re-export AST types from other crates

Some AST types are defined in crates outside oxc_ast crate. Re-export these types from oxc_ast crate for ease - so you don't need to remember where they're defined to use them.

#4773  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite

@rzvxa @Dunqing I would have asked Boshen to review this, but he's off today. I can't see any downside to this, so I think safe to merge if one of you can confirm that you can't see a downside either.

Thanks both for reviewing.


Automatically adding error classes to form group elements

Currently the form-fields JS module adds an appropriately styled error message after a form field if there is an error with what the user has submitted.
It would be good if we could add further functionality so that when a field has an error, if the field is inside a container element (e.g. a div) with the form__group class set, then it also automatically adds the form__group--error class to that container element so that it is automatically styled too.

I don't think we are using the form-fields any more so this behaviour needs to be handled in your form-components package.


Request: Adaptive heart rate settings

My streamer has a very high heart rate and a caffeine addiction that leads to heart rates between 80 and 100 resting, but it doesn't necessarily mean they're scared or exhausted. Sometimes scared or stressed is 98, sometimes it's 110, and that can change during the same stream. To combat this, some method for detecting a change in heart rate that exceeds a threshold, or some sort of moving average to subtract from the heart rate and use the min/max on that, might be nice.
Depending on the time window for the average or how quickly it adapts, it would end up limiting how long the high heart rate effects would last as the high heart rate would become the new average level, but I don't anticipate high stress situations lasting very long anyway.

As you point out, I'm not sure of an intuitive way to know that someone's baseline has shifted versus a prolonged high-stress situation. Certainly a cute accessibility feature, I'll have to think on it some more.


Update RevisionRepository.php to return object of RevisionContract type

Thanks. What error does this solve?

Sorry if I acted too fast and skipped the opening of the issue :)
If I have to, I will open one.

Nope that’s fine- just wanted some context.


[CARBONDATA-3193] Cdh5.14.2 spark2.2.0 support

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ No] Any interfaces changed?

[ No] Any backward compatibility impacted?

[ Yes] Document update required?

[ Yes] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ No Large Changes] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

This is just only the way we fix for CDH5.14.2, and the Spark2.2.0, the way how parquet treats the data.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1923/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10176/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2132/

@jackylk , @ravipesala Can somebody validate this against the CDH5.14.2 and could you please create a profile for build validation for CDH Libraries.. Please let me know where to add..if I need to trigger a different profile build.

Does carbon not support Cdh5.14.2 spark2.2.0  using -Pspark-2.2 ?
Did CDH change the spark interface ,so that carbon can't run succesfully ?

@chandrasaripaka I can't find the spark maven dependency for CDH5.14.2, But I am able to build with CDH spark versions 2.2.0-cdh6.0.1 and 2.2.0.cloudera3. Only the problem here I found is it does not have spark-hive-thriftserver jar in cloudera repo, so classes related it like CarbonThriftServer and CarbonSQLCLIDriver cannot compile. Apart from I am able to compile carbon with 2.2.0-cdh6.0.1 and 2.2.0.cloudera3 versions. I am not sure why CDH does not include spark-hive-thriftserver jar in there repo.
Please send the repository for CDH5.14.2, so that I can verify this version also.

Please check the repo here.
https://www.cloudera.com/documentation/enterprise/release-notes/topics/cdh_vd_cdh5_maven_repo_514x.html#maven_5142

I went through this link earlier, but I cannot find spark 2.2 version in this distribution. I can find only 1.6.0-cdh5.14.4 of spark here.

Please try this:
https://repository.cloudera.com/artifactory/cloudera-repos/org/apache/spark/spark-sql_2.11/2.2.0.cloudera2/

@chandrasaripaka , I got the issue, but creating many duplicate files may not be a good idea as it will be difficult to maintain, I will try to do with reflection.
And one more question is I don't find the package spark-hive-thriftserver_2.11 from cloudera, without this package we cannot run the carbon thrift server. Where to find this package? Or Is it ok if we don't run carbon thrift server from cloudera distribution?

@ravipesala , Yes you can let me know how you want to inherit..I think defining a interface for the wrapper would be a good fit.. In our local fork we did it using spark-2.2.0 normal thrift server, it is ok if we dont run thrift server from cloudera distribution, that works.

@chandrasaripaka
As I know, spark 2.2.0 is not a stable version, it is better to consider other more stable versions.

@chandrasaripaka Please check the PR https://github.com/apache/carbondata/pull/3026

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1953/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10206/

We get error from a commit related to altertableschema.. which is not there in cloudera spark

https://github.com/apache/carbondata/commit/b0733ecbf380d7956dee57a9048dd7537620744e

This commit breaks the cloudera 2.2.0cloudera2

I will check on it
On Wed, 2 Jan 2019 at 10:37 PM, Chandrasekhar Saripaka <
<EMAIL_ADDRESS>wrote:

b0733ec
https://github.com/apache/carbondata/commit/b0733ecbf380d7956dee57a9048dd7537620744e
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/carbondata/pull/3021#issuecomment-450922573,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHwdxlnPiNf3k7TSQcnRFjD_jqqCTHEiks5u_OdkgaJpZM4ZgM5V
.

--
Thanks & Regards,
Ravi

Thank you..let's use your pull request and close this...so that we can have a single.place to comment.

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/40/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/39/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/1278/

Build Failed  with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.4/41/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12444/job/ApacheCarbon_PR_Builder_2.4.5/3437/


rollback doc

Release Playbook

[ ] Rebase against master
[ ] Code review
[ ] Merge into master
[ ] Verify changes at http://site-staging.convox.com
[ ] Promote release on site-production in the convox/production Rack

 Rollback doc

Got +1 from Ian in Slack


Add Media Object to TweetEntities

Add Media Object to TweetEntities.
ref: https://developer.twitter.com/en/docs/twitter-api/v1/data-dictionary/object-model/entities#media

Thanks!!!!
Looks very Good To Me🥺


update CLA landing page URL

Fixes #61
@swormke
What's this change do?
I changed the URL for the CLA landing page from the github.io one to the new read the docs URL.
Where should the reviewer start?
Review the changes below.
Any background context?

This merge request should be done against 1.0 and then we can merge into master.


RTMDet inference slower than Mask-RCNN (CPU)

I have a segmentation task where I need to segment a single, large (>50% of image area) object from an image. I trained Mask-RCNN for this task using mmdetection and inference time is 500ms on my CPU, with input image size 640x640. Then I trained RTMDet-m on the same dataset, also using mmdetection, with the same input image size. On my CPU inference time is... 580ms.
RTMDet is usually described as faster than YOLO and orders of magnitude faster than Faster-RCNN, so this result is disappointing.
Configs used (I only modified the datasets and some minor settings like LR and input image size):
Mask-RCNN:
https://github.com/open-mmlab/mmdetection/blob/main/configs/mask_rcnn/mask-rcnn_r50_fpn_1x_coco.py
RTMDet:
https://github.com/open-mmlab/mmdetection/blob/main/configs/rtmdet/rtmdet-ins_m_8xb32-300e_coco.py
Any ideas what's causing this?
PS. All tests were done on Macbook Pro M1.

To reduce the inference speed, we suggest you adjust the post-processing setting of the model. We set a very low score threshold during training and testing to achieve better COCO mAP. However, in actual usage scenarios, a relatively high score threshold (e.g. 0.3) is usually used.
# in MMDetection config
model = dict(
    test_cfg=dict(
        nms_pre=1000,  # keep top-k score bboxes before nms
        min_bbox_size=0,
        score_thr=0.3,  # score threshold to filter bboxes
        nms=dict(type='nms', iou_threshold=0.65),
        max_per_img=100)  # only keep top-100 as the final results.
)

You can reduce the nms_pre,  max_per_img and increase the score_thr in the config https://github.com/open-mmlab/mmdetection/blob/f78af7785ada87f1ced75a2313746e4ba3149760/configs/rtmdet/rtmdet-ins_l_8xb32-300e_coco.py#L25

@RangiLyu
Thanks for the reply!
Here's my previous config:
model = dict(
    ...
    test_cfg=dict(
        nms_pre=1000,
        min_bbox_size=0,
        score_thr=0.05,
        nms=dict(type='nms', iou_threshold=0.6),
        max_per_img=100,
        mask_thr_binary=0.5))

I modified it to
model=dict(
    ...
    test_cfg=dict(
        nms_pre=10,
        min_bbox_size=0,
        score_thr=0.5,
        nms=dict(type='nms', iou_threshold=0.6),
        max_per_img=10,
        mask_thr_binary=0.5))

But there's no speedup at all. Inference times are still around 390-450ms.

Did you manage to speed it up further?

Hey I encounter same slow performance. Have u found any solution?

@LuukvandenBent @heylamourding
Yes I did.
It seems that RTMDet-m was simply an overkill for my usecase.
After switching to RTMDet-tiny I ended up with the same accuracy as with RTMDet-m but far better speed.

@Macok  thanks for reply! Glad that u get the solution eventually. I also switch to RTMDet-tiny.
May I know did u do any other effort to improve inference speed? Though I switch to RTMDet-tiny, inference speed of the model is still slower than Yolov5.


use cluster eds service_name alias in LoadStats if the service_name is used in EDS

Bug Template
Title: LoadStats should use cluster's eds service_name  if the service_name is used in EDS requests
Description:

In EDS, the cluster::eds_cluster_config::service_name is preferred (if set) over cluster::name() when sending EDS requests to XDS server.
cluster_name_(cluster.eds_cluster_config().service_name().empty()
? cluster.name()
: cluster.eds_cluster_config().service_name()) ...
This cluster_name_ should be set as LoadStats::cluster_name as well as ADS side is using them to track loads on a "cluster".

This is the right way to go when multiple clusters "share" the same upstream prioritySet, while they don't have the same cluster::name(). But for the control plane to understand correctly the actual "total" load of upstream, we need to set the correct service_name in the loadstats.

I agree that we should provide service granular information. I wonder if this would be a breaking change though if we just switch immediately. Maybe we could provide both cluster name and service name in the LRS report, that way the management server can decide which to consider, and also can decide whether to aggregate or not.

we are sending eds service name already at the eds side, so IMHO that's the
name the management server actually knows?
On Thu, Feb 21, 2019 at 12:37 AM htuch<EMAIL_ADDRESS>wrote:

I agree that we should provide service granular information. I wonder if
this would be a breaking change though if we just switch immediately. Maybe
we could provide both cluster name and service name in the LRS report, that
way the management server can decide which to consider, and also can decide
whether to aggregate or not.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/envoyproxy/envoy/issues/5986#issuecomment-465868520,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADSPTAaf9k2wv6fmeDPAiSno-xc49K-yks5vPjCNgaJpZM4a-pmS
.

--
Xin Zhuang

The management server is aware of both names, since it might be synthesizing CDS. I think the safest thing to do is include both names in the LRS report.

Talked to Htuch offline, agreed to defer the aggregation of cluster stats of the same service name to user's management server impl.


Improve fullscreen mode of the viewer

PR Checklist

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[ ] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Fixes
Issue Number: #2514 #2159 #2267
Changes

New button to toggle full screen mode of viewer.
New shorcut to toggle fullscreen mode of viewer ( key:f ).
Fullscreen mode for all type of files.

Todo

[ ] Polyfill fullscreen api (only works in chrome ).
[ ] Make it work with new video player.

Thanks for the PR @btzr-io ! We'll get it reviewed tomorrow hopefully.


#4217 kit factory, base item, and rspec various refactors

Addresses #4217 for kits
Various refactors to lay groundwork for #3707
Description

#4217 Hard codes all uses of kit factory
Remove kit :with_item trait and replace with KitCreateService - this is to make it easier for me to rewrite kit creation later when working on #3707
Rename item.kits scope to item.housing_a_kit
DRYs up kit base_item seeding
Add rspecs to:

prevent kit base_item deletion
test item.is_in_kit?, item.loose, item.housing_a_kit

Kit :with_item trait removal conflicts with #4582, recommend merging that one first then I can merge and change their rspecs in this PR

Type of change

Bug fix (non-breaking change which fixes an issue)
Documentation update

How Has This Been Tested?
passes all rspecs

the failing tests are flaky ones, added them to the list

I split off the cleanup pieces into PR #4665

@jimmyli97  FYI: We had an urgent fix that required all the senior contributors this week , so we didn't get to look at this again.  Hopefully this week will go better.

@jimmyli97 this looks good, but there's a conflict now. :(

can't recreate failing test locally, think this is a flake, added to list


📝 Update includes for docs/de/docs/advanced/templates.md

Made changes to docs/de/docs/advanced/templates.md  as mentioned here https://github.com/fastapi/fastapi/issues/12554

Thanks for the effort! :cake:
This was handled in another PR, so I'll close this one now. :coffee:


feat - align content

Align content
by https://github.com/expressjs/expressjs.com/issues/1668

Please fix the mobile responsiveness

Fiz alguns ajustes de responsividade para dispositivos móveis

I think the original issue you put up is good idea, but this is what I get now at this width.

I think the original issue you put up is good idea, but this is what I get now at this width.
Obv the nav squish has nothing to do with your changes

I'm not looking at the menu right now at the request of the @bjohansebas
@chrisdel101  I will analyze the other screen sizes, tks

it could be fixed by adding padding to the elements you changed, and please remove the changes to the footer, as this was already done in another PR.

Hi @carlosstenzel, I’ve made some changes to fix some issues with certain screen measurements, and I’ve used grid for the boxes. This improves the responsive design.
Feel free to change it if you don’t think it’s the best approach.

@bjohansebas
Perfect, thank you.


LDAP auth-,  user-,  and group-providers can't cope with Active Directory GUIDs

When using and Active Directory as the backend for CS3 user and groups it should be possible to use one  of the GUID that AD provides as the ID attribute for the cs3 users/groups. E.g. using this configuration:
[grpc.services.userprovider.drivers.ldap]
...
userfilter="(&(objectclass=user)(objectGUID={{.OpaqueId}}))"

[grpc.services.userprovider.drivers.ldap.schema]
uid="objectGUID"
displayName="displayName"
dn="dn"
cn="samAccountName"
...

objectGUID and other GUID Attributes in AD are just standard UUIDs. However, AD does treat them as bare Octetstring values in LDAP Search Results and LDAP filters. (Different to other LDAP server with return the string representation of UUID). That requires special treatment when e.g. searching something by GUID. AD expects a hex-escaped representation of the GUID in the filter string (e.g. objectGUID=\8c\aa\e2\b0\2e\96\10\2f\8b\3c\97\0f\19\6e\26\95 instead of objectGUID=8caae2b0-2e96-102f-8b3c-970f196e2695)
This currently causes issues with LDAP filters we create from go-templates (like the userfilter) above. As we can't properly escape the filter any more after the template processing happened.

Related to https://github.com/owncloud/ocis/issues/3150


[Frontend] merge beam search implementations

Merged implementation of AsyncEngine and MQLLMEngine's beam_search into EngineClient(Protocol)
Manually testing conducted to verify that requests are still ran in parallel and output is correct.
server side:
$ vllm serve meta-llama/Meta-Llama-3-8B

client side:
Completion
from openai import OpenAI

client = OpenAI(
    base_url="http://localhost:8000/v1",
    api_key="key123",
)

prompt = "Capital of France is"

try:
    completion = client.completions.create(
        model="meta-llama/Meta-Llama-3-8B",
        prompt=prompt,
        max_tokens=4,
        extra_body={'use_beam_search': True, 'best_of': 3}
    )
    print(completion.choices[0].text)
except Exception as e:
    print(e)

Chat
from openai import OpenAI

client = OpenAI(
    base_url="http://localhost:8000/v1",
    api_key="key123",
)

prompt = "Capital of France is"

try:
    completion = client.chat.completions.create(
        model="meta-llama/Meta-Llama-3-8B",
        messages = [
            {"role": "system", "content": "You are a helpful AI assistant."},
            {"role": "user", "content": prompt}
        ],
        max_tokens=10,
        extra_body={'use_beam_search': True, 'best_of': 3, 'temperature': 0}
    )
    print(completion)
    print(completion.choices[0].message.content)
except Exception as e:
    print(e)

@njhill thanks for shepherding this pr!
@LunrEclipse please address the review from @njhill .
I'll be afk and will hand it over to @njhill for review.

@njhill Thank you for the review! I've gone ahead and pushed changes based on your feedback

@njhill Yeah, it's definitely doable if we add logic to the EngineClient.generate methods to check if beam_search is true and then yield different results there than checking inside the engine itself.

Thanks @LunrEclipse.
Not related to this PR specifically, but couldn't the beam search impl still be kept behind the EngineClient.generate API? I.e. we just intercept the existing beam_search and associated params in SamplingParams ... so that the outward function remains the same?

it is possible following the spirit of https://github.com/vllm-project/vllm/pull/9302 . we can just create another BeamSearchSequenceGroup class. @LunrEclipse @njhill

@youkaichao yes I think we should refactor things a bit.. and also move the impl into beam_search.py instead of protocol.py, etc.


element: 1.7.28 -> 1.7.29 (backport to 21.05)

Motivation for this change
Backport of #124276
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 124326 at 6495b1f5 run on x86_64-linux 1

1 package built successfully:

element-desktop

3 suggestions:

warning: build-tools-in-build-inputs
rsync is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:292:7:
    |
292 |       buildInputs = [ yarn nodejs rsync ] ++ extraBuildInputs;
    |       ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:332:7:
    |
332 |       installPhase = attrs.installPhase or ''
    |       ^

warning: build-tools-in-build-inputs
yarn is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:292:7:
    |
292 |       buildInputs = [ yarn nodejs rsync ] ++ extraBuildInputs;
    |       ^


Set motor variation at proto level

Adds a fixed 1% variation between motor instances
Seeded with motor name so all motors with the same name have the same error
This should be combined with reducing the motor jitter in the API.

ah ok I'll drop https://github.com/sourcebots/sbot_simulator/pull/5 in favour of this


[help] How can I change default color's hex code?

I want to change colors's hex codes into dracula theme's setting: https://github.com/dracula/dracula-theme#color-palette
Example:

Would it be possible to change color's default value into ones I want? For example I want to change pink's color into #ff79c6 and so on.

Your terminal defined a color theme, which you can usually edit via the settings in your terminal software. It's not something you do in code.

I am able to do something like: print(f"[#ff79c6]hello[/#ff79c6]").
I wanted to force the color's hex definition in the code as well and also create aliases for the new colors I want to use; for exampole b for bold and so on.

You already can use hex codes, and b works for bold. You can also created themes to define aliases for your own colors.

Got it, I can do something like following:
custom_theme = Theme({
        "magenta": "#ff79c6"
    })


three pointer algo

if we do this using hashing, the worst case seems to be O(n2)... Any idea about average case?
@shivamranj  @pran005


Implement Cocos Studio 2.x JSON parser

hi @pandamicro  please kindly consider auto callback feature
reference:http://www.cocoachina.com/bbs/read.php?tid-276980.html

@zj8487 Can you please review our implementation here: https://github.com/cocos2d/cocos2d-html5/pull/2580
Any suggestions or feed backs are welcome

hi @pandamicro
very glad to do this

@zj8487 Sorry I made a mistake, this is the PR for JSON parser: https://github.com/cocos2d/cocos2d-html5/pull/2569

How i make cocos studio export json?

@lassade
until now it is not supported, i am waiting the version of ccs and cocos2d-js

So how can i help?

@zj8487 @lassade Thank you for your attention
The Cocos Studio v2.1 will support json export. And the supported version of Cocos Studio will be released in the next week, please stay tuned.
And I will release Cocos2d-JS v3.3 beta today which include the JSON parser


[EASI-4303] Status updates

EASI-4303

Changes and Description

Extracted status changes into separate record
Ensured model plan creating record is always first
Removed readyForReview fields as they are covered by status changes
Removed records for initial create of task list sections and op needs
Updated the task list recent changes to reflect sorting
Added unit tests

How to test this change
Verify the changes listed above are reflected in the change history render
Tests pass
PR Author Review Checklist

[ ] Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
[ ] Added or updated tests for backend resolvers or other functions as needed.
[ ] Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
[ ] Updated the Postman Collection if necessary.

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
Always make comments, even if it's minor, or if you don't understand why something was done.

Ah gotcha, thanks yeah I'll tackle these in the next PR


Raze not updating automatically

See https://github.com/coelckers/Raze/releases for reference.
Scoop version: 0.7.3 alpha
Current version: 0.8.1 beta
Thank you in advance

The _alpha suffix was replaced with _beta. That's probably why it doesn't work. Looking into it…


Strange behavior when serializing KeyValuePair using a contract implementing IContractResolver

Consider this code:
class Program
    {
        static void Main(string[] args)
        {
            var pairs = new KeyValuePair<int, int>(1, 1);

            var setting1 = new JsonSerializerSettings() { ContractResolver = new MyContractResolver() };
            var setting2 = new JsonSerializerSettings() { ContractResolver = new CamelCasePropertyNamesContractResolver() };

            var json1 = JsonConvert.SerializeObject(pairs, setting1);
            var json2 = JsonConvert.SerializeObject(pairs, setting2);

            Console.WriteLine(json1); // prints {"Key":1,"Value":1}
            Console.WriteLine(json2); // prints {"key":1,"value":1}
            Console.ReadKey();
        }
    }

    internal class MyContractResolver : IContractResolver
    {
        readonly IContractResolver _camelCaseContractResolver;

        public MyContractResolver()
        {
            _camelCaseContractResolver = new CamelCasePropertyNamesContractResolver();
        }

        public JsonContract ResolveContract(Type type)
        {
            return _camelCaseContractResolver.ResolveContract(type);
        }
    }

It seems that serializer refuses to use camel casing when dealing with KeyValuePair; But only when implementing a contract resolver using IContractResolver. I think serializer uses something more than just ResolveContract method; But only when defined ContractResolver is DefaultContractResolver.

From what I can gather, your resolver needs to override 'ResolvePropertyName', and return the camelcase version of the string received. But, then again, this is the same 'CamelCasePropertyNamesContractResolver' does.
Also, your Resolver will be ignored by the KeyValuePairConverter if it`s base class is not DefaultContractResolver

@stoiKris Thank you for answering. I was wondering if it is possible to create a contract resolver with just implementing IContractResolver or every contract resolver needs to be inherited from DefaultContractResolver.
And why KeyValuePairConverter ignores my contract resolver but others don't?

Unfortunately this is a limitation of IContractResolver being an interface. There isn't a clean way to fix this limitation.


ConntrackModule

Adding a conntracksubsystemmanagementSINK
gastank!
Right now we dont manage cleanup of conntrack...
We can manage it in a way thats orthogonal to any of the backends, by making a conntrack module based on https://github.com/kubernetes/kubernetes/blob/master/pkg/util/conntrack/conntrack.go.

This will basically be like a "separate backend" that runs in the same process , i.e. it wont share any memory w/ the "actual" backend, but it will be glued on when things start up.

/assign @hanamantagoudvk

As in included by the backends that use the conntracker?

Yes :)
On Mon, Dec 20, 2021, 18:34 Per Andersson @.***> wrote:

As in included by the backends that use the conntracker?
—
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/kpng/issues/157#issuecomment-998134456,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA5QROHQYJXI7FWJFHW3XFLUR5SKVANCNFSM5KJKIZKA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Issue #174 is caused by this defect

i will start working on this..

Whoever wants to work on this, we have a detailed description of some of the conntrack problems here  https://github.com/kubernetes-sigs/kpng/issues/235 .... might be a good place to get started

/unassign

mikael said he can dig into this one for now
/assign @mcluseau

I think it's done at least since #264  ;)
/close


cmd/cgo: -godefs mishandles enum value

Reduced test case:
package p

// enum { IFF_UP = 0x1 };
import "C"

const IFF_UP = C.IFF_UP

Running go tool cgo -godefs x.go with Go 1.14 produces
const IFF_UP = 0x1

With tip it produces
const IFF_UP = int32

Although -godefs is not seriously supported, we shouldn't break it like this.
This may be due to https://golang.org/cl/230037.  CC @mdempsky

I can look into it, unless you're already doing that.

I'm looking at it.  I have a fix.

Thanks a lot for fixing this @ianlancetaylor. Just noticed the same behavior while trying to re-generate x/sys/unix with go1.15beta1.


Wait until image exists.

In our experience, checking for AMI availability breaks many of our builds on GovCloud--there can be a brief delay between registering an AMI and the AMI existing via the API, so many builds fail with InvalidAMIID.NotFound. Adding a wait on AMI existence first resolves this issue for us.
Have you all encountered this kind of issue?

Have time to look at this @ljfranklin? If the change makes sense, I can target to develop.

@jmcarp sorry for letting this sit, we need to wire up better alerts for this repo. Before I got sidetracked, I tried running unit tests on this and it threw "WaitUntilImageExists not defined" or similar. If you could base this off develop and bump the AWS SDK to latest that would be fantastic. We've been bit by AWS eventual consistency bugs similar to this one in the AWS CPI, so I'm happy to merge this.

Closing as duplicate of https://github.com/cloudfoundry-incubator/aws-light-stemcell-builder/pull/8


Expose fault.http.abort.http_status setting via HTTTP header

Description: The partial implementation of https://github.com/envoyproxy/envoy/issues/10254. Adding a support for http header responsible for injecting faults - aborting requests with x-envoy-fault-abort-request HTTP header set.
Risk Level: low, new feature.
Testing: Added
Docs Changes: Added
Release Notes: Added

@mattklein123 @htuch I think that I've addressed all of your comments.
I have one question regarding tests. I've tried to add an integration unit tests to fault_filter_integration_test.cc file but every time I tried to inject an abort fault via HTTP header I ended up getting the following error while running tests:
[2020-03-10 01:25:56.208][12906338][critical][assert] [test/integration/http_integration.cc:384] assert failure: result. Details: Timed out waiting for new connection.

It fails on waitForNextUpstreamRequest(); which makes sense since from what I know there is no upstream request if we inject abort fault but I just want to confirm with you that it's fine.
A git patch that can be used to test this:
diff --git a/test/extensions/filters/http/fault/fault_filter_integration_test.cc b/test/extensions/filters/http/fault/fault_filter_integration_test.cc
index 70cfb89e5..68b55bb23 100644
--- a/test/extensions/filters/http/fault/fault_filter_integration_test.cc
+++ b/test/extensions/filters/http/fault/fault_filter_integration_test.cc
@@ -107,6 +107,7 @@ TEST_P(FaultIntegrationTestAllProtocols, HeaderFaultConfig) {
                                                  {":scheme", "http"},
                                                  {":authority", "host"},
                                                  {"x-envoy-fault-delay-request", "200"},
+                                                 {"x-envoy-fault-abort-request", "503"},
                                                  {"x-envoy-fault-throughput-response", "1"}};
   const auto current_time = simTime().monotonicTime();
   IntegrationStreamDecoderPtr decoder = codec_client_->makeHeaderOnlyRequest(request_headers);

Thanks, looks great with one small nit and test request. Nice work! In terms of adding an integration test, here is an example of a test that doesn't use an upstream, it just makes a request and expects a response:

Thank you! I tried something like this but it just got stuck on response->waitForEndStream():
// Request abort controlled via header configuration.
TEST_P(FaultIntegrationTestAllProtocols, HeaderFaultAbortConfig) {
  initializeFilter(header_fault_config_);
  codec_client_ = makeHttpConnection(lookupPort("http"));

  auto response =
      codec_client_->makeHeaderOnlyRequest(Http::TestRequestHeaderMapImpl{{":method", "GET"},
                                                                          {":path", "/test/long/url"},
                                                                          {":scheme", "http"},
                                                                          {":authority", "host"},
                                                                          {"connection", "close"},
                                                                          {"x-envoy-fault-abort-request", "429"}});
  response->waitForEndStream();
  codec_client_->waitForDisconnect();

  EXPECT_TRUE(response->complete());
  EXPECT_THAT(response->headers(), Envoy::Http::HttpStatusIs("429"));
}

Removal of  {"x-envoy-fault-abort-request", "429"} header didn't help. Sorry for a noob question but am I missing anything in my test?

I'm not sure why your test is failing, but it's probably an actual issue. I would recommend running your test with debug tracing locally to debug a bit. Try the following bazel flags:
--test_arg="-l trace" --test_arg="--gtest_filter=<your test>"

I was able to add an integration test for a case when abort header fault is injected and it's green. deec559
I still have problem when I try to write a test which that tests header delay and abort faults. I've tried to play with time using simTime().sleep(std::chrono::milliseconds(400)); in my test but it didn't help. More explanation below:

HTTP headers:
{":method", "GET"},
                                     {":path", "/test/long/url"},
                                     {":scheme", "http"},
                                     {":authority", "host"},
                                     {"x-envoy-fault-delay-request", "200"},
                                     {"x-envoy-fault-abort-request", "429"}}

I was able to debug the test using the following command:
bazel test //test/extensions/filters/http/fault:fault_filter_integration_test --test_arg="-l trace" --test_arg="--gtest_filter=Protocols/FaultIntegrationTestAllProtocols.HeaderFaultAbortAndDelayConfig/IPv4_HttpDownstream_HttpUpstream" --test_output=streamed

Debugging output:
2020-03-10 21:21:38.168][1205163][info][main] [source/server/server.cc:551] starting main dispatch loop
[2020-03-10 21:21:38.172][1205084][debug][testing] [test/integration/integration.cc:416] registered 'http' as port 56411.
[2020-03-10 21:21:38.174][1205084][debug][upstream] [source/common/upstream/upstream_impl.cc:274] transport socket match, socket test selected for host with address <IP_ADDRESS>:80
[2020-03-10 21:21:38.175][1205084][debug][client] [source/common/http/codec_client.cc:34] [C0] connecting
[2020-03-10 21:21:38.175][1205084][debug][connection] [source/common/network/connection_impl.cc:725] [C0] connecting to <IP_ADDRESS>:56411
[2020-03-10 21:21:38.175][1205084][debug][connection] [source/common/network/connection_impl.cc:734] [C0] connection in progress
[2020-03-10 21:21:38.175][1205084][trace][connection] [source/common/network/connection_impl.cc:492] [C0] socket event: 2
[2020-03-10 21:21:38.175][1205084][trace][connection] [source/common/network/connection_impl.cc:580] [C0] write ready
[2020-03-10 21:21:38.175][1205084][debug][connection] [source/common/network/connection_impl.cc:591] [C0] connected
[2020-03-10 21:21:38.175][1205084][debug][client] [source/common/http/codec_client.cc:72] [C0] connected
[2020-03-10 21:21:38.175][1205084][trace][connection] [source/common/network/connection_impl.cc:428] [C0] writing 130 bytes, end_stream false
[2020-03-10 21:21:38.175][1205201][debug][conn_handler] [source/server/connection_handler_impl.cc:353] [C1] new connection
[2020-03-10 21:21:38.175][1205084][trace][connection] [source/common/network/connection_impl.cc:492] [C0] socket event: 2
[2020-03-10 21:21:38.175][1205084][trace][connection] [source/common/network/connection_impl.cc:580] [C0] write ready
[2020-03-10 21:21:38.175][1205201][trace][connection] [source/common/network/connection_impl.cc:492] [C1] socket event: 2
[2020-03-10 21:21:38.175][1205201][trace][connection] [source/common/network/connection_impl.cc:580] [C1] write ready
[2020-03-10 21:21:38.175][1205084][trace][connection] [source/common/network/raw_buffer_socket.cc:68] [C0] write returns: 130
[2020-03-10 21:21:38.175][1205084][trace][connection] [source/common/network/connection_impl.cc:492] [C0] socket event: 2
[2020-03-10 21:21:38.175][1205201][trace][connection] [source/common/network/connection_impl.cc:492] [C1] socket event: 1
[2020-03-10 21:21:38.175][1205084][trace][connection] [source/common/network/connection_impl.cc:580] [C0] write ready
[2020-03-10 21:21:38.175][1205201][trace][connection] [source/common/network/connection_impl.cc:530] [C1] read ready
[2020-03-10 21:21:38.175][1205201][trace][connection] [source/common/network/raw_buffer_socket.cc:25] [C1] read returns: 130
[2020-03-10 21:21:38.175][1205201][trace][connection] [source/common/network/raw_buffer_socket.cc:39] [C1] read error: Resource temporarily unavailable
[2020-03-10 21:21:38.175][1205201][trace][http] [source/common/http/http1/codec_impl.cc:467] [C1] parsing 130 bytes
[2020-03-10 21:21:38.175][1205201][trace][http] [source/common/http/http1/codec_impl.cc:649] [C1] message begin
[2020-03-10 21:21:38.175][1205201][debug][http] [source/common/http/conn_manager_impl.cc:264] [C1] new stream
[2020-03-10 21:21:38.176][1205201][trace][http] [source/common/http/http1/codec_impl.cc:424] [C1] completed header: key=host value=host
[2020-03-10 21:21:38.176][1205201][trace][http] [source/common/http/http1/codec_impl.cc:424] [C1] completed header: key=x-envoy-fault-delay-request value=200
[2020-03-10 21:21:38.176][1205201][trace][http] [source/common/http/http1/codec_impl.cc:424] [C1] completed header: key=x-envoy-fault-abort-request value=429
[2020-03-10 21:21:38.176][1205201][trace][http] [source/common/http/http1/codec_impl.cc:570] [C1] onHeadersCompleteBase
[2020-03-10 21:21:38.176][1205201][trace][http] [source/common/http/http1/codec_impl.cc:424] [C1] completed header: key=content-length value=0
[2020-03-10 21:21:38.176][1205201][trace][http] [source/common/http/http1/codec_impl.cc:746] [C1] Server: onHeadersComplete size=4
[2020-03-10 21:21:38.176][1205201][trace][http] [source/common/http/http1/codec_impl.cc:628] [C1] message complete
[2020-03-10 21:21:38.176][1205201][debug][http] [source/common/http/conn_manager_impl.cc:764] [C1][S11532646105675666467] request headers complete (end_stream=true):
':authority', 'host'
':path', '/test/long/url'
':method', 'GET'
'x-envoy-fault-delay-request', '200'
'x-envoy-fault-abort-request', '429'
'content-length', '0'

[2020-03-10 21:21:38.176][1205201][debug][http] [source/common/http/conn_manager_impl.cc:1316] [C1][S11532646105675666467] request end stream
[2020-03-10 21:21:38.176][1205201][debug][filter] [source/extensions/filters/http/fault/fault_filter.cc:160] fault: delaying request 200ms
[2020-03-10 21:21:38.176][1205201][trace][http] [source/common/http/conn_manager_impl.cc:1025] [C1][S11532646105675666467] decode headers called: filter=0xd0
a15c0 status=1
[2020-03-10 21:21:38.176][1205201][trace][http] [source/common/http/http1/codec_impl.cc:488] [C1] parsed 130 bytes
[2020-03-10 21:21:38.176][1205201][trace][connection] [source/common/network/connection_impl.cc:314] [C1] readDisable: enabled=true disable=true state=0
[2020-03-10 21:21:38.176][1205201][trace][connection] [source/common/network/connection_impl.cc:492] [C1] socket event: 2
[2020-03-10 21:21:38.176][1205201][trace][connection] [source/common/network/connection_impl.cc:580] [C1] write ready

I confirmed that postDelayInjection method is never called here (and it should be called) https://github.com/envoyproxy/envoy/blob/139f926c1517672cdcc833e44c3b64d480e6ef39/source/extensions/filters/http/fault/fault_filter.cc#L160

Thanks for trying the delay integration test. I think we can probably give up on it now, but before we do that, can you show a diff of your proposed test? Where are you putting the sim time advance? I think the issue is that you are likely advancing time before the actual timer is created, so it's racing, and you have no way of actually knowing when it's safe to advance time. If we keep a gauge of active faults that are currently delayed (?) you could probably wait on this gauge being 1 and that would work, but I'm not sure if we do that.
cc @jmarantz.

Diff of the test I have problems with:
diff --git a/test/extensions/filters/http/fault/fault_filter_integration_test.cc b/test/extensions/filters/http/fault/fault_filter_integration_test.cc
index 44da53d1e..4040219e4 100644
--- a/test/extensions/filters/http/fault/fault_filter_integration_test.cc
+++ b/test/extensions/filters/http/fault/fault_filter_integration_test.cc
@@ -154,6 +154,31 @@ TEST_P(FaultIntegrationTestAllProtocols, HeaderFaultAbortConfig) {
   EXPECT_EQ(0UL, test_server_->counter("http.config_test.fault.response_rl_injected")->value());
 }

+// Request abort controlled via header configuration.
+TEST_P(FaultIntegrationTestAllProtocols, HeaderFaultAbortAndDelayConfig) {
+  initializeFilter(header_fault_config_);
+  codec_client_ = makeHttpConnection(makeClientConnection(lookupPort("http")));
+
+  auto response = codec_client_->makeHeaderOnlyRequest(
+      Http::TestRequestHeaderMapImpl{{":method", "GET"},
+                                     {":path", "/test/long/url"},
+                                     {":scheme", "http"},
+                                     {":authority", "host"},
+                                     {"x-envoy-fault-delay-request", "200"},
+                                     {"x-envoy-fault-abort-request", "429"}});
+
+  simTime().setMonotonicTime(simTime().monotonicTime() + std::chrono::milliseconds(1000));
+
+  response->waitForEndStream();
+
+  EXPECT_TRUE(response->complete());
+  EXPECT_THAT(response->headers(), Envoy::Http::HttpStatusIs("429"));
+
+  EXPECT_EQ(1UL, test_server_->counter("http.config_test.fault.aborts_injected")->value());
+  EXPECT_EQ(0UL, test_server_->counter("http.config_test.fault.delays_injected")->value());
+  EXPECT_EQ(0UL, test_server_->counter("http.config_test.fault.response_rl_injected")->value());
+}
+
 // Header configuration with no headers, so no fault injection.
 TEST_P(FaultIntegrationTestAllProtocols, HeaderFaultConfigNoHeaders) {
   initializeFilter(header_fault_config_);

You were right, my time modification logic is racing with the logic responsible for delay injection and I end up modifying time before I schedule a timer.


Fixing #670: restoring allowSnapshots which was disabled in PR #665

Fixing the problem related to snapshots in UpdateParentMojo + adding a unit test testing snapshots.

@slawekjaranowski please review

Just linking

#670

Still getting
[INFO] --- versions-maven-plugin:2.12.1-SNAPSHOT:update-parent (default-cli) @ parent ---
[WARNING] Not updating version: could not resolve any versions

with what invocation arguments? did you use -DallowSnapshots ?

with what invocation arguments?

mvn org.codehaus.mojo:versions-maven-plugin:2.12.1-SNAPSHOT:update-parent -DparentVersion=71-SNAPSHOT -DallowSnapshots=true

As there is no reproducer in original issue, here's my pom:
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>

    <parent>
        <groupId>org.codehaus.mojo</groupId>
        <artifactId>mojo-parent</artifactId>
        <version>70</version>
    </parent>

    <groupId>mojohaus</groupId>
    <artifactId>issue-670</artifactId>
    <version>0.31-SNAPSHOT</version>
    <packaging>pom</packaging>

</project>

        <groupId>org.codehaus.mojo</groupId>
        <artifactId>mojo-parent</artifactId>
        <version>70</version>

And what are the available versions of that artifact?

Or perhaps could you please refer to the artifacts in it-repo?

Thanks for the test case. Amended the PR.

Also added that test as an it.

@ajarmoniuk thanks for fix
@pzygielo thanks for testing


Networking process now finishes by itself when users Ctrl-C

The networking process wasn't finishing by itself upon receiving a
SIGINT because it wasn't stopping its endpoint.
With the above fixed, in most cases trinity should finish cleanly
without the need for calling kill_process_gracefully() for each
subprocess, so that is now only called if those processes take more
than 2s to finish after receiving the first SIGINT
With those changes, the workaround for #940 is now no longer needed
Finally, since now the networking process is generally not sent a 2nd
SIGINT (by kill_process_gracefully), #862 is also fixed
Closes: #862
Closes: #940

This is how a clean shutdown looks like now:
    INFO  09-21 14:08:29       FastChainSyncer  Starting sync with ETHPeer <Node(0xbbb3@<IP_ADDRESS>)>
    INFO  09-21 14:08:40       FastChainSyncer  Advanced by 167 blocks in 25.0 seconds, new head: #3973832
^C    INFO  09-21 14:08:43               trinity  Keyboard Interrupt: Stopping
    INFO  09-21 14:08:43  BasePlugin#JSON-RPC Server  Sent SIGINT to process 14633, waiting 10 seconds for it to terminate
    INFO  09-21 14:08:43     DiscoveryProtocol  stopping discovery
    INFO  09-21 14:08:43       FastChainSyncer  Sync with ETHPeer <Node(0xbbb3@<IP_ADDRESS>)> was shut down: Cancellation requested by FastChainSyncer:FullNodeSyncer:FullServer:RopstenFullNode token
   ERROR  09-21 14:08:43               asyncio  _GatheringFuture exception was never retrieved
future: <_GatheringFuture finished exception=CancelledError()>
concurrent.futures._base.CancelledError
    INFO  09-21 14:08:43           ETHPeerPool  ETHPeer <Node(0xbbb3@<IP_ADDRESS>)> finished, removing from pool
    INFO  09-21 14:08:43           ETHPeerPool  Stopping all peers ...
    INFO  09-21 14:08:43            FullServer  Closing server...
    INFO  09-21 14:08:43  BasePlugin#JSON-RPC Server  Process 14633 has already terminated
    INFO  09-21 14:08:43               trinity  DB process (pid=14628) terminated
    INFO  09-21 14:08:43               trinity  Networking process (pid=14632) terminated
Trinity shudown complete

@gsalgado this is also addressed in https://github.com/ethereum/py-evm/pull/1309

@gsalgado this is also addressed in #1309

Ok, maybe just duplicate the changes to kill_trinity_gracefully() there as well and then we can close this?

@gsalgado sounds good. I'll get to it when I get home. Just keep this PR open for now as a reminder and I'll close it when I refactored it in.


Slider

Start by suggesting the YAML for this widget.

@hamxa152 as Amin suggested, the first step, please suggest the YAML for the widget and tag me in the comment. Once we approve the YAML, you can start implementing. When you are working on something, please put that in progress.

assigning to Sneh as he is already working on it

Checked in with https://github.com/EnsembleUI/ensemble/pull/692


Multi Select - Design & Usage Guidelines

As a developer for Reaction or a member of the Reaction community, I should be able to get design guidelines on a component level for the multi select component.

Multi-select design guidelines: zpl.io/295jjed


OnPreSceneQuery Null Ref Error

Describe the bug
I keep getting following error when running on hololens.
NullReferenceException: Object reference not set to an instance of an object.
Microsoft.MixedReality.Toolkit.Input.GGVPointer.OnPreSceneQuery () (at <00000000000000000000000000000000>:0)
Microsoft.MixedReality.Toolkit.Input.FocusProvider.UpdatePointer (Microsoft.MixedReality.Toolkit.Input.FocusProvider+PointerData pointer) (at <00000000000000000000000000000000>:0)
Microsoft.MixedReality.Toolkit.Input.FocusProvider.UpdatePointers () (at <00000000000000000000000000000000>:0)
Microsoft.MixedReality.Toolkit.Input.FocusProvider.Update () (at <00000000000000000000000000000000>:0) Microsoft.MixedReality.Toolkit.MixedRealityToolkit+<>c.<UpdateAllServices>b__68_0 (Microsoft.MixedReality.Toolkit.IMixedRealityService service) (at <00000000000000000000000000000000>:0) System.Action`1[T].Invoke (T obj) (at <00000000000000000000000000000000>:0)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.ExecuteOnAllServices (System.Action`1[T] execute) (at <00000000000000000000000000000000>:0)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.Update () (at <00000000000000000000000000000000>:0)

To reproduce
Use toolkit and build project.
Expected behavior
The error should not be printed constantly.
Your Setup (please complete the following information)

Unity Version 2019.1.14f1
MRTK Version RC 2.1

Target Platform (please complete the following information)

HoloLens
HoloLens 2

Additional context
Add any other context about the problem here.

@lordlycastle, are you able to update your MRTK version and try again? MRTK Version RC 2.1 is pretty old now. Thanks!

Closing this old issue out - I think that this is basically this one:
https://github.com/microsoft/MixedRealityToolkit-Unity/issues/5494
The tricky part is that we haven't really seen this recently and we've made a ton of changes to the MRTK since this was originally filed.
If folks are still seeing this I think that attaching some min repro would go a long way to figuring out what's going on.


Update Service Template with Nicer Formatting

Copy formatting from github.io/index.html for user and bot message styling.

Completed and added version number as well.


Word wrapping

Hello,
How to Disable & Enable Word wrapping Console in Windows Terminal?
If this feature does not exist, please add it.
Thanks.

I looking for this option:

Wait could you elaborate more? Is there a specific scenario that doesn't work well with word wrap? There might be better tools or other bugs that would help more than "disabling word wrap sometimes".

Wait could you elaborate more? Is there a specific scenario that doesn't work well with word wrap? There might be better tools or other bugs that would help more than "disabling word wrap sometimes".

I want to toggle word wrap at runtime. (Like Visual Studio Code)

Ah okay. What you're looking for is /dup #1860

Both issues are closed now, however we don't have the possibility to disable the word wrap yet :(

Not having the option to disable the wrap has made windows terminal impossible to be used on a vertical screen.

Has this been fixed? As far as December 2024, I've search for this line wrapping option in Windows Terminal Version: 1.21.3231.0, and it is not available (hopefully I've searched in the right places).
I need it for a better organized logging display. In the following window arrangement, the logging on the left side of the screen is less readable than if it where unwrapped. An horizontal scrollbar would make working with it smoother.

As as side note, as you can see from this comment in the present issue, the feature is heavily needed:


createst: add midstream arg - v10

Add optional argument '--midstream' to add that as an argument to test.yaml.
Default is still midstream false.
usage:
createst.py [--midstream]
before:
args:
- -k none

after:
args:
- -k none
- --set stream.midstream=true

Previous PR: https://github.com/OISF/suricata-verify/pull/987
Update from Last PR: rebased.

Merged. Thanks!


Fix default starter python app image

The default https://github.com/cloud-native-robotz-hackathon/robot-gitops/blob/main/base/namespace/robot-app/deployment.yaml#L17 failes ....
Let's use build a nice one an storage it at quay.io/cloud-native-robotz-hackathon/

Fixed


Add practice mode support

What should @mapeo/core expose to help applications switch between a project and training mode?

Implementation plan

Create a shared project key that is included in app code, e.g. sha256Hash(Buffer.from('MAPEO_PRACTICE_MODE'))
On first load of the app, the "practice mode project" should be joined, using the shared project key
Skip role checks for practice mode projects: all devices are project "members" by default. No support for invites (e.g. no one is "coordinator")
Blacklist practice mode project key from internet sync


[Style] Enhance Circular Prime Calculator UI

Description
Making the circular prime calculator a bit more artistic and feature rich.
Currently the page looks out of alignment and haven't used the functionalities of CSS effectively.
Please assign me the task so that i can make the page exquisite. (requesting as a part of GSSoC 2024)
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[x] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Hey there! I am excited to contribute to this project; please assign it to me under GSSoc'24 @Rakesh9100

Proceed @AnandK-pm


Use Calendar endpoint instead of hardcoding term dates.

There's an endpoint on PP to get term dates, but we're still hardcoding it like monkeys.
https://docs.api-next.peterportal.org/docs/developers-guide/rest-api/reference/calendar
Related Issues
#758

Terms endpoint is kinda dope >:), but it's not documented ;(

Passing this onto other AntAlmanac folk 🫡

It's too much of a PITA.


BetterPickers lib has moved and is now maintained by Code-Troopers

https://github.com/code-troopers/android-betterpickers

@fchauveau thanks

@fchauveau oh just saw you did it on the wrong branch. the main branch is develop not dev


with own base image api is not starting anymore

If i publish using this command:
dotnet publish -c Release -p:ContainerBaseImage=registry-1.docker.io/kleymannl/dotnet-libfontconfig1:latest -p:ContainerImageName=replaced/replaced -p:RuntimeIdentifier=linux-x64
the container is not starting anymore and I get following error message:
replaced.path: no such file or directory
My base image looks like this:
FROM mcr.microsoft.com/dotnet/runtime-deps:7.0
RUN apt-get update
RUN apt-get install -y libfontconfig1

BinLog is a little bit complicated, because it contains sensitive data for me.
Can I share it to you privately? @baronfel

Sure! Create a new developer community ticket here, and once you've created the ticket you can upload the binlog privately to that site. Then you can comment back here with the link to the ticket you just created and I'll be able to securely access the binlog.

Okay thanks. I attached the binlog to a private comment for microsoft only.
https://developercommunity.visualstudio.com/t/sdk-container-builds:-with-own-base-imag/10461318

@LennartKleymann can you take a look at this comment? This is what I'm hoping to get into .NET 8 that would identify and force you to handle this error case.

@baronfel Hey, sorry for the late response.
With building my base image on the correct plattform my publsih of my API works.
I think that the comment you link is really good to prevent confusion, thank you really much.


url_for: 500 Internal Server Error

In Flaskr example, I'm getting the following for url_for('add_entry')
Internal Server Error
The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application.
This is running behind uwsgi with emperor mode. Logs are absent and do not show the real problem and I'm unable to diagnose.

Run the app in debug mode (app.debug = True) to see the exception/traceback.
Also, during local development/testing the builtin dev server is pretty useful. No need for a full-blown webserver. It just makes things more complex.

That is one of the problems. When running the app with python directly it does work and shows '/add' correctly. When I move to the nginx + uwsgi it shows this 500 error.

Configure Python's logging to enable Flask's traceback output in production (the following example configures it to print to stderr, which should get captured by uWSGI.  Please post the full traceback for us to examine.
import logging
handler = logging.StreamHandler()
handler.setLevel(logging.ERROR)
app.logger.addHandler(handler)

I didn't get anything on terminal with that.

When I change it to {{ url_for('index') }} it returns '/microblog/'. For anything else it returns 500 error.

But I need {{ url_for('add_entry') }} to return '/microblog/add'

There's not enough information here to continue.  Try configuring logging to log to a file instead, if uWSGI isn't picking up stderr.

OK @davidism, thanks for your support!

For future reference I was able to get some backtrace following http://librelist.com/browser/flask/2012/1/27/catching-exceptions-from-flask/#e3f303db052ce2bdae0801269b51d55d
I had to add --catch-exceptions to uwsgi command line and app.config['PROPAGATE_EXCEPTIONS'] = True to the application.

Internal Server Error
The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application.

i need a support

@chaitanya425 Both your comments are completely useless. You posted a super generic error message and nothing else. What do you expect us or anyone else to do there?

@ThiefMaster  i need solution

Seriously, what do you expect? You didn't even post any code. Anyway, this is the wrong place. Go to Stack Overflow or our Discord/IRC channel, and share your code. Debug mode also help in seeing what's actually failing.

@ThiefMaster  cool bro i need help in error (500 Internal Server Error) do you have solution please  tell me otherwise.         i know stack overflow ok .


Spread and rest properties

Closed by https://github.com/dop251/goja/commit/a7a3a1366b2e7b74058af3de88cc540748d31096


ZooKeeper compatibility layer

Could we adapt tikv as a dropin replacement for ZooKeeper? ZooKeeper is nortoriously unstable, so some kind of adapter for zk clients to use tikv as a backend would be tremendously helpful to transition to more reliable systems.

Honestly speaking, you can do it. But TiKV is designed as a large scale storage system, not like zk & etcd, TiKV doesn't support APIs like Watch/Ephemeral Nodes/... but yeah...if you have distributed transaction and Raft, it's doable...
But IMHO, use etcd as dropin replacement for zk is a good idea...


[Bug] use with package that using reactNativeRanimated failed

Describe the Bug
I followed the documentation here on integrating the react-native-reanimated library with Storybook.
When I create components containing animations, everything works as expected. However, when I incorporate another package that also includes animations, the web version of the app breaks (while the native app remains unaffected).
I am using Storybook version 7, and you can find the relevant commit here.
You can view an example of my package here.
Steps to Reproduce

Clone the repository:git clone git@github.com:YOEL311/storybookPublic.git
cd storybookPublic
yarn
yarn storybook

in web i got this error
[Reanimated] `useAnimatedStyle` was used without a dependency array or Babel plugin. Please explicitly pass a dependency array, or enable the Babel/SWC plugin.

However, removing the animation from the external library and keeping only the animation of my app resolves the issue. You can see the specific code here.
I have added the configuration for react-native-reanimated here.

@YOEL311 you have three configurations for the same config you must have only one
in your config:
    '@storybook/addon-react-native-web',
    {
      name: '@storybook/addon-react-native-web',
      options: {
        modulesToAlias: {
          'react-native-linear-gradient': 'react-native-web-linear-gradient',
        },
      },
    },
    {
      name: '@storybook/addon-react-native-web',
      options: {
        modulesToTranspile: ['react-native-reanimated'],
        babelPlugins: [
          '@babel/plugin-proposal-export-namespace-from',
          'react-native-reanimated/plugin',
        ],
      },
    },
  ],

expected config:
    {
      name: '@storybook/addon-react-native-web',
      options: {
       modulesToAlias: {
          'react-native-linear-gradient': 'react-native-web-linear-gradient',
        },
        modulesToTranspile: ['react-native-reanimated'],
        babelPlugins: [
          '@babel/plugin-proposal-export-namespace-from',
          'react-native-reanimated/plugin',
        ],
      },
    },

Hi @dannyhw
Thank you for your reply. I appreciate it.
I made the necessary changes, but I still encountered the same error.

@YOEL311  you still have it two times

look here remove this line 6
https://github.com/YOEL311/storybookPublic/blob/8c936a99299efb6fc8d9eb52f59e2c12c4ab459b/.storybook/main.js#L6

ok but I still got the error

Well you can also just manually add the dependency array to your useAnimatedStyle
for example:
  const animatedStyles = useAnimatedStyle(() => ({
    transform: [{ translateX: withSpring(translateX.value * 2) }],
  }), translateX.value);

@YOEL311 I found the issue, you need to add your package to the modulesToTranspile or add the dependency array in the component in that package
update the modulesToTranspile to this:
     modulesToTranspile: [
          'react-native-reanimated',
          'test-package-yoel-test',
        ],

@dannyhw
Thanks
I have to give you my salary (:


operator project-quay (3.10.0-nightly.20230821)

Add 3.10.0-nightly.20230821 to community operators

/merge possible

/merge possible


Better ImportError message when a dataset script dependency is missing

When a depenency is missing for a dataset script, an ImportError message is shown, with a tip to install the missing dependencies. This message is not ideal at the moment: it may show duplicate dependencies, and is not very readable.
I improved it from
ImportError: To be able to use bigbench, you need to install the following dependencies['bigbench', 'bigbench', 'bigbench', 'bigbench'] using 'pip install "bigbench @ https://storage.googleapis.com/public_research_data/bigbench/bigbench-0.0.1.tar.gz" bigbench bigbench bigbench' for instance'

to
ImportError: To be able to use bigbench, you need to install the following dependency: bigbench.
Please install it using 'pip install "bigbench @ https://storage.googleapis.com/public_research_data/bigbench/bigbench-0.0.1.tar.gz"' for instance'

Discussed offline with @mariosasko, merging :)

Fwiw, i think this same issue is occurring on the datasets website page, where preview isn't available due to the bigbench import error

For the preview of BigBench datasets, we're just waiting for bigbench to have a stable version on PyPI, instead of the one hosted on GCS ;)


Change API for 'hasPreimage' to 'getPreimage'

The getPreimage API is created into the FullNode API and the hasPreimage API is removed.
In EnrollmentManager, there are two functions getting a pre-image information for a validator or a node, which is confusing now but will be handled in bpfkorea#604 issue.
For unit test, the broadcastPreimage API is added in TestAPI.
Fixes #567
Fixes #566

After modifying one thing, I will request review.
Please don't review now.

Ready for review.
The ci/circleci build output error continuously as follows.
object.Exception@ci/system_integration_test.d(67): Command failed: ["dub", "--root", "/home/circleci/project/tests/system"]
----------------
??:? void system_integration_test.runCmd(const(immutable(char)[][])) [0x48eb28]
??:? _Dmain [0x48e7e5]

If it should be handled, please let me know.

This is not your error. You have to look at the full log, not just the last few lines ;)

Addressed review

@linked0 : Still need to fix the CircleCI error though.

The circleci build outputs error continuously. There seems some problem in calling spawnProcess with the parameter of "["dub", "--root", "/home/circleci/project/tests/system", "--", "http://<IP_ADDRESS>:4000", "http://<IP_ADDRESS>:4001", "http://127.0 .0.1:4002"]".
What should I try to solve it?

The error is:
Linking...
tests/system/.dub/build/application-debug-linux.posix-x86_64-dmd_2090-DB8FB99E8E2FF2C1325A116C295C574C/systemtest-simple.o:(.data.rel.ro+0x20): undefined reference to `_D5agora9consensus4data12PreimageInfo12__ModuleInfoZ'
tests/system/.dub/build/application-debug-linux.posix-x86_64-dmd_2090-DB8FB99E8E2FF2C1325A116C295C574C/systemtest-simple.o:(.data.rel.ro+0xa80): undefined reference to `_D5agora9consensus4data12PreimageInfo12__ModuleInfoZ'
collect2: error: ld returned 1 exit status
Error: linker exited with status 1
/home/circleci/dlang/dmd-2.090.1/linux/bin64/dmd failed with exit code 1.

It means one of your module is missing in dub.json (agora.consensus.data.PreimageInfo).

It means one of your module is missing in dub.json (agora.consensus.data.PreimageInfo).
Thank you. I'll check it out.

Rebasing on v0.x.x should fix it.

Ready for review and thank you for supporting for the build.

Ping @AndrejMitrovic


Require Authentication on FE and BE

[x] Backend
Add the isAuthenticated endpoint where needed. Make sure it's the same user.

[x] Frontend
Add all tokens to frontend requests where needed

finished issue


tfsec reports AWS051 error when storage_encrypted = true and no kms_key_id specified in aws_rds_cluster

Describe the bug
It looks like if an aws_rds_cluster is defined with no kms_key_id property and with storage_encrypted = true, tfsec reports an error for AWS051. Terraform and the AWS provider support having an aws_rds_cluster with storage_encrypted = true and no kms_key_id set, which causes the default aws/rds KMS key for the account to be used for encryption (Default master key that protects my RDS database volumes when no other key is defined). So, I assume this shouldn't raise an error in tfsec.
To Reproduce
Steps to reproduce the behavior:

Create a Terraform config with an aws_rds_cluster with storage_encrypted = true and no kms_key_id set.
Run tfsec
Confirm that AWS051 error is raised.

Expected behavior
tfsec should not raise an AWS051 error when storage_encrypted = true and no kms_key_id is set for an aws_rds_cluster.
Desktop (please complete the following information):

OS: Windows 10
Version tfsec v0.39.21, Terraform v0.14.10, provider registry.terraform.io/hashicorp/aws v3.37.0

Owen, Thanks for taking a look!

@jslevin4 - thanks for pointing it out, its issues that keep us on the right track!


[TC-EEVSEM-1.2] In step 2 comment has to be updated as per VS document

Description:
TC-EEVSEM-1.2
Step 2 - In Test plan check for TagName field has been removed from the Expected Outcome and Verification step has been updated accordingly. So Yaml-Maual script has to be updated as per the Verification step document by removing the If the Value field is in the MfgTags (0x8000 to 0xBFFF) range, the TagName field is a string with a length between 1 and 64  Comment from the Step2.
Steps to reproduce:
Test step 2
Test plan for references:

https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/mode_energy_EVSE.adoc

Verification step document for References:

https://docs.google.com/spreadsheets/d/13zltSz50GRs_kidvobceEuIT8kAAHSK64ANyWcc3xQI/edit?gid=862152136#gid=862152136&range=14:14

Yaml Script for References:

https://github.com/project-chip/connectedhomeip/blob/master/src/app/tests/suites/certification/Test_TC_EEVSEM_1_2.yaml

Test plan PR for references:

https://github.com/CHIP-Specifications/chip-test-plans/pull/4145

@Ashwinigrl is this test not automated ? Could you reach out to James and see if this is covered as part of the TE2 automated scripts ?


[Feature request] - ViewComponent support

ViewComponent is a new library from Github that is gaining support quickly. It encapsulates views and partials into objects that can be easily rendered and tested. However, as far as I can tell, there is not a great way to use the Page Object Model and specifically site_prism with this awesome new tool.
In my head, I think the ideal way this would work is I would create a section class (inheriting from SitePrism::Section), then instantiate that with the html output coming from render_inline(MyComponent.new(...)).to_html from ViewComponent's helpers. Then I could interact with that in the same way I could any other section on a page. I could also reuse that section class in a feature test when I'm using a browser driver to interact with the page, getting double bang for my buck.
I'm not sure exactly what would be needed to make this work. Essentially I think I want to instantiate a Section without a Page, and without requiring capybara to pre-define a page object. I'm not sure if this requires any changes to site_prism or even capybara, or if I'm just missing how to do this with the current version of the library.
Any help with this is greatly appreciated!

So some things you need to be aware of

You can instantiate raw html just by doing Capybara.string(html) - This works as a page when doing #load
A Section "technically" doesn't need a page. If you mocked out and used doubles it would work. A Section has 3 initialize args. A root_element a parent and an optional block. Here the only important one is root_element, as this provides your scoping.

If you instantiated a Section and provided a nil arg for parent. Then #parent_page would throw an error. But as this is a rarely called method, pretty much everything else should work as intended.
It's worth pointing out instantiating a Section is pretty much entirely api private (I know we don't document it as such), so any issues you encounter there are unlikely to be fixed, unless you can show the fix is completely backwards compatible.

@luke-hill That's very helpful info. I'll give that a shot and see if it works. If it works well, maybe site_prism could consider some of those "private apis" public and I can write up some documentation on how this gem would be used with view_component.

They're only api private in the sense of they should not be initialized directly, but instead created through the usage of SitePrism in a normal manner. It wouldn't be something we would advise people to do, because then traits would not be passed down through inheritance (parent / page for example).

Alright, dug into this a little more and it works like you said:
html_string = render_inline(LabelComponent.new(args)).to_html # Render the html from my ViewComponent class
capybara_object = Capybara.string(render_inline(described_class.new(args)).to_html)
section = LabelComponentSection.new(nil, capybara_object)
section.text # This works as expected.

It looks like Capybara.string is a public method, so that's fine. The only thing that isn't 100% "kosher" here is the LabelComponentSection.new. Like you said, that's not exactly a private method, but from the SitePrism docs, it's not intended to be used directly. I think what I'll do is create a little helper method to do that step, so that if the API for that changes later, it'll be easy to swap out my implementation. Maybe that helper could make its way back into site_prism as an official API? Just something like:
def render_section(section_class, capybara_object)
  section_class.new(nil, capybara_object)
end

Do you mean like this? https://github.com/site-prism/site_prism/blob/master/lib/site_prism/dsl.rb#L142

Hmm. I guess that line, but wrapped in a publicly accessible API, documented in the readme. So it's an officially supported way to create a section by itself. Maybe even pull the Capybara.string call into it. So something like SitePrism::Section.from_string(string)

The problem is what your describing only works in a subset of situations. You are attempting to create a section without it "belonging" anywhere. I still don't get why you need to manually create a section without doing the DSL inline.
If you had a Page Object representing your page, just do section :name_of_section, '.locator.of.section'
I'm aware you're in a testing / mocking phase. But if you're looking to use SitePrism, you should have a basic concept of your page / section. So you should have as the bare minimum
Something representing your page (I think here you have an html fragment as a string)
Something representing your section (I think here you have a locator or something inside your html string)
If you want to submit a PR feel free. But I'm still not seeing what you can't do with the existing code. The only idea that I potentially have that would save a lot of time, is if you wanted the section "scoped" as the full page. i.e. your testing some small section which is the entire view (Like you would say on Storybook). In which case the parent would basically be non-infinite version of self. The best / quickest way to remedy this would be something like.
SitePrism::Section.new(SitePrism::Page.new, locator_of_section)
Consequently, a PR which "defaulted" the Section initializer to a new instance of page if a separate parent wasn't provided would be accepted, which would then leave you with your version being just.
SitePrism::Section.new(locator_of_section)- Which to me feels almost like what you're trying to achieve. But I might be wrong.

@luke-hill sorry for the confusion. What you describe with Storybook is close to what I'm looking to do here. You can think of ViewComponent as basically a different way to create a rails partial (eg _label.html.erb or _label.html.slim). I want to unit test that in isolation, without having to load up a whole page (and do the routing and controller and whatnot). What I'm describing could also be useful in testing rails partials in isolation, for example in a view spec (though I've not seen those used that often).
One reason to do this vs a full-fledged feature test in Capybara is it adds the overhead/time of loading a headless browser, hitting the routes & middleware, and hitting the controller (which likely needs to have some setup or stubbing to get to a particular render state of the component being tested).
Now, I could test the html string manually, which is essentially what the ViewComponent readme recommends. But I like the SitePrism style of creating objects to represent pages and sections of pages, so that you can interact with them in an abstracted way. So, what I'd like is a way to turn that html partial string (output of the render_inline helper from ViewComponent, which is a subsection of the entire DOM "Some text"), into a SitePrism object. As stated above, this also has the benefit that when I use that component/partial on a page and test the entire page with a feature test, I can re-use the SitePrism object there as well, probably embedded in a Page object.
What you describe above "a basic concept of your page / section" makes sense. I could see creating a stubbed Page object as a wrapper around the component/partial/section being tested. But I want that process of creating the mocked page to be easy, with minimal boilerplate.
As for what I can't do with the existing code, I think everything is there and I could start using a method-ized version of that snippet I posted above. Matter of fact, I've already created that in my codebase:
  # Renders a ViewComponent into a SitePrism::Section class
  def render_to_section(component, section_class, &block)
    html_string = render_inline(component, &block)
    capybara_object = Capybara.string(html_string)
    section_class.new(nil, capybara_object)
  end

  # usage
  render_to_section(LabelComponent.new({ type: "warn" }), LabelComponentSection) { "Some text" }

I'm just worried about calling the SitePrism::Section.new directly, without going through the DSL, because like you said, that's kinda a private API. Or at least it's not documented as something that should be used. So I'm worried that some refactor in the future might break my implementation. To avoid that, I'd like to move my method (or some variation of it) into the SitePrism codebase.
This is basically what my PR would contain (though implemented in the actual code, rather than a monkeypatch):
module SitePrism
  class Section
    def self.from_view_component(component, &block)
      html_string = render_inline(component, &block).to_html
      capybara_object = Capybara.string(html_string)
      self.new(nil, capybara_object)
    end
  end
end

# usage
LabelComponentSection.from_view_component(LabelComponent.new({ type: "warn" })) { "Some text" }

or, if you want to remove the coupling to ViewComponent:
module SitePrism
  class Section
    def self.from_string(html_string)
      capybara_object = Capybara.string(html_string)
      self.new(nil, capybara_object)
    end
  end
end

# usage
html_string = render_inline(LabelComponent.new({ type: "warn" })) { "Some text" }
LabelComponentSection.from_view_component(html_string)

As mentioned we don't need to extend the public API, we can just default the Section to having the parent as a page entity. That's a tiny PR, but one which would probably go into a major release, as you would need to flip the argument assigns.
That then fixes all of your issues. As for calling Section initialization yourself. Again I would just use the DSL, and inside a page just call section :name, locator You can load a html page from a string by default using our API.

You can create a blank / semi blank site prism page, and then just pass in your capybara string to the load function, we handle the rest dynamically.
See https://github.com/site-prism/site_prism/blob/master/spec/site_prism/page_spec.rb#L109-L210 for more info - They cover a fair few use cases.

ping @dkniffin is there anything else needed commit wise here?

I haven't been working with ViewComponent in a bit for unrelated reasons. I think this is good-to-go for now, so I'll close this and if I run into issues again later, I'll ping again or open a new issue.


Can't create new Image in 3.0?

Using Godot_v2.1.4-beta_20170625_win64 on Windows 10, I could use the code below to create a new image and set it as the texture of a sprite (with _RGBA instead of _RGBA8).
In Godot_v3.0-alpha_win64, I get the following error message on line 4
Invalid call. Nonexistent function 'Image' in base 'Sprite (sprite.gd)'.
extends Sprite
var img
func _ready():
	img = Image(256, 256, false, Image.FORMAT_RGBA8)
	for i in range(0, 256):
		for j in range(0, 256):
			var r = i / 255.0
			var g = j / 255.0
			var b = (i + j) / 255.0
			img.put_pixel(i, j, Color(r, g, b, 1))
	var tex = ImageTexture.new()
	tex.create_from_image(img)
	set_texture(tex)
	pass

Not a bug, just a change in the API. Image is not a built-in type anymore, so you have to do something like this:

Okay, thanks


Luigi Visulizer Pruning : Turning off

Hi
I am interested in being able to turn off pruning or change the timing to be settable in the config file.  I noticed the following code in server.py
...
# prune work DAG every 60 seconds
pruner = tornado.ioloop.PeriodicCallback(scheduler.prune, 60000)
pruner.start()
....

I think this is where this is getting set and I am looking to see if this is the only place.
I would be happy to work on making this a configurable option but it would be good to get some guidance as I haven't looked at this code much and have not yet done a PR from GitHub.
Thanks.

I also see the scheduler.py does some pruning.

Why do you want to do this? Luigi prunes the graph on every page load even if I'm not mistaken even.

If you want to make tasks live longer, then that is already configurable. :)

I would like to have the dependency graph around longer.  How do I do this ?  Is this what you are referring to being configurable ?

@steveb-cirina See remove-delay in the scheduler configuration section - https://luigi.readthedocs.io/en/stable/configuration.html#scheduler-config
The prune method gets called on a regular basis but it only removes tasks if they haven't had any stakeholders for remove-delay seconds.

@chrispalmer Thanks, I will check that out.

Closing this. I don't think there's any follow-up on this at the moment.


modularize domain decomposition

The domain decomposition, whereby cells were partitioned across domains/MPI
ranks and then grouped together, was performed in an ad-hoc manner.
This PR modularizes the domain decomposition.

A domain_decomposition class performs the cell partitioning given the recipe
and some parameters.
This implementation has a single domain_decomposition class and flags are
provided in a group_rules struct

The domain_decomposition could be specialized, or the simple rules struct
could provide some sort of policy implementation in the future when the
need arises

The domain_decomposition class is initialized inside the model constructor
and is maintained as state of the model.

In the future when the domain decomposition is responsible for load balancing
and gid renumbering it will provided the translation between user and model
gid numberings.
For this reason I have put it inside the model.
But I am open to discussion about whether domain decomposition ought to be
performed before model creation.

The cell model constructor interface has been simplified to a single constructor
that takes a recipe and the group_rules.

fixes #242

I am looking for some feedback here.
It has unit tests for using without MPI, however I have only got placeholders for the MPI tests.
All these tests will become much richer when we have multiple cell types and gid renumbering.

Currently debating design with @bcumming IRL ...

In terms of the design, I am counter-proposing the following:

The domain_decomposition object is instantiated at the application level.
model gets passed only the recipe object and a group_allocation object which comprises

A cell gid partition (representing map from local group index to cell gid interval).
A map from group index to (suggested) hardware back-end.

The model code then remains very nearly unchanged; it gets the cell_kind for any particular group from the recipe directly.
Why keep them separate? I believe it is a cleaner, tighter design, for the following reasons:

The domain decomposition can be queried, or potentially tweaked, at the application level independently of model creation.
Querying the decomposition gives the option of the application-level code pre-allocating or configuring structures, i/o etc. just for the cells that are process-local, again without needing to first instantiate the model.
Keeping decomposition information queries outside of the model object reduces the size of the model interface.
The model takes a more concrete data structure for the decomposition, instead of wrapping a more opaque object whose behaviour needs to be understood in conjunction with the model initialization code.
If a more complicated domain decomposition process requires global communication, then that communication point would be explicit in the application code rather than implicit in the model constructor.
It makes it easy to instantiate multiple models over arbitrary and explicit ranges of cells, simplifying testing code.


Always on Top border remains after moving window

Microsoft PowerToys version
"0.63.0"
Installation method
Windows Store
Running as admin

[x] Yes

Area(s) with issue?
Always on Top
Steps to reproduce
I simply used the function and then moved the window.
✔ Expected Behavior
While moving, the border stays with the window
❌ Actual Behavior
The border stays with the windows but it has created a new border.

Even if i disable the always on top with the shortcut, the border stays.
I need to restart Powertoys to let the ghost border go away.
Other Software
cmd.exe

@theking2
As you reported the issue too, I like to ask some questions for investigating:

Does it happen every time?
Does it happen with every program? (If not does it happen with a special type (pop-up, ...) of windows?)

cc: @SeraphimaZykova

Every time? difficult to say. I have a ghost on my screen right now.
I do have multiple screens attached to my setup, it might be that?

@theking2
Can you please upload a "Report Bug" zip file here?    Then drag the zipfile from your desktop onto the GitHub comment box in this issue.  Thanks!

PowerToysReport_2024-04-20-12-27-59.zip
I-ve deleted stuff unrelated to AOT