Queries result in error

' operator: Failed to resolve table or column or scalar expression named 'WVDErrorV1_CL'
If issue persists, please open a support ticket.
Even using only 'WVDErrorV1_CL' in the query results in error

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1fbeb2fb-b956-ebb4-1d0b-fb32c5ecccd0
Version Independent ID: f225fa84-9cfe-d58f-4794-3ce09ff51808
Content: Windows Virtual Desktop diagnostics log analytics - Azure
Content Source: articles/virtual-desktop/diagnostics-log-analytics.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

I did follow the steps and later discovered that the error is present until
there are applicable log entries to query on. The query should be adjusted
to properly handle lack of entries among the joins. Thank Ltd for the
response.
On Fri, Apr 3, 2020 at 3:04 PM Karishma Tiwari - MSFT <
<EMAIL_ADDRESS>wrote:

Have you followed the steps described in this doc?
https://docs.microsoft.com/en-us/azure/virtual-desktop/deploy-diagnostics
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/51652#issuecomment-608608702,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGVLZDGZS2YGMXFK7B23RR3RKYXM3ANCNFSM4L4BKLNQ
.

Thanks for sharing the update.
I have assigned the issue to the content author to investigate further and update the document as appropriate.

@Karishma-Tiwari-MSFT we still get the query error, could you assign this to someone on high priority as its affecting the business.
Thanks.

@sajidfaizan The query error happens because there are no errors to report.
If you go to the workspace where your diagnostics data is, then go to Logs and check the Tables tab in the query, you can see if there are any errors listed there. If there's no table, then that means there are no errors for the query to report, which is why the query fails.

Thanks @Heidilohr for sharing insights on this. :)
@sajidfaizan Hope that helps answer your question.

Hi @Karishma-Tiwari-MSFT , @Heidilohr
Thank you for your time.
Refering to this microsoft documentation
https://docs.microsoft.com/en-us/azure/virtual-desktop/diagnostics-log-analytics
under section "Example queries", i should have all these 3 tables(WVDActivityV1_CL, WVDErrorV1_CL, WVDCheckpointV1_CL) under Custom Logs, but i have only WVDActivityV1_CL not the rest 2. Since all data joined using these tables are very much required. If there are no records in all tables that is not the problem for me, problem is non-existence of the tables, due to which query runs with error.

Hi @Karishma-Tiwari-MSFT , @Heidilohr
I am following below microsoft documentation
https://docs.microsoft.com/en-us/azure/virtual-desktop/diagnostics-log-analytics
under section "Example queries",  there is 3 table given WVDActivityV1_CL, WVDErrorV1_CL, WVDCheckpointV1_CL some time  only WVDActivityV1_CL table comes sometime WVDActivityV1_CL and the second table come after 10 mins or it takes more WVDCheckpointV1_CL but the third table WVDErrorV1_CL is not coming. In absence of my
WVDErrorV1_CL this table i can't run that query.

Closing due to this being a support a support issue, rather than the article itself.
#please-close


Fix type checking errors for dtypes that are not subtypes of np.generic

Bug fix for #6:
Sometimes, type checkers will complain about certain dypes, since they are not actually typed as subtypes of np.generic in numpy. Example:
import numpy as np

def stringify_dtype(dtype: np.generic) -> str:
    return dtype.__name__

stringify_dtype(np.float64)  # <--- causes error on x64 architectures

The above example, run against mypy on a 64-bit architecture, results in the following error:
Argument 1 to "stringify_dtype" has incompatible type "type[floating[Any]]"; expected "generic"  [arg-type]

A very similar issue occurs when using builtins, which are technically allowed as ndarray dtypes, but will also cause an error:
import numpy as np
from numdantic import NDArray, Shape

x: NDArray[Shape[int, int], float]  # <--- causes an error in type checkers

The error is similar:
Type argument "float" of "NDArray" must be a subtype of "generic"  [type-var]
Incompatible types in assignment (expression has type "ndarray[Any, dtype[signedinteger[_32Bit]]]", variable has type "ndarray[tuple[int, int], dtype[float]]")  [assignment]

Potentially one could get around the problem by writing a custom type that includes type[floating[Any]] etc. plus built-ins and then just ignore the fact that np.ndarray is typed in a way that will not allow this type (since it only accepts np.generic as dtype - which these apparently aren't).

Regarding the built-in types: https://github.com/numpy/numpy/issues/23663
np.float_ is a subtype of float, so there is a relation, it's just "upside-down" with numpy generics being subtypes of the built-in, not the other way around.

Seeing as how #6 was seemingly a sleep-deprived mistake on my end, this issue is now mostly related to using built-in types in NDArray types. Will update title accordingly, and will later update the description as well.
See comment in #6.


Update SnippetConcept.md

@BoyaWu10 Let me know if I should revise anything else! If it looks ready, please merge it. Thank you!

@BoyaWu10 Let me know if I should revise anything else! If it looks ready, please merge it. Thank you!

Thanks Gina! The document looks good to me and Qiwei has helped to merge it.


add wfg pareto front

the pareto front generating methods are previously commented out
also added lexicographical sort so that it can be drawn as line by
pyplot for 2-objective
but the visualization is a bit odd at the right end of the 2-D pareto fronts

Thanks for the contribution. Does this generalize to ND too?
(can't remember why I commented it out to be honest)

Hey, I just saw your reply. Yes.
I now know why the 2D visualization is off (a "wide" gap between points). It's because of the random generation of the PF. Even if I set the size of the PF to 1000, the gap is still visible. However, I haven't really check its effect on the IGD or HV calculation. What do you think?


Ntfy Notification doesn't  set action link

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
When using the ntfy notification, uptime-kuma create an action button to go to the uptime-kuma page on the ntfy notification but the actual link is not completed. The main URL is setup on uptime-kuma
👟 Reproduction steps
Create an ntfy notification
Receive a down or up notification
Click on the action button on ntfy
See the result
👀 Expected behavior
the action button take you to the uptime-kuma page
😓 Actual Behavior
the action button take you to a about:blank page

🐻 Uptime-Kuma Version
1.22.0-beta.0
💻 Operating System and Arch
Fly.io
🌐 Browser
Not browser related
🐋 Docker Version
Fly.io
🟩 NodeJS Version
No response
📝 Relevant log output
No response

Relavant Code:
https://github.com/louislam/uptime-kuma/blob/master/server/notification-providers/ntfy.js#L58

This seems to happen for those cases where no URL is available, e.g. when monitoring a docker container. Could this also be the issue in your case @cfouche3005 ?

Yes, I can confirm (when I create an http monitor, the button on the notification redirect me to the monitored website), I was thinking that the button redirected to the probe on uptime-kuma, not the monitored website (but it make sense)

This seems to happen for those cases where no URL is available

@cfouche3005
What is the expected case and what is currently implemented?
Is this resolved?
I am confused

@CommanderStorm Sorry if it wasn't clear (English is not my first language), the issue is just a "normal" behavior : Uptime-Kuma set the action button web link with the monitored website but for Groups (or docker container), witch doesn't have a web link, it just set a blank link. The rest of the issue was just a misunderstanding of the actual behavior.
This issue might be a non issue.

Actually in case there is no URL, I think it should either set the field to something meaningful (e.g. the URL of the monitor) or not enable the button at all. Setting the button to an empty action is just confusing and not helpful to a user.


Incorrect DelimitedRecordWriter column ordering

The order of columns in the header is incorrect when header is written through the WriteColumnHeaders method with includeDataType set to false.  Here is a quick test:
using (var writer = new DelimitedRecordWriter(new StreamWriter("c:\\temp\\header_test.txt", false))) {
    writer.Columns.Add(new DelimitedRecordColumn("A"));
    writer.Columns.Add(new DelimitedRecordColumn("B"));
    writer.Columns.Add(new DelimitedRecordColumn("C"));
    writer.Columns.Add(new DelimitedRecordColumn("D"));
    writer.WriteColumnHeaders(false);
}

The expected behaviour is the column header would appear as "A","B","C","D".  Please note that the method behaves as expected when includeDataType is set to true.

Thank you for the detailed bug report, I pushed an update to nuget.


Fallback to no syntax hightlighting without warning.

Related to #3065
Fixes:
iris/docs/iris/src/developers_guide/gitwash/development_workflow.rst:317: WARNING: Could not lex literal_block as "python". Highlighting skipped.
Reference:
http://www.sphinx-doc.org/en/stable/config.html#confval-highlight_language

Well found! 👍


Solution to project euler problem 1

Signed-off-by: Steven Budinata<EMAIL_ADDRESS>I added solution to project euler problem 1: "Multiples of 3 and 5"
I also edited the Readme so it contains the problem's content

Hi, can you add the solution in the README.md as well ? look at the other solutions.
the README is rendered on the website like this: https://satyajitghana.github.io/project-euler/problem-018/

I have updated the readme, thank you :smile:

Looks good, thanks, if you can explain the solution in the README that would be great ! i've actually forgot to do documentation in many of the codes, feel free to do so.
i'm accepting this PR now. but you can do make more PRs !


Cscape interface improvements

Reduced ResultSet load times from ~2:10 mins to ~27 seconds for a 20 scenario dataset.
Note, improvements will be more noticeable if more each C~Scape dataset holds more than a single scenario.
Achieved by:

A "smarter" indexing strategy used to read C~Scape results into a common data structure
Precalculates the indices for the scenarios in each dataset to avoid if branching in the loop
avoiding loading/calculating data where results are all zeros,
reading in data into memory prior to any calculations

I've also organized the function definitions so that methods with the same names are together in the file, as per style guide.
I also applied the formatter so it passes the format check we now have in place.

Whoops, @DanTanAtAims I neglected to update the docstring detailing the expected directory structure for the C~Scape datasets.
Can't do it today but please hold off any approvals until that is done.

@DanTanAtAims I've added a link to the section to the docs which explains the expected directory structure.
I expect this should work but we'll see.


can you help me set up the CI for this Repo.

Hello Thomas,
During the last two days I tried to teach myself about VSTS Extensions and also about this wonderful project (nsis-extension). I tried to create a development environment to test your codes, So I installed Visual studio Code and  powershell plugin for it. I tried to figure out how to run it and I installed Microsoft/vsts-task-lib.  and I believe -if i'm not mistaken- you used this library in the nsis.ps1 file before vsts-task-lib change its functions (e.g. renaming invoke-tool to invoke-vststool for example).
I would like to know how to set up the CI for this Repo if I want to help you maintaining it. Also, what about the changes I mad to the nsis.p1 will it work?
Thanks.

Please use this forked repo: https://github.com/dev-maxima/nsis-extension This repo is no longer active
The new version is here: https://marketplace.visualstudio.com/items?itemName=bizeta.nsis-task
Please post your issue there


Add option to enforce identical app name in pings

Always reject pings from wrong app name

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Oh, I just saw ringpop-common#97. Can you add the integration test to that one and temporary change the branch name in run-shared-integration-tests:9 temporary until ringpop-common#97 is merged

this lgtm

Given we already have a test in ringpop-node, the test in ringpop-common will be added at a later time.


refactor(core): update with-routes to handle redirect logic better

What/Why?
Merging 3rd party code from #1429 (PR was created to run CI)
Testing
See CI

@chanceaclark
I've run this twice, both on the latest changes of my forked repo and our >2months old fork that we have been building off of
In both cases I get this:

on all redirects
https://github.com/bigcommerce/catalyst/pull/1429#discussion_r1793476393
/uplift-v2-standing-desk-v2-or-v2-commercial/
/uplift-v2-l-shaped-standing-desk/
/uplift-v2-standing-desk-frame/
/height-adjustable-standing-desk-with-l-shaped-top/
All redirects exhibit the exact same behavior as before, except now the 404 is an infinite redirect loop
[
@bigcommerce/catalyst-core:dev:   {
@bigcommerce/catalyst-core:dev:     "route": {
@bigcommerce/catalyst-core:dev:       "redirect": {
@bigcommerce/catalyst-core:dev:         "to": {
@bigcommerce/catalyst-core:dev:           "__typename": "ProductRedirect",
@bigcommerce/catalyst-core:dev:           "path": "/uplift-v2-l-shaped-standing-desk/"
@bigcommerce/catalyst-core:dev:         },
@bigcommerce/catalyst-core:dev:         "toUrl": "https://www.upliftdesk.com/uplift-v2-l-shaped-standing-desk/"
@bigcommerce/catalyst-core:dev:       },
@bigcommerce/catalyst-core:dev:       "node": {
@bigcommerce/catalyst-core:dev:         "__typename": "Product",
@bigcommerce/catalyst-core:dev:         "id": "UHJvZHVjdDo4NTk=",
@bigcommerce/catalyst-core:dev:         "entityId": 859
@bigcommerce/catalyst-core:dev:       }
@bigcommerce/catalyst-core:dev:     },
@bigcommerce/catalyst-core:dev:     "expiryTime":<PHONE_NUMBER>395
@bigcommerce/catalyst-core:dev:   },
@bigcommerce/catalyst-core:dev:   {
@bigcommerce/catalyst-core:dev:     "status": "LAUNCHED",
@bigcommerce/catalyst-core:dev:     "expiryTime":<PHONE_NUMBER>939
@bigcommerce/catalyst-core:dev:   }
@bigcommerce/catalyst-core:dev: ]
Frustratingly, this actually is lending a lot of credence to the theory that the actual root cause is route.node.id ending in "="
Please see link to previous PR comments with my redirect console logging to confirm, but each one ends in "="


Add test coverage to opts

This is the time for opts to get covered 🐸.
There is a few FIXME in this one :

ValidatePath(":/test") is valid, although it will fail after I think
 func ValidateEnv(val string) (string, error) always returns nil for error. I guess it's for coherence of returns with the other validate method, so I think I can remove my FIXME comment.
There is FIXMEs for ListOpts.GetAll() and ListOpts.GetMap asking if we can remove it. They are used in runconfig/parse.go ; GetMap could/should probably have another name but..

# before
+ go test -test.timeout=30m github.com/docker/docker/opts
PASS
coverage: 33.8% of statements
#after
+ go test -test.timeout=30m github.com/docker/docker/opts
PASS
coverage: 92.8% of statements

Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

Ok, so I've updated the envfile end env validation.

For envfile, it will fail if there is spaces even without =, a file like this would fail :
some spaces

Almost the same for env (and now there is a case it returns an error :stuck_out_tongue_closed_eyes: ), it's no more possible to do something like : docker run -e "some spaces" ….

For the sake of it, I wasn't sure if it was possible to define a environment variable with spaces, so I tried (with bash and zsh) :
$ export SOME\ SPACES=value
bash: export: `SOME SPACES=value': not a valid identifier
$ export "SOME SPACES"=value
bash: export: `SOME SPACES=value': not a valid identifier

:relaxed:

yep - that's what I got in my testing as well.  thanks!!

LABEL call just stole code from ENV.  It should follow the same standard of whatever ENV allows, I believe.

Rebased to master and move a test from https://github.com/docker/docker/pull/13879 in ip_test.go.

Any more thoughts one that ? :blush:

Janky is not gonna build it today :smile_cat:.
@duglin did the regexp stuff (I've put it in the envfile.go because it seemed like the right spot, but I saw later a bunch of regexp were in opts.go so I'm wondering it that was the right move or not).

Tests are green!
@duglin @calavera @LK4D4 @rhatdan PTAL

Updated and rebased with the changes introduced by https://github.com/docker/docker/pull/14321.

LGTM
ping @duglin

@duglin I've put both commit on this. Tell me if you'ld prefer that I squash it to one commit or not :wink:.

Just one question/comment! Looking good!

@duglin I think it's done.. I'm not found of the move I made of rwMode and roMode. WDYT ? :sweat_smile:

@vdemeester yea, lets keep that code into volumes.go and just externalize validateMountMode() instead of moving it all into opt.go. To me, volumes (sort of) owns all that logic and the opts stuff is more like a user of it.

@duglin The problem is there seems to be a cycle loop of import (if I import daemon in the package opts) . I'm gonna move it into github.com/docker/docker/volume.

@duglin quick update :

Moved ValidateMountMode to github.com/docker/docker/volume.
Fixed few tests (runconfig, etc..), e.g. that would failed because they were considered rwz that would be later rejected as not supported.
Added a bunch of godoc :wink:.

@duglin Another update :sweat_smile:.
I've added a ValidateDevice function that will do the same as ValidatePath but without validating the mount mode (https://github.com/docker/docker/pull/13694/files#diff-def63b7f78492fa1f0dc4e219a650df4R229). It should fix the DockerSuite.TestDevicePermissions integration test.

@vdemeester thanks for the hard work!
LGTM
ping @LK4D4 you still ok with this?

LGTM

:tada: thanks!!

:tada: :blush:
@duglin thanks for all the reviews !

Added impact labels, because the validation-rules for environment variables changed in this PR (see https://github.com/docker/docker/pull/14727)


console.log view of the simulator is gone

Maybe has something to do with the breadboard stuff?

Fixed by https://github.com/Microsoft/pxt/commit/c56541d09dc73cf9b81714b364b0a1e4fdb69785


Extend rossystem metamodel and Xtext to support ComponentsStacks

The changes added here correspond to a prototype for a new version of the rossystem metamodel to support the definition of groups (or stacks) of components.
These groups are defined by an identifier name (mandatory attribute) , the list of the components that compose it  (from 0 to infinite) and a list of quality attributes (optional , from 0 to infinite). The quality attributes have 3 mandatory fields: name, type and value, where the type correspond to the ROS supported primitives for parameters (see https://github.com/ipa320/ros-model/blob/master/docu/Parameters.md for further information). The following capture shows a capture of the ecore model:

The rest of the attributes that defined a RosSystem where not modified, this means all the previous  rossystem models are supported by this metamodel version.
This PR introduce only the changes to the ecore metamodel and its derived java classes and the update of the Xtext grammar, but the validator of the DSL and the code generators where not changed, if the new model is valid, al least the launch file generator will require some modifications.
See the following example of a new rossystem model:
RosSystem { Name 'MyAwesomeSystem'
	RosComponentStacks (
		ComponentStack {
			name graph_object
			RosComponents (
				ComponentInterface { name 'arm_driver'},
				ComponentInterface { name 'moveit' })
			QualityAttributes (
				QualityAttribute qa_grasp type Integer value 1
			)
		},
		ComponentStack {
			name navigation
			RosComponents (
				ComponentInterface { name 'base_driver' },
				ComponentInterface { name 'move_base' })
			QualityAttributes (
				QualityAttribute qa_safe type Double value 1.5
			)
		}
	)
}

(copy-paste) from: https://github.com/ipa320/ros-model/pull/116

Do we create a package for each ComponentStack?
There are two ways to create a docker image for a ComponentStack:

We add all packages into a docker image, like we have now for a Rossystem. To start each ComponentStack, we can do:

define start command (roslaunch) in docker compose file, using a same docker image
define start command in dockerfiles, so we will have docker images

If we create a package for each ComponentStack, we can add packages only for this ComponentStack into docker image

@ipa-rwu please review:

give me your opinion about the changes from https://github.com/ipa320/ros-model/pull/152/commits/b0e58dd0bbe284479c164d2f01f19b401f07ad27 and specially from https://github.com/ipa320/ros-model/pull/152/commits/15ba3f85eb740796bda8718854a8433d0301e497 (I think there were some errors on the amount of files to be generated)
stress test all the changes together, I made just a very simple example. I think you have more complex rossystem files to test the generators.

If the changes are ok to you, let me know and I will clean the history.
Thanks! 😃


Support Wercker private projects

Turns out both methods don't work with private projects. Wercker makes available their own badge using this API that we should probably use
$ curl https://app.wercker.com/status/248faefe7474c5f7ff299c53f5a79f5e

With badge available at: https://app.wercker.com/status/248faefe7474c5f7ff299c53f5a79f5e/m

Thanks for the suggestion!
How easy is it for users to find the 248faefe7474c5f7ff299c53f5a79f5e bit?

URL bar

Actually. It is in the share page

I'll need to add this image to the documentation (we have a brand-new documentation system for the front page: https://github.com/badges/shields/commit/0536763b498b865e65db31243512356e7bcd2295#diff-20b51e3176fb8c62d5ce21aee43e6cd1R1029).
However, the front page already has a lot of image downloads. I'll consider this issue to depend on https://github.com/badges/shields/issues/633.

Oracle shut down Wercker on 31 October so this is no longer relevant


feat: add array operators

More info here: https://github.com/nestjsx/crud/pull/754

@afilp  unfortunately tests are failing with this change. I spend some time trying to figure out what causes it, but it's not obvious at all.
I don't have time in the next few days to figure it out, so it will have to wait until I have time...

Sure!
I just copied/pasted the old code from that PR:
https://github.com/nestjsx/crud/pull/754
So, that you can have a start. Most likely that old code would fail somewhere.

@afilp this is merged and released as 5.3.1 .

@afilp Does it work eventually? Without any changes?

@afilp  I don't understand do you mean?
Install v5.3.1 and check if it's working. I fixed the tests, but I didn't have time to test the two new array operators. The branch is actually meged, but I closed the PR, because it was way more work to merge it trough the PR.
As for the changes, I had to make a trivial change because of small refractor that this PR is doing.


libjcat: 0.2.1 -> 0.2.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/hughsie/libjcat/releases.
meta.description for libjcat is: Library for reading and writing Jcat files
meta.homepage for libjcat is: https://github.com/hughsie/libjcat
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.2.2 with grep in /nix/store/j57wdjdvydrc3a6kyz6bxl77d0p1hasy-libjcat-0.2.2-bin
found 0.2.2 in filename of file in /nix/store/j57wdjdvydrc3a6kyz6bxl77d0p1hasy-libjcat-0.2.2-bin

Rebuild report (if merged into master) (click to expand)

23 total rebuild path(s)

23 package rebuild(s)

First fifty rebuilds by attrpath

fwupd
gnome-firmware
gnome-software
gnome.gnome-software
kdePackages.discover
libjcat
libsForQt5.discover
libsForQt5.kinfocenter
pantheon.elementary-greeter
pantheon.elementary-onboarding
pantheon.elementary-settings-daemon
pantheon.switchboard-plug-about
pantheon.switchboard-plug-pantheon-shell
pantheon.switchboard-plug-power
pantheon.switchboard-plug-security-privacy
pantheon.switchboard-with-plugs
pantheon.wingpanel-applications-menu
pantheon.wingpanel-indicator-power
pantheon.wingpanel-quick-settings
pantheon.wingpanel-with-indicators
plasma5Packages.discover
plasma5Packages.kinfocenter

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/j57wdjdvydrc3a6kyz6bxl77d0p1hasy-libjcat-0.2.2-bin \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libjcat https://github.com/r-ryantm/nixpkgs/archive/797ff48ef55efc010647e017105e302ea83cb82d.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/797ff48ef55efc010647e017105e302ea83cb82d#libjcat

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/j57wdjdvydrc3a6kyz6bxl77d0p1hasy-libjcat-0.2.2-bin
ls -la /nix/store/j57wdjdvydrc3a6kyz6bxl77d0p1hasy-libjcat-0.2.2-bin/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 33 packages built:

fwupd
fwupd.debug
fwupd.dev
fwupd.devdoc
fwupd.installedTests
fwupd.lib
fwupd.man
gnome-firmware
gnome-software
kdePackages.discover
kdePackages.discover.debug
kdePackages.discover.dev
kdePackages.discover.devtools
libjcat
libjcat.bin
libjcat.dev
libjcat.devdoc
libjcat.installedTests
libjcat.man
libsForQt5.discover
libsForQt5.kinfocenter
pantheon.elementary-greeter
pantheon.elementary-onboarding
pantheon.elementary-settings-daemon
pantheon.switchboard-plug-about
pantheon.switchboard-plug-pantheon-shell
pantheon.switchboard-plug-power
pantheon.switchboard-plug-security-privacy
pantheon.switchboard-with-plugs
pantheon.wingpanel-applications-menu
pantheon.wingpanel-indicator-power
pantheon.wingpanel-quick-settings
pantheon.wingpanel-with-indicators

Maintainer pings

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 348555 run on x86_64-darwin 1

6 packages built:

libjcat
libjcat.bin
libjcat.dev
libjcat.devdoc
libjcat.installedTests
libjcat.man

Result of nixpkgs-review pr 348555 run on x86_64-linux 1

33 packages built:

fwupd
fwupd.debug
fwupd.dev
fwupd.devdoc
fwupd.installedTests
fwupd.lib
fwupd.man
gnome-firmware
gnome-software
kdePackages.discover
kdePackages.discover.debug
kdePackages.discover.dev
kdePackages.discover.devtools
libjcat
libjcat.bin
libjcat.dev
libjcat.devdoc
libjcat.installedTests
libjcat.man
libsForQt5.discover (plasma5Packages.discover)
libsForQt5.kinfocenter (plasma5Packages.kinfocenter)
pantheon.elementary-greeter
pantheon.elementary-onboarding
pantheon.elementary-settings-daemon
pantheon.switchboard-plug-about
pantheon.switchboard-plug-pantheon-shell
pantheon.switchboard-plug-power
pantheon.switchboard-plug-security-privacy
pantheon.switchboard-with-plugs
pantheon.wingpanel-applications-menu
pantheon.wingpanel-indicator-power
pantheon.wingpanel-quick-settings
pantheon.wingpanel-with-indicators


Update 05-child-workflows.md

Fix typo
s/activities/child workflows/

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[#23 #22] Allow a logfile mode and logfile date-naming

Two features we've modded into https://github.com/facebook/osquery.git:

Write logs that may have sensitive content in warnings/errors as o600 instead of o644.
Write/append to a logfilename using the date as a suffix. If folks are pulling these files into an elk-stack or splunk, having a by-date file name from the project is a nicety!

It would be great to have 1. in maintain so we can build a safe glog dependency in FreeBSD, where we construct our build hosts with ports. 2. is more of a like-to-have-- so I'm interested in other's thoughts.

Yo @googlebot, I signed it!

I'd recommend splitting off the date-naming change to its own pull request, and making this pull requests only about the permission?


SLEIGH docs do not indicate that that only 1 register space is allowed.

If 2 register spaces are defined in the SLEIGH definition for an ISA, it will compile to .sla perfectly well, but on loading a project using the ISA, Ghidra will produce an error.
after searching the code base, the following can be found in DefaultAddressSpace:
else if (space.getType() == AddressSpace.TYPE_REGISTER) {
	if (registerSpace != null || !space.getName().equalsIgnoreCase("register")) {
		// Ghidra address encoding only handles a single register space
		throw new IllegalArgumentException(
			"Ghidra can only support a single Register space named 'register'");
		}
	registerSpace = space;
}

However, the documentation for SLEIGH makes no indication of this. Is that because the register space limit of 1 is planned to be changed, or is this the permanent state of Ghidra? If there are no plans to change this limit, it might be wise to add some sort of warning like the ones in other parts of the documentation.
In addition, it might also be worth changing the error, as it makes it sound like Ghidra would have no issue with handling multiple register spaces if it werent for the hardcoded name.

The sleigh "register" space is intended to represent internal registers to a processor which have no specific offset defined by the processor architecture.  Registers can be placed within this space at any offset which suits your needs.  If the processor architecture defines an addressable space containing registers, that space should be defined as a ram space with appropriate dimensions (e.g., size, wordsize).

Understood, my bigger issue is more with the lack of documentation in SLEIGH and the bad error information when this failure is encountered.


SliceIndex query ContainsAll not working

Hello,
Recently I found an issue with querying using the ContainsAll criteria.
Using the unit tests provided in index_test.go I was able to confirm this by adjusting theTestSliceIndexWithPointers to the following.
I updated the tests in 2 ways, first to not use Categories []*string but instead to Categories []string instead. Secondly, I updated the store.Find ContainsAll call to include both {cat1, cat2} (multiple items to search for, not just one). The test looks as follows and fails when it should succeed:
`
func TestSliceIndexWithPointers(t *testing.T) {
type Event struct {
	Id         uint64
	Type       string    boltholdIndex:"Type"
	Categories []string boltholdSliceIndex:"Categories"
}

testWrap(t, func(store *bh.Store, t *testing.T) {
	cat1 := "Cat 1"
	cat2 := "Cat 2"
	cat3 := "Cat 3"

	e1 := &Event{Id: 1, Type: "Type1", Categories: []string{cat1, cat2}}
	e2 := &Event{Id: 2, Type: "Type1", Categories: []string{cat3}}

	ok(t, store.Insert(e1.Id, e1))
	ok(t, store.Insert(e2.Id, e2))

	var es []*Event
	query := bh.Where("Categories").ContainsAll(cat1, cat2).Index("Categories")
	ok(t, store.Find(&es, query))
	equals(t, 1,len(es))
})

}
`
The test expects the variable in e1 to be returned, but it is not found when run with an index.
Remove the .Index("Categories") qualifier and it succeeds.
`
func TestSliceIndexWithPointers(t *testing.T) {
type Event struct {
	Id         uint64
	Type       string    boltholdIndex:"Type"
	Categories []string boltholdSliceIndex:"Categories"
}

testWrap(t, func(store *bh.Store, t *testing.T) {
	cat1 := "Cat 1"
	cat2 := "Cat 2"
	cat3 := "Cat 3"

	e1 := &Event{Id: 1, Type: "Type1", Categories: []string{cat1, cat2}}
	e2 := &Event{Id: 2, Type: "Type1", Categories: []string{cat3}}

	ok(t, store.Insert(e1.Id, e1))
	ok(t, store.Insert(e2.Id, e2))

	var es []*Event
	query := bh.Where("Categories").ContainsAll(cat1, cat2)
	ok(t, store.Find(&es, query))
	equals(t, 1,len(es))
})

}
`

Thanks for the detailed issue and test repro.  I'll take a look.

Absolutely. Sorry about the formatting issues! You may need to add back in the ` backticks in the event structs.

I edited your comment to fix the formatting, FYI.

Ok, there is definitely a logical inconsistency here with ContainsAll.
The slice indexes store the slice values individually, but ContainsAll needs to compare them as a group.
I just need to figure out the best way to handle it.
The easiest option is to simply ignore the Index request in the query, like I do for "MatchFunc"queries where any value (like those not in the index) can be matched against, but that may not be the most performant.

Thanks for confirming there is an issue there. I came to the same conclusion, ignore the index request and all is still working. Thank you

Master branch should work for you now.


support CollectionGroup Query

Overview
solve https://github.com/atn832/cloud_firestore_mocks/issues/107
support CollectionGroup Query
Review Points

add isCollectionGroup flag on MockCollectionReference in imitaion of Firestore offical plugin implementation

Especially, I would you to review 2 points.

getSubpath() returns all paths which contain "collectionId"
In getDocuments(), Solving Path of DocumentReference is executed

@atn832 I would like you to review this. regards,

Yes, I'll take a look this weekend!

Thank you for implementing the support for collectionGroups @sensuikan1973! I just published your PR at https://pub.dev/packages/cloud_firestore_mocks/changelog#047.


Disable caching for Terms Filter (Nest 1.7.1)

Hi there,
According to https://www.elastic.co/guide/en/elasticsearch/reference/1.7/query-dsl-terms-filter.html, you can disable caching for Terms filter query.
I am right assuming that they are not cache control at the moment with Nest fluent interfaces on "Term" and "Terms" filter queries?
Here is my terms filter:
filterDescriptor.Terms("documentId", documentIds.Select(x => x.ToString()), TermsExecution.Plain)
Thanks,

The FilterDescriptor does not expose a .Terms(f=>f) where f is a Func<TermsFilterDescriptor, ITermsFilter>. It only has short version overloads.
See also:
https://github.com/elastic/elasticsearch-net/blob/develop/src/Nest/DSL/Filter/FilterDescriptor.cs#L767
The QueryDescriptor does have this:
https://github.com/elastic/elasticsearch-net/blob/develop/src/Nest/DSL/Query/QueryDescriptor.cs#L156
In 2.0 this all normalized. But we should definitely expose this in the first 1.7.x NEST bug fix release.

Ok on second inspection it seems i was confused back in November.
You can use f=>f.Cache(false).Terms() in 1.x
Sorry we left this ticket open for so long


[Bug] [Entrance]HDFSCacheLogWriter getOutPutStream NPE

Search before asking

[X] I searched the issues and found no similar issues.

Linkis Component
linkis-cg-entrance
What happened + What you expected to happen
There is an NPE problem in HDFSCacheLogWriter getOutputStream, and it does not judge whether the fileSystem is Null
HDFSCacheLogWriter getOutputStream存在NPE问题，没有判断fileSystem是否为Null
def getOutputStream: OutputStream = {
    if (null == outputStream) OUT_LOCKER.synchronized {
      if (null == outputStream) {

        outputStream = fileSystem.write(new FsPath(logPath), false)
      }
    }
    outputStream
  }

You should make a short judgment when writeToFile is called, and give a Warn-level log

Relevent platform
all
Reproduction script
no
Anything else
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

I want to fix this issue. Please assign to me.

I want to fix this issue. Please assign to me.

ok


Streamline dictionary update process for morphodict

Ensure documentation and process to update dictionary entries is both available and that it is consistent with the implementation

Step 1 is documentation, being handled in https://github.com/UAlbertaALTLab/crk-db/pull/110
A draft of the process to discuss next week is here:
https://github.com/fbanados/crk-db/blob/update-db-docs/db-update.md


Ability to scroll response/result body and save it to file.

I haven't found binding to scroll results window or ability to save response to the output file.

Ah, okay, I have to Shift+Tab first before Ctrl+Arrow works. Perhaps it would make more sense to use Shift instead of Ctrl? Since Shift+Tab shifts tabs on result so users can logically assume Shift+Whatever works on results.

Am thinking the main problem, for me at least, is not knowing to which window are shortcuts related to. Some kind of highlight would help immensely.

Great. Looking forward to it.


Hub data / OnEnd issues

TombEngine version
v1.4
Tomb Editor version
v1.7.1
Describe the bug
Originally posted here:
https://github.com/MontyTRC89/Tomb-Editor/issues/890
Nickelony asked me to post it here.
Hello!
I’ve made some tests with GameVars variables value to understand that how OnEnd works exactly.
I’ve got numerous awful test results…
ENDREASON TEST
Test1.lua:

GameVars.testVar value set in an OnLoop moment. (Moment is defined as „a” value, based on a = a + 1 loop operation.)
Another GameVars.testVar value set in OnEnd, also using TEN.Logic.EndReason constants (if… then) to change OnLoop variable value.

Test2.lua:

ShowString (in loop callback) to print GameVars.testVar value.

Title.lua:

ShowString (in loop „ControlPhase” callback) to print GameVars.testVar value.

Tested situations, on Test1:
Finish trigger to Test2
Savegame load to Test2
Finish trigger to title
From Pause menu to title
Lara’s death to title
Results:

EndReason.LEVELCOMPLETE: After Finish trigger, Test1 OnEnd value is printed in Test2. (Passed.)
EndReason.LOADGAME: After Finish trigger, Test1 OnLoop value is printed in Test2. (Passed.) Now I save SaveX. Then Finish of Test2 loads back to Test 1. Now I load Save X, back to Test2, still Test1 OnLoop value is printed. (If I understand LOADGAME exactly, then it is a failed test then. I mean, under any other circumstances, it seems logical that the saved Test1 OnLoop value is loaded – except now, Test1 OnEnd value should be printed. Which means if LOADGAME would work well, then I shouldn’t run OnEnd without an EndReason constant, otherwise I may ruin saved values unintentionally.)
Maybe it also connected to HUB DATA TEST (see below).
EndReason.EXITTOTITLE: After Finish trigger/Pause menu, there is no value printed in title. Log says: „[error] Could not execute function: ../../Scripts\Levels\title.lua:21: attempt to call a nil value (global 'toString')” (Failed.)
EndReason.DEATH: After Lara’s death and loading title, there is no value printed in title. Log says: „[error] Could not execute function: ../../Scripts\Levels\title.lua:21: attempt to call a nil value (global 'toString')” (Failed.)
EndReason.OTHER: it must be a custom value, I cannot get it now.

HUB DATA TEST
Test1.lua:

GameVars.testVar value set at a=1 OnLoop moment. (Moment is defined as „a” value, based on a = a + 1 loop operation.)
Another GameVars.testVar value set at a=100 OnLoop moment. (Moment is defined as „a” value, based on a = a + 1 loop operation.) 100 is random now.

Test2.lua:

ShowString (in loop callback) to print GameVars.testVar value.

Tested situation, from Test1:
Some moments after starting Test1 (so when a=100 value is just set) a Finish trigger loads to Test2. This a=100 value is printed now. (Passed.) Then a Finish of this level loads back to Test1. OnLoop a=1 moment changes the value. Very fast (so when the value is still at a=1 value) I load back to Test2, with the same Finish as before. I expect that a=1 value will be printed, but still a=100 value printed instead. (Failed.) (I tried with both Lara and Lara_Start_Pos, when loading back to Test1.)
Conclusion (I think):
You can't take over a GameVars variable value from Level A to Level B if Level B already has a value for that variable from a previous visit of Lara there. However, you can still change that variable value on Level B.
(And, as you see above, I can't take a GameVars variable value into the title, at all. Or, vice verse, anyway, from title to level.)
Maybe it is all connected to this issue:
https://github.com/MontyTRC89/Tomb-Editor/issues/855v
To Reproduce
"Describe the bug" - It is told there how I got the bug.
Expected Behaviour
"Describe the bug" - It is told there that what should happen.
Screenshots
This is mostly code. Screenshots don't really say anything.
Additional Content
No response
Minimal reproduction project
It is not a PRJ2 issue.
"Describe the bug" - as I said here, just type the different script entries (EndReason, GameVars, ShowString) in different level LUA's, that's all.

This issue was reported in less details in #1508 and now fixed.


The prop theme is marked as requried but it's value is 'undefined'

The top component is AppContainer, which yields the App component which build as a class. App component is wrapped with the MuiThemeProvider wrapper, which has one child - div element. In the console there is a warning "Warning: Failed prop type: The prop 'theme' is marked as required in 'MuiThemeProvideWrapper', but its value is 'undefined'."
I later get the error "Uncaught TypeError: Cannot read property 'prepareStyles' of undefined
at DatePicker.render" which seems to be related. According to the documentation there is no need to provide a theme as the Light Theme is used as default (http://www.material-ui.com/#/customization/themes & http://www.material-ui.com/#/get-started/usage). However, the problem persists also when I apply the Dark Theme according to instuctions on the Theme page.
I couldn't find any info about this warning.

[ x] I have searched the issues of this repository and believe that this is not a duplicate.

Steps to Reproduce (for bugs)
Here is a link to the app with the warnings and errors in the console:
Here is a link to my code: https://github.com/carpben/notifications/tree/master/src

npm install material-ui -S
in the top component import MuiThemeProvider.
3.render MuiThemeProvider with one child
Render a material Ui Component somewhere in your app.

Context

At the moment I can't use Material UI at all.
Your Environment

Tech
Version

Material-UI
0.22

React
16

browser
chrome

etc
Windows 10, create react app, redux, bash on ubuntu on windows

You are reading Material-UI v0.x documentation but using v1.x dependency: https://github.com/carpben/notifications/blob/7c917fd576d92dbfc75afd7a84d926e80d91cd4d/package.json#L7. It's not going to make it.

Sorry! I forgot to push to Github for a long time.  The version I have installed locally is 0.22. I just pushed to Github so you can see the correct version now: https://github.com/carpben/notifications/blob/master/package.json .
I originally installed Material Ui Next, but then decided that material Ui version 0.2 is more suitable for my project.

Strangely the error shows when I run it locally, but not when I run it from firebase server: https://next-f2cee.firebaseapp.com/ . When I run it there there is no warning or error, and it can also render the datepicker. Help on this topic will be greatly appreciated.

It seems to be some sort of caching, perhaps on the local npm server. Though I restarted the computer, and emptied caching on the browser.

Strangely now it works fine on my local server as well. I guess its some sort of caching. Perhaps with the local server coming with create-react-app. This doesn't seem to be an issue with Material-Ui. I'll close the issue now, though if someone knows how solve this it will be most appreciated.

I am getting this same error too.
 Warning: Failed prop type: The prop `theme` is marked as required in `MuiThemeProvider`, but its value is `u
I am not using MuiThemeProvider in this project at all
as I am using "material-ui": "1.0.0-beta.38" and it is optional.

@nharrisanalyst Do you have a reproduction example? It shouldn't behave this way.


Add editable caption to figure

Any plans to add figcaption to figure?
Maybe something like that this:

Some Text Here

With an icon, aside resize and remove icons, to change the caption value. Or just make it editable.

@orthes Does this work now? I would find it really useful!
Thanks


Dutch translation

Hi,
Here is the Dutch translation.
Great tool !
nl.zip

Thanks, i included it if you don't mind.


Login username is missing from account drop down menu when using local DB

UI v0.46.0

Name shows up, but not username, which is causing alignment issues in the dropdown.

The name might still be missing from the API response in some case, but the UI will display it not cut off like that now.

So the missing name is due to the API?

Verified fixed the UI alignment. Opened up #2130 to track the missing API.


Hide scrollbar on Linux chrome+firefox

Please check @stuartnelson3. I don't have OSX, works fine on Ubuntu+Chromium.

looks good :+1:


Error fix while generating aab file

https://github.com/microsoft/appcenter/pull/1629
My fix solves this issue, because gradle generates app-release.aab but during the build appcenter tries to find app.aab file which leads to error "No such file or directory"

I have same error in appcenter
##[warning]Directory '/Users/runner/runners/2.170.1/work/1/a/bundle' is empty. Nothing will be added to build artifact 'bundle'.
When will this fix be available?


Implement Check State Machine Uses

Implement the Check State Machine Uses algorithm for state machine semantics.

[x] Implement
[x] Test

Done in commit ec323c31a4365dafba5b8cbd3c6eb468e618753d.


readme is out dated

get account currency showed diffrent result
current readme
{
"account_name": "currency",
"eos_balance": "0.0000 EOS",
"staked_balance": "0.0001 EOS",
"unstaking_balance": "0.0000 EOS",
"last_unstaking_time": "2035-10-29T06:32:22",
...
}
but in latest version
{"account_name": "currency",
 "permissions": [{
      "perm_name": "active",
      "parent": "owner",
      "required_auth": {
        "threshold": 1,
        "keys": [{
            "key": "EOS6bhtfGKhuZ73Xfiyp3TR94cpTPXVGKssKTAH8Vjm6c82Gi4PRz",
            "weight": 1
          }
        ],
        "accounts": []
      }
    },{
      "perm_name": "owner",
      "parent": "",
      "required_auth": {
        "threshold": 1,
        "keys": [{
            "key": "EOS6pUEEqY3G2JtZj26Bo3Yww4L1HbT7mbyib8fk8nm3bGCgFFyUE",
            "weight": 1
          }
        ],
        "accounts": []
      }
    }
  ]
}

Yes, I still don't know how to get eos_balance for an account :)

The currency contract has been changed as of Dawn 3.0.  The more up-to-date example to use can be found in the wiki, https://github.com/EOSIO/eos/wiki/Tutorial-eosio-token-Contract
If you still want to try to get the eos_balance for what you were doing above, the attached file provides some instructions that should help.  This was originally includes in the Local Environment section in the wiki, just after the section on Creating and Launching a Single Node Testnet.  It was removed in deference to the eosio.token example.  It looks like you've already done the first set of steps.  You might be able to just skip down through the file to the part where it says to create, then issue the currency, (~line #125) and resume from there.
accounts_example.txt


feat(deploy-worker): Added deploy worker processor/action/operation #OONE-5

Added deploy worker task, processor to split task by node, per node deploy processor to split
actions, per action split operations framework.
拆分具体实现逻辑到不同的PR，不然一个PR太大了。

LGTM

LGTM

哥，你

就Approve一下吧~~~


ZONEMD verification failed: verify DNSKEY RRset with trust anchor failed

Not sure what really happened to my unbound instance after a recreation today.
Seems like the root.key disappeared and caused SERVFAIL. I download the root.hint and make it work again. And notice a warning message in log.
warning: auth zone .: ZONEMD verification failed: verify DNSKEY RRset with trust anchor failed
info: start of service (unbound 1.17.0).

The auth-zone.conf looks like this.
auth-zone:         name: "."         primary: <IP_ADDRESS>         # b.root-servers.net         primary: <IP_ADDRESS>          # c.root-servers.net         primary: <IP_ADDRESS>          # d.root-servers.net         primary: <IP_ADDRESS>          # f.root-servers.net         primary: <IP_ADDRESS>         # g.root-servers.net         primary: <IP_ADDRESS>         # k.root-servers.net         primary: <IP_ADDRESS>         # iad.xfr.dns.icann.org         primary: <IP_ADDRESS>         # lax.xfr.dns.icann.org         primary: 2001:500:200::b      # b.root-servers.net         primary: 2001:500:2::c        # c.root-servers.net         primary: 2001:500:2d::d       # d.root-servers.net         primary: 2001:500:2f::f       # f.root-servers.net         primary: 2001:500:12::d0d     # g.root-servers.net         primary: 2001:7fd::1          # k.root-servers.net         primary: 2620:0:2830:202::132 # iad.xfr.dns.icann.org         primary: 2620:0:2d0:202::132  # lax.xfr.dns.icann.org         #url: "https://www.internic.net/domain/root.zone"         fallback-enabled: yes         for-downstream: no         for-upstream: yes         zonemd-check: yes     zonemd-reject-absence: no         zonefile: "/usr/local/unbound/iana.d/root.zone"
The security.conf is also exactly as the example.
I notice the root.zone file is also missing under iana.d. I downloaded it manually. But the warning still there. Please help.

You need to update your root.zone as well, map a docker volume for the iana.d directory and place the file there.
iana.org

Thanks, mapping iana.d solves the issue.

I will implement an update mechanism for the zone files.

I'll take a look into that, may it is sufficient having the iana.d mapped but I'll check an update routine as well.

I've added the mapping to the example docker files


Store stats in DB + protect production + increase timeout

Indexing

Stats can now be stored in the DB or file system
Production is time protected against bulk indexing and will only start indexing after midnight and before 7:30am

time protection is managed by a schedule that is registered when a user requests a reindex

POST request timeout has been increased to 1 minute 30 seconds to allow large payloads on staging/production
New Options.php file created to minimise code-read confusion in other classes

@wilson1000-MoJ
Do you want me to review this now? As you mentioned in standup you may have a few more commits to push.


723 update doc

close #723
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[x] Code is formatted according to the tidyverse style guide
[x] Updated relevant unit tests or have written new unit tests - See Unit Test Guide
[x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[x] Update to all relevant roxygen headers and examples
[x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[x] Address any updates needed for vignettes and/or templates
[x] Update NEWS.md
[x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[x] Address or fix all lintr warnings and errors - lintr::lint_package()
[x] Run R CMD check locally and address all errors and warnings - devtools::check()
[x] Link the issue so that it closes after successful merging.
[x] Address all merge conflicts and resolve appropriately
[x] Pat yourself on the back for a job well done!  Much love to your accomplishment!

Nice Job Ojesh! I'm a little worried about this convert_blanks_na.Rd being an issue. Can you look into this more for us before it is merged in?

Thanks Ben! Per our conversation just a minute ago, we looked into the convert_blanks_na.Rd issue and decided to move forward as is.


add button for check-clang-version

https://github.com/ClangBuiltLinux/continuous-integration2/actions/workflows/clang-version.yml has been red but we didn't notice because it's not in the grid of buttons we check in the readme or homepage.  Probably doesn't need to be in the grid, but we should have an "indicator light" somewhere.

My bad:
clang hasn't been updated in 25 days!
I have some issues that I don't know how to fix:
https://github.com/llvm/llvm-project/issues/59097

My bad: clang hasn't been updated in 25 days!

To be fair, the reason for that is not entirely your fault :) TuxMake's images have been failing to build for three weeks now, which was before apt.llvm.org started failing:
https://gitlab.com/Linaro/tuxmake/-/issues/196

I fixed the issue on my side. we should be up to date now on all branches!


Remove Interrupt buttons and commands from Jupyter

"Run all" on a long notebook eg Titanic.ipynb
The interrupt button blinks on and off
This is actually contributed by Jupyter, and it looks like the when clause changed recently @joyceerhl

Filing this because @kieferrm mentioned it, we could leave the when clause alone (if that is causing the issue), but next month we have this button in vscode itself. See https://github.com/microsoft/vscode/issues/133776 also

The changes will be made in VS Code core.
Leaving this issue open so we remove the custom toolbar icons & commands.

This requires core changes so it's blocked.

@roblourens any update on when or even if the interrupt button will be added into core.
I coudln't find any issue that tracks that work in vscode repo. Probably there is and I couldn't find it.

That's https://github.com/microsoft/vscode/issues/133776 - from what I remember, the button is there but does not appear.

It looks like currently the Jupyter command is still used for the Interactive Window, and the builtin command is used for notebook editors, is there a reason for the @rebornix? Can the builtin command also be used for the IW?

@roblourens when removing the interrupt button for notebooks, I found that we have a different set of interrupt commands for IW, and their impl is slightly different, thus I leave them there. We should take some efforts to remove it.

easier repro to verify:

create an Interactive window
ensure there is no interrupt button in the toolbar while nothing is running
run some interruptable code

import time
for i in range(20):
    time.sleep(.5)
    print(i)

ensure interrupt button appears in the toolbar and can be used to interrupt execution


RELEASE: v.0.1.0-alpha.46

Coverage remained the same at 100.0% when pulling 9d00a0ca64a0c92266cab3cc882c25401e463a6d on dev into 94049f6ad1639210b75407163d980f890015f06d on next.


Save edited decision table

Add saving option.
Under the ctrl+s key combination there should be an action of saving the edited decision table to the file.

Use case

As a user I am opening a file containing a decision table in Unicode format.
Then I edit the content and press ctrl+s to save the changes.
All changes I made, should be saved in the originally opened file, because when I work with decision tables, in one terminal window I do edit the decision table and in the second terminal window I test/evaluate it using dsntk.
A backup file containing the original content should be created during the editing process. Since I am uncertain about the stability of the editor before its official production release, I want to ensure my original file is not lost.

Implementation proposal

Before opening the original file, make a backup copy named original_name + .bak extension.
Load the content of the file and allow editing. Original file must not be blocked during editing. It is done here: https://github.com/DecisionToolkit/dte/blob/cbd1fd408bf8608cce9a96f17bdb8870bd6bfab8/editor/src/main.rs#L28-L29
Add a new trigger for ctrl+s combination: https://github.com/DecisionToolkit/dte/blob/cbd1fd408bf8608cce9a96f17bdb8870bd6bfab8/editor/src/trigger.rs#L10-L14
Add a new trigger handler: https://github.com/DecisionToolkit/dte/blob/cbd1fd408bf8608cce9a96f17bdb8870bd6bfab8/editor/src/trigger.rs#L38-L45
Create a new action for saving the file: https://github.com/DecisionToolkit/dte/blob/cbd1fd408bf8608cce9a96f17bdb8870bd6bfab8/editor/src/editor.rs#L63-L67
In this action save the edited content to the original file. Edited content is available in the Controller: https://github.com/DecisionToolkit/dte/blob/cbd1fd408bf8608cce9a96f17bdb8870bd6bfab8/engine/src/controller.rs#L64-L68
The Row has function text() that returns a line of text. All rows may be joined with a new line, make sure the last new line is preserved in the text file and save the whole text in one operation to the original file.

Some Rust tips from ChatGPT 😀
Saving files
use std::fs::File;
use std::io::Write; // Import the Write trait

fn main() -> std::io::Result<()> {
    // Create or open the file
    let mut file = File::create("output.txt")?;

    // Write the text to the file
    file.write_all(b"Hello, Rust!")?;

    // Optional: Add a newline
    file.write_all(b"\n")?;

    // Return Ok if everything is fine
    Ok(())
}

Joining text slices
fn main() {
    let lines = vec!["Line 1", "Line 2", "Line 3"];
    let joined = lines.join("\n");
    println!("{}", joined);
}


Full screen loading video

A “Blank” video should be loaded first. Then the actual full video
"append" and displayed on screen 3. (table(Screen03)
The blank video will be found (T-ARC Blank Empty Loading)  and can be downloaded. If I the actual
Loading video or upload from file , there is no question about overwrite, append. and the first blank video
appears to be overwritten.
I just tried it with Theater of Magic, I'm attaching the client log.
Ps the import functions Backglass, Altsound, Table, rom worked very well
vpin-studio-ui.log

Yeah.  Since new update I cant seem to add more than one Loading video.  Also there should be an option to add a blank screen as well as add a second video and add it to the list on screen 3, just like popper does

It appears that when fixing the asset lookup and renaming, I forgot the "screen" named assets. Thanks for reporting. I'll fix this asap.

The update 2.11.3 should have fixed this issue. But I'll take a closer look again on the weekend since I hadn't much time to review everything an the the VPS database URL need to be released.

Retested and looks good to me.

hello,
yes - works very well for me. thx
gerhard

Von: syd711 @.>
Gesendet: Samstag, 10. Februar 2024 15:48
An: syd711/vpin-studio @.>
Cc: GerhardPK @.>; Author @.>
Betreff: Re: [syd711/vpin-studio] Full screen loading video (Issue #138)
Retested and looks good to me.
—
Reply to this email directly, view it on GitHubhttps://github.com/syd711/vpin-studio/issues/138#issuecomment-1937024252, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BE72QBSVLPMVQEKSHBOSBHDYS6CE7AVCNFSM6AAAAABCZDGACOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXGAZDIMRVGI.
You are receiving this because you authored the thread.Message ID: @.***>


util.extend: allow deprecation console log

Coverage decreased (-0.2%) to 80.564% when pulling eac1536b613bde67979e3c5c25b1e8f5e12ecb12 on silence-warning into d5b3c5c9b92a8d93ab0a94f10e5c07b93f2d5bf5 on master.


the msg bar doesn't expand until mouse over

Noty version: Jquery plugin 2.2.0
Browser: Chrome Version 71.0.3578.98
OS: Mac Yosemite 10.10.5
jsFiddle link (if available): .....

I am using Noty on a legacy jsp project, when the noty msg pop up. the msg bar shows as a line and doesn't expand until mouse hover. I suspect other css files causing this problem, however it is hard for me  to find which css file causing this problem because this project is very chaotic. css and js files are all over the place

Hi, you are using Dec 10, 2013 release. Use the latest version.


Add support for BC-TC-C-WM-2

Please add support for the older Max wallthermostat devices which are of type BC-TC-C-WM-2. Values retrievable should be same as for BC-TC-C-WM-4.

I'll take care of that. Should be done beore the next HASS is released.


Draft: workflow for creating issue report

An example of how to automate the discussion item for the developer meetings.
To trigger the workflow to create a discussion item, you would use the workflow_dispatch function:

The resulting discussion would look something like this: https://github.com/lenkan/keri/discussions/8
Imo, it looks a bit cluttered, it would probably be better if the summary for each repo would be posted as a comment instead of the initial discussion body. You can close this if you want, or suggest changes.
Potential changes:

Create dicsussion, but post the summary as a comment for each repo.
Move the script and workflow to separate repository
...

Nice work! I like it.

Nice! Would be good if it posts the summary per comment as you suggest; agree that it looks a bit cluttered.

Another note is it's actually nice to see all current open PRs as sometimes reviews can take a while. Or maybe all recent PRs and older PRs that are ready for review/not in draft.

Another note is it's actually nice to see all current open PRs as sometimes reviews can take a while. Or maybe all recent PRs and older PRs that are ready for review/not in draft.

Yes, could do something like:
## New PRs

- #XYZ Some new title

## Older PRs ready for review

- #XYZ Some title (X days old)
- #XYZ Some other title (Y days old)

## Merged PRs

- #XYZ Some new title

## New issues

...

Also, maybe a link to the workflow that created the discussion can be included in the top part.

I have updated the script to post comments instead. I haven't looked at the other suggestions of tweaking the filters, but that is easy to do and we can collect more feedback on that.
Here is a discussion created with the updated script: https://github.com/lenkan/keri/discussions/20


Fix crash on topic change due to invalid user's nickname

After running the code with commit 50e16b8624 (that introduced the ability
of using nicks), I've noticed in rare occasions we could face a crash on
topic/system_header change due to invalid nickname. I believe this is related
to other users clearing their nicks after the start of matterircd.
The way I've fixed that was to add some additional checks to system_header
change event, and then was able to run several weeks without crashes
(although the checks were triggered sometimes, preventing the NIL crash).
Notice the Warn was never reached though, but I kept that for safety!
Fixes: 50e16b8624 ["Add option to use Nickname instead of Username (#273)"]
Signed-off-by: Guilherme G. Piccoli<EMAIL_ADDRESS>

👍

Awesome, thanks for merging!


Add metrics level 3 arch diagram

Maybe point prometheusRules to prometheus instead of Alertmanager?
PrometheusRules may not only include alertingRules but also recordingRules all of which are handled by prometheus

Maybe point prometheusRules to prometheus instead of Alertmanager? PrometheusRules may not only include alertingRules but also recordingRules all of which are handled by prometheus

You are right! Nice catch! Fixed and PTAL. :smile:


Production Deployment - fix links, add playwright test, small updates.

PRs:

https://github.com/djangonaut-space/wagtail-indymeet/pull/213
https://github.com/djangonaut-space/wagtail-indymeet/pull/192
https://github.com/djangonaut-space/wagtail-indymeet/pull/218
https://github.com/djangonaut-space/wagtail-indymeet/pull/222
https://github.com/djangonaut-space/wagtail-indymeet/pull/211
https://github.com/djangonaut-space/wagtail-indymeet/pull/223

@sarahboyce I wouldn't bother waiting for an approval for this. If you're around to monitor that the release works, go for it.


Code for Compositional and Mixed Embedding Tricks

Does this DLRM repo have the code for the two papers mentioned in the README i.e compositional embeddings and mixed embeddings?
If yes, where is the code, and how to run DLRM with these tricks?

The relevant code is located in https://github.com/facebookresearch/dlrm/tree/main/tricks, while the flags to experiment with these tricks are --qr-flag, --md-flag and other associated flags here.

Closing.


fix: orgsessionid not being cleared out on manual timeout

Change ISessionStartParams to SesssionStartFlags

:tada: This PR is included in version 0.275.3 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


text_completion_dataset: RuntimeError: each element in list of batch should be of equal size

I have created an unstructured dataset using the text_completion_dataset:
dataset = text_completion_dataset(
        tokenizer,
        source="text",
        column="text",
        data_files="t8.shakespeare.txt",
        split="train",
        max_seq_len=seq_length,
        packed=False
    )
    return dataset

using the text file t8.shakespeare.txt
When I load it into a DataLoader with a batch_size > 1
dataloader = torch.utils.data.DataLoader(dataset, batch_size=8, num_workers=0, shuffle=False)

I get the error
Traceback (most recent call last):
  File "dataset.py", line 77, in <module>
    for batch in dataloader:
  File "/home/coder/.local/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 630, in __next__
    data = self._next_data()
  File "/home/coder/.local/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 673, in _next_data
    data = self._dataset_fetcher.fetch(index)  # may raise StopIteration
  File "/home/coder/.local/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 55, in fetch
    return self.collate_fn(data)
  File "/home/coder/.local/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 317, in default_collate
    return collate(batch, collate_fn_map=default_collate_fn_map)
  File "/home/coder/.local/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 155, in collate
    clone.update({key: collate([d[key] for d in batch], collate_fn_map=collate_fn_map) for key in elem})
  File "/home/coder/.local/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 155, in <dictcomp>
    clone.update({key: collate([d[key] for d in batch], collate_fn_map=collate_fn_map) for key in elem})
  File "/home/coder/.local/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 170, in collate
    raise RuntimeError('each element in list of batch should be of equal size')
RuntimeError: each element in list of batch should be of equal size

I supposed that using max_seq_len was truncating all the tokens to max_seq_len, while it seems that padding is missing.
I have then tried to use collate_fn:
dataloader = torch.utils.data.DataLoader(dataset, batch_size=8, num_workers=0, shuffle=False, collate_fn=lambda x: x)
print(dataloader)
    for batch in dataloader:
        for sample in batch:
            print(sample)
            print( len(sample['tokens']), tokenizer.decode(sample['tokens']) )

        break

this is the output
{'tokens': [128000, 2028, 374, 279, 220, 1041, 339, 469, 1342, 1052, 10666, 555, 5907, 52686, 11, 323, 128001], 'labels': [128000, 2028, 374, 279, 220, 1041, 339, 469, 1342, 1052, 10666, 555, 5907, 52686, 11, 323, 128001]}
17 This is the 100th Etext file presented by Project Gutenberg, and
{'tokens': [128000, 285, 10666, 304, 23915, 449, 4435, 11896, 11, 4953, 2637, 505, 872, 128001], 'labels': [128000, 285, 10666, 304, 23915, 449, 4435, 11896, 11, 4953, 2637, 505, 872, 128001]}
14 is presented in cooperation with World Library, Inc., from their
{'tokens': [128000, 17344, 315, 279, 12781, 323, 42482, 11325, 3442, 50, 13, 220, 5907, 52686, 128001], 'labels': [128000, 17344, 315, 279, 12781, 323, 42482, 11325, 3442, 50, 13, 220, 5907, 52686, 128001]}
15 Library of the Future and Shakespeare CDROMS.  Project Gutenberg
{'tokens': [128000, 61917, 19786, 469, 87042, 430, 527, 4276, 9277, 304, 279, 3142, 21749, 3001, 128001], 'labels': [128000, 61917, 19786, 469, 87042, 430, 527, 4276, 9277, 304, 279, 3142, 21749, 3001, 128001]}
15 often releases Etexts that are NOT placed in the Public Domain!!
{'tokens': [], 'labels': []}
0
{'tokens': [128000, 2059, 37971, 128001], 'labels': [128000, 2059, 37971, 128001]}
4 Shakespeare
{'tokens': [], 'labels': []}
0
{'tokens': [128000, 9, 2028, 469, 1342, 706, 3738, 7065, 25127, 499, 1288, 1373, 69322, 128001], 'labels': [128000, 9, 2028, 469, 1342, 706, 3738, 7065, 25127, 499, 1288, 1373, 69322, 128001]}
14 *This Etext has certain copyright implications you should read!*

While I do not get here the error anymore, the dataset samples have different sizes, so when loading in a real training it will not work.

Hey @loretoparisi. I think you might find our built-in collate function useful, which can be used across our datasets when loading them into a dataloder. Check out https://pytorch.org/torchtune/main/generated/torchtune.utils.padded_collate.html#torchtune.utils.padded_collate
dataloader = torch.utils.data.DataLoader(dataset, batch_size=8, num_workers=0, shuffle=False, collate_fn=torchtune.utils.padded_collate)

You can also see how it's used in our training recipes here.

@SalmanMohammadi thanks! I have added it
from torchtune.utils import padded_collate
dataloader = torch.utils.data.DataLoader(dataset, batch_size=8, num_workers=0, shuffle=False, collate_fn=padded_collate)
print(dataloader)
 for sample in dataloader:
        print(sample)
        print( len(sample['tokens']), tokenizer.decode(sample['tokens']) )
        break

but now when running tokenizer.decode I'm getting
Traceback (most recent call last):
  File "dataset.py", line 100, in <module>
    print( len(sample['tokens']), tokenizer.decode(sample['tokens']) )
  File "/home/coder/.local/lib/python3.8/site-packages/torchtune/models/llama3/_tokenizer.py", line 126, in decode
    return self.tt_model.decode(token_ids, truncate_at_eos=truncate_at_eos)
  File "/home/coder/.local/lib/python3.8/site-packages/torchtune/modules/tokenizers/_tiktoken.py", line 151, in decode
    k = token_ids.index(self.eos_id)
AttributeError: 'Tensor' object has no attribute 'index'

for the sample
<torch.utils.data.dataloader.DataLoader object at 0x7f314db98e50>
{'tokens': tensor([[128000,   2028,    374,    279,    220,   1041,    339,    469,   1342,
           1052,  10666,    555,   5907,  52686,     11,    323, 128001],
        [128000,    285,  10666,    304,  23915,    449,   4435,  11896,     11,
           4953,   2637,    505,    872, 128001,      0,      0,      0],
        [128000,  17344,    315,    279,  12781,    323,  42482,  11325,   3442,
             50,     13,    220,   5907,  52686, 128001,      0,      0],
        [128000,  61917,  19786,    469,  87042,    430,    527,   4276,   9277,
            304,    279,   3142,  21749,   3001, 128001,      0,      0],
        [     0,      0,      0,      0,      0,      0,      0,      0,      0,
              0,      0,      0,      0,      0,      0,      0,      0],
        [128000,   2059,  37971, 128001,      0,      0,      0,      0,      0,
              0,      0,      0,      0,      0,      0,      0,      0],
        [     0,      0,      0,      0,      0,      0,      0,      0,      0,
              0,      0,      0,      0,      0,      0,      0,      0],
        [128000,      9,   2028,    469,   1342,    706,   3738,   7065,  25127,
            499,   1288,   1373,  69322, 128001,      0,      0,      0]]), 'labels': tensor([[128000,   2028,    374,    279,    220,   1041,    339,    469,   1342,
           1052,  10666,    555,   5907,  52686,     11,    323, 128001],
        [128000,    285,  10666,    304,  23915,    449,   4435,  11896,     11,
           4953,   2637,    505,    872, 128001,   -100,   -100,   -100],
        [128000,  17344,    315,    279,  12781,    323,  42482,  11325,   3442,
             50,     13,    220,   5907,  52686, 128001,   -100,   -100],
        [128000,  61917,  19786,    469,  87042,    430,    527,   4276,   9277,
            304,    279,   3142,  21749,   3001, 128001,   -100,   -100],
        [  -100,   -100,   -100,   -100,   -100,   -100,   -100,   -100,   -100,
           -100,   -100,   -100,   -100,   -100,   -100,   -100,   -100],
        [128000,   2059,  37971, 128001,   -100,   -100,   -100,   -100,   -100,
           -100,   -100,   -100,   -100,   -100,   -100,   -100,   -100],
        [  -100,   -100,   -100,   -100,   -100,   -100,   -100,   -100,   -100,
           -100,   -100,   -100,   -100,   -100,   -100,   -100,   -100],
        [128000,      9,   2028,    469,   1342,    706,   3738,   7065,  25127,
            499,   1288,   1373,  69322, 128001,   -100,   -100,   -100]])}

So our tokenizers have the signature def decode(self, ids: List[int]) -> str - they take a list of integers and decode to a string. This means you need to call .tolist() on a tensor before decoding.
In your example, since you have a batch of tensors, try:
# loop through every batch element
for i in range(sample["tokens"].shape[0]):
    print(len(sample["tokens"][i], tokenizer.decode(sample["tokens"][i].tolist()))

disclaimer: code may not work on first try. hope you get the gist  : )

@loretoparisi This is expected, after collating the list of token ids becomes a Tensor, so you'll have to return to list form to decode properly:
print( len(sample['tokens']), tokenizer.decode(sample['tokens'].tolist()) )

It may be good to also remove any empty lines so you don't waste samples that are entirely padding. This brings up a good point about no ability to apply a filter through text_completion_dataset... will create an issue

@RdoubleA great thanks I works!
batch_size: 8
sample_size: 17
This is the 100th Etext file presented by Project Gutenberg, and
sample_size: 17
is presented in cooperation with World Library, Inc., from their
sample_size: 17
Library of the Future and Shakespeare CDROMS.  Project Gutenberg
sample_size: 17
often releases Etexts that are NOT placed in the Public Domain!!
sample_size: 17
!!!!!!!!!!!!!!!!!
sample_size: 17
Shakespeare
sample_size: 17
!!!!!!!!!!!!!!!!!
sample_size: 17
*This Etext has certain copyright implications you should read!*

Having the empty lines filtering would be a great add on, thank you!

@RdoubleA Thanks to helping me, I have two questions. If I use batch_size=1 I can see different padding for the bath, it's possibile to test it using shuffle=True:
{'tokens': tensor([[128000,    220,   5161,     33,   6483,  22774,     13,    435,  11206,
           9282,     30, 128001]]), 'labels': tensor([[128000,    220,   5161,     33,   6483,  22774,     13,    435,  11206,
           9282,     30, 128001]])}
batch_size: 1
12   SEBASTIAN. Foul weather?

...

<torch.utils.data.dataloader.DataLoader object at 0x7fef40d26e50>
{'tokens': tensor([[128000,    262,  34776,    289,   2469,    279,   2606,    261,    315,
             26,    323,   4228,    433,    374, 128001]]), 'labels': tensor([[128000,    262,  34776,    289,   2469,    279,   2606,    261,    315,
             26,    323,   4228,    433,    374, 128001]])}
batch_size: 1
15     Than wots the miller of; and easy it is

And the same when using batch_size=8 by example.
So if I use this dataset to train Llama3 from scratch I get a dimensionality error:
Epoch 0:   0%|                                                                                | 0/2 [00:00<?, ?it/s][rank0]: Traceback (most recent call last):
[rank0]:   File "train.py", line 233, in <module>
[rank0]:     train()
[rank0]:   File "train.py", line 222, in train
[rank0]:     trainer.fit(model)
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/lightning/pytorch/trainer/trainer.py", line 543, in fit
[rank0]:     call._call_and_handle_interrupt(
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/lightning/pytorch/trainer/call.py", line 43, in _call_and_handle_interrupt
[rank0]:     return trainer.strategy.launcher.launch(trainer_fn, *args, trainer=trainer, **kwargs)
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/lightning/pytorch/strategies/launchers/subprocess_script.py", line 105, in launch
[rank0]:     return function(*args, **kwargs)
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/lightning/pytorch/trainer/trainer.py", line 579, in _fit_impl
[rank0]:     self._run(model, ckpt_path=ckpt_path)
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/lightning/pytorch/trainer/trainer.py", line 986, in _run
[rank0]:     results = self._run_stage()
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/lightning/pytorch/trainer/trainer.py", line 1030, in _run_stage
[rank0]:     self.fit_loop.run()
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/lightning/pytorch/loops/fit_loop.py", line 205, in run
[rank0]:     self.advance()
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/lightning/pytorch/loops/fit_loop.py", line 363, in advance
[rank0]:     self.epoch_loop.run(self._data_fetcher)
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/lightning/pytorch/loops/training_epoch_loop.py", line 140, in run
[rank0]:     self.advance(data_fetcher)
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/lightning/pytorch/loops/training_epoch_loop.py", line 212, in advance
[rank0]:     batch, _, __ = next(data_fetcher)
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/lightning/pytorch/loops/fetchers.py", line 133, in __next__
[rank0]:     batch = super().__next__()
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/lightning/pytorch/loops/fetchers.py", line 60, in __next__
[rank0]:     batch = next(self.iterator)
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/lightning/pytorch/utilities/combined_loader.py", line 341, in __next__
[rank0]:     out = next(self._iterator)
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/lightning/pytorch/utilities/combined_loader.py", line 78, in __next__
[rank0]:     out[i] = next(self.iterators[i])
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 630, in __next__
[rank0]:     data = self._next_data()
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1344, in _next_data
[rank0]:     return self._process_data(data)
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1370, in _process_data
[rank0]:     data.reraise()
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/torch/_utils.py", line 706, in reraise
[rank0]:     raise exception
[rank0]: RuntimeError: Caught RuntimeError in DataLoader worker process 0.
[rank0]: Original Traceback (most recent call last):
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/torch/utils/data/_utils/worker.py", line 309, in _worker_loop
[rank0]:     data = fetcher.fetch(index)  # type: ignore[possibly-undefined]
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 55, in fetch
[rank0]:     return self.collate_fn(data)
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 317, in default_collate
[rank0]:     return collate(batch, collate_fn_map=default_collate_fn_map)
[rank0]:   File "/home/coder/.local/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 170, in collate
[rank0]:     raise RuntimeError('each element in list of batch should be of equal size')
[rank0]: RuntimeError: each element in list of batch should be of equal size

This issue has been solved by https://github.com/pytorch/torchtune/issues/1416


feat(crds): add printer columns for Topic and Subscription

Fixes https://github.com/aws-controllers-k8s/community/issues/2194
Adds additional printer columns (ARN, Age, Synced) to Topic and Subscription
CRDs to improve kubectl output. Topics also show DisplayName.
Output example:
k get topics
NAME        DISPLAYNAME   SYNCED   AGE
topic-123   My Topic      True     32m

k get subscriptions -owide
NAME               ARN                                                                                SYNCED   AGE
subscription-123   arn:aws:sns:us-west-2:095708837592:topic-123:a140e042-4de4-44c3-b301-599672805647   True     25m

k get subscriptions
NAME               SYNCED   AGE
subscription-123   True     25m

k get subscriptions -owide
NAME               ARN                                                                                SYNCED   AGE
subscription-123   arn:aws:sns:us-west-2:095708837592:topic-123:a140e042-4de4-44c3-b301-599672805647   True     25m

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm


Added Ukrainian translation

It would be great if someone could review this as well.

thank you @veikus ! we have 2 team members in Kyiv, will ask them to review so we can merge.

@veikus Дякую за твій вклад!
Thank you for your contribution!

@yankobogdan Thank you for the editing!


I`m still learning =)


koreader 2020.12 -> 2021.01

Motivation for this change
Version bump
Things done
Tested running and loading a pdf file

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 110648 run on x86_64-linux 1

1 package built:

koreader

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 110648 run on x86_64-linux 1

1 package built:

koreader


Unable to run commands via exec/execSync

I’m not sure if this is intended or not, but it seemed viable to do give the fact its possible to set the FAUNA_ADMIN_KEY  environment variable I thought it could be a quick approach to apply changes to multiple databases. For testing purposes the code would look something like the following:
process.env['FAUNA_ADMIN_KEY'] = secret_key;
var parentClient = new faunadb.Client({secret: secret_key});

async function runCmd(cmd) {
    try {
        const output = execSync(cmd, { encoding: 'utf-8' })
        console.log('Output was:\n', output);
    } catch (error) {
        console.log(error)
    }
}

async function apply_migration(client) {

    let child_databases = await client.query(q.Paginate(q.Databases()));
    var child_databases_list = [];
    child_databases.data.forEach(async (value, index, array) => {
        var child_db_name = `${value.id}`;
        child_databases_list.push(child_db_name);
    });
    console.log(list)
    for (i=0; i < list.length; i++) {
        let cmdString =  `npx fauna-schema-migrate apply ${i+1} ${list[i]}`
        console.log(cmdString)
        await runcmd(cmdString)
        }

    return true
}

apply_migration(parentClient)
.then((ret) => console.log(ret))

The cmdString variable uses the syntax noted in the README to be able to apply changes to a child database. This will return the following output:

Based on this, I followed the link and thought I could fix this by setting process.stdin.setRawMode(false) at the top of the script, but this did not work either. On the Fauna end, the migrations collection gets created in each database but no document is created within it and no other collections/indexes/functions are created either.
Is there a more accepted way to be able to some kind of application this way?
FYI: this error occurs if I just use apply and set the FAUNA_ADMIN_KEY but the migration goes through, it only doesn't go through when using the following notation: fauna-schema-migrate apply 1 nameOfChildDb1

Try setting --legacy as an option in the npx fauna-schema-migrate apply ${i+1} ${list[i]} command. This is caused by ink, legacy mode prints plain text without using ink.
I'm not entirely sure but I think that you are trying to use fauna-schema-migrate apply 1 nameOfChildDb1 in a wrong way. If you use that, you are expected to write your resources in child folders as explained in the README (look for "Managing multiple databases"). Or look at the tests to learn more if you want to go that route. Your approach with exec should work fine though.
PS: currently childdb tests are disabled since sometimes they fail. That is probably due to this issue.

The --legacy flag has removed the plain text print and yes it does look like I was using it the wrong way, I read that section more closely and the script is working fine now. Thanks for the quick reply!


[MGDOBR-1159]:Move all integration tests into a module

Fixing review comment
MGDOBR-1159
PR owner checklist
Please make sure that your PR meets the following requirements:

[ ] Your code is properly formatted according to this configuration.
Run mvn clean verify -DskipTests so that imports are correctly set.
[ ] Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
[ ] The layers in the kustomize folder have been updated accordingly.
[ ] All new functionality is tested
[ ] Pull Request title is properly formatted: MGDOBR-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

PR reviewer(s) checklist

[ ] Check if code and Github action workflows have been modified and if the modification is safe
[ ] If the modification is safe, add the safe to test label

How to trigger pipelines and use the bots:

Run the end to end pipeline
Annotate the pull request with the label: safe to test. If you want to run the pipeline again, remove and add it again.

Rebase the pull request
Comment with: /rebase.

Deploy BOT
Comment with `/deploy <dev,stable> when the PR has been merged to deploy to a target environment.

Rebased https://github.com/5733d9e2be6485d52ffa08870cabdee0/sandbox/pull/1255, addressing leftover issues


IPROTO-155 Reduce FileDescriptor memory usage

https://issues.redhat.com/browse/IPROTO-155
Parse annotations eagerly to avoid keeping them around.

Sorry @tristantarrant I only noticed running this patch on current Infinispan main, that there are some cases where the annotations field is filled and processedAnnotations not. This probably could be an issue for the remote query code. Full story here => https://infinispan.zulipchat.com/#narrow/stream/118645-infinispan/topic/pr.20queue/near/420641654.
An idea to keep the optimization, is to fill the annotations list only if:

annotations ⊈ processedAnnotations

at the end of processAnnotations methods. WTDY?