Don't make spans for comments or SET statements in SQL

In playing with sleuth, which layers on brave now, I noticed we create spans for a whole lot of junk. This happens to the first trace on a JDBC connection. I think we should not add SET statements or SQL comments to the trace.
cc @marcingrzejszczak @shakuzen @schrepfler @devinsba @angrybobcat
[
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "e415bbea6a2e3b5d",
    "kind": "SERVER",
    "name": "get",
    "timestamp":<PHONE_NUMBER>242552,
    "duration": 58115,
    "localEndpoint": {
      "serviceName": "backend",
      "ipv4": "<IP_ADDRESS>"
    },
    "remoteEndpoint": {
      "ipv4": "<IP_ADDRESS>",
      "port": 51527
    },
    "tags": {
      "http.path": "/api",
      "mvc.controller.class": "Backend",
      "mvc.controller.method": "printDate"
    },
    "shared": true
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "204018b9b80eb785",
    "kind": "CLIENT",
    "name": "/*",
    "timestamp":<PHONE_NUMBER>022729,
    "duration": 32182,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "/* mysql-connector-java-5.1.45 ( Revision: 9131eefa398531c7dc98776e8a3fe839e544c5b2 ) */SELECT  @@session.auto_increment_increment AS auto_increment_increment, @@character_set_client AS character_set_client, @@character_set_connection AS character_set_connection, @@character_set_results AS character_set_results, @@character_set_server AS character_set_server, @@collation_server AS collation_server, @@init_connect AS init_connect, @@interactive_timeout AS interactive_timeout, @@license AS license, @@lower_case_table_names AS lower_case_table_names, @@max_allowed_packet AS max_allowed_packet, @@net_buffer_length AS net_buffer_length, @@net_write_timeout AS net_write_timeout, @@query_cache_size AS query_cache_size, @@query_cache_type AS query_cache_type, @@sql_mode AS sql_mode, @@system_time_zone AS system_time_zone, @@time_zone AS time_zone, @@tx_isolation AS tx_isolation, @@wait_timeout AS wait_timeout"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "f12479b34e62a1f4",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>057645,
    "duration": 389,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET character_set_results = NULL"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "760cf1ca5b00d106",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>058435,
    "duration": 256,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "da2e4f78230009d0",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>060545,
    "duration": 224,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "set session transaction read write"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "64f37d8c50f7c8c5",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>061217,
    "duration": 195,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "ccab9dfc21b802a0",
    "kind": "CLIENT",
    "name": "select",
    "timestamp":<PHONE_NUMBER>061780,
    "duration": 267,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SELECT @@session.tx_isolation"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "05dc86bf6bc3847a",
    "kind": "CLIENT",
    "name": "select",
    "timestamp":<PHONE_NUMBER>074581,
    "duration": 586,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SELECT COUNT(*) from zipkin_spans"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "13b5196e4fdae416",
    "kind": "CLIENT",
    "name": "/*",
    "timestamp":<PHONE_NUMBER>175884,
    "duration": 815,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "/* mysql-connector-java-5.1.45 ( Revision: 9131eefa398531c7dc98776e8a3fe839e544c5b2 ) */SELECT  @@session.auto_increment_increment AS auto_increment_increment, @@character_set_client AS character_set_client, @@character_set_connection AS character_set_connection, @@character_set_results AS character_set_results, @@character_set_server AS character_set_server, @@collation_server AS collation_server, @@init_connect AS init_connect, @@interactive_timeout AS interactive_timeout, @@license AS license, @@lower_case_table_names AS lower_case_table_names, @@max_allowed_packet AS max_allowed_packet, @@net_buffer_length AS net_buffer_length, @@net_write_timeout AS net_write_timeout, @@query_cache_size AS query_cache_size, @@query_cache_type AS query_cache_type, @@sql_mode AS sql_mode, @@system_time_zone AS system_time_zone, @@time_zone AS time_zone, @@tx_isolation AS tx_isolation, @@wait_timeout AS wait_timeout"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "7e68a7732b26f6bd",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>177339,
    "duration": 283,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET character_set_results = NULL"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "80dbf7f33fbc4d58",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>177803,
    "duration": 225,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "82e9476bc383a9f1",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>178197,
    "duration": 211,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "set session transaction read write"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "9c1a87c9a1ed3795",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>178574,
    "duration": 269,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "dccaf494ae86604b",
    "kind": "CLIENT",
    "name": "/*",
    "timestamp":<PHONE_NUMBER>181826,
    "duration": 692,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "/* mysql-connector-java-5.1.45 ( Revision: 9131eefa398531c7dc98776e8a3fe839e544c5b2 ) */SELECT  @@session.auto_increment_increment AS auto_increment_increment, @@character_set_client AS character_set_client, @@character_set_connection AS character_set_connection, @@character_set_results AS character_set_results, @@character_set_server AS character_set_server, @@collation_server AS collation_server, @@init_connect AS init_connect, @@interactive_timeout AS interactive_timeout, @@license AS license, @@lower_case_table_names AS lower_case_table_names, @@max_allowed_packet AS max_allowed_packet, @@net_buffer_length AS net_buffer_length, @@net_write_timeout AS net_write_timeout, @@query_cache_size AS query_cache_size, @@query_cache_type AS query_cache_type, @@sql_mode AS sql_mode, @@system_time_zone AS system_time_zone, @@time_zone AS time_zone, @@tx_isolation AS tx_isolation, @@wait_timeout AS wait_timeout"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "d3db2299822d8bb2",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>183113,
    "duration": 243,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET character_set_results = NULL"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "dc31096681cb0681",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>183574,
    "duration": 221,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "6dab7d24b19286e6",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>184002,
    "duration": 281,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "set session transaction read write"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "fc3f32651ed8efbf",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>184474,
    "duration": 248,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "17c8b3f3016a65f6",
    "kind": "CLIENT",
    "name": "/*",
    "timestamp":<PHONE_NUMBER>187246,
    "duration": 697,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "/* mysql-connector-java-5.1.45 ( Revision: 9131eefa398531c7dc98776e8a3fe839e544c5b2 ) */SELECT  @@session.auto_increment_increment AS auto_increment_increment, @@character_set_client AS character_set_client, @@character_set_connection AS character_set_connection, @@character_set_results AS character_set_results, @@character_set_server AS character_set_server, @@collation_server AS collation_server, @@init_connect AS init_connect, @@interactive_timeout AS interactive_timeout, @@license AS license, @@lower_case_table_names AS lower_case_table_names, @@max_allowed_packet AS max_allowed_packet, @@net_buffer_length AS net_buffer_length, @@net_write_timeout AS net_write_timeout, @@query_cache_size AS query_cache_size, @@query_cache_type AS query_cache_type, @@sql_mode AS sql_mode, @@system_time_zone AS system_time_zone, @@time_zone AS time_zone, @@tx_isolation AS tx_isolation, @@wait_timeout AS wait_timeout"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "8225489562cdef80",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>188548,
    "duration": 270,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET character_set_results = NULL"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "5a1d9b27cafe4c22",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>189036,
    "duration": 258,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "fc662c9dae33e52a",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>189505,
    "duration": 243,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "set session transaction read write"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "4d76b1ee126bb928",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>189917,
    "duration": 588,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "0038390166bc5040",
    "kind": "CLIENT",
    "name": "/*",
    "timestamp":<PHONE_NUMBER>192610,
    "duration": 575,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "/* mysql-connector-java-5.1.45 ( Revision: 9131eefa398531c7dc98776e8a3fe839e544c5b2 ) */SELECT  @@session.auto_increment_increment AS auto_increment_increment, @@character_set_client AS character_set_client, @@character_set_connection AS character_set_connection, @@character_set_results AS character_set_results, @@character_set_server AS character_set_server, @@collation_server AS collation_server, @@init_connect AS init_connect, @@interactive_timeout AS interactive_timeout, @@license AS license, @@lower_case_table_names AS lower_case_table_names, @@max_allowed_packet AS max_allowed_packet, @@net_buffer_length AS net_buffer_length, @@net_write_timeout AS net_write_timeout, @@query_cache_size AS query_cache_size, @@query_cache_type AS query_cache_type, @@sql_mode AS sql_mode, @@system_time_zone AS system_time_zone, @@time_zone AS time_zone, @@tx_isolation AS tx_isolation, @@wait_timeout AS wait_timeout"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "dcd8007cccafb809",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>193772,
    "duration": 297,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET character_set_results = NULL"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "a53a93fac7f6d4c6",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>194331,
    "duration": 258,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "9cb026388c37d4d8",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>194807,
    "duration": 253,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "set session transaction read write"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "9ed2f5878a703cf8",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>195226,
    "duration": 222,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "b9e5bbb089fe1c59",
    "kind": "CLIENT",
    "name": "/*",
    "timestamp":<PHONE_NUMBER>198208,
    "duration": 650,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "/* mysql-connector-java-5.1.45 ( Revision: 9131eefa398531c7dc98776e8a3fe839e544c5b2 ) */SELECT  @@session.auto_increment_increment AS auto_increment_increment, @@character_set_client AS character_set_client, @@character_set_connection AS character_set_connection, @@character_set_results AS character_set_results, @@character_set_server AS character_set_server, @@collation_server AS collation_server, @@init_connect AS init_connect, @@interactive_timeout AS interactive_timeout, @@license AS license, @@lower_case_table_names AS lower_case_table_names, @@max_allowed_packet AS max_allowed_packet, @@net_buffer_length AS net_buffer_length, @@net_write_timeout AS net_write_timeout, @@query_cache_size AS query_cache_size, @@query_cache_type AS query_cache_type, @@sql_mode AS sql_mode, @@system_time_zone AS system_time_zone, @@time_zone AS time_zone, @@tx_isolation AS tx_isolation, @@wait_timeout AS wait_timeout"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "c10a4ea9c4656253",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>199421,
    "duration": 257,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET character_set_results = NULL"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "ff0531f86c5d0c7e",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>199869,
    "duration": 220,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "6c1798ef78673c22",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>200284,
    "duration": 232,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "set session transaction read write"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "3a643452bbcf4e80",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>200680,
    "duration": 213,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "ed818e3b83888f94",
    "kind": "CLIENT",
    "name": "/*",
    "timestamp":<PHONE_NUMBER>203608,
    "duration": 766,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "/* mysql-connector-java-5.1.45 ( Revision: 9131eefa398531c7dc98776e8a3fe839e544c5b2 ) */SELECT  @@session.auto_increment_increment AS auto_increment_increment, @@character_set_client AS character_set_client, @@character_set_connection AS character_set_connection, @@character_set_results AS character_set_results, @@character_set_server AS character_set_server, @@collation_server AS collation_server, @@init_connect AS init_connect, @@interactive_timeout AS interactive_timeout, @@license AS license, @@lower_case_table_names AS lower_case_table_names, @@max_allowed_packet AS max_allowed_packet, @@net_buffer_length AS net_buffer_length, @@net_write_timeout AS net_write_timeout, @@query_cache_size AS query_cache_size, @@query_cache_type AS query_cache_type, @@sql_mode AS sql_mode, @@system_time_zone AS system_time_zone, @@time_zone AS time_zone, @@tx_isolation AS tx_isolation, @@wait_timeout AS wait_timeout"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "6e801ec76cfa49ed",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>204894,
    "duration": 254,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET character_set_results = NULL"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "b52b592bbb4a2713",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>205340,
    "duration": 263,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "5c467c803e5f193f",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>205809,
    "duration": 261,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "set session transaction read write"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "72b55a32a48323c4",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>206243,
    "duration": 261,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "047d9cff7e768d43",
    "kind": "CLIENT",
    "name": "/*",
    "timestamp":<PHONE_NUMBER>209411,
    "duration": 485,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "/* mysql-connector-java-5.1.45 ( Revision: 9131eefa398531c7dc98776e8a3fe839e544c5b2 ) */SELECT  @@session.auto_increment_increment AS auto_increment_increment, @@character_set_client AS character_set_client, @@character_set_connection AS character_set_connection, @@character_set_results AS character_set_results, @@character_set_server AS character_set_server, @@collation_server AS collation_server, @@init_connect AS init_connect, @@interactive_timeout AS interactive_timeout, @@license AS license, @@lower_case_table_names AS lower_case_table_names, @@max_allowed_packet AS max_allowed_packet, @@net_buffer_length AS net_buffer_length, @@net_write_timeout AS net_write_timeout, @@query_cache_size AS query_cache_size, @@query_cache_type AS query_cache_type, @@sql_mode AS sql_mode, @@system_time_zone AS system_time_zone, @@time_zone AS time_zone, @@tx_isolation AS tx_isolation, @@wait_timeout AS wait_timeout"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "10f8cf830cffe5b6",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>210413,
    "duration": 254,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET character_set_results = NULL"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "3dad97555e3ae576",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>211055,
    "duration": 234,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "b5fc1e00bdbe8765",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>211476,
    "duration": 258,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "set session transaction read write"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "a2d80c084de3a177",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>211901,
    "duration": 238,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "d4ed01c43cc3110e",
    "kind": "CLIENT",
    "name": "/*",
    "timestamp":<PHONE_NUMBER>214466,
    "duration": 511,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "/* mysql-connector-java-5.1.45 ( Revision: 9131eefa398531c7dc98776e8a3fe839e544c5b2 ) */SELECT  @@session.auto_increment_increment AS auto_increment_increment, @@character_set_client AS character_set_client, @@character_set_connection AS character_set_connection, @@character_set_results AS character_set_results, @@character_set_server AS character_set_server, @@collation_server AS collation_server, @@init_connect AS init_connect, @@interactive_timeout AS interactive_timeout, @@license AS license, @@lower_case_table_names AS lower_case_table_names, @@max_allowed_packet AS max_allowed_packet, @@net_buffer_length AS net_buffer_length, @@net_write_timeout AS net_write_timeout, @@query_cache_size AS query_cache_size, @@query_cache_type AS query_cache_type, @@sql_mode AS sql_mode, @@system_time_zone AS system_time_zone, @@time_zone AS time_zone, @@tx_isolation AS tx_isolation, @@wait_timeout AS wait_timeout"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "74bb3091987f5b3e",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>215487,
    "duration": 254,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET character_set_results = NULL"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "822cbf823e1ac1db",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>215941,
    "duration": 234,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "e9f8d4feb2f9abf8",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>216366,
    "duration": 247,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "set session transaction read write"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "a072c4fe6faddf2e",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>216783,
    "duration": 253,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "e2e33bc7fa206534",
    "kind": "CLIENT",
    "name": "/*",
    "timestamp":<PHONE_NUMBER>219540,
    "duration": 556,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "/* mysql-connector-java-5.1.45 ( Revision: 9131eefa398531c7dc98776e8a3fe839e544c5b2 ) */SELECT  @@session.auto_increment_increment AS auto_increment_increment, @@character_set_client AS character_set_client, @@character_set_connection AS character_set_connection, @@character_set_results AS character_set_results, @@character_set_server AS character_set_server, @@collation_server AS collation_server, @@init_connect AS init_connect, @@interactive_timeout AS interactive_timeout, @@license AS license, @@lower_case_table_names AS lower_case_table_names, @@max_allowed_packet AS max_allowed_packet, @@net_buffer_length AS net_buffer_length, @@net_write_timeout AS net_write_timeout, @@query_cache_size AS query_cache_size, @@query_cache_type AS query_cache_type, @@sql_mode AS sql_mode, @@system_time_zone AS system_time_zone, @@time_zone AS time_zone, @@tx_isolation AS tx_isolation, @@wait_timeout AS wait_timeout"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "08a2100b1307d7af",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>220543,
    "duration": 258,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET character_set_results = NULL"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "e20b143240249d0b",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>220974,
    "duration": 230,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "0fb5d62b4a45b15f",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>221390,
    "duration": 235,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "set session transaction read write"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "8345b5360f5631fe",
    "kind": "CLIENT",
    "name": "set",
    "timestamp":<PHONE_NUMBER>221769,
    "duration": 234,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "sql.query": "SET autocommit=1"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "parentId": "d6abdbe228950d38",
    "id": "e415bbea6a2e3b5d",
    "kind": "CLIENT",
    "name": "get",
    "timestamp":<PHONE_NUMBER>101492,
    "duration": 197238,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "tags": {
      "http.path": "/api"
    }
  },
  {
    "traceId": "d6abdbe228950d38",
    "id": "d6abdbe228950d38",
    "kind": "SERVER",
    "name": "get",
    "timestamp":<PHONE_NUMBER>642865,
    "duration": 691347,
    "localEndpoint": {
      "serviceName": "frontend",
      "ipv4": "<IP_ADDRESS>"
    },
    "remoteEndpoint": {
      "ipv6": "::1",
      "port": 51523
    },
    "tags": {
      "http.path": "/",
      "mvc.controller.class": "Frontend",
      "mvc.controller.method": "callBackend"
    }
  }
]

here's a photo of the beauty!

Firstly thanks for all the awesome work on Zipkin and this instrumentation @adriancole .
I ran into this issue today and have forked the mysql TracingStatementInterceptor locally and introduced a regex for excluding certain SQL statements. i.e.
private Pattern exclude = Pattern.compile("(set.+)|(commit)|(select @@session.tx_read_only)", Pattern.CASE_INSENSITIVE);

    @Override
    public ResultSetInternalMethods preProcess(String sql, Statement interceptedStatement,
                                               Connection connection) {

        // When running a prepared statement, sql will be null and we must fetch the sql from the statement itself
        if (interceptedStatement instanceof PreparedStatement) {
            sql = ((PreparedStatement) interceptedStatement).getPreparedSql();
        }

        if (exclude.matcher(sql).matches()) {
            return null;
        }

...

This works for us at the moment as we are generally using this locally to help identify perf issues etc but not sure this is a solution you would want to add for this issue? If so would be more than willing to submit a PR.
I guess some concerns would be the performance impact of adding a regex as part of this instrumentation and possibly making this regex configurable? Though not sure what the best approach for that would be?
I also ran into an interesting deadlock issue when 1st adding this instrumentation to an existing Spring Boot / Sleuth application with a c3po connection pool as outlined here in case anyone else has a similar issue.

Note that brave uses P6spy for jdbc integration, it has a few configuration options to exclude certain statements https://p6spy.readthedocs.io/en/latest/configandusage.html#excludecategories from being traced. The SET statement is not one of them AFAICT, commit/rollback is.

I was to make a similar comment to Jorg. we do want to consider what is
required to do in impl vs composition. if this was the mysql driver.. with
no means to configure except classpath or jdbc query params.. maybe we must
define a pattern implementation at the brave abstraction.. or create a
helper to do this.
some things similar are web skip patterns. these can be implemented as
decorating filters. a config project sleuth makes some pattern
autoconfigurations.
anyway this is the point to consider I think.. do we implement this or
delegate to something else that can (ex decoration or another feature). I
usually tend to the latter.
cc @anuraaga
On Tue, May 14, 2019, 12:16 AM Jorg Heymans<EMAIL_ADDRESS>wrote:

Note that brave uses P6spy for jdbc integration, it has a few
configuration options to exclude certain statements
https://p6spy.readthedocs.io/en/latest/configandusage.html#excludecategories
from being traced. The SET statement is not one of them AFAICT,
commit/rollback is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-zipkin-brave/issues/609?email_source=notifications&email_token=AAAPVVYZFBC5JXUDIRGPFZ3PVGH5DA5CNFSM4EQMPECKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVI2EOA#issuecomment-491889208,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAPVV3HLKHC5ZAPQHYZYWDPVGH5DANCNFSM4EQMPECA
.

A few observations

/* should never be the name of a span. I suspect the MySQL instrumentation needs to be updated to handle this more sanely. FWIW, I don't think I've ever seen this I wonder if there is a connector option pretending that comment

Traces of background spans like SET and health check have always been annoying. I'm only interested in tracing queries in the context of a request (if you know what I mean ;) so HikariCP's background queries are boring.

Unfortunately it's not as simple as filtering the span name by itself. Select used in health check I don't need but select used by the app I do.

It's not clear to me whether decoration etc have the flexibility for this sort of filtering. Though I don't know if an interceptor option does either - it's really a pain that MySQL connector doesn't use the perfectly good service loader mechanism for extension... I think we'd need to play around to see what ends up cleanest.
But definitely want to help getting rid of junk MySQL spans from my apps!

@anuraaga @patrickbray it just dawned on me that we should be able to get a sane default by looking at if this is a root span. If so, dump the set, etc.

ok here's a little example https://github.com/openzipkin/brave/pull/970
note you can definitely weed this stuff out with a FinishedSpanHandler meanwhile. Just look at the incoming context and see if it is root (parentIdAsLong == 0). just drop spans named "set" or "/* " by returning false.


Updating the landing page to make it up to date

Summary
Updated the landing page to reflect the current state of the project

Major update in previously "why life science" section
updated the OLS journey
Some grammatical updates

Thank you Berenice! @yochannah whenever you have a chance to have a look (no hurry), please go ahead and add your suggestion+merge it.


Register udahbang.is-cool.dev

Added udahbang.is-cool.dev using the CLI.

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

how do this?


Add Internet Computer (ICP)

Currency name:  Internet Computer
Symbol: ICP
Website: https://dfinity.org
Theme color: #FAB13B (From here)
Logo (SVG format): Drive Link (From Here)

@alphapuggle I think we should go with the black color as the original logo is multicolored.


Errors in 2015-2019 ACS in 2020 Geogs

For CT20-level data

[ ] Median variables have estimates exactly at the lower bound of a bin in cases where ratio = 1
Walk through the workflow of calculating medians when the aggregation step does not combine records (1-to-1).
[ ] Median variables in sample have NULL p, ours currently has 100
[ ] MOE is rounded to different numbers of digits between our output and sample for several variables (e.g. avghhsroc)
[ ] Particularly large differences for non-special, non-median variables: aghhinc, agip15pl, lgoeng1, lgoeng2, mv00t09, mv10ltr, mv90t99, pv150t174 (sample has all estimates of zero),
[ ] Big moe differences for gprgcu18
[ ] We're treating several language vars (lgoeng1,lgarblep1, lgchilep1, etc.) as base variables, so p is 100. Sample data has p less than 100.
[ ] Check on logic concerning which variables should have NULL moe by default.

[ ] Several variables have NULL moe in sample data, while ours are non-NULL, even when estimates are non-zero (e.g. blt10ltr for some tracts). Why?

[ ] Check on logic for z calculation. In several cases, c, e, m, and p match exactly, but z differs.

median variables should have p = NULL and z = NULL

Over all strategy

Check all cases where E != E_sample (across all geographies)
Check all cases where E = E_sample but M != M_sample
Check all cases where E = E_sample, M = M_sample but C != C_sample

@SPTKL  given that there are also rounding errors, should we set a threshold for the 4 checks you list above?

@SPTKL given that there are also rounding errors, should we set a threshold for the 4 checks you list above?

yeah, I remember we did 0.1 for previous iterations

median variables should have p = NULL and z = NULL
For some reason, median variables calculated at CT20 have p set to 100. The following line isn't working properly.
https://github.com/NYCPlanning/db-factfinder/blob/7da9fbeb6dabcd525b205501d0ea2d6260587cbf/factfinder/calculate.py#L233

median variables should have p = NULL and z = NULL

For some reason, median variables calculated at CT20 have p set to 100. The following line isn't working properly.
https://github.com/NYCPlanning/db-factfinder/blob/7da9fbeb6dabcd525b205501d0ea2d6260587cbf/factfinder/calculate.py#L233

We would need to exclude median/special variables from this line

also it seems like pv150t174 is just not calculated at all for a lot of the tracts, c,e,m,p,z all empty

median variables should have p = NULL and z = NULL

For some reason, median variables calculated at CT20 have p set to 100. The following line isn't working properly.
https://github.com/NYCPlanning/db-factfinder/blob/7da9fbeb6dabcd525b205501d0ea2d6260587cbf/factfinder/calculate.py#L233

We would need to exclude median/special variables from this line

@SPTKL  this line applied specifically to median variables

seems I skipped over pv150t174 in recalculating the data. it should not be blank. uploaded new version of economic file for this fix.

MOE for avghhsroc should be rounded to two decimal places. There's a few variables that have different logic for rounding than the normal rules. It was in the previous code logic

fixed MOE for blt10ltr (uploaded new housing file). are there others where this is an issue?

fixed MOE for blt10ltr (uploaded new housing file). are there others where this is an issue?

@EricaMaurer
Here is a list of variables that have non-zero tract-level estimates and NULL MOE in the sample data, with non-zero estimates and non-NULL MOE in our output. Several are inputs to median calculations.

e7pt5t10
e10t12pt5
e12pt5t15
e15t17pt5
e17pt5t20
e20t22pt5
e22pt5t25
ern2pt5t5
ern5t7pt5
ernu2pt5k
lgoenlep2
mdage
mdefftwrk
mdemftwrk
mdewrk
mdfam
mdfami10t14
mdfami15t19
mdfami20t24
mdfami25t29
mdfami30t34
mdfami35t39
mdfami40t44
mdfami45t49
mdfami50t59
mdfami60t74
mdfami75t99
mdfami200pl
mdfaminc
mdfamiu10
mdfi100t124
mdfi125t149
mdfi150t199
mdgr
mdhhi10t14
mdhhi15t19
mdhhi20t24
mdhhi25t29
mdhhi30t34
mdhhi35t39
mdhhi40t44
mdhhi45t49
mdhhi50t59
mdhhi60t74
mdhhi75t99
mdhhi200pl
mdhhinc
mdhhiu10
mdhi100t124
mdhi125t149
mdhi150t199
mdnfinc
mdpop0t4
mdpop5t9
mdpop10t14
mdpop15t17
mdpop18t19
mdpop20
mdpop21
mdpop22t24
mdpop25t29
mdpop30t34
mdpop35t39
mdpop40t44
mdpop45t49
mdpop50t54
mdpop55t59
mdpop60t61
mdpop62t64
mdpop65t66
mdpop67t69
mdpop70t74
mdpop75t79
mdpop80t84
mdpop85pl
mdpop_3
mdrms
mdvl
nf100t124
nf125t149
nf150t199
nfam
nfi200pl
nfmi10t14
nfmi15t19
nfmi20t24
nfmi25t29
nfmi30t34
nfmi35t39
nfmi40t44
nfmi45t49
nfmi50t59
nfmi60t74
nfmi75t99
nfmiu10
oochu5
ov1t149m
ov2milpl
ov100t124
ov125t149
ov150t174
ov150t199m
ov175t199
ov200t249
ov250t299
ov300t399
ov400t499
ov500t749
ov750t999
ovl10t14
ovl15t19
ovl20t24
ovl25t29
ovl30t34
ovl35t39
ovl40t49
ovl50t59
ovl60t69
ovl70t79
ovl80t89
ovl90t99
ovlu10
r1kt1249
r1p5t1999
r2kt2499
r2p5t2999
r3kt3499
r100t149
r150t199
r200t249
r250t299
r300t349
r350t399
r400t449
r450t499
r500t549
r550t599
r600t649
r650t699
r700t749
r750t799
r800t899
r900t999
r1250t1p5
r3500pl
roccshrnt
ru100
wrke16pl

the variables that aren't shown in the profile and are just used as inputs to medians do not use MOEs so didn't previously calculate those columns. ok to calculate them on your end though.
the variables included in the list that are medians that have estimates but no MOE shown was because our median calculations produced an error or the data is top-coded
just fixed LgOEnLEP1M and reuploaded the social part 2 file
I think that should clear everything unless I missed one on the list that doesn't fall into those categories

the variables that aren't shown in the profile and are just used as inputs to medians do not use MOEs so didn't previously calculate those columns. ok to calculate them on your end though.
the variables included in the list that are medians that have estimates but no MOE shown was because our median calculations produced an error or the data is top-coded
just fixed LgOEnLEP1M and reuploaded the social part 2 file
I think that should clear everything unless I missed one on the list that doesn't fall into those categories

@EricaMaurer  I tried sorting in the comment above. For cases where your median calculation showed an error or the data was top-coded, what should we be producing?

-- Big m differences for gprgcu18 across geographies, even with matching e... found the error on my end-- was referencing the wrong column. Will re-upload sample data.
--Big p and z differences for lgchilep2 with matching e and m. Is base variable correct? We use pop5pl2... base should be LgOenLEP2
-- Differences in z for pu18bwpv, p65plbwpv and pbwpv with matching c, e, m, p across most geographies
check base variable in formula...
---pu18bwpv -- base: PU18PvU
---p65plbwpv -- base: P65plPvU
---pbwpv -- base: PopPvU1
-- Difference in p for p65plbwpv for SI0305... weird that only one geog would be off
=<PHONE_NUMBER>17668/2487.45653710247)*100 = 7.03832458602895
rounded: 7.0
-- Big differences in p for pbwpv for most NTA and CDTAs... check base: PopPvU1 (should be ok if percent for tracts match)
-- Big differences in p for pu18bwpv for most NTA and CDTAs: check base: PU18PvU (should be ok if percent for tracts match)
--  MOE is rounded to different numbers of digits between our output and sample for several variables (e.g. avghhsroc)
--- estimate and MOE should be rounded to same number of digits. Below are variables that are not rounded to full number (number of decimal digits)
--- mdage: 1
--- avghhsz: 2
--- avgfmsz: 2
--- mntrvtm: 1
--- hovacrt: 1
--- rntvacrt: 1
--- mdrms: 1
--- avghhsooc: 2
--- avghhsroc: 2

@mgraber do you think we can close this issue and open up a new one just for the medians? it seems like all the non-median related issues are resolved


testing of UI connectivity to VMODL API - all enpoints are testing ok

is there a way to avoid copy0n-paste for each argsSOAP construction ?
The rest looks good to my untrained eye

msterin: good call, I've made it more DRY, those changes will be in the next PR

msterin: good call, I've made it more DRY, those changes will be in the next PR

LGTM then. Looking forward for the next PR :-)


Depend on the DI Interfaces package instead of the implementation package

Relies on https://github.com/aspnet/DependencyInjection/pull/195
/cc @HaoK @davidfowl @Eilon

Hi @GrabYourPitchforks, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Levi Broderick). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla2.msopentech.com.

TTYL, MSOTBOT;

:shipit: once the DI change goes in

:shipit: very nice

:heart: refactoring


Create OpenCollective account

(once we have confirmed domain)

Reach4Health OpenCollective created!
https://opencollective.com/reach4help


Ctoaster cloud dev setup changes

Accidentally opened it here, hence closed.
This PR is opened on ctoaster.carrotcake.


Question: kadm.CalculateGroupLag documentation is very confusing on how to get the inputs

https://github.com/twmb/franz-go/blob/master/pkg/kadm/groups.go#L1050-L1054

I don't think the function FetchOffsets has the signature expected in that comment
Its not obvious how to get the middle parameter 'commit OffsetResponse'

Perhaps an actual example test would make it more clear?

FetchManyOffsets returns FetchOffsetsResponse seems to have CommittedPartitions function on its signature but doesn't meet OffsetResponse signature.

Example here: https://github.com/redpanda-data/redpanda/blob/b4232edad290078fb9b204af40a0a2834c484b44/src/go/rpk/pkg/cli/cmd/group/describe.go#L50-L78
I'll update the docs

Perfect thank you.


Automate Firefox AMO release

Tools we can use: https://www.npmjs.com/package/firefox-extension-deploy
Related to: https://github.com/mozilla/web-ext/issues/804

https://github.com/bfred-it/web-ext-submit


It is support WKWebView ？

A new APP must the WKWebView.

go: https://socket.io/blog/socket-io-on-ios/


[wip] improve c support

I would by default only provide the default toolchain from nixpkgs itself and also make
sure that CC/LD/STRIP/NM environment variables are set so that buildsystems pickup the devenv compiler rather than defaulting to impure /usr/bin/gcc etc.
Furthermore I would only provide one module for both c/c++ as these cannot be separated and configurations would conflict with each other.
Also interesting would be to have some sane abstraction for cross compiling as this is a complex topic where the nix documentation is not super helpful.
Let me know what you think about the direction.

Hey @Mic92, do you still want to do this now that naked shell has been removed?

We can close this. I see value in overriding the compiler with overrideCC, but currently do not have plans to add this.


First crack at some GUI changes.

Added some components, nothing really works yet.

subset of roster-options PR content


[Device Support Request]

Is your feature request related to a problem? Please describe.
I've seen these TRVs made by Tuya apparently but they don't stick to ZHA.
Describe the solution you'd like
Adding a quirk would be nice
Device signature - this can be acquired by removing the device from ZHA and pairing it again from the add devices screen. Be
I don't own them yet but here's a link to deconz thread:

Additional context
Add any other context or screenshots about the feature request here.

Please fill out all of the required information

Here's a missing link to deconz thread, is this enough to work with?

I would very like to have this as well!

Some devs have starting doing the ground for the tuya comand decoding and some for the TRVs https://github.com/zigpy/zha-device-handlers/pull/538#issue-509500699.
Device support request is posted for them https://github.com/zigpy/zha-device-handlers/issues/581#issue-740866517.
If making one working then its only adding the model id and its working and if little different its only applying different options from the tuya palette of functions (look at Z2M how they is adding new ones its similar as for Zigpy).

I have some twins (different model number) and its being supported in the dev branch today in deCONZ ;-))
HA dont have support for all functions but more is in the pipe.


Extend Rust README with cargo-nextest notes

After https://github.com/hyperledger/iroha-2-examples/blob/Rust_base/Rust/README.md is available in the main branch, it'll be useful to add notes on cargo-nextest arguments like:

--no-fail-fast
--no-unstable
-p

Closing, because it does not reflect the architecture


config migration to add dataFormat

This is expected to be used in the future for migration
from Lift to LCM
Adding it to WeSay 1.6 so that, provided no other config changes are
needed 1ater, 1.6, 2.0 and 3.0 will be compatible

This change is

I made it as  under . I can change it if there would be a better place than there

  Although I don't yet understand about the two format states that are "in transit" ie. LiftToLCM and LCMToLift  I'm sure there's a good reason for it.

Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

src/WeSay.Project/WeSayWordsProject.cs, line 49 at r1 (raw file):

namespace WeSay.Project
{
	public enum WeSayDataFormat { Lift, LCM, LiftToLCM, LCMToLift };

What does it mean when WeSayDataFormat is set to LiftToLCM or LCMToLift ?

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

src/WeSay.Project/WeSayWordsProject.cs, line 49 at r1 (raw file):
Previously, megahirt (Chris Hirt) wrote…
What does it mean when WeSayDataFormat is set to LiftToLCM or LCMToLift ?

The idea is that if there is a gui radio control then instead of changing the DataFormat from Lift to LCM it will change to LiftToLCM so that wesay-config will know to do the migration when it closes and saves

Comments from Reviewable

We agreed that this change will enable interoperability between 3.0(LCM) and 2.0(Lift), but doesn't insist on that strategy


chrome bug - modal

Hello,
The first time the modal open I cannot scroll down to it's end:

After it works but it's white at the end of the body:

The second issue appears on Firefox to. I'm on Ubuntu.

I've met the same problem, but after debugging, I found the reason is: I put some images into the ".content" tag, and the modal is shown before the image loaded.  something like:
var $modal = $('.ui.modal').modal({ options... });
$modal.find('.content').html("<img src=\"real large image\">");
$modal.modal('show');

you could refer to http://plnkr.co/edit/uNo0RGX8YLfPjjUtJXUo?p=preview
I resolved this problem by setting the 'height' of '.content img' tag.
I guess maybe you've done the similar things.
I think this is really a frustrating problem, I hope @jlukic could add warnings (that display images in modal may incur some problems) in documents.


extract_mft_record_slack.py - broken shebang

Greetings--
The extract_mft_record_slack.py tool on the SIFT workstation uses a shebang which points to /bin/python as the location of the Python symlink:
#!/bin/python

#    This file is part of INDXParse.
#
#   Copyright 2014 Will Ballenthin<EMAIL_ADDRESS>#                    while at FireEye <http://www.FireEye.com>

...however on the SIFT workstation, Python has been configured to place its symlink at /usr/bin/python:
sansforensics@siftworkstation:~$ which python
/usr/bin/python

This causes an issue if one is running the script as executable - which it is in SIFT:
sansforensics@siftworkstation:~$ extract_mft_record_slack.py test
bash: /usr/local/bin/extract_mft_record_slack.py: /bin/python: bad interpreter:
No such file or directory

It looks like Willi's development environment has the Python symlink residing at /bin/python - it is probably just a holdover from that:
https://github.com/williballenthin/INDXParse/blob/master/extract_mft_record_slack.py
Adam

Fixed!

Thanks!


Deletion of alternate nodes in Linked List

EXPLANATAION:
Given a Singly Linked List of size N, deletion of alternate nodes are implemented in this program.
Input 1 consists of number of testcases i.e. T
Input 2 consists of number of Nodes i.e. N
EXAMPLE
INPUT:1->2->3->4->5
OUTPUT: 1->3->5
Hello  @tarun26091999  please assign this to me .I would implement it using either C++.

hello @tarun26091999 @rudrakshi99 can i work on this issue in python?
Thank you!


[WIP] Optimize .ibm Dockerfile for Improved Build Performance and Dependency Updates

Optimized the Dockerfile by combining multiple RUN commands into a single layer to reduce the size and improve build efficiency. Set essential environment variables together, consolidated installations, and added comments for clarity. This refactor enhances maintainability and performance of the Docker build process.

Would be cool if you could also switch this to be based on UBI9 so we're not using Ubuntu to test RH product :D

Would be cool if you could also switch this to be based on UBI9 so we're not using Ubuntu to test RH product :D

Unfortunately, Playwright only supports Ubuntu and Debian from Linux distros 😢

I added one more comment regarding Go. Apart from that I'm good with the changes once the PR is green


Complete overhaul of connected lights tutorial

Apologies in advance for how huge this PR is.
Key updates & changes:

SimpleM2MClient removed and replaced with current mbed cloud client
References to "access key" replaced with "application key"
Complete removal of web application tutorial pages as Python & JS SDKs are deprecated
Screenshots renamed and updated for current portal
Firmware code brought up to date for Mbed OS 6.2 & current mbed cloud client

I have gone through and tested the entire tutorial end-to-end to make sure it compiles and runs/works, but only for the K64F board and Grove LED bar. Other boards remain untested due to lack of hardware.

@peknis01 Could you please review this for API key/access key terminology accuracy?

@peknis01 Could you please review this for API key/access key terminology accuracy?

Terminology checked. Only two instances needing my attention found. And fixed. Also one link fix in the same doc.

thanks @yennster for the PR, @AnotherButler fyi started reviewing.


Add -minimum-slang-optimization to favor compile time.

New Feature

Add -minimum-slang-optimization compiler option to enable a minimum set of optimizations in the Slang compiler. This speeds up the compilation time in Slang for users who wish to favor faster compile times.

Probably it is expected but I noticed that some of slang-test tests are failing when the option is enabled.

@jkwak-work this is fine. We have tests that assumes the optimizations exist and is looking for a specific pattern that is no longer the case without the optimization.


Revert to 8d14ad4

I don't know why you remove PlanViz2 and keep PlanViz...
As I mention in the README.md in version 1.4.0, PlanViz is for last year and should keep it.


Issues with instalation

I've tried to install your package with npm i https://github.com/fasiha/curtiz-japanese-nlp. However, after importing there're some issues. One example of the errors is:
node:internal/modules/cjs/loader:1039
  const err = new Error(message);
              ^

Error: Cannot find module './annotate'
Require stack:
- /Users/b450-admin/PycharmProjects/transcript/node-server/node_modules/curtiz-japanese-nlp/annotateServer.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1039:15)
    at Module._load (node:internal/modules/cjs/loader:885:27)
    at Module.require (node:internal/modules/cjs/loader:1105:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (/Users/b450-admin/PycharmProjects/transcript/node-server/node_modules/curtiz-japanese-nlp/annotateServer.js:18:20)
    at Module._compile (node:internal/modules/cjs/loader:1218:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1272:10)
    at Module.load (node:internal/modules/cjs/loader:1081:32)
    at Module._load (node:internal/modules/cjs/loader:922:12)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:169:29) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/b450-admin/PycharmProjects/transcript/node-server/node_modules/curtiz-japanese-nlp/annotateServer.js'
  ]
}

Node.js v18.13.0

What I noticed is that none of the .js files are located in the package, only .ts. Is this the expected behaviour? Could you help me with configuring it?

I'm so so so sorry for forgetting about this, please forgive me! I've fixed this so the instructions in the README will work! I'll repeat them here just to make sure I don't mess them up:
mkdir curtiz-demo
cd curtiz-demo
# download JmdictFurigana.json (see README for links)
# download and unzip jmdict-eng-3.5.0.json
# download kanjidic2.xml.gz
npm init -y
npm i https://github.com/fasiha/curtiz-japanese-nlp
PORT=8888 JMDICT_SIMPLIFIED_JSON=./jmdict-eng-3.5.0.json npx curtiz-annotate-server

This will print out several lines like
Annotation app listening at http://<IP_ADDRESS>:8888, NATIVE mecab=true
3378 entries written
7264 entries written
11120 entries written
...

and then the server will be ready! In another console you can run
curl --data '{"sentence": "へましたらリーダーに切られるだけ"}' \
  -X POST \
  -H "Content-Type: application/json" \
  -o curtiz.json \
  http://<IP_ADDRESS>:8888/api/v1/sentence

and this will save the output of the REST API in curtiz.json which you can look at. It'll have details on dictionary hits, conjugations and deconjugations of verbs/adjectives, particles, JDepP bunsetsu dependency trees, kanji entries and breakdowns from Wanikani, etc. 😁
I'm very happy you're interested in this package, I really like it but I know it's quite hard to use and the documentation is very spotty and it's untested. I am most happy to help answer questions and build docs if you'd like. Right now I'm using this as part of my app quite intensively so it may change, but hopefully only for the better.


protect against zero devision given zero fluxes

In the case of 'sc::Fluxes' and 'sc::FluxesAndFrictionVelocity' if the known fluxes are zero than 'local_lmo' in 394 and 'obukhov_length' in line 377 will result in zero devision. we should consider either returning a very large LMO or LMO=0 in these cases.

@yairchn I think https://github.com/CliMA/SurfaceFluxes.jl/pull/60 closed this issue.


Incorrect ETINE flagging:

The following are flagged as ETINEs in this report:
http://build.berkeleybop.org/job/build-go-assert-inferences-report/2877/artifact/assert-report.txt
But they appear to be inferred correctly in Protege + ELK.
GO:0008333	endosome to lysosome transport	GO:0016482	cytoplasmic transport

There are lots of other ETINES to "GO:0016482	cytoplasmic transport" that are equally suspect.
Side of membrane to organelle part":
GO:0098538	lumenal side of transport vesicle membrane	GO:0044433	cytoplasmic vesicle part
GO:0098539	cytoplasmic side of transport vesicle membrane	GO:0044433	cytoplasmic vesicle part
GO:0098554	cytoplasmic side of endoplasmic reticulum membrane	GO:0044432	endoplasmic reticulum part
GO:0098565	lumenal side of endosome membrane	GO:0044440	endosomal part

Possible explanation:  In testing, it is hard to remove all inferences that might be being used.  If this is the issue, it may be easier to work through ETINEs once inferences have been split out.
Related ticket: #12315
CC @cmungall

Update:
As a crude experiment - I've created an OBO version of gene_ontology_write using egrep -v 'is_inferred="true"'.  I'm finding some interesting problems
For example, this is not entailed:
GO:0098538 lumenal side of transport vesicle membrane GO:0044433 cytoplasmic vesicle part
because after stripping inferred axioms, side of membrane has no classification up to cellular_component.

Presumably a previous redundancy stripping removed the reason that 'membrane part' was entailed.

This one is down to the intracellular clause on cytoplasmic transport
GO:0008333 endosome to lysosome transport GO:0016482 cytoplasmic transport
Simple fix for now is to assert intracellular transport as genus of all affected terms
Might want to consider changing pattern for cytoplasmic transport to 'occurs in' some cytoplasm.  But this then has the problem that we need to add many more occurs in axioms to transport classes.

Whatever we do, all assumptions should be made explicit, preferably in
the label.
the intercellular clause in 'cytoplasmic transport' prevents transport
from the cytosol of one cell to the outside of the same cell (despite
the fact this is allowed by the text definition).
we could have transport from the endosome of one cell to the lysosome of
another (unlikely perhaps, but analogous situations may exist). This
also wouldn't fit.
On 1 Mar 2016, at 7:46, David Osumi-Sutherland wrote:

This one is down to the intracellular clause on cytoplasmic transport
GO:0008333 endosome to lysosome transport GO:0016482 cytoplasmic
transport
Simple fix for now is to assert intracellular transport as genus of
all affected terms
Might want to consider changing pattern for cytoplasmic transport to
'occurs in' some cytoplasm.  But this then has the problem that we
need to add many more occurs in axioms to transport classes.

Reply to this email directly or view it on GitHub:
https://github.com/geneontology/go-ontology/issues/12316#issuecomment-190777861

Whatever we do, all assumptions should be made explicit, preferably in
the label.

Agree

the intercellular clause in 'cytoplasmic transport' prevents transport
from the cytosol of one cell to the outside of the same cell (despite
the fact this is allowed by the text definition).

I think the term itself is pretty suspect. Is it really intuitive to have cytoplasmic transport cover everything coming in and out of the cytoplasm?  I'm inclined to redefine as "transport that 'occurs in' some cytoplasm" or obsolete it (even with occurs in, it covers transport in and out of cytoplasmic organelles.  The problem with this strategy is that it requires adding an occurs_in clause to many classes to get appropriate classification.


Intersection of Nvidia GRID, NV-series Virtual Machines, and Citrix XenServer

The existence of the NV-series VM is great, but to take advantage of the Nvidia GRID technology, you have to utilize other technologies like Citrix XenServer and XenDesktop. Does anyone have an architecture that shows how to deploy these three technologies on Azure to actually take advantage of the GRID hardware for high performance remote graphics?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 472ed16f-83af-9c24-4a47-596e72a59ca7
Version Independent ID: dc63914d-d1ce-8161-0d6c-b0c62f82b22d
Content: Azure Windows VM sizes - GPU
Content Source: articles/virtual-machines/windows/sizes-gpu.md
Service: virtual-machines-windows
GitHub Login: @jonbeck7
Microsoft Alias: jonbeck

@rwwinn1 we do not have any MSFT branded documentation on merging the three together. However, once you setup the N series and its drivers the process should be no different than implementing the solution on premises. If you are looking for help in building this solution I would suggest reaching out to Stack Overflow or MSDN community as others who have gone through this process could help provide you with guidance.
I will close this out as there is not actionable feedback on this specific document.
If you decide to open a post on Stack or MSDN please feel free to share it here so we can follow up as well.


Restore option not shown for backups of volumes that are not in use by any VM.

Rancher server - Build from master
Steps to reproduce the problem:
Deploy a VM service with ROOT volume in longhorn.
Take few snapshots.
Stop VM service.
Create Backup of snasphot.
After this , I should be given an option to do restorefrombackup for the ROOT volume of this VM from this backup.
There is no option presented in UI for doing this.

Might be my problem if the action isnt showing up

Restore wasn't implemented at the time

Tested with UI version - v1.1.6
Restore volume from Backup option is seen for backups when the Volume that they were created from is not in use by any VM.


Added initial support for 5" turing screen

Based on https://github.com/mathoudebine/turing-smart-screen-python/blob/main/library/lcd/lcd_comm_rev_c.py

Supports full image display
Partial image update but this seems to have limited support. Example 1 doesn't work with this.
Added unit tests to compare python output with c# code

@ErikApption
Thanks for the pull request.
I would like to merge, but I would like you to do the following.

Make sure there are no warnings when doing a Release build.
The name should match the Python source, not 5inch.
Delete unnecessary files such as backup and make a pull request with minimal content.

Hi @usausa, I believe I fixed all the issues you asked.

@ErikApption
There is a build warning, so please check it.
This project uses static checking by Analyzer as a coding rule.
There is an AnalysisMode setting in Directory.Build.props, and if you build in Release mode, the following warning will be output, so I would like you to take action.
1>D:\GitHub\turing-smart-screen\TuringSmartScreenLib\TuringSmartScreenBufferC.cs(11,47,11,58): warning CA1825: 不要な長さ 0 の配列の割り当てを避けます。代わりに Array.Empty<byte>() を使用してください。 (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1825)
...

I missed the release configuration... I think I cleaned the remaining issues


Unittest for #177 / #192

Hello,
this is my first-ever pull request, so please excuse me if i did any mistake or unwanted stuff.
I refactored the code to make sure "createAndFillUserTable" can be used with both bind() and without bind() - may be useful in the future as well.
Please ignore commits b9c6ddd5d8d9876ae245416a3f6eb3cd5bf5f8eb and ad8823e0943b3138e4ccb07cb75bff6d690fe1e3 - the first had some unwanted code pushed, the second is the revert of it.
My last commit (e68c36db8820676b5cc7dc82ecc3b165c307df17) has all the changes i really.
I'm looking forward for any feedback you may have!

Looks good. Thanks!
 This will make for a cleaner git history.
Also, I can see that you have fixed some formatting in the code. Next time, put these fixes in it's own commit, as these has nothing to do with the unittest.

Hello,
Thanks for git reset, i didn't know it.
On the formatting, i need to be honest, it may have been my IDE, as i didn't do that on purpose. Sorry for that, i'll keep an eye out next time.

@zsoca8711 nice contribution.
@aaberg @zsoca8711 about code formatting, I have some suggestions (listed bellow). What you guys think about it?

Wasn't this a case to use a tool to statically check the code formatting to avoid situations like this. This question at SO have some interesting suggestions about this subject.
Create a CONTRIBUTING.md file and include on it some suggestions about code style. It will make another contributors more comfortable.

Regards

There is already a short document describing the coding guidelines:
https://github.com/aaberg/sql2o/wiki/Coding-guidelines
I like the idea about statically checking the code at compile time, but I don't think it should be necessary. Maybe it is enough to make the coding guidelines more visible? The compile-time code check will anyway just be able to check for things like the use of whitespaces instead of tabs and number of whitespaces etc. It won't be able to check if the contributor has added unwanted code changes.
When using git, it is regardless a best practice to always run a git status and a git diff before committing changes.


fix: only selected row has enabled toggle in feed modal

Description
correct the enabled/disabled state on the feed management modal in package manager so that only the selected row is enabled
Task Item
fixes #7028
Screenshots

Coverage remained the same at 54.656% when pulling 18c6b2a7d67646205d0fb774be0a5f9971ee4504 on benbrown/prereleasetoggle into 9827be615ada2d3009528b8c96003aca9c174b57 on main.


Add an api to fetch subscribers by email

Is there an API to fetch subscriber(s) by email? Something like:
$subscribers = $mailcoach->subscriberByEmail('john@test.com');

Which returns an array of subscriber resources that have the email.

Yes there's a findByEmail method.


Training takes too long

Hi, I tried training your model on a Nvidia GTX 1050 GPU, but it takes around 5-6 days to complete the training (which seemed too long for the size of the dataset and model). It was trained on the DAVIS-train-dataset provided as a link in the README. Hence I wanted to know the estimated training time and the hardware on which it was trained.
Also, I used DALI is 0.10.0 as mentioned in the README. Could a newer version of DALI improve the speed in any way?
Thanks for your help!

Hi, it takes me 4-5 days to train a model on a Titan Xp. You can try augmenting the batch size if it fits in your GPU memory.
As for the newer version of DALI, it could improve the runtimes, but I don't know for sure if fairness, I haven't tried.
Hope this helps!


unstable featureId

Problem
A day ago, featureId=338 was Italy, now it is some county in Russia. It's meaning is not defined.
Can we make IDs that don't change?
Proposal
I don't know. Good enough for me to use random numbers as long they don't change.
Ratione
I'm trying to pre-select some locations by ID but now I need to search/find the whole array by country/county/city and aggregation to find it.

Yes, they totally change. #243 was set to fix this with the help of @hyperknot's killer dataset, and it will be refactored and resent soon.

@lazd if this is fixed, feel free to close :)


nrtcacheck: use v1 API

due to a oversight, the code was not update to use the v1 API.

/chery-pick release-4.13

/cherry-pick release-4.13


Fix password changed email and add a regression test

Template wasn't rendering
Closes #1384
Backend checklist

[x] Formatted my code by running isort . && black . in app/backend
[x] Added tests for any new code or added a regression test if fixing a bug
[x] All tests pass
[ ] Run the backend locally and it works
[x] Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

The test seems like a unit test, not a regression test? And it seems like it doesn't really test for the fix? Shouldn't there be a test in test_email for the change you made?


Should be possible to use Ruby's URI implementation instead of Addressable::URI

Sometimes Addressable::URI mangles urls to something incorrect. See: https://github.com/sporkmonger/addressable/issues/160
When cobweb crawls one of these, the correct URL is put into redis, but when normalized it hits a 404. Examples would be any URI containing "%e2%80%b3"
Ruby's URI implementation doesn't do this. It would be nice to have an option of using this class instead.

Just closed sporkmonger/addressable#160 as "won't fix", but wanted to comment here because I suspect cobweb is actually misusing Addressable, given that this issue came up.
The uri.normalize method's output should not generally be used directly to query a web server. Instead, you want to use it as more of a lookup key for caches or previously crawled URLs, etc. So you'd use uri to query your web server and uri.normalize to record the output the web server gives you back. But you'd never want to make a request to the web server with the output of uri.normalize because it's an intentionally lossy operation that's primarily meant for lookups and equality testing (where both sides of the URI equality being tested get normalized and then compared). Probably 95+% of the time it'll work fine to do it the wrong way, but then every once in awhile it'll bite you.
Sorry about getting to this so late after the issue was opened.


OpenApi response oneOf, for several response types

Describe the feature
@OpenApiResponse(status = "200", content = @OpenApiContent(from = First.class, type= "application/json")),
                    @OpenApiResponse(status = "200", content = @OpenApiContent(from = Second.class, type= "application/json")),
                    @OpenApiResponse(status = "200", content = @OpenApiContent(from = Third.class, type= "application/json")),

should compile to corresponding oneOf in stead of picking the last item, from swagger.io
responses:
        '200':
          description: A JSON object containing pet information
          content:
            application/json:
              schema:
                oneOf:
                  - $ref: '#/components/schemas/Cat'
                  - $ref: '#/components/schemas/Dog'
                  - $ref: '#/components/schemas/Hamster'

Additional context
Until then
                    @OpenApiResponse(status = "200", content = @OpenApiContent(from = First.class, type= "application/json")),
                    @OpenApiResponse(status = "200", content = @OpenApiContent(from = Second.class, type= "application/json")),
                    @OpenApiResponse(status = "200", content = @OpenApiContent(from = Third.class, type= "application/json")),
                    @OpenApiResponse(status = "200", content = @OpenApiContent(from = PlaceHolder.class, type= "application/json"))

class PlaceHolder  {}

and custom ToJSONMapper (replace with it -> JacksonToJsonMapper.INSTANCE.map(it).replaceAll(...).replaceFirst(...))
            String yaml = Yaml.pretty().writeValueAsString(openApi);
            return yaml.replaceAll("\n(\\s+)(.+)/PlaceHolder'\n", "\n$1oneOf:\n  $1- $2/First'\n  $1- $2/Second'\n  $1- $2/Third'\n").replaceFirst("\\s+PlaceHolder:\n\\s+type: object","");

either default several compiles to oneOf, or make more tages in the OpenApiContent-annotation: so as to handle oneOf, and anyOf as well as single schemas

@MikkelHJuul could you submit a PR for this?

I will look at it in some time; on vacation for another week!

But as I see it, in order to control if the outcome should be oneOf or anyOf, the annotation needs to change in a way that is non-compatible with the current version.
But then again I would suggest pulling the open API annotation and its rendering to another project entirely (there are not so many open API frameworks out there - or in a self-contained module which serves this purpose)

Might pull it out eventually, but for now it's easier to keep them in the same project imo.
Maybe I shouldn't be, but I'm more okay with breaking changes to plugins than to the core.

Hey Tipsy, I have a bunch of commits ready to fulfill this feature request.... but I'm not really sure how to create a remote branch, so I can push and do a PR, am I looking at this the wrong way?

Fork the repo, create a branch and publish it. Once you've done this, a "create PR" button will appear in the github web ui.

I think this was closed by #825 ?


List all public repositories missing

Hi,
I'm missing the list all public repositories in your API. Did I overlook it or is it really missing?
Regards Helmut

Seconded. Can't find it either.

Added: https://mikedeboer.github.io/node-github/#api-repos-getPublic


Unable to validate parameter due to ["should be string"]

Hello,
I am have implemented everything correctly and now trying to work some examples, I am making request and getting this error
2020-10-26T21:32:35.962Z - warn: [DiscoveryEndorsementHandler]: _build_endorse_group_member >> G0:0 - endorsement failed - Error: error in simulation: transaction returned with failure: Error: Unable to validate parameter due to ["should be string"] Failed to submit transaction: Error: Endorsement has failed after network.invoke  Error: Endorsement has failed
Idk why this happening, I successfully generated wallet for app-admin,
my config.json
{   "connection_file": "ibpConnection.json",   "appAdmin": "app-admin",   "appAdminSecret": "secret",   "orgMSPID": "org1msp",   "caName": "https://{secretCname}",   "userName": "V1",   "gatewayDiscovery": { "enabled": true, "asLocalhost": false } }
also when I made app-admin user in CA I added attributes also.
So I think problem is in contracts, I have tried to generate contracts correctly from VS code but exactly can't understand how to export, can someone link me correct way to export contracts correctly to upload on IBM platform later?

also getting this if helps someone
2020-10-26T22:46:55.964Z - error: [Channel.js]: Channel:channel1 received discovery error:failed constructing descriptor for chaincodes:<name:"_lifecycle" >


mergeSEs fixes

https://github.com/microbiome/mia/issues/326
As discussed in the issue, if there are equally named variables but their class differ, this leads to an error. Now it is handled by checking martching variables and merging them together only if their class match. Otherwise, the original variable name is dropped and e.g., in the case of character and numerical class, two new variables called original_name_class are created. This should be good enough fix.
https://github.com/microbiome/mia/issues/322
Additionally, now it is possible to merge multiple assays. However, all the assays must be specified; it is not possible to just specify assay_name = "all". I think this is ok, since there are multiple cases where merging assay is not wise (normalization over whole dataset for instance).

Yep this is good.
Re #322 perhaps function example could however show how to fetch the list of "all" assays and apply it in the merge case. The comments in the example could include a small word of advice for the novices to be cautious.


docs(operators): add fromPromise documentation

closes: #79

@btroncone @ashwin-sureshkumar last commit should fix both requested changes. Please take a look at it and let me know if there is something else I can fix.

@btroncone, @ashwin-sureshkumar, @sumitarora could you take another look at this pr to get this done?


v3.2.1 has a breaking change

Specifically, it uses the ?? operator, which doesn't work in node 12 (and breaks eslint-plugin-import tests).
It was added here: https://github.com/microsoft/node-jsonc-parser/pull/81#discussion_r1489833516
Please remove use of this operator and publish a v3.2.2?
(I'm happy to make a PR if that's needed)

ping @aeschli

We want to move forward and not commit to be backward compatible. We currently compile against es2020 and for that you need Node 14.
Node 12 has reached end of line status almost 2 years ago.
Is there maybe a packager that you can useto back-compile?

We actually switched to es2020 already for 3.2.0. This is documented in the [CHANGELOG}( https://github.com/microsoft/node-jsonc-parser/blob/main/CHANGELOG.md)
Maybe what should have happend is to add an engine property. I will add that ASAP.

ok, that’s still a breaking change in v3.2.0. You have to bump the major when you drop any platform/engine.


Race condition when builder attempts to find slugbuilder pods

git push was rejected because builder was unable to watch for pod events.
Logs available at https://gist.github.com/slack/f5056d6abe5b17e2c69d

This bit me for a number of deploys off the bat but is now working as intended.
We should probably retry on 404 for a pod that we know should exist.

have to do appropriate changes in builder https://github.com/deis/workflow/pull/346

@smothiki @slack I'm confused by the scope of this issue. The issue in deis/workflow#346 is unrelated to the race condition that's described here.
Also, #166 seems to solve the race condition described here. Can anyone confirm?

Yeah, I don't think deis/workflow#346 is related. I haven't tested since #166 was merged. I'll test with current v2-beta images and see what falls out.

Deployed deis-dev images as of today and was unable to repo attempting to stream logs issue after 7 deploys. I'll go ahead and close!

@slack I'm ok with leaving this closed for now, but it's a race so it could still be around. If you see failures again please reopen or file a new issue.

Certainly, I'll pipe up if I see it again!

Thanks. And I believe that @gabrtv saw an error that looked suspiciously like a race yesterday. I don't recall details, and couldn't tell at the time if a race was definitely to blame. Anyway, given our polling interval the race is unlikely but I have a prototype here that, in theory, would remove any potential race.

This bad larry popped up again:
k:beef example-go [master]$ git commit -m "Bump" --allow-empty && git push deis master
[master c0d91cd] Bump
Warning: Permanently added the RSA host key for IP address '[<IP_ADDRESS>]:2222' to the list of known hosts.
Counting objects: 98, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (93/93), done.
Writing objects: 100% (98/98), 19.29 KiB | 0 bytes/s, done.
Total 98 (delta 53), reused 0 (delta 0)
remote: ---> 2016/02/22 20:39:24 Error running git receive hook [watching events for builder pod startup (pods "slugbuild-earthy-instinct-c0d91cd9-cd33644e" not found)]
Starting build... but first, coffee!
To ssh://git@deis.beef.slack.io:2222/earthy-instinct.git
 * [new branch]      master -> master
k:beef example-go [master]$

I'm running into this as well on the new staging-2 cluster.

this is definitely reproducible on the staging-2 cluster

I'm seeing this > 50% of the time when running the e2e tests locally.

closing this in favor of https://github.com/deis/builder/pull/198.
Please feel free to reopen if issue is not fixed


Empty string host returned for trailing whitepace

This might be new?
Have a config with trailing whitespace on the Host line like
Host penlv
  HostName penlv-devbox
  User penlv

I get an array for "value" which includes an empty string like this:

It's an overlooked old issue. I'll fix right away

v4.0.1 released @roblourens


Delete Truthfacts

The last Truthfacts strip was released 2016-12-30, see https://wumo.com/truthfacts

Wrong duplicate of https://github.com/tardypad/sailfishos-daily-comics/pull/135


Tensorboard

I built Tensorflow 1.6.0 for arm (Odroid UX4Q) successfully. However, when I am running:
pip2 install --install-option="--prefix=$prefix" /tmp/tensorflow_pkg/tensorflow-1.6.0-cp27-cp27mu-linux_armv7l.whl  --upgrade --ignore-installed
I am getting the following error message:
 Could not find a version that satisfies the requirement tensorboard<1.7.0,>=1.6.0 (from tensorflow==1.6.0) (from versions: ) No matching distribution found for tensorboard<1.7.0,>=1.6.0 (from tensorflow==1.6.0)
Which seems reasonable since there is no tensorboard pip package for arm... Is there a workaround for it?
Thanks!

HI, install the pip without dependencies:
pip install /tmp/tensorflow_pkg/tensorflow-1.6.0-cp27-cp27mu-linux_armv7l.whl --no-deps

And install the deps manually, except Tensorboard?


Do not force puppet:/// schema resource

Related to Issue #462

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

I already signed CLA. Please let me know if I need to do something else.
Cheers

I made a new push with this change. It's ok or should I close this PR and made a new one?
Thanks @electrical

This is fine, thank you!
as soon as Jenkins is happy i'll merge it

jenkins, test it

@abednarik would you be able to squash your commits into a single commit? thanks!

Sure, let me see how can I do that :)
El nov. 9, 2015 7:33 AM, "Richard Pijnenburg"<EMAIL_ADDRESS>escribió:

@abednarik https://github.com/abednarik would you be able to squash
your commits into a single commit? thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/elastic/puppet-elasticsearch/pull/470#issuecomment-155023934
.

Can you please review @electrical ? I made a rebase and then squash my commits into a single one. It's the first time i made this, so maybe wrong. I also notice that i didn't create a feature branch, which is not recommended :(

Looks good so far. I'll let Jenkins do its thing and merge it when green.
Again thank you for the contribution!

jenkins, test it

Finally!! :)

Thank you for your contribution :)


Make all stories self-canonical

This is an attempt to arrange for all the AMP Story examples to have a self-referential <link rel=canonical> as required.
That is, a URL such as https://ampbyexample.com/stories/introduction/amp_story_hello_world/preview/embed/ should have a <link rel=canonical> of
<link rel=canonical href=https://ampbyexample.com/stories/introduction/amp_story_hello_world/preview/embed/>

Hm, not sure about this approach as it means that the documented samples no longer appear in search (and the stories don't link back to the documented sample).
How about using a relative path instead? <link rel=canonical href=".">? [Search](<link rel=canonical href=) supports it.

How about this approach? #1490


Use constant address space for SPIR-V parameters when generating tessellation control shader.

In MoltenVK, MVKCommandEncoder::setComputeBytes can call either setBytes or setBuffer, but Metal only allows setBytes to be used with the constant address space. As a small read-only buffer, this should be a safe change for both cases.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Only one problem: The constant address space imposes an alignment requirement of 256 bytes. For an indirect draw, this buffer comes from the indirect draw parameters, which we can't guarantee will be 256-byte aligned. I think this needs to be fixed MoltenVK-side.

I have a number of other fixes related to tessellation in MoltenVK and a few bug reports for issues I couldn't solve, I'll file that bug report there too and leave this open for now.

@cdavis5e Do you have documentation on this 256-byte requirement? I can't find it in the MSL spec nor MTLComputeCommandEncoder documentation.

@cdavis5e Do you have documentation on this 256-byte requirement? I can't find it in the MSL spec nor MTLComputeCommandEncoder documentation.

From -[MTLComputeCommandEncoder setBuffer:atOffset:]:

For buffers in the constant address space, the offset must be aligned to 256 bytes in macOS.

So iOS does not have this restriction, but macOS does.

Okay, noted, thanks!

My primary concern here is alignment indeed. I'll let @cdavis5e have the final word on this PR.

The pull request has been updated to fix the tests for this change.

So, I've thought about this, and I think what we should do is: the address space should be changed to constant, but only for tessellation control shaders. MoltenVK always uses setComputeBytes() here, even in indirect draws, so we don't have the issue with buffer alignment here.
But for vertex shaders, we need to keep using the device AS.

This change is indeed only for tessellation control shaders. However MoltenVK doesn't strictly use setComputeBytes: if dynamic Metal buffer feature isn't enabled, it falls back on setComputeBuffer.

This change is indeed only for tessellation control shaders.

Are you sure? The changes to the tests indicate that it also affects vertex shaders.

However MoltenVK doesn't strictly use setComputeBytes: if dynamic Metal buffer feature isn't enabled, it falls back on setComputeBuffer.

Yes, but in that case it gets a temporary buffer and ensures that the buffer offset is aligned correctly for the constant AS.

Yes, you're right. In CompilerMSL::entry_point_args_builtin and MVKCmdDrawIndirect::encode. What are the performance characteristics of device vs constant? My intuition (OpenCL background) suggests that, for these buffers, constant should be preferred, but as an array of uint32_ts that would be rather wasteful in memory.
I'll update to your suggestion and only use constant in the tessellation control case.

Hm, nope, that won't do either. The non-indirect case still uses setVertexBytes and crashes with device.

KhronosGroup/MoltenVK#572 should fix that.

Updated pull request for merged KhronosGroup/MoltenVK#572.

With KhronosGroup/MoltenVK#572 merged, is this clear to merge in now? MoltenVK tessellation is still broken without this commit.

I have no objections. @HansKristian-Work?

Then I have none either. Merged. Thanks!


Split attrs docs

🚀 Pull Request
Description

This is very bare, but as @pp-mo has pointed out there just isn't currently an appropriate place to discuss NetCDF I/O. Raising the profile any further would disproportionately focus on attribute handling and read very strangely. I've made a # TODO: as a placeholder and should probably create an issue tomorrow.

Consult Iris pull request check list

Closes #4989


ngx-Formly with PrimeNG - Apply CSS at "formly-field-primeng-radio"

Formly with PrimeNG - CSS
Question
I am trying to apply CSS class at “formly-field-primeng-radio” level within formly so that it will take care of margins which is defined in CSS Class.
Is there any way to apply CSS i.e. apply CSS Class at formly-field-primeng-radio level. Example as below.
Actual :
Expected : <formly-field-primeng-radio class=”ut-align-right label__block-margin”>
NGX-Formly with PrimeNG : Primeng: https://stackblitz.com/edit/ngx-formly-ui-primeng

see https://github.com/ngx-formly/ngx-formly/issues/1494#issuecomment-551655615

I think it does but somehow in an indirect way https://stackblitz.com/edit/ngx-formly-primeng-integration-uvj4wf.
Another approach is to create a custom field type that overrides the original type which gives you total control.


Upgrade @rollup/plugin-node-resolve to 13.0.6

Signed-off-by: Julio Zynger<EMAIL_ADDRESS>Hey, I just made a Pull Request!

Fixes https://github.com/backstage/backstage/issues/12219
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@Rugvip Fixed, thanks for the comment.
Would we be able to ship a 1.3.1 release including this patch?

There will be a prerelease on Tuesday, but won't cut a patch release as this doesn't affect newly created projects and can be worked around in existing projects.

@Rugvip Can you please describe exactly what the workaround is? We have held on to the 1.3.0 bump and now tried the 1.4.0 release just to hit the same wall. We're running @backstage/cli 0.18.0 but still see the following error when running yarn run build:
Error: (plugin commonjs) Error: Insufficient @rollup/plugin-node-resolve version: "@rollup/plugin-commonjs" requires at least<EMAIL_ADDRESS>

There will be a prerelease on Tuesday, but won't cut a patch release as this doesn't affect newly created projects and can be worked around in existing projects.

@Rugvip Can you please describe exactly what the workaround is? We have held on to the 1.3.0 bump and now tried the 1.4.0 release just to hit the same wall. We're running @backstage/cli 0.18.0 but still see the following error when running yarn run build:
Error: (plugin commonjs) Error: Insufficient @rollup/plugin-node-resolve version: "@rollup/plugin-commonjs" requires at least<EMAIL_ADDRESS>
Setting a package resolution in the root package.json did not help:
  "resolutions": {
    "react": "^17",
    "react-dom": "^17",
    "@rollup/plugin-node-resolve": "13.0.6",
    "@hot-loader/react-dom": "^17",
    "@types/react": "^17",
    "@types/react-dom": "^17"
  },

@julioz we faced the same issue as well still in @backstage/cli 0.18.0 whereas on a fresh npx @backstage/create-app it works fine.
Executing
rm -rf node_modules
rm yarn.lock
yarn install

solved the issue.

We've spent significant amount of time debugging the issue, and indeed tried setting up a new app with @backstage/create-app; that also works fine.
We finally figured out what the issue was in our setup; here we use npm instead of yarn but backstage heavily relies on the latter. We've been referencing two lockfiles (package-lock.json and yarn.lock) for some time, and the issue was arising from a circular dependency between the two. When yarn install ran, it would update one of the lockfiles but not the other and npm install would do the opposite. The solution was to rework our setup to get rid of the npm dependency altogether and rely fully on yarn (to follow Backstage's setup) even though that means getting out of our company 'golden path' for web development.


Auto jumpbug using engine prediction

this is very borked, do not merge

dont know how to make it better but ill keep trying, did all sorts of weird combinations already. current one seems to be the best yet still broken

closed until i can make it better

What's jump bug?

What's jump bug?

this

What's jump bug?

this

Thanks


Wrong line length parsing for template string

Hi there,
I just look into allow_wrap_or_preserved_newline function
The proposed line length is calculated like this
var proposed_line_length = output.current_line.get_character_count() + current_token.text.length +
                    (output.space_before_token ? 1 : 0);

but for ES2015 template string current_token can contains newline
thus proposed_line_length report the wrong value span multiple lines.
This make the formatted code break in case similar to this one:
let testTable = function() {
    return `CREATE TABLE IF NOT EXISTS some_table (
id INT UNSIGNED NOT NULL AUTO_INCREMENT,
label VARCHAR(64) NOT NULL,
PRIMARY KEY (id)
) ENGINE=Aria DEFAULT CHARSET ascii;`;
};

IMO we should preserve (at least not wrap) anything around token that span multiple lines.
There is nothing much formatter can do with the template string so just leave it to user decision is good enough.
For now I guess I will simply use parentheses as temporary solution for text wrapping issue.
However, this case just uncover breaking condition that make text wrap after return statement.
You would better keep that in your radar.

There's combination of issues.
First, If there wasn't a newline between return and the next token, a newline should not be added.
Second, the newline calculation doesn't have a concept of multi-line tokens.
The first problem is a bug that must be fixed.  The second is an enhancement.


about thread_axis

How OpenCL know dim parameters when call clEnqueueDNRangeKernel?
How TVM generate thread_aix?
Thanks
Yuanbo

We explicitly bind axis to thread_axis. e.g.
bx, tx = s[C].split(some_axis, 8)
s[C].bind(bx, tvm.thread_axis("blockIdx.x"))
s[C].bind(tx, tvm.thread_axis("threadIdx.x"))

The lengths of bx, tx can be inferred during lowering, which determine the dim parameters.

How will bx, tx  be inferred to the number of block or thread?

bx, and tx will be inferred depending on the extent of the loop axis that it was bound to. For example, if a loop nest has 16 outer loop iterations and 16 inner loop iterations, and the outer loop axis is bound to say threadIdx.y and the inner loop axis is bound to say threadIdx.x, then each thread block will have 16*16 = 256 threads.
The same reasoning can be applied for blockIdx and the number of blocks in a grid.

@eqy
Why bx's extent is 64? is bx 256/8 = 32, right?

Yes, my mistake :)
On Fri, Mar 16, 2018 at 1:16 AM Yuanbo Ye<EMAIL_ADDRESS>wrote:

@eqy https://github.com/eqy
Why bx's extent is 64? is bx 256/8 = 32, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/tvm/issues/1005#issuecomment-373636941, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACIsgA2_ZC4s67BYh1W8TGZSkI-rVTVrks5te3TKgaJpZM4SrhRM
.