Unregister Purescript Electron

I’m taking over a package that the owner stopped developing on. I talked to the owner to have his package unregistered on bower to upload mine, and he did so. The problem that I have is that when I register my package, the registry still show information of the previous package. I am able to successfully register my package, yet when I want to download it using bower, the previous package is downloaded instead.
Can you unregister purescript-electron, so that I can upload my package?

If you still want to unregister / modify this package you can send PR against this repository that modifies db/packages.json file. Please include proof that you are owner of this package. Please also mind that even if we remove/modify entry in bower registry, bower clients can have cache saved which needs to be cleaned with bower cache clean for each user. At this point it's better to leave registry entries unmodified, they won't hurt anyone.


Add workflow for scraping courses

This PR adds a mechanism to fetch and parse the course list from https://academy.zerotomastery.io/courses
It checks on a daily schedule but the workflow also has a manual trigger so you could run it on demand as well. If changes are found, it will open a PR.

[!TIP]
...it will open a PR
It may be more convenient to have it just commit back to main but maybe you want to run it a few times to make sure you're confident in it. Then it's only a few updates to the workflow file to change the logic.

Output
Here's a manual run: https://github.com/KevinBatdorf/ztm-extension/actions/runs/9762033440/job/26944460686
PR it opened: https://github.com/KevinBatdorf/ztm-extension/pull/9
File output: https://github.com/KevinBatdorf/ztm-extension/blob/main/course-details.json
New:
{
  "id": "1806594",
  "name": "Advanced Excel Bootcamp: Data Analytics and Business Intelligence",
  "description": "Master Excel's built-in power tools, including Power Query, Power Pivot Tables, and DAX.",
  "link": "https://zerotomastery.io/courses/business-intelligence-course",
  "author": "Travis Cuzick",
  "thumbnail": "https://process.fs.teachablecdn.com/ADNupMnWyR7kCWRvm76Laz/resize=width:705/https://cdn.filestackcontent.com/Ar6Ma3YcSZuHGE76b2TL"
}

Before:
{
  "name": "Advanced Excel Bootcamp: Data Analytics and Business Intelligence",
  "link": "https://zerotomastery.io/courses/business-intelligence-course/"
}

Comments
The IDs appear to be in order from oldest course to newest, so this would also allow for sorting (as mentioned here https://github.com/sithu-khant/ztm-extension/issues/40) along with a custom UI (just overtake the dom and render something new).
Some other ideas could be to parse the course descriptions, lesson titles, (transcripts??), then create a local embeddings database and make it easy to do some semantic searches for a topic you're interested in (e.g. "What are queues?").
Test
To test it now you need Deno, and you can just run:
deno run --allow-net --allow-write .github/scripts/scrape-courses.ts

Let me know if I missed anything

This is a great PR... thank you for putting in the work and writing great detailed information about this PR. Curious to hear what @sithu-khant thinks. Also love the use Deno ;)
Would be a great addition.

@KevinBatdorf the scrapper is scraping the pages those don't exist.
For example, ZTM Campus Event Recordings linked https://zerotomastery.io/courses/ztm-campus-event-recordings  don't exist in academy page. It will return a 404 page if you click the course detail icon. There are also for some courses those don't exist in academy page.
Could you fix that? Don't scrap if there isn't a real course page.
I don't want to show the course detail icon if there isn't a real course description page. That is what the course detail feature does.

Makes sense. Would you be able to support it if link is set to null and it looks like this?
  {
    "id": "2450909",
    "name": "ZTM Campus Event Recordings",
    "description": "Listen to recordings of past Campus events. A great way to keep learning while doing chores or going for a walk!",
    "link": null,
    "author": "Zero To Mastery Instructor Team",
    "thumbnail": "https://process.fs.teachablecdn.com/ADNupMnWyR7kCWRvm76Laz/resize=width:705/https://cdn.filestackcontent.com/yeKu0AUzR6S7BuwqhKcj"
  }

Could you just remove the "link" key? If you can please remove the whole course list if link don't exist. I hope you can skip adding that by if else statement.

btw, will this scrapper overwrite the whole file or just add the latest course information at the end?
What if we want to update that JSON file manually?

I am sorry, I accidentally closed this. Now it is alive again.

What if we want to update that JSON file manually?

It will overwrite the whole thing. We could support manual overrides, but then it may result in outdated data if it's not maintained. What do you think?

Could you just remove the "link" key?

We could and it would work the same when consuming it, but is there a reason? It might be less readable if each entry doesn't follow a predictable schema. You might wonder if there was a bug. Let me know and I'm ok changing it though.

If you can please remove the whole course list if link don't exist. I hope you can skip adding that by if else statement.

Do you think course could remain regardless? For example, this is for the ZTM Campus Event Recordings https://academy.zerotomastery.io/courses/enrolled/2450909 which can be built using the course id
So if search were to be implimented, I'd expect that to show up.
To remove them from details, I think you'd just need to add .filter((res) => res.link) to this line (https://github.com/sithu-khant/ztm-extension/blob/main/scripts/ztm-course-details.js#L98) ? I could add that change too.

Actually, this is the check point codes -> https://github.com/sithu-khant/ztm-extension/blob/1be25abcc7dd436988df8770892d5d1c8da5b5a8/scripts/ztm-course-details.js#L121C17-L127C18
But it can easily update to if (getCourseDetailsAnchor.href !== "null") { from if (!getCourseDetailsAnchor.href) {. Could you update that from your side?

I noticed quite a few of the links actualy arent pointing to the proper course page. I think it's just outdated on that course listing page.
What I'll do is try to search this course page which has links to the details page. Also has a bit of other useful informaiton too
https://zerotomastery.io/courses/
I'll update that file too to remove entries without links from the details view.
I'll follow up in a day or so

I updated this now if you can take a look. I've checked the URLs and they all seem propery linked now too.
There ended up being a few of inconsistencies between the courses depending on where they are listed that made this a bit complicated, but I think I came up with a consistent solution.
Some courses have different names (e.g. prefixed with "The") and different URL patterns (some use course id, some use a slug), and some have minor grammer inconsistencies (e.g. oxford comma in one title on one page, but not the other 😅)
So here's the flow I landed on.

Check the course description page for a course id match
Check for an exact name match
Split the course name into pieces and just look for a 70% word overlap

Here's the file list if you can check it out now: https://github.com/KevinBatdorf/ztm-extension/blob/18e1ecaa63c08bd602f977a664e1108ef450147e/course-details.json
And the PR the bot opened: https://github.com/KevinBatdorf/ztm-extension/pull/12
I also filtered out the cards with no links in the details script within the extension
Happy to make changes of course so let me know.

@KevinBatdorf did you test the extension with your updated code locally? Is everything okay? The important thing is all the courses must have Course Details icon if they have real description links.

So I tested from this page here: https://academy.zerotomastery.io/courses/
Similar to the video, I clicked on every course link to confirm they went to the corresponnding details page. All good.
https://github.com/sithu-khant/ztm-extension/assets/1478421/6b90c08a-56c7-4f46-9958-72264c7b10b1
Also checked that the courses that shouldn't have a button, don't. All good there too (as far as I can tell)

This looks great. Great job @KevinBatdorf 👍
So we are all on the same page: once this is merged, the only thing this adds, is it creates a new PR whenever a new course is added to ZTM /courses page. This PR can then be reviewed for any issues, and then merged with any new course launch.
Once merged, we can then submit the new extension to the Chrome store.
If you all give me the 👍 to this comment, @sithu65 feel free to merge this.

Well done, @KevinBatdorf. Thanks for your contributions to the ZTM Extension. I hope you show up again with more brilliant ideas.
I merged it now.

Sure thing! Have a few fun and maybe useful ideas. As for this PR, the workflow runs once a day at 6am UTC, so in about 5-6 hours from now. Otherwise you can manually trigger it here any time too.
https://github.com/sithu-khant/ztm-extension/actions/workflows/scrape-courses.yml
If any issues come up with the workflow or PR I might not get a notification, but feel free to dm me on discord (kev_xb) or tag me here too

So, this scrapper is going to create a new pull request once a day? So, if we didn't merge those, there will be a ton of pull request?
How about scrapping can happen once a day, but for creating pull request, only if the course-details.json got changed?

No, it's smart enough to only open one at a time, and if there are no changes (you merged it in), then no new PR too

So, it will only open a new PR until we merge the updated one?

If there's an open PR it won't open a second PR.
And if the courses list updates again after that PR is open (e.g. you keep it open for a month and new courses are added), the PR will be stale. In that case, the workflow will auto update the PR and not open a new PR.
The PR workflow actually has a breakdown of the logic it uses here: https://github.com/peter-evans/create-pull-request?tab=readme-ov-file#action-behaviour

Cool! that is excellent.

The run failed for what looks to be a permissions issue from the gh action bot trying to make the PR.
You might need to enable something on the repo to let the bot open PRs. I don't remember doing that but maybe I have a setting elsewhere that it inherits from.
Can you check out this comment here? https://github.com/peter-evans/create-pull-request/issues/2767#issuecomment-1953810837

I dug a little deeper on this and the action will fail until until the permissions are set up to allow the action to make the commit.
You should be able to update that here:
https://github.com/sithu-khant/ztm-extension/settings/actions
And it looks like this:

Hi there @KevinBatdorf, I did all the steps you suggested. The scrapper is still getting fails.  So, I added you as collaborator. Please accept it and let's see how it goes.

Looks like setting the permissions explicitly worked!
https://github.com/sithu-khant/ztm-extension/blob/main/.github/workflows/scrape-courses.yml#L10


Is there human understandable example how to use it?

Ok. This example from Docs make no sense for me. Sorry.
<Motion :value="offset" tag="div">
  <div slot-scope="props" :style="{ transform: `translateX(${props.value}px)` }">

</Motion>
// in the component
this.offset = 200

What component you are talking about?
What is this.offset?
What is props?

There are other examples with documentation at https://posva.net/vue-motion/#/home
But please, be more respectful towards wy work next time, thanks

@posva I am respectful to your work, it's just it's painful to see that not many people can consume the results of your work, because of documentation.


Logging system improvements

replace msg() with a proper logging system (Tattletale.js?)
report error stack traces somewhere (Papertrail?)
send server logs too (winston + Papertrail?)

see also https://trackjs.com/ and http://newrelic.com/sp/browser-monitoring

and http://help.papertrailapp.com/kb/configuration/configuring-centralized-logging-from-javascript/


setup-env.sh assumes the 'gh' CLI is authenticated

When this script runs, if the gh CLI exists, it uses it to try to get the github username and current repository name.
It does an error check to make sure that gh exists, but if it does exist, it doesn't check to see if the user is authenticated to github for the CLI.

alanpoole@penguin:~/gke-github-deployment/gke-github-deployment$ gh repo view alanpoole/gke-github-deployment --json url
{
  "url": "https://github.com/alanpoole/gke-github-deployment"
}
alanpoole@penguin:~/gke-github-deployment/gke-github-deployment$ gh repo view github.com/GoogleCloudPlatform --json url
GraphQL: Could not resolve to a Repository with the name 'github.com/GoogleCloudPlatform'. (repository)
alanpoole@penguin:~/gke-github-deployment/gke-github-deployment$


Massive filesize

This package just added 600kb to my production bundle. I actually really like this lib, but the filesize could be a dealbreaker for me. I tried not importing styles but filesize is still the same. Right now my only workaround is to include react-syntax-highlighter in my vendor bundle and exclude it from the main app bundle.
https://gyazo.com/c9bbe6b0f9fd5917c3abb020ce980c14
The only comfort I have from this is that it's down to 200+kb after gzipped.

yeah, I've been trying to think a lot about this problem. It's mostly due to the way we handle the lowlight import. It seems clunky to have the user register a language by reaching into the lowlight internals but that would massively cut filesize, perhaps we could offer a light build. would that interest you?

The package looks awesome and exactly what I'm looking for to use in production, but the filesize is a deal breaker, I would be fine with reaching into internals to register a language or a light build.

@goozo sounds good, I'll try to get it released this weekend.

@conorhastings yes that would be nice thanks!

@gerardmrk @goozo sorry for the delay, busy with work. See this commit https://github.com/conorhastings/react-syntax-highlighter/commit/90607dbb023becb7a8d816f3e433366acef47e46 (published as v2.2.0) and see if that works for you! I tried it ad able to see a 10x drop in package size for something I am using this for!


[router] Skip registering router metrics for system stores

Do not register router metrics for system stores

The system stores are mostly read from controller and their router metrics are hardly useful for debugging system store issues as most of the time system store issues stems from write path to them. But nonetheless for each user store router emits 2x the number of system store metrics, one for its DVC push status and one for meta store system stores. This PR will stop emitting system store router metrics thus cutting down router metric count by 1/3.
How was this PR tested?

GHCI
Does this PR introduce any user-facing changes?

[x] No. You can skip the rest of this section.
[ ] Yes. Make sure to explain your proposed changes and call out the behavior change.

Hi Sourav,
I feel like this change is a bit heavy, and I wonder if we could do it a bit differently. It would be nice if we could maintain immutability of the state, and also not need all these boilerplate null checks in all the record functions. How about the following idea:

We add a bit of static state which is just a Sensor instance coming out of a throwaway MetricsRepository (this is important, since using the main MR results in the metrics getting published, which is what this PR wants to avoid...).
At the start of the constructor, we populate this.isSystemStore as you're doing here.
We override the registerSensor function along the lines of:

  @Override
  protected Sensor registerSensor(String sensorName, MeasurableStat... stats) {
    if (this.isSystemStore) {
      return // the statically defined Sensor mentioned in 1.
    }
    return super.registerSensor(sensorName, stats);
  }

In this way, I think the constructor need not have the big if, the state can all remain final, and the record functions would be unchanged. It might also help the diffCoverage check ;) ...

Thanks for the suggestion, I thought of something similar, but balked at the idea of creating a dummy sensor. But using a dummy MR to register the sensor to the metrics are not published is a good idea, I will update the PR.

I thought of something similar, but balked at the idea of creating a dummy sensor.

Another variation would be to register not a dummy sensor, but to have the overridden function exclude the user store name, and rather use just the system store name, when it encounters a system store. This way, all the individual system stores would funnel their metrics into one consolidated metric per system store type. WDYT of this?

I thought of something similar, but balked at the idea of creating a dummy sensor.

Another variation would be to register not a dummy sensor, but to have the overridden function exclude the user store name, and rather use just the system store name, when it encounters a system store. This way, all the individual system stores would funnel their metrics into one consolidated metric per system store type. WDYT of this?

Having consolidated metrics make sense for some time type of sensors like count/number, but for various latency metric will it be useful ? Even if see high or aberrant value of some consolidated metric, can we debug them ?

Having consolidated metrics make sense for some time type of sensors like count/number, but for various latency metric will it be useful ? Even if see high or aberrant value of some consolidated metric, can we debug them ?

I guess that would depend on a case by case basis. I am not sure how often it would be useful or not.

Having consolidated metrics make sense for some time type of sensors like count/number, but for various latency metric will it be useful ? Even if see high or aberrant value of some consolidated metric, can we debug them ?

I guess that would depend on a case by case basis. I am not sure how often it would be useful or not.

Right, I would rather skip it altogether. I am ok with keeping per system store type metrics as well, just not sure it will be useful or not. Let me know whats your preference


Issues with openshift installation

In the openshift installation there are couple of things i am seeing issues. I have Openshift V4 -

The openshift install document says - oc create -f deploy/crds/argoproj_v1alpha1_argocd_crd.yaml however file argoproj_v1alpha1_argocd_crd.yaml doesnt exist.
The operator install is erroring out with below message -
The operator install is erroring out with below message -
oc logs argocd-operator-769676587-l6nwl
....
....
{"level":"info","ts":1581389982.2209306,"logger":"cmd","msg":"Registering Components."}
{"level":"info","ts":1581389982.2213113,"logger":"controller-runtime.controller","msg":"Starting EventSource","controller":"argocd-controller","source":"kind source: /, Kind="}
{"level":"error","ts":1581389985.7235928,"logger":"controller-runtime.source","msg":"if kind is a CRD, it should be installed before calling Start","kind":"ArgoCD.argoproj.io","error":"no matches for kind "ArgoCD" in version "argoproj.io/v1alpha1"","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/home/john/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128\nsigs.k8s.io/controller-runtime/pkg/source.(*Kind).Start\n\t/home/john/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.3.0/pkg/source/source.go:88\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Watch\n\t/home/john/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.3.0/pkg/internal/controller/controller.go:122\ngithub.com/argoproj-labs/argocd-operator/pkg/controller/argocd.watchResources\n\targocd-operator/pkg/controller/argocd/util.go:400\ngithub.com/argoproj-labs/argocd-operator/pkg/controller/argocd.add\n\targocd-operator/pkg/controller/argocd/argocd_controller.go:58\ngithub.com/argoproj-labs/argocd-operator/pkg/controller/argocd.Add\n\targocd-operator/pkg/controller/argocd/argocd_controller.go:46\ngithub.com/argoproj-labs/argocd-operator/pkg/controller.AddToManager\n\targocd-operator/pkg/controller/controller.go:27\nmain.main\n\targocd-operator/cmd/manager/main.go:152\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:203"}
{"level":"error","ts":1581389985.7236865,"logger":"cmd","msg":"","error":"no matches for kind "ArgoCD" in version "argoproj.io/v1alpha1"","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/home/john/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128\nmain.main\n\targocd-operator/cmd/manager/main.go:153\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:203"}

Please let me know if any additional info is needed,

I will have a look at this shortly @JTG2020, I think just have some old file names in there with the recent refactoring that I did. Thanks for the feedback!

@JTG2020 I believe that I fixed the issue with the document that you referenced. I still had the old CRD filename in the documentation. I ran through that install doc and it worked for me after I made the change. The update should be available in master.

@JTG2020, Can you confirm, that this is fixed for you in the latest documentation?
https://argocd-operator.readthedocs.io/en/latest/install/openshift/#crds
Thanks!

@jmckind Thank you. I'll test this out and provide you the feedback.


🎨Enabled more detailed error message on creating insecure passwords

no issue
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!

[x] There's a clear use-case for this code change, explained below:

Ghost's 'Sorry, you cannot use an insecure password.' message has been quite confusing as Ghost tries to enforce a much stricter password rule than others. In my case, I have a long password which got rejected by Ghost and eventually found out it was the keyword 'ghost'. This commit points out what rule the password is conflicting with.

[x] Commit message has a short title & references relevant issues
[x] The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

🤖 Generated by Copilot at da4eda9
Enhanced password validation feedback in the admin app. The file password.js now shows more informative error messages when the password does not meet the security requirements.

I like this change. It's important that user's understand an error message well enough to know how they might fix the related issue.

This tripped me up when trying to use Ghost for the first time, it kept rejecting my (very long/complex) passwords because they contained the string ghost and it took a lot of trial-and-error to figure out what was going on. It was a really bad first impression.
Personally I would just remove that check altogether, but this change would be a huge improvement. What needs to happen to get this merged? Looks like the tests haven't run, is there some way to re-trigger that?


Cursor not visible when same color behind

Create a new Black + White Cursor visible on all surfaces

Corrected on commit https://github.com/Sygmei/ObEngine/commit/993bd0785e028bad8a4cea93e1be974f62a473b5


[Transaction] Fix broker init transaction related topic.

Motivation
now, transaction coordinator assign topic and pending ack and transaction log will init persistent topic when namespace unload, so we should load namespace bundle can't init the above topic.
implement
load namespace bundle filter related managedLedger topic.
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

@congbobo184 does this affect docs?

@eolivelli  fix your comment. please review again. thanks.

@congbobo184 does this affect docs?

don't need.


THORN-1531: Following instructions at wildfly-swarm-example/ribbon-co…

…nsul doesn't yield desirable result.
Motivation
If you follow the instructions on the ribbon consul examples it won't work because topology connector will try to advertise <IP_ADDRESS>: to consul - which is invalid. You need to supply a valid ip address for swarm.bind.address - that should be mentioned in the readme.
Also the examples still use Main class which is deprecated..
Modifications
Changed the readme to reflect the necessary command line parameter.
Result
Examples will be better understandable and runnable by newcomers.
NOTE:
This is a repeat of https://github.com/thorntail/thorntail-examples/pull/155 based on the current master.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

retest this please

add to whitelist


Java 9.4: Methods Overloading

Description
Add audio, documentation, and video regarding the Methods Overloading.

Location of File to be added
The files should be added inside the Methods Overloading  folder which is inside the Classes and Methods  folder present in the   Java  main folder.  The documentation file can be in the .md/.py/.ipynb format. Audio should be in .mp3 format and to be submitted through a Google drive link. Video can be in any format and should be submitted through a Google Drive link.
Note:

You are required to comment with \assign CONTENT_TYPE, so that other content types can be created at the same time.
Failing to comment in the above manner will lead to the removal of assignment from the issue even if the bot assigns.
You are required to do a PR within 7 days otherwise you will be unassigned and others will be assigned.
Issues will be assigned on a first come first serve basis.

Domain
Java_Domain
Type of Contribution
Audio, Video, Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

\assign Document

\assign document

\assign document

/assign Document

\assign document

/assign video

/assign Video

@Amrita-Mukherjee You have been assigned documentation. @khushali452 You have been assigned the video content.

\assign audio

@Sneha-0308 You have been assigned Audio. Saas to lelo behen , abhi to merge hu hai :laughing:

\assign Document

\assign document

/assign audio


windows: Crash when minimizing and restoring the window

This seems to be a problem only in virtual machines.


browserpass does not taltk to firefox 57

Issue description
With firefox-57, browserpass does not work properly. When clicking on the browserpass icon in firefox, browserpass states 'Error talking to browserpass'
Steps to reproduce

Install browserpass via programs.browserpass.enable = true
Install firefox via environment.systemPackages = with pkgs; [ firefox ]
Install browserpass browserplugin via firefox marketplace
Click on browserpass icon in firefox

Technical details

system: "x86_64-linux"
host os: Linux 4.14.9, NixOS, 17.09.2498.a9ffb7b0b5a (Hummingbird)
multi-user?: yes
sandbox: no
version: nix-env (Nix) 1.11.16
channels(root): "nixos-17.09.2498.a9ffb7b0b5a"
channels(wucke13): "nixpkgs-18.03pre121983.fd7953d95f4"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs

So this is still broken. Using browserpass-ce I get the suggestions but when clicking on them, it only displays "Error: An unexpected error occurred". Will this be fixed?

This works for me with firefox 59.0.1. IIUC, it won't work with firefox-bin.

$ firefox -v
Mozilla Firefox 59.0.2

Hmmh. Installed via environment.systemPackages = with pkgs; [ firefox ];. Using programs.browserpass.enable = true; for browserpass.

@wucke13 Do you have gpg in your system-packages or not?
I'd say that it shouldn't be needed, but might be needed.

If I look in the browserpass source, I found this function: https://github.com/dannyvankooten/browserpass/blob/4ca5c7c0d557f4aece063da54683eb04436d59be/browserpass.go#L135-L155
Which seems to be the one that failed. It's purpose seems to be to find a gpg binary. But it fails since it's not in your environment.
If I look in our package for browserpass https://github.com/NixOS/nixpkgs/blob/fbac1cbc06568380b538e81546e9d3b1715cab14/pkgs/tools/security/browserpass/default.nix -- I don't see that we patch the path to the gpg binary, which means that it must exist in the system environment for browserpass to find it.
A temporary fix for you would be to add it to your system packages, but in reality browserpass should be patched with our path to gpg.

The temporary fix does work for me. Closing since you started a PR on this. Great thanks!


output length mismatch and no attr

for op:
input: "conv1"
input: "Pad_pads"
input: "Pad_value"
output: "legacy_padded_tensor"
name: "Pad"
op_type: "Pad"
domain: ""
Below assertion fails:
outputs = xf_operators[op.op_type](op, graph, tensors, model.graph.initializer)
if not isinstance(outputs, list):
outputs = [outputs]
assert len(outputs) == len(op.output), "Number of output tensors mismatch"
and
def _pad(op, graph, tensors, initializer):
inputs = _get_inputs(op, graph, tensors, initializer)
attrs = _parse_attribute(op.attribute)
# Currently treat pad as a no op
assert sum(attrs['pads']) == 0
return inputs
Because no attrs pads in this op

@OuHangKresnik I pushed a temporary fix for this. The output shape of Pad depends on the second input tensor, so we will need the shape information from the ONNX runtime to calculate the exact output shape (which is a TODO item once we have the ONNX support).


reintroduce binary compatabilty lost in #303

alternative to #307 proposed by @jglick

[ ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[ ] Ensure that the pull request title represents the desired changelog entry
[ ] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Does it work?

yes


Add converter from Pascal VOC to Weed COCO

A first draft. Not fully tested.
Fixes #33

I can now run the following:
python conversion_tools/voc_to_json/voc_to_json.py --voc-dir /Volumes/research-data/PRJ-iweeds/Narrabri/artificial_illumination/wheat/20190728_Z16/VOC --image-dir /Volumes/research-data/PRJ-iweeds/Narrabri/artificial_illumination/wheat/20190728_Z16/images --agcontext /Volumes/research-data/PRJ-iweeds/agcontext-junk-example.yaml  -o /tmp/coco_from_voc-test.json
python conversion_tools/draft\ export\ to\ elastic.py --thumbnail-dir artificial < /tmp/coco_from_voc-test.json| curl -X POST localhost:9200/_bulk  -H 'Content-Type: application/json' --data-binary @-

I can now run the following:
python conversion_tools/voc_to_json/voc_to_json.py --voc-dir /Volumes/research-data/PRJ-iweeds/Narrabri/artificial_illumination/wheat/20190728_Z16/VOC --image-dir /Volumes/research-data/PRJ-iweeds/Narrabri/artificial_illumination/wheat/20190728_Z16/images --agcontext /Volumes/research-data/PRJ-iweeds/agcontext-junk-example.yaml  -o /tmp/coco_from_voc-test.json
cat /tmp/coco_from_voc-test.json | python conversion_tools/draft\ export\ to\ elastic.py --thumbnail-dir artificial | curl -X POST localhost:9200/_bulk  -H 'Content-Type: application/json' --data-binary @-

I like this; it seems like a pretty clean and relatively straightforward process. It helps me imagine more of what our pipeline for user provided data might look like.

Writing well-tested code from scratch takes quite a lot of work! This is now ready for review.

Oh no! CI is using a recent beta version of black, which differs on how it formats weedcoco.utils!

I'll reopen this. Trying to revert the merge, I pushed the wrong parent, which closed this PR irreversibly, it seems.


[Bug]: Error on cluster startup

Environment

VerneMQ Version: 2.0.0
OS: official VerneMQ docker image
Cluster size/standalone: 2 node cluster

Current Behavior
During evaluation of the VerneMQ 2.0 docker image we observed some weird issues during cluster startup. We are running VerneMQ in K8S using the VerneMQ helm chart.
Assuming a clean cluster with no previous deployment, the cluster starts fine, but when redeploying again during pod rotation by the StatefulSet the first pod that gets terminated and started again fails for properly start with this message:
Runtime terminating during boot ({{badkey,{'VerneMQ@<IP_ADDRESS>',<<13,199,20,12,50,139,154,26,231,215,232,27,187,181,74,218,20,95,50,182>>}},[{erlang,map_get,[{'VerneMQ@<IP_ADDRESS>',<<13,199,20,12,50,139,154,26,231,215,232,27,187,181,74,218,20,95,50,182>>},#{}],[{error_info,#{module=>erl_erts_errors}}]},{vmq_swc_plugin,'-summary/1-lc$^1/1-1-',3,[{file,"/opt/vernemq/apps/vmq_swc/src/vmq_swc_plugin.erl"},{line,220}]},{vmq_swc_plugin,history,1,[{file,"/opt/vernemq/apps/vmq_swc/src/vmq_swc_plugin.erl"},{line,230}]},{vmq_swc_peer_service,attempt_join,1,[{file,"/opt/vernemq/apps/vmq_swc/src/vmq_swc_peer_service.erl"},{line,57}]},{vmq_server_cli,'-vmq_cluster_join_cmd/0-fun-1-',3,[{file,"/opt/vernemq/apps/vmq_server/src/vmq_server_cli.erl"},{line,516}]},{clique_command,run,1,[{file,"/opt/vernemq/_build/default/lib/clique/src/clique_command.erl"},{line,87}]},{vmq_server_cli,command,2,[{file,"/opt/vernemq/apps/vmq_server/src/vmq_server_cli.erl"},{line,45}]},{erl_eval,do_apply,7,[{file,"erl_eval.erl"},{line,746}]}]})

We were able to reproduce this locally with the following docker-compose.yml
version: '3.5'

services:

  vernemq1:
    image: docker-hub.testo.dev/vernemq/vernemq:2.0.0
    environment:
      - DOCKER_VERNEMQ_ACCEPT_EULA=yes
      - DOCKER_VERNEMQ_COMPOSE=on
    volumes:
      - vernemq1:/vernemq/data
    networks:
      - vernemq

  vernemq2:
    image: docker-hub.testo.dev/vernemq/vernemq:2.0.0
    environment:
      - DOCKER_VERNEMQ_ACCEPT_EULA=yes
      - DOCKER_VERNEMQ_DISCOVERY_NODE=vernemq1
      - DOCKER_VERNEMQ_COMPOSE=on
    volumes:
    - vernemq2:/vernemq/data
    networks:
      - vernemq

networks:
  vernemq:
    name: vernemq

volumes:
  vernemq1:
  vernemq2:

The following steps result in the described error:

Create both VerneMQ nodes

docker-compose up -d

cluster formation seems ok, we can see the following log line
vernemq2_1  | 2024-06-06T08:25:37.920390+00:00 [info] <0.711.0> vmq_cluster_node:handle_message/2:220: successfully connected to cluster node<EMAIL_ADDRESS>
and vmq-admin cluster show shows
+--------------------+---------+
| Node               | Running |
+--------------------+---------+
|<EMAIL_ADDRESS>| true    |
+--------------------+---------+
|<EMAIL_ADDRESS>| true    |
+--------------------+---------+

stop all nodes docker-compose stop
start all nodes again docker-compose start

looking at the logs docker-compose logs -f the second node consistently fails with
vernemq2_1  | 2024-06-06T08:28:21.087071+00:00 [error] <0.9.0>: Error in process <0.9.0> on node<EMAIL_ADDRESS>with exit value:, {{badkey,{'VerneMQ@<IP_ADDRESS>',<<191,60,5,252,193,92,106,78,25,98,133,181,82,244,69,161,221,52,49,64>>}},[{erlang,map_get,[{'VerneMQ@<IP_ADDRESS>',<<191,60,5,252,193,92,106,78,25,98,133,181,82,244,69,161,221,52,49,64>>},#{}],[{error_info,#{module => erl_erts_errors}}]},{vmq_swc_plugin,'-summary/1-lc$^1/1-1-',3,[{file,"/opt/vernemq/apps/vmq_swc/src/vmq_swc_plugin.erl"},{line,220}]},{vmq_swc_plugin,history,1,[{file,"/opt/vernemq/apps/vmq_swc/src/vmq_swc_plugin.erl"},{line,230}]},{vmq_swc_peer_service,attempt_join,1,[{file,"/opt/vernemq/apps/vmq_swc/src/vmq_swc_peer_service.erl"},{line,57}]},{vmq_server_cli,'-vmq_cluster_join_cmd/0-fun-1-',3,[{file,"/opt/vernemq/apps/vmq_server/src/vmq_server_cli.erl"},{line,516}]},{clique_command,run,1,[{file,"/opt/vernemq/_build/default/lib/clique/src/clique_command.erl"},{line,87}]},{vmq_server_cli,command,2,[{file,"/opt/vernemq/apps/vmq_server/src/vmq_server_cli.erl"},{line,45}]},{erl_eval,do_apply,7,[{file,"erl_eval.erl"},{line,746}]}]}
vernemq2_1  |
vernemq1_1  | 2024-06-06T08:28:21.088686+00:00 [warning] <0.421.0> vmq_cluster_mon:handle_info/2:127: cluster node<EMAIL_ADDRESS>DOWN
vernemq2_1  | Crash dump is being written to: /erl_crash.dump...[os_mon] cpu supervisor port (cpu_sup): Erlang has closed
vernemq2_1  | [os_mon] memory supervisor port (memsup): Erlang has closed

Expected behaviour
see current behaviour
Configuration, logs, error output, etc.
see current behaviour

Code of Conduct

[X] I agree to follow the VerneMQ's Code of Conduct

@pellepelster Thanks, this is fixed in main by PR https://github.com/vernemq/vernemq/pull/2304, which will be part of 2.0.1 as a hotfix release for 2.0.0 very soon.
Your current workaround is to set
DOCKER_VERNEMQ_VMQ_SWC__PREVENT_NONEMPTY_JOIN to "off"

👉 Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
👉 Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

Thanks for the quick response, the workaround did indeed fix the issue, looking forward for the quick fix


Add new instancio-quickcheck module to support property-based testing using Instancio

Add new instancio-quickcheck-junit module to support property-based testing (experimental) using Instancio generation capabilities.
The design closely follows the QuickCheck principles (hence the name) [1] but at this stage offers very limited feature set. It currently only supports JUnit 5 by providing own test engine.
[1] https://dl.acm.org/doi/10.1145/351240.351266

@reta thanks very much for putting this together. This is a great start!
What do you think about naming the module instancio-quickcheck instead of instancio-quickcheck-junit? I'm hoping to avoid confusion with the existing instancio-junit module.

@armandino I think we have a first cut in a good shape, what do you think about it? Thank you!

Thanks @reta! Will take another look at the PR.

@reta, I added a few minor comments. It would be nice to have javadocs for the public APIs.
Unfortunately the Sonar scan doesn't play well with PRs from forks (#783), but there are a few branches not covered by tests. If any of those are important, it'd be nice to have a test for them as well.

@reta, I added a few minor comments. It would be nice to have javadocs for the public APIs.

Thanks a lot @armandino , makes perfect sense, I will work through your comments!

Unfortunately the Sonar scan doesn't play well with PRs from forks (#783), but there are a few branches not covered by tests. If any of those are important, it'd be nice to have a test for them as well.

@armandino worked through javadocs and adding more test cases, there are still few branches to cover but those are related to enhancements we could target in future right away (nested test classes as an example), thank you!

@armandino worked through javadocs and added more test cases, there are still few branches to cover but those are related to enhancements we could target in future right away (nested test classes as an example), thank you!

Thank you, @reta!  Let's merge the PR. Could you please rebase and squash the changes into one commit?

Thank you, @reta! Let's merge the PR. Could you please rebase and squash the changes into one commit?

Thanks @armandino , should be all set

Thanks @reta!


Hide tabs and "open editors"

Is your feature request related to a problem? Please describe.
In VS Code, I exclusively use the command palette to move around instead of tracking open editors/tabs; I have the "open editors" section and tab bar hidden.
Describe the solution you'd like
I'd love to be able to configure lapce the same way!
Describe alternatives you've considered
I could learn to live with the default setup, but it's very visually distracting.
Additional context
I love the other features of lapce!

Edited because I figured out how to move elements to the rhs panel, but the tab / "open editors" sections seem to be untouchable.


fix: change description column type to text

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Close #16438 , When using MySQL as the SQL backend, the description column will be defined as varchar(255), but the description of session parameters is generated by macros from comment content, which can easily exceed this length limit.
Note that, the feature of session parameter is not in release 1.8.X, so directly modifying the type will not cause a backward compatible issue.
Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Should we use a new migration script instead of modifying a exist one?


Update README.md

Add python3-dev and libpq-dev dependency install instructions

@froggleston do you want to merge this PR?


[FEATURE] choose disk by label or something

Is your feature request related to a problem? Please describe.
I use Harvester on a PC with 2 disk -- a 256G NVME SSD & a 1T SATA HDD.
I can add both disk in host management, but can't choose which disk my vm's volume will use.
Describe the solution you'd like
I think it's a good idea to give disk labels,
so when you create a VM, you can use labels to make the volume using right disk.
Longhorn already support this feature(storage-tags).
Just expose it in harvester's UI.

Perhaps it's similar to https://github.com/harvester/harvester/issues/2147

Close as this is duplicate with https://github.com/harvester/harvester/issues/2147, feel free to reopen it if u have different concerns, thanks.


AMB-1306: byminute Support

These changes add byminute to RecurrenceForm to support occurrences at times beyond the :00.
AMB-1306
ambitioninc/ambition PR

These changes will require byminute which means ambitioninc/ambition changes will need to be released beside.

@somewes I have made byminute optional as we discussed in Slack. Is this how you would set a default value?


Package Status

Hi @XavRsl
Your package is very useful for me, but it seems you have not the time to maintain it actively.
Do you think that changes again?
Can I help you in some way?
I forked your package to get it work with Laravel 5 and added a little feature.
Let me know if you think I should create a pull request.

Hi @strebl,
I'm glad you find this package useful. I've been looking at your forked version (haven't found time to install it yet). It's great to have it laravel 5 compliant, but is it really working as is ? I've updated my CAS package recently and it seems I had to do a lot more things to be L5 ready...
Thanks for the removal of the $password variable from the bind() method call.
Your globalFilter is interesting but it seems like you force the boolean operator to be AND without allowing it to be OR. Not sure this will please everyone.
In fact, I don't really know if I should keep on working on that package. I have the feeling that if I had to work on it I would rewrite it from the ground up. The fact is I now use the Zend LDAP package more and more and although it's a lot heavier and seems overwhelming at first, you can actually achieve a lot more than with my old LDAP package.
I need some time to consider this package's future.
Thank you for your time, I'll try to come back to you ASAP.
Xavier

Hi Xavier, I'm looking forward to your response on this as well. I think it's a pretty good package to have. Haven't tried Zend LDAP before, would you be able to point me in the right direction?

Hi @XavRsl
Yeah it works so far. But I didn't go deep into the package until now. I'll come back to that question in a few days / weeks because now I'll start with the LDAP part of my app.
Until now, I only wrote a little importer command which imports all users to my database. That works fine!
About the global filter:
You can still use an OR operator within my global filter to achieve something like that: get all users with a displayname = *bob* but only users inside the organizational unit boston OR california.
I can't imagine a situation where I would set a global "OR" filter. Get all users with a displayname = *bob* OR all users in the OU boston OR california. Seems weird to me.
Can you give me an example where you would use a global or filter?
For me, the or filter is really useful for queries like: get all users where the displayname is bob OR jane. But that is what your packages handles very well.
The main usage for a global filter, in my opinion is to ignore some users. I'll give you an example. In our LDAP we have some test and system users. all test users have a prefix: test_* and our system user: sys_*. I don't need these users in a end user app, therefore I'd like to exclude them.
I will definitely take a look on the Zend LDAP package. But when I was looking for a ldap package I found that package too. But my first impression was it is kinda verbose and I felt I would have to write a wrapper around the Zend package.
Maybe I just wasn't looking close enough!
On the other side, your package has a great API and feels right to me in the Laravel context. :smile:
Did you think about a Laravel package for the Zend package?

Hi @strebl !
You're right for the AND and OR operators. I have no example of the use of a global OR but I think I remember a user asking me for this feature in an issue. So could you just put back the $this->booleanOperator instead of & ?
I've been thinking about writing a wrapper around Zend Ldap. I also wanted to make it Eloquent-like. But the work to achieve this would be a bit overwhelming for me. I've looked at two packages that do something like that : https://github.com/Vinelab/NeoEloquent/ and https://github.com/yajra/laravel-oci8. Very good packages but very complex.
So, the good way to go would be to write the API first, then tests, then start writing the package using Zend Ldap in the background (as this would also help me solve issues concerning AD compliance #7 ). The whole structure should also be re-written, the Directory Class should be split into small, more manageable pieces. I'd also like to create a Middleware for LDAP authentication and have Laravel 5 fashion function call ldap()->people().
Sounds like a lot of fun. I think I'll need some help to achieve this. I've made a Trello Board to start getting organized. If you guys wanna join in, please do ! : https://trello.com/b/g7xEVakS/ldap-package-development
Xavier


feat: Add example snippets for snapshot reads

As part of feature work for snapshot reads, add examples for the documentation.
Fixes #1002  ☕

@yixiaoshen, please review.


markdown mode link highlight

markdown mode highlights text below
[text having square bracket

But It is actually not a link yet.

The text should not be highlighted.

The mode can't look ahead and determine whether the bracket corresponds to a well-formed link, so it has to work this way—assuming something that may start a link actually does so. Full Markdown parsers work very differently from typical programming language parsers, but in a highligher, we do have to work in a single pass.

If a user invokes '[' on the middle of document, "the rest of document" will have a blue line. It's awkward for users.


Add QWOP as a third-party environment

Description
Environment: qwop-gym
Type of change
Please delete options that are not relevant.

[x] This change requires a documentation update

Checklist:

[x] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes

Thanks for adding the project, could you add it in alphabetic order?

Hello,
it's been three months since this was merged, but it's still not visible on the website 🤔
Is there anything else I need to do in order to change that?
Cheers


[Feature Request]: Refactor db setup

Contact Details
No response
Is your feature request related to a problem?
I will use this as a collection point for all database related issues.

https://github.com/nfdi4plants/Swate/issues/319, search returns unintuitive results
https://github.com/nfdi4plants/Swate/issues/315. search is not performant
https://github.com/nfdi4plants/Swate/issues/320, maybe use TIS?
https://github.com/nfdi4plants/Swate/issues/236, do not show or use queries ignoring obsolete terms
https://github.com/nfdi4plants/Swate/issues/306, correctly display OntologySourceReference as part of ontology object in db.

Describe the solution you would like!
Either use TIS or setup 2 databases:

neo4j for tree search
any high performance string search database

search string only,
use results to do tree search, but already return string search results.
Add to results from tree search results.

remove user toggle for tree search and make it happen "magically"

Additional context!
No response
Host
Standalone
Host Details
All

Will close all related issues as they are now collected here


Fatal error: Allowed memory size of 268435456 bytes exhausted (tried to allocate 1310720 bytes) in D:\Apache Server\Apache24\htdocs\php-ml-examples\vendor\php-ai\php-ml\src\FeatureExtraction\TokenCountVectorizer.php on line 92

While running bbc.php i am getting this error.
Fatal error: Allowed memory size of 268435456 bytes exhausted (tried to allocate 1310720 bytes) in D:\Apache Server\Apache24\htdocs\php-ml-examples\vendor\php-ai\php-ml\src\FeatureExtraction\TokenCountVectorizer.php on line 92

It happens because of memory_limit in php.ini. You will need to update that field to -1 (no limit on usage of memory) in php.ini file. Although it has its own drawbacks i.e. it may slow down the system in case of heavy memory usage. But for memory_limit issues, it works well.


fix(deps): update dependency @apollo/client-react-streaming to v0.9.0

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

@apollo/client-react-streaming
0.9.0-snapshot-test.1 -> 0.9.0

[!WARNING]
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

apollographql/apollo-client-nextjs (@apollo/client-react-streaming)
v0.9.0
Compare Source

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - "after 8am and before 4pm on tuesday" in timezone Etc/UTC.
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: yarn.lock
➤ YN0000: · Yarn 4.1.0
➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed in 0s 672ms
➤ YN0000: ┌ Post-resolution validation
➤ YN0002: │ @apollo/client-react-streaming@workspace:packages/client-react-streaming [6d01c] doesn't provide react-dom (p6ea56), requested by @testing-library/react.
➤ YN0002: │ @apollo/client-react-streaming@workspace:packages/client-react-streaming [a7905] doesn't provide react-dom (p8d8b3), requested by @testing-library/react.
➤ YN0002: │ @apollo/client-react-streaming@workspace:packages/client-react-streaming [ff90e] doesn't provide react-dom (p6a157), requested by @testing-library/react.
➤ YN0002: │ @apollo/client-react-streaming@workspace:packages/client-react-streaming doesn't provide react-dom (p8b348), requested by @testing-library/react.
➤ YN0002: │ @apollo/experimental-nextjs-app-support@workspace:packages/experimental-nextjs-app-support [57d1f] doesn't provide react-dom (p14a9a), requested by @testing-library/react.
➤ YN0002: │ @apollo/experimental-nextjs-app-support@workspace:packages/experimental-nextjs-app-support [689d7] doesn't provide react-dom (p8f77d), requested by @testing-library/react.
➤ YN0002: │ @apollo/experimental-nextjs-app-support@workspace:packages/experimental-nextjs-app-support doesn't provide react-dom (p102c3), requested by @testing-library/react.
➤ YN0002: │ @apollo/experimental-nextjs-app-support@workspace:packages/experimental-nextjs-app-support doesn't provide react-dom (p6ec33), requested by next.
➤ YN0002: │ monorepo@workspace:. doesn't provide webpack (pef089), requested by @size-limit/webpack-why.
➤ YN0086: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code.
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step


RLMArray insertObjects:atIndexs:

Why not offer insertObjects:atIndexs: in RLMArray.h as a public method ?  I can not find a proper method to insert objects at the middle of a RLMArray instance.  Write an category for this case is not a better idea.

Currently you can call -[RLMArray insertObject:atIndex:] multiple times to insert multiple objects in the middle of an array.
We can certainly consider adding -insertObjects:atIndexes: (and -replaceObjectsAtIndexes:withObjects:) for consistency with NSMutableArray. We already support -addObjects:.


Add metro codes

@cee-dub Whatchu think?

I’d like to merge this, but rather than add a separate field for metro codes, I think we should prefix the metro code in locations, e.g.:
{
	"locations": [
		"metro:803",
		"Los Angeles"
	}
}

Closing in favor of https://github.com/zonedb/zonedb/pull/727


Doesn't work with Laravel v5.1.43

Laravel base installation... nothing modified. Literally just added this library and it gives the error:
Whoops, looks like something went wrong.

Lies, all lies. It's fine. The error was due to the Laravel .env file not being set up correctly.


Wallets were deregistered but coldkey and hotkey still registered to UID. Not recovering.

Registered UID 216 on 2/20/24. Needed to troubleshoot miner and had to reset paths to coldkey and hotkey. Miner and UID 216 have been live on taostats during this time. Rebooted and fixed miner today. Restarted pm2 mining process and received error (image attached.) Netuid 13 is requesting additional registration even though miner is still registered and in immunity period.

As discussed you were out of your 30 hour immunity period and got deregged because your miner was down and incentive dropped too low.


Inference on Single Node multiple GPUs

Hi Erfan, how can we load a large model with weights split across multiple GPUs? All of the examples I looked at only show CPU memory offloading.

Ill create an example for you in next commit but simply you just have to give the shard-fns to loaders

https://github.com/erfanzar/EasyDeL/blob/main/examples/load_model_parallel.py

This doesn't work. I tried this with Llama-2 and Mixtral and it produces these kind of errors:
TypeError: MixtralForCausalLM.init() got an unexpected keyword argument 'shard_fns'

Did some digging for some reason for the Mixtral model params_shape_tree is empty which forces match_partition_rules to produce an empty Dict and consequently an empty shard_fns. This is not the case when I run Llama2 model. Any idea why it's not producing params_shape_tree for Mixtral but does for Llama-2?

The trick that we used for shard llama model wont work only and only on mixtral models for that you should use some other tricks

It's because MoE models are way too dynamic for jax so we cant pass them to jax.eval

sharding model now fixed on Mixtral models and you can do the same with the just like what you llama for sharding model

I tested load_model_parallel_llama.py and it's not working with Mixtral. Works as expected with LlamaStory/Llama-2
Here's the error I'm getting:

Mixtral models are not compatible with phit again and im tryin to fix moe part but ill create autoshard function in easy api seems like a lot of people want to use this api

check this out for easier api call


Update the latest flash-attention repo

rt

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 4 committers have signed the CLA.:white_check_mark: Xreki:x: eggiter:x: tridao:x: ksivamanYou have signed the CLA already but the status is still pending? Let us recheck it.


Add PyQt5-sip to requirements.txt

Otherwise (on Ubuntu 22.04) loading the plugin fails with:
Traceback (most recent call last):
  File "/home/igor/.lightning/plugins/lightning-qt/lightning-qt.py", line 13, in <module>
    import sip
ModuleNotFoundError: No module named 'sip'

Hello, thank you for the PR. I'll probably merge this trivial patch but FYI the plan is to migrate this repo to https://github.com/lightningd/plugins (see https://github.com/lightningd/plugins/pull/292).


Refactor with PlutoDevMacros 0.6.0

This is a significant internal refactor of the code in order to leverage the new script/html combining functionality from PlutoDevMacros v0.6
It is now easier to specify how to render PlutoPlot objects both inside and outside Pluto, opening the possibility of also rendering the plots correctly when not using Pluto.
The plot will in principle render automatically in the correct way depending on whether it's shown inside or outside Pluto.
PlutoPlot objects are now also rendered in the Plot pane in VSCode while still providing most of the functionality of PlutoPlotly that are not in PlotlyBase (like easily adding JS code or listeners).
With this rewrite, it is now easy to directly print a fully standalone hml document that contains the plot using the print_html function defined in PlutoDevMacros and extended here for PlutoPlot objects. This will fix #12

Closing this as the current way forward is to separate the JS part into a separate JS library (see #50)


chore: use more recent chromedriver and audit fix

Hi @ahmadnassri mind to review that PR, please :)

I've pushed an update in https://github.com/ahmadnassri/node-nightwatch-accessibility/commit/e9e29f3b51ca485735d710813e24568df8721f2d which also automates package updates, so this will not slip anymore.
thank you and sorry it took so long to follow up .


Any PDF not rendering in Android WebView

Link to PDF file (or attach file here):  I've used the sample PDF that comes in the pre-built PDF.js package.  I've also tried other PDF files, from different sources.  The results are the same.
Configuration:

Web browser and its version: Android WebView (Appcelerator)
Operating system and its version: Android Marshmallow
PDF.js version: v1.3.91
Is an extension: No

Steps to reproduce the problem:

I used the pre-built viewer to see if it would work in the Android WebView Control in our Hybrid Mobile app
I am just loading the sample PDF that comes with the pre-built PDF.js

What is the expected behavior? (add screenshot)
This is how it looks in Chrome on Android, it looks perfect:

What went wrong? (add screenshot)
This is how it looks inside of the Android WebView.  The PDF does download, I can see the "Document Properties" and I can see it in Full Screen mode, but it does not render in normal mode.

Both the logs from Chrome and the Android WebView look the same:

I understand that this is likely something to do with the Appcelerator WebView control, however I am wondering if there is some other way I can troubleshoot or find a workaround.  Is there more logging that can be enabled, or some other steps I could try to find the problem?
Thanks.

some other steps I could try to find the problem?

Since loading is working, try to log some page painting info e.g. if PDFPageView draws anything or page divs are created.

P.S. possible reason that viewer div is not visible, hidden or too small.

Yes!!    I used the Chrome debugger to inspect the HTML content and indeed, the "height" of the html. body, and div#outerContainer tags are set to "%100". Each has a "Calculated" height of 0px.  So, the div#viewerContainer element renders at 0px high as well. Once I add some explicit/actual height to any of those containers, the PDF shows up just fine.
<div id="viewerContainer" tabindex="0"> <-- This, and all parent elements, render at 0px high
Another oddity is that, once its visible, the PDF is rendered very large.  Its being rendered at over 800px wide even though my screen only has 360 px across.  I'm thinking these two things are related.
Any ideas why the CSS wouldn't be calculating the height of the html or body tags correctly?  Feels like a media query gone wrong maybe?  Due to something quirky with the Appcelerator WebView?

Same problem with android api 23/reactnative/webview.
As said it's quickly fixed by document.body.style.height = window.innerHeight + 'px' although one should take care of dynamic resizing if any.
The rendering to wrong size seems to only affect the emulator, but I tested only on one android 5 device by now.

Why is there no integrated PDF.js viewer in Firefox for Android?
Everytime I click on a PDF with my mobile phone (Android Marshmallow, Firefox Beta 48) it gets downloaded instead of displayed inside of the browser.
The extension is deprecated: https://addons.mozilla.org/de/android/addon/pdfjs/

@srgibbs99 I have the same height problem in a Samsung s6 6.0.1 Could you fix this? Thank you

@paolocaminiti

As said it's quickly fixed by document.body.style.height = window.innerHeight + 'px'

Where do you put that line of code? I'm having issues rending my PDFs inside my webview, they only render about a third of the size...

Hi,
I’m working on a solution using pdfjs via react-pdf into react-native and expo app.
https://github.com/xcarpentier/rn-pdf-reader-js
That may helps someone...

Given the age of this issue, and that it looks platform and/or browser specific (rather than PDF.js related as such), is it actually meaningful to keep it open?

Given the age of this issue, and that it looks platform and/or browser specific (rather than PDF.js related as such), is it actually meaningful to keep it open?


ext-mongodb is missing from the akeneo images

Hello,
I'm trying to use the docker-compose files to have a dev environment for Akeneo. I may have gotten something wrong, but at least the apache version, when running the docker-compose exec akeneo php -d memory_limit=-1 /usr/local/bin/composer update I get a missing ext-mongodb dependency for the system. I have this with akeneo:php-5.6 as well as latest.
Here is the complete stacktrace:
Problem 1
    - alcaeus/mongo-php-adapter 1.0.0 requires mongodb/mongodb ^1.0.1 -> satisfiable by mongodb/mongodb[1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.1.0, 1.1.1].
    - alcaeus/mongo-php-adapter 1.0.1 requires mongodb/mongodb ^1.0.1 -> satisfiable by mongodb/mongodb[1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.1.0, 1.1.1].
    - alcaeus/mongo-php-adapter 1.0.2 requires mongodb/mongodb ^1.0.1 -> satisfiable by mongodb/mongodb[1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.1.0, 1.1.1].
    - alcaeus/mongo-php-adapter 1.0.3 requires mongodb/mongodb ^1.0.1 -> satisfiable by mongodb/mongodb[1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.1.0, 1.1.1].
    - alcaeus/mongo-php-adapter 1.0.4 requires mongodb/mongodb ^1.0.1 -> satisfiable by mongodb/mongodb[1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.1.0, 1.1.1].
    - alcaeus/mongo-php-adapter 1.0.5 requires mongodb/mongodb ^1.0.1 -> satisfiable by mongodb/mongodb[1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.1.0, 1.1.1].
    - alcaeus/mongo-php-adapter 1.0.6 requires mongodb/mongodb ^1.0.1 -> satisfiable by mongodb/mongodb[1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.1.0, 1.1.1].
    - alcaeus/mongo-php-adapter 1.0.7 requires mongodb/mongodb ^1.0.1 -> satisfiable by mongodb/mongodb[1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.1.0, 1.1.1].
    - alcaeus/mongo-php-adapter 1.0.8 requires mongodb/mongodb ^1.0.1 -> satisfiable by mongodb/mongodb[1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.1.0, 1.1.1].
    - mongodb/mongodb 1.1.1 requires ext-mongodb ^1.2.0 -> the requested PHP extension mongodb is missing from your system.
    - mongodb/mongodb 1.1.0 requires ext-mongodb ^1.2.0 -> the requested PHP extension mongodb is missing from your system.
    - mongodb/mongodb 1.0.4 requires ext-mongodb ^1.1.0 -> the requested PHP extension mongodb is missing from your system.
    - mongodb/mongodb 1.0.3 requires ext-mongodb ^1.1.0 -> the requested PHP extension mongodb is missing from your system.
    - mongodb/mongodb 1.0.2 requires ext-mongodb ^1.1.0 -> the requested PHP extension mongodb is missing from your system.
    - mongodb/mongodb 1.0.1 requires ext-mongodb ^1.1.0 -> the requested PHP extension mongodb is missing from your system.
    - Installation request for alcaeus/mongo-php-adapter ^1.0 -> satisfiable by alcaeus/mongo-php-adapter[1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.0.5, 1.0.6, 1.0.7, 1.0.8].

  To enable extensions, verify that they are enabled in your .ini files:
    - /etc/php5/cli/php.ini
    - /etc/php5/cli/conf.d/05-opcache.ini
    - /etc/php5/cli/conf.d/10-pdo.ini
    - /etc/php5/cli/conf.d/20-apcu.ini
    - /etc/php5/cli/conf.d/20-curl.ini
    - /etc/php5/cli/conf.d/20-gd.ini
    - /etc/php5/cli/conf.d/20-imagick.ini
    - /etc/php5/cli/conf.d/20-intl.ini
    - /etc/php5/cli/conf.d/20-json.ini
    - /etc/php5/cli/conf.d/20-mcrypt.ini
    - /etc/php5/cli/conf.d/20-mongo.ini
    - /etc/php5/cli/conf.d/20-mysql.ini
    - /etc/php5/cli/conf.d/20-mysqli.ini
    - /etc/php5/cli/conf.d/20-pdo_mysql.ini
  You can also run `php --ini` inside terminal to see which files are used by PHP in CLI mode.

Hello @Erwyn.
No, you didn't miss anything, it is my fault. I forgot an important element in the documentation: on PHP 7.x, you need to run composer with the option --ignore-platform-reqs or you end with the error you report.
So after adding alcaeus/mongo-php-adapter, the right command is:
docker-compose exec akeneo php -d memory_limit=-1 /usr/local/bin/composer --ignore-platform-reqs update .
I will amend the COMPOSE.md as soon as possible. Thank you for reporting this issue :+1: .
Damien.

I must add that this issue exists as well for php-5.6. I had to install the php-pear package as long as openssl libraries to install the mongodb extension through pecl install mongodb.
Should I run with the --ignore-platform-reqs as well for php-5.6?

Nope, this is not needed for PHP 5.6, and the images come with php5-mongo, so you should not have to use pecl at all.
That is strange. I am sure mongo works fine on the PHP 5.6 images as I use them on a daily basis. And you don't need alcaeus/mongo-php-adapter with PHP 5.6.
I think I must organize the documentation differently, as in fact the content is not the same depending of the branch you are on (for instance, I don't mention alcaeus/mongo-php-adapter on the php-5.6 branch).

Oh, I see, I understand now, I'll try with the 5.6 branch.

Okay, so I confirm now, this is not a problem with the 5.6 branch.

should be closed

As the issue has been fixed by the documentation and is now one month old, I am closing it.


Expand the grammar to allow bracketed expressions

The current definition for a bracketed expression is this:
bracketSpecifier
  : '[' SIGNED_INT ']' # bracketIndex
  | '[' '*' ']' # bracketStar
  | '[' slice ']' # bracketSlice
  | '[' ']' # bracketFlatten
  | '[?' expression ']' # select
  ;

slice : start=SIGNED_INT? ':' stop=SIGNED_INT? (':' step=SIGNED_INT?)? ;

This means that we can't use expressions to index an array.
e.g. items[length(items) / 2] is an invalid syntax.
We can do this today using the value function: value(items, length(items) / 2)
However, allowing expressions inside brackets seems more intuitive -- and it appears that we can expand the syntax to allow it without conflict.
If we do extend the syntax this way, then we can also use brackets to retrieve map children.
e.g. address['street']
If so, we could do away with the value() function.
bracketSpecifier
  : '[' expression ']' # bracketIndex
  | '[' '*' ']' # bracketStar
  | '[' slice ']' # bracketSlice
  | '[' ']' # bracketFlatten
  | '[?' expression ']' # select
  ;

slice : start=expression? ':' stop=expression? (':' step=expression?)? ;

Notes:

We would also use expressions for slice.  Again, this should work, since the : character is not used elsewhere in the grammar and we can delimit the expressions.
When indexing arrays, an expression may return a negative integer -- which then offsets from the end of the array
When a bracketed expression is used for an array, it is cast to an integer
When a bracketed expression is used on an object, it is case to a string

@arnehjain:
I was trying to use this with objects -- but not working as I expected it to.
e.g. I was expecting the expression: address['street'] to return the street field

Ah. I think I missed implementing it for objects. Will raise another PR for that.


chore(deps): enable renovate

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Integrate UNet predictions with batchlib

[x] add normalization function used by UNet2D
[x] make it work with TorchPrediction

I've also changed batchlib/segmentation/torch.py to batchlib/segmentation/torch_prediction.py due to name clashing while importing torch in other files :)

Thanks a lot!

Ok, looks all good now, thanks!


Bad Transaction Key in front of  model name

Hello.  My client is using the marketplace version of the data dictionary but someone here mentioned to submit this question here.  Is there a reason that we see this in front of the model name

Hi, we can't reproduce this issue anymore, so I'm closing it.


Incorrect permissions with 5.1.8 | Ensure at/cron is restricted to authorized users task

The task for this CIS criteria changes the cron file permissions to 0640 when they should be 0600 instead
      - name: "SCORED | 5.1.8 | PATCH | Ensure at/cron is restricted to authorized users | Create allow files"
        file:
            path: "{{ item }}"
            owner: root
            group: root
            mode: 0640
            state: touch
        with_items:
            - /etc/cron.allow
            - /etc/at.allow

Audit:
Run the following command and verify Uid and Gid are both 0/root and Access does not grant permissions to group or other for both /etc/cron.allow and /etc/at.allow :
stat /etc/cron.allow
Access: (0600/-rw-------) Uid: ( 0/ root) Gid: ( 0/ root)
stat /etc/at.allow
Access: (0600/-rw-------) Uid: ( 0/ root) Gid: ( 0/ root)

Hello,
Thanks for raising the issue and I can make the change but I want to make sure I fully understand the mistake being made before the change. I have the audit from the and remediation from that control in the benchmark below. Looking at the audit output that is being used as the "good" finding it is set to 640. Then in the remediation step it has you removing write and execute from group and read/write/execute from other. Doing it by the number I think 640 is correct for those files since in the end the user perms are left with whatever,  group is left with only read permissions, and other has none. Let me know if I'm mis-interpreting the control.
audit section:
Run the following command and verify Uid and Gid are both 0/root and Access, does not grant write or execute to group, and does not grant permissions to other for/etc/cron.allow: # stat /etc/cron.allow Access: (0640/-rw-r-----) Uid: ( 0/ root) Gid: ( 0/ root)
remediation section:
chmod g-wx,o-rwx /etc/cron.allow
George

Ah I see the issue, I was comparing the Distribution Independent Linux CIS Benchmark instead of the Ubuntu-specific CIS Benchmark.
In the DIL benchmark the 5.1.8 criteria requires 0600 permissions for the at/cron files, whereas in the Ubuntu benchmark the 5.1.8 criteria calls for 0640 permissions.
Not entirely sure why the difference in permissions, but AFAICT it seems that Debian/Ubuntu systems need the 640 permissions due to the crontab group needing access to read the at/cron files to properly restrict user access.
ie.

https://bugs.launchpad.net/ubuntu/+source/bastille/+bug/55741
https://groups.google.com/g/comp.os.linux.security/c/Z1-dOm8YegI


added imagepullsecrets

Description

Fix #556
Test

To test this pull request, you can run the following commands:
add image pull secrets to a values file:

imagePullSecrets:
  - name: mySecret

helm install --wait -n kubewarden kubewarden-controller charts/kubewarden-controller --values myvalues.yaml

Images of the post-install-hook can be pulled even if the private registry needs authentication.
Additional Information
if imagePullSecrets are not set the part will be ignored and not created.
Tradeoff
None Known
Potential improvement
None Known

I hope this works had problems with signing and cound't fix it without reopening

Many thanks! Merging, this will be part of 1.17 in a couple of weeks.


Support configuring a HTTP client timeout in the Docker provider

What does this PR do?

This PR adds a new configuration option on the Docker provider setting the HTTP client timeout when a HTTP endpoint is used. It also sets a default of 1 hour, which should probably be debated as there is currently no timeout by default.
Motivation

Closes #7093.
More

[x] Added/updated tests
[x] Added/updated documentation

Additional Notes

Let's debate whether it's a good or a bad idea to set a default timeout of e.g. 1 hour.

I don't understand what to do about the test failures of Test_decodeFileToNode_Yaml and Test_decodeFileToNode_Toml as I've placed the new option in the same order in all sample files.

I appreciate the fixes added to the PR. What makes 32 a good default?

It's the same value a the dialer https://github.com/moby/moby/blob/516d9719d554ab983d4b53d19fa88ff21a98e091/vendor/github.com/docker/go-connections/sockets/sockets.go#L12

Please don't update your branch by merging master, we have a bot that manage automatically the rebase of the PR.

Please don't update your branch manually (unless there are conflicts to be managed by hand), we have a bot that manage automatically the rebase of the PR.

Point taken, GitHub simply offered it with a big inviting button.

Any chance of this making it into the next 2.2 release? It was already on the "next" milestone before the last 2.2 release.

the current next is v2.4


[HOLD for payment 2023-06-28] [$1000] Email is missing in "Invite new members to workspace" page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

go to Settings >Workspaces > Members
2.click on invite

Expected Result:
email showing for all members
Actual Result:
email is missing for all members
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: main
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan / @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686828770758129
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0131ca05869a50a814
Upwork Job ID:<PHONE_NUMBER>705686528
Last Price Increase: 2023-06-19

@tjferriss I don't know if we need an engineer on this - @fedirjh made the PR & i merged it - technically @fedirjh is a C+ but they didn't do C+ duties, they fixed the bug 😅 👍

@Beamanator thanks. It sounds like we should @fedirjh as the contributor and you're the reviewer.
As for the reporting bounty, I see the bug was first reported by @gadhiyamanan so I would assume we give them the reporting bonus over @priya-zha.

@Beamanator thanks. It sounds like we should @fedirjh as the contributor and you're the reviewer.
As for the reporting bounty, I see the bug was first reported by @gadhiyamanan so I would assume we give them the reporting bonus over @priya-zha.

@tjferriss I reported the same bug on June 12 whereas this issue was reported on June 15. Here's the slack convo: https://expensify.slack.com/archives/C049HHMV9SM/p1686588133599859
It would be great if you could look at this and let me know your thoughts on this. :grinning: :grinning:
Thanks

@priya-zha you reported that bug for PR testing which was fixed and for that reporting bonus will be handled here and i reported after it merged with main

It's still reproducible, so was it really fixed? If a bug has been reported for a specific build, do we need to create the same bug report again and again if the PR merges with the main or hits the staging ? Actually, i don't have much idea on this , so if someone could clarify.  I'll leave this on the team. Whatever the team decides , I'm okay with it.  😄😄😄😄
Also a related conversation here https://expensify.slack.com/archives/C049HHMV9SM/p1686659432203249?thread_ts=1686648377.836269&cid=C049HHMV9SM

It's still reproducible, so was it really fixed?

I am not able to reproduce, are you?

@gadhiyamanan No not today. It was reproducible when the PR merged with the main. If it was already solved before the PR merged with the main , then why did the issue appear again? Also, I  have a question, Can you please let me know if we create different bug reports for the same bug if it gets reproduced on a different build? I'm sorry I don't know much about this. Or is it like we just create a single bug report for a specific bug no matter what the build is? Here's where my doubt is. It would be great if you could answer this. :smiley: :smiley:
If we create different bug reports for the same bug which depends on the build/platform we use , then no doubt, you should be the one to be the reporter for this bug. But,  according to this slack convo, I felt no multiple bug reports are created for the same issue. I don't know what's the procedure here. :confused: :question:  Confused totally.

according to this slack convo, I felt no multiple bug reports are created for the same issue

the above bug which you mention is general bug which was reproducible in staging and not related to PR according to this. the bug which was reported by you is related to PR and which was solver according to this
the bug which was reported by me and created in GitHub was reported after merged with main

Ready for payment 👍

Bump @tjferriss

Bump again @tjferriss :D

Sorry for the delay here. I meant to re-assign before heading out on vacation. Offers have been sent to @fedirjh and @gadhiyamanan for the reporting bonus.

@tjferriss accepted, thanks!

Payments have been sent.


Double tapping past end of input

Double tapping after the last word in an input should still select that last word.
Fixes https://github.com/flutter/flutter/issues/132042

This solution appears to be blocked on https://github.com/flutter/flutter/issues/123415.

Closing this, I'll come back to it if it becomes unblocked.


View cards modal list

The view cards modal that opens when you click the view cards button on an in-progress reservation.
This should show a scrollable list of the cards associated with that reservation

This will involve hitting the api to get all line items where hold=true AND are associated with this reservationID and returning them so they can be listed out and displayed in the modal.


✨ Add webhook readiness and health check

Currently the readiness of our controller deployments does not include the webhook server. I.e., the deployment is already ready even when the webhooks are not up.
The current PR will help that the wait for readiness will also include the webhook server. This is crucial because otherwise there's a chance that clusterctl immediately fails when we try to deploy resources.
Follows: https://github.com/kubernetes-sigs/cluster-api/pull/4989

/test-integration
/test-centos-integration

/assign @furkatgofurov7
/cc @fmuyassarov @Xenwar

Would be great to update IPAM repo too with same changes.
/approve

Yes I would need the current PRs to go in IPAM since this change needs newer controller tools.

Would be great to update IPAM repo too with same changes.
/approve

Yes I would need the current PRs to go in IPAM since this change needs newer controller tools.

@kashifest heads up, in IPAM you will need to upgrade controller-runtime to v0.9.3+ to for this to work

Would be great to update IPAM repo too with same changes.
/approve

Yes I would need the current PRs to go in IPAM since this change needs newer controller tools.

@kashifest heads up, in IPAM you will need to upgrade controller-runtime to v0.9.3+ to for this to work.
/lgtm

Would be great to update IPAM repo too with same changes.
/approve

Yes I would need the current PRs to go in IPAM since this change needs newer controller tools.

@kashifest heads up, in IPAM you will need to upgrade controller-runtime to v0.9.3+ to for this to work.
/lgtm

Yep. Check this https://github.com/metal3-io/ip-address-manager/pull/44


allow to disable APIPA blocking

[ ] Redmine Issue: https://redmine.pfsense.org/issues/9966
[ ] Ready for review

allow to disable APIPA blocking

changed


Unlock DeWeb to Ecosystem projects

[x] Make repo public
[x] Check ReadMe and improve it if needed
[x] Contact projects - define a due date
[ ] Organise meetings to get feedback

Were going to launch meeting beginning of next week with the objective of closing by the 21st

We had written feedbacks, I was in regular contact with different ecosystem builders through telegram & discord.
Formal meeting not necessary.
See notion: https://www.notion.so/massa-innoteam/Beta-launch-feedback-e9118f0130514c61ac7890f5a2ae6f6d?pvs=4


Problem: Passing null to Encoder#encodeObject's Input Case Class Throws

Using:
$cat build.sbt
scalaVersion := "2.12.1"

val circeVersion = "0.6.1"

libraryDependencies ++= Seq(
  "io.circe" %% "circe-core",
  "io.circe" %% "circe-generic",
  "io.circe" %% "circe-parser"
).map(_ % circeVersion)

I observed the following MatchError when passing a null to Encoder#encodeObject:
$sbt console

// ...

scala> :paste
// Entering paste mode (ctrl-D to finish)

import io.circe._, io.circe.generic.semiauto._

case class X(a: Int)
case class Y(x: X)

implicit val xEncoder = deriveEncoder[X]

deriveEncoder[Y].encodeObject(Y(null))

// Exiting paste mode, now interpreting.

scala.MatchError: null
  at anon$lazy$macro$36$1$anon$macro$32$1.to(<pastie>:16)
  at anon$lazy$macro$36$1$anon$macro$32$1.to(<pastie>:16)
  at shapeless.LabelledGeneric$$anon$1.to(generic.scala:228)
  at shapeless.LabelledGeneric$$anon$1.to(generic.scala:226)
  at io.circe.generic.encoding.DerivedObjectEncoder$$anon$1.encodeObject(DerivedObjectEncoder.scala:13)
  at io.circe.ObjectEncoder.apply(ObjectEncoder.scala:12)
  at io.circe.ObjectEncoder.apply$(ObjectEncoder.scala:12)
  at io.circe.generic.encoding.DerivedObjectEncoder.apply(DerivedObjectEncoder.scala:6)
  at anon$lazy$macro$46$1$$anon$2.encodeObject(<pastie>:20)
  at anon$lazy$macro$46$1$$anon$2.encodeObject(<pastie>:20)
  at io.circe.generic.encoding.DerivedObjectEncoder$$anon$1.encodeObject(DerivedObjectEncoder.scala:13)
  ... 45 elided

I'm not sure if this behavior is standard or documented, however I recently encountered it when playing with this library.
Perhaps null is a more appropriate JSON value?

This is the intended behavior for all methods in circe (and matches most standard library methods, etc.). Checking for null everywhere would be noisy and wouldn't encourage good practice, so it's assumed that the user is responsible for not passing it, and if they do the behavior is undefined (but will usually either be this match error or an NPE).


add an API to set cookies

Can a cookie be set from within a grape api action?
I can't sort out how to get access to the request or rack to do it.
Thanks

An implementation was merged in https://github.com/intridea/grape/commit/fca7d6d372ee08e737e3b579962c79ae0d59f6ac to the frontier branch. See https://github.com/intridea/grape/pull/140.


Release 112

Changes to Pro

Exposes Pro features in a read-only mode for Free users:

Theme manager allows changing themes, but not editing
Read from repositories with multi-file sync, but not push
See which branch you're on in the branch switcher, but not make the switch

Improved tokens

Adds support for Figma's new individual stroke widths. Fixes #836
Adds autocomplete to composition tokens

Sync

Adds support for root-level git storage (e.g. storing tokens in the "/" directory). Fixes #822
When using multi file sync, renaming token sets now correctly renames the file
When using multi file sync, deleting a token set now correctly deletes the file

Quality of life improvements

Switching between token sets now remembers the last scroll position. Fixes #796
Adds support to load a single .json file or multiple multiple files. Fixes #599
Removing tokens from multiple selected layers is now supported. Fixes #826
Branch picker now scrolls when more than a certain number of branches are present.

Fixes

Fixes composition tokens not picking up values of 0. Fixes #951
Fixes scrollbar color. Fixes #930
Fixes issue where URL sync providers got duplicated.
Fixes an issue where documentation tokens with value 0 couldn't be applied. Fixes #888
Fixes an issue with autocomplete where tokens that were using a number wouldn't show up (e.g. spacing or radii)

Composition tokens autocomplete not working for individual border-widths


Replace ouroboros with self_cell

https://github.com/joshua-maros/ouroboros/issues/88 suggests self_cell in place of ouroboros. These things can be tricky. The iterator-based algorithm itself is still good.

I don't really understand what could the failure in Verify Examples be. cargo make test passed on everything locally.

I don't really understand what could be the failure in Verify Examples. cargo make test passed on everything locally.

Unrelated to your PR, more general issue across the board (related to a cargo-leptos and lightningcss versioning issue last I checked).

Thanks for keeping track of this, and it looks good to me.


Git.exe crashes on WinSshFs - unhandled exception

Hello
I'm running a guest  VMWare Workstation with Ubuntu Linux on Windows 10 host.
To edit files inside of guest  i use WinSshFs application v<IP_ADDRESS>.
The files are shown correctly in new drive and i can edit them.
The problem is when i try to run hosts Windows Git (ie. git status) on folder that is inside guest git crashes with debug info:
An unhandled win32 exception occurred in git.exe
After that error text different numbers occur like  [18104] , [3760],[14748] etc (not sure what they are).
For projects that are on Windows host drive same installation of git works correctly.

This is not where issues re Git for Windows should be raised.
Did you not read the issue template?

[ ] This is not an issue about

the Git documentation (a.k.a. man/help pages, i.e. anything with a URL starting with https://git-scm.com/docs), which should be raised with the community,
the contents of the Pro Git book (i.e. anything with a URL starting with https://git-scm.com/book or its PDF versions), which should be raised at progit/progit2.
Git itself, which should also be raised with the community, or
Git for Windows, which should be raised at git-for-windows/git.
and is actually about the website itself (e.g. website-specific content, JS, or CSS that doesn't seem to be doing its job correctly).


Support React v16.0

React v16.0 has been released with massive improvements.

The blog post is saying that there shouldn't be any breaking changes when coming from 15.x.x (https://facebook.github.io/react/blog/2017/09/26/react-v16.0.html#upgrading)

Is this just a matter of adding  || ^16.0.0 to the peerDependencies?
https://github.com/christianalfoni/formsy-react/blob/ebd84bb02613b355a02fd3e3cffb9d6dcd46b500/package.json#L47
That should be okay for the upcoming 1.0.x release, but the 0.x releases use mixins – are they supported in React 16?

The current release of the beta on npm has React v15 listed as a dependency. If you upgrade your app to React v16, two versions of React are loaded and chaos ensues.
https://github.com/christianalfoni/formsy-react/blob/998e2be44f4dcf3c49162244a4ef9e813af6f5c3/package.json
As this has already been fixed on the beta branch, is there any word on pushing a new release to npm?

whats the road map right now ? I would love to contribute and make updates but it seems pretty in-active.

There is another repo presents on Github - fork of this one. https://github.com/maccuaa/formsy-react-2. It looks like ready for React 16. AFAIK it was made because of low activity of this one repo.
I have tried it in my projects, and looks like ok.

Thanks for the link to the fork! Will look forward to it. It's sad that there hasn't happened much recently.

The other repo doesn't seem to work with formsy-react-components  I hope this repo get updated.

Hi @aliogaili, (Speaking as the maintainer of the formsy-react-components package). I'm not keen to support forks of formsy-react right now.
I agree the stuttered release pattern of formsy-react is frustrating, especially when we want to test with the latest shiny new React. But there is some nice stuff on the beta branch that seems like it could reboot this project, and I'd like to support that before switching to or otherwise supporting for forks.
Note: I'm not passing any judgment or expressing a preference about any forks here. It's just easier for consumers of formsy-react-components to couple with the formsy-react mothership.

Thanks @twisty, I also think that's the right path.

I agree, I would rather contribute to this project than have to maintain a fork.

I think i need to put it out there that react-formsy in its current state works fine with React 16.

I'm running into the following error when I update to React 16:

Any idea on what might be causing this?

Ok I went to the node_modules/formsy-react/node_modules and deleted the react folder then the error went away! when I do npm install again, the folder gets recreated (with react<EMAIL_ADDRESS>but the error is no longer showing.
Does anyone know what might be causing this behavior?

@aliogaili The reason react 15 is getting installed again is that the beta published to npm has react 15 listed as a dependency. It should be a peerDependency. This was fixed on the beta branch over a month ago, but there hasn't been a new beta release pushed to npm since the fix.
"I know!", you might think. "I'll just install it straight from the github repo!". Well, this does work, but takes a bit of twiddling. You may not get the built release files (the lib folder doesn't exist in the repo, and for some reason yarn wasn't transcoding them on install, YMMV):
This installs the latest version of the beta branch, transcodes the source, then removes any devDependencies.
yarn add https://github.com/christianalfoni/formsy-react#beta
cd ./node_modules/formsy-react
yarn install
yarn install --production --ignore-scripts

I think you'll still get a warning about the react peer dependency, but it should run okay.

If you download the tar referenced by the resolved url then you'll get a package.json that has react 15 referenced as a dependency (and not peer dependency).
Moving react from dependency to peer dependency was done by the last commit here and it has not been published to npm  yet, which explains why I keep getting the older package.json with the react 15 as dependency.
So how are you folks using the last commit?

Thank you so much @twisty ! that's what I'm looking for, it was a bit confusing for me, but now it's clear.

@twisty I've following the steps you gave and I keep getting uncaughtException: Cannot find module 'formsy-react
Formsy-react is in the package.json and in the node_modules folders but the app doesn't start and I receive this exception :(

Hi @aliogaili, I think technically it's all installed properly, but I think those errors are because the alpha 7 of formsy-react-components doesn't support the tip of the formsy-react beta branch. (It looks like Formsy.Form has gone away).
I've got an alpha ready to go that fixes this, but would prefer to wait for a new release from this repo.
I'm not keen on documenting the process of depending on this branch, which won't be fun.
I'm hesitant to call out the batsignal for @aesopwolf or another maintainer, but it would really help to get a response or an ETA on this.

I just downloaded the version currently published on the NPM registry, patched it to remove the react dependency and installed it locally, it's working, for now.
But I really hope we can hear soon from the maintainer(s) of formsy-react and we get a newer version on NPM. This is a very useful and well designed library and really not much effort needs to get it up and running. I'm sure more people will run through this issue as they start updating to React 16, so the sooner this get resolved the better. Hopefully, the batsignal does it job :)

@Semigradsky I see you made contributions to formsy-react, and as it stand it's currently blocking the adoption of React 16 because the last comment has not been published to NPM.
@twisty there are two forks of this library due to the inactivity here:

formsy-react-2 , which has been created by the @maccuaa who is also maintaining formsy-mui
formsy-react-es6 forked by @track0x1 who is also maintaining formsy-react-native

I think both of those forks exist due to the lack of activity here at the moment. I'm blocked from publishing my project because I'm using formsy-react-components which is depending on this version of formsy-react and it's conflicting with React 16. So can you please consider aligning with one of the two libraries (or even maintain your own fork if you wish) so we can move forward with this?
Thanks!

This issue has been moved to the new formsy organization: https://github.com/formsy/formsy-react/issues/7

This issue has been SOLVED in the new formsy organization with Formsy 1.1.0: https://github.com/formsy/formsy-react/


DCOS-13033: Fixing CreateServiceModalFormUtil.applyPatch function

This PR rewrites part of the CreateServiceModalFormUtil.applyPatch function in order to cover all possible patch cases. This fixes various issues.

mesosphere-ci retest this please 🙏

run unit tests

Fixed and also rebased 👍

run integration tests

LGTM - nice work @wavesoft

@wavesoft thanks for clarifying the test cases. Great job! 💯


Typography updates

This change reduces the sizes available on Heading and Text from 5 options to 3 options. Sizes map as follows:
Heading

Before
After

--
sm: 20px

xs: 24px
md: 28 px

sm: 36px
lg: 36 px (default)

md: 48px (default)
(lg: 36 px)

lg: 64px
(lg: 36 px)

xl: 96px
(lg: 36 px)

Text

Before
After

xs: 12px
sm: 12px

sm: 14px
md: 14px

md: 16px (default)
lg: 16px (default)

lg: 18px
(lg: 16px)

xl: 21px
(lg: 16px)

This PR also includes codemods to make the updates

cd gestalt; yarn run codemod --parser=flow -t=packages/gestalt-codemods/1.7.0-1.8.0/heading-size-replace.js ~/code/repo
yarn run codemod --parser=flow -t=packages/gestalt-codemods/1.7.0-1.8.0/text-size-replace.js ~/code/repo

[x] Documentation
[x] Tests
[x] Accessibility checkup

Thanks for the review. I'm going to wait to land this one until the main repo is caught up to latest (hopefully just by the end of the week)


Showing "**に適用されます:****" (Markdown notation)

https://docs.microsoft.com/ja-jp/DeployOffice/vlactivation/activate-office-by-using-mak

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2a2fe572-95d3-c2db-7a27-19ef0ba74b20
Version Independent ID: dfeea1f8-be9b-60ad-36e8-04da2458da28
Content: Activate volume licensed versions of Office by using MAK
Content Source: DeployOffice/vlactivation/activate-office-by-using-mak.md
Product: office-perpetual-itpro
GitHub Login: @DHB-MSFT
Microsoft Alias: danbrown

@hyoshioka0128 -- Thank you for pointing this out. I've notified our localization team about the issue so they can get it fixed.

The "Applies to" section was fixed, and it's displayed properly at live site


Update paper.md

Address and Name Update

Coverage increased (+0.1%) to 39.018% when pulling 5601e02fe4c05ac69a6f01b2f50d0553875d0ea3 on qmusga:patch-1 into 21f15f91c46af5df626351e631fb30e646a1aa64 on chloroExtractorTeam:develop.


5166 duplicate instance

Description
Implement the new feature to duplicate instances.
In the process, the buttons present in the expanded rows have been moved into a kebab-menu at the end of each row.
The e2e test are using the duplicate instance option whenever a second instance is needed in the test.
https://github.com/inmanta/web-console/assets/44098050/16d39958-2942-43bd-b767-a1acc3fc3bae

Processing this pull request

Pull request rejected by merge tool. No change entry file found

Merged into branches iso6, master in 610e45b8d7aff36e4bb83559741c2fcf7e99a40c