Flutter: problem with SystemChrome.setPreferredOrientations when I use it with an iPad - and error with iOS 16

In my project, I only need to have one page in landscape mode and not in portrait mode, while the rest of the pages are in portrait and landscape mode.
As per the documentation, I used SystemChrome.setPreferredOrientations
@override
   void initState() {

    // set the screen in landscape mode
    SystemChrome.setPreferredOrientations([
      DeviceOrientation.landscapeRight,
      DeviceOrientation.landscapeLeft,
    ]);

   super.initState();
}

and
@override
  void dispose() {
    // restore the
    SystemChrome.setPreferredOrientations([
      DeviceOrientation.portraitUp,
      DeviceOrientation.landscapeRight,
      DeviceOrientation.landscapeLeft,
    ]);

    super.dispose();
  }

when I exit the page to restore the portrait mode.
Now, while with the iPhone it works perfectly (the page is forced into landscape mode only), with the iPad it is as if it were not there and both landscape and portrait are possible. Of course as I don't want the whole application in landscape mode but only one page I can't act on info.plist. Has anyone had the same problem?
I have noticed that with iOS 16 it also does this error (although it works fine with the iPhone)
[Orientation] BUG IN CLIENT OF UIKIT: Setting UIDevice.orientation is not supported. Please use UIWindowScene.requestGeometryUpdate(_:)

I also saw that this is a problem introduced by iOS 16:
https://developer.apple.com/forums/thread/707735
my doctor -v
[✓] Flutter (Channel stable, 3.3.10, on macOS 12.6.2 21G320 darwin-x64, locale it-IT)
    • Flutter version 3.3.10 on channel stable at /Users/carlosacchetti/Developer/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 135454af32 (6 weeks ago), 2022-12-15 07:36:55 -0800
    • Engine revision 3316dd8728
    • Dart version 2.18.6
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/carlosacchetti/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] IntelliJ IDEA Community Edition (version 2021.1.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.74.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.58.0

[✓] Connected device (4 available)
    • iPhone 14 (mobile)                             • DEF9CAB0-24F5-44D2-8FAA-F40B260AD874 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-2
      (simulator)
    • iPad Pro (12.9-inch) (6th generation) (mobile) • F5A9C789-A17F-43B8-9751-C419E514EA01 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-2
      (simulator)
    • macOS (desktop)                                • macos                                • darwin-x64     • macOS 12.6.2 21G320 darwin-x64
    • Chrome (web)                                   • chrome                               • web-javascript • Google Chrome 109.0.5414.119

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Thanks for the report @csacchetti
The error you pointed out has been fixed as part of this issue : https://github.com/flutter/flutter/issues/111587 and should be available on latest master if you try and switch to it (flutter channel master followed by flutter upgrade --force).
The commit doesn't seem to be in latest stable yet, as I see the commit is in master version per https://github.com/flutter/flutter/commit/6ea01e6aec25405b56667b2beb3966a789f9db44
So try to switch to latest master and run your use case again to see if you still get the same behavior or not.

Thank you @darshankawar. Today I upgraded to Dart 3.7. Are you aware that the fix is also present in this latest version?

The fix should be available on latest master which is using Dart 3.0.0, but the dart version is unrelated here. If you switch to latest master and try running your scenario again, the reported error should not occur per the fix made.

I tried version 3.7 of flutter. About the Orientation problem in iOS 16 the error message,
[Orientation] BUG IN CLIENT OF UIKIT: Setting UIDevice.orientation is not supported. Please use UIWindowScene.requestGeometryUpdate(_:)

mentioned above, has disappeared.
However, the problem on the iPad where it does not rotate and gives a new error message has not yet been resolved.
This is new error only for iPad:
Failed to change device orientation: Error Domain=UISceneErrorDomain Code=101 "The current windowing mode does not allow for programmatic changes to interface orientation." UserInfo={NSLocalizedDescription=The current windowing mode does not allow for programmatic changes to interface orientation.}

As far as the iPhone is concerned, while it used to work correctly,
now when I go back to the page where all the orientations are available, it only keeps the horizontal orientation. As a workaround to get it to work I have to first send a command with only portrait and then again the command with all the orientations I want.
to give only landscape mode
@override
   void initState() {

    // set the screen in landscape mode
    SystemChrome.setPreferredOrientations([
      DeviceOrientation.landscapeRight,
    ]);

   super.initState();
}

to return with all orientations
@override
  void dispose() {
    restoreOrientation();
    super.dispose();
  }

Future<bool> restoreOrientation() async {
    // restore multiple orientation
    // before portrait for a bug in iOS 16
    await SystemChrome.setPreferredOrientations([
      DeviceOrientation.portraitUp,
    ]);
    // then all wanted orientation
    await SystemChrome.setPreferredOrientations([
      DeviceOrientation.portraitUp,
      DeviceOrientation.landscapeRight,
      DeviceOrientation.landscapeLeft,
    ]);
    return true;
  }

This is what happened after testing flutter 3.7
My new Doctor -v is:
[✓] Flutter (Channel stable, 3.7.0, on macOS 12.6.2 21G320 darwin-x64, locale it-IT)
    • Flutter version 3.7.0 on channel stable at /Users/carlosacchetti/Developer/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b06b8b2710 (8 days ago), 2023-01-23 16:55:55 -0800
    • Engine revision b24591ed32
    • Dart version 2.19.0
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/carlosacchetti/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] IntelliJ IDEA Community Edition (version 2021.1.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.74.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.58.0

[✓] Connected device (8 available)
    • ANE LX1 (mobile)                               • 89U7N18330004866                     • android-arm64  • Android 9 (API 28)
    • iPhone SE (3rd generation) (mobile)            • 56484625-7707-4C44-9F29-3D2A06988F38 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-2
      (simulator)
    • iPhone 14 Pro (mobile)                         • 52291C7F-6FD3-4BC1-8EC8-6ED2B67006F5 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-2
      (simulator)
    • iPad Air (5th generation) (mobile)             • 904BA423-E0C7-48DC-87B5-A0F4B9F85B35 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-2
      (simulator)
    • iPad mini (6th generation) (mobile)            • 23515587-CC9C-489E-A81E-F8832485186D • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-2
      (simulator)
    • iPad Pro (12.9-inch) (6th generation) (mobile) • F5A9C789-A17F-43B8-9751-C419E514EA01 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-2
      (simulator)
    • macOS (desktop)                                • macos                                • darwin-x64     • macOS 12.6.2 21G320 darwin-x64
    • Chrome (web)                                   • chrome                               • web-javascript • Google Chrome 109.0.5414.119

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Thanks for the update. Can you provide a complete minimal code sample that we can use to verify this ?
I came up with below sample but not sure if it represents your use case or not.

 code sample

import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        // This is the theme of your application.
        //
        // Try running your application with "flutter run". You'll see the
        // application has a blue toolbar. Then, without quitting the app, try
        // changing the primarySwatch below to Colors.green and then invoke
        // "hot reload" (press "r" in the console where you ran "flutter run",
        // or simply save your changes to "hot reload" in a Flutter IDE).
        // Notice that the counter didn't reset back to zero; the application
        // is not restarted.
        primarySwatch: Colors.yellow,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key, required this.title}) : super(key: key);

  // This widget is the home page of your application. It is stateful, meaning
  // that it has a State object (defined below) that contains fields that affect
  // how it looks.

  // This class is the configuration for the state. It holds the values (in this
  // case the title) provided by the parent (in this case the App widget) and
  // used by the build method of the State. Fields in a Widget subclass are
  // always marked "final".

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  @override
  void initState() {

    // set the screen in landscape mode
    SystemChrome.setPreferredOrientations([
      DeviceOrientation.landscapeRight,
      DeviceOrientation.landscapeLeft,
    ]);

    super.initState();
  }

  @override
  void dispose() {
    // restore the
    SystemChrome.setPreferredOrientations([
      DeviceOrientation.portraitUp,
      DeviceOrientation.landscapeRight,
      DeviceOrientation.landscapeLeft,
    ]);

    super.dispose();
  }

  void _incrementCounter() {
    setState(() {
      // This call to setState tells the Flutter framework that something has
      // changed in this State, which causes it to rerun the build method below
      // so that the display can reflect the updated values. If we changed
      // _counter without calling setState(), then the build method would not be
      // called again, and so nothing would appear to happen.
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    // This method is rerun every time setState is called, for instance as done
    // by the _incrementCounter method above.
    //
    // The Flutter framework has been optimized to make rerunning build methods
    // fast, so that you can just rebuild anything that needs updating rather
    // than having to individually change instances of widgets.
    return Scaffold(
      appBar: AppBar(
        // Here we take the value from the MyHomePage object that was created by
        // the App.build method, and use it to set our appbar title.
        title: Text(widget.title),
      ),
      body: Center(
        // Center is a layout widget. It takes a single child and positions it
        // in the middle of the parent.
        child: Column(
          // Column is also a layout widget. It takes a list of children and
          // arranges them vertically. By default, it sizes itself to fit its
          // children horizontally, and tries to be as tall as its parent.
          //
          // Invoke "debug painting" (press "p" in the console, choose the
          // "Toggle Debug Paint" action from the Flutter Inspector in Android
          // Studio, or the "Toggle Debug Paint" command in Visual Studio Code)
          // to see the wireframe for each widget.
          //
          // Column has various properties to control how it sizes itself and
          // how it positions its children. Here we use mainAxisAlignment to
          // center the children vertically; the main axis here is the vertical
          // axis because Columns are vertical (the cross axis would be
          // horizontal).
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headline4,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: () {
    Navigator.push(
    context,
    MaterialPageRoute(builder: (context) => const SecondRoute()),
    );
    },
        tooltip: 'Increment',
        child: const Icon(Icons.ac_unit_rounded),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

class SecondRoute extends StatelessWidget {
  const SecondRoute({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Second Route'),
      ),
      body: Center(
        child: ElevatedButton(
          onPressed: () {
            Navigator.pop(context);
          },
          child: const Text('Go back!'),
        ),
      ),
    );
  }
}

I also see that this could be iOS 16 related behavior. Although I don't have the latest iOS, but I'll request my colleague to verify this once we get a reproducible code sample.

I am experiencing a similar issue on iOS 16.2, where the SystemChrome.setPreferredOrientations only works once. If I set orientation right after building finishes, it does what it should do. But if I set it again with a different set of orientations, nothing changes.
I've tried @csacchetti 's solution, unfortunately it does not work for my case.
The SystemChrome.setPreferredOrientations setter works as it should be on iOS 15.

Thanks for providing your findings @mkobuolys and @shuotwang

When I define the orientations like this:
SystemChrome.setPreferredOrientations([
  DeviceOrientation.landscapeLeft,
  DeviceOrientation.landscapeRight,
]);

It forces the screen to rotate to landscape, all good. However, when I set the preferred orientations like this:
SystemChrome.setPreferredOrientations([
  DeviceOrientation.landscapeLeft,
  DeviceOrientation.landscapeRight,
  DeviceOrientation.portraitUp,
]);

The screen remains in portrait mode AND it gets stuck there - it seems like landscape orientations are ignored.

I tried this using latest stable (3.7.0) on iOS 15.2 and observed the same behavior, so maybe it is not iOS 16 specific ?

SystemChrome.setPreferredOrientations only works once. If I set orientation right after building finishes, it does what it should do. But if I set it again with a different set of orientations, nothing changes.

This I observed on iOS 15.2 simulator too.
Please check below similar / related issues and see if they resonates with your use cases:
https://github.com/flutter/flutter/issues/57748
https://github.com/flutter/flutter/issues/34230
https://github.com/flutter/flutter/issues/73651

About the error message on iPad (reported in https://github.com/flutter/flutter/issues/119473#issuecomment-1410337725)
It is probably related to the limitation described in SystemChrome.setPreferredOrientations documentation: see https://api.flutter.dev/flutter/services/SystemChrome/setPreferredOrientations.html
Limitations

This setting will only be respected on iPad if multitasking is disabled.

You can decide to opt out of multitasking on iPad, then setPreferredOrientations will work but your app will not support Slide Over and Split View multitasking anymore.

Should you decide to opt out of multitasking you can do this by setting "Requires full screen" to true in the Xcode Deployment Info.

Thanks @bleroux, in fact, by setting 'Requires full screen' adding in info.plist:
<key>UIRequiresFullScreen</key>
<true/>

the error disappears and landscape mode is maintained. It is a strange handling because it behaves differently to the iPhone, but indeed the iPad is not the iPhone.

@csacchetti Can this issue be closed as resolved based on above comments ?

As far as I am concerned yes

@darshankawar This is still an issue on iPhone (the one I mentioned above).

Please check below similar / related issues and see if they resonates with your use cases:
https://github.com/flutter/flutter/issues/57748
https://github.com/flutter/flutter/issues/34230
https://github.com/flutter/flutter/issues/73651

None of these really resonated with the problem I mentioned (https://github.com/flutter/flutter/issues/34230 is the most similar, I suppose). Should I ask about the problem in that issue?

Started getting this error in iphone.
Failed to change device orientation: Error Domain=UISceneErrorDomain Code=101 "None of the requested orientations are supported by the view controller. Requested: landscapeLeft, landscapeRight; Supported: portrait" UserInfo={NSLocalizedDescription=None of the requested orientations are supported by the view controller. Requested: landscapeLeft, landscapeRight; Supported: portrait}

@sanalkv For this, you need to add available app orientations to the Info.plist file, like this:
<array>
    <string>UIInterfaceOrientationPortrait</string>
    <string>UIInterfaceOrientationPortraitUpsideDown</string>
    <string>UIInterfaceOrientationLandscapeLeft</string>
    <string>UIInterfaceOrientationLandscapeRight</string>
</array>

Hi @mkobuolys , I found that these were already existing in info.plist. In fact i got these issue recently after the upgrade to flutter. Previously the feature was working without any issue. Not sure if the issue related to the latest update.

As far as I am concerned yes

Thanks. Based on OP's comment, I'll go ahead and close this as resolved.

This is still an issue on iPhone

@mkobuolys Since this original issue was specifically for iPad, let's track iphone related behavior separately.

Should I ask about the problem in that issue?

Yes, you may share your findings in that issue for better tracking.

My new doctor -v
Flutter (Channel stable, 3.7.1, on macOS 13.2 22D49 darwin-arm64, locale it-IT)
    • Flutter version 3.7.1 on channel stable at /Users/carlosacchetti/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7048ed95a5 (2 weeks ago), 2023-02-01 09:07:31 -0800
    • Engine revision 800594f1f4
    • Dart version 2.19.1
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/carlosacchetti/Library/Android/sdk
    • Platform android-33, build-tools 33.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] VS Code (version 1.75.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.58.0

[✓] Connected device (4 available)
    • iPhone di Carlo (mobile) • 8197a7889687e1b6883fab3f8b749fd17b32538b • ios            • iOS 16.2 20C65
    • iPad di CS (mobile)      • 00008027-001C504E1168002E                • ios            • iOS 16.3.1 20D67
    • macOS (desktop)          • macos                                    • darwin-arm64   • macOS 13.2 22D49 darwin-arm64
    • Chrome (web)             • chrome                                   • web-javascript • Google Chrome 109.0.5414.119

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!
```

@csacchetti
Can you please file a new issue and provide all relevant details in it so that we can track and address it properly ?
This issue has mix of iphone and ipad related behavior which makes it a bit confusing to properly track the original issue.

I'm not able to switch the master channel due to dependencies. Do we know when this'll be pushed to the stable channel? Does anyone have any workarounds?

I'm not able to switch to the master channel due to dependencies. Do we know when this'll be pushed to the stable channel? Does anyone have any workarounds?


V.06b4: player state issue

This one is reasonably new (works before):
I start a radio station on my CC group. Playing starts fine, but I can't control the individual volumes of the child CC's, as their state remained off. This was the state view:

Also strange that the volume indicator for the group is zero. ( I tried to adjust their volumes in the home app; their the state was playing and the volumes could be adjusted. BUT that didn't change anything in HA/MA)
After tapping the power buttons of the individual players (in MA), their state was correct:

Update v06b5:
I know this issue is still in. But some extra info. In MA the child player of the group cast has the wrong state (off):

The corresponding source player is correct:

Then I added two other players of the CC group. Same story.
They automatically start playing ad well, but their state in MA is wrong, while in HA the source players are correct

Nice

Ps: the state also fail's when the players where used before and I kept them powered

should be fixed in beta 6

Thanks, it works great now in beta 7


feat: show lnaddress only when oauth  account settings are accessed

Describe the changes you have made in this PR
show lnaddress only when oauth account settings are accessed

feat: New feature (non-breaking change which adds functionality)

Checklist

[X] Self-review of changed code
[X] Manual testing
[X] Added automated tests where applicable
[X] Update Docs & Guides
For UI-related changes
[X] Darkmode
[X] Responsive layout

tAck


Adding a 404-Error Page

To ensure a positive user experience, a custom 404 error page should be created and displayed when a user navigates to a non-existent or incorrect web address. This page should provide a friendly message and useful navigation links.

I Want to Work on this project @abhijeetnishal  Could you Please Assign this task to me under GSSoC'24?

Hey @AkshitGarg24 and @JaiBansal007, i guess 404 is there when some try to change url code. Contribute to other issues.


Remove the last table-row if it's not being used?

Hey!
Loving the calendar and using it in an app I'm working on atm.
I was just wondering if it's possible somehow to get rid of the very last table row if it's not being used?
This would enable me to push the content up a little more on some months and not to have a gap there.
I have attached a screenshot!
Thanks
David

Hmm I'm not sure why its doing that. There is no row there when I use the element inspector.
I'll have to dig in when I get some more time.
@coderdave Any idesa?

Does it go away if you set scrollEnabled to false?

It is because that at least one of the months in the scrollview has 6 rows and the scrollview needs to have height of 6 rows instead of 5 rows to make sure it can contain that month.


feature: concrete security calculator

Goal
Add terminal output to indicate security level for zkVM proofs, in terms of "proven security" and "conjectured security"
References
Ulvetanna's analysis - PDF
Ulvetanna's analysis - python notebook
Miden's calculator
RISC Zero ZKP Whitepaper
Work in progress
Ying Tong is working on this here

We landed a first version of the calculator (with some known issues) in #1593 and are working on further updates in #1661

looks like this has been complete so I'm going to close it. Feel free to reopen if that's not the case...

Yes indeed -- the soundness calculator is done and lives here: https://github.com/risc0/risc0/blob/main/risc0/zkp/src/prove/soundness.rs

I guess there are a few lower priority action items here:

Document how to turn on the calculator
Move the calculator to live on the verifier side rather than the prover side


Creating Firebase lisnters for main_button

Need to add critical code to app_state that will allow the app to communicate with the database. We want to make sure that we are not live updating the count, rather, we need to keep two ints:

One int that is the pulled int that is saved to the account, which is the initial display

Then one that is a local int that then will display after the intial, and will only be applied to the account after either loging out or switching pages

So we need to have a listners in some class then be able to pull the ints to the page_button.

Fixed in basic implementation, button now communicates with the scoreboard on firebase and keeps track of account score.


Support plugins? (airline, nerdtree, ...)

Will this plugin ever support other plugins like airline, nerdtree, ...?

I think this question is reversed. I'm not sure what support would look like/means in this case? If it means can these icons be used in those plugins then I think the onus to add this would be on airline or other plugins to somehow adds this functionality themselves and make this plugin a dependency not really the other way around.
For the most part other consumers of the plugin like telescope.nvim, barbar.nvim, nvim-bufferline.lua, galaxyline.lua have implemented integrations themselves without anything needing to be done on this plugin's side. Both plugins you mention are written in vimscript and would need to special case using this plugin to nvim with access to lua 🤷🏿♂ which is possible but definitely something (IMO) for them to do if they wanted.

Oh okay, I'm asking because when I also install https://github.com/ryanoasis/vim-devicons, airline and nerdtree get icon support out of the box, I assumed it was done by https://github.com/ryanoasis/vim-devicons and not by nerdtree, airline, ... but I could be mistaken
Given it was "a fork of" that project, I was expecting it to work out of the box as well. I get that it's not easy because of vim<>lua

@entropitor I actually just dug through the devicons code base searching for nerdtree and airline and you're right vim-devicons specifically hooks into apis exposed by those plugins and integrates with them. Tbh only @kyazdani42 can give you a definitive answer but imo both those integrations each look to be quite a lot of vimscript, and really seem like they should have been done in the specific plugins not by vim-devicons since it seems to go beyond the remit of what is essentially an icon pack 🤷🏿♂ .  Looks like it would be very awkward at best to try and make either of those plugins work with this package.

Okay, that's a fair point. I was just wondering 👍

Hi, yes i agree with akinsho, although it's a 'fork', i would like to preserve a library like functionality for this plugin. Implementing code for other plugins would be too much work and i do not aim for that. Also i've written my own tree plugin and that's when i had to rewrite vim-devicons because it was too slow and did not match my requirement in term of usability. People are free to fork and extend this to support plugins like nerdtree or airline though :)


Clean install and errors: Mutable dev script is in the immutable view function.

When I tried a clean installation of TextDAO:4b1083d and then I got error below.
$ forge test
[⠢] Compiling...
[⠒] Compiling 110 files with 0.8.25
[⠢] Solc 0.8.25 finished in 753.71ms
Error:
Compiler run failed:
(skip)
Error (8961): Function cannot be declared as view because this expression (potentially) modifies the state.
  --> lib/mc/devkit/utils/ForgeHelper.sol:27:16:
   |
27 |         return vm.envOr(envKey, address(0));
   |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Error (8961): Function cannot be declared as view because this expression (potentially) modifies the state.
  --> lib/mc/devkit/utils/ForgeHelper.sol:32:13:
   |
32 |         if (vm.envOr(envKey, address(0)).code.length != 0) return true;
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Error (8961): Function cannot be declared as view because this expression (potentially) modifies the state.
  --> lib/mc/devkit/utils/ForgeHelper.sol:59:16:
   |
59 |         return vm.getLabel(addr);
   |                ^^^^^^^^^^^^^^^^^
(skip)
Error (8961): Function cannot be declared as view because this expression (potentially) modifies the state.
  --> lib/mc/devkit/MCBase.sol:30:16:
   |
30 |         return vm.envOr(keyword, addr);
   |                ^^^^^^^^^^^^^^^^^^^^^^^

Just removing view and it will be fixed.

I'll close this issue as it seems to be resolved. Please reopen if the problem persists.


Exception package: 401

Hi, i have this bug
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Exception: Error from AI package: Exception: run code : 401
can you help me to fix it

Hi, i have this bug [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Exception: Error from AI package: Exception: run code : 401 can you help me to fix it

look the package now is under development . the API has changed to new endpoints that what cause the problem, im trying to refactor the package to use the new V1 version. the real problem now is that the API is experimental and not complete for production mode, im waiting now from Fusion Brain to release the full API.

Thanks for replying

i am also getting same error


As a team manager I can update individual player's number of goals scored

so that I ...

so that I can keep track of the player's scoring record.


Added ICspAsymmetricAlgorithm implementation

Updated Pkcs11RsaProvider to support ICspAsymmetricAlgorithm in order to be possible the Private key to be imported into X509Certificate2 object. Useful when X509Certificate2 is passed into a code and somewhere later the signing is done.
Added properties:
private byte[] _cspBlob;

Updated methods:
// added _cspBlob data generation from RSACryptoServiceProvider using the PublicKey
internal Pkcs11RsaProvider(Pkcs11X509CertificateContext certContext);

Added methods:
public CspKeyContainerInfo CspKeyContainerInfo; //NOTE not precise and could be improved
public byte[] ExportCspBlob(bool includePrivateParameters);
public void ImportCspBlob(byte[] _cspBlob);

Possible usage:
// Load the Pkcs11X509Store
Pkcs11X509Store store = new Pkcs11X509Store(@"C:\Windows\SysWow64\cmP11.dll", new ConstPinProvider("1234"));

Pkcs11X509Certificate pkcs11cert = store.Slots[0].Token.Certificates[0];

// Crate X509Certificate2 object with just a certificate
X509Certificate2 x509Certificate2 = new X509Certificate2(pkcs11cert.Info.RawData);

// Get PKCS#11 based private key
RSA rsaPrivateKey = (RSA)pkcs11cert.GetRSAPrivateKey();

//Set the private key to be used by Pkcs11RsaProvider
Pkcs11RsaProvider pkcs11RsaPrivateKey = (Pkcs11RsaProvider)rsaPrivateKey;

// Extend X509Certificate2 with the private key
x509Certificate2.PrivateKey = pkcs11RsaPrivateKey;

// Do the signature
byte[] sig = x509Certificate2.GetRSAPrivateKey().SignData(input, hashAlgorithmName, rSASignaturePadding);

Do I understand it correctly that the only motivation for this is change is to "carry" an instance of Pkcs11RsaProvider class in the instance of X509Certificate2 class?

Exactly because X509Certificate2 class is mostly used for signing. After this change we managed to sign using FirmaXadesNet which is the only option we found that produces XADES-XL signatures. We also use other code that requires X509Certificate2 class to be used.

After this change we managed to sign using FirmaXadesNet (with a minor fix)

Is it possible to see that minor fix somewhere?

Sure! Just did also a pull request to FirmaXadesNet project:
https://github.com/ctt-gob-es/FirmaXadesNet45/pull/15
Just added a try/catch to cover the case when certificate.PrivateKey is not of RSACryptoServiceProvider type. After this we successfully signed the XML.

I understand that this code helped you to resolve your problem. However I cannot merge it because it is just faking windows integration. It returns the name of non-existing CSP. Any app that will try to communicate with such CSP will fail. You've already seen that with FirmaXadesNet and that's the reason why you had to modify its code. Better way to modify FirmaXadesNet code would be to pass AsymmetricAlgorithm along with X509Certificate2. Take a look at CmsSigner Constructors for a real-world example from .NET team. Sample usage then can be seen in our BasicSignedCmsTest.


Fixed ps call for Docker Linux containers

Fix for Bug 1152117: Attach to process doesn't work on alpine based Linux containers. Verified on images listed here.
Before:

After:

Modern version of ps have this in the man pages.
This version of ps accepts several kinds of options:

       1   UNIX options, which may be grouped and must be preceded by a dash.
       2   BSD options, which may be grouped and must not be used with a dash.
       3   GNU long options, which are preceded by two dashes.

It looks like all the Linux based docker versions accept BSD options way, too. However mcr.microsoft.com/dotnet/core/aspnet:3.0-alpine3.9 does not allow the UNIX options way.


Backport "HBASE-23102: Improper Usage of Map putIfAbsent (#828)" to branch-2

FYI @belugabehr

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 53s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 30s
branch-2 passed

+1 :green_heart:
compile
3m  7s
branch-2 passed

+1 :green_heart:
checkstyle
0m 55s
branch-2 passed

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 18s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 23s
the patch passed

+1 :green_heart:
compile
3m  4s
the patch passed

+1 :green_heart:
javac
3m  4s
the patch passed

+1 :green_heart:
checkstyle
0m 10s
The patch passed checkstyle in hbase-procedure

+1 :green_heart:
checkstyle
0m 33s
hbase-server: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6)

+1 :green_heart:
checkstyle
0m  9s
The patch passed checkstyle in hbase-rsgroup

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 37s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 42s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

42m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5048

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 36444b7032c3 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3f25f33bc3

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server hbase-rsgroup U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 46s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 56s
branch-2 passed

+1 :green_heart:
compile
1m 20s
branch-2 passed

+1 :green_heart:
shadedjars
5m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  5s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 57s
the patch passed

+1 :green_heart:
compile
1m 18s
the patch passed

+1 :green_heart:
javac
1m 18s
the patch passed

+1 :green_heart:
shadedjars
5m 18s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 54s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 25s
hbase-procedure in the patch passed.

-1 :x:
unit
204m 21s
hbase-server in the patch failed.

+1 :green_heart:
unit
4m 14s
hbase-rsgroup in the patch passed.

239m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5048

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6e3f933523ac 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3f25f33bc3

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/testReport/

Max. process+thread count
2412 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server hbase-rsgroup U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m  2s
branch-2 passed

+1 :green_heart:
compile
1m 40s
branch-2 passed

+1 :green_heart:
shadedjars
6m 20s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  6s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  9s
the patch passed

+1 :green_heart:
compile
1m 23s
the patch passed

+1 :green_heart:
javac
1m 23s
the patch passed

+1 :green_heart:
shadedjars
5m 24s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 55s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 28s
hbase-procedure in the patch passed.

-1 :x:
unit
203m 25s
hbase-server in the patch failed.

+1 :green_heart:
unit
4m 20s
hbase-rsgroup in the patch passed.

240m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5048

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 297e5fe6c41c 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3f25f33bc3

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/testReport/

Max. process+thread count
2616 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server hbase-rsgroup U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 54s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 35s
branch-2 passed

+1 :green_heart:
compile
3m  4s
branch-2 passed

+1 :green_heart:
checkstyle
0m 57s
branch-2 passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 19s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 20s
the patch passed

+1 :green_heart:
compile
3m  5s
the patch passed

+1 :green_heart:
javac
3m  5s
the patch passed

+1 :green_heart:
checkstyle
0m 10s
The patch passed checkstyle in hbase-procedure

+1 :green_heart:
checkstyle
0m 34s
hbase-server: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6)

+1 :green_heart:
checkstyle
0m 10s
The patch passed checkstyle in hbase-rsgroup

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 36s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 30s
The patch does not generate ASF License warnings.

42m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5048

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 982a917f0557 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3f25f33bc3

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server hbase-rsgroup U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 46s
branch-2 passed

+1 :green_heart:
compile
1m  0s
branch-2 passed

+1 :green_heart:
shadedjars
4m 26s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 39s
the patch passed

+1 :green_heart:
compile
0m 59s
the patch passed

+1 :green_heart:
javac
0m 59s
the patch passed

+1 :green_heart:
shadedjars
4m 24s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 28s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
200m 59s
hbase-server in the patch passed.

+1 :green_heart:
unit
5m 13s
hbase-rsgroup in the patch passed.

230m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5048

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux be37804fa4e7 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3f25f33bc3

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/2/testReport/

Max. process+thread count
2532 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server hbase-rsgroup U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 53s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 21s
branch-2 passed

+1 :green_heart:
compile
1m 19s
branch-2 passed

+1 :green_heart:
shadedjars
4m 31s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 53s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 21s
the patch passed

+1 :green_heart:
compile
1m 19s
the patch passed

+1 :green_heart:
javac
1m 19s
the patch passed

+1 :green_heart:
shadedjars
4m 31s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 53s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 24s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
198m 55s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m 24s
hbase-rsgroup in the patch passed.

230m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5048

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 684bea657100 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3f25f33bc3

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/2/testReport/

Max. process+thread count
2526 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server hbase-rsgroup U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thanks for looking at this older one folks.


Cannot read property 'trim' of undefined when running yarn setup-dev

Hello,
Loving your project.
When running yarn setup-dev i get the error Cannot read property 'trim' of undefined
It's coming from around line 26 /devtools/dev/setup-envs-dev.js and looks like /logs/dev/candy-machine-start-date.txt is not being populated by the update_candy_machine command.
everything else seems to be working smoothly!

hey bro! You need to update your metaplex cli. If it does not work, ping me here and I will work on it.

@kevinfaveri Thanks for your swift response.
$ metaplex -V
0.0.1

Is that not the latest? It looks to be the latest on npm

It is always 0.0.1 because they are not updating it... You need to build from source. On the readme.md there is instructions for that.

If you mean this commant $ git clone git@github.com:metaplex-foundation/metaplex.git \   ~/metaplex-foundation/metaplex then i have already installed and pulled on master for this repo.

Thanks, bro @ZEAL-MATCH-LTD! It seems like Metaplex changed their CLI. I've updated the repo to reflect it and they are working now. Please pull the changes and ping me back

Pulled and getting a different error again.
/Users/zealmatch/.config/yarn/global/node_modules/ts-node/src/index.ts:692
    return new TSError(diagnosticText, diagnosticCodes);
           ^
TSError: ⨯ Unable to compile TypeScript:
../../../metaplex-foundation/metaplex/js/packages/cli/src/candy-machine-cli.ts(2,21): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
../../../metaplex-foundation/metaplex/js/packages/cli/src/candy-machine-cli.ts(3,23): error TS2307: Cannot find module 'path' or its corresponding type declarations.
../../../metaplex-foundation/metaplex/js/packages/cli/src/candy-machine-cli.ts(4,10): error TS2305: Module '"commander"' has no exported member 'program'.
../../../metaplex-foundation/metaplex/js/packages/cli/src/candy-machine-cli.ts(5,25): error TS2307: Cannot find module '@project-serum/anchor' or its corresponding type declarations.
../../../metaplex-foundation/metaplex/js/packages/cli/src/candy-machine-cli.ts(6,16): error TS2307: Cannot find module 'bn.js' or its corresponding type declarations.
../../../metaplex-foundation/metaplex/js/packages/cli/src/candy-machine-cli.ts(7,19): error TS2307: Cannot find module 'node-fetch' or its corresponding type declarations.
../../../metaplex-foundation/metaplex/js/packages/cli/src/candy-machine-cli.ts(10,41): error TS2307: Cannot find module '@solana/spl-token' or its corresponding type declarations.
../../../metaplex-foundation/metaplex/js/packages/cli/src/candy-machine-cli.ts(11,27): error TS2307: Cannot find module<EMAIL_ADDRESS>or its corresponding type declarations.
../../../metaplex-foundation/metaplex/js/packages/cli/src/candy-machine-cli.ts(30,17): error TS2307: Cannot find module 'loglevel' or its corresponding type declarations.
../../../metaplex-foundation/metaplex/js/packages/cli/src/candy-machine-cli.ts(627,15): error TS2580: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node`.

I've ran a fresh yarn install and also deleted node_modules in root and nft-manager

Thinking i need to do a fresh build on metaplex foundation. I have to hit the hay but will have a crack at this tomorrow and let you know.
Unless you see something different.

Yes. You need to reinstall the metaplex repo (clone it) and then run run npm install in the metaplex-foundation/metaplex/js/packages/cli/src/

Did it work @ZEAL-MATCH-LTD? If so, please close the issue.

@kevinfaveri Yes! thank you appreciate your help. Feel free to close.

Type mint price [default 1 sol]: 1
Type start date of the minting [default 16 Sep 2021 00:00:00]: 28 Sep 2021 00:00:00
[INFO] Cleaning older cache folder for metaplex
[INFO] Uploading all resources
[INFO] Creating candy machine
[INFO] Setting minting start date (goLiveDate)
./devtools/dev/setup-metaplex-dev.sh: 4: ts-node: not found
./devtools/dev/setup-metaplex-dev.sh: 6: ts-node: not found
./devtools/dev/setup-metaplex-dev.sh: 8: ts-node: not found
$ node ./devtools/dev/setup-envs-dev.js
/home/imentus/Documents/projects/solana-nft/code/github/solana-candy-factory/devtools/dev/setup-envs-dev.js:20
.trim()
^
TypeError: Cannot read property 'trim' of undefined
at /home/imentus/Documents/projects/solana-nft/code/github/solana-candy-factory/devtools/dev/setup-envs-dev.js:20:9
at Array.forEach ()
at /home/imentus/Documents/projects/solana-nft/code/github/solana-candy-factory/devtools/dev/setup-envs-dev.js:13:9
at FSReqCallback.oncomplete (fs.js:180:23)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Same issue on my side.

You need to reinstall the metaplex repo (clone it) and then run run npm install in the metaplex-foundation/metaplex/js/packages/cli/src/
After you do that, you need to run yarn setup-dev and go along with the prompt.

Newest version of metaplex binary is broken see https://github.com/metaplex-foundation/metaplex/issues/581#issuecomment-932818807 they recommend using ts-node and running directly. Still have been unable to get this to work on newest version unfortunately.


feat: publish intent retry

Adding retires for intent publishing.
This library is used - https://github.com/lifeomic/attempt
It has 0 deps
Some context for params usage - https://encore.dev/blog/retries
Some example of timing I get for retries

a small code sample to try it locally
import { retry } from "@lifeomic/attempt"

let counter = 0
async function main() {
  await retry(
    async () => {
      const a = new Date()
      console.log(
        counter,
        `${a.getHours()}:${a.getMinutes()}:${a.getSeconds()}:${a.getMilliseconds()}`
      )

      if (counter > 123) {
        return
      }
      counter++
      throw new Error()
    },
    {
      delay: 1000,
      factor: 1.5,
      maxAttempts: 7,
      jitter: true,
      minDelay: 1000,
    }
  )
}

main()

Comments fixed but it is weird but using dev shell script the FE can't find the module
@cawabunga-bytes


LG TV volume_set not working

Home Assistant release with the issue:
hassos: "2.12"
homeassistant: 0.103.5
machine: raspberrypi3
supervisor: "193"
Operating environment (Hass.io/Docker/Windows/etc.):
Hass.io
Component/platform:
webostv
Description of problem:
Setting the volume with service "media_player.volume_set" is not working. I tried to set it with the GUI and with calling the service, the volume is changed in HA but not on the TV. If i call the service "media_player.volume_down" or "media_player.volume_up" it is working as expected.

Sliding the volume here does not change the TV's volume. I am using a LG 65UK6500 TV and a LG SK6F soundbar connected via ARC HDMI.
Regards
Richard

I don't think volume_set can work this way controlling an external audio device through ARC.  (You can check whether it works rather when using the internal TV speaker).
You could try controlling the soundbar directly with the lg_soundbar integration (and then possibly using the universal remote integration to combine this with control of the tv from one media player entity)

I thought it's a bug because "media_player.volume_down" and "media_player.volume_up" is working, but you are right. If i disconnect the soundbar "media_player.volume_set" is working.
The integration "lg_soundbar" is not working, see here and here
So i have to write my own python script to set the volume to a defined level with "media_player.volume_down" and "media_player.volume_up".
Regards
Richard

(You probably won't be able to read the current volume of the soundbar from the TV either.)

The volume of the soundbar is readable through the TV:

0.12 equals 12 on the soundbar.
Regards

That volume level is not really usable because it is not updating if the volume is set directly on the soundbar...
Maybe the codeowner from the lg_soundbar integration responds to one of my issues.
Regards
Richard

That volume level is not really usable because it is not updating if the volume is set directly on the soundbar...
Maybe the codeowner from the lg_soundbar integration responds to one of my issues.
Regards
Richard

Hey, did you get any further on this? Have the code owner replied?
Would be nice to be able to set up automation or scripts for soundbar and TV.
Right now i'm controlling my soundbar with a IR blaster, issue with that is that i don't get any information back about what source the soundbar is set to.

Unfortunately no progress, no sign of life from the codeowner.
Regards
Richard


feat: Update PR template to something people might actually use

I notice that people largely ignore PR templates, especially big ones.
I think that shrinking this down to just the essentials will increase the
likelihood that people use it.
In particular, I want to remove things like "All reviewers approved" and
"CI build is green" that are generally already enforced by repo policies,
"Delete working branch" (there's a setting for that if we want it!), and
release instructions (should be in a central document linked from the
README).
Merge checklist:

[x] Changelog record added
[x] Documentation updated (not only docstrings)
[x] Commits are squashed

Bringing over an idea from the README template (#244): what about "poison pills" in the template? Content that needs to be removed, and can be detected easily by checks?

I'm not fond of the idea of creating more work for people who are already doing the right thing. Maybe if it was really easy to delete the marker? Or a checkbox that shouldn't be checked, heh. :-)

BTW: the merge conflicts in CHANGELOG.rst are the primary reason for tools like towncrier and https://github.com/nedbat/scriv.

@timmc-edx

I'm not fond of the idea of creating more work for people who are already doing the right thing. Maybe if it was really easy to delete the marker? Or a checkbox that shouldn't be checked, heh. :-)

If you wanted to automate this, then you could check that every box (or some critical subset of boxes) are checked. That way, to ignore the template requirement and pass the automation, you'd have to actively lie in your PR description.

Incidentally, I have a personal checklist that I used to follow at my previous job, adapted to edX: https://gist.github.com/timmc-edx/03cc4bebd9d524c7cf5b7dc268f55d21 -- something to mine for ideas, but not applicable to all repos.


Liveness probe should not use ready endpoint

Currently the Broker does not support any liveness checks.
The liveness probe should not use the ready endpoint, since it can take up to the configured snapshotInterval to be ready for each partition.
On Broker start the partitions are recreated and start reprocessing from the last snapshot, this can take several minutes up to the configured snapshotInterval. After all partitions are ready the broker is ready and the ready endpoint will return a good value.
If we use this endpoint as liveness probe k8s will probably kill the pod in a loop, since it is never ready in time. Related to that https://github.com/zeebe-io/zeebe/issues/3600#issuecomment-571914391

@Zelldon that is correct.. for such reason the initial interval is high.. but I will definitely love to see if we can expose one endpoint for that specifically. Is that doable? Can we create an issue? I might be able to work on it with some guidance..

Unfortunately the start interval is not high enough. We already have an open issue for that. https://github.com/zeebe-io/zeebe/issues/2484 This is an ongoing topic for quite a while, but we have not found any satisfied solution yet.
I while ago I thought about doing this with help of metrics, does this make sense? Do you know how other systems do this? Maybe you can add your input at this topic.

@Zelldon should we remove it for now then? until we have something reliable to trust on the liveness probes?
In my experience that is why spring boot actuators are super useful. If we have a way in Zeebe to emit an event when everything is started, having an endpoint to externalize that should be super easy. I would go with that.
Using metrics sounds super complex .. I am not entirely sure about which metrics do you mean exactly and from where are you going to read them, but having an eventing mechanism which can let us know when the broker has done all the init work will be great. Is that something that you see doable?

@Zelldon should we remove it for now then? until we have something reliable to trust on the liveness probes?

Yes this would also be my proposal.

Using metrics sounds super complex .. I am not entirely sure about which metrics do you mean exactly and from where are you going to read them, but having an eventing mechanism which can let us know when the broker has done all the init work will be great. Is that something that you see doable?

This is actually the ready endpoint. It returns only a valid value when the startup phase is done.

Maybe we can add a start up probe https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-startup-probes

@Zelldon I like startup probes.. because if the /ready endpoint is returning 200 after init is done, we should be fine with it. I will give that a try before removing the livenessProbe

@Zelldon, unfortunately, we cannot use the startup probes just yet.. they were introduced too recently (V1.16) to be supported by most Kubernetes installations. In GKE the default is currently V1.13 and you can go to V1.15 max so we will need to wait for that.

Done Zeebe Cluster Helm V0.0.45 doesn't have the livenessProbes: https://github.com/zeebe-io/zeebe-cluster-helm/releases/tag/v0.0.45 if you are using the full chart you will need to use https://github.com/zeebe-io/zeebe-full-helm/releases/tag/v0.0.29

Makes sense thanks @salaboy

Any sort of way to implement livenessProbes for Zeebe brokers? It is implemented for Zeebe gateways, so I was wondering what's the difference with brokers. Thanks!


Firefox issue

Hi,
I've spotted an issue while using this library with Firefox. Once the transition is complete, the icon (after some milliseconds) lose its thickness. Am I the only one that is experiencing this problem?

Me too, latest firefox, osx el capitan. Still, for me it's not an issue since the button is going to be used only on mobile devices.

On SO someone also reports this issue, though not with these particular "hamburgers".
Seems to be a Firefox issue.
Why is there a strange “thinning” effect visible on these span tags after the transition has finsihed?

Since this is not related to this library, I'm going to close the issue. Thanks for the SO link


Weird error MSB6006: "cmd.exe" exited with code 1 on some packages

We've been facing a very strange issue at Etcher (https://github.com/resin-io/etcher). We have node-sass as a development dependency, and lzma-native as a production dependency.
When node-gyp was updated to v3.6.0, node-sass picked up this change, causing lzma-native to fail with the following error on Windows:
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 1. [C:\projects\etcher\node_modules\lzma-native\build\liblzma.vcxproj]

So to make it clear, after the node-gyp upgrade on a development dependency (node-sass), a totally unrelated production dependency, lzma-native, suddenly starts to fail on Windows. What's even more strange is that node-sass compiles just fine, and removing node-sass from the development dependencies causes lzma-native to start working again. As a fix, we've started shrinkwrapping development dependencies as well, and locking node-gyp to v3.5.0, which makes everything work again.
The problem seems to have been introduced by https://github.com/nodejs/node-gyp/commit/ae141e19060ecb1c596a96acf9510d66b7376c18, however I don't understand why.
See https://github.com/resin-io/etcher/pull/1191. You can probably reproduce by cloning Etcher, checking out a commit before such fix, and running make electron-develop (which is a Makefile target that we use to pass some node-gyp options to npm, run bower, etc).

The problem seems to have been introduced by ae141e1, however I don't understand why.

Hmm, I wonder if the problem might be that this part of the change:
  function findMsbuild () {
    if (config.variables.msbuild_path) {
      command = config.variables.msbuild_path

means that the MSBuild command is now run with its full-path "C:\Program Files (x86)\MSBuild\...\MSBuild.exe", whereas previously it was just run as MSBuild.exe, and this additional "C:\Program Files (x86)\MSBuild\..." is now just enough to push the lzma-native compilation command over the cmd.exe command-line length limit on Windows? http://stackoverflow.com/questions/3205027/maximum-length-of-command-line-string

cc @refack @joaocgreis

hmmm... giving this some thought...

It's not a "length of command line" issue, it's a "not run from VS console" issue.
The lzma-native build calls lib.exe which is not in the path unless vsvarsall.bat (or it's derivatives) is run.
Up till node-gyp:v3.5.x the whole thing would fail. Now we can find & call msbuild.exe in the general case, but than we fail if the build is complicated ;(

Scratch that!
It's probably a bug in GYP. It eronuesly transforms
'action': [
  'lib -def:"<(module_root_dir)\\deps\\doc\\liblzma.def" -out:"<(module_root_dir)\\deps\\bin_x86-64\\lzma.lib" -machine:x64 && if not exist <(dlldir) mkdir <(dlldir) && copy "<(module_root_dir)\\deps\\bin_x86-64\\liblzma.dll" "<(dlldir)\\liblzma.dll"'
]

to
call call "lib -def:"C:\code\3party\lzma-native\deps\doc\liblzma.def" -out:"C:\code\3party\lzma-native\deps\bin_x86-64\lzma.lib" -machine:x64 && if not exist C:\code\3party\lzma-native\binding-v2.0.0-node-v51-win32-x64 mkdir C:\code\3party\lzma-native\binding-v2.0.0-node-v51-win32-x64 && copy "C:\code\3party\lzma-native\deps\bin_x86-64\liblzma.dll" "C:\code\3party\lzma-native\binding-v2.0.0-node-v51-win32-x64\liblzma.dll""
if %errorlevel% neq 0 exit /b %errorlevel%

Instead of
lib -def:"C:\code\3party\lzma-native\deps\doc\liblzma.def" -out:"C:\code\3party\lzma-native\deps\bin_x86-64\lzma.lib" -machine:x64 && if not exist C:\code\3party\lzma-native\binding-v2.0.0-node-v51-win32-x64 mkdir C:\code\3party\lzma-native\binding-v2.0.0-node-v51-win32-x64 && copy "C:\code\3party\lzma-native\deps\bin_x86-64\liblzma.dll" "C:\code\3party\lzma-native\binding-v2.0.0-node-v51-win32-x64\liblzma.dll""
if %errorlevel% neq 0 exit /b %errorlevel%

Awesome, great to hear you found the root cause of this issue! BTW, could you explain why in our case lzma-native started failing after node-gyp was upgraded by node-sass? I'm assuming that such upgrade caused lzma-native to start re-using node-sass's node-gyp version, which built node-sass fine, but caused errors on lzma-native because lzma-native uses lib.exe during build.
Is this correct?

node-gyp come with npm. It's a tool that compiles "native bindings" for some modules.
Unfortunately native bindings need to be re-compiled for every version of node (or in this case electron).
lzma-native has an online cache of precompiled bindings, seems like the new version couldn't find a precompiled pack for your platform. In that case it tries to compile it with node-gyp which triggered the bug (bug might have been there for a while)

@refack Yeah, but it’s still a curious thing how the node-sass upgrade made the difference?

I'm afraid I'll have to disagree with the (bug might have been there for a while) comment.
Up until 5 days ago all our Windows CI builds were working fine on Appveyor (including building lzma-native from source) but then all of a sudden (after the release of node-gyp 3.6.0) all our Windows CI builds started failing.
And our workaround for the problem in https://github.com/resin-io/etcher/pull/1191 was to basically version-lock node-gyp to 3.5.0 which got everything working again.

Up until 5 days ago all our Windows CI builds were working fine on Appveyor (including building lzma-native from source) but then all of a sudden (after the release of node-gyp 3.6.0) all our Windows CI builds started failing.

I said might... 🤷
I'm still digging...

Found it
Added escaping of custom actions, which may lead to broken commands
/cc @kunalspathak

Thanks @refack for the investigation. I went back and checked and it seems the quote_cmd issue was fixed in node-chakracore but https://github.com/nodejs/node-gyp/pull/873 was not updated with the fix. I will send another PR to fix this.

resolved in @3.6.1

Having the same problem in 3.6.2
$ npm install

><EMAIL_ADDRESS>install C:\Users\xavier\Documents\Carestream\server\node_modules\ref
> node-gyp rebuild

C:\Users\xavier\Documents\Carestream\server\node_modules\ref>if not defined npm_config_node_gyp (node "C:\Program Files (x86)\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "C:\Program Files (x86)\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(356,5): error MSB6006: "CL.exe" exited with code -1073741515.  System Windows_NT 6.3.9600
gyp ERR! command "C:\\Program Files (x86)\\nodejs\\node.exe" "C:\\Program Files (x86)\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\xavier\Documents\Carestream\server\node_modules\ref
gyp ERR! node -v v8.9.4
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>No repository field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"ia32"})


zap-like structural logger

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: #364
What is the new behavior?
Other information

Codecov Report
Base: 59.74% // Head: 59.74% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (89e0982) compared to base (b89cc7b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #474   +/-   ##
=======================================
  Coverage   59.74%   59.74%
=======================================
  Files         242      242
  Lines       26031    26031
=======================================
+ Hits        15552    15553    +1
- Misses       9490     9495    +5
+ Partials      989      983    -6

Flag
Coverage Δ

1.16.x
58.45% <ø> (-0.93%)
:arrow_down:

1.18.x
46.18% <ø> (-13.26%)
:arrow_down:

1.19.x
57.69% <ø> (-1.93%)
:arrow_down:

connection
10.39% <ø> (ø)

database_sql
16.50% <ø> (-0.88%)
:arrow_down:

discovery
8.68% <ø> (+0.04%)
:arrow_up:

e2e
52.03% <ø> (-0.04%)
:arrow_down:

integration
16.50% <ø> (-0.88%)
:arrow_down:

macOS-latest
36.53% <ø> (-0.03%)
:arrow_down:

ratelimiter
10.06% <ø> (ø)

scripting
10.98% <ø> (+0.02%)
:arrow_up:

table
33.00% <ø> (+0.12%)
:arrow_up:

topic
27.05% <ø> (+0.03%)
:arrow_up:

ubuntu-latest
59.69% <ø> (+0.02%)
:arrow_up:

unit
36.59% <ø> (-0.03%)
:arrow_down:

windows-latest
36.55% <ø> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

sql_unwrap_go1.18.go
0.00% <0.00%> (-55.56%)
:arrow_down:

internal/xsql/unwrap_go1.18.go
0.00% <0.00%> (-33.34%)
:arrow_down:

internal/xsql/tx.go
75.36% <0.00%> (-4.35%)
:arrow_down:

retry/sql.go
63.29% <0.00%> (-3.80%)
:arrow_down:

internal/xsql/connector.go
47.76% <0.00%> (-2.99%)
:arrow_down:

internal/xerrors/operation.go
66.66% <0.00%> (-2.57%)
:arrow_down:

internal/table/client.go
84.15% <0.00%> (-0.86%)
:arrow_down:

...al/topic/topicreaderinternal/stream_reconnector.go
94.17% <0.00%> (+1.34%)
:arrow_up:

log/driver.go
80.21% <0.00%> (+1.70%)
:arrow_up:

internal/repeater/repeater.go
91.81% <0.00%> (+1.81%)
:arrow_up:

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Maybe need to use golang.org/x/exp/slog interface ?


build error

Hi I get this error
MSB3231	Unable to remove directory "obj\Debug\netcoreapp3.1\Razor". Could not find a part of the path 'Default.cshtml.g.cs'.
try to remove the obj file but same error

We haven't seen this error. Could you please describe steps to reproduce.

Try to clean the solution

thanks ,
we can close it


Wait for the kernel to notify the veth interfaces are running

This is a revised patch from docker/docker#26492, adding a timeout and moving the synchronizing code into a separate function.
It addresses race conditions that apparently caused a few different problems.  According to my own testing, this seems to fix at least docker/docker#26492, coreos/bugs#1554, and coreos/bugs#254.

I've pushed a revision that just prints a warning instead of returning an error on timeout, since the netlink messages are documented as not being reliable.  It is theoretically possible that the notification will not be received when everything else is working correctly.
Also note that the one-second timeout was fairly arbitrary; I'm not sure what is appropriate here.  My tests' logging showed around a 1%-2% of a second delay until the IFF_RUNNING message was received, so I assumed a ~100x increase would be acceptable.

I've pushed a revision to undo what I mentioned in my previous comment to test LinkSubscribeAt in the CI tests.  If it succeeds and there are no suggestions otherwise, I plan to re-add the change from my previous comment.

So given that systemd seems to be causing unexpected interface state changes, I think it's reasonable to close this pull request and add an option to networkd instead for leaving Docker veths unmanaged.
I'll leave it up to you to close it, in case you want to continue working on this to account for external processes fiddling with the interfaces.

Thanks @dm0- . I will close it now and we can work on this again once we are able to characterize the issue and find a deterministic workaround to the kernel bug.


Set maxconn globally

Without setting maxconn in the global scope, the maximum connections are limited to 2k. This is too low and makes the setting under "defaults" meaningless.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Matt Miller seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage remained the same at 17.005% when pulling 7dd341451647dfddfa170d6c56c559d02e89f029 on mmiller1:master into 30d0eb1812e143974c242e9473baac7be4b7b93f on aledbf:master.


Custom JSX pragma for better integration with React

Motivation
Inspired by Emotion, a css prop could be attached to JSX elements for better composition possibilities.
Basic example

I am blue

Details
For compatibility purposes, the React Classic Runtime of Babel should be supported.

Unlike most existing solutions, the css prop should be passed between components for atomic composability.

I have mixed opinions on the css prop. I started using it a few years ago in our codebase and have really loved the convenience. It's only now as I step back I'm beginning to realize that maybe it was a mistake? My tweet above mentions two main reasons.

Since it's a pseudo-prop, you can't use it like a real prop (forward it, add to it, etc)

You mention passing the css prop around, and I do think that helps. Another alternative mentioned by Sunil Pai's is to only allow the css prop on dom elements. This makes needing to pass the css prop unnecessary. I think one of these approaches is necessary.
Also, as a developer using this (or any css prop library), to support css and className properly, you'll have to forward both in each of your components. Sounds painful.

Your styles are now defined via three props (className/style/css).

This is the bigger issue to me. I think it's too much of a mental disconnect using both the css and className prop. On twitter, @siddharthkp phrased it well: "css and className both are for base styles. it feels odd to use both in a project."
I like to use a css toolkit (like tailwind, basscss) and then add "custom" css as needed with a css prop. I think if you're using any css classes, you shouldn't use the css prop. They don't compose as well and feel too disconnected. Instead, use classnames (or make your own class-composition-helper).

Thank you for this interesting library! Personally I'm largely in favour of the className={css(…)} API if there are no performance downsides.
I recently commented on the emotion repository about this.
The relevant parts are:

However I think it's still a bit confusing that you assign a css prop on an element but then receive className in the component itself. I think another advantage of the className prop API is that it works for edge cases like wrapperClassName without needing additional API like ClassNames. I guess TypeScript integration would also be simpler without this mapping, e.g. a mandatory className prop doesn't seem to work with the current typings (CodeSandbox demo).

For me personally it comes down to:

css prop: Convenient API, but slightly magical and some edge cases to consider.
css function provided to className: Slightly more verbose, but explicit.

Thank you for these detailed thoughts. The css() API would be great if composition can be solved.
For example, when component A passes padding: 16 to component B which already has padding: 0 set by default through className, how may the precedences be managed? I’m thinking about making css() multi-parametered and applying the className-ified rules in order.
A Map could be used for tracking the CSS rule associated with each class name. Pulling this off correctly is complicated, though.

So you mean something like this?
function A() {
  return ;
}

function B({className}) {
  return
B
;
}

Now the css function from B receives the object and _10rtstj. As you mentioned a reverse lookup of the class name within a map to the property that produced the rule could help here.
I guess handling shorthands is something that makes this a bit tricky, e.g.:
css(
  {paddingLeft: 0},
  css({paddingTop: 5}),
  css(
    {padding: 10},
    css({paddingBottom: 20})
  )
);

// Result: `padding: 5px 10px 10px 0`;

This is of course an extreme case, but API-wise this would make sense to me 🙂.

Shorthands are hard to handle. I’m not quite sure about how they should be managed. Composition feels a bit unnatural for atomic CSS. Your idea sounds awesome, but it seems to be very hard to implement.

It seems this could be done with a Babel macro. As for resolving composition, please see issue #47.


getPlayer and getStatus in one message

Hello, Is there anyway to get getPlayer and getStatus in one message? for example, I want to have one message where I can get player version, rank, map, game, mode etc..

No, but you can suggest this feature on our discord server https://discord.gg/NSEBNMM


New-DFSNRootTarget creates spurious error

I am using New-DFSNRootTarget to create a second DFSN target to a new DFSN namespace. If I do the following:
 $NSHT2 = @{
   Path       = '\\Reskit.Org\ShareData'
   TargetPath = '\\SRV2\ShareData'
 }
 New-DfsnRootTarget @NSHT2 | Out-Null

Those step produces this output:
New-DfsnRootTarget : The requested object could not be found.
At line:5 char:1
+ New-DfsnRootTarget @NSHT2 | Out-Null
+ ~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (MSFT_DfsNamespaceRootTarget:ROOT\Microsoft\...spaceRootTarget)
                              [New-DfsnRootTarget], CimException
    + FullyQualifiedErrorId : MI RESULT 6,New-DfsnRootTarget

There is no real clue as to what object can not be found, but the DFSN is created just fine. If I use Get-DFSNRootTarget, I can see the second target just fine:
PS C:\Foo> Get-DfsnRootTarget -Path \\Reskit.Org\ShareData
Path                   TargetPath                  State  ReferralPriorityClass ReferralPriorityRank
----                   ----------                  -----  --------------------- --------------------
\\Reskit.Org\ShareData \\SRV1.Reskit.Org\ShareData Online sitecost-normal       0
\\Reskit.Org\ShareData \\SRV2.Reskit.Org\ShareData Online sitecost-normal       0

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d1efe011-5f75-9929-8de7-d35d4ff9116f
Version Independent ID: 8418a00d-7ba8-eb17-0d05-8e9e1f3cf0ee
Content: New-DfsnRootTarget (dfsn)
Content Source: docset/windows/dfsn/new-dfsnroottarget.md
Product: w10
GitHub Login: @coreyp-at-msft
Microsoft Alias: coreyp

@officedocsbot unassign @e0i
@officedocsbot assign @yogkumgit

Hello @doctordns
Thanks for your feedback.
This issue resource is specifically to address issues in documentation.
Besides that, please see this
and this
Hope this information helps you.
Thanks

The cmdlet still creates a spurious error message. :-)

I agree with you @doctordns  that the cmdlet should better describe the error, please visit this resource to suggest that improvement https://windowsserver.uservoice.com/forums/301869-powershell as that is out of the scope of Docs.
Thank you

@officedocsbot close

Using the above script , I cannot create the DFS Root target to Network Share . I have a requirement where I need to access the Share using the Root name space in 2016 Server .
With 2019 I am getting error  like
New-DfsnRootTarget : One or more parameter values passed to the method were invalid.
with 2016 I am getting error like :
New-DfsnRootTarget :  Can't add DFS Namespace Folder target "\Hostname\Share"
Windows System error 1168 , New-DfsnFolder Target .
What changes you made to update the DFS Root target folder to Network Share .

you need to use the FQDN Fully Qualified Domain Name when using at least the -TargetPath argument.


Custom note splashes animation don't play

Describe your bug here.
Custom note splashes animation don't play, It only shows the first interframe and disappears, not running the following frames. And in NOte splash debug, when press A button to save, a error window show.
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No

problem from you put it at mods not assets,idk but maybe this not bug,xml and txt need change name
like noteSplashes-diamond
change txt and xml name to    note splash-diamond

problem from you put it at mods not assets,idk but maybe this not bug,xml and txt need change name like noteSplashes-diamond change txt and xml name to note splash-diamond
it need change when files at mods if at assets so name is noteSplashes-name

I use the mod pack in Gamebanana, i put it in mods folder, pc player haven't have this bug. And how about save problem, did u fixed it?

put it at .PsychEngine/assets

put it at .PsychEngine/assets

But this iss mod folder

#4 Tôi đã liên lạc lại với bạn rồi

Still don't work, use custom note splashes by yourself and see if this bug happen in your phone

it work on my phone

it work on my phone

Strange


[Bug]: Weird behavior with label commands

What happened?
There was some odd behavior in #22265 around labels which should be fixed.
Issue Priority
Priority: 2
Issue Component
Component: beam-community

.add-labels website
.remove-labels P2

.add-labels website
.remove-labels P2


Docs.rs documentation fails to build

The build logs are here: https://docs.rs/crate/libflatterer/0.19.12/builds/1122348

@JohnTheCoolingFan, sorry, I have not put effort into the rust docs as it is mainly used as library for the python bindings.
Duckdb has difficulty running on docs.rs.  Added feature to remove it and made docs.rs remove the feature and it works now: https://docs.rs/libflatterer/latest/libflatterer/index.html


Localization always returns english clulture

My views contains swedish text e.g.
@Localizer["Välkommen"] // means welcome
If I have a english resource for my view e.g. Index.en.resx this text will get translated to the english text no matter what! Even if I configure the app not to even support english, eg:
services.Configure<RequestLocalizationOptions>(options =>
        {
            var supportedCultures = new[]
            {
                new CultureInfo("sv"),
                //new CultureInfo("en")
            };

            options.DefaultRequestCulture = new RequestCulture(culture: "sv", uiCulture: "sv");
            options.SupportedCultures = supportedCultures;
            options.SupportedUICultures = supportedCultures;
            options.RequestCultureProviders.Insert(0, new CustomRequestCultureProvider(context =>
            {
                return Task.FromResult(new ProviderCultureResult("sv", "sv"));
            }));
        });

and in configure app:
var locOptions = app.ApplicationServices.GetService<IOptions<RequestLocalizationOptions>>();
        app.UseRequestLocalization(locOptions.Value);

Pretty frustrating, so the workaround for now is to simply rename the resource files to some other culture, norweigan for instance e.g. Index.no.resx.

I configure the localization options like this, but the configuration that you did should work too. To make things work as expected you should add a Swedish resource file like the following Resources/Views/ControllerName/ViewName.sv.resx

What you're proposing is something entirely different. My views contains Swedish text so there is no .sv.resx files since Swedish is the default. The user may choose to switch to English however, and if there is any ViewName.en.resx files, the text will be localized to English no matter what. See the difference?

My workaround for this is to put the English localization into some bogus language like Norwegian e.g. ViewName.no.resx and camouflage Norwegian as English.

@ajtowf can you update to the latest version, I tried to use the localization sample with English & Swedish as supported cultures, Swedish is the default one. I added Startup.en.resx, so when I visit http://localhost:5000 it retrieve "Välkommen", when I visit `http://localhost:5000/?culture=en&ui-culture=en' I got "Welcome", these are the correct and expected result.
If i'm not wrong it was bug, because I saw a similar result like what you mentioned before I update to the latest changes

@ajtowf it doesn't sound like this is your issue, but as a warning it is generally a bad idea to rely on the behavior of your "default" language (that is, the one which ".resx" instead of ".lng.resx") without manually setting that language as described here. Without setting that one way or another if you deploy to an English EC2 instance after developing in Swedish you will get the wrong language out of your default language.
That said, it sounds as if you're having a different issue. Once you've ensured you have the latest versions of MVC and localization as @hishamco suggested, if you're still having trouble I think the next step would be for you to provide a reproduction repo for us to troubleshoot against. Since our samples don't have this problem it's likely an edge case or configuration problem that won't be apparently until we can run your app.

@ryanbrandenburg so my default language isn't in .resx, it's in the views, I only have lang.resx for non-default languages, e.g in Index.cshtml:
@Localizer["Hej hej, hemskt mycket hej!"]

will have a corresponding Index.en.resx that contains
Hej hej hemst mycket hej! -> Hello Hello, very much hello!

i won't have a Index.resx.
as recommended in https://docs.asp.net/en/latest/fundamentals/localization.html is that bad? Or am I missing something fundamental?
Also the user is allowed the change the lang by clicking links which will set the preffered lang in a cookie as described in the docs. Isn't that safe if we've specified the default request culture? Very confusing if not.
I'll try to update the versions and see if the problem still exists.

If you have no "base" resx then ignore my first paragraph as it's irrelevant to you.
Setting a default request culture should have no bearing on the ability to use the CookieRequestCultureProvider. I note that you had a CustomRequestCultureProvider in you snippet, which would cause you to always get Swedish as the request culture, but I assume that was added for testing purposes.

@ryanbrandenburg yes the custom provider is just to illustrate that it doesn't matter what the user "chooses" it's always english. Same problem with latest versions, I'll create a sample repo to reproduce the bug.
By the way the samples don't suffer from this since the default language is english and it's possible to switch to french.
I'll get back with a sample app, thanks!

@ryanbrandenburg @hishamco simple minimalistic repo to reproduce the bug https://github.com/ajtowf/LocalizationBug/
Maybe @DamianEdwards is interested?

I have exactly the same problem.
I have implemented my own RequestCultureProvider, but the returned culture is ignored by the IStringLocalizer. However, it is used by AnnotationsLocalization so my annotations are translated correctly.
I have basically the same setup as provided in the example of @ajtowf

@ajtowf this was an interesting one! I was finally able to replicate this behavior by renaming a resource file from one language to another. When you look in the bin directory after doing that you'll see the folder for your new language, but you'll also still see the folder for the language that no longer has any resx files.
More generally this is to say that language folders (and their discovery by dotnet) won't go away unless you 1) delete the language folder or entire bin directory 2) overwrite them with a new resource.
This is known behavior of the cli. Can you delete the bin and obj directories of your project and confirm that fixes it for you?

That's the idea I want to suggest 😄

@ryanbrandenburg so you mean by simply cloning my repo you get Swedish and not English when passing ?culture=sv as query param? @hishamco same for you? Why would I want to rename the resource files? I have English resources, that's correct. I'd say what you are suggesting is something entirely different.
Just to make myself clear again, my claim is that if you have an "en" folder, which contains the English localization that one will always get served. There is no need for renaming any resource files to any other language and then deleting the old ones, that's not relevant.

By simply having a English localization one would expect it not to be served when browsing the default Swedish localization.

Isn't this the same thing as https://github.com/aspnet/Home/issues/1707 ? I see you've been active there as well @ryanbrandenburg

Just verified this is only a problem when targeting framework netcoreapp1.0, works for full net451, just updated (the sample repo)[https://github.com/ajtowf/LocalizationBug/], it's obvious this is a bug, try switching between full and core framework.
@davidfowl I've seen you've been involved in other threads, care to comment? ;-)

You need to use .NET >= 4.6 to get the behavior you want.

@davidfowl thx for answering mate.
Right, so this won't be possible targeting core at all?
How can this not be a bug?

Oh wait, I misread that, I thought it did work with core and not on .NET Framework.

@davidfowl it would just be nice if this would be recognized as a bug, imho the sample repo to reproduce must be enough. I keep getting suggestions in this thread that's completely irrelevant, it's getting ridiculous.

some bogus language like Norwegian

Heyyy! :angry:

@khellang sorry mate, no offence, I'm a swede btw, sorry to hear about Johaug! ;-)

Heh. Just trolling :wink: Yeah, "sorry" :stuck_out_tongue_closed_eyes: #SorryNotSorry

@ajtowf sorry for any confusion, I was saying that renaming your resource files is a way to have a problem like this, not suggesting that you rename it as a solution. It IS true that renaming your resource files can give you these problems (regardless of framework) but after reading your most recent post I found that you are correct that it's not the problem you're running into.
Though the resultant description of behavior is the same as aspnet/Home#1707 they are not the same root cause, since in both your reproduction app and the more minimal one I've created the language directories are copied over.
I was able to replicate your problem reliably on netcoreapp and narrowed it down to a change in behavior in ResourceManager. I've created an issue against corefx here.
Unfortunatly while we're waiting on the corefx team to resolve this issue the only ways I can see to avoid this problem are to use "bogus" languages like you have, or to not use netcoreapp, which are both less than ideal.

@ryanbrandenburg cool, thx mate, I guess I'll go with the "awesome-other-language"-workaround (@khellang) for now until it's fixed and keep an eye on the issue you created. Feel free to close this bug, I don't know what your practices are for handling issues.

@ryanbrandenburg can you please fix the link of the corefx issue to https://github.com/dotnet/corefx/issues/12625

Thanks @hishamco.

Moving to 1.2.0 per the email discussion.

Same problem... very frustrating seeing that the official docs make it clear that this scenario is not only supported, but advised:

We anticipate that many developers will not create a default language resource file.

(emphasis not mine)

If you want to just return the key when missing a resource for the requested culture you must not have a default resource file.

Should be changed to:

If you want to just return the key when missing a resource for the requested culture you must not have a default resource file. At the moment, a resource file with an ".en" (or ".en-US") culture designator is considered a default resource file.

The issue is that in .NET Core it ultimately falls back to the Invariant Culture, which is en-US.
This makes translating web apps (where the language of the keys is not english) more cumbersome. Now you have to create a resource file for the strings that you are already using as keys.

@wc-matteo you wouldn't believe how much time I've spent discussing this, just check out this thread https://github.com/dotnet/corefx/issues/12625, the discussion with tarekgh and gkhanna79 is mind blowing. Let's hope we get a fix soon, I wouldn't hold my breath though...

@ajtowf yep, I saw that thread... at least @ramarag nailed the issue... let's hope...

@ajtowf yep, I saw that thread... at least @ramarag nailed the issue... let's hope...

@ajtowf @ryanbrandenburg @hishamco , same problem here in VS 2017 RC Asp.Net Core 1.1. This is a very nice bug. The statements made in the docs are incorrect and lead to the confusion in my opinion; it would be better to clarify that this is not 2-way (en or OS language->sv vs sv->en or OS anguage) until the issue is cleared.

Fixed by #333.