document mutation testing vs fuzz testing

Fuzz testing randomly varies the input to the program and sees if the program will crash. Mutation testing deterministically varies the program (in ways that will probably still compile) and sees if your tests detect the change.
Probably pseudo-random edits to the program are introducing bugs that should be caught by tests, and so if no tests fail that might be a gap in test coverage. (Or, it might be that the edit is semantically harmless, or it changes something that is very hard to test hermetically, such as making something slower…)
fuzz testing is generally used to tell you that your program will crash/hang/spin on bad input (i.e. there are bugs in your code, if you can’t trust the input); mutation testing tells you that some presumably-bad edits to your code would not be caught — i.e. if a hapless contributor proposed some patches they would not be caught by CI
fuzz testing e.g. with cargo-fuzz for Rust requires that you have an interface to “run the code on this blob of bytes”, e.g. “parse this blob of bytes as an MP3 file”; mutation testing doesn’t make any assumptions about the structure and doesn’t need you to write a harness: you can just run it on any existing crate with hermetic tests.
fuzz testing is necessarily sampling-based because there are so many possible input files once you get beyond a couple of bytes (256 << n_bytes); mutation testing can in principle test every mutation it can generate. (Although for large crates that might be a large number, it’s still probably only in the thousands-millions, not astronomical.)

Fixed in https://github.com/sourcefrog/cargo-mutants/wiki/Compared


Click on '....'
Scroll down to '....'
See error

Screenshots / Recording
No response
Operating system
iOS
Bitkit version
33
Log output
No response

+1

Duplicated. Closing the issue.#785


test osx and 32-bit linux

closes #2

@homunkulus r+

:pushpin: Commit 41bea38 has been approved by japaric

:hourglass: Testing commit 41bea38 with merge 41bea38...

@homunkulus r+

:pushpin: Commit fe25483 has been approved by japaric

:hourglass: Testing commit fe25483 with merge fe25483...

:pushpin: Commit ce7edfc has been approved by japaric

@homunkulus r+

:hourglass: Testing commit ce7edfc with merge ce7edfc...

@homunkulus try

:hourglass: Trying commit 26698bb with merge 26698bb...

:broken_heart: Test failed - status-travis

@homunkulus try

:hourglass: Trying commit b18afbe with merge b18afbe...

:broken_heart: Test failed - status-travis

:pushpin: Commit 7a8039b has been approved by japaric

@homunkulus r+

:hourglass: Testing commit 7a8039b with merge 7a8039b...

@homunkulus r+

:pushpin: Commit 7b9f2ed has been approved by japaric

:hourglass: Testing commit 7b9f2ed with merge 7b9f2ed...

:sunny: Test successful - status-travis
Approved by: japaric
Pushing 7b9f2ed1d3d215f7b1d2c27e0edf852b68dddb58 to master...


feat(ts-gen): display progress bar via websockets

Still need to add the progress inside DB for the listener and fix the issue on random test I introduced about event buses


Question: Can I use this for steering wheel input?

I'm using godot 4.2
If yes, can I somehow implement force feedback?

I don't have a steering wheel to test with. Does it show up as joypad input in Godot?


404 on /en/en.json during Project Open

Similar to #2835 we have a 404 for /en/en.json when we open a project.
Tested with OpenRefine 3.3 and 3.4.1
OS Linux with Chrome
GET http://<IP_ADDRESS>:3333/en/en.json 404 (Not Found)

This looks like it's coming from /extension/database/scripts/project/database-exporters.js.
https://github.com/OpenRefine/OpenRefine/blob/1157cb047ca7192d7a3e5f5afe4a230482335606/extensions/database/module/scripts/project/database-exporters.js#L31-L44
With my language set to fr, I get two 404s, one for /fr/fr.json and one for /fr/enjson, presumably due to fallback processing.

I tried reproducing this and no longer get a 404 error, the translations for the database exporter just load fine here.


Replace print with logging

Replace print with logging to allow finer-grained control over what gets printed out and avoid huge lines of logs

Sweet, thanks!


Bzlmod Migration

Hey @mvukov ,
Will keep on updating the PR ... as we move on bzlmod transition

So few things !

I've added .devcontainer for vscode development its easier to develop inside docker for this project to isolate all the code.

Trying to make sure that to see if poetry would help us cross compile the code to aarch64 only issue i found was netifaces maybe has to be recompiled with clang for the wheel file since it only supports x86 and poetry throws an error since it could not find it for my laptop (ARM64)

I am also expermenting with hermetic_cc_toolchain which uses zig to compile the c/cpp code ! lot faster and less configuration

Please let me know your thoughts on this ! so we could proceed further accordingly ... Thanks 😁

This work is still fresh, so converted it to draft. As-is right now, the PR has some unrelated changes. If you want to introduce bzlmod, I'd suggest to "just" do that in this PR and leave rules_poetry, cross-compilation, dev containers for follow-up PRs. This way the PR is going to be much shorter and easier to review.

This work is still fresh, so converted it to draft. As-is right now, the PR has some unrelated changes. If you want to introduce bzlmod, I'd suggest to "just" do that in this PR and leave rules_poetry, cross-compilation, dev containers for follow-up PRs. This way the PR is going to be much shorter and easier to review.

Hey thank you, So well I could link multiple issues with this PR for rules_poetry, cross-compilation, dev containers to follow up .... I thought to wrap it up in one go. but sure if you wanna do that I could only make it for bzlmod

Follow-ups should go to follow-up PRs, this one should be as small as possible.

Hi folks, I've also been actively working on migrating our workspaces to bzlmod, including rules_ros2.
As a first step, I migrated rules_pcl, PR is here: https://github.com/kgreenek/rules_pcl/pull/17


Removing patchNode, patchKoa options

Removing the patchNode and patchKoa options.
As part of the next major release, addresses https://github.com/dlau/koa-body/issues/139#issuecomment-480223780
Ping @damianb to review.

Looks okay.
Question - should we or should we not also do something along the lines of ctx.request.body = {} at the very beginning of the middleware lifecycle?  That way we can remove the undefined union typing of ctx.request.body and leave it entirely as any.  (ctx.request.files is perfectly fine to still have typed as Files | undefined.)

Also, potentially related to #144 as a result.  Could address that root issue if we consider the bit in the prior comment.

Definitely thinking now that a follow up PR should handle setting ctx.request.body consistently and also look into addressing #115 simultaneously.
I'm okay with merging it.

I'm OK with type changes in v5 but I think we should do this in another PR and attempt to be type-compatible with koa-body's type definition, which now appears to be any.


Update docker pool names for new project.

Closing in favor of doing this on the nightly branch first (then merging over). https://github.com/microsoft/go-images/pull/169. Thanks again for the initial work.


upgrade tokio 1.34 => 1.36

tokio 1.36 has been out for a month.
Release notes don't indicate major changes.
Skimming through their issue tracker, I can't find open C-bug issues that would affect us.
(My personal motivation for this is JoinSet::try_join_next.)

Proxy recently forked copy_bidirectional, which had some changes since. Notably only cooperative budget stuff. Potentially need to make some changes there, but nothing blocking https://github.com/tokio-rs/tokio/issues/6250


Unclear ErrNewSemVersion

What did you do?
Run
dlv debug ./cmd/cdc -- server
./bin/cdc cli changefeed create ...

What did you expect to see?
When running the server as dlv exec bin/cdc -- server things work fine. Same for running outside of delve.
What did you see instead?
Error: [CDC:ErrNewSemVersion]create sem version: None is not in dotted-tri format

Versions of the cluster
Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):
sql> SELECT tidb_version()\G
*************************** 1. row ***************************
tidb_version(): Release Version: v5.3.0
Edition: Community
Git Commit Hash: 4a1b2e9fe5b5afb1068c56de47adb07098d768d6
Git Branch: heads/refs/tags/v5.3.0
UTC Build Time: 2021-11-24 13:32:39
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0008 sec)

TiCDC version (execute cdc version):
$ ./bin/cdc version
Release Version: v5.4.0-master
Git Commit Hash: 7d9dd2f1d220084e8480f793be160e3a49bb8887
Git Branch: master
UTC Build Time: 2021-12-30 16:04:38
Go Version: go version go1.16.12 linux/amd64
Failpoint Build: false

The problem with this is that it is unclear which of the following has the wrong version: PD, TiKV or the CDC server.
Would be good if the error would indicate which component has the wrong version.
It would be great if this would work when using Delve, but that's not as important as a more informative error.

Running Delve like this makes it more diffcult to debug as Delve might not have the right path for the source files and the build may be optimized etc.

We can pass build flags to dlv too via build-flags: dlv debug --build-flags="-ldflags='-X github.com/pingcap/tiflow/pkg/version.ReleaseVersion=v5.4.0-master'" ./cmd/cdc -- server

maybe we need a script to get build flags, such as

$ dlv debug --build-flags="$(./get_build_flags.sh)" ./cmd/cdc -- server

➜  cat get_build_flags.sh
#!/bin/bash

echo "-ldflags='-X github.com/pingcap/tiflow/pkg/version.ReleaseVersion=v5.4.0-master'"

Would you please take a look @CharlesCheung96

@amyangfei maybe we should put that in the README?
And maybe something like this:
echo "-ldflags='-X github.com/pingcap/tiflow/pkg/version.ReleaseVersion=$(git describe --tags)"

to not hardcode the version.

@amyangfei maybe we should put that in the README?
And maybe something like this:
echo "-ldflags='-X github.com/pingcap/tiflow/pkg/version.ReleaseVersion=$(git describe --tags)"

to not hardcode the version.

yes, the build flags should be generated dynamically, like what Makefile does, this is just a demo to show how it works.


Adding text in Videos at top

Script Title - Video_textadder
Brief - Script should able to add text at the top of the video (User have the choice to customize font size)
Instructions

Create a new folder for your script and file/folder name should be appropriate.
Create a README.md in your folder for program Instructions
add requirements.txt if needed

Programming Language

[x] Python

Happy Coding

@pawangeek
I am also able on this task. Could you assign it to me?

The first task first. I will surely assign this to you :)

@pawangeek
The first one have been merged. Might I start working on this task?

Yes, you can


Chart doesn't update

I want my chart to be refreshed when the model is changed. For instance, I'd like my datasets' labels to be dynamically defined by user input.
Here's a zip file containing an example project (from @mharmer 's other issue): ElmLabelTest.zip
I can get the doughnut to show, typing something in the input element does change the model (as it shows in the h2 I've added for hat purpose), but the chart's label doesn't change from its original value:

Am I missing something in my project?

I have same probleme, when my model change, my chart  does not update.


Fix travis unit test failures

Signed-off-by: Joe Grund<EMAIL_ADDRESS>

Codecov Report

Merging #1252 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1252   +/-   ##
=======================================
  Coverage   95.39%   95.39%
=======================================
  Files           2        2
  Lines         152      152
=======================================
  Hits          145      145
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce3b3a...345fe13. Read the comment docs.


Missing dot in documentation

In this page: https://registry.hub.docker.com/u/lfex/lfe/
There is a commando without a dot in the end. It should be:
docker build -t my-lfe-app .

For a smooth ride,
we don't want to refer to an docker image called "lfe:0.10"
on this page: https://registry.hub.docker.com/u/lfex/lfe/
"lfe:0.10" does not exist for new users.
It's better to only refer to "my-lfe-app".
Since this one will exist if the user just built an image.

A very belated response here ... I fixed the version issue last week and just fixed the "commando" (lI like your term) now.
A note on the version -- at the time the Dockerfile was created, the dev version had got bumped in the repo, but then went back to 0.9.x. It has since gone back up to 0.10.x, but hasn't been released yet. It was a moving target :-)
Feel free to close this issue, if it all checks out at your end (I don't have perms to close).


Upgrade tested AGP versions

from 8.7.0 to 8.7.3
from 8.8.0-alpha04 to 8.8.0-rc02
introducing 8.9.0-alpha06
bumping the 8.9 nightly
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test AFT AST APT

The following builds have passed:

All Functional Tests for Pull Request Feedback (Trigger) (Pull Request Feedback)

Build Scan

The following builds have passed:

All Performance Tests (Trigger)

Build Scan

The following builds have failed:

All Smoke Tests for Pull Request Feedback (Trigger) (Pull Request Feedback)

Build Scan


[SPARK-38126][SQL] Check the whole message of error classes

What changes were proposed in this pull request?
In the PR, I propose to check the whole error messages of error classes in the test suites Query.*ErrorsSuite.
Why are the changes needed?

To catch changes in error classes.
To improve test coverage.
Set user expectations from Spark's errors.
The checks can document error messages in tests.

Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running the modified test suites:
$ build/sbt "test:testOnly *QueryParsingErrorsSuite"
$ build/sbt "test:testOnly *QueryCompilationErrorsSuite"
$ build/sbt "test:testOnly *QueryCompilationErrorsDSv2Suite"
$ build/sbt "test:testOnly *QueryExecutionErrorsSuite"

@cloud-fan @imback82 @ivoson @SaurabhChawla100 @yutoacts @leesf Could you review this PR, please.


Fix an issue with ruby build in Digest class

An extensive explanation of this error can be found here. It seems like an race condition within rubies build Digest class. So it's better to use openssl digest.

Coverage remained the same at 98.867% when pulling 3e72c1907ca161c7128e2c869b8087074ad3a4a6 on feature/change_digest_class into d0c6d3e11396db056f508075b0df61496fdcfd29 on master.

Coverage remained the same at 98.867% when pulling 8091598c5b5759276f4ac3a6ce789c20a8fb3e0a on feature/change_digest_class into d0c6d3e11396db056f508075b0df61496fdcfd29 on master.

Coverage remained the same at 98.867% when pulling b00c2ab5fbdd88a4e3f9e1525c72173a2245ec69 on feature/change_digest_class into d0c6d3e11396db056f508075b0df61496fdcfd29 on master.

Coverage remained the same at 98.867% when pulling b00c2ab5fbdd88a4e3f9e1525c72173a2245ec69 on feature/change_digest_class into d0c6d3e11396db056f508075b0df61496fdcfd29 on master.

Coverage remained the same at 98.867% when pulling 7702c1c7b81d4d1cef4dfb664087ab65d8ccbb67 on feature/change_digest_class into d0c6d3e11396db056f508075b0df61496fdcfd29 on master.


Singleton with parameters?

Great article!
I would like to ask you: do you have some clever solution for a Singleton to which we need to pass parameters? Let's say URL and APIKey? Solution with class constant doesn't work due to initialization order. Which approach would you suggest?

I have the same question. What do you think about this? Singleton with parameters.

What's the matter with using simple object properties?

Here is an example of how this might look like using Approach A in this repository:
//: A simple parameterized Singleton example

import UIKit

// The Singleton class with parameters
class SingletonA {

    // MARK: - Class Stored Properties

    static let sharedInstance = SingletonA()

    // MARK: - Object Stored Properties

    private let baseUrl = "http://https://github.com/hpique/SwiftSingleton"
    private let apiKey = {
        // TODO: Get your API-Key from a secure place (like the Keychain)
        return "your retrieved API-Key"
    }()

    // MARK: - Initialization Methods

    init() {
        println("AAA");

        // Note: Alternatively you could set the baseUrl and apiKey values here
    }

    // MARK: - Object Methods

    // TODO: Your methods go here ...
}

// Usage:
SingletonA.sharedInstance

//: Please note that you could make the Object Stored Properties non-private
//: in order to be able to use them in other classes.

If this doesn't answer your question you might be better with using a different pattern than a Singleton. See this great answer on StackOverflow as a first read for that.

Well, they have to be compile-time constants. I was thinking if there is a way to create singleton using syntax SingletonA('abc') where you provide initialization data only once.

In that case, just use the Factory pattern instead – Singletons are not made for this. You can still create a class that holds your factory object(s) as a class property though so you can use your factory object everywhere in your code, much like a Singleton.

Thanks for explanation, it is really useful.

Glad I could help. I suggest we close this issue then as this is not really an issue with this repository (which is intended to be an implementation of the Singleton pattern only).

Sure, simply didn't have idea how to chat otherwise :)


open links prompt to select url for copying

@michael-lazar

Thanks woorst. I made the following changes and merged

Added tests
Changed the behavior to not flash the screen if the user is presented with the prompt but doesn't select a link.
Made the code more tolerant of missing content fields. E.g. the same method was using bothdata.get('permalink')  and data['permalink'] interchangeably.


Update Japanese message catalog for nodes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

This PR adds missing Japanese translation of message catalogue for nodes.
Also fixes missing label in settings UI of websocket config node.
Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage remained the same at 76.878% when pulling 3d272d0f10e03dc626a574a9954397a0192fd159 on node-red-hitachi:update-JP-catalog-for-nodes into 47de85b012251bbad1c9bb32b041759e8619b5c7 on node-red:dev.


【ADD】update node servant revert step

What type of PR is this?

/kind enhancement

What this PR does / why we need it:
Sometimes the node has residual certificate files related to tunnels, if we still use this nodes to join the cluster, the invalid certificate cannot create the grpc tunnel, it can make the error for connection closed.
If we don’t open the grpc process debug parameter, it’s hard to find it. So we need to clean the tunnel directory when node-servant do the revert option.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

/lgtm
/approve


minor build warning

Successfully built ethminer 0.9.41-genoil-1.0.6 with gcc (Ubuntu 4.8.4-2ubuntu1~14.04.1) 4.8.4, but a minor build error was reported:
[100%] Building CXX object ethminer/CMakeFiles/ethminer.dir/main.cpp.o
In file included from /root/cpp-ethereum/ethminer/main.cpp:39:0:
/root/cpp-ethereum/ethminer/MinerAux.h: In member function ‘void MinerCLI::doFarm(dev::eth::MinerType, std::string&, unsigned int)’:
/root/cpp-ethereum/ethminer/MinerAux.h:872:9: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wparentheses]
if (current.seedHash != newSeedHash)
^

fixed with https://github.com/Genoil/cpp-ethereum/commit/63acddf812af0cc09e23652cb622c6b509038262


Special build for Pybricks Code

Since EV3 doesn't work with Pybricks Code, it would be helpful if we could add some ifconfig around the EV3 stuff so we can make a Powered Up-only version of the docs. The HTML output of this configuration should be packaged in a JavaScript package so that we can pull it in to Pybricks Code. This will allow Pybricks Code to be a fully offline app and will hopefully reduce confusion about EV3 not working with Pybricks Code.

Since pybricks-api is set up for multiple targets already, another thing we could do is split off the EV3 docs altogether. But maybe we'll need to look at what to do with future EV3 support first.

This is now available by building
poetry run make -C doc SOURCEDIR=ide html

This is now available by building
poetry run make -C doc SOURCEDIR=ide html

Since EV3 doesn't work with Pybricks Code, it would be helpful if we could add some ifconfig around the EV3 stuff so we can make a Powered Up-only version of the docs.

Done

The HTML output of this configuration should be packaged in a JavaScript package so that we can pull it in to Pybricks Code. This will allow Pybricks Code to be a fully offline app and will hopefully reduce confusion about EV3 not working with Pybricks Code.

This is still to be done, assigning @dlech.

Since EV3 doesn't work with Pybricks Code, it would be helpful if we could add some ifconfig around the EV3 stuff so we can make a Powered Up-only version of the docs.

Done

The HTML output of this configuration should be packaged in a JavaScript package so that we can pull it in to Pybricks Code. This will allow Pybricks Code to be a fully offline app and will hopefully reduce confusion about EV3 not working with Pybricks Code.

This is still to be done, assigning @dlech.


Unable to find the testng xml in the project structure

Unable to find the testng xml in the project. I need to run my test in the specific order and where can I mention the tests?

Unfortunately, test ordering is not supported via testng.xml today.
You could, however, achieve this by having one test which calls the other tests in the order desired.
The downside to this approach being that device farm will track that one test on a high level so any failures in the test will need to be figured out by digging in the logs.


Looks like -importall has a problem

Looks like -importall has a problem or I'm not using it correctly. can you help me ?

i fixed it here
v1.4
close the issue if your problem fixed

@nonamebatbai
i fixed it here
v1.4
close the issue if your problem fixed


android video fullscreen not working

hi
android video fullscreen mode not working

The video widget does not have a fullscreen mode. If you want your video to be fullscreen you will have to lay it out to cover the entire screen.

this screen layoutData:{left:0:right:0:top:0:bottom:0}
How should I set it up? @mpost

tabris.ui.displaymode

When I add the video object to the page, the full screen feature is distorted
tabris.ui.set("displayMode", "fullscreen");
tabris.ui.set("toolbarVisible", false); // hide original actionbar

var page = new tabris.Page({
    title: 'Paging',
    topLevel: true,
    style: ["FULLSCREEN"]
});
var video = new tabris.Video({
    url: 'MP4 file',
    controlsVisible: true,
    layoutData: {left: 0, right: 0, top: 0, bottom: 0}
}).appendTo(page);

page.open();

deleted style flag but not working
Same screen

Hi @mpost. In v2.x is planned a full screen future on video widget? I tried to implement that too using layouts, but is so unnaturally.

@maoamid Do you have a snippet of your implementation?

right now no, because I quit trying on december 2016. I still need it for a foundation I work for. For them the video assets is a key one in their app, and a big part of theirs videos are store on youtube, so also without a youtube api integration I choose to delayed it that work to a upcoming version on my app. So long story short, for now I use a jwplayer iframe in a webview. Maybe I find time in a few days to try again, and post a snippet here to discuse. One note: the other problem I had was that the custom controls cannot be set as a "child" widget on video one, so on different layouts, the controls was misplaced, because the video size was mostly dynamic.

@maoamid a snippet showing your problem would definitely be helpful.
With the upcoming Tabris.js 2 release creating fullscreen UIs will also be simplet as we decouple the tabris.ui concept into a standalone widget.

It is possible for tabris.device to have a set orientation property? if we I want to force a reorientation? or the contentView can be rotate?

You can fix your apps orientation via the cordova preference Orientation. https://cordova.apache.org/docs/en/latest/config_ref/index.html

is the possible to make the https://github.com/apache/cordova-plugin-screen-orientation to work in tabris?
In v2 beta is not working, it seems not read/set properly to window.screen object

@maoamid While quickly looking over the code of the cordova-plugin-screen-orientation plugin, i don't see a reason why it shouldn't work. Do you see any errors?

no, I got no errors on build, but screen.orientation return always unknown.

That would imply that the plugin is not properly registered. Is the screen object or the orientation object undefined? Could you show your config.xml entry where you include the plugin?

yes, the screen object is undefined,
in cordova .xml I just include the plugin with:

That means the plugin is not available during runtime. Do you get any errors in your build output log? It might be related to the ~ in your spec.
You could also try the concrete latest version:
<plugin name="cordova-plugin-screen-orientation" spec="1.4.3" />

<plugin name="cordova-plugin-screen-orientation" /> build without error only if no spec defined at all but the screen object remain undefined.

@maoamid In general you should provide a version to not break on updates of the plugin. Since 1.4.3 is on npm that should be picked up as expected. At that point we would need to try it out ourselves to see if it works or not.

@mpost thank you for helping me. I tested using spec in clear, and the result is the same: orientation is unknown (v2 beta1 and nightly )

about screen object on v2 beta1 version:
propertyName in screen return: lockOrientation, unlockOrientation and orientation.
working: screen.lockOrientation('landscape');
working: screen.unlockOrientation();
not woking: `screen.orientation return always unknown
Notice: On cordova screen orientation readme https://github.com/apache/cordova-plugin-screen-orientation/blob/master/README.md the methods names changed a few weeks ago:
// set to either landscape
screen.orientation.lock('landscape');
// allow user rotate
screen.orientation.unlock();

Install doesn't work for me :(... Do you have ideas ?
$ cordova plugin add cordova-plugin-screen-orientation
> Installing "cordova-plugin-screen-orientation" for android
> ANDROID_HOME=/Users/xxx/Library/Android/sdk
> JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_101.jdk/Contents/Home
> Failed to install 'cordova-plugin-screen-orientation':Error
>     at Object.module.exports.check_gradle (xxx/cordova/platforms/android/cordova/lib/check_reqs.js:90:25)
>     at GradleBuilder.prepEnv (xxx/cordova/platforms/android/cordova/lib/builders/GradleBuilder.js:161:23)
>     at Api.module.exports.runClean (xxx/cordova/platforms/android/cordova/lib/build.js:131:20)
>     at xxx/cordova/platforms/android/cordova/Api.js:394:50
>     at _fulfilled (xxx/cordova/platforms/android/cordova/node_modules/q/q.js:834:54)
>     at self.promiseDispatch.done (xxx/cordova/platforms/android/cordova/node_modules/q/q.js:863:30)
>     at Promise.promise.promiseDispatch (xxx/cordova/platforms/android/cordova/node_modules/q/q.js:796:13)
>     at xxx/cordova/platforms/android/cordova/node_modules/q/q.js:604:44
>     at runSingle (xxx/cordova/platforms/android/cordova/node_modules/q/q.js:137:13)
>     at flush (xxx/cordova/platforms/android/cordova/node_modules/q/q.js:125:13)
> Error: Could not find gradle wrapper within Android SDK. Might need to update your Android SDK.
> Looked here: /Users/xxx/Library/Android/sdk/tools/templates/gradle/wrapper

@Liberateur Are you using Cordova to do a local build?  If so, I would heed the error and update your Android SDK.
If you are using the Tabris.js cloud build, just add the following to your config.xml and run a build:
<plugin name="cordova-plugin-screen-orientation" version="1.4.3" />

I use cordova for build and right i just update Android SDK, really thanks ! <3

Closing this one as resolved. Please reopen if necessary.


Expanded rows become hidden within the table

Describe the bug
When expanding a row, the new added rows will hide some of the content, if not all.
It seems that the pageSize has some impact on what's currently being rendered.
Your minimal, reproducible example
https://github.com/TanStack/table/tree/main/examples/react/expanding
Steps to reproduce

Run the example expanding
Expand last row
Sub rows won't be visible

Expected behavior
As a user, I expect to be able to see the sub-rows, regardless the page size limit.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform

macOS

react-table version
8.9.3
TypeScript version
5.0.4
Additional context
Also using
- @tanstack/react-query": "^4.29.13",
- @tanstack/react-query-devtools": "^4.29.13"
- @tanstack/react-table": "^8.9.3"
- @tanstack/react-virtual": "^3.0.0-beta.54"
Terms & Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

Yeah, can second this. Similar setup but without react-virtual. Looked into hacking together a solution, it's very fiddly with the page size and expanded state, don't recommend managing that by counting the subrows and doing pageSize + totalSubrowCount it just very clunky.
However, I've noticed that in the demo for expanding rows it works fine. The setup is pretty similar to what I have, but for some reason it actually works.

Turns out setting paginateExpandedRows={false} fixed the issue.

Turns out setting paginateExpandedRows={false} fixed the issue.

Yep, this worked for me


fix: adds data-testid into inputProps for Input and Select components

Extends inputProps of <Input /> and <Select /> components with a custom type definition for data-testid data attribute.

before: typescript errors

after: no erros.

cc: @jxom

I think this is more of a Reakit responsibility rather than Fannypack. If we add data-* attributes to only Input & Select, then we should make every component compatible with them.


prevent overflow on 32_bit platforms

A bit more context.
The original code would fail the compilation on 32-bit platforms due to this overflow issue.
example ci

Thanks a lot for the fix! I am on vacation for a couple of weeks but will check and merge the branch as soon as I return.

I tried the fix and it gets the project to compile but it seems there's an immediate runtime overflow in
    #[inline(always)]
    fn new_fragment_capacity_from(
        &self,
        fragment_capacities: impl ExactSizeIterator<Item = usize>,
    ) -> usize {
        fragment_capacities.last().map(|x| x * 2).unwrap_or(4)
    }

In orx-split-vec-69c925888591bba4/24b4fda/src/growth/doubling/doubling_growth.rs:68:44:

@CjiW  and @Chronostasys . Thanks again for the issue and proposed fix. Only one note. The CUMULATIVE_CAPACITIES array must contain nonzero usizes. Could you consider the following minor refactoring on your fix:
pub(super) const FIRST_FRAGMENT_CAPACITY_POW: usize = 2;

pub(super) const FIRST_FRAGMENT_CAPACITY: usize = usize::pow(2, FIRST_FRAGMENT_CAPACITY_POW as u32);
pub(super) const SIZE_USIZE: usize = std::mem::size_of::<usize>() * 8;
pub(super) const OFFSET_FRAGMENT_IDX: usize = SIZE_USIZE - FIRST_FRAGMENT_CAPACITY_POW - 1;

const fn cumulative_capacity(fragment_idx: usize) -> usize {
    usize::pow(2, (fragment_idx + FIRST_FRAGMENT_CAPACITY_POW + 1) as u32) - FIRST_FRAGMENT_CAPACITY
}

const fn capacities_len() -> usize {
    #[cfg(target_pointer_width = "32")]
    return 30;

    #[cfg(target_pointer_width = "64")]
    return 33;
}

pub(super) const CUMULATIVE_CAPACITIES: [usize; capacities_len()] = [
    0,
    cumulative_capacity(0),
    cumulative_capacity(1),
    cumulative_capacity(2),
    cumulative_capacity(3),
    cumulative_capacity(4),
    cumulative_capacity(5),
    cumulative_capacity(6),
    cumulative_capacity(7),
    cumulative_capacity(8),
    cumulative_capacity(9),
    cumulative_capacity(10),
    cumulative_capacity(11),
    cumulative_capacity(12),
    cumulative_capacity(13),
    cumulative_capacity(14),
    cumulative_capacity(15),
    cumulative_capacity(16),
    cumulative_capacity(17),
    cumulative_capacity(18),
    cumulative_capacity(19),
    cumulative_capacity(20),
    cumulative_capacity(21),
    cumulative_capacity(22),
    cumulative_capacity(23),
    cumulative_capacity(24),
    cumulative_capacity(25),
    cumulative_capacity(26),
    cumulative_capacity(27),
    cumulative_capacity(28),
    #[cfg(target_pointer_width = "64")]
    cumulative_capacity(29),
    #[cfg(target_pointer_width = "64")]
    cumulative_capacity(30),
    #[cfg(target_pointer_width = "64")]
    cumulative_capacity(31),
];

I tried the fix and it gets the project to compile but it seems there's an immediate runtime overflow in
    #[inline(always)]
    fn new_fragment_capacity_from(
        &self,
        fragment_capacities: impl ExactSizeIterator<Item = usize>,
    ) -> usize {
        fragment_capacities.last().map(|x| x * 2).unwrap_or(4)
    }

In orx-split-vec-69c925888591bba4/24b4fda/src/growth/doubling/doubling_growth.rs:68:44:

Hi @MichaReiser . Thanks for reporting the issue! Is it possible to provide a little more details? Specifically, do you observe the issue immediataly or when the vector grows to a certain capacity? As there are a couple of ways to approach to this, it would be very helpful to know.

I haven't looked into that yet. It happens immediately when the application starts and at best after a few insertions. But I would have to add debug statements in the wasm build to see how many items get pushed.

I haven't looked into that yet. It happens immediately when the application starts and at best after a few insertions. But I would have to add debug statements in the wasm build to see how many items get pushed.

It already gives me the idea, thanks! Only trouble on my side is that currently I am not on my dev environment, still on vacation. I will be able to dive into the issue in one week. Lastly, could you share your build target please.

Merging and closing this PR. There will be an additional fix for different growth types and corresponding tests will be added. @MichaReiser, I will let you know once the complete fix is ready. Then, it would be great if you could let me know if you still experience the issue.


Interactive Plot shows incorrect data with filter

Describe the bug
When using an altair plot with transform_filter, the interactive plot feature shows data that has been filtered out. For example:
    chart = alt.Chart(data.cars()).mark_point().encode(
        x='Horsepower',
        y='Miles_per_Gallon',
        color='Origin',
    ).transform_filter(datum.Origin == "Europe")
    chart = mo.ui.altair_chart(chart)

The data has been filtered out to only show points with origin==Europe. The top plot is correct. The bottom plot incorrectly shows filtered out points.

Environment
{
"marimo": "0.2.1",
"OS": "Linux",
"OS Version": "6.1.0-1029-oem",
"Processor": "x86_64",
"Python Version": "3.10.12",
"Binaries": {
"Chrome": "120.0.6099.109",
"Node": "--"
},
"Requirements": {
"black": "24.1.1",
"click": "8.1.7",
"jedi": "0.19.1",
"pymdown-extensions": "10.7",
"starlette": "0.36.1",
"tomlkit": "0.12.3",
"typing_extensions": "4.8.0",
"uvicorn": "0.27.0.post1"
}
}
Code to reproduce
import marimo

app = marimo.App(width="full")

@app.cell
def __():
    import altair as alt
    from altair import datum
    from vega_datasets import data
    import marimo as mo
    return alt, data, datum, mo

@app.cell
def __():
    chart = alt.Chart(data.cars()).mark_point().encode(
        x='Horsepower',
        y='Miles_per_Gallon',
        color='Origin',
    ).transform_filter(datum.Origin == "Europe")
    chart = mo.ui.altair_chart(chart)

@app.cell
def __():
    # View the chart and selected data as a dataframe
    mo.vstack([chart, chart.value])

if __name__ == "__main__":
    app.run()

We have a fix for this in this PR (https://github.com/marimo-team/marimo/pull/734). As a heads up, it will require you install vegafusion for this feature to work.


[Addition]: colossal mint cormorant

Hotspot b58 Addresses
112UfE7R2VCudgQ4GLbvP76GF6PWadwYBhAYv9sdEa7UwJ74F69y
Discord Handle
No response
Reason(s)
only beaconing , no witnessing, use of other devices

no listen address, only performing  mainly beaconing and no witnessing


Remove step from log image key

What does this PR do?

Remove the step from key, since this creates multiple images
What issue(s) does this change relate to?

Before submitting

[ ] Have you read the contributor guidelines?
[ ] Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
[ ] Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
[ ] Did you update any related docs and document your change?
[ ] Did you update any related tests and add any new tests related to your change? (see testing)
[ ] Did you run the tests locally to make sure they pass?
[ ] Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@jessechancy can you resync your main branch with composer main? The failure are fixed on a PR a few days ago

Closing in favor of https://github.com/mosaicml/composer/pull/3601


Compatibility with segment replication

Summary
With 2.9.0 release, there are lot of enhancements going in for segment replication[1][2] feature (went GA in 2.7.0), we need to ensure different plugins are compatible with current state of this feature. Previously, we ran tests on plugin repos to verify this compatibility but want plugin owners to be aware of these changes so that required updates (if any) can be made. With 2.10.0 release, remote store feature is going GA which internally uses SEGMENT replication strategy only i.e. it enforces all indices to use SEGMENT replication strategy. So, it is important to validate plugins are compatible with segment replication feature.
What changed
1. Refresh policy behavior

RefreshPolicy.IMMEDIATE will only refresh primary shards but not replica shards immediately. Instead post refresh, primary will start  a round of segment replication to update the replica shard copies leading to eventual consistency.
RefreshPolicy.WAIT_UNTIL ensures the indexing operation is searchable in your cluster i.e. RAW (Read after write guarantee). With segment replication, this guarantee is not promised due to delay in replica shared updates from asynchronous background refreshes.

2. Refresh lag on replicas
With segment replication, there is inherent delay in documents to be searchable on replica shard copies. This is due to the fact that replica shard copies over data (segment) files from primary. Thus, compared to document replication, there will be on average increase in amount of time the replica shards are consistent with primaries.
3. System/hidden indices support
With https://github.com/opensearch-project/OpenSearch/pull/8200, system and hidden indices are now supported with SEGMENT replication strategy. We need to ensure there are no bottlenecks which prevents system/hidden indices with segment replication.
Next steps
With segment replication strong reads are not guaranteed. Thus, if the plugin needs strong reads guarantees specially as alternative to change in behavior of refresh policy and lag on replicas (point 1 and 2 above), we need to update search requests to target primary shard only. With https://github.com/opensearch-project/OpenSearch/pull/7375, core now supports primary shards only based search. Please follow documentation for examples and details
Open questions
In case of any questions or issues, please post it in core issue
Reference
[1] Design
[2] Documentation

Request owners to add v2.9.0 label on this issue.

[Triage] Duplicate from Dashboards plugin version.

@scrawfor99: Can you please share the duplicate issue that you are referring here ?

@scrawfor99 : Do you mind sharing the duplicate issue you referred above.

Hi @dreamer-89, so sorry I missed your original tag. I was referring to this issue since Security and Security Dashboards are coupled: https://github.com/opensearch-project/security-dashboards-plugin/issues/1494.

To clear up the confusion: we will be leaving this issue open as the tracking issue for seg rep compatibility. The Sec Dashboards issue is closed. This will stay open and I will label it 2.10.

Copy pasting @cwperks comment from security-dashboards-plugin issue.

@dreamer-89 Yes, the security repo. The security-dashboards-plugin repo utilizes the .kibana-* indices to support multi-tenancy, but those indices are not system indices the way that .opendistro_security (the security index) is. The security repo requires strong consistency for the security index to ensure that every node reading from the security index sees the freshest data from the index. There was a PR opened in the security repo to set the preference of the mget request that the security plugin performs when reading from the security index, but the PR was closed. See discussion on the PR here: https://github.com/opensearch-project/security/pull/2903
security issue: https://github.com/opensearch-project/security/issues/2916

Copy pasting @cwperks comment from security-dashboards-plugin issue.
@dreamer-89 Yes, the security repo. The security-dashboards-plugin repo utilizes the .kibana-* indices to support multi-tenancy, but those indices are not system indices the way that .opendistro_security (the security index) is. The security repo requires strong consistency for the security index to ensure that every node reading from the security index sees the freshest data from the index. There was a PR opened in the security repo to set the preference of the mget request that the security plugin performs when reading from the security index, but the PR was closed. See discussion on the PR here: #2903
security issue: #2916

Thank you @cwperks for the explanation and linking the PR https://github.com/opensearch-project/security/pull/2903 where _primary shard based routing was attempted. Just wanted to update you that with https://github.com/opensearch-project/OpenSearch/issues/8536, core now also supports realtime reads for segment replication enabled indices. Thus, if you are using get/mget requests, you should receive the latest data. With this, I think there is no action needed from your end. Please correct if I am wrong.
Please check https://github.com/opensearch-project/OpenSearch/issues/8536 for more details.

[Triage] @dreamer-89 The 2.10 release is coming up, what work needs to be done to resolve this issue for that release.  Doesn't seem like we need to do anything can you confirm and close if that is the case?

Thanks @peternied for the comment. I have already called out ask in the description. Let me know if you have any questions.
With https://github.com/opensearch-project/OpenSearch/issues/8536, core now supports realtime reads via get/mget APIs for SEGMENT replication enabled indices. If security ONLY relies on get/mget APIs for strong reads, then there is no change needed. If your plugin relies on strong reads via write path i.e. using IMMEDIATE/WAIT_UNTIL refresh policy during indexing operations, then you need to use get/mget APIs or use _primary preference in search requests. The later is not recommended as it results in all request been handled by primary also called out here

Hi @dreamer-89, the security plugin requires strong reads. In the past it was shared that seg. rep. was intending to offer support of this by 2.10: https://github.com/opensearch-project/security/pull/2903#issuecomment-1631281941.

Hi @dreamer-89, the security plugin requires strong reads. In the past it was shared that seg. rep. was intending to offer support of this by 2.10: #2903 (comment).

Thanks @scrawfor99 for the update. Yes, https://github.com/opensearch-project/OpenSearch/issues/8536 is resolved but please note, this change only provides strong reads for get/mget APIs.
Also, please note DOCUMENT replication guarantees RAW on the write path by using IMMEDIATE or WAIT_UNTIL refresh policy, which ensure all replica shards are updated with same indexing operation. With SEGMENT replication this guarantee does not holds true. Thus, if you are using IMMEDIATE, WAIT_UNTIL refresh policy, then for follow up search requests (where you need RAW), you need to use either get/mget APIs or use _primary preference parameter. The former is preferred as later puts extra load on primary shard.

Hi @dreamer-89, thank you for the follow-up. Sorry but I am not sure I understand what needs to be done... I thought that the changes were going to make it so that strong reads were supported meaning the current behavior of the security plugin could remain unchanged?
From your comment

please note DOCUMENT replication guarantees RAW on the write path by using IMMEDIATE or WAIT_UNTIL refresh policy, which ensure all replica shards are updated with same indexing operation. With SEGMENT replication this guarantee does not holds true. Thus, if you are using IMMEDIATE, WAIT_UNTIL refresh policy, then for follow up search requests (where you need RAW), you need to use either get/mget APIs or use _primary preference parameter. The former is preferred as later puts extra load on primary shard.

It sounds like do need to swap something though?
If you look at this PR: https://github.com/opensearch-project/security/pull/2903, you can see the previous attempt to resolve the issue. Do we simply need to move forward with that PR again or what is required?
Thank you again.

Hi @scrawfor99,
I think all thats required here is to remove the _primary based preference here because it is no longer required on get/mget requests, and the pr you linked is using an mget.  This will be realtime with SR internally.  Going forward only search requests would require any primary based routing using these parameters.

Ah i see that was never merged, I do not think there is anything required here on security side.


Have a way to mute alert until it's resolved to receive a resolved notification once it's fixed

Let's say I have an outage on one of my server I'm monitoring and it's inaccessible but I don't know how long it's gonna take to fix it, so I'm muting it for a really long time.
With this approach, I won't receive any resolved notifications, so to check if the alert is fixed I need to go to my alerts list to see if it's still firing, and given that I've muted it for a long time I also need to remove the mute to know if it's firing again.
What would be nice to have:

I have a server outage
an alert is triggered
I create a new mute and somehow specify that I need it to be active until the alert is resolved
a server fixes itself
a resolved alert notification is dispatched
a mute is removed
if a server starts misbehaving again and a new alert is triggered, I'm receiving an alert notification again

Pretty sure this would have a lot of cases that'll make it difficult, like if a mute has a lot of active alerts, but still would be really awesome to have.
Do you guys think it's manageable?

Hi! :wave: It sounds to me like you want a silence to expire when it is no longer silencing any active alerts.
I think there are a couple of problems that we would need to solve to add such a feature. For example:

Alertmanager does not persist alerts to disk, so if an Alertmanager is restarted all of its alerts will be lost; and because of this all of its silences will also be expired. This is undesirable because the alert might not have actually resolved. Prometheus will resend all alerts to Alertmanager after the resend delay and you may receive duplicate notifications.
If Alertmanager is run in HA (high availability) and one Alertmanager becomes partitioned, then its alerts will resolve as Prometheus will be unable to communicate to that Alertmanager. The partitioned Alertmanager will expire its silences as it has no more active alerts. When the partition recovers the Alertmanager that expired its silences will gossip these expirations to the other Alertmanagers, expiring them on those Alertmanagers too.

@grobinson-grafana seems so.
For issues that you outlined:

Can this be solved by saving alerts to disk every time Alertmanager is receiving one and loading it from disk if it's present, or do you think there are other caveats with this approach?
I don't know a lot about Alertmanager HA internals, but let's say if there is a cluster of 3 nodes and one is partitioned and loses the mute given all the alerts there are resolved, once it goes back, won't other 2 nodes disagree and won't the consensus be that this mute isn't in fact removed? (and if there are 2/3 nodes partitioned, pretty sure expiring mutes aren't gonna be the biggest problem here lol)

Yes that's right! The problem is that Alertmanager is stateless, so some kind of embedded database will need to be evaluated and then all the code will need to be written to use it.
Alertmanager doesn't use consensus for gossiping silences, its a case of last write wins. Since the expiration was the most recent event the other Alertmanagers will believe it to be the correct one.

@grobinson-grafana

From what I'm seeing, it shouldn't be difficult:

when creating/editing/deleting the alert, just dump whatever alerts there are to the disk
when starting, load the alerts from state if it's present
afaik it's not a proper database, but basically alerts snapshot, so no need to sync between the file and Alertmanager in cases other than the two above

Do you think that introduces new troubles?

Were the team ever considering using the consensus model? Wonder if it has any payoffs other than kinda being the requirement for the feature I propose and if it adds more problems.

Yes, but the current Alertmanager design is that alerts should continue to work even if all but one Alertmanager is down. If we add consensus then we need N/2+1 Alertmanagers to be up at all times.

Do you think you have time to work on this? I think the best place to start is to evaluate some of the embedded k/v stores such as bbolt to see which would be the most appropriate.
Yes, but the current Alertmanager design is that alerts should continue to work even if all but one Alertmanager is down. If we add consensus then we need N/2+1 Alertmanagers to be up at all times.

@grobinson-grafana for 1) I can try implementing it by myself, but I'm not not sure if I can manage 2) or if it's even feasible.

Hi! :wave: Do you have time to evaluate some embedded k/v stores? That would be a fantastic contribution as we have discussed durable storage for Alertmanager in the past but haven't decided what to use.
For example, I know that Grafana Loki uses bbolt, but it would be nice to see a comparison of some other embedded databases. You could even include sqlite3. Alertmanager has avoided being dependent on other processes as it needs to operate even when these are unavailable, so that means no MySQL, PostgreSQL, memcache, redis, etc.
Second, it is not uncommon for users to have Alertmanager installations with 10,000s of alerts, so it would be nice to see some performance comparisons of different databases. I expect the workload to be write-heavy as reads will only happen at startup time.

@grobinson-grafana so I looked a bit into how it's done for silences. Apparently it's all serialised into some binary format and stored on disk as a single file. Do you think it makes sense to do it the same way for alerts here as well, or would it be better to do it via a proper db? Basically we only need to read from it once to load all the alerts when starting Alertmanager and to write to it once an alert is created/updated.
(One issue I see with that approach is that if there are 10k inserts creating alerts, then every time it'll have to overwrite the whole file, which is not nice.)

One issue I see with that approach is that if there are 10k inserts creating alerts, then every time it'll have to overwrite the whole file, which is not nice.

Yes! That's the issue! :) It works for silences because silences are not created very often and you don't tend to have very many of them. But alerts are very different, and Alertmanager can be receiving 1000s of alerts per minute (i.e. the EndsAt timestamp needs to be updated to stop firing alerts from resolving).

@grobinson-grafana okay, from my point of view, sqlite3 here doesn't make a lot of sense as it adds another layer of complexity by having to deal with db schema, so I think this won't be the best approach here.
From other kv databases, other than bbold that you've suggested, one cool option I found is https://github.com/dgraph-io/badger - it has quite a big community (it has more github stars than bbolt) is used by a lot of projects and seems to be maintained. I haven't used either of this in my projects, so I can mostly look at the library popularity and if it's maintained - both seem cool with it.
What do you think?

Just as a quick note: there's kthxbye which automatically extends silences (prefixed by "ACK!" in the default configuration) that are still firing before they expire
While you still won't receive a resolved notification this way, you can set the silence duration to a shorter span and don't need to take care of a long-running silence.

Can we please at least have Silence START/END notifications? Those won't require states, would they? (unless we want to survive "end of silence during restart" situation). Will save lots of medical expenses for many people. Possibly lives.
(related: #2690 )


error when setting python version 3.5

Description
What steps will reproduce the problem?

What is the expected output? What do you see instead?
Please provide any additional information below
File "/home/randi/.local/lib/python2.7/site-packages/spyder/plugins/ipythonconsole.py", line 876, in run_script
self.execute_code(line, current_client, clear_variables)
File "/home/randi/.local/lib/python2.7/site-packages/spyder/plugins/ipythonconsole.py", line 922, in execute_code
sw.execute(to_text_string(to_text_string(lines)))
File "/home/randi/.local/lib/python2.7/site-packages/qtconsole/history_console_widget.py", line 47, in execute
source, hidden, interactive)
File "/home/randi/.local/lib/python2.7/site-packages/qtconsole/console_widget.py", line 632, in execute
self._execute(source, hidden)
File "/home/randi/.local/lib/python2.7/site-packages/qtconsole/frontend_widget.py", line 294, in _execute
msg_id = self.kernel_client.execute(source, hidden)
AttributeError: 'NoneType' object has no attribute 'execute'
Version and main components

Spyder Version: 3.2.1
Python Version: 2.7.13
Qt Versions: 5.7.1, PyQt5 5.7 on Linux

Dependencies
pyflakes >=0.5.0  :  1.6.0 (OK)
pycodestyle >=2.3 :  2.3.1 (OK)
pygments >=2.0    :  2.2.0 (OK)
pandas >=0.13.1   :  0.19.2 (OK)
numpy >=1.7       :  1.12.1 (OK)
sphinx >=0.6.6    :  1.6.3 (OK)
rope >=0.9.4      :  0.10.7 (OK)
jedi >=0.9.0      :  0.10.2 (OK)
psutil >=0.3      :  5.3.0 (OK)
nbconvert >=4.0   :  5.3.0 (OK)
sympy >=0.7.3     :  None (NOK)
cython >=0.21     :  None (NOK)
qtconsole >=4.2.0 :  4.3.1 (OK)
IPython >=4.0;<6.0:  5.4.1 (OK)
pylint >=0.25     :  1.7.2 (OK)

Thanks for reporting. This issue is a duplicate of #5053 and is solved in Spyder 3.2.4; please update to fix it. Accordingly, this issue will be closed.


[Packagist] Use default branch as indicated by Packagist

Instead of assuming dev-master for the default branch, check the package data from Packagist to see which branch is set as the default, and use it.

Warnings

:warning:
This PR modified service code for packagist but not its test code. That's okay so long as it's refactoring existing code.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @ramsey!

  Generated by :no_entry_sign: dangerJS against cb2b26995f49e870ef4edb5909f2cd45905e281e

This PR modified service code for packagist but not its test code.

Is this because packagist-license and packagist-php-version are considered separate services from packagist?

@chris48s Oh, nice! Glad to know I helped close out that other issue. I kind of stumbled on this by accident and wasn't aware of the other effort, so this was serendipitous. 😁


copr: support new index encoding with collation support

Signed-off-by: TennyZhuang<EMAIL_ADDRESS>
What have you changed?
Support new index encoding described in https://github.com/pingcap/tidb/pull/14574
Related to https://github.com/pingcap/tidb/pull/14876
What is the type of the changes?

New feature (a change which adds functionality)

How is the PR tested?

Unit test

@wjhuang2016 PTAL

Hi, @TennyZhuang , it is ok to review now?

Hi, @TennyZhuang , it is ok to review now?

Yes

@sre-bot /help

@sre-bot /run-integration-test tidb=pr/14574

Mark as DNM in case of TiDB integration issues.

/build

/release

hi @breeswish @TennyZhuang , the TiDB-TiKV integration tests passed all index scan cases in https://github.com/bb7133/tidb-test/blob/ci_collation/mysql_test/r/utf8mb4_general_ci.result, I think it is ready to merge.
Good job @TennyZhuang !

/merge

/merge

/release


sub folders need a locking mechanism

Sub folders are meant to be configurable, so that you can use a wip sub folder instead of the main one when processesing.  This worked in the past by selecting a sub folder, and the ui would remember the selection.  However this was confusing because there was no indicator that selecting a sub folder was configuring something.
This issue can be fixed by adding a checkbox or something beside the sub folder. When checked the sub folder would be locked, and import_data would automatically used the locked sub folder instead of the main one.


Runtime reconciles FieldExport even if CRD is not Present in Cluster

Describe the bug
Even if the FieldExport is not applied to the cluster, the runtime still tries to reconcile it and throws an error. It seems like there are two reconsiders for this resource, which I do not fully understand. One that checks the presence of the CRD, and one that does not.
1.6521301546735055e+09	ERROR	controller.bucket	Reconciler error	{"reconciler group": "s3.services.k8s.aws", "reconciler kind": "Bucket", "name": "example-8675309", "namespace": "ack-system", "error": "no matches for kind \"FieldExport\" in version \"services.k8s.aws/v1alpha1\""}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:227

Steps to reproduce

Build a controller and install it into a cluster, but do not apply the FieldExport
Create a CR (say a bucket) and see the controller though the above error.

Expected outcome
I'd expect that FieldExport is ignored.
Environment

Kubernetes version OpenShift 4.10
Using EKS (yes/no), if so version?  no
AWS service targeted (S3, RDS, etc.) S3, but probably applies to all controllers.

That's weird ... we have code that checks whether the CRD was installed and conditionally starts the reconciler ... https://github.com/aws-controllers-k8s/runtime/blob/main/pkg/runtime/service_controller.go#L227-L239


Mark late applications with "Late"

Right now, even if people send in or change their application after the deadlines, this is not shown to anyone (you have to go into shell).

Should we mark "send in or change" as different notes? In case you just changed one word in your application after the deadline.
We envisioned using the created_at and updated_at fields to mark some applications as Created late and others with Edited late


Endless loop

It seems that in some cases it will fall into an endless loop.
If you can find any clues (for example, opening a specific file or performing a specific operation will cause an endless loop), please give me your feedback. Thank you!

I noticed that simply closing VSCode after using the extension can cause the process to hang at 100% CPU, but there may be other cases as well. I'll do some more testing tomorrow.

Thanks for the quick fix! :heart:


Update lifetime dependence syntax and inference

Pitch - https://github.com/apple/swift-evolution/pull/2305
Changes highlights:
dependsOn(paramName) and dependsOn(scoped paramName) syntax
dependsOn(paramName) -> copy lifetime dependence for all parameters/self except when we have Escapable parameters/self, we assign scope lifetime dependence.
Allow lifetime dependence on parameters without ownership modifier.
Always infer copy lifetime dependence except when we have
Escapable parameters/self, we infer scope lifetime dependence.
Allow lifetime dependence inference on parameters without ownership modifier.

@swift-ci test

@swift-ci test windows

Swift-syntax work is pending

@swift-ci test

Please test with following pull request:
https://github.com/apple/swift-syntax/pull/2564
@swift-ci Please test

Please test with following pull request:
https://github.com/apple/swift-syntax/pull/2564
@swift-ci Please test macOS platform

Please test with following pull request:
https://github.com/apple/swift-syntax/pull/2564
@swift-ci Please test macOS platform


Cleaned up error message on bad login

Error message wasn't formatted properly when logging into a non-existent host.
Removed check to make sure host is passed since docopt takes care of that for us.

Much nicer...
:+1:


[banuser] Group participants by ban duration

Update _get_condition to categorize participants by ban duration. This will also need to be reflected in config and randomizations.

Closed by #93~


The lockfile is only modified greatly if you ran npm install with a different node/npm version than the original author.
https://docs.npmjs.com/cli/v9/configuring-npm/package-lock-json#lockfileversion
You might have got this message and caused your lockfile to change a lot
This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@3. I'll try to do my best with it!

https://docs.npmjs.com/cli/v10/configuring-npm/package-lock-json#description


Feat/separate lit node client node code & add version bump tool

What 1 - Node code separation
The new TS-SDK is built with being isomorphic in mind, that means sometimes we need to include code that might not be needed in the environment. eg. walletconnect in nodejs
Proposed Solution
Separate the LitNodeClient node code on its own repo, then the current LitNodeClient extends from it so no breaking changes for existing customers that decides to upgrade the @lit-protocol/lit-node-client package

The new structure will look like this:

NodeClient - This is purely for Node.js.
LitNodeClient - This is isomorphic, so both browser and Node.js code are included. This is the default repo, but if the user decides to, they could use NodeClient instead.

Usage
This proposed solution is published to dev tag and can be tested in version 2.1.62
// ONLY FOR NODE.JS
yarn add<EMAIL_ADDRESS>
// import * as LitJsSdk from "@lit-protocol/node-client";
// const client = new LitJsSdk.NodeClient();

OR

// ISOMORPHIC
yarn add<EMAIL_ADDRESS>
// import * as LitJsSdk from "@lit-protocol/lit-node-client";
// const client = new LitJsSdk.LitNodeClient();

Tested manually and e2e works
What 2 - SDK tool - version bump
This PR also added a version bump tool which bumps the version in lerna.json and version.ts
Solution
yarn bump // for patch
yarn bump:minor // for minor
yarn bump:major //for major

Will be changing the name from @lit-protocol/node-client to @lit-protocol/lit-node-client-nodejs cus node can mean two things here and don't want to be confusing


On Android not working

Challenge Name

Issue Description

Browser Information

Browser Name, Version:
Operating System:
Mobile, Desktop, or Tablet:

Your Code

Screenshot

@Ashish8897 hi there! Thanks for the issue. Can you be more specific and fill out the issue template with your issue? We're not sure how to help without any information. Thanks!


BUG[FOOTER] The scrolling page is displayed in landing page after clicking on the 'My cabinet' link

Environment:
OS: Windows 10Pro, V.1909
Browser: Chrome 80.0.3987.122 / 64-bit
Steps to reproduce:

Go to 'Green city' application https://ita-social-projects.github.io/GreenCityClient/#/welcome
Scroll down to the bottom of the page
Click on 'My cabinet' link
Verify the displayed page

Actual result:The scrolling page is displayed in landing page after clicking on the 'My cabinet' link
Expected result: The 'Log in' form is displayed for unlogged user in landing page after clicking on the 'My cabinet' link
#384
Video link:
https://drive.google.com/open?id=1dA_KE_pdkCOs5p9kzK-jgL6uFTPoNBmb

Bug not fixed.
Appears page instead 'Sign In' pop up
In the footer "My habits" instead "My cabinet"

Old functional of Authorization will be deleted and after will be add link for button to open Auth modal window instead of old Auth page


Page Templates

Page templates needs to:
1 Be able to generate a page
2 Generate sub components, related elements to the main artifact it generates
e.g.
profile.??? template might end up generating:
person-profile.js
person-profile-avatar.js
person-profile-eventlist.js
Template format?
Handlebars?

Page Templates needs to be able to include custom code to override generator specific behavior.


Remove Woo notice templates

As described in https://github.com/bootscore/bootscore/issues/333, Woo templates should be reduced for less maintenance and more stability.
This PR does it with all alerts in templates.

Replaced all alert alert-* classes with default Woo woocommerce-info, woocommerce-error and woocommerce-message.
Using @extend to show them in Bootstrap's style
6 files that only had changes in the alert classes has been deleted
Minor margin class improvement in checkout

This has no impact on the frontend. Tested, works fine and is already live on bootscore.me. Just click through the store and check alert classes in cart, checkout and dashboard.
@justinkruit if you agree, I'm happy when you just hit the merge button. BTW, maybe I have an idea how to solve alert icons with Fontawesome's JS version, but let's do that later.

I'll look into it this weekend!
Also, I said I was gonna look into the FA thing so I'll also promise to try some stuff out for that 😄


Simplify DeviceList Logic

Thank you for this and sorry for the delay. We will look into it once the team is back from vacation.

@hkal
Could you add a description for this PR of what is expected out of this change?

@hkal
Could you add a description for this PR of what is expected out of this change?

Let's not take this into main. I'm going to include it in the screencast work we recently spoke about.

This PR is obsolete due to #983


doc: Misc fixups for Transparent Encryption GSG

Updates https://github.com/cilium/cilium/issues/11903

test-docs-please

Coverage decreased (-0.02%) to 37.014% when pulling 7b9f61858d83ade40c56ec314d1bd24bbe7db031 on christarazi:pr/christarazi/misc-fixups-enc-docs into c216dfb3ad911ca5ba7659b6266109c8c6882d70 on cilium:master.

Travis hit https://github.com/cilium/cilium/issues/12111


nitter: unstable-2023-04-21 -> unstable-2023-05-19

Description of changes
Trivial bump of Nitter.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I don't think the date will matter between now and the next bump.


Spanish Translate [WIP]

Hi, I'm working on translate this awesome plugin to Spanish, my native language.
So, I think in one or two days will be finished, but... May plugin won't work with UTF-8 chars? Like 'ñ', 'ó' and similar used in Spanish.... I hope everything will work correctly

BTW, my english is not that good, so if you find any bad english you can fix it.

No problem, that is now fixed :+1:

The lowerCamelCase is not that much work, it are just these six upper keys that changed:
PlayerNotFound, WorldNotFound, NumberFormat, NotPlayer, NoPermissions, UnknownCommand.
The sorting is easy with http://alphabetizer.flap.tv/ or another online tool.

sorry for the absence, I've been busy with exams. the translation is still active

No problem.

Closed because of inactivity.
If you wish to continue comment on this issue.


Allow using FindRust.cmake several times

CMake only allows creating alias targets once, otherwise it bails out with
CMake Error at thirdparty/corrosion/cmake/FindRust.cmake:330 (add_executable):
add_executable cannot create imported target "Rust::Rustc" because another
target with the same name already exists.
Allow using find_package(Rust) in several places by following the pattern of other
find modules, protecting with an if.

Hi  Frederik 😉,
Looks good to me.
A test would be nice.

Hi  Frederik 😉,
Looks good to me.
A test would be nice.

Hello Olivier 😁 , test added.

Thank you :+1:


MessageStream trait

see also #462
Motivation
currently when I have a grpc call with client streaming like ByteStream::Write I get a rust function with this signature:
async fn write(&self, request: Request<Streaming<WriteRequest>>) -> Result<Response<WriteResponse>, Status>
If I want to test this function I would need to create a Streaming object which is quite complicated.
It would be much easier if the generated function write would be generic accepting a argument implementing the trait Stream and Streaming would implement this.
Solution
Adding a new trait
trait Stream {
    type Item;
    async fn message<'_>(&'_ mut self) -> Result<Option<Self::Item>, Status>;
    async fn trailers<'_>(&'_ mut self) -> Result<Option<MetadataMap>, Status>;
}

and generate function definitions for ByteStream::write with such a signature
async fn write<S: Stream<Item = WriteRequest >>(&self, request: Request<S>);
This allows to create simple Mocks which implement Stream for testing.
And otherwise Streaming is still used, which must then implement Stream.

While I agree that changing some trait functions to be generic can be useful (and I believe it is possible),  I'm not sure the change would fly. However, if you want to continue working on this, here are some pointers that may help. These are not gospel and I may be wrong but you might want to look into them.

The async_trait dependency is feature gated. It is only available with the codegen feature.
Some code in examples,  tests, and most likely other people's code, rely on the fact that Streaming implements futures::Stream.
The future returned by MessageStream::message is not the same as the future returned by the current Streaming::message method. They can't be use interchangeably as is.
Similarly, MessageStream::message can't always be used instead of Stream::next.
Probably the easiest way to achieve what you want, is to use futures::Stream as a bound to the generic methods parameters. The additional MessageStream wouldn't be needed. This should work without much fuss, other than changing codegen. But, this will make function signatures a lot more involved. In the end, even if you can pull off introducing the new async trait I think function signatures would still be a bit of an eye sore. There is also the object safety issue. Although I don't think it matters, I don't know for sure.


CAMEL-13704 - Added PR template file with instructions on what to include when subm…

CAMEL-13704 - https://issues.apache.org/jira/projects/CAMEL/issues/CAMEL-13704?filter=allopenissues
I have created a PR template file for this repo and plan to add the same template to camel-k and camel-quarkus

Can I get guidance on how to pass the failing check?

It's a glitch in github action not your fault

Oh ok! Then has my change been merged to master?

No. I want to wait for the other reviewers :-)