ROX-25421: Show diagnostic info when upgrader lacks permissions

Description
We have a possibility that the secured cluster will be deployed using the legacy method without the SA and CRB required for the sensor upgrader.
To do that, one needs to turn off the switch in the UI (on the screenshot it is enabled):
.
In that state, sensor should not be upgraded - that is what the user selected. However, we do not prevent the upgrader from trying to upgrade (it would be difficult to prevent that). In case the user forgets that a given cluster has never been configured for upgrades and tries to run the upgrader, the following error will be returned:

This error may also be shown when the cluster has originally been created with possibility of upgrades, but the resources have been manually altered (e.g., as a result of security audit) to not allow sensor-upgrader run as cluster admin.
Whit this PR, we want to give the user additional hints about the reasons why upgrader cannot start. For that, I expanded the error text to contain additional checks. See example:

User-facing documentation

[x] CHANGELOG is updated OR update is not needed
[x] documentation PR is created and is linked above OR is not needed

Testing and quality

[x] the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
[ ] CI results are inspected

Automated testing

[ ] added unit tests
[ ] added e2e tests
[ ] added regression tests
[ ] added compatibility tests
[ ] modified existing tests

How I validated my change

[x] Manually deployed to to the clustered, deleted the sensor-upgrader SA and triggered the upgrade.

It looks like you made quite a few changes to what additional info is rendered in the pop-up. Could you please update the description so we can review?

The lower-most screenshot in the PR description is meat to present the "after this change" state and I think it is up to date. Is there anything missing?

Ok. Let me try to make a few suggestions then.
Upgrader failed to execute <...> reported errors which usually means access is denied. Have you configured this Secured Cluster for automatically receiving updates? More info: <link to the doc with troubleshooting>.

Note that I dropped the list of resources and actions as well as the list of potential issues. I think we should print all of that to the logs and note in the troubleshooting doc where to look for logs.

Ok. Let me try to make a few suggestions then.
Upgrader failed to execute <...> reported errors which
usually means access is denied. Have you configured this
Secured Cluster for automatically receiving updates?
More info: <link to the doc with troubleshooting>.

Note that I dropped the list of resources and actions as well as the list of potential issues. I think we should print all of that to the logs and note in the troubleshooting doc where to look for logs.

Okay, that sounds like something that I can implement :)

@alexr, I started implementing your suggestion, however, I find the potential troubleshooting steps a bit cumbersome. They would require to get the logs from sensor-upgrader while it is running and that happens only for maybe 10-20 seconds.
Making it more comfortable for the user would require to print the additional logs in sensor or in central. The code for adding that would get more complexity, as we do not have a part saying that this should go to the UI but that to the logs.

/test gke-nongroovy-e2e-tests

I updated the PR description. This error looks currently like this:

For my taste, the error is still a bit too long, but it only contains useful information, so I think we're good to go

I totally understand the comment that it is too long. The problem with shortening it is in the way the upgrader works, it runs many layers of activities - iterates over workflows, plans, steps - the error is a composition of many pieces that allows to identify the exact origin of the error. I find this construction elegant and I wouldn't like to destroy it. That is why I am personally okay with long error in this particular case.

/test gke-upgrade-tests


Consider marking all COM functions as #[must_use].

It's probably always necessary to check the result of a COM method call. In Rust, we can mark COM methods as #[must_use] in order to ensure that users check the result from calling the COM method.

Yes, there are basically two cases here:

C-style functions that return an HRESULT. HRESULT is mapped to windows::ErrorCode and this type should have #[must_use] to help with diagnostics.

COM interface methods that return HRESULT (not all do). These should be remapped to return Result<T> where T is either () or the trailing out parameter type (except where there is a trailing pair). windows::Result already has the #[must_use] attribute.

A related question is whether windows::BOOL should be #[must_use] since it is most often used to indicate the success or failure of some C-style function.


Ipykernel install

For #

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

Not sure what's going on here? Is this a bot?

Ok, this is definitely not my stuff. No idea, but some of the changes are not mine.


Receiving a copy of mail letters to the Mattertost-channel

The readme lacks information on how to run mail2most. Please give me a more detailed procedure.
Installed mail2most on Linux via docker-compose. I have a user on the mail server (username@example.com). I have a user in Mattermost who created a personal token. I have a team in Mattermost and a private channel within it, where I would like to receive messages redirected from mail to Mattermost. In mail2most.conf we specify the following parameters:
[Default Profile.Mail]
ImapServer = "imap.example.com:993"
Username =<EMAIL_ADDRESS>Password = "mypass"
[DefaultProfile.Mattermost]
URL = "https://mattermost.example.com"
Team = "team name"
Username = "username"
Password = "userpassword"
AccessToken = "tokensymbols"
Channels = ["mail2most"]
Users =<EMAIL_ADDRESS>As I understand it, when I send myself a letter to<EMAIL_ADDRESS>I should receive his mask in the specified channel in Mattermost. However, this does not happen. Perhaps I'm specifying something more or incorrect? Please indicate my mistake.

Hi @rindelit you are missing the email filter section
# The DefaultProfile.Filter defines a default filter
# if your Profile has no defined filter this information will be used
[DefaultProfile.Filter]
  # Folders filters your mails only in specific email folders
  Folders = ["some-default-email-folder", "some-other-default-email-folder"]
  # Unseen lets you process unseen mails only by checking the unseen mail flag
  Unseen = false
  # From filters for defined from addresses
  From =<EMAIL_ADDRESS>  # To filters for defined to addresses
  To  =<EMAIL_ADDRESS>  # Subject filters if the email subject contains one of the defined strings
  Subject = ["example subject"]
  # TimeRange will only process mails that are not older than the defined time range
  TimeRange = "24h"
  # IgnoreMailErrorNotifications sets if Delivery Status Notifications are ignored or not
  IgnoreMailErrorNotifications = true

check the example config for more information.

Hi @rindelit you are missing the email filter section
# The DefaultProfile.Filter defines a default filter
# if your Profile has no defined filter this information will be used
[DefaultProfile.Filter]
  # Folders filters your mails only in specific email folders
  Folders = ["some-default-email-folder", "some-other-default-email-folder"]
  # Unseen lets you process unseen mails only by checking the unseen mail flag
  Unseen = false
  # From filters for defined from addresses
  From =<EMAIL_ADDRESS>  # To filters for defined to addresses
  To  =<EMAIL_ADDRESS>  # Subject filters if the email subject contains one of the defined strings
  Subject = ["example subject"]
  # TimeRange will only process mails that are not older than the defined time range
  TimeRange = "24h"
  # IgnoreMailErrorNotifications sets if Delivery Status Notifications are ignored or not
  IgnoreMailErrorNotifications = true

check the example config for more information.

i have the same issue and i add the filters as the example conf but i get nothing in mattermost

@95-M  can you post your configuration here, don't forget to remove sensitive information. Make sure folder is only defined if not index folder and check if email address is correct. Simplest way to test is just define Filter with subject and timerange and send an email with the same subject from one of your email addresses

@rindelit does the problem still persist or did you solved it by adding a filter?


Adding common "reason" constants

Adding "reason" constants to the pkg repo as suggested in this PR: https://github.com/fluxcd/notification-controller/pull/701
This will be followed by a PR in kustomize controller to refer to these constants from common pkg repo here and updates to the above mentioned PR to do the same.

@darkowlzz : Thanks for the review. I have incorporated your review comments: rebased, fixed and squashed my commits as well. Please review again and let me know if more updates are required. thx.

@stefanprodan , @hiddeco : Could you please review this PR? Its pending your review and approval. Thanks.

@gdasson please rebase with main and force push.

@stefanprodan: Done.


(question): Is there an example of Karepenter running optimized capacity deployments?

Is there an example where Karpenter is running optimized capacity deployments? The example in the documentation creates new instances when deployment gets inflates, rather than running the pods on the existing nodes (if any are available).
P.S.  Side question: Should we have a dedicated github issue template for questions?

Karpenter only creates nodes for pods that the kube-scheduler has marked as unschedulable.  If they can be run on existing nodes by the kube-scheduler, it will schedule them and Karpenter won't come into play.
There is a Karpenter channel on the Kubernetes that is a good forum for questions as well.

@tzneal Thanks for quick response. So how do I demonstrate optimized capacity deployment with the current example given in the documentation? Every time I inflate the deployment new node instance gets provisioned even through there is plenty of space/resources for additional pods to run on the node. TIA.

Sorry, I saw the thumbs up and closed it :) Karpenter packs pods into nodes in order to choose the 'right sized' node based on what the current set of unschedulable pods are.  This should hopefully be close to the node's capacity in terms of memory/cpu.  If you scale the deployment up again, it's likely that the new pod requests will exceed what your current set of nodes can service.
Are you certain that there are plenty of resources on the existing nodes? If there is, kube-scheduler should schedule your pods there.  You can look at the CPU/memory requests with kubectl describe node node-name to check.

Ok... so to be on the safe side, I limited my default provisioner to use only t3a.medium nodes.  I believe that the pod in the test deployment in the documentation is not really that big and t3a.medium can handle few of them. Am I better off not limiting the instance types in the provisioner config and let Karpenter magically figure out the correct node type/size?
P.S. Thanks for the #karpenter slack channel pointer... I just joined 👍

Thanks @tzneal for helping me out in Slack... YOU ROCK!!!!


Add Ludicrous Propulsion Systems

Author posted on CKAN thread asking for this mod to be added.
Waiting on mod author to publish a full release on GitHub before this will test.

#rebuild

V.0.2.4 has been released several days ago, the AVC file has been fixed

@BenjaminCronin, The LPS.version file in the v0.2.4 download is still missing the commas. Not sure why.

Ok, should be good now. Most recent release is <IP_ADDRESS>.

@BenjaminCronin Version file needs a : after "

Anything else?

No, that was the last error

All right. I'll make a release and your can run the check on that. it will be release v.<IP_ADDRESS>

Alright, done. Thanks for all your help!

Wait.  Wait wait.

Ok, we should be good.

ok then, merging with our thanks


External File Adapter Dependencies

Hey, noticed that the GCS file adapter was moved to devDependencies in this commit https://github.com/ParsePlatform/parse-server/commit/1eb2a87f9f0b5328ebeaaf0eb2f82b86150f2b13
I like the opt-in approach to these dependencies for production parse servers, any similar plans for S3 / ParseFS adapters?

The reason for that one is because the one of the transitive dependencies needed to compile native code and required more than 1GB of RAM to do so, causing install failures on AWS micro instances. I agree that it's a better model to have the dependencies be opt-in, but thats also a breaking change and I'm not sure if the benefit of the breaking change justifies the cost to everyone else, like it did with the GCS adapter.

Makes sense, not worth the pain of the breaking change unless if there are extenuating circumstances like native module failures.  Thanks


I382 - Update documentation to reflect 5.2.0

Update the online documentation to reflect changes to 5.2.0

There are a couple of things in the ticket that I didn't see:

4412446 - at the bottom where it talks about viewing the database in the enterprise client it would be good to have it say something like "Google Earth EC can be downloaded from ..." and provide a link to the relevant wiki page.
4412433 - Line 488 says "CA POIs" with a space between "A" and "".  We should take the space out.


about grayscale range of data

Is there any requirement for the grayscale range of data?
Do I need to normalize the data to [0,1] ?
Thank you very much!

Yes, the image intensity range should be normalized to [0,1]. Otherwise, the Gaussian noise specified in range [-1,1] will not be sufficient for diffusion.
Dewei

From: UJSdog @.>
Sent: Tuesday, November 29, 2022 11:19 AM
To: DeweiHu/OCT_DDPM @.>
Cc: Subscribed @.***>
Subject: [DeweiHu/OCT_DDPM] about grayscale range of data (Issue #3)
Is there any requirement for the grayscale range of data?
Do I need to normalize the data to [0,1] ?
Thank you very much!
—
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDeweiHu%2FOCT_DDPM%2Fissues%2F3&data=05|01|dewei.hu%40vanderbilt.edu|5c52accb76b340ada85808dad22deb67|ba5a7f39e3be4ab3b45067fa80faecad|0|0|638053391918020558|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=8xJPb5Sx2qGIiVIj7nIrCetOZSUT1CkmW%2BsgygX36uI%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAL6WZQBP3NDFGYQXSOZDG2TWKY3LJANCNFSM6AAAAAASOXIELI&data=05|01|dewei.hu%40vanderbilt.edu|5c52accb76b340ada85808dad22deb67|ba5a7f39e3be4ab3b45067fa80faecad|0|0|638053391918020558|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=99zMoqUyP%2BVjLbb%2Fc9d9lHMxHhzJlwlZIVoWNVUSHSs%3D&reserved=0.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Hello, I see that your code normalizes the data to [-1,1], so how do you say normalize to [0,1]

Hi, I updated the normalization code earlier this year, it will normalize the intensity to [-1,1] now.

Thank you very much for your answer. I am also using normalization to [-1,1]. During the training process, I used a noisy OCT image with a size of 512 * 512, but the loss did not decrease or converge during the training process. Do you know the reason.

Hi, I uploaded a checkpoint of my model in the folder ckpts. I normalized my instensity range to [1,3] when training this model. You can try if it works for you.

非常感谢您的回答。我也使用规范化来 [-1，1]。在训练过程中，我使用了大小为 512 * 512 的噪声 OCT 图像，但在训练过程中损失没有减少或收敛。你知道原因吗。

Hello, I have such a problem now, do you know the reason？


Support running publish workflow on aarch64 runners

GitHub now has support for paid for aarch64 runners, which means passing labels to runs-on:. I don't think there is a way we can do this at the moment, looks like we would need to customise the get_os function

@ConorMacBride I don't suppose you have any quick input on this before I start fumbling around in the dark?

We could support something like this to modify the default image? Should just be a matter of updating get_matrix_item to extract the options depending on whether it receives a string or a dict.
jobs:
  publish:
    uses: OpenAstronomy/github-actions-workflows/.github/workflows/publish.yml@v1
    with:
      test_extras: test
      test_command: pytest --pyargs test_package
      targets: |
        - linux
        - build: cp3?-manylinux_aarch64
          runs-on: ubuntu-latest-aarch64
        - cp3?-macosx_x86_64
    secrets:
      pypi_token: ${{ secrets.pypi_token }}

https://github.com/OpenAstronomy/github-actions-workflows/blob/a0669d967924b07daa381e64cf7a601196cb9247/tools/load_build_targets.py#L68-L75

Astropy is very interested. Please keep us updated. Thanks!

@ConorMacBride What do you think the best solution for detecting when to use QEMU is?
i.e. what should we change this to:
https://github.com/OpenAstronomy/github-actions-workflows/blob/e3cc5245fe108cf0ef3d307e38e20652a38c676c/.github/workflows/publish.yml#L148
Should we make it check to see if CIBW_ARCH is not equal to the native arch? I have no idea how we would do that.


[Feature Request] Hook PvPManager

Hook PvPManager
When a town war is conducted with PvPManager installed on the server, attacks will be prevented by PvP protection.

Thanks for your request, however I think this type of hook is better implemented by the other plugin, so I will decline this for now.


Refactor: Settings with hooks

fix #7

Codecov Report

Merging #33 into develop will increase coverage by 0.2%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop      #33     +/-   ##
==========================================
+ Coverage    98.56%   98.76%   +0.2%
==========================================
  Files           27       28      +1
  Lines          625      650     +25
  Branches        96       96
==========================================
+ Hits           616      642     +26
+ Misses           9        8      -1

Impacted Files
Coverage Δ

src/routes/Settings/hooks/index.ts
100% <100%> (ø)

src/routes/Settings/hooks/ads.ts
100% <100%> (ø)

src/routes/Home/hooks.ts
100% <100%> (ø)
:arrow_up:

src/models/phrases.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ac7c5...9cb325d. Read the comment docs.


vlan-fd-capability::port-and-protocol-based-vlan-is-avail is missing

In vlanInterfaceConfiguration is an attribute (forwardedProtocolVlanIdGroupingList), which is referencing forwardedProtocolGroupIds.
These protocol groups (incl. their IDs) are defined for the entire VLAN Bridge (means in the VlanFd).
In vlanFdConfiguration is an attribute (protocolGroupList), which is defining these protocol groups (incl. their IDs).
Basically, everything straight, but not all implementations are supporting this feature.
vlanInterfaceCapability contains an attribute (port-and-protocol-based-vlan-is-avail), which is indicating, whether the vlanInterfaceConfiguration::forwardedProtocolVlanIdGroupingList can be expected, or not.
Such indicative attribute is missing in vlanFdCapability. The vlanFdConfiguration::protocolGroupList attribute is missing without any explanation.
Proposal:
Adding a vlanFdCapability::portAndProtocolBasedVlanIsAvail attribute.

Has been solved with VlanFd_1.0.0-tsp.210126.1050+yang.1.


expose popup window size configuration

Hi @quolpr ,
is it possible easily expose window size configuration or can you give me hint i can create pr for that?
local function open_popup()
  popup = Popup({
    enter = true,
    bufnr = popup_buf,
    focusable = true,
    border = {
      style = "rounded",
    },
    position = "50%",
    size = {
      width = "95%", -- this
      height = "80%", -- this
    },
  })

here is the pr #27


Migration to authjs 🚀

Hello everyone 👋
The time has come: We are slowly moving forward to migrate NuxtAuth from using NextAuth under the hood to running the new authjs package!
This will come with numerous benefits, including:

Smaller bundle size (as we no longer need to include the default Login Page built for React)
Improvements to many bugs that have been blocked by NextAuth
Support for future features

Serverless deployments
etc.

This issue will track our current progress, issues and goals. We are currently beginning this migration, therefore more information will follow soon.

Valid point regarding trustHost: https://github.com/sidebase/nuxt-auth/issues/691#issuecomment-1972763234

It makes perfect sense to wait for a release of next-auth@5 which would also mean a release of a significant @auth/core version (maybe even v1).
Tracking:
https://github.com/nextauthjs/next-auth/releases

It makes perfect sense to wait for a release of next-auth@5 which would also mean a release of a significant @auth/core version (maybe even v1).

Agreed! I can see that they already have alpha versions of Version 5 released. Have they added support for trusthost there yet? I think we can also still continue internally preparing for the release, by outlining which changes we will be making and updating our internal logic in preparation for this. But I do agree that we should wait with the official switch until they release!

I am a bit concerned, see reports below.
What is missing/required to start with the migration process?
package.json
"@sidebase/nuxt-auth": "^0.7.2",
"next-auth": "4.21.1",

Audit Report:
# npm audit report
next  >=13.4.0 <14.1.1
Severity: high
Next.js Server-Side Request Forgery in Server Actions - https://github.com/advisories/GHSA-fr5h-rqp8-mj6g
fix available via `npm audit fix`
node_modules/next

next-auth  <4.24.5
Severity: moderate
Possible user mocking that bypasses basic authentication - https://github.com/advisories/GHSA-v64w-49xw-qq89
fix available via `npm audit fix --force`
Will install<EMAIL_ADDRESS>which is a breaking change
node_modules/next-auth
  @sidebase/nuxt-auth  0.3.0-alpha.1 - 0.4.0-alpha.6 || >=0.7.0-rc.0
  Depends on vulnerable versions of next-auth
  node_modules/@sidebase/nuxt-auth

3 vulnerabilities (2 moderate, 1 high)

Why next
❯ npm why next
<EMAIL_ADDRESS>peer
node_modules/next
  peer<EMAIL_ADDRESS>|| ^13" from<EMAIL_ADDRESS>  node_modules/next-auth
<EMAIL_ADDRESS>from the root project
    peer next-auth@"^4" from<EMAIL_ADDRESS>    node_modules/@next-auth/prisma-adapter
<EMAIL_ADDRESS>from the root project
    peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>    node_modules/@sidebase/nuxt-auth

Valid point regarding trustHost: https://github.com/sidebase/nuxt-auth/issues/691#issuecomment-1972763234

Primarily some missing security features, such as trustHost. Aside from this, we would definitely wait to deprecate the current version until authjs makes their full official release. We want to avoid solely relying on a package that has not had a proper release yet.
We have already investigated internally what is required for a migration and are slowly preparing our module for this in the future, however, due to the reasons mentioned above, we will not release a stable version of the authjs provider, until they do so as well!

I am a bit concerned, see reports below.

If you delve into the actual report (https://github.com/advisories/GHSA-v64w-49xw-qq89), you'll see that the vulnerability only affects the default NextAuth middleware. One of the fixes they also mention is writing your own middleware that avoid adds an additional check that was missing.
However, this middleware is never used inside our module, as we have our own custom Nuxt middleware. Therefore this vulnerability does not affect the module. If you have any additional questions feel free to raise them. 😊

Hello there :) Would it be possible to get some news re. this subject? I just checked, and it seems that the underlying v5 has been released since then.

Hello there :) Would it be possible to get some news re. this subject? I just checked, and it seems that the underlying v5 has been released since then.

Hey all, I wanted to +1 this request for an update considering the circumstances of the rewrite. :-)

Hi everyone 👋
Short update regarding our migration timeline: We are finalizing release 0.8.0 (Check out https://github.com/sidebase/nuxt-auth/releases/tag/0.8.0-rc.1). In this release, we primarily focused on housekeeping and improving the internal module code as well as some long-awaited and necessary updates for the local and refresh providers:
Housekeeping:

https://github.com/sidebase/nuxt-auth/pull/740
https://github.com/sidebase/nuxt-auth/pull/750
https://github.com/sidebase/nuxt-auth/pull/747
https://github.com/sidebase/nuxt-auth/pull/694

Refresh and Local Providers:

https://github.com/sidebase/nuxt-auth/pull/766
https://github.com/sidebase/nuxt-auth/pull/592

With the release of 0.8.0, we feel we have a much better basis for NuxtAuth to continue evolving. While I can't give precise updates on the next steps, I do hope to be able to update you soon once @phoenix-ru and I outline the scopes for the next release!

@zoey-kaiser Does NuxtAuth make use of any Next.js server actions? I am asking because I am wondering if using NuxtAuth in our project would open us up to any vulnerabilities surrounding this GitHub advisory: https://github.com/advisories/GHSA-fr5h-rqp8-mj6g
Thanks!

Hi @johnwilson-wsh 👋
Thanks for raising the advisory. I would also pull in @phoenix-ru for his opinion, but my initial thoughts are that this should not affect the module, as all requests are still made via the Nuxt 3 server. We have an internal "converter" that accepts H3events and transforms them into requests that NextAuth can handle (See code here).
Therefore, I do not think that any SSRF vulnerabilities exclusive to Nextjs would not affect this package!

Hi,
I was reading the documentation of the new version. I see that it is still stuck with the old NextAuth version, with the comment "NextAuth has changed their package exports, blocking NuxtAuth users from using the newer versions."
What do you think, when will this be solved? Is NextAuth doing this on purpose? If nuxt-auth is stuck to the old version for ever, this will be a dead end.
Regards,
Sven

What do you think, when will this be solved? Is NextAuth doing this on purpose? If nuxt-auth is stuck to the old version for ever, this will be a dead end.

Hey Sven! They changes the exports to prepare for their own next version. We had raised this with them and they will not change the exports. This is the reasons we are now working on a migration to authjs, to ensure that this module is not stuck on the old version!

Hi everyone 👋
I wanted to give a quick update on the AuthJS Migration! We have now pushed the first working version of NuxtAuth, using AuthJS under the hood 🥳
There is still much work under the hood to ensure all the features are working correctly, but we are confident this migration is going well! We would like to get this update into your hands as quickly as possible so you can help us test the module since testing every form of authentication internally is close to impossible 😮💨
Therefore, we aim to introduce the first alpha version of NuxtAuth 1.0.0 next week, which will already be available for you to download and test. We do not recommend running it in production yet. However, it would be fantastic if you could install it into your projects using NuxtAuth and see if any issues occur with your setup.
We will release more information on this in the coming week, as we are still figuring out how we want to deploy a second version of the docs for the migration and keep the main branch "clean" to push updates to  <=0.8.0. We will also add a new issue template specifically for NuxtAuth 1.0.0 issues.
Feel free to already peak into #818 and follow along with our progress!

Hello everyone! Thank you for this great project. It's a awesome library that I have as inspirational reference.
I've been trying<EMAIL_ADDRESS>and I like to report an issue.
I'm using the credentials provider with a custom login page that calls the signIn() of useAuth().
Before, the nuxt-auth/core callback handler have been returning an object with redirect property:

And the useAuth/signIn always expected to receive an object:

But now, with authjs, just throws an error:

The error is never handled, producing and internal server error:

And the useAuth/signIn now receives an HTML of the error page:

References:

<EMAIL_ADDRESS>- previous callback handler: https://github.com/nextauthjs/next-auth/blob/25388de0278f97f58f65bae85adf951ce09f5b21/packages/core/src/lib/routes/callback.ts#L280-L289

auth/core - now just throws: https://github.com/nextauthjs/next-auth/blob/748c9ecb8ce10bef2b628520451f676db0499f9d/packages/core/src/lib/actions/callback/index.ts#L327

Hi @guesant 👋
Thank you for being brave enough to try out the alpha! After publishing and playing around with it we ran into a lot of issues ourselves and due to this decided to refrain from making an official announcement!
Thank you for posting about your issue, I will take it into our list! As this version is still super early in development, we do not recommend using it in any capacity yet and hope to be able to release a more stable version soon, that can then be fully tested by the community!

Hi everyone 👋
I wanted to give another short update on the progress with the authjs migration! As mentioned in my comment above, we released an alpha version on our next branch, where we migrated to AuthJS under the hood.
Sadly this upgrade came with a lot of new issues and was not stable enough for a full release. However, as we wanted to continue developing the other provider and patch other bugs, we decided to backport a portion of the migration into main.
This was done in https://github.com/sidebase/nuxt-auth/pull/849, where we switched to the @auth/core methods exposed by AuthJS. NextAuth has already provided the majority of the new AuthJS core, which we now import, instead of the NextAuth imports. We could import these from next-auth/core (exports both the old next-auth versions and the "new" authjs versions). You can see an example of this here.
The next step will be to fully replace next-auth with @auth/core. We will continue testing the migration and ill try and keep you updated as best I can 😊


Add retry conig for gcp-datastore

GCP native java client allows to configure retries, but there is no way to do so if spring-data-datastore is used.
The native client is instantiated in a private method, so no way to change this. If a user defined Datastore bean with configured retries is exposed, this will not work because of namespaces. It is not possible to have both NamespaceProvider and Datastore at the same time. To add a custom datastore client, the entire namespace related instantiation logic have to be copied on user side. Suggestion is to add RestryConfigurationProperties read config from it and configure in getDatastore() method:
`	private Datastore getDatastore(String namespace) {
DatastoreOptions.Builder builder = DatastoreOptions.newBuilder()
.setProjectId(this.projectId)
.setRetrySettings(getRetrySettings())//the magic happens here
.setHeaderProvider(new UserAgentHeaderProvider(this.getClass()))
.setCredentials(this.credentials);
if (namespace != null) {
builder.setNamespace(namespace);
}
	if (this.host != null) {
		builder.setHost(this.host);
	}
	return builder.build().getService();
}`

@NorthernDarkness Would the retry properties need to be unique for each namespace, or global across the application?
Either way would involve adding properties to GcpDatastoreProperties (either simple properties or a map of them) and using them in GcpDatastoreAutoConfiguration.
Would you be interested in contributing a PR for this?

This looks natural to have retry settings global for all namespaces because a client is not aware which specific cluster in google data center handles a specific namespace request, so no reason to control it separately.
This change certainly requires a new items in GcpDatastoreProperties(or probably just create a common RetryProperties to share with other GCP products as retry settings are basically the same across all GCP native clients )
I can try to make a draft and push it later next week maybe.

One thing we can do is expose DatastoreOptions.Builder that Datastore getDatastore(String namespace) uses as a bean that can be overwritten.  Alternatively, we can create a factory interface that takes a namespace and produces a Datastore object.


Change file structure

Changes file structure to typical file structure for C++ projects. .cpp files should now be contained in src/, .h files should be in include/, .o files should be generated into build/ (but not uploaded), and the executable should be in bin/, again not uploaded.
When compiling, only changed files should be recompiled.

The bin/ directory is not created when it is missing.


Adding back performance updates

In favour of: #8

To be merged when these changes are on production again


Any tips on how to tunnel pwd through VPN?

Hello there,
I would like to pass all the containers created inside PWD through a VPN.
I edited the docker compose file to reflect the changes (see code below).
I tried different things like:

removing haproxy in order to reach the vpn service first and redirect it to PWD : I can't reach the backend even while specifying port 3000 in the playground domain : INTERNET -> Cloudflare domain -> VPN -> PWD
putting the VPN in front of haproxy - not sure on how to redirect ports together : INTERNET -> Cloudflare domain -> VPN -> haproxy-> PWD
adding a new frontend and backend to haproxy: INTERNET -> Cloudflare -> haproxy -> VPN -> haproxy -> PWD

On my playground domain page, I either get "503", "521" or "522 timeout" errors.
I'm using cloudflare with a ssl key configured inside haproxy, so the "normal" setup (without the vpn service) works like a charm, but I cannot pass pwd inside the VPN and reach it outside of localhost (by using the playground domain through cloudflare).
Here is my docker compose file:
version: '3.2'
services:
    haproxy:
        container_name: haproxy
        image: haproxy
        ports:
           - "80:8080" # http-in
           - "443:443" # https-in with ssl cert (cloudflare)
        volumes:
           - ./haproxy:/usr/local/etc/haproxy

vpn:
        depends_on:
            - haproxy
        container_name: nordvpn
        image: azinchen/nordvpn:latest
        cap_add:
            - net_admin
        devices:
            - /dev/net/tun
        environment:
           - USER=mail
           - PASS=pass
           - COUNTRY=Germany;IE;131
           - GROUP=Standard VPN servers
           - RANDOM_TOP=10
           - RECREATE_VPN_CRON=5 */3 * * *
           - NETWORK=<IP_ADDRESS>/16;<IP_ADDRESS>/16;<IP_ADDRESS>/16 # tried differents ip with no sucess
           - OPENVPN_OPTS=--mute-replay-warnings

        restart: unless-stopped

 pwd:
        depends_on:
            - vpn
        network_mode: service:vpn
        # pwd daemon container always needs to be named this way
        container_name: pwd
        # use the latest golang image
        image: golang
        # go to the right place and starts the app
        command: /bin/sh -c 'ssh-keygen -N "" -t rsa -f /etc/ssh/ssh_host_rsa_key >/dev/null; cd /go/src/; if [ -e /runbin/pwd ]; then /runbin/pwd  -save /pwd/sessions -name l2; else go run api.go -save /pwd/sessions -name l2; fi'
        volumes:
            # since this app creates networks and launches containers, we need to talk to docker daemon
            - /var/run/docker.sock:/var/run/docker.sock
            # mount the box mounted shared folder to the container
            - $PWD:/go/src
            - sessions:/pwd

    l2:
        depends_on:
            - vpn2
        network_mode: service:vpn2
        container_name: l2
        # use the latest golang image
        image: golang
        # go to the right place and starts the app
        command: /bin/sh -c 'ssh-keygen -N "" -t rsa -f /etc/ssh/ssh_host_rsa_key >/dev/null; cd /go/src/router/l2; if [ -e /runbin/l2 ]; then /runbin/l2 -ssh_key_path /etc/ssh/ssh_host_rsa_key -name l2 -save /pwd/networks; else go run l2.go -ssh_key_path /etc/ssh/ssh_host_rsa_key -name l2 -save /pwd/networks; fi'
        volumes:
            - /var/run/docker.sock:/var/run/docker.sock
            - $PWD:/go/src
            - networks:/pwd
        ports:
            - "8022:22"
            - "8053:53"

volumes:
    sessions:
    networks:

Any help on how it would be possible to achieve this?
Thank you.

If you configure your host to connect  to the VPN, all the containers inside PWD should use the VPN since the traffic is routed through the host. Would that work for you?

Hi Marcos,
Thank you for the advice! I didn't think about that. Unfortunately I lose the connecion (SSH) to my server when I activate the VPN. I'm trying to add a route and/or whitelist the port 22 but without sucess for now. I feel like it may have something to do with the network settings added to make docker/PWD run when I installed them.
By the way, I want to thank you for your work, I'm watching some of your conferences on Youtube and I learn a lot. You are an inspiration to me.
Best,
Max

Awesome!
don't hesitate to ask here in case it's giving too much trouble.
Cheers!

I may need your help if you know about this networking stuff 😀
Here is my config (X.X.X.X being my server public IP):
ip route show
default via X.X.X.254 dev eno1 proto dhcp src X.X.X.X metric 100
<IP_ADDRESS>/16 dev docker0 proto kernel scope link src <IP_ADDRESS> linkdown
<IP_ADDRESS>/16 dev docker_gwbridge proto kernel scope link src <IP_ADDRESS>
<IP_ADDRESS>/16 dev br-6c8ed30a7002 proto kernel scope link src <IP_ADDRESS> linkdown
<IP_ADDRESS>/16 dev br-74614dc112f3 proto kernel scope link src <IP_ADDRESS> linkdown
X.X.X.0/24 dev eno1 proto kernel scope link src X.X.X.X
X.X.X.254 dev eno1 proto dhcp scope link src X.X.X.X metric 100

route -n
Kernel IP routing table
Destination     Gateway         Genmask         Flags Metric Ref    Use Iface
<IP_ADDRESS>         X.X.X.254 <IP_ADDRESS>         UG    100    0        0 eno1
<IP_ADDRESS>      <IP_ADDRESS>         <IP_ADDRESS>     U     0      0        0 docker0
<IP_ADDRESS>      <IP_ADDRESS>         <IP_ADDRESS>     U     0      0        0 docker_gwbridge
<IP_ADDRESS>      <IP_ADDRESS>         <IP_ADDRESS>     U     0      0        0 br-6c8ed30a7002
<IP_ADDRESS>      <IP_ADDRESS>         <IP_ADDRESS>     U     0      0        0 br-74614dc112f3
X.X.X.0   <IP_ADDRESS>         <IP_ADDRESS>   U     0      0        0 eno1
X.X.X.254 <IP_ADDRESS>         <IP_ADDRESS> UH    100    0        0 eno1

ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
2: eno1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP group default qlen 1000
    link/ether e0:69:95:50:24:84 brd ff:ff:ff:ff:ff:ff
    inet X.X.X.X/24 brd X.X.X.255 scope global dynamic eno1
       valid_lft 86208sec preferred_lft 86208sec
    inet6 2001:41d0:2:bae1::/56 scope global
       valid_lft forever preferred_lft forever
    inet6 fe80::e269:95ff:fe50:2584/64 scope link
       valid_lft forever preferred_lft forever
3: docker0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default
    link/ether 02:42:56:ff:c7:c7 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/16 brd <IP_ADDRESS> scope global docker0
       valid_lft forever preferred_lft forever
4: br-6c8ed30a7002: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default
    link/ether 02:42:54:58:9a:46 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/16 brd <IP_ADDRESS> scope global br-6c8ed30a7002
       valid_lft forever preferred_lft forever
5: br-74614dc112f3: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default
    link/ether 02:42:dd:aa:8d:d0 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/16 brd <IP_ADDRESS> scope global br-74614dc112f3
       valid_lft forever preferred_lft forever
6: docker_gwbridge: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default
    link/ether 02:42:66:9e:ef:8a brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/16 brd <IP_ADDRESS> scope global docker_gwbridge
       valid_lft forever preferred_lft forever
    inet6 fe80::42:66ff:fe9e:ef8a/64 scope link
       valid_lft forever preferred_lft forever
12: vethbc26922@if11: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue master docker_gwbridge state UP group default
    link/ether 3a:e7:bb:ec:31:39 brd ff:ff:ff:ff:ff:ff link-netnsid 1
    inet6 fe80::38e7:bbff:feec:3139/64 scope link
       valid_lft forever preferred_lft forever

I install nordvpn .deb package according to https://www.makeuseof.com/how-to-install-nordvpn-ubuntu/
I typed:
nordvpn login --legacy
Email: **
Pass: **
nordvpn connect
and poof* no more connection. I'm even unable to connect, I have to reboot the server from my hosting account.
I tried these commands: https://unix.stackexchange.com/questions/432709/what-exactly-does-these-ip-lines-do/432784#432784
To add a route. But with no sucess... I don't know if you are familiar with nordvpn or if you are able to reproduce the issue, but I used nordvpn whitelist add 22 which was supposed to help me connect to SSH...
I took days and I'm about to give up :-/
Thank you again!

I think I can help. I'll check it out tomorrow.

Hi Marcos,
Almost a year passed since my first message and I still don't have a solution.
I connect to the VPN from the host but PWD instances don't load at all (same problem than trying to SSH to the server: nothing happens).
I guess the best way would be to load a nordvpn container with docker-compose and pass the other containers to it? I tried something like this in my first message but I don't know docker well enough to make this work.
If you have any tips for that I'd gladly ready them
Best


2022032401

added various gamers
proof in issues:
Closes #2661  , Closes #2702 , Closes #2707 , Closes #2709
Redundant addition requests (already included in issues above):
Closes #2632 , Closes #2664 , Closes #2668

Please review removal request #2506
Thank you in advance

14YeKFGXE23yAdACj6hu5NWEcYzzKxptYbm5jHgzw9A1P1UQfMv wallet with funds sent from this farms above. Just take first hotspot from list in https://github.com/helium/denylist/issues/2661 and track.

I have included this in https://github.com/helium/denylist/pull/2734
You may close this. Thanks.

I have included this in #2734
You may close this. Thanks.

Can you please take a look at removal request #2506?


templateParameters are required

The templateParameters property Microsoft.ApiManagement/service/apis/operations is failing
    [-] Template Should Not Contain Blanks (14 ms)         Empty property:  [] found on line: 52 Index:1663
But it seems like it is not required.
Microsoft Docs
After creating one manually this is the template I can export:
        "properties": {
            "displayName": "test",
            "method": "GET",
            "urlTemplate": "/testerenstest",
            "templateParameters": [],
            "responses": []
        }

Not relevant


Update docs

Description (motivation)
Improve docs in docs.go and README.md.
Provide links to Quick Start guide, list of struct tags, encoding options, decoding options, etc.
Make it clear that both em.Marshal(v) and encoder.Encode(v) use encoding options specified during creation of encoding mode em.

Thanks.  Looks good!


migration techradar

[x] Adjust Gitlab Build
[x] Add CI Token in Gitlab
[x] Add applicaton in showroom
[x] Notified the project team
[ ] referenced default branch
[ ] openshift deletion

added to monitoring b50d2d6

Migration completed.


[HUDI-5572] Flink write need to skip check the compatibility of Schem…

…a#name
Change Logs
add HoodieTable#isNeedCheckSchemaNames
Describe context and summary for this change. Highlight if any code was copied.
Impact
Solve the compatibility problem of schema of flink and spark.
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[x] Read through contributor's guide
[x] Change Logs and Impact were stated clearly
[x] Adequate tests were added if applicable
[x] CI passed

@hudi-bot run azure


Add option to pip source distribution for building HELICS from source

Add an option (--full_build) to compile a copy of HELICS when using a pip source distribtution.

The switch over to scikit-build-core makes this work. There are some limitations -- any features using Boost are disabled, and the ZeroMQ core isn't available either.


Does not works when used with mod

#![cfg(test)]
#![feature(proc_macro_hygiene)]
use casey::{camel, lower, shouty, snake, upper};

mod abc{
    pub fn abc() -> bool {
        true
    }
}

#[test]
fn it_works_to_lowercase() {
    fn abc() -> bool {
        true
    }
    assert!(lower!(ABC)());
    assert!(abc::abc());
    assert!(lower!(ABC)::abc());  //expected type, found module `abc`
}

Thanks for the bug report @imerkle!
This should work out-of-the-box but I believe it is an issue with proc macro hygiene, see https://github.com/rust-lang/rust/issues/54727#issuecomment-468420719 and related discussion.
I'll look to come up with a workaround to resolve this in the meantime

Seems to be resolved in recent rust stable versions


refactor: refactor and replace use NIO

refactor and replace use NIO
Proposed changes
Issue Number: #11768
Problem summary
replace use NIO and some check-style warning, the replace scpoe CONTAINS fe-core/src/test
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[✅] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[✅] No 【It do not need unit test anymore】
[ ] No Need

Has document been added or modified:

[ ] Yes
[✅] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[✅] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[✅] No

@jackwener Hi, can you help this pr review, thx


Adce refactor (NFC)

This PR has two commits that are just refactors of the ADCE code.  The refactoring is not complete.  Please do not ask me to do more at this time, but check that the new code is okay.  You can look at each commit on its if you want.

The refactor seems to have broken loop unswitching.

The refactor seems to have broken loop unswitching.

I was only running test_opt and the loop tests are in test_opt_loop.  I should have run it before.  Anyway, I have fixed that.


Remove version: Microsoft.Edge version 109.0.1518.70

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping @Exorcism0666, I'll get a notification.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

URL: https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/64daea79-a443-4a1b-b23a-b286e37e08f6/MicrosoftEdgeEnterpriseARM64.msi
Status Code: 200
(Automated message - build 694)


feat: add Annotation

What do you think if for the arrow you make the triangle at the end aligned to the direction on the line? having the starting and ending point you can calculate the angle and make the rotation (it should be something like rotate(${Math.atan(dx/dy)}rad)

What do you think if for the arrow you make the triangle at the end aligned to the direction on the line?

It's already the case thanks to the marker attribute orient


Update one extra use of unversioned python

Thanks Stefano Rivera<EMAIL_ADDRESS>for the patch

The change was uploaded on Ubuntu there
https://launchpadlibrarian.net/463544872/meson_0.53.0-1ubuntu1_0.53.0-1ubuntu2.diff.gz
and that fixes the build in focal when /usr/bin/python has been removed


mounting /tmp in devcontainer.json not required?

What happened?

Devcontainer builds have an error about x11 being read only, and is referencing the wrong port (X1 when should be X0?)
Container server: Error: listen EROFS: read-only file system /tmp/.X11-unix/X1
a clue found here
The devcontainer "postCreateCommand": "cat .devcontainer/bashrc.override.sh >> /home/dev-user/.bashrc" does not run and hangs the Configuring Dev Container (show log) status, so no DATABASE_URL sourced in .bashrc.

What should've happened instead?
No errors and successful execution of postCreateCommand.
How to fix
The clue here suggests there is no need to mount /tmp in devcontainer.json as it is now handled automatically by vscode.
Simply comment out the mount of /tmp in mounts like so:
"mounts": [
        {
            "source": "./.devcontainer/bash_history",
            "target": "/home/dev-user/.bash_history",
            "type": "bind"
        },
        // {
        //     "source": "/tmp",
        //     "target": "/tmp",
        //     "type": "bind"
        // },
        {
            "source": "~/.ssh",
            "target": "/home/dev-user/.ssh",
            "type": "bind"
        }
    ]

and all good!

Would you like to send us a pull request to fix that?


Remove python dependency

Everything thats done with the python scripts is possible by using plain starlark and one call to cat.

Thanks! This is cool.


Crashes for Unet finetuning

Hi @allenzren. I'm trying to reproduce the fine-tuning results of unet diffusion policy on furniture bench. I got these crashes after around 30 iterations.
823 Error executing job with overrides: ['train.val_freq=50', 'train.n_train_itr=500']
2824 Traceback (most recent call last):
2825   File "script/train.py", line 87, in main
2826     agent.run()
2827   File "/home/edward/projects/dppo/agent/finetune/train_ppo_diffusion_agent.py", line 126, in run
2828     obs_venv, reward_venv, done_venv, info_venv = self.venv.step(
2829   File "/home/edward/projects/dppo/env/gym_utils/wrapper/furniture.py", line 124, in step
2830     obs, sparse_reward, dense_reward, done, info = self._inner_step(action)
2831   File "/home/edward/projects/dppo/env/gym_utils/wrapper/furniture.py", line 147, in _inner_step
2832     obs, reward, done, info = self.env.step(action_chunk[:, i, :])
2833   File "/home/edward/anaconda3/envs/dppo/lib/python3.8/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
2834     return func(*args, **kwargs)
2835   File "/home/edward/projects/dppo/furniture-bench/furniture_bench/envs/furniture_rl_sim_env.py", line 2017, in step
2836     obs = self.get_observation()
2837   File "/home/edward/projects/dppo/furniture-bench/furniture_bench/envs/furniture_rl_sim_env.py", line 1293, in get_observation
2838     robot_state = self._read_robot_state()
2839   File "/home/edward/projects/dppo/furniture-bench/furniture_bench/envs/furniture_rl_sim_env.py", line 1160, in _read_robot_state
2840     ee_pos, ee_quat = self.get_ee_pose()
2841   File "/home/edward/projects/dppo/furniture-bench/furniture_bench/envs/furniture_rl_sim_env.py", line 1211, in get_ee_pose
2842     hand_pos = self.rb_states[self.ee_idxs, :3]
2843 RuntimeError: CUDA error: an illegal memory access was encountered
2844 CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
2845 For debugging consider passing CUDA_LAUNCH_BLOCKING=1
2846 Compile with `TORCH_USE_CUDA_DSA` to enable device-side assertions.
2847 Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.

Do you have some idea what might have gone wrong? Thank you very much.

Hi @edwardjjj, I actually haven't seen this error before. The only issue I am aware of has to do with NaN observation in Furniture-Bench but that error looks different than this one.
Can you share which config you are running? I can try looking into it but I doubt that I can reproduce the error. Meanwhile I suggest you can try re-running it and see if the same error shows up.

@ankile, Lars, any idea about this error?

Thank you for getting back to me. After further investigation, we found that these crashes always happen on the same node. So possibly it is a driver version issue. I'll share my findings after more tests.

I see, let me know if you find anything. I would be curious to know. Thanks!


move reject with isolation logic in fcntl

This PR moves the block of logic inside fcntl to reject if isolation is enabled into the branch checking if the command is F_FULLFSYNC on apple. This allows fcntl to duplicate file descriptors while using isolation.
This means we can now run the tokio tests with isolation.
This PR allows moves the now passing fcntl logic from libc-fs-with-isolation.rs into two different tests:

fcntl(1, libc::F_DUPFD, 0) succeeds with isolation
fcntl(1, libc::F_FULLFSYNC, 0) fails with isolation on MacOS

How would I assert there’s no error without checking last_os_error?

Check the fcntl docs, the return value will somehow indicate whether there was an error.
One never checks last_os_error unless one already knows that there was an error and wants to learn what the error was.

One never checks last_os_error unless one already knows that there was an error and wants to learn what the error was.

During review I said to leave it in, because it doesn't hurt. What's the worst case? We notice when the default value changes?
We could move it to a separate test tho.

@rustbot author

@bors r+

:pushpin: Commit 25f5a02fdd0528a37a1166a7176364724c7513a8 has been approved by oli-obk
It is now in the queue for this repository.

:sunny: Test successful - checks-actions
Approved by: oli-obk
Pushing c1fc5248f416ca1175a12421ce37452b52344565 to master...


Wrote failing test.  Fixed bug.  Test passes for opening host url with base twice

Currently, skyux serve will open the host url but include the app base twice.  This is caused due to updates to host-utils.
I first updated my test to fail in it's current state (making what url I test is opened more strict).  Then fixed the bug and have the test pass.

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #78   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          22     22
  Lines         513    513
  Branches       59     59
=====================================
  Hits          513    513

Impacted Files
Coverage Δ

config/webpack/serve.webpack.config.js
100% <ø> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a90d6f...0abd291. Read the comment docs.


SSE+AVX2: Addition test failing

The addition test fails in both backends on the next operation:
vecf<8> a4= {8,5,2,5,2,5,8,0};
vecf<8> b4= {5,7,6,8,0,3,6,3};

Fixed on latest commit.


[spirv] Plumb NCHW convolution support through

This commit enables tiling and vectorizing NCHW convolution ops.
The vectorization flow still needs further improvements, like
removing vector.extract/vector.insert pairs due to vector.transpose,
enabling hoisting vector.transfer_* ops, etc.
Towards https://github.com/iree-org/iree/issues/10536

test_shark_model_suite is failing due to dependency installation issue: "Installing build dependencies: finished with status 'error'". That's unrelated to this one. So I'll ignore it and land this patch.


Refactor enrichers/converters from all plugins to adopt cursor and batch insertion approach

Description
When dataset grows too big, we have two things to consider:

OOM might occur if we keep loading all rows from table into memory
Enrichment/Conversion become super slow

Describe the solution you'd like

All data reading should use cursor instead of gorm.DB.Rows method to avoid OOM
Insert/Update should be operated in Batch Mode

Example implementation can be seen here:  https://github.com/merico-dev/lake/pull/967/files#diff-323d48ffd286c2e4453d8c77076e3ceeaf8d8f23a7757357697a3821bc3f7e43R12
Has the Feature been Requested Before?
No

Addressed by #1287


Updated Readme to add three emojis to title

Made these changes as I was told to in the Github training. Closes alphagov/govuk-design-system#186

You can preview this change here:
Built with commit 5242a1ae8ae0405420dbf40f8f2c11ca84f532f8
https://deploy-preview-188--govuk-design-system-preview.netlify.com


Translations: Tab view for different languages

Make it easier to change between page translations (e.g. design tabs for each language).
This is part of #104.

This was solved in #205


Add some basic unit tests to improve test coverage.

Since I am looking to using Connexion in one of our projects, and was specifically interested in writing unit tests for this, I decided to have a look at the unit tests and add a few test cases that improve the coverage.
Please have a look. I welcome any questions or comments with regards to coding style etc.

:+1: looks great, thanks a lot :sunny:


Removing the infinite loop guard in the bootsector does not prevent qemu from executing it

Context
There is a behaviour (maybe) related to qemu I don't understand.
I just tried the first lesson, and I wanted to see what would happen to the V.M. if the infinite loop "guard" was removed.
Note:
bootsector.asm:
jmp $ ; <--<--<--<--<-- the infinite loop i'm talking about
times 510-($-$$) db 0
dw 0xaa55

Expected
Qemu crashes.
Actual
Nothing changes visually. No error or warning is issued.
Issue
I don't understand what happens behind the scene. Is the presence of an infinite loop at the end of a boot-sector optional? Or is qemu some sort of wizard that knows magically when to stop the execution of the boot-sector?

Ive noticed that nasm reacts weirdly to errors, by just "loading the back up of the previous version". I dont know if thats true, just a feeling

QEMU would just continue running whatever there is in memory after the bootsector. Which is zeros. Or garbage data. Once it has gone over all the zeroes of the bootsect it finds the magic number. Let's dissasemble the magic number. What does it do?
push bp
stosb

and so we push bp to the stack and issue the stosb instruction(which by having SI and DI undefined, we are not sure what is it doing). Then we continue running. Likely we find more zeroes. Or maybe BIOS code all over the place. The behaviour is undefined. Probably just running up in memory forever.
Why would any warning or error be issued by QEMU?
As you yourself said, QEMU is not a wizard that knows where the bootsector stops, so how could it know when(or why) to throw a warning?
It just runs what is in memory. Simple enough, that's how computers work.
Hope that awnsered your question :)

Simple and clear. Thanks!


Remove hardcoded sleep when waiting for SSH in container

There is a hardcoded sleep() in the code that waits for the pwnbox container to have ssh available. I try to wait for the port to be available but it seems inefficient, if I can find a better way without introducing external dependencies that would be great.

Looks like this is the only way, so closing this issue.


Can't list tag hints when typing "tag:" in search box

Bug Description
when search files with a tag forgotten the name, with the default theme, once typing "tag:" in the box, all tags will list, it's is helpful. but It's regret that shimmering focus miss it. expect tag hint can be added to searching. thanks!
Relevant Screenshot

To Reproduce
type "tag:" in search box, no tag hint.
Sample Text
No response
Obsidian Version
1.5.3
Installer Version
1.4.16
In which mode(s) does the problem occur? (if applicable)

[ ] Source (Edit)
[ ] Reading (Preview)
[ ] Live Preview

Which operating system?

[ ] macOS
[ ] Linux
[X] Windows
[ ] iOS
[ ] Android

Checklist

[X] I updated to the latest version of the theme (Settings → Appearance → Check for updates).
[X] If your installer version is much lower your app version, you should update it by re-downloading Obsidian from the Obsidian website. The installer version can be seen in the Obsidian settings (About → App → Installer Version).
[X] I made sure that the issue is related to this theme by checking that the problem does not occur with the default theme.
[X] In case I am missing an UI element, I have checked that it cannot be re-enabled with the Style Settings plugin.
[X] My issue concerns Obsidian version 1.0+ and I am not using the Legacy Editor (CM5). (Older Obsidian versions and the Legacy Editor are not supported by this theme anymore.)
[X] This issue concerns the theme in general and is not related to a specific plugin, for which there is the plugin-support form.

fixed

fixed

Thanks!

fixed

Thanks!


Error:Cannot access first() element from an empty List

On MAC and Windows I get this error when attempting to compile the source code.

I removed the publish section from the gradle files


Fix handling of blank commands

When a potential system pager passed in via
the environment variables or git configuration
yields a pager that is blank ("") or whitespace-
only ("  ") the call to TTY::Which.exist?
would raise an error.
This behavior could be fixed in either gem,
however I was wary of having TTY::Which
gracefully handle this case and then have
dependencies (including TTY::Pager) need
to know about its behavior when nil is
passed; as a result fixing TTY::Pager
seemed cleaner to me.
Closes #5.

Coverage increased (+0.08%) to 90.833% when pulling 87497da075e8caf7fa02882fb73b30ec5b37771c on JacobEvelyn:blankety-blanks into 0f721b9e7a1a5e89bca3ba8abe4a96504cd52dc0 on piotrmurach:master.

Thanks ❤


Add androidx support.

Replace android.support with androidx in import.

Hello :)
Maybe we can simply remove the annotation ? Like what you did here : https://github.com/itinance/react-native-fs/pull/691
Just to ensure the two-ways compatibility.

Thanks @maieonbrix and @se-bastiaan ! I removed the annotation and androidx import.

Thanks for this. We just released beta version of the new version of our SDK which has the fix already in there.
See: https://github.com/getsentry/sentry-react-native/issues/612
If really necessary I can make a patch release.

I think that completely depends on the planning for the v1 of the SDK. I would say that this, as a breaking change, is the perfect moment to only support react-native v0.60 and higher as you already mentioned in #612. However, if v1 takes longer than expected it would be nice to have a patch release. For now, no need imo. We'll have to wait for other packages and their updates to be able to update to RN 0.60 anyways.

Can we merge this PR?

I will close this PR since it's outdaten, please migrate / use our new SDK which has support for AndroidX
https://github.com/getsentry/sentry-react-native/issues/612


build: fix release-please config format

Is the indentation correct for branch propertyies?

Yeah, it should be fine as it is - could also indent everything an extra 2 spaces at the front too


Question about setting ArgoCD image to patch the argocd components

Is your feature request related to a problem? Please describe.
Regarding CVE-2022-24348  "Path traversal and dereference of symlinks when passing Helm value files" I want to upgrade to ArgoCD version 2.2.5, quay.io/argoproj/argocd:v2.2.5.
I have set the property Image to argocd image 2.2.5:
apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
spec:
  image: quay.io/argoproj/argocd@sha256:bac1aeee8e78e64d81a633b9f64148274abfa003165544354e2ebf1335b6ee73

Failed to apply default image tag "quay.io/argoproj/argocd@sha256:bac1aeee8e78e64d81a633b9f64148274abfa003165544354e2ebf1335b6ee73@sha256:358c244c96313ca3bf9f588
dc870d8123fc22ffa5c231c57da10f77b8d671c66": couldn't parse image reference
"quay.io/argoprojargocd@sha256:bac1aeee8e78e64d81a633b9f64148274abfa003165544354e2ebf1335b6ee73@sha256:358c244c96313ca3bf9f588dc870d8123fc22ffa5c231c57da10f77b8d671c66":
invalid reference format

**Expected behaviour
I would expect that setting the Image property in ArgoCD CR would make the argocd componenents to use the image specified.

Hi @jonaslar, Please make the below correction to your CR.
apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
spec:
  image: quay.io/argoproj/argocd
  version: sha256:bac1aeee8e78e64d81a633b9f64148274abfa003165544354e2ebf1335b6ee73

Hi,
setting version as described above solved the problem. I find now that the property version is documented, https://argocd-operator.readthedocs.io/en/latest/reference/argocd/#version
Thank you for the help


[FEATURE] Fix the matrices

Current we have some soon-to-be-obsolete types (in m84, so not the next version, but the next next version):

SKMatrix44
SK3dView

This is all replaced with a new SKM44.
But we have System.Numerics...
However, Numerics does not have a matrix of 3x3 which we use all over. Having a mix is going to be weird and annoying.
Also, I may need to add members to the matrix for SkiaSharp uses, so using Numerics will get a bit messy.
But, intrinsics...
We could use SkiaSharp matrices on the members and fields, and then have then be implicitly convertible to VectorX and Matrix4x4 for things...
We also have SKPoint, SKPoint3, SKSize...
And no breaking changes...
Performance is important...
What to do, what to do...

A broad comment from my user perspective:

Breaking changes are not such a problem. Just document them well. It helps to put tags like these on the deprecated fields to the compiler can help in the migration:
[Obsolete("Use X instead", true)]
Performance is important. We iteratively draw again and again, so especially avoiding newing objects for simple operations is important.
If it is possible to avoid the slower solution by using the matrices directly while other users can use the implicit conversion this is fine as well.

It it hard to give more specific comments. Could you point to some code that would be affected and what it would look like after the changes?

For a major version bump, I am perfectly fine with breaking changes. After all, it is a new major version.
For SkM44, it seems to binary compatible at first sight with Matrix4
We should look at the memory layout of these matrices. Passing a matrix by ref and just casting the pointer might be the fastest way.
That only would work for matrices passed by reference. If Skia expects a matrix to be passed by value, then a copy is made anyway, so it doesn't matter what type we use.

We can't really do breaking changes too much since folks like Syncfusion/Telerik and other vendors will all have to update and then all users will have to make sure thy are all in sync.
@Ziriax If the ABI for Matrix4 and SKM44 are the same, then we could just ref it over... For Matrix, I cheat a bit as they have a whole bunch of other private fields. So I ref it over to my own type, and then copy it to the real matrix type.

We can't really do breaking changes too much since folks like Syncfusion/Telerik and other vendors will all have to update and then all users will have to make sure thy are all in sync.

Can't they just either update, either use older nugets?

@mattleibow Do we have https://api.skia.org/classSkM44.html in v3 preview?
In order to replace SK3dView we need the LookAt() etc.. Maybe I missed something.
We could indeed use System.Numerics Matrix4x4 CreateLookAt but then do we have a FAST conversion between this dontnet and skia SKMatrix that is used for SKCanvas.SetMatrix?
Personal vote regarding "what to do what to do" would be to ignore System.Numerics duplicates and go for including the skia latest API without cheats.

We should have SKMatrix44. Is there some API on there that is missing?

Yes, in order to replace SK3dView i need the LookAt, map, normalizePerspective etc.
Do you mean SKMatrix44 is equivalent to skm44?

It should be. I just chose a better name (I hope).
The implementation is currently a bit of a lie as I just use the system numeric Matrix4x4 under the hood. It is also implicitly castable between it.
I may not have mapped all the apis since they had a bunch that I may not have felt it was easy to write myself. Let me know if those apis are missing. It may not be the same as the SK3dVoiew was from the perspective of a camera or something. Matrix is just a matrix, but I think they have some create methods in there.

@mattleibow I may be totally wrong on every point below, please feel free to correct me:

Skia deprecated SK3DView, SKCamera3D, SKPatch3D, because they provided a more flexible SKM44, that has methods to recreate the 3d camera behavior.
Skiasharp has now bindings to SK3dView removed and its replacement (SKM44) not introduced as SKMatrix44 class is not bound to SKM44 but is using System.Numeric.Matrix4x4. This one doesn't provide the same methods SKM44 provides, just looking at the docs https://api.skia.org/classSkM44.html.
Using bindings to SKM44 can result in slower executing time with interop compared to calling System.Numeric.Matrix4x4, yet these are (a bit?) different.

I have created a custom implementation of a SK3dView using System.Numeric.Matrix4x4 and its Matrix4x4.CreateLookAt, and while overall the result is similar comparing the result between the original SK3dView and this custom implementation I see differences in 3D. They might come from the implementation itself, but being currently stuck with it I'm left to think that using directly SKM44 that is intended for this and has c++ code from SK3DView, SKCamera3D and SKPatch3D, would instantly solve my problem.
While personally missing (this)[https://github.com/mono/SkiaSharp/issues/1330#issuecomment-2438307929]) other people could be missing other API from SKM44, depending on usage. Again, this is just one use-case, other people might still expect to be able to interop with SKM44.
One day i might solve my problem using just System.Numeric.Matrix4x4, but i'm left to think that Skiasharp missing a latest and modern part of the skia library, which is SKM44, could have its impact.

OK, I see. You are not wrong, it all comes down to me not yet doing all the things I wanted to in my semi-limited time.
The current SKMatrix44 in SkiaSharp is just the basics needed to make things work. I see SkM44 does have several more APIs that I have not yet ported/wrapped/exposed since I did not yet have the opportunity to do so. I do not want to directly bind the SKM44 object in C++ to the C# world as then each time we do an operation we will have to potentially copy data as well as hop the interop bridge - which will be way slower than doing it in C# directly. I took a shortcut for now to just wrap the Numerics Matrix4x4 so I could get something working. It is slower than I want, but not as slow as doing interop.
What I would like to do is complete the implementation (using Numerics or not) of the SKMatrix44 so that it can be a replacement for the old camera implementations.
Maybe give a list of all the APIs right now that are missing so I can prioritize them.
If you have an implementation for some APIs, we can use that too. You mention that you see differences, so maybe if you have a test case for each of your APIs and then we can make sure the new APIs match what SkM44 does. I am also not sure if the camera APIs are supposed to be a 100% drop-in replacement since they may have fixed a bug or changed the implementations. Where are you seeing the case that SK3DView and SkM44 are supposed to be exactly the same?
At the end of all this, I didn't get the time I needed to fully recreate the SkM44 API in C#, so just leveraged the Numerics. Any missing APIs were just a result of me not knowing which ones to prioritize so just got the basics working.

With regards to:

do we have a FAST conversion between this dontnet and skia SKMatrix that is used for SKCanvas.SetMatrix?

Is this fast enough?
public static implicit operator Matrix4x4 (SKMatrix44 matrix) =>
	Unsafe.As<SKMatrix44, Matrix4x4> (ref matrix);

public static implicit operator SKMatrix44 (Matrix4x4 matrix) =>
	Unsafe.As<Matrix4x4, SKMatrix44> (ref matrix);

Here is my short implementation of Sk3dView i use for v3: https://github.com/taublast/DrawnUi.Maui/blob/2-A/src/Engine/Internals/Helpers/3D/Sk3dView.cs
Funny enough was first using Matrix4x4 CreateLookAt, got stuck with z-rotation not being "non-affine" then did a version with Matrix4x4 CreatePerspective, was kinda working but looked IMHO over-complicated, and finally ended up with just approximative maths.
Actually i'm failing to make it pass this test, ApplyToCanvas is not working as it should because of the missing "mapping matrix by new matrix" process that was done by SkCamera3D+SkPatch3D.
void Sk3DView::getMatrix(SkMatrix* matrix) const {
    if (matrix != nullptr) {
        SkPatch3D   patch;
        patch.transform(fRec->fMatrix);
        fCamera.patchToMatrix(patch, matrix);
    }
}

Otherwise if I use only the .Matrix getter to postconcat my canvas for non-affine transforms of skia controls (that was the goal initially) the result is pretty similar, maybe even identical, to one produced by the original v2.

This is to say that when someone would want to implement the patch.transform(fRec->fMatrix); fCamera.patchToMatrix(patch, matrix); they could maybe find SKM44 helper methods useful. Personally I'm forced to leave it as it is for now due to lack of time.

Thanks for this! I'll have a look and see if I am missing the secret apis.

I have SkCamera3D +SkPatch3D csharp classes skeletons (incomplete ports) sitting in same folder as Sk3dView.cs for anyone to play with, just in case..

another interesting possible fact to be verified is the rotation orientation difference between SKM44 and Matrix4x4 that might come into play:
https://stackoverflow.com/questions/73007949/c-sharp-matrix4x4-multiplication-problems-with-createrotationx-createrotatez

I might be mistaken, but think this is due to the classes originating from SharpDX which was written with DirectX in mind, and the DirectXMath helper functions create clockwise rotation matrices aswell. –
Ray
CommentedJul 16, 2022 at 22:30

Thanks for the extra info. I will have a look and run both SK3dView and SKMatrix44 side-by-side and see if I can get them to work the same or at least figure out why they are different.


Fix broken inline install when fullscreen.

The online install currently dies when Chrome is in fullscreen mode, with no feedback to user. This provides fix. Falls back to the link to the webstore already defined in the link href attribute.
Not tested locally.

Thanks @jasonpriem! Assigning @markmacgillivray

Have copied into the dev changes as I have the page open right now anyway, so closing the PR. Thanks for the fix!

👍


[Question]: Will the App be opensourced?

Hi,
InvenTree looks really promising but for my usecase I have to extend the android app's functionality.
The particular feature I'm looking for is RFID tag support (additionally to barcodes).
Will it be opensourced or how are new features collected/added?
Also I noticed that it is only available via Google Playstore for Android which makes it impossible to buy&install for ungoogled Android devices. Also saw https://github.com/inventree/InvenTree/issues/2204 so upon opensourcing F-Droid is the way to go to distribute FOSS apps.
Thank you in advance!

will be also an update for https://github.com/inventree/InvenTree/issues/1951

@hacker-h as far as I am aware the questions were already answered in the linked issues. F-Droid does not work with the current model and is too small of an audience for the effort. This project is done solely in spare time by volunteers.
If you have feature requests please file them using the FR template.

@SchrodingersGat do you have anything to add to this or can I close?

APK releases would also be fine.
Upon opensourcing it will be easy to add additional release formats, otherwise will have to build another app and reinvent the wheel :/

As of now, there are no intermediate plans to open source, pls enjoy the great free inventory solution you were given and consider making an FR for the thing you want specifically. The maintainer of the app is great in delivering new features of they make sense.
You are free to create your own app, we provide APIs for that reason. If you do please kee an eye on
https://github.com/inventree/InvenTree/blob/4a5e4a88ac3e91d64a21e8cab3708ecbc6e2bd8b/InvenTree/InvenTree/version.py#L15-L27
changes in the API are marked by incrementing the version counter, you have to check for the version before assuming an endpoint exists.


Add docker context create command

The docker context create command is implemented like stated in the official docker docs.

Sorry for the delay, it was more complicated than I anticipated. It should be all good now. I will make a new release once it's merged in master


[Feature] Support LaserMix augmentation

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
The documentation has been modified accordingly, like docstring or example tutorials.

Hi @Xiangxu-0103 ,
Thanks for your kind PR. It seems that there are conflicts between your PR and the targeted branch. Could you solve the conflicts so that we could eventually merge this PR?
You can find more details in the place shown as below:

Hi @Xiangxu-0103 , Thanks for your kind PR. It seems that there are conflicts between your PR and the targeted branch. Could you solve the conflicts so that we could eventually merge this PR?
You can find more details in the place shown as below:

Hi @Xiangxu-0103 , Thanks for your kind PR. It seems that there are conflicts between your PR and the targeted branch. Could you solve the conflicts so that we could eventually merge this PR?
You can find more details in the place shown as below:

resolved.


Fixed WithX functions to preserve options

Fixed WithAttrs and WithGroup functions to preserve the NoBaggage option.

Hey @tomerf, thank you for taking the time to contribute!


Auto timeout

Is your feature request related to a problem? Please describe.
I believe it would be worth it to add an auto timeout to close Walker after a fixed amount of time.
When I was using Rofi I had this in my config.

timeout {
delay: 15;
action: "kb-cancel";
}

Describe the solution you'd like
Added a setting timeout_delay or similar new entry in the config with a default of zero (disabled)
Have you checked the wiki?
Yes?

Would you need the action? Or Just a timeout? What's the usecase here? Just so it disappears after X seconds of inactivity?

A simple timeout so it auto dismiss after the X seconds of inactivity.   No action required.

Added.

Thank you, tested and much appreciated.

Scrolling in the list of entries with the keyboard does not seem to count as activity.

Indeed rn only typing does.

Check latest release.

Talked to quickly, I'm seeing an odd behavior. Will try to report with repro steps.

Not sure if this is related, but the prompt cursor (Search...) caret stops blinking after 9 or 10 seconds.  Is this a feature ?
I believe it's a bug, because after it stops, then it seems the activity is no longer tracked so the program exits after the timeout even tho I'm still navigating the entries.
Attached a video illustrating the issue. All I do is Up/Down on the keyboard.  You can see the caret stops blinking and then it exits a bit after.
https://github.com/user-attachments/assets/0bcc2950-f17b-4466-aaee-356893f03da3

Odd indeed. I think there's a few more handlers missing... rn the timeout only respects typing and actual scrolling.

Ok, i have no idea what causes the cursor to stop blinking. It happens for me as well.
Latest commit should have fixed the timeout being ignored by the keystrokes though.

Yeah, I don't know why the caret stop blinking after 9 or 10s. Weird.
The timeout behavior is much better now.   Even tho I found one more edge case.
If I invoke  "walker"  and do not interact with it at all (no keystroke, no click, nothing)  it never timeout.
I have my timeout set at 15seconds.

Should be fixed, pls check latest release.

Sorry, forgot to go back to the issue to close.  Working good thx!


Fixing preview action enums.

See: http://docs.splunk.com/Documentation/Splunk/6.3.3/RESTREF/RESTsearch

Read guidelines, moving pull request to "develop" branch.


Allow use of datetime or timedelta where approriate, fixes #43

start, end and bucketDuration now accept native Python datetime functions.
@vnugent Comments?

Would you update the Readme as well?  LGTM otherwise.


Like Button interaction

Add file to create and like TVshow

🟢 STATUS: APPROVED
Hello @akhror-valiev 👋,
Your project is complete! You followed all the requirements, feel free to merge it! 😄
Congratulations! 🎉
Highlights
✔ POST & GET methods being used correctly.
✔ Nice usage of arrow functions.
✔ No linter errors.
Cheers and Happy coding!👏👏👏


Add UI for the cursorToolOnLoad pref in the Chrome extension + migration logic

While preparing for a release, I encountered the "Don't know how to handle cursorToolOnLoad!" error in the console of the options page. After an investigation, I found that the hand tool preference was converted from a boolean to an integer in #7635.
I fixed the UI and added migration logic - see the commit message for more details.
Test:

Run gulp chromium

Go to chrome://extensions in Chrome, enable Developer mode and load the extension from build/chromium/.

Click on Inspect background page of the extension, and run the following code:
chrome.storage.local.set({enableHandToolOnLoad: true}, function() {location.reload();});

Run the following code to confirm that the preference has been migrated:
chrome.storage.local.get('enableHandToolOnLoad', console.log); // Should be an empty {}.

Click on the "Options" link and confirm that the "Cursor tool on load" dropdown is set to "Hand Tool".

Optional (to check that the migration logic does not interfere with a normal functioning of the migrated pref):

Change the dropdown to "Text selection tool", close the options page, reload the extension and open the options page.
Confirm that the dropdown value is still at "Text selection".
Repeat step 6 and 7, but change from "Text selection" to "Hand tool" instead.

I verified this and it works as intended. Thank you for fixing this!


split control pin between os specific files

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#17  👈
#16
#15
#14
#13
#10 : 1 other dependent PR (#11 )
#9
#8
#7
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Cohors1316 and the rest of your teammates on  Graphite


<EMAIL_ADDRESS>godot (2.0)

https://github.com/caskroom/homebrew-cask/commit/bda8d5993400ecffb7ab6024141282ce41029509

Damn bots. It’s even the same commit. It had already made some nonsense comment early on, in another issue.

Thought so - cleaned up, regardless.


Fixed reception MTU by incorporating header offset.

This fixes #389.

I think this is correct behavior. The MTU defines the maximum size of the frame on the interface level. So that includes the network layer (CSP) header.
Take Ethernet for example, it's MTU is typically 1500 bytes. Not including the ethernet header (total 1518 bytes). But it does include the IP, IPX or whatever protocol is transferred over the ethernet frame.
So there problem must sending side its producing too long frames. (The real CAN limitation comes from the maximum frame length in the CFP field.)

Please see https://github.com/libcsp/libcsp/pull/391 for a fix


[5.8] Extract registered event and login to registered method

This is another approach to do the same thing as proposed in PR #27795 but without introducing new properties.
We will be able to fire another custom event on user registration (I could return event firing back to register method if there is no need) and skip auto-login by just overriding registered method with our own logic in application.
The only one bad thing could happen - if user already extended this method in application. Then it will become a breaking change and should be pointed to Laravel 5.9. I could make another PR to master branch if you wish.

This would have to go to 5.9.

@taylorotwell I've resubmitted this PR to master branch: #27807


Bit idea: set up eqwalizer

https://github.com/WhatsApp/eqwalizer
We could try this with dialyser and see the difference.
Maybe https://github.com/josefs/Gradualizer would be more interesting? It doesn't require an additional binary.

Implemented here: be5416dc8f98fa7951000ccacff9b60c22453a12


review/ see other product reviews

As a buyer on E-commerce
I need to be able to review the products I bought and see others reviews
So that I can compare products and decide which products to buy
Acceptance Criteria
Given that the buyer bought a product and got an email requesting to review the product
When the fill out the review field
Then this review should be submitted and should show in that respective product's page

Great start! I saw @josephiswhere's comment on another card that said maybe to specify the fields? Like "Number of reviewers" "Avg. Star Rating" ? Not sure how detailed we're supposed to get on these :)

This is great. Maybe we can offer the ability to sort reviews by "high to low", "date posted", etc. to increase utility to the user


Unable to get some GPU parameters in rocm 2.4

It worked in rocm 2.3 now rocm-smi and rocm-smi -a gives:
========================ROCm System Management Interface========================
================================================================================
GPU  Temp   AvgPwr  SCLK    MCLK    Fan     Perf  PwrCap  SCLK OD  MCLK OD  GPU%
0    31.0c  N/A     852Mhz  167Mhz  28.63%  auto  N/A     0%       0%       N/A
1    26.0c  N/A     852Mhz  167Mhz  27.84%  auto  N/A     0%       0%       N/A
================================================================================
==============================End of ROCm SMI Log ==============================

GPU[0] 		: Unable to get maximum Graphics Package Power
GPU[1] 		: Unable to get maximum Graphics Package Power
================================================================================
================================================================================
GPU[0] 		: Unable to get Power Profile
GPU[1] 		: Unable to get Power Profile
================================================================================
================================================================================
GPU[0] 		: Unable to get Average Graphics Package Power Consumption
GPU[1] 		: Unable to get Average Graphics Package Power Consumption

GPU[0] 		: Unable to get GPU use.
GPU[1] 		: Unable to get GPU use.
================================================================================
================================================================================
GPU[0] 		: Unable to display voltage
GPU[1] 		: Unable to display voltage

Hi @misos1
Sorry for the delay in responding, but if this problem is still happening, the report should probably go over to the rocm-smi repo. This repository is for the rocm-smi library, which is meant for linking into applications, not the rocm-smi command line script that you are using to see the problem here.


Add a Note Block

The notes from Omnivore notebook are currently only available as {{{note}}} in the template. Given that the note can be a free-form text, there is a high probability of the note breaking the formatting.
This PR creates a ### Note block right above the ### Highlights and puts each line of the note into a separate child block.

Hello, I'm not experienced with this repo, so apologies in advance if I state something obvious :) I've recently discovered 2 issues with logseq omvnivore plugin, and I'm interested if this PR tackles either / both of them.

If I add a note to the article itself (important - not a note for any of the highlights) then this note does not appear anywhere after I sync omnivore data from logseq. I've checked my config file and my default article template doesn't seem to have a {{{note}}} field by default. This is what I have in my .logseq\settings\logseq-omnivore.json: "articleTemplate": "[{{{title}}}]({{{omnivoreUrl}}})\ncollapsed:: true\nsite:: {{#siteName}}[{{{siteName}}}]{{/siteName}}({{{originalUrl}}})\n{{#author}}\nauthor:: {{{author}}}\n{{/author}}\n{{#labels.length}}\nlabels:: {{#labels}}[[{{{name}}}]] {{/labels}}\n{{/labels.length}}\ndate-saved:: {{{dateSaved}}}\n{{#datePublished}}\ndate-published:: {{{datePublished}}}\n{{/datePublished}}"

Then, if I add {{{note}}} to the above and resync the data, then the article note starts appearing after the sync. But if the note has multiple lines, then it breaks the article block, as only the 1st line of the note is attached to that block.

If I understand correctly, your PR resolves issue 2) that I've described? Does it also help with 1)?

@artjomsR, yeah, I had exactly the same issue and that's what that PR attempts to solve.
It solves both 1. and 2. in your example but it's somewhat opinionated, besides Hightligts block you'd get with original plugin you'd also get a Note block with a document (not highlight) note.

That’s great, thank you so much for the PR and explaining :)

Is there some progress on this request?


[Weekly] 2021-06-02

Last Week: #23

Should we use prefix for all classess (Liquid, LQ or similar) like UC last term? Currently, we are not consistent on this

Find a common schema for naming toggle entries to enable analysis for presentation

[ ] Retro

[ ] Decide about consistent term definitions https://github.com/hpi-swa-teaching/Liquid/issues/71#issuecomment-852416808

[ ] Planning Poker


[Relay Mining] Emit events and refactor test helpers

Summary

Event - Emitting an event when the relay mining difficulty is updated
Flaky - Added some flaky comments/pointers in different places
Refactor -  the event filtering function into a shared location
Utils - Updated testing to support a signed mined relay

Issue

#542

Type of change
Select one or more:

[x] New feature, functionality or library
[ ] Bug fix
[x] Code health or cleanup
[ ] Documentation
[ ] Other (specify)

Testing

[ ] Unit Tests: make go_develop_and_test
[ ] LocalNet E2E Tests: make test_e2e
[ ] DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

[ ] I have tested my changes using the available tooling
[ ] I have commented my code
[ ] I have performed a self-review of my own code; both comments & source code
[ ] I create and reference any new tickets, if applicable
[ ] I have left TODOs throughout the codebase, if applicable

@bryanchriswhite @red-0ne Few things to note in this PR:

The actual business logic was short & simple
A lot of work went into making the integration test work
A lot of improvements were made to the utilities in a way that existing ones were reused & refactored
@bryanchriswhite Special request - please make a mental note of all the TODOs in case you come up with better ideas in the future
@red-0ne Special request - see the TODOs in the code related to the telemetry. I will ask you to implement it on my behalf due to time limitations & because I'd like to present it at EthCC

@bryanchriswhite @red-0ne LOVE the comments on this! Ready for another review but also beginning to look much better after all your suggestions 🚀


Add static file secret-less sub-config support

Example successful pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3808554&view=logs&j=76b7f760-7857-5526-9942-d88b580eb83a&t=e7aafb05-307d-576c-4c8b-8cdd7950626b
Example wiring up in tests.yml https://github.com/Azure/azure-sdk-for-net/compare/main...djurek%2Fworkload-identity-live-tests-sub-config-files?body=&expand=1#diff-a38d5bba40ecff60e025723b70c9a682e464bcadf5e87e6571a641ca8659dee3R9-R12

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

This can merge once I can verify the final state of the PR against the ephemeral test subscription.

@danieljurek @weshaggard what is the need for the sub config file path parameter, and how is it different from https://github.com/Azure/azure-sdk-tools/tree/main/eng/common/TestResources/clouds? Or are we changing the path? I'm not a fan of this extra config field it seems unnecessary and something that could be inferred, but I don't think I have enough detail.

@danieljurek @weshaggard what is the need for the sub config file path parameter, and how is it different from https://github.com/Azure/azure-sdk-tools/tree/main/eng/common/TestResources/clouds? Or are we changing the path? I'm not a fan of this extra config field it seems unnecessary and something that could be inferred, but I don't think I have enough detail.

Our goal is to move the subscription configurations as files into the repo instead of in the KV. Now that they will not contain any secrets there is no reason we cannot have that configuration in the repo.

Chatted with Wes. I'm on board LGTM.

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


Prevent accessing to a branch instead of a single state

In the documentation, you mention a way to prevent accessing a state. But how can I restrict a state and all of its children with that? Specifically, I want to have a login state with a lot of children. No children should be accessed if the login condition is not met but I don't want to duplicate the same code for all of them. How's that possible?
I asked a more thorough question on Stackoverflow. Thanks.

http://bit.ly/UIR-SOF


Debug slow performance

Initial calls to enumerate Cloud Run regions takes upwards of 10s.
Need to debug to understand why. Alternatively, remove this call and hard code all regions as a constant.

Resolved by #19


[1.10.2] java.lang.NoSuchMethodError: dan200.computercraft.shared.computer.blocks.TileComputerBase.native_writeToNBT

Crash log: http://pastebin.com/8UUFupB0
Unborked 1.10.2-1.80pr0-1.0.5
CCTweaks 1.10.2-1.3.2

It is possible the NBT method mappings changed in 1.10.2, resulting in the correct method not being copied.


wikmd on Windows: Separate pandoc install not required

Hi,
Just tested wikmd on Windows.
Seems a separate installation of Pandoc isn't required anymore.
The requirements.txt seems to take care of that already.
Greetings,
Simon

Alright perfect, I remove it from the docs! Thanks for sharing.