Update New-ComplianceTag.md

A noticed that you can also add a note for a tag. So I have added the Notes parameter to the documentation.

OPS Build status updates of commit 9038150:
:clock10: Full build: the average full build time is 12 min(s) 23 sec(s), this is based on the last 14 build(s) for this repository.
:warning: This is a FULL build due to the 'master' branch had a configuration change, normally no action is required on your part. In the result that you find subsequent builds still performing full builds, please contact your repository admin to manually perform a full build on the 'master' branch. For more detailed info, please click here.

OPS Build status updates of commit 9038150:
:warning: Validation status: warnings

File
Status
Preview URL
Details

sharepoint/docs-conceptual/overview.md
:warning:Warning
View (sharepoint-ps)
Details

exchange/exchange-ps/exchange/policy-and-compliance-retention/New-ComplianceTag.md
:white_check_mark:Succeeded
View (exchange-ps)

sharepoint/docs-conceptual/overview.md

Line 9: [Warning] Invalid file link:(~/docs-conceptual/sharepoint-server%5Csharepoint-server-cmdlets.md).
Line 11: [Warning] Invalid file link:(~/docs-conceptual/sharepoint-online%5Csharepoint-online-cmdlets.md).
Line 13: [Warning] Invalid file link:(~/docs-conceptual/sharepoint-pnp%5Csharepoint-pnp-cmdlets.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 04c1e67:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/policy-and-compliance-retention/New-ComplianceTag.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 6890c5e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/policy-and-compliance-retention/New-ComplianceTag.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: rendezvous client

Adds rendezvous client
Needs:

[ ] https://github.com/libp2p/js-libp2p-rendezvous/pull/6

Any update on this? I'd like to use it for one of my projects, should I just install the branch?

Closing due to staleness


doc: Don't vendor a copy of DCO, as it is under another license.

Hi.  I'm packaging cue for Debian which are careful about licenses practices.  I noticed that CONTRIBUTING.md includes a vendored copy of a file that is not under your project license, and the license of this text doesn't even allow modifications so it cannot be included into Debian.  Would you consider dropping the copy of the DCO and merely reference it?
Thanks,
Simon

Thanks for pointing this out! LGTM. Will merge in Gerrit as part of our usual process.

Thanks for the patch. Out of curiosity, does this not affect a number of other OSS projects that you might want to package too, or even might already be packaging?

https://gitlab.freedesktop.org/wayland/weston/-/blob/master/DCO-1.1.txt
https://kernel.googlesource.com/pub/scm/utils/kernel/virtme/virtme/+/refs/heads/master/DCO-1.1.txt
https://github.com/gnuradio/gnuradio/blob/main/DCO.txt

If those are OK because they are in their own separate file which Debian can exclude from packaging, perhaps we could consider that too, given that we can't reliably link to version 1.1 of the text - https://developercertificate.org/ is simply the latest version of the license.

You are right -- this seems to be a common problem, and I brought it up on the Debian legal list: https://lists.debian.org/debian-legal/2024/11/msg00005.html
Many packages include different variations of this text, but as far as I can tell, they all look complicated from a FOSS and legal perspective.  So I would appreciate if the non-free text was removed from this repository, but I also understand your situation that there is no good canonical way to link to the version 1.1 DCO text.  I wonder if you really need that, though?  Many projects like git and the linux kernel simply says DCO and refer to https://developercertificate.org/ (I have no idea who runs that website).


context.default-region is no longer supported. But docs still states it is a possible option.

I'm getting this error
The 'context.default-region' key was found in /Users/seanyu/Zap/test-cdk-static/cdk.json, but it is no longer supported. Please remove it.

when i  run cdk deploy when my cdk.json have default-region
{
  "app": "node dist/cdk/index",
  "context": {
    "default-region": "ap-southeast-1",
  }
}

but it states in the docs https://docs.aws.amazon.com/CDK/latest/userguide/awscdk.pdf Environment and Aunthentication section that it still supports it.

cc @Doug-AWS

is there an alternative to having a "default" region aside from writing it directly in code?

No. We recommend you specify your region directly in the code. If you want to deploy the same stack to multiple regions, instantiate all of them and give each of them a different region.

Got it! @rix0rrr

What about default-account? Does that go away also?

Should I just delete:
Otherwise, read default-account and default-region from the application's context. These can be set in the AWS CDK Toolkit in either the local cdk.json file or the global version in $HOME/.cdk on Linux or MacOS or %USERPROFILE%\.cdk on Windows.

Yes, please.

Done. The change will be visible when I rebuild the docs. I'll post a link to the new docs when I'm done.

Thanks @Doug-AWS !

Both the online and PDF versions no longer include that passage.


Find-and-replace example doesn't handle explicit port number.

The Conference API is returning two forms of the URL, one with the port and one without.  The find-and-replace example doesn't work correctly when a port number is present, and returns an invalid URL:
"href": "https://conferenceapi.azurewebsites.net:443/speakers",
"href": "https://conferenceapi.azurewebsites.net/speaker/1",
become:
"href": "https://apiphany.azure-api.net/conference:443/speakers",
"href": "https://apiphany.azure-api.net/conference/speaker/1",
As you can see the port number is now after the conference prefix:
"href": "https://apiphany.azure-api.net/conference:443/speakers",
I don't think this is the desired behaviour as it is leaking port information for the original API.  (This also happens with the <redirect-content-urls /> policy.)
A potential workaround for the tutorial would be to handle both cases:
<find-and-replace from="://conferenceapi.azurewebsites.net:443" to="://apiphany.azure-api.net/conference" />
<find-and-replace from="://conferenceapi.azurewebsites.net" to="://apiphany.azure-api.net/conference" />

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f650a0b5-a147-ff23-533e-5a5481b3f02e
Version Independent ID: 5271aa75-8a47-62fd-1e35-d0a23c58a6e2
Content: Transform and protect your API with Azure API Management
Content Source: articles/api-management/transform-api.md
Service: api-management
GitHub Login: @vladvino
Microsoft Alias: apimpm

@tonymitchell Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

This item was addressed in PR #67862. #please-close

Today I encountered the same problem. What does PR #67862 refer to?
I get the same result as described in the tutorial, so in that sense the tutorial is correct. The problem is that, after the transformation by redirect-content-urls, the collection.href field in the response contains an invalid URL. A hypothetical user of this API probably would not be happy with that.

I eventually used this policy to get the output I wanted.
<outbound>         <set-header name="X-Powered-By" exists-action="delete" />         <set-header name="X-AspNet-Version" exists-action="delete" />         <find-and-replace from="@("://" + context.Api.ServiceUrl.Host + ":443" + context.Api.ServiceUrl.Path)" to="@("://" + context.Request.Headers["Host"][0] + context.Api.Path + "/")" />         <redirect-content-urls />         <base />     </outbound>


Added a StoryRowV2 to start redesigning the Story Row

Added a StoryRowV2 to start redesigning the Story Row
In the process of replacing the old story row

#239  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Fails to create certs if user/owner of files has been changed outside of Plesk

We have a slightly odd way of setting up domains/hosting accounts in Plesk that we think is affecting LetsEncrypt from doing its thing.
E.G. We have a 'deployer' user that is used to deploy to hosting accounts we setup in Plesk. Our process is...Set up a domain / hosting package in Plesk, create a user/password etc, then we change default hosting settings to meet our requirements around deployments (e.g. changing the document root from httpdocs to httpdocs/current/build), then we change the owner of everything under /httpdocs to be a generic 'deployer' user set up outside of Plesk.
We assume this means that the LetsEncrypt process cannot create the .well-known dir it needs in order to run further processes as it runs as the user that the hosting account was setup with initially, which can no longer write to the document root as it is owned by the 'deployer' user.
Any ideas how we might be able to work around this?
Thanks,
Ceri

Try to create '.well-known/acme-challenge' directory in doc root of every site you plan to secure by LetsEncrypt. Add write permissions to the diretory for subscription owner's system user. In this case the LE extension will put challenge token files in the directory and won't try to remove the directory after challenge is passed.
Perhaps, custom '.well-known/acme-challenge/.htaccess' (or '.well-known/acme-challenge/web.config' for Windows/IIS) file is required for your special configuration.

Thanks for the ideas - but still failing to issue. We also change the doc root in hosting settings (httpdocs/current/build), do you think this may also be a factor?

Yes, this definitely is root cause. The LetsEncrypt extension place challenge token files in /var/www/vhosts//.well-known/acme-challenge/ directory (C:\inetpub\vhosts<domain>.well-known\acme-challenge\ on Windows) and assumes the token files are accessible by http:///.well-known/acme-challenge/. In your custom vhost configuration the token files are not available.
Please, try to configure your domain vhost to serve /.well-known/acme-challenge/* URL from /var/www/vhosts//.well-known/acme-challenge/ directory. Perhaps symlink ${vhost}/httpdocs/current/build/.well-known/acme-challenge/ -> ${vhost}/.well-known/acme-challenge/ will suite your needs.

Thanks again for the ideas. Unfortunately still not working for us, but getting some feedback in the form of errors now:
Error: Permission denied
Error: Let's Encrypt SSL certificate installation failed:
filemng failed: filemng: Error occurred during /bin/mkdir command.


ci: add custom lint for spirv-std building with -Z minimal-versions.

This tries to prevent issues like:

#1053

Note that the separation into commits is to aid review, and also I'm going to open this PR without the fix for the failure, so that I can demonstrate CI failing with the new check.

CI fails as expected, will push fix commit now.


TabNet. Unable to reproduce the 99% accuracy on Poker Hand dataset.

We're trying to reproduce the results from a TabNet paper. There is a remarkable 99% accuracy on Poker Hand dataset. We can't reproduce the result, we've got only 54%. Can you share the code, so we can check what's wrong with our setup?

To add to this, we understand that there’s a lot of hyperparameter tuning to be done. We also tried following both the ones suggested in the paper and our own hyper parameter search which only achieved ~62% accuracy.

https://github.com/fmobrj/pokerhand_tabular/blob/master/poker_hand_induction_fastai_x_tabnet_final.ipynb

Hi there.
I figure this problem was resolved? Could you briefly explain if there was a bug in the PyTorch implementation of the code...? I'd be interested in using the PyTorch model and want to be sure that there's no implementation bug. Thanks

The issue was how the data was being prepared. Everything was treated as categorical (the notebook above shows).

Thanks @muellerzr ! Will jump right in...
And thanks for your work and contributions in the fast.ai community. Any intuition why the fast.ai models beats? Not that I am complaining ;-)

We’re looking into it but a study wasn’t really ever done to compare how fastai does on baselines (doing so now) and so plenty to be discovered :)

@cwerner we released a bugfix yesterday on pytorch-tabnet, so everything should be working fine now!

@Optimox great - thanks for the heads-up


OSCI: Onboard UI e2e

Description
WIP
Checklist

[ ] Investigated and inspected CI test results

Testing Performed
CI is sufficient

/test gke-qa-e2e-tests


Package for pip install

Being able to "pip install openfoodfacts-apirestpython" would be cool :-)

Is it open? I would like to work on it.

go ahead :)

poke @itchix

We also have a wrapper for the live API
https://github.com/openfoodfacts/openfoodfacts-python

In openfoodfacts/openfoodfacts-python#41 @teolemon told there is already a Pypi account, so it will be a good idea to upload this package too, if the main developers consider appropriated to use the Open Food Facts official account in Pypi.


Provide support for CRD upgrades natively in zarf

Is your feature request related to a problem? Please describe.
Today zarf's posture for CRD upgrades is identical to helm's - https://docs.zarf.dev/ref/deploy/#handling-customresourcedefinitions-crds. While this does make sense given zarf is using helm under the hood it means that the end user is left to figure out how to upgrade CRDs on their own. Typically this means either the chart needs to handle upgrades (I've seen this done with k8s jobs that apply the CRD manifests) or it has to be handled via the zarf package. Handling via the zarf package is certainly possible, but not ideal (I think it would have to be done with files + actions, since even manifests get wrapped in a helm chart and would rely on helm's behavior).
Describe the solution you'd like
I would like zarf to provide config options for CRDs per chart. By default this would align with the upstream helm default behavior (install only, don't touch upgrades), but could be configured based on package needs. This could mean something like a new field in the helm chart component spec to specify whether to do CRD upgrades or not:
components:
  - name: my-chart
    charts:
      - name: my-chart
        url: https://mychart.com
        version: 2.0.0
        namespace: myns
        crdUpgrade: true

When this field is set Zarf would handle CRD upgrades itself (this would have to be done via k8s api/sdk directly rather than helm given the helm posture on CRDs).
Describe alternatives you've considered
Continue down the current path, shifting the CRD upgrade responsibility to the end user to handle either via the helm chart or some zarf package changes. Perhaps to ease the burden on end users and example package could be provided to show how CRD upgrades would be expected to take place.
Additional context
Another project in a similar space of "managing helm installs" is Flux - they have build a similar spec around their HelmRelease which allows for configuring CRD upgrades. I'm not sure if their project/code would be a useful place to look for inspiration on how to approach this problem differently.
I do think CRD upgrades are likely to be a common problem/need in the future - many upstream charts leave this to the end user as a manual upgrade (ex: kube-prom-stack). It would be great if zarf could provide something to lessen this burden.

@phillebaba yeah I think that would be a great path to go down. One thing I was always curious on was the decision to only "manage" CRDs if they are in the crd directory. In my experience with a number of the opensource charts we use for uds-core there's definitely a handful of charts that use templates for CRDs instead. I wonder if it would possible/reasonable to use the kind only (and not consider directory) to determine what is a CRD we want to manage?

Here is a user example that does not involve the Helm crd directory.
kind: ZarfPackageConfig
metadata:
  name: knative
  description: Deploys Knative using Manifest files
  version: 0.0.1
  authors: Justin Bailey
  documentation: https://knative.dev/docs/install/yaml-install/serving/install-serving-with-yaml/
  source: https://github.com/knative/serving

components:
  - name: knative-serving
    required: true
    description: "Knative Serving"
    manifests:
      - name: knative-crds
        files:
          - https://github.com/knative/serving/releases/download/knative-v1.14.1/serving-crds.yaml
      - name: knative-serving
        namespace: knative-serving
        kustomizations:
          - manifests/
    images:
      - gcr.io/knative-releases/knative.dev/serving/cmd/activator:v1.14.1
      - gcr.io/knative-releases/knative.dev/serving/cmd/autoscaler:v1.14.1
      - gcr.io/knative-releases/knative.dev/serving/cmd/controller:v1.14.1
      - gcr.io/knative-releases/knative.dev/serving/cmd/queue:v1.14.1
      - gcr.io/knative-releases/knative.dev/serving/cmd/webhook:v1.14.1
      - gcr.io/knative-releases/knative.dev/net-kourier/cmd/kourier:v1.14.0
      - docker.io/envoyproxy/envoy:v1.26-latest

I also think it would be very meaningful if Zarf could support this feature.
If there isn't a good solution for now, could we consider having a dedicated document on Zarf CRDs upgrades to provide some suggestions or alternatives?

I did some digging and reading today and believe my initial understanding of Helm and CRDs was a bit flawed. It seems like "helm does not upgrade CRDs" only applies if using the special crds folder within a chart. Based on what I'm seeing. CRDs are actually upgraded as expected when they are in the templates folder. Depending on how a chart is architected, CRD upgrades may actually be possible with Zarf (for example I've successfully upgraded CRDs on the Istio base chart which uses the templates folder).
This still does not account for CRDs in the crds folder but I think this could still solve a number of scenarios. I'm unsure on the behavior if CRDs are included as zarf manifests. May be worth a doc update to explain this assuming my findings are correct here.
A few upstream helm code links that seem to backup that the special "skip upgrade" logic only applies to resources in the crds folder:

https://github.com/helm/helm/blob/main/pkg/chart/chart.go#L154
https://github.com/helm/helm/blob/a933bcc7d13733a2bef60a184c13fe3ed6703fb5/pkg/action/install.go#L264
https://github.com/helm/helm/blob/a933bcc7d13733a2bef60a184c13fe3ed6703fb5/pkg/action/install.go#L171


📚 config_group API to take a propler list of host_names

Small glitch in the documentation of config_group API, should be a proper list of host_name. Also API call returns 200, not 202.

Closing PR as its over a year old.


Setting or changing locale data per instance

I need to change the first day of week according to user profile; currently I could register my own locales or change already loaded locales but in the moment class!, I need to change only some aspects of the locale data per moment instance, not sharing the locales. I couldn't even create a new locale base on the current one because I see no way of getting the locale data in a valid format so I could change de "dow".
And no way I think on doing it programatically with startOfWeek or so.
What I wish is something like:
var date = moment().locale('en');
date.locale({ week: { dow: 1 }}); //Only for this instance override/merge current localeData with this one
console.log(data.locale()); //en
console.log(data.localeData().firstDayOfWeek()); //1

//This instance will use the plain globally loaded english locale
date = moment().locale('en');
console.log(data.locale()); //en
console.log(data.localeData().firstDayOfWeek()); //0

You can define a new locale based on the current one like this:
moment.locale('en-custom', moment.localeData('en'));

Then just customize the new locale as desired and use it.

This turns unscalable when customizing locales per user, where each have their own detailed customizations.

I'm not sure why.  You can do the customization on-the-fly, per user. It doesn't have to be done globally ahead of time.


tmux_prefix_highlight pushes right-aligned statusbar items

Hi, awesome theme (along with the compatibility with a bunch of programs)!
When I activate the prefix highlight, all the other right aligned statusbar items are pushed to the right 3 characters. With the copy highlight, the other items are moved 1 character.
This is all with the non-patched version.

My fix to at least avoid any shift with the prefix, was to add this line to my tmux config:
set -g @prefix_highlight_empty_prompt '    '

On my machine this was caused by a long hostname, so a more sensible solution is actually to increase the right status bar similar to the proposed https://github.com/arcticicestudio/nord-tmux/pull/27/files .


[TypeResolution] Ban local variable packs

This change bans local variable packs as they are not supported.

Undo #61755.
Add a check for the case where this type is inferred.

@swift-ci please smoke test


Detection doesnt work properly

I have a url thats redirected to postman pages , CNAME points to postman but your tool detects it as AWS bucket vulnerable.
I have also checked DNS and page source manually , there no AWS bucket text or hosts anywhere.

Hello @kleozzy,
Thank you for your message. I have reviewed the code, and it appears to be functioning correctly. Could you please provide your URL so we can investigate further?

Sure try with : postman.backblaze.com

Seems to work fine

Thats not aws bucket

share exact  console output if you don't mind

Takeit based on can-i-take-over-xyz. It identifies URLs as vulnerable if they contain specific fingerprints associated with takeover risks. In your case, the URL includes the message "The specified bucket does not exist: NonExistentBucket" which matches one of these fingerprints. This is why my tool flagged it as potentially vulnerable. I will soon be adding the capability to match CNAME records from can-i-take-over-xyz as well.

Also you can utilize the exclude pattern feature in the tool to avoid false positives, please refer to the "README" file in the repository. There are specific instructions and examples provided there to help you set it up effectively.

i see , the final page is a docs site and it indeed has this text , i guess it hard to filter those false positives out:

It's not too hard to fix, and I'll work on reducing the false positives.

That would be awesome.


Testing Commit Signature

This PR is to test signature for commits.
Pull reviewers stats
Stats for the last 30 days:

User
Total reviews
Time to review
Total comments

jeremy-page
24
36m
3

carlosfelix2
14
14h 15m
41

kevinhaube
13
9h 46m
19

cwinters-usds
10
36m
8

clediggins-usds
8
56m
3

bgantick
7
41m
1

TomNUSDS
7
1h 19m
18

brick-green-agile6
6
42m
0

oslynn
4
11h 24m
2

jorg3lopez
4
15h 47m
2

MauriceReeves-usds
4
3d 16h 14m
0

sethdarragile6
4
1h 47m
2

snesm
4
50m
6

mreifman
3
32m
1

TurkeyFried
2
27m
1

ahay-agile6
2
5h 15m
1

jbiskie
2
33m
0

JosiahSiegel
1
3m
0

RickHawesUSDS
1
6m
2

jh765
1
32m
2

closing, commits have signature and are verified.


Cannot move the players

I cannot have interaction with the player , Pls help me thank!

Please tell how to make an interaction with the chess game

This API is not implemented yet (the delegate). Presently only viewing the board is implemented.


Optimizer: enable the DeinitDevirtualizer pass

It was disabled so far to not hide bugs in the deinit code generation. Now hopefully deinit code generation is stable enough to enable the pass.
Also fix a bug which showed up after enabling the pass: don't convert non-copyable owned -> guaranteed arguments in FunctionSignatureOpts:
It's not safe to insert a compensating release_value at the call site.
This release_value calls the deinit which might have been already de-virtualized in the callee.

@swift-ci test

@swift-ci benchmark

@swift-ci test

@swift-ci benchmark


Add Bezier Script

Adds a new random LFO that uses cubic Bezier curves to generate voltages & gates. Heavily inspired by the ADDAC507.  Creates two independent random LFOs (A & B), each with an adjustable frequency and curve constant.  Each LFO picks a random voltage (0-10V by default), and approaches the desired voltage following a cubic bezier curve.
Dependency Note
Uses the new FloatConfigPoint implementation from https://github.com/Allen-Synthesis/EuroPi/pull/370. That change should be reviewed & merged before addressing Bezier. Marking this MR as a draft until that's ready to go.
Firmware Bugfix
Renames experimental.math to experimental.math_extras to prevent possible bugs with other experimental scripts that need to use the default math namespace.
An older revision of Bezier used the new experimental.math_extras.rescale(...) function, but that's no longer used. However, this presented the opportunity for a very small elimination of some duplicate code in Lutra and ParticlePhysics, which have been kept in this MR rather than reverted.

Rebased to latest main after #370 was merged. Should be ready for review now.


HSEARCH-2561 Allow sorting metadata to be overriden during query execution

This PR is based on #1299 (HSEARCH-2570), which we'll have to merge first. => Merged!
Relevant JIRA ticket: https://hibernate.atlassian.net/browse/HSEARCH-2561

@anistor this is looking good to me. Do you want to try it out on Infinispan to see how it works in practice?

I'm trying it out now. Might now have results until later today (as we have long planning meeting today).

@anistor Any news on this?

Doesn't seem very dangerous; I'll merge it, so we can keep working with minimal conflicts. @anistor will be able to open bugs as needed.


fix: short mode route unmatched

https://github.com/radix-vue/radix-vue/pull/933
https://github.com/pmndrs/valtio/pull/898

This has the same issue as #32


feat(addon-table): TextArea add support for interactive tables

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows Conventional Commits
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring
[ ] Code style update
[ ] Build or CI related changes
[ ] Documentation content changes

What is the current behavior?
Closes #546
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[ ] No

I got a concern that a cell with a checkbox in it would be considered editable and lose vertical centring. Probably not that big a deal to add it manually, but maybe it's possible to solve this under the hood 🤔


Fixing Service_Unavailble

I had Service_Unavailble error on the first run but after I increase timeout and delay I can run it successfully. So you might want to update Readme.md with this information.
./byfn.sh up -t 30 -d 10

Thanks @methuz ! I will updated it very soon!

Updated :+1: and thanks again:)

hello I am still getting the same error
Error: got unexpected status: SERVICE_UNAVAILABLE -- will not enqueue, consenter for this channel hasn't started yet !!!!!!!!!!!!!!! Channel creation failed !!!!!!!!!!!!!!!! ========= ERROR !!! FAILED to execute End-2-End Scenario ===========

@sngvahmed you might want to increase more delay

@keenkit you're welcome

@methuz
I run ./byfn.sh up -t 30 -d 1000 and I am still getting the same error in ubuntu server and also in VirtualBox ubuntu server

@sngvahmed , can you check the logs from kafka / zookeeper or orderer to see if any obvious error?

@keenkit  it work with me now thanks

@sngvahmed what did you do to get it working can you please let us know. thanks

i met this question,this the orderer logs:
2018-12-03 13:49:26.710 UTC [orderer/consensus/kafka/sarama] Open -> DEBU 27b ClientID is the default of 'sarama', you should consider setting it to something application-specific. 2018-12-03 13:49:26.710 UTC [orderer/consensus/kafka/sarama] func1 -> DEBU 27c client/metadata fetching metadata for all topics from broker kafka0.example.com:9092 2018-12-03 13:49:26.711 UTC [orderer/consensus/kafka/sarama] withRecover -> DEBU 27d Failed to connect to broker kafka0.example.com:9092: dial tcp <IP_ADDRESS>:9092: connect: connection refused 2018-12-03 13:49:26.711 UTC [orderer/consensus/kafka/sarama] func1 -> DEBU 27e client/metadata got error from broker while fetching metadata: dial tcp <IP_ADDRESS>:9092: connect: connection refused 2018-12-03 13:49:26.711 UTC [orderer/consensus/kafka/sarama] func1 -> DEBU 27f client/metadata no available broker to send metadata request to 2018-12-03 13:49:26.711 UTC [orderer/consensus/kafka/sarama] tryRefreshMetadata -> DEBU 280 client/brokers resurrecting 4 dead seed brokers 2018-12-03 13:49:26.713 UTC [orderer/consensus/kafka/sarama] tryRefreshMetadata -> DEBU 281 client/metadata retrying after 250ms... (2 attempts remaining) 2018-12-03 13:49:26.965 UTC [orderer/consensus/kafka/sarama] Open -> DEBU 282 ClientID is the default of 'sarama', you should consider setting it to something application-specific. 2018-12-03 13:49:26.965 UTC [orderer/consensus/kafka/sarama] func1 -> DEBU 283 client/metadata fetching metadata for all topics from broker kafka2.example.com:9092 2018-12-03 13:49:26.966 UTC [orderer/consensus/kafka/sarama] withRecover -> DEBU 284 Failed to connect to broker kafka2.example.com:9092: dial tcp <IP_ADDRESS>:9092: connect: connection refused 2018-12-03 13:49:26.966 UTC [orderer/consensus/kafka/sarama] func1 -> DEBU 285 client/metadata got error from broker while fetching metadata: dial tcp <IP_ADDRESS>:9092: connect: connection refused 2018-12-03 13:49:26.967 UTC [orderer/consensus/kafka/sarama] Open -> DEBU 286 ClientID is the default of 'sarama', you should consider setting it to something application-specific.
at the same time ,i noticed that errors:
2018-12-03 13:49:33.598 UTC [orderer/common/broadcast] Handle -> WARN 4a4 [channel: mychannel] Rejecting broadcast of message from <IP_ADDRESS>:35802 with SERVICE_UNAVAILABLE: rejected by Consenter: will not enqueue, consenter for this channel hasn't started yet 2018-12-03 13:49:33.598 UTC [orderer/common/server] func1 -> DEBU 4a5 Closing Broadcast stream 2018-12-03 13:49:33.612 UTC [common/deliver] Handle -> WARN 4a6 Error reading from <IP_ADDRESS>:35800: rpc error: code = Canceled desc = context canceled
should i do ?


Transparent favicon doesnt work

Transparent favicon doesn't show up AT ALL on chrome & just can't get it to work

Figured it out: use a transparent .ico and don't put any type attribute on the <link>


MAINT: fix deprecation warnings

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 91.671%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
178243

Relevant Lines:
194438

💛  - Coveralls


Conformance statement results are hard to debug

When I test https://portal.demo.syncfor.science/api/fhir I get

https://portal.demo.syncfor.science/api/fhir/metadata includes
      "security": {
        "extension": [
          {
            "extension": [
              {
                "url": "authorize",
                "valueUri": "https://portal.demo.syncfor.science/oauth/authorize"
              },
              {
                "url": "manage",
                "valueUri": "https://portal.demo.syncfor.science/apps"
              },
              {
                "url": "token",
                "valueUri": "https://portal.demo.syncfor.science/oauth/token"
              },
              {
                "url": "register",
                "valueUri": "https://portal.demo.syncfor.science/oauth/register"
              }
            ],
            "url": "http://fhir-registry.smarthealthit.org/StructureDefinition/oauth-uris"
          }
        ]
      }

... which I think should be valid. Clicking on the "Details: No authorize URI provided in conformance statement." error line turns the screen grey but does not convey additional information about what went wrong.

Thanks for the report @jmandel.  Is the 'gray screen' issue on the public hosted instance of this on SITE or a copy you are running locally?  If it is on the public instance, this was fixed in https://github.com/siteadmin/inferno-site-overlay/pull/4, but hasn't yet been deployed.
I believe the test is failing because the conformance statement does not explicitly declare SMART-on-FHIR as a supported security service in Conformance.rest.security.service.  Documentation in smart app launch seems vague about whether or not it is required, but the example included that field.
We ended up making it required, since it is a reasonable assumption from a client dev perspective (and an assumption we made when making our client).  What are your thoughts on this?
At the very least, this error message should be more explicit (missing security service, not missing oauth uri).

Thanks @arscan! I think ideally we'd make this required, but our docs don't say this today, and I'd rather not break compatibility over this. We should review what existing Argonaut vendors do here, for example. If there's consistent support, we can bring this up as we're finalizing ballot reconciliation of the SMART spec through HL7.

(Oh, and this is on the public site -- thanks.)

I would strongly prefer it to be required... after all, it caused a "bug" in our client (that misleading error message).  I assume others will make the same mistake, especially if it is in the reference example.  And even if it is removed from the reference example, it will still exist in the restful-security-service value set.
I believe that most argo vendors already use it, though I can't say with certainty at the moment.  Even if they don't, this seems like it should be an easy change (famous last words).
The only other time I recall seeing this missing is in the Blue Button 2.0 API.  But they aren't argo, and it doesn't claim SMART-on-FHIR conformance in their documentation either (though it does quack like a SoF enabled API).

Thanks for this. The BB 2.0 API aims to follow the SMART on FHIR guide, so it's worth including this in the roundup/assessment.
In any case, I too would prefer if it was required.

This should be decided when finalizing the ballot reconciliation of the SMART spec through HL7.  Meanwhile, let's adjust the Inferno test tool to return a message that says "Missing security service in conformance statement" when the URI is present but it does not explicitly declare SMART-on-FHIR as a supported security service in Conformance.rest.security.service.

I wanted to point out that https://portal.demo.syncfor.science/api/fhir/metadata is now including this information.
...
"service": [
{
"coding": [
{
"code": "SMART-on-FHIR",
"system": "http://hl7.org/fhir/restful-security-service"
}
],
"text": "OAuth2 using SMART-on-FHIR profile (see http://docs.smarthealthit.org)"
}
]
....


Add Afrikaans (af-za) as a language

This is as good as it gets.

Thanks! :)
This change has been applied manually to also include the necessary GUI changes for the added translations.


Ubuntu version changed from 16.04 to 19.04

Read the contribution guidelines
Include a reference to a related issue in this repository
A description of the changes proposed in the pull request

branch looks good.


blank virtualmin list

It works perfectly on a lot of server .. but in one server I cannot use it because virtualmin tab was empty.
I think problem is russian character .. I have a russian domani..
could you help me to solve this problem?

Yes, just update Webmin to the latest.

I have already installed webmin 1.770

Then VM?

This is the reason why it happed in past. What are your Virtualmin and the Theme versions?

I update also virtualmin and now it works correctly thank you!!!!

 ;)


ci: publish amd and arm images

Updates Dockerfile with optimizations and steps to compile Tesseract (compilation required for arm)
Updates docker-publish GHA workflow to build and test both amd and arm images
Updates docker smoke test to enable skipping inference tests (they hang with emulated architecture)
Updates timeout on docker smoke test (it can take 30s-1m to reach healthy)

Testing
Tested on m1 (for the arm container) and dev instance (for the amd container). The test build comes from this commit and run (since the current version will only trigger on pushes to main).
docker pull quay.io/unstructured-io/unstructured-api-multiarch:3bdc5d6
IMAGE_NAME=quay.io/unstructured-io/unstructured-api-multiarch:3bdc5d6 make docker-test

LGTM! Test instructions work great. Interesting to see it takes about twice as long on m1 than intel with 8 cpu's:
12 passed, 2 xfailed in 134.84s (0:02:14)

vs
12 passed, 2 xfailed in 61.36s (0:01:01)

Thanks! Woah, interesting data point! That is a not-insignificant difference.


Missing types in Release

Hello.
We are facing with one strange behavior when generating GitHub Release. In Release we can see only features and bug fixes, but such types like ci, chore, build is not generated/present in Changelog and Release.
GitHub action workflow:
name: Releases
on:
  push:
    branches:
      - main

jobs:
  changelog:
    runs-on: ubuntu-latest
    permissions:
      contents: write
    steps:
      - uses: actions/checkout@v4

      - name: Conventional Changelog Action
        id: changelog
        uses: TriPSs/conventional-changelog-action@v5
        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}

      - name: Create release Action
        uses: actions/create-release@v1
        if: ${{ steps.changelog.outputs.skipped == 'false' }}
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          tag_name: ${{ steps.changelog.outputs.tag }}
          release_name: ${{ steps.changelog.outputs.tag }}
          body: ${{ steps.changelog.outputs.clean_changelog }}

Git log:
4c97fbc (tag: v1.2.0) chore(release): v1.2.0 [skip ci]
54069ef Merge pull request #20 from rgb000/feature/ip
83deb8c feat(ip): updated module outputs
b18eb82 feat: add ip module
97f3843 Merge pull request #19 from rgb000/feature/ci-update
5ed7a2e chore: updated pre-commit hooks
f3a70df chore: updated .gitignore

GitHub Release:

This is because the default preset is 'angular' and that one does not contain those.

But there is ci type is in angular preset https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#-commit-message-guidelines

Also I've tested rest of the types:
a28945b (HEAD -> main, tag: v1.5.0, origin/main, origin/HEAD) chore(release): v1.5.0 [skip ci]
f948072 Merge pull request #26 from rgb000/feature/test2
095e1b1 (origin/feature/test2, feature/test2) feat: message1
7a8a200 refactor: message1
470673a perf: message1
4f52413 docs: message1
5315945 build: message1
3e6cfbf Merge pull request #25 from rgb000/feature/test2
9cced26 ci: changed something
b285bd7 (tag: v1.4.0) chore(release): v1.4.0 [skip ci]

And from all of the above in Release I got only:

Yes the type exists but they don't add it to the changelog, checkout the conventional commit one (search existing issues) I think that one does add them.
Otherwise it's an option to configure a custom config.

See https://github.com/TriPSs/conventional-changelog-action/issues/217 for example.

Yes, thanks. I found this information here - https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-changelog-angular
Could you please clarify how can I get common types (build, docs, perf, refactor, ci) in Changelog in this case ?

By changing the preset to one that has it or using a custom config.
I'm on my phone so can't link/check, see issue that I referenced, I think that preset does it.

I got the same results with mentioned preset ("conventionalcommits"). Please advice when you will be near PC

Search for other preset that supports it, see also #223 or use a custom config.

Hi.
I tried most of different presets and even custom config described here and didn't make it work as expected... As I saw in #254 issue conversation - we didn't get working config example as well....

Please make a ticket at conventional commit library itself, that is what we use here, all of this is not related to this action.


enforce 2.4.0 failures

since its green, we should probably keep it green.

Although given the apparent speed of 2.4 we might not want to do this right now

( https://bugs.ruby-lang.org/issues/13113 - fix is on HEAD and should be in 2.4.1 )


Minor refactoring and robust mode check for imagenet_utils.py

Minor refactoring of code for better readability of conditional statements (using elif instead of multiple ifs if the statements check for conditions on the same object). Also added robust mode argument check to prevent silent failure.

@jaketae Can you please check build failures. Thanks!

@gbaned Thank you for the friendly reminder. I realized that one of the files had a missing argument required for docstring formatting. I've pushed a new commit, so hopefully it goes through.

@jaketae Could you please resolve the conflicts? Thanks!


style: remove dbg() in favor of dump() from @core

Pull Request Test Coverage Report for Build 120
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.552%

Totals

Change from base Build 117:
0.0%

Covered Lines:
1415

Relevant Lines:
1898

💛  - Coveralls


Change KittyCAD Mouse Controls to Zoo Mouse Controls

Description
Change KittyCAD Mouse Controls to Zoo Mouse Controls
Version
v0.29.0
Recordings/Screenshots

cc @JBEmbedded

Shifting off this. This has a lot more hold that I was expecting. Leaving for someone else to pick up.


Javascript event queue slows/ceases to function while Phaser is running

A bug in the API

The issue that made me aware of this:
http://stackoverflow.com/questions/39461135/socket-io-client-does-not-emit-based-on-available-memory-cpu-in-tab
setInterval and setTimeout literally slow to a crawl when the game dips below 50 FPS i.e. when Phaser is using a lot of memory/cpu of the tab. Is this intentional? It causes socket.io to cease to work (as socket.io depends on the event queue as do many other js applications).  This seems to be  major issue to me because what is javascript without the event queue? Mind you, this isn't when the tab is at a halt because of a lack of cpu/memory, this is when the tab is under a moderate load ( a by-product of that is a drop in FPS).

New evidence has come to light.
It seems the event queue works just fine under normal circumstances (regardless of the memory/cpu load Phaser is taking up), except when I execute this function at the beginning of my game:
function createFogOfWar() {
var bmd = game.make.bitmapData(game.camera.width, game.camera.height);

bmd.fill(0, 0, 0);

var img = game.add.image(0, 0, bmd);
img.alpha = fogOfWarAlpha;
fogOfWar.img = img;
fogOfWar.addChild(img);
fogOfWar.bmd = bmd;

img.fixedToCamera = true;

}
Yup, that one function (and not the function which updates the fog of war) causes the event queue to break when the tab is under moderate cpu/memory stress. It doesn't seem to be a memory/cpu issue as the event queue works just fine when the game is under an extremely heavy load (i.e. down to 20 FPS).
This bmd isn't even that big (it's the camera size, which is the window size). So I can't imagine what is happening here.

Input events, timers and RAF are blocking events. If you do something expensive in them, they literally freeze the single thread that JS runs in. You (personally) may not consider that function expensive, but at the time it's being called, the browser does.
Lots of essential info here<EMAIL_ADDRESS>

But how is creating a bmd related to any of that?
(hope that questions doesn't sound like " .... but why male models??" to you).

Because it's a relatively expensive operation, especially for a window sized canvas. Think about what it does internally: Search the Canvas Pool for a free canvas, retrieve one (if it can, generate one if it can't: expensive), resize that canvas, clear out it pixel values, fills it, updates it, then goes into the part about creating a new Image, assigning it a texture etc.
It's not a huge amount on a Phaser level, but add onto that all of the memory management, GPU updates, and whatever else the browser does internally, and it takes up precious milliseconds. Call that at a point where the main thread is already blocked (i.e. from an event handler), and it just adds to the delay, before anything else can continue.
That article explains how the whole process flow is like driving down a one-way street.  What's more, you have no control over what the browser will do internally to mitigate this (i.e. throttling setTimeout perhaps). All you can do is ensure you only release fast cars onto the road.

Thanks, Richard, for the explanation. It makes so much more sense now :).
I think I will have a go at creating a web worker to run socket.io and communicate with the server. That way, nothing going on with the main thread will tie up network communications. If that fails, I will need to focus on making the cars faster, as you say.

I would suggest you try and create a bunch of bmd's up front (and the Images that use them), and have them ready in advance. Then you can unleash them as needed. I don't know how many you need, but caching just a few at the start would surely help removing creating them from what sounds like a hotspot bit of code.


Unable to compile Hello World on Mac OSX Sierra

Crystal 0.23.1 (2017-09-08) LLVM 4.0.1
{21:29}~/Learning/crystal ➭ crystal -v Crystal 0.23.1 (2017-09-08) LLVM 4.0.1 {21:29}~/Learning/crystal ➭ less hello.cr puts "Hello World"
compiling it produces this error
{21:28}~/Learning/crystal ➭ crystal hello.cr ld: library not found for -levent clang: error: linker command failed with exit code 1 (use -v to see invocation) Error: execution of command failed with code: 1: 'cc "${@}" -o '/Users/dayas/.cache/crystal/crystal-run-hello.tmp'  -rdynamic  -lpcre -lgc -lpthread /usr/local/Cellar/crystal-lang/0.23.1_1/src/ext/libcrystal.a -levent -liconv -ldl -L/usr/lib -L/usr/local/lib'
I have tried the XCode steps
{21:23}~/Learning/crystal ➭ sudo xcode-select --install Password: Sorry, try again. Password: xcode-select: error: command line tools are already installed, use "Software Update" to install updates {21:23}~/Learning/crystal ➭ sudo xcode-select --switch /Library/Developer/CommandLineTools
exact details are here https://gist.github.com/a193c36cbe66fa49b3899354b934fd99
what am I doing wrong?

The installation docs describe a situation here which might be related to your problem.

Are you referring to the Xcode steps? I already tried those but that doesn't help :(

@daya could you try otool -L $(which crystal) and brew info crystal-lang libevent?

@matiasgarciaisaia seems like some of the dependencies are missing
{9:30}~/Learning/crystal ➭ otool -L $(which crystal) /usr/local/bin/crystal: 	/usr/lib/libncurses.5.4.dylib (compatibility version 5.4.0, current version 5.4.0) 	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.8) 	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1238.50.2<EMAIL_ADDRESS>(compatibility version 1.0.0, current version 1.0.0) 	/usr/local/opt/pcre/lib/libpcre.1.dylib (compatibility version 4.0.0, current version 4.9.0) 	/usr/local/opt/bdw-gc/lib/libgc.1.dylib (compatibility version 2.0.0, current version 2.3.0) 	/usr/local/opt/libevent/lib/libevent-2.1.6.dylib (compatibility version 7.0.0, current version 7.2.0) 	/usr/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0) 	/usr/lib/libc++abi.dylib (compatibility version 1.0.0, current version 307.3.0)
here is the brew output that shows libatomic_ops ✘, automake ✘, doxygen ✘, libtool ✘ as missing. I am pretty sure automake missing is bad
https://gist.github.com/cbce788a2d4ce01165700bf10c53062b
{10:08}~/Learning/crystal ➭ brew info crystal-lang libevent
crystal-lang: stable 0.23.1 (bottled), HEAD
Fast and statically typed, compiled language with Ruby-like syntax
https://crystal-lang.org/
/usr/local/Cellar/crystal-lang/current (812 files, 45.7MB)
Poured from bottle on 2017-09-12 at 20:17:57
/usr/local/Cellar/crystal-lang/0.23.1_1 (812 files, 45.7MB) *
Poured from bottle on 2017-09-12 at 20:17:57
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/crystal-lang.rb
==> Dependencies
Build: pkg-config ✔, libatomic_ops ✘
Required: libevent ✔, bdw-gc ✔, llvm@4 ✔, pcre ✔, gmp ✔, libyaml ✔
==> Options
--without-release
Do not build the compiler in release mode
--without-shards
Do not include shards dependency manager
--HEAD
Install HEAD version
==> Caveats
Bash completion has been installed to:
/usr/local/etc/bash_completion.d
zsh completions have been installed to:
/usr/local/share/zsh/site-functions
libevent: stable 2.1.8 (bottled)
Asynchronous event library
http://libevent.org
Conflicts with:
pincaster (because both install event_rpcgen.py binaries)
/usr/local/Cellar/libevent/1.4.14b (20 files, 794.8KB)
Built from source
/usr/local/Cellar/libevent/2.0.17 (53 files, 1.8MB)
Built from source
/usr/local/Cellar/libevent/2.1.8 (847 files, 2.2MB)
Poured from bottle on 2017-09-12 at 20:15:17
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/libevent.rb
==> Dependencies
Build: autoconf ✔, automake ✘, doxygen ✘, libtool ✘, pkg-config ✔
Required: openssl ✔
{10:08}~/Learning/crystal ➭
Any pointers will be much appreciated.

From the first output it seems you are missing libevent. You can try brew install libevent. I don't know why would that happen, though...

@asterite Thanks for that pointer, I did have libevent installed but wasn't properly linked doing brew link --overwrite libevent fixed it
Thanks everyone for the help.

If anyone has the time, this is a great candidate to a self-replied StackOverflow question!


[STATISTICS-71]: Add base interfaces for all statistic implementations.

Codecov Report

Merging #46 (d41be79) into master (763ba71) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #46   +/-   ##
=========================================
  Coverage     99.82%   99.82%
  Complexity     1688     1688
=========================================
  Files            65       65
  Lines          4472     4472
  Branches        756      756
=========================================
  Hits           4464     4464
  Misses            4        4
  Partials          4        4

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Approved GH actions, will have a look at the code today, @ani5rudh . Thanks!

The pom does have a default goal that is used by the GH action. The only difference is the GH action includes the examples module as well. So to run all the same checks as GH just type mvn from the project root.
One other item to add is to document that the Min implementation returns the same order as that imposed by Math#min.

Hello @aherbert, thanks for the review. I've updated the PR per your comments.

I have fixed the build on master, please rebase.

@ani5rudh , why did you close this pull request and created a new one? I thought you would rebase, and perhaps squash it with Git. After that this could be merged and others would be able to find a pull request with the discussion and history of the change here. If you create separate pull requests it becomes much harder.

I tried to rebase onto apache:master but in the process, the commits were duplicated in this PR. I tried to remove those duplicate commits by resetting and force pushing. But, accidentally, all the commits were lost and this PR was closed automatically. Apologies for this mess up.
I was able to recover the commits by checking out to the last commit before all of this happened.  I force pushed the recovered commits to the branch on my forked repo and created a new PR.
Link to the new PR: https://github.com/apache/commons-statistics/pull/48

This branch is showing 0 commits now. You probably have to push what you have in the other branch to this pull request and maybe close the other PR (hovering the reopen pull request a message is displayed mentioning another PR).

The foundation branch requires more commits to reopen this PR


mdInput not working

Bug, feature request, or proposal:
Bug / mistake
What is the expected behavior?
Show material input field
What is the current behavior?
Buggy input: Blank white input field. The placeholder is displayed in the next line left-bounded. No material design elements. See Screenshots:

What are the steps to reproduce?

ng new webapp
npm install --save @angular/material
npm install --save @ang

ular/animations

npm install --save hammerjs

After that i importet the modules in app.module.ts
http://plnkr.co/edit/tcdmRCC46tmsiTuEGIEa?p=preview
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
"@angular/animations": "^4.2.5",
"@angular/common": "^4.0.0",
"@angular/compiler": "^4.0.0",
"@angular/core": "^4.0.0",
"@angular/forms": "^4.0.0",
"@angular/http": "^4.0.0",
"@angular/material": "^2.0.0-beta.7",
"@angular/platform-browser": "^4.0.0",
"@angular/platform-browser-dynamic": "^4.0.0",
"@angular/router": "^4.0.0",
"core-js": "^2.4.1",
"hammerjs": "^2.0.8",
"rxjs": "^5.1.0",
"zone.js": "^0.8.4"
Thank you

Did you import any theme? If not, try:
<link href="https://rawgit.com/angular/material2-builds/master/prebuilt-themes/indigo-pink.css" rel="stylesheet">
in you index.html.

Thanks a lot julianobrasil, worked for me. I imported the style in app.component.css with @import<EMAIL_ADDRESS>


Enhance problem_ids to be part of CLI

Move problem_ids report generation script to CLI

problem_id integrated as part of CLI. let me know if you find any bugs...when you are comfortable with it, delete the file get_csv_report_by_problem_id.py and use the CLI to generate reports for problem ids


Its possible?

Hello, thanks for this awesome tool.
However, I'm trying to implement it on a custom platform that I can't do it in the normal way.
I can't "create" div elements. Because there's already created. So I installed the dependencies, and I'm trying to init them adding the attribute on the elements after the page load.
AOS.init();
$(document).ready(function() {
document.getElementById("myImage").setAttribute("data-aos", "fade-up");
document.getElementById("myImage").setAttribute("data-aos-anchor-placement", "bottom-bottom");
});
When I open the page, I checked the console, no errors.
But the image is not showing up when scrolling, it's just invisible.
This is inspecting image:
https://puu.sh/ATwpZ/7ddcbe5016.png
Any idea?
Thanks.

I solved it using after loading that script used:
AOS.refreshHard();


iOS: Change background refresh to use BGAppRefreshTask

I'm still working on porting background fetch to BGAppRefreshTask but it's not behaving quite right.
2019-06-18 23:36:54.523814+0800 NetNewsWire[5127:695645] Starting simulated task: <BGAppRefreshTask: com.ranchero.NetNewsWire.FeedRefresh>
2019-06-18 23:36:54.525031+0800 NetNewsWire[5127:695645] [application] 👀 Woken to perform account refresh.
2019-06-18 23:36:54.528043+0800 NetNewsWire[5127:695655] [application] ✉ Getting unread count.
2019-06-18 23:36:54.529174+0800 NetNewsWire[5127:695655] [application] ✅ Got unread count: 11
2019-06-18 23:36:54.529728+0800 NetNewsWire[5127:695655] [application] 🔄 Starting refresh.
2019-06-18 23:36:55.550032+0800 NetNewsWire[5127:695655] [application] ⏰ Waiting for account refresh processing to complete...

Starting Refresh is the call to AccountManager.shared.refreshAll(errorHandler: ErrorHandler.log), but it's not actually doing anything.

Are you running AccountManager.shared.refreshAll on the main thread?  I'm pretty sure that you have to, especially for the local account.  If you are running it on the main thread, make sure you haven't blocked the main thread while waiting.

Pretty much everything is designed to be called on the main thread.

Yep, AccountManager.shared.refreshAll is running from main.

let refreshQueue = OperationQueue()
refreshQueue.qualityOfService = .background
refreshQueue.maxConcurrentOperationCount = 1

let refreshOperation = BlockOperation {

    // Get unread count

    OperationQueue.main.addOperation {
        AccountManager.shared.refreshAll(errorHandler: ErrorHandler.log)
    }

    // Wait for combinedRefreshProgress.isComplete == true.

    // Update unread count

}

refreshOperation.completionBlock = { task.setTaskCompleted(success: true) }

task.expirationHandler = {
    refreshQueue.cancelAllOperations()
    task.setTaskCompleted(success: false)
}

refreshQueue.addOperations([refreshOperation], waitUntilFinished: false)

@vincode-io @brentsimmons It appears that this issue only crops up when the refresh task is triggered from the debugger. It works fine when the device triggers the task.

Ah.  The perils of developing on Beta releases.


stripe.webhooks.constructEvent works fine on local but causes issues after deploying on vercel

Hi everyone,
It works fine on local when I test using stripe-cli but it causes error after deploying on vercel
I get Error validating Webhook Event

Hi Mr Byte,
Sorry you are having this issue, I have zero experience deploying on Vercel as I have only been using Netlify.  If you are still having this issue, could you provide a little more information.
Michael

It is working fine now. I guess the error raised as my Vercel account was free plan. Now I upgraded and it is working fine.


refactor(wikipedia): rewrite

Rewrites Wikipedia! Their new dark mode support means they finally switched to properly using vars, so this works!

As mentioned in Discord; this rewrite is pretty usable for the most part, and most of the unthemed stuff you'll find is due to whatever element not properly using vars. I'd expect them to continue fixing issues like that as the rollout progresses and I think we'll wait a bit before merging.

wait so the port was so unstable it had to be rewritten 2-3 times?

why does this port always gets rewritten?

This is noise, and it doesn't? It hasn't been rewritten a single time before this?

This is noise, and it doesn't? It hasn't been rewritten a single time before this?
oh wait i thought it was rewritten twice my bad

this is not colored btw

As I said:

most of the unthemed stuff you'll find is due to whatever element not properly using vars

I don't plan to theme stuff not using vars. I expect they will fix issues like that one in the future.

Oh I see!

Ended up theming the root and home pages that don't look like they are getting variables any time soon. Theme is usable, don't see any unthemed areas except for inline stuff. Should be good to go.


Add mail sink Kamelet

Looks good overall

@oscerd thanks fixed the kamelet sources. could you please approve the workflow run once more?

Done. Thanks.

@oscerd previous workflow run was hanging due to issue with YAKS versioning. Could you please approve once more 🙏
this hanging workflow can be cancelled https://github.com/apache/camel-kamelets/runs/4433396398?check_suite_focus=true

@oscerd forgot username and password as mandatory Kamelet properties. sorry for the trial end error. I think we are close to getting this test running green 🤞

No worries! Thanks a lot for your time!

@oscerd please one more round of approval 🙏

@oscerd ha, found a last issue. the test requires both timer-source and mail-sink Kamelet to be available in the namespace. Please approve once more.

Wohooo! SUCCESS! @oscerd many thanks for staying with me

Happy to help


invalid allocationClassSizeFactor

When I test cachelib in a test cluster, an error is thrown
E0818 21:25:01.105298    14 cachelib_cache_handler.cpp:54] invalid factor 6.93298464824273e-310
it throws from the check from MemoryAllocator.cpp
generateAllocSizes {   if (factor <= 1.0) {     throw std::invalid_argument(folly::sformat("invalid factor {}", factor));   } }
The way i create cachelib instance is
    Cache::Config config;
    config.setCacheSize(cache_size).setCacheName(cache_name).validate();
    return std::make_unique<Cache>(config);

where cache_size = 76GB.
I didn't set allocationClassSizeFactor anywhere and i think it is defaulted as 1.25? I am not sure what this config (allocationClassSizeFactor) is and why it is 0.

Hi @sathyaphoenix finally we find the root cause is we set -DFOLLY_SSE=0 to support AVX512 compiler optimizer. But cachelib requires folly::dynamic and f14map in nvmconfig and f14map requires at least FOLLY_SSE=2. I think cachelib does not check this case but just throws an error with a confusing error message.
Do you think we can add an additional check or have a comment in nvmconfig to avoid this issue?

@tangliisu Can you share the confusing error message that you see and also more details on how this causes the double value to be ~0. Also, please note that NvmConfig has moved away from using folly::dynamic in the main branch and it  has simple declarative api to configure it. https://cachelib.org/docs/Cache_Library_User_Guides/Configure_HybridCache) .. We do rely on F14Map though. Once you share the error message, we can look into an appropriate work around.

Thanks for the info. We pin cachelib to an old version so nvmconfig is still there.
I could not reproduce the error message allocationClassFSizeFactor ~0 in recent build.  But i happened to get the ~0 error before we figured out the FOLLY_SSE=0 issue
E0818 21:25:01.129964    14 ExceptionTracer.cpp:214] exception stack complete
terminate called after throwing an instance of 'std::invalid_argument'
  what():  invalid factor 6.93298464824273e-310

If cachelib still rely on F14Map, i guess we need to have FOLLY_SSE=2.
BTW we implemented cachelib in our system. The perf is very impressive. We are still working on tuning the cachelib to see if we could further reduce the CPU usage.

Great to hear it is working out as expected. Let us know if you need any information for tuning.
It is strange though that not setting FOLLY_SSE=2 would cause an unrelated double to be broken. cc @agordon  if he has any insights to share.


401 throws error in the console

When server returns 401 not authorized it throws error in the console even though it is handled

It looks like the issue is not Angular-side but rather just a normal browser behaviour. Source


Enable dependabot

Enable dependabot for notification when one of the dependencies has a vulnerability.
This is just the config file. The setting has to be enabled in the Security setting within the repository.

/assign @dlorenc

/ok-to-test

/approved

/lgtm

Thank you for your contribution!  😄


A not operator (!) in a template breaks hot reloading

Version
2.6.11
Reproduction link
https://jsfiddle.net/drnyt/sxj18w49/7/
Steps to reproduce

NPM version 6.14.5

vue create vue-todo
<template>
  <div class="hello">
    {{name}}
    {{btnState ? "The button is disabled" : "The button is active"}}
    <button
      v-on:click="changeName"
      v-bind:disabled="btnState"
    >CHANGE NAME</button>
  </div>
</template>

<script>
export default {
  name: "Skills",
  data() {
    return {
      name: "Coursetro",
      btnState: true
    };
  }
};
</script>

- Adding the not operator (!) to the following line:

    `{{btnState ? "The button is disabled" : "The button is active"}}`

    to

    `{{!btnState ? "The button is disabled" : "The button is active"}}`

    works and prints button is active, but removing the not operator (!) at this point would stop hot reloading.

- You can open the same link `http://localhost:8080/` in another tab without restarting and it will work again until you repeat the steps above.

### What is expected?
Hot reload stays active after removing a not operator (!) from the template.

### What is actually happening?
Hot reload stops working after removing the not operator (!) from the template.

---
- Works fine on JSFiddle

Tested on:
- Google Chrome | Version 83.0.4103.116 (Official Build) (64-bit)
- Microsoft Edge (Chromium) | Version 83.0.478.58 (Official Build) (64-bit)

<!-- generated by vue-issues. DO NOT REMOVE -->

I tried locally with that example and it worked.

Remember there is a forum and a Discord chat to ask questions!


Deprecate EpochRewards Contract on L2.

Description
Deprecates EpochRewards contract on L2.
Tested
Unit tested
Related issues

Fixes https://github.com/celo-org/celo-blockchain-planning/issues/197

Backwards compatibility
State changing functions will revert on L2

Version bump is necessary


Add "handlebars" to the dependenciesWhitelist

Handlebars ships its own types since version 4.1.0

Could anybody merge this? The removal of typings from DefinitelyTyped depends on it.

Bump. @sandersn?

Bump again – this is blocking DefinitelyTyped/DefinitelyTyped#33200, which blocks every single Ember types package.

Thank you, @sandersn! 😊

Should be published now as well. I restarted the Travis build to see whether it passes now.

Now DefinitelyTyped/DefinitelyTyped#33200 is hitting the typescript@next break for ember, which is tracked at https://github.com/Microsoft/TypeScript/issues/29898. @chriskrycho if you are an ember expert, you may be able to point out the best fix for what is going wrong here.

Gah. @mike-north had dug the furthest on that particular one. If he doesn't have a chance, I'll try to swing back around on this later today or tomorrow.

I'm not sure if the ember typings could not be made independent of Handlebars actually. All they need is "SafeString", which is pretty simple.
 export class SafeString {
      constructor(str: string);
      toString(): string;
      toHTML(): string;
  }

Seems like a lot of effort to depend on the whole Handlebars package just for that.

I'm not an ember expert, but as far as I know, ember isn't using Handlebars anymore.

@nknapp Ember does still use (a descendant of) Handlebars which uses Handlebars' types and AST. It still might be worth our extracting SafeString from that to a shared location, though. 🤔

I think that ember's decendant of Handlebars (you mean Glimmer?) ist not compatible to Handlebars 4.x though, but rather to 3.x
Now, the typing packages should somehow resemble to real package-structure. Which package do they get the SafeString class from?
Just that I understand correctly: When my PR is merged, and somebody installs @types/ember, does that pull<EMAIL_ADDRESS>into its dependencies as well?

After reading the comments on https://github.com/wycats/handlebars.js/issues/1499 and https://github.com/ef4/ember-auto-import/pull/191, I'm seriously considering removing the typings from Handlebars 4.1 again. Would be a pity, because the minor version bump was just because of the typings. But now, it seems to be more of a breaking change than a new feature.


Label takes Height and Width of the Grid container

I was creating a outline Text field component like the one below:

Here is the result

When I focus I get this.

But putting the background to the placeholder label, I realized that the label took the width and height of the entire container. Here is the result

Here is the code:
    public VisualNode OutlinedTextField(string label, string supportText, Action<string> textChangedAction)
        => Component.Render(context =>
        {
            MauiControls.Entry _entryRef = null;
            var state = context.UseState<(bool IsFocused, bool IsFilled)>();

            return new Grid("* Auto", "*")
            {
                    new Grid("*", "*")
                    {
                        new Border
                        {
                            new Grid
                            {
                                new BorderlessEntry(entryRef => _entryRef = entryRef)
                                .OnFocused(() => state.Set(s => (IsFocused: true, s.IsFilled)))
                                .OnUnfocused(() => state.Set(s => (IsFocused: false, s.IsFilled)))
                                .OnAfterTextChanged(text =>
                                {
                                    state.Set(s => (s.IsFocused, IsFilled: !string.IsNullOrWhiteSpace(text)));
                                    textChangedAction?.Invoke(text);
                                }),
                            }
                        }
                        .Padding(16,0)
                        .StrokeThickness(2)
                        .Stroke(Colors.Black),
                        new Label(label)
                            .Padding(16,0)
                            .TextColor(Colors.Black)
                            .VerticalTextAlignment(TextAlignment.Center)
                            .BackgroundColor(Colors.White)
                            .FontSize(state.Value.IsFocused || state.Value.IsFilled ? 12 : 16)
                            .TranslationY(state.Value.IsFocused || state.Value.IsFilled ? -25 : 0)
                    }
                    .Padding(0)
                    .HeightRequest(56)
                    ,

                    Current.BodySmall(supportText)
                        .Padding(16, 4, 16, 0)
                        .GridRow(1)
                        .TextColor(Current.Error)
            }
            .OnTapped(()=>_entryRef?.Focus());
        });

I'm not sure which issue you're reporting about MauiReactor, if the problem is the label is not completely visible, I think you have to play a bit with the translation value:
.TranslationY(state.Value.IsFocused || state.Value.IsFilled ? -25 : 0)
maybe something like -32 or so could do the trick

Thanks for the help. TranslationY is not the problem. the problem is that the Label takes the same height and width of it contains. When I apply TranslationY it moves with it width and heigh.  if I change the background of the BorderlessEntry to red and background of the Label to blue. get the following

unfocused
The whole Text field is now blue

focused
The label translate to -25. Now the BorderlessEntry entry with red background appear. The blue part is the Label it has the same size as the BorderlessEntry

The label occupies all the available space that is that provided by the parent grid, try to put VCenter() on the label

Yeah, VCenter() fix the height issue. The width is the same width as the container

Unfocused

Focused

Try with HCenter() for the width


Make needs to be run BEFORE make userspace-base/full to generate Jinx

Describe the bug
If running make userspace-base/full BEFORE make like the guide on the README suggests, it'll fail as it cant find Jinx. The solution is to run make to download Jinx and set it to be executable for some reason
To Reproduce
Steps to reproduce the behavior:

Follow the guide and run make userspace-base/full
See error

Expected behavior
I expected it to work and get Jinx
Screenshots
None
Environment (please complete the following information):

Host OS: Microsoft Windblows
Host OS Version: 11 IoT Enterprise LTSC 24H2
Emulator/Hypervisor: Not installed yet
Emulator/Hypervisor None as not installed yet

Additional context
None

Known issue. Will update the README.

okay


When deepCopying GlobalState, reserve the same amount of space for the symbol table

When deepCopying GlobalState, reserve the same amount of space for the symbol table.
Now the symbol table size passed in via --reserve-symbol-table-capacity is propagated to copies, which is useful for LSP.
This might be a no-op if reserve already upgrades the passed-in size to the nearest power of 2, but I'd rather not take my chances here. :)

Motivation

Reduce copying/allocation overhead in LSP.
Test plan

N/A

I sized the symbol and name tables properly and saw that vector.emplace_back overhead still existed. I immediately thought of deepCopy and confirmed that this is happening -- but I don't think this explains the copying I was seeing. AFAICT, on the CLI, we aren't using deepCopy on GlobalState after preallocating.


swagger: add 'required: true' for params in URL

Partial fix for #4010

Swagger validation needs 'required: true' for parameters that are in
the URL path.
Signed-off-by: Steve Traugott<EMAIL_ADDRESS>

Codecov Report

Merging #4097 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4097   +/-   ##
=======================================
  Coverage   19.97%   19.97%
=======================================
  Files         153      153
  Lines       30494    30494
=======================================
  Hits         6091     6091
  Misses      23489    23489
  Partials      914      914

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0549762...5e79dd6. Read the comment docs.


SysAdm empty filename passed to function

/var/log/sysadm-server-ws.log
Starting the PC-BSD sysadm server.... (WebSocket)
Using SSL Library:

Version: "OpenSSL 1.1.1-freebsd  11 Sep 2018"
Server Started: "2018-11-18T10:26:31"
Port: "12150"
URL: "wss://<IP_ADDRESS>:12150"
Configuration File: "/var/db/sysadm.ini"
WARNING: Empty filename passed to function
Context:  Line:

maybe related:
/var/log/PCDM-vt9.log
Warning: Could not parse stylesheet of object 0x7fffffffe808
Debug: ThemeStruct: Invalid item: "encdevice"
Warning: Empty filename passed to function
Warning: Could not parse stylesheet of object 0x7fffffffe808

has this been fixed in the latest release?

Sorry not, this is yet:
" - Configuration File: "/var/db/sysadm.ini"
WARNING: Empty filename passed to function
Context:  Line: "         by the /var/log/sysadm-server-ws.log

Most of the SysAdm errors/warnings are fixed on the latest release (18.11-PRERELEASE_2).
There are still a couple random "WARNING: Empty filename passed to function" prints on startup, but it does not seem to be affecting behavior/usage of SysAdm at all.


proposal: x/sync/errgroup: improve api for context values

I propose extending the x/errgroup API with a few convenience functions,

Context() context.Context - return the error group cancelable context,
GoContext(func(context.Context) error) - pass the produced ctx on to functions,

This requires:

Add the produced context.Context value to Group{},
Have the ability to read it afterwards with Context(),
Pass context to functions with GoContext(func(context.Context) error) convenience

The convenience function can be easily implemented as a wrapper:
func (g *Group) GoContext(fn func(context.Context) error) {
        g.Go(func() error {
                return fn(g.Context())
        }
}

The suggested naming is in line with http.Request Context(), and database/sql function signatures like ExecContext(...). The impact on code readability on codebases should be positive, as the wrapping for context-aware functions is eliminated on the consumer implementation side. There are no backwards compatibility issues that I can see.
Are PRs for this area accepted, any concerns? I'm more than willing to submit a PR for extending the functionality of this package.

An example from appleboy/gorush;
	var g errgroup.Group

	// Run httpd server
	g.Go(func() error {
		return gorush.RunHTTPServer(ctx)
	})

	// Run gRPC internal server
	g.Go(func() error {
		return rpc.RunGRPCServer(ctx)
	})

	// check job completely
	g.Go(func() error {
		select {
		case <-finished:
		}
		return nil
	})

	if err = g.Wait(); err != nil {
		gorush.LogError.Fatal(err)
	}

After:
	// we already had "ctx" which parent propagates
	// it's Done() to the child.
	g, ctx := errgroup.WithContext(ctx)

	// Run httpd server
	g.GoContext(gorush.RunHTTPServer)

	// Run gRPC internal server
	g.GoContext(rpc.RunGRPCServer)

	// check job completely
	g.Go(func() error {
		select {
		case <-finished:
		}
		return nil
	})

	if err = g.Wait(); err != nil {
		gorush.LogError.Fatal(err)
	}

Now, the code is more succint, doesn't wrap the functions with already expected function signatures, and the comments before individual Go*() calls feel redundant. Depending on what the code outside of the example does to trigger the error, it's also possible that the last function won't finish, meaning Wait() will never exit. We can fix that:
	// check job completely
	g.GoContext(func(ctx context.Context) error {
		select {
		case <-finished:
		case <-ctx.Done():
		}
		return nil
	})

This also solves a bug directly related to the group cancellation. As soon as any of the other functions exit with an error, the last function has the opportunity to return, allowing the error to bubble up the stack and get handled.

If to take a look at net/http.Request as I suggested, Context() should return context.Background() when it's internal context is a nil value. An zero context can be checked against nil.
// NewRequest wraps NewRequestWithContext using the background context.
func NewRequest(method, url string, body io.Reader) (*Request, error) {
	return NewRequestWithContext(context.Background(), method, url, body)
}

So, the Context() context.Context would be implemented as follows:
func (g *Group) Context() context.Context {
        if g.ctx == nil {
                return context.Background()
        }
        return g.ctx
}

The zero errgroup.Group today is valid, and collects errors without cancelling anything on error.

That's exactly the argument for adding a context-aware API. Even with the example above it's easy to see how not having a cancellation context from the group can lead to serious problems. If anything, passing context explicitly should be preferred over relying on scope.

@titpetric, that example seems pretty convoluted to begin with.

Why is the goroutine executing close(finished) not started within the errgroup in the first place?
Why does withContextFunc accept a callback, rather than returning a context that will be canceled appropriately? (That would make the function much easier to structure as a more typical g.Go callback.)
Given that InitWorkers accepts a context.Context, why does it also need to be passed a sync.WaitGroup (rather than blocking until the Context is done, then shutting down workers synchronously before returning)?

I think as motivating examples go, that one needs some concurrency cleanup before we can use it to conclude anything about errgroup API improvements.

Thinking about this some more, it might be feasible to use a sync.Once to allow the zero Group to initialize its own context.WithCancel the first time the Context method is called.
That would likely provide a better default than context.Background(), since it would allow the zero Group to support the same cancel-on-error behavior as other groups.
However, context.WithCancel requires might need some other API in order to avoid leaking resources. (In CL 134395, that API is a Stop method, but there would still be a potential leak if a caller that invokes Context is paired with an an older caller that allocates a zero Group and doesn't know about the Stop method.)

As a side-bar, what would be your thoughts on satisfying a context.Context value with errgroup.Group?

The WithContext() API becomes problematic with such a change,

would WithContext use return wg, wg?
should there be a NewGroup(ctx) api returning the Group only?

Calling <-wg.Done() would be an equivalent to wg.Wait(),
No need for a particular Context() function (wg is the context),
Satisfying a context.Context value is a strong signal that the group isn't intended for reuse, any cleanup could be done in Wait/Done (e.g. no defer wg.Stop() needed).

I'm also not completely sold on my GoContext() suggestion. What I mean by that is that maybe, if a breaking change would ever be OK here, it could be decided just to take func(ctx) error as the parameter for Go(). As far as I'm aware the x/ packages aren't subject to backwards compatibility promises, which might be an opportunity to provide a context-first API, instead of augmenting it with XContent() functions as I originally suggested. I think over 2000+ consumers of the errgroup package might be a deal-breaker here tho,... Nobody wants that amount of backlash :smile:

*errgroup.Group should not satisfy context.Context. It has no need to carry values, and its Wait method may legitimately return nil (whereas a Context.Err method must always return a non-nil error after Done() is closed).

This proposal has been declined as retracted.
— rsc for the proposal review group


Check for VolSync install via OADP for enableDataMover

https://github.com/openshift/oadp-operator/pull/741

https://github.com/openshift/oadp-operator/pull/752

merged


low cpu usage for given proto file

For given proto file I use 8 search workers. During execution I found that cpu usage for long periods doesn't match with number of search workers. Cpu utilization is with other proto files around 25-30% (comply with number of threads / available cores), with this proto file spectrum is much wider between 4 and 30%. It seems that lower cpu utilization has something to do with situation when a solution is found and after call of solution  callback cpu utilization is improved.
Given example consume during search around 40G of memory in ortools 7.3
proto.zip

Your question sounds similar to https://github.com/google/or-tools/issues/1420, but I'm not 100% sure if it still works like that

Most of the time is spent presolving the model, which is sequential.
Solving is fast and uses all threads.
I0919 12:00:42.190474 185435 sat_runner.cc:168] Reading a CpModelProto.
I0919 12:00:43.612012 185435 cp_model_solver.cc:2251] Parameters: num_search_workers: 8
I0919 12:00:43.753345 185435 cp_model_solver.cc:2265] Satisfaction model '':
#Variables: 119200

119200 in [0,1]
#kLinear2: 1631700
#kLinearN: 1192
I0919 12:00:43.877019 185435 cp_model_solver.cc:2308] *** starting model presolve at 0.27s
I0919 12:01:02.079699 185435 cp_model_presolve.cc:3873] - 0 affine relations were detected.
I0919 12:01:02.079766 185435 cp_model_presolve.cc:3875] - 0 variable equivalence relations were detected.
I0919 12:01:02.079798 185435 cp_model_presolve.cc:3883] - rule 'bool_or: implications' was applied 1631700 times.
I0919 12:01:02.079804 185435 cp_model_presolve.cc:3883] - rule 'linear: empty' was applied 37 times.
I0919 12:01:02.079809 185435 cp_model_presolve.cc:3883] - rule 'linear: negative clause' was applied 1631700 times.
I0919 12:01:02.079813 185435 cp_model_presolve.cc:3883] - rule 'linear: positive equal one' was applied 999 times.
I0919 12:01:02.079818 185435 cp_model_presolve.cc:3883] - rule 'linear: singleton column' was applied 37 times.
I0919 12:01:02.079825 185435 cp_model_presolve.cc:3883] - rule 'presolve: iteration' was applied 2 times.
I0919 12:01:02.137112 185435 cp_model_solver.cc:2333] Satisfaction model '':
#Variables: 115500
115500 in [0,1]
#kAtMostOne: 41699 (#literals: 622800)
#kBoolAnd: 3100 (#enforced: 3100) (#literals: 3100)
#kBoolOr: 999 (#literals: 99900)
#kLinearN: 156
I0919 12:01:02.223026 185435 cp_model_solver.cc:2196] *** starting Search at 18.61s with 8 workers and strategies: [ auto, less encoding, no_lp, max_lp, random, random_1, random_2, random_3 ]
I0919 12:01:03.448972 185547 synchronization.cc:110] #1      19.84s  no_lp num_bool:115500
I0919 12:01:03.451136 185552 synchronization.cc:110] #2      19.84s  less encoding num_bool:115500
I0919 12:01:05.104082 185435 cp_model_solver.cc:2454] CpSolverResponse:
status: FEASIBLE
objective: NA
best_bound: NA
booleans: 115500
conflicts: 0
branches: 250032
propagations: 8889668
integer_propagations: 458400
walltime: 21.4315
usertime: 21.4315
deterministic_time: 2.02935
primal_integral: 0

Sorry I have to disagree.
Of course I know that presolve use only single thread, I talk about next phase - searching.
I think the issue is not related to #1420, since additional search workers are used for lns and when no solution exists yet it doesn't make sense to execute them.
Attached proto file solves optimization and not feasibility problem.
There's my code :
File initialFile = new File("c:/temp/test2.proto");
InputStream targetStream = new FileInputStream(initialFile);
    CpModel model = new CpModel();
    model.getBuilder().mergeFrom(targetStream);

    CpSolver cpSolver = new CpSolver();

    cpSolver.getParameters().setLogSearchProgress(true);
    cpSolver.getParameters().setNumSearchWorkers(8);

    CpSolverSolutionCallback solutionCallBack =  new CpSolverSolutionCallback()
    {
        @Override
        public void onSolutionCallback()
        {
            System.out.println("solution found");
        }
    };

    cpSolver.solveWithSolutionCallback(model, solutionCallBack);

Sorry, too many files from support with the same names
Here is what I get on master:
216428 lperron   20   0 5177696   4.2g  19720 S 792.1   2.2  11:57.87 sat_runner
It uses 8 CPUs after 1 min and 30s, consistently.
At worst, it will use 5 threads when searching for a solution, and launch all 8 when/if it finds them.

Understand :-)
After 3hours of execution I still see periods when cpu usage is around 11% that corresponds to 4 threads at max for my cpu. I'll try to test it on master, run it on another OS and get some statistics about cpu usage. Maybe some synchronization between search workers is causing this behaviour.

how many cores do you have ?
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le jeu. 19 sept. 2019 à 13:28, gregy4<EMAIL_ADDRESS>a écrit :

Understand :-)
After 3hours of execution I still see periods when cpu usage is around 11%
that corresponds to 4 threads at max for my cpu. I'll try to test it on
master, run it on another OS and get some statistics about cpu usage. Maybe
some synchronization between search workers is causing this behaviour.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1588?email_source=notifications&email_token=ACUPL3NQUIHQ7G6CD4MWYN3QKNO4FA5CNFSM4IYINESKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7DEQHQ#issuecomment-533088286,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3POFZCALCN5XJIOQLLQKNO4FANCNFSM4IYINESA
.

16 real cores, with hyperthreading shown as 32 cores. threadripper 1950x

So usage is 5 / 32 before the first solution and 8/32 when one solution is
found.
It is consistent.
PS: You should use 16 workers or more.
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le jeu. 19 sept. 2019 à 13:34, gregy4<EMAIL_ADDRESS>a écrit :

16 real cores, with hyperthreading shown as 32 cores. threadripper 1950x
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1588?email_source=notifications&email_token=ACUPL3MX5CQGOGWGTLSDP33QKNPV3A5CNFSM4IYINESKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7DE7YY#issuecomment-533090275,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3MMKYI4FY5HEQQ5YFLQKNPV3ANCNFSM4IYINESA
.

I agree, this is how it should look like.
Meanwhile I used performance profiler from visual studio and have more correct data.
Phase one - presolve, one thread is used - in my case cpu usage is around 3-4%
Phase two - solve started, no solution is found yet - cpu utilization varies between 9-30%
Phase three - solution is found, displayed message
#1     202.16s best:5460  next:[5018,5459] no_lp num_bool:6511250
Phase four - Called solution callback
Between information that solution was found and execution of callback is minimally 40 seconds interval when cpu utilization is between 3-4%.
I can send you report file from VC, but it is little bit big 30mb per 3 minutes.

most likely a locking mechanism in the callback part.
Can you remove the callback  and try ?
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le jeu. 19 sept. 2019 à 14:39, gregy4<EMAIL_ADDRESS>a écrit :

I agree, this is how it should look like.
Meanwhile I used performance profiler from visual studio and have more
correct data.
Phase one - presolve, one thread is used - in my case cpu usage is around
3-4%
Phase two - solve started, no solution is found yet - cpu utilization
varies between 9-30%
Phase three - solution is found, displayed message
#1 https://github.com/google/or-tools/pull/1 202.16s best:5460
next:[5018,5459] no_lp num_bool:6511250
Phase four - Called solution callback
Between information that solution was found and execution of callback is
minimally 40 seconds interval when cpu utilization is between 3-4%.
I can send you report file from VC, but it is little bit big 30mb per 3
minutes.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1588?email_source=notifications&email_token=ACUPL3ND3254BXXJYAJWI4DQKNXHPA5CNFSM4IYINESKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7DKGKI#issuecomment-533111593,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3NAEPCW6WHRJOSO7C3QKNXHPANCNFSM4IYINESA
.

Definitely much better ... no interval where only one core is used.
This time I choose to use 16 cores but only for short time 16cores (about 50%) were used - on graph between 2:45 and 3:45. After 3:45 cpu usage is between 10 - 16% so callback is probably not only the
one reason.

If you are not in C++, there may be a global lock going back to C++,
forcing all threads with solutions to wait.
Inside, there is also a mutex, but normally the locking part is very
minimal.
In your graph, does the 3.45 minutes corresponds to finding the optimal
solution?
Sometimes, some threads are slow to finish.
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le jeu. 19 sept. 2019 à 15:39, gregy4<EMAIL_ADDRESS>a écrit :

Definitely much better ... no interval where only one core is used.
This time I choose to use 16 cores but only for short time 16cores (about
50%) were used - on graph between 2:45 and 3:45. After 3:45 cpu usage is
between 10 - 16% so callback is probably not only the
one reason.
[image: cpu_profile]
https://user-images.githubusercontent.com/5640112/65249124-b16b0600-daf3-11e9-890f-5004ab44aaed.png
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1588?email_source=notifications&email_token=ACUPL3LRLX32T5YTGBEENXTQKN6KTA5CNFSM4IYINESKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7DP7QY#issuecomment-533135299,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3PPKQMRPAUXF3FNSHTQKN6KTANCNFSM4IYINESA
.

No, optimal solution wasn't found and probably is not reachable in reasonable time.

It could be thermal throttling of the CPU.
Le jeu. 19 sept. 2019 à 16:23, gregy4<EMAIL_ADDRESS>a écrit :

No, optimal solution wasn't found and probably is not reachable in
reasonable time.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1588?email_source=notifications&email_token=ACUPL3JHN3JAH7JK2H2MCPTQKODPXA5CNFSM4IYINESKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7DUU6Y#issuecomment-533154427,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3IMB2HA3SZJRNLSTFDQKODPXANCNFSM4IYINESA
.

Hello!
I have roughly the same issue here, currently have my solvers running on AWS Batch using a c5.metal EC2 instance, which is 96 vCPUs and 192GB RAM.
Proto is a too large for github, but this should work
Anyway,

I've currently set num_search_workers to 192, on the off chance I've misunderstood something about logical threads, but it appears that CPU utilization never breaks 30%.
Doubt its a temperature problem as mentioned, given vCPUs. CPU Usage ends in the graph after a certain amount of time has passed (400 seconds).
Any help is appreciated!

You are right. I could reproduce on my machine.

Good to know its reproducible, thanks for the hard work! Looking forward to seeing the fix on master

I have done a first pass and committed to master. If possible, can you try ?

Hi @lperron ,
Sorry about the late reply. I'll let you know sometime this week, we gotta figure out how to deploy master branches using AWS Batch first. Thanks for the fix!

Alright, looks like the results speak for themselves.
Thanks for the fix @lperron !


[improve][txn] reduce unnecessary nested futures

cc @gaoran10 @BewareMyPower @codelipenghui @eolivelli @syhily
Documentation

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] doc-not-needed
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

Matching PR in forked repository
PR in forked repository: https://github.com/tisonkun/pulsar/pull/1

/pulsarbot run-failure-checks

/pulsarbot rerun-failure-checks


Scrape all profiles?

is there an option to scrape all profiles, because im not seeing it? do i have to choose each model separately? thanks.

--username ALL

--username ALL

--username ALL

lol yeah i just saw that sigh. thanks.


Maps autocomplete example documentation incomplete

Related page
https://mui.com/material-ui/react-autocomplete/#google-maps-place
Kind of issue
Missing information
Issue description
The sample code at https://mui.com/material-ui/react-autocomplete/#google-maps-place fails compilation with three errors, that all boil down to a missing dependency.
This could be effectively fixed by copying the same first sentence found under "Highlights:" ("The following demo relies on autosuggest-highlight, a small (1 kB) utility for highlighting text in autosuggest and autocomplete components.") to the description.
Context
This is useful to be able to run the example more or less as published, with one's own API key as is already made clear.
Search keywords: maps autosuggest-highlight implied implicit any

Right, makes sense. Would you be up to opening a PR for this?

I'm not sure; the barrier seems somewhat high to PRs that are considered valuable in this repo, which leads me to a high degree of uncertainty in my estimate about the low amount of time/effort fixing this seems like it should take.
I'm willing to provide the feedback that sets out a clear path to improvement, but the extra hours of unpaid effort for uncertain outcomes don't seem likely to reach a top priority for me in the near future.  If someone else wants to take it on, or help fix open-source's broken funding model here, that's fine with me. Otherwise, I might get to it eventually, but it won't be today.


targets: zephyr: Update for Zephyr 1.13

Zephyr 1.13 made some refactorings to its CMake infrastructure which must
be propagated to applications.
Also, some config options were removed/refactored, so cleanup prj.conf.
JerryScript-DCO-1.0-Signed-off-by: Paul Sokolovsky<EMAIL_ADDRESS>

@pfalcon The CI's Zephyr build job is failing after this update

@akosthekiss: Yeah:
Installing SDK to /home/travis/build/jerryscript-project/zephyr-sdk-0.9.2
git clone https://github.com/zephyrproject-rtos/zephyr.git ../zephyr -b v1.10.0

So, it uses pretty old Zephyr release and previous version of SDK. Let me update Travis-related infra with this PR too. Zephyr 1.13 itself is in RC phase now, with the release in a week or so. Until all that is done, let me mark this as WIP.

As an update, this now builds against  v1.13.0-rc3 and passes CI. The release should be tagged next week.

@zherczeg, @akosthekiss: Zephyr 1.13 was released, this PR was updated to build with the release tag and passes CI.  First commit is for code changes, 2nd - for CI infrastructure, what's sense to squash them? But done.

@pfalcon That's one way to look at it. From my perspective, all this is a build system bump. And also the project custom is one commit per PR -- if changes are independent enough to be broken into separate commits then separate PRs should also be opened. And each PR/commit shall pass on the CI on its own. I'm not sure this would've worked here. Anyway, the important thing is that the update has landed in master.

@akosthekiss:
Thanks for response, indeed, such schedule also has its place.

Anyway, the important thing is that the update has landed in master.

Indeed, thanks!


Backslash issue with isValid

Here's a test sample:
moment("custom2008\01,10", "[custom]YYYY\MM,DD", true).isValid()
false
moment("custom2008\01,10", "[custom]YYYY[\]MM,DD", true).isValid()
false
Looking inside the moment object I can see there is a backslash left over and a backslash unused token.
Whereas using a pipe instead:
moment("custom2008|01,10", "[custom]YYYY[|]MM,DD", true).isValid()
true
The engine I am using is Internet Explorer 10 on Windows 8.

Sorry, I missed a reply here.
Thanks for pointing that out.
I don't know what I was thinking on that day (I used to code C, so I should have spotted it!).