USB core has a data race during write on many platforms

The function hid_int_ep_write() has a data race where the TX data may change underneath the USB driver. For example, hid_int_ep_write() calls usb_write() directly passing the user's data buffer. Many USB drivers do not copy the buffer before using it e.g. nrfx and stm32, while e.g. rpi_pico, native_posix, and kinetis do. This means that if the caller modifies the passed data buffer before the TX is complete the host may observe the new contents.
The problem was identified on the nrfx platform (a Kinesis Adv360 keyboard running ZMK), and was observed to very reliably cause keys to be dropped. On wireshark two TX messages were recorded with each keypress (corresponding to key press and key release), but both messages contained the same contents (no keys pressed). Only a key press-release combination generated by a macro-like mode of ZMK is fast enough to trigger the bug. My proposed fix to ZMK, the PR https://github.com/zmkfirmware/zmk/pull/2257, simply copies the data into a temporary buffer before the call and immediately fixed the problem as tested on real hardware.
I am confident this is bug in Zephyr because all but one of the samples which call hid_int_ep_write(), namely usb/hid-mouse, usb/hid-cdc, and sensor/fxos8700-hid all do not protect the data buffer after calling hid_int_ep_write(), e.g. by modifying it immediately after the call, or by leaving it on the stack and returning allowing for corruption. (Note that the semaphore in sensor/fxos8700-hid is not protecting the data buffer.) The only sample which does not have this issue (usb/hid) is because it is too simple and uses a constant buffer.
In order to fix the problem either the HID function hid_int_ep_write() or the USB core function usb_write() (or the underlying driver usb_write() immediately calls) need to copy the data buffer. I am happy to implement a fix in any case but seek confirmation of what the intended API is and thus which approach to take.
Thank you very much in advance for your help.

Actually, while stm32 doesn't copy the buffer, it does wait until the transmission has been received by the host before returning. Other platforms I am checking appear to copy the buffer. I suppose is just a bug in nrfx.

I am confident this is bug in Zephyr because all but one of the samples which call hid_int_ep_write(), namely usb/hid-mouse, usb/hid-cdc, and sensor/fxos8700-hid all do not protect the data buffer after calling hid_int_ep_write(), e.g. by modifying it immediately after the call, or by leaving it on the stack and returning allowing for corruption. (Note that the semaphore in sensor/fxos8700-hid is not protecting the data buffer.) The only sample which does not have this issue (usb/hid) is because it is too simple and uses a constant buffer.

Yes, all HID samples are sloppy with report buffers. At least hid and hid-mouse should be fixed. We should consider removing hid-cdc and fxos8700-hid samples as they do not provide much benefit. fxos8700 is actually a generic sample and can be reworked into a generic input driver.


[BUG] Dead link in Azure Identity Readme

Describe the bug
A clear and concise description of what the bug is.
The line:
See more about how to configure Azure CLI in [Sign in Azure CLI for AzureCliCredential](https://github.com/Azure/azure-sdk-for-java/wiki/Set-up-Your-Environment-for-Authentication#sign-in-azure-cli-for-azureclicredential).
The sign in link goes to create a new wiki page.

Looks like this was fixed at some point.


HttpServer support configure the allowed HTTP methods.

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[X] Update the CHANGES log.

Do we need this to be configurable? I remember we disable other methods because of Jetty server CVE. Can you take a

I don't want to set the other allowed method as global, since mostly are POST for now.
This configuration needs to be explicitly turned on by configuration, I  think it's no different to configure it in java code.

I mean, if you add other methods than POST you need to enable this otherwise the added methods won't take effect. What's the point to let users set it themself if this is going to be always "POST,GET"? Do you think users will change the configuration to something like "POST,GET,DELETE" if they don't modify the codes (add a DELETE method)? I don't think we want to add random configuration that users might never set themselves.

From HTTP server perspective, these configurations should only affect to codes interaction, which is fine. We don't expose these to end users.
But for different HTTP server, it could be different, SkyWalking only exposes POST for native protocol, but Zipkin expose Get for query.

Let trace back to when this was added https://github.com/apache/skywalking/pull/7052 I'd just remove the method check as this was to fix Jetty CVE  and now we don't use Jetty we could just allow all methods.

I mean, if you add other methods than POST you need to enable this otherwise the added methods won't take effect.

Make sense. So could we just let this configure in the specific module configure.java code, like ZipkinReceiverConfig.java
not expose it to the config file(yaml) or env. variables.

In my mind, I prefer to generate this setting from all declaration of handlers, and set this when server start. This is not a setting, this is a expose limitation, which is good.
I know this was introduced by jetty, but this kind of CVE happenned from time to time for any HTTP server.
@wankai123 Let's not check it, and accept this as a part of handler registration, and lock it just before server starts.


CAS Integration 1 - Add CAS Supplier Info to Student Profile (SFAS Import & Get Supplier Number)

User Story:
SIMS must record and maintain a student's 'supplier' information as part of their profile, so that a student's SIMS profile can match with their corresponding account in the Corporate Accounting System (CAS), and SIMS can relay critical information about that student to CAS.
Acceptance Criteria:
Initiate 'Get Supplier' Process (See Doc 1,  Section: 11.1.6, page 13 for context)

[ ] If student does not have a supplier and site number, execute the 'Get Supplier By Last Name and SIN' process with CAS.

[ ] If successful response is received, save the following details to DB:

SupplierNumber
SupplierName
Supplier protected
Supplier Address, especially suppliersitecode and siteprotected
status

[ ] if any error other than not found (404) then ????

[ ] If empty result or 404 error code is received, then end current process  - next steps (creating new supplier info) will be pursued in #3260

[ ] If any of following conditions are met, then end current process, and error handling will be deferred to #3258

If status = inactive

If Supplier Name does not match with the name in SIMS profile

If SupplierProtected = Yes

If Siteprotected = Yes

Saving Historical Details:

[ ] DB should record all iterations of the following information:

Supplier Number and Supplierprotected
Supplier Site Code and siteprotected

Technical Context:
Question:  Should the auth token be stored in Redis as we know how long the token is valid for?
Stephen or Jason to supply required connection information (.env)
Sample Code
  async authenticate(): Promise<any> {
    const url = `${this.baseUrl}/oauth/token`;
    const auth = Buffer.from(`${this.clientId}:${this.clientSecret}`).toString(
      'base64',
    );
    const headers = {
      'Content-Type': 'application/x-www-form-urlencoded',
      Authorization: `Basic ${auth}`,
    };
    const body = new URLSearchParams();
    body.append('grant_type', 'client_credentials');
    const config: AxiosRequestConfig = {
      headers,
    };
    const response = await firstValueFrom(
      this.httpService.post(url, body.toString(), config),
    );
    return response.data as AuthResult;
  }

  async getSupplier(token: string, sin: string, surname: string): Promise<any> {
    const url = `${this.baseUrl}/cfs/supplier/${surname}/lastname/${sin}/sin`;
    const headers = {
      Authorization: `Bearer ${token}`,
    };
    const config: AxiosRequestConfig = {
      headers,
    };
    const response = await firstValueFrom(this.httpService.get(url, config));
    return response.data as SupplierQueryResult;
  }

Business Context:
Questions:

Do we need to identify an SFAS Site Code so we can handle this supplier information differently, i.e. not attempt edits, etc...?
Do we need to run the 'Get Supplier Number' process for students with existing SFAS info saved?
Why does 'Get Supplier Process' send the address details?
Do we need a secondary check if the first one fails? I.e. if Last Name + SIN aren't found, should we check another format like Supplier Name + Postal Code?

Mock-Ups
Fig 1

Fig 2 - Success Response Format for Get Supplier Number Process

Doc 1
Supplier Web Service RESTful Client Onboarding v02_01.pdf
Doc 2:
Individual Supplier Web Service Field Requirements (All Requests) JAN2023.xlsx

@HRAGANBC we should review this and then take it to grooming

@andrewsignori-aot

the understanding on Upon student creation, create a new entry in the sims.cas_suppliers and have it associated with a new column in sims.students.cas_supplier_id table. This would follow the same idea from sims.sin_validations and sims.students.sin_validation_id., why are we creating an entry if the student is not validated for sin and on creation?
On displaying the table cas_suppliers UI in the ministry portal, the line items for the suppliers for a particular student has to be fetched from this table cas_suppliers. Without the relation of student_id in the table how we could display muliple rows?

@andrewsignori-aot

the understanding on Upon student creation, create a new entry in the sims.cas_suppliers and have it associated with a new column in sims.students.cas_supplier_id table. This would follow the same idea from sims.sin_validations and sims.students.sin_validation_id., why are we creating an entry if the student is not validated for sin and on creation?
On displaying the table cas_suppliers UI in the ministry portal, the line items for the suppliers for a particular student has to be fetched from this table cas_suppliers. Without the relation of student_id in the table how we could display muliple rows?
Reason for having Pending address verification status in the enum.
What will be the enum status if the CAS call is failure or no response is returned.
When a manual Edit Info is added for a particular student only SupplierNumber and SiteCode information is populated? What other information has to be updated in the sims.cas_suppliers table other than the supplier_status as Verified manually?
Efforts on configuration for cas api, like the URL endpoint, authentication parameters in our project is not captured. Do we need it initially as a first effort and from there create the table for cas_suppliers as subsequent efforts?

Following the same approach from SIN we ensure there will always be a status associated with the student even if it is "pending".
Following the same approach from SIN we can have the student ID added.
Pending address verification is reserved for future use when students update their profiles and we need to communicate CAS. It is not part of this ticket and it can be added later if the Team is not willing to have it added now.
Failure to call CAS should keep the status as it is to a new attempt happen. 404 will be returned if not student was found and I believe that we can set the is_valid to false and set the record as validated.
Details for manual editing will be clarified in upcoming tickets.
The effort for the authentication is specified on "Create new secrets to store the Client ID and Client Secret." and we can just have the API URL added.

@HRAGANBC @sslaws @JasonCTang
I have some questions I couldn't find in the documentation or ACs:

Can a supplier response have more that one "item"? If so, should we ignore the rest?
Is it possible that a supplier does not have an address? What to do if so?
What's criteria to set isValid to true for a supplier? Should it just set isValid to true if there's a response for the request?

@andrepestana-aot

Can a supplier response have more that one "item"? If so, should we ignore the rest?
My understanding is that you can only have one item, but Nino has asked CAS for confirmation
Is it possible that a supplier does not have an address? What to do if so?
My understanding is that is not possible, but Nino has asked CAS for confirmation
What's criteria to set isValid to true for a supplier? Should it just set isValid to true if there's a response for the request?
My understanding is that is a variable we define ourselves to reflect whether or not SIMS has all the information it needs from CAS transactions. We set isValid = true when:

we receive a successful response of any kind from CAS, OR
A minstry user manually input the supplier information through the interface

@ninosamson @sslaws FYI

@andrepestana-aot

Can a supplier response have more that one "item"? If so, should we ignore the rest?
My understanding is that you can only have one item, but Nino has asked CAS for confirmation
Is it possible that a supplier does not have an address? What to do if so?
My understanding is that is not possible, but Nino has asked CAS for confirmation
What's criteria to set isValid to true for a supplier? Should it just set isValid to true if there's a response for the request?
My understanding is that is a variable we define ourselves to reflect whether or not SIMS has all the information it needs from CAS transactions. We set isValid = true when:

we receive a successful response of any kind from CAS, OR
A minstry user manually input the supplier information through the interface

@ninosamson @sslaws FYI

Hi @andrepestana-aot.
Confirming that all suppliers MUST have an address as per minimum requirement on creation.

@ninosamson Could you confirm if the lastname for the request should be capitalized. In my tests I had different results with upper and lower cases.

From the documentation @andrepestana-aot


Request language server info in bug report template

Request language server info in bug report template

This is a good step, for sure... i feel like some future version of our language server spec should include a way to find that with a user-oriented CLI, e.g. jupyter lsp versions, etc. Unfortunately, not all language servers support such a thing from their command line interface, and I don't believe there is a message we could use to determine it from a running one...


Minor update from privacy team

Minor update to privacy policy, as requested by GDS privacy team.

Looks good! 👍🏻


[COMMUNICATION] - [LIVE TESTS] - adding missing env var

Live tests are failing because of a new environment variable that was introduced.
Introducing it into the test resources to fix tests

\azp pipeline net - communication - tests

/azp pipeline net - communication - tests

/azp run net - communication - tests

/azp run net - communication - tests


Bandcamp - !play ALBUM errors

Singles work, but not entire albums. This exception is after running:
!play http://deepelmdigital.com/album/wide-awake
Future exception was never retrieved
future: <Future finished exception=FileNotFoundError(2, 'No such file or directory')>
Traceback (most recent call last):
  File "C:\Users\Michael\Desktop\MusicBot-1.9.5rc7\musicbot\playlist.py", line 261, in _download
    unmoved_fname = md5sum(unhashed_fname, 8).join('-.').join(unhashed_fname.rsplit('.', 1))
  File "C:\Users\Michael\Desktop\MusicBot-1.9.5rc7\musicbot\playlist.py", line 319, in md5sum
    with open(filename, "rb") as f:
FileNotFoundError: [Errno 2] No such file or directory: 'Bandcamp_-album-wide-awake-Wide_Awake.NA'
Failed to get entry.
Traceback (most recent call last):
  File "C:\Users\Michael\Desktop\MusicBot-1.9.5rc7\musicbot\player.py", line 164, in _play
    entry = await self.playlist.get_next_entry()
  File "C:\Users\Michael\Desktop\MusicBot-1.9.5rc7\musicbot\playlist.py", line 168, in get_next_entry
    return await entry.get_ready_future()
  File "C:\Users\Michael\AppData\Local\Programs\Python\Python35-32\lib\asyncio\futures.py", line 358, in __iter__
    yield self  # This tells Task to wait for completion.
  File "C:\Users\Michael\AppData\Local\Programs\Python\Python35-32\lib\asyncio\tasks.py", line 290, in _wakeup
    future.result()
  File "C:\Users\Michael\AppData\Local\Programs\Python\Python35-32\lib\asyncio\futures.py", line 274, in result
    raise self._exception
  File "C:\Users\Michael\Desktop\MusicBot-1.9.5rc7\musicbot\playlist.py", line 261, in _download
    unmoved_fname = md5sum(unhashed_fname, 8).join('-.').join(unhashed_fname.rsplit('.', 1))
  File "C:\Users\Michael\Desktop\MusicBot-1.9.5rc7\musicbot\playlist.py", line 319, in md5sum
    with open(filename, "rb") as f:
FileNotFoundError: [Errno 2] No such file or directory: 'Bandcamp_-album-wide-awake-Wide_Awake.NA'

Thanks for your hard work with this bot!

Yep, seems to be a bug with how this one is handled.  I'll sort this out soon.  Oddly enough, it seems all the tracks are downloaded properly, but the bot doesn't construct the names properly or something weird.

Attempt 3 of explaining this issue: It's a bit weird.  That link isn't a proper bandcamp link, http://deepelmrecords.bandcamp.com/album/wide-awake is.  However, this link redirects to the link you posted in your browser.  Youtube-dl doesn't recognize your link as a bandcamp playlist, so it doesn't work.  But when it processes the link, it goes through the redirect and it works.  This is an odd situation and I'll have to do some testing, but i'll get this sorted out eventually.

Whats funny is that the singles like http://deepelmdigital.com/track/glowing-embers do work, even though their not a "bandcamp" link either. Thanks for your help!

I think this is fixed.  Reopen if this comes up again and i'll take another look.

Almost fixed :P
It downloads everything, prepares to play the song, and...
[Command]<PHONE_NUMBER>45719808/MichaelFedora (!play http://deepelmdigital.com/album/wide-awake)
[Download] Started: http://deepelmdigital.com/album/wide-awake
[Download] Complete: http://deepelmdigital.com/album/wide-awake
audio_cache\Bandcamp_-album-wide-awake-Wide_Awake.NA: No such file or directory

Can't find the *.NA file. Singles and normal bandcamp links do work though.

I think part of this is how I deal with processing links.    I'm writing the soundcloud set async processing function.

I fixed the fucker.  https://github.com/SexualRhinoceros/MusicBot/commit/041916f465b6b6a768ba3de3989671918496a98f


Call profile service api endpoint on page load

If successful redirect to Homepage or redirect to login page

Completed


[GHSA-9c47-m6qq-7p4h] Prototype Pollution in JSON5 via Parse Method

Updates

Affected products
Description

Comments
The upstream maintainer has released a version 1.0.2 which backports the relevant patch (https://github.com/json5/json5/blob/v1.0.2/CHANGELOG.md).

Hi there @jdgregson and @jordanbtucker! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

Ah, sorry - I wasn't clear where these edit suggestions were sent to so wasn't able to check for duplicates. This is a dup of #1541


[Bug] Changes in new version crashes

Just changed to the newest version, but that results in a crash when starting up
There has been no changes in my code and it works with an older version of JTouchbar.
:runIde
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x000000010bcec129, pid=14254, tid=0x0000000000010507
#
# JRE version: OpenJDK Runtime Environment (8.0_152-b06) (build 1.8.0_152-release-1153-b6)
# Java VM: OpenJDK 64-Bit Server VM (25.152-b6 mixed mode bsd-amd64 compressed oops)
# Problematic frame:
# V  [libjvm.dylib+0x2ec129]  jni_GetObjectClass+0x65
#
# Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /Users/uruloke/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIC/LATEST-EAP-SNAPSHOT/71ffd116fca01d7bd4db1251b5e567b70d5e78e1/ideaIC-LATEST-EAP-SNAPSHOT/bin/hs_err_pid14254.log
#
# If you would like to submit a bug report, please visit:
#   http://bugreport.java.com/bugreport/crash.jsp
#
:runIde FAILED

The log file referenced above can be found here.
Haven't been able to reproduce it in a simple example, not sure what the difference is in my project, sorry.
Sidenote:
Could be nice if you changed the version when you make changes. So we can actually tell which version isn't working anymore.

I will have a look at this.
In regards to the sidenote, I hope to soon move the snapshot to the release repository, after that version numbers will hopefully move more quickly.

@ttveldhuis Sounds great.
Sorry for not being able to give you a simple example to run.

Pushed a fix for the bug found in the log file. Hopefully that should fix your crash.

I fixed the crash, but now there is no touchbar.
It also fails to show a touchbar in a simple example.
     JFrame frame = new JFrame();
        frame.add(new Button("works"));
        frame.pack();
        frame.setVisible(true);

        JTouchBar jTouchBar = new JTouchBar();
        jTouchBar.setCustomizationIdentifier("MySwingJavaTouchBar");

        // button
        TouchBarButton touchBarButtonImg = new TouchBarButton();
        touchBarButtonImg.setBezelColor(Color.CONTROL_COLOR);
        Image image = new Image(ImageName.NSImageNameTouchBarColorPickerFill, false);
        touchBarButtonImg.setImage(image);

        jTouchBar.addItem(new TouchBarItem("button_1", touchBarButtonImg));
        jTouchBar.show(frame);

@ttveldhuis Great the example i provided works now.
No need for apologising, I am just using your library, your the hero here.


FIx the Emergency option

When no contacts is saved then on clicking the Emergency option it should redirect you to Emergency Contacts page.

Hi!
I would like to give this a shot .Could you please assign it to me?

Hi!
I would like to give this a shot .Could you please assign it to me?

Ok

Sir,Could you please guide me as to how I can reproduce the bug?

Sir,Could you please guide me as to how I can reproduce the bug?

When no contacts is saved then on clicking the Emergency option it should redirect you to Emergency Contacts page.

Hi! I would like to work on this issue.
Please assign this to me.

Hi! I would like to work on this issue.
Please assign this to me.

Ok @musavveer

Thank You @swapnilsparsh
See my DM on discord

@swapnilsparsh Can u also assign me this issue to?

@swapnilsparsh Can u also assign me this issue to?

Thank you for showing you interest in the project.
@SubhradeepSS  you have to wait for 3-5 days as 2 people are already assigned on this issue.
Kindly give some time to the assignees to resolve the issue then you can work on this issue till then look after some other issues.
We appreciate your patience.

Issue has been resolved by @musavveer


Faster implementations of Besselk0 and Besselk1

Implementation of besselk0, besselk1 and their scaled versions based on approximations given here
The implementation follows similar discussion in #6 by reducing a couple of branches and merging Float32 and Float64.
This comes with quite a performance boost...
# old version
julia> @benchmark besselk0(x) setup=(x = 100*rand())
BenchmarkTools.Trial: 10000 samples with 998 evaluations.
 Range (min … max):  15.514 ns … 52.198 ns  ┊ GC (min … max): 0.00% … 0.00%
 Time  (median):     36.564 ns              ┊ GC (median):    0.00%
 Time  (mean ± σ):   36.300 ns ±  2.779 ns  ┊ GC (mean ± σ):  0.00% ± 0.00%

   ▂                                                    █   ▃ ▁
  ▅█▃▁▁▄▃▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁█▄▁▄█ █
  15.5 ns      Histogram: log(frequency) by time      38.3 ns <

 Memory estimate: 0 bytes, allocs estimate: 0.

# new version
julia> @benchmark besselk0(x) setup=(x = 100*rand())
BenchmarkTools.Trial: 10000 samples with 999 evaluations.
 Range (min … max):   8.925 ns … 29.659 ns  ┊ GC (min … max): 0.00% … 0.00%
 Time  (median):     13.693 ns              ┊ GC (median):    0.00%
 Time  (mean ± σ):   13.692 ns ±  0.867 ns  ┊ GC (mean ± σ):  0.00% ± 0.00%

                                             ▆█               ▁
  ▅▁▆█▃▃▃▁▁▁▁▁▁▁▁▁▁▃▃▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▃███▃▁▁▁▁▁▁▁▁▁▁▅█ █
  8.92 ns      Histogram: log(frequency) by time      15.2 ns <

 Memory estimate: 0 bytes, allocs estimate: 0.

# comparing to SpecialFunctions.jl
julia> @benchmark besselk(0, x) setup=(x = 100*rand())
BenchmarkTools.Trial: 10000 samples with 815 evaluations.
 Range (min … max):  122.103 ns … 592.071 ns  ┊ GC (min … max): 0.00% … 65.17%
 Time  (median):     200.658 ns               ┊ GC (median):    0.00%
 Time  (mean ± σ):   215.430 ns ±  46.820 ns  ┊ GC (mean ± σ):  0.04% ±  0.94%

             ▇▆██▆▇▆▅▆▅▄▄▃▃▃▃▂▂▁▁▁▁                             ▂
  ▂▄▅▅▂▆▆▇▇▇▇█████████████████████████▇▇██▇▇▆▇▇▆▇▅▆▆▅▆▇▇▆▅▆▆▆▅▅ █
  122 ns        Histogram: log(frequency) by time        435 ns <

 Memory estimate: 16 bytes, allocs estimate: 1.

These implementations also handle large arguments better at the edges of float precision
# SpecialFunctions.jl
julia> besselk(0, 700.0)
0.0

# Bessels.jl
julia> besselk0(700.0)
4.669776431685378e-306

Codecov Report

Merging #7 (5599e6e) into master (547bfad) will decrease coverage by 0.35%.
The diff coverage is 91.17%.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   93.91%   93.55%   -0.36%
==========================================
  Files          12       11       -1
  Lines         427      481      +54
==========================================
+ Hits          401      450      +49
- Misses         26       31       +5

Impacted Files
Coverage Δ

src/besselk.jl
88.15% <88.00%> (-0.74%)
:arrow_down:

src/constants.jl
100.00% <100.00%> (ø)

src/besselj.jl
93.69% <0.00%> (-0.12%)
:arrow_down:

src/chebyshev.jl
100.00% <0.00%> (ø)

src/Bessels.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 547bfad...5599e6e. Read the comment docs.

How do the maximum errors compare?

Old errors compared to ArbNumerics.jl

New errors

New error average rel. error / eps(Float64) = 0.51424
maximum = 2.1939
Optimizing these polynomials any further is pretty prohibitive due to the issue with besselk in ArbNumerics.jl. I've commented https://github.com/JeffreySarnoff/ArbNumerics.jl/issues/48. This essentially makes Remez.jl take hours to give meaningful results after setting precision above 2000.

I've added implementations for besselk(nu,x) and besselkx(nu, x). These are accurately and quickly calculated with a three term recurrence using besselk0 and besselk1. For small to moderate orders this is ok and most likely the fastest way to do this.
# Bessels.jl
julia> @benchmark besselk(50, x) setup=(x=rand()*30)
BenchmarkTools.Trial: 10000 samples with 978 evaluations.
 Range (min … max):  66.969 ns … 108.788 ns  ┊ GC (min … max): 0.00% … 0.00%
 Time  (median):     72.463 ns               ┊ GC (median):    0.00%
 Time  (mean ± σ):   72.645 ns ±   1.870 ns  ┊ GC (mean ± σ):  0.00% ± 0.00%

         ▃▁                      ▁█▆▆▂     ▃▁▁                 ▂
  ▆▆▃▁▁▁███▆▄▁▃▁▁▅▅▅▁▃▁▁▁▁▄▁▁▁▃▁▃██████▅▅▃████▇▇▆▆▆▆▇██▇▇▆▆▄▆▆ █
  67 ns         Histogram: log(frequency) by time        77 ns <

 Memory estimate: 0 bytes, allocs estimate: 0.

## Compared to SpecialFunctions.jl
julia> @benchmark besselk(50, x) setup=(x=rand()*30)
BenchmarkTools.Trial: 10000 samples with 200 evaluations.
 Range (min … max):  399.605 ns … 949.175 ns  ┊ GC (min … max): 0.00% … 0.00%
 Time  (median):     515.200 ns               ┊ GC (median):    0.00%
 Time  (mean ± σ):   538.276 ns ±  65.815 ns  ┊ GC (mean ± σ):  0.00% ± 0.00%

          ▁▁▁▁  ▅█▇▇▆▅▅▄▄▄▃▄▃▃▃▂▃▂▂▂▁▂▁▁▁▁▁▁ ▁                  ▂
  ▅▆▇██████████████████████████████████████████████▇▇▇▇▇▇█▇▇▆▇▇ █
  400 ns        Histogram: log(frequency) by time        792 ns <

 Memory estimate: 16 bytes, allocs estimate: 1.

When the order is large and x is large it is much faster to use a uniform expansion to calculate this. I have added notes in the document about how to implement this. We should come back at a later time to implement this as it requires other bessel functions we haven't implemented yet.
# Bessels.jl
julia> @benchmark besselk(120, x) setup=(x=rand()*1000 + 10.0)
BenchmarkTools.Trial: 10000 samples with 995 evaluations.
 Range (min … max):   27.027 ns …   5.351 μs  ┊ GC (min … max): 0.00% … 0.00%
 Time  (median):     137.620 ns               ┊ GC (median):    0.00%
 Time  (mean ± σ):   288.813 ns ± 879.224 ns  ┊ GC (mean ± σ):  0.00% ± 0.00%

  ▆█                                                          ▂ ▁
  ██▇▃▁▁▁▁▁▁▃▃▁▁▁▃▄▃▁▁▄▃▄▄▁▄▄▅▁▄▄▃▅▃▁▄▄▄▄▄▄▅▄▃▄▄▄▄▅▄▅▅▅▄▅▅▄▄▄▅█ █
  27 ns         Histogram: log(frequency) by time       4.79 μs <

 Memory estimate: 0 bytes, allocs estimate: 0.

# SpecialFunctions.jl
julia> @benchmark besselk(120, x) setup=(x=rand()*1000 + 10.0)
BenchmarkTools.Trial: 10000 samples with 631 evaluations.
 Range (min … max):  194.799 ns …  1.524 μs  ┊ GC (min … max): 0.00% … 86.15%
 Time  (median):     207.323 ns              ┊ GC (median):    0.00%
 Time  (mean ± σ):   206.982 ns ± 19.862 ns  ┊ GC (mean ± σ):  0.13% ±  1.22%

   █                   █▇
  ▄█▂▂▂▃▅▅▂▃▅▃▃▃▃▂▂▂▂▂▃██▇▆▂▅▇▆▄▇▅▄▄▃▃▃▃▂▂▂▂▂▂▂▂▂▂▂▂▁▂▃▂▁▁▂▂▂▂ ▃
  195 ns          Histogram: frequency by time          229 ns <

 Memory estimate: 16 bytes, allocs estimate: 1.

It looks like SpecialFunctions.jl switches over to this expansion with the amos routines. Which becomes faster starting at around order 200.
@oscardssmith Could you review this three term recurence function? Its speed is pretty important for fast generation of these higher order terms. It will also be used for the bessely(nu, x) implementation.
One thing we should consider is returning an array of nu values. This is usually how you need them anyway so we should also have an implementation that returns the array.... will have to think about best way to do this.

Ok I am going to merge this and open a new PR with the other method I am working on for higher orders. It is very accurate even for lowish orders. We can move the discussion of the recurrence errors there as well to decide how we want to deal with those. We will have to determine the right asymptotic cutoff but I think this discussion will be best as its own PR. It works for both besseli(nu, x) and besselk(nu, x)


[WIP] Modularity Change Review

Thank you for submitting a pull request. This code is leveraged to monitor critical services. Before contributing, please read our contributing guidelines and code of conduct.

Overview
Please describe the changes present in the pull request and if applicable, describe why the changes are needed.
Related Github Issue
Please include a link to the related GitHub issue, if applicable
Testing
The browser agent includes a suite of tests which should be used to
verify that your changes don't break existing functionality. These tests will run through Github Actions when:

A pull request is made and
The pull request is marked as ready for testing by the internal team.

If applicable, please include details on how to test your changes.

More details on running your tests locally can be found in the
CONTRIBUTING and README docs.

Any plans drawn to optimize using splitChunks ? I imagine the chunks be: a. base loader + {metrics, page-view-event, page-view-timings} instrument b. each feature instrument individually c. base aggregator d. {m, pve, pvt} together + each feature aggregate individually

Plan would probably be an outcome of spiking on async loader impacts

Integrated into: PR https://github.com/newrelic/newrelic-browser-agent/pull/259


Players can decide whether grenades can damage the map

Is your feature request related to a problem? Please describe.
Explosive bullets and grenades always destroy the map.
Describe the solution you'd like
Players can determine whether explosive bullets and grenades can destroy blocks through the destroy GlassBlocks option
Describe alternatives you've considered
But when the world rule mobGriefing is closed, explosive bullets and grenades cannot destroy the map
Additional context
N/A

Will come in 0.1

 Config Overhaul

I have solved it myself, and after the merger, I will close this issue


feat: add masking for captured data

dependant on:

https://github.com/speakeasy-api/speakeasy-schemas/pull/12
https://github.com/speakeasy-api/sdk-test-suite/pull/3

awaiting decision on: https://speakeasyapi.slack.com/archives/C036B83TW3X/p1660737645161639

The tests/lint and building will fail until we merge https://github.com/speakeasy-api/speakeasy-schemas/pull/12


look for makepkg.conf in ~/.config

Now used by pacman 4.2.
Also get rid of the awkward awk usage.

Thanks a lot for the patches, they are now in master.
I merged the two first in a single commit, and also fixed a typo in the third patch - you did use 'pacaur' instead of 'pacman' in the userpacmandir variable ;)


Install protobuf with apt-get instead of pip

Add python3-protobuf to the existing apt-get install command, instead of installing it with pip
(added Signed-off-by: to the commit message to fix #8 being blocked by DCO)

Thanks, closing in favor of #10.


Added 3 Bash Books That Are Really Helpful, So Please Merge This Pull Request

What does this PR do?
Add resource(s)
For resources
Added 3 Books That Are Really Helpful
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Looks like the books you have provided are not permitted for free use by the license. This repo accepts only the resources that are truly free


Update Restlet or migrate back to 2.3.12

Describe the bug
Restlet has migrated over to Talend open source.
Major changes in JAR provisioning

Maven repo: https://maven.restlet.talend.com/; pointers to new Talend page for the framework.

To Reproduce
Attempt maven build pulling in Xponents dependencies inside a docker.
Error from JDK indicating "PKIX" exception validating source.
Expected behavior
better documentation on how to securely access Talend's https:// site.

Issue magically resolved through a variety of proxy and other related SSL issues. No longer an issue for the code here.


Welcome Page: Include links to browse views

As depicted in the mockups (v4) the welcome page should feature the links to the three browse sections (where, when, what).

closed in 9d8f7678883f8f5e041d17c53a28ce762a8cc580. We should add the link to the other sections when they are ready


Feature request: compactly supported covariance functions

I suppose there are no compactly supported covariance functions implemented yet? As they result in sparse covariance matrices, computations can scale perhaps to one or two orders of magnitude larger datasets. Of course, sparse matrices would need to be treated properly in order to gain this benefit. Would it require a huge change to the GPy core or would it be sufficient to just implement the relevant kernel classes, do you have any insight? Scikit.sparse offers a thin wrapper for SuiteSparse/CHOLMOD to access sparse Cholesky decompositions etc. I've also implemented some additional needed functions years ago but they haven't (yet) been merged into scikit.sparse. Do you think it would be useful and worth the effort, or would it just be too much work to integrate it? I might be able to implement this at some point (to some extent at least), but no promises at the moment. Anyway, I wanted to create this issue to hear your comments.
Another question: Does GPy include some tricks for modelling large datasets with short length-scale?

There is already an issue in GPy for sparse matrix support. No one had the time to do it yet, it would have to be crc matrices, as the slicing is being done along the columns.

Am 15.03.2016 um 07:29 schrieb Jaakko Luttinen<EMAIL_ADDRESS>I suppose there are no compactly supported covariance functions implemented yet? As they result in sparse covariance matrices, computations can scale perhaps to one or two orders of magnitude larger datasets. Of course, sparse matrices would need to be treated properly in order to gain this benefit. Would it require a huge change to the GPy core or would it be sufficient to just implement the relevant kernel classes, do you have any insight? Scikit.sparse offers a thin wrapper for SuiteSparse/CHOLMOD to access sparse Cholesky decompositions etc. I've also implemented some additional needed functions years ago but they haven't (yet) been merged into scikit.sparse. Do you think it would be useful and worth the effort, or would it just be too much work to integrate it? I might be able to implement this at some point (to some extent at least), but no promises at the moment. Anyway, I wanted to create this issue to hear your comments.
Another question: Does GPy include some tricks for modelling large datasets with short length-scale?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/SheffieldML/GPy/issues/333 https://github.com/SheffieldML/GPy/issues/333

Ok, thanks! I put it here for reference: https://github.com/SheffieldML/GPy/issues/128. You can close this as duplicate if you want.

I actually didn't quite understand the other issue, so I'm just making sure: it is about sparse covariance matrices, not sparse data matrices, right? This wasn't quite clear to me from that issue report, so just checking that this really is a duplicate.

Well, if the data matrix (X) is sparse, then the covariance matrix will be sparse as well : )

Am 15.03.2016 um 14:13 schrieb Jaakko Luttinen<EMAIL_ADDRESS>I actually didn't quite understand the other issue, so I'm just making sure: it is about sparse covariance matrices, not sparse data matrices, right? This wasn't quite clear to me from that issue report, so just checking that this really is a duplicate.
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/SheffieldML/GPy/issues/333#issuecomment-196839172 https://github.com/SheffieldML/GPy/issues/333#issuecomment-196839172

Hmm, I think they are separate things: The covariance matrix can be sparse even if the data matrix is dense (with compactly supported covariance functions). And on the other hand, if data sparsity means that there are lots of zeros in the matrix, I don't see how this would necessarily result in sparse covariance matrices - depends on your covariance function, I'd say.
I also think they serve slightly different purposes. You can use sparse data matrix to reduce the size of the data matrix, and then use dense covariance matrix with inducing inputs without any sparsity in the covariance matrix. Useful perhaps if you have very high dimensional input space? Sparse covariance matrices are useful for local (i.e., short lengthscale) functions in datasets with a large number of samples.

I think what Jaakko is after banded covariance matrix, which makes sense if your range of x values expands more than several times the length scale of the kernel. This way you can tackle large datasets, without giving the trade offs of the sparse approximation (or rather, different ones).
When studying GP I have also thought about it, but I haven't seen any papers on that (which means little, I am not the expert here).

Yes, banded covariance matrices are one special case of sparse covariance matrices. There are more discussion about compactly supported covariance funtions in the GP book by Rasmussen and Williams, and, for instance, in the paper "Modelling local and global phenomena with sparse Gaussian processes" by Vanhatalo and Vehtari (2008) (http://arxiv.org/ftp/arxiv/papers/1206/1206.3290.pdf).
The benefit of sparse covariance matrices (note: different from the "sparse" approximation) is that the Cholesky decomposition can be done by using special sparse matrix algorithms which can give significant speedups.
But as I said, I didn't understand the other issue almost at all, so I can't say whether this is a duplicate. To me it sounded like that issue was about sparse data which is a different matter.

Just wondering if there has been any update on this? On Matlab atleast taking the Cholesky decomposition of a sparse matrix was a lot faster than a non-sparse matrix. In that particular case I had multiplied with a compact support covariance function.
Would help immensely with large datasets as @jluttine mentioned.


KAFKA-3968: fsync the parent directory of a segment file when the file is created

Kafka does not call fsync() on the directory when a new log segment is created and flushed to disk.
The problem is that following sequence of calls doesn't guarantee file durability:
fd = open("log", O_RDWR | O_CREATE); // suppose open creates "log"
write(fd);
fsync(fd);
If the system crashes after fsync() but before the parent directory has been flushed to disk, the log file can disappear.
This PR is to flush the directory when flush() is called for the first time.

Thanks for the PR. Did we check the performance impact of this change?

Fixed comments from @junrao
Also addressed the two problems we discussed offline:

flush the parent of new segments during its first flush: added the !fileAlreadyExists check
flush the parent directory after flushing the log file and all index files

Please take a look @junrao

Ran bin/kafka-producer-perf-test.sh with default settings and 1KB record size.
The result before applying this PR:
1205625 records sent, 241125.0 records/sec (235.47 MB/sec), 127.4 ms avg latency, 204.0 ms max latency.
1177965 records sent, 235593.0 records/sec (230.07 MB/sec), 130.2 ms avg latency, 202.0 ms max latency.
1198860 records sent, 239772.0 records/sec (234.15 MB/sec), 128.2 ms avg latency, 197.0 ms max latency.
1182420 records sent, 236484.0 records/sec (230.94 MB/sec), 129.8 ms avg latency, 201.0 ms max latency.
1172340 records sent, 234468.0 records/sec (228.97 MB/sec), 131.0 ms avg latency, 204.0 ms max latency.
1197570 records sent, 239514.0 records/sec (233.90 MB/sec), 128.3 ms avg latency, 203.0 ms max latency.
1178820 records sent, 235764.0 records/sec (230.24 MB/sec), 130.2 ms avg latency, 225.0 ms max latency.
1173870 records sent, 234774.0 records/sec (229.27 MB/sec), 130.8 ms avg latency, 201.0 ms max latency.
1152990 records sent, 230598.0 records/sec (225.19 MB/sec), 133.1 ms avg latency, 212.0 ms max latency.

The result after applying this PR:
1147650 records sent, 229530.0 records/sec (224.15 MB/sec), 133.9 ms avg latency, 216.0 ms max latency.
1184085 records sent, 236817.0 records/sec (231.27 MB/sec), 129.7 ms avg latency, 213.0 ms max latency.
1213275 records sent, 242655.0 records/sec (236.97 MB/sec), 126.5 ms avg latency, 204.0 ms max latency.
1176105 records sent, 235221.0 records/sec (229.71 MB/sec), 130.5 ms avg latency, 211.0 ms max latency.
1143045 records sent, 228609.0 records/sec (223.25 MB/sec), 134.4 ms avg latency, 231.0 ms max latency.
1113390 records sent, 222678.0 records/sec (217.46 MB/sec), 138.0 ms avg latency, 236.0 ms max latency.
1133850 records sent, 226770.0 records/sec (221.46 MB/sec), 135.3 ms avg latency, 208.0 ms max latency.
1063410 records sent, 212682.0 records/sec (207.70 MB/sec), 144.6 ms avg latency, 216.0 ms max latency.
1128195 records sent, 225639.0 records/sec (220.35 MB/sec), 136.2 ms avg latency, 235.0 ms max latency.

No significant difference.

@junrao Thanks for the reiview. The previous test was run with default settings in config/server.properties, where log.segment.bytes=1073741824 (1GB). I changed it to log.segment.bytes=10737418 (~10MB) and re-ran the test. I, again, used 1KB record size.
The result before applying this PR:
384286 records sent, 76749.8 records/sec (74.95 MB/sec), 361.0 ms avg latency, 568.0 ms max latency.
486450 records sent, 96575.3 records/sec (94.31 MB/sec), 318.9 ms avg latency, 346.0 ms max latency.
476100 records sent, 94802.9 records/sec (92.58 MB/sec), 322.1 ms avg latency, 368.0 ms max latency.
473010 records sent, 94602.0 records/sec (92.38 MB/sec), 328.8 ms avg latency, 370.0 ms max latency.
462570 records sent, 92514.0 records/sec (90.35 MB/sec), 329.6 ms avg latency, 363.0 ms max latency.
462405 records sent, 92481.0 records/sec (90.31 MB/sec), 331.4 ms avg latency, 373.0 ms max latency.
475485 records sent, 95097.0 records/sec (92.87 MB/sec), 322.9 ms avg latency, 353.0 ms max latency.
475980 records sent, 95157.9 records/sec (92.93 MB/sec), 322.4 ms avg latency, 380.0 ms max latency.
476190 records sent, 95238.0 records/sec (93.01 MB/sec), 323.9 ms avg latency, 366.0 ms max latency.
474345 records sent, 94869.0 records/sec (92.65 MB/sec), 326.8 ms avg latency, 386.0 ms max latency.
488115 records sent, 96752.2 records/sec (94.48 MB/sec), 314.0 ms avg latency, 344.0 ms max latency.
485220 records sent, 97044.0 records/sec (94.77 MB/sec), 320.9 ms avg latency, 358.0 ms max latency.
487740 records sent, 97548.0 records/sec (95.26 MB/sec), 311.4 ms avg latency, 353.0 ms max latency.
493755 records sent, 98751.0 records/sec (96.44 MB/sec), 313.8 ms avg latency, 348.0 ms max latency.

The result after applying this PR:
253786 records sent, 50757.2 records/sec (49.57 MB/sec), 542.9 ms avg latency, 1099.0 ms max latency.
439665 records sent, 87862.7 records/sec (85.80 MB/sec), 351.7 ms avg latency, 487.0 ms max latency.
458580 records sent, 91716.0 records/sec (89.57 MB/sec), 337.6 ms avg latency, 417.0 ms max latency.
477015 records sent, 95403.0 records/sec (93.17 MB/sec), 322.0 ms avg latency, 359.0 ms max latency.
492705 records sent, 97584.7 records/sec (95.30 MB/sec), 313.8 ms avg latency, 344.0 ms max latency.
492240 records sent, 98448.0 records/sec (96.14 MB/sec), 314.3 ms avg latency, 358.0 ms max latency.
495810 records sent, 99162.0 records/sec (96.84 MB/sec), 308.9 ms avg latency, 357.0 ms max latency.
483675 records sent, 96735.0 records/sec (94.47 MB/sec), 317.1 ms avg latency, 365.0 ms max latency.
478230 records sent, 95646.0 records/sec (93.40 MB/sec), 319.8 ms avg latency, 365.0 ms max latency.
482295 records sent, 95560.7 records/sec (93.32 MB/sec), 321.1 ms avg latency, 427.0 ms max latency.
491430 records sent, 98286.0 records/sec (95.98 MB/sec), 315.5 ms avg latency, 373.0 ms max latency.
489615 records sent, 97923.0 records/sec (95.63 MB/sec), 314.0 ms avg latency, 367.0 ms max latency.
405855 records sent, 81154.8 records/sec (79.25 MB/sec), 374.0 ms avg latency, 485.0 ms max latency.
455400 records sent, 91061.8 records/sec (88.93 MB/sec), 338.5 ms avg latency, 416.0 ms max latency.
470325 records sent, 94065.0 records/sec (91.86 MB/sec), 327.5 ms avg latency, 424.0 ms max latency.
444465 records sent, 88893.0 records/sec (86.81 MB/sec), 343.3 ms avg latency, 426.0 ms max latency.
410010 records sent, 81789.3 records/sec (79.87 MB/sec), 374.5 ms avg latency, 485.0 ms max latency.
460455 records sent, 92091.0 records/sec (89.93 MB/sec), 338.6 ms avg latency, 411.0 ms max latency.

We can clearly see some differences. Is this a concern?

Failed tests are unrelated and passed on my local run.

@ccding : Thanks for the experimental results. It seems there is a 5-10% throughput drop with the new PR for 10MB segment. This may not be a big concern since it's an uncommon setting. It's interesting that the absolute throughput dropped significantly with 10MB segments compared with 1GB segment.
Could you redo the tests for 100MB segments? Thanks.

With 100MB segment size:
Before this PR:
422206 records sent, 84441.2 records/sec (82.46 MB/sec), 333.0 ms avg latency, 997.0 ms max latency.
1016955 records sent, 203391.0 records/sec (198.62 MB/sec), 152.7 ms avg latency, 230.0 ms max latency.
986760 records sent, 197352.0 records/sec (192.73 MB/sec), 155.5 ms avg latency, 293.0 ms max latency.
1025070 records sent, 205014.0 records/sec (200.21 MB/sec), 150.0 ms avg latency, 231.0 ms max latency.
1034265 records sent, 206853.0 records/sec (202.00 MB/sec), 148.5 ms avg latency, 212.0 ms max latency.
1025280 records sent, 205056.0 records/sec (200.25 MB/sec), 149.2 ms avg latency, 222.0 ms max latency.
1033485 records sent, 206697.0 records/sec (201.85 MB/sec), 148.6 ms avg latency, 212.0 ms max latency.
1036230 records sent, 207246.0 records/sec (202.39 MB/sec), 148.2 ms avg latency, 220.0 ms max latency.
1034385 records sent, 206877.0 records/sec (202.03 MB/sec), 148.4 ms avg latency, 216.0 ms max latency.
1013655 records sent, 201401.7 records/sec (196.68 MB/sec), 151.5 ms avg latency, 247.0 ms max latency.
1035300 records sent, 206481.9 records/sec (201.64 MB/sec), 149.1 ms avg latency, 213.0 ms max latency.
1035585 records sent, 207117.0 records/sec (202.26 MB/sec), 148.4 ms avg latency, 217.0 ms max latency.
1035015 records sent, 205197.3 records/sec (200.39 MB/sec), 149.4 ms avg latency, 231.0 ms max latency.

After this PR:
363796 records sent, 72759.2 records/sec (71.05 MB/sec), 389.1 ms avg latency, 1005.0 ms max latency.
992910 records sent, 198582.0 records/sec (193.93 MB/sec), 154.5 ms avg latency, 281.0 ms max latency.
989655 records sent, 197931.0 records/sec (193.29 MB/sec), 156.4 ms avg latency, 250.0 ms max latency.
1026900 records sent, 205380.0 records/sec (200.57 MB/sec), 149.6 ms avg latency, 217.0 ms max latency.
1033515 records sent, 206703.0 records/sec (201.86 MB/sec), 148.5 ms avg latency, 205.0 ms max latency.
1034775 records sent, 206955.0 records/sec (202.10 MB/sec), 148.5 ms avg latency, 201.0 ms max latency.
1035420 records sent, 207084.0 records/sec (202.23 MB/sec), 148.3 ms avg latency, 210.0 ms max latency.
1013130 records sent, 202626.0 records/sec (197.88 MB/sec), 151.6 ms avg latency, 216.0 ms max latency.
1010295 records sent, 202059.0 records/sec (197.32 MB/sec), 150.9 ms avg latency, 215.0 ms max latency.
1022640 records sent, 204528.0 records/sec (199.73 MB/sec), 151.2 ms avg latency, 219.0 ms max latency.
1015950 records sent, 203190.0 records/sec (198.43 MB/sec), 151.2 ms avg latency, 232.0 ms max latency.
1033725 records sent, 206745.0 records/sec (201.90 MB/sec), 148.5 ms avg latency, 208.0 ms max latency.
1024905 records sent, 204981.0 records/sec (200.18 MB/sec), 149.9 ms avg latency, 213.0 ms max latency.
1035720 records sent, 207144.0 records/sec (202.29 MB/sec), 148.3 ms avg latency, 203.0 ms max latency.
998625 records sent, 199725.0 records/sec (195.04 MB/sec), 153.8 ms avg latency, 214.0 ms max latency.

It's interesting that the absolute throughput dropped significantly with 10MB segments compared with 1GB segment.

I am thinking it is the cost of the extra flush. We have one extra flush per segment, which is 1 extra flush per 10,000 records for 10MB segments and 1KB records. If it were 1GB segments, there is 1 extra flush per 100,000 records: 1/100 of the cost.

Would the perf impact of this change be more significant with a larger number of partitions?


Support Option in contracttype

We should allow using Option in UDT structs. Currently some necessary trait(s) are missing implementation, such as:
the trait From<&std::option::Option>is not implemented forstellar_xdr::ScVal`
There is seemingly no good reason to not support this, so we should implement the missing traits.

Any approach to solve this? @dmkozh

To get around it for now you can create your own Option type. Not optimal, but that's what I've done to get around this.

Yes, we also opted to create our own Option type. I'm trying to solve this issue in the source code


298/find replacement packages for the styleguide vrt

Partial fix for #298 — this adds a component library as a replacement for the previous styleguide.

Adds storybook
Moves the comments in sass files in md files
Uses a storybook plugin to display the markdown next to the story
groups the files for each CSS class into its own folder as each now has three files

Advantages:

We’re familiar with storybook
bitstyles is a set of UI components more than a design system, requiring a component library more than a styleguide
Documentation is easier to read than it was in comments, both in the MD file, and in storybook
We can run snapshot and VRT tests against the fullscreen version of each story

Disadvantages:

More folder structure.
Right now node-sass is falling behind the specs for sass — index imports should work (like js, where you can import from a component’s folder, and will automatically get the index.js file without specifying that explicitly), but they currently do not. To avoid having imports like @import 'bitstyles/objects/list-inline/list-inline';, this feature is required now we have per-class folders. he workaround is to name the files _.scss which looks odd, but will hopefully be temporary, and not so different to the equally-meaningless index.scss.

Thanks so much for your feedback @lwassermann! 🙏
Responses, in order:

The base stories/examples are there so that we can have snapshots of those elements with no classes applying styles (there’re currently still no VRT snapshots — this PR will allow that to restart)

The base styles themselves are very barebones, being just a few colors and text sizes that are largely inherited (and the normalize/reset css). This was an architectural decision taken when we created bitstyles, to minimise the amount of overriding we needed to do. With this approach, if you don’t apply one of our object-level input classes to your input, all you get is font-sizes and text colors that match the rest of your site. This seemed a reasonable base on which to style them as you want in your current project, with minimal overriding.
It also follows the atomic/BEM/ITCSS system — applying styles only through classes in order to avoid specificity issues.
This is something I’ve wanted to revisit though — I can see it being useful having (some of?) the styles from say o-input--text (like padding, color overrides, border) applied as default to all input types that could be considered 'text'. Overriding those styles later on with a class would not present specificity issues (as the selector is just an element, it’s a lower specificity), and though there may be some properties that need to be re-declared, it would provide much easier out-of-the-box usage.
Any thoughts on that? Making the change would be better done in another branch anyway, I think.

‘The text-align: justify example content’ & ‘The no-margin stories don't show much’: Yup, that’s true. I would add both of these points to a new issue to update the examples all in one go, together (I’m sure there are other places we could improve the docs & examples).

I’ll merge this now, as it’s a big PR that others depend on — from feedback it seems the general approach/choice of tech is acceptable. I’ve created issues to investigate & fix the issues raised in the discussion above:

#315
#316


Fix using Docker plugin with multi-arch manifests

I messed up and this is missing two fixes that are also blockers.

Let's please merge this and tag a release asap. We are going to be depending on this in freedesktop-sdk.


Need to throttle updates?

I'm using this with Raspberry Pi and Rainbow HAT.  If I leave it running the temperature shown steadily increases.  It might be case that I need to add heatsink to the processor but wondering if perhaps the code should throttle number of updates it does.  Not a big issue in the scheme of things (realise this is just a demo).

@joreilly I think this is coming from the apa102 RGB LED that are just above the temperature sensor.
You could try to dim them off and see if it affect the temperature.

I commented out code to set LEDs but still seeing temperature steadily going up.  I also tried passing in my longer delay (1000000 microseconds  for example) to mSensorManager.registerListener() but it didn't seem to take effect.

Pimoroni recently added the following note to the product page

Temperature readings are affected by heat radiated from your Pi’s CPU and the onboard LEDs; calibration can help to correct temperature readings. bstrobl, on the Raspberry Pi forums, suggests to use the formula: corrected temp. = measured temp. - (CPU temp. - measured temp.) / 2. Using a Mini Black HAT Hack3r can also help.

Maybe we could implement that as an helper function in the Rainbow Hat driver
/cc @gguuss

Someone came up with an algo to take into effect the cpu temp - will post back if I find it. Here is something to keep the display from flickering with each change. It also converts to Fahrenheit:
private SensorEventListener mTemperatureListener = new SensorEventListener() {
    @Override
    public void onSensorChanged(SensorEvent event) {
        float newTemperature = event.values[0];
        if (Math.abs(newTemperature - mLastTemperature) > 1) {
            mLastTemperature = event.values[0];
            Log.d(TAG, "sensor changed: " + mLastTemperature);
            if (mDisplayMode == DisplayMode.TEMPERATURE) {
                float fahrenheit = 32 + (mLastTemperature * 9 / 5);
                updateDisplay(fahrenheit);
            }
        }
    }

    @Override
    public void onAccuracyChanged(Sensor sensor, int accuracy) {
        Log.d(TAG, "accuracy changed: " + accuracy);
    }
};

did anyone try the pimoroni suggestion? what were the results?

Pimoroni recently added the following note to the product page

Temperature readings are affected by heat radiated from your Pi’s CPU and the onboard LEDs; calibration can help to correct temperature readings. bstrobl, on the Raspberry Pi forums, suggests to use the formula: corrected temp. = measured temp. - (CPU temp. - measured temp.) / 2. Using a Mini Black HAT Hack3r can also help.

Maybe we could implement that as an helper function in the Rainbow Hat driver
/cc @gguuss

You cannot read the CPU temp on Android Things but even if you could this would not work. I have tried to move the Rainbow Hat away from the Android Things board via a 20cm long 2x20 GPIO cable. The temp sensor still measures data from another reality, e.g. 30C+ at normal room temp. This is a design flaw in the Rainbow Hat itself.


Undocumented but implemented log messages

Feature description
Documents for logs that are already implemented in the source code but not yet documented
Problem and motivation
Some logs are implemented and found in the source code, but they are not documented. CDC has rules based on interesting ones so that potential errors can be monitored as well. It would be great that they are kept if they don't disobey data privacy regulations.
Is this something you're interested in working on
No.

Add Log Message for Cleanup to Documentation

fixed with https://github.com/eu-federation-gateway-service/efgs-federation-gateway/issues/189


docs: added new issue templates, removed old templates

Preflight Checklist

[x] I have read the Contributing Guidelines for this project.
[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the pull request tracker for a Pull Request (PR) that matches the one I want to submit, without success.

Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:

added new github issue templates
removed old issue templates

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] Documentation content changes
[ ] Other (please describe):

Does this introduce a breaking change?

[ ] Yes
[x] No

Codecov Report

Merging #1663 (4eb6219) into master (ab917b0) will decrease coverage by 3.10%.
The diff coverage is 53.63%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master    #1663      +/-   ##
==========================================
- Coverage   54.85%   51.75%   -3.10%
==========================================
  Files          49      133      +84
  Lines        1659     4678    +3019
  Branches      406     1222     +816
==========================================
+ Hits          910     2421    +1511
- Misses        671     2084    +1413
- Partials       78      173      +95

Impacted Files
Coverage Δ

...ts/sbb-accordion-item/sbb-accordion-item.events.ts
100.00% <ø> (ø)

...mponents/sbb-accordion-item/sbb-accordion-item.tsx
0.00% <0.00%> (-37.21%)
:arrow_down:

...onents/sbb-autocomplete/sbb-autocomplete.events.ts
100.00% <ø> (ø)

src/components/sbb-checkbox/sbb-checkbox.events.ts
0.00% <ø> (ø)

src/components/sbb-header/sbb-header.tsx
27.63% <ø> (ø)

src/components/sbb-icon/sbb-icon-request.ts
70.00% <ø> (ø)

src/components/sbb-icon/sbb-icon-validate.ts
45.16% <ø> (ø)

src/components/sbb-icon/sbb-icon.tsx
92.30% <ø> (ø)

src/components/sbb-image/sbb-image.helper.tsx
0.00% <ø> (-64.52%)
:arrow_down:

src/components/sbb-image/sbb-image.tsx
0.00% <ø> (-62.97%)
:arrow_down:

... and 142 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[bug] Marking excluded node as failed, yields error

Version
Build/Run method

[x] Docker
[ ] PKG
[ ] Manually built (git clone - npm install - npm run build )

zwavejs2mqtt version: d98fd7e8541a722b89a0e65fcfaca14b6b589cb2
Describe the bug
I excluded a node, and wanted to re-include it with the same id. Couldn't do that, as the replace failed required it to be failed - so I used "mark node as failed". That in turn errored out. I have not tested marking a working node as failed.
zwavejs2mqtt_1  | 2021-01-19 18:17:41.975 INFO ZWAVE: Node 28: value added 28-38-5-duration => [Duration: 0seconds]
zwavejs2mqtt_1  | 2021-01-19 18:17:42.361 INFO ZWAVE: Node 28: value added 28-38-5-currentValue => 99
zwavejs2mqtt_1  | 2021-01-19 18:17:42.362 INFO ZWAVE: Node 28: value added 28-38-5-Up => undefined
zwavejs2mqtt_1  | 2021-01-19 18:17:42.362 INFO ZWAVE: Node 28: value added 28-38-5-Down => undefined
zwavejs2mqtt_1  | 2021-01-19 18:17:42.365 INFO ZWAVE: Node 28 ready: Logic Group - ZDB5100 (MATRIX Switch with Dimmer and Backlight)
zwavejs2mqtt_1  | 2021-01-19 18:17:42.372 INFO APP: Zwave api call: markNodeAsFailed [ 20, [length]: 1 ]
zwavejs2mqtt_1  | 2021-01-19 18:17:42.373 INFO ZWAVE: this.driver.controller.markNodeAsFailed is not a function markNodeAsFailed
zwavejs2mqtt_1  | 2021-01-19 18:17:42.715 INFO ZWAVE: Node 30 is alive
zwavejs2mqtt_1  | 2021-01-19 18:17:43.074 INFO ZWAVE: Node 30: value added 30-91-0-slowRefresh => true
zwavejs2mqtt_1  | 2021-01-19 18:17:43.074 INFO ZWAVE: Node 30: value added 30-91-0-scene-001 => undefined
zwavejs2mqtt_1  | 2021-01-19 18:17:43.074 INFO ZWAVE: Node 30: value added 30-91-0-scene-002 => undefined
zwavejs2mqtt_1  | 2021-01-19 18:17:43.075 INFO ZWAVE: Node 30: value added 30-91-0-scene-003 => undefined
zwavejs2mqtt_1  | 2021-01-19 18:17:43.075 INFO ZWAVE: Node 30: value added 30-91-0-scene-004 => undefined

To Reproduce
N/A
Expected behavior
Function fails because the node is excluded properly, or works, and fails an excluded node.
Additional context
N/A

@LordMike I think that the actual zwave js version still doesn't have the api?

@LordMike I think that the actual zwave js version still doesn't have the api?

Exciting - it's that new? :)
If so - we can just close this.

Exciting - it's that new? :)
If so - we can just close this.

@LordMike It has been removed after some thoughts, check #289

@LordMike It has been removed after some thoughts, check #289


Authentication failing on submission to the WebAPI

2017-07-20 06:20:07,168 interface:WARNING QC metrics failed to upload. Status 401: {"_error": {"code": 401, "message": "Please provide proper credentials"}, "_status": "ERR"}

@chrisfilo this is maybe why we are getting less measures lately
@rwblair any chance that something changed in the Web API end?

Can you reproduce this locally? Did you try 0.9.6?

@rwblair disregard this. It is my fault. Thanks @chrisfilo for walking me to the solution.

Using the official 0.9.7-rc5 it worked. Nothing to look at here. Thanks and sorry for the noise.

I also get this error

Are you using Docker or Singularity?

Neither, just did pip install
Op vr 15 jun. 2018 om 11:09 schreef Chris Filo Gorgolewski <
<EMAIL_ADDRESS>
Are you using Docker or Singularity?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/poldracklab/mriqc/issues/594#issuecomment-397561697,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOdDLxdF4noCrCwW6n4y8WghDjU1s7mjks5t83nXgaJpZM4Odp1Q
.

2018-06-15 10:58:23,131 interface:WARNING QC metrics upload failed to create an ID for the record uplOADED. rEsponse from server follows: {"_error": {"message": "Please provide proper credentials", "code": 401}, "_status": "ERR"}
2018-06-15 10:58:23,132 interface:WARNING QC metrics failed to upload. Status 401: {"_error": {"message": "Please provide proper credentials", "code": 401}, "_status": "ERR"}
mriqc --version
mriqc v0.11.0

To avoid the authentication issue you need to disable the QC metric
crowdsourcing on the command line. See --help for details.
Best,
Chris
PS Apologies for brevity and potential typos. This message was composed on
a phone.
On Fri, Jun 15, 2018, 5:16 PM Marcel Zwiers<EMAIL_ADDRESS>wrote:

2018-06-15 10:58:23,131 interface:WARNING QC metrics upload failed to
create an ID for the record uplOADED. rEsponse from server follows:
{"_error": {"message": "Please provide proper credentials", "code": 401},
"_status": "ERR"}
2018-06-15 10:58:23,132 interface:WARNING QC metrics failed to upload.
Status 401: {"_error": {"message": "Please provide proper credentials",
"code": 401}, "_status": "ERR"}
mriqc --version
mriqc v0.11.0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/poldracklab/mriqc/issues/594#issuecomment-397563543,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOkp8TTfV3-gliT2F25zTs6cQ3wMT8Wks5t83t_gaJpZM4Odp1Q
.

You mean using --no-sub (turn off submission of anonymized quality metrics
to MRIQC's metrics repository)? Sure I won't get this error then, but I
thought anyone could upload their QC metrics?
Op vr 15 jun. 2018 om 11:39 schreef Chris Filo Gorgolewski <
<EMAIL_ADDRESS>
To avoid the authentication issue you need to disable the QC metric
crowdsourcing on the command line. See --help for details.
Best,
Chris
PS Apologies for brevity and potential typos. This message was composed on
a phone.
On Fri, Jun 15, 2018, 5:16 PM Marcel Zwiers<EMAIL_ADDRESS>wrote:

2018-06-15 10:58:23,131 interface:WARNING QC metrics upload failed to
create an ID for the record uplOADED. rEsponse from server follows:
{"_error": {"message": "Please provide proper credentials", "code": 401},
"_status": "ERR"}
2018-06-15 10:58:23,132 interface:WARNING QC metrics failed to upload.
Status 401: {"_error": {"message": "Please provide proper credentials",
"code": 401}, "_status": "ERR"}
mriqc --version
mriqc v0.11.0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/poldracklab/mriqc/issues/594#issuecomment-397563543
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAOkp8TTfV3-gliT2F25zTs6cQ3wMT8Wks5t83t_gaJpZM4Odp1Q
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/poldracklab/mriqc/issues/594#issuecomment-397569194,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOdDL-RRj9PqrE-apt6RJcWJbH5PgiCVks5t84DTgaJpZM4Odp1Q
.

Oh, you are right Marcel. We bake the authentication token in when building
the docker image, and seemingly we don't for the pypi package. I'll have a
look and see if that can easily be done.
But for now, I don't think you'll be able to share your IQMs when run as a
python package :(.
On Fri, Jun 15, 2018 at 6:05 PM, Marcel Zwiers<EMAIL_ADDRESS>wrote:

You mean using --no-sub (turn off submission of anonymized quality metrics
to MRIQC's metrics repository)? Sure I won't get this error then, but I
thought anyone could upload their QC metrics?
Op vr 15 jun. 2018 om 11:39 schreef Chris Filo Gorgolewski <
<EMAIL_ADDRESS>
To avoid the authentication issue you need to disable the QC metric
crowdsourcing on the command line. See --help for details.
Best,
Chris
PS Apologies for brevity and potential typos. This message was composed
on
a phone.
On Fri, Jun 15, 2018, 5:16 PM Marcel Zwiers<EMAIL_ADDRESS>wrote:

2018-06-15 10:58:23,131 interface:WARNING QC metrics upload failed to
create an ID for the record uplOADED. rEsponse from server follows:
{"_error": {"message": "Please provide proper credentials", "code":
401},
"_status": "ERR"}
2018-06-15 10:58:23,132 interface:WARNING QC metrics failed to upload.
Status 401: {"_error": {"message": "Please provide proper credentials",
"code": 401}, "_status": "ERR"}
mriqc --version
mriqc v0.11.0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/poldracklab/mriqc/issues/594#
issuecomment-397563543
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAOkp8TTfV3-
gliT2F25zTs6cQ3wMT8Wks5t83t_gaJpZM4Odp1Q
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/poldracklab/mriqc/issues/594#issuecomment-397569194
,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOdDL-RRj9PqrE-
apt6RJcWJbH5PgiCVks5t84DTgaJpZM4Odp1Q>

.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/poldracklab/mriqc/issues/594#issuecomment-397575564,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAkhxuLT01v33YxuWmB5il79gNxBKritks5t84bSgaJpZM4Odp1Q
.


Manually remove @mentions from the msg.content because msg.safeContent doesn't support <#channel mentions>

nvm


Can now drag the scrubber during video playback

Fixes #59.
Dragging the scrubber during playback now pauses the video and then resumes play after the dragging is stopped

Updated the PR, the test deployment should now work as expected @lkiesow

Updated the PR, the test deployment should now work as expected @lkiesow


Add documentation for AWS ACL options

Hi Owncast team,
I spent about an hour trying to debug my S3 configuration earlier and discovered that I had created a bucket with the ACLs disabled. I'm not sure if this is a default setting specific to my account or if other users might see this as well, but I've been able to recreate it during the S3 bucket creation process. The defaults that I see when creating an S3 bucket are attached in a screenshot below.
Since the docs state that the only necessary configuration change is to "Uncheck 'Block all public access'" I wanted to be sure that this important option would not be missed by future users as well.
Thanks! Happy to discuss further.

Sounds good! Sorry you had to debug so long. That's a big of a double edged sword with these kind of things as documentation about 3rd party services can go out of date or be incorrect and it's easy not to catch it, but I think it's better than not having any at all, but I'm not sure.
Thanks for the update!


Update defer.md

Hi.
This modification proposal provides several comments that might improve the comprehension of the Defer subject. Each proposal is inserted above the point I think a clarification is due. Regards.
IL.
What are you changing in this pull request and why?

Checklist

[x] Review the Content style guide so my content adheres to these guidelines.
[ ] For docs versioning, review how to version a whole page and version a block of content.
[ ] Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding or removing pages (delete if not applicable):

[ ] Add/remove page in website/sidebars.js
[ ] Provide a unique filename for new pages
[ ] Add an entry for deleted pages in website/vercel.json
[ ] Run link testing locally with npm run build to update the links that point to deleted pages

Will reopen as an issue


How to input video URL

I don't know what's my wrong. could you help me!

@blackcodersec , can you pull the main branch again and check if it's working now? I've created an empty init file to guarantee that it will be treated as a module

I pull the main branch, but same issue. not working. is my command right?

@tiemi hello could you give me solution?

@blackcodersec , I've updated the requirements because it was missing one package (the keyphrase_vectorizers). Also, I've updated the description of the read.me file giving an example of the video URL and how to create a virtual environment with Conda. Thank you for letting me know. Can you check one last time?

The video that you are trying to convert to a blog post doesn't have audio, just a soundtrack. So, I would recommend you try another tutorial. For example:  https://www.youtube.com/watch?v=kibx5BR6trA&ab_channel=Deepgram


Your models have changes that are not yet reflected in a migration

On Django 1.7, oscar 1.1, after running manage.py migrate for the first time, it seems to run fine without error.
Subsequent runs of managy.py migrate give the following error:
...
Running migrations:
  No migrations to apply.
  Your models have changes that are not yet reflected in a migration, and so won't be applied.
  Run 'manage.py makemigrations' to make new migrations, and then re-run 'manage.py migrate' to apply them.

If I run manage.py makemigrations the following files are created:
site-packages/oscar/apps/customer/migrations/0002_auto_20150723_2301.py:
# -*- coding: utf-8 -*-
from __future__ import unicode_literals

from django.db import models, migrations
import oscar.models.fields.autoslugfield
import django.core.validators

class Migration(migrations.Migration):

    dependencies = [
        ('customer', '0001_initial'),
    ]

    operations = [
        migrations.AlterField(
            model_name='communicationeventtype',
            name='code',
            field=oscar.models.fields.autoslugfield.AutoSlugField(populate_from=b'name', validators=[django.core.validators.RegexValidator(regex=b'^[a-zA-Z_][0-9a-zA-Z_]*$', message="Code can only contain the letters a-z, A-Z, digits, and underscores, and can't start with a digit.")], editable=False, max_length=128, separator='_', blank=True, help_text='Code used for looking up this event programmatically', unique=True, verbose_name='Code'),
            preserve_default=True,
        ),
    ]

site-packages/oscar/apps/catalogue/migrations/0006_auto_20150723_2301.py:
# -*- coding: utf-8 -*-
from __future__ import unicode_literals

from django.db import models, migrations
import django.core.validators
import oscar.core.validators

class Migration(migrations.Migration):

    dependencies = [
        ('catalogue', '0005_auto_20150604_1450'),
    ]

    operations = [
        migrations.AlterField(
            model_name='productattribute',
            name='code',
            field=models.SlugField(max_length=128, verbose_name='Code', validators=[django.core.validators.RegexValidator(regex=b'^[a-zA-Z_][0-9a-zA-Z_]*$', message="Code can only contain the letters a-z, A-Z, digits, and underscores, and can't start with a digit"), oscar.core.validators.non_python_keyword]),
            preserve_default=True,
        ),

Seems a new issue caused by the Validator change
https://github.com/django-oscar/django-oscar/commit/700242330a6d3fe12159bff276c94b349bfadde6

Looks like the following commits are responsible:
https://github.com/django-oscar/django-oscar/commit/276eba92491acbc99663363115ed491b2342670d
https://github.com/django-oscar/django-oscar/commit/700242330a6d3fe12159bff276c94b349bfadde6

This migrations break django 1.8/py3 makemigrations:
Traceback (most recent call last):
  File "./manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/mnt/data2/work/graymalin/lib/python3.4/site-packages/django/core/management/__init__.py", line 354, in execute_from_command_line
    utility.execute()
  File "/mnt/data2/work/graymalin/lib/python3.4/site-packages/django/core/management/__init__.py", line 346, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/mnt/data2/work/graymalin/lib/python3.4/site-packages/django/core/management/base.py", line 394, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/mnt/data2/work/graymalin/lib/python3.4/site-packages/django/core/management/base.py", line 445, in execute
    output = self.handle(*args, **options)
  File "/mnt/data2/work/graymalin/lib/python3.4/site-packages/django/core/management/commands/makemigrations.py", line 125, in handle
    migration_name=self.migration_name,
  File "/mnt/data2/work/graymalin/lib/python3.4/site-packages/django/db/migrations/autodetector.py", line 43, in changes
    changes = self._detect_changes(convert_apps, graph)
  File "/mnt/data2/work/graymalin/lib/python3.4/site-packages/django/db/migrations/autodetector.py", line 186, in _detect_changes
    self.generate_altered_fields()
  File "/mnt/data2/work/graymalin/lib/python3.4/site-packages/django/db/migrations/autodetector.py", line 850, in generate_altered_fields
    if old_field_dec != new_field_dec:
  File "/mnt/data2/work/graymalin/lib/python3.4/site-packages/django/core/validators.py", line 55, in __eq__
    self.regex.pattern == other.regex.pattern and
AttributeError: 'bytes' object has no attribute 'pattern'

problem in regex bytes, without b it's work fine
https://botbot.me/freenode/django-oscar/2016-03-03/?msg=61450113&page=1

@slav0nic I ran across the same issue. Fixed it and submitted pull-request #2030.

How come that in the customer migration editable=False is set?

Should be fixed in 1.2.2 / master


Make file an explicit dependency

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?

Per https://github.com/Linuxbrew/brew/issues/287#issuecomment-284471277 we have a dependency on file, but it's not explicitly stated.
Put it in a) the installation instructions for both Debian/Ubuntu and Red Hat-alikes
and b) the Dockerfile.
See also Linuxbrew/docker#6

Merged. Thanks, Bob!


Massive refactor

too much for this comment. check out the DOCS.md

merging to move forwards.  will be moving to a new repo anyway (the one in package.json)


Fix HTTParty response check

This resolves a deprecation warning from the HTTParty gem.

HTTParty will no longer override response#nil?. This functionality will be
removed in future versions. Please, add explicit check response.body.nil? || response.body.empty?.
For more info refer to: https://github.com/jnunemaker/httparty/issues/568.

Simon got there first!


A few tweaks for README

This pull request makes a few teaks on the README.md file.

Why did you actually remove the @boxbilling. I believe that is the actual Twitter handle.

@timothygwebb, I didn't remove the Twitter handle. I just renamed the link's text from "@boxbilling" to "Twitter", like how it is for the Facebook link. The link still points to twitter.com/boxbilling

@evrifaessa  Thanks for the clarification.


Fixed android bounding box

Summary

This PR fixes #19637.
Summary of the issue: on Android, transformed touchables have press issues because the touchable's measurements are incorrect in the release phase. UIManager.measure() returns an incorrect size and position as explained here
This is easily seen with the inspector :
Screenshot of a { scale: 2 } transform
The real view (scaled) is in pink, the incorrect touchable area is in blue.

Screenshot of a { rotateZ: "-45deg" } transform
The real view (rotated) is in pink, the incorrect touchable area is in blue.

Changelog

[Android] [Fixed] - Fix UIManager.measure()
Test Plan

Android now produces the same results as iOS as seen on these screenshots

Android without fix
Android with fix
iOS

Thanks for this contribution! Are you aware that on this blue area on iOS does not mean that this area is touchable?
This is how we virtualise touchable areas on iOS:

So clickable area is limited to bounds on component. Can you confirm that your code works like these?
Please consider using touchables button in an inspector while attaching screenshot :)

Yes, I know the blue rectangle represents the bounds, but it's the bounds that are used to detect the LEAVE_PRESS_RECT event.

You press in the touchable area, pressIn is triggered.
You move a bit. Since the bounds are incorrect, a LEAVE_PRESS_RECT is triggered.
You release your touch. Since you are considered out of the "press rect", pressOut in NOT triggered.

You can see that the bounds are used for step 2 :

_remeasureMetricsOnActivation() is called
UIManager.measure() is called, the results are store in positionOnActivate and dimensionsOnActivate which are used to compute isTouchWithinActive  and to trigger LEAVE_PRESS_RECT.

Does this clarify things?
Sorry if this wasn't included in the PR description but when I investigated this issue a year ago the Touchable.js code was very different and I haven't a good understanding of this new code.

@floriancargoet could you please address my comment related to the missing Javadoc and we should be good to merge this PR. @mdvacca what do you think?


[Bug] Fix line height in editor

I use Acode on tablet.
Font size 12px is too small to use.
But with any font size (except for 12px), I get every line cut on top.
Size: 14px

Size: 16px

Please fix it.
Make line height calculated from font-size.

I've fixed it in latest version <IP_ADDRESS>


Updating the readme file in autorest to use latest Api spec preview

Regenerated the Azure SDK by updating readme file in the autorest.md to use the latest API spec preview.

Hi @jsquire , I have changed it to public now. Please review.

Hi @jsquire , I have changed it to public now. Please review.

You do not have a public Azure membership nor do you have the needed "write" permissions.   Please refer to the links that I shared above for more details and assistance.

Hi @jsquire , I have now got write access and joined azure org as public.

API change check
API changes are not detected in this pull request.


How could I use this on my html5 page ?

My html5 application need the qr scan feature, but the project is an app
How could I use the on my html5 page with javascript ?

@Lynn-cc Issues in github are meant for issue in app. This is not a helping forum. Go to stackoverflow and create questions so people can help you.


Fix mkdir issue

Introduced in f551c0ad124bb8ab782f7dd90ab30ae9cc49fafa
This actually breaks Beaker, because the host variable is nil:
/opt/rubies/2.1.2/lib/ruby/gems/2.1.0/bundler/gems/beaker-136d9c3cccbc/lib/beaker/host.rb:305:in `mkdir_p': undefined local variable or method `host' for #<FreeBSD::Host:0x007f8abe0e20b8> (NameError)
	from /opt/rubies/2.1.2/lib/ruby/gems/2.1.0/bundler/gems/beaker-136d9c3cccbc/lib/beaker/host.rb:364:in `block in do_scp_to'
	from /opt/rubies/2.1.2/lib/ruby/gems/2.1.0/bundler/gems/beaker-136d9c3cccbc/lib/beaker/host.rb:361:in `each'
	from /opt/rubies/2.1.2/lib/ruby/gems/2.1.0/bundler/gems/beaker-136d9c3cccbc/lib/beaker/host.rb:361:in `do_scp_to'
	from /opt/rubies/2.1.2/lib/ruby/gems/2.1.0/bundler/gems/beaker-136d9c3cccbc/lib/beaker/dsl/helpers.rb:207:in `block in scp_to'

Can one of the admins verify this patch?

Any thoughts @liamjbennett? Maybe switching to explicit declaration of bitvise connection instead?

Good catch. :+1:

Needs a rebase.

More review comments, also needs rebase.

@anodelman Just rebased.
You'd already fixed the no local variable bit in 9c32cac7a7a5bf52f21b628b14ddba9bfc44510c, I thought it would work on PSWindows, but I noticed the logic around creating a directory was wrong. This should fix it (tested on a Bitvise windows box)

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/615/
:red_circle: Test failed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/625/
:red_circle: Test failed.

failure unrelated to change. :+1:


Added error handing

We check if user:

has metamask installed
has metamask unlocked
is connected to correct network

If not, we show him the appropriate error message,

Good job! Let me handle the merge conflicts.


GLControl documentation and code improvements

Improved slightly documentation and fixed bugs:

Colors ranged [0, 1) instead of [0, 1]
Control wasn't drawn on application start

Let me know when this is ready for review.

It's already ready for review.
Please make sure to nitpick on documentation; not that good at it


Ensure mappings end up in final build image

Codecov Report

Merging #79 (95512fb) into main (96388ae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   85.98%   85.98%
=======================================
  Files           8        8
  Lines         835      835
=======================================
  Hits          718      718
  Misses         84       84
  Partials       33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96388ae...95512fb. Read the comment docs.


Centering items when all items are in view.

Thanks for the great script.
What I want to do is center the items on screen when all items are visible on screen. As a default they always start on the right .
I tried
.v-hl-container {
justify-content: center;
}
This works when all items on screen are visible, but then when all items cannot fit on screen it causes a problem in that elements expand both to the left and right out of the viewport and the initial view position is the center of the row.
Is there a simple CSS way to achieve this ? It would seem like a common user case.
Thanks

After an awful lot of messing about and trying different things, I got it to center on the screen when there are less items than the full width of the viewport by doing the following
<style> .v-hl-container {   margin: 0 auto -30px !important;   width: auto !important; } </style>
It would be nice if this could be an option in the CSS core as I'm not a fan of using !important to force override styles.


[BUG] Photo upload not working

Describe the bug
The candidate picture is not loaded in the site.
To Reproduce
Steps to reproduce the behaviour:

Create a new resume
Upload a photo
The photo is not loaded and showed

Expected behaviour
The photo should be loaded and showed in the resume
Desktop (please complete the following information):

OS: Linux
Browser: Firefox
Version [e.g. 22]

Additional context
The browser console says the following:
Uncaught (in promise) Object { statusCode: 500, message: "Internal server error" }

Duplicate of https://github.com/AmruthPillai/Reactive-Resume/issues/658, resolved now.
Should be fixed on production in the next version (will be up in few minutes).

Thank you, I did not see #658, sorry for that.


did:dht resolution fails

Hitting the following error when attempting to resolve did:dht DIDs:
code:
const did = await DidDhtMethod.create();
const didResolutionResult = await DidDhtMethod.resolve({ didUrl: did.did });

error:
Error: Invalid SignedPacket bytes length, expected at least 72 bytes but got: 25
  at SignedPacket.fromBytes (file:///Users/moe/code/tbd/ose/web5/node_modules/pkarr/lib/signed_packet.js:75:13)
  at Pkarr.relayGet (file:///Users/moe/code/tbd/ose/web5/node_modules/pkarr/index.js:46:25)

This is a result of attempting to fetch the DID before it has published, which takes about 10 seconds. The error can be better but I wouldn't classify it as a bug.

kk thanks! this works:
const sleep = (time) => new Promise(resolve => setTimeout(resolve, time));

const did = await DidDhtMethod.create({ publish: true });

await sleep(10_000);
const didResolutionResult = await DidDhtMethod.resolve({ didUrl: did.did });

agree that it's not a bug and agree that the error message could be better. removed the bug label and updated the github issue description to reflect


V3: "arcgiscache" folder not updated

Following V3 release which closed #166, I wanted to update ArcGIS Server cache directory using the new version but it did not work.
My ArcGIS Enterprise is already configured and I wanted to update the cache directory by moving it from C:\ to D:\ and though the configuration is successfull the ArcGIS Server site is still using C:\ for its cache directory.
Having a look at the code but not being a DSC expert, I am under the impression that it is only used in 'Invoke-CreateSite'. Can't it be updated ? Or is my config maybe wrong ?
Here is the relevant server config:
"Server": {
	"LicenseFilePath": "\\pathToLicence\\portal.prvc",
	"Installer": {
		"Path": "\\pathToSetup\\ArcGIS_Server_Windows_1071_169677.exe",
		"InstallDir": "C:\\Program Files\\Arcgis\\Server",
		"InstallDirPython": "C:\\Python27"
	  },
	  "ServerDirectoriesRootLocation": "C:\\arcgisserver\\directories",
            "ConfigStoreLocation": "C:\\arcgisserver\\config-store",
            "LocalRepositoryPath": "C:\\arcgisserver\\local",
            "ServerLogsLocation": "C:\\arcgisserver\\logs",
            "ServerDirectories": [
                {
                    "name": "arcgiscache",
                    "physicalPath": "D:\\arcgisserver\\directories\\arcgiscache",
                    "directoryType": "CACHE",
                    "cleanupMode": "NONE",
                    "maxFileAge": 0
                },
                {
                    "name": "arcgisjobs",
                    "physicalPath": "C:\\arcgisserver\\directories\\arcgisjobs",
                    "directoryType": "JOBS",
                    "cleanupMode": "TIME_ELAPSED_SINCE_LAST_MODIFIED",
                    "maxFileAge": 360
                },
                {
                    "name": "arcgisoutput",
                    "physicalPath": "C:\\arcgisserver\\directories\\arcgisoutput",
                    "directoryType": "OUTPUT",
                    "cleanupMode": "TIME_ELAPSED_SINCE_LAST_MODIFIED",
                    "maxFileAge": 10
                },
                {
                    "name": "arcgissystem",
                    "physicalPath": "C:\\arcgisserver\\directories\\arcgissystem",
                    "directoryType": "SYSTEM",
                    "cleanupMode": "NONE",
                    "maxFileAge": 0
                }
            ]
		}

Thanks !

Hi @cameronkroeker,
Thanks for the reply. Just wanted to make this was by design.


Can the processing code for the AST matrix in data preprocessing in SASA be exposed

The treatment of AST matrices in the "Understanding Long Programming Languages with Structure-Aware Sparse Attention" is not particularly detailed, and no code is provided. This problem is similar to my current research direction, I hope you can make the code public, thank you very much

code available at https://github.com/alibaba/EasyNLP/tree/master/examples/SASA
if you have any questions, consult the first author, thank you


Fix getPresence so it actually makes the call to the server

Call was not working
Verified after this change that I get a good presence response

Thanks for the fix :)


chore: export Location and Coordinates type

Description
Export type Location and Coordinates.
Checklist

[x] I have tested this on a device/simulator for each compatible OS
[x] I updated the documentation with running yarn generate in the root folder
[x] I updated the typings files - if js interface was changed (index.d.ts)
[x] I added/ updated a sample - if a new feature was implemented (/example)

Fixed 👍


Shipyard slow to respond

Maybe I am missing something, but I cannot figure out what is going on. I have a development environment that I am trying to add Shipyard to, but I cannot get shipyard to respond in any reasonable amount of time. I have setup all of the containers per the quickstart guide, and I have tried setting it up again even, but I get the same result.
The Development environment is a CoreOS Alpha image running inside of Vagrant (virtualbox). The environment has plenty of memory and cpu free.
My problem is that both the Shipyard CLI and the Web UI are extremely slow to load information. According to Chrome Debugging tools, the web api took 48 seconds to respond with the containers after clicking the containers button. The CLI took approximately 25 seconds to pull the containers as well.
This problem is experienced across all of the tabs. Loading an individual container, loading a container's logs, loading the CPU/Memory dashboard, etc. All of these things load extremely slowly, and I cannot figure out why this is. Docker on the machine itself runs extremely fast and I see no performance issues.
Also, as a side note, none of my containers report using any memory or cpu.
I would love to get this working. I am trying to include this in the development environment that my team uses so that all of my developers can see into the environment with more transparency, but with the speeds I am currently experiencing this won't be possible.
Any help would be greatly appreciated! I would also love to help if there is something I can do. Thanks for your help!

You are welcome :)
On Wed, Dec 31, 2014 at 6:26 AM, Sebastiaan van Stijn <
<EMAIL_ADDRESS>wrote:

Makes sense. Thanks for the explanation!
—
Reply to this email directly or view it on GitHub
https://github.com/shipyard/shipyard/issues/368#issuecomment-68436802.

You are welcome :)
On Wed, Dec 31, 2014 at 6:26 AM, Sebastiaan van Stijn <
<EMAIL_ADDRESS>wrote:

Makes sense. Thanks for the explanation!
—
Reply to this email directly or view it on GitHub
https://github.com/shipyard/shipyard/issues/368#issuecomment-68436802.


Basic reading list support

A user should be able to add media to a reading list, like a playlist but for books. Reading lists may be either for a user or for a set of users
Core tasks:

[ ] Add ReadingList model to prisma schema
[ ] API routes to manage reading lists (minimal for now)

[ ] Create reading list

[ ] #74

[ ] ImportCblJob should be created
[ ] .cbl parsing functions need to be created

[ ] Edit reading list (NOTE: this will likely be much more nuanced than what I am writing)

[ ] Provided a list of media ids, add them to reading list.
[ ] Provided a list of media ids, remove them from reading list

[ ] Delete reading list

[ ] server config to store imported .cbl files

Interface tasks:

[ ] TBD

I can take it


Implement DOSKEY functionality

Changes:

Implemented the following APIs (DOSKEY.EXE) support:

AddConsoleAlias
GetConsoleAlias
GetConsoleAliasExesLength
GetConsoleAliasExes
GetConsoleAliasesLength
GetConsoleAliases
ExpungeConsoleCommandHistory
SetConsoleNumberOfCommands - not used
GetConsoleCommandHistoryLength
GetConsoleCommandHistory
GetConsoleHistoryInfo - not used
SetConsoleHistoryInfo - not used

Alt+F10 to wipe DOSKEY aliases for current process (by process module name).
Alt+F7 to clear command history (by process module name).
Processes with the same module name share a common command history.

Closes #428

When I try this PR i get compilation errors. Is this a problem with my setup?
C:\source\vtm>cmake --build bin --config Release
MSBuild version 17.6.3+07e294721 for .NET Framework

  1>Checking Build System
  Building Custom Rule C:/source/vtm/CMakeLists.txt
  vtm.cpp
C:\source\vtm\src\netxs\desktopio\canvas.hpp(1579,80): error C2131: expression did not evaluate to a constant [C:\source\vtm\bin\vtm.vcxproj]
C:\source\vtm\src\netxs\desktopio\canvas.hpp(168,49): message : a non-constant (sub-)expression was encountered [C:\source\vtm\bin\vtm.vcxproj]
C:\source\vtm\src\netxs\desktopio\logger.hpp(99,1): error C3313: 'state': variable cannot have the type 'void' [C:\source\vtm\bin\vtm.vcxproj]
C:\source\vtm\src\netxs\desktopio\logger.hpp(100,1): error C3536: 'state': cannot be used before it is initialized [C:\source\vtm\bin\vtm.vcxproj]
C:\source\vtm\src\netxs\desktopio\logger.hpp(110,1): error C3313: 'state': variable cannot have the type 'void' [C:\source\vtm\bin\vtm.vcxproj]
C:\source\vtm\src\netxs\desktopio\logger.hpp(111,1): error C3536: 'state': cannot be used before it is initialized [C:\source\vtm\bin\vtm.vcxproj]
C:\source\vtm\src\netxs\desktopio\logger.hpp(115,1): error C3313: 'state': variable cannot have the type 'void' [C:\source\vtm\bin\vtm.vcxproj]
C:\source\vtm\src\netxs\desktopio\logger.hpp(116,1): error C3536: 'state': cannot be used before it is initialized [C:\source\vtm\bin\vtm.vcxproj]

You may need to update Visual Studio.
My setup (MSBuild version 17.7.2):
D:\sources\test\vstest>cmake --build bin --config Release
MSBuild version 17.7.2+d6990bcfa for .NET Framework

  Checking Build System
  Building Custom Rule D:/sources/test/vstest/CMakeLists.txt
  vtm.cpp
  vtm.vcxproj -> D:\sources\test\vstest\bin\Release\vtm.exe
  Building Custom Rule D:/sources/test/vstest/CMakeLists.txt

D:\sources\test\vstest>

Make sure checkout branch o-sdn-o:vt-input-mode:
D:\sources\test\vstest>git rev-parse --abbrev-ref HEAD
vt-input-mode

D:\sources\test\vstest>

I'll configure github actions for automatic building and it will be easier to test.

Now you can just download the binary fron 'All checks have passed -> Details -> Summary -> Artifacts'

looks good now. No errors are showing up anymore.
That is great work. Thanks!