[Fix] Map reloads with "Route pending"

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/38864
PROPOSAL: N/A
Tests

Go to workspace chat.
Create a distance request.
Go to request details page.
Click Distance.
Click Save button without editing the addresses.
Verify the map is not reloaded.

Offline tests

N/A
QA Steps

[ ] Verify that no errors appear in the JS console
[ ] Do the tests from the Tests section.

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android & iOS: Native

https://github.com/Expensify/App/assets/104823336/7751bce6-57f9-491e-91ad-a08d1830e2c2

Android: mWeb Chrome & iOS: mWeb Safari

https://github.com/Expensify/App/assets/104823336/6dbb904f-d7f2-40dd-a257-4220be05c5f4

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/104823336/b4751c2c-0a0f-4c77-a030-138e2f762767

MacOS: Desktop
https://github.com/Expensify/App/assets/104823336/955ce892-f6a6-4c61-abd4-ca77da8e04cb

@DylanDylann what about the checklist?

This is the regression of this PR. @ishpaul777 You are C+ of the offending PR, could you add checklist for this PR?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.65-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Added GameMode restriction bypass permission

Better, easier to read diff :)

I support this idea.

Yh, i found when travelling between worlds it rests the gamemode, very annoying!!

@Sizer009 if your comment is directly related to this commit, then it is most certainly valid, but if you're building against the stock MV, please file a seperate ticket.
@dumptruckman Will review myself (or @lithium3141 @main-- @Rigby90 will) and we'll get this integrated! Had a lot of people requesting this and just not a lot of time!
Thanks!
--FF

Oh balls, apparently my new rebase b0rked your commits, so automerging cannot happen. I'll have to do some manual magic. No worries.

Reviewed, rebased, and committed as of a092dd87602197d1a02065fb3085e978fb50958a. Needs some bonus testing, though.

Tested & seems to work with latest MV-Core built from master. Steps:

Set up a new server with CB 1597, MV-Core from source, PermissionsBukkit 1.2k
Grant a player (let's say lithium3141) the permission multiverse.gamemode.ignore.world_nether
Have lithium3141 log in
From console, set world_nether to creative mode with mvm set mode creative world_nether
From console, teleport lithium3141 to world_nether; watch as the game mode is not changed
Teleport lithium3141 back to world and remove his permission
Teleport lithium3141 to world_nether again and watch as the game mode is changed

At this point, since the code's merged and works (at least on the surface), new bugs should appear as completely new issues in the tracker.


docs: Upgrading Core links to Express links isn't always wanted

The quartodocs rendering process finds shiny.ui.___ links and upgrades them to shiny.express.ui.____ links
https://github.com/posit-dev/py-shiny/blob/ea5db0e222c39128202da9d54afe51488f660d87/docs/_renderer.py#L61-L72
but this isn't always desirable, as in the case of :func:`~shiny.ui.page_auto` which only exists in shiny.ui. When the Express counterpart doesn't exist, the function is rendered as code without a link. See https://shiny.posit.co/py/api/express/express.ui.page_opts.html

I'm ok if we white list exceptions until a bigger pattern emerges. The docs handling code doesn't need to be pretty

Maybe we could try importing converted using something like this, then informatively warn/error if it doesn't exist?

...or just use the original link if the converted link doesn't exist.


Jets new fails during jets webpacker:install

[x] Upgrade Jets: Are you using the latest version of Jets? This allows Jets to fix issues fast. There's a jets upgrade command that makes this a simple task. There's also an Upgrading Guide: http://rubyonjets.com/docs/upgrading/
[x] Reproducibility: Are you reporting a bug others will be able to reproduce and not asking a question. If you're unsure or want to ask a question, do so on https://community.rubyonjets.com
[x] Code sample: Have you put together a code sample to reproduce the issue and make it available?  Code samples help speed up fixes dramatically. If it's an easily reproducible issue, then code samples are not needed. If you're unsure, please include a code sample.

My Environment

Software
Version

Operating System
Amazon Linux

Jets
1.8

Ruby
2.5.1

Expected Behaviour
Using Cloud9, jets new demo will setup my project.
Current Behavior
Setup fails during jets webpacker:install execution. config/webpack/environment.js doesn't get setup and this error is thrown /active_support/inflector/methods.rb:285:in const_get': uninitialized constant Jets::Job::S3EventHelper (NameError)`
Step-by-step reproduction instructions

Start a new Cloud9 host
Install and use Ruby 2.5

rvm install 2.5.1 && rvm use 2.5.1 --default

Install jets

gem install jets

Install yarn

npm install -g yarn

Install mysql client

sudo yum install mysql-devel

Start new project

jets new demo

Using webpacker 3.2.0 from https://github.com/tongueroo/webpacker.git (at jets@3651cc3)
Bundle complete! 10 Gemfile dependencies, 76 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
         run  jets webpacker:install from "."
Traceback (most recent call last):
        18: from /home/ec2-user/.rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:24:in `<main>'
        17: from /home/ec2-user/.rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:24:in `eval'
        16: from /home/ec2-user/.rvm/gems/ruby-2.5.1/bin/jets:23:in `<main>'
        15: from /home/ec2-user/.rvm/gems/ruby-2.5.1/bin/jets:23:in `load'
        14: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/jets-1.8.0/exe/jets:14:in `<top (required)>'
        13: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/jets-1.8.0/lib/jets/cli.rb:5:in `start'
        12: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/jets-1.8.0/lib/jets/cli.rb:20:in `start'
        11: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/jets-1.8.0/lib/jets/cli.rb:48:in `boot_jets'
        10: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/jets-1.8.0/lib/jets/core.rb:18:in `boot'
         9: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/jets-1.8.0/lib/jets/booter.rb:14:in `boot!'
         8: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/jets-1.8.0/lib/jets/booter.rb:153:in `eager_load_jets'
         7: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/jets-1.8.0/lib/jets/booter.rb:153:in `select'
         6: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/jets-1.8.0/lib/jets/booter.rb:165:in `block in eager_load_jets'
         5: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/activesupport-5.2.2/lib/active_support/core_ext/string/inflections.rb:68:in `constantize'
         4: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/activesupport-5.2.2/lib/active_support/inflector/methods.rb:281:in `constantize'
         3: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/activesupport-5.2.2/lib/active_support/inflector/methods.rb:281:in `inject'
         2: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/activesupport-5.2.2/lib/active_support/inflector/methods.rb:281:in `each'
         1: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/activesupport-5.2.2/lib/active_support/inflector/methods.rb:285:in `block in constantize'
/home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/activesupport-5.2.2/lib/active_support/inflector/methods.rb:285:in `const_get': uninitialized constant Jets::Job::S3EventHelper (NameError)
      insert  config/webpack/environment.js
Traceback (most recent call last):
        24: from /home/ec2-user/.rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:24:in `<main>'
        23: from /home/ec2-user/.rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:24:in `eval'
        22: from /home/ec2-user/.rvm/gems/ruby-2.5.1/bin/jets:23:in `<main>'
        21: from /home/ec2-user/.rvm/gems/ruby-2.5.1/bin/jets:23:in `load'
        20: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/jets-1.8.0/exe/jets:14:in `<top (required)>'
        19: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/jets-1.8.0/lib/jets/cli.rb:5:in `start'
        18: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/jets-1.8.0/lib/jets/cli.rb:21:in `start'
        17: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/jets-1.8.0/lib/jets/commands/base.rb:27:in `perform'
        16: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/jets-1.8.0/lib/jets/commands/base.rb:38:in `dispatch'
        15: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
        14: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
        13: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
        12: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.3/lib/thor.rb:40:in `block in register'
        11: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.3/lib/thor/invocation.rb:115:in `invoke'
        10: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.3/lib/thor/group.rb:232:in `dispatch'
         9: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.3/lib/thor/invocation.rb:133:in `invoke_all'
         8: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.3/lib/thor/invocation.rb:133:in `map'
         7: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.3/lib/thor/invocation.rb:133:in `each'
         6: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.3/lib/thor/invocation.rb:133:in `block in invoke_all'
         5: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
         4: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
         3: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/jets-1.8.0/lib/jets/commands/new.rb:106:in `bootstrap_install'
         2: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.3/lib/thor/actions/inject_into_file.rb:27:in `insert_into_file'
         1: from /home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.3/lib/thor/actions.rb:94:in `action'
/home/ec2-user/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/thor-0.20.3/lib/thor/actions/inject_into_file.rb:60:in `invoke!': The file /home/ec2-user/environment/welp/config/webpack/environment.js does not appear to exist (Thor::Error)

Addressed in #194.  Released in v1.8.1


Support for IPython and Jupyter

Look into any special hooks that would make measured easier to work with or prettier in IPython or Jupyter notebooks.

https://ipython.readthedocs.io/en/stable/config/integrating.html#rich-display


Transfer repo to new organization.

Summary by CodeRabbit

New Features

Added support for Python with installation of pre-commit and poetry.
Introduced a command to install pre-commit hooks post-creation of the container.
Added new features in the development container configuration for docker-in-docker and python.

Bug Fixes

Updated various references from the old organization to the new organization for consistency.

Documentation

Updated README files and documentation to reflect the new repository ownership and commands.

Chores

Cleaned up configuration files by removing outdated settings and tasks.
Added .pre-commit/ directory to .gitignore.
Modified CI configuration to allow deployment from an additional branch.

@coderabbitai review


Billing page followup

@rishig These commits are ready for review.

Thanks @hackerkid! I merged the first six commits, and pushed an updated version of the 7th.
I think it would be useful to look at d32051b, compare it closely to your original version, and check that for each thing that is different you understand why I did it differently. For anything where you aren't sure just PM me and we can chat about it.
The updated version of the last commit doesn't pass tests, but can't be merged until
https://chat.zulip.org/#narrow/stream/49-development-help/topic/realm.20audit.20log.20changes
is resolved anyway.

Thanks @hackerkid! I spent a bit of time working on this, though didn't quite finish so pushing the progress here. The first commit I split out into #10332.
The second commit is probably done, though needs a different commit message, like
billing: Make CTA buttons on /plans reflect current plan type.
For the third commit we should compute the condition in home.py (the same place we compute show_invites). Let's show "Plans and pricing" to everyone if they are on LIMITED, show "Billing" to admins and the billing admin if they are on PREMIUM, and nothing in every other case.
For the fourth commit, I unfortunately am not seeing the column on /activity, though maybe my changes messed it up.

The current logged out Plans page shows buy premium. Should we change that as the sign up flow is just the same as clicking on "Current Plan"

I pushed some changes

Removed billing_enabled from template context.
Updated the navbar commit to reflect your feedback as well as added tests.

For the fourth commit, I unfortunately am not seeing the column on /activity, though maybe my changes messed it up.

It's showing up for me. Weird.

Thanks @hackerkid! Merged the last commit; it's working for me now as well.
For the other two:

Good point about the "Buy Premium". I wrote a note in the billing doc on how we can handle this.
For the nav bar change: I didn't think about the fact that we'd have to import from zilencer. Let's instead add a field is_billing_admin to UserProfile, default False, and set it in do_create_customer_with_payment_source if the user is not an admin.
We can also add a commit to remove Customer.billing_user.

@rishig I made a minor change to the plans page to point Buy premium to /billing instead of /new  so that they would be redirected to login page. This works fine when a user is logged out and is accessing plans plage from their realm subdomain(eg https://hackinthenorth.zulipchat.com/stats). But when user tries to do so from root domain (https://zulipchat.com/stats) they would be redircted to find accounts.
Slack does this in two different ways.

When I am logged into multiple organizations and I access slack.com/plans it redirects me to the plans page of the last organization(not sure thats how they decide the organization though) I visited. We have to write extra code to accomplish this.

When I am not logged in and I access slack.com/plans it asks me to signin to an organization and redirects to plans page after I do that. In the current PR instead of asking people to sign in we redirect them to find accounts page. (In localhost people are redirected to locaclhost:9991 where all the accounts are listed). We need to create an extra page that asks people to sign to their organization instead of doing the find-accounts thing. I guess that is true for other cases where user have to sign in as well.

Is this how you like to see this implemented?

@rishig Updated

Thanks @hackerkid! After playing around with this, let's add another button for /plans; a grayed out button like

Then we can do the following simpler behavior:

On root domain: Current behavior
On subdomain: Make it a logged-in-only page. I.e. should redirect to login, with ?next=...

On subdomain, when logged in:

plan_type self_hosted: Redirect to /plans/enterprise. For now it can be a page with just "Enterprise plans coming soon. Please contact<EMAIL_ADDRESS>plan_type limited: "Free" is a grey button, "Premium" is current behavior (green "Buy Premium" button that goes to /upgrade).
plan_type premium or premium free: "Free" has nothing in the bottom section (no button or text), "Premium" is the grey button

So now the plans page no longer has to know anything about the user.

@rishig Took care of the feedback.

Thanks @hackerkid! Looks great. For next steps I'm going to wait until #10435 is merged (the /plans portion of this PR), which will likely happen when Tim is back in operation.

fyi, merged part of this as #10435, and opened #10479 for the gear menu changes. Still reviewing /accounts/go.

Merged one more commit. Might be good to rebase the next time you look at this.

@rishig Rebased and updated the next param backend to a style similiar to our dev_login.

Great! Repushed, with minor changes.
I think the next step is for Tim to review. Could you take these last two commits and open a new PR?


More advanced spring.factories key processing to address test issues

The native image creation for tests has uncovered somewhere we haven't explored. Right now we are only 'processing' (as in computing the optimal related contents for StaticSpringFactories .java and *.json files) configurations pointed to by the EnableAutoConfiguration key in spring.factories. The test infrastructure in Spring Boot is referencing all manner of extra auto configurations from keys other than that. For example:
org.springframework.boot.test.autoconfigure.web.reactive.AutoConfigureWebTestClient=\
org.springframework.boot.autoconfigure.security.oauth2.client.reactive.ReactiveOAuth2ClientAutoConfiguration,\
org.springframework.boot.autoconfigure.security.oauth2.resource.reactive.ReactiveOAuth2ResourceServerAutoConfiguration,\
org.springframework.boot.autoconfigure.security.reactive.ReactiveSecurityAutoConfiguration,\
org.springframework.boot.autoconfigure.security.reactive.ReactiveUserDetailsServiceAutoConfiguration,\
org.springframework.boot.test.autoconfigure.web.reactive.WebTestClientAutoConfiguration

There are two problems here. Firstly if we don't process it in detail when computing StaticSpringFactories, we end up registering a bunch of random configurations that in fact wouldn't pass ConditionalOnClass/etc checks. This would lead to a bloated image, but we don't get as far as a working image because the backend is not doing the computation for the *.json files because we are not processing configurations reachable by these other keys there either.
This is why the ci for spring-native is failing. The webflux-thymeleaf sample is failing because FreeMarkerAutoConfiguration cannot be found as a resource file when starting the image. Two problems here:

the backend didn't follow the chain from the org.springframework.boot.test.autoconfigure.web.reactive.AutoConfigureWebFlux key that points to it so it never got added as a resource entry in resource-config.json
it never should have made it that far anyway because it shouldn't really be in StaticSpringFactories because it wouldn't pass ConditionalOnClass checks.

Fix one is being smarter up front to allow more than just EnableAutoConfiguration keys to reference auto configurations and processing (and discarding) them when necessary.
This would mean the right ones get into StaticSpringFactories.java
Then we have to fix the backend to do the same thing, follow auto configurations that are rooted at these keys other than EnableAutoConfiguration. With these two changes, webflux-thymeleaf fully passes for me locally.

I've pushed a commit, let's see what the build machine makes of it. It is a little more radical than recent changes although I've tried to take care and make sure this first variant only impacts the testing situation.  The commit should fix:

problems with FreeMarkerAutoConfiguration
problems with WebTestClientAutoConfiguration
problems with jdbc-tx related to WebEnvironment (I fixed this with a simple change that introduces hints for SpringBootTests)

Depending what happens on the build machine I will re-open this or open a follow on for next steps.


TxSubmission2 protocol

This series of patches introduce 'Hello' protocol transformer. It is included
under Protocol.Trans module name space (similar to monad transformers).  The
TxSubmission2 protocol is TxSubmission wrapped in Hello transformer.
TxSubmission2 protocol will be used from version NodeToNodeV_6.

typed-protocols: fmapPeerPipelined

ouroboros-network: Hello protocol wrapper

tx-submission: expose more codec functions

TxSubmission2: protocol

TxSubmission2: tests

tx-submission: missing case in id codec
This patch fixes a bug in codecTxSubmissionId, it also adds a test which
would discoverit.  KMsgThx is not used anywhere hance the bug wasn't
discovered.

TxSubmission2: use in node-to-node v6 protocol

bors merge


style: Execute lint fix on violating files for standard linting format

Really like your plugin and how it works with the spec! 👍
Noticed some linting errors that could be fixed quickly with the singlequote ones with standard fix. Let me know if there's documentation to add; I know these things can be annoying to do manually.

Before
npm run lint

><EMAIL_ADDRESS>lint
> standardx src/**/*.ts src/*.ts | snazzy

standardx: Use JavaScript Standard Style (tweaked by standardx) (https://github.com/standard/standardx)
standardx: Run `standardx --fix` to automatically fix some problems.

design-tokens/src/transformer/standardTransformer.ts
  261:28  error  Unnecessary escape character: \.
  261:32  error  Unnecessary escape character: \_
  261:34  error  Unnecessary escape character: \/
  261:36  error  Unnecessary escape character: \@
  261:38  error  Unnecessary escape character: \+
  261:40  error  Unnecessary escape character: \&
  261:42  error  Unnecessary escape character: \:
  267:37  error  Strings must use singlequote
  267:42  error  Strings must use singlequote

✖ 9 problems

After

No linting errors
Manually removed unnecessary regex characters

 design-tokens % npm run lint

><EMAIL_ADDRESS>lint
> standardx src/**/*.ts src/*.ts | snazzy

 design-tokens %

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.475%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/transformer/standardTransformer.ts
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
492

Relevant Lines:
715

💛  - Coveralls


PayPal: إرسال مدفوعات

https://www.paypal.com/myaccount/transfer/homepage

Hi, I don't know what your issue is, please see #30604 for how to report a issue.

@MonicaLiu0311 This is simply spam. I don't understand why you did not simply close it and reported the user.

This issue will be closed soon, if you have problems please re-report as #30604.


UnimplementedError while applying class level macro to sealed extension.

Applying a Class level macro to a sealed extension lead to an UnimplementedError: (SuperFormalParameterImpl)
macro class BaseAppliedMacro implements ClassDefinitionMacro, ClassDeclarationsMacro {...}

sealed class Base {...}

@BaseAppliedMacro
final class BaseImpl1 extends Base {...}

UnimplementedError: (SuperFormalParameterImpl) super.description #0      DeclarationBuilderFromNode._formalParameterDeclaration (package:analyzer/src/summary2/macro_declarations.dart:1721:9)
dart-lang/language#1      DeclarationBuilderFromNode._executableFormalParameters (package:analyzer/src/summary2/macro_declarations.dart:1663:31)
dart-lang/language#2      DeclarationBuilderFromNode.constructorDeclaration (package:analyzer/src/summary2/macro_declarations.dart:1235:9)
dart-lang/language#3      DeclarationBuilderFromNode.declarationOf (package:analyzer/src/summary2/macro_declarations.dart:1263:16)
dart-lang/language#4      DeclarationBuilder.declarationOfElement (package:analyzer/src/summary2/macro_declarations.dart:165:23)
dart-lang/language#5      MappedListIterable.elementAt (dart:_internal/iterable.dart:425:31)
dart-lang/language#6      ListIterator.moveNext (dart:_internal/iterable.dart:354:26)
dart-lang/language#7      WhereTypeIterator.moveNext (dart:_internal/iterable.dart:882:20)
dart-lang/language#8      new _GrowableList._ofOther (dart:core-patch/growable_array.dart:202:26)
dart-lang/language#9      new _GrowableList.of (dart:core-patch/growable_array.dart:152:26)
dart-lang/language#10     new List.of (dart:core-patch/array_patch.dart:39:18)
dart-lang/language#11     Iterable.toList (dart:core/iterable.dart:497:7)
dart-lang/language#12     _DeclarationPhaseIntrospector.constructorsOf (package:analyzer/src/summary2/macro_application.dart:1019:12)
<asynchronous suspension>
dart-lang/language#13     new ExternalMacroExecutorBase.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:_fe_analyzer_shared/src/macros/executor/executor_base.dart:159:47)
<asynchronous suspension>

Thanks for filing an issue!
It is expected at this time that macros will throw some unimplemented errors. I am going to close this, but cc @scheglov who owns the analyzer implementation here. As more language tests etc get written we will get to all of these.

I understand that the painting is still fresh, this report is a mark of interest for the macros features. Thanks.


Add sessionInfo pubsub topic

We're breaking sessionInfo packets into a different pubsub topic. I've set it up in the app but we need to create the topic and give the neurodoro service account permission to it

Here's the schema for the sessioninfo / streaminfo packets:
{
  "channel_count": 4,
  "manufacturer": "Interaxon",
  "name": "non-symbolic attention",
  "nb_samples": 2723,
  "nominal_srate": 256,
  "session_id": "4yf474451",
  "source_id": "NeuroTechTO",
  "start_time":<PHONE_NUMBER>163,
  "type": "RawEEG",
  "uid": "d_shY774yf4",
  "version": "1.0"
}


Add GitHub Enterprise setting as env var

Here, I add process.env.GITHUB_ENDPOINT as a possible environmental var
to use to change the rootURL. I change all instances of rootURL to
githubEndpoint, as that is the token used in gh-got
and it seemed like a good idea to just copy that token.
I was unsure of how to add a test for this.

Just realized changing rootURL to githubEndpoint will break functionality for others. So, that may not be advised. Happy to change it back. Having a default env var would still be useful.
I resolved my issues in https://github.com/RichardLitt/gh-description/issues/12 using rootURL, so this PR is no longer necessary for me, but it may still be useful.


Incorrect LUMO energy extraction for some xyz files

Hi,
Thank you for creating uxtbpy, which makes xtb calling accessible as a Python API! I recently encountered an issue with LUMO energy extraction for some xyz files. For example:
...
   *** convergence criteria satisfied after 16 iterations ***

         #    Occupation            Energy/Eh            Energy/eV
      -------------------------------------------------------------
         1        2.0000           -0.8375023             -22.7896
       ...           ...                  ...                  ...
       104        2.0000           -0.3599362              -9.7944 (HOMO)
       105        0.0000           -0.3291062              -8.9554 (LUMO)
       106                         -0.2656783              -7.2295
       ...
       185                          1.6005732              43.5538
      -------------------------------------------------------------
                  HL-Gap            0.0308299 Eh            0.8389 eV
             Fermi-level           -0.3445198 Eh           -9.3749 eV
....

In the code:
https://github.com/hkneiding/uxtbpy/blob/8390296a3677abf19e2f6751cf36cb1bd465d035/uxtbpy/xtb_output_parser.py#L150-L158
the LUMO energy extraction looks for the "(LUMO)" keyword to retrieve the third element from line_split. In this case, it returns:
{'homo_energy': -9.7944, 'lumo_energy': -0.3291048, ...}

However, the LUMO energy is in Eh rather than eV. The issue arises with molecules that have a column with Occupation 0.0000, while most other cases work correctly.
For your reference, I’m attaching an example xyz file that causes the issue (remove .txt)
mol.xyz.txt
xtb mol.xyz --opt tight --uhf 0 --norestart -v -c 0

Hi,
thanks for bringing this to my attention!
It seems that the following line causes a problem for the parser:
105        0.0000           -0.3291062              -8.9554 (LUMO)
The reason is that the parser expects this line to have only 3 entries after splitting at whitespaces. In fact I have previously never encountered a 0.0000 occupation entry for the LUMO.
I implemented and pushed a fix for this issue.


Error org.postgres.Driver not loaded

I need to get data from a PostgreSQL DB and index it into Elasticsearch.
https://www.elastic.co/blog/logstash-jdbc-input-plugin
When I run /opt/logstash-2.3.3/bin/logstash -v -f es_table.logstash.conf
I receive the following error:
Pipeline aborted due to error
{:exception=>#<LogStash::ConfigurationError: org.postgres.Driver not loaded.
Are you sure you've included the correct jdbc driver in :jdbc_driver_library?>, :backtrace=>["/opt/logstash-2.3.3/vendor/bundle/jruby/1.9/gems/logstash-input-jdbc-3.0.2/lib/logstash/plugin_mixins/jdbc.rb:156:in `prepare_jdbc_connection'", "/opt/logstash-2.3.3/vendor/bundle/jruby/1.9/gems/logstash-input-jdbc-3.0.2/lib/logstash/plugin_mixins/jdbc.rb:148:in `prepare_jdbc_connection'", "/opt/logstash-2.3.3/vendor/bundle/jruby/1.9/gems/logstash-input-jdbc-3.0.2/lib/logstash/inputs/jdbc.rb:167:in `register'", "/opt/logstash-2.3.3/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.3-java/lib/logstash/pipeline.rb:330:in `start_inputs'", "org/jruby/RubyArray.java:1613:in `each'", "/opt/logstash-2.3.3/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.3-java/lib/logstash/pipeline.rb:329:in `start_inputs'", "/opt/logstash-2.3.3/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.3-java/lib/logstash/pipeline.rb:180:in `start_workers'", "/opt/logstash-2.3.3/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.3-java/lib/logstash/pipeline.rb:136:in `run'", "/opt/logstash-2.3.3/vendor/bundle/jruby/1.9/gems/logstash-core-2.3.3-java/lib/logstash/agent.rb:473:in `start_pipeline'"], :level=>:error}

Here is a piece of my Logstash configuration:
input {
   jdbc {
      jdbc_user => 'user'
      jdbc_driver_class => 'org.postgresql.Driver'
      jdbc_connection_string => 'jdbc:postgresql://<IP_ADDRESS>:5432/db'
      lowercase_column_names => false
      clean_run => false
      jdbc_driver_library => '/usr/share/java/postgresql-jdbc4.jar'
      jdbc_password => 'pass'
      jdbc_validate_connection => true
      jdbc_page_size => 1000
      jdbc_paging_enabled => true
      statement => 'SELECT * FROM "table"'
      type => 'table'
   }
...

The jdbc4 driver exists. I tried jdbc3 too without success.
ls /usr/share/java | grep postgresql-jdbc
postgresql-jdbc3-9.2.jar
postgresql-jdbc3.jar
postgresql-jdbc4-9.2.jar
postgresql-jdbc4.jar

The Driver class is inside:
jar tf /usr/share/java/postgresql-jdbc4.jar | grep -i driver
org/postgresql/Driver$1.class
org/postgresql/Driver$ConnectThread.class
org/postgresql/Driver.class
org/postgresql/util/PSQLDriverVersion.class
META-INF/services/java.sql.Driver

The port 5432 is open:
telnet <IP_ADDRESS> 5432
Trying <IP_ADDRESS>...
Connected to <IP_ADDRESS>.
Escape character is '^]'.

Authentication to the DB works.
My OS:
cat /proc/version
Linux version 3.19.0-56-generic (buildd@lgw01-10) (gcc version 4.8.2 (Ubuntu 4.8.2-19ubuntu1) ) #62~14.04.1-Ubuntu SMP Fri Mar 11 11:03:15 UTC 2016

The problem was because I did a mistake in the driver name.
I wrote jdbc_driver_class => 'org.postgres.Driver'
And the correct name is jdbc_driver_class => 'org.postgresql.Driver'


Possible error status code is not documented for "Get a tree" endpoint

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/rest/git/trees?apiVersion=2022-11-28#get-a-tree
What part(s) of the article would you like to see updated?
"Get a tree" endpoint (/repos/{owner}/{repo}/git/trees/{tree_sha}) seems returning 409 Conflict response when the repository is empty, but that doesn't seem documented.
Additional information
I got the below response object with 409 status code when fetching an empty repo.
{"message":"Git Repository is empty.","documentation_url":"https://docs.github.com/rest/git/trees#get-a-tree"}

@kt3k Thank you for raising a flag on this! ✨ The team will need to review this issue, and make updates to this documentation internally. I've created an internal issue for review, and will go ahead and close this issue out 💛


val gpu slow

during the training the usage of GPU is high but when start to val the usage go to 20%.Any help for this @Holmeyoung ?

refer to this to solve this problem! 214


Python 3.7 clickhouse_connect import error importlib.metadata

Describe the bug
Python 3.7,  Module clickhouse_connect
Since version 0.6.9 there is an import error because importlib.metadata in python3.7 is importlib_metadata
Steps to reproduce
Just import:
> python3 -c "import clickhouse_connect"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/alexander/.local/lib/python3.7/site-packages/clickhouse_connect/__init__.py", line 2, in <module>
    from clickhouse_connect.entry_points import validate_entrypoints
  File "/home/alexander/.local/lib/python3.7/site-packages/clickhouse_connect/entry_points.py", line 6, in <module>
    from importlib.metadata import PackageNotFoundError, distribution
ModuleNotFoundError: No module named 'importlib.metadata'

Expected behaviour
No error on import
Code example
import clickhouse_connect

Sorry about that, this should be fixed in 0.6.14.  Python 3.7 is EOL and no longer included in our CI tests, which is why I missed this.  I strongly recommend upgrading. :)

Hi @genzgd!
Thank you for reply.
Yes, upgrading is needed, but this is PROD Airflow and it is not quick. You know how it is =)


override params?

I'm looking for a way to allow passing a file as parameters but also being able to override certain parameters or setting certain parameters as required on the command line.  An example of this that when I spin up a vpc, I want to specify the CIDR block it uses.  I'd like to use a parameter file such as dev.json to describe all the fields required in dev but each user who wants a custom dev environment needs to have a separate cider block.
I was envisioning something like:
stack-create example-test --override "VpcCidr=<IP_ADDRESS>"
which would use all values from example.json except would override VpcCidr with the passed value.
Or an even better user experience would be if the VpcCidr wasn't in example.json but the stack new that this was a required field for it to be created so it prompted the user for a value.
stack-create example-test
please enter required value for parameter "VpcCidr":
<IP_ADDRESS>
creating stack ...

Would you consider supporting this?  Or is there a different recommended way to acheive something similar?
thanks

I'm pretty excited about the deploy function in AWSCLI.
It does a create-or-update (good for scripts, dangerous at command line when you are logged into wrong account).
It also enables TAB completion for the template name.
The parameter-overrides functionality is great. It defaults to UsePreviousValue for everything. :-)
aws cloudformation deploy                                        \
  --stack-name example-stack                                   \
  --template-file cloudformation/example-stack.yml \
  --parameter-overrides "VpcCidr=<IP_ADDRESS>"

I will possibly be adding a stack-deploy function in future but the AWSCLI function is pretty damn usable on it's own! :-)

sweet. Thanks for the heads up.


Handshake happens when protocol is malformed

Describe the bug
We are using a custom implementation for Unreal4 of SignalR, we saw an issue when start the handshake protol we sent "Json" with the J capital as the protocol. and the Handshake was succeed, ping was working but no message was received from SignalR. We tried to debug and we only had user error metrics. I understand that the is not an official SDK from SignalR but we had no choice that implement ours, and anyway the handshake should be rejected if the protocol is not supported or invalid.
To Reproduce
send a client the protocol "Json" instead of "json" No  Error in the response of the handshake will happen.
Exceptions (if any)
No Exceptions
Further technical details

Current Azure SignalR

I will try to make a example to reproduce it with Azure SignalR

If you got a successful handshake response that very likely means the protocol is supported.
It's very likely that you implemented something wrong after the handshake that's causing issues.

the handshake should be rejected if the protocol is not supported or invalid.

At least in the case without using Azure SignalR, "Json" or "json" works:
https://github.com/dotnet/aspnetcore/blob/c646e20f7597a3913b1103d6f426666f183a6602/src/SignalR/server/Core/src/Internal/DefaultHubProtocolResolver.cs#L38

The only thing I changed was the handshake from "Json" to "json" (with tolower( ) in c++ ) and started to receive messages other than pings.

Are you using SignalR or Azure SignalR?

@vicancy The scenario is similar:
UE4 client -> SignalR -> Grid Event -> AzureFunction (where we send the message).
I tested with the same client using "Json" in the handshake and "json" and in the first one message was not received.
I also tested using SignalR Rest API to send messages to Connection and to user and neither of them worked.
The issue I imagined is like you described,  but sendToConnection didn't work neither (I tried). Not sure why ping works, maybe uses the protocol in different way.


Add kubernetes-specific labels to the google cloud logging fluentd plugin

Effectively a cross-post of https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/issues/15, but this also tracks updating our fluentd images once the plugin has been changed.
@mr-salty @satnam6502

How do we decide a milestone for this PR?

@erickhan

Love this feature.  Any plans to do something similar for ES?  And did we consider just replacing fluentd with our own collector (in Go)?

@justinsb, I can't remember if you've been pointed there before, but I think #8632 is along the lines of what you would want for ES.
And we haven't really considered replacing it, no. Fluentd hasn't been a source of problems as far as I've seen. I expect the main benefits that would motivate a replacement would be lower resource usage and making it easier to integrate k8s concepts?

Closing in favor of #8001, which is effectively the same.


[unittest] add negative unittest

Commit 1:     [unittest] rename negative testcase name to _n place at the end
 - Since the indicator _p/_n is at the middle of testcase name all of test cases
   are regarded as positive testcases(default). So place indicator at the end.
 - Added '_' right before 'n' to indicate negative testcase.

Signed-off-by: hyeonseok lee<EMAIL_ADDRESS>
Commit 2:     [unittest] added negative testcase
 - Added negative testcase

Signed-off-by: hyeonseok lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2003. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @lhs8928, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2003-202209221836130.58477592468262-3e2e43d379ab577dfb2f2f57a999e69f2285c0a1/.


Xamarin Mobile 0.7.5

Hi,
The latest version of  nuget package comes with Xamarin Mobile 0.7.1. Do you have any plan to upgrade this dependency to 0.7.5? Any recommendations how to have those two versions coexist ?
Thanks
Pawel

I updated to this months ago and it is included right in the Niger package

Hi,
I've just create a new XF app and go the latest version of the package 2.0.4 and it looks like it uses the old version of  Xamarin Mobile. Am I missing something ?

From the wp8 project
<Reference Include="Xamarin.Mobile, Version=<IP_ADDRESS>, Culture=neutral, processorArchitecture=MSIL">
  <SpecificVersion>False</SpecificVersion>
  <HintPath>..\Components\xamarin.mobile-0.7.5\lib\wp8\Xamarin.Mobile.dll</HintPath>
</Reference>

They may not have updated the versioning with xammobile.  Just replace it manually if you are concerned about it.  I don't think there is much of an upgrade in the wp8 side anyhow.

Yeah, I can hack it but I would rather not :).  I think I simply downgrade  Xamarin Mobile to 0.7.1

I'm saying it isn't a bug.  I've included xamarin.mobile 0.75 from the component store (the path shows that).  Xamarin may not have updated the assembly signature.

Ah, ok. Now it makes sense. I thought that you wanted me to change the Hintpath.
Thanks for clarifying this.


Improve dotenv support

- Summary

previous implementation wasn't really useful as it was limited to just two
files .env.development and .env (and not even merging them)
so we are bringing .env.local and .env.developepment.local file support and so on
as well as dotenv-expand that can be pretty useful as well as just there
to be consistent with cra and dotenv-load
most egregious of them was that if you have ABC=0 in .env you won't be able
to change it by running ABC=123 netlify dev as it will continue to have
process.env.ABC=0 inside .netlify/functions

- Test plan
I made it so it passes current unit tests, but the scenario that I was testing was netlify website with this kind of configuration:
# .env
FUNCTIONS_A="from .env"
FUNCTIONS_B="from .env"
FUNCTIONS_C="from .env"

# .env.local
FUNCTIONS_A="from .env.local"
FUNCTIONS_B="from .env.local"

// functions/test.js

const headers = {
  "Access-Control-Allow-Origin": "*",
  "Access-Control-Allow-Headers": "Content-Type",
};

exports.handler = function (event, context, callback) {
  callback(null, {
    statusCode: 200,
    headers: headers,
    body: JSON.stringify(getDebugEnv()),
  });
};

function getDebugEnv() {
  return Object.keys(process.env)
    .filter(key => key.startsWith("FUNCTIONS_"))
    .reduce((acc, key) => ({ ...acc, [key]: process.env[key] }), {});
}

Now if we run
FUNCTIONS_A="from cli" netlify dev

it will print
◈ Overriding the following env variables with .env.local,.env files: FUNCTIONS_A,FUNCTIONS_B,FUNCTIONS_C

and curl http://localhost:3200/.netlify/functions/hash produces
{
  "FUNCTIONS_A": "from cli",
  "FUNCTIONS_B": "from .env.local",
  "FUNCTIONS_C": "from .env"
}

just to compare to what I was fixing, here's result that v2.51.0 produces
{
  "FUNCTIONS_A": "from .env",
  "FUNCTIONS_B": "from .env",
  "FUNCTIONS_C":"from .env"
}

- Description for the changelog
Improved support for .env files, now it behaves like create-react-app which means it will use files .env.development.local, .env.development, .env.local and .env; as well as it will expand environment variables
- A picture of a cute animal (not mandatory but encouraged)

ok, I see all of those tests are failing :) it looks like this is because of NODE_ENV=test again, I'm open to suggestions on what is the right way to deal with it :)

And now it fails without any indications of why :) I can infer from the name that it wants me to add labels to RP, but I can't edit it.

I was working on a project that would have been benefited from you fixing this... maybe one more picture will help

Sorry for the late follow up @JLarky. Will try to review this week.

Sorry for the late follow up @JLarky. Will try to review this week.

no worries :) just wanted to hear at least something back :) let me know how I should update this PR so it can be merged :) should I rebase it on the latest master? :) as you can imagine last time I had this repo set up was half a year ago :) I don't want to spend too much time before knowing if this PR is going through or not :)

should I rebase it on the latest master

No worries, I'll do the rebase and ping you for approval

@JLarky I followed up with some changes:

Dropped dotenv-expand as it doesn't seem to be maintained and I couldn't find a way to use interpolation without mutating current process.env:
https://github.com/motdotla/dotenv-expand/blob/de9e5cb0215495452f475f5be4dea1580b8217cd/lib/main.js#L5
I'm open to adding this feature if another lib if available/in another PR
Changed the code to read all .env files in parallel.
Changed vars to be the result of Object.entries to make it easier to use.

To be done:

Add some more tests.
Update the logs as I believe they don't reflect the code anymore.

Dropped dotenv-expand as it doesn't seem to be maintained and I couldn't find a way to use interpolation without mutating current process.env:
https://github.com/motdotla/dotenv-expand/blob/de9e5cb0215495452f475f5be4dea1580b8217cd/lib/main.js#L5
I'm open to adding this feature if another lib if available/in another PR

This is to be consistent with CRA and dotenv-load. https://www.npmjs.com/package/react-scripts?activeTab=dependencies so my opinion is "once those packages use something else you can change it to that thing to be consistent"

Changed the code to read all .env files in parallel.

as long as it doesn't mess with the order I guess? Do you plan to move your changes upstream? :) https://github.com/facebook/create-react-app/blob/5bd6e73047ef0ccd2f31616255c79a939d6402c4/packages/react-scripts/config/env.js

Changed vars to be the result of Object.entries to make it easier to use.

I have no opinion on that

To be done:

Add some more tests.

I only changed the test so they don't fail CI

Update the logs as I believe they don't reflect the code anymore.

I don't know what you mean

This is to be consistent with CRA and dotenv-load.

We can re-visit this in another separate PR. Don't think we should add an unmaintained library.

Do you plan to move your changes upstream? :)

Oh, didn't realise this code was based on that. I think it would be not that straightforward as the code there is synchronous to begin with.

I only changed the test so they don't fail CI

I'm going to add those

I don't know what you mean

Sorry, clarifying - we are no longer overriding env variables as stated here:
https://github.com/netlify/cli/pull/924/files#diff-dd36b1f406f5fb77839467571252f745R29
we're just sourcing/adding them.

Don't think we should add an unmaintained library.

as opposed to this one?

Thank you for your feedback, @JLarky. I'm going to follow up with these changes in another PR as I believe the current handling of .env files should be improved


Cleanup

r? @dirvine
(maidsafe_highfive has picked a reviewer for you, use r? to override)

r? @inetic


Found a pull request with something similar:


Add Create & Update Token Commands to Stake-Pool CLI

Adding the following commands to the spl-stake-pool rust cli:

create_token_metadata
update_token_metadata

All arguments have been catered for with friendly descriptions.

Took me some time to get my environment setup correctly to run these commands.
Thanks for the comments! I have run the format command and clippy seems happy :)


calling addScriptTag returns Promise that is not rejected in case of an error

Steps to reproduce
Puppeteer version: 0.12.0
Platform / OS version: macOS El Capitan
What steps will reproduce the problem?
If loading external script fails (wrong url, internet is down ...), if you call:
await page.addScriptTag({url: "someurl"});
nothing will happen and execution of a code will be stuck on this line.
What is the expected result?
Promise should be rejected because of an error.
What happens instead?
Promise is not rejected because in FrameManager.js "onerror" callback is not registered.

That's a good one. Should be easy to fix; the code in question is here
https://github.com/GoogleChrome/puppeteer/blob/6dec7cf6e4c5121570c22fc1db89678690d367f7/lib/FrameManager.js#L347-L353

Simply adding script.onerror = reject; works, however it produces a rather cryptic error message:

Evaluation failed: Event

As far as I'm aware, there isn't a way for me to access an error object from the event itself.
Perhaps I've tried to implement a fix that is too easy, did you have another solution in mind, @aslushnikov? I'd like to have a go at fixing this.
It's also worth mentioning that addStyleUrl will also need the same treatment, as the functionality is almost identical.

As far as I'm aware, there isn't a way for me to access an error object from the event itself.

@robertlyall onerror callback gets an error object passed in: MDN

Simply adding script.onerror = reject; works, however it produces a rather cryptic error message:

You can reject with your own error if you wish to.

It's also worth mentioning that addStyleUrl will also need the same treatment, as the functionality is almost identical.

Indeed, good call

Unfortunately, it appears that the arguments differ between element.onerror and window.onerror.

When a resource (such as an  or


Fails to build: type annotations needed for Box<_>

error[E0282]: type annotations needed for `Box<_>`
  --> /wrkdirs/usr/ports/misc/oatmeal/work/oatmeal-0.13.0/cargo-crates/time-0.3.30/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
   = note: this is an inference error on crate `time` caused by an API change in Rust 1.80.0; update `time` to version `>=0.3.35` by calling `cargo update`

Version: 0.13.0
rust-1.83.0
FreeBSD 14.1

update time to version >=0.3.35 by calling cargo update

cargo add time
cargo build --release
DO NOT RUN "cargo update" or you will have to re-do everything.
P.s. i have disabled a # fix for cargo-about -- as it looks like for macos only.
cargo install oatmeal / cargo install oatmeal --locked DO NOT WORK.
Just now installed on FreeBSD 14.2-RELEASE also have oatmeal installed on FreeBSD 14.1-RELEASE on 1st of September 2024.


Add image to Signature field

Thanks for the library, it's very helpful.
I have successfully added an image to the PDFTextField, but I'm unable to get it worked for PDFSignature. I tried the approach implemented in #700  and #718 but I feel it's not straightforward as mentioned. When I try to implement, need to add too many references from the original library. Could you please guide me with the right approach to add an image in the Signature field.
Thank you.

Please fill out the new bug report form if you're still having trouble with this.


rust-analyzer is slow to compile

Both ra_hir and ra_ide_api are really slow to compiler, which makes fix & test loop rather frustrating. Note that tests are extremely fast themselves, it's compile time that hurts us badly.
We need to do something with it...

Codegen seems to be taking an awful lot of time...

At the moment we carry around 2 versions of winapi which adds over 30 seconds to my build. I can get it down to (I think) one version of 0.2.8 being held back by mio.

Yeah, and 102s by default.

Hm, that reminds me that we should set debug = 1 for the dev profile, to save some disk space...

Another interesting thing is that I tried to use lld. Even though it helped quite a lot on other projects, it seems to make no difference here.

Some random -Z self-profile measurements, which don't tell us anything new:
ra_hir:
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| Item                                          | Self time | % of total time | Item count | Cache hits | Blocked time | Incremental load time |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| LLVM_module_optimize_module_passes            | 129.32s   | 35.794          | 199        | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| LLVM_thin_lto_optimize                        | 75.69s    | 20.950          | 199        | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| LLVM_module_codegen_emit_obj                  | 55.74s    | 15.429          | 199        | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| codegen_crate                                 | 36.53s    | 10.111          | 1          | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| codegen_module                                | 16.45s    | 4.553           | 199        | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| LLVM_thin_lto_import                          | 13.98s    | 3.869           | 199        | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| LLVM_module_optimize_function_passes          | 6.76s     | 1.870           | 199        | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| typeck_tables_of                              | 3.29s     | 0.910           | 2798       | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| LLVM_module_codegen_make_bitcode              | 2.61s     | 0.723           | 199        | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| evaluate_obligation                           | 1.35s     | 0.374           | 79783      | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| monomorphization_collector_graph_walk         | 1.04s     | 0.289           | 1          | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+

ra_ide_api:
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| Item                                          | Self time | % of total time | Item count | Cache hits | Blocked time | Incremental load time |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| LLVM_module_optimize_module_passes            | 166.80s   | 35.059          | 305        | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| LLVM_thin_lto_optimize                        | 96.95s    | 20.377          | 305        | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| LLVM_module_codegen_emit_obj                  | 69.66s    | 14.642          | 305        | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| codegen_crate                                 | 50.28s    | 10.568          | 1          | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| LLVM_thin_lto_import                          | 26.33s    | 5.533           | 305        | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| codegen_module                                | 25.05s    | 5.266           | 305        | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| LLVM_module_optimize_function_passes          | 10.47s    | 2.200           | 305        | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| LLVM_module_codegen_make_bitcode              | 3.14s     | 0.660           | 305        | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| normalize_projection_ty                       | 1.84s     | 0.386           | 15240      | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| monomorphization_collector_graph_walk         | 1.74s     | 0.367           | 1          | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| evaluate_obligation                           | 1.46s     | 0.307           | 74165      | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+
| codegen_fulfill_obligation                    | 1.46s     | 0.307           | 23807      | 0          | 0.00ns       | 0.00ns                |
+-----------------------------------------------+-----------+-----------------+------------+------------+--------------+-----------------------+

chrome_profiler.zip

Will further modularization help?

On thing that helps a bit is using lld:
λ cat ~/.cargo/config
[build]
rustflags = [ "-C", "link-arg=-fuse-ld=lld" ]⏎

That's strange, I tried it a couple of times, and it made zero difference for RA. It does help a lot on other projects.

Since I now got a fancy desktop PC which is not generally slow here is another observation: The compile cycle does barely use any parallelism.
The following is the CPU utilization for a small edit and recompile inside a file in ra_hir on a 12 core CPU:

The whole cargo build for this picture took 12s - so it's not super annoying. But it looks like it could go a lot faster if more resources are actually used. But I guess that is more likely a rustc than an actual rust-analyzer issue - unless the project is restructured to be more suitable to for parallelism (crates which are not that dependend on each other?).

I think small, incremental edits parallelize inherently worse, because there's less to compile. Still, it's not so bad:

But it's surprising how much debug info slows things down. Same scenario, touch crates/ra_hir/src/db.rs; cargo build --release -p ra_lsp_server:

How could one disable debug=0 constantly without an extra flag without having to constantly stash the change in Cargo.toml as soon as there's an update?

That's how, but you might not need to stash that often.
I generally use pull --rebase with autostash, so it doesn't come up most of the time.

Hm, should we put debug=0 into Cargo.toml? I think I personally can live with that, especially if it makes printf debugging faster :-)
We loose line numbers in backtraces, but I think I rarely look at backtraces (but we should retain debug=1 for releases, so that folks can get a useful backtraces from the debugger).
On the side note, one of the things I miss most from IntelliJ is the ability to colorize and linkify backtraces. If we could link rust::paths from backtraces to functions, that would be sooo helpful.

Hm, should we put debug=0 into Cargo.toml? I think I personally can live with that, especially if it makes printf debugging faster :-)

That depends on whether you're testing on debug or release builds. Re backtraces, unfortunately rust-analyzer pretty much never crashes for me. I've used the debug info for profiling, but I can enable it manually.

Well, I use rust-analyzer always with install-ra, which means afaic that I use release all the times. :/

It feels like it became significantly works for --release since we've introduced ra_ide_db crate, because now we repeatedly monomorphise hir for the same database in different crates.

Some measurements from today and a time before ra_ide_db introduction https://gist.github.com/matklad/9657836aa0a9ad226a95b6f18d55b3fc

:( :( :(

I haven't looked over the code, but is there a way to avoid that, maybe by introducing monomorphic wrappers?

So "introducing monomorphic wrappers" is exactly what ra_ide_db done, and it made things worse.
Ie, making DB non-generic does not work (or, rather, makes things worse), because all functions are still generic, but are now monomorphised in each crate that uses a non-generic database.

because all functions are still generic

Do you mean things like impl<'db, DB: HirDatabase> Semantics<'db, DB> that are still generic over the database? Can they use RootDatabase instead?

That as well, but mostly all query definitions, like infer_query.

(though, I still haven't really debugged this properly, my understanding of how monomorphisation happens might be wrong)

I can't try right now, but I'm curious what happens on a non-LTO build. It seemed to me that half of the build time was spent during linking.

with lto=false it is somewhat faster, but the general picture is the same
https://gist.github.com/matklad/c80618d9328546ca28f06ebe9022a327

Ok, looks like my analysis about monomorphisations was only partially correct. I've switch everything to dynamic dispatch in https://github.com/matklad/rust-analyzer/commit/68304de289ba88dda20e242c841859a8348d921f
It reduced the total compile time somewhat, but, contrary to what I've expected, every one of the big crates still takes a long time to compile.
https://gist.github.com/matklad/4a38367f0b2fd8da1c5c4f7c2297c00f

I think it would be very useful to compare self-profile data from the dyn commint and from the corrspondig commit before dyn-ing everything.

Is that with lto=false?

Nope, that's with lto.
Total build time for dyn is
real 210.67s
user 1570.88s
sys  15.58s
rss  966300k

for impl is
real 306.74s
user 2288.41s
sys  19.79s
rss  1061588k

Perf is essentially the same, binary is slightly smaller:
λ ./target/rust-analyzer-dyn analysis-stats ~/projects/rustraytracer/
Database loaded, 55 roots, 75.137501ms
Crates in this dir: 4
Total modules found: 40
Total declarations: 309
Total functions: 175
Item Collection: 3.382379153s, 0b allocated 0b resident
Total expressions: 4101
Expressions of unknown type: 187 (4%)
Expressions of partially unknown type: 94 (2%)
Type mismatches: 38
Inference: 5.032461187s, 0b allocated 0b resident
Total: 8.414847361s, 0b allocated 0b resident

17:46:38|~/projects/rust-analyzer|master✓
λ ./target/rust-analyzer-impl analysis-stats ~/projects/rustraytracer/
Database loaded, 55 roots, 72.812239ms
Crates in this dir: 4
Total modules found: 40
Total declarations: 309
Total functions: 175
Item Collection: 3.401339997s, 0b allocated 0b resident
Total expressions: 4101
Expressions of unknown type: 187 (4%)
Expressions of partially unknown type: 94 (2%)
Type mismatches: 38
Inference: 5.013217611s, 0b allocated 0b resident
Total: 8.414570169s, 0b allocated 0b resident

λ exa -l -all target/
.rwxr-xr-x 21M matklad 13 Mar 17:47 rust-analyzer-dyn
.rwxr-xr-x 24M matklad 13 Mar 17:47 rust-analyzer-impl

No significant difference in debug build-times, about a minute for each.

 The one on GitHub is 27 MB and mine is 28.

And the one on GitHub is presumably linked statically (but still stripped).

Maybe cargo-llvm-lines could help us identify some hot spots.

Yeah... I was hoping it would show us if there were a lot of monomorphized things we could reduce.

@lnicola @kjeremy  Note that RawVec::grow, which is pretty high on both of these lists, was recently changed to be mostly non generic in https://github.com/rust-lang/rust/pull/72013. Another similar optimization was done for iterator methods in https://github.com/rust-lang/rust/pull/72166, so they now use try_fold less, which is also pretty high on these lists.
Both PRs reduced the number of llvm-ir lines generated and improved compile time. They will land on stable in next Rust release in July, so until that, you might want to measure with cargo-llvm-lines on nightly to account for these improvements :wink:

@panstromek thanks for the heads-up.
Reply to this email directly, view it on GitHub
https://github.com/rust-analyzer/rust-analyzer/issues/1987#issuecomment-652202248,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANB3M7FRVZECURZQ77T3GTRZLDOTANCNFSM4I7OUNRA
.

SSR isn't heavy, Semantics is
I'll tell Niko that chalk-solve builds too quickly (chalk-parse takes ages)

After #5242:

One of my tests is to compile a new crate containing only this code:
use hir::Semantics;
use ra_syntax::{ast, AstNode, SyntaxNode};

pub struct MatchFinder<'db> {
    sema: Semantics<'db, ra_ide_db::RootDatabase>,
}

impl<'db> MatchFinder<'db> {
    pub fn new(db: &'db ra_ide_db::RootDatabase) -> MatchFinder<'db> {
        MatchFinder { sema: Semantics::new(db) }
    }

    pub fn find_matches(&self, code: &SyntaxNode) {
        if let Some(macro_call) = ast::MacroCall::cast(code.clone()) {
            self.sema.expand(&macro_call);
        }
    }
}

It takes 11.5 seconds (vs. ~35 last week).

Much more reasonable!

Substantial amount of the rest seems to be serde-generated code. Not sure how to combat that....

cc https://github.com/tokio-rs/tracing/issues/783

@lnicola do you have up-to-date CPU usage metrics over time?
Combining them with crates build chart would show bottlenecks where only a few cores are used.

We're pretty good on that front:
cargo-timing-20200707T083110Z.zip

Yeah, overall CPU usage looks very reasonable with exception of small 5 seconds window where only 3 threads are properly utilized.
16 thread CPU reveals some bottlenecks though:
cargo-timing-20200707T103522Z.zip

I wonder how much do we pay for may AST methods being trait methods. It might make sense to experiment with generating all methods as inherent methods, and then implementing traits via delegation to inherent methods. This will also reduce the amount of imports we od.

We should also try the self-profiling feature. Last time I wasn't really able to understand the profile output -- it seemed to me that ThinLTO took up to 80 seconds for some CGUs, but I didn't have a baseline to compare it with.

Let's close this: we implemented a couple of optimization in this space recently, and I feel that the compile times are reasonable .
One of the optimizations was to fix thermal throttling bug in my laptop: https://github.com/rust-analyzer/rust-analyzer/issues/5903#issuecomment-683181883 =/

One of the optimizations was to fix thermal throttling bug in my laptop

Wrong link?

Indeed: https://github.com/erpalma/throttled

Here's a fresh -Z timings output (on different hardware, though):


Activating privacy features error

Hi there,
I run a webserver on my server together with Wekan, I get the following error:
2018/03/18 09:33:13 [sub.host.domain.nl] failed to get certificate: [sub.host.domain.nl] error presenting token: Could not start HTTP server for
Mar 18 09:33:13 sub.host.nl systemd[1]: snap.wekan.caddy.service: Main process exited, code=exited, status=1/FAILURE
Mar 18 09:33:13 sub.host.nl systemd[1]: snap.wekan.caddy.service: Unit entered failed state.
Mar 18 09:33:13 sub.host.nl systemd[1]: snap.wekan.caddy.service: Failed with result 'exit-code'.

I want to run Wekan alongside my webserver. Is this possible?

error presenting token: Could not start HTTP server for challenge -> listen tcp :80: listen: address already in use

When you look at snap install page:
https://github.com/wekan/wekan-snap/wiki/Install
Wekan runs on localhost port 3001.
You can use Caddy to provide automatic Let's Encrypt SSL using ports 80 and 443, you add config to Caddyfile. There is easy examples for Wekan, static hosting, etc. Snap updates Wekan and Caddy automatically.
You seem to have some other webserver already at port 80.
If you'd like to use some other webserver that is more complex to configure, disable caddy:
snap set wekan caddy-enabled='false'

Then look at Wekan wiki:
https://github.com/wekan/wekan/wiki
At wiki menu at right, there is topic "Webservers" and under that Nginx, Apache and Traefik. From those examples you see how to enable websockets support on your chosen webserver, so that Wekan works correctly. Meteor js framework uses websockets to fast live updates, when there is changes in MongoDB.


Add note about Hooks working alongside Suspense

https://twitter.com/tylermcginnis/status/1057015589393227776

Would it make sense to add an alert/warning box to each of the methods (useEffect especially) stating that performing data fetching may best be done with Suspense instead of useEffect, as to make it very clear & not lost between the introduction & the API docs

@ThisIsMissEm I agree but went with the most subtle approach since I wasn't sure the overall sentiment on it. If the premise that Hooks are really only half the picture is actually true, seems like it should be all over.


Allow multiple platform API files

Currently, platforms can implement a public API. This is hardcoded to be built from {platform}/api.h and {platform}/api.cpp.
While this works and is useful, some platforms provide a fairly large API. Trying to keep all that in those two files becomes painful quickly.
This simple change allows one to split up the API implementation into multiple files. It changes nothing for existing implementations, but optionally allows one to have e.g. api/achievements.cpp, api/networking.cpp and api/specialplatformstorage.cpp be also included in the build, without having to modify the Godot source or build system when adding a custom platform implementation.

Thanks!


Bring back necessary content from docs folder & remove unnecessary components & styles

Partially reverts ml5js/ml5-website#184, which removes all of the docs content. After merging the PR, I realized that we still need to maintain docs for the About page and Community page in this repository.
While adding back these necessary subfolders, I also noticed that this repo contains a lot of unused code from previous iterations of the website. Since we're in a version-controlled context, it's safe to delete this content from the repositories.
Tested by ensuring that local Gatsby development builds still work and that navigating a locally hosted site works.

Since I merged a PR that breaks local builds, I'm going to merge this fix PR without review, but I'd love to get any feedback you have after merge and I can return to make updates later on.


Errors in Untitled files stay around

From @joaomoreno on June 6, 2016 9:26

Create a new Untitled file
Type const hello; in it
Change its mode to JavaScript
Close the file, don't save

There is an error laying around in the Problems view
Copied from original issue: Microsoft/vscode#7244

Will investigate. Very likely the tsserver not cleaning up correctly.

This is ESLint.

VSCode: 1.3.0-insiders, Commit:716f76, Data:2016-07-01
ESLint: 0.10.17
File was deleted, but the error message still stay in the Problems view

This got addressed with eslint 0.10.18


Manager and proxy mesh self-monitoring

This is a tracking issue to investigate mechanisms for self-monitoring in Manager and Proxies.
We would like to monitor health of manager service, proxies, proxy agents, completion of config reloads across Istio deployment in a consistent way.
Potential options to explore:

align with Mixer to trigger alerts and log status
align with Mixer's way of self-monitoring
utilize platform means (pod annotations or events in Kubernetes)

There are work items spread around the code to handle failure cases that need to be addressed.

Issue moved to istio/istio #1427 via ZenHub


Test without cannabis.ca.gov responding

In order to effectively test the new headless frontend we need to setup a local override so that requests going to the current monolith responding at cannabis.ca.gov right now will intentionally fail. This is critical for discovering unknown dependencies. We have found and fixed several of these already.

I ran this test by:
adding local hosts override so that cannabis.ca.gov pointed to <IP_ADDRESS>
I had no local server running so all requests to that top level domain would immediately 404
I verified this behavior was returnign 404s
Then I ran through the site test script using chrome on mac desktop: https://docs.google.com/document/d/1xVODGz3P0c5vO0Fe-pmdSV_FLntwpTzgG4EO_q-iIwc/edit
I didn't discover any new dependency issues. I did see that the favicon was broken, looks like it was still in the media directory and that is no longer copied from 11ty, will open separate ticket to address that


fixed login card UI

Closes #153

@RakeshSangem i think the button text should be at centre. but i don't think currently it's at the correct position (slightly on right side). what's your thought?

fixing that

thanks @Rounak-28

please check

@RakeshSangem

Hey @Rounak-28 , Could you fix padding issues. I mean follow some padding for login UI.
Reference Image

__
  Summary: :hammer_and_wrench: This code needs a fix

sorry I don't understand

sorry I don't understand

sorry I don't understand

@rohitdasu Could you explain to Rounak.
__
  Summary: :hammer_and_wrench: This code needs a fix  |  Tags: Inefficient

Hey @Rounak-28 , Could you fix padding issues. I mean follow some padding for login UI.
Reference Image

__        Summary: 🛠 This code needs a fix

@RakeshSangem could you please explain on which part the padding should be fixed? it would be helpful to understand.

Add border to card then it will great in my opinion.

Add border to card then it will great in my opinion.

Which color and how much width should I give to the border?

1 or 2px fine and don't use %100 black.

@RakeshSangem please check how's this looking

@Rounak-28 could you add color #eeeeee as border color please?

#eeeeee border does not looks good in light mode

@Rounak-28 i don't like the orange color for border for sure. use some lighter black color please.

how about white border on dark mode and something like gray for light mode?

how about white border on dark mode and something like gray for light mode?

white is fine but that shouldn't be 100% white. lighter is better

I suggest colors for you. #4e4e4e and #959595 Choose according with themes

also check how the colors should change for both light and dark mode. we are using next-themes. see how we can set these values @Rounak-28

@rohitdasu @RakeshSangem check now


Tweaked OS Detection project structure and added os check for PT Run

Summary of the Pull Request
This PR fixes the issue of PowerLauncher.exe getting launched on OS version less than 19H1 and also makes a few changes to the os-detection project structure.

os-detect.cpp and os-detect.h references have been added to common project. That way we can use the functions in C++ executables/dlls directly by referencing and without requiring os-detection.dll in that folder.
The reference to os-detection.dll in runner has been removed, and instead the method is accessed from common
os-detection.dll is still required for Image Resizer so no change has been made to affect that. In the future we could merge os-detection.dll into the PowerToysInterop library to reduce the number of additional projects/dlls.
In the Microsoft.Launcher project (which is the PowerToyModule project for PT Run), under the enable method where PowerLauncher.exe is launched a check has been added to launch the executable only if it matches the OS requirement.

References

PR Checklist

[X] Applies to #3730
[X] CLA signed. If not, go over here and sign the CLA

Validation Steps Performed
Verified that behavior is as expected for Launcher/ImageResizer/Settings on 1909, 1809 VM and an internal build number VM. Only for the 1809 VM the old settings would be loaded, image resizer would use its old settings UI, and PowerLauncher.exe would not be launched.

@enricogior this solves #3730 and partially solves some of the issues in #3354 . I have still kept the dll since it is required for Image Resizer so that it can make it's old settings UI visible when the OS version is older than 19h1.

@arjunbalgovind
we should remove the DLL and use the PowerToysInterop DLL instead. Having one DLL for one function is not ideal, otherwise we end up adding individual DLLs every time we have to expose something to C# projects. But we can merge your PR and complete the work later on, so please keep https://github.com/microsoft/PowerToys/issues/3579 open after merging this. Thank you.


Add expiry for unused proof-requests

vc-authn is used to access resources protected by OIDC authentication. As such, there should be a timout after which a proof-request that was not used will be marked as expired and removed from the queue of allowed authentication attempts.
Note: a special scenario, if/when supported, would be multi-use proof-requests (see #64). This can be effectively worked-around by having each proof-request be unique, and the multi-use scenario be a "redirect" case that would trigger a brand new authentication attempt every time.

It would be good to use the Aries/DIDComm ~timing protocol for this. May need to do some updates in ACA-Py and the BC Wallet to make it useful, but I think it is the right way to do expiries such as this.

possibly UI/Front end scope if this story get completed before end of sprint

@esune Do you still want to touch base on this ticket?

@popkinj and I synced-up: for the time being, we are going to ensure the UI gets a proof_status=EXPIRED if the proof-request age is older than what indicated in its expiry time. Further tweaks/improvements to be discussed with next steps.


Add instructions to inspect the Blobstore contents using mc

I merged, edited and restaged.
Don't forget to use https://github.com/pivotal-cf/docs-partners-template/blob/master/style-guide.md

https://minio-internal-blobstore-162142678.cfapps.io/minio-internal-blobstore/operator-guide.html#inspect
@jncd your changes https://github.com/pivotal-cf/docs-minio-internal-blobstore/commit/416675b00e5f40ded5c89e28de11f39039fdf3c7 makes it look like this (check the formatting of the commands):

Without it, it looks correct, like this:

Can you fix your changes?

Thanks, yes, I can make those changes.
I'll try to do it right this time. (Does Minio have any tech writers in-house?)

I'll try to do it right this time. (Does Minio have any tech writers in-house?)

Yes, there is a new tech writer who is getting up to speed

Thanks, yes, I can make those changes.

I tried to fix it, but could not figure it out.

I used the template here to format the commands. https://docs-wiki.cfapps.io/wiki/style/documenting-commands.html
(You can add the examples and define the variables.)

Ah, thanks for the link


[ahub] fix ahub issue

cast unsigned value to signed value and check its value it overrides sign-bit.

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2145. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @lhs8928, Applications/utils/jni/bitmap_helpers.cpp does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md


Embeddings

Hi there. I am upgrading my bindings for the lord of llms tool and I now need to be able to vectorize text to embedding space of the current model. Is there a way to have access to the latent space of the model ? I input a text and get the encoder output in latent space?
Best regards

Hi,
I am a little bit confused, maybe you are mixing terms!
Do you want to get the embeddings of the text? or you want the latent space of the encoder output ?

The latent space of the encoder output.

I don't think the encoder output is exposed by llama.cpp API header file AFAIK. But let me know if you have an idea.
But why you would use llama.cpp for this task ? why not just use the original LLaMA Python code in this case. You can get the output of any transform block you want ?

I was thinking to build an animation that shows the model encoder output moving inside a 2d or 3d projection of the latent space with a background of text chunks data distribution of the document that is used by chat_with_document personality. This allows me to see how the model is exploring the ideas while generating its outputs compared to the reference texts. So I kinda wanted to use the model being used at the instant and not need to reload another pytorch model that is not exactly the same and is not quantized. It eats memory space. I figured, it would be better to have every thing done by the same model.
Maybe I'll ask llamacpp for this feature.
Thank you anyway.

I was thinking to build an animation that shows the model encoder output moving inside a 2d or 3d projection of the latent space with a background of text chunks data distribution of the document that is used by chat_with_document personality. This allows me to see how the model is exploring the ideas while generating its outputs compared to the reference texts. So I kinda wanted to use the model being used at the instant and not need to reload another pytorch model that is not exactly the same and is not quantized. It eats memory space. I figured, it would be better to have every thing done by the same model.
Maybe I'll ask llamacpp for this feature.
Thank you anyway.

Yeah, I understand. Nice idea.
You can ask llama.cpp and if you get any solution I'll be more than happy to integrate it in the bindings.

I thought about it and maybe just expose the embed function of llamacpp would already be useful for me.

I think this is already exposed,
Are ou talking about llama_get_embedding, isn't-it ?

I need to give it text and it gives me the embeddings for the input text. Can you expose that in the model?

Ok, I will try to expose it in the model class.

In llama-cpp-python binding, they have embed function in their model:
https://abetlen.github.io/llama-cpp-python/
Also the ctransformers binding have embed method:
https://github.com/marella/ctransformers
I think they use the llamacpp in background.

yeah, if you want it just like what they did then I can add it. they are using the same function under hood.
The problem I was thinking about is just It is an overkill to eval the whole transformer to get just the first block.
If you are using the generate function on a prompt, then eval will be called and the embedding vector will change, without rerunning eval again.
Anyways I think I will add the two functions, one to get the last embedding and one to create them based on a string as input ?

Excellent!

@ParisNeo, Here you go
get_prompt_embeddings is what you are looking for.
if you don't have any other request I will push a new version to PYPI ?

Thanks. No requests for now. I'll update my binding as soon as you push it to pypi.
Thanks alot

You are welcome.
The new version has been pushed to Pypi.


permalinks and language switcher example are incompatible

As written the example language switcher doesn't work on pages that have a permalink, apparently regardless if there's a translated permalink or not.
Current example for posterity:
{% if site.lang == "sv" %}
  {% capture link1 %}{{ site.baseurl_root }}en{{ page.url}}{% endcapture %}
  {% t global.english %}
{% elsif site.lang == "en" %}
  {% capture link2 %}{{ site.baseurl_root }}{{ page.url  }}{% endcapture %}
  {% t global.swedish %}
{% endif %}

In my example I have default lang en, secondary fi. If you click language switcher from default e.g. /help/
You will end up at: /help/fi/help/
Whereas the expected would be: /fi/help/ or if defining a permalink_fi: /apua/ then I would expect it to lead to /fi/apua/
So in short, the example switcher doesn't work with permalinks or translated permalinks and I couldn't fiddle it to work with them on my own.

I have exactly the same existential question about switching between languages in a permalinked page.
Any suggestion about how to do that ?

Same problem here


Change the generated filename of seeder files

Laravel Version: 5.4
Voyager Version: 0.11.2
PHP Version: 7.1.1
Database Driver & Version:

Description:
It would be nice to namespace or prefix the generated seeder files so they don't collide with existing seeder files.

Steps To Reproduce:
This seeder files are generated when running ./artisan voyager:install

What is your idea here?
Maybe classes could be namespaced and files could be located inside a subfolder in the seeds folder.

/ping @abdgad for your thoughts.

maybe just adding Voyager prefix to the file names would suffice?

+1 for the special folder.

+1
Any update regarding this matter? I would love to see this enhancement soon... I'm good with the sub folder

+1 for the subfolder.  (Assuming it doesn't mess with autoloading at least)

Closing due to age for now.  We're still open to Pull Requests for this.  The only issue with the subfolder idea is that these classes aren't namespaced (by default at least), so you will still have name collisions.


Filter overrides facet in 3.1 beta

Describe the bug
Adding a text filter to a column when you already have a facet selected on a different column leads to the facet selection being reset.
To Reproduce
Steps to reproduce the behavior:
Example data:
Col 1,Col 2
a,b
c,d
e,f

Create a facet on Col 1
Select 'a' in that facet -> one row shows
Creata a text filter on Col 2
Type 'd' into the text filter
See that the facet is reset

Current Results
The filter essentially overrides the fact
Expected behavior
That the facet should remain with the same value selected, the filter should add to this, not override it
Screenshots
In 3.0 this works (see 'a' is still selected in facet)

In 3.1 the facet is reset - see that 'a' is no longer selected in the facet:

Desktop (please complete the following information):

OS: macOS Mojave
Browser Version: Safari Version 12.0.1 (146<IP_ADDRESS>.1)
java version "1.8.0_72"

OpenRefine (please complete the following information):

OpenRefine 3.1 Beta

Haven't had time to check thoroughly, but my guess is that the change in behaviour is related to https://github.com/OpenRefine/OpenRefine/commit/f327b09a596d8723a2915fd53a4d38c1bfc36c40


kubernetes-helm: 2.8.2 -> 2.9.0

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Failure on aarch64-linux (full log)
Attempted: kubernetes-helm
Partial log (click to expand)
building '/nix/store/xhv6gn7lzzbhmp8zxsbvv9vnpdmzci67-helm-2.9.0.drv'...
building
installing
linux-amd64/
linux-amd64/LICENSE
linux-amd64/helm
linux-amd64/README.md
/nix/store/8sd7p53snnl8iszbif15mkax2mivj424-stdenv-linux/setup: line 1227: /nix/store/k0n34jysfaxky40vmlgi4kgcp38rj816-helm-2.9.0/bin/helm: cannot execute binary file: Exec format error
builder for '/nix/store/xhv6gn7lzzbhmp8zxsbvv9vnpdmzci67-helm-2.9.0.drv' failed with exit code 126
error: build of '/nix/store/xhv6gn7lzzbhmp8zxsbvv9vnpdmzci67-helm-2.9.0.drv' failed

Success on x86_64-darwin (full log)
Attempted: kubernetes-helm
Partial log (click to expand)
                                 Dload  Upload   Total   Spent    Left  Speed
100 9471k  100 9471k    0     0  7084k      0  0:00:01  0:00:01 --:--:-- 7084k
building '/nix/store/z63f5wsf9x0wmwbvsb4xx621gxnwgrc1-helm-2.9.0.drv'...
building
installing
darwin-amd64/
darwin-amd64/LICENSE
darwin-amd64/helm
darwin-amd64/README.md
/nix/store/mhjbgwn2r5jgi2z15h60zvc8q0ppdwfs-helm-2.9.0

Thanks!


chore(main): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2024-12-17)
Features

generate images (9277891)

Bug Fixes

dont build on node 16 anymore (1412347)
ensure package.json is fine (c5b037a)
move files in place (dd21fd3)
style (6df7526)
use pnpm cache (6380463)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.0.0
:sunflower:


Simplify spawners

Rather than computing the total food and number of bugs near a spawner, make the food and bugs children entities of said spawner.

https://bevy-cheatbook.github.io/features/parent-child.html

Actually, this doesn't make sense as spawners are Resources, not components.


Load and Store the serialized version of the memory FS

Hey there! ZboxFS looks like an awesome virtual file system, that has a lot of potential, however, I have noticed that there is no way to store and restore the created memory file system, rendering it totally volatile. It makes using Zbox is scenarios like WASM as an embedded file system nearly impossible without additional hacks.
Am I missing something there? Thanks! Great work so far!

Thanks. Yes, the memory storage cannot be persisted because it is volatile. When the repo is closed, the memory storage is also released. So there is no way to open it again. To use in WASM, I think we need to wrap the memory storage in a static object, so that it can be re-used again.
Actually, that kind of reusable memory storage is already used in the faulty storage, which uses a in-memory static hashmap to store multiple memory storage. Take a look at it, hopefully that is what you want. In the future, I think we can extend current memory storage to include that feature. Thanks for your advice.

The wasm support is finally landed on, check out #32.


Fix references to Docker repository

The docker repo names in the README do not match the the actual repo (https://hub.docker.com/r/thethingsindustries/protoc), which causes errors in the docker CLI:
$ docker run --rm Thethingsindustries/protoc --help
docker: invalid reference format: repository name must be lowercase.
See 'docker run --help'.

To resolve this, this PR lowercases both references to the repository.

@erwinvaneyk Thanks!