[Bug]: ScriptUtils.splitSqlScript works incorrectly with statements containing IFs and LOOPs

Module
Core
Testcontainers version
1.19.1
Using the latest Testcontainers version?
Yes
Host OS
not relevant
Host Arch
not relevant
Docker version
not relevant

What happened?
Current version of ScriptUtils.splitSqlScript tries to take into account BEGIN...END blocks. However, it treats any END as an end of the block, even if it's END IF or END LOOP, so that the following one-statement script
BEGIN
     rec_loop: LOOP
         FETCH blah;
         IF something_wrong THEN LEAVE rec_loop; END IF;
         do_something_else;
     END LOOP;
END;

Is incorrectly  split into following "statements":
BEGIN
    rec_loop: LOOP
        FETCH blah;
        IF something_wrong THEN LEAVE rec_loop; END IF
-----------------------------------------------------------------
       do_something_else
-----------------------------------------------------------------
   END LOOP
-----------------------------------------------------------------
END

This is also broken for the case when a special statement separator is used (like GO in MSSQL tradition, / in Oracle tradition or @ in DB2).
The following statement is not split over @ sign as when it comes to the separator, the algorithm counted more ENDs than BEGINs and and since the balance is not zero, it is not splitting the code:
BEGIN
    rec_loop: LOOP
        FETCH blah;
        IF something_wrong THEN LEAVE rec_loop; END IF;
        do_something_else;
    END LOOP;
END;
@
CALL something();
@

Relevant log output
No response
Additional Information
No response

Hi @inponomarev, please consider reading our Contributing guideline and the form before raising a PR and then and issue.

Thanks for taking the time to fill out this bug report! Before submitting a bug, please make sure there is no existing issue for the one you encountered and it has been discussed with the team via discussions or Slack.

Closing this as duplicate of #7646


removed from docs jenkinsPipelineEnvironments usage

we decommissioned jenkinsPipelineEnvironments suite param usage:
https://github.com/zebrunner/pipeline-ce/issues/240
Also let's think about migration steps for those who used them

done, no more info about this param on https://zebrunner.github.io/community-edition/user-guide/ page


error while loading package, class file ... has location not matching its contents

So, my project compiles, runs, and passes all its unit test fine, but when I try to run my Gatling tests from Maven I get
> mvn gatling:test
. . .
[ERROR] [2019-02-20 10:22:38,442] [main] [io.gatling.compiler.ZincCompiler$] error while loading package, class file '/Volumes/Repos/leaderboard/target/classes/net/kolotyluk/leaderboard/akka/package.class' has location not matching its contents: contains package object Akka
[ERROR] [2019-02-20 10:22:38,447] [main] [io.gatling.compiler.ZincCompiler$] error while loading package, class file '/Volumes/Repos/leaderboard/target/classes/net/kolotyluk/leaderboard/akka/endpoint/package.class' has location not matching its contents: contains package object endpoint
[ERROR] [2019-02-20 10:22:38,454] [main] [io.gatling.compiler.ZincCompiler$] error while loading package, class file '/Volumes/Repos/leaderboard/target/classes/net/kolotyluk/leaderboard/akka/endpoint/leaderboard/package.class' has location not matching its contents: contains package object leaderboard
[ERROR] [2019-02-20 10:22:38,487] [main] [io.gatling.compiler.ZincCompiler$] three errors found

These errors looks surprisingly similar to some errors I got trying to build my project with SBT, which is why I switched to Maven. If Gatling utilizes SBT to run, then it is more likely to fail.
I have used Maven a lot longer, and a lot more than SBT, and never found a crippling defect. However, I have found at least 3 crippling defects in SBT in that same time.
It would be nice to be able to invoke Gatling from Maven without any interference from SBT.
Feel free to play with the project at https://github.com/kolotyluk/leaderboard
<groupId>io.gatling</groupId>
<artifactId>gatling-maven-plugin</artifactId>
<version>3.0.2</version>

That’s most likely your package named Akka with capital A that breaks Zinc.
You should fix it and use lower case for packages.

I cannot rename my package Akka to akka, because then it conflicts with other things. If Zinc cannot handle that, then Zinc is broken, because nothing else has a problem with it. Also, what about the errors on packages endpoint and leaderboard?

I cannot rename my package Akka to akka, because then it conflicts with other things.

No, it's not that you can't, it's that you don't want to. If you don't know how to handle those conflicts in Scala, just don't name it "Akka/akka" but something else.

If Zinc cannot handle that, then Zinc is broken

The Java Language Specification has always been recommending (not requiring) that package names use lower case. This rules has always been adopted by everyone that I can understand bugs can happen went you don't follow this rule.

If Zinc cannot handle that, then Zinc is broken

Strictly speaking, I agree. You can open an issue there. But I suspect the best way to get this fixed is to contribute a fix yourself. I kind of expect that this won't be a priority for them as basically nobody names packages the way you do.

nothing else has a problem with it

scala-maven-plugin uses a very old  pre-1.0 version of Zinc. I guess there was a regression.

what about the errors on packages endpoint and leaderboard

Those are sub-packages and suffer from the same problem: capital A in full package name.
All in all, there's nothing we can do here.

Okay. renaming the package from Akka to akka_specific solved the problem. Thanks
I could not rename the package to 'akka' because that conflicts with all the akka... packages, and I could not find a work-around for that. It's not that I didn't want to change the name, it was more that I wanted to exhaust other solutions before trying that one.
I generally don't use Uppercase in package names, and I understand the package naming recommendations, but they are not specifications, and Zinc should conform to specifications over recommendations. Also, the Zinc diagnostics could be better.
Thanks for the link to Zinc, I will take a look at that.
I wonder if SBT uses Zinc, and why it falls prey to that or similar problems???
Thanks again for your help.

Zinc is sbt’s incremental compiler, ie sbt is built on top of it. And so is scala-maven-plugin and Gatling.


Create dependabot.yml

This PR adds dependabot config

Not something I want to add here, thanks anyway for the PR!


Remove inline-styles on .destroy()

Problem:
lory.destroy() does (currently broken see https://github.com/meandmax/lory/issues/84) unregister the slider but the styles on the js_slide element remain which can cause odd optical behaviour.
Solution:
Maintain added styles as object and on delete match against the current inline styles of the element (to prevent foreign styles to get deleted) and remove the ones added by lory before.
Update:
The items cloned by lory don't get removed on .destroy() too.

@Dangoo,
I removed all eventlisteners, and as far as I can see all listeners are gone. Hope this helped.
thx Max

Any chance this can be reopened?
 Unless I'm missing something. Example:
transition-duration: 0ms; transform: translate3d(-435px, 0px, 0px); transition-timing-function: ease;

After actually looking in the source, I confirmed the suspicion that nothing removes the added styles in the destroy method.
Adding a simple method and calling it when destroyed seems to take care of it.
function untranslate () {
    const style = slideContainer && slideContainer.style;

    if (style) {
        style[prefixes.transition + 'TimingFunction'] = null;
        style[prefixes.transition + 'Duration'] = null;
        style[prefixes.transform] = null;
    }
}

// ...

function destroy() {
    dispatchSliderEvent('before', 'destroy');

    untranslate();
    // ...


User is having to clear cache on their browser after every deployment to see latest changes

From @yfzwinnie on November 26, 2018 17:38
Copied from original issue: Microsoft/Access2Justice#805

Couldn't reproduce with current setup.
May be fixed with new deployment process.


make liteeth work

This pull request enables liteeth ethernet controller in poll mode.
At the moment there are two problems with liteeth ethernet controller under linux:

wrong liteeth csr addresses in dts; (it has to be 0xf0003800 instead of 0xf0009800 and has to be 0xf0003000 instead of 0xf0009000);
liteeth driver can't get irq line; interrupt controllers does not used in the right way.

The first problem can be fixed easy. The only uncomfortable thing is necessity to change many dts files in uniform way. To make things easy the common part of dts files is moved to a separate dtsi-file. As a result the dts board files contains only board specific data.
Tthe second problem is complex. The simple (and ugly) solution  is use liteeth ethernet controller in interrupt less (poll) mode. The performance is poor (80-90 Ko per second). Some improvements can be done by using linux kernel NAPI framework.

Tested on ARTY board.

Please see https://github.com/enjoy-digital/linux-on-litex-vexriscv/pull/18

@frantony - Long term we want LiteX to autogenerate the dts and embed it in the gateware (probably in the BIOS) to be passed to Linux when it boots.

@frantony - I have a very hacky tool which tries to auto-generate the DTS file at https://github.com/mithro/litex-devicetree

@frantony Also see the issue at https://github.com/enjoy-digital/linux-on-litex-vexriscv/issues/10 for more links / information.

FYI - @pgielda

@mithro
Is there any viable example for https://github.com/mithro/litex-devicetree ?
I have tried it:
litex-devicetree$ python3 csr2dt.py --csr_csv ~/litex/litex/litex/boards/targets/soc_basesoc_de2_115/soc.csv
Traceback (most recent call last):
  File "csr2dt.py", line 895, in <module>
    main(sys.argv)
  File "csr2dt.py", line 844, in main
    for record_type, record_name, record_value, record_size, record_mode in csv.reader(open(args.csr_csv)):
ValueError: not enough values to unpack (expected 5, got 1)

Can you post your .csv file somewhere?

@mithro
Well, here it is! It's CSR map for SoCSDRAM-based DE2-115 gateware:

soc-csv.txt

Sorry, Github can't attach csv-file. But it can attach txt-file.

Thanks @frantony for the pull request. It's merged. For the CSR addresses, it's because of a change in LiteX to define the CSR, Ethernet will now use 0xf0003800 and 0xf0009800 for all targets and should no longer change.
For the second issue, @daveshah1 knows what is missing as explained on IRC:

The problem with the interrupts is that Linux doesn't know about the VexRiscv specific CSRs
10:23 Either we could implement/emulate a PLIC or add a driver for the VexRiscv IRQ suppory
10:25 This could be based on the one from the old kernel, but with a different CSR number: https://github.com/daveshah1/litex-linux-riscv/blob/master/drivers/irqchip/irq-vex.c

We'll try to address that soon.

@frantony About irq-vex
CSR moved from
machineMaskCsrId = 0xBC0,
machinePendingsCsrId = 0xFC0,
to
      supervisorMaskCsrId = 0x9C0,
      supervisorPendingsCsrId = 0xDC0

(https://github.com/m-labs/VexRiscv-verilog/blob/09e5b0c53061c016e2c6a7f7e45119113641de5e/src/main/scala/vexriscv/GenCoreDefault.scala#L207)


Trivial Wording Fix for Introduction

Addresses https://github.com/source-academy/cadet-frontend/issues/362

Pull Request Test Coverage Report for Build 830

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 25.794%

Totals

Change from base Build 821:
0.0%

Covered Lines:
896

Relevant Lines:
2940

💛  - Coveralls

@ReignOfComputer The travis build fails for some reason (I don't think it should, from looking at your changes)


SDK-426: moved UIApplication accesses to Main Queue

Accessing instances of UIApplication on any queue other than Main Queue causes Xcode's Thread Sanitizers to raise warnings & can result in undefined behaviour as all UIKit objects must always be accessed from the Main Queue.

hi @ygit
Changes are ready for review?

Yes @Aditi3
Ready for Review


Support large diffs/binary files

I have a pretty large diff and it appears that parse-git-diff is unable to process all of it.
https://gist.github.com/kentcdodds/4cbf74cfb232f798e71603d0deb91f4d
I included the JSON for the parsed output I get for this. It's missing a couple files. I'd also like to have the binary files represented as changed/added/deleted if possible.
I'm thinking this is one part bug report, and one part feature request 😅

I think it may be the data.db file. Because if I remove that before running the diff everything seems to display (except the other binary files).

I wonder if the issue is related to the binary files. Perhaps parse-git-diff stops processing the diff once it finds a binary file and that's why all the rest of the files aren't included in the parsed output?

It's fixed and released in v0.0.11

Thank you!

I tried the latest version and it isn't parsing things properly.
Here's the diff I passed:
diff --git var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.problem.outlet/bn604czq5nh/app/assets/img.png var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.solution.outlet/bn604czq5nh/app/assets/img.png
index d7077fa..84d259b 100644
Binary files var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.problem.outlet/bn604czq5nh/app/assets/img.png and var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.solution.outlet/bn604czq5nh/app/assets/img.png differ
diff --git var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.solution.outlet/bn604czq5nh/app/assets/img2.png var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.solution.outlet/bn604czq5nh/app/assets/img2.png
new file mode 100644
index 0000000..636c497
Binary files /dev/null and var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.solution.outlet/bn604czq5nh/app/assets/img2.png differ
diff --git var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.problem.outlet/bn604czq5nh/app/root.tsx var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.solution.outlet/bn604czq5nh/app/root.tsx
index f4fc7f7..703fce2 100644
--- var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.problem.outlet/bn604czq5nh/app/root.tsx
+++ var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.solution.outlet/bn604czq5nh/app/root.tsx
@@ -7,9 +7,10 @@ import {
 	Scripts,
 	ScrollRestoration,
 } from '@remix-run/react'
-import tailwindStylesheetUrl from './styles/tailwind.css'
 import { KCDShop } from './kcdshop.tsx'

+import tailwindStylesheetUrl from './styles/tailwind.css'
+
 export const links: LinksFunction = () => {
 	return [{ rel: 'stylesheet', href: tailwindStylesheetUrl }]
 }
diff --git var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.problem.outlet/bn604czq5nh/app/routes/deleted.tsx var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.problem.outlet/bn604czq5nh/app/routes/deleted.tsx
deleted file mode 100644
index 9080896..0000000
--- var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.problem.outlet/bn604czq5nh/app/routes/deleted.tsx
+++ /dev/null
@@ -1,5 +0,0 @@
-import { json } from '@remix-run/node'
-
-export async function loader() {
-	return json({ iAm: 'deleted' })
-}
diff --git var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.problem.outlet/bn604czq5nh/app/routes/index.tsx var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.solution.outlet/bn604czq5nh/app/routes/index.tsx
index ceb48f8..c5f1b30 100644
--- var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.problem.outlet/bn604czq5nh/app/routes/index.tsx
+++ var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.solution.outlet/bn604czq5nh/app/routes/index.tsx
@@ -1,12 +1,7 @@
-import { Link } from '@remix-run/react'
-
 export default function Index() {
 	return (
-
+

Welcome to the app

-			<Link to="/whatever" className="text-blue-800 underline">
-				Go to "/whatever"
-			</Link>

 	)
 }
diff --git var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.solution.outlet/bn604czq5nh/app/routes/parent.tsx var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.solution.outlet/bn604czq5nh/app/routes/parent.tsx
new file mode 100644
index 0000000..9fd1945
--- /dev/null
+++ var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.solution.outlet/bn604czq5nh/app/routes/parent.tsx
@@ -0,0 +1,3 @@
+export default function Parent() {
+	return
I am a parent

+}
diff --git var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.problem.outlet/bn604czq5nh/package.json var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.solution.outlet/bn604czq5nh/package.json
index 6aad87d..0a945ff 100644
--- var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.problem.outlet/bn604czq5nh/package.json
+++ var/folders/kt/zd3bfncd0c3gjx25hbcq483c0000gn/T/kcdshop/diff/example/exercises__sep__01.nested-routing__sep__01.solution.outlet/bn604czq5nh/package.json
@@ -1,19 +1,14 @@
 {
-  "name": "exercises.01.nested-routing.01.problem.outlet",
+  "name": "exercises.01.nested-routing.01.solution.outlet",
   "private": true,
   "sideEffects": false,
-  "kcd-workshop": {
-    "testRequiresApp": true,
-    "scripts": {
-      "test": "echo \"\\x1b[36mhello\\x1b[37mworld\" && sleep 0.7 && echo hi && sleep 0.7 && echo hi && sleep 0.7 && echo hi && sleep 0.7 && echo hi && sleep 0.7 && echo hi && sleep 0.7 && echo hi && sleep 0.7 && echo hi && sleep 0.7 && echo hi && sleep 0.7 && echo hi && sleep 0.7 && echo hi && sleep 0.7 && echo hi && sleep 0.7 && echo hi && sleep 0.7 && echo hi && sleep 0.7 && echo hi && sleep 0.7 && echo hi && sleep 0.7 && echo hi && sleep 0.7 && echo hi && sleep 0.7 && echo hi"
-    }
-  },
   "type": "module",
   "scripts": {
     "build": "run-s build:*",
     "build:remix": "remix build",
     "build:server": "tsx ./other/build-server.ts",
     "dev": "remix dev -c \"tsx ./index.js\" --no-restart",
+    "test": "echo TODO",
     "format": "prettier --write .",
     "lint": "eslint --cache --cache-location ./node_modules/.cache/eslint .",
     "start": "cross-env NODE_ENV=production node .",

And here's the output:
{"type":"GitDiff","files":[]}


autoFocus not working for Select component

In documentation for Select it says that inherents all props from input component. So I tried to set autoFocus prop on Select and it does not work.
codesandbox:
https://codesandbox.io/s/15po0w9wj

Tech
Version

Material-UI
1.0.0-beta.38

React
16.2.0

browser
chrome

@rpkRED This is a good catch! The autoFocus property only works for the native implementation.

@oliviertassinari Hey!
I would like to implement this.
Should we convert Select to class component in order to add or componentDidMount hook, or autofocus logic must be added to SelectInput?

@nicoffee The Select component is an API "glue". The core logic is in the SelectInput :).


Web Interface like scikit-learn

Developing a web interface like scikit-learn will help others understand better. The Ui may contain

Model Name
Model Specs
Model Description
Model snippet
Example

Hi. Could you elaborate a bit on the purpose / use cases of such a web interface.


Integration tests being skipped

In some of the workflow runs the integration tests are outright skipped, providing no error logs.
I've never seen this issue before in other codebases. Its cropped up in this repo for a couple months, most recently in #1328 (relevant comments 1 and 2) and in #1331 (screenshot of associated job run).
Its occuring on forks, as well as on internal repo branches.

Whelp. Turns out I just completely missed the if: github.event.pull_request.draft == false line in the integration test workflow


[BUG] original name is not displayed at the new compressed image

[READ] Step 1: Are you in the right place?
Yes
[REQUIRED] Step 2: Describe your configuration

Extension name: _ (storage-resize-images)
Configuration values (redact info where appropriate):
-Size:64x64
-Cloud Storage Path: empty

[REQUIRED] Step 3: Describe the problem
I just added storage-resize-images extension to my firebase project, it is working as expected when i upload an image manually from the firebase console, but the problem is that whenever i use
storageRef.putString()

function to upload base64 url encoded image to the firebase storage cloud, the compressed image will be created but its name is only _64x64 (not original_64x64).
Obviously i am resizing images as 64x64.
Since the created file doesn't contain a unique name it is unaccessible for me dynamically...Is there something am i missing?
Steps to reproduce:
Install storage-resize-images extension to my firebase project.(web)
Expected result
storage-resize-images extension to create an image file using the "original.jpeg" image as "original_64x64.jpeg"
Actual result
The extension generated the image as expected but the naming was wrong, it is _64x64.jpeg instead of original_64x64.jpeg

Hey @emrebicer thanks for reporting this issue, will get this looked at.

You can set a file extension when using putString by  specifying a the file name when creating a storage reference:
const imageStorageRef = firebase.storage().ref('images/space.jpg');
// ...
imageStorageRef.putString(/* ... */) // ..

Is there some other case where it would never set a file extension?

Looks like

You can set a file extension when using putString by specifying a the file name when creating a storage reference:
const imageStorageRef = firebase.storage().ref('images/space.jpg');
// ...
imageStorageRef.putString(/* ... */) // ..

Is there some other case where it would never set a file extension?

After adding ".jpg" at the end of my file names the problem went away. It looks like a proper solution for me. Closing the issue, thank you :).

Still experiencing this when an uploaded file does not have an extension.
I am aware that I can check whether filename has an extension before uploading, but IMO the resize image extension should be able to handle case without file extension.
Can this be re-opened ?

@Salakar We should support file names without file type extensions. Can you work on a PR to fix this?

Actually I see it's fixed in https://github.com/firebase/extensions/pull/134 :)


Appstudio update mvp-test-component

Pipelines as Code configuration proposal

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
11 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
13 seconds
sanity-inspect-image

✅ Succeeded
18 seconds
deprecated-base-image-check

✅ Succeeded
16 seconds
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
7 seconds
sanity-optional-label-check

✅ Succeeded
7 seconds
sanity-label-check

✅ Succeeded
6 seconds
show-summary


Fix ChannelTabs for the new version of Discord

thank you

I've put up my fixes here, so which should automatically update in case I fix anything in the future.

I hope someone does something similar for TypingIndicator, it doesn't have to be you if you're not interested though, thanks for at least taking on one of them.

I dont have the button for addin g channel to fav.Am i miss some plugins or setting?

Thanks for the fixes @samfundev !!

is this PR still up to date?

@l0c4lh057 There was one change that wasn't in the PR, I've just added that in the latest commit.

highly appreciated @l0c4lh057 and @samfundev.

hey @samfundev, not sure if you are still around but if so, the favorites feature stopped working with discord's newest version. When we right click on any tab, doesn't open the drop down menu anymore so we can't add favorites or remove existing ones. I tried to resolve it myself but way out of my depth. Willing to pay if you have time to look into this please.
Attached error that shows in console when I right click on a tab

Hey @samfundev if you are around, it broke again :( If you are able to fix I can tip!

Posting this here because I don't know where else to put it
@samfundev You might be aware already, but Discord broke all the plugins again, and just wanted to know if we can expect a fix when you have the time for it ?


Implement pureness tests for FFI based on property testing

Along with typetests which verify the spec of a function we want a property test that checks whether used FFI call is pure and total.
For example:
myDivision : Float -> Float -> Float
myDivision =
  ffi "Kernel" "/"

Should verify "all" possible incomes and outcomes:

Check the params for 0 and any possible random floats  -2^128 - 2^128
Verify if there is a return value of type float. If not fail the test
->
Function throws an error when second parameter is a 0. It has to be fixed by using different module like ffi "NativeBasics "safe_div"

Example 2
myMap : (Bool -> Int) -> List Bool -> List Int

Generate a function verifying that it took a bool and returning a random int
Generate a list of random length with random bools inside
Check if function always returns a list of integers. If not throw

Etc

Blocked by #202


Split up xbuild Prow job

currently our prow xbuild job takes nearly an hour to run. It would be nice if we could split this job up into different jobs that built the images for different architectures that run separately. We should already have most of the cruft required for this in our Makefile, so it should mostly be a matter of writing the prow job yaml.

/dibs

/assign @mszostok
Do we still have the #dibs in the docs somewhere? We should be using the kubernetes prow commands now.

@MHBauer tbh I just followed the Jonathan approach from this issue https://github.com/kubernetes-sigs/service-catalog/issues/2189#issuecomment-501493368 :D
and about the #dibs it's still mentioned here:

https://github.com/kubernetes-sigs/service-catalog/blob/492c01787080a7bc72dfb221007998e9c5abd773/CONTRIBUTING.md#L13-L17
https://github.com/kubernetes-sigs/service-catalog/blob/492c01787080a7bc72dfb221007998e9c5abd773/docs/devguide.md#L17-L21

oh, yea, I forgot that people have to be org member for assignment.
Even so, that's the only thing, and it's helpful for us to use the tooling we have. It's easier to check while browsing, what's been assigned, and who to talk to if you want and update on progress or to take over.

if building each image e.g. service-catalog-image for 5 different architectures (amd64 arm arm64 ppc64le s390x) is really necessary?

I don't know about arm or arm64, but IBM requires amd64, ppc64le & s390x.

could you point me, where you are using that?
I understand that the svcat binary should be built against different platforms because it's directly executed on the client host and each of us can have a different OS arch.
But what about the user-broker-image, test-broker-image, service-catalog-image, healthcheck-image? In production, they are executed as a docker container inside the Kubernetes cluster and they are shipped with docker image with the amd64 arch. (check that job: https://travis-ci.org/kubernetes-sigs/service-catalog/jobs/540981158)
Times
When we split prow xbuild job to:

user-broker-image & test-broker-image
service-catalog-image
healthcheck-image
svcat-all

and each of them will be built against 5 different arch then each build will take around 25minutes.
When we will execute that only against amd64 then it will take the only 5min.
Errors

Discussed on the SIG meeting. The service catalog binary is executed directly on OS, instead of using the default docker image. Currently, we want to leave support for all of the architecture.

Description
I've created PR to split the pull-service-catalog-xbuild job.
Instead of having one pipeline for building all images we split that into:

pull-build-all-images-for-amd64
pull-build-all-images-for-arm
pull-build-all-images-for-arm64
pull-build-all-images-for-ppc64le
pull-build-all-images-for-s390x
pull-build-all-images-for-svcat (cli for darwin, linux, windows)

pros:

reduce pipeline time from 1h to around 7min
based on investigation https://github.com/kubernetes-sigs/service-catalog/issues/2663#issuecomment-509289729, the most common random failures are connected with architecture so splitting by that type will help for restarting only failed builds

cons:

have 5 additional pipelines

Based on the pros IMO is worth to have those additional 5 pipelines. What's more, they are split by arch so it's a fixed number of pipeline regardless of the number of domains (brokers, apiservers, healtchecks etc.)
I've tested that solution by executing those build on our test-infra clusters, results:

pull-build-all-images-for-svcat duration: 4m31s
pull-build-all-images-for-amd64 duration: 4m24s
pull-build-all-images-for-arm duration: 7m2s
pull-build-all-images-for-arm64 duration: 5m27s
pull-build-all-images-for-ppc64le duration:  6m49s
pull-build-all-images-for-s390x duration: 5m36s

Sum duration: 43m55s
Outdated solution
The first approach was to split build into:

brokers-build-image-all-arch (user-broker & test-broker)
service-catalog-build-image-all-arch
healthcheck-build-image-all-arch
svcat-build-image-all-arch

pros:

reduce time to merge from 1h to 25min
have only 3 additional pipelines

cons:

based on investigation https://github.com/kubernetes-sigs/service-catalog/issues/2663#issuecomment-509289729, the most common failures are connected with architecture so splitting by domain does not help too much
requires changes in makefile: https://github.com/mszostok/service-catalog/compare/master...mszostok:change-mf

Resolved by: https://github.com/kubernetes/test-infra/pull/13855
(merged&tested)

wow, nice!


scala cross compilation in scala plugin

Hey,
Scala has a problem with binary compatibility between minor version releases and currently we have to use plugins to cross compile scala libraries between multiple versions.
So i wanted to ask if it would be possible to build it directly into the scala plugin of gradle.
Then we can easily support multiple sourcesets per scala version. A bit like sbt currently does. Are you instresed into helping me implement this?
currently i have to resort to this plugin to do it, but it woul be better that it is just build into the default plugin.
https://github.com/prokod/gradle-crossbuild-scala

The way I did it in my gradle config is I created a separate build.gradle file per scala compiler version and included them as separate gradle modules sharing the same source directories:
settings.gradle
include 'proj_2.11'
project(':proj_2.11').with {
    projectDir = file('proj')
    buildFileName = 'build-2.11.gradle'
}
include 'proj_2.12'
project(':proj_2.12').with {
    projectDir = file('proj')
    buildFileName = 'build-2.12.gradle'
}
include 'proj_2.13'
project(':proj_2.13').with {
    projectDir = file('proj')
    buildFileName = 'build-2.13.gradle'
}

then in each individual file I can do:
build-2.13.gradle
buildDir = 'build-2.13'

clean {
    delete 'build-2.13'
}

sourceSets {
    main.scala.srcDirs += [file('src/main/scala-2-'), file('src/main/scala-2.13+')]
}

It's not ideal but it works alright. No additional plugins needed.


couple of small issues, just for the records, first time using this issue reporting system, so bear with me. :)

The new SDK 4.6.4 supports rounded labels W12DIA and W24DIA, would you mind adding them? thanks.
Autocut on the latest another_brother 1.0.2 appears to be not working on Android devices. It is the isAutoCut == false that is not working, which means that you cannot turn it off.
RJ4030Ai printer works perfectly on Android, but not on iOS. It is a Bluetooth device and I have paired them like all other Bluetooth printers
RJ4030 printer can be added, yet no customer paper is available, would you please add them at your convenience? Thank you. Keep in mind that RJ4030 is an Android-only Bluetooth printer.

@SoCaliOS try running the iOS build on a physical device, with a built ipa file, and try printing to the RJ4030Ai. I had issues having the printer communicating when running on a local dev build, but in production the code works just fine.

@mikhael28 that makes sense. I am surprised that you have the RJ4030Ai. I tested it on the 4" paper (BinPaper_RJ4030Ai.RD_W4in) and it worked on Android. I will test it on a .ipa later as it involves quite a number of steps. By the way, the error was PRINTER_SETTING_NOT_SUPPORTED. Not sure if you had the same problem when you tested with the actual device without using the .ipa. I have been using the runner.app from Flutter's build folder for iosphone. Thank you.

I do not have a 4030, I have a QL10 something - but I am assuming that the underlying issues of running the iOS build from XCode directly transfer between devices. I remember that I was looking at the XCode logs, and I saw that the device successfully connected to the Bluetooth device - and would successfully disconnect, as per the log message - but the communication to actually pruint would not work for whatever reason. The same exact could would work perfectly on Android though - when I built a deployed a new version to TestFlight and ran the build, I found that the printing worked just fine. Hence my suggestion for you to try using a .ipa if your app has not progressed far enough to have TestFlight builds.

Thank you for the suggestion. I have several other Brother Bluetooth-only printers and they were successfully tested on both iOS and Android, with actual respective devices, not on the simulator. RJ4030Ai is just strange and it is being replaced with RJ4230B. I will most definitely test the .ipa when I am ready.

Are you running on an Intel MacBook by any chance or Apple Silicon? If you can run iOS simulator, it sounds like you are running on an Intel computer.

Intel iMac. I wasn't running on the iOS simulator. I connected directly to my iPhone 13 Pro Max.

I just posted a new issue about this @SoCaliOS , you can check it out.

I have no issues with iPhone old and new, iPad old and new. Everything runs beautifully! For iOS, simply "flutter build ios --release" and install it on your device after a successful test. I will recommend following the instructions, which is super easy. I did no fewer than 12 apps and literally, I can build an iOS and an Android app with minimum effort.

Yeah, Intel architecture ftw I guess.

I believe that the default for the following are true for Android:
    printInfo.isCutAtEnd = false; // try to fix android
    printInfo.isLabelEndCut = false; // try to fix android

Without adding the above settings, even if you set printInfo.isAutoCut = true, it will always be cut after each print. I have been lazy and was allowing only Auto Cut settings, it appears that I need to add the above settings to make sure Auto Cut can be turned off under the Android platform.
P.S. I have not tested the difference between isCutAtEnd and isLabelEndCut, perhaps only one is needed.


11 pii section story

This combined PR changes the tests to use TypeScript, it also introduces a chunk of available HTML components all tested to work.

Codecov Report
All modified lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:loudspeaker: Thoughts on this report? Let us know!.


Meteor.JS install

How to install this on meteor.js? I tried the npm install and insert this inside my app
import moment from 'push.js'; const Push = require('push.js');
But the Push is still undefined..

Hmm... I'm actually not too familiar with Meteor, though it theoretically should work. Perhaps someone else might be able to offer assistance. Adding a "help wanted" tag.

Yeah there's something that I have not done correctly. This is actually my first time trying npm_modules in meteor.

@mroftalp import * as Push from 'push.js';

Hi
I can import the package into Meteor with npm but I get a "Push.create is not a function" error when I fire it.
Push exist, but with just this properties inside:

Permission:e {_win: Window, DEFAULT: "default", GRANTED: "granted", DENIED: "denied", _permissions: Array(3)}
default:e {_currentId: 0, _notifications: {…}, _win: Window, Permission: e, _agents: {…}, …}
Symbol(__esModule):true
_agents:{desktop: t, chrome: t, firefox: t, ms: t, webkit: t}
_configuration:{serviceWorker: "/serviceWorker.min.js", fallback: ƒ}
_currentId:0
_notifications:{}
_win:Window {stop: ƒ, open: ƒ, alert: ƒ, confirm: ƒ, prompt: ƒ, …}
Symbol(Symbol.toStringTag):"Module"

Any idea? Should I do something more to import correctly @rafinskipg ?
Do you made it work with Meteor @mroftalp ?
It seem to work great! I need it :D
Thank you for help

@Molosc First, install push. Type this command on your project directory through the terminal. meteor npm install push.js --save. Then when importing, it should be like this: import Push from 'push.js';. That's how I made it work with Meteor.


Error when calling report.load, "accessToken is required"

The current code is using both a direct call of powerbi.embed() before the DOMContentLoaded event and an indirect call using powerbi.init() after DOMContentLoaded.
The second call through powerbi.init() will internally cause call to embedExisting since there is a report already embedded in the element which then requires the configuration to be passed explicitly. This defaults to an empty object which does not have an accessToken and this fails validation.

Accidentally created this issue on wrong repo.  Auto-correct on the url got me.


added vote validation module for single image

checked the code and merged the developer branch to the main branch


Android networking code fails on numerous devices on WIFI if domain name is resolved to an IPv6 address

We have a networked game communicating with servers using HTTP. We have received dozen of complaints of players not being able to connect to the server.
The issue is 100% reproductible
IF your network receives an IPv6 AND
IF you have an Android device with OS < 4.3 (possibly also affects newer devices).
The current network implementation for Android fails immediately in NetJavaImpl.sendHttpRequest
The reason is because a time out value is set on the connection. If a timeout value is set on the connection, the call to connection.connect() fails immediately (1 sec.) instead of exhausting the timeout value (30,000 = 30 sec.) if an IPv6 is provided by the network.
error: "failed to connect to game.uniwar.com/2600:3c00::f03c:91ff:fea8:53af (port 80) after 30000ms"
despite what this message says, it fails immediately.
NOT CALLING the method below fixes the problem.
connection.setConnectTimeout(httpRequest.getTimeOut());
I suggest to remove this line from the Android implementation or to change the API to have 2 time out setters one for the connection & one for the read. Anyway, I am not even sure if Android implements a timeout on the connection...
I am wondering if the Android implementation is buggy. When failing to connect to IPv6 address, it will not try to connect to IPv4 as it should. The internal Android Implementation does not seem to follow the contract described below:
Android spec URLConnection
Some posts from Google suggesting that their implementation might be broken

I am not sure where I can find the C or Java from the Android implementation that deals with the connection time out value but if we find it. We should be able to understand the cause of the bug. It would be useful to know how widespread this issue is in term of the Android OS versions. If more and more ISP start to roll IPv6 addresses in name resolutions, then this issue might become more and more widespread if it is caused by the buggy implementation that deals with IPv6.

Issue & Workaround have been confirmed on the following devices: (Manufacturer, Device, OS)
Motorola	Droid X4 (XT984)	4.1.2
Motorola	RazrI	4.1.2
blu	Quattro 4.5	4.0.4
HTC	One V	4.0.3
Samsung 	GT-I9100 SGS2	4.1.2
Huawei	Ascend Y300	4.1.1
Samsung	Google Nexus S - Dev Ed.	4.1.2
Issue confirmed but workaround failing on:
Motorola	Droid X2	2.3.5
Samsung 	Fascinate	2.3.5
Amazon	Kindle Fire (2nd gen)	2.3.4
Issue not happening on:
Motorola	Nexus 6	5
Amazon	Fire HD 6 (4th gen)	4.4
HTC	One	4.3
HTC	Desire 820	5.0.2
Samsung	I747 SGS3	4.4.2
Motorola	E (XT1528) 2nd gen	5.1
Samsung	Galaxy S6	5
Samsung	Galaxy S5	4.4
Motorola	X (XT1060)	5.1.0
Amazon	Fire HDX 7 (3rd gen)	4.4.3
Kyocera 	Event	4.0.4

Apparently, it's just luck that it worked on devices with OS >= 4.3 because some players are reporting the issue on:
Samsung Galaxy S6 Edge running Android 5.1.1
Samsung Galaxy Note 5 with 5.1.1
It seems that Android devices have a broken IPv6 implementation (which would fine if it would gracefully switch to IPv4 as requested by the spec).
Similar issue related to IPv6 are explained here:
https://code.google.com/p/android/issues/detail?id=79576
https://code.google.com/p/android/issues/detail?id=3389
https://code.google.com/p/android/issues/detail?id=32621&q=ipv6&colspec=ID Type Status Owner Summary Stars
https://code.google.com/p/android/issues/detail?id=32662

There's sadly nothing we can do about this. We merely use the standard Java
classes for networking.
On Jan 15, 2016 8:20 AM, "Xavier Kral"<EMAIL_ADDRESS>wrote:

Apparently, it's just luck that it worked on devices with OS >= 4.3
because some players are reporting the issue on:
Samsung Galaxy S6 Edge running Android 5.1.1
Samsung Galaxy Note 5 with 5.1.1
It seems that Android devices have a broken IPv6 implementation (which
would fine if it would gracefully switch to IPv4 as requested by the spec).
Similar issue related to IPv6 are explained here:
https://code.google.com/p/android/issues/detail?id=79576
https://code.google.com/p/android/issues/detail?id=3389
https://code.google.com/p/android/issues/detail?id=32621&q=ipv6&colspec=ID Type Status Owner Summary Stars
https://code.google.com/p/android/issues/detail?id=32662
—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/3736#issuecomment-171891329.

Did you notice that the bug does not happen IF the 'connection.setTimeOut()' is not being called because in that case, the phone gracefully switches to IPv4?
That's why I am calling to make that changes. I currently have deployed production versions with that fix.

Perhaps you can send a PR with the suggested change?

The patch that I wrote fixes the issue only on some devices (4.x to 4.3). Due to the limited benefit of it, it is not worth doing a PR. We can close this issue. There is simply NO WAY to have an IPv6 server now that communicates correctly with Android devices (even OS 6.0.1 has issues causing slow communication of 30+ seconds when the server responds in less than 10 millis).

Hi, Some of our users are experiencing this issue, @JavaNoobsyBoobsy did you manage to solve it entirely by removing connection.setTimeOut()?
Btw, from my research, it seems that this bug started with version 1.8 of Libgdx.
I couldn't find anything directly related to the Net implementation between 1.7.2 to 1.8 except one method which only happens on the GWT implementation.
One other change I found which I'm not sure related, is a change in the android build tools from 23 to 25 on the Gradle dependencies.
I'm really desperate to fix this, as this wasn't an issue before 1.8.
Do you have any new ideas about it that weren't mentioned here?
Thanks,


fixed library grab line

Coverage remained the same at 16.439% when pulling 8adaccca3ce68e40be784e9128bbf1619e87d657 on hellcoderz:master into 158840c6beb2ea8784cfefe6bba8d77d2d964849 on groovyfx-project:master.


Add TryConvert for NonZero types

This PR adds support for NonZero types, which is part of std::num.
I tried using NonZero<T>, but ZeroablePrimitive is a nightly trait, so used a macro instead. It raises an ArgumentError if the value is zero, but I think a TypeError would work as well.
Edit: Switched to NonZeroI8, NonZeroI16, etc. since NonZero<T> is not available in 1.61.

Thank you! This looks good. Could you rebase on main, that should fix the failing tests, and then I'll merge this.

Thanks @matsadler!


Error: object must be from this instance

I clicked on this action in the merge editor dropdown:

Error: object must be from this instance
    at MergeEditorModel.getState (mergeEditorModel.js:287:23)
    at Derived.computeFn (conflictActions.js:65:47)
    at Derived.get (derived.js:75:39)
    at Derived.endUpdate (derived.js:126:26)
    at TransactionImpl.finish (base.js:100:26)
    at transaction (base.js:65:16)
    at ObservableValue.set (base.js:123:17)
    at MergeEditor.toggleShowNonConflictingChanges (mergeEditor.js:569:44)
    at ShowNonConflictingChanges.run (commands.js:193:34)
    at handler (actions.js:376:52)
    at InstantiationService.invokeFunction (instantiationService.js:46:24)
    at CommandService._tryExecuteCommand (commandService.js:81:59)
    at CommandService.executeCommand (commandService.js:50:33)
    at MenuItemAction.run (actions.js:317:41)
    at EditorCommandsContextActionRunner.runAction (actions.js:114:26)
    at EditorCommandsContextActionRunner.run (actions.js:106:28)
    at EditorCommandsContextActionRunner.run (titleControl.js:34:26)
    at NativeContextMenuService.runAction (contextmenuService.js:196:43)
    at Object.click (contextmenuService.js:174:30)
    at EventEmitter.onClickChannelHandler (contextmenu.js:16:25)
    at Object.onceWrapper (node:events:646:26)
    at EventEmitter.emit (node:events:526:28)
    at Object.onMessage (node:electron/js2c/renderer_init:69:746)

Fixed in todays main.


Mixed dtype: dot

Partially fixed https://github.com/chainer/chainer/issues/6436

Jenkins, test this please.

Jenkins CI test (for commit f5f8fe9be4a3248aece95eb0305c8fc63cce2708, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Hm, I don't know why Jenkins is failing.

Jenkins, test this please。

Jenkins CI test (for commit f5f8fe9be4a3248aece95eb0305c8fc63cce2708, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Jenkins, test this please.

Running jenkins to verify failure/fix that I cannot reproduce locally. Could be due to different gcc/nvcc version.

Jenkins CI test (for commit b6827e56bc7940cda6680db303236ad090a5a235, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

The above failure seems to be fixed (verified on Jenkins).

LGTM.


pull request for e2e test at 12/29/2016 02:56:15

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Keplr address doesn't match autostaking script address

Had reports of this for Desmos, maybe others. When your autostaking mnemonic is imported into Keplr, the address matches for most networks but some it does not. E.g. Desmos.
For the purpose of running the script, the address spat out by npm run autostake is the correct one. This is the one you should fund and the script will send TXs from. I'm not sure how to actually access this in Keplr as of writing but it's probably derivation path related.
If you see this on any other networks, please add to this issue. I'll put a note in the README asap.

I remeber I saw something like Desmos use another derivation path. But can't find it now.

Hmm we have everything we need to solve this now, as all chain registry data is available in the application. I think unfortunately we just have to break things here, but an operator can always override the slip44 path in networks.local.json if they want to continue supporting the old format as well.
I'll make sure this is mentioned in the README, and it will be clear enough to users in the UI if they need to 're-grant' to the validator.
I'll look to get a fix out for this ASAP to minimise how many grants are created against the wrong addresses

Is there any example I can follow for networks.local.json which handle bitsong issue please?

There's not really an issue, just fund the address the script gives you when you run it and use that as your botAddress. You just can't use it in Keplr and it's non-standard. The bot address should be a hot wallet + not heavily funded, so I believe it's workable in the meantime.

Thanks Tombeynon, will have a try ..

Desmos and Bitsong are using different coin types (Desmos is 852 and Bitsong is 639) from Cosmos, which is 118. Currently tools generating wallets for Bitsong and Desmos, including CLI and Keplor are using new coin types which will generate different wallet address from bot address. (I dont serve Persistence but seem facing the same situations)

@poorbuthappy see #304


Could you please provide a release?

Hi,
first of all: thank you for your amazing job. I really like you template engine.
I want to be able to download the latest release by just using curl. So I would be able to check your latest release here:
https://api.github.com/repos/osalvador/tePLSQL/releases/latest and download a zip file.
thank you

The master branch is the latest.  I would just pull it from GitHub directly with this URL:
https://github.com/osalvador/tePLSQL/archive/master.zip
If you have a need for the suggested URL, please explain further.
Thanks,
MK

@MikeKutz
you should make releases on github
you can put release notes in it.
it allows users to reference specific version they are using.
currently you don't have any release published.

I have to agree with @jgebal
And you know, if the user refers to a specific version, if the bug has already been fixed

We use releases with github for utPLSQL.
It's pretty easy to do manually.

done.
Let me know if I should do anything else (or if I should just close this Issue)
thanks,
MK


remove duplicated service account for constructing sds config

https://github.com/istio/istio/issues/6411
Fix multiple TLS certificates are not supported for client contexts error when pilot push cds to ingress-gateway

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
If they are not already assigned, you can assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @wattli @qiwzhang @JimmyCYJ

@quanjielin: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
4d737509c9e95ef76d3b0839341634edab1bf6cc
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

@quanjielin: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
ccd6d43a9a90e463db95dd62094a3b4188010b17
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: wattli
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS [wattli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Any test we can add?

Integration test needs to be added later, which pending on mock CA or citadel interface change done.


Hover not working for AR model Request textDocument/hover failed.

2024-07-25 15:21:50.247 [info] (my_project) [Error - 15:21:50] Request textDocument/hover failed.
2024-07-25 15:21:50.248 [info] (my_project)   Message: /Users/Anon/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/ruby-lsp-0.17.9/lib/ruby_indexer/lib/ruby_indexer/index.rb:245:in `resolve': undefined method `any?' [..]

      full_name = nesting.any? ? "#{nesting.join("::")}::#{name}" : name
                         ^^^^^
	from /Users/Anon/.gem/ruby/3.1.0/gems/ruby-lsp-rails-0.3.5/lib/ruby_lsp/ruby_lsp_rails/hover.rb:54:in `on_constant_read_node_enter'
	from /Users/Anon/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/prism-0.30.0/lib/prism/dispatcher.rb:1532:in `block in visit_constant_read_node'
	from /Users/Anon/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/prism-0.30.0/lib/prism/dispatcher.rb:1532:in `each'
	from /Users/Anon/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/prism-0.30.0/lib/prism/dispatcher.rb:1532:in `visit_constant_read_node'
	from /Users/Anon/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/prism-0.30.0/lib/prism/node.rb:5487:in `accept'
	from /Users/Anon/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/prism-0.30.0/lib/prism/dispatcher.rb:66:in `dispatch_once'
	from /Users/Anon/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/ruby-lsp-0.17.9/lib/ruby_lsp/requests/hover.rb:80:in `perform'
	from /Users/Anon/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/ruby-lsp-0.17.9/lib/ruby_lsp/server.rb:481:in `text_document_hover'
	from /Users/Anon/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/ruby-lsp-0.17.9/lib/ruby_lsp/server.rb:54:in `process_message'
	from /Users/Anon/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/ruby-lsp-0.17.9/lib/ruby_lsp/base_server.rb:128:in `block in new_worker'

  Code: -32603

Hi, can you first try update ruby-lsp-rails to the latest release.

Hi, thx. I using the extension from VSCode and it does not show that it needs updating. And the ruby-lsp-rails seems bundled inside ruby-lsp right? How do I do that on VSCode?

You're on the latest VS Code extension version, but the ruby-lsp-rails addon is at ruby-lsp-rails addon gem is at v0.3.5, and the latest is v0.3.11.
Normally it gets auto-updated, but something in your bundle may be constraining it.
First you can try BUNDLE_GEMFILE=.ruby-lsp/Gemfile bundle update ruby-lsp ruby-lsp-rails
If that doesn't work, then check if another gem may be constraining rbs, sorbet-runtime or prism.


Kotlin Android project fails with java11/java13

Expected Behavior
I have a simple Android Studio (AGP 3.5.1) + Kotlin (1.3.50) project that works fine with Gradle 5.6.2
I expect ./gradlew $TASK to continue to work after I upgrade to gradle 6.0-rc-1 and Java13
Not sure if it's a bug from Gradle, Jetbrains, Android or all of them.
Current Behavior
$ ./gradlew --scan dependencies
FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':app'.
> Failed to notify project evaluation listener.
   > wrong number of arguments
   > KotlinJvmAndroidCompilation with name 'debugAndroidTest' not found.

Publishing build scan...
https://gradle.com/s/yjwfqdw2ysrlk

Context
Fails in Gradle 6.0-rc-1 with Java13 and Kotlin 1.3.50 and AGP 5.3.1
Works if I use Java 8 and Gradle 5.6.2
Steps to Reproduce

git clone the gradle6 branch here

https://github.com/jmfayard/update-legacy-android-project/tree/gradle6

run ./gradlew --scan dependencies

Your Environment

plugin("android").version("3.5.1")
plugin("org.jetbrains.kotlin.android").version("1.3.50")
Operating system	Mac OS X 10.15
Java runtime	AdoptOpenJDK OpenJDK Runtime Environment 13+33

Build scan URL: https://gradle.com/s/yjwfqdw2ysrlk

Does it fail with Java 8 + 6.0-rc-1?

I'm not seeing a failure with JDK11 or JDK13 and 6.0-rc-1 with your branch when running gradle help or gradle dependencies.

id("com.louiscad.splitties").version("0.1.0")

This doesn't appear to be published and is coming from your ~/.m2.  Is it possible it has something funky in it?

I have to publish the plugin to gradle portal, but I'm seeing an issue for now, that I'm looking with Gradle folks to get resolved:
> Failed to post to server.
  Server responded with:
  You are not the owner of group com.louiscad.splitties

(happened after ownership transfer)

@big-guy The plugin publishing issue has been resolved since then, the project should work on your side now.

@LouisCAD Thanks, I'm still not seeing a failure.  Is there maybe something else that's different?  Does it not fail with JDK8 for you?

I have looked at this again. I can't reproduce the original error so I was digging a bit through the build scan and the stack trace in it. The failure is thrown when NamedDomainObjectProvider.get() is invoked reflectively within the Kotlin Gradle plugin. It is a weird error and I can't really see how that can happen unless there is a buggy behavior in the used Java RT or the classpath of the build itself is somehow screwed up. Some things in the build scan that might indicate this:

com.android.tools.build:gradle:3.1.3 (not 3.5.1) on the root build classpath
AdoptOpenJDK OpenJDK Runtime Environment 13+33 Java runtime VS 	Eclipse OpenJ9 Eclipse OpenJ9 VM openj9-0.16.0 (JRE 13 ... JVM -
https://scans.gradle.com/s/yjwfqdw2ysrlk#infrastructure

As I can't reproduce, I can't debug this further. With the current knowledge, I doubt that this is a regression in Gradle from 5.6.3 -> 6.0 or a specific issue with Gradle's Java13 support. I assume there is somethign fishy in the setup and the appearance of the error might depend on the (build) classpath order.
@jmfayard I also didn't see the gradle6 branch in your example anymore. Did you remove that on purpose? Are you still able to reproduce this issue?

Hello @jjohannes
I tried with different versions of Gradle + Java switching with https://sdkman.io/

This commit works with Gradle 6 https://github.com/jmfayard/buildSrcVersions/commit/8681484d6446a182a281e6e11cb8be812dd17624
This commit works with Gradle 5.6.3 https://github.com/jmfayard/buildSrcVersions/commit/648a4051f4e3e2a639f55ec7d6be0a5c8ff63e02

I have found that

Gradle 5 + Java 8 works
Gradle 5 + Java 11 doesn't work https://scans.gradle.com/s/4xe6vb75zwiha
Gradle 5 + Java 13 doesn't work (no Gradle support obviously)
Gradle 6 + Java 8 works
Gradle 6 + Java 13 doesn't work  https://gradle.com/s/dc3nq6nxekutu

@big-guy correct, the plugin was not published.
This can now be tested with the two commits I have indicated in my previous comment ^^

The strange thing is for me the build only runs on Jetbrains runtime 11

can't build apk on openj9 jdk which use less memory, my laptop has less RAM

I encountered a similar issue with AGP 4.0.0, Gradle v6.1.1, andEclipse OpenJ9 VM v1.8.0_242.
Upgrading to use Gradle v6.2.2 fixed it for me.

I encountered a similar issue with AGP 4.0.0, Gradle v6.1.1, and Eclipse OpenJ9 VM v1.8.0_242.
Upgrading to use Gradle v6.2.2 fixed it for me.

This did the trick.
Apparently, it's a known issue that should be addressed soon
https://github.com/AdoptOpenJDK/openjdk-support/issues/127

Closing as it looks fixed with the right combination of tools.


Turborepo errors out when using yarn pnp

What version of Turborepo are you using?
1.0.24
What package manager are you using / does the bug impact?
Yarn v2/v3 (not supported)
What operating system are you using?
Linux
Describe the Bug
turbo run ... fails with an error like
/home/itsbth/scratch/tr-sample/.pnp.cjs:15363
    throw firstError;
    ^

Error: Qualified path resolution failed - none of those files can be found on the disk.

Source path: /home/itsbth/scratch/tr-sample/.yarn/unplugged/turbo-npm-1.0.24-afce9e06ca/node_modules/turbo/
Not found: /home/itsbth/scratch/tr-sample/.yarn/unplugged/turbo-npm-1.0.24-afce9e06ca/node_modules/turbo/
Not found: /home/itsbth/scratch/tr-sample/.yarn/unplugged/turbo-npm-1.0.24-afce9e06ca/node_modules/turbo/.js
Not found: /home/itsbth/scratch/tr-sample/.yarn/unplugged/turbo-npm-1.0.24-afce9e06ca/node_modules/turbo/.json
Not found: /home/itsbth/scratch/tr-sample/.yarn/unplugged/turbo-npm-1.0.24-afce9e06ca/node_modules/turbo/.node
Not found: /home/itsbth/scratch/tr-sample/.yarn/unplugged/turbo-npm-1.0.24-afce9e06ca/node_modules/turbo/index.js
Not found: /home/itsbth/scratch/tr-sample/.yarn/unplugged/turbo-npm-1.0.24-afce9e06ca/node_modules/turbo/index.json
Not found: /home/itsbth/scratch/tr-sample/.yarn/unplugged/turbo-npm-1.0.24-afce9e06ca/node_modules/turbo/index.node

Require stack:
- /home/itsbth/scratch/tr-sample/.yarn/unplugged/turbo-npm-1.0.24-afce9e06ca/node_modules/turbo/node-platform.js
- /home/itsbth/scratch/tr-sample/.yarn/unplugged/turbo-npm-1.0.24-afce9e06ca/node_modules/turbo/bin/turbo
    at Function.external_module_.Module._resolveFilename (/home/itsbth/scratch/tr-sample/.pnp.cjs:15362:55)
    at Function.resolve (internal/modules/cjs/helpers.js:98:19)
    at generateBinPath (/home/itsbth/scratch/tr-sample/.yarn/unplugged/turbo-npm-1.0.24-afce9e06ca/node_modules/turbo/node-platform.js:110:46)
    at Object.<anonymous> (/home/itsbth/scratch/tr-sample/.yarn/unplugged/turbo-npm-1.0.24-afce9e06ca/node_modules/turbo/bin/turbo:6:3)
    at Module._compile (internal/modules/cjs/loader.js:1072:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1101:10)
    at Module.load (internal/modules/cjs/loader.js:937:32)
    at Function.external_module_.Module._load (/home/itsbth/scratch/tr-sample/.pnp.cjs:15211:14)
    at Function.moduleExports.runMain (/home/itsbth/scratch/tr-sample/.pnp.cjs:15412:31)
    at internal/main/run_main_module.js:17:47

It looks like there's some code to try to support pnp, but as the turbo package doesn't have any importable code require.resolve (https://github.com/vercel/turborepo/blob/cbc65fd7dc1ccf18f490d87a0db7ef469571368e/cli/npm/turbo-install/node-platform.js#L110) throws an error. On yarn 3.1.1 (latest as of now) turbo (and turbo-linux-64) appears to be unplugged by default, so it works when you comment out that section (alternatively, adding an empty index.js will make require.resolve work).
Expected Behavior
It should not crash.
To Reproduce

npx create-turbo@latest
Choose a directory and package manager yarn.
cd <directory>
yarn set version stable
yarn (migrates the lockfile and sets the linker to node-modules).
Turborepo (mostly?) works here.
sed -i '/node-modules/d' .yarnrc.yml (set linker mode to the default pnp).
yarn
yarn build (fails with the above error).

(Note: Even after applying one of the workarounds mentioned earlier the example project still doesn't build with pnp, even in loose mode, but turbo appears to be working)

Sorry about this, Turbo does not work with v2 yet. Closing as this is duplicate of #264.

This is a rather specific bug in code that appears to explicitly try to handle yarn 2+ pnp (and indeed it would have worked without that code as long as turbo is unplugged).
If you don't want to fix it until proper yarn 2+ support, would you accept a PR fixing this specific issue in the meantime?


Android gesture detection.

How can I add more categories/gestures to the model?
also, I have a problem the landmarks doesn't appear exactly in my hand...

Hey @Rawabi20 what device are you using? That looks like a UI bug (though maybe the left/right settings could be contributing to it, so I'll investigate that too). Basically the way the sample works is an image is taken from the camera, resized, inference is run, then the points for that resized image are sent back as a result to be rescaled and displayed.


feat: add support for JavaScript channels

Note: I did not check any of the below checklist yet.

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
[ ] I signed the CLA.
[ ] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[ ] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Please note that the current implementation contains a prefer_function_declarations_over_variables warning. Let's first see if we think this solution is a good solution in the first place.


[FEA] Automated canonicalization tests

Is your feature request related to a problem? Please describe.
One of the causes of #1308 is parts of the plan failing to canonicalize properly, and this confuses the Spark query planner into thinking it cannot reuse parts of the query that are reusable.  This ends up running scans redundantly during the query needlessly.
The canonicalization error was subtle and easy to miss, so we need a better way of automatically detecting when canonicalization methods are incorrect.
Describe the solution you'd like
One idea is to inject canonicalization testing into our existing unit and integration tests.  When running a GPU query, we could plan the query twice and verify that the two executed plans canonicalized are equivalent.
For example, if we have a plan like spark.sql(query).collect we could do something like this:
val plan1 = spark.sql(query)
val plan2 = spark.sql(query)
val isCanonical = plan1.queryExecution.executedPlan.canonicalized == plan2.queryExecution.executedPlan.canonicalized
plan1.collect

Describe alternatives you've considered
If we could programmatically generate unit tests for the various combinations of GPU Exec nodes and expressions that would be great, but I think artificially creating some of the input arguments outside of a query could be tricky.

@andygrove does this issue get resolved by PR #1349 or do we need to wait for https://issues.apache.org/jira/browse/SPARK-33744 to close this?

Yes, this was resolved by #1349. We skipped the canonicalization test on 4 unit tests due to SPARK-33744.


Visualizations: Long error displayed when selecting an overlay in histogram

I accidentally picked the wrong overlay in a histogram in GEMS1 (screenshot attached). The error took up the whole page. Maybe if the error should be displayed it could be short?

I can now select "Traditional healer, medical expenses amount" for my x-axis.
I cannot select "Bought remedy or medicine, transport expenses amount" for my overlay. This is because this variable has 9 unique values (only variables with 8 or fewer unique variables can be selected for the overlay)

Since this is the behavior we want, I'm closing this ticket


Mast: Watch voh.church

Mast requests the watch of the watch_keyword voh\.church. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

voh\.church has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Daniil in Charcoal HQ


make all latch members protected for consistency

make all latch members protected for consistency

@hkaiser can we ignore the codacity check? It doesn't show any details for me. Not sure if I need to be logged in for me to see something.

@msimberg yes, I wanted to try Codacy to see what this offers. It looks somewhat useful to me, but we can always remove the checking if it gets in the way.

Sure, I'm all for more checks. Let's try it and see what it gives as. And now the check green anyway, so I guess it just wasn't set up properly yet or something like that.


File.lastModified() succeeds even if path exists as a directory

Context: tests in https://gist.github.com/tvolkert/8c3f91d17ef258f50642eb941c394b87
You expect File.lastModified() (and File.lastModifiedSync()) to throw if the path references an existing directory (or symlink to a directory), yet they do not.

@zanderso


🔼 Investigate SMP calculation

User Story
As an orchard manager/technician, I want to know the genetic worth, mean latitude, mean longitude and mean elevation of supplemental mass pollination (SMP) that I apply on my orchard.
Acceptance Criteria

Clear understanding of the calculations and all dependencies, tables, required
Given that I enter the parent tree number and pollen volume in the SMP tab of the seedlot registration, the application calculates the genetic worth, mean latitude, mean longitude and mean elevation of supplemental mass pollination (SMP) that I apply on my orchard.
Business rule: The parent trees used in an SMP mix can be from outside of the orchard but are registered parent trees of the correct species.

Definition of Done:

[ ] Ready to Demo in Sprint Review
[ ] Does what I have made have appropriate test coverage?
[ ] Documentation and/or scientific documentation exists and can be found
[ ] Peer Reviewed by 2 people on the team
[ ] Manual testing of all PRs in Dev and Prod
[ ] Merged

PO + Craig + Mattheus tmr at 1PM?


8.5.2RC1 - CKEDITOR errors shown in console

expected
Given I am logged in
When I edit a content block
Then there should be no errors in the JavaScript console

actual
CKEditor errors logged in console, although they don’t seem to have any effect. This occurs in all browsers as of 8.5.2.
CKEDITOR: Error code: editor-element-conflict in console when editing content blocks

"although they don’t seem to have any effect. "

Not entirely true. I spent HOURS yesterday chasing down weird behaviour on one site I manage. All the other sites are fine but some unknown interaction with this bug made it impossible to choose an image for the content block even on a new page with the elemental theme. However, one only one site. At any rate @Kaapiii's fix seems to have resolved the issue.


Extract data team and os

depends on #319
The separation between data and templating was restored for team and projects sections; that way it will be way easier to keep those pages updated when adding, moving, sorting items.
I used this PR to add @creachadair to the team!
https://github.com/src-d/landing/pull/321/files#diff-6bb0d9fa032c3676084edae453eea5edR63
And move Alex to LA team
https://github.com/src-d/landing/pull/321/files#diff-6bb0d9fa032c3676084edae453eea5edR66

since there is no major changes, I'll auto merge this

Looks (retroactively) good to me! 👍

@creachadair
You're now in our landing!!!
welcome on board :dancer:
(it would be great if @marnovo brings his camera next week and fix this :wink:  )

[I]t would be great if @marnovo brings his camera next week and fix this 😉

It looks as if I'm not the only one missing!

@meyskens and @vcoisne are also missing, but I'm afraid they're not coming to the office next week :(

Maybe @marnovo forgot to add it?
You can also send it to me by email, and I'll do the rest.


Check if filteredParameters exists before assign them

Those parameters would not exist on exception response.
https://github.com/nexylan/paybox-direct/blob/c987cf793b49505212a15ae523aa77dbab3dcfd0/src/Response/DirectPlusResponse.php#L36-L37

See also #29


Add to_pymc method to distributions

Closes #517
This allows us to convert PreliZ distribution to PyMC distributions. This will work both inside and outside a model context.

Codecov Report
Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.16%. Comparing base (8f36b1e) to head (0a35ba2).
Report is 29 commits behind head on main.

Files
Patch %
Lines

preliz/distributions/distributions.py
72.72%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
- Coverage   82.36%   82.16%   -0.20%
==========================================
  Files          96      100       +4
  Lines        7895     7975      +80
==========================================
+ Hits         6503     6553      +50
- Misses       1392     1422      +30

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


811 series added entry--meeting name

https://github.com/uwlib-cams/MARC2RDA/blob/main/Working Documents/8XX.csv

@pennylenger Please note - before this mapping is ready for transform, there may be rows that get Rreproduction Conditions checked and need to have that information added. Let @lake44me and @dchen077 know when the mappings/transform are otherwise reviewed/approved.


DNM Dsw 0 form label switch

DO NOT MERGE - this is a demo of how to get pie-form-label component working with any input components we create, such as pie-switch

this has already been implemented in pie-form-label
https://github.com/justeattakeaway/pie/pull/1257


No license specified

There's no license specified. Feel free to help yourself with Choose a license website ;)

Thank you for pointing it out @clawfire! 😄


Allow ":" character in job names.

Right now we use some lame split logic that prevents us from using : in job names. Let's fix that so that we can use whatever name we like. We'll need to ensure the logic works for demands as well as scheduled jobs.

Fixed with #4

Fixed with #4


Switching from a non-rerversed sorting to a reversed sorting, back to a non-reversed sorting, keeps the reversion.

What system are you running Yazi on?
Linux Wayland
What terminal are you running Yazi in?
foot version: 1.17.2 +pgo +ime +graphemes -assertions
Did you try the latest code to see if this problem got fixed?
Tried, but the problem still
yazi --debug output

Yazi
    Version: 0.2.5 (Arch Linux 2024-06-08)
    Debug  : false
    OS     : linux-x86_64 (unix)

Ya
    Version: 0.2.5

Emulator
    Emulator.via_env: ("foot-extra", "")
    Emulator.via_csi: Ok(Foot)
    Emulator.detect : Foot

Adaptor
    Adaptor.matches: Sixel

Desktop
    XDG_SESSION_TYPE: Some("wayland")
    WAYLAND_DISPLAY : Some("wayland-1")
    DISPLAY         : Some(":0")

SSH
    shared.in_ssh_connection: false

WSL
    /proc/sys/fs/binfmt_misc/WSLInterop: false

Variables
    SHELL              : Some("/bin/fish")
    EDITOR             : Some("micro")
    ZELLIJ_SESSION_NAME: None
    YAZI_FILE_ONE      : None
    YAZI_CONFIG_HOME   : None

Text Opener
    default: Some(Opener { run: "$EDITOR \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block  : Some(Opener { run: "$EDITOR \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })

tmux
    TMUX   : false
    Version: No such file or directory (os error 2)

Dependencies
    file             : 5.45
    ueberzugpp       : No such file or directory (os error 2)
    ffmpegthumbnailer: 2.2.2
    magick           : 7.1.1-33
    fzf              : 0.53.0
    fd               : 10.1.0
    rg               : 14.1.0
    chafa            : 1.14.0
    zoxide           : 0.9.4
    unar             : 1.10.7
    jq               : 1.7.1

Describe the bug
Starting with sort --dir-first natural, then sort modified --reverse --dir-first, then going back to sort --dir-first natural, does sort natural --reverse --dir-first instead.
This does not to happen when switching from sort --dir-first natural to sort size --dir-first back to sort --dir-first natural.
Expected Behavior
Sorting should not be reversed when choosing a non-reversed sorting.
To Reproduce
See above.
Configuration
No response
Anything else?
No response

See https://github.com/sxyazi/yazi/issues/1046


Fix deprecation of constant OpenSSL::Cipher::Cipher in ruby-2.4

This PR fixes OpenSSL::Cipher::Cipher constant being deprecated in ruby-2.4

I agree this is needed, because my project (using Ruby 2.5.1) gets copious quantities of warning messages about the use of the deprecated OpenSSL::Cipher::Cipher.


Consider switching to a map based system instead of separate variables

Ex:
$color--main: (background: [#xxxxxx],
               text: [#xxxxxx],
               ...
               border: [#xxxxxx]) !default;

@mixin color ($color-map)
{
    background-color: map-get($color-map, background);
    color: map-get($color-map, text);

    ...
}

Advantages:

Color/font can be dynamically set; this is not possible when using separate variables / mixins because of the lack of variable / mixin interpolation in sass.
Number of (global) variables would be significantly lower.
...

Disadvantages:

No code completion in IDE.
Fails silently if a map value doesn't exist; map-get returns null with no warning/error. (Possible solution: write custom map-exists-and-get function.)
...

Idea: consider taking it one step further and putting all variables in one big nested $inkframe map + write a function that takes a list of (nested) keys for this map.
Ex:
background-color: inkframe(color, main, background);
color: inkframe(color, main, text);

Compromise that has the best of both worlds: define everything as variables, then automatically add colors / fonts / etc. to maps that can be passed to mixins, so only a single color / font / etc. mixin will be necessary. Ex:
// These can be overridden.
$color--main__background:                   $color--main !default;
$color--main__text:                         $color--contrast !default;
$color--main__text-alt:                     shade($color--main, 40%) !default;
$color--main__link:                         $color--accent !default;
$color--main__link-hover:                   shade($color--accent, 40%) !default;
$color--main__icon:                         shade($color--main, 10%) !default;
$color--main__border:                       $color--main__icon !default;

$colors--main:                             (background: $color--main__background,
                                            text: $color--main__text,
                                            text-alt: $color--main__text-alt,
                                            link: $color--main__link,
                                            link-hover: $color--main__link-hover,
                                            icon: $color--main__icon,
                                            border: $color--main__border,
                                            ) !default;

To think about: text-alt, icon and border might not need to be added to the map, since they can never be set automatically anyway.


docs(managedkafka): change old title to new title

Changes all instances of the "old" product title to the "new" one. Internal bug http://b/379316147

This change is

/gcbrun

Thanks! To pass the formatting build, can you run the following and commit the changes:
ci/cloudbuild/build.sh -t checkers-pr

And if you are wondering why this naming stuff is maintained by hand, there is some discussion in #10237

Thanks! To pass the formatting build, can you run the following and commit the changes:
ci/cloudbuild/build.sh -t checkers-pr

Done!

/gcbrun


Some more stuff on config overrides

A bit of continuation for #110.

Good point, done in https://github.com/biggraph/lynxkite-enterprise/pull/21.


Fallthorugh definition within OP-TEE 3.11-rc1 breaks fTPM compilation

OP-TEE introduced a #define fallthrough which is included in OP-TEE 3.11.0-rc1.
However this clashes with WolfSSL, leading to a compilation error:
| /home/phoenix/build/YOCTO.BSP-Pengutronix-Labgrid/build/tmp/work/cortexa7hf-neon-oe-linux-gnueabi/ms-ftpm-ref/1.0+gitAUTOINC+81abeb9fa9-r0/recipe-sysroot/usr/include/optee/export-user_ta/include/compiler.h:257:21: error: expected ')' before '__attribute__'
|   257 | #define fallthrough __attribute__((__fallthrough__))
|       |                     ^~~~~~~~~~~~~
| ./lib/wolf/wolf_symlink/wolfssl/wolfcrypt/types.h:184:50: note: in expansion of macro 'fallthrough'
|   184 |             #define FALL_THROUGH __attribute__ ((fallthrough));
|       |                                                  ^~~~~~~~~~~
| lib/wolf/wolf_symlink/wolfcrypt/src/asn.c:5062:9: note: in expansion of macro 'FALL_THROUGH'
|  5062 |         FALL_THROUGH;
|       |         ^~~~~~~~~~~~
| In file included from ./lib/wolf/wolf_symlink/wolfssl/wolfcrypt/asn.h:26,
|                  from lib/wolf/wolf_symlink/wolfcrypt/src/asn.c:53:
| ./lib/wolf/wolf_symlink/wolfssl/wolfcrypt/types.h:184:62: error: expected identifier or '(' before ')' token
|   184 |             #define FALL_THROUGH __attribute__ ((fallthrough));
|       |                                                              ^
| lib/wolf/wolf_symlink/wolfcrypt/src/asn.c:5062:9: note: in expansion of macro 'FALL_THROUGH'
|  5062 |         FALL_THROUGH;
|       |         ^~~~~~~~~~~~
| make[1]: *** [/home/phoenix/build/YOCTO.BSP-Pengutronix-Labgrid/build/tmp/work/cortexa7hf-neon-oe-linux-gnueabi/ms-ftpm-ref/1.0+gitAUTOINC+81abeb9fa9-r0/recipe-sysroot/usr/include/optee/export-user_ta/mk/compile.mk:159: ../out/AuthVars/./lib/wolf/wolf_symlink/wolfcrypt/src/asn.o] Error 1
| make[1]: Leaving directory '/home/phoenix/build/YOCTO.BSP-Pengutronix-Labgrid/build/tmp/work/cortexa7hf-neon-oe-linux-gnueabi/ms-ftpm-ref/1.0+gitAUTOINC+81abeb9fa9-r0/git/TAs/optee_ta/AuthVars'
| make: *** [Makefile:9: authvars] Error 2
| WARNING: exit code 1 from a shell command.

Relevant PR in OP-TEE can be found here: https://github.com/OP-TEE/optee_os/pull/4125

https://github.com/wolfSSL/wolfssl/pull/4563

Submodules needs to be updated on top of https://github.com/wolfSSL/wolfssl/pull/4580 once merged.


CXF-7501: Cannot inject field in ContainerRequestFilter (and generally, into any providers registered using FeatureContext)

Using proper CDI bean resolution with fallback to default strategy. The @Vetoed presented an edge case when CDI runtime won't resolve the bean but we have to go over manual instantiation.
CC @rmannibucau @johnament

LGTM
side note: do we have a test covering @Context injection/instantiation too? Wonder if we need a third case where we do the injection normally (standalone) then create an InjectionTarget to integrate with CDI.

@ApplicationScoped the provider, will be proxied so the injection will not be done as expected ;). A workaround used can be to support @Inject @Context but that's a workaround but CDI doesn't enable us to do more yet until you add automatically an @AroundConstruct interceptor to do the injection.

@rmannibucau I see, proxies do mess things up. I think would be good to solve that as a separate issue, it has more broad impact that the one this PR concerns. I will create a test case to reproduce that and an issue in the tracker. Sounds like a plan?

+1, that's why it was a side note ;)

Done, https://issues.apache.org/jira/browse/CXF-7544. @rmannibucau @johnament Thank you guys for helping out with proper implementation.

LGTM as well.  FWIW, I was able to cause it to fail using a CDI 2 feature of SE initialization.
SeContainerInitializer.newInstance()
        .disableDiscovery()
        .addBeanClasses(Resources.class, LoggingReporter.class, BraveProducers.class, RestApplication.class, TopCDsEndpoint.class, CXFCdiServlet.class)
        .addExtensions(new JAXRSCdiResourceExtension())
        .initialize();

In general, there are no issues using CXF with CDI 2, the integration continues to work fine.  This was just something I noticed and wanted to confirm as a real issue.
@Vetoed was the easiest way I had to explain where it would fail from a mobile


Migrate to googletest and add coverage reports

For my work on the config parser, I wanted an easier to use testing framework as
we had before. Right now only two tests are ported but the others will be quite
straight-forward
I have also linked this repo with coveralls.io so that we can see
what our tests missed.
I have also done some cleanup in the travis config file and created several
build configurations: [Debug, Release] X [gcc, clang] and a separate one for the
tests (using gcc because gcov needs gcc).

I see your concern and cloning googletest would be quite unnecessary especially on the build server.
If we made cloning optional, we would only be able to build the tests, if we specifically enable it when calling cmake, which is fine, it would just be a break from the current functionality. I will push another commit to make this happen.
As for the error, it seems to be only occuring with clang, because we have -Wmissing-field-initializers and clang complains about that and gcc doesn't. I will add -Wno-missing-field-initializers to the CXX_FLAGS

Done, I don't actually know how to give you access to the coveralls repo. This is strange, since it seems to be the first one to register a repo becomes the only one with access.

If you're not against trying out other suites we could also try codecov.

I'm open to that. Do you have any experience with codecov? One thing I noticed with coveralls is that the upload script doesn't work, if I pass the -a flag to gcov. What -a does, is give you coverage reports for each block, so for
if(x > 2 || y < 5) {
  ...
}

we get coverage reports for both x > 2 and y < 5. Do you know, if codecov supports that? It would be really useful to get coverage for every possible code path.
Would you look into that? I have already spent quite a lot of time on the coveralls integration.

Just looked a little at codecov and it seems it has a lot more features (and documentation) than coveralls. So switching to it may be beneficial to our testing efforts

I’ll take a look at migrating to it in the next few days.


cabal-dev can't distinguish .hi files

My install of cabal-dev on OS X (0.8 of hackage and d876a99b5b3651b10a283ba9ad381999e4bbaa8d) doesn't seem to include the module-specific path component when it's deciding where to place .hi files within ./cabal-dev/
Thus I get lots problems when installing multiple modules which have modules with the same name. For instance:
Something is amiss; requested module  MonadCatchIO-mtl-<IP_ADDRESS>:Control.Monad.CatchIO differs from name found in the
interface file MonadCatchIO-transformers-<IP_ADDRESS>:Control.Monad.CatchIO

with a reference to .../cabal-dev//lib/Control/Monad/CatchIO.hi.

I'm also having this problem. It's just as @thsutton describes. With the latest version of the haskell platform on OS X (the 64-bit variant, if it matters), the ~/.cabal/config file has this section:
install-dirs user
  prefix: /Users/nkpart/Library/Haskell/$compiler/lib/$pkgid
  libsubdir:
  datasubdir:
  docdir: $prefix/doc

install-dirs global
  prefix: /Library/Haskell/$compiler/lib/$pkgid
  libsubdir:
  datasubdir:
  docdir: $prefix/doc

So the ./cabal-dev/cabal.config gets spat out like this:
install-dirs user
  prefix: /Users/nkpart/railscamp/leave-forms/cabal-dev/
  libsubdir:
  datasubdir:
  docdir: $prefix/doc
install-dirs global
  prefix: /Users/nkpart/railscamp/leave-forms/cabal-dev/
  libsubdir:
  datasubdir:
  docdir: $prefix/doc

Could the prefix be made to include $compiler and $pkgid? Without some change here cabal-dev isn't going to work reliably on vanilla platform installs on OS X.


feat(CurriculumCard): added new career path card styles

Overview

changed the short description place placement on Curriculum Cards
Added new optional styles for the Career Path card to only appear when showCareerPathVariant prop is set to true
refactored the top level Card component on CurriculumCard to just use flex rather than grid.

PR Checklist

[x] Related to designs: https://www.figma.com/file/dowwtwoPxenj1Q7dToyl0z/Catalog-%26-Category-IA-🐈⬛?node-id=787%3A17605
[x] Related to JIRA ticket: Disc-515, Disc-514
[x] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.69-alpha.345ce7.0@codecademy/gamut-labs@30.0.1-alpha.345ce7.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://62276c22eed8e0f2b0dcea82--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.69-alpha.dad8c9.0@codecademy/gamut-labs@30.0.1-alpha.dad8c9.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://622773df7f1d5601b4ee97b7--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.69-alpha.71aea4.0@codecademy/gamut-labs@30.0.1-alpha.71aea4.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://62277711b8f15100add86c8b--gamut-preview.netlify.appDeploy Logs

Do you have a feature branch that uses it for QA?

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.69-alpha.3c9b94.0@codecademy/gamut-labs@30.0.1-alpha.3c9b94.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://622f754d957ed8272cf79892--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.69-alpha.6f9d8d.0@codecademy/gamut-labs@30.0.1-alpha.6f9d8d.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6230fcc67e0b9c18dea346d2--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.69-alpha.884c3f.0@codecademy/gamut-labs@30.0.1-alpha.884c3f.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://623109f8011c3826e83213e5--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.81-alpha.391004.0@codecademy/gamut-labs@30.2.7-alpha.391004.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://62310c9bbb9e322d8b5ac79e--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.81-alpha.7560e0.0@codecademy/gamut-labs@30.2.7-alpha.7560e0.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6233804d4e585f23dc8c00d0--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://62338662c022002a64361c7d--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.81-alpha.c1a531.0@codecademy/gamut-labs@30.2.7-alpha.c1a531.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://62338801634e182778496549--gamut-preview.netlify.appDeploy Logs


Couldn't install headless browser

(base) mike@mikes-mbp chatgpt-telegram-Darwin-arm64 % ./chatgpt-telegram
2022/12/04 17:47:55 Couldn't install headless browser: could not install driver: could not install driver: could not check if driver is up2date: could not run driver: exit status 1
Keep getting stuck on execution, thoughts on what this could be?

See the new Browserless Authentication section of the README.


          ?

Originally posted by @kylecarbs in https://github.com/coder/coder/issues/12499#issuecomment-1987237882

Add/add/run

          ?

Originally posted by @kylecarbs in coder/coder#12499 (comment)


Duplicate keys in the en.json file

Duplicate in row 67 and 78

Good catch. I will probably not make a seperate relase to remove them since it doesn't affect the behaviour but i will remove it with the next version, thanks.

I have removed the duplicate keys with v3.0.4


Comparing two profiles

I was wondering if there is any automated way to compare two profiles (flamegraphs) taken by async-profiler for same application?
Something similar to - https://www.brendangregg.com/blog/2014-11-09/differential-flame-graphs.html ?

Moving this to - https://github.com/async-profiler/async-profiler/discussions/911


Popover should allow isModal={false} for ComboBox

Closes
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Didn't this not quite solve the issue because of the extra elements between the input and the menu? Ideally we would want it to be modal, but not to hide the input right?

@devongovett You're correct that this isn't exactly the behavior we want. This was just a quick hack I shared to see if omitting useModal() would help with screen reader announcement within ComboBox input.


Sendgrid API v3

Updated to use the new sendgrid API
Still needs some work with respect to the sendgrid specific headers that are used in the package.
Also some testing would be nice and the docs need some updates ;-)

any updates?

I think we can close this PR because of https://github.com/elbuo8/sendgrid-django/pull/26


refactor(typescript): migrate mtdFraudPrevention to TypeScript

Migrate mtdFraudPrevention from JavaScript to TypeScript
Description of what's changing
Migrate mtdFraudPrevention from JavaScript to TypeScript. Luckily, this was a very straightforward migration. The only wrinkle was a mistake I made in the browserInfoHelper migration where I included the rejection type in the return type of the promise. TypeScript does not expect this. The rejection type of a promise is always any (unfortunately).
What else might be impacted?
There shouldn't be any other impacts of this change.
Which issue does this PR relate to?
This relates to issue #12. However, it does not complete it.
Checklist
[ ] Tests are written and maintain or improve code coverage
[ ] I've tested this in my application using yarn link (if applicable)
[ ] You consent to and are confident this change can be released with no regression

Looks good! Thanks @pmaidens.

@pmaidens Looks like the build failed due to coverage check failure. But, I don't think the issue could be specific to this PR and something related to coveralls config. Looking into this now.

:tada: This PR is included in version 1.11.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Reverting the PR fixed the coverage and thus the build issue. Need to fix the coverage issue associated with these changes.


Feature Request: Please add ESP8266 support

Please add ESP8266 - WiFi Module support to take the home automation system to the next step.

You can use the ESP8266 today by running the Sming MQTT client on your ESP8266 and connecting to the MQTT components in HA.

👍👍👍 talking mqtt is the best and most reliable way to do this. Super simple.
I'm coming around to becoming a big fan of mqtt.

On Oct 10, 2015, at 1:47 PM, Paulus Schoutsen<EMAIL_ADDRESS>wrote:
You can use the ESP8266 today by running the Sming MQTT client on your ESP8266 and connecting to the MQTT components in HA.
—
Reply to this email directly or view it on GitHub.

Or simply use aREST.


Finalize credits

Olivia???
Add more people/institutions/things to "thanks guys"
Adjust layout if desired (ez with these prefabs)
Reorganize sections if desired

I would also suggest adding some cool/funny pictures from the development/finished models and stuff along the way! 🤠


cannot search by chinese；

thank you for your awesome work~~
here is my digital garden using the project。
https://blog.oldwinter.top/notes
there are some bug，could you please have a look？
1，search can not support IME，when input method engine run ，search function cant work。
2，search can not support Chinese。
first bug like this：when I enter return，obsidian word go into search bar，but there is no result。

second bug like this：Chinese cant search any thing。

appreciate your time ，thanks~~~😃

I need to check the library we are using for search.


The camera stream is not released in some conditions

What

The camera stream is not released in some conditions
Note it's not possible to record the indicator
It's properly released after going back to the scan screen
It starts at the beginning of the video, no clear idea of the trigger yet

Screenshot and video
https://photos.app.goo.gl/xsdCLKdYKvA6ALPWA

That one is annoying me, as I'm unable to reproduce it 🤨
In debug mode, is the issue reproducible?


Significant improvements to pom, plus minor code improvements.

In the pom: upgrade all libs/plugins to their latest versions. Add missing libraries (used/undeclared) and remove unused ones (declared/unused). Add a bunch of default maven plugins so we can upgrade them. Add some basic reporting capabilities when using mvn site. Add some additional pom attributes like name, project description, license, etc.
In the code, organize some imports. Update the jbom version written to the generated SBOM so it outputs the actual version of jbom, not the static value 1.0.0. And point the project repo to the Eclipse foundation web site.

Thank you Dave.  Some nice changes in here.  The jdom stuff is broken though.  Throws NPE every time.   Also you don't need anything in the pom to get resources directory contents into jar file -- happens automatically.  I made some updates and checked in.   Let me know when you get a chance to test and I'll do a release.

@planetlevel - The merge plus the changes you made after look good to me.