Typechecker reports a cyclical binding

I have run into a strange error message by the type checker on this specification:
module t {
    pure def ok(value: a): { v: a, err: str } = {
        { v: value, err: "" }
    }

    pure def onOk(r: { v: a, err: str },
                  callback: (a) => { v: a, err: str }): { v: a, err: str } = {
        if (r.err == "") {
            callback(r.v)
        } else {
            r
        }
    }

    pure def foo(s: int, bar: (int, int) => { v: int, err: str }): { v: int, err: str} = {
        ok(s)
            .onOk((v2) => bar(v2, 3))
            .onOk((v3) => bar(v3, 4))
    }
}

This is what the typechecker is showing:
$ quint typecheck t.qnt
t.qnt:16:9 - error: [QNT000] Can't bind _v18 to _v18, _v21: cyclical binding
Trying to unify entities [_v18, _v21] and [_v18]
Trying to unify Read[_v18, _v21] and Read[_v18]
Trying to unify (Read[_v18, _v21]) => Read[_v23] and (Read[_v18]) => Read[_v21]
Trying to unify (Read[_v22], (Read[_v22]) => Read[_v23]) => Read[_v22, _v23] and (Read[_v18, _v21], (Read[_v18]) => Read[_v21]) => _e10
Trying to infer effect for operator application in onOk(onOk(ok(s), ((v2) => bar(v2, 3))), ((v3) => bar(v3, 4)))

16:         ok(s)
            ^^^^^
17:             .onOk((v2) => bar(v2, 3))
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
18:             .onOk((v3) => bar(v3, 4))
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: typechecking failed

I guess, I am just pushing the boundaries of Quint way too much. The error message is quite confusing.

Interesting case! Good find :D
Definitely a confusing error message.
The cycle in this case is showing up in the effect checking.
Minimization
module t {
    pure def foo(s: int, g: int => int): int = {
      val r = if (true) s else g(s)
      g(r)
    }
}

Giving:
$  quint typecheck ../t.qnt
/home/sf/Sync/informal-systems/apalache/quint/t.qnt:4:7 - error: [QNT000] Can't bind _v1 to _v1, _v3: cyclical binding
Trying to unify entities [_v1] and [_v1, _v3]
Trying to unify Read[_v1] & Update[_v2] and Read[_v1, _v3] & Update[_v2]
Trying to unify (Read[_v1] & Update[_v2]) => Read[_v3] & Update[_v2] and (Read[_v1, _v3] & Update[_v2]) => _e2
Trying to infer effect for operator application in g(r)

4:       g(r)
         ^^^^

error: typechecking failed

Removing the conditional in favor of either branch avoids the problem.
Replacing the call to g with an equivalent lambda avoids the problem.
Defining g instead of taking it has a parameter avoids the problem.

Debugging

{
  "stage": "typechecking",
  "warnings": [],
  "modules": [
    {
      "id": 20,
      "name": "t",
      "declarations": [
        {
          "id": 19,
          "kind": "def",
          "name": "foo",
          "qualifier": "puredef",
          "expr": {
            "id": 18,
            "kind": "lambda",
            "params": [
              { "id": 1, "name": "s" },
              { "id": 3, "name": "g" }
            ],
            "qualifier": "puredef",
            "expr": {
              "id": 16,
              "kind": "let",
              "opdef": {
                "id": 13,
                "kind": "def",
                "name": "r",
                "qualifier": "val",
                "expr": {
                  "id": 12,
                  "kind": "app",
                  "opcode": "ite",
                  "args": [
                    { "id": 8, "kind": "bool", "value": true },
                    { "id": 9, "kind": "name", "name": "s" },
                    { "id": 11, "kind": "app", "opcode": "g", "args": [{ "id": 10, "kind": "name", "name": "s" }] }
                  ]
                }
              },
              "expr": { "id": 15, "kind": "app", "opcode": "g", "args": [{ "id": 14, "kind": "name", "name": "r" }] }
            }
          },
          "typeAnnotation": {
            "id": 17,
            "kind": "oper",
            "args": [
              { "id": 2, "kind": "int" },
              { "id": 6, "kind": "oper", "args": [{ "id": 4, "kind": "int" }], "res": { "id": 5, "kind": "int" } }
            ],
            "res": { "id": 7, "kind": "int" }
          }
        }
      ]
    }
  ],
  "table": {
    "9": { "id": 1, "name": "s", "kind": "param" },
    "10": { "id": 1, "name": "s", "kind": "param" },
    "11": { "id": 3, "name": "g", "kind": "param" },
    "14": {
      "id": 13,
      "kind": "def",
      "name": "r",
      "qualifier": "val",
      "expr": {
        "id": 12,
        "kind": "app",
        "opcode": "ite",
        "args": [
          { "id": 8, "kind": "bool", "value": true },
          { "id": 9, "kind": "name", "name": "s" },
          { "id": 11, "kind": "app", "opcode": "g", "args": [{ "id": 10, "kind": "name", "name": "s" }] }
        ]
      },
      "depth": 1
    },
    "15": { "id": 3, "name": "g", "kind": "param" }
  },
  "errors": [
    {
      "explanation": "[QNT000] Can't bind _v1 to _v1, _v3: cyclical binding\nTrying to unify entities [_v1] and [_v1, _v3]\nTrying to unify Read[_v1] & Update[_v2] and Read[_v1, _v3] & Update[_v2]\nTrying to unify (Read[_v1] & Update[_v2]) => Read[_v3] & Update[_v2] and (Read[_v1, _v3] & Update[_v2]) => _e2\nTrying to infer effect for operator application in g(r)\n",
      "locs": [
        {
          "source": "/home/sf/Sync/informal-systems/apalache/quint/t.qnt",
          "start": { "line": 3, "col": 6, "index": 102 },
          "end": { "line": 3, "col": 9, "index": 105 }
        }
      ]
    }
  ]
}

IR

Annotating the values with their inferred effects:
module t {
    pure def foo(s :: e_s_1 = Pure, g :: e_g_3 = Pure): int = {
      val r :: Read[_v1, _v3] & Update[_v2] = ({
        if (true :: Pure)
            (s :: Read[_v1] & Update[_v2])
        else
            (g(s) :: Read[_v3] & Update[_v2]
                  ~> g :: (Read[_v1] & Update[_v2] => Read[_v3] & Update[_v2]) // Inferred from effect of `s` above.

                  )
      } :: Read[_v1, _v3] & Update[_v2])
      g(r) :: e2
           ~> g :: (Read[_v1, _v3] & Update[_v2] => e2)
    }
}

Where :: is used to indicate an effect annotation and ~> indicates an
inference derived from the preceding inference.
What this shows how we are arriving at an unsolvable unification at g(r)

at g(s) we infer g to have the effect Read[_v1] & Update[_v2] => Read[_v3] & Update[_v2], due to the placeholder effect variables inferred for s
and the placeholder effect variables inferred for g(s).

The effect inferred for r is determined by the application of the effect
signature specified for ite (the "if then else" operator) to the effects
inferred for its operands.
ite :: (Read[r1], Read[r2] & Update[u], Read[r3] & Update[u]) => Read[r1, r2, r3] & Update[u]`
// so
ite(true, s, g(s)) :: (Read[_v1, _v3] & Update[_v2])

Because true, being known from the outset as Pure, takes r1 out of the
equation.

at g(r), because of the type inferred for r, we infer g to have type
(Read[_v1, _v3] & Update[_v2] => e2).

Finally, when we try to reconcile the two different effects inferred for g,
we try to unify the read effect variable _v1 with the set of read effect
variables _v1 ∪ _v3, and fail on the occurs check.

I think we get some insight into what's going wrong by comparing with this case,
in which the inference goes through correctly:
module t {
    def g(x :: e_x_1 = Pure):: e_x_1 => e_x_1  = (x :: e_x_1 = Pure)

    pure def foo(s::Read[_v1] & Update[_v2]): int = {
      val r :: Read[_v1] & Update[_v2] = ({
        if (true)
          (s::Read[_v1] & Update[_v2])
        else
          (g(s::_e0)::Read[_v1] & Update[_v2])
      } :: Read[_v1] & Update[_v2])
      g(r) :: Read[_v1] & Update[_v2]
    }
}


Build Graph Function Outputs and Slow Processing

Hi, we are trying to implement the graph-transformer code on our own data, and are having some issues with the time ti takes to run the build_graphs function and determining the validity of the outputs. We are running the function on our center for computational research nodes, but over the span of 24 hrs it only managed to get to the 9th patch. Additionally, we are assuming that the build_graphs function saves a c_idx.txt, adj_s.txt, and a features.pt for each and every patch. Is this true? Because if so, how do you get the function to finish when you have over 55000 image patches, and how do you handle the large amount of output data?

build_graphs function saves a c_idx.txt, adj_s.txt, and a features.pt for each WSI, not each patch.
Training a feature extractor using self-supervised learning takes a long time because augmentation is time-consuming. You could potentially use cosine similarity to find the positive pairs instead of augmentation. This will speed up training and increase sample diversity.
We provide a pre-trained model.

Calculating the adjacency matrices in two nested loops is extremely slow...


"StackNavigator" documentation for "RouteConfigs" seems to be out of sync

I was working on StackNavigator's RouteConfig, and attempted to hide header for a specific screen. According to the documentation, the following code should handle it.
StackNavigator(
  {
    S1: {
      screen: S1,
      navigationOptions: {
        headerVisible: false
      }
    },
    S2: {screen: S2},
    ...
  },
  {
    headerMode: "screen"
  }
)

But, it didn't work. I found another solution here,
StackNavigator(
  {
    S1: {
      screen: S1,
      navigationOptions: {
        header: {visible: false}
      }
    },
    S2: {screen: S2},
    ...
  },
  {
    headerMode: "screen"
  }
)

which is working as expected. (but not mentioned in the documentation)
Is the documentation out of sync?
Note: I'm using master branch.

yea they added that stuff in the documentation like 8 hours ago, and the latest release is still without that. the old way is header: { visible: false } } and the new (probably in the next release) is headerVisible: false

This has been updated 😄


Follow ups from docs review

Change Obtain a connection string section to Authenticating the client.
Key Concept change roman numerals to bullets or numbers
Consider reducing number of examples, or provide as links.  3-5 is a good number.
Authenticating with Azure.Identity - add a link to this portion of the doc to the Authenticating the client
Add enable logging to the Troubleshooting section (link to How to Enable Console Logging)

Fixed in https://github.com/Azure/azure-sdk-for-net/pull/10909


Test / Add overflow visible to all textareas

added overflow visible in main index scss to textarea components

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.471%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
5798

Relevant Lines:
6306

💛  - Coveralls


You are getting a kiss and a pint

My gf is British and we might be coming to London this year.    Truly.fucking.awesome.thankyou.

No problem, glad it is useful to someone else!
To be honest I'm assuming this is a stopgap that could be replace with MobX-state-tree when that has got more definite. This library is way less ambitious and more simplistic, so it has hardly any code (it's little more than a pattern) but ticks the boxes for what I need most urgently.
I should definitely write SOME tests though. Also a demo of a simple vector graphics editor.

It works like a charm.  I plan to use it to replace state-tree as well.  Which is a huge relief!  Keep the examples coming!

On Feb 9, 2017, at 3:47 AM, Daniel Earwicker<EMAIL_ADDRESS>wrote:
No problem, glad it is useful to someone else!
To be honest I'm assuming this is a stopgap that could be replace with MobX-state-tree when that has got more definite. This library is way less ambitious and more simplistic, so it has hardly any code (it's little more than a pattern) but ticks the boxes for what I need most urgently.
I should definitely write SOME tests though. Also a demo of a simple vector graphics editor.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/danielearwicker/json-mobx/issues/2#issuecomment-278607837, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAQ93liut-f1zky0S8va1c1fZRdh0k_ks5rau6ngaJpZM4L7fOy.

Hey should this thing be capable of serializing pretty deep graphs.  Are you using it to do so?

Can you provide an example of a custom getter and setter, I can't figure it out.

It shouldn't have a problem with depth, it's just simple recursion. It is designed for tree structures though, not random graphs.
Polymorph from the source is a simple example of a class that defines its own persistence format:
    @computed get json() {
        return {
            type: this.type,
            settings: json.save(this.ref)
        };
    }
    set json(data: any) {
        if (data && data.type) {
            this.set(data.type);
            json.load(this.ref, data.settings);
        }
    }

Thanks!

On Feb 9, 2017, at 2:22 PM, Daniel Earwicker<EMAIL_ADDRESS>wrote:
It shouldn't have a problem with depth, it's just simple recursion. It is designed for tree structures though, not random graphs.
Polymorph from the source is a simple example of a class that defines its own persistence format:
@computed get json() {
    return {
        type: this.type,
        settings: json.save(this.ref)
    };
}
set json(data: any) {
    if (data && data.type) {
        this.set(data.type);
        json.load(this.ref, data.settings);
    }
}

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/danielearwicker/json-mobx/issues/2#issuecomment-278777536, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAQ99jhOGfkr0WLSrcfSIB7N8B1q61Xks5ra4N7gaJpZM4L7fOy.


updated image filter module from nginx-1.15.2

All tests successful.  ACK
$TEST_NGINX_BINARY=/home/fakang.wfk/github/work/tengine/objs/nginx  prove -v -I tests/nginx-tests/nginx-tests/lib/  ./tests/nginx-tests/nginx-tests/image_filter.t
./tests/nginx-tests/nginx-tests/image_filter.t ..
1..41
ok 1 - test
ok 2 - test content-type
ok 3 - test fail
ok 4 - off
ok 5 - size wrong type
ok 6 - size content-type
ok 7 - size width
ok 8 - size height
ok 9 - size jpeg
ok 10 - size gif
ok 11 - size png
ok 12 - resize
ok 13 - resize 1
ok 14 - resize 2
ok 15 - resize var
ok 16 - resize var 1
ok 17 - resize var 2
ok 18 - rotate
ok 19 - rotate var 1
ok 20 - rotate var 2
ok 21 - gif interlaced off
ok 22 - gif transparent white
ok 23 # skip broken libgd
ok 24 - gif transparent loss
ok 25 - png interlaced off
ok 26 - png transparent white
ok 27 # skip can wedge nginx with SIGPIPE
ok 28 - png transparent loss
ok 29 - quality default
ok 30 - quality
ok 31 - quality var
ok 32 - quality nested
ok 33 - crop
ok 34 - crop var
ok 35 - rotate before crop
ok 36 - rotate after resize
ok 37 - resize rotate nested
ok 38 - small buffer
ok 39 - small buffer proxy
ok 40 - no alerts
ok 41 - no sanitizer errors
ok
All tests successful.
Files=1, Tests=41,  0 wallclock secs ( 0.04 usr  0.00 sys +  0.21 cusr  0.07 csys =  0.32 CPU)
Result: PASS


Persist volume names

We want to be able to recover the name of a volume which is associated with a filesystem. To do this without the current fragile code, we need persistent volume names. This might also help a future use-case of renaming volumes.

We are moving our development planning to JIRA. This issue is now being tracked at https://clusterhq.atlassian.net/browse/FLOC-78. You are welcome to file additional issues in GitHub if that's easier for you.


fixing the spelling mistakes

Fixes Issue : Corrected the spelling mistakes

please review and add hacktoberfest label

Hi @AbhineshJha. Welcome to LinksHub! :) We don't accept spam pull requests, so I'm putting yours in draft mode for now. Refer to our Contributing Guide to learn how to effectively contribute to the project. In the future, please raise an issue and wait until it has been approved and assigned to you before you submit a pull request. Happy Contributing! 😊


Please open a security advisory

This project has a security vulnerability. Please open an advisory and add me.
https://github.com/mrvautin/expressCart/security/advisories

Fixed 3c9a86306a1ea5d633ecf84690d1951a2b63ab17.

@mrvautin Can you re-open the advisory so we can finish it out and get this issue disclosed.


Dropdown doesn't close on blur

Hi,
I've setup a multi-select that uses Ajax to retrieve data from the server. If you click on the text input, you get the dropdown menu with the text "Please enter 1 more character". This box doesn't seem to close if you click away on the page and trigger the blur event.
Fiddle: http://jsfiddle.net/dGF4W/
(obviously the ajax call will fail in the example)
Strangely enough, this doesn't seem to be an issue on the demo page, but I can't seem to find what I'm doing wrong...

I will second @stephenoldham. I had the same issue, applied CSS rules to account for custom z-index, and suddenly select2 was disappearing on blur again. Worked like a charm with the following code.
.select2-container {
  z-index: 6000;
}
.select2-drop-mask {
  z-index:5990;
}
.select2-drop-active {
  z-index:5995;
}

@NoelBaron thank you so much! that really works! awesome!

I am having the same issue: http://jsfiddle.net/brunodd/jEADR/2009/

I am having the same issue

Most likely you're trying to click below the container, and you're seeing an issue where technically that is outside of the document. Because of this, your click event isn't actually firing and you aren't seeing the dropdown close.
Most people have things below their container in production, so usually this isn't an issue.

@kevin-brown But why the dropdown doesn't close once you select an option?

But why the dropdown doesn't close once you select an option?

You're missing the CloseOnSelect decorator.
https://jsfiddle.net/axy8sq69/

Besides it would be great to make the dropdown/up fixed as an option we should be able to pass.

This has been feature requested and denied a few times in the past, search around in tickets for "direction".


I search an image which is uploaded before, but it is not top1

which step is wrong?

already fix it


The first image is not displayed in the "Share to Open Food Facts" modal

The first image is not displayed in the "Share to Open Food Facts" modal. It didn't have a barcode.

Maybe if no barcode is detected within it.

Added in #1873


Country filter in Django Admin - enhacement

Limit listed countries for those are active

Duplicate of https://github.com/CodeForPoznan/pah-fm/issues/448


License?

Could you please create the license file? Preferrably MIT or BSD

Sorry, I have added the MIT license, please check it.

Great, thanks


[admin] Publish

Docs Build status updates of commit df5a391:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/overview/excel.md
:white_check_mark:Succeeded
View

docs/testing/platform-limits.md
:white_check_mark:Succeeded
View

licensing-information.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Partial in Generic Class is not working properly

Bug Report

🔎 Search Terms

Partial Generic Class
🕗 Version & Regression Information

This is the behavior in every version I tried (latest version v4.8.4)

⏯ Playground Link

Playground link with relevant code
💻 Code

type OptionalDataExtra <T extends {}, E extends {} = {}> = Partial<T & E>;

interface TestData {
	foo: string;
	bar: number;
}

function testFunction<E extends {}>(data: OptionalDataExtra<TestData, E>): void {
	console.log(data)
}

// works
testFunction({
	foo: "test"
})

class Test<E extends {}> {
	constructor() {
		// doesn't work
		this.testFunctionInsideClass({
			foo: "test"
		})
	}

	testFunctionInsideClass(data: OptionalDataExtra<TestData, E>): void {
		console.log(data)
	}
}

const testObj = new Test();

// works
testObj.testFunctionInsideClass({
	bar: 1,
})

🙁 Actual behavior

This case Partial of Generic Object combined with Known Object properties is not working properly even though the Generic Object properties is not actually used
It's only happen while used inside generic class
🙂 Expected behavior

Since Partial is make object properties optional, it should works fine even though the generic object properties not visible yet but, in the end of the day the additional generic properties is optional

See Why can't I return a generic T to satisfy a Partial<T>?.  The caller of the construct signature can specify E to be a type with a foo property narrower than string, so the compiler is technically correct to complain that {foo: "test"} might not be assignable to 'Partial<TestData & E>':
const n = new Test<{ foo: "bar" }>();
n.testFunctionInsideClass({ foo: "test" });
//Type '"test"' is not assignable to type '"bar"'.(2322)

Playground link

@jcalz I see that make sense now
But, I think by reordering object combination logically should be solving the problem isn't it?
// old
Partial<T & E>

// new
Partial<E & T>

The T properties will override the E properties when conflict happen

No, intersections of non-functions are not order-dependent.

Yeah, that’s not how intersections work.  T & E means a value which is assignable to both types, neither type “overwrites” the other, they just merge.  e.g. { x: string } & { x: number } becomes { x: never }

i see thank for the explanation


Updating state in Redux, merge or update?

I just started working in Immutable, and I've hit some cornerstones. I'm insecure about several things, and I hope that you'll help out with me figuring out how it works :) ( I've also asked on SO, but people doesn't answer seriously )

To update state in Redux with Immutable, do I call state.merge(something) or state.update(...)
When structuring my changed values, what is the best way to do that? I most certainly know that I have done something and most likely everything wrong, so I hope that you will correct me on this.
How do I call update /  updateIn on flat objects?

Thanks for helping me out! Here's the sc.

I always use update/set, to modify exclusively the portion of the state that needs to be modified. In your  example, you don't show how your previous state looks like, so I'm not sure what is the best here :/

Previous state is empty, it gets populated by a payload in the first reducer, if I have got the concept right :) @AugustinLF

If the state is empty, then it doesn't matter, you can even directly return updatedState. But this think work only if the content of the state doesn't have any influence on the updatedState

Updated state is the new state @AugustinLF , you can´t set it directly

No but you can just return it. a reducer is a (state, action) => newState function. Map().merge(fromJS({a: true})) is shallow equal to fromJS({a: true}). So in your case, you can simply do (since state is an empty Map):
case POPULATE:
  let updatedState = fromJS({data: action.payload.meetingNote});
  return updatedState;

To update state in Redux with Immutable, do I call state.merge(something) or state.update(...)

Both of these will return a new version of your state with a change applied. They just do different kinds of changes. Merge looks fine as you're using it now. There's a good parallel here to Arrays. push(), shift(), and map() are all about changing things, but they do different things. One isn't superior to the other.

When structuring my changed values, what is the best way to do that? I most certainly know that I have done something and most likely everything wrong, so I hope that you will correct me on this.

I think you're over thinking this. There's basically no wrong way to structure your data. It's your data. Structure it however you like that works for your app.

How do I call update / updateIn on flat objects?

Could you clarify what a flat object is?

One thing I noticed is that your function says it will accept Map as state and action, but you're using property accessors like state.data or action.type. Immutable Maps are not like JS Objects, they're like ES6 Maps. They don't have properties but instead have a get() method.

@AugustinLF  @leebyron  thanks! Flat object would be like this:
updatedState: {
        data: someval,
        more: false,
        less: ...
}

Okay, so here's how it looks now. Is there any optimizations needed to be picky now? Also, I really want to have each action return the state & not updatedState. Do I use state.set(updatedState) on all my reducers or do I use updateIn or similar? I'm adding a optional question at the end here, asking the following: I'm unsure about updating multiple values through update, how do I do that?

I'm not sure this code does what you think it does. Does it work?
I think you may be misunderstanding some fundamental concepts here. I definitely recommend backing up and getting a better grasp on what it is you're trying to accomplish without additional tools like redux and immutable or babel/es6 and only including these when they help you accomplish something in a better way.
To start, I suggest reading more about redux and reducers. Typically the goal or a reducer function is to accept an older version of something and one other value and then return a newer version of that same thing by using the value. When called multiple times with each new value becoming the "older version" with each subsequent call to the function, you can model change over time via the sequence of events. Immutability is a fundamental aspect to how a reducer function should work (not specific to JavaScript, the concept exists in most languages) but you don't need a special library to use immutability. Simply don't edit the "older version" and instead always create a new copy with your change applied. Redux is really just about popularizing this existing concept of reducers to UI programming. The "thing" being updated over time we call "state" and the value used to update it is the "action". You can see that in your latest version of your code, you're not using the previous state at all to produce the new returned state, that's definitely a big red-flag that your reducer isn't doing what you want it to do.
Next, the ES6 features enabled with Babel being used here represent the "default values" for arguments, or what value to use if one is not passed to your function. In a reducer the second argument "action" is always provided, so the default value there isn't doing anything valuable. It's probably just distracting from how the reducer works. The first argument "state" is only not provided for the very first time the reducer is called in the case that you're not providing an initial state. If your redux setup has an initial state then you don't need that either. If it doesn't, then here's where that initial state can be defined. An empty Map is very likely not what you are expecting to be your initial state. So it's either distracting from what's really going on, or your probably have a bug there, depending on if you're providing your initial state to redux or not.
then there's immutable.js. I would strongly suggest familiarizing yourself with the concepts of immutability without using this library first just by using plain old JavaScript objects at first. Actually in your case it looks like your state is quite simple so you're probably not gaining much by using immutable.js anyhow. Since plain JS objects are much simpler, hopefully this can help you better visualize what's going on. You can return new versions of your state using Object.assign like this:
var newState = Object.assign({}, prevState, { keyToChange: newValueToUse })
I'm sure you can find ample examples of this sort of thing in the redux documentation and explainers.
Once you get a better grasp of using redux to build apps and things are working, come back to immutable.js as you need to model more complex state or state that has larger amounts of data in it. Immutable.js uses different kinds of data structures that help conserve memory and improve performance for those kinds of situations.
I'm going to close this issue since both the question in the title was answered in an earlier comment (both merge and update are useful for updating redux states, as are the many other methods immutable.js provides) and the discussion has mostly been focused on this one piece of code, which may be better handled by either working with some tutorials or asking on stack overflow.


r

Command

What occurred

What you expected to occur
CLI Version

CC API Endpoint Version

CF Trace

Platform & Shell Details

Any other relevant information

hey there @dutch3000, is this a real issue or is this an accidental bug file?

@dutch3000 Closing this as it looks like a mistaken entry.


update dependencies

Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
This PR focuses on updating several package versions across multiple package.json files, specifically upgrading @tanstack/react-query from 5.62.2 to 5.62.3 and updating @types/react and @types/react-dom from 19.0.0 to 19.0.1 in various locations.
Detailed summary

Updated @tanstack/react-query from 5.62.2 to 5.62.3 in:

apps/playground-web/package.json
apps/wallet-ui/package.json
apps/dashboard/package.json
apps/portal/package.json
packages/thirdweb/package.json

Updated @types/react and @types/react-dom from 19.0.0 to 19.0.1 in:

apps/playground-web/package.json
apps/wallet-ui/package.json
apps/dashboard/package.json
apps/portal/package.json

Updated msw from 2.6.6 to 2.6.7.
Updated react-native from 0.76.3 to 0.76.4.
Updated react-native-svg from 15.9.0 to 15.10.1.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#5649  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Fix: Axis formatNumberAsK does not work for negative numbers

Add Math.abs(number) to the function

https://github.com/brumik/react-json-chart-builder/commit/41d4f883c03297e2f0c0e99f2cc9d5e5e122d425


Fixed issue where akka-js-actor-tests would not complete or Node.js reported an error

Fixed issue where the akka-js-actor-tests would not complete or Node.js reported a communication error. In test suite AddressTerminatedTopicBenchSpec the  test "Subscribe and unsubscribe of AddressTerminated be quick"  is expected to start 20,000 in 10 seconds. This may not be an attainable level of performance in The NodeJS runtime.  In addition due to an issue with the use of the Props=> T constructor resulting in the exception "TypeError: Cannot read property 'prototype' of undefined" for each actor, the performance was worsened.
The fix was to set the number of actors to 1000, alternatively we could also change the timeout, however I am unsure of the impact of creating 20,000 actors in Node.JS
In addition, we changed the constructor employed to Props(classof[T},... for AddressTerminatedTopicBenchSpec and UidClashTest. There are 37 exception of this type in  this test module. Applying this change generally would remedy many of the failing tests in the module.

Thanks!


Browser support?

Whats the browser support please?

https://github.com/limonte/sweetalert2#browser-compatibility


Grammatical and spelling correction in electron_app/guide.js

Description
Grammatical and spelling errors appear on the introduction screen of the electron app.
Screenshot for reviewing

I want to work in this issue

Hi @parthsingh29 I am working on this issue


Pull request comment is not shown until page is reloaded

Hello,
I am trying to add a comment to a pull-request using the following code:
    _, _, err = client.Issues.CreateComment(
        context.Background(),
        "myorg",
        "myrepo,
        pr_number,
        &github.IssueComment{Body: &body},
    )

The comment is added to the pull-request, but I can only see it if I reload/refresh the page.
Is there something I can do to avoid the page refresh?
Thanks

This repo is a client library for the GitHub v3 REST API and has nothing to do with the GitHub web-based user interface.
So no, there is nothing this repo can provide that will help you prevent a browser page refresh.


Rewrite telegram bot using telebot library

What's your idea about rewriting telegram bot using telebot library?
If it's ok then  I can do this...

Sure, any improvement is welcomed.
But note that at first we created the telegram bot, so in future we use it as a voting platform to label tweets. But after a few tests we found out that it is not a efficient way of labeling tweets. Because there are a lot of tweets (about 1000 in a second) that match atleast one keyword.
We are planning to create a browser extension so users label only useful tweets.
With that being said, if you think that you can give us your valuable time and improve any aspect of the bot, we will be thankful.

We can develop our bot for acting in two mode :

Send text of Tweets with name of account in telegram channel
Labeling the texts only in private and after subscribing. ( 3 tweet per day )

I start writing

We can develop our bot for acting in two mode :
Send text of Tweets with name of account in telegram channel
Labeling the texts only in private and after subscribing. ( 3 tweet per day )
I start writing mode number 1 and I can start developing mode 2 after your approve on this method


Avoid collisions of dots in adjacent glyphs

Normal dot collision avoidance does not work between two glyphs. However, connected scripts, such as Arabic, will end up with dots on top of one another by default if the skeletal strokes are designed to connect. It would be better to find a way to avoid overlapped dots. Even for scripts that do not have formal OpenType cursive connections it might be useful to somehow control this.
We could add metadata to a node (similar to forced dots) that would drop any dot at that location if a custom parameter is set. This would work for glyphs that are known to be non-final.
There may be better solutions.

More generally I think it might be useful to force there being no dot at a particular node, kind of the inverse of a forced dot. This may also help with joins.

Sounds good to me


isIn operator does not seem to work when I run my code via tsx

I ran into the issue below:

The isIn operator did not error, but simply returned 0 results.

This is fixed in 0.4.0


Failed to sync iCloud sync

I guess the app somehow now syncing some of a folders or feeds between iPhone and iPad.
It's like Twitter is in sync, the major part of a library in terms of feeds are the same, but it failed Ty sync some recently added feeds and failed to sync read/unread articles.

Guess it’s #3839 related.

Duplicate of #3839


New Landscape Entry - Emproof

Project Name
Emproof
Description
Agile, robust and cost-effective security and IP integrity for embedded software.
Homepage URL
https://www.emproof.com
Crunchbase URL (https://www.crunchbase.com/)
https://www.crunchbase.com/organization/emproof
Repository URL (Only if publicly available)
No response
Organization hosting or owning the project
Emproof
Evidence of RISC-V ecosystem support
RISC-V International Member: Link
Use Case
Logo

Category
Services
Sub-Category
None

@bprestonlf +1

@bprestonlf +1


Lockless socket output, lower allocs

Inter dependent items from PR #309 as individual commits

Closing for now until have some numbers; need to improve latency...


⚠ Bofrost.es has degraded performance

In 99a3dc7, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1577 ms

Resolved: Bofrost.es performance has improved in 3e83741 after 9 minutes.


Expose data-mui-test when process.env.NODE_ENV === 'test'

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

Only strip data-mui-test if process.env.NODE_ENV !== 'test', perhaps something like
<Foo data-mui-test="foo" />

//     ↓ ↓ ↓ ↓ ↓ ↓

process.env.NODE_ENV === 'test' ? <Foo data-mui-test="foo" /> : <Foo />

Examples 🌈

Motivation 🔦

I understand that we don't want to have data-mui-test in our bundles. However, in some cases, it's the only "public" way of accessing an element to fire events on, e.g. using fireEvent from RTL to simulate a backdrop click
https://github.com/mui-org/material-ui/blob/14f5de62cacb53dc2e8243b46b1bd4bbcb173b80/packages/material-ui/src/Dialog/Dialog.js#L232-L240
Alternatively, I guess we could add FakeBackdropProps (see https://github.com/mui-org/material-ui/issues/10401#issuecomment-367587475) in the particular case of Dialog, but it feels to me that a user should be able to query MUI components the way MUI does in its tests: https://github.com/mui-org/material-ui/blob/14f5de62cacb53dc2e8243b46b1bd4bbcb173b80/packages/material-ui/src/Dialog/Dialog.test.js#L22-L24

v5 will have fully public class names so I don't think that it's needed.


Don't add Mock suffix when a destination package contains mock

Hi, thank you for the lib, it's really awesome.
I've a case like that:
//go:generate moq -pkg mock -out ../mock/answer_store_mock.go . AnswerStore:AnswerStore
type AnswerStore interface {
	// etc
}

as you can see I'm typing AnswerStore 2 times to get rid of Mock suffix (it will be AnswerStoreMock as you can guess). But this doesn't make sense 'cause destination package will be mock, for me mock.AnswerStoreMock contains too much mock in the name :)
Is it possible to add a flag with defines exact final name (-name?) or there will be a feature to not append Mock at the end when pkg is mock (or contains mock). Latest probably will break backward compatibility :(
Thanks.

While I agree that having to repeat the name ideally should not have been necessary, it does not seem feasible to solve this without breaking backwards compatibility. And in this case, the cost of breaking existing usages does not seem worth the cosmetic benefit.

🤷


Fix for getting the final consumer expression in the error message

This PR applies a fix for retrieving the correct final consumer expression from the point of conflict.
[Depends on PR #34]

This PR is now obsolete with the revised error message format. Hence, closing it without merging.


A little vague statement

[Enter feedback here]
Hello All,
I hope you are all doing well, just wanted to give feedback regarding below statement:

The administrators of organization 'Contoso' have no direct administrative privileges to organization 'Test,' unless an administrator of 'Test' specifically grants them these privileges. However, administrators of 'Contoso' can control access to organization 'Test' if they sign in to the user account that created 'Test.'

I am specifically talking about "However, administrators of 'Contoso' can control access to organization 'Test' if they sign in to the user account that created 'Test." This statement is confusing.
The way I understand it is as follow, I have person-A with Global Administrator Account-A, and person-B with Global Administrator account-B, person-A using account-A created the 'Test' tenant/organisation, only person-A is now the Global Administrator of tenant 'Test', for person-B to gain control of tenant 'Test' he/she need to use account-A that originally created the tenant 'Test'.
If above understanding is correct, why would person-A give person-B his account-A, this is a strange solution from a security point of view, the better solution is for person-A to give person-B Global Administrator role over the newly created tenant 'Test'.
Thank you and all the best, Stay strong!
Cheers,
Ahmed Muhi

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4a916018-5100-91af-bc16-6aab0372bd48
Version Independent ID: 2f526d40-8282-090c-430e-b2bf1d3ba7df
Content: Characteristics of multi-tenant interaction - Azure AD
Content Source: articles/active-directory/enterprise-users/licensing-directory-independence.md
Service: active-directory
Sub-service: enterprise-users
GitHub Login: @curtand
Microsoft Alias: curtand

@ahmedmuhi
Thanks for your feedback! We will investigate and update as appropriate.

#please-close

Thank you, team, for taking the time to make these revisions! 📄👍 The clarity is fantastic now – truly appreciate it. Loving the changes 🥰.


Correction for raw affiliation AGIR Research Unit, EA 4294, Jules Verne University of Picardie, Amiens, France

Correction needed for raw affiliation AGIR Research Unit, EA 4294, Jules Verne University of Picardie, Amiens, France
raw_affiliation_name: AGIR Research Unit, EA 4294, Jules Verne University of Picardie, Amiens, France
new_rors: 01gyxrk03
previous_rors: 01sjmsj73;01gyxrk03
works_examples: W2897174558
contact: 24d6e8457f2ed84712e0418830a1cb74:7406e62b75ac6d6569a92958fd20a1c5 @ u-picardie.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Don't fail if -u, -o or -a are not supplied for cve validate command

Hi
This is actually similar to https://github.com/RedHatProductSecurity/cvelib/issues/92 but for the new added cve validate subcommand. AFAIU, the validation is against all local data, so I would expect
cve validate -s full -f ./tests/data/CVEv5_advanced-example.json

to just work without -u, -o and -a.
Is this correct?

Ah, thanks for the report. Fixed in linked PR!


Add initial schemas and sync with Clerk for user

added user schema for admin dashboard and successfully added user to my db.
Clerk sync still in progress, will add it when enhancing app.


Failed to find root link: Two robot links fopunds: [base] and [world]

Hi, recently I cloned this repository(tm700_demo) and try to
roslaunch tm700_demo_moveit_config tm700_demo_moveit_planning_execution.launch

but I met some problem in the following pictures:

it seems like there's no URDF model loaded

it appearse NO PLANNING LIBRARY LOADED

However, I found out that if I use the older package (techman_robot), everythin went really well.

roslaunch tm700_demo_moveit_config tm700_demo_moveit_planning_execution.launch

So I'm not sure is there anything gose wrong here.
Many thanks.

Hi I'm facing the same issue: Two root links found
How did you resolve it?


Repos: Support multiple repos through and through

At the moment, pulldasher only supports a single repository. Let's update it to support more than one. We'll still only have one dashboard, but it may have pulls from across multiple repos.
A few record types contain a repo column, but nearly all of them will need it (and need it filled in)

💯


Support Java Modules

ion-java 1.5.1 defines an automatic module name
$ jarviz module descriptor --file ion-java-1.5.1.jar
name: software.amazon.ion
version: 1.5.1
open: false
automatic: true
main-class: software.amazon.ion.impl._Private_CommandLine
requires:
  java.base mandated
contains:
  software.amazon.ion
  software.amazon.ion.apps
  software.amazon.ion.facet
  software.amazon.ion.impl
  software.amazon.ion.impl.bin
  software.amazon.ion.impl.lite
  software.amazon.ion.system
  software.amazon.ion.util

I'd be great if the library supplied a full Java module descriptor. It's possible to keep bytecode baseline compatible with Java 5 while providing a full module descriptor thanks to ModiTect. This will help modular projects that consume ion-java, specifically those that create custom Java Runtimes with jlink, as the latter does not support automatic modules but explicit modules. If interested I can send a PR to make it happen.

Thanks for bringing this to our attention. We'll need to understand the ramifications before we make any changes—I'll be the first to admit that I am only familiar with Java modules in a very general sense—but we would welcome a pull request.
Can you tell us anything more about ModiTect? I took a look at it, and it doesn't look like it is actively maintained. (For posterity, ModiTect also has a Gradle plugin, though it also looks like it's no longer maintained.)
Given that we only need one module-info.java for our project and that we intentionally don't have dependencies outside the Java std library, is there any reason we can't hand-write the module-info.java file once and forget about it?
Do you absolutely need ion-java 1.5.1? That version is nearly 4 years old, and there have been a significant number of bug fixes and performance improvements since then. We would prefer not to revisit such an old version if possible.

I'm currently cinsuming ion-java as a transitive dependency of com.amazonaws:aws-java-sdk-s3:$1.12.374 which is also not fully modular compatible. However, v2 of that API is (such as software.amazon.awssdk:s3:2.20.5).
The reason why I've stayed in v1 is because last time I checked v2 brings a boatload of dependencies due to reactive and async support, which I don;t need at all and would like to keep my dependency set as small as possible. This being said, perhaps I can have another look at v2 and see how/if the dependency graph may be trimmed down to a manageable size. If that were to be the case then I wouldn't need updates for ion-java in it's v1 form.
ModiTect is still maintained albeit not as fast as it used to be in the past. The Maven plugin lives at the core of the project while the Gradle one is provided as an external project. The current releases are stable enough even though their version numbers indicate RC. For example, the Jetty project relied on ModiTect to create module-info.class on the fly for their v9 and v10 releases IIRC. they switched to full modules and Java11 as baseline in v11, no longer needing ModiTect after that.
You could certainly hand-write module-info.java and make it part of the same compilation session, without having to rely on yet another external plugin like ModiTect.

I'm currently cinsuming ion-java as a transitive dependency of com.amazonaws:aws-java-sdk-s3:$1.12.374

So are you actually using Ion in your application, or are you only dealing with this issue because it's part of the AWS SDK?

Only because it's a part of the AWS SDK I require to post binaries to S3 buckets.

unfortunately v2 of the AWS SDK is not yet fully modular
$ jarviz module descriptor --gav software.amazon.awssdk:s3:2.20.5
name: software.amazon.awssdk.services.s3
version: 2.20.5
open: false
automatic: true
requires:
  java.base mandated
contains:
  software.amazon.awssdk.services.s3
  software.amazon.awssdk.services.s3.checksums
  software.amazon.awssdk.services.s3.endpoints
  software.amazon.awssdk.services.s3.endpoints.internal
  software.amazon.awssdk.services.s3.internal
  software.amazon.awssdk.services.s3.internal.crt
  software.amazon.awssdk.services.s3.internal.endpoints
  software.amazon.awssdk.services.s3.internal.handlers
  software.amazon.awssdk.services.s3.internal.resource
  software.amazon.awssdk.services.s3.internal.settingproviders
  software.amazon.awssdk.services.s3.internal.signing
  software.amazon.awssdk.services.s3.model
  software.amazon.awssdk.services.s3.model.selectobjectcontenteventstream
  software.amazon.awssdk.services.s3.paginators
  software.amazon.awssdk.services.s3.presigner
  software.amazon.awssdk.services.s3.presigner.model
  software.amazon.awssdk.services.s3.transform
  software.amazon.awssdk.services.s3.waiters
  software.amazon.awssdk.services.s3.waiters.internal

The last time I spoke with the people responsible for the AWS Java SDK, they told me that Ion is not actually supported by the SDK. Since it's apparently not needed by the AWS SDK and you're not actually using ion-java for anything, you should be able to exclude it from your dependencies. (Here's how, using maven or gradle.)

Thanks. I wonder if its inclusion as a dependency is remnant of a previous version of the SDK and someone forgot to take it out.


setup.py

Making py2js setup.py installable would make it easier to try out deploy etc.
Comments
certik May 14, 2010 | link | edit | delete
That's a good idea. Where should we put the py-builtins.js and later on possibly other scripts?
panosl May 14, 2010 | link | edit | delete
distutils has two options for this.

http://docs.python.org/distutils/setupscript.html#installing-package-data

If the *.js files are considered data it's under
package_data = {'py2js': ['data/*.js']}
http://docs.python.org/distutils/setupscript.html#installing-additional-files, where the layout might be like:
data_files = [('js': 'py-builtins.js')]
certik May 14, 2010 | link | edit | delete
Awesome, this should work. I am a bit busy today, do you think you can fix this in your branch? I'll merge it.
panosl May 14, 2010 | link | edit | delete
Which way do you wanna go though?
certik May 14, 2010 | link | edit | delete
Any way is fine with me. Choose one, it can always be changed later if it turns out that it doesn't work.
I guess that py2js.py should then somehow figure out the correct path to get the py-builtins.js, right?

Is a setup.py script still planned?


upgrade seralize-javascript library

Addresses security vulnerability alert described here: https://github.com/fission-suite/ipfs-photo-gallery/network/alert/yarn.lock/serialize-javascript/open

Sweet thanks :tada:


Add phases for an idea (Employee Ideas App for Teams)

Like a campaign has phases, I'd like to have an idea assigned to a phase so for example

Collect
Analyze
Accept
Reject
In Progress
Completed

These are just examples - does not need to be these labels.

Thank you for creating GitHub issue for documentation. Please reach out using Power Apps Ideas Forum for suggestions to improve products and features.


Add golanglint ci

add golangci-lint
add shellcheck
enabled pre-commit hooks ( spellcheck, phony targets & markdown-link-check)
use new logo

hmm, the images size is currently 1.15GB .. that's not acceptable and we need to change that.


[RFC][FEATURE] Model alias

Introduction:
Right now our model versions are identified by random IDs. Meanwhile, most of our ML-related behaviors at this time require user to refer the model ID directly, which are hard to remember and use due to its abstractness. This can lead to confusion and errors when the users want to refer to a specific model or compare different models. To address this issue, we propose to design and implement a model alias feature for our ml-commons. This feature will allow users to assign a custom alias to each model they create or use, and then use this alias as a reference instead of the model ID. For example, a user can name their model "text_embedding" or "sentiment_analysis" and then use these alias in their queries or commands.
Benefits of this feature:

It will improve the user experience and satisfaction by making it easier and more intuitive to work with machine learning models.
It will reduce the risk of errors and mistakes by avoiding confusion between different models or using the wrong model ID.
It will enable more efficient and effective communication and collaboration among the users who share or exchange models.

Where model id is being used now:

The get/delete/deploy/undeploy/predict model API required model ID right now.
In Neural Search Plugin, in order to ingest vectorized documents, you need to create a Neural Search pipeline. A pipeline consists of a series of processors that manipulate documents during ingestion, allowing the documents to be vectorized. The following example API operation creates a Neural Search pipeline:

PUT _ingest/pipeline/nlp-pipeline
{
  "description": "An example neural search pipeline",
  "processors" : [
    {
      "text_embedding": {
        "model_id": "bxoDJ7IHGM14UqatWc_2j",
        "field_map": {
           "passage_text": "passage_embedding"
        }
      }
    }
  ]
}

Neural search query also needs model id, for example
            "query": {
              "neural": {
                "passage_vector": {
                  "query_text": "Hello world",
                  "model_id": "xzy76xswsd",
                  "k": 100
                }
              }
            },

Pain point
Suppose the user have a new model version and they want to use it to replace the old version. They need to update the pipeline by changine the model_id. User also need to change model id in neural search query.
Another example: User build some application with OpenAI remote model, and later they prefer to move to a another model like Claude model, then user have to change the model id in their application code and redeploy. That will have service unavailable window.  With model alias, user can simply move alias from one model to another, then all request will be routed to the new model, no need to redeploy, no service unavailable window.
Solution HLD:
Option 1: The model alias is globally unique
Plan:

Model alias is an optional field when the user register a model (null is a legal value)
User can give or modify(including remove) model alias anytime through model update API
Every time when user create or modify the model alias, we will initiate a global uniqueness checking towards the model alias given by the user. If it does not meet the global uniqueness requirement, an exception will be thrown.
User can re-link model alias to a different model through model update API

pros:

This solution does not require too much changes in the backend
This solution requires less checks

cons:

Generally user intends to create intuitive and meaningful names, which are very likely to be similar and can easily cause collision. This indicates user frustration when alias number grows.
The user may need to keep update model alias once they update their model.

Solution LLD:
Plan:

This solution mainly involved in three methods: create-alias, update-alias, and delete-alias
Global uniqueness check: we check both on model ID and model aliases.
Create-alias: API endpoints use model ID to locate the model. We first initiate a global uniqueness checking. If it does not meet the global uniqueness requirement, an exception will be thrown. If global uniqueness check passed, we return a success message.
Update-alias: API endpoints use model ID to locate the model. We first check if the model group has the alias. If yes we relink the alias. If not we throw an exception.
Delete-alias: We check if user can access the model, if yes then the corresponding alias can be removed and be released to public

Security

DDOS
Abuse of update-alias method (Use update-alias without communicating with collaborators)

Backward Compatibility

This solution does not involve in any breaking changes, so backward compatibility won’t be a problem here.

Testability

The logic is pretty straightforward, so testing won’t be a problem here. But if we want we can let neural search team to test the feature before release, to gather some metrics and feedback.

This is a great idea, love it!
In the case where the alias namespace gets crowded, it would be very helpful to have some kind of search-aliases API to see what names are taken, and perhaps where they point so I don't end up duplicating these unnecessarily.
Another option to consider could be to have alias names be unique on some kind of access-control basis: it could be very frustrating to try to create aliases but then be unable because someone's already done so in an access level above you. I'm not sure that's a real thing, but something to think about.
Can you explain the LLD update-alias in more detail? I'm having a little trouble understanding. Can a model have multiple aliases associated with it?
Thanks

Will connectors get aliases, too?

+1 this will be a great user experience and will help with model versioning and MLClient interactions.
Couple of suggestions and questions:

Global uniqueness check: we check both on model ID and model aliases.

Curious where the global alias metadata is stored and how.

Option 1: The model alias is globally unique

Did you consider other options? Like unique model aliases per model group.
Though I like the approach of globally unique aliases, it would be nice to compare alternatives.

With introduction of model access control[1], control is operated on model groups. How does it work with aliases being introduced?
For create/update/delete-alias APIs, we should validate if the user is authorized use these APIs and also when these aliases are accessed we need to make sure the user has right level of permissions to access the model.

model_id is mandatory today, how do we handle when both model_id and model_alias are present? It would be good to clarify that.

            "query": {
              "neural": {
                "passage_vector": {
                  "query_text": "Hello world",
                  "model_id": "xzy76xswsd",
                  "model_alias": "neural_search_text_embedding",
                  "k": 100
                }
              }
            },

Where model id is being used now

Update MLClient?

[1] https://github.com/opensearch-project/ml-commons/blob/2.x/docs/model_access_control.md

Will connectors get aliases, too?

I think we can add alias for connector too. @austintlee , Will it be useful? Any concern?

What if the model_id could just be manually specified instead of randomly generated?
Instead of creating alias functionality around the ID, you could just specify the ID of your choosing when you create the various objects. If the ID attribute is left off, then it's auto-generated as it is today, but when specified the ID is used. Users could then decide if they want to use a "text-friendly" ID (e.g. "neural_search_text_embedding_model"), a UID of their own or the one OpenSearch creates.
Would that simplify things?
There's probably some technical reasons why this might not be feasible (and why it wasn't done from the start), but I'm just wondering if this wouldn't simplify things if there are no technical reasons why the ID cannot just be specified during creation.

+1 for this feature.
I'm trying to work on scripts so we can provision our servers. We deploy to varies different environments, so having IDs that are consistent across deployments makes the chain much easier to manage, especially since our indices are created on-the-fly.
Right now, there's no simple solution to referencing the model workflow, since the IDs will be different on every instance. The application stack needs to search of the registered models by name and find their IDs and then store that for use in the application and then we need to look it up any time we need to run some one-off queries.
Having the ability to use an "alias" (or define our own ID) would definitely simplify our workflow.

why is the model name not unique the same way that an index is unique?
adding yet another layer of indirection -- alias -- seems to be going in the wrong direction, which is ease-of-use

Thanks @rbpasker ,

why not make model name unique in the same way that an index is unique?

This is some historical issue. The model name was designed not as identifier (no uniqueness check) at first. Considering we have many users are using this and they may have models which same name. If we change the model name design to be an identifier, will be challenging to support backward compatible (for example, user have two models with same name, if they use same model nam, we don't know which model should be used). Adding an alias is easier for supporting backward compatible.

I agree with @rbpasker the current proposed solution will add more friction and complexity.

will be challenging to support backward compatible (for example, user have two models with same name, if they use same model nam, we don't know which model should be used). Adding an alias is easier for supporting backward compatible.

easier != the best solution
Why not something like this?:
if models.get(name).size > 1 then fail("there are 2 models with the same name please update accordingly) else do whatever

What purpose does a model name even serve, if it is not unique is never used by the system anywhere else,and there is a separate model description?
Alternatively, make model name optionally unique. With no change to the model definition, it works exactly as now. By adding "model-unique":true , system would do a uniqueness check, and return HTTP 409 Conflict if it already exists https://www.rfc-editor.org/rfc/rfc7231#section-6.5.8

@rbpasker Thanks for your suggestion. Sounds an option.
Want to clarify some details

By adding "model-unique":true , system would do a uniqueness check, and return HTTP 409 Conflict if it already exists

Do you mean add another field model-unique in model or add a cluster setting to check uniqueness for all models?
Adding a field to model will be "smallest surface area for implementation and testing".

@ylwu-amzn i updated the comment to refer specifically to the model definition.


Can we add an environmental variable when we fireup terminal so that the terminal session knows it's in a VS~ code environment?

for example, I run TMUX and i have a zsh config file saying launch tmux every time I open a terminal session.
For Intellij, they have an environmental variable indicating that the terminal is running in intellij so I can disable tmux from firing up in intellij terminal.

See $TERM_PROGRAM and $TERM_PROGRAMM_VERSION

@Tyriar this only tells what app you are using. for example, I get iTerm on $TERM_PROGRAM that does not help if my terminal is opened in Intellij or VSCode

@fsw0422 I don't understand what you mean?

Launch iterm
echo $TERM_PROGRAM gives iTerm.app (expected)
Launch code-insiders from iterm
Open integrated terminal echo $TERM_PROGRAM gives vscode (as designed)

Am I misunderstanding?

sorry my bad. my terminal launches tmux by default and it didn't carry the $TERM_PROGRAM environment. thanx

Do you share your tmux session? If so then this is by design, tmux should inherit the environment fine if it's a new session.


Modified super() calls to be Python2.7 compatible.

django-ckeditor currently throws the following exceptions when running on Python2.7 based django installations:
File ".\lib\site-packages\ckeditor\fields.py", line 47, in init
super().init(*args, **kwargs)
TypeError: super() takes at least 1 argument (0 given)
This pull request makes django-ckeditor compatible with Python 2.

You've closed the PR already but for the record: I'm not interested in Python 2 compatibility anymore. Python 2 is EOL and there are no supported versions of Django which still run on Python 2 at all.
Thanks!


Remove get prefix from getTokenForcingRefresh and getLimitedUseToken

Renamed getTokenForcingRefresh:completion: to tokenForcingRefresh:completion and getLimitedUseTokenWithCompletion: to limitedUseTokenWithCompletion: since they behave like the public API methods of the same names in Firebase App Check (rather than the interop methods).

cc: @mdmathias Once you update your AppCheckCore dependency to 0.1.0-alpha.4 you'll need to change getLimitedUseTokenWithCompletion: to limitedUseTokenWithCompletion: on line https://github.com/google/GoogleSignIn-iOS/blob/18b5fbe51adcef2d38d539f1693adbf15875bb1c/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m#L142.


[WIP] Improve Yolo WASM UI example

Only missing the last UI iteration, I'll push soon

Looks pretty great, some small points:

If you haven't already done so, could you test the pure rust UI building it via trunk and checking that it still looks fine?
Not sure if we want to include the images as they add to the repo size, maybe just have a link to them?
Either make a script for building the wasm bits for the JS UI (and download the image too?) or put some indications in a local README.md on how to build/deploy?

Looks pretty good to me, if you think it's ready can you remove the draft tag from the PR and we can merge?

thanks @LaurentMazare

If you haven't already done so, could you test the pure rust UI building it via trunk and checking that it still looks fine?
I've tested with the new changes and it's as before. I had to hardcode the new params as the worker now expect model_size, conf_threshold and iou_threshold

Merged, great work on this UI, that's super helpful!


Move to WildFly Core 1.0.0.Alpha16

Linux with security manager Build 801 is now running using a merge of 1f3d396e03d19089baec5afa6bff8a3f4579883e

Windows Build 925 is now running using a merge of 1f3d396e03d19089baec5afa6bff8a3f4579883e

Linux Build 5816 is now running using a merge of 1f3d396e03d19089baec5afa6bff8a3f4579883e

Linux with security manager Build 801 outcome was SUCCESS using a merge of 1f3d396e03d19089baec5afa6bff8a3f4579883e
Summary: Tests passed: 851, ignored: 316 Build time: 0:07:58

Windows Build 925 outcome was SUCCESS using a merge of 1f3d396e03d19089baec5afa6bff8a3f4579883e
Summary: Tests passed: 2934, ignored: 311 Build time: 0:49:53

Linux Build 5816 outcome was SUCCESS using a merge of 1f3d396e03d19089baec5afa6bff8a3f4579883e
Summary: Tests passed: 2934, ignored: 311 Build time: 0:51:00


NOISSUE - Add performance improvement to writer filtering

What does this do?
Improves writer filtering performance by replacing a list with a set.
List any changes that modify/break current functionality
There are no such changes.
Have you included tests for your changes?
No.
Did you document any new/modified functionality?
No.

Codecov Report

Merging #744 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #744      +/-   ##
==========================================
+ Coverage   85.32%   85.35%   +0.02%
==========================================
  Files          68       66       -2
  Lines        4321     4220     -101
==========================================
- Hits         3687     3602      -85
+ Misses        424      415       -9
+ Partials      210      203       -7

Impacted Files
Coverage Δ

readers/postgres/messages.go

readers/postgres/init.go

writers/cassandra/init.go
80% <0%> (+20%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc5c66b...7de7aec. Read the comment docs.


assignment of computed property

If this is a bug, please try reproducing using https://flow.org/try/.
I have this code:
type HttpRequestData = {
	url:string,
	method:string,
	headers?:Object,
	body?:string,
};

function request(options: HttpRequestData) {
  options.headers = options.headers || {};

  options.headers['Accept'] = 'application/json';
  options.headers['Content-Type'] = 'application/json';    << Error
}

It gives me this error:

assignment of computed property/element. Computed property/element cannot be assigned on possibly undefined value

I didn't used computed property. Also when I comment that line, it works. Why it passes with headers['Accept'] part that has same syntax?
https://flow.org/try/#0C4TwDgpgBAEsxgEoQI4FcIGdgBECGweUAvFAN4BQAkGgE4A2AXNrQJYB2A5gDTUC2EYAAsA9gBNmwNl15UhEPGIi1MAfkYB5AEYArCAGNgsreJDqWHHhQC+AbgoUAZmnaHWI9lFqoM2ABQiYMDu7JiMsPBIPli4BHgAlOQUUFCBwR6YAHTyisqYJKlBIVk5SipQAD4V5HbUVMmF6aHZCmWYANoA5ACC+voQQZ0AugWdeGBg9Kz6BCEA9DqYHp32KWnFLbkqXQDCHsAQ7MAAtAAq4BDDo+OT07MeC0vsKzZAA

This kind of dynamic pattern won't be supported.


Tweaked the build monitor design

Fixes #1526
This ended up being a bigger tweak to the design than I thought it would be but I like that the time is now more closely related to the status.

Deploying as 2.57.1


Version visibility log

The route /{author}/{slug}/versionLog that also takes a body parameter for a version string doesn't seem to be used anywhere? It fills in a template for showing visibility changes to a certain version. Should we keep it around? If so, it should probably be renamed to /{author}/{slug}/versions/{version}/log and have a link added to the Admin Actions dropdown on the version view.

Perhaps it was removed in favour of the general logs? I believe you can achieve the same thing with its filters.

This issue should include adding a user action log type for version visibility changes. One exists for project visibility changes already.


Track checksum in Cargo.lock

Packages in the registry should never be changed in place. We currently track the content of each package using a checksum in the registry index; I think we should start recording that checksum in the Cargo.lock, to increase the likelihood that we detect if the index were to be maliciously updated like this.
For example, one common way of building programs is to push the entire package source to a build machine, without vendoring crates. This build machine may have a cache of crates and cargo set up, or it may be instantiated from nothing for each build. In the latter case, a targeted MITM attack could replace the registry index with one containing malicious crates when the build machine connects to github to download the index, and this would not visibly changing the output of the build.
If package pushed to the build machine has a lock file (as is the default for applications), a MITM attack like this would be detected, because the checksums in the index would not match the checksums in the lockfile.
Similarly, malicious edits to the actual index would be more likely to be discovered because they would be likely to lead to build failures for anyone who has that crate in their lockfile.
This is a relatively small change, and I'd be glad to make the PR if we think its a good idea. cc @rust-lang/cargo

It turns out we already do track checksums for each package in the lockfile, they just aren't where I expected them to be (there's a table at the end, rather than inline with each package). Closing as we already have this feature.

We've even got a test for what happens when it changes!

Packages in the registry should never be changed in place.

That's true! Sometimes, they can be changed by accident:

LARLPOP build.rs by default overwrites files in the src directory
If you run cargo metadata inside the registry, you might create a lockfile.
You might be inclined to just edit the files by hand

It would be great to prevent such accidents with a better error message. One useful thing I've observed recently is making certain parts of file-system readonly (nix does this for /nix/store and bazel does this for the build dir with dependencies). Could Cargo mark registry and vendored sources as readonly as well?


'React/RCTBridgeModule.h' file not found

Hello,  I am trying to use react-native-linea in my react native app and during build i am getting React/RCTBridgeModule.h' file not found    error. Could you please help ?
Steps i tried -
1. react-native init ScannerApp
2. cd ScannerApp/
3. npm i react-native-linea --save
4. react-native link react-native-linea
5.Drag and drop the InfineaSDK Framework into the General > Embedded Binaries section of your Project. The framework will also display the Linked Frameworks and Libraries.
a. Verify that Copy Items if needed is checked.
6.Add the following to General > Linked Frameworks and Libraries:
• CoreLocation.framework
• ExternalAccessory.framework
• Foundation.framework
7.Add a new Run Script phase.
At the end of your project’s Build phase(s), add new running scripts to set up InfineaSDK.
FRAMEWORKS="${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}" "${FRAMEWORKS}/InfineaSDK.framework/SDKSetup"
8.react-native run-ios
****Error*****
simulator/react-native-linea.build/Objects-normal/x86_64/RCTLinea.o
In file included from /Users/****/reactnative/ScannerApp/node_modules/react-native-linea/react-native-linea/RCTLinea.m:9:
/Users/****/reactnative/ScannerApp/node_modules/react-native-linea/react-native-linea/RCTLinea.h:9:9: fatal error: 'React/RCTBridgeModule.h' file not found
#import <React/RCTBridgeModule.h>
        ^~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

** BUILD FAILED **

yarn add react-native-linea - fixed the issues

I have no access to a scanner anymore to test this. It's been a while ago since I worked on this. I know that this once worked, but for now, I'm sorry to say that I can't help :(


need a proper documentation of contribution.md

Hello there! I'd like to work on this issue - I can start working on it upon assignment

Hi, I would like to work on this issue. Thanks !

Hi this is Akshat Jain and I'd like to work on this issue. From what I've understood, you want  meto write a markdown explaining various guidelines for contributors. I'd like to complete it within a given time frame :)

Hi this is Akshat Jain and I'd like to work on this issue. From what I've understood, you want meto write a markdown explaining various guidelines for contributors. I'd like to complete it within a given time frame :)

i want it by 2nd oct ok !!

Hi this is Akshat Jain and I'd like to work on this issue. From what I've understood, you want meto write a markdown explaining various guidelines for contributors. I'd like to complete it within a given time frame :)

i want it by 2nd oct ok !!

sure! Thanks for the issue :)


libcudla.so.1 trouble while "make"

Hei,
I have another problem with "make"-command trying to build the project from source. I already tried to clone the repo twice and "make" still gets stuck with the same mistake:
"/usr/bin/ld: warning: libcudla.so.1, needed by /usr/lib/gcc/aarch64-linux-gnu/7/../../../aarch64-linux-gnu/libnvinfer.so, not found (try using -rpath or -rpath-link)"
Any ideas about this?

@ElenaSkrebneva which Jetson and version of JetPack-L4T are you running?
Do you have CUDA Toolkit installed?   That library should be found under /usr/local/cuda/lib64
ls -ll /usr/local/cuda/lib64/libcudla*
lrwxrwxrwx 1 root root     13 Sep 14  2022 /usr/local/cuda/lib64/libcudla.so -> libcudla.so.1
lrwxrwxrwx 1 root root     17 Sep 14  2022 /usr/local/cuda/lib64/libcudla.so.1 -> libcudla.so.1.0.0
-rw-r--r-- 1 root root 179792 Sep 14  2022 /usr/local/cuda/lib64/libcudla.so.1.0.0

If not, try doing sudo apt-get update && sudo apt-get install cuda-toolkit-*


where is voipEnabled property?

hi.
i can't find voipEnabled method in Socket class.
where i try socket.voipEnabled = true got this error:
Value of type 'WebSocket?' has no member 'voipEnabled'
but every other things just works fine.
xcode 10

voipEnabled was removed as Apple no longer supports background like that. See previous issues for more discussion around this.


unexpected command tag UPDATE

sql := "update table1 set field1 = field1 + 1 where id = 1 returning field1, field2"
tx := DB.Begin()
rows, err := tx.Raw(sql).Rows()
if err != nil {
	tx.Rollback()
	log.Panic(err)
	return
}
...
tx.Commit()

[2016-02-03 11:30:12]  [20.36ms]  update table1 set field1 = field1 + 1 where id = 1 returning field1, field2
[2016-02-03 11:30:12]  unexpected command tag UPDATE
What am i doing wrong?
Same scenario works perfectly in sql database itself.

I think this is not an error from GORM, but from database, so can't help on that.
Maybe good to search this question with more detailed information of your database.
Sorry for that.


Stash 3.0.0 is incompatible with flutter_test

Describe the bug
By extension Stash is unfortunately pretty much incompatible with most flutter projects
Because every version of flutter_test from sdk depends on async 2.6.1 and stash >=3.0.0-dev.2 depends on async ^2.7.0, flutter_test from sdk is incompatible with stash >=3.0.0-dev.2.
And because stash_dio >=3.0.0 depends on stash ^3.0.0, flutter_test from sdk is incompatible with stash_dio >=3.0.0.
So, because alltold depends on both stash_dio 3.0.0 and flutter_test any from sdk, version solving failed.

FWIW adding this to pubspec.yaml seems to work as a temporary fix:
dependency_overrides:
  async: 2.6.1

I can go back to the previous version I think I'm not using anything special from 2.7.0. Let me check

I've downgraded to version 2.6.1 of async in version 3.0.1 that I've just published


Define a Generic/Blank Entity

A have in a number of places created something like the following:
final case class CustomEntity(x: Int, y: Int, width: Int, height: Int, depth: Depth, shader: ShaderData)
    extends EntityNode[CustomEntity]:
  val flip: Flip                    = Flip.default
  val position: Point               = Point(x, y)
  val size: Size                    = Size(width, height)
  val ref: Point                    = Point.zero
  val rotation: Radians             = Radians.zero
  val scale: Vector2                = Vector2.one
  lazy val toShaderData: ShaderData = shader

  def withDepth(newDepth: Depth): CustomEntity =
    this.copy(depth = newDepth)

  val eventHandlerEnabled: Boolean                                      = false
  def eventHandler: ((CustomShape, GlobalEvent)) => Option[GlobalEvent] = Function.const(None)

Which is really just a 'blank' scene entity that I can use to render a shader on the screen somewhere.
It would be nice to have a formal one of those with all the usual spatial modifiers so that if you just need a spacial placeholder and you're prepared to do the rest manually, you can.
What to call it? :thinking:

I've labelled this as a good first issue. It requires a bit of context but the work is fairly mechanical. Would be happy to talk someone through it if they turned up on our discord chat.


ESM build : reassignment of import and require

Hello,
i'm trying to use react-mapbox-gl 4 with Rollup but I'm having problems :

The problem discussed here - how to reproduce

In short:
In node_modules/react-mapbox-gl/lib-esm/map.js, there is
import * as MapboxGl from 'mapbox-gl';
/* ... */
MapboxGl.accessToken = accessToken;

which throws Illegal reassignment to import 'MapboxGl'.
Since mapbox-gl has a default export, changing the first line to import MapboxGl from 'mapbox-gl'; fixes this problem.

A few lines later there is var isEqual = require('deep-equal');, which is causing problems since  there is mixed ESM and CommonJS syntax in the same file, and this is the "module" entrypoint in package.json.

Of course I may be missing something here. If so, if someone has any experience getting react-mapbox-gl 4 working with Rollup, I'd appreciate any help.
For what it's worth, version 3.x works fine (but there is no esm build).

does the 4.x commonjs version work for you?

Hi I ran into what I think is a related issue when bundling with Webpack - the setter was not being called so MapboxGl.accessToken was set to my access token, but this setter was not called, so config.ACCESS_TOKEN was never set. This only started becoming a problem in the past month, so I am assuming that Webpack made a change to be more spec compliant and stop this working?
TL;DR I think the way this is written in ESM should not work, but it works in many bundlers because they are a little more lenient. I think the change @camille-hdl suggests should work.

@mklopets I tried manually importing from the cjs build, but ran into other issues (I don't remember exactly but it was related to the mixed import / require syntax I described in the OP iirc)

ah ok I see the code is written in TypeScript, so you need this * import to get the types. I'm not familiar enough with TypeScript to know the workaround for this.

Not sure if I was looking at the same issue, but you might try installing the mapbox-gl types directly
npm install -D @types/mapbox-gl

@camille-hdl did you manage to fix this?

@sirgalleto I haven't found a workaround, that said I haven't tried to update it in a while (I stuck to 3.x for now), so I don't know if it's fixed now.

@camille-hdl I was trying to use the latest version, but is still broken, now using 3.x as well.
I'm wondering what options we have for TypeScript, I have not too much experience using TS so I'm not sure about how to change the import * from MapgoxGL. I'll investigate a little bit and try to come with a solution.


contributing documentation

What should we add?
Getting a functioning dev environment has steps not outlined in the current CONTRIBUTING.md documentation. As an example, the section on using conda is not complete as there is no environment file for conda in the repo, and there are dependencies that will be missed if a user follows the current documentation as is.
I would also like to point out that there are steps in the project's Makefile that could help speed up starting development on the project, and should be highlighted in the contributing document. I personally glazed over the rules in the Makefile when creating my first PR, and probably should not have done so as there are good steps that I should have done before creating it. Some of the steps in the makefile, e.g. linting and formatting, could be automated by pre-commit for local development. If the community is interested in using pre-commit, I'd be happy to add those to the dev process, and the creation of its documentation. Let me know if y'all would like one or the other, or both items discussed in this request.

Update the CONTRIBUTING.md document with more discussions on how to build a working dev environment.
Add pre-commit as a dev dependency and document its use.

Thanks for the report - some of our dev-env documentation may have got a bit lost in a recent transition of where the Qiskit documentation lives, and some of it may be out of date, so it's good to be fixed up.  We should be careful about overloading it with too many permutations of things, though - it's already probably too long, and people using non-standard tooling like conda can consult its own documentation.
I don't think a Conda environment file is necessary; we use tox for dev-tooling isolation, along with requirements files in the standard built-in format (pip requirements files, like requirements-dev.txt).  The lint suite is run by tox -e lint, as discussed in the contributing guide, and the local API docs preview is built with tox -e docs.  There's no need for somebody getting started to install the tools manually; all you need is to build the package from source, which is done by the standard pip install -e ., with a Rust compiler available.
I'm actually a bit surprised that the Makefile commands still work - I didn't think it had been significantly maintained for years despite a lot changing in how we lint, run CI, and everything else.  I'd largely forgotten it existed.
You're quite welcome to use pre-commit locally if you desire, but beware that pylint is rather slow (runtime of minutes) and unsuited to it. I personally have not been too convinced by pre-commit; it's one more of a litany of things to teach new contributors to install, it slows down committing so gets in the way of "commit-then-rebase" workflows, and we have to test everything it would check in CI anyway because it's not guaranteed to run.

Understood. I'll continue to read the code base more and determine where my misunderstanding came from while building a dev environment. If there is anything I think is relevant by breaking down the process again, I'll make a different issue with a PR.
I'm going to close this issue in favor of the discussion in #11504


why default media type has been changed?

this line
https://github.com/yegor256/takes/commit/c6a98c9ff6ceb47f427fb1df0423fc8a3980f2e5#diff-3628fdd06e17f22ff51a01c1aa51515aR92
has been changed from
list = new MediaTypes("*/*");

to
list = new MediaTypes("text/html");

in commit c6a98c9ff6ceb47f427fb1df0423fc8a3980f2e5
unfortunately I don't see any PR(or an issue) related to the commit
Why was this done?
Is it bug or feature?

@dmzaytsev it's a feature. if no content type is provided by the browser, we must assume that text/html is expected. If we put */* there, text/xml or application/json will be returned, for example, which is not what the browser is ready to process.

@dmzaytsev you think I should put some documentation into the code about it?

@yegor256 yep, it would be nice to update readme
I can update the ticket description if needed

Job gh:yegor256/takes#475 is not assigned, can't get performer

This job is not in scope


chore: make SDK errors easier to debug

This PR adds a few usability improvements around errors that could reasonably occur if when users try to use this app with their Ory Network project.

adds better logging so it is immediately clear what the issue is

uses makeRedirectUri for return URL instead of a hardcoded URL so that OIDC login works on emulators & native devices as well.

Related Issue or Design Document

Checklist

[ ] I have read the contributing guidelines and signed the CLA.
[ ] I have referenced an issue containing the design document if my change introduces a new feature.
[ ] I have read the security policy.
[ ] I confirm that this pull request does not address a security vulnerability.
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact<EMAIL_ADDRESS>from the maintainers to push the changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added the necessary documentation within the code base (if appropriate).

Further comments

Replaced by https://github.com/ory/kratos-selfservice-ui-react-native/pull/77


Getting regex in allowed function

Hello, I need to determine by which regular expression the checked address will not be indexed. So I decided to offer a solution.
Path: texting_robots/src/lib.rs
pub fn allowed(&self, url: &str) -> (Option<String>, bool) {
    let url = Self::prepare_url(url);
    if url == "/robots.txt" {
        return (None, true);
    }

    let mut matches: Vec<&_> = self
        .rules
        .iter()
        .filter(|(rule, _)| rule.is_match(&url))
        .collect();

    matches.sort_by_key(|x| (&x.0, !x.1));

    match matches.first() {
        Some((rx, is_allowed)) => {
            (Some(rx.as_str().to_string()), *is_allowed)
        }
        None => (None, true),
    }
}

Hi @dot-pulsar, apology for the delay in reply.
What was the use case for determining whether a specific rule allowed or denied the given URL? I'm curious if there's a broader use case that might need  this type of information exposed.


Regarding the warmup in the snippet.

Hi,
Thanks a lot for your contribution.
I wanted to ask about the warmup thing. In your flexmatch training code there is args.warmup inside the if condition if max(pseudo_counter.values()) < len(self.ulb_dset):
Will it not everytime go in this if condition and args.warmup if condition? Because I printed the if statement and through the training it goes in args.warmup if condition.
So ACC to paper the warmup should get over after some time?
Is there a issue in a code or am I understanding it in a wrong way?
Thanks a lot,
Shreejal

Can you put your stdout here? So that we can help you debug the problem.


Realms is now compatible with mobile wallet apps

See https://github.com/solana-labs/wallet-adapter/issues/604 for much more information.
Test plan

yarn && yarn dev
npx ngrok http 3000

Desktop
https://user-images.githubusercontent.com/13243/197694908-bd16a8f7-ea79-41c2-ad1b-63a612953e26.mov
Mobile
https://user-images.githubusercontent.com/13243/197697187-99bd7df9-435b-4ffa-ae98-fd7ea0ed8f65.MOV

This is not the greatest solution. Eventually, you will want to tear out your custom wallet store implementation and just use the raw @solana/wallet-adapter-react package to get the full benefits of the Wallet Standard and the Mobile Wallet Adapter.
A similar refactor to what will be needed on Realms was done here: https://github.com/project-serum/serum-dex-ui/pull/157

@steveluscher Hi, i tested the pr it all works and builds locally but on vercel we are getting "error Command failed with signal “SIGKILL”." and its only on this branch i tried few times to redeploy but it didn't help any ideas ?

@steveluscher is attempting to deploy a commit to the blockworks-foundation Team on Vercel.
A member of the Team first needs to authorize it.

Isn’t it getting killed because I don’t have authorization to reply?

@steveluscher is attempting to deploy a commit to the blockworks-foundation Team on Vercel.
A member of the Team first needs to authorize it.

Isn’t it getting killed because I don’t have authorization to deploy?

Nope we have two organizations one is solana and it doesn't build on solana. i authorized deployments there.

@steveluscher is attempting to deploy a commit to the blockworks-foundation Team on Vercel.
A member of the Team first needs to authorize it.

Isn’t it getting killed because I don’t have authorization to deploy?

Ok looks like its related to web3.js update.
i created fresh pr with web3.js update and it have same result https://github.com/solana-labs/governance-ui/pull/1130

Oh, 100% that’s probably going to be because of BigInt compatibility. One sec.

Let's try this.

There we go.

Hey @steveluscher , the PR needs an additional commit to make it compatible with the new Realms Hub work. I put together said commit here: https://github.com/nramadas/governance-ui/commit/6ff87aea8960c48473cac4b1ce4519b5787e0b42 . Let me know what you think

Let me know what you think

I think you folks should take it from here! Just run through the test plan in https://github.com/solana-labs/wallet-adapter/issues/604

@nramadas Looks good on my side can we merge ? Is hub ok ?

@abrzezinski94 let's continue on this PR (https://github.com/solana-labs/governance-ui/pull/1135) instead since it contains some updates to make the new wallet compatible with the hub.


Replaced dls-controls with DiamondLightSource

Repository was automatically transferred from dls-controls/cs-web-lib using https://gitlab.diamond.ac.uk/github/github-scripts

@abigailalexander we've moved the repo, but not sure which of these changes need to be made to the repo as a result, please can you edit and merge this?


Corrected typo in decentralized-identifier-overview.md

@maestros : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@barclayn
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"

@maestros thank you for taking the time to submit this correction. We have made the necessary updates as part of article updates done in support of General Availability.  #please-close


[Feature Request] Check-only mode for CI

Sorry if it's a duplicate... an option that would just check if the ToCs are up-to-date without modifying anything would be useful for the CI use.
Currently I need to do sth like that:
https://github.com/VirtusLab/git-machete-intellij-plugin/pull/636/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R14

I think as a potential workaround, you could use the new --update-only flag that was introduced, and then see if there's any changes in the index?

Yes, I'm currently doing sth like that... just need #189 to be addressed for that workaround to fully work :/

If you want to run doctoc in the CI, ensuring tocs are up-to-date or fail the job if not, I highly suggest you this:
https://github.com/fluidattacks/makes#formatmarkdown
This is how a CI failure looks like:
https://github.com/fluidattacks/makes/pull/190#issuecomment-877709118
It can also be executed locally, which is nice

Thanks @kamadorueda, that seems like a neat case for using nix. I'd say the vast majority of people don't use it, though, so I think there's still a use case for developing something like this.


no-pretraining case

Hello,
Thank you very much for this study. I would like to  kindly ask why do you freeze most of the parameters in "dist_finetune_nopretraining.py" code. The model does not take weights from the pretrained model, but you still freeze most of them.

Hi and thanks for your interest!
scBERT consists of 6 transformer layers, followed by a 3-layer neural network that is appended during fine-tuning to predict the cell type label. During fine-tuning, the majority of the layers in the transformer are frozen, leaving only the final 2 layers with trainable weights (see GitHub). In order to set up an experiment that would evaluate the benefit of pretraining, we left everything about the finetuning setup unchanged, except we replaced the pretrained transformer weights with random weights. This meant having the same setup as the authors main finetuning setup, where the majority of the transformer weights are frozen and not updated during finetuning.
By the way, you might notice the scBERT authors presented results from a similar pretraining ablation in their Extended Data Figure 1a which showed qualitatively different results than ours. I believe that the authors unfroze all weights in the transformer during this ablation experiment, which meant that their “no pretraining” model was larger (i.e. had more trainable weights) than the finetuning model used in their main results. Given the fact that their experimental setup led to worse results on finetuning and ours did not, it seems that their "no pretraining" model performed worse on cell type annotation due to the larger model capacity, but not due to the removal of pretraining.

Hi,
Thank you very much for the detailed answer.


Investigate XAML pipeline / build needs update for object model split

The AdaptiveCards.Rendering.Uwp.3.0.0-202110.7001.nupkg package from https://microsoft.visualstudio.com/AdaptiveCards/_build/results?buildId=39966064&view=artifacts&pathAsName=false&type=publishedArtifacts doesn't work with an existing test app because it can't find a reference to the object model package:

@RebeccaAnne  - looks like we can use the nuspec to point to the object model project and it should be included in the built package: https://stackoverflow.com/questions/7486651/create-nuget-package-with-multiple-dlls


ys-0.1.20 linux release build won't run on openSUSE Leap 15.5 (glibc 2.31)

I tried running the 0.1.20 release build for Linux on openSUSE Leap 15.5 and got:
troyt@localhost:~/Downloads/ys-0.1.20-linux-x64> ./ys-0.1.20 --version
./ys-0.1.20: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by ./ys-0.1.20)
./ys-0.1.20: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by ./ys-0.1.20)
troyt@localhost:~/Downloads/ys-0.1.20-linux-x64> ldd --version
ldd (GNU libc) 2.31

Running make build in the repo on the same system produces a working build:
troyt@localhost:~> /usr/local/bin/ys --version
YAMLScript 0.1.20

Thanks @troytop
@borkdude gave me a ton of info for resolving this in the Clojurians Slack: https://clojurians.slack.com/archives/CAJN79WNT/p1701786909524679
Looks like the best fix is to build ys staticly. See https://www.graalvm.org/latest/reference-manual/native-image/guides/build-static-executables/

And also don't build on a machine/image with newer than 2.31.

I had the same issue. Ended up just building from source.


Question: support for iOS5+?

I noticed that the JavaScript SDK for LinkedIn doesn't support iOS 5+.
Does node-LinkedIn? Thanks!

Hi, I'm not sure as I didn't end up to such situation.We're a JS wrapper if you can run JS on your iOS device (which you can!), then the wrapper works too!

I'm just checking because LinkedIn specifically said that they don't support iOS 5+ in their documentation
See here

We're backend module, for usage in APIs, therefore, I cannot comment. However, it seems they wrote about their JavaScript SDK and we're API wrapper :)


chore: fix puppeteer version in chromium roll

@mathiasbynens Any idea why the tests are failing?

@mathiasbynens Any idea why the tests are failing?

https://github.com/puppeteer/puppeteer/pull/7300/checks?check_run_id=2709824054#step:6:94
The docs/api.md changes from #7288 were wrong as well, so they need to be corrected


Unable to create pvc in AzureGermanCloud

Is this a request for help?: Yes

Is this an ISSUE or FEATURE REQUEST? (choose one): ISSUE

What version of acs-engine?:
0.8.0

Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
Kubernetes v1.7.7
What happened:
Unable to create a persistent volume claim in the kubernetes cluster created in Azure Germany.
What you expected to happen:
The Claim should have created a Persistent Volume and map that the storage account.
How to reproduce it (as minimally and precisely as possible):
Create a cluster in AzureGermanCloud and then create a persistent volume claim from the default storage class.
Anything else we need to know:
Event Message:
Warning         ProvisioningFailed      Failed to provision volume with StorageClass "default": Put https://<storageaccount_name>.blob.core.windows.net/2838460267?restype=container: dial tcp: lookup <storageaccount_name>.blob.core.windows.net on <IP_ADDRESS>:53: no such host

I have the same issue are there any updates ?

v1.7.9 should solve this issue, just ping me if it does not work.

I have checked v1.8.3 has fixed this issue, cherry-pick fix for this issue is https://github.com/kubernetes/kubernetes/pull/54615
@pengzhisun FYI

I've checked on v1.8.2 deployed on azure germany and is not working , still same issue.
On azure portal the volume is created but , when kube is connecting to the volume we receive this error.
Warning  ProvisioningFailed  14s (x9 over 2m)  persistentvolume-controller  Failed to provision volume with StorageClass "default": Put https://p1339261175.blob.core.windows.net/36338085?restype=container: dial tcp: lookup p1339261175.blob.core.windows.net on <IP_ADDRESS>:53: no such host

@vidrascup yes, v1.8.2 does not work since cherry-pick https://github.com/kubernetes/kubernetes/pull/54615 is not in 1.8.2, v1.8.3 should work

@amkumar1989 since v1.8.3 has fixed this issue, could you close it?


[web][SIMS #301]Feature/programs summary 301

Created program summary list as shown below.

I moved the vue files related to programs (summary/add/edit/view) inside a new folder institution/locations/programs to be more aligned with the "left menu" and the navigation. @ann-aot and @guru-aot, please let me know your insights on this.

Created the placeholder for program view, as shown below.

LGTM