Fixing package.json to run Storyshots with Svelte

I wasn't able to successfully run Storyshots as per the tutorial without the following.  Seems like these should be in this template.
The tutorial that I followed is here:
https://storybook.js.org/tutorials/intro-to-storybook/svelte/en/simple-component/
Your existing template package.json just needs a couple of additions to enable successfully running Storyshot tests:

add the following to jest
"transformIgnorePatterns": ["node_modules/(?!(@storybook/svelte)/)"],
add the following to jest  "transform"
"^.+\\.stories\\.[jt]sx?$": "<rootDir>node_modules/@storybook/addon-storyshots/injectFileName",

Seems like this won't hurt anything with the above and then using Storyshots automatic tests is easy.
If you want to support it completely, add Storyshots to your devDependencies... but if you do that, update to latest versions (you're at Storybook 6.1 and 6.2 is needed for Svelte).
"@storybook/addon-storyshots": "^6.2.2",
Here's the complete Storybook 6.2 package.json that is working for me:
  "name": "intro-storybook-svelte-template",
  "version": "1.0.0",
  "description": "Starter template to get up and running quickly with Svelte and Storybook",
  "private": true,
  "author": "Chromatic <https://chromatic.com/>",
  "repository": {
    "type": "git",
    "url": "https://github.com/chromaui/intro-storybook-svelte-template"
  },
  "bugs": {
    "url": "https://github.com/chromaui/intro-storybook-svelte-template/issues"
  },
  "license": "MIT",
  "scripts": {
    "build": "rollup -c",
    "dev": "rollup -c -w",
    "start": "sirv public",
    "test": "jest --watchAll",
    "storybook": "start-storybook -p 6006 -s public",
    "build-storybook": "build-storybook -s public"
  },
  "devDependencies": {
    "@babel/core": "^7.12.10",
    "@rollup/plugin-commonjs": "^16.0.0",
    "@rollup/plugin-node-resolve": "^10.0.0",
    "@storybook/addon-actions": "^6.2.1",
    "@storybook/addon-essentials": "^6.2.1",
    "@storybook/addon-links": "^6.2.1",
    "@storybook/addon-storyshots": "^6.2.2",
    "@storybook/svelte": "^6.2.1",
    "@testing-library/jest-dom": "^5.11.8",
    "@testing-library/svelte": "^3.0.3",
    "babel-jest": "^26.6.3",
    "babel-loader": "^8.2.2",
    "jest": "^26.6.3",
    "jest-transform-svelte": "^2.1.1",
    "rollup": "^2.3.4",
    "rollup-plugin-copy-assets": "^2.0.3",
    "rollup-plugin-css-only": "^3.1.0",
    "rollup-plugin-livereload": "^2.0.0",
    "rollup-plugin-svelte": "^7.0.0",
    "rollup-plugin-terser": "^7.0.0",
    "svelte": "^3.31.2",
    "svelte-loader": "^2.13.6"
  },
  "dependencies": {
    "sirv-cli": "^1.0.0"
  },
  "jest": {
    "transformIgnorePatterns": ["node_modules/(?!(@storybook/svelte)/)"],
    "transform": {
      "^.+\\.js$": "babel-jest",
      "^.+\\.stories\\.[jt]sx?$": "<rootDir>node_modules/@storybook/addon-storyshots/injectFileName",
      "^.+\\.svelte$": "jest-transform-svelte"
    },
    "moduleFileExtensions": [
      "js",
      "svelte",
      "json"
    ],
    "moduleNameMapper": {
      "\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$": "<rootDir>/__mocks__/fileMock.js",
      "\\.(css|scss|stylesheet)$": "<rootDir>/__mocks__/styleMock.js"
    },
    "setupFilesAfterEnv": [
      "@testing-library/jest-dom/extend-expect"
    ],
    "testPathIgnorePatterns": [
      "/node_modules/",
      "/build/",
      "/storybook-static/"
    ]
  }
}

@etsiaDigital thank you for bringing this to our attention, I'm going to update the Svelte version of the tutorial sometime in the next weeks. And I'll factor in your issue when the documentation is updated. To give you a bit more context, this is not an issue with the template itself. Its main job it's only to get you set up with the least amount of commands possible.
It seems that what the tutorial is missing is the transformIgnorePatterns instruction. It might be related to some recent changes introduced.
Stay safe

@jonniebigodes
I saw something different just yesterday or so when creating a "recipe" for myself to start using Storybook more.
Yes originally I had to add the  transformIgnorePatterns but not this second time.  I went back through the tutorial from scratch and I'm capturing the scripts for adding features intelligently to a new project...  I was able to actually run this time with no errors but not 100% as expected.  Here are the issues I see (related to Storyshots/Jest):

With both Sample.test.js and storybook.test.js w/Storyshots enabled:
There's a syntax error:

Unexpected error while loading ./stories/Introduction.stories.mdx: SyntaxError: Cannot use import statement outside a module
at Object.warn (node_modules/@storybook/client-logger/dist/index.js:53:73)

There's a  warning:

console.warn
 was created without expected prop 'backgroundColor'
at new Button (src/stories/Button.svelte:162:12)
at getRenderedTree (node_modules/@storybook/addon-storyshots/dist/ts3.9/frameworks/svelte/renderTree.js:23:5)

And then there's this variant in behavior depending on Sample.test.js being present or not.
Here is the behavior with Sample.test.js present:

Here is the behavior with Sample.test.js absent (and just Storyshots and storybook.test.js as in the tutorial):
Note the deprecation warning as well...

(node:9928) DeprecationWarning: `storyFn` is deprecated and will be removed in Storybook 7.0.
https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#deprecated-storyfn
(Use node --trace-deprecation ... to show where the warning was created)

@etsiaDigital I've gone through the issue you pointed out. And it seems that it's a mismatch of versions. I tested it with the current state of the repo and I was able to check that it indeed leads to that issue. After bumping the package versions to the latest Storybook version (see #3) and running through the tutorial I get this once I reach the Snapshot testing section of that chapter.

The deprecation warning is going to follow us to 7.0 at least. I need to check with the current maintainer of Svelte version of Storybook and see what might be the issue there.
I followed the rest of the tutorial to the screen section and ran the command to generate and update the snapshots...As technically that chapter marks the end of the component development and test the results and I got this:

I'm currently doing some updates on the tutorial itself and plan on merging the pull request I've mentioned above today (Friday). What I would like from you if you're ok with it is to run the tutorial once more with the updated dependencies and see if the issue still persists and let me know.
Also one thing that sparked my interest in your screenshots, it seems that the addon it's trying to snapshot the mdx files when it shouldn't. Technically it should only capture snapshots for your own stories and not the example ones provided inside the stories folder. With that in mind, I would also like to ask you the following, did you update the path in .storybook/main.js as mentioned in the Simple Component chapter, under the Config section?
Stay safe

OK @jonniebigodes,
I'm rerunning from scratch starting here:
https://storybook.js.org/tutorials/intro-to-storybook/svelte/en/get-started/
When I run 'yarn storybook',  I get the suggestion to upgrade storybook so I do that.
I upgraded as suggested from SB 6.2.8 to 6.2.9 (npx sb@latest upgrade).
Hmmm. I've had to run this a couple of times to figure out what is wrong here when changing .storybook/main.js
Here what you start with and what is in the Tutorial:

Here's the original .storybook/main.js

Here's the Tutorial Config section

This is what I would recommend using in the tutorial for main.js Config:

And note that there is a typo on the pathname for .storybook/preview.js in the Config pathname above (it has a leading '..').
I got some odd behavior on my first pass through the tutorial (no stories found) and I'm not sure why.
The next code addition to Task.svelte is wrong (ok misleading).  Here's the tail end of what's currently in Task.svelte:

And here is the "add this to Task.svelte" in the Tutorial:

The green + add lines should include that last part of the  and + green the additional statements.  Personally, drop that + prefix stuff and just use green.  If you want to "delete" a line, make it commented out and green.
That finishes the Task stories and everything works as expected.
I then followed the automated testing instructions.
When I ran "yarn test" it failed:

So I added the following to the Jest property in package.json:
 "transformIgnorePatterns": ["node_modules/(?!(@storybook/svelte)/)"],
It seems I had to re-run 'yarn storybook', and my .storybook/main.js is like this:

module.exports = {
// The following stories: picks up the Examples as well as the 'components'
//  stories: ["../src//*.stories.js", "../src/components//.stories.js"],
// The following will just pick up stories in 'components'
stories: ["../src/components/**/.stories.js"],
addons: [
"@storybook/addon-actions",
"@storybook/addon-links",
"@storybook/addon-essentials",
"@storybook/addon-storyshots",
],
};

and THEN I got this result:

cheers.

Let me summarize the changes to the Svelte tutorial that would clean up the issues:

There needs to be a better path to the Tutorial.  The "Get Started" button on this page:  https://storybook.js.org/tutorials/intro-to-storybook/   should be a drop down allowing framework selection and then route accordingly.  You have to manually do that.

On this page: https://storybook.js.org/tutorials/intro-to-storybook/svelte/en/simple-component/  in the Config section I would simplify / correct the config files {.storybook/main.js, .storybook/preview.js} to be a cut/paste-able form. They should be:

.storybook/main.js   (note this is a simple edit of what is there already.. so it will be clear whats going on)

module.exports = {
  stories: [
    "../src/components/**/*.stories.js"],
  ],
  addons: [
    "@storybook/addon-links",
    "@storybook/addon-essentials",
    "@storybook/addon-actions",
    "@storybook/addon-storyshots",
  ],
};

.storybook/preview.js    (NOTE there was a typo here on the web page re: the preview.js path)

import "../src/index.css";
export const parameters = {
  actions: { argTypesRegex: "^on[A-Z].*" },
};

Same page, Build out the states section.  Change the src/components/Task.svelte file contents to be cut/paste-able.  If you wish to highlight the changes, do so with color only.  The delta indicated is wrong because it omits the // reactive declaration addition just above the markup.  That's the svelte part of the

@etsiaDigital thanks for the suggestions, I want to go over them so that we're on the same page here and don't accidentally introduce misconceptions:

There needs to be a better path to the Tutorial. The "Get Started" button on this page: https://storybook.js.org/tutorials/intro-to-storybook/ should be a drop down allowing framework selection and then route accordingly. You have to manually do that.

Regarding this item, if you could open up an issue in the tutorial's repo here, we'd appreciate it and would look into it.

.storybook/main.js (note this is a simple edit of what is there already.. so it will be clear whats going on)

Regarding this item, I have changed it locally on my end, and when the pull request is merged the pattern is fine-tuned. What's intended here is to focus on the components/stories the reader is working on. The sample stories that are provided with each Storybook installation are a good source of inspiration, but not applicable in terms of the tutorial. In a nutshell, we don't need them.
Also, by introducing the proposed change you've mentioned in your code snippet, we're actually introducing a misconception. The "@storybook/addon-storyshots"  doesn't need to be referenced in .storybook/main.js, it's one of the few ones that are at the lack of a better word independent of Storybook. Its main job is to pull in the stories you've created and run tests based on what you've set up in terms of stories.

.storybook/preview.js (NOTE there was a typo here on the web page re: the preview.js path)

Regarding this item, it's taken care of. The typo is fixed on changes I'm going to introduce in the tutorial.

Same page, Build out the states section. Change the src/components/Task.svelte file contents to be cut/paste-able. If you wish to highlight the changes, do so with color only. The delta indicated is wrong because it omits the // reactive declaration addition just above the markup. That's the svelte part of the

Ack
I just saw what was causing me some flakiness and is a problem:

.storybook/main.js

module.exports = {
  stories: [
    // NOTE the following used to be "../src/components/**/*.stories.js"  which is wrong
    //   It should be "../src/components/*.stories.js" or
    "../src/**/*.stories.js"],
  ],
  addons: [
    "@storybook/addon-links",
    "@storybook/addon-essentials",
    "@storybook/addon-actions",
  ],
};

When you include src/stories, you do get warnings about backgroundColor expected but missing.  The tests all pass:

Regarding the transformIgnorePatterns prop for Jest,  I've had a mixed experience with this.  At some earlier time in testing, I didn't need it.  The last pass, I got errors and needed it.  To be safe, and because it's reasonable in any event (in Svelte's case), I'd keep it in for reliability.
There has to be some inter-dependencies here that a new Storybook user won't have a clue about.  Your framework specific tutorial templates I've seen mentioned elsewhere will solve all of that and provide a predictable first experience.
As an aside, I like the broken out story checkmarks with test timing that you see here:

and here:

rather than a simple "PASS" of the test file (like src/storybook.test.js) like here:

I don't understand why sometimes running "yarn test" produces the itemized storyshot testing w/times vs just the PASS of a test file.
Sorry I missed that pathname problem.

No worries, i'm closing this issue as it's fixed. Stay safe


Adds a local copy of the npm packages for the validator

Description
Add a local copy of the NPM packages for the validator.
Related issues
Addresses [issue #].
Testing
Describe how this change was tested.
FHIR Team Checklist

Update the title of the PR to be succinct and less than 65 characters
Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
[ ] CI is green before merge
Review squash-merge requirements

Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)

/azp run

/azp run

/azp run


fix: hardcode default global search results

Note to the motivation: This replaces the search result for the empty input (which is queried by default when the search panel is opened) with the hard-coded data, and this saves the cost of algolia usage


Update to reflect archival / inactive status

There was discussion at the last CI working group meeting that this repo may be a red herring for people looking to understand / replicate parts of the ASWF CI.
@tykeal would you be able to take a pass mark this repo as archive / inactive?
Thanks
Daniel

@dheckenberg I've closed out all open PRs, locked down options on the repository to limit what can be done here and just changed the description to state it's been archived as of today. You may also notice that I have changed the repo name to be archived-ci-management. That should help folks realize what's what here!


docker-compose up created Postgres Account I can connect to without password

When trying to debug a different issue I came across something which looks like an issue to me (Correct me if I'm wrong and just have some big misunderstanding how authentication with psql works):

Create a Loraserver Setup with docker-compose up.
Things I changed in the docker file:

Remove the Mosquitto Container as I don't need that
Give each container a fixed IP Address
Things I changed in the Config Folder:
postgresql: Nothing
network-server: MQTT Connction Parameters

Expected Behavior: The docker-compose up command should create a psql database and user with the default credentials from the 001-init-chirpstack_ns.sh file:

    create role chirpstack_ns with login password 'chirpstack_ns';
    create database chirpstack_ns with owner chirpstack_ns;

Testing: I tried to connect to the Database from command line:
psql -h <IP_ADDRESS> -p 5432 -U chirpstack_ns -W

Actual Behavior: It asks me for a password, but even when I give the password "asdf" or anything else it connects successfully. Even when connected to psql I can connect to the database by giving a wrong password:

[...]$ psql -h <IP_ADDRESS> -p 5432 -U chirpstack_ns -W
Password for user chirpstack_ns:
psql (9.2.24, server 9.6.16)
WARNING: psql version 9.2, server version 9.6.
         Some psql features might not work.
Type "help" for help.

chirpstack_ns=> \connect chirpstack_ns
Password for user chirpstack_ns:
psql (9.2.24, server 9.6.16)
WARNING: psql version 9.2, server version 9.6.
         Some psql features might not work.
You are now connected to database "chirpstack_ns" as user "chirpstack_ns".

Somewhere in the back of my head I remember that Postgres authenticates by the unix user you use to login but I'm not 100% sure how it actually works to be honest. So is this one a bug or am I misunderstanding authentication in psql completely? It doesn't matter whether I try to authenticate directly from the host system or from within the Network Server Docker container, both work fine. Also if I change the Password in the network-server configuration file and do a docker-compose down and then a docker-compose up the Network Server can still connect to the Database.

This docker-compose.yml file is intended to demonstrate a working setup, it is not intended to be production ready. See in the README:

Note: Please use this docker-compose.yml file as a starting point for testing but keep in mind that for production usage it might need modifications.

It might be that there are some PostgreSQL flags that you can tweak in the postgresql image for authentication / authorization, but https://hub.docker.com/_/postgres would be a better source for this :-)


Feature request: VIRTUAL_HOST

if you look at https://github.com/BlackGlory/caddy-proxy you'll see that his package automatically regenerates a Caddyfile every time a new docker container gets fired. it looks at the environment variable, which contains the name we want the container to answer to, and maps appropriately.
it'd be great if this package could do this. reason: this package has 100+K pulls whilst BlackGlory's has 385 and gets no support. I can't make it work (I've already spent too much time trying) but I love the functionality
would it be difficult to do?

So just to be clear, this would have caddy act as a reverse proxy that can automatically detect new services?
That may be out of the scope of this project, but I'm sure there is some way that we can fit it in whether it's a separate branch, or a fork from this repo that I wouldn't mind maintaining.

yes, apparently https://github.com/jwilder/nginx-proxy does it and it was the inspiration for BlackGlory's image


05/31/2018 20:34 : Create Pull Request for branch master -> prTesting1_2018053120

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Can we have a python 3.7 build of this package

There is no code related issue here but rather a build request. I’m not sure where to place this request so please let me know if I need to submit the request somewhere else. Thanks a lot for making conda-forge great!

@ouyangw noarch builds have been available over a year now, please close the issue.

Sorry I haven't been following up, closing now. Thanks.


Double '$' characters in passwords are being truncated

I'm having issues where a password with 2 '$' characters in a row is getting truncated to just 1 -- to get it to work, I have to use 3 '$' characters in a row.
I'm using the VS Code extension on an M1 Mac, but it happened on an x86-64 PC also.
The HTTP request is a standard GET request using Basic Auth, with a password pulled from an httpYac environment variable in the VS Code settings file. So a request header like this:
Authorization: Basic {{username}}:{{password}}
Let me know if you need more details. Thank you.

@shieronymus-slingshot Yes, I'm afraid I need help to recreate it. It currently works correctly for me. I have the following test setup. The password is correctly determined and sent

auth.http

GET https://httpbin.org/basic-auth/{{user}}/{{password}} HTTP/1.1
Authorization: Basic {{user}} {{password}}

settings.json (VSCode Settings)

  "httpyac.environmentVariables": {
    "$shared": {
      "user": "doe",
      "password": "$$doe_secure"
    }
  }

I can also imagine a possible problem only in connection with {{$...}}. Could you please adapt my example for this reason, so that it doesn't work anymore?

Hmm, after playing with your new test case, I also am unable to replicate the problem. Sorry for the noise!
I think the issue must lie in the web/api setup I'm using.
Thanks for all the work on your tool.
-Seth

Actually, I don't think it's working... playing with the example some more I see an issue. If you just do the request as above, it does work. But if you deliberately cause it to fail, but using an invalid password in the Authentication line, you can see the issue.
For example, I have my settings like this:
    "httpyac.environmentVariables": {
        "$shared": {
            "user": "user",
            "password": "pa$$word"
        }
    }

But if I use the following request (with bad auth line):
###
GET https://httpbin.org/basic-auth/{{user}}/{{password}} HTTP/1.1
Authorization: Basic {{user}} bad_pa$$word

You get the following output (note the password in the GET line -- it's missing a '$' character):
GET https://httpbin.org/basic-auth/user/pa$word
accept-encoding: gzip, deflate, br
accept: */*
authorization: Basic dXNlcjpiYWRfcGEkJHdvcmQ=
user-agent: httpyac

HTTP/1.1 401 UNAUTHORIZED
access-control-allow-credentials: true
access-control-allow-origin: *
connection: close
content-length: 0
date: Fri, 28 Oct 2022 22:36:09 GMT
server: gunicorn/19.9.0
www-authenticate: Basic realm="Fake Realm"

Could the variable expansion be swallowing one of the '$' characters?

@shieronymus-slingshot I really love Javascript/ Typescript, but some Functions are really broken. Why does replace remove the $. Executing this statement in the dev tools returns pa$word
"{{password}}".replace("{{password}}", "pa$$word")

¯_(ツ)_/¯

I published v5.7.6 fixing issue with string.replace


Investigate /data-sources/:id GET allowing only Basic.

Context
@joshuagraber Reported the following to me:

GET requests to /data-source/:id are currently failing unless basic auth is passed. Is that intended?

It is not! Let's fix that!
Requirements

TODO

Tests

Add new tests to check that this functions in both BASIC and BEARER auth.

Docs

TODO

Open questions

TODO

False alarm! All gucci.


Flutter ScreenUtil().setSp(22) doesn't work after null safety upgrade to 5.0.0+2

We have used flutter_screenutil package in our flutter project. In current version of our application, this is how we set the fontsize, and it works fine.
fontSize: ScreenUtil().setSp(22)
After upgrading this package to 5.0.0+2, suddenly fontsize changed way too small. Upon debugging, we found that ScreenUtil().setSp(22) returns 4.5. That's what it does.
The way we used to initialize ScreenUtil in old version:
Widget build(BuildContext context) {
    ScreenUtil.init(context, allowFontScaling: false);

The way we initialize now after upgrading the package:
Widget build(BuildContext context) {
    return ScreenUtilInit(
          designSize: Size(1080, 1920),
          builder: () => Scaffold(...

Is there anything wrong or are we missing anything here? How can we get the fontsize back to normal?

The unit of Size(1080, 1920) is px, while the new version of the plug-in uses the size of dp.
It needs to be converted to the corresponding size

The unit of Size(1080, 1920) is px, while the new version of the plug-in uses the size of dp.
It needs to be converted to the corresponding size

Didn't work. If I change Size to anything else, it messes up the screen. It either makes the entire screen to big or too small. Do I have to go to all the places and change the Text font sizes?

Only the initialization is modified.
Just switch the units of the design to dp

https://github.com/OpenFlutter/flutter_screenutil/blob/959f18821039ac5162696f6714e11c0c9265703e/lib/screenutil.dart#L89
https://github.com/OpenFlutter/flutter_screenutil/blob/514454586ce9c87b5d371d4441b079e3eeedbad7/lib/screenutil.dart#L95
Starting from v4.0.2, scaleText is min(scaleWidth, scaleHeight), but before this version, scaleText is equal to scaleWidth, so I think this is why the font size looks strange on some devices The reason is because the font size may be adjusted to scaleHeight, but in most cases, we only need to adjust the font size to scaleWidth.
@lizhuoyuan

@debuggerx01
perhaps you're right.
The teacher said that I am not sure which of the two options is the best.


Create option for internal hosting

All our apps are hosted as AWS Lambdas, which is great for public facing apps, but is non-trivial to replicate for anyone looking to use the apps internally.
A more approachable solution would be to have a Docker compose file that ran everything in a self contained distribution, ready to be deployed with a single command.

A docker compose file is now provided to allow the workflow builder to run locally.


model: Add missing babel import

Fixes a failing test which reports _() is undefined.
I'm not sure how to fix the other tests, since the exception contains a lazy evaluated string. Which actually doesn't seem to work well. Since the exception string is:
{'number': <flask_babel.speaklater.LazyString object at 0x7efc06f3cc50>}

So maybe that should be changed to a non lazystring exception?

Changed the Exception so that they work. I would suggest renaming the Exceptions though to Class specific Exceptions instead of raising Python exceptions

The exceptions should work with lazy strings, I do that in another project. Simply using gettext instead of lazy_gettext is not a good idea as these exceptions are caught and the exception message is displayed to the user in the frontend and then translated according to the user's language setting.
Class specific exceptions could solve this as they could have methods to return the untranslated, fixed message (for unit tests) and to return the translated message (lazy string for the frontend). I will think about that.
Actually, I accidentally pushed commits which were not yet ready, I found on my laptop when sitting in the train to the easterhegg. Normally, there should have been git hooks to prevent that, but well... I then was frustrated and decided to enjoy the easterhegg instead. ;)

Hmm seems I didn't need to remove the lazystr stuff.


Expand on TOPIARY_LANGUAGE_DIR in the README

While installing Topiary, I found the explanation around TOPIARY_LANGUAGE_DIR in the README to a be a bit lacking (while it's an important point of the setup in order to make topiary correctly work with e.g. the Nickel language server)

What this environment variable is and why we need it isn't completely covered. In particular, is it compulsory, and what happens if we don't set it.
The text doesn't provide a sensible default/an example.
The README says that TOPIARY_LANGUAGE_DIR can be set at build time as well, but I'm not sure what it means. I couldn't find (by grepping) and build script or build-time computation referring to this environment variable. My first understanding of this information would be that if you set it a build time, the topiary build somehow picks it up and hardcodes the corresponding path into the binary. But that doesn't seem to be the case? What does the sentence mean, then?

This PR tries to clarify this aspect of the installation by explaining what this environment variable is, why we need it, what value should you use by default, and remove the part about build time (but feel free to re-introduce it if I didn't understand that correctly, which is very probable).

The compile-time magic is achieved by the option_env! macro, which is used here.
Does it not work? We rely on it in the Nix build.

@torhovland thanks for the heads up, I missed that macro call. PTAL at https://github.com/tweag/topiary/pull/424/commits/7df6822470c01dc8021c8efa49707faec8afff52

Looking good!


How to set password for the admin user

I successfully deployed magda using terraform.
But I coudn't find a setting for admin password, and  I can't access /auth/admin or /admin.
Is there a way to change password for admin user?

@monomoti We also have a spectrum chat room: https://spectrum.chat/magda
probably easier to discuss usage issue there.
The default installation only enabled SSO to data.gov.au CKAN.
If you already login to the system, there will be a Magda user created during the SSO process.
We don't have a tool to change a standard user to an admin user (We will create one dedicate tool for this in near future).
You can do it manually by following:

Instruction section 16: https://github.com/magda-io/magda-config#16-what-now
And FAQ: how-do-i-make-myself-an-admin
The current Admin area doesn't provide too much functions besides functions allows you to customise colour themes & home page. Most admin job actually need to complete via update Helm chart config value.

You probably want to play around by follow the instructions of section 16 first.

@t83714 I got it. I created a data.gov.au CKAN account and signed in my magda instance then changed "isAdmin" to TRUE in the data base.
Thank you for the quick reply.


The Discription of DisruptionBudge with non-percentage value is incorrect

Description
How can the docs be improved?
https://github.com/aws/karpenter-provider-aws/blob/main/website/content/en/v1.0/concepts/disruption.md#nodes

If the budget is configured with a percentage value, such as 20%, Karpenter will calculate the number of allowed disruptions as allowed_disruptions = roundup(total * percentage) - total_deleting - total_notready. If otherwise defined as a non-percentage value, Karpenter will simply subtract the number of nodes from the total (total - non_percentage_value) - total_deleting - total_notready. For multiple budgets in a NodePool, Karpenter will take the minimum value (most restrictive) of each of the budgets.

From the example offered below, the , It should be "If otherwise defined as a non-percentage value, Karpenter will simply use this number as budget :  non_percentage_value - total_deleting - total_notready"

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

I'm having some trouble understanding this as well... The semantic of the given formula is "the number of nodes I want to protect" while the example shows a different semantic "the number of nodes I accept to be disrupted", which is the same semantic of the percentage value formula.

As @jfmrm mentioned, I believe the problem is how the formula is defined in the docs. Instead of considering total - non_percentage_value as the total of allowed_disruptions it should be non_percentage_value directly


Actually shakes the whole window with screen shaker

I quite like it. Video:
https://share.cleanshot.com/rlJ11YJ0

I originally just wanted to shake the editing area, but shaking the entire window might be nice too. However, for me, it feels a bit too chaotic (though this plugin is already quite chaotic). Maybe we could control it with a setting option.
 The window shake is unstable; after shaking for a while, it drifts farther and farther from its original position. I don't think this was your intention, so it may need further optimization.

It works really well with a low intensity and short timeout. I agree that there are probably better ways to give the user the right kind of control over this, though.
And yes, I saw the drift too. I tried a few things to mitigate it but haven't fully stamped it out. Open to ideas!
Maybe instead of moving the window the opposite amount after the timeout, we remember where the original window was and return it to exactly that position..?

I'll fix the drift issue later.


Add a copy button to the theme code block？

After writing a blog, many old articles need to be checked back, and the copy function is often used.
I hope to add this function.

github hangs up, repeat submission


Fixed minor typos in prompts

Type of PR:
Bug fix

PR Description:
This PR addresses minor typographical errors in the prompts of two settings files. The changes are aimed at improving the clarity and correctness of the instructions provided in the prompts.

PR Main Files Walkthrough:

pr_agent/settings/pr_code_suggestions_prompts.toml: A repeated word 'provide' was removed from the prompt instructions.
pr_agent/settings/pr_reviewer_prompts.toml: A repeated word 'provide' was removed from the prompt instructions.

👍

/describe

@zmeir check out the new describe command, it changed the title and description of this PR.
/review

@zmeir check out the new describe command, it changed the title and description of this PR.

@okotek very cool! Although, the description for pr_agent/settings/pr_reviewer_prompts.toml is wrong... :(


keras.Model does not work with keras.Input that was created with tensor= kwarg.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 18.04 LTS
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 1.15.0-rc2
Python version: 3.7.4
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

current behavior
keras.Input and keras.InputLayer give the option to pass in a tf.placeholder through the argument tensor=None. When using the output of keras.Input(tensor=some_placeholder) as inputs to the functional keras.Model and subsequently calling model.predict(batch) on the newly created model an error occurs:
ValueError: ('Error when checking model input: expected no data, but got:', array([[0., 1.],
       [2., 3.],
       [4., 5.],
       [6., 7.],
       [8., 9.]]))

expected behavior
No error occurs and keras.Model correctly feeds the inputs through the graph.
Code to reproduce the issue
The following code breaks:
snippet 1
import tensorflow as tf
import tensorflow.keras as keras
import numpy as np

print("TF VERSION: ", tf.__version__)

ph = tf.placeholder(shape=[None,2], dtype=tf.float32)

# create input layer from a predefined tensorflow placeholder
inputs = keras.Input(tensor=ph)
# perform some operation
A = tf.constant([[0.5, 0],[0, 0.5]], dtype=tf.float32)
x = tf.linalg.matmul(inputs, A)
outputs = tf.reduce_sum(x, axis=1)

# make a model
model = keras.Model(inputs=inputs, outputs=outputs)

# try to feed a batch through the model
batch = np.linspace(0, 9, 10).reshape(5, 2)
out = model.predict(batch)

print(out)

Explanation
I already debugged through the keras code and I think I spotted the issue:
tesorflow/python/keras/engine/network.py, lines 342-352
snippet 2
for i, layer in enumerate(self._input_layers):
      self.input_names.append(layer.name)
      if layer.is_placeholder:
        self._feed_input_names.append(layer.name)
        # Use batch_input_shape here because non-eager composite tensors may not
        # have a shape attribute that's meaningful (sparse, for instance, has
        # a tensor that's non-constant and needs to be fed). This means that
        # input layers that create placeholders will need to have the
        # batch_input_shape attr to allow for input shape validation.
        self._feed_input_shapes.append(layer._batch_input_shape)
        self._feed_inputs.append(layer.input)

snippet 2 is taken from the Network constructor. As can be seen, only tensors coming from layers with is_placeholder set to true are added to the _feed_inputs array.
In out case, this array is empty, because our InputLayer that was created from a tf.placeholder has is_placeholder set to false.
Looking at the constructor code of InputLayer we can see why this is the case:
tensorflow/python/keras/engine/input_layer.py, lines 115 - 138
snippet 3
    if input_tensor is None:
      if input_shape is not None:
        batch_input_shape = (batch_size,) + tuple(input_shape)
      else:
        batch_input_shape = None
      graph = backend.get_graph()
      with graph.as_default():
        input_tensor = backend.placeholder(
            shape=batch_input_shape,
            dtype=dtype,
            name=self.name,
            sparse=sparse,
            ragged=ragged)

      self.is_placeholder = True
      self._batch_input_shape = batch_input_shape
    else:
      if not tf_utils.is_symbolic_tensor(input_tensor):
        raise ValueError('You should not pass an EagerTensor to `Input`. '
                         'For example, instead of creating an '
                         'InputLayer, you should instantiate your model and '
                         'directly call it on your input.')
      self.is_placeholder = False
      self._batch_input_shape = tuple(input_tensor.shape.as_list())

input_tensor has the value from the tensor= argument. In our case, this holds the placeholder we passed to Input(tensor=ph). Since it is not None self.is_placeholder = False is run in the else-case.
This subsequently results in the layer not being added to the _feed_inputs of the model which then does not expect any inputs to the predict method.
The issue can be worked around by manually setting the is_placeholder field of our input layer.
snippet 4
inputs._keras_history[0].is_placeholder = True

Adding this line of code just below line 10 of snippet 1 resolves the error.
Fixed code:
snippet 5
import tensorflow as tf
import tensorflow.keras as keras
import numpy as np

print("TF VERSION: ", tf.__version__)

ph = tf.placeholder(shape=[None,2], dtype=tf.float32)

# create input layer from a predefined tensorflow placeholder
inputs = keras.Input(tensor=ph)
inputs._keras_history[0].is_placeholder=True
# perform some operation
A = tf.constant([[0.5, 0],[0, 0.5]], dtype=tf.float32)
x = tf.linalg.matmul(inputs, A)
outputs = tf.reduce_sum(x, axis=1)

# make a model
model = keras.Model(inputs=inputs, outputs=outputs)

# try to feed a batch through the model
batch = np.linspace(0, 9, 10).reshape(5, 2)
out = model.predict(batch)

print(out)

Output:
TF VERSION:  1.15.0-rc2
[0.5 2.5 4.5 6.5 8.5]

Since I can not think of any reason, why an InputLayer created from a placeholder should have is_placeholder=False I think this issue can be resolved by removing the respective line of code.

I have tried on colab with TF version 1.15 and was able to reproduce the issue.Please, find the gist here.Thanks!

@7Z0nE Thanks for the issue!
Placeholders are removed in TF2, instead you can write the code like this:
import tensorflow as tf
import tensorflow.keras as keras
import numpy as np

print("TF VERSION: ", tf.__version__)

# create input layer from a predefined tensorflow placeholder
inputs = keras.Input(shape=[2,], dtype=tf.float32)
# perform some operation
A = tf.constant([[0.5, 0],[0, 0.5]], dtype=tf.float32)
x = tf.linalg.matmul(inputs, A)
outputs = tf.reduce_sum(x, axis=1)

# make a model
model = keras.Model(inputs=inputs, outputs=outputs)

# try to feed a batch through the model
batch = np.linspace(0, 9, 10).reshape(5, 2)
out = model.predict(batch)

print(out)

Unfortunately we are not able to backport fixes like this to earlier version.
Please try with the latest tf-nightly pip install -U tf-nightly


Issue with k8s.io/docs/tutorials/kubernetes-basics/create-cluster/cluster-interactive/

This is a Bug Report

Problem:
IT CAN NOT WORK.
Proposed Solution:
Page to Update:
https://kubernetes.io/...

Hi @LinziWang Can you please provide details in the issue you are seeing?

/assign @BenHall l

/triage needs-information

pls feel free to open with actionable issue details or file a new one.


undici has socket error

Before you report a bug ...

[x] I have checked that I am on the latest version of discord-player-youtubei
[x] I have checked existing issues to see if this is a duplicate report

Description of the bug
Undici has undefined socket, which crashes programs. The error usually shows up near startup of the bot.
/home/X/Pytech/node_modules/undici/lib/core/connect.js:224
if(Array.isArray(socket.autoSelectFamilyAttemptedAddresses)) {

TypeError: Cannot read properties of undefined (reading 'autoSelectFamilyAttemptedAddresses')
at onConnectTimeout (/home/X/Pytech/node_modules/undici/lib/core/connect.js:224:28)

Steps to reproduce

Run program
Wait a few seconds
Program should error

Versioning
discord-player: 6.7.1
node.js: v19.8.1
discord-player-youtubei: 1.3.5

Hey! Thanks for the issue but be sure that the correct syntax for the tick boxes are [x]

Please try again by installing it directly via GitHub by using npm or pnpm.

I will try this once I get the chance to.

Got some new information. It seems that the error only shows up when it's being hosted from the terminal of a cloud VM (like oracle cloud) or from a raspberry pi. Running the program using pm2 as a manager doesn't give that error, nor does it show up from my self-hosted visual studio code terminal.

Could you check the relative versions of nodejs on those hosts? This error is coming from undici and if you're not using IP rotation, it should not error at all.

Both cloud VM and the raspberry pi are running on node v19.8.1, as is my VSC terminal. I was running the bot on heroku previously and it didnt have any issues either, also running node v19.8.1.

Yeah installing directly from github should fix it. I just implemented a check to see if an IP is resolved from the rotator module. If not, it should just continue normally.

I am closing this due to inactivity. Reopen if needed!


Add incense timer for PohPlugin

Messed up that original PR, here's a clean version.
this would add a timer using the timer infobox (similarly to bosstimers).
adds 2 options in the config

enable burner timer
duration (s)

duration as the time isn't thát consistent regardless of firemaking level, thus one could set a personal bottom level

I would rather see this rendered above the burners ingame instead of an infobox, since there are two of them.


publish 1.0.0-rc10 on pub?

like title

rc10 is published on pub, pub is just not ordering rc10 as > rc9 so you have to depend specifically on rc10 and not ^...-rc10.
https://pub.dev/packages/flame/versions/1.0.0-rc10


fix: adding default property to schema message.

Adding default property so that it can be passed over via schema message. This can be used by the target validators to populate records.

:books: Documentation preview :books:: https://meltano-sdk--2015.org.readthedocs.build/en/2015/

https://github.com/meltano/sdk/issues/1998#issuecomment-1757702007
a bit of explanation here :)


appendHTML

selection.append but parsing and appending HTML/SVG strings. I use it when I want to generate a hierarchy of nodes, for example when using an inline template.

I added an appendSVG method for adding elements with the right namespace


Perfect Forward Secrecy Support

Telegram supports Perfect Forward Secrecy (PFS).
To achieve this:

Ability to encrypt with MTProto v.1.0 needs to be added to Encryption.cs
CreateAuthorizationKey https://github.com/wiz0u/WTelegramClient/blob/e7ec282ac10afe4769b2af2d383efdf201af1348/src/Encryption.cs#L29 should be updated to support creation of a temp_auth_key. Then we can call this twice to create a temporary authorization key as we are connecting.
New fields need to be added to DCSession as well to hold the TempAuthKey data https://github.com/wiz0u/WTelegramClient/blob/e7ec282ac10afe4769b2af2d383efdf201af1348/src/Session.cs#L20
A new BindTempAuthKey method needs to be created that constructs the binding message and sends it. This method could be called in DoConnectAsync https://github.com/wiz0u/WTelegramClient/blob/e7ec282ac10afe4769b2af2d383efdf201af1348/src/Client.cs#L724
SendAsync https://github.com/wiz0u/WTelegramClient/blob/e7ec282ac10afe4769b2af2d383efdf201af1348/src/Client.cs#L1175 should accept msgId as a parameter as the binding message needs to contain the same msgId.
A recurring task could be created to renew the temp_auth_key. Before sending a request client can also check the expires_at timestamp and renew the temp_auth_key for the cases the aforementioned task fails?
Client needs to handle the cases where temp_auth_key expires before the expires_at is reached.

I have come across this as I was writing the integration tests for my Telegram Server. I can work on this if you assign this issue to me.

Yeah I wasn't keen on implementing PFS for cloud chats as it is not required and its implementation is really weird (MTProto1, several exceptional message encoding not respecting standards imposed by the rest of the protocol, unclear goals) and could kinda mess-up the clean implementation of the protocol I have here.
You may want to look at commit 3fe9002f2e39a88832b5a6d588320a2d5bc6a528 where I removed support for MTProto1 in this library, if you want to put some of it back in.
Now, honestly I'm not convinced it is useful for this library and its users to implement it, but I understand you would find it useful in order to test your server-side implementation as you also need to support official clients using PFS.
I think for now I will pass on it and let you develop it in a fork, then maybe I will later take a look at what you did and decide what I wanna do (I will credit you of course if I decide to merge your implementation)

I understand. I also acknowledge that it might introduce some instabilities if not thoroughly tested. I will develop it in my fork and use your implementation of MTProto v.0.1 and in case you decide to merge it in the future. I will also try to introduce as little change as possible. For now we can close this issue as not planned I guess.

New fields need to be added to DCSession as well to hold the TempAuthKey data

You sure about that? because the specs seems to encourage temp keys to remain in RAM, not being stored for long-term use.
(but maybe I didn't dive enough into that documentation to fully grasp the ins and outs)

The spec says: 'For additional security, the client can store the temporary authorization key in RAM only and never save it in persistent storage.' I assumed it was optional but I may have misinterpreted it.
The official tdlib has the following AuthData structure that does not persist the said keys.
private:
  bool use_pfs_ = true;
  AuthKey main_auth_key_;
  AuthKey tmp_auth_key_;
  bool server_time_difference_was_updated_ = false;
  double server_time_difference_ = 0;
  ServerSalt server_salt_;
  int64 last_message_id_ = 0;
  int32 seq_no_ = 0;
  std::string header_;
  uint64 session_id_ = 0;

  std::vector<ServerSalt> future_salts_;

  MessageIdDuplicateChecker<1000> duplicate_checker_;
  MessageIdDuplicateChecker<1000> updates_duplicate_checker_;
  MessageIdDuplicateChecker<100> updates_duplicate_rechecker_;

  void update_salt(double now);

It also has the AuthDataShared structure that persists the main auth_key.
void set_auth_key(const mtproto::AuthKey &auth_key) final {
    G()->td_db()->get_binlog_pmc()->set(auth_key_key(), serialize(auth_key));
    log_auth_key(auth_key);

    notify();
}

So the official implementation also does not persist the temp_auth_key at the first look. In this case the best course of action would be to simply ignoring those properties with the [JsonIgnore] attribute.

internal fields in DCSession are not serialized

So I implemented the PFS support and it passes my initial tests. But probably more tests are needed.
https://github.com/wiz0u/WTelegramClient/compare/master...aykutalparslan:WTelegramClient:pfs_support


Fix core-overlay freezing. Allow users to add multiple Cloud friends.

Fixes: https://github.com/uProxy/uproxy/issues/2076
The core-overlay problem was discussed here: https://github.com/Polymer/core-overlay/issues/37 and I saw someone had created a patch. I forked that, published it, and now bower uses that instead of the stock core-overlay code. I think this should fix our core-overlay problem forever (forever!)
Also, @trevj caught that we couldn't add multiple cloud friends. This was happening because I tried to login each time we entered a cloud invite. I fixed that, but we still see the confirmation ("you've entered an experimental code...") each time. I left that in because I thought it might be helpful, but it's easy to take out if that's better.

FYI, repeated confirmations shouldn't be a big issue for now - we're testing with a small org that just needs one server.

:+1:

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

bower.json, line 17 [r1] (raw file):
If we are allowed to have comments in this file it might be good to add a comment here explaining why we are using this.   Otherwise don't worry about it

Comments from the review on Reviewable.io

Ah, apparently can't add comments to the JSON file, but I tried to document better in the release notes: https://github.com/lucyhe/core-overlay/releases/tag/0.1.0


haskellPackages.yarn-lock: remove unnecessary override

https://hackage.haskell.org/package/yarn-lock-0.6.3/changelog

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build haskellPackages.yarn-lock

Looks like this builds, thanks for following up with this!


Development: Cleanup control flow in client code

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Client

[x] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
[x] I followed the coding and design guidelines.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[x] I documented the TypeScript code using JSDoc style.
[ ] I added multiple screenshots/screencasts of my UI changes.
[x] I translated all newly inserted strings into English and German.

Motivation and Context
The auto migrator did only syntactically migrate, but leaves semantics and readability behind. This PR refactors a small portion of auto-migrated control flow statements.
Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress
Performance Review

[x] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance

Code Review

[x] Code Review 1
[x] Code Review 2

Summary by CodeRabbit

Enhancements

Improved logic for rendering table rows and pagination in the Audits section.
Enhanced display formatting for garbage collector metrics.
Refined the system notification management interface for better clarity.
Updated user management controls to better reflect user activation status.
Adjusted assessment header to conditionally display information based on test run status.
Streamlined the display of complaints in the list of complaints section.
Optimized loading state indicators across various components for a smoother user experience.
Enhanced conditional rendering logic in the student exams and assessment dashboard sections.
Improved visual representation of tree structures in the code editor.
Refined the display of exercise hints and scores for a more intuitive user interface.
Updated the course discussion component to handle loading states more effectively.
Polished the course registration modal to improve user interaction during loading states.
Enhanced consistency checks and loading indicators throughout the application for better performance feedback.

Bug Fixes

Fixed issues with conditional rendering that could affect the visibility of certain elements based on user permissions and system states.

This PR is too open for a long time and will be closed due to inactivity


Compatible with KubeJS

Could the items to be tuned with kubejs script?
I am a modpack developer. It would be good if this mod support KubeJS so that I can use the /. +/ format from JavaScript which is a lot faster in modifying the level required for each tools.
For example, if i want players to use spartanweaponry iron items only after lv10, i could write
"/spartanweaponry:. +_iron/ gathering:10"
I am not familiar with toml file. If toml file support this kind of format, could you give me an example on how to use it?
Thanks a lot!

TOML does not support syntax like that afaik. Apart from that, I'll consider KubeJS support, but don't count on it.


ngrok premium is required by the command in A01

Student provided feedback - please check and fix

Fixed in PR #47


HOTT-2641 Override existing tree methods

Jira link
HOTT-2641
What?
I have added/removed/altered:

[x] Added a feature flag to enable use of NestedSet for existing code paths
[x] Added overrides for different goods nomenclature types to use nested set for existing hierarchy methods

Why?
I am doing this because:

So we can turn this feature on and off
It provides a starting point for integrating the nested set work

Deployment risks (optional)

With the flag off, low,
With the flag on, high since it changes our queries used for the hierarchy

Note: the time machine fix is cherry-picked back into the relationships branch where it was introduced and will go away when the intermediate branches get rebased.

Concluded this was too likely to introduce N+1s and since most code areas have been manually converted to nested set


[BACK-2408] Add documentation for the token exchange flow

This PR documents for the token exchange flow and intentionally omits extensive docs for other OpenID Connect flows. We should probably document those as well, but the area is quite big so we can do it gradually over time

Oh, one more thing: this new auth.v2.yaml file needs to be added to the templates/openapi-merge.jsonnet file so that it's included in the published docs.


improve status

Hello,
Looks like you're going to be our first time contributor pretty soon :)
Few notes:
Cosmetic
I played a little bit with the code you sent, and it seemed the output could be improved a tiny bit.
* foo               dm/my-branch ↑3 commits ↓7 commits dirty
* baz               master  dirty

Note how:

nothing at all is displayed when the branch is up-to-date (no need for the '==' sign)
the 'diverged' symbole is no longer required (it's redondant with the number of behind and ahead commits)
extra space between the arrows and the number of commits has been trimmed

It looks to me a more compact output is more readable.
Implementation

It would be nice to add least add a test for the new behavior
I found a few ways to improve the clarity of the code, see my other comments

I have just addressed most of your comments, I ll try to improve the corresponding test before the end of the week

@dmerejkowsky I have started the refactoring, it's coming along! As you mentioned, I would appreciate, if you could have a look and give some help :smile:


Add User's REP balance into the market creation, Reporting sections, and disputing form

Market Creation. Across all steps
Page: Market Creation 4
https://www.figma.com/file/csVtbWhGCAYe3nVe2LI1UEPM/Timezone-issue?node-id=181%3A965

Use the same component across the following sections
Reporting: Dispute

Reporting: Markets

Reporting: Resolved

Dispute Form

Report Form

Notice that if the market is Open Reporting and the user isn't the Designated Reporter no need to show the user's REP balance.

@matt-bullock it's added...plz rvw make sure it matches design and close

Can you align it to the right of that section on market creation:


CI: TestGetIdentity/Duplicated_identity failure

Description
Failure link https://app.travis-ci.com/github/cilium/cilium/jobs/594047847, this issue is replicated locally as well.
=== RUN   TestGetIdentity/Duplicated_identity
    identity_test.go:218: Expected key 10, got 11
    identity_test.go:218: Expected key 10, got 11
    --- FAIL: TestGetIdentity/Duplicated_identity (0.03s)

From the first look, the test expectation is to get key 10, however, the underlying get method didn't guarantee any particular order while retrieving element from map.
https://github.com/cilium/cilium/blob/master/pkg/k8s/identitybackend/identity.go#L219-L242

#23229 traces the cause of this to https://github.com/cilium/cilium/pull/23064 which was not marked for backport to 1.13, so it looks like this does not affect 1.13 at this time.

it looks like this does not affect 1.13 at this time.

thanks, I overlooked on this :+1:


feat: redo nativeTags

close #3148
This PR is a rollback of #2685.
After confirmation, #3259 does not solve #3148. It seems that it is necessary to generate more efficient virtual code through the nativeTags of hard code, instead of entrusting the work of differentiating IntrinsicElements to TS.
This also fixed the regression introduced by #3259.
cc @ModyQyW

Thanks! I will check it later. Currently, I am stuck in company issues and having bad days 😅


Inbox or Gmail?

I thought this issue clarified that support would be given to continue the inbox interface using the gmail API?
https://github.com/denysdovhan/inboxer/issues/77
I've just built the mac version of the newest release and it's gmail, not inbox. Do I have it backwards?

You're right, the original plan laid out in issue #77 was to re-implement Inbox features on top of Gmail. As mentioned by @denysdovhan it will be a hard task and as far as I know there has been no progress on that front. Right now we are faced with a hard deadline at the end of March 2019 so we had to act.
I use Inboxer on a daily basis and would like to continue using it after the end of March even it means vanilla Gmail, that's why I adapted it to work with Gmail. We should continue working towards the goal of re-implementing Inboxer features, consider release 1.3.0 as a first step in that direction.
I'm gonna look into back porting some of the new features in 1.3.0 back to 1.2.1 and have another maintenance release that supports Inbox.

Ah that's too bad, I understand tho. I was so excited about being able to
continue using inbox that I made a donation yesterday. Hopefully it can
still do a little to support that long term goal.
On Sun, Mar 10, 2019 at 5:40 PM jmarino<EMAIL_ADDRESS>wrote:

You're right, the original plan laid out in issue #77
https://github.com/denysdovhan/inboxer/issues/77 was to re-implement
Inbox features on top of Gmail. As mentioned by @denysdovhan
https://github.com/denysdovhan it will be a hard task and as far as I
know there has been no progress on that front. Right now we are faced with
a hard deadline at the end of March 2019 so we had to act.
I use Inboxer on a daily basis and would like to continue using it after
the end of March even it means vanilla Gmail, that's why I adapted it to
work with Gmail. We should continue working towards the goal of
re-implementing Inboxer features, consider release 1.3.0 as a first step in
that direction.
I'm gonna look into back porting some of the new features in 1.3.0 back to
1.2.1 and have another maintenance release that supports Inbox.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/denysdovhan/inboxer/issues/93#issuecomment-471322028,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA611J6eid7Regrru3mj9XiZqhYSufIYks5vVTWBgaJpZM4bnWrG
.


Change code style:  prefix_in --> prefixIn, suffix_in --> suffixIn

Codecov Report

Merging #169 into develop will decrease coverage by 0.03%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop     #169      +/-   ##
===========================================
- Coverage    52.85%   52.82%   -0.04%
===========================================
  Files          217      217
  Lines        21579    21579
===========================================
- Hits         11406    11399       -7
- Misses        8883     8887       +4
- Partials      1290     1293       +3

Impacted Files
Coverage Δ

bfe_basic/condition/primitive.go
43.76% <0%> (ø)
:arrow_up:

bfe_spdy/server_write_sched.go
78.46% <0%> (-1.54%)
:arrow_down:

bfe_spdy/server_conn.go
78.09% <0%> (-0.45%)
:arrow_down:

bfe_http2/server.go
71.5% <0%> (-0.33%)
:arrow_down:

bfe_websocket/server_conn.go
75% <0%> (+0.75%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dde9f7...40bb31c. Read the comment docs.


WRP-15613: [TransferList POC] Add documentation

Enact-DCO-1.0-Signed-off-by: Adrian Cocoara<EMAIL_ADDRESS>Checklist

[x] I have read and understand the contribution guide
[ ] A CHANGELOG entry is included
[ ] At least one test case is included for this feature or bug fix
[x] Documentation was added or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added
Added helpful comments through the code
Resolution
Additional Considerations
Links
WRP-15613
Comments

Please also try to add comments to actions happening inside the functions.
I'm just pointing an example but there are many others:


Notifications showing in account selector, when none are unread

I have two Teams accounts, both use my online AD account as the login email address, the account drop-down in the top right often (most of the time) shows a red circle with a number in, presumably the number of unread items it thinks is in one (or both? or the other?) account(s), but on using the dropdown and switching to the other account I can see no notifications, and nothing unread in Activity.

@richardacre thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.
@officedocsbot close

@officedocsbot close

I don't understand, that page asks me for a country then gives me a phone number, where do I report the bug?


[BACKLOG-21139] Add new "static base" assembly with minimal files for worker nodes

@pentaho/rogueone @pentaho/x-wing
Jira: https://jira.pentaho.com/browse/BACKLOG-21136
This PR adds a smaller version of the static assembly called static-base (which only has the files required to run pan/kitchen on linux). This is needed for the pdi-ee-client-light assembly that will be used for worker nodes.
The static assembly was changed to build off of the static-base assembly to hopefully simplify the maintenance of the pdi-ee-client-light assembly.
This PR is related to https://github.com/pentaho/pentaho-ee/pull/1221

Build Skipped
:white_check_mark: There was nothing to build. The changes are probably excluded by the build rules. If this is an error, please contact your system administrator.

Build Skipped
:white_check_mark: There was nothing to build. The changes are probably excluded by the build rules. If this is an error, please contact your system administrator.


support INPUT prompts

In spite of the BASICODE conventions forbidding INPUT prompts, apparently some programs use them, so this implementation should offer the functionality as well.

Fixed in branch bc3-test.


fix: Langfuse and StatefulClient clients return incorrect trace url

Added project id in trace url returned by Langfuse client and StatefulClient
Closes https://github.com/langfuse/langfuse/issues/650

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @HugoMichard, thanks for the contribution. Does this fix a problem that you have?
The /traces/{traceId} route is redirected to the correct /project/{projectId}/traces/{traceId} route to not require a synchronous call to the Langfuse API to get the trace url. See implementation here: https://github.com/langfuse/langfuse/blob/main/src/pages/trace/[traceId].tsx


Support for server side apply

First take on server side apply feature  (https://github.com/vmware-tanzu/carvel-kapp/issues/388) to collect early feedback.
Some highlights:

user provided manifest + some kapp generated annotations is what we are submitting to K8S via PATCH request.
diff calculation is at the core of kapp code paths, so I had to approximate it by diffing existing instances against dry run SSA result. This required calls to K8S much earlier in the code than it was previously, which required some plumbing
because we have to make dry run call, there is a new  NewChangeSSA change factory
E2E test runner now supports KAPP_E2E_SSA=1 env var value. When set, --ssa-enabled flag is added to kapp invocation allowing same tests to be run in SSA mode. Tests with rebasing are skipped in SSA mode.
To make debugging e2e cases easier I created embeddable runner, which runs kapps *corbra.Command in the testing process. It is not a full replacement for a kapp command execution, but greatly helped developing this feature as most interesting scenarios come up in e2e and not   unit testing.

Unimplemented:

[x] SSA conflict force flag. It is present, but not used anywhere.
[x] conflicting CLI flags are ignored in favour of SSA feature. I think there should be  a clear error message if conflicting flags are specificed, like --diff-against-last-applied.

Yet untested (unless there is an existing E2E test covering it):

[ ] how changes to namespace are handled
[ ] how changes to apiVersion are handled (apps/v1beta1 -> apps/v1)

Features deliberately left outside of this PR:

Ownership transfer as described in docs.  There might be situations where user might want to give up ownership of certain fields after initial creation.  kapp could assist with it.
Fine grained force conflict resolution. Right now it is all or nothing. There is no fine grained force option in the kubernetes, so it has to be implemented as 2 separate operations: non-SSA patch for conflicting fields + SSA for the rest. I'll create an issue with more detailed proposal once SSA work is merged

Thanks for the draft PR @redbaron !
Will definitely go through the changes to get an idea of what's going on.

Hm, all tests are passing locally on Docker Desktop managed 1.21 kubernetes cluster, but  TestSSAUpdateSimple  fails in CI.

Looks like it is just the new test. Let me take a swing at it as well 🤔

(will also circle back in beginning of Jan, happy holidays!)

your company's legal contact did not review your signed contributor license agreement within the 14 day limit.

I don't understand, which company? Which address your bot contacted? I am contributing from my personal account.

Hm, all tests are passing locally on Docker Desktop managed 1.21 kubernetes cluster, but TestSSAUpdateSimple fails in CI.

The tests are running on k8s v1.16 and v1.22, and I think the behaviour is a bit different on those.
For v1.22 you might wanna remove the spec.selector field in kubectlChange (I haven't looked at it in detail so I am not sure how that will effect the e2e test).

OK, it reached the stage where I'd like to propose it for a merge.
I added option to run E2E tests with SSA enabled and  test suite now passes with SSA on my 1.21 K8S,  except for tests with rebasing. I'll go through diff and add notes on  parts worth paying attention to.
TestIgnoreFailingAPIServices fails for me locally even on master, because error message text differs from what test expects.
There is a missing test for --ssa-force option, I'll add it in due course, but otherwise I consider initial implementation complete.
I'll also update  PR message to reflect current state shortly.
/cc @cppforlife

cool cool. ill do a deep dive today/tomorrow on this @redbaron. other folks will also take a look...

(still reading through the code... hoping to be done tomorrow)

Thanks for a quick review, I'll make requested changes shortly

@redbaron lmk, when to take a look at the PR again.

Hey guys,
Could you give me a brief update on the topic? Are there still plans to support server-side-apply or will there be no further work on this topic for the time being?
I'm only asking because I use Carvel in combination with other tools that would support SSA (e.g. Operator SDK).

Hi @ebma16! Unfortunately the maintainers don't have the bandwidth to work on this at the moment, and I am not sure when we will be able to prioritise it. We can definitely prioritise a review if you would be interested in submitting a PR or continuing on this one.
kapp rebase rules should still work well with other tools that support SSA. Could you share the specific problem that you are facing?

Hi @praveenrewar,
thank's for the update and your quick response!
At the moment I have no problems with the kapp rebase rules. We are still in an early phase of the project and I just did a small test for the interaction between the Java-Operator-SDK (using SSA) and the kapp rebase rules (without SSA). So far I could not find any problems and everything worked. I was just curious about the current status when I read this thread ;)
I will continue with this constellation (kapp without SSA and other tools using SSA). If I notice any problems, I will definitely let you know and continue this thread!

Sure, keep us updated. Happy to chat on carvel slack channel too if you need help with anything.


Remove plugin.ResultType due to confusion/lack of need

What this PR does / why we need it:
There was redundancy between three different fields of the plugin:
name, resultType, and resultFormat. The first two existed prior
to the third and were the same in almost every case, leading
to confusion about why there were two different values at all.
The problem with this is that the aggregator server would be primarily
concerned with resultType and use it through its code when referring
to plugins. As a result, the plugin name, despite having the more
intuitive title, was actually almost never used.
This all led to a few confusing situations:

If a plugin name != resultType it was unclear on which query/screen
they would see which value
Uniqueness was only enforced on resultType and not plugin name, leading
to the confusing requirement that they provide a name but not using it often
and it not being required to be unique
The plugin name/type were almost always 100% the same even though their
names don't imply that, whereas plugin type/format were never meant to be
related despite sounding like similar ideas.

By removing the plugin result type (and relying on plugin name for the
unique identifier) we are left with two fields (name and format) which
seem much more clear and unique.
Internally, the aggregator server still uses the "ResultType" naming
convention in its own types since those types did not have the 'Name'
field to conflict with. In addition, that is not really a user-facing
field whereas plugin definitions (where type/name both exist) are.
Which issue(s) this PR fixes
Fixes #830
Special notes for your reviewer:
Somewhat WIP; I put this together quickly and want to review it myself before merging too.
Release note:
Plugin definitions (e.g. output from `sonobuoy gen plugin` and input for the `--plugin` flag) no longer have a `--plugin-type` field. This was usually identical to the `plugin-name` field and only led to confusing users or causing issues if those values were not identical.

I want to run some manual tests, but I am pleasantly surprised by how easy this turned out to be and how simple a review this looks to be 💯

Codecov Report

Merging #857 into master will increase coverage by 0.06%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
+ Coverage   46.86%   46.93%   +0.06%
==========================================
  Files          75       75
  Lines        4869     4860       -9
==========================================
- Hits         2282     2281       -1
+ Misses       2455     2449       -6
+ Partials      132      130       -2

Impacted Files
Coverage Δ

pkg/plugin/manifest/manifest.go
3.03% <ø> (+0.08%)
:arrow_up:

pkg/client/gen.go
83.85% <ø> (-0.15%)
:arrow_down:

cmd/sonobuoy/app/gen_plugin_def.go
91.42% <ø> (-0.24%)
:arrow_down:

pkg/discovery/discovery.go
7.93% <0%> (ø)
:arrow_up:

pkg/plugin/aggregation/run.go
25.83% <100%> (ø)
:arrow_up:

pkg/plugin/driver/base.go
59.61% <100%> (-0.52%)
:arrow_down:

pkg/plugin/driver/job/job.go
73.77% <80%> (-0.22%)
:arrow_down:

pkg/plugin/driver/daemonset/daemonset.go
65.82% <80%> (-0.22%)
:arrow_down:

cmd/sonobuoy/app/status.go
59.43% <0%> (+1.88%)
:arrow_up:

pkg/plugin/aggregation/aggregator.go
83.2% <0%> (+4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a268401...791e631. Read the comment docs.

Nice to see this removed. I'm assuming that for any existing plugins, the result-type field will just be ignored?

Right; if someone has a saved plugin def it will be ignored and in most cases the value is identical to the plugin-name which will remain.

On Aug 23, 2019, at 4:42 PM, Bridget McErlean<EMAIL_ADDRESS>wrote:
Nice to see this removed. I'm assuming that for any existing plugins, the result-type field will just be ignored?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

👍 I'll still do a few more tests but I wanted to see where approval was too. I see that I put WIP remarks in the notes so I realize now why you didnt finalize your review.

Just the known pid issue; rerunning ci for safety then merging. Manual testing went well. I used a mix of plugins which provided the old field and some which did not. Was able to run and process results as expected for all of them.


publish image on new tag

Describe the pull request:

[x] New feature
[x] Build system change

Pull request long description:

This will bump the patch number on each PR merge unless the commit message contains #none.
In order to bump the major or minor version add #major or #minor to the PR message.
#major -> v1.2.3 > 2.0.0
#minor -> v1.2.3 > 1.3.0
If a new tag is created the second part of the action will build an docker image and publish it to the GithHub Container Registry.
The new image can the be pulled by calling docker pull ghcr.io/neicnordic/sda-doa:latest
Changes made:

Action to automatically bump the tag on push to master or PR merge.
Builds new Docker image and published to GHCR when tag changes.
pushes to docker hub as well

Related issues:

Additional information:

#none Do not bump the version for this PR
Release note:

Documentation change:

Mentions:

@jbygdell who did the original code for this

merging, as positive reviews are in and this does not affect functionality, just the ci build.


dev: add zsh to the development container

Description
Add zsh to the development container.

Thanks.
A piece of advice : If you are already using a development container, the change will NOT be applied automatically, you need to run the VS code "> Remote-Containers: Rebuild container" command for the change to take effect (this will also clear any change/installation done inside the container).


Stop assigning issues to yourself, highfive

It looks silly.

The reason for this was to test stuff with multiple reviewers - e.g., choosing a random reviewer doesn't make sense with just one reviewer. I get notifications in any case.


BUG-303: no negative sizes

Never save a dimension lower than the minimum (240px). Never render a dimension lower than the minimum (240px). This ought to prevent any strangeness.

We probably should add those enforcements to the backend too, if they aren't there @jobelenus

bors merge


Fixed isValidUser username and password check

When checking data provider credentials in isValidUser, it always passes true to isProvider. For data providers we may want to check both username and password.

Thanks!


Request failed with status code 429

It should be due to limitations imposed by the OpenAI API.

Good point; we do need to handle some common error codes instead of showing them directly to the user.
429 does mean come to the request limit, such as 3 in 1 minute; I found it in: https://platform.openai.com/docs/guides/error-codes/api-errors
I also found more context in the below links:
https://help.openai.com/en/articles/6891839-api-error-code-guidance
https://help.openai.com/en/articles/6897213-openai-library-error-types-guidance
https://callmefred.com/how-to-fix-openai-error-ratelimiterror-the-server-had-an-error

Closed by https://github.com/mefengl/vscode-i-dont-care-about-commit-message/commit/f02394e508bfbff7dbf1b8329e929ec164df9c39


properly handled failed seek

This is a minor bug in the way we're handling exceptions for super_len in prepare_body. The mocked seek method wasn't created with the optional whence parameter and was failing with a TypeError when called. A legacy exception block for the older version of super_len caught this and made it appear the test was passing.
This commit will wrap the seek->tell->seek process in the appropriate exceptions and fix the test.
I think there's two things that may need further discussion though. The first minor one being, we've been using super_len in prepare_content_length without this broad exception block from prepare_body for two releases without issue. I'm going to suggest we remove it from prepare_body because I don't think these exceptions can be raised from super_len any longer, except in cases we probably don't want them caught.
The second is, if we seek to the end of a file and fail on the tell or seek back to the original position, do we want to actually send the request? At that point, we'd probably want to raise an exception, right? This probably is something for 3.0.0 since it will be breaking, but wanted to address it before we merge this.

Codecov Report

Merging #3873 into master will decrease coverage by -0.09%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3873      +/-   ##
==========================================
- Coverage   89.17%   89.08%   -0.09%
==========================================
  Files          15       15
  Lines        1893     1896       +3
==========================================
+ Hits         1688     1689       +1
- Misses        205      207       +2

Impacted Files
Coverage Δ

requests/utils.py
84.94% <100%> (+0.12%)
:white_check_mark:

requests/models.py
93.42% <ø> (-0.46%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f3842...f47aff6. Read the comment docs.

So, this patch demonstrates the possible advantages of removing the overbroad exception block because this patch actually manages to regress coverage despite being completely covered. I still think we should merge it. =)

Great! @Lukasa, when you have a free moment, would you mind merging master in proposed/3.0.0 so I can rebase my changes for #3338 onto this?

I've done so, but we should see if the builds run because the merge was pretty gnarly.

😬 yep, looking a little rough. I can tidy things up if you don't want to deal with it.

heh, I'd definitely accept a PR if you're feeling in the mood. Otherwise I'll tackle it after this meeting.


Update codeql filename in grading script

Fixes https://github.com/githubtraining/exercise-enable-code-scanning-using-codeql/issues/4

ok

I think it would be actually better to rename the file to codeql-analysis.yml, which is the default name for the CodeQL workflow.


Vulnerability roundup 103: snort-<IP_ADDRESS>: 3 advisories [7.5]

search, files

[ ] CVE-2021-1223 CVSSv3=7.5 (nixos-21.05)
[ ] CVE-2021-1224 CVSSv3=5.3 (nixos-21.05)
[ ] CVE-2021-1495 CVSSv3=5.3 (nixos-21.05)

Scanned versions: nixos-21.05: 0b8b127125e.
Cc @aycanirican

@ckauhaus Thank you, fixed by https://github.com/NixOS/nixpkgs/pull/128580.


Error while installing on latest version of OS X

Hello,
We are seeing the following error when installing 0.59 on OS X.
xh_config.h:25:10: fatal error: 'endian.h' file not found
Perl version 5.38.2
Last successfully installed XML-Hash-XS version: 0.57
Mac terminal launched with rosetta
We have reproduced the error on 3 machines.

Hello,
In src/xh_config.h, changing include <endian.h> toinclude <machine/endian.h> allows it to successfully compile on macOS (Sequoia 15.2) on my machine in Terminal, also with Rosetta and perl v5.40.0.
I hope this helps for fix.
Best Regards,
Travis

Hi! Please check v0.63.

Hello,
Worked like a charm. Thanks so much for your work.
-Travis
cpanm XML::Hash::XS
--> Working on XML::Hash::XS
Fetching http://www.cpan.org/authors/id/Y/YO/YOREEK/XML-Hash-XS-0.63.tar.gz
... OK
Configuring XML-Hash-XS-0.63 ... OK
Building and testing XML-Hash-XS-0.63 ... OK
Successfully installed XML-Hash-XS-0.63 (upgraded from 0.59)
1 distribution installed
On Sun, Dec 29, 2024 at 9:02 PM Yurii Ustiushenko @.***>
wrote:

Hi! Please check v0.63.
—
Reply to this email directly, view it on GitHub
https://github.com/yoreek/XML-Hash-XS/issues/26#issuecomment-2565028908,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BNMVPKXHV4RP2BMRSIEVSGT2IDHV5AVCNFSM6AAAAABUHZRZNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRVGAZDQOJQHA
.
You are receiving this because you commented.Message ID:
@.***>


Finegrained humidity

Humidity in ENV_DATA has the same format as temperature, but without the offset. This pull request adapts setEnvironmentalData() to take humidity as a double as well. In addition to basically duplicating the code for temperature it also changes the division by 0.001953125 to a multiplication by 512. Mathematically this works out to be exactly the same, but it feels more in line with the datasheet which specifies "[...] is stored as an unsigned 16 bits integer in 1/512 [...]".
Additionally: I used "clang-format -i" this time before submitting the pull request :-)

please change to float, we dont get double preceision anyways

Both humidity and temperature?

yes please, will reduce flash usage greatly - we shouldn't be using doubles

modf won't work with floats :-(

The "algorithm" to convert the float values to uint16_t has been verified with the following code snippet (on a linux box):
#include <stdint.h>
#include <stdio.h>

int main(void) {
  float hum = 48.75;
  uint16_t hum_conv = hum * 512 + 0.5;

  printf("%g\n", hum);
  printf("%x\n", hum_conv);
  return 0;
}

result:
[chbw@undisclosed ccs811test]$ g++ foo.cpp -o foo && ./foo
48.75
6180

I added the f-suffix to the constants to really avoid doubles.
While the previous code version only explicitly uses float, the constants without suffix can cause an implicit conversion to double. With ARM gcc 9.2 (none) on compiler explorer/godbolt.org one can see that the variant without the f suffix uses __aeabi_f2d, __aeabi_dadd and __aeabi_d2uiz where with the suffix no conversion to double takes places and the code only uses __aeabi_fadd and __aeabi_f2uiz. However, there is no difference between the variants with AVR gcc 9.2.0 where float and double are literally the same.

thanks! @caternuson can you take a look?

@ladyada :eyes: yep
@chbw Is this changed based only on code inspection? Or is there some repeatable issue that goes along with this?

@caternuson this is not based only on code inspection, this is working code. I wanted to use the full precision of a DHT22 sensor's humidity data with the CCS811 ENV_DATA register.
The first commit here (1e1e4ff) basically duplicated the code for temperature (due to the very similar format in the registers) and the humidity parameter got the same data type as the temperature parameter. A very conservative (or lazy?) code change.
In the second commit (28fb189), I tried to get rid of double in favor of  #float after @ladyada's input. Unfortunately, simply replacing double with float did not cut it. The function modf in the existing code takes a pointer to a double as second argument, which necessitates having a double in the first place. So I implemented the conversion in a different way. While being functionally correct, commit 28fb189 is a major mistake at it still contains double literals and thus does not get rid of double induced code at all.
Commit e0a6a8e finally contains float literals.

Thanks for this. Looks like a good update. The existing implementation does look a bit odd - both in parameter types used and not using full resolution of relative humidity.
Tested the update with simple modification to library example sketch:
#include "Adafruit_CCS811.h"

Adafruit_CCS811 ccs;

void setup() {
  Serial.begin(9600);
  while (!Serial);

  Serial.println("CCS811 test");

  if(!ccs.begin()){
    Serial.println("Failed to start sensor! Please check your wiring.");
    while(1);
  }

  // Wait for the sensor to be ready
  while(!ccs.available());

  // Set known values for humidity and temperature
  ccs.setEnvironmentalData(42.8, 24.3);
}

void loop() {
  if(ccs.available()){
    if(!ccs.readData()){
      Serial.print("CO2: ");
      Serial.print(ccs.geteCO2());
      Serial.print("ppm, TVOC: ");
      Serial.println(ccs.getTVOC());
    }
    else{
      Serial.println("ERROR!");
      while(1);
    }
  }
  delay(500);
}

on an Itsy M4 and simple breath-on-it for input:
CCS811 test
CO2: 0ppm, TVOC: 0
CO2: 0ppm, TVOC: 0
CO2: 0ppm, TVOC: 0
CO2: 400ppm, TVOC: 0
CO2: 746ppm, TVOC: 52
CO2: 746ppm, TVOC: 52

Dumping relevant datasheet info here for general reference:


can't login

login with connection failed .
when i want to delete everything to relogin
it return:
An unexpected application error occurred.
Please let us know of the following error message as it could be a bug:
code fault: _setBooted called while self.hasBooted=true

Hi @Cliff012 you should be able to login now.
I will however see if we can replicate the delete all bug on our side as it should not rely on you needing to be connected.

OK .i login now ,thanks
------------------ 原始邮件 ------------------
发件人:                                                                                "mymonero/mymonero-app-js"<EMAIL_ADDRESS>发送时间: 2020年12月15日(星期二) 下午4:20
收件人<EMAIL_ADDRESS>抄送: "宁忠炜"<850709035<EMAIL_ADDRESS>主题: Re: [mymonero/mymonero-app-js] can't login  (#348)
Hi @Cliff012 you should be able to login now.
I will however see if we can replicate the delete all bug on our side as it should not rely on you needing to be connected.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


More than twenty 'IServiceProvider' instances have been created for internal use by Entity Framework

after a few requests, I am getting this issue. Do you have any idea what is the issue here.
An unhandled exception was thrown by the application.
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Infrastructure.ManyServiceProvidersCreatedWarning': More than twenty 'IServiceProvider' instances have been created for internal use by Entity Framework. This is commonly caused by injection of a new singleton service instance into every DbContext instance. For example, calling 'UseLoggerFactory' passing in a new instance each time--see https://go.microsoft.com/fwlink/?linkid=869049 for more details. This may lead to performance issues, consider reviewing calls on 'DbContextOptionsBuilder' that may require new service providers to be built. This exception can be suppressed or logged by passing event ID 'CoreEventId.ManyServiceProvidersCreatedWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.
at Microsoft.EntityFrameworkCore.Diagnostics.EventDefinition.Log[TLoggerCategory](IDiagnosticsLogger1 logger, Exception exception)    at Microsoft.EntityFrameworkCore.Diagnostics.CoreLoggerExtensions.ManyServiceProvidersCreatedWarning(IDiagnosticsLogger1 diagnostics, ICollection1 serviceProviders)    at Microsoft.EntityFrameworkCore.Internal.ServiceProviderCache.<GetOrAdd>g__BuildServiceProvider|4_1(IDbContextOptions _, ValueTuple2 arguments)
at Microsoft.EntityFrameworkCore.Internal.ServiceProviderCache.GetOrAdd(IDbContextOptions options, Boolean providerRequired)
at Microsoft.EntityFrameworkCore.DbContext.get_ContextServices()
at Microsoft.EntityFrameworkCore.Internal.InternalDbSet1.get_EntityType()    at Microsoft.EntityFrameworkCore.Internal.InternalDbSet1.CheckState()
at Microsoft.EntityFrameworkCore.Internal.InternalDbSet1.get_EntityQueryable()    at Microsoft.EntityFrameworkCore.Internal.InternalDbSet1.System.Linq.IQueryable.get_Provider()
at System.Linq.Queryable.Where[TSource](IQueryable1 source, Expression1 predicate)
at Ashghal.BusinessCards.Authorization.RoleMappingService.<>c__DisplayClass6_0.b__0(ICacheEntry cacheEntry) in D:\Ashghal\DevOps\Business Cards\Authorization\RoleMappingService.cs:line 29
at Microsoft.Extensions.Caching.Memory.CacheExtensions.GetOrCreate[TItem](IMemoryCache cache, Object key, Func2 factory)    at ResolveService(ILEmitResolverBuilderRuntimeContext, ServiceProviderEngineScope)    at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(ServiceIdentifier serviceIdentifier, ServiceProviderEngineScope serviceProviderEngineScope)    at Microsoft.AspNetCore.Authentication.AuthenticationHttpContextExtensions.GetAuthenticationService(HttpContext context)    at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)    at Microsoft.AspNetCore.Server.IIS.Core.IISHttpContextOfT1.ProcessRequestAsync()

Hi, it is a known issue.
Unfortunately, I have no fix for it now.
As a temporary solution use
builder.ConfigureWarnings(x => x.Ignore(CoreEventId.ManyServiceProvidersCreatedWarning));

You can also set EnableServiceProviderCaching for development purposes.
services.AddDbContext<ApplicationDbContext>(options => {
    options.UseFileBaseContextDatabase("dbUser"));
    options.EnableServiceProviderCaching(false);
});


mongoose.connect is treated as if it's synchronous

https://github.com/meanjs/mean/blob/master/server.js#L16 You're treating that call as if it's blocking, but it's not -- establishment of a connection(s) is async, and the rest of the initialization should only proceed after the callback is called without an error, right?

@zbjornson take a look at 0.4.0 for the improved version.

@ilanbiala yes, it's correct in 0.4.0.
(Your branches are a bit confusing -- the readme gives instructions for checking out the "latest" version of the repository, but the instructions will check out master, not 0.4.0. From the number of commits in each branch, I was not sure if 0.4.0 was historical or future.)

0.4.0 is future, but getting much closer to be merged into master.
I think this issue is resolved then.


NLog + .NET 6.0 + Npgsql 6.0 get error with logged DateTime (timestamptz)

NLog 4.7.12 + .NET 6.0 + Npgsql 6.0 get error with logged DateTime (timestamptz)
After updating the project to .NET 6.0. There was a problem with the logging. Due to changes in the date format, the Npgsql 6.0 component.
Breaking changes:
https://www.npgsql.org/doc/release-notes/6.0.html
https://www.npgsql.org/doc/types/datetime.html
NLog version: 4.7.12
dbProvider: Npgsql 6.0
Platform: .Net 6.0
Current NLog config (xml or C#, if relevant)
...
    <target name="database" xsi:type="Database"
            dbProvider="Npgsql.NpgsqlConnection, Npgsql"
            connectionString="User ID=user;Password=pass;Host=psqlserver;Port=5432;Database=cloud_logging;Pooling=true;">
...
     <!--
CREATE TABLE log
(
    Id serial primary key,
    Application character varying(100) NULL,
    Logged timestamptz(6) NOT NULL,
    Level varchar(100) NULL,
    Message varchar(8000) NULL,
    Logger varchar(8000) NULL,
    Callsite varchar(8000) NULL,
    Exception varchar(8000) NULL
)
-->
      <commandText>
        insert into log (
        Application, Logged, Level, Message,
        Logger, CallSite, Exception
        ) values (
        @Application, @Logged, @Level, @Message,
        @Logger, @Callsite, @Exception
        );
      </commandText>
...

I tried different options and nothing helps.
Try:
      <parameter name="@logged" layout="${date}" dbType="NpgsqlDbType.TimestampTz" />

and:
      <parameter name="@logged" layout="${date}" dbType="DateTime" />

Error:
2021-11-15 17:07:12.1611 Error DatabaseTarget(Name=database): Error when writing to database. Exception: System.InvalidCastException: Cannot write DateTime with Kind=Local to PostgreSQL type 'timestamp with time zone', only UTC is supported. Note that it's not possible to mix DateTimes with different Kinds in an array/range. See the Npgsql.EnableLegacyTimestampBehavior AppContext switch to enable legacy behavior.
   at Npgsql.Internal.TypeHandlers.DateTimeHandlers.TimestampTzHandler.ValidateAndGetLength(DateTime value, NpgsqlParameter parameter)
   at Npgsql.Internal.TypeHandlers.DateTimeHandlers.TimestampTzHandler.ValidateObjectAndGetLength(Object value, NpgsqlLengthCache& lengthCache, NpgsqlParameter parameter)
   at Npgsql.NpgsqlParameter.ValidateAndGetLength()
   at Npgsql.NpgsqlParameterCollection.ValidateAndBind(ConnectorTypeMapper typeMapper)
   at Npgsql.NpgsqlCommand.ExecuteReader(CommandBehavior behavior, Boolean async, CancellationToken cancellationToken)
   at Npgsql.NpgsqlCommand.ExecuteReader(CommandBehavior behavior, Boolean async, CancellationToken cancellationToken)
   at Npgsql.NpgsqlCommand.ExecuteNonQuery(Boolean async, CancellationToken cancellationToken)
   at Npgsql.NpgsqlCommand.ExecuteNonQuery()
   at NLog.Targets.DatabaseTarget.ExecuteDbCommandWithParameters(LogEventInfo logEvent, IDbConnection dbConnection, IDbTransaction dbTransaction)
   at NLog.Targets.DatabaseTarget.WriteLogEventToDatabase(LogEventInfo logEvent, String connectionString)

Notice this is the repository for the NLog-core-project. So not support forum for specific DbProvider-implementation. Think you will a larger audience at StackOverflow.com.
Found the following Npgsql documentation:
https://www.npgsql.org/doc/release-notes/6.0.html#major-changes-to-timestamp-mapping
But have you tried doing this:
<parameter name="@logged" layout="${date:universalTime=true}" dbType="NpgsqlDbType.TimestampTz" />
```

Since it complains about:

> Cannot write **DateTime with Kind=Local** to PostgreSQL type 'timestamp with time zone'

Thanks snakefoot, it helped me.
But I must note that I also had to write down the column names in lowercase letters, otherwise they would not be found.
Before, everything worked without it,
PS: I apologize if I wrote about the problem in the wrong place.

Glad you found a solution. Closing issue as resolved.


fix(cli.rs): prefix the "before script" env vars with TAURI_

Before we exported env vars to the "before scripts" (beforeDevCommand and beforeBuildCommand) like this ARCH, PLATFORM and VERSION which is problematic for two reasons:

It can clash with env variables defined by the OS (ARCH is very generic for example)
It wasn't clear that the env vars above came from the tauri bundling process.
Tools like vite, have a whitelist by prefix for security reasons. So having everything prefixed with TAURI_ will make life easier and more secure for our tauri+vite users.

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[x] Yes, and the changes were approved in issue #___
[ ] No

Checklist

[ ] When resolving issues, they are referenced in the PR's title (e.g fix #___, #___)
[ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

Other information

Good idea imo

I caused the problem, I fix the problem lol