debugger running on live site

I don't know if this is the right place to talk about this as in my view this is a security related issue but i didn't found a more private place to send this.
The site right now is exposing the werkzeug when a exception occurs (which for me occurred on http://pennydreadfulmagic.com/league/, a link that is shown on the login page as "league announcements"). Sure the PIN is active but even their own docs warn multiple times about the risk of enabling it on a production environment.
Is this a bug or a known "shippable" issue? In the later case is ok to do PR with support for a env settings disabling it on production?

This is one for @silasary to decide on. With the PIN stuff I wonder how big the risk really is here.

ac87089 at least prevents /league/ from showing it by fixing the 404 page.

It's known (and has been incredibly useful).
With the 404 page fixed, I think this is an acceptable risk.

Sounds ok to me.


Starting a new Python background solution

First of all, the "Blinky" sample is running fine and I can make changes.
Now I want to recreate this sample starting with a new project. Till now I only have 2 lines and i'm stuck.
print  ("/// Test 1 ///")
import _wingpio as gpio
After hitting F5, I get this:
====
The program '[4032] backgroundTaskHost.exe' has exited with code 0 (0x0).
/// Test 1 ///
Traceback (most recent call last):
File "visualstudio_py_remote_launcher.py", line 119, in
run_as
File "visualstudio_py_remote_launcher.py", line 58, in debug_remote
vspd.exec_file(file, globals_obj)
File "C:\Users\DefaultAccount\AppData\Local\DevelopmentFiles\ptest1VS.Debug_ARM.Schelto\visualstudio_py_util.py", line 111, in exec_file
exec_code(code, file, global_variables)
File "C:\Users\DefaultAccount\AppData\Local\DevelopmentFiles\ptest1VS.Debug_ARM.Schelto\visualstudio_py_util.py", line 87, in exec_code
exec(code_obj, global_variables)
File "StartupTask.py", line 2, in
import _wingpio as gpio
ImportError: No module named '_wingpio'
Error in sys.excepthook:
Traceback (most recent call last):
File "C:\Users\DefaultAccount\AppData\Local\DevelopmentFiles\ptest1VS.Debug_ARM.Schelto\ptvsd\visualstudio_py_debugger.py", line 2197, in _excepthook
do_wait()
File "C:\Users\DefaultAccount\AppData\Local\DevelopmentFiles\ptest1VS.Debug_ARM.Schelto\ptvsd\visualstudio_py_debugger.py", line 2324, in do_wait
msvcrt.getch()
AttributeError: module 'msvcrt' has no attribute 'getch'
Original exception was:
Traceback (most recent call last):
File "visualstudio_py_remote_launcher.py", line 119, in
run_as
File "visualstudio_py_remote_launcher.py", line 58, in debug_remote
vspd.exec_file(file, globals_obj)
File "C:\Users\DefaultAccount\AppData\Local\DevelopmentFiles\ptest1VS.Debug_ARM.Schelto\visualstudio_py_util.py", line 111, in exec_file
exec_code(code, file, global_variables)
File "C:\Users\DefaultAccount\AppData\Local\DevelopmentFiles\ptest1VS.Debug_ARM.Schelto\visualstudio_py_util.py", line 87, in exec_code
exec(code_obj, global_variables)
File "StartupTask.py", line 2, in
import _wingpio as gpio
ImportError: No module named '_wingpio'
The program '[4032] python @ tcp://pisvd:5678/?sd=C%3a%5cUsers%5cSchelto%5cDesktop%5cptest1%5cptest1&td=C%3a%5cUsers%5cDefaultAccount%5cAppData%5cLocal%5cDevelopmentFiles%5cptest1VS.Debug_ARM.Schelto&host=uwp' has exited with code -1 (0xffffffff).
(Sorry for the formatting above, I can't fix it)
The screen says:
ImportError was unhandled by user code
Message: No module named '_wingpio'
After the build was done and comparing the two solutions, I found differences in directory structures and missing files.  Copying the windevises directory and licence.txt file into the solution did not help.
The root cause seems to be File "visualstudio_py_remote_launcher.py". I cant find it and no useful info on Google.
What should I try next?

pcopa,
The error, <File "StartupTask.py", line 2, in import _wingpio as gpio ImportError: No module named '_wingpio'>, means that python cannot find the _wingpio module.  The _wingpio module needs to be downloaded to the device (ie, raspberry Pi) along with the python interpreter/libraries during deployment.
To do that, you need to

copy the files under windevices to your blinky project (which you have done already)
and add a reference to the _wingpio to your *.pyproj.  You can do that by comparing the your *.pyproj and the PythonBlinkyHeadless.pyproj.  You should find an item group that looks like the following.  Just copy the whole block to your project.

<ItemGroup>
    <Reference Include="windevices\ARM\_wingpio_d.pyd" Condition=" [...snip for brevity ...]>">
      <Name>_wingpio_d.pyd</Name>
      <PythonExtension>windevices\ARM\_wingpio_d.pyd</PythonExtension>
    </Reference>
    [ ... snip... other references for other architectures ...]
</ItemGroup>

Hope this helps!

@alanch-ms  Thanks Alan, that explains a lot. I would have never figured that out myself. Blinky is blinking again.
There are still 2 errors popping up during debug and the output window also disappears, but pops back up at the end and shows no errors. But that's another story!
I'm a computer HW eng and completely new to Python.
When in VS I've noticed that i could not edit the .pyproj file. Only if it's broken, edit is available on tight click.
To look what's going on, I used file-explorer and notepad to edit and some edits got corrupted after starting sln again.
Is there a better editor? I'm always weary of special formatting characters.

Is there a better editor?

There is a way to modify the project file (.pyproj) in Visual studio.  You will need to unload the project first  right click on the project in the solution explorer -> unload project.  After the project has been unloaded, right click on the project -> edit *.pyproj .  The xml content of the project file should opened in VS.  After you have made your modifications, you can reload the project by right click on the project -> Reload Project

@alanch-ms  Thanks Alan, that works fine.
Moving on to trying the spi interface, I replaced the windevices directory with the pywindevices directory and changed/added the references in the .pyproj file.  But I could not get the spi pins to budge. Not with pin addressing and not with GPIO addressing.
So I re-addressed the spi pins to unused GPIO pins and now everting is working.
Do the spi pins need to be enabled in raspberry pi2?
Is there a description of the supported commands in pywindevices?  Im looking for something like "GPIO.setmode(GPIO.BCM)"


⚠ Bofrost.at has degraded performance

In cbd00e6, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1096 ms

Resolved: Bofrost.at performance has improved in 7d61fff.


Sticky navbar is not working on mobile version

Describe the bug
The sticky navbar on mobile disappears as the user scrolls down to various website sections.
To Reproduce
Steps to reproduce the behavior:

Go to the homepage on mobile
Scroll down to any section
See bug

Expected behavior
The navbar should remain fixed at the top (or any other specified position) of the webpage as the user scrolls. This ensures that the navigation menu is always accessible, regardless of the user's position on the page.
Bear in mind that the sticky navbar should adapt to different screen sizes and devices. It should be responsive and adjust its layout and appearance accordingly, ensuring optimal usability on mobile devices as well as desktops
Screenshots
If applicable, add screenshots to help explain your problem.

@ijemmao this is the intended behaviour for mobile devices? yes if assign it to me, let me handle it.

@kingdanie go for it!

Closing since this issue since it doesn't seem relevant anymore. Feel free to reopen. Thank you for opening this ticket!


Develop

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[CI] Fix CI

Description
One of our dependencies apparently dropped their dependency on boto3 and scipy. These are however required for our tests and were missing, causing test failures.
Checklist
Essentials

[X] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

Job PR-875/4 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-875/4/index.html


Document suggested arguments to hash for beginners

My impression is that the most standard way to call Crypto.Hash.BLAKE2.BLAKE2b.hash is hash 64 mempty, but I had to look in the benchmarks to make sure. It would be nice to have more info about this in the Haddocks. I'd be happy to look through the spec and make a PR if you'd like one.

@seagreen: Is this what you intended?

Exactly, looks great!


Have problem detect single digit

Hi, thanks for the package.
However I am having problem with the attached image. Seems doctr can not detect single digit.
Any special config to use to make it work?
Thanks!
Patrick

Hi,
Maybe the models have been trained like that: detect at least 2 charset and return a box .
By running the demo app with default models, it seems that the detection model doesn't create boxes.
You can see it as follows:

I think with better SOTA models it would detect it.
In next doctr versions, contributors will implement them

Hello @patrickjchen,
Thank you for sharing your thoughts and ideas. The fastest way to achieve your desired results seems to train yourself on one of the models of detection with tagged data, specifically focusing on texts with single character/digit labels. It could be an effective solution.. but not in the long term.
I'd be more than happy to assist you by providing relevant data that aligns with your specific interests. By fine-tuning the data you choose, you can further optimize your progress. Moreover, if you decide to share the data you've tagged with doctr, it would not only benefit in the future yourself but also other people. It would greatly contribute to enhance future models and ensuring they incorporate your desired specifications.
Would you be interested ? :)

Thanks Nikokks!   However,  ML/AI is just a hobby for me. I will contact you in a couple of weeks when I have some more free time.
Best Regards
Patrick


SmartBlocks integration

Would it be possible for this plugin to work with your SmartBlocks plugin, to insert templates with dynamic variables using the current meeting title and attendees as properties?
BTW, thanks for all the awesome work you have been doing with Logseq offlate.

This would be great - I'd love to have Logseq automatically pull in my calendar at the top when a new daily page is created. Either via smartblocks or some other automation.


Allow custom certificates in oidc mode

Allow oidc flow with custom certificates when run in insecure mode
Testing done
Done!! tested with setting up oidc auth flow with dex followed by untrusted cert

Thanks @iaguis for setting up the test cluster :D

fixes #127


Script error on some magento sites with customized flows

We should null check every time we do $('id-name').  Some folks are getting:
Uncaught TypeError: Cannot read property 'contains' of null
checkout.js:407window.requestAutocomplete.MagentoFlow.onClick_
checkout.js:407(anonymous function)
prototype.js:391

Should this issue be closed, since the associated PR is merged?


Next release, when?

Hi 👋🏽 ,
is there any info about next release? I'd like to use the cython plugins with the meta propagation fixed. Thanks

It's really hard to tell when the next release will be!
But the last one was 10 minutes ago ;)


"'NoneType' object is not iterable" on "az advisor recommendation disable"

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az advisor recommendation disable
Errors:
'NoneType' object is not iterable
Traceback (most recent call last):
Temp\pip-install-p8t_6awn\knack\knack\cli.py, ln 206, in invoke
azure\cli\core\commands\__init__.py, ln 603, in execute
azure\cli\core\commands\__init__.py, ln 661, in _run_jobs_serially
azure\cli\core\commands\__init__.py, ln 654, in _run_job
Local\Temp\pip-install-p8t_6awn\six\six.py, ln 693, in reraise
azure\cli\core\commands\__init__.py, ln 631, in _run_job
azure\cli\core\commands\__init__.py, ln 306, in __call__
azure-cli-core\azure\cli\core\__init__.py, ln 485, in default_command_handler
azure\cli\command_modules\advisor\custom.py, ln 26, in disable_recommendations
TypeError: 'NoneType' object is not iterable

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

az login
az advisor recommendation disable

Expected Behavior
Environment Summary
Windows-10-10.0.17763-SP0
Python 3.6.6
Shell: powershell.exe

azure-cli 2.0.75

Additional Context

@RakeshMohanMSFT Nice PR to fix.


WIP: Change API to be able to assign roles to namespaces

Fixes #491.

This is WIP. Do not review.

@costrouc @dcmcand NOT READY FOR MERGE (SEE BELOW), but PTAL. This might have minor issues here and there, I'll do another review before this gets merged.
The design I'm trying to implement is here https://github.com/conda-incubator/conda-store/issues/491#issuecomment-1751773261. I had to deviate from that in some places, but it's mostly the same.
As requested by Tania and Chuck, I need to keep the old APIs and make the new APIs v2. On the ORM side, old tables will also stay until the deprecation period is over. For old APIs that I'm replacing, we'll communicate that those are deprecated (by updating documentation/release notes and also using HTTP). If you have opinions on how we should sunset/deprecate APIs on the HTTP side, let me know.

@costrouc PTAL.
New routes are part of the v2 API now. Old v1 routes (that are compatible) are marked as v2 as well. There's one incompatible v1 route.
This touches auth code. What I do is check the v2 roles first, then check v1.
I think we should later port the tests so that all v2 routes are tested as well, to ensure compatibility between v1 and v2. This PR only tests new v2 routes because it's very big already.
I've also added experimental route support while I'm changing this.
I'm not 100% sold on routes being oneliners, LMK what you think. I now feel like changing the oneliners back, just to keep the diff less verbose.
I'm also not sure whether having NAMESPACE_ROLE_MAPPING_READ permission implies we don't need to check for NAMESPACE_READ. I think we should check for both since there's no downside to do that, but there's a lot of downside if we introduce a mistake in permission-checking logic.
The commit we looked at previously is saved here as part of this branch.

TODO: Add namespace-read everywhere we use it.

Since this uses a DB migration, this will need to be rebased on updated main before merging.

One thought that occurred to me is that introducing the version to our routes actually is breaking if anyone has previously had naked routes. I think adding a router for naked routes that redirects to v1 of the route and documenting this would handle that issue. This could be a seperate issue/pr if that is simpler, but without it this will be a breaking change.

One thought that occurred to me is that introducing the version to our routes actually is breaking if anyone has previously had naked routes.

Did you mean to reply to the router_ui thread? This PR doesn't make changes to existing routes.

Yeah, no action is needed here. I'll mention this for whoever is reading these later. The API I'm using is already versioned:
router_api = APIRouter(
    tags=["api"],
    prefix="/api/v1",
)


cargo run -- install.scm fails with os error 2: no such file or directory

currently nix build and nix shell does not work.
Running either command errors with
> error: package `clap_builder v4.5.2` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.72.1
> Either upgrade to rustc 1.74 or newer, or use
> cargo update -p<EMAIL_ADDRESS>--precise ver
> where `ver` is the latest version of `clap_builder` supporting rustc 1.72.1

This is easily fixable by updating  flake.lock (i.e. calling nix flake update).

Package is not currently installed.
=> Installing:  '#hash((package-name . steel/lists) (path . "/build/source/cogs/lists") (version . "0.1.0") (dependencies . ()))
=> Copied package over to:  /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/steel/lists
✅ Installed package to: /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/steel/lists
Package is not currently installed.
=> Installing:  '#hash((path . "/build/source/cogs/command-line") (version . "0.1.0") (package-name . steel/command-line) (dependencies . ()))
=> Copied package over to:  /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/steel/command-line
✅ Installed package to: /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/steel/command-line
Package is not currently installed.
=> Installing:  '#hash((package-name . steel/sorting) (version . "0.1.0") (dependencies . ()) (path . "/build/source/cogs/sorting"))
=> Copied package over to:  /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/steel/sorting
✅ Installed package to: /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/steel/sorting
Package is not currently installed.
=> Installing:  '#hash((dependencies . ()) (package-name . steel/collections) (path . "/build/source/cogs/collections") (version . "0.1.0"))
=> Copied package over to:  /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/steel/collections
✅ Installed package to: /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/steel/collections
Package is not currently installed.
=> Installing:  '#hash((package-name . steel/tests) (dependencies . ()) (version . "0.1.0") (path . "/build/source/cogs/tests"))
=> Copied package over to:  /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/steel/tests
✅ Installed package to: /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/steel/tests
Package is not currently installed.
=> Installing:  '#hash((version . "0.1.0") (path . "/build/source/cogs/srfi") (package-name . srfi) (dependencies . ()))
=> Copied package over to:  /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/srfi
✅ Installed package to: /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/srfi
Package is not currently installed.
=> Installing:  '#hash((dependencies . ()) (package-name . steel/fs) (version . "0.1.0") (path . "/build/source/cogs/fs"))
=> Copied package over to:  /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/steel/fs
✅ Installed package to: /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/steel/fs
Package is not currently installed.
=> Installing:  '#hash((version . "0.1.0") (package-name . steel/time) (path . "/build/source/cogs/time") (dependencies . ()))
=> Copied package over to:  /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/steel/time
✅ Installed package to: /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/steel/time
Package is not currently installed.
=> Installing:  '#hash((path . "/build/source/cogs/installer") (dependencies . ()) (version . "0.1.0") (package-name . installer))
=> Copied package over to:  /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/installer
✅ Installed package to: /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/installer
Package is not currently installed.
=> Installing:  '#hash((path . "/build/source/cogs/slack") (version . "0.1.0") (dependencies . ('#hash((#:path . "../libs/steel-websockets") (#:name . steel-websockets)) '#hash((#:path . "../libs/steel-webrequests") (#:name . steel-webrequests)))) (package-name . slack/websocket))
=> Copied package over to:  /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/slack/websocket
=> Installing:  '#hash((version . "0.1.0") (package-name . steel-websockets) (dependencies . ()) (path . "../libs/steel-websockets") (dylibs . ('#hash((#:name . "steel-websockets") (#:workspace-root . "../..") (#:subdir . "libs/steel-websockets")))))
=> Copied package over to:  /nix/store/lh4y0sjnnqqmwmrzn91lbhfqim1md3ap-steel-interpreter-0.6.0/lib/cogs/steel-websockets
Attempting to install:  '#hash((#:name . "steel-websockets") (#:workspace-root . "../..") (#:subdir . "libs/steel-websockets"))
Running dylib build in:  ../libs/steel-websockets/../../libs/steel-websockets
error[E03]: TypeMismatch
┌─ install.scm:11:1
│
11 │
│   Struct getter expected Ok, found Gc(UserDefinedStruct { fields: [Error: Io: No such file or directory (os error 2)], type_descriptor: StructTypeDescriptor(1) }), (Err Error: Io: No such file or directory (os error 2))
Error: SteelErr { repr: Repr { kind: TypeMismatch, message: "Struct getter expected Ok, found Gc(UserDefinedStruct { fields: [Error: Io: No such file or directory (os error 2)], type_descriptor: StructTypeDescriptor(1) }), (Err Error: Io: No such file or directory (os error 2))", span: Some(2535..2544), stack_trace: Some(DehydratedStackTrace { stack_trace: [DehydratedCallContext { span: Some(0..0) }, DehydratedCallContext { span: Some(0..0) }, DehydratedCallContext { span: None }, DehydratedCallContext { span: Some(0..0) }, DehydratedCallContext { span: Some(2161..2172) }, DehydratedCallContext { span: Some(0..0) }, DehydratedCallContext { span: Some(1555..1563) }, DehydratedCallContext { span: Some(0..0) }, DehydratedCallContext { span: Some(2161..2172) }, DehydratedCallContext { span: Some(1555..1563) }, DehydratedCallContext { span: Some(2182..2186) }, DehydratedCallContext { span: Some(2426..2452) }] }) } }
/nix/store/v099hqvw5z87423p4hz1vfhzaqa07dii-stdenv-linux/setup: line 131: pop_var_context: head of shell_variables not a function context

PS: the popd in line 41 in flake.nix seems to throw an error too, see the last line of the log
EDIT: I investigated this further. This is not a nix flake error! Instead this seems to originate from running cargo run -- install.scm from contributing.scm too! To me it looks like steel-websockets or steel-regex fails to install (depending on which machine I use)

You probably missed my last edit :)
I could reproduce this issue on a non nixos too!

You're right - I did miss the edit! Can you try this:
git clone https://github.com/mattwparas/steel.git &&
cd steel &&
mkdir -p .steel/cogs && mkdir -p .steel/native && # Creates this directory too
export STEEL_HOME="$(pwd)/.steel" &&
cargo build &&
cargo install --path crates/cargo-steel-lib &&
pushd cogs &&
cargo run -- install.scm &&
popd &&
cargo test --all

I had thought that I would create that additional directory automatically; but it seems like I don't!

Okay so I'm realizing there might be more that needs to be done. In order to install dylibs we'll need the dylib installer which is installed separately as a cargo extension (eventually it doesn't need to be) - that is located under crates/cargo-steel-lib. Can you first try to install that with cargo install --path crates/cargo-steel-lib and then run the installer?
Apologies that this is all undocumented; this one slipped past me I think

Don't worry, as much is expected! So far, I enjoy steel very much. Looking forward to build helix plugins with it!
I'll keep you posted.

Okay so I'm realizing there might be more that needs to be done. In order to install dylibs we'll need the dylib installer which is installed separately as a cargo extension (eventually it doesn't need to be) - that is located under crates/cargo-steel-lib. Can you first try to install that with cargo install --path crates/cargo-steel-lib and then run the installer?
Apologies that this is all undocumented; this one slipped past me I think. There could be other things that I'm missing as well but that would be the first step to try debugging this

Thanks, had similar problem, but not using nix, just plain ubuntu, this fixed it.


Broken link to content monorepo

The README links to "Content monorepo" but this one returns 404. Is content monorepo still a private repository?
https://github.com/Pocket/pocket-monorepo/blob/6347430896efdc6635311f11f45366f7adbcf902/README.md?plain=1#L3

Thank you.  Yes, this repository is owned by another team and is not yet public.


XP Pylon bug - "Deposit All" setting Level to -1, huge negative XpP values

Minecraft version & Mod Version: MC 1.12.2 (FTB Horizons 3 1.1.0 release)
Forge <IP_ADDRESS>8
Cyclic v 1.12.2-1.9.8
Single player or Server: single player save
Describe problem (what you were doing / what happened): (after using the XP Pylon to deposit All XP)

noticed I was not getting any XP bar progress from picking up Xp orbs, from mining, kills, nor animal breeding.  Checked my XP value from the EverlastingAbilities "totem" UI, said I had -5 XP total.
Checked values in NBTExplorer:
had near overflow value for XpTotal
XpLevel -1  ||  XpP: -4.294967E+08

Crash log (if any): does not cause crash
Issue easily reproduced in current save file, let me know if I can capture additional logging to help track issue.

I will check to see if this happens in Cyclic 1.9.10, i did just fix a bunch of Exp pylon issues in this latest release

This should have been fixed in 1.9.10, but i also added an extra safeguard in 1.9.11 to prevent this https://minecraft.curseforge.com/projects/cyclic/files/2499688

for some reason, this same issue still occurs in version 1.16.6 but exclusively on dedicated servers.
tested with a forge server only running cyclic with default configs.
works perfectly fine on singleplayer worlds though.


Use the example to cause a field: Unhandled error during execution of beforeMount hook

Version
3.0.6
Reproduction link
https://github.com/pruidong/AntdvErrorDemo
Steps to reproduce

npm install
npm run dev
open http://localhost:3000/

What is expected?
Using Vue 3.0.5 and Ant Design Vue, Ant Design Vue's Carousel components can be used normally.
What is actually happening?
Visit the homepage, prompt:
runtime-core.esm-bundler.js:38 [Vue warn]: Unhandled error during execution of beforeMount hook
at <ACarousel effect="fade" >
at <App>

Please open an issue in their repo, or open a new issue here if you can reproduce the problem without involving 3rd party frameworks.


Think about how to 'hear' conversations in adjacent rooms

A further subdivision of "room" into "group" or "booth" that causes text of people who are in your room or group to be colored differently. This is so, if you're standing at say the ADOM booth, you can distinguish "Things people in the ADOM" booth are saying from "Things people at the AutoFire booth" are saying.

Figuring out how to visually distinguish this in our current UI might be tricky, but I think this would be valuable.
This is only a display setting, it doesn't change how you send messages. You can chat with people in adjacent areas since presumably they can see your messages the same way you can see theirs. (To be explicit, I'm imagining this being strictly bidirectional: you can never have rooms A and B where room A can hear room B but not vice-versa)

Coming back to this:
It's probably not to hard to steal this UI design from MMOs (a dropdown selector for chat context when typing, different styling on different received message types).
I'm still thinking through the value. Definitely valuable for sponsor booths / game showcases. I'm not yet sure it's as useful for the case of e.g. hanging out at a table in the kitchen. I don't know how to answer that question other than prototyping it. I think this is low priority, but worth eventually spending time on. Maybe as part of a larger rethinking of a showcase area.

I think this is too hard a problem for us to reasonably tackle this year, so I'm not going to think about it. Don't let me stop anyone else.


Unable to see Targets for prometheus-frontend

What did you do?
Deploy prometheus-operator, prometheus-frontend with serviceaccount, roles, rolebinding.
What did you expect to see?
Not getting metrics at http://ip_address:30100
The prometheus-frontend is  using system:serviceaccount:monitoring:prometheus-frontend and the serviceAccountName: prometheus-frontend is set in the prometheus-frontend deployment
What did you see instead? Under which circumstances?
Targets info not displaying at http://ip_address:30100/targets
Environment
CentOS 7.3
prometheus-operator 0.14

Kubernetes version information:
 Client Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.4", GitCommit:"793658f2d7ca7f064d2bdf606519f9fe1229c381", GitTreeState:"clean", BuildDate:"2017-08-17T08:48:23Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
 Server Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.4", GitCommit:"793658f2d7ca7f064d2bdf606519f9fe1229c381", GitTreeState:"clean", BuildDate:"2017-08-17T08:30:51Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:
kubeadm

Manifests:
   #  kubectl get po -n monitoring
   prometheus-frontend-0                  2/2       Running   0          5m

  ---
  apiVersion: v1
  kind: ServiceAccount
  metadata:
    name: prometheus-frontend
    namespace: monitoring

 ---
 apiVersion: rbac.authorization.k8s.io/v1beta1
 kind: Role
 metadata:
    name: prometheus-frontend
    namespace: monitoring
 rules:
 - apiGroups: [""]
   resources:
   - nodes
   - services
   - endpoints
   - pods
   verbs: ["get", "list", "watch"]
- apiGroups: [""]
  resources:
  - configmaps
  verbs: ["get"]

 ---
 apiVersion: rbac.authorization.k8s.io/v1beta1
 kind: RoleBinding
 metadata:
    name: prometheus-frontend
    namespace: monitoring
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
   name: prometheus-frontend
subjects:
- kind: ServiceAccount
   name: prometheus-frontend
   namespace: monitoring

Prometheus-frontend Logs:
    level=error ts=2018-03-15T05:01:22.217971764Z caller=main.go:212 component=k8s_client_runtime err="github.com/prometheus/prometheus/discovery/kubernetes/kubernetes.go:177: Failed to list *v1.Endpoints: User \"system:serviceaccount:monitoring:prometheus-frontend\" cannot list endpoints at the cluster scope. (get endpoints)"
    level=error ts=2018-03-15T05:01:22.220082098Z caller=main.go:212 component=k8s_client_runtime err="github.com/prometheus/prometheus/discovery/kubernetes/kubernetes.go:178: Failed to list *v1.Service: User \"system:serviceaccount:monitoring:prometheus-frontend\" cannot list services at the cluster scope. (get services)"
    level=error ts=2018-03-15T05:01:22.22024442Z caller=main.go:212 component=k8s_client_runtime err="github.com/prometheus/prometheus/discovery/kubernetes/kubernetes.go:179: Failed to list *v1.Pod: User \"system:serviceaccount:monitoring:prometheus-frontend\" cannot list pods at the cluster scope. (get pods)"

@bamb00 Thanks for your bug report.
Do I understand correctly that you are facing the following two issues:

prometheus-frontend not discovering the example-app targets
Retrieving the /metrics endpoint from the prometheus-frontend instance

Did you use the ./hack/example-service-monitoring/deploy script?
Would you mind pasting the output of the following command (promtheus configuration yaml) here:
kubectl exec -it prometheus-frontend-0 -- cat /etc/prometheus/config/prometheus.yaml

(Make sure to elide any secrets)
Are you able to reproduce the same issue with Prometheus operator 0.17?
Might be related to: https://github.com/coreos/prometheus-operator/pull/1107

Thanks for pointing out #1107 I see what I did wrong.


Promote Maturity Status to Beta

With the latest improvements to net-gateway-api and solidification of the config format (to match what we did in net-istio)
I think we're good to mark this integration as beta so we get some more usage.

/assign @izabelacg
/cc @skonto @ReToCode

/lgtm

/override "Generate some code!"
/override "style / Golang"
/override "style / suggester / github_actions"
/override "style / suggester / yaml"
/override "style / suggester / shell"


Upgrade to Spark 3.4.1 and Delta 2.4.0

This Draft PR is for updating versions of Spark and Delta to the latest available!
Here's a summary of some interesting changes that are included in the updates.
Spark 3.4.x
Read the full notes here: Apache Spark Version 3.4 , Apache Spark Version 3.4.1

Python Client for Spark Connect.
Timestamp without timezone support. (TimestampNTZ Type ).
Support timestamp in seconds for TimeTravel using Dataframe options
Better Spark UI scalability and Driver stability.
Catalog API compatible with 3 Layer Namespace.

Delta 2.4.0
Read the full notes here: Delta Lake Version 2.4.0

Support for Apache Spark 3.4
Deletion Vectors implementation. Improve the way UPDATES are handled and recovered, adopting a "Merge On Read" strategy.
Support for writing and reading with Deletion Vectors and PURGE in case we want to deactivate the feature for the table (which will invoke a rewrite of some of the files).
Support REPLACE WHERE expressions in SQL to selectively overwrite data.
Change on the DeltaLog API: Now snapshot is no longer reliable to return the last Snapshot available. Use DeltaLog.update() instead.
NOTE: This version does not include the Iceberg to Delta converter

The current status is the following:

New APIs of Table and DeltaLog adapted to the current code.
Introducing compatibility with TimestampNTZ.

Following the previous comment, I investigated a little bit more about the problem and opened this issue
I will discard all the code to solve the INSERT INTO with TIMESTAMP_NTZ here, so we can decouple both developments.
And before continuing with the Upgrade, we should fix #213 first.

Pending TODO: Support TIMESTAMP_NTZ. That would be for the next iteration. I would open an issue.


fix: change wrong pattern for test

I found tests of FxTs are consist of for type check and for unit test.
But all type check only tests run and are failed when I run npm test.
Your test script specified glob pattern of under /test directory. But jest does't recognize it.
So, I investigated about it. and I found an issue about this. (comment). and I referred to the comment and changed your config.
I'm still confused why jest doesn't work with your config. But I guess It's because of micromatch which is used for glob pattern.
BEFORE:
all type check tests are failed

AFTER:
all type check tests are not target.

ps. Sometimes some tests are failed because they depend on timeout api. I think it'd be nice to fix it. thx

@khg0712  Thank you for your contribution
Could you check prettier?

ps. Sometimes some tests are failed because they depend on timeout api. I think it'd be nice to fix it. thx

also registered it https://github.com/marpple/FxTS/issues/93 👍

@ppeeou I'll fix it :)

@khg0712  Thank you for your contribution
Could you check prettier?
you can try npm run prettier:fix

@ppeeou I'll fix it :)


[TODO] Clean up controlPanels/sections  and controls in superset-frontend

Part of these files are moved to @superset-ui/chart-controls but still incomplete.

superset-frontend/src/explore/controlPanels/sections.jsx -> packages/superset-ui-chart-controls/src/sections.tsx
superset-frontend/src/explore/controls.jsx -> packages/superset-ui-chart-controls/src/shared-controls/index.tsx

Diverging changes in these almost identical files have caused confusion and bugs. We should clean up the version in superset-frontend and port any subsequent changes after the file was initially copied over to sueprst-ui/chart-controls.

Hi, I would like to work on this issue, please tell me how to proceed :)

It's open for over a year; is this still relevant / anyone plans to work on it? @ktmud @Red-0111 ?

Yes, we still need to do this.  Is it on anyone's radar at the moment?

This hairball still exists. It's not a bug exactly so I'm tempted to close this (especially since it's also stale) but it's a reminder that this work still needs to be done. A LOT of work still needs to be done to clean up control panels, in fact.

@rusackas What needs to be done? I'm interested in working on this.

@rusackas What needs to be done? I'm interested in working on this.

Pretty much what the issue describes... the two files linked should be merged into the monorepo packages, rather than being a part of Superset's main codebase. The dependencies here might be fairly intricate (TBD) so I worry this will be a delicate surgery. But then again, there's probably no need to move the entire file... even moving one piece of code to the right spot is a step in the right direction.

The current files:

superset-frontend/src/explore/controlPanels/sections.tsx -> superset-frontend/packages/superset-ui-chart-controls/src/sections/sections.tsx

After glancing these 2 files, I think there's nothing more to refactor. The only duplicated bit is this:
export const colorScheme: ControlPanelSectionConfig = {
  label: t('Color scheme'),
  controlSetRows: [['color_scheme']],
};

The rest of those are different enough to justify the duplicated code.

Right... I haven't looked closely at this in forever, so I don't know all the details/difficulties of this effort, but the general idea is that ALL code related to control panels should be moved to the package(s) for maximum reusability and minimum code duplication.

This issue, and all effort behind it AFAIK, seems to have gone stale. I'll go ahead and close this out. I think it's fair to say that the control panels still need a TON of design and engineering work to make them more consistent, more sensible, more DRY, and more... modern/React-y. This seems like the job for a SIP and a whole project kanban, so I'll go ahead and close this out until there's some more significant time to dedicate to the effort.


Make error display persistent

Currently, if you evaluate a whole buffer (with 'cmd+shift+return'), and an error occurs, it's displayed in the Atom non-modal dialogue which disappears after a few seconds. It would be nice if there was a way to keep the error message persistent so I can view it as a I debug the error.

fixed in https://github.com/JunoLab/Atom.jl/pull/15

Awesome.


Add initial props watcher

Support dynamic initial values.

Pull Request Test Coverage Report for Build 62

0 of 4 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.7%) to 94.783%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/Autocomplete.vue
0
4
0.0%

Totals

Change from base Build 57:
-1.7%

Covered Lines:
158

Relevant Lines:
166

💛  - Coveralls


Attributes OnChange and OnSelect Missing for Tabs

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 52f4635c-5645-1042-20ce-dc99498e4a8b
Version Independent ID: 52f4635c-5645-1042-20ce-dc99498e4a8b
Content: Tabs or tab list modern control in Power Apps - Power Apps
Content Source: powerapps-docs/maker/canvas-apps/controls/modern-controls/modern-control-tabs-or-tabs-list.md
Service: powerapps
Sub-service: canvas-maker
GitHub Login: @yogeshgupta698
Microsoft Alias: yogupt

Thanks for your comment, @divya-akula. This issue has been assigned to the doc author for review.

@bishalgoswami  Fixed and created a pull request for the same [https://github.com/MicrosoftDocs/powerapps-docs/pull/4518] (Pull Request)


rename registry clusteroperator resource plus file renames+cleanup

add clusteroperator skeleton to our manifest so the CVO respects it
rename our manifests dir to "manifests" to align w/ other operators
remove what appeared to be some dead files

/assign @dmage @legionus @coreydaley

/hold
we'll want to see this pass e2e-aws multiple times to ensure we're not going to block the installer w/ this change

/assign @dmage @legionus @coreydaley
(bot was dead)

/refresh

/test e2e-aws

/retest

@smarterclayton @deads2k @abhinavdahiya i'm trying to add the image-registry clusteroperator resource to the manifest, but the CVO seems to be having issues picking it up:
I0204 23:47:22.558954       1 sync_worker.go:442] Running sync for clusteroperator "image-registry" (config.openshift.io/v1, 177 of 261)
E0204 23:47:23.563157       1 task.go:57] error running apply for clusteroperator "image-registry" (config.openshift.io/v1, 177 of 261): clusteroperators.config.openshift.io "image-registry" not found

E0204 23:47:48.583150       1 sync_worker.go:266] unable to synchronize image (waiting 3m19.747206386s): Could not update clusteroperator "image-registry" (config.openshift.io/v1, 177 of 261): resource may have been deleted

the CRD was defined here:
I0204 23:38:11.787638       1 sync_worker.go:468] Done syncing for customresourcedefinition "clusteroperators.config.openshift.io" (apiextensions.k8s.io/v1beta1, 2 of 261)

and other cluster operator resources are managed w/o issue:
I0204 23:47:17.932566       1 sync_worker.go:468] Done syncing for clusteroperator "kube-apiserver" (config.openshift.io/v1, 56 of 261)

and there is no sign the registry operator was actually created (would normally happen after the clusteroperator resource was created based on our resource ordering), so i don't know what else would be deleting/interacting with that resource.
the full CVO log is here:
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-image-registry-operator/189/pull-ci-openshift-cluster-image-registry-operator-master-e2e-aws/991/artifacts/e2e-aws/pods/openshift-cluster-version_cluster-version-operator-647b8f5746-tc84r_cluster-version-operator.log.gz
Is it invalid to create the clusteroperator resource before creating the operator (because the CVO is going to wait for the clusteroperator to report available before instantiating the rest of the manifest resources)?  Still wouldn't explain why it's reported as removed though..

/retest
/test e2e-aws

/retest
/test e2e-aws

/retest

@dmage @legionus @coreydaley
still needs review please

/lgtm
Only comment would be that I thought the style guide for golang package aliases was to use the last section of the import path, if that collides with something else, then go back one more section and so on and so forth until it is unique.

Only comment would be that I thought the style guide for golang package aliases was to use the last section of the import path, if that collides with something else, then go back one more section and so on and so forth until it is unique.

Assuming you mean stuff like this:
configapiv1 "github.com/openshift/api/config/v1"
I picked that pattern up elsewhere in origin (though i'm sure it's not consistent).  In general I try to name the aliases in such a way that the references in the code make sense.  (ie when you're reading the code, "configv1.Foo" doesn't tell you as much as "configapiv1.Foo" does.  And don't get me started on "v1.Foo")
Also since you can have a config client v1 and a config api v1, i didn't want to just call this "configv1" and then later when someone also imports client we'd have "clientconfigv1" and "configv1" which makes it unclear to someone reading the code who just sees "configv1" what it is.  So better to head off the ambiguity up front, imho, because no one's going to refactor configv1 to apiconfigv1 when they add clientconfigv1.
as for "apiconfigv1" vs "configapiv1", the latter reads more naturally to me (and again, is what i've seen elsewhere in origin).
tldr: i prefer readability/clarity over arbitrary style guide recommendations

Despite the fact that I agree with the reasoning, I don't like the ...apiv1 approach just because it's inconsistent with corev1 and metav1. And these values I'd like to not to change, because they are used everywhere.

Despite the fact that I agree with the reasoning, I don't like the ...apiv1 approach just because it's inconsistent with corev1 and metav1. And these values I'd like to not to change, because they are used everywhere.

we can certainly retain an exception for corev1 and metav1, I agree that I don't want to go search+replace the world.  I'm not even suggesting we go change any of our existing ones, but as I find them in files i'm working on, I try to update them.
(example of the pattern i'm trying to follow from origin:
https://github.com/openshift/origin/blob/master/pkg/api/imagereferencemutators/internalversion/pods.go#L19-L22)
(note that they used "kapiv1" for corev1 in that file, so it's all an inconsistent mess anyway:
https://github.com/openshift/origin/blob/master/pkg/api/imagereferencemutators/internalversion/pods.go#L9)

/refresh

/test e2e-aws

/test e2e-aws

/test e2e-aws

/test e2e-aws

/hold cancel


Add block data to commits

Right now the block committer only commits the block hash, but we should add for this commits also the block data, but considering the size of the block data to split in multiple commits if needed

Closing as https://github.com/FuelLabs/fuel-block-committer/pull/85 mostly solved it. Still, we only post the tx hashes from a block, but now it can do it through blobs and not only calldata. We still need to figure out what data we want to post (a decision coming mostly from the core) and how DA compression will work here.


[varLib.instancer] L4) moving the default location of an axis

Hey hey. I just wanted to bring the pending L4 feature to your attention.
I think the instancer is already a handy function and will be very useful in the future. But implementing "L4) Move the default position of an axis" is definitely something that would make the tool even more useable in the workflow.
Is anyone currently working on L4? And is there anything I can do to further the implementation efforts?

Hi, thanks for filing this

Is anyone currently working on L4?

No, I don't think so.

implementing "L4) Move the default position of an axis" is definitely something that would make the tool even more useable

could you please elaborate on that? I'm curious to understand how you'd find this feature useful for your workflow.
Among the main goals of the instancer was to produce a partial VF that contains less variation data and is thus smaller in size. Changing the default position would not necessarily yield a result that reduces the amount/size of variation data in the VF (though in some situations it may).

Hi, thanks for filing this

Is anyone currently working on L4?

No, I don't think so.

implementing "L4) Move the default position of an axis" is definitely something that would make the tool even more useable

could you please elaborate on that? I'm curious to understand how you'd find this feature useful for your workflow.
Among the main goals of the instancer was to produce a partial VF that contains less variation data and is thus smaller in size. Changing the default position would not necessarily yield a result that reduces the amount/size of variation data in the VF (though in some situations it may).

Thanks for your quick reply!

could you please elaborate on that?

Sure! Let's say I want to generate a partial variable font with an axis range that does not include the default position.
Currently, I have to do a work-around, open the Glyphs file, change the variable font origin to something within the desired range, export the variable font again, and then run instancer.AxisRange with the desired values.
Moving the default position of an axis may not change the file size, but in combination with the other functions of the Instancer, it allows you to create a larger number of subsets without having to manipulate the source file.

Thanks for your quick reply!

could you please elaborate on that?

Sure! Let's say I want to generate a partial variable font with an axis range that does not include the default position.
Currently, I have to do a work-around, open the Glyphs file, change the variable font origin to something within the desired range, export the variable font again, and then run instancer.AxisRange with the desired values.
Moving the default position of an axis may not change the file size, but in combination with the other functions of the Instancer, it allows you to create a larger number of subsets without having to manipulate the source file.

Joining here again, and bringing the already mentioned stuff from this issue over here.
"… To specify, I meant, if you subset a variable font that has 2 axes originally, but the subset will only have one of the axes, what will happen with the origin location if that one originally sits on the dropped axis? …"
As far as I see you cannot slice/subset an axis range, when the target range does not include the variable font origin, right? That’s exactly the problem. So if you have an input font with
weight 0..1000 and the origin lies on 200, it’s currently not possible to get a subset to a range of e.g. 400…1000. The instancer will just spit an error (as documented).

Joining here again, and bringing the already mentioned stuff from this issue over here.
"… To specify, I meant, if you subset a variable font that has 2 axes originally, but the subset will only have one of the axes, what will happen with the origin location if that one originally sits on the dropped axis? …"
As far as I see you cannot slice/subset an axis range, when the target range does not include the variable font origin, right? That’s exactly the problem. So if you have an input font with
weight 0..1000 and the origin lies on 200, it’s currently not possible to get a subset to a range of e.g. 400…1000. The instancer will just spit an error (as documented).

I've been thinking about this. And like to see it happen. Solving the general-case can be a bit hairy to think about. But I think is doable.
I looked at the instancer code. Currently, using the following function, it splits desired subset designspace into axes that got "pinned" and those that remain a range:
def splitAxisLocationAndRanges(axisLimits, rangeType=AxisRange):
    location, axisRanges = {}, {}
    for axisTag, value in axisLimits.items():
        if isinstance(value, rangeType):
            axisRanges[axisTag] = value
        elif isinstance(value, (int, float)):
            location[axisTag] = value
        elif isinstance(value, tuple):
            axisRanges[axisTag] = rangeType(*value)
        else:
            raise TypeError(
                f"Expected number or {rangeType.__name__}, "
                f"got {type(value).__name__}: {value!r}"
            )
    return location, axisRanges

to support L4, we would allow an axis to be returned in both of those sets, both as "pinned" to new default, as well as carrying a range.
Then we need to update the entire code for that change.
A utility function which I thought of, that might make the code easier to navigate and understand, is a function that then takes the output of the above function as well as a delta+support, and returns a list of delta+support, as well as the "bias" to add to the value being variated.  This is similar to limitTupleVariationAxisRange, but can be written more generally and reused.
Perhaps those should be added right into varLib.models.

Hey @behdad. This is good news. Thanks for doing the research and thinking about the implementation. Excited to see it happen!

Hey @behdad. I was wondering if there is news on the implementation of L4?

Hi @KatjaSchimmel. I won't have the time or focus to do this myself. But I've pinged a couple people who might be able to help.

thanks you!

Hi! It's me again. Just checking in if there is news on L4 support? I still think it would be a very helpful function.

Has anyone been able to take this on?

As far as I know no one is looking into it.

I'm working on this in https://github.com/fonttools/fonttools/pull/2728

I think my work is ready. Take it for a test drive and let me know!
Word of caution: changing default of multi-axis variable fonts can result in font size blowup...
https://github.com/fonttools/fonttools/pull/2728

hey @KatjaSchimmel, would you like to test @behdad's implementation of L4 instancing? You could install fonttools from that git branch directly using pip:
pip install -e git+https://github.com/fonttools/fonttools.git@instancer-l4#egg=FontTools
Or you could git clone fonttools, switch to instancer-l4 branch and install from there.
Let us know thanks!

@anthrotype I'm really excited to run a test and will hopefully get to it next week. 🤞 Thanks for the additional info on how to test

This is merged now!


Tags for Asset and AssetRegistry

Ability to tag asset, and query asset registry by tags, allowing simple single tag searches, as well as more complicated AND/OR scenarios.
TagsCache is internal class used by AssetRegistry, and will be used by Scene to tag entities.
It takes benefit of provided key index, to build internal indexes for making find queries fast and efficient.

Looks good to me apart from the minor comments I had. :)


Optionally allow JSON encoding in user register/login

Enables JSON encoding of requests and responses for user register/login operations.
Useful for integration with external authoritative user accounts systems that have no or limited support for Protobuf.

@zyro Verified with:
curl -u "defaultkey:" -H 'Content-Type: application/json' -H 'Accept: application/json' -X POST http://<IP_ADDRESS>:7350/user/register -d '{"device": "blahblahblahblahblah"}'

And:
curl -u "defaultkey:" -H 'Content-Type: application/json' -H 'Accept: application/json' -X POST http://<IP_ADDRESS>:7350/user/login -d '{"device": "blahblahblahblahblah"}'

Looks good 👍


Ability to supply another signature header like Signature

Draft 2 has introduced support of the Signature header.
A new 'sign_header' optional parameter has been added to HeaderSigner
and HeaderVerifier.

You pull request contain quite a lot of what appear to be irrelevant whitespace changes to the code.  Could you perhaps reduce the pull request to only the changes relevant for the feature you implement?

Done.

Any news?


does not open the modal

Hello,
I am having a new issue with the package as I deployed it but when the application opens it is not showing the update modal, even though it should.
I appreciate the information,

same issue
my widget:
`  AppUpgradeAlert(
navigatorKey: Grock.navigationKey,
      appUpgrader: Upgrader(

languageCode: 'tr',
debugLogging: kDebugMode,
showIgnore: false,
countryCode: 'tr',
          dialogStyle: Platform.isIOS
              ? UpgradeDialogStyle.cupertino
              : UpgradeDialogStyle.material,

          canDismissDialog: false,
          appcastConfig: AppcastConfiguration(supportedOS: ['android','ios']),
          messages: UpgraderMessages(code: 'tr'),

minAppVersion: '2.0.2',
          shouldPopScope: () => false,
          showLater: false),
      child:

Scaffold...
`
and debug results:
I/flutter (12954): AppUpgrader: instantiated.  I/flutter (12954): AppUpgrader: instantiated. I/flutter (12954): AppUpgrader: build AppUpgradeAlert


To fix: JavaLayerConfigurationsHelperTest

Description of the issue: Test failure
Expected behavior: Test success
Steps to reproduce:
cd jib-maven-plugin
./mvnw verify -Pintegration-tests

Environment:
Linux rodete
Log output:
[INFO] Running com.google.cloud.tools.jib.plugins.common.JavaLayerConfigurationsHelperTest
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.004 s <<< FAILURE! - in com.google.cloud.tools.jib.plugins.common.JavaLayerConfigurationsHelperTest
[ERROR] testFromExplodedWar(com.google.cloud.tools.jib.plugins.common.JavaLayerConfigurationsHelperTest)  Time elapsed: 0.004 s  <<< FAILURE!
java.lang.AssertionError: expected:<[/usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/META-INF, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/META-INF/context.xml, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/Test.jsp, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/WEB-INF, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/WEB-INF/classes, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/WEB-INF/classes/empty_dir, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/WEB-INF/classes/package, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/WEB-INF/classes/package/test.properties, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/WEB-INF/lib, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/WEB-INF/web.xml]> but was:<[/usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/META-INF, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/META-INF/context.xml, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/Test.jsp, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/WEB-INF, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/WEB-INF/classes, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/WEB-INF/classes/empty_dir, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/WEB-INF/classes/package, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/WEB-INF/classes/package/test.properties, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/WEB-INF/lib, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/WEB-INF/web.xml, /usr/local/google/home/qingyangc/clones/jib/jib-maven-plugin/target/test-classes/exploded-war/file]>
	at com.google.cloud.tools.jib.plugins.common.JavaLayerConfigurationsHelperTest.assertLayerEntriesUnordered(JavaLayerConfigurationsHelperTest.java:42)
	at com.google.cloud.tools.jib.plugins.common.JavaLayerConfigurationsHelperTest.assertSourcePathsUnordered(JavaLayerConfigurationsHelperTest.java:47)
	at com.google.cloud.tools.jib.plugins.common.JavaLayerConfigurationsHelperTest.testFromExplodedWar(JavaLayerConfigurationsHelperTest.java:72)

I think I hit this. Do mvn clean and try again.

Ah okay, that did the trick - I guess it was just leftover build files interfering with the test. I noticed in that test, it creates a directory in the exploded-war build output directory. I think we should keep tests hermetic and use temporary directories with the test files copied into them.


Test codes compatible with Agorav0.30.0

Hashing with Channel ID

Typo: ChainID

Typo: ChainID

Thank you.


Fix default font directory list on MacOS Catalina

After I upgraded to MacOS Catalina, I've noticed that Arial fonts could not be detected anymore. I've figured out that Arial and some other font were moved to /System/Library/Fonts/.
I don't know whether it is a proper fix, but it solved the issue for me.

Thank you, @korya! This looks good to me.
Adding a new directory to the font directories list cannot cause any harm, I guess.


Add the float version of slidedown/up instructions.

Ref: https://github.com/riscv/riscv-v-spec/issues/236#issuecomment-507997226
I had used the slidedown/up instructions in a loop, the are some extra costs for float-to-int conversion.
If there is no extra work to have the float version of slidedown/up, please make both float and int version of slidedown/up.
@aswaterman @kasanovic

Here is my use case.
I try to compute a serial of fp32 values, and push them into a vector register.
If the loop number becomes bigger, the cost of "fmv.x.s" will be a problem.
loop:
    .... // a complex formula for fp32_vlaue
    fmv.x.s int_value, fp32_value
    vslide1down.vx v0, v0, int_value
    ....
end_loop:

Irrespective of whether we add the float version, the code example given would generally run much faster and lower energy if you were to do scalar stores into a memory buffer, then do a single vector load to bring into vector register file.  Every vslide1down has to read and write the entire vector register VLMAX times, i.e., O(VLMAX^2) operands moved, whereas using a memory buffer only writes and reads each element once from RAM and once into a vector register, i.e., O(VLMAX) operands moved.

Asking TG opinion.

The most significant use case is when XLEN < FLEN.  (RV32 and D float).
The transfer to integer to vector register is not possible.
However, I would prefer scalar vslide1down.vs vslide1up.vs to vslide1down.vf
The float to scalar can be fused with the vslide1.

Asking TG opinion.

@kasanovic
Any update for float version of slidedown/up?

@JerryShih added.


Density compensation

This refactors and augments the density compensation routines.

:heavy_check_mark: density is now a proper module, at the same level as operator and trajectories.
:heavy_check_mark: Added new "cell counting" method, which is purely geometric, and runs fast enough in 3D.
:warning: Pipe's method implementation with cufinufft has been removed (too hacky, and we want to follow the main branch of (cu)finufft).
:rocket: There is tests!
:eyes:  Density compensation methods all have the same signature density_method(traj, shape, **kwargs).

Not considered in this PR:

Adding more density compensation method. Radio-astronomy have a lot of methods to consider and their naming can be confusing^1
Registering all the density compensation methods (like we do for the operators, for now we only have 3)

Good job @paquiteau

I dont get the last point in your PR description, we technically have the same interface for density estimation?

By registering, I meant to have something to collect all density compensation methods and  then do a
get_density("cell_count")(traj, ...)


Complete the "binary" documentation such that anybody can write a "wrapper"

Right now, inputmodule-rs is a python + rust project. Great for command line, not so great for developers who wish not to touch either language.
Good news is that there is some binary level documentation available here: https://github.com/FrameworkComputer/inputmodule-rs/blob/main/commands.md
However, it is currently incomplete.  Things like how the bytes are oriented for images (left to right then down, or up to down then left to right?), how to make a custom animation, etc. This would be useful for developers who wish to make their own "wrapper" (like a C/C++ wrapper, or somebody wants to write everything in Java) and would not need an external dependency.

For anybody who stumbles on this issue and is also wondering how the DrawBW call works.
As @DesiOtaku pointed out, the byte orientation is not immediately obvious; if you write a loop which sets every bit one by one, the activated pixel will first move right to left, after which it suddenly jumps to the next line. The location where this occurs is not the same on each line either, which makes it tricky to figure out what is going on.
There are two things which cause confusion here:

The LED Matrix is a 34x9 grid, while the DrawBW call accepts 39 bytes (i.e. 39x8 bits) of data. Thus, the dimensions of both "grids" don't match. The real grid has a width of 9 while the binary grid has a width of 8.

If you do the loop experiment I mentioned above, you will notice the "jump" to a new line always occurs on a multiple of 8.

The bits in each byte are read right-to-left instead left-to-right. Thus, setting the first bit will activate the 8th pixel on line 0 of the LED matrix.

Once you know these two things, you can figure out how to map a {x, y} coordinate on the LED matrix to a {x, y} coordinate that identifies which bit you need to set:

"Flatten" the coordinate in the LED Matrix 34x9 grid to an offset in an array:

offset = y * 9 + x

We can now do the inverse and turn this offset into an {x, y} coordinate where y represents the byte to modify and x represents the bit in the byte to modify.

y = offset % 8
x = 7 - (offset % 8)

For drawing black and white, I think it's helpful to imagine the LED matrix as a list of 306 pixels that are turned on or off with a list of bits. After turning the bits into bytes, we can send those bytes to the LED module:
def black_white_draw_pixels(dev):
    """ Use a list of 306 bits to draw a pattern of black and white pixels on the LED module."""

    # Each bit represents the state of an LED (1 is on, 0 is off)
    bits = [
            0, 0, 0, 0, 1, 0, 0, 0, 0,
            0, 0, 0, 1, 0, 1, 0, 0, 0,
            0, 0, 1, 0, 0, 0, 1, 0, 0,
            0, 1, 0, 0, 0, 0, 0, 1, 0,
            1, 0, 0, 0, 0, 0, 0, 0, 1,
            0, 1, 0, 0, 0, 0, 0, 1, 0,
            0, 0, 1, 0, 0, 0, 1, 0, 0,
            0, 0, 0, 1, 0, 1, 0, 0, 0,
            0, 0, 0, 0, 1, 0, 0, 0, 0,
            0, 0, 0, 0, 0, 0, 0, 0, 0,

            0, 0, 0, 0, 0, 0, 0, 0, 0,
            0, 0, 0, 0, 0, 0, 0, 0, 0,

            0, 0, 0, 0, 1, 0, 0, 0, 0,
            0, 0, 0, 0, 1, 0, 0, 0, 0,
            0, 0, 0, 0, 1, 0, 0, 0, 0,
            0, 0, 0, 0, 1, 0, 0, 0, 0,
            1, 1, 1, 1, 1, 1, 1, 1, 1,
            0, 0, 0, 0, 1, 0, 0, 0, 0,
            0, 0, 0, 0, 1, 0, 0, 0, 0,
            0, 0, 0, 0, 1, 0, 0, 0, 0,
            0, 0, 0, 0, 1, 0, 0, 0, 0,
            0, 0, 0, 0, 1, 0, 0, 0, 0,

            0, 0, 0, 0, 0, 0, 0, 0, 0,
            1, 0, 0, 0, 0, 0, 0, 0, 1,
            0, 1, 0, 0, 0, 0, 0, 1, 0,
            0, 0, 1, 0, 0, 0, 1, 0, 0,
            0, 0, 0, 1, 0, 1, 0, 0, 0,
            0, 0, 0, 0, 1, 0, 0, 0, 0,
            0, 0, 0, 1, 0, 1, 0, 0, 0,
            0, 0, 1, 0, 0, 0, 1, 0, 0,
            0, 1, 0, 0, 0, 0, 0, 1, 0,
            1, 0, 0, 0, 0, 0, 0, 0, 1,

            0, 0, 0, 0, 0, 0, 0, 0, 0,
            0, 0, 0, 0, 0, 0, 0, 0, 0
          ]

    bytes = bits_to_bytes(bits)
    send_draw_command(dev, bytes)

If you define the bits like this, you can actually see the patterns in the code that will end up on the LED matrix.
Here's the rest of the code:
def main():
    print("Start of program")
    black_white_draw_pixels("/dev/ttyACM0")
    print("End of program")

def bits_to_bytes(bits):
    """Convert a list of bits to a list of bytes."""
    import math
    nr_of_bytes = math.ceil(len(bits) / 8)
    bytes = [0x00 for _ in range(nr_of_bytes)]

    for bit_index, bit in enumerate(bits):
        byte_index = int(bit_index / 8)
        bit_index_within_byte = bit_index % 8
        if bit:
            # Set the byte's bit to one at bit_index_within_byte
            bytes[byte_index] |= 1 << bit_index_within_byte

    return bytes

def send_draw_command(dev, bytes):
    """Send a draw command to the LED module that turns LEDs on or off.

    The draw command (0x06) requires 39 bytes to be sent to the module. With a 34x9 matrix, we need 34*9 = 306 bits to represent the individual LED's state (on or off). 306 bits fit into 39 bytes: 306/8 = 38.25.

    The bits in those bytes represent the state of the individual LEDs on the module. The first bit represents the top left LED, the second bit the LED to the right of it, and so forth. The 10th bit represents the LED in the second row, first column, and so forth.
    """
    draw_cmd_byte = 0x06
    send_command(dev, draw_cmd_byte, bytes)

def send_command(dev, command, parameters=[], with_response=False):
    """Send a command to the device. Opens a new serial connection every time."""
    fwk_magic = [0x32, 0xAC]
    return send_command_raw(dev, fwk_magic + [command] + parameters, with_response)

def send_command_raw(dev, command, with_response=False):
    import serial

    """Send a command to the device. Opens a new serial connection every time."""
    try:
        with serial.Serial(dev, 115200) as s:
            s.write(command)

            # Response size from here:
            # https://github.com/FrameworkComputer/inputmodule-rs/blob/main/commands.md

            response_size = 32
            if with_response:
                res = s.read(response_size)
                print(f"Received: {res}")
                return res
    except (IOError, OSError) as _ex:
        disconnect_dev(dev.device)
        print("Error: ", ex)


Update Glibc to 2.23

Branch: https://github.com/NixOS/nixpkgs/tree/glibc-2.22
Will set up a Hydra jobset.

The locale problems when mixing versions should be no longer fatal, after a patch we had, right?

Yeah (and 2.22 contains that patch).

@vcunat @edolstra
fyi, 2.23 was just released.
https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;utm_source=anzwix;h=c0276cf81b7e838becaa252c09d3900cce6cd277;hb=refs/heads/release/2.23/master

Shall we skip to 2.23 then, even for 16.03? Assuming the new unicode support won't break locales again, I wouldn't expect compatibility problems.

2.23 builds for me now.

I guess we need to decide whether we want the bleeding edge or not :-) I guess I could fire off a jobset to see how much breakage 2.23 causes.
Meanwhile, there is a jobset for 2.22: http://hydra-test.nixos.org/jobset/nixpkgs/glibc-2.22. (This is also a test of the new Hydra queue runner that uploads build results directly to an S3 binary cache. The cache is http://nix-test-cache.s3.amazonaws.com/, public key test.nixos.org-1:pjXm8QJl1Gsxfxjpe+R9acIs5kNvW1lIS/i/bAFnHgM=).

I've got all my system running on 2.23 (+closure-size, coreutils and other stuff), and I see no problems. Maybe it is rather new to get into 16.03, I don't know. /cc also @domenkozar

I see no problem going to 2.23 given that hydra builds all of the packages and proves most of them build :) But there's left than a week to test that.

@vcunat I see you merged 2.23, but it does have a bunch of new build failures: http://hydra-test.nixos.org/eval/2#tabs-now-fail

(And that's just the 2.22 -> 2.23 build failures, not 2.21 -> 2.22.)

I somehow didn't notice that jobset (or forgot it), but there's no mass breakage. Most of this seems due to webkitgtk, and it looks like it shouldn't be too hard to fix by some patch. I'll look into that.

Yeah, most of it looks pretty simple (some errors about isnan not being found, probably due to some increased header strictness).

The relevant ticket, most likely: https://sourceware.org/bugzilla/show_bug.cgi?id=19439

Aha, we might want to patch glibc instead by https://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=3c47c83a9730c20e602694505b9278c25637b0d0;hp=1233be76694ca81454f61e2ba5a2fb5830840191

Ignore the above comment. (That patch is actually contained in 2.23.)
The situation with 2.23 and isnan is unclear to me. I suppose it will be better to choose 2.22 for the upcoming release. Shall I revert 59617de6d7f8a on staging?

Let me ask upstream at least, as this part of the regression still seems to be without any response: https://sourceware.org/bugzilla/show_bug.cgi?id=19439#c8

ATM it looks most likely that a majority of the new failures was just glibc exposing non-conforming c++ header usage, as only std::isnan is normally (guaranteed to be) put into scope.

I think all the larger breakages due to glibc 2.22 -> 2.23 should be fixed in master now (libreoffice, webkitgtk, libksysguard). Only a couple individual packages aren't, and I'll leave them broken ATM.


Stop warning about protected (maybe even private) access modifiers

Since access modifiers are typescript only and provide no restrictions for Aurelia or at runtime, it seems (to me at least) that there shouldn't be warnings about them. Or at least a configuration option to turn them off.
As an example I often use protected as a modifier for things I want the view/template from having access to, but if someone were to get access to the VM directly I wouldn't want them to have access to (or at least it pollutes the api with things specific only for the view/template).

config.aureliaBindingAccessOpts.restrictedAccess = [];

https://github.com/MeirionHughes/aurelia-template-lint/blob/develop/source/config.ts#L142

@MeirionHughes doh -- sorry about that :(

Don't worry about it. :)


Using this addon inside of an engine causes Route to be reopened twice

When this addon is used inside of an engine, it's initializer is run twice, once for the parent app and once for the engine. This results in all of the hooks being fired twice.
For example, the queryParamsDidChange hook will run twice every time a query param changes.
I can create a demo app if you'd like.

That makes sense. @HeroicEric I'll investigate further. PR is always welcome 😄


Adding comments on the use of the lms_sign function

Adding comments to the lms_sign function to clarify that this function is only used as a convenience and the reuse of a Q value is only for testing purposes.  Real images should be signed by a FIPS certified HSM.

Closing this PR as this is addressed by: https://github.com/chipsalliance/caliptra-sw/pull/861


fix: add missing gcp api gateway services to gcp cloud project.go

Description
I am assuming based on the documentation we should be activating the correct services for GCP for API Gateway. I couldn't from a fresh nitric project generation access the API Gateway dashboard as we are missing dependant services not being applied during the nitric up command.

fixes https://github.com/nitrictech/nitric/issues/658
Link to docs - api gateway and cloud run

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Testing
Not sure how to test and run the project <---- needs a second pair of eyes :)

@algoflows if you've got all the right tooling installed, you should be able to run make install in the cloud/gcp go module. If this runs successfully you should get a<EMAIL_ADDRESS>provider installed on your local machine which you can reference in your stack file to run it.
Let us know if you have any issues building the project. Will also test this out myself on a new GCP project.

Tested today in a new project - prior to this change the API UI looks like this:

After the change the two additional services are enabled as expected.


Proxies

Do I have to write what type of proxies im using before putting them ?
And can I use public ones ?
Https/http or socks4/5 ?

Right now only HTTP proxies are supported. Going to add support for others soon.

Thank you!


Bad link in EN FAQ to #voluntary_self_quarantine

Where to find the issue
https://www.coronawarn.app/en/faq/#red_card_how_to_test "Red Card? How to go through Corona testing"
Describe the issue
Clicking on the link Why is voluntary self-quarantine recommended? fails to open the expected article using the Firefox browser.
Firefox attempts to open https://www.coronawarn.app/en/faq/#voluntary_self_quarantine  and instead of going to the intended article it goes to the top of the page https://www.coronawarn.app/en/faq/#.
There is an extra space (%20) in the hyperlink.
Steps to reproduce
Manual check
In Firefox:

Open the FAQ article https://www.coronawarn.app/en/faq/#red_card_how_to_test "Red Card? How to go through Corona testing"
Click on the link "Why is voluntary self-quarantine recommended?"
Note that the browser shows "Frequently Asked Questions about the Corona-Warn-App" instead of the article "Why is voluntary self-quarantine recommended?"

Cypress automated check
Execute

npm run test:open
In Cypress console
select "Firefox 97"
click check_anchor_links.js

Note test failure in /en/faq
Syntax error, unrecognized expression: #voluntary_self_quarantine%20

Suggested change
Remove extra space in
https://github.com/corona-warn-app/cwa-website/blob/fcefdbe3bc60469a9a00d32beb7e2d3e6a2e07df/src/data/faq.json#L1263

@MikeMcC399 Thanks for reporting and fixing!

@dsarkar
You're welcome! I checked on production and the error no longer occurs since PR #2477 was merged.
It would be good if the Cypress tests could be run regularly, for both Chrome and Firefox. This bug has existed since the text was created mid December 2021 through PR https://github.com/corona-warn-app/cwa-website/pull/2188. I only caught the issue when I was checking if Cypress could be updated to the latest version if necessary when I manually executed both:
npm run test:chrome
npm run test:firefox

and I discovered that chrome passed and firefox failed.

@MikeMcC399 Maybe we should add that to README.md

@dsarkar

Maybe we should add that to https://github.com/corona-warn-app/cwa-website/issues/2476#readme

Good suggestion. I opened https://github.com/corona-warn-app/cwa-website/issues/2478 so this can be discussed separately.


test/bpf: Fix XDP loading in verifier-test.sh

Running test/bpf/verifier-test.sh on net-next kernels fails with the following error:
Tail call map owned by prog type 3, but prog type is 6!

This happens because the verifier compares the type of the BPF program that created each pinned map to the type of the new program that is trying to use those maps. It errors if the two types (original map creator vs. map user) don't match. Since previous loaded programs are of TC type, we need to remove all maps before creating them again from XDP programs.

retest-runtime


Possible packaging problem with zip and title case

I have a plugin like: $:/plugins/MAS/DynaNotator
When I exported this via zip, all of the tiddler files went into

mas/

But the tiddlywiki.info file went into

MAS/

On Windows these two might have been combined, but on Linux (and Mac, no doubt) they are two separate things.
Gatha 0.9.0

Hi Mark,
I investigate to see what is the problem. I am not sure if I used any name conversion (like convert to lowecase or not).
I will look in to in this weekend.

Many plugins use lowercase only. But I don't know if that is a rule.

Many plugins use lowercase only. But I don't know if that is a rule.

I do not think it is a rule! One question: the tiddler name seems works fine, the created plugin also works fine, but I see you like to have the same folder, file name ( with the same uppercase/lowercase)

Hi Mark,
I went into the code, the reason is using slugify operator. It converts all uppercase into lower case.
So, may be Jeremy can explain what is the reason to use lowercase when slugify!


fix: Update Scroll constructor call

"The Best in Asia comp modal doesn't appear to be working for me and some others around"
It was introduced here:
https://github.com/lonelyplanet/rizzo-next/commit/d55f42579ad55fe19ea6f84c4dbe738b2e8107ae#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R69
Scroll constructor changed:
https://github.com/mkay581/scroll-js/commit/1e642327b91f740316bd78c1e20ebc0d4cde7632
and this:
https://github.com/lonelyplanet/marketing/blob/master/app/pages/best_in_asia/index.js#L45
https://github.com/lonelyplanet/rizzo-next/blob/master/src/components/scroll_to/scroll-to.js#L13
is throwing:
Uncaught Error: Scroll error: element passed to Scroll constructor must be a DOM node, you passed [object Object]!
preventing Modal constructor from being called:
https://github.com/lonelyplanet/marketing/blob/master/app/pages/best_in_asia/index.js#L55
and detaching modal:
https://github.com/lonelyplanet/rizzo-next/blob/master/src/components/modal/modal_component.js#L24
so it's covering "ENTER COMPETITION" button, you can't click it (see attached image).


improv: toggle time display on click from remaining / not remaining

Discussion: https://github.com/muxinc/media-chrome/discussions/181

[x] updates <media-time-display> behavior so that it toggles on click between current / remaining
[x] handles keyboard interaction with Enter & Spacebar
[ ] Do we need cursor: pointer: here? What's the best place to put that style rule?
[ ] What's the right conventional commit here? improv: ? fix: ?

I'd go with fix: for this change, in the <v1.0.0 state.
cursor: pointer could be an inline style on the span since it's in the shadow DOM


Update CLI-for-JFrog-Lifecycle.md

Edited the English, as requested by @eyalbe4. Also made specific reference to RBv2 in the text.

[ ] All tests have passed. If this feature is not already covered by the tests, new tests have been added.
[ ] The pull request is targeting the dev branch.
[ ] The code has been validated to compile successfully by running go vet ./....
[ ] The code has been formatted properly using go fmt ./....

I have read the CLA Document and I hereby sign the CLA


Error in loadNamespace(x) : there is no package called ‘whitening’

Hello,
i am following the template example and trying to run analysis but i got the following error
PolarTraits <- ConvertToPolar(dfnames = traits,
                         snpid = "snpid",
                            whiten = TRUE,
                             LDcorrect = FALSE)

[1] "number of SNPs used for cov: 71"
Error in loadNamespace(x) : there is no package called ‘whitening’
Note that i have installed and re-installed the lasted version of PolarMorphism. I wonder why this is happening.
Thanks!

Hi Lydiamli,
Is the whitening package installed? You can check this by running library(whitening) (which will attempt to load the whitening package).


Popover tour: prototype for an example

Note: Please transform - [ ] into - (NA) in the description when things are not applicable
Related issues
Tried a different approach from #607.
Description
Trying a way to develop the popover tour using Popovers.
It's missing much a11y and design features, this PR is just to show a draft and see the contraints on this implementation compared to modals.
Some things might be hardly homemade for time reasons.
Some basic things seems to be missing from the bundle such as focustrap and backdrop.
This solution looks far from ideal because:

Reusability: Should we implement a component ?
Refreshing the page leads to regenerate all the mechanism: Should we introduce a localStorage or a way to deactivate it when not needed ?
Uses much js: 3 steps need ~100lines of js
More ...

Motivation & Context
See if the tour is feasible using only Popovers.
Types of change

New feature (non-breaking change which adds functionality)

Live previews

https://deploy-preview-2190--boosted.netlify.app/docs/examples/popover-tour
https://deploy-preview-2190--boosted.netlify.app/docs/examples/popover-tour-backdrop

Checklist

Contribution

[x] I have read the contributing guidelines

Accessibility

[x] My change follows accessibility good practices; I have at least run axe

Design

[x] My change respects the design guidelines defined in Orange Design System
[x] My change is compatible with a responsive display

Development

[x] My change follows the developer guide
(NA) I have added JavaScript unit tests to cover my changes
(NA) I have added SCSS unit tests to cover my changes

Documentation

[ ] My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

[ ] My change introduces changes to the migration guide
[ ] My new component is well displayed in Storybook
[ ] My new component is compatible with RTL
[ ] Manually run BrowserStack tests
[ ] Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
[ ] Code review
[ ] Design review
[ ] A11y review

After the merge

[ ] Manually launch Percy tests

Just a list of some questions/comments/suggestions/etc:
First; great work!

Since it's supposed to be a tour, should we allow users to interact with any element in the page or should it be restricted to elements inside the tour?
I am still strongly in favor of localStorage to keep a trace of the last step seen by the user, if the tour was completed or not, etc.
Is it possible to use sanitizeFn instead of sanitize to create a specific configuration for tgis component and have no impact for user not using it?
Is it supposed to be a guided tour of Boosted (for a new version maybe?) or a whole new component available in our framework? If the goal is to make a component what are the options to provid a simple and easily customisable way to do it? I had one idea in mind: making a json template with multiples entries, each entries having a guided tour step id, the id of the HTML element related to this popover and lastly the content of the step itself. Then our JS file will contain JSON.parse() method to construct the tour.
I would also add that I have tons of questions regarding the accessibility of popovers for guided tour.


Switch MirrorManager unregistering to use a heartbeat

Feature request
Description
Change the way MirrorManager objects unregister from the Schedule node from using an explicit unregister service to instead using a heartbeat to signal presence.
See this comment for details.
Implementation considerations
DDS heartbeats seem reliable enough to support the proposed approach.
Alternatives
Stick with the unregister service client, which requires managing a client and relies on the object destructor being called while the client is valid.

This is effectively fixed by #86 where queries will be periodically cleared out if they're not in use anymore.


Rework configuration

CONFIG is now a global of the ConfigFile class
This change obviously has major ramifications
all over, but the big one is that it is now
shared state amongst all threads. gets/puts
must be limited!
Several other global fixes
ConfigFile class is now in a separate module
Configuration defaults are now in the code rather
than the bundled file which means the bundled
config.ini is pointless.
Switched from configparser to Qt' QSettings.
This change has several big advantages, the biggest
being that it is platform aware so that settings
are now sitting in a globally available space
rather than inside the application
ConfigFile now has locks around variable updates
so should be much more thread-safe. Locks are
implemented using threading.RLock rather than
QReadWriteLock because the latter is not
re-entrant. :(
Several default paths and UI bits have been
cleaned up/made more sane
Active/Passive in the UI changed to Oldest/Newest
Fix invalid httpdir crash as well as create it
if it doesn't exist (e.g., if tmpdir gets wiped)
Settings-wise, a quick pass at trying to group things more
logically.  This one will likely need to be revisted.
Hard-coded the handler to 'serato' to prepare for the
eventual Mixxx support.

Argh. Just realized I forgot to fix the docs for this change.  From an end user perspective, the big one is that the text file no longer has to be pre-created in order to be picked when 'Browse for file' is used.

I see a few other issues. Pulling this one back for now.


FixFix Bug when grouping has same grouping set

fix sql like select a from t1 group by grouping sets((a),(a));

run buildall

run buildall

run buildall


Fix logic for using Authenticate and Continue when on Windows Auth Broker

Need to support:

WIndows Store 8.1
Windows Phone 8.1 (Silverlight)
Windows Phone 8.1 (Jupiter)
Windows 10

Validate that Cordova can support WP8.1/Jupiter.

@adrianhall Do we continue to support SSO in Cordova Windows apps?

Yes.  The future of WWA (Windows Wep App) is through cordova support, so we definitely want to support anything that we did in WinJS, which includes SSO.


Install Movement CLI page link and docs info

@Rahat-ch @PrasoonPratham I'm getting ready to update the docs relating to Aptos CLI so they are relevant to the changes to Movement CLI (which replaces Aptos CLI).
On this page I see a link to Install Aptos CLI but the link goes to https://docs.movementnetwork.xyz/.

Do you have a page in mind, or is there one on the docs site already, for installing Movement CLI? I'm not quite sure where to update installation instructions.

If you're not sure where it would go, may I suggest a Developer Tooling section?

Or if you prefer to make the updates, basically the Movement CLI crate is at

https://github.com/movementlabsxyz/aptos-core/tree/movement/crates/aptos
for developers who want to dive into the source code
and the syntax is changed as follows:
Wherever you have the aptos command in Aptos CLI, simply substitute movement for it, in the docs.
So aptos move build becomes movement move build.
This is different than the old Movement CLI, where you would use movement aptos move build because both Aptos and Sui CLI were embedded into that one Movement CLI.
Movement CLI now is focused on supporting Aptos Move exclusively at first, hence removing the need to specify aptos in specific CLI commands.

To install Movement CLI, clone the movement branch of https://github.com/movementlabsxyz/aptos-core/ and cd into it.

Then run cargo build -p movement.
This generates the target/debug/movement executable, which you can copy into your bin or add it to your PATH depending on your system config.
Example of copying movement to bin on Mac or Linux:
sudo cp target/debug/movement /usr/local/bin/

Hope this helps. Please let me know if you'd like me to add any of it anywhere specifically in the docs.

This link was supposed to go to the Aptos CLI installation instructions. Going forward we can have an installation instructions on this page itself with the new movement CLI.

Ok so I can add the installation instructions under the Aptos heading there?

Yeah that would be perfect. Let’s also clarify the movement CLI is analogous to the Aptos CLI and Sui is under development.

Alright, submitted here: https://github.com/movementlabsxyz/movement-docs/pull/18


gprof2dot: Add new package

gprof2dot is a Python script to convert the output from many profilers
into a dot graph.

Ok, switched to fetchFromGitHub as suggested by @edwtjo.

All good


SAK-43801 Added Arabic translation (35%)

Since this is not a close 100% does it make sense for it to go to the legacy-language-packs?

This is a new contribution, this is a request from the new maintainer, they want to see the translation progress in master to demo Sakai to some Arabic institutions, important in terms of Marketing.

Agree, this is great progress, it seems like they are rapidly headed to full coverage

They went from 35% to 42% so they are very constant.
https://www.transifex.com/apereo/sakai-trunk/


Bad initialization of dx0 in the forward pass

The gap f0 should be used to initialize the first dx0, rather than force it to be dx0 = 0. In practice, f0 should be equal to the difference of the initial constrained state x0 (provided during the creation of the shooting problem) and the first state of the warm state trajectory, provided during the ddp->solve.

@edantec -- Nicolas explained the solution, could you provide a PR with this work?
If so, note that you will need to review:

SolverDDP
SolverFDDP
SolverKKT
and check that the unit-tests are passing.

@edantec, @proyan and @nmansard
I review a second time the code for both: DDP and FDDP, and I conclude that we don't have this issue. I mean the solvers are properly handling the initial condition. Let me to explain it as easy as possible.
However, before starting the explanation, we need to say that dx has T length (not T+1 length). In practice means that dx0 isn't associated to the initial condition, instead it's associated to the first equality condition (dynamic condition). Note that we don't need to allocate another dx for the initial condition in any of the solvers.
DDP solver*
In this case, we already know that the first forward pass will close the gaps. To ensure this, I have defined the xs_try with the initial state (https://github.com/loco-3d/crocoddyl/blob/devel/src/core/solvers/ddp.cpp#L43). And this is needed for running the forward pass (i.e. dx0 = x0 - xs[0]) as you can see in https://github.com/loco-3d/crocoddyl/blob/devel/src/core/solvers/ddp.cpp#L250.
*FDDP solver
If the user provides an infeasible warm-start for the initial condition, then the FDDP solver accounts it during the calculation of the gap f0 (https://github.com/loco-3d/crocoddyl/blob/devel/src/core/solvers/ddp.cpp#L156) (as well the DDP solver). Then the forward pass will close the gaps as much as defined by the step length (https://github.com/loco-3d/crocoddyl/blob/devel/src/core/solvers/box-fddp.cpp#L98).

Do you agree with me?

I will close this issue.
Feel free to re-open if that the case.


UX - behave like normal input when getting focus

This is not a bug and I'm sure if every one agree, but there is two things I think it would be more user friendly:

When gettting focus through tab key, all content could be selected as a normal input field.

When getting focus through mouse click, cursor could stay near the character that received the click.

Changes shipped in 3.14.0


Added mailing list info and a Code of Conduct

Coverage remained the same at 68.73% when pulling 928330d29b1cbb78ca7a71c8dbfb34531fe049dc on feature/mailing-list into 724f4a240a0d9213a59b8803cf2c272d4334929d on master.

Coverage remained the same at 68.73% when pulling e63b332ed730d471e48e4f856405b23a98080c51 on feature/mailing-list into 724f4a240a0d9213a59b8803cf2c272d4334929d on master.