bad uri.scheme. don't know how to resolve.

Please answer these questions before submitting your issue.
Should this be an issue in the gRPC issue tracker?
Create new issues for bugs and feature requests. An issue needs to be actionable. General gRPC discussions and usage questions belong to:

grpc.io mailing list
StackOverflow, with grpc tag

Please don't double post your questions in more locations, we are monitoring both channels and the time spent de-duplicating questions can is better spent answering more user questions.
What version of gRPC and what language are you using?
client  1.3.0 with c++
server with Golang
What operating system (Linux, Windows, …) and version?
built On Ubuntu 16.04.2 LTS
run on centos6.4 with glic-2.14
What runtime / compiler are you using (e.g. python version or version of gcc)
What did you do?
std::ostringstream oss;
oss << ip_ << ":" << port_;
log4cplus_debug("launch", "[%s:%d]", FUNCTION, LINE);
std::shared_ptrgrpc::Channel ch = grpc::CreateChannel(oss.str(), grpc::InsecureChannelCredentials());
if (!ch )
{
log4cplus_debug("launch", "[%s:%d] CreateChannel failed=%d", FUNCTION, LINE, ch->GetState(false));
return false;
}
stub_.reset(RelayStatusReport::NewStub(ch).release());
log4cplus_debug("launch", "[%s:%d] CreateChannel State=%d", FUNCTION, LINE, ch->GetState(false));
running_ = true;
log_in();
What did you expect to see?
gcc version 5.4.0 20160609
runtime glibc-2.14
What did you see instead?
Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
export GRPC_VERBOSITY=DEBUG;./launch
log4cplus: Just opened file: /tmp/launch.log
I0601 14:26:59.340767230   22028 ev_epoll_linux.c:95]        epoll engine will be using signal: 40
D0601 14:26:59.340813606   22028 ev_posix.c:107]             Using polling engine: epoll
I0601 14:26:59.340852505   22028 init.c:228]                 grpc_init(void)
I0601 14:26:59.340866731   22028 completion_queue.c:119]     grpc_completion_queue_create(reserved=(nil))
I0601 14:26:59.341009329   22028 init.c:228]                 grpc_init(void)
I0601 14:26:59.341035137   22028 channel_create.c:105]       grpc_insecure_channel_create(target=0x2730fe0, args=0x7ffc14517160, reserved=(nil))
E0601 14:26:59.341062536   22028 uri_parser.c:60]            bad uri.scheme: '<IP_ADDRESS>:55001'
E0601 14:26:59.341072024   22028 uri_parser.c:66]                             ^ here
E0601 14:26:59.341083069   22028 resolver_registry.c:127]    don't know how to resolve '<IP_ADDRESS>:55001' or 'dns:///<IP_ADDRESS>:55001'
E0601 14:26:59.341103374   22028 uri_parser.c:60]            bad uri.scheme: '<IP_ADDRESS>:55001'
E0601 14:26:59.341111859   22028 uri_parser.c:66]                             ^ here
E0601 14:26:59.341122141   22028 resolver_registry.c:127]    don't know how to resolve '<IP_ADDRESS>:55001' or 'dns:///<IP_ADDRESS>:55001'
D0601 14:26:59.341142472   22028 combiner.c:146]             C:0x2731930 create
E0601 14:26:59.341163701   22028 resolver_registry.c:127]    don't know how to resolve 'dns:///<IP_ADDRESS>:55001' or 'dns:///dns:///<IP_ADDRESS>:55001'
D0601 14:26:59.341178479   22028 combiner.c:161]             C:0x2731930 really_destroy old_state=1
D0601 14:26:59.341187088   22028 combiner.c:151]             C:0x2731930 really_destroy
E0601 14:26:59.341209224   22028 channel.c:99]               channel stack builder failed: {"created":"@1496327219.341175855","description":"resolver creation failed","file":"src/core/ext/filters/client_channel/client_channel.c","file_line":677}
I0601 14:26:59.341228385   22028 lame_client.c:181]          grpc_lame_client_channel_create(target=<IP_ADDRESS>:55001, error_code=13, error_message=Failed to create client channel)
I0601 14:26:59.341238825   22028 init.c:228]                 grpc_init(void)
I0601 14:26:59.341248077   22028 init.c:233]                 grpc_shutdown(void)
I0601 14:26:59.341262231   22028 channel.c:319]              grpc_channel_register_call(channel=0x27313d0, method=/relayserverstatus.RelayStatusReport/SendStatusReport, host=(null), reserved=(nil))
I0601 14:26:59.341276092   22028 channel.c:319]              grpc_channel_register_call(channel=0x27313d0, method=/relayserverstatus.RelayStatusReport/Login, host=(null), reserved=(nil))
I0601 14:26:59.341288220   22028 channel.c:319]              grpc_channel_register_call(channel=0x27313d0, method=/relayserverstatus.RelayStatusReport/HeartBeat, host=(null), reserved=(nil))
I0601 14:26:59.341300122   22028 channel.c:319]              grpc_channel_register_call(channel=0x27313d0, method=/relayserverstatus.RelayStatusReport/GetChannelConfig, host=(null), reserved=(nil))
I0601 14:26:59.341316964   22028 channel_connectivity.c:53]  grpc_channel_check_connectivity_state(channel=0x27313d0, try_to_connect=0)
E0601 14:26:59.341327284   22028 channel_connectivity.c:60]  grpc_channel_check_connectivity_state called on something that is not a client channel, but 'lame-client'
I0601 14:26:59.341416705   22028 channel.c:353]              grpc_channel_create_registered_call(channel=0x27313d0, parent_call=(nil), propagation_mask=ffff, completion_queue=0x2730780, registered_call_handle=0x2730fe0, deadline=gpr_timespec { tv_sec:<PHONE_NUMBER>854775807, tv_nsec: 0, clock_type: 1 }, reserved=(nil))
I0601 14:26:59.341452235   22028 grpc_context.c:41]          grpc_census_call_set_context(call=0x2732158, census_context=(nil))
I0601 14:26:59.341493404   22028 call.c:1759]                grpc_call_start_batch(call=0x2732158, ops=0x7ffc14516db0, nops=3, tag=0x27316d0, reserved=(nil))
I0601 14:26:59.341506408   22028 call.c:1402]                ops[0]: SEND_INITIAL_METADATA(nil)
I0601 14:26:59.341515720   22028 call.c:1402]                ops[1]: SEND_MESSAGE ptr=0x2732a20
I0601 14:26:59.341523953   22028 call.c:1402]                ops[2]: SEND_CLOSE_FROM_CLIENT
I0601 14:26:59.341549698   22028 lame_client.c:86]           OP[lame-client:0x27327a0]: [COVERED] SEND_INITIAL_METADATA{key=3a 70 61 74 68 ':path' value=2f 72 65 6c 61 79 73 65 72 76 65 72 73 74 61 74 75 73 2e 52 65 6c 61 79 53 74 61 74 75 73 52 65 70 6f 72 74 2f 4c 6f 67 69 6e '/relayserverstatus.RelayStatusReport/Login'} SEND_MESSAGE:flags=0x00000000:len=10 SEND_TRAILING_METADATA{}
I0601 14:26:59.341580329   22028 lame_client.c:86]           OP[lame-client:0x27327a0]: [UNCOVERED] CANCEL:{"created":"@1496327219.341563047","description":"lame client channel","file":"src/core/lib/surface/lame_client.c","file_line":96}
I0601 14:26:59.341594397   22028 completion_queue.c:224]     grpc_cq_end_op(exec_ctx=0x7ffc14516d20, cc=0x2730780, tag=0x27316d0, error={"created":"@1496327219.341563047","description":"lame client channel","file":"src/core/lib/surface/lame_client.c","file_line":96}, done=0xa812f0, done_arg=0x2732818, storage=0x2732820)
E0601 14:26:59.341606585   22028 completion_queue.c:226]     Operation failed: tag=0x27316d0, error={"created":"@1496327219.341563047","description":"lame client channel","file":"src/core/lib/surface/lame_client.c","file_line":96}
I0601 14:26:59.341622277   22028 call.c:1759]                grpc_call_start_batch(call=0x2732158, ops=0x7ffc14516e80, nops=3, tag=0x2731750, reserved=(nil))
I0601 14:26:59.341633100   22028 call.c:1402]                ops[0]: RECV_INITIAL_METADATA ptr=0x2731950
I0601 14:26:59.341642179   22028 call.c:1402]                ops[1]: RECV_MESSAGE ptr=0x2731780
I0601 14:26:59.341652577   22028 call.c:1402]                ops[2]: RECV_STATUS_ON_CLIENT metadata=0x2731998 status=0x27317a0 details=0x27317a8
I0601 14:26:59.341664201   22028 lame_client.c:86]           OP[lame-client:0x27327a0]: [COVERED] RECV_INITIAL_METADATA RECV_MESSAGE RECV_TRAILING_METADATA
I0601 14:26:59.341689179   22028 lame_client.c:86]           OP[lame-client:0x27327a0]: [UNCOVERED] CANCEL:{"created":"@1496327219.341674371","description":"lame client channel","file":"src/core/lib/surface/lame_client.c","file_line":96}
D0601 14:26:59.341733765   22028 call.c:690]                 get_final_status CLI
D0601 14:26:59.341745051   22028 call.c:693]                   2: {"created":"@1496327219.341563047","description":"lame client channel","file":"src/core/lib/surface/lame_client.c","file_line":96}
D0601 14:26:59.341756089   22028 call.c:693]                   3: {"created":"@1496327219.341674371","description":"lame client channel","file":"src/core/lib/surface/lame_client.c","file_line":96}
I0601 14:26:59.341768269   22028 completion_queue.c:224]     grpc_cq_end_op(exec_ctx=0x7ffc14516df0, cc=0x2730780, tag=0x2731750, error="No Error", done=0xa812f0, done_arg=0x27328e8, storage=0x27328f0)
I0601 14:26:59.342055574   22050 completion_queue.c:359]     grpc_completion_queue_next(cc=0x2730780, deadline=gpr_timespec { tv_sec:<PHONE_NUMBER>, tv_nsec: 352048991, clock_type: 1 }, reserved=(nil))
I0601 14:26:59.342093860   22050 completion_queue.c:444]     RETURN_EVENT[0x2730780]: OP_COMPLETE: tag:0x27316d0 ERROR
I0601 14:26:59.342112491   22050 completion_queue.c:359]     grpc_completion_queue_next(cc=0x2730780, deadline=gpr_timespec { tv_sec:<PHONE_NUMBER>, tv_nsec: 352048991, clock_type: 1 }, reserved=(nil))
I0601 14:26:59.342124762   22050 completion_queue.c:444]     RETURN_EVENT[0x2730780]: OP_COMPLETE: tag:0x2731750 OK
I0601 14:26:59.342203724   22050 call.c:536]                 grpc_call_destroy(c=0x2732158)
D0601 14:26:59.342510292   22050 call.c:690]                 get_final_status CLI
D0601 14:26:59.342521574   22050 call.c:693]                   2: {"created":"@1496327219.341563047","description":"lame client channel","file":"src/core/lib/surface/lame_client.c","file_line":96}
D0601 14:26:59.342531916   22050 call.c:693]                   3: {"created":"@1496327219.341674371","description":"lame client channel","file":"src/core/lib/surface/lame_client.c","file_line":96}
I0601 14:26:59.342545581   22050 metadata_array.c:47]        grpc_metadata_array_destroy(array=0x2731998)
I0601 14:26:59.342554262   22050 metadata_array.c:47]        grpc_metadata_array_destroy(array=0x2731950)
I0601 14:26:59.342565393   22050 completion_queue.c:359]     grpc_completion_queue_next(cc=0x2730780, deadline=gpr_timespec { tv_sec:<PHONE_NUMBER>, tv_nsec: 352561968, clock_type: 1 }, reserved=(nil))
D0601 14:26:59.342578374   22050 timer_generic.c:534]        TIMER CHECK BEGIN: now=102928.293732755 [1] next=102928.303720312 [11] tls_min=0 glob_min=0
D0601 14:26:59.342832224   22050 timer_generic.c:440]          .. shard[0]->min_deadline = 1
Anything else we should know about your project / environment?

This is very surprising. It seems the dns resolver is not registering. You should see something like:
I0607 14:51:45.015431502   63449 ev_epoll_linux.c:95]        epoll engine will be using signal: 40
D0607 14:51:45.015559300   63449 ev_posix.c:107]             Using polling engine: epoll
D0607 14:51:45.015619338   63449 dns_resolver.c:316]         Using native dns resolver
...

Note the "Using native dns resolver" line.
Could you make sure your environment is in a good condition (no conflicting versions left around the environment, make clean, etc.)?

@dgquintas
Hi dgquintas,
thanks for response.
this issue is gone if I link program against dynamic library.
I don't know why.

Excellent! Closing the issue.

If anyone is wondering, when loading gRPC as a DLL/SO, grpc_init() is called when the library is loaded. When it's statically compiled, you have got to call grpc_init() yourself.

i have same question

@noonien 打算


calico: init at 3.19.1

Motivation for this change
Init calico at 3.19.1
TODO: add modules for use with NixOS and K8S on NixOS
Resolves #124071
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[ ] Fits CONTRIBUTING.md.

I've been gradually running through calico the hard way & I spotted the install phase grabbing calico and calico-ipam from their GH releases: https://docs.projectcalico.org/getting-started/kubernetes/hardway/install-cni-plugin#install-the-plugin
calico and calico-ipam are the same binary just with different names so I've just added a symlink to save space
root@f75697cb9892:/# sha256sum calico-amd64
5480032e627a65eeb7917da39e339da758fb4a406eb55870a0363d1fb8475149  calico-amd64
root@f75697cb9892:/# sha256sum calico-ipam-amd64
5480032e627a65eeb7917da39e339da758fb4a406eb55870a0363d1fb8475149  calico-ipam-amd64

I've not needed calicoctl just yet but it seems quite relevant to operations at the very least

The WIP commit just copies the flannel modules and makes some minor tweaks based on what I've come across in the docs, still no where near completion.

Other TODOs or notes:
The network module probably needs to be swapped to calico-felix https://docs.projectcalico.org/getting-started/bare-metal/installation/binary-mgr
I need to read up a bit more on the differences
There is also typha for scaling out the datastore to the felix instances that I need to look into a lot more
https://github.com/projectcalico/typha

I don't have time to work on this, especially the nixos module to make it work nicely
Maybe we can just get the cli tool into nixpkgs and someone else can pick up the module work if they need it?

done by https://github.com/NixOS/nixpkgs/pull/203932


Using Dynomite with Redigo (Redis Golang Client)

Hi,
I am trying to use dynomite with redis golang client [Redigo] (https://github.com/garyburd/redigo) .
I use a single node cluster. I used the conf/redis_single.yml file.
Dynomite/Redis server is running on Ubuntu 14.04
Client  code is on Mac OS X 10.11.5.
I am able to connect to dynomite, but i get an error (details given below) while trying to write to Redis with SET command. Here's the code I am using . (I use Vitess Go Pool  for creating a Redis Connection Pool)
func PlayWithDynomite(strIPAddr string) {

	pRedisPool, err := GetPool("dynomite_redis", strIPAddr, "22222")
	if err != nil {
		panic(err)
	}

	pConn, err := pRedisPool.GetConnection()
	if err != nil {
		panic(err)
	}
	defer pRedisPool.PutConnection(pConn)

	fmt.Println("Connected To dynomite/redis") // This print happens. Successfully connected.

	R.SET(pConn, "a", "b") //This command fails.

}

I get the following error.

panic: redigo: bad response line terminator (possible server error or unsupported concurrent read by application)

But,When I try to connect to Redis instance directly (instead of connecting to dynomite), the client connects successfully and the write succeeds.
I tried to dig a bit in to the redigo client and The call stack of the point where the error was thrown is :

github.com/garyburd/redigo/redis.(*conn).readLine(0xc820086e60, 0x0, 0x0, 0x0, 0x0, 0x0)
/Users/test/try/src/github.com/garyburd/redigo/redis/conn.go:350 +0x645
github.com/garyburd/redigo/redis.(*conn).readReply(0xc820086e60, 0x0, 0x0, 0x0, 0x0)
/Users/test/try/src/github.com/garyburd/redigo/redis/conn.go:422 +0x57
github.com/garyburd/redigo/redis.(*conn).Do(0xc820086e60, 0x44bc88, 0x3, 0xc820109200, 0x2, 0x2, 0x0, 0x0, 0x0, 0x0)
/Users/test/try/src/github.com/garyburd/redigo/redis/conn.go:570 +0x6b2

I just added a panic before line 350 in redigo/redis/conn.go to produce the call stack.
Has anyone here tried using dynomite with Redigo ?
Can you please help me fix this problem ?
Thank you,
Prakash

Are you running Redis or Dynomite in port 22222? It seems you are establishing the connection pool to that port:
    pRedisPool, err := GetPool("dynomite_redis", strIPAddr, "22222")
Based on the YAML you are running 22122 is your Redis port, and 8102 is your Dynomite port. 22222 is the REST port for Dynomite. So your client may be connecting but no Redis operations will succeed.

Thanks a lot for your help @ipapapa .
I am now able to write to redis via dynomite.
I also had to change the redis_single.yml file
dyn_listen has to be changed from <IP_ADDRESS>:8102 to <IP_ADDRESS>:8102.
Here's my current config file.
`dyn_o_mite:
dyn_listen: <IP_ADDRESS>:8101
data_store: 0
listen: <IP_ADDRESS>:8102
dyn_seed_provider: simple_provider
servers:

<IP_ADDRESS>:22122:1
tokens: 437425602`

Thank you,
Prakash


Menu font text color is black, when I use the theme

My menu font is black, when I use the theme it is not correct, this is weird, when the cursor moves over it the menu text shows white while the other menu fonts are black, sorry I'm not very good at win32 api, need a help

Environment (please complete the following information):

systeminformation package version: 3.0.7566 (999ab69)
OS: windows 11  23H2 Pro 22631.3447
Hardware AMD 7950x CPU,  AMD GPU 7900xtx  Driver 24.31

I found the problem, open the Windows Setting > screen > Advanced Display Settings> Automatically manage app colors and it will look like this
https://support.microsoft.com/en-us/windows/auto-color-management-in-windows-11-64a4de7f-9c93-43ec-bdf1-3b12ffa0870b
Well, not all windows have this option, I looked at my company's computer and didn't have this option, I recommend not using the windows api to get the color, you can use RGB (24, 24, 24) fixed color

Hi, @yanite ... as the package itself does not have any UI, this problem is NOT related to this package. Can you tell me, what software you are using (that uses then this package?)


[FLINK-11368][tests] Port TaskManagerStartupTest to new code base

What is the purpose of the change
Check and port TaskManagerStartupTest to new code base.
Brief change log

Port tests of testIODirectoryNotWritable, testMemoryConfigWrong and testStartupWhenNetworkStackFailsToInitialize to new code base.
Previous test testStartupWhenTaskmanagerActorPortIsUsed could be covered by TaskManagerRunnerConfigurationTest in FLINK-11363-PR

Verifying this change
This change added tests and can be verified as follows:

port TaskManagerStartupTest to new code base.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

Failed test should have no relationship with this PR


ENH: Added basic pairs algo.

@thewassermann could you take a brief look and merge if this looks okay?

looks great, works great


Unable to resolve version from lightweight tags

which are the tags that are created by GitHub when cutting a new release.
Can be fixed by adding --tags to the git describe command. PR incoming.

It's a design decision to only consider annotated tags (aka exclude lightweight tags).
I should document that.
But what do you mean by "created by GitHub when cutting a new release"? Aren't GitHub releases based on the user published tags?

Aren't GitHub releases based on the user published tags?

Not necessarily. It is possible to create a new release from Releases GitHub page which will in turn create a new tag. That tag is going to be a lightweight one.

Is there a problem when considering lightweight tags in the describe?

Using lightweight tags to define the version means you can never use tags for anything but the version. For instance you can't create a local "before-refactor" tag, for your convenience, and you have to use SHAs all the time. I personally believe this is a waste of a great feature in git, so I prefer only annotated tags are used for versions.
But I'm happy for sbt-dynver to have an opt-in feature that includes lightweight tags.

... you can never use tags for anything but the version ...

Are you concerned of a version being inadvertently derived from a tag which was not meant to be a version tag?
sbt-dynver uses --match to only consider tags that start with a v and a number. That should be enough to have this risk very low.
Or is there something else that I am missing?

You're right, I forgot about that safe-guard - I agree it makes the risk very low.
Go ahead, and welcome, my first contributor :)

Fixed by #15


ci: add dependabot.yml to set commit prefix

This is an alternative to #3388.

I think this is correct.  Let's see if it works.


Fix Nutanix env for e2e

Description of changes:
Set the proper env var for Nutanix E2E
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Release on Modrinth

https://modrinth.com/dashboard/projects

Maybe this action can be used to automatically publish. To build the project using gradle, maybe this action can be used.

https://fabricmc.net/wiki/tutorial:publishing_mods_using_github_actions
The fabric wiki also has their own page on publishing mods using github. It also seems that marvinpinto/action-automatic-releases won't be needed when using Kir-Antipov/mc-publish.


DHCP and DNS settings: dnsmasq domain filter is too restrictive and doesn't allow wildcards

In the Network > DHCP and DNS > CNAME tab, it is possible to edit entries that will be converted into a dnsmasq --cname option. In the UI, this is configured with a hostname data type for validation:
https://github.com/openwrt/luci/blob/032f3056789d01930028ab5eeecac59c17c7e8d6/modules/luci-mod-network/htdocs/luci-static/resources/view/network/dhcp.js#L814
However, dnsmasq supports wildcards in cname aliases, as evidenced by the docs:

[...]
--cname as long as the record name is in the authoritative domain. If the target of the CNAME is unqualified, then it is qualified with the authoritative zone name. CNAME used in this way (only) may be wildcards, as in
--cname=*.example.com,default.example.com

Note that a wildcard domain may be set using the command line (uci), and dnsmasq behaves as expected.
The field validation should be relaxed to allow wildcards as well as valid domain names, to allow this feature of dnsmasq to be used.

Hi @vtavernier! In which situations (only) does the manpage document that a CNAME may contain wildcards?

@jow- I was afraid this might happen which was why I asked the question. There is only one very specific use case when this is possible and even then not recommended, and adding wildcard possibility to this field opens up more problems than it solves. One needs to study that part of the man page which upon a few readings is actually easy to misunderstand. As long as we don't advertise this possibility, that's... Acceptable.

It is allowed by dnsmasq, it is accepted by uci and there's existing configs using it, so there is no reason LuCI should not accept it.


New version: Mozilla.Firefox.DeveloperEdition.is version 132.0 (132.0b4)

Created by 🥟 Dumplings.
Microsoft Reviewers: Open in CodeFlow

Verify by proxy: https://github.com/microsoft/winget-pkgs/pull/179431#issuecomment-2400690391


Update Jacoco version

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #10991 (8f231ff) into 3.1 (f074aec) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.1   #10991      +/-   ##
============================================
+ Coverage     64.55%   64.59%   +0.03%
  Complexity       14       14
============================================
  Files          1418     1418
  Lines         58857    58857
  Branches       8638     8637       -1
============================================
+ Hits          37997    38016      +19
+ Misses        16828    16811      -17
+ Partials       4032     4030       -2

Impacted Files
Coverage Δ

.../dubbo/remoting/transport/netty4/NettyChannel.java
72.64% <0.00%> (-1.89%)
:arrow_down:

...ava/org/apache/dubbo/rpc/model/FrameworkModel.java
91.39% <0.00%> (-0.67%)
:arrow_down:

...ubbo/config/deploy/DefaultApplicationDeployer.java
72.07% <0.00%> (-0.40%)
:arrow_down:

...n/java/org/apache/dubbo/common/utils/NetUtils.java
62.39% <0.00%> (-0.28%)
:arrow_down:

...rg/apache/dubbo/common/timer/HashedWheelTimer.java
85.22% <0.00%> (+0.34%)
:arrow_up:

...ubbo/registry/client/AbstractServiceDiscovery.java
79.85% <0.00%> (+0.74%)
:arrow_up:

...pache/dubbo/common/json/impl/AbstractJSONImpl.java
0.99% <0.00%> (+0.99%)
:arrow_up:

...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java
90.47% <0.00%> (+2.38%)
:arrow_up:

...try/client/metadata/MetadataServiceDelegation.java
41.30% <0.00%> (+3.26%)
:arrow_up:

...org/apache/dubbo/rpc/protocol/AbstractInvoker.java
70.64% <0.00%> (+3.66%)
:arrow_up:

... and 4 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Copy in FAQ

Paste in the first 9 FAQ from the trello board
https://trello.com/b/4dogyu5I/brainbot-trustlines-communications

@ezdac please advise which format and which file, please propose sample format for headings/sections and question/answer pairs


513 when to use

Fix #513

Added the new "When To Use" block in code and library
❗ Made some changes to general link handling in styles.css based on Frontify > @saurabh-khare Please have a look
Added Design System to the Sidekick library @alexcarol (link to Sidekick library does not work yet)

Test URLs:
Content Hub:
Before: https://main--hlx-test--urfuwo.hlx.page/topics/
After: https://513-when-to-use--hlx-test--urfuwo.hlx.page/topics/ (focus on the links, nothing changed)
Design system:
Before: https://main--hlx-test--urfuwo.hlx.live/fiori-design-web/button-web-component
After: https://513-when-to-use--hlx-test--urfuwo.hlx.page/fiori-design-web/button-web-component

[x] New Blocks introduced in this PR
If yes, please provide details below

Block Name
Documentation
Library Link

when-to-use
doc-link + https://513-when-to-use--hlx-test--urfuwo.hlx.page/tools/sidekick/blocks/when-to-use
Library Link

It doesn't quite match the design:
Live site:

This branch:

If it makes it easier you can always remove the explicit "do" and "don't" from the content and add it via code along with the icon (that's up to you).

If it makes it easier you can always remove the explicit "do" and "don't" from the content and add it via code along with the icon (that's up to you).

I would like to keep the current implementation (the CSS selects the correspoding p).


failing tests when using spawn-wrap to run node-tap

the bad news
There are failing tests when using nyc to instrument node-tap with code coverage. I think I've hunted down one of the issues:
In the test expose-gc-test.js, you run the following shell command:
bin/run.js --expose-gc ./gc-script.js

When this gets spawn wrapped it seems to run --expose-gc as argv[1].
+++ found
    --- wanted
    -true
    +module.js:318
    +    throw err;
    +          ^
    +Error: Cannot find module '/Users/benjamincoe/bcoe/node-tap/--expose-gc'
    +    at Function.Module._resolveFilename (module.js:316:15)
    +    at Function.Module._load (module.js:258:25)
    +    at Function.Module.runMain (module.js:451:10)
    +    at Function.runMain
    +(/private/tmp/node-spawn-wrap-33830-310e04a7343d/iojs:62:10)
    +    at Object.<anonymous>
    +(/Users/benjamincoe/.nvm/versions/io.js/v1.6.2/lib/node_modules/nyc/bin/nyc.js:14:6)
    +    at Module._compile (module.js:410:26)
    +    at Object.Module._extensions..js (module.js:428:10)
    +    at Module.load (module.js:335:32)
    +    at Function.Module._load (module.js:290:12)
    +    at Function.Module.runMain (module.js:451:10)

the good news
With the updates to nyc's signal handling we now have a much better coverage report for node-tap:
------------------|-----------|-----------|-----------|-----------|
File              |   % Stmts |% Branches |   % Funcs |   % Lines |
------------------|-----------|-----------|-----------|-----------|
   bin/           |      76.3 |     66.07 |        50 |     76.74 |
      run.js      |      76.3 |     66.07 |        50 |     76.74 |
   lib/           |     86.05 |     80.21 |     91.92 |     86.14 |
      assert.js   |     94.77 |      83.7 |       100 |     95.32 |
      mocha.js    |     85.19 |        70 |        75 |     85.19 |
      root.js     |     77.78 |        25 |         0 |     77.78 |
      stack.js    |     83.78 |      69.7 |       100 |     83.78 |
      synonyms.js |     94.74 |        75 |       100 |     94.74 |
      test.js     |     84.06 |        82 |     90.91 |     84.06 |
------------------|-----------|-----------|-----------|-----------|
All files         |     84.57 |     78.17 |     87.39 |     84.72 |
------------------|-----------|-----------|-----------|-----------|

also,
you should now be able to test yourself easily by running:
npm install nyc -g
nyc npm test

the ugly news
there is no ugly news.

It seems like this got worked out?  tap coverage seems to be working for tap's tests right now?


Include auto subscribe

will also need a change here: https://github.com/NFIBrokerage/beeline_honeycomb/blob/f64b8715289021ae0d5709a2b05a8d2d136c6481/lib/beeline/honeycomb.ex#L70-L92
to add in the :auto_subscribe field to the event sent to honeycomb


Is there a significant difference between pretty-compact and pretty?

Just wondering if pretty-compact produces noticeably better output than pretty, in the context of kicad-data?  If the difference isn't that big, I wonder if it might be preferable to switch to pretty instead, because:

pretty is more widely used
pretty has a more liberal license

Neither of these is a big issue for me, but they both seem like small arguments in favor of pretty.

I read this blog post at the time and decided to use it. It does seem to have some nicer formatting for s-expressions. I don't think it's a huge issue though as the footprints are mostly for machine reading so if it is a problem for people I am happy to switch it out.

OK, thanks.  The blog post sheds some light on the reasons.  It isn't a problem for me; I was just curious why a more-obscure library was being used.


Document org policy violations REST API

Proposed changes

Unreleased product version (optional)

Related issues (optional)
Fix https://github.com/pulumi/pulumi-service/issues/21563

This needs to be updated to include the urn as that will be part of the api response.

This needs to be updated to include the urn as that will be part of the api response.

Updated


[e2e]: generic release main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/v24.0.202
Run: https://github.com/slsa-framework/example-package/actions/runs/3879684590
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.release.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.release.main.default.slsa3.yml
Trigger: release
Branch: v24.0.202
Date: Tue Jan 10 02:42:32 UTC 2023

It seems that the example-package project was broken by upgrading to Bazel 6.0.0.
https://github.com/slsa-framework/example-package/pull/127
/cc @mihaimaruseac

Or maybe it was the gazelle update https://github.com/slsa-framework/example-package/pull/121

It seems we were using Go 1.16 with Bazel even though we specified 1.18 in go.mod.
https://github.com/slsa-framework/example-package/pull/128

Oh, I didn't notice this. Good to know, thank you for the ping.

Repo: https://github.com/slsa-framework/example-package/tree/v24.0.203
Run: https://github.com/slsa-framework/example-package/actions/runs/3889144639
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.release.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.release.main.default.slsa3.yml
Trigger: release
Branch: v24.0.203
Date: Wed Jan 11 02:45:19 UTC 2023
Tests are passing now. Closing this issue.


feat: cambios entrega final

Codecov Report

Merging #58 (372132a) into master (0a47c73) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #58   +/-   ##
=========================================
  Coverage     96.83%   96.83%
  Complexity      135      135
=========================================
  Files            22       22
  Lines           253      253
  Branches         20       20
=========================================
  Hits            245      245
  Misses            5        5
  Partials          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a47c73...372132a. Read the comment docs.


Value not updated after setState

Hi
I have three ScrollPickers in a modal I'm creating (for days, hours and minutes). I'd like to set the selectedIndex on all three of them in componentDidMount. When I call setState, only the last ScrollPicker is updated and the others are stuck on 0. How can I work around this?

did you solve this problem?? im having a same issue


Update request

It is probably somewhat infrequent that a new Sandstorm user is hoping to start using BabyBuddy, but as unexpected to me as it is... I am expecting to need this app in approximately two months! I am not sure how significant the updates are from 1.4 to 1.9, or if there's any significant bitrot in updating the Sandstorm package, but I was curious if that would be possible.

Congrats! I’ll take a look here soon. There are have been a number of decent improvements in recent versions.

Well first hurdle... it seems, of course, I have lost the key material for my app ID :grimacing:
If I generate a new key and submit the app again am I going to end with a duplicate app and/or not be able to submit under the same app title or something?

So yes, that would generally be an issue, but we have a system for that. You would submit a PR for https://github.com/sandstorm-io/sandstorm/blob/0d53a6646ab99c2cd4e54d2fc2d04d69f1e18366/src/sandstorm/appid-replacements.capnp which, once merged, would tell both the app market and Sandstorm that a given app with a new key is the same, and permit updates from one to the other.

Good news -- I found the key materials on an old computer. However, new problem, I have imported the proper secrets on my new computer but I can't seem to get vagrant to recognize them? Here's the output when I try to test for the key --
chris@crushinator:~/PycharmProjects/babybuddy-sandstorm$ vagrant-spk getkey 7yu31zwuv5f0aeg0749hvtrfz92g5ccq4mf21nvmspxwjs61duwh
Calling 'vagrant' 'ssh' '-c' 'spk getkey --keyring=/host-dot-sandstorm/sandstorm-keyring 7yu31zwuv5f0aeg0749hvtrfz92g5ccq4mf21nvmspxwjs61duwh' '--' '-T' in ~/PycharmProjects/babybuddy-sandstorm/.sandstorm
7yu31zwuv5f0aeg0749hvtrfz92g5ccq4mf21nvmspxwjs61duwh: key not found in keyring
Command failed with a non-zero exit status (1).

I tried destroying and rebuilding the vm but maybe that's not relevant anyway? I'm a little unclear on how this process is supposed to work...

Alright I posted and submitted v3 based on Baby Buddy v1.5.0 just to get things tested. Will do a v4 release soon with the latest version of Baby Buddy.

I need to clean the update approval queue up, but I created a BabyBuddy 1.4 instance, and updated it to 1.5 from the experimental market, and that all looks good!

Great! I'm going to delay at least a few days here anyway because I think its about time for a new point release of Baby Buddy. After that I'll work on getting the Sandstorm build up to date on 1.9.x. I think there may be some Sandstorm specific hitches between 1.5.0 and 1.9.x.

:wave: @ocdtrekkie v4 based on the latest version of Baby Buddy has been submitted for publishing!

Approved to the app market.


repository-setup

[x] Repository Setup
[x] Create and Share a Repository
[x] Milestones
[x] Planning Folder
[x] Code of Conduct

all done


TODO tags without brackets not shown in sidebar

Its seems like a TODO created like this is not displayed in the Sidebar:
* TODO Save the cheerleader

This works:
* [TODO] Save the world

The settings "Use Brackets Around Todo Tags" does not seem to affect this.

Thanks for the report, I'll get a fix out in the next release.

Sorry, one more release until this gets out.

Fixed in 0.7.1


Laravel 11 is not supporting ???

Laravel 11 is not supporting ???

https://github.com/gg-innovative/larafirebase

@gentritabazi i want to update my code from laravel 9 to 11 but this package is not working ..

You need to replace package to https://github.com/gg-innovative/larafirebase
``composer require gg-innovative/larafirebase```


Added index.html file

@dev-minds0987
I want you to merge this pull request. If you think there is no error while debugging.
If you have found an error, please let me know.

@nived-dev Pull requested will be merged but please make the changes and get back to me


Added RundBundle

/claim #875
RunBundle Added

Hi @tolgaOzen implemented runbundle. If any changes needed, let me know.

Hello @Rutik7066 , I did a review and couldn't see the tests, can you add them?

Hi @tolgaOzen sure i will add the test


Add FRWC token weighted strategy

Add FRWC token weighted strategy.
Changes proposed in this pull request:

Add a strategy to assign votes to holders of Forgotten Runes Wizard Cult tokens
No strategy is present to allow multiple ERC721 to be counted with different weights
Strategy Passes all tests, including if run with >500 addresses

Updated that, can you review again? Thanks!

Looks good to me 👍


in a case of invalid key, the node crashes the node-red instance

In a case where an empty key is supplied, the node crashes<EMAIL_ADDRESS>instance.
The response from ifttt is: { errors: [ { message: 'You sent an invalid key.' } ] }
The error message is:
30 Oct 12:34:55 - SyntaxError: Unexpected token o in JSON at position 1
at Object.parse (native)
at Request._callback (/home/mqiu/dev/test-node-red/node_modules/node-red/node_modules/node-red-contrib-ifttt/nodes/ifttt.js:35:27)
at Request.self.callback (/home/mqiu/dev/test-node-red/node_modules/node-red/node_modules/node-red-contrib-ifttt/node_modules/request/request.js:186:22)
at emitTwo (events.js:106:13)
at Request.emit (events.js:191:7)
at Request. (/home/mqiu/dev/test-node-red/node_modules/node-red/node_modules/node-red-contrib-ifttt/node_modules/request/request.js:1163:10)
at emitOne (events.js:96:13)
at Request.emit (events.js:188:7)
at IncomingMessage. (/home/mqiu/dev/test-node-red/node_modules/node-red/node_modules/node-red-contrib-ifttt/node_modules/request/request.js:1085:12)
at IncomingMessage.g (events.js:292:16)
at emitNone (events.js:91:20)
at IncomingMessage.emit (events.js:185:7)
at endReadableNT (_stream_readable.js:974:12)
at _combinedTickCallback (internal/process/next_tick.js:80:11)
at process._tickCallback (internal/process/next_tick.js:104:9)

Yes this could use better error handling around the JSON.parse. Pull requests accepted.

Merged fix and published at v0.1.0


[Bug]: No @lenra:navTo key in type ListenerName

What happened?
We didn't have the @lenra:navTo and other system key in the  ListenerName type. https://github.com/lenra-io/app-lib-js/blob/main/src/lib/gen/names.ts
What browsers are you seeing the problem on?
No response
Version
No response
Relevant log output
Argument of type '"@lenra:navTo"' is not assignable to parameter of type 'ListenerName'.ts(2345)

Might be blocking for TypeScript projects


sdist is missing tests

The sdist package at PyPI is missing tests.  Please add tests to sdist to make downstream testing easier.  Thank you.

Hello! The Python community appears to be divided over this and there's no current recommendation to include tests or docs (see https://discuss.python.org/t/should-sdists-include-docs-and-tests/14578/115) so I won't be working on this, sorry. That said, I would accept a pull request that implements this.


Schema and site updates for 1.2

Fixes #3030
Microsoft Reviewers: Open in CodeFlow

Any chance you can squash some of these commits? CodeFlow can't open a review with >64...

I couldn't figure out squashing, so squashed via GitHub into a new branch and created a new PR: #3044. All of your feedback has been resolved in that PR, other than a base ContainerElement (commented on that) and hosting the typed-schema schema (commented on that).
Thanks so much for the initial look through via GitHub! The new one should be viewable in CodeFlow now :P


which firmware version works with this libray....

please share the link of .bin file

Can you update the firmware version and its link. Some commands working and some are not.

I'm having issues running the HTTPGET example and am pretty sure it's firmware related, I'm

AT version:<IP_ADDRESS>(May 11 2016 18:09:56)
SDK version:1.5.4(baaeaebb)
compile time:May 20 2016 15:08:19

My example fails at the createTCP call.


[RELEASE] Data Prepper 2.0.0

Is your feature request related to a problem? Please describe
The Data Prepper team is releasing 2.0.0.
Planned release date: Oct 5, 2022
Describe the solution you'd like
After the Data Prepper maintainers completes the staging release build, please run the promotion job. A Data Prepper maintainer will supply the VERSION and DATA_PREPPER_BUILD_NUMBER parameters.
We also need to run the Copy Docker Image Jenkins job with the following parameters:
DockerHub: label 2.0.0 -> 2
DockerHub: label 2.0.0 -> latest
ECR: label 2.0.0 -> 2
ECR: label 2.0.0 -> latest
Describe alternatives you've considered
No response
Additional context
No response

[Triage] @dlvenable can you work with @gaiksaya to see if we can completely automate this release process?

@gaiksaya , @bbarani ,
I created #2632 to reduce the number of steps required by operators. However, I don't expect that we will have time on our end to make this change for 2.0.0. We can discuss any specifics of my proposal in #2632.

Hi @dlvenable please contact @rishabh6788 on the release matter for the week of 2022/10/05.

Just synced up with @rishabh6788 on the release process and he should also be able to complete this issue leading to the 2.0.0 data prepper releases.
https://github.com/opensearch-project/opensearch-build/issues/2632

We are going to push this release back to Monday Oct 10, 2022.

With support for #2632 we will set:
RELEASE_MAJOR_TAG: true
RELEASE_LATEST_TAG: true

VERSION : 2.0.0
DATA_PREPPER_BUILD_NUMBER: 26

Data Prepper build: https://github.com/opensearch-project/data-prepper/actions/runs/3221121185

Data Prepper is released.
Maven: https://aws.oss.sonatype.org/content/repositories/releases/org/opensearch/dataprepper/data-prepper-api/2.0.0/
Linux: https://artifacts.opensearch.org/data-prepper/2.0.0/opensearch-data-prepper-jdk-2.0.0-linux-x64.tar.gz
Dockerhub: https://hub.docker.com/r/opensearchproject/data-prepper/tags?page=1&name=2.0.0


build failed according to the readme badge

Oops. Thanks for flagging @matkoniecz - this is my bad - I was trying to quick-fix something that I obviously need to roll-back.


Visibility flag in doc comments for generated documentation

I would like to indicate what comments to be included in the generated documentation, and which ones not to.
For example, biscotto provides these flags: https://github.com/gjtorikian/biscotto#visibility, which would be really nice to have.

How about @public and @private and configure your esdoc.json so that it will only include either of these two?

@jstejada Please use @public, @protected, @private and config.access.

https://esdoc.org/tags.html#-access
https://esdoc.org/config.html


"stack" operation is too slow

The way the "stack" operation is currently implemented (including row_stack and column_stack) it invokes array(x) for each item of the input. This creates an object array (because the input is not an ndarray, it's an ArrayNode), which given the input array might have millions of entries is very very slow.
You can achieve the same thing (in the case of column_stack) with concatenate followed by reshape, so it seems odd that the stack function behaves so much worse. At least if it's expected it might be worth a note in the documentation.
Here's an example of the problem:
import autograd.numpy as np
import autograd

def test_one(x):
    a = np.sin(x)
    b = np.cos(x)
    c = np.concatenate((a, b)).reshape((-1, 2))
    return np.sum(c)

def test_two(x):
    a = np.sin(x)
    b = np.cos(x)
    c = np.column_stack((a, b))
    return np.sum(c)

x = np.zeros(1000000)

# both are quick
print(test_one(x))
print(test_two(x))

# this is quick
test_one_grad = autograd.grad(test_one)
print(test_one_grad(x))

# this never terminates
test_two_grad = autograd.grad(test_two)
print(test_two_grad(x))

This tripped me up today as well. It's worth noting that the slowness only comes up for the backwards pass, when the input is an ArrayNode.
I ended up making my own version of stack that avoids the autograd.numpy.array() call:
def stack(arrays, axis):
  if not arrays:
      raise ValueError('need at least one array to stack')

  shapes = set(arr.shape for arr in arrays)
  if len(shapes) != 1:
      raise ValueError('all input arrays must have the same shape')

  result_ndim = arrays[0].ndim + 1
  if not -result_ndim <= axis < result_ndim:
      raise IndexError('axis {0} out of bounds [-{1}, {1})'.format(axis, result_ndim))
  if axis < 0:
      axis += result_ndim

  sl = (slice(None),) * axis + (None,)
  return autograd.numpy.concatenate([arr[sl] for arr in arrays], axis=axis)

(This is literally the same function from autograd/numpy, except I removed the line arrays = [array(arr) for arr in arrays].)
It seems like the general fix might be is to allow autograd.numpy.array() (at least inside the stack functions) to pass through ArrayNode objects?


Generator seems to fail with 400 stations option

Describe the bug
Generator seems to fail with 400 stations option
To Reproduce
Steps to reproduce the behavior:
./generator -i ../data/weather_stations.csv -o data400.csv -n<PHONE_NUMBER> -4
Expected behavior
Should generate the file.
Screenshots
$ ./generator -i ../data/weather_stations.csv -o data400.csv -n<PHONE_NUMBER> -4
ERROR: Option at position 7 needs an argument : 4

Additional context
Same issue is --400stations is used.
No problem without the -4 option: the csv file is correctly generated.

I understood now: I have to use -4 400.
But the -h message is just wrong, and such usage is very misleading.
Writing e.g. --400stations 1000 sounds just plain weird.

Hey Y'all,
We good to close this one?
PR has been merged.
Cheers,
Gus


As a user, I want to open the calendar so that I can check on my schedule

unless the calendar is immediately shown when the address book runs


refactor(core): allow passing optional check params to Authenticated …

…component
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://refine.dev/docs/guides-concepts/contributing/#commit-convention

Bugs / Features

[x] Related issue(s) linked
[x] Tests for the changes have been added
[x] Docs have been added / updated
[x] Changesets have been added https://refine.dev/docs/guides-concepts/contributing/#creating-a-changeset

What is the current behavior?
The Authenticated component doesn't take extra params for the useIsAuthenticated hook to check the auth status
What is the new behavior?
The component now has params in the props which is then passed to the authenticated hook call, which already allows for params: any
fixes (#6309)
Notes for reviewers

Oh, a minor thing I forgot, we could also update Authenticated component documentation and mention that params can be passed to AuthProvider's check method.

Oh. Okay @BatuhanW. sadly I have to run now...
I'm not sure why the linting is throwing an error... I installed the biome extension, but can't get it to format the file for some reason.... is this something someone else can easily help with?

Thanks @BatuhanW. Apologies I couldn't continue since too. Have my hands quite tied presently

@reedwane no worries, we'll release it around December 5th. If we can't hear back from you until then, we can update documentation.

Hello @reedwane I have commits to complete your PR but I can't push to your fork. It seems contributor commits aren't allowed.

Thanks @BatuhanW
The last couple of weeks have been quite the days. I'm just even seeing these notifications now. Thanks for completing the changes.


Ordered keys

It would be great if a formatting option could be added to this tool to sort keys in YAML objects.

Thanks for opening an issue! I agree that would be a good issue, but unfortunately it will need to be added to the pile of issues that will have to wait until I have some custom yaml parsing; the library I'm using doesn't have this functionality and it would be hard to add.


Issue #544: Restore same log level.

This PR addresses the build break from merging #591.
Restore the same log level from the start of the test, rather
than assuming that it's DEBUG.
If I run the tests using a more recent Surefire and -Dsurefire.runOrder=random, the tests fail before this change, and pass afterwards.

Running hudson verify on this PR: https://hudson.eclipse.org/rdf4j/job/rdf4j-verify-pr/32/

Can you elaborate on what exactly you think the problem was? Because I find it odd that simply fixing the log level setting would influence the test outcomes this way.

Hudson build succeeded, ready to merge IMHO.  Thanks @josephw !

The proposed fix here indicates that the log level setting code is still broken. Ie, the fact that only a test was changed indicates that there is still a bug in the actual code that was recently merged in relation to the log level setting.

That is true, which is why I am keen to hear more details on what exactly caused the issue in the first place (and why this fix resolves it). I merged immediately because I wanted the branch stable, but it'd be good to discuss this a bit further.

I am working through the SetParameters code to see if I can improve it, particularly to not rely on null as a sentinel.

The Federate command class has a switch on log.isDebugEnabled() at line 77 that affects control flow. I.e., the ROOT log level that is being changed by SetParametersTest has side effects on Federate/FederateTest. This behaviour doesn't look to be documented (we don't say that if a user sets log level to debug that federation will be not performed).
This may have been the first time that this code has actually been run through the testsuite.
I am working on a pull request to patch it.

@jeenbroekstra Debugging this included updating Mockito to version 2.2.0 that has some extra debugging features, and bumping the Logback version to the latest to verify it wasn't related.
Do you want me to open an issue to get legal approval to use Mockito 2.2.0 and Logback 1.1.7 and include it in a pull request or back out those version bumps?

Neither of those versions are existing in Orbit yet, so they haven't been pre-approved. This close to release I'd prefer not to file CQs that might hold up release review. Can you back out of those bumps for the immediate fix and log issues to update these libraries for a later release?

The Federate command class has a switch on log.isDebugEnabled()

Thanks, @ansell - that explains what I saw, and why this change to the test has any effect. I didn't have time to dig in, so I appreciate learning what's going on.


Referral Bonuses

Full Disclosure we took out the [Referral Bonuses] (https://github.com/clef/handbook/blob/master/Benefits and Perks/Referral Bonuses.md) perk because we feel that referrals at this point are expected from everyone on the founding team. Totally open to discussion on that point, but wanted to open an issue as a placeholder for when we do want to start offering Referral Bonuses to employees, specifically if we hire anyone with a lot of clout, visibility, or network power.

Personally not into referral bonuses. Doesn't seem like it creates the right motivation.

I'm not into referral bonuses either. I can see how at a much larger
company (or a company where a lot of people are driven by money), it might
mean that people would try harder to source candidates, but definitely
shouldn't be needed at this stage, IMO.
On Wed, Jan 13, 2016 at 11:14 AM, Zeke Sikelianos<EMAIL_ADDRESS>wrote:

Personally not into referral bonuses. Doesn't seem like it creates the
right motivation.
—
Reply to this email directly or view it on GitHub
https://github.com/josephine/handbook/issues/14#issuecomment-171402155.


Retrieve function arguments via AST

The current implementation accepts nested functions with arity 0 or 1.
Functions with arity one receive all bindings of the view, for example:
In the template:

<%= mymodule:get_foo() .%>

In the erlang code:
-module(mymodule).

get_foo() -> fun(#{'MyMap' := MyMap} = _AllBindings) -> maps:get(foo, MyMap) end.

I could not find a way to resolve the nested function as get_foo() -> fun(MyMap) -> maps:get(foo, MyMap) end..
This situation was discussed in the Erlang forums here. Please read the Erlang forums topic for more information.
I opened this issue to remember to discuss this in the future because maybe the current implementation makes no sense.
Any help or an idea for a different approach is welcome.

Closing this issue because it does not make sense and its implementation is no longer needed.


Fixed appassembler for Windows

Addressing #943:
For Windows, appassembler generated invalid batch files with too long classpaths.
To fix it, we can use wildcards (available from Java 6) along with a flat directory structure.

@edwinzhng you're on Windows, right? can you look at this and comment?

@lintool @guyrosin I was able to reproduce the error on Windows and I can confirm that this change fixes it 💯

Thanks @guyrosin for your contributions!


Chef Client has no support for Self Signed SAN Certificates.

Versions

Chef Standalone Server:  12.3.1 (Deb Package)
Chef Development Kit: 0.10.0
Chef Client: 12.5.1

Environment

Chef Server: Ubuntu 14.04.1 LTS
Workstation: Mac OSX v10.11.2 (Ruby 2.2.1 & OpenSSL 0.9.8zg 14 July 2015)

Issue
We have a Chef Server which has both public and private DNS names. such as chef.example.com (Public) & chef.example.cloud (Private). So with the certificates common name set to "chef.example.cloud" chef-clients on our private network work perfectly.
On our public side it is a different story onced I have fetched the certs using:
knife ssl fetch https://chef.example.com

Which give me the following expected output.
WARNING: Certificates from chef.example.com will be fetched and placed in your trusted_cert
directory (/Users/<USERNAME>/.chef/trusted_certs).

Knife has no means to verify these are the correct certificates. You should
verify the authenticity of these certificates after downloading.

Adding certificate for chef.example.cloud in /Users/<USERNAME>/.chef/trusted_certs/chef_example_cloud.crt

That works file. Then when i check the certificates using this command:
knife ssl check https://chef.example.com

I get the following error which is not what I am expecting.
Connecting to host chef.example.com:443
ERROR: The SSL cert is signed by a trusted authority but is not valid for the given hostname
ERROR: You are attempting to connect to:   'chef.example.com'
ERROR: The server's certificate belongs to 'chef.example.cloud'

TO FIX THIS ERROR:

The solution for this issue depends on your networking configuration. If you
are able to connect to this server using the hostname chef.example.cloud
instead of chef.example.com, then you can resolve this issue by updating chef_server_url
in your configuration file.

If you are not able to connect to the server using the hostname chef.example.cloud
you will have to update the certificate on the server to use the correct hostname.

So next I verify the connection using OpenSSL s_client directly to check it not the certificate.
openssl s_client -port 443 -host chef.example.com -CAfile /Users/<USERNAME>/.chef/trusted_certs/chef_example_cloud.crt

I get a similar output to what is shown below.
CONNECTED(00000003)
depth=0 /C=US/ST=NewYork/L=NewYork/O=ExampleCompany/OU=DevOps<EMAIL_ADDRESS>verify return:1

---
Certificate chain
 0 s:/C=US/ST=NewYork/L=NewYork/O=ExampleCompany/OU=DevOps<EMAIL_ADDRESS>   i:/C=US/ST=NewYork/L=NewYork/O=ExampleCompany/OU=DevOps<EMAIL_ADDRESS>
---
Server certificate
-----BEGIN CERTIFICATE-----
MIIEgzCCA2ugAwI .......... 1uxiodZKZQ==
-----END CERTIFICATE-----
subject=/C=US/ST=NewYork/L=NewYork/O=ExampleCompany/OU=DevOps<EMAIL_ADDRESS>issuer=/C=US/ST=NewYork/L=NewYork/O=ExampleCompany/OU=DevOps<EMAIL_ADDRESS>
---
No client certificate CA names sent

---
SSL handshake has read 2114 bytes and written 456 bytes

---
New, TLSv1/SSLv3, Cipher is DHE-RSA-AES128-SHA
Server public key is 2048 bit
Secure Renegotiation IS supported
Compression: NONE
Expansion: NONE
SSL-Session:
    Protocol  : TLSv1
    Cipher    : DHE-RSA-AES128-SHA
    Session-ID: 20CA00067CF071B185E30BD3CC9F42202893B2645F4BF59F12F94BB1FE3765D1
    Session-ID-ctx:
    Master-Key: 5E3D97B1341004C4A9CE8A6A12673E608681D9F24B6D9892C84834985A2D35889AB87F37861636B2D52D01962457CD42
    Key-Arg   : None
    Start Time:<PHONE_NUMBER>
    Timeout   : 300 (sec)
    Verify return code: 0 (ok)

---

To conclude OpenSSL is verifying my Certificate correctly but Chef only uses the common name to do SSL verification which is the issue. As I can't find a way other than SAN Certificates to have Chef Server have multiple single certificate on the same standalone server.
Any help would be most appreciated to enable this functionality.

Agreed, this looks like something we should fix.

Thanks thommay :)

I'm assigning this to the sustaining team to see if they can replicate this on a modern chef-client binary since the openssl ruby bindings have been significantly updated in the last few years.


feat: Move Merge Expense to Platform: Moved API Call

Description

🤖[deprecated] Generated by Copilot at d47c43d
Updated the merge expenses feature to use the new platform/v1 expense model and service. This involved changing the import paths, property names, and account type enum in the merge expenses service, page, and model files.

🤖[deprecated] Generated by Copilot at d47c43d

We're merging expenses on the platform/v1
We're using the new model and the enum
Heave away, me hearties, heave away
We'll make the code more consistent and display

Walkthrough

🤖[deprecated] Generated by Copilot at d47c43d

Update the import paths for the expense model and the account type enum to reflect the new platform/v1 folder structure (link, link, link, link, link, link)
Inject the expenses service as a dependency in the merge expense page constructor and use it to get the expenses by id instead of the transaction service (link, link)
Use the new expense properties such as state, matched_corporate_card_transaction_ids, category.name, merchant, project.display_name, spent_at, amount, currency, id, foreign_currency, foreign_amount, source_account.type, project_id, is_billable, category.id, tax_group_id, tax_amount, cost_center.name, purpose, locations, started_at, ended_at, travel_classes, distance, distance_unit, custom_fields, source_account_id, cost_center_id instead of the old tx_ prefixed properties and the source_account_type property in the merge expenses service and the merge expense page (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)

Clickup
https://app.clickup.com/t/86cu0yntg
Code Coverage
Please add code coverage here
UI Preview
Please add screenshots for UI changes

Left some comments


Variadic options

This is an experimental pr that makes an attempt at masking. It is possibly the wrong approach because it attempts to prevent masked fields from being marshalled. But in reality these fields probably won't be set to being with so it adds a lot of complexity for relatively little value

Closing, not necessary at this moment. We don't want to expose options if it complicates the codebase too much


refactor: move classes from Http to Router package

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 79.482%

Totals

Change from base Build<PHONE_NUMBER>1:
0.04%

Covered Lines:
7883

Relevant Lines:
9918

💛  - Coveralls

You could also turn the argument around: maybe http-client shouldn't be a separate component then either.
No but, I get it. I don't oppose it. I'm just saying we shouldn't aim for tempest/router to be a truly usable standalone component anytime soon. It's ok to pull them apart already today and work on it later.

You could also turn the argument around: maybe http-client shouldn't be a separate component then either.

You could also turn the argument around: maybe Tempest shouldn't have components and everything should be bundled. Yet here we are and separation of concerns has some value.

I'm just saying we shouldn't aim for tempest/router to be a truly usable standalone component anytime soon. It's ok to pull them apart already today and work on it later.

That's pretty much all I'm going for here. Rip it into another standalone component and then we can continue to finesse.

👍 Feel free to merge when you're ready :)

I'm gonna close this and re-create the PR.


Firesuit resprite

About the PR
Changes the current firesuit sprite to the new TG ones (◕‿◕) made by Mr.Entropy aka Imaginos16
Screenshots

Changelog

:cl: Imaginos16

add: Added new sprite for firesuit.

If you're going to port the firesuit over, please port the full set, and edit the hi-vis stripes into their own sprite layer so they can use emissives.

Hi, author of the sprites here! I'm fine with this PR, but I will agree the above comments, I'd ideally want the full set with the fire helmets, since that's my intention as an artist. Having just that mildly defeats the purpose of my resprite I did in the respective PR: ( #67000 )
Otherwise, I'm happy to see my work has made through so many corners of the Space Station community!

I don't think this is warranted at all, nor did I really think the fire axe one was either. This is just changing sprites for the sake of changing sprites. Which I don't think we should do. Art style is orientated towards /tg/ for a reason. It's also the most recognizable of any space station 13 variety and makes the most sense for this remake to be based on. If you really want a different art style, fork the game, just like it's done for SS13.

I don't think this is warranted at all, nor did I really think the fire axe one was either. This is just changing sprites for the sake of changing sprites. Which I don't think we should do. Art style is orientated towards /tg/ for a reason. It's also the most recognizable of any space station 13 variety and makes the most sense for this remake to be based on. If you really want a different art style, fork the game, just like it's done for SS13.

Read closer, this is a tg sprite by a tg spriter.

Looking deeper into this, apparently these are /tg/ sprites, which I wasnt aware of, I'd assumed this was for another fork, since that's what many of your PRs have been, pushing different styles sprites. And looking at the artists PR, it includes much more than just a firesuit.

Looking deeper into this, apparently these are /tg/ sprites, which I wasnt aware of, I'd assumed this was from another fork, since that's what many of your PRs have been, pushing different styles sprites. And looking at the artists PR, it includes much more than just a firesuit.

Happens! As I alluded to in my previous comment, my work tends to sweep huge categories, so I don't mind people extracting specific parts. I'd just preferentially like fire helmets to be included since that's how the set in its entirety is supposed to look like. I'm sure you guys will figure out your own style for other Engineering things!

Looking deeper into this, apparently these are /tg/ sprites, which I wasnt aware of, I'd assumed this was from another fork, since that's what many of your PRs have been, pushing different styles sprites. And looking at the artists PR, it includes much more than just a firesuit.

Happens! As I alluded to in my previous comment, my work tends to sweep huge categories, so I don't mind people extracting specific parts. I'd just preferentially like fire helmets to be included since that's how the set in its entirety is supposed to look like. I'm sure you guys will figure out your own style for other Engineering things!

I think the sprites are fine when viewed in context to an entire departmental respite, and I think all of your work should be included :)

hmmm look at

This is done in the same style with an open face, while now in the build the helmets look different.
Atmos:

Without resprited helm:

for me, there is no conflicts. Should resprite helmet when other suits are updated to the new standard.

edit the hi-vis stripes into their own sprite layer so they can use emissives.

I'm not sure I understood correctly, make them glow in the dark? ushaded layer?

i tried add some glowing to stripes by PointLight. Here is the results (if u look closely). My choice is 2 radius

And I still don't know about: should replace the full head helmet by hardhat? [I am not familiar with the history of TG sprites, maybe somewhere there is a helmet corresponding to the costume]

Oh, I'm sorry. I saw that in the PR there are those very "emissives" for the suit in the form of a grayscale. So far, I don't know of a way to make them reflect light, so I'm hoping for a hint on what to do.


Adding a timer to delay UI server startup

Context
The UI server exits in error when his node is not available.
In an automatic deployment context this may cause trouble as it will immediately fail.
Depending on the deployment configuration ( ie: multi-containers pod ), the UI failure might take down the node with it.
Description
Need a to be able to pass a parameter / environment variable  to delay the start of the UI server by some seconds.
Tasks
Try to split the feature into small tasks.

[ ] add a timer
[ ] set a parameter / environment variable

I suggest to increase the timeout instead of your proposal.
In p2p/neighbor.go:
func NewNeighbor(target *Target, clientFactory ClientFactory) (*Neighbor, error) {
	client, err := clientFactory.CreateClient(target.Ip(), target.Port(), target.Value())
	if err != nil {
		return nil, fmt.Errorf("failed to create client reaching %s: %w", target.Value(), err)
	}
	settings := gp2p.NewClientSettings()
	settings.SetRetry(1, time.Nanosecond)
	settings.SetConnTimeout(commonConnectionTimeoutInSeconds * time.Second)
	client.SetSettings(settings)
	return &Neighbor{target, client, settings}, nil
}

The commonConnectionTimeoutInSeconds should be passed as a constructor parameter. I might be set to 60 for the host, and to 5 for all others.

another solution might be to modify the gp2p/client_factory.go file.
replace:
package gp2p

import (
	"fmt"
	gp2p "github.com/leprosus/golang-p2p"
	"github.com/my-cloud/ruthenium/src/log"
	"github.com/my-cloud/ruthenium/src/log/console"
	"github.com/my-cloud/ruthenium/src/node/network"
	"github.com/my-cloud/ruthenium/src/node/network/p2p"
	"strconv"
	"time"
)

const neighborFindingTimeoutSecond = 5

type ClientFactory struct {
	ipFinder network.IpFinder
	logger   log.Logger
}

func NewClientFactory(ipFinder network.IpFinder) *ClientFactory {
	return &ClientFactory{ipFinder, console.NewLogger(console.Fatal)}
}

func (factory *ClientFactory) CreateClient(ip string, port uint16, target string) (p2p.Client, error) {
	lookedUpIps, err := factory.ipFinder.LookupIP(ip)
	if err != nil {
		return nil, fmt.Errorf("DNS discovery failed on addresse %s: %w", ip, err)
	}
	ipsCount := len(lookedUpIps)
	if ipsCount != 1 {
		return nil, fmt.Errorf("DNS discovery did not find a single address (%d addresses found) for the given IP %s", ipsCount, ip)
	}
	_, err = factory.ipFinder.DialTimeout("tcp", target, neighborFindingTimeoutSecond*time.Second)
	if err != nil {
		return nil, err
	}
	tcp := gp2p.NewTCP(ip, strconv.Itoa(int(port)))
	var client *gp2p.Client
	client, err = gp2p.NewClient(tcp)
	if err != nil {
		return nil, err
	}
	client.SetLogger(factory.logger)
	return client, err
}

by:
package gp2p

import (
	"fmt"
	gp2p "github.com/leprosus/golang-p2p"
	"github.com/my-cloud/ruthenium/src/log"
	"github.com/my-cloud/ruthenium/src/log/console"
	"github.com/my-cloud/ruthenium/src/node/network"
	"github.com/my-cloud/ruthenium/src/node/network/p2p"
	"strconv"
	"time"
)

type ClientFactory struct {
	ipFinder network.IpFinder
	logger   log.Logger
}

func NewClientFactory(ipFinder network.IpFinder) *ClientFactory {
	return &ClientFactory{ipFinder, console.NewLogger(console.Fatal)}
}

func (factory *ClientFactory) CreateClient(ip string, port uint16) (p2p.Client, error) {
	lookedUpIps, err := factory.ipFinder.LookupIP(ip)
	if err != nil {
		return nil, fmt.Errorf("DNS discovery failed on addresse %s: %w", ip, err)
	}
	ipsCount := len(lookedUpIps)
	if ipsCount != 1 {
		return nil, fmt.Errorf("DNS discovery did not find a single address (%d addresses found) for the given IP %s", ipsCount, ip)
	}
	tcp := gp2p.NewTCP(ip, strconv.Itoa(int(port)))
	var client *gp2p.Client
	client, err = gp2p.NewClient(tcp)
	if err != nil {
		return nil, err
	}
	client.SetLogger(factory.logger)
	return client, err
}

In this case, the interface and usages must be modified too, and the client_factory_mock must be regenerated (see https://github.com/matryer/moq)
If you are experiencing issues to generate the mock, here is the new generated client_factory_mock code:
// Code generated by moq; DO NOT EDIT.
// github.com/matryer/moq

package p2ptest

import (
	"github.com/my-cloud/ruthenium/src/node/network/p2p"
	"sync"
)

// Ensure, that ClientFactoryMock does implement ClientFactory.
// If this is not the case, regenerate this file with moq.
var _ p2p.ClientFactory = &ClientFactoryMock{}

// ClientFactoryMock is a mock implementation of ClientFactory.
//
//	func TestSomethingThatUsesClientFactory(t *testing.T) {
//
//		// make and configure a mocked ClientFactory
//		mockedClientFactory := &ClientFactoryMock{
//			CreateClientFunc: func(ip string, port uint16) (Client, error) {
//				panic("mock out the CreateClient method")
//			},
//		}
//
//		// use mockedClientFactory in code that requires ClientFactory
//		// and then make assertions.
//
//	}
type ClientFactoryMock struct {
	// CreateClientFunc mocks the CreateClient method.
	CreateClientFunc func(ip string, port uint16) (p2p.Client, error)

	// calls tracks calls to the methods.
	calls struct {
		// CreateClient holds details about calls to the CreateClient method.
		CreateClient []struct {
			// IP is the ip argument value.
			IP string
			// Port is the port argument value.
			Port uint16
		}
	}
	lockCreateClient sync.RWMutex
}

// CreateClient calls CreateClientFunc.
func (mock *ClientFactoryMock) CreateClient(ip string, port uint16) (p2p.Client, error) {
	if mock.CreateClientFunc == nil {
		panic("ClientFactoryMock.CreateClientFunc: method is nil but ClientFactory.CreateClient was just called")
	}
	callInfo := struct {
		IP   string
		Port uint16
	}{
		IP:   ip,
		Port: port,
	}
	mock.lockCreateClient.Lock()
	mock.calls.CreateClient = append(mock.calls.CreateClient, callInfo)
	mock.lockCreateClient.Unlock()
	return mock.CreateClientFunc(ip, port)
}

// CreateClientCalls gets all the calls that were made to CreateClient.
// Check the length with:
//
//	len(mockedClientFactory.CreateClientCalls())
func (mock *ClientFactoryMock) CreateClientCalls() []struct {
	IP   string
	Port uint16
} {
	var calls []struct {
		IP   string
		Port uint16
	}
	mock.lockCreateClient.RLock()
	calls = mock.calls.CreateClient
	mock.lockCreateClient.RUnlock()
	return calls
}


CSF-strict config should include CSF config

CSF-strict doesn't include the base CSF config. This is inconvenient and inconsistent with how other libs in the ecosystem does this (like typescript-eslint, for example).
Describe the solution you'd like
CSF-strict config should include CSF config.

Looking at the code it looks like this is already the case, it's just very very unclear by the docs.

Hey @AndreaPontrandolfo thanks for reporting this. It's quite valid, the fact that the docs are unclear are worth making changes! It's done now, I hope it's more clear to you 🙏


Not all labs require cheat sheets

Now only lab 1, 2, 4 and 6 require cheat sheet updates. Other labs were removed from the evaluation template.


WIP: Return SAML LogoutResponse to RP instead of redirecting to the CAS logout page

This feature allows to return SAML LogoutResponse to RP after RP sent a SAML LogoutRequest to CAS and if configuration property cas.authn.samlIdp.logout.returnLogoutResponse is set to true.

Thanks very much.
As I understand, when CAS logout is invoked, SAML logout messages are built and passed along to clients, with SamlProfileSingleLogoutMessageCreator and family to execute SLO. It also appears that once the setting is on, a logout response is built and returned back to the application without SLO actually taking place, yes?
What need/problem are you trying to solve here with this patch?

Hi @mmoayyed
Yes you are right. Indeed I think there is a bug in this patch. My intention for this PR was that after SAML LogoutRequest sent by Service Provider to the CAS and successful logout, CAS will respond to a SP with SAML LogoutResponse. Some applications depend on this response and will redirect to a specific page after received it.
If you know how to make it possible (without any changes) then let me know. If not, I will prepare fix to execute CAS SLO properly and send LogoutResponse to a SP after that.

Is there any new progress on this issue? We had a similar issue with Microsoft ADFS, ADFS expected a SAML SLO response instead of redirecting to the CAS logout page.

For posterity:
This issue has been resolved in version 6.3.0-RC2.
Related commits:
https://github.com/apereo/cas/commit/c4cedf147fbc6bf9d396bb47f70bed1828d5ad1d
https://github.com/apereo/cas/commit/3f721bb7c5d8dc4e0be38254d7b4f0c49ce6da59


SecureNAT provides dhcp address to LAN

I've this issue: #981
for some reason, dhcp doesnt provide any more addresses to vpn clients, so I've enabled SecureNAT
but it provides dhcp addresses to my LAN too !!!
why?

You need to disable Local Bridge before enabling SecureNAT. Otherwise, the virtual DHCP server of SecureNAT will be directly connected to the Ethernet segment of the Local-Bridged physical network.

ok it works thanks


Fork jhur and add some data functions for public health data (vaccines??)

fork this to jhudsl https://github.com/muschellij2/jhur

I started this and made a new issue that is more specific :)


QLora Support

Feature request
Add 4-bit quantization support when bitsandbytes releases.
Motivation
Run larger models easily and performantly
Your contribution
I could make a PR if this is a reasonably easy first task or 2.

Hello,
Wondering if you got any insights on what would be the inference performance of bitsandbytes 4bit compared to 8bit. Will it be any better? In my experience, 8bit is around 8x slower compared to fp16. Yet to try llama GPTQ(waiting for it be available in this server).

Hello,
Wondering if you got any insights on what would be the inference performance of bitsandbytes 4bit compared to 8bit. Will it be any better? In my experience, 8bit is around 8x slower compared to fp16. Yet to try llama GPTQ(waiting for it be available in this server).

Is it planned to support GPTQ models with this Server?

Dear @OlivierDehaene ,
Thank you very much for all of your work on text-generation-inference!
Recognizing the effort required, I'm offering to cover the Lambda costs for a H100 instance for your use during implementation. Could you please estimate the timeline for this feature?
Thank you for considering this proposal.
Best Regards

Thanks @OlivierDehaene, is there any support for LORA?

Yep, 4bit inference with bnb is super slow.
GPTQ is pretty fast though. On my hardware it's actually faster than inferencing with fp16.
There's a high-level library called Autogptq (https://github.com/PanQiWei/AutoGPTQ) that makes adding GPTQ support like just a couple lines (the original gptq-for-llama library is tougher to integrate and tends to have random breaking changes).

Would love to GPTQ support added

There is a PR opened for adding GPTQ support for llama #267 not sure if it will be amended to support all the other models as well. Eagerly waiting for this.


create connection class

a class for one connection from one item to an array of others. should also include a map of items to values for weighted graphs

solved it using a small short method in NewItem class instead


Add provision command to generate certs

There are a number of certs which are needed to spin up the OpenTDF platform. For proof-of-value mode it is convenient to generate certs for local-development -- these are typically self-signed.
When it comes to production deployment, most of these certs need / will be managed by a separate cert manager. (i.e. https://github.com/openbao/openbao)
To improve the experience of contributors and consumers alike as well as reducing the prerequisites and maintenance we should move our cert management from Bash + OS specific scripts into a Go command.
There is already a fantastic tool https://github.com/FiloSottile/mkcert which has solved a lot of these problems. Since this is a Go tool we could extend this to generate self-signed certs for our services as well as certs for KAS.
Acceptance Criteria

draft an interactive opentdf provision certs command

This command should use https://github.com/charmbracelet/huh to guide the user through the process of provisioning certs for

grpc services
keycloak
kas keys (RSA + ECC)

draft a opentdf provision certs kas [flags] [<args>]
draft a opentdf provision certs x509 [flags] [<args>]
draft a opentdf provision cert ca [flags] [<args>]

This should not have been closed and is still necessary for maintainability.


(InvitingGuests) IE9 issues

There should be some space between the footer and the activity item above it

Uploading a profile picture does not appear to be working. In fact, it doesn't look like any uploads work.

There's no spacing between individual items in the invitation email

The Share With modal doesn't render for a discussion

Assigning to @mrvisser

There should be some space between the footer and the activity item above it

Fix submit in https://github.com/oaeproject/Hilary/pull/1234 > https://github.com/oaeproject/Hilary/commit/cbd545f853752e47ddec13e1b120a0010e47e841

Uploading a profile picture does not appear to be working. In fact, it doesn't look like any uploads work.

File uploads and uploading / cropping profiles pictures is working fine for me in VirtualBox (IE9 + Windows 7). Could it be your environment?

The Share With modal doesn't render for a discussion

Fixed in this PR. There was a race condition.

Assigned to @nicolaasmatthijs for review

Looks good. Merged


GH-34375: [C++][Parquet] Ignore page header stats when page index enabled

Rationale for this change
parquet-mr does not write page stats to the header once page index is enabled: https://issues.apache.org/jira/browse/PARQUET-1365. We should follow the same thing.
What changes are included in this PR?
Once page index is enabled for one column, it does not write page stats to the header any more.
Are these changes tested?
Added a test to check page stats have been skipped.
Are there any user-facing changes?
NO.

Closes: #34375

Seems OK to me as writing column indices is opt-in?

Seems OK to me as writing column indices is opt-in?

Yes, by default page index is disabled. I am not sure if we should turn on it by default someday to align with what parquet-mr does.

Yes, by default page index is disabled. I am not sure if we should turn on it by default someday to align with what parquet-mr does.

I think we eventually want to turn it on by default. We just release support for it in 12.0.0, but it's not yet used for any data skipping in the Parquet reader or dataset scanner (right?). I think we should add support for leveraging it in the readers in 13.0.0, and then if it seems to be working for users we can turn in on by default in 14.0.0. Does that seem like a reasonable plan?

I think we should add support for leveraging it in the readers in 13.0.0

Yes, but I don't think the time frame is sufficient for a complete page skipping implementation. We can support it progressively.

Sure. So I suppose modify my proposal to: if we fully support predicate pushdown for page index in version N, let's set this to default in version N + 1 (assuming there are no unresolved issues we find).

I guess maybe a user previously uses page filter. Now when he/she enables page index, the filter would not work

I think the documentation is also missing for stats filtering on the page header. Since page index is an ongoing effort and it is not enabled by default, users will not get confused by this for now.

About statistics, though nan will break the page index, and page statistics and make full use of nan-counts. I think this on-going patch helps https://github.com/apache/parquet-format/pull/196

Due to the inactivity in that PR, I assume it will take a long time to move forward as we need somehow to reach a consensus from the community.

Could you please take a look again? @pitrou

Did you try to benchmark writing the page index vs. writing statistics in data page headers?
Perhaps in the future we can enable the page index by default?

Did you try to benchmark writing the page index vs. writing statistics in data page headers? Perhaps in the future we can enable the page index by default?

I didn't benchmark the writer time because it should spend more time when page index is enabled because:

It only skips writing stats to the thrift-encoded header but the stats comparison (which is heavy) in the column writer still does the job.
Page index builder also does more work than just serializing stats. It also collects sorting order from page stats, collects page offsets and so on.

The main goal of skipping writing stats to page header mainly is to reduce the file size as they are duplicated and easier to get from the column index. We have internally enabled page index by default. The benefit brought by page index is promising.

We have internally enabled page index by default. The benefit brought by page index is promising.

Did you measure the benefits (other than file size)?

Yes, it could achieve 2X~4X acceleration of reading column chunk from cloud object store using page offset index (with I/O coalescing) compared to issue single I/O of a full column chunk (which is currently by default).

Nice, I see. What about the column index, are you using it?

Nice, I see. What about the column index, are you using it?

Yes, we did a naive implementation of predicate push down similar to what the parquet-mr does.

@wgtmac could you elaborate on how you are achieving 2X~4X acceleration of reading the column chunk from the cloud object store you mentioned above? Are you reading the column chunk page by page?

@wgtmac could you elaborate on how you are achieving 2X~4X acceleration of reading the column chunk from the cloud object store you mentioned above? Are you reading the column chunk page by page?

In short, collect all offset/length ranges of required pages, then coalesce them into reasonable I/O chunks and issue async reads before reading any page.


Event modifier which enables text selection on focus

I am building a UI for an app where users will want to quickly change number values in a table (like a spreadsheet). It would be much better in this case to have the entire contents of the input selected on focus.
This pull request adds an event modifier v-focus.select='expression' which does just that.

Yes, yes, yes!! Please accept this pull request :)

@simplesmiler any thoughts on this PR?

@simplesmiler I'd also like this feature!

Does it allow to use it like this: v-focus.lazy.select="true"?

@shepelevstas yes, that's how I have been using it.


available az for cn-northwest-1

Is there an existing issue for this?

[x] I have searched the existing issues

Current Behavior

2021/12/17 09:26:39 DEBUG: Response sts/GetCallerIdentity Details:
---[ RESPONSE ]--------------------------------------
HTTP/1.1 403
Content-Length: 305
Content-Type: text/xml
Date: Fri, 17 Dec 2021 09:26:38 GMT
X-Amzn-Requestid: 48993052-8b1d-4eb9-8222-3b3d36414ff4

2021/12/17 09:26:39

Sender
InvalidClientTokenId
The security token included in the request is invalid

48993052-8b1d-4eb9-8222-3b3d36414ff4

{"level":"info","msg":"Couldn't get account Id for role : InvalidClientTokenId: The security token included in the request is invalid\n\tstatus code: 403, request id: 48993052-8b1d-4eb9-8222-3b3d36414ff4\n","time":"2021-12-17T09:26:39Z"}
{"level":"debug","msg":"Metrics scraped.","time":"2021-12-17T09:26:39Z"}
{"level":"debug","msg":"Scraping every 300 seconds","time":"2021-12-17T09:26:39Z"}
Expected Behavior
I specified the region to  'cn-northwest-1' in china ,
does it support the az in china ?
thanks
Steps To Reproduce
docker run -e regions='cn-northwest-1' -e aws_access_key_id='111111111111111'  -e aws_secret_access_key='2222222222222'  -itd    -v $PWD/config.yml:/tmp/config.yml -p 5000:5000 --name yace ghcr.io/nerdswords/yet-another-cloudwatch-exporter:v0.33.0-alpha   "--config.file=/tmp/config.yml" "--debug"
Anything else?
No response

This looks like a problem with CREDS.
Still a problem?
Can you try to give the docker container AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY env vars?

{"level":"info","msg":"Parse config..","time":"2022-11-09T03:23:18Z"}
{"level":"info","msg":"Startup completed","time":"2022-11-09T03:23:18Z"}
{"level":"debug","msg":"Starting scraping async","time":"2022-11-09T03:23:18Z"}
{"level":"debug","msg":"Scrape initially first time","time":"2022-11-09T03:23:18Z"}
2022/11/09 03:23:18 DEBUG: Request sts/GetCallerIdentity Details:
---[ REQUEST POST-SIGN ]-----------------------------
POST / HTTP/1.1
Host: sts.amazonaws.com
User-Agent: aws-sdk-go/1.44.127 (go1.18.8; linux; amd64)
Content-Length: 43
Authorization: AWS4-HMAC-SHA256 Credential=AKIAXHMHPBOVUM4ZBZFQ/20221109/us-east-1/sts/aws4_request, SignedHeaders=content-length;content-type;host;x-amz-date, Signature=2d1f52df7ae202a9b86366ef7596e44c0ca6349721768317c211c713c4cefa0b
Content-Type: application/x-www-form-urlencoded; charset=utf-8
X-Amz-Date: 20221109T032318Z
Accept-Encoding: gzip
Action=GetCallerIdentity&Version=2011-06-15
2022/11/09 03:23:20 DEBUG: Response sts/GetCallerIdentity Details:
---[ RESPONSE ]--------------------------------------
HTTP/1.1 403 Forbidden
Content-Length: 306
Content-Type: text/xml
Date: Wed, 09 Nov 2022 03:23:20 GMT
X-Amzn-Requestid: 54dfff07-13de-4df7-8142-db74e68ae2d8

2022/11/09 03:23:20

Sender
InvalidClientTokenId
The security token included in the request is invalid.

54dfff07-13de-4df7-8142-db74e68ae2d8

{"arn":"","error":"InvalidClientTokenId: The security token included in the request is invalid.\n\tstatus code: 403, request id: 54dfff07-13de-4df7-8142-db74e68ae2d8","job_type":"s3","level":"error","msg":"Couldn't get account Id","region":"cn-northwest-1","time":"2022-11-09T03:23:20Z"}
{"level":"debug","msg":"Metrics scraped.","time":"2022-11-09T03:23:20Z"}
{"level":"debug","msg":"Scraping every 300 seconds","time":"2022-11-09T03:23:20Z"}

admin@admindeMacBook-Pro ~ % docker exec -it ffbfb71cb399b1bbf3b07d103c8e77d75eb
3f1bae9f58cf77ae0c570118a55e7 /bin/sh
~ $
~ $
~ $ ls
~ $ env
HOSTNAME=ffbfb71cb399
SHLVL=1
HOME=/exporter
regions=cn-northwest-1
TERM=xterm
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
AWS_ACCESS_KEY_ID=AKIAXXX
AWS_SECRET_ACCESS_KEY=kcHNXXXX
PWD=/exporter
~ $

Same problem


[Feature]: Add replica.synchronous option

Is there an existing issue already for this feature request/idea?

[X] I have searched for an existing issue, and could not find anything. I believe this is a new feature request to be evaluated.

What problem is this feature going to solve? Why should it be added?
We have no way at the moment to add a replica cluster as potential synchronous standby in a quorum.
Describe the solution you'd like
A Postgres cluster that is currently a primary in a distributed scenario, can request to have a designated of a downstream replica cluster participate as a potential synchronous standby in a quorum. Consider the example in #3942 regarding pg1, but modified as follows:
  instances: 3
  minSyncReplicas: 1
  maxSyncReplicas: 1
  replica:
    primary: pg1
    source: pg2
    enabled: auto
    synchronous:
    - pg2

The operator should add pg2 to the list of servers participating to the quorum. We might need to revise how the quorum is calculated, but we can do further analysis when things are clearer - as this ticket depends on several other tickets.
If we don't like this automated way of managing replica clusters sync rep, let's just proceed with the alternative approach.
Describe alternatives you've considered
Add a more generic additionalSynchronousStandbyNames option under postgresql section.
Additional context
No response
Backport?
No
Are you willing to actively contribute to this feature?
Yes
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I am suggesting to postpone this feature at least to 1.25, and first receive feedback on the new controlled switchover feature.
CNPG currently supports only quorum sync rep. This feature would simply add the list of specified external cluster names to sync_standby_names only if the local sync rep is enabled, as otherwise it could break self-healing.
I would like to get more clear use cases from users out there before committing a feature that is not achieving what we'd expect.

Superseded by #5095


Ss/rocket example

What problems are you facing?

Hey @samsamai, can you push the latest draft up here? Even it can't be compiled.

Hi @tyt2y3 @billy1624 , yeah I've been trying to clean up the code it tonight but I'm having some weird problems, it is giving errors that I wasn't getting before. I just rebooted and updated rust... 🤞

Still doing it, it's weird, I'm going back to one of my commits from before but getting lots of these:
error[E0425]: cannot find function, tuple struct or tuple variant `ColumnFromStrErr` in module `sea_orm`
  --> /Users/sam/Code/github/sea-orm/src/tests_cfg/fruit.rs:20:40
   |
20 | #[derive(Copy, Clone, Debug, EnumIter, DeriveColumn)]
   |                                        ^^^^^^^^^^^^ not found in `sea_orm`
   |
   = note: this error originates in the derive macro `DeriveColumn` (in Nightly builds, run with -Z macro-backtrace for more info)

Not sure what it's doing with test_cfg when my code is a crate inside examples

Try cargo update

Thanks! that was it!

@billy1624 I pushed up the version that I have, sorry it is really messy as I was trying everything to just get it to work.
It needs this repo to run: git@github.com:samsamai/Rocket.git, branch:  ss/seaorm-contrib so if you pull that down locally and change the examples/rocket_example/Cargo.toml and also contrib/db_pools/lib/Cargo.toml in this rocket repo, it should work locally.
cargo run in the rocket_example dir, and then http://<IP_ADDRESS>:8000/sqlx
It's hard coded to use mysql (see the rocket side) just to get it working.

Okay, so that means we need to open a PR on Rocket!

Looks good so far. I am just puzzling, what's prevent us from generalizing over MySQL and Postgres?

We should be able to, I'll have to fix the implementation of the rocket driver first, right now it is not using a pool and just had mysql hardcoded in so we could get things working.

okay, thank you for the explanation!

@tyt2y3 Rocket expects us to implement rocket_db_pools::Pool for the struct that we have chosen to derive database on.
This impl needs an init where the database pool is initialized with various options, and a get which returns a connection from the pool.

Any other problem we need to solve? @samsamai

I think it would help with the Rocket integration if there was a general Sea-Orm pool type, which would generalize over all the different DB types. Currently we have SqlxMySqlPoolConnection, SqlxPostgresPoolConnection and SqlxSqlitePoolConnection but I can't see anything like a SeaOrmPool that generalizes over them.
If there was such a thing then the rocket driver would look something like this in pseudo:
#[rocket::async_trait]
impl rocket_db_pools::Pool for sea_orm::SeaOrmPool {
    type Error = sea_orm::DbErr;

    type Connection = sea_orm::DatabaseConnection;

    async fn init(figment: &Figment) -> Result<Self, Self::Error> {
      // let pool = Connect to database via url
      // return Ok(pool)
    }

    async fn get(&self) -> Result<Self::Connection, Self::Error> {
        // return a connection from the pool
        // return Ok(self.pool.acquire().await)
    }
}

okay, I think we can name it sea_orm::RocketDbPool
@samsamai would you need help from @billy1624 on this?

@tyt2y3 Yes sure, @billy1624 help is always appreciated. I'll make a start on it and ask if I get stuck.

Looks really good now!
@samsamai is there still anything missing?
@billy1624 what's your thought?

I've been adding some templates so that the example renders html and is more interactive. I will check that in soon and then have a look at getting db_url in the run_migrations.

Wow we got an UI for it? Cool! @samsamai

I think we are missing a link to /read the post?

@tyt2y3 I added an edit page which serves dual purpose.

This is ready to launch, I reckon. 😉


fix(aws-lb-controller): wait till deployed

Issue #, if available:
N/A
Description of changes:
AlbController webhook isn't ready directly after the AddOn deployment.
This cause a race condition when another AddOn creates Kubernetes Manifest resources that rely on it, like TargetGroupBinding.
Sometimes it is successful, sometimes not. To avoid such situations, addHelmChart of AlbController should wait similar as it was implemented for External Secrets: https://github.com/aws-quickstart/cdk-eks-blueprints/pull/514
Example of such an error when the proposed fix is not applied:
Received response status [FAILED] from custom resource. Message returned: Error: b'Error from server (InternalError): error when creating "/tmp/manifest.yaml": Internal error occurred:
failed calling webhook "mtargetgroupbinding.elbv2.k8s.aws": failed to call webhook: Post "https://aws-load-balancer-webhook-service.kube-system.svc:443/mutate-elbv2-k8s-aws-v1beta1-tar
getgroupbinding?timeout=10s": no endpoints available for service "aws-load-balancer-webhook-service"\n'

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/do-e2e-tests

/do-e2e-tests


zh,en: update dmctl commands

What is changed, added, or deleted? (Required)
update dmctl command for v2.0.1

Which DM version(s) do your changes apply to? (Required)

[x] master (the latest development version, including v3.0 changes)
[x] v2.0 (TiDB DM 2.0 versions)
[ ] v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

https://github.com/pingcap/dm/pull/1333
https://github.com/pingcap/dm/pull/1316
https://github.com/pingcap/dm/pull/1323

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

[ ] Delete files
[ ] Change aliases
[ ] Need modification after applied to another branch
[ ] Might cause conflicts after applied to another branch

Should we merge this PR after v2.0.1 is released? @csuzhangxc @lance6716

Should we merge this PR after v2.0.1 is released? @csuzhangxc @GMHDBJD

YES, and #516, #517, #518 should be merged after v2.0.1 released.


Use a new 'use' style

This normalizes all use to a slightly different style that I've grown to like in other projects.
This also updates CONTRIBUTING.md (from #48) to include the logic of this use group style.
I mostly like this style because it groups uses together and creates no ambiguity as to how things should be formatted. There's always one use statement per top-level item, so there's never any decision that needs to be made about what imports to group together and what imports not to group together.
CC @ASalvail: see what you think of this.
I don't think it's a big thing, but it does affect all the code. I don't feel too strongly about this particular style, but I would like to normalize to something.

Might I also suggest alphebetical order when using collections of import?

Alphabetical order is good- rustfmt / the formatting guidelines should enforce that but it can't hurt to write it in here as well. I'll fix that and not mentioning module documentation
Re: Rust 2018 module system:
I've been avoiding using it for a while mostly because it's an unstable feature and there were some decisions yet to be made. I'd probably prefer to wait until it's stable to use, just to avoid extra work fixing any breaking changes that pop up. I realize we already depend on nightly, but still, the fewer different nightly things that break, the better. We can definitely switch when  the module system is stabilized and usable without another #![feature] attribute.

That's fine by me. We can have a PR specifically to transition to rust 2018 later.

I think this should address all of the comments and be up-to-date with master. We probably want to merge #40 first then this if both are good?

:+1:
thanks for reviewing and getting me to write all this down in the documentation!