Bootstrap 5

This PR upgrades bootstrap to v5.1.3
As the original bootstrap integration was kinda hacked-in, this implementation will be a lot more methodical and conformant to the bootstrap "standards".
(Read: Previously I had no idea what I was doing...)
Note: This will most likely be a long-running PR as there will be a lot of changes required...
Closes https://github.com/inventree/InvenTree/issues/2111
TODO

[x] Navbar
[x] Search input
[x] main drop-down menus
[x] Refactor sidebars (remove dependency)
[x] Refactor API forms (client side)
[x] Refactor modal forms (server side)
[x] Fix dropdown-toggles for menus
[x] Fix button callbacks (e.g. "cancel" button in forms)
[x] Fix hover actions for thumbnail images
[x] Table CSS fixes
[x] Fix panels
[x] Refactor "card" display for part table
[x] Refactor "label" classes (very different in v5)
[x] Refactor "detail" panel for major screens to be more "bootstrappy"
[x] Enforce "breadcrumb" view for each page (and standardize)
[x] Search results page
[x] Index page
[x] Settings page
[x] Refactor "button group" instances - perhaps a html template here?
[ ] Refactor "table filters" UI (see comment below) (will leave for a separate PR)
[x] Use CSS custom properties to allow for easier theming
[x] Replace all instances of "data-toggle" with "data-bs-toggle"
[x] Remove all instances of "action-buttons" class
[x] Remove all instances of "btn-default"
[x] Remove all references to "two_column.html" template
[x] Replace "media" and "media-left" with "card"
[x] Replace "panel" with "card"
[x] Replace "label" width "badge" - https://getbootstrap.com/docs/5.0/components/badge/
[x] Fix action buttons in "part category" and "stock location" display (see comment below)
[x] Remove all instances of "{% block menubar %}"
[x] Remove all instances of "enableNavbar" (replace with enableSidebar)
[x] Remove all instances of "attachNavCallbacks"
[x] Remove all instances of "sideNav"
[x] Replace "tree view" for parts and stock
[x] Refactor all existing "admin" buttons

@matmair @eeintech I'm pretty happy with this now, can you guys please pull this down and see if anything obvious stands out? It is a pretty major overhaul of the front-end visuals, so feedback is appreciated!

@matmair @eeintech I'm pretty happy with this now, can you guys please pull this down and see if anything obvious stands out? It is a pretty major overhaul of the front-end visuals, so feedback is appreciated!

Already have done that throughout the process, there seem to be some problems with wrapping on upright iPads - will submit a PR to fix that

Looks really nice by the way. Should we refactor the themes too?

there seem to be some problems with wrapping on upright iPads - will submit a PR to fix that

Should we refactor the themes too?

Yes, to both these things. Let's address these with separate PRs.

@SchrodingersGat is it intentional that the treeview for parts and stock locations is not there anymore? I found that feature very handy.

@matmair the "tree view" is now implemented in the subcategory and sublocation tables, like so:

You can toggle this view in the top-right of the table:

Does this meet your needs? The dedicated tree views could be added back in but I'd do it a different way now, the old method was very inefficient.

@SchrodingersGat we should document any major UI shifts in the release notes so nobody gets confused

Does this meet your needs? The dedicated tree views could be added back in but I'd do it a different way now, the old method was very inefficient.
@SchrodingersGat, sorry to intrude, but I also find this treeview very helpful for quick navigation. As a suggestion, what do you think about adding a drop-down list with part subcategories near the current breadcrumbs. In this way it will consume only one line of vertical screen space and you still be only one click away from any subcategory.

@sintech @matmair happy to add it back in, as it seems it was appreciated.
@sintech can you describe your idea further? Maybe an example diagram?

@matmair I am happy with the current solution. Just needed to be pointed to the filter.

@SchrodingersGat, I have created new FR with mockups #2250.


Make vizviewer test more stable on Mac on github actions

Now vizviewer test sometimes fails on nightly validations(example). It's not a real failure, just the port is somehow occupied. As vizviewer does support custom ports, we can maybe check if the port works first, then try to test on it, which will reduce the fake positives in nightly validation.

So can I just try another port?

Well, not exactly. We should not simply try different ports after failing on a port, as there might be some cavets like "it will always fail on the first try". We should use another independent way to confirm a port is working, before we try vizviewer on that port.

I see. Could we provide a method to find a free port that is not working and then try to test Viewer on it?

Yes, we can implement a new method in the test class to find a free port first, then test on it.

If we find a free port first, the cases to test use_external_processor option can use this port but not 10000. Right?

I melt a problem when I complete my codes: The test_use_external_processor case could not pass. And when I try to execute vizviewer --use_external_processor temp.json, it took a long time but nothing happened until I killed it. I don't know what happened.
My device is Macbook Pro M1 Max. I can see the Python took a 100% CPU usage like it melt a dead loop.

If we find a free port first, the cases to test use_external_processor option can use this port but not 10000. Right?

No, test_use_external_processor is another thing. The issue is about the other general tests which usually run on port 9001. You can refer to the example link for a failure case.

If we find a free port first, the cases to test use_external_processor option can use this port but not 10000. Right?

No, test_use_external_processor is another thing. The issue is about the other general tests which usually run on port 9001. You can refer to the example link for a failure case.

Oh, I see.

This issue is fixed by #286.


Rendering formula value although widget is collapsed

Fixes #103.
CR: @viddo
cc @saleiva

:shipit:

Thanks!


FIX: Support hashing of FILES

Properties used for hashing FILE are:
name, size, type and lastModified

Are you able to add a test, or should somebody else do that?

Sorry, i can't do it in any reasonable time frame.


net core bug?

I had .net 3.4 before, amumss said it needs 5.0, so I updated and have 6.0, so an even further branch, since 5.0 is no longer supported. and I still get errors.

Sorry for the trouble!
AMUMSS uses MBINCompiler.exe AND MBINCompiler.exe REQUIRES '.NET 5 x64 Desktop Runtime' latest version to run.
It can be found at https://dotnet.microsoft.com/download/dotnet/5.0/runtime
Even if .NET 5 is technically at 'end of life', that is what is required for now and .NET 6 is NOT backward compatible with .NET 5
I updated the README to reflect this


Switch from Travis-CI to GitHub Actions

we're looking to reduce Travis-CI usage in scala/*
(as per https://github.com/scala/scala-dev/issues/785)
volunteer?

Seems like you have done it already. Is there anything left I could help with?

ah, so I did! it's only an oversight that I didn't close this ticket.

Is there anything left I could help with?

w/r/t GitHub Actions specifically?

w/r/t GitHub Actions specifically?

Yeah, I meant github actions, but since you said that it was only an oversights with the ticket being left open I guess that you are good :)


Repo sync for protected CLA branch

The pull request is created from master637432422976334403 to master to fix git push error for protected CLA branch

@ghogen : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Analysis server generates quickfixes that modify the Flutter SDK

Found by @bradmuzza at https://github.com/Dart-Code/Dart-Code/issues/1341. If you call some Flutter framework code incorrectly, you may get quick-fixes that make modifications to the Flutter SDK source files:

If you click Add required parameter, it'll insert this as a new param in the definition of IconButton.
Note: In VS Code, this results in the file being opened, made dirty, and a "You're modifying a file outside your workspace" message, however it's still pretty easy for a user to just hit Save All or something and end up with a broken SDK.
This is similar to https://github.com/dart-lang/sdk/issues/33181 where it was deemed that generated edits outside of the analysis roots probably didn't make sense, so I think the same logic could work here (rather than being specific to the Flutter SDK).
cc @bwilkerson @scheglov

https://dart-review.googlesource.com/c/sdk/+/87382


Add SslProvider.isOptionSupported(...)

Motivation:
Sometimes it is useful to understand if an SslContextOption is supported or not by a given SslProvider.
Modifications:
Add new static method which allows to check if an option is supported or not
Result:
Easier to reason about if an option is supported or not

We need something similar in Channels also. There are options that only apply to a SocketChannel, ServerSocketChannel, or both.

@hyperxpro you can use config().setOption(...) and check if it returns true there. So I dont think so .


Broker nodes may need to blacklist historicals/realtimes

A historical node that announces in ZK but does not respond to any network connections  can cause the broker to keep selecting it for queries and fail often.

Same issue as #5709. Even though this one's older, the newer one has some more discussion, so I'll keep that one open.


README

README
User Story
As a bootcamp student
I want the prework notes to be organized on a webpage
So that I can look back and reference it
Acceptance Criteria
GIVEN the prework project repository
WHEN I view the README
for the repository
THEN I can see a professional README that provides information on the project and how to use it

Added professional README file


Fix typo in release.yaml

The variable ${{ github.events.input.release }} is invalid, it should be inputs.release 🙄
/kind cleanup
Submitter Checklist

[n/a] Includes tests if functionality changed/was added
[n/a] Includes docs if changes are user-facing
[y] Set a kind label on this PR
[y] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
NONE

/lgtm


add rocksdb option to makefile

Description

Add build flags for rocksdb to the makefile

Codecov Report

Merging #763 (8855d99) into main (d342086) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #763   +/-   ##
=======================================
  Coverage   18.72%   18.72%
=======================================
  Files         174      174
  Lines       23921    23921
=======================================
  Hits         4480     4480
  Misses      18665    18665
  Partials      776      776

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d342086...8855d99. Read the comment docs.


haw-hamburg:0.1.0

I am submitting

[x] a new package
[ ] an update for a package

Description: This allows Typst users to write their bachelor or master thesis using the design of the haw-hamburg.

I have read and followed the submission guidelines and, in particular, I

[x] selected a name that isn't the most obvious or canonical name for what the package does
[x] added a typst.toml file with all required keys
[x] added a README.md with documentation for my package
[x] have chosen a license and added a LICENSE file or linked one in my README.md
[x] tested my package locally on my system and it worked
[ ] excluded PDFs or README images, if any, but not the LICENSE

[x] ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

I haven't excluded some PDFs from examples so users can have a fast view how the template looks like.
I saw that many packages have example PDFs. If you  think I should remove them, I can remove them of course.

Because you excluded the whole examples directory, the PDF files are excluded as well. And it makes sense to do so in my opinion, because these files are not necessary to have in the local cache for the package to work correctly (and most people will have a look in your GitHub repo if they want to see the examples, not in the package cache on their machine).
The bot listed a few variables and functions that are not named following Typst conventions, but you can choose to ignore these warnings if you want to, tell me what you prefer.

Thanks for letting me now, I have just fixed all the warnings :)
I always try to adhere to the naming conventions of course, but still need to get used to it :)

Thank you for making the changes, and for the package :)


nvidia module: set LD_LIBRARY_PATH

It's needed for CUDA driver, which applications are supposed to dlopen() and
which is a driver version-dependent.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Tested on Tensorflow which works now. I'll merge in several days unless there are better ideas.

@abbradar See #67791 and https://github.com/NixOS/nixpkgs/pull/67791#issuecomment-526755769

I guess we'll need to roll back on 19.09 after all. However there are at least two different issues:

older applications not working without LD_LIBRARY_PATH;
CUDA broken because libcuda cannot be found.

I don't know any better way to solve the second issue than leaving LD_LIBRARY_PATH enabled for Nvidia (on master too) .
On September 2, 2019 8:21:54 AM GMT+03:00, worldofpeace<EMAIL_ADDRESS>wrote:

@abbradar See #67791 and
https://github.com/NixOS/nixpkgs/pull/67791#issuecomment-526755769
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/67893#issuecomment-527005358

--
Nikolay.

@abbradar things in nixpkgs have been using addOpenGLRunpath to patch the runpath on executables and shared libraries, e.g. I submitted a PR for fix CUDA in mpv: #67790

@ivan This is similar to OpenGL drivers before libglvnd became a thing, we used LD_LIBRARY_PATH instead of patching all OpenGL software.
I'm not sure if we want to start using addOpenGLRunpath now but that's an architectural decision. Personally I think LD_LIBRARY_PATH is less error-prone as it's very simple to accidentally link to nvidia_x11 instead of using addOpenGLRunpath in a package, and this is wrong and breaks when packages come from different version of nixpkgs.

This was done in https://github.com/NixOS/nixpkgs/commit/370d3af0c40c30f1dad763c35a2db637f70e6176 for #11434, but I don't fully understand the rationale.
"Currently Mesa and NVidia drivers don't set setLdLibraryPath because they work with libglvnd and do not override libraries" - I believe this is referring to GL calls going through libglvnd and thus not needing LD_LIBRARY_PATH for just GL functionality.
I believe https://github.com/NixOS/nixpkgs/issues/11434#issuecomment-494928821 references some specific problem that this change solved ("any program that links to one of these libraries will load the one from the AMD drivers. This can result in horrible breakage") but I don't know the details, maybe @ambrop72 can clarify?

The idea is that now for dispatch libraries we either:

use vendor configuration files which specify full paths to libraries;
use setOpenGLRunpath for edge cases (no configuration file, gets library name via GLX etc.).

That means that for vast majority of cases LD_LIBRARY_PATH is not needed anymore because we localized all library search to those dispatch libraries. The problems, however, start when there's no dispatch library for something (i.e. CUDA) - cudatoolkit is only one point of entry into it. IMO for these cases we should fall back to the old approach, which is LD_LIBRARY_PATH - the world of library end-users is potentially immense and checking and patching all these packages would be much bigger task than fixing just the dispatchers.
Regarding the comment - LD_LIBRARY_PATH can be harmful when the driver itself is broken (in this example API drivers) and provides replacements for system libraries. This is out of scope - NVIDIA drivers are clear in that regard.

@ambrop72 I see now that you already patched some packages to find CUDA, what do you think of my suggestion instead?
My argument is that it's less error-prone that way (especially if application links to libcuda directly, in which case it's very difficult to notice that it's broken), makes CUDA applications easier to package and that our old policy was to avoid patching all the world, opting for LD_LIBRARY_PATH when we cannot fix this by controlling only dispatcher libraries.

I believe #11434 (comment) references some specific problem that this change solved ("any program that links to one of these libraries will load the one from the AMD drivers. This can result in horrible breakage") but I don't know the details, maybe @ambrop72 can clarify?

Whenever a driver ships with their own version of some library, e.g. llvm, which uses the same sonames as system libraries, if an application both links to a nixpkgs driver and uses the driver (possibly very indirectly), only one of the libraries will end up used, one thing will inevitably use the wrong version. This cannot be solved due to the design of Linux dynamic linking. However, if those driver-specific libraries end up in LD_LIBRARY_PATH, then every program that links to such a conflicting library is affected, not just programs that actually use the driver.
I understand the arguments about breaking things, but I think the simple solution of sticking with LD_LIBRARY_PATH is just too invasive, as it has potential to break every program, including those that do not use, or affect startup time. Therefore I still think this (or #67791) should go to 19.09 only and we fix the breakages on master. By the way could we have a meta bug to keep track of such breakages? I can assist fixing them.

Also, if we keep the LD_LIBRARY_PATH for 19.09 and backport addOpenGLRunpath fixes to 19.09, then the "older applications not working without LD_LIBRARY_PATH" problem will not be after the upgrade to the next release, where LD_LIBRARY_PATH finally disappears, assuming one is not using applications older than 19.09.

Regarding the comment - LD_LIBRARY_PATH can be harmful when the driver itself is broken (in this example API drivers) and provides replacements for system libraries. This is out of scope - NVIDIA drivers are clear in that regard.

Sorry I missed this, yes the NVidia drivers seem fine. But I still wouldn't want to undo the work that went into getting rid of LD_LIBRARY_PATH because of one case (CUDA) and which only affects a fraction of people.

Sorry, my fault - I mentioned you here only after I noticed you already patched some software.
My problem is specifically with CUDA: addOpenGLRunpath is a burden to use for all CUDA applications, and it may be very difficult to do correctly (I especially fear stuff linking against libcuda because it will lead to hard to debug errors when driver versions are different).
Regarding number of CUDA users - I think that amongst people with nvidia GPUs it's actually a pretty frequent usecase, as a lot of random software makes use of it (ml libraries, blender, cryptominers, mpv, games etc.), and we only revert this flag back for Nvidia users.
There are also possible edge cases like people dlopening libcuda from interpreters like Python, but there's not a single case that I know of.
Overall my point is - sadly we don't have a single entry point, so instead of plugging holes let's use the sledgehammer.
On September 2, 2019 8:27:17 PM GMT+03:00, Ambroz Bizjak<EMAIL_ADDRESS>wrote:

Also, if we keep the LD_LIBRARY_PATH for 19.09 and backport
addOpenGLRunpath fixes to 19.09, then the "older applications not
working without LD_LIBRARY_PATH" problem will not be after the upgrade
to the next release, where LD_LIBRARY_PATH finally disappears,
assuming one is not using applications older than 19.09.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/67893#issuecomment-527210443

--
Nikolay.

I think the sledgehammer approach is inconsistent with Nix/NixOS philosophy which is focused on purity. Of course we can't be pure here, so the current solution for such problems is to fix individual packages to look in impure places (/run/opengl-runpath).
By the way I filed a PR to fix Houdini (#67958). Generally I will be glad to fix other programs that I am told about.

My problem is specifically with CUDA: addOpenGLRunpath is a burden to use for all CUDA applications

Please note that for big applications, setting LD_LIBRARY_PATH in a wrapper (which in many cases already exists) is a simpler approach than patchelf.

I suggest that this is merged only to 19.09 and without reverting the CUDA fixes. This would fix the immediate 19.09 issues and leave the most freedom to decide how to proceed - by still having the fixes in 19.09, if the LD_LIBRARY_PATH is not reintroduced in master and therefore is not present in the next release after 19.09, applications in user environments will not break after an upgrade doe to disappearance of LD_LIBRARY_PATH.

I'm still not sure we should do this by patching packages but let's try and see what problems arise. The package I was trying to fix now was tensorflow, also tensorflow-bin has invalid RUNPATH (nvidia-x11) and all other sorts of ML packages are broken now - we need to fix them.
I don't think we should merge this for 19.09, rather either merge to post-19.09 unstable or reject. For 19.09 we'd rather leave LD_LIBRARY_PATH always enabled for the time being, there is https://github.com/NixOS/nixpkgs/pull/67791 for that.

I don't think we should merge this for 19.09, rather either merge to post-19.09 unstable or reject. For 19.09 we'd rather leave LD_LIBRARY_PATH always enabled for the time being, there is #67791 for that.

Yeah that's better because it prevents breakage of packages from user environments after upgrade to 19.09 in cases of using open-source drivers.

I fixed this bug for tensorflow at least. Let's close this for now.


[resh] Add tab completion for shell users

Why
Simplify life of shell users and lower the barrier to use the CLI.
What
TBD.

Fixed via #811


Allow AES XTS decryption using duplicate keys.

Encryption is still disallowed and will generate an error.
Fixes #9105

Thanks @mspncp I'll wait to see if @slontis or @davidmakepeace can provide insight as to the FIPS status of this.

Hmm.. This looks good to me.
It seems to be a general pattern to have restrictions on protection, but then relax these restrictions during processing.
BUT..
If you look at FIPS 1402IG it specifically says this in the following section..
A.9 XTS-AES Key Generation Requirements
additional comments:
The check for Key_1 ≠ Key_2 shall be done at any place BEFORE using the keys in the XTS-AES algorithm to process data with them.
Maybe we should always do the check during generation/encryption.. but only do the decryption check in FIPS mode??

Either way we do need some. mechanism that allows them to decrypt using duplicate keys, otherwise they cant migrate them.. Could also make it configurable, and turn it on in fips and off in default by default (with the ability to change it).  Maybe ue a security flags setter/getter?

IF it all possible, don't make the FIPS and non-FIPS default behavior different.  This probably means requiring a flag for decrypt to override the "no duplicate key" behavior.

Unless @davidmakepeace has a definite opinion about this, I'll ask the experts....

I think we should disable both encryption and decryption using duplicate keys by default for both default and fips providers with a way to re-enable decryption for migration purposes.
Even if there is a popular Application out there in the wild that uses OpenSSL, uses AES XTS and has been deliberately generating duplicate keys I think it is reasonable to prevent all use of duplicate keys by default - such an Application could be updated to perform the migration using a new mechanism to allow decryption for that purpose.
The main use case for this algorithm is encryption of block-oriented storage for databases, filesystems, etc., especially when retrofitted to existing systems where there is no space for metadata such as per-block nonces and authentication tags. I expect that most such systems are read/write though some may be storage archives. In some cases the amount of data may be so large that re-keying/migrating would be onerous and it would be preferable to just keep using the duplicate keys assuming that the risks of not migrating are accepted and well understood. Maybe there should be a mechanism to explicitly allow both encryption and decryption.
It would nice to know if any such storage systems (that have been deliberately generating duplicate keys) exist.

I've updated this PR to disallow duplicate key XTS by default.
I've added a ctrl to allow decryption to be performed.
(documentation is lacking until the final solution is determined)

I don't see many alternatives to the way you have written this.

Ping?  A re-review is required after changes.

After hearing from the FIPS lab, decryption is not permitted at all in FIPS mode.

Unfortunately, as your pointed out the IG states before using keys in the XTS-AES Algorithm to process data with them. Our interpretation in the past has been that this means it applies to both encryption and decryption functions. Other areas in CMVP guidance they explicitly call out encryption vs. decryption, for example the AES GCM IV uniqueness requirements in IG A.5.

The choice is between having a behavioural difference between FIPS and not, or not allowing decryption at all.  I think the behavioural difference is the better path.  Once this decision is made, the requirement for a control to enable decryption doesn't seem so relevant.

I think a behavior change is very very wrong.  Portable applications will mis-behave depending on how the local site is configured.  Make it explicit to always decrypt with duplicate keys.

Make it explicit to always decrypt with duplicate keys.

Which would mean that we cannot include this in the FIPS provider.
The choice is between:

Have this behavourial difference and have XTS in the FIPS validation.
Always allow duplicated key decryption and not have XTS in the FIPS validation.
Ban duplicated key decryption and have XTS in the FIPS validation.

My vote is overwhelming for the first of these.
It can't be in FIPS but it is wanted for legacy reasons.

Technical enforcement is not required. We can add this into the security policy passing the responsibility to the user of the module.

I view technical enforcement as better than policy enforcement, especially when it's straightforward like here.

We can add this into the security policy passing the responsibility to the user of the module.
I disagree with this approach. It assumes that EVERY user will READ and actually UNDERSTAND what is in the security policy. I think it is much better for it to fall over and then at least the question gets asked as to why it doesnt work. If you really want to do something insecure it should be an option that you need to enable. The name of the option should make it clear that this is insecure - as well as listing the option in the security policy.

I was thinking of the openssl application having a flag.
I think adding a control that says "allow duplicate keys" that the FIPS XTS code could error-return would work.

That would constitute a FIPS behavioural difference, just a different one.
I don't see a need but I can add a derypt outside of FIPS mode control back in if it is desirable, I think it is more complex than required and requires code changes in applications to support legacy use.

Here is what I am suggesting, hopefully this is more clear.  Add a CTRL option that says "can decrypt with duplicate keys"  FIPS provider rejects it, default provider allows it.  Applications that want to do this will/can/should know that the default provider will decrypt. The decrypt applet must be also be changed: add a new flag "-dupkeys" or whatever, and if that is specified, it explicitly loads the default provider to do the decryption regardless of whatever providers are loaded by switches or config files.
Is that more helpful?

XTS mode isn't supported by enc, so no need to modify the applet.
By introducing a new ctl call, user applications will have to change to support it.  By doing the way it is done here, they don't.  BTW: the first commit in this branch does include a new ctl call to enable same key decryption.  I think it is close to what you're suggesting.  The flawed assumption being that this was allow under the FIPS legacy rules.

Have this behavourial difference and have XTS in the FIPS validation.

Seems like the right answer to me. Behavioural differences between the default and FIPS providers are inevitable so I have no problem with that at all.

Ping for review?

Travis failure isn't relevant.

Ping for review?

Thanks @t8m
Merged to master and 1.1.1.


Allow the webhook listener path to be configurable

Fixes #629

Defaults to what was hardcoded previously /

Thanks!

@ryandens I released 2.6.0 which includes your 2 contributions.

Amazing, thank you @gsmet! We were already using aspects of this extension to build [pixeebot](https://github.com/marketplace/pixeebot-automated-code-fixes (like the GitHubClientProvider and the PayloadSignatureChecker but now we'll be able to use more aspects of it 😄 Looking forward to making more contributions along the way


GetGamepadName() not working after update to current commit, first since platform split.

Issue description
After updating to latest commit for the first time since the platform split, GetGamepadName() returns an uninitialized value if the gamepad was connected before InitWindow() was called.  Calling the function on a reconnected gamepad works properly, returning the expected const char**
Environment
Windows 10, VS 2022, OpenGL 3.3, Radeon 6500XT.
Code Example
After testing, it seems that replacing rcore_dexktop.c Line 1123:
if (glfwJoystickPresent(i)) CORE.Input.Gamepad.ready[i] = true;

with
if (glfwJoystickPresent(i)) {
    CORE.Input.Gamepad.ready[i] = true;
    strcpy(CORE.Input.Gamepad.name[i], glfwGetJoystickName(i));
}

solves the issue.

@TongueSurfer I think that calling strcpy(CORE.Input.Gamepad.name[i], glfwGetJoystickName(i)); inside PollInputEvents() (L1123) would be a bad idea as PollInputEvents() gets executed every frame, so it would be needlessly copying the names every frame.
I believe a better solution would be moving GetGamepadName() back to the rcore_[platform].c since the different platforms apparently have different methods to retrieve that data, e.g.:

GLFW: glfwGetJoystickName();
SDL: SDL_GameControllerName();
DRM: ioctl().

I agree; if it can be avoided, then assigning the names every frame is just wrong.  I didn't realize I was looking at something that happens every frame.  If moving the functions into the split platforms is an option, it's the way to go.

Ouch! I merged the fix too fast!
@ubkp is right, it could be too costly to retrieve it per-frame basis... still, I'm wondering if GLFW or SDL poll that data per frame, considering that any controller can be plugged/unplugged anytime...
But I also like the idea of keeping inputs as much platform-independant as possible... maybe that additional performance cost (one strcpy() call) worths it...
I'll think about it before applying any solution.

Those two cases work for PLATFORM_DESKTOP and PLATFORM_WEB, on PLATFORM_DESKTOP_SDL it can be processed through a SDL_Event on event polling and PLATFORM_DRM processes gamepads in a separate thread, so they can just be updated there.

@raysan5 I was looking into that. And, as far as I could tell, the gamepad detection filling the gamepad name should already be working as is right now:

On rcore_desktop.c (GLFW) we already setup a callback for it glfwSetJoystickCallback(JoystickCallback); (L1536);
And that callback JoystickCallback already handles copying the name to CORE.Input.Gamepad.name[*] (L1783-L1794).
It should be working, as it is exactly like the documentation mentions it, but I don't know why it's not working.

@ubkp As per mi understanding, it does not work if the gamepad is already connected when the application starts, so the connect/disconnect event is not processed. It should be checked at InitPlatform().

@raysan5 Thanks for the answer! So I guess that if we call glfwSetJoystickCallback(NULL); on InitPlatform() here: L1354, perhaps the fix would be calling glfwSetJoystickCallback(JoystickCallback); in the end of InitPlatform() too?
Note: Unfortunately I don't have a joystick here, so I can't test it.

@raysan5 As @ubkp suggested, after testing (I have a joystick and 2 controllers connected), inserting
for (int i = 0; i < MAX_GAMEPADS; i++) {
    if (glfwJoystickPresent(i)) strcpy(CORE.Input.Gamepad.name[i], glfwGetJoystickName(i));
}

at line 1550 right before InitPlatform()'s end and its "Success" TRACELOG solves the problem; all controllers connected before initialization now report their name.  I think it's cleaner to have it there than behind an if() in PollInputEvents().

@TongueSurfer @ubkp thanks for the review and sending the review! Merged!


Fails to get credentials when called through a composite action multiple times

TL;DR
Getting consistent errors when I am calling auth and get-gke-credentials actions through a composite action twice within a same job in a workflow.
Expected behavior
No errors. Getting credentials should work no matter how or how many times I call it. This limits how these composite actions can be used.
Observed behavior
Looks to me that, when I call the composite action a second time it somehow uses the environment variables from the first pass eventhough the logs are clearly telling me that it will overwrite those environment variables.
Action YAML
# Composite action
name: "auth"
description: "calling this many times fails"
runs:
  using: "composite"
  steps:
    - name: Checkout
      uses: actions/checkout@v3
    - id: Auth
      name: gcloud auth
      uses: 'google-github-actions/auth@v0'
      with:
        workload_identity_provider: projects/<numbers>/locations/global/workloadIdentityPools/github-actions/providers/github
        service_account<EMAIL_ADDRESS>        token_format: 'access_token'
        access_token_scopes: https://www.googleapis.com/auth/cloud-platform
        access_token_subject<EMAIL_ADDRESS>    - name: Get gke credentials
      uses: google-github-actions/get-gke-credentials@v0
      with:
        cluster_name: cluster
        location: us-central1
        project_id: project
# Workflow that always fails
name: gcloud auth errors

on: [push, workflow_dispatch]

jobs:
  foo:
    name: foo
    runs-on: [ self-hosted, linux ]
    permissions: write-all
    steps:
      - name: Checkout
        uses: actions/checkout@v3
      - name: auth
        uses: ./.github/actions/auth
      - name: auth
        uses: ./.github/actions/auth
# Works well without using composite action
name: gcloud auth

on: [push, workflow_dispatch]

jobs:
  foo:
    name: foo
    runs-on: [ self-hosted, linux ]
    permissions: write-all
    steps:
      - name: Checkout
        uses: actions/checkout@v3
      - name: gcloud auth
        uses: 'google-github-actions/auth@v0'
        with:
          workload_identity_provider: projects/<numbers>/locations/global/workloadIdentityPools/github-actions/providers/github
          service_account<EMAIL_ADDRESS>          export_environment_variables: true
          cleanup_credentials: true
      - name: Get gke credentials
        uses: google-github-actions/get-gke-credentials@v0
        with:
          cluster_name: gke-test-usc1
          location: us-central1
          project_id: gke-test
      - name: gcloud auth
        uses: 'google-github-actions/auth@v0'
        with:
          workload_identity_provider: projects/<numbers>/locations/global/workloadIdentityPools/github-actions/providers/github
          service_account<EMAIL_ADDRESS>          export_environment_variables: true
          cleanup_credentials: true
      - name: Get gke credentials
        uses: google-github-actions/get-gke-credentials@v0
        with:
          cluster_name: gke-test-usc1
          location: us-central1
          project_id: gke-test

Log output
2022-06-07T12:00:39.3650503Z Requested labels: self-hosted, linux
2022-06-07T12:00:39.3650609Z Job defined at: Corporation/github-actions-workflows/.github/workflows/wth_gcloud_authv3.yml@refs/heads/wth-gcloud-auth
2022-06-07T12:00:39.3650632Z Waiting for a runner to pick up this job...
2022-06-07T12:00:41.9093137Z Job is about to start running on the runner: corporation-linux-runner-qm279-nlpkw (organization)
2022-06-07T12:00:50.8545116Z Current runner version: '2.292.0'
2022-06-07T12:00:50.8553616Z Runner name: 'corporation-linux-runner-qm279-nlpkw'
2022-06-07T12:00:50.8554321Z Runner group name: 'corporation-runners'
2022-06-07T12:00:50.8555157Z Machine name: 'corporation-linux-runner-qm279-nlpkw'
2022-06-07T12:00:50.8558099Z ##[group]GITHUB_TOKEN Permissions
2022-06-07T12:00:50.8558928Z Actions: write
2022-06-07T12:00:50.8559199Z Checks: write
2022-06-07T12:00:50.8559612Z Contents: write
2022-06-07T12:00:50.8559977Z Deployments: write
2022-06-07T12:00:50.8560367Z Discussions: write
2022-06-07T12:00:50.8560756Z Issues: write
2022-06-07T12:00:50.8561102Z Metadata: read
2022-06-07T12:00:50.8561461Z Packages: write
2022-06-07T12:00:50.8561796Z Pages: write
2022-06-07T12:00:50.8562173Z PullRequests: write
2022-06-07T12:00:50.8562539Z RepositoryProjects: write
2022-06-07T12:00:50.8563004Z SecurityEvents: write
2022-06-07T12:00:50.8563609Z Statuses: write
2022-06-07T12:00:50.8563923Z ##[endgroup]
2022-06-07T12:00:50.8568692Z Secret source: Actions
2022-06-07T12:00:50.8569494Z Prepare workflow directory
2022-06-07T12:00:50.9644182Z Prepare all required actions
2022-06-07T12:00:50.9889171Z Getting action download info
2022-06-07T12:00:51.4217824Z Download action repository 'actions/checkout@v3' (SHA:2541b1294d2704b0964813337f33b291d3f8596b)
2022-06-07T12:00:52.2227395Z ##[group]Run actions/checkout@v3
2022-06-07T12:00:52.2227778Z with:
2022-06-07T12:00:52.2228133Z   repository: Corporation/github-actions-workflows
2022-06-07T12:00:52.2228835Z   token: ***
2022-06-07T12:00:52.2229089Z   ssh-strict: true
2022-06-07T12:00:52.2229384Z   persist-credentials: true
2022-06-07T12:00:52.2229748Z   clean: true
2022-06-07T12:00:52.2230006Z   fetch-depth: 1
2022-06-07T12:00:52.2230245Z   lfs: false
2022-06-07T12:00:52.2230507Z   submodules: false
2022-06-07T12:00:52.2230809Z   set-safe-directory: true
2022-06-07T12:00:52.2231082Z ##[endgroup]
2022-06-07T12:00:52.4484220Z Syncing repository: Corporation/github-actions-workflows
2022-06-07T12:00:52.4486543Z ##[group]Getting Git version info
2022-06-07T12:00:52.4487467Z Working directory is '/runner/_work/github-actions-workflows/github-actions-workflows'
2022-06-07T12:00:52.4588436Z [command]/usr/bin/git version
2022-06-07T12:00:52.4674009Z git version 2.36.0
2022-06-07T12:00:52.4727250Z ##[endgroup]
2022-06-07T12:00:52.4754742Z Temporarily overriding HOME='/runner/_work/_temp/7f7eca38-6665-4c28-b693-07c1936b7c31' before making global git config changes
2022-06-07T12:00:52.4756287Z Adding repository directory to the temporary git global config as a safe directory
2022-06-07T12:00:52.4762797Z [command]/usr/bin/git config --global --add safe.directory /runner/_work/github-actions-workflows/github-actions-workflows
2022-06-07T12:00:52.4818731Z Deleting the contents of '/runner/_work/github-actions-workflows/github-actions-workflows'
2022-06-07T12:00:52.4823309Z ##[group]Initializing the repository
2022-06-07T12:00:52.4828296Z [command]/usr/bin/git init /runner/_work/github-actions-workflows/github-actions-workflows
2022-06-07T12:00:52.4875717Z hint: Using 'master' as the name for the initial branch. This default branch name
2022-06-07T12:00:52.4876271Z hint: is subject to change. To configure the initial branch name to use in all
2022-06-07T12:00:52.4876763Z hint: of your new repositories, which will suppress this warning, call:
2022-06-07T12:00:52.4877140Z hint:
2022-06-07T12:00:52.4877652Z hint: 	git config --global init.defaultBranch <name>
2022-06-07T12:00:52.4878025Z hint:
2022-06-07T12:00:52.4878508Z hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
2022-06-07T12:00:52.4879048Z hint: 'development'.   Not sure, if composite actions have some limitations that could cause this. Not sure, if this is a problem with this action or perhaps the "auth" action or perhaps an issue with github actions itself or an user error.

Thanks for the report @rellu. I believe your observations are correct and the Overwriting existing environment variable GOOGLE_GHA_CREDS_PATH is not actually overwriting. This does looks like an upstream issue https://github.com/actions/runner/issues/1899

Thanks for the report @rellu. I believe your observations are correct and the Overwriting existing environment variable GOOGLE_GHA_CREDS_PATH is not actually overwriting. This does looks like an upstream issue actions/runner#1899

thanks for the link! It clearly looks like an upstream issue. Should we close this then?

Closing as the upstream issue has been fixed: https://github.com/actions/runner/pull/1794


Windows 10 compatibility

I didn't have the time to thoroughly test this, but our WPF app doesn't work in Windows 10 Preview. The last version before we employ Akavache, works just fine.
I initialize Akavache on the application startup, but the caches' files never get created and I see my app changing its status to Suspended in task manager, before completely ending after a couple of seconds.
Unfortunately the app logs don't contain any error information and there isn't any unhandled exception AFAIK.
I'm building a temporary dev setup on Windows 10 Preview to try and test this more, but if you have any info on this, please share.
/cc @paulcbetts
Edit: Just saw https://github.com/ericsink/SQLitePCL.raw/issues/44 so I guess there's no solution for this yet.
Edit 2: Replacing the sqlite3.dll with the one from http://www.sqlite.org/2015/sqlite-dll-win32-x86-3081002.zip everything works as expected. I replaced both dlls in x86 and x64 folders and tested on Windows 10 build 10122 64-bit.

Having this problem but in Windows 7 for a WPF app.

UWP + Akavache works, make sure you upgrade to latest SQLite and read this https://github.com/ghuntley/repros/tree/master/nuget/TransitiveRefs to work around a nuget resolution issue.

"suppressParent": "none" is help, Thank you @ghuntley


question: is there any method to avoid mapping same page?

hi, there
i saw there's test case named "basic_small_buffers_mapping". If cudamalloc many times(far more than twice), is there any method to check if this memory's page has been already mapped? if it has been mapped by others, maybe we should use va from matched handle, the map API should not return failure?

Hi @hongbilu,
We don't provide such API. And the agreement of the pin and map API is within the buffer you pin and map. It is unsafe to assume that you can use the same CPU VA range from mapping CUDA buffer A to access CUDA buffer B.

Hi @hongbilu,
We don't provide such API. And the agreement of the pin and map API is within the buffer you pin and map. It is unsafe to assume that you can use the same CPU VA range from mapping CUDA buffer A to access CUDA buffer B.

yes, but cudaMalloc cannot guarantee that memory address must be different page. In fact they might be same pretty much when allocating small data size which is a very common usage. The problem is that applications will take the management  of all the cuda memory and check if cpu va is at same range with others, that is an additional work, too dirty and specific solution. what do you think?

Let's say that you have two CUDA buffers A and B from cudaMalloc. You will be able to pin both A and B, but you may not be able to map them. gdr_map requires the start address (does not have to be at the beginning of the buffer) to be GPU BAR1 page aligned. cudaMalloc does not guarantee the alignment. If you want to use GDRCopy to create CPU VA of your buffers, you must manually adjust the alignment (see https://github.com/NVIDIA/gdrcopy/blob/master/tests/common.cpp#L46). Generally, this results in you allocating each buffer with size larger than GPU BAR1 page. Thus, the buffers should not be that small anyway.
basic_small_buffers_mapping is a unit test to ensure that we can do gdr_pin of two small contiguous buffers. But even if you can pin, you cannot map as the second buffer is not GPU BAR1 page aligned. It is probably not what you are looking for.

Thanks! But the key point is that CUDA buffer number may be far more than 2, you need to manage these VA ranges with probably different page size which makes GDRCopy not easily to be used by clients and these management should be put into GDRCopy I think, what you mentioned above  can avoid mapping failure but will cost more cuda memory and do not reduce management work.

thanks! so it need to allocate more buffers manually which means a not easily to use for clients

You may use CUDA VMM instead of cudaMalloc. VMM always guarantees that CUDA VA is page aligned.

very appreciate for remind! thanks


Hover on bokeh plots sometimes does not work

It seems that sometimes the hovering on data points does not work.
Then the hover does not appear on the right side of the plot.

No, seems to be okay now. It seems that sometimes for steep curves it's difficult to touch "the right point", but if you zoom in, it works. Closing.


Call AddOwner on Slider.Orientation instead of declaring a new property

What does the pull request do?
Change the registration of the Slider.OrientationProperty.
What is the current behavior?
The Slider class registers the Orientation as a new property.
What is the updated/expected behavior with this PR?
Slider calls AddOwner on the ScrollBar.OrientationProperty.

Checklist:

[x] Added unit tests (if possible)?

Fixes #1696

@grokys This seems to be a problem with the latest changes in the master branch... I can reproduce your problem on master, without the changes in this PR.
Dragging the slider-circle does not work anymore, but clicking elsewhere on the slider still works.


NPT-12189: Docstrings and messages

Adjustments to documentation content:

README
Docstrings
Error messages

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

I'll need more context and guidance from stakeholders before I know what to do with the README :smile:


Electron 12.0.2 + sharp 0.28.1 fails to build (without running npm i -g prebuild-install)

I created an empty project with just electron and sharp. Here's the package.json:
{
  "name": "sharp-electron-test",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "scripts": {
    "postinstall": "rm -rf node_modules/prebuild-install && yarn electron-builder install-app-deps"
  },
  "devDependencies": {
    "electron": "^12.0.2",
    "electron-builder": "^22.10.5"
  },
  "dependencies": {
    "sharp": "0.28.0"
  }
}

This project builds fine:
$ yarn install --force  --no-default-rc
yarn install v1.22.10
[1/4] Resolving packages...
[2/4] Fetching packages...
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Rebuilding all packages...
success Saved lockfile.
$ rm -rf node_modules/prebuild-install && yarn electron-builder install-app-deps
yarn run v1.22.10
$ /home/mrm/src/sharp-electron-test/node_modules/.bin/electron-builder install-app-deps
  • electron-builder  version=22.10.5
  • rebuilding native dependencies<EMAIL_ADDRESS>platform=linux arch=x64
  • install prebuilt binary  name=sharp version=0.28.0 platform=linux arch=x64
  ⨯ cannot find prebuild-install
  • rebuilding native dependency  name=sharp version=0.28.0
Done in 11.28s.
Done in 16.16s.

If I change sharp to 0.28.1, yarn install fails:
mrm@speedy:~/src/sharp-electron-test$ rm -rf ~/.electron ~/.cache/electron* ~/.electron-gyp ~/.npm/_libvips ~/AppData/Roaming/npm-cache/_libvips ~/.node-gyp ~/.cache/yarn/*/*sharp* node_modules
mrm@speedy:~/src/sharp-electron-test$ yarn install --force  --no-default-rc
yarn install v1.22.10
[1/4] Resolving packages...
[2/4] Fetching packages...
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Rebuilding all packages...
success Saved lockfile.
$ rm -rf node_modules/prebuild-install && yarn electron-builder install-app-deps
yarn run v1.22.10
$ /home/mrm/src/sharp-electron-test/node_modules/.bin/electron-builder install-app-deps
  • electron-builder  version=22.10.5
  • rebuilding native dependencies<EMAIL_ADDRESS>platform=linux arch=x64
  • install prebuilt binary  name=sharp version=0.28.1 platform=linux arch=x64
  ⨯ cannot find prebuild-install
  • rebuilding native dependency  name=sharp version=0.28.1
  ⨯ cannot execute  cause=exit status 1
                    out=$ (node install/libvips && node install/dll-copy && prebuild-install) || (node-gyp rebuild && node install/dll-copy)
    sharp: Using existing vendored libvips v8.10.6
    make: Entering directory '/home/mrm/src/sharp-electron-test/node_modules/sharp/build'
      CC(target) Release/obj.target/nothing/../node-addon-api/nothing.o
      AR(target) Release/obj.target/../node-addon-api/nothing.a
      COPY Release/nothing.a
      TOUCH Release/obj.target/libvips-cpp.stamp
      CXX(target) Release/obj.target/sharp/src/common.o
    make: Leaving directory '/home/mrm/src/sharp-electron-test/node_modules/sharp/build'
    info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

                    errorOut=/bin/sh: 1: prebuild-install: not found
    gyp info it worked if it ends with ok
    gyp info using<EMAIL_ADDRESS>    gyp info using<EMAIL_ADDRESS>| linux | x64
    gyp info find Python using Python version 3.8.5 found at "/usr/bin/python3"
    gyp http GET https://electronjs.org/headers/v12.0.2/node-v12.0.2-headers.tar.gz
    gyp http 200 https://electronjs.org/headers/v12.0.2/node-v12.0.2-headers.tar.gz
    gyp http GET https://electronjs.org/headers/v12.0.2/SHASUMS256.txt
    gyp http 200 https://electronjs.org/headers/v12.0.2/SHASUMS256.txt
    gyp info spawn /usr/bin/python3
    gyp info spawn args [
    gyp info spawn args   '/home/mrm/.nvm/versions/node/v14.16.0/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
    gyp info spawn args   'binding.gyp',
    gyp info spawn args   '-f',
    gyp info spawn args   'make',
    gyp info spawn args   '-I',
    gyp info spawn args   '/home/mrm/src/sharp-electron-test/node_modules/sharp/build/config.gypi',
    gyp info spawn args   '-I',
    gyp info spawn args   '/home/mrm/.nvm/versions/node/v14.16.0/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
    gyp info spawn args   '-I',
    gyp info spawn args   '/home/mrm/.electron-gyp/12.0.2/include/node/common.gypi',
    gyp info spawn args   '-Dlibrary=shared_library',
    gyp info spawn args   '-Dvisibility=default',
    gyp info spawn args   '-Dnode_root_dir=/home/mrm/.electron-gyp/12.0.2',
    gyp info spawn args   '-Dnode_gyp_dir=/home/mrm/.nvm/versions/node/v14.16.0/lib/node_modules/npm/node_modules/node-gyp',
    gyp info spawn args   '-Dnode_lib_file=/home/mrm/.electron-gyp/12.0.2/<(target_arch)/node.lib',
    gyp info spawn args   '-Dmodule_root_dir=/home/mrm/src/sharp-electron-test/node_modules/sharp',
    gyp info spawn args   '-Dnode_engine=v8',
    gyp info spawn args   '--depth=.',
    gyp info spawn args   '--no-parallel',
    gyp info spawn args   '--generator-output',
    gyp info spawn args   'build',
    gyp info spawn args   '-Goutput_dir=.'
    gyp info spawn args ]
    gyp info spawn make
    gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
    ../src/common.cc:24:10: fatal error: vips/vips8: No such file or directory
       24 | #include <vips/vips8>
          |          ^~~~~~~~~~~~
    compilation terminated.
    make: *** [sharp.target.mk:145: Release/obj.target/sharp/src/common.o] Error 1
    gyp ERR! build error
    gyp ERR! stack Error: `make` failed with exit code: 2
    gyp ERR! stack     at ChildProcess.onExit (/home/mrm/.nvm/versions/node/v14.16.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
    gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
    gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)
    gyp ERR! System Linux 5.8.0-48-generic
    gyp ERR! command "/home/mrm/.nvm/versions/node/v14.16.0/bin/node" "/home/mrm/.nvm/versions/node/v14.16.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
    gyp ERR! cwd /home/mrm/src/sharp-electron-test/node_modules/sharp
    gyp ERR! node -v v14.16.0
    gyp ERR! node-gyp -v v7.1.2
    gyp ERR! not ok
    error Command failed with exit code 1.

                    command=/home/mrm/.nvm/versions/node/v14.16.0/bin/node /home/mrm/.nvm/versions/node/v14.16.0/lib/node_modules/yarn/bin/yarn.js run install
                    workingDir=/home/mrm/src/sharp-electron-test/node_modules/sharp
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

What is the output of running npx envinfo --binaries --system?
$ npx envinfo --binaries --system

  System:
    OS: Linux 5.8 Ubuntu 20.04.2 LTS (Focal Fossa)
    CPU: (24) x64 AMD Ryzen 9 3900X 12-Core Processor
    Memory: 6.25 GB / 62.79 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 14.16.0 - ~/.nvm/versions/node/v14.16.0/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.16.0/bin/yarn
    npm: 7.7.0 - ~/.nvm/versions/node/v14.16.0/bin/npm

If I npm i -g prebuild-install, the build passes.
If I add prebuild-install as a devDependency, it's ignored.

sharp v0.28.1 depends on prebuild-install v6.1.1, which is the latest version published to npm.
I notice you've used the --force flag so perhaps there's a conflict with the change in https://github.com/prebuild/prebuild-install/pull/140

I notice you've used the --force flag so perhaps there's a conflict with the change in prebuild/prebuild-install#140

I just uninstalled the globally-installed prebuild-install, cleaned out node_modules, and just ran yarn install, and got the same error. :cry:
$ npm uninstall -g prebuild-install

removed 58 packages, and audited 1 package in 197ms

found 0 vulnerabilities

$ rm -rf ~/.electron ~/.cache/electron* ~/.electron-gyp ~/.npm/_libvips ~/AppData/Roaming/npm-cache/_libvips ~/.node-gyp ~/.cache/yarn/*/*sharp* node_modules

$ yarn install
yarn install v1.22.10
[1/4] Resolving packages...
[2/4] Fetching packages...
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
$ rm -rf node_modules/prebuild-install && yarn electron-builder install-app-deps
yarn run v1.22.10
$ /home/mrm/src/sharp-electron-test/node_modules/.bin/electron-builder install-app-deps
  • electron-builder  version=22.10.5
  • rebuilding native dependencies<EMAIL_ADDRESS>platform=linux arch=x64
  • install prebuilt binary  name=sharp version=0.28.1 platform=linux arch=x64
  ⨯ cannot find prebuild-install
  • rebuilding native dependency  name=sharp version=0.28.1
  ⨯ cannot execute  cause=exit status 1
                    out=$ (node install/libvips && node install/dll-copy && prebuild-install) || (node-gyp rebuild && node install/dll-copy)
    sharp: Using existing vendored libvips v8.10.6
    make: Entering directory '/home/mrm/src/sharp-electron-test/node_modules/sharp/build'
      CC(target) Release/obj.target/nothing/../node-addon-api/nothing.o
      AR(target) Release/obj.target/../node-addon-api/nothing.a
      COPY Release/nothing.a
      TOUCH Release/obj.target/libvips-cpp.stamp
      CXX(target) Release/obj.target/sharp/src/common.o
    make: Leaving directory '/home/mrm/src/sharp-electron-test/node_modules/sharp/build'
    info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

                    errorOut=/bin/sh: 1: prebuild-install: not found
    gyp info it worked if it ends with ok
    gyp info using<EMAIL_ADDRESS>    gyp info using<EMAIL_ADDRESS>| linux | x64
    gyp info find Python using Python version 3.8.5 found at "/usr/bin/python3"
    gyp http GET https://electronjs.org/headers/v12.0.2/node-v12.0.2-headers.tar.gz
    gyp http 200 https://electronjs.org/headers/v12.0.2/node-v12.0.2-headers.tar.gz
    gyp http GET https://electronjs.org/headers/v12.0.2/SHASUMS256.txt
    gyp http 200 https://electronjs.org/headers/v12.0.2/SHASUMS256.txt
    gyp info spawn /usr/bin/python3
    gyp info spawn args [
    gyp info spawn args   '/home/mrm/.nvm/versions/node/v14.16.0/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
    gyp info spawn args   'binding.gyp',
    gyp info spawn args   '-f',
    gyp info spawn args   'make',
    gyp info spawn args   '-I',
    gyp info spawn args   '/home/mrm/src/sharp-electron-test/node_modules/sharp/build/config.gypi',
    gyp info spawn args   '-I',
    gyp info spawn args   '/home/mrm/.nvm/versions/node/v14.16.0/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
    gyp info spawn args   '-I',
    gyp info spawn args   '/home/mrm/.electron-gyp/12.0.2/include/node/common.gypi',
    gyp info spawn args   '-Dlibrary=shared_library',
    gyp info spawn args   '-Dvisibility=default',
    gyp info spawn args   '-Dnode_root_dir=/home/mrm/.electron-gyp/12.0.2',
    gyp info spawn args   '-Dnode_gyp_dir=/home/mrm/.nvm/versions/node/v14.16.0/lib/node_modules/npm/node_modules/node-gyp',
    gyp info spawn args   '-Dnode_lib_file=/home/mrm/.electron-gyp/12.0.2/<(target_arch)/node.lib',
    gyp info spawn args   '-Dmodule_root_dir=/home/mrm/src/sharp-electron-test/node_modules/sharp',
    gyp info spawn args   '-Dnode_engine=v8',
    gyp info spawn args   '--depth=.',
    gyp info spawn args   '--no-parallel',
    gyp info spawn args   '--generator-output',
    gyp info spawn args   'build',
    gyp info spawn args   '-Goutput_dir=.'
    gyp info spawn args ]
    gyp info spawn make
    gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
    ../src/common.cc:24:10: fatal error: vips/vips8: No such file or directory
       24 | #include <vips/vips8>
          |          ^~~~~~~~~~~~
    compilation terminated.
    make: *** [sharp.target.mk:145: Release/obj.target/sharp/src/common.o] Error 1
    gyp ERR! build error
    gyp ERR! stack Error: `make` failed with exit code: 2
    gyp ERR! stack     at ChildProcess.onExit (/home/mrm/.nvm/versions/node/v14.16.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
    gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
    gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)
    gyp ERR! System Linux 5.8.0-48-generic
    gyp ERR! command "/home/mrm/.nvm/versions/node/v14.16.0/bin/node" "/home/mrm/.nvm/versions/node/v14.16.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
    gyp ERR! cwd /home/mrm/src/sharp-electron-test/node_modules/sharp
    gyp ERR! node -v v14.16.0
    gyp ERR! node-gyp -v v7.1.2
    gyp ERR! not ok
    error Command failed with exit code 1.

                    command=/home/mrm/.nvm/versions/node/v14.16.0/bin/node /home/mrm/.nvm/versions/node/v14.16.0/lib/node_modules/yarn/bin/yarn.js run install
                    workingDir=/home/mrm/src/sharp-electron-test/node_modules/sharp
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

OH DEAR :facepalm:
My postinstall script was deleting the prebuild-install module out of node_modules: this led to prebuild-install: not found error. I don't remember why that was there, but it's clearly wrong.
I changed the postinstall to just
    "postinstall": "yarn electron-builder install-app-deps"

and everything works properly (at least on Ubuntu)
Thanks for humoring me!


Warning when building AGE on MacOS

Describe the bug
Warning when building AGE on MacOS
How are you accessing AGE (Command line, driver, etc.)?
Accessing AGE through command line.
What data setup do we need to do?
Apache AGE (PG15 branch) with PostgreSQL (REL_15_STABLE).
What is the necessary configuration info needed?
MacOS Sonoma 14.4
egor@MacBook-Air-Egor ~/Work/age (PG15) $ clang --version
Apple clang version 15.0.0 (clang-15<IP_ADDRESS>)
Target: arm64-apple-darwin23.4.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

./configure CFLAGS=" -Og" --enable-tap-tests --enable-debug --enable-cassert --prefix=/tmp/pgsql

What is the command that caused the error?
egor@MacBook-Air-Egor ~/Work/age (PG15) $ make

src/backend/parser/cypher_gram.c:2198:5: warning: variable 'cypher_yynerrs' set but not used [-Wunused-but-set-variable]
int yynerrs;
    ^
src/backend/parser/cypher_gram.c:68:17: note: expanded from macro 'yynerrs'
#define yynerrs cypher_yynerrs
                ^
1 warning generated.

Expected behavior
Build without warnings
Best regards,
Egor Chindyaskin
Postgres Professional: https://postgrespro.com/

To resolve this warning, you could consider removing or modifying the declaration of cypher_yynerrs in the cypher_gram.c file. Since it's not being used, removing it entirely should resolve the warning.


#928 issue number. Linked the login page to the index.html file

#928 issue number. The login button when clicked upon opens up to the login page.
Added   (anchor tag) and linked the login.html file inside anchor tag using href.
Please consider my pull request and merge @anuragverma108
Thank You.

@prakruthiprasad20 Please see the conflicts . Resolve the conflicts . Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


versioning

fix the versioning in the documentation

now in the documentation works, but issues with the xx.xx.xx versioning format on pypi, it is displayed as xx.xx

now in the documentation works, but issues with the xx.xx.xx versioning format on pypi, it is displayed as xx.xx

Apart from this, versioning should be displayed also in the documentation as link to previews releases


Getting "Failed error" alert and redirect from github to http instead of https domain.

After successfully authenticated against Salesforce and Github, I am redirected to my app "https://clickdeploy-fluent.herokuapp.com/" but with http instead of https url. All the configs contain https urls.
If I click on "Deploy" button, I get an alert with "Failed error". If I start the full process again, it works because I am redirected to the https url.

@SPaulusOfficial its probably your Connected App Callback URL I am guessing.
btw,you know that this tool is deployed for general use here https://githubsfdeploy.herokuapp.com/ right?


Component CRD: Include Gen 5 APIs in YAML specification

Description
We need to include Gen5 APIs as an alternative in our YAML file specifications.
We see this as changing the API reference in the YAML file to an Array, allowing us to specify as many variants of an API as we need.  We will have to retain Gen4 APIs, as these are still a formally supported TM Forum product.

We will create a v1beta3 version of the Component resource and update the specification to allow a list/array or specifications to allow a Golden Component to specify "one of" a list of Open APIs generations.
Do we also want to enable an implemented component to specify multiple versions of a single API (so that a component could offer a Gen5 and Gen4 version of a given API? (any views @sharrop ?)

Hi
Yes, we need it both ways.
The Component can pass conformance if it correctly implements one or more of the listed APIs, gen 4 APIs or Gen 5.
So the conformance needs at least one of the APIs in the list, but if there are several alternative APIs listed, each should pass.
From: Lester @.>
Sent: Tuesday, December 5, 2023 10:14 PM
To: tmforum-oda/oda-canvas @.>
Cc: Hugo Vaughan @.>; Author @.>
Subject: Re: [tmforum-oda/oda-canvas] <component/operator/ctk>: Include Gen 5 APIs in YAML specification (Issue #128)
We will create a v1beta3 version of the Component resource and update the specification to allow a list/array or specifications to allow a Golden Component to specify "one of" a list of Open APIs generations.
Do we also want to enable an implemented component to specify multiple versions of a single API (so that a component could offer a Gen5 and Gen4 version of a given API? (any views @sharrophttps://github.com/sharrop ?)

Reply to this email directly, view it on GitHubhttps://github.com/tmforum-oda/oda-canvas/issues/128#issuecomment-1841705910, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A36BEBJD7KMGRZHDSMXGQFDYH6MBDAVCNFSM6AAAAAA7XVJ2BGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBRG4YDKOJRGA.
You are receiving this because you authored the thread.Message ID: @.***>


propose intelligent deletion management approach

Currently, deletes of content in the registry are allowed with administration privileges. This means layers and manifests can be deleted, with extreme prejudice. This meets most use cases where the goal is to remove old or unused layers. Unfortunately, this allows for one to corrupt a manifests by deleting dependent data. This is insufficient for integration into the docker client.
The registry API allows deletion of registry objects under various scenarios. The initial intent of the new registry implementation was to have deletes be integrated from the start. With the current state of the manifest specification, deletes were challenging to implement or impossible to implement reliably. Changes are occurring to address this in #62.
There are several aspects to this problem:

Most registry data has interdependencies that are expressed internally but they are expensive to resolve while underlying data is changing.
Deletes under eventual consistency results in odd scenarios that wouldn't be present in a transactional system. This fact needs to be considered.

We need to propose a solution that can allow for all proposed deletes in a reliable and safe manner.

Why is this closed?

Soft delete have been implemented as part of the API, and more specialized issues have been opened for garbage collection.

@dmp42 does soft delete, delete only the repository records/data and not the actual files & folders on the disk? can we use soft delete atm?

@tunix you should find info about it here: https://github.com/docker/distribution/blob/master/docs/spec/api.md#deleting-a-layer
Soft delete only delete references, and not the actual files.


YARN-11495. Fix typos in hadoop-yarn-server-web-proxy.

Description of PR
JIRA: YARN-11495. Fix typos in hadoop-yarn-server-web-proxy.
While reading the code, I found some typo issues. This JIRA will fix these issues in hadoop-yarn-server-web-proxy.
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 34s

trunk passed

+1 :green_heart:
compile
0m 28s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 26s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 31s

trunk passed

+1 :green_heart:
mvnsite
0m 30s

trunk passed

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 25s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
0m 56s

trunk passed

+1 :green_heart:
shadedclient
20m  2s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 19s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
compile
0m 17s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 15s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy: The patch generated 1 new + 35 unchanged - 1 fixed = 36 total (was 36)

+1 :green_heart:
mvnsite
0m 20s

the patch passed

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
0m 44s

the patch passed

+1 :green_heart:
shadedclient
20m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 11s

hadoop-yarn-server-web-proxy in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

87m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5652/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5652

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux e0ea52985704 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 23d2b2f2b6fce2da11a86a71b5086a554f720281

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5652/1/testReport/

Max. process+thread count
639 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5652/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

can you fix the checkstyle warning: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5652/1/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt
It was already there, but would be good if we can fix it

Thank you very much for your help to review the code! I will modify the code.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 47s

trunk passed

+1 :green_heart:
compile
0m 28s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 27s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 32s

trunk passed

+1 :green_heart:
mvnsite
0m 32s

trunk passed

+1 :green_heart:
javadoc
0m 38s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
0m 57s

trunk passed

+1 :green_heart:
shadedclient
20m 25s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 19s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 15s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy: The patch generated 0 new + 35 unchanged - 1 fixed = 35 total (was 36)

+1 :green_heart:
mvnsite
0m 19s

the patch passed

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
0m 45s

the patch passed

+1 :green_heart:
shadedclient
20m 21s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 11s

hadoop-yarn-server-web-proxy in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

85m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5652/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5652

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a6bdbb181307 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / bab1e38cc6154fa9f13aec31c6528f3276a61808

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5652/2/testReport/

Max. process+thread count
733 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5652/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ayushtkn Thank you very much for helping to review the code!


feat(multi_object_tracker): add velocity observation

Description
Currently, Kalman filter in the multi-object tracker cannot update its velocity with the observed velocity value when the measurement object has valid velocity value. In this PR, I change the tracker that can accept the velocity term when it can use velocity.

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

LGTM


Add python3.10 support

@aneustroev any way to make progress on this one please?
Otherwise @dekoza would you accept/review another PR to fix it please?


[Feature Request] Ability to copy module from another project via cli

As a User I want ability to copy module and exported functionalities from external project.
E.g.
Someone has implemented Auth Module in their template project, I want to be able to do pynet c https:/github.com/somer_repo#somebranch -m ModuleNameToCopy -T TargetModuleName
This would allow us to create sort of pynest specific package repos e.g. there are repos for Django applications

Hi @rnbokade , I really like this idea. I'm adding here a more whole feature request -
Feature Request: PyNest Module Copy Command
User Story
As a user, I want the ability to copy a module and its exported functionalities from an external project.
Example Use Case:
If someone has implemented an Auth Module in their template project, the user wants to be able to copy it into their own project using a command like:
pynet c https:/github.com/some_repo#some_branch -m ModuleNameToCopy -T TargetModuleName

This would allow for the creation of PyNest-specific package repositories, similar to how there are repositories for Django applications.
Clarifying the Requirements
Source and Target Repositories:

Source Repository: The repository from which the module will be copied.
Target Repository: The repository into which the module will be copied.

Module Names:

ModuleNameToCopy: The name of the module in the source repository.
TargetModuleName: The name of the module in the target repository after copying.

Command Functionality:

The command should pull the specified module and integrate it into the target project seamlessly.
It should handle dependencies and configurations necessary for the module to function in the new environment.

Guiding Questions
Repositories and Branches:

Can you provide the exact URL of the source repository and the branch from which the module needs to be copied?
Do you have access to both the source and target repositories?

Modules and Dependencies:

What is the name of the module you want to copy from the source repository?
What should be the name of the module in the target repository?
Are there any specific dependencies that the module relies on? If yes, should these be copied or referenced separately?

Target Environment:

Is the target project already set up to use PyNest, or will additional setup be required?
Are there any existing modules in the target project that might conflict with the new module?

Implementation Details:

Should the command handle any necessary environment configurations (e.g., .env files, database connections)?
Are there any specific files or directories that should be excluded or included during the copy process?

Implementation Steps
1. Clone the Source Repository
Use Git commands to clone the specified branch of the source repository.
git clone -b some_branch https://github.com/some_repo temp_repo

2. Copy the Module
Navigate to the module directory and copy its contents to the target project.
cp -r temp_repo/path/to/ModuleNameToCopy target_repo/path/to/TargetModuleName

3. Update Configurations
Adjust any configurations in the target project to ensure compatibility (e.g., import paths, environment variables).
4. Install Dependencies
Install any additional dependencies required by the copied module.
5. Clean Up
rm -rf temp_repo

Example Command Workflow
Cloning the Repository:
git clone -b some_branch https://github.com/some_repo temp_repo

Copying the Module:
cp -r temp_repo/path/to/ModuleNameToCopy target_repo/path/to/TargetModuleName

Updating Configurations and Dependencies:
Modify import paths, and environment variables, and install necessary dependencies.
Cleaning Up:
rm -rf temp_repo


Tabs animations

I'm using version 2.0.0-alpha.11 of angular/material and I'm wondering if there was a way to disable the tab animations.
I'm also running into issues in my karma tests where the tabs don't change, which may be caused by the animations, since I didn't have this issue with alpha.10.  Do I need to add an additional import or dependency to the TestBed to get this working?
Here is the test and selectChange method for the tab group:
it('should change activeTabIndex when tab changes', async(() => {
    let fixture = TestBed.createComponent(AppComponent);
    let component = fixture.componentInstance;

    fixture.detectChanges();

    let compiled = fixture.debugElement.nativeElement;
    let tabs = compiled.querySelectorAll('.md-tab-label');
    tabs[1].click();	// change to something other than tab 0
    expect(component.activeTabIndex).toBe(1);
 }));

  selectChange(event: MdTabChangeEvent): void {
    this.activeTabIndex = event.index;
    console.log(event.index);
  }

Try adding another fixture.detectChanges() after clicking the tab.

I've tried that and it doesn't work.

Otherwise you can see how we're testing it here: https://github.com/angular/material2/blob/master/src/lib/tabs/tab-group.spec.ts#L44

In your test, you test for the MdTabGroup's selectedIndex which does change.  However, I'm trying to test whether my selectChange callback gets called and it doesn't.  The activeTabIndex value never gets updated.

<md-tab-group (selectChange)="selectChange($event)">
</md-tab-group>

This is how I'm defining the selectChange callback and this works when I run the app normally.  Just doesn't work in the tests.
Also to reiterate my other question, is it possible to disable the animations?

I don't think it is, unless you do something like * { animation: none !important; transition: none !important; } in your CSS.
Regarding the test, what are you doing in the selectChange method? Maybe something isn't being updated there?

The selectChange method is in my first post.

Ah sorry, I missed it. What value comes back when you try to log the index? undefined?

Yes undefined.

In our tests it also looks like we flush the timeouts. Try changing your test to this:
import {fakeAsync} from '@angular/core/testing';

it('should change activeTabIndex when tab changes', fakeAsync(() => {
  let fixture = TestBed.createComponent(AppComponent);
  let component = fixture.componentInstance;

  fixture.detectChanges();

  let compiled = fixture.debugElement.nativeElement;
  let tabs = compiled.querySelectorAll('.md-tab-label');
  tabs[1].click();  // change to something other than tab 0

  fixture.detectChanges();
  tick();

  expect(component.activeTabIndex).toBe(1);
}));

Yeah, be sure to call fixture.detectChanges() after the click. I've also experienced some strange behavior with debugElement, so maybe try using fixture.nativeElement instead.

Finally got it working, but I had to change the tick to tick(1000).  Thanks.

Cool, glad to help. I'll close the issue.

Anyway to disable animation by a class or property on md-tab-group? the css hack doesn't work.

I also need disabling of tabs animation, +1


Use testPool for ScalaXMLSpec parrallel test

Just the test improvement we discussed in #1214

Oh, I missed that, LGTM


Error with tt-rss v16.8 (f04b12d)

I just cloned Feediron from github to my plugins.local dir, and got this in Preferences → Plugins from XDebug.
Fatal error: Cannot redeclare define_default() (previously declared in \rss\include\functions.php:39) in \rss\include\functions.php on line 41
Call Stack
#	Time	Memory	Function	Location
1	0.0004	400024	{main}( )	...\backend.php:0
2	0.0672	2695064	Pref_Prefs->index( )	...\backend.php:123
3	0.0749	2806952	PluginHost->load_all( )	...\prefs.php:753
4	0.0780	2811840	PluginHost->load( )	...\pluginhost.php:145
5	0.0863	3349176	require_once( '\rss\plugins.local\feediron\init.php' )	...\pluginhost.php:168

I'll appreciate any help.

Looks like the include of "Functions.php" causes the error. I think all the includes should be changed to a include_once or require_once.

Yep, changing all include to include_once worked, thank you!

@m42e Thanks for the fix.
I recently experienced this problem while trying to set up tt-rss on my local machine (Windows 10, latest version of XAMPP with PHP 7.2.4). However on my hosted webspace (Linux with PHP 7.0.29) it works fine without modification.


Python not found

I can start the app with python2 fsociety
Trying to use many of the tools within, I get "python not found"
Fix??

Install Python2

Python2 isnt installed, just use the new version. with python3 https://github.com/fsociety-team/fsociety

how to start fsociety


Webview not showing up in ios.

Webview not showing up in ios..
In android it's working perfectly.
Webview is not showing in blank area.

Info.plist
	<key>io.flutter.embedded_views_preview</key>
	<true/>

code
class _BottomPromotionWebViewState extends State<BottomPromotionWebView> {
  double _height = 280;
  WebViewController _controller;

  @override
  Widget build(BuildContext context) {
    return SizedBox(
      height: _height,
      child: WebView(
        initialUrl: "https://www.pgurus.com/myJS/html/BuyMe_1.html",
        onWebViewCreated: (controller) {
          this._controller = controller;
        },
        onPageFinished: (url) async {
          var height = double.parse(await _controller
              .evaluateJavascript("document.documentElement.scrollHeight;"));
          setState(() {
            _height = height;
          });
        },
        navigationDelegate: (req) {
          launch(req.url);
          return NavigationDecision.prevent;
        },
        javascriptMode: JavascriptMode.unrestricted,
      ),
    );
  }
}

Hi @KartikPatelOfficial
Are you using it inside listview or cloumn? Please provide complete minimal code sample
Can you also please provide your flutter doctor -v your flutter run --verbose
Thank you

@TahaTesser
Yes i am using it inside SinglChildScrllView > Column.
In android it's working perfectly.
And also there's no run time exceptions for widget.
And i set fixed webview height.
For minimal code i am using that stateful widget (provided in issue) in column.
Here's my flutter doctor -v
[✓] Flutter (Channel master, 1.19.0-5.0.pre, on Mac OS X 10.15.5 19F101, locale en-IN)
    • Flutter version 1.19.0-5.0.pre at /Users/kartikpatel/developer/flutter
    • Framework revision<PHONE_NUMBER> (9 days ago), 2020-06-08 02:03:01 -0400
    • Engine revision dfdd88deb7
    • Dart version 2.9.0 (build 2.9.0-13.0.dev 87c5e3612b)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/kartikpatel/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.1

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.46.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[!] Connected device
    ! No devices available

! Doctor found issues in 1 category.

Hi @KartikPatelOfficial
Please check this code sample

Code Sample
import 'package:flutter/material.dart';
import 'package:webview_flutter/webview_flutter.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: SingleChildScrollView(
        child: Column(
          children: [
            Container(
              height: 300,
              child: Builder(builder: (BuildContext context) {
                return WebView(
                  initialUrl: 'https://flutter.dev',
                  javascriptMode: JavascriptMode.unrestricted,
                  gestureNavigationEnabled: true,
                );
              }),
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {},
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel dev, 1.20.0-0.0.pre, on Mac OS X 10.15.5 19F101, locale
    en-GB)
    • Flutter version 1.20.0-0.0.pre at /Users/tahatesser/Code/flutter_dev
    • Framework revision d9653445f4 (8 days ago), 2020-06-09 18:43:03 -0400
    • Engine revision e8c13aa012
    • Dart version 2.9.0 (build 2.9.0-14.0.dev 5c1376615e)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.46.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (5 available)
    • SM M305F      • 32003c30dc19668f          • android-arm64  • Android 10
      (API 29)
    • Taha’s iPhone • 00008020-001059882212002E • ios            • iOS 13.5.1
    • macOS         • macOS                     • darwin-x64     • Mac OS X
      10.15.5 19F101
    • Web Server    • web-server                • web-javascript • Flutter Tools
    • Chrome        • chrome                    • web-javascript • Google Chrome
      83.0.4103.106

• No issues found!

Yes Working

@KartikPatelOfficial
Hope you incorporate this in your code and fix the issue, you need to provide to fixed since webview can take all space and not properly work properly column without fixed height.
Thank you

@KartikPatelOfficial
I hope you solved the problem, closing, since long time without a response


[opentitanlib] Fix up instance names and ensure TAP straps have default values

Fix up IDs for UART and SPI instances. Some tests were still using "0" as the identifier for UART and SPI devices, but these are not supported across all transports. The correct identifiers are "console" for the UART console and "BOOTSTRAP" for Earl Grey's spi_device IP. The transport will convert these to the correct internal devices that interface with them.
Adjust FPGA flows to perform transport init before FPGA programming. Because the FPGA programming flow interacts with any currently-loaded OpenTitan, the host transport must be set up correctly first.
Ensure TAP straps have default values. The TAP straps should default to setting OT to have no TAP selected. Change the configs to reflect this.

This LGTM, I just have a question about the transport-init.
Does fpga load-bitstream not initialize the transport? Is it unreliable to use that command without having run transport-init, or is it just about the order of them when you execute both?

I believe fpga load-bitstream does not initialize the transport. transport init will change pins back to defaults, and I think fpga load-bitstream is focused on executing only its particular actions, like any other command.
opentitantool is intended to be usable in the middle of any running session, so it can't just assume it's allowed to change pin defaults in general. However, for tests, we're using it to cover the whole test session from start to finish, and we should start that session with the known state.
In cases so far, we can probably get away with doing fpga load-bitstream without transport init, so this is more of a change to be "technically correct," haha.


Do the binaries on PyPI have Vectorscan or Hyperscan?

I was under the assumption that the arm binaries use Vectorscan, and the x86_64 binaries use Hyperscan.
Is this understanding correct or am I missing something?
Edit:
After looking at the Container files, seems like all of them use vectorscan.
Could you please help confirm if my understanding is right, and if there is a way to use Hyperscan for the x86 binaries

Currently, they are all using vectorscan. Is this an issue?


Top navigation bar is broken

All links in the (top) navigation bar links to http://aimacode.github.io/x-ChapterName it should be http://aimacode.github.io/aima-javascript/x-ChapterName. This includes the home button.

I'm planning to fix this.

Fixed.


bump sync plugin to 0.1.10

@bparees FYI
@tdawson - can we use this PR to initiate the generation of a new RPM for the openshift-sync-plugin?  If not of course just let me know how you want us to register the ask.
However initiated, once that new RPM is ready, and after we merge https://github.com/openshift/jenkins/pull/238 tomorrow (march 3) we'll want to also have a new set of jenkins images created on brew-pulp to facilitate QE's testing of few features we have ready (and with 3.5 code freeze tomorrow march 3, we feel safe in doing so now)
thanks

to be clear, the new RPMs would be intended for jenkins images built for 3.6, not for 3.5.

If this is for 3.6, then it will be a week or two.  We still don't have the 3.6 build queues and targets setup.
But this is fine for a request.  I'll let you  know when it's been built and is ready.

gotcha - thanks for the info / help @tdawson

it isn't the gating factor, but as a fyi, https://github.com/openshift/jenkins/pull/238 has been merged

hey @tdawson - it has been a week since we last talked.  Just curious if the ETA for 3.6 build queues and targets setup is any clearer ... thanks.

They are being created as I write this, so hopefully we'll have this ready by end of day today.

Great - thanks as always @tdawson !!
Heads up, I got a bug from QE this morning testing our centos image that
will necessitate another bump to openshift-sync.  I'll tag you in the PRs I
create to cut the new version of openshift-sync.
On Thu, Mar 9, 2017 at 12:18 PM, Troy Dawson<EMAIL_ADDRESS>wrote:

They are being created as I write this, so hopefully we'll have this ready
by end of day today.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/openshift/jenkins/pull/254#issuecomment-285417827,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADbadCz0CrJOLx6Xi8kfXt_HcJp5zFpKks5rkDR_gaJpZM4MRelo
.

No images yet, but updated rpm is built, and is in the 3.6 puddles, and on the mirrors on enterprise-3.6