Imporove apex

This PR is for #117

Update cpprb and use the new class MPPrioritizedReplayBuffer (multi-process version PER), which doesn't requires manual lock

MPPrioritizedReplayBuffer doesn't lock whole buffer but critical section only

Remove busy loop and use efficient waiting by queue's get() method.
Remove slow proxy, SyncManager
Reduce access for shared value, trained_steps

Fix atomic increment, too. (+= requires manual lock. See doc)

Run learner at main process instead of background process
Remove writer.flush() (I just let TensorFlow flush. We might need to adjust flush timing for our needs)
Remove eps (small value) addition to TD, which is added in buffer.

This improvement have larger effect for small network and/or simple Env.
I tested by running example/run_apex_dqn.py with default "CartPole-v0" on CPU machine.
Please test other Envs and/or on GPU.
P.S.
Weights distribution with multiple queues seems to be inefficient because of multiple copying.
I will continue to consider other solution.

Hi @ymd-h , thanks for brilliant PR!! I would really appreciate your continuous support!
I checked changes of codes, and I think all of them would contribute improvement of ApeX performance.

P.S.
Weights distribution with multiple queues seems to be inefficient because of multiple copying.
I will continue to consider other solution.
Yeah, this is true. I also consider some workaround. Thanks!

Hi @ymd-h , thanks for brilliant PR!! I would really appreciate your continuous support!
I checked changes of codes, and I think all of them would contribute improvement of ApeX performance.

P.S.
Weights distribution with multiple queues seems to be inefficient because of multiple copying.
I will continue to consider other solution.
Yeah, this is true. I also consider some workaround. Thanks!

@keiohta
I updated the PR.

Merge master branch to take recent update
Use newer cpprb, which improved Segment Tree implementation

On my local machine, (a part of) logs at example/run_apex_dqn.py are followings;
Before PR

After PR

It seems that Super Linter v3 is strangely broken and we need to upgrade to v4. (I will add soon.)
https://github.com/github/super-linter/issues/2253


Couldn't find type for class Microsoft.ApplicationInsights.TraceListener.ApplicationInsightsTraceListener

Repro Steps
I have project A and project B. Project A is a SOAP service in which I import project B as a DLL reference.
Project A has Application Insights up and running. At some point, in project A, I call a function from project B and in that function I have a line of code that looks like
Debug.WriteLine("output message");.
Actual Behavior
An error is thrown: "Couldn't find type for class Microsoft.ApplicationInsights.TraceListener.ApplicationInsightsTraceListener, Microsoft.ApplicationInsights.TraceListener."
Note: I don't want to reference application insights in project B.
Is it possible NOT to collect data from System.Diagnostics or something like this?
Note: This happens even if Application Insights is disabled.

It sounds like B is trying to use the TraceListener resource before A has initialized it.
Can you provide us a small repro app so we can investigate this further?

@PhilipCotan , if scenario suggested by @MS-TimothyMothra above is correct, you may have a workaround - trace something from A before you invoke B, so AI is loaded into the memory beforehand.

@Dmitry-Matveev thanks for your suggestion. I'll try it and I'll let you know whether it works or not.
Cheers.

Any follow up to this?


Whitelist clubs from bot_reports.

international kingkiller

ok that was a little cancer i didnt realize i had to cast message.channel


Interlock -- Model Validation Requires Request Integrity

Team -- I have a PR outstanding that encapsulates HTTP request validation within the request models found in go-mod-core-contracts
https://github.com/edgexfoundry/go-mod-core-contracts/pull/71
This is the result of quite a bit of discussion in the Core Working Group, the point of which was that we identified that in many cases it was possible to submit a request to our REST APIs that was not valid. The following issue is the one that started this effort
https://github.com/edgexfoundry/blackbox-testing/issues/174
The PR for go-mod-core-contracts is complete and I am working on a follow up PR to integrate it into edgex-go. As part of my due diligence, I want to run the blackbox tests against the upcoming edgex-go PR. However I have found that we have a lot of issues in our blackbox test scripts with request integrity. Fields that are supposed to have a required value are not populated. Here is an example of the errors thrown by core-metadata when running the core-metadata-importer collection via Postman.
level=ERROR ts=2019-04-24T16:09:59.889698Z app=edgex-core-metadata source=rest_deviceprofile.go:52 msg="Name cannot be blank"
level=ERROR ts=2019-04-24T16:10:00.453664Z app=edgex-core-metadata source=rest_device.go:61 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.453818Z app=edgex-core-metadata source=rest_device.go:61 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.45401Z app=edgex-core-metadata source=rest_device.go:61 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.453853Z app=edgex-core-metadata source=rest_device.go:61 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.454341Z app=edgex-core-metadata source=rest_device.go:61 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.454429Z app=edgex-core-metadata source=rest_device.go:61 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.454562Z app=edgex-core-metadata source=rest_device.go:61 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.454575Z app=edgex-core-metadata source=rest_device.go:61 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.454587Z app=edgex-core-metadata source=rest_device.go:61 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.454688Z app=edgex-core-metadata source=rest_device.go:61 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.454721Z app=edgex-core-metadata source=rest_device.go:61 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.454847Z app=edgex-core-metadata source=rest_device.go:61 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.455018Z app=edgex-core-metadata source=rest_device.go:61 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.455055Z app=edgex-core-metadata source=rest_device.go:61 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.455148Z app=edgex-core-metadata source=rest_device.go:61 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.45545Z app=edgex-core-metadata source=rest_device.go:61 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.993425Z app=edgex-core-metadata source=rest_provisionwatcher.go:306 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.99348Z app=edgex-core-metadata source=rest_provisionwatcher.go:306 msg="invalid OperatingState \"\""
level=ERROR ts=2019-04-24T16:10:00.993502Z app=edgex-core-metadata source=rest_provisionwatcher.go:306 msg="invalid OperatingState \"\""

My ask is to please ensure the following

For any model that has an OperatingState property, that property needs to be populated with a correct value
For any model that has an AdminState property, that property needs to be populated with a correct value
For any model corresponding to an EdgeX entity (device, device profile, addressable, etc) on create, it needs to have a name. On update, it needs to have either an ID or a name.

What is your preferred method for addressing this? Would you like to do a pro-active review of the scripts to ensure required properties are populated? Or would you like me to proceed with the above integration and perform fixes based on what tests break? Since the imports don't even run successfully, A LOT of tests will fail -- if not all of them. Please advise ASAP.

FYI edgex-go PR has been created
https://github.com/edgexfoundry/edgex-go/pull/1284

I check the test script, we have OperatingState, AdminState in those device entities, and other entities have a name field.  So I'm not sure why you got the error.
I pull the edgex-go and run the core-metadata-importer again
level=INFO ts=2019-04-25T01:59:08.108269Z app=edgex-core-metadata source=main.go:56 msg="Service dependencies resolved..."
level=INFO ts=2019-04-25T01:59:08.108648Z app=edgex-core-metadata source=main.go:57 msg="Starting edgex-core-metadata 1.0.0 "
level=INFO ts=2019-04-25T01:59:08.108832Z app=edgex-core-metadata source=main.go:60 msg="This is the EdgeX Core Metadata Microservice"
level=INFO ts=2019-04-25T01:59:08.109058Z app=edgex-core-metadata source=main.go:67 msg="Service started in: 8.178627ms"
level=INFO ts=2019-04-25T01:59:08.109259Z app=edgex-core-metadata source=main.go:68 msg="Listening on port: 48081"
level=ERROR ts=2019-04-25T01:59:42.151058Z app=edgex-core-metadata source=rest_device.go:69 msg="no supporting protocol specified for device"
level=ERROR ts=2019-04-25T01:59:42.151089Z app=edgex-core-metadata source=rest_device.go:69 msg="no supporting protocol specified for device"
level=ERROR ts=2019-04-25T01:59:42.151082Z app=edgex-core-metadata source=rest_device.go:69 msg="no supporting protocol specified for device"
level=ERROR ts=2019-04-25T01:59:42.151054Z app=edgex-core-metadata source=rest_device.go:69 msg="no supporting protocol specified for device"
level=ERROR ts=2019-04-25T01:59:42.151146Z app=edgex-core-metadata source=rest_device.go:69 msg="no supporting protocol specified for device"
level=ERROR ts=2019-04-25T01:59:42.151202Z app=edgex-core-metadata source=rest_device.go:69 msg="no supporting protocol specified for device"
level=ERROR ts=2019-04-25T01:59:42.151287Z app=edgex-core-metadata source=rest_device.go:69 msg="no supporting protocol specified for device"
level=ERROR ts=2019-04-25T01:59:42.151364Z app=edgex-core-metadata source=rest_device.go:69 msg="no supporting protocol specified for device"
level=ERROR ts=2019-04-25T01:59:42.151441Z app=edgex-core-metadata source=rest_device.go:69 msg="no supporting protocol specified for device"
level=ERROR ts=2019-04-25T01:59:42.151499Z app=edgex-core-metadata source=rest_device.go:69 msg="no supporting protocol specified for device"
level=ERROR ts=2019-04-25T01:59:42.151585Z app=edgex-core-metadata source=rest_device.go:69 msg="no supporting protocol specified for device"
level=ERROR ts=2019-04-25T01:59:42.151654Z app=edgex-core-metadata source=rest_device.go:69 msg="no supporting protocol specified for device"
level=ERROR ts=2019-04-25T01:59:42.151704Z app=edgex-core-metadata source=rest_device.go:69 msg="no supporting protocol specified for device"
level=ERROR ts=2019-04-25T01:59:42.151754Z app=edgex-core-metadata source=rest_device.go:69 msg="no supporting protocol specified for device"
level=ERROR ts=2019-04-25T01:59:42.151816Z app=edgex-core-metadata source=rest_device.go:69 msg="no supporting protocol specified for device"
level=ERROR ts=2019-04-25T01:59:42.15189Z app=edgex-core-metadata source=rest_device.go:69 msg="no supporting protocol specified for device"
level=ERROR ts=2019-04-25T01:59:44.395323Z app=edgex-core-metadata source=rest_devicereport.go:66 msg="Item not found"
level=ERROR ts=2019-04-25T01:59:44.395466Z app=edgex-core-metadata source=rest_devicereport.go:66 msg="Item not found"
level=ERROR ts=2019-04-25T01:59:44.395495Z app=edgex-core-metadata source=rest_devicereport.go:66 msg="Item not found"
level=ERROR ts=2019-04-25T01:59:44.395551Z app=edgex-core-metadata source=rest_devicereport.go:66 msg="Item not found"
level=ERROR ts=2019-04-25T01:59:44.395608Z app=edgex-core-metadata source=rest_devicereport.go:66 msg="Item not found"
level=ERROR ts=2019-04-25T01:59:44.395692Z app=edgex-core-metadata source=rest_devicereport.go:66 msg="Item not found"
level=ERROR ts=2019-04-25T01:59:44.395828Z app=edgex-core-metadata source=rest_devicereport.go:66 msg="Item not found"
level=ERROR ts=2019-04-25T01:59:44.39608Z app=edgex-core-metadata source=rest_devicereport.go:66 msg="Item not found"
level=ERROR ts=2019-04-25T01:59:44.39608Z app=edgex-core-metadata source=rest_devicereport.go:66 msg="Item not found"
level=ERROR ts=2019-04-25T01:59:44.396126Z app=edgex-core-metadata source=rest_devicereport.go:66 msg="Item not found"

There are different errors in my console. I thought we need to fix the test script for the new Validate change.

Yes, it's the nested entities that are the problem. Your solution sounds good. I'm concerned about the timing. If you're OK with the notice that tests will break once the edgex-go PR is merged, then we can proceed independently.

I thought to remove the ref $id in CoreCommands is OK.
But the device entity is a problem, it means the API will break with this general usage:
curl localhost:48081/api/v1/device -H "Content-Type:application/json"
 -X POST  \
   -d '{
           "name":"Variable Speed motor3",
           "description":"MicroMax Variable Speed Motor",
           "adminState":"UNLOCKED",
           "operatingState":"ENABLED",
           "addressable":{"name":"Motor"},
           "labels":["motor","modbus"],
           "service":{"name":"edgex-device-modbus"},
           "profile":{"name":"Network Power Meter3"}
}'

So you mean I need to add the device with entire device service entity?

Yes. A large type like Device that has nested child types has to have all required fields specified. So for the device you would need a minimum of the required fields for Addressable, AdminState, OperatingState, Service and Profile -- just like you've done above.
FWIW I've presented a proposal in the Core WG that would simplify requests, using a specific type for the API request that doesn't require this hugely nested structure. But this is where we are right now. I expect we'll be discussing refactoring next week in Seoul.

Ok, I get it now,  we will modify the test script, thanks.


Changes for amlupdate.sh to be run as sudo, and possibly multiple times.

@scobb,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Refactor range contains check function

The validity_range_contains_range function incorrectly returned False when a contained
range had the same end date as the containing range.
This commit fixes that by checking that the contained range bounds are within or equal
to the containing range bounds.
Also, a couple of fixes to tests that failed after this change

the tests for this function, natch
the footnotes editing test was submitting an empty start date when editing the end date
the measures tests were missing the measure_type_series validity period (probably only passed before because of the bug this commit fixes)

Codecov Report

Merging #86 into master will increase coverage by 0.02%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   66.00%   66.03%   +0.02%
==========================================
  Files         123      123
  Lines        6172     6194      +22
  Branches      371      380       +9
==========================================
+ Hits         4074     4090      +16
- Misses       2008     2010       +2
- Partials       90       94       +4

Impacted Files
Coverage Δ

common/tests/test_util.py
100.00% <ø> (ø)

measures/tests/test_business_rules.py
95.61% <ø> (ø)

common/util.py
57.89% <66.66%> (+0.75%)
:arrow_up:

footnotes/tests/bdd/test_edit_footnote.py
97.87% <90.90%> (-2.13%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 866e1dc...a3942d0. Read the comment docs.


Problems with find_by

Hi there,
I am trying to find a model entry with find_by.
Here is an example:
Speaker.all.load().each do |s|
    ap "#{s.class} #{s.id} #{s.name}"
    ap s.fields
end

co = Speaker.find("5N1ZmKH7682WKAsW0ACwqC")
puts co.name
co2 = Speaker.find_by(:name => "Christian Ott").load
puts co2.name

This outputs and throws an error:
"Speaker 5N1ZmKH7682WKAsW0ACwqC Christian Ott"
{
        :name => "Christian Ott",
    :jobtitle => "Informatiker"
}
Christian Ott
import.rb:54:in `<main>': undefined method `name' for <Contentful::Array total=1 skip=0 limit=100>:Contentful::Array (NoMethodError)

What am I missing? I am using preview api mode.
Christian

Hey @chriso0710,
Which version of the gem are you using?
Cheers

I am using the latest 0.2.0, from the github master branch.
Additionally:
contentful (2.1.1)
contentful-management (1.8.1)
jekyll-contentful-data-import (1.6.0)

Hey @chriso0710,
Just understood your error.
::find_by returns an array of entries, therefore you're missing either calling #first or #each on the array.
Cheers

Thank you for your answer and sorry for taking so long to respond.
You are right, of course. My mistake for not expecting/checking the (obvious) Contentful::Array class.
Thanks again
Christian


Fix for issue #6, fix api calls backports compatible

Fix for apiv3, certname field in response does not exist.
See https://docs.puppet.com/puppetdb/2.3/api/query/v3/nodes.html#response-format.
Fix for apiv4, query syntax now uses _ instead of -.
See https://docs.puppet.com/puppetdb/4.1/api/query/v4/upgrading-from-v3.html
When query fails UNKNOWN is returned.

I tested against my puppetdb 2.3 and saw that certname isn't returned in the response, so I changed that too.

looks good, thanks. will test later today and merge then :)

thanks!


{{ghost_head}} not working on error page in Ghost 0.6.0

The theme I currently use, has a custom 404 error template in error.hbs. It uses the {{ghost_head}} helper in the template. This worked fine in all 0.5.x versions
After upgrading to 0.6.0 however, I get the following error when browsing to a non-existing page:
ERROR: [error.hbs] Cannot read property '0' of undefined
 Error whilst rendering error page
 Error template has an error
 TypeError: [error.hbs] Cannot read property '0' of undefined
    at Object.ghost_head (/Users/frank/src/openminds/frank/ghostblog/core/server/helpers/ghost_head.js:269:31)
    at Object.<anonymous> (/Users/frank/src/openminds/frank/ghostblog/core/server/helpers/index.js:60:28)
    at Function.Waiter.resolve (/Users/frank/src/openminds/frank/ghostblog/node_modules/express-hbs/lib/async.js:83:3)
    at Object.<anonymous> (/Users/frank/src/openminds/frank/ghostblog/node_modules/express-hbs/lib/hbs.js:394:18)
    at Object.eval (eval at <anonymous> (/Users/frank/src/openminds/frank/ghostblog/node_modules/express-hbs/node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:209:23), <anonymous>:11:166)
    at ret (/Users/frank/src/openminds/frank/ghostblog/node_modules/express-hbs/node_modules/handlebars/dist/cjs/handlebars/runtime.js:144:30)
    at ret (/Users/frank/src/openminds/frank/ghostblog/node_modules/express-hbs/node_modules/handlebars/dist/cjs/handlebars/compiler/compiler.js:462:21)
    at renderTemplate (/Users/frank/src/openminds/frank/ghostblog/node_modules/express-hbs/lib/hbs.js:481:13)
    at render (/Users/frank/src/openminds/frank/ghostblog/node_modules/express-hbs/lib/hbs.js:529:5)
    at renderIt (/Users/frank/src/openminds/frank/ghostblog/node_modules/express-hbs/lib/hbs.js:591:18)

(Forum thread: https://ghost.org/forum/installation/18712-ghost_head-not-allowed-in-error-hbs-after-upgrading-to-0-6-0/)

@franklouwers thanks for the bug report, we'll get it fixed up :)

PR inbound https://github.com/TryGhost/Ghost/pull/5149

So others can google this issue based on the text on the error page:
Oops, seems there is an error in the error template.

Encountered the error:

[default.hbs] Cannot read property '0' of undefined

whilst trying to render an error page for the error:

404
Page Not Found


Task/goldi enhancements

A lot of refactoring and code cleanup
Fixes #18

Coverage increased (+0.83%) to 93.63% when pulling aa02761d9ed19656b4538337e60df4fe014c81f3 on task/goldi-enhancements into cfbee6226023f3ee3fda6a7fadea9aea2e6635fb on master.


As a technical contact, I need guidance so I can understand open source and open source licensing.

During the UX research it was established that technical contacts within the client programs were unclear how to create an open source project and select the correct licensing.
Created by the UX research team
DOD

Content suggestions
Design suggestions (wireframes)

Connect with Loren/Rommel

Note that we have a document which details open source licensing in the BC Govt context.

@DavidR8 Super. Could you please flip it to me when you have a moment.


KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found

Jira
This restores previous behavior for Admin::listOffsets, which was to fail immediately if topic metadata could not be found, and only retry if metadata for one or more specific partitions could not be found.
There is a subtle difference here: prior to https://github.com/apache/kafka/pull/13432, the operation would be retried if any metadata error was reported for any individual topic partition, even if an error was also reported for the entire topic. With this change, the operation always fails if an error is reported for the entire topic, even if an error is also reported for one or more individual topic partitions.
I am not aware of any cases where brokers might return both topic- and topic partition-level errors for a metadata request, and if there are none, then this change should be safe. However, if there are such cases, we may need to refine this PR to remove the discrepancy in behavior.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

What was the original rationale for https://issues.apache.org/jira/browse/KAFKA-12339? My understanding is that when a topic is first created, there is sometimes a delay to the metadata propagation. It seems like connect was encountering this issue and rather than adding code to retry they wanted it to be done automatically.
I can see the issue with the compatibility break, but I also see the issue with the metadata propagation. Is there anyway to configure whether we prefer to retry on such an error? Or is the argument this should always be left to the client to handle the manual retries?

Sorry for the delay @C0urante and thanks for the explanation. It makes sense.
Given that we moved the retries to TopicAdmin::retryEndOffsets does this mean there is not any known wide usage or need for this retry?

No worries about the delay, thanks for continuing to work on this @jolshan!

Given that we moved the retries to TopicAdmin::retryEndOffsets does this mean there is not any known wide usage or need for this retry?

Not that I'm aware of, though if anyone believes otherwise, we can discuss later. Considering the change in behavior that we're targeting here seems to have been made accidentally, I think we should err on the side of preserving existing behavior until we have a rationale for changing it and do so intentionally.

I guess that was sort of the question in the final part of the pr description.

The last question is about broker behavior (especially across prior releases). Metadata responses from brokers can contain both topic-level errors and topic partition-level errors. If there's a case where a broker returns an error for topic t, but also returns errors for one or more partitions in topic t, then this PR will result in a change in behavior. I'm optimistic that that case doesn't exist, but wanted to note it to be safe.

Also -- I assume we want to pick this to 3.6 as well. Is that the only branch @C0urante?

Tests look unrelated and like flakes I've seen before, so I will go ahead and merge + pick to 3.6

Sorry! Yes, that's correct--3.6 is all we need to backport to. Thanks @jolshan!


[Test] Speculatively fix a non-deterministic issue

Somehow, deinit isn't called deterministically. Instead of using deinit to print out the summary, use finalize() which is intended to finalize the diagnostics.
Fixes rdar://problem/71046813

@swift-ci Please test

@swift-ci Please smoke test

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - c30abf85e8f6ff6d8a983c489d8566533a705e33

Build failed
Swift Test OS X Platform
Git Sha - c30abf85e8f6ff6d8a983c489d8566533a705e33


While Deploying my web app in Vercel its saying "The Serverless Function "index.js" is 51.71mb which exceeds the maximum size limit of 50mb."

While Deploying my web app in Vercel its saying "The Serverless Function "index.js" is 51.71mb which exceeds the maximum size limit of 50mb." Please remove files that are large from package

@awesome-yasin I believe this is caused by pdfjs-dist

Sorry, I am not able to reproduce this issue


Update Terraform provider version to 2.53.1

Description of your changes
Updated Terraform provider version to 2.53.1
I have:

[x] Read and followed Crossplane's [contribution process].
[ ] Run make reviewable to ensure this PR is ready for review.
make lint seems to fail on main as well for me

How has this code been tested

Ran make crddiff & make test locally
Ran an e2e test against a local environment
Uptest tests in the comments below:

/test-examples="examples/app/v1beta1/roleassignment.yaml"

Hi @turkenf,
I tried it out and after updating the dependency to the stated version, I am getting the following error:
17:40:29 [ .. ] go generate linux_amd64
# github.com/hashicorp/terraform-provider-azuread/internal/provider
../../../../go/pkg/mod/github.com/upbound/terraform-provider-azuread@v0.0.0-20240827105353-b0f94b9249b7/internal/provider/provider.go:303:49: not enough arguments in call to environments.FromEndpoint
        have (context.Context, string)
        want (context.Context, string, string)
apis/generate.go:25: running "go": exit status 1
17:40:32 [FAIL]
make[1]: *** [go.generate] Error 1
make: *** [generate] Error 2

Hi @turkenf, did you get the time to look at this?

Hi @hazim1093, I haven't had a chance to look at it yet due to priorities. When I can, I'll let you know. Thank you for your patience.

@hazim1093 I was able to successfully run make generate. The error you get is due to outdated version of github.com/hashicorp/go-azure-sdk/sdk in go.mod. Strangely, go mod tidy did not handle that indirect dep update as it is. Tried to push the change to your branch, but I am not permitted, so here are the steps
as Fatih mentioned, replace terraform-provider-azuread dependency to the fork @upjet-v2.53.1 if not already in go.mod
go mod edit<EMAIL_ADDRESS>
open go.mod in your text editor, remove the line
github.com/hashicorp/go-azure-sdk v0.20231018.1171511 // indirect

then, run
go mod tidy

This correctly updates the version for go-azure-sdk dependency and generation succeeds when:
make generate

Hi @turkenf, I tried it out and after updating the dependency to the stated version, I am getting the following error:
17:40:29 [ .. ] go generate linux_amd64
# github.com/hashicorp/terraform-provider-azuread/internal/provider
../../../../go/pkg/mod/github.com/upbound/terraform-provider-azuread@v0.0.0-20240827105353-b0f94b9249b7/internal/provider/provider.go:303:49: not enough arguments in call to environments.FromEndpoint
        have (context.Context, string)
        want (context.Context, string, string)
apis/generate.go:25: running "go": exit status 1
17:40:32 [FAIL]
make[1]: *** [go.generate] Error 1
make: *** [generate] Error 2

Thanks @erhancagirici.
I've updated the go-azure-sdk/sdk as you mentioned, but I still the same errors during make lint.
make generate works fine, make reviewable fails due to lint failing.

@hazim1093 can you provide me push access to your fork/branch or make the following changes?
First, please rebase the PR to the latest main.
while bumping go-azure-sdk/sdk seems like your commit also bumped the following.  I am able to successfully build & lint & run tests.
If this does not work for you, please provide access and I can push.

Thank you for your effort in this PR @hazim1093, to move faster, closing in favor of https://github.com/crossplane-contrib/provider-upjet-azuread/pull/167


NullString::to_string can panic

Thanks for your work on binread/binrw!
I stumbled upon some unexpected panics inside binread, when calling NullString::to_string, which calls std::str::from_utf8 and unwraps the result.
This is unexpected and quite different from the behavior for NullWideString, as well as from the implementations of the into_string methods, and from a user point of view, a call to to_string is not expected to be able to panic at all.
I can see two possible fixes:

Remove those ToString implementations. I actually replaced them with calls to into_string(), and i'm not sure how useful they are.
Fix the ToString implementation for NullString to do: String::from_utf8_lossy(self).to_string().

What is your opinion on this?

Thanks for raising this concern, changed it to be lossy rather than panic in 0.9.2


[WIP] CMake rewrite

@pseudotensor @navdeep-G the build seems to be passing, think I'm done. Can I get a final check before merge?
@pseudotensor I went through the things we found during our review and fixed most:

DEBUG AND USENVTX are back (with description in DEVEL.md how to use)
Added an example how to add new code, it's in EXAMPLE_SOLVER.md
removed a lot of redundant declarations in *.i files (not all) by using header files - unfortunately looks like SWIG requires to have those declarations in 2 places so that's the only way to DRY it
changed the int * to size_t * where appropriate

2 more things I need to double check:

SWIG generated wrapper complains about ch2o4gpu_gpu.py:15: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
need to make sure SWIG isn't creating any new pointers/objects and we don't have any leaks - any ideas how to make an automatic test for this?

LGTM. Will test out more once in master. :)


How to contrib ?

I like the idea, and will use the plugin. I would love to help in the development of new features!

Hi Andrés, thank you for being interested in the project. You can support development by sharing feature proposals or creating PRs with particular implementations.
I started this project as an MVP for personal use but I'm happy to extend it with functionality that will be valuable to other users as well.


[orf] please support --no-playlist for segmented features

Checklist

[x] I'm reporting a site feature request
[x] I've verified that I'm running youtube-dl version 2021.02.22
[x] I've searched the bugtracker for similar site feature requests including closed ones

Description

Many features on tvthek.orf.at are divided in segments (news, magazines, opera and theater, sports events, etc.). Nearly all of those have an alternative video for the full feature. ytdl currently only detects the segments as a playlist, but not the full video.
Feature request: please detect the full video, so it can be downloaded instead of the segments using --no-playlist
Implementation wish: segmented features take the extractor a lot of time to get all formats of all segments. So an optimisation would be great to skip analysing the segments when [a full video exists] and [--no-playlist is given].
Additional Info
The mediathekview crawler already detects the full videos. On the site http://mediathekviewweb.de they are shown among the segments, recognisable by the length and (most of the times) by the name.
Example (most current, available worldwide, will be online 7 days):
https://tvthek.orf.at/profile/AKTUELL-nach-fuenf/13887571/AKTUELL-nach-fuenf/14083355
Best [hls-Q8C-Sehr hoch] URL of full video (from the page, before redirection):
https://apasfiis.sf.apa.at/ipad/cms-worldwide_episodes/14083355_0013_Q8C.mp4/playlist.m3u8
Best [hls-Q8C-Sehr hoch] URL of first segment (from the page, before redirection):
https://apasfiis.sf.apa.at/ipad/cms-worldwide/2021-02-26_1708_tl_02_AKTUELL-nach-fu_Signation__14083355__o__1066098380__s14867944_4__BCK2HD_17085703P_17090911P_Q8C.mp4/playlist.m3u8

👍🏿
Unfortunately, all broadcasts with chapters are only available for 7 days. But to test, you can try this URL, always pointing to the last episode:
https://tvthek.orf.at/profile/Willkommen-Oesterreich/1309549
Or, open https://tvthek.orf.at/profiles/letter/W and scroll down to "Willkommen Österreich" and you should also find the latest episode for testing.
Thanks,
Thomas

This would be really, really great.

Superseded by #32798.


fix: Fixing linting errors

#60  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Error in http_client main.rs

Running http client example main.rs is giving an error
jason@webassembly120:~/wasm_storage$ cargo build --bin httpclient --target wasm32-wasi
    Finished dev [unoptimized + debuginfo] target(s) in 0.01s
jason@webassembly120:~/wasm_storage$ wasmedge ./target/wasm32-wasi/debug/httpclient.wasm
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: IO(Error { kind: WriteZero, message: "failed to write whole buffer" })', src/bin/httpclient.rs:12:73
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[2022-11-10 23:12:21.926] [error] execution failed: unreachable, Code: 0x89
[2022-11-10 23:12:21.926] [error]     In instruction: unreachable (0x00) , Bytecode offset: 0x0006b1b7
[2022-11-10 23:12:21.926] [error]     When executing function name: "_start"

Thanks for your help.

Hi @JasonLou99, Thanks for reporting this!
It seems that the error is caused by outdated http_req.
Please update the wasmedge_http_req to 0.9.0.
We will fix this in #74.

Thanks!


Enhance the DataFilter documentation

The current documentation is frustrating
The concept is introduced in the REST quick start in a sentence.
In that sentence, we are invited to read the Resource section for more information, which just displays another sentence, inviting us to:

read the Quick Start for an example (I was just there)
the data provider section on Data Filters which yields a small example for a single model filtering.

There are no information to be found on how to filter on a relation, how to properly form GET queries with advanced filters, ..
A real-world example would be more than welcome.

Also, clearly talk about ActiveDataFilter and DataFilter in this page https://www.yiiframework.com/doc/guide/2.0/en/output-data-providers#filtering-data-providers-using-data-filters
The link at the bottom is responsible for wasting me 3 hours today.

Yes, totally agree. I also spent huge time on this when trying to grasp the idea and do some enhancements. The problem is as usual with no time available to write better docs...


HDDS-11017. Migrated from react-scripts to Vite and Vitest

What changes were proposed in this pull request?
HDDS-11017. Migrated from react-scripts to Vite and Vitest and upgraded to AntD v5
Please describe your PR in detail:

While conducting a fossa scan we found that node-notifier and jsdom is not compatible with Apache license
This PR migrates from the react-scripts used in the current project to Vite and Vitest which resolved the licensing issue
Apart from that this will bring additional improvements like:

Faster local development time
Faster builds
Migration to AntD v5 which will allow us to directly upgrade to newer versions
Shift from xo to eslint and prettier - this will make the development experience more smooth and consistent for contributors

What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11017
How was this patch tested?
The patch was tested manually on local build

@ivandika3 @smitajoshi12 could you please take a look at this PR when you have time?
Thanks

Closing this as FOSSA scan is yet to be run to finalize lib selection and issue resolution


Disabling menu options programmatically

In first place, thank you for the library, I think is great!
my concern is if it's possible to disable some items of the menu programmatically? I've tried using setHasOptionsMenu and onPrepareOptionsMenu, but seems like it doesn't work, it just the onPrepareOptionsMenu is not being called in the fragment. Thanks.

Nevermind, it was my mistake, to handle it I just has to get the menu from the BottomNavigationViewEx and handle it as a normal menu.


TemplateDoesNotExist in rest_framework with Django 1.10.1

With the current master and current Django version (1.10.1) the rest framework could not be shown when navigating to your.server/rest. The framework in OpenSlides works. But for development, this is a bit annoying.
A temporary fix would be to stick to version 1.9.9 and wait until this is fixed in Django.
The Traceback:
Template loader postmortem
Django tried loading these templates, in this order:
Using engine :
    This engine did not provide a list of tried templates.

Traceback:

File "/home/finn/OpenSlides/.virtualenv/lib/python3.4/site-packages/django/core/handlers/exception.py" in inner
  39.             response = get_response(request)
File "/home/finn/OpenSlides/.virtualenv/lib/python3.4/site-packages/django/core/handlers/base.py" in _legacy_get_response
  249.             response = self._get_response(request)
File "/home/finn/OpenSlides/.virtualenv/lib/python3.4/site-packages/django/core/handlers/base.py" in _get_response
  217.                 response = self.process_exception_by_middleware(e, request)
File "/home/finn/OpenSlides/.virtualenv/lib/python3.4/site-packages/channels/handler.py" in process_exception_by_middleware
  227.             return super(AsgiHandler, self).process_exception_by_middleware(exception, request)
File "/home/finn/OpenSlides/.virtualenv/lib/python3.4/site-packages/django/core/handlers/base.py" in _get_response
  215.                 response = response.render()
File "/home/finn/OpenSlides/.virtualenv/lib/python3.4/site-packages/django/template/response.py" in render
  109.             self.content = self.rendered_content
File "/home/finn/OpenSlides/.virtualenv/lib/python3.4/site-packages/rest_framework/response.py" in rendered_content
  72.         ret = renderer.render(self.data, accepted_media_type, context)
File "/home/finn/OpenSlides/.virtualenv/lib/python3.4/site-packages/rest_framework/renderers.py" in render
  696.         template = loader.get_template(self.template)
File "/home/finn/OpenSlides/.virtualenv/lib/python3.4/site-packages/django/template/loader.py" in get_template
  25.     raise TemplateDoesNotExist(template_name, chain=chain)
Exception Type: TemplateDoesNotExist at /rest/
Exception Value: rest_framework/api.html

Temporary workaround: pip uninstall Django && pip install "Django<1.10"

Fixed with #2373


Sometimes when enemies dies the game "breaks"

Description:
Sometimes when enemies dies the game "breaks". Alita disappears and the music stops, so it breaks.

Build:
<IP_ADDRESS>

Type:
A

Steps to reproduce:
Kill enemy.

Frequency:
Sometimes

In theory this is now fixed.


Lab Information Updates through ReportStream

Problem Statement
We received an email from Kenny McNeil<EMAIL_ADDRESS>Consultant to CDC DCIPHER Program, regarding what occurs when labs submit new or changed information.
What you need to know
Initial inquiry email:

I have a quick question for the lab team. Is the lab information ever updated or changed that we should ever expected updated or corrected information come through our connection?

Follow-up for clarification:

Thank you for contacting the ReportStream Support team.
We appreciate your inquiry and would like to assist with any information you need. Could you please provide me with some examples of what kinds of lab information you are referring to? (e.g. CLIA number, facility name, Ordering Provider/NPI, etc.)

Confirmation of inquiry:

Sure! I was inquiring about any of the data provided. If we should ever expect any values to go from null to populated or change, such as facility name, ordering provider or even any results.

Acceptance Criteria
Establish a document/statement detailing what happens when new or changed lab information is submitted and when this can occur.
To Do

[ ] Determine what, if any, notifications or indicators are present when new or changed lab information is submitted
[ ] Create a standardized response to provide to ReportStream users who may ask about this
[ ] Provide details to the ReportStream Support team to address the current inquiry from Kenny

Additional Comments
The requester, Kenny McNeil, is part of the National Center for Emerging and Zoonotic Infectious Diseases (NCEZID) via Booz Allen Hamilton.

I'm... not sure I really understand this question? We pass on the info we're given...

@wcollin89 please confirm what the need is for this ticket or if we can close it. Thanks!

@adegolier @GilmoreA6 I believe the user just wants confirmation when a lab name is changed or corrected it won't affect their system.  But I don't believe our Reportstream settings have a static Lab Name, city, etc. field where DCipher would need to be notified of that change.

Sharon to respond to email. Closing


Add SAST logs to OCM component descriptor

What this PR does / why we need it:
Add SAST logs to OCM component descriptor.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

This PR proposes changes that would break the pipeline definition:
gardener-extension-shoot-networking-filter-enhancement_enable-gosec-result-upload: Traceback (most recent call last):
  File "/usr/lib/python3.12/site-packages/concourse/replicator.py", line 141, in render
    definition_descriptor = self._render(definition_descriptor)
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/concourse/replicator.py", line 185, in _render
    'definition': factory.create_pipeline_definition(),
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/concourse/factory.py", line 88, in create_pipeline_definition
    self._apply_traits(variant)
  File "/usr/lib/python3.12/site-packages/concourse/factory.py", line 177, in _apply_traits
    transformer.process_pipeline_args(pipeline_def)
  File "/usr/lib/python3.12/site-packages/concourse/model/traits/release.py", line 495, in process_pipeline_args
    raise ValueError(f'{asset=}\'s step_name refers to an absent build-step')
ValueError: asset=BuildstepLogAsset(ocm_labels=[{'name': 'gardener.cloud/purposes', 'value': ['lint', 'sast', 'gosec']}, {'name': 'gardener.cloud/comment', 'value': 'we use gosec (linter) for SAST scans\nsee: https://github.com/securego/gosec\nenabled by https://github.com/gardener/gardener-extension-shoot-networking-filter/pull/181\n'}], type='build-step-log', name='verify-build-step', step_name='verify', artefact_type='application/data', purposes=['lint', 'sast', 'gosec'], comment='we use gosec (linter) for SAST scans\nsee: https://github.com/securego/gosec\nenabled by https://github.com/gardener/gardener-extension-shoot-networking-filter/pull/181\n')'s step_name refers to an absent build-step

The pipeline-definition has been fixed.


TabNine config incorrectly documented in IntelliJ.

OS version: Win10
Editor: intelij
Editor version: Community 2020.3
Programming language: Lua
TabNine extension version: 0.2.9, TabNine 3.2.63-32

Issue Details:
In the text details for the IntelliJ TabNine plugin, the description seems to be for both a different platform (Mac?) and a different IDE (Microsoft?)
Examples:
"Installation Instructions
Press Cmd+,to open the Settings/Preferences dialog"

There is usually no "Cmd" key on a Windows machine. The hotkey is Ctrl-Alt-S.
There is no such thing as a "Settings/Preferences" dialog in Windows' IntelliJ, it's "File" menu -> "Settings" menu item -> "Plugins" section.

"Trouble installing? Check out our FAQ page, or contact<EMAIL_ADDRESS>
The FAQ page contains no information on installing Tabnine in intelliJ.

"After Tabnine’s installation, navigate to the Tabnine Settings page (‘Tabnine: Open Settings’ from the Command Palette) and verify that Tabnine local model is successfully loaded (as shown in the following screenshots)"

There is no "Command Palette" in IntelliJ, and "Command Palette" is a link to the Visual Studio site.
There are no "following screenshots".
There appears to be no settings page for TabNine in IntelliJ. This is unfortunate, as if there were a way to stop it prioritizing its bad suggestions over the IDE's correct suggestions, I would likely continue using it.

Thank you for reporting this!
We will make sure to improve it!
Thanks!

Thank you for reporting this!
We will make sure to improve it!
Thanks!

Hey @DewiMorgan,
Just letting you know we've updated the textual details you've mentioned.
Thanks again for bringing this to our attention!

Hey @DewiMorgan,
Just letting you know we've updated the textual details you've mentioned.
Thanks again for bringing this to our attention!

Looks good to me! :D Fast response!

Looks good to me! :D Fast response!


Support for type = "vim/input"

From the docs, it seems that vim.fn.input() should be supported, however, this following configuration doesn't work as expected:
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
	vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.uv.fs_stat(lazypath) then
	vim.fn.system({
		"git",
		"clone",
		"--filter=blob:none",
		"--single-branch",
		"https://github.com/folke/lazy.nvim.git",
		lazypath,
	})
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
	"folke/tokyonight.nvim",
	"notomo/cmdbuf.nvim",
}

require("lazy").setup(plugins, {
	root = root .. "/plugins",
})

-- additional
vim.opt.termguicolors = true
vim.cmd([[colorscheme tokyonight]])

vim.keymap.set("c", "<C-f>", function()
	local cmdbuf = require("cmdbuf")

	local cmdtype = vim.fn.getcmdtype()

	cmdbuf.split_open(vim.o.cmdwinheight, {
		line = vim.fn.getcmdline(),
		column = vim.fn.getcmdpos(),
		type = cmdtype == "@" and "vim/input" or "vim/cmd",
	})
	vim.api.nvim_feedkeys(vim.keycode("<C-c>"), "n", true)
end)

(You can run this by copying it into repro.lua and the running nvim -u repro.lua)
If you use this config and run:

:echo input("How are you today? ")
Use <C-f> to enter the command buffer
Type any response and press <CR>

You won't see the thing you wrote being printed out...

Thanks for reporting!
Unfortunately, vim/input is not supported execute().
Because normal window cannot continue scripts after input().
I added notomo/cmdbuf.nvim@04076b5 .

Would you mind if I tried to get it to work on my own, and opened a pull request if I managed?

Sure!


ImportError: cannot import name 'ExpiredSignature'

Bug description
Regression of bug #3556.
Environment information
DefectDojo Commit Message:
[2021-02-17 10:19:48 +0100] 45f64b93: Update rabbitmq Docker tag from 3.8.11 to v3.8.12 (docker-compose.yml) (#3874) [ (HEAD, upstream/dev)]

Steps to reproduce
Try to log in to DefectDojo.
Actual result
[17/Feb/2021 18:41:05] "GET /login HTTP/1.1" 200 14013
[...]
Internal Server Error: /login
Traceback (most recent call last):
  [...]
  File "C:\GIT\DefectDojo\venv\lib\site-packages\social_core\backends\azuread_tenant.py", line 6, in <module>
    from jwt import DecodeError, ExpiredSignature, decode as jwt_decode
ImportError: cannot import name 'ExpiredSignature'

Root cause
requirements.txt
social-auth-app-django==4.0.0
[...]
PyJWT==2.0.1

Additional information
This bug is added by PR #3644.

I was afraid this could happen, the situation is quite unclear. Some libs support only <2 other only >=2 for PyJWT. I think we need someone actually using the Azure login to find out what PR we need to fix it. Maybe just downgrade back to 1.7.1?
@AndreyMZ Are you using Azure login, or are you seeing it in another social login as well? I think we have people running dev with Google SSO for example, without issues.

Should be fixed if we update to social-auth-core 4.0.3: https://github.com/python-social-auth/social-core/commit/e26c71cb9ee2fce9a423336ffb9dbc5a62ff4582

@AndreyMZ Are you using Azure login, or are you seeing it in another social login as well? I think we have people running dev with Google SSO for example, without issues.

Sorry for the delay in reply. Yes, usually I use Azure AD login. But this issue is reproduced without any social auth, because 'social_core.backends.azuread_tenant.AzureADTenantOAuth2' is in AUTHENTICATION_BACKENDS unconditionally (see dojo/settings/settings.dist.py:358).

Sorry for the delay in reply. Yes, usually I use Azure AD login. But this issue is reproduced without any social auth, because 'social_core.backends.azuread_tenant.AzureADTenantOAuth2' is in AUTHENTICATION_BACKENDS unconditionally (see dojo/settings/settings.dist.py:358).

That's weird because it works locally here and also in our integration tests. I did see that depending on the python / pip version it sometimes installs 1.7.x and sometimes 2.0.x. Looking at your log info looks like you're also running outside docker, which might explain it. Anyway, with that PR at least the most important libs are now used against 2.0.x.
We may better not include all those auth backend by default, on the other hand, by having them there by default we found out about this issue quite fast.

We may better not include all those auth backend by default, on the other hand, by having them there by default we found out about this issue quite fast.

This is it.

closing as it is fixed in 1.13.0


ImportError: No module named testapp

I have tried to run the testapp by navigating in the directory it is saying that the testapp not found.

Hi @babygame0ver thanks for reaching out. I must admit the testapp is only made for the test suite. So don't expect a great. But anyhow, you can run the app from the git root, like:
python tests/testapp/manage.py runserver

If that doesn't work, try:
PYTHONPATH=. python tests/testapp/manage.py runserver


Support LiveView 0.18.X

Hello and thanks for the great project!
This issue is to track support for the latest release of phoenix_live_view, 0.18.18.
Currently, it is incompatible
Because your app depends on flame_on ~> 0.2 which depends on phoenix_live_view ~> 0.17.6, phoenix_live_view ~> 0.17.6 is required.
So, because your app depends on phoenix_live_view ~> 0.18.3, version solving failed.

@davydog187 we do have support for LV 0.18 in main, however #26 is a real issue that I have not yet been able to resolve and was hoping to figure out before cutting an official hex release. Could you try main in your project and let me know if you run into the same issue outlined in #26? Either way if you could report your findings in that issue, it would be greatly appreciated.

@TheFirstAvenger appreciate it! I'll give it a run as soon as I can and report back

@TheFirstAvenger I was able to get it installed against the main branch. However, when running against the :cowboy_handler.execute/2 function, it resulted in a lot of spans and crashed the BEAM.
[debug] flame_on trace: call {:gen, :"-call/4-fun-0-", 4}, stack_size: 100
[debug] flame_on trace: call {:gen, :do_call, 4}, stack_size: 101
[debug] flame_on trace: call {:erlang, :monitor, 2}, stack_size: 102
[debug] flame_on trace: return_to {:gen, :do_call, 4}, stack_size: 103
[debug] flame_on trace: out {:gen, :do_call, 4}, stack_size: 102
[debug] flame_on trace: in {:gen, :do_call, 4}, stack_size: 103

[os_mon] cpu supervisor port (cpu_sup): Erlang has closed
[os_mon] memory supervisor port (memsup): Erlang has closed
[1]    27037 bus error  mix phx.server

I believe this may be related to #26. However, running against a smaller function like Phoenix.Flash.get/2 worked just fine

Thank you very much @TheFirstAvenger - i won't be able to verify it before Friday, i hope that's fine?

I am going to close this ticket as the original request (0.18) is already in main. If you are still getting the issues you were, please open a new issue with the details.


Handle incorrect scheme when accessing via ngrok

When switching between using this example directly on http://localhost:8080 and the same but with ngrok in front https://somethingsomething.ngrok.io then we lose the scheme* and it always assumes HTTP, not HTTPS, because it ignores the HTTP_X_FORWARDED_PROTO for security reasons. For this situation, where we want to support the header, we can use https://github.com/akrabat/rka-scheme-and-host-detection-middleware.
This pull request adds it for the record-a-message building block only, but if we agree this is useful, I'll roll it out for the others (4 or 5 others in the voice folder using Slim are affected I think , it's basically when we need to build a URL in an NCCO).

Actually we also get the wrong port number, but I think that's a Slim bug and have opened an issue/PR with them and am leaving our code as it is for now (see https://github.com/slimphp/Slim/issues/2486)

probably outdated

Yeah, I don't think it's been an issue since the later 3.x builds and doesn't seem to be an issue in 4.x


[$250] Workspace - Workspace list doesn't get updated unless user opens workspace chat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.17-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Prepare two different devices as this issue needs two devices to reproduce
(Device 1) Navigate to staging.new.expensify.com and sign in with a brand new account
(Device 1) Create one new workspace
(Device 1) Go to inbox and open your space chat
(Device 1) Navigate back to workspace list page
(Device 1) Stay on workspace list page
(Device 2) Sign in with the same account as device 1
(Device 2) Navigate to workspace list page
(Device 2) Click on "New workspace" to create a new workspace
(Device 1) while on the workspace list page refresh the page
(Device 1) Observe that the new created workspace doesn't appear on the workspace list
(Device 1) Go to inbox and observe the newly created workspace chat appearing on inbox (But do not open the workspace chat page yet
Go back to workspace list page and observe the new workspace still didn't appear
Go back to inbox and open the workspace chat of the newly created workspace
Go back to the workspace list page

Expected Result:
The newly created workspace appears on the workspace list after it being created
Actual Result:
The newly created workspace does not appear on the workspace list page on device 1 unless user navigates to the newly created workspace chat and opens it and then navigates back to the workspace list page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/e0fc4387-afed-45c1-9e1f-aea64d621177

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0166c8776ce1f2455a
Upwork Job ID:<PHONE_NUMBER>375033485
Last Price Increase: 2024-08-20
Automatic offers:

rayane-djouah | Reviewer | 103648162

Issue OwnerCurrent Issue Owner: @rayane-djouah

Looks like the problem is:
Mac 1 creates an account and creates a workspace and stays on the Settings > Workspaces page
Mac 2 logs into that same account, creates an additional workspace
Mac 1 refreshes and cannot see the workspace immediately
We discourage users from sharing accounts, so I can't see that this is a real use bug, so there's no major urgency here.
@izarutskaya can I please confirm that I must use 2 macs, or is it any 2 devices?

Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace list doesn't get updated if we create the workspace from another device or OD.
What is the root cause of that problem?
When we create the workspace from another device or OD, the policy data doesn't have a role property, but shouldShowPolicy requires the policy to have a role, added in https://github.com/Expensify/App/pull/44836.
https://github.com/Expensify/App/blob/67ad466251078a3b54558a2ed84876ec2fe18608/src/libs/PolicyUtils.ts#L169-L175
What changes do you think we should make in order to solve the problem?

Even though the policy doesn't have a role property, it does have a employeeList which contains the employee list with each of its role. So, we can use that as a fallback, just like we did for isPolicyAdmin.
https://github.com/Expensify/App/blob/67ad466251078a3b54558a2ed84876ec2fe18608/src/libs/PolicyUtils.ts#L186-L187
let currentUserLogin = '';
Onyx.connect({
    key: ONYXKEYS.SESSION,
    callback: (val) => {
        currentUserLogin = val?.email ?? '';
    },
});

(!!policy?.role || !!policy?.employeeList?.[currentUserLogin]?.role)

is it any 2 devices?

@RachCHopkins It's any 2 devices or creating the workspace from OD will cause this issue too. I once commented about this issue here.

Thanks @bernhardoj for the insight!

Thanks for reviewing @rayane-djouah,
@bernhardoj's proposal LGTM!

PR is ready
I cover https://github.com/Expensify/App/issues/44697 in the PR too.
cc: @rayane-djouah

How's the review going @rayane-djouah?

@rayane-djouah I've just paid you. @bernhardoj I will send you an offer shortly!

Scratch that, sorry @bernhardoj I sent you an offer then retracted it, I just realised we pay you via NewDot.
Payment Summary:
Contributor: @bernhardoj to be paid $250 via NewDot Manual Request
Contributor+: @rayane-djouah paid $250 via Upwork
Upwork job here

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

Requested in ND.


Add a parity checker

We need a way to compare two or more output files for parity.  Rather than comparing field values, we are looking to find the difference among keys.  For example, let say we want to find the parity between the following services' output files:

service%3DGetOrderHistory%2FHydra-API%2FExigo-API%26country%3DUS
service%3DGetOrderHistory%2FHydra-API%2FInfoTrax-API%26country%3DTH

Basically, we need to know whether these services return similar data structures and if they differ in what keys they return.  Essentially, the target output structures need to be the same even though their sources are different.

Parity can be found by:

Let A represent a set of all paths in target a's output file. O(n)
Let B represent a set of all paths in target b's output file. O(n)
...
Let N represent a set of all paths in target n's output file. O(n)
Find the (asymmetric) difference between the sets A, B, ..., N. O(n).

Additional references:

https://github.com/Unicity/Chimera/blob/master/classes/Unicity/Config/Helper.php#L73-L114
https://github.com/Unicity/Chimera/blob/master/classes/Unicity/Common/Set.php#L100-L115

Paths are string following dot syntax, where keys are represented as quoted strings (which can be escaped similarly as they would be in a CSV file) and indexes are represented by the wildcard * character.   For example:
"Order"."lines"."items".*."item"."href"


Fix CommonJS/AMD -m --modular flag does not work when providing a 'to directory' rather than 'to file'

The CLI did not provide compiled tags with CommonJS/AMD encapsulation if the compilation was to a directory, the additional code was only affixed in the toFile method.

Coverage increased (+0.16%) to 91.01% when pulling 13c1e31fec0f347faddb59338348cb70b7d6ea57 on qrb:dev into 937fcb37fb3901d3794b33c4087df8600b027ddb on muut:dev.

Could you add also a test to check that nobody will ever destroy your contribute please?

Thanks but I'm going to need some guidance on how this should be tested.
high level:- As a user of the CLI when the modular flag is set and the flow is from (file-file, directory-file, directory-directory), then the contents of the output .js file(s) are surrounded by the commonjs/amd wrapper in each scenario.
Can I unit-test?
If the make method in cli was extracted out to its own class then the internal functions would be public to that class and unit testable. That said I should be able to call make() with the correct arguments to generate the expected output then make assertions against the generated expectation files.
The problem here is any code requiring lib/server/cli.js with commonjs is problematic because it will retain state. the function init() for instance when required will never set opts.flow more than once due to init.called = true. Because this method isn't exported, it returns an opts.flow = '??' with what ever I use first. Unless there is a way around this it means I cant call make() multiple times in a test.
I'm unclear and not sure about the intention of only allowing init() to be executed once.
So I feel I'm left with two options. Refactor more of the cli code (even though I'm unclear about it's intent) Or, setup some behavioural tests using only the cli in bash scripts or batch files?
If there is a logical way around this I'm looking forward to understanding it.
Also I can't find any prior tests for lib/server/cli make method. My desire would be to investigate testing a little further with some feedback on the appropriate approach in this instance and then, if it's unreasonably complicated to test due to the design, then accept this PR so that the --modular functionality works with a dd flow. I'd be happy to submit a new PR with proposed enhancements to lib/server/cli making it more testable.

thanks I need we need some tests for this feature


Remove first back arrow

Describe the bug

On the first screen when the app starts there is an unnecessary back arrow on the bottom on the left that does nothing. The arrow should only be visible starting at the second screen
Smartphone (please complete the following information):

Device: OnePlus 7T Pro
OS: Android 11
App Version: 2.0.2

For the intro I used the library AppIntro, so I can not change anything about that arrow.
But I can try to choose another style for arrows to workaround this issue.
Thanks!

For the intro I used the library AppIntro, so I can not change anything about that arrow.
But I can try to choose another style for arrows to workaround this issue.
Thanks!

I'm sorry, but the only other option is to replace the back button with a "Skip" button. But it makes no sense in my case because you have to agree to the terms before you can continue so you can not skip the AppIntro.
Therefore it will stay like it is now.

I'm sorry, but the only other option is to replace the back button with a "Skip" button. But it makes no sense in my case because you have to agree to the terms before you can continue so you can not skip the AppIntro.
Therefore it will stay like it is now.


[Fixes #7071] Orchard.Users - Users last login time is not correct

[Fixes #7071] Orchard.Users - Users last login time is not correct

Backporting @dcinzona's PR #6441 to close this blocking issue for 1.10.2


Error 0x80070422 when starting Bash on Ubuntu on Windows

lxcore_files.zip

Yep, me too with Debian GNU/Linux.

0x80070422 is service disabled, please make sure the "Lxss Manager" service is not set to disabled.


Update libuv to 1.1.0

Instead of installing the rc2 version of libuv, we should update to the latest 1.1.0 release:
https://github.com/libuv/libuv/releases/tag/v1.1.0
See https://github.com/aspnet/aspnet-docker/pull/22 for a related PR

@lodejard

Let's figure out how to continually incorporate latest libuv bits from here on out.

@moozzyk

#147 - probably we could link statically

We are know at 1.7.3 for Windows and Darwin.


Add Update Status Hook

The update status hook is missing, which caused a problem related to the certificates not being updated.
/cc @claudiubelu

/easycla

@fabi200123, the Lint and Unit tests are failing for this PR.


automated push to prod

We need a way that anyone in our org can use to push docs to the production server. Need to consider that master might be used as a testing branch, so it may not always be suitable for pushing. We could instead use a prod branch or something that is auto-pushed, and we manually push to that when we're ready to deploy stuff. I'm not thrilled by that, but it works. Better ideas?

Other ideas discussed with @jseldess: use docs.cockroachlabs.com and have github pages build it. This would require using CloudFlare because that's the only way (that I'm aware of) to have HTTPS on github pages with a CNAME. @mberhault thoughts? Doesn't have to be for the entire domain (although we may want to do that anyway for the CDN benefits).

So just to make sure we're all clear, currently, we use github to manage our doc files, and I manually sync Jekyll output from my machine to dreamhost. So github and our live docs are completely separate right now.
Matt's suggestion would be to treat our gh-pages branch (the master branch) as our live content, cutting out the need to sync to some other server. Github Pages already uses Jekyll to serves it up at http://cockroachdb.github.io/docs/. We would need to:

Add a CNAME for docs.cockroachlabs.com
Use cloudflare as our cdn, since they'd provide https
Redirect from cockroachlabs.como/docs to docs.cockroachlabs.com

I think this sounds good but am interesting in thoughts from @mberhault, @bdarnell, @spencerkimball. The only downside here is that someone may merge with master and break the live site, not having built with Jekyll locally to validate that the html is fine. This isn't a big danger, though, since others are likely to be working on actual content, not Jekyll stuff.

Github pages places some restrictions on the URL scheme we can use (i.e. it must be a subdomain docs.cockroachlabs.com rather than our current planned URL of cockroachlabs.com/docs). Can we add a cron job on the machine that's serving www to run git pull and rebuild? Or we could set up circleci to build and push (as long as we're comfortable giving CI machines the necessary credentials)

@bdarnell, do you prefer that approach over just going with docs.cockroachlabs.com and using Github? That url is fine, too, but if we change, we'll definitely want to change before beta.

I don't feel strongly about the URL, but I do think that we'll eventually want more flexibility than GH Pages gives us and so we'll need one of the other solutions anyway. I'm fine with doing whatever's easiest for now.

I'm not so sure we need to have an automated pipeline for docs.
Granted, they're changing a lot right now, and having anyone able to push them is nice. However, once we hit beta, I expect docs will be much more strictly versioned, possibly from separate branches that turn into versioned pages on docs.cockroachlabs.com
Now, it would still be nice to push them automatically. We do need to make sure they're not broken though. Does Jekyll catch errors? is it worth putting in circle-ci to validate the generated pages?
Either way, we can end up with a branch that's either pushed to from circle-ci, or manually. From there, we can either have circle-ci generate the pages and copy them over to docs.cockroachlabs.com (would require an ssh key), or have a cron job in docs.cockroachlabs.com pull down the docs and place them in the right directory (would require jekyll and dependencies)

@mberhault, Jekyll doesn't catch errors in the generated html, no, but I've been meaning to look into this html proofer: https://github.com/gjtorikian/html-proofer. Could we run that type of thing with circle ci? Would we want to trigger that whenever a PR is merged with master, or should we use a different branch?

We now use Circle CI to check the html for each docs PR and push the site to aws for review.
Now that that's in place, it'd be interesting to think through a prod deployment step, though I don't think we want to push to the live site on merge given the eventual need to version the docs.

We can easily add a deployment step to circleci for green gh-pages merges. This would just rerun jekyll with baseurl: /docs and rsync to the web server. circleci has a section for ssh keys.
The only question is whether we really want to do this. Let me know.

Good to know, @mberhault. I'm hesitant to do this right now because there might be PRs we want merged but not published. Let's hold off until we know how and when we'll version the docs.

We have a 1-click push to dreamhost via teamcity, thanks to @mjibson.


Use templates sent along with the request.

Templates are compiled by an older service that we can't replace. To use fragments, we'd like to run tailor over the resulting html output before it gets sent back to the client.
So basically we'd send a call to the tailor node server that contains a stringified html.
However... it seems like tailor requires templates to be physical files in your own folders or on a server somewhere else... :/
I'd expect there to be a "template = string" option that we can pass to the request handler.

You can accomplish this by setting the fetchTemplate to a custom function where you retrieve the html from your legacy service.
Let me know if you have any additional questions.
Sent from my iPhone

On Oct 3, 2019, at 9:36 AM, Pixelatex<EMAIL_ADDRESS>wrote:
Templates are compiled by an older service that we can't replace. To use fragments, we'd like to run tailor over the resulting html output before it gets sent back to the client.
So basically we'd send a call to the tailor node server that contains a stringified html.
However... it seems like tailor requires templates to be physical files in your own folders or on a server somewhere else... :/
I'd expect there to be a "template = string" option that we can pass to the request handler.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

let tailor = new Tailor({
    templatesPath: __dirname + '/../templates', // in case you had any local templates
    fetchTemplate: (templatesPath, baseTemplateFn) => {
        // any logic you might have that gets returns a Promise fetching the template
    },
});

Did you solve this @Pixelatex? I'm in a similar position, using fetchTemplate to query the older service to get the HTML. However, it's not possible to pass cookies and headers from fetchTemplate to the response.

@stevoPerisic apologies that I never responded, the fetchTemplate does work indeed
@atkinchris I have no need for passing along cookies and headers like that, I think your implementation may need tweaking to use this


missing search image?

We have a bunch of models all of which have the "search image" in the promote tab, but after making a new model that inherits from both the metadata mixin and wagtail's Page, that field is not showing up in the promote tab - is there a way to manually trigger a "metadata check" pass that ensures there is a migration that adds all the metadata fields that should exist to a model that might be missing one (or more)?

The metadata mixin just adds the fields to the model you are extending.
Do you have an example of the model where the field isn't showing up? One thing to be sure of is to put MetadataPageMixin before Page other wise the Pages promote_panels attribute overrides the mixin not vice versa

Yeah, the model we're using that's not showing an image field is https://github.com/mozilla/foundation.mozilla.org/blob/master/network-api/networkapi/wagtailpages/models.py#L543, which shows this in its promote tab:

An example of a page type that works fine is https://github.com/mozilla/foundation.mozilla.org/blob/master/network-api/networkapi/wagtailpages/models.py#L417 which shows the follow promote tab content:

As far as I can tell, those two models are identical in terms of metadata setup, but while I can find a migration that adds the search image to the PrimaryPage class (https://github.com/mozilla/foundation.mozilla.org/blob/master/network-api/networkapi/wagtailpages/migrations/0039_auto_20181009_1342.py) no amount of manage migrate has added one for the BlogPage class.

It'd be worth checking if the database itself or dropping into a django shell and checking the model to see if it has a search image. It looks like it was added in this migration here, so it should exist. If it doesn't there's a bigger problem here.
It does look like the the BlogPage overrides the promote_panels attribute which is most likely why the field isn't showing up in the admin.
If you change this line to:

promote_panels = FoundationMetadataPageMixin.promote_panels + [
   FieldPanel('tags')
]

That should get you what you want

totally fixed it, thanks so much!


Fix cloud provider name for GCP in default-storage-class addon

What this PR does / why we need it:
The default-storage-class addon was ported from KKP and uses the value "gcp" to determine if the Kubernetes cluster uses the GCP cloud provider. However KubeOne uses "gce" as identifier for the GCP cloud provider and therefore the StorageClass was never rendered when provisioning a Kubernetes cluster with KubeOne on GCP.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Deploy default StorageClass for GCP clusters if the `default-storage-class` addon is enabled

/retest

/cherrypick release/v1.3

/retest


Issue with IPlocation

This module looks amazing, but I get the following error after calling your exact code:
{ Error: ENOENT: no such file or directory, open 'test/GeoIP/IP2LOCATION-LITE-DB5.IPV6.BIN'
errno: -2,
code: 'ENOENT',
syscall: 'open',
path: 'test/GeoIP/IP2LOCATION-LITE-DB5.IPV6.BIN' }

You probably don't have IP2Location BD files. You can download it for free at https://www.ip2location.com/


⚠ ClamAV has degraded performance

In 7721d43, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 70 ms

Resolved: ClamAV performance has improved in 0025718.


RestorePurchases?

I am developing a PurchaseSubscription.
Should I check "State == PurchaseState.Purchased" or "AutoRenewing=true" in RestorePurchases?
but your code ...
var sorted = subs.Where(p => p.ProductId == productIdSub).OrderByDescending(i => i.TransactionDateUtc).ToList();
var recentSub = sorted[0];
if (recentSub != null)
{
//Success
}
Why is RestorePurchases successful when State or AutoRenewing is not checked?

AutoRenewing is just general information, Purchased state is all you need.
You can decide how you want to check and what state it is in.


View output on acquire_terminal

Sometimes I'm executing cargo commands for showing examples for TUI projects such as tachyonfx:
```bash +exec +acquire_terminal
cargo run --manifest-path /home/orhun/gh/tachyonfx/Cargo.toml --example fx-chart
```

This works, but I am unable to see the cargo run output (i.e. build logs) so I sometimes wait on an empty terminal screen for 5-10 seconds which makes the presentation a bit strange to follow.
Would it be possible to also redirect stdout to the previous terminal when acquire_terminal is being used?

wait on an empty terminal screen for 5-10 seconds

I created #375 which should help; rust-script caches dependencies so I imagine most time here is being spent linking and linking in release mode takes a lot longer (maybe use mold if you're not using it to speed this up?).

Would it be possible to also redirect stdout to the previous terminal when acquire_terminal is being used?

The problem with this is if there's an error in your script, presenterm can't capture it so you'll get an "execution failed" message and nothing else. e.g. either I capture stderr (cargo writes to stderr, not stdout) and show you the error message on failure, or I don't capture it and you will see cargo's build logs but then if there's an error I can't show it to you. At best I can add an attribute like +no_capture_stderr that would indicate presenterm desn't capture stderr but if there's an error all you'll get is "execution failed". Would that work?

(maybe use mold if you're not using it to speed this up?).

Good tip, will try!

e.g. either I capture stderr (cargo writes to stderr, not stdout) and show you the error message on failure, or I don't capture it and you will see cargo's build logs but then if there's an error I can't show it to you

Wouldn't it be feasible to capture everything via using something like os_pipe and also redirect it to the terminal at the same time? Not sure if that'd actually work, just throwing an idea.

At best I can add an attribute like +no_capture_stderr that would indicate presenterm desn't capture stderr but if there's an error all you'll get is "execution failed". Would that work?

Yup that'd work - ofc if adding yet another option is not a big issue :)

I can't think of a nice way of solving this unfortunately. Something involving os_pipe would be pretty tricky, because it would need to capture and print stderr but only until the actual program is ran. e.g. you want the stderr that rust-script emits, but not the one that the compiled program emits.
Looking at your presentation, the hello world snippet takes a bit the first time but any subsequent run (even after closing and reopening presenterm) takes about a second. Of course not sure what hardware you're running this on but maybe this should be better now that this is using debug mode? Otherwise the thing you're doing to run cargo run on each snippet should be the way to go. Even if this printed something but took 10 seconds it would be a terrible UX so having things precompiled should be the way to go.

Yeah I see... I'm going to give this a try again, as you have said if I pre-compile the dependencies it shouldn't be a big problem.

Closing this as we can't do much unfortunately. Will re-open if a solution comes up.


Frontend: introduce a new swift_upcoming search path entry

This adds /usr/lib/swift_upcoming to the default search path that follows /usr/lib/swift to allow us to have a staging ground for upcoming features.  Given that upcoming features may be ABI unstable, they are statically linked.  The default behaviour of isolating static and dynamic libraries into /usr/lib/swift and /usr/lib/swift_static and switching that based upon -static-stdlib is important to preserve as the linkage is encoded into the swift module and impacts the code generation on some platforms.  This allows us to include a default search path that may link statically irrespective of how the remainder of the standard library is linked.

@swift-ci please test

Looks good, could you add a test for it somehow?

Not sure about the testing, but seemed to run into an issue with this, so going to wait on this just a bit.

I think I might have found part of the issue (swift-driver), let me see if I can get that fixed first.

I don't believe we should make this change, because the complexity of having separate directories for "upcoming" (i.e., not-ABI-stable-on-Darwin) libraries outweighs the benefits.
For one, the specific change in this pull request doesn't account for the distinction between a dynamically-linked Swift runtime (i.e., what goes into usr/lib/swift) and a statically-linked Swift runtime (i.e., what goes into usr/lib/swift_static, which is used when -static-stdlib is provided to the driver). We can't, for example, have a single static library that works with both the dynamically-linked and statically-linked Swiss runtimes. To split out the "upcoming" directories for static libraries such as those supporting C++ interoperability (Cxx and CxxStdlib), we'd really need two more directories: usr/lib/swift_upcoming and usr/lib/swift_upcoming_static, each of which has a static library for Cxx and CxxStdlib. These libraries would be built differently (one without -static-stdlib, one with, respectively), and the driver or frontend would have to pick the appropriate one based on the absence or presence of -static-stdlib.
At a technical level, we don't need separate directories for "upcoming" libraries (like Cxx and CxxStdlib) vs. libraries that are ABI-stable on Darwin (like the Swift runtime): usr/lib/swift can be a mix of static and dynamic libraries, so long as the static libraries were correctly built without -static-stdlib, and it's fairly common practice to have a mix of static and dynamic libraries in a single 'lib' directory. Then usr/lib/swift_static has all static libraries, all built with -static-stdlib.
At present, we have only declared ABI stability on Darwin, so we can't really say that "upcoming" libraries are the non-ABI-stable ones and non-upcoming libraries are ABI stable.
The only downside I see with keeping the status quo is that mixing static and dynamic libraries in a directory can cause some confusion for Windows developers: it can be hard to tell between an import library for a dynamic library and a static library because both of them have the .lib suffix. In such cases, the shared library (DLL) is in a different directory altogether (the bin directory of the runtime), and that's the real indicator. However, there are approaches for folks that need to programmatically determine this, and most developers shouldn't need to care beyond packaging the right set of DLLs with their Swift app on Windows.
I don't think the extra benefit here amounts to much, and splitting out the "upcoming" directories adds complexity to both the build system and the driver/frontend, so I'd rather not do it.

Thanks for the summary of the conversation @DougGregor!  I'm still a bit biased towards the split because it makes the lives of the developer a bit easier.  But I do think that I have a solution for the confusion caused by the static and import libraries.  That basically just leaves the small bit of confusion of non-static-stdlib implying static linking to the standard library, but I suppose that is a tradeoff for simplicity.


Update Customization.md

Fixed link to GDPR-Activity-Hub-Workflows.xml

@panjkov,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Thank you Dragan!
Good catch!

You're welcome :)


chore(dep): bump aws-sdk [WIP]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Let's work together on this branch to bump aws-sdk version.
cc @MrCroxx please help resolve the "native-tls" issues. thx 🥹

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

replaced by #13286


Backend Initial project setup

Setup backend project files and readme

Started working on the template but I need to add .gitignore because there are a lot of unnecessary Items that could be added

@PrinceJK ok you can work on it

Ok. I raised a PR just now


BUG: Leaked task detection triggers for cancelled tasks

Leaked tasks detection shouldn't trigger if a task is cancelled.

https://github.com/facebook/TestSlide/pull/263/files
I bet it requires a 1 line change to change "not done" tasks to "any active tasks", which should exclude cancelled.

https://github.com/facebook/TestSlide/pull/263/files
I bet it requires a 1 line change to change "not done" tasks to "any active tasks", which should exclude cancelled.

@deathowl Check if #278 is the same scenario you spotted.

@deathowl Check if #278 is the same scenario you spotted.


AspNetCore.WsFederation get signin-wsfed redirect to HTTP when original request is HTTPS

Describe the bug
An aspnetcore 2.1 website hosted in a Docker container on port HTTP, along with the use of an nginx reverse proxy exposing HTTPS 443 only.
The website is accessed from the outside on HTTPS, it redirects to an STS website on HTTPS, which redirects to the /signin-wsfed on HTTPS.
However, the response location from the /signin-wsfed is HTTP.
Expected behavior
The response location is preserved as HTTPS, considering the request POST URL is.
Additional context
Here is the request:
POST https://core-mydocker.####/signin-wsfed HTTP/1.1
Accept: image/gif, image/jpeg, image/pjpeg, application/x-ms-application, application/xaml+xml, application/x-ms-xbap, */*
Referer: https://sts-mydocker.####/Pages/Email/Default.aspx?wtrealm=https%3a%2f%2fcore-mydocker.####%2f&wa=wsignin1.0&wreply=https%3a%2f%2fcore-mydocker.####%2fsignin-wsfed&wctx=#####
Accept-Language: fr-FR,fr;q=0.8,en-GB;q=0.6,en;q=0.4,ja;q=0.2
User-Agent: Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.2; WOW64; Trident/7.0)
Content-Type: application/x-www-form-urlencoded
Accept-Encoding: gzip, deflate
Host: core-mydocker.####
Content-Length: 10612
Connection: Keep-Alive
Cache-Control: no-cache

and the response:
HTTP/1.1 302 Found
Server: nginx/1.12.2
Date: Thu, 21 Feb 2019 09:39:34 GMT
Content-Length: 0
Connection: keep-alive
Cache-Control: no-cache
Pragma: no-cache
Expires: Thu, 01 Jan 1970 00:00:00 GMT
Location: http://core-mydocker.####/Authenticate
Set-Cookie: .AspNetCore.Correlation.WsFederation.######=; expires=Thu, 01 Jan 1970 00:00:00 GMT; path=/; HTTPOnly; Securesignin-wsfed; httponly
Set-Cookie: FedAuth=#######=/; HTTPOnly; Secure; httponly
Access-Control-Allow-Credentials: true
Access-Control-Allow-Origin: https://mydocker.####

HTTP being inacessible from the outside, this provokes an error.
Note: Tested as well on aspnetcore 2.2.2, same issue.

Did you setup nginx to forward the original protocol, and configure your application to understand that?

Hi @blowdart
Yes indeed the nginx configuration has been set:
proxy_set_header		X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header		X-Forwarded-Proto $scheme;

Also, the ASPNET .net core configuration has been performed using the documentation you mentionned.

Hi @blowdart,
Thanks for pointing in the right direction.
I found the solution to my problem on stack overflow
Happens that by default, the KnownNetworks collection only processes <IP_ADDRESS>. In a Docker environment where each container is on a separate IP, that's bound to be incorrect.
As suggested by the validated answer, changing the code to the below, fixed the problem:
var forwardingOptions = new ForwardedHeadersOptions()
{
    ForwardedHeaders = ForwardedHeaders.XForwardedFor | ForwardedHeaders.XForwardedProto
};
forwardingOptions.KnownNetworks.Clear(); //its loopback by default
forwardingOptions.KnownProxies.Clear();
app.UseForwardedHeaders(forwardingOptions);


Feature request - allow to return a file as the API response

Summary
Allow to return a file as the API response.
Motivation
At the moment there is no way to return a file (for example a 1x1 tracking pixel).

A workaround is a redirect call at the end of the action, e.g.
redirect_to "https://example.com/abc.gif"

Glad you were able to figure out a workaround.
Sure be able to render a file with render file:. The jets internal public_controller.rb uses this.
Note, binary images are a little tricky since it depends on the client sending specific accept headers, here's a discussion: https://forums.aws.amazon.com/thread.jspa?threadID=246629  Probably better to serve the image out of s3 anyway. Unsure, how to do something like a tracking pixel though.

Yeah, initially I tried to replicate the way images are served from the public dir and actually I found the public controller - I tried many different scenarios, but nothing worked.


Added Inconsolata font and adjusted code folding arrow size.

Fixes the following issues

Large code collapse arrows - https://github.com/mozilla/thimble.webmaker.org/issues/1143
Using crappy fonts - https://github.com/mozilla/thimble.webmaker.org/issues/1158

Please wait til I'm back to do this. The font stuff is tricky the way Brackets does it, spread across less, JS, and extension files. I'd like to be involved if possible.
On Sep 29, 2015 1:21 PM, Luke Pacholski<EMAIL_ADDRESS>wrote:
Fixes the following issues

Large code collapse arrows - mozilla/thimble.webmaker.org#1143https://github.com/mozilla/thimble.webmaker.org/issues/1143
Using crappy fonts - mozilla/thimble.webmaker.org#1158https://github.com/mozilla/thimble.webmaker.org/issues/1158

You can view, comment on, or merge this pull request online at:
https://github.com/humphd/brackets/pull/473
Commit Summary

Added Inconsolata font and adjusted code folding arrow size.

File Changes

M src/index.htmlhttps://github.com/humphd/brackets/pull/473/files#diff-0 (12)
M src/styles/bramble_overrides.csshttps://github.com/humphd/brackets/pull/473/files#diff-1 (6)

Patch Links:

https://github.com/humphd/brackets/pull/473.patch
https://github.com/humphd/brackets/pull/473.diff

—
Reply to this email directly or view it on GitHubhttps://github.com/humphd/brackets/pull/473.

Closing this in favour of https://github.com/humphd/brackets/pull/475


requestBody in POST method does not conform to OpenApiV3 spec

In the:
"post": {
...
}

With Javalin 4 I have:
        "requestBody": {
          "description": "Empty JSON",
          "content": {
            "application/json": {
              "schema": {
                "$ref": "#/components/schemas/Unit"
              }
            }
          }
        },

With Javalin 5 + OpenApi plugin I get:
        "requestBody": {
          "description": "Empty JSON",
          "content": {
            "application/json": {
              "schema": {
                "type": "application/json"
              }
            }
          },
          "required": false
        },

Later on I can't parse this JSON with OpenAPIV3 parser.
Some corresponding defintions from OpenAPIV3 parser (in Typescript):
    // this one correspond to the whole object under "post"
    export type OperationObject<T extends {} = {}> = Modify<OpenAPIV3.OperationObject<T>, {
        parameters?: (ReferenceObject | ParameterObject)[];
        requestBody?: ReferenceObject | RequestBodyObject; // <<< THIS IS "requestBody"
        responses?: ResponsesObject;
        callbacks?: Record<string, ReferenceObject | CallbackObject>;
        servers?: ServerObject[];
    }> & T;

    export type RequestBodyObject = Modify<OpenAPIV3.RequestBodyObject, {
        content: {
            [media: string]: MediaTypeObject;
        };
    }>;

   // This one is the one which previous one is based on
    interface RequestBodyObject {
        description?: string;
        content: {
            [media: string]: MediaTypeObject;
        };
        required?: boolean;
    }

    interface MediaTypeObject {
        schema?: ReferenceObject | SchemaObject;
        example?: any;
        examples?: {
            [media: string]: ReferenceObject | ExampleObject;
        };
        encoding?: {
            [media: string]: EncodingObject;
        };
    }

    type SchemaObject = ArraySchemaObject | NonArraySchemaObject;

    interface ArraySchemaObject extends BaseSchemaObject {
        type: ArraySchemaObjectType;
        items: ReferenceObject | SchemaObject;
    }

    interface NonArraySchemaObject extends BaseSchemaObject {
        type?: NonArraySchemaObjectType;
    }

    type NonArraySchemaObjectType = 'boolean' | 'object' | 'number' | 'string' | 'integer';
    type ArraySchemaObjectType = 'array';

So in here:
            "application/json": {
              "schema": {
                "type": "application/json"
              }
            }

"type" cannot be "application/json", it may be absent, if you generate NonArraySchemaObject or be one of listed in the NonArraySchemaObjectType, or it must be array if you generate ArraySchemaObject.
As you can see, in Javalin 4, for empty body it was generating ReferenceObject and mapped type to specially added type Unit.
This may be not ideal, but far more correct than what new plugin does now. Please fix this.

Output from Javalin 4 also doesn't seem to be correct, it's basically covered by Kotlin's Unit type, so scheme might be correct, but it doesn't make any sense semantically. Could you share your requestBody definition from sources?

  requestBody = OpenApiRequestBody([OpenApiContent(type = "application/json")], description = "Empty JSON"),

Output from Javalin 4 also doesn't seem to be correct, it's basically covered by Kotlin's Unit type, so scheme might be correct, but it doesn't make any sense semantically. Could you share your requestBody definition from sources?

As I said it is not a best solution, but still - schema is correct, and that's very important.

Ok, I know why it happens, we use the same method to generate scheme for reuqestBody and responses. Such format is valid for responses, but not for requestBody. Kinda strange, but I'll just remove simple types from resutedBody so it'll contain scheme with reference or it'll be just empty.

Please also add a unit test for this. If don't have unit tests at all, it's good time to start writing them at least for something...

I'm maintaining several projects and I don't have enough time to address this issue at this moment:

https://github.com/javalin/javalin-openapi/issues/74

Unit tests would protect us from regression, but not from this kind of issue that are simplify a misunderstanding of specification. It's also good to note that current schema is already processed by Swagger Validator, but we simply miss all combinations of properties in JavalinTest.class.

Yes, that's exactly the point, users, including me, want to be protected from regressions. We use your library in our software and deliver our software to our important customers, and so want to be sure we depend on the more-less reliable software, as long as you are in active development, and your code is refactored often, and so there is higher chance to break something.

Both usages:
@OpenApiContent(type = "application/json")
@OpenApiContent(mimeType = "application/json"),

are now generated with empty body:

To be fair such usage was not intended, it's more likely a side-effect of the old OpenApi plugin, but it's not harmful so we can support this in such form.

Thank you!


State Of Branches - Updates and Unverified Commits

Question.  I want to update my branch with the latest version of the master branch. In investigating / comparing  commits -- I see  that some commits have been verified and several that have not been verified.
Is it wise to merge unverified commits to my branch ? What does verified mean really ? Who or whom are the verificators - Are there official Yetinauts ?
...
Possible Solution

...
Checklist

[x] I have read and follow the CONTRIBUTING.md document.
[x] here are no other issues similar to this one.
[x] The issue title and template are correctly filled.

Hi @blynnc,
The verified means only that these were digitally signed using PGP. Either by GitHub when the website is used or by the user when Git is configured to sign every commit.
See https://git-scm.com/book/en/v2/Git-Tools-Signing-Your-Work and https://help.github.com/en/articles/signing-commits
We do not enforce or check this.
Please also use the develop branch as this is our default (master) branch.

It makes not much difference and you can safely pull all commits.
It just prevents impersonification and additional security in some context and when everyone signs their commits (manipulated commits by others would be visible when the used signing key or verified status would change).

Closing as resolved. If your questions are not answered, please let us know.


Add stream_options property to get token usage.

Added the ability to receive token usage based on this object in the OpenAI documentation:
https://platform.openai.com/docs/api-reference/chat/streaming
Added an optional parameter called streamOptions to the createStream  interface which passes the aforementioned body parameter to the chat endpoint which enables receiving the optional usage statistics.
Added tests as well which succeeded during my tests. Some of the new tests might be considered unnecessary and I will be happy to change them if necessary.
Unrelated to the changes I made - I will note the following expects failed so I commented them out during my testing - they don't seem related my code changes:
    expect(streamEvent.choices.first.delta.content,
          isA<List<OpenAIChatCompletionChoiceMessageContentItemModel>?>());
      expect(streamEvent.choices.first.delta.content?.first?.text,
          isA<String?>());

Kept getting bad state: no element - presumably because we are using the .first getter here.
Thanks!
This PR is a solution to this issue: https://github.com/anasfik/openai/issues/155#issuecomment-2155470264

Good job, look for this feature too, and I think this PR is what I want.
When will this be merged and released?

Yeah no response from the maintainer so far so not sure what to do.


Please Teach BLT about IntelLLVM so things like blt_append_custom_compiler_flag have a shot of working

LC module named intel/oneapi.2021.2


chore: testnet configs

Adds sepoliaBase and fuji testnet options for deployment
Adds hardhat-etherscan for contract verification

Closing this one since preference is using Foundry for deployments instead of Hardhat.


Using OpenMetadata for Qlik Cloud

Feature
Using OpenMetadata for Qlik Cloud
Describe the task
I just want to know if there are plans to integrate Qlik Cloud into the native OpenMetadata connectors? No problem for Qlik Sense, the doc is perfect, but I can't find anything regarding Qlik Cloud...

Hi @pmbrull is this still available?

hi @Xceptions, assigned! Thanks for the help

Hi @pmbrull , apologies for the mix up. I was misled into thinking that the project was in python, only to find out it is in Java. I really apologize for this mix up. Kindly unassign

hi @Xceptions, main piece of work for the connectors is in Python. You can see an example PR developing a connector here https://github.com/open-metadata/OpenMetadata/pull/13128

thank you. Will look into it!

We are currently working on qlik cloud connector.