CFE produces the following error in flutter code when constant_update_2018 flag is turned on

Turning on constant_update_2018 flag and running flutter tests produces the following error:
Compiler message:
file:///usr/local/google/home/asiva/workspace/flutter-roll/flutter/packages/flut
ter/lib/src/painting/flutter_logo.dart:56:26: Error: Binary operator '=='
requires receiver constant 'FlutterLogoStyle {index: 0, #lib1::_name:
"FlutterLogoStyle.markOnly"}' of type 'Null', 'bool', 'int', 'double', or
'String', but was of type 'FlutterLogoStyle'.
 - 'FlutterLogoStyle' is from 'package:flutter/src/painting/flutter_logo.dart'
 ('file:///usr/local/google/home/asiva/workspace/flutter-roll/flutter/packages/f
 lutter/lib/src/painting/flutter_logo.dart').
       _position = style == FlutterLogoStyle.markOnly ? 0.0 : style ==
       FlutterLogoStyle.horizontal ? 1.0 : -1.0, // ignore:
       CONST_EVAL_TYPE_BOOL_NUM_STRING

The relevant code is as follows:
import 'dart:math' as math;
import 'dart:typed_data';
import 'dart:ui' as ui show Gradient, TextBox, lerpDouble;

import 'package:flutter/foundation.dart';

import 'alignment.dart';
import 'basic_types.dart';
import 'box_fit.dart';
import 'decoration.dart';
import 'edge_insets.dart';
import 'image_provider.dart';
import 'text_painter.dart';
import 'text_span.dart';
import 'text_style.dart';

/// Possible ways to draw Flutter's logo.
enum FlutterLogoStyle {
  /// Show only Flutter's logo, not the "Flutter" label.
  ///
  /// This is the default behavior for [FlutterLogoDecoration] objects.
  markOnly,

  /// Show Flutter's logo on the left, and the "Flutter" label to its right.
  horizontal,

  /// Show Flutter's logo above the "Flutter" label.
  stacked,
}

/// An immutable description of how to paint Flutter's logo.
class FlutterLogoDecoration extends Decoration {
  /// Creates a decoration that knows how to paint Flutter's logo.
  ///
  /// The [lightColor] and [darkColor] are used to fill the logo. The [style]
  /// controls whether and where to draw the "Flutter" label. If one is shown,
  /// the [textColor] controls the color of the label.
  ///
  /// The [lightColor], [darkColor], [textColor], [style], and [margin]
  /// arguments must not be null.
  const FlutterLogoDecoration({
    this.lightColor = const Color(0xFF42A5F5), // Colors.blue[400]
    this.darkColor = const Color(0xFF0D47A1), // Colors.blue[900]
    this.textColor = const Color(0xFF616161),
    this.style = FlutterLogoStyle.markOnly,
    this.margin = EdgeInsets.zero,
  }) : assert(lightColor != null),
       assert(darkColor != null),
       assert(textColor != null),
       assert(style != null),
       assert(margin != null),
       _position = style == FlutterLogoStyle.markOnly ? 0.0 : style == FlutterLo
goStyle.horizontal ? 1.0 : -1.0, // ignore: CONST_EVAL_TYPE_BOOL_NUM_STRING
       // (see https://github.com/dart-lang/sdk/issues/26980 for details about t
hat ignore statement)
       _opacity = 1.0;

  const FlutterLogoDecoration._(this.lightColor, this.darkColor, this.textColor,
 this.style, this.margin, this._position, this._opacity);
 ................
 ................
   /// Whether and where to draw the "Flutter" text. By default, only the logo
  /// itself is drawn.
  // This property isn't actually used when painting. It's only really used to
  // set the internal _position property.
  final FlutterLogoStyle style;
  ..................
  ..................
}

Was able to reduce the test as follows
/// Possible ways to draw Flutter's logo.
enum FlutterLogoStyle {
  /// Show only Flutter's logo, not the "Flutter" label.
  ///
  /// This is the default behavior for [FlutterLogoDecoration] objects.
  markOnly,

  /// Show Flutter's logo on the left, and the "Flutter" label to its right.
  horizontal,

  /// Show Flutter's logo above the "Flutter" label.
  stacked,
}

class FlutterLogoDecoration {
  const FlutterLogoDecoration(
    { this.style = FlutterLogoStyle.markOnly }
  ) : assert (style != null),
      _position = style == FlutterLogoStyle.markOnly ? 0.0 : style == FlutterLog
oStyle.horizontal ? 1.0 : -1.0, // ignore: CONST_EVAL_TYPE_BOOL_NUM_STRING
      _opacity = 1.0;

  final double _opacity;
  final double _position;
  final FlutterLogoStyle style;
}

main() {
  const FlutterLogoDecoration config = FlutterLogoDecoration();
  print(config);
}

This produces the following error when constant__update_2018 flag  is used
file:///tmp/junk1.dart:19:25: Error: Binary operator '==' requires receiver constant 'FlutterLogoStyle {index: 0, #lib1::_name: "FlutterLogoStyle.markOnly"}' of type 'Null', 'bool', 'int', 'double', or 'String', but was of type 'FlutterLogoStyle'.
 - 'FlutterLogoStyle' is from 'file:///tmp/junk1.dart'.
      _position = style == FlutterLogoStyle.markOnly ? 0.0 : style == FlutterLogoStyle.horizontal ? 1.0 : -1.0, // ignore: CONST_EVAL_TYPE_BOOL_NUM_STRING
                        ^
file:///tmp/junk1.dart:28:31: Context: While analyzing:
  const FlutterLogoDecoration config = FlutterLogoDecoration();
                              ^
file:///tmp/junk1.dart:19:25: Error: Binary operator '==' requires receiver constant 'FlutterLogoStyle {index: 0, #lib1::_name: "FlutterLogoStyle.markOnly"}' of type 'Null', 'bool', 'int', 'double', or 'String', but was of type 'FlutterLogoStyle'.
 - 'FlutterLogoStyle' is from 'file:///tmp/junk1.dart'.
      _position = style == FlutterLogoStyle.markOnly ? 0.0 : style == FlutterLogoStyle.horizontal ? 1.0 : -1.0, // ignore: CONST_EVAL_TYPE_BOOL_NUM_STRING
                        ^

Without the flag it runs fine:
sivalinuxmach[sdk]>out/DebugX64/dart /tmp/junk1.dart
Instance of 'FlutterLogoDecoration'

This is invalid code, that's why the analyzer is told to shut up with // ignore: CONST_EVAL_TYPE_BOOL_NUM_STRING.
The error message we give seems kind of cryptic, but the important part is that the spec requires "receiver ... of type 'Null', 'bool', 'int', 'double', or 'String', but was of type 'FlutterLogoStyle'".
If we had a spec change, it would be easy enough to change the constant evaluator.
/cc @lrhn

This is really a duplicate of https://github.com/dart-lang/sdk/issues/26980.

The front-end constant evaluator fixes a bug in the VM (that it accepted this code).  Flutter will see it as a regression because the Dart platform they were using previously allowed this code.  This is despite the fact that it was knowingly exploiting a VM bug.
I'm not sure how we want to proceed from here.  The workaround in Flutter code is to use identical instead of operator==.
I talked to @lrhn and we're not going to get a spec update for this issue for Dart 2.3.
We could provide a flag that the VM target could use to instruct us to be bug compatible with the previous behavior, and allow this comparison.  I'd like to do that as a very last resort and try to fix Flutter first.

FYI, some related bugs:

#36511 (independent discovery of the same issue with a PR that wasn't landed)
#36528 (the bug wherein the VM erroneously accepted this code)

@a-siva I see that your pull request was merged, is it OK to close this issue now?

Flutter code has been fixed.


Please apply security updates to public.ecr.aws/lambda/dotnet:6

Hi there,
We are using public.ecr.aws/lambda/dotnet:6 and pushing our images to an ECR that we scan for vulnerabilities using Snyk.  A number of "High" issues are being raised that appear to have been addressed in Amazon security updates, yet there is no sign of a new release of lambda/dotnet:6 - can you rev the image please?
https://security.snyk.io/vuln/SNYK-AMZN2-GLIBC-6745196
https://security.snyk.io/vuln/SNYK-AMZN2-GLIBCALLLANGPACKS-6745289
https://security.snyk.io/vuln/SNYK-AMZN2-GLIBCCOMMON-6745132
https://security.snyk.io/vuln/SNYK-AMZN2-GLIBCMINIMALLANGPACK-6745170
https://security.snyk.io/vuln/SNYK-AMZN2-LIBCRYPT-6745245
https://security.snyk.io/vuln/SNYK-AMZN2-GLIB2-6663608
https://security.snyk.io/vuln/SNYK-AMZN2-LIBNGHTTP2-6745071
Sincerely
Pete

.NET 6 has reached EOL status, and the Lambda team has already marked this runtime as EOL.
I would recommend resolving this as wontfix. In the interim, anybody relying on .NET 6, I would not hold my breath if I were you.


Use of InitBloc function rather than a Bloc Provider

In the following line:
https://github.com/brianegan/flutter_architecture_samples/blob/c3b66660faadfa848a1f7447221854fcd65bc2c3/example/bloc_flutter/lib/widgets/todo_list.dart#L46
the bloc is instantiated via a function that is passed to the stateful todo DetailScreen. This works fine however I am wonder why was a TodoBlocProvider class within DetailScreen was not used instead? We could get the dependencies through the Injector class the same way... but instead would have a nice provider that we could call from nested widgets off of the detail screen, correct?
This part confused me so I am wondering if there is any benefit in this method vs using a "nested" provider. Is this method of bloc instantiation preferred when no child widgets will require the bloc?
Furthermore, it appears that these Blocs are created per "screen", is that the typical approach?
Thanks for the library/help.

This article helped answer my questions for future people who come across this issue: https://www.didierboelens.com/2018/12/reactive-programming---streams---bloc---practical-use-cases/


Adding filename + path to identify location

I simply wanted to see the source of a component output. This shows the full path of the file its generated from. Might help to identify in more complex scenarios.

Feature Sponsored by
If you like this change, feel free to review and accept this PR ;)
This feature/PR is sponsored by the company I work: Garaio AG

Released in v3.1.0


Dec 20 22 bug fixes

:tada: This PR is included in version 1.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support for plugin dependencies

In a parent I have a plugin (arch-unit) which has a plugin dependency on a rule set that itself is a module in the pom (so listed in the modules section).
Maven itself recognizes that after the parent, it should first build the module that is used as a plugin-dependency, so that it is available for other modules.
Nx-maven however does not see this dependency. It does not create dependencies in the graph and therefore it sometimes builds/tests a project that has a dependency on another for execution it's plugin, but that project has not been built yet.
Is this a known issue?

@PieterVanEde
I know this case based on jnxplus-examples: https://github.com/khalilou88/jnxplus-examples/blob/main/nx-maven/pom.xml
It's not covered by nx-maven because it will create a circular dependency if the parent project is also the aggregator project.
You can use implicitDependencies to link this project to your parent project.
I will add this feature and in this case we need to separate aggregator project from parent project. Maybe I will add a flag to not break other projects: SkipPluginDependencies!

Would be great indeed to support this. It is indeed possible to create circular dependencies, but that would only happen if a vanilla mvn build would also fail I guess.

Would it also be possible to backport this to the 0.x version range? I'm unfortunately in a project still stuck at NX 18 at the moment, but I would really be happy to use this functionality. Given the number of projects, it would be a chore (and fragile) to depend on developers manually adding the correct implicitDependencies

@PieterVanEde OK

That's great! Out of curiosity, what is the expected timeline when you expect this functionality to arrive in nx-maven?

That's great! Will it also look in the plugin(management) section of the parent?

For pluginManagement  I need an example. I am using jnxplus-examples for cases

No problem, very valid request. I've raised a PR for an example where a dependency is specified in the pluginManagement section: https://github.com/khalilou88/jnxplus-examples/pull/308

@PieterVanEde
You can test the version 1.13.0-next.0

@PieterVanEde
I published also version 0.50.0-next.0 for NX 18.3.5

I will perform a test right away!

This now works almost correctly.
What works correctly:

a dependency is created from the parent pom to the project holding the plugin dependency
this is created as a circular dependency like you predicted

What I find strange:

Maven itself does not create a circular dependency, because I have implemented a (hack, I admit) from https://stackoverflow.com/questions/12924634/define-maven-plugins-in-parent-pom-but-only-invoke-plugins-in-child-projects. This hack allows me to specify the desired configuration and execution in the pluginManagement section of my root pom.xml, but in the plugins section to erase the phase. Net result: in the parent pom the plugin is not executed, and in all children the plugin is executed.

Code is perhaps clearer:
<build>
    <pluginManagement>
        <plugins>
            <plugin>
                <!-- Main declaration and configuration of the plugin -->
                <!-- Will be inherited by children -->
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-checkstyle-plugin</artifactId>
                <version>2.9.1</version>
                <executions>
                    <execution>
                        <!--This must be named-->
                        <id>checkstyle</id>
                        <phase>compile</phase>
                        <goals>
                            <goal>check</goal>
                        </goals>
                    </execution>
                </executions>
                <!-- You may also use per-execution configuration block -->
                <configuration...>
            </plugin>
        </plugins>
    </pluginManagement>
    <plugins>
        <plugin>
            <!-- This declaration makes sure children get plugin in their lifecycle -->
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-checkstyle-plugin</artifactId>
            <!-- Configuration won't be propagated to children -->
            <inherited>false</inherited>
            <executions>
                <execution>
                    <!--This matches and thus overrides execution defined above -->
                    <id>checkstyle</id>
                    <!-- Unbind from lifecycle for this POM -->
                    <phase>none</phase>
                </execution>
            </executions>
        </plugin>
    </plugins>
</build>

This would mean that you have to reason over the effective pom and disregard a plugin if it is not bound to a phase. I don't know how feasible that is.
Alternatively I could seperate my module specification and my plugin/dependency specification in two layered parent poms, but I would rather not do that.

I added more code to https://github.com/khalilou88/nx-maven-examples.
Run nx graph to understand the architecture

@PieterVanEde I published version 0.50.0 for NX 18.3.5 and 1.13.0 for NX 20.

Great, thanks a lot!

Sorry to get back to this, I just had some sime to also review the code. I see the current implementation (if I don't misread the code) only looks at plugin dependencies specified in pluginDependencies. However, I think this is a little too narrow approach. I'll try to file a PR that also looks at regular plugin dependencies.

And there I did misread the code, your implementation really is sound.


feat(clerk-js,types): Add appearance keys for organization components

Type of change

[ ] 🐛 Bug fix
[x] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[x] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[x] @clerk/types
[ ] @clerk/themes
[ ] @clerk/clerk-expo
[ ] @clerk/backend-core
[ ] @clerk/clerk-sdk-node
[ ] @clerk/edge
[ ] build/tooling/chore

Description

[x] npm test runs as expected.
[x] npm run build runs as expected.

@desiprisg Is this to be reviewed? If yes, let's fix the conflicts before that.

Rebased. Let's review this.


Investigate Kubeflow on Minikube and document the installation if feasible

In issue https://github.com/kubeflow/website/issues/1662, we removed the guide for running Kubeflow on Minikube. The reasons were that the way we'd documented the deployment of Kubeflow on Minikube was no longer feasible, and we'd had no success in creating a new guide.
The original guide to Minikube still exists in the Kubeflow v0.7 docs, but was not working even at that time.
This new issue tracks work to investigate ways of deploying Kubeflow on Minikube and testing the deployment by means of a hello world ML task.
Furthermore, we'd like an indication of how we can ensure that the doc is kept up to date going forward, by continuous or consistent testing against the latest Kubeflow release.

/assign @janeman98
@janeman98 I'm assigning this to you with thanks :) as you've already started this work in PR https://github.com/kubeflow/website/pull/1743

@sarahmaddox
PR #1743 include the instruction for installation of minikube, Kubeflow 1.0, compilation of  a pipeline sample (sequential.py), upload of  compiled pipeline application,  and execution of such application in the Kubeflow central dashboard. Will that be good enough to test the deployment is good?

@abhi-g Please would you give your take on this question?

PR #1743 include the instruction for installation of minikube, Kubeflow 1.0, compilation of a pipeline sample (sequential.py), upload of compiled pipeline application, and execution of such application in the Kubeflow central dashboard. Will that be good enough to test the deployment is good?

@janeman98 In general, compilation of a pipeline sample, upload and execution should be a good test for the deployment. Unfortunately sequential.py Pipeline is not a good pipeline to test KF functionality because it doesn't invoke any of the ml operations. It simply downloads a file from GCS and prints it to the logs.
I think when I mentioned mnist example, I meant this notebook: https://github.com/kubeflow/examples/blob/master/mnist/mnist_vanilla_k8s.ipynb which you can try running onto your minikube kubeflow.

@abhi-g
Thanks for the notebook url. When I run the notebook, I am hitting problems here and there and I will document the solutions/workaround on the side.  I do have a question: I am hitting following problem while running this notebook,
FileNotFoundError: [Errno 2] No such file or directory: '/var/run/secrets/kubernetes.io/serviceaccount/namespace'
Which pod is I should look into?
notebook-controller-deployment-7db57b9ccf-vw9vw
jupyter-web-app-deployment-89789fd5-cjkwf
or other??

See PR #1743.

We can close this one now!
On Sun, 29 Mar 2020, 12:07 Jane Man<EMAIL_ADDRESS>wrote:

See PR #1743 https://github.com/kubeflow/website/pull/1743.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/website/issues/1751#issuecomment-605541423,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABO2TC5LXWJVXR2DN25VUF3RJ2NOFANCNFSM4K5DCXYA
.

Thanks @sarahmaddox and @abhi-g !


Add sphinx autobuild

Resolves #87.

Could you check if the problem with the released version is still present?

I replaced the gh-link in the requirements with the current version of sphinx-autobuild, because the option --open-browser is now included.


xrepo install brew::llvm fails on Linux

Xmake Version
2.8.2
Operating System Version and Architecture
Ubuntu 22.04.3 LTS
Describe Bug
Invoking xrepo install brew::llvm on Linux fails.
However, the same command did work when I tested it on my macOS machine.
Expected Behavior
The command should succeed (on all platforms where Homebrew is supported).
Project Configuration
No project configuration.
Additional Information and Error Logs
The logs just show the following:
fetch brew::llvm-latest failed!

I moved the issue to the main xmake repo.


Jax throws internal XLA error for sufficiently large batched outer product on GPU

Code:
import jax.numpy as jnp

A = jnp.ones((4, 1024*1024, 1))
B = jnp.ones((4, 1024*1024, 1))

tot = 0
def f(A, B):
  return  A[:,:,None,:] * B[:,None, :, :]
f(A, B)

throws
/usr/local/lib/python3.6/dist-packages/jax/interpreters/xla.py in _execute_compiled_primitive(prim, compiled, result_handler, *args)
    355   device, = compiled.local_devices()
    356   input_bufs = list(it.chain.from_iterable(device_put(x, device) for x in args if x is not token))
--> 357   out_bufs = compiled.execute(input_bufs)
    358   check_special(prim, out_bufs)
    359   return result_handler(*out_bufs)

RuntimeError: Resource exhausted: Out of memory while trying to allocate<PHONE_NUMBER>104 bytes.: while running replica 0 and partition 0 of a replicated computation (other replicas may have failed as well).

Using GPU runtime
https://colab.research.google.com/drive/11MPml8hIU9aeIfuTn8ns7GitYffRjsGv?authuser=2#scrollTo=tjDEbMizZdg_
If you decrease the size it doesn't throw this error, so it may be simply a bad error.
@mattjj

That isn't an internal error, it's a user-facing error, although perhaps it could be worded better.
Your program requires a lot of memory, in particular it would require at least<PHONE_NUMBER>0241024*4 bytes = 16TiB for its output, and you most likely do not have 16TiB of GPU memory. The particular allocation quantity in the error message is probably for one of the intermediate values, which is why it is only 4TiB.
If you have suggestions on how to make the error clearer, we'd welcome them. But this is otherwise working as intended.
(I guess the part of the error about replicated computations is irrelevant to this particular error; we should probably fix that.)

I updated the error a little bit in the PR linked above. When deployed as part of a jaxlib, the error will be:
RuntimeError: Resource exhausted: Out of memory while trying to allocate<PHONE_NUMBER>104 bytes.

which seems pretty self-explanatory to me!
Closing, but feel free to suggest further improvements.

Wait, sorry, I copied the wrong error.
This is the actual error I get.
/usr/local/lib/python3.6/dist-packages/jax/interpreters/xla.py in backend_compile(backend, built_c, options)
    350   # we use a separate function call to ensure that XLA compilation appears
    351   # separately in Python profiling results
--> 352   return backend.compile(built_c, compile_options=options)
    353
    354 def _execute_compiled_primitive(prim, compiled, result_handler, *args):

RuntimeError: Internal: RET_CHECK failure (external/org_tensorflow/tensorflow/compiler/xla/service/gpu/gpu_compiler.cc:698) !llvm::verifyModule(*llvm_module, &err_stream) Invalid LLVM IR before optimizations:
Range must not be empty!
!2 = !{i32 0, i32 0}

This probably indicates a bug in the HLO -> LLVM IR lowering. Rerun with --xla_dump_to to get the IR and looks for files with name containing: *module_0000.*

I agree, that's a bad error. I filed a bug with the XLA folks.

With a jaxlib built including #5787, we now get:
RuntimeError: Unimplemented: Kernel launch needs more blocks<PHONE_NUMBER>) than allowed by hardware<PHONE_NUMBER>).

which is a slightly better error.

Nice :)


python37Packages.twilio: 6.23.1 -> 6.24.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-twilio/versions.
meta.description for python37Packages.twilio is: '"Twilio API client and TwiML generator"'.
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 6.24.0 with grep in /nix/store/ycw937j3db372npi5sipsxzvxiwg4zjm-python3.7-twilio-6.24.0

directory tree listing: https://gist.github.com/72c88a1d7e0146faf7d4383f231717ef

du listing: https://gist.github.com/6f4fcb0f530898246d0b31bc39640168

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)
2 package rebuild(s)
2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
python27Packages.twilio
python37Packages.twilio

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ycw937j3db372npi5sipsxzvxiwg4zjm-python3.7-twilio-6.24.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A python37Packages.twilio https://github.com/r-ryantm/nixpkgs/archive/55be337d47170a5ad67ee1acaf27c3f9f6b0d762.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ycw937j3db372npi5sipsxzvxiwg4zjm-python3.7-twilio-6.24.0
ls -la /nix/store/ycw937j3db372npi5sipsxzvxiwg4zjm-python3.7-twilio-6.24.0/bin

cc @flokli for testing.

@GrahamcOfBorg build pythonPackages.twilio


alpha

I am curious if the benchmarks bust the LRU caches per iteration (or iterations are impure) to reflect a fair and real world comparison?

we're #2356 now

I am curious if the benchmarks bust the LRU caches per iteration (or iterations are not pure) to reflect a fair and real world comparison?
Update: we added this to isAddress recently, but just realised we didn’t update benchmarks to reflect - we can update that on our side.

this is something I need to take a look at, good shout. We'll definitely want to do it (at least in the) "cold cache" benches


CRLF makes --check report a change while there is nothing to modify

I have two files:

no_crlf.R, created on Linux:

if (TRUE) {
}

> file no_crlf.R
no_crlf.R: ASCII text

with_crlf.R, created on Windows and then opened on Linux:

if (TRUE) {
}

> file with_crlf.R
with_crlf.R: ASCII text, with CRLF line terminators

Both files have identical contents and are already formatted, but (I guess that) the CRLF line terminators make --check report some changes to make:
> air format no_crlf.R && air format no_crlf.R --check
> air format with_crlf.R && air format with_crlf.R --check
Would reformat: <path>/with_crlf.R

Tested with air 0.1.1.
Thanks again for this amazing tool

Ah yes, that's a side effect of https://github.com/posit-dev/air/issues/90 and will get fixed when we fix that
Thanks for being an early beta tester! Nice to surface a few of these early bugs


remove viewRef props from readme

remove viewRef props from readme

Thanks for the PR, but there is another one (older one) that fixes the same issue. I'm closing this one as duplicated


Removing the V2 compatibility layer

We're going to have a fair amount of code to ease the process of migrating from V1 to V2, including:

logic to catch old import paths, see #5113
similarly, support for from pydantic.settings import BaseSettings, even tough settings is in a new package - if pydantic-settings is installed, the import will work with a warning, if not you'll get an error saying "please install ..."
same for types moved/copied to pydantic-extra-types e.g. Color and PaymentCard - they're currently copied, e.g. they still exist in pydantic, but long term we want to remove that logic from pydantic
functional validator wrappers, see #5153
support for class based config
potentially a compatibility mode in pydantic-core that get's some old very common coercions to work, e.g. int -> str and any iterable of pairs -> dict
warning/error for things like Config.fields which has been removed

These compatibility features should be temporary. The question is how/when to remove them?
We should decide this before v2 is released so we can be explicit in warnings and errors about when the functionality will change.
Two options:

keep them until v3 - this either means keeping them for a long time, or releasing v3 quite soon even though most of the "changes" will just be removing this stuff
removing them in a future minor release, e.g 2.3 - this would mean they can be removed more quickly, but would break semvar and would require us to know when minor release they'll be removed in now and could potentially restrain us from  releasing new features as we have to limit our new minor releases e.g. "so 2.3 isn't released until a year after v2"
Remove them almost immediately in 2.1 - e.g. 2.0 is really just a compatibility release

I guess I'm leaning towards either 1 or 3, what do others think?

I am Ok with option 1. keeping them in V2 and removing them in V3.

or releasing v3 quite soon even though most of the "changes" will just be removing this stuff

Not so cool IMHO, but we might want to do it because V2 is a special version.
In general, we need to define a deprecation/removal plan and stick to it. for example, everything that is deprecated in a minor release will be removed in the next major release except deprecation in the last minor that has to be removed in minor version 1 of the next major release.
Consider we are in V2 and V2.5 is the latest minor release in V2. then all the deprecated features in V2.0-4 will be removed in V3.0 and deprecated features in V2.5 will be removed in V3.1
Then we can mark the features in code, tests, and docs with a pre-defined format to find them easily for removal. for example:
# RemoveInV3.0: When the deprecation ends, remove the function.
def test_func():
    warnings.warn('`test_func` is deprecated and will be removed in V3.0. use `new_func` instead')
    ....

I agree with @hramezani's suggestion to keep the items in v2 and remove them in v3, but I also think it's important to have a clear plan for how we will deprecate and remove them.
Essentially, there are two options:

Deprecate in v2 and remove in v3.
Keep in v2 and remove in v3.

I'm comfortable with either option, but I believe we should have a concrete strategy in place.
For example:

similarly, support for from pydantic.settings import BaseSettings, even tough settings is in a new package - if pydantic-settings is installed, the import will work with a warning, if not you'll get an error saying "please install ..."
same for types moved/copied to pydantic-extra-types e.g. Color and PaymentCard - they're currently copied, e.g. they still exist in pydantic, but long term we want to remove that logic from pydantic.

If we go with the first flow, in the first minor versions ex. v2.2  we should start informing the user that the import is deprecated and will be removed in v3.
def __getattr__(name):
    if name in ('BaseSettings'):
        warnings.warn(
            f'pydantic.{name} is deprecated and will be removed in v3.0, '
            'please use: pip install pydantic-settings instead.',
            DeprecationWarning,
        )
        return getattr(settings, name)
     raise AttributeError(f'module {__name__!r} has no attribute {name!r}')

Depending on the option we choose, we could begin to inform users of deprecation as early as minor version v2.2, or simply inform them that the imports will be removed in v3.
We could also stagger the removal process, with deprecated imports being removed earlier in minor versions ex. v2.5

@CameronNemo: https://docs.pydantic.dev/latest/usage/pydantic_settings/ / https://docs.pydantic.dev/latest/migration/#basesettings-has-moved-to-pydantic-settings

Ah yes sorry misunderstood, BaseSettings has indeed moved to a separate package, but also got a massive rewrite. Maybe you can use the compat code from pydantic.v1? (available with pydantic v2)


Zookeeper: Typo fix in purge interval property

Fix typo in the autopurge.purgeInterval property
Auto purge task is not getting scheduled because of the typo in this property
fixes #2942

/check-cla

/assign @enisoc

/lgtm


Order online page UI  and responsive

Page UI doesn't match to the website theme.
Page is not even responsive

@sunny0625 @khushi-joshi-05 ,
Please assign this issue to me under GSSoC'24.


Electron 7: going simple full screen turns everything white

Refs: https://github.com/microsoft/vscode/issues/85994
macOS, Catalina, electron exploration build

"window.nativeFullScreen": false
Go full screen -> whole screen is white and code is unusable

Due to the severity of the issue adding label important

@isidorn I cannot reproduce this with today's insider build (which comes with E7). Can you try again?

@bpasero I also can not reproduce, so this seems to have been fixed.


add amp-accordion

//cc @jkingyens this is an example for a component that won't validate as it is still in experimental.

LGTM, just one detail, should we put (experimental) next to it, and any other, in the main page to highlight that fact?

I thought the same - what's a good way to mark examples as experimental?

Maybe just a text next to them in the list (experimental: what does this mean?) with a link to https://github.com/ampproject/amphtml/tree/master/tools/experiments in the question.

but where do we add the flag when writing the sample?

Would it be possible to read a ? We can do it later in another pull.


Users' full names containing non-ASCII characters breaks Boxen::Config

For example, @mislav's full name, Mislav Marohnić, causes failures when Boxen::Config tries to load config.json.

@indirect I couldn't reproduce this. Is it still an issue for you?

I have no idea if it's a problem with the latest boxen still, sorry.
On Sun, Mar 22, 2015 at 12:30 PM, Sean Knox<EMAIL_ADDRESS>wrote:

@indirect I couldn't reproduce this. Is it still an issue for you?
Reply to this email directly or view it on GitHub:
https://github.com/boxen/boxen/issues/150#issuecomment-84683718

No worries. Going to close this.

@seanknox If someone is forking boxen/our-boxen, this is fixed for them in https://github.com/boxen/our-boxen/pull/448

The lock screen message requires a completely different byte encoding scheme, so I doubt this is fixed in general:
  # We can't use ::osx::recovery_message because:
  # 1) defaults read can't handle UTF-8. é input becomes either
  #    \U00e9 (if read by file) or \351 (if read by key)
  #    PlistBuddy inexplicably has no problem with UTF-8.
  $recovery_message = "André Arko<PHONE_NUMBER><EMAIL_ADDRESS>@indirect"
  $plist_cmd = "/usr/libexec/PlistBuddy /Library/Preferences/com.apple.loginwindow.plist"
  exec { 'Set OS X Recovery Message':
    command => "$plist_cmd -c 'Add :LoginwindowText string \"$recovery_message\"'",
    unless  => "$plist_cmd -c 'Print :LoginwindowText' | grep '^$recovery_message$'",
    user    => "root",
    notify => [
      Exec['Refresh system kext cache'],
      Exec['Refresh CoreStorage EFI Cache']
    ]
  }

  # 2) nvram good-samaritan-message percent-encodes é into %c3%a9
  $nvram_value = "Andr%c3%a9 Arko<PHONE_NUMBER><EMAIL_ADDRESS>@indirect"
  exec { 'Set OS X Recovery Message NVRAM Variable':
    command => "nvram good-samaritan-message='${nvram_value}'",
    unless  => "nvram good-samaritan-message | cut -c24- | grep '^${nvram_value}$'",
    user    => "root"
  }

  # The CoreStorage kext cache needs to be updated so the recovery message
  # is displayed on the FDE pre-boot screen.
  #
  # The CS cache can be updated directly by touching $eficachedir, if it exists.
  # Otherwise you will need to touch $kextdir to generate it.
  $eficachedir = '/System/Library/Caches/com.apple.corestorage/EFILoginLocalizations'
  $kextdir     = '/System/Library/Extensions'
  exec { 'Refresh system kext cache':
      command     => "/usr/bin/touch ${kextdir}",
      creates     => $eficachedir,
      refreshonly => true,
      user        => root
  }

  exec { 'Refresh CoreStorage EFI Cache':
      command     => "/usr/bin/touch ${eficachedir}",
      onlyif      => "test -d ${eficachedir}",
      refreshonly => true,
      user        => root
  }


6.0: [MoveOnly] Call mutating methods on existentials.

Explanation: Fix a diagnostic-on-valid in the move-checker.
Previously, calling a mutating method on a non-copyable existential failed with error: usage of a noncopyable type that compiler can't verify. Here, this is fixed.
Scope: Affects non-copyable code.
Issue: rdar://128900124
Original PR: https://github.com/apple/swift/pull/74198
Risk: Low. The fix is small and targeted.
Testing: Added regression test.
Reviewer: Andrew Trick ( @atrick )

@swift-ci please test

@swift-ci please test


[node] Update deployment env var for MCD

MCD token address is live , we need to be ready to support it by changing our deployment parameters.

https://twitter.com/nanexcool/status/1195356894426279936?s=12

Merged


fix: 🐛 instruction affirmation does not need leg count

Description
6.0 removes the need to specify leg count for affirmations. Previously would fail with expecting 2 got 3 args error
Breaking Changes
None
JIRA Link
N/A
Checklist

[ ] Updated the Readme.md (if required) ?

:tada: This PR is included in version 21.0.0-alpha.10 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 22.0.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 22.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Updates to debian package name

According to debian standards, package name and package
version should be seperated by '_'.
Changes to support rocm-cmake - https://github.com/RadeonOpenCompute/rocm-cmake/pull/38

@ntrost57 ,
Can you please review this.


Convert to correct underlying type

@davidkline-ms I just merged in the latest master branch and am now getting an error for implicit conversion between int and uint, so I do not believe these changes are in yet.

Thanks for checking on this! If you would like, feel free to update the types as part of your VS Catalog PR. :)


pass region to minio client

closes #3

Hi, looks really good to me.  I'll merge it after Christmas 🎅 Thanks for your contribution!

Sorry for the huge delay @johannesf95. Looks great. I'll merge & release it.

@NiklasPor No problem, since I figured out that we are actually using a minio bucket in our company. Since we rolled out your nx remote-cache last week, the pipeline performance increased a lot, because before were trying to persist the nx cache by using gitlab cache, but there you always have to upload/download the whole cache.
But might be still interesting for others, who use a s3-bucket actually.

Great to hear. Happy that you're actively using it. I actually built this only because someone asked me in one of my other packages about other options besides azure 👀


chore(api): fixing AWSDataStorePluginAuthCognitoTests to build

Issue #, if available:
Description of changes:
Check points: (check or cross out if not relevant)

[ ] Added new tests to cover change, if needed
[ ] Build succeeds with all target using Swift Package Manager
[ ] All unit tests pass
[ ] All integration tests pass
[ ] Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
[ ] Documentation update for the change if required
[ ] PR title conforms to conventional commit style
[ ] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Instead of reopening another PR because you've create a new branch like manaswi.datastore-cognitoAuth. You can take the previous branch manaswi.datastore-cognito from the previous PR https://github.com/aws-amplify/amplify-ios/pull/2251 and delete it locally:
git branch -D manaswi.datastore-cognito

Then rename manaswi.datastore-cognitoAuth to manaswi.datastore-cognito
// assuming you are on `manaswi.datastore-cognitoAuth` branch
git branch -M manaswi.datastore-cognito

Then you can do a force push to manaswi.datastore-cognito and overwrite the commit in the previous PR
git push -u origin HEAD --force


Execution params in actions

Description
Creates a way to pass execution time parameters inside actions.
👉 "Can pass a reference"
{{
  Api1.run(undefined, undefined, {
    userId: Button1.text
  })
}}

👉 "Can pass a value directly"
{{
  Api1.run(undefined, undefined, {
    userId: "value"
  })
}}

👉 "Can pass a locally created variable"
{{
  Table1.selectedRows.forEach(row => {
    Api1.run(undefined, undefined, { row })
  })
}}

⭐ "On the action side you can pull this value by `this.params` or by `executionParams` keywords"

{{ this.params.userId }} OR {{ executionParams.name }}

💥 "One can also refer multiple variables or write complex logic with it"

{{ this.params.userId  || "100" }}

Fixes #2100
Fixes #1817
Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?

TODO

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

@hetunandu Does this mean that we don't have to do implement global actions? If we can pass params to an action, then that action can be re-used across multiple workflows on the page.


Bug 1994139: Bump OLM kubernetes version to 1.22

PR updates dependencies to kubernetes 1.22 for OLM and includes a fix for the make manifests directive to make it crossplatform.
Signed-off-by: Daniel Sover<EMAIL_ADDRESS>Upstream-repository: operator-lifecycle-manager
Upstream-commit: 4a784fceec7661e36281139c4fc0f28a8e260c7f
Upstream-repository: api
Upstream-commit: 74543ec8c395244fa7892466b310ec38ec2ab375
Upstream-repository: operator-registry
Upstream-commit: a4fd56c7fb85428c6fb20d8e9fa378d3b5647657

/retest

/lgtm

/test e2e-aws-olm

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/lgtm

/lgtm

/retest

/retest

Hmm, those marketplace failures/alerts may be worth investigating after https://github.com/operator-framework/operator-marketplace/pull/414 merged earlier today.

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest


fix product reviews

pass media_list in create product review endpoint

move update medias of reviews in patch method of class.


feat: port MeasureTheory.Function.AEMeasurableSequence

AeMeasurable is defined in the file measure_theory.measure.measure_space_def. However, this file hasn't been ported yet.

AeMeasurable is defined in the file measure_theory.measure.measure_space_def. However, this file hasn't been ported yet.

I started to port this file because it appeared in "maybe ready to port". This happened because I ported MeasurableSpace ignoring the fact that the file with the tactic was not ported yet.

mathlib3port has newer changes


Improved insight into alignment-level data

There are many reasons nimble could produce alignments beyond what the user wants. This includes: 1) sub-optimal alignment settings (like too low mapping score), 2) a reference library with sets of references that will simply always result in ambiguous calls (like a reference with two nearly identical sequences). It would help the user if nimble-align could create an optional debugging output with a lot of raw information to help the user debug. The proposal is:

Add option to nimble and nimble python (which is passed to nimble-aligner), which is a filepath to an optional debug output. This would be a gzipped TSV.
Nimble would output one line per alignment. This output should have: 1) basic alignment metadata, including ref name. If start/stop are not possible, this is OK, 2) alignment stats, like score, # mismatches, etc, 3) the actual complete input read sequence(s), and 4) the sample name or cellbarcode. If the read is ambiguous, it would be useful if the reference name was the actual term used in the regular output (i.e. KIR3DL1/KIR3DL2 or SIVmac239/SIVmac251).

This would enable things like:

If a given reference is producing lots of low counts across cells, the user could extract all raw reads that mapped to that reference and 1) inspect the histogram of mapping scores, 2) take all raw reads and manually align to the reference to see where they map. for example, maybe all the noise is mapping to one specific region, 3) look at which regions of the input read map to the reference vs. which do not. On the whole, the point is to provide a lot of raw information, which could be inspected to better understand what the aligner is actually doing.

Note: while I assumed this would be a rust output, if nimble python code has access to read-level alignment data, this could be equally appropriate in python. In fact, if any filtering happens in python, it might be more appropriate there.

Note: it would also be really useful for the purpose of debugging if this could output some BAM-level flags, including: 1) MAPQ, and 10x-specific tags, including: MM and xf:
https://support.10xgenomics.com/single-cell-gene-expression/software/pipelines/latest/output/bam


Importing Performance Toolkit to BC Container fails

error AL1024: A package with publisher 'Microsoft', name 'Performance Toolkit', and a version compatible with '<IP_ADDRESS>' could not be loaded. Symbols for the requested app Performance Toolkit by
Microsoft <IP_ADDRESS> could not be found in the database
Following is the script that I am using:
$artifactUrl = $artifactUrl = get-bcartifacturl -country base -storageAccount bcinsider -version 17.1 -sasToken XXXX
$auth = "UserPassword"
$credential = New-Object pscredential 'admin', (ConvertTo-SecureString -String 'password' -AsPlainText -Force)
$licenseFile = "C:\Users\achandola\Desktop\License files\5164953v16.flf"
New-BCContainer -accept_eula                 -containerName $containerName
-auth $auth                 -credential $credential
-licenseFile $licenseFile                 -includeAL
-doNotExportObjectsToText                 -artifactUrl $artifactUrl
-assignPremiumPlan                 -isolation hyperv
-updateHosts                 -includeTestToolkit
-doNotCheckHealth                 -enableTaskScheduler:$false
-includePerformanceToolkit `

Please do not include tokens in your issues

You need to include -testtoolkit and -includeTestFrameworkOnly as well.
Next bccontainerhelper this will be automatic.
Please use this https://github.com/microsoft/navcontainerhelper/issues for containerhelper issues and follow the template.
thanks

My bad! I was just about to edit that. Thanks.

@freddydk I included those parameters as well but it didn't work for me. It fails while publishing _Microsoft_Performance Toolkit Samples.app

Didn't see the response until now.
You would need to dump the full output of the container generation AND the full output when trying to import perf toolkit to get help,


Type of Organization - wrong value showing

Bug:  in Analyst portal - Type of Organization shows as 'True' instead of the value stored in the db.
This is what is shows:

These are the values for example in the database that need to be displayed in the Analyst Portal

Good work!


AccountDetailsScreen: Adding flow type and updating to strict-local

Removed weakly typed reference and added ConnnectorProps type to AccountDetailsScreen.js. The file was updated with the tag strict-local.
Clarifications Required:

Given Props was already being used as a type in the same document, I had to name the new type as ConnectorProps. If this can be improved, please let me know and I'll take care of it in a jiffy (^_^)

Thanks @VisibleMarkov ! And thanks @jainkuniya for the review. :slightly_smiling_face:
I'll be interested to see what solution you find -- there are a number of spots in our code that use these react-navigation-related types, and I think a lot of them can be improved once we figure out how to write the types correctly. The kind of check that @jainkuniya described will be an important one in making sure any solution is a good one.


Can't form Range with end < start

Hi Vkt0r,
First of all thank you for this code. Just one issue so far.. In case child is empty, I get an error:
"Can't form Range with end < start"
I'm using it for generating a category menu. Some items have subcategories, some don't.
Any idea how I can change the code?

@99xs You're welcome. Issue fixed, good catch!!! 👍 In case of not being child the range is malformed I mean the first is greater to the second, fixed with this line:
guard index + 1 <= index + numberOfChilds else { return }

Avoiding runtime exceptions. Please update your repository with the new updates I've made.


fix #1858

it seems that the name={{ extra_packages | list }} line is not correctly interpreted

For my own reference, see: https://github.com/geerlingguy/drupal-vm/issues/1858#issuecomment-437434703
Not sure why the | list is there currently.

I think the | list was there to allow people to also enter a package list as a string (e.g. separate by commas or spaces). As I haven't seen any issues with this behavior for the past couple years, I'm going to close this PR as a 'cannot reproduce'. I haven't seen an issue with the current usage in any of my projects...
If you still see this issue, please post an issue to the issue queue with all the requested details so I can reproduce the bug.


Python "askopenfilename" function not working in "withdraw" mode if follows "input" command

Issue Type: Bug
When running Python script in VS Code "askopenfilename" function doesn't open respective window to provide a file and the code gets stuck - "print('4')" is not executed (even CTRL+C interruption doesn't work). This happens only if root window is hidden using "withdraw" function and "input" function to get user input is used before the "withdraw" (see the code below).
If root window is not hidden using "withdraw" function or if "askopenfilename" function is used without creating root window before or if "input" function is not used or the "input" function is used after "withdraw" function then the code works well and the respective window to provide a file is correctly rendered.
Also, the script works well and the respective window to provide a file is correctly rendered in any case (with "withdraw" and "input" functions) if the script is run from command line (not from VS Code) or directly from file manager in Windows.
from tkinter import filedialog
import tkinter as tk

input()

print('1')
root = tk.Tk()
print('2')
root.withdraw()
print('3')

filedialog.askopenfilename(
    title='Select ONM file',
    filetypes=(
        ("CSV files", "*.csv"),
        ("all files", "*.*")
    )
)

print('4')

VS Code version: Code 1.65.1 (8908a9ca0f221f36507231afb39d2d8d1e182702, 2022-03-08T02:06:27.846Z)
OS version: Windows_NT x64 10.0.18363
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz (4 x 2496)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.88GB (5.17GB free)

Process Argv
--log trace --crash-reporter-id db6e5194-50ea-46b6-b869-4a3cdd0c6042

Screen Reader
no

VM
0%

Extensions (14)

Extension
Author (truncated)
Version

show-unsaved-changes
ctf
0.0.9

syntax-highlighter
evg
0.5.0

code-runner
for
0.11.7

gc-excelviewer
Gra
4.2.53

vscode-edit-csv
jan
0.6.6

sftp
lix
1.12.10

python
ms-
2022.2.1924087327

vscode-pylance
ms-
2022.3.1

jupyter
ms-
2022.2.1030672458

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.6

autodocstring
njp
0.6.1

jinjahtml
sam
0.17.0

ayu
tea
1.0.5

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30443607
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vsclayoutctrt:30448491
dsvsc009:30440023
pythonvspyt640:30450168
vsbas813:30436447
vscscmwlcmt:30438805
helix:30440343
pynewfile477cf:30450039

/extPython


I'm able to install the plugin but it does not control my projector in Home app

Hello,
I’ve been trying to set up the jvc home bridge plugin you helped design.I’ve tried to follow the instructions but it doesn’t seem to be working. In home app, the device is installed but it does not detect the correct state of the projector, nor can it turn it on or off. I don’t see any error messages in the log section of HOOBS. I’ve got a couple of questions I was hoping you can answer.

I think I was able to successfully installl the JVC package remote package via the HOOBS terminal.

Python. I’m a coding novice and had not even hear about python until I looked it up for this plugin. I’ve downloaded python (v 3.9) onto my laptop. How do I figure out the python path that I need to for the plugin? As of right now, the application is installed in my application folder. I’ve tried a path to that and also "/.local/lib/python3.9” and "/usr/local/bin/python3”.

Is there a way to designate which port on the JVC it communicates with. While also trying to get another IP remote app (Roomie remote) to control the projector, my research discovered that I needed to use port 20554. Once I set that in the Roomie Remote app, I was able to control the projector.

Any other suggestions of what I can try to get your plugin to control my projector?

I appreciate any advice you can offer.
Jason

You need to determine the path to the python executable and use this for python_path configuration property.
On the terminal, does this give you anything:
which python3
if so, use that.
What is the path where Python is installed? Do you see any executable files in there?
What about if you just type:
python3
?
The port is not configurable currently, but the underlying python module uses 20554 by default so that should be fine.

Please see below for responses.

On the terminal, does this give you anything:
which python3

Yes. I get the following response:
/Library/Frameworks/Python.framework/Versions/3.11/bin/python3

You need to determine the path to the python executable and use this for python_path configuration property.
if so, use that.

I put copied that into HOOBS but still unable to see correct state of projector, or control it.

What is the path where Python is installed?

Python is installed in my applications folder

Do you see any executable files in there?

There is IDLE and Python Launcher applcations in the folder. I opened IDLE and put in the command:
import sys; print(sys.executable)
I got back the same path as above.

What about if you just type:
python3

When I put this into Terminal, it starts python
I also tried putting this into HOOBS and it was also unsuccessful.
Any other suggestions? I appreciate you trying to help me out.
jg

On Apr 16, 2023, at 1:38 PM, vectronic @.***> wrote:

?
The port is not configurable currently, but the underlying python module uses 20554 by default so that should be fine.
—
Reply to this email directly, view it on GitHub https://github.com/vectronic/homebridge-jvc-projector/issues/13#issuecomment-1510439780, or unsubscribe https://github.com/notifications/unsubscribe-auth/A237Q3UDDA4ONEKBM253TYTXBQVC7ANCNFSM6AAAAAAW7A3YYU.
You are receiving this because you authored the thread.

So/Library/Frameworks/Python.framework/Versions/3.11/bin/python3 is the executable and is the value you should use for python_path.
But try running the python file just from the command line without Homebridge first e.g.
Assuming the homebridge plugin is installed in /homebridge/node_modules/homebridge-jvc-projector and replacing <projector_ip> with the correct value something like this:
/Library/Frameworks/Python.framework/Versions/3.11/bin/python3 /homebridge/node_modules/homebridge-jvc-projector/dist/get_power_state.py <projector_ip>
Should be what the plugin invokes to check the power state.

Do I run that in macOS terminal or the hoobs terminal?jgOn Apr 17, 2023, at 3:56 AM, vectronic @.***> wrote:
So/Library/Frameworks/Python.framework/Versions/3.11/bin/python3 is the executable and is the value you should use for python_path.
But try running the python file just from the command line without Homebridge first e.g.
Assuming the homebridge plugin is installed in /homebridge/node_modules/homebridge-jvc-projector and replacing <projector_ip> with the correct value something like this:
/Library/Frameworks/Python.framework/Versions/3.11/bin/python3 /homebridge/node_modules/homebridge-jvc-projector/dist/get_power_state.py <projector_ip>
Should be what the plugin invokes to check the power state.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Wherever you have installed hombridge, the plugin and python...

I have homebridge installed on a raspberry pi. Is python supposed to be installed on the same machine (right now python is installed on my mac)?  If python needs to be installed on my pi, can you point me to some instructions on how to do that?Thanks. jgOn Apr 17, 2023, at 6:29 AM, vectronic @.***> wrote:
Wherever you have installed hombridge, the plugin and python...
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

yes - python needs to be installed with the homebridge plugin and homebridge.
I can't really step you through installing python on a raspberry pi. It should be fairly straightforward to find some instructions on google though.

Ok. I did some more reading. And I learned the python is already installed on my raspberry pi (v 3.9.2). I use the which python3 command to get the path and put it into the plugin. Again, I couldn’t connect to the projector. I tried running your installation command
npm install -g homebridge-jvc-projector
In HOOBS terminal and and it returned an error message (see attached screenshot). Any suggestions?
Thanks.
jg

On Apr 17, 2023, at 6:50 AM, vectronic @.***> wrote:
yes - python needs to be installed with the homebridge plugin and homebridge.
I can't really step you through installing python on a raspberry pi. It should be fairly straightforward to find some instructions on google though.
—
Reply to this email directly, view it on GitHub https://github.com/vectronic/homebridge-jvc-projector/issues/13#issuecomment-1511116836, or unsubscribe https://github.com/notifications/unsubscribe-auth/A237Q3RMHKX23EJ473DBCB3XBUN6XANCNFSM6AAAAAAW7A3YYU.
You are receiving this because you authored the thread.

￼

No screenshot provided.
If you’re configuring the plug-in surely it is already installed. Why are you trying to install it again?!

I’ve attached it again. I tried running it because I did not know what else to try to get the plugin to connect to the projector. I’m open to any suggestions. jgOn Apr 18, 2023, at 4:40 AM, vectronic @.***> wrote:
No screenshot provided.
If you’re configuring the plug-in surely it is already installed. Why are you trying to install it again?!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

No screenshot again... use the web UI instead of attaching to an email response!

I uninstalled the plugin and then tried installing with your command line. I received the same error messages.

I don't know anything about hoobs. How do you usually install homebridge plugins?
That looks like you you are logged in as user hoobs which doesn't have permission to write to /usr/lib.
Usually you would install as root user in this case by doing:
sudo npm install -g homebridge-jvc-projector


Provide instructions or links how to install Air and/or Templ

^ title
The documentation is really poor

@idc77 PRs are welcome, btw 🤗


Grafana dev

Issue #, if available:
Edited readme and added 2 files: launch_grafana.sh & grafana.ini
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi @abdelhaq-gh, thanks for the pull request! It looks like a large number of files are changed besides the launch_grafana.sh and grafana.ini changes mentioned in your comment. Would it be possible for you to squash your commits and rebase against latest main branch so that the diff contains just the significant changes?


JPEG-XL viewer

Description of the new feature / enhancement
Could we, please, have JXL preview and thumbnails, please?
Scenario when this would be used?
JPEG-XL has several advantages over prehistoric JPEG. Adobe Camera RAW and Affinity Photo already supports it. XN-View as well. To be able to view them on Windows would be soooo useful!
Supporting information
Maybe this could be useful.

JPEG-XL support is the future as far as I'm concerned. Standardized less than a year ago and it already has support from Adobe Camera Raw (their website recommends using AVIF or JXL for HDR photos), Affinity Photos 2, Krita, GIMP, Darkroom, ffmpeg, ImageMagick, Paint.NET, and like every image viewer I've ever used that's not the default Windows one. Far superior to AVIF and especially WebP.
jxl-winthumb that was linked is written in Rust but is a good reference (I assume PowerToys is enforcing code to be in C++/C# and doesn't want to add new build dependencies by incorporating Rust).
(Posted this on a separate issue for a proposed image converter utility but I think this is a more important and a better starting point for better incorporating JXL support into Windows.)

Needs tight integration with both PT:Peek and PT:File Explorer Add-On (Preview Pane)
fingers crossed

Hi! I came back just to inform that Lightroom now also supports JPEG-XL!

I guess everyone already knows but adding to the list:
Apple has been supporting JPEG-XL in the OS for some time now.
https://www.theregister.com/2023/06/07/apple_safari_jpeg_xl/

Interestingly, the quite okay image format  is already supported natively in PowerToys

Interestingly, the quite okay image format https://qoiformat.org/ is already supported natively in PowerToys

And the conclusions of this post about JXL performances ( https://cloudinary.com/blog/jpeg-xl-and-the-pareto-front#the_pareto_front ) are that qoi format is no more the fastest lossless compression format and that even for this use case, jxl is the best image format.


Buddy Project

[x] Enforce readonly in thread or use cron to delete after an hour
[x] Include tag of the buddy in the initial DM
[x] Block members with DMs disabled until they click a reaction in the disabled channel
[x] Clear matchedDate on DM issues

TODOs remaining (atm)

@geisterfurz007 can you rebase?

@geisterfurz007 can you rebase?

Done 👍

And Conflicts again  😅


Various issues related to the translation process

I noticed several issues while translating some pages so I’ll gather them in this issue:
1. Some translation units with an external link will fail to be published
This is currently tracked in a separate issue
2. Pages are not automatically translated to the currently selected wiki language, even if the translation is available
Example with the “Nix ecosystem” page:

Go to Nix ecosystem
Select “français” in the header
Notice that the selected page language is still “English”, even if the french translation is available

3. Automatic subpages list shows translated pages in addition to default pages
Example with the “NixOS on ARM” page:

Go to NixOS on ARM subpages list
Notice that the “en” and “fr” pages are listed
Notice that the “UEFI”, “UEFI/en” and “UEFI/fr” pages are listed

4. Automatic subpages list does not show on translated pages
Example with the “NixOS on ARM” page:

Go to NixOS on ARM subpages list
Notice that the list of subpages is present
Go to either the “en” or “fr” page translation subpages list
Notice that the list of subpages is not present

5. Sidebar is not automatically translated to the currently selected wiki language

Notice that a french version of the sidebar exists
Select “français” in the header
Notice that the sidebar still displays the english version

Mhm it looks like for translations to work they have to use special language links everywhere in KDE. Not so ergonomic

Ah. We basically need this: https://github.com/NixOS/nixos-wiki-infra/issues/119


Add a method to Share as Image

When clicking on our share option, the user should be prompted with "Share as text" or "Share as image", likely sharing the image will prompt them to save it to the google drive or directly send it to someone.
Change:

Will add a share icon to the top app bar and that will prompt the new menu dropdown.
unsure about placement currently, either top left or top right next to vertical dots.
for VtC, CtV, and SMD screens

Not sure how this implementation would look, though it may just be a screenshot of the resistor and resistance component for each screen.

before closing we need to do lots of testing to ensure the app will not crash from this


⚠ Bofrost.fr has degraded performance

In b5496d4, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1239 ms

Resolved: Bofrost.fr performance has improved in 006d31d after 6 minutes.


feat: resource apply changes only if different

This PR is to address #342 .
Changes:

updated the implementation in service layer
rework unit tests for the impacted methods

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

60 of 64 (93.75%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 75.137%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

datastore/service.go
60
64
93.75%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
6316

Relevant Lines:
8406

💛  - Coveralls


feat: support escaped paths in field name

Attempts to address https://github.com/TanStack/form/discussions/532 .
This is a sketch implementation for feedback, using lodash's internals for get.
Happy to roll a custom implementation but I thought of using an existing battle-tested implementation.
This implementation handles some of the cases in https://github.com/lodash/lodash/blob/main/test/toPath.spec.js .

This looks good overall! The only concern I have now is typings. We'll want a way to merge the types from string[] to string. This can be done like so:
https://github.com/crutchcorn/ts-util-helpers/blob/main/src/concat-string.ts#L1-L7
But then the question becomes "how do we get TName inference working for this?

This looks good overall! The only concern I have now is typings. We'll want a way to merge the types from string[] to string.
Not sure I get this part of your comment. Where are you referring to the string[] type? Is it the makePathArray?

But then the question becomes "how do we get TName inference working for this?
Just to make sure I get what you're referring to. You're referring to making sure that the DeepKeys https://github.com/TanStack/form/blob/77f119b0a6e6caccb8fdc3d3cdeda97b3560d1e5/packages/form-core/src/utils.ts#L299 can work for the [''] syntax, right? I'll look in this.

I wouldn't modify DeepKeys. I would modify the instance where TName is being passed and introduce a new utility type of some kind.

Added spec updates and also utilities as discussed. Ready for comment/review.

Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (08ad74d) 87.78% compared to head (92bc078) 87.65%.

Files
Patch %
Lines

packages/form-core/src/utils.ts
89.47%
2 Missing :warning:

packages/react-form/src/useField.tsx
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
- Coverage   87.78%   87.65%   -0.14%
==========================================
  Files          31       31
  Lines         819      826       +7
  Branches      184      187       +3
==========================================
+ Hits          719      724       +5
- Misses         95       97       +2
  Partials        5        5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hey, I am super sorry - but we've made drastic changes to the internals of these files. It's honestly better to close out this PR and revisit them. I think our types support this now, but our logic certainly doesn't.
Let's track the progress of this in: #639


release-please failed: Error adding to tree

TL;DR
PR not created when a commit received
Expected behavior
PR to be created
Observed behavior
Action stops running with the following error:
release-please failed: Error adding to tree: 93332e4552b999bf6d02e56f5044507a77ea92ca

93332e4552b999bf6d02e56f5044507a77ea92ca is the latest commit for the default-branch
Action YAML
on:
  push:
    branches:
      - features
name: release-please
jobs:
  release-please:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
        with:
          fetch-depth: 0
      - uses: google-github-actions/release-please-action@v3
        with:
          default-branch: features
          release-type: simple
          include-v-in-tag: false
          changelog-types: '[{"type":"feat","section":":sparkles: Features","hidden":false},{"type":"fix","section":":bug: Bug Fixes","hidden":false},{"type":"plugin","section":":package: Plugin Changes","hidden":false},{"type":"perf","section":":zap: Performance Improvements","hidden":false},{"type":"add","section":":hammer: Improvements","hidden":false},{"type":"revert","section":":rewind: Commit Reverts","hidden":false},{"type":"doc","section":"📚 Asset & Documentation Changes","hidden":false},{"type":"test","section":":white_check_mark: Tests","hidden":false},{"type":"ci","section":"🎡 CI","hidden":false},{"type":"refactor","section":"💡 Refactors","hidden":false},{"type":"release","section":"🏹  Releases","hidden":false},{"type":"style","section":"💄 Code Style Changes","hidden":false}]'

Log output
Run<EMAIL_ADDRESS>✔ Looking for latest release on branch: features with prefix:
❯ Fetching merge commits on branch features with cursor: undefined
❯ Found latest release pull request: 511 version: 1.14.3
❯ Fetching releases with cursor undefined
❯ found release for  Version {
  major: 1,
  minor: 14,
  patch: 3,
  preRelease: undefined,
  build: undefined
}
❯ found release for  Version {
  major: 1,
  minor: 14,
  patch: 2,
  preRelease: undefined,
  build: undefined
}
❯ SHA not found in recent commits to branch features, skipping
❯ found release for  Version {
  major: 1,
  minor: 14,
  patch: 1,
  preRelease: undefined,
  build: undefined
}
❯ SHA not found in recent commits to branch features, skipping
❯ found release for  Version {
  major: 1,
  minor: 14,
  patch: 0,
  preRelease: undefined,
  build: undefined
}
❯ Found 2 files
❯ Backfilling file list for commit: 9e9fb893033c062fabfc10b444b049a39dbd25e6
❯ Found 1 files
❯ Backfilling file list for commit: 7ad9172e126759acba06652c1c29ed802b9c7f13
❯ Found 3 files
❯ Backfilling file list for commit: 62de7d6e176969e40da9bdc121dd9e43ff11ef1b
❯ Found 1 files
❯ Backfilling file list for commit: 36ba924debcac44c8eed981116fb1cedbbea379e
❯ Found 1 files
✔ PR #512 has many files, backfilling
❯ Backfilling file list for commit: 21b720148a94288ede812027bca9cc2fc425aab6
⚠ Found 3000 files. This may not include all the files.
❯ Backfilling file list for commit: b900986650e2d562cd205aeceb133a994ff2b4c2
❯ Found 16 files
❯ Backfilling file list for commit: 43a59640e987a77766b5421c157371d29bf1262d
❯ Found 1 files
❯ Backfilling file list for commit: 0ddb0f1eb335ef5fb0363d71dac02121aba2e8f1
❯ Found 1 files
❯ Backfilling file list for commit: 2830afe407cc327e927623932c5b2aef54cc04f5
❯ Found 3 files
❯ Backfilling file list for commit: f40a395c45b743717b8726869dc7ff5bad61419a
❯ Found 2 files
❯ Backfilling file list for commit: 618868ffd25a028cb9537edcf26f090e2b495094
❯ Found 2 files
❯ Backfilling file list for commit: 495c809e2ae6b7941f62fd19613d374edd88f038
❯ Found 3 files
❯ Backfilling file list for commit: 5dc0b1af1defbfcbfee6c39e9767dc089de0d365
❯ Found 1 files
❯ Backfilling file list for commit: 0ea33afcff39bda4417c74954f09047be63fda31
❯ Found 1 files
❯ Backfilling file list for commit: c5fd9aaa47fc8443a901baa0b8ec443612de41ba
❯ Found 6 files
❯ Backfilling file list for commit: f1ebf8947916aca807b015c1c6342e1d2fd59b9d
❯ Found 1 files
❯ Backfilling file list for commit: a69b7c30143977d92a6936cb416caf46531eeade
❯ Found 1 files
✔ Splitting 3 commits by path
✔ Building candidate release pull request for path: .
❯ type: simple
❯ targetBranch: features
❯ commits: 3
✔ Considering: 3 commits
❯ component:
❯ pull request title pattern: undefined
✔ Looking for open release pull requests
✔ found 0 open release pull requests.
✔ Looking for snoozed release pull requests
✔ found 0 snoozed release pull requests.
❯ Fetching CHANGELOG.md from branch features
❯ Fetching version.txt from branch features
⚠ file version.txt did not exist
❯ Fetching .release-please-manifest.json from branch features
⚠ file .release-please-manifest.json did not exist
✔ Starting GitHub PR workflow...
✔ Successfully found branch HEAD sha "93332e4552b999bf6d02e56f5044507a77ea92ca".
✔ Skipping branch creation step...
✔ Got the latest commit tree
Error: release-please failed: Error adding to tree: 93332e4552b999bf6d02e56f5044507a77ea92ca

Additional information
We were using this action without any problems for at least 3 months. But we had this problem since yesterday. Can't find anything on the internet to fix this error, hope you could help.

I suggest trying to debug with the underlying release-please library's CLI: https://github.com/googleapis/release-please/blob/main/docs/troubleshooting.md (specifically with the --trace) option.

Same problem with the manifest command. However, the release-please cli does work. It fails while trying to create PR requests.

I'm also experiencing this error. Here are the logs from my github actions run:

✔ Building pull requests
✔ Building strategies by path
❯ .: simple
✔ Collecting release commit SHAs
❯ release search depth: 400
❯ Fetching releases with cursor undefined
❯ Found release for path ., v0.8.0
❯ release for path: ., version: 0.8.0, sha: 446f84cb5d32bf81bfc7e6f69e7a52a681e9e7ee
✔ Collecting commits since all latest releases
❯ commit search depth: 500
❯ Set(1) { '446f84cb5d32bf81bfc7e6f69e7a52a681e9e7ee' }
❯ Fetching merge commits on branch main with cursor: undefined
❯ Backfilling file list for commit: 9372c76061ba7957c7f7f556bc3039d383298266
❯ Found 4 files
❯ Backfilling file list for commit: 24dac357cf170e34[658](https://github.com/inContact/acddevops-reusable-workflows/actions/runs/4358230947/jobs/7618535898#step:3:659)6ec444e9ee7aff69[685](https://github.com/inContact/acddevops-reusable-workflows/actions/runs/4358230947/jobs/7618535898#step:3:686)43
❯ Found 1 files
❯ Backfilling file list for commit: fdd5b2f4104a652c389e462587d3a54abe[700](https://github.com/inContact/acddevops-reusable-workflows/actions/runs/4358230947/jobs/7618535898#step:3:701)46f
❯ Found 1 files
❯ Backfilling file list for commit: 71b837d7be17f735aaa8c3033a86e391ec5b90bf
❯ Found 1 files
❯ Backfilling file list for commit: 9486f516bef41efcf2224b235a36a8634de3fd05
❯ Found 1 files
❯ Backfilling file list for commit: 27312b361616e1f0ce81eb43f40065e1852df020
❯ Found 1 files
❯ Backfilling file list for commit: 88fa79073cba53923e722a94317ca2e57dba1621
❯ Found 3 files
❯ Backfilling file list for commit: 314debe51310d9443b58202913edaf69ec4a36ef
❯ Found 2 files
❯ Backfilling file list for commit: e0a88ca4fdf7eeaa61247ec2fac8571aa0223876
❯ Found 9 files
✔ Splitting 9 commits by path
✔ Building candidate release pull request for path: .
❯ type: simple
❯ targetBranch: main
❯ commits: 9
✔ Considering: 9 commits
❯ component:
❯ pull request title pattern: undefined
✔ Looking for open release pull requests
✔ found 0 open release pull requests.
✔ Looking for snoozed release pull requests
✔ found 0 snoozed release pull requests.
❯ Fetching CHANGELOG.md from branch main
❯ Fetching version.txt from branch main
❯ Fetching .github/actions/dockerfile/default/action.yml from branch main
❯ Fetching .github/actions/dotnet/build/action.yml from branch main
❯ Fetching .github/actions/go/build/action.yml from branch main
❯ Fetching .github/actions/java/build/action.yml from branch main
❯ Fetching .github/workflows/code-build-and-deploy.yml from branch main
❯ Fetching .release-please-manifest.json from branch main
⚠ file .release-please-manifest.json did not exist
✔ Starting GitHub PR workflow...
✔ Successfully found branch HEAD sha "9372c76061ba7957c7f7f556bc3039d383298266".
✔ Skipping branch creation step...
✔ Got the latest commit tree
Error: release-please failed: Error adding to tree: 9372c76061ba7957c7f7f556bc3039d383298266

Locally I executed:
release-please release-pr --token $GITHUB_TOKEN --repo-url=my-repo --debug --dry-run

and got the following output:

ConfigurationError: base (my-repo): Missing required manifest config: release-please-config.json
    at fetchManifestConfig (/home/linuxbrew/.linuxbrew/lib/node_modules/release-please/build/src/manifest.js:837:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async parseConfig (/home/linuxbrew/.linuxbrew/lib/node_modules/release-please/build/src/manifest.js:790:20)
    at async Promise.all (index 0)
    at async Manifest.fromManifest (/home/linuxbrew/.linuxbrew/lib/node_modules/release-please/build/src/manifest.js:118:93)
    at async Object.handler (/home/linuxbrew/.linuxbrew/lib/node_modules/release-please/build/src/bin/release-please.js:309:24) {
  releaserName: 'base',
  repository: 'my-repo'
}

Next, I added a release-please-config.json and .release-please-manifest.json file to my repo and updated my GitHub Actions workflow to the following:
      - uses: google-github-actions/release-please-action@v3
        id: release
        with:
          command: manifest

When the workflow ran it returned the same error:
Error: release-please failed: Error adding to tree: cad1a4570893fa785e7f10698e4c48468218b3f6

Nex, I ran the release-please cli locally with the command:
release-please release-pr --token $GITHUB_TOKEN --repo-url=my-repo --debug --dry-run

This command succeeded. So I'm a little bit lost on what to do since the release-please CLI is working but the release-please-action is not.
Also, the release-please-action doesn't have the ability to enable additional debug logging, so I'm not sure what to do next to diagnose this issue.

After further diagnosing I've determined that if I include the packages[*].extra-files array then the Error: release-please failed: Error adding to tree error occurs. If I remove the extra-files array then the error no longer occurs.
I'm not familiar with the code within this repo, but I think this can likely help someone else to resolve this issue.

Another data point...
Not sure if this is intentional, but have confirmed if using the release-please-config.json, and having the extra-files config section reference a file under the .github/workflows directory, release-please throws the same error as others have commented here:
✔ Got the latest commit tree
Error: release-please failed: Error adding to tree: <<GIT_SHA>>

I am currently experiencing a similar problem ("error: adding to tree", exclude-paths instead of extra-files, described in #704 ).
I am wondering if the issues are related.
The current theory is that the path .github/workflows has some sort of special meaning.
Ring any bells?

The .github/workflows folder indeed requires another permission. I tried using a custom Personal Access Token with the following permissions and it worked:

Was getting the same issue trying to update a file in .github/ directory, adding the permissions fixed it. Thank you @foxted

I was getting this issue with a fine grained access token - I couldn't find a set of permissions that worked, even if I matched the ones above.
Switching to a classic access token with the permissions in @foxted 's comment fixed it.

After we migrated to Github enterprise, this issue started to occur in our pipelines also. I want to share how we fixed it.

Grant more permissions to GITHUB_TOKEN

permissions:
  contents: write
  pull-requests: write

Allow GitHub Actions to create and approve pull requests. You can check it in your org settings or Github enterprise settings.


feat(response): new setting strict status codes

According to issue, a new configuration variable is added and the status code behavior is adjusted.

I think we need to add a test that is outside the strict range -- I could not find any existing

@ctcpip I added the missing test

@wesleytodd maybe I misunderstood, could you confirm the default value of the setting?
Default: true or
Default: false

I could be wrong, but I thought we had discussed with @jonchurch doing the strict checks by default in v5. I am not strongly opinionated either way, but if we dont turn it on by default now then we cannot until v6.

@wesleytodd I've updated the code according to the conversation, now "strict status codes" is true by default.

@wesleytodd, this isn't strictly required for v5
We had discussed adding this setting, and Blake suggested we err on the side of unopinionated and not set this by default.
It's a nice to have, but unless we open the discussion to have this as a default, it can come in as a minor.

Ok, so how about this. To keep things moving, lets go back to not setting it by default and then we can land it either now if we get approvals, or we can release it as a minor soon after the main release.

I updated the tracking todos to move the issue tracking this to the "future minor"

Ok, so how about this. To keep things moving, lets go back to not setting it by default and then we can land it either now if we get approvals, or we can release it as a minor soon after the main release.

@jonchurch That's my bad, I don't think I was clear, when I wrote:

I'd love to take a strong stance either way

I meant I'd prefer no configuration. Revisiting this a few months later I actually think this is still correct, and it should be loose by default, and anything else can be middleware. My hot take here is that we should actually be deprecating and removing configuration instead of adding more.

I meant I'd prefer no configuration.....My hot take here is that we should actually be deprecating and removing configuration instead of adding more.

I probably agree, that said this PR is in line with historical design of the project. I am sorry for any churn I created by asking the setting to be on by default. I think we should work toward aligning on some of these "technical vision" ideas after we release v5 and work toward applying those ideals in v6 (where landing this as a minor could be a step toward that, or closed if we decide the goal is to remove configuration options).

To be clear, what folks agreed to proceed with was the validation of the range of what node accepts -- there was discussion about limiting the range further, about whether the framework should be more or less opinionated, and so on, but the idea of a strict mode limiting the range further was the last comment and did not receive further discussion AFAIU.  So -- I don't think we should land this in 5.0.  We could still land it as a minor if we can get consensus to land it, but I don't want to block 5.0 on this.


Camera.record service issue

Home Assistant release with the issue: 0.91.2

Last working Home Assistant release (if known): N/A
Operating environment (Hass.io/Docker/Windows/etc.): Raspbian Lite

Component/platform: https://www.home-assistant.io/components/camera

Description of problem:
I am using YI 1080p Home camera and I configured it using Camera component. Live stream works without any issues using RTSP but I have problem with camera.record service in automation and in Service tab on webpage.
Web UI error message is: Failed to call service camera/record. Service not found.
When I'm executing record from automation I'm getting below error log:
ERROR (MainThread) [homeassistant.components.automation] Error while executing automation automation.nagrywaj. Service not found for call_service at pos 1: (ServiceNotFound(...), 'Service stream.record not found')
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
Configuration.yaml for camera
ffmpeg:
camera:
  - platform: ffmpeg
    name: camera
    input: -rtsp_transport tcp -i rtsp://<IP_ADDRESS>/ch0_0.h264
    extra_arguments: '-q:v 1 -r 25 -vf "scale=640:360"'

Automation.yaml for camera
- alias: nagrywaj
  trigger:
     - platform: event
       event_type: xiaomi_aqara.click
       event_data:
          entity_id: binary_sensor.switch_158d00020f5516
          click_type: single
  action:
     - service: camera.record
       data:
         entity_id: camera.camera
         filename: '/tmp/{{ entity_id }}_{{ now().strftime("%Y%m%d-%H%M%S") }}.mp4'

Traceback (if applicable):

Additional information:

Quoting from the documentation you linked:

Service record
Make a .mp4 recording from a camera stream. Requires stream component to be set up.

You need to setup the stream component by adding this line to your configuration.yaml:
stream:

The above comment is correct. stream must be enabled to use the record service.


[backport] Fix compatibility issues of ndarray.view

Backport of #5428 by @toslunar

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 52b4f7d5f030cb863ae4ffc3723e7b9d9dbce6a2, target branch v9) succeeded!


Getting started page is not up to date

On the getting started page it says I'm able to import from multiple targets like this:
  import { deepEqual } from "json-joy/es2020/json-equal";

Unfortunately it doesn't work and I get this error:
Cannot find module 'json-joy/es2020/json-equal' or its corresponding type declarations

https://jsonjoy.com/libs/json-joy-js/getting-started

Apparently withLogicalClock is also deprecated but still in the docs. This should also be updated

Yes, it will be updated soon. Please use /lib instead of /es2020. And Model.create() instead of Model.withLogicalClock().


About Kmeans label

You set 4 label that each color is 'navy', 'tomato', 'green', 'orange', but you practically use 3 label.
Why did you do that?
Thank you for reading.

First of all, thank you for your interest in my github.
When we proceed with kmeans, we experimented with two cases, one with three labels and the other with four.
As a result of the execution, when there were 4 clusters, the classification prediction model gave poor results, which is thought to be because the classification was not effective because the data we had was too continuous.
Therefore, it showed better performance when K was 3, so 3 labels were used.
I hope my answer helped you.
Thanks.


Incompatibility with Numpy 1.25

Environment

Qiskit Terra version: 0.24.1
Python version: 3.10
Operating system: macOS 13.3.1

What is happening?
The test suite and CI are failing because of new deprecation warnings issued by Numpy 1.25 (removing some unnecessary aliases and deprecating some questionable array-to-scalar conversions that we first encountered in #10120).  There also seems to be some sort of behavioural change that's affecting the isometry tests and making them flaky, which is harder to pin down.
How can we reproduce the issue?
Run CI with Numpy 1.25.
What should happen?
No warnings, all tests passing.
Any suggestions?
No response

I'm not 100% sure what's going on with the isometry tests - the failures seem to have questionably large absolute differences between the expected and resultant matrices.  It's plausible that it's related to changes in sin and cos in Numpy 1.25: numpy/numpy#23399, but I'm still looking into it.

I've narrowed at least one component of this a little bit more.  This might not be the only issue, but I do know:
import numpy as np
from numpy import array
from qiskit.extensions.quantum_initializer import UCGate

np.set_printoptions(floatmode="unique")

a1 = [array([[ 0.668014861563423-0.3346551458465917j,  0.277967131510269-0.6037353326489598j],
       [-0.277967131510269-0.6037353326489598j,  0.668014861563423+0.3346551458465917j]]), array([[ 0.2166062838266952+0.8682003952928524j ,  0.4271167766350859+0.12992709700820013j],
       [-0.4271167766350859+0.12992709700820013j,  0.2166062838266952-0.8682003952928524j ]]), array([[-0.2741070097201944 +0.8117613476501147j, -0.01821474636319918+0.5153417164352673j],
       [ 0.01821474636319918+0.5153417164352673j, -0.2741070097201944 -0.8117613476501147j]]), array([[ 0.1623765358315201 +0.9716678872200901j,  0.13410238340678943-0.107293654617689j ],
       [-0.13410238340678943-0.107293654617689j ,  0.1623765358315201 -0.9716678872200901j]]), array([[ 0.8245314897717796  +0.5297803036914427j , -0.014618052150304811-0.19815893809430707j],
       [ 0.014618052150304811-0.19815893809430707j,  0.8245314897717796  -0.5297803036914427j ]]), array([[ 0.7996715550698764 +0.5389276848385285j, -0.26190637639918435-0.0385668838274234j],
       [ 0.26190637639918435-0.0385668838274234j,  0.7996715550698764 -0.5389276848385285j]]), array([[-0.6951654137555511-0.4727347508596223j , -0.4217756893779492+0.33966479166601926j],
       [ 0.4217756893779492+0.33966479166601926j, -0.6951654137555511+0.4727347508596223j ]]), array([[-0.077850612760931  +0.5820993526489561j,  0.06379232106309757+0.8068644034233984j],
       [-0.06379232106309757+0.8068644034233984j, -0.077850612760931  -0.5820993526489561j]])]
uc = UCGate(a1, up_to_diagonal=True)

# As of Numpy 1.25, this call is no longer bit-for-bit deterministic:
uc._get_diagonal()

That call at the end used to produce deterministic output.  Now, the various values can differ between calls by an atol of somewhere in the region of 2e-16.  This then threads itself through the rest of the functions, occasionally flipping some global phases, and producing different matrices.
This doesn't explain to me, however, why the operator for the output isometry differs significantly from the input.  Within a single construction, I don't know why minor differences in the FLOPs of the calculation can produce such different output.

I don't know if this is the root cause, but I've tracked down a seeming flakiness in the multiply ufunc with complex numbers in Numpy 1.25.  On my machine, the file
import sys
import numpy

a = [
    numpy.array([
        [0.37407431362525206 + 0.7981674467868007j, 0.4497329415302707 + 0.1440049168541349j],
        [0.44973294153027066 - 0.14400491685413508j, -0.37407431362525156 + 0.7981674467868008j],
    ])
    for _ in [None] * 2
]
b = 0.7071067811865476 - 0.7071067811865475j

if (a[0] * b)[1, 1] - (a[1] * b)[1, 1]:
    sys.exit(1)

intermittently exits in the failure condition, with the imaginary components differing by 1ULP.  I couldn't reproduce that behaviour with Numpy 1.24.3 (or 1.25.0 without AVX2).
I don't really understand how that behaviour could cause a correctness issue in the Isometry decomposition itself - as far as I can tell it shouldn't attempt to recalculate the exact same FLOPs at any other time, so the decomposition should come out maybe differently each time, but correct - but it at least seems to be related.
I've filed the above issue as numpy/numpy#24000.  I'm not 100% sure it's a bug in Numpy, but I've chased this about as far as I can think right now.


need instructions on okapi

hi, i noticed the okapi module in morpheus
some traits such as PropertyGraph and CypherSession are defined in okapi,
that seems it is ready to be used to build custom Cypher execution engines
do you have any instructions or example code of how to use okapi?
thank you!

Hello @bluejoe2008 and thanks for reaching out to us!
You are quite right, the design intention for okapi is to be used as an abstract query engine to be applied to any backend in order to implement Cypher querying support. There are multiple layers on the okapi stack with which you can hook into the engine. The most sophisticated is the okapi-relational layer, which assumes a table-like backend system (such as Apache Spark, which we have used as the driving backend for okapi, and the main feature of Morpheus).
We have done a number of talks on okapi:

openCypher Implementers Meeting (oCIM) 5, March 2019
Apache Spark Summit EU 2019 - SparkGraph
Apache Spark Summit EU 2019 - Morpheus

To mention a few. I hope these talks can be useful.
Unfortunately, we do not have any updated documentation for okapi in particular, and we are not actively developing either okapi or morpheus. There are also two sibling projects that use okapi on other backends:

https://github.com/opencypher/link (Apache Flink)
https://github.com/s1ck/mem-cypher (In-memory Scala data structures)

but these are also not being actively developed.

ok, many thanks!

I'm glad you like it! 😃
Technically, okapi is less about Neo4j (the database) and more about Cypher (the query language) but they do share history and indeed we who built this are with Neo4j (the company).
If/when you try out okapi please do reach back here for additional questions and we'll do our best to help out!
Sincerely,
Mats


Right Clicking Tokens

Whenever I would right-click tokens while having token(s) selected, as a GM, to add them to initiative/enter combat state (or to do other stuff such as apply conditions) it would instead move all the selected tokens to that area, due to opening the token tooltip menu also requiring a right-click.
It would be great if when it detects a token it doesn’t move, similar to how it detects panning.

Fixed!


Smooth Walking Policy w/ Legs only

Fine tune the policy for Stompy's Legs. Quick walking pace and decently sized gait.

Achieved.


Fix some typos

Signed-off-by: lizz<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Documentation for OSS Lifecycle

See https://github.com/badges/shields/pull/3618#issuecomment-507900899.

Warnings

:warning:
This PR modified service code for osslifecycle but not its test code. That's okay so long as it's refactoring existing code.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @PyvesB!

  Generated by :no_entry_sign: dangerJS against 2b2be4a28f1cb1d6d0db0cc4086d787e42f8c06a