Operation request: Remove Diacritics (with replacing letters) / Remove non-latin letters / Latinize

Summary
Remove diacritics and replace non-latin characters with latin equivalents.
Example Input
ĄĆĘŁŃÓŚŹŻ ąćęłńóśźż æ ø

Example Output
ACELNOSZZ acelnoszz ae o

Explanation
There is existing operation Remove Diacritics. Example.
Example input:
ĄĆĘŁŃÓŚŹŻ ąćęłńóśźż æ ø

Example output:
ACEŁNOSZZ acełnoszz æ ø

But you can see that not all letters is replaced. For example in polish alphabet letter ł isn't replaced to l. Another example letters are æ and ø.
You can think this is a bug, but I found why this is working in that way. Source code links to StackOverflow answer with implementation. There is discussion and explanation:

There's always one char that fails.. 'ąśćńżółźćę'.normalize('NFD').replace(/[\u0300-\u036f]/g, "") -> ascnzołzce (missing match for ł ->l).
ł is a letter in itself, not an accented L. Therefore it should not be changed to l.

So it only removes diacritics, but not removes non-latin letters.
On Stackoverflow question there are many other answers handling these cases (I think the only way is listing all cases and replacing). Also there is a library latinize (https://github.com/dundalek/latinize) that handled these cases (source code lists all cases).
New operation or parameter to existing
I wonder what will be better:

New operation (name: Latinize or Remove non-latin letters).
Modify existing operation and add boolean parameter (name Replace letters or Remove non-latin letters ).

First is more natural because this is another operation. But is causes more and more similar operations.

I prepared change that fixes this issue: https://github.com/gchq/CyberChef/pull/1257

I think I favour a new operation called 'Latinise' or 'Romanise' over adding this into the 'Remove Diacritics' operation. The latinize library that you mentioned does more than just remove diacritics. It transliterates characters like 'Ю' to 'YU', 'я' to 'ya', and 'ч' to 'ch'. Diacritics are specifically extra glyphs added to existing letters, like accents. I think it's important to differentiate between these two different functions, though I agree that having an operation to Romanise characters would be useful.


verify the url?

Great stuff I was looking for someyhing like this!
But before I fill in my password
How can I verify  https://y7xyrocicl.execute-api.eu-west-1.amazonaws.com is owned by aquacell? Or how did youget this info?

All the used URLs and IDs are retrieved from the android mobile app.
I'm not aware of any endpoint on this rest API to be able to identify it without authentication.
You could verify it by decompiling the APK and check the res\raw\amplifyconfiguration.json file.

Ok, thanks a lot! Maybe add this info to the REAME.md? I would be happy to create a PR for that.


weathermap crash after upgrade and path changes

perhaps a regression of https://github.com/Cacti/plugin_weathermap/issues/129 ??
upgraded this morning after not using weathermap on this system for a while, dealing with database performance issues.  Typo on my part... FYI... a G and an M after 512 makes a HUGE difference to MariaDB :)
anywhoo..  see the new paths for config.php and updated outside of the cacti dir.. permissions set to www-data.  Plugin will enable, but on first run it crashes and disables itself.  tried full un-install/re-install. disabled all configs and only enabled the simple.conf with very limited instruction.
$configdir = '/var/www/html/cacti-weathermap/configs/'; $outputdir = '/var/www/html/cacti-weathermap/output/';
current versions:
commit 582f4f6c1a31cc17c382a6be83a2a40894fbe323 (HEAD -> develop, origin/develop, origin/HEAD)
Author: TheWitness<EMAIL_ADDRESS>Date:   Mon Dec 9 11:24:18 2024 -0500
Plugin: /var/www/html/cacti/plugins/weathermap/
commit d30f39ea79abcc84c86215445d084c72bbe2c5a1 (HEAD -> develop, origin/develop, origin/HEAD)
Author: TheWitness<EMAIL_ADDRESS>Date:   Wed Nov 20 14:18:01 2024 -0500
php is at 8.1. perhaps this is an 8.2 issue?  intl is installed and everything up-to-date as of this morning
error (word wrap on the post doesn't seem to be working for some reason for me)
2024-12-09 08:58:49 - SQL Backtrace: (/plugins/weathermap/weathermap-cacti-plugin-mgmt.php[286]:add_config(), /plugins/weathermap/weathermap-cacti-plugin-mgmt.php[1567]:db_execute_prepared())

2024-12-09 08:58:49 - CMDPHP ERROR: A DB Exec Failed!, Error: Duplicate entry 'simple.conf' for key 'configfile'

2024-12-09 08:58:16 - MAILER INFO: Mail successfully sent via SMTP from '911 Network Monitor<EMAIL_ADDRESS>to 'Administrator<EMAIL_ADDRESS>cc '', bcc '', and took 1.46 seconds, Subject 'Cacti System Warning'

2024-12-09 08:58:15 - SYSTEM MONITOR STATS: Time:0.02 Reboots:0 DownDevices:0 Notifications:0 Purges:0
2024-12-09 08:58:15 - CMDPHP ERRORS DETECTED - DISABLING PLUGIN 'weathermap'
2024-12-09 08:58:15 - PHP ERROR Backtrace: (CactiShutdownHandler())
2024-12-09 08:58:15 - ERROR PHP ERROR in Plugin 'weathermap': Uncaught Error: Found unconstructed IntlDateFormatter in /var/www/html/cacti/plugins/weathermap/lib/WeatherMap.class.php:1947 Stack trace: #0 /var/www/html/cacti/plugins/weathermap/lib/WeatherMap.class.php(1947): IntlDateFormatter->format() #1 /var/www/html/cacti/plugins/weathermap/lib/WeatherMap.class.php(2043): WeatherMap->{closure}() #2 [internal function]: WeatherMap->{closure}() #3 /var/www/html/cacti/plugins/weathermap/lib/WeatherMap.class.php(2045): preg_replace_callback() #4 /var/www/html/cacti/plugins/weathermap/lib/WeatherMap.class.php(2053): WeatherMap->strftime() #5 /var/www/html/cacti/plugins/weathermap/lib/WeatherMap.class.php(3646): WeatherMap->DrawTimestamp() #6 /var/www/html/cacti/plugins/weathermap/lib/poller-common.php(461): WeatherMap->DrawMap() #7 /var/www/html/cacti/plugins/weathermap/setup.php(1233): weathermap_run_maps() #8 /var/www/html/cacti/lib/plugins.php(243): weathermap_poller_bottom() #9 /var/www/html/cacti/lib/plugins.php(97): api_plugin_run_plugin_hook() #10 /var/www/html/cacti/poller.php(991): api_plugin_hook() #11 {main} thrown in file: /var/www/html/cacti/plugins/weathermap/lib/WeatherMap.class.php on line: 1947

Run php -m is php-intl installed?  It could be as I have not been working on the Weathermap for a while.  Distracted with the core.  Pull requests are always welcome.

It is installed and current, I'll see what I can do and if I can fix I'll try a pull request.


SourceFile.appendText

Would be useful to add this specifically for source file.

I can't remember the reason for this. Right now people can use the addStatements method.


Desk.com

would be awesome to have the Desk logo in here. Seems you already have Salesforce and Heroku. Also Zendesk and User  Voice.
Cheers
http://www.desk.com/

Added 7dc1b8b6910a254efec43994f348d06ffc3d683b

nice!


FastImage :Breaks in android

when i am using some thing like
<FastImage
            source={{
              uri: item.blurredImageUrl,
            }}
            resizeMode={FastImage.resizeMode.cover}
            style={Style.modalHeaderBgImage}
          >
            <View>
              <FastImage
                source={{
                  uri: iconUrl,
                  priority: FastImage.priority.high,
                }}
                style={Style.modalHeaderImage}
                resizeMode={FastImage.resizeMode.stretch}
              />
            </View>
            <View style={Style.modalHeaderRight}>

              <Text>
                ENDS IN
              </Text>
            </View>
          </FastImage>

when i use this libary on Android, it show an error:
"android.widget.imageview cannot be cast to android.view.viewgroup".
Please resolve this issue . Works fine in IOS . Need it urgently

I don't think FastImage component should have children. Or should they? Have you try removing the children and write them as siblings components? Check this out

It seems that this is a duplicate of the issue #7

Definitely duplicate. FastImage shouldn't have child components if you want to target android.

Thanks for the issue. See #15 .


Generate remaining files in nanoproto format.

Generated by running almost all ant targets under java/build.xml; everything except:

testname
test
clean
clean-build

Some targets that generated new files:

[default]
build-single-file-phone-metadata
build-test-metadata
build-single-file-test-metadata
build-js-metadata

JAR diffs at ~keghani/GitHub_diffs/20151019_01/ - protobuf files were all removed.

Obsolete


Xiaomi

Home Assistant release with the issue:

Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):

Component/platform:

Description of problem:
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:
Hi. None of My Xiaomi switches is not working after 0.84.3

Please fill out the template.

Please read the release notes about breaking changes: https://github.com/home-assistant/home-assistant/pull/17354


AMD GPU support

I got it working
Run this
pip3 install torch torchvision torchaudio torchvision --index-url https://download.pytorch.org/whl/rocm6.2

Then remove torchvision, torchaudio, torchvision from the file... Only problem, it's quite slow lol but that's just my GPU likely (rx 6800)
open-oasis on  master [!?] via 🐍 v3.12.7 (venv)
❯ python generate.py
/home/noah/Documents/AI/open-oasis/generate.py:17: FutureWarning: You are using `torch.load` with `weights_only=False` (the current default value), which uses the default pickle module implicitly. It is possible to construct malicious pickle data which will execute arbitrary code during unpickling (See https://github.com/pytorch/pytorch/blob/main/SECURITY.md#untrusted-models for more details). In a future release, the default value for `weights_only` will be flipped to `True`. This limits the functions that could be executed during unpickling. Arbitrary objects will no longer be allowed to be loaded via this mode unless they are explicitly allowlisted by the user via `torch.serialization.add_safe_globals`. We recommend you start setting `weights_only=True` for any use case where you don't have full control of the loaded file. Please open an issue on GitHub for any issues related to this experimental feature.
  ckpt = torch.load("oasis500m.pt")
/home/noah/Documents/AI/open-oasis/generate.py:23: FutureWarning: You are using `torch.load` with `weights_only=False` (the current default value), which uses the default pickle module implicitly. It is possible to construct malicious pickle data which will execute arbitrary code during unpickling (See https://github.com/pytorch/pytorch/blob/main/SECURITY.md#untrusted-models for more details). In a future release, the default value for `weights_only` will be flipped to `True`. This limits the functions that could be executed during unpickling. Arbitrary objects will no longer be allowed to be loaded via this mode unless they are explicitly allowlisted by the user via `torch.serialization.add_safe_globals`. We recommend you start setting `weights_only=True` for any use case where you don't have full control of the loaded file. Please open an issue on GitHub for any issues related to this experimental feature.
  vae_ckpt = torch.load("vit-l-20.pt")
/home/noah/Documents/AI/open-oasis/generate.py:42: FutureWarning: You are using `torch.load` with `weights_only=False` (the current default value), which uses the default pickle module implicitly. It is possible to construct malicious pickle data which will execute arbitrary code during unpickling (See https://github.com/pytorch/pytorch/blob/main/SECURITY.md#untrusted-models for more details). In a future release, the default value for `weights_only` will be flipped to `True`. This limits the functions that could be executed during unpickling. Arbitrary objects will no longer be allowed to be loaded via this mode unless they are explicitly allowlisted by the user via `torch.serialization.add_safe_globals`. We recommend you start setting `weights_only=True` for any use case where you don't have full control of the loaded file. Please open an issue on GitHub for any issues related to this experimental feature.
  actions = one_hot_actions(torch.load(actions_path))
/home/noah/Documents/AI/open-oasis/venv/lib/python3.12/site-packages/torch/nn/modules/linear.py:125: UserWarning: Attempting to use hipBLASLt on an unsupported architecture! Overriding blas backend to hipblas (Triggered internally at ../aten/src/ATen/Context.cpp:296.)
  return F.linear(input, self.weight, self.bias)
 29%|███████████████████████▌                                                         | 9/31 [02:27<06:58, 19.01s/it]

Could a official requirements_amd.txt or something be made?

If someone wants they can experiment with Intel Arc/OpenVINO and DirectML, seems easy to just replace dependencies and it just works and not many of them

can you make a more indepth tutorial on how to fixx this?

I already did. Run the first command, edit out the lines in requirements.txt, then install the remaining dependencies with pip install -r requirements.txt. This is however assuming you run Linux, on Windows things are much less developed (but more stable in my experience... Can't have best of both worlds seemingly)
Finally, additionally you might want to either use Conda or python -m venv venv and source ./venv/bin/activate to create a isolated environment for the things you will install


.Top and .Skip are ignored for actions

The .Top and .Skip values are ignored when executing action. For example,
client.For<Foo>().Action("Bar").Skip(10).Top(10)

Will generate
Foo/Bar

instead of
Foo/Bar?$skip=10&$top=10

Thank you for the report. Let me investigate this issue and get back to you.

Yes, I reproduced the problem. The fix is coming soon.

Fixed in version 4.2.1.


changed the background of home page

Description
changed the background of home page
Checklist

[x] I am making a proper pull request, not spam.
[x] I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests
issue #77
Add relevant screenshot or video (if any)

@Vanshiii203 there is some issues with the background. also after search results are not showing. did you clone main branch?

Yes

@wasimreja Should I create another PR??

@Vanshiii203 clone the hacktoberfest branch not main branch then change the background and raise pr

@Vanshiii203 clone the hacktoberfest branch not main branch then change the background and raise pr

okay!


chore: package-lock.json files necessity of existence

It doesn't seem to be of any use and I think it needs to be removed.

See the explanation from stack overflow.

Maybe the above link is about this file, which only works for npm-managed projects, and obviously the root dependency is managed by go mod, not npm.
https://github.com/LinuxSuRen/api-testing/blob/master/console/atest-ui/package-lock.json

You are right.


It won't load nvm automatically, only if I trigger the function __nvm_run

I believe that loading nvm.sh after intialization would be better,
otherwise It won't inject or modify necessary ENV VARIABLES into global, like $PATH, where stores some global dependencies installed by NPM. Only I can access the bin after type node or nvm, it's annoying, right?

And I figured out one solution, is that add bass source $NVM_DIR/nvm.sh to config.fish

That's the point, sourcing nvm everytime you open a new terminal will slow it down by a couple of seconds, this plugins only sources nvm when you run nvm, npm or node if you want it to be runnig whenever you open the terminal just add this to your config.fish
if not type -q bass
    echo 'Bass is not installed please install it running fisher edc/bass'
else
   bass source $NVM_DIR/nvm.sh >/dev/null ^&1
end

yep.. I noticed that before.. actually, it's much slower
is that caused by bass process?
anyway, thanks the code!

The biggest problem is in nvm itself, more info in https://github.com/creationix/nvm/issues/860 and https://github.com/creationix/nvm/issues/703
Of course sourcing bash code in fish adds a couple of milliseconds

@bjmin If you are not constrained to using nvm (like company rule, etc), I recommend you https://github.com/fisherman/fin.

@bucaran thx~.. though i'm looking for a more native way to install Node, i'll give a try!

@bjmin I could be completely wrong, and please @FabioAntunes correct me if I am wrong, but I see little benefit to building from source unless you actually want to fiddle with the source, in which case, sure go ahead :)


Cloudformation: reorganize and clarify the form

This commit includes:

Re-order parameters by using AWS::CloudFormation::Interface
Add friendly name for parameters
A few description clarifications
Change the InstanceCount to be a string with list of 1-10

Fixes: #180
@yaronkaikov please review.
The form new design:

@benipeled Just a general comment, if you want me to review, you can just asign me as a reviewer (right side). if you can't let me know so i will fix it for you


The code style and bugs of the e2e module

As we have ready know, the e2e module is preleased ahead of the  schedule.But the released version is not pecfect,even we can say it's not a good example.I‘m sorry for say those impolite words.I try run the code,and find those:

The code is mix with tensorflow and keras.I guess the original model is used tensorflow,in order to release a public model,then rewrite the model in keras,It seems like this code

with tf.device("/gpu:0/"):

is kind of tensorflow code style,and it did not work with keras model and would raise fault.

The batch_size setting seems unwork, the current batch_size is used to generate batch_size data,but in keras the method model.fit did not specialized the batch_size,when run the model,I set the batch size to be 256,but the GPU memory would just using about 3GB,I it would be effective if using model.fit(...,batch_size = 256,...),I'm not sure the caculating speed of those two seting.According to keras,if you did not sepcialized batch_size,the default would be 32,but indeed,I can see the image number incease from 1 to 256,not jump by 32.

The data read and training pipeline did not have multiprocessing,If I set the batch size to be 4096,and the real traing batch_size is 256,means that an epoch have 16 step.But the data loading from the disk seems very long,about 3 second while the GPU usage is very low.

There need to check if there existed a folder of 'log' and 'modules',if not,make one.

I try my best to run those code,and I'm not really good at codding,I have success train the model.if no one update those code ,I will try to merge my version,but I really hope you guys could make those code peffect.

Thanks very much for your comments. Please make a pull request of your version and we will add e2e people to review it.

In our platform, if you have created  “logs” and “models” directory, the code is running without any errors, Keras on the multi-GPU and distributed support is done through the tensorflow. If there any errors, please post it , together to solve it.
The focus of this open source is the data, so the code is to help developers to quickly understand the open source data format and how to use the open source data. Follow-up we will continue to open our models and algorithms. Of course, you can make a pull request.
The "logs" and "modles" directories have been created and the code is updated.

@yanys1  Thank you for the reply, I wonder Where could I find the tensorflow and keras version you are using,currently I'm using tensorflow 1.3 and keras 2.0.8. I see you update your code,and I see you remove the code
with tf.device("/gpu:0"):

but you did not upgrade the multiprocessing code, I implement an version that have multiprocessing,due to the speed of my hard disk is very slow compaired to the compute time by GTX1080 ti,it decrease the computing time by 10~15%.you said that this code is just to understand the data,Do we need to make the code as simple as possible?

After I run the code and see the code implementation of keras, I found that the default batch_size is 32 and it is effect, just because the number increase so quickly,indeed it is increase by 32.

@gengqx  i'm using tensorflow 1.2 and keras 2.0.7.  The jpg decode more time consuming, it is recommended that put the source data and programs  on an SSD disk, it will be faster.

@yanys1 Thank you,As I said,I have already implement an version that have multiprocessing.Indeed I referenced the 'fit_generator' method.
Here I want to say: We could not use 'fit_generator' method directly.There are two reason for this.
First,Using 'fit_generator',it need the generator to loop over the all the data infinitely,apparently the current generator in Apollo does not satisfy.
Second,using 'fit_generator',you need to specify the samples per epoch,currently we did not know how many are the images compared to the other pubic dataset having fixed and known data shape.

@gengqx   The trainsets has  5246135  samples, the testsets is have 125043 samples.


ScheduledReporter may have missed reports

Problem Statement
I think, fix for https://github.com/dropwizard/metrics/issues/1524 has undesired side-effects in our environment. Because executor.scheduleWithFixedDelay accumulating errors (due network latency, for example) when it goes over reporting period, we have "holes" in graphite metrics:

Possible solution
In our case, report bursts are probably lesser evil than holes, so maybe we can make it configurable.

We are seeing the same problem which is a result of #1524 and the switch to scheduleWithFixedDelay
We are sending counter metrics every minute to Graphite, Carbon Aggregator and we use nonNegativeDerivative to show only the changes per minute and we are seeing "fake" metrics.

The derivative function is sensitive to missing metrics, if one of the hosts aggregated is not sending and then sends again, it will show up as an increase in the metric for that minute. We are aggregating to hours in the above graph and the results are completely wrong, there is nothing happening on the server and all those bars are caused by missing metrics.
Here is an example of missing metrics showing up from two hosts:

I've captured the metrics on the Graphite server with tcp dump and saw the following reports from a single source server:

arrived 08:08:59.087611 metric payload timestamp<PHONE_NUMBER> (08:08:58)
arrived 08:09:59.343252 metric payload timestamp<PHONE_NUMBER> (08:09:59)
arrived 08:10:59.597794 metric payload timestamp<PHONE_NUMBER> (08:10:59)
arrived 08:11:59.856127 metric payload timestamp<PHONE_NUMBER> (08:11:59)
arrived 08:13:00.118483 metric payload timestamp<PHONE_NUMBER> (08:13:00)

First I suspected network latency issues and missing aggregation buckets on Graphite, but from the timestamps added by GraphiteReporter it is clear that the reporter is sending them late and missing the buckets. The increasing delay was an immediate sign of scheduleWithFixedDelay which was confirmed in the codebase.
Current metric reporting using fixed delay is problematic as the reporting interval is unstable and a function of how long does reporting itself take. The small delays add up and every few hours we see a missed interval and fake values with derivatives.


Find all subsets of a string.

Input - FUN
Output -
F
FU
FUN
U
UN
N

Can you assign me?

@rahulkumar6142998  I want to solve this code

@anupriya-21 yes you can

@ssurbhi09  okk you can

done u can see my pr and pls merge it thanyou.

@ssurbhi09  can you help me also get pr? Iam not able to find any issues

Now u got it or not?

I have done both the issues!

@ssurbhi09 Yes no issues

@rahulkumar6142998 I have added the program and created a PR

Shall I work on this ?

I want to work on this issue


updated the index.html and the img folder

i included my picture in the image folder at isaac.jpg,  and included my fact-card at 'ISAAC'S SECTION' of the index.html file

You have a conflicting file please resolve

You have a conflicting file please resolve

Done

Good job Isaac. Thank you for your contribution

Please fix your image and write "Frontend Engineer" instead of "ReactJs Software Developer"


add more examples for Belt.List

Fixes #50
Adds examples for more Belt.List functions.
Do we want examples for the uncurried functions as well?

I think leaving uncurried examples is fine for now. At some point we should have a dedicated info page on how to use uncurried functions, so this information would otherwise be redundant IMO

Thanks!


Missing utcOffset in DatePicker even if it is still documented in datepicker.md

Describe the bug
I was hoping that I can tweak the today's timezone in DatePicker by using utcOffset which was stated in  datepicker.md. However, utcOffset is removed from the source code in this from version 0.58.
To Reproduce
Assume browser timezone is UTC+00:00

Pass in utcOffset as a prop like below

      <DatePicker
        ...
        utcOffset={480}
      />

Click and open the DatePicker in browser
Seeing today with timezone of UTC+00:00

Expected behavior
I expect to see today with timezone of UTC +08:00
Desktop (please complete the following information):

OS: Mac
Browser: Chrome
Version: 77.0.3865.90 64 bits

Additional context
I really hope utcOffset is still supported. However, If it is not supported any more, I think the document needs to be updated accordingly.

Anyone can help with the UTC problem?


docs: rip out contract-api section

upgrade api-extractor
disbable solidoc in nitro-protocol
delete sidebar and navbar entries

this is a fallback option in case we cannot get solidity -> docs pipeline working again.
Not to be merged yet, since it could end up overwriting the existing docs website.

in favour of #3005


⚠ Fetchers has degraded performance

In 35dabfc, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 479 ms

Resolved: Fetchers performance has improved in 1bff54f.


fix(keybr.com): darken lesson keys colors

🔧 What does this fix? 🔧

darken lesson key background colors
before:

after:

🗒 Checklist 🗒

[x] I have read and followed Catppuccin's contributing guidelines.
[x] I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

@TadoTheMiner fwiw the CI will automatically ping you on pull requests changing your userstyles, looks like you haven't yet accepted the invitation to the organization maybe? After that any subsequent PRs should at least :)

I appprove


ubint logical bitwise operator

implement the logical bitwise operators of apa::ubint class.

.boolean() method that returns true if the ubint instance is not zero.
& bitwise logical and
| bitwise logical or
^ bitwise logical xor
&= assignment bitwise logical and
|= assignment bitwise  logical or
^= assignment bitwise logical xor
~ bitwise logical not

#33


Bundler integration

Is your feature request related to a problem? Please describe.
It would be great to have a bundler integrated.
Describe the solution you'd like
Integrate one of the popular bundle.

Yes, Webpack is must nowadays :)


⚠ Secret Website 3 has degraded performance

In 3eb9b3d, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 11436 ms

Resolved: Secret Website 3 performance has improved in d6d0e9c.


Performance Issues

Upon installation of this extension, VSCode’s performance is reduced drastically. Specifically, typing performance goes down the drain, wile everything else remains as snappy as it normally is.
I don’t quite know what could cause this, but I thought it might be the core editor itself for a while, until I remembered that this extension was installed.
Disabling it globally resolved the problem immediately.
I don’t quite know how to debug these kinds of things – happy to help if I can, but would rather just leave it there in case anything springs to your mind as you read this.
Many thanks!

Well... I don't know what it could be.

Specifically, typing performance goes down the drain

There is an early return on the extension only to do the further operations if it's an ftl file:
https://github.com/macabeus/vscode-fluent/blob/99d8ddd42ae2c8a3e6a11fcf3fc087139afea87f/src/extension.ts#L38-L41
https://github.com/macabeus/vscode-fluent/blob/99d8ddd42ae2c8a3e6a11fcf3fc087139afea87f/src/utils.ts#L6-L7
Maybe you are using another extension that doesn't work well with this one?
Or it can even be an issue from the new vscode version?
If you could try to open an issue on vscode repository and try to debug (I don't know how) it would be very useful.

Thanks for the quick reply @macabeus. I don't know how to debug either, and don't have the time right now to try find out. In the meantime, I'll open an issue on the vscode repo and point it back to this one.

They closed the above issue 😅
I will try and make some time this weekend to debug (after finding out how 🙃).

One thing I did notice is that ripgrep pops up in the process explorer, using a large amount of CPU. The moment I disable the extension, the process is no longer spawned.

@mikerockett Thanks for the help.
I'm wondering what could be making the extension floods ripgrep processes...

is it happen on every file or only when the filename ends with .ftl?
if you remove the whole onDidChangeTextDocument hook on extension.ts (lines 38-59), does the issue still happen?
likewise the above item, if you remove the call of updateGlobalState and/or updateDiagnosticCollection within onDidChangeTextDocument, does the issue still happen?
can you confirm that it doesn't happen when opening a new .ftl file?

@macabeus Thanks, I’ll make a little time to help debug this. Where/how exactly do I go about adjusting these files?

@macabeus What I’m asking is how do I get to those files? Is there a specific way to go about modifying installed extensions?

Firstly, I would recommend you to uninstall the installed extension (it isn't strictly necessary, but it can be useful to not be confused with the extension being developed and the production one).
Or install VS Code Insiders to have an isolated VS Code.
Then, you can clone this repository, open it on VS Code/VS Code Insiders, and use the Run Extension task to run the develop extension locally.
Note that there is no hot reload. You should run this task again after every change on the extension source code.
Feel free to ask me anything else.

Thanks, sounds easy enough – I'll hop on it now.

Sorry, and to answer your earlier question, it happens when I edit any file, not just .ftls.

I've played with it a bit, and so far, I’ve noticed that this only happens when a workspace is open. If it’s just a folder that’s open, I don't get any rg/ripgrep processes at all.

if you remove the whole onDidChangeTextDocument hook on extension.ts (lines 38-59), does the issue still happen?

Yes, it does.

I guess it could be related to the code action.
VS Code recently made some changes related to code actions, and vscode-fluent's code actions only work on workspace.
Can you comment out registerCodeActionExtractStringToFluent() on extension.ts and see if it fixes the issue, please?

Your guess appears to be correct – commenting that method call out fixed it.

Good!
I really think that it's an issue because of the recent VS Code changes on code actions.
In theory, there is nothing to be done on vscode-fluent's side.
It's an issue on VS Code and should be fixed there.
But since @meganrogge closed the issue, we would need to open a new one being explicit that this extension had no changes in the 11 months and it started to be slow after the new VS Code realease, and it's related to code actions.
But in the meantime, you can try to play with the new code actions API and see if using them fixes this issue.
I didn't check it yet. I don't know how they are and how they can be useful for vscode-fluent.

Probably a good idea to open a new issue for this (I was originally thinking of saying that the original issue should be re-opened as this extension is what’s being used to figure out where the problem is). Would you mind opening it, or shall I?
I don't see how code actions could be beneficial to Fluent, at least not for me anyway. I tend to stay far away from code actions and just do my own thing. If corrective action is needed, I do it manually. Same applies to refactoring.

Would you mind opening it, or shall I?

No worries. I can open it today later, after doing a few more tests on it.
Thanks for the help!

I opened the issue, and I fixed the tests. It looks like that now VS Code is postponing a little more time to start the extensions on workspace, and I needed to set a timeout now here (see patch below). Probably there are better ways to do it, but it works for now.
If you want to try to fix it, you now have automated tests.
To run it, change the VS Code runner to Test Extension - With workspace.

diff --git a/tests/with-workspace/code-action.test.ts b/tests/with-workspace/code-action.test.ts
index 8bbaa3a..7c009ac 100644
--- a/tests/with-workspace/code-action.test.ts
+++ b/tests/with-workspace/code-action.test.ts
@@ -12,6 +12,8 @@ describe('#Code Action', () => {
           },
         },
         async (mapFilenameToUri) => {
+          await new Promise(r => setTimeout(r, 1000))
+
           const codeActions = await take.codeActions(
             mapFilenameToUri['index.js'],
             new Range(new Position(0, 0), new Position(0, 9))
@@ -33,6 +35,8 @@ describe('#Code Action', () => {
           },
         },
         async (mapFilenameToUri) => {
+          await new Promise(r => setTimeout(r, 1000))
+
           const codeActions = await take.codeActions(
             mapFilenameToUri['index.js'],
             new Range(new Position(0, 0), new Position(0, 9))
@@ -65,6 +69,8 @@ describe('#Code Action', () => {
           },
         },
         async (mapFilenameToUri) => {
+          await new Promise(r => setTimeout(r, 1000))
+
           const codeActions = await take.codeActions(
             mapFilenameToUri['index.js'],
             new Range(new Position(0, 0), new Position(0, 9))
@@ -88,6 +94,7 @@ describe('#Code Action', () => {
             },
           },
           async (mapFilenameToUri) => {
+            await new Promise(r => setTimeout(r, 1000))
             const codeActions = await take.codeActions(
               mapFilenameToUri['index.js'],
               new Range(new Position(0, 0), new Position(0, 9))
@@ -120,6 +127,7 @@ describe('#Code Action', () => {
               },
             },
             async (mapFilenameToUri) => {
+              await new Promise(r => setTimeout(r, 1000))
               const codeActions = await take.codeActions(
                 mapFilenameToUri['index.js'],
                 new Range(new Position(0, 0), new Position(0, 9))
@@ -154,6 +162,7 @@ describe('#Code Action', () => {
                 },
               },
               async (mapFilenameToUri) => {
+                await new Promise(r => setTimeout(r, 1000))
                 const codeActions = await take.codeActions(
                   mapFilenameToUri['index.js'],
                   new Range(new Position(0, 0), new Position(0, 9))
@@ -187,6 +196,7 @@ describe('#Code Action', () => {
                 },
               },
               async (mapFilenameToUri) => {
+                await new Promise(r => setTimeout(r, 1000))
                 const codeActions = await take.codeActions(
                   mapFilenameToUri['index.js'],
                   new Range(new Position(0, 0), new Position(0, 9))
@@ -220,6 +230,7 @@ describe('#Code Action', () => {
                 },
               },
               async (mapFilenameToUri) => {
+                await new Promise(r => setTimeout(r, 1000))
                 const codeActions = await take.codeActions(
                   mapFilenameToUri['index.js'],
                   new Range(new Position(0, 0), new Position(0, 9))

@mikerockett I opened the issue following your report.
I was trying to reproduce it locally, but I can't. Firstly I tried to reproduce on my macOS, but I can't.
Since you are using Windows, then I opened Parallels, and I can't see VS Code spawning ripgrep there as well.
See the video below:
https://user-images.githubusercontent.com/9501115/190001524-5794e3f3-3f0d-4d11-a4fa-7bb053af2f92.mp4
Can you record a video to show me how to reproduce it, please?

@macabeus I’m not running Windows, am on a Mac. I’ll try and record something today.

https://user-images.githubusercontent.com/4586280/190062330-6764da5a-1387-45dd-ab5d-80288b42edf4.mov
The lag between keystrokes is a little difficult to identify from a video, but it is very noticeable when it happens. As you can see, process explorer shows several rg processes spawn up and shut down in rapid succession.

And here’s a video with the extension disabled – no rg processes, no lag.

I just noticed something:

Notice how the ftl extension is not prefixed with !, whereas all of the others are. Is it meant to be like that?

@mikerockett Well... The issue was closed since the delay in a reply. I'm traveling and I won't have any time soon to do further work now.
If the root of the issue is the await workspace.findFiles('**/*.ftl'), in theory, we can avoid it by checking only when a new file is added/removed at the workspace.
If you have time, you can do it.

@mikerockett Feel free to one a PR. A kick-start is a good step to deliver a big change later.
I'm not working on this extension anymore, but I can at least try to help you.

I realised that we actually may need a file-system watcher here to accomodate changes to the workspace that were not done in VSC itself

Did you check about chokidar?

Fixed on https://github.com/macabeus/vscode-fluent/releases/tag/1.0.1


BAU: Remove reference to possible absence of core identity JWT

Why

This can never happen in a P2 journey at the moment, as if identity is not proven, then the RP gets an access_denied error
This means that they do not have a code/token to use to make a userinfo request in the first place
It is therefore misleading to suggest that a userinfo response is possible without the core identity JWT in a P2 journey

What

Remove reference to possible absence of core identity JWT

Technical writer support

Yes; would appreciate @elenaschwan review in particular please

How to review

Confirm that the removal of this wording is not problematic for the wider context
Confirm that you agree the wording was misleading and that removal is the best thing to do as opposed to rephrasing

@galund Can I get your input on this please? I remember we discussed this at the time of writing.

We put this in so that RPs would code defensively. When we have mitigations in place, we need the OpenID/OAuth journey to be successful, because we want to return a FID code in the UserInfo response.
However, in that case, we would not return a Core Identity JWT.
This situation ought to occur quite soon as there was a clear intention to get at least some mitigations working soon, which implies some FID codes should be generated. When that might happen is something you should check with @erino or @kerrr  or David P.
There are also future cases where we might want to return self-asserted names and addresses, even if the user couldn't prove their identity, and RPs should code defensively against that situation too, even though we haven't defined how it would happen.
So I don't recommend approving this PR, and if this wording is causing confusion for RPs then potentially it should be expanded on rather than removed.

To add a little context, we have received feedback on this content from RPs that it is confusing in light of the way the system currently works. It sounds like future changes will bring the actual system behaviour into line with what the docs already say, but there is some practical cost until then to keeping these docs unchanged.
Depending on how soon the changes discussed above are likely to take to come into effect, it may still be worth improving our docs for the interim period, to avoid any further confusion. After all, docs can change pretty dynamically, and RPs will (legitimately) assume that docs reflect current state, rather than future ambition. As noted by others, I'm sure there is some formulation of words that neither misrepresents the current state of the system, nor encourages RPs to assume that this aspect of the interface is set in stone. I do not know what those words should be, but I am simply flagging that the potential for RP confusion is not purely hypothetical.

Maybe we can be more explicit, we could write something like

GOV.UK One Login identity proofing can fail in one of several ways, and by detecting the failure mode you can help the user find an appropriate next step. If there is an OAuth error [link to section about OAuth errors] then you should offer the user another chance to use One Login to prove their identity, because they need to sign in to One Login again. In this case you should also offer a route to alternative ways to access your service, as in some cases users will already have realised that they cannot (or do not wish to) use One Login.
If the OpenID Connect journey is successful but no Core Identity JWT is returned, then you must offer the user another way to access your service, because they have successfully signed in but could not prove their identity. You may use their contact details (such as email address and phone number) to help them access your alternative options. If a Failure Identifier (FID) code is provided, this may give you more information about why the user failed the journey [link to content about FID codes - right now this should just say "One Login does not yet provide FID codes."]

That sounds fair @galund. I only opened the PR because I thought it would be a quick/uncontroversial change, but can see it's more nuanced from your perspective. I'll close this PR, since straight deletion isn't what's wanted.


expect(nil).notTo.beNil; doesn't fail

I tried the follow expectation:
expect(nil).toNot.beNil;
expect(nil).notTo.beNil;
expect(nil).to.beNil;

but all of them were not failed which first two should be.

You are missing the parens to invoke the matcher beNil e.g.
expect(nil).toNot.beNil()

Gosh!  Maybe try to let the compiler complain this situation when this happens.
Thanks for your rapidly reply.


Modified code to make the table more readable in report.md.

@mark-velez can you try now? I pushed an update.

The value for parsing property in the log is sometimes set to numeric value 0 instead of a boolean value. One side effect is the column Parsed File may be checked when the file hasn't even been received.

Made the fix. I changed it so it put false instead of 0.

I'm now seeing many duplicate records. Sorry, this bug may have been there already, but I'm only seeing it now. Duplicates are not in the database, they are being written to the file by export_log(). My guess is that results is preserving the records from each iteration of the outer loop, causing them to get rewritten here.


Allow check_mjml_command() to be skipped on app start

Creating this issue in response to performance issues observed when the mjml app was included in installed apps.
We observed a slowdown of several seconds for app starts, restarts/reloads, and test runs, due to the check_mjml_command() invocation in MJMLConfig.ready(). As best as we can tell there is currently no way to avoid this performance hit on every app start/test run/reload.
Once a server has been configured in a stable environment, the administrator should have some level of control over whether this command is invoked every time a django process starts.
Our suggestion is to include a simple boolean setting (MJML_SKIP_CMD_CHECK?) which will allow an administrator to have fine-grained control over this startup behavior.
(PS: Thanks for creating this great library!)

This possibility will be implemented in next release. Thanks.


Feature/eslint checker plugin

Inspired by the existing Typescript Checker Plugin. This checker is a more bare-bones version of the typesript plugin, and doesn't have much in the way of customisability or testing yet.
I have this working for my personal project which uses next-js+typescript, but I haven't tried this using other projects like create-react-app or bundlers like webpack.
I am also unsure what the best way to add the types for StrykerOptions, I wish to add a lintConfigFile?: string, but I only saw a big interface defined in src_generated which I thought I shouldn't touch.
Finally apologies I didn't open an issue before, I only just started on this earlier today and it all came together quite quickly

Progress:

[x] Implementation
[x] unit tests
[x] integration tests
[x] e2e tests:

[x] mocha-javascript-eslint
[ ] jest-js-eslint
[ ] jest-ts-eslint
[ ] jest-old-version-eslint
[ ] other e2e tests?

I don't think it is needed to have an eslint e2e test for each test runner. My reasoning is: checkers are pretty isolated from test runners. The added value is minimal.
Rather I'm now thinking the following e2e tests:

A JS project with eslint recommended rule set
A JS project with eslint type-aware recommended rules active
A TS project with the typescript-checker AND eslint type-aware recommended rules active.

@TimLehner what do you think?

Yes, that sounds much better 👍

@nicojs I have implemented the requested e2e tests. I think this is now ready for a proper review

@TimLehner I've got time to look at this tomorrow and next Monday. The build is failing because of some dependency stuff, which I've fixed yesterday on master. Would you mind merging those changes in your branch?

Thanks for the push rights! Will be looking at this today 👀

I think I've addressed the majority of your comments, let me know if I've missed anything

I've was finally able to merge # which allows us to progress here. I've updated the code, file descriptions are now being passed into the constructor.
Also did some more work:

rename e2e tests to start with the name "eslint", that makes more sense IMO (i was looking for 'eslint')
Ive added a e2e test for the validation schema
I went ahead and changed the config setting to be grouped under eslint. That allows us to expand on eslint settings in the future. This is also what we did for mocha, karma, etc. The tsconfigFile is an exception, because Stryker's core also uses that setting.
Ive added the vscode config to easily run the tests from vscode

I was looking at the report in the e2e tests, and was not happy with the result TBH:

As you can see, there are 3 linting errors here. However, these are all false negatives in my opinion. Maybe its better to whitelist certain rules, instead of the blacklisting approach.
@TimLehner what do you think about that?

Hmm, I think you make a good point on the false negative there, whitelisting would be useful, then if there is a specific surviving mutant you dismiss due to your lint rules, you can specifically enable the relevant rule and use Stryker as normal.  What was the reason for you to embark on this journey?

Apologies for the delay in my response, I've been distracted.
It's tricky, since my initial motivation were a number of rather niche react-specific ESLint rules, namely: react-hooks/exhaustive-deps
Although I have also found it too be potentially too aggressive there. I'm not sure what your thoughts are on this use-case?


OAK-10341 Tree store

Ready for review.

Just my opinion, but I see no logic that addresses the logic or readability of the TreeStore. Wouldn't it have made sense to have some reviews on that before merging?

I see no comments that address the logic or readability of the TreeStore

Just documenting the tree store (alone) wont resolve that problem. I think we are missing high-level documentation of the implementation for many many features. Including the blob store, the segment store, the document store, oak-core, oak-jcr, etc. I think we should discuss what implementation level-documentation is needed in general. I view that as an independent problem.


make reconnecting-websocket a direct non-dev dependency

Codecov Report

Merging #201 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #201   +/-   ##
========================================
  Coverage    65.14%   65.14%
========================================
  Files           15       15
  Lines          766      766
  Branches        87       87
========================================
  Hits           499      499
  Misses         246      246
  Partials        21       21

Flag
Coverage Δ

#integration
38.25% <ø> (ø)
:arrow_up:

#unit
64.88% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbbea39...38bbe25. Read the comment docs.


Automated cherry pick of #4369: Fix base-windows Dockerfile and script

Cherry pick of #4369 on release-1.9.
#4369: Fix base-windows Dockerfile and script
For details on the cherry pick process, see the cherry pick requests page.

/test-windows-e2e

@XinShuYang I suppose we can close this since we maintain 1.10 and 1.11 for now?


[WIP]: Empirical p-value NB

@dhimmel I randomly sampled 5000 rows (so that the computation won't take all day) and did the simplest empirical p-value calculation, as we discussed. Here is that distribution

I will try to overlay this with a permutation asap

I randomly sampled 5000 rows

Good idea.
Did you change the p-value calculation to be :skull: simple... i.e. no multiplication and just a single inequality comparison?


Update 「messagegenerator.py」 for Teams Notifications Using Power Automate Endpoint

With the deprecation of incoming webhooks for Microsoft Teams, it is necessary to update messagegenerator.py to enable Teams notifications via Power Automate. The modification should allow the script to send notifications to a Power Automate workflow endpoint, which will handle the routing to Teams channels. This change ensures continuity in notification delivery and leverages the capabilities of Power Automate to enhance Teams notifications.

I actually went and got this working earlier today and tested using orgs. Ill put the code in a PR in a short bit.
Just be ware when you create the workflow using Teams, the default setup doesnt work. It needs to be put together like this:

Submitted, although the card is pretty big in the teams window so I am looking at making soem way to "expand for more".

Tidied it up with an accordian view on the ARN and Description


App closing when inviting friend or generating invite link

Since yesterday I'm experiencing this problem when I try to use use the app. I tried reinstalling, running the program as an administrator and testing it with multiple games to no avail. Before yesterday it worked just fine.
I'm currently running the app on Windows 10 64-bit on the Steam Families Beta (Again, didn't have any issues even though I'm using the families beta weeks ago).

Client Beta is not supported.

Client Beta is not supported.

That was it, thank you! I turned off the beta client and was able to play again.


Custom Serializations

I was wondering if there was a way to implement something to replace PHP's \Serializable interface and use that on all of the data structures. With a Serializer interface, so that behaviour can be attached to actually recreating the entities themselves.
Main reason I'm after this is because I have managed Doctrine entities everywhere, and it would be useful to keep them around instead of a shallow copy of them. With an unserializer implementation, I could look for the type and just keep the id and class in the serialized string.
This would break a few things, one major drawback I can imagine is that whenever you serialize/unserialize a workflow, you would need to specify the serializer implementation so the class can trickle down and be available throughout the tree. I wouldn't really want this to be globally available or kept in a registry anywhere because, for me anyway, it would need to be a Symfony service entry.
Also, early on, I wanted to push some data to the frontend React app, so a json version of the tree would be helpful as well.
I intend to work on this, but I was wondering if anyone had any alternative ideas/solutions or different models for the concept.

Serialized objects have often been broken at PHP level. This would be a time to remove all uses of \Serializable in Workflow objects including StateMachine objects. If so, our SerializableInterface will be introduced instead. Workflower or PHPMentorsWorkflowerBundle will be able to provide a JSON serializer (for example, by using Serializer) as the default serializer. What do you think?

I'm in the middle of trying to get something to work, this commit creates a json string which might sort of kind of work.
Still working on it, haha. So far, I've only looked at the serialization.

The unserializer actually gets pretty close. This was my attempt.
It actually looks pretty good. The dates are obviously wrong, and the Stagehand stuff is just a massive string, but everything looks in-tact.


Safety Requirements

Required before submitting for review:

[ ] Implement the free OpenAI Content Filter to prevent Unsafe (CF=2) completions from being returned to the end-user.
[ ] Authenticate end-users (e.g. via username and password) and send end-user IDs](https://beta.openai.com/docs/usage-guidelines/4-know-your-customers) with each request.
[ ] Abide by our content policy.
[ ] Do not permit end-users to input custom prompts (i.e., end-users should not have a Playground-like interface where they choose the general goal of the prompt).
[x] Do not permit automated posting to other sites (including social media).
[x] Do not permit automated execution of model-generated code.
[ ] Implement end-user rate limits of no more than 60 requests per minute.
[x] Expose your service to end-users only through a front-end (i.e., no programmatic API access, no bulk uploading/processing).
[ ] Disclose clearly and periodically to end-users that they are interacting with an AI system, and flag relevant limitations.
[x] Avoid anthropomorphising the AI system to end-users in a way that could emotionally manipulate or confuse end-users (e.g., do not use language implying that the system is sentient).

For item #4:

Do not permit end-users to input custom prompts (i.e., end-users should not have a Playground-like interface where they choose the general goal of the prompt).

While sqliterate does not allow them to choose the general goal (other, defining text is added to the prompt no matter what), we can try to address this further

Item #1 and #4 will be addressed with provided content filters


feat: added basic room logic

Looks good for now. But I think we should talk about our object model at some point.

I think I'd like to clean that up right away.

@overflowerror can i merge or do you want review it again?

@overflowerror can i merge or do you want review it again?

I think you can merge.


Adding node.js built-ins as a dependency should be considered a breaking (major) change

In v1.31.0 ENS support was added. This version added @ensdomains/ensjs as a dependency to onboard.js, and was treated as a minor version bump to v1.31.0.  When upgrading our onboard.js package from 1.27.0 to the latest version, it turns out that v1.31.0 introduced a breaking change for us, because @ensdomains/ensjs seems to rely on the global, process.env, and Buffer node.js builtins.
Many build tools such as Webpack v4 automatically polyfill these node modules, but newer build tools such as Webpack v5 and Vite do not—they require explicit polyfills during the build step. Many devs try to avoid relying on node.js packages that require polyfills for the browser, but it's understandable that we are unable to do that entirely since onboard.js has dependencies that rely on many of these, including crypto, http, and https
However, I think it's worth considering the addition of node builtins as a breaking change because onboardjs is designed for a browser, and many browser build tools do not polyfill these builtins. Therefore anyone using Webpack v5 or Vite will likely have their app broken when upgrading to v1.31.0 or later (unless they already have those builtins polyfilled), and if they jump ahead by many minor versions, it can be hard to track down which version introduced this breaking change

@mds1 Thank you for this feedback. I agree with you as with ens support we did not make it opt-in. However, I am curious to know if you are building Onboard.js ad including hardware wallets as those wallets will also not build unless you are using Webpack v4.
Which build tool are you using?

We are using Vite as the build tool. Right now the current list of selected wallets in this particular app is metamask, walletConnect, torus, ledger, lattice, though admittedly that's just a default set and we haven't tested any of them yet aside from MetaMask.
I did need to add polyfills for various modules to get things up and running, though it's possible I'm missing some additional polyfills given that we haven't actually started testing wallets yet.
In this particular case we already handle ENS resolution on our own and therefore don't need the onboard.js ENS functionality, so it is a bit frustrating to be stuck at v1.30.0. For any features, fixes or new wallets we want to support, we'll have to polyfill node.js built-ins that we don't use, which adds bloat to the bundle size and isn't ideal from a security perspective 😕

@mds1 I know it isn't the exact solution you were anticipating, however, to improve your client side bundle size, I made ENS a dynamic import such that it will not get included in the final build should you decided not to use that feature.
In the future we hope to make Onboard more modular where you can choose which features you would like to be included in your build rather than needing to install everything.
Please let me know if this at least partially solves your issue and feel free to re-open this issue if need be.
Also if you need any assistance with your build configuration don't hesitate to reach out on discord and DM me.

Awesome, thanks a lot @taylorjdawson—I'll give that a try soon and ping you on Discord if there's any issues.
Also, a more modular Onboard sounds awesome. Excited to hear that!


Updated sorting and filtering feature in Products section issue Adding of a refine(filter) functionality current ,based on the price , discount , brand name in respective products section. #80

done issue #80
#80
https://github.com/Niharika0104/TrendTrove/assets/132948936/1a161506-b46c-4d0f-ba1c-205f9e3a20ce

filtering by the price, I am getting an issue

looks amazing! @jeevan10017  but there are merge conflicts please resolve them.

@Niharika0104  Conflicts resolved

@Niharika0104

@jeevan10017 What issue are you facing while filtering price @chirantanbanik Can you help him regarding this.

@Niharika0104 @chirantanbanik ,
Issue with sorting price from low to high and high to low
-> It is sorting independently for 3-digit prices and 4-digit prices.
For example => If I select the sort option (low to high)
products sorting first with ₹1000  -> ₹3300 (Highest price of product)  then ₹ 329(lowest price of product) -> ₹ 999
Logic used for it
` updatedData.sort((a, b) => {
const priceA = parsePrice(a.discountprice);
const priceB = parsePrice(b.discountprice);
  switch (selectedSort) {
    case 'price-asc':
      return priceA - priceB;
    case 'price-desc':
      return priceB - priceA;

}`


Update for latest stdlib

Hello!
The stdlib is undergoing a latest round of deprecations. There's a bunch of errors being emitted by this library, it would be fab to have them fixed!
Thank you,
Louis

Hello! Wow there were a lot of them in this package. This should be fixed in v5.1.0. Thanks for the ping!
Also there is still a warning when compiling on JS about an unsafe int. I am working on another branch that reduces the base unit of time from nanoseconds to microseconds, which should resolve this.

Thank you 💜
Is this OK to close now?

Yes! Closing now


fix init typescript template

When I run the command as documented, I got the following error.
info Fetching template react-native-template-react-native-template-typescript...
yarn add v1.6.0
[1/4] 🔍  Resolving packages...
warning jest > jest-cli > jest-config > jest-environment-jsdom > jsdom ><EMAIL_ADDRESS>use String.prototype.padStart()
warning jest > jest-cli > jest-config > jest-environment-jsdom > jsdom ><EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
error An unexpected error occurred: "https://registry.yarnpkg.com/react-native-template-react-native-template-typescript: Not found".
info If you think this is a bug, please open a bug report with the information provided in "/Users/toda/project/IfReward/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
yarn remove v1.6.0
[1/2] 🗑  Removing module react-native-template-react-native-template-typescript...
error This module isn't specified in a manifest.
info Visit https://yarnpkg.com/en/docs/cli/remove for documentation about this command.
warn Failed to clean up template temp files in node_modules/react-native-template-react-native-template-typescript. This is not a critical error, you can work on your app.
(node:42357) UnhandledPromiseRejectionWarning: Error: Command failed: yarn add react-native-template-react-native-template-typescript
    at makeError (/Users/toda/project/IfReward/node_modules/execa/index.js:174:9)
    at Promise.all.then.arr (/Users/toda/project/IfReward/node_modules/execa/index.js:278:16)
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:42357) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 3)
(node:42357) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

When you execute the changed command, the following log is output and init completes normally.

Refs #1777.

@Simek
#1777 is docs/getting-started.
This Pullrequest is docs/typescript.
Is there any difference?

Since  #1777 we have changed the docs structure. The reason for you issue is the same as stated there.


Include explicitly committed files

search.useIgnoreFiles is a great setting, but it would be great if it didn't also exclude files that were explicitly committed in spite of .gitignore

Hmm, we rely on ripgrep upstream for useIgnoreFiles functionality. I would file upstream to see if they can do that, although I'm not sure if they actually key into the git state of things. Rather, I think that they just read the ignore files and act accordingly.

Will close this as 'not planned', since we are planning to continue following what ripgrep does.


Overhauled deployment events and logs

This PR

Increases the reliability of the deployment output in the event of networking issues
Implements our upcoming deployment events API
Suppresses HTTP/2 warnings
Makes some cosmetic changes and improvements
Improves instrumentation

Hasn't been tested thoroughly yet, but it's ready for early reviews

lgtm

Sweet! Going out on canary in a sec.


Support for Django 1.6 and 1.7

Currently updating some models to match the new 1.6 requirements (with deprecations scheduled in 1.8) in https://github.com/kevwilde/django-plans/tree/django1.7support
Waiting for a new release of ordered_models (see https://github.com/bfirsh/django-ordered-model/issues/41) before creating a pull request.

any progress here?

Any progress ??

This is fixed in #56


Consider port of VSTHRD010 to this project

The VSTHRD010 analyzer defined in vs-threading is the only analyzer in that project that is really VS-specific. We should consider moving that analyzer to this repo. The alternative would be to make that analyzer more generalized (data-driven), which may be a good idea anyway.

I'm making it more data driven. I haven't decided whether we should move it to this repo yet.


Frontend Web Development : CSS Animation added in Documentation

Description 📜
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes #1056
 CSS Animation Properties with live demo example

Type of change 📝

[x] Doc#umentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] Frontend Dev #HTML/CSS/JS

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Hello @ghulamyazdani @code-reaper08 , Pls check this once and let me know if I need to do some fixes or its fine

@ghulamyazdani @code-reaper08 I added more properties as well as many gifs.


Import from pypi

0.3.1 was released without the changes from #5. This PR is the result of importing 0.3.1 from pypi, reapplying #5, and the bumping the version to 0.3.2 to make it easier for your to push a new version to pypi.
If you can push this up to pypi, I'll submit a PR to home-assistant that bumps the version it uses! Thanks in advance! 😎

This should be pushed to Pypi now.


Fix non-GNU grep installer issue

The grep flag -P only exists on GNU grep, which is not the default grep
on macOS; the awk script used instead works and obtains the same value.
Also did some work on making it so that at least the amd64 version will
install on Apple Silicon Macs. This is suboptimal, but it should do the
job.

Hey @halostatue, sorry for responding so late. Thank you for fixing the issue!

Hey @halostatue, could you provide details regarding the Apple Silicon Mac install issue?

I’ll open a new ticket for this. I realized that I left a bug in this that needs to be fixed ASAP.


[BugFix] Fix ElasticSearch predicate timezone problem

Problem Summary:

Fix ES hang when BE enables HTTP_PROXY/HTTPS_PROXY
Introduce timezone properties time_zone for ES table/catalog. Because many users will insert data into ES with UTC time, but SR query from ES will use +08:00 time, it will occur user's predicates will not be matched. If the user SET time_zone=+00:00 in SR, the user will worry that may affect other SR query's correctness. So we introduce this property, it will affect specific ES table/catalog.

Example:
CREATE EXTERNAL TABLE es_table_timezone
(
    id int,
    create_date datetime
)
ENGINE=ELASTICSEARCH
PROPERTIES
(
    "hosts" = "http://<IP_ADDRESS>:9200",
    "index" = "bug",
    "time_zone" = "+00:00"
);

What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:disappointed: fail : 31 / 62 (50.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/connector/elasticsearch/ElasticsearchMetadata.java
0
1
00.00%
[79]

:large_blue_circle:
com/starrocks/planner/EsScanNode.java
0
9
00.00%
[142, 148, 149, 150, 151, 152, 154, 160, 193]

:large_blue_circle:
com/starrocks/connector/elasticsearch/EsConfig.java
0
2
00.00%
[33, 36]

:large_blue_circle:
com/starrocks/catalog/EsTable.java
29
48
60.42%
[222, 226, 236, 246, 260, 261, 262, 269, 270, 271, 279, 290, 297, 303, 412, 413, 417, 418, 462]

:large_blue_circle:
com/starrocks/connector/ConnectorFactory.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/connector/elasticsearch/PartitionPhase.java
1
1
100.00%
[]

Another way is to set a query-level time zone, which is unavailable per doc.
Can we use the CONVERT_TZ function as a workaround?