Solving issue #204

I have tried to solve issue #204 . Please check and let me know if I did something wrong and need correct it.
Otherwise please merge it.
This is the response we get for saved shows:

Thank you so much @manan2501 for fixing this!!


Bump package version in the Readme

Totally not necessary, but nice to have the latest one there.
Mechanically copied and pasted the old version myself, then wasted ~5 minutes looking into the warnings about deps() and package().
Thanks for this nice little package!

Thanks! :smile:


Update to support latest versions of Cycle (Cycle Unified)

Pulling in collection seems to be causing me to get the following error (as I don't appear to have anything else that relies on xstream-adapter, which seems to be no-longer supported in Cycle Unified): node_modules/@cycle/xstream-adapter/lib/index.d.ts(1,31): error TS2307: Cannot find module '@cycle/base'.

fixed in #37


RT model Two stage config

Hi tianweiy,
from papers ,we know the stage two also have some contribution to improve accuracy.
But  I can not found waymo Real Time 3D detection Two stage config ?

it requires some code changes. I will update a config and merge this branch into master once I get (probably in one to two week)

Thanks very mush! Your baseline code is very useful for driving the progress of 3D detection & Tracking.

When we can get two stage config for RT modeling ?? Thanks your effort.

I still get a few final exams until 15. Will work on this after finishing them

will push today

Thanks

just updated https://github.com/tianweiy/CenterPoint/blob/c4b4e0fc97ec6d42d6a31f559816d3305abdf750/configs/waymo/voxelnet/two_stage/waymo_base.py
two other tips:

you need a pretrained single-stage model and you can specify the path here https://github.com/tianweiy/CenterPoint-WOD/blob/5185b8af3c9785b6c6af4d360038c9649c4a9ce0/CenterPoint-dev/configs/waymo/voxelnet/two_stage/waymo_base.py#L22

for faster training, maybe you can consider caching the feature with a pretrained backbone and only train the second stage which is just a few layers of MLP (and will be significantly faster). However, this may need some 100 gb space.


Created Windows instructions and prerequisites

Please label this pull request with hacktoberfest-accepted.
I noticed this highly starred repo has no instructions for windows and windows server endpoints, so I added Microsoft's solutions and other goodies that users can enjoy docker with. After installation, windows users are able to follow the rest of the cheat sheet.

Thanks!


Improve logging by showing logged in user that triggers an API

When debugging, it's useful to know which API calls are triggered manually by logged in users.

@neolynx What do you think of changing cirrina logging format to emit something like this?
Oct 05 13:21:37 molior-test molior[50645]: [admin] <IP_ADDRESS> GET /api/status 200 in 0.007639s
Oct 05 13:21:38 molior-test molior[50645]: [admin] <IP_ADDRESS> GET /api/users 200 in 0.004822s
Oct 05 13:21:38 molior-test molior[50645]: [admin] <IP_ADDRESS> GET /api/nodes 200 in 0.001323s
Oct 05 13:21:39 molior-test molior[50645]: [admin] <IP_ADDRESS> GET /api2/repositories 200 in 0.005186s
Oct 05 13:21:39 molior-test molior[50645]: [admin] <IP_ADDRESS> GET /api/mirror 200 in 0.038432s

Note the "[admin]" logged in user.
The code to do that would be something like:
from aiohttp.abc import AbstractAccessLogger

class AccessLogger(AbstractAccessLogger):

    def _get_username(self, request):
        try:
            return request.cirrina.web_session.get('username')
        except Exception:
            return None

    def log(self, request, response, time):
        username = self._get_username(request)
        self.logger.info(
                f'[{username}] '
                f'{request.remote} '
                f'{request.method} {request.path} {response.status} '
                f'in {time:.6f}s')

and then use it as:
       self.srv = await self.loop.create_server(
            self.app.make_handler(
                access_log_class=AccessLogger,
                access_log_format='%r %s',
                access_log=self.logger,
                logger=self.logger),

We could also improve cirrina to accept an access_log_class and pass it in from Molior.

PR submitted: https://github.com/molior-dbs/molior/pull/34
Please review!


Pygame is very slow to plot images

Now , with recent improvements in CARLA fps, pygame has become
one bottleneck when running the manual_control.py example.
Pygame seems a good solution for the joystick/keyboard controlling part,
but not for plotting images.
Does anyone knows a good library for that ?
Is the current pygame implementation suboptimal ?

I've not tried it, but maybe you can take a look at pyglet.


Collapse citations/credits to compact version by default

Default compact citation/credit should be: "Powered by Esri | Landsat imagery courtesy of USGS, NASA, and Microsoft"
Full attribution shown upon hover over.

@robert-waterman please review this fix on DEV.

@vannizhang , verified fixed. Please close after you push to prod.


Allow to pass executablePath of browser in getOpenAIAuth

As @luphoria pointed out in #140, using the library is tricky for those who for some reason don't have the browser in the default path. With this PR, I fixed this problem by adding the ability to pass the executablePath of the browser directly into the getOpenAIAuth function.
This helps users who use alternative versions of Chrome, who have installed it in a different path or who just want to use another browser.

@MarvynSTAR I appreciate the PR, but merged a different one for this instead. See release https://github.com/transitive-bullshit/chatgpt-api/releases/tag/v2.5.1


Writing test cases in the application by mocking purchaseUpdatedListener

I would like to know how to mock/implement purchaseUpdatedListener for writing test cases for the purchase success and error scenario
Version of react-native
0.61.2

Closes via #1273


Add chunkbeforesend event handler

A use case for using chunked upload requires an MD5 hash to be calculated for each chunk prior to sending, then added to the form data. This allows the server to compare the client calculated MD5 hash against the actual data received, to provide an extra level of integrity checking, catching issues is large files before the end of the full upload. Other usages are conceivable.
The current chunksend handler is triggered after the form data has been initialised for the chunk request, therefore preventing updates to a chunk request to be made.
This PR proposes a chunkbeforesend handler, running just before the form data is initialised, allowing parameters to be added to the request. Let me know if this is acceptable or if you need changes.
With this change the following example can now be used:
$('#fileupload').fileupload().on('fileuploadchunkbeforesend', function (e, data) {
      data.formData.chunk_hash = chunk_hashes.shift();
})

In addition to the one line change to js/jquery.fileupload.js I also added the entry fileuploadchunkbeforesend in the Angular code. I'm assuming this is correct.
In the documentation I'd suggest updating https://github.com/blueimp/jQuery-File-Upload/wiki/Chunked-file-uploads#callbacks to
$('#fileupload').fileupload({maxChunkSize: 100000})
    .on('fileuploadchunkbeforesend', function (e, data) {})
    .on('fileuploadchunksend', function (e, data) {})
    .on('fileuploadchunkdone', function (e, data) {})
    .on('fileuploadchunkfail', function (e, data) {})
    .on('fileuploadchunkalways', function (e, data) {});

Also to https://github.com/blueimp/jQuery-File-Upload/wiki/Options#callback-options add the line
   .bind('fileuploadchunkbeforesend', function (e, data) {/* ... */})

and before https://github.com/blueimp/jQuery-File-Upload/wiki/Options#chunksend add

chunkbeforesend
Callback before the start of each chunk upload request, allowing final changes to be made to the request (such as form data updates) prior to sending.

Thanks a lot for your contribution, @philayres !
Special thanks for the hints to update the documentation.
Merged and done. ☺


bug: should not save the runtime data of plugin into etcd

Issue description
admin api will pollute and save plugin_conf into etcd when calling plugin's function check_schema.
e.g.  https://github.com/apache/incubator-apisix/blob/master/apisix/plugins/proxy-rewrite.lua#L111
Environment

apisix version (cmd: apisix version): 1.4
OS: centos7

Minimal test code / Steps to reproduce the issue

add a route with plugin proxy_write
view the route just added

What's the actual result? (including assertion message & call stack if applicable)
the runtime data of the plugin has be saved into etcd.
What's the expected result?
the runtime data of the plugin should't be saved into etcd.

only Admin API has this bug.

I think we should remove apisix.admin.plugins.check_schema, just check schema in sync_data

@wrl96 Your way is dangerous, we don't allow dirty data to be stored in etcd.

I will fix this bug


fix: only award redeem premium upto the secure threshold

2 significant changes:

Only award a premium for the amount of tokens required to bring the vault back to the secure threshold. Otherwise the vault could end up paying the premium for all of its tokens.
Rather than only considering issued_tokens to determine whether or not a vault is below the premium redeem threshold, now use the "to_be_backed" tokens, i.e. the tokens if all open issues and redeems execute successfully (= issued + to_be_issued - to_be_redeemed). This is required because otherwise additional redeems would again be able to de a premium redeem.

Since this significantly modifies audited code, I'd like to have 2 people approve this PR before we merge

I just realized that by doing the premium redeem, the collateral decreases. I didn't account for that in the premium cap calculation - should I? That's going to complicate the calculation


can't  phantomjs something

it must be change shell to bash after install phantomjs, this cmd can't directly work in zsh

phantomjs is installed globally using npm right? That seems like a PATH issue. Have a look at your bashrc file to see if you added some directory related to npm to your PATH.


Fix link in load_dataset docstring

Fix https://github.com/huggingface/datasets/issues/5387, fix https://github.com/huggingface/datasets/issues/4566

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Program enthusiastic


Bring back Controller.TryUpdateModel

Microsoft.AspNetCore.All 2.1.5
The name 'TryUpdateModel' does not exist in the current context

@pranavkm, I see async version, but there is no TryUpdateModel.
I will use this approach even if it looks more complicated.
TryUpdateModelAsync(user, ...).GetAwaiter().GetResult();

Use await TryUpdateModelAsync(...); in your controller action. Doing a blocking call (GetResult) may result in thread pool starvation and application deadlocks.

@pranavkm I cannot use await because my action is not async

@RoboBurned make the action asynchronous instead.


Correct URL for maven-metadata.xml file when using maven publication plugin to push to codeartifact

Expected Behavior
The plugin should create a URL for the maven-metadata.xml which contains the artifact version specified in the repository, this happens correctly for the artifact and the pom.xml file
Current Behavior
For the maven-metadata.xml the plugin creates a URL which does not include the artifact version, as a consequence, AWS codeartifact will respond with a 400 Bad Request
Context
Although the specified artifact and pom.xml file are uploaded correctly, the task fails, so i get a red build on Jenkins.
Steps to Reproduce
Define a publishin task:
publishing {
  publications {
    publicMyArtifact(MavenPublication) {
      def branchName = System.getenv('BRANCH_NAME')
      if(!branchName)
        branchName = 'local'
      def buildNumber = System.getenv('BUILD_NUMBER')
      if(!buildNumber)
        buildNumber = '-'
      groupId = 'com.company.project'
      artifactId = 'my-artifact.jar'
      version = 'v1'
      from components.java
      artifacts = ['build/libs/my-artifact.jar']
    }
  }
}

Define the repository:
 maven {
          name 'codeartifactRelease'
          url 'https://my-AWSaccount.d.codeartifact.us-east-1.amazonaws.com/maven/project/module/submodule'
          credentials {
            username = 'aws'
            password = System.getenv('CODEARTIFACT_AUTH_TOKEN')
          }
        }

Invoke the task:
  sh "./gradlew -i --full-stacktrace :publishPublicMyArtifactPublicationToCodeartifactReleaseRepository"

For the pom.xml and the artifact we will get the URL:
https://my-AWSaccount.d.codeartifact.us-east-1.amazonaws.com/maven/project/module/submodule/com/company/project/submodule/my-artifact.jar/v1/myartifact.jar-v1.pom
But for the maven-metadata.xml we will get:
https://my-AWSaccount.d.codeartifact.us-east-1.amazonaws.com/maven/project/module/submodule/com/company/project/submodule/my-artifact.jar/myartifact.jar-v1.pom
The version is missing causing codeartifact to reject the request.
Your Environment
My build is running on a Java-8 node on Jenkins.
Java version: 8
Gradle version: 7.2
Some informations have been hidden due privacy reasons but i hope the explanation of the problem is clear.

Thank you for your interest in Gradle.
This behaviour is expected and matches the Maven layout. maven-metadata.xml is not per version but per <groupId>:<artifactId>.
A publisher is supposed to download that file, update it and upload it again with the just published version information.
You will have to figure out how to allow this on the repository you are publishing to.


fix(debugging): Additional debugging

:tada: This PR is included in version 4.2.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Cannot create a new book with github repo

I just delete a book and then I can't create a new one...
Now I find no answer to this problem.
How could this happen?

We're deploying a fix, it should be fixed in a few minutes.

Oh, thx.


XIVY-3475 fix rcptt tests

https://jenkins.ivyteam.io/view/scrum-master/job/ivy-project-demos_test-connectivity-rcptt/job/feature%252FXIVY-3475_fix-rcptt/


Can´t edit .json of a custom Book

Maybe i´m totally stupid, but im not able to edit books via .json file.
i read the ingame wiki for creating a new book.
the problem is when i create a new book via shift-rightclick or by creating a new json i not able to re-edit it. for example:
created book (shift-rightclick) named it ABC
put in a crafting grid, then close editing gui.
went to config/enchiridion/books, opened the ABC.json, edited the item in crafting grid.
restart minecraft, opened book, change doesnt apply.
with another custom book i changed the name in json after ingame editing.
after opening it ingame the json were reseted to an empty book.
any ideas?
mc 1.7.10
forge <IP_ADDRESS>8
ench 2-1.7.10-2.0.2a
@joshiejack

no answer. just closed?

1.7.10 is not beeing supported anymore. I just tested that exact feature myself on the same version. Works just fine for me tho.

ah, ok. thx for the answer!


Rails 4.2.1 Images do not show in generated pdf

I have a bunch of images in app/assets/images/ when I render the html view the images are present as one would expect. When I render the pdf view via princely they are not present I just get something like this: Bd header70 b cc0e9cd02bd0b2ec1f31f22bbfe90be47fec42de002e9f5445603b82b492bdaa
In my controller I have this:
    render :pdf => 'ConsultantsQuote',
           :template => 'quotes/show_consultant',
           :handlers => %w[erb],
           :formats => %w[pdf],
           :stylesheets => %w[application pdf],
           :layout => 'pdf',
           :disposition => 'inline',
           :relative_paths => true

In my view:

  <%= image_tag("bd_header70_b.png") %>

What am I doing wrong? Thanks Paul Thompson

Same for me, images aren't render in pdf.

Just added in controller action flag relative_paths: false also if layout: false then need wrap view to html -> head and body


Splitted editor window, deleted source file

Description
What steps will reproduce the problem?

Split editor in two windows
open some files, such that they are sshown in tabs on both "splits"
delete one of the files in explorer

Sypder realizes the vanished source and offer to close the tab, but it closes only the tab in the the first split. The tab in the second split stays ope. This error raises while clicking on the second still opened tab.
Traceback
  File "C:\Software\WinPython\WinPython-64bit-<IP_ADDRESS>Qt5\python-3.6.6.amd64\lib\site-packages\spyder\plugins\editor.py", line 1368, in close_file_in_all_editorstacks
    index = editorstack.get_index_from_filename(filename)
  File "C:\Software\WinPython\WinPython-64bit-<IP_ADDRESS>Qt5\python-3.6.6.amd64\lib\site-packages\spyder\widgets\editor.py", line 1372, in get_index_from_filename
    return filenames.index(filename)
ValueError: 'X:\\SoftwareDev\\Python\\spmgut\\source\\spmgut\\io\\import_image.py' is not in list

Versions

Spyder version: 3.3.1
Python version: 3.6.6
Qt version: 5.9.3
PyQt5 version: 5.9.2
Operating System: Windows 10

Dependencies
pyflakes >=0.6.0  :  2.0.0 (OK)
pycodestyle >=2.3 :  2.4.0 (OK)
pygments >=2.0    :  2.2.0 (OK)
sphinx >=0.6.6    :  1.7.7 (OK)
rope >=0.9.4      :  0.11.0 (OK)
jedi >=0.9.0      :  0.12.1 (OK)
nbconvert >=4.0   :  5.3.1 (OK)
pandas >=0.13.1   :  0.23.4 (OK)
numpy >=1.7       :  1.14.5 (OK)
sympy >=0.7.3     :  1.2 (OK)
cython >=0.21     :  0.28.5 (OK)
qtconsole >=4.2.0 :  4.4.1 (OK)
IPython >=4.0     :  6.5.0 (OK)
matplotlib >=2.0.0:  2.2.3 (OK)
pylint >=0.25     :  2.1.1 (OK)

Thanks for reporting. We'll take a look at this in a future release.

This is a duplicate of issue #8814, which has a much better way to reproduce this problem.


fix(pkg): up deps, tweak up gh-actions

:tada: This PR is included in version 1.5.5 :tada:
The release is available on:

v1.5.5
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Correcting Invoice Posted with Incorrect Date

An invoice was posted with an incorrect date.  We are unable to cancel or correct because "You cannot cancel / correct this posted purchase invoice because the invoice is based on a purchase order."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 83c8f216-2ecd-ae0e-a754-05c14bebe5bf
Version Independent ID: 65149fe7-b68f-68a7-d37e-ac88469a289a
Content: Amend or Cancel Unpaid Purchase Invoices - Business Central
Content Source: business-central/purchasing-how-correct-cancel-unpaid-purchase-invoices.md
Service: dynamics365-business-central
GitHub Login: @SorenGP
Microsoft Alias: sgroespe

Thank you for the input - This limitation was missing in Help. Sorry about that.
I have added the following note in the Correct or Cancel Unpaid Purchase Invoices topic:
"This functionality is not possible on posted purchase invoices that are posted from purchase orders. To correct or cancel such a posted purchase invoice with slightly more steps, see Process Purchase Returns or Cancellations."
It will be available in Help within one week.
Regards
Soren

Good morning,
I have mistakenly accounted for an inventory purchase invoice with incorrect accounting date, 28/08 instead of 28/02.
How can I go about solving this problem? can you change the posting date?


Mobile landscape viewport fixes

Description:
Looks like some alignments are off on mobile viewports.
iPhone 14 Pro landscape:

Android Chrome landscape:

Tweaked according to specs in telegram. Hopefully I got it right. Note that android landscape will go to desktop view on some phones still, I think its the correct behavior.

QA passed


fix(wpa-pkgs): cidercollective.cider

because "?per_page=1" currently doesn't have beta builds you can change "?per_page=1" to "?per_page=5" for testing purposes.
You might need to check if PostResponseScript will work or not.
I used $UpdateCondition = $Response | Where-Object { $_.name -match 'main' -and $_.prerelease -eq $PreRelease -and $_.id -gt $PreviousReleaseId } for testing but reverted it.

@ItzLevvie please give "maintainers can modify" permission


Grunt connect task serves map files, but not the source they point to.

I've noticed that it's necessary to disable Javascript source maps to debug effectively, as otherwise it seems that the browser tries to load the original .coffee source, which isn't served as it isn't under dist.
I have limited coffeescript experience, so I don't know how well this debugging works in general.

Fixed once the webpack build is merged


Unable to see launches from newman run

Hi Team,
I am unable to see launches from newman run. However i can see  test item start/Success/Finish as well with save log on cli.
Start launch 12tzmgrckl6ezcht
Start test item 12tzmgrckl6ezci3
Start test item 12tzmgrckl6ezd4g
Start test item 12tzmgrckl6ezdga
Start test item 12tzmgrckl6ezdtk
Start test item 12tzmgrckl6eze64
Success start item 12tzmgrckl6ezci3

Could you please help me how can i see launches in report portal ?
D:\Postman> newman run .\InternationalPaymentInitiationcollection.json --insecure --reporters @reportportal/reportportal --reporter-@reportportal/reportportal-debug=true --reporter-@reportportal/reportportal-endpoint=http://10.192 .XX.1XX:8080 --reporter-@reportportal/reportportal-token=167ebff4-276f-47ba-bd6f-bxxxx92544075 --reporter-@reportportal/reportportal-launch=POSTMAN_TEST_PRAVIN --reporter-@reportportal/reportportal-project=test-automation -x
Start launch 12tzmgrckl6ezcht
Start test item 12tzmgrckl6ezci3
Start test item 12tzmgrckl6ezd4g
Start test item 12tzmgrckl6ezdga
Start test item 12tzmgrckl6ezdtk
Start test item 12tzmgrckl6eze64
Success start item 12tzmgrckl6ezci3

@avarabyeu or @DzmitryHumianiuk Can you please help?

@deepaleekhare31 question is right to the point )
@KatsiarynaTatarynovich rework of Postman (Newman) integration right in current sprint, thus it will be available pretty soon.

@DzmitryHumianiuk @KatsiarynaTatarynovich - Any updates on Postman (Newman) integration with Report Portal ? When we can expect to be available ?

@AmsterGet wasn't it released already?

@pravinupganlawar Hello!
We recently released a new package with version 5.0.0 (npm, github packages), release notes.

@pravinupganlawar please double check a new version and close issue if not relevant any more.
thank you.

I was able to find a work-around by removing the port 8080 from the URL

Hi there!
I'll close this issue as there has been no reaction for a long time, but feel free to open it again if you have any questions related to the topic.


 I will just hope someone jumps in and fixes it for me.

bors d+
Please merge when the mathlib3 PR is approved.

bors merge

By the way, I think that we should not have PR titles like this one, it is very uninformative. It should be something like feat: A quasilinear function is either monotone or antitone (mathlib#17801) with the mathlib#17801 part either in the title or in the description.

Sure, I'm happy to change.


UserGroups.myGroups() returns UserGroups where the user isn't a member of.

https://github.com/blockstack/radiks/blob/22c60f440ab5f7fae12bc63eaac07af0910f7366/src/models/user-group.ts#L90
Seems if keys is empty in the myGroups() method, it will return all UserGroups.

Is this related to #39 ?

I don't think so?

fixed by #91


Add support for manipulating form

Being able to add, remove, and edit the fields in the form object would be nice.
I'm currently trying to scrape a website where there are 2 fields of the same name on the form and one of them needs to be deleted. Are there already methods for that?

I'm not sure if I am doing it "correctly" per se however using the objects.fields.pop() method seems to have worked for me when I need to remove a field. The "add_field()" method works for adding fields to the form object. It took me reading a issue here to understand how to use it. Check out my post here for complete example.


Tracking issue for additional array size support: error[E0277]: the trait bound UInt<...>: ArraySize is not satisfied

hybrid-array relies on impls of ArraySize on individual typenum::Unsigned types, e.g. U1, U2, U3, which is a deliberate tradeoff versus generic-array which is able to support any array size.
These ArraySize impls are the linkage between typenum types and core arrays, which provide the underlying storage used by hybrid-array, and with it const generic linkage and significantly less unsafe code.
Unfortunately, you will encounter the rustc error message in the issue title if you attempt to use an unsupported array size.
Per #57, we are attempting to handle such cases as one-off requests for sizes which can be granted on a case-by-case basis, and gating them under the extra-sizes. It's unclear how well this will work in practice, but we are attempting it for now.
The main reason to constrain the number of supported sizes is a compile time cost as we add more impls of ArraySize/AssocArraySize. Compile times are not currently too significant but get worse as we add support for more array sizes.

As per my proposal in #78, I will need sizes for NTRU-prime which are U653,  U761, U857, U953, U1013,  U1277. I will also need to add the type U1277 itself. I am not fully aware if I will need more sizes, since I am not fully familiar with the mathematics behind NTRU but unless there is an objection, Kindly expect a PR for those very soon.

@oddcoder see how sizes are defined here:
https://github.com/RustCrypto/hybrid-array/blob/master/src/sizes.rs#L617-L811
It shouldn't be too hard to add.

#81 provides a solution for user-defined types, however it requires removing the supertrait bound on typenum::Unsigned which seems like it will cause additional breakages beyond what hybrid-array will already entail.
For the v0.2.0 release I'd like to punt on that for now, but it's something we can consider for v0.3.


Add attributes from Geojson to SVG

Hello,
Can we add some attributes from Geojson to SVG, with providing which properties or geometries in Geojson we need to add in SVG, with "geojson-to-svg-cli"?

What attributes do you have in mind? Custom user-defined attributes, exposed as data-* SVG attributes?

geojson-svgify, the library beneath geojson-to-svg-cli, already has an option computeProps(feature) which can be used for this. PR welcome!

I need "code" and "city" and "type" in geojson file to be added in my svg.
"properties": { "code": "1111", "city": "cityname" }
"geometry": { "type": "Polygon", "coordinates":  ... }
I have very geojson files to convert them to svg.

The readme of geojson-svgify only briefly mentions computeProps. It calls computeProps for every feature returned by geojson-flatten.
We would have to introduce a command line option that in turn uses computeProps to add attributes to the SVG elements.

OK. Thank you a lot.

Published as<EMAIL_ADDRESS>


Define rule DDF00008

I belive the desciption is correct, "'For each ScheduleInstance there should be either a
defaultConditionId or a scheduleTimelineExitId'
The comment text includes Dave IH's statement of the rule, which includes the extraneous information "Generally default is set, but if Exit is set then no default."  This is confusing.  The language "is set" is also unclear.
The Outcome Message is "For ScheduledInstance, there should be only one defaultConditionId OR
only one scheduleTimelineExitId, not both."  This is okay, though I would have left out the "only"s.


MSI: Make sure that file components are patchable

PR Summary
MSI: Make sure that file components are patchable
- avoid changing names and guids of components between builds as this prevents patch generation
- This required submitting the file generated by heat
- add code to make sure the generated file is not out of date
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[x] Not Applicable
OR
[ ] User-facing Documentation needed

[ ] Issue filed - Issue link:

Testing - New and feature

[x] Not Applicable or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] if the change is significant or affects feature tests

I wonder - is this implement RFC suggestion for root path C:\Program Files\PowerShell?

@iSazonov Only partially... During the work to make everything patchable.  The need for the changes in the RFC was discovered.  This does not change the actual install location.  This big change here is to fix the GUIDs for all the file components.  This allows the file components to be patched (using an MSP, which is required by Microsoft Update for Security Patches.)
After we merge most of the MSI PRs I have pending, I'll submit the main implementation for RFC.  I'll mark it as a WIP until the RFC is done.

@TravisEz13 Thanks for clarify. I don't understand how it works - it seems the change links component to root PowerShell directory. Main question is should we review rest components? And whether repair works for such components?

I already have and submitted two other PRs for all significant issues.  The main other issue is that in a patch only differences are applied to the original MSI.  We need to remove all references to the specific version numbers from the GUI.  Otherwise, when you are applying the 6.0.3 patch to 6.0.2 MSI, the patch will still say 6.0.2.  Perhaps there is a way to use the actual MSI version at runtime.  I'll have a PR for that sometime after this is merged.


Promote shape

@JohanMabille this seems to be working ok.
Check out my change to _or, _and and the meta function for promote_shape and promote_strides.
Name proposals welcome.

@JohanMabille I added a test in test_xutils.


CB-13672 Fix hybrid cloud test

Issue 1: AWS Freeipa, and YARN Datalake master instance groups receive the same name, so instead of creating a new instance group for YARN, the test framework used the one that was created for AWS.
The fix was to include the cloud platform in the test dto's name, so AWS and YARN receive different names.
Issue 2: Freeipa is no longer created by environment service, so the security groups set for the environment are not automatically applied to Freeipa instances.
The fix was to set the security group directly to the Freeipa request.

2 AWS test suites were run for this PR successfully
aws-ycloud-hybrid-cloud-tests: http://ci-cloudbreak.eng.hortonworks.com/job/cloudbreak-pull-request-builder-aws-test/22413/parameters/
aws-distrox-tests: http://ci-cloudbreak.eng.hortonworks.com/job/cloudbreak-pull-request-builder-aws-test/22412/


Can't slice result of find_by_tag

Here's example straight from my code:
all_raw_msgs = self.browser.find_by_id('messages').first.find_by_tag('li')
new_raw_msgs = all_raw_msgs[self.message_count:-1]

I get error 'slice(0, -1, None) is not JSON serializable', so I looked up source code and found this:
    def __getitem__(self, index):
        if not isinstance(index, int):
            return self.first[index]
        try:
            return super(ElementList, self).__getitem__(index)
        except IndexError:
            raise ElementDoesNotExist(
                u'no elements could be found with {0} "{1}"'.format(
                    self.find_by, self.query))

Why case of non-integer index is special? This is the line that makes attempt to slice fail. What is reason for this?
Thanks for your time.

this line that makes possible to execute a command in the first element without the first attr. e.g:
elements = browser.find_by_tag('li')
elements.click()

I believe that you found a bug that should be fixed. But I believethat convert the find_by_* return to list is a workaround for this problem:
all_raw_msgs = list(self.browser.find_by_id('messages').first.find_by_tag('li'))
new_raw_msgs = all_raw_msgs[self.message_count:-1]

Can you try it?

I'm having a similar issue, except I'm adding in the .html function. My code looks as follows:
post = browser.find_by_css('.fm-post')
block = post[0].find_by_tag('p')
notes = block[3:]
notes.html # or block[3:].html

I've tried multiple different types of simple declarations to try and print each p tag from index 3 on, including the list solution provided by @andrewsmedina but they all result in the slice error from the OP, just with different numbers.

@andrewsmedina A simple fix to this could be checking if the index is a slice or not:
def __getitem__(self, index):
    if not isinstance(index, int) and not isinstance(index, slice):
        return self.first[index]
    try:
        return super(ElementList, self).__getitem__(index)
    except IndexError:
        raise ElementDoesNotExist(
            u'no elements could be found with {0} "{1}"'.format(
                self.find_by, self.query
            )
        )


Allow for encoding in color

Created EncodeColor in order to create custom colored QR codes when writing to a file is not possible.
Also implemented the same fix as in #53 in order to run tests.

Can we get some attention to this PR? It's been 2 years and I think it's a very useful feature


Map filter invalid geo (Merge after product-styling)

[ ] joeferner
[ ] sfeng88
[ ] mwizeman joeybrk372 jharwig

Testing Instructions: Create an invalid geocoordinate (43, -999999)  and add to map product. Click fit (this will slow pan/zoom if the map passes that coordinate to open layers)
Points of Regression: None
CHANGELOG
Fixed: Prevent invalid geocoordinates from being added to OpenLayers that can impact pan/zoom performance. Will log a console warning.

Wait until after
https://github.com/visallo/visallo/pull/1365 is merged


05/11/2018 00:13 : Create Pull Request for branch master -> prTesting1_2018051100

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


ReferenceError: React is not defined

Hello,
I testing my react application with Mocha and when I run npm test I got the exception:
app/DOM/pure/landing-assets/logo.svg:3
React.createElement(
^

ReferenceError: React is not defined

In webpack config file I set this properties to svg:
{
  test: /\.svg$/,
  loaders: DEBUG ? ['react-hot', 'babel', 'svg-react'] : ['babel', 'svg-react']
}

How I can solve this problem?

@whois42 Are you depending on react in your package.json file?

@jhamlet sure

Hmmm... I need a little more information/context on how you are running your Mocha tests... are they going through webpack?
Is the a repository you can point me to?

"test": "mocha --compilers js:babel-register --recursive --require test/utils/dom.js --require mock-css-modules --require babel-polyfill --harmony-proxies"
Sorry, I can't show you project, because it's a closed source


Add share buttons to bingo overlay

Add buttons to share your bingo success on Facebook and Twitter

Fixed by #22


Add descendants query with a couple valid test cases

Adds a descendants query for ncbi taxa
This is the first query I've tested that uses a default value in its params. I had to do a lot of tweaking of the API to get it to work, but it should work now in the API's develop branch/tag.

Removed the unnecessary auth headers within these tests

Added the limit in the query (10k) with a comment about it at the top


fix: examples were using wrong image loader

https://github.com/cornerstonejs/cornerstone3D-beta/issues/149#issuecomment-1211028156


Adds form handling route called submit, and changes info.html with ch…

…anges to the form and adds new route to index.js and this resolves #43

Looks good. We should think about whether it's better to redirect to the \thankyou route, or just render the view of that page in the \submit route itself. I know that's something we discussed at some point during FaC, but I can't remember what the conclusion was.
p.s. You can write longer commit messages (with title and body separated out) if you omit the -m flag when committing.


Refactor JSON en-/decoding

My ideas for json were:

use a boilerplate-free library like circe or upickle
replace the renesca propery and parameter datatypes by JSON ASTs, as they are essentially json. Maybe use json4s for the AST?

After some experiments, I can say that upickle is very buggy. Circe works  very well,  is flexible and provides a great json ast to work with.


Added contributing document.

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

/cc @bradtopol @jichenjc

overall this looks like a good start and we can iterate on it. One question.  You say folks should use minikube. Any reason you picked minikube over kind? I heard kind was faster at least according to the other SIG Cluster lifecycle folks

Thanks @bradtopol , I updated the document to using Kind as you proposed. ;-)


Don't advertise the Ruby API anymore

It was dropped earlier this year because it was unmaintained and non-functional. See https://github.com/delta-io/delta-rs/pull/1102.

Closes #328

Thanks very much @manuteleco  - merging now!


Add script to clean-up unused AWS EC2 Instances and VPCs

@shivakunv It'd be better if the cleanup bot follows the same sequence of operations as laid out in the holodeck delete.go file

passed piepline :
https://github.com/NVIDIA/holodeck/actions/runs/12407157176/job/34637449418

@tariq1890
followed delete.go sequence:-
terminateInstancesInput
deleteSecurityGroup
Delete the subnet
Delete the route tables
Delete the Internet Gateway
Delete the VPC

@shivakunv It'd be better if the cleanup bot follows the same sequence of operations as laid out in the holodeck delete.go file

followed delete.go sequence:-
terminateInstancesInput
deleteSecurityGroup
Delete the subnet
Delete the route tables
Delete the Internet Gateway
Delete the VPC

@shivakunv Please amend the commit and retitle the PR as follows
Add script to clean-up unused AWS EC2 Instances and VPCs"

Thanks @tariq1890 for reviewing.
incorporated the review comments. PTAL
passed pipeline:-
https://github.com/NVIDIA/holodeck/actions/runs/12427716870/job/34698013023


Missing some images..

On http://thoughtbot.com/bourbon/ page missing some images..

example: in http://thoughtbot.com/bourbon/#border-image page under demo.

Thanks for pointing this out @cihad. Fixed.


Update FPI tests

This PR updates the existing FPI tests and adds one additional.

Existing tests were reworked to primarily check the correctness of the memory layout after the transaction execution.
A new test perform a more comprehensive check, asserting the correctness of the execution of the foreign procedure.

Closes: #917

During the rebase I noticed another issue, related to the FPI: in case a user wants to access the map storage slot, the internals of this map should be preliminarily loaded to the advice provider.
An easy way to solve it is to populate the advice provider the same way we do this for the account storage and code, so we can add the maps only if user want to access the map slots, but it looks like not the best UX.
We could populate the advice provider with this data during the TransactionContext building, but potentially it could be expensive in memory terms. Not sure what is the best option.

Also I noticed two more "structural" problems:

Currently the TransactionContext have both advice_inputs and tx_args fields, although tx_args already contains the advice inputs internally. I think we should remove the advice_inputs field and leave only tx_args: it will simplify the advice inputs management, I will be able to remove the clumsy code which populates the tx arguments with the advice inputs (here).
I think that it is very useful to have an opportunity to load the foreign account code to the TransactionContext, but in case we use the TransactionExecutor we have to different ways to do the same thing — probably we can optimize it. One way is to always use the account codes stored in the TransactionContext and then populate them to the TransactionExecutor (since we use context in the executor anyway). So our new load_account_code() function will become an internal function, which will be used during the creation of the executor, and the main (and probably only) way to provide the account code will be using the context. I think it will make the code more simple and less confusing, also improving the UX.

@Fumuran - now that #969 has been merged, could you resolve merge conflicts?

@phklive need this PR to be merged for his Oracle task, so I'll merge the current state into next, and address the issues I noted above in the follow up PR.


Add support for docker build nocache option via -Ddocker.nocache=true

I was having some trouble with a corrupted docker cache so added this to the plugin.

Thanks for the PR. Since a nocache option has been added to the build config, too, I added this feature a little bit differently.


Option to disable automatic top-level compendium folder

Since v11, Foundry allows folders in the compendium tab. dnd5e auto-creates a folder called "D&D 5e SRD" every time the world is booted up, and moves the SRD compendiums into it. This is in general a good thing, but some users may want to keep the compendiums in a different folder. The module will create the folder and move the compendiums even if the folder was previously deleted, which can be quite annoying if the user had a good reason to move them. There should be a configuration option to disable this behavior.

Known issue I think, has been around since the SRD was organized into folders, I think v12 Might fix it? Not completly sure tho

This is a core foundry issue rather than a system issue.

Tracking at upstream foundryvtt/9902


Windows: Added support for storage-opt size

- What I did
Added support for storage-opt size on Windows.
- How I did it
Added ExpandSandboxSize api to hcsshim, and called it after creating a sandbox layer.
- How to verify it
This does not work on TP5, but does work on internal builds. Manually tested currently, I will add a CI test gated on build number.
- Description for the changelog

Added support for storage-opt size on Windows daemons
- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Darren Stahl<EMAIL_ADDRESS>

Rebased after #23392 merged.

Added the docs changes required to support size as per https://github.com/docker/docker/pull/23780

we have this option for other drivers, so moving to code review

LGTM

LGTM


TBD TERRIFIC IMPORTANCE show some gui launching indicator stuff as quick as possible on i2pd_qt launch

WONTFIX, IT'S ALREADY QUICK TO SHOW UP AFTER THE LAUNCH.


Crash when landing in a planet

After arriving to a planet and starting the landing, MC crash,  happens in any planet. See log attached,
crash-2016-10-23_20.01.32-server.txt

Does this occur if you remove everything except AR and libvulpes?

Uhm... A little bit tricky, for example I've all my items in storage drawers, several automated machines (grinders smelters etc), a big transport system based in RFTools. The weird part is that I was able to visit two planets some days ago... I'm going to make a "mod debug" eliminating gradually the latest and non essentials... I'll keep you posted...

Can make a copy of the world folder, so you don't lose anything permanently

Yep, working with world backups :-). I manage to isolate 9 mods, now trying one by one... work in progress!!! :-) -:)  (I mean, without this 9 mods I can land ok)...

Gotcha! https://minecraft.curseforge.com/projects/jurassic-park-minecraft-genesis?gameCategorySlug=mc-mods&projectID=250575
Jurassic Park Minecraft Genesis... When this mod is removed the landing crash is no more...Why? gee.... why knows! should I report this to the JPME developer? (with what evidence?)

I'll look at it once I get to a computer so I can see exactly why it's
doing this and I'll report back

Alright, if you get it down to one or two I'll see if I can do fixes

Uhm.. I'm slower than normal :-), what do you mean with "if you get it down to one or two"?

I sent that email well before you reported that you narrowed it down to the one mod...  but I meant find one of two mods that seems to cause it and I'll look... out of order conversations lead to odd results..

What is the minimum set of mods installed when you can still make it crash?  Just LibVulpes, AR, and Jurassiccraft?
Also if you put it back in does it crash again?

ZMaster's emails to github glitched out the other day. He probably sent
that before you figured out which mod it was and github just now got it.
On Tue, Oct 25, 2016, 2:01 PM jonabrv1965<EMAIL_ADDRESS>wrote:

Uhm.. I'm slower than normal :-), what do you mean with "if you get it
down to one or two"?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/zmaster587/AdvancedRocketry/issues/260#issuecomment-256142823,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJzt6pql-DN3_gohlJPGzMzn_OKIY2pCks5q3lIjgaJpZM4KeY8_
.

I meant of you narrow it down to one or two mods, which you already have it
seems

Hi all, thank you for your time!. Yes, I was able to isolate the culprit, see my last message up here.

https://minecraft.curseforge.com/projects/jurassic-park-minecraft-genesis?gameCategorySlug=mc-mods&projectID=250575
Jurassic Park Minecraft Genesis...
Just in case my messages does not get you... :-)

does it happen every time or just some of the time?  I've got LibVulpes, AR 0.9.1, forge <IP_ADDRESS>4 and JPME  1.0.0 (latest build, because they're not numbered :/) in a pack, but I don't crash even if i go to multiple new worlds.  Is there anything in particular that you do?

I've forge-1.10.2-<IP_ADDRESS>7, LibVulpes-1.10.2-0.1.5-universal, AdvancedRocketry-1.10.2-0.9.1.
It happened to me every time I load JPME.jar (without numbers). Also use OptiFine_1.10.2_HD_U_C3.jar (and installed the latest OptiFine_1.10.2_HD_U_D1, with same results : crash)
In the crash log you can find the mods loaded :-)

Hmm... I just got the same crash in the overworld

Nailed it down to the list of dinosaurs to spawn having a total weight of 0 from here.
    public static <T extends WeightedRandom.Item> T getRandomItem(Random random, List<T> collection, int totalWeight)     {         if (totalWeight <= 0)         {             throw new IllegalArgumentException();         }         else         {             int i = random.nextInt(totalWeight);             return getRandomItem(collection, i);         }     }

Still working on it, but I've found the crash still occurs when JPME is loaded, so it is definitely not an AR interaction.
Got this by loading a new world with only JPME installed.
crash-2016-10-27_20.52.25-server.txt

I've left a comment on the mod page so hopefully it'll get fixed fairly soon.
https://minecraft.curseforge.com/projects/jurassic-park-minecraft-genesis?comment=14


It would be good to be able to search for rules on the site

I wanted to search for the equivalent of jscs disallowKeywordsOnNewLine but couldn't find an easy way. Would be great if I could do that.

I think I like the idea. As personally I always have to do a cntrl + f to lookup rules.

I was planning on adding search by at least name to the rules page. I'm just waiting to get rule schemas completely added into eslint first.
However, I'm not sure if search by name would help in this case...

@gyandeeps
Well you can't do that for searching equivalents or keywords (detail info) of a rule.

@stevemao I don't think we will ever add full text search into the site. Our site is hosted using github pages, that doesn't allow server-side code, and doing such search on the client-side is not feasible. Our site, however, is fully indexed by google, you can always do a search there.

Full text search might be a bad idea. But I would like to search by rules (all rules including jshint and jscs).
Another thought. Maybe we can add a "equivalents" page (mostly for people who are using jscs and jshint in the past)?

We do not keep a list of jshint or jscs rules. And I don't think we will be able to create "equivalents" page. Our rules update quite rapidly (and same goes for jscs), and we also don't have one-to-one mapping. Some of our rules cover only parts of rules from jshint/jscs and some cover quite a bit more then counterparts. Keeping this page up to date would be a nightmare. You can try https://jslinterrors.com/ for approximate mapping, but I think that's the best we would be able to offer.

I understand. It doesn't have to be one-to-one mapping or anything strict like this. It could be very rough.
Reason I open this is because in some pages I see
Compatibility
JSHint: indent
JSCS: validateIndentation
I personally like this as I wanted to switch from jshint or jscs in some projects. This makes everything easier. It would be great to quickly search for those. Mainly for starters.

Only a few rules have compatibility section, and that was done mostly early on, when we were trying to catch up to JSHint in terms for rules parity. I'm not sure we would be able to parse it out of the .md files, but I can take a look.  That should give you pretty accurate results.

You can search the site via Google, just use:
site:eslint.org your search terms

It would be great if we add this to the docs?

What do you mean? Add google's search box up top? Yes, I guess we could do that, but I always sort of hated that kind of integration.

The google search box looks ugly. I was thinking this could be added to something like "Pro Tips".

Ahhh.. I got it, just an explanation on how to search the site. We could do that. In all honesty, I would rather just add a full blown search, but that's a bit problematic, since we are hosted in Github.

Yup :smile:

I initially posted the same issue in the wrong repo (eslint core), so I'm adding my voice to this issue as well:
I, too, am bothered by the fact that everytime I need to find documentation about a specific rule, I have to get out of the website, do a eslint {name-of-the-rule} google search, and get back to the website. It would be much more easier if I could do my search directly from the website.
I work at Algolia, and (apart from being heavy users of eslint), we also do a SaaS search engine, so there might be a way I could help with that.
We're used to provide custom and free accounts to open-source projects (we did it for Laravel and FontAwesome for example) as a way to contribute back, so this won't cost anything. I've also submitted a few PR adding this kind of search to other popular projects (Bootstrap, Babeljs and React), but none of them has been accepted yet, though. So, before starting anything, I wondered if this was something you'd be interested in. If so, I'd happily submit a PR.
The search I have in mind would be pretty similar to the above examples, with typo-tolerance, highlighting and custom ranking built-in. It takes the form of a jekyll plugin, and simply requires a jekyll algolia push for reindexing the data.
Would that make sense for you? Tell me what you think, I can help building it, but I'd like some feedbacks and inputs before starting anything.

@pixelastic I think it would be nice to add a search to the site. Quick question though. As far as I remember Github pages don't support arbitrary jekyll plugins. Would algolia plugin work with Github pages? Also, how much control do we have over output of the search engine?

@ilyavolodin The search would totally work on websites hosted on GitHub pages.  As you said, GitHub pages will not execute Jekyll scripts that are not in their whitelist, so this would have to be done from your machine.
We're planning to support GitHub webhooks in the future to remove this step, but this is not ready yet.
Regarding the output of the search engine, you'll have total control over it. All the display is handled client side, with Mustache templates. You can have a look at the PR for BabelJS to have an idea of the changes to the files involved.

@nzakas Do you have jekyll installed locally, would we be able to add jekyll algolia push into the release script before pushing website out?

Since I'm on Windows, I can't get Jekyll to work, so anything that requires me to run Jekyll manually is a nonstarter.
The only real option would be to publish the site through an intermediary to another host, but that seems like overkill.

Hmm.. that would be a problem. I did get Jekyll to run on my Windows machine, but it took me hours to setup correctly.

Hmm, the jekyll algolia push command is tightly bound to Jekyll internals, a node script won't do it.
Is Docker easier to install than Jekyll on Windows? I could provide a Dockerfile that will do the jekyll algolia push, but that seems a bit overkill.
There might also be a way to do it automatically through TravisCI now that I think of it. I'm going to test if this is doable.

Travis CI solution would be ideal, since we can set it up to kick of on any master branch update.

I just did a quick test with TravisCI and this is working fine. Still, it requires a bit of configuration:

Adding a Gemfile with the jekyll and algoliasearch-jekyll version numbers
Adding a .travis.yml (running bundle exec jekyll algolia push when pushing to gh-pages)
Adding an ALGOLIA_API_KEY env variable in the TravisCI config panel

@ilyavolodin: Would that work for you?

I've updated the documentation of our plugin with more detailed information of what is required to make it work with Travis: https://github.com/algolia/algoliasearch-jekyll#github-pages

@ilyavolodin and @nzakas : Would the TravisCI solution suggested above be acceptable for you? It still requires a minimal bit of configuration the first time, and then every reindexing of data will be automatic on every updates on the gh-pages branch.
If so, I'll start working on the search implementation.

@pixelastic I think it's a reasonable approach. Let's try that. The only correction is we need Travis to kick out a new build on update of master branch, not gh-pages

Sure, this can easily be changed.

@pixelastic Any updates on adding algolia search?

Sorry, didn't have time to start this this week. I'll give it a go probably next week, I'll keep you informed.

I've been working on it this week, I should be able to show something in the next days. Sorry for the delay.

I think this can be closed?

Yes, thanks.


Make Bundler Noisy; Open Readme in browser; Open new Lab in new tab

Did you want to move the restore_files and watch_for_changes before the bundle in this PR too?


Conflict if the iterating element is called "element"

If you name your item for ng-repeat "element" it will fail and render blank items for your collection. If you still try to reorder, they will be visible the second time but errors will be thrown in the console.
<tr as-sortable-item ng-repeat="element in formElements">
Just renaming from "element" to something like "melement"  seams to solve this.
( Thanks for an awesome directive :) )

Hi didn't get you... Do you see this code somewhere in the demo app?

Hi. I am using your library in one of my projects. When I use it in the format where I declare it the way I mentioned it above the sorting does not work. To be specific: if you try to use "element in someCollection" for ng-repeat where you actually name it "element" (literally) the sorting does not work. if you rename "element" to something else (ex "my_element" or "element_foo", etc) it works. But calling it "element" breakes something. If you name the iterator "element" and you try to output via {{element}} you get a circular dependency error. All sort of weird behaviours happen.

+1
I had the same issue

I think it comes from the fact the directive does not use isolated scope, I had the same kind problem with a scope property named "type".

 I had given up until I had the (random) idea of checking the issues section 😅


OWNERS for pipelines folder

/assign @rmgogogo @joeliedtke
Propose adding engs to approvers of pipelines folder, so that we can fix minor issues much faster.

/lgtm

/approve


Proposal to Integrate Prettier for Consistent Code Formatting

Background
As our project grows, maintaining a consistent coding style across multiple files and developers becomes increasingly challenging. This can lead to discrepancies in code formatting, which may not only affect readability but also lead to unnecessary git diffs that complicate code reviews and version control.
Proposal
I propose that we integrate Prettier, an opinionated code formatter, into our development workflow. Prettier supports many languages and integrates well with most editors and the command line. By automating the formatting process, we can ensure our codebase remains clean and consistent without requiring manual effort from developers.
Benefits

Consistency: Automates formatting to ensure all developers follow the same style without having to think about it.
Saves Time and Reduces Errors: Minimizes the time spent on formatting code manually, allowing developers to focus more on logic and implementation.
Enhanced Code Quality: Improves readability and reduces the likelihood of format-related issues in code reviews.
Easy Integration: Prettier can be easily integrated with pre-commit hooks using tools like Husky, ensuring that all committed code is automatically formatted.

Implementation Steps

Agree on the basic Prettier configuration settings that match our project's coding standards.
Set up Prettier with a configuration file in our project repository.
Integrate Prettier into our build process using a pre-commit hook to automatically format staged files.
Update our contributing guidelines to include steps for setting up Prettier locally.

Seeking Feedback
I would like feedback on:

The choice of Prettier as our code formatter.
Any specific preferences for Prettier configurations (e.g., tab width, semicolons, single vs double quotes).
How to best integrate this into our existing workflow without disrupting current project timelines.

Please share your thoughts and suggestions on this proposal. Your input is invaluable as we aim to enhance our development practices.

Adopted


KeyboardAwareScrollView not work in TextInput nested in FlatList component

Describe the bug
Hey, i'm facing issue with KeyboardAwareScrollView  - When im trying to use it above the level of FlatList` it does not work.

Is there any specific way that i should handle it?
Of course, in the renderItem of flat list i does not have only the TextInput, but whole component with textInput in it

@elenydev FlatList under hood renders its own ScrollView. So your layout will contain two ScrollViews:
<ScrollView> // <- KeyboardAwareScrollView
  <ScrollView> // <- FlatList

And ScrollView rendered by FlatList is simple ScrollView which doesn't have avoiding behavior. In your case you can try to render KeyboardAwareScrollView inside FlatList:
<FlatList
  renderScrollComponent={KeyboardAwareScrollView}
/>

Can you try this and see if it fixes your problem?

@kirillzyusko thanks for fast reply!
Actually, passing the KeyboardAwareScrollView like You've showed result in

This way it renders the list, but unfortunately it's not solving the issue :(

@elenydev can you post the code sample here, so that I can run it in my example app and see what exactly is not working? 👀

https://snack.expo.dev/@eleny/keyboardavoidingview - You can take straight from here - also You can try to play with renderScrollComponent
@kirillzyusko

@elenydev here is a slightly modified version of your code:
import React from "react";
import { FlatList, TextInput, View } from "react-native";
import { KeyboardAwareScrollView } from "react-native-keyboard-controller";

const foo = [...Array(100).keys()];

const KeyboardAvoidingComponent = () => {
  return (
    <View style={{ flex: 1, background: "black" }}>
      <FlatList
        data={foo}
        renderItem={() => (
          <View style={{ width: "100%", height: 50 }}>
            <TextInput
              placeholder="Some input"
              style={{
                color: "blue",
                margin: 20,
                borderColor: "red",
                height: 30,
                borderWidth: 1,
              }}
            />
          </View>
        )}
        renderScrollComponent={(props) => (
          <KeyboardAwareScrollView bottomOffset={10} {...props} />
        )}
      />
    </View>
  );
};

export default KeyboardAvoidingComponent;

KeyboardProvider and other app providers are located in App.tsx so I didn't put them here, but you can find them in example app.
Works like a charm:
https://github.com/kirillzyusko/react-native-keyboard-controller/assets/22820318/4a32301e-020a-4d1a-9458-76fc2a4d951a
Let me know if I can close this issue 👀

@kirillzyusko Yeah, this way it works, but take a closer look on my example :) you're missing KeyboardAwareScrollView above flat list - and also the input

@elenydev Ah, you did it with purpose 😅 I thought it was just demonstration of when it works and when not 😅
I think having two view is incorrect layout, because most likely it will break a virtualization of a FlatList (you should receive a warning) - FlatList will not be able to detect its own size (it'll actually find it, but since it'll be nested in a ScrollView - it will have infinite height so it'll try to render all elements).
In your case If you want to have a blue input on top and all other red inputs in FlatList then you can utilize ListHeaderComponent property and render there blue input, while rendering red inputs in renderItem. In this case you'll have a single ScrollView and will have a blue input.
Does it make sense what I'm saying?

Works like charm :) Great advice, really appreciate that! I'm learning native version of React, all of those tips are very handful.
Thanks @kirillzyusko , we can close the issue :)


Injecting Stripe in Elements Gives Error That Says Otherwise

Hi! I am having trouble rouble setting up the SSR with Next.js, and I was hoping for a bit of guidance. While I could compile with next dev, I cannot next build without running into
It looks like you are trying to inject Stripe context outside of an Elements context.

I know that this is a common issue, but the common fix does not appear to do the job in this case in which I separate the Elements and injectStripe components. Here are my files:
index.js
import React, { useState, useEffect } from "react";
import { StripeProvider } from "react-stripe-elements";
import Checkout from "./Checkout";

export default function Stripe() {
  const [stripe, setStripe] = useState(null);
  useEffect(() => {
    setStripe(window.Stripe(process.env.LEDGER_SECRET));
  });
  return (
    <StripeProvider stripe={stripe}>
      <Checkout />
    </StripeProvider>
  );
}

Checkout.js
import React from "react";
import { Elements } from "react-stripe-elements";
import Form from "./Form";

function Checkout() {
  return (

      <Elements>
        <Form />
      </Elements>

  );
}

export default Checkout;

Form.js
import React from "react";
import { CardElement, injectStripe } from "react-stripe-elements";

function Form() {
  const submit = () => {};

  return (

      <CardElement />
      <button onClick={submit}>Submit</button>

  );
}

export default injectStripe(Form);

_document.js
import Document, { Html, Head, Main, NextScript } from "next/document";

export default class Doc extends Document {
  static async getInitialProps(ctx) {
    const initialProps = await Document.getInitialProps(ctx);
    return { ...initialProps };
  }

  render() {
    return (


Need way to control split stopping criteria

Currently the stopping criteria appears to be quite conservative.
For example, if I set maxBins to 1000, it will usually just generate 2 - 5 bins. Why doesn't it generate 8 or 10 instead? I think there should be another parameter that allows the user to specify the stopping criteria. I realize that there will be diminishing returns for generating more bins, but it seems that in many cases it would be better to go further than its currently doing. The combination of both maxBins and a parameter to control when to stop splitting could give the user a lot of control over the number of bins that get as a result.

Looking through the code, I discovered the constant that controls the stopping criterion.
The same constant (-1-e-5) appears in two places in the 2 evalThresholds methods:
var criterion = (gain - (log2(s - 1) + delta) / s) > -1e-5
When I changed this constant to something like -1e-3 or -1e-2, I started getting more splits (which is what I wanted). How was the -1e-5 determined? It seems rather arbitrary. I need to read the paper to understand its meaning.
Here is what I propose:

lets add a new (optional) stoppingCriterion param for the discretizer. If not specified, it can default to something like -1e-5 or -1e-5
There is a lot of code duplicated between the two evalThresholds methods. At a minimum I think the last part of each method could be pulled out into a common method, but I was thinking that we might actually want to make ThresholdFinder classes for the two different ways of finding thresholds. There could be ManyValuesThresholdFinder and FewValuesThresholdFinder classes that both extent a base ThresholdFinder trait. On different between the two implementations surprised me and I'm wondering if it might be the result of fixing something in one copy but not the other. The many values version of evalThresholds has val s1 = leftFreqs.sum while the few values impl has val s1 = if (k1 > 0) leftFreqs.sum else 0. Was that intentional?

I read the paper and did some experimentation. The paper said that you should make the split if the MDL criterion value is greater than 0. It seems that in practice that may result in too few splits (I'm guessing) so  -1e-5 was used instead of 0.  You get even more splits if a value like -1e-3 is used. Using more splits should get more accuracy, but with diminishing returns. I don't see how it could ever get worse (but might overfit). I guess the value to use may vary with the use case, so I think it should be a parameter. The name could be something like stoppingCriterion.

That's what I've seen in Weka version of MDLP:
gain > (Utils.log2(numCutPoints) + delta) / numInstances
So we should use 0 strictly if we want to follow the original designed created by Fayyad and Irani. About the reorganization of code, I agree with you on extracting the duplicated code.

We could have the default value of the stoppingCriterion be 0 and say in the documentation that that is the value suggested in the original paper. However, setting smaller values like -1e-4 or -1e-2 relaxes it so that more bins are likely to be produced.

I am working on this in https://github.com/barrybecker4/spark-MDLP-discretization/tree/ISSUE-12-stopping-criteria-bb
I will create a PR later today or tomorrow.


SDDS dropdown toggle dropdown

Requirements before reporting

[X] No duplicated issue reported.
[X] I have read the contribution guidelines.
[X] I have checked the lastest version if the bug exist there. See all avaliable packages at npmJS.com
[X] I have made sure that the issue comes from SDDS packages by removing SDDS from my project as a test.
[X] I have followed the installation guide.

Package
@scania/components
Package versions
@scania/components 4.5
Browser
Edge (Chromium)
Framework
Angular
Version
14
Reproduction steps
Toggle only works on dropdown and clicking an item in the list but clicking the drop up arrow.
Code example
....
Screenshots
Add/Copy screenshot here
Expected behaviour
Ckicking drop up arrow show hide the dropdown list
Console errors
No response
Contact information
<EMAIL_ADDRESS>

This issue has been resolved in the latest versions of both @scania/components and @scania/tegel packages.


Col is LG when opened in XS

Hi,
I am experiencing a weird behaviour. I  have the following:
Mobile:

Browser:

                 <Container fluid>
                    <Row>
                        <Col lg={6} xs={12}>
                            <div dangerouslySetInnerHTML={{ __html: this.props.text }}/>
                        </Col>
                    </Row>
                </Container>

When I am in XS like an Android device, I am seing LG 6 columns instead of 12 as expected. Is this a bug? Do I need to use Visible for mobile devices instead?
Thanks

@LMulvey @hmarcelodn i could not create a reproduction but I solved it by adding:
setTimeout(() => {
  window.dispatchEvent(new Event('resize'));
}, 0);

I'll close this then :)


Sample code compiled error

Environment:

MacOS 10.15
Sublime Text 3 + Mactex + skim
I also tried the bash command, however, the compiler shows the same issue

Sample code Compiled error:

main.tex line47. \printbibliography undefined control sequence
ap-publication.tex line22. \printbibliography undefined control sequence
/usr/local/texlive/2016/texmf-dist/tex/latex/biblatex/biblatex.sty:11963: Package keyval Error: dashed undefined. [\blx@processoptions]

Solution:
Error 1. and 2.  According to https://www.overleaf.com/learn/latex/Bibliography_management_with_biblatex, you should include the following packages in the _global_settings.tex:
\usepackage[utf8]{inputenc}
\usepackage[english]{babel}
\usepackage{csquotes}
Error 3. The arg 'dashed' in _global_settings.tex {biblatex} is undefined, so I just comment it.
If you are experiencing the same issue, you can try the aforementioned solutions.

Thanks for pointing out such compilation compatibility issues. Fixes for Error 1&2 have been incorporated in Commit 721a5ad4aac4f27aeab40d535ea6d3ed95e35a25.
For Error 3, dashed is in fact necessary and not recommended to be dropped. It is undefined in ancient version of biblatex. Notice that you're using TeX Live 2016---better to upgrade it to avoid errors due to obsolete packages.


Intermediate Algorithm Scripting: Seek and Destroy - Solution 3 not working (misspelled variable name)

Solution 3 of this challenge doesn't pass the test.
The 2 variables ("valuesToRemove" and "valsToRemove") are supposed to be one and the same variable.
I suggest to either change both of them to "valuesToRemove" or both of them to "valsToRemove".
Here the link to the challenge:
https://www.freecodecamp.org/forum/t/freecodecamp-challenge-guide-seek-and-destroy/16046

@gignupg I have updated the solution to use valuesToRemove and now passes all the tests.
Thank you for reporting.

Sure, thx for fixing it!!


fixed year in page.njk

Closes #404

Changes

Flags

Screenshots or Video

Related Issues

Issue #
Pull Request #

Author Checklist

[x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[x] Vital features and changes captured in unit and/or integration tests
[x] Commits messages follow AP format
[x] Extend the documentation, if necessary
[x] Merging to master from fork:branchname

We need DCO sign-off. See the failing check for details.


More fixes

Addressed comments in https://github.com/looker/custom_visualizations_v2/pull/9
Fixed TypeScript linting errors

cc @nickfogler @pascal4mile


implement patch gamedata/id

Did you want feedback already on something specific, or shall I wait for you to fix the tests?

Did you want feedback already on something specific, or shall I wait for you to fix the tests?

If you know of the top of your head how a test can work locally and fail at github because database get all fetches items in the incorrect order that might be helpfull. I'l probably add some sorting to the test but I don't think it should need any

Looks good. Mind adding feature tests as well?

Looks good. Mind adding feature tests as well?

Added feature test


Can two DRPlacementControls refer to the same DRPolicy

IMO, this was possible before and is a valid use case. However, with #435 this isn't possible anymore. Is this a bug that must be fixed?

Test case:

create a drpolicy
create a drpc that refers to it
create another drpc that refer to the same drpolicy

The reconciliation of the second drpc fails with the error "drpolicy is referenced in existing drpc resource name".

@ShyamsundarR @BenamarMk @jmishrarh

Sorry for the noise. The DRPolicy had a deletion timestamp. I am not sure what issued the delete.
This feature is working as expected. Closing the issue.


Fix CRI-O installation information

update Ubuntu, CentOS and Debian installation instructions
add Fedora instructions

PTAL @TomSweeneyRedHat

One question, otherwise LGTM

Page preview:
https://deploy-preview-23000--kubernetes-io-master-staging.netlify.app/docs/setup/production-environment/container-runtimes/

addressed as suggested @kbhawkey PTAL

@haircommander
Is this design intended? looks kinda weird to me 🤔

If I'm being honest, the table format is not being rendered super well. I think it is clear enough to be understood, but I'm happy to adopt a change that would look better.

/lgtm

thank you @zacharysarah, updated as suggested

/lgtm
/approve


Final Project Submission

API for Medibook Doctors Appointment Platform
Hello reviewer. Here's the final submission for our capstone project. Team members @sainingo @OybekKayumov @AnicetFantomas @IfzaRasool
Front-end PR
LIVE DEMO
Project Milestone completed: 💪 🍄

Set up the Kanban board with all the cards for tasks.
Specify the Topic as Booking an appointment with a doctor.
Set up the Gitflow.
Set up the rails app with Postgresql
Set up the authentication and authorization with JWT & Bcrypt.
Set up the linters files
Create the models User, Doctor, and Appointment.
Create All migrations needed and schema and seed data
Create the associations.
Add the Validations.
Create the routes For Login and Signup
Create controller actions for users, doctors, and appointments.
Add tests for requests.
Add tests for models.
Deploy the API with Heroku
Create the Documentation for the API.
No linters error. 🚀💯🔥

Thanks a lot, @vichuge !


Feature/interceptors

Fixing binding issue for interceptor invocation.

@Romakita I guess we can drop this PR, the other one looks fine...


Clean up dag_test.go

don't use test builders
use script mode instead of command+args
sort start times using sort.Slice
compare parallel task start times using math.Abs in case s1 starts >5s before s2 -- only the other case was checked before
then copy test/dag_test.go -> test/v1alpha1/dag_test.go and fix incompatibilities

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[y] Includes tests (if functionality changed/added)
[n] Includes docs (if user facing)
[y] Commit messages follow commit message best practices
[y] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
NONE

/kind cleanup
/area testing
#3178

/lgtm

/lgtm


Clustering - ZeroMQ.lib.zmq threw and exception

Description
config.json: (trunkated)
{
    ...
    "api": {
        "enabled": true,
        "listenAddress": "<IP_ADDRESS>",
        "port": 80,
        "adminPort": 8080
    },
    "shareRelay": {
        "publishUrl": "tcp://<IP_ADDRESS>:6000",
        "sharedEncryptionKey": "testkey"
    },
    ...
}

Error:
[2019-07-12 07:27:07.7708] [W] [Core] Running as root is discouraged!
[2019-07-12 07:27:07.9630] [I] [Core] .NET Core 4.6.27617.05 on Linux 4.4.0-142-generic #168-Ubuntu SMP Wed Jan 16 21:00:45 UTC 2019 [X64]
[2019-07-12 07:27:08.6642] [I] [Core] 46 coins loaded from /dotnetapp/coins.json
System.AggregateException: One or more errors occurred. (The type initializer for 'ZeroMQ.lib.zmq' threw an exception.) ---> System.TypeInitializationException: The type initializer for 'ZeroMQ.lib.zmq' threw an exception. ---> System.DllNotFoundException: Unable to load shared library 'libzmq' or one of its dependencies. In order to help diagnose loading problems, consider setting the LD_DEBUG environment variable: liblibzmq: cannot open shared object file: No such file or directory
at ZeroMQ.lib.zmq.version(Int32& major, Int32& minor, Int32& patch)
at ZeroMQ.lib.zmq..cctor()
--- End of inner exception stack trace ---
at ZeroMQ.lib.zmq.ctx_new()
at ZeroMQ.ZContext..ctor()
at ZeroMQ.ZContext.get_Current()
at Miningcore.Mining.ShareRelay.Start(ClusterConfig clusterConfig) in /tmp/miningcore/src/Miningcore/Mining/ShareRelay.cs:line 58
at Miningcore.Program.Start() in /tmp/miningcore/src/Miningcore/Program.cs:line 818
--- End of inner exception stack trace ---
at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
at Miningcore.Program.Main(String[] args) in /tmp/miningcore/src/Miningcore/Program.cs:line 109
---> (Inner Exception #0) System.TypeInitializationException: The type initializer for 'ZeroMQ.lib.zmq' threw an exception. ---> System.DllNotFoundException: Unable to load shared library 'libzmq' or one of its dependencies. In order to help diagnose loading problems, consider setting the LD_DEBUG environment variable: liblibzmq: cannot open shared object file: No such file or directory
at ZeroMQ.lib.zmq.version(Int32& major, Int32& minor, Int32& patch)
at ZeroMQ.lib.zmq..cctor()
--- End of inner exception stack trace ---
at ZeroMQ.lib.zmq.ctx_new()
at ZeroMQ.ZContext..ctor()
at ZeroMQ.ZContext.get_Current()
at Miningcore.Mining.ShareRelay.Start(ClusterConfig clusterConfig) in /tmp/miningcore/src/Miningcore/Mining/ShareRelay.cs:line 58
at Miningcore.Program.Start() in /tmp/miningcore/src/Miningcore/Program.cs:line 818<---
Cluster cannot start. Good Bye!
[2019-07-12 07:27:09.3346] [I] [Core] Shutdown ...
Shutdown...
[2019-07-12 07:27:09.3698] [I] [ShareRelay] Stopping ..
[2019-07-12 07:27:09.4002] [E] [Core] System.NullReferenceException: Object reference not set to an instance of an object.
at Miningcore.Mining.ShareRelay.Stop() in /tmp/miningcore/src/Miningcore/Mining/ShareRelay.cs:line 90
at Miningcore.Program.Shutdown() in /tmp/miningcore/src/Miningcore/Program.cs:line 929
at Miningcore.Program.Main(String[] args) in /tmp/miningcore/src/Miningcore/Program.cs:line 179 System.NullReferenceException: Object reference not set to an instance of an object.
at Miningcore.Mining.ShareRelay.Stop() in /tmp/miningcore/src/Miningcore/Mining/ShareRelay.cs:line 90
at Miningcore.Program.Shutdown() in /tmp/miningcore/src/Miningcore/Program.cs:line 929
at Miningcore.Program.Main(String[] args) in /tmp/miningcore/src/Miningcore/Program.cs:line 179 at Miningcore.Mining.ShareRelay.Stop() in /tmp/miningcore/src/Miningcore/Mining/ShareRelay.cs:line 90
at Miningcore.Program.Shutdown() in /tmp/miningcore/src/Miningcore/Program.cs:line 929
at Miningcore.Program.Main(String[] args) in /tmp/miningcore/src/Miningcore/Program.cs:line 179
** AppDomain unhandled exception: System.NullReferenceException: Object reference not set to an instance of an object.
at Miningcore.Mining.ShareRelay.Stop() in /tmp/miningcore/src/Miningcore/Mining/ShareRelay.cs:line 90
at Miningcore.Program.Shutdown() in /tmp/miningcore/src/Miningcore/Program.cs:line 929
at Miningcore.Program.Main(String[] args) in /tmp/miningcore/src/Miningcore/Program.cs:line 179
Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.
at Miningcore.Mining.ShareRelay.Stop() in /tmp/miningcore/src/Miningcore/Mining/ShareRelay.cs:line 90
at Miningcore.Program.Shutdown() in /tmp/miningcore/src/Miningcore/Program.cs:line 929
at Miningcore.Program.Main(String[] args) in /tmp/miningcore/src/Miningcore/Program.cs:line 179
Aborted (core dumped)

Version
Master branch on this Github repo.

https://gist.github.com/Konstantin35/9cc735c75ef20124d755c1736ffdeae6

Did you figure this out?  What OS?

For Ubuntu 18.04 I had to use this to get past your error.
sudo apt-get install libzmq3-dev


feat(i18n): add Traditional Chinese translations

Add Traditional Chinese for @valibot/i18n

Thank you very much! Could you also review the zh-CN translations in #419?

新春愉快
I read this translation with reference to the proper nouns on Wikipedia, and it's a great translation. I also referenced this to revise the translation in simplified Chinese.

Thank you!


Add Toggle for System Dark Mode

Adds toggle for System dark mode as well as App Dark mode to Tweaks. This is to fix issue #354 . Tested and Working on Windows 10 22H2. Was unable to figure out how to add the functionality to the current buttons so I made new buttons for system and renamed the current buttons to specify App dark mode. Feel free deny merge and do it better if you want as i have no clue how to use github properly and this is my first pull req. This was originally forked from main and it seems that some confilcts with main and test are present... The only edits i actually made were lines 219-222 in winutil.ps1 and lines 1395-1411 in MainWindow.xaml (sorry)

Made this pull based on main, not test, made edit to test and repulling


Registry per Namespace - Sources

Proposed Changes

Reconciling eventTypes in source reconcilers. Created a common reconciler helper to avoid duplicating code across sources.
Adding 'from' extension to CloudEvents in the corresponding adapters as cloudEvent.Source is useless. With this we can at least easily identify the origin of the eventType. Should probably rename EventType.Source to EventType.From or EventType.Origin.

Release Note

NONE

FYI @vaikas-google
This is the other part of the PR. Still work in progress, I still need to more changes.
Tried it with GitHub and is working. Need to finish the others sources, update the UTs, and do some renaming.
You can get a high level idea of what I'm doing, and we can further discuss tmrw.
The main thing is that IMO we should add a custom extension attribute to the CloudEvents in the adapters, as source is useless. I'm calling it 'From' for now, which would be something like 'Subject' on spec v3.
The Broker ingress can then use that attribute (if present -- it'll be if it comes from most of our adapters). If not, then resort to the useless Source.
I think we should update the Triggers to be able to match not just on Type and the useless Source, but also on other (potentially configurable) attributes, e.g., From (or whatever name we choose).

FYI @Harwayne @grantr @akashrv @n3wscott
Some changes on sources to register EventTypes upon CR installation.


Improvewkb input and output are represented as hexadecimal strings And delete EWKB

mysql> select ST_AsBinary(st_point(24.7, 56.7));
+----------------------------------------------+
| st_asbinary(st_point(24.7, 56.7))            |
+----------------------------------------------+
| \x01010000003333333333b338409a99999999594c40 |
+----------------------------------------------+
1 row in set (0.01 sec)
2.
Since the S2 library is not based on the WGS-84 coordinate system, it is not correct to construct EWKB format data in 4326, so delete

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 32.49 seconds
stream load tsv:          437 seconds loaded<PHONE_NUMBER>9 Bytes, about 163 MB/s
stream load json:         21 seconds loaded<PHONE_NUMBER> Bytes, about 107 MB/s
stream load orc:          60 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230417043436_clickbench_pr_129902.html

run buildall

run buildall


Add support to async etl/pull2 resource

resolves issue #98

consider to make all DTOs not exposed in DatasetService package private

@jimirocks package private DTOs done

looks good to me


where with multiple column and anyof()

I have table data as mentioned below.
Id Name Type
1 ABC SCAN
2 BDC SCAN
3 ABC MANUAL
4 BDC EXTDEV
5 ABC EXTDEV
As per the above Tbl data want ABC data including all 3 types.
I have tried below function
export const getInventoryScanProductByAccNameAndType = async (
accName
) => await db.InventoryScans
.where(['AccountName', 'ProductEnterType']).anyOf(accName, ['SCAN', 'MANUAL', 'EXTDEVICE']).toArray();
Can anyone help me to get the data below?
Id Name Type
1 ABC SCAN
2 ABC MANUAL
3 ABC EXTDEV

Given your table has an index '[AccountName+ProductEnterType]':
await db
  .InventoryScans
  .where('[AccountName+ProductEnterType]').
  anyOf([accName, 'SCAN'], [accName, 'MANUAL'], [accName, 'EXTDEVICE'])
  .toArray();

thanks a lot. Your answer is very helpful for me.

Thanks for the above query. This was very helpful to get the data I want.


Issue and Pull Request Submission Guide

Add a guide to submit issues and pull requests as part of the document maintenance framework.
Issues can be submitted in order to request changes or additions to the documents and should be tagged with the documents they are referring to.
Pull Requests will allow for change tracking and collaborative review of any changes implemented into any document. The PRs should also be tagged with the issue they are "fixing" and they should reference the document under modification in the PR title.
This guide should be added to the README of the pipeline-solutions main page.
Issue and PR templates would be a nice addition.

https://docs.github.com/en/issues/tracking-your-work-with-issues/creating-an-issue


Wrong value in token balance label

System information
OS & Version: All
Browser & Version: All
Actual behavior
After a successful transaction, target chain token balance label shows double the amount of transferred token sum instead of the actual amount. For example (first screenshot), 1 TST from METIS to BOBA, balance is 22 TST on Metamask, while token balance label shows 23 TST = 21 + (1 x 2). 2nd screenshot, 3 TST from METIS to BOBA, balance on Metamask is 25 TST, while token balance label shows 28 TST = 22 + (3 x 2). This behavior occurs for a few minutes and then the balance returns to the right one matching Metamask!

Expected behavior
Token balance label value should match Metamask one at all times!
Steps to reproduce the behavior
Create a request and check the target chain balance just after making it!

@weilbith How do you want to move forward with this? Do you need to discuss this with @manuelwedler or will you be able to give an estimate on the refinement?

@andfletcher @compojoom had the same issue. Can you explain how to reproduce the bug?

@weilbith  can you give a new look into this? Sync with @andfletcher and Daniel.

A small help to reproduce the issue as the repo is public and I still receive notifications from it :laughing::
1- Check the token balances on both networks before making a transfer request (check the value below the amount box and compare it to Metamask as well).
2- make a transfer.
3- check the new balance for the "target" token (from the label below the amount). It doesn't equal the balance on Metamask (which is the right one)!
Have a nice day :)


Add configurable delay?

My DNS registrar (namesilo) doesnt push updates immediately but instead on 5 minute intervals.
This causes certs not generate as script times out.
Is there a way to handle this? is there some option to delay DNS record check to 5 minutes?

Yes of course. The environment variable LEXICON_SLEEP_TIME is made for that. See https://github.com/adferrand/docker-letsencrypt-dns/blob/master/README.md#sleep-time

Ohh awesome! Thank you I missed that.


Add Smugglers Satchel

About the PR
Add the smugglers satchel, a small bag that can be hidden under floor tiles
Why / Balance
SS13 content
Additional ways to hide items
Media
https://github.com/space-wizards/space-station-14/assets/11758391/3b7bf0c7-c900-41a5-b67d-f6b60e31f13f

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl:

add: Smugglers Satchel

I want to request feedback on two aspects:

Due to how SubFloorHide works, i need an abstract entity - should i move this to a seperate yml rather than in specific.yml
Given that its essentially its a small cloth bag with some cables for straps i have made it craftable - should i remove that and restrict it to uplink only?

There is already an open PR for this here


ConnectionFieldTypeVisitor.ConnectionDataFetcher.adapt throws IndexOutOfBoundsException when container is empty

The ConnectionFieldTypeVisitor.ConnectionDataFetcher.adapt method throws an IndexOutOfBoundsException when the container parameter is empty (e.g. an empty Spring Data Window). adapter.getContent(emptyWindowObject) will return an empty collection which makes nodes and edges empty lists. When edges.get(0) is called, we get an exception thrown - IndexOutOfBoundsException: Index 0 out of bounds for length 0.

Hi @jimador, we had the same error in our project when returning an empty container. Turns out, in this case, if you return null instead of empty container, the ConnectionFieldTypeVisitor.ConnectionDataFetcher.adapt maps it to an empty connection as seen here


Update Rust crates

This migrates us to the latest revision of the zcash/librustzcash crates.
Author

[ ] Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
[ ] Automated tests: Did you add appropriate automated tests for any code changes?
[ ] Manual tests: Did you update the manual tests as appropriate? While we aim for automated testing of the application, some aspects require manual testing. If you had to manually test something during development of this pull request, write those steps down.
[ ] Documentation: Did you update documentation as appropriate? (e.g README.md, etc.)
[ ] Run the app: Did you run the demo app and try the changes?
[ ] Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

[ ] Checklist review: Did you go through the code with the Code Review Guidelines checklist?
[ ] Ad hoc review: Did you perform an ad hoc review?  In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
[ ] Automated tests: Did you review the automated tests?
[ ] Manual tests: Did you review the manual tests?
[ ] How is Code Coverage affected by this PR? We encourage you to compare coverage before and after changes and when possible, leave it in a better place.
[ ] Documentation: Did you review Docs, README.md, and Architecture.md as appropriate?
[ ] Run the app: Did you run the demo app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data. Perform this step last, after verifying the code changes are safe to run locally.

Force-pushed to add a SeedRequired exception and pass the relevant status across the FFI to raise it.

Force-pushed to add a SeedRequired exception and pass the relevant status across the FFI to raise it.

I added a followup issue to address how I think the Synchronization factory methods could evolve in the future: https://github.com/zcash/zcash-android-wallet-sdk/issues/725


Can you please share the testing metric? Like the test error of 3.61 is in what units and what is the metric?

Hello,
We used Normalized Mean Error (NME) as a metric. There is no unit, only a range.

Got it, thanks!