Collection methods with model-attributes-style predicates

As underscore provides it, a Backbone.Collection functional helper should be able to be called with a model-attributes-style predicate (in addition to function-style).
Example:
this.collection.reject({user: 'guybrush'});

Methods concerned: find, detect, filter, select, reject, every, all, any, some, partition.
Compatible with underscore#1.7.0.

I really like the idea, I'm surprised this hasn't been requested before. Mind addressing the comments?

Looks like the attributeMethods can be folded into collectionMethods with this as well.

This looks great, thanks. Can you squash down into a single commit and rebase from master and we'll merge?

Thanks for the PR!

And thanks for the code reviews :)

@jridgewell @sophietk this caused the build to break in IE7 and IE8: https://travis-ci.org/jashkenas/backbone/builds/66548299. Mind taking a look?

Oops, didn't see that. Your help is appreciated.


Improve the way NetCDFTimeConverter.convert handles scalars

Currently NetCDFTimeConverter.convert promotes scalar CalendarDateTime or cftime.datetime objects to arrays of floats:
>>> import cftime
>>> from nc_time_axis import NetCDFTimeConverter
>>> NetCDFTimeConverter.convert(cftime.DatetimeNoLeap(2010, 1, 1), None, None)
array([3650.])

Within matplotlib, this can lead to unusual assignment behavior, which will eventually be deprecated in NumPy (https://github.com/numpy/numpy/pull/16943):
$ python -Wd
>>> import cftime
>>> import matplotlib.pyplot as plt
>>> import nc_time_axis
>>> times = [cftime.DatetimeNoLeap(2000, 1, 1), cftime.DatetimeNoLeap(2000, 1, 2), cftime.DatetimeNoLeap(2000, 1, 3)]
>>> data = range(3)
>>> plt.plot(times, data)
.../matplotlib/transforms.py:943: DeprecationWarning: setting an array element with a sequence. This was supported in some cases where the elements are arrays with a single element. For example `np.array([1, np.array([2])], dtype=int)`. In the future this will raise the same ValueError as `np.array([1, [2]], dtype=int)`.
  self._points[:, 0] = interval
.../nc_time_axis/__init__.py:266: DeprecationWarning: `np.object` is a deprecated alias for the builtin `object`. Use `object` by itself, which is identical in behavior, to silence this warning. If you specifically wanted the numpy scalar type, use `np.object_` here.
  if value.dtype != np.object:
[<matplotlib.lines.Line2D object at 0x7fc550278c40>]

In the above example, self._points is np.array([[0., 0.], [1., 1.]]) and interval is (np.array([0.]), np.array([3650.])).  If the converter handled scalars without promoting them to arrays, interval would be (0., 3650.), and the assignment would proceed without warning.
xref: pydata/xarray#4265

@spencerkclark Is this still a live issue that we want to pull into v1.3.0 ?

Yes, I think this would be good to fix in v1.3.0; my PR in #46 should address it.


[SPARK-48167][PYTHON][TESTS][FOLLOWUP][3.5] Reformat test_readwriter.py to fix Python Linter error

What changes were proposed in this pull request?
This is a follow-up of https://github.com/apache/spark/pull/46430 to fix Python linter failure.
Why are the changes needed?
To recover branch-3.5 CI,

https://github.com/apache/spark/actions/runs/8981228745/job/24666400664

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass Python Linter in this PR builder.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @HyukjinKwon and @zhengruifeng

Could you review this PR, @gengliangwang ?

Thank you, @gengliangwang !

Python Linter passed and the doc generation issue is different one.
Merged to branch-3.5.

Thanks!


feat: filter retrieved credential by revocation state

Filter retrieved credentials by revoked status. If revoked = true it means non-revocation was requested and the credentials can't be used to to satisfy the proof request. This is configurable in the getRequestedCredentialsForProofRequest method using the filterByNonRevocationRequirements property.
Made it filter by non revocation requirements by default, but figured it may be dersirable to retrieve credentials that match except for the non-revocation requirement (same as the filterByPresentationPreview config option). The question is whether we want filterByNonRevocationRequirements to be true or false by default. Currently have it to false, but maybe true makes more sense?
@JamesKEbert you input is highly appreciated here. Also if there's anything incorrect here please let me know. I'm not that familiar with revocation.

Codecov Report

Merging #641 (5e60a92) into main (c43cfaa) will increase coverage by 0.01%.
The diff coverage is 61.11%.

@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
+ Coverage   85.57%   85.59%   +0.01%
==========================================
  Files         337      337
  Lines        7265     7267       +2
  Branches     1137     1138       +1
==========================================
+ Hits         6217     6220       +3
+ Misses       1047     1046       -1
  Partials        1        1

Impacted Files
Coverage Δ

...src/modules/indy/services/IndyRevocationService.ts
58.90% <ø> (ø)

...s/core/src/modules/proofs/services/ProofService.ts
84.70% <58.82%> (+0.34%)
:arrow_up:

packages/core/src/modules/proofs/ProofsModule.ts
79.59% <100.00%> (+0.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c43cfaa...5e60a92. Read the comment docs.

I also created a PR in AATH that fixes the broken revocation tests: https://github.com/hyperledger/aries-agent-test-harness/pull/436

It is not dependant on this PR and already works (all tests that align with RFC0441 now pass 🎉 )

That's awesome to hear! Thanks for getting those fixed/sorted out! :)


TST: Check Archiver file encoding and decoding uses UTF-8.

This is a quick rough-cut of some tests that check for UTF-8 during encoding and decoding.

Set errors='strict' in existing readers (_load_version, _load_metadata). This will ensure that a TypeError is raised if there is an encoding mismatch. Not sure if we need to raise our own exception at this point, but feel free to comment.
Manually encode the payloads for the existing writers (_save_version, _save_readme, _save_metadata)

Questions:

I used a dummy class for testing the relevant Archiver methods discussed above: thoughts on that? Maybe it makes more sense to set up a real Archiver instance for these tests. Let me know.
Do we want to set a package constant (or class, etc.) that specifies the encoding to use? Right now 'utf-8' is sprinkled throughout as arguments.
I didn't touch anything outside of the artifact metadata/info/version domain, let me know if there is something I missed.

Thanks!

This is awesome, thanks @thermokarst!

@ebolyen do the existing plugins need updating to use a specific encoding and/or newline character? The readers/writers are currently using universal-newline mode.

@jairideout I think they do, it should just be q2-types as that is defining all of the data-layouts which is what we are trying to make more deterministic.

Sounds good, can you create an issue on q2-types so we don't forget? I'd create one but I'm not clear on what exactly needs to change in the data layout readers/writers (and file formats?).
It's starting to look like we need a richer API than supplying data_dir to readers/writers since this is really easy to mess up and not notice until it comes up in the wild (plus it's some boilerplate that plugin devs shouldn't need to write). What do you think?

@jairideout Will do.
Re: Richer API; Perhaps, the downside is they would have to interact with file-objects at that point, so we would want this API to come with the ability to get just a file to make wrapping tools easier.


Support the Component/Module Creation for Xcode Previews

Problem
Using some code in a SwiftUI view that, e.g., uses an @EnvironmentObject injected by Spezi requires the manual annotation in the SwiftUI preview to inject this object:
struct ScheduleView: View {
    @EnvironmentObject var scheduler: TemplateApplicationScheduler

    var body: some View {
        // ...
    }
}

struct SchedulerView_Previews: PreviewProvider {
    static var previews: some View {
        ScheduleView()
            .environmentObject(TemplateApplicationScheduler())
    }
}

While this is possible for simple components with no @Dependency-annotated components, injecting more complex components that require the injection of dependencies makes this difficult.
Solution
We propose the creation of a .previewComponent(...) or .previewComponents(...) view modifier that injects a specified amount of components in the environment.
The modifier would also require the definition of the associated standard or any generic requirement that are imposed on a component.
Additional context
Input on the design of this preview injection mechanism is greatly welcome. Please leave your thoughts and comments under this issue.
Code of Conduct

[X] I agree to follow this project's Code of Conduct and Contributing Guidelines

Completed as of #95


Allow multiple storage connectors

Allow multiple storage connectors so that we can write to multiple storage destinations at once (e.g. DynamoDB and S3)

Added in 0.8.0


Fix CI workflow to work on macOS 14 runner

This PR fixes the CI workflow to success with the newly activated macOS 14 runner.

@itchyny
Thank you for this contribution! I don’t have a macOS environment, so this fix is incredibly helpful. Your efforts to ensure the CI workflow works on macOS 14 are much appreciated.


How did you obtain the two model files, qwen-1.5-1.8b-chat-int8.mllm and qwen-1.5-1.8b-chat-q4k.mllm?

How did you obtain the two model files, qwen-1.5-1.8b-chat-int8.mllm and qwen-1.5-1.8b-chat-q4k.mllm?

The model files are in here. The link in readme is needed to be fixed.

How are these two models converted?

Where should the model be placed?


Update stable versions and add volvo adapter to stable

Better to separate stable and new latest ... now all need to wait for review

RE_CHECK!

separated

RE-CHECK!

Automated adapter checker
ioBroker.gruenbeck

[ ] :heavy_exclamation_mark: [E150] No common.connectionType found in io-package.json
[ ] :heavy_exclamation_mark: [E152] No common.dataSource found in io-package.json
[ ] :heavy_exclamation_mark: [E605] No actual year found in copyright. Please add "Copyright (c) 2020 tomboxi<EMAIL_ADDRESS>at the end of README.md
[ ] :heavy_exclamation_mark: [E701] No actual year found in LICENSE. Please add "Copyright (c) 2020 tomboxi<EMAIL_ADDRESS>at the start of LICENSE
[ ] :heavy_exclamation_mark: [E816] file tsconfig.json found in repository, but not found in .npmignore

ioBroker.mercedesme

[ ] :heavy_exclamation_mark: [E150] No common.connectionType found in io-package.json
[ ] :heavy_exclamation_mark: [E152] No common.dataSource found in io-package.json

ioBroker.nina

[ ] :heavy_exclamation_mark: [E150] No common.connectionType found in io-package.json
[ ] :heavy_exclamation_mark: [E152] No common.dataSource found in io-package.json

ioBroker.velux

:thumbsup: No errors found
ioBroker.volvo

[ ] :heavy_exclamation_mark: [E150] No common.connectionType found in io-package.json
[ ] :heavy_exclamation_mark: [E152] No common.dataSource found in io-package.json

ioBroker.vw-connect

[ ] :heavy_exclamation_mark: [E150] No common.connectionType found in io-package.json
[ ] :heavy_exclamation_mark: [E152] No common.dataSource found in io-package.json

ioBroker.mystrom

[ ] :heavy_exclamation_mark: [E801] No repository about text found. Please go to "https://github.com/TA2k/ioBroker.mystrom", press the settings button beside the about title and add the description.
[ ] :heavy_exclamation_mark: [E802] No topics found in the repository. Please go to "https://github.com/TA2k/ioBroker.mystrom", press the settings button beside the about title and add some topics.
[ ] :heavy_exclamation_mark: [E603] NO "## Changelog" found in README.md
[ ] :heavy_exclamation_mark: [E604] No ## License found in README.md
[ ] :eyes: [W400] Cannot find "mystrom" in latest repository
[ ] :eyes: [W505] setTimeout found in "main.js", but no clearTimeout detected

Add comment "RE-CHECK!" to start check anew

@TA2k I accept ... please add the montioned new files to io-package  for next version :-) Thank you!


how to deal different licenses on the same source_id

this seems very theoretical, so let's close for now....


Fix browsers autocompleting HTTP Basic Auth form

Description
Fixes #1061. HTTP Basic Auth should not be autocompleted by the browser. By adding autocomplete="new-password" attribute to the password field, this behaviour is prevented.
Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist

[x] My code follows the style guidelines of this project
[x] I ran ESLint and other linters for modified files
[x] I have performed a self-review of my own code and test it
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)
Before

After

Well done!


[Feature request] Delete with left of cursor text getting shifted rightwards

This is a much missing feature on doing gaphical editing, ie with https://github.com/jbyuki/venn.nvim/issues/12
As I understand it, the plugin only provides moves but the goal is to make things more complete.
Since unfortunately neovim does not offer such "simple" features, it would be great to provide them consistently.
Side question:
Do you plan to provide a command to activate and deactivate the plugin like how venn.nvim works (buffer specific enabling via command)? This would make integration with buffer-specific setups much simpler.

Not sure I'd be able to provide a delete operation within the plugin: but I'm really not sure I can completely understand what you'd like to achieve. If I may ask for another example: please do explain further the feature that you'd like in another example, thank you!
As for the side question: I do not plan to provide a command to do so within the plugin, as it can simply be handled through nvim_buf_set_keymap. Here's a snippet to do so!
function _G.Toggle_Gomove()
  local gomove_enabled = vim.b.gomove_enabled or false
  local buf_map = vim.api.nvim_buf_set_keymap
  if gomove_enabled == false then
    vim.b.gomove_enabled = true
    --move keymappings on hjkl
    buf_map(0, "n", "h", "<Plug>GoNSMLeft", {silent=true})
    buf_map(0, "n", "j", "<Plug>GoNSMDown", {silent=true})
    buf_map(0, "n", "k", "<Plug>GoNSMUp", {silent=true})
    buf_map(0, "n", "l", "<Plug>GoNSMRight", {silent=true})
    --duplicate keymappings on HJKL
    buf_map(0, "n", "H", "<Plug>GoNSDLeft", {silent=true})
    buf_map(0, "n", "J", "<Plug>GoNSDDown", {silent=true})
    buf_map(0, "n", "K", "<Plug>GoNSDUp", {silent=true})
    buf_map(0, "n", "L", "<Plug>GoNSDRight", {silent=true})
  else
    vim.cmd([[mapclear <buffer>]])
    vim.b.gomove_enabled = false
  end
  print('Gomove is', (vim.b.gomove_enabled and "enabled" or "disabled"))
end
--toggle with <leader>m
vim.api.nvim_set_keymap('n', '<leader>m', ":lua Toggle_Gomove()<CR>", {noremap=true, silent=true})

Okay, let me give you an example in venn.nvim with cursor position marked with x

One line of text before deletion
One line of text after deletion
Expected one line of text after deletion with the intended feature

test123 ─► tes123
    x
test23 ─► tes123
    x
 test23 ─► tes123
     x

The problem is that the arrow positions break every time, if I delete text and I need to jump leftwards and back to where I have removed some text.
Further, I dont want to count the amount of characters I deleted for making the spacing "just work" as this is tedious and annoying for longer words.
neovim provides also no quickjump on the same line, so that I can I´ whitespace EscandC-o` which is another annoyance.

I think I understand what you mean now! I don't think I can integrate this into gomove as it is very outside the scope of the plugin, but I will look into this and see if I can create it. Will keep the issue open for awhile to track progress :)

Hello! I was able to make a small implementation of this simply in functions :)
function _G.RightAlignDelete(count)
  local prev_pos = {vim.fn.line("."), vim.fn.col(".")}
  vim.cmd('normal!'..count..'x'..count..'I ')
  vim.fn.cursor(unpack(prev_pos))
end
api.nvim_set_keymap(
  'n', 'gd', ":lua RightAlignDelete(vim.v.count1)<CR>", {silent=true}
)

function _G.RightAlignDeleteVirtual(count)
  local line_start = vim.fn.line("'<")
  local line_end = vim.fn.line("'>")

  vim.cmd('execute "normal! g`<\\<C-v>g`>"')

  local register = "z"

  local before_register = vim.fn.getreg(register)
  vim.cmd('normal!'..count..'"'..register..'x')
  vim.cmd(line_start..','..line_end..'normal!'..count..'I ')

  vim.fn.setreg(register, before_register)

  vim.cmd('execute "normal! g`<\\<C-v>g`>"')
end
api.nvim_set_keymap(
  'x', 'gd', ":<C-u>lua RightAlignDeleteVirtual(vim.v.count1)<CR>", {silent=true}
)

Simply place this snippet onto your init.lua and it should work! I haven't done any edge-case testing yet, but this should cover the base functionality at least. Hope this helps!
I made the mapping gd just because it's available, but you can remap it to anything you'd like :)

Thanks alot @booperlv !
I will try this out once I have more time for it.


add cosign

This PR adds image signing for the kwasm-operator image to the current CI process.
Signatures of images can then be verified via
$ cosign verify \
    --certificate-identity https://github.com/kwasm/kwasm-operator/.github/workflows/docker-build-push.yml@<ref> \
    --certificate-oidc-issuer https://token.actions.githubusercontent.com \
    ghcr.io/kwasm/kwasm-operator:<tag or digest>

LGTM.


(gom-player) Fixes the AU bot's error by adding additional GET argument

Description
I have fixed the AU bot for GOM Player. The AJAX page needed an extra GET argument (update_lang). This also makes it easier for the Choco packages team to read the checksums of the gomplayer exe file.
Motivation and Context
This fixes and updates GOM Player. It also removes the error from the AU bot.
How Has this Been Tested?
It has been run locally and with the bot in the PR request.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[x] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[x] All files are up to date with the latest Contributing Guidelines
[x] The added/modified package passed install/uninstall in the chocolatey test environment.
[x] The changes only affect a single package (not including meta package).

:white_check_mark: Package verification completed without issues. PR is now pending human review

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

There is no way the code failed because of me. I changed two things that wouldn't have broken it. Can someone possibly rerun the code? Thank you.

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

:white_check_mark: Package verification completed without issues. PR is now pending human review


Remove LRU cache in pkg/cache

Please provide a description of this PR:
This is to fix test flake https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/49102/unit-tests-arm64_istio/1752553284104622080, seems like the cache is not used anywhere.

/test all


How to assign PartitionKey in queries

After upgrading the SDK from 2.1.5 to 3.5.2 the following code is no longer working.

client.items.query(myQuery, { partitionKey: "MyPartitionKey" }).toArray()

I converted the line to the following but do not know how to assign the partition-key since it has apparently been removed from FeedOptions!

client.items.query(myQuery,{ partitionKey: "MyPartitionKey" }).fetchAll()

Any idea how to fix this?

Partition keys should now be specified as part of the query:
// v2
client.items.query("SELECT * from c", { partitionKey: "MyPartitionKey" }).toArray()

// v3
client.items.query('SELECT * from c WHERE c.yourPartitionKey = "MyPartitionKey"').fetchAll()

I noticed this was missing from the v3 migration guide. I will add some docs

Thanks.
Please update the docs on the methods that uses options as well.
For example:
https://github.com/Azure/azure-sdk-for-js/blob/83fcc44a23ad771128d6e0f49043656b3d1df990/sdk/cosmosdb/cosmos/src/client/Item/Items.ts#L47
This make me think I still need to specify the partionKey inside the options.


lodash CVE

GitHub reports that the version of lodash found in the dependency tree of grunt-cli is vulnerable. Please update, or even remove, the affected dependencies in order to resolve the alerts.

There does not appear to be any audit warning on a clean install of<EMAIL_ADDRESS>nor<EMAIL_ADDRESS>I suggest using npm audit fix, or removing your package-lock.json file and re-running npm install. If you still see it, make sure you are using "grunt-cli": "~1.4.2" or "grunt": "~1.6.1" in your package.json file.


Shouldn't order history be inside solidus repo?

Hello, I am integrating Solidus ecommerce in an existing app, so I need to use the existing User table.
I am not actually using this gem, but I found out that the user orders history (routes, views and so on) are inside this repo.
I am a bit confused about it, because authentication does not really concern orders, IMHO these parts of code may better belong inside solidus codebase. What's your opinion on this matter?

Yes, I agree. Would you like to propose a PR to core? This would be very much appreciated.

Alright, I'll work on this soon.
I also noticed that the guest_checkout feature is present in solidus codebase with the preference setting allow_guest_checkout, enabled by default, but to me it seems it's never used there. Again, its functionality is placed in the solidus_auth_devise gem.


Incorrect ligatures in CMD shell

When opening a command line the prompt shows the cwd, something like this C:\Users\test>
Entering now e.g. a = turns the last character (>) of the prompt message together with the = into a greater equal sign.

Broadly, because the terminal doesn't know what part of the output is the prompt vs the user input, this isn't possible. #757 might make it more possible. Until then, why not set your PROMPT to have a space at the end?

Broadly, because the terminal doesn't know what part of the output is the prompt vs the user input, this isn't possible. #757 might make it more possible. Until then, why not set your PROMPT to have a space at the end?

I wasn't aware of the PROMPT environment variable - thanks for that.


[Feature]: Implement MongoDB countDocuments() method

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
When working with a MongoDB raw query, there must be the ability to use the countDocuments() method to find the exact number of documents in a collection.
Why should this be worked on?
This functionality needs to be worked on because some users, like this one, reported that when using the command in a raw query, Appsmith returns an error which says: Your query failed to execute: no such command: countDocuments.
Furthermore, the countDocuments() method is currently the only method that returns the exact number of documents in a collection. The count() method, on the other hand, takes advantage of the collection's metadata information to provide a faster approximate count.

Hii @felix-appsmith , I would like to work on this ticket .
Can you share some data or screen shots regarding ,where you are  using countDocuments() method.
thank you.


Add text direction

Add direction CSS property along with the new TextDirection type and ltr / rtl values.

Please, don't merge yet, going to refactor this to replace newtype with sum type like we did in #95

Refactored, rebased :ok_hand:

Superceded by #137


[Fix #305] Fix crash in Rails/MatchRoute cop when via option is a variable

Closes #305

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[ ] If this is a new cop, consider making a corresponding update to the Rails Style Guide.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Thanks always!


New feature, Select2 without jQuery

Make Select2 work with and without jQuery.
Being able to use Select2 without jQuery would be more interesting than forcing it.

Duplicate of https://github.com/select2/select2/issues/6196.


Event slide not display when adding/removing events dynamically.

I'm adding and removing events dynamically when clicking on the days in the month view. When a day is first clicked the slide that shows the event under the day displays just fine and it's added to the events array. Now, when the array has multiple events (I'm just allowing one per day) and you click on a day, that's not the last on the array, to remove it, which it does and then click again to re-add it the event slide doesn't show.
I hope I explained my issue well since I'm no good at explaining in general. Anyway, can anyone help?

Sorry I don't quite follow you, could you maybe put together a plunker that reproduces the problem you're experiencing?

I had some time to dig into this a bit more today, I'm assuming you're adding events via the on-timespan-click event, if you pass in the $event object like so: on-timespan-click="toggleEvent(calendarCell, calendarDate, $event)" and then call $event.preventDefault() only when removing the event on the first click it should solve your problem.


#20 - Remove window* references

WIP - untested!  Tests are passing but no clue if it will actually work - will have to test that later.

Okay, now we are here:
Error: this method must be invoked in a browser environment
    at createKindeBrowserClient (D:\GIT\ZabaanAngularSpa\.angular\cache\19.0.2\Zabaan\vite\deps_ssr\kinde-angular.js:14431:11)

https://github.com/kinde-oss/kinde-typescript-sdk/blob/a9f596bd136ee0412d3eb3b4e3c8e1aca1473421/lib/sdk/clients/browser/index.ts#L7

Auth flow working now with SSR!
https://jam.dev/c/7430311d-5ebf-413c-bd36-88d51ff18bb8
No startup errors:

FYI, I will test it tomorrow.

Are you able to push your playground changes you used to test this? I think its a good addition to move to provider syntax in the demo app.

@luukhaijes I didn't realize the purpose of the playground was to test the app!  that makes a lot of sense.
I tested in the app i am working on building with a local NPM package pointing to your repo, so nothing to push unfortunately.  Sorry about that.

@JoshuaNitschke, yeah its used as a starter/demo/testing and such. Your workflow sounds good too, I'll have a look into that. I tested it locally and it works as it should, approving your PR. Thanks for contributing.🎉


[INJIWEB-1025] : injiweb proxy to overcome the CORS issue while working locally

don't commit oidckeystore.p12 file

don't commit oidckeystore.p12 file

removed


python3Packages.zigpy: 0.32.0 -> 0.33.0

Motivation for this change
Update to latest upstream release 0.33.0
Change log: https://github.com/zigpy/zigpy/releases/tag/0.33.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 118255 run on x86_64-linux 1

17 packages built:

home-assistant
python38Packages.bellows
python38Packages.zha-quirks
python38Packages.zigpy
python38Packages.zigpy-cc
python38Packages.zigpy-deconz
python38Packages.zigpy-xbee
python38Packages.zigpy-zigate
python38Packages.zigpy-znp
python39Packages.bellows
python39Packages.zha-quirks
python39Packages.zigpy
python39Packages.zigpy-cc
python39Packages.zigpy-deconz
python39Packages.zigpy-xbee
python39Packages.zigpy-zigate
python39Packages.zigpy-znp


To be able to toggle windows

It would be nice to be able to open and close editors easily. Closing a group to allow a bigger view of the other groups only to re-open that same file you've closed is a hassle. It would be an amazing feature to quickly toggle groups instead of closing them.

It would be nice to be able to open and close editors easily.

Do you mean you want to be able to hide and show editor groups... (#27203, #86641, #102088)

Closing a group to allow a bigger view of the other groups only to re-open that same file you've closed is a hassle.

Or merge two groups together?

If you mean the former, there is another request which is currently open and you can up vote to make it happen


Support for configurable timeouts

Minimal support for TCP timeouts, with tests.
There are several serious issues remaining in the code. In particular, several of the "Begin..." asynchronous I/O functions actually call the blocking Write functions on the socket, and are therefore dependent on the socket's SendTimeout if a connection is abandoned.
The timeouts as documented should time the "total time" to perform an action, for example to read the header, but do not. Therefore, the listener is still vulnerable to tarpit style DOS attacks.

Notes:

ResumableTimer is intended for use timing the total duration of a header read, body draining, etc. But I didn't get that far because there's a LOT of work to be done cleaning up the async I/O first.

The unit tests deal with timeouts, so they take a long time to run. So it goes!

Thanks, just one thing to be aware of. I'm trying to mirror the mono http listener as much as possible while only adding features that it is missing:
https://github.com/mono/mono/tree/master/mcs/class/System/System.Net
The idea is that hopefully we eventually won't even need this anymore once they add WebSocket support.  I guess if you're mirroring newer .net classes that is good because the mono version will probably later go that way, but just keep it in mind.

I had guessed standards-compatibility was a goal. Yes, I was sorely tempted to rename the timeout fields from the somewhat silly IIS-derived names they have now. :) But I was strong.
I thought I'd submit what I did so far more for comment right away. I'm actually pretty proud of the socket tests--networking code can be very tricky to get right. It was two days before I realized that "FlushInput" actually works correctly because the input stream considers itself "empty" when it has read the entire entity body.
I wonder if I should be submitting this upstream to the mono project, as the current code's failure modes are "very bad" in the face of flaky networking and capricious corporate firewalls: infinite timeouts and hung threads.
I could (and probably should) remove largely-unnecessary timer class and changes, to keep the changes minimal. The other changes, well, they're not sexy, but this provides the bare minimum required for a production environment.


feat: added documentation for exposeServices step

Resolves Jira: https://armory.atlassian.net/browse/CDAAS-2156

The title of this Pull Request needs to be changed to match the format:
<type>(<scope>): <subject>

See more details here: https://www.spinnaker.io/community/contributing/submitting/#commit-message-conventions
Some common examples are:
feat(armory.io): add docs.armory.io
fix(parser): grammar and spelling
style(loadingPage): made it super pretty!
refactor(helpMessages): changed order to make more sense


bits and bobs (attempt 2)

changed the demos to use 'argparse' library for better compatibility and nicer '-h' option
changed the ColoredGrid to use matplotlib colormaps
added a pixel_exporter which uses a different approach to drawing the mazes
added some jupyter demos
added some abstract base classes

@MarcinKonowalczyk My sincere apologies, it seems my Github notifications mute got too far away and I didn't received any email/notification about your issues/pull requests.
I'll check your PR as soon as I have time, as there are quite a lot of changes, but based on the commit messages and your list of highlights looks great!


[9.x] Add test cases for multiple_of validation rule

Some of the test cases were not conforming to step constraint in HTML and (in my opinion) not correct per se, i.e. 10.5 is a multiple of .3 as much as it is a multiple of .5.
I also added a few more test cases where the behaviour of multiple_of is not what one would expect and not how HTML validation handles them (emphasis mine):

Constraint validation: When the element has an allowed value step, and the result of applying the algorithm to convert a string to a number to the string given by the element's value is a number, and that number subtracted from the step base is not an integral multiple of the allowed value step, the element is suffering from a step mismatch.

Currently the validation rule fails some cases of recognizing that the value is "an integral multiple of the allowed value step" (because PHP's fmod fails that) and doesn't even attempt to tie the check together with min.
https://html.spec.whatwg.org/multipage/input.html#the-step-attribute

@driesvints Is this is really 9.x? The functionality and the erroneous & misleading test cases are already shipped in Laravel 8.

@tontonsb you've sent this to master which is for the upcoming Laravel 9 release.

@driesvints sorry, double fail on my side 🥇

Btw you're free to send this to 8.x if you want.

Closing this one as the other PR got merged.


Fixing array syntax for PHP 5.3

This bug was introduce in 4d18be1ab1b3af0e91ce694210bae81c8ec03478 and uses a PHP 5.4+ compatible only syntax.
This reverts to the old array() syntax.
//cc @michael-e

Bah sorry guys, working heavily on PHP5.6 at the moment so just used to it now! Thanks for fixing!

Bah sorry guys,

No problemo :P


Feature: Publish the library

Goal: publish library to Maven Central Repository
Pre-requisites (outlined in OSSRH Guide):

[x] Create a ticket with Sonatype which uses JIRA to manage requests:
[x] Create JIRA account
[x] Create a New Project ticket
[x] Review requirements
[x] Setup PGP signatures
[x] Deployment
[x] Use Gradle to automate deployment process
[x] Releasing to Central

Release pending approval from Maven Central Repository (one-time approval required for first release)

@fsaravia ready for review!
Updates to build.gradle per central repository guidelines, save for minor edits to sourcesJar & javadocJar tasks which required some tweaking because this is an Android library and the instructions provided are for Java libraries.
Note: the added uploadArchives task runs successfully, and works as expected: uploads all necesary components to Central Repository.  The library is now in the inital review stages w/ Central Repo.

@kristinpeterson other than those comments, this looks great. Thanks!

@fsaravia thanks!


Prepare release 0.2.0

@benjaminbluhm I accidentally used one of my official IDs while making the last pull request, could you please change it the GitHub ID I own (https://github.com/achieveordie) to avoid any accidental breach of contract? Thanks.

@benjaminbluhm I accidentally used one of my official IDs while making the last pull request, could you please change it the GitHub ID I own (https://github.com/achieveordie) to avoid any accidental breach of contract? Thanks.

Sure no problem, just updated it :-)


bpfman/lib: add function documentation

This pull request documents several functions in the bpfman crate, with examples marked with rust,no_run to ensure proper compilation without execution.
Fixes: https://github.com/bpfman/bpfman/issues/1050
Rationale for rust,no_run Attribute

Compile-Time Checks: By using rust,no_run, the examples are still compiled when running cargo test --doc. This ensures that the code snippets are syntactically correct and that any changes to the API will be caught at compile time.
Avoiding Runtime Dependencies: The examples often require a running instance of bpfman and specific system conditions (e.g., loaded eBPF programs). These conditions are not guaranteed in a typical documentation test environment. Using rust,no_run prevents these examples from failing due to unmet runtime dependencies.
Safety and Stability: Some functions can have side effects or require specific system states. By preventing the execution of these examples, we avoid potential issues such as modifying system state, interfering with running services, or causing unintended side effects during testing.
Focus on Usage Clarity: The examples are intended to illustrate how to use the functions correctly. Using rust,no_run ensures that the focus remains on demonstrating the correct usage patterns without the need for setting up the entire runtime environment required for execution.

By compiling but not running the examples, we strike a balance between ensuring code correctness and avoiding the complexity and potential instability of executing environment-dependent code during documentation tests.
Tested with:
% cargo test --doc
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.19s
   Doc-tests bpfman

running 6 tests
test bpfman/src/lib.rs - pull_bytecode (line 633) - compile ... ok
test bpfman/src/lib.rs - remove_program (line 316) - compile ... ok
test bpfman/src/lib.rs - add_program (line 132) - compile ... ok
test bpfman/src/lib.rs - get_program (line 549) - compile ... ok
test bpfman/src/lib.rs - list_programs (line 439) - compile ... ok
test bpfman/src/types.rs - types::ProgramData::new (line 373) ... ok

This is failing the DCO check because two commits aren't signed off.

This is failing the DCO check because two commits aren't signed off.

Fixed in https://github.com/bpfman/bpfman/compare/ddd7f0dcdb815e6af7909f137e8632e21baa1810..1d9ed28ebe1ba8ff5ba6907161336f0dc34df2c4. Thanks!

Thanks, great work.
Do we need to add cargo test --doc to CI?

Yes, I think we should. Without it, there's a risk of drift unless everyone consistently runs the command before committing

I pushed a lot of commits to address review comments. I think once we're happy with the content we should squash them back down to 3 or 4 commits.
/hold

Thanks, great work.
Do we need to add cargo test --doc to CI?

I added to the github workflow in 109d9419b64516b13d8e6067270cef22c3b7cf23.

@Billy99 Thanks for the review. I've pushed changes for all suggestions from both you and @astoycos. Once we're satisfied with the content, I'll squash the commits down to four discrete ones.
The additional CI GitHub workflow that compiles the examples is expected to fail, and intentionally for the moment until I push:
commit 247aaeb8dc99aee1f0d49e2c2e215b6f329c1407 (HEAD -> 1050-add-doc-comments-and-examples)
Author: Andrew McDermott<EMAIL_ADDRESS>Date:   Wed Aug 14 15:43:37 2024 +0100

    Fix: cargo test --doc --all-features

diff --git a/bpfman/src/lib.rs b/bpfman/src/lib.rs
index 050f184e..ad518b45 100644
--- a/bpfman/src/lib.rs
+++ b/bpfman/src/lib.rs
@@ -140,8 +140,8 @@ pub(crate) fn get_db_config() -> SledConfig {
 ///     // during the loading of the eBPF program. The keys in global_data must
 ///     // already exist in the eBPF program's BPF maps, otherwise, an error
 ///     // will be encountered. For example:
+///     let mut global_data = HashMap::new();
 ///     global_data.insert("global_counter".to_string(), vec![0; 8]);
-///     let global_data = HashMap::new();
 ///
 ///     // Summary:
 ///     //

I haven't pushed this change yet because I want to first confirm that the GitHub workflow fails as expected before pushing a compilable example.

@frobware, I rebased this pr to get it to pass the build check, however, I just realized that you still need to squash everything and sign it to pass the DCO check.  So, you should do a rebase yourself after you squash and then force push it.

Yes, feel free to go ahead and squash and have it ready to merge.

Commits have been squashed, and I have rebased. Ready for final review.


[Bug]: roundtripper and client not reuse tcp connection

TLS client version
1.7.4
System information
...
Issue description
roundtripper does not support reusing tcp connection for subsequent requests
For each RoundTrip, a new connection opens and a handshake takes place, which greatly affects the speed of sending requests
Steps to reproduce / Code Sample
package main

import (
	"context"
	"io"
	"log"
	"net/url"

	http "github.com/bogdanfinn/fhttp"
	client "github.com/bogdanfinn/tls-client"
)

func main() {

	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	options := []client.HttpClientOption{
		//client.WithForceHttp1(),
		client.WithRandomTLSExtensionOrder(),
		client.WithTransportOptions(&client.TransportOptions{
			MaxConnsPerHost:    1,
			DisableCompression: true,
		}),
	}
	client, _ := client.NewHttpClient(client.NewNoopLogger(), options...)

	u, _ := url.ParseRequestURI("https://tls.peet.ws/api/tls")

	for i := 0; i < 3; i++ {
		request := &http.Request{
			Method: "GET",
			URL:    u,
			Header: http.Header{},
		}
		request = request.WithContext(ctx)

		response, _ := client.Do(request)

		log.Print(response)
		body, _ := io.ReadAll(response.Body)
		log.Printf("%s", string(body))
	}
}

https://stackoverflow.com/questions/33238518/what-could-happen-if-i-dont-close-response-body


Getting host context?

In my livecoding VST, whenever the midi composition changes, I want to insert it on the same track that the VST is loaded on (and clear the track before calling InsertMedia), so I need to determine the track that the VST is on.
Reaper supports this via a callback that's similar to getting host function pointers (but passing 1 as the request param instead of 0):
https://www.reaper.fm/sdk/vst/vst_ext.php#vst_hostctx
Does reaper-rs already support this in some way? :)

Yes. reaper_medium::Reaper::plugin_context().type_specific(). And then VstPluginContext::request_containing_track() etc.


Solidjs Context example missing on main

Noticed this was missing. I know Solid has very similar syntax to React, but thought I'd just pull it incase it was overlooked.

CI checks failed


feat: Add example for S3 bucket access through VPC Endpoint

Description
Added an example that shows how to allow a Lambda Function to write objects to an S3 bucket without Internet access, using an S3 Gateway Endpoint available within the VPC the Function is attached to.
Motivation and Context
Provide the community with a working example of the above-mentioned scenario.
Breaking Changes
Not aware of any.
How Has This Been Tested?

[X] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[X] I have tested and validated these changes using one or more of the provided examples/* projects

[X] I have executed pre-commit run -a on my pull request

This PR is included in version 4.1.0 :tada:


[WIP][MB-3868] disable PPM RADIO button on Shipment select page

Description
Explain a little about the changes at a high level.
Reviewer Notes
Is there anything you would like reviewers to give additional scrutiny?
Setup
Add any steps or code to run in this section to help others prepare to run your code:
echo "Code goes here"

Code Review Verification Steps

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change
this article explains more about the approach used.

Screenshots
If this PR makes visible UI changes, an image of the finished UI can help reviewers and casual
observers understand the context of the changes. A before image is optional and
can be included at the submitter's discretion.
Consider using an animated image to show an entire workflow instead of using multiple images. You may want to use GIPHY CAPTURE for this! 📸
Please frame screenshots to show enough useful context but also highlight the affected regions.

Messages

:book:
:link: MB-3868

  Generated by :no_entry_sign: dangerJS against 1519f898017062ab15e78e12103bda7234d6394a

closing based on: https://dp3.atlassian.net/browse/MB-3868?focusedCommentId=13628


I read your blog sounds nice. Is this the 1.9.x version? Modman not working

Seems like there is some reference to the Mage 2.x version?
modman clone https://github.com/ericthehacker/magento2-configscopehints.git
Initialized empty Git repository in /home/dev/domains/mysite.nl/public_html/.modman/magento2-configscopehints/.git/
remote: Counting objects: 44, done.
remote: Total 44 (delta 0), reused 0 (delta 0), pack-reused 43
Unpacking objects: 100% (44/44), done.
ERROR: magento2-configscopehints does not contain a "modman" module description file.
Error trying to clone new module 'magento2-configscopehints', operation cancelled.

@seansan
This is the 1.X version of the module, so it shouldn't be referencing the Magento 2 version ...
If you copy the commands in the installation section of the readme you should be good to go -- it has the correct modman URL.


Update functional_api.py

Updated broken link for " (e.g. GANs)" as (https://www.tensorflow.org/tutorials/generative/dcgan) in "Training, evaluation, and inference" section.

The link is intended to point to https://keras.io/examples/generative/dcgan_overriding_train_step/ and works just fine.

https://keras.io/examples/generative/dcgan_overriding_train_step/

It goes to this link "https://www.tensorflow.org/examples/generative/dcgan_overriding_train_step" which is not working.

The link is intended to point to https://keras.io/examples/generative/dcgan_overriding_train_step/ and works just fine.

https://www.tensorflow.org/examples/generative/dcgan_overriding_train_step

The link is intended to point to https://keras.io/examples/generative/dcgan_overriding_train_step/ and works just fine.

Okay, Please update "https://www.tensorflow.org/examples/generative/dcgan_overriding_train_step" to "https://keras.io/examples/generative/dcgan_overriding_train_step/".

Using just a path in the link doesn';t work because this page is shown on both tensorflow.org and keras.io.
Switching to a full URL for the link will work everywhere.
@RenuPatelGoogle could you update teh generated MD and IPYNB files to match?

Hi @RenuPatelGoogle, are you still working on this?

@RenuPatelGoogle could you update teh generated MD and IPYNB files to match?

Otherwise we'll close the request. Thanks!


Implement a rich default context object for every supported environment

We should configure integrations with a default context that already has most of the stuff we can gather from the environment the library is running on, since it can prove extremely valuable for debugging purposes. Things we record in Corvus at the moment are: arch, host arch, node version, platform, cpu cores, total memory, free memory, locale, etc

Closing stale issues


⚠ Jenkins Plugins Artifactory has degraded performance

In 7fcd5cb, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 2392 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 5f27f3e after 12 minutes.


401 is returned via the success response  interceptor, and not the error response interceptor

Hello,
I'm using the beta version of this library (2.0.0-beta.2), and I noticed that with axios 0.18.1 doesn't throw on 401 status codes by default.
Since axios doesn't throw, the beautiful axios-auth-refresh interceptor logic doesn't run, therefore my token isn't refreshed.
I'm not sure if I'm messing something up on my end, but I can't figure this out, any ideas?
Here's some code:
    this.handler = axios.create({
      baseURL: this.sdkConfig.base,
      timeout: 20000,
      headers: {
        'Content-Type': 'application/x-www-form-urlencoded',
      },
      paramsSerializer: params => qs.stringify(params),
    });

    const refreshAuthLogic = (failedRequest : MyCustomResponseError) => this.auth.refreshTheAccessToken()
      .then((res: MyCustomTokenResponseObj) => {
        const {
          config,
        } = res || {};
        const {
          url,
          MyCustomSpace,
        } = config;

        logEvent('EXPIRED_TOKEN_FOUND', {
          path: url,
        });
        failedRequest.response.config.headers['Authorization'] = 'Bearer ' + res.data.access_token;
        return Promise.resolve();
      });

    // Create the refresh token interceptor
    createAuthRefreshInterceptor(this.handler, refreshAuthLogic);

    // Intercept requests
    this.handler.interceptors.request.use(async (options : MyCustomRequestOptions) => {
      const newOptions = await this.requestInterceptor.prepareRequestInterceptor(
        options,
        this.sdkConfig,
        this.getAccessToken.bind(this)
      );

      // check if too many requests have been dispatched
      this.requestInterceptor.checkIfTooManyRequestsInterceptor(newOptions);

      return newOptions;
    });

    // Intercept responses
    this.handler.interceptors.response.use(
      (opts) => {
        this.responseInterceptor.successInterceptor(opts)
      }, // success interceptor
      (err: MyCustomResponseError) => { // error interceptor
        return this.responseInterceptor.errorInterceptor(err, this.sdkConfig, this.handler);
      }
    );

Thanks @Flyrell I appreciate all your work.

nevermind I was using a request interceptor, and it was deleting the validateStatus that's typically found in the config.


Bump version to "v14.2.1" with changelog.

Dropping this release as we need to land at least one more fix before release.


Benchmark more operations and libraries

Hi!
I spent some time exploring other libraries and decided to add them to the benchmark.
BigNumber.js and decimal.js are both from the same creator of big.js but are much faster in some area.
I also took the opportunity to refactor and simplify the reporting by directly logging the table to paste in the readme.
This should save a decent amount of time when the table needs to be updated.
I also removed the winner column as it doesn't really help understanding the difference in performance between each lib. Instead I added the diff (as %) between BigDecimal.js and each libraries and each operations.
Hope you will enjoy this.

Operation
Bigdecimal.js
Big.js
BigNumber.js
decimal.js
GWTBased

Constructor
44,092 ( - )
39,246 (-11%)
41,920 (-5%)
41,669 (-5%)
2,814 (-94%)

Add
80,748 ( - )
16,901 (-79%)
100,613 (25%)
59,138 (-27%)
88 (-100%)

Subtract
75,724 ( - )
18,438 (-76%)
96,361 (27%)
56,545 (-25%)
88 (-100%)

Multiply
503,550 ( - )
33,408 (-93%)
27,806 (-94%)
54,172 (-89%)
2,739 (-99%)

Divide
15,953 ( - )
1,157 (-93%)
12,530 (-21%)
14,611 (-8%)
686 (-96%)

Remainder
10,186 ( - )
4,002 (-61%)
14,416 (42%)
23,014 (126%)
2,640 (-74%)

Positive pow
28,230 ( - )
26 (-100%)
128 (-100%)
3,833 (-86%)
6 (-100%)

Negative pow
5,169 ( - )
21 (-100%)
123 (-98%)
2,131 (-59%)
278 (-95%)

Abs
795,097 ( - )
1,448,594 (82%)
948,990 (19%)
355,103 (-55%)
14,320 (-98%)

Integer rounding
99,357 ( - )
459,079 (362%)
266,314 (168%)
144,091 (45%)
1,878 (-98%)

Decimal scale
100,688 ( - )
502,895 (399%)
241,756 (140%)
130,178 (29%)
1,735 (-98%)

Compare
558,710 ( - )
1,237,538 (121%)
780,308 (40%)
296,844 (-47%)
1,006,175 (80%)

I also took the opportunity to refactor and simplify the reporting by directly logging the table to paste in the readme.
This should save a decent amount of time when the table needs to be updated.

Definitely. Thank you.

I also removed the winner column as it doesn't really help understanding the difference in performance between each lib. Instead I added the diff (as %) between BigDecimal.js and each libraries and each operations.

Agreed. It is better now.
Should we write +121% instead of 121% if a library is faster than bigdecimal.js ? I think it is better to match the minus sign with a plus sign.
so, instead of "-12% and 12%" for slower and faster, we can show "-12% and +12%"

Thank you for the review, I will look into the last two unresolved points a bit later.

Thank you for the contribution @d-mon-


 False False False False False False False False]],

       fill_value = 1e+20)

k = 3

ranked = array([[3. , 3. , 2. , 2.5, 3. , 2. , 3. , 3. , 3. , 2. ],

       [2. , 1. , 3....5, 2. , 2. , 3. ],

       [1. , 2. , 1. , 1. , 2. , 1. , 1.5, 1. , 1. , 1. ]])

    def friedmanchisquare(*args):

        """Friedman Chi-Square is a non-parametric, one-way within-subjects ANOVA.

        This function calculates the Friedman Chi-square test for repeated measures

        and returns the result, along with the associated probability value.

        Each input is considered a given group. Ideally, the number of treatments

        among each group should be equal. If this is not the case, only the first

        n treatments are taken into account, where n is the number of treatments

        of the smallest group.

        If a group has some missing values, the corresponding treatments are masked

        in the other groups.

        The test statistic is corrected for ties.

        Masked values in one group are propagated to the other groups.

        Returns

        -------

        statistic : float

            the test statistic.

        pvalue : float

            the associated p-value.

        """

        data = argstoarray(*args).astype(float)

        k = len(data)

        if k < 3:

            raise ValueError("Less than 3 groups (%i): " % k +

                             "the Friedman test is NOT appropriate.")

        ranked = ma.masked_values(rankdata(data, axis=0), 0)

        if ranked._mask is not nomask:

            ranked = ma.mask_cols(ranked)

            ranked = ranked.compressed().reshape(k,-1).view(ndarray)

        else:

            ranked = ranked._data

        (k,n) = ranked.shape

        # Ties correction

        repeats = np.array([find_repeats(_) for _ in ranked.T], dtype=object)

>       ties = repeats[repeats.nonzero()].reshape(-1,2)[:,-1].astype(int)

E       DeprecationWarning: The truth value of an empty array is ambiguous. Returning False, but in future this will result in an error. Use `array.size > 0` to check that an array is not empty.

_          = array([2., 3., 1.])

args       = ([9.0, 9.5, 5.0, 7.5, 9.5, 7.5, ...], [7.0, 6.5, 7.0, 7.5, 5.0, 8.0, ...], [6.0, 8.0, 4.0, 6.0, 7.0, 6.5, ...])

data       = masked_array(data =

 [[9.0 9.5 5.0 7.5 9.5 7.5 8.0 7.0 8.5 6.0]

 [7.0 6.5 7.0 ... False False False False False False False False]],

       fill_value = 1e+20)

k          = 3

n          = 10

ranked     = array([[3. , 3. , 2. , 2.5, 3. , 2. , 3. , 3. , 3. , 2. ],

       [2. , 1. , 3....5, 2. , 2. , 3. ],

       [1. , 2. , 1. , 1. , 2. , 1. , 1.5, 1. , 1. , 1. ]])

repeats    = array([[array([], dtype=float64), array([], dtype=int64)],

       [array([], d...64)],

       [array([], dtype=float64), array([], dtype=int64)]], dtype=object)

scipy/stats/mstats_basic.py:2602: DeprecationWarning

If the cause is what I think it is, this is by design. A repro is
a = np.empty(2, object)
a[0] = np.array([1])
a[1] = np.array([])

a.nonzero()

Note that this already errored in the following case:
a = np.empty(2, object)
a[0] = np.array([1, 2])
a[1] = np.array([])

a.nonzero()


fix(lint): Box large error types to resolve the clippy large result err variant lint

Motivation
There are a lot more result_large_err lints on nightly, so we should probably actually fix them.
Solution

Box very large (128-140 byte) error types, adding accessor methods as needed

Review
This is a low priority lint fix.
Reviewer Checklist

[ ] Will the PR name make sense to users?

[ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)

[ ] Are the PR labels correct?
[ ] Does the code do what the ticket and PR says?
[ ] How do you know it works? Does it have tests?

Follow Up Work

@mergifyio refresh


feat: Add support for npm lockfile version 3

This PR adds support for npm lockfile version 3, which drops the "dependencies" key and uses "packages" instead. I've refactored the lockfile parser to make the distinction between the versions explicit rather than the implicit behaviour before. It might be worth splitting into separate files at some point, but the logic is so minimal that I haven't done it.
Some open questions;

Does the code look vaguely correct? I don't know Go well at all
I can't find good documentation around the presence of the "license" key under the "packages" entries. It seems to be present in the v2 fixture, but I couldn't recreate that locally.
Are there other places that I need to add / update tests?

Fixes #1203

Just to get this on the main thread this PR is BLOCKED: https://github.com/npm/cli/issues/5532

made some follow up comments
https://github.com/anchore/syft/commit/9d8244bae6aab260d5ddb504bc1de278d0f4bf10
addressing in PR:
https://github.com/anchore/syft/pull/1349


Return null object from object's const operator[] as well.

Currently const operator[] on object asserts if the key is not found. This is inconsistent with the non-const version, which adds and returns a null object.
IMO it should be possible to return a const reference to a static null json object.
This wouldn't be a breaking change, since it's currently UB. Unlike the non-const version, this wouldn't add anything to the subscripted object and would instead return a reference to a static object, but that should be OK, since it can't be modified anyways.
Specific use case for which this would be helpful:
struct Err {
	unsigned code;
	std::optional<std::string> message;
};

void from_json(const json &j, Err &err) {
	j["Code"].get_to(err.code);
	//assuming from_json for std::optional<T> already written
	j["Message"].get_to(err.message);
}

Currently this code would assert if Message is not present (Note that it is perfectly valid for non-const json objects), whereas with this feature, it would work as expected.

I am not convinced, but I am willing to discuss.
An extension of the from_json method is unfortunately not that simple (and std::optional not available in C++11).

Extending from_json for std::optional can be handled in user code, and in any case is out of scope for this request.
Adding this would have negligible space overhead (just one json object), compared to the cost of the lookup, the cost of checking for the end iterator is negligible, and if I read the README correctly, this library is more about usability than performance anyways.
If implemented, it would remove one source of UB and surprise (there are already several issues open about this, for example #825, #1167, #1358), since the pattern json[key].is_null() would work for const as well as non-const references.
Possibly most importantly, it would free the programmer from having to keep in mind whether the reference they are working with happens to be const or not, since at present, if you either mistakenly call operator[] on a const reference or just make that reference that you've been using const, the program will only crash at runtime instead of causing a compiler error like most constness errors do.
If someone has a reason against this change, please comment it here, since I can't really think of one.

Also, it doesn't introduce any traps, since mutating the result would be a compile error, and since the referred-to object would be static, there is no danger of a dangling reference.

I have to agree that this would be a convenient addition. This has caused many bugs for us, because it is so easy to get wrong...
I also wonder what the rationale is for basic_json::operator[](... key) const to even exist in the first place. AFAICT this library aligns itself quite strongly to STL concepts, and in the STL there's no const operator[] for map-like classes.

So since nobody supplied any reason why this would be outright bad, should I just make a PR?


Assemble changes for 1.7.0 release

We are not able to release 1.6.0 due to unstable staging API.

We need to fix new buttons: next/prev block


Solarpilot fixes

Thanks Ben for the contribution.  @mjwagner2 , if you have a chance to look at, just let me know, otherwise I can take it.

I can look at it. Just skimming through the changes, everything looks good, but I need to make sure the function call(s) that are removed aren't setting any member data.


Got Fatal Error while building a project

Fatal error: ["build/CocoaLumberjack.framework"]: file /Users/admin/dev/xcbeautify/Sources/XcbeautifyLib/String+Beautify.swift, line 164
I can provide you with more info if required

@thii  thanks for the tool )


Add page headers and page numbers to TOC

In the future we can use @page, string-set, target-counter, etc. to put the current section name in the page header and show page numbers in the TOC. We may be able to use some polyfill to do it now.

We could also use display: table-header-group and currently supported counter-increment and content(counter(...)) to get section numbers at the top/bottom of each page.


fix(sec): upgrade certifi to 2022.12.07

What happened？
There are 1 security vulnerabilities found in certifi 2022.12.7

CVE-2022-23491

What did I do？
Upgrade certifi from 2022.12.7 to 2022.12.07 for vulnerability fix
What did you expect to happen？
Ideally, no insecure libs should be used.
The specification of the pull request
PR Specification from OSCS

There is no .07 release, the latest one on pypi is 2022.12.7, which is what we have already.


UI: fix blank screen when redirect to unknown app route

Issue

sometimes when login via OIDC auth flow the UI just shows blank screen.
The reason is that after removing access_token from url the final constructed redirect url does not matches any known app route.

Solution

verify if the redirect url matches known app routes. if not then fallback to root route "/" otherwise continue with the generated redirect url.

Codecov Report

Merging #9888 (0f9cc3a) into master (2dae951) will decrease coverage by 53.17%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #9888       +/-   ##
=============================================
- Coverage     68.96%   15.79%   -53.18%
+ Complexity     5522      175     -5347
=============================================
  Files          1978     1925       -53
  Lines        106182   103757     -2425
  Branches      16089    15801      -288
=============================================
- Hits          73230    16386    -56844
- Misses        27820    86175    +58355
+ Partials       5132     1196     -3936

Flag
Coverage Δ

integration2
?

unittests1
?

unittests2
15.79% <ø> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Learn more

@jayeshchoudhary thanks for looking into this. I understand this is simply a function of whether there's a trailing / or not?

@jayeshchoudhary thanks for looking into this. I understand this is simply a function of whether there's a trailing / or not?

@apucher actually the issue was after login via OIDC auth, the redirect url had other params as well along with access token
eg - {url domain}/#access_token=abc&expiry=123&token_type=bearer. But UI was only expecting access_token and after removing access_token the final redirect url did not match any known UI screen. hence returned a blank screen.
I have added a check to make sure we don't redirect to any unknown screen.


Switch License from AGPL to Apache

Purpose:
AGPLv3 is not an appropriate license for the code in edx-load-tests repo.  This PR makes the necessary changes to relicense the repo's code from AGPLv3 to Apache v2.

Summary:
The Affero GPL is designed to close the "application service provider loophole" that is not protected by the standard GPL license.  This loophole allows ASPs to use GPL code without distributing their changes back to the open source community.  This additional protection is only relevant when licensing hosted software that users interact with over a network (i.e. SaaS applications).
Since the code in edx/edx-load-tests is distributed in standard fashion (not SaaS), it does not make sense to use AGPL.  Since there is no ASP loophole to protect, this is not relevant to the code base.  It is essentially offering the same terms as the standard GPL.  This is confusing, and it is also not inline with edX's open source licensing policy (which uses Apache License rather than GPL for all other open source projects).

Changes made to facilitate the license change:

update README.rst 'License' section, changing "AGPLv3" to "Apache License, Version 2.0"

create a NOTICE.txt which asserts copyright to edX and declares "Apache License, Version 2.0" as the license in use.

update LICENSE.txt, replacing terms and conditions of the 'AGPLv3' license with those of the 'Apache License, Version 2.0'.

/cc @rlucioni

Thanks for the pull request, @cgoldberg! I've created OSPR-1107 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.
Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.
We can't start reviewing your pull request until you've submitted a     signed contributor agreement     or indicated your institutional affiliation.     If you like, you can add yourself to the AUTHORS      file for this repo, though that isn't required.     Please see the CONTRIBUTING     file for more information.

We can't start reviewing your pull request until you've submitted a signed contributor agreement

I don't have a printer, so this might take me a few days to submit.
quick rant:
A very nice enhancement to the edX contribution process would be an electronic means of signing the contributor agreement.  Most open source projects support something like this.
Currently, you provide a document (in MS word format?!) that needs to be printed, then snail mailed (or scanned/emailed).  That is a very onerous process when all the contributor wants to do is give you an enhancement to your code.  If electronic submission is not feasible, you could (at the very least) provide the form in PDF format, so the user does not need to use a proprietary program like MS Word or jump through doc conversion hoops just to print and sign it.
I'd be curious if you have ever tracked metrics on how many pull requests never get merged due to contributors not returning a signed agreement.  I'd bet it is > 0% :)

@cgoldberg yeah, we're looking into electronic submission of the agreement.  I don't blame you for the rant, and welcome back :)

@cgoldberg btw, since none of this pull request is actually authored by you, they are just boilerplate from others, we won't need a signed agreement for this pull request.

Thanks for the contribution @cgoldberg!

awesome.. thanks guys! :rocket:


Argentina - Invalid Format for Mobile Area Codes 387 and 388

Imported from Google Code issue #559 created by martindaloia on 2014-11-19T20:40:02.000Z:

Given this valid E.164 mobile number: +54 9<PHONE_NUMBER> (the last part was modified to preserve the identity)
Current National Format: 03876 15-84-8695
Expected National Format: 0387 15-684-8695
Given this valid E.164 mobile number: +54 9<PHONE_NUMBER> (the last part was modified to preserve the identity)
Current National Format: 03885 15-70-1111
Expected National Format: 0388 15-570-1111
Version used: 7.0.0
This information is taken from the Argentinian bureau of communications called CNC. You can download this Excel where are all the assigned Area Codes (column INDICATIVO) and the Prefix number (column BLOQUE, which in this case are 684 and 570 respectively):
http://www.cnc.gob.ar/multimedia/noticias/archivos/201411/archivo_20141118022303_914.zip
(The link was obtained from this URL: http://www.cnc.gob.ar/asignaciones-a-la-fecha_p445 (On the right side there is a link with a "Númeración Geográfica" as a label))
You can filter INDICATIVO by 387 and 388, and BLOQUE by 570 and 684 to see all of them.
=======
Below there is a Workaround that we made in the PhoneNumberMetadata.xml to change this behavior but we are not sure that doesn't affect other formats:
We modified these 2 lines (883 and 884): https://code.google.com/p/libphonenumber/source/browse/trunk/resources/PhoneNumberMetadata.xml?r=715# 883
and changed like this:
[...]
8(?:
[01]|
3[013469]|
5[0-39]|
7[0-24-69]|
8[0-59]
)
[...]

The link to the file on code.google.com is not accessible anymore.
The equivalent to github.com is:
https://github.com/googlei18n/libphonenumber/blob/b5e59c4e803739422bbcfbd1b8fdf29ffd25eec4/resources/PhoneNumberMetadata.xml#L883

Thanks for the bug report and details. I looked at the spreadsheet data and there are some issues:
In the 387 range, the 4 digit area codes end in 3,6,7,8
In the 387 range, the 3 digit area codes end in 4,5,6
In the 388 range, the 4 digit area codes end in 5,6,7,8
In the 388 range, the 3 digit area codes end in 4,5,6
This means that the following contradictions exist:
"3876 XX" (x 10) vs "387 6XX" (x 22)
"3885 XX" (x 1) vs "388 5XX" (x 58)
"3886 XX" (x 11) vs "388 6XX" (x 3)
My proposal would be to change the following into 3-digit area codes:
3874, 3875, 3876
3884, 3885
But not (yet) 3886 as there are more case where it's used as a 4 digit area code.
Unfortunately the patch you provided won't work because the "leading digits" patterns must much a precise number of digits. The second pattern must match exactly 4 digits in all paths and you have changed it so it matches 5 digits in some cases. For performance and maintenance reasons we only differentiate down to 4 digits in the leading digits, so the contradictory cases above will have to remain incorrect for some cases (ie, "3876 XX", "3885 XX" and "388 6XX").
If you think this is unacceptable, please let us know (we might be able to make an exception, but we'll have to weigh up the pros and cons carefully).
Now I have the XLS spread-sheet I can also look at other area codes and check our data.
Thanks again.

Unfortunately the prefix 3876 appears in the XSL document as both a 3 digit area code and a 4 digit area code. The 4 digit area code appears twice as often as the 3 digit one:
387 6XX XXXX		56 times
3876 XX XXXX		99 times
Similarly 3885 also appears as both 3 and 4 digit codes:
388 5XX XXXX		120 times
3885 XX XXXX		45 times
Here the 3 digit version is more common.
As we are only currently looking at a maximum of 4 digits to determine the formatting, the best we can do is say that 3876 is a 4 digit area code and 3885 is a 3 digit area code.


Include branch name in Humanitec notification

Motivation
We found that Humanitec is not automatically deploying new images. I wanted to switch it to use latest tag from main branch, but discovered that we weren't actually writing branch name to the notify message.
Approach
$GITHUB_BRANCH is not a real environment variable, use $GITHUB_REF_NAME instead.

📣 NOTIFICATION
You are receiving this message because we did not publish any packages.
Generated by @thefrontside/actions


Build docs for 0.5.0

There are some Pypi issues, let's wait for them to resolve

Kicking CI as it looks like the PyPI issue has been resolved.


Test fail: AttributeError: module 'numpy' has no attribute 'bool'

What happened?
I'm trying to package xarray for Mageia.
Since python-numpy has been updated to 1.24.3, tests fail.
What did you expect to happen?
Test pass
Minimal Complete Verifiable Example
Run pytest

MVCE confirmation

[ ] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
[X] Complete example — the example is self-contained, including all data and the text of any traceback.
[ ] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
[X] New issue — a search of GitHub Issues suggests this is not a duplicate.

E           `np.bool` was a deprecated alias for the builtin `bool`. To avoid this error in existing code, use `bool` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.bool_` here.
E           The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
E               https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

/usr/lib64/python3.10/site-packages/numpy/__init__.py:305: AttributeError
______ TestDataArrayRolling.test_rolling_reduce_nonnumeric[max-4-3-True] _______

Anything else we need to know?
No response
Environment

xarray.show_versions()
/usr/lib/python3.10/site-packages/_distutils_hack/init.py:33: UserWarning: Setuptools is replacing distutils.
warnings.warn("Setuptools is replacing distutils.")

And bottleneck? They have a 1.3.7 version out and it's in bottleneck the error occurs in.


PublishEngage WOH with the "merge" strategy fails if the media package does not exist in search instead of SKIPping

Describe the bug
A clear and concise description of what you see:
PublishEngage WOH with the "merge" strategy fails if the media package does not exist in the search index. It should just SKIP the operation.
Also, it first distributes all the elements before checking the existence of the media package in the search index, which potentially leaves files distributed that are not referenced by anything.
To Reproduce
Steps to reproduce the behavior:

Publish a media package
Retract it
Publish again with the "merge" strategy
WOH fails instead of SKIPping

Environment Information

Opencast 11.x, 12.x, 13.x

This was resolved by #4478, right? It's not automatically closed because that PR only mentioned this issue in the description and was not targeting our default branch.
Of course anyone is invited to reopen this if it is still an issue. 😄


Create database table for bookmark functionality

Dev Tasks
Create database table of the following columns:

bookmark id
column for all of the selected and enabled filters
last accessed
date created
amount of times the bookmark has been accessed

Bookmark table was created under campdaux.


About implementing Mapper

This example leaves map/unmap unimplemented. Is it allowed to do so? At least it seems to me that it will panic in Single::new.
    /// #[derive(Clone)]
    /// struct MemoryMapper;
    /// impl Mapper for MemoryMapper {
    ///     unsafe fn map(&mut self, phys_base: usize, bytes: usize) -> NonZeroUsize {
    ///         unimplemented!()
    ///     }
    ///
    ///     fn unmap(&mut self, virt_base: usize, bytes: usize) {
    ///         unimplemented!()
    ///     }
    /// }
    ///
    /// let mapper = MemoryMapper;
    /// let r = unsafe { xhci::Registers::new(MMIO_BASE, mapper) };

https://github.com/rust-osdev/xhci/blob/main/src/registers/mod.rs

This is an example of how to call Registers::new, and you have to implement the correct mapper when you use it in the actual code. I'll add a note about this later.


0200-12-12-papers.md

fixed some typos and layout issues in the German version
switched links in the German beginners' chapter from the English version of the field papers section to the German one now that it exists
brought images in the English version up-to-date with the current fieldpapers.org interface
made a few adjustments to the English document so that it is in sync with the German version

Nice work thanks @michael63-osm


Reducing the size of the gem

Simpler Rakefile and gemspec. The previous gem would contain other gems and include source_texts, making the gem very large (13Mb). This change makes the gem smaller. Should someone need the source_texts as part of the gem, I suggest they clone the repos instead and do the training.

Awesome, thanks Morten
I've made it so that the gem goes out and fetches the sources from wikipedia, so I can remove the source texts entirely


Make changes to FluxHelmRelease CRD versioning

Problem

The current version of the FluxHelmRelease (FHR) API version is v1alpha, which is not compatible with Kubernetes versioning scheme

Change of the FHR definition (https://github.com/weaveworks/flux/issues/982, https://github.com/weaveworks/flux/pull/1035) is a breaking one

A/C

Change the first API implementation version to v1alpha1

Change the current API implementation version to v1alpha2 and make sure both versions work

NOTE
a)
There is a case for postponing the versioning implementation. This would mean a breaking change for current testing users.
The basis for this approach is that the helm-operator is in alpha stage and there are not many external users who would be affected by the schema change. As these users are trying the flux helm integration out, they are, very likely, testing on a small amount of  helmified applications; ie would need to make a small amount of changes in their deploy config repo. If we know who they are, they can be contacted.
The helm-integration documentation in the flux repo and documentation in the weaveworks/flux-helm-test repo will be updated and will inform about the format change and the error messages one will encounter if using the old FHR format.
b)
The case against postponing the versioning implementation is that the versioning will need to be implemented anyway to account for future FluxHelmRelease (FHR) changes. The pragmatic question is how likely it is that the current FHR design is going to change.

An agreement has been reached to postpone the versioning implementation. As there are plans for kubernetes to provide Custom Resource versioning, we may avoid having to implement this.


Issues that suddenly stop

Streaming to rtsp.
I've instantiated VideoFrame and I'm playing the video.
The media player will stop after some time.
Make sure it doesn't stop.
I'm going to get a report and try to reconnect when it's stopped. Is it possible?
[Important: Store the FFmpegInteropMSS instance e.g. in a local field, as long as playback is running. If the object is collected by the GC during playback, playback will stop with an error.] => I don't think this is the problem.
help me
public class VideoFrame
{
private readonly FFmpegInteropConfig mConfig = new FFmpegInteropConfig();
private readonly FFmpegInteropConfig mConfigCapture = new FFmpegInteropConfig();
    private MediaPlayerElement mMediaPlayerElement;
    private MediaPlayer mMediaPlayer = new MediaPlayer();

    private readonly string mCameraName;

    public VideoFrame(MediaPlayerElement mediaPlayerElement, string cameraName)
    {
        Debug.Assert(!string.IsNullOrEmpty(cameraName));
        if(string.IsNullOrEmpty(cameraName)) throw new NullReferenceException("아무것도 비어있으면 안됨. null 도");
        mCameraName = cameraName;

        Debug.Assert(mediaPlayerElement != null);
        mMediaPlayerElement = mediaPlayerElement ?? throw new NullReferenceException("null 참조");

        mConfig.FFmpegOptions.Add("rtsp_flags", "prefer_tcp");
        mConfig.FFmpegOptions.Add("stimeout", 100000);

        mConfigCapture.FFmpegOptions.Add("rtsp_flags", "prefer_tcp");
        mConfigCapture.FFmpegOptions.Add("stimeout", 100000);
    }

    public string RtspUrl { get; set; } = string.Empty;

    private FFmpegInteropMSS mFFmpegMSS;
    private FFmpegInteropMSS mFFmpegMSSFrameCapture;

    public async Task StartCameraAsync()
    {
        while (true)
        {
            try
            {
                mFFmpegMSS = await FFmpegInteropMSS.CreateFromUriAsync(RtspUrl, mConfig);
                mFFmpegMSS.BufferTime = TimeSpan.Zero;
                var source = mFFmpegMSS.CreateMediaPlaybackItem();

                mMediaPlayerElement.Source = source;

                Debug.WriteLine(LogFormat.Get(LogFormat.ELevel.DEBUG, Thread.CurrentThread.ManagedThreadId, nameof(StartCameraAsync), $"{mCameraName} 카메라 open 성공"));
                return;
            }
            catch (Exception ex)
            {
                Debug.WriteLine(LogFormat.Get(LogFormat.ELevel.ERROR, Thread.CurrentThread.ManagedThreadId, nameof(StartCameraAsync), $"{mCameraName} 에러", ex));
            }
        }
    }

    public async Task StartCameraFrameServerAsync()
    {
        while(true)
        {
            try
            {
                mFFmpegMSSFrameCapture = await FFmpegInteropMSS.CreateFromUriAsync(RtspUrl, mConfigCapture);
                mFFmpegMSSFrameCapture.BufferTime = TimeSpan.Zero;
                var sourceFrameCapture = mFFmpegMSSFrameCapture.CreateMediaPlaybackItem();

                mMediaPlayer.Source = sourceFrameCapture;
                mMediaPlayer.IsVideoFrameServerEnabled = true;
                mMediaPlayer.VideoFrameAvailable += MediaPlayerVideoFrameAvailable;
                mMediaPlayer.Play();

                Debug.WriteLine(LogFormat.Get(LogFormat.ELevel.DEBUG, Thread.CurrentThread.ManagedThreadId, nameof(StartCameraFrameServerAsync), $"{mCameraName} 프레임 서버 open 성공"));
                return;
            }
            catch (Exception ex)
            {
                Debug.WriteLine(LogFormat.Get(LogFormat.ELevel.ERROR, Thread.CurrentThread.ManagedThreadId, nameof(StartCameraFrameServerAsync), $"{mCameraName} 에러", ex));
            }
        }
    }

You may need to set the decoder in ffmpeg config to always use system decoders.
We recently implemented D3D11 decoders and those are causing some issues with streaming.
See the "VideoDecoderMode" property of the configuration class.

I see that you set BufferTime to Zero. Then you should not have any issues with D3D11 decoders, it only occurs when using the MSS buffer. So I don't believe that this is your problem.
When you create an instance of the VideoFrame class, do you store that instance in your app (e.g. in your MainPage)? If you store the MSS in the VideoFrame, but don't store the VideoFrame in your app, playback will stop as soon as the GC runs.

Closing this since there was no response for a long time.


Azure Firewall Service Tags: bicep configuration docs

I'm not able to find an example in the docs of how to use azure firewall service tags with bicep/ARM templates.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 47182f22-284b-7a8b-8a18-64bc38051ce6
Version Independent ID: 54e00bc3-3ba5-bcf8-b2e2-efb98d62acb6
Content: Overview of Azure Firewall service tags
Content Source: articles/firewall/service-tags.md
Service: firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

@NaridaL
Thanks for your feedback! We will investigate and update as appropriate.

@NaridaL
You can find this documented here: https://learn.microsoft.com/en-us/azure/templates/microsoft.network/azurefirewalls?pivots=deployment-language-arm-template#azurefirewallnatrule-1

#please-close


Dashboard layout

The dashboard layout has a few issues; that's on Mac + Safari, but Mac firefox does something similar.

Yes, most definitely; sorry, I didn't see that one, I'll close mine.


missing transaction in transactions list

Description
We have a high throughput controller endpoint that is completely missing in the transactions list. It does show up occasionally in the slow transactions list, and when clicked on, the graphs for App Performance and Throughput look like this (showing 0 ms, 0 rpm):

Expected Behavior
Transaction should appear in the transactions list--in fact it is one of the endpoints that is called with high frequency by the app.
Steps to Reproduce
Unsure how to reproduce.
The only difference from other controller methods in the same controller that do appear in the transactions list is that the missing counts method is mentioned in a prepend_before_action :skip_trackable, only: [:counts] in the controller. skip_trackable is defined to do this:
  def skip_trackable
    request.env['devise.skip_trackable'] = true
  end

Your Environment
NewRelic Ruby Agent 7.2.0
Rails <IP_ADDRESS>
Ruby 3.0.2

Hi @gsar, thanks for reaching out!
After assessing the issue, New Relic Support seems best positioned to assist with this specific issue. You can engage the New Relic Support Community or open a support ticket, depending on your support level.  Please provide a link to this GitHub issue when submitting your community post or support ticket.

I want to clarify the reasoning behind my message earlier this week. I noticed I just said the word “assess” without further background. Here it is:
At this time, it’s hard to tell whether this is a bug within the agent or another service (such as a UI component or NRDB). Our support team is versed in each of these layers and will cross-reference your issue with other similar reports to narrow down the root cause. If the support team deems it is an agent-related issue, it will pop back into our laps and we’ll re-assess then.
We really appreciate your active support and reporting on this codebase. I hope my terse redirection didn’t deter your enthusiasm. We’re very grateful for your contributions.


Use base64ct instead of base64

Closes #195.
Also applies 2018 idiom lints.

My initial inclinations here are:

Why?
Why not?

I say this half in jest. :)
Back to reality: I cannot discern a situation in which a timing of base64 reveals security sensitive information. The base64 value is fully known to any attacker, so the timing of a base64 decode of said value would also be known. The decoding operation does not make use of any sensitive information. This would imply that a proof of interference between sensitive information and the base64 values exists, and so variable-time decoding of base64 in this context is as secure as constant-time decoding of base64 in this context. Do you see it another way?
Still, if this is no answer to "why not?", there's no reason not to do this. The standard response would be that there's a performance cost. Can you measure said cost and report back results? We're more interested in passing verifications than we are failing, which will obviously be slower but also rare.

In a security-related context it's better to use const-timing algorithms by default. It may be unnecessary in this particular case, but side-channel attacks can be quite surprising and non-trivial. For example, if a secret value is used repeatedly an attacker  acting under a different user may try to estimate it by measuring timings of responses to his requests (such attack is probably highly unpractical, but still theoretically possible).
Performance-wise, I got the following results on my PC:
test base64_decode   ... bench:      35,631 ns/iter (+/- 7,786) = 2104 MB/s
test base64_encode   ... bench:      33,999 ns/iter (+/- 1,025) = 2205 MB/s
test base64ct_decode ... bench:     123,016 ns/iter (+/- 6,242) = 609 MB/s
test base64ct_encode ... bench:      41,659 ns/iter (+/- 1,407) = 1800 MB/s

With target-cpu=native:
test base64_decode   ... bench:      34,659 ns/iter (+/- 288) = 2163 MB/s
test base64_encode   ... bench:      32,796 ns/iter (+/- 263) = 2286 MB/s
test base64ct_decode ... bench:      99,231 ns/iter (+/- 637) = 755 MB/s
test base64ct_encode ... bench:      28,777 ns/iter (+/- 353) = 2606 MB/s

It probably worth to look into decoding performance of base64ct, it may be possible to improve it (I did something similar for base16ct previously).


When uploading several files at once the date is missing

When uploading several files at once the date is missing.
Also sometimes wrong.
The App added the upload date, instead of the date " according to Exif data".
https://commons.wikimedia.org/w/index.php?title=File:View_of_Leh_from_Tsemo_castle,_Ladakh.jpg&oldid=315035923
https://commons.wikimedia.org/w/index.php?title=File:View_of_Leh_from_Tsemo_castle,_Ladakh_,_2.jpg&oldid=315036119
Device and Android version:
Samsung J510FM
Android 7.1.1
Commons app version:
2.8.1
Would you like to work on the issue?
No.

Just checking, did it happen only when you uploaded multiple files at once? If so we should probably include that into the issue title.
For the "View_of_Leh_from_Tsemo_castle,_Ladakh" set, both File 1 and File 2 seemed to have the dates wrong (upload dates instead of EXIF dates), indeed.

I can confirm that for all my uploads the date is missing. This happens for single uploads such as https://commons.wikimedia.org/wiki/File:Grab_Hackpfüffel.jpg and batch uploads https://commons.wikimedia.org/wiki/File:Kirche_Hackpfüffel_-_1.jpg.

@neslihanturan Do you think this could have been caused by our recent upload change at #1720 ?

Maybe @misaochan , I will try to check this on Monday.

Just talked to @ashishkumar468 about the potential cause of this bug. It seems that the temp file URI changes made at #1749 to fix a different bug, may have caused this.
It isn't limited to just date, but much of the Exif metadata would have been omitted as well, unfortunately. For instance, see the difference between https://commons.wikimedia.org/wiki/File:Miss_Claudes_creperie_in_Brisbane.jpg and https://commons.wikimedia.org/wiki/File:Nepalese_pagoda_in_south_bank_Brisbane.jpeg
Fortunately, this should be fixed soon. :) Thanks for your patience everyone.

Hi @Yannf , we just released this bugfix with v2.9 in beta. Could you please let us know if the problem is solved for you?

Fixed in https://github.com/maskaravivek/apps-android-commons/pull/1 and #1968


Add Validation loss for LoRA training

Base on https://github.com/kohya-ss/sd-scripts/pull/1165
And I only test on Lora training, DreamBooth and ControlNet training need more test.

instead of taking the code and making a commit of your own you should follow the full commit process so the credit and copyright is property accounted for. It's very rude to all those before it. The PR you took from also did it to my original code and it's really annoying as I get no credit


Schema Compare - Invalid Script?

Issue Type: Feature Request
The script created to run against a SQL Server includes lines like:
 :setvar DatabaseName "MyDatabase"
When attempting to Run the script directly in the edit window, SQL rejects those lines with "Incorrect syntax near ':' "
Azure Data Studio version: azuredatastudio 1.8.0 (96e214593190071f0b520439929b218f9fa673de, 2019-06-06T01:59:30.203Z)
OS version: Windows_NT x64 10.0.17763

Thanks for the feedback, this is currently being tracked as adding support for sqlcmd #5140 so I'll close this one


refactor: disentangle bindgen extractor logic

I feel like trying to extract all function bindgen info in one pass has led to an error-prone code that is hard to reason about. In this PR I am refactoring it into two parts:

Deciding what kind of function this is (init, view, call) by doing a pass through arguments and attributes
Traversing all relevant parts of the function signature and calling the respective visitor methods

I am not super happy with how the polymorphic aspect of this approach turned out to be (Box<dyn BindgenVisitor> is unmovable, so build() has to clone visitor field values to the end-structure), so feel free to suggest an alternative.
The bindgen models have also been changed to only contain the values that are relevant to them (e.g., init function does not have result_serializer). This is technically a breaking change since it restricts some combinations that were previously compilable, but I think none of them ever made sense.
NOTE: I left the old models in place and wrote a conversion method so that the PR is reasonably sized. In a follow-up PR I will clean up the codegen side of bindgen macro, which will benefit greatly from this refactoring.
Unresolved questions:

Should init functions be allowed to be private?
Should view functions be allowed to be private? Wouldn't such a function only be callable from a transaction?

Will add some compilation tests to ensure no regression happens after we clear up the question above.

Should init functions be allowed to be private?

Likely not, there is a valid pattern (a pure function calling itself in a promise to initialize the contract) but I can't think of one reason why this would ever be needed. I think it's safe to remove that ability and then just add the capability back if devs ask for it.

Should view functions be allowed to be private? Wouldn't such a function only be callable from a transaction?

No, even calling env::predecessor_account_id fails in view contexts at runtime. This should be restricted at compile time. Good callout!

Might want to double-check https://github.com/near/near-sdk-rs/issues/718 is fixed by this (when you get to it)

Might want to double-check https://github.com/near/near-sdk-rs/issues/718 is fixed by this (when you get to it)

It did not, but now it does :)


ROX-17208: bump operator sdk to 1.33

Description
Bumping operator SDK from 1.24 to 1.33 as per upgrade docs https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.25.0/
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
TODO(replace-me)
Use this space to explain how you validated that your change functions exactly how you expect it.
Feel free to attach JSON snippets, curl commands, screenshots, etc. Apply a simple benchmark: would the information you
provided convince any reviewer or any external reader that you did enough to validate your change.
It is acceptable to assume trust and keep this section light, e.g. as a bullet-point list.
It is acceptable to skip testing in cases when CI is sufficient, or it's a markdown or code comment change only.
It is also acceptable to skip testing for changes that are too taxing to test before merging. In such case you are
responsible for the change after it gets merged which includes reverting, fixing, etc. Make sure you validate the change
ASAP after it gets merged or explain in PR when the validation will be performed.
Explain here why you skipped testing in case you did so.
Have you created automated tests for your change? Explain here which validation activities you did manually and why so.
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

/retest

/retest

/retest


TAJO-2166: Disallow csv file format in DDL Languages

I applied all your comments! :)

+1 Thanks.


Disabled button state on submission

https://trello.com/c/UTUQWWYr/21-disabled-button-state-on-submission
What
Creates a module that disables all buttons on a form on submit.
Why
We found that we allow users to submit multiple times if they continue to click on the submit button. This isn't a problem noticed on a fast connection, but on slower connections, the user doesn't receive a visual indication that something is happening.
Built a quick prototype of how we could potentially do it but needs design thinking: https://codepen.io/DilwoarH/pen/jOxyMRy
Design system solution: https://design-system.service.gov.uk/components/button/#stop-users-from-accidentally-sending-information-more-than-once
The design system solution doesn't work as it only stops it for within the first second.
Background
Original problem: https://trello.com/c/DNw6WuuA/726-using-repeated-events-as-a-metric-for-success
Screenshots
Before

After

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
Follow these steps if you are doing a Rails upgrade.

Looks good. Are there any other places this needs to be applied that we've already ported?

Looks good. Are there any other places this needs to be applied that we've already ported?

We'll have to do it as and when we notice it. Let's get this in and add other prs for any other bits


I have error after last release: Error: Flags were specified that were not recognized:    --r  Not sure what you mean there

Operating System: MacOS
Node Version: 10.6.0
NPM Version: 6.2.0-next.1
webpack Version: 4.15.1
webpack-serve Version: 2.0.1

This issue is for a:

[x] bug
[ ] feature request
[ ] modification request

there was no any error before last release
CLI Command
  webpack-serve -r ./config/webpack/client/register-ts.js --config ./config/webpack/client/webpack.config.babel.js

Expected Behavior
run server without the error
Actual Behavior
fails to start with the error
How Do We Reproduce?
try to run client script on the project

Not exactly a great issue there. Always include error messages in the body and choose succinct titles.
This is a duplicate of #213