Various issues with questions

A whole lot of the questions are ambiguously worded, incorrectly valued, or just plain silly. No offense.
I also have a problem with your 'tradition' bar in general. Generally, the political spectrum is 'change' versus 'stability'. However, you make it out to be 'science and climate change' versus 'religion and morals'. You also conflate 'Christian traditions' with the general concept of traditionalism, and progress in a particular direction with the general concept of progressivism. This doesn't do the political spectrum justice at all. I won't accuse you of agenda pushing, but it's definitely a bias showing.
Figured I'd say it up here to point out the pattern. I'll still mention it down below.
There's also the fact that nearly every question is a 10 to something. I'll point out the most obvious examples of this, but in general this really needs a rework to determine which answers split farther down the scale than others.
Anyway, on with the questions.
"It is necessary for the government to intervene in the economy to protect consumers."
Which level of intervention? Which level of protection? The question will get different answers depending on the interpretation.
"Publicly-funded research is more beneficial to the people than leaving it to the market."
This is not a tradition vs progress question. It's not even directly a progress question. By making it increase towards 'progress', and having the question itself ask which one results in more progress, you insinuate that public funding is the 'correct' answer.
"International trade is beneficial."
Nobody would possibly argue that the USA should produce all the products it would ever need on its own. I think a better question would be 'Tariffs on international trade are important to encourage local production', with inverted values, because you'd get much more of a split there.
"From each according to his ability, to each according to his needs."
Again, not really a progress vs tradition question.
"It would be best if social programs were abolished in favor of private charity."
Same complaint as above, and this isn't a question likely to have a high split (whereas asking which of the two things you would prefer to err on the side of would produce a better one).
"Public utilities like roads and electricity should be publicly owned."
That is more or less the definition of a public utility. I would replace 'public' with 'basic'. I'd also increase the point value or knock off roads, because public ownership of roads splits farther to the right than public ownership of electricity.
"Excessive government intervention is a threat to the economy."
 Where political views really split is not whether excessive government intervention is a threat, but what level of government intervention constitutes 'excessive'.
"Quality education is a right of all people."
Not a progress vs tradition question. Not even by the strange scale you used.
"The means of production should belong to the workers who use them."
I would increase the point value for this, since it splits farther to the left than the other economic questions.
"The United Nations should be abolished."
This isn't really a civil rights question, since it's about authorities governing other authorities rather than authorities controlling humans. The UN doesn't have any say in my day to day life. And I'd increase the point value slightly.
"Military action by our nation is often necessary to protect it."
Similar issue. That is definitely not a +10 to authoritarianism. We're not controlling other countries for the sake of power, we're trying to protect our own interests. It's definitely militant over pacifist, but it's not authoritarian over libertarian. It may be what the words mean, but it's not what the scales mean.
"I support regional unions, such as the European Union."
Not a progress question. Iffy on whether it's an economic question.
"It is important to maintain our national sovereignty."
This one's going the wrong way. It should be a +5 instead of a -5 (liberty of nations vs authority of other bodies).
"A united world government would be beneficial to mankind."
This should probably have increased points since it splits farther to the left.
"Wars do not need to be justified to other countries."
I don't know whether this should be a couple of points in the positive or not, but it certainly isn't authoritarian, for the same reason as the 'military action' question.
"Military spending is a waste of money."
And again here. I'm also curious why this isn't econ+5.
"My nation is great."
This is one of the aforementioned 'silly' ones. I like the country I live in. That does not affect whether I support international unions or accountability.
"Research should be conducted on an international scale."
Not a progress vs tradition question. And I'd cut that point value in half, as that splits closer to the center.
"Even when protesting an authoritarian government, violence is not acceptable."
This doesn't really fit across either of the axes you put it on. It's not related to nationalism vs internationalism, and libertarianism doesn't make violence acceptable. If anything, this would be the first one I'd actually put on the progressivism axis, since it's directly 'change vs security'.
"Our nation's values should be spread as much as possible."
Not really a libertarianism question. Or if so, then probably -5 instead of -10. The implication in this one that's different from the religion one is that in the religion one, it's a value that you hold, vs in this one, it's a value that the whole nation holds.
"It is very important to maintain law and order."
Without context (like, as opposed to?), this doesn't fit on any axis, especially not nationalism vs internationalism.
"The sacrifice of some civil liberties is necessary to protect us from acts of terrorism."
Which ones? This has no context. This is less egregious than the 'excessive government intervention' thing, but the same concept.
"Government surveillance is necessary in the modern world."
To which level?
"The very existence of the state is a threat to our liberty."
The only way this would be a relevant question to any of them is if you defined anarchy as the farthest reach of libertarianism, in which case that point value should be seriously increased.
"Regardless of political opinions, it is important to side with your country."
This is nationalism, but it isn't nationalism at the expense of internationalism. And it's also not progressivism - the idea is that you put aside your values for your country, whether they be traditionalism or progressivism.
"A hierarchical state is best."
As opposed to what? I think this is actually less authoritarian, since it's different levels of delegation instead of one big ruling body.
"The stronger the leadership, the better."
This is not nationalism vs internationalism. Unless you were talking about international unions, in which case the point value would be in the other direction.
"Democracy is more than a decision-making process."
This is incredibly vague; certainly not worth ten points for libertarianism.
"Environmental regulations are essential."
Context of extent is missing, and it's not progressivism. Climate science is not politics.
"A better world will come from automation, science, and technology."
There is no way this is +10 for progressivism. The alternative is the Amish. The split is way farther to the right than 10 points.
"Children should be educated in religious or traditional values."
Not 10 authoritarianism.  There is not a difference in the level of government intervention in schools in these sides.
"Traditions are of no value on their own."
Vague, and not worth 10. Generally traditionalism is done for an actual purpose, even if the purpose is simply the morals the traditions teach you.
"Churches should be taxed the same way other institutions are taxed."
This isn't the socialist end. Churches, as nonprofits and seriously altruistic ones at that, should not be taxed if you're redistributing money based on need. Taxing them would actually be more towards the capitalist end.
"Climate change is currently one of the greatest threats to our way of life."
Climate science is not politics. Interpretation of a nonpolitical threat to our way of life as being more or less important than others is extremely not politics.
"It is important that we work as a united world to combat climate change."
Climate science is not politics. And if it were, then it wouldn't really affect your views on internationalism, since what everyone else does affects you, so it'd generally be something you'd put aside your differences for.
"Society was better many years ago than it is now."
This doesn't relate to traditionalism. It can, but it's more about whether it's change in the wrong direction than whether it's change at all.
"It is important that we maintain the traditions of our past."
Which ones are those? In which context? Stuff like Thanksgiving or Christmas splits in a completely different place than stuff like religious ceremonies.
"It is important that we think in the long term, beyond our lifespans."
That's not progressivism. Progressivism is about making change and traditionialism/conservatism is about not making change; whether you flex towards recognizing the eventual outcome of your decisions is beside the point.
"Reason is more important than maintaining our culture."
Not worth 10 IMO. Phrased like that, few would disagree - just like with 'excessive', the definition of reasonable is what counts here, not the importance of reason vs culture.
"Drug use should be legalized or decriminalized."
You already asked that, so it effectively becomes +20 for libertarianism instead of the sensible +10.
"Same-sex marriage should be legal."
This entirely depends on whether this is interpreted to mean governmental pairing for purposes of tax and representation or to mean the cultural ceremony of wedding.
"No cultures are superior to others."
This isn't a libertarianism question. No part of this implies requirement.
"If we accept migrants at all, it is important that they assimilate into our culture."
Not authoritarian. The government isn't getting involved in the assimilation.
"Abortion should be prohibited in most or all cases."
To the untrained eye, this may seem like a libertarianism question. However, it's important to remember that the other side comes not from a position of control, but simply a religious belief that life begins at conception. The point of libertarianism which would allow human murder wouldn't be even on this graph; the argument is simply whether a fetus constitutes a human.
"Gun ownership should be prohibited for those without a valid reason."
This has nothing to do with internationalism vs nationalism.
"Governments should be as concerned about foreign citizens as they are about those within their borders."
This certainly isn't a capitalism vs socialism question, and I'd say the point value on internationalism should be higher because the entire point of paying for a government is generally considered to be for it to look out for you.
"All people - regardless of factors like culture or sexuality - should be treated equally."
That's not progressivism, that's not socialism, that's only barely libertarianism, and that's just slightly more internationalism than it is libertarianism.
"It is important that we further my group's goals above all others."
That's not capitalism, that's not nationalism, that's not traditionalism, and I'd question the point value of the authoritarianism simply because the question doesn't say whether it's important to you or important to your country or important to all of humanity.
All in all, I would say that this was definitely written by someone with a socialist, internationalist, progressivist bias. It often fails to represent the other side accurately, and the point values don't reflect the actual political values. It's a great concept and the website was clearly designed well, but the questions definitely need more research and thought put into them.

I created a pull request that removes a lot of these unconnected changes that occur; however not a lot has happened with it.

I concur with @pie-flavor, these questions could really use some refinement so they are less ambiguous and remove either/or choices. For example, consider the following choice:

Publicly-funded research is more beneficial to the people than leaving it to the market

There is no mutual exclusion between the public funding of research and allowing the market to conduct research. Hypothetically, you could have a country with a trillion dollar public research program, but still have complete freedom for companies in the private sector to conduct research as well, or to have private sector companies make proposals for that public funding.
@pie-flavor's suggestions are definitely a big step up!

I agree with a lot of the issues raised here, and some are already under consideration. I think I'll probably group some of these changes into several pull requests to fix different kinds of issue.
I do want to address each of these individually, so I'll start with the ones I definitely agree need changing.
Questions that definitely need changing

International trade is beneficial

This question certainly needs rephrasing, and I really like your suggestion about changing the question to one about tariffs and swapping the values.

From each according to his ability, to each according to his need

Yeah, I'm not sure why this is a progress question.

It would be best if social programs were abolished

Likewise for this one.

Public utilities should be publicly owned

This should definitely be changed to 'Basic utilities'.

Excessive government intervention is a threat to the economy

I agree the word 'excessive' is unhelpful here. The question would almost certainly be improved if it was simply rephrased to 'Government intervention is a threat to the economy.'

Quality education is a right of all people

This is probably not a progress question. At least, not since a few decades ago.

I support regional unions, such as the European Union

Fully agreed.

My nation is great

So this one is already under consideration, it's quite vague and so it will probably be rephrased along the lines of 'My nation is great no matter what it does' to reframe it specifically as a question of nationalism.

Our nation's values should be spread as much as possible

I think this one ought to be reduced to a -5 like you suggest.

Government surveillance is necessary in the modern world

I think some clarification would be useful here. It might even be worth splitting it into a couple of different questions to test different levels, although the current scoring system doesn't really lend itself well to that.

Democracy is more than a decision-making process

This question is vague and confusing, and definitely needs an overhaul.

Children should be educated in religious or traditional values

Definitely a good suggestion to reduce this one to -5 on the civil axis.

Reason is more important than maintaining our culture

This one definitely needs to be rephrased to get a more even 50/50 split. Maybe it could be rephrased to 'Progress is more important than maintaining our culture'? Needs some thought.

Drug use should be legalized or decriminalized.

This is a duplicate of 33! I'm surprised I hadn't noticed that before. Maybe it would help just to remove the '(such as drug use)' from Q33 and it would be 'Victimless crimes should not be crimes at all'. It might still need another example to specify though.

Same-sex marriage should be legal

At the moment, this does seem to depend on the interpretation. If rephrased to 'Same sex marriage should not be illegal', that might remove some of the ambiguity (this is definitely about the cultural side).

Gun ownership should be prohibited for those without a valid reason.

I agree, not sure why this is about nationalism.

Governments should be as concerned about foreign citizens as they are about those within their borders

Yep, this is not a socialism/capitalism question.
Questions which might need changing
These are the ones I'm less sure about. In some cases, I agree something's wrong but I'm not sure how to change it, in others I'm so-so on whether the question or its point values are wrong.

It is necessary for the government to intervene in the economy to protect consumers

So this one is fairly vague, and I think the solution to this was suggested in #80, to change it to be a question specifically about consumer protection laws.

Publicly-funded research is more beneficial to the people than leaving it to the markets

In response to the comment made about mutual exclusivity, I think that the scale of answers does allow for some nuance. For instance, someone who believes in a system of research with both public and market funding would probably choose 'Neutral' or 'Agree'. In response to the point about the progress axis, I agree that this question shouldn't affect that axis (and certainly not by +10).

The United Nations should be abolished

There's an argument both ways regarding this. While the UN doesn't necessarily have a say in your daily life directly, it certainly has the potential to. One of the UN's primary stated functions is to prevent human rights abuses, so one can definitely make the argument that support for the abolition of the UN is (even if only slightly) on the authoritarian side. That's a fairly tenuous link, so there is definitely discussion to be had as to whether the question warrants -5 on the civil axis.

Military action by our nation is often necessary to protect it

I can see why this might not be really a -10 for authoritarian, but it's worth noting that support for a strong military is certainly linked to the Authority value of the test. Maybe reducing it to a -5 would be helpful though.

Research should be conducted on an international scale

I agree this is not necessarily a progress question. Not sure about cutting the point value for the nationalism axis though, since selecting "Disagree" or "Strongly Disagree" has the same effect as "Agree" or "Strongly Agree" only negative. This is perhaps a flaw in the points system (not accounting for an uneven split) but that's less an issue with the questions and more with the system as a whole. Maybe something to fix for v2 if it ever happens.

It is very important to maintain law and order

I think the 'as opposed to' you're looking for here is maintaining civil liberties. In other words, this question is (implicitly) asking whether law and order is ever more important than civil liberties or personal freedoms, or to what extent one can be valued over the other. With that interpretation it's perhaps easier to see the link to the nationalism axis, but I do agree it's not a strong enough link to be worth 5 points.

The sacrifice of some civil liberties is necessary to protect us from acts of terrorism

The lack of context here is intentional - this question is less about one's willingness to sacrifice particular liberties (some are more important to certain people than others) but rather to assess whether security and safety are valued over freedom in a more abstract sense. For most people (at least in the US and Europe) the context comes from whichever acts of terrorism are closest to home, and whichever civil liberties have been sacrificed in the aftermath.

Regardless of political opinions, it is important to side with your country

This question's link to progressivism is fairly tenuous. Still, unquestioning allegiance to your nation regardless of political opinions can come from a place of tradition and resistance to change (respect for your country as a historical and cultural entity rather than for its values etc.). So I think the 5 points is just about warranted here.

The stronger the leadership, the better

I think this question can be interpreted two ways: it can mean authoritative leadership (civil axis) or one with a more bullish diplomatic style (nation axis). The two are strongly connected, so although this might introduce some ambiguity into the question, I can understand why it affects both these axes.

It is important that we think in the long term, beyond our lifespans

Phrased as it currently is, you're right that this question doesn't really match progressivism. I think though that it can if rephrased a little, maybe to something about embracing long-term changes.

No cultures are superior to others

I'm inclined to disagree on this point (although I see where you're coming from). The prescence of social hierarchies as implied by this question's sentiment, were someone to disagree, does necessitate a difference in social power - in other words, those of the ostensibly "superior" culture wielding power over the "inferior". That's why this question has a +5 on the civil axis, but the connection is certainly not strong enough for a +10.

Abortion should be prohibited in most or all cases

This is a tricky question to represent on these axes (given the inherently controversial nature of this issue), and I think it falls victim to one of the problems with the scoring system of the quiz as a whole. Answers on the side of 'Disagree' probably correspond with a positive change in the libertarian axis, but the reverse is not necessarily true; answering 'Agree' should not necessarily increase authoritarianism for the reasons you mention. Until the fundamental scoring system is changed, I think the best solution for now is perhaps just to reduce the civil points score to 5.

All people - regardless of factors like culture or sexuality - should be treated equally

So this question is perhaps a little misleading in the examples it gives: culture and sexuality. Really it's only about assessing belief in equality. Now that's an ambiguous term, and intentionally so; it could refer to equality of class (towards the socialist side on economic), equality of race or nationality (diplomatic axis), equality of power (civil axis) or equality of religion and sexuality (social axis). So while there are definitely issues with the way the question is worded, the values assigned to it aren't particularly askew.

It is important that we further my group's goals above all others

So this one I definitely agree the word "group" is a bit vague. In a way this is intentional, since this question is intended as the reverse of the previous one. The interpretation of group can economic class (econ axis), national identity (diplomatic axis), social class (civil axis) or religious group (social axis). So this question sort of suffers from the same issues as the previous question, and probably needs rephrasing, but I don't think the values are significantly off.
Questions I don't think need changing

The means of production should belong to the workers who use them

So in terms of the question split, unfortunately the current scoring system doesn't really take it into account (since disagree has an equal and opposite effect to agree). Maybe with v2 that can be changed, but increasing the point value for 'Agree' will also increase point value for 'Disagree'.

It is important to maintain our national sovereignty

The point values are correct here, since the civil axis refers to individual liberties. In the case of this question, the concept of "national sovereignty" refers to a lack of influence from other powers such as the EU or UN, which act as a bureaucratic hold on authoritarian policy changes.

A united world government would be beneficial to mankind

See question 15.

Wars do not need to be justified to other countries

Like with the 'military action' question, I can see why this might not be necessarily a -10 for authoritarian, but again support for a strong military is certainly linked to the Authority value of the test.

Military spending is a waste of money

Ditto.

Even when protesting an authoritarian government, violence is not acceptable

It is not so much that libertarianism makes violence acceptable, however the libertarian stance here would likely be that the power of any authoritarian government derives from its monopoly on violence, which is no more acceptable than any violence committed in protest against it. In terms of its influence on the diplomatic axis, the reason it's a 5 away from nationalism is the tendency towards a pacifist viewpoint rather than a hawkish one.

The every existence of the state is a threat to our liberty

See question 15 for why a point value increase wouldn't really help here.

A hierarchical state is best

I think you've misunderstood this one a little. It is testing one's belief in a hierarchical system of government versus a more horizontal or decentralised system. An authoritarian system with one big ruling body is still a hierarchical state, since it splits into those with power (part of the big ruling body) and those without. So this question refers more to hierarchical systems of power and governance.

Environmental regulations are essential

I wish climate science were not a political issue, but it has certainly become a polarising one in today's political climate (no pun intended), and the axis along which it polarises is necessarily the progress/traditionalism axis. Environmental regulations which would affect way of life are just the kinds of changes which this axis is designed to test resistance to.

A better world will come from automation, science, and technology

It's not necessarily true that the alternative is the Amish. I for one know plenty of people (albeit mostly in the boomer or silent generation) who are of the opinion that automation and technology are damaging our society.

Traditions are of no value on their own

Again, there are plenty of traditions (and many people who believe it is important to continue those traditions) for no particular reason other than their nature as traditions, or their history within a family or religious group. This is often framed as respect for one's history, and I believe that viewpoint is what the question refers to.

Churches should be taxed the same way other institutions are taxed

This is testing a couple of different views here (hence why it affects both the economic and social axes). It tests whether one considers churches' charitable contributions to be more valuable than the same monetary contributions being made on a government level via taxation. In other words, it tests government programs vs private charity (toward the socialist end for the former) and also trust in religious institutions (for the social axis).

Climate change is currently one of the greatest threats to our way of life

See question 43.

It is important that we work as a united world to combat climate change.

Ditto.

Society was better many years ago than it is now

This is more of an abstract question than a concrete one. Agreeing with its sentiment indicates support for the status quo or status quo ante, and so swings towards the traditionalist side.

It is important that we maintain the traditions of our past

Again, more of an abstract question about traditions in general. Also see question 15 for why the split doesn't really influence the scoring under the current system.

If we accept migrants at all, it is important that they assimilate into our culture

While the government might not be involved in the assimilation, it is likeley that they would be involved with the consequences for not assimilating.
Overall thoughts
This is a really excellent set of ideas and issues with the questions. For the first group (which definitely need changing) I will group them and start making changes to fix the issues. As to the ones I'm not sure about, I'll leave the issue open for further discussion and probably make some more commits for smaller improvements based on those issues.


Does current Google Authenticator app on the App Store build from this source?

according to this article and commit history, it seems this source repository is outdated, at least GA app on the App Store is build from other source tree.

fine, I noticed “These apps are not on the app stores, and their code has diverged from what's in the app stores, so patches here won't necessarily show up in those versions."


Buckaroo should lazily fetch recipe versions

When fetching recipes from GitHub, BitBucket and GitLab, Buckaroo will fetch every release tag to create the recipe for that project. Instead, it should lazily fetch recipe versions as part of the resolution process. This is quite a significant code change to the resolver.
This problem is seen with libraries such bson, which have over 50 releases!

Buckaroo Redux is lazy by design


Fixed syntax highlighting language to properly highlight JavaScript code

@jlattimer This has been fixed through the internal repo; thanks for your contribution.
Closing without merging.


Update config.txt

Enable SPI and I2C by default.

That have no effect, we build this dynamic. Please explain your change request a bit more.

There are Hass-supported devices that use the SPI and I2C ports on a Raspberry Pi. Since these ports are disabled by default, it forces the user to figure out how to get into the boot partition and modify the config.txt file. If they were on by default, things would just work.

Is that the default on rasbian?
buildroot-external is the layer where we can change things.

Put it in post build script of rpi


OpenACC-MPI testing in python3

Looks good. Just made a test vm from the new image and everything worked as expected.

@georgebisbas Oh, and remember to clean up CI-gpu after this goes in.

Merged! thanks


Add write permissions to account table

Apart from the actual write permissions linked to a particular publisher we need to add a is_superuser attribute. At present there is a is_admin attribute, which will mean that the user has admin rights within the publisher, while is_superuser will mean the user has write access to everything

Apart from the actual write permissions linked to a particular publisher we need to add a is_superuser attribute. At present there is a is_admin attribute, which will mean that the user has admin rights within the publisher, while is_superuser will mean the user has write access to everything

Most of the tables have a hierarchy of relations with the publisher on top (e.g. Publisher > Imprint > Work), however, the are two exceptions: Contributor and Funder. We need to discuss how these will be managed. It makes sense to share these records between publishers to avoid duplication, but we need to check any concerns on doing so, and decide how editing of shared records will be controlled

Most of the tables have a hierarchy of relations with the publisher on top (e.g. Publisher > Imprint > Work), however, the are two exceptions: Contributor and Funder. We need to discuss how these will be managed. It makes sense to share these records between publishers to avoid duplication, but we need to check any concerns on doing so, and decide how editing of shared records will be controlled

Apart from the actual write permissions linked to a particular publisher we need to add a is_superuser attribute. At present there is a is_admin attribute, which will mean that the user has admin rights within the publisher, while is_superuser will mean the user has write access to everything

I think that if we have a new table linking account and publisher we can move the is_admin attribute there since the new meaning will be specific to a publisher

Apart from the actual write permissions linked to a particular publisher we need to add a is_superuser attribute. At present there is a is_admin attribute, which will mean that the user has admin rights within the publisher, while is_superuser will mean the user has write access to everything

I think that if we have a new table linking account and publisher we can move the is_admin attribute there since the new meaning will be specific to a publisher


Allow admins to invite other staff

🔗 Issue
Fixes #226
✍ Description
This Pull Request adds the functionality of inviting new staff members to the organization by administrators (staff admins) using the devise_invitable gem. The invitation acceptance flow is currently in a basic form but improvements will be addressed in a subsequent PR.
📷 Screenshots/Demos
https://github.com/rubyforgood/pet-rescue/assets/96994176/bf5a4266-1dcb-49e6-aec7-b88359a0a88b

These are great suggestions! Should we make them into tickets?

Looks great! I tested it out locally and I like it.
I know you said you had improvements to follow in another PR, so the following is my thoughts, some which you may already have considered:
* I am guessing the `invite!` call on line 16 of `Organizations::InvitationsController` is triggering the mailer. I am wondering if we are able to send any params to that? It would be good to send the organization so we can access its name and slug and recreate the Org's Url in the email e.g., https://www.petrescue.com/baja

* The redirect after the invited user enters and saves their password to accept the invite, is this coming from registrations_controller   def after_sign_in_path_for ? This is another place where it would be good to scope it to the organization's dashboard rather than the root path, if possible.

* I think we could use the invitation_accepted_at column in the staff table to indicate whether or not the staff has accepted the invite in the staff table (not directly related to this work) e.g., in the status column

Thank you @kasugaijin and @nsiwnf for the review! 💪
I will create separate issues for your suggestions and start working on them soon :)


NIFI-7139 Add record.error.message on failure of a record reader or w…

…riter
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Adds an attribute record.error.message to failing flow files to expose the error message to down stream processors.
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

So I'm breaking a test case in TestConvertRecord that checks to see if the flow file was modified when being routed to failure. Adding attributes creates a new flow file so while the contents haven't changed the object isn't the same.

I can change the check to compare the contents of the flow file instead since that's really what matters.

Rebased with master and moved WritesAttributes out of the abstract class for now.

My build environment has died so I don't know if this will compile or not.

+1 LGTM, ran contrib-check and tested on a live NiFi, verified the error attribute is added with the appropriate error message. Thanks for the improvement! Merging to master


Change default of restart policy to RecreateGroupOnPodRestart

What would you like to be added:
Change default of restart policy to RecreateGroupOnPodRestart.
Why is this needed:
It will be the most commonly used restart policy.
Completion requirements:
This enhancement requires the following artifacts:

[ ] Design doc
[ ] API change
[ ] Docs update

The artifacts should be linked in subsequent comments.

/assign

We should change the name as well, or Default policy but not default, and default is somehow unclear, default for what? Maybe None, which means the lws will not do anything, it's all the pod behavior.

hmm, unfortunately we can't remove it, but perhaps we can add a None value and in the webhook we re-write anything that sets Default to None.

For backwards compatibility? We can mark it as deprecated and remove that in the future.

Sounds good, do you have time to do this?

on the way.


Encoding_Error: failed to unmarshal KDC's reply: asn1: syntax error: sequence truncated

I know this error was posted before but i can't seem to figure out how to fix it.
When trying to userenum (I'm doing the Attacking Kerberos Room on THM atm) it doesn't work so I tried -v to see what was going on.
For every single user checked it gave me this error message: "[Root cause: Encoding_Error] Encoding_Error: failed to unmarshal KDC's reply: asn1: syntax error: sequence truncated"
I don't know how to fix it.
Here might be some steps on how to replicate it (I'm using a Kali Linux VM):
Download kerbrute_linux_amd64
chmod +x kerbrute_linux_amd64
./kerbrute_linux_amd64 userenum --dc CONTROLLER.local -d CONTROLLER.local User.txt
Edit: Only workaround i found was editing /etc/hosts with "ip	CONTROLLER.local"

i am also having the same issues

    __             __               __
   / /_____  _____/ /_  _______  __/ /____
  / //_/ _ \/ ___/ __ \/ ___/ / / / __/ _ \
 / ,< /  __/ /  / /_/ / /  / /_/ / /_/  __/
/_/|_|\___/_/  /_.___/_/   \__,_/\__/\___/

Version: dev (9cfb81e) - 07/22/22 - Ronnie Flathers @ropnop

2022/07/22 14:47:23 >  Using KDC(s):
2022/07/22 14:47:23 >   CONTROLLER.local:88

2022/07/22 14:47:25 >  [!]   <link crossorigin="anonymous" media="all" integrity="sha512-ksfTgQOOnE+FFXf+yNfVjKSlEckJAdufFIYGK7ZjRhWcZgzAGcmZqqArTgMLpu90FwthqcCX4ldDgKXbmVMeuQ==" rel="stylesheet" href="https://github.githubassets.com/assets/light-92c7d381038e.css" /><link crossorigin="anonymous" media="all" integrity="sha512-1KkMNn8M/al/dtzBLupRwkIOgnA9MWkm8oxS+solP87jByEvY/g4BmoxLihRogKcX1obPnf4Yp7dI0ZTWO+ljg==" rel="stylesheet" href="https://github.githubassets.com/assets/dark-d4a90c367f0c.css" /><link data-color-theme="dark_dimmed" crossorigin="anonymous" media="all" integrity="sha512-cZa7DZqvMBwD236uzEunO/G1dvw8/QftyT2UtLWKQFEy0z0eq0R5WPwqVME+3NSZG1YaLJAaIqtU+m0zWf/6SQ==" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_dimmed-7196bb0d9aaf.css" /><link data-color-theme="dark_high_contrast" crossorigin="anonymous" media="all" integrity="sha512-WVoKqJ4y1nLsdNH4RkRT5qrM9+n9RFe1RHSiTnQkBf5TSZkJEc9GpLpTIS7T15EQaUQBJ8BwmKvwFPVqfpTEIQ==" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_high_contrast-595a0aa89e32.css" /><link data-color-theme="dark_colorblind" crossorigin="anonymous" media="all" integrity="sha512-XpAMBMSRZ6RTXgepS8LjKiOeNK3BilRbv8qEiA/M3m+Q4GoqxtHedOI5BAZRikCzfBL4KWYvVzYZSZ8Gp/UnUg==" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_colorblind-5e900c04c491.css" /><link data-color-theme="light_colorblind" crossorigin="anonymous" media="all" integrity="sha512-3HF2HZ4LgEIQm77yOzoeR20CX1n2cUQlcywscqF4s+5iplolajiHV7E5ranBwkX65jN9TNciHEVSYebQ+8xxEw==" rel="stylesheet" data-href="https://github.githubassets.com/assets/light_colorblind-dc71761d9e0b.css" /><link data-color-theme="light_high_contrast" crossorigin="anonymous" media="all" integrity="sha512-+J8j3T0kbK9/sL3zbkCfPtgYcRD4qQfRbT6xnfOrOTjvz4zhr0M7AXPuE642PpaxGhHs1t77cTtieW9hI2K6Gw==" rel="stylesheet" data-href="https://github.githubassets.com/assets/light_high_contrast-f89f23dd3d24.css" /><link data-color-theme="light_tritanopia" crossorigin="anonymous" media="all" integrity="sha512-AQeAx5wHQAXNf0DmkvVlHYwA3f6BkxunWTI0GGaRN57GqD+H9tW8RKIKlopLS0qGaC54seFsPc601GDlqIuuHg==" rel="stylesheet" data-href="https://github.githubassets.com/assets/light_tritanopia-010780c79c07.css" /><link data-color-theme="dark_tritanopia" crossorigin="anonymous" media="all" integrity="sha512-+u5pmgAE0T03d/yI6Ha0NWwz6Pk0W6S6WEfIt8veDVdK8NTjcMbZmQB9XUCkDlrBoAKkABva8HuGJ+SzEpV1Uw==" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_tritanopia-faee699a0004.css"<EMAIL_ADDRESS>- KRB Error: (60) KRB_ERR_GENERIC Generic error (description in e-text)
2022/07/22 14:47:29 >  Done! Tested 31 usernames (0 valid) in 5.457 seconds

I had the same problem but I solved it by putting the IP instead of the domain name.
I think the problem comes from a bad resolution that Kerbrute can't handle, but I'm not sure.

I know this thread is old however, I can not overcome this issue with my domain in the /etc/hosts file or using raw IP.
Steps to reproduce: Parrot OS VM in VMWare Workstation Pro 17 connected over OpenVPN to target network on HackTheBox Office machine. Issuing the command:
./kerbrute userenum -d office.htb --dc dc.office.htb /path/to/usernames -v
My hosts entry contains:
X.X.X.X  office.htb
Compiling kerbrute from source seems to show a slightly different error of trying to use a different interface than the OpenVPN tunnel to perform host discovery but I have no way to define a specific interface to use and by mapping Kerbrute should see the network.
I understand this is a HackTheBox machine and could be a fault on their end. I have confirmed the DC name and reset the target environment many times. I haven't seen any other users with the issue.


pull in gtest source into subdir gtestsrc

replace '--enable-gtest=...' with '--enable-gtest' in the cmd of compiling libyami
remove gtest.m4

Signed-off-by: Zhziyao<EMAIL_ADDRESS>

Also, please rebase.

Hi, @uartie
updated. Please help review.Thanks.

Hi, @uartie
Thank you for your patient explanation.
updated and help review.

@uartie good suggestion, we did not notice it.
thanks

OK. The "Testing" section of README is modified. Please help review.

thanks @uartie  for review


Load project from X: hard drive

Hi all,
I need to load project from D drive!
From the GUI, I cannot select a different drive than C:

addressed via https://github.com/microsoft/BotFramework-Composer/pull/2274

need to test it on linux system today.

addressed via https://github.com/microsoft/BotFramework-Composer/pull/2412


Can't load .emacs

The .emacs from https://commercialhaskell.github.io/intero/ leads to "error: Package `emacs-24.4' is unavailable". This openSUSE machine has 24.3 and upgrading would be a can of worms according to the admin. Does that dependency need to be hard?

Yes, sorry. Emacs 24.4 was released on 2014-10-20, and you should reasonably expect to develop on a machine which has newer software, even if your deployment target machine is older.


Do not execute startup code if there isn't any

For #8879

Codecov Report

Merging #8880 (1151da1) into main (f154b75) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            main   #8880   +/-   ##
=====================================
  Coverage     71%     71%
=====================================
  Files        382     382
  Lines      24695   24695
  Branches    3805    3805
=====================================
+ Hits       17665   17668    +3
- Misses      5499    5500    +1
+ Partials    1531    1527    -4

Impacted Files
Coverage Δ

src/client/datascience/jupyter/kernels/kernel.ts
75% <100%> (+<1%)
:arrow_up:

src/client/datascience/dataScienceSurveyBanner.ts
73% <0%> (-2%)
:arrow_down:

src/client/common/process/baseDaemon.ts
44% <0%> (-2%)
:arrow_down:

src/client/debugger/jupyter/kernelDebugAdapter.ts
77% <0%> (+<1%)
:arrow_up:

...t/datascience/notebook/vscodeNotebookController.ts
80% <0%> (+<1%)
:arrow_up:

...lient/datascience/variablesView/notebookWatcher.ts
93% <0%> (+2%)
:arrow_up:


[release-4.11] OCPBUGS-15567: Fix flake MetalLB resources should have correct statuses

cherry-pick of: #183
Note:

The fix for the flake is in the commit: "Use the DeployTimeout const in e2etest".
The other commits are different improvements that were add together with the fix,
that makes sense to include them here as well.
The commit "Update kind's node image" was omitted deliberately.

/lgtm

/approve

/label backport-risk-assessed

/override ci/prow/ci-index-upgrade-bundle

/override ci/prow/operator-e2e-upgrade

/jira refresh

/label cherry-pick-approved


cannot install project

$ go get -u -v github.com/Xe/x/cmd/dnsd@latest
go: cannot use path@version syntax in GOPATH mode

$ go get -u -v github.com/Xe/x/cmd/dnsdgithub.com/Xe/x (download)
github.com/miekg/dns (download)
# cd /Users/user/go/src/github.com/miekg/dns; git pull --ff-only
error: cannot open .git/FETCH_HEAD: Permission denied
package github.com/miekg/dns: exit status 1
github.com/mmikulicic/stringlist (download)
Fetching https://within.website/x/internal?go-get=1
Parsing meta tags from https://within.website/x/internal?go-get=1 (status code 200)
get "within.website/x/internal": found meta tag get.metaImport{Prefix:"within.website/x", VCS:"git", RepoRoot:"https://github.com/Xe/x"} at https://within.website/x/internal?go-get=1
get "within.website/x/internal": verifying non-authoritative meta tag
Fetching https://within.website/x?go-get=1
Parsing meta tags from https://within.website/x?go-get=1 (status code 200)
within.website/x (download)
github.com/joho/godotenv (download)
Fetching https://go4.org/legal?go-get=1
Parsing meta tags from https://go4.org/legal?go-get=1 (status code 200)
get "go4.org/legal": found meta tag get.metaImport{Prefix:"go4.org", VCS:"git", RepoRoot:"https://github.com/go4org/go4"} at https://go4.org/legal?go-get=1
get "go4.org/legal": verifying non-authoritative meta tag
Fetching https://go4.org?go-get=1
Parsing meta tags from https://go4.org?go-get=1 (status code 200)
go4.org (download)
Fetching https://within.website/confyg/flagconfyg?go-get=1
Parsing meta tags from https://within.website/confyg/flagconfyg?go-get=1 (status code 200)
get "within.website/confyg/flagconfyg": found meta tag get.metaImport{Prefix:"within.website/confyg", VCS:"git", RepoRoot:"https://github.com/Xe/confyg"} at https://within.website/confyg/flagconfyg?go-get=1
get "within.website/confyg/flagconfyg": verifying non-authoritative meta tag
Fetching https://within.website/confyg?go-get=1
Parsing meta tags from https://within.website/confyg?go-get=1 (status code 200)
within.website/confyg (download)
Fetching https://within.website/confyg?go-get=1
Parsing meta tags from https://within.website/confyg?go-get=1 (status code 200)
get "within.website/confyg": found meta tag get.metaImport{Prefix:"within.website/confyg", VCS:"git", RepoRoot:"https://github.com/Xe/confyg"} at https://within.website/confyg?go-get=1
Fetching https://within.website/ln?go-get=1
Parsing meta tags from https://within.website/ln?go-get=1 (status code 200)
get "within.website/ln": found meta tag get.metaImport{Prefix:"within.website/ln", VCS:"git", RepoRoot:"https://github.com/Xe/ln"} at https://within.website/ln?go-get=1
within.website/ln (download)
github.com/pkg/errors (download)
Fetching https://within.website/ln/opname?go-get=1
Parsing meta tags from https://within.website/ln/opname?go-get=1 (status code 200)
get "within.website/ln/opname": found meta tag get.metaImport{Prefix:"within.website/ln", VCS:"git", RepoRoot:"https://github.com/Xe/ln"} at https://within.website/ln/opname?go-get=1
get "within.website/ln/opname": verifying non-authoritative meta tag
Fetching https://within.website/ln?go-get=1
Parsing meta tags from https://within.website/ln?go-get=1 (status code 200)
Fetching https://within.website/x/cmd/license/licenses?go-get=1
Parsing meta tags from https://within.website/x/cmd/license/licenses?go-get=1 (status code 200)
get "within.website/x/cmd/license/licenses": found meta tag get.metaImport{Prefix:"within.website/x", VCS:"git", RepoRoot:"https://github.com/Xe/x"} at https://within.website/x/cmd/license/licenses?go-get=1
get "within.website/x/cmd/license/licenses": verifying non-authoritative meta tag
Fetching https://within.website/x/internal/flagenv?go-get=1
Parsing meta tags from https://within.website/x/internal/flagenv?go-get=1 (status code 200)
get "within.website/x/internal/flagenv": found meta tag get.metaImport{Prefix:"within.website/x", VCS:"git", RepoRoot:"https://github.com/Xe/x"} at https://within.website/x/internal/flagenv?go-get=1
get "within.website/x/internal/flagenv": verifying non-authoritative meta tag
Fetching https://within.website/x/internal/manpage?go-get=1
Parsing meta tags from https://within.website/x/internal/manpage?go-get=1 (status code 200)
get "within.website/x/internal/manpage": found meta tag get.metaImport{Prefix:"within.website/x", VCS:"git", RepoRoot:"https://github.com/Xe/x"} at https://within.website/x/internal/manpage?go-get=1
get "within.website/x/internal/manpage": verifying non-authoritative meta tag
Fetching https://within.website/x/web?go-get=1
Parsing meta tags from https://within.website/x/web?go-get=1 (status code 200)
get "within.website/x/web": found meta tag get.metaImport{Prefix:"within.website/x", VCS:"git", RepoRoot:"https://github.com/Xe/x"} at https://within.website/x/web?go-get=1
get "within.website/x/web": verifying non-authoritative meta tag
github.com/celrenheit/sandflake (download)

$ GOBIN=$(pwd) go install github.com/Xe/x/cmd/dnsd
../../../../go/src/github.com/Xe/x/cmd/dnsd/main.go:17:2: use of internal package within.website/x/internal not allowed

I'm guessing its because of the internal package?

Try this:
``console
$ export GO111MODULE=on
$ go get -v within.website/x/cmd/dnsd

; <<>> DiG 9.10.6 <<>> @localhost youtube.com
; (2 servers found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 62794
;; flags: qr aa rd; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0
;; WARNING: recursion requested but not available

;; QUESTION SECTION:
;youtube.com.                   IN      A

;; Query time: 2005 msec
;; SERVER: ::1#53(::1)
;; WHEN: Wed Jul 03 01:35:13 CEST 2019
;; MSG SIZE  rcvd: 29```

not sure why, the server has been started, am I missing something?

$ docker ps
CONTAINER ID        IMAGE                         COMMAND                  CREATED              STATUS              PORTS                NAMES
32409e99d8e6        xena/dnsd:v1.1.2              "sh /usr/sbin/entryp…"   About a minute ago   Up 2 seconds        <IP_ADDRESS>:53->53/udp   dnsd

$ docker container logs 324 -f
2019/07/02 23:47:56 conf: -zone-url=https://xena.greedo.xeserv.us/files/akua.zone
2019/07/02 23:47:56 conf: -zone-url=https://xena.greedo.xeserv.us/files/adblock.zone
2019/07/02 23:47:56 conf: -port=53
2019/07/02 23:47:56 conf: -forward-server=<IP_ADDRESS>:53
2019/07/02 23:47:57 https://xena.greedo.xeserv.us/files/akua.zone: 63 records
2019/07/02 23:48:00 https://xena.greedo.xeserv.us/files/adblock.zone: 85435 records
2019/07/02 23:48:56 stored https://xena.greedo.xeserv.us/files/akua.zone:"ptxr5a2eo"
2019/07/02 23:48:56 stored https://xena.greedo.xeserv.us/files/adblock.zone:"ppcc1u1xcfd"

$ dig @localhost youtube.com

; <<>> DiG 9.10.6 <<>> @localhost youtube.com
; (2 servers found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 25265
;; flags: qr aa rd; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0
;; WARNING: recursion requested but not available

;; QUESTION SECTION:
;youtube.com.			IN	A

;; Query time: 2002 msec
;; SERVER: <IP_ADDRESS>#53(<IP_ADDRESS>)
;; WHEN: Wed Jul 03 01:48:29 CEST 2019
;; MSG SIZE  rcvd: 29

$ dig @localhost youtube.com +trace

; <<>> DiG 9.10.6 <<>> @localhost youtube.com +trace
; (2 servers found)
;; global options: +cmd
;; Received 17 bytes from <IP_ADDRESS>#53(localhost) in 2003 ms

note, I am running locally on a macos, I will try on a linux server such as digitalocean,scaleway or hetzner if needed, not sure it matters

This is odd. I'm going to dig more into this. I have never seen it error like this before.

Hey, sorry to bother, it might be because of the weird VPN configuration I have; I've tested on my home PC and it works as expected, please feel free to close this one.

On Jul 4, 2019, at 12:57 AM, Christine Dodrill<EMAIL_ADDRESS>wrote:
This is odd. I'm going to dig more into this. I have never seen it error like this before.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Xe/x/issues/18?email_source=notifications&email_token=ACFXUL7WW75L5QVBHMDISETP5UVEPA5CNFSM4H5ASSE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZF4FEA#issuecomment-508281488, or mute the thread https://github.com/notifications/unsubscribe-auth/ACFXUL57ISPGBTYJAZ7Y7VDP5UVEPANCNFSM4H5ASSEQ.


APEX-186 Enable license header check in Travis CI.

@vrozov please review

Yes, we want to run verify, which includes test as well as apache-rat:check and other checks that need to occur.
The 3 files that have a warning need to be added to the exclusion list.

apache-rat:check by default binds to validate phase. Did we change it to run during verify?
Will you add 3 files to the exclusion list or they were already added to the exclusion list as part of a different commit/pull request?

Added the 3 files to exclusion list.

These checks all run after test (japicmp, license, rat). That's good, don't want these to run on every iteration during development.

japicmp and maven license checks do run during verify. checkstyle plugin runs during validate as well as enforcer. apache-rat does not run at all unless explicitly invoked by "mvn apache-rat:check". Should apache-rat be enabled for automatic run during verify? I think that we need to have it enabled, so that committers can execute "mvn clean verify" and not to wary that not all checks are passed.
Will it be better to fail build due to license or checkstyle violation before tests are executed as tests take most of the time? If developer/contributor wants to skip license/checkstyle validation, can they do this using command line parameters/properties/flags?

checkstyle can be skipped by : mvn clean install -Dcheckstyle.skip
We can also run mvn with fail-never option to see all the failures at the end.
Don't mean to divert the discussion but I think we can reduce the no. of plugins by getting rid of license check. License can be validated by checkstyle as well.

@chandnisingh This change is about what runs in Travis CI. The license header check does not run in the development environment unless you do the -Dlicense.skip=false
@vrozov Good catch, I'm going to add the apache-rat:check as a goal to the Travis CI script. I would prefer to keep the "main loop" of the development build light. Things like japicmp and license header check add to the build time, they can come late in the build lifecycle. The important thing is these issues are caught in the PR CI.

Personally I don't mind few seconds extra time for checkstyle and license check during main development lifecycle as test consumes most of the time and I don't want to rerun tests after fixing code style or missing/incorrect license. At the same time, if license and code style templates are integrated into IDE, those checks are redundant most of the time. Can we get more attention to https://malhar.atlassian.net/browse/APEX-137 and define workflow for contributors/committers.
It looks that Travis CI status is ignored (https://travis-ci.org/apache/incubator-apex-malhar/builds).
It will be nice to have something like https://issues.apache.org/jira/browse/HDFS-9181?focusedCommentId=14946362&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14946362.

Made the script change.
+1 for attention to APEX-137 :-)


Lint uses of include_str/include_bytes

This is probably required to avoid issues in cases where people include_bytes! things like keys and certificates.

Surprised I managed to get all the cases. But it turns out we already had diagnostic items for these.

ha!  this is great!

Thanks for taking care of that nit, Jubilee!


Propose a new inlay hint that marks the declared name of a definition

void foo() {
} // foo

An example is shown above where we could add "// foo" to the end of function definition. This is helpful to identify the end of a long function. Also, the idea applies to struct/class/namespace definition as well

This is actually very easy to implement. A prototype implementation is at https://github.com/daiyousei-qz/llvm-project/tree/inlay_hint_end_function.

As a vscode user, I suppose I could always resort to the breadcrumb bar.

Not sure if other editors offer a feature like that.

Yes, we can. Also, stickySchroll feature in vscode could also help identify the context. However, have an inlay hint there could make the boundary more identifiable since it is right in the place where the definition ends. In practice, in LLVM codebase we are already adding "// namespace XX" as part of the code, so I suppose this is reasonable feature to add.
Of course, we'll have more details to discuss about when we should add the inlay hints if we are moving forward with this feature. Namely,

What if the definition only consumes one line
What if user already put manual annotation there
What if the definition is a fairly short one or even an empty one
.etc

Yes, we can. Also, stickySchroll feature in vscode could also help identify the context. However, have an inlay hint there could make the boundary more identifiable since it is right in the place where the definition ends. In practice, in LLVM codebase we are already adding "// namespace XX" as part of the code, so I suppose this is reasonable feature to add.
Of course, we'll have more details to discuss about when we should add the inlay hints if we are moving forward with this feature. Namely,

What if the definition only consumes one line
What if user already put manual annotation there
What if the definition is a fairly short one or even an empty one
.etc

Rust-analyzer has already implemented this same feature, so maybe it would we helpful to look at their implementation regarding these details

This seems reasonable to me.

What if the definition only consumes one line
What if the definition is a fairly short one or even an empty one

As a first cut I'd try adding it whenever the opening and closing brace are on different lines, and see whether that feels too noisy.

What if user already put manual annotation there

For param etc hints, we approx-parse /*foo=*/ type comments and suppress if they match the hint we'd generate, probably best to be consistent. Namespace comments are the most important because clang-format adds them.

Hey, I submitted a review at https://reviews.llvm.org/D150635. Also, git branch is at https://github.com/daiyousei-qz/llvm-project/tree/inlay_hint_end_function in case anyone is interested to try it out.

It roughly looks like what's shown above. Forgive the verboseness to short the image. The minimal lines of definition for this to shown is configurable so in practice it should look better.

Currently it's shown before ';' in a form like a comment. It's done so because technically ';' is part of the declarator instead of the type declaration. I'm okay with that, but comments are welcome.
What should be the default value for minimal required lines for definitions? 1 is obviously too verbose as shown above. 2? 10? 100?

Currently it's shown before ';' in a form like a comment. It's done so because technically ';' is part of the declarator instead of the type declaration. I'm okay with that, but comments are welcome.

Any reason for using the /* */ style instead of // ?

What should be the default value for minimal required lines for definitions? 1 is obviously too verbose as shown above. 2? 10? 100?

For rust-analyzer apparently it's 25:
rust-analyzer.inlayHints.closingBraceHints.minLines (default: 25)
Minimum number of lines required before the } until the hint is shown (set to 0 or 1 to always show them).

https://rust-analyzer.github.io/manual.html#inlay-hints

Any reason for using the /* */ style instead of // ?
Because a trailing ';' may follow the hint, I want to avoid creating an illusion that things after the hint are commented.

For rust-analyzer apparently it's 25
Thank you! I thought this is still an in-dev feature since the inlay-hint section doesn't mention it.

Fixed by https://reviews.llvm.org/D150635. Thanks, @daiyousei-qz!

@daiyousei-qz could you also submit a patch to https://github.com/llvm/clangd-www to document the new config key added in this patch please?


multiple frontend changes on multi-select lists

A wonderful example for 'How to communicate'.
For the curious: implements a 'select all' button, and changes the multiselection from the whole data row to just the first column.

changes the multiselection from the whole data row to just the first column.

not just the first column, but to the columns that have otherwise no secondary click functions.

Worked through the annotations and added deselectAll


bug: Cordova 5 compatibility

Type: bug
Platform: all
I am considering to migrate to Cordova 5 but I have doubts about compatibility issues with Ionic, ngCordova and cordova plugins
Is Ionic fully compatible with Cordova 5?

Ionic will work with Cordova 5.0.


More useful message for folks without a Plotly account (who don't know they need one)

Feedback email:
"I did have a little trouble though — I started with plotly after I forked an ipython notebook that made a plotly based plot. Naturally, I got an error since I didn’t log in. I had no idea I had to set up an account. The error message was something like username can’t be empty…  Perhaps a more useful error message could occur if you try to plot with out an account. (Though I imagine my route to using plotly is not usual) What would get me to only use plotly? I guess a script I could enable to translate all my matplotlib code into plotly. Until then, I think I’ll just be using plotly when I want interactive plots."

:+1:

Gonna close this for now, I just tried using plotly without a .plotly file and got the following error:
PlotlyLocalCredentialsError:
Couldn't find a 'username', 'api-key' pair for you on your local machine. To sign in temporarily (until you stop running Python), run:
>>> import plotly.plotly as py
>>> py.sign_in('username', 'api_key')

Even better, save your credentials permanently using the 'tools' module:
>>> import plotly.tools as tls
>>> tls.set_credentials_file(username='username', api_key='api-key')

For more help, see https://plot.ly/python.

Seems pretty helpful! Unless there's another path to unhelpfulness, this seems like a non-issue.

+1 It wasn't immediately clear to me that plotly needs a login to work. I suggest adding something along the lines of "A valid username and password is necessary to use plotly"


Added some missing parameters to camera.

auto_wb
wb_kr
wb_kg
wb_kb

This looks good to me and I will merge it as soon as I am able to run the tests with a camera connected. This may however still take a few days, since I don't have physical access to the cameras at the moment. Thank you for your contributions!

I made the changes you requested.


equalTo should support multiple value in it with and and or condition.

hi
is there any way to check or and condition on the property value.
this.af.database.list("refChild", {
query: {
orderByChild: 'age',
equalTo: 28 or 29
}
});
currently for doing same i need to do the query twice. so i want to avoid this.

I don't think this is supported. Did you look at QueryBase .

I think startAt(28).endAt(29) should work.

@sabhiyan Hello, we have an issue template that is required for submitting issues. Can you please resubmit this issue following the template?


Can TPO Host / Developer with battery sell battery power when grid charging is allowed?

TPO Host / Developer PV Battery configurations use BTM battery dispatch with an FOM financial model. The host pays the developer for all power generated by the system. The battery dispatches to reduce monthly electricity bills.
The PV Battery and Generic Battery configurations report both CF_energy_sales ("Electricity generation") for power to the grid from system including from the battery, and CF_energy_without_battery ("Electricity generated without storage") for power from the system only.
For the Host / Developer model, should PPA revenue be calculated from CF_energy_sales or CF_energy_without_battery? If the battery charges from the grid and then discharges, would those kWh factor into the PPA agreement at all? (or should host-developer batteries be prevented from charging from the grid for this reason?)

Discussion from SAM meeting 10/24 there are potentially financially beneficial scenarios to grid charging where the grid power price plus the TPO PPA price would arbitrage to making selling back to the grid worthwhile. Therefore CF_energy_sales is the right variable.
This also covers cases where the PV is very small.

No changes are required to ssc based on the above discussion, cf_energy_sales is already used to calculate the host agreement cost and revenue for the developer.
@cpaulgilman The below shows an example of the PV-battery host-developer case where the battery can charge from the grid. Do you see a need for any changes to the cash flow tabs based on the host agreement cost being correct from ssc?

@brtietz I don't think this requires a change to the cash flow.

Thanks for double checking! Closing since no changes are required.


Python 2/3 compatible version

Basic test passing, further testing is needed. For Python 3 it uses git@github.com:awetzel/python-erlastic.git version which is not compatible with Python 2.

Oh man, totally forgot about awetzel's patch for erlastic. Just merged it. Thanks for bringing this up again.

Thanks for the patch as well.

Thanks Samuel, you’re welcome. Any chance to have pypi package updated as well. Maybe I could work on awetzel's code to make it python2/3 compatible to...
Best regards

I'll push it out to pypi now. If you can get erlastic to be both 2 and 3 compatible that could be awesome.


Should non-OSS binaries/artifacts in jlls be allowed to be registered?

We currently require all packages registered in the registry to have a valid OSI license.
Should a jll with a closed source artifact be allowed to be registered in the General registry. This could happen for Yggdrasil or non-Yggdrasil jlls. Currently the Julia source in an Yggdrasil jll is licensed as MIT, which passes our license checks, but this does not preclude the artifact itself being non-open-source.
The concern here is that this allows inadvertent license violations, through implicit dependencies, that are hard to protect against.  That is is the main argument for our current rule for only allowing OSI licensed packages.
Put aside the question of how we would detect or enforce this. Lets agree on the overall policy first.

Thinking out aloud, the policy should be about having the license to distribute (rather than it being a valid OSI license). In my mind, where this comes from is making it easy for the user.
Debian has their non-free repo, to clearly separate out software that has non-DFSG licenses, but they do distribute:
https://www.debian.org/doc/debian-policy/ch-archive#s-non-free

Just to clarify, this discussion is only for binary artifacts, right?
I.e. no matter what, we'll still require that Julia packages themselves are OSI, and for wrapper code that wraps binaries, we'll require that the wrapper code is OSI? And the only thing that we are discussing here is if the binary artifacts will be allowed to be non-OSI as long as they are allowed to be distributed?
Is this correct?

I would say copied, distributed and used. At least in some source code licenses I've seen a distinction between those, and in some licenses they are explicitly mentioned as allowed. Just my 50 cents, though, since I'm no expert on the legalese.

Thinking out aloud, the policy should be about having the license to distribute (rather than it being a valid OSI license).

You might have e.g. MKL, and MKL_jll in mind. Purist would be against non-free, even Debian: https://www.gnu.org/distros/common-distros.en.html
I'm conflicted, as if we would disallow we might end up with just MKL.jl (which is OSI, that is just the wrapper), and no MKL_jll, making installation harder, as we had to do before, just install dependencies manually. It's unclear if even that would satisfy (they wouldn't install themselves), as considering promoting non-free, even without actually distributing any non-free...
https://github.com/JuliaBinaryWrappers/MKL_jll.jl/blob/main/LICENSE
As I see it needs to be clear what your getting, e.g. in MKL_jll, but also in MKL.jl, as most users would never look at each dependency.
Is there already a rule that states, all non-jll dependencies must be OSI? It's implicit if those are registered packages, so the question is really, can you depend on non-registered package?


todoman: 4.1.0 -> 4.3.1

Description of changes
Package changed to pyproject.toml in version 4.3.0. I also changed a bit around the tests, but I think more could be done - most of the disabled tests passed on my machine.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@antonmosich consider adding yourself as maintainer as well if you end up sending a future PR for this package :)


Conda installation for python=3.7 and 3.8 takes too long

conda install -c conda-forge -c esmvalgroup esmvaltool or conda create -y esmvaltool && conda install -c conda-forge -c esmvalgroup esmvaltool using python=3.7 and 3.8 take an eternity, some runs go through but after hours. Environment solving is at fault, just like the case of conda-build that I sorted out only by forcing the build with python=3.9. Conda offering us diminishing support for env solving for older Python version, a very bad approach and lack of foresight. Both conda=4.9.2 and 4.10.1 show the same behavior and are unable to perform the install. Possible solutions: use mamba instead of conda (although the latest mamba=0.10.0 wants python=3.9) or drop support for Python<3.9 - as in, not drop support per se, but allow installation of Python=3.9 when installing esmvaltool from conda/with mamba (this wouldn't affect the user). Up for other ideas as well!

Of course, hoping that when @zklaus will put esmvaltool on conda-forge all these issues will be solved by miracle :grin:

What are the downsides of dropping support for Python<3.9?

no downsides but we want to have a wider reach - I personally don't like supporting multiple versions of Python if there is no specific reason (and there isn't one for us since they all do the same thing and all the deps we have support Python 3.9, no performance cliff either) - but again, this should be decided at a technical governance level


Wheels for arm64

Hey everyone,
First of all, thank you so much for the work on this project. It is performing really well and is awesome to use.
We ran into some problems when hosting pyvroom on our platform, though, as we are currently limited to arm64 architecture. This is subject to change in future; however, we wanted to support pyvroom earlier. For this, I created a small project that compiles pyvroom wheels for additional platforms as a temporary solution. You can find it here: pyvroomwheels.
This was done to quickly unblock us; however, I would be happy to contribute something back to the main project if you are interested / it makes sense.
Thanks again for the great work!
Best,
Marius

That is very neat! If you can contribute a patch that would be much appriciated!

I only did subtle changes to the build. I made some more changes to the release workflow, but most were just needed to make the additional package and its builds work (pyvroomwheels).
Anyway, the real challenge is in the two self-hosted machines (runners - rpi & mac-mini) that I am hosting for this. It's at least a security concern for both sides to be discussed, even if I am willing to maintain them further in the interest of this project. :blush:
Happy to continue the discussion though. :relaxed:

By the way, there seem to be Github-hosted arm64 runners for open source on the horizon. So, maybe just a temp solution is required. :shrug:

We're past the "horizon" stage on arm64 macs:) We already use that since a while: https://github.com/valhalla/valhalla/blob/master/.github/workflows/osx.yml.

Oooh, I didn't realize. Good to know. Well, that should make things simpler, right? :joy_cat:
At least for darwin/arm64 that is. There seems to be no docker available on the macos runners. :monocle_face:
So, that may require a hack.

Today I took a stab at getting both the current arches to work (intel-mac was down) and some new ones (arm-mac and arm-linux). Here is my current status:

intel-mac is back up
arm-mac now works as expected on a native runner and is quite fast.
arm-linux works through Qemu so it is slow. A 10 min build is now being stretched out to about 50 min.

To achieve this I had to increase the requerments a bit both for Python (3.9) and Mac (13 on intel, 14 on arm).
I don't have arm64 linux so please try it out and let us know how it works with pip install pyvroom==1.13.6.dev7.

It works perfectly on our infra and on my rpi. Thank you so much! :hugs:

Looks good on my M1 as well. I just released 1.13.6.
As you noted, native arm is on the horizon. I'll need to revisit this when that happens so we can get the build time down.


WIP - do not merge feat: add DIDComm V2 service block and use only KeyAgreement ID as kid in packers

This change removes Base58 key encoding for recipients and sender and uses KeyAgreement.ID for DIDComm V2 or did:key for DIDComm v1 for both sender and recipient keys.
It also includes vdr peer did creation with all KeyAgreement keys, not only the first key.
It moves jwk out of the jose package to be a separate package called jwk along with common jwk code in jwksupport subpackage to avoid circular dependency.
This change also updates webkms log traces level to Debug.
This change adds key resolvers for the packers, one for did:key resolution, another for DID doc resolution using the vdr registry and the last one used for the 1PU test vector verification purposes using a thirdparty store resolution.
Finally this change adds all keyAgreement VMs in the DID doc into the DIDComm service bloc (instead of only the first key).
closes #1604
closes #1207
closes #1659
closes #1847
Signed-off-by: Baha Shaaban<EMAIL_ADDRESS>

created subsequent PRs with similar changes


Major test refactoring, introducing acceptance testing

Summary: This PR contains test structure refactoring and introduces acceptance testing based on vagrant-spec. Current behaviour of launching unit-tests hasn't changed (it is the default rake task). Constistent with structure of the parent project (Vagrant).
Details:

Acceptance tests based on vagrant-spec with an example in README.
ruby-version file for locking the ruby version to the same as embedded in vagrant.
Separating rake files into easily maintainable subtasks.
base.rb files in testing catalogs to centrally configure Rspec and keep common settings for CI (sync output, etc.).
Bumped Rspec version.

/CC @erjohnso

One note - my current instructions assume that the Vagrant public key is imported into the GCE account. They are being changed immidiately on login, however, this may not be the most secure solution, since this is propagated to all instances started on the account.
I think I'll change the Vagrantfile skeleton in the GCE box to get the SSH key from an environment variable, just like the account.

Done. Added a separate test box, updated documentation, User/Key parameters can now be passed in env vars.

Looks good to me, thanks @Temikus!


Save and Print Viewer Button Properties

Allow the save and print buttons from the viewer to be disabled. (Visible = false)

Thank you for your pull request. However I'd rather not make such changes.
The point of the PdfViewer control is to have something to start out with
to get you up and running quickly. If you want to customise the UI, you
should use the PdfRenderer control instead, e.g. by copy/pasting the
PdfViewer code into your project. This allows you to tailor the UI to your
specific needs.
On Sat, Jun 20, 2015, 18:10 Saran88<EMAIL_ADDRESS>wrote:

Allow the save and print buttons from the viewer to be disabled. (Visible
= false)
You can view, comment on, or merge this pull request online at:
https://github.com/pvginkel/PdfiumViewer/pull/35
Commit Summary

Save and Print Viewer Button Properties

File Changes

M PdfiumViewer/PdfViewer.cs
https://github.com/pvginkel/PdfiumViewer/pull/35/files#diff-0 (16)

Patch Links:

https://github.com/pvginkel/PdfiumViewer/pull/35.patch
https://github.com/pvginkel/PdfiumViewer/pull/35.diff

—
Reply to this email directly or view it on GitHub
https://github.com/pvginkel/PdfiumViewer/pull/35.

No worries. I like the viewer since it is already in place and setup but
needed to be able to turn off those two controls at times, and figured I
would offer to contribute.
On Saturday, June 20, 2015, Pieter van Ginkel<EMAIL_ADDRESS>wrote:

Thank you for your pull request. However I'd rather not make such changes.
The point of the PdfViewer control is to have something to start out with
to get you up and running quickly. If you want to customise the UI, you
should use the PdfRenderer control instead, e.g. by copy/pasting the
PdfViewer code into your project. This allows you to tailor the UI to your
specific needs.
On Sat, Jun 20, 2015, 18:10 Saran88<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:

Allow the save and print buttons from the viewer to be disabled. (Visible
= false)
You can view, comment on, or merge this pull request online at:
https://github.com/pvginkel/PdfiumViewer/pull/35
Commit Summary

Save and Print Viewer Button Properties

File Changes

M PdfiumViewer/PdfViewer.cs
https://github.com/pvginkel/PdfiumViewer/pull/35/files#diff-0 (16)

Patch Links:

https://github.com/pvginkel/PdfiumViewer/pull/35.patch
https://github.com/pvginkel/PdfiumViewer/pull/35.diff

—
Reply to this email directly or view it on GitHub
https://github.com/pvginkel/PdfiumViewer/pull/35.

—
Reply to this email directly or view it on GitHub
https://github.com/pvginkel/PdfiumViewer/pull/35#issuecomment-113790301.

I understand. I am happy that you took the time to contribute though. Maybe
I should extend the readme page with this guideline. You're not the first
that made such a suggestion ☺.
On Sat, Jun 20, 2015, 19:24 Saran88<EMAIL_ADDRESS>wrote:

No worries. I like the viewer since it is already in place and setup but
needed to be able to turn off those two controls at times, and figured I
would offer to contribute.
On Saturday, June 20, 2015, Pieter van Ginkel<EMAIL_ADDRESS>wrote:

Thank you for your pull request. However I'd rather not make such
changes.
The point of the PdfViewer control is to have something to start out with
to get you up and running quickly. If you want to customise the UI, you
should use the PdfRenderer control instead, e.g. by copy/pasting the
PdfViewer code into your project. This allows you to tailor the UI to
your
specific needs.
On Sat, Jun 20, 2015, 18:10 Saran88<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:

Allow the save and print buttons from the viewer to be disabled.
(Visible
= false)
You can view, comment on, or merge this pull request online at:
https://github.com/pvginkel/PdfiumViewer/pull/35
Commit Summary

Save and Print Viewer Button Properties

File Changes

M PdfiumViewer/PdfViewer.cs
https://github.com/pvginkel/PdfiumViewer/pull/35/files#diff-0 (16)

Patch Links:

https://github.com/pvginkel/PdfiumViewer/pull/35.patch
https://github.com/pvginkel/PdfiumViewer/pull/35.diff

—
Reply to this email directly or view it on GitHub
https://github.com/pvginkel/PdfiumViewer/pull/35.

—
Reply to this email directly or view it on GitHub
<https://github.com/pvginkel/PdfiumViewer/pull/35#issuecomment-113790301
.

—
Reply to this email directly or view it on GitHub
https://github.com/pvginkel/PdfiumViewer/pull/35#issuecomment-113790830.


rust installation requirement (re: jiter dependency)

When I installed instructor (uv add instructor), I had to install the rust toolchain because of the jiter=0.5.0 dependency.
I haven't seen in the docs that compilation steps are required to install this package, is this expected installation behavior (or is it just my machine)?

I am also just now running into this rust issue as well. Previously, I did not have to install rust to install instructor.

@aretrace hmmm i haven't had this specific problem before, neither have I installed rust on the new development machine I'm using.
How does the error message occur?

@ivanleomk I've uninstalled Rust via rustup self uninstall trying to re-create the error but now the installation still works 😅.
The error occurred during  uv add instructor, it said it something like Failed to build jiter, do you have the rust toolchain installed?.
@asvintheguy perhaps you can still bring up the exact error message.

I've ran into the same issue.
It should be fixed with https://github.com/pydantic/jiter/releases/tag/v0.6.1
Let's see if it is indeed fixed once the dependabot dependency #1151 bump is merged.

@r-dh and @aretrace I just released a new version of 1.6.4 which has jiter bumped to 0.6.1. Could you try to give it a shot?

Going to close this issue for now but feel free to re-open if it persists


remove references to archived openwhisk-client-swift

The Swift 3 mobile SDK is not being actively maintained and
was archived in mid-2019.  Remove dangling references from the
core repo docs and the nginx.conf template.

Codecov Report

Merging #4795 into master will decrease coverage by 6.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4795      +/-   ##
==========================================
- Coverage    85.1%   78.54%   -6.56%
==========================================
  Files         190      197       +7
  Lines        8578     8843     +265
  Branches      601      610       +9
==========================================
- Hits         7300     6946     -354
- Misses       1278     1897     +619

Impacted Files
Coverage Δ

...core/database/cosmosdb/RxObservableImplicits.scala
0% <0%> (-100%)
:arrow_down:

...enwhisk/connector/kafka/KamonMetricsReporter.scala
0% <0%> (-100%)
:arrow_down:

...e/database/cosmosdb/cache/ChangeFeedConsumer.scala
0% <0%> (-100%)
:arrow_down:

...ore/database/cosmosdb/cache/CacheInvalidator.scala
0% <0%> (-100%)
:arrow_down:

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0% <0%> (-96.23%)
:arrow_down:

...sk/core/database/cosmosdb/CosmosDBViewMapper.scala
0% <0%> (-93.85%)
:arrow_down:

...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala
0% <0%> (-92.31%)
:arrow_down:

...e/database/cosmosdb/cache/KafkaEventProducer.scala
0% <0%> (-77.78%)
:arrow_down:

...whisk/core/database/cosmosdb/CosmosDBSupport.scala
0% <0%> (-74.08%)
:arrow_down:

...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala
7.69% <0%> (-50%)
:arrow_down:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9e4c10...db8a36d. Read the comment docs.


Toggle: item request dates from itemsAPI

In order to easily test having the items' available dates returned from the items API, we need to add a toggle around the ItemRequestModal
When the toggle is ON the options here should be the list of availableDates returned directly with each requestable item from the items API
https://github.com/wellcomecollection/catalogue-api/blob/cac7c2ad956e2bd8df1cc8877108b96e6d8fbff1/items/src/main/scala/weco/api/items/services/SierraItemUpdater.scala#L95

Closed as part of https://github.com/wellcomecollection/wellcomecollection.org/pull/10848


Tweet ID get rounded

I want to save the ID of a tweet but I will receive something like this
1026837156479718000
instead of
1026837156479717985
Is there a way to disable the rounded numbers?

@Fchen48 it's not because of the library, it's because Javascript cannot support numbers with > 53-bits, see: https://developer.twitter.com/en/docs/basics/twitter-ids

But the library, knowing that this is a limitation, could work around it. The easiest way would be to preprocess the JSON string for ids.json to make them all strings before parsing them. I'm sure there is a more elegant way, but that is a workaround.

hello, I don't know if I should be posting here but I need help regarding a twitter bot which I am trying to make (which will reply to a particular phrase or hashtag) but something is wrong. I will appreciate if anyone can help solve it.
here is the code
console.log('the bot is starting');
var Twit = require ('twit');
var config = require('./config');
var T = new Twit(config);
var query = "alot";
T.get('search/tweets',
{ q: query, count: 1, lang: "en" },
function (error, tweets, response) {
var tweetList = tweets['statuses'];
    for (var i = 0; i < tweetList.length; i++) {
        var id = { id: tweetList[i].id_str }
        if ('retweeted_status' in tweetList[i])
            continue;
        }

        var message = "Alot confused, a lot not understand feelings";
        var tweetId = tweetList[i].id_str

        try {
            T.post('statuses/update',
                { "status": message, "in_reply_to_status_id": tweetId },
                function (error, tweets, response) {
                    console.log("Tweet posted successfully!")
                });
        }
        catch (err) {
            console.log(err);
    }
});

See https://github.com/draftbit/twitter-lite#numeric-vs-string-ids


Push-to-talk (PTT) keyboard shortcut on Windows?

It would be cool to have an optional push-to-talk (PTT) keyboard shortcut on Windows, where it records as long as it is pressed down.
I find this more intuitive than the current system:

press down/up (to start recording)
system records
press down/up (to stop recording)

Hey Michael, thank you again for the feature suggestion!
Currently, I am limited by the Tauri global keyboard shortcut API, so I can't have key up or down functionality.
I plan on making some changes and having a custom keyboard shortcut manager in the distant future, as mentioned in #130 !

Cool, thanks!

I strongly support this feature request. Maybe it's possible to have different hotkeys for switching Whispering on and off. This way it would be possible to create a push-to-talk hotkey, for example using AutoHotkey, for as long as this is not yet available natively.


Add support for io.etcd:jetcd-core:0.7.5

What does this PR do?

Fixes https://github.com/oracle/graalvm-reachability-metadata/issues/164 .
I have set some org.junit.jupiter.api.Disabled non-permanently, one of them is from org.mockito:mockito-core:4.11.0 Bug, I have opened the corresponding issue https://github.com/mockito/mockito/issues/2862 yet. Four of them seem to be due to https://github.com/etcd-io/jetcd/pull/1092 . Two of them seem to be known test bugs of jetcd-core, because these tests fail to run in JIT. These things seem to be resolved by future updates of Junit and Mockito.
I also marked all org.junit.jupiter.api.Timeout annotations temporarily removed, because using this class will cause tests to fail under NativeTest. Looks like a later version of Junit will fix it.

Checklist before merging

[x] I have properly formatted metadata files (see CONTRIBUTING document)
[x] I have added thorough tests. (see this)

One test had a too short timeout of 30 seconds. I'll deal with it in another Commit.

One test had a too short timeout of 30 seconds. I'll deal with it in another Commit.

Done.

I need to start to modify this PR tomorrow, because I am not near the work computer on vacation these days.

CI's Error Log seems to be due to external reasons, which have nothing to do with me. Refer to https://github.com/oracle/graalvm-reachability-metadata/actions/runs/3975259643/jobs/6815005161 .

Error: Could not find GraalVM dev build for Java 17. It may no longer be available, so please consider upgrading the Java version. If you think this is a mistake, please file an issue at: https://github.com/graalvm/setup-graalvm/issues.

@dnestoro @vjovanov

I checked https://github.com/oracle/graalvm-reachability-metadata/blob/237c9297016a638436c011c9696d60254bd43a92/.github/workflows/test-changed-metadata.yml , but I'm not quite sure how to put java-version: 'dev ' to test-changed-metadata.yml. The functions of Github Actions do not seem to be as powerful as I understand.

Does this require me to open a new issue in the current Git to discuss how to fix CI according to https://github.com/graalvm/setup-graalvm/pull/31 ?

I also marked all org.junit.jupiter.api.Timeout annotations temporarily removed, because using this class will cause tests to fail under NativeTest. Looks like a later version of Junit will fix it.
I also temporarily turned on metadataRepository 0.2.5. If I don't turn it on, Netty prevents the native image from compiling, I don't know why.

This issue is addressed in another PR.

Late reply as I am busy these months. I will refactor the contents of this PR as required by the master branch. Until the refactoring is complete, the PR will be in a draft state.


Slow Read Video .mp4 on ligne  -> VERY FAST PLAY

Hello,
I have a problem if i'm read 3 videos on ligne.
Any solution to read very fast video .mp4 on ligne , if on click next video or back video .
Thanks :)

@abdelhakimkotti  use an ultra mega fast server?

And config the server to allow progressive streaming

I close the issue as this question probably is better to StackOverflow

@CHaNGeTe yes, this is out the box, maybe @abdelhakimkotti should download the videos using rn-fetch-blob to improve the performance, just only an idea.


Can't add html attributes to Dynamic Form elements.

Currently CSS classes and HTML Id's that are added to the Form container or to any elements within a form are not saved. So there is no ability to add CSS to form elements in the dynamic forms module.

Which branch? Should have been fixed in 1.9.x which has yet to be merged into dev.

I'm not using the 1.9.x branch, so it it's been fixed I can close the issue.


OperationalError: database is locked after upgrade from 2.21.32

Hello I updated my flexget from 2.21.32 to the lates 3.0.25 and I had to update the python to 3.7.3 on debian 10. Now I can't start flexget, this is the error, even in flexget check

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/dist-packages/sqlalchemy/engine/base.py", line 755, in _commit_impl
    self.engine.dialect.do_commit(self.connection)
  File "/usr/local/lib/python3.7/dist-packages/sqlalchemy/engine/default.py", line 534, in do_commit
    dbapi_connection.commit()
sqlite3.OperationalError: database is locked

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/bin/flexget", line 10, in <module>
    sys.exit(main())
  File "/home/downloader/.local/lib/python3.7/site-packages/flexget/__init__.py", line 41, in main
    manager.start()
  File "/home/downloader/.local/lib/python3.7/site-packages/flexget/manager.py", line 356, in start
    self.initialize()
  File "/home/downloader/.local/lib/python3.7/site-packages/flexget/manager.py", line 214, in initialize
    self.load_config()
  File "/home/downloader/.local/lib/python3.7/site-packages/flexget/manager.py", line 675, in load_config
    self.update_config(config)
  File "/home/downloader/.local/lib/python3.7/site-packages/flexget/manager.py", line 686, in update_config
    self.config = self.validate_config(config)
  File "/home/downloader/.local/lib/python3.7/site-packages/flexget/manager.py", line 742, in validate_config
    config = fire_event('manager.before_config_validate', config, self)
  File "/home/downloader/.local/lib/python3.7/site-packages/flexget/event.py", line 110, in fire_event
    result = event(*args, **kwargs)
  File "/home/downloader/.local/lib/python3.7/site-packages/flexget/event.py", line 20, in __call__
    return self.func(*args, **kwargs)
  File "/home/downloader/.local/lib/python3.7/site-packages/flexget/components/variables/variables.py", line 86, in process_variables
    variables_to_db(variables)
  File "/home/downloader/.local/lib/python3.7/site-packages/flexget/components/variables/variables.py", line 61, in variables_to_db
    session.merge(variables)
  File "/home/downloader/.local/lib/python3.7/site-packages/flexget/utils/sqlalchemy_utils.py", line 138, in __exit__
    self.commit()
  File "/usr/local/lib/python3.7/dist-packages/sqlalchemy/orm/session.py", line 1027, in commit
    self.transaction.commit()
  File "/usr/local/lib/python3.7/dist-packages/sqlalchemy/orm/session.py", line 498, in commit
    t[1].commit()
  File "/usr/local/lib/python3.7/dist-packages/sqlalchemy/engine/base.py", line 1727, in commit
    self._do_commit()
  File "/usr/local/lib/python3.7/dist-packages/sqlalchemy/engine/base.py", line 1758, in _do_commit
    self.connection._commit_impl()
  File "/usr/local/lib/python3.7/dist-packages/sqlalchemy/engine/base.py", line 757, in _commit_impl
    self._handle_dbapi_exception(e, None, None, None, None)
  File "/usr/local/lib/python3.7/dist-packages/sqlalchemy/engine/base.py", line 1476, in _handle_dbapi_exception
    util.raise_from_cause(sqlalchemy_exception, exc_info)
  File "/usr/local/lib/python3.7/dist-packages/sqlalchemy/util/compat.py", line 398, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb, cause=cause)
  File "/usr/local/lib/python3.7/dist-packages/sqlalchemy/util/compat.py", line 152, in reraise
    raise value.with_traceback(tb)
  File "/usr/local/lib/python3.7/dist-packages/sqlalchemy/engine/base.py", line 755, in _commit_impl
    self.engine.dialect.do_commit(self.connection)
  File "/usr/local/lib/python3.7/dist-packages/sqlalchemy/engine/default.py", line 534, in do_commit
    dbapi_connection.commit()
sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) database is locked
(Background on this error at: http://sqlalche.me/e/e3q8)

What can I do to solve this?

I'm guessing you forgot to stop the service before upgrading.

I did it all, kill, reboot! Delete old data base and create new one, the error still exists!

Bunch of good suggestions on this post:
https://stackoverflow.com/questions/13895176/sqlalchemy-and-sqlite-database-is-locked

But this is all under the hood changes! I didn't change anything on the core flexget, only updated the python and flexget! Now I have this problem!

Ok. Did any of the suggestions in that post solve the issue?

No, i don't think the problem is in the database, I deleted the database
and flexget created a new one, only to give the same error on a newly
created database!
On Sat, Dec 28, 2019, 21:37 metaMMA<EMAIL_ADDRESS>wrote:

Ok. Did any of the suggestions in that post solve the issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Flexget/Flexget/issues/2544?email_source=notifications&email_token=AC3FPIYWURK33R25IIF3I2TQ27BJZA5CNFSM4J756GU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHYSTLI#issuecomment-569452973,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC3FPI3IBYQERW6I6QH3WTLQ27BJZANCNFSM4J756GUQ
.

Well since you already deleted the database, you should try uninstalling an reinstalling sqlalchemy. There might be a lock file that you haven't deleted that is causing the issue. Possibly the database/flexget is running as a different user than the owner of the other.

@metaMMA what is your installation method? based on the paths in log it's not clear ..
Try installing into a new python virtualenv. It's pretty much guaranteed to be clean and working.

@paranoidi Not the OP
@siloam ^

I will try again! I ended up rolling back eventing because I didn't want to have the system stopped that long! I'll try to make the update again! I have the system installed outside the virtual ev! This is a good time to update to virtual env.
Thank you

is this still relevant?

Problem seem to be related on having the database on a shared smb folder! I used to have the config on a shared folder and then I had a symbolic link to link it to flexget folder! Since the upgrade this stopped working, I ended up moving the config outside of the share! Everything started working!

Good to hear. Closing this for now, reopen if relevant.