Party Configuration

Has there been any discussion/interest in scraping the four party configurations and what they have equipped? Or even scanning all characters equips and then just scraping the party arrangements. It'd be nice to be able to share your builds outside of the game more easily.
I might be able to take a swing at implementing the scraping, but I also wanted to know if there was interest in adding that data to the GOOD format as well.

Just wanted to ask what exactly you mean by this?
Do you want to pull your 8-character showcase from the game into GO?
Or do you want to use GO to create a team and then export that configutation to show it off?

So, firstly, when I wrote this, I don't think I realized that there were fields in the artifacts and weapons that pointed to who had them equipped. Thinking about it, that's the right way to structure it given there is only ever one of any given character.
Note that I'm just referring to the data format, not necessarily how GO would utilize that data. Also, I talked about scraping but that's not GO's job, I just was bringing up that a screen scraper could automate the transcription of the party info.
All I meant was that it would be nice if the GOOD format allowed us to represent our existing party configurations. For example, Enka.network lets you generate character cards (though that gets its data in a completely different manner, I'm only referencing the output product), but those cards could also be generated from a GOOD object, and information on your in-game party presets would allow you to generate a card (or something in the same vein) with your entire party represented.
Even though this isn't possible in game, it might also be nice to be able to have different parties in the same overall GOOD object that utilized shared weapons/artifacts across different characters, but that may be departing from what data GOOD is designed to represent.
Sorry if this is still unclear, please let me know.

but why?

Characters already store their teammates in GOOD, just look for the team field, but im not sure what reason to have this data explicitly, unless its from the scanner side, but we probably wouldnt do anything with this data...


example: remove unused header file

since it has been used in lockdep.h, refer to:
https://github.com/insop/lockdep/blob/master/include/lockdep.h#L10

LGTM, thank you


Hyundai: longitudinal support for legacy safety

We might need some exceptions in hyundaican, the Optima doesn't have the SCC14 message, which controls things like jerk limits and comfort bands


Silent tacit holes ?_

In redtt, we could write ?_ to leave a hole but not display it.

This was done, but GitHub's NLP failed to notice


w2ui fails if used together with Opal

This html-code fails. as soon as I remove opal, it works.
<!DOCTYPE html>

    <link rel="stylesheet" type="text/css" href="http://w2ui.com/src/w2ui-1.4.min.css" />

I get the following message in browser console
Uncaught Error: Syntax error, unrecognized expression: #layout_layout_panel_function (symbol) {
      var $a, self = this, $iter = TMP_4.$$p, block = $iter || nil;

      var array_size = arguments.length - 1;
      if(array_size < 0) array_size = 0;
      var args = new Array(array_size);
      for(var arg_index = 0; arg_index < array_size; arg_index++) {
        args[arg_index] = arguments[arg_index + 1];
      }
      TMP_4.$$p = null;
      return $scope.get('Kernel').$raise($scope.get('NoMethodError').$new((function() {if ((($a = self.$inspect && !self.$inspect.$$stub) !== nil && (!$a.$$is_boolean || $a == true))) {
        return "undefined method `" + (symbol) + "' for " + (self.$inspect()) + ":" + (self.$$class)
        } else {
        return "undefined method `" + (symbol) + "' for " + (self.$$class)
      }; return nil; })(), symbol));
    } > .w2ui-panel-content

@iliabylich wrote:
Well, the error comes from this place - https://github.com/vitmalina/w2ui/blob/1.4.0/src/w2layout.js#L745. The library iterates over an array using for (var i in []) and they don't check for if hasOwnProperty(i)
Opal adds further properties to Array, thus this "enumerating" pattern does not work and should be replaced by an iteration (http://web.archive.org/web/20101213150231/http://dhtmlkitchen.com/?category=/JavaScript/&date=2007/10/21/&entry=Iteration-Enumeration-Primitives-and-Objects)
@vitmalina could you fix that?

I updated to the latest master  branch and it seems that this issue is already fixed.in commit 05bc53c

@vitmalina I reopen this, just to request your advice what todo: as far as I can see, your fix is not merged into an official release. I can start to develop my project against your master branch, but I would like to rely on an official release. What can i do?

I think you are correct, for (var i in []) was fixed in current master, but not in 1.4.x branch. And it is unlikely it will be fixed there.
Master branch is next release, which is 1.5. I will be in charge of it. It is currently in feature complete stage and we are working on updating documentation, etc. No date for its release yet, but I think it is very stable and can be used instead of 1.4 branch.

I switched one of my two projects to the masterbranch here. As 1.5 is not fully compatible to 1.4, I need to stick with this. Luckily this is not an Opal project


Individual Meshes

Currently, each chunk uses its own mesh. Could this be optimized? Depending on Orientation the mesh stays the same. Right now the position is also encoded in the mesh itself, this seems rather wasteful in terms of memory transfer+usage to me.
Is there a way to reuse parts of this across chunks, and decouple the offset from the mesh itself? (Related to #3?)

Ideally we have a better way of specifying number of chunks and the size of the chunks. For really large maps or maps that are changed quite frequently I can see it being beneficial to chunk things up, but for smaller maps or maps that don't ever change having a single draw call/mesh would be much more ideal. As for positioning the only position that gets "encoded" in the mesh is the local position of each vertices. I don't see a way of improving the memory usage there.

The best way to do this would be leveraging the work put into bevy_tilemap. Issue here: https://github.com/StarArawn/bevy_tiled/issues/40


something about "infer_Mamba.SCD.py"

Hello, I would like to use the BDA model for prediction, but I only see 'infer_MambaBCD.py' ,'infer_MambaSCD.py 'available. Will there be an update to include 'infer_MambaBDA.py'? Thank you very much."

thanks


Talentpool Cleanup

Closes #2306. Tested and ready for review!
Sorry for the big diff, it's not that bad I promise.
Marked as high priority as this blocks other changes to talentpool stuff.

Thanks for the reviews :)


Add Tanner (Kẻ chán đời)

Thêm nhân vật Tanner (Kẻ chán đời)

Chức năng: Nếu bị vote chết trong 3 ngày đầu sẽ thắng.
Phe thứ 3 (Tanner Party)

His name should be Tanner base on the traditional game

Should we skip "the first 3 days" rule, so Tanner can try to distract both Werewolves and Villagers during the whole game, then it will much more fun.
I think when the 3 days ended, Tanner is just like a normal Villager which is quite boring :D

So. What if noone want to vote?

So. What if noone wants to vote?

This locks Tanner into their own team and makes victory much harder for them, but also much more rewarding since it overrides any other victory.
The worst case is when Tanner get killed by Witch or Werwolves,
he will 100% lose the game :D

@huybt22 so the final decision is:

Skip "the first three days" rules
Tanner will be killed only by Witch or Werewolves

Am I right? Please correct me if there are more conditions or rules relative to this character, thanks.

@maidxn
`

Tanner can be killed by anything
When Tanner is killed by lynching, he immediately wins the whole game, override all others win condition
`

About three days rule, it means Tanner must try to be lynched during the first 3 days, otherwise he will never reach the victory.
Please share your thoughts, then we can decide together.

After our discussion, I wrap it up here @huybt22:

Tanner's ability will last whole game, no limitation.
Tanner is in Tanner party, wins game when lynched. Whenever villagers win, it still loses.

Hope this is enough what we mentioned, if there are any changes, please let me know, thanks.

Agree, thank you!


Attack Macros

Attempt to provide attack macros which streamline to process of rolling combat style, rolling hit location, and damage.  Potentially include alternative damages like scatter, maximize, etc
This may just be an enhancement to the existing weapon rolls

This thread may hold the trick needed to chain actions with a pause for decision making:
https://app.roll20.net/forum/post/5914960/using-a-drop-down-macro-to-call-other-macros

Added weapon buttons to cs rolls in v3.0


Update java to 1.8.0_121-b13:e9e7ea248e2c4826b92b3f075a80e441

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

They had added a hash value into the download link which is a bit painful, so I've adjusted accordingly. Also added a java_update value into the cask body to try to make it a bit more obvious what's going on so let me know if that's OK too.

Hey maintainers, any feedback for this one?

As long as we’re adding a new variable to this mess (freaking java), we might as well add one for each split case.

Thanks @vitorgalvao


Ubuntu 15.10 cmake error

Probably already already sorted, found similar with a Mac user.
Using non-windows-woraround branch, used to compile fine with Ubuntu 15.04 (libboost 1.55), now with Ubuntu 15.10 (installed libboost 1.60, as 1.58 reported buggy).
Cannot cmake osvr-core :
CMake Error at cmake-local/BoostTargets.cmake:22 (message):   Using an untested Boost version - inspect the Boost Interprocess release   notes/changelog/diffs to see if any ABI breaks affect us. Call Stack (most recent call first):   CMakeLists.txt:289 (include)
Help pretty please ?

OK got a bit further.
In the non-windows-workaround branch, edited ./OSVR-Core/cmake-local/BoostTarget.cmake , line 21 to:
if(Boost_VERSION GREATER 106000)
cmake does not complain.
Run make, compile fails at 75% :
[ 75%] Building CXX object src/osvr/Common/CMakeFiles/osvrCommon.dir/IPCRingBuffer.cpp.o /home/pilou/OSVR/OSVR-core/OSVR-Core/src/osvr/Common/IPCRingBuffer.cpp:55:2: error: #error "Using an untested Boost version - inspect the Boost Interprocess release notes/changelog to see if any ABI breaks affect us."`
Edit ./OSVR-Core/src/osvr/Common/IPCRingBuffer.cpp, line 55 :
#if (BOOST_VERSION > 106000)
Just tested OpenGLSample, seems to work without issues...
Will post again if I stumble upon more issues with boost 1.60.

Sorry, this is fixed in the master branch but I didn't update the workaround branch with it apparently.  For what it's worth, people aren't having the trouble with 1.58 that was originally expected/reported, we may have merged a workaround but not a documentation update.


Fixed some bugs in BaseDataPublisher

Fixed a bug that caused false-alarm warning log messages.
Fixed a bug that will prematurely complete processing of a WorkUnitstate if a branch didn't produce any data and it is not the last branch.

Signed-off-by: Yinan Li<EMAIL_ADDRESS>

@ydailinkedin can you review?

LGTM!


Getting 502 Bad Gateway

Hello ,
I am getting Getting 502 Bad Gateway.

fixed!

I am still seeing 502 Bad Gateway

hey @jake-wickstrom can you try now?
nginx needed a good ol' restart for some reason 😅


fix: datasource documentation link (#30169)

Description
This PR fixes the link associated with Learn More button on the datasource page. Earlier, on clicking Learn More button, there was a hardcoded URL in the code, which redirected the users to documentation homepage.
With this change, the user will be redirected to the specific plugin page as now the URL configuration is consumed from the database field plugin.documentationLink
Fixes #30169
Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!TIP]
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8933944898
Commit: ead13a99f865a98911e687a4356a569a84909068
Cypress dashboard url: Click here!

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

/build-deploy-preview skip-tests=true

@sneha122 @rishabhrathod01 the dp will not show these buttons because of this LOC

@NilanshBansal Do you think we should write any automation test cases for this?

@NilanshBansal Do you think we should write any automation test cases for this?

@sneha122 I am not sure if we should write automation tests for this because, the documentation URL is picked from the database, and the documentation link can change in the future.
For such scenarios, if we change the documentation link from the database, we would also have to update the test cases i.e. code level changes will need to be done for a non-code related change.
Also, going forward let's say we change the link from https://docs.appsmith.com to https://appsmith-docs.com, instead of doing any code-level or db changes, we can just add a redirection rule to our DNS settings without need for dev dependency.
But there are pros and cons to either of the approach.
cc: @sneha122 @rishabhrathod01

I am not sure if we should write automation tests for this because, the documentation URL is picked from the database, and the documentation link can change in the future.
For such scenarios, if we change the documentation link from the database, we would also have to update the test cases i.e. code level changes will need to be done for a non-code related change.
Also, going forward let's say we change the link from https://docs.appsmith.com/ to https://appsmith-docs.com/, instead of doing any code-level or db changes, we can just add a redirection rule to our DNS settings without need for dev dependency. But there are pros and cons to either approach.

IMO we shouldn't test the user education routes in the product. A regression test suite could have these but E2E tests should skip this.


nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n

Summary
by moving the intializition code to nsh_telnetmain.
Note: the init script postpone the execution when the first user login too.
Impact
See the issue description:
https://github.com/apache/incubator-nuttx-apps/issues/584
Testing

@lukegluke please try this path.

Hi @xiaoxiang781216,
Patch fixed the build, but network not works if CONFIG_NSH_CONSOLE=n.
I suppose it is because netinit_bringup() is called only from nsh_consolemain (usbconsole/altconsole):
https://github.com/apache/incubator-nuttx-apps/blob/39a1950098b331c5a2c203431ffc26f276274863/nshlib/nsh_consolemain.c#L101-L105
that in turn is not called if no console:
https://github.com/apache/incubator-nuttx-apps/blob/f613da4f92d5ae1f719cda3f3f2ae28db3b7559b/system/nsh/nsh_main.c#L165-L168

@lukegluke about #584 do you know which PR broke it? Maybe we could revert the offending PR until we have telnet working with it again.

@acassis I had found it by git blame for that time, but I can't say it to you now.
Why not just moved netinit_bringup() code to main(int argc, FAR char *argv[]) in nsh_main.c (see code parts above)?

@acassis I had found it by git blame for that time, but I can't say it to you now.
Why not just moved netinit_bringup() code to main(int argc, FAR char *argv[]) in nsh_main.c (see code parts above)?

Because netinit_bringup() doesn't depend on nsh! You can create a standalone (a modified hello_world for example) that needs network initialization.

Yes you're right, I see. But as it seemed to me that previously netinit_bringup was also in nsh, so it is another problem. I didn't get deep into history of this issue and related net bringup problems, just noticed the issue.

See the better fix here: https://github.com/apache/incubator-nuttx-apps/pull/703


Replaced emdedded RedisServer with testcontainers.

closes #2175
What does this PR do?

Checklist

[x] This is something else

[x] Replaced emdedded RedisServer with testcontainers.
[x] In the remaining test classes(Lettuce*Test) - junit4 has been replaced with version5

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Reason: The PR is not allowed to run in the CI yet

Start Time: 2021-10-31T10:36:55.726+0000

Duration: 3 min 28 sec

Commit: 32a77dda1a949fbc33e649aa8a0cb5f785b3a246

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run benchmark tests : Run the benchmark test.

run compatibility tests : Run the JDK Compatibility test.

run integration tests : Run the APM-ITs.

Hi @cachedout , please check this.
This should solve problem(Unless others suddenly appear :D)

run elasticsearch-ci/docs

@felixbarny do we need to test a specific Redis version?

Please rename the tests extending AbstractRedisInstrumentationTest so that they end with IT (integration test). This makes them not run when doing a mvn test, only a mvn verify.
I don't think we need to test against a specific Redis server version.

Done

/test

run elasticsearch-ci/docs


Can we publish internal Space Cloud events to a pluggable sink?

We should have a mechanism to publish internal events for functions to subscribe on. We can publish events like

CRUD operation hooks
File Upload

This is possible via eventing


[Linux tray] Can't launch tray from Applications

Still not working, but work for Ilarion, maybe it my local bug?


scmi: unused methods

@mz-pdm can we remove those methods since they are not used, or have we forgotten to use them somewhere?
$ rustc --version
rustc 1.78.0 (9b00956e5 2024-04-29)

$ cargo build -p vhost-device-scmi
   Compiling vhost-device-scmi v0.2.0 (/home/stefano/repos/vhost-device/target/package/vhost-device-scmi-0.2.0)
warning: methods `invalid_property` and `process_property` are never used
   --> src/devices/common.rs:301:8
    |
276 | pub trait SensorT: Send {
    |           ------- methods in this trait
...
301 |     fn invalid_property(&self, name: &str) -> Result<(), DeviceError> {
    |        ^^^^^^^^^^^^^^^^
...
308 |     fn process_property(&mut self, name: &str, _value: &str) -> Result<(), De...
    |        ^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: `vhost-device-scmi` (bin "vhost-device-scmi") generated 1 warning

We can remove them, PR posted.


Add support for files from classpath

Hi I would like to server my assets from classpath I went into the documentation of ratpack and I found this: http://ratpack.io/manual/current/launching.html#base_dir
This basically means if you want to serve assets from the classpath you need to create a markerfile .ratpack and catacumba should call http://ratpack.io/manual/current/api/ratpack/server/ServerConfig.html#findBaseDir-java.lang.String- when you don't set a basedir (Or maybe this should be an option?). Would you like a pull request with this change?

Hi @mitchelkuijpers
Yeah, it would be a great improvement. PR is welcome.
The only thing is that I don't know the best approach for handling this at this moment. Maybe a reasonable option will be if base-dir is not provided, find the .catacumba markfile (instead of .ratpack). And additionally add an option for specify the default markfile name with the default value to .catacumba ?
Thanks!

Yeah a .catacumba markfile would be a much nicer approach no need to expose ratpack internals. The only thing is it does not seem to work correctly for example it does not resolve compiled files from target/public but it does from resources/public (where I put the .ratpack file) :( Maybe it might be a better idea to create a resources middleware like the one from ring? I am just blurting out ideas.

hmm, I'm not pretty sure about take a own solution, the ratpack approach should work fine.  Maybe you should add target/public to :resources-paths for make it available to the classpath?

Agree would not like that either, the thing is target should be on the classpath since that is the classpath, will investigate further tonight..

It seems my problem with loading files from the classpath is related to boot and how ratpack finds assets

It get's the current classloader
finds the markerfile from the classpath
finds the containing directory and then uses that as a basedir

This is absolutely fine with leiningen (I think?) but not with boot they do some magic and then the basedir resolves to stuff like this /Users/mitkuijp/.boot/cache/tmp/Users/mitkuijp/Development/relations_for_jira/ixx/9553b This is easily fixed for me with a check if it's dev and then use the target folder (which is basically the classpath with boot) and otherwise the marker thingy.
I will create a pull request tomorrow that searches for the .catacumba markerfile by default when no basedir is defined and update the docs accordingly.

Great! I'm looking forward your PR!

Going to take a bit longer gonna be busier today then expected.
One thing is if you don't have markerfile it will throw a runtime exception when starting the server I don't think this is wanted behaviour as a default. So maybe I should add it as a separate option. Still thinking about a name ik think findBaseDir is a pretty name for this, any ideas?

Hmm, I think, that the decided behavior is a proper. And the underlying platform does not works in a exactly way we should workaround. In other words, I don't want condition a design of catacumba by design decisions by the underlying platform unless there is no other remedy or that the change is reasonable.
And for this case, maybe a better approach will be catch that runtime exception and simple ignore it. This approach maintains backward compatibility (it is not very important point in this phase of development but is not bad...) and behaves as we expect. So if no file is found no base-dir is set.
What do you think?

Done in master.


Set balance below existential

Summary

[M] y/n | Does it introduce breaking changes?
[N] y/n | Is it dependant on the specific version of cargo-contract or pallet-contracts?

Added a check for setting the balance in tests below the existential minimum
Description
Given that accounts with a balance below the existential minimum get reaped, adding a check to prohibit setting balance below seems logical. If this should not be like this, feel free to correct us.
Checklist before requesting a review

[X] My code follows the style guidelines of this project
[x] I have added an entry to CHANGELOG.md
[X] I have commented my code, particularly in hard-to-understand areas
[x] I have added tests that prove my fix is effective or that my feature works
[X] Any dependent changes have been merged and published in downstream modules

Please merge master

@faculerena Could you merge master into your PR or allow me to resolve the conflicts?

I think its ok now @cmichi

@faculerena There are some CI errors, do you see the Details if you click the link?
The cargo fmt issues can be applied automatically by executing cargo +nightly fmt --all locally.

Clippy issues fixed and fmt ran. I think the Dylint issues are the same as the other two.

Thank you, @faculerena!


Release to ROS Build Farm

Any plans to release this to the build farm? We would love to not have to build this as a dependency.

You are talking about the ROS build farm? No plans, but rather because we have no experience with it, not because we don't want to.
Also I am not sure if ROS is already admitting C++14. Last time I checked at least C++11 support was required. And mrt_cmake_modules might be a problem. We could release it as well but I would rather avoid the extra work since it is only required for building.

@poggenhans - Sorry I haven't responded to this lately. Yes, I was talking about the ROS build farm. They are accepting C++14 code, but only for ROS Melodic and above (which is really what we care about). Since mrt_cmake_modules is a pure CMake thing, it also shouldn't be a problem to release it and doing so is very easy. It can then be added as a <build_depend> since it is required at build-time but not compile-time. I would be happy to walk through the release process with you  on either repo. Please email me at<EMAIL_ADDRESS>and we can set something up.

ros/rosdistro#24060

Awesome! Thanks!


Don't allow editor to move the location of the active/main game.project file from the Assets panel

I accidentally dragged my game.project file into another folder and everything exploded

Wrong repo


Add support for annotations and labels

generateSandboxContainerSpec() is currently filtering all annotations received through the CRI api vs copying them to the runtime spec. Consider if some of the annotations should be filtered or if all should be copied over. For example:
annotations := config.GetAnnotations()
for key, value := range annotations {
 		g.AddAnnotation(key, value)
}

Similarly, labels received over CRI are not being processed / handed over to containerd.
Consider the patterns enabled/being used for kubernetes when connected to dockershim and CRI-O, should we be unique here?

There were some discussion about this before, could not find the email threads now.
The conclusion was that we don't want to expose the container label as part of api, user should not rely on it. :)

interesting.. what about annotations?

addressed by #1084


[Feature Request] Programmatic Fast Bypasser

Currently the Fast Bypasser works by manually activating the switches. My idea would be to add an additional input to the bypasser with the setting "always one" with which I pass an integer which then switches one of the switches?
In my case I have created a few nodes with which I change the setup of the sampler via a txt file, the name of the checkpoint is read out and then the respective setting parameters are automatically changed (https://github.com/gisu/comfyui-foxpack). Optionally I can enter whether it is an SD1.5 or SDXL checkpoint. As long as I work with regular switches, this works quite well because I can pass an integer into an input there. The only thing missing is the fast bypass, where I currently always have to do it manually.

This comes up a lot but, unfortunately, it's not really possible to toggle mute/bypass with an input as they are in two completely different phases of execution.
Muting, Bypassing, and other actions are all modifying the active workflow in the browser in real-time. Whether you use ctl+M, or a Fast Muter, etc. when you do so, it's changing those nodes' status right there in the browser workflow--there's no communication with the server.
When you queue a prompt, ComfyUI takes the current browser workflow, and sends it as-is to the backend, which executes it independently. Things that have been muted/bypassed are stuck as muted/bypassed (I actually think Comfy doesn't even send them to the backend).
Further, an input is a value passed from one node to a connecting node in the backend, during that nodes' execution. At this point, it is infeasible to then mute/bypass a node or group based on the value of an input as we're no longer in the browser to manipulate the workflow that would have been sent to the server. (At least not without an extensive re-write to ComfyUI's execution and APIs.)

Ok, thank you for the explanation. It will probably need lifecycle hooks and only the ComfyUI team can integrate them.


Property test JS functions and variable names can't be reserved js keywords

for example var, new, and eval

https://github.com/demergent-labs/azle/pull/1473


Valid credentials but index loop

Hi, I use Yourls all the time but since yesterday my backend is impossible to reach..
I was in 1.7.3 so I've updated to 1.7.4, reset the admin password, changed to MD5 hash, but nothing worked.
Credentials are good since I don't have the "Invalid username or password" alert but each attempt to login acts like a refresh.
Best regards
simon

We'll need more info to might be able to help, like browser console or server logs. Check https://github.com/YOURLS/YOURLS/wiki/Troubleshooting-first-steps

Hi everyone,
For those who may have that issue someday, it was due to the activation of varnish..
When I removed extreme cache (cpanel), everything worked as it should :)
Regards


Fix bug

I've found the bug when I write test of RBQFetchedResultsController class.
When I stored date like below:

Even though section type is 2 types(section 1 and section 2), but self.fetchedResultsController numberOfSections will return 10 because [controllerCache.sections addObject:section]; will be called 10 times in - createCacheWithRealm:cacheName:forFetchRequest:sectionNameKeyPath: method.

Also could you please check this PR. I've added RLMArray+Utilities!!

This is the expected behavior. The keyPath for the section names must either be the first sort in the fetchRequest or have the same ordering. Here is how Apple explains it for NSFetchedResultsController:

If this key path is not the same as that specified by the first sort descriptor in fetchRequest, they must generate the same relative orderings. For example, the first sort descriptor in fetchRequest might specify the key for a persistent property; sectionNameKeyPath might specify a key for a transient property derived from the persistent property.

I think though your attempt with this highlights the potential need for better documentation. I will copy Apple's language into the header.


ffmpeg error after restore

Hi, i restore the backup in a new installation and I receive this error:
Giardino: Setting up camera, please be patient...
Error: spawn /var/lib/homebridge/node_modules/homebridge-camera-ui/node_modules/ffmpeg-for-homebridge/ffmpeg ENOENT
at Process.ChildProcess._handle.onexit (node:internal/child_process:286:19)
at onErrorNT (node:internal/child_process:484:16)
at processTicksAndRejections (node:internal/process/task_queues:82:21)
[08/12/2023, 01:41:15] [CameraUI] Child bridge process ended
[08/12/2023, 01:41:15] [CameraUI] Process Ended. Code: 1, Signal: null
[08/12/2023, 01:41:22] [CameraUI] Restarting Process...
I already try to install ffmpeg manually but nothing change.

Anyone could fix it?


[#12] throws indicator

See #12

:+1: So good to have this explicit!

functionName() => String, throws // Is the same as:
functionName() => String, throws Error
>
> And throwing a generic `Error` type is a totally legit use-case.

> — https://github.com/ericelliott/rtype/issues/12#issuecomment-158486865

How about making it stand out that `throws` is the equivalent of `throws Error`? Otherwise people can throw things like `{errorCode: 300, description: '...'}` and just say that their function `throws`.

:-1:  I am against having a default Error type. I like the fact that you can say it throws without being too specific about it. It covers several types as well.
I know that we should advocate the throw Error but ppl will continue to throw stuff they shouldn't throw and that will require documentation anyhow.

@Mouvedia thrown errors are not going to be type checked. They're just going to throw.
Error is a generic case that will be satisfied by a specific error type like TypeError, just like a date string would still satisfy a String type check, or a User would still satisfy an Object type check.
It's the other way around that doesn't work. For instance, if you ask for a TypeError, and instead get a less specific Error, that would be a type constraint violation.
If people are returning random strings instead of proper error objects, they should definitely get a type error, because random strings don't have enough information to help developers debug the problem.

I can agree in not being able to use throws for throw 'don't do this'.
But you should be able to do throws String in that case. rtype shouldn't be limited to good code.
I want to be able to document bad code as well.

But you should be able to do throws String in that case... I want to be able to document bad code as well.

 I personally would chose throws Error and change the code from throw 'some string' to throw new Error('some string');.
If you're mucking around in the code anyway, might as well clean it up a little while you're there. ;)


Replace Node Shapes with PNG Images

For the vital conditions project I would like to replace the nodes with png images provided by our colleagues. I am sure that this will have applications in other projects to represent node types (people, buildings, etc.). Currently I am just modifying the final image in powerpoint but it would be awesome if I could up load a set of images and link them to the shapeby function on MT. It would also be fantastic if these images could be used to label polygons. Please let me know if you would like to chat about this one, or if you would like example files.

Great idea!
From: frankambrosio3 @.>
Sent: Wednesday, April 14, 2021 10:03 AM
To: CDCgov/MicrobeTrace @.>
Cc: Subscribed @.***>
Subject: [CDCgov/MicrobeTrace] Replace Node Shapes with PNG Images (#351)
For the vital conditions project I would like to replace the nodes with png images provided by our colleagues. I am sure that this will have applications in other projects to represent node types (people, buildings, etc.). Currently I am just modifying the final image in powerpoint but it would be awesome if I could up load a set of images and link them to the shapeby function on MT. It would also be fantastic if these images could be used to label polygons. Please let me know if you would like to chat about this one, or if you would like example files.[https://camo.githubusercontent.com/5494fc1502cb41b91bc11b33f9a0db202992db4d650d694c37bbe03111635203/68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3630366636643737393335363161393761373533646633652f34353563373636342d613039642d343]https://camo.githubusercontent.com/5494fc1502cb41b91bc11b33f9a0db202992db4d650d694c37bbe03111635203/68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3630366636643737393335363161393761373533646633652f34353563373636342d613039642d343133662d386562642d636661613136333734323261
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/CDCgov/MicrobeTrace/issues/351, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHMTDBPJKVB62HKIZ4XBKFDTIWOBZANCNFSM425O2BXQ.

We have received a set of the icons in SVG format from our Vital Conditions colleagues. Please let me know if/when you need access to these images.


Can't build repo on Windows

I've been unable to get this repo building on Windows:
> $env:DENO_FUTURE=1 ; deno task build
Task build docusaurus build && cp -r src-deno/* build
[INFO] [en] Creating an optimized production build...
[ERROR] Loading of version failed for version current
[ERROR] Loading of version failed for version current
[ERROR] Loading of version failed for version current

Error: Unable to build website for locale en.
    at tryToBuildLocale (file:///V:/deno-docs/node_modules/@docusaurus/core/lib/commands/build.js:55:19)
    at eventLoopTick (ext:core/01_core.js:168:7)
    at async mapAsyncSequential (file:///V:/deno-docs/node_modules/@docusaurus/utils/lib/jsUtils.js:44:24)
    at async Command.build (file:///V:/deno-docs/node_modules/@docusaurus/core/lib/commands/build.js:82:21)
Caused by Error: EINVAL: invalid argument, stat
    at __node_internal_captureLargerStackTrace (ext:deno_node/internal/errors.ts:62:9)
    at __node_internal_uvException (ext:deno_node/internal/errors.ts:127:10)
    at denoErrorToNodeError (ext:deno_node/internal/errors.ts:1770:14)
    at ext:deno_node/_fs/_fs_stat.ts:138:95
    at eventLoopTick (ext:core/01_core.js:168:7)

[INFO] Docusaurus version: 3.1.1
Node version: v20.11.1

This now runs on windows, albeit slowly


feat: FirstName and Lastname for waitlist

addded firstname and lastname input
added proper form validation and feedback
updated api url
added new eslint rule

This fixes #122


BIP339: Add wtxidrelay message and WTx inv type

BIP339 support was just merged into core: https://github.com/bitcoin/bitcoin/pull/18044
Not sure about changing the protocol version because I don't think every protocol is supported in rust-bitcoin yet
Not sure about the name for the new inv type, we already have WitnessTransaction

Code Review ACK 8c066e8.
Thanks @jrawsthorne for clarifying PROTOCOL_VERSION usage.

Rebased

Could you perhaps squash?

Squashed @stevenroose


Initial BE work

Added initial skeleton
Created json file with auth tokens and deviceIDs
Added node-outlook package for basic OAuth handshake

:+1: seems to be a fine jumping off point


Remove left navigation sidebar

Since the docset is already indexed within pages, I think it makes sense to remove the built-in navigation sidebar, as it doesn't serve any purpose while taking a lot of space on the screen.


Question: Is there any way to get segment info(not only string but with start and end) in hmm and search mode?

Gse version (or commit ref):
0.60
Go version:
1.14
Operating system and bit:
macOS 10.14

Description
In my case, I need get start and end info of each word after segmenting in hmm and search mode.
By reading apis, I only found:

CutSearch(string, true) which only return []string but no star and end infos
Segment([]byte(text)) which can return segment with start and end info, but it does not accept param to choose search mode.

Is there anyway to something like Segment([]byte(text), searchMode)?

You can use seg.ModeSegment([]byte(text), searchMode).

ModeSegment

Thank you @vcaesar .
Sorry for my wrong words.
Actually I want a method which returned something combines HMM and searchMode, for example CutSearch and ModeSegment.

The start and end of the search mode with HMM? It's not supported now, I will be supported in the near future.

Yep.
I'm new to gse now. I'm glad to make a PR after I digging into this awesome project.

Hi there,
As of 0.63.1 released, did this issue fixed in the newest release?

Not yet, will be added soon.

You can use seg.Analyze() to get it.


Add manager kustomize check

Accidentally checked in my personal image for the manager kustomize. So to stop future mishaps like this accidentally getting committed, I've added a small check that see if the manager kustomize has the appropriate image

/retest


Qingwei/rx

Ignore the branch name

Coverage decreased (-0.4%) to 88.547% when pulling b1301b3e38757f14cc27422f86a48ccb3b9a79c5 on qingweibinary:qingwei/rx into eb1fcbde9b14e609039bb394ad598668ec754fb7 on binary-com:master.

Coverage decreased (-0.4%) to 88.547% when pulling ccf12ab3e2cf2fcddc90c45ed29a742f0703b5cf on qingweibinary:qingwei/rx into eb1fcbde9b14e609039bb394ad598668ec754fb7 on binary-com:master.

Coverage increased (+0.9%) to 89.812% when pulling 653dde1f5413389a6e4e85b02af185f018c510a8 on qingweibinary:qingwei/rx into eb1fcbde9b14e609039bb394ad598668ec754fb7 on binary-com:master.

Coverage increased (+0.9%) to 89.812% when pulling 6f82a5d3f3824d6e14eac8fec5a4201a1ea41757 on qingweibinary:qingwei/rx into eb1fcbde9b14e609039bb394ad598668ec754fb7 on binary-com:master.

@borisyankov
I just realize an issue, let's discuss
This PR handle unsubscribe in ApiState, so when reconnect, we do not subscribe to stream that had been forgotten.
Then I discover next-gen is works by hooking on authorize, and do all those subscription again.
This raise a question, should we do all those resubscription for caller, or maybe we only reauthorize, and let them handle themselves?
Or we provide yet another switch to opt-in ?
@aminmarashi maybe you can provide some insight too

@borisyankov @qingweibinary In my opinion it's best that all resubscriptions are handled for caller, because it's the most common usage.

Yeah, I also think so.

codacy complains about console.warn, let's ignore codacy =P
the warning is for deprecation, maybe next 2 release we can remove that 2 calls


Feat/forgjs

Close #321

Codecov Report

Merging #324 (bcbeab9) into release/0.5 (fb992eb) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release/0.5      #324   +/-   ##
=============================================
  Coverage       100.00%   100.00%
=============================================
  Files               43        43
  Lines              954       954
  Branches           359       359
=============================================
  Hits               954       954

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb992eb...bcbeab9. Read the comment docs.


Remove workarounds

Following up to https://github.com/aspnet/AspNetCore/pull/12557. I'll send a tell-mode email if this PR passes.

I'll try addressing https://github.com/aspnet/AspNetCore/issues/11701 while we're removing workarounds.

I've investigated this a little more and it seems like the workaround we want to remove for https://github.com/dotnet/cli/issues/11378 still affects building some projects for reference assemblies:

I'm not sure why this only seems to affect some (but not all) reference assembly projects but it seems like we can't remove the workaround just yet. This only seem to affect windows builds only and no other platforms. @dsplaisted would you know what to look for here?
FYI, the binlogs that I'm looking at is here: https://dev.azure.com/dnceng/public/_build/results?buildId=292612&view=logs&jobId=d9e61dd5-50da-562f-684c-804952f2640b.
For the time being, I'm adding back the workarounds.

@dsplaisted as @JunTaoLuo described, we're still seeing
...FrameworkReferenceResolution.targets(274,5): error NETSDK1073: The FrameworkReference 'NETStandard.Library' was not recognized [...]

if we remove the dotnet/cli#11378 workaround (a conditional <TransitiveFrameworkReference Remove="NETStandard.Library" />).
With the 3.0.100-preview7-012821 .NET SDK, shouldn't we have picked up the bug fix?
Or, is the problem only fixed on CI agents with VS 16.2 or later (for example)? If this is relevant, the errors are visible with both BuildPool.Windows.10.Amd64.VS2019.BT.Open and BuildPool.Windows.10.Amd64.VS2019.Open agents. (Not positive what VS 2019 version those agents have installed at the moment.)

@JunTaoLuo suggest getting this in and leaving #11701 as well as any improvements related to dotnet/cli#11378 for later. Your build was clean 😃

Missing an approval but I can rage merge 😄


Token logo image names do not use asset primary key

One potential issue with naming tokens by their symbol is that a chain can have multiple tokens with the same symbol, which means there could be a conflict.
E.G., terra::'chainlink' (symbol == LINK), and terra::'chainlink (portal)' (symbol == LINK)
If we want to switch to a primary key, well I believe only the base denom is guaranteed to be unique.
In the case of Ethereum, for example, there are plenty of fake contracts copying the same symbol as other successful ERC20s, (the same happens of Terra, as well) hoping to trick people into buying their fake token.
This might suggest something like using instead the base denom as the image name.
However, the issue with using base denom for the name of the token images is that contract names are not easily human readable.
-We could ignore that issue and just have images titled like: "cw20juno14h5j5g43hf6h65fg65g4h7jkf654gh7k6hj5jkhjgbhj.png"
-Or we could use both symbol AND base_denom to keep the names unique and also human readable: "_"
e.g., "NETA_cw20juno1ch3g4gh6j7j7hh4jk473feu3io5lth54j3klf37h43tf4:
But even that could have problems if a token's symbol could change over time....
Another issue with using base_denom is that we technically specify the base denom for cw20s as "cw20:", but the colon (:) cannot be used in the name. Should that be omitted and just do "cw20" without the colon?

Since we can point to the files and give them properties using the various schema, I propose we just abandon any naming standard, and try to just be reasonably descriptive.


Make PR merging easier

We do a good job in this project making small PRs, which is great because they are easy to review. We also have really strict branch protection, requiring that tests pass in an up to date branch before merging. I think there are enough moving parts in this project that it's good that we do this; otherwise we'd have things broken often in master.
However, as a result, it takes a while to get branches merged after PR approval. There's updating the branch, waiting for tests to pass, and then merging. And worse, if another maintainer is doing this at the same time, the process has to be repeated.
I'd like to consider a couple solutions to reduce the effort needed:

Encourage everyone to merge PRs upon approval. Reviews are generally happening one at a time, so it's often easier – and satisfying! – to merge as the review is happening.
Use a merge queue, something like bulldozer, github-merge-bot, or bors. The way this would work is that we'd give the bot rights to merge PRs when there's an approval and the status checks pass.

I had a look at enabling repo ranger for this project earlier, but I think I don't have enough permissions on the badges org to do it. I don't have badges listed in the "Account" drop-down on https://github.com/marketplace/ranger :(

I have the same result. But https://github.com/marketplace/ranger:

For personal accounts only
[...]
Contact us to beta test in org. accounts and private repos
So it's not a matter of permissions.

Yea, same issue here.
I was able to add the app through https://github.com/apps/repo-ranger, want to see if you can get anywhere with that?

Oh yeah. I think using the out-of-the-box config we should just be able to apply the "merge when passing" label to PRs once we've reviewed them and it will do that once the branch is up-to-date and all the tests have passed.

Lets give it a go next time dependabot has a pile of PRs for us..

Repo Ranger is working pretty well for us! Cool with closing this?


contnious scanning

Is there a contnious scanning is there  for to contnious scanning the barcode

fixed commit https://github.com/CodingWithTashi/simple_barcode_scanner/commit/efd30d295aa39afd6c0d2415ace095e06ff9154a


DRILL-7276: Fixed an XSS vulnerability in Drill Web-UI query profile …

…page

@agozhiy, Change looks good, thanks for fixing this issue.
Could you please revise other JS scripts and check the usage of html(...) method and other possibly dangerous methods which may cause similar issues?

@agozhiy, I have noticed another issue: when the script is inserted into the autoLimit filed, it breaks the warning window with the error message, could you please take a look at this issue?

@vvysotskyi thanks for finding this case, fixed it now.
Cannot find any other dangerous usages of html() function, in most of the cases we use FreeMarker to substitute values.
Please, review.

Done.


travis.yml: Fix travis to publish master images

Travis CI is supposed to auto-publish images from master with the SHA tag to compliment official releases. In #647, the build and deploy matrix stopped matching so publishing stopped. This should fix.

This job seems to indicate it would start publishing again once merged to master. https://travis-ci.org/coreos/matchbox/jobs/299357700

Skipping a deployment with the script provider because this is not on the required runtime - nope

See #672


fix: disabling SSL for local OpenSearch docker

disabling the SSL for the local Docker Image since I was getting this error:

ConnectionError([SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129)) caused by: SSLError([SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129))

ok - makes sense, did not knew it was being used in tests - thanks 👍🏽


Projects Page  display: inline-block;

Hi,
Nice theme team, 👍
It would be nice if projects are show in inline.
We have multiple sub projects, we tried with below..
#projects-index ul.projects li.root {
margin-bottom: 20px
border: 1px solid #DDD;
        border-radius: 4px;
        box-shadow: 0 3px 5px rgba(0, 0, 0, 0.05);
        display: inline-block;
        margin: 0 0 10px;
        padding: 2%;
}

Hi,
I made something similar in 994410fd891bb47a52bb54907483dbd8983c1794, hope you like it!


New User: Mass Lists were not detected in all files

Basic information

My operating system: macOS Monterey 12.0
My MZmine version: MZmine 3, 64-bit, java -version

Hi, I am struggling in using MZmine 3.
I input the file, one at the time. The steps that I did: raw data methods > raw data import > mzML > choose the file > open > status:FINISHED > show raw data overview
but the mass list were all in red “x“ sign as showed in the screenshoot attached below. Then I cannot do the chromatogram building and the peak deconvolution.

I am looking forward to your guidance how to do better. Thank you

The mass list can be added by the Mass detection module, see the basic workflow here: https://mzmine.github.io/mzmine_documentation/workflows/lcmsworkflow/lcms-workflow.html
Or video tutorial: https://www.youtube.com/watch?v=hk7WeXibReg&list=PL0JAF-4UFc8N8DxAIOoF2cMSKy-wC4WWG&index=7&t=650s

Ok, I am following your steps until from youtube until the ADAP chromatogram builder but still the mass list is not available. Here I attach the screenshoots of what I just did:

Looking forward to your further guidance. Thank you

Why did you set Scan definition: 1 in the Mass detection parameters?

You should not apply scan filtering in mass detection. Make sure that its applied to all scans - so no RT filter etc.
Only if needed, you can do mass detection on MS level 1 and then a second step on MS level 2.

Hi all,
Thank you for your responses. Silly me, I click the wrong close button below yesterday.
About the mass detection, I tried again and not applied the scan definition. But, still I got the same result. Here I attached the screenshots for what I had done.

I still do not get the mass list when I saw the raw data overview:

Then, I changed the MS level 1 into MS level 2, and here what I saw:

so when I run the ADAP chromatogram builder, it was written the files do not have a mass list as I attached below:

What should I improve? Thank you in advance.
Best regards,
Agni

Just press on the clear button for the scan filter. Do not apply a retention time range filter. Those fields should be blank.

OK. I got it now. Thanks heaps!!!
Please check the attached picture below. Is it correct?

Make sure to apply mass detection to all scans.
either clear all scan filters in mass detection to do it in one step or if the noise levels are different for MS1 and MS2 then apply the mass detection 2 times. once for each MS level.
You can see in here


bump v0.0.2

@tinatorabi  --  can you review this please and then merge? Then we can finish the ASP PR in ACEfit.


Slider not rendering

Hey all, I'm trying to get a decent understanding of rickshaw so I've been trying to add functionality to one of the simpler examples, but the range slider just isn't working. I've been looking at the code for this example to try to get it to work, but even though my code looks the same it just isn't working. Part of my problem is that I'm not sure what all the minified files contain, so I'm not sure when I need to include individual .js files for which functionality. As I'm sure you've noticed the documentation doesn't cover this,
so if any of you have any insight for me it would be greatly appreciated.
A note about the below code, I'm using jinja2 templates, thus the url_for functions
<!doctype>

	<link type="text/css" rel="stylesheet" href="{{ url_for('static', filename='src/css/graph.css')}}">
	<link type="text/css" rel="stylesheet" href="{{ url_for('static', filename='src/css/detail.css')}}">
	<link type="text/css" rel="stylesheet" href="{{ url_for('static', filename='src/css/legend.css')}}">
	<link type="text/css" rel="stylesheet" href="{{ url_for('static', filename='src/css/lines.css')}}">

```
`

my issue was that the link to the jQuery-ui stylesheet wasn't working, so I went to jQuery's site and downloaded the files I needed and added them to my project that way.


refactor: pure es6 import syntax

Brief Information
This pull request is in the type of:

[ ] bug fixing
[ ] new feature
[x] ci
[x] refactoring

Related issues:

resolve #381

Details
Convert all require to import.
Except for conventional-changelog-action related scripts due to this.
Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA

Others
~Temporarily pause the work until #347 comes out.~

Since #352 adopted require syntax, now I will refactor to convert it to pure es6 modules and test the workflow in https://github.com/tyn1998/workflows-for-hypercrx.

Confirmed again, deploy is OK:


Theme 1.0 updates

Please review commit by commit, i.e. (1-10) refers to excel rows 1 to 10; (47-54) refers to excel rows 47 to 54
There's been design reverts that differ slightly from excel sheet, commit messages reflect that

Closes #2530, #1951, #2489, #2518, #2014, #2190, #1417

needs CS

needs CS

yeah the CS werent added on each commit, it's in one of the last few commits, one dedicated specifically for all changesets (theme and core)

I saw Status indicator QA snapshot changes, is there a mention in Icon size change in changeset?

Great catch!! There was an update in HD icon size indeed, just added that to cs and more comments in code to explain in case of confusion

To be confirmed: HD icon size is 12/24/36/48 instead current value 12/20/30/40

OK to be released?

To be confirmed: HD icon size is 12/24/36/48 instead current value 12/20/30/40

OK to be released?

Just got confirmation - it should be 12/20/30/40, changing values for HD --salt-size-icon to be 10px instead


@azure/storage-blob depends on depreciated package opentelemetry/types

Package Name: @azure/storge-blob
Package Version: 12.0.0
Operating system: any
[ x] nodejs

version:

[ ]
Describe the bug

npm install
npm WARN deprecated<EMAIL_ADDRESS>Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js

To Reproduce
Steps to reproduce the behavior:

have a package.json that refers to "@azure/storage-blob": "^12.0.0"

Expected behavior
Don't want the warning message
Can we get this released SOON.  Lot's of other Azure SDK's fixed this.
This is showing up on an install of the azure-iot-device SDK.

Thanks for reporting @anthonyvercolano
@vinjiang, @XiaoningLiu, All the relevant changes are in the master branch. All that is needed is to do the actual release.
cc @jeremymeng

Thanks @anthonyvercolano for the info! The planed release is on Jun which will involve several great new features in developing. We definitly appreciate the voice here, and wish to check if this works for you.
Thanks,
Jiachen

@jiacfan
Is the master branch of storage-blob in a state that it is not suitable for release?
When I hear that the June release of storage-blob will include several new features, I fear that a problem with any those new features would further delay the release of storage-blob.
Storage-blob is downloaded 73000 per week.  That means 73000 times a user gets to see the depreciation warnings.
While releasing too often can cause difficulties with customers, I think a cadence of once a month is just right.
It has been 2 months since storage-blob's last release.   It looks like it will be at least one more.
I am disappointed.

@jiacfan
Could we close this as the fix is already released?

Yes, definitely.
Thanks everyone!


feat: Add more data to the dashboard page chart #3365

add more data to the dashboard page chart such as “Groups,Roles,Certs and so on”

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Gexinyu2333:x: gxygxy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@Gexinyu2333 fix this CI:


Fill out minor tests and some cleanup

Description

Motivation and Context

Types of changes

[ ] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to
not work as expected)
[x] Improvement/refactoring (non-breaking change that doesn't add any feature
but make things better)

Checklist

[ ] Check other PRs and make sure that the changes are not done yet.
[ ] The PR title is no longer than 64 characters.

73% 🎉 🎉 🎉 🎉 🎉


Add Alpine Linux v3.14

Alpine Linux v3.14 released!
See https://www.alpinelinux.org/posts/Alpine-3.14.0-released.html

Thank you for the support of the project. This is your first PR, welcome to our community. I have verified your changes on the website and everything is correct.
I noticed that they moved the release page to a new link and therefore updated it also on our page.

Well ... I don't know why this PR need to be revised to have another not so related commit ...

Sorry, it was my fault. I saw the other PR to late.

I mean even without that PR, this one shouldn't be revised like this, should it? That's independent and unrelated change. This is a cool project, just think the process of PR review and revise can be more carefully ;)

I fully agree with you :+1: I will do it more carefully in the future.


Update orderBy

This refers to the https://github.com/vuejs/vue/pull/2591 and https://github.com/vuejs/vue/pull/2562 features.
Please tell me if I did the PR on the wrong branch so I can create a new one :smile:

Added some suggestions before merge this.

ping @ludo237

For me is fine @yyx990803 what do you think?

Should I add an example about using an dynamic Array to sort?
Let me rebase tomorrow to make it in one nice single commit

@posva I think just adding a note that you can use an Array is fine. Also GitHub now supports auto-squashing for merges, so no need to worry about commit numbers anymore :D

@yyx990803 Cool :smile:


Refactor InvokerHelper formatting methods

These are some refactorings and minor enhancements of the formatting methods in InvokerHelper.
The formatting of maps, arrays, collections and ranges should be more consistent, allowing the same parameters (verbose, maxSize, safe) everywhere. The 'safe' parameter gets used in many more contexts (though default is still false).
I hope that existing behavior and API was not changed (too much). I believe I did not change any existing public method signature, though I added a few with more options.
The behavior should be the same, except for the case when an Object.toString() method throws a checked exception, then this will be rethrown wrapped in a GroovyRuntimeException, when a method is invoked with 'safe=true', which I believe is done by PowerAsserts.
Some changes might need further discussions. One thing annoying me still is that after this PR, the methods
toArrayString(Object[] collection, boolean verbose, int maxSize, boolean safe) and formatCollection(Collection collection, boolean verbose, int maxSize, boolean safe) are syntactically equal, not sure if there is a nice way not to replicate code, yet also not transforming arrays to collections or vice versa.
The preAllocation of the StringBuffers might be too big, maybe a value like 3 or 4 might be nicer. It's always a heuristic value, maybe premature optimization.
I hope next to change the default printing in PowerAsserts and Groovysh to use the "verbose" flag.

rebased and added another little fix to escaping (with test)

on first look looks good to me... btw, very nice breaking up of commits and commit messages!

@tkruse: Could you please add a Apache license header to the test? Thanks!

Header added to new file. Note that there is some discussion on https://issuesPRE.apache.org/jira/browse/GROOVY-7564, so I guess this should not be merged until 7564 is okay with Paul, though I can make 7564 a separate PR if necessary. It is just one commit, independent of the rest.
Maybe a third opinion on this could help.

After reconsidering, reduced this PR to just providing strict refactorings, meaning (hopefully) no change of output.
The more controversial changes I have moved to https://github.com/apache/incubator-groovy/pull/111

Added several more tests in a commit before the changes to show API and behavior remain the same (tests should run before and after the refactorings)

compileJava is failing:
http://ci.groovy-lang.org/viewLog.html?buildId=26797&tab=buildResultsDiv&buildTypeId=Groovy_Jdk6Build

all PRs good now, I think. There were minor problems stemming from the reordering of commits to separate commits that refactor from commits that change behavior. Sorry that I don't retest locally after every rebase or commit change.

bump

Merged (finally!!), thanks!


What are the credentials referenced in the example code?

This is an excellent plugin, I am just not understanding which credentials to use in the readme example. I am trying to run it with my own values, and I get a "Login authentication failed" error. I think if this is clarified, it'll be really easy for people to get started with this plugin.
The following lines have the unclear variables:
func _on_connection_opened() -> void:
  # Replace <nick> and <OAuth Token> with actual values.
  $TwitchIRCClient.authenticate("<nick>", "<OAuth Token>")

and
func _on_authentication_succeeded() -> void:
  # Replace <twitch channel> with an actual value.
  $TwitchIRCClient.join("#<twitch channel>")

My questions are:

What is "Nick" referring to? The application name, the username of the developer account, or something else?
Is the "OAuth Token" supposed to come from here: https://twitchapps.com/tmi/, or should I get this from the developer console somewhere?
Is "twitch channel" referring to the channel that I want to run this api from?
I have a client ID and client secret from creating an app- are these values supposed to be entered in this code somewhere?

Thank you! Once this is clarified, I'm happy to make a pull request with some updates to the readme :)

To add slightly more info, I am just trying to get the "!helloworld" example running, so presumably I don't need a ton of credentials set up for that?

A couple things I found through trial and error! To get the !helloworld example working:

you don't need to create an app in the developer console
you do need to generate an oauth token here: https://twitchapps.com/tmi/
IMPORTANT: it will be generated in the form "oauth:123456". In the code, you JUST need the "123456" portion of it, if you include the "oauth:", it will not work!
I could modify "Nick" to be anything and it still worked (so the purpose of this variable isn't clear to me yet)

Hi. Thanks for testing the plugin and reporting these issues. Answering your questions:

It's good practice to pass the account name you've generated the OAuth token for as a nick. The NICK IRC message is a requirement of the RFC1459 (which, to be fair, I'm not sure Twitch follows closely.)

You must pass the OAuth token, omitting the oauth: part.

It's the Twitch channel whose chat you want to interact with. Remember that, at the moment, joining and managing several channels at once is not supported. Also, you need the chat:read OAuth scope to read messages, and chat:edit to send replies.

The plugin doesn't need your client ID or secret to use it.

I have updated the README accordingly.

There are a few ways to obtain OAuth tokens, which are described in greater detail on the Twitch developer docs.
Earlier revisions of the plugin's documentation briefly mentioned https://twitchapps.com/tmi/ as a way to obtain OAuth tokens, but I don't recommend it anymore. That site is an independent effort, and it could be decommissioned anytime (btw, at the moment I'm writing this, I'm getting an HTTP 403 error accessing that site's address, omitting the /tmi part, which is a bad sign.)
Tokens obtained there use the OAuth Implicit Grant Flow method, which is easy to implement, generated tokens last indefinitely (but expire, eventually) and is OK for testing purposes. The reason "you don't need" to register an app in this case is because you're authorizing their app to do stuff on your behalf, as you would with any other Twitch apps (StreamElements, Nightbot and others, for example.)
For this reason you ideally should register your own app and generate your tokens through it. Easier said than done, I'm sorry for that... You could try using the Twitch CLI, but tokens created with it use Authorization Code Grant Flow that last for about 4 hours, but at least you can refresh them manually.
I've been working on a prototype of a plugin to help with OAuth Authorization Code Grant Flow recently, complete with token validation and refreshing, but it still needs testing and I haven't decided yet how its API should look like yet. (And I've not much free time lately, that's why its taking me forever to finish it.)


Error while Pip installing

this is the preview for the error

I am getting this error as well. Check out some of the other issues here on this repo, some people have had success manually installing some of the dependencies.
Are you trying to use WSL btw?

I got the same error, both on Windows 11 and inside a WSL instance.

Oh thanks for the idea, and yes I'm trying to use WSL

I got the same error, both on Windows 11 and inside a WSL instance.

Did u rectified that error? If yes can u provide more details for how to solve the problem please?

@Karthikk-2003 Unfortunately no. I encountered this error while following a video to train SDXL. I am exploring another option at the moment via Kohya.
I wanted to consider the suggestion of fixing dependencies manually, but suspect that there'd be a lot of them to go through and while I understand programming, I am not fluent with python.

@Karthikk-2003 Unfortunately no. I encountered this error while following a video to train SDXL. I am exploring another option at the moment via Kohya. I wanted to consider the suggestion of fixing dependencies manually, but suspect that there'd be a lot of them to go through and while I understand programming, I am not fluent with python.

@wyxos, I want to fine-tune my GPT model. If you have any ideas, can you help me out with this?

@Karthikk-2003 I am not very familiar with training LLM but I recall seeing that hugging face has spaces to allow such training and has a version of CPU that's free. You may want to search around that option. If your use case requires local fine tuning, I suspect the only way at the moment would be to figure out and sort the issue around installing autotrainer.

Same error on M1 Mac

Removed some requirements and pushed updated version. M1/M2 mac is now working fine with installation. I have just tested.
triton will need to be installed by end-user if they need it.

please try: pip install -U autotrain-advanced and check if it gets version 0.6.15

@abhishekkrthakur Thanks. That is absolutely strange, was there an update to the package or something? Been running this exact command since then and all of a sudden it's now working.

yes. we pushed some fixes and made an update. glad to know its working now.

@Karthikk-2003 I am not very familiar with training LLM but I recall seeing that hugging face has spaces to allow such training and has a version of CPU that's free. You may want to search around that option. If your use case requires local fine tuning, I suspect the only way at the moment would be to figure out and sort the issue around installing autotrainer.

hey thanks, btw can you help me to delete those models, I've installed ton of GPT models through Visual Studio Code where it automatically downloaded those models when I just typed their names in the "model name", I'm running out of storage, Please someone help me to figure out how to delete those models, I don't remember Some of the model name that I've downloaded

models are downloaded in HF_CACHE which is usually located at ~/.cache/huggingface


No available [HOST] memory

I got no available host memory warning while I think I have enough memory for JVM/GPU.

(1)Stack dump
Update1
(2)My project is on coding.net.

But according to your log - you don't have enough ram. This warning is issued when app gets close to  Xmx threshold. In your case threshold is 8GB. For decent model with decent inputs - you might need higher values obviously.

Ok, I will try.


Project still alive?

Activity on watchexec seems to have basically stopped (is that fair comment @mattgreen?). Which seems a bit tragic to me, as of all the "watcher" type programs I've used, watchexec is my favourite and would like it to keep moving forward. Would it be possible to perhaps give a couple more people that admin bit?

To be clear: I'm not proposing myself as an admin. I'm far from being a rust coder. Just that we'd have some more people involved to get PRs merged etc.

Hi, thanks for poking me. I'm glad you like watchexec and would like it to continue.
I'd like to pass maintainer status on to someone else. Right now I'm working as a full-time dev and part-time PM while also being a dad, so open source is a bit hard to slot time for. I'm sorry for the languishing PRs and such.
If anyone would like to take it over, please let me know. If you'd like a little bit of guidance I can provide that, I just can't help out with code at the moment.

Completely understand and wish you good continuation with your other activities!
I'd be happy to take it over, especially as part of the notify and cargo-watch ecosystem (while of course letting watchexec remain agnostic as per its purpose), though I'll work with the community to get more people involved if possible so there's a more healthy balance and future, given my own state of occupation.
How should we do this? The least work for you would be to add me as a collaborator and give me publish rights on crates.io, but perhaps a more robust thing would be to move watchexec into its own Github organisation. Up to you.

No need to apologise at @mattgreen. Thank you sincerely for this project and the hours of your free time that you have given over it's lifetime. All the best.

Current status on this:

Created an organization for watchexec
Moved the repository over
Added passcod to org
Added passcod as owner on crates.io
Changed org permissions to default to admin

Everything look OK?

It does! Thank you Matt. I'll get on PRs asap / this weekend :)


Improve evaluation of group-by expression

I was unable to group-by nested properties eg. group-by="country.name"or functions. This PR uses Angular's $parse method to resolve the expression and seems to work better.
I have had to leave the $scope.$eval call in for compatibility – without it you need to write the expression without quotes group-by="country.name" rather than group-by="'country.name'" which I would prefer but breaks the tests and therefore existing implementations.

I'd prefer the idea of dropping the single quotes maybe we just stack this with any other breaking changes till then.

As there is not comments on this PR  (only from maintainers). I will close it down. If needed people can reopen/ comment and we can have a look at it.


Move the Design Doc to the README.

I added blueprint template and changed cluster create.

Let's move it to the readme after we finish the design

Certainly it's not finished, but I think it's good enough to require commits to make changes. I mean, on the wiki, we are making commits anyways just in a separate history :/

The doc is missing things like cluster stop/start. At least we should have all the commands we plan to support in v0.1, then make commits if/when we change their output

I agree. It's also missing things like services, tasks, etc.
The point is that we should be keeping one history.
Also, the empty README we have now is missing WAY more than this commit is.


IPSec interface does not show under Interfaces or Firewall rules

Hi,
I have just configured IPSec and it works very well (up to point where traffic is routed), but when I was going to setup firewall rules for it, it's not there.. I tried to "Assignments" under Interfaces and see if its waiting there, but no luck..
On my dashboard etc the IPSec shows in traffic graphs etc..
best regards
Thomas

Hi Thomas,
Which version? I think this was permanently fixed in 17.1.1:
https://github.com/opnsense/changelog/blob/master/doc/17.1/17.1.1#L36
Cheers,
Franco

Hi @fichtner
17.1.2 (installed).
I started at 17.1 but did a update from that to 17.1.1 and then to 17.1.2 if that helps..
best regards
Thomas

Ok, saving the config in any dialog should fix this. If not we need to take a closer look...

That does not do it.. Tried refreshing everything but no luck..

One more in the forum: https://forum.opnsense.org/index.php?topic=4638.0
Maybe it's this: https://github.com/opnsense/core/commit/318426c
Can you try to revert via:
opnsense-patch 318426c
And save an unrelated page like e.g. System: Setting: General?
Thanks,
Franco

I'll check that after a few hours sleep...

THX Franco, after patching and saving something somewhere the IPsec interface was back in Firewall > Rules.
But the old problem remains the same, I can't connect to the dev's behind the IPsec. It even got worse, can't connect even with the rules on WAN enabled...

@mircsicz need to take a look at that config and why it's breaking the expected logic.. the IPsec pass rules could be gone for the moment: try to reapply the firewall rules with the tab and pass rule in place.

already done... ;-)

But no change

My IPSec rule tab has re-appeared, but it's still not shown under interfaces src/dst in rules etc.

This happened when i created a site-to-site vpn with phase1 and phase2 entry..

I can now successfully hide/unhide the IPSec tab under firewalls by enable/disable Phase2 on my site-to-site profile.. So I guess there is some broken logic on the part that decides when to show that tab based on that..

timeout due to inactivity


Update light_HassLightSet.yaml

fixed variable names  ,  and  (which should remain in English). Added some more verb variations.

Closing this request as it won't pass the test due to variable conflict.
Although it is a good practice to keep variables in English, these specific variables came from the "expansion_rules" and might be in the translators' language to simplify sentence construction.
I'll make a new PR to add the suggested sentence additions.


cmd-shift-enter doesn't strip whitespace

When on a line with only white-spaces, it correctly removes them if I press enter. If I want to add a new line above the current line, it doesn't work however.

I have made a pull request that should fix the issue of 'cmd-enter' (and the other default mappings for Atom's newline and newline-below commands). Also looking into ways to fix newline-above.

Fixed by #3 (v1.1.0)


Use of Model when using partial page views can sometimes cause error

Some views use @Html.Partial("BreadCrumbsView", Model) and because the binding is dynamic errors are produced. The use of Model is pointless and the lines where Model is passed can be written like so @Html.Partial("BreadCrumbsView").
The following is the same issue I encountered:
https://stackoverflow.com/questions/28465114/system-web-mvc-htmlhelper-has-no-applicable-method-named-partial
I will create a PR to fix this.

Thanks! Although I understand that Model could be passed implicit does any views in the demo project fail to define the model?

Nope but if code is copied from one of the views to a custom view without a model specified it can cause issues which can be avoided by either specifying a model or removing the model from the call.


Exercise 4.19 Obtain wdi object

Exercise 4.19 Obtain wdi object from exercise 5 of the Exercise section. The following questions focus only on year 2000 (which means all the following questions implicitly start with the expression, for those from year 2000.)

How many observations are there?

The followings are iso2c values that represent a region but not a country. Take a subsample that excludes those region (i.e. a subsample that consists of countries),

iso2c_nonCountry <- c('ZH','ZI','1A','S3','B8','V2','Z4','4E','T4','XC','Z7','7E','T7','EU','F1','XE','XD','XF','ZT','XH','XI','XG','V3','ZJ','XJ','T2','XL','XO','XM','XN','ZQ','XQ','T3','XP','XU','XY','OE','S4','S2','V4','V1','S1','8S','T5','ZG','ZF','T6','XT','1W')

The following questions focus on the subsample.
3, How many countries are there?

Regarding Energy use (kg of oil equivalent per capita). Complete the following summary:

For Energy use (kg of oil equivalent per capita), there are … observations with … missing values. Excluding missing values, the range of energy use is between … and … kg/per capita of oil equivalent with median usage of … and mean usage of … .

The wdi$data’s feature meanings (other than iso2c, year, and country) can be found at:
browseURL(wdi$meta)

https://github.com/raychiu135/110-1-r4ds-main/blob/7764b84117a53c6a8b456a78eb9477a99909df9b/exercise_4.19.rmd#L2


Target Damage doesn't work with Healer's Blessing effect

As title says, may be incompatible with the healing-received selector overall.

(Healing with Target Damage vs. without it (untargeted).)

Have this exact same issue.
Original Application buttons have class="heal-damage vs. Target Damage buttons with class="pf2e-td heal-damage applied"
It's definitely something with how pf2e is interpreting the Target Damage healing application button.

It's not about the classes. It's about having an outdated applyDamageFromMessage function.
Will have to copy paste the system code again so its up to date.
Made an issue in the pf2e system to not have to copy paste code and keep it from going stale.
https://github.com/foundryvtt/pf2e/issues/10927

It's not about the classes. It's about having an outdated applyDamageFromMessage function. Will have to copy paste the system code again so its up to date.
Made an issue in the pf2e system to not have to copy paste code and keep it from going stale. foundryvtt/pf2e#10927

Oh interesting, and a good ask of the pf2e devs!

Looks like updating the damage function will need more involvement than a mere copy paste, as that doesn't seem to be doing much in terms of fixing these issues, if not outright breaking stuff.
If anyone wants to look into this, I will gladly merge the PR.

I'm not sure but would this be what is causing the life oracle curse to not apply the penalty properly properly? The system damage button works properly however the target one does not.

I'm not sure but would this be what is causing the life oracle curse to not apply the penalty properly properly? The system damage button works properly however the target one does not.

Yes


[FLINK-18422][docs] Update Prefer tag in documentation 'Fault Tolerance training lesson'

What is the purpose of the change
Update Prefer tag in documentation 'Fault Tolerance training lesson' according to Prefer Reminder .The markdown file location is:  flink/docs/learn-flink/fault_tolerance.md
Brief change log

Update Prefer tag in documentation 'flink/docs/learn-flink/fault_tolerance.md'

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? no

@klion26
Could you help me to review this PR(https://github.com/apache/flink/pull/12778)
Thank you.

Hi, @wuchong
Could you help me to review this PR(https://github.com/apache/flink/pull/12778)？
Thank you.

@RocMarshal  thanks for your contribution, could you please also change the Chinese version?

@RocMarshal thanks for your contribution, could you please also change the Chinese version?

@klion26
Of course. I had completed the changes in PR 12727 according to your suggestions, which was already merged into master branch.
Thank you so much.

@klion26 ,
I have made some changes according to your suggestions and David Anderson's reply ,please take a look.
Thank you !

@wuchong Could you help me to merge this PR if the condition is met ?
Thank you.


Add type for SuiteTest

Description
Add typing for test arguments.
Related Issue

Type of Change

[ ] 📚 Examples / docs / tutorials / dependencies update
[ ] 🔧 Bug fix (non-breaking change which fixes an issue)
[x] 🥂 Improvement (non-breaking change which improves an existing feature)
[ ] 🚀 New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🔐 Security fix

Checklist

[x] I've read the CODE_OF_CONDUCT.md document.
[x] I've read the CONTRIBUTING.md guide.
[x] I've updated the code style using make codestyle.
[x] I've written tests for all new methods and classes that I created.
[x] I've written the docstring in Google format for all the methods and classes that I used.

There is no make file for the make codestyle command ?

Btw, just looking into the logs :

Hello and thanks for your contribution :)
CI is sometimes temperamental on github for windows and mac, let me retry it first.
We are using cachine here and there in the CI, but the error while installing packages was probably something looking like an architecture issue and/or some system packages missing.
So should not be linked in any way to your PR indeed !


introduce proc macro - inject_error

Motivation
This commit introduces a proc macro inject-error which can help test the robustness of the system.
The feature is gated by a feature flag and not enabled in cargo test i.e. #[cfg(all(not(test), feature="inject-error"))]
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
test binary
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

My two worries here are those:

We are going to generate failure in any unit test, it can contribute to higher degree of flakiness. Especially if some people later won't know about this feature
We might have a problem of test feature activating in release mode(this have happened in past - do we have any active guard against it @metajack / @sunshowers ?). If this happen that would be pretty sad

@andll for first no, I'm not looking for injecting it in unit tests where it tests expected behavior. it aims for smoke test/cluster test at integration level.
for second, I don't have a good idea where to gate it, what I have in mind is config + env var given smoke test/cluster test is built without features.

For first - looking at the code it seems it just sets fixed chance of failure when compiled with test feature? Do you mean there will be some additional work to adjust that with config?
Also note that cluster test runs release binaries, since it verifies docker images before they shipped to prod.

@andll yeah, it's just prototype, one way is to gate with an env var. so it can be if enable && rand < chance and removed the cfg(test), we probably can further customize the chance with some config value

why not gate it behind a feature flag?

@bors-libra delegate+

:v: @zekun000 can now approve this pull request

@bors-libra r=metajack

:pushpin: Commit 7064a15 has been approved by metajack

:hourglass: Testing commit 7064a152ea64086fbb5b64cfe06773d92b57e60c with merge 9bea6f45dc6cca050872a0a0b2bae4b0bc210a2a...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra r=metajack

:pushpin: Commit fddcb68 has been approved by metajack

:hourglass: Testing commit fddcb68a7a3d2ee20cc9d470d770a03e30d1b203 with merge 832c44966022f99308329ee13e0e7e6e3a7439b2...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: metajack
Pushing 832c44966022f99308329ee13e0e7e6e3a7439b2 to master...


Login page (home)

[x] Auth page with empty div.
[x] Sign in and sign up feature in one page
[ ] Allow users to skip authenticating and go to home page directly.

Skipping "Allow users to skip authenticating and go to home page directly."


Added the option to disable the embedded HTTP server.

A new argument was added: httpServerEnabled with default value of true (which maintain existing behavior).

Looks good, thanks!

@ajsquared: will you create a new release or are you planning on adding more functionality before releasing v1.0.2?

I don't have anything planned.  I'll release 1.0.2 today.

great. thanks!

I've just published the 1.0.2 release with this change.  It should be in Maven Central shortly.


environment variable expansion

It would be nice for environment variable placed in the resource path to be expanded ... i.e. you could have -resource=secret:secrets/%ENV%/me:file=filename.test,fmt=yaml

#17


Possible regression: image preview no longer working as before

I just installed the latest AsciiDoc in Code (0.3.1), and now the images links are broken in preview.
In my file:
:imagesdir: images is at the top
image:059_01_Couchbase_Web_Console.png[Couchbase Web Console login] is later in the post
And in the preview:

Am I doing something wrong, or is this a regression?

Fix published to the marketplace on 0.3.2 .


Some difficulties reproducing the results in paper.

Thank you for your significant contributions to the field of time series, which have given me the opportunity to build on your work in downstream tasks. However, I am facing some challenges in reproducing the results of your paper. I have used the unsupervised pre-training mode to complete the regression of AppliancesEnergy data, and the parameters are also specific values given in your paper (Table 14).
The specific pre-training code is as follows.
python src/main.py --output_dir experiments --comment "pretraining through imputation" --name pretrained --records_file Imputation_records.xls --data_dir "/AppliancesEnergy/" --data_class tsra --pattern TRAIN --val_ratio 0.2 --epochs 700 --lr 0.001 --optimizer RAdam  --pos_encoding learnable --num_layers 3  --num_heads 16 --d_model 128 --dim_feedforward 512 --batch_size 128
The specific fine-tune code is as follows.
python src/main.py --output_dir experiments --comment "finetune for regression" --name finetuned --records_file Regression_records.xls --data_dir /AppliancesEnergy/ --data_class tsra --pattern TRAIN --val_pattern TEST  --epochs 200 --lr 0.001 --optimizer RAdam --pos_encoding learnable  --load_model /pretrained_2023-02-17_21-13-58_dtF/checkpoints/model_best.pth --task regression --change_output --num_layers 3  --num_heads 16 --d_model 128 --dim_feedforward 512 --batch_size 128
The specific test code is as follows.
python src/main.py --output_dir experiments --comment "test" --name test  --data_dir /AppliancesEnergy/ --data_class tsra  --load_model /finetuned_2023-02-17_21-28-36_l5O/checkpoints/model_best.pth --pattern TEST --test_only testset --num_layers 3  --num_heads 16 --d_model 128 --dim_feedforward 512 --batch_size 128 --task regression
I have run these three steps (pre-training, fine-tuning, and testing) several times, but each time the test loss results have a large difference with that in paper. I saw that there is a similar situation in issue 19 (Test result in multivariate dataset without pretrain #19), and he said he solved it this way (He search best epoch and train the model with such epoch and the whole train set). However, I did not understand his meaning indeed. Would you be able to provide a detailed explanation or some other advice to me as a beginner?
the RMSE pretrained reslut of  AppliancesEnergy is 2.375 (Table 4)
but i got thes test result:
Test Summary: loss: 11.078025
Test Summary: loss: 11.406574 |
Test Summary: loss: 10.409667

Okay, so the first thing to keep in mind is that the values reported by the code (as mentioned in the README), are always MSE, not RMSE, so you should take the square root at the end, which means that the last RMSE loss in your experiments  would be about sqrt(10.41) = 3.226.
Secondly, and very importantly, you should allow fine-tuning for a sufficient number of epochs (e.g. 700 for this dataset - you can monitor how the loss evolves).  In this dataset, I got the best results after more than 600 epochs of fine-tuning.
Finally, specifically for this dataset, the result for the pre-trained / fine-tuned transformer was achieved with a batch size of 64, not 128; the rest of the hyperparameters are correct. A couple of datasets, including this one, displayed a better performance with a batch size different from 128 (typically 64 or 32) and for this reason the batch size should have been probably mentioned as a separate hyperparameter - but unfortunately never was.
If you take care of these 3 points, I believe you will get the performance you desire.

Thank you for your patient guidance. Following your advice, I have successfully reproduced the results. Hyperparameters can be a love-hate thing.  In other words, do you have any suggestions for me to tune hyperparameters on my own dataset?

In addition, I encountered a small problem when creating my own dataset and would appreciate your help in identifying the issue. My data is a 3D matrix of shape (600, 256, 200), where 600 is the train size, 256 is the length, and 200 is the number of features (i.e., dimensions). Following your example, I created a new data-loading class using the following code, and the dimensions of all_df, feature_df, and labels_df look correct. However, there is a problem with all_IDs. According to your original code, its length should be the train size, but I currently have a length of 256, which is the length.
`class Data(BaseData):
def init(self, root_dir, file_list=None, pattern=None, n_proc=1, limit_size=None, config=None):
# self.set_num_processes(n_proc=n_proc)
self.config = config
self.all_df, self.labels_df = self.load_all(root_dir, file_list=file_list, pattern=pattern)
self.all_IDs = self.all_df.index.unique()  # all sample (session) IDs
self.max_seq_len = 66
self.feature_names = self.all_df.columns
self.feature_df = self.all_df
def load_all(self, root_dir, file_list=None, pattern=None):
    ts=np.load(root_dir+'feature.npy') # (600,256,200)
    df = pd.concat([pd.DataFrame(subj) for subj in ts])
    if self.config['task'] == 'regression':
        lable=np.load(root_dir+'label.npy',encoding='latin1')   #(600,)
        labels_df = pd.DataFrame(lable, dtype=np.float32)
    else:
        labels_df = None
    return df, labels_df

data_factory = {'data': Data}
`
I am not sure how this affects data loading and processing, and I am concerned that it might impact the processing of the samples. Therefore, I made some modifications based on the TSRegressionArchive, but I am unable to run it.
`class Data(BaseData):
def init(self, root_dir, file_list=None, pattern=None, n_proc=1, limit_size=None, config=None):
# self.set_num_processes(n_proc=n_proc)
self.config = config
self.all_df, self.labels_df = self.load_all(root_dir, file_list=file_list, pattern=pattern)
self.all_IDs = self.all_df.index.unique()  # all sample (session) IDs
self.max_seq_len = 66
self.feature_names = self.all_df.columns
self.feature_df = self.all_df
def load_all(self, root_dir, file_list=None, pattern=None):
    ts=np.load(root_dir+'feature.npy') # (600,256,200)
    df = pd.concat([self.load_subj(subj) for subj in ts])
    if self.config['task'] == 'regression':
        lable=np.load(root_dir+'label.npy',encoding='latin1')   #(600,)
        labels_df = pd.DataFrame(lable, dtype=np.float32)
    else:
        labels_df = None
    return df, labels_df
def load_subj(self,subj):
    df = pd.DataFrame(subj)
    lengths = np.full((600, 200), 256)
    df =[pd.DataFrame({col: df.loc[row, col] for col in df.columns}).reset_index(drop=True).set_index(
        pd.Series(lengths[row, 0]*[row])) for row in range(df.shape[0])]
    return df`

Hi @Guanyunlph , thank you for your kind words. I am glad you could perfectly reproduce the results.
I think your last post is a completely different topic, so could you please remove if from this thread and open a new issue? (It helps with discoverability, visibility etc). I will try to answer with a few thoughts.

Well, I'd be happy to do that.