Source generator does not discover endpoints in nested classes

Hi,
I have been working my project that uses quite a lot of generated code. I am also using vertical-slices approach with class by feature approach.
Long story short - my use case requires the endpoint class to be a nested class. Currently the code generated by the source generator does not see the class.
I found a workaround for that if someone is interested.
This also simplified the code a little bit - BTW is there a reason for so much workarounds and exclusions in current generator's code?
Here is my approach for file: Src/Generator/EndpointsDiscoveryGenerator.cs
[Generator(LanguageNames.CSharp)]
public class EndpointsDiscoveryGenerator : IIncrementalGenerator
{
    public void Initialize(IncrementalGeneratorInitializationContext context)
    {
        var typeDeclarationSyntaxProvider = context.SyntaxProvider.CreateSyntaxProvider(
                (sn, _) => sn is TypeDeclarationSyntax,
                (c, _) => Transform(c))
            .Where(p => p is not null);

        var compilationAndClasses = context.CompilationProvider.Combine(typeDeclarationSyntaxProvider.Collect());

        context.RegisterSourceOutput(compilationAndClasses, (spc, source) => Execute(source.Left, source.Right, spc));
    }

    private void Execute(ImmutableArray<ITypeSymbol> typeSymbols, SourceProductionContext spc)
    {
        if (!typeSymbols.Any())
            return;
        var fileContent = GetContent(typeSymbols);
        spc.AddSource(
            "DiscoveredTypes.g.cs",
            SourceText.From(fileContent,
                Encoding.UTF8));
    }

    private ITypeSymbol? Transform(GeneratorSyntaxContext ctx)
    {
        var symbol = ctx.SemanticModel.GetDeclaredSymbol(ctx.Node);
        if (symbol is not ITypeSymbol typeSymbol) return null;
        var isEndpoint = typeSymbol.AllInterfaces.Select(i => new TypeDescription(i)).Intersect(new[]
        {
            new TypeDescription("FastEndpoints.IEndpoint"),
            new TypeDescription("FastEndpoints.IEventHandler"),
            new TypeDescription("FastEndpoints.ICommandHandler"),
            new TypeDescription("FastEndpoints.ISummary"),
        }).Any() && typeSymbol is { IsAbstract: false, DeclaredAccessibility: Accessibility.Public };
        return isEndpoint ? typeSymbol : null;
    }

    private static string GetContent(IEnumerable<ITypeSymbol> filteredTypes)
    {
        var sb = new StringBuilder(@"
using System;
namespace FastEndpoints
{
    public static class DiscoveredTypes
    {
        public static readonly System.Type[] All = new System.Type[]
        {
");

        foreach (var discoveredType in filteredTypes)
        {
            sb.Append("            typeof(")
                .Append(discoveredType.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat)).Append(@"),
");
        }

        sb.Append(@"        };
    }
}");
        return sb.ToString();
    }
}

@nefarius would you like to take this one?
@ekspedycja can you pls send your changes in as PR so it's easy to what you've done pls?

https://github.com/FastEndpoints/FastEndpoints/pull/472

<IP_ADDRESS>-beta pushed to nuget if you guys wanna give it a test run.

@ekspedycja @nefarius
guys it's been reported that the new source generator does not discover types from referenced assemblies in the same solution.
i've put together a small repro showing what the issue is.
i have absolutely no clue on how to remedy this. any ideas?
thanks!

Issue solved with a minor breaking change to how we register the discovered types :-)
The source generator no longer automatically discovers types from referenced assemblies/projects.
You now have to add the FastEndpoints.Generator package to each project you'd like to use type discovery with and register the discovered types per assembly like so:
builder.Services.AddFastEndpoints(o =>
{
    o.SourceGeneratorDiscoveredTypes.AddRange(MyApplication.DiscoveredTypes.All);
    o.SourceGeneratorDiscoveredTypes.AddRange(SomeClassLib.DiscoveredTypes.All);
})

We should add that to the documentation as it's not immediately self-explanatory what's happening now, IMHO.


Having lightning-bolts pinned to a commit hash is breaking publishing to PyPI

Description
Having lightning-bolts pinned to a commit hash is causing the publish and publish-dev actions to fail with
WARNING  Error during upload. Retry with the --verbose option for more details.
ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
         Invalid value for requires_dist. Error: Can't have direct dependency:
         'lightning-bolts @
         git+https://github.com/Lightning-AI/lightning-bolts.git@78cbcdd5226d5d1
         cb5d9214a12c499bb702fe80f ; extra == "test"'

TODO

[ ] Find a working test datamodule that is included in a published lightning-bolts release
[ ] Update serotiny/config/data/test_mnist.yaml to use the new datamodule

Fixed by #127 and #126


[UX] UX issues in the revisions page

Describe your problem(s)

Isn't it better to have a deploy "this" revision button here?

Since the column name is "deployed revision" (past tense) it's not intuitive that we can "do" deploy here.

Describe your problem(s)

Isn't it better to have a deploy "this" revision button here?
User can not directly deploy revision unless he selects the gateway/URLs, So we cant add the deploy option there the the users will confuse if we put the deploy option in multiple places

Since the column name is "deployed revision" (past tense) it's not intuitive that we can "do" deploy here.
Yes, since this column shows both deployed revision(Once deployed revision it will show the deployed revision) and deploy option(Deploy existing revision), How about change column name to Manage revision

Can't we open the same window (but filled) that's opened by the "Deploy new revision" button? To me, it looks natural to have a "deploy" button for each revision because that's what we really deploy at the end.

How about just "API Revisions"?

Regarding 1, yes, having "deploy" in multiple places can be confusing. IMO what we should remove is the button from the table below and just show "deployed revisions" there. On the other hand, if someone wants to deploy a revision in all gateways, we need a lot of deploy clicks in that table. If we use the same pop up as I said, we only need 1 deploy click.  WDYT?

@tmkasun

Regarding 1, yes, having "deploy" in multiple places can be confusing. IMO what we should remove is the button from the table below and just show "deployed revisions" there. On the other hand, if someone wants to deploy a revision in all gateways, we need a lot of deploy clicks in that table. If we use the same pop up as I said, we only need 1 deploy click. WDYT?

In the UX review we agreed to show deploy button only on the table as it was straight forward and caters the Pareto principle.
Yes, edge cases like user deploy a revision in all gateways, it will be a burden  to the user.

Since we think the current way is fine, I'll close the issue.


Enabling vite server dynamic imports

Context: nuxt/nuxt.js#13819 > vitejs/vite#8641 > nuxt/framework#5506 > nuxt/framework#5506 > nuxt/framework#6412 > nuxt/framework#6423 > nuxt/framework#6433
Enabling dynamic chunks for vite server output, allows lazy loading page chunks in production and reducing startup time but due to reported issues, we currently disable this behavior until stablize and fixing hydration issues and their cause.

This has been enabled by default.


Building solution with --runtime fails with error LIB003

Functional impact
Build fails in CI server
Minimal repro steps
I have a build pipeline that runs each step in the nano sdk container on Windows 2019 (microsoft/dotnet:2.2.103-sdk-nanoserver-1809). The source code folder is mapped into the container as a volume.
My solution contains a web project, a couple of support projects and a couple of test projects that depend on the web project

dotnet restore my.sln --configuration release --runtime win-x64
dotnet build my.sln --configuration release --runtime win-x64 --no-restore

Step 2 fails with multiple instances of error LIB003, each for a different file. The files in question are present
libman.json : error LIB003: css/bootstrap-grid.min.css.map could not be written to disk. Make sure the file name is correct

Expected result
The build would work
Further technical details

Running a LibMan CLI step before the build to restore the packages doesn't solve the issue
Removing the --runtime win-x64 option works.
Doing the build on the web project works.

My guess is that there's a race condition between concurrent downloads of the packages caused by builds of the test projects. When --runtime is specified the output shows 2 instances of
  Restoring library<EMAIL_ADDRESS>  Restoring library<EMAIL_ADDRESS>  Restoring library<EMAIL_ADDRESS>  Restoring library<EMAIL_ADDRESS>  Restoring library<EMAIL_ADDRESS>
  5 libraries restored in 0.18 seconds

whereas without it only 1 restore is done.

Same issue on v2.1.76. Is there any workaround?

I'm having the same issue with multiple LIB003 errors, but I'm using mcr.microsoft.com/dotnet/sdk:6.0 for the build.
Furthermore the dotnet restore does not throw any exception, I'm getting the error when dotnet publish command is executed on the web-project of my solution.

I am having a similar issue; I dont have the runtime options, but the project does have them in the proj like this ;
<RuntimeIdentifiers>win-x64;linux-x64</RuntimeIdentifiers>

I get this error; pretty consistently
libman.json : error LIB003: highstock.src.js could not be written to disk. Make sure the file name is correct

on version 2.1.161, but had it on earlier versions too.

We are experiencing this sporadically as well. Is there any update?

I would also like to tack onto this issue. I am seeing it while restoring a net6.0 asp.net web app in a docker container.
It's important to note that while the web app doesn't have multiple runtimes, and I wasn't using the CLI options to specify one, the app did use some legacy packages in .Net Framework. I had been using the dotnet core docker image as my build, so I tried using a framework image instead to see if that helped - and it did! So for anyone stuck on this, I might recommend trying a Framework container and see if it helps, especially if you have legacy/old Nuget packages that run in Framework (even if your web app is dotnet core)

I still have the same error, I have tried a few ways to fix it but it's still unclear, when I open the project it crashes
I did clean a few times and it disappeared.

@Hoai-Phong can you share the libman.json snippet for that library so I can try to reproduce the issue?

@jimmylewis
Send you
{
"version": "1.0",
"defaultProvider": "cdnjs",
"libraries": [
{
"library"<EMAIL_ADDRESS>"destination": "wwwroot/lib/jquery/",
"files": [
"jquery.min.js",
"jquery.js"
]
},
{
"provider": "cdnjs",
"library"<EMAIL_ADDRESS>"destination": "wwwroot/lib/bootstrap/",
"files": [
"js/bootstrap.min.js",
"js/bootstrap.js"
]
},
{
"provider": "unpkg",
"library"<EMAIL_ADDRESS>"destination": "wwwroot/lib/datatables.net-bs5/",
"files": [
"css/dataTables.bootstrap5.css",
"css/dataTables.bootstrap5.min.css",
"js/dataTables.bootstrap5.js",
"js/dataTables.bootstrap5.min.js"
]
},
{
  "provider": "unpkg",
  "library"<EMAIL_ADDRESS>  "destination": "wwwroot/lib/datatables.net-buttons-bs5/",
  "files": [
    "css/buttons.bootstrap5.css",
    "css/buttons.bootstrap5.min.css",
    "js/buttons.bootstrap5.js",
    "js/buttons.bootstrap5.min.js",
    "js/buttons.bootstrap5.mjs"

  ]
},
{
  "provider": "unpkg",
  "library"<EMAIL_ADDRESS>  "destination": "wwwroot/lib/datatables.net-responsive-bs5/",
  "files": [
    "css/responsive.bootstrap5.css",
    "css/responsive.bootstrap5.min.css",
    "js/responsive.bootstrap5.js",
    "js/responsive.bootstrap5.min.js",
    "js/responsive.bootstrap5.mjs"

  ]
},
{
  "library"<EMAIL_ADDRESS>  "destination": "wwwroot/lib/datatables-responsive/"
},
{
  "library"<EMAIL_ADDRESS>  "destination": "wwwroot/lib/datatables.net-select/",
  "files": [
    "dataTables.select.js"
  ]
},
{
  "library"<EMAIL_ADDRESS>  "destination": "wwwroot/lib/jquery-timepicker/"
},
{
  "library"<EMAIL_ADDRESS>  "destination": "wwwroot/lib/moment.js/"
},

{
  "provider": "cdnjs",
  "library"<EMAIL_ADDRESS>  "destination": "wwwroot/lib/i18next/",
  "files": [
    "i18next.min.js",
    "i18next.js"
  ]
},
{
  "provider": "cdnjs",
  "library"<EMAIL_ADDRESS>  "destination": "wwwroot/lib/select2/",
  "files": [
    "js/select2.min.js",
    "js/select2.js"
  ]
},
{
  "provider": "unpkg",
  "library"<EMAIL_ADDRESS>  "destination": "wwwroot/lib/jquery-datatables-checkboxes/",
  "files": [
    "css/dataTables.checkboxes.css",
    "js/dataTables.checkboxes.js",
    "js/dataTables.checkboxes.min.js"
  ]
},
{
  "provider": "cdnjs",
  "library"<EMAIL_ADDRESS>  "destination": "wwwroot/lib/select2/"
},
{
  "provider": "cdnjs",
  "library"<EMAIL_ADDRESS>  "destination": "wwwroot/lib/flatpickr/"
},
{
  "provider": "unpkg",
  "library"<EMAIL_ADDRESS>  "destination": "wwwroot/lib/datatables.net/",
  "files": [
    "js/jquery.dataTables.js",
    "js/jquery.dataTables.min.js"
  ]
},

{
  "provider": "cdnjs",
  "library"<EMAIL_ADDRESS>  "destination": "wwwroot/lib/datatables-buttons/",
  "files": [
    "js/dataTables.buttons.min.js",
    "js/dataTables.buttons.js",
    "js/buttons.print.mjs",
    "js/buttons.print.min.mjs",
    "js/buttons.print.min.js",
    "js/buttons.print.js",
    "js/buttons.html5.mjs",
    "js/buttons.html5.min.mjs",
    "js/buttons.html5.min.js",
    "js/buttons.html5.js"
  ]
},

{
  "provider": "cdnjs",
  "library"<EMAIL_ADDRESS>  "destination": "wwwroot/lib/sweetalert2/"
},
{
  "provider": "cdnjs",
  "library"<EMAIL_ADDRESS>  "destination": "wwwroot/lib/datatables.net-scroller-bs5/",
  "files": [
    "scroller.bootstrap5.min.js",
    "scroller.bootstrap5.css",
    "scroller.bootstrap5.js",
    "scroller.bootstrap5.min.css"
  ]
},
{
  "provider": "unpkg",
  "library": "<EMAIL_ADDRESS>  "destination": "wwwroot/lib/ckeditor/ckeditor5-alignment/",
  "files": [
    "src/alignment.js",
    "build/alignment.js",
    "build/translations/ja.js"
  ]
},
{
  "provider": "unpkg",
  "library": "<EMAIL_ADDRESS>  "destination": "wwwroot/lib/ckeditor/ckeditor5-alignment/",
  "files": [
    "src/alignment.js",
    "build/alignment.js",
    "build/translations/ja.js"
  ]
},

{
  "provider": "unpkg",
  "library": "<EMAIL_ADDRESS>  "destination": "wwwroot/lib/ckeditor/ckeditor5-basic-styles/",
  "files": [
    "build/basic-styles.js",
    "build/translations/ja.js"
  ]
},
{
  "provider": "unpkg",
  "library": "<EMAIL_ADDRESS>  "destination": "wwwroot/lib/ckeditor/ckeditor5-editor-classic/",
  "files": [
    "build/editor-classic.js"
  ]
},
{
  "provider": "unpkg",
  "library"<EMAIL_ADDRESS>  "destination": "wwwroot/lib/ckeditor5/",
  "files": [
    "build/ckeditor5-dll.js",
    "build/translations/ja.js"
  ]
},
{
  "provider": "unpkg",
  "library": "<EMAIL_ADDRESS>  "destination": "wwwroot/lib/ckeditor/ckeditor5-font/",
  "files": [
    "build/font.js",
    "build/translations/ja.js"
  ]
},
{
  "provider": "unpkg",
  "library": "<EMAIL_ADDRESS>  "destination": "wwwroot/lib/ckeditor/ckeditor5-link/",
  "files": [
    "build/link.js",
    "build/translations/ja.js"
  ]
},
{
  "provider": "unpkg",
  "library": "<EMAIL_ADDRESS>  "destination": "wwwroot/lib/ckeditor/ckeditor5-style/",
  "files": [
    "build/style.js",
    "build/translations/ja.js"
  ]
}

,
{
"provider": "unpkg",
"library": "<EMAIL_ADDRESS>"destination": "wwwroot/lib/ckeditor/ckeditor5-build-classic/",
"files": [
"build/ckeditor.js",
"build/translations/ja.js"
]
}
,
{
"provider": "unpkg",
"library": "<EMAIL_ADDRESS>"destination": "wwwroot/lib/ckeditor/ckeditor5-heading/",
"files": [
"build/heading.js",
"build/translations/ja.js"
]
}
,
{
"provider": "unpkg",
"library": "<EMAIL_ADDRESS>"destination": "wwwroot/lib/ckeditor/ckeditor5-block-quote/",
"files": [
"build/block-quote.js",
"build/translations/ja.js"
]
}
]
}


[Bug] Currency Input Overlap Text

Description
Using CNY currency type overlaps with the text in an input
https://downloads.intercomcdn.com/i/o/384523291/a065f95e40447f9bf224463b/image.png?expires=1630655323&signature=796e0d43405d475daac3c1709bc3f002d5eac0bb2451cf57d692dd7ce4f67321

Currently, we are making use of Blueprintjs input component.
Their implementation is in such a way that the currency symbol (Left Icon) is of fixed width. If the symbol goes beyond a certain width, it overlaps the input text.
To make it flexible, we need to make use of CSS Flex. But if we are making use of flex, then we also need to modify the input box's properties (like the fucus and error UI state) to make it work like the way it works now. That needs a lot of effort.
The alternative way is to modify the design to look like that of Bootstrap's input component

Waiting for @momcilo-appsmith's opinion on this.


Enable live dpi toggling

This change makes it possible to enable/disable DPI scaling during runtime on
all platforms.

@sodiumjoe I'd be interested to hear what you think about this. I haven't tested it on MacOS but it should work. If anyone is able to test, that would be nice.
This should allow updating DPR at runtime and make it easier, do you think you can rebase on #1346 on top of this @sodiumjoe or will this method of updating the DPI scale not work with your implementation?

@chrisduerr

Here's a crappy screen recording I did to show what happens for me when running on macOS and toggling airplay casting AirPlay on/off (same effect as unplugging/plugging into an external monior with different DPI, in this case).
The first alacritty build is master, the 2nd is from this PR. No difference observed.

I'm not quite sure what I'm looking at here.

@chrisduerr At starting screen:

Top left is stable alacritty build
Bottom left is this PR build
Right is sublime text for an example of scale

When plugging into monitor:

Sublime text stays in scale (expected)
Alacritty stable build scales up (expected bug)
Alacritty PR build scales up (unexpected, this aimed to resolve)

Does that help? Sorry, the windows shift places so i makes it a little confusing.

The main goal of this PR is just to make it possible to enable/disable DPI scaling, the automatic scaling when moving a window across monitors is just a side-effect that works at least on x11.
I'm not very familiar with how things work on macos though, but have you tried out #1346?

My mistake! I started on this venture from that PR.

This PR has been merged together with #1403.


docs: provide a section aggregating per-language server reflection tu…

…torials
This allows users of any language to find documentation about server reflection. I chose this document as the place to put it because it has quite good SEO for the term "server reflection grpc".
This is WIP pending:

https://github.com/grpc/grpc/issues/16017
https://github.com/grpc/grpc/issues/16101

If we can get python and c# examples, I will update this PR with those links. Just wanted to get the PR out for initial review.

@hsaliak

CC @jtattermusch

The PR with C# server reflection tutorial is here: https://github.com/grpc/grpc/pull/16136/files

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,976,356      Total (=)      1,976,356

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,770,406      Total (>)     10,770,405

 No significant differences in binary sizes

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,976,610      Total (=)      1,976,610

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,771,527      Total (>)     10,771,521

 No significant differences in binary sizes

I'm happy merging in right now and adding python doc after the fact. Do y'all have a preference?


GEODE-7482: make DUnit launch correct product version

GEODE-7482
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[x] Does gradlew build run cleanly?

[x] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

waiting for distributed tests to pass just to make sure we don't see any new failures there


Update: translation

Codecov Report

Merging #530 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #530   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files         172    172
  Lines        1723   1723
=====================================
  Hits         1723   1723

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7568254...6d4d160. Read the comment docs.


Update juliacall_unfold.jl to include MNE Python warning

Added MNE Python warning to juliacall_unfold

@all-contributors please add @carmenamme for docs
Super cool! Thanks :)

@


Image does not load

Hello!
Thanks for the repository, it is amazing and will greatly help my project.
 With the following code:
urls.forEach(item => {
      userPics.push({
        source: {
          uri: item
        },
      })
    })

However, when I open the image, the screen goes black.
I really don't know why, maybe the error is quite simple and I didn't detect it.
Ps: When I use the example codes, ie with a previously declared vector, it works perfectly.

Hi @GabrielNexT, thanks for using the package.
First, could you please share a complete code sample via https://gist.github.com/
Second, I would recommend to try https://github.com/jobtoday/react-native-image-viewing as an improved and optimised version of this package

Ok, I will start using the new version.
Gist


How is istio-peer-exchange ALPNgenerated?

I find that the ALPN sent by the client sidecar is istio-HTTP /1.1, istio, and http/1.1, but not istio-peer-exchange.As shown in the picture below:

I found that the cluster is configured with alpnProtocols. What is the use of alpnProtocols?As shown in the picture below:

In what scenarios is an istio-peer-exchange ALPN sent?
I hope you can help me. Thank you

It is a customized application protocol, which is hard coded in istio code

pilot/pkg/networking/core/v1alpha3/listener.go#L95
	mtlsTCPWithMxcALPNs = []string{"istio-peer-exchange", "istio"}


replicationProviderName_s for physical or VMware servers seems to be InMageRcm and not InMageAzureV2

Hi,
was trying to create some queries for Azure Site Recovery for a on-prem VMWare environment.
As in the docs is mentioned that for on-prem devices the replicationProviderName_s should be InMageAzureV2 I was not getting any data.
Analyzing the replicationProviderName_s  table it seems that the correct name should be "InMageRcm".
At least I'm now getting valid data from the log analytics workspace.
Can you confirm / update this?
Thanks
Regards,
Ben
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ff08de1c-1661-5523-0f1a-eca1fd34c3e9
Version Independent ID: 64502dfc-db1c-ad5e-fa61-02e0163f85f6
Content: Monitor Azure Site Recovery with Azure Monitor Logs - Azure Site Recovery
Content Source: articles/site-recovery/monitor-log-analytics.md
Service: site-recovery
GitHub Login: @ankitaduttaMSFT
Microsoft Alias: ankitadutta

@Bennzn I can confirm that your observation is correct. We will have to update the documentation and that will be done by next week.
Thanks once again for your contribution to the documentation.

hi @Bennzn, doc has been updated, will be live shortly.
#please-close


Compiles for c++17; Not for the valid version of Maya

Maya 2018 gcc compiler is gcc-4.8.2 and g++-4.8.2; C++17 not yet supported.

Yikes. That's an old GCC.

Closing this since we can't get the Linux version working yet, we're now focussing on exporting animation instead. Furthermore this pull request should get a dedicated branch.


enh: Add .rows(named=False) support for pyarrow

I'm in the camp of slow support is better than no support.
If there ever comes a time that pyarrow supports retrieving row values more natively, then this code can be updated.
What type of PR is this? (check all applicable)

[ ] 💾 Refactor
[ ] ✨ Feature
[x] 🐛 Bug Fix
[ ] 🔧 Optimization
[ ] 📝 Documentation
[ ] ✅ Test
[ ] 🐳 Other

Related issues

Related issue # NA
Closes # NA

Checklist

[x] Code follows style guide (ruff)
[ ] Tests added
[ ] Documented the changes

If you have comments or can explain your changes, please do so below.
posit-dev/py-shiny uses .rows(named=False) to retrieve the values

@FBruzzesi Fixed 😄
Narwhal's testing, pre-commit, and uv integration is quite amazing 🤩 . Some day py-shiny will be have its testing infrastructure heavily from narwhals. 🥳

thanks both! i'm just at a company retreat but i'll try to merge / release tomorrow


Fix the way we retrieve the transform for the sensors

This allows to export a sensor with a frame not specified in exportedFrames. It fixes #77.

Neat! LGTM.

Before merging I need to address the case in which the frame is exported with an additionalTransformation

@mfussi66 I added the handling of the additionalTransformation, the two functions for getting the transformation of the sensor and ftsensor are very similar, we can think to a refactoring to Sensorizer in the future:

#80

@mfussi66 I added the handling of the additionalTransformation, the two functions for getting the transformation of the sensor and ftsensor are very similar, we can think to a refactoring to Sensorizer in the future:
* [CREO2URDF – Refactor Sensorizer class #80](https://github.com/icub-tech-iit/creo2urdf/issues/80)

Makes sense, maybe even review the YAML schema so it is more similar between sensors?

This fix has been validated 🎉

https://github.com/icub-tech-iit/ergocub-software/pull/222#issuecomment-1970904483

Merging


Create a test PR

[x] Fork this repository
[x] Clone on a local computer
[x] Create a directory 'testDir'.
[ ] Create a file 'testFile' inside 'testDir'
[ ] git add, git commit and git push
[ ] Create a pull request from the commit

I cloned the the repository but the app is not working


Support offline mode for NSRR records

Once NSRR records are downloaded locally, there should be no need having to log in to sleepdata.org. This is currently the case, and this can be problematic if the website is down.

I know that the readers already support offline=True, but I meant some automatic settings like e.g. offline="auto" (which could be the default?), which would only download in case the requested files are not available locally. But I'm not sure if this is really necessary.


Request hit localhost after deploy to production

When I deploy this project in production, the API keeps hitting localhost, even my strapi is deployed in a real domain with HTTPS.
Is there any environment variable for this?
I couldn't find it

Update: After finding on internet, I figured out that we need to build out app.
I was abit confused with the NODE_ENV=production, thought it's for production already, but no, it just builds the app in production mode.
So after run this image, we need to add our own Dockerfile, I take it from Strapi Prod sample Dockerfile. Then we build our own image and run it.


Fix #500: Framework INFO to TRACE messages

Fix #500: Framework INFO to TRACE messages

OK good idea updated!


Clarify time zone of "Maintenance start hour"

The documentation says "local start time", but what is "local" here? Local to the currently logged in user's device, local to the time zone of the region, local to the time zone of the server? This is unclear.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b5fc1e80-5a56-3850-cb63-7c882950c4e6
Version Independent ID: ee5da592-4c95-f38d-6f9f-7787fff9ff70
Content: Automated Patching for SQL Server VMs (Resource Manager) - SQL Server on Azure VM
Content Source: articles/azure-sql/virtual-machines/windows/automated-patching.md
Service: virtual-machines-sql
GitHub Login: @MashaMSFT
Microsoft Alias: mathoma

@tastyeggs Thanks for the feedback! We are currently investigating and will update you shortly.

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Hi @tastyeggs , thanks for contacting Microsoft! Local time refers to the local time of the OS/server where the IaaS extension is installed.
I hope that helps and please let us know if you have any further questions. I'm going to close out this Git Issue, but please feel free to comment should you need anything else.
Thanks and have a great rest of your day!
Masha from the SQL Docs team
#please-close


esprima-next -> fork for development and npm package

As I get no answers to my questions here, for example #2078
Nothing really happens (okay, some pulls are merged, but no npm package created)
I've started a fork at:
https://github.com/node-projects/esprima-next
Who want's to join? Question to you (or others)
@jginsburgn @ljqx @eryue0220 @luiscubal @Avuxo
I've merged all pulls, changed default to esm module (think most would use this today), updated all npm packages,
disabled the not workin style&coverage checks atm.
I think we should also look at fork of https://github.com/Contrast-Security-Inc/esprima
They seem to have many fixes not in esprima yet (see: https://github.com/jquery/esprima/compare/main...Contrast-Security-Inc:master)

For anyone who wants to join: https://github.com/node-projects/esprima-next/discussions/2


[feat] add support for serde

Scenario: One may want to deserialize into a HashMap<String, String> from, say, a config file containing a map with arbitrary keys. There's a config-rs crate for this, but due to https://github.com/mehcode/config-rs/issues/531, the deserialized keys are always converted to lowercase. The consequence is catastrophic: for a Map<user_id, priority> where user_id might contain upper cased letters, anyone forgetting to add a .to_ascii_lowercase() will find None from the hash map.
Many crates also have a special serde feature for serialize/deserialize using serde_json or other similar libraries built upon the serde crate. So maybe we should add this feature into unicase as well.

Sorry, didn't notice that there's already #41. Will close this dup PR.


[Reveal] Modal not working

How can we reproduce this bug?

Copy / paste the code found in the docs
Click on the "Click me for a modal"
Nothing happens

What did you expect to happen?
Opens a modal
What happened instead?
Nothing
Test case

Where is the modal code itself located (i.e. the one with the ID of reveal)?

I tried it in a new file (clean file) and still nothing...I tried to comment everything so I left the code for the modal only, but still, nothing.

And you're using 6.0.5?

Yes, and I did that, but still nothing. :\ ...I think I'm going to use a jQuery plugin ...

 If so, do you get any console errors?

Did you try the non minimized foundation file?

Yes, I had the $(document).foundation(); on it... the fix, simply: i tried the non minimized file :S and now is working, but the minimized is bugged (on chrome only, in firefox works), at least, for me.

@asfo there has been ongoing disparity between minified and non-minified since the release. It's worth noting those issues continue to creep.


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v5.13.3",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=ad365e9351ac2b450e7e79932ff6abf59342d91a"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "ad365e9351ac2b450e7e79932ff6abf59342d91a",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "dm btree remove: assign new_root only when removal succeeds\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.13.3 by commit ad365e9351ac2b450e7e79932ff6abf59342d91a. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001215


Make the output of git merge -s resolve deterministic

Let me know if this doesn't work for you.

@benedikt-schesch This is likely mergeable; the CI failures seem to be due to problems in the v2-update branch.


Revise 2.16 for clarity. Fixes #102.

Preview | Diff

This looks great to me.  Other relevant examples here might be referrer policy, or cookies, where on some platforms sites can relax (or remove) privacy protections recently achieved with stronger defaults.
I don't mean to clutter the document or belabor a point though.  If you think more text / the above examples would be helpful, im happy to add to yr PR.  Otherwise, whats there also looks great!

This looks great to me.  Other relevant examples here might be referrer policy, or cookies, where on some platforms sites can relax (or remove) privacy protections recently achieved with stronger defaults.
I don't mean to clutter the document or belabor a point though.  If you think more text / the above examples would be helpful, im happy to add to yr PR.  Otherwise, whats there also looks great!

This looks great to me. Other relevant examples here might be referrer policy, or cookies, where on some platforms sites can relax (or remove) privacy protections recently achieved with stronger defaults.
I don't mean to clutter the document or belabor a point though. If you think more text / the above examples would be helpful, im happy to add to yr PR. Otherwise, whats there also looks great!

I think it would be helpful to add more examples, though perhaps that's best done in a followup PR.


Fix bug #289

Effectively handle loaders serialized as { "0": "b", "1": "a", "2": "r", ... }.

Is there anything I can do with this PR to get it merged?

I can confirm that this fixes #289 for me.


tests: Fix error for when a VM is unable to deploy

Fixes the failing invalid_resource_test to a more consistent error message

Codecov Report
Base: 34.04% // Head: 34.04% // No change to project coverage :thumbsup:

Coverage data is based on head (19d08d9) compared to base (c00943a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage   34.04%   34.04%
=======================================
  Files          43       43
  Lines        3892     3892
=======================================
  Hits         1325     1325
  Misses       2387     2387
  Partials      180      180

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Test Results : (tid-42)
Environment: kvm(x3), Advanced Networking with Management Server Centos 7
Kubernetes Version v1.23.3
E2E Test Run Logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/capc-e2e-artifacts-42.zip

Ran 26 of 0 Specs in 0.529 seconds
FAIL! -- 0 Passed | 26 Failed | 0 Pending | 0 Skipped
--- FAIL: TestE2E (0.54s)
FAIL

Test Results : (tid-43)
Environment: kvm(x3), Advanced Networking with Management Server Centos 7
Kubernetes Version v1.23.3
E2E Test Run Logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/capc-e2e-artifacts-43.zip
[PASS] When testing horizontal scale out/in [TC17][TC18][TC20][TC21] Should successfully scale machine replicas up and down horizontally
[PASS] When testing affinity group Should have host affinity group when affinity is anti
[PASS] When testing node drain timeout A node should be forcefully removed if it cannot be drained in time
[PASS] When testing subdomain Should create a cluster in a subdomain
[PASS] When the specified resource does not exist Should fail due to the specified account is not found [TC4a]
[PASS] When the specified resource does not exist Should fail due to the specified domain is not found [TC4b]
[PASS] When the specified resource does not exist Should fail due to the specified control plane offering is not found [TC7]
[PASS] When the specified resource does not exist Should fail due to the specified template is not found [TC6]
[PASS] When the specified resource does not exist Should fail due to the specified zone is not found [TC3]
[PASS] When the specified resource does not exist Should fail due to the specified disk offering is not found
[PASS] When the specified resource does not exist Should fail due to the compute resources are not sufficient for the specified offering [TC8]
[PASS] When the specified resource does not exist Should fail due to the specified disk offer is not customized but the disk size is specified
[PASS] When the specified resource does not exist Should fail due to the specified disk offer is customized but the disk size is not specified
[PASS] When the specified resource does not exist Should fail due to the public IP can not be found
[PASS] When the specified resource does not exist When starting with a healthy cluster Should fail to upgrade worker machine due to insufficient compute resources
[PASS] When the specified resource does not exist When starting with a healthy cluster Should fail to upgrade control plane machine due to insufficient compute resources
[PASS] When testing MachineDeployment rolling upgrades Should successfully upgrade Machines upon changes in relevant MachineDeployment fields
[PASS] When testing with custom disk offering Should successfully create a cluster with a custom disk offering
[PASS] When testing machine remediation Should replace a machine when it is destroyed
[PASS] When testing Kubernetes version upgrades Should successfully upgrade kubernetes versions when there is a change in relevant fields
[PASS] When testing with disk offering Should successfully create a cluster with disk offering
[PASS] with two clusters should successfully add and remove a second cluster without breaking the first cluster

Summarizing 4 Failures:

[Fail] When testing app deployment to the workload cluster with slow network [ToxiProxy] [It] Should be able to download an HTML from the app deployed to the workload cluster
/jenkins/workspace/capc-e2e/test/e2e/deploy_app_toxi.go:128

[Fail] When testing app deployment to the workload cluster [TC1][PR-Blocking] [It] Should be able to download an HTML from the app deployed to the workload cluster
/jenkins/workspace/capc-e2e/test/e2e/deploy_app.go:109

[Fail] When testing affinity group [It] Should have host affinity group when affinity is pro
/root/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.2.7/framework/controlplane_helpers.go:116

[Fail] When testing resource cleanup [BeforeEach] Should create a new network when the specified network does not exist
/jenkins/workspace/capc-e2e/test/e2e/resource_cleanup.go:62

Ran 26 of 26 Specs in 13990.783 seconds
FAIL! -- 22 Passed | 4 Failed | 0 Pending | 0 Skipped
--- FAIL: TestE2E (13990.80s)
FAIL

/lgtm
/approve


Update README to include descending parameter for /api/v1/read/ endpoint

Description
I recently raised an issue https://github.com/cloudfoundry/log-cache-release/issues/544 asking the README.md file be updated to include the descending parameter for the /api/v1/read/ endpoint. In response, @chombium suggested that I could add the parameter myself if I wanted to. So, I have created this pull request to make the necessary changes.
Type of change
Documentation update

LGTM! @anetaivanova-pesheva can you please sign the CLA so that we can approve and merge this PR :)

@ctlong I will take care of the CLA


Font types

Fonts.com has a nice article about font type classifications. There are 4 categories with 17 sub-categories, which only some of them are used in license plates. So the types you may consider are can be these below.
Serif Type Styles: Slab Serif.
Sans Serif Type Styles: All four of them.
Script Type Styles: None.
Decorative: None.
So there are 5 types of fonts to keep in mind. You may consider searching all the states about which is a more specific method. Or, you may consider training the AI with at least 5 types of each 5 classes mentioned above, which is simpler and universial hack.
I tihnk this might be a simple (but not exact) solution for the 2nd drawback in your conclusion.

It shouldn't be too hard to implement this:  I'm imagining we'd have a fonts/ folder, and then gen.py would just load all fonts into an array and randomly select one at generation time.
There is one possible complication that I can see:  The current code has very basic kerning:  Each character is individually rendered into its own image ahead of time, and then these images are then tiled horizontally.  This scheme works well enough for the UK number plate font, but it might not work so well for other fonts.  A better solution might be to directly render the full license for each image with PIL.ImageDraw.text().

I've had some success with using the following set of fonts:

Slab serif:

Arvo
BioRhyme
BioRhyme Extended
Bitstream Vera Serif
Bodonitown
Kreon

Sans serif:

Aaargh
Aller
Amble
Arimo
Bitstream Vera
Capsuula
Cicle
Comme
Courier Prime Sans
Norwester
Open Sans

The fonts were chosen somewhat arbitrarily from the Font Squirrel lists of slab serif and sans serif fonts.
With these fonts the system seems able to read UK number plates (even though the UK number plate font wasn't provided).  This means it is able to generalize to other fonts, and may be able to read non-UK number plates, however #6 will need fixing before this is possible.

Hello @matthewearl, great project walk  through, I've been tinkering with the code for assembly line product number detection, I changed the font type, changes the generated sequences in gen.py eveything ran Ok but i keep getting this error when running the train.py script, any idea what could be the problem?
Traceback (most recent call last):   File "./train.py", line 266, in <module>     initial_weights=initial_weights)   File "./train.py", line 174, in train     digits_loss, presence_loss, loss = get_loss(y, y_)   File "./train.py", line 132, in get_loss     [-1, len(common.CHARS)]))   File "/home/tmalete/tensorflow/local/lib/python2.7/site-packages/tensorflow/python/ops/nn_ops.py", line 1555, in softmax_cross_entropy_with_logits     labels, logits)   File "/home/tmalete/tensorflow/local/lib/python2.7/site-packages/tensorflow/python/ops/nn_ops.py", line 1510, in _ensure_xent_args     "named arguments (labels=..., logits=..., ...)" % name) ValueError: Only call softmax_cross_entropy_with_logitswith named arguments (labels=..., logits=..., ...)


runtime config "re2.max_program_size.error_level" doesn't apply to "stats_matcher"

Title:  runtime flag "re2.max_program_size.error_level" doesn't apply to stats_matcher config
Description:
I have this simple envoy config
{
  "admin": {
    "access_log_path": "/dev/null",
    "address": {
      "socket_address": {
        "address": "<IP_ADDRESS>",
        "port_value": 8001
      }
    }
  },
  "layered_runtime": {
    "layers": [
      {
        "name": "static-runtime",
        "static_layer": {
          "re2.max_program_size.error_level": 1000
        }
      }
    ]
  },
  "stats_config": {
    "stats_matcher": {
      "inclusion_list": {
        "patterns": [
          {
            "safe_regex": {
              "google_re2": {},
              "regex": "cluster.(metadata-cluster|iam-cluster|service-control-cluster|backend-cluster-sample-backend-s3fctubhaq-uc.a.run.app_443).upstream_rq_(reset|timeout|[1-5]xx)"
            }
          }
        ]
      }
    }
  }
}

Envoy failed to load it with following error:
2022-04-27 12:21:28.927][1601282][critical][main] [external/envoy/source/server/server.cc:117] error initializing configuration '/tmp/envoy333.json': regex 'cluster.(metadata-cluster|iam-cluster|service-control-cluster|backend-cluster-sample-backend-s3fctubhaq-uc.a.run.app_443).upstream_rq_(reset|timeout|[1-5]xx)' RE2 program size of 187 > max program size of 100 set for the error level threshold. Increase configured max program size if necessary.
[2022-04-27 12:21:28.927][1601282][info][main] [external/envoy/source/server/server.cc:939] exiting
regex 'cluster.(metadata-cluster|iam-cluster|service-control-cluster|backend-cluster-sample-backend-s3fctubhaq-uc.a.run.app_443).upstream_rq_(reset|timeout|[1-5]xx)' RE2 program size of 187 > max program size of 100 set for the error level threshold. Increase configured max program size if necessary.

It seems that layered_runtime runtime is applied after stats_matcher.  so its flag of ""re2.max_program_size.error_level" to 1000 was not applied.
It happens with  top of tree,  release 1.22.0
But it did not happen with release 1.21.1
Repro steps:

was https://github.com/envoyproxy/envoy/pull/19972/files - it's always been the case that stats ran before runtime, and we simply ignored all size bounds for bootstrap before the change, and now apply default limits
that seems..... not great.
It's much easier to restore the prior behavior so I'm inclined to do that,and file an issue for proper handling later.  SG?

Well, I guess it is the old behaviors.  I guess it should be ok then.  SG

Ok, I fixed the part where we're applying the defaults before runtime is loaded, but leaving the other part (actually loading runtime first, or re-running checks) as help wanted


check fails with admin permissions

Steps to reproduce
The has_guild_permissions check is not passing when the command invoker has admin permissions
@has_guild_permissions(hikari.Permissions.MANAGE_NICKNAMES)
@command()
async def command(ctx) -> None:
    pass

Invoke the command with admin permissions
Expected Result
Check should have passed
Actual Result
Check fails and raises MissingRequiredPermission
System info
Most recent lightbulb dev version
Checklist

[x] I have made sure to remove ANY sensitive information (bot token, passwords,
credentials, personal details, etc).
[x] I have searched the issue tracker and have made sure it's not a duplicate.
If it is a follow up of another issue, I have specified it.

Same thing with bot_has_guild_permissions

Same thing with bot_has_guild_permissions


PHP 8.1 support

WIP: this is untested
Attempt to resolve issues that are causing Suma to fail with PHP 8.x. See the mailing list for examples.

Update dependencies, particularly zf1-future and Gump.
Remove get_magic_quotes_gpc() calls
Fix phpcs complaints in our code
Rebuild project
Document how to use phpcs/PHPCompatibility

Hey @cazzerson, I made a docker version of Suma that's pegged to this branch if that would help you out.  I'm still working on the documentation for it, but I think everything's working with PHP 8.1 and MariaDb 10.5.9.  Note that the Suma code is running on a Debian based php8.1 image.
If you have any problems starting it up or working with it, please let me know!

@kbeswick we've deployed this to a PHP 8.1 server and everything seems to be working. OK to merge?

I ran this through a PHP scanner and also selected dependencies that still support PHP 7.1+. I think this can be a minor release, but it may be worth testing on one of your servers if you're still running PHP 7.x.

This branch works for me on PHP 7.4. I tested things like administering locations/initiatives, using the collection client, and the analysis tools, and they all work without any issues. I think this is good to merge and call a minor release.


Revise Analytics Tag

Our previous analytics was set up to point to "http://say-their-names.com" however since we will be on "http://saytheirnames.io/" we should use the following analytics tag.
<!-- Global site tag (gtag.js) - Google Analytics -->
<script async src="https://www.googletagmanager.com/gtag/js?id=G-0P757MTVT6"></script>
<script>
  window.dataLayer = window.dataLayer || [];
  function gtag(){dataLayer.push(arguments);}
  gtag('js', new Date());

  gtag('config', 'G-0P757MTVT6');
</script>

@cdemeke is this the official one, like created from the saytheirnames.io GA account?

So there were still some debates as to which analytics we would be using. There were concerns about privacy

So there were still some debates as to which analytics we would be using. There were concerns about privacy

I opened up and the floor for the people with concerns to provide an alternative, no one stepped up.

I'd originally created an analytics account using my personal Gmail account, do we have a saytheirnames gmail account? Happy to swap it out for that or create the gmail account if one doesn't exist.

cc: @devingray

nalytics account using my personal Gm

Yes, we have a gmail account

I have gotten the google tag id, what's just needed it to add it to the environment variables of the application. I'd do that

Up and running!


Pecan asynchronous cards

Closes #4369
Shows cards as they are ready except when the column type is date, in which case it waits for a number or a string to create a value/category-based torque map.
@javierarce

retest this please

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)


Linter status in status bar?

Effectively like Atom lint, it would be great to see either the number of errors, highlighted in red, or a green check mark in the status bar on the right hand side, giving me greater visibility in a static location.
As you can see there is an error, but I have to scroll to figure that out, or scroll the minimap to do so, I don't get a good scope of the file.
https://www.dropbox.com/s/k2o3s94xabpgnua/Screenshot 2014-10-30 12.05.26.png?dl=0

Fixed by #277. Will be in the next release.


Some errors with icons

Hello,
Thanks for this nice package.
I am using emacs 28.0.50 feature/native-comp.
All was working well before I upgraded melpa packages.
Here is my config :
(helm-icons-enable)
;;(setq helm-icons-provider 'all-the-icons)

(use-package helm
  :init
  (setq helm-autoresize-max-height 20)
  (setq helm-buffer-max-length 40)
  :bind
  ("M-x" . helm-M-x)
  ("C-q" . helm-imenu)
  ("C-x C-f" . #'helm-find-files)
  ("C-x b" . #'helm-buffers-list)
  ("C-x r b" . #'helm-filtered-bookmarks)
  ("C-s" . #'swiper-helm)
  )

(require 'helm-config)
(helm-mode 1)

(define-key helm-map (kbd "<left>") 'helm-previous-source)
(define-key helm-map (kbd "<right>") 'helm-next-source)
(customize-set-variable 'helm-ff-lynx-style-map t)
(customize-set-variable 'helm-imenu-lynx-style-map t)

Each time I want to use helm commands I get the error message :
helm-icons--get-icon: Invalid function: treemacs-get-icon-value

and nothing shows up. although the treemacs config is loaded before helm config (as above).
If I decide to use all-the-icons, helm-buffers works again with icons but helm-find-files returns :
Wrong type argument: sequencep, dir-closed

If I decide to use all-the-icons, helm-buffers works again with icons but helm-find-files returns :

I have a PR to fix this ^^

If I decide to use all-the-icons, helm-buffers works again with icons but helm-find-files returns :

I have a PR to fix this ^^

should be fixed with https://github.com/yyoncho/helm-icons/pull/13

should be fixed with https://github.com/yyoncho/helm-icons/pull/13

There's another problem with treemacs still, I will fix later 😁

There's another problem with treemacs still, I will fix later 😁

Thanks !
A few clarifications,  the treemacs-get-icon-file bug appears both on linux and windows (10) with emacs 28.0.50 branch. It does not happen with latest emacs 27.1 compiled source. So, it is probably a compatibility issue.
Regards

Thanks !
A few clarifications,  the treemacs-get-icon-file bug appears both on linux and windows (10) with emacs 28.0.50 branch. It does not happen with latest emacs 27.1 compiled source. So, it is probably a compatibility issue.
Regards

Thanks for the feedback, that's a weird one. I will look into it regardless.
For now, the all-the-icons stuff should be fine now, do let me know 😁

Thanks for the feedback, that's a weird one. I will look into it regardless.
For now, the all-the-icons stuff should be fine now, do let me know 😁

@deb75 I have another PR, if you could test it and let me know if this resolves it for you :D

@deb75 I have another PR, if you could test it and let me know if this resolves it for you :D

@elken I have just upgraded the package helm-icons, probably your other PR is not yet in it.
helm-find-files does work again ! However, I noticed that helm-buffers works but not with the right icon for the right file. As an example, if I open a *.java file with helm-find-files I get the so called java icon. Then, if I list buffers with helm-buffers, it is no more the aformentioned java icon, it looks like the default icon.
That is to note also I configured treemacs to use all-the-icons` :
(require 'treemacs-all-the-icons)
(treemacs-load-theme "all-the-icons")

and icons displayed are often not the same as helm-buffers and helm-find-files .

@elken I have just upgraded the package helm-icons, probably your other PR is not yet in it.
helm-find-files does work again ! However, I noticed that helm-buffers works but not with the right icon for the right file. As an example, if I open a *.java file with helm-find-files I get the so called java icon. Then, if I list buffers with helm-buffers, it is no more the aformentioned java icon, it looks like the default icon.
That is to note also I configured treemacs to use all-the-icons` :
(require 'treemacs-all-the-icons)
(treemacs-load-theme "all-the-icons")

and icons displayed are often not the same as helm-buffers and helm-find-files .

I haven't tested with that package, seems like a roundabout way. Which provider works then?

I haven't tested with that package, seems like a roundabout way. Which provider works then?

I have just tested your pull request. I did it by hand and provided no errors from me, I still get Invalid function : treemacs-get-icon-value.
I googled this error, it seems be due to the fact that treemacs-get-icon-file is a macro, not a real function. So, probably that it does not play well with native compilation (gccemacs)
For now, all-the-icons works but with some caveats (not the right icons).
Regards

I have just tested your pull request. I did it by hand and provided no errors from me, I still get Invalid function : treemacs-get-icon-value.
I googled this error, it seems be due to the fact that treemacs-get-icon-file is a macro, not a real function. So, probably that it does not play well with native compilation (gccemacs)
For now, all-the-icons works but with some caveats (not the right icons).
Regards

I'm running on 28,  currently HEAD so I'm having difficulty replicating this on my end

I'm running on 28,  currently HEAD so I'm having difficulty replicating this on my end

Do you mean the treemacs-get-icon-file issue or that some icons are not displayed in helm-buffers with all-the-icons ?
My branch is not HEAD, will try with HEAD.

Do you mean the treemacs-get-icon-file issue or that some icons are not displayed in helm-buffers with all-the-icons ?
My branch is not HEAD, will try with HEAD.

I still get the treemacs-get-icons-file issue with latest emacs 280.0.50 (feature/native-comp) and latest melpa packages.
Also, I pay attention to load  treemacs configuration before helm one. The curious thing is that treemacs works flawlessly with all-the-icons, I should also get the same issue with treemacs, shouldn't I ?

I still get the treemacs-get-icons-file issue with latest emacs 280.0.50 (feature/native-comp) and latest melpa packages.
Also, I pay attention to load  treemacs configuration before helm one. The curious thing is that treemacs works flawlessly with all-the-icons, I should also get the same issue with treemacs, shouldn't I ?

Still not able to replicate this. If you can consistently replicate it on as vanilla an emacs as you can and put the steps here I will see if I can fix it.

Still not able to replicate this. If you can consistently replicate it on as vanilla an emacs as you can and put the steps here I will see if I can fix it.

if at all useful, I am also getting Invalid function : treemacs-get-icon-value on emacs 27.1 after upgrading all packages.


added new env vars - REZ_SHELL_INIT_TIMESTAMP, REZ_SHELL_INTERACTIVE

Closes #833

the variables are being generated correctly, at the very least
(whether that solves the reason we went down this road, I can't be totally sure yet, as we discussed, but the PR does no harm at the worst, so I think this is fine to merge if desired)


Add the ability for backends to add entries to the trace

The API is tested by being used in the frontends.

What's the state of this PR @Tabrizian ? Do we intend to finalize it at some point? I think a new backend API like this could enable a cleaner way to report  nested spans (create traces) for OpenTelemetry tracing closer to the site, rather than the current behavior of reporting everything all at the end in the TRITONBACKEND_ReportStatistics callback. CC @oandreeva-nv

@rmccorm4 Sorry for the delay. This must have fallen through the cracks. Yeah, I think we probably want to have this API at some point for creating custom traces. Right now I think this is just blocked on testing.


Icons missing from Source Control Changes bar

code-server version: 1.696-vsc1.33.0
OS Version: Debian GNU/Linux 9 \n \l (Docker container)

Description
On the Source Control view, the Changes bar is missing icons.  If I mouse over the bar, I see the hint text appear where the icons should be.  As far as I can tell, similar bars within other views are showing icons.

Can you show a screenshot? It might be your cache so try a hard reload with empty cache (Ctrl + Shift + R in Chrome)

The hard reload fixed it.  Thanks.


Support running from non-standard HOME directory

I wanted to try this config without moving my current .emacs.d directory, so I cloned into a different directory and launched with that directory as my HOME:
HOME=/home/tsanders/doom emacs

This caused the following error:
File error: Cannot open load file, Not a directory, core-lib

After looking into it some more, I think the paths are (partially?) expanded as part of the make compile process, so my load-path would contain ~/doom/.emacs.d/core, which expands to /home/tsanders/doom/doom/.emacs.d/core instead of /home/tsanders/doom/.emacs.d/core, etc..
Compiling with the alternate HOME seems to fix the issue:
HOME=/home/tsanders/doom make compile

However, this patch is another fix I have tried that appears to work for me regardless of the compile environment: If we expand HOME the first time the base path is set, all downstream references should use the correct path.
(I'm not super familiar with this project, the elisp byte compile process, or the implications that this change might have, so please test and make sure this doesn't break anything.  :) )

Yeah, that's a good solution. Nice work!


Switch to using more expressive layout descriptors instead of numeric layout names

This is a relatively big PR but most changes are cosmetic. Feel free to review a sub-set of files/changes.

review is WIP. I will try to review everything soon.


fix OHEM with cascade rcnn

Thanks! It is also interesting to know whether there is any difference for the final performance when using OHEM, can you share some results?

Thanks! It is also interesting to know whether there is any difference for the final performance when using OHEM, can you share some results?

@hellock Hi, I tested the performance before and after using cascade rcnn ohem.  Results are as follows：
Without OHEM：

With OHEM：

Performance has improved！

Thanks for the report! I have a question that the mAP without OHEM seems much lower than the model zoo (42.1 for R-101). Is your setting different from the official config file?

Thanks for the report! I have a question that the mAP without OHEM seems much lower than the model zoo (42.1 for R-101). Is your setting different from the official config file?

I change imgs_per_gpu to 4, and trian on 3 GPUs. I don't know if this will harm the performance.

We tested OHEM on Cascade R-CNN with R-50. The results looks reasonable.

w/o OHEM (baseline): 40.3
w/ OHEM: 40.6

We tested OHEM on Cascade R-CNN with R-50. The results looks reasonable.

w/o OHEM (baseline): 40.3
w/ OHEM: 40.6
Thanks! The performance of the two is similar, it seems that there is no need to use OHEM. ：)

I think supporting OHEM is nice. Applying OHEM to Faster R-CNN brings only a gain of 0.4 to 0.6, so 0.3 for Cascade R-CNN is reasonable. You can reopen the PR with some fixes.

I think supporting OHEM is nice. Applying OHEM to Faster R-CNN brings only a gain of 0.4 to 0.6, so 0.3 for Cascade R-CNN is reasonable. You can reopen the PR with some fixes.

:+1: Ok, I will reopen the PR with some fixes.

Hi, I resubmitted the PR according to your request. Check it, please!

It looks good to me.
The permission of compile.sh and dist_train.sh is changed from 755 to 644, could you recover it?

Ok, I will fix it.


Provide a Dockerfile and host it inside the github registry

What feature would you like seen in Chunker?
It would be nice to have container images for the Chunker CLI and Web Application. These could be hosted in the github registry, ensuring that not everybody needs to build the images on their own.
Edit: As I just saw it now, that the web application has been marked as legacy and has been replaced by the Java Application, but it would still be great to have the ability to run the Chunker CLI inside containers for automated world conversion.
However the wider user base would not profit of that, as not many need a service to convert java edition worlds automatically to bedrock edition.

Docker don't work like this. You can expose ports from the docker for external usage. Using Docker to exposing CLI is not possible.
As you said first, if it was a web service theire will be no problem to do this but as the app is now all in java runnable app you cannot longer do this.


Missing Focus Indicators

When users are tabbing across the map interface, some of the tab stops don't have a visual indicator of the tab focus.  When a user tabs so that the map is in focus, nothing shows that the map is in focus, and users might not be aware that when the map is in focus a user can use their keyboard arrows and '-' and '+' signs to navigate the map.
Is it possible to add a default small popup indicator which appears on the bottom or side of the map which notifies users when the map has focus, and possibly also add text alerting them they can use keyboard navigation, and have the indicator only show when users have tabbed to the map, or set the map in focus.

You can add the focus yourself with CSS with #map:focus selector, both an outline and some block of text.

I have done the :focus effect, and a :active effect to highlight the map, and I have a custom div which i have hard coded for several maps which shows up when the map has focus but I think it would be useful to have a default indicator or icon show up which lets users know when they can navigate the map via keyboard. This default icon could be of a keyboard or keyboard arrows and would only show up in a corner of the map when the map has focus or when it can be navigated with the keyboard.
I will make a small pull request to show you my thoughts on this issue.

I don't think it's a good idea to add such styling on the core leaflet. Among other things, it would create inconsistency across browsers (firefox adds a dotted outline; webkit uses a blue blurred border; firefox on android uses orange; internet explorer adds god-knows-what). On top of that, users of assistive technologies will add some custom styling to focusable/focused elements.
Sounds like an idea to split into a plugin, though.


Fix a gcc warning with -Wparentheses

suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]

Thanks Sylvestre !


Automator: update<EMAIL_ADDRESS>dependency in<EMAIL_ADDRESS>

Generated by Automator - 2022-09-01T20:12:01+00:00

Rerunning job to fix conflict.


ModuleNotFoundError: no module named 'lollms'

After I run win_install. I had error like this. I set up v6.7

Same issue found

Hi, are you sure the tool was installed?
At the beginning, the script installs miniconda, then installs the main lollms webui and then its dependencies and finally it pulls my zoos and other optional apps.
If you read documentation, the folder wher eyou install lollms should not contain a space in its path or this won't install miniconda (the source of this constraint) and thus nothins is really installed.
This looks like the tool wasn't installed correctly. Verify and try reinstalling it.

Having the same issue, reinstalling did nothing... Any other tips? Not sure how to install lollms independently.

Did you use the updated version of the installer?
If you used the old one, it had an issue and wasn't installing the right tools. So basically only the webui was installed and not the lollms_core library.
Try downloading the last installer and it should fix this.
best regards

The install script says something about not a git directory, I'm pretty sure it is because of the lollms_core submodule. Trying to navigate to it gives a 404 error


Countdown thank you page

What is the context of this PR?
Add countdown on thank you page to view/download survey answers
Also:

Fixes a few typos
Updates to the latest version of the DS
Updates to Chromedriver v99

How to review  - Post DS changes merge
With Javascript enable

Load design system changes ( new component timeout-panel )
Launch test_view_submitted_response or test_thank_you survey
Submit Answer , A countdown timer of 45 minutes should start counting down.
Respondent should be able to view/download answer during the countdown period
update VIEW_SUBMITTED_RESPONSE_EXPIRATION_IN_SECONDS=120(restart runner) and repeat step 1 and 2 , 2 minutes countdown timer should start counting down
Wait for timer to run out and observe the page refreshes and user  doesn't have option of download or view answers

With Javascript disabled

Launch test_view_submitted_response or test_thank_you survey
Disable JS from chrome dev settings
submit answers
Observe there is no countdown timer, the message is static

Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

Looks good, some minor stuff. You also said this updates chromedriver to 99, but I can't see that

We did update to 99 but I think another PR must've merged into master that did the same, so now it looks like our PR didn't. Ill remove it from the description


Disable connection reuse only for proxy clients not for the admin client

We are using WireMock for our integration tests. In one of our projects the test suite does ~ 29000 requests to the WireMock for stubbing, verifying, resetting ... requests. With the current implementation for each and every request a new TCP connection is created. This causes a lot of useless overhead. On powerful systems the test suite takes just 1 minute and a few seconds and it looks like we now reached a limit where some kind of ratelimiting (haven't yet found the reason for) on the network layer blocks the creation of new TCP connections to the WireMock. If I enable the connection reuse everything works as expected.
I just had a look through the history and it looks like disabling the connection reuse was introduced due to a bug that occurs when the WireMock server is running in proxy mode. Therefore this feature should only be disabled in these cases. (Btw. I don't think it's a good idea to mix-up the configuration of clients that are used for completely different use cases.)
To provide a test for this a added a small dummy server that just accepts a single connection. If you disable the connection reuse feature you will see it failing.
References

#1389

Submitter checklist

[ ] Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
[x] The PR request is well described and justified, including the body and the references
[x] The PR title represents the desired changelog entry
[x] The repository's code style is followed (see the contributing guide)
[x] Test coverage that demonstrates that the change works as expected
[ ] For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

Thanks!


Idea: Show indent level visually in editor

Hey @sebmeister2077 I had an idea and thats why I added the class mentioned in my PR #2 however I wasnt sure of the best way to go about it.
Showing a visual indicator in the UI for the ident. I assume doing a calculation from the far left side to the start of the div that wraps the content? See image below in yellow. A lot of nesting going on there so wasnt sure of the best way.
Thoughts?

I like the idea. Would be cool if we also have support for the amount of indent there is on a block for styling, and we need to take into consideration if the user has also an alignment tune in his editor. 😄
I'd suggest we/you create a separate PR for this feature. I will work on it around 6-7 hours from now after work if you didnt have time till then

I've done some investigating, and we dont need to calculate anything since we already know how much indent is applied (in pixels), only thing i dont know yet is if i should use a separate html element or if i should use .ce-block__content::before

@sebmeister2077 thanks for digging into that and so far looks good to me

@sebmeister2077  Used latest version in production and everything worked great! Thanks!


Payload value must not be empty for Acknowledgment parameter

**Affects Version(s):2.6.5

Copying from https://github.com/spring-projects/spring-framework/issues/26389 since it seems this is right place for it.
I have a @KafkaListener with this signature:
    @KafkaListener(topics = "${matcher.reply.channel:matcher_response${matcher.kafka.topic.suffix}}")
    public void processMessage(@Payload ConsumerRecord<String, String> record, Acknowledgment acknowledgment) {

When I receive a message I get an exception that Payload value must not be empty about the acknowledgment parameter:
[org.springframework.kafka.KafkaListenerEndpointContainer#0-0-C-1] SeekToCurrentErrorHandler - Backoff none exhausted for ConsumerRecord(topic = multilateral_matcher_results, partition = 0, leaderEpoch = 0, offset = 2, CreateTime =<PHONE_NUMBER>545, serialized key size = -1, serialized value size = 76, headers = RecordHeaders(headers = [], isReadOnly = false), key = null, value = {"matchProcessId":"dc033ece-4e0e-4a60-86ce-7f8071678418","status":"SUCCESS"})
org.springframework.kafka.listener.ListenerExecutionFailedException: Listener method could not be invoked with the incoming message
Endpoint handler details:
Method [public void com.capitolis.matcher_client.kafka.consumer.MatcherReplyKafkaConsumer.processMessage(org.apache.kafka.clients.consumer.ConsumerRecord<java.lang.String, java.lang.String>,org.springframework.kafka.support.Acknowledgment)]
Bean [com.capitolis.matcher_client.kafka.consumer.MatcherReplyKafkaConsumer@193f5509]; nested exception is org.springframework.messaging.handler.annotation.support.MethodArgumentNotValidException: Could not resolve method parameter at index 1 in public void com.capitolis.matcher_client.kafka.consumer.MatcherReplyKafkaConsumer.processMessage(org.apache.kafka.clients.consumer.ConsumerRecord<java.lang.String, java.lang.String>,org.springframework.kafka.support.Acknowledgment): 1 error(s): [Error in object 'acknowledgment': codes []; arguments []; default message [Payload value must not be empty]] , failedMessage=GenericMessage [payload=org.springframework.kafka.support.KafkaNull@437ffb4f, headers={id=99763706-5013-dcae-a45a-16485a65854e, timestamp=1610624118214}]; nested exception is org.springframework.messaging.handler.annotation.support.MethodArgumentNotValidException: Could not resolve method parameter at index 1 in public void com.capitolis.matcher_client.kafka.consumer.MatcherReplyKafkaConsumer.processMessage(org.apache.kafka.clients.consumer.ConsumerRecord<java.lang.String, java.lang.String>,org.springframework.kafka.support.Acknowledgment): 1 error(s): [Error in object 'acknowledgment': codes []; arguments []; default message [Payload value must not be empty]] , failedMessage=GenericMessage [payload=org.springframework.kafka.support.KafkaNull@437ffb4f, headers={id=99763706-5013-dcae-a45a-16485a65854e, timestamp=1610624118214}]

It seems that  the PayloadMethodArgumentResolver (or the KafkaNullAwarePayloadArgumentResolver that inherits from it) handles an argument that it shouldn't. I thought it might be a compatibility issue and aligned my dependencies with the matrix here:
https://spring.io/projects/spring-kafka
But that did not prevent the exception.
Removing the Acknowledgement argument worked around the problem for me but for some scenarios it may be required and can't be removed

The Acknowledgment argument is only available if the container AckMode property is MANUAL or MANUAL_IMMEDIATE. You cannot acknowledge records that are automatically acknowledged by the container, which is the default (and preferred) behavior.

The Acknowledgment argument is only available if the container AckMode property is MANUAL or MANUAL_IMMEDIATE. You cannot acknowledge records that are automatically acknowledged by the container, which is the default (and preferred) behavior.

Oh, I see; you want the original record as well as the Acknowledgment.
Remove the @Paylaod annotation; when you are getting the entire ConsumerRecord there is no payload conversion needed.

Oh, I see; you want the original record as well as the Acknowledgment.
Remove the @Paylaod annotation; when you are getting the entire ConsumerRecord there is no payload conversion needed.

This works fine for me with, or without, the @Payload annotation (which is not needed in this case).
Your problem must be the ack mode.
@SpringBootApplication
public class Gh1683Application {

	public static void main(String[] args) {
		SpringApplication.run(Gh1683Application.class, args);
	}

	@KafkaListener(id = "gh1683", topics = "gh1683")
	void listen(ConsumerRecord<String, String> cr, Acknowledgment ack) {
		System.out.println(cr);
		ack.acknowledge();
	}

	@Bean
	NewTopic topic() {
		return TopicBuilder.name("gh1683").build();
	}

	@Bean
	ApplicationRunner runner(KafkaTemplate<String, String> template) {
		return args -> template.send("gh1683", "foo");
	}

}

spring.kafka.consumer.auto-offset-reset=earliest
spring.kafka.listener.ack-mode=manual

This works fine for me with, or without, the @Payload annotation (which is not needed in this case).
Your problem must be the ack mode.
@SpringBootApplication
public class Gh1683Application {

	public static void main(String[] args) {
		SpringApplication.run(Gh1683Application.class, args);
	}

	@KafkaListener(id = "gh1683", topics = "gh1683")
	void listen(ConsumerRecord<String, String> cr, Acknowledgment ack) {
		System.out.println(cr);
		ack.acknowledge();
	}

	@Bean
	NewTopic topic() {
		return TopicBuilder.name("gh1683").build();
	}

	@Bean
	ApplicationRunner runner(KafkaTemplate<String, String> template) {
		return args -> template.send("gh1683", "foo");
	}

}

spring.kafka.consumer.auto-offset-reset=earliest
spring.kafka.listener.ack-mode=manual

@garyrussell
Thank you for your answer and the time you put into it.
When I set the acknowledgment to manual in the configuration the exception went away.
I suppose there is a way to do it for this specific listener and not all of them since this process has other KafakaListener that don't require manual acknowledgement.
It would be useful though if there is a way to make the exception more instructive. Maybe make the KafkaNullAwarePayloadArgumentResolver check if it is trying to resolve and Acknowledgement argument throw a different exception that suggests that the acknowledgement mode must be manual in order to use this argument.
Thanks again. This was really helpful for me

@garyrussell
Thank you for your answer and the time you put into it.
When I set the acknowledgment to manual in the configuration the exception went away.
I suppose there is a way to do it for this specific listener and not all of them since this process has other KafakaListener that don't require manual acknowledgement.
It would be useful though if there is a way to make the exception more instructive. Maybe make the KafkaNullAwarePayloadArgumentResolver check if it is trying to resolve and Acknowledgement argument throw a different exception that suggests that the acknowledgement mode must be manual in order to use this argument.
Thanks again. This was really helpful for me

@garyrussell
I added a PR to provide a correct error message (and not "Payload value must not be empty") for this situation (Acknowledgement argument must only be used with manual acknowledgment configuration).
https://github.com/spring-projects/spring-kafka/pull/1684
However this test fails:
	@Test
	public void testBadAckConfig() throws Exception {
		template.send("annotated28", 0, 1, "foo1");
		assertThat(this.config.badAckLatch.await(30, TimeUnit.SECONDS)).isTrue();
		assertThat(this.config.badAckException).isInstanceOf(IllegalStateException.class);
		assertThat(this.config.badAckException.getMessage())
				.isEqualTo("No Acknowledgment available as an argument, "
						+ "the listener container must have a MANUAL AckMode to populate the Acknowledgment.");
	}

From the expected message it seems to me that it expects the listener not to have an Acknowledgement argument, however in the listener method there is an Acknowledgment argument:
		@KafkaListener(id = "ackWithAutoContainer", topics = "annotated28", errorHandler = "badAckConfigErrorHandler",
				containerFactory = "withNoReplyTemplateContainerFactory")
		public void ackWithAutoContainerListener(String payload, Acknowledgment ack) {
			// empty
		}

The exception that occurs is my newly created exception and not the expected exception in this test.
Is the test wrong or did I break something I shouldn't have?
Thank you, Sela

@garyrussell
I added a PR to provide a correct error message (and not "Payload value must not be empty") for this situation (Acknowledgement argument must only be used with manual acknowledgment configuration).
https://github.com/spring-projects/spring-kafka/pull/1684
However this test fails:
	@Test
	public void testBadAckConfig() throws Exception {
		template.send("annotated28", 0, 1, "foo1");
		assertThat(this.config.badAckLatch.await(30, TimeUnit.SECONDS)).isTrue();
		assertThat(this.config.badAckException).isInstanceOf(IllegalStateException.class);
		assertThat(this.config.badAckException.getMessage())
				.isEqualTo("No Acknowledgment available as an argument, "
						+ "the listener container must have a MANUAL AckMode to populate the Acknowledgment.");
	}

From the expected message it seems to me that it expects the listener not to have an Acknowledgement argument, however in the listener method there is an Acknowledgment argument:
		@KafkaListener(id = "ackWithAutoContainer", topics = "annotated28", errorHandler = "badAckConfigErrorHandler",
				containerFactory = "withNoReplyTemplateContainerFactory")
		public void ackWithAutoContainerListener(String payload, Acknowledgment ack) {
			// empty
		}

The exception that occurs is my newly created exception and not the expected exception in this test.
Is the test wrong or did I break something I shouldn't have?
Thank you, Sela

The MessagingMessageListenerAdapter already has a field hasAckParameter.
We currently only check it if a MessageConversionException is thrown.
https://github.com/spring-projects/spring-kafka/blob/f9bc4195110c07651e004fa9ab9638d392c2baaa/spring-kafka/src/main/java/org/springframework/kafka/listener/adapter/MessagingMessageListenerAdapter.java#L333-L339
We should change that to add a MethodArgumentNotValidException to the catch.

The MessagingMessageListenerAdapter already has a field hasAckParameter.
We currently only check it if a MessageConversionException is thrown.
https://github.com/spring-projects/spring-kafka/blob/f9bc4195110c07651e004fa9ab9638d392c2baaa/spring-kafka/src/main/java/org/springframework/kafka/listener/adapter/MessagingMessageListenerAdapter.java#L333-L339
We should change that to add a MethodArgumentNotValidException to the catch.

@garyrussell
Good afternoon, please tell me, I have a listener in the parameters that has an object(POJO) and acknowledgment, when an error occurs, I shift the offset in the handler and send this message to a "error" topic, but I do not acknowledgment.acknowledge(); because I can not pass it to the my errorHandler. How to pass acknowledgment to my custom ErrorHandler?
Otherwise, if I do not do acknowledgment.acknowledge(); in my errorHandler, then when the micro service is raised again, it will re-read these messages and will process them again.

Don't ask unrelated questions in old, closed, issues; use the Discussions tab to ask questions, or ask on Stack Overflow tagged with [spring-kafka].
I am not sure what you mean by "shift the offset". I don't know if you are using the framework error handling mechanism or your own.
If you are using your own error handler and you can't change its API for some reason, one option would be to pass the Acknowledgment using a ThreadLocal.
If that's not clear, ask a new question (not an issue) showing your code and configuration.

If you are using the framework DefaultErrorHandler (or SeekToCurrentErrorHandler for 2.7.x and earlier) and the ackmode is MANUAL_IMMEDIATE, the error handler will commit the offset for the recovered record if it's commitRecovered property is true.

@garyrussell
Thanks a lot.
I'm sorry I wrote in the closed issues, in the future I will turn to the right discussions.

The Acknowledgment argument is only available if the container AckMode property is MANUAL or MANUAL_IMMEDIATE. You cannot acknowledge records that are automatically acknowledged by the container, which is the default (and preferred) behavior.

@garyrussell,  in this case i suggest to throw the exception with a better semantic error message.

@mdymen85 ,
Please, raise a new issue with more relevant context. The closed issue is closed for a reason. And this one had some fixed in some milestone.
Plus Gary is not with the team anymore.


7tv support

What should be added?
emote support for 7tv like @AnatoleAM 's fork https://github.com/SevenTV/chatterino7
Why should it be added?
its like another third party thing

I'll let this issue wait until the conversation of adding this to upstream is finished.

Added as an optional feature


Add exponential With jitter backoff

Adds exponential + jitter retry policy. To enable drastic slow down of sending out requests to any external system.
Jitter in computational contexts refers to the addition of a small random variation to a value to break the symmetric patterns

@duke-git Please review this


Orphan Instances mess up haddocks

Since almost all of the TextShow instances are provided as orphans, the don't show up in the haddocks. This is similar to an issue in aeson that I noticed.

I'm 99% sure this is a GHC bug. My reasoning stems from the discussion here, since someone else had trouble looking up orphan instances with the GHC API.

I'm going to close this issue, since I'm not willing to refactor huge chunks of this library to accommodate what is a proper Haddock bug. See my comment here.

This issue has been fixed upstream in Haddock, and will land in the Haddock bundled with GHC 8.4.1. Proof:


Search documents

As an integrator, I want to search for records with the EAS search mechanism to up to 100 records matching the search parameter.

PR #14 added the base of this request. I will close the issue as I will add more parameters simply by submitting PRs.


Add DefaultAzureCredentialOption

Add DefaultAzureCredentialOptions type that will include fields for:

scopes
environment credentials
managed identity credentials

These options will be used in the Default Credential type in azidentity

Added in linked PR #6432


Opening the first commit in Project History throws an error

Current Behavior
When opening the first commit in Project History > Commit History, Node-RED throws an error.
Existing project

Newly created project

Expected Behavior
No response
Steps To Reproduce
Open the first (oldest) commit in Project History > Commit History
Example flow
No response
Environment

Node-RED version: 3.0.2
Node.js version: v16.17.0
npm version: 8.15.0
Platform/OS: macOS Monterey 12.6
Browser: Chrome

I was thinking about this issue. Maybe when clicking on the first commit, it should only show the contents of the commit and not try to generate a diff.


Unable to stop console output

When I load a file I get a print out on the console:
compiling: [
  'C:\\Users\\supercoder2000\\source\\repos\\project\\src\\config.ts'
]

I have tried setting NODE_ENV=production but I still get the printouts.
I get this every time I run.

On 0.2.8-rc1 I am only getting the output when it actually compiles which is good. I am still wondering if there is an option to turn off this output.


FYPO term/evidence combined filtering not working

From this comment when evidence filtering was deployed:
https://github.com/pombase/website/issues/249#issuecomment-293464984
I got the impression that we should be able to filter on FYPO terms and evidence simultaneously, and see annotations that match "term x AND evidence y" (if any). But that appears to be broken.
Whichever filter I select first works, but then nothing happens when I make a selection from the other filter pulldown (i.e. if I pick a term filter first, it works, but if I then pick an evidence filter no further filtering happens, and vice versa).
Oddly, if I remove the first filter, the second one I tried to set then magically starts working, a la

term filter -> annotations filtered by term
add evidence filter, yielding term filter + evidence filter -> no change
remove term filter, leaving evidence filter -> annotations filtered by evidence

... and vice versa, again.
Seems to affect gene pages and publication pages (not relevant on FYPO term pages, which are effectively already term-filtered). Doesn't seem to be browser-specific.
Probably ought to be fixed for release unless it's really hairy.

Thanks for catching that.  It looks like combining filters never worked.  Sorry for the poor testing.
It should be fixed now.

thanks - trying to document how it should work is a great way of finding things that don't ...


When provisioning a private GKE cluster, there is no Registration tab showing the registration command to connect the cluster to Rancher

Setup

Rancher version: v2.6.8
Browser type & version: Chrome

Describe the bug

Similar to previously-logged issue https://github.com/rancher/dashboard/issues/6036, when you go to create a private GKE cluster within Rancher, there is no registration tab present. That means, if you do not copy the registration command presented after you provision the cluster, you need to go to the old UI and get the UI that way:

As we did with EKS and AKS, we need to ensure that we expose the registration tab so that it is easier for users to be able to find the registration command needed to finish configuring their private GKE clusters in Rancher.
To Reproduce

Setup Rancher, create a standard user and login as that user.
Navigate to Cluster Management and choose GKE.
Fill out the prompted information and ensure that you specify that this is a private cluster.
Once the cluster appears in Cluster Management, click the cluster and note that there is no Registration tab to grab the registration command.

Result
There is no registration tab containing the kubectl apply command to register the cluster.
Expected Result
There needs to be a registration tab, similar to what we have for private AKS and private EKS clusters.

We can mimic what we have with EKS & AKS already.

Validated that this is addressed in v2.7-head https://github.com/rancher/rancher/commit/eab28ddaeeb772894c35a7e86b0e37d3cb484b8c.
ENVIRONMENT DETAILS

Rancher install: Helm
Rancher version: v2.7-head https://github.com/rancher/rancher/commit/eab28ddaeeb772894c35a7e86b0e37d3cb484b8c
Browser: Chrome

TEST RESULT - PASS
VERIFICATION STEPS

Setup Rancher, created a standard user and logged in as that user.
Navigated to Cluster Management > Google GKE.
Provisioned a private GKE cluster.
Clicked on the cluster and noted that there is now a Registration tab:


Support inherit base html for multi-page application

What problem does this feature solve?
Sometime we need html template engine to process html, like sharing base.html in a multi-page application.
What does the proposed API look like?
export default <Config> {
  compilation: {
    input: {
      index: './index.ejs',
    }
  }
}

For performance reason, I decided to implement inherit base html feature in FarmPluginHtml and it does not rely on any template engine.
The template engine  feature can be implemented by plugins.


use endStream: true behavior when making an HTTP/2 request

Fix to #762

I just noticed that #760 is much better as it fixes the whole HTTP2 in DIO. Right now it is not usable at all.


How to set mp3 metadata?

I Want to set metadata in mp3 files, but i don't see a documentation for this. How i can do this?

Duplicate of #342


use ubuntu/trusty64 Official Ubuntu Server 14.04 LTS (Trusty Tahr) build

Realized I used an older Ubuntu 12 vm box file in Vagrant script.
Should be Ubuntu 14.04

looks good

LGTM

LGTM. Merge if there're no more discussions


Garry's Mod Time Out Prop_Mesh

Issue Type

[x] Unknown

So, when using this on a server, other people's games can crash rarely and just be times out after being in the server after the PM cube is out. Them they wont be able to join back after this happen when the PM cube is spawned out. I am unsure if this is a gmod or lua error.
I am hoping to help test things out and fix this

https://github.com/Aqua-GVPYT/Lilly-s-Faces/blob/main/Lilly Neutral Face.obj
Here is one of them, but even when its just one its know to cause it, it also been known to cause it on models with less and even with out a model entirely

Thanks, will take a look

thank you

Just checkin in, any good progress on finding out whats gone wrong?

Alright, if you dont have any issues I can organize my friend who does have the issues to meet up with me and record a video of what happened and get his game log.

Alright, if you dont have any issues I can organize my friend who does have the issues to meet up with me and record a video of what happened and get his game log.

can you get me the video? Will help tracking it down <3

I was coming to check in as I remembered something.
I do have a crash log from my friend when he crashed.
https://drive.google.com/file/d/1Ha5AeGFNzEWfLpdyAEV0C-Yk-NdM8oFY/view?usp=sharing
here is the log, it might be able to aid you.

His game does crash to desktop, similar to the game being overloaded by to much things
We call it the godplate, as if you put 800 or so plates in one spot, and shine a light on it, almost everyone's game crashes.

@Mari-Fey hey, sorry for the huge delay, took at look at the dump
-Lua Stack Traces-
  Client
    0. BuildFromTriangles - [C]:-1
      1. v - lua/entities/sent_prop2mesh/cl_init.lua:146
        2. Run - lua/includes/modules/hook.lua:96
          3. v - lua/prop2mesh/cl_meshlab.lua:917
            4. (null) - lua/includes/modules/hook.lua:96

  Server
    Lua Interface = NULL

  MenuSystem
    *Not in Lua call OR Lua has panicked*

-Console Buffer-
================
1866(2228.896528):  Failed to lock vertex buffer in CMeshDX8::LockVertexBuffer: nVertexCount=56952, nFirstVertex=0, nVertexSize=64, VertexFormat=327687

This typically means you are running out of Video Memory on your GPU.
1865(2228.896502):  CVertexBuffer::Lock failed !m_pVB !m_pSysmemBuffer

Seems to be an issue with BuildFromTriangles (native lua method from gmod)
I can try lowering the max default vertices

I've increased the rendering / parsing time, hopefully this will lower the crashes when joining a server. I also lowered the vertice default limit and now the prop should auto-split if that limit is reached


sleep between retries

https://argoproj.github.io/argo-workflows/retries/ would be great if could say sleep 120 seconds between each retry

https://raw.githubusercontent.com/argoproj/argo-workflows/master/examples/retry-backoff.yaml has backoff example


error: expected initializer before ‘<’ token

Description
When using the single include header (https://github.com/nlohmann/json/blob/develop/single_include/nlohmann/json.hpp) I get the following error during compilation
error: expected initializer before ‘<’ token
in line 5323.
Sorry if it's an easy fix, I don't have much experience with C++.
I'm using g++ together with the latest CUDA compiler nvcc under WSL.
Edit: does not work using C++20, C++17 (probably below as well) compiles flawlessly
Reproduction steps
Include "json.hpp" in any header file
Expected vs. actual results
Expected: Successful compilation
Actual: No compilation
Minimal code example
No response
Error messages
No response
Compiler and operating system
g++ (Ubuntu 12.1.0-2ubuntu1~22.04) 12.1.0 | Cuda compilation tools, release 12.0, V12.0.76 Build cuda_12.0.r12.0/compiler.31968024_0
Library version
version 3.11.2
Validation

[X] The bug also occurs if the latest version from the develop branch is used.
[ ] I can successfully compile and run the unit tests.

Can confirm the bug

Same error. You might compile the program with nvcc as the default compiler. I have the same problem but can't find the solution.

Looking at this, it seems that support for ranges (a C++20 feature) is disabled on g++11. I have the issue above with nvcc12 and g++10.2.1. Maybe there should be more checks here? (I thought nvcc just used gcc's headers, so maybe it has nothing to do with CUDA/nvcc.)
In any case, I wanted to share the workaround of disabling ranges with
#define JSON_HAS_RANGES 0

before including the library.


Are you going to support regions in China anytime soon

We want to deploy our amplify application for customers in China. How soon are you going to support China regions

@gaochenyue This item is on our roadmap but we cannot provide any details on when this will be available at this time.


Add data point for holidays with link to holiday details

It would be nice to have a curated list of links to URLs for details about the specified holiday.

Hi @crossan007
Definitely a nice idea! Currently the source code contains links to URLs for the majority of the holidays. Are you thinking of a function for the Holiday class that returns those URL's? Or did you have something else in mind?
Cheers! Sacha

Exactly!
So, instead of the @ link  comment (https://github.com/azuyalabs/yasumi/blob/develop/src/Yasumi/Provider/CommonHolidays.php#L36), the class Holiday could implement a getURLs() : array[] function which returns an array of type string (or possibly a new DTO for link - if we think more link metadata could be helpful).
This would enable applications using Yasumi to provide a user-facing link to view holiday details.

I think each URL is rather a ValueObject than a DTO ;) Anyways, each Holiday could indeed return a collection of URL's that are defined within the class.
As for any metadata, do you have some ideas/suggestions for that? What I can think of right now is the 'source', however that can possible be deduced from the URL.
So we could have:

Source identifier
URL
...

An additional (possibly useful) property of the 'source' object may be an ENUM value representing the "authoritativeness" (or a better word) of the 'source'.  I.E. COMMUNITY_MAINTAINED, vs GOVERNMENT_OFFICIAL to allow data-class-consumers to differentiate "wikipedia-like" sites from "official" sites.
There are probably other "information authority classifications" that would fit here, but I can't seem to think of any ;-)
Also - instead of source, HolidayInformationalReference may be a good name for the ValueObject.

 Other ones could also be:

Author
Date of Last Revision
Objectivity
Accuracy

My only concern at the moment is that it would become a pretty heavy ValueObject :) Perhaps it is best to start simple.

Of those you listed, I think Date of Last Revision would be the simplest to include with the highest benefit.
Would Author be person / organization / government credited with creating the content at the URL?  Or the person who contributed the HolidayInformationalReference data?
Not sure how we can "objectively" quantify Objectivity and Accuracy :-) but I like the idea!

Author is indeed the person / organization / government that is the owner of the source. Perhaps this one is of low benefit.
Indeed Objectivity and Accuracy might be hard to quantify and even testify as it can be quite subjective. It was just a thought :)

I have some good idea how to do this :) At the moment I am working on making the Yasumi v2.2 release, so I will have a go after that.


[Feature Request] Safari

Hello, first I want to thank you for building this extension, it's great! I was wondering why you haven't built it for Safari yet? I recently made the switch and this is definitely the number one thing I miss from Chrome.

Personally I don't have a Mac, and by extension Safari, to build or test for. The more browser support the better though. If anyone has an interest in working on this make a note here and I'd be happy to talk.

Does Safari support web extensions? Based on #92 then it could work.