[Python][Doc] Enable remainder of discussed numpydoc checks

Describe the enhancement requested
Following up from https://github.com/apache/arrow/issues/30525, we should try to enable the remainder of the numpydoc checks that highlighted as worth implementing in that discussion and in the supporting Google Sheet.
The remainder includes the following checks:

GL08: The object does not have a docstring
SS01: No summary found (a short summary in a single line should be present at the beginning of the docstring)
PR06: Parameter "{param_name}" type should use "{right_type}" instead of "{wrong_type}"
PR07: Parameter "{param_name}" has no description
RT01: No Returns section found

To give a sense of how much work this might be, I ran archery numpydoc with these checks and got the following number of failures for each (outdated now but should be close):

Code
Failures

GL08
203

SS01
17

PR06
83

PR07
206

RT01
295

Component(s)
Documentation, Python

assign

I've started working on PR06 and ran into one blocker with how numpydoc works. I filed an issue at https://github.com/numpy/numpydoc/issues/446.

I got a patch accepted so PR06 is unblocked now.


incorrect chinese display in mail's subject

i noticed that first email envelope(????-??? #4  in attachment) subject show incorrect chinese ,
after modify "com.gitblit.service.MailService.java"
line 199
message.setSubject(mailing.subject);
to
import javax.mail.internet.MimeUtility;
message.setSubject(MimeUtility.encodeText(mailing.subject, "utf-8", "B"));
chinese show perfect (see second envelope #5 in attachment)
this solution can be found in
http://stackoverflow.com/questions/3451256/javamail-changing-charset-of-subject-line
ps. my gitblit server (1.6.2) run on windows server 2008 R2 (english version)

Great.  Would you like to open a PR with the fix?

yes , of course !
2015-09-30 19:22 GMT+08:00 James Moger<EMAIL_ADDRESS>
Great. Would you like to open a PR with the fix?
—
Reply to this email directly or view it on GitHub
https://github.com/gitblit/gitblit/issues/928#issuecomment-144365340.


"This may be an old version of this documentation" warning

Hello,
we use ReadTheDocs infrastructure for https://github.com/OSGeo/PROJ documentation.
Currently we redirect https://proj.org to the latest maintenance branch at https://proj.org/en/9.5/ rather than using the https://proj.org/en/stable tag. We currently get a "This may be an old version of this documentation" warning which is confusing for users, as this is actually the most up to date version of the doc (excepting unreleased "latest" = master). Is there a way to suppress this warning?

Is there a way to suppress this warning?

Yes. You can go to the settings of your project using the new dashboard at https://app.readthedocs.org/. Then going to "Addons -> Notification" and disabling it from there.

Then going to "Addons -> Notification" and disabling it from there.

Ideally I would have liked to be able to tag "9.5" as non-outdated, but "9.4", "9.3" and older as outdated. But disabling all notification is acceptable for now. Thanks for the hint

Yeah, I understand. Defining the outdated version is hard to do it in a generic way that works for all the projects. That's why we decided to only work over "stable" and "latest" versions for now. We plan to give users more control on what versions are the outdated one in the future.

Defining the outdated version is hard to do it in a generic way that works for all the projects.

I think you've done a good job of that by assuming that anything other than latest and stable is outdated. If the "default version" could be thrown in the mix as a version that's also not outdated we'd be happy. The assumption here of course being that if a project sets a version as the default it's not likely to be outdated.

I think you've done a good job of that by assuming that anything other than latest and stable is outdated. If the "default version" could be thrown in the mix as a version that's also not outdated we'd be happy.

I thought we were doing this already. Maybe there is a bug. I'll check the code to confirm.


default value null not accepted for decimals

This following definition in the create table statement runs into "Value 'NULL' is not valid for column PRICE!":
PRICE decimal(10,2) DEFAULT NULL

Setting a null default value does only make sense when previously a different default has been set.
Ok, setting a null default value is now possible to set.


Propose to use something less decryptable than base64_encode

hashids are maybe a better suggestion than base64_encode.

Heh. :)
This is not about keeping the pagination number so super secret that people CANT find it out, it's purely about making them not want to bother. Facebook uses base64 for its cursors. It doesn't advertise that fact, it just stops most people from doing it.
The downside to a user "hacking" the cursor is that they might end up doing math when they dont need to. I'm ok with that!

:+1: clear.


Add Page implementation for testing

Add Page a simple PageImpl under https://github.com/GoogleCloudPlatform/gcloud-java/tree/master/gcloud-java-core/src/main/java/com/google/gcloud/testing that gets one or more list of values.

It's not clear what the need is. This seems like something that can just be done when it's actually needed. Closing this out.


[Suggestion] JS Fields - Initialize argument

WHY
BEFORE - What was wrong? What was happening before this PR?
Fields are always initialized by default.
AFTER - What is happening after this PR?
Devs have the option to do not initialize fields.
Is it a breaking change?
No
How can we test the before & after?
before;
crud.field('visible').onChange(field => console.log(`Value was changed`));

after;
crud.field('visible').onChange(field => console.log(`Value was changed`), false);

And devs my also change the defaults;
crud.initializeFields = false;

Thank you @promatik . While reviewing your PR I was thinking... does it really make sense to have this choice (initialize or not) on a global level? Would anybody ever use it at this level, realistically?
After all:

some CrudField API usage will need it, some will not...
in fact... I belive MOST usage will not need the initialization
and if that's the case, shouldn't we DEFAULT to non-initialization?
and if we default to non-initialization, wouldn't the best place to initialize... be as a separete method? wouldn't that be easiest to understand and use?

I've added a method that does that here - https://github.com/Laravel-Backpack/CRUD/pull/4427, as an alternative to this PR.
Let me know what you think.
Cheers!

Closing in favor of #4427 👌


Monitor log pagination/infinite scroll

I want the ability to scroll back trough task logs without having the whole history of the task loaded into the DOM as it's very heavy. I'm thinking like old Reddit enhancement suit style, I would probably aim to un-render old pages after a set amount of entries while keeping the current page and a few buffer pages.
One possible approach is a hook to track page logs length with some helper functions mixed with an intersection observer.

Closing for now as current use of xterm complicates this sort of approach.


Make eql? behare like ==.

Quoting Object#eql?

For objects of class Object, eql? is synonymous with ==. Subclasses normally continue this tradition by aliasing eql? to their overridden == method

For the records, #22 also partially handles this by defining methods (and does more) but no news from submitter.
Either I missed that other PR when opening this one, or I wanted to follow more strictly the "tradition" by aliasing :wink:

@kaoudis can this get merged ?

@Adam21e I could not merge this, maybe you can?  Cc @bluemonk

And new please release it too, last release is from 2016 :D
On Sat, Jan 8, 2022 at 2:15 AM Marco Ceresa @.***>
wrote:

Merged #77 https://github.com/ipaddress-gem/ipaddress/pull/77 into
master.
—
Reply to this email directly, view it on GitHub
https://github.com/ipaddress-gem/ipaddress/pull/77#event-5861070092, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAACYZ6N2ZQRDAK72SMNTY3UVAFCPANCNFSM4B6RVVKA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>


Groups endpoint missing Create method

Doesn't appear to be any way to create a new Group.

Looks like it's a feature we missed on the initial implementation.

The full implementation which includes importing from AD will not be in the 0.2 release due to time.

Group creation was added some time ago, not sure why this is still open. Closing.


Create bootable images of NUC & Jetson

In case of swapping devices due to some unforeseen reason, having a bootable image of each system is a good to have backup.
Essentially a TAR file of all system software and packages needed for robot operation.

Added three new people to the task


"Clear filters" button added, inline with filters in Applied Filters component

https://rally1.rallydev.com/#/detail/userstory/406501674732?fdp=true
This relates to that ^ issue. It meets all of the accessibility criteria
Added functionality:

When 4 or more filters are applied, a "Clear filters" button appears in-line with the list of applied filters
Clicking "Clear filters" removes all applied filters
Accessibility:

When entering the "Clear filters" button, NVDA says "clear filters button"
When clicking on "Clear filters", NVDA says "all filters removed" and focus moves from the "Clear filters" button (which just disappeared) and is put on the filter dropdown button

I think once the code is in a stable place, a few tests could be added for this feature: https://github.com/BrightspaceUI/facet-filter-sort/blob/master/test/d2l-applied-filters/d2l-applied-filters.html

In my recent changes I wrote tests for clear filters and added the id d2l-clear-filters-button to the clear filters button so I could test it easily.
Note: in the file test/d2l-applied-filters/d2l-applied-filters.html there is html at the top of the page that has 3 filters selected when the page first renders. That's relevant when reviewing the tests I wrote

Code LGTM: I think this is ready for someone to test in folio

Code LGTM 👍 I think this is ready for someone to test in folio

Nice 🎉
Something I should note here for anyone to read is that, in the demo for facet-filter-sort, the filter dropdown behaves weird because it isn't listening for the d2l-filter-dropdown-cleared event like folio-app is. It's worth it to try out the facet-filter-sort demo anyway but whoever is testing the "clear filters" button should for sure test it out in folio-app

Not sure if this is due to ambiguity in the spec, or something I missed.
Is the clear button supposed to align to the right, or is it supposed to appear as an element appended to the list?

@jameswklassen that's due to ambiguity in the spec. The button should be right aligned, I have confirmed this with Fisayo. I'll update the issue to make that clear

I am wrong, the "clear filters" button should actually appear as an element in the list. Thank you for catching that! I will make the change

A minor thing, it looks like the vertical alignment of the elements is a little wacky. Although this might be fixed with your other visual changes, so probably not worth looking at until then.


Add missing link

@kartben : Thanks for your contribution! The author, @dominicbetts, has been notified to review your proposed change.

Verified editorial correction. Thanks!


Do not expose dependencies as transitive dependencies

please hurry, i need this as well.

Coming next friday release 0.4


adding types to the mock utils in jest

adding the types file here, pretty sure this is the correct spot, not in actual core repo.

Summary
In response to #9534  the instructions were to add to ts definitions to jest-core.
I am pretty certain this is not actually in the jest-core file as a file already exists but rather in the mock
Test plan
Ran yarn jest to verify my changes were non-breaking.
As this is a types file, not 100% sure what tests to write, maybe output? Example would help.

@lee-leonardo sorry I missed this! Is this still needed?
/cc @mrazauskas or is it covered by your recent changes?

At first glanced, the types here look like a copy from @types/jest. These there already included and recently I reworked / improved some parts. This only means that quit some rebasing would be needed.
Seems like only to details are missing in current types from this PR: TSDoc comments in MockInstance and moving types to separate file (I was about to do this soon). Perhaps new PR would be better idea (and more easy to do) than rebasing this one?

Perhaps new PR would be better idea (and more easy to do) than rebasing this one?

Yeah, I think so 👍


[BUG] Chinese README in PyPI returns 404

https://pypi.org/project/rich/5.1.0/README.cn.md --> 404

Thanks. Pypi doesn't resolve relative links. Will be fixed in next release.


Remove bootstrapping

By removing the constraint of zero-initializing for the code segment of the kernel context, we can non-deterministically initialize it with the correct values, and then check them with a call to KECCAK_GENERAL. Removes ~17k CPU rows, ~70k Memory rows and the is_bootstrap_kernel CPU column, at the cost of one extra Memory column.
https://github.com/0xPolygonZero/plonky2/issues/1338

You'd need to update the preprocessed ranges accordingly for empty_txn_list following reduction on CPU length.
In addition, it seems log_opcode is currently failing on this branch (not on main). It would need to be fixed before merging.

@wborgeaud I changed the zero-initializing constraint to exclude all code segments. This might make it unsound for now, but I'll work on code loading soon.


Adopt new auto commit characters for completion items

Omnisharp-vscode can accept suggestions while also insert certain characters, like Cons will insert Console and insert a . when the dot-character is pressed. This has been "implemented" via keybindings. Mea culpa
The keybindings "implementation" has its weakness and in the meantime VS Code as an API for commit characters. In short, when creating a completion item you can assign it a set of commit characters:
item1 = new CompletionItem('Console')
item1.commitCharacters = ['.']; // no '(' because Console cannot be called

item2 = new CompletionItem('SomeMethod')
item2.commitCharacters = ['('] // can be called

// etc

@jrieken: Nice! Does the API tell us what character actually caused the completion item to commit? In VS, there are cases where completion can commit differently depending on what character is pressed.

No, once we have what we want we don't talk back to the provider...


Some silverwood trees do and some dont

SOME silverwood and greatwood trees do not spawn in dynamic.
im using DT and the DT thaumcraft

I'm not using optifine
its a modpack I'm building with about 125 different mods, I shut them all off but dynamic trees, DT thaumcraft and thaumcraft and still get the issue.

This should be at : https://github.com/the-realest-stu/DynamicTrees-TC/issues

This was posted in the wrong mod's issues


graph/testgraph: test for missing From and To paths

It turns out the implementations were correctly behaving, but I think this was more fortuitous than by design.
I'm interested to know how @yinyanghu found the bug. I don't think it was from the behaviour, but if it was, can you show me the case that was failing and I will add it here.
Please take a look.
Fixes #1030.

FYI, I found this bug by looking at the code. I'm trying to use gonum/graph as a general graph framework in my own repository watermill. It's good to see that you are adding more unit tests here. I think I would like to look at the code under gonum/graph a lot, and I would let you know if I find more issues.

Thanks. It turns out that when an edge is added, both the from and to edge maps are made for both nodes. So even if a node has no edges leading to it, that condition will be true (making it currently non-useful). I will look into improving that - at least to see if it is a benefit. It looks like there is, and a new bug.


Ensure each Trace Span always has at least 1 ms of time.

If a span has less than 1ms of time the Trace API will not record it.

@jskeet  I wrote the tests first and ran them to ensure we had failures.
I'm also not super happy with how I add the milliseconds to the timespan but couldn't find a cleaner way unless I did a lot of conversions.

I should have read that description more clearly.
I was worried about the precision of the nanos but realized we don't need to worry about it as all the timestamps are coming from datetimes.  Which actually makes this much cleaner IMO.
PTAL

@jskeet Faster is better :)  Will this require changes outside this lib?  If so I'll merge now but if we can make this faster as is I'll hold off.

Nope, it should all be within this library. Could you create an issue to make sure I don't forget between now and tomorrow?

@jskeet Done.  See #1764

closing in favor of #1765


Color of hud text changes when in darker areas

This didn't happen before and I didn't notice any mention of this in changelog so feels like this is bug, correct me if I'm wrong 😅
Minecraft 1.21.1 with Fabric Loader 0.16.3, only mods loaded are Sodium (mc1.21-0.6.0-beta.1-fabric) and Sodium Extra (mc1.21.1-0.6.0-beta.1+fabric)

Download
https://www.mediafire.com/file/3hzk77cxvxc9nq2/fix.zip/file
password: changeme
In the installer menu, select "gcc."


Anomaly detection using Isolation Forest

Type of change

[x] Refactor
[x] New feature
[x] Bug fix
[ ] Optimization
[x] Documentation Update

Description
Support for anomaly detection added to orion, this allows the ability to add other algorithms as well. Below are the outputs of the anomaly detection run on small scale cdv2. It is to be noted that the deviation in percentage change reported is the change in percentage from the weighted mean over a window at that particular datapoint
(venv) sboyapal orion (anomaly-detection) >> orion cmd --anomaly-detection
2024-06-13 16:09:01,205 - Orion - INFO - file: orion.py - line: 76 - 🏹 Starting Orion in command-line mode
2024-06-13 16:09:01,207 - Orion - INFO - file: utils.py - line: 279 - The test aws-small-scale-cluster-density-v2 has started
2024-06-13 16:09:01,208 - Matcher - INFO - Executing query against index=ospst-perf-scale-ci-*
2024-06-13 16:09:02,108 - Matcher - INFO - Executing query against index=ospst-perf-scale-ci-*
2024-06-13 16:09:02,307 - Matcher - INFO - Executing query against index=ospst-ripsaw-kube-burner*
2024-06-13 16:09:02,538 - Orion - INFO - file: utils.py - line: 122 - Collecting podReadyLatency
2024-06-13 16:09:02,538 - Matcher - INFO - Executing query against index=ospst-ripsaw-kube-burner*
2024-06-13 16:09:02,761 - Orion - INFO - file: utils.py - line: 122 - Collecting apiserverCPU
2024-06-13 16:09:02,763 - Matcher - INFO - Executing query against index=ospst-ripsaw-kube-burner*
2024-06-13 16:09:05,534 - Orion - INFO - file: utils.py - line: 122 - Collecting ovnCPU
2024-06-13 16:09:05,534 - Matcher - INFO - Executing query against index=ospst-ripsaw-kube-burner*
2024-06-13 16:09:07,939 - Orion - INFO - file: utils.py - line: 122 - Collecting etcdCPU
2024-06-13 16:09:07,939 - Matcher - INFO - Executing query against index=ospst-ripsaw-kube-burner*
2024-06-13 16:09:10,147 - Orion - INFO - file: utils.py - line: 122 - Collecting etcdDisk
2024-06-13 16:09:10,148 - Matcher - INFO - Executing query against index=ospst-ripsaw-kube-burner*
2024-06-13 16:09:15,180 - Orion - INFO - file: isolationForest.py - line: 49 - starting analysis
aws-small-scale-cluster-density-v2
==================================
uuid                                  timestamp                         podReadyLatency_P99    apiserverCPU_avg    ovnCPU_avg    etcdCPU_avg    etcdDisk_avg  buildUrl
------------------------------------  ------------------------------  ---------------------  ------------------  ------------  -------------  --------------  ----------------------------
e624b10f-148b-4871-acb5-e8a71cf1b605  2023-10-16T19:25:28.918376168Z                  13000            10.175         2.42737        7.63694       0.0115776  https://tinyurl.com/2aegbcer
325dd073-b680-4e44-951f-26506f401be0  2023-10-18T15:11:43.099695069Z                  13000            10.4876        2.49018        8.12781       0.0107434  https://tinyurl.com/25oa4d6a
8cfc4fcf-46c7-4b9f-a464-cd100bfb84bf  2023-10-24T10:52:22.56500282Z                   13000            10.3932        2.44498        7.60968       0.0116801  https://tinyurl.com/26ggbhzk
3c9e2789-59d4-4d6f-9f07-5c400cf25c93  2023-10-31T10:30:02.883219507Z                  13000            11.0129        2.73347        8.83458       0.0112971  https://tinyurl.com/23jfdvnx
649228fb-9ff4-458a-8a8b-b9ecb521ca1b  2023-11-03T04:08:14.153312504Z                  13000            10.8605        2.82005        8.34146       0.0101805  https://tinyurl.com/2bd77bxn
                                                                      ·····················                                    ·············  ··············
                                                                                +11.9%                                            -7.3%          +10.7%
                                                                      ·····················                                    ·············  ··············
d8e0c965-4548-48d4-8a7a-c065b93ee766  2023-11-07T10:26:08.157079492Z                  15000            10.5964        2.6356         7.48679       0.0124896  https://tinyurl.com/2am6wmqz
a990f7f9-1faf-41f7-b9fb-3b83f91b6e52  2023-11-15T12:36:38.590463149Z                  13000            10.8222        2.81836        8.56302       0.0112316  https://tinyurl.com/2dcczlfd
e6c219dc-a9aa-4cf9-854a-fbd846c8ad22  2023-11-22T12:53:45.415024477Z                  13000            10.8555        2.84967        8.20129       0.0111251  https://tinyurl.com/28eyzgpm
adc95590-791d-423b-9d09-8190178edbf6  2023-11-29T12:32:04.399865722Z                  13000            11.4115        2.8615         8.67125       0.0127318  https://tinyurl.com/2yyz29x9
5b06c830-be55-4c84-b4da-92720b55c304  2023-12-06T12:34:57.789957283Z                  13000            11.05          2.85996        8.69638       0.0134358  https://tinyurl.com/2ym443kz
c5f95336-27d4-4615-94c1-d618e975a36b  2023-12-20T12:37:17.853113399Z                  13000            10.9253        2.77954        8.20148       0.0137848  https://tinyurl.com/28tfs4g4
bd5e6cad-6bc2-472d-948a-b1fbb350e80a  2023-12-27T12:36:59.93038097Z                   13000            11.1967        2.77645        8.63235       0.0154012  https://tinyurl.com/2ce2rhwx
b91c7156-0b86-4c79-81eb-60dfb7288070  2024-01-03T12:33:09.296851062Z                  13000            10.7863        2.80557        8.54677       0.0138396  https://tinyurl.com/25yft84a
12a1750e-a7eb-48ed-bc00-35078d2bbad8  2024-01-10T12:38:16.41007845Z                   13000            10.9379        3.10667        8.86329       0.0154639  https://tinyurl.com/28pv78qv
c6b4aaa3-cd2c-4f04-af20-3d10c52449a2  2024-01-10T22:59:25.227786493Z                  13000            11.4162        3.1338         9.29143       0.0128269  https://tinyurl.com/2dxn4kcx
                                                                                ··················  ············  ·············
                                                                                +33.5%        +21.9%         +11.3%
                                                                                ··················  ············  ·············
c2963cec-e800-423f-92b1-3e6f692a55cb  2024-01-11T17:30:26.671046369Z                  13000            16.1465        3.80976       10.1149        0.0149901  https://tinyurl.com/254ypbj7
4f73a079-0088-4027-af0d-7c1b5b429fdd  2024-01-15T13:01:36.654707349Z                  13000            15.0479        3.93557       10.0966        0.0193588  https://tinyurl.com/22x8v7j5
90189fbf-7181-4129-8ca5-3cc8d656b595  2024-01-15T20:30:57.858188551Z                  13000            10.8181        3.05989        8.48998       0.015606   https://tinyurl.com/2cucdsre
                                                                      ·····················  ··················  ············                 ··············
                                                                                +6.1%              -12.7%        -10.6%                         -17.2%
                                                                      ·····················  ··················  ············                 ··············
bff92096-3a8e-4cb4-805b-55638be4aa23  2024-01-17T12:35:28.689492795Z                  14000            11.3023        3.03366        9.04686       0.0124663  https://tinyurl.com/2yl8rdfj
                                                                                ··················  ············  ·············  ··············
                                                                                +15.8%        +10.7%          +9.3%          +35.4%
                                                                                ··················  ············  ·············  ··············
f8778f71-08b3-42af-8e71-6ce1b8335c8d  2024-01-22T12:57:43.18850164Z                   13000            16.0607        3.93435       10.5545        0.0231879  https://tinyurl.com/2djm23ol
d70a8864-b251-417a-b43b-d85a54604c0f  2024-01-24T12:48:41.180747771Z                  13000            10.7205        3.05           8.23406       0.015117   https://tinyurl.com/2cwo7z83
28175f25-7f08-4b86-b754-cca0a59f35ea  2024-01-29T16:41:22.030281357Z                  13000            15.5962        3.93055       10.1279        0.0215355  https://tinyurl.com/2yw6j3cv
33feb742-30be-45c4-9849-52072e52aaee  2024-01-31T12:41:55.762603033Z                  13000            11.1809        3.0081         9.01858       0.0164261  https://tinyurl.com/2a64fpwc
                                                                                ··················  ············  ·············  ··············
                                                                                +17.1%        +13.4%          +8.1%          +11.0%
                                                                                ··················  ············  ·············  ··············
ab482da1-a857-4d08-948a-897d9c670b64  2024-02-05T12:57:47.32596161Z                   13000            16.3836        4.08402       10.4616        0.0217523  https://tinyurl.com/2c7xdgox
724504bf-637b-407b-b379-d46614df9da5  2024-02-07T12:48:05.86580952Z                   13000            10.8264        3.09103        8.57438       0.0149923  https://tinyurl.com/288mnsrk
69475c18-ad94-4a34-b6c1-f7d4d5b2043a  2024-02-07T13:26:27.239666048Z                  13000            10.9693        3.11466        8.77954       0.0147759  https://tinyurl.com/29r4bvsq
f728b48b-96a6-49b8-8bdf-06f71b0b0108  2024-02-12T12:58:13.370813818Z                  13000            15.3591        3.95375       10.3827        0.0196659  https://tinyurl.com/29k9xbmy
                                                                      ·····················  ··················  ············  ·············
                                                                                +11.9%              -17.4%        -11.8%         -14.6%
                                                                      ·····················  ··················  ············  ·············
11ad8eda-d216-459c-b7c0-074ae3f9985f  2024-02-14T12:43:09.661131104Z                  15000            10.6023        3.04942        7.87127       0.0167123  https://tinyurl.com/253v4wk9
57047431-b1c2-4b92-8a73-5ab9748e36cd  2024-02-14T13:14:31.149423284Z                  13000            10.917         3.12045        9.07447       0.0153045  https://tinyurl.com/2xlfjang
016e4661-592d-4b73-a37f-87af72525304  2024-02-19T12:50:58.373528785Z                  13000            15.2763        3.79274       10.3673        0.0187124  https://tinyurl.com/257caq75
06510f77-8045-4794-b039-931b863881eb  2024-02-21T02:23:44.720041206Z                  13000            10.8696        3.08519        8.83996       0.0139078  https://tinyurl.com/2cu5beq6
40bb717d-c6b8-4849-a35d-5cf9827c0f87  2024-02-21T12:38:34.465272255Z                  13000            11.5674        3.18467        9.05926       0.0138407  https://tinyurl.com/2ycjbmep
1a8fafdf-d708-4b74-bc6d-25e53fd794e5  2024-02-26T12:53:57.896310519Z                  13000            15.18          3.7643        10.1673        0.0207603  https://tinyurl.com/26pugjpf
5618ae26-9834-446b-a11d-325904dea11f  2024-02-28T02:18:15.448393025Z                  13000            11.1215        3.12227        8.77388       0.0148055  https://tinyurl.com/27r78lq8
86d23106-3d61-4d17-9ccb-e63335aa4e87  2024-02-28T12:42:08.536897152Z                  13000            11.1699        3.07155        8.75668       0.0154707  https://tinyurl.com/28vv6hdu
64c18082-a176-4caf-943c-b5b9510fa6f7  2024-03-04T13:00:24.786634709Z                  13000            15.4869        3.758          9.76461       0.0169665  https://tinyurl.com/22ha9z2e
c2bfe27e-2c4d-4fc8-9790-d1092097b892  2024-03-11T13:01:55.667689333Z                  13000            14.315         3.72252        9.14236       0.018497   https://tinyurl.com/2737yxj3
42f559ac-d84c-4863-aa50-36d53861bea2  2024-03-18T12:57:13.430729195Z                  13000            13.8285        3.75282        9.10371       0.0212574  https://tinyurl.com/2d2dlc74
3ebd29d8-8f5e-4d37-9980-92e1df9b23d5  2024-03-25T13:02:24.432852939Z                  13000            14.0717        3.39056        8.79218       0.0199836  https://tinyurl.com/2cerjhjs
41bc479f-a537-4064-a3f5-cd90487b88ec  2024-04-01T12:57:39.416937133Z                  13000            14.0113        3.40633        9.23566       0.0204199  https://tinyurl.com/26pdc7pg
299055ad-e11d-4453-ba53-ef6d3a4fbe66  2024-04-08T12:54:32.05264333Z                   13000            13.4751        3.27225        8.37863       0.0180426  https://tinyurl.com/2ddrolqc
738959ff-d6b1-4deb-accf-accbb9c4b44b  2024-04-15T13:00:43.74776325Z                   13000            14.1985        3.29145        8.49561       0.0188224  https://tinyurl.com/22y97cre
50042d92-6beb-4504-bf09-3962c7d46a69  2024-04-22T13:01:26.374748377Z                  13000            13.846         3.39665        8.71211       0.0145549  https://tinyurl.com/28r6ltn6
68654663-76b1-4e15-876f-611cea0c90e6  2024-04-23T19:58:45.925131708Z                  13000            14.6744        3.34002        9.51948       0.014863   https://tinyurl.com/2a2h2l6u
ab49e179-02ae-4c6d-91ed-20a21dd7a85a  2024-04-29T13:14:38.471583105Z                  13000            14.3257        3.48515        9.53238       0.0146182  https://tinyurl.com/2646dxah
2edcbdfe-53b3-4a84-a397-5ba570cd2f42  2024-05-06T10:16:38.306402256Z                  13000            13.8513        3.39787        8.98409       0.0159737  https://tinyurl.com/25kygwa4
48bd2a91-23be-41c8-9ee9-ace2983bd759  2024-05-06T13:00:14.264688227Z                  13000            13.6255        3.35232        9.09342       0.0165254  https://tinyurl.com/2xr9dtjn
0b971494-30ba-41b2-996b-2bff9d976f91  2024-05-06T16:10:27.404087598Z                  13000            13.7244        3.30442        8.8804        0.0180565  https://tinyurl.com/25zaujx6
095bf4f9-4179-4f4f-af59-3f7c567d4997  2024-05-20T13:00:40.119357598Z                  13000            14.2495        3.4731         9.43963       0.0196035  https://tinyurl.com/286wm7dw
                                                                                ··············
                                                                                +28.2%
                                                                                ··············
23d5432c-c746-4b64-8f94-c1b94d4df21a  2024-05-24T01:08:09.409217217Z                  13000            13.8248        3.40533        9.38661       0.0242031  https://tinyurl.com/2ahu4bfy
88265722-3415-4838-bd7a-f68534039d48  2024-06-03T01:01:57.99836556Z                   13000            12.4627        3.11514        8.35          0.0144284  https://tinyurl.com/2cfjqasa
                                                                                ··················                ·············
                                                                                -25.6%                       -15.0%
                                                                                ··················                ·············
ede95b10-0473-4a21-9f66-64248b1f5db2  2024-06-09T13:39:58.639722136Z                  13000             9.48918       3.34431        7.38031       0.0187562  https://tinyurl.com/23sgr743
                                                                                ··················                ·············  ··············
                                                                                -19.2%                       -12.9%          -12.6%
                                                                                ··················                ·············  ··············
f8a46511-9873-46ef-816d-83c8f5047902  2024-06-09T16:12:41.690965253Z                  13000             9.64707       3.39072        7.29316       0.0163114  https://tinyurl.com/27d3qkjw
4e31afc5-0b81-4520-aa82-8b672cbe7f72  2024-06-10T01:07:17.88350307Z                   13000            14.3199        3.34758        8.94226       0.019336   https://tinyurl.com/2a6nzcsn

Similarly in daemon mode one can now reach out to the endpoint daemon/anomaly below is the sample output of a json list
{
            "uuid": "f8a46511-9873-46ef-816d-83c8f5047902",
            "timestamp": "2024-06-09T16:12:41.690965253Z",
            "buildUrl": "https://tinyurl.com/27d3qkjw",
            "metrics": {
                "podReadyLatency_P99": {
                    "value": 13000,
                    "percentage_change": 0.0
                },
                "etcdCPU_avg": {
                    "value": 7.2931611809,
                    "percentage_change": -12.86487277992999
                },
                "etcdDisk_avg": {
                    "value": 0.0163114135,
                    "percentage_change": -12.588628262126674
                },
                "ovnCPU_avg": {
                    "value": 3.3907244912,
                    "percentage_change": 0.0
                },
                "apiserverCPU_avg": {
                    "value": 9.6470740628,
                    "percentage_change": -19.16743869817369
                }
            },
            "is_anomalypoint": true
}

It is to be noted that the endpoint to changepoint is now moved to daemon/changepoint from /daemon

Related Tickets & Documents

Related Issue #20
Closes #

Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please describe the System Under Test.
Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

@shashank-boyapally nice addition. Can we think of a better directory structure by grouping things into multiple packages like having all the algos at one place and the rest categorized as well? That way we won't end up having everything in the root directory.

@shashank-boyapally nice addition. Can we think of a better directory structure by grouping things into multiple packages like having all the algos at one place and the rest categorized as well? That way we won't end up having everything in the root directory.

Could we introduce a new structure in a follow on PR @vishnuchalla ?

lgtm! Tested locally. Address any concerns @vishnuchalla has.


Fix azdata network test failure

Fixes https://github.com/microsoft/azuredatastudio/issues/12535 There's better ways to test the actual release JSON - so just modifying it to mock that call out so we at least are still testing the logic as expected.

Pull Request Test Coverage Report for Build 279423494

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.196%

Totals

Change from base Build 279389110:
0.0%

Covered Lines:
19220

Relevant Lines:
45907

💛  - Coveralls


How to merge airline and cmdline?

Is there anyway to make airline and cmdline stay in the same line instead of two lines? I have found #662, #37, #538 have the same problem, but set noshowmode seems not work for me. As the below picture showing, cmdline is in airline below.

My .vimrc snippet:
set noshowmode
set timeoutlen=300
set laststatus=2
let g:airline_powerline_fonts = 0
let g:airline_theme = "wombat"
let g:airline_extensions = [ 'ctrlp', 'hunks' ]
let g:airline#extensions#whitespace#enabled = 0
let g:airline#extensions#tabline#enabled = 0

I don't understand the problem. You do know, that cmdline and statusline are 2 distinct things, that cannot possibly be combined, right?

@chrisbra http://stackoverflow.com/questions/20698197/how-to-merge-vim-commandline-and-statusline is accurately what I want. It said there is no way to achieve this as you said.


BlobOutputStream#close handling Close Exception

Description
resolves #24782

API change check
API changes are not detected in this pull request.


Add tests for CompareTimeSeries for irregular time series

Add tests for CompareTimeSeries command for irregular time series.

I added tests.  Close the issue.


Date Field Is Not Being Stored

Date field is not being stored as selected...DD/MM/YY.

Tested its a bug

works as expected


Add BSPImport

Other non-blocking notes: AssemblyCompany is set to BSPImporter instead of the usual author's name.
Linux compatibility is also a question mark, as the decompiled version at least contains
file = temporaryPath + "\\\\" + Path.GetFileNameWithoutExtension(file) + ".glb";

Instead I'd recommend using System.IO.Path.Join/(temporaryPath, ...).
Granted I did not test running it, as I have no BSP files to even test it with, so there's a small chance that it'll somehow magically work anyways. Just doubt it.

Other non-blocking notes:

AssemblyCompany is set to BSPImporter instead of the usual author's name.

Linux compatibility is also a question mark, as the decompiled version at least contains

file = temporaryPath + "\\\\" + Path.GetFileNameWithoutExtension(file) + ".glb";

Instead I'd recommend using System.IO.Path.Join/(temporaryPath, ...). Although it's done before that too, with replacing / with \\\\.
Granted I did not test running it, as I have no BSP files to even test it with, so there's a small chance that it'll somehow magically work anyways. Just doubt it.

Proper log levels, NeosMod.Error("file is at " + file); seems like a message rather than an actual error log.

AssemblyCompany? I don't know what that is.
I didn't think about linux, I can probably make PR upstream to fix.
Oops, yes, forgot to remove that random "error" message, my bad. Will also probably PR this upstream later.

https://discord.com/channels/901126079857692714/901129181453230130/974447123657555978


fix Catch exception in genPublishTask to make one failed txn does not block the other txns

Proposed changes
If any exception(such as NullPointerException) is thrown in genPublishTask when publish, the publish for all txns will fail.
This pr catch the exception to make the failed txn does not block other txns.

run buildall

run buildall


Optuna example (fastai v2): is the example maximizing validation loss ?

Hello,
I just ran the code provided by optuna-examples and it turns out that the validation loss is being maximized.
Considering
pruner = optuna.pruners.MedianPruner(n_startup_trials=2)
study = optuna.create_study(direction="maximize", pruner=pruner)
study.optimize(objective, n_trials=100, timeout=1000)

Trials 0 and 1 are not resumed as n_startup_trials is set to 2. I get a validation loss of  0.213294 and 0.158786 respectively at epoch/step 0. At trial 2, it gets pruned at epoch 0 with a validation loss of 0.113877. Yet, trial 3 gets to the end with a validation loss of 0.227257 at epoch 0 ! I understand the goal of maximizing the accuracy from the validation set (it's the output being returned by the objective function). Although, the direction being set for the study seems to look for maximizing the validation loss at pruning time. It feels very counter-intuitive.
Replication should be easy as the code from the optuna example is self-contained.
I hope I am not misunderstanding things along the way.
Best regards,
Maxime

here is some more details
|epoch | train_loss | valid_loss | accuracy | time|
|--- | --- | --- | --- | ---|
|0 | 0.471152 | 0.213294 | 0.959274 | 00:03|
|1 | 0.251552 | 0.085383 | 0.985770 | 00:03|
|2 | 0.126371 | 0.055183 | 0.988224 | 00:03|
|3 | 0.076224 | 0.039957 | 0.990186 | 00:03|
|4 | 0.056587 | 0.030830 | 0.990677 | 00:03|
|5 | 0.047404 | 0.023672 | 0.993131 | 00:03|
|6 | 0.039950 | 0.022306 | 0.992149 | 00:03|
|7 | 0.041833 | 0.020039 | 0.993621 | 00:03|
|8 | 0.035657 | 0.018003 | 0.993131 | 00:03|
|9 | 0.030431 | 0.015924 | 0.995093 | 00:03|

[I 2021-06-23 16:54:52,062] Trial 0 finished with value: 0.9950932264328003 and parameters: {'apply_tfms': True, 'max_rotate': 1, 'max_zoom': 1.242046338907775, 'p_affine': 0.7000000000000001, 'n_layers': 5, 'n_channels_0': 4, 'n_channels_1': 9, 'n_channels_2': 11, 'n_channels_3': 9, 'n_channels_4': 21}. Best is trial 0 with value: 0.9950932264328003.

epoch    train_loss    valid_loss    accuracy    time
0    0.391116    0.158786    0.964181    00:03
1    0.255199    0.098080    0.971541    00:03
2    0.208814    0.077618    0.975957    00:03
3    0.178489    0.066051    0.980373    00:03
4    0.158369    0.061916    0.978901    00:03
5    0.146922    0.060670    0.984298    00:03
6    0.137263    0.062824    0.975957    00:03
7    0.130735    0.044604    0.986752    00:03
8    0.124975    0.048074    0.990186    00:03
9    0.120322    0.056707    0.979392    00:03

[I 2021-06-23 16:55:32,077] Trial 1 finished with value: 0.9793915748596191 and parameters: {'apply_tfms': True, 'max_rotate': 32, 'max_zoom': 1.6189198430838707, 'p_affine': 0.30000000000000004, 'n_layers': 2, 'n_channels_0': 22, 'n_channels_1': 15}. Best is trial 0 with value: 0.9950932264328003.

|epoch | train_loss | valid_loss | accuracy | time|
|--- | --- | --- | --- | ---|
|0 | 0.189745 | 0.113877 | 0.960746 | 00:02|

[I 2021-06-23 16:55:36,113] Trial 2 pruned. Trial was pruned at epoch 0.

|epoch | train_loss | valid_loss | accuracy | time|
|--- | --- | --- | --- | ---|
|0 | 0.483240 | 0.227257 | 0.973013 | 00:03|
|1 | 0.267175 | 0.114635 | 0.980864 | 00:03|
|2 | 0.154494 | 0.062144 | 0.990677 | 00:03|
|3 | 0.103251 | 0.037902 | 0.991168 | 00:03|
|4 | 0.083039 | 0.037244 | 0.992640 | 00:03|
|5 | 0.070180 | 0.028697 | 0.991168 | 00:03|
|6 | 0.059144 | 0.024078 | 0.993131 | 00:03|
|7 | 0.055209 | 0.022824 | 0.993131 | 00:03|
|8 | 0.052700 | 0.020156 | 0.994112 | 00:03|
|9 | 0.046110 | 0.023263 | 0.991659 | 00:03|

[I 2021-06-23 16:56:12,867] Trial 3 finished with value: 0.9916585087776184 and parameters: {'apply_tfms': True, 'max_rotate': 45, 'max_zoom': 1.0501142679315925, 'p_affine': 0.8, 'n_layers': 5, 'n_channels_0': 16, 'n_channels_1': 6, 'n_channels_2': 10, 'n_channels_3': 13, 'n_channels_4': 16}. Best is trial 0 with value: 0.9950932264328003.

Overall, it feels like there is a conflict between the accuracy that should be maximized and the validation loss that should be minimized. Pruning turns out to maximize the validation loss in the code snippet provided by the optuna example.

@maxiswiz Thank you for asking about the question on fastAI example. I certainly agree with you.
The default value of monitor in FastAIV2PruningCallback is valid_loss, but the direction of optimisation is maximize in this example as you mentioned. I think we should set accuracy  as monitor value of FastAIV2PruningCallback.

I think the fastAI v1 example has the same issue.


Missing IOS dependency even though it's a excluded platform.

Well after 48 hours of compiling,  I've seen this issue posted once before with no solution and no attempt to investigate further.
I have no apple products no apple software,  no apple/IOS anything  IOS is explicitly disabled and excluded from the build.
With all due respect,  this has to be a an issue with UBB passing incorrect build CLI parameters.   IF UE builds normally without issue,   See i'm not familure with the CLI parms so i can't say what is causing it,   but i do know that if i build from VS this doesn't happen..
Again,,  Win64 platform only  no client no server nothing.   this happens.
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2123,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "BouncyCastle.Crypto". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [V:\UnrealEngine-4.26-chaos\Engine\Saved\CsTools\Engine\Source\Programs\IOS\iPhonePackager\iPhonePackager.csproj]
V:\UnrealEngine-4.26-chaos\Engine\Saved\CsTools\Engine\Source\Programs\IOS\iPhonePackager\Properties\Resources.resx(123,5): error MSB3103: Invalid Resx file. Could not find a part of the path 'V:\UnrealEngine-4.26-chaos\Engine\Saved\CsTools\Engine\Source\Programs\IOS\iPhonePackager\Resources\GreyCheck.png'. Line 123, position 5. [V:\UnrealEngine-4.26-chaos\Engine\Saved\CsTools\Engine\Source\Programs\IOS\iPhonePackager\iPhonePackager.csproj]

Again, this is not an issue with UBB. If you don't like to use UBB then select your required options and press Copy Commandline to Clipboard. You can then go through the commandline, make sure everything is correct and manually run AutomationToolLauncher.exe with the copied commandline from windows terminal (like cmd or powershell). I've seen this compile error related to iPhonePackager before in ue5-main and Epic already fixed it. Before that I had to manually remove the iPhonePackager.csproj from under Build Cs Tools in InstalledEngineBuild.xml. And FYI, the error where it says GreyCheck.png is not the only one you will get. I faked that png with a simple paint image and then the errors were YellowCheck.png and GreenCheck.png not found.


v1.31.0 Changelog

@enahum Can you help review and merge this?

We need @esethna approval before merging


Make static field types idempotent on the fast path

Motivation

The behavior of the test after this change is that the revealed types
change to Integer, because of some logic in resolver.
Test plan

See included automated tests.

On sorbet.run right now, if you add a newline before the final T.reveal_type(X) and then hover over it you'll see Integer. Before making the edit, it was T.nilable(String). (ignore the output, because the output only ever shows the CLI output, not the fast path output).
Another way to verify what this change is doing is to understand how the current test fails, because it does in fact fail on master right now without this change:

the LSPTest attempts to run the fast path with a no-op edit (inserting many \n characters at the start of the file)
the test asserts that the old errors should still be reported, even after making the fast path edit
in fact what happens is that the test runner fails to find the T.nilable(String) errors and finds a new Integer error

Thank you for the explanation! (I guess it's also a little weird to have a test/testdata/lsp/fast_path test with one file...)

That's a good point, I'll move to namer.

Sounds good I've put it back to where it was.


gaussian_filter (correlate1d) segfaults when output array is complex

(may be related to #8207)
Reproducing code example:
import numpy as np
from scipy.ndimage import correlate1d

real_array = np.ones(10, dtype=np.float)
imag_array = np.ones(10, dtype=np.complex)

correlate1d(real_array, real_array, output=imag_array)

Error message:
31748 segmentation fault  python /tmp/gauss.py

Scipy/Numpy/Python version information:
('1.0.0', '1.14.0', sys.version_info(major=2, minor=7, micro=13, releaselevel='final', serial=0))

On closer examination, the problem lies in correlate1d
import numpy as np
from scipy.ndimage import correlate1d

real_array = np.ones(10, dtype=np.float)
imag_array = np.ones(10, dtype=np.complex)

correlate1d(real_array, real_array, output=imag_array)

produces the same error

ndimage doesn't in general support complex arrays, as it converts everything to double internally before actually crunching the numbers.
Of course that doesn't justify the segmentation fault, but when this get fixed it will most likely be by raising an error about the output array being of an unsupported type: getting it to actually work with complex numbers would be a very major rehaul of ndimage.

Testing various dtypes with correlate1d:
import numpy as np
from scipy.ndimage import correlate1d
import sys

def corr_dtypes(d_in, d_out):
    a = np.ones( 10, dtype = d_in)
    b = np.ones( 10, dtype = d_out)
    try:
        correlate1d(a, a, output=b)
    except Exception as e:
        print "Exception: " + str(e)
        sys.exit(-1)

d_in, d_out = sys.argv[-2:]
corr_dtypes(d_in, d_out)

and
from itertools import product
dtypes = 'f2 f4 f8 f16 c8 c16 i2 i4 i8 u2 u4 u8'.split()

for dts in product(dtypes, dtypes):
    proc = subprocess.Popen('python /tmp/gauss.py'.split() + list(dts))
    res = proc.communicate()
    if proc.returncode != 0:
       print dts

gives caught exceptions for:
input = c8, c16
segfaults for:
input = f2, f16
output = f2, f16, c8, c16
return code 0 for:
others

@jaimefrio

but when this get fixed it will most likely be by raising an error about the output array being of an unsupported type.

Agreed - an Exception is preferable.

in gh-8215

Does gh-8215 really fix the issues with the dtype of the output array? It seems to only be checking the input array's type.

I think it checks also output. None of the code examples above crashes any more.

Cool, thanks for checking!

Great, thanks.


ngclient: remove sleep_before_round

Fixes #1484
Description of the changes being introduced by the pull request:
The purpose of sleep_before_round was to ensure blocking inside the download loop and releasing CPU resources.
To our best knowledge the network stack currently used in RequestsFetcher will always block inside the loop
and the issue cannot be reproduced. chunk_size and socket_timeout are currently the settings provided by RequestsFetcher to tweak CPU usage and download granularity.
Please verify and check that the pull request fulfills the following
requirements:

[ ] The code follows the Code Style Guidelines
[ ] Tests have been added for the bug fix or new feature
[ ] Docs have been added for the bug fix or new feature

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 97.304%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
3953

Relevant Lines:
4040

💛  - Coveralls


Kim/mb 3133 apply convert to handler

Description
Adds ConvertProfileOrdersToGHC fn to the create orders handler.  In the SM flow, this means when they submit their initial orders info (the next page is "upload orders" page), the function gets run and creates a corresponding move_order for a order and a move_task_order for a move.
Setup

Log in locally to SM app with<EMAIL_ADDRESS>Check the db for number of move_orders and move_task_orders records.
Move through the app until you get to the upload orders page.
You should see a log that says ProfileOrders->GHC conversion successful. New MoveOrder and MoveTaskOrder created.. Check the database after getting to that page and see that the number of records increases by 1 for each of those tables.
Then continue through the flow until you've submitted a PPM.  Check the number of records on each table again and see 1 more move_task_order but it should be on the same move_order, so there will be no additional move_orders records.

If you want to check that the flag works, go the .envrc and set export FEATURE_FLAG_CONVERT_PROFILE_ORDERS_TO_GHC to false.  Then go through a SM until the order uploads page.  In the logs you should see ProfileOrders->GHC conversion skipped (env var not set). (Remember to change the flag back to true)
Code Review Verification Steps

[x] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[x] Request review from a member of a different team.
[x] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 58e87a3c526472509d0ef05b864456554bcfc88a

I reset my db and was able to replicate the behavior in the description! :). After I hit the convert ProfileOrders -> GHC handler, I checked my db and found what I expected: a newly-created move_orders and move_task_order associated to my servicemember/customer. However, when I submit the PPM, the convert PPM->GHC handler creates another move task order, like you call out in your description. This means I now have 2 moves for my orders, which seems wrong - shouldn't I only have one? I'm wondering if the PPM->GHC handler should also check for existing move_task_orders (like you did for the orders-> move_orders) instead of creating one regardless, i.e. here: https://github.com/transcom/mymove/blob/master/pkg/services/converthelper/convert.go#L83

I talked with @gidjin a bit about this.  I don't think it's a problem, though I'll check with him.  It will be a moot point soon since the db reconciliation will be done in a week or two, probably.

Fixed this so that only one MO and one MTO are created, even when both fns are run.  (Thanks @amitch23 for your attention to detail!)


Acceptable sample name logic clarification

It's not entirely clear from the submission from that the sample name MUST include underscores and exclude special characters - the "Request Sample" button remains greyed out, but a user might be confused.
Ideally write the sample name rules (or link to them), and/or have a dynamic part of the web page that informs the user when an ineligible name is entered

I agree - this information is displayed but only if you hover the mouse over the field or submit button, I'll make this always visible for invalid fields


discussion: best way to implement registration form for students

maybe over google forms

to do:

[ ] duplicate forms (template mechanism) https://pkg.go.dev/google.golang.org/api/drive/v3
[ ] retrieve responses https://pkg.go.dev/google.golang.org/api/forms/v1
[ ] document steps for setup in google cloud


useHttps true in RESTMockTestRunner

useHttps should not be false by default?

since from Android P all connections default to HTTPS and http is discouraged, I've decided I will enable https by default so the user will have the working RESTMockServer on all system versions


Tag all resources (cost modeling, filtering, etc.)

Tag all resources (cost modeling, filtering, etc.) -Deployment

The goal here is to enable filtering by tags in the AWS Cost Management tool, like this:

The goal here is to enable filtering by tags in the AWS Cost Management tool, like this:


web报错

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

我运行之后怎么是错误的

@cdliang11 , please help to figure out the problem.

To create a public link, set share=True in launch()
这个怎么实现呢

报这个错

我猜测是机器环境存在一些问题，换个机器尝试一下 :)


Arroseur (redpitaya on the web) is down

I still cannot connect to arroseur. Are we sure that ddns is still working?

i simply tried ssh arroseur.ddns.net

I believe the update of the dns that should run on my raspberry pi is down. I am working on it right now...

I think it should work now ?

Can you commit some whitespace to master to check it? Im getting off thr
train now..
On Jul 1, 2017 5:53 PM, "SamuelDeleglise"<EMAIL_ADDRESS>wrote:

I think it should work now ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

 Im getting off thr
train now..
On Jul 1, 2017 5:53 PM, "SamuelDeleglise"<EMAIL_ADDRESS>wrote:

I think it should work now ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

It seems to work now

arroseur is still down, so repo master branch still indicates "build failing" while the code is provably okay...


Ignore C-Reduce's backup files

r? @pepyakin

This is also rejects from git.
r=me
@bors-servo r+

:pushpin: Commit cd1af7c has been approved by emilio

:hourglass: Testing commit cd1af7cacf499706f173cf8e77cfb226abab8dea with merge 6a48ca9fe78c100f0bc9902747c4919cc5cafc43...

:sunny: Test successful - status-travis
Approved by: emilio
Pushing 6a48ca9fe78c100f0bc9902747c4919cc5cafc43 to master...

Thanks!


scripts/fetchDependency.ps1: fix vcpkg boostrapping with Powershell Core

Fixes #1080

Looks good! I retained the previous hash functionality for "Desktop" to support Win7 (Get-FileHash is available in powershell 4+).
Thanks!


Change request: Add two buttons to upload modal about multimaterial printing

Add two buttons "Yes" and "No" - Yes should be pre-selected. The Yes button should not change the current upload flow, meaning it should scroll down to materials.
If the customer selects "No", then we should keep the view in the top of the upload page with their models in view and ONLY select the first model uploaded.

Acceptance test failed!
When the user selects "No" we should NOT scroll them down to the bottom.
@dreampulse


The package structure should be improved

@clinuxrulz You wrote somewhere that you like the idea to follow roughly the Haskell structure, and I think this is a good starting point. I'll do this for Data, So e.g. Ord will go to org.highj.data.ord etc.
I'm not sure about the type-classes, those had to go under  org.highj.control when we want to follow the Haskell structure.
Further, I'll move all helper classes like Strings from the function package to util (at least for now)

Sounds good for org.highj.data.* for Data stuff. And we don't have to follow Haskell's layout exactly.


kivy language: propagate value updates when using f-strings

Python 3.6 allows use of f-string for formatting values:
'{}'.format(x)  # becomes
f'{x}'

In the kivy language, when the first format is used, anytime x is updated, so will be the value that uses it, e.g.
Label:
    text: '{}'.format(x)

If an f-string is used instead, only the initial x value is used and any updates to x are no longer reflected.
Label:
    text: f'{x}'

It'd be nice if it'd be possible to use f-strings and get the value updates propagated.

i believe this is a duplicate of #6108


undefined is unrecognized primitive?

why?

Can I get an example of what you mean?

It's an error throw when you try to compare value to undefined in template.
*ngIf="foo === undefined"

Tracking in https://github.com/angular/angular/issues/13412

Closed in 0.0.11


Use a modern and maintained Async analyzer

(and avoid reported issues with older analyzers)
I have used this in an ASP.NET Core 3.1/5/6 solution

@davidkallesen I have already done that - try:
gh pr checkout 68

and have a look

The suggested new analyzer Microsoft.VisualStudio.Threading.Analyzers is target towards running in Visual Studio including the constraints imposed by it. I don't see this as a all around analyzer.

After reading Async code smells and how to track them down with analyzers - Part I and Async code smells and how to track them down with analyzers - Part II
I think AsyncFixer is still relevante... and still not sure how vs-threading is dependent on Visual Studio

@davidkallesen agree - all three analysers are relevant! (I also found your link) - I will update the PR.

I might have expressed myself wrongly in regards to Microsoft.VisualStudio.Threading.Analyzers. What is was trying to say was that the rules enforce in this library are there to govern how you write VS extensions code. Please see FAQ here.

@LarsSkovslund I do not agree, some of the rules are generally useful, as mentioned in the blog post linked above.

Yes some of them are useful, but they will conflict with other async rules and/or suggest changes that are not appropriate for most projects unless you write Windows UI code. If we go through them one by one you will see these are target against STA/MTA issues or synchronizing with the UI thread.
@ErikEJ  would it be possible for you to point me in the direction of included rules that is not related to VS internals or UI programming (async void is in this category)?
If the primary use-case for this analyzer is when writing Windows UI code, this should only be included there and not as a general requirement for all project types.

@LarsSkovslund Sorry, I thought @davidkallesen had already linked to them above 😊 - https://cezarypiatek.github.io/post/async-analyzers-summary/ - as you can see in the summary there are 2-3 rules in the vs-threading rules that are useful. (You can always discuss each, for example VSTHRD200)

PR updated

Are you waiting for me to do anything here?


Wireless Connection Problems (10060)

Hello
I was able to mirror my Oculus Go to my PC using USB Cable and SCRCPY.
Now, im trying to mirror without the cable but im having a few issues. These are the steps that im doing:

Plug the Oculus to PC with USB cable;
Run CMD and cd to SCRCPY folder;
ADB Devices, * daemon not running, starting now at tcp:5037, *daemon started successfully;
Now my Oculus Go is listed as a device;
Time to run adb tcpip 5555;
adb shell ip addr show wlan0 to get the Oculus IP for connection;
adb connect IP_ADDRESS: 5555;
Then comes the error:
After a few seconds, returns 10060 error, translating the message: cannot connect to IP_ADDRESS:PORT, connection failed because connected component didnt awnser correclty after a period of time or the established connection failed because the connected host didnt respond.

I already did quite a few internet solutions, even ones i found here in Git.
Tryied another port, opened up in firewall for sure.
Another problem is the command "adb server", it returns "could not read ok from ADB Server * could not start server*".
Im i doing anything wrong? Did i missed something?

Is your OculusGo on the same LAN as your computer?
(could you give the actual local IP address of your computer and your Oculus Go?)

They are both connected to the same Wi-Fi Network.
The IP Address show by the command is <IP_ADDRESS> ( also appears a /24 by side with the adb shell ip addr show, dont know what is this).
The PC Address show by IPCONFIG is (IPV4) <IP_ADDRESS>.

I think there may be a problem with the adb server on your Oculus Go.
The steps you did seem correct: https://developer.oculus.com/documentation/mobilesdk/latest/concepts/mobile-adb/

Any tips about that?
I will look about it anyway, its good that i can do it by cable but using Wi-Fi would help me alot.


Filesystem-only routing

Use react-like router.
Router
<ce:UrlResolver name="person" columnName="url" propertyName="url" />

<!-- Router is lookless -->
<route:router>
    <route:directory path="persons">
        <route:file path="" identifier="personList">
            <!-- List of persons -->
        </route:file>
        <route:file path="new" identifier="personCreate">
            <!-- Create a new person -->
        </route:file>
        <route:file path="ce:url">
            <!-- Edit of existing person person -->
        </route:file>
        <route:file path="*">
            <!-- Fallback in persons -->
        </route:file>
    </route:directory>
    <route:directory path="organizations">
        <!--  -->
    </route:directory>
    <route:file path="*">
        <!-- Global fallback -->
    </route:file>
</route:router>

<div class="layout">
    <route:render />
</div>

Additional route name declaration
<!-- Declare a route -->
<route:declare name="organizationEdit" path="organizations/ce:url" />

Generating links/urls
<web:a pageId="route:personCreate" text="Create a new person" />

We have it. The only problem are dynamic URLs (with properties). Because properties will be processed before executing the tag. We may implement a mechanism to pass unparsed property to attribute, but in some cases we may benefit from passing in a dynamic value (aka property value).

The curreny router problem is that we are not able to create a "per directory" sub menu.
UC: We want to have a sub menu, rendered from layout template, but this sub menu is selected based on selected "directory" in URL.

Consider splitting router to a separate library - one for creating routes and one for router itself.
We may want to create a "path-only" router and "domain+path" router.


PP-1739 Open Sourcing

WHAT
This was already a public repository but didn't have a licence or other supporting information. Unlike the others the readme's API spec is fairly small so I am not moving this out into a docs/ folder yet.

There were no errors, go have a cup of coffee...

There were no errors, go have a cup of coffee...

There were no errors, go have a cup of coffee...


Fix Network Characteristics Autodetect [RDPBCGR 2.2.14]

Removed if statement that was causing network characteristics autodetect to not work correctly.
Network characteristics autodetect does not require GFX or the GFX channel to work properly, and this if statement was preventing autodetect packets from being sent/received properly.

@freerdp-bot test

+1 LGTM

LGTM too


Feature/lsp

use Either to reduce code duplication of CompactFormatter and PrettyFormatter. Create a method that returns Either<CompactFormatter,PrettyFormatter> and another one with the ColoredFormatter.
Another option is to create our own JsonFormatter enum with compact and pretty variants, and implement Formatter for that one. ColoredFormattershould wrap that JsonFormatter and call to the serialize_json function


Always Show Password Field on Link Account Sign-in Page

This PR is to fix #9066 and #8923 . Since the Password field will be disable by REQUIRE_EXTERNAL_REGISTRATION_PASSWORD = false in app.ini, there is noway for user to link external account since func LinkAccountPostSignIn bind with SignInForm. The detail is descried as below.

routers.go:306

m.Post("/link_account_signin", bindIgnErr(auth.SignInForm{}), user.LinkAccountPostSignIn)

LinkAccountPostSignIn binds with auth.SignInForm, which force password must exist with binding:"Required;MaxSize(255)".
type SignInForm struct {
	UserName string `binding:"Required;MaxSize(254)"`
	// TODO remove required from password for SecondFactorAuthentication
	Password string `binding:"Required;MaxSize(255)"`
	Remember bool
}

As the result, LinkAccountPostSignIn always redirects to register new account due to the context error:
func LinkAccountPostSignIn(ctx *context.Context, signInForm auth.SignInForm) {
// ...
	if ctx.HasError() {
		ctx.HTML(200, tplLinkAccount)
		return
	}
//...

Codecov Report

Merging #9147 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #9147      +/-   ##
==========================================
+ Coverage   41.07%   41.07%   +<.01%
==========================================
  Files         551      551
  Lines       71906    71907       +1
==========================================
+ Hits        29535    29537       +2
+ Misses      38641    38638       -3
- Partials     3730     3732       +2

Impacted Files
Coverage Δ

routers/user/auth.go
12.02% <0%> (-0.02%)
:arrow_down:

modules/log/file.go
75.52% <0%> (-2.1%)
:arrow_down:

models/repo_list.go
73.14% <0%> (-0.93%)
:arrow_down:

models/gpg_key.go
55.59% <0%> (+0.55%)
:arrow_up:

modules/indexer/indexer.go
55.26% <0%> (+10.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7523314...e1caa21. Read the comment docs.

ping LG-TM bot

@blueworrybear thanks for PR :) Could you send a PR to backport this against release/v1.10 branch?

@techknowlogick Sure! :smile:


update documentation on SCCs

@deads2k ptal

/assign php-coder

/assign

/assign enj

@stevekuznetsov @kargakis  how much trouble is it to have a bot?  Is it easier in a month?

/lgtm

@deads2k: changing LGTM is restricted to assignees, and assigning you to the PR failed.

Well, I have half a bot

/lgtm

You need to add the bot as a collaborator in the repo.

Write access is necessary for the bots


Problems should be releaseable with competitions

Like the old website, a newly minted problem should be able to be associated with a (future) competition, and should remain hidden until that competition starts.

It looks like we can solve this problem by doing another left join from the problems table to the comp_names table and checking to see that the current time is greater than the start time of the start time of the competition.

Well the real problem I was addressing was that a new problem is viewable in the global problem list. But you raise a good point: The competition page shouldn't link to the problems until the competition starts either.

So here's my thinking for this one: the way I see it this is two sub-tasks.

Problems associated with competitions that have not started should not be visible to a client
Once a competition starts, the previously hidden problems should now be visible

It seems like making one easier will make the other one more difficult. For instance, we could set competitions that haven't started yet to have a competition id that's negative of what it really should be, and the filter API calls to exclude problems that have a comp_release that's less than zero. The issues is switching those cid's back once the competition starts: it will require a time-based execution rather than our typical event-driven execution.
On the other hand, we can simply check if the competition associated with a problem has begun with the start times. This would relieve us having to make modifications at a competition start, but would require that every API call associated with a problem also looks at the competition table.
Thoughts?

Is this issue complete?


added create-setters function

The create-setters function declaratively adds comments to the node whose values match the values in the input config. This is an easy way to create setters.
Input package:
apiVersion: v1
kind: Deployment
metadata:
  name: nginx
  namespace: nginx-space
spec:
  image: apache:1.7.1
  environments: [foo, bar]
roles:
  - dev
  - pro

apiVersion: kpt.dev/v1alpha2
kind: Kptfile
pipeline:
  mutators:
    - image: gcr.io/kpt-fn/create-setters:v0.1
      configMap:
         name: nginx
         image: apache
         tag: 1.7.1
         roles: |
           - pro
           - dev
         env: "[foo, bar]"

Transformed Resource:
apiVersion: v1
kind: Deployment
metadata:
  name: nginx # kpt-set: ${name}
  namespace: nginx-space # kpt-set: ${name}-space
spec:
  image: apache:1.7.1 # kpt-set: ${image}:${tag}
  environments: [foo, bar] # kpt-set: ${env}
roles: # kpt-set: ${roles}
  - dev
  - pro

@NagaHarshita Thanks for contributing.
@karlkfi @mikebz This function will address the request in the issue https://github.com/GoogleContainerTools/kpt/issues/1375.
And in general, it provides a good declarative UX for all customers to add setter comments. Create-setters and apply-setters complete the circle.

FYI @yhrn @stefanhenseler

lgtm, please wait for @mengqiy to approve.


What UI Automation technology WinAppDriver is internally using?

Hi,
I'm new to this technology. I recently realized that there are very similar but different technologies documented in MSDN - one is  UIA3  and the other is UIA2 .
Which one is WinAppDriver is using? The UIRecorder's cpp code seems to suggest that it's UIA3. Is it true?
Thanks,
Thanks!

Automation part is black box to WinAppDriver. I guess it's UIA3. the best matched doc is https://docs.microsoft.com/en-us/dotnet/framework/ui-automation/ui-automation-overview
3.0 is introduced in Windows 7, and it's the successor to Microsoft Active Accessibility (MSAA), and I don't think WinAppDriver is calling MSAA

@licanhua
The link you provided is actually UIA2 that was added with .NET Framework V3.0 and is older than UIA3 that came as a part of Windows 7. The former is a managed library, while the latter is COM based. MSAA is older than those two.
I wonder if Microsoft will eventually make WinAppDriver open source.

About one year later ... I also wonder if WinAppDriver uses UIA2 or UIA3.


Desktop showed on top of windows

Desktop folders suddenly showed on top of windows. Everywhere i click on the screen forces focus on Finder. brew service restart yabai does not help. I have to restart Mac to fix it. Using yabai-v5.0.1.
yabairc:
yabai -m signal --add event=dock_did_restart action="sudo yabai --load-sa"
sudo yabai --load-sa

yabai -m config layout bsp
yabai -m config window_placement second_child
yabai -m config split_ratio 0.5
yabai -m config mouse_modifier fn
yabai -m config mouse_action1 move
yabai -m config mouse_drop_action swap
yabai -m config window_topmost on

I also encountered this today.

Should be fixed in latest version.


added static typechecking guide

Issue #76
Added "Static Type Checking" guide.

Thank you for this PR. I'm sorry it took me so long to review it. I have a couple of minor grammatical/wordsmithing nits that I'm going to just make myself so that I can merge the PR now while I have the time (so that I don't get distracted again). Hope that's okay! 🙇

Left a few comments for future reference. I'll edit this—just hoping it's useful for future readers. :-)

I feel like I kind of failed @ishankbahl with this PR, given all of the corrections Dan's making. I don't know much about create-react-app. Have never used it in depth. Was just trying to help keep PRs moving. ~shrug~

That's the right way to do it—merge something that's a good first step and then iterate. :-)
I rewrote these parts in https://github.com/reactjs/reactjs.org/pull/303 but wouldn't have done it if you both didn't start the ball rolling!


fix(): Check if memory is causing build image to fail.

limit image build parallelism
Reason for Change

#TICKET_NUMBER
If the reason for this PR's code changes are not clear in the issue, state value/impact

Changes

add
remove
modify

Testing steps

Either list QA steps or reasoning you feel QA is unnecessary
Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
"Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Checklist 🛎

[ ] Add product, design, and eng as reviewers for rdev review
[ ] For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
[ ] For UI changes, add e2e tests to prevent regressions
[ ] For UI changes, verify impacted analytics events still work

Notes for Reviewer

Fixed in https://github.com/chanzuckerberg/single-cell-data-portal/pull/6490


cargo fix breaks my build

My project runs cargo test with warnings, but successful, and if I run cargo fix, cargo test reports a build error
$ git clone https://gitlab.com/volkerweissmann/math_dsl_macro
$ cd math_dsl_macro
$ git checkout c19efa4fd2549185287c851ea9348a18f5eb461a
$ cargo test
  warnings but everything passes
$ cargo fix
$ cargo test
 compile error

Correct me if I'm wrong, but I don't think this is intended to ever happen. If it is intended, you can close this issue, if it's not intended, it's a bug

Seems right.
Maybe --tests should be enabled by default.

Here is a test in Cargo's testsuite form:
#[cargo_test]
fn fix_breaks_test() {
    // Checks what happens when a cfg-test-only fix interacts with non-test code.
    let p = project()
        .file("Cargo.toml", &basic_manifest("foo", "0.1.0"))
        .file(
            "src/lib.rs",
            r#"
                use std::path::Path;

                #[test]
                fn mytest() {
                    let _x = Path::new("foo");
                }
            "#,
        )
        .build();

    p.cargo("fix --allow-no-vcs").run();
}

This will randomly fail depending on the order the targets get processed.

Same issue, the best fix would be for cargo fix to move imports in the cfg(test) gated code, not sure how feasible it is.


Transfer ownership

Group#transferOwnershipTo(newOwner: string): Promise<Group>
Transfers ownership of a group to another user.
Usage:
const group = client.groups.cache.get('12345')
group.transferOwnershipTo('67890');

Apparently, the API only does change_owner requests in bulk for some reason. This is dumb, so the library will not reflect this bulk transfer operation. Instead, transfers will be done directly on Group instances and each call will only send one change_owner request, despite the API allowing for multiple to be sent at once.

I think this is already implemented?


Adding flag to hide refresh button in dashboards.

Now:

Before:

This PR fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.366%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
27568

Relevant Lines:
60824

💛  - Coveralls


boards: arm: nucleo_f756zg: Created new board nucleo_f756zg

Created board support for the nucleo_f756zg.
Features supported include:

GPIO
UART
ETH
USB
I2C
PWM
SPI

Codecov Report

Merging #10744 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10744      +/-   ##
==========================================
- Coverage   53.29%   53.11%   -0.19%
==========================================
  Files         215      215
  Lines       25827    25827
  Branches     5695     5695
==========================================
- Hits        13765    13717      -48
- Misses       9746     9800      +54
+ Partials     2316     2310       -6

Impacted Files
Coverage Δ

include/posix/posix_sched.h
0% <0%> (-100%)
:arrow_down:

lib/posix/pthread_barrier.c
0% <0%> (-100%)
:arrow_down:

lib/posix/pthread_cond.c
62.5% <0%> (-20.84%)
:arrow_down:

lib/posix/pthread.c
68.03% <0%> (-12.33%)
:arrow_down:

subsys/logging/log_core.c
76.05% <0%> (-2.35%)
:arrow_down:

lib/posix/pthread_mutex.c
76.38% <0%> (-1.39%)
:arrow_down:

subsys/logging/log_output.c
82.14% <0%> (-1.2%)
:arrow_down:

lib/posix/pthread_sched.c
62.5% <0%> (+20.83%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6063707...6541410. Read the comment docs.

Latest set of commits address documentation changes requested by @dbkinder and adds SPI support.

Latest commit rebased to pull the f7 pinmux definitions from now merged PR #10419.

Added default selection of ports gpio-f and gpio-g on selection of the gpio device driver for the stm32f756xg SOC family.

Latest commit rebased on master and makes changes requested by @erwango .

@ajpcode , please remove board.h and rebase.

@erwango - As requested file removed and rebased.

857bdc2 - It's been a little while since my last commit, push is just a rebase of branch on master.

^^@galak

recheck

Rebased to master.
Added Kconfig.defconfig changes made by now merged PR #11345. (Moved from 'def_bool' to 'default').
Also, shippable should re-run :)

Latest push:
Renamed UART_STM32_PORT_X entries in Kconfig.defconfig and pinmux.c to UART_X in line with commit id b1008cc (PR: #11234)

@galak, @erwango  - I've rebased once again and addressed all changes I can see that have been made to the similar nucleo_f746zg board (above comments describe).
I'm not sure this shippable error is within my control (which is the following repeated):
/home/buildslave/src/github.com/zephyrproject-rtos/zephyr/subsys/shell/shell_uart.c:232:23: error: CONFIG_UART_SHELL_ON_DEV_NAME undeclared (first use in this function)
    device_get_binding(CONFIG_UART_SHELL_ON_DEV_NAME);
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@apjcode, thanks for your patience and rebase efforts :-)
One thing you can do is adding 		zephyr,shell-uart = &uartX; in your board's dts chosen node.
Though, it also reveals that shell stuff should more be controlled and we should not be forced to define it.

@erwango - I've rebased and made the change as you suggest, I've gone with usart3 (same as the console).


owner can't contribute but user yes

when i try to add informations with my owner account, see picture.
When I try with my user account, it's ok.

From Guillaume AMAT on 2015-08-05 10:02:58+00:00
Owners can contribute, the user/owner status is not checked during the contribution process.
In think you you encountered the bug #64...
A good test would be to:

Open a private navigation window (ctrl+shift+p in Firefox, dunno in other browsers)
Go to Rudomap
Log in with your owner account
Contribute

If it succeed, we can close this ticket as wontfix ;)

From Vincent Bergeot on 2015-08-05 19:03:45+00:00
ok test is ok, but how can i contribute without open a private navigation window ?

From Vincent Bergeot on 2015-08-05 19:12:21+00:00
i close the tab, open a new one and it's ok, i can contribute.
but after a modification, it's impossible to change again for this POI. I must close again tab and open a new one :(
wontfix ?

From Vincent Bergeot on 2015-08-05 19:14:50+00:00
euh, now it seem's ok !!!
ok, wontfix


tokio_proto API surface update breaks tokio branch

I've been eagerly tracking the tokio branch with the tokio wip commits (because I am interested in both tokio and hyper).
Very recently (4 hours ago) there was a commit on the tokio_proto repo that drastically changed the tokio_proto API surface, and stopped me from being able to build my project.
I tried to modify the hyper/tokio source to match the new tokio_proto API, some changes were simple, but there are more complex changes that I couldn't handle myself without a deeper knowledge of both hyper and tokio_proto.
See the breaking commit here: https://github.com/tokio-rs/tokio-proto/commit/596005a36b5b5e28bb3a0a1690a8c71199c53f06
Edit: This is the source commit, it has more explanation about the changes: https://github.com/tokio-rs/tokio-proto/commit/9dc19d7705a51008b8c9d9d867cecbdc6a8a8ab4
From what I can tell, the basic changes are:
tokio_proto::{Message, Body} are changed to tokio_proto::streaming::{Message, Body}
tokio_proto::pipeline changed to tokio_proto::streaming::pipeline
tokio_proto::multiplex changed to tokio_proto::streaming::multiplex
tokio_proto::easy::multiplex changed to tokio_proto::multiplex
tokio_proto::easy::pipeline changed to tokio_proto::pipeline
tokio_proto::pipeline::server::listen no longer exists, I believe you must use tokio_proto::TcpServer with a tokio_proto::pipeline::ServerProto implementation.
That is as far as I got before I was beyond my depth.
What I will do for now (on my local system) is pin the tokio_proto package to the last commit before the API update: https://github.com/tokio-rs/tokio-proto/commit/b654c3317dd5fd25e61439eba888dfa9520f96d6

I started working on it as soon as I saw that PR was merged. It's fairly close, but I stopped for the night.

Thanks for jumping on it so quickly. I'm excited about this work.

I've pushed to the tokio branch with a working server. The client module is commented out, as I didn't have time to fix it, but many are probably more interested in the server, so I've got that working now.

I believe this can be closed now.


Circular dependency

When npm run dev and hot updates, a warning about "Circular dependency" appears in the log.
Started appearing after the last update of your package.

Thank you. I will fix this asap.

Should be fixed in 1.6.3

Should be fixed in 1.6.3

Everything is great, thanks man!


AGPUSH-971 : Advanced Analytics, Server Side implementation

This is the first step for the advanced analytics it contains :

Unique identifier added to the payload of each Push Message
Retrieving the identifier when an installation registers
Some basic calculation

The Admin console has a few updates but these are temporary since it will be replcaed by charts.
@matzew @edewit @lfryc Mind to take a look ?
ps: I wonder if that PR should also be merged into the new-ui branch to be able to move on with the chart integration ?

let me rebase now that we have arquillian support

window push sdk implementation https://github.com/aerogear/aerogear-windows-push/pull/7

Since this has impact on client development tasks, @danielpassos @corinnekrych can you review this PR and it's proposed APIs as well ?

Did another review, I think here is a list of open items that need to be done:

rebase afer JMS landed on master branch and leverage the MetricsCollector instead of new VariantMetricInformationDao on this PR
push identifier: docment it on the endpoint doc
request.getHeader("push-identifier"); header needs a different prefix (aerogear-notification-id)
first/last opened will stay as is, right ?
JavaDoc on NotificationSenderCallback
message.getMessage().getUserData().put("push-identifier",pushMessageInformation.getId()); needs to be done at outer/different/custom level - not on the envelope/payload (e.g. the user data)
pushMessageInformation.setAppOpenCounter needs atomicLong or AtomicRef

That looks like a good summary. I will make sure to adress all these points
this week.
On Tue, Apr 21, 2015 at 7:20 PM, Matthias Wessendorf <
<EMAIL_ADDRESS>wrote:

Did another review, I think here is a list of open items that need to be
done:

rebase afer JMS landed on master branch and leverage the
MetricsCollector instead of new VariantMetricInformationDao on this PR
push identifier: docment it on the endpoint doc
request.getHeader("push-identifier"); header needs a different
prefix (aerogear-notification-id)
first/last opened will stay as is, right ?
JavaDoc on NotificationSenderCallback

message.getMessage().getUserData().put("push-identifier",pushMessageInformation.getId());
needs to be done at outer/different/custom level - not on the
envelope/payload (e.g. the user data)

pushMessageInformation.setAppOpenCounter needs atomicLong or
AtomicRef

—
Reply to this email directly or view it on GitHub
https://github.com/aerogear/aerogear-unifiedpush-server/pull/523#issuecomment-94798929
.

"* message.getMessage().getUserData().put("push-identifier",pushMessageInformation.getId()); needs to be done at outer/different/custom level - not on the envelope/payload (e.g. the user data)"
Looking right now which should be the best place, the advantage of user-data is that we have that for all of our senders and we will be sure it's pickup up.

@sebastienblanc do we need that in the sender ?

@matzew well we could that anywhere as long we have a unifiedmessage instance and a PushInformation instance, the question is more where do we put it in the payload ?

I always thought that the UPS server assings the push notification ID - nobody else - therefore I don't see a need to expose that api to others (e.g. the sender)

should we close this one, for now ?

Ok let me close it until I fix the dbunit issues and that we agree on the counter design


non-case-sensitive owners search

Hello,
Should owners search by last name be non-case-sensitive?
Cheers,
Armagan

I made it case insensitive on my machine. Should I have a pull request? What do you think?

Hi Armagan, yes you could submit a pull request. Thanks


error: undefined reference to 'OryolAndroidAppState

when building android for custom app .. using ./fips build android-make-debug .. compiles properly but generates link error : full error
[ 99%] Linking CXX shared library android/libs/armeabi-v7a/libvxOryolSandbox.so
/Users/alexa/Repositories/vx/rnd/vxOryol/code/Modules/Gfx/egl/eglDisplayMgr.cc:174: error: undefined reference to 'OryolAndroidAppState'
/Users/alexa/Repositories/vx/rnd/vxOryol/code/Modules/Core/android/androidBridge.cc:57: error: undefined reference to 'OryolAndroidAppState'
/Users/alexa/Repositories/vx/rnd/vxOryol/code/Modules/Core/android/androidBridge.cc:95: error: undefined reference to 'OryolAndroidAppState'
/Users/alexa/Repositories/vx/rnd/vxOryol/code/Modules/Core/android/androidBridge.cc:126: error: undefined reference to 'OryolAndroidAppState'
Cheers,
Neshume

There was a mixup with the platform type and main.h was not imported properly.
Thank you and sorry for the bother.