Custom Logging Solution

Summary
Re-wrote the logging implementation to be driven by a custom class rather than a library.
We can now register logging hooks in a fashion similar to other hooks in the template. The Feature Loader is now aware of loggerHooks.
These Logger Hooks are actually "Destinations" for the logs themselves. The Logging class by default is not configured with any destinations, so the logs would essentially be forgotten. In addition to enhancing the template itself and its ability to load logging hooks - this includes a Feature that writes any logs to the console.
Anyone is now free to write additional features that can send logs anywhere you like!
Destinations
Destinations are classes that implement sending logs to a specific location. Destinations can be configured with a log level. It will ignore lower level logs than its configured minimum log level.
This means you could register a destination that was only interested in receiving errors, but not debug logs, etc.
Destinations extend an abstract class provided by this logging enhancement. Here is an example destination that sends all logs to the console! This is the actual implementation used by the feature added in this PR.
import { LogLevel } from '../../../utils/logger';
import Destination from '../../../utils/logger/destination';

export default class Console extends Destination {
  async handle(level: LogLevel, message: string, context?: object, meta?: object): Promise<void> {
    return new Promise((resolve) => {
      let additonalContext: object = {};
      additonalContext = Object.assign(additonalContext, meta, context);

      // if there is additional context, use it
      if (Object.keys(additonalContext).length) {
        console[level](message, additonalContext);
      } else {
        console[level](message);
      }

      return resolve();
    });
  }
}

Yes, you can still use console.log if you want
Developers using the template are still free to use console.log directly in their features - but I would recommend that after development is complete they switch to the logging library with appropriate log levels so that customers can configure where logs might go and what levels they are interested in.
Metadata and Context
In addition, our logger does support both metadata and context objects with its log messages. Metadata will be automatically appended to each log message. By default, we include the current worker sid and worker name to each log message when you use the logging library - but other forms of meta data would be possible.
Additionally, each Destination can be configured with its own metadata - or told to ignore all metadata entirely. For example, the console destination now ignores global metadata by default.
How to use
In most cases, migrating to this logger is easy. Consider the log:
console.log(`activity-reservation-handler: handle ${eventName} for ${task.sid}`);
Can now be written as:
import logger from 'utils/logger';
logger.log(`activity-reservation-handler: handle ${eventName} for ${task.sid}`);

The logger has methods for different log levels
import logger from 'utils/logger';

logger.debug('...');
logger.log('...');
logger.info('...');
logger.warn('...');
logger.error('...');

Adding Context
This logger supports adding additional context with your log message (string).
import logger from 'utils/logger';

logger.debug('This is my message', {task, worker});

Log Buffering
Because the feature-loader takes time and loads features in alphabetical order, its possible that features are writing logs before all the destinations have been loaded from all other features. In order to ensure that these messages are not missed, the logger now buffers messages while there are no destinations configured. Upon completion of the feature-loader process the log will attempt to flush these buffered messages to all configured destinations.
Checklist

[x] Tested changes end to end
[ ] Updated documentation
[ ] Requested one or more reviewers

This is an excellent addition, I love it.
The only thing I can think of, do we need a special consideration for the remove-feature script though when removing this feature?

That's a fair point. While it wouldn't be catastrophic, it would prevent the remaining feature's logs from working. I see a couple ways around this:

Exclude the feature from the remove-features script
Bundle the console logger with the template as a util rather than as a feature
Do nothing from the code perspective, and document "features you might want to keep" in the remove-features script doc.

Yeah I think the best option is to consider this as part of the template rather than a traditional feature. In that sense the documentation should align with that.
I think we still need to update the remove features script to actively ignore it then.


Support open-telemetry

Trace integration
Metrics integration

Hi, is there any updates about this feature? We're using pulsar in prod and we eagerly want this feature. I'm willing to impl this if possible, any idea?

Pulsar should specify it's own constants for open-telemetry similar to what is specified for kafka here
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/messaging.md


Admission scenarios screen (EXPOSUREAPP-11751)

Changes

Admission scenarios screen
Update admission scenarios and selectedScenario Id after selection
Trigger DccWalletInfo calculation
Suppress Error per person calculation to continue for other persons
Screenshots

TODO

[ ] unit tests

Ticket
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-11751

Looks good to, tested it
The popup seems to be dismissed right away as the calculation is fast. Maybe we can drop it if displaying it is slower than the calculation, but that would be an enhancement

That is right for a few person certificates ,but in case there are many persons we need the indicator and maybe in the future Configuration will change and do more work. let us keep as in Figma


fix lldb debugger for ubuntu distros

Add out the box support for lldb on ubuntu distros.
Have run the lint and unit tests.
Again, python not my strong suit, appreciate any feedback on this.
I avoided using the python 3,x approach as wasn't sure if it would be supported on both 2.7 and 3.x.
happy reviewing
Tom

The comment at the bottom of the path creation block is an optional one liner. I read somewhere that writing raw paths in strings is bad juju in terms of style/guidelines. Even though this particular piece of code should only fire on linux distros, I thought it best to use the idiomatic approach.

Thanks for the patch.  For reference, this is in relation to https://bugs.launchpad.net/ubuntu/+source/llvm-toolchain-6.0/+bug/1776208 right?
I've got a few code nits which I'll comment on in a sec, but my main concern is that this is very specific to one specific version of llvm, so if the same issue happens with the llvm-7.0 package, then it's not going to work, and may even silently cause us to silently end up using the 6.0 interface when we think we're using 7.0.
I'm wondering if a better solution would be to accept '--lldb-python-path' as an option in dexter and use that in preference to the one determined by querying the lldb executable if specified.  What do you think?

Nits added, but I think I'd rather go with the approach of letting the user override the path from the command line, unless you strongly disagree, in which case we'll need to figure out how to genericise this.

Dropping this PR, it's no longer a blocking issue for me and seems there wasn't much appetite for it (and rightly so I think).
Cheers
Tom W


 I created the model without adding stuff, and could…

…n't figure out how to start over. In retrospect I should've just answered the questions with the code anyway instead of worrying about the database, since I am confident that I knew the answers. I guess I'll try this one again.

Yeah, this was not your best. You need to not let yourself get stuck on one problem like that; you only have about a half-hour on average for each of these assessments, which adds up to about 5 or 6 minutes  per question. If you're not getting it after 2 or 3 minutes, drop it and move on.

I definitely agree that you should re-submit this one; let me know when you do so that I can give you feedback.


🐛 iOS | Leaderboard displays incorrect information

Steps to reproduce:

Open the Leaderboard page. The This Month list is displayed.
Switch to either This Year or All Time list
Switch back to This Month list

Expected result:
The This Month list from step 1 is displayed
Actual result:
Some information from the list selected on step 2 is still displayed. It's gone if you scroll down and back.
On the video below points for Camilla are incorrect.
https://github.com/SSWConsulting/SSW.Rewards.Mobile/assets/123032112/45f8fdcb-3dc4-4549-ae0c-d3313c58aeb1

Hi @AntPolkanov, this issue appears to have been resolved in the most recent build. Can you please confirm?
Can you confirm when you observed this? I think it's either something that was fixed in this commit, or if not could be a fix in .NET 8 (https://github.com/dotnet/maui/pull/15831).

Confirmed as resolved by me, @AntPolkanov, @sethdailyssw and @ricksu978


Need project/package changes list for Pilot

Somehow, we need to show changes in the image made to packages and projects.  This could use the existing McPatch support in Jade for packages or we can do string diffs.

Package level changes seem to be working. Closing in favor of #85.


Fix type error no handleDate function

Status
READY
Description
Close #85
Impacted Areas in Application
List general components of the application that this PR will affect:

Handler

Upon quick review, I am rather certain we require one change of this PR.
Please make it that options.handleDate MAY be passed in AND is used if it is passed in. Otherwise use built in function.
Thank you for including unit tests. Perhaps you could cover the above requirement in a test please and thank you

New changes look good by eyes 👀
Expect merge within two days to allow a little time for additional participation and for me to actually checkout code, build, test, merge, and publish
Thank you much from everyone

I've noticed that I haven't committed the changes in the dist folder, I should update it too, right?

I believe  npm run build should populate the dist folder and the commit. Either way I would get it when I do my steps plus increase package version

I have merged this PR. I will publish within two days @kaue or anyone else to chime in, in case I myself missed anything here

Was this published? I'm still having the issue.

You are having “@types” typings issues in #89 and you are trying to push for attention by calling out this PR unrelated PR with relatable keywords.
This package runs on donated time. Please proceed with great care into our time. Again, I believe “@types/jsonexport” is who needs to be dealt with. Long term, this package should be built on .ts files casted into .js files which would drop the need for an “@types” package.


custom layers

I am currently testing whether I should switch from tfSlim to your layers. There something I cannot figure out. The minimal example is:
from tensorpack import *
import tensorflow as tf

tf.reset_default_graph()

@layer_register()
def revReLU(x):
    return -1 * tf.nn.relu(x)

a = tf.Variable(tf.random_normal([8, 224, 224, 3], stddev=0.35), name="a")
b = (LinearWrap(a).Conv2D('b', 8, 7, stride=2, nl=tf.identity))()
c = (LinearWrap(a).Conv2D('c', 8, 7, stride=2, nl=tf.identity).revReLU())()

sess = tf.InteractiveSession()
sess.run(tf.global_variables_initializer())
print sess.run(b).shape
print sess.run(c).shape

When I put "revReLU" into the modules directory everything works as exected. But when using layer_register in the actual script LinearWrap cannot use it.
revReLU is just for demonstration.

I didn't make linearwrap to work with custom layers. Will try to fix that.

Note that by default a layer should be under some variable scope as the first argument, just like Conv2D. So you should call it with: revReLU('relu', x). And in LinearWrap this becomes .revReLU('relu').
You can register it with @layer_register(use_scope=False) to disable the scope.
In your case you don't have to register it as a layer to use LinearWrap. You can use apply.
def revReLU(x):
    return -1 * tf.nn.relu(x)
#....
c = (LinearWrap(a).Conv2D('c', 8, 7, stride=2, nl=tf.identity).apply(revReLU))()


feat(apps): scale / deploy run all process types in parallel instead of sequantially

This also moves the restart function to use api.utils.async_run  - it is a slightly modified version of the original to be exception aware and not require an internal function
Eventually I may move us to use https://github.com/observerss/aioutils but right now that is not required

Current coverage is 85.38% (diff: 97.91%)

Merging #938 into master will decrease coverage by 0.01%

@@             master       #938   diff @@
==========================================
  Files            30         30
  Lines          3062       3073    +11
  Methods           0          0
  Messages          0          0
  Branches        513        517     +4
==========================================
+ Hits           2615       2624     +9
- Misses          296        297     +1
- Partials        151        152     +1

Powered by Codecov. Last update 43354be...39cde37

Getting https://github.com/deis/controller/pull/939 reviewed first but getting a review on this would be good. The first commit is the what this PR is all about


Some bugs with random module of Numpy

Environment data

VS Code version: XXX
Extension version (available under the Extensions sidebar): XXX
OS and version: Windows 10
Python version (& distribution if applicable, e.g. Anaconda): Anaconda 5.0.1
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
Relevant/affected Python packages and their versions: XXX

It seems that this python plugin have some problem with random module of numpy. The code runs fine but the warning bother me a little.

This should be fixed in the latest release of the extension.


discuss adding in getSingleDrugCohort into study package

Its up to users to get cohorts they want ready for cohort symmetry but we could help them by giving them a really useful function that @xihang-chen has written
getSingleDrugCohort <- function(cdm, drug, table_name, start_date, end_date){
drug_name <- list()
for (i in (1: length(drug))){
if (drug[[i]][2] == "ingredient"){
drug_name[[i]] <- getDrugIngredientCodes(cdm = cdm, name = drug[[i]][1])
} else {
drug_name[[i]] <- getATCCodes(cdm = cdm, name = drug[[i]][1], level = c(drug[[i]][2]))
}
}
conceptSet <- c()
for (i in (1:length(drug_name))){
conceptSet <- c(conceptSet, drug_name[[i]])
}
cdm <- generateDrugUtilisationCohortSet(
cdm = cdm,
name = table_name,
conceptSet = conceptSet,
cohortDateRange = as.Date(c(start_date, end_date))
)
return(cdm)
}

Would this live here or could it even be in drug utilisation itself? Seems a nice type of function for drug utilisation right @catalamarti?

A similar function that would be very useful is if we could restrict a drug cohort to a partcular cohort, for example a condition cohort. PSSA would be beneficial from this because often one wants to see the prescription cascade in a particular condition population.
Provisionally I have something like this:
singleDrugCohortConditionStrata <- function(cdm,
outcome_table_name,
condition_cohort_table,
condition_cohort_name,
drug_cohort_table,
gap_before,
gap_after){
if(gap_before == Inf){
gap_before <-<PHONE_NUMBER>99999999999
}
if(gap_after == Inf){
gap_after <-<PHONE_NUMBER>99999999999
}
cdm[["condition_cohort_temp"]] <- cdm[[condition_cohort_table]] %>%
dplyr::inner_join(attributes(cdm[[condition_cohort_table]])$cohort_set, copy = T, by = "cohort_definition_id") %>%
dplyr::filter(cohort_name == condition_cohort_name) %>%
dplyr::select(cohort_definition_id, cohort_name, subject_id, cohort_start_date, cohort_end_date) %>%
dplyr::compute()
cdm[["drug_cohort_temp"]] <- cdm[[drug_cohort_table]] %>%
dplyr::inner_join(attributes(cdm[[drug_cohort_table]])$cohort_set, copy = T, by = "cohort_definition_id") %>%
dplyr::select(cohort_definition_id, cohort_name, subject_id, cohort_start_date, cohort_end_date) %>%
dplyr::compute()
cdm[[outcome_table_name]] <- cdm[["condition_cohort_temp"]] %>%
dplyr::rename(condition_cohort_id = cohort_definition_id,
condition_cohort_name = cohort_name) %>%
dplyr::inner_join(cdm[["drug_cohort_temp"]] %>% dplyr::rename(drug_cohort_name = cohort_name, drug_start_date = cohort_start_date, drug_end_date = cohort_end_date), by = "subject_id") %>%
dplyr::mutate(gap_to_drug = cohort_start_date - drug_start_date) %>%
dplyr::filter(-gap_before <= gap_to_drug & gap_to_drug <= gap_after) %>%
dplyr::select(-cohort_start_date, -cohort_end_date, -gap_to_drug) %>%
dplyr::rename(cohort_start_date = drug_start_date,
cohort_end_date = drug_end_date) %>%
dplyr::compute()
return(cdm)
}
I reckon this is similar to the original post but I doubt it should live in DrugUtilisation. Maybe either:

have it as a separate function in CohortSymmetry
Embed it when we eventually have a function that does disease strata in CohortSymmetry.

@xihang-chen once we release CohortConstructor I think you´ll be able to use this function https://github.com/oxford-pharmacoepi/CohortConstructor/blob/main/R/requireCohortIntersectFlag.R, although maybe we´ll need to adapt it?

close as this is now #96


Is command "since:2023-01-10" working ?

Hey boss ! Thank you for your amazing work
When I use
go run main.go -Query nasa since:2023-01-10
It still gives me tweet from January 09 or random times
Again when I use :
go run main.go -Query nasa within:
go run main.go -Query tezos within_time:1d
I get tweets like made 3 months before or 5 months
If you could bring a fix for that ?
Thank you so much !

Hi,
I think there was an error on how inputs were parsed. May you can now, please? I see no errors on my end.
Thanks

Hi I got same issue when I input:
go run main.go -Query "control AND adaptive" since:2022-12-02 until:2023-04-11 -Instance nitter.moomoo.me -Format csv > ControlAdaptive.csv
It returns the results from the last three months

Hi,
I think there was an error on how inputs were parsed. May you can now, please? I see no errors on my end.
Thanks

Hi I got same issue when I input:
go run main.go -Query "control AND adaptive" since:2022-12-02 until:2023-04-11 -Instance nitter.moomoo.me -Format csv > ControlAdaptive.csv
It returns the results from the last three months


Confirm Content from old Wiki is in new Pages - Challenges with Code Coverage

https://github.com/SFDO-Community/declarative-lookup-rollup-summaries/wiki/Challenges-with-Code-Coverage

Exists here: https://sfdo-community-sprints.github.io/DLRS-Documentation/Architecture/code-coverage.html


Update the version of chef-server in Automate

Latest greatest is 14.6.32.
https://github.com/chef/automate/issues/5371

https://github.com/chef/chef-server/pull/2775

14.9.23 release should resolve all the chef-server issues in Automate environment. Yet to create a PR in automate.

Blocked. Currently fails in dependency resolution for core/glibc and core/linux-headers. https://buildkite.com/chef/chef-automate-main-verify-private/builds/18338#8564bacc-6dce-4457-a01a-3de0f5282a6a/689-1048

Also as part of this, we need to add --skip=headers while running pedant. https://github.com/chef/chef-server/pull/2815#discussion_r730586966

The latest chef-server has the pg13, but automate is still not updated yet. The changes for the current latest 14.10.23 are ready in the PR - https://github.com/chef/automate/pull/6183

Dependencies issue - The automate component dependencies were moved to stable2021-q2 from stable channel of the habitat. chef-server component dependencies were still using stable channel, because of this we had the dependency issue.
The automate pipeline is failing because the erchef and nginx components are CRITICAL, but working in dev environment.
Data collector issue - The data_collector is enabled Automatically in the automate-cs-oc-erchef but the URL is not working so CS is sending the status as  fail due to CS is not able to send the data to the defined URL in configuration. We can disable the data collector.
chef-server-ctl issue - We are not able to run chef-server-ctl commands in the dev environment. getting the following error - Could not find rake-13.0.6 in any of the sources Run bundle install' to install missing gems.. Bundle install is failing with the error bash: bundle: command not found.

Status -
Upgrade migration is failing in the automate after updating the CS version.
Pipeline - https://buildkite.com/chef/chef-automate-main-verify-private/builds/19525#054129b7-9376-4041-9da3-d68d39d8ac1b
This is failing with sqitch error.
Dec 10 06:51:00 a1-migration.test hab[4747]: pg-sidecar-service.default(O): Cannot find change 4168bd129204d3c9137179a5e52173ffa07476bc (cookbook_versions_cookbook_id_index @1.0.4) in /hab/pkgs/chef/oc_erchef/14.11.1/20211124104838/schema/baseline/sqitch.plan
Dec 10 06:51:00 a1-migration.test hab[4747]: automate-pg-gateway.default(O): <IP_ADDRESS>:36610 [10/Dec/2021:06:51:00.380] postgresql automate_postgresql/<IP_ADDRESS> 1/0/29 4488 SD 65/65/64/64/0 0/0
Dec 10 06:51:00 a1-migration.test hab[4747]: pg-sidecar-service.default(O): time="2021-12-10T06:51:00Z" level=error msg="failed to deploy sqitch" action=deploy_sqitch conn_info="postgresql://automate@<IP_ADDRESS>:10145/<database>?sslmode=verify-ca&sslcert=/hab/svc/automate-postgresql/config/server.crt&sslkey=/hab/svc/automate-postgresql/config/server.key&sslrootcert=/hab/svc/automate-postgresql/config/root.crt" db=automate-cs-oc-erchef db_database=postgres error="exit status 2" sqitch_dir=/hab/pkgs/chef/oc_erchef/14.11.1/20211124104838/schema/baseline user=automate

These are not creating the issues in the fresh install but failing in the upgrade It seems.
need investigate more on this.

https://github.com/chef/automate/pull/6183


Kill terminal command doesn't work anymore

Regression in today's build
{ "key": "ctrl+shift+x",     "command": "workbench.action.terminal.kill" }

The kill command is being registered twice which overwrites the first one.


helm 2.4.1 ignores --home option

on ubuntu 16.04
helm home --home somedir
still returns default user home directory
HELM_HOME=somedir helm home
works fine

@adamreese

#2476 resolves this. We should probably put that into 2.4.3 and release it this week.

Closed by #2476


HTML5. NPE in CanvasGraphics.playCommands

Sometimes I've got exception:
Uncaught TypeError: Cannot read property 'x' of null
openfl__$internal_renderer_canvas_CanvasGraphics.playCommands
openfl__$internal_renderer_canvas_CanvasGraphics.endFill	openfl__$internal_renderer_canvas_CanvasGraphics.hitTest
openfl_display_Graphics.__hitTest
$extend.__hitTestMask	//From openfl_display_DisplayObject
$extend.__hitTest	//From openfl_display_Sprite
$extend.__hitTest	//From openfl_display_DisplayObjectContainer
$extend.__hitTest	//From openfl_display_Sprite
$extend.__hitTest	//From openfl_display_DisplayObjectContainer
$extend.__hitTest	//From openfl_display_Sprite
$extend.__hitTest	//From openfl_display_DisplayObjectContainer
$extend.__hitTest	//From openfl_display_Sprite
$extend.__hitTest	//From openfl_display_DisplayObjectContainer
$extend.__hitTest	//From openfl_display_Sprite
$extend.__hitTest	//From openfl_display_DisplayObjectContainer
$extend.__hitTest	//From openfl_display_Sprite
$extend.__hitTest	//From openfl_display_DisplayObjectContainer
$extend.__hitTest	//From openfl_display_Sprite
$extend.__hitTest	//From openfl_display_DisplayObjectContainer
$extend.__hitTest	//From openfl_display_Sprite
$extend.__hitTest	//From openfl_display_DisplayObjectContainer
$extend.__hitTest	//From openfl_display_Sprite
$extend.__hitTest	//From openfl_display_DisplayObjectContainer
$extend.__hitTest	//From openfl_display_Sprite
$extend.__hitTest	//From openfl_display_DisplayObjectContainer
$extend.__hitTest	//From openfl_display_Sprite
$extend.__hitTest	//From openfl_display_DisplayObjectContainer
$extend.__onMouse	//From openfl_display_Stage
$extend.onMouseMove	//From openfl_display_Stage
$extend.onMouseMove	//From lime_app_Application
f
(anonymous function)	//lime_app_Application in createWindow in window.onMouseMove.add
lime_app_Event_$Float_$Float_$Void.dispatch
lime__$backend_html5_HTML5Window.handleMouseEvent

in
openfl__$internal_renderer_canvas_CanvasGraphics.playCommands = function(commands,stroke) {
	if(stroke == null) stroke = false;
	openfl__$internal_renderer_canvas_CanvasGraphics.bounds = openfl__$internal_renderer_canvas_CanvasGraphics.graphics.__bounds;
	var offsetX = openfl__$internal_renderer_canvas_CanvasGraphics.bounds.x;  //bounds is null
        ...

I've run into this as well, and opened a thread on the OpenFL forums: http://community.openfl.org/t/crash-in-canvasgraphics-playcommands/7598

Sometimes I've got exception:

So that doesn't happen everytime?

Sometimes I've got exception:

So that doesn't happen everytime?

Not for me. In my case, we couldn't find concrete repro steps, but the repro rate was high.
The cases always seemed to involve a Sprite that used graphics.drawRect() to fill the screen (I can't confirm that that object was to blame, but it was often present when the issue occurred). We were adding and removing objects to/from the display tree in MouseEvent handlers; my hypothesis was that that played a factor in the issue occurring, but I couldn't find more info to confirm/disconfirm that.
We were able to workaround the issue, as described here: http://community.openfl.org/t/crash-in-canvasgraphics-playcommands/7598/2

We had another (unconfirmed) hypothesis that https://github.com/openfl/openfl/issues/1100 may have indirectly caused this.


Improving Github docker registry logging

As the title.
Now don't use env vars, only secrets and actions.

@akaszynski  I'm forcing the merge. Please feel free to have a look anyway.


use labels instead of is_a? to determine whether nodes are of appropriate type

This solves https://github.com/neo4jrb/neo4j/issues/717.
Rails reload! method was bumping heads with the @model instance variable in QueryProxy. I can't totally pin down why, will need to look at it more another time. In the meantime, this skips around the problem by just using labels to determine whether nodes are of the appropriate type.
No new tests, this is too specific to Rails and it doesn't add anything new, it ends up in the same place using existing methods.

Oh, interesting, that probably makes sense.  If I had to guess, reload! is probably destroying the constant and then creating it over again which would explain why it's two different objects


tests: drivers: regulator: support PCA9420 in voltage levels test

Add support for the PCA9420 present on the RT685 EVK to the regulator voltage levels test. Only LDO1 and LDO2 are enabled, as these are the only regulators that can be reconfigured without the SOC voltage dropping too low.
~Depends on #53224 (earlier commits in this PR are from there and will be dropped)~

oops, forgot you need to add a new entry for this board in testcase.yaml.

Thanks, fixed. Also swapped the order of the regulators tested on the RT685, as it appears LDO1 will more reliably hit a requested voltage target if LDO2 is first dropped from 3.3V to 1.8V.


Custom schedule entries individually removable.

One might want to individually remove schedule entries rather than go to settings and delete all.

My fault, they are already removable by long tapping on the event.


Postmark 1.0.2 Plugin not working with Kanboard 1.0.28

Installing the postmark plugin in the Kanboard 1.0.28 renders kanborad unavailable.  All we requeust to the system yeild 500 error.  page isnt working error.
Steps to reproduce

cd /var/www/html/kanboard/plugins
sudo wget https://github.com/kanboard/plugin-postmark/releases/download/v1.0.2/Postmark-1.0.2.zip
sudo unzip Postmark-1.0.2.zip
sudo rm Postmark-1.0.2.zip

Configuration
Application version: 1.0.28
PHP version: 5.5.9-1ubuntu4.16
PHP SAPI: apache2handler
OS version: Linux 3.13.0-86-generic
Database driver: postgres
Database version: 9.3.12
Browser: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36

Installed Plugins.
Name	Version
Sendgrid	1.0.3
Slack	1.0.3
Timetable	1.0.7
Subtask Forecast	1.0.1
Budget Planning	1.0.7

Can you get the exact error message from your Apache logs? Thanks


Expand website tests

We have the testing tools preinstalled, but don't use them yet. https://legacy.reactjs.org/docs/test-utils.html

superseded by e2e tests


Application mail password reset & email change

Won't work out of the box. Not sure if I should integrate this into the simplified installer or not.
Don't want to end up with too much fields either (Mailserver host, email address, password, optional port)
Could move email credentials to /../security.php and force a no-reply@ setting (fewer field)
This still urges user to create mail user straight away..
Making mailing work with same mailserver on installed webserver:

Create the user<EMAIL_ADDRESS>note your settings. (yourdomain.ex must match your website address)
In /src/Data/UserDAO.php  match these settings on lines 295, 298 and optinally 300 (SMTP port)

Good practice might be to troubleshoot your<EMAIL_ADDRESS>first without the application. Can you send/receive?

Moved mail settings to app/config/config.php as well.

Moved mail settings to app/config/config.php as well.


The Watchtower Sign—A Longtime Brooklyn Landmark

https://www.jw.org/en/jehovahs-witnesses/activities/bethel/watchtower-sign-brooklyn-landmark/


Edit dg

Codecov Report

Merging #155 (8b3f980) into master (3f57761) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #155      +/-   ##
============================================
+ Coverage     67.47%   67.51%   +0.03%
  Complexity      564      564
============================================
  Files           104      104
  Lines          1891     1890       -1
  Branches        208      208
============================================
  Hits           1276     1276
+ Misses          544      543       -1
  Partials         71       71

Impacted Files
Coverage Δ
Complexity Δ

.../java/seedu/address/model/util/SampleDataUtil.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f57761...8b3f980. Read the comment docs.


wip: falco-driver-loader improvements

What type of PR is this?
/kind documentation
/kind feature
Any specific area of the project related to this PR?
NONE
What this PR does / why we need it:
It lets users specify a custom DRIVER_NAME getting it from the environment. It can be useful when the user has a Falco kernel-module with a different name (eg., falco_probe) from the current default one (ie., falco).
This way (DRIVER_NAME=falco_probe falco-driver-loader module) it will look for a kernel module (via lsmod) named falco_probe and remove it (rmmod).
Furthermore, the module should also be removed from dkms. WIP for this reason.
Last but not least, for debugging and clarity purposes, this PR make the falco-driver-loader script aware of the Falco version it has been built for.
And outputs it at:

runtime time
help/usage time

Which issue(s) this PR fixes:
Fixes #1486
Special notes for your reviewer:
/cc @leogr
/cc @fntlnz
Does this PR introduce a user-facing change?:
new: falco-driver-loader script can get a custom driver name from DRIVER_NAME env variable
new: falco-driver-loader know the Falco version

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leodido after the PR has been reviewed.
You can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.27.0

Thank you for this PR. We definitely need that :+1:
Although specifying a custom DRIVER_NAME can be useful for various reasons, I believe it's not the best way to clean up old drivers since:

the script will then try to insmod/modprobe with the given DRIVER_NAME
the script does not have action only to remove the driver

Thus, as discussed privately, I believe it worth adds just a specific cleanup command for the old falco_probe that we don't use anymore. I will work on that.

Yep, that's the reason this PR is WIP @leogr :)
As discussed privately, we probably need to add 3rd action to the script (eg., falco-driver-loader clean)

Yep, that's the reason this PR is WIP @leogr :)
As discussed privately, we probably need to add 3rd action to the script (eg., falco-driver-loader clean)

That's ok for me too. But, do we still want a simple clean-up for falco_probe that runs always?

That's up to us to decide.

Ok, let's do this step-by-step.
So I can work on the clean action since I believe we all agree on that.

Yes, we all agree on that. As also discussed privately. :)
Then, we could also think about how to make the upgrade process straightforward even if the driver name changes again.

Yes, we all agree on that. As also discussed privately. :)

Done by https://github.com/falcosecurity/falco/pull/1488/commits/aa892e498c358e4c02d38b4b06c222a37b872431 :)
It's the first draft anyway, so PTAL.

Then, we could also think about how to make the upgrade process straightforward even if the driver name changes again.
And, given that a new kernel module name change is very unlikely: if it's worth.

:+1:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please ask for approval from leodido after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: c7883d2b3b5513cff0688e4579695580d2e57cb7

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


code de-duplication, unification, and minor fixes

don't use FMAX when calculating the maximum payload length
use raw-strings for all OS input (args, env, paths)
make onum() independent from the value in FBITS
with readdir(), distinguish between EOF and error
fix size calculation in count_cmdlinearg_words()

Good cleanups and fixes.
One less than obvious thing to keep in mind related to these changes: The amount of memory used by a bytecode sequence is assumed to be bound, because the GC is triggered at each entry to a function. Therefore, if you attempt to allocate more memory at once, say, for a raw string, you may end up writing past the end of the heap and segfault.
This is a temporary issue before the memory bounding is done automatically at compile time and an instruction with the bound is added at the beginning of a bytecode block where the bound is higher than the default one.


README updates for Sage 10

This updates the README to reflect changes made for Sage 10.

Switches references to Laravel Mix to Bud.

I am using the Netlify URL for the docs. Not sure if we want to change this.

While jQuery still works in Sage since it works in WordPress, I removed the mention of it as a feature.

@retlehs I had added a few of these things to the 10 release checklist, but I figured I could update them myself. The only thing I haven’t do is remove or change the whole composer create-project thing. Is that how we still want to recommend installing Sage?

@knowler thank you 🙏
netlify URL is good until https://github.com/roots/bud/issues/683 lands, removing the mention of jQuery is good  :+1:
the mention of browsersync needs to be removed, maybe @kellymears / @QWp6t have thoughts on specific verbiage to use instead
keeping the composer create-project instructions sounds good to me for now. i think now would be a good time to land #2700 as well.

21c1eb2 @retlehs I removed the Browsersync mention and changed the Bud description to just use its tagline from the website.


Not stable work with multiple instances of chipmunk

Prerequisites
affected version: 1.20.13
make sure to check this before filing an issue:

[x] I am running the latest version
[x] I checked the documentation and found no answer
[x] I checked to make sure that this issue has not already been filed

Expected Behavior
Whole functionality (filters, search etc) should work as well
Current Behavior
If a few instances are running:

Filters are not applied
No way to colorize the lines
Open dialog only offers files with the ending *.txt

Steps to Reproduce

Open at least two instances of chipmunk
Try to do regular activities (search, storing filters, coloring)

Context

Operating System: Ubuntu 19.04

Here is my logfile:
logviewer.log


feat!: fix non-functional custom RSC component handling, separate label and description props, fix non-functional label function handling

Description
RSC Custom Components fix
The goal for custom components is to pass in payload if they are server components. This never happened, as our logic for detecting RSCs was broken. This is now fixed.
Additionally, the BeforeLogin and AfterLogin custom components are now handled properly, which allows us to inject the payload prop into them if they are RSCs.
Labels fix
Currently, admin.description (for fields) can be a

string
function (with t as argument) which returns string
Client Component
RSC

The problem: there is no reliable way to discern between functions and RSCs.
If it is a function returning a string, we want to insert it as text into the default Description component.
If it is a RSC, we want to completely replace the default Description component.
Solution: We have separated the props
We already have admin.components. So we split up admin.description into:
admin.description - now only accepts string or function returning a string
admin.components.Description - accepts RSC or Client Component
More details on the specific changes are in the breaking changes list.
Additionally, the globalConfig.admin.description and collectionConfig.admin.description functions now have access to the t prop.
Broken i18n label functions

This used the sanitized field name (Url) as the label, as fields:enterURL was never resolved. So yea, any custom label function which used the t function like that did not work.
Breaking Changes

Globals config: admin.description no longer accepts a custom component. You will have to move it to admin.components.elements.Description
Collections config: admin.description no longer accepts a custom component. You will have to move it to admin.components.edit.Description
All Fields: field.admin.description no longer accepts a custom component. You will have to move it to field.admin.components.Description
Collapsible Field: field.label no longer accepts a custom component. You will have to move it to field.admin.components.RowLabel
Array Field: field.admin.components.RowLabel no longer accepts strings or records
If you are using our exported field components in your own app, their labelProps property has been stripped down and no longer contains the label and required prop. Those can now only be configured at the top-level

[ ] I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

[ ] Chore (non-breaking change which does not add functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Change to the templates directory (does not affect core functionality)
[ ] Change to the examples directory (does not affect core functionality)
[ ] This change requires a documentation update

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

Other than my one small comment about the type name, this looks really good 👍 I'm excited about this change and the fixes you've caught here


react/mysql hard-depends on old react/socket version

Because react/mysql depends on a specific old minor version of react/socket (0.4), its not possible to use it in projects that depend on libraries (such as react/http) that require a more recent version of react/socket.
I suggest changing the requirement for react/socket and react/socket-client to support upgrades as needed.
Thanks.

+1. Same with you.

i made #21 to update the code to the last version of react/socket if you want.


Parameter Descriptions Are Confusing

The scriptLocatiopn and scriptPath arguments are confusing. Both are required and both descriptions say it's the path to the script or the fully qualified path to the script. Why would I need both? The examples are not helpful since they are both using the inlineScript approach. Please clarify this.
The description of the values for scriptType are not clear. The text has PowerShell/PowerShell Core/Bat/Shell, bash/pscore and batch/ps/pscore are all highlighted. Are they all possible selections? A simple table(s) would make this much more clear indicating what the acceptable values are and to what agents they apply. Again teh examples are no help since they are both ps.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8de3304e-98f9-bac0-3ccc-c65f68a89e87
Version Independent ID: 8fb2f6a9-545d-dff1-ff86-974694a85054
Content: Azure CLI task - Azure Pipelines
Content Source: docs/pipelines/tasks/deploy/azure-cli.md
Product: devops
Technology: devops-cicd-tasks
GitHub Login: @ushan
Microsoft Alias: UshaN

@wfschneider Thank you for your feedback! I agree, the description was a little confusing.
scriptLocation: enter scriptPath to use a script file or inlineScript if you want to write your script inline.
scriptPath required when scriptLocation = scriptPath
inlineScript required when scriptLocation = inlineScript
scriptType: if your are using a windows agent you can use PowerShell, PowerShell core, or batch (select one). Select bash or PowerShell core if you are using a Linux agent.


Add TraceState implementation to API

Follow up based on 29/12 call, TraceState implementation should be part of API for various reasons (Should be able to use in creating in custom propagator only by taking dependency on @opentelemetry/api , library instrumentation, specification). There is already an interface TraceState exported so introducing the factory function createTraceState that returns new TraceState implementation.
It is worth noting that there are other components that are supposed to be in api/sdk but are part of opentelemetry-core package but TraceState is something I needed at the moment.

Is this the exact implementation from core or have you made any notable changes?

It is worth noting that there are other components that are supposed to be in api/sdk but are part of opentelemetry-core package but TraceState is something I needed at the moment.

Can you create issues for those components at least so we have something to track?

Is this the exact implementation from core or have you made any notable changes?

The only new change introduced in this PR createTraceState since there is already exported interface with TraceState name. Everything else is copied over from core package.

Can you create issues for those components at least so we have something to track?

Sure, will do that.

Are there already plans how to handle this move to API in @opentelemetry/core and other related packages?

@opentelemetry/core is GA so removing this class there would be breaking. Redirecting won't work as core exposes the constructor not the factory method which is not accessible in API.
There are some propagators which use the TraceState from core which could move to the API variant but this would require to bump the min API version there.
How to ensure compatibility between old/new implementation? I think it's likely to end up having both are in used within a single app.

@dyladan 's recommendation was to move this initially and then update wherever it is used. Encourage people to use the api method and issue depreciation notice to core component. But we will continue to keep maintaining the same changes in two places until the next major version.

Even though the core is GA we could just make a major bump, its supposed to be a internal package for instrumentations/sdks not something public facing right ?
In the order:

publish new api (as a minor ?)
update all usage from all packages to use the api instead of core
major bump core
update new version for all packages

I think the first two steps are fine for now. Maybe add a doc deprecation of TraceState in core.
There are a few other issues open to move more from core to API. Maybe core gets anyway empty at some point in time...

Right now having all stable SDK packages have the same version makes it a lot easier for end users. Also, our main repo is not really well set up to have packages independently versioned. I think publishing a minor API, updating usage, and adding a deprecation notice in the core package is sufficient for now.
Before merging this, are there any unreleased PATCH level changes that we should release first?


stampit instance passed in as state to another stampit loses its stampiness

I've got a live demo here: http://codepen.io/anon/pen/qEgjyo (open the console to see the result).
The code to reproduce is at the link above, but I'll repeat it here:
var a = stampit().state({
  n: 1
}).methods({
  num:function () { return this.n; }
})();

console.log(a); // b {n: 1, num: function}

var b = stampit().state({a: a})();

console.log(b.a); // Object {n: 1}

If I pass a stampit instance in as state to a stampit factory, the factory un-stampifies the instance into a plain Object. (Do forgive me if my terms are inaccurate.) As a consequence, the 'num' method is missing from b's reference to a.
Is this intended behaviour? If not, please consider this a bug. If this is intended behaviour, what is the reason for it, and/or is there a different pattern I should be aware of?

That is by design. The state does not copy any .prototype properties from the given variable a. Moreover, it performs cloning of the variable a, i.e. not referencing.

OK, thanks. The stampit API docs do mention that:
@param {Object} [state] A map of property names and values to clone for each new object.
I apologize for missing this. To compose by reference, then, the options are either
a) enclose(), or
b) assignment after instance creation

@ericelliott Here is the third person who needs composing by reference.
We have to add it to v2.0 I reckon.

Why? Stampit is already perfectly capable of producoling the desired stamp with .enclose().

It seems to me that enclose() can be used conceptually the same as a constructor or init method. Instead of passing in the initial data as arguments, one grants the function passed to enclose access to the initial data via scope (or closure).  Like so:
var refInstance = stampit().state(...).methods(...)();
var init = function () {
    this.ref = refInstance
};

var myInstance = stampit().state(...).methods(...).enclose(init)();

This not only works but feels good, too. :)

We might inbuild this feature into v2.x as it is very popular request. See #55
Closing this one as @jomido has found the proper solution. Well done, mate!


toradex: Add support for Toradex BSP 6.2.0

@TheYoctoJester ping

@drewmoseley ack

When I try to build the tdx-reference-minimal-image for an apalis-imx8 machine with these changes I get an error during the patch state of  u-boot-toradex-2022.04-r0:
Patch 0001-configs-toradex-board-specific-mender-integration.patch does not apply
Am I doing something wrong or is this PR not behaving as expected?

@mattes-bru what is the value of your TORADEX_BSP_VERSION variable?

the variable is not set. I followed along the QuickStart of the README but used another repo init:
repo init -u https://git.toradex.com/toradex-manifest.git \
    -b refs/tags/6.2.0 \
    -m tdxref/default.xml

I also needed to alter the mender manifest a little:
wget --directory-prefix .repo/local_manifests \
    https://raw.githubusercontent.com/mendersoftware/meta-mender-community/kirkstone/scripts/mender-no-setup-layers.xml

@drewmoseley: Thank you. Everything works as expected. I added a PR  with an updated version of the README #348


customMetadata added for Keycloak Sol.

customMetadata added for Keycloak Sol.

Validation failed.
Please check. @crystalz2022

Added one more commit to correct the issue "TPL_Standard_User  The user license doesn't allow the permission: View All Product2"


Several crashes with rewarded ad on iOS

MAX Plugin Version
2.0.0
Flutter Version
3.0.5
Device/Platform Info
iOS 15
Current Behavior
Several crashes appear in Crashlytics and XCode logs.

Fatal Exception: NSInvalidArgumentException
0  CoreFoundation                 0x99288 __exceptionPreprocess
1  libobjc.A.dylib                0x16744 objc_exception_throw
2  CoreFoundation                 0xf0390 __CFDictionaryCreateGeneric
3  Runner                         0x2e2eb4 +[MARewardedAd sharedWithAdUnitIdentifier:sdk:]
4  Runner                         0x1a8a98 -[AppLovinMAX retrieveRewardedAdForAdUnitIdentifier:] + 825 (AppLovinMAX.m:825)
5  Runner                         0x1a67f0 -[AppLovinMAX isRewardedAdReadyForAdUnitIdentifier:result:] + 413 (AppLovinMAX.m:413)
6  Runner                         0x1aba78 -[AppLovinMAX handleMethodCall:result:] + 1254 (AppLovinMAX.m:1254)
7  Flutter                        0x55ae50 (Missing UUID b5f419596300357c85f161f5e6e0920d)
8  Flutter                        0x42cd0 (Missing UUID b5f419596300357c85f161f5e6e0920d)
9  libdispatch.dylib              0x1e6c _dispatch_call_block_and_release
10 libdispatch.dylib              0x3a30 _dispatch_client_callout
11 libdispatch.dylib              0x11f48 _dispatch_main_queue_drain
12 libdispatch.dylib              0x11b98 _dispatch_main_queue_callback_4CF
13 CoreFoundation                 0x51800 CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE
14 CoreFoundation                 0xb704 __CFRunLoopRun
15 CoreFoundation                 0x1ebc8 CFRunLoopRunSpecific
16 GraphicsServices               0x1374 GSEventRunModal
17 UIKitCore                      0x514b58 -[UIApplication _run]
18 UIKitCore                      0x296090 UIApplicationMain
19 Runner                         0x590c main + 8 (AppDelegate.swift:8)
20 ???                            0x1065d9da4 (Missing)

Expected Behavior
No response
How to Reproduce
Can't reproduce. Seen only in crash logs, it must be related to rewarded ads.
Additional Info
No response

@kreativityapps , thanks for reporting.   Could you let us know a few things about the issue?

What is the exception message when you have NSInvalidArgumentException?   There must be an error message along with it.
What percentage of daily active users are affected by this issue?

Hi @alhiwatan, thanks for getting back so quickly.
Exception message:

Fatal Exception: NSInvalidArgumentException
No sdk specified

Almost 5% of users are affected. Ran an A/B test applovin enabled/disabled.
Disabled -> 100% crash-free with 1000 users
Enabled -> 95% crash-free with 1000 users
Affects both iphone and ipads.

@alhiwatan - Looks like when this LoC is called, self.sdk is nil. Which might indicate
@kreativityapps is not creating the rewarded ad objects after our plugin is done initializing.
@kreativityapps - Could you provide code snippet of your integration surroudning our plugin's init + loading rewarded ads?
https://dash.applovin.com/documentation/mediation/flutter/getting-started/integration#initialize-the-sdk
https://github.com/AppLovin/AppLovin-MAX-Flutter/blob/master/applovin_max/ios/Classes/AppLovinMAX.m#L136

This is the code, let me know if more details are needed.
await AppLovinMAX.initialize(Constants.applovinKey);
AppLovinMAX.createBanner(
  Constants.applovinIOSBanner,
  AdViewPosition.topCenter,
);
initializeRewardedAds();
AppLovinMAX.setVerboseLogging(kDebugMode);

void initializeRewardedAds() {
  AppLovinMAX.setRewardedAdListener(
    RewardedAdListener(
      onAdLoadedCallback: (ad) {
        _rewardedAdRetryAttempt = 0;
      },
      onAdLoadFailedCallback: (adUnitId, error) {
        _rewardedAdRetryAttempt = _rewardedAdRetryAttempt + 1;
        final int retryDelay =
            pow(2, min(6, _rewardedAdRetryAttempt)).toInt();
        Future.delayed(Duration(milliseconds: retryDelay * 1000), () {
          AppLovinMAX.loadRewardedAd(Constants.applovinIOSRewarded);
        });
      },
      onAdDisplayedCallback: (ad) {},
      onAdDisplayFailedCallback: (ad, error) {},
      onAdClickedCallback: (ad) {},
      onAdHiddenCallback: (ad) {},
      onAdReceivedRewardCallback: (ad, reward) {
        Future.delayed(const Duration(milliseconds: 1000), () {
          AppLovinMAX.loadRewardedAd(Constants.applovinIOSRewarded);
        });
      },
    ),
  );
  AppLovinMAX.loadRewardedAd(Constants.applovinIOSRewarded);
}

For Flutter iOS setup is enough to use await AppLovinMAX.initialize(applovinKey), right?
Or the key has to be added also to the Info.plist like described in the iOS documentation?
https://dash.applovin.com/documentation/mediation/ios/getting-started/integration#add-the-sdk-key

Hi, the issue was with AppLovinMAX.isRewardedAdReady.
In my code it was possible to execute it without initialising Applovin first. Missed this branch.
It's surrounded by a try - catch, on Android the error is handled, but on iOS the app crashes. This issue looks solved to me now, but maybe you want to look into the iOS crash. Thank you for your time.


Collect must-gathers on failed e2e runs

Which issue this PR addresses:

Fixes https://msazure.visualstudio.com/AzureRedHatOpenShift/_workitems/edit/11004136 and https://msazure.visualstudio.com/AzureRedHatOpenShift/_workitems/edit/12519725/
What this PR does / why we need it:

Adds a step to CI runs that appends a must-gather
Execute the step only when the E2E job fails
Move E2E cluster deletion to a dedicated step

Test plan for issue:
Confirm in CI that behavior is as expected

Is there any documentation that needs to be updated for this PR?
No

/azp run E2E


Investigate use of cf-python

This is something to just hold onto, certainly it might simplify / complement the existing use of iris and xarray for certain activities (regridding, processing and plotting), but especially be good for generating the CF compliant output from icenet_output.
Have a nosey at cf-python and see how it compares. Consider it as an in-place or complementary library.
This would also help enable integration with MET Office UM output, should we be interested in that in the future.

Worth noting that NCAS-CMS are the originators of cfunits, which is already sporadically used in the library

Particularly like the cell methods inclusion for operations carried out by the library, which to my knowledge is not added via scitools iris or xarray


Update MVC to use routing required values for endpoints

Exploring what MVC code would look like when consuming RoutePatternTransformer.
Neither tests or routing are updated yet so everything will fail.

Builds and tests locally.
Unable to complete at the moment without a feature branch build.

Replaced with PR on aspnetcore


Test case for session_partial_run_test.py is getting failed

I tried running file session_partial_run_test.py, It throws an error with following two failed exception.
======================================================================
FAIL: testRunAndPartialRunDist (__main__.PartialRunTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "g:/tensorflow/tensorflow/python/client/session_partial_run_test.py", line 258, in testRunAndPartialRunDist
    self.RunTestRunAndPartialRun(session.Session(server.target))
  File "g:/tensorflow/tensorflow/python/client/session_partial_run_test.py", line 123, in RunTestRunAndPartialRun
    self.assertEqual(r1, r2)
AssertionError: Lists differ: [4.0, 12.0] != [array([], dtype=float32), 12.0]

- [4.0, 12.0]
+ [array([], dtype=float32), 12.0]

======================================================================
FAIL: testRunAndPartialRunDist (__main__.PartialRunWithCApiTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "g:/tensorflow/tensorflow/python/client/session_partial_run_test.py", line 258, in testRunAndPartialRunDist
    self.RunTestRunAndPartialRun(session.Session(server.target))
  File "g:/tensorflow/tensorflow/python/client/session_partial_run_test.py", line 123, in RunTestRunAndPartialRun
    self.assertEqual(r1, r2)
AssertionError: Lists differ: [4.0, 12.0] != [array([], dtype=float32), 12.0]

- [4.0, 12.0]
+ [array([], dtype=float32), 12.0]

----------------------------------------------------------------------
Ran 50 tests in 2.933s

FAILED (failures=2)

However, I tried debugging the code and found some scenarios in below function:
def RunTestRunAndPartialRun(self, sess):
    a = constant_op.constant(2.0, dtypes.float32)
    b = a * 2
    c = b * 3
    r1 = sess.run([b, c])
    h = sess.partial_run_setup([b, c], [])
    r2 = sess.partial_run(h, [b, c])
    self.assertEqual(r1, r2)

In 1st scenario, when testRunAndPartialRunDirect() is executed, the test gets succeed with h value:
h = '->mul:0,mul_1:0//1/;0'
In 2nd scenario, when testRunAndPartialRunDist() is executed, the test gets failed with h value:
h = '0'
and below following list are different since assertEqual is throwing an exception:
Lists differ: [4.0, 12.0] != [array([], dtype=float32), 12.0]

- [4.0, 12.0]
+ [array([], dtype=float32), 12.0]

Looks like due to zero handle value, it started throwing an exception. Just need your suggestion if you are facing the same issue. Can I fix it by myself (I'd be happy to contribute)?
Guidance will be appreciated.

Is this throwing an exception just because of GPU? I tried it using CPU. Just a thought.

Nagging Awaiting TensorFlower: It has been 14 days with no activity and the awaiting tensorflower label was assigned. Please update the label and/or status accordingly.

@rajendraarora16 Sorry for the delay, but I am unable to reproduce this :(
This may be a GPU issue, but without a repro case I am unable to debug. Did you have any luck digging into this?
What machine, TF version, and operating system are you using?

Nagging Assignee @suharshs: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

It has been 44 days with no activity and the awaiting response label was assigned. Is this still an issue?

@rajendraarora16
Closing due to inactivity. Please reopen if you can provide a repro case or make any progress. thanks!


Add build-official-release.sh (take two)

This is a redo of #10687:

Adds a script which will: clone from a git tag, make release, and give you very detailed instructions as to what to do from that point.
Changes push-official-release.sh so we can't push "dirty" releases anymore (which build-official-release.sh also double checks at the end.)
Fixes #9576 by ensuring a correct umask.
Changes common.sh to gtar all the way through, to ensure that bloody OS X tar never touches the release process, because I don't want to have to understand two tar programs and how release artifacts are created from both (c.f. #10615.)

The two additional commits are fixes on top of #10687, to make it transparent what changed past the original PR.
Related to #1883.

cc @brendandburns (original) @ixdy @quinton-hoole

The text for each release should include a link to docs and examples for that release:
e.g.
## [Documentation](http://releases.k8s.io/v0.21.0/docs)
## [Examples](http://releases.k8s.io/v0.21.0/examples)

@thockin: Fixed in 79766ae5822d6dcca87ac8fde7fa8f9dfb8c09d8

LGTM

... but maybe squash before merge?

Squashed.

@brendandburns: Can we try to get this in ASAP, so I can break the world again while I'm still around?

LGTM + ok-to-merge

cc @vmarmol .. I'll be watching


data model(ling)

After todays virtual hangout about the data model I'm going to open this issue so we can share our hangoutresults and thoughts about the data model.
First of all I was searching for a tool to create, collaboratively edit and share UML-Projects.
Ther are a lot of tools to do these things...
I decided to use GenMyModel because I read some positive things about it and it has some export functionalities that might be useful.
Actually everybody who knows the link to this UML-Project can edit the models. So i send a mail to the coders attending to the hangout today.
No we can talk about the data model itself...

Maybe we should close this issue, as we just refactored the modelling in the past week.

:+1:  I had the same thought!

We can always reopen if necessary


ui-pl was reset during upgrade to 2.2.1

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

Install e.g. Rancher-HA 2.1.6
Configure ui-pl in settings to custom value
Upgrade Rancher to version 2.2.1

Result:
Value in ui-pl again contains 'Rancher'
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.2.1
Installation option (single install/HA):
HA

In the same context I found another thing: When I open the catalog page in Global -> Tools -> Catalog the text below displays
Official repository of curated application templates maintained by ecp.
I changed ui-pl in the settings to 'ecp'. I think this should display 'Rancher'.

@roycec -

I was not able to reproduce the ui-pl issue when upgrading to 2.2.2.  If you see this issue again, please reopen.
Removing the text Rancher is by design.  We will not display the text Rancher anywhere once ui-pl has been modified so user can work to 'customize' the product for their purposes.  As an admin you can disable the Library catalog and prevent users from enabling it.


endpoints doesn't have any authentication

Right now any rest request is open to the world and not only for nicegui.
Looking at the code ModelAPI needs something to check that the authentication is fine.

You can can subclass the view and override the get and post functions with authentication required like this:
from module.views import ModelAPI
from django.contrib.auth.decorators import login_required
from django.utils.decorators import method_decorator
from django.http import JsonResponse

class AuthenticatedView(ModelAPI):

    @method_decorator(login_required)
    def get(self, request, app_label, model_name, object_id, field_name):
        return super().get(request, app_label, model_name, object_id, field_name)

    @method_decorator(login_required)
    def post(self, request, app_label, model_name, object_id, field_name):
        return super().post(request, app_label, model_name, object_id, field_name)

Also looking at your readme and code to use ModelAPI isn't used at all to integrate django-nice but is used only internally.


Add ability to choose 'generate temporary file' when selecting target projects

For new users, they may want to just select 'Generate temporary file' if they get the generation dialogue on first use. So adding an option to the UI for 'no target project' would be useful.

Implemented in 0.121


#42557 fix - make open in command multiselect aware

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: sriram-dev sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@sriram-dev thanks for your PR. This looks good for me.
I would only argue that you should use a Set and not a Map of boolean, since you are using your Map as a Set.
Did you test this out?
@Tyriar do you wish to review as well or you leave this up to me?

@isidorn  Yes set makes sense. Will change it.

@isidorn  Please review and confirm if the changes are good

@sriram-dev thanks for your PR I have merged it in 🍻
I have pushed minor polish on top of it https://github.com/Microsoft/vscode/commit/119d49590d11266a311df66495f0bf17ba8181c2

Yay! Thanks!


DefaultHttpClient logs entire response on Error

In DefaultHttpClient, we allow clients to configure what level of logging they would like to have. This helps clients from leaking sensitive PII into their logs.
However, if there is an HTTP error (non 200 code) when communicating with Smartsheet, then we log the entire response.
See the logging code below. We should not be using REQUEST_RESPONSE here.
public void logRequest(HttpRequestBase request, HttpEntitySnapshot requestEntity,
                       HttpResponse response, HttpEntitySnapshot responseEntity, long durationMillis) throws IOException {
    logger.info("{} {}, Response Code:{}, Request completed in {} ms", request.getMethod(), request.getURI(),
            response.getStatusCode(), durationMillis);
    if (response.getStatusCode() != 200) {
        // log the request and response on error
        logger.warn(LOG_ARG, RequestAndResponseData.of(request, requestEntity, response, responseEntity, REQUEST_RESPONSE));
    } else {
        // log the summary request and response on success
        logger.debug(LOG_ARG, RequestAndResponseData.of(request, requestEntity, response, responseEntity, REQUEST_RESPONSE_SUMMARY));
    }
}

Asks:

We shouldn't add additional logging for other 200-level response code. Ex a 201 should cause us to do WARN logging
The client should be able to configure what we log on errors

In my MR, I made it so we don't log any additional request/response info on a non 200 response.
The client can enable debug logging or look at the request URI that was in the info level log that still happens.
In the future if clients ask for better error logging, we can add some configurable logic in there.


Issue-Create Deployment.yml (#16)

Create Deployment.yml

Created deploy workflow

Update Deployment.yml

update secrets name

Update Deployment.yml

Updated deployment workflow

Update Deployment.yml

updated production environment

Update Deployment.yml

Automated Review Comments
Issues in package-lock.json:

(5, 'Hardcoded string found')
(7, 'Hardcoded string found')
(8, 'Hardcoded string found')
(10, 'Hardcoded string found')
(14, 'Hardcoded string found')
(15, 'Line exceeds 80 characters')
(15, 'Hardcoded string found')
(16, 'Line exceeds 80 characters')
(16, 'Hardcoded string found')
(19, 'Hardcoded string found')
(20, 'Line exceeds 80 characters')
(20, 'Hardcoded string found')
(22, 'Hardcoded string found')
(26, 'Hardcoded string found')
(27, 'Line exceeds 80 characters')
(27, 'Hardcoded string found')
(28, 'Line exceeds 80 characters')
(28, 'Hardcoded string found')
(29, 'Hardcoded string found')
(30, 'Hardcoded string found')
(32, 'Hardcoded string found')
(33, 'Hardcoded string found')
(34, 'Hardcoded string found')
(38, 'Hardcoded string found')
(41, 'Hardcoded string found')
(43, 'Hardcoded string found')
(44, 'Hardcoded string found')
(45, 'Hardcoded string found')
(49, 'Hardcoded string found')
(50, 'Hardcoded string found')
(51, 'Line exceeds 80 characters')
(51, 'Hardcoded string found')
(52, 'Hardcoded string found')
(53, 'Hardcoded string found')
(57, 'Hardcoded string found')
(58, 'Hardcoded string found')
(59, 'Line exceeds 80 characters')
(59, 'Hardcoded string found')
(62, 'Hardcoded string found')
(63, 'Line exceeds 80 characters')
(63, 'Hardcoded string found')
(65, 'Hardcoded string found')
(69, 'Hardcoded string found')
(70, 'Hardcoded string found')
(71, 'Line exceeds 80 characters')
(71, 'Hardcoded string found')
(72, 'Hardcoded string found')
(73, 'Hardcoded string found')
(77, 'Hardcoded string found')
(78, 'Hardcoded string found')
(79, 'Line exceeds 80 characters')
(79, 'Hardcoded string found')
(80, 'Hardcoded string found')
(81, 'Hardcoded string found')
(85, 'Line exceeds 80 characters')
(85, 'Hardcoded string found')
(86, 'Hardcoded string found')
(89, 'Hardcoded string found')
(90, 'Line exceeds 80 characters')
(90, 'Hardcoded string found')
(91, 'Line exceeds 80 characters')
(91, 'Hardcoded string found')
(92, 'Hardcoded string found')
(95, 'Hardcoded string found')
(96, 'Hardcoded string found')
(100, 'Hardcoded string found')
(101, 'Line exceeds 80 characters')
(101, 'Hardcoded string found')
(102, 'Line exceeds 80 characters')
(102, 'Hardcoded string found')
(103, 'Hardcoded string found')
(104, 'Hardcoded string found')
(108, 'Hardcoded string found')
(109, 'Hardcoded string found')
(111, 'Hardcoded string found')
(115, 'Hardcoded string found')
(116, 'Line exceeds 80 characters')
(116, 'Hardcoded string found')
(117, 'Line exceeds 80 characters')
(117, 'Hardcoded string found')
(120, 'Hardcoded string found')
(121, 'Hardcoded string found')
(123, 'Hardcoded string found')
(124, 'Line exceeds 80 characters')
(124, 'Hardcoded string found')
(125, 'Line exceeds 80 characters')
(125, 'Hardcoded string found')
(126, 'Hardcoded string found')
(127, 'Hardcoded string found')
(131, 'Hardcoded string found')
(135, 'Hardcoded string found')
(136, 'Hardcoded string found')
(137, 'Line exceeds 80 characters')
(137, 'Hardcoded string found')
(138, 'Hardcoded string found')
(139, 'Hardcoded string found')
(143, 'Hardcoded string found')
(144, 'Hardcoded string found')
(146, 'Hardcoded string found')
(150, 'Hardcoded string found')
(151, 'Hardcoded string found')
(152, 'Line exceeds 80 characters')
(152, 'Hardcoded string found')
(153, 'Hardcoded string found')
(154, 'Hardcoded string found')
(155, 'Hardcoded string found')
(159, 'Hardcoded string found')
(160, 'Line exceeds 80 characters')
(160, 'Hardcoded string found')
(162, 'Line exceeds 80 characters')
(162, 'Hardcoded string found')
(163, 'Line exceeds 80 characters')
(163, 'Hardcoded string found')
(166, 'Hardcoded string found')
(167, 'Hardcoded string found')
(168, 'Line exceeds 80 characters')
(168, 'Hardcoded string found')
(171, 'Hardcoded string found')
(172, 'Line exceeds 80 characters')
(172, 'Hardcoded string found')
(174, 'Line exceeds 80 characters')
(174, 'Hardcoded string found')
(175, 'Line exceeds 80 characters')
(175, 'Hardcoded string found')
(178, 'Hardcoded string found')
(179, 'Hardcoded string found')
(180, 'Line exceeds 80 characters')
(180, 'Hardcoded string found')
(181, 'Hardcoded string found')
(182, 'Hardcoded string found')
(186, 'Hardcoded string found')
(187, 'Hardcoded string found')
(189, 'Hardcoded string found')
(190, 'Line exceeds 80 characters')
(190, 'Hardcoded string found')
(191, 'Line exceeds 80 characters')
(191, 'Hardcoded string found')
(192, 'Hardcoded string found')
(193, 'Hardcoded string found')
(197, 'Hardcoded string found')
(198, 'Hardcoded string found')
(199, 'Line exceeds 80 characters')
(199, 'Hardcoded string found')
(200, 'Hardcoded string found')
(201, 'Hardcoded string found')
(202, 'Hardcoded string found')
(205, 'Hardcoded string found')
(209, 'Hardcoded string found')
(210, 'Line exceeds 80 characters')
(210, 'Hardcoded string found')
(211, 'Line exceeds 80 characters')
(211, 'Hardcoded string found')
(214, 'Hardcoded string found')
(215, 'Line exceeds 80 characters')
(215, 'Hardcoded string found')
(217, 'Hardcoded string found')
(221, 'Hardcoded string found')
(222, 'Hardcoded string found')
(223, 'Line exceeds 80 characters')
(223, 'Hardcoded string found')
(224, 'Hardcoded string found')
(225, 'Hardcoded string found')
(229, 'Hardcoded string found')
(230, 'Hardcoded string found')
(231, 'Line exceeds 80 characters')
(231, 'Hardcoded string found')
(232, 'Hardcoded string found')
(233, 'Hardcoded string found')
(238, 'Hardcoded string found')
(240, 'Hardcoded string found')
(241, 'Hardcoded string found')
(242, 'Hardcoded string found')
(244, 'Hardcoded string found')
(245, 'Hardcoded string found')
(246, 'Hardcoded string found')
(249, 'Hardcoded string found')
(251, 'Hardcoded string found')
(254, 'Hardcoded string found')
(257, 'Hardcoded string found')
(259, 'Hardcoded string found')
(260, 'Hardcoded string found')
(263, 'Hardcoded string found')
(265, 'Hardcoded string found')
(266, 'Hardcoded string found')
(270, 'Hardcoded string found')
(271, 'Hardcoded string found')
(272, 'Line exceeds 80 characters')
(272, 'Hardcoded string found')
(273, 'Hardcoded string found')
(274, 'Hardcoded string found')
(278, 'Hardcoded string found')
(279, 'Hardcoded string found')
(280, 'Line exceeds 80 characters')
(280, 'Hardcoded string found')
(281, 'Hardcoded string found')
(282, 'Hardcoded string found')
(286, 'Hardcoded string found')
(287, 'Hardcoded string found')
(288, 'Line exceeds 80 characters')
(288, 'Hardcoded string found')
(291, 'Hardcoded string found')
(292, 'Line exceeds 80 characters')
(292, 'Hardcoded string found')
(294, 'Hardcoded string found')
(298, 'Hardcoded string found')
(299, 'Line exceeds 80 characters')
(299, 'Hardcoded string found')
(300, 'Line exceeds 80 characters')
(300, 'Hardcoded string found')
(301, 'Hardcoded string found')
(302, 'Hardcoded string found')
(303, 'Hardcoded string found')
(306, 'Hardcoded string found')
(307, 'Hardcoded string found')
(308, 'Hardcoded string found')
(310, 'Hardcoded string found')
(311, 'Hardcoded string found')
(315, 'Hardcoded string found')
(316, 'Hardcoded string found')
(317, 'Line exceeds 80 characters')
(317, 'Hardcoded string found')
(318, 'Hardcoded string found')
(319, 'Hardcoded string found')
(323, 'Hardcoded string found')
(324, 'Hardcoded string found')
(325, 'Line exceeds 80 characters')
(325, 'Hardcoded string found')
(328, 'Hardcoded string found')
(329, 'Hardcoded string found')
(331, 'Hardcoded string found')
(335, 'Hardcoded string found')
(336, 'Hardcoded string found')
(337, 'Line exceeds 80 characters')
(337, 'Hardcoded string found')
(338, 'Hardcoded string found')
(339, 'Hardcoded string found')
(343, 'Hardcoded string found')
(344, 'Line exceeds 80 characters')
(344, 'Hardcoded string found')
(350, 'Hardcoded string found')
(351, 'Hardcoded string found')
(352, 'Line exceeds 80 characters')
(352, 'Hardcoded string found')
(353, 'Hardcoded string found')
(354, 'Hardcoded string found')
(358, 'Hardcoded string found')
(359, 'Line exceeds 80 characters')
(359, 'Hardcoded string found')
(361, 'Hardcoded string found')
(362, 'Line exceeds 80 characters')
(362, 'Hardcoded string found')
(363, 'Line exceeds 80 characters')
(363, 'Hardcoded string found')
(364, 'Hardcoded string found')
(365, 'Hardcoded string found')
(369, 'Hardcoded string found')
(370, 'Hardcoded string found')
(371, 'Line exceeds 80 characters')
(371, 'Hardcoded string found')
(372, 'Hardcoded string found')
(373, 'Hardcoded string found')
(377, 'Hardcoded string found')
(378, 'Line exceeds 80 characters')
(378, 'Hardcoded string found')
(379, 'Line exceeds 80 characters')
(379, 'Hardcoded string found')
(380, 'Hardcoded string found')
(381, 'Hardcoded string found')
(385, 'Hardcoded string found')
(386, 'Hardcoded string found')
(387, 'Line exceeds 80 characters')
(387, 'Hardcoded string found')
(388, 'Hardcoded string found')
(389, 'Hardcoded string found')
(390, 'Hardcoded string found')
(393, 'Hardcoded string found')
(394, 'Line exceeds 80 characters')
(394, 'Hardcoded string found')
(395, 'Line exceeds 80 characters')
(395, 'Hardcoded string found')
(396, 'Hardcoded string found')
(397, 'Hardcoded string found')
(398, 'Hardcoded string found')
(401, 'Hardcoded string found')
(405, 'Hardcoded string found')
(406, 'Line exceeds 80 characters')
(406, 'Hardcoded string found')
(407, 'Line exceeds 80 characters')
(407, 'Hardcoded string found')
(408, 'Hardcoded string found')
(409, 'Hardcoded string found')
(410, 'Hardcoded string found')
(411, 'Hardcoded string found')
(412, 'Hardcoded string found')
(413, 'Hardcoded string found')
(415, 'Hardcoded string found')
(416, 'Hardcoded string found')
(420, 'Hardcoded string found')
(421, 'Line exceeds 80 characters')
(421, 'Hardcoded string found')
(422, 'Line exceeds 80 characters')
(422, 'Hardcoded string found')
(423, 'Hardcoded string found')
(426, 'Hardcoded string found')
(427, 'Hardcoded string found')
(431, 'Hardcoded string found')
(432, 'Hardcoded string found')
(435, 'Hardcoded string found')
(436, 'Hardcoded string found')
(437, 'Line exceeds 80 characters')
(437, 'Hardcoded string found')
(438, 'Hardcoded string found')
(439, 'Line exceeds 80 characters')
(439, 'Hardcoded string found')
(442, 'Hardcoded string found')
(448, 'Hardcoded string found')
(449, 'Hardcoded string found')
(450, 'Line exceeds 80 characters')
(450, 'Hardcoded string found')
(451, 'Hardcoded string found')
(452, 'Hardcoded string found')
(456, 'Hardcoded string found')
(457, 'Line exceeds 80 characters')
(457, 'Hardcoded string found')
(459, 'Hardcoded string found')
(463, 'Hardcoded string found')
(464, 'Line exceeds 80 characters')
(464, 'Hardcoded string found')
(465, 'Line exceeds 80 characters')
(465, 'Hardcoded string found')
(466, 'Hardcoded string found')
(467, 'Hardcoded string found')
(471, 'Hardcoded string found')
(472, 'Line exceeds 80 characters')
(472, 'Hardcoded string found')
(473, 'Line exceeds 80 characters')
(473, 'Hardcoded string found')
(476, 'Hardcoded string found')
(477, 'Line exceeds 80 characters')
(477, 'Hardcoded string found')
(478, 'Line exceeds 80 characters')
(478, 'Hardcoded string found')
(481, 'Hardcoded string found')
(482, 'Hardcoded string found')
(484, 'Hardcoded string found')
(488, 'Hardcoded string found')
(489, 'Hardcoded string found')
(490, 'Line exceeds 80 characters')
(490, 'Hardcoded string found')
(491, 'Hardcoded string found')
(492, 'Hardcoded string found')
(496, 'Hardcoded string found')
(497, 'Line exceeds 80 characters')
(497, 'Hardcoded string found')
(499, 'Hardcoded string found')
(503, 'Hardcoded string found')
(504, 'Hardcoded string found')
(505, 'Line exceeds 80 characters')
(505, 'Hardcoded string found')
(506, 'Hardcoded string found')
(507, 'Hardcoded string found')
(509, 'Hardcoded string found')
(510, 'Hardcoded string found')
(514, 'Hardcoded string found')
(515, 'Hardcoded string found')
(517, 'Hardcoded string found')
(518, 'Line exceeds 80 characters')
(518, 'Hardcoded string found')
(519, 'Line exceeds 80 characters')
(519, 'Hardcoded string found')
(520, 'Hardcoded string found')
(521, 'Hardcoded string found')
(522, 'Hardcoded string found')
(525, 'Hardcoded string found')
(529, 'Hardcoded string found')
(530, 'Line exceeds 80 characters')
(530, 'Hardcoded string found')
(531, 'Line exceeds 80 characters')
(531, 'Hardcoded string found')
(532, 'Hardcoded string found')
(535, 'Hardcoded string found')
(536, 'Hardcoded string found')
(540, 'Hardcoded string found')
(541, 'Hardcoded string found')
(543, 'Hardcoded string found')
(547, 'Hardcoded string found')
(548, 'Hardcoded string found')
(549, 'Line exceeds 80 characters')
(549, 'Hardcoded string found')
(550, 'Hardcoded string found')
(551, 'Hardcoded string found')
(555, 'Hardcoded string found')
(556, 'Line exceeds 80 characters')
(556, 'Hardcoded string found')
(558, 'Hardcoded string found')
(562, 'Hardcoded string found')
(563, 'Line exceeds 80 characters')
(563, 'Hardcoded string found')
(564, 'Line exceeds 80 characters')
(564, 'Hardcoded string found')
(567, 'Hardcoded string found')
(568, 'Hardcoded string found')
(574, 'Hardcoded string found')
(575, 'Line exceeds 80 characters')
(575, 'Hardcoded string found')
(576, 'Line exceeds 80 characters')
(576, 'Hardcoded string found')
(577, 'Hardcoded string found')
(578, 'Hardcoded string found')
(581, 'Hardcoded string found')
(582, 'Hardcoded string found')
(586, 'Hardcoded string found')
(587, 'Hardcoded string found')
(589, 'Hardcoded string found')
(593, 'Hardcoded string found')
(594, 'Hardcoded string found')
(595, 'Line exceeds 80 characters')
(595, 'Hardcoded string found')
(596, 'Hardcoded string found')
(599, 'Hardcoded string found')
(600, 'Hardcoded string found')
(602, 'Hardcoded string found')
(603, 'Hardcoded string found')
(607, 'Hardcoded string found')
(608, 'Line exceeds 80 characters')
(608, 'Hardcoded string found')
(610, 'Hardcoded string found')
(614, 'Hardcoded string found')
(615, 'Line exceeds 80 characters')
(615, 'Hardcoded string found')
(616, 'Line exceeds 80 characters')
(616, 'Hardcoded string found')
(617, 'Hardcoded string found')
(618, 'Hardcoded string found')
(622, 'Hardcoded string found')
(623, 'Hardcoded string found')
(624, 'Line exceeds 80 characters')
(624, 'Hardcoded string found')
(625, 'Hardcoded string found')
(626, 'Hardcoded string found')
(629, 'Hardcoded string found')
(631, 'Hardcoded string found')
(632, 'Hardcoded string found')
(636, 'Hardcoded string found')
(637, 'Hardcoded string found')
(639, 'Hardcoded string found')
(643, 'Hardcoded string found')
(644, 'Line exceeds 80 characters')
(644, 'Hardcoded string found')
(645, 'Line exceeds 80 characters')
(645, 'Hardcoded string found')
(646, 'Hardcoded string found')
(648, 'Hardcoded string found')
(649, 'Hardcoded string found')
(652, 'Hardcoded string found')
(653, 'Hardcoded string found')
(656, 'Hardcoded string found')
(657, 'Hardcoded string found')
(662, 'Hardcoded string found')
(663, 'Line exceeds 80 characters')
(663, 'Hardcoded string found')
(665, 'Hardcoded string found')
(669, 'Hardcoded string found')
(670, 'Line exceeds 80 characters')
(670, 'Hardcoded string found')
(671, 'Line exceeds 80 characters')
(671, 'Hardcoded string found')
(674, 'Hardcoded string found')
(675, 'Line exceeds 80 characters')
(675, 'Hardcoded string found')
(677, 'Hardcoded string found')
(681, 'Hardcoded string found')
(682, 'Hardcoded string found')
(683, 'Line exceeds 80 characters')
(683, 'Hardcoded string found')
(684, 'Hardcoded string found')
(685, 'Hardcoded string found')
(686, 'Hardcoded string found')
(687, 'Hardcoded string found')
(688, 'Hardcoded string found')
(690, 'Hardcoded string found')
(691, 'Hardcoded string found')
(693, 'Hardcoded string found')
(694, 'Hardcoded string found')
(697, 'Hardcoded string found')
(699, 'Hardcoded string found')
(700, 'Hardcoded string found')
(704, 'Hardcoded string found')
(705, 'Hardcoded string found')
(706, 'Line exceeds 80 characters')
(706, 'Hardcoded string found')
(707, 'Hardcoded string found')
(708, 'Hardcoded string found')
(712, 'Hardcoded string found')
(713, 'Hardcoded string found')
(714, 'Line exceeds 80 characters')
(714, 'Hardcoded string found')
(717, 'Hardcoded string found')
(718, 'Hardcoded string found')
(719, 'Line exceeds 80 characters')
(719, 'Hardcoded string found')
(722, 'Hardcoded string found')
(723, 'Line exceeds 80 characters')
(723, 'Hardcoded string found')
(724, 'Line exceeds 80 characters')
(724, 'Hardcoded string found')
(725, 'Hardcoded string found')
(726, 'Hardcoded string found')
(728, 'Hardcoded string found')
(729, 'Hardcoded string found')
(731, 'Hardcoded string found')
(732, 'Hardcoded string found')
(736, 'Hardcoded string found')
(737, 'Line exceeds 80 characters')
(737, 'Hardcoded string found')
(738, 'Line exceeds 80 characters')
(738, 'Hardcoded string found')
(739, 'Hardcoded string found')
(740, 'Hardcoded string found')
(744, 'Hardcoded string found')
(748, 'Hardcoded string found')
(749, 'Line exceeds 80 characters')
(749, 'Hardcoded string found')
(750, 'Line exceeds 80 characters')
(750, 'Hardcoded string found')
(753, 'Hardcoded string found')
(754, 'Line exceeds 80 characters')
(754, 'Hardcoded string found')
(756, 'Hardcoded string found')
(757, 'Line exceeds 80 characters')
(757, 'Hardcoded string found')
(758, 'Line exceeds 80 characters')
(758, 'Hardcoded string found')
(759, 'Hardcoded string found')
(760, 'Hardcoded string found')
(768, 'Hardcoded string found')
(769, 'Hardcoded string found')
(770, 'Line exceeds 80 characters')
(770, 'Hardcoded string found')
(771, 'Hardcoded string found')
(772, 'Hardcoded string found')
(776, 'Hardcoded string found')
(777, 'Line exceeds 80 characters')
(777, 'Hardcoded string found')
(779, 'Hardcoded string found')
(783, 'Hardcoded string found')
(784, 'Line exceeds 80 characters')
(784, 'Hardcoded string found')
(785, 'Line exceeds 80 characters')
(785, 'Hardcoded string found')
(786, 'Hardcoded string found')
(787, 'Hardcoded string found')
(791, 'Hardcoded string found')
(792, 'Hardcoded string found')
(794, 'Hardcoded string found')
(798, 'Hardcoded string found')
(799, 'Hardcoded string found')
(800, 'Line exceeds 80 characters')
(800, 'Hardcoded string found')
(801, 'Hardcoded string found')
(805, 'Hardcoded string found')
(806, 'Hardcoded string found')
(810, 'Hardcoded string found')
(811, 'Line exceeds 80 characters')
(811, 'Hardcoded string found')
(813, 'Line exceeds 80 characters')
(813, 'Hardcoded string found')
(814, 'Line exceeds 80 characters')
(814, 'Hardcoded string found')
(817, 'Hardcoded string found')
(818, 'Hardcoded string found')
(819, 'Line exceeds 80 characters')
(819, 'Hardcoded string found')
(820, 'Hardcoded string found')
(821, 'Hardcoded string found')
(825, 'Hardcoded string found')
(826, 'Line exceeds 80 characters')
(826, 'Hardcoded string found')
(828, 'Line exceeds 80 characters')
(828, 'Hardcoded string found')
(829, 'Line exceeds 80 characters')
(829, 'Hardcoded string found')
(832, 'Hardcoded string found')
(833, 'Line exceeds 80 characters')
(833, 'Hardcoded string found')
(834, 'Line exceeds 80 characters')
(834, 'Hardcoded string found')
(835, 'Hardcoded string found')
(836, 'Hardcoded string found')
(840, 'Hardcoded string found')
(841, 'Hardcoded string found')
Issues in package.json:
(2, 'Hardcoded string found')
(3, 'Hardcoded string found')
(4, 'Hardcoded string found')
(5, 'Hardcoded string found')
(6, 'Hardcoded string found')
(7, 'Hardcoded string found')
(8, 'Hardcoded string found')
(9, 'Hardcoded string found')
(14, 'Hardcoded string found')
(16, 'Hardcoded string found')
(17, 'Hardcoded string found')
Issues in src/components/Activity.js:
(5, 'Line exceeds 80 characters')
(7, 'Hardcoded string found')
(9, 'Line exceeds 80 characters')
(10, 'Hardcoded string found')
(14, 'Line exceeds 80 characters')
(18, 'Line exceeds 80 characters')
(35, 'Line exceeds 80 characters')
(42, 'Hardcoded string found')
(45, 'Line exceeds 80 characters')
(46, 'Line exceeds 80 characters')
(54, 'Line exceeds 80 characters')
(55, 'Line exceeds 80 characters')
(65, 'Line exceeds 80 characters')
(71, 'Hardcoded string found')
(74, 'Line exceeds 80 characters')
(78, 'Line exceeds 80 characters')
(85, 'Line exceeds 80 characters')
(93, 'Line exceeds 80 characters')
(103, 'Line exceeds 80 characters')
(130, 'Line exceeds 80 characters')
(138, 'Line exceeds 80 characters')
(138, 'Hardcoded string found')
(148, 'Line exceeds 80 characters')
(151, 'Line exceeds 80 characters')
(151, 'Hardcoded string found')
(155, 'Line exceeds 80 characters')
(155, 'Hardcoded string found')
(161, 'Hardcoded string found')
(163, 'Line exceeds 80 characters')
(168, 'Hardcoded string found')
(178, 'Line exceeds 80 characters')
(178, 'Hardcoded string found')
(181, 'Line exceeds 80 characters')
(181, 'Hardcoded string found')
(183, 'Line exceeds 80 characters')
(183, 'Hardcoded string found')
(186, 'Line exceeds 80 characters')
(190, 'Line exceeds 80 characters')
(197, 'Line exceeds 80 characters')
(197, 'Hardcoded string found')
(200, 'Line exceeds 80 characters')
(200, 'Hardcoded string found')
(202, 'Line exceeds 80 characters')
(202, 'Hardcoded string found')
(204, 'Line exceeds 80 characters')
(204, 'Hardcoded string found')
(206, 'Line exceeds 80 characters')
(207, 'Line exceeds 80 characters')
(213, 'Line exceeds 80 characters')
(213, 'Hardcoded string found')
(217, 'Line exceeds 80 characters')
(219, 'Line exceeds 80 characters')
(219, 'Hardcoded string found')
(220, 'Line exceeds 80 characters')
(224, 'Line exceeds 80 characters')
(229, 'Line exceeds 80 characters')
(229, 'Hardcoded string found')
(231, 'Line exceeds 80 characters')
(231, 'Hardcoded string found')
Issues in src/components/Selector.js:
(3, 'Line exceeds 80 characters')
(4, 'Line exceeds 80 characters')
(7, 'Hardcoded string found')
(13, 'Line exceeds 80 characters')
(15, 'Line exceeds 80 characters')
(16, 'Line exceeds 80 characters')
(35, 'Line exceeds 80 characters')
(38, 'Hardcoded string found')
(48, 'Line exceeds 80 characters')
(48, 'Hardcoded string found')
(49, 'Line exceeds 80 characters')
(49, 'Hardcoded string found')
(50, 'Hardcoded string found')
(61, 'Line exceeds 80 characters')
(64, 'Hardcoded string found')
(73, 'Line exceeds 80 characters')
(74, 'Hardcoded string found')
(75, 'Hardcoded string found')
(76, 'Hardcoded string found')
(83, 'Line exceeds 80 characters')
(84, 'Hardcoded string found')
(85, 'Hardcoded string found')
(94, 'Line exceeds 80 characters')
(94, 'Hardcoded string found')
(98, 'Line exceeds 80 characters')
(98, 'Hardcoded string found')
(102, 'Line exceeds 80 characters')
(110, 'Line exceeds 80 characters')
(110, 'Hardcoded string found')
(113, 'Line exceeds 80 characters')
(113, 'Hardcoded string found')
(116, 'Line exceeds 80 characters')
(116, 'Hardcoded string found')
Issues in src/components/WorkerNumber.js:
(4, 'Line exceeds 80 characters')
(5, 'Line exceeds 80 characters')
(6, 'Hardcoded string found')
(13, 'Line exceeds 80 characters')
(14, 'Line exceeds 80 characters')
(20, 'Hardcoded string found')
(22, 'Line exceeds 80 characters')
(23, 'Line exceeds 80 characters')
(24, 'Line exceeds 80 characters')
(24, 'Hardcoded string found')
Issues in src/components/layout.js:
(9, 'Hardcoded string found')
(10, 'Hardcoded string found')
(22, 'Hardcoded string found')
(25, 'Hardcoded string found')
(28, 'Hardcoded string found')
(30, 'Hardcoded string found')
(38, 'Hardcoded string found')
(39, 'Hardcoded string found')
(46, 'Hardcoded string found')
(47, 'Hardcoded string found')
(48, 'Hardcoded string found')
(50, 'Hardcoded string found')
(51, 'Hardcoded string found')
(60, 'Line exceeds 80 characters')
(60, 'Hardcoded string found')
(61, 'Line exceeds 80 characters')
(61, 'Hardcoded string found')
(63, 'Hardcoded string found')
(64, 'Line exceeds 80 characters')
(66, 'Hardcoded string found')
(67, 'Line exceeds 80 characters')
(67, 'Hardcoded string found')
(68, 'Line exceeds 80 characters')
(68, 'Hardcoded string found')
(69, 'Line exceeds 80 characters')
(71, 'Hardcoded string found')
Issues in src/context/index.js:
(3, 'Hardcoded string found')
(5, 'Hardcoded string found')
Issues in src/pages/_document.js:
(5, 'Line exceeds 80 characters')
(9, 'Line exceeds 80 characters')
Issues in src/pages/index.js:
(8, 'Line exceeds 80 characters')
(17, 'Line exceeds 80 characters')
(20, 'Line exceeds 80 characters')
(22, 'Line exceeds 80 characters')
(23, 'Hardcoded string found')
(28, 'Line exceeds 80 characters')
(28, 'Hardcoded string found')
(33, 'Hardcoded string found')
(42, 'Line exceeds 80 characters')
(42, 'Hardcoded string found')
(44, 'Hardcoded string found')
(53, 'Hardcoded string found')
(63, 'Line exceeds 80 characters')
(63, 'Hardcoded string found')
(64, 'Line exceeds 80 characters')
(64, 'Hardcoded string found')
(65, 'Line exceeds 80 characters')
(65, 'Hardcoded string found')
(66, 'Hardcoded string found')
(67, 'Hardcoded string found')
(68, 'Line exceeds 80 characters')
(72, 'Line exceeds 80 characters')
(72, 'Hardcoded string found')
(73, 'Line exceeds 80 characters')
(73, 'Hardcoded string found')
(75, 'Line exceeds 80 characters')
(75, 'Hardcoded string found')
(76, 'Line exceeds 80 characters')
(76, 'Hardcoded string found')
(78, 'Line exceeds 80 characters')
(78, 'Hardcoded string found')
(79, 'Hardcoded string found')
(80, 'Hardcoded string found')
(85, 'Line exceeds 80 characters')
(89, 'Line exceeds 80 characters')
(89, 'Hardcoded string found')
(90, 'Line exceeds 80 characters')
(90, 'Hardcoded string found')
(91, 'Line exceeds 80 characters')
(91, 'Hardcoded string found')
(95, 'Hardcoded string found')
(107, 'Hardcoded string found')
(110, 'Hardcoded string found')
Issues in src/pages/secretary.js:
(5, 'Line exceeds 80 characters')
(6, 'Hardcoded string found')
(15, 'Hardcoded string found')
(17, 'Hardcoded string found')
(23, 'Line exceeds 80 characters')
(28, 'Hardcoded string found')
(29, 'Hardcoded string found')
(30, 'Hardcoded string found')
(31, 'Line exceeds 80 characters')
(31, 'Hardcoded string found')
(32, 'Hardcoded string found')
(33, 'Hardcoded string found')
(35, 'Line exceeds 80 characters')
(35, 'Hardcoded string found')
(39, 'Line exceeds 80 characters')
(39, 'Hardcoded string found')
(40, 'Line exceeds 80 characters')
(40, 'Hardcoded string found')
(41, 'Line exceeds 80 characters')
(41, 'Hardcoded string found')
(42, 'Hardcoded string found')
(43, 'Line exceeds 80 characters')
(61, 'Hardcoded string found')
(62, 'Hardcoded string found')
(63, 'Line exceeds 80 characters')
(70, 'Hardcoded string found')
(75, 'Line exceeds 80 characters')
Issues in src/toast/index.js:
(4, 'Hardcoded string found')
(11, 'Hardcoded string found')
(12, 'Hardcoded string found')
(16, 'Hardcoded string found')
(17, 'Line exceeds 80 characters')
(17, 'Hardcoded string found')
Issues in src/utils/index.js:
(12, 'Hardcoded string found')
(13, 'Hardcoded string found')
(17, 'Hardcoded string found')
(18, 'Hardcoded string found')
(25, 'Hardcoded string found')
(26, 'Hardcoded string found')

I got it.


Box observation_space high bound wrongly set by wrap_deepmind

wrap_deepming function, depending on user inputs, could call first ScaledFloatFrame and then FrameStack, in this case the upper bound of the box observation space is set to 255 by FrameStack, while it should be 1.0
A possible solution could be to call ScaledFloatFrame at the end, even if this means getting rid of LazyFrames.

Hello,
That's true. In practice, this wrapper is not used and the scaling is done during the pre-processing.
We may remove that wrapper as it is also now present in gym.

Yep, I see normalization is performed in the observation_input method indeed, but if someone uses the wrapper with scale=True kwarg that's an issue. Thanks for the feedback.


featuregate ivy dependent autoloads for irc, pass

previously these functions would get autoloaded even when another
completion framework was active

Thanks!


Missions

In this PR,

I created a route for missions page
I fetched data from API using createAsyncThunk
I displayed missions on list render
I implemented mission joining and leaving
I displayed missions on profile when reserved is true
I styled the missions page

Hi @Otegaa  ,
Status: Approved  :+1: :
Good job applying the project requirement!

GOOD HIGHLIGHTS :heavy_check_mark:

Linter checks are passing
Good commit messages
Professional README.md description
Adhered to GitHub flow
Applied the requirements of the project
Check the comments under the review.

Cheers and Happy coding :clap: :clap: :clap:
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.