feat: Support RAW photo capture on iOS

What
This PR adds support for capturing photos with RAW format on iOS.
Changes

(iOS) Adds enableRawCapture boolean prop available in iOS.
(iOS) Finds a rawFormat for the AVCapturePhotoSettings
(iOS) Adds a delegate file called RAWCaptureDelegate which is responsible for:
Making a unique DNG file URL.
Saving the photo in the phone gallery. I wanted to save the photo to the phone with the CameraRoll.save() function in the react native example, but the CameraRoll library doesn’t support saving dng files to the phone. Currently, there is a PR for saving dng files to the CameraRoll library: https://github.com/react-native-cameraroll/react-native-cameraroll/pull/223/files
Return the photo data: path, width, height, isRawPhoto, metadata, thumbnail
(iOS) Adds a raw embedded thumbnail photo format to the photoSettings

Tested on

iPhone 13 pro max, iOS 15.4.1

Related issues

Fixes #73

Closing due to inactivity.


Compatibility with Yanfly Event Mini labels.

Describe the bug
In my 1104x624 game it shifts mini labels to the left by about 48 pixels. I tried changing the plugin order but it was the same.
I'll admit I did not try in a fresh project and my project has a ton of yanfly plugins but only a few alter the text, Even Labels and Message Core and the menu plugins. I tried turning word-wrap off too but nothing I tried fixed it.
To Reproduce
Steps to reproduce the behavior:

Install Yanfly Event Mini Labels and Message Core.
Make a Event Mini Label
Look at it.

Expected behavior
To not change the Y location of mini labels.
Screenshots

Desktop (please complete the following information):

OS: Windows
Full play test but not exported
RPG Make MV 1.63

Smartphone (please complete the following information):

PC

Additional context
I tried putting your plugin above mini labels but no change.
I tried looking at both plugins but have no idea what is conflicting. textWidthEx?
This is easy for the user to work around with the Y buffer parameter given by Mini Labels.

What is the name of my plugin that you used?

What is the name of my plugin that you used?

RS_MessageAlign
Life saving plugin by the way.

Ok. I'll check it.

I have fixed a compatibility issue with the YEP_EventMiniLabel plugin.

Hell yea thanks for the fast fix!


question about calc_landmarks layer

https://github.com/swook/GazeML/blob/5466f59be70583e7e8c343bda91c8df539aef13a/src/models/elg.py#L272
Mind explaining the rationale for this function? What is the effect of creating the meshgrids, flattening them and multiplying them by the output of the softmax for each heatmap?

I just realized this is a 2d soft argmax. I wonder if it would work better to calculate the center of mass or centroid.


DOI disappeared during duplicate merge

I just manually grouped and merged duplicate publications in RMD for the "Enlightenment" chapter, written by Thomas Beebee, in a Routledge handbook. I merged the Activity Insight record, which didn't have a DOI, into the Pure record, which did. The merged record ended up without a DOI. I added it back in manually. The DOI is https://doi.org/10.4324/9781351138703

Closing this because it duplicates #973


Ribbon Consistent Hash Loadbalace

spring cloud ribbon can achieve consistent Hash load balancing?

Can you provide a better description of the problem you are trying to solve?

I have a url like http://host:port/a/b/c/{pathValue}，pathValue is a path variable，Suppose there are n services. For a pathValue, it fixed request to a server X, assuming X downtime, it will request to the server Y, if the server X has been good, the request will go to the server X.
Because pathValue is a random variable, on the whole, n servers are load balanced, for a specific request, it will request to the specified server, the consistent hash algorithm can achive this goal. But I can not find in Spring Cloud

You would need to write a custom zuul filter that translated {pathValue} to a service id that could be used to loadbalance.

@spencergibb Is there a way to implement the ribbon to do this?

@fudali113 ribbons job is to map a service id to a host and port. The zuul filter would need to map the pathValue to a service id.

Closing due to age of the question. If you would like us to look at this issue, please comment and we will look at re-opening the issue.


Make it work with iframes

When destination element is in another iframe, it is necessary to take into consideration the container offset.
To get the container offset we need to set a viewport in the options.
The same change must be done into tooltip.js
To make it work, the element in the step must be referred by the jQuery instance:
{
element: $('#element',$('#iframe').contents)
}

How you managed to enter the bootstrap tour in an iframe the solution you propose does not solve my problem, you help me.


Templates are not working as before

Hello,
I use last lime version on haxelib (2.0.0) and last openfl and today I had a problem with templates.
I usually use a template to add some facebook info to my PROJ-Info.plist and avoid to have to add the info in the plist manually on each update, but today the template is not used anymore.
in my include.xml I use the following command :
<template path="templates" />
and in my templates folder I have the following
" iphone/PROJ/PROJ-info.plist "
What changed in the new version ? How can I use my template again ?
I triied to use
<template path="path/to/the/plist" replace="projectName-info.plist" />
and it seems to work fine.
thanks

Are
Here is the include.xml i use : https://github.com/TBaudon/OpenFLMopub/blob/master/include.xml
and here is the template folder : https://github.com/TBaudon/OpenFLMopub/tree/master/templates
In my project.xml, i include the extension after <haxelib name!"openfl" />
I though templates were overwriting existing openfl file and adding others. When I use -verbose with lime update I don't see anything happening about my template, and in my xcode project, my resources file are not added.
I'm I missunderstanding something about templates ? Thanks.

I just added support for a "Resources" directory:
https://github.com/openfl/lime/commit/712749e9d7ede65779552fa34033c9b9422b4718
Please let me know if this is working as you would expect it to :smile:

Thanks.
Yes it does the trick, the files are copied ine the Resources folder.
I think the xcodeproj template needs some change as well because even if the file are added in the resources folder, they aren't in the project. I'm trying to figure out what part need to change but this file is quite hard to understand >.<

I don't really have a way of testing here.
I'm going to close this for now, if it is not quite working as you need it to, do this --
1.) Generate the OpenFL project
2.) Open the project in Xcode
3.) Copy the project somewhere to back it up
4.) Make the needed change manually in Xcode to make it work
5.) Send me both Xcode projects so I can compare, or run a diff program (WinMerge, Meld, etc) against them to get the needed diff yourself
Thanks again :smile:


Update JSON tests to use 'std.testing.expectEqual'

Use the more descriptive 'expectEqual' testing function. This is also used in the Zig stdlib tests.

that looks complex for new user

It could made more explicit but verbose by splitting out the 'expected' and 'actual' values of the call.
I would still say that is a better testing function to use.
https://ziglang.org/documentation/master/std/#A;std:testing.expectEqual
This function is intended to be used only in tests. When the two values are not equal, prints diagnostics to stderr to show exactly how they are not equal, then returns a test failure error. actual is casted to the type of expected.

expectEqual is intended to use for structs and big types. there's no reason to use it over expect when you're comparing integers.

Respectfully, it is used to check simple values.
Running a simple test case of grep -rn "testing.expectEqual(@as" . | wc -l comes back with 620 lines.
https://github.com/ziglang/zig/blob/3f04231600e7ec2e16f5fb33f2e81eea24bdc41b/lib/std/Uri.zig#L469
https://github.com/ziglang/zig/blob/3f04231600e7ec2e16f5fb33f2e81eea24bdc41b/lib/std/array_list.zig#L1111
https://github.com/ziglang/zig/blob/3f04231600e7ec2e16f5fb33f2e81eea24bdc41b/lib/std/bit_set.zig#L1439
https://github.com/ziglang/zig/blob/3f04231600e7ec2e16f5fb33f2e81eea24bdc41b/lib/std/math.zig#L897
https://github.com/ziglang/zig/blob/3f04231600e7ec2e16f5fb33f2e81eea24bdc41b/lib/std/json.zig#L33
https://github.com/ziglang/zig/blob/3f04231600e7ec2e16f5fb33f2e81eea24bdc41b/lib/std/unicode.zig#L742
https://github.com/ziglang/zig/blob/3f04231600e7ec2e16f5fb33f2e81eea24bdc41b/lib/std/wasm.zig#L212
It's cool if you want to reject; it was interesting enough giving me a reason do read more of the stdlib code.

not rejecting, just wanted to put my two cents. feel free to push merge button if you aren't convinced

Your project mate, just helping where I can 😀. Not fussed either way.


Fix: [Regex] Do not allow white space in front of IP

⚠⚠⚠ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:

[x] I have read and understand the pull request rules.

Description
Fixes #2616
Tested with the regex test provided in the link.
Type of change
Please delete any options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Checklist

[x] My code follows the style guidelines of this project
[x] I ran ESLint and other linters for modified files
[x] I have performed a self-review of my own code and tested it
[ ] I have commented my code, particularly in hard-to-understand areas
(including JSDoc for methods)
[x] My changes generate no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Hi,
There is an auto test for this function you could update here : https://github.com/louislam/uptime-kuma/blob/master/test/cypress/unit/util-frontend.spec.js
Just a thought, but couldn't we add a trim when we submt?

Added unit test and fixed more edge cases
Added trim() to frontend when submit


:OmniSharpInstall fails with 'failed inside powershell'

I have a clean installation of Neovim 0.3.8 running on Windows 10. When I try to install the omnisharp server using the built-in :OmniSharpInstall command, it fails with the following error:

Omnisharp's log directory is completely empty. I have tried the suggestions in this comment and none appear to make any difference but if I run omnisharp-manager.ps1 (the original, unedited one) from powershell directly (not running as administrator) it works without issue.
EDIT: I realise I didn't include my init.vim:
" Fix the path so that we can find ~/.vim on windows, by default the runtime path only includes ~/vimfiles, so it doesn't find plugins
if has('win32') || has('win64')
    set runtimepath=$HOME/.config/nvim,$VIM/vimfiles,$VIMRUNTIME,$VIM/vimfiles/after,$HOME/.config/nvim/after
endif

call plug#begin('~/.config/nvim/plugged')
Plug 'OmniSharp/omnisharp-vim'
call plug#end()

let g:OmniSharp_server_path=$HOME . '\.omnisharp\OmniSharp.exe'
let g:OmniSharp_server_stdio = 1
let g:OmniSharp_loglevel = 'debug'

I really don't know how to debug this, I don't know powershell, but it sounds like the same permissions issues from the issue you have linked.
Any ideas, @axvr?

Hi @jacquesh, would you mind replacing this line
https://github.com/OmniSharp/omnisharp-vim/blob/8a1d609873d675ff66b3071f32a7496214676434/autoload/OmniSharp.vim#L1205
with this:
echomsg 'powershell "& ""' . s:script_location . '"""' . l:http .
      \ ' -l "' . l:location . '"' . l:version
echomsg system(

Then try running :OmniSharpInstall again. This should hopefully give us an error message from PowerShell, and check what Vim actually told it to run.

For completeness I tried it on Vim 8.1.1777 and nvim 0.3.8. Both give the same output (down to the plugin directory at least, in nvim's case I was using the config given above):

In case it helps, I was fiddling around (not knowing anything about VimL or calling out to powershell) and if I manually run the following it works:
call system('powershell "& ""C:\Users\Jacques Heunis\.vim\plugged\omnisharp-vim/installer/omnisharp-manager.ps1"""')

Sorry for the late reply I was busy all yesterday. These error messages are certainly strange, and the only potential problem I can see with it is the /s in the script path.
I'm currently installing a copy of Windows, so I can try and debug this. I'm also going to test some possible enhancements to the script which should make the install process easier, safer, and add missing features such as error logging, while making the install code simpler.

@jacquesh could please give the latest version a go? @axvr has just updated the installer scripts, it'd be really good to hear if this makes everything work for you.

Yep, it appears to work perfectly (in both vim and neovim, for anybody wondering)! Thanks :)

Awesome, great job @axvr, thanks again!


Close my Word Office app , after I call convert.shutdown method.

My app closes MS office word app, when I shutdown converter .
        File output = new File(System.getProperty("user.dir") + "/1.pdf");
        FileOutputStream fos = null;
        try {
            fos = new FileOutputStream(output);
            IConverter converter = LocalConverter.builder()
                    .baseFolder(tmpDir)
                    .workerPool(20, 25, 2, TimeUnit.SECONDS)
                    .processTimeout(30, TimeUnit.SECONDS)
                    .build();
            converter.convert(new File(System.getProperty("user.dir") + "/1.docx")).as(DocumentType.MS_WORD)
                    .to(fos).as(DocumentType.PDF).execute();
            converter.shutdown;
        } catch (FileNotFoundException e) {
            e.printStackTrace();
        } finally {
            try {
                if (fos != null) {
                    fos.close();
                }
            } catch (IOException e) {
                e.printStackTrace();
            }
        }

After tracing the source code, I found that the converter in documents4j needs to be shut down after it is used up, but when I call shutdown method , it would turn off the office word program in my computer.
How to code so that not close my Office Word program?

That is implicit since documents4j is running Word as your user and needs to be in controll of the singelton Word being executed.
Either run Word as your own user or modify the shutdown script. You can set shutdown.vbs to a script of your choosing and configure this via command line variables. Check the MicrosoftWordBridge code for details, it should be straight forward to do. You can use the same shutdown.vbs but you need to make it a no-op.
Note that Word might not start correctly with a running instance.

I modify the shutdown script , then repack. Using the new jar file resolves my problem. But as you say

:Note that Word might not start correctly with a running instance.

Why Word not start correctly again, when I close the Word manually？

The problem is the state management. You should really run documents4j on a dedicated server and user in production.

@raphw But now the question is : when I closed word, the word_start.vbs script could not be executed successfully for the first time, But I execute the start script by command for the first time , it's ok.
Why?

VBS is pretty messy and I can only guess: probably some internal state is not changed when you do it manually and this leaves VBS in a broken state. It's simply not supported to use documents4j and Word by hand at the same time.


Fix border radius on /gas

📝 Changed routes:

/gas

(view full size)

Commit 4cc497c21324b309a45ba1388bbb80ad1db52092 (https://thirdweb-hwv52vrfp-thirdweb.vercel.app).


media attr is needed for multiple sources

Now only src and type is supported. We need to set different sources for different media queries.

Fixed in 1.1.3 👍


Address CVE-2020-0187

Open vulnerability:
https://nvd.nist.gov/vuln/detail/CVE-2020-0187
Android port has patched the fix as:
https://android.googlesource.com/platform/external/bouncycastle/+/14ceec126e49f2f4748f0d540be820515cc725a6^!/#F0

Closing since the fix seems to be already available via
https://github.com/bcgit/bc-java/issues/767


Force powershell on local-exec

If you look at the code for local-exec, it turns out that it hard codes to cmd instead of doing something intelligent to see if it is run from powershell or cmd. See https://github.com/hashicorp/terraform/blob/master/builtin/provisioners/local-exec/resource_provisioner.go#L79
Unfortunately, cmd doesn't quite cleanly support multiline commands when passed using the /C arg, so instead we need to force Powershell when on windows by using the interpreter attribute.
Additionally, environment variables are read as $env:ENV_VAR on Powershell, so we need to adapt to that as well.
I also ran into issues with json encoding, where the double quotes made Powershell unhappy, so we need to escape those as well.
Testing note

[x] Test on windows box

Ok I have verified the current version works on my windows box.

Ah looks like there is still a problem with windows. Specifically, the kubectl auth system doesn't work. Since we've run into a few issues with kubectl anyway, I'll work on creating a wrapper in kubergrunt that can run arbitrary kubectl auth'd.

Thanks for the review! Going to merge this now that kubergrunt is merged.


Vertex AI Model Handler Private Endpoint Support

Tightens retry logic to service-side errors and explicit 429s, explicitly handles private Vertex AI endpoints to support request sizes above 1.5 MB, adds some sanity-checking for args to the model handler (largely private + network pairing,) and makes the example pipeline compatible with private endpoints.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Run Python_PVR_Flink PreCommit

R: @damccorm


{Packaging} Bump msrest from 0.6.21 to 0.7.0

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Packaging


[Charts] Do not check chart version in dev cycle

What this PR does / why we need it:
With the current chart version bump behavior, the charts version has
been bumped each time when there are changes in the current development
cycle but those versions are never released until the final official
release which could confuse the user.
The chart version should be bumped in the following situations:

Official release following the new Kubernetes major/minor version, we should bump at least the minor version unless there are backward-incompatible chart changes.
cloud-provider-openstack own patch version release for stable branches when there are related chart changes.

Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

Thanks.
/lgtm
/approve

/override openlab/cloud-provider-openstack-unittest


Project freezes/crashes when trying to open it in 4.4dev6

Tested versions

Reproducible in 4.4dev6
Still working in 4.4dev5

System information
Godot v4.4.dev6 - Windows 10.0.19045 - Single-window, 2 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4080 (NVIDIA; <IP_ADDRESS>94) - AMD Ryzen 7 3700X 8-Core Processor (16 threads)
Issue description
When trying to open my project, the editor completely freezes at this point:

In the console there is no error being printed, not even in verbose mode 😥
I don't have any more information - if someone knows anything else I could do to pin this problem down I gladly do so to make this report a bit more helpful
Steps to reproduce

Open my project Engraving...

Minimal reproduction project (MRP)
As I can't find out anything about the problem, it is virtually impossible to make a MRP.

Does that happen to any project or a specific projet?

I don't have any more information - if someone knows anything else I could do to pin this problem down I gladly do so to make this report a bit more helpful

If you run the editor in a debugger you can interrupt (pause) the process to see where it's at (call stack).

Does that happen to any project or a specific projet?
I tested it on my hobby project Engraving, there it happens. On a new project it doesn't happen.

I don't have any more information - if someone knows anything else I could do to pin this problem down I gladly do so to make this report a bit more helpful

If you run the editor in a debugger you can interrupt (pause) the process to see where it's at (call stack).

I will do so on Monday, I'm away for the weekend...

@quietbytes Could you open a new bug report for this? There can be many reasons for Godot to crash and since it's not clear what's the problem in @RPicster's case, we can't really expect that your crash has the same root cause.
Your crash seems to have to do with the new CSG internals using the Manifold library.

I want to see if the csg manifold crash has the root cause as https://github.com/godotengine/godot/issues/100073 and is fixed in master. So it should result in an empty mesh and fully works after the mend pr

@RPicster Ensure you are not loading on a scene that has particles. Could be related to #100098 . You can check by opening the project in an earlier dev build.

Hi, same issue with dev5 and 6 on my side. It takes a very long time to load the project and then, impossible to launch it.

it happened to me that CSG were made with before dev 6 and when I wanted to open scene it crashes
cylinders to be exact
the boxes were opening fine

@RPicster Do you spot any change in the 4.4-dev6 changelog that relates to features you're using?
https://godotengine.github.io/godot-interactive-changelog/#4.4-dev6
Are you using CSG maybe?

@MarkoGrbec Can you try Godot Engine master? https://nightly.link/godotengine/godot/workflows/runner/master?preview Remember to backup etc.

hmmm, ... I cannot even open editor let alone to try to open scene with CSG
I even tried with deleting .godot folder

@RPicster Do you spot any change in the 4.4-dev6 changelog that relates to features you're using? https://godotengine.github.io/godot-interactive-changelog/#4.4-dev6
Are you using CSG maybe?

I have no idea but I can give you MRPtesting-csg.zip
with CSG that crashes the dev-6

@RPicster Do you spot any change in the 4.4-dev6 changelog that relates to features you're using? https://godotengine.github.io/godot-interactive-changelog/#4.4-dev6
Are you using CSG maybe?

I have no idea but I can give you MRPtesting-csg.zip
with CSG that crashes the dev-6

Thanks for the MRP!
I tested it and confirm the crash in 4.4-dev6, and that the crash is fixed in the master branch already.

I Guess this happens to me too but already did since dev 3 in the tps demo on the Android editor, aside from it crashing too upon loading game(as proved here  https://github.com/godotengine/godot/issues/98330 )

I wanted to dig a bit deeper today and found out that it works on master.
So as I didn't really provide any detailed information for the bug: this is good enough for me - I will close this issue 🌟

I noticed that my project on 4.4dev6 crashes every time I call:
get_tree().paused = false
Calling
get_tree().paused = true
is fine.

I noticed that my project on 4.4dev6 crashes every time I call: get_tree().paused = false

That´s weird,  i do have crashes too, but on an android small project that it´s not empty( kinda like since 4.4 dev 1 i think, though only reported  since dev 3 in my issue  that i posted below.
About your crash, it might be because there are many things in the tree that had to be unpaused and as such caused the crash(ram/vram related?)

I noticed that my project on 4.4dev6 crashes every time I call: get_tree().paused = false

That´s weird, i do have crashes too, but on an android small project that it´s not empty( kinda like since 4.4 dev 1 i think, though only reported since dev 3 in my issue that i posted below.
About your crash, it might be because there are many things in the tree that had to be unpaused and as such caused the crash(ram/vram related?)

I just tested opening the same project with version 4.4dev5 and it doesn't happen there.
I don't know what the problem could be: the game crashes and the window closes by itself, without any errors in the console.
I am very sure the cause is the get_tree().paused = false, because I tried to call the same command from different scripts and the result is the same.
However it does not happen in a new project created with version 4.4dev6.


Is it invalid to call CommandEncoder::finish in a prepare callback function

I‘m a newer to egui, so I tried to follow other's examples. And I found that the function item type of CallbackFn::prepare had been changed. Here's a new parameter of type &mut CommandEncoder and a new return type Vec<wgpu::CommandBuffer>.
I tried to invoke CommandEncoder::finish but failed, because the CommandEncoder in the closure is a mutable reference which can't be moved by CommandEncoder::finish.
I have to steal the ownership from the reference or edit CommandEncoder::finish to make it work.
If it's allowed to call CommandEncoder::finish here, CommandEncoder should be changed to value type I think.

NOTE: @Wumpf rewrote this recently in https://github.com/emilk/egui/pull/3253

didn't see this ticket so far, don't think the mechanism has changed there much
@ACGNnsj the command encoder you get in is the one that is later on used to record egui render passes, as such you're not allowed to finish it inside of prepare since it is still used later. However, you can create new command encoders (or pass them in), finish those and return the resulting CommandBuffer. These command buffers will be executed prior to the egui command encoder but in the same wgpu::Queue::submit call which can make things quite a bit more efficient.


[Feature Request] Easily define animation curve

Hi folks,
maybe I miss something but I currently I don't see a possibility to easily define an animation-curve for the animations. I had expected, next to duration and delay, a curve property.
Would this be possible to implement?

@Klerith as you mentioned for self explanatory method names I think I doesn't make any sense, but for the rest of them it does.
e.g. if I'm using SlideInUp I'd like to have different animation curves

@rubenaster @erperejildo
I like it; I was skeptical at the beginning, however, this example looks awesome.
It will be part of the next release, V.3.3.0

FadeIn(
                  animate: animate,
                  curve: Curves.easeInOutCubicEmphasized,
                  duration: const Duration(milliseconds: 1000),
                  delay: const Duration(milliseconds: 0),
                  child: const Square(),
                ),
                FadeInUp(
                  animate: animate,
                  curve: Curves.easeInOutCubicEmphasized,
                  delay: const Duration(milliseconds: 300),
                  child: const Square(),
                ),
                FadeInDown(
                  animate: animate,
                  curve: Curves.easeInOutCubicEmphasized,
                  delay: const Duration(milliseconds: 600),
                  child: const Square(),
                ),
                FadeInLeft(
                  animate: animate,
                  curve: Curves.easeInOutCubicEmphasized,
                  delay: const Duration(milliseconds: 900),
                  child: const Square(),
                ),
                FadeInRight(
                  animate: animate,
                  curve: Curves.easeInOutCubicEmphasized,
                  delay: const Duration(milliseconds: 1200),
                  child: const Square(),
                ),


Reword theme disable

Fixes https://github.com/jenkinsci/theme-manager-plugin/issues/13

Repo readme should be updated accordingly.


[widget metadata]can we do introspection to get widget metadata

some of the properties in some of the widgets have code similar to
if "showBorder" is among the keys of pProperties then
		put pProperties["showBorder"] into mShowDivide
	else
		put true into mShowDivide
	end if

which could be avoided if we could check the version metadata, and if it is under a certain value, assign those initial default values

This doesn't answer your question, but the above code is not correct.  That else clause is totally unnecessary.  OnCreate is called first and then OnLoad so there should never be a case where mShowDivide is not already initialized to true as defaults are already set at that point.
Unless you choose to save the version, the stack won't have any knowledge of what version was used stored.  The version metadata is a part of the widget itself and not the data stored in the stack file.  This is something that you, as a widget developer, would need to handle.  As long as there are just properties being added, using a new version shouldn't pose a problem.  For all of the changes that I proposed, the defaults (OnCreate) would set the widget up to match the prior version.

That is from the navBar, by the way.
It was part of what was so confusing with OnCreate() vs OnLoad(), because in the style guide, it says that defaults should be set in OnCreate() not OnLoad(), but there were a bunch of these blocks in the OnLoad() handler.
Since OnCreate() is only executed once, I think (?), when the widget is instantiated the very first time, don't you have an issue for existing widgets if a new version of the widget comes along with new properties? Will OnCreate() ever fire for those pre-existing widgets?

OT but... I wish there was a way to re-'kind' all placed widgets of a specific 'kind' after you've changed the reverse-domain identifier (ie com.livecode..), a real pain it seems there's no way to update 'kind' for already placed widgets. I've had to do this for Widget demo stacks quite a few times now. I even tried to modify the all-widgets 'kind' property in its .tsv file to make 'kind' editable to no avail (the property just reverts to previous after setting it).


DataSet.get_metadata to return value only if the casing of the tag matches the column name in the database

DataSet.get_metadata method for retrieving a metadata value for a
given tag is now case-sensitive with respect to the tag.
For example, if metadata was added with dataset.add_metadata('something', 1),
it can only be retrieved by using its exact casing of the tag,
dataset.get_metadata('something'), and not e.g.
dataset.get_metadata('SomeThinG'). In the previous versions of QCoDeS,
any casing of the tag in DataSet.get_metadata would work and return the
value stored under that tag. Note that this change brings consistency
with how getting metadata via the dataset.metadata works:
dataset.metadata['something'] does return the value, and
dataset.metadata['SomeThinG'] does not.
Also adds extra testing for one() helper function and clarifies docstrings of a few helper functions.

bors merge


Feature request - allow Mask configurations for upstream and downstream keys

I'm actually working on this right now, but I wanted to have a place to track the conversation for the "right" way to implement it.
Right now, I've got all 5 values in one action:

enabled
top
bottom
left
right

However, my gut is telling me to have two separate actions. One for:

enabled

and one for:

top
bottom
left
right

What does everyone else think?

Have a look at what I did for https://github.com/bitfocus/companion-module-bmd-atem/blob/master/src/actions.ts#L968-L1009.
Essentially, there is a multi-select dropdown which chooses which fields you wish to set, and then based on the selected fields the 'isVisible' functions on each input will show/hide each input, and when executing it will only set the selected properties
I suppose that could also have been done for https://github.com/bitfocus/companion-module-bmd-atem/pull/189, but with it being so few properties it feels a bit excessive.

Interesting. Seems pretty straightforward. I'll go down that path.

I believe this is done


mfc5890cn{lpr,cupswrapper}: init

Motivation for this change
Printer does not support IPP and the generic brother drivers available are not compatible with this printer.
Shoutout
These packages are largely based on the packages of mfc9140cdn, added in #125890. Therefore want to thank @mweinelt for his previous work. Thank you very much!!
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
[x] After installing pkgs.mfc5890cncupswrapper to services.printing.drivers in configuration.nix, the driver is available in the CUPS dashboard
[x] After adding a Brother MFC-5890CN printer via network connection to CUPS (as per instructions of Brother via the connection string lpd://${IP_ADDRESS}/binary_p1), I can print a sample page.
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@mweinelt Thank you very much for your review, I have addressed the issues you raised and updated this PR.


Added snippet to read RDS files in an R notebook

Currently, the page only provides examples for CSV files. I'd like to add a snippet that I developed to read RDS files from a datastore using a filestore object.

@microsoft-github-policy-service agree

I tried adding the compression as an argument to open, because the AzureMachineLearningFileSystem class should be a subclass of AbstractFileSystem and the API docs of fsspec specifies that you can provide the compression type, but it didn't change the bytes read at all...

@sdgilley
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Thank you for contributing to this Azure documentation. Unfortunately, changes to Machine Learning content can't be accepted this week. The Skilling Content group is migrating this content to a new repository: azure-ai-docs.
In the meantime, we are closing this PR and tagging it so that when the content is available in the new repo, we can follow up with new location information.
#label:"migrate-followup"
#please-close

@wangwiza We’re happy to share that contributions to machine-learning, ai-studio, ai-services, genomics, open-datasets, search are once again possible at azure-ai-docs. We appreciated your patience during this migration.
Find your article in the new repository and make the changes there (or copy/paste the raw markdown from your changed file) and open a new PR.
#remove-label:"migrate-followup"


A discord server

You guys should make a discord server so people can ask for help and support. The server chat can be nuked every 1 day so the server doesn't get termed. Also you guys can use terms like reet/r4t instead of rat so it doesn't get termed because of malicious intentions. If you guys have a discord server already please invite me in it

or if someone can drop his discord here, cause i want to talk with him something.

You guys should make a discord server so people can ask for help and support. The server chat can be nuked every 1 day so the server doesn't get termed. Also you guys can use terms like reet/r4t instead of rat so it doesn't get termed because of malicious intentions. If you guys have a discord server already please invite me in it

no time for handling a server, helping people or making sure it doesnt get termed

or if someone can drop his discord here, cause i want to talk with him something.

look at my profile, my discord is there

You guys should make a discord server so people can ask for help and support. The server chat can be nuked every 1 day so the server doesn't get termed. Also you guys can use terms like reet/r4t instead of rat so it doesn't get termed because of malicious intentions. If you guys have a discord server already please invite me in it

no time for handling a server, helping people or making sure it doesnt get termed

i can help you guys with it, i've been managing couple of servers including mine that i succeed to get at 3k members and couple more.


Bernies context fixes

Description
A bunch of changes and cleanup at the point where the context is created.

Created a User object that gets added to the context for use by the resolvers
Added a logger to the context (Winston) for easier logging
Added a couple environment variables to set the log level and the URI of the JWKS
Added some auth checks to resolver to show how to use the User object

 Profile Info not persisting.

Doesn't look like this made into master... closing the PR so I can delete the branch


[Feature Request] Simple Typing Animation

It would awesome if Animate.css had a basic typing animation! Other projects like Typed.js have more heavy-weight scripting-based solutions that easy get unwieldy when you just need a simple typing animation, and a stylesheet-based solution would be a nice, light-weight alternative.

@eltonmesquita @daneden what do you think?
For me, we want to make the Animate.css as natural as possible we don't want to make animate.css become heavy-weight something like typed.js...
We will take a look into this and discuss it.

There are a few CSS-based solutions to this online already but the code for it isn't very clean or general enough to handle many use cases. In addition, I think this would be a very popular animation for developers (e.g. showcase what to type in the shell, etc.). I would be happy to contribute a typing animation if you guys think it's something that would fit in Animate.css!

There are a few CSS-based solutions to this online already but the code for it isn't very clean or general enough to handle many use cases. In addition, I think this would be a very popular animation for developers (e.g. showcase what to type in the shell, etc.). I would be happy to contribute a typing animation if you guys think it's something that would fit in Animate.css!

Let's wait for @eltonmesquita and @daneden to discuss it.

Hey @kevtan! Thanks for the suggestion. I think this kind of animation is pretty specific and actually non-trivial to implement in CSS alone. We have to consider different typeface character widths, effects like pausing on punctuation, etc.
Since there are alternate, dedicated libraries already out there for this kind of animation, I’d prefer not to introduce it to Animate.css, which is intentionally focused on simpler animations.


Fix migration name substitution

Faulty regex from the beginning of the project (here)

Thanks for noticing 👍
But regarding it didn't work it is probably useless or maybe it should be [_ ]

Ah, yes, actually. I was thinking the spaces get replaced in the join call a couple lines above anyway, but if the name is wrapped in quotes, they count as a single argument.


Upgrade<EMAIL_ADDRESS>

Updates to latest.
Note that @types/styled-components hasn't been updated yet since it leads to compatibility issues with our version of react. Will need to do that at the same time.

Does this fix/introduce any [rehydration] issues?

Is this something we still need to do? I mean, I assume we'll want to at some point. Do we want to do it now or hold off until later?

I would prefer to do it now and stay current. It doesn't fix our issues, and no observable changes (sorry @alloy, just now seeing your comment).

Okeydokey 👍


Feature request: record Dalfox traffic in HAR file

Hi, thank you for making Dalfox, it is a great tool.
It would be useful if Dalfox could save a HAR file with the contents of the requests that it sends to a target site. This would make it easier to combine the results from Dalfox with other tools like ZAP and review them in a GUI like Chrome dev tools.
It could be implemented by using a library like github.com/vvakame/go-harlog. In Dalfox, scanning.getTransport() could use the go-harlog http.RoundTripper to record all the requests. Dalfox could add a Dalfox-Request-Id: ${guid} header to each request and it would appear in the HAR file. The output from Dalfox (when it reports a PoC) could include a "request_id": "${guid}" so the user would know which requests in the HAR file correspond to which PoCs.
This is similar to what ZAP does, where it can record a HAR file and assigns "zap message IDs" to each entry.
I could submit a PR for this. Would that be useful?

@aidansteele
Wow, it's so nice. It's a great idea and I believe it's going to have a awesome results 🥰
(Personally, I wanted to increase support for HAR at Dalfox)
Thank you even more if you send me a Pull Request :D
Feel free to let me know if you need any help! I'll actively support you!

Thanks for the quick response! I will submit a draft PR next week to get your feedback/review.


test priority small datasets vs big dataset

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (956c4f0) 90.32% compared to head (f82ad5d) 90.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2171      +/-   ##
==========================================
+ Coverage   90.32%   90.54%   +0.21%
==========================================
  Files         265      250      -15
  Lines       16231    15492     -739
==========================================
- Hits        14661    14027     -634
+ Misses       1570     1465     -105

Flag
Coverage Δ

jobs_cache_maintenance
95.33% <ø> (ø)

jobs_mongodb_migration
86.69% <ø> (ø)

libs_libapi
?

libs_libcommon
92.18% <100.00%> (+0.08%)
:arrow_up:

services_admin
86.56% <ø> (ø)

services_api
83.69% <ø> (ø)

services_rows
81.61% <ø> (ø)

services_search
80.48% <ø> (ø)

services_sse-api
94.21% <ø> (ø)

services_worker
91.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Consider these tests have been run in an empty database.

jobs
workers
useless started job attempts
usefull time (ms)
useless time (ms)
total time (ms)
useless time %

102
25
88
50.23294044
74.77886558
125.011806
59.82%

102
50
91
55.68369579
91.09566951
146.7793653
62.06%

102
50
158
92.57473493
208.5147598
301.0894947
69.25%

302
45
153
118.4229636
138.1023927
256.5253563
53.84%

302
45
195
96.4994421
177.9030538
274.4024959
64.83%

1002
45
227
176.4738398
182.02267
358.4965098
50.77%

1002
45
236
201.5012972
233.8879504
435.3892477
53.72%

What I can see is that almost 50% of the time we are reading already started jobs which can also increase the next waiting job performance.


Inception Layers?

Are you thinking in adding Inception Layers?

It's not my priority right now (I am currently working on RNN layers).
If I understand inception layer, it is a maxout + conv 1x1 + conv 3x3 + conv 5x5 on the same input and then concatenated into one tensor on the depth dimension.
Forward pass should be achievable but I am not so sure how to make the error flow on the backward pass.
Since I don't have immediate use of such layer, I'm hoping someone will do PR for this kind of layers :)


Improve duplicate repo url error.

What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
This adds a little extra detail when we detect a duplicate repo url.
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer:

/approve

/approve


Explicit boldface in preferred

Because of https://github.com/metanorma/metanorma-iso/issues/554, preferred is no longer to be rendered as boldface by default: the designation within the preferred term in the Presentation XML is indicated to be boldface explicitly:
<preferred>человек, ед.</preferred>
If the PDF XSLT does assume that the contents of preferred are all boldface, please remove that assumption.

Done:


Not working when there are more than one contacts apps

We have a Samsung Galaxy S9 and it has two contacts apps. It lets us choose which app, then it shows the list of contacts, but when we select a contact, the result is "OPERATION_CANCELLED_ERROR".
More specifically, the second app is the app "Drupe". If we select a default contacts app, everything works fine.

I'm facing the same problem, did you find any solution?

We are archiving this repository following Apache Cordova's Deprecation Policy. We will not continue to work on this repository. Therefore all issues and pull requests are being closed. Thanks for your contribution.


3315 Genesis address format - address size and type change

Motivation

Closes #3315

Changes

address moved to separate pkg. probably in future will be as independent library
address still array of bytes ([24]byte), but implement bech32 algorithm. Additional first byte reserved for contain HumanReadablePart of address (now contain info about networkID - test|main net), so result is [25]byte
all api endpoints will be changed to use string instead []byte (related pr https://github.com/spacemeshos/api/pull/173)

Test Plan
unit tests
TODO

[ ] Explain motivation or link existing issue(s)
[ ] Test changes and document test plan
[ ] Update documentation as needed

DevOps Notes

[ ] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[ ] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

could you please use aliases for such refactoring?
package types

type Address = address.Address

they were created specifically to make such changes reviewable

one of idea was to move address implementation to separate library, which will be included as dependency

This is not a terrible idea - do we think other projects will have this dependency? (And would they want to use just an address module without relying on all of go-spacemesh?) E.g., sm-repl, dash/explorer, etc.

one of idea was to move address implementation to separate library, which will be included as dependency

This is not a terrible idea - do we think other projects will have this dependency? (And would they want to use just an address module without relying on all of go-spacemesh?) E.g., sm-repl, dash/explorer, etc.

but why? what is the problem with having the impl inside common/types/address.go? the functionality you are providing in the new pkg look highly similar to the old ones. @abergasov

This is not a terrible idea - do we think other projects will have this dependency? (And would they want to use just an address module without relying on all of go-spacemesh?) E.g., sm-repl, dash/explorer, etc.

there is no strong arguments that we should move it to separate pkg, only this 2:

our possibly moving address in separate lib in future

i think this is a future thing and should be separated from this discussion.

current situation in common/types, where we have 25 different files aka 25 different types (there are total 33 files with tests) and some of this files contains lot of code - this look like place where we can add more pkg separation and make it more strict

right. but changing only 1 makes it even more confusing. i'd support if you make a sweeping change later to change all of them. but the code inside each file (tho large) are mostly very simple code... i personally don't think it's worth the effort now.

if you think that it better move back to common/types - ok, i'll do. arguments for separate pkg not very strong

that will be my preference. and worry about separate library when the use case arise.

bors try

what about system tests?

i thought that it was merged. is there any reason why it is still open?


Create plots with t0 as a vertical line

To make quick inspection of trajectories and their progress towards
equilibration, being able to quickly generate plots over a data space to
inspect with signac dashboard will make our lives much easier.
This is not feature complete, features like matplotlib plotting kwargs
and other options will be exposed to the user, which will be implemented
in the analysis module.
Simple example using a `pymbar.testsystems.correlated_timeseries_example(N=10000, tau=200)

The vertical line is the t0 that maximizes the amount of uncorrelated samples from pymbar.detectEquilibration

Not the best, but for an initial and quick screen, should be good. Next steps will be in a separate PR which will operate on a job, and use statepoint info as additional formatting.

Ive cleaned things up a bit. @jennyfothergill or anyone else who already has a "log.txt" file, can one of yall test this to make sure it is behaving as expected?

Just tested on a sample log.txt from @jennyfothergill , seems to be working well!

Not the best, but for an initial and quick screen, should be good. Next steps will be in a separate PR which will operate on a job, and use statepoint info as additional formatting.

Forgive me if this is a nitpick, but Neff is the number of uncorrelated samples, right? Let's format it as an integer.

Completely correct and I have changed this now. I also had some bugs where dictionaries were being passed by reference, and would be left with previous values in the label if you tried to plot multiple properties in a single session (like an ipython instance). This has been fixed. I also reduced the scaling and made it behave much better than before.


Create SECURITY.md

Types of changes

[ ] Update npm packages
[ ] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Performance improvement
[ ] Refactoring (so no functional change)
[x] Other (docs, build config, etc)

Checklist:

[ ] I've added tests for my code. (most of the time mandatory)
[ ] I have added an entry to the changelog. (mandatory)
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Codecov Report

Merging #19 (db4c3c1) into main (54b00ad) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          143       143
  Lines         7142      7142
  Branches       674       674
=========================================
  Hits          7142      7142


Lenovo Drivers:  You cannot call a method on a null-valued expression

Specifically trying to get the Thinkpad T490s (20NY) drivers for Windows 10 x64.  If I go to the URL in the logs I end up on a page that has no download links, which obviously leads to the driver lookup function not returning a null value instead of an array of links.
The URL in the logs is https://support.lenovo.com/downloads/ds506553 which for me redirects to https://support.lenovo.com/us/en/downloads/ds506553
I get the same page if I try to search Lenovo's site for SCCM driver packs.  Looks like it might be an issue on Lenovo's end.  This isn't the only Lenovo model I get this for, but it is the one I was specifically looking for.  I submitted feedback on Lenovo's site, hopefully that will fix things.

Update, it isn't because there are no download links (which right now I am only seeing if I load the page in IE)  It is from this line
The results I am getting from testing this, there is no $ie.Document.ParentWindow however $ie.Document exists.
This is on Server 2016.  It looks like this may be what is happening:
https://stackoverflow.com/questions/53511837/using-powershell-to-run-javascript-in-internet-explorer-on-windows-server
I also tried running this on Windows 10 v1909 and IE is not installed by default so it failed to create the $ie object.  Haven't figured out if there is a way to accomplish the same thing with Invoke-WebRequest yet.


[Addition] Code of Conduct

The project is currently missing the Code of Conduct which defines standards for how to engage in a community. If you are interested in adding that, then I would want to add a PR with that.
Please let me know what do you think about that.

Should the code of conduct forbid swearwords?

Should the code of conduct forbid swearwords?

Please let me add a Pull Request first. Then it would be helpful to discuss that,

well folks...

As described by this project's Code of Conduct this is not an acceptable way to address someone. Apologize immediately and also give me five dollars for taking the time to speak to you about this matter.


Audit trail of using the AI functionality

Should we keep an audit log of editors using AI functionality in any shape or form? Given there are cost implications here, it may be beneficial for administrators to be able to monitor this in some ways.
We could just expose standard logs or use the Wagtail audit trail.

I think this is covered by #82? Do you want to add any additional thoughts there?

Yep, a duplicate! Sorry.


WebTransport support

Hi, is WebTransport supported, or is there a plan to do so? Or does it not belong in aioquic? Keen to use it in Python and trying to figure out if it's already there or on the roadmap or what the right building blocks would be to impl if needed.

https://github.com/aiortc/aioquic/tree/main/examples#webtransport

Amazing, thank you.


Fixes serialization of two Adviser fields in Investment search.

Codecov Report

Merging #294 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #294   +/-   ##
========================================
  Coverage    92.87%   92.87%
========================================
  Files           63       63
  Lines         2427     2427
  Branches       215      215
========================================
  Hits          2254     2254
  Misses         145      145
  Partials        28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d8591...e27f3ff. Read the comment docs.


Clarify naming convention for UTRs

Comment rising from preparing D.mel annotation for Riboviz.
It is not currently clear what the required naming convention is for untranslated regions in GFF files, and this convention varies between files in the repo.
For example:

Yeast CDS with 250UTRs uses "UTR5" and "UTR3"
Yeast UTR GFF uses "five_prime_UTR" and "three_prime_UTR"

When the convention "five_prime_UTR" and "three_prime_UTR" is used in the GFF, this is not flagged as an error by the riboviz.tools.check_fasta_gff tool. However, this causes Riboviz to fail.

Can be handled by documentation.

A quick fix would be to update documentation to recommend users edit their GFF file to replace the latter with the former. A more time-consuming solution would be to update bam_to_h5_functions.R to replace the hard-coded "UTR5" and "UTR3" occurrences with values from command-line parameters which could be provided via configuration parameters.


Fill out an initial DV plan for the icache

This currently has quite a lot of TBD sections, but should hopefully
describe my plan for the UVM testing reasonably well.

This took a few days since PR #711 landed because it seemed much easier to make sure I had the UVM hierarchy right by writing some code. So far, I have the core and memory agents implemented (but no error checking, so it's not exactly a testbench yet).

Handy link for Github's rendering of the markdown: https://github.com/rswarbrick/ibex/blob/icache-dv-plan/dv/uvm/icache/doc/ibex_icache_dv_plan.md

Thanks for all your feedback on this PR Udi. Just as a meta-point, I think Rupert took the approach of (for now) avoiding the custom syntax that relies on tooling that only exists in the OpenTitan repo. There's a discussion to be had about that (is that the right path? should we instead import OT tooling? Or instead commit this DV plan to OT?). But in order to keep things focused, I propose we park that question and circle back to it after agreeing the substance of the plan.

@asb - Sure, that makes sense to me. I tried to limit the discussion to just involve the tooling that is already used (or going to be used) for Icache DV work (dv_lib libraries, dvsim, uvmdvgen, so on).
We can circle back to this later down the road.

Hi @udinator, Thanks for the comments. I'll push up a new version this morning to drop the extra agent and clarify how the scoreboard checks returned data.

@sriyerg I understand your note about the testplan, but don't think it really makes sense to write that without a rough block diagram for the testbench, and I'm blocked on implementing the testbench until you and Udi say you're ok with the basic design - I don't want to write thousands of lines of code and then have to rework them all.
If you think this DV plan is a reasonable start (and describes a sane framework), maybe the best thing to do is to merge this and hash out details later, in parallel with actually building the thing.

New version pushed. The only change is re-instating the line about DV_LIB.

The current state of this PR: I've just resolved any conversations that I think have closed (with one person or another going "ok, shall do". There's one discussion about Makefiles that I don't want to close in case Sri wants to reply, but I believe think the only remaining sticking point is:

Deleted links. These links won't work (because this isn't in the OT repo). Should we retain bullet items or not?

I have a remaining action item, to fix up (and replace) the tb.svg block diagram in the expected format, which I'll try to do this afternoon.
Is there anything I've missed?

I've just pushed up a version with a testbench diagram in the style of the other OpenTitan block diagrams. This also re-instates the "Current Status" section that @sriyerg asked for. I believe the only remaining sticking point is whether we direct users to run dvsim.py directly or do my preferred approach of wrapping it with Make to run builds (which is what I'm going to do when actually developing the DV code).

I believe that I have made all the changes requested. @sriyerg, @udinator: Is there anything else you think needs to change before this can be merged?

I think it's good to go, we can make any necessary changes later down the road.


how to specify prettier execution with params?

it is possible to execute prettier from CLI with arguments, for example prettier --single-quote --trailing-comma=all.
I'd like to have similar thing, but from VS Code. So, for example whenever I run prettier using prettier plugin in VS Code it will be called with provided params.
is it possible to do this ?

If you want to run prettier from the CLI you have to install it using npm and it is unrelated to this plugin.
If you want to execute prettier with some settings inside vscode, you can use all of these settings:
// Use 'prettier-eslint' instead of 'prettier'. Other settings will only be fallbacks in case they could not be inferred from eslint rules.
"prettier.eslintIntegration": false,

// Fit code within this line limit
"prettier.printWidth": 80,

// Number of spaces it should use per tab
"prettier.tabWidth": 2,

// Use the flow parser instead of babylon (deprecated, use 'parser:"babylon"' instead)
"prettier.useFlowParser": false,

// If true, will use single instead of double quotes
"prettier.singleQuote": false,

// Controls the printing of trailing commas wherever possible
"prettier.trailingComma": "none",

// Controls the printing of spaces inside object literals
"prettier.bracketSpacing": true,

// If true, puts the `>` of a multi-line jsx element at the end of the last line instead of being alone on the next line
"prettier.jsxBracketSameLine": false,

// Override the parser. You shouldn't have to change this setting.
"prettier.parser": "babylon",

// Whether to add a semicolon at the end of every line
"prettier.semi": true,

// Indent lines with tabs
"prettier.useTabs": false,

// Advanced feature. Enable and use 'prettier.parser' parser for those language ids. Restart required
"prettier.javascriptEnable": [
  "javascript",
  "javascriptreact"
],

// Advanced feature. Enable and use typescript parser for those language ids. Restart required
"prettier.typescriptEnable": [
  "typescript",
  "typescriptreact"
],

// Advanced feature. Enable and use postcss parser for those language ids. Restart required
"prettier.cssEnable": [
  "css",
  "less",
  "scss"
],

// Advanced feature. Enable and use json parser for those language ids. Restart required
"prettier.jsonEnable": [
  "json"
],

// Advanced feature. Enable and use graphql parser for those language ids. Restart required
"prettier.graphqlEnable": [
  "graphql"
]

@RobinMalfait thank you so much, this is exactly what I'm looking for

Answered so closing.


hg build "Could not create a working copy"

it couldn't create /var/www/html/runtime/builds/18_df216\ build folder?
it is does not exist.
Args: ["hg clone %s "%s" -r %s","https://myip/site/","/var/www/html/runtime/builds/18_df216/","prod"]
Command: hg clone https://myip/site/ "./" -r prod
abort: error: Try again
Execution status: 255
Failed to clone remote hg repository.
Exception: Could not create a working copy.
BUILD FAILED

@spfuture Please see #21, may be it is connected problems. Can you check permitions on runtime/builds directory?

Yes.


Sourcemap for "X.ts" points to missing source files

Describe the bug
I currently have the following configuration for my Vite & Vue.js project:
import { defineConfig } from 'vite'

import vue from '@vitejs/plugin-vue'
import WindiCSS from 'vite-plugin-windicss'

import typescript from '@rollup/plugin-typescript'

// https://vitejs.dev/config/
export default defineConfig({
  plugins: [
    // https://github.com/antfu/vite-plugin-windicss
    WindiCSS({
      safelist: '',
    }),
    typescript({
        tsconfig: './tsconfig.json'
    }),
    vue()
  ]
})

And on running the following command:
npm run dev -- --host --port 8099

And navigating to localhost:8099 in the browser I am seeing these errors:
Sourcemap for "/Users/michael/Developer/observerly/aestrium/src/main.ts" points to missing source files
Sourcemap for "/Users/michael/Developer/observerly/aestrium/src/components/index.ts" points to missing source files
Sourcemap for "/Users/michael/Developer/observerly/aestrium/src/composables/index.ts" points to missing source files
Sourcemap for "/Users/michael/Developer/observerly/aestrium/src/composables/useAdjustedScreen/index.ts" points to missing source files
Sourcemap for "/Users/michael/Developer/observerly/aestrium/src/composables/useCanvas/index.ts" points to missing source files
Sourcemap for "/Users/michael/Developer/observerly/aestrium/src/composables/useDimensions/index.ts" points to missing source files
Sourcemap for "/Users/michael/Developer/observerly/aestrium/src/composables/useCardinals/index.ts" points to missing source files
Sourcemap for "/Users/michael/Developer/observerly/aestrium/src/composables/useEcliptic/index.ts" points to missing source files
Sourcemap for "/Users/michael/Developer/observerly/aestrium/src/composables/useInteractions/index.ts" points to missing source files
Sourcemap for "/Users/michael/Developer/observerly/aestrium/src/composables/useConstellations/index.ts" points to missing source files
Sourcemap for "/Users/michael/Developer/observerly/aestrium/src/composables/useMoon/index.ts" points to missing source files
Sourcemap for "/Users/michael/Developer/observerly/aestrium/src/utils/index.ts" points to missing source files
Sourcemap for "/Users/michael/Developer/observerly/aestrium/src/composables/useStars/index.ts" points to missing source files
Sourcemap for "/Users/michael/Developer/observerly/aestrium/src/composables/useSun/index.ts" points to missing source files
Sourcemap for "/Users/michael/Developer/observerly/aestrium/src/utils/canvas.ts" points to missing source files
Sourcemap for "/Users/michael/Developer/observerly/aestrium/src/utils/intersectDistance.ts" points to missing source files

Although the app works 100% fine, I believe these are just warnings.
I've looked through the documentation as to why this could be happening, but nothing suggests why. There is a build.sourcemap flag I could add, but no dev.sourcemap (a similar one exists for CSS css.devSourcemap) ...
Reproduction
https://github.com/observerly/aestrium
System Info
System:
    OS: macOS 12.2.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 894.11 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 17.6.0 - /usr/local/bin/node
    npm: 8.5.3 - /usr/local/bin/npm
  Browsers:
    Chrome: 100.0.4896.60
    Firefox: 98.0.2
    Firefox Developer Edition: 99.0
    Safari: 15.3
  npmPackages:
    @vitejs/plugin-vue: ^2.3.1 => 2.3.1
    vite: ^2.9.1 => 2.9.1

### Used Package Manager

npm

### Logs

```shell
> vue-tsc --noEmit && vite build "--debug"

  vite:config bundled config file loaded in 242.30ms +0ms
  vite:config using resolved config: {
  vite:config   plugins: [
  vite:config     'vite:build-metadata',
  vite:config     'alias',
  vite:config     'vite-plugin-windicss:alias',
  vite:config     'vite-plugin-windicss:groups',
  vite:config     'vite:modulepreload-polyfill',
  vite:config     'vite:resolve',
  vite:config     'vite:html-inline-proxy',
  vite:config     'vite:css',
  vite:config     'vite:esbuild',
  vite:config     'vite:json',
  vite:config     'vite:wasm',
  vite:config     'vite:worker',
  vite:config     'vite:asset',
  vite:config     'vite-plugin-windicss',
  vite:config     'vite-plugin-windicss:css',
  vite:config     'vite-plugin-windicss:css:svelte',
  vite:config     'vite-plugin-windicss:devtools',
  vite:config     'typescript',
  vite:config     'vite:vue',
  vite:config     'vite:define',
  vite:config     'vite:css-post',
  vite:config     'vite:build-html',
  vite:config     'vite:worker-import-meta-url',
  vite:config     'vite:watch-package-data',
  vite:config     'commonjs',
  vite:config     'vite:data-uri',
  vite:config     'rollup-plugin-dynamic-import-variables',
  vite:config     'vite:asset-import-meta-url',
  vite:config     'vite-plugin-windicss:entry',
  vite:config     'vite:build-import-analysis',
  vite:config     'vite:esbuild-transpile',
  vite:config     'vite:terser',
  vite:config     'vite:reporter',
  vite:config     'vite:load-fallback'
  vite:config   ],
  vite:config   build: {
  vite:config     target: [ 'es2019', 'edge88', 'firefox78', 'chrome87', 'safari13.1' ],
  vite:config     polyfillModulePreload: true,
  vite:config     outDir: 'dist',
  vite:config     assetsDir: 'assets',
  vite:config     assetsInlineLimit: 4096,
  vite:config     cssCodeSplit: true,
  vite:config     cssTarget: [ 'es2019', 'edge88', 'firefox78', 'chrome87', 'safari13.1' ],
  vite:config     sourcemap: false,
  vite:config     rollupOptions: {},
  vite:config     minify: 'esbuild',
  vite:config     terserOptions: {},
  vite:config     write: true,
  vite:config     emptyOutDir: null,
  vite:config     manifest: false,
  vite:config     lib: false,
  vite:config     ssr: false,
  vite:config     ssrManifest: false,
  vite:config     reportCompressedSize: true,
  vite:config     chunkSizeWarningLimit: 500,
  vite:config     watch: null,
  vite:config     commonjsOptions: { include: [Array], extensions: [Array] },
  vite:config     dynamicImportVarsOptions: { warnOnError: true, exclude: [Array] }
  vite:config   },
  vite:config   define: { __VUE_OPTIONS_API__: true, __VUE_PROD_DEVTOOLS__: false },
  vite:config   ssr: { external: [ 'vue', '@vue/server-renderer' ] },
  vite:config   configFile: '/Users/michael/Developer/observerly/aestrium/vite.config.ts',
  vite:config   configFileDependencies: [ '/Users/michael/Developer/observerly/aestrium/vite.config.ts' ],
  vite:config   inlineConfig: {
  vite:config     root: undefined,
  vite:config     base: undefined,
  vite:config     mode: undefined,
  vite:config     configFile: undefined,
  vite:config     logLevel: undefined,
  vite:config     clearScreen: undefined,
  vite:config     build: {}
  vite:config   },
  vite:config   root: '/Users/michael/Developer/observerly/aestrium',
  vite:config   base: '/',
  vite:config   resolve: { dedupe: undefined, alias: [ [Object], [Object] ] },
  vite:config   publicDir: '/Users/michael/Developer/observerly/aestrium/public',
  vite:config   cacheDir: '/Users/michael/Developer/observerly/aestrium/node_modules/.vite',
  vite:config   command: 'build',
  vite:config   mode: 'production',
  vite:config   isWorker: false,
  vite:config   isProduction: true,
  vite:config   server: {
  vite:config     preTransformRequests: true,
  vite:config     fs: { strict: true, allow: [Array], deny: [Array] }
  vite:config   },
  vite:config   preview: {
  vite:config     port: undefined,
  vite:config     strictPort: undefined,
  vite:config     host: undefined,
  vite:config     https: undefined,
  vite:config     open: undefined,
  vite:config     proxy: undefined,
  vite:config     cors: undefined,
  vite:config     headers: undefined
  vite:config   },
  vite:config   env: { BASE_URL: '/', MODE: 'production', DEV: false, PROD: true },
  vite:config   assetsInclude: [Function: assetsInclude],
  vite:config   logger: {
  vite:config     hasWarned: false,
  vite:config     info: [Function: info],
  vite:config     warn: [Function: warn],
  vite:config     warnOnce: [Function: warnOnce],
  vite:config     error: [Function: error],
  vite:config     clearScreen: [Function: clearScreen],
  vite:config     hasErrorLogged: [Function: hasErrorLogged]
  vite:config   },
  vite:config   packageCache: Map(0) { set: [Function (anonymous)] },
  vite:config   createResolver: [Function: createResolver],
  vite:config   optimizeDeps: {
  vite:config     esbuildOptions: { keepNames: undefined, preserveSymlinks: undefined }
  vite:config   },
  vite:config   worker: {
  vite:config     format: 'iife',
  vite:config     plugins: [
  vite:config       [Object], [Object], [Object],
  vite:config       [Object], [Object], [Object],
  vite:config       [Object], [Object], [Object],
  vite:config       [Object], [Object], [Object],
  vite:config       [Object], [Object], [Object],
  vite:config       [Object], [Object], [Object],
  vite:config       [Object], [Object], [Object],
  vite:config       [Object], [Object], [Object],
  vite:config       [Object]
  vite:config     ],
  vite:config     rollupOptions: {}
  vite:config   }
  vite:config } +120ms
vite v2.9.1 building for production...
✓ 35 modules transformed.
[plugin:typescript] @rollup/plugin-typescript: Rollup 'sourcemap' option must be set to generate source maps.
dist/src/index.d.ts                                 0.11 KiB
dist/src/main.d.ts                                  0.03 KiB
dist/src/components/index.d.ts                      0.07 KiB
dist/src/components/SkyViewer/SkyViewer.d.ts        0.10 KiB
dist/src/composables/index.d.ts                     1.08 KiB
dist/src/composables/useAdjustedScreen/index.d.ts   0.10 KiB
dist/src/composables/useCanvas/index.d.ts           1.07 KiB
dist/src/composables/useCardinals/index.d.ts        1.48 KiB
dist/src/composables/useConstellations/index.d.ts   1.92 KiB
dist/src/composables/useDimensions/index.d.ts       0.46 KiB
dist/src/composables/useEcliptic/index.d.ts         1.64 KiB
dist/src/composables/useInteractions/index.d.ts     0.76 KiB
dist/src/composables/useMoon/index.d.ts             1.81 KiB
dist/src/composables/useStars/index.d.ts            2.16 KiB
dist/src/composables/useSun/index.d.ts              1.69 KiB
dist/src/types/index.d.ts                           0.07 KiB
dist/src/types/SkyViewer/index.d.ts                 1.65 KiB
dist/src/utils/canvas.d.ts                          0.92 KiB
dist/src/utils/index.d.ts                           0.12 KiB
dist/src/utils/intersectDistance.d.ts               0.37 KiB
dist/index.html                                     0.44 KiB
dist/assets/index.efebb9d2.css                      1.77 KiB / gzip: 0.83 KiB
dist/assets/index.9e05da30.js                       343.63 KiB / gzip: 96.98 KiB

### Validations

- [X] Follow our [Code of Conduct](https://github.com/vitejs/vite/blob/main/CODE_OF_CONDUCT.md)
- [X] Read the [Contributing Guidelines](https://github.com/vitejs/vite/blob/main/CONTRIBUTING.md).
- [X] Read the [docs](https://vitejs.dev/guide).
- [X] Check that there isn't [already an issue](https://github.com/vitejs/vite/issues) that reports the same bug to avoid creating a duplicate.
- [X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
- [X] Check that this is a concrete bug. For Q&A open a [GitHub Discussion](https://github.com/vitejs/vite/discussions) or join our [Discord Chat Server](https://chat.vitejs.dev/).
- [X] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.

Is this related to the following PR: PR 7442 ? I have recently updated to the most recent version but I am guessing these changes haven't been added to a release yet?

Your reproduction links to 404. It seems it is a private repository.

Your reproduction links to 404. It seems it is a private repository.

Let me know if you want access to it I can add you as temp maintainer.

If it is not a minimal reproducible example, could you create it?

If it is not a minimal reproducible example, could you create it?

It's a maximum reproducible example ... i.e., the actual code base with the error.

@michael-observerly We need a minimal repro so that it's simpler to debug what causes the issue. A full scale app as a repro could introduce a lot of places to look for, making it hard to resolve the issue.

@bluwy Would you be happy if I started from a template just created: https://stackblitz.com/edit/52908eea-914c-4188-9920-784a3a0d8eb3-du2mmh

The template looks good to me. There is a Vite + Vue 3 template though:

Closing this issue as setting the sourceMap flag in tsconfig.json seems to remove the error:
   ...
   "sourceMap": false, /* Generates corresponding '.map' file. */
   ...


Salsa does not warn or help when passing in wrong argument type

Testing #2218
/**
 * @param {string} name
 */
function howdy(name) {

}

howdy(3);

even if it knows a string is expected:

Correct. We explicitly decided to give no warnings/errors other than syntax errors for JavaScript code. If warnings on incorrect type usage are required, we'd need to spec how and when these would occur in JavaScript, else being based on TypeScript, code such as the below would also be a type error:
var x = 10;
var x = "ten";

var y = {a:true};
y.b = false;

In the existing Code JS language service we gave warnings for the first example above and we didn't receive complaints.

We have also warned about undefined variables, which had issues when users where also using a linter in their project and they defined a global as a global in their linter configuration. The confusion was that they define the global in linter configuration, but our JS service still warned about the global.

This issue was moved to Microsoft/TypeScript#6658


KAFKA-5121: Implement transaction index for KIP-98

retest this please

I realized that the relationship between the LSO and the high watermark is trickier than I originally thought. I had assumed that it was sufficient to take the minimum of the two as the maximum offset that a client could fetch in READ_COMMITTED mode. The issue is when the COMMIT or ABORT marker itself is larger than the high watermark. We need to ensure that none of the records from the associated transaction becomes readable until the marker itself is replicated (even if the records have offsets lower than the high watermark). This requires a little more bookkeeping as we need to keep track of which transactions have been completed, but are not replicated. I'll update the patch as soon as I have a solution ready.

retest this please

note to self: once the transactional client patch lands, we should update Fetcher to use the control sequence number when finding the commit/abort markers.

@junrao I've added a commit to do transaction index recovery. The approach I've taken is the following:

I've removed the periodic PID snapshot.
Instead, when the log rolls, I take a new snapshot using the offset of the new segment.
When a segment has been flushed to disk, I remove the corresponding snapshot. The snapshot corresponding the start of the active segment is never removed.
When recovering a segment, I have to read the log from the starting segment in the worst case in order to rebuild the transaction index. Once finished rebuilding an individual segment, I take another snapshot so that we don't have to repeat the same work if we have to recover another segment. To make this efficient, I ensure that logs are loaded/recovered in ascending order.
When the log is cleanly closed, I take another snapshot. I was a bit unsure of the benefit of this. If we can always or usually expect to truncate upon startup, then perhaps the benefit is low and we need to revisit periodic PID expiration to reduce the chance that we have to scan the last segment upon initialization.

@hachikuji : Thanks for the patch. LGTM.

I will let you merge this after running the system tests.

@junrao Thanks for the review cycles. System tests are looking good: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2017-05-05--001.1494059152--hachikuji--eos-txn-index--64671d8/report.html. I am going to look at a couple of the build failures above before merging to see if they could be related.

retest this please

It looks like the recent transient failures are known issues: https://issues.apache.org/jira/browse/KAFKA-5183, https://issues.apache.org/jira/browse/KAFKA-5182, https://issues.apache.org/jira/browse/KAFKA-5175. In one of the previous builds, I saw a failure in kafka.server.LogRecoveryTest.testHWCheckpointWithFailuresSingleLogSegment. This could be related to this patch and there is no active JIRA, so I'm trying to reproduce it locally.

I was able to reproduce the failure in LogRecoveryTest locally and it didn't occur in the last few builds. I went ahead and increased the timeout that failed just in case. I'm going to go ahead and merge this to trunk.


Add flags to VarInfo

Resolving #389 and #391 by adding another filed to VarInfo called flags
TODOs

[x] get rid of the use of NULL
[x] turn flags to VarName-wise

Sparse by dictionary or not?

[x] genearlize the signature of flags by macro better function signature

@yebai Do we still want the feature of VarInfo which supports storing multiple chains in the same time, which we never use, i.e. make vi.spl a vector of vector.

@emilemathieu I introduced a function set_retained_vns_del_by_spl! in varinfo.jl to replace our previous getretain and set to NULL statement (the function is almost the same as getretain). Because of it we actually don't need getretain. Do think we can just remove it?

Another design issues I was thinking of is: should we make flags sparse or dense
i) sparse: if we assume only a small part of variables will be set a flag, a set/hash map to represent the flag is more memory-efficient
ii) dense: if most of the variables will be set flags, an array based implement is good

Maybe a test could be useful (or modifying existing test)s to check that vi.flags is built and updated as planned. Otherwise, this PR seems right !

Good suggestion. I will add some tests for vi.flags!

Left to discuss

[ ] merge trans or not
[ ] sparse or dense


Picard CollectGcBiasMetrics stand alone script

Calculates GC metrics for a CRAM file using Picard CollectGcBiasMetrics.
Successful batch - https://batch.hail.populationgenomics.org.au/batches/439455/jobs/1

Unfamiliar with picard, but would it be possible to drop down the resource requirements to make the run cheaper? I just requested the same amount of resources used by jobs in picard.py.

Just did a bit of scrounging around and saw SnakeMake documentation requests 1Gb (https://snakemake-wrappers.readthedocs.io/en/0.75.0/wrappers/picard/collectgcbiasmetrics.html) though it's not clear what data that would be applicable to but to me it suggests we could get away with a STANDARD machine?

yay, using 1 cpu and standard mem worked: https://batch.hail.populationgenomics.org.au/batches/439618/jobs/1, cost dropped by 1/3

dynamic storage sizing is working nicely - https://batch.hail.populationgenomics.org.au/batches/440034/jobs/1


flutter format -n no longer works

We recently had to implement a workaround in flutter/samples (#841) due to a breaking change in the flutter command line tool. This command no longer works in the dev channel:
flutter format -n --set-exit-if-changed .
We'd been relying on -n to suppress output to our GitHub Action workflow, and had to change to -o none in order to achieve the existing behavior with the new version of the SDK.

CC: @jonahwilliams


Create custom link preview for each post

Currently when the user clicks the share via Whatsapp button the preview that whatsapp generates for that link is the same for every post. It would be nice if the title and image of that preview could be the description and image of the specific post.

In process

Yes @matcom-chacha, you can have the issue 😂

Thanksss : )


[SPARK-13794][SQL] Rename DataFrameWriter.stream() DataFrameWriter.startStream()

What changes were proposed in this pull request?
The new name makes it more obvious with the verb "start" that we are actually starting some execution.
How was this patch tested?
This is just a rename. Existing unit tests should cover it.

Test build #52811 has started for PR 11627 at commit a3d0e26.

LGTM.

Test build #52811 has finished for PR 11627 at commit a3d0e26.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52811/
Test PASSed.

Thanks - merging in master.


Release 1.0.2 for pypi/cadet as well

Since CADET (https://pypi.org/project/CADET/) is currently an alias fo CADET-Python, the release needs to be done there separately with the cadet_pypi_release branch to push the correct README.

Hijacking to remind ourselves that we also need to create a release on conda-forge.

After talking to @lieres, we decided to stop publising code in PyPI/cadet. Instead, we should simply add are README containing: "Wer das installiert ist doof" (or similar) and refer to the proper package. This way, we don't "lose" the name in the package index s.t. we can later still use it for meta packages.

The readme should contain a short explanation (CADET is now used for the organization on GitHub and might be used for a meta package on PyPI) and links to the following pages for further information:
https://github.com/cadet/
https://cadet.github.io/


feat(Subscription): allow subscription.add to accept promise of teardownlogic

Currently, the following code is not allowed:
const observable = new Observable(async subscriber => {
  const value = await getAsyncValue();
  subscriber.next(value);
});

and it will yield the following error:
Argument of type '(this: Observable<{}>, observer: Subscriber<{}>) => Promise<void>' is not assignable to parameter of type '(this: Observable<{}>, subscriber: Subscriber<{}>) => TeardownLogic'. Type 'Promise<void>' is not assignable to type 'TeardownLogic'. Type 'Promise<void>' is not assignable to type 'AnonymousSubscription'. Property 'unsubscribe' is missing in type 'Promise<void>'.

This is because subscriptions don't allow teardownlogic to be provided through a promise.  This PR adds that functionality to subscriptions.

I'm not sure if we want to allow asynchronous teardown logics to be added in subscription. @benlesh thoughts?

I haven't verified so it's just gut feeling but this could possibly bring weird execution order.

Coverage increased (+0.002%) to 97.736% when pulling f6c53b7a1fe3fdd50bf9c3ee4a660ae6058236c1 on knowledge-express:master into 491970f5aa05680d6bfe89084272fcb207d46167 on ReactiveX:master.

Coverage increased (+0.002%) to 97.736% when pulling f6c53b7a1fe3fdd50bf9c3ee4a660ae6058236c1 on knowledge-express:master into 491970f5aa05680d6bfe89084272fcb207d46167 on ReactiveX:master.

I have the same feeling as @kwonoj it seems like this could cause some weird race conditions.  The biggest one would be what happens if you unsubscribe from the observable, while the promise is still in flight?  Since we can't cancel the promise, then we may see any weird number of things popup.
Is there a specific reason that you can't just do something like...
Observable.defer(() => Observable.from(getAsyncValue()));

I'm just trying to find a compelling reason that we must introduce promises into the constructor in this way.

Coverage increased (+0.001%) to 97.735% when pulling b11bd715232521bc855e87095a17a285172e12a3 on knowledge-express:master into 491970f5aa05680d6bfe89084272fcb207d46167 on ReactiveX:master.

Coverage increased (+0.001%) to 97.735% when pulling b11bd715232521bc855e87095a17a285172e12a3 on knowledge-express:master into 491970f5aa05680d6bfe89084272fcb207d46167 on ReactiveX:master.

This is actually interesting, I'd like to read @jhusain's opinion on it.
The major difficulty I see is we'd need to return a Promise<Subscription|Function|void> from that internal function... however, it should be simple enough to wrap that in a Subscription synchronously.
I see this as totally doable, but the real question is whether or not we need to even have this if we make Observable.from() accept async function * (AsyncIterators). That's work that has already been prototyped, and I think I might even have a PR sitting around for it.
Also technically this would work:
const source = new Observable(observer => {
  (async () => {
    const value = await getAsyncValue();
    observer.next(value);
    const value2 = await getAsyncValue();
    observer.next(value2);
    observer.complete();
  }());
});

If you needed some sort of cancellation (which promises don't natively support, you'd have to role your own thing), you could do this:
const source = new Observable(observer => {
  const subscription = new Subscription();
  (async () => {
    const token = new SomeCancelationTokenThing();
    subscription.add(() => token.cancel());
    const value = await getAsyncValue(token);
    observer.next(value);
    const value2 = await getAsyncValue(token);
    observer.next(value2);
    observer.complete();
  }());
  return subscription;
});

Yeah... the more I look at this, I think it's completely doable. It's just a matter of whether or not it's a good idea... We need to explore the corner cases.
Just adding support for Promise<TeardownLogic> should indeed do it, you're right @joostverdoorn

This is currently being discussed over in the TC39 proposal repo: https://github.com/tc39/proposal-observable/issues/163

SInce there hasn't been much traction on this idea, and it's too different from both the WHATWG and TC39 proposal. I'm going to close it for now.

This is something we think we'll need so we can do deep cancellation in one of our libraries that ultimately relies on a fetch polyfill on some platforms. We believe we need this PR and GitHub/fetch#592 merged to get the improved performance we're shooting for.

I've been following several PR's against the fetch polyfill - this one seems most promising - that is driving some of our cancellation work.  In speaking with @jayphelps yesterday, we have a good solution for cancellation if we hand back an abort-able in our subscription.  In reading through this (and the TC39 Observable you referenced above), I'm wondering: was it ever decided that a Subscription must be returned synchronously @benlesh ?
Thanks for the hard work and time, ladies and gentlemen – I'm enjoying digging-in with Rx (and RxJS in particular).


can I resize the image before uploading?

Hi, I would like to know if there is an option or a hack that I can use to resize or compress an image before http uploading. it seems that my server cannot accept file sizes more than 5GB and I don't want to force user to resize the image before it is uploaded.
Thanks.

Hello @xpanta
If you are doing in php, you can use image intervetion to resize your images on server-side.http://image.intervention.io/

Does dropify support canvas?
How to do it?


[v3.1.1 Node] [Messenger] new 500 errors when using 3.1.0, 3.1.1

I had a bot working with v3.0.1, but needed to update to 3.1.x to get a bugfix. Now, on 3.1.x, I'm getting 500 errors like the one below whenever I try to send messages from the bot.
I haven't changed anything about my bot except the version of botbuilder it is running.
Here's an error that it is throwing.
Error: Request to 'https://facebook.botframework.com/v3/conversations/1084613888243541-1063346527086061/activities/mid.1469080260144%3Ab45627fe553f667216' failed: [500] Internal Server Error
    at Request._callback (/Users/DudeOfAwesome/Github/hello-bot/node_modules/botbuilder/lib/bots/ChatConnector.js:356:46)
    at Request.self.callback (/Users/DudeOfAwesome/Github/hello-bot/node_modules/request/request.js:200:22)
    at emitTwo (events.js:106:13)
    at Request.emit (events.js:191:7)
    at Request.<anonymous> (/Users/DudeOfAwesome/Github/hello-bot/node_modules/request/request.js:1067:10)
    at emitOne (events.js:101:20)
    at Request.emit (events.js:188:7)
    at IncomingMessage.<anonymous> (/Users/DudeOfAwesome/Github/hello-bot/node_modules/request/request.js:988:12)
    at emitNone (events.js:91:20)
    at IncomingMessage.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:973:12)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickDomainCallback (internal/process/next_tick.js:122:9)

Are there some breaking changes that I missed reading about?

I'm having this issue too. Any message my bot tries to send via Facebook Messenger results in this error.
Is there any known issue with the service?

Ditto, having this issue here too :(

+1

+1

+1

I just tried it again, and it looks like the 500 error has disappeared when using 3.1.1
Make sure that you're not using 3.0.1 though, because then no messages get through at all, and no errors are displayed either.

Works for me now too. (also found out that node_modules wasn't being ignored for some reason and that was causing problems too I think)

+1
i'm seeing this issue with Sky.
Error: Request to 'https://skype.botframework.com/v3/conversations/29%3A1lm8ymLQhQ5WvPYm55K2BAd5u6klEeaEJuZBvHXgskBI/activities' failed: [500] Internal Server Error
at Request._callback (/Users/lakshman/Documents/StockBot/node_modules/botbuilder/lib/bots/ChatConnector.js:356:46)
at Request.self.callback (/Users/lakshman/Documents/StockBot/node_modules/request/request.js:187:22)
at emitTwo (events.js:100:13)
at Request.emit (events.js:185:7)
at Request. (/Users/lakshman/Documents/StockBot/node_modules/request/request.js:1044:10)
at emitOne (events.js:90:13)
at Request.emit (events.js:182:7)
at IncomingMessage. (/Users/lakshman/Documents/StockBot/node_modules/request/request.js:965:12)
at emitNone (events.js:85:20)
at IncomingMessage.emit (events.js:179:7)

Any comments for this one? Same problem for me

Using 3.2.3, extended error message:
{ errorCode: -1,   message: 'ExceptionContext::MS.Msn.Messenger.ConnectionGateway.WebApi.Models.ResourceMri GetDecryptedIdentity(MS.Msn.Messenger.ConnectionGateway.WebApi.Models.ResourceMri, MS.Msn.Messenger.Runtime.MessengerResourceIdentifier, MS.Msn.Messenger.Runtime.Agents.ApsAgentCache)' }

+1
Finding..

Generally occurs when we try to send receipt/hero/thumbnail card
Once error occurs, that conversation ID has this error... Others conversation work well.
Told don't happen with emulator
As of now error found in skype and Facebook

Any updates on this?

I am also getting the same error in messenger :-(

Hi @APXEOLOG, the MS.Msn.Messenger code is completely foreign to me. Are you using the Bot Builder SDK and the Bot Framework service?

Hi @dandriscoll , yes. This message code i got while debugging the source of the nodejs botbuilder sdk. The interesting thing is that it works with "Web Chat" channel, but doesn't work with Skype

I'm getting the same error on skype as well. Any update?

Closing because of age.  Please open a new issue if you are still seeing the same problem with the latest SDK and service release.


remove settings.gradle in service builder template created in workspace

I think David's pr is better for fix this .


테스트 서버 복구 방법 알려주세요.

글리치에서 db를 잘못 건드려서
app@mire-satin-bass:~ 03:45
$ node server
node-pre-gyp info This Node instance does not support builds for Node-API version 6
node-pre-gyp info This Node instance does not support builds for Node-API version 6
[경고!]: 시스템이 멀티 쓰레딩을 지원하지 않습니다
(node:20672) UnhandledPromiseRejectionWarning: Error: SQLITE_CORRUPT: database disk image is malformed
--> in Database#all('select key, value from config', [], [Function])
at /app/database.js:9:10
at new Promise ()
at Object.execute (/app/database.js:7:10)
at setWikiData (/app/server.js:284:24)
at Object. (/app/server.js:479:3)
at Module._compile (internal/modules/cjs/loader.js:759:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:770:10)
at Module.load (internal/modules/cjs/loader.js:628:32)
at Function.Module._load (internal/modules/cjs/loader.js:555:12)
(node:20672) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:20672) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
이렇게 되었는데 어디를 수정해야 되는지요?

오류가 또 발생해서 새로 열어야겠습니다.


[Meta] Support Inline Completions related features.

Suggestion

🔍 Search Terms
inline, completions

✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
VScode has supported inline completions: https://github.com/microsoft/vscode/blob/main/src/vs/vscode.proposed.d.ts#L2576.
Let's find out what can we do with the new API.

I think we could ping @mjbvz .

I think we should add the support even we do not have some feature yet.
I want to provide some inline completions by my ts plugin. But there's no way to do that without the ts support.

What are inline completions?

There's a proposed VS Code api: https://github.com/microsoft/vscode/issues/124024 and https://github.com/microsoft/vscode/blob/019867139e8818908d65c814816acc3119c5dd1f/src/vs/vscode.proposed.d.ts#L2456
I believe Copilot uses them shows an inline preview of the suggested text while still letting you use normal completions