Attendee flow

This is fully functional and pretty awesome. It could use some UI love – making it more obvious when something can be selected / is selected – which should probably happen as part of this branch.
This will resolve #396 and partially address #403 when it lands. At least that's the idea.

(It also needs some explanatory text, which I would be happy to take a stab at or leave to someone else.)

The ractive shop seems to not be working quite right on this branch. Not sure if it's working on master, but... I'd kinda rather resolve that in a new branch since we're not using it yet anyway? hopeful / sheepish grin?

Yeah, that sounds reasonable. I'll keep reviewing this.

It would be preferable to me if this branch still auto-assigned items when only registering a single attendee. That's the most common case and should be as smooth as possible.

That should be doable. It would also be neat if one could move more than one item at once... Should be doable as long as they're all from the same source

Does the masthead need to be ractive here? We need the countdown timer back on the attendee page.

(Also I don't like making entire pages a single ractive instance, as previously discussed :p)

Clicking the trash cans to delete attendees isn't working.

I can fix the trash cans.
I guess the banner image doesn't have to be ractive, but the stepbar does. It has to react to whether the current page is finished or not.

Hm. I can see that being good, though I don't think it would be a big deal if the stepbar didn't react since it doesn't react on other pages.
In my ideal world, the stepbar would be a completely separate component that would check the attendee component for completion. Especially since it will be reused on multiple pages ultimately. If necessary a parent component could coordinate that communication.

yeah, I think having it as a separate component would be really cool.

This looks pretty good actually. Great work on the overlays. Everything could be spiffed up a bit, but I'm happy to get any of that and the other stuff I complained about after merging this. Feelings on merging as-is @melinath?

Yep, I'm satisfied with the current state for now. :-)

Let me give it one more pass.

Actually, is it possible to bypass the item assignment page altogether if it's a single-attendee situation?

I can take a swing at that.

@harrislapiroff I don't think we should bypass it altogether. It's really easy to accidentally click the "Continue" button from attendee creation instead of "Register another attendee" – and it's not obvious how to go back and add another person if you intended to have more than one.

I think it's very confusing (and a waste of time) to be presented with an interface that you don't have to do anything with and since single-attendee is the most common case, I'd prefer to optimize for that.

Okay.

If we continue to get confusion about registering multiple attendees, I'll reconsider. But right now, my instinct says that we'll get more confusion this way.

@melinath Would you review that last commit and then merge if this is good?

On it @harrislapiroff


Other Then Login Page Toast are Not Working

toast are not working On Rest of pages

can you please elaborate

See the code of blog or any other page there is toast code but it is not working

But it is  not required

@thestarsahil  Like that are toast it like if I created article it's good if I receive notification that article is created


Random seed in LocalOptimization is fixed

In LocalOptimization the random seed is always reset to options.random_seed_. Since this method is called multiple times, this probably not the desired behavior.
https://github.com/tsattler/RansacLib/blob/565718ff44657b3e5782bda0844f863ae8653f62/RansacLib/ransac.h#L353-L357

Resolved in PR #12


Improving the usefulness of one comment

Improving the rpc_address comment.
Source: http://www.datastax.com/documentation/cassandra/2.1/cassandra/configuration/configCassandra_yaml_r.html

:+1:


Include new CaptureFPS property in availability calculation

Starting in ZM 1.32.3 the monitor API also returns a Monitor_Status object per monitor
https://zoneminder.readthedocs.io/en/stable/api.html#return-a-list-of-all-monitors
The ZM front-end uses the CaptureFPS to determine if there is an error so I would like to do the same from HASS:
https://github.com/ZoneMinder/zoneminder/blob/bf3e783c42c6557c44cdb49bff594f1b1e6b5198/web/skins/classic/views/console.php#L245-L246
If the new property doesn't exist, the old calculation is used.

Sorry, I didn't get a chance to review this during the week. I'll review this weekend.

Fixed. Thanks

Released in 0.3.2.


Module not recognizing use_num_suffix

I'm not sure why the module is not appending the instance count to the name. I set the value for
use_num_suffix = true , but the names do not get appended with the number.  After the hosts are built the names do not reflect the count. I would expect the hostnames to be myhosts1 and myhosts2
  source = "terraform-aws-modules/ec2-instance/aws"
  version = "2.13.0"

  # name                   = "${var.service_name}"
  name                   = "myhosts"
  instance_count         = 2
  use_num_suffix        = true
  subnet_id             = tolist(data.aws_subnet_ids.subnet.ids)[0]
  instance_type          = "t3.medium"
  key_name               = "${var.ssh_key_name}"
  iam_instance_profile   = "${var.iam_instance_profile}"
  ami                    = "${data.aws_ami.aws-ami.id}"
  vpc_security_group_ids = tolist(data.aws_security_groups.default.ids)

  root_block_device = [{
    volume_type           = "gp2"
    volume_size           = 50
    delete_on_termination = true
   }]

  # Set tags for the ec2 instance #
  tags = {
    Name                  = "${var.service_name}"
    terraform             = "true

  }
  # Set tags for the data volume #
  volume_tags = {
    Name                  = "${var.service_name}"
    env                   = "${var.environment}"
    terraform             = "true"
  }
}

You are overwriting the num_suffix based tags with your own tag definitions. Remove the "Name" tags from your tags and volume_tags blocks and you should see what you are looking for.

@jeremyciak That was it. Thank you.


Added New Swag Metafy

Re-styling is needed.

I am trying but it is not working @thefool76

Applying: Restyled by prettier-json
error: patch failed: src/list.json:5
error: src/list.json: patch does not apply
Patch failed at 0002 Restyled by prettier-json
hint: Use 'git am --show-current-patch=diff' to see the failed patch


Clang-7 Explicit Toolchain

Couple of things need review:

Naming convention: Switches to libc++ but name doesn't indicate that
Path to header is specific to where I've got those headers, I'm not sure how to more elegantly find them

Thanks to your help and some symlinks I don't think this toolchain makes sense anymore - closing :)


Add Tip About Pop-up Windows

Fixes #129

Hey there! Anything needed to merge this?

Good morning! Does this look good to merge?

@loganfranken I'll merge once the conflict is resolved.

Fixed! Thanks @garster!

@loganfranken more conflicts, from merging in the other PR

Thanks @garster!


Node 18 or 20 break ffmpeg in google cloud function

Version information

fluent-ffmpeg version: ^2.1.2
ffmpeg version: (The one installed in Google Cloud node js 18/20)
OS: Linux-64 (Google cloud function)

Code to reproduce

const ffmpeg = require("fluent-ffmpeg");

// Following is inside a .https.onRequest Google Cloud function with enough memory

try {
  const duration = new Promise((resolve, reject) => {
  ffmpeg.ffprobe(videoUrl, async (err, metadata) => {
    if (err) {
      if (res.headersSent) {
        console.error("Response already sent");
        return;
      } else {
        console.log("Metadata:", metadata);
        console.log("err: " + err);
        res.status(400).send("Error getting video metadata");
        return;
      }
    }
  const duration = metadata.format.duration;
  console.log("video duration in second: " + duration);
  resolve(duration);
  });
});
  let videoDuration = await duration;
} catch (err) {
  console.log(err);
  throw err;
}

Expected results
The above code is working on node js 16 in Google Cloud functions. It provides the duration of the video file from the video URL.
Observed results
The error "cannot find ffprobe" appears when upgrading to node 18 or 20 (No other change than upgrading node).
Setting the path manually using ffmpeg.setFfprobePath(ffprobePath);
Trigger the error:
-> Error: ffprobe was killed with signal SIGSEGV
err: Error: ffprobe was killed with signal SIGSEGV
ffprobe version 4.4.1-static https://johnvansickle.com/ffmpeg/  Copyright (c) 2007-2021 the FFmpeg developers
built with gcc 8 (Debian 8.3.0-6)
configuration: --enable-gpl --enable-version3 --enable-static --disable-debug --disable-ffplay --disable-indev=sndio --disable-outdev=sndio --cc=gcc --enable-fontconfig --enable-frei0r --enable-gnutls --enable-gmp --enable-libgme --enable-gray --enable-libaom --enable-libfribidi --enable-libass --enable-libvmaf --enable-libfreetype --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenjpeg --enable-librubberband --enable-libsoxr --enable-libspeex --enable-libsrt --enable-libvorbis --enable-libopus --enable-libtheora --enable-libvidstab --enable-libvo-amrwbenc --enable-libvpx --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxml2 --enable-libdav1d --enable-libxvid --enable-libzvbi --enable-libzimg
libavutil      56. 70.100 / 56. 70.100
libavcodec     58.134.100 / 58.134.100
libavformat    58. 76.100 / 58. 76.100
libavdevice    58. 13.100 / 58. 13.100
libavfilter     7.110.100 /  7.110.100
libswscale      5.  9.100 /  5.  9.100
libswresample   3.  9.100 /  3.  9.100
libpostproc    55.  9.100 / 55.  9.100

I also opened a stackoverflow question: https://stackoverflow.com/questions/77516185/node-18-or-node-20-break-ffmpeg-in-google-cloud-functions-ffprobe-was-killed
As it may be related to the google cloud ffmpeg version.
Thank you for the help

GCP Functions NodeJS 16 runtime uses Ubuntu 18.04 with FFMpeg installed.
NodeJS 18/20 use Ubuntu 22.04 and Google in all their wisdom decided not to include FFMpeg -_-.
https://cloud.google.com/functions/docs/runtime-support#node.js
https://cloud.google.com/functions/docs/reference/system-packages

That's unfortunate, to say the least...
What's the solution here then? No way to find an easy workaround without having to deploy a custom docker into Google Cloud?

I'm in the same position right now, I don't want to deploy a container just to have FFMpeg.
1 approach would be these libraries that install FFMpeg as an NPM dependency:
https://github.com/eugeneware/ffmpeg-static
https://github.com/kribblo/node-ffmpeg-installer
I haven't gotten this approach working in GCP Functions yet, so next I am going to try putting an FFMpeg tarball in a GCS bucket and unpacking it to the local filesystem during function initialization.
I think excluding FFMpeg was done intentionally to push users towards GCP Transcoder service, but that service is designed specifically for VOD content preparation, so the full range of FFMpeg capabilities is not available there.

Update here:
After discussing with Google support, they finally decided


fix broken delete function

This PR is to fix the delete function which generates a wrong url. Currently trying to use graph_session.delete() will fail.

additional commit fixes pyproject.toml so the library may be installed via
pip install git+https://github.com/microsoftgraph/msgraph-sdk-python-core.git@dev


adds the ability to "mix" solutions (reactions caused by using an item on a solution holder)

adds a component for mixing, that can take a list of strings that are essentially mixing 'categories'
solutions have a canMix variable, and there's a new method for getting a mixable solution from an entity
mixing system attempts to update chemicals for entities hit by an entity that has the mixing component
reactions can have a list of strings that are the required mixing categories for the component to have
i.e. if a bible has Holy, and the blood to wine reaction has Holy, then hitting a beaker of blood with a bible will create wine (this is also a reaction added as an example!)
solutions default to not allowing mixing by default, and then i set beakers cups and bottles to allow mixing, because i feel like it's easier and more maintainable to say what does allow mixing compared to what does not
personally i think it has the best use for cooking/bartending because you could actually mix a drink using a spoon, for example, or have a shaker that when used on itself (this would probably need a second event adding to the mixer system but is a very minor change!) mixes reactions inside it
made in response to suggestion #11778
tested locally to make sure it works as intended (both using the recipe correctly, and trying to mix it with something that has the wrong mixing category in the component such that it doesn't mix, and trying to mix things that don't allow mixing)
this is my first PR for ss14 so any feedback on alternative approaches, code quality, etc would be greatly appreciated

[ ] I have added screenshots/videos to this PR showcasing its changes ingame
[X] This PR does not require an ingame showcase

:cl:

add: ability to mix reactions with certain entities, included example being blood can be converted into wine using a bible at a ratio of 1:1

thanks for the feedback, i'll work on addressing those points now!


Selected item shifts to previous item in visual studio code debugger

When I press ctrl + shift + d to open the debugger and in the selection drop down list select a particular item, post that pressing left arrow key to go to run button shifts the selected item to previous item in the list.

VS Code Version: 1.86.2
OS Version: Enterprise Version 22H2 (OS Build 22621.3155)
JAWS version : 2024.2312.53.400

Steps to Reproduce:

Press ctrl+shift+d to open debugger window
Press right arrow key to go to selection drop down
Select an item in the list
Press left arrow key to go back to run button

This issue becomes more frustrating with screen readers because user is not aware that selection has changed. Please @isidorn request to get the issue resolved.

Thanks for the issue. The selection does not change for me when I follow your steps. Pls lmk if I'm missing something else.

I am curious if this issue reproduces when using NVDA.

@meganrogge  Yes for me both  on NVDA and JAWS it happens.

Could you pls enable screen cast mode by running the command Developer: Toggle Screencast Mode and record a gif and share it?


fixes cisco for username and password

What does this PR do?
The Cisco ACI Integration had a regression in username and password when we added certificates
Motivation
issue #2237 from @jgcasd
Review checklist

[ ] PR has a meaningful title or PR has the no-changelog label attached
[ ] Feature or bugfix has tests
[ ] Git history is clean
[ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes
Anything else we should know when reviewing?

Codecov Report

Merging #2267 into master will increase coverage by 15.32%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #2267       +/-   ##
==========================================
+ Coverage   79.77%   95.1%   +15.32%
==========================================
  Files         170      17      -153
  Lines        7838    5168     -2670
  Branches     1159     195      -964
==========================================
- Hits         6253    4915     -1338
+ Misses       1275     182     -1093
+ Partials      310      71      -239


Task and domain knowledge

Although the datasets have a unified appearance, the domains and tasks are different for each dataset.
This information should be one of the inputs to the table2text generation system.
The system needs to know if the task is to describe overall appearance of the data, trends, summaries, commentary, etc.
The goal is to find a principled way to represent this information and present it to the system.

It seems that he knowledge and the task description can be just described in plain words – all you need is ChatGPT.


Add doc hint on using Sprite mask on canvas

For the moment, PIXI.CanvasRenderer doesn't support PIXI.Sprite as mask. #2279

mistake


Free Travis CI is going away

Copying this issue from the PINT page (https://github.com/nanograv/PINT/issues/817), reposted here:
There is a nice discussion of this on the astropy-dev list: https://groups.google.com/g/astropy-dev/c/45frnTEAX-U
Astropy switched from Travis CI to github's "Actions" for CI.
https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing

Here is a decent tutorial.

Awesome! Sorry I have not had time to do this yet. It is on my to-do list still though.

It doesn't look like the Pint folks have successfully figured this out yet either. But there are some nice resources in their conversation.

This was merged into the joss-reveiw branch in PR #182 and has been confirmed to run successfully in PRs #183, #180 , and #184 . This still needs to be merged with the main branch but for all intents and purposes this has been completed.


Possible Ιmprovement...

Hi,
Your tool is Fantastic.
I propose a possible Ιmprovement.... Can we have in scrollable line chart two lines for two values for Y per X
If we can have something like that it will be very nice!
Any way, I want to thank you in advance...
George Gerardis

@geogerar Thank you for your suggestion, i will give it some serious consideration , and if possible , improve it in the next version. If you have any other suggestions , i will be glad to see them.

Hi,
I got email from you closing the proposed <Possible Ιmprovement>
about having two lines in scrolling line chart for your "WYChart" tool.....
I check the new version in github but I didn't see something.
Did you make the proposed improvement or you have not implement it yet?
I would like to know because I want to add your tool in an app that I am
developing.
Thank you in advance
George Gerardis
On Wed, Oct 19, 2016 at 4:49 AM, 王颖<EMAIL_ADDRESS>wrote:

Closed #1 https://github.com/GeorgeWang03/WYChart/issues/1.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GeorgeWang03/WYChart/issues/1#event-828402571, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC7aPdQPRfh5vh1oQNdppSiNz3womX5_ks5q1Xc1gaJpZM4KF6FI
.

--
Γιώργος Ν. Γεράρδης

@geogerar im sorry about that the new version about having two lines in scrolling line chart for  "WYChart" tool has not yet released, i will try my best to develop it, once the new version is ready, i will notice you, im glad to see you adding it into your app and thank you for your suggestions.

@geogerar soory to keep you waiting, WYChart v0.2.0 now avaliable in github and cocoapods, it support multiple lines.


25/75 module requiring headers

25/75 organism is now requiring a group header when that should be optional. @kurtw @kave

That should be in a PR right now but I'm not near my laptop to check
easily.
On Mon, Dec 21, 2015, 11:06 AM tnferrell<EMAIL_ADDRESS>wrote:

25/75 organism is now requiring a group header when that should be
optional. @kurtw https://github.com/kurtw @kave
https://github.com/kave
—
Reply to this email directly or view it on GitHub
https://github.com/cfpb/cfgov-refresh/issues/1252.

@kurtw yup its been updated and merged into flapjack. waiting on the push to Refresh
https://github.com/cfpb/cfgov-refresh/pull/1250

@tnferrell could you close this if its no longer an issue


test: add e2e test cases for cors plugin

Please answer these questions before submitting a pull request

Why submit this pull request?

[ ] Bugfix

[ ] New feature provided

[ ] Improve performance

[ ] Backport patches

Related issues

Bugfix

Description

How to fix?

New feature or improvement

Describe the details and related test reports.

Backport patches

Why need to backport?

Source branch

Related commits and pull requests

Target branch

Codecov Report

Merging #334 (90fb180) into master (8006297) will decrease coverage by 0.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
- Coverage   43.72%   43.24%   -0.49%
==========================================
  Files          40       39       -1
  Lines        3428     3427       -1
==========================================
- Hits         1499     1482      -17
- Misses       1761     1775      +14
- Partials      168      170       +2

Impacted Files
Coverage Δ

pkg/apisix/cluster.go
28.44% <0.00%> (-5.97%)
:arrow_down:

pkg/apisix/route.go
42.03% <0.00%> (-1.92%)
:arrow_down:

test/e2e/e2e.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8006297...90fb180. Read the comment docs.


Add a License file

Could you please add a license file to the repository?

I'm rather ignorant about OS licensing, but I suppose I can just copy the one from turtlebot: https://github.com/turtlebot/turtlebot/blob/melodic/LICENSE
@mikeferguson , @mmwise , @stonier is this right?

I think you could basically adapt the headers from https://github.com/turtlebot/turtlebot_arm/blob/melodic-devel/turtlebot_arm_kinect_calibration/src/detect_calibration_pattern.cpp (or any of the other early files in the repo)

Aye, approximately what @mikeferguson said. Ground truth of these things is always at opensource.org, e.g. BSD-3.

Bundle a LICENSE file at the root (easy to discover)
Copy it into each header file (opinions vary on if this is necessary, but it seems prudent to have some hint for people in the publicly distributed files)
Make sure you set your copyright fields appropriately

done


Want to contribute to this project

I want to work on this project as part of gssoc2021

I want to contribute to this project as a GSSOC '21 project but where are the issues mentioned can you tell me?


Documentation on Encoding/Decoding of data formats

A common question on discord is something like:
"I have data in format X but I want it in format Y, how can this be done?"
Where X and Y may be;
Address 58 byte public key <=> 32 byte public key
Signed Transaction blob <=> SignedTransaction object
Transaction on front end <=> Transaction on a server
Describe the solution you'd like
Build a page with common encodings and how to convert them to other formats with code examples

addressing in #656


Discord version 0.0.309

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

Microsoft Reviewers: Open in CodeFlow

cc @KevinLaMS Installation is working fine here:


FocalsConv3d usage

Hello, it is amazing that your Focals Conv backbone is as the point cloud feature extraction! But I found that the backbone occupies too much GPU memory while I training on RTX 3090 and also slows down the training.
I am very glad to find that you implement FocalsConv with CUDA; I also follow your instruction to see examples in file focal_sparse_conv_cuda.py, but I found no use of FocalsConv3d. So I find the source code of FocalsConv3d in spconv package. But I wonder how I use it correctly in file spconv_backbone_focal.py. I follow the usage of spconv.SubMConv3d in VoxelBackBone8xFocal class to replace the  special_spconv_fn which is for FocalSparseConv with FocalsConv3d block. But I found that its forward function has parameter ori_feat_num which I confuse about it, could you help me what the param stand for?
the source code is as follows:
class FocalsConv3d(SparseConvolution):
    def __init__(self,
                 in_channels,
                 out_channels,
                 kernel_size,
                 stride=1,
                 padding=0,
                 dilation=1,
                 groups=1,
                 bias=True,
                 indice_key=None,
                 algo: Optional[ConvAlgo] = None,
                 fp32_accum: Optional[bool] = None,
                 name=None):
        super(FocalsConv3d, self).__init__(3,
                                         in_channels,
                                         out_channels,
                                         kernel_size,
                                         stride,
                                         padding,
                                         dilation,
                                         groups,
                                         bias,
                                         subm=False,
                                         focal=True,
                                         indice_key=indice_key,
                                         algo=algo,
                                         fp32_accum=fp32_accum,
                                         name=name)

forward function in SparseConvolution:
def forward(self, input: SparseConvTensor, mask=None, ori_feat_num=-1, group_map=None):
if FocalsConv3d is called, ori_feat_num should > 0. In KITTI dataset, the param should be 1 or 3? it means orientation feature num?

Another question is that is it right to replace special_spconv_fn with spconv.FocalsConv3d without any other parameters changed except kernel_size, in/out_channels, stride?
I would appreciate for your reply. Thank you again.

Hi Deze,
Thanks for your interest in our work. I uploaded the new examples just now. You can find the example from the following codes.
https://github.com/dvlab-research/FocalsConv/blob/master/OpenPCDet/pcdet/models/backbones_3d/spconv_backbone_focal_cuda.py
https://github.com/dvlab-research/FocalsConv/blob/master/OpenPCDet/pcdet/models/backbones_3d/focal_sparse_conv/focal_sparse_conv_cuda.py
Regards,
Yukang Chen

ori_feat_num means the number of sparse features in the original input sparse features.

Wow! I am truly grateful for your help.


SUBTASK: Alternative form method

User Need
As a Developer
I want To trial an alternative form method of data collection for DNS requests
so that I can choose the most effective method
Acceptance Criteria:

Create a form POC for collection of DNS request data using a method such as Slack Forms or Microsoft forms

Parent: https://github.com/orgs/ministryofjustice/projects/52/views/4?pane=issue&itemId=62738021

Slack forms is paid subscription model

MS Forms form - https://forms.office.com/e/UDEuitaBFz

Output is xlsx file in cloud - how to extract this data e.g for integration with IaC?

How to remove DNS requests when complete, so they don't keep getting picked up?


Brackets editor questions

I'm using latest version of Brackets on Windows 10, 64-bit. Can you please answer my questions about Brackets usage?

How can I set the default file type to text file (.txt), so that when I save a file Brackets automatically saves it as a .txt file?
On the same note, how can I tell Bracket to create a .txt file when I click File>New?
I have a file open in a tab and when I single click another file in sidebar then Brackets opens this new file in the active tab. How can I prevent this from happening i.e., when I single click a file in sidebar then it should be opened in a new tab just like when I double click a file in sidebar.
How can I auto hide the sidebar by default so that it is shown only when I move my mouse cursor to the left side of the editor?

Thanks!

This is counter-intuitive. This should not be so since the editor should leave it to the user to explicitly specify the extension of the file to be saved. You can simply specify the extension of the file when saving by selecting Text Files under the Save as type: field.
Just do the same as number 1.
The sidebar acts as the only tab for opened files. There's no need for a collection of active files in the top tab; it should actually be removed since we can already see the active file in the sidebar.
There's no auto-hiding it since it serves as the only indicator of open files. You can, however, hide the sidebar by going to View->Hide Sidebar, or pressing the key combination Ctrl Alt H.

Thanks for your replies. One more question.
Is there a portable version of Brackets? In other words, can I use brackets without using the installer and just extract a zip file and use it that way.

I don't think there is a portable installer. There are a lot of features that are dependent on having the IDE installed, so as to fetch crucial system information upon installation.

Thanks. It would be nice to have a portable version.
Going back to my question #3. let's say I have a file already open in the editor. When I single click another file in sidebar then the contents of already opened file in the editor on the right side is replaced with the contents of the new file I clicked. I would have expected this to happen only on double click. I guess what I'm asking is, I only want a file to be opened when I double click a file in the sidebar, single clicking on a file should not open file. How can I make this happen where essentially the sidebar should not open file on single mouse click. Thanks.


add build.bat and add notice on meta servers

Coverage increased (+0.01%) to 50.181% when pulling 6a90ad05a7e97b979005e7c3e9eab531e2d79bfb on nobodyiam:build-scripts into f6d4da92ab11a2d8ba01b2cbf1f1649166d71b86 on ctripcorp:master.

Codecov Report

Merging #691 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #691      +/-   ##
============================================
+ Coverage      46.7%   46.73%   +0.02%
- Complexity     1481     1482       +1
============================================
  Files           341      341
  Lines          9392     9392
  Branches        928      928
============================================
+ Hits           4387     4389       +2
+ Misses         4680     4679       -1
+ Partials        325      324       -1

Impacted Files
Coverage Δ
Complexity Δ

...ervice/service/ReleaseMessageServiceWithCache.java
86.9% <0%> (+2.38%)
25% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6d4da9...6a90ad0. Read the comment docs.


Batch import data

I have an existing data table, which may be an XLS or CSV file
I tried to copy the entire column of data, but after pasting it became the content of a cell.
Either paste or import method is OK. The plug-in automatically creates a file name and expands it to the corresponding number of lines

I think this issue is duplicated
https://github.com/RafaelGB/obsidian-db-folder/issues/129


Update module github.com/stackitcloud/stackit-sdk-go to v0.5.0

This PR contains the following updates:

Package
Update
Change

github.com/stackitcloud/stackit-sdk-go
minor
v0.4.0 -> v0.5.0

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Updating to v0.6.0 directly in #43


Double-check @types dependencies, some of then might not be used

Like "@types/mkdirp"

Fixed at 364d2029acfb2e9caf79e50d3b5ea97792dd5b3b


Create a mirror field

U can created a mirror link that change a time i selected before? for example if i select in format MM/DD/YYYY the mirror link capture this value and change to DD/MM/YY, and the time too if i select un 24h in this mirror change in to 12h. This is becouse for the user enter the value in any way he want, but the mirror flied has the format i need to send via SQL

Just use the date function to get the date from the picker and call format("DD/MM/YY") or whatever format you need it in.
All date's in the picker are Moment objects and you can format it as you need it.


Adding docs for chromatic

What
Docs for chromatic.
Removing manual trigger since chromatic actions doesn't support it
Why

How Tested

Process & policy checklist

[ ] I have updated the project documentation to reflect my changes if necessary.
[ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

Can you add a section here also in the readme under infra: https://github.com/Azure/communication-ui-library/tree/main/docs


Filtering out a popular hashtag makes the boost carousel go weird

I filtered my feed to not show the #monsterdon hashtag and got the attached.

@timbray 🤔 hmm what's your expectation for this case?

Collapse them somehow.  “38 posts and boosts concerning #x”. Similar to the nice way you summarize likes and boosts in notifications?


feat: Add Zspan.fundamentalDomain_ae_parallelepiped

Prove that the fundamental domain of a ℤ-lattice is almost equal to the corresponding parallelepiped. This is useful because many results in measure theory use the parallelepiped associated to a basis.

bors r+

Error: ./././Mathlib/MeasureTheory/Measure/Haar/OfBasis.lean:62:4: error: unknown identifier 'SMulHomClass.map_smul' was presumably from here. Please fix and re-submit

bors r+


Remove Cancel button from menu

According to @celinehuang from the CRM team 😡 it's not necessary
Quick fix to feel productive

hehe

Closed by #147


Implement help command

Is your feature request related to a problem? Please describe.
Given how pipenv uses a verb command interface, it feels wrong that to get a help/command summary you need to invoke it with --help instead of pipenv help.
Describe the solution you'd like
Enable pipenv help to work. Can be shared with the --help output. This maps better in terms of usability.
If okay, I can put a PR together for this.

I don’t really follow your reasoning on why --help is wrong, to be honest. --help feels as correct as help to me.

Thanks for the feedback and for explaining the reasoning with it, that definitely helps us understand where you're coming from -- overall I'd say I see an argument for why it could behave this way, but at the same time I don't think we are getting a lot of feedback for this right now.  That's not to say it shouldn't happen, but I don't think now is the time for these kinds of API changes.  Right now we are aiming for stability and correcting some functionality and performance issues.
I'm going to close this for now, but we may revisit it in the future.  Thanks again for your input

@techalchemy Thanks for the feedback. It was something I raised based on internal feedback from users at the company I work for.


Membership overview graphs

This PR adds a view at /members/graphs/ that show multiple variations of membership graphs over the dates that the bookstore was open.  For now, these are meant to be exported as SVG and embedded; in future perhaps they can be embedded directly.

solr indexing on year+month that members were active, in order to get efficient totals for the graph (requires reindex)
a new view and template to get the totals and render the graphs
added Gissoo's d3.js code and refactored into a typescript file that finds the appropriate divs and displays the data based on a data-series attribute.

Not sure what tests are needed for the typescript code. Been a while since I did the first section, may need tests for the view logic also.

Forgot to say: thanks @thatbudakguy for the directions & example for how to write the typescript code and access the data.

Codecov Report

Merging #433 into develop will decrease coverage by 0.09%.
The diff coverage is 90.42%.

@@            Coverage Diff             @@
##           develop     #433     +/-   ##
==========================================
- Coverage    98.48%   98.39%   -0.1%
==========================================
  Files          175      175
  Lines         8337     8407     +70
  Branches        26       26
==========================================
+ Hits          8211     8272     +61
- Misses         126      135      +9


Is easychart still being developed?

Hi,
Is easychart still being developed, or is it better to use Highcharts editor as it is built and maintaned by the creators of the Highcharts library?

Since the release of Highcharts editor we've stopped the development of Easychart so it's better to us Highcharts editor.
All the best,
Thomas


cleanup: use backoff v4

Signed-off-by: Kuat Yessenov<EMAIL_ADDRESS>[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@bianpengyuan  Need P&T approval.

@douglas-reid can I get your approval for this cleanup?

@kyessenov: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
885e90cf8041bd6d010b9b4e6d2c9629b67e8ab2
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
885e90cf8041bd6d010b9b4e6d2c9629b67e8ab2
link
/test integ-pilot-k8s-tests_istio

integ-security-multicluster-tests_istio
885e90cf8041bd6d010b9b4e6d2c9629b67e8ab2
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@kyessenov: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
885e90cf8041bd6d010b9b4e6d2c9629b67e8ab2
link
/test integ-security-multicluster-tests_istio

integ-pilot-k8s-tests_istio
885e90cf8041bd6d010b9b4e6d2c9629b67e8ab2
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
885e90cf8041bd6d010b9b4e6d2c9629b67e8ab2
link
/test integ-pilot-k8s-tests_istio

integ-security-multicluster-tests_istio
885e90cf8041bd6d010b9b4e6d2c9629b67e8ab2
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@kyessenov: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyessenov: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-cni-k8s-tests_istio
885e90cf8041bd6d010b9b4e6d2c9629b67e8ab2
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


DioError [DioErrorType.RESPONSE]: Http status error [429]

hi.
why this error give me
Is there a solution?
`  try {

  for (var i = 0; i <= 603; i++) {

    sleep(const Duration(seconds: 1));

    response = await dio.download(
        "http://api.alquran.cloud/v1/page/${i + 1}/tr.bulac",
        "${dir.path}/page${i + 1}.json",
        options: Options(
      //connectTimeout: 10000,
      receiveTimeout: 10000,
    ),
        onReceiveProgress: (rec, total) {
      print("Rec: $rec , Total: $total");
      setState(() {
        indirilen = i + 1;
        progressString = (rec / total * 100).toStringAsFixed(0) + "%";
      });
    });
  }

} catch (e) {
  print(e);
}

`

This is a question better suited for StackOverflow, since there doesn’t seem to be anything wrong with Flutter itself. Closing, as this is not an issue report. See https://flutter.dev/community for support options.


Details of plugin import failures are masked - Fix this

We recently discovered a change in the python glance client that prevented the plugin from being imported.  The precise error is not reported in Factory debug output.  Instead, a generic "unable to import" error gets thrown.  We had to manually attempt a plugin import from an interactive shell to determine actual fatal error message.
We should log full details of any exception that occurs when attempting plugin imports.

As of this commit, unless we get a well known exception type or exception text, we log the full details:
https://github.com/redhat-imaging/imagefactory/commit/bdf81a0de4422b5e395335fe0d0d1c81d375dea8


Update 3_1_1_Roles_in_the_IDS.md

Hello, I guess it is a small typo.
This constellation my occur
should be:
This constellation may occur

Hello @ssteinbuss @mokamhuber ,
The merge seems to be blocked, could you please have a look
Thanks
XD


Type AvatarExportedEventPayload hasn't covered the expected parameters

According to the documentation event v1.avatar.exported has three parameters:
{
  data: {
    avatarId,
    url,
    userId
  },
  eventName: 'v1.avatar.exported',
  source: 'readyplayerme',
}

Execution confirms this statement, however, type AvatarExportedEventPayload has only the url key:
export type AvatarExportedEventPayload = {
  url: string;
};

Could you please verify this behavior?

Hey, this package was not updated. This is now done in the package as well. Thanks for noticing it.


Should vectorizer be limited to returning 1-D arrays only?

This is to document some thoughts on

whether to allow vectorizers to output 2-D arrays, or even n-D arrays

which currently these classes/methods make use of:

hover.core.dataset.SupervisableDataset.compute_2d_embedding()
hover.core.neural.VectorNet
hover.core.neural.MultiVectorNet

Arguments for n-D array support

for image / audio processing, 2-D arrays are closer to the original input.
for sequence models in NLP, a doc with token-level embeddings is a 2-D array. Aggregating into 1-D can lose information.

Arguments against n-D array support

hover.core.dataset.SupervisableDataset.compute_2d_embedding() it is unclear to the dimensionality reducers how to take advantage of 2-D localities.

Of course, if there is no locality, one can simply flatten 2-D into 1-D.
Could consider using a if-not-1D preprocessing function, which defaults to something like array.flatten().

It will always be the user who supplies the transform from 2D/N-D array to 1D vector, since hover makes no use of higher dimensionality. Therefore we should stick to asking for 1D input.


[ENH] basic "test all estimators" suite

Incomplete migration of TestAllEstimators - this requires scenarios, but these are not yet implemented.

Codecov Report
Attention: 145 lines in your changes are missing coverage. Please review.

Comparison is base (4d05959) 71.67% compared to head (0e10d48) 68.12%.
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   71.67%   68.12%   -3.56%
==========================================
  Files          93       97       +4
  Lines        4950     5157     +207
  Branches      900      952      +52
==========================================
- Hits         3548     3513      -35
- Misses       1173     1419     +246
+ Partials      229      225       -4

Files
Coverage Δ

skpro/utils/random_state.py
30.00% <30.00%> (ø)

skpro/tests/scenarios/scenarios_regressor_proba.py
64.10% <64.10%> (ø)

skpro/tests/scenarios/scenarios_getter.py
21.05% <21.05%> (ø)

skpro/tests/test_all_estimators.py
60.83% <33.33%> (-23.23%)
:arrow_down:

skpro/tests/scenarios/scenarios.py
15.94% <15.94%> (ø)

... and 4 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Peek not opening pdf inside a ZIP compressed folder (Peek + ZIP folder)

Microsoft PowerToys version
0.74.1
Installation method
PowerToys auto-update
Running as admin
No
Area(s) with issue?
Peek
Steps to reproduce

Open a ZIP file in Windows 10 File Explorer.
Select a PDF from the compressed zip folder
Call Peek with keyboard shortcut over that file

✔ Expected Behavior

Peek is running
I am able to have a "peek" at that pdf file inside the compressed zip folder

❌ Actual Behavior

Peek is running
Error message "An error occurred while previewing that file"

Other Software
none

/dup #26146


moderation: fix clean only deleting N-1 messages

When slash commands were implemented, dcmd.TriggerSourceDM changed from 0 -> 1 (https://github.com/jonas747/dcmd/blame/74c1a523b779e35bf365ae9537ba96120a57bbb3/data.go#L185), causing the number of messages to delete to no longer be incremented by one when the command was used. The effect of this was that -cl 5 only deleted 4 messages from the perspective of the user (4 + the trigger) instead of 5. This very short PR fixes that regression.

Addressed in https://github.com/jonas747/yagpdb/pull/922/commits/a4b3e4dad6562fb4b604e3fb90b8bb46b456a494, trigger is now not included in the final count.
Also looked like this actually still deletes even if triggered by exec/execAdmin so I went ahead and added a check for the ExecutedByCC context key.

What i meant was take in a "authorID" param for the delete function, and just silently include that
Increasing the count by 1 is kind of a hack and could potentially include a extra message if the message was deleted before the command was handled

Ah OK. Just to clarify, would you like this to manually delete the trigger message in AdvancedDeleteMessages instead of including it in the bulk delete, or only include it in the bulk delete if the message ID is present in the slice of fetched messages?


fixes #1145 - Scale app after killing tasks without scaling

Can you put some explanation why we need this force attribute into the commit msg? Without it's hard to follow.

Good idea, thanks.

Now I understand :-)


python_plugin_test not yet running on Travis

I'm trying to get #864 up to test Python on Travis, but tests seem to be failing (see: https://travis-ci.org/grpc/grpc/builds/52375291).... hoping someone with some Python-Fu can pick this up.

@soltanmm, this appears to be coming from the python_plugin_test and having something to do with the path at which the python used in the test expects to find gRPC.

My progress so far:

I've commented out the python_plugin_test and it's failing anyway, so the problem is more substantial (locally, things work) - let's get the rest working and get back to python_plugin_test
I've added apt-get install pip dependency
build_python.sh fails after that (I suspect it wasn't really working before)

https://travis-ci.org/grpc/grpc/builds/52457683

(Retitled to reflect the narrowed scope of outstanding work.)
@soltanmm, please sync with @murgatroid99 about proto-in-the-travis-test-environment. This issue may not be immediately actionable; it may be that we have to wait for configuration changes before we get to run python_plugin_test on travis.

I believe this has been addressed.

Yep, I agree that this was addressed by #965.


Fix elixir 1 8 warnings (and require Elixir 1.5)

Here is a list of the deprecations (from
https://hexdocs.pm/elixir/compatibility-and-deprecations.html):
String.strip/1 deprecated in 1.5 replaced with String.trim/1 (available in 1.3)
String.rstrip/1 deprecated in 1.5 replaced with Strim.trim_trailing/1 (available from 1.3)
String.lstrip/1 deprecated in 1.5 replaced with Strim.trim_leading/1 (available from 1.3)
Kernel.to_char_list/1 deprecated in v1.5 replaced with Kernel.to_charlist (available in 1.3)
Enum.partion/2 deprecated in v1.6 replaced with Enum.split_with/2 (available in 1.4)
Stream.chunk/2 deprecated in v1.7 replaced with Stream.chunk_every/2 (available in 1.5)
If we want to maintain support for a lower version of Elixir then we can remove the Stream.chunk/2 fix to support 1.4 (or likewise Enum.partition/2 to support v1.3). But in my opinion, 1.5 (released Jul 24, 2017) should be good.

@bkirz is there anything I can do to facilitate getting this in?

Just a friendly ping :)


Attributes "Abstract" and "Final" not saved

When editing a type and changing the inheritance attributes "Abstract" and/or "Final"  to "yes", this change is not saved, even though a pop-up confirming the change appears. We have observed this issue when creating a node type.

After using the latest version of the tool, this seems to be fixed.


getting RawData missing Error

mylist= os.listdir('RawData/')
getting the error as FileNotFoundError.
please let me know if anyone know how to solve this error and also guide me if where i need to place the dataset

It's a duplicate of #45

I'm getting the same error

sorry i have same question  can't find RawData this file...

Did anyone figure it out?

Is this issue solved yet? any solution?

@eknoor137 Off the top of my head, I believe I just ended up using my own wav file, disregarding the output10.wav, or there is another example wav file not named output10.wav but it's provided in the project

@all Sorry, I have been busy lately. This error relates to audio file location.
This repository doesn't include the audio files used for training purpose. The links to download them has been provided in the readme file. Just create a new folder (any name). In this case I had created 'RawData' and dumped all the audio files into this folder.
'output10.wav' was a sample audio I used to test my trained model and check it's prediction.


Unable to install @bonfida/ui

How do you install @bonfida/ui? It seems that Bonfida/bonfida-ui.git is either private or doesn't exist at all. @dr497

This should fix it https://github.com/Bonfida/swap-ui/commit/62de75fa474b69992cb63ce8596fb3238cf04e6e


Contribute to django-helpdesk 0.3x

Discussion to help work the 0.3x release and progress this project towards compatibility with the current Django version.
There are tasks to complete the 0.3x release, the purpose of this ticket is to have a place to discuss current goals and help newcomers know where they can put effort and pull requests to move support the next version release.
Would one of the main contributors please post some primary items that need attention that I might be able to work on?
Thanks.

Thank you very much @alligatorbait ! I haven't had the time to work on this like I had hoped.
The master branch is the 0.3.x work. As far as I know it mostly needs to be updated for Django 3.x. There's some kind of bug in it that I possibly introduced when merging a bugfix from 0.2.x, but I haven't gone through to figure out where the error is.
You can also check the tickets under the 0.3.0 milestone. It's possible some of them should be deferred to 0.4.x, we need someone to check them and triage them and figure out only the minimum needed to get the 0.3.x release out.
Thanks!

I didn't look too deeply, but it looks like many of the "bug" tickets on the 0.3.x milestone are related to Django 3.x support so I think that would be the top priority for the next release. Thanks again for your help!

Hi all !
I believe the first bug to fix is the import of an old function which doesn't exist anymore in master : apply_query (in staff.py line 30). Each time I run on master, I'm having trouble with that error. I can try to understand the new __Query__ class and fix it in a PR.
At the same time, I will take a look into the things that are missing in order to make django-helpdesk running with the third version of Django. But as I'm not using it my other projects, I'm not sure I will manage to do it..
Then I would like to work on replacing some fields (ticket description and resolution, followup comment and preset-reply body) into HTML Fields with the use of the TinyMCE library in order to have better formatting and also keep the HTML from email (instead of having an attachment with email_html_body). See #859 for reference.
Another thing I would like to add is a Merging option on the ticket list : select some tickets and then, on an intermediate page, choose which one will receive all the followups of the other ones, also select which information for each ticket's fields. If an email is sent to a merged ticket, the followup has to be attached to the ticket to which it was merged.
Once the TinyMCE widget is integrated, I could add a way to copy-paste screenshots/images directly in it, in order to easily display image in an HTML answer. Images would be uploaded in background through AJAX as a Django media, and then the URL would be used in the HTML (URL has to be absolute since it will be used in emails).
One last thing I would like to try to implement  is the adding of reports on custom fields (the list one in particular).
For exemple, if I add a custom fields with a billing information as a list (maintenance contract, quote, incorrect billing, offered), then I would like to know how many tickets are in which billing per user, or per queue.
I already have implemented some of these features on my fork that I'm using in my company project and I think they can be useful to others. This would be part of my first participation to HacktoberFest 😄

The apply_query issue was introduced back in Refactor query code into customizable class where one instance of apply_query() was missed in a refactor and has resided in the code since. The item that needs to be updated to Query() is in run_report() in staff.py.
Then in #850 from timthelion/patch-1 the reference to the non-existent apply_query() was also added back into staff.py.
Anyone want to volunteer to update that first apply_query() over to the new Query() class object in run_report() in staff.py and remove the reference to import the apply_query() from staff.py at the same time.

Thanks @Benbb96! This is a great list of items, I hope it's not too much for one month but will certainly be a big improvement if so! I think we'd have a solid 0.3.x release if we got that done and fixed the errors like @alligatorbait mentioned.

@Benbb96 and @gwasser, I used the same apply_query change @Benbb96 made and then went and made all the other changes in order to have django-helpdesk run with Django 3.1.2 (current version as of this message).

@Benbb96 you have me looking at the Hacktoberfest shirt now that I know about this.

It occurs to me that the travis ci was still using django 2.x for testing, so I updated the travis ci config. I'll merge the two PRs so we don't lose anything and see where we're at.

So there appears to still be some error still happening but I think we're close! I noticed in the build log we get errors like:
`'saved_queries' template tag (django-helpdesk) crashed with following error:
'AnonymousUser' object is not iterable
.'saved_queries' template tag (django-helpdesk) crashed with following error:
'AnonymousUser' object is not iterable`

@gwasser This error can be fixed in templatetags/saved_queries.py by adding a condition in the beginning of the function :
if user.is_authenticated:

But I didn't have time to investigate for the other errors in the travis build.

I entered a merge request to correct the is_authenticated issue and then found additional test errors that appear when running the tests locally.
get_emails.py was updated but the tests were not, and several errors appear due to this change:

imaplib module missing - This used to exist in get_emails.py and was imported from there. It looks like the whole test_get_email.py needs rework.
test_get_email.py", line 265, in test_commas_in_mail_headers

list_dir module missing
test_get_email.py", line 227, in test_commas_in_mail_headers

poplib module missing
test_get_email.py", line 249, in test_commas_in_mail_headers

Thanks @alligatorbait! I bet the mail libraries in django got renamed and/or moved for Django 3. We'll have to update the imports as necessary.
Which brings a question: should django-helpdesk 0.3.x support Django 2.2+, or should we require Django 3? If both Django 2.2 and Django 3, then we need to be careful with conditional imports, otherwise if just Django 3 then we can replace with correct imports.

I'm a little hesitant to not support Django 2.2 since it is an LTS release, and Django 3.2 LTS is still a good 6 months away (April 2021). But we could decide to simply be cutting edge and support only Django 3. What do y'all think?

Yes, we should retain Django 2.2 support as well as support 3.2. Are you able to update the travis-ci options to do Django 2.2 builds in conjunction with the Django Latest version builds?
I will see about fixing these test_get_email errors, and then also look at the templates to see if I can find a way to provide one that can easily be overridden for a top level site theme.

Thanks @alligatorbait! I updated travis to test Django 2.2 and Django 3.x latest. I think it would be good to support both Django 2.2 LTS and eventually 3.2 LTS so there's a clear upgrade path for folks.

During runtime I see this file as missing.

I don't see any reference to this item in the documentation. I'm adding an html template customization in my next pull request and documenting it, should I add documentation for this at the same time?

docs/custom_templates.rst:6:In particular, users can include a file named helpdesk-customize.css in their django project directory to provide CSS overrides easily.
helpdesk/static/helpdesk/helpdesk-extend.css:4:@import 'helpdesk-customize.css';

The helpdesk-customize.css file is probably unnecessary today. It's a long ago workaround for better customization, but django already supports overriding templates and such.

Should we remove the support for the helpdesk-customize.css, it is not documented (at least not displayed). I can put in another pull request to remove that if we want.

I honestly don't know the best way to support custom CSS in django, if it's all handled by modern django or if we need to do something in our templates to support it. If anyone knows or can do a little research, I support whatever the consensus is.

I went through everything tagged with 0.3.0 and there are several excellent improvement suggestions, some bugs, and some items that have been around forever. But in the list I see no deal breakers to prevent a release of version 0.3.0 at this point. I would want to have a couple of people actually test functionality on both Django 2.2 and Django 3.1 and run through as many functions as possible to make sure there are no deal breaker runtime errors.

In requirements.txt when the requirements are installed this error pops up:
Cloning https://github.com/pinax/pinax-teams.git (to revision dd75e1c) to /tmp/pip-download-jrjkdds3/pinax-teams
Did not find branch or tag 'dd75e1c', assuming revision or ref.
We should probably fix that.

I haven't tested the changes yet, but I've rrad through all the PRs and it looks like some great work is going on. I did review most of the code, but didn't comment just because I didn't see anything obviously wrong 🙂👍

My first run with current version gives me a module missing markdown_deux
I'll look at this and see what is causing it later today.

I'm not familiar with pinax actually, that's part of the work from @timthelion toward better permissions management. We should investigate. I'm not a fan of requiring some random commit. If pinax has a new release, let's use that, if it's not seeing much development then I'm tempted to cut out the pinax dependency altogether and look for a different solution.
I feel like I looked into markdown_deux once before and it was an old package that has a replacement. I think we just need to drop in the new dependency instead.

Actually, looks like someone already removed Markdown-deux, I'm seeing it on the readthedocs master, but in the repo latest on master no reference to it.

That would explain why I thought I looked into it before! I wonder if readthedocs is stuck on an old revision. We used to use master as the current release with a devel branch that was the next release. I changed it to the more standard release branch with master tracking bleeding-edge development. I'll have to log in to readthedocs and see if anything needs changing.

OK I just uploaded the 0.3.0b1 to github and pypi. Please test and keep reporting bugs and submitting PRs. Thank you!

0.3.0 beta 3 is now tagged on github, uploaded to pypi and available on the demo website: https://django-helpdesk-demo.herokuapp.com. This fixes a few issues notably an issue with the login and translations. Please test it and send feedback and PRs! hoping we can turn this into a real release very soon.

0.3.0 beta 3 is now tagged on github, uploaded to pypi and available on the demo website: https://django-helpdesk-demo.herokuapp.com. This fixes a few issues notably an issue with the login and translations. Please test it and send feedback and PRs! hoping we can turn this into a real release very soon.

Since master is using Bootstrap v4.5.3 can I slowly start working on bumping this up to v5 (currently in beta)? v5 offers some really convenient form controls like Datalists amongst other things that would really provide some QoL.

Sure go ahead. We've got to iron out some bugs in the 0.3.x release anyway
so doing cleanups for bootstrap 5 might help clean up the templates.
On Mon, Feb 8, 2021 at 9:53 PM MrPiethon<EMAIL_ADDRESS>wrote:

Since master is using Bootstrap v4.5.3 can I slowly start working on
bumping this up to v5 (currently in beta)? v5 offers some really convenient
form controls like Datalists
https://getbootstrap.com/docs/5.0/forms/form-control/#datalists amongst
other things that would really provide some QoL.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/django-helpdesk/django-helpdesk/issues/878#issuecomment-775620429,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABEKHU4RHKKM4EJHL2MA3M3S6CPTBANCNFSM4SFHKVCA
.

@gwasser, Could I also improve the designs a bit so they look more modern and consistent with other help desks?
An example of a KB item template edit I made:

If so, is there any place in particular you would like me to share the designs?

yeah that looks great! just replace the existing templates with new ones on
a pull request branch. as long as we're not losing features, ok with an
update.
On Mon, Feb 8, 2021 at 10:57 PM MrPiethon<EMAIL_ADDRESS>wrote:

@gwasser https://github.com/gwasser, Could I also improve the designs a
bit so they look more modern and consistent with other help desks?
An example of a KB item template edit I made:
[image: image]
https://user-images.githubusercontent.com/25252033/107313416-536ff300-6a47-11eb-80c0-ce6aa67df87d.png
If so, is there any place in particular you would like me to share the
designs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/django-helpdesk/django-helpdesk/issues/878#issuecomment-775643888,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABEKHU4VYEPIAX4VKYUSZO3S6CXDTANCNFSM4SFHKVCA
.

Awesome happy to hear that. Will start working on the PR once I finish the designs and release them on my platform.

@MrPiethon I had updated the Create Ticket Buttons on the Knowledge Base section to display something other than 'Contact a Human', hoping you'll keep with the updated theme for the ticket creation buttons.

Any objections to adding a DateTime picker? https://github.com/xdan/datetimepicker MIT license and active with significant utilization.

@MrPiethon I had updated the Create Ticket Buttons on the Knowledge Base section to display something other than 'Contact a Human', hoping you'll keep with the updated theme for the ticket creation buttons.

Are your changes present in master branch?

Yes, basically the button text said "Create Ticket in Queue: xxxx xxxx"
On Wed, Feb 10, 2021, 1:21 PM MrPiethon<EMAIL_ADDRESS>wrote:

@MrPiethon https://github.com/MrPiethon I had updated the Create Ticket
Buttons on the Knowledge Base section to display something other than
'Contact a Human', hoping you'll keep with the updated theme for the ticket
creation buttons.
Are your changes present in master branch?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/django-helpdesk/django-helpdesk/issues/878#issuecomment-777003885,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOLRZMOWPX3IJKFIZM7UGA3S6LTEXANCNFSM4SFHKVCA
.

I noticed that the change also broke a test that was looking for 'Contact a human'
FAIL: test_kb_category (helpdesk.tests.test_kb.KBTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/django-helpdesk/django-helpdesk/helpdesk/tests/test_kb.py", line 50, in test_kb_category
    self.assertContains(response, 'Contact a human')
  File "/home/travis/virtualenv/python3.6.12/lib/python3.6/site-packages/django/test/testcases.py", line 454, in assertContains
    self.assertTrue(real_count != 0, msg_prefix + "Couldn't find %s in response" % text_repr)
AssertionError: False is not true : Couldn't find 'Contact a human' in response

Any update on this? I'd like to help, but I'm not familiar enough with the project to know what might be missing.

@brendanwood have you used the beta? Any last minute bugs or problems? It's really just waiting on me to officially release it I think, which I can do this week. I've had a lot on my plate recently so apologize about the delay.

@gwasser I have not used the beta, but we're at the point where we may switch our prod version to the beta anyway. In fact, if that would help you decide whether beta is ready for a release, we can just do that and report back after a couple weeks of using it in prod.
I'll do that and let you know how it goes.

Thanks! Yes I've been hopeful to get more feedback before officially
releasing it. If you plan to switch and don't mind reporting bugs, that
would definitely help get it officially released. Let me know your
experience switching over!
On Tue, Aug 17, 2021 at 2:58 PM Brendan Wood @.***>
wrote:

@gwasser https://github.com/gwasser I have not used the beta, but we're
at the point where we may switch our prod version to the beta anyway. In
fact, if that would help you decide whether beta is ready for a release, we
can just do that and report back after a couple weeks of using it in prod.
I'll do that and let you know how it goes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/django-helpdesk/django-helpdesk/issues/878#issuecomment-900553642,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABEKHU4S7KALOCI4S3NVMOTT5KWPDANCNFSM4SFHKVCA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

We have upgraded our test environment so far, we will roll this out to prod with our next deploy as long as everything continues to look fine. There were a few hurdles to upgrade our test environment, may need to update documentation so that others can upgrade smoothly.

Under INSTALLED_APPS, bootstrapform needs to be replaced with bootstrap4form

pinax_teams appears to be a new required dependency, but is not listed in requirements.txt. Is this correct?

Assuming pinax_teams is a legit new dependency, need to add the following to INSTALLED_APPS for pinax_teams:

        "account",
        "pinax.invitations",
        "pinax.teams",
        "reversion",

If using send_templated_mail, then it now needs to be imported from helpdesk.templated_email

Missing migration for Alter field email_on_ticket_change on usersettings. Here is the migration file I generated. I can submit that in a PR if needed.

        # Generated by Django 3.1.13 on 2021-08-18 14:30

        from django.db import migrations, models
        import helpdesk.models

        class Migration(migrations.Migration):

            dependencies = [
                ('helpdesk', '0034_create_email_template_for_merged'),
            ]

            operations = [
                migrations.AlterField(
                    model_name='usersettings',
                    name='email_on_ticket_change',
                    field=models.BooleanField(default=helpdesk.models.email_on_ticket_change_default, help_text="If you're the ticket owner and the ticket is changed via the web by somebody else,do you want to receive an e-mail?", verbose_name='E-mail me on ticket change?'),
                ),
            ]

Other than that, the migration went smoothly so far. I will update once we push to prod.

thank you @brendanwood for the update! this sounds promising that there were no major hiccups so far. I can make the changes you listed above and if things go smoothly I'll release this as 0.3.0. thanks for your help!

FYI @brendanwood I made the changes you suggested, added the migration and added a new upgrade.rst file to the docs that give info on how to upgrade from older versions of django-helpdesk. Let me know if you have any other changes, or PRs welcome! In general, PRs welcome from all the folks in this thread, if you have time to tackle a few 0.3.0 bug reports before we release.

@gwasser Thanks for your patience on this. It took us longer than expected to get this rolled out to prod because there were a cascade of dependency updates from our Django3 migration.
We have been running the master branch of django-helpdesk in prod for the last week. Overall it seems quite stable.
We did encounter one major issue regarding email processing from Outlook-based email addresses. Here is a PR that appears to fix the issue for us:
https://github.com/django-helpdesk/django-helpdesk/pull/974
The error we were seeing was thrown by the postmark integration but caused by bad whitespace characters in certain message fields that was not being stripped. It's not clear whether this will affect other email providers, but it's important to make sure this is fixed before cutting the 0.3.0 release.

Thanks for testing and sending a PR @brendanwood! I accepted it into master, should get rolled up into a beta shortly. I know of maybe one other main fix we should do before official release, but almost there. Anyone else following this thread: any last minute fixes? Bugfix PRs welcome!

@gwasser wondering what the timeline looks like for an official release? We have been running the master branch in production for about 2 weeks now.

There's a couple bugfixes I want to get in before cutting an official release, but I'd expect probably next week @nickmccullum. I'll probably roll up one last beta this weekend, wait a few days, then cut the release next week. So, last call for folks in the thread to point out any blocker or important bug, otherwise we'll put it off to 0.3.x bugfixes or 0.4 development branch.

I uploaded a beta 5 just now, please give it one last look over this week. If no major blockers, I'll make it official 0.3.0 release by next Monday probably. Thanks everyone!


Pybids database creation toggle

Closes #

Changes proposed in this pull request:

Checklist (for reviewers)
This section is for the PR reviewer

[ ] PR has an interpretable title with a prefix (e.g. [BUG], [DOC], [ENH], [MAINT])
Refer to NumPy Development Guide for a full list
[ ] PR links to GitHub issue with mention Closes #XXXX
[ ] Tests pass
[ ] Checks pass

For new features:

[ ] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions

Addresses issue #253


Fix right mouse click on <a href""> in firefox

#982

Should this perhaps use button instead of which which appears to be non standard?

@reaction1989 In all web browsers I have tested middle click (mouse wheel click) opens link in a new tab. Unfortunately in Blazor middle click on internal link works exactly the same as left click. I think that your small change will fix this problem also. Thanks!

Thanks, @reaction1989 and @Suchiman! This is now merged.

maybe we could've updated eventHasSpecialKey with the new check "|| event.bouton === 0"

eventHasSpecialKey is here for handling those cases when we don't want to override the browser behavior (ctrl click, shift click). The check button === 0 could be in this method as it's the same goal. Is that clear enough ?

In my humble opinion eventHasSpecialKey is a utility function. Similarly isWithinBaseUriSpace is also utility function. Both functions together + outer if are used to decide if we want to perform internal navigation or not.

fair enough


  PLEASE DON'T ASK FOR WORKAROUNDS OR TIMELINES - THIS IS FREE SOURCE CODE
NO ISSUES ARE BEING TAKEN FOR DOCS, ONLY PR'S
ISSUES MUST include full reproducible sample and stacktrace or they will be closed without explanation!!!
I have added push notifications to my android app, and the push received event in the PushDelegate fires but no notification is ever displayed.
Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[ ] iOS
[ x] Android
[ ] UWP

PLATFORMS THAT YOU CANNOT FILE ISSUES ON RIGHT NOW: Tizen, watchOS, tvOS, macOS
IF YOU HAVE AN ISSUE WITH DOCUMENTATION, DO NOT FILE AN ISSUE - PR'S ONLY!
Feature Library

[ ] Core (Jobs, Settings, Initialization)
[ ] Locations (GPS, Geofencing, Motion Activity)
[ ] HTTP Transfers
[ ] Notifications
[ ] NFC
[ x] Push - Native
[ ] Push - Azure Notification Hub
[ x] Push - Firebase
[ ] Sensors
[ ] BluetoothLE Client
[ ] BluetoothLE Hosting
[ ] Beacons
[ ] SQLite Integration

Version of Library
<IP_ADDRESS>69
Version of OS(s) listed above with issue
10
Steps to Reproduce

Set up push for android as per instructions

        public override void ConfigureServices(IServiceCollection services, IPlatform platform)
        {
            if (DeviceInfo.Platform == DevicePlatform.iOS)
            {
                services.UsePush<PushDelegate>();
            }
            else
            {
                services.UseFirebaseMessaging<PushDelegate>();
            }
        }

Create Push Delegate

    public class PushDelegate : IPushDelegate
    {
        public Task OnEntry(PushNotificationResponse response)
        {
            Analytics.TrackEvent($"[PushDelegate-OnEntry]: {response.Text}");
            Debug.WriteLine($"[PushDelegate-OnEntry]: {response.Text}");
            return Task.CompletedTask;
        }

        public Task OnReceived(PushNotification notification)
        {
            Analytics.TrackEvent($"[PushDelegate-Received]: {notification.Notification?.Title}");
            Debug.WriteLine($"[PushDelegate-Received]: {notification.Notification?.Title}");
            return Task.CompletedTask;
        }

        public async Task OnTokenChanged(string token)
        {
            Analytics.TrackEvent($"[PushDelegate]: TokenChanged (AV4 : {AddViewApplication.UsingAv4})");
            Analytics.TrackEvent($"[PushDelegate]: TokenChanged {token}; using AV4 {AddViewApplication.UsingAv4}");
            Debug.WriteLine($"[PushDelegate]: TokenChanged {token}; using AV4 {AddViewApplication.UsingAv4}");
         }
    }

Add Shiny to Main Activity

using Android.App;
using Android.Content.PM;
using Shiny;

[assembly: ShinyApplication(
    ShinyStartupTypeName = "AddView.Mobile.AppStartUp",
    XamarinFormsAppTypeName = "AddView.Mobile.App"
)]

namespace AddView.Mobile.Droid
{
    [Activity(Label = "AddView", Icon = "@mipmap/icon", Theme = "@style/MainTheme", MainLauncher = true,
        ConfigurationChanges = ConfigChanges.ScreenSize | ConfigChanges.Orientation,
        ScreenOrientation = ScreenOrientation.Portrait)]
    public partial class MainActivity : global::Xamarin.Forms.Platform.Android.FormsAppCompatActivity
    {
    }
}

Add Permissions to manifest

<manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionCode="1" android:versionName="0.0.0" package="com.xxxx.xxxxx">
	<uses-sdk android:minSdkVersion="21" android:targetSdkVersion="29" />
	<uses-permission android:name="android.permission.INTERNET" />
	<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
	<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
	<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
	<uses-permission android:name="android.permission.USE_FINGERPRINT" />
	<uses-feature android:name="android.hardware.location" android:required="false" />
	<uses-feature android:name="android.hardware.location.gps" android:required="false" />
	<uses-feature android:name="android.hardware.location.network" android:required="false" />
	<uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
	<uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
	<uses-permission android:name="android.permission.ACTIVITY_RECOGNITION" />
	<uses-permission android:name="com.google.android.c2dm.permission.RECEIVE" />
	<uses-permission android:name="android.permission.WAKE_LOCK" />
	<uses-permission android:name="android.permission.GET_ACCOUNTS" />
	<application android:label="AddView.Mobile" android:icon="@mipmap/icon" android:allowBackup="false">

	</application>
</manifest>

Request Push Access

        public async Task<string> RequestAccess()
        {
            if (_deviceInfo.DeviceType == DeviceType.Virtual) return string.Empty;

            var result = await _pushManager.RequestAccess();

            if (result.Status != AccessState.Available && !string.IsNullOrWhiteSpace(result.RegistrationToken))
            {
                return string.Empty;
            }

            await RegisterForNotifications(result.RegistrationToken);  // Server Registration

            return result.RegistrationToken;
        }

Send Push Notification

Expected Behavior
A notification should be displayed when I swipe down to see notifications
Actual Behavior
Debug & AppCenter Statement shows that Push Delegates OnReceived fires
No push notification is displayed to the user

If you're using firebase, use firebase.  You shouldn't be doing an if on that.

@aritchie
Looks like it's a native way to add push notification in general:

iOS - Native
Android - Firebase Cloud Messaging

Why we should force use Firebase for both?

That's the whole purpose of Shiny is to manage the cross platform for you.  Firebase is used as the native mechanism on Android with just UsePush.  The only reason to reference the firebase package is because you are using firebase with iOS as well.

I had that before, I have now changed it to  be:
        public override void ConfigureServices(IServiceCollection services, IPlatform platform)
        {
            services.UsePush<PushDelegate>();
        }

It works fine on iOS but just won't work on Android.
So with the above it is just the same, OnReceived in the PushDelegate fires but no notification.
Interestingly - but on Android OnTokenChanged event in the delegate never fired, which was why I added the server registration logic into where the request access was.

OnTokenChanged only fires outside of RequestAccess.  This is something firebase can occasionally do.
If OnReceived is firing, it means you are likely missing the necessary notification data.  Please provide the message being sent through firebase or take a look at how the code processes the native messages here: https://github.com/shinyorg/shiny/blob/b33f1ac410861b47a2518e5e9c660f4a15e3c7ca/src/Shiny.Push/Platforms/Android/PushManager.cs#L65

so the message that is sent is :
"{ "data" : {"message":"Hello World"} }"

And in the OnReceived method the pushnotification.Data contains the message in the dictionary but the notification is null.

You don't have any notification data in that packet.  Data is custom and can be anything.

thanks for the help, as a work around I added this ti my PushDelegate and it worked perfectly.  If it helps someone else then great.
        public async Task OnReceived(PushNotification notification)
        {
            if (notification.Notification == null && notification.Data.TryGetValue("message", out var message))
            {
                var notificationService = ShinyHost.Resolve<INotificationManager>();
                var result = await notificationService.RequestAccess();

                if (result == AccessState.Available)
                {
                    await notificationService.Send("AddView", message);
                }
          }

You don't need a workaround at all.  You just need to send the notification data as per the firebase instructions.
https://firebase.google.com/docs/cloud-messaging/concept-options


Memory usage increases non-stop and causes application to restart

What happened?
After starting the main kogito processes (provider, region and super cluster flows), memory usage starts increasing and does not stop. After some time, infinispan restarts and caches are cleaned. Processes keep showing in dataindex but not in infinispan. And they are not accessible anymore.
What did you expect to happen?
.
How can we reproduce it (as minimally and precisely as possible)?
Start the application and start non-dying processes.
Anything else we need to know?
No response

Memory heap size increased, will be opened if the issue persists.


Wordpress comic ripper now supports more sites

Test links
http://www.totempole666.com/comic/first-time-for-everything-00-cover/
http://buttsmithy.com/archives/comic/p1
http://themonsterunderthebed.net/?comic=test-post
http://prismblush.com/comic/hella-trap-pg-01/
http://www.konradokonski.com/sawdust/
http://www.konradokonski.com/wiory/
http://freeadultcomix.com/finders-feepaid-in-full-sparrow/
http://comics-xxx.com/republic-rendezvous-palcomix-star-wars-xxx/

@metaprime Can I get an update on when this will be merged?

Sorry, I've been really busy with work. Going out of town for the long weekend. Will merge probably sometime next week.


Enable signature help for option and result

Doesn't need a changelog.

Why only on these 3 variant cases? Do they have something special in common?

Since option and result are now builtins, they're not covered by the generic variant stuff (which is what was used before). So they need to be handled separately like this.


Missed opportunity

Hi, It is good to see that the older version of TODO highlight has been taken over for future dev.  It is a shame that the new version still has the limitation that using todohighlight.keywordsPattern switches off todohighlight.keywords.  I would like to highlight sections of code between two tags with isWholeLine set to true (to pick out code in a particular language) AND also have the facility to pick out keywords for different special formatting.  This could also be achieved by allowing repeated todohighlight.keywordsPattern object keys so you can set different formats for differet regex patterns.  Why would you make this clever tool a single use feature - unless I'm missing something, you can choose one format to apply to one set of items and then you are done.  Wouldn't it be simple enought to cycle through the object array and apply all changes rather than stopping at one?  Do you know of a more comprehensive tool that will allow more choice and versatility.  Thanks.

I don't follow your point. You can have many todohighlight.keywords set, including some which are isWholeLine, and others which aren't, so more suitable for tags. See the long example in the documentation.
If you're still having trouble, please post your relevant settings.

Thanks for the reply.  If I understand it using 'keywordPattern' disables 'keywords'.  I don't see why this limitation is put on the tool, why remove this flexibility.  I think I need both or alternatively the option to use 'keyowrdPattern' several times to create different formatting styles for different instances.
Specifically, I am trying to replicate some of the formatting of notepad++ in VS code.  As such, I would like to highlight all javascript areas in my php code files (some background color ideally, like notepad++ does), hence I need to use regex to seek the multiline areas that are between the script open and close tags using 'keywordsPattern'.  I also want to find and highlight e.g. opening an closing tags for php within markup and other things, but with a different format set from the javascript sections.  Because 'keywordPattern' disables 'keywords'  I can't do both things and because you can only have one instance of 'keywordPattern' which must have a single set of parameters (one only format set) I can't do both things.
Perhaps I read it wrong or have an error in my setup.  Is it possible to repeat part of 'keywordPatten' declaration in order to use it multiple times with different formatting settings?
Thanks again.  Sorry for the misunderstanding.

Please see the example in the documentation. keywordsPattern is a simple setting that just picks up the single default style. But keywords allows you to set many styles, each of which can be defined either by regex or simple string match.


Refactor Courses Page to Use React

This pull request refactors the courses page to use react, adding a course's school and term to the page in the process.
Acceptance Critera:

[ ] All non Hidden courses are visible in /courses

[ ] /courses primarily uses React to display content

[ ] /courses is searchable and sortable

[ ] Table in /courses includes Term and School information

Removed has_many so schools_table is standalone

Schema commit.

Re-added has_many relationship

Created json api for courses

Created CoursesIndex React, added to Courses index

pc/vi - WIP on converting courses page to React Bootstrap Table

Add colors + confirmation to button

Removed unused CoursesIndexItem

Addresses issue #333, #329, and possibly more.

I'm unable to replicate this error on my own machine; investigating.


Fix #5011 (canvas remove+add)

Bug when using map option preferCanvas: true (canvas renderer for paths) and removing then adding back a vector within the same animation frame (typically in the same sequence, as done by Leaflet.markercluster at "zoomend" event, to remove layers and clusters outside visible bounds).
This commit clears the _removed flag from paths when they are added to the canvas.
Also added corresponding test suites.
Note: Leaflet #5011 was moved to https://github.com/Leaflet/Leaflet.markercluster/issues/727 due to bug being initially visible only with MCG plugin.
Demo of result: http://playground-leaflet.rhcloud.com/waw/1/edit?html,output

Thinking about the flag, it does not work if the layer is moved from one pane (therefore renderer) to another (e.g. if developer wants to dynamically change z-index), because the flag is attached to the layer, and we cannot distinguish if the canvas is the same or not.
This is a problem for current version and even with this PR.
To cover such a use case, we would need either to:

store a temporary array / hash map of the layers to be removed (like needsRemoving in Leaflet.markercluster), within each canvas, or
rename the flag to make it specific to each canvas (e.g. ["_removed" + canvas._leaflet_id]), so that each one operates independently.

Thanks! Let's follow-up on the remaining rare case.


DNN-8273 - DAM - file move failed from Amazon S3 to Database folder type

the position of the stream is only used when the steam is seekable

Code review done


Remove commented out EventProcessor::eventthread

I commented this out in 2017, it's time to actually get rid of it.

Cherry-picked to v9.2.x


GDScript 2.0 Can't Assign null to Signal-Typed Variable

Godot version
v4.1.dev1.official [db1302637]
System information
Windows 10
Issue description
var sig : Signal = null results in "Cannot assign a value of type 'null' as 'Signal'".
Yet var sig : Signal; print(sig) prints "null::[Signal]", implying that they can in fact be null.
I'd like to include a strongly-typed Signal parameter in a function call that defaults to null.
Steps to reproduce
var sig : Signal = null
Minimal reproduction project
N/A

All Variant types except Object (Vector2, Color, Array, etc.) are not nullable. Use Signal() for an empty signal.
var my_signal: Signal = Signal()

Use Signal() for an empty signal.
var my_signal: Signal = Signal()

Which BTW is equivalent to:
var my_signal: Signal

as it will be initialized to the declared type's default value (which in this case is Signal()).

var sig : Signal = null results in "Cannot assign a value of type 'null' as 'Signal'".
Yet var sig : Signal; print(sig) prints "null::[Signal]", implying that they can in fact be null.

I agree that's not a bug. What confused OP is how an empty Signal is being printed out: null::[signal]. But null in there tells what Object is assigned to the Signal, it doesn't mean the Signal itself is null. That's just how Signal is being formated/stringified:
https://github.com/godotengine/godot/blob/9f12e7b52d944281a39b7d3a33de6700c76cc23a/core/variant/callable.cpp#L443-L455
It seems consistent and not sure if anything in that aspect could be improved:
extends Node

signal signal_name

func _ready() -> void:
	print(Signal())
	print(signal_name)

Outputs:
null::[signal]
Node(script_name.gd)::[signal]signal_name

I'd like to include a strongly-typed Signal parameter in a function call that defaults to null.

Just to be clear: so what you want is an empty Signal:
func foo(signal_parameter := Signal()) -> void:
	pass

Note there's Signal.is_null method and Signal().is_null() returns true. Yeah, this method's name might be a little confusing too. But it is what it is, it's too late for potential renaming. However, the docs correctly explain what it actually returns.

Duplicate of #72350.


My location button callback function

Could not find a similar question on here. Do we have access to the button press?

nope, you can add a PR for this or create your own my location marker

Customize your button. Here's an idea how. https://github.com/react-community/react-native-maps/issues/209#issuecomment-350907665

@alvelig, @gilbox


KeyboardAwareScrollView not working properly with TextInput when used with states

Try using TextInput with its value stored in state i.e for example -

<TextInput
onChangeText={(text) => {
this.setState({
myText: text
});
}}
value={this.state.myText}
/>
</
After typing some characters try to scroll, the TextInput goes behind keyboard and user cannot scroll it back to top making it impossible for the user to see what is being typed.

Hi!
I using<EMAIL_ADDRESS>and cannot reproduce.
Tested on Android 5 and ios 10.
Me text Input
			<TextInput
				underlineColorAndroid = {'transparent'}
				style={styles.textInput}

				onChangeText={(text) =>{ this.setState({whom:text})  }}
				placeholder='Whom'
				placeholderTextColor = '#7cbeda'
				autoGrow={true}
				multiline = {true}
				value={this.state.whom}
			/>

I had this issue too on 0.4.1, but it was resolved when I updated to 0.4.4.


Updates to use pointer for notes to pass null values

PR for opslevel-go changes:  https://github.com/OpsLevel/opslevel-go/pull/74

99% sure this is no longer needed


Pre/Post Processing V2 clarification

The following V1 post-processing works just fine:
"postProcessingSpecifications": [
  {
    "environment": "Node",
    "timeoutMs": 5000,
    "value": "output = {myVal: 1}"
  }
],

and based on the V2 input / output docs "The output of the post-processing snippet is an object with the following properties: response...", I expected the following to work:
"postProcessingSpecificationV2": {
  "environment": "Node",
  "timeoutMs": 5000,
  "value": "{response: {myVal: 5}}"
},

but this returns the very cryptic error:
TypeError: {(intermediate value)} is not a function

It turns out, because of how unsafeEvaluateV2  works:
(async () => {
  return await (${code})(payload)
})();

it appears the correct post processing V2 snippet has to be:
"value": "({ response }) => { return { response: {myVal: 5}}; }"

This could be much better explained.

Also the value fields in all OIS V2 processing-related tests would error. If those are just placeholders, which is fine, it should be clearer.
https://github.com/api3dao/ois/blob/0235bdd5654a8561776f874474705538f23a1b50/src/ois.test.ts#L710-L807

Mhh, the documentation says:
The processing snippet is a function which receives a payload as an argument.

I see we could mention that the value needs to be a function in a few places, but it feels quite clear to me considering there is an example.

Also the value fields in all OIS V2 processing-related tests would error. If those are just placeholders, which is fine, it should be clearer.

Yep, those should be changed.

Whoops, I didn't want to close this (but I did because I referenced the issue in a closing context).
@dcroote I am happy to implement/review any improvements :)

the value needs to be a function

This is what got me, but you're right there are a few examples. Let me think a little more

I'm trying to understand a bit more on where we can clarify- the word "payload" appears frequently in this section- why this word choice?

I wanted to refer to "the thing passed to processing script" and they are fundamentally different for pre and post processing. TBH I can't think of a better work then payload. Maybe "initial value" but that may be confusing with pre/post processing v1 where you can chain these.

I wanted to refer to "the thing passed to processing script"

I agree it's pretty tricky to think of simple wording here. What about:
- The processing snippet is a function which receives a payload as an argument.
+ The processing snippet expects a function that takes an object as an argument, the properties of which are different for pre-processing and post-processing.

Yeah, I think that is a bit clearer.


Approximate Bounds

from @andrewvyrros:

Seems like a nice usability thing.  Mike shared with MS half a year ago. Stumbling block for ppl new to dp.  Like an easy way to use some budget to let the system figure out min max bounds in DP Creator.  Different from min estimator and max estimator.  Not complicated to implement, but choose bin edges exponentially distance (?) and post process.

SmartNoise SDK currently used hand-rolled implementation of: https://desfontain.es/thesis/Usability.html#usability-u-ding-

Priority: Short-term

I wrote a prototype here:
import opendp.prelude as dp
import numpy as np
dp.enable_features("contrib", "honest-but-curious")

def make_logarithmic_binning():
    """bin each datum into a floating-point band"""
    input_domain = dp.vector_domain(dp.atom_domain(T=float))
    output_domain = dp.vector_domain(dp.atom_domain(T=int))
    metric = dp.symmetric_distance()

    def function(arg):
        arg = np.array(arg)
        band = np.log2(abs(arg)) # bands grow exponentially
        band[~np.isfinite(arg)] = 1025 # infinities get their own band
        return ((arg >= 0) * 2 - 1) * (band.astype(int) + 1074) # sign * band

    return dp.t.make_user_transformation(
        input_domain, metric, output_domain, metric,
        function, lambda d_in: d_in)  # 1-stable

def make_find_bounds(scale, alpha=1e-9):
    """makes a postprocessor that finds bounds from a vector of noisy counts"""
    n_bands = 2099 + 1 + 2099 # negative bands, zero, positive bands
    threshold = -scale * np.log(2 - 2 * (1 - alpha) ** (1 / (n_bands - 1)))

    def function(counts):
        assert len(counts) == n_bands, "expected one count per-band"
        lower_idx = (counts > threshold).argmax() - 1
        upper_idx = n_bands - (counts > threshold)[::-1].argmax()
        idx = np.array([lower_idx, upper_idx]) - 2099

        with np.errstate(over="ignore"):
            return ((idx >= 0) * 2 - 1) * 2. ** (abs(idx) - 1075)

    return function

def make_private_bounds_via_histogram(scale, alpha=1e-9):
    return (
        make_logarithmic_binning() >>
        dp.t.then_count_by_categories(np.arange(-2099, 2100), False) >>
        dp.m.then_laplace(scale) >>
        make_find_bounds(scale, alpha)
    )

def test_binning():
    binner = make_logarithmic_binning()
    print(binner([np.nextafter(0, 1), 2.2250738585072014e-308, 0.5, 1., 2., 1.7976931348623157e+308, np.inf]))
    print(binner([np.nextafter(0, -1), -2.2250738585072014e-308, -0.5, -1., -2., -1.7976931348623157e+308, -np.inf]))

# meas = make_private_bounds_via_histogram(scale)
# print(meas(np.random.normal(size=1000)))

def test_make_find_bounds():
    post = make_find_bounds(scale=1.)
    zeros = np.zeros(2099 + 1 + 2099)
    # zeros[0] = 1000
    # zeros[1] = 1000
    zeros[2100 + 1074] = 1000
    print(post(zeros))

meas = make_private_bounds_via_histogram(scale=3., alpha=1e-9)
print(meas(np.random.normal(size=1000, scale=10))) # ~> [-8.0, 8.0]
print(meas.map(d_in=1)) # -> .333 = ε