refactor: ziofy ValuesRouteV1 (DEV-2012)

Pull Request Checklist
Task Description/Number

Issue Number: DEV-2012
Basic Requirements
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] fix: represents bug fixes
[x] refactor: represents production code refactoring
[ ] feat: represents a new feature
[ ] docs: documentation changes (no production code change)
[ ] chore: maintenance tasks (no production code change)
[ ] test: all about tests: adding, refactoring tests (no production code change)
[ ] other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No
[ ] Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

[ ] Yes (don't forget to update the JS-LIB team about the change)
[x] No

I couldn't properly review the changes in ValuesRouteV1 as there were that many changes. But I guess it is OK. There are a lot of Codacy complaints about missing tests and bad code (e.g. get() on an option) but I guess it's out of scope here..

The complaints about the .get on an Option value were present before. Probably we have to fail with a BadRequest in these cases as well. In those cases I guess the assumption is that the value must be filled as part of that particular request. Before the user would see a 500 in those cases. It would be an improvement if this
wdyt, @irinaschubert ?

I couldn't properly review the changes in ValuesRouteV1 as there were that many changes. But I guess it is OK. There are a lot of Codacy complaints about missing tests and bad code (e.g. get() on an option) but I guess it's out of scope here..

The complaints about the .get on an Option value were present before. Probably we have to fail with a BadRequest in these cases as well. In those cases I guess the assumption is that the value must be filled as part of that particular request. Before the user would see a 500 in those cases. wdyt, @irinaschubert ?

Yes, a Bad Request sounds reasonable in that case.

I couldn't properly review the changes in ValuesRouteV1 as there were that many changes. But I guess it is OK. There are a lot of Codacy complaints about missing tests and bad code (e.g. get() on an option) but I guess it's out of scope here..

The complaints about the .get on an Option value were present before. Probably we have to fail with a BadRequest in these cases as well. In those cases I guess the assumption is that the value must be filled as part of that particular request. Before the user would see a 500 in those cases. wdyt, @irinaschubert ?

Yes, a Bad Request sounds reasonable in that case.

see PR https://github.com/dasch-swiss/dsp-api/pull/2561


Add Spotify embed

resolves https://github.com/v0l/snort/issues/182
I tested embedding songs, playlists, albums, and podcasts and they all work great.
Song embed
https://open.spotify.com/track/1Sgj10byiGzPpI2IrXSFEn?si=6d15381f6d564149
https://snort.social/e/note1rk50pff7r6rhtp4xghdt4ecve82lquma3zhxfkaz564cdzrqstcsfdzgcz

Album embed
https://open.spotify.com/album/3tQd5mwBtVyxCoEo4htGAV?si=CjgdxdAATMu3Xc1YOwq7Jw
https://snort.social/e/note1k6wekcs942nav7m03gp2zpkyw88q08972caq4jutkk4wr5vn43lqv7xakz

Playlist embed
https://open.spotify.com/playlist/4SwuF39rGVg6VX3Sevgn0Y?si=c8f3e9a4dd8946f6
https://snort.social/e/note100h6uz2rkag42j99eghzyr3ppsg7fn0cpmtypwwrj3vt7swlrykqzjzzdl

Podcast embed
https://open.spotify.com/episode/4dDg0a7X2aCAcYxT3aCHOk?si=f28506a3dd4a4b8b
https://snort.social/e/note1z425v420nd7tk63te9zwyeg8v3urucxqm9lxmv63cwe2dvduyxus0g8x8y


Throw error if a dependency was unpublished when trying to link it

Fixes #296

I'm putting this PR on-hold until we tag v2.0.0


feat(IBM Cloud Shell): re-gen service to adopt the new error toolchain

PR summary

PR Checklist
Please make sure that your PR fulfills the following requirements:

[ ] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Afreen1998:x: Afrin KatageriAfrin Katageri seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@Afreen1998 For some reason, when you submitted your PR a Travis build was not triggered.  I'm not sure why this happened.   Could you please force-push an amended commit to your branch and see if that kickstarts git/travis to kick off the build?

Will open an another PR , added a wrong commit message and committed with wrong ID.


Restoring a huge table is a synchronous operation

While restoring a big table the session is getting blocked. No other action can be performed on dderl while the restoring is going on.

@shamis after reviewing the code I found it is not serialized in dderl side as it is as any other normal request so it is probably getting stuck in the imem side so no other operation is getting a response until this one finishes.
Moving this to imem.


v9 type errors with typescript

🤓 Question
Thanks for the great work!!
I believe it is because style require React.CSSProperty rather than any since v9.
when I try like this or
style={props}
is shows error because props returns SpringValue
and when like this or interpolate()
is shows error because string dose not meet PositionProperty type
so, how should I use position propperty with typescript

I noticed this too. With the new typings for the v9 beta interpolate is not working properly anymore if it's used for certain CSS properties such as visibility. Example here: https://codesandbox.io/s/flamboyant-tu-npoxr

As you've noticed, the position and visibility props have a string union type, rather than the wider string type. You need to cast your string to ensure it has the right type.
type Position = React.CSSProperties['position']

// In your `useSpring` call or similar:
from: { position: "absolute" as Position, opacity: 0 },

It would be unsafe for react-spring to widen those props to string, so you (unfortunately) need to manually ensure your values are the correct type.

@aleclarson would it be possible to define a generic overload for interpolate? Casting the result doesnt seem to be working: https://codesandbox.io/s/flamboyant-tu-npoxr
Ideally I would like to be able to call interpolate such as this: opacity.interpolate<Visibility>(x => x === 0 ? "hidden" : "visible")

@dagstuan I've made it less strict about the return type, so casting should work now. 👍

@aleclarson perfect, works great now, thank you! 👍

Note: For 100% type safety, you should be using as const instead.

Note: For 100% type safety, you should be using as const instead.

Can you please elaborate? If you can give a quick code example. Thanks in advance!


modules: hal: nxp: update to include fix for CACHE64_GetInstanceByAddr()

CACHE64_GetInstanceByAddr() function was asserting when an instance was requested for an invalid address that the CACHE64 controller does not manage. This behavior is not correct, as the CACHE64 management functions check to see if the instance number returned by this function is out of range (and if so, simply return without modifying the cache).
This assertion was causing a failure within the USDHC driver, which performs a cache clean/invalidate for tx/rx transfers within the HAL layer. When a transfer was run using a data buffer not in the CACHE64 address range, this assertion failed and caused the application to crash
Fixes #80901

@danieldegrasse , please update the HAL SHA

@danieldegrasse , please update the HAL SHA

Done, thanks for the ping

@danieldegrasse this pr fix part of this sdmmc issue, still another one
b8466e0c951b8a159ed0a0465ed831497668197b is the first bad commit
commit b8466e0c951b8a159ed0a0465ed831497668197b
Author: Vit Stanicek<EMAIL_ADDRESS>Date:   Mon Aug 5 10:40:04 2024 +0200

    boards: mimxrt685_evk/mimxrt685s/cm33: Enable DMIC

    Enable DMIC clock in soc.c - attach to chip's audio PLL. Add pinmux
    definitions for the DMIC peripheral. Add nodes to SoC's device tree for
    the DMIC peripheral and its audio channels. Configure the DMIC
    peripheral in board's device tree to enable audio capture.

    Signed-off-by: Vit Stanicek<EMAIL_ADDRESS>
 .../nxp/mimxrt685_evk/mimxrt685_evk-pinctrl.dtsi   | 10 ++++
 .../mimxrt685_evk_mimxrt685s_cm33.dts              | 27 ++++++++-
 dts/arm/nxp/nxp_rt6xx_common.dtsi                  | 66 ++++++++++++++++++++++
 soc/nxp/imxrt/imxrt6xx/cm33/soc.c                  | 12 ++++
 4 files changed, 114 insertions(+), 1 deletion(-)

@danieldegrasse this pr fix part of this sdmmc issue, still another one

b8466e0c951b8a159ed0a0465ed831497668197b is the first bad commit

commit b8466e0c951b8a159ed0a0465ed831497668197b

Author: Vit Stanicek<EMAIL_ADDRESS>
Date:   Mon Aug 5 10:40:04 2024 +0200

    boards: mimxrt685_evk/mimxrt685s/cm33: Enable DMIC

    Enable DMIC clock in soc.c - attach to chip's audio PLL. Add pinmux

    definitions for the DMIC peripheral. Add nodes to SoC's device tree for

    the DMIC peripheral and its audio channels. Configure the DMIC

    peripheral in board's device tree to enable audio capture.

    Signed-off-by: Vit Stanicek<EMAIL_ADDRESS>

 .../nxp/mimxrt685_evk/mimxrt685_evk-pinctrl.dtsi   | 10 ++++

 .../mimxrt685_evk_mimxrt685s_cm33.dts              | 27 ++++++++-

 dts/arm/nxp/nxp_rt6xx_common.dtsi                  | 66 ++++++++++++++++++++++

 soc/nxp/imxrt/imxrt6xx/cm33/soc.c                  | 12 ++++

 4 files changed, 114 insertions(+), 1 deletion(-)

Locally the sdmmc test passes for me with this fix. Do you still see a failure on your board?

Locally the sdmmc test passes for me with this fix. Do you still see a failure on your board?

sorry my bad. this PR fixes all issues.


Allow explicitly specifying the security protocol

EWay has changed their Sanbox API to use TLS1.2. I have updated the code to allow support for explicitly specifying the security protocol to connect to the EWay API with.  It is backwards compatible since the production API is currently not on TLS1.2 yet.

After further testing, I found that upgrading to .NET 4.6 seems to fix the problem without requiring the change ServicePointManager code. This may be a more viable option, I have updated my fork. Will close this PR as .NET 4.6 might not be relevant to all library users.


Patch?

Hey i think they did some type of patch where 1 message per ip address can u check this out and lmk? and if its like that now can u add a proxy feature where we add proxies and can spam

Are you sure about that? I tested it out and it seems to be the same for me.

wym the same? what i said or the bot is working fine?

Sorry, should have been more clear, I didn't notice any ip patch on their end, it works just as well as before, for me, but it does get stuck after a few hundred messages, so I will add a proxy option soon enough.

ok when u add the option lmkk reply heree

and it only sends 1 mesage not 100

I've looked into it and it doesn't seem like there's a way to set multiple proxies with selenium, because the back-end is a browser and those are not designed for this. What I can do is add an option for a single proxy and then you can use some external software like proxifier that allows you to chain.

I have created a separate branch with a proxy option. Will only merge if more people request it, as it adds some code complexity that I don't like.


Add DCO explanation.

Signed-off-by: Tom Kelley<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

documentation?

What this PR does / why we need it:
I was really confused why my PR got tagged "dco-signoff: no", and I wanted to make sure that nobody else was confused like I was.
Which issue(s) this PR fixes:

N/A
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: distortedsignal
To complete the pull request process, please assign fjogeleit after the PR has been reviewed.
You can assign the PR to them by writing /assign @fjogeleit in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 3d05c27b48db54177051158a2351fa7ab0d2db75

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: distortedsignal, Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Update README.md

Little addition to make it fully clear, as I just ran into these issues

Thanks for PR!


Cache similar jobs for 12 hours

Store vacancy IDs for similar jobs in the Rails cache for 12 hours so
we don't keep hitting Algolia.

Review app deployed to https://teaching-vacancies-review-pr-2957.london.cloudapps.digital


wiki:pull-request  Apache HTTP Server configuration initial (2014-11-19 13:46:04 +0100)

Hi guys, my
git request-pull 261a55d0 https://github.com/Karm/mod_cluster.wiki.git 261a55d0

generated this lovely message for you:
The following changes since commit 261a55d065b496baffb596ae2727dc43533b5006:

  Apache HTTP Server configuration initial (2014-11-19 13:46:04 +0100)

are available in the git repository at:

  https://github.com/Karm/mod_cluster.wiki.git master

for you to fetch changes up to 261a55d065b496baffb596ae2727dc43533b5006:

  Apache HTTP Server configuration initial (2014-11-19 13:46:04 +0100)

----------------------------------------------------------------

Closing. GitHub Wiki doesn't suit us. The solution is GitHub Pages with Jekyll SaaS: http://modcluster.io/.


Add Toxicity tables to the Safety section

Porting logic previously implemented in the 20.04 release.

This should address issue opentargets/platform#1034 (a follow-up to opentargets/platform#1017).

The ‘Source’ column contains a link in the tables. In the file downloads, I export the URL there, but as opposed to the publication URL in the Adverse effects and Safety risk information tables, the URL seems to be the same for all rows here. Let me know if you think I should put the name of the data source (the text of the link) in these exported fields instead.

Should I also push a commit to hide the Adverse effects and Safety risk information tables when they are empty?

Should I also push a commit to hide the Adverse effects and Safety risk information tables when they are empty?

@fedde-s yes if you could do that, it would be much appreciated. These data sets only cover a small portion of targets so if we could hide when the data is not available - as we currently do in the Angular app - that would be great!

The ‘Source’ column contains a link in the tables. In the file downloads I export the URL there, but as opposed to the publication URL in the Adverse effects and Safety risk information tables, the URL seems to be the same for all rows here. Let me know if you think I should put the data source name (the link text/label) in these exported fields instead.

@fedde-s the URL is fine. It is the same because we had to separate each data source - eTOX and Tox21 - into its own data table because of the differences in the underlying data. However, one of our informatics projects is curating more data for these tables and so eventually we will have different URLs in the source column 👍

@LucaFumis can you please review?
I have checked the deploy preview (e.g. ESR1 and CDK2 and MTOR) and all scenarios look good to me 👍

@andrewhercules:

if we could hide when the [ Adverse effects and Safety risk information ] data is not available - as we currently do in the Angular app - that would be great!

Done! Feel free to squash the commits as you see fit, or to ask me to squash/reorder some of them.

(e.g. ESR1 and CDK2 and MTOR)

An example of a target with both toxicity tables: ABCG2
And one with only an eTOX table: SLC28A2


N815: TypedDict Subclasses are not ignored

In https://github.com/astral-sh/ruff/pull/4066 a routine was implemented to ignore TypedDicts from N815 (mixed-case-variable-in-class-scope). But subclasses are not respected from the ignore rule for TypedDicts.
from typing import TypedDict

class Baseclass(TypedDict):
    camelCaseOK: str # No violation

class Subclass(Baseclass):
    camelCaseNotOK: str # Violation! But should not violate because it is a subclass of Baseclass

Thanks for opening the issue! Luckily, this was fixed three days ago in #10719, so shouldn't be an issue once the next release comes out :-)
Closing as a duplicate of #10671


Building openbabel first, will come back for deepchem

#677 is not building because OpenBabel is not building. I think this is a chicken-egg problem so I am going to try and build and push openbabel first, then come back for deepchem.

@Lnaden : It looks like everything works in building openbabel except the test script path is misconfigured (or the test file is not checked in):
===== testing package: openbabel-2.4.0-py35_2 =====
import: 'openbabel'
import: 'pybel'
running run_test.py
===== openbabel-2.4.0-py35_2 OK =====
+ /bin/bash -x -e /anaconda/conda-bld/openbabel_1484940011820/test_tmp/run_test.sh
+ cd /anaconda/conda-bld/openbabel_1484940011820/test_tmp/test
/anaconda/conda-bld/openbabel_1484940011820/test_tmp/run_test.sh: line 3: cd: /anaconda/conda-bld/openbabel_1484940011820/test_tmp/test: No such file or directory
TESTS FAILED: openbabel-2.4.0-py35_2

I'm not exactly sure how to fix that. I've got a few things I can try. Altenetley, we can remove the test section from the meta.yaml file and rely instead on the run_test.py file for testing.
From what I can tell, it looks like something changed in the way the source is built on the back end. Its been a year since this was originally compiled, so I imagine some things changed under the hood which are now causing this to fail.

Let's just remove these lines.

Sure, I just changed those from what they were to try and work around the error. If we remove those we reduce the ability to test the package though.

Sure, I just changed those from what they were to try and work around the error. If we remove those we reduce the ability to test the package though.

@rbharath can improve the testing in a separate PR if he ends up finding needed functionality is missing.

There is a test that is still run which does do the imports (PyBel imports the OpenBabel libs). So I think having the meta.yaml's test section do an import of the two packages is redundant, if I am interpreting the run_test.py script correctly.
I can also verify from the travis builds that the run_test.py script is being run successfully, so I think we are good.

Ah, OK. As long as there is some minimal check of whether it built the package, that should be fine!


Android export for GLES2 doesn't include textures unless ETC import is configured manually

Godot Version 3.1 Alpha 2
Android 6.0, Xiaomi Redmini Note 3
GPU: Adreno 510
Issue description:
I created a little project to test the 3D of GLES2 with android. It is a simple app with a rotating blue cube and when a user tapping the screen appears a spaceship. After I exported it to droid and tested on my device, I found that the blue cube is Ok, but the spaceship not appeared. I checked the logcat, and I found the app did not find some resources. I checked the generated APK file, and I also did not see the incriminated files. I used 64 bit version of windows 10 for development/export. I also exported a windows version from the same project, and it run flawlessly, it seems that the issue related with the Android export only.
I attached the project, the logcat result and the zipped archive of the APK file.
Playground2.zip
logcat.txt
Playground2 _apk.zip

The problem is that Android uses the ETC compression format for GLES2 (and ETC2 for GLES3), but by default only ETC2 and S3TC (desktop) are imported. (See in rendering/vram_compression in ProjectSettings).
Enabling ETC import and reimporting the freelancer.jpg texture fixes it. But those are cryptic settings for most users, Godot should make sure that the correct formats are imported before exporting to a target requiring them.

Thank you, it solved my problem.

Tested this out in a sample, project, and the fix works. But should the ETC import option be enabled by default or called out in the docs for people targeting Android GLES2? I'm testing a project I was developing in 3.0, just imported the whole thing into 3.1 alpha 2. I get a whole bunch of scene loading issues which I think are propagating from the failure to load textures, and I don't know a good way of fixing the whole project without reimporting each asset individually. It seems like deleting the import folder might work, but haven't had success so far.

This likely constitutes a new feature, but I had a head-scratching moment the other day because I wanted to support a workflow that meant using GLES3 on desktop, and GLES2 on mobile (this is for VR development, btw). When I tried switching the project to GLES2 to run on mobile, it crashed. Checking the logs via adb, it was trying to load assets that weren't there. The fix was switching to Etc. IMO, that should either happen automatically, or be a pop-up message when you change the video driver that is an impossible-to-miss reminder.

Actually I fixed this issue in 3.1 already with #26523, as exporting a GLES2 project to Android now requires rendering/vram_compression/import_etc to be enabled. Enabling it requests an editor restarts and triggers a reimport of all textures.


Compiled queries don't evaluate conditions that depend on parameters

I was hoping to use a single compiled query for filtering, paging and sorting of a set of aggregate models. In this scenario some of the parameters to the query would be nullable as they are optional. In this scenario the generated sql for the compiled query evaluates based on the first values used with the query.
For example if I have the following query to search for quests, optionally filtered by Hero...
public class GetQuestsQuery : ICompiledListQuery<Quest>
{
    public Guid? Hero { get; set; }

    public Expression<Func<IQueryable<QuestDetails>, IEnumerable<QuestDetails>>> QueryIs()
    {
        return query => query.Where(x => !Hero.HasValue || x.Hero == Hero)
    }
}

The following is the sql that is generated...
select d.data, d.id, d.mt_version
from public.mt_doc_quest as d
where ((true or CAST(d.data ->> 'Hero' as uuid) = :arg0)

Note that the where condition includes a true or, I believe this equates to the !Hero.HasValue || part of the Where clause in the Linq query. This occurs if the first usage of the query contains a null value for the Hero property. I believe the SQL generated should vary depending on the inputted parameter.
I haven't yet dived into the code to see how this hangs together, but I can imagine why this might be hard to do. In anycase this feels like a common use case. I wonder how others have dealt with it.

"I can imagine why this might be hard to do" -- I can. Relinq reduces the expression !Hero.HasValue into the boolean value so the compiled query planner doesn't even know that the Hero property is used within the first part of the Where clause.
You're going to have to leave this open as a defect for now. I don't have any ideas for making this work without diving into Relinq itself.

Stuck with the same problem. However I guess the original solution is  suboptimal. Besides complexity of parsing ling it creates cryptic SQL queries which are hard to read and may lead to messy execution plans.
This can be fixed in a different way - caching not a single plan, but a set of ICompiledQuerys with custom IEquatable or IEqualityComparer implementations like this:
public class GetQuestsQuery : ICompiledListQuery<Quest>, IEquatable<Quest>
{
    public Guid? Hero { get; set; }

    public Expression<Func<IQueryable<QuestDetails>, IEnumerable<QuestDetails>>> QueryIs()
    {
        if(Hero.HasValue)
		{
			return query => query.Where(x => x.Hero == Hero);
		}
		return query => query;
    }

    public bool Equals(Quest other) => Hero.HasValue == other.Hero.HasValue;

    public int GetHashCode(Quest other) => Hero.HasValue.GetHashCode();
}

It will produce simpler SQL queries and avoid fighting with LINQ parsing. Still don't how hard it would be to implement the feature.

@solyutor What you're doing is never going to work because of the conditional inside of QueryIs(). In your case though, you could just use the user supplied query mechanism easily enough.

@jeremydmiller Sorry for being unclear in my first message, I know (why) it doesn't work with current version.  What I meant was "Is it a good idea to create a PR for such a feature?" I've tried and here's what I've done https://github.com/solyutor/marten/commit/07cbf0ad928e68744e4d211740545862e85811f3.
Hope you'll have some time to review it and decide whether it worth to create a PR.

@solyutor Sorry for taking so long to look at this. At this point, the compiled query implementation was rewritten for V4, so the potential PR wouldn't help. I'd honestly just say that you use separate compiled query types. I just don't want any more complexity in that code.


Azul Zulu 17 JRE download query

@davidbpirie
You may remember last year we worked together on some issues I had creating AutoPkg Munki recipes to download via your matching download recipe. This was at the time purely in relation to downloading JDK versions and we solved all those issues and this is still working fine currently for JDK releases.
Today I decided I would like to have a JRE version 17 and I therefore used exactly the same approach to make a new AutoPkg Munki recipe and fill in details instead to download the JRE instead of a JDK.
This is pretty much working but I have hit one minor issue which I think is related to your download recipe and how Azul have listed versions.
Currently they have one JRE 17 for Apple Silicon, but two JRE 17 for Intel listed. See screen capture below. Your recipe is downloading unfortunately the older of the two Intel versions and ignoring the newer one. Ideally you would alter this.

@jelockwood can you please provide all the input variable values you are using? ie JAVA_MAJOR_VERSION, ARCHITECTURE, DOWNLOAD_FILE_EXTENSION, BUNDLE_TYPE?

I suspect the issue is to do with DOWNLOAD_FILE_EXTENSION - if you hover over the Download buttons, you will see that for x86 17.0.7+7 only offers .zip and .tar.gz, and 17+35 only offers .dmg; whereas ARM has all three extensions available for 17.0.7+7.

My munki recipe relies on my pkg recipe, which is written expecting to use my download recipe with DOWNLOAD_FILE_EXTENSION set to dmg, as it will then extract a pkg file from that dmg. If the source version combination you are after doesn't include a dmg, then you will need to write your own recipe that creates a pkg from one of the other file types published.

Ah!
When I first looked this and reported it, I merely saw that it was listing two versions of the JRE17 for x86 processors and that only the older one was being downloaded.
I therefore assumed that your recipe had been confused by this and picked the last one listed which happened to be the older one. However prompted by your reply I have gone back and looked again and yes you are right. I am 'asking' for a DMG and only the older one listed is available for x86 in the form of a DMG, the newer one is only available as a zip or tar.gz and not DMG.
So it would seem to be down to Azul making a mess of things.
I am therefore happy for you to close this issue.


pythonPackages.python-csxcad: init at unstable-2020-02-18

Motivation for this change
Adds python bindings for CSXCAD. @jonringer this is the 2nd last PR related to this PR.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Done, @jonringer.


Source Twilio: Add dbt converter

Closes https://github.com/airbytehq/airbyte-dbt-models/issues/32
How

The tables from the fivetran model are analyzed for source-twilio
https://github.com/fivetran/dbt_twilio_source/tree/main/models

Fivertran's Streams were matched against Airbyte streams and differential tables were identified

Single transformation were made

@marcosmarxm, I've made matches for most models,
The messaging_service model is little fishy, and I can't figure out a match with existing ab schemas
Ready for a first review :bow:

@btkcodedev I don't think Airbyte sandbox account has message_service stream. We can disable and have the model runnign without it, the same as Zendesk.

Done @marcosmarxm :bow:


New Crowdin updates

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: jaydenhur:x: klaytndocsYou have signed the CLA already but the status is still pending? Let us recheck it.


nested async call in an effect handler

According to Talking-To-Servers, I define an effect handler to deal with side-effect, but in this fx, I need to call two async call, something like

(rf/reg-fx
 :chrome-query
 (fn [[start end text]]
   (js/chrome.history.search (clj->js {:text (or text "")
                                       :startTime start
                                       :endTime end
                                       :maxResults 1000})
                             (fn [items]
                               (mapv #(js/chrome.history.getVisits (clj->js {:url (.-url %)})
                                                                  (fn [visits]
                                                                    (rf/dispatch [:query-result visits])))
                                    items)))))

For every item returned from search, I need to call getVisits to get details.
My question here is how to accumulate those results into app-db.
Thanks in advanced.

I'm afraid I don't understand the question.  But it does not seem as if you are reporting an issue or noting possible improvements which is the purpose of github issues.  Please ask usage/tutorial questions via the #re-frame channel in http://clojurians.net/


Azure DevOps Office Integration

Hi there, what about exchanging the old TFS integration with Azure DevOps Office Integration 2019 which also support Office 365 and Office 2019?
https://go.microsoft.com/fwlink/?linkid=2076587&clcid=0x409

Thanks for the suggestion! The product teams aren’t always watching this repository, so to make sure it gets in front of them for triage, please submit your idea here.


cut a release please :)

Hi @TooTallNate can you cut a new release please?

@TooTallNate bump

@TooTallNate bump

bump

bump

@vercel/remix v2.13.1 has been published.


pdfmake improvements for assignments

Some improvements for assignment pdfs generated with pdfmake - splitted out from #2534 ...
Ballot PDF:

[x] remove ":" after ballot number if poll description field is empty

Election PDF:

[x] The state 'elected' ("*") is not shown in pdf if pollmethod is YNA or YN. (Only for VOTES it works.)
[x] Please hide "* = elected" legend if no candidate of the election is marked as elected.
[ ] Replace special values "-1" and "-2" (see motions and assignment-detail template)

General:

[x] use "_" for blanks in filename.

Last open task moved to #2709.


Update combine_data.py

I have updated the function for reading UVigo data because after updating the results for the Scotland case, all the UVigo files have the same name for the tree cases.

Looks great. I did had to make some small changes to make it work (e.g. test_data_pakistan is now called test_data).

I have added the changes to the test file, so it should be okay now (moreover I added one line that executes the testing function, but feel free to remove that).


A zip containing a shp and a txt only imports txt

If you add a .txt to the zip that contains shp files, only the txt is imported (at least, with a filename that is lexicographically before than the rest of the files).
@iriberri is this a known issue? It's strange I've spotted it.

There is (or was) a similar issue about importing a file which contained a KML and another file, and only one of them was imported, but I think this is unrelated and was provoked by another issue (I think it was the bikelanes kml).

Bikelanes kml issue is covered by #2044 indeed, although we're beginning to experiment with different approaches for layer-intensive files // @danicarrion .

We solved this with multi-file importing during the last months.


modify_sysreg: modify name to keep consistent with Linux, express more clearly

Summary
The linux implementation is as follows:
/*

Modify bits in a sysreg. Bits in the clear mask are zeroed, then bits in the
set mask are set. Other bits are left as-is. */ u64 __scs_val = read_sysreg(sysreg);				\ u64 __scs_new = (__scs_val & ~(u64)(clear)) | (set);		\ if (__scs_new != __scs_val)					\ write_sysreg(__scs_new, sysreg);			\ } while (0)
/

Impact
NOne
Testing
None

[Experimental Bot, please feedback here]
No, this PR does not meet the NuttX Requirements. Here's why:

Insufficient Summary:

Missing Context: The summary provides code but lacks crucial context. What is the PR trying to achieve? What problem does it solve (fix), what functionality does it enhance (update), or what new capability does it introduce (new feature)?
Unclear Functional Change:  It mentions "linux implementation" but doesn't explain what part of NuttX's code is being modified and why the Linux approach is relevant.
Missing Details: How does the code change impact NuttX's behavior? What specific changes will occur, and how will they work within the system?
No Issue References:  Are there related issues in the NuttX or NuttX Apps repositories? If so, these should be linked.

Incomplete Impact Assessment:

The PR claims "None" for impact, but this is highly unlikely for any code change.  Every modification has some level of impact. Consider:

Functionality: Does it introduce new features, modify existing ones, or fix bugs?
Build System: Are there changes to build configuration, dependencies, or the build process itself?
Hardware Support:  Does it affect support for specific architectures, boards, or drivers?
Documentation: Does the change necessitate updates or additions to the NuttX documentation?
Security: Does the code introduce any potential security vulnerabilities or address existing ones?
Compatibility: Does it impact backward compatibility with older versions of NuttX, forward compatibility with future versions, or interoperability with other systems?

Missing Testing Information:

"None" is not Acceptable:  Every PR needs evidence of testing to demonstrate its correctness.
Provide Specifics:

Build Hosts: List the operating systems, CPUs, and compilers used to build NuttX.
Target Platforms:  Specify the architectures (including simulators), boards, and configurations tested.
Testing Logs: Include relevant logs from tests conducted before and after the code changes. These logs should highlight the problem being addressed and demonstrate the effectiveness of the fix.

In short, the PR needs significant improvements to meet the NuttX requirements.  Provide a clear and detailed explanation of the changes, their impact, and thorough testing evidence.


add support for multiple regions

[x] update Rust lib (https://github.com/jam1garner/smash-arc/issues/3)
[ ] add regional indicator icon to regional files
[ ] update file details view (https://github.com/ScanMountGoat/ArcExplorer/issues/2)
[ ] specify a region when extracting single files or all files
[ ] add region to user preferences

The smash-arc lib has the following regions:
pub enum Region {
    None = 0,
    Japanese = 1,
    UsEnglish = 2,
    UsFrench = 3,
    UsSpanish = 4,
    EuEnglish = 5,
    EuFrench = 6,
    EuSpanish = 7,
    EuGerman = 8,
    EuDutch = 9,
    EuItalian = 10,
    EuRussian = 11,
    Korean = 12,
    ChinaChinese = 13,
    TaiwanChinese = 14,
}

Region::None should never be selectable from the user interface to avoid extracting empty files. The option can still be part of SmashArcNet for the sake of completeness.

The smash-arc lib has the following regions:
pub enum Region {
    None = 0,
    Japanese = 1,
    UsEnglish = 2,
    UsFrench = 3,
    UsSpanish = 4,
    EuEnglish = 5,
    EuFrench = 6,
    EuSpanish = 7,
    EuGerman = 8,
    EuDutch = 9,
    EuItalian = 10,
    EuRussian = 11,
    Korean = 12,
    ChinaChinese = 13,
    TaiwanChinese = 14,
}

Region::None should never be selectable from the user interface to avoid extracting empty files. The option can still be part of SmashArcNet for the sake of completeness.


Openshift.start_build(): give correct argument to create_build()

Openshift.create_build() needs the JSON, not the internal representation of it.

LGTM


[rstmgr] Verification sign-off for M2.5

Description
Couldn't find a verification task for sign-off - created.
Efforts recorded in issues

[ ] Close out TODOs 0.5d .. 1d #18435
[ ] Complete V2.5 checklist items not captured elsewhere 0.25d #18436

CC: @matutem  @msfschaffner

This has apparently already been closed in #17915.

@matutem can you quickly check whether the associated checklist items and TODOs have been resolved (#18435 #18436)?

All is done. Closing.


Initial PR for SendMessageRemoval

See Issue https://github.com/Microsoft/HoloToolkit-Unity/issues/224 for more details

Hi @HodgsonSDAS, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Gonna close this until we get the GestureManager figured out.


[BUG] [QUESTION] Import reads one extra row

Prerequisites

[x] Able to reproduce the behaviour outside of your code, the problem is isolated to Laravel Excel.
[x] Checked that your issue isn't already filed.
[x] Checked if no PR was submitted that fixes this problem.

Versions

PHP version: 7.2.8
Laravel version: 5.7
Package version: ^3.1

Description

Steps to Reproduce
I have an import that looks like this
<?php

namespace App\Imports;

use App\Kid;
use Carbon\Carbon;
use Illuminate\Support\Facades\Request;
use Maatwebsite\Excel\Concerns\ToModel;
use Maatwebsite\Excel\Concerns\WithHeadingRow;

class KidsImport implements ToModel, WithHeadingRow
{
    public function model(array $row)
    {
        return new Kid([
            'name' => $row['nimi']." ".$row['piirkonna_tahis'],
            'gender' => trim($row['sugu']) === 'P' ? 'M' : 'F',
            'age' => $row['vanus'],
            'gift_wish' => $row['soov'],
            'project_year' => Carbon::now()->year,
            'fulfiller_id' => null,
            'city_id' => Request::post('city_id')
        ]);
    }
}

Expected behavior:
I expect this to only import the rows that have content in them.
Actual behavior:
The package, for some excel files that look identical to the ones that work properly, also tries to import one row after the content. Causing an error 500 in adding it to the database.. Resaving the excel file does not help.
Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue. A demo xlsx is included.
demo.xlsx

When I create a new XLSX file (using LibreOffice) with the contents from your demo file, I don't get the extra (empty) row.
So there is probably something wrong with the XLSX file you're using.
We are considering adding ignoreEmpty to 3.x as well, which might help you in resolving this issue.
Please note that this is just for your information and not a promise that we eventually will add it to 3.x.

hmm :/ The demo file i provided is literally a obfuscated save of the file with the problem. Did you try with that as well?

Using your file indeed has 1 additional row. By copying the values from that file (the cells) to a new XLSX file, I didn't get the extra row.


Changeset status is failing (Proposed solution within)

Affected Packages

Problem
Recently, we changed our directory structure at the job I work at, and Changeset status stopped working as a result

It was telling me that I had no changesets, even though I created one

I applied a fix locally and found it to work for me

Proposed solution
This was the code I fixed, it's a tiny change of [1] to .at(-1)

I believe changesets CLI only work when the .changesets folder is within the current working directory? I'm not sure if $cwd/frontend/.changeset would work everywhere else otherwise. Or maybe it's supposed to work but I haven't seen it setup this way in practice.


Allow client side encryption of shuffle files

Allow users to configure spark.plugin.shuffle.async.encryption.enabled to encrypt shuffle files before uploading them to remote storage.
Encryption is done by palantir/hadoop-crypto.
This builds on top of #646 (SPARK-25299), new functionality is off by default.
cc @mccheah @robert3005

@robert3005 points out that this is supported ootb by Spark, see Local Storage Encryption
, SPARK-5682.


/run/initramfs/live is not accessible when booting LiveCD in UKI mode

Kairos version:
3.0-alpha2
Describe the bug
We used to mount the livecd content to /run/initramfs/live to allow automatic installation and custom user-data ( https://github.com/kairos-io/kairos-agent/blob/0119b9cfb264e9ddbdf91ca0b37f80a89059cea8/main.go#L39 )
To Reproduce
Boot an UKI iso, /run/initramfs/live does not exist.
Expected behavior
The iso to be mounted to /run/initramfs/live

Fixed by:

https://github.com/kairos-io/immucore/pull/223
https://github.com/kairos-io/kairos-agent/pull/225

Needs new versions, trickled down into packages -> framework, keeping this open until it does

missing mounting the efiboot under /run/rootfsbase so the media is available for install.

https://github.com/kairos-io/immucore/pull/224

waiting until the packages are bumped in kairos

packages should now be available in kairos!


unorderable types: str() >= int() and unsupported operand type(s) for -: 'int' and 'str'

I'm using the 0.2.9 version (don't know why neither anaconda or pip don't upgrade the package to the 0.4.0 version)
and when I use some augmenters I nearly always fall on that kind of error. The only augmenters that are actually working for me are the Affine and Fliplr.
The augmenter that give me these errors are these one :
iaa.SaltAndPepper(0.1, per_channel=True),
iaa.Add((-40, 40), per_channel=0.5)
iaa.AdditiveGaussianNoise(scale=(0, 0.2*255)),
iaa.Multiply((0.5, 1.5), per_channel=0.5),
iaa.AverageBlur(k=((5, 11), (1, 3))),
iaa.WithColorspace(to_colorspace="HSV",from_colorspace="RGB",children=iaa.WithChannels(0,iaa.Add((0, 50)))),
iaa.AddToHueAndSaturation((-50, 50), per_channel=True)
The errors  :
Traceback (most recent call last):
  File "e:/EPHEC/Bac_3/Q2/TFE/experiencor/dataAugmentation/echantillon/reddit_file.py", line 248, in <module>
    augmented_images_df = image_aug(labels_df, 'train_image_folder/', 'aug_images/', 'aug2_', aug)
  File "e:/EPHEC/Bac_3/Q2/TFE/experiencor/dataAugmentation/echantillon/reddit_file.py", line 110, in image_aug
    bbs_aug = bbs_aug.remove_out_of_image()
  File "C:\Users\Antoine\Anaconda3\envs\augmentData\lib\site-packages\imgaug\augmentables\bbs.py", line 1026, in remove_out_of_image
    bbs_clean = [bb for bb in self.bounding_boxes
  File "C:\Users\Antoine\Anaconda3\envs\augmentData\lib\site-packages\imgaug\augmentables\bbs.py", line 1027, in <listcomp>
    if not bb.is_out_of_image(self.shape, fully=fully, partly=partly)]
  File "C:\Users\Antoine\Anaconda3\envs\augmentData\lib\site-packages\imgaug\augmentables\bbs.py", line 420, in is_out_of_image
    if self.is_fully_within_image(image):
  File "C:\Users\Antoine\Anaconda3\envs\augmentData\lib\site-packages\imgaug\augmentables\bbs.py", line 370, in is_fully_within_image
    return self.x1 >= 0 and self.x2 < width and self.y1 >= 0 and self.y2 < height
TypeError: unorderable types: str() >= int()

or
Traceback (most recent call last):
  File "e:/EPHEC/Bac_3/Q2/TFE/experiencor/dataAugmentation/echantillon/reddit_file.py", line 236, in <module>
    augmented_images_df = image_aug(labels_df, 'train_image_folder/', 'aug_images/', 'aug2_', aug)
  File "e:/EPHEC/Bac_3/Q2/TFE/experiencor/dataAugmentation/echantillon/reddit_file.py", line 107, in image_aug
    image_aug, bbs_aug = augmentor(image=image, bounding_boxes=bbs)
  File "C:\Users\Antoine\Anaconda3\envs\augmentData\lib\site-packages\imgaug\augmenters\meta.py", line 1888, in __call__
    return self.augment(*args, **kwargs)
  File "C:\Users\Antoine\Anaconda3\envs\augmentData\lib\site-packages\imgaug\augmenters\meta.py", line 1859, in augment
    batch_aug = self.augment_batch(batch, hooks=hooks)
    attr, hooks=hooks)
  File "C:\Users\Antoine\Anaconda3\envs\augmentData\lib\site-packages\imgaug\augmenters\meta.py", line 1066, in augment_bounding_boxes
    kps_ois_aug = self.augment_keypoints(kps_ois, hooks=hooks)
  File "C:\Users\Antoine\Anaconda3\envs\augmentData\lib\site-packages\imgaug\augmenters\meta.py", line 951, in augment_keypoints
    hooks=hooks
  File "C:\Users\Antoine\Anaconda3\envs\augmentData\lib\site-packages\imgaug\augmenters\meta.py", line 3157, in _augment_keypoints
    parents, hooks, _augfunc)
  File "C:\Users\Antoine\Anaconda3\envs\augmentData\lib\site-packages\imgaug\augmenters\meta.py", line 3195, in _augment_non_images
    hooks
  File "C:\Users\Antoine\Anaconda3\envs\augmentData\lib\site-packages\imgaug\augmenters\meta.py", line 3155, in _augfunc
    return augmenter_.augment_keypoints(koi_to_aug_, parents_, hooks_)
  File "C:\Users\Antoine\Anaconda3\envs\augmentData\lib\site-packages\imgaug\augmenters\meta.py", line 951, in augment_keypoints
    hooks=hooks
  File "C:\Users\Antoine\Anaconda3\envs\augmentData\lib\site-packages\imgaug\augmenters\flip.py", line 120, in _augment_keypoints
    keypoint.x = (width - 1) - keypoint.x
TypeError: unsupported operand type(s) for -: 'int' and 'str'

Thanks in advance for the help !

I'm using the 0.2.9 version (don't know why neither anaconda or pip don't upgrade the package to the 0.4.0 version)

Try adding --upgrade to pip or an explicit uninstall first, like pip uninstall -y imgaug; pip install imgaug. If it reports that the library was successfully installed and then when you run python it is still an old version, there are multiple python environments on your system and pip is installing to a different one than what you are actually using.
Regarding the problem, judging from the stacktrace it doesn't look like the error actually originates from the augmentation step, but from
File "e:/EPHEC/Bac_3/Q2/TFE/experiencor/dataAugmentation/echantillon/reddit_file.py", line 110, in image_aug
bbs_aug = bbs_aug.remove_out_of_image()

The error is due to a bounding box coordinate being expected to be float or int, but it actually is a string. I.e. at some point you probably create a bounding box with something like BoundingBox(x1, y1, x2, y2) and one of x1, y1, x2 or y2 is a string. My guess would be that you read these values from a file and forgot to parse them via int(value) or float(value). Or you accidentally provide a (class) label instead of one of these coordinates.


Follow thumbnails to original image

Hi there, reading issue https://github.com/eight04/image-picka/issues/9 there seems to be a very manual way of receiving images in other sizes derived via urls. I have no idea how to access this feature, by the way.
However, I came up with the idea to have a button that replaces (or adds) images to the overview that are linked from images on the site. It is likely an image that links to an image will be the same, but full size version of this image.
I imagine to have a button in the selection overview to access this feature. The user can then decide to replace images with linked images or add the linked images. Even tough I doubt that the latter will be used a lot.
Thanks

I derived the idea from my own use-case: I often use this plugin to download images from galeries. For those I can be certain that every image I click leads to the original. So whatever creative solutions pop up on your side, it would be handy for me to just follow all "image-links" on request. The "add" (instead of replace) option targets users who need embedded and linked images.

For example, your avatar is a link which leads to your profile. In order to know whether the link target is an image, the extension has to load the URL and check the file type, causing extra network traffic.
BTW, are you talking about batch download or downloading a single image?

the extension has to load the URL and check the file type, causing extra network traffic.
For sure. I guess if it is on the user's request it is fine, tough.

I talk about batch-downloading.


make elasticsearch example run out of the box

Description

Change parameters to luigi.run in elasticsearch indexing example.
Motivation and Context

The --task parameter seems obsolete now.

error: unrecognized arguments: --task

Also, I tested the example with the latest elasticsearch release 5.0.0 - it works.
Have you tested this? If so, how?

Tested locally:
$ brew install elasticsearch
$ elasticsearch --daemonize
$ python examples/elasticsearch_index.py
...
This progress looks :)

Actually. I would rather see the whole code block removed, and replaced with something like this


Adding MakefileWorker to the build

Coverage remained the same at 99.833% when pulling b359a5f0d1f2fb14e4b9490e5711ea542a73aca8 on basvodde:master into 3c208486536b359a8120c336ce1c49b606a35f68 on cpputest:master.


Merge request: SEO friendly bootstrap-select  tag

I would like to contribute to this awesome plugin.
Are you interested in a new feature for SEO friendly anchor tags?
Someone else wanted the same feature as myself, more info here:
https://github.com/snapappointments/bootstrap-select/issues/1146
Proposal:
If you set:
.selectpicker({
     addValueOfOptionElementToAnchorHref: true, //  (maybe you have a better name for this option?)

This code gets generated:

                                                            ...

Now google etc. can crawl the link easily.
Let me know what you think, I will be happy to contribute if you are interested!

Any updates on this topic? @caseyjhol


SAE Creative Media Institute

Website

https://www.sae.edu/grc/ (SAE Athens)
https://www.sae.edu/gbr/ (SAE UK)

SAE’s 2-year Audio Production degree
https://www.sae.edu/gbr/courses/ba-bsc-hons-audio-production/

@nbilalis Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


refactor(datagrid): move row controls into sticky container

This moves the datagrid row controls into the stick container and prepares for pinned columns (frontside). Styles were adjusted to handle the column separaters and flex the sticky and scrollable elements in the header as a row instead of a column.
RELATED CHANGES:
The pokemon generator was modified to produce consistent items from the three arrays that are used to generate data so that visual regression tests could be turned on and utilized for visual regression testing of the datagrid use cases. This commit will generate reference images for the baseline.
Signed-off-by: Matt Hippely<EMAIL_ADDRESS>PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Datagrid row control buttons scroll on the x-axis when there is overflow.
Issue Number: N/A
What is the new behavior?
Datagrid row control buttons do not scroll in the x-axis but do scroll in the y-axis when content overflows.
Does this PR introduce a breaking change?

[x] Yes (Visually this breaks the display consumers are expecting)
[ ] No

Other information

I am looking for 'scroll under sticky container with no border' and don't see it. In the demo the rows expand and the entire data grid container grows without scroll bars. The rows themselves simply expand / minimize.

@colinreedmiller - to turn on the horizontal scrolling behavior you need to resize several of the column widths so that column content overflows horizontally.
Once this happens the content will scroll horizontally. Also, if you are viewing on a mac check your system/OS settings and make sure that General/Show scroll bars is set to always, that way you can be sure that scrolling behavior is applied.
I think the question here is does the content inside the sticky containers need a right border or even more some sort of shadow blur to delineate between content that can scroll horizontally and content that stays in view. In this change for the header I made it so that the spacers will always have the column separator to keep it consistent with how the various header spacers looked.
If you need to lets pair on this so we can decide whats best for this PR.

Addition of small vertical stroke on the right side of the sticky container solves the visual design concern. Preview validates - PR approved.

Addition of small vertical stroke on the right side of the sticky container solves the visual design concern. Preview validates - PR approved.


[Packaging][Release][Python] The Windows wheel verification is failing due to missing PARQUET_TEST_DATA env variable

Describe the bug, including details regarding any error messages, version, and platform.
The Windows wheel binary verification is currently failing due to missing PARQUET_TEST_DATA:
     @pytest.fixture(scope='module')
    def parquet_test_datadir():
        if sys.platform == 'emscripten':
            pytest.skip("needs PARQUET_TEST_DATA files access")
        result = os.environ.get('PARQUET_TEST_DATA')
        if not result:
>           raise RuntimeError('Please point the PARQUET_TEST_DATA environment '
                               'variable to the test data directory')
E           RuntimeError: Please point the PARQUET_TEST_DATA environment variable to the test data directory

C:\tmp\arrow-verify-release-wheels\_verify-wheel-3.9\Lib\site-packages\pyarrow\tests\parquet\conftest.py:38: RuntimeError
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> entering PDB >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>

>>>>>>>>>>>>>>>>>> PDB post_mortem (IO-capturing turned off) >>>>>>>>>>>>>>>>>>
> c:\tmp\arrow-verify-release-wheels\_verify-wheel-3.9\lib\site-packages\pyarrow\tests\parquet\conftest.py(38)parquet_test_datadir()
-> raise RuntimeError('Please point the PARQUET_TEST_DATA environment '
(Pdb)

Component(s)
Packaging, Python, Release

Issue resolved by pull request 44462
https://github.com/apache/arrow/pull/44462


Move file reader

The file_reader in the api directory causes all sorts of problems with reusing it for tests and circular dependencies.

/lgtm
/approve


Feature: remove Node.commented_files

Purpose
The commented_files field is used to easily calculate the total unread file comments, but updating the field causes the Node to lock. Since the total unread file comments are not being displayed anywhere, this code can be removed for now.
Changes

Remove all usages of Node.commented_files
Simplify Comment.find_n_unread
Address code review comments from #5059, mainly minor refactoring

Good to merge when the build passes.


Update installation of HNPWA-vanilla documentation

Hi Cristian, I just try update installation of HNPWA-vanilla documentation. You can try in local. If it runs well, please let me know. Thanks a lot.

Hey @satyakresna,
Thank you! 😄 This clears up the confusing parts of running it locally, for sure. I need to check something first, because I think you can do it via firebase-cli and don't need to have the python installed.
I'll get back to you.
Thanks again!

You're welcome Cristian. Nice to help the author and me how it works.
On Feb 12, 2018 2:46 PM, "Cristian Bote"<EMAIL_ADDRESS>wrote:

Hey @satyakresna https://github.com/satyakresna,
Thank you! 😄 This clears up the confusing parts of running it locally,
for sure. I need to check something first, because I think you can do it
via firebase-cli and don't need to have the python installed.
I'll get back to you.
Thanks again!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cristianbote/hnpwa-vanilla/pull/11#issuecomment-364839779,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKlcMvBgKOxk25sRTtLIKTfVZOpcYryzks5tT95BgaJpZM4SA1x2
.

Hey @satyakresna, I just did a commit and added the npm run serve command. Would you be willing to update the wording on it? I'm gonna add some comments.

Hi @cristianbote , just finished based on your request. Done, feel free to check. Thanks a lot.


Improve loading indicator

When waiting for a response from the OpenAI API, there's currently a cheesy sparkly effect from react-sparkle over the whole page.
It would be great to simplify this, remove that dependency (in pursuit of #1), and keep the indicator within the context of the current editor. I couldn't figure out how to get a handle on the Draftail instance that we're currently working inside, but I'm sure it's possible.

There's a slightly better loading indicator in 1.1.0. More to be done!


Modifier keys are not properly propagated to application hosted in Windows Terminal

Environment
Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 0.8.10091.0
Far Manager <IP_ADDRESS>11 x64 [Official page](https://www.farmanager.com/)

Steps to reproduce

Install Windows Terminal
Install Far Manager
Add Far manager as one of Windows Terminal profiles
Start Far manager profile
Memorize the bottom function key row of Far Manager.

Press and hold Alt key on a keyboard

Expected behavior
Bottom function key row is changed

This can be observed on a same system by running Far from separate CMD or Powershell session (not within Windows Terminal)
Actual behavior
Bottom function key row is not changed.

win32-input-mode support also added to the Linux Far Manager port: https://github.com/elfmz/far2l/pull/1581

win32-input-mode support also added to the Linux Far Manager port: https://github.com/elfmz/far2l/pull/1581


Sbarry Config Files changes

Fixing display errors (duplicate text) for join-pages
nrel-commute.nrel-op.json

There was a redundant NREL here, which would make the title of the join-page read: National Renewable Energy Laboratory (NREL) NREL commuting study

wyoming.nrel-op.json

Removed the redundant part of the title which caused it to read: Yellowstone-Teton Clean Cities Yellowstone-Teton Clean Cities E-Bike Commuter Program
Also changed the spanish translation for the same reason

Added Research Questions for all config files
For all config files, I looked at their MOU's and input the research questions from the MOU's

Wyoming
Denver CASR
Massachusets
Durham (DID NOT HAVE research questions text, so I took the research questions from the current CMS join page)
Open access (no MOU, took from the current CMS join page)
Commute Study (no MOU, took from the current CMS join page)
Stage Program (no MOU, took from the current CMS join page)
Stage study (no MOU, took from the current CMS join page)
dev program (no MOU, took from the current CMS join page)
dev study (no MOU, took from the current CMS join page)


Create a Software Qualification Testing for Release new versions

Currently we don't have any kind of Qualification Testing to confirm that a regression wasn't included in our code base.
A good starting point is the "ostest" (at apps/testing/ostest) and the SIM CI test, but these tools alone are not enough to detect regressions.
We need some test to exercise many NuttX features and drivers. The recent email in the mailing list about the Rotating Log not working as expected is an example of basic test that we are failing to execute.
Please share ideas how to cold create some automated tests to help to exercise more NuttX features and drivers as possible.

It is not automated, but last time I cut a release I created this which uncovered some issues that we then resolved in further release candidates.
https://docs.google.com/spreadsheets/d/1qMQV_CSN5Ka13_wr73QNo2Uh-NiSumjcwINuc0BkyIs/edit?usp=sharing

Hi @btashton very nice! I think we could create a listing of features to test for each peripheral to guarantee the driver is working. Recently I discovered that SSD1306 wasn't working on ESP32 because the I2C driver doesn't support NOSTOP feature. My idea is something like this:
Qualification Test

GPIO

Check if GPIO pins can work as Output, Input
Check if GPIO Input can generate interrupts
Check if GPIO can work in Open Drain mode

UART

Check if the NSH console can start on selected UART (case MCU has 2 or more UARTs, test on others too)
Check if UART can exchange data with other boards/devices, to exercise higher throughput, different baudrates and parity modes, etc
Check if RS485 (Modbus) works on that UART ports

I2C

Check if I2C can send a byte (to some I2C DAC that receives only a byte by time)
Check if I2C can send block of bytes (to some I2C Display like SSD1306)
Check if I2C can receive a byte per transaction (some sensor)
Check if I2C can receive a block of bytes
...

It is not easy to automate these tests, maybe a FPGA board that use some standard connector pinout (i.e. like Raspberry Pi pinout) should be necessary to do it.

So, this is a check list for manual testing?

The initial idea is to start testing manually and then we need to create some automatic testing solution for it.

The simple automation is added by @yamt : https://github.com/apache/nuttx/pull/5382
@ttnie add more test: https://github.com/apache/nuttx/pull/7109 and https://github.com/apache/nuttx/pull/7743

Thank you @xiaoxiang781216 !!!
Do you have a listing with procedures to test when certificating a new chip on your company? Maybe we could use it as base to create this automated tests. I think using some wiki page to let more people bring tests suggestions will be very good.

Some thoughts on enhancing testing of NuttX:
Expect
When we want to test the external interfaces of the system (e.g. console, protocols etc), we are making heavy use of expect scripts:
https://linux.die.net/man/1/expect
https://likegeeks.com/expect-command/
We are running the application in the sim and we have the script to interact with the system through NSH. Practically any manual interaction can be scripted this way, easily.
We have our CI to run these scripts, ensuring that at least the basic functionality of the system and its interfaces are OK.
Another way that we are using it, is by testing protocols.
We have sim to use one virtual serial port, and we have expect to interact with the system through this port,
exercising all system commands.
I am planning to use expect also on lower-level tests, like device drivers.
I am thinking of having it sending dummy data to mocked devices, and evaluate the system's behavior.
All in all, I believe that at least all (most?) NSH commands, and NSH-triggered functionality can be easily
tested with expect.
I can provide more information on how test the system with expect, but unfortunately I cannot share my existing scripts verbatim, as they refer to proprietary projects.
Code Coverage
Code coverage data can be a useful metric to evaluate the coverage of the tests.
NuttX in sim supports gcov, and we are already using it in all our CI tests.
The simulator starts and executes its tests.
Either using expect, or by any other means of input, or by using purpose-build applications (like os-test).
Upon finishing the coverage data are created automatically.
At the end of the CI pipeline, lcov is used to merge all reports into a single one.
This single report provides the overall metrics of the tests.
I believe that it would be nice to have this on NuttX.
Especially since it requires practically 0 effort (everything is already there, enabled with Kconfigs).
At least it would be an indication on what is tested or what may need improvement.
We may even add a "rule" that each release must at least increase the coverage of the tests (even marginally).
_ I can provide my lcov scripts that combine the result of the various individual tests and generate the reports._
Tests Output
One of the greatest issues with testing NuttX in an automated way is that the output of the tests
(os-test, mm-test, fs-test etc), is inconsistent.
Every test has its own output format.
If I recall correctly, one test uses the word "error" for a non-erroneous state (i.g. expected error).
Parsing of the output is very hard, adding tests can be tedious.
It happened to me at least once to have the test fail, but my CI script fail to recognize the issue.
Standardization of the output for all tests will be greatly beneficial.
Note that all sim tests are currently broken for us, due to a regression. Something have been changed recently, the outputs differ and all tests fail. I am still investigating.
Networking
The most neglected part of NuttX (at least IMO) is networking.
There is no automated testing I can do there.
And as it seems, it is quite a problematic part of NuttX.
Its a few months that I struggle with networking, and still it is totally unstable for me.
I also see various regressions occasionally, for example the latest master hardfaults immediately when I try to use sendfile.
Unfortunately, I never managed to have the networking run on the simulator (let alone within CI).
So no tests can be written for this for the moment.
I believe that this is the part of NuttX that requires the most attention, testing-wise.
Even basic HTTP, ftpc, ftpd etc communications would be a good indication that the system is still functioning properly.


Update Composer dependencies (2021-08-08-00-05)

Visual regression test passed!
View the visual regression test report


Support GitHub Actions Deployment for EKS

New version to support GitHub Actions Deployment using official Terraform GitHub Action Published on Marketplace and simplify EKS deployment using GitHub Workflows.

Hi @oaviles, thank you so much for submitting this PR. Two things to note:

We (just today) finished completely refactoring the EKS scenario, so we need to explore how that changes this submission.
Because of how you originally created the files under a different name (in your repo), and then renamed them to match the TF files in this scenario, the actual diff's of what changed are not properly reflected, so when you look at the "Files Changed" tab, it essentially things all of the files were completely removed and replaced.

Would you mind taking a second look now that this scenario has been refactored and see how we can re-commit the PR to reflect only the changes that were added/subtracted?
Happy to reach out and chat 1:1 if any additional clarity is required here.

@oaviles, we'd like to get this merged into the June sprint, but I just noticed that your README.md completely overwrites the README.md in the azure_arc root. Can move the README materials into the documentation for this scenario please? Please let me know if you need any guidance or assistance.

The documentation for the scenario can be found here:
https://github.com/microsoft/azure_arc/blob/main/docs/azure_arc_jumpstart/azure_arc_k8s/eks/eks_terraform/_index.md


crack-attack: enable sound support in the crack-attack game.

Motivation for this change
The crack-attack game can have sound if the user-supplied sound files are present in its configuration folder. However, this needs the --enable-sound configure option to be enabled. Note that the option on its own does not activate the sounds, the files must be added to the configuration folder (see the commit message for more info).

The --enable-sound ./configure option enables the sound support in crack-attack.
This commit enables the --enable-sound option, and adds a dependency on SDL_mixer.
The following files still have to be supplied by the user, due to licencing issues upstream:
~/.crack-attack/music/game.ogg
~/.crack-attack/music/gameover.ogg
~/.crack-attack/music/prelude.ogg
~/.crack-attack/music/youwin.ogg
~/.crack-attack/sounds/block_awaking.wav
~/.crack-attack/sounds/block_dying.wav
~/.crack-attack/sounds/block_fallen.wav
~/.crack-attack/sounds/countdown.wav
~/.crack-attack/sounds/garbage_fallen.wav
~/.crack-attack/sounds/garbage_shattering.wav
The crack-attack game will detect when these sound files are present, and use them as background music and sound effects.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

The build fails with

/nix/store/[...]-SDL_mixer-1.2.12/include/SDL/SDL_mixer.h:27:23: fatal error: SDL_types.h: No such file or directory

Please consider enabling sandboxing to help eliminate implicit dependencies.

@joachifm I tried building it with nix-env -f $NIXPKGS --option nix.useSandbox true -iA crack_attack, and it build fine here (is that command okay? I couldn't find where to enable the useSandbox otherwise, /etc/nixos/configuration.nix complains that there is no such option if I add it there). Also, that file (SDL_types.h) is provided by the SDL package, which is already part of the build inputs for crack-attack. Any idea about what's happening here?

@jsmaniac if you're using nix-daemon, you can't control sandboxing that way (in a multi-user environment, some of the point of sandboxing would be lost if users could control it). Sandboxing is configured in nix.conf (via nix.useSandbox or nix.useChroot if you're on an older NixOS.
One thing you could try something like NIX_CFLAGS_COMPILE = "-I${SDL.dev}/include" (or wherever the supposedly missing file resides); it's kind of ugly, but at least then you can ensure it'll be in the include path. Then again, adding SDL to inputs ought to be sufficient, if the headers are in a standard location ...

@joachifm Thanks for the help. I had omitted the nix. prefix when adding useSandbox to my /etc/nixos/configure.nix. I still can't reproduce the error, and noticed that on the Travis build, the following flags are omitted (but they are used when I build locally). I don't know why this happens, it's as if nix ignores some of the buildInputs.
-I/nix/store/3r7hrfi9ywgbx7wpv1kpjy8w2855p7ak-SDL-1.2.15-dev/include/SDL -I/nix/store/3r7hrfi9ywgbx7wpv1kpjy8w2855p7ak-SDL-1.2.15-dev/include/SDL -I/nix/store/lr4p15vdd35ixb3i1x1f25pf4k9aq75n-SDL_mixer-1.2.12/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT

Several other games use the hack you mentioned, so I added this to crack-attack's default.nix too, this should hopefully be enough.
NIX_CFLAGS_COMPILE = "-I${SDL.dev}/include/SDL";


document 'since' pagination for Users.ListAll

Fixes #278.
Change-Id: Ia1d0c1f6b395d493714d91e0f6e79dc2506f8fde

The actual content in this PR looks good to me, I don't see any issues. LGTM.
I do have 2 style comments that I'll leave inline for your discretion. The first one (writing gofmted Go code, even if it's inside a comment) is highly recommended. The second one is completely optional and up to you.


Update meta.yaml

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

requirements: run: openff-units >= 0.1.6 should not contain a space between relational operator and the version, i.e. openff-units >=0.1.6

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender


Updates NLU.DevOps.ModelPerformance to pass through utterance JSON

Previously, NLU.DevOps.ModelPerformance parsed utterance JSON into a LabeledUtterance model, which loses any additional context (e.g., the "score" property from LUIS). This change ensures that the utterance JSON is passed through to the test case as is, so when serialized, it includes extra properties not in the LabeledUtterance model. The result is that we can pass through the LUIS score to the metadata output in the compare command.

I think this falls short of being useful. We'll need to bubble up the score to the top-level in the test result.


refactor(kube): execStream requires a context.Context

Change Overview
Passing context to execStream so that execution could be terminated due to context cancellation.
Pull request type
Please check the type of change your PR introduces:

[ ] :construction: Work in Progress
[x] :rainbow: Refactoring (no functional changes, no api changes)
[x] :hamster: Trivial/Minor
[ ] :bug: Bugfix
[ ] :sunflower: Feature
[ ] :world_map: Documentation
[ ] :robot: Test

Issues

fixes #2172

Test Plan

[ ] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

Putting WIP because I'd like to write some unit test which will verify that context cancellation has an effect.

Unit test has been added.


Synthesis failed for google-p12-pem

Hello! Autosynth couldn't regenerate google-p12-pem. :broken_heart:
Here's the output from running synth.py:
2020-05-15 10:26:57,589 autosynth [INFO] > logs will be written to: /usr/local/google/home/rennie/gitrepos/synthtool/logs/googleapis/google-p12-pem
2020-05-15 10:26:58,591 autosynth [DEBUG] > Running: git config --global core.excludesfile /usr/local/google/home/rennie/.autosynth-gitignore
2020-05-15 10:26:58,595 autosynth [DEBUG] > Running: git config user.name Jeffrey Rennie
2020-05-15 10:26:58,601 autosynth [DEBUG] > Running: git config user.email<EMAIL_ADDRESS>2020-05-15 10:26:58,606 autosynth [DEBUG] > Running: git config push.default simple
2020-05-15 10:26:58,612 autosynth [DEBUG] > Running: git branch -f autosynth
2020-05-15 10:26:58,619 autosynth [DEBUG] > Running: git checkout autosynth
Switched to branch 'autosynth'
2020-05-15 10:26:59,036 autosynth [DEBUG] > Running: git rev-parse --show-toplevel
2020-05-15 10:26:59,045 autosynth [DEBUG] > Running: git log -1 --pretty=%H
2020-05-15 10:26:59,053 autosynth [DEBUG] > Running: git remote get-url origin
2020-05-15 10:26:59,515 autosynth [DEBUG] > Running: git log be74d3e532faa47eb59f1a0eaebde0860d1d8ab4..HEAD --pretty=%H --no-decorate
2020-05-15 10:26:59,523 autosynth [DEBUG] > Running: git log -1 --pretty=%at be74d3e532faa47eb59f1a0eaebde0860d1d8ab4
2020-05-15 10:26:59,531 autosynth [DEBUG] > Running: git log -1 --pretty=%at<PHONE_NUMBER>c0c7ada19e6a8219d7963ff174b392
2020-05-15 10:26:59,537 autosynth [DEBUG] > Running: git log -1 --pretty=%at 5bbfd095faedfe273819d266f21e402192a29041
2020-05-15 10:26:59,545 autosynth [DEBUG] > Running: git log -1 --pretty=%at 4fa923bd3dafb91df8613accbe2230299cc5b98e
2020-05-15 10:26:59,553 autosynth [DEBUG] > Running: git log -1 --pretty=%at 55cdc844877d97139f25004229842624a6a86a02
2020-05-15 10:26:59,561 autosynth [DEBUG] > Running: git log -1 --pretty=%at 98c50772ec23295c64cf0d2ddf199ea52961fd4c
2020-05-15 10:26:59,569 autosynth [DEBUG] > Running: git log -1 --pretty=%at ba909fca409f6b38eae0fa735614e127d1fc0deb
2020-05-15 10:26:59,575 autosynth [DEBUG] > Running: git log -1 --pretty=%at 7482e79a82e353248769d819788adc1213e8c207
2020-05-15 10:26:59,581 autosynth [DEBUG] > Running: git log -1 --pretty=%at a7759f81c25396207d46532ed389ad4d34879857
2020-05-15 10:26:59,586 autosynth [DEBUG] > Running: git log -1 --pretty=%at 5b48b0716a36ca069db3038da7e205c87a22ed19
2020-05-15 10:26:59,592 autosynth [DEBUG] > Running: git log -1 --pretty=%at c585ac3b5eff5cd2097a5315ffd9cf4823cc1ed2
2020-05-15 10:26:59,599 autosynth [DEBUG] > Running: git log -1 --pretty=%at b0461724be19443075b08c10d4a345cb217002b5
2020-05-15 10:26:59,606 autosynth [DEBUG] > Running: git log -1 --pretty=%at 84c4156c49be9dcabacc8fd7b0585b6fd789ae47
2020-05-15 10:26:59,613 autosynth [DEBUG] > Running: git log -1 --pretty=%at f503622985e230a6792730bbc3b7746c11fce09e
2020-05-15 10:26:59,620 autosynth [DEBUG] > Running: git log -1 --pretty=%at 3d2a7d0e21387ed455c966da9f9897b0a4bc5bb8
2020-05-15 10:26:59,627 autosynth [DEBUG] > Running: git log -1 --pretty=%at 7b7f386b393947a542b87707499f4458136f4f61
2020-05-15 10:26:59,634 autosynth [DEBUG] > Running: git log -1 --pretty=%at f395615039665af6599f69305efcd886685e74f9
2020-05-15 10:26:59,640 autosynth [DEBUG] > Running: git log -1 --pretty=%at b6bdd4783f396f9252ce28af43f7215834a55c3c
2020-05-15 10:26:59,646 autosynth [DEBUG] > Running: git log -1 --pretty=%at 3593e3a995510c0570648d9a48fc756ab2bfc2cb
2020-05-15 10:26:59,654 autosynth [DEBUG] > Running: git log -1 --pretty=%at cb3433f7f554ea751584bdd3631d45ec56a32eb5
2020-05-15 10:26:59,663 autosynth [DEBUG] > Running: git checkout b5eb4cb9a324669e839a8659854f0713933aab3d
Note: switching to 'b5eb4cb9a324669e839a8659854f0713933aab3d'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at b5eb4cb chore(deps): update dependency js-green-licenses to v2 (#261)
2020-05-15 10:26:59,674 autosynth [DEBUG] > Running: git checkout cb3433f7f554ea751584bdd3631d45ec56a32eb5
Note: switching to 'cb3433f7f554ea751584bdd3631d45ec56a32eb5'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at cb3433f fix: uses http for links to internal logs (#556)
2020-05-15 10:26:59,686 autosynth [DEBUG] > Running: git branch -f autosynth-20
2020-05-15 10:26:59,692 autosynth [DEBUG] > Running: git checkout autosynth-20
Switched to branch 'autosynth-20'
2020-05-15 10:26:59,702 autosynth [INFO] > Running synthtool
2020-05-15 10:26:59,702 autosynth [INFO] > ['/usr/local/google/home/rennie/env3.6/bin/python', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']
2020-05-15 10:26:59,705 autosynth [DEBUG] > Running: /usr/local/google/home/rennie/env3.6/bin/python -m synthtool --metadata synth.metadata synth.py --
/usr/local/google/home/rennie/env3.6/bin/python: No module named synthtool
2020-05-15 10:26:59,737 autosynth [ERROR] > Synthesis failed
2020-05-15 10:26:59,737 autosynth [DEBUG] > Running: git reset --hard HEAD
HEAD is now at b5eb4cb chore(deps): update dependency js-green-licenses to v2 (#261)
2020-05-15 10:26:59,744 autosynth [DEBUG] > Running: git checkout autosynth
Switched to branch 'autosynth'
2020-05-15 10:26:59,752 autosynth [DEBUG] > Running: git clean -fdx
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/local/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/local/google/home/rennie/gitrepos/synthtool/autosynth/synth.py", line 612, in <module>
    main()
  File "/usr/local/google/home/rennie/gitrepos/synthtool/autosynth/synth.py", line 473, in main
    return _inner_main(temp_dir)
  File "/usr/local/google/home/rennie/gitrepos/synthtool/autosynth/synth.py", line 592, in _inner_main
    commit_count = synthesize_loop(x, multiple_prs, change_pusher, synthesizer)
  File "/usr/local/google/home/rennie/gitrepos/synthtool/autosynth/synth.py", line 368, in synthesize_loop
    synthesize_inner_loop(toolbox, synthesizer)
  File "/usr/local/google/home/rennie/gitrepos/synthtool/autosynth/synth.py", line 378, in synthesize_inner_loop
    synthesizer, len(toolbox.versions) - 1
  File "/usr/local/google/home/rennie/gitrepos/synthtool/autosynth/synth.py", line 266, in synthesize_version_in_new_branch
    synthesizer.synthesize(synth_log_path, self.environ)
  File "/usr/local/google/home/rennie/gitrepos/synthtool/autosynth/synthesizer.py", line 119, in synthesize
    synth_proc.check_returncode()  # Raise an exception.
  File "/usr/local/lib/python3.6/subprocess.py", line 389, in check_returncode
    self.stderr)
subprocess.CalledProcessError: Command '['/usr/local/google/home/rennie/env3.6/bin/python', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth passed, closing! :green_heart:


testing: use T.Skip to mark a fuzz input as uninteresting

Currently, the fuzzing engine marks an input as "interesting" if it activates coverage counters that were not activated before. Interesting inputs are minimized and added to the cached corpus. New inputs may be derived from them.
Fuzz target authors may not want to spend time fuzzing certain kinds of inputs, for example, because they're unlikely to find bugs or because they're expensive or impractical to test. It would be useful to have some signal that an input is not interesting and should not be added to the cached corpus. T.Skip seems like a reasonable way to do that.
func FuzzSqrt(f *testing.T) {
  f.Add(2.0)
  f.Add(99.9)
  f.Fuzz(func(t *testing.T, v float64) {
    if v < 0 {
      t.Skip()
    }
    s := math.Sqrt(v)
    if math.Abs(s*s - v) >= 0.001 {
      t.Fatal()
    }
  })
}

Compare with go-fuzz, which has a similar feature: the fuzz function may return:

+1 for an interesting input that should be given priority (we have no way to express this yet)
0 normally
-1 for an input that should not be added to the corpus, even if it exposes new coverage (this feature)

Closing as a duplicate of https://github.com/golang/go/issues/48779


feat(extend): implement reverse mapping method

Fixes #8

Codecov Report

Merging #21 (f98f8e7) into dev (ab93151) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines          164       173    +9
  Branches        11        12    +1
=========================================
+ Hits           164       173    +9

Impacted Files
Coverage Δ

src/extend.ts
100.00% <100.00%> (ø)


Misleading line here

https://github.com/NVIDIAGameWorks/NRI/blob/64120b73fff99de567372d43915f6409783f707a/Source/VK/BufferVK.cpp#L26
The left hand side is being compared with a VK_NULL_HANDLE on the right. This works as VK_NULL_HANDLE is defined as nullptr anyway. However, the line is misleading as looking at it without IDE, one would assume that m_Memory is a vulkan resource when it is in fact a NRI struct.

Sorry, I slipped out from my attention. Thanks, it will be fixed soon.

Thanks Robert. Fixed.