Have a trash bin to see deleted notes

Is your feature request related to a problem? Please describe.
Some people would like to see deleted notes
Describe the solution you'd like

i want another button on top of the settings button "Trash".

show the same settings screen, at the top there will be a banner that says "Deleted Notes" and a "Go Back" button which will bring them back to the normal settings screen
so when they click on the deleted note it'll open a dialog which will ask if they want to restore the note, with two buttons "Restore" and "Cancel"
remove bottom bar to add note and stuff

Additional context

at least 2 people asked for this.

Closes by https://github.com/fleetingnotes/fleeting-notes-flutter/pull/841


Update berkshelf dependency

This PR updates the Berkshelf dependency to 5.6.x. This update allows us to deprecate the Berkshelf patch that was being used.
It also adds a -v/--version task to print the current Builderator version.

What are the validation steps we need to do to make sure we are still resolving/pushing cookbooks correctly?

I remember there being an issue with berkshelf 5.x for something, but I don't recall exactly what it was, just that going back to 4.x fixed the glitch.  @cdoughty-r7 mentioned it was a ruby not being supported; is that the case and is it fixed or do we care?

Based on the Changelog it seems like the only big thing is that they deprecated the use of Ruby 2.1.

Moving to 6.x requires an update to Ruby > 2.3.1.


fix bug in job submit form

Coverage decreased (-8.8%) to 71.923% when pulling 7fa3a8b861a8b5a3b2a26bed8f076757ab95734d on zhaonan/json-editor into 03a81b82adb903ed62b874bd5c0c9d8c61711b5e on master.

Coverage decreased (-8.8%) to 71.923% when pulling 7fa3a8b861a8b5a3b2a26bed8f076757ab95734d on zhaonan/json-editor into 03a81b82adb903ed62b874bd5c0c9d8c61711b5e on master.

Coverage decreased (-8.8%) to 71.923% when pulling 7fa3a8b861a8b5a3b2a26bed8f076757ab95734d on zhaonan/json-editor into 03a81b82adb903ed62b874bd5c0c9d8c61711b5e on master.

Coverage decreased (-8.8%) to 71.923% when pulling 7fa3a8b861a8b5a3b2a26bed8f076757ab95734d on zhaonan/json-editor into 03a81b82adb903ed62b874bd5c0c9d8c61711b5e on master.


Stopped working after 88d473a

as per title, the new parser removed ultisnip completion items from cmp list after 88d473a7385c15b64e9e3fbdeefdd7494d5bc825
neovim version v0.6.0-dev+631-g72d62aa6a

Hey, could you confirm if this is still the case with the latest version? Also, I will create a PR in a few minutes that should resolve some issues with snippets not showing up.

Yes, stopped working right after rebuilding latest neovim and updating plugins

Sorry about that, I should have tested the new parser better. This should be fixed once #26 has been merged.

@quangnguyen30192 thank you for the fast merging, @rebelot could you pull the latest update and test again?

Still not working for me, but thanks for your super quick response!

any update? I'll share my minimal config
use({
    "SirVer/ultisnips",
    requires = {"honza/vim-snippets", rtp = "."},
    config = function()
	vim.g.UltiSnipsExpandTrigger = "<Plug>(ultisnips_expand)"
	vim.g.UltiSnipsJumpForwardTrigger = "<Plug>(ultisnips_jump_forward)"
	vim.g.UltiSnipsJumpBackwardTrigger = "<Plug>(ultisnips_jump_backward)"
	vim.g.UltiSnipsListSnippets = "<c-x><c-s>"
	vim.g.UltiSnipsRemoveSelectModeMappings = 0
    end,
})

use({
    "hrsh7th/nvim-cmp",
    requires = {"quangnguyen30192/cmp-nvim-ultisnips"},
    config = function()
        local cmp = require('cmp')
            cmp.setup {
                snippet = {
                    expand = function(args) vim.fn["UltiSnips#Anon"](args.body) end
                },
                mapping = {
                    ['<C-Space>'] = cmp.mapping(cmp.mapping.complete(), {'i', 'c'}),
                    ['<CR>'] = cmp.mapping.confirm({ behavior = cmp.ConfirmBehavior.Replace, select = false }),
                },
                sources = {{ name = 'ultisnips' }}
            }
    end
})

Hey, I would really like to solve your issue. However, I just tested with your config and it works for me.
This is how it looks like when using your config with vim-snippets in a Java file and hitting <C-space>:

Can you tell me the output of the following command?
:call UltiSnips#SnippetsInCurrentScope(1) | lua print(vim.inspect(vim.g.current_ulti_dict_info))

this is the output of the command for a lua file (trying to complete date global snippet)

{
  ["#!"] = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/lua.snippets:1"
  },
  AGPL = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:265"
  },
  AGPL3 = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:86"
  },
  APACHE = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:219"
  },
  BEERWARE = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:235"
  },
  BSD2 = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:112"
  },
  BSD3 = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:140"
  },
  BSD4 = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:167"
  },
  GMGPL = {
    description = "linking exception",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:103"
  },
  GPL2 = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:18"
  },
  GPL3 = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:52"
  },
  ISC = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:281"
  },
  LGPL2 = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:35"
  },
  LGPL3 = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:69"
  },
  MIT = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:197"
  },
  MPL2 = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:260"
  },
  WTFPL = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:244"
  },
  ["c)"] = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:4"
  },
  date = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:6"
  },
  datetime = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:14"
  },
  ddate = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:8"
  },
  diso = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:10"
  },
  elif = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/lua.snippets:32"
  },
  for = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/lua.snippets:10"
  },
  fori = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/lua.snippets:18"
  },
  forp = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/lua.snippets:14"
  },
  fun = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/lua.snippets:6"
  },
  if = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/lua.snippets:22"
  },
  ife = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/lua.snippets:26"
  },
  im = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/lua.snippets:45"
  },
  local = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/lua.snippets:4"
  },
  lorem = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:16"
  },
  print = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/lua.snippets:43"
  },
  repeat = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/lua.snippets:35"
  },
  time = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/_.snippets:12"
  },
  while = {
    description = "",
    location = "/Users/laurenzi/.local/share/nvim/site/pack/packer/start/vim-snippets/snippets/lua.snippets:39"
  }
}

Oh I think I know what's the issue. I was convinced that UltiSnips only supports snippets of the form snippet ... ensnippet as one would guess when reading the helpdocs. As can be seen here https://github.com/SirVer/ultisnips/blob/2c83e40ce66814bf813457bb58ea96184ab9bb81/doc/UltiSnips.txt#L1768, apparently UltiSnips also supports snippets using vsnip syntax. I will update the parser for this, thank you for providing the details! We will let you know once this has been fixed, thanks for your patience.

thank you! but this raises another issue (for me...) why snippets are searched only in vim-snippets/snippets folder and not also in vim-snippets/UltiSnips?

That's actually a really good question, the issues with the rtp just happened to me also. Packer actually has some problems with setting rtp, I will test your solution and probably update the readme once it works.

@quangnguyen30192 I think we should not support vim-snipmate-like snippets at the moment. That would be quite a lot of work and involve a few edge cases. But we should update the readme again for honza/vim-snippets users.

Or maybe fallback to not using the custom parser if a snipmate snippet is found (then we will only have the tab_trigger and description info).

I second this... I find snipmate snippets very useful (like licenses, date, author/program info)

While thinking about it, snipmate snippets only have a tab_trigger and description anyway (at least on the main branch). So there is no need to change the parser, we can simply use the info provided by UltiSnips.

Not all of them are shown on latest (i.e. box (this one is super useful imo), bbox, docs, MIT, ...). I'm reverting and locking for now. Thanks for the support, hope you'll find a way to implement that!

@rebelot I have updated the snippets.lua file and it seems to working now for vsnip snippets :) Will create a PR later and hopefully the issue will be resolved then.

Thanks @smjonas for your effort

@rebelot could you check if the new updates resolve your issue? We completely got rid of the custom parser now :D

Everything seems to works nicely! Thank you very much!  👍


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/OPS-E2E-PPE/docs-archive-test-source

Docs Build status updates of commit 41b7acf:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Release_Archive_master_2020-01-13-02-33-46 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Release_Archive_master_2020-01-13-02-33-46

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Change question about being from underrepresented group to be more inclusive

On the instructor training application there is a question that reads

I self-identify as a member of a group that is under-represented in research and/or computing, e.g., women, ethnic minorities, LGBTQ, etc. followed by a text box to provide details.

This may make people feel like they must provide detailed information about sensitive personal information.
We would like to change this as follows:
Help Text
The Carpentries strives to increase opportunities for underrepresented groups to join our team.
Question
I self-identify as a member of a group that is under-represented in research and/or computing. (yes/no/prefer not to say check box)
Question
If you are comfortable doing so, please share more details. Your response is optional, and these details will not impact your application's ranking.

@maneesha would this work?

@maneesha @karenword @ErinBecker even though this new form allows for automatic scoring of underrepresented field (because it's yes|no|undisclosed), I don't want to alter your workflow too much, so I decided to instead extend API for manual scoring with underrepresented_details field. This way the workflow stays the same, ie. a human being needs to check underrepresented and underrepresented_details fields.

@ErinBecker  @karenword Would we want this to grant +1 automatically if they answer yes, regardless of what they put in the details box?  That's what I was thinking.

Yes. +1 automatically if they click yes.
On Thu, Feb 21, 2019 at 10:08 AM maneesha sane<EMAIL_ADDRESS>wrote:

@ErinBecker https://github.com/ErinBecker @karenword
https://github.com/karenword Would we want this to grant +1
automatically if they answer yes, regardless of what they put in the
details box? That's what I was thinking.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/swcarpentry/amy/issues/1468#issuecomment-466104391,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASSbf35G_t3XGvk6oJxBHBMZE2r24hX9ks5vPuCOgaJpZM4a8cbh
.

--
Erin Becker
Associate Director with The Carpentries https://carpentries.org/
Pronouns: she/her/hers
Schedule a meeting with me: https://calendly.com/ebecker-1
https://calendly.com/ebecker-1
The Carpentries https://carpentries.org/ *- *
We teach foundational coding and data science skills to researchers
worldwide. Twitter http://twitter.com/thecarpentries | Facebook
https://www.facebook.com/carpentries/ | Blog
https://carpentries.org/blog/
The Carpentries is a fiscally sponsored project of Community Initiatives
http://communityin.org/, a registered 501(c)3 non-profit organisation
based in California, USA.
We are a global community teaching foundational computational and data
science skills to researchers in academia, industry and government.

@ErinBecker, @maneesha I'll adjust the code. Thanks!

Actually I do have one more thought, which I will ask here instead of the PR because the screenshot is above. In the "If you are comfortable doing so..." box I think it leaves a question as to why we are asking if we will not use it to score their application. Do we want to add something like "but they will support our efforts to track and document our application demographics" at the end? Or, if that is not the case, maybe we should just remove that box entirely. @maneesha maybe you can comment here?

Oh no, I didn't see that comment from @karenword until after I merged the PR. I'll make a separate PR if @maneesha agrees to @karenword idea.


Proposal: Hardhat and Foundry templates to deploy smart contracts on Kaia

Description

A Foundry and Hardhat boilerplate to deploy smart contracts on Kaia.
Boilerplate will try not to conflict much with the changes in core frameworks. Most of it will be peripheral scripts to aid development.
Include deployment settings, documentation and various dev-ops utilities

Bounty track

Contribute an Open Source Developer Tool

Can I not do Hardhat and go all in with Foundry template? I will include some really good stuffs with existing ecosystem projects?

Please find the template here:
https://github.com/haxxsniper/kaia-foundry-template
I included token implementation, automated developer config, orakl integration and foundry toml file.

looks ok. Need more docs and test though but I will approve this one. Come back with more docs and Pyth integration for me.
Maybe include more stuffs. They don't have to be tied together. You can separate different workflows with makefile
Approved for 500 KLAY payout.

Closing this Issue. Open new issue when you make additional updates.


Set OwnerReference on plugin TLS Secret

What this PR does / why we need it:
We previously modified plugin Pods and DaemonSets to be owned by the
main Sonobuoy pod. When running plugins, we also create a secret for the
TLS certificate used for communication between plugins and the
aggregator pod. This change adds an OwnerReference to this secret so
that it is cleaned up if the main Sonobuoy aggregator pod is deleted.
Signed-off-by: Bridget McErlean<EMAIL_ADDRESS>Special notes for your reviewer:
Aside from unit testing, I tested this manually by checking that the secret exists before deleting the main Sonobuoy pod, and confirming it is deleted after that pod is deleted.
$ kubectl get secrets -n sonobuoy
NAME                                   TYPE                                  DATA   AGE
default-token-r2qd7                    kubernetes.io/service-account-token   3      10s
sonobuoy-plugin-e2e-9d1b7bc465764ac5   kubernetes.io/tls                     2      9s
sonobuoy-serviceaccount-token-59h76    kubernetes.io/service-account-token   3      10s

$ kubectl delete pod sonobuoy -n sonobuoy
pod "sonobuoy" deleted

$ kubectl get secrets -n sonobuoy
NAME                                  TYPE                                  DATA   AGE
default-token-r2qd7                   kubernetes.io/service-account-token   3      111s
sonobuoy-serviceaccount-token-59h76   kubernetes.io/service-account-token   3      111s

Release note:
Sonobuoy now sets the `OwnerReference` on the Secret resource created when running plugins which is used when communicating with the main aggregator pod. This means that if the main aggregator pod is deleted, this Secret will also be deleted.

Codecov Report

Merging #973 into master will increase coverage by 0.16%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
+ Coverage   47.53%   47.69%   +0.16%
==========================================
  Files          76       76
  Lines        5291     5298       +7
==========================================
+ Hits         2515     2527      +12
+ Misses       2620     2617       -3
+ Partials      156      154       -2

Impacted Files
Coverage Δ

pkg/plugin/driver/job/job.go
67.88% <0%> (ø)
:arrow_up:

pkg/plugin/driver/daemonset/daemonset.go
57.69% <0%> (ø)
:arrow_up:

pkg/plugin/driver/base.go
60.94% <100%> (+1.68%)
:arrow_up:

pkg/plugin/aggregation/aggregator.go
75.77% <0%> (+3.1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd942b3...964b990. Read the comment docs.


Infinite recursion problem in Inkscape with SVGs of emoji 🌎 & 🏠

While playing around some with the SVG files of the emoji I noticed that for  🌎 (U+1f30e) and 🏠 (U+1f3e0) Inkscape complains about exceeding some maximum iteration limit ([...] More than 32 iteration while updating document [...]).
The problem seems to be caused by a radialGradient tag inside of a group that references it by id for the fill attribute. There is an open issue about this in the Inkscape repository here. Going by what is mentioned in the issue, the fill referencing the radialGradient is inherited to the radialGradient tag, which causes some kind of self-referential-recursion.
This seems to be an issue which affects only Inkscape, other SVG renderers seem to be able to deal with this.
For 🌎 (U+1f30e) the issue is with gradient #a, for 🏠 (U+1f3e0) it's #d, moving these gradients out of the groups referencing them for their fill fixes the issue and doesn't affect the rendered result.

This seems to be fixed in the latest release.


fatal error: 'google_api_availability/google_api_availability-Swift.h' file not found

🐛 Bug Report

I'm facing this error trying to build my Flutter project for iOS with "flutter build ios" command:
Building com.*******.mobile for device (ios-release)...
Automatically signing iOS for device deployment using specified development team in Xcode project: *********
Running pod install...                                       2.0s
Starting Xcode build...
Xcode build done.                                           24.9s
Failed to build iOS app
Error output from Xcode build:
↳
** BUILD FAILED **
Xcode's output:
↳
/Users/dev/Documents/flutter/.pub-cache/hosted/pub.dartlang.org/google_api_availability-1.0.2/ios/Classes/GoogleApiAvailabilityPlugin.m:2:9: fatal error: 'google_api_availability/google_api_availability-Swift.h' file not found
#import <google_api_availability/google_api_availability-Swift.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
/Users/dev/Documents/flutter/.pub-cache/hosted/pub.dartlang.org/geolocator-2.0.1/ios/Classes/GeolocatorPlugin.m:2:9: fatal error: 'geolocator/geolocator-Swift.h' file not found
#import <geolocator/geolocator-Swift.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Encountered error while building for device.
This is the output of flutter doctor:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v0.7.3, on Mac OS X 10.13.2 17C88, locale en-BG)
[✗] Android toolchain - develop for Android devices
✗ Unable to locate Android SDK.
Install Android Studio from: https://developer.android.com/studio/index.html
On first launch it will assist you in installing the Android SDK components.
(or visit https://flutter.io/setup/#android-setup for detailed instructions).
If Android SDK has been installed to a custom location, set $ANDROID_HOME to that location.
[✓] iOS toolchain - develop for iOS devices (Xcode 9.2)
[✗] Android Studio (not installed)
[!] IntelliJ IDEA Ultimate Edition (version 2017.2.5)
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
[!] Connected devices
! No devices available
This is how my pubspec.yaml file looks like:
name: ****
description: ***
version: 1.0.0+1
environment:
sdk: ">=2.0.0-dev.68.0 <3.0.0"
dependencies:
flutter:
sdk: flutter
intl: 0.15.7
cupertino_icons: ^0.1.2
http: 0.11.3+17
shared_preferences: 0.4.2
google_api_availability: ^1.0.2
geolocator: ^2.0.1
dev_dependencies:
flutter_test:
sdk: flutter
flutter:
uses-material-design: true
The SWIFT_VERSION from Xcode is 4.0. Any help will be very much appreciated.
Version: 1.0.2
Platform:

[x] :iphone: iOS
[ ] :robot: Android

Thanks!


nickel: fix darwin build

Description of changes
Tries to fix the darwin build issue noticed in https://github.com/NixOS/nixpkgs/pull/242686#issuecomment-1631662785.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Not sure why it's still failing. I'm not very familiar with packaging for darwin.
I found libiconv & Security were used in the upstream flake.nix:
https://github.com/tweag/nickel/blob/1.1.1-release/flake.nix#L101-L102
But I can't anything else that would be missing.

Something about pyo.

Let's break this, then?
Or it's best to wait for an official fixup?

Thanks for pointing this problem out. We'll try to fix the build script for Darwin, or we even might separate the python wrapper (which requires this py0, but is not required by Nickel itself in any way) in another repo in the short term, it has just caused a lot of trouble for building already. In the meantime I tend to think @YorikSar's dirty fix is the shortest path to getting something which works again.

It's not the usual libiconv/Security issue, it's something related to py0.

Should we still add those, since these dependencies are used upstream?


Add docs for mounting Mesop app

The FastAPI example seems to be working well:
https://github.com/wwwillchen/mesop-fastapi
However, I'm having trouble with the Flask example: https://github.com/wwwillchen/mesop-flask - when I try to run Mesop in debug mode, it's not loading.
All things considered though, I think encouraging people to use FastAPI is better as it reduces the likelihood of a version dependency conflict with Mesop's internal Flask usage and other people's Flask usage.
Fixes #803.

Nice. This is exciting. It could be good to provide examples of how one could interact with Fast API in your example repo.

I updated the readme to be clearer about this - there's an HTTP interaction w/ web component, let me know if you're thinking of something else.

Also could be good to know what limitations there are at the moment.

good idea, added one around hot reloading.

I updated the readme to be clearer about this - there's an HTTP interaction w/ web component, let me know if you're thinking of something else.

Ah, yeah I totally missed that (didn't end up looking at web_component.js).
I guess I was  wondering if there was a way to access state from Fast API.  One use case I was thinking about was the download use case, where we have some data in state that needs to be included in the download.
It's not a huge deal if we can't access state from from FastAPI. We'd just have to use the web component as a proxy to send certain state info to Fast API.


selection fails from the second file

It seems that the selection object only works properly in the first file opened. Once switched to a second one, it begins to fail. No error thrown in the console.

I can confirm this behavior, I've filled out the issue template here to help out:
Please Review Before Posting!

[x] I checked that the bug does not happen in the CodeMirror Vim demo. If it does, please report it there and not here.
[x] I'm reasonably sure that this bug is indeed about the Vimrc file support and not a general Vim in Obsidian issue. If it's a general Vim issue, report it here.

Describe the bug:
After loading a 2nd file, either a new file or a file previously written, commands with selections no longer work. (eg: surround commands)
To Reproduce:
Steps to reproduce the behavior:

Start Obsidian with plugin enabled and a surround command in your vimrc file
edit a file, check that surround commands work.
open a 2nd file, either new or pre-written.
Attempt a 2nd surround command on either a selected word or within a word.

Environment:

OS: Mac OS Version 12.4
Vimrc plugin version: 0.7.2

Additional context:
With verbose logs this is the error I get:
app.js:1 Error: can't surround on an empty line
    at surroundFunc (plugin:obsidian-vimrc-support:778:27)
    at Object.eval [as surround] (plugin:obsidian-vimrc-support:804:68)
    at ExCommandDispatcher._processCommand (vim.js:4658:34)
    at vim.js:4604:16
    at e.operation (app.js:1:1267455)
    at ExCommandDispatcher.processCommand (vim.js:4602:12)
    at Object.handleEx (vim.js:991:29)
    at Object.eval [as squote] (plugin:obsidian-vimrc-support:654:43)
    at ExCommandDispatcher._processCommand (vim.js:4658:34)
    at vim.js:4604:16

I sometimes also get cannot read property of null anchor errors when attempting the same thing.

@Laharah Thanks for the additional informations. Though this is not exactly the same thing I was talking about. What I meant was the selection object offered by jscommand and jsfile, which, after a second file is opened, stops updating the selection range and position and always stays the same.
I suppose the surround command might also based on the same structure, whereas selection itself doesn't throw an error when it fails.

@twio142 Ah, no worries then, I'll make my own issue then, but I'll link to this one in case it's the same root cause.

PR is merged, thank you and sorry for the huge delay :(


Backup kevin cob4 23

not needed anymore. the consolidated version is https://github.com/ipa320/cob_robots/pull/804


npm installed packages don't work untill node is ran

When opening a new shell session before running any npm installed command I have to run node first:
$ echo $NVM_BIN

$ trash
fish: Unknown command 'trash'
$ npm
Now using node v6.5.0 (npm v3.10.3)

Usage: npm <command>

where <command> is one of:
   access, adduser, bin, bugs, c, cache, completion, config,
   ddp, dedupe, deprecate, dist-tag, docs, edit, explore, get,
   help, help-search, i, init, install, install-test, it, link,
   list, ln, logout, ls, outdated, owner, pack, ping, prefix,
   prune, publish, rb, rebuild, repo, restart, root, run,
   run-script, s, se, search, set, shrinkwrap, star, stars,
   start, stop, t, tag, team, test, tst, un, uninstall,
   unpublish, unstar, up, update, v, version, view, whoami

npm <cmd> -h     quick help on <cmd>
npm -l           display full usage info
npm help <term>  search for help on <term>
npm help npm     involved overview

Specify configs in the ini-formatted file:
   /Users/matteo/.npmrc
or on the command line via: npm <command> --key value
Config info can be viewed via: npm help config

<EMAIL_ADDRESS>/Users/matteo/.nvm/versions/node/v6.5.0/lib/node_modules/npm
$ echo $NVM_BIN
/Users/matteo/.nvm/versions/node/v6.5.0/bin
$ trash
Specify at least one path

Sourcing nvm on shell init, delays it's initial start by almost two seconds, you can read more about that here https://github.com/fisherman/nvm/issues/3 and https://github.com/fisherman/nvm/issues/2


MC 1.20 javafml error

the base mc 1.20 version of your forge mod is set to the wrong fml for 1.20.
fml for 1.20: the latest is 46.0.14
fml for 1.20.1: latest is 47.0.3
crash-2023-06-17_14.20.21-fml.txt

I've removed the 1.20 tag so the mod is now labeled as requiring 1.20.1.


Added missing functions for SKPath

Added missing functions for SKPath:

Reset()
Rewind()
Added to SKPath.cs and SkiaAPI.cs in same style as SKPath.Close()

Looks like you have some whitespacing issues: this project uses hard tabs.

Thanks for this @charlenni, I am looking to merge this, but I can't find the native sk_path_reset and sk_path_rewind methods. Did you forget to PR the mono/skia repo?
Just a note on the whitespacing there - it uses spaces, not tabs :)

Sorry for the delay.
The changes to SkiaAPI.cs are added to the PR and mono/skia already contains this functions. Or I'm missing something?

It does not look like the code in Skia has it yet:
https://github.com/mono/skia/blob/xamarin-mobile-bindings/src/c/xamarin/sk_x_path.cpp

I implemented the Skia counterpart.


Navigatable checkbox

Applied tabIndex=0 to checkbox.
#50

Coverage remained the same at 92.869% when pulling 44e025c9536077b149ccd48ac066c62a209aa78a on navigatableChackbox into 5adb881a9a021fc4d7dcfa7c960d72a2b16bf295 on master.

Coverage decreased (-0.3%) to 92.558% when pulling d3348f44840bc93eac4fc77463689f6de2df9d4a on navigatableChackbox into d484f22fb9351300493e98379b218214037b3284 on master.

Coverage decreased (-0.09%) to 92.786% when pulling aa7731e4d32f5ce9ded48da1dfb87bf0fda79ecc on navigatableChackbox into d484f22fb9351300493e98379b218214037b3284 on master.

Coverage decreased (-0.09%) to 92.786% when pulling 9dd4ba41302fb1e4ceb87dc561208f23bba97646 on navigatableChackbox into d484f22fb9351300493e98379b218214037b3284 on master.

Coverage decreased (-0.09%) to 92.783% when pulling f3be892b006c2418882fb535b8f0d3ee1a99fc18 on navigatableChackbox into 45a4d0640932a5231b13f3871cbd07d49ba6fcff on master.


Invalid links to VirtualHost and VirtualDirectory

This issue was originally filed by<EMAIL_ADDRESS>
URL (if available): https://pub.dartlang.org/packages/http_server
Issue/feedback:
    The links to VirtualDirectory and VirtualHost on above page lead to blank pages. They should probably lead to https://api.dartlang.org/docs/channels/stable/latest/http_server/VirtualDirectory.html
and
https://api.dartlang.org/docs/channels/stable/latest/http_server/VirtualHost.html

This issue has been moved to dart-lang/http_server#21.


Add the ability pass multiple networks for the community string

Add the ability pass multiple networks for the community string

This is backwards compatible

Sorry that I have not been keeping up on these.   :-(


add flow and deviceType to relay

for when authTitle is changed

can you add more details on usage of this?

can you add more details on usage of this?

Allows for properly logging in with a different auth title
Without this change it isnt possible to log in with an auth title other than nintendo

@GameParrot any updates?

I fixed it, in future PRs please remember to update doc for what is changed


SSH and GPG keys

Description
It would be nice to have some documentation regarding the use of SSH and/or GPG keys with code-server.
Currently, the supported methods would be to either store the private keys on the server running code-server, or use a forwarded ssh session to the local machine where the keys are stored.
Option 2, with a forwarded session, is handled nicely by sshcode however it would be nice if this was mentioned somewhere.
Of course, this breaks the idea of being able to work from any device with a web browser.
Example Workflows

Clone/push/pull to git

Anytime you need to work with a repository, you would need to either use basic authentication (username & password) or ssh keys. I would be surprised if most people were using password-based authentication.

Signing commits

When you want to sign a commit, you need access to your private GPG key. Generally, you would want to keep this in as few locations as possible. In my case, I keep the key on a yubikey.
Related Issues
I was unable to find any issues or documentation related to using SSH or GPG keys with code-server.

+1

Any update on the FAQ?
I've finally gotten around to using code-server some more, and am having some issues (I suspect I'm expecting too much of the program).
I've created new SSH and GPG keys on my server, and setup git to use them to push/pull and sign my commits. The problem is that using the code-server commit option fails due to a lack of pinentry (I suspect). I then have to open the terminal and commit my changes manually.
I suspect there is no way of prompting the user to enter their pin via the browser itself :/

The FAQ is nearly complete, this is the last missing question at the moment. See #1338
Will reopen so I don't forget.

I've created new SSH and GPG keys on my server, and setup git to use them to push/pull and sign my commits. The problem is that using the code-server commit option fails due to a lack of pinentry (I suspect). I then have to open the terminal and commit my changes manually.

Remove pin entry from your gpg config and it should work fine.

I've removed the pinentry settings from gpg-agent.conf, and rebooted, however this does not seem to have made a difference.
When trying to commit, it still says failed to sign the data. Doing it via CLI still prompts for a password.

Ah this is a bug it’s using the terminal of the code server process instead of prompting.
Cc @code-asher

I think we'd need to create our own pinentry. Maybe something like
code-server --pinentry which will show a prompt in the browser via
the currently running code-server instance then spit out the response.
Either that or some trickery with parsing code-server's own stdout and
when it sees the password prompt text it could show a prompt in the
browser and then write out the result to stdin.

What does vscode do?

I don't believe they do anything. I think the expectation is that you're
using some graphical pinentry popup like pinentry-gtk-2 or something.

Opened https://github.com/cdr/code-server/issues/1464

This is documented in the FAQ by sshcode/exposing code-server.

I can't sign using the Integrated Commit Tool, when using the Terminal it works.

What does vscode do?

It spawns a window, where you can enter the password


Fix some format

This change is

/approve
No need for tech review. Changes are to markup only to comply with docs style guide.


SP-1923 - AWS Configuration Scanning #minor

Allow to configure AWS Config with DAILY rather than CONTINOUS scanning to reduce config recorder costs in high cadence accounts #minor

hey, would you mind updating the readme - i think theres a pre-commit to do it :)

Sorry I missed that, hadn't inited pre-commit on this repo on the new laptop yet :)


suggest pcre

https://www.pcre.org/
The golang standard library uses the RE2 engine, which is not syntactically compatible with pcre. Some systems only support pcre regular expressions, so I hope c2go can convert and support the pcre library.

https://github.com/PCRE2Project/pcre2
A pure go pcre2 migration will be great.


Update validate script

Problem:
gometalinter is timing out in CI and is being run inefficiently
Solution:
Update script to use go package listing which speeds up build times

LGTM


Extension not found when trying to sign-in

Dev Home version
0.601.285.0
Windows build number
10.0.22621.2428
Other software
OS Build Version: 10.0.22621.2428.amd64fre.ni_release.220506-1250
.NET Version: .NET 6.0.22
Steps to reproduce the bug
Go to Settings>Accounts>Add Account. I have an extension that requires an account.
Expected result
It should let us add our account because we have an extension that requires an account.
Actual result
It said there were no extensions that required an account.
Included System Information
Physical Memory: 11.89GB (1.61GB free)
Processor Architecture: x64
Included Extensions Information
Extensions:
Microsoft.Windows.DevHomeGitHubExtension_0.600.283.0_x64__8wekyb3d8bbwe
Microsoft.Windows.DevHome_0.601.285.0_x64__8wekyb3d8bbwe

Can you make it so that anybody can link their account, without having an extension that requires an account?

It says "No extensions found
Install a Dev Home extension that uses your developer account, then sign in to add the account.

I'm sorry, I misunderstood the original question.
Did you disable the extension before trying to log in with it? Disabling the extension would cause Dev Home to act like no extension is installed and show that message.

No, I didn't disable the extension.

@vineeththomasalex Can you take this?

/logs

TheLogs:https://1drv.ms/f/s!Aqq-Je19xlrfhGdaqODLtf4LHSxB?e=BTycUZ

[2023-10-19 04:46:17.4796][DevHome] ERROR: Failed to get IDeveloperIdProvider provider from 'Dev Home GitHub Extension (Preview)'
System.ArgumentNullException: Value cannot be null. (Parameter 'o')
at System.Runtime.InteropServices.Marshal.GetIUnknownForObject(Object o)
at DevHome.Models.ExtensionWrapper.b__31_0()
at System.Threading.Tasks.Task.InnerInvoke()
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
--- End of stack trace from previous location ---
at DevHome.Models.ExtensionWrapper.StartExtensionAsync()
at DevHome.Models.ExtensionWrapper.GetProviderAsyncT
at DevHome.Services.AccountsService.GetDevIdProviders()
This is very likely a symptom of the Extension crashing.

So, how do I fix this?

In the new build #1945 happens.

Duplicating to #1945

Not duplicate. That happens in the new build and this doesn't.


⚠ Bofrost.lu has degraded performance

In ff5d988, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1103 ms

Resolved: Bofrost.lu performance has improved in 9018adb.


feat(proxy): client proxy for http and https

This is a proof of concept for supporting client side proxies. The tests
are not passing yet, I am just soliciting feedback on the architecture.
The use cases that I see are the following

when proxy is configured by default all connections go to the proxy

additionally there is a small list of local wan/localhost which bypass
the proxy

So once a connection to a host is established it will either use the
proxy
all the time or it will be a direct connection all the time. The Pool
keys streams on host-port-scheme so a stream is either proxy or direct.
The logic is the following:

connect to the proxy instead of the desired host

for http use the appropriate RequestUri (pre-existing class)

for https we need to issue a CONNECT first

Let me know what you think.

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

Commit: 5109c29956e3f8cb22618fde014fc0090223c831
Commits must be in the following format: %{type}(%{scope}): %{description}
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

Commit: 5109c29956e3f8cb22618fde014fc0090223c831

Commits must be in the following format: %{type}(%{scope}): %{description}

Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Commit: 3ba3bcc2c7f3a1e91db2acab7b3629ee3fdb1ab2

Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

Commit: ca133ad4f3a986533b5960dbc6d933b7f3cb7266
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

Commit: d0d3f29dd0b4cee8f2ef4bdf5d695adcf3a4c4fc
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

Good morning Hyper community,
I've rebased my client proxy changes on master and made all the tests pass. I need to write some tests but I would like to get some advice first on the architecture. I tried a couple of alternatives like removing the concept of the Route or not have it closely tied to the HttpStream. The challenge is that the proxying is a pretty low level concept so any change tends to propagate through the codebase.
Where would you like me to take next? We have a stable commit right now and we can compare with other approaches.

At the moment there is an assumption that both HTTP and HTTPS will be handled by the same proxy. This could cause problems. While I do not need it I know others do require authentication support.
As for design concerns, is there a reason you made a new constructor instead of allowing the user to call something like add_proxy? Common use code will look something like:
let client = match read_proxy_env() {
    Some(proxy_url) => {
         Client::with_proxy_config(proxy::Config {
             proxy_host: proxy_url.some_struct_value,
             proxy_port: proxy_url.some_other_struct_value,
             proxy_version: "1.1".to_string()
         })
    }
    None => Client::new(),
}

Except as I noted above this only works when one proxy config works for both settings. If there is a separate HTTP and HTTPS proxy things get more complex. This complexity needs to be duplicated in each and every client project using hyper.
Not directly this patch's problem but reading env::var("http_proxy") is not trivial. I need to use something like into_url on the string, then find the bits in the Url struct. Similarly how should one handle no_proxy? It would be nice if there was convenience help provided for this set of common env variables.

The code works as expected for HTTP requests with the caveat that all requests go to the proxy because there is no support for no_proxy or the equivalent.
Any attempt to access a SSL url generates a SIGPIPE for me.

@shaleh thanks for the feedback. I will add authentication and fix the https crash. I also need to add tests, I will do that after I refactor the internals based on other feedback.
I do not know how frequent it is for people to have multiple proxies. If we assume that most people have one proxy for all requests then the current API is the simplest. For your use case you can create 3 Hyper clients in the three configurations that you describe:

wi proxy
http proxy
https proxy

This keeps the library simple and allows flexibility in the consuming application, with the downside that there is more code in the application.
Let me know what you think.

The point of a library is to make the application author's life easier AND to have one place to put redundant code.
Almost every user of the hyper crate will need to implement proxy support at some point. The crate should make it easy for the application author to get it right. Ideally this means stuffing as much proxy knowledge into the crate as possible.
I'd like to see a baked in way to create a hyper based Client that read its settings from the environment. A similar bit of code that took a list of proxies instead of reading the environment would be another useful interface for those that want the proxy to come from their own configs.
Sorry, I would have written code instead of asking but I have been busy on other projects.

Got it, I have been working on multiple proxies but I have only 6-8
hrs/week available myself. I will put out what ever code I have ready at
the end of this weekend.
On Fri, Oct 16, 2015 at 1:25 PM, Sean Perry<EMAIL_ADDRESS>wrote:

The point of a library is to make the application author's life easier
AND to have one place to put redundant code.
Almost every user of the hyper crate will need to implement proxy support
at some point. The crate should make it easy for the application author to
get it right. Ideally this means stuffing as much proxy knowledge into the
crate as possible.
I'd like to see a baked in way to create a hyper based Client that read
its settings from the environment. A similar bit of code that took a list
of proxies instead of reading the environment would be another useful
interface for those that want the proxy to come from their own configs.
Sorry, I would have written code instead of asking but I have been busy on
other projects.
—
Reply to this email directly or view it on GitHub
https://github.com/hyperium/hyper/pull/639#issuecomment-148824686.

I think the task of getting the proxy settings should be outside of hyper. The configuration could come from anywhere (environment variables, command line arguments, config files, hard coded, etc). Instead, hyper should accept the parameters in the Proxy constructor.
For instance:
client.set_proxy(Proxy::Http {
    host: env::var("HTTP_PROXY_HOST").unwrap(),
    port: env::var("HTTP_PROXY_PORT").unwrap(),
})

Also, it is possible to build a Proxy entirely outside of this crate, and use a hyper Client internally.  That's why I've mentioned trying not to adjust too much of the internal http protocol modules. The Client (and Request) just need to be able to use all the parts of RFC7230, such as the CONNECT method and alternate RequestUri formats. I'd rather if the logic to use those was contained in the Proxy type.

Yeah, I have been trying to be less invasive. I think that some internal
refactoring is needed and it may be outside my current understanding of the
code. Let me try this weekend and see where I end up, you are certainly
welcome to take over as soon as you have the cycles :-)
On Sat, Oct 17, 2015 at 10:59 AM, Sean McArthur<EMAIL_ADDRESS>wrote:

I think the task of getting the proxy settings should be outside of
hyper. The configuration could come from anywhere (environment variables,
command line arguments, config files, hard coded, etc). Instead, hyper
should accept the parameters in the Proxy constructor.
For instance:
client.set_proxy(Proxy::Http {
host: env::var("HTTP_PROXY_HOST").unwrap(),
port: env::var("HTTP_PROXY_PORT").unwrap(),
})

Also, it is possible to build a Proxy entirely outside of this crate,
and use a hyper Client internally. That's why I've mentioned trying not to
adjust too much of the internal http protocol modules. The Client (and
Request) just need to be able to use all the parts of RFC7230, such as the
CONNECT method and alternate RequestUri formats. I'd rather if the logic to
use those was contained in the Proxy type.
—
Reply to this email directly or view it on GitHub
https://github.com/hyperium/hyper/pull/639#issuecomment-148938187.

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

Commit: 65777aed06e69e2ce48d436bdb915b5d0fffe496
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

@seanmonstar I got rid of the Route and instead added a request_uri in Request (and RequestHead) as you had suggested on the initial PR. I've added a list of proxies each with their own proxy policies. All of this is only in place for the Http 1.1 code.
For the SSL NetworkConnector there is still one architecture issue because all the SSL types are defined only in the h2.rs file. So the NetworkConnector's connect still defers back to the Proxy, and this code is not ported to use the new list of proxies as per the desired APIs.
Where do you want me to take this code next?

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

Commit: 65777aed06e69e2ce48d436bdb915b5d0fffe496
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

Commit: c30780b56de9f05bcc70c8b8a1e5a87b23064f3d
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

@seanmonstar, thanks for your feedback I've addressed some of it.
I love your suggestion to have an implementation of NetworkConnector for Proxy, not yet implemented. What needs to happen is the following:

the Proxy implementation will connect to the proxied port
the socket must be passed down to the Http11 or SSL NetworkConnectors

With the current API this is not possible. This is the reason why the proxy is passed down.
Note that the Pool NetworkConnector has a different use case, the lower level NetworkConnectors are allowed to open their own sockets.
Please feel free to take over this PR and play with some approaches :)

As mentioned in the ticket I would love to help drive this PR forward. Proxy support is very important to me.

Ideally some of this work can be brought over to the async world, as I hope to merge async io soon. It may even be that since the async version of hyper is a little lower level, using a proxy may be easier.


Benchmark against Flyd

Has Most.js ever been benchmarked against Flyd?
Just wondering if this lib has ever been benchmarked against Flyd in perf and mem testing? It appears faster than Kefir but curious I find no Flyd reference. https://github.com/paldepind/flyd/issues/22
More so are there some unique reasons to use one over the other?
Tnx

Hi @Mapiac.  We've not benchmarked flyd, but it'd probably be fairly easy to add to the benchmarking suite if you're interested in either contributing that, or just trying it.  I'd urge you to consider benchmarking @most/core.  It's the new version of most, and we encourage everyone to use it for new projects.
As for unique reasons, I'm not familiar enough with flyd to speak to it's strengths.  We believe that @most/core's strengths are its commitment to a lean, declarative API, relatively small size and tree-shakeability, and of course, it's cpu and memory performance.
I'd say read the concepts, look at examples, and peruse the API.
Hope that helps.  Cheers!

Thanks so much for that Brian. Adding these screen shots from Flyd creator, for if it helps others making similar comparissisons. We might have some benchmarks to add soon. Most.js looks great and we'll definitely look to use the core version.

My pleasure, @Mapiac.
Shall we close this issue and plan to open a PR if you move forward with contributing new benchmarks to @most/core?


Don't transpile super()

It'd be ideal to avoid transpiling super in class and object methods. However, this is difficult - would require inlining class methods in class definitions, and creating objects with methods using super in scope functions.
However, the worst problems currently with transpiled super relate to the use of super() in class constructors e.g. #234, #341, #540. There are also other edge cases which I'm aware of which aren't handled correctly but don't have issues, and probably even more which aren't discovered yet.
Making the change to not transpile super() in class constructors is far more feasible than removing all transpilation of super overall. This would solve the worst bugs.
This input:
class S {}
export default class C extends S {
  constructor() {
    super();
    this.x = 1;
  }
}

Is currently output as:
const ObjectSetPrototypeOf = Object.setPrototypeOf,
  S = class S {},
  C = (super$0 => super$0 = class C {
    constructor() {
      const this$0 = Reflect.construct(Object.getPrototypeOf(super$0), [], super$0);
      this$0.x = 1;
      return this$0;
    }
  })();
ObjectSetPrototypeOf(C, S);
ObjectSetPrototypeOf(C.prototype, S.prototype);
export default C;

Could instead be output as:
const ObjectSetPrototypeOf = Object.setPrototypeOf,
  S = class S {},
  C = class C extends Object {
    constructor() {
      super();
      this.x = 1;
    }
  };
ObjectSetPrototypeOf(C, S);
ObjectSetPrototypeOf(C.prototype, S.prototype);
export default C;

extends Object is used as a placeholder to make the super() syntax legal. It could be replaced by extends S, but that would not work if S is circular, hence using a placeholder.
This change would have 2 further advantages:

Subclasses with no constructor would not require one to be added in output.
Could remove all the code related to transpiling super(), which is very complicated with the additional fake this$0 variable, and probably error-prone.

Some work on no-super branch.


factory function

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
I have the filling that a simple builtin helper  factory factory  would be a good addition.
from pydantic import Field, BaseModel
from pydantic.fields import FieldInfo
from typing import Callable, Any

def factory( factory: Callable[[], Any])->FieldInfo:
      return  Field( default_factory = factory )

Usage
from datetime import datetime
class M(BaseModel):
     time: datetime =  factory( datetime.now )

Which is much more readable then :
class M(BaseModel):
     time: datetime =  Field( default_factory = datetime.now )

Affected Components

[ ] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .model_dump() and .model_dump_json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[X] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

@SylvainGuieu,
Thanks for your request.
This pattern seems to be a pretty specific use case where a Field only takes the default_factory argument. Given that this is a relatively specific use case, I think a change like this should reside in user code.
Going to mark this as not planned, because I we're not likely to implement this API anytime soon.


Add Pixexid.com

Please consider add Pixexid https://pixexid.com is a free image community with features like visual crop and 360 panoramas. (custom license)

how do you plan to generate revenue out of this project, assuming you would like to generate some cash flow

how do you plan to generate revenue out of this project, assuming you would like to generate some cash flow

Affiliate links.

Good website. I enjoy using it to find image materials and doing some edit work with VanceAI https://vanceai.com/.


camera do not work

Hello,your job is great.but when I followed your tutorial to do it, the software model is the same, the model of the development board and the model of the camera are also the same, to reproduce the vvw model, but the camera does not work, the screen is completely black.

Hi @Super-Karl ,
Can you check if you are using STM32CubeIDE version 1.5.0? That could be the issue.

Hi @meenchen ,
My problem is solved, it is the inferior data cable that caused this problem, thank you!!


Improve README with Atom Beautify package settings

@Glavin001 , I see. I've tried to find in package settings a field related to ERB beautifier selection, however I couldn't find any. Besides that, there're plenty of options which I am not sure, I need them (or anyone else), so at least I would group these options somehow. How are they built? Perhaps I would try to play with them.
The context menu misunderstanding is probably due to different platform.

I've tried to find in package settings a field related to ERB beautifier selection, however I couldn't find any.

You can change the ERB default beautifier with Language Config - ERB - Default Beautifier: https://github.com/Glavin001/atom-beautify/blob/master/docs/options.md#language-config---erb---default-beautifier

Besides that, there're plenty of options which I am not sure, I need them (or anyone else), so at least I would group these options somehow. How are they built? Perhaps I would try to play with them.

The documented options here: https://github.com/Glavin001/atom-beautify/blob/master/docs/options.md
Are generated by https://github.com/Glavin001/atom-beautify/blob/master/docs/index.coffee
Which uses the options generated by buildOptionsForBeautifiers here: https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/index.coffee#L92-L273

The context menu misunderstanding is probably due to different platform.

Yup. I think the platform agnostic way is to use the Atom command Application: Open your Config

This README change is not really in the direction that I want to go with documentation. I do agree, there are too many options, however I still encourage users to read the documentation (link provided in current README already) and then set in their Atom Beautify package settings, and in their .jsbeautifyrc file for project-specific settings. This is all indicated in the old / current README, so I am going to close this.
I do however, want to look into improvements for displaying the settings in the package settings view. I wondering if groups are supported?


OrderHelper enhancements

Split up OrderHelper
Provide fulfillment strategy to OrderHelper
Replace CriteriaConstraint with HelperAdvancedOrder

Note: Depends on https://github.com/ProjectOpenSea/seaport-sol/pull/3

Codecov Report
Patch and project coverage have no change.

Comparison is base (e1ab8a9) 100.00% compared to head (57f06de) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1253     +/-   ##
===========================================
  Coverage   100.00%   100.00%
===========================================
  Files           22         1     -21
  Lines         1307         2   -1305
  Branches       220         0    -220
===========================================
- Hits          1307         2   -1305

Flag
Coverage Δ

foundry
?

production
100.00% <ø> (ø)

reference
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 21 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


https://webui.ipfs.io can't access API througt my lan IP

Describe the bug
I don't know why https://webui.ipfs.io can't access to my API via my IP lan address (eg. <IP_ADDRESS>) although that works when the API listen to <IP_ADDRESS>.
I set CORS and API address:
% cat ~/.ipfs/config | head -n 23
{
  "API": {
    "HTTPHeaders": {
      "Access-Control-Allow-Methods": [
        "POST"
      ],
      "Access-Control-Allow-Origin": [
        "*"
      ]
    }
  },
  "Addresses": {
    "API": "/ip4/<IP_ADDRESS>/tcp/5001",
    "Announce": [],
    "Gateway": "/ip4/<IP_ADDRESS>/tcp/8080",
    "NoAnnounce": [],
    "Swarm": [
      "/ip4/<IP_ADDRESS>/tcp/4001",
      "/ip6/::/tcp/4001",
      "/ip4/<IP_ADDRESS>/udp/4001/quic",
      "/ip6/::/udp/4001/quic"
    ]
  },

Furthermore, that works on http://<IP_ADDRESS>:5001/webui
To Reproduce
Steps to reproduce the behavior:

Set CORS and API address on cli:

ipfs config --json API.HTTPHeaders.Access-Control-Allow-Origin '["*"]'
ipfs config --json API.HTTPHeaders.Access-Control-Allow-Methods '["POST"]'

Run ipfs daemon
Go to https://webui.ipfs.io
On the bottom of this web page, set manually the API address: /ip4/<IP_ADDRESS>/tcp/5001
The ipfs webui can't find the API

Expected behavior
https://webui.ipfs.io is connected to the API.
Desktop:

OS: macOS Catalina (10.15.4)
Browser: firefox 76.0.1
IPFS version 0.5.1

@lidel @rafaelramalho19 or @olizilla -- might you be able to triage? Thank you!

@D4ryl00 I suspect this is caused by Firefox blocking loading "mixed active content"... by default now Firefox will block requests to http urls from a page that was loaded over https, see: https://developer.mozilla.org/en-US/docs/Web/Security/Mixed_content
If you are comfortable with the dev tools in Firefox, you can verify that by repeating the steps and checking for a console error line similar to:

I believe Chromium based browser do not have the same restriction. We are unlikely to get time to come up with a fix for this any time soon, but good ideas for solutions and patches are welcome! I suspect the only immediate solutions will be, figure out how to get Firefox to drop the restriction for that IP if possible, or set up a valid https cert for a domain for your IPFS node, via nginx and letsencrypt or similar, which is non-trivial.
Can you confirm that it is the mixed content issue that you are hitting?

Yes, I've just checked the console and both Firefox and Google Chrome block mixed active content by default as you said.

Ok, I'm gonna go close this out as known issue. It's worth noting that webui.ipfs.io always points to the bleeding edge, latest commit, so if you can deal with using the local ip for your IPFS node instead, you'll have a more stable time of it.


Extracting only all keys

Hi there,
I skimmed through the closed issues and google couldn't help me either so:
How can I extract all keys? (retaining the order is not necessary)
{
  "field11": "value11",
  "field12": "value12",
  "field13": "value13"
}

	res := gjson.Get(s, "SomethingMagical")

Result should be: field11,field12,field13
Thanks in advance for answer.

Hi,
Currently, there's nothing built into the gjson path syntax that allows for extracting keys as values.
One option is to use the ForEach function to iterate over each key and build a json array.
Here's an example:
package main

import (
	"strings"

	"github.com/tidwall/gjson"
)

func getKeysAsValues(json string) gjson.Result {
	var sb strings.Builder
	sb.WriteByte('[')
	var once bool
	gjson.Parse(json).ForEach(func(key, value gjson.Result) bool {
		if !key.Exists() {
			return false
		}
		if once {
			sb.WriteByte(',')
		} else {
			once = true
		}
		sb.WriteString(key.Raw)
		return true
	})
	sb.WriteByte(']')
	return gjson.Parse(sb.String())
}

func main() {
	const json = `{
		"field11": "value11",
		"field12": "value12",
		"field13": "value13"
	  }`
	res := getKeysAsValues(json)
	println(res.String())
}

// output: ["field11","field12","field13"]

Or you could take it one step further by extend the gjson syntax with a custom modifier. Such as:
gjson.AddModifier("keyvals", func(json, _ string) string {
	return getKeysAsValues(json).String()
})

Then use @keyvals like:
res := gjson.Get(json, "@keyvals")

Perfect! Thank you!

This is just a heads up regarding performance:
goos: darwin
goarch: amd64
BenchmarkJSONKeys/GJSON-4         	 1000000	      1709 ns/op	     848 B/op	      16 allocs/op
BenchmarkJSONKeys/GJSON-4         	 1000000	      1723 ns/op	     848 B/op	      16 allocs/op
BenchmarkJSONKeys/jsoniter-4      	  300000	      3791 ns/op	    1982 B/op	      52 allocs/op
BenchmarkJSONKeys/jsoniter-4      	  300000	      3855 ns/op	    1982 B/op	      52 allocs/op
BenchmarkJSONKeys/stdlib-4        	  200000	      7941 ns/op	    2478 B/op	      66 allocs/op
BenchmarkJSONKeys/stdlib-4        	  200000	      7947 ns/op	    2478 B/op	      66 allocs/op
PASS

You're welcome and I'm glad it's working out well for you.


New build old PDNS server

I was trying to upgrade a CentOS 7 build that i have however i had many error in the upgrade. so I decided to build a new system to host the application - when I try to connect to the old PDNS server to pull records - I encounter this issue.
[2022-10-26 11:53:11,097] [domain.py:181] ERROR - Cannot update domain table. Error: (raised as a result of Query-invoked autoflush; consider using a session.no_autoflush block if this flush is occurring prematurely)
(sqlite3.IntegrityError) column name is not unique
[SQL: INSERT INTO domain (name, master, type, serial, notified_serial, last_check, dnssec, account_id) VALUES (?, ?, ?, ?, ?, ?, ?, ?)]
[parameters: ('50.251.209.in-addr.arpa', '[]', 'Master',<PHONE_NUMBER>, 7200, 0, 0, None)]
(Background on this error at: http://sqlalche.me/e/13/gkpj)
[2022-10-26 11:53:11,205] [_internal.py:225] INFO - <IP_ADDRESS> - - [26/Oct/2022 11:53:11] "GET /dashboard/ HTTP/1.1" 200 -
[2022-10-26 11:53:12,036] [_internal.py:225] INFO - <IP_ADDRESS> - - [26/Oct/2022 11:53:12] "GET /static/generated/main.js?bb987201 HTTP/1.1" 304 -
[2022-10-26 11:53:12,781] [internal.py:225] INFO - <IP_ADDRESS> - - [26/Oct/2022 11:53:12] "GET /dashboard/domains-custom/reverse?draw=1&columns%5B0%5D%5Bdata%5D=0&columns%5B0%5D%5Bname%5D=&columns%5B0%5D%5Bsearchable%5D=true&columns%5B0%5D%5Borderable%5D=true&columns%5B0%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B0%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B1%5D%5Bdata%5D=1&columns%5B1%5D%5Bname%5D=&columns%5B1%5D%5Bsearchable%5D=true&columns%5B1%5D%5Borderable%5D=true&columns%5B1%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B1%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B2%5D%5Bdata%5D=2&columns%5B2%5D%5Bname%5D=&columns%5B2%5D%5Bsearchable%5D=true&columns%5B2%5D%5Borderable%5D=true&columns%5B2%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B2%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B3%5D%5Bdata%5D=3&columns%5B3%5D%5Bname%5D=&columns%5B3%5D%5Bsearchable%5D=true&columns%5B3%5D%5Borderable%5D=true&columns%5B3%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B3%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B4%5D%5Bdata%5D=4&columns%5B4%5D%5Bname%5D=&columns%5B4%5D%5Bsearchable%5D=true&columns%5B4%5D%5Borderable%5D=true&columns%5B4%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B4%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B5%5D%5Bdata%5D=5&columns%5B5%5D%5Bname%5D=&columns%5B5%5D%5Bsearchable%5D=true&columns%5B5%5D%5Borderable%5D=true&columns%5B5%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B5%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B6%5D%5Bdata%5D=6&columns%5B6%5D%5Bname%5D=&columns%5B6%5D%5Bsearchable%5D=true&columns%5B6%5D%5Borderable%5D=false&columns%5B6%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B6%5D%5Bsearch%5D%5Bregex%5D=false&order%5B0%5D%5Bcolumn%5D=0&order%5B0%5D%5Bdir%5D=asc&start=0&length=10&search%5Bvalue%5D=&search%5Bregex%5D=false&=1666799592236 HTTP/1.1" 200 -
[2022-10-26 11:53:12,791] [internal.py:225] INFO - <IP_ADDRESS> - - [26/Oct/2022 11:53:12] "GET /dashboard/domains-custom/inaddrarpa?draw=1&columns%5B0%5D%5Bdata%5D=0&columns%5B0%5D%5Bname%5D=&columns%5B0%5D%5Bsearchable%5D=true&columns%5B0%5D%5Borderable%5D=true&columns%5B0%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B0%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B1%5D%5Bdata%5D=1&columns%5B1%5D%5Bname%5D=&columns%5B1%5D%5Bsearchable%5D=true&columns%5B1%5D%5Borderable%5D=true&columns%5B1%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B1%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B2%5D%5Bdata%5D=2&columns%5B2%5D%5Bname%5D=&columns%5B2%5D%5Bsearchable%5D=true&columns%5B2%5D%5Borderable%5D=true&columns%5B2%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B2%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B3%5D%5Bdata%5D=3&columns%5B3%5D%5Bname%5D=&columns%5B3%5D%5Bsearchable%5D=true&columns%5B3%5D%5Borderable%5D=true&columns%5B3%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B3%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B4%5D%5Bdata%5D=4&columns%5B4%5D%5Bname%5D=&columns%5B4%5D%5Bsearchable%5D=true&columns%5B4%5D%5Borderable%5D=true&columns%5B4%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B4%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B5%5D%5Bdata%5D=5&columns%5B5%5D%5Bname%5D=&columns%5B5%5D%5Bsearchable%5D=true&columns%5B5%5D%5Borderable%5D=true&columns%5B5%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B5%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B6%5D%5Bdata%5D=6&columns%5B6%5D%5Bname%5D=&columns%5B6%5D%5Bsearchable%5D=true&columns%5B6%5D%5Borderable%5D=false&columns%5B6%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B6%5D%5Bsearch%5D%5Bregex%5D=false&order%5B0%5D%5Bcolumn%5D=0&order%5B0%5D%5Bdir%5D=asc&start=0&length=10&search%5Bvalue%5D=&search%5Bregex%5D=false&=1666799592238 HTTP/1.1" 200 -
[2022-10-26 11:53:12,792] [internal.py:225] INFO - <IP_ADDRESS> - - [26/Oct/2022 11:53:12] "GET /dashboard/domains-custom/ip6arpa?draw=1&columns%5B0%5D%5Bdata%5D=0&columns%5B0%5D%5Bname%5D=&columns%5B0%5D%5Bsearchable%5D=true&columns%5B0%5D%5Borderable%5D=true&columns%5B0%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B0%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B1%5D%5Bdata%5D=1&columns%5B1%5D%5Bname%5D=&columns%5B1%5D%5Bsearchable%5D=true&columns%5B1%5D%5Borderable%5D=true&columns%5B1%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B1%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B2%5D%5Bdata%5D=2&columns%5B2%5D%5Bname%5D=&columns%5B2%5D%5Bsearchable%5D=true&columns%5B2%5D%5Borderable%5D=true&columns%5B2%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B2%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B3%5D%5Bdata%5D=3&columns%5B3%5D%5Bname%5D=&columns%5B3%5D%5Bsearchable%5D=true&columns%5B3%5D%5Borderable%5D=true&columns%5B3%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B3%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B4%5D%5Bdata%5D=4&columns%5B4%5D%5Bname%5D=&columns%5B4%5D%5Bsearchable%5D=true&columns%5B4%5D%5Borderable%5D=true&columns%5B4%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B4%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B5%5D%5Bdata%5D=5&columns%5B5%5D%5Bname%5D=&columns%5B5%5D%5Bsearchable%5D=true&columns%5B5%5D%5Borderable%5D=true&columns%5B5%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B5%5D%5Bsearch%5D%5Bregex%5D=false&columns%5B6%5D%5Bdata%5D=6&columns%5B6%5D%5Bname%5D=&columns%5B6%5D%5Bsearchable%5D=true&columns%5B6%5D%5Borderable%5D=false&columns%5B6%5D%5Bsearch%5D%5Bvalue%5D=&columns%5B6%5D%5Bsearch%5D%5Bregex%5D=false&order%5B0%5D%5Bcolumn%5D=0&order%5B0%5D%5Bdir%5D=asc&start=0&length=10&search%5Bvalue%5D=&search%5Bregex%5D=false&=1666799592237 HTTP/1.1" 200 -
[2022-10-26 11:53:12,936] [_internal.py:225] INFO - <IP_ADDRESS> - - [26/Oct/2022 11:53:12] "GET /static/img/favicon.png HTTP/1.1" 304 -
Seems like it is having issues pulling all the domains and records from the API call.
anyone knows the fix for this ?

does any one know how to fix this ?


feat: add Xing social network link and icon

Adds support for the Xing social network user profile. Xing is a German version of LinkedIn and I think that millions of employees use it here.

Thanks for your contributions.


Active - Active : Reversed Key values

Hi, a simple 2 member Active - Active, as per the documentation.
Host1:
Writes    key: thehostname, value: Host1
Host2:
Writes    key: thehostname, value: Host2
This happens to occur at the exact same time.
The results is:
Host1:
Key: thehostname, value: Host2
Host2:
Key: thehostname, value: Host1
Obviously the preference is that one would win and overwrite, block the other write. That is, I do not need one value to win, I need to stop one of the writes from being successful.
The code that does that, checks if the Key exists before attempting to create it with the value. Open to suggestions to fix the code :).
In the mean time i've put a HAproxy in front of it to queue all writes to 1 and fail to the other if it fails.
There might be a better simple dual HA configuration I can use? Maybe standard multi-master with readonly replica?
I really need to be able to bounce these hosts up and down and not to have to deal with things like a broken redis cluster :D

Clock skew is resulting in them not converging. I had a plan to implement synchronization and it looks like its about time to implement it.
The original plan for Active Rep was to support what you described, send all traffic to one node and failover to the other without needing sentinel to promote.

What is the point of multi-master without CRDT feature? They would just be overwriting each other or worse, what OP just experienced.
I was blown away that KeyDB had achieved master-master but I've yet to see a good use case of the current implementation. I think KeyDB should *star it's homepage when mentioning master-master and say "CRDT-pending" to not get everyone excited.
Also consider starting a Gitcoin for this project as I know many people as well as myself would sponsor this feature. https://gitcoin.co/
https://github.com/EQ-Alpha/KeyDB/issues/47 can't come sooner.
Thanks.

Since RAFT is an active work in progress, and would fix this issue as well as CRDTs would, closing this issue and tracking with #349 instead.


Use besu-untuned to execute the acceptance tests

PR description
Use besu-untuned to execute different tests that need to run a besu node in a different process.
Also, there is no need to apply the JVM tuning related to GC and continuous profiling to this kind of tests.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

[x] Checked out our contribution guidelines?
[x] Considered documentation and added the doc-change-required label to this PR if updates are required.
[x] Considered the changelog and included an update if required.
[x] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

[x] unit tests: ./gradlew build
[ ] acceptance tests: ./gradlew acceptanceTest
[ ] integration tests: ./gradlew integrationTest
[ ] reference tests: ./gradlew ethereum:referenceTests:referenceTests

It's different test failures each time but it seems specific to this PR (eg CLIOptions tests)

Yes, it seems to be related to this PR, I tried different executions but I had different issues especially the timeout one. My interpretation is that with besu sh, the acceptance tests are running faster. The only difference between besu and besu-untuned is GC flags and JFR continuous profiling.
I will continue to investigate.


Vector Load/Store Whole Register Instruction formats

Section 7.9 now shows the formats for Vector Load/Store Whole Register Instructions as:
Format for Vector Load Whole Register Instructions under LOAD-FP major opcode
31 29  28  27 26  25 24   20 19       15 14   12 11      7 6     0
 nf  | mew| mop  | 1| 01000 |    rs1    | width |    vd   |0000111| VL<nf>R

Format for Vector Store Whole Register Instructions under STORE-FP major opcode
31 29  28  27 26 25  24   20 19       15 14   12 11      7 6     0
 nf  |  0 | mop |  1| 01000 |    rs1    |  000  |   vs3   |0100111| VS<nf>R

Is this correct, or should the mop fields actually be 00 (i.e. unit-stride only)?

In Table 7, 8
mop=00 is for unit-stride
and in Table 9, 10
lumop/sumop fields are 01000 for unit-stride, whole registers
so I think the mop here should be 00.
also in vmem-format.adoc
mop in unit-stride and strided column
should use 00 and 10 directly.
Format for Vector Load Instructions under LOAD-FP major opcode
31 29  28  27 26  25  24      20 19       15 14   12 11      7 6     0
nf  | mew| mop | vm |  lumop   |    rs1    | width |    vd   |0000111| VL*  unit-stride
nf  | mew| mop | vm |   rs2    |    rs1    | width |    vd   |0000111| VLS* strided
nf  | mew| mop | vm |   vs2    |    rs1    | width |    vd   |0000111| VLX* indexed
Format for Vector Store Instructions under STORE-FP major opcode
31 29  28  27 26  25  24      20 19       15 14   12 11      7 6     0
nf  | mew| mop | vm |  sumop   |    rs1    | width |   vs3   |0100111| VS*  unit-stride
nf  | mew| mop | vm |   rs2    |    rs1    | width |   vs3   |0100111| VSS* strided
nf  | mew| mop | vm |   vs2    |    rs1    | width |   vs3   |0100111| VSX* indexed

Fixed with #526


cl20: Khronos Bug 16236: Support CL_DEPTH images in the image helpers…

… when using the border colour
Signed-off-by: Kevin Petit<EMAIL_ADDRESS>

Already present in other branches. Merging.


Remove CoinCut (OTC) from the list of merchants

What's the name of the merchant you are asking to remove?
CoinCut (OTC)
What's the URL of their website?
https://www.coincut.com/
Why do you think it should be removed?

[x] They don't accept Monero anymore
[ ] They are likely scammers
[ ] They closed / Their services are unavailable

Useful links
https://www.coincut.com/
Additional comments
Very strange site has passed registration well I have not found where they have the opportunity to exchange Monero, perhaps she was before but at the moment there is no way to exchange Monero on this site.

They seem to accept Monero, but we should remove them anyway. They look inactive.


Add docker-compose file with better local debugging support

Describe the change
This adds a docker-compose.yml file and updates the README to simplify running the app to just docker-compose up -d. This should greatly simplify the experience for new users running the emulator. The compose file also uses named volumes for easy persistence and access from the host for the keypair and database files.
In order to better support local debugging without having to have access to system folders, this uses an environment variable when running in Docker for the database and cert/key files, but defaults to a "data" folder within the repo so that the IDE/CLI does not need special permissions to /var (on macOS/Linux).
Additionally, the openssl command has been moved into keygen.sh which can be run locally for local development, but is also run by the container and is aware of those Docker Compose environment variables, falling back to the local data folder.
Current behavior
The instructions to start up the emulator are complex and are not easily repeatable.
New behavior
The startup of the emulator is easy with docker-compose up
Additional context
Updates README, adds keygen.sh file for easy key generation.

Hi @paulirwin, thank you very much for your contribution!
Given that different teams will be running the emulator differently I would like to keep getting started as is for now.
It is also worth noting that the emulator is still being developed and so there could be breaking changes pre-stable.

This change is largely in addition to what already exists. What about if I add back the README instructions for those that don't want to use docker-compose?

I would like to keep getting started as is for now as those steps are simple for people to get started with the emulator.
Different teams will likely have different ways of running the emulator so I would like to keep the README generalised.

With all due respect, the following steps are not exactly simple to use:

openssl req -x509 -out ./emulator.crt -keyout ./emulator.key -newkey rsa:2048 -nodes -sha256 -subj '/CN=localhost' -addext 'subjectAltName=DNS:localhost'
docker build -f ./src/AzureAppConfigurationEmulator/Dockerfile -t azure-app-configuration-emulator .
docker run -e ASPNETCORE_HTTP_PORTS=8080 -e ASPNETCORE_HTTPS_PORTS=8081 -p 8080:8080 -p 8081:8081 -v ./emulator.crt:/usr/local/share/azureappconfigurationemulator/emulator.crt:ro -v ./emulator.key:/usr/local/share/azureappconfigurationemulator/emulator.key:ro azure-app-configuration-emulator-data-potection-keys:/root/.aspnet/DataProtection-Keys azure-app-configuration-emulator

I do not understand how that is simpler than docker-compose up. Can you explain your thinking?
And like I said, I can add back these instructions if you'd prefer, while also having a docker-compose option for those that want a simple command to start it up. I think this helps move in the direction of your goal of "Different teams will likely have different ways of running the emulator" which includes docker-compose and named volumes.
It also is not simple for local debugging to have to grant access for the IDE to /var/lib (on macOS) to run outside of Docker. It is far easier to run in my experience to use a path within the repo where that permission is implicitly granted already. Additionally, this change allows for an environment variable to specify where the keypair/database files are, which better enables your goal of "Different teams will likely have different ways of running the emulator" - something that is hindered with the current hardcoded paths. By making it environment variables, users can set it to any path they want for any way they want to run the app. That said, if you really want those hardcoded paths, I can add that back as a fallback if the env var is not present.
Can we discuss how we can enable these different ways of running the emulator (such as via docker-compose with one simple command) without closing this PR wholesale? If you have feedback on the PR I'm open to addressing it.

To be fair the current approach only requires copying and executing 3 commands (2 if you exclude self-signed certificate generation) and being container-based also means that it is cross-platform.
Enhancing the documentation with other supported environments and scenarios is something that will be done nearer to the stable release of the emulator.


#656: Added more unit tests to TkProxyTest

Fix for #656
The goal of this PR is to add more unit tests to TkProxyTest.

@essobedo Let me find a reviewer for this pull request, thanks for submitting it

@dmzaytsev it's yours, please review

@essobedo looks good to me, thanks

@rultor merge

@rultor merge

@dmzaytsev Thanks for your request. @yegor256 Please confirm this.

@yegor256 Could you please check? thx in advance

@yegor256 ping

@yegor256 please review my PR, thx in advance

@rultor try to merge

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 23min)

@ypshenychka review this ticket please, for compliance with our quality rules

@rultor please deploy

@rultor please deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor please deploy

@davvd Done! FYI, the full log is here (took me 27min)

@dmzaytsev
According to our QA Rules:

The code reviewer found at least three problems in the code.

No issues were found during code review.
Please confirm that you'll try to find at least three problems while future reviews.

@ypshenychka I confirm

@dmzaytsev Thank you.

@davvd Quality is acceptable.

@davvd Quality is acceptable.

@ypshenychka thanks for the QA review, we'll work better next time

@dmzaytsev paied 10 mins to @ypshenychka for QA review (payment ID is 84065493)... Much appreciated! 18 mins was added to your account, payment ID 84065518, time spent is 119 hours and 42 mins... review comments (c=3) added as a bonus... added +18 to your rating, now it is equal to +2128


Event Reorder in The Same Region

Before asking a question, make sure you have

[X] Searched existing Stack Overflow questions
[X] Googled your question
[X] Searched open and closed GitHub issues
[X] Read the documentation

What is your question?
Is it expected that the events in the puller module is not ordered at region level?
I understand that the events are not globally ordered because the events are from different regions which belong to different Raft stores. But should the events in the same region be ordered when they are sent from TiKV?
I inserted some logs in the puller module and found they were not ordered in the same region.

They are ordered as they are sent from TiKV, as long as there is no region merger or split. But the order might be different from what you might expect from the commitTs of the transactions.

@liuzix Thanks for the explanation.


Script Stalls

After clicking "Start" the script runs for a while then it stalls with no error message. It stops at:
[ ok ] Started Docker Application Container Engine.
I've tried to restarting a few times but it continually stalls at this point.

Do you mean the Virtual machine stalls at "[ ok ] Started Docker Application Container Engine."
as the script is run on the shell part of the host, and doesn't start the machine after it's created it.

Yes. I reran the install a couple of times and did notice two failed statements as the script was running through the console. I had to rerun it a few times to capture it since there is no way to scroll back. The 1st one was: "Failed to start Network Manager wait online" and the 2nd was: " Failed to Start Docker Application Container". Both of these appeared I was say around the middle of the script and it goes by quickly. It then proceeds to the "[ ok ] Started Docker Application Container Engine" and just stalls. I tried waiting over 30 minutes but it doesn't appear to be moving forward at all.  I should note that I have Proxmox installed on an older Core 2 Duo Laptop. Could any of these be impacting why it is not proceeding?

So thats not the script, thats just the virtual machine booting (I gather from you saying yes)
what happens if you press enter a few times when your in the console of that virtual machine.
Have you installed Proxmox on to the laptop ?
the processor is quite old, but should support Proxmox fine.

Proxmox is installed on the laptop and appears to be running fine. Pressing enter does nothing in the console. I actually tried the other approach from Dr Zzzs video using MarkM's script and it stops at the same spot in the console. It also looks like it is running and I do see an ip address in my router however when I try to connect to it the web page refuses connection.

Are you using the wireless on the laptop as the bridge device ? or are you cabled in ?

I am using an Ethernet cable on the laptop

Sorry that was my final idea of what it could be, I've run the script on 3 different boxes (not quite as old as core2duo) and it worked fine.

I was hoping for a minor miracle, wanted to play with a dev version of hassio under proxmox. Looks like I'll need a better machine.


Is RTL Languages Supported?

Yes :)

If I switch to an RTL Language, the stars don't switch to RTL
I added the Cosmos view via Interface Builder and added it in a stack view; in a custom UICollectionViewCell
**Using latest Xcode 8.3.3 and latest Update of the Library

Hi, thanks for reporting. I created a demo app with collection view and placed a cosmos view inside a stack view. However, I could not reproduce your problem. The cosmos view flipped to right-to-left mode after I switched my phone to Hebrew (Settings > General > Language & Region).
Please see the attached demo app below.
CosmosRTLDemo.zip
You probably know this, but just for the record:

One needs to add the localization for the right-to-left language in the project settings, in order for it to work.
One can quickly test right-to-left layout by choosing Edit Scheme > Application Language > Righ-to-left pseudolanguage.

Maybe there is something specific to your app that I did not try?

@mn288 please let me know if you still have the problem :)

I am sorry for the late response, seems something was wrong with my email notifications. I still face the same problem.
I tried your sample project, it works beautifully with Hebrew, but with Arabic, it isn't working as it should

It's ok @mn288. The sample project will not show right-to-left layout unless one adds a localization for Arabic language in Project > Into. Please see the screenshot attached. Let me know if it fixes the problem.

Although the last step you mentioned was already implemented, I solved the problem by:

Removed all the localizations
Removed Derived Data folder
Cleaned the Project
Added localization files from scratch.

Thanks a lot

I'm glad it worked, thanks for sharing your solution. 👍

@wajihkm creating a new issue #132.


Vorbis weird replay behavior

If you load a Vorbis file in the StreamPlayer and press play on the editor, it works fine. But if you stop and play again it makes a weird sound (like the samples are out of order). It becomes worse each time you stop and play again.
It can also be reproduced by this code inside a StreamPlayer with a loaded Vorbis stream:
extends StreamPlayer

func _ready():
	play()
	stop()
	play()

I confirm the bug. It sounds really weird :)

I can reproduce this issue as well.

this was fixed long ago, closing


Opening wireless grids with the keybinding locks the active hot bar slot, even if that slot isn't the opened grid.

Version: 0.4.4
Replication

Have a Wireless Grid (or similar) in your inventory.
Assign a key to open that grid.
Select a slot on the hot bar that doesn't contain the Wireless Grid.
Open the Wireless Grid with the keybinding.

Result

Items cannot be moved into or out of the selected hot bar slot as long as the Wireless Grid is open.
The Wireless Grid can be picked up, dropped out of the inventory, or moved to any slot except the selected hot bar slot, including into the storage network it is connected to.

Expected Behavior
Opening a Wireless Grid or other wireless grid item should lock the inventory slot the opened grid occupies, rather than assume the currently selected hot bar slot has the open grid and locking that.

I'm sure this is for locking the grid in place when it is opened by right-clicking it, so that you can't accidentally put it into itself. However, when you open with the keybinding the selected slot could easily be something else, and it's a little confusing when suddenly a "random" item can't be picked up, or a "random" slot can't have an item moved into it while the grid is open.
As a curiosity, picked up items can be put into the locked slot if it is empty, and will then be locked in place until the Wireless Grid is closed.

Fixed for RS 1.7.1. Thanks for reporting.
https://github.com/raoulvdberge/refinedstorage/commit/b485c74503b84cb7b7f7f105ecbce566be9f520e


link validator: ignore license report

partly covers #395

no idea why the ignore doesn't seem to be working :/