Enable allWarningsAsError on the library?

tasks.withType<KotlinCompile> {
  kotlinOptions {
    allWarningsAsErrors = true
  }
}

It's easier to add it now than later.
👍 👎

Yep let's enable it now 👍


Segfault running helloworld

rustc 1.45.0-nightly
kApp 0.1.0
    Finished dev [unoptimized + debuginfo] target(s) in 0.15s
     Running `target/debug/examples/hello`
[1]    24666 segmentation fault  cargo run --example hello

Thanks for the report! Which platform are you running this on?

Thanks for the report! Which platform are you running this on?

macOS Mojave 10.14.6
Cargo.lock in case it helps
# This file is automatically @generated by Cargo.
# It is not intended for manual editing.
[[package]]
name = "bumpalo"
version = "3.2.1"
source = "registry+https://github.com/rust-lang/crates.io-index"

[[package]]
name = "cfg-if"
version = "0.1.10"
source = "registry+https://github.com/rust-lang/crates.io-index"

[[package]]
name = "console_error_panic_hook"
version = "0.1.6"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "cfg-if 0.1.10 (registry+https://github.com/rust-lang/crates.io-index)",
 "wasm-bindgen 0.2.64 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "gl_generator"
version = "0.13.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "khronos_api 3.1.0 (registry+https://github.com/rust-lang/crates.io-index)",
 "log 0.4.8 (registry+https://github.com/rust-lang/crates.io-index)",
 "xml-rs 0.8.3 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "glow"
version = "0.4.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "gl_generator 0.13.1 (registry+https://github.com/rust-lang/crates.io-index)",
 "js-sys 0.3.39 (registry+https://github.com/rust-lang/crates.io-index)",
 "slotmap 0.3.0 (registry+https://github.com/rust-lang/crates.io-index)",
 "wasm-bindgen 0.2.64 (registry+https://github.com/rust-lang/crates.io-index)",
 "web-sys 0.3.39 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "js-sys"
version = "0.3.39"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "wasm-bindgen 0.2.64 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "kapp"
version = "0.1.0"
dependencies = [
 "glow 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)",
 "kapp_gl_context 0.1.0",
 "kapp_platform_macos 0.1.0",
 "kapp_platform_web 0.1.0",
 "kapp_platform_windows 0.1.0",
]

[[package]]
name = "kapp_gl_context"
version = "0.1.0"
dependencies = [
 "kapp_platform_common 0.1.0",
 "objc 0.2.7 (registry+https://github.com/rust-lang/crates.io-index)",
 "raw-window-handle 0.3.3 (registry+https://github.com/rust-lang/crates.io-index)",
 "wasm-bindgen 0.2.64 (registry+https://github.com/rust-lang/crates.io-index)",
 "web-sys 0.3.39 (registry+https://github.com/rust-lang/crates.io-index)",
 "winapi 0.3.8 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "kapp_platform_common"
version = "0.1.0"
dependencies = [
 "raw-window-handle 0.3.3 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "kapp_platform_macos"
version = "0.1.0"
dependencies = [
 "kapp_platform_common 0.1.0",
 "objc 0.2.7 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "kapp_platform_web"
version = "0.1.0"
dependencies = [
 "console_error_panic_hook 0.1.6 (registry+https://github.com/rust-lang/crates.io-index)",
 "kapp_platform_common 0.1.0",
 "wasm-bindgen 0.2.64 (registry+https://github.com/rust-lang/crates.io-index)",
 "web-sys 0.3.39 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "kapp_platform_windows"
version = "0.1.0"
dependencies = [
 "kapp_platform_common 0.1.0",
]

[[package]]
name = "khronos_api"
version = "3.1.0"
source = "registry+https://github.com/rust-lang/crates.io-index"

[[package]]
name = "lazy_static"
version = "1.4.0"
source = "registry+https://github.com/rust-lang/crates.io-index"

[[package]]
name = "libc"
version = "0.2.69"
source = "registry+https://github.com/rust-lang/crates.io-index"

[[package]]
name = "log"
version = "0.4.8"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "cfg-if 0.1.10 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "malloc_buf"
version = "0.0.6"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "libc 0.2.69 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "objc"
version = "0.2.7"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "malloc_buf 0.0.6 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "proc-macro2"
version = "1.0.18"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "unicode-xid 0.2.0 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "quote"
version = "1.0.4"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "proc-macro2 1.0.18 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "raw-window-handle"
version = "0.3.3"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "libc 0.2.69 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "slotmap"
version = "0.3.0"
source = "registry+https://github.com/rust-lang/crates.io-index"

[[package]]
name = "syn"
version = "1.0.33"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "proc-macro2 1.0.18 (registry+https://github.com/rust-lang/crates.io-index)",
 "quote 1.0.4 (registry+https://github.com/rust-lang/crates.io-index)",
 "unicode-xid 0.2.0 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "unicode-xid"
version = "0.2.0"
source = "registry+https://github.com/rust-lang/crates.io-index"

[[package]]
name = "wasm-bindgen"
version = "0.2.64"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "cfg-if 0.1.10 (registry+https://github.com/rust-lang/crates.io-index)",
 "wasm-bindgen-macro 0.2.64 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "wasm-bindgen-backend"
version = "0.2.64"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "bumpalo 3.2.1 (registry+https://github.com/rust-lang/crates.io-index)",
 "lazy_static 1.4.0 (registry+https://github.com/rust-lang/crates.io-index)",
 "log 0.4.8 (registry+https://github.com/rust-lang/crates.io-index)",
 "proc-macro2 1.0.18 (registry+https://github.com/rust-lang/crates.io-index)",
 "quote 1.0.4 (registry+https://github.com/rust-lang/crates.io-index)",
 "syn 1.0.33 (registry+https://github.com/rust-lang/crates.io-index)",
 "wasm-bindgen-shared 0.2.64 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "wasm-bindgen-macro"
version = "0.2.64"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "quote 1.0.4 (registry+https://github.com/rust-lang/crates.io-index)",
 "wasm-bindgen-macro-support 0.2.64 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "wasm-bindgen-macro-support"
version = "0.2.64"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "proc-macro2 1.0.18 (registry+https://github.com/rust-lang/crates.io-index)",
 "quote 1.0.4 (registry+https://github.com/rust-lang/crates.io-index)",
 "syn 1.0.33 (registry+https://github.com/rust-lang/crates.io-index)",
 "wasm-bindgen-backend 0.2.64 (registry+https://github.com/rust-lang/crates.io-index)",
 "wasm-bindgen-shared 0.2.64 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "wasm-bindgen-shared"
version = "0.2.64"
source = "registry+https://github.com/rust-lang/crates.io-index"

[[package]]
name = "web-sys"
version = "0.3.39"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "js-sys 0.3.39 (registry+https://github.com/rust-lang/crates.io-index)",
 "wasm-bindgen 0.2.64 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "winapi"
version = "0.3.8"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
 "winapi-i686-pc-windows-gnu 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)",
 "winapi-x86_64-pc-windows-gnu 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)",
]

[[package]]
name = "winapi-i686-pc-windows-gnu"
version = "0.4.0"
source = "registry+https://github.com/rust-lang/crates.io-index"

[[package]]
name = "winapi-x86_64-pc-windows-gnu"
version = "0.4.0"
source = "registry+https://github.com/rust-lang/crates.io-index"

[[package]]
name = "xml-rs"
version = "0.8.3"
source = "registry+https://github.com/rust-lang/crates.io-index"

[metadata]
"checksum bumpalo 3.2.1 (registry+https://github.com/rust-lang/crates.io-index)" = "12ae9db68ad7fac5fe51304d20f016c911539251075a214f8e663babefa35187"
"checksum cfg-if 0.1.10 (registry+https://github.com/rust-lang/crates.io-index)" = "4785bdd1c96b2a846b2bd7cc02e86b6b3dbf14e7e53446c4f54c92a361040822"
"checksum console_error_panic_hook 0.1.6 (registry+https://github.com/rust-lang/crates.io-index)" = "b8d976903543e0c48546a91908f21588a680a8c8f984df9a5d69feccb2b2a211"
"checksum gl_generator 0.13.1 (registry+https://github.com/rust-lang/crates.io-index)" = "ca98bbde17256e02d17336a6bdb5a50f7d0ccacee502e191d3e3d0ec2f96f84a"
"checksum glow 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)" = "31aed196700daf16e1241d819ff4a4855a78ee0cddb051948d50b9213deec82f"
"checksum js-sys 0.3.39 (registry+https://github.com/rust-lang/crates.io-index)" = "fa5a448de267e7358beaf4a5d849518fe9a0c13fce7afd44b06e68550e5562a7"
"checksum khronos_api 3.1.0 (registry+https://github.com/rust-lang/crates.io-index)" = "e2db585e1d738fc771bf08a151420d3ed193d9d895a36df7f6f8a9456b911ddc"
"checksum lazy_static 1.4.0 (registry+https://github.com/rust-lang/crates.io-index)" = "e2abad23fbc42b3700f2f279844dc832adb2b2eb069b2df918f455c4e18cc646"
"checksum libc 0.2.69 (registry+https://github.com/rust-lang/crates.io-index)" = "99e85c08494b21a9054e7fe1374a732aeadaff3980b6990b94bfd3a70f690005"
"checksum log 0.4.8 (registry+https://github.com/rust-lang/crates.io-index)" = "14b6052be84e6b71ab17edffc2eeabf5c2c3ae1fdb464aae35ac50c67a44e1f7"
"checksum malloc_buf 0.0.6 (registry+https://github.com/rust-lang/crates.io-index)" = "62bb907fe88d54d8d9ce32a3cceab4218ed2f6b7d35617cafe9adf84e43919cb"
"checksum objc 0.2.7 (registry+https://github.com/rust-lang/crates.io-index)" = "915b1b472bc21c53464d6c8461c9d3af805ba1ef837e1cac254428f4a77177b1"
"checksum proc-macro2 1.0.18 (registry+https://github.com/rust-lang/crates.io-index)" = "beae6331a816b1f65d04c45b078fd8e6c93e8071771f41b8163255bbd8d7c8fa"
"checksum quote 1.0.4 (registry+https://github.com/rust-lang/crates.io-index)" = "4c1f4b0efa5fc5e8ceb705136bfee52cfdb6a4e3509f770b478cd6ed434232a7"
"checksum raw-window-handle 0.3.3 (registry+https://github.com/rust-lang/crates.io-index)" = "0a441a7a6c80ad6473bd4b74ec1c9a4c951794285bf941c2126f607c72e48211"
"checksum slotmap 0.3.0 (registry+https://github.com/rust-lang/crates.io-index)" = "759fd553261805f128e2900bf69ab3d034260bc338caf7f0ee54dbf035c85acd"
"checksum syn 1.0.33 (registry+https://github.com/rust-lang/crates.io-index)" = "e8d5d96e8cbb005d6959f119f773bfaebb5684296108fb32600c00cde305b2cd"
"checksum unicode-xid 0.2.0 (registry+https://github.com/rust-lang/crates.io-index)" = "826e7639553986605ec5979c7dd957c7895e93eabed50ab2ffa7f6128a75097c"
"checksum wasm-bindgen 0.2.64 (registry+https://github.com/rust-lang/crates.io-index)" = "6a634620115e4a229108b71bde263bb4220c483b3f07f5ba514ee8d15064c4c2"
"checksum wasm-bindgen-backend 0.2.64 (registry+https://github.com/rust-lang/crates.io-index)" = "3e53963b583d18a5aa3aaae4b4c1cb535218246131ba22a71f05b518098571df"
"checksum wasm-bindgen-macro 0.2.64 (registry+https://github.com/rust-lang/crates.io-index)" = "3fcfd5ef6eec85623b4c6e844293d4516470d8f19cd72d0d12246017eb9060b8"
"checksum wasm-bindgen-macro-support 0.2.64 (registry+https://github.com/rust-lang/crates.io-index)" = "9adff9ee0e94b926ca81b57f57f86d5545cdcb1d259e21ec9bdd95b901754c75"
"checksum wasm-bindgen-shared 0.2.64 (registry+https://github.com/rust-lang/crates.io-index)" = "7f7b90ea6c632dd06fd765d44542e234d5e63d9bb917ecd64d79778a13bd79ae"
"checksum web-sys 0.3.39 (registry+https://github.com/rust-lang/crates.io-index)" = "8bc359e5dd3b46cb9687a051d50a2fdd228e4ba7cf6fcf861a5365c3d671a642"
"checksum winapi 0.3.8 (registry+https://github.com/rust-lang/crates.io-index)" = "8093091eeb260906a183e6ae1abdba2ef5ef2257a21801128899c3fc699229c6"
"checksum winapi-i686-pc-windows-gnu 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)" = "ac3b87c63620426dd9b991e5ce0329eff545bccbbb34f3be09ff6fb6ab51b7b6"
"checksum winapi-x86_64-pc-windows-gnu 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)" = "712e227841d057c1ee1cd2fb22fa7e5a5461ae8e48fa2ca79ec42cfc1931183f"
"checksum xml-rs 0.8.3 (registry+https://github.com/rust-lang/crates.io-index)" = "b07db065a5cf61a7e4ba64f29e67db906fb1787316516c4e6e5ff0fea1efcd8a"

Thanks for the additional info. Hmm.. I'm running on Catalina 10.15.5. I wonder if somehow I've introduced code that only works on Catalina? I'll have to think about and research what could be going wrong here.

I could update to Catalina but I've been quite disappointed with recent OSX releases (there's nothing new worthy of the time/risk to upgrade).

Catalina has been frustrating. I haven't hit any major bugs, but in general the security model gets in the way of much of what I want to do. I updated out of curiosity, but it is probably the wiser choice to stay behind for now.
My goal with kApp is that it will get more stable as time goes on so it's ok to aim for stability on the most recent release, but a crash on Mojave feels a bit too recent for my tastes. I'll see if I can get a VM setup to replicate it.

@waylandc I believe I've fixed the issue. The NSView for the window was being allocated but not initialized. Definitely a real bug and not just a discrepancy between versions, just for some reason it wouldn't crash on Catalina. Thanks for reporting!
Here's the fix: https://github.com/kettle11/kApp/commit/bbd0db376529145cde1b9e830c8dc6d43ccd400f
If you have time would you mind pulling master again and seeing if the issue is fixed for you?

works now, thanks for looking at this quickly. I'll definitely be watching this interesting project.


deprecation warning for :CACHE_ROOT in config.build.cache_dir

This is a 🐞 bug fix.
This is a 🙋♂ feature or enhancement.

[ ] I've added tests (if it's a bug, feature or enhancement)
[ ] I've adjusted the documentation (if it's a feature or enhancement)
[x] The test suite passes (run bundle exec rspec to verify this)

Summary
For users migrating from v1 to v2, they'll neeed update the terraspace app.rb cache_dir value if they have configured the setting. They will need to remove :CACHE_ROOT.
This PR provides a warning message about :CACHE_ROOT removal from config.build.cache_dir to user.
Context
https://community.boltops.com/t/migration-from-v1-to-v2-update-the-terraspace-app-rb-cache-dir-value/926/2
How to Test
Run sanity check
Version Changes
Patch

Released in 2.1.3


Feature - expand all rows

Added a method to expand all rows. This removes the need to loop through and call expandRowForItem: on each root item. The method does everything in one batch update, making it much faster than looping as well, based on my testing.
Also added a method to expand all rows with a RATreeViewRowAnimation as a parameter. The other method uses the default expand animation.

Any chance this could get merged in? Any thoughts/concerns?

@IMcD23 Thanks for PR :+1:
I like the idea of the PR but I would modify the public API that is provided by it. I think that we should expand functionality of the expandRowForItem:, expandRowForItem:withRowAnimation: and expandRowForItem:expandChildren:withRowAnimation: (also modify collapse methods so they works for item equal to nil) methods so that all tree can be expanded if we pass nil as item and YES and expandChildren parameter. That would allow us to keep the public API in its current state.
What do you think about that idea?

I like that idea. I'll take a look into adding the ability to put in a nil item into the expand and collapse methods. That only makes sense to me, however, as an additional way of doing it. I feel as if most people won't think that passing a nil tree node to expand will actually mean to expand every tree node.
It's up to you with what way you want to do, but I think it would probably work best to either allow both ways, or just the way I have in this PR.
Also, I think no matter what, the expandsChildrenOnLoad property should be kept. This allows the user to have it always expand without calling any additional functions.

So this functionality isn't added? Why Is this closed? How to expand all rows at start?


fine-tune on VQA

Hi,
Thanks for your code. I want to use VLBERT to fine-tune on VQA dataset. The pretrained weights have 12-layer parameters. But in config file of VQA task, the number of layers is only 4. Can you provide more details about how to load pretrained weights and fine-tune on VQA?
Thank you.

It is actually 12 layers for base model and 24 layers for large model. Please see the config yaml under the folder cfgs/vqa, e.g., https://github.com/jackroos/VL-BERT/blob/2ff7a65ac475b5e863e4dd5ab6792caeb7e1b1b4/cfgs/vqa/base_4x16G_fp32.yaml#L71.
For how to fine-tune the network for VQA, please see fine-tuning instructions in README. Thanks!

Hi I'm also encountering an "issue" with fine-tuning on vqa, it seems that by default the model is trained on the train2014 + val2014 images and questions but val2014 is also used as the validation split. Why is that? Shouldn't the validation set bet holdout from training so that it gives independent information on which epoch model to choose for evaluation on test?

@jules-samaran Following other's practice, we train on train+val split, and evaluate our model on test-dev and test-std by submitting to the VQA evaluation server. You can following the instructions on README for how to evaluate on test set. Thank you!


Integration Test Maintenance

:tada: This PR is included in version 5.2.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Unable to locate credentials retrieved by ibmcloud

For an enhanced user experience, the ibmcloud command-line tool and ibm-cos-sdk Python library should be seamlessly interoperable.
If the service credentials are retrieved using
ibmcloud resource service-key my-service-credentials --output JSON > ~/.bluemix/cos_credentials

The resource creation command gives a ConfigParseError:
>>> cos = ibm_boto3.resource("s3")
ConfigParseError: Unable to parse config file: ~/.bluemix/cos_credentials

That happens because the JSON object written by ibmcloud is a list with only one JSON object, while ibm-cos-sdk is expecting a dictionary. Hence the error AttributeError: 'list' object has no attribute 'keys'.
To circumvent this, one can parse the JSON list with jq and use
ibmcloud resource service-key my-service-credentials --output JSON | jq '.[0]' > ~/.bluemix/cos_credentials

That yields a successful
>>> cos = ibm_boto3.resource("s3")

but then fails when I call get_buckets():
>>> get_buckets()
Retrieving list of buckets
Unable to retrieve list buckets: Unable to locate credentials

I can only make it work by copying and pasting the contents of the service credentials JSON file into ibm_boto3.resource() as shown here.

Thanks for taking the time to raise this ticket and provide a detailed explanation.
I've spoken with the SDK architects, we've added this enhancement to the list of items to be considered in the next major version release.
If you are happy with this resolution please close the ticket, otherwise please let me know any further questions/issues you have.

Thanks @stephenskinner for the feedback!


Crons django-celery-beat timezone glitch

How do you use Sentry?
Sentry Saas (sentry.io)
Version
1.29.2
Steps to Reproduce

Setup django-celery-beat
Create a Periodic task via the admin and set a wacked timezone for it
setup Sentry with CeleryIntegration(monitor_beat_tasks=True),
See the resulting cron monitor in sentry

The current implementation of the _get_monitor_config helper does not consider for the posibility that the schedule might be coming from django_celery_beat (this is understandable since this is all new).
Here is the implementation for it
https://django-celery-beat.readthedocs.io/en/latest/_modules/django_celery_beat/tzcrontab.html#TzAwareCrontab
which has a timezone property. The resulting schedule could have a different timezone from app.conf.timezone and could be per-schedule.
We traced it to here https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/integrations/celery.py#L447 and think that considering that schedule could be an instance of TzAwareCrontab would be the way to go.
Not sure how you would like to code the possible import failure of django_celery_beat and so on, so stopped there.
Expected Result
Expectation is that the cron monitor in sentry has the Americas/Chicago timezone we have setup in django admin for our task
Actual Result
The task cron monitor in sentry has Americas/Los_Angeles as timezone as that is the app.conf.timezone

Adding a screenshot for clarity just in case

Hey @avilaton !
Thanks for reporting this. I put it on our backlog.

@antonpirker I've seen a number of reports about this actually. Let's see if we can't get this more heavily prioritized?

@evanpurkhiser I can take a look at this next week.

@evanpurkhiser the list of timezones in django-celery-beat has values in it, that are not in Sentry's list of timezones:
timezones-django-celery-beat.txt
When I select a timezone that is not available in Sentry's list, then the timezone -- shows up in Sentry's UI.
Is there a way we can map those non existing timezones?


[collab-galley] Add pkg/config/meshcfg

Adds an event source for publishing mesh config. The file-based meshconfig handling is modeled as a regular event source.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio_auth_sds_e2e

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test istio_auth_sds_e2e

prow/integ-pilot-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-pilot-k8s-presubmit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test istio_auth_sds_e2e

prow/integ-pilot-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-pilot-k8s-presubmit-tests

prow/integ-security-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-security-k8s-presubmit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test istio_auth_sds_e2e

prow/integ-pilot-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-pilot-k8s-presubmit-tests

prow/integ-security-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-security-k8s-presubmit-tests

prow/integ-framework-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-framework-k8s-presubmit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test istio_auth_sds_e2e

prow/integ-pilot-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-pilot-k8s-presubmit-tests

prow/integ-security-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-security-k8s-presubmit-tests

prow/integ-framework-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-framework-k8s-presubmit-tests

prow/e2e-dashboard.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test istio_auth_sds_e2e

prow/integ-pilot-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-pilot-k8s-presubmit-tests

prow/integ-security-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-security-k8s-presubmit-tests

prow/integ-framework-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-framework-k8s-presubmit-tests

prow/e2e-dashboard.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test istio_auth_sds_e2e

prow/integ-pilot-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-pilot-k8s-presubmit-tests

prow/integ-security-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-security-k8s-presubmit-tests

prow/integ-framework-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-framework-k8s-presubmit-tests

prow/e2e-dashboard.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/integ-istioctl-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-istioctl-k8s-presubmit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test istio_auth_sds_e2e

prow/integ-pilot-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-pilot-k8s-presubmit-tests

prow/integ-security-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-security-k8s-presubmit-tests

prow/integ-framework-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-framework-k8s-presubmit-tests

prow/e2e-dashboard.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/integ-istioctl-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-istioctl-k8s-presubmit-tests

prow/integ-galley-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-galley-k8s-presubmit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test istio_auth_sds_e2e

prow/integ-pilot-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-pilot-k8s-presubmit-tests

prow/integ-security-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-security-k8s-presubmit-tests

prow/integ-framework-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-framework-k8s-presubmit-tests

prow/e2e-dashboard.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/integ-istioctl-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-istioctl-k8s-presubmit-tests

prow/integ-galley-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-galley-k8s-presubmit-tests

prow/integ-telemetry-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-telemetry-k8s-presubmit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-pilot-k8s-presubmit-tests

prow/integ-security-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-security-k8s-presubmit-tests

prow/integ-framework-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-framework-k8s-presubmit-tests

prow/e2e-dashboard.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/integ-istioctl-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-istioctl-k8s-presubmit-tests

prow/integ-galley-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-galley-k8s-presubmit-tests

prow/integ-telemetry-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-telemetry-k8s-presubmit-tests

prow/e2e-simpleTests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [geeknoid,ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [geeknoid,ozevren]
pilot/OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-security-k8s-presubmit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
dadb34d713ebff13bb73e32df8b2c2d092a8f8e6
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-security-k8s-presubmit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
dadb34d713ebff13bb73e32df8b2c2d092a8f8e6
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
dadb34d713ebff13bb73e32df8b2c2d092a8f8e6
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test integ-security-k8s-presubmit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
695a0d8035a4997e20fe5886b1d23bca8c4c3f54
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
dadb34d713ebff13bb73e32df8b2c2d092a8f8e6
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
dadb34d713ebff13bb73e32df8b2c2d092a8f8e6
link
/test e2e-simpleTests

prow/istio-pilot-multicluster-e2e.sh
dadb34d713ebff13bb73e32df8b2c2d092a8f8e6
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

nk
/test e2e-simpleTests

/test istio-pilot-e2e-envoyv2-v1alpha3

/test e2e-simpleTests

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [geeknoid,ozevren]
pilot/OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


SAKIII-5022 dont add spacing to carousel if not needed

https://jira.sakaiproject.org/browse/SAKIII-5022

Squashed and merged


Validate inputs for queries

Description/Reasoning
We should validate inputs (strings etc.) for our queries as a sanity check.
Current Behaviour
Expected Behaviour
Steps to reproduce (for bugs)
Relevant Logs or Files

are we not doing that?


error with nuget

I tried to install the nuget package via the package manager but when I am trying to do so I get the following error
Install failed. Rolling back...
Package 'Plugin.BLE.1.0.0-beta4' does not exist in project 'BluetoothToggleWidget'
Package 'Plugin.BLE.1.0.0-beta4' does not exist in folder 'C:\Users\sebastienj\Documents\WORK\MyStuff\XamarinBLETest\Xamarin\AndroidChat\packages'
Install-Package : Failed to add reference to 'Plugin.BLE.Abstractions'.
At line:1 char:1

Install-Package Plugin.BLE -Pre

  + CategoryInfo          : NotSpecified: (:) [Install-Package], Exception
  + FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PackageManagement.PowerShellCmdlets.InstallPackageCommand

Can you please fix it?

Attempting to gather dependency information for package 'Plugin.BLE.1.0.0-beta4' with respect to project 'App1', targeting 'MonoAndroid,Version=v6.0.99'
Attempting to resolve dependencies for package 'Plugin.BLE.1.0.0-beta4' with DependencyBehavior 'Lowest'
Resolving actions to install package 'Plugin.BLE.1.0.0-beta4'
Resolved actions to install package 'Plugin.BLE.1.0.0-beta4'
GET https://www.nuget.org/api/v2/package/Plugin.BLE/1.0.0-beta4
OK https://www.nuget.org/api/v2/package/Plugin.BLE/1.0.0-beta4 1276ms
Installing Plugin.BLE 1.0.0-beta4.
Adding package 'Plugin.BLE.1.0.0-beta4' to folder 'C:\Projekte\Temp\App1\packages'
Added package 'Plugin.BLE.1.0.0-beta4' to folder 'C:\Projekte\Temp\App1\packages'
Added package 'Plugin.BLE.1.0.0-beta4' to 'packages.config'
Successfully installed 'Plugin.BLE 1.0.0-beta4' to App1

It's working here. So you have to provide some more information. :)

@sebastienjouhans What's the status of this issue? Is it still occuring for you?

I'm guessing this has been solved. Will close.


Issue Page 213

In the paper book, city.ts is defined as:
export interface City {
id: number,
name: string,
lat: string,
lon: string
}
Serialization to decimal of (lat and lon) fails, correct interface is:
export interface City {
id: number,
name: string,
lat: number,
lon: number
}
The code is correct on this repository

Thanks for the tip, I sent it to the editor so that they will update the paperback and e-book version accordingly.


Please add a license file

I'd like to add this to awesome-zsh-plugins, but it doesn't have a license file.
Please add a license file - if you don't have one in mind,  I recommend using choosealicense.com to help choose an appropriate one.
Thanks!

Ok, I added a MIT LICENSE. I think you can use my zsh theme now.


Add more about how to counter quantum computers

Make it clear that if you are adding post-quantum crypto, add it as new layer since there's a non-trivial risk of complete breakage. Include a note about SIKE, where this has already occurred.

I got an out-of-band response from Hart Montgomery that this looks good. We can always improve this further, but telling people these basics now seems like the right thing to do.


Removed problematic local executor specification

Related to https://github.com/nextflow-io/nextflow/issues/693#issuecomment-391792952 and https://github.com/nf-core/cookiecutter/issues/30

@ewels, I think this PR is faulty? Feel free to close this one if you agree.

Faulty how? Looks good to me!

The tests are failing because the travis config hasn’t been set up yet (its blank).

Ok, if you think it looks good, then I'm pleased! I just thought it was one of those other cases where there were no "script" defined so that it would actually make sense to force it to run locally?

In this case it's fine to have executor 'local' because the process execute groovy code, not an bash script. Removing the localexecutor it will print a warning message when running the workflow in a cluster/cloud.

Yes, I didn't read far enough down the diff to realise that it was an exec not a script. The process name has been updated in other repos to use a script and run as a regular process, so I think it's fine to remove it like this, as we'll almost certainly update it further in the future.
Thanks for the clarification though @pditommaso! 👍


Builds failing due tslint crash using nightly build

Looks like it was introduced by 9df1ed4dd32408fcaa92d031d1f3ff6468506b95
Repro

From an initialized TypeScript repo (i.e. you've already run npm install within it), run npm install<EMAIL_ADDRESS>Run jake lint.

Expected: No lint errors.
Actual:
$ jake lint
jake aborted.
TypeError: Cannot read property 'name' of undefined
    at getPropertySymbolsFromBaseTypes (C:\Users\drosen\TypeScript2\node_modules\typescript\lib\typescript.js:49945:73)
    at getPropertySymbolFromTypeReference (C:\Users\drosen\TypeScript2\node_modules\typescript\lib\typescript.js:49970:29)

@yuit can you look into this?

The fix is pretty trivial. Just remove the symbol && in getPropertySymbolsFromBaseTypes and add a guard to the top like
if (!symbol) {
    return;
}

I just don't know what a solid repro is.

CC: @adidahiya @JKillian  - you might be interested as well

If it helps, it seems to occur when linting src/compiler/utilities.ts and calling getPropertySymbolsFromBaseTypes with "getCanonicalFileName" as a property name.

Thanks for the heads-up @DickvdBrink. If anything needs changing/investigating in TSLint I'll do it ASAP.

Made the change suggested by @DanielRosenwasser and added a test case over in https://github.com/Microsoft/TypeScript/pull/6507.
I reverted https://github.com/Microsoft/TypeScript/commit/62c3bfb1fb6714fc383379caae8b55d81bf62fbe as requested as well, but of course that will make the CI fail for the PR, as the CI is now using the previous nightly which still contains the bug.

Thanks a ton @JKillian we really appreciate it. I'll perform the revert tonight/tomorrow morning.


Include git_current_branch function to remove OMZ dependancy

The git_current_branch function is actually a part of OMZ.  For those of us that don't use OhMyZsh, this needs to be included separately.
🐛 for #1

Thanks 👏


Feedback on Demo Performance

Hi there!
I noticed that the performance is a bit slow in the demo. It might be worth looking into that.
I believe your project has huge potential, and many people have been waiting for something like this for years.
Best of luck!

Hi, thank you for your feedback. I know there is performance drawback compared to the Forms version of the same viewer. I tried to optimize it and I tried different method to render a  page and convert it to presentable image. I replaced the original solution with a better one but still not ideal. If you have any idea how to improve the performance let me know.

maybe this can help
https://weblog.west-wind.com/posts/2024/Jan/03/Working-around-the-WPF-ImageSource-Blues

I read the article, which gives a hint for async loading the image.
Actually there is an easier way to do it with IsAsync binding, I tried it before but for me it gave me worse user experience. I was able to scroll quickly but the pages loaded asyc with a delay, so first blank pages later the page appearad. I decided to keep the blocking loading for now.
The underlaying lib render the image which I need to convert to ImageSource to be able to present in WPF. I have no change to improve the rendering of the image by the lib, but I worked on different method to convert it to image source. I just added a method from nth-user's branch which seems to work fine and it avoids the memory isses. I also reduced the rendering size to the display size, which gave me additional 25% speed. Give it a try to the latest version.

Indeed Performace has improved a lot
Many Thanks


malformed clang::SourceRange results in kaskara-statement-finder abort

From the following log output, we can see that the getEndLoc() component of the  DEBUG statement below refers to line 0, column 0, which results in an abort, due to improper length calculation from file offset.
DEBUG: obtained statement location: /workspace/source/catalog.c@2157:4::0:0
terminate called after throwing an instance of 'std::length_error'
  what():  basic_string::_M_create
/opt/kaskara/scripts/kaskara-statement-finder: line 5:    58 Aborted                 (core dumped) /opt/kaskara/bin/kaskara-statement-finder "$@"

With the location information above, we can see that the length calculation on ./lib/kaskara/clang/backend/src/util.cpp @ 61 would be negative.
 56 std::string read_source(clang::SourceManager const &SM,
 57                         clang::SourceRange const &range)
 58 {
 59   clang::SourceLocation loc_start = range.getBegin();
 60   clang::SourceLocation loc_end = range.getEnd();
 61   int length = SM.getFileOffset(loc_end) - SM.getFileOffset(loc_start);
 62   const char *buff = SM.getCharacterData(loc_start);
 63   return llvm::StringRef(buff, length + 1).str();
 64 }

Looking at this specific source file: catalog.c @ line 2157:
2152 static const xmlChar *
2153 xmlParseSGMLCatalogComment(const xmlChar *cur) {
2154     if ((cur[0] != '-') || (cur[1] != '-'))
2155         return(cur);
2156     SKIP(2);
2157     while ((cur[0] != 0) && ((cur[0] != '-') || ((cur[1] != '-'))))
2158         NEXT;
2159     if (cur[0] == 0) {
2160         return(NULL);
2161     }
2162     return(cur + 2);
2163 }
2164


Config stage should check cache_dir exists

I was trying to use the --cache-dir option (currently unreleased) in latest HEAD but getting permission denied at the end of the job when it tries to write the cache.zip
FATAL: mkdir ../../../../../../../Volumes/My Shared Files: permission denied
Failed to create cache

Turns out I had the wrong path configured in config_args but I think the driver should exit with error if the path does not exist.

Which macOS version and Tart VM image are you using? Tart's directory mounting feature requires both host and guest to run at least macOS 13 (Ventura).

Both host and guest are Ventura 13.3
ProductName:		macOS
ProductVersion:		13.3
BuildVersion:		22E252


Add missing await in the loadConfiguration docs

Changes
Very small docs improvement.
Testing
N/A
Docs
loadConfiguration returns a Promise but the code example was missing an await.

Ship it!


merge locon to checkpoint

is there a tutorial or guide to merge locon into checkpoint?

We are planning to do some tutorial for these things

Wonderful, cannot wait to give it a try

I need to support merge for all kind of my model first XD
before making the tutorial


can't use WebSocket hook

Whenever I try to open a WebSocket from the client to the server, if I use ws:// the connection just stalls indefinitely, and if I use wss:// I get WebSocket connection to wss://localhost:5173/ws failed: on the client, and (node:5790) Warning: An error event has already been emitted on the socket. Please use the destroy method on the socket while handling a 'clientError' event. on the server. Here's my +page.svelte:

Welcome to SvelteKit

Visit kit.svelte.dev to read the documentation

And here's my hooks.server.ts:
import type { WebSocketHandler } from "svelte-adapter-bun";

export const handleWebsocket: WebSocketHandler = {
	open(ws) {
		ws.send("test");
	},
	upgrade(request, upgradeFn) {
		const url = new URL(request.url);
		return url.pathname.startsWith("/ws") ? upgradeFn(request) : false;
	},
	message(ws, message) {
		ws.send(message);
	},
};

I reproduced your code and it works for me... Did you build the app? It doesn't run in dev mode
// hooks.server.ts
import type { WebSocketHandler } from "svelte-adapter-bun";

export const handleWebsocket: WebSocketHandler = {
    open(ws) {
        ws.send("test");
        console.log("ws opened");
    },
    upgrade(request, upgradeFn) {
        const url = new URL(request.url);
        return url.pathname.startsWith("/ws") ? upgradeFn(request) : false;
    },
    message(ws, message) {
        ws.send(message);
        console.log("ws message", message);
    },
};

// +page.svelte

Welcome to SvelteKit

Visit kit.svelte.dev to read the documentation

oh sorry, I didn't see that it doesn't work in devmode. building it works. thanks!


Use Hubblo Debian packages for Debian/Ubuntu setup

This pull request modify the commands mentioned in docs_src/tutorials/installation-linux.md, pointing to the Debian Bookworm and Debian Bullseye packages available with the Scaphandre 1.0.0 release.

For recent Debian (i..e testing and unstable, but not yet in stable Debian) and derivatives, you might also want to add the option of simply doing sudo apt install scaphandre, as the project has been packaged officially for Debian since a month.

Debian has a development tracking package and a user-oriented page for scaphandre

That's great, thanks a lot for this work @jonassmedegaard !

https://github.com/hubblo-org/scaphandre/blob/dev/docs_src/tutorials/installation-linux.md#debianubuntu


Provide Full Updated Code

I've noticed a common failure case is that Claude goes to edit a file but does not provide the full updated code. It's like "to be done" or even worse its discarding things because it puts "keep all functions below this"
Need to give stricter prompting to provide full updated code. Might even need to append to every prompt instead of just putting in system or tool instructions.

I think this is a limitation of all LLMS.. it is like they are lazy or programmed specifically to abridge or only give changes vs being verbose and through.  I struggle with this with all LLMS.  I would like to find the ultimate prompt for this but have yet to find it.

I've had this problem arise constantly today.
I even start all my chats with the tool like
"When providing your solution, provide a full code solution. Add to the existing code or update it. DO NOT Remove existing functionality. Do not delete existing code."
It will still offer to delete 500 lines of code and replacing it with one new function.
I tell it no, and ask it to provide a full solution.
It acknowledges it, but still refuses to give the full solution.
This has definitely something to do with the length of the file contents, but it is surprisingly stubborn not wanting to output the whole thing.
With smaller files, it works most of the time.

This is almost certainly due to your file being too large. I recommend changing your provider to Anthropic if it's not already, since it's able to output a max of 8192 tokens while OpenRouter/Bedrock are limited to 4096. Another thing you can try is breaking your file into multiple smaller files. In any case, I'm about to release v1.1.0 that has stricter instructions around not truncating files, so please give these things a try and let me know if you still run into issues.

This is almost certainly due to your file being too large. I recommend changing your provider to Anthropic if it's not already, since it's able to output a max of 8192 tokens while OpenRouter/Bedrock are limited to 4096. Another thing you can try is breaking your file into multiple smaller files. In any case, I'm about to release v1.1.0 that has stricter instructions around not truncating files, so please give these things a try and let me know if you still run into issues.

Appreciate it. I will be testing these out today and reporting back.

When I'm using normal Claude I get good results from just adding "Provide full updated code" at the end of each prompt.
I think one issue with the agentic approach is that you can't go back in the conversation and re-prompt. LLMs, once they make a mistake a few times in a row, tend to get "stuck" because now they are in a state space where mistakes are part of the potential output.
It almost might make sense to have a recovery mechanism where you ask for a concise update on what went wrong, revert state to before the issue, and append the update to the prompt instead of just directly moving forward.

When I'm using normal Claude I get good results from just adding "Provide full updated code" at the end of each prompt.
I think one issue with the agentic approach is that you can't go back in the conversation and re-prompt. LLMs, once they make a mistake a few times in a row, tend to get "stuck" because now they are in a state space where mistakes are part of the potential output.
It almost might make sense to have a recovery mechanism where you ask for a concise update on what went wrong, revert state to before the issue, and append the update to the prompt instead of just directly moving forward.

I am getting great results with Anthropic-Claude as well.

That is a great suggestion @CiberNin! Closing this ticket for now since I want to move all lazy coding related discussions to #14, please see this comment.

Hi ya - Comparing the behaviour of Claude-dev with both openAI and anthropic I see that their approach is, that as new lines are added to the text input box, the box increases in height but after a specific height it then brings up a scroll bar. Do you think that is a plausible feature to add.
Great work by the way :)


Frontend web development html css js

Description 📜
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes #issue_number_here

Type of change 📝

[ ] Au#dio (Should be in mp3 format Includes speech clarity, Concise, Low distortion)
[ ] Vi#deo (Animations, screen-recordings, presentations, and regular explanatory films are all possibilities, etc)
[x] Doc#umentation (Content Creation in the form of codes or tutorials)
[ ] Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

[x] Frontend Dev #HTML/CSS/JS

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[x] I'm a GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@Knighthawk-Leo please review this PR for issue #7708

Almost 77% of Palgiazrized

Can't I add credits? I saw in some merged repo they added credits @2024-SANDHYA
I took help of the first website

Can't I add credits? I saw in some merged repo they added credits @2024-SANDHYA I took help of the first website

What'll be the use of that if you've copy-pasted only, we can refer to that site rather than this repo. Getting my point? Plagiarized content won't be accepted in any form, no matter if you add links or not. Take reference but don't copy-paste.


Design Meeting Notes, 3/17/2023

Stricter Type Arguments With instanceof and Private-in Checks
https://github.com/microsoft/TypeScript/pull/49863

Usually, instanceof will narrow down to an instance type where all type parameters are replaced with any.

Very loose behavior.

Roughly, this PR makes it so that we replace with the type parameter constraint.

Or never as the lower-bound occasionally.

Why is using the constraint wrong in contravariant positions?

Because you don't respect what the actual type is.

An existential would help here.
Newest changes in the PR make it so:

covariant type parameters fall back to the constraint
contravariant type parameters go back to never
invariant types are a...shrug-off. Falls back to the constraint.
bivariant or independent is any

Note: new PR narrows instanceof Array to any[].

Also, this doesn't fix Array.isArray which still narrows you to any[].
Is Array something that should hold this back?

It is very weird that everything except for Array gets better.
Unclear if it should be the enemy of "better".
But any is way more consistent than picking the wrong type - we can explain the current behavior.

We can make things better and explain "yes, we would like to fix those other cases."

Aside - this is allowed and doesn't do what you think it does:

if (y instanceof Array<string>)

Should disallow it.

But you can always add a layer of indirection.
const lool = Array<string>;
if (y instanceof lool) {
  // ...
}

A simple syntactic check is probably good enough here.

Did not find many breaks when run unconditionally.

We need to re-run with the newest changes that checks variance.

Invariant would get you unknown, even if there was a constriant!

Can we bring this in under an existing flag?

This is arguably an implicit any that's always been around.

Does the PR make the any instantiations introduced by the bivariant anys?

No.

But it's a strictness flag!

But how do you get some other type apart from any anyhow?
For independent type variables, that shouldn't be an error because it's unwitnessable.

Current PR uses any if bivariant - what if we always use the constraint in those cases?

Doesn't introduce any anys.
Well...if you're bivariant, you're probably at least contravariant (if not invariant).

No, bivariant implies pure bivariance* - covariant usages push you out of bivariant.
So you're really contravariant.

Covariant, invariant, unwitnessed, those should be the constraint.
Contravariant, bivariant, those should be never.

Conclusion: let's try to make this something that doesn't introduce any new implicit anys. See if we can fit it under either noImplicitAny or a new strict flag if necessary.

Prepare script

Idea: add a prepare script to package.json

hereby LKG && hereby clean
Do we need the clean?

Possibly not.

Pre-pack, pre-publish
When installing a package from git types, file types
Nice for installing from git, off of forks, etc.
LKGs are done on release-*.* branches.

Now there could be a divergence between LKG and whatever gets built.

Could do this only on the main branch.
npm install would run this too though.

@weswigham's comment is also a good reference here: https://github.com/microsoft/TypeScript/pull/49863#discussion_r1140608783


[Feature Request]: Update the login page

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description

I can make the login ui much better,,,
dont forget to add the labels...
thanks:)
Use Case
I can make the login ui professional, modern and sleek rather and make it much better than the current basic buttons for the login
Benefits
No response
Add ScreenShots
No response
Priority
Medium
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

Is there an existing issue for this?

[x]  I have searched the existing issues

Feature Description
 I can make the login ui much better,,, dont forget to add the labels... thanks:)
Use Case
I can make the login ui professional, modern and sleek rather and make it much better than the current basic buttons for the login
Benefits
No response
Add ScreenShots
No response
Priority
Medium
Record

[x]  I have read the Contributing Guidelines
[x]  I'm a GSSOC'24 contributor
[x]  I have starred the repository

Hello @NK-Works, Go for it
All the Best


Feature Request Add support for --host option to gather metrics

It would be great if we could use the built in wifi on esp32 devices to gather these metrics without having to have the dedicated USB connection. the meshtastic CLI supports using the --host flag to connect to a radio that has wifi enabled. I can possibly modify the script for my needs but would like to see it added to your upstream. Happy to beta test this as well and provide feedback.
https://meshtastic.org/docs/software/python/cli/
--host HOST
The hostname/ipaddr of the device to connect to (over TCP).
Usage
meshtastic --host HOST
Thanks!

I will add this option.

I second this, looking forward to it. Thank you @cordelster !

I have pushed to associated issue branch changes. See if they work for you. Added "-m ip" for method, use "-p 192.168.x.x" for your device IP.
./mesh_metrics.sh -f example.lst -p <IP_ADDRESS>  -m ip
https://github.com/cordelster/mesh-metrics/tree/6-feature-request-add-support-for-host-option-to-gather-metrics


GrpcBackedSubscriptionQueryMessage overwrites update type with initial response type

Basic information
The GrpcBackedSubscriptionQueryMessage overwrites the type of UpdateResponseType with the type of the initial response.
This breaks subscription queries where these types are different.

Axon Framework version: 4.5.15 and up
JDK version:  11, 17
Complete executable reproducer if available (e.g. GitHub Repo):
Updated unit test
Fork with test and potential fix

Steps to reproduce
Simply modify the SubscriptionMessageSerializerTest to reflect this scenario. The test covers the idea of the problem, but it fails to detect it, as in the original test, both response types are identical (int.class).
The test should be modified so that both response types are different. For example:
 @Test
    void testSubscriptionQueryMessage() {
        GenericSubscriptionQueryMessage<String, String, Integer> message = new GenericSubscriptionQueryMessage<>(
                "query",
                "MyQueryName",
                instanceOf(String.class),
                instanceOf(int.class));
        SubscriptionQuery grpcMessage = testSubject.serialize(message);
        SubscriptionQueryMessage<Object, Object, Object> deserialized = testSubject.deserialize(grpcMessage);
        assertEquals(message.getIdentifier(), deserialized.getIdentifier());
        assertEquals(message.getPayload(), deserialized.getPayload());
        assertEquals(message.getPayloadType(), deserialized.getPayloadType());
        assertEquals(message.getMetaData(), deserialized.getMetaData());
        assertEquals(message.getQueryName(), deserialized.getQueryName());
        assertTrue(message.getResponseType().matches(deserialized.getResponseType().responseMessagePayloadType()));
        assertTrue(message.getUpdateResponseType()
                          .matches(deserialized.getUpdateResponseType().responseMessagePayloadType()));
    }

This test will fail.

Expected behaviour
The AxonServerQueryBus deserializes Grpc subscriptions before handing them over to the QueryUpdateEmitter for registration.
In the deserialization step, the deserialized message should have the same response types as the Grpc message.
So the test above should not fail.

Actual behaviour
In the deserialization step, the deserialized message will have its update response type set to the type of the initial response.
The test fails. In practice, type casting errors can occur when the UpdateEmitter attempts to emit updates.
Fix
Fix in fork
I think the issue is caused in GrpcBackedSubscriptionQueryMessage
Original:
   public GrpcBackedSubscriptionQueryMessage(SubscriptionQuery subscriptionQuery,
                                              Serializer messageSerializer,
                                              Serializer serializer) {
        this(
                subscriptionQuery,
                new GrpcBackedQueryMessage<>(subscriptionQuery.getQueryRequest(), messageSerializer, serializer),
                new LazyDeserializingObject<>(
                        new GrpcSerializedObject(subscriptionQuery.getQueryRequest().getResponseType()), serializer
                )
        );
    }

The creation of the LazyDeserializerObject accesses subscriptionQuery.getQueryRequest().getResponseType(). Replacing this with subscriptionQuery.getUpdateResponseType() appears to fix the issue:
    public GrpcBackedSubscriptionQueryMessage(SubscriptionQuery subscriptionQuery,
                                              Serializer messageSerializer,
                                              Serializer serializer) {
        this(
                subscriptionQuery,
                new GrpcBackedQueryMessage<>(subscriptionQuery.getQueryRequest(), messageSerializer, serializer),
                new LazyDeserializingObject<>(
                        new GrpcSerializedObject(subscriptionQuery.getUpdateResponseType()), serializer
                )
        );
    }

Will submit pull request.

I created an executable test to replicate the issue in an application.
https://github.com/heutelbeck/axon-issue2331
The test uses testcontainers to set up an AxonServer and demonstrates how the problem would manifest itself in an application.
The test also runs on GitHub Actions. And the failure can be observed in this run:

Thanks for the detailed scenario explanation and issue replicating sample, @heutelbeck!
We've went through the issue and agree you've found (and solved) a bug here.
What strikes me, is that you found this only now, while the feature's here for a long time.
I find it hard to deduce whether you're truly the first one noticing this, perhaps not meriting yet another patch release just before we finish 4.6.0.
So, for the time being, I've put it on milestone 4.6.0.
If you have any assumptions to add on the why you're the first to spot this, @heutelbeck, please do share!

Thanks, @smcvb. I am happy to contribute and good to know that I was not wrong.
I think this was a pretty hidden issue. The issue only appears when the query is deserialized in the same line, it is handed over to the emitter:
 UpdateHandlerRegistration<Object> updateHandler =
                    updateEmitter.registerUpdateHandler(subscriptionSerializer.deserialize(query), 1024);

So, the bug is only visible inside the UpdateEmitter.
However, the SimpleUpdateEmitter never validates the type before sending the update to the sink.
So maybe alongside the fix, an additional check for the type may be reasonable as well.
Take a look at where the predicate supplied by the projection is checked:
https://github.com/AxonFramework/AxonFramework/blob/5c3ab8802173ff7b2c9ee049a8297c2c3f908ba4/messaging/src/main/java/org/axonframework/queryhandling/SimpleQueryUpdateEmitter.java#L179
Here, an additional Filter may be appropriate to also check for a match between the update response type supplied by the query and the actual type of the update supplied by the projection.
The current implementation simply does not check for this. And just by happy accident, due to type erasure, if the developer attempts to emit the correct type, nothing goes wrong.
So I think if somebody encountered this problem, they just reasoned that they must return the correct type. And also, I guess rarely does someone use the same query class with two different update response types. I can see use cases for that, though.
In my case, I had to do explicit reasoning about the return types when implementing a custom update emitter for securing the stream of updates at runtime: https://github.com/heutelbeck/sapl-extensions/blob/main/sapl-axon/src/main/java/io/sapl/axon/queryhandling/SaplQueryUpdateEmitter.java .

Awesome, thanks for this, @heutelbeck.
I assumed it resided somewhere on the registration part, but didn't have sufficient time to investigate.
The fact you've spotted it while adopting your own QueryUpdateEmitter makes the chance other users hit this issue very small.
As such, I think it fair to point this issue and your pull request to milestone 4.6.0., especially as we plan to release it next month.
If you feel otherwise, please do let me know!

On the point of the type validation, we agree with your argument that validating the provided type through the projector is reasonable.
However, I do want to point out that this point would warrant a different pull request.
Mainly for clarity within the pull request and the subsequent documentation we achieve by having a different GitHub issue number.

Overall the validation addresses the same problem space, fixing problems when the two types in the subscription query differ. I added a matching check to the original pull request, as your message in the pull request indicated that you want to wait with emerging it. So I interpreted it as "please extend this here".

It was intended as a form of request, but definitely not a necessity.
Nonetheless, the addition is much appreciated of course. :-)

Closing this issue as the predicaments have been resolved in pull request #2332.
Thanks again for helping out here, @heutelbeck!


Feature: User Mentions

Turn @ (e.g. @tsarbomba instead of @TSaR-BOMBA, basically just what is in the URL of the user's profile page) into a link to the page. Also, potentially implement some way of sending notifications to the user who was mentioned? That seems more advanced, but once we have the authentication and basic server infra down for the pronouns API, it's probably possible.

For sending notifications to that user, I would directly send a message to the user mentioned with a link to the thread, but I can see if that makes inboxes harder to manage.

I was thinking that in the popup we could add a tab called "mentions" or something that would list user mentions (possibly a desktop notification, too?)
This is why I say it'll be easier once we implement the authentication system.

Oh, that's a pretty neat idea too! Once we resolve #22 and #23 we can probably plan that out in more detail


Long caching intervals

Describe the bug
When releasing a new version (creating a new tag on /x) the shield is outdated for a long time. Last time it took almost a week until it would update. This time it's been half an hour so far, and the change is still pending. Is there a way to force-update the badge? We publish dually on both npm and /x and it looks bad if the Deno version is always behind for days.
Reproduction
Visit https://github.com/grammyjs/grammY and look at the shields. (If it depends on the location, I know that both Germany and Norway are affected.)
SHIELDS

AS RENDERED

Note that img.shields.io sets a header cache-control: max-age=300, s-maxage=300 but shield.deno.dev does not. I assume that GitHub caches the shields much longer if it is being allowed to.


Terra Bridge IBC transfer from Atom from COSMOS to TERRA does not work.

Hello,
Via terra bridge I have sent ATOM to my Terra wallet. Here is the transaction code: 45F121408A6519641F556344E42E6CFBFE5C4FDC11CE94EFD16BADDC55DD0D7A
I couldn't receive it. Can you help?

your transaction in queue. You can see https://www.mintscan.io/cosmos/relayers/channel-299 the pending relayer TXs. Wait and your TX will find the destination or get back to the cosmos. Just wait.

great, thank you so much.

Hello @cvitelli Kindly chat with one of our support agent to get a quicker response on live chat CLICK HERE

great, thank you so much.

Hello, Kindly chat with one of our support agent on live chat to get a quicker response CLICK HERE.

Terra Ecosystems Bridge Support Team
I’ll have to refer you to the official support page with the ticket ID LUN7548
. Please reach out to Terra Ecosystems Support Team using the livechat page, the best team of dev will assist you on the issue immediately.


DynamoDB Transaction Support

Summary:
This PR adds support for DynamoDB Transactions.
Code sample:
General
const transactionPromise = await dynamoose.transaction([
  User.transaction.update({id: "user1"}, {$ADD: {balance: -100}}),
  Charge.transaction.create({userid: "user1", product: "product1", amount: 100, status: "successful"}),
  Product.transaction.update({id: "product1"}, {$ADD: {inventory: -1}}),
  Credit.transaction.delete({id: "credit1"})
]);

GitHub linked issue:
Closes #462
Type (select 1):

[ ] Bug fix
[x] Feature implementation
[ ] Documentation improvement
[ ] Testing improvement
[ ] Test added to report bug (GitHub issue #--- @---)
[ ] Something not listed here

Is this a breaking change? (select 1):

[ ] 🚨 YES 🚨
[x] No
[ ] I'm not sure

Is this ready to be merged into Dynamoose? (select 1):

[ ] Yes
[x] No

Are all the tests currently passing on this PR? (select 1):

[x] Yes
[ ] No

Other:

[x] I have searched through the GitHub pull requests to ensure this PR has not already been submitted
[x] I have updated the Dynamoose documentation (if required) given the changes I made
[x] I have added/updated the Dynamoose test cases (if required) given the changes I made
[x] I have run npm test from the root of the project directory to ensure all tests continue to pass
[x] I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
[x] All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
[x] I have confirmed that all my code changes are indented properly using 2 spaces
[x] I have filled out all fields above

I still need to write tests for this PR. Not quite sure how I'm going to do that yet since DynamoDB Local hasn't added support for transactions. Might have to do some type of AWS mock or something like that. Still undecided about that.
Also need to run some manual tests on this as well to ensure it's working correctly.

Pull Request Test Coverage Report for Build 723

26 of 27 (96.3%)  changed or added relevant lines in 2 files are covered.
6 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.1%) to 85.138%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/Model.js
25
26
96.15%

Files with Coverage Reduction
New Missed Lines
%

lib/index.js
6
89.02%

Totals

Change from base Build 721:
0.1%

Covered Lines:
1900

Relevant Lines:
2162

💛  - Coveralls

Pull Request Test Coverage Report for Build 723

26 of 27 (96.3%)  changed or added relevant lines in 2 files are covered.
6 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.1%) to 85.138%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/Model.js
25
26
96.15%

Files with Coverage Reduction
New Missed Lines
%

lib/index.js
6
89.02%

Totals

Change from base Build 721:
0.1%

Covered Lines:
1900

Relevant Lines:
2162

💛  - Coveralls

Hi @jutaz! Thanks for offering to help on this! I could for sure use some help. Currently we have 1 test failing due to the UnknownOperationException: An unknown operation was requested.. If you want to take a look at it and see what you can do just branch off of my branch fishcharlie:ddbtransactionsupport, then you can submit a PR to merge your work into my branch or something like that.
Overall, a code review would be helpful as well. Just having a second pair of eyes to look over would be great.
In terms of patching the AWS client itself. We have a method setDDB that we could take advantage of to inject a custom DynamoDB instance. Currently we don't do that for any tests yet tho, so that is why I'm a bit hesitant about it.
I also tweeted about the fact that transactions aren't support on DynamoDB Local yet. Looks like someone from AWS replied. So hopefully that put it on their radar that it's a priority.
https://twitter.com/char_fish/status/1068347718928523267

@jutaz A code review, and finishing the tests are the two things we need for this to be done. Once it gets done, I'm planning on getting a release out to NPM shortly after that is done (#464). I'd LOVE to get that done by tomorrow or this weekend. But it all depends on when those things get done.

Oh sorry. One more thing. We need to add support for ConditionCheck (https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/DynamoDB.html#transactWriteItems-property).
I know this is a huge feature for DynamoDB and one that has a lot of excitement around it. So I do want to get it out ASAP. So I MIGHT consider moving that to a future release if this other stuff drags on for too long.
At some point I'd also love to add support for .save on a model instance and having transaction support for that. But that is for sure a future release.

I'll take a look at the failing test, and if I'll be able to fix it - will submit a PR to your branch.

Overall, a code review would be helpful as well. Just having a second pair of eyes to look over would be great.

Yep, will do that as well 👍
I think that it might be worth just releasing the initial transactions support, even without ConditionCheck, even if it is a really good addition. That can be added, if I understand correctly, without any breaking changes anyway, so can be a follow up. And if the AWS local instance supports transactions by default - that will make it so much easier to test.

@jutaz Awesome! Will take a look soon and get back to you.

@jutaz Just reviewed that PR. What else needs to be done do you think to get this finalized?

What else needs to be done do you think to get this finalized?

I wasn't able to fully get to the read transaction - it seems to be failing a test that I added in
https://github.com/fishcharlie/dynamoose/pull/2 due to missing schema variable, which I'm not 100% sure on where to access it

@jutaz Just submitted a PR to your fork that should fix that. Once that gets merged in I will merge fishcharlie#2 in.

Merged that in 👍

Did you get around to doing any manual tests?

Did not get around to that just yet, but will do in the next hour.

And after that gets merged in? Any thoughts on next steps? I think we are getting close to merging.

So far it seems to be in a pretty good shape!

@jutaz Awesome! So aiming to get this out tonight at some point. Will need to wrap up a few other things for the release (#464). But should hopefully get all that done tonight.
Keep me posted on the status of manual tests.

Alrighty, getting on to test this on real stuff. Hold tight on results.

One thing that I think we should improve upon:

Currently Get transactions will return the model nested as Item, which probably isn't what we want - shouldn't we return just a model for each item?

Code to Reproduce
const dynamoose = require('./');

dynamoose.AWS.config.update({
  region: 'us-east-1'
});

var dogSchema = new dynamoose.Schema({
  ownerId: {
    type: Number,
    validate: function(v) { return v > 0; },
  },
  id: {
    type: String,
    hashKey: true,
    index: true
  },
  race: {
     type: String,
     enum: ['Golden retriever', 'Beagle']
  },
  breed: {
    type: String,
    trim: true,
    required: true
  },
  color: {
    lowercase: true,
    type: [String],
    default: ['Brown']
  },
  age: Number
});

const DogModel = dynamoose.model('Justas-transactions-test', dogSchema);

dynamoose.transaction([
  DogModel.transaction.create({id: 10000, ownerId: 1, breed: 'whatevs'}),
  DogModel.transaction.create({id: 1, race: "Beagle", ownerId: 1, breed: 'whatevs'})
])
// Already exists
.catch((err) => {
  console.error(err);
  return null;
})
.then((data) => {
  console.log('create', data);
  return dynamoose.transaction([
    DogModel.transaction.get({id: '10000'}),
    DogModel.transaction.get({id: '1'})
  ]);
}).then((data) => {
  console.log(data);
  console.log(data[0].race);
}).catch(console.error);

@jutaz Also, just reminding about https://github.com/fishcharlie/dynamoose/pull/2/files#r237941170

Any chance you could write a test for this that fails under the current situation? Then either you or I can fix it

Yep, pushing changes in a moment to my branch.

@jutaz I think this is good to go. Wanna give it one last review before I merge it?

Add ConditionCheck Support to Dynamoose Transactions: #478

@jutaz THANK YOU SOOO much for your help on this!!! I can't express how appreciative I am of your help in regards to this. ❤ the open source community.

Created issue #479 to track refactoring and removing code after DynamoDB Local adds Transaction support.

@fishcharlie Thanks to you too for maintaining this & opening this PR so quickly after the feature was announced! Looking forward to taking a bit deeper dive into codebase to try to simplify few things too. Will express my ideas via issues 😄

@jutaz Of course! I'm SUPER excited for this feature. I remember when it was announced I was super excited about it. Then they announced the on-demand, pay per request, the next day, and I still can't decide which I'm more excited for haha.
For sure submit ideas/problems/feedback via issues once you get a chance to dive in deeper!!
Will merge in soon, and get version 1.2.0 out within the next 6 hours or so (hopefully).

We should probably add a few more tests to increase the code coverage a bit more. I think a few more simple tests could help cover more cases.
https://coveralls.io/builds/20392553/source?filename=lib%2Findex.js#L211
https://coveralls.io/builds/20392553/source?filename=lib%2FModel.js#L264


Failure to use specify customer provider verification headers - 'PactffiVerifierAddCustomHeader(arg 2 expected a string'

Software versions

OS: Mac OSX 12.3
Pact Node version: 13.7.1
Node Version: 18.7.0
Other Versions<EMAIL_ADDRESS>
Issue Checklist
Please confirm the following:

[x] I have upgraded to the latest
[x] I have the read the FAQs in the Readme
[x] I have triple checked, that there are no unhandled promises in my code
[x] I have set my log level to debug and attached a log file showing the complete request/response cycle
[ ] For bonus points and virtual high fives, I have created a reproduceable git repository (see below) to illustrate the problem

Expected behaviour
Verifier to execute and apply the custom headers.
Actual behaviour
Error when executing the verifier.
PactffiVerifierAddCustomHeader(arg 2 expected a string

Steps to reproduce
Using 13.7.1 of @pact-foundation/pact-node, specify the equivalent customProviderHeaders that<EMAIL_ADDRESS>requires, execute verifier.
E.g.
  {
    customProviderHeaders: {
      'hello': 'there'
    },
  }

Relevant log files
 ● Pact Verification › validates the expectations on the "my-provider-service" provider

    PactffiVerifierAddCustomHeader(arg 2 expected a string

      32 |       : process.env.CI_COMMIT_BRANCH
      33 |
    > 34 |     const output = await verifyProvider(
         |                    ^
      35 |       {
      36 |         provider: 'my-provider-service',
      37 |         branch: branch!,

      at ../../../../../pact-provider/node_modules/@pact-foundation/pact-core/src/verifier/nativeVerifier.ts:47:9
          at Array.forEach (<anonymous>)
      at Object.verify (../../../../../pact-provider/node_modules/@pact-foundation/pact-core/src/verifier/nativeVerifier.ts:46:49)
      at Verifier.Object.<anonymous>.Verifier.verify (../../../../../pact-provider/node_modules/@pact-foundation/pact-core/src/verifier/index.ts:25:12)
      at Pact.Object.<anonymous>.Pact.verifyPacts (../../../../../pact-provider/node_modules/@pact-foundation/pact-core/src/pact.ts:156:37)
      at ../../../../../pact-provider/node_modules/@pact-foundation/src/dsl/verifier/verifier.ts:110:29
      at Object.<anonymous> (src/__tests__/pact/my-provider-service.verifier.spec.ts:34:20)

[2022-08-11 14:50:46.844 +0000] INFO (36927 on DCM-RJ6KY4W9FP<EMAIL_ADDRESS>Verifying provider
[2022-08-11 14:50:46.846 +0000] INFO (36927 on DCM-RJ6KY4W9FP<EMAIL_ADDRESS>debug request/response logging enabled
[2022-08-11 14:50:46.847 +0000] INFO (36927 on DCM-RJ6KY4W9FP<EMAIL_ADDRESS>Verifying Pacts.
[2022-08-11 14:50:46.847 +0000] INFO (36927 on DCM-RJ6KY4W9FP<EMAIL_ADDRESS>Verifying Pact Files
[2022-08-11 14:50:46.847 +0000] DEBUG (36927 on DCM-RJ6KY4W9FP<EMAIL_ADDRESS>Initalising native core at log level 'debug'

thanks to @TimothyJones for the fix, let us know how you get on @adamwitko
https://github.com/pact-foundation/pact-js-core/releases/tag/v13.7.2

Thanks folks!
I'll look at the devex for setting up the core locally next week some time.

I think this is fixed now?


Add a command palette launcher to the title bar

The quick pick family, command palette, search etc, is very powerful but often overlooked. Esp new users don't know about its keybindings are rarely discover it. The idea is to render a "launcher" in the title bar part that simply triggers quick pick, like so
https://user-images.githubusercontent.com/1794099/168265125-201d288a-29c6-41c8-ab2c-6e7b2f64569a.mov
This is related to https://github.com/microsoft/vscode/issues/115641

explore/experiment for May

/cc @daviddossett @misolori

I guess we should also consider to update the height of the title bar part, right? This is how it could look with some extra height

With https://github.com/microsoft/vscode/pull/149468 I have added support for custom hover here. @sbatten if this sticks we should also do the same for the layout switcher

https://user-images.githubusercontent.com/1794099/168294114-993d3a05-070f-44fa-bb4a-644211d90a1d.mov

I guess we should also consider to update the height of the title bar part, right? This is how it could look with some extra height

How would this look on Windows or other platforms w/ the classic menu? Would those be centered vertically?

Are we able to align the window actions vertically on macOS? Ours are still aligned to the top of the container:

I would hope so but idk where that currently comes from...

@jrieken we can control that with trafficLightPosition on BrowserWindow https://www.electronjs.org/docs/latest/api/browser-window https://github.com/microsoft/vscode/blob/2dff5deef71fed71f039f8064e4e6deb818b1e3d/src/vs/platform/windows/electron-main/window.ts#L244-L249

Reading this thread, I'm a bit confused. Was this option added? I can't find it in the settings but I see it in y'all's screenshots?

Yeah, we haven't decided how to name this thing yet. The current favourite is "command center"

now we could click the textbox to launch global search.
and we could click the combo box style to get more action,
I suggest adding another button to launching the command panel directly

The best solution may be an float panel? Is there still some tech limitation to using float panel?

Closing as the main part of the feature has been implements. More feedback is very welcome but should be filed as new issues. Issues in this feature-area a label command-center

To verify:

ensure the window.commandCenter toggles the command center


feat(spanner): Option to use GAPIC backoff strategy (#2062)

For issue #2062:

useGapicBackoffs flag for SpannerClient
unit tests to ensure that GrpcRequestWrapper passes correct options

Please wait on merging this pending @dwsupplee review. :)

Friendly ping here @dwsupplee

Thanks for the ping, I'll work on getting this released this week.


graph drawing libs

Go through these some time.
https://anvaka.github.io/graph-drawing-libraries/#!/all

mathbox based tools

https://www.math3d.org/ / https://github.com/ChristopherChudzicki/math3d-react
https://kineticgraphs.org / https://github.com/cmakler/kgjs
https://github.com/QBobWatson/ila

Random find: https://github.com/bpmn-io/bpmn-js


⚠ Bofrost.lu has degraded performance

In 6eec0a0, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1688 ms

Resolved: Bofrost.lu performance has improved in ff4ab0f after 6 minutes.


Document routing concerns for lazy engines

Document route-serializer usage in ember-engines and how it differs from behavior outside of engines.
Document change in loading behavior for failed transitions when crossing an engine boundary.

Thanks @trentmwillis!


Specify email when create applicant?

Hi.  Is there any way to specify an email when you create an applicant?  Thanks!

would also like to see this added!

This is quite easy to do if you are willing to download the source code and add it yourself, it only requires you to make a small modification to the Applicant.cs object.  I've added it and I've submitted a pull request.


--container-runtime flag still in the documentation for external etcd in version 1.27 despite removal

What happened?
Documentation for external etcd cluster for kubernetes 1.27 is not up to date
What did you expect to happen?
That the documentation doesn't take into consideration the fact that --container-runtime was removed in version 1.27 of kubelet:
https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/setup-ha-etcd-with-kubeadm/

ExecStart=/usr/bin/kubelet --address=<IP_ADDRESS> --pod-manifest-path=/etc/kubernetes/manifests --cgroup-driver=systemd --container-runtime=remote --container-runtime-endpoint=unix:///var/run/containerd/containerd.sock
Restart=always

How can we reproduce it (as minimally and precisely as possible)?
Just try to install kubernetes with an external etcd cluster (which right now doesn't work anyway also for other reasons related to this https://github.com/kubernetes/kubernetes/pull/118353) with version 1.27.2 and you'll get:

May 31 22:24:22 omni-etcd-0 kubelet[3755]: E0531 22:24:22.055640    3755 run.go:74] "command failed" err="failed to parse kubelet flag: unknown flag: --container-runtime"

Anything else we need to know?
No response
Kubernetes version

1.27.2

Cloud provider

self-hosted

OS version

# On Linux:
$ cat /etc/os-release
PRETTY_NAME="Ubuntu 22.04.2 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.2 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy
$ uname -a
Linux omni-etcd-0 5.15.0-72-generic kubernetes/kubernetes#79-Ubuntu SMP Wed Apr 19 08:22:18 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Install tools

kubeadm

Container runtime (CRI) and version (if applicable)

containerd

Related plugins (CNI, CSI, ...) and versions (if applicable)

calico

https://github.com/kubernetes/kubernetes/pull/114017 removed the comment in v1.27.
https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet/ is not re-generated.
I opened https://github.com/kubernetes/website/pull/41402 to fix it.

/retitle --container-runtime flag still in the documentation for external etcd in version 1.27 despite removal
/language en
/triage accepted


Identify image needs for the site

When [Situation]?
We have approved content for a given page
I want to [Motivation]
List out what images will be needed
So I can [Expected Outcome]
so I can request that GCPE provide them

Add a task list to support this ticket

[Meeting with Allieren]
Unsplash is ok without people. Must be photography within British Columbia.
If there is people there is a general concern about licensing and release forms.
If we need to credit photographers see example:
https://descan.ca/sample-page/thank-you-unsplash


Component text name search doesn't find children of KeepAlive

But if selecting component via dom, it does pull it up.

Hi, I'm not reproduce it, can you please provide a minimal reproduction? Thanks

Are you using functional component?

No, I don't think so. We do use RouterView, KeepAlive, and <component :is=""">. I'll have to work on an MRE.


chore: remove deprecated querystring package with URLSearchParams

Describe the bug
The querystring package has been deprecated now and should be replaced by URLSearchParams API as recommended in its documentation.

@ehmicky Should I pick this one up?

The URLSearchParams API isn't supported Node.js 12.0.0. Since there's ongoing work to upgrade the repo Node version to that in https://github.com/netlify/cli/issues/3512, I'm just leaving this open for now.

I believe URLSearchParams was added in Node 6.13.0 and made a global object in Node 10.0.0?

Just checked again. What you're saying is correct but the lint extension was reporting this:

I probably mixed up the version from another lint error which can be fixed with a polyfill:

Added the engines property for the function template. Working now.


Added demo in docs of cards for adding props to CardActionArea

[ ] I have followed (at least) the PR section of the contributing guide.

This PR consists of a new demo showcasing adding for adding props/attributes to CardActionArea components.
In this onClick behaviour select the clicked card.

This PR relates to issue: https://github.com/mui/material-ui/issues/44730

Hi all, can anyone review the PR please?

Thanks for simplifying the code @siriwatknp. Looks much clearer

@samuelsycamore Upon seeing your review comments, I have committed them. I also understood that the styles make the card look active, it not actually being active. Thanks.

Hi, @siriwatknp are there any more changes needed to be made to the documentation, if so please let me know


adding fps counter functionality

Features:

got rid of bloom parameter in the settings (not needed for our game)
added FPS counter

Constitutes as a label in the main menu (can add it to game scene once we make it)
Can be turned on and off in the settings

Its good. Just fixed fps display bug.

I noticed that after closing the first instance of the game and opening it again, I was no longer able to get fps values higher than 60 no matter what I changed the max to. I was still able to set the max to < 60, but any value > 60 would just cause the fps to cap at 60. Is anyone else able to reproduce this, or is it maybe my computer limiting the fps somehow?

I couldn't replicate it, was the vsync option on as well? That could be forcing the frames to stay at the max for your screen, if not then I have no clue

I too can't replicate this. What steps did you do to get this? My only issue is that vsync isn't working if it is suppose to work right now.

I too can't replicate this. What steps did you do to get this? My only issue is that vsync isn't working if it is suppose to work right now.

Vsync was working for me yeah, didn't test it too extensively though


Improve article 2104.09792

Exact location of issue
Please provide a link to the source article, ideally pointing to the exact piece of content containing the issue. Our documents have "id" attributes on each logical element.
Example:

Section 3 of math/0003013, where the link points to the fragment #S3.p2

Problem details
A clear and concise description of what the bug is.

is the article missing pieces of content (a section, an abstract, references?)
are there latex constructs missing support (marked in red), or supported inaccurately?
is the visual appearance flawed - pieces of content colliding, placed or sized wrongly?

Example:

Labels are missing their targets, and conversion fails abruptly.

(Optional) Expected behavior
A clear and concise description of what you think the preferred outcome should be.
Desktop (please complete the following information)

OS: [e.g. iOS, Windows, Ubuntu]
Browser [e.g. firefox, chrome, safari]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]

(Optional) Screenshots
If applicable, add screenshots to help explain your problem.
(Optional) Additional context
Add any other context about the problem here.

Actually this is a good one to investigate, thanks @hkboo - I'll reopen.

It has to do with a redefinition of \text and/or a use of pgfplots that leads latexml into an infinite loop.

This article now converts to a healthy state, using the ar5iv update generated via latexml v0.8.8


Game crashes when i put specific stage

Describe your problem here.
when i put a stage that i added it just crashes. if i use other stages it works fine. is it because i didnt put a .lua file of my backround? (idk how to turn it into lua) i dont know what to do. I have a picture of what the small window thing tells me

i dont use lua or source i just find json and lua files to put in the build im modding
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
i tried to add a lua in since i only added a json file of the backround but i couldn't do it.
EDIT: new terminal message

someone please help

i just find json and lua files to put in the build im modding

maybe because of this
you can look in the Lua Script API there are recreates of some stages, but if you need, I can make you a script

hey, its been a long time since u responded and all but like i need a script ik its late but ya srry


func: init at 3.0.3568

Motivation for this change
Adding azure-functions-core-tools func cli tool.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

closes #118708

I ran nixpkgs-fmt on pkgs/top-level/all-packages.nix
I'm okay with dropping this and leaving the formatting as is but I think we should make the format consistent and I think this is the best method..


example metrics with 2.3.0 will no longer suitable for gke 1.25 and later

As GKE dashboard shows, we need to migrate to validate version after gke upgrade to 1.25, as I checked with our own app, all APIs seems fine, but we can see all the api invalidate calls from kube-state-metrics with 2.3.0. we need to separate the version for before 1.25, or we just update the docs directly

dashboard warnings

logs in detail

I see, yes we should bump
https://github.com/GoogleCloudPlatform/prometheus-engine/blob/main/examples/kube-state-metrics/kube-state-metrics.yaml#L20 (or recommend two different versions based on GKE version)
which is being hosted in
https://cloud.google.com/stackdriver/docs/managed-prometheus/exporters/kube_state_metrics
@TheSpiritXIII happy to take over this request because GMP is WAI -- we'll just need to refresh our copy-pastable exporter configs


feat(toast): webcomponent

NOTE: Needs to use sdds-link so that one should be merged first.
NOTE: Needs to decide on how we want to handle the close of the toasts.
Describe pull-request
Webcomponent version of toast. Also renamed native story.
Solving issue
Fixes: AB#3166
How to test

Go to storybook link below.
Check in Components -> Toast -> Toast
Check that the design is aligned with figma and try out the controls.

Suggested test steps

[ ] Browser testing (Chrome, Safari, Firefox)
[ ] Keyboard operability
[ ] Interactive elements have labels.
[ ] Storybook controls
[ ] Design/controls/props is aligned with other components
[ ] Dark/light mode and variants
[ ] Input fields – values should be displayed properly
[ ] Events

Screenshots
Additional context

NOTE: Needs to decide on how we want to handle the close of the toasts.

Please bring this one to the dev check-in.