Possible fix for Plugin Crash

It was pointed out by a KiCAD developer that the self.app = wx.App() might be the problem. See issue 15520 for details.
Removing it solved the issue for me but most likely will bring back #291
So I looked at KiBuzzards source an shamelessly stole two lines from there 😅

@hansfbaier would you mind testing this against your Ubuntu 22.04 installation? I think you were the only one that had problems (at least the only one reporting it in #291)
@badrbouslikhin @octave @shuki25 can one of you confirm that this doesn't break the plugin for MacOS?
(you reported back in #295)

@HaiJin-Yun can you test this PR as well an see if it fixes your problem?

Ubuntu 22.04 Where can I download it?

On September 1st, I downloaded kicad-jlcpcb-tools-main.zip again.
I installed it using the file install option.
It is not installed.

@HaiJin-Yun Ubuntu 22.04 is the operating system, not the plugin.
You cannot download the main branch zip and install it via KiCAD PCM, that doesn't work!
As I'm also on Windows and for me the issue seems fixed I'll just wait for one of the OSX users to report back and merge the fix.

@Bouni I can confirm this branch seems to work on macOS. Haven't done much besides opening the plugin and moving between Settings and main window.
I got a few errors on the logs, but they seem unrelated to this commit.
❯ ./pcbnew
Starting plugin CircularZone
Starting plugin ViaStitching
2023.09.01 10:04:46 - DEBUG - download -  Parts db is split into 3 parts. Proceeding to download...
2023.09.01 10:04:46 - DEBUG - download -  Removing any spurios old zip part files...
2023.09.01 10:04:46 - DEBUG - download -  Removing /Users/badr/Documents/KiCad/7.0/3rdparty/plugins/com_github_bouni_kicad-jlcpcb-tools/jlcpcb/parts.db.zip.001.
2023.09.01 10:04:46 - DEBUG - download -  Download parts db chunk 1 with a size of 76.29MB
2023.09.01 10:04:52 - DEBUG - download -  Download parts db chunk 2 with a size of 76.29MB
2023.09.01 10:05:05 - DEBUG - download -  Download parts db chunk 3 with a size of 27.74MB
2023.09.01 10:05:07 - DEBUG - download -  Combining and extracting zip part files...
Traceback (most recent call last):
  File "/Users/badr/Documents/KiCad/7.0/3rdparty/plugins/com_github_bouni_kicad-jlcpcb-tools/mainwindow.py", line 556, in populate_footprint_list
    if not self.store:
AttributeError: 'JLCPCBTools' object has no attribute 'store'
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Top layer
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Silk top
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Mask top
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Paste top
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Bottom layer
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Silk top
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Mask bottom
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Paste bottom
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted Edges
2023.09.01 10:05:28 - INFO - generate_geber -  Successfully plotted V score cut
2023.09.01 10:05:28 - INFO - generate_excellon -  Finished generating Excellon files
2023.09.01 10:05:28 - INFO - zip_gerber_excellon -  Finished generating ZIP file
Traceback (most recent call last):
  File "/Users/badr/Documents/KiCad/7.0/3rdparty/plugins/com_github_bouni_kicad-jlcpcb-tools/mainwindow.py", line 915, in generate_fabrication_data
    self.fabrication.generate_cpl()
  File "/Users/badr/Documents/KiCad/7.0/3rdparty/plugins/com_github_bouni_kicad-jlcpcb-tools/fabrication.py", line 271, in generate_cpl
    for part in self.parent.store.read_pos_parts():
AttributeError: 'JLCPCBTools' object has no attribute 'store'

Bouni

Bouni You made my work very convenient.
thank you
I hope it gets resolved well.


Get Options / Delta

How do you pull Options Data and Delta information?
Also, is there a fix for error: KeyError: 'expireDateList'

I don't see Delta there from "get_options" response.

I'm sorry, in the next expiration date Delta is there:


Recomposition is not scheduled on SnapshotList change

The following code is an example of a simple ui list which support deletion on button press.
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.material.Text
import androidx.compose.material.TextButton
import androidx.compose.material.TextField
import androidx.compose.runtime.*
import androidx.compose.runtime.snapshots.SnapshotStateList
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.unit.dp
import androidx.compose.ui.window.WindowState
import androidx.compose.ui.window.singleWindowApplication

data class Man(var surname: String)

@Composable
fun ShowMan(man: Man) {
    Row {
        var surname by remember { mutableStateOf(man.surname) }
        TextField(
            surname,
            onValueChange = { newAgeString: String ->
                man.surname = newAgeString
                surname = newAgeString
            })
    }
}

@Composable
fun <T> UiList(
    list: SnapshotStateList<T>,
    DisplayElement: @Composable (T) -> Unit,
) {
    @Composable
    fun DisplayRow(element: T, Button: @Composable () -> Unit) {
        Row { DisplayElement(element); Button() }
    }

    Column {
        list.forEach {
            DisplayRow(it) {
                TextButton(onClick = { list.remove(it); println(list[0]) }) {
                    Text("X", color = Color.Red)
                }
            }
        }
    }
}

@Composable
fun ManExample() {
    val men = mutableStateListOf(Man("Anne"), Man("Chris"))
    UiList(men) { man -> ShowMan(man) }
}

fun main() = singleWindowApplication(
    state = WindowState(width = 900.dp, height = 600.dp)
) { ManExample() }

On button presses, the list is updated (as the element is deleted) and thus the recomposition of UiList function must be scheduled (as it reads form list). This, however, does not happen.
This application displays two rows for people named Anne and Chris:

On pressing the first cross (to delete the person named "Anne"), the console prints "Chris" (as the first element of the remaining list); however, on the window Chris is deleted instead:

change   var surname by remember { mutableStateOf(man.surname) } to var surname by remember { mutableStateOf(man.surname) }.apply { value = man.surname }  will fix .

Inside the forEach, add a  key(it) {} around your content (and while unrelated, ideally use a specific name instead of it).

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Windows CI: No integration daemon stop

Signed-off-by: John Howard<EMAIL_ADDRESS>@jfrazelle @mikedougherty The integration daemon stop script is meaningless on Windows CI. The daemon under test is torn down through the Jenkins tear down (and setup) scripts. Rather than modify the multiple places where the .integration-daemon-stop bundle is made, putting a condition around the entire contents and a comment.

LGTM
/cc @jfrazelle

of course we'll have to update this again when doing Windows-on-Windows testing :)
LGTM

LGTM as long as janky :)

@mikedougherty Yes, we will. However, this also gets rid of Windows CI errors being logged which aren't actually errors.

all green \o/


FR: Make undo button at the top also work for drawing mode/layer

Currently when I have drawn a line and press "undo" at the top it doesn't undo the drawn line.
It would be very nice and intuitive if the undo-button at the top would also undo. The undo button with the drawing tools is a bit unintuitive as users are used to have one central undo option.

Fixed by removing the undo button at the top, thus leaving only the one, operational, undo button


[as2_motion_refence_handlers / as2_motion_controller] Add motion reference thust

Basic Info

Info
Please fill out this column

Issue(s) this addresses
-

ROS2 version tested on
Humble

Aerial platform tested on
Multirotor Simulator

Description of contribution in a few bullet points
ACRO is part of available input control mode, but motion controller didn't subscribe to thrust motion reference

Add  motion reference thrust handler
Motion controller subscribe to thrust references

The CI is failling beacuse of a gtest in the trajectory generator


Allow constructor arguments for bootstrap

Coverage remained the same at 82.101% when pulling b96a26d899cf0da6e25c1c347a5a4e465e34a82a on fix/test-utils into 8836520da717b80ccfb8db2186700094288c732f on develop.

what does this change affect?

Previously, you couldnt deploy a contract with args to its constructor.  This fixes that.  I can add a test to demo?


Please add a label containing digest of the base-image used for the build

I'd like to know what was the specific underlying base-image used during the build. Would it be possible to add a label on the produced image that reflects this?
Context: I'm trying to avoid rebuilding my own custom image, unless the base image has been updated. Right now I save that digest during the build and compare it against current registry digest, but it's a bit clunky and brittle approach. Having this as a label on the final image would be way more convenient.
I'm willing to make a PR to add this, if you'd show me in cli's code where would be a good place to extract that information during build time. My Rust is rather rusty (heh :) so it'd speed things up.
Thanks!

From a cursory inspection of the source, it looks like bluebuild doesn't really get involved in the building process itself; it generates the Containerfile and asks the build driver to use it. Which means, whatever it does in order to devise digest of the base-image, it's exposed to the same timing problem as my current solution. I haven't found a way to get that digest within the Containerfile itself either. :(
Do you think it's worthwhile to add any post-build labeling here, which might be stale? Or is that something that you don't want bluebuild to worry about?

So if what you need is a label on your image that contains the digest of the base image used to build your image, I can very easily add that to the build. We already inspect the base image for various other information.

Thanks!
...so out of curiosity, how are you handling that race condition right now?  :)

Thanks!
...so out of curiosity, how are you handling that race condition right now?  :)

There isn't a race condition. BlueBuild creates the containerfile for you and then uses that to build your image. All the inspection is done before we generate the containerfile.

I've checked the output of the generated Containerfile and it's:
FROM ghcr.io/ublue-os/aurora-dx:stable AS yaurora

If bluebuild is inspecting aurora-dx:stable before generating this, there's a small window of time between inspection and actually using the generated Containerfile, where aurora-dx:stable might be updated (by ublue-os). That's what I'm referring to as a race condition. The time window is small, but non-zero :) Maybe it hasn't been a concern on your end.
If you want to entertain this problem further, I see two approaches this can be mitigated with:

Resolve base-image outside of the Containerfile down to specific digest, use that digest in FROM line of the generated Containerfile (eg. FROM image@digest ...).
Label the image post-build, based on the produced build driver logs. That's going to be my workaround once/if https://github.com/blue-build/github-action/pull/66 gets merged.

there's a small window of time between inspection and actually using the generated Containerfile, where aurora-dx:stable might be updated (by ublue-os).

This is really not a problem since it's far less than a second from when the image is inspected and your image starts building. We can still use the digest to be sure, but this is highly unlikely to be a problem from within the CLI.

Thanks a lot for this! It really simplified my GH action :)


.npm-init.js - maybe add a common .gitignore also

perhaps this should also create a .gitignore with the common things that node devs ignore

@lholmquist @lance I've added only npm-debug.log and node_modules:
https://github.com/bucharest-gold/entente/blob/master/npm-init.js#L43-L44
Feel free to add more if needed.


Fix repeatable name re-indexing on multiple inputs

WHY
BEFORE - What was wrong? What was happening before this PR?
There was a bug in repeatable that was preventing it from properly work with multiple inputs. The new introduced code to deal with the fact that the names are setup in PHP and not JS was not complete was missing this bit to handle cases where name ends with [].
The way it was working to check if the name was already a repeatable name was broken and the field name was not properly generated.
AFTER - What is happening after this PR?
After this PR it properly parses the name.
HOW
How did you achieve that, in technical terms?
Mostly a refactor, moved the suffix handling higher in execution and worked only with non ending [], appending it later if needed.
Is it a breaking change or non-breaking change?
non
How can we test the before & after?
Go to dummy, fill one nice dummy (just mandatory and one select multiple for example in the relationships section).
Edit it, and add a new row in that section.
Check the select multiple name is broke.
Do the same with this PR, names are properly set.

Tested, confirmed - bug was there, his fixes it. Thank you 🙏


You are correct  the return type is always list of strings, even there is only one item in the list. I think it's better that keywords have only one return type, in this case a list. Because then one doesn't need write extra handling if  user have a scenario where keyword can return zero or more elements.

    You are correct  the return type is always list of strings, even there is only one item in the list. I think it's better that keywords have only one return type, in this case a list. Because then one doesn't need write extra handling if  user have a scenario where keyword can return zero or more elements.

Originally posted by @aaltat in https://github.com/MarketSquare/robotframework-browser/issues/2513#issuecomment-1370807235

Hard for me to understand what you write. Or are there no more issues? Maybe it is more understandable this way?
To my great surprise, the functions Get Count, Get Length from the library BuiltIn  are not useful for counting the elements of the list. Because, the functions count either the number of characters of the element for one element in the container and the functions count the number of elements for more than one element in the container. Return value for ${attributes} = href is 4, return value for ${attributes} = ['href', 'onclick'] is 2. In other words, in the first case the function counts the characters of one element, in the other case the function counts the number of elements of the list.

Closed. Please continue on the same issue and do not open new ones.


Docker local storage volume demo not working properly

Unable to login with jpicado account.

Fixed reading proper htpasswd file in config.yaml.
Added version: '3' in docker-compose.yaml file.

I think the examples were affected for a bug I've found at https://github.com/verdaccio/verdaccio/commit/09753cc1fa7777c9deab514ab95e8931728382ea so I guess we can close this, if still happens please open a ticket.


FStar.Pure.Break: add a utility to "break away" the VC of the continuation

While stabilizing some queries in HACL*, I wrote something similar for the STATE effect
let break () : STATE unit (fun p h -> spinoff (squash (p () h))) = ()

This worked very well to cause a VC to be split at points chosen by the programmer, to make verification more stable. In my case:
let mk_bn_to_bytes_be #t is_known_len len b res =
  push_frame ();
  if is_known_len then begin
    [@inline_let] let numb = size (numbytes t) in
    [@inline_let] let bnLen = blocks len numb in
    [@inline_let] let tmpLen = numb *! bnLen in
    let tmp = create tmpLen (u8 0) in
    if tmpLen =. len then begin
      LowStar.Ignore.ignore tmp;
      bn_to_bytes_be_ bnLen b res end
    else begin
      break(); // !!!!!!
      bn_to_bytes_be_ bnLen b tmp;
      copy res (sub tmp (tmpLen -! len) len) end end
  else begin
    [@inline_let] let numb = size (numbytes t) in
    let bnLen = blocks len numb in
    let tmpLen = numb *! bnLen in
    let tmp = create tmpLen (u8 0) in
    bn_to_bytes_be_ bnLen b tmp;
    copy res (sub tmp (tmpLen -! len) len) end;
  pop_frame ()

That single break stabilizes this proof to pass --quake 10, with an rlimit of 50, while before it had an rlimit of 250 and was still flaky.
Now, I could just say that's a common pattern/trick and document it, but for Pure it is considerably harder to do because we need to prove monotonicity of the effect. This PR is my best attempt, with a small modification in Pervasives to expose that spinoff p is really equal to p.
The interface file is not really clean, but I don't know if I can do better... the postprocess_with is there to ensure that break_wp really is fun p -> spinoff (squash (p ())), so it shouldn't add any unexpected indirection or overhead.

tests/ide failing for some reason
{"kind":"response","query-id":"2.86","status":"failure","response":[{"level":"error","number":217,"message":"  - Tactic left uninstantiated unification variable ?208 of type Type0 (reason = \"flex-flex quasi:\tlhs=Instantiating implicit argument in application\trhs=apply arg\")\n","ranges":[{"fname":"FStar.Calc.fsti","beg":[91,52],"end":[91,62]}]}]}


Database Error

Luckperms Version: 5.1.93
Minecraft version 1.16.3
Hello I don't know what happened but I was just playing in the server and it automatically signs me out and it says like this please refer in the picture
IMG: https://imgur.com/a/q89rgcD
Pastebin: https://pastebin.com/ZM0vXpYJ

The error just means luckperms cant connect to your database. either the db or lp config is wrong. If it was working before, maybe your database is just facing some down time. you can see: https://github.com/lucko/LuckPerms/wiki/Storage-system-errors


[WIP] 👷 add github action workflow

Closes #226
The workflow script is tested, here is a successful run:
https://github.com/univerone/ML-Model-CI/runs/1950020813
Set the slack webhook URL  (see https://api.slack.com/incoming-webhooks) in repo secrets setting to keep it credential

What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Does this change require updates to documentation?
Before submitting this PR, please make sure you have:

[ ] run python -m pytest tests/ and confirmed all checks still pass.
[ ] verified that any code or assets from external sources are properly credited.

remember to add a badge to the readme


Format parameter MODEUR-59

Am I right thinking that we are depending on the presence of ISSN and ISBN rather than explicitly on something being a monograph or a serial?

Yep. This is using existing checks for that. If we are to use the kb instead of counter, then the internal tables will have to be changed (and so the database structure will change and we have to reset it).


Minor Revision upgrade Needs major Mongoose Upgrade

When changing the Mongoose version to to ~ 4.0.0, you should probably use a major version upgrade.
NPM throws an error in this case if package.json of the client contains
"mongoose": "~3.8.8",
"mongoose-auto-increment": "^3.2.0",
Just a recommendation, can be easily worked around but when you should not force a major mongoose upgrade in a minor mongoose-auto-increment upgrade.

Yeah this behaviour seems incorrect (and Mongoose 4.0 is marked as not for production yet so probably should stick to 3.x for now).

Sorry, I'm having the same error. How do you fix this?

same here?

Sorry guys. My mistake. I will take care of this as soon as I'm back from lunch ;)
In the meantime you can simply depend on any version older than the current one.

Im  getting this with my package.json as follows?
"mongoose": "~3.8",
"mongoose-auto-increment": "^3.0.8",
why would this all of a sudden break?
npm ERR! Darwin 14.0.0
npm ERR! argv "node" "/usr/local/bin/npm" "install"
npm ERR! node v0.12.0
npm ERR! npm  v2.5.1
npm ERR! code EPEERINVALID
npm ERR! peerinvalid The package mongoose does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>

Okay, I reverted back to Mongoose 3.8.12 and pushed a new version up under<EMAIL_ADDRESS>This should remove the dependency on mongoose 4.0 for anyone who runs a simple npm update. There is also a<EMAIL_ADDRESS>which uses mongoose 4.0.0 (It's just coincidence that the version is the same as mongoose's latest version).


Standalone Boilerplate

the starwars data in boilerplate is fetched from external data from other server, i hope it could be modified to be a simpler one that just fetching data from the project route itself.

Agreed. Depending on what the user is building, querying an external endpoint may actually be fitting. For example if a user has an existing Java backend and only wants to scaffold a frontend.

I updated Bati so that when installing telefunc, it also adds a todolist example showcasing its usage.

Makes sense, as the user will then most likely want to fetch local data.

or probably add both, fetching data locally and externally woul be good ideas, because fetching the data locally, since onBeforeRender is running in server by default, some people might get confused on how to fetch the data because in client, the url origin is available by default, but then in server, the url origin is undefined which cause error for some people.
to retrieve the url origin, i had to combine res.protocol and res.hostname

to retrieve the url origin, i had to combine req.protocol and req.hostname

What do you mean by that?

to retrieve the url origin, i had to combine req.protocol and req.hostname

What do you mean by that?

i'm trying to fetch data locally in onBeforeRender, example is fetch("/mypath/endpoint") but this got error of no address asociated with hostname /mypath/endpoint and i had to use fetch("http://localhost:3000/mypath/endpoint")
pageContext in onBeforeRender had undefined url hostname, i had to modify pageContextInit in express-entry.ts to add new property
const pageContextInit = {
  urlOrigin: `${req.protocol}://${req.hostname}`
}

this way i could do fetch(pageContext.urlOrigin + "/mypath/endpoint")
i hope the boilerplate would show me a proper way of fetching data locally.

You should usually not call fetch in onBeforeRender to retrieve localhost information.
The only use case for which it's valid is when the API you're calling ("/mypath/endpoint" in your example) is defined by a different app that run on the same machine, but I'll assume that it's not the case here.
You should try to generate a boilerplate with --telefunc, or check https://github.com/brillout/vite-plugin-ssr/tree/main/examples/telefunc-v1/pages/index

Adding some reasons why calling fetch on localhost from the server is a bad idea:

Full network loop with a request + response (with potential mismatch on Origin, Hostname, Protocol, Headers, etc.)
Unnecessary serialization
Typing is lost

that's why i hope the boilerplate could show the proper way to get data locally in the same app

Fair enough. It will be added in the near future when presets or wizard are added.


bpf, hubble: explicitly mark trace reason as "unknown" when relevant

So far, the "reason" for a trace would be set to 0 when not known at an observability point in the datapath. This was problematic, because 0 is also a valid value for a specific reason (CT_NEW). As a result, the monitor package had to explicitly filter the observability points, based on whether they are supposed to provide a valid reason or not.
Instead, we can simply mark the reason as "unknown" when we ignore its value. This makes it straightforward to ignore an unknown reason when decoding the trace in Hubble.
This is in the context of https://github.com/cilium/cilium/pull/19185, which should be rebased on top, should this PR be accepted and merged.
Cc: @gandro [Note: Contrary to our offline discussion, I did not attempt to shift the values of the existing reasons and to assign 0 as the unknown trace reason, because I figured this would introduce some complications when upgrading/downgrading Cilium (regarding the states stored in the Conntrack table).]

/test

Thank you Quentin!

/test

/test

GKE failure looks unrelated (seems to be https://github.com/cilium/cilium/issues/17307).

Sebastian reviewed for cilium/hubble, I'm considering this PR ready to merge.


parameterized queries

Would it be possible to have phan notify when a query is not parameterized?

Can you give an example statement you'd like Phan to pick up?

$username = $_GET['username'];

$query = "SELECT pid from users where username = '$username'";
mysql_conenct(....);
mysql_query($query);

The above code will produce an sql injection.  99% of SQL injections will be stopped by using parameterized queries.
Some more info here: http://php.net/manual/en/security.database.sql-injection.php

another example would be INSERTing user input directly into the database (parameterized or not) and then using it as trusted data as part of SELECTs later.

I think we're going to have to leave this one to another project to handle. Adding a SQL parser is out of scope.


Remove "*instal" aliases from bash completion

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

Remove all command aliases ending in "instal" (single letter L) from the bash completion. This has the practical effect of removing the aliases "instal" and "uninstal" from bash completion, allowing "install" and "uninstall" to be auto completed once the first three characters of each "ins" or "uni" are typed in.
This makes bash completion for "uninstall" complete with a following space on the first tab instead of offering two different versions of the same command.
Addresses #3051

@rhwood Thanks for the PR! FYI for future if you're happy to open a PR for an issue you don't need to create an issue first.

Thanks for your contribution to Homebrew, @rhwood!  You rock!


Rename deprecated macros

rename deprecated definition and parameters
Issue: N/A
Test: N/A
Signed-off-by: Ethan Wang<EMAIL_ADDRESS>

this change is not needed. Reviewed IPLDT scan result, agreed to mark “GOOGLE” “Widevine” “PAVP” “decrypt” “Encrypted” as false hit.


fix(#3280/AWS/DeleteStack): fixed existence check

Handled pre-creation failure non-existent CloudFormation stack properly.

Q
A

Bug fix?
yes

New feature?
no

API breaks?
no

Deprecations?
no

Related tickets
resolves #3280

License
Apache 2.0

What's in this PR?

Fixed the handling of non-existent CloudFormation stack handling in AWSCommon.DeleteStackActivity by adding the corresponding validation error to the non-existent stack error handling branch on the existence check.
Why?

Because there are different errors for already deleted and never created stacks, only the former was handled before.
Additional context

Unfortunately I couldn't find any predefined error code/message for this case in https://github.com/aws/aws-sdk-go.
Checklist

[X] Implementation tested (with at least one cloud provider)
[X] Code meets the Developer Guide
~OpenAPI and Postman files updated (if needed)~
~User guide and development docs updated (if needed)~
~Related Helm chart(s) updated (if needed)~

@sagikazarmark I think so, yeah, other activities are using it inline as well, so it might be worth extracting it, but it would require a somewhat bigger refactor, because right now the activities are calling the describe and then it would have to be put up onto the workflow level and the activities should get the stacks through their input arguments.


Update README to explain how to call server

The README explains how to start lbrycrd in server mode, but does not explain how to actually call the server or provide any sample calls. It would be good if it did.

Do you think it should point to the CLI examples at lbry.tech ?

I think a quick example (getinfo is a good one) with a link to the CLI would do.

Note: do #246 when you do this one.

link to https://lbry.tech/api/blockchain when this is done as well

For review at https://github.com/lbryio/lbrycrd/tree/depends_build_all

Merged.


fix: close tmp file

Purpose of PR?:
Fixes #
close tmp file
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[ ] Bug fix. Fixes #
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Commit has unit tests
[ ] Commit has integration tests

Hey @testwill
This looks like a valid thing to do. Might I ask why did you notice this? Or were there any issues you faced in the context to get this fixed?


[NavigationCodelab] UnknownPluginException: Plugin [id: 'com.diffplug.spotless', version: '6.21.0'] was not found

Getting the following error while trying to open NavigationCodelab in Android Studio:
* Exception is:
org.gradle.api.plugins.UnknownPluginException: Plugin [id: 'com.diffplug.spotless', version: '6.21.0'] was not found in any of the following sources:
- Gradle Core Plugins (plugin is not in 'org.gradle' namespace)
- Plugin Repositories (could not resolve plugin artifact 'com.diffplug.spotless:com.diffplug.spotless.gradle.plugin:6.21.0')
  Searched in the following repositories:
Gradle Central Plugin Repository
at org.jetbrains.plugins.gradle.model.ProjectImportAction.execute(ProjectImportAction.java:125)
	at org.jetbrains.plugins.gradle.model.ProjectImportAction.execute(ProjectImportAction.java:42)

This could be closed now, it's outdated. Spotless has been updated to 6.25.0.


content inspection

Please add contentinspection as a keyword that is highlighted.  Also, can something be done to make entire interfaces 0/1, 1/1, 10/1, LA/1, LR/1, LO/1, etc show up a single color instead of multiple?
Thanks

Sure, I'll look at adding these in the next release.

Also IP address should be a single color

The first octet of IP address has the . as a different color


Need to be able to release collections of nodes that are no longer required.

We reference collections of nodes in a system using
System.onRegister
{
nodes = game.getNodes(NodeClass);
}
we should probably do the inverse in onRemove, or at least offer the functionality:
System.onRemove
{
game.releaseNodes(nodes);
}
This functionality would probably actually sit in NodesManager.release

That sounds like a good idea. You'll want reference counting on the collections in case multiple systems use the same collection.


Improve the handling of fields in DFA

This PR improves the handling of fields by filters out irrelevant fields using the type of the targets on handle ~ handle connection edges.

/gcbrun


Fix command escaping on Windows

Connects To: #2172
See MSDN Blog: Everyone quotes command line arguments the wrong way

Ref https://github.com/resin-io/etcher/issues/1399, https://github.com/resin-io/etcher/issues/1398, https://github.com/resin-io/etcher/issues/1394


Unexpected token

Hello. I use Vue 2 (Vuex) and Laravel Elixir with Browserify to compile my files.
It gives me an error message:
<template> ^ ParseError: Unexpected token
Other components in project work fine. All dependencies are up-to-date.
What am I doing wrong?

@prorockdesign I develop vue-ckeditor2 and bundle with Rollup and Webpack. I'm not use Laravel Elixir with Browserify. Can you show me code you using and I will fix it.

@prorockdesign May you missing ckeditor.js in the index.html file. vue-ckeditor2 using ckeditor external.
<script src="//cdn.ckeditor.com/4.6.2/full/ckeditor.js"></script>

or
<script src="/path/to/ckeditor.js"></script>

Thanks. I thinks it will be great idea to note about adding script tag to index file in docs.
But your solution doesn't helps me. I copied ckeditor.vue to my project folder from node_modules and now all works fine. I really don't understand the difference of the file placement for Elixir+Browserify. I didn't meet this error before.


[BUG] - Incorrect Boilerplate in American-British Translator

Describe your problem and how to reproduce it:
I was looking in to writing tests for the American British Translator project. Poking around the code in the example project, I see these routes in the test runner:
  app.route('/_api/routes/api.js')
    .get(function(req, res, next) {
      console.log('requested');
      fs.readFile(__dirname + '/routes/api.js', function(err, data) {
        if(err) return next(err);
        res.type('txt').send(data.toString());
      });
    });
  app.route('/_api/controllers/convertHandler.js')
    .get(function(req, res, next) {
      console.log('requested');
      fs.readFile(__dirname + '/controllers/convertHandler.js', function(err, data) {
        if(err) return next(err);
        res.type('txt').send(data.toString());
      });
    });

However, neither of these routes point to existing files. These appear to be the routes for the Metric-Imperial converter.
Is there another way to write the tests? The logic appears to be handled client-side, so I'm not sure how to approach this without modifying these routes to target the appropriate files. I tried fetching the translator.js file directly but got hit with a CORS.
Add a Link to the page with the problem:
Example Project Code
Live Example Project
Tell us about your browser and operating system:

Browser Name: Chrome
Browser Version: 85.0.4183.102
Operating System: Windows 10 V1909

If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):

@nhcarrigan Does #39822 solve (close) this?

Ignore that (I am unable to edit the above comment, for some reason), I just remembered the PR is targeting /learn.

I'm glad you pinged me on this though.
The api.js file was added to the boilerplate, but we neglected to clean up the erroneous convertHandler route. I'll grab @SaintPeter next time we're free to get that route removed. 😁

This should be closed with the merge of the boilerplate PR but we will need to add a commit to remove that extra route.

This will be closed when freeCodeCamp/demo-projects#23 lands. 🙂


Feature: show the current (non-default) skhd mode in process widget

Addressing https://github.com/Jean-Tinland/simple-bar/issues/205#issuecomment-1074408036, I've introduced another update to the process widget: this adds skhd mode next to the space layout IFF it's something other than the string "default".
This one requires some configuration to set up (I've added notes in the readme):

define on_enter commands in .skhdrc to call a new simple-bar bash script. This script will simply cache the given mode name, and optionally a color (default white).
enable System Preferences > Privacy & Security > Automation > skhd > ubersicht, to allow skhd to issue AppleScript commands to Ubersicht.

I've added a setting for this to the process widget settings.
The logic that determines whether to display the span for the mode name will NOT print anything if the mode name is "default". I've assumed this default since that's used in the example skhdrc provided by the author. Should this be a config setting? Show mode name regardless of name?
Do let me know if you have changes you think would be helpful for the readme/configuration/the way the script is set up.

some screenshots:
during default mode (i.e. normal operation)

(display current layout: false)

(display current layout: true)

This is great, I'll merge it soon! Thank you very much for your work :)

no problem 🙏🏾


Ruby snippets

Ruby snippets

Hi @reshmabidikar couple of endpoints are missing the respective method in the Ruby client, have added them here https://github.com/killbill/killbill-client-ruby/issues/88


Looking for Python NN repo

Hey Matthew, great hands-on workshop on the 19th April. Spoke to you after the tutorial and you mentioned how this repo is based on Python code. Couldn't find it; could you share it here?
Thanks.

Hey Mori! I've pasted the python tutorial that I build the workshop off of in the Workshop meetup page which you can find here: https://www.meetup.com/torontojs/events/bqlmqpyzfbqb/


s/Dismissable/Dismissible/

The Dismissable widget is misspelled.

...I could have sworn I fixed that already once.


feat: add client identifying metadata for apollo studio analytics

Description
Adds a metadata header to graphql requests that names the client, allowing requests to be broken down by client in the apollo studio analytics suite. (apollo docs)
My only concern is that this would mean we're sending user numbers to the external analytics suite. I don't think this would be a problem, but I'd like sign off from @srconway as to whether that passes GDPR muster on our side.

Motivation and Context
This will allow us to tell which clients are producing the highest volume or longest running requests, allowing us to more easily locate bugs or targets for optimisation.
By including the user number where available my hope is that we can identify future occurances of https://github.com/UserOfficeProject/issue-tracker/issues/1094 with much greater ease too.

How Has This Been Tested

Using local browser dev tools to verify that the headers are set on requests to the backend.
Fixes

Closes UserOfficeProject/issue-tracker#1203
Changes

Depends on

Tests included/Docs Updated?

[ ] I have added tests to cover my changes.
[ ] All relevant doc has been updated

I've not looked at the code itself but on the principle of whether we can use the user ID I think it's covered by our privacy statement under "to enable administration and delivery of the service". We do specifically mention tracking visitors through Google Analytics and we ought really to look at re-wording that statement to make it a bit broader - "3rd party systems like Google Analytics". Could you raise a separate issue to look at that one but given the first statement I don't think it should prevent us adding this in to Apollo as am I right in saying that only holds the data for 12 months.

Your information may be shared with other organizations outside of STFC, only to enable administration and delivery of the services you requested or for the lawful, disclosed purposes of STFC. For example we will share information with taxis, hotels, airlines etc. as is necessary to deliver the travel and accommodation services your requested; we will share proposal details with organisations outside of STFC for proposal review or other purposes as part of internationally-funded programmes.
...
We use cookies on our website:

...
to track visitor use of our websites and to compile statistical reports on website activity to help us improve our website to make it easier for you to access the services you require.
...
We use Google Analytics to track visitor use of our websites. We have set the data retention period to the minimum available (14 months).

Hi @ACLay, did you read my message on MTeam that I sent Friday morning? Did you try the approach where we just update the request's header after the auth middleware? If that works, wouldn’t it be simpler?

Yes, I saw the message. I'll give that a try, just had a lot of meetings on friday, and we've finally somehow managed to replicate https://github.com/UserOfficeProject/issue-tracker/issues/1094 so haven't had a chance to work on this.

@janosbabik I've had a look at setting it in the backend. It can be done there but you lose some level of specificity for anonymous calls. Setting it in the frontend we can specify a value like UOP - anonymous, but if we set something like that in the backend any anonymous calls from other consumers or systems would end up in the same category. It also just feels kinda hacky to be setting a request header once we've recieved the request.

@ACLay I forgot that you have this identification from other systems. Okay, then the frontend should send it.


Added blacklist to stop offensive words

What changes does this PR introduce?
Added a blacklist for words being created.
Where should the reviewer start?
By closing their eyes until after the blacklists/en file
Has this been manually tested? How?
136843250 words without a bad word found or a crash. I dont have until the heat death of the universe to find a bad word
What GIF best describes this PR or how it makes you feel?

  I thought the blacklist was already in place, but not 100%

@corbinlc kinda but there are a lot of issues with it as pointed out by prater


Add charges

Did some reformatting so the compare isn't as great as I'd like, but here's the current state of my code. No rush, but I'd like @derac or @johnclary to take a look and review before I merge it in.

Looks good to me!


Fix processing of unset build-args during build

Fix processing of unset build-args during build
This reverts 26103.  26103 was trying to make it so that if someone did:
docker build --build-arg FOO .
and FOO wasn't set as an env var then it would pick-up FOO from the
Dockerfile's ARG cmd.  However, it went too far and removed the ability
to specify a build arg w/o any value. Meaning it required the --build-arg
param to always be in the form "name=value", and not just "name".
This PR does the right fix - it allows just "name" and it'll grab the value
from the env vars if set. If "name" isn't set in the env then it still needs
to send "name" to the server so that a warning can be printed about an
unused --build-arg. And this is why buildArgs in the options is now a
*string instead of just a string - 'nil' == mentioned but no value.
Closes #29084
Signed-off-by: Doug Davis<EMAIL_ADDRESS>

I'm a bit confused why this requires changing types around, and particularly a string pointer.
Shouldn't this just be an issue on the CLI?

@cpuguy83 I tried that but due to the way we send the data to the daemon (as a json object) we needed to support an arg having a value of "nil" - meaning it was mentioned on the cmd line but no value is associated with it.  The only way to keep the "nil" for an ARG is to have the json property be a *string. When its just a string we can't tell the different between "" meaning "just mentioned" vs "an empty string" value.

@duglin But couldn't we not send the arg at all if there's nothing to send?
E.g., user does --build-arg FOO, FOO is not set as environment variable, don't send the the argument.

@cpuguy83 the problem with not sending it all is then the user won't see the warning about specifying a build-arg that's not used in the Dockerfile.
So, for example, docker build --build-arg FOO=bar will generate:
[Warning] One or more build-args [FOO] were not consumed

if there is no ARG FOO in the Dockerfile.
I can't remember when we added the warning, but the decision was made to tell the user that they messed up by including a build-arg that's never mentioned in the Dockerfile. This would avoid them thinking that they were providing info that actually was never going to be used.
In order to keep these semantics we need to include the data that they specified it on the cmd line to the daemon.  I decided that even if there is no env var currently specified, we should still tell the use they messed up because I would expect the same results no matter what my env looked like. In both cases I specified a build-arg that isn't actually defined in the Dockerfile.
Note - this doesn't change the API at all. I made sure of that. This is just changing how we deal with the data internally to capture the 3 possible states (mentioned/no-value, "", "value").

@duglin oh
15:36:34 # github.com/docker/docker/builder/dockerfile
15:36:34 ..\..\builder\dockerfile\dispatchers.go:748: undefined: newValue
15:36:34 ..\..\builder\dockerfile\dispatchers.go:764: undefined: newValue

@cpuguy83 yea, if we were sending the data as just strings (like we do with env vars) then we could have use:  "FOO" vs "FOO=" vs "FOO=value" to differentiate between the cases.
However, even with that, we'd still probably need to use *string in the code itself because "string" can be used to represent "no value".  Unlike the env vars, that are stored in memory as a []string, we store buildArgs in a map[string]string - well, now map[string]*string.  We could store them as []string too but that would make the look-up slower.  A long time ago I tried to switch env vars to use a map too but that's a different story for another day. :-)

@vdemeester oops - push coming in a sec....
thanks!

ok fixed -sorry for being lazy

LGTM


Fix assignment issue in the init script

In a number of places, the wrong operator was used for setting server arguments (+ instead of =). This PR fixes this.

@kaiju is this project accepting PRs? There's no harm in seeing this merged, I believe.

Oof! Yes! Thank you!


Update unncessary-regular-expression (RUF055) fix to use var == value

I think this should be s == "abc". It's a minor stylistic difference (in which I think x == VALUE is more idiomatic), but it can cause actual differences due to type checking implementations, e.g. https://github.com/microsoft/pyright/issues/9093
Originally posted by @zanieb in https://github.com/astral-sh/ruff/pull/14659#discussion_r1864944451

Thanks

I'd like to work on this.

Go for it. Let me know if you need any help.


Group by file

Group results by file, then by functions, instead of the actual behavior o grouping by function only ?
It could be useful when profiling lots of functions in different files, but it can be annoying since it adds another layer to expand/collapse.
It could be an option in the application settings.
It could group only if there is multiple functions in the file, and let the other functions alone.

It will mess up with #18 if the numer of @profile decorators changes between runs. Still doable, but trickier.


fix: handle empty github repos in SCM generator (#503)

Fixes #503
I don't like not having any tests here. But adding a test would require creating an empty repo in, say, the argoproj org. Maybe we could create an argoproj-tests org @alexmt ?
At any rate, spot-check on gzur-org works, and this seems like a pretty safe change.

Just confirmed that, even if no branch has ever been created in a repo, the GitHub API returns "main" as DefaultBranch (rather than something we could detect and avoid the call, like an empty string).


install failed on Heroku.

I added the gem to my gemfile and pushed to Heroku:
remote:        You have added to the Gemfile:
remote:        * wkhtmltopdf-heroku
remote:  !
remote:  !     Failed to install gems via Bundler.
remote:  !
remote:
remote:  !     Push rejected, failed to compile Ruby app

hmm that's odd.
can you try to install it in your local environment?

I moved it out of the poduction group on my gemlist and that seemed to let it install. However the pdf generation still is not working. I get the error:
Bad wkhtmltopdf's path: /usr/local/bin/wkhtmltopdf

This is a project i have inherited at work and am moving over to Heroku so I'm not completely sure the whole configuration. Any ideas?
My gemfile consists of:
gem 'wkhtmltopdf-binary'
gem 'wicked_pdf'
gem 'wkhtmltopdf-heroku'

Does this seem correct?

it's probably conflicting with wkhtmltopdf-binary
I know both gems are setting a binary path for wicked_pdf.
could you try to remove the binary gem? Also this gem only works with cedar-14 stack (Ubuntu 14.04 LTS) you will need to use the same OS in your development environment in order to use this gem.

I removed the binary gem and I am still getting the same error. I am on the cedar-14 stack.
Weirdly the pdf generation still works in my development environment (Mac OS) without the binary gem

I found a config file in the project:
WickedPdf.config = {
  #:wkhtmltopdf => '/usr/local/bin/wkhtmltopdf',
  #:layout => "pdf.html",
  :exe_path => '/usr/local/bin/wkhtmltopdf'
}

Im assuming this is the problem. Do I need any config file for this gem to work?

you probably have the binary installed in the system.
yea, could you comment out that exe_path configuration...the heroku gem will set that for you.

Yup that fixed it. Thanks for your help!


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter warp for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.warp
   -
ERRORS:

[ ] :heavy_exclamation_mark: [E026] "{'engines': {'node'>='16'}}" is required at package.json, "{'engines':{'node'>='18'}}" is recommended
[ ] :heavy_exclamation_mark: [E033] @iobroker/adapter-core 2.6.0 specified. 3.1.4 is required as minimum, 3.1.6 is recommended. Please update dependencies at package.json
[ ] :heavy_exclamation_mark: [E036] @iobroker/testing 3.0.2 specified. 4.1.3 is required as minimum,  4.1.3 is recommended. Please update devDependencies at package.json
[ ] :heavy_exclamation_mark: [E157] js-controller 2.0.0 listed as dependency but 4.0.24 is required as minimum, 5.0.19 is recommended. Please update dependency at io-package.json.

WARNINGS:

[ ] :eyes: [W040] "keywords" within package.json should contain "ioBroker"
[ ] :eyes: [W127] Missing suggested translation into uk of "common.titleLang" in io-package.json.
[ ] :eyes: [W132] Many "common.news" found in io-package.json. Repository builder will truncate at 7 news. Please remove old news.
[ ] :eyes: [W134] Missing suggested translation into uk of "common.desc" in io-package.json.
[ ] :eyes: [W135] "common.tier" is required in io-package.json. Please check https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/objectsschema.md#adapter.
[ ] :eyes: [W154] Missing suggested translation into uk of some "common.news" in io-package.json.
[ ] :eyes: [W181] "common.license" in io-package.json is deprecated. Please define object "common.licenseInformation"
[ ] :eyes: [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
[ ] :eyes: [W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".
[ ] :eyes: [W184] "common.title" is deprecated and replaced by "common.titleLang". Please remove from io-package.json.

SUGGESTIONS:

[ ] :pushpin: [S522] Please consider migrating to admin 5 UI (jsonConfig).

Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
Suggestions reported by repository checker should be reviewed. Suggestions can be ignored due to a decision of the developer but they are reported as a hint to use a configuration which might get required in future or at least is used be most adapters. Suggestions are always optional to follow.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
Note: This issue replaces issue #132
@mcm1957 for evidence
Last update at Thu, 12 Sep 2024 08:42:33 GMT based on commit 0d1addd26d6ba16510076e1d09edb8258aa6df0f
ioBroker.repochecker 3.0.2

Issue outdated due to RECREATE request. Follow up issue #134 has been created.
This issue will be closed.
your
ioBroker Check and Service Bot


Clarification on "This risk may indicate that a different user is using the same credentials"

Hi,
I would like some clarification on the following text:
"This risk may indicate that a different user is using the same credentials."
By "different user", means a diferente person/device? Because this is supposedly done with the same credentials (user)
By "using the same credentials" means that its using the same username/email and password?  or is just the username/email necessary to trigger this?
Thanks

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 81a1385f-b90a-e7b4-8cbd-f25aeb8b3c49
Version Independent ID: d468eb75-88a9-b1aa-7fb3-19ebb4faa179
Content: What is risk? Azure AD Identity Protection - Microsoft Entra
Content Source: articles/active-directory/identity-protection/concept-identity-protection-risks.md
Service: active-directory
Sub-service: identity-protection
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

Risk detections in Azure AD Identity Protection include any identified suspicious actions related to user accounts in the directory.

@jorgemfm
Thanks for your feedback! We will investigate and update as appropriate.

@MicrosoftGuyJFlo
Thanks for your inputs
@jorgemfm
if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

@jorgemfm
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation


feat(forge create): read calldata from file

Motivation
I want to be able to deploy a contract with large constructor args. If passed via argv they are too large.
Solution
It is possible to create a transaction where the
calldata is too large to be passed via argv.
See https://wiki.debian.org/CommonErrorMessages/ArgumentListTooLong
for more information on this limitation. To make it
possible to create these large transactions, update
forge create so that it can read the calldata
from a file. Now if there is a single argument
passed to --constructor-args, it will check to
see if it is a path to a file and if there is a file
then it will read that file and parse it as a space
delimited string.
There are a security implication here, if somebody is able
to get a file on the filesystem that mirrors an actual
calldata argument, then the file could be read and used instead of
the actual argument.
An alternative solution would be to add another flag that is meant to be
a path to a file and enforce that only 1 of the flags is passed for passing through
calldata. I feel like there is a more idomatic rust solution compared to
my implementation, so open to any feedback. This should also include
doc updates so people know this feature exists

The more that I think about this, the more that I think that this functionality should be implemented via a different flag. Thoughts?

hmm, can't think of any side effects if we check whether the input is a file, but leaning towards making this a separate flag that conflicts_with = constructor-args, explicitly for reading from file, many contructor-file?
cc @gakonst

Good idea - Let's do with a separate flag "--constructor-args-path" or something similar and conflicts_with as Matt said

I've updated this PR to add the --constructor-args-path flag


relation to imgui?

Although I´m using it avidly Im not sure I understand how imgui is integrated into bgfx-python. I´m quite interested in using the docking features from imgui which seem to be available in packages such as pyimgui and dear pygui.
Is what is included in bgfx-python a wrapper around a specific version of imgui? Would it be possible (for me) to somehow use either pyimgui or pygui with bgfx-python. Any nudge in a direction on where to start would be greatly appreciated!
Thanks again for a great repository!

Thanks @SuperSimon81 for the kind words 🤗
I integrated the same ImGUI linked with the original BGFX repository. Reason is that it requires quite a lot of code to pipe ImGUI's backbuffer to BGFX one. You can se how it is done looking at dependencies/bgfx/examples/common/imgui/imgui.cpp.
The new cppyy bindings provides you with a JIT C++ compiler and all the necessary headers to access BGFX's internals, but I'm not sure about a specific ImGUI Python binding.
I've looked at pyimgui in the past as I've found it more pythonic, especially for handling primitive types like ImFloat, but I've found that I needed to heavily modify the source code to access the required internals.
Hope this will help you a bit!

Thank you. I will look into it. I´ll let you know if I make any significant progress

I´ve been fiddling with this a bit and concluded I´m out of my depth. I´ve settled on trying to make ImGui::Image work in bgfx-python. As far as I can tell the function is defined in dependencies/bgfx/examples/common/imgui/imgui.h using inline, so I thought it would be available. But ImGui.image or ImGui.Image throws an error in bgfx-python. Am I going about this the wrong way?


[request] Additional field stored w/ the apis/routes/services

Background
We have a specification on our gateway implementation requiring us to validate requests to each route/api on the gateway against the it's swagger specification before proxying it to the upstream service.
To achieve this, we need to store the swagger specification in the apis entity (routes in the proposed release) data store and retrieve it while serving a request. We faced a challenge however because table apis does not bear a field to serve this purpose thus we ended up extending it and creating an extra field in our implementation to suite the need.
The proposed new release introduces a new model with routes and services model (deprecating the apis model) which provides a better separation of concerns than the "API" entity offers. We were just about to implement our custom separation of services and routes when we found out about release 0.13.0 and plan to upgrade to it as soon as it is released.
The upgrade however means that to maintain our request validation feature, we have to carry over our changes that help us store an api's swagger specification to the routes and services model. Having given it much thought, we have found it might not be wise for us as we foresee having to do the same in future releases that change such models to integrate new features. Besides, other kong users might find value in our proposed enhancement
Proposed solution
Addition of an extra user data field in both the routes (apis for backward compatibility) and services to allow users store their custom routes/apis and/or services data that they may need in some of their custom plugins

Hi @kwahome! It's great to hear positive feedback around Routes and Services — we spent a lot of time working on the model update.
If I follow your use-case correctly, you want to have some piece of custom data associated to a route or a service. But plugins can have their configuration tables storing arbitrary plugin-specific data, and they can also store route_id/service_id/api_id to associate that data with a Route/Service/Api. This way, that custom data is attached to the Route/Service/Api via a foreign key relationship. Would it be sufficient perhaps to store your extra data in a custom plugin and associate it to the relevant entity?

Also, please be mindful that the Kong issue tracker is aimed at bug reports only. For feature requests and further discussion, I recommend opening a thread in our Kong Nation forum, in the Feature Suggestions section. Thank you!

@hishamhm Thanks for the feedback. Yes we had given some thought to the plugin solution and found it would work for us. Our only trouble was that we kind of need to enforce database constraints to ensure each endpoint has a swagger contract stored with it and the operation that adds an api/route relies on a single api call to api/routes and have all data associated to a route/api stored in that entity which would guarantee us atomicity.
Also, the right place for feature suggestions is noted. I'll move this discussion. Thank you!


e2e tests

And uses the work based of this, but with the changes required to run ABI v0.2.1 and grpc stuff
I propose:

[x] Forking proxy-wasm/test-framework into our Kuadrant org
[x] Push kuadrant branch from my fork to that and make that the "main" branch
[x] (optional) Would we rather want to have cargo declare the dependency on that branch on github, or keep it as submodule? The latter makes it easier to alter as needed, when needed; the former makes the build scripts et al tidier…

@eguzki Tried to address your questions in my responses, I hope this makes some sense. We can always hop on a call if that helps… I know this is somewhat surprising.


Custom config passed to Ream constructor is ignored

Custom config passed to Ream constructor is ignored.
Ream constructor recently started to looks like this:
class Ream extends Event {
  constructor(options, config) {

however config is always undefined there.
Steps to reproduce:
const ream = require('ream')

const app = ream({ config: false }, { entry: 'xyzzy.js' })
console.log(app.config.entry) // index.js

On a related note, https://ream.js.org/api.html#ream-options should be updated to reflect the recent API change.

:tada: This issue has been resolved in version 3.2.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Infinite loading when audio only is selected

The app is only loading infinitely when I have audio only ticked.

Sorry, I can't replicate this issue. Can you ensure that the website where the audio files are downloaded from is not blocked? Check if you can open this link in your browser: http://omam.nulldev.xyz/

I think it was temporary issue, now it's working.


Telegram Link

Hi @jackieleng, thank you so much for your awesome bot 👍
Do you have a live version and can tell me the Telegram URL (e.g. https://telegram.me/werewolfbot)?

Thanks for your interest. I re-enabled the bot (https://telegram.me/vierchanbot). I think it should work again.
Currently, the bot is extremely simple and only fetches images from one board (but this can be changed). Also, it doesn't even send you the image but just the link to the image and lets Telegram expand it for you (this can be improved probably).
I hope you find it helpful

Thanks a ton! 😀


[DOCFIX] Add test section to "Running Alluxio on Cluster with High Availability" doc

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16735/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16775/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16780/
Test PASSed.

I moved code snippets inline. @apc999 PTAL.

Reopened as #6045 to target branch-1.6


Add ceph client into controller pod

We used KET to install K8s 1.6.0 on Baremetal (Ubuntu Ubuntu 16.04.2 LTS), it works well.
Now I want to create pod with volume which is provisioned from external ceph storage cluster (seperate & outside K8s cluster). But It's seem that the official kube-controller-manager image doesn’t have rbd client installed, some workaround (from https://crondev.com/kubernetes-persistent-storage-ceph/) is using another image (update image name in /etc/kubernetes/manifests/kube-controller-manager.yaml to this one quay.io/attcomdev/kube-controller-manager:v1.6.1). I have tried follow tutorial but still get error when create pvc :

41m        43m         11        claim1       PersistentVolumeClaim                 Warning   ProvisioningFailed             persistentvolume-controller   Failed to provision volume with StorageClass "fast-rbd": failed to create rbd image: executable file not found in $PATH, command output:

Notes : I have tried "kubectl exec -ti kube-controller-manager-master-203 -n kube-system bash" and execute the "rbd" sucessfully (to make sure the new controller image already include rbd client)
Any help ? Thanks
Best Regards,
VietNC

Hi @vietwow are you sure that all of the controller-managers have been restarted with the new image?
I would recommend modifying the variable to include the new image and rerun the installer.

Hi @dkoshkin ,
I m sure, because after changing (even reboot server), I have kubectl exec into controller-manager pod, it's now ubuntu with rbd command (previous run alpine with rbd), I also check the hash of new docker image.
If my cluster was running, how do I apply this ansible change (https://github.com/apprenda/kismatic/blob/master/ansible/group_vars/all.yaml#L151)  ?
Thank you very much for your reply.
Best Regards,
VietNc

Closing due to inactivity. Feel free to reopen, or reach us through our Slack for questions.


update minskd version to 27

the minskd  version is too higher for some platforms

Unfortunately, a minimum SDK of 29 is needed as BeauTyXT uses getApplication().bindIsolatedService(). SDK 27 is Android 8.1, which is very outdated. The latest version of Android is 14. Android 8.1 does not get security updates any more. I'd advise you to get a new device.


Create the validator method

It looks like JSON Schema for PHP is the way to go.

Oops—I forgot that there needs to be a way to submit the code in question.


[Request] AI: The Somnium Files (PC Steam)

Steam
It's hookable with textractor but it'll be nice to have it on agent

We now have a script for the switch version (and soon for the second game 👀)


add ovn0 default route

Pull Request

[ ] Make sure you have followed Kube-OVN Code Style.

What type of this PR
Examples of user facing changes:
1、dual-stack cluster
2、IPv6 route for ovn0 on node is deleted in some case, so loopOvn0Check failed and kube-ovn-cni pod crash
3、ovn0 nic has already exist and will not be created again.
4、The route is added when pod change to Running state and after startWorkers. But before that, the ping check for gateway is failed since IPv6 route on node is deleted and has not been added.
5、So the route for ovn0 should be added before gateway check.

Features
Bug fixes

Which issue(s) this PR fixes
Fixes #(issue-number)

need an e2e test


fix: editorInterface methods do not reset custom sidebar anymore

Summary
Fixes https://github.com/contentful/contentful-migration/issues/173
Description
editorInterface payload can have custom sidebar configuration saved. Currently all related methods just override sidebar configuration. This PR fixes the behavior, so if sidebar configuration isn't overwritten if present in the initial payload.

@suevalov can you add tests to the editor interfaces intent at least to make sure that the tool gives an accurate summary about what will happen
here for example

@Khaledgarbaya I think it's quite accurate at the moment. In this PR we're addressing the problem that the tool does what is not intended to happen (rewrites sidebar config).
There will be an another PR which adds possibility to copy and create sidebar configuration.

:tada: This PR is included in version 0.17.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


cFE cES1702.3 and cES1703.3 Requirement Failures

The original implementation to satisfy ES requirements cES1702.3 and cES1703.3 involved making a call to the cFE platform configuration variable CFE_ES_EXCEPTION_FUNCTION within the PSP.  Changes to the PSP have now resulted in the failure of these two requirements (requirement text is provided below for reference).
cFE requirements should be satisfied within the cFE code base.
Failed requirements include:
cES1702.3 If the CPU exception was caused by the Operating System or cFE Core then the cFE shall initiate a <PLATFORM_DEFINED> response.
cES1703.3 If the Floating Point exception was caused by the OS or cFE Core then the cFE shall initiate a <PLATFORM_DEFINED> response.

Imported from trac issue 164.  Created by sstrege on 2016-05-21T15:00:07, last modified: 2019-03-05T14:58:28

Trac comment by sstrege on 2017-10-02 09:15:04:
Commit [changeset:121b378] is ready for CCB review.

Trac comment by glimes on 2016-11-08 14:17:08:
Current crop of cfe-next are all going into CFE 6.6

Trac comment by sstrege on 2017-10-05 16:29:59:
The tag <PLATFORM_DEFINED> in the requirements does not indicate the functionality will be performed at the platform layer.  Since the cFE is a multi-platform product, the platform-specific features and customization requirements for the cFE are tagged with <PLATFORM_DEFINED>.
This is why the requirements are violated.  The cFE is required to generate its own response to OS and cFE core exceptions in addition to the response defined at the PSP layer.  As seen from the implementation of CFE_ES_ProcessCoreException, there are responses that the cFE can take that cannot be done at the PSP layer.  Without requirements in place, these responses may be left untested (requirement holes).  What makes these requirements tricky is the cFE depends on the PSP to kickoff the cFE response.

Trac comment by cdknight on 2017-10-03 18:05:56:
I'm still not clear how the requirements are violated...PSP does its "<PLATFORM_DEFINED>" response to the exception, then calls (directly, via a macro-defined fn, or a fn ptr) into the cFE (a "higher layer in the stack of code") to allow it to also do whatever cFE needs to do to also clean up.
BUT I am not fond of having PSP calling cFE code in this way. Instead, what I would prefer, would be something like this, which removes any CFE-specific knowledge from the PSP:
---cfe_psp.h---
{{{
...
typedef void (*CFE_PSP_ExceptionCallback_t)(
uint32 task_id,
char *ExceptionReasonString,
CFE_PSP_ExceptionContext_t *ExceptionContext,
size_t ContextSize);
extern void CFE_PSP_SetDefaultExceptionEnvironment(
CFE_PSP_ExceptionCallback_t Callback);
...
}}}
---cfe_psp_exception.c---
{{{
CFE_PSP_ExceptionCallback_t *CFE_PSP_ExceptionCallback = NULL;
void CFE_PSP_ExceptionHook (int task_id, int vector, ESFPPC* pEsf )
{
/* ...platform-specific logic */
/*
** Call the Generic cFE routine to finish processing the exception and
** restart the cFE
*/
if(CFE_PSP_ExceptionCallback != NULL)
{
    CFE_PSP_ExceptionCallback((uint32) task_id,
        (char *) CFE_PSP_ExceptionReasonString,
        (uint32 *) &CFE_PSP_ExceptionContext,
        sizeof(CFE_PSP_ExceptionContext_t));
    /*
    ** No return to here
    */

} /* end function */
/* ... /
void CFE_PSP_SetDefaultExceptionEnvironment(CFE_PSP_ExceptionCallback_t Callback)
{
CFE_PSP_ExceptionCallback = Callback;
}
}}}
---cfe_es_api.c---
{{{
int32 CFE_ES_RegisterApp(void)
{
/...*/
/*
** Set the default exception environment
*/
CFE_PSP_SetDefaultExceptionEnvironment(
    CFE_ES_ProcessCoreException);

/.../
} /* End of CFE_ES_RegisterApp() */
}}}

Trac comment by sstrege on 2017-10-09 13:38:02:
Commit based off of the discussions/decisions from 10/6/17 CCB [changeset:2089d9b] is ready for review.

Trac comment by glimes on 2017-10-10 12:50:42:
Recommend accept.
Background thoughts: on occasion, I've seen cases where platform-specific logic does have to be pushed upward in the software stack. The canonical flow would be to have the upper layer register a callback with the lower layer at runtime; and while this is commonly done via having the upper layer do an explicit runtime call with a function pointer, locking down the callback at compile time via a macro is a useful variant. Doing it this way has the twin benefits of assuring that the callback function identity is always known, and that it can not change during a run.

Trac comment by glimes on 2017-10-10 13:22:34:
Potential replacement for the "extern void ..." line after edits:
{{{
static const SystemExceptionFunc_t my_callback =
CFE_PLATFORM_ES_EXCEPTION_FUNCTION;
}}}
Then the call is:
{{{
my_callback(...);
}}}

Trac comment by sstrege on 2017-10-10 17:12:44:
Commit (with the approved changes from the 10/10/17 CCB) [changeset:887e11f] is ready for integration to development.

Trac comment by jhageman on 2019-03-05 14:58:28:
Milestone renamed


move semantics

Why not support move semantics (move ctor and move operator=)?

The beauty of open source software. Feel free to submit a patch.
On Thu, 28 Jan 2021, 6:41 pm jackeykong<EMAIL_ADDRESS>wrote:

Why not support move semantics (move ctor and move operator=)?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/brofield/simpleini/issues/49, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACZ4MRSR6ASDPF4HGJKIXTS4EPLNANCNFSM4WWT6K6A
.

The beauty of open source software. Feel free to submit a patch.
On Thu, 28 Jan 2021, 6:41 pm jackeykong<EMAIL_ADDRESS>wrote:

Why not support move semantics (move ctor and move operator=)?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/brofield/simpleini/issues/49, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACZ4MRSR6ASDPF4HGJKIXTS4EPLNANCNFSM4WWT6K6A
.


Add separate type for validated patterns

First part of https://github.com/kframework/kore/issues/2640

Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

[ ] Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
[ ] Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
[ ] Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
[ ] Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

After parsing we do syntactic validation => TermLike VariableName
In my PR I'm adding a new type Pattern to replace this.
Do we need Pattern variable?


Assertion failed! (LATEST BUILD) SpritePolygon Creation => pressing right arrow

Microsoft Visual C++ Runtime Library
Assertion failed!
Program: ...-x-master.build\bin\cpp-tests\Debug\cpp-tests.exe
File: D:_____EGNX\EGNX_1007\EGNX_1007\en...\CCAutoP...gon.cpp
Line: 260
Expression: sv != 0 && sv != 15
For information on how your program can cause an assertion
failure, see the Visual C++ documentation on asserts
(Press Retry to debug the application - JIT must be enabled)
Abort   Retry   Ignore

some more hint (changing the resourceSize back to:
static Size resourceSize(960, 640);    <<<<<<<<<<<<<<<<<   works!!!
static Size resourceSize(1280, 720);  <<<<<<<<<<<<<<<<<   failed

Yes, I have checked the official v4, also have same problem

@halx99 Please remove the label: "needs-confirm"

Maybe a hint on the documentation is helpful?
=> Rect have to be adapt to the 2.0/"ContentScaleFactor()"


vscode-extensions.formulahendry.auto-rename-tag: init at 0.1.5

Motivation for this change
Add support for Visual Studio Code extension Auto Rename Tag
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108733 run on x86_64-linux 1

1 package built:

vscode-extensions.formulahendry.auto-rename-tag

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108733 run on x86_64-linux 1

1 package built:

vscode-extensions.formulahendry.auto-rename-tag


[Oobe] Telemetry: When specific OOBE sections are entered/exited

Summary of the Pull Request
What is this about:
Added to log for how long section was opened.
Logs are being sent on the OnNavigatedFrom event and on OOBE window closing.
What is include in the PR:
How does someone test / validate:
Quality Checklist

[ ] Linked issue: #xxx
[ ] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[ ] Binaries: Any new files are added to WXS / YML

[ ] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

It works as expected when changing section

but when closing OOBE, the last section visited is reported with a TimeOpenedMs of zero.


SFA Sampler: Failed to find lullaby texture for sampler

I am trying out sceneform (new to it and arcore as well) and added an .obj file that I downloaded. It works fine, however, I noticed all the textures were missing. I added one via the samplers in the .sfa file, however, I am getting the error:
Error: failed to find lullaby texture for sampler
I have no idea what lullaby means in this context, nor does it seem to be related to the model I downloaded.
This is the download link: https://free3d.com/3d-model/house-interior--81890.html
And here is the .sfa file, I get the error as soon as I add the sampler portion
{
   materials: [
      {
         name: "floor_texture",
         parameters: [
            {
               baseColor: "floor_uv_texture",
            },
            {
               baseColorTint: [
                  0.58819999999999995,
                  0.58819999999999995,
                  0.58819999999999995,
                  1,
               ],
            },
            {
               metallic: 1,
            },
            {
               roughness: 0.16903099999999999,
            },
            {
               opacity: null,
            },
         ],
         source: "build/sceneform_sdk/default_materials/obj_material.sfm",
      },
      {
         name: "wire_115115115",
         parameters: [
            {
               baseColor: null,
            },
            {
               baseColorTint: [
                  0.45100000000000001,
                  0.45100000000000001,
                  0.45100000000000001,
                  1,
               ],
            },
            {
               metallic: 1,
            },
            {
               roughness: 0.242536,
            },
            {
               opacity: null,
            },
         ],
         source: "build/sceneform_sdk/default_materials/obj_material.sfm",
      },
      {
         name: "texture_1",
         parameters: [
            {
               baseColor: null,
            },
            {
               baseColorTint: [
                  0.58819999999999995,
                  0.58819999999999995,
                  0.58819999999999995,
                  1,
               ],
            },
            {
               metallic: 1,
            },
            {
               roughness: 0.19803000000000001,
            },
            {
               opacity: null,
            },
         ],
         source: "build/sceneform_sdk/default_materials/obj_material.sfm",
      },
      {
         name: "crome",
         parameters: [
            {
               baseColor: null,
            },
            {
               baseColorTint: [
                  0.58819999999999995,
                  0.58819999999999995,
                  0.58819999999999995,
                  1,
               ],
            },
            {
               metallic: 1,
            },
            {
               roughness: 0.158114,
            },
            {
               opacity: null,
            },
         ],
         source: "build/sceneform_sdk/default_materials/obj_material.sfm",
      },
      {
         name: "table_wood_texture",
         parameters: [
            {
               baseColor: null,
            },
            {
               baseColorTint: [
                  0.58819999999999995,
                  0.58819999999999995,
                  0.58819999999999995,
                  1,
               ],
            },
            {
               metallic: 1,
            },
            {
               roughness: 0.208514,
            },
            {
               opacity: null,
            },
         ],
         source: "build/sceneform_sdk/default_materials/obj_material.sfm",
      },
   ],
   model: {
      attributes: [
         "Position",
         "TexCoord",
         "Orientation",
      ],
      file: "sampledata/models/house_interior/house_interior.obj",
      name: "house_interior",
      scale: 0.0040810000000000004,
      suggested_collision: {
         center: {
            x: 0,
            y: 0,
            z: 0,
         },
         size: {
            x: 1,
            y: 1,
            z: 1,
         },
         type: "Box",
      },
   },
   samplers: [
      {
          file: "sampledata/models/house_interior/floor_uv_texture.jpg",
          name: "floor_uv_texture",
          params: {
               usage_type: "Normal",
          },
          pipeline_name: "floor_uv_texture.jpg",
      },
      ],
   version: "0.51:1",
}

@Jahmale - In our 1.0 release there is a bug where we do not support adding new samplers in the sfa that are not present in the source asset.  This is why adding the sampler as you've tried isn't working.  This is fixed internally and will be available in a future release.
As a workaround, you should be able to add the texture you want to use in the .mtl file for your source asset, then delete the .sfa file and rebuild.  Specifically, under the newmtl floor_texture section, add this line map_Kd floor_uv_texture.jpg.  Then, after you delete the sfa and rebuild you should see the floor_uv_texture sampler show up and work properly.


Installation documents and example

Hi, First of all, thank you for sharing the code.  It would be nice to have a install doc and some example on how to use the tool.

Hello Sir,
could you please provide installation steps for this code?
Thanks


Injecting contexts to components

Hey,
I'm using Alt as Flux impl,
I'd like all my route's components to have some reference to the alt instance,
Preferably, i'd like to pass the alt instance to the top level Component (Router? or per route's component) but I couldn't find an elegant way to do that,
What would be the appropriate way to achieve that?
I assume I can implement the createElement hook and define the alt as a component property, but it seems like context is more appropriate as all components should have the same alt instance.
Thanks

You can render a Router inside another component.
var App = React.createClass({
  // do your context stuff or whatever you want here.
  render() {
    return <Router .../>
  }
});

@ryanflorence Are you sure ? I tried that already, Im getting
Potentially unhandled rejection [2] SyntaxError: Invalid regular expression: /^/*(.*?)$/: Stack overflow     at String.match (native)     at matchPattern (http://localhost:8080/jspm_packages/npm/react-router@1.0.0-beta2/lib/URLUtils.js:143:24)
It seems like URLs breaks when Router is not the first component.
Thanks

@ryanflorence Awesome, thanks.

Nice. I like how the Router is a component itself.
Can this be done with server side rendering as well?
We build an isomorphic app using react-router 1.0.0-beta2 and would like to share some context between parent and child components. Both are rendered by Router with routes like this:
routes =
  path        : '/'
  name        : 'Parent'
  component   : require './components/Parent'
  childRoutes : [
    name        : 'Child'
    path        : '/child'
    component   : require './components/Child'

If I understood react docs on  children ownership correctly, then rendered instances of my components are owned by the instance of Router.
Now the child context we set in parent is undefined in children, and I get warnings like this:
Warning: owner-based and parent-based contexts differ (values: `undefined` vs `3`) for key (test) while mounting Child (see: http://fb.me/react-context-by-parent)

After reading this gist I guess it's because in current version of React the context is passed from owner to owned (not from parent to child, as names of properties would suggest). In my setup parent doesn't own a child - they are both owned by router. Am I right?
Then @ryanflorence answer would solve our problem if only I could apply it server-side.


Removed BadRequestException when FeedOptions.maxItemCount is -1

This PR fixes the issue of SDK throwing BadRequestException when maxItemCount is less than 0.
https://github.com/Azure/azure-cosmosdb-java/issues/261

thanks for fixing it.
You could avoid the outer "if", might be more readable this way.
BadRequestException validationError = Utils.checkRequestOrReturnException(
    initialPageSize > 0 || initialPageSize == -1, "MaxItemCount", "Invalid MaxItemCount %s", initialPageSize);
if (validationError != null) {
    return Observable.error(validationError);
}

Yes, that seems good as well, I will do that.

Timeout issues, merging the PR as the change is unrelated to the timeout issues.


make on_lines function calls async

Can anyone watching https://github.com/p00f/nvim-ts-rainbow/issues/5 test please?

Can anyone watching https://github.com/p00f/nvim-ts-rainbow/issues/5 test please?

too async?

too async?

it doesn't colour new brackets

it doesn't colour new brackets

Let me think about this and come back to you shortly.

My "tests" for slowdown were typing random stuff.
There is no slowdown when typing random stuff wrapped inside a string.
Maybe you did really fix it and it hangs because of treesitter errors (wrong syntax)?

nvm the random stuff is a valid node

ok the above comment was for clojure, the slowdown still happens inside a string in cpp

I just tested one case where there was still a lag but significantly reduced with this PR
change it to
 on_lines = try_async(callbackfn, bufnr)}

and I'll merge this

I just tested one case where there was still a lag but significantly reduced with this PR
change it to
 on_lines = try_async(callbackfn, bufnr)}

and I'll merge this

Thank you so much!!! :D

Thank you so much!!! :D


Changes to terminology to match changes in the CLI

invitation-> request
link-> connection
keyring-> wallet
plus sample file name change

Hi, this is a project archive. Active development of Indy is taking place over here: https://github.com/hyperledger?utf8=✓&q=indy&type=&language= thank you


FATAL ERROR: JS Allocation failed - process out of memory

Hello,
execution of following code ends with 'out of memory' error:
var BuildMail = require('buildmail');

var builder = new BuildMail('text/html');
builder.setContent(new Buffer('http-equiv="Content-Type" content="text/html; charset=ISO-8859-2"\r\ntml\r'));

var stream = builder.createReadStream();
stream.pipe(process.stdout);

(it is minimal string, I've extracted from html page, that caused an error,  'http-eguiv[...]' is from <meta> tag, and 'tml' is from <\html> tag)
I've tested on two platforms:

Linux, node version: v0.12.2, buildmail 1.2.1
Windows 7, node version v0.10.29, buildmail 1.2.1

Fixed the issue (an eternal loop happened if the string ended with \r) and released as v1.2.2.