Watch mode stopped working on macOS Sierra

This is a bug that seems to happen ever since I've updated to Sierra.
Whenever I want to run Jest in --watch mode it crashes:
$ jest --watch
2016-09-22 10:49 node[79167] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2016-09-22 10:49 node[79167] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2016-09-22 10:49 node[79167] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: Error watching file for changes: EMFILE
    at exports._errnoException (util.js:1036:11)
    at FSEvent.FSWatcher._handle.onchange (fs.js:1406:11)

Tried reinstalling the node modules, checking for any updates and anything. I can't seem to reproduce it on a new project but on the other hand even if I just run an empty test suite with --testPathPattern it still crashes, so I'm guessing it's a dependency conflict somewhere. I don't have any setup files or anything, it's literally running an empty file and crashing.
I don't get any more output with --debug so not sure what else to provide to help. This does not happen with --watchman
$ node --version && npm --version && jest --version
v6.6.0
3.10.8
v15.1.1

I had the same issue.  Upgrading watchman with brew install watchman to v4.7.0 fixed it.

I'm quite confident this is not a Jest issue but either an underlying module or something else on your system. Unsure how to troubleshoot, everything is fine here on Sierra.

I also got a similar report about Sierra: https://github.com/facebookincubator/create-react-app/issues/713

@cpojer Do you have a Sierra? Have you tried 6.6.0 on it?

Per https://github.com/facebookincubator/create-react-app/issues/713#issuecomment-249197672, uninstalling Watchman fixes the issue so it’s either a problem with Watchman, or its Jest integration on Sierra.

A few other possibly related threads:
https://github.com/ember-cli/ember-cli/issues/6259
https://github.com/facebook/watchman/issues/358
Can you try any suggestions there and report back?

@gaearon I'm using node 6.6.0 on Sierra with watchman and everything is fine.

Definitely seems like a watchman/upgrading issue. I'm gonna close this out for now but happy to reopen in case this is actually a Jest problem. Since many people reported this on other projects (rn) it is unlikely though.

I do not believe I have ever had watchman installed and I just now am experiencing this issue with jest in watch mode. I also recently upgraded to macOS Sierra. My guess is watchman can help (and I will try it as a workaround) but I don't think the problem is native to having or using watchman

FWIW I don't have watchman installed and still had this bug, but deleting my node_modules folder and reinstall did the trick for me

I think it is a bit short through the corner to close this issue. Jest reports an error, so maybe the problem is in one of the dependencies which need to be updated? I removed my node_modules and reinstalled, but to no avail. I never installed watchman and even if I did, the dependencies should be coming from my package.json, not from any external program I installed.

I was thinking that fsevents is the issue. I would recommend reinstalling the node binary, wiping away all node_modules folders and doing a fresh npm install.

I installed new node binary (6.7.0), removed node_modules again, reinstalled everything but still the same error. But I guess the problem is that it is trying to watch too many files at once: http://stackoverflow.com/questions/8965606/node-and-error-emfile-too-many-open-files

The folk over on react-native fixed the too many files at once issue I think here
However for me, it was still an upgrade of watchman that fixed it.

Usually when this happens it is a sign to restart the computer. This happens frequently at FB too (unrelated to Jest) :(

Sorry to be such a pain in the *ss. I raised the ulimits as pointed out in the issue @robzolkos pointed at, but why would I need to install watchman? It is not a dependency of Jest, I just use Jest out of the box as is. This is my setup now:
14:31 $ ulimit -n
100000
14:31 $ node --version
v6.7.0
14:31 $ npm -v
3.10.3

The project contains about 45k files (including node_modules) so I don't see why it could still give me an EMFILE. I will check if installing watchman is a workaround.

@hmeerlo watchman is a file watching service built by FB to make file system operations faster. Jest will run much faster on a big repo if watchman is installed and it brings the startup overhead of Jest to practically nothing as it will only statically analyze files that have changed.

Thanx, I just checked it and it works flawless now, but there still is another issue somewhere for people who do not have watchman installed, as it is not a requirement for jest.

It's not a strict requirement but just like react-native, on big repositories with large dependency trees (lots of node modules, for example), we do recommend watchman for better performance and to avoid the problems mentioned in this issue. I would recommend your team to install it to speed up common file system operations.

@cpojer Should we document Watchman in CRA User Guide?

@gaearon Yeah, I don't think there is any problem with that. I would recommend adding it to the Jest docs as well.
I'm unsure how big the dependency tree of cra's node_modules is. If it is sufficiently large we should probably recommend watchman to most people.

FYI Even though reinstall all node_modules initially did the trick for me, seems it was temporary, borked again. But installing watchman resolved this for me.
+1 to documenting it in Jest as a recommended install.

It's unclear what the outcome of this issue is. Just now I've freshly installed Jest (with fresh node_modules) on Sierra and run into this problem, which makes --watch unusable. Is that the resolution of this issue just that Jest's watch mode does not work on Sierra? Or it only works on Node 6 with Watchman?

Do you have problems if you uninstall Watchman completely? Jets should use the Node based watcher if you do so. Do you have issues with it as well?

@gaearon I only got it to work by installing Watchman. Without Watchman, no luck.

Same here, it's without watchman that it doesn't work for me

I was having this problem using node 4.6.0 after upgrading to Sierra. After upgrading node to v6.7.0, clearing node_modules and running a new npm install, jest watch started working again. I had to both upgrade node and then clear node_modules, though; those things individually didn't fix the problem.

Mac OS Sierra (10.12.1). Node 6.7. If I don't install watchman, I get the error. Please reopen. This is a jest problem, and also creates problems when using create-react-app.

Same for me with Sierra. Installing watchman resolved the issue, but before that (and I had tried everything), I got the above error. I kept avoiding the watchman-related fixes because I had never installed it in the first place.

I'm reopening because we get reports about this in Create React App with uninstalling Watchman doing the trick. Therefore the problem is in whatever Jest uses when Watchman is disabled.

Whether or not this is a Watchman issue, it affects Jest users, and by proxy, all Create React App users. Create React App chose Jest as a runner in the hope that such issues are addressed, whether in Jest, Watchman, or any other underlying projects.
No matter whose fault this issue is, I don't think we can close it until we have clear instructions about how to fix it, and I can tell something consistent about fixing it to Create React App users.
I can't tell something as vague as "Try installing, or maybe uninstalling Watchman, whatever works" to people if tests literally don't run inside newly created projects. If some versions of Watchman are buggy or incompatible, Jest should bail out of using them. If Node crawler is buggy, Jest should fix it, or force users to install Watchman.

Just thought I'd pop in and say I'm having this same issue while using Jest through create-react-app. With watchman installed, the test runner hangs indefinitely, and without it I get the same error as the OP.
I'm running macOS 10.12.1 with the following version of Node.js, NPM, and create-react-app.
▸ node --version; and npm --version; and create-react-app --version
v7.0.0
3.10.8
create-react-app version: 0.6.0

Hey everyone,
I've been incredibly busy with a bunch of projects and was unable to spend any time on this issue. I'm sorry about that. There have a been a ton of reports here and different solutions seem to have worked for different people. I'd like to figure out what is going wrong and how to fix it, however I have not been able to reproduce this issue and it doesn't seem like there are any repro steps available in this thread either. Can somebody who ran into this spend some time trying to figure out a consistent repro that I can test locally?

My home iMac isn't experiencing these issues, so I'll see if I can repro it there.

@cpojer Just tested it, merely removing the watchman binary triggered the issue for me again. Besides that my gut feeling is that the size of the project matters.

I have the same problem & I tried all the solutions, none of them worked for me:

Delete node_modules/
Install watchman
Uninstall watchman

$ node -v && npm -v && jest --version
v6.1.0
3.8.6
v16.0.2

Yep, same for me guys installing watchman fixed it for me, thanks for all your help guys

I've started experiencing the problem right now too. Was working on a project yesterday on macOS, worked fine. Today worked on same project under windows 7, worked fine. Came home pulled the project onto macOS, failed. Will see tomorrow if it still works on windows.
Size of project has increased since yesterday.
$ node -v && npm -v && jest --version
v6.2.0
3.8.9
v16.0.2

Tried installing watchman. Failed - got the message outdated Xcode (8.0). Installed 8.1. Installed watchman. Install Succeeded.
After that the tests were running again.

I started seeing this issue after upgrading to macOS Sierra, I resolved it by installing watchman
Error
Determining test suites to run...2016-11-04 12:51 node[4311] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2016-11-04 12:51 node[4311] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2016-11-04 12:51 node[4311] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: Error watching file for changes: EMFILE
    at exports._errnoException (util.js:1026:11)
    at FSEvent.FSWatcher._handle.onchange (fs.js:1406:11)
npm ERR! Test failed.  See above for more details.

Environment
node v6.9.1
jest v16.0.2
npm v3.10.9

Unsuccessful steps

npm rebuild
rm -rf node_modules && yarn

Confirmed on Serria it's due to watchman not being installedbrew install watchman fixed it for me

Reportedly, this may fix the issue:
launchctl unload -F ~/Library/LaunchAgents/com.github.facebook.watchman.plist
watchman version

JFYI I have such problem with watchman when I run jest --watch from inside tmux.
It works like a charm outside.

One more twist on this (in a create_react_app): deleting node_modules and reinstalling with yarn install did not help. Deleting node_modules and reinstalling with npm install DID resolve the issue for me. So this issue is somehow related to number of packages and/or how yarn installs packages.

@stefaneg the problem is related to the maximum number of open files. yarn install probably results in more files therefore you run into the maximum number of files limit whereas npm install probably just stays under this limit.

launchctl unload ~/Library/LaunchAgents/com.github.facebook.watchman.plist fixed it for me

FWIW, I was getting this exact error on:
mocOS: 10.12.1
Node: 6.6.0
NPM: 3.10.3
Jest: 10.0.1
I installed watchman (via homebrew) and it resolved the error.
Bonus FWIW: Jest is awesome. So glad I gave it a second chance :)

To add more entertainment value to this. I was running into the error, inside of tmux. Tried the suggestion of running outside, and it worked, went back inside of tmux and it worked.
macOS: 10.12.1
Node: 6.9.1
yarn: 0.17.3
Jest: 17.0.2
watchman: 4.7.0

Can confirm that this issue was related to tmux. After getting the error
2016-11-04 12:51 node[4311] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2016-11-04 12:51 node[4311] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: Error watching file for changes: EMFILE
    at exports._errnoException (util.js:1026:11)
    at FSEvent.FSWatcher._handle.onchange (fs.js:1406:11)
npm ERR! Test failed.  See above for more details.

I install watchman, but continued to get the issue. Running react-native commands outside of tmux now works.

I was getting not using tmux, only iterm2..

Had the same issue on two other repos but not on another all using the same versions. Which is odd. So it might have to do with the amount of files?
macOS: 10.12.1
node: 6.9.1
npm: 3.10.8
jest: 17.0.3
using nvm for node version control
npm command is
"test:watch": "cross-env NODE_ENV=test jest --watchAll",
Tried reinstalling node_modules did not fix it.
Installing watchman fixed the issue for me.
brew install watchman
watchman: 4.7.0

Confirming the same issue. Installing watchman fixed the problem.

It seems like most people resolves this issue in one way or another and it most likely had to do with issues around OS upgrades, node modules, watchman and node. We never had a repro at FB, so it is hard to know what exactly was going on here. I'll close it as non-actionable at this point. If you are reading this in the future, please scroll up and try any of the solutions people brought up.

I also summarized a few workarounds here.

I got this issue with a new laptop, I just installed node + my project + yarn install + jest --watch and got the issue. I had to install watchman to "fix" this. Maybe it's related to the fact that yarn does not link all node_modules/.bin of submodules like npm does?

I had jest running on other projects fine, though ran in to this issue with an immediately ejected create-react-app.
brew install watchman fixed it though.

@MoOx Unfortunately at this point I don’t think we’ll figure out the root until somebody who has the issue takes the time to figure out what is happening (e.g. you could put console logs in Jest sources and its Node-based watcher).

Actually I can reproduce as soon as I uninstall watchman. Can somebody point me to the right direction so I can add some logs and paste those here?

I think that without watchman Jest falls back to Node crawler. Something in Sierra might've broken it. So maybe worth putting some logs there.

Same thing here:
$ yarn test
yarn test v0.17.0
$ react-scripts test --env=jsdom
Determining test suites to run...2017-01-04 09:58 node[9151] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2017-01-04 09:58 node[9151] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2017-01-04 09:58 node[9151] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: Error watching file for changes: EMFILE
    at exports._errnoException (util.js:1036:11)
    at FSEvent.FSWatcher._handle.onchange (fs.js:1406:11)
error Command failed with exit code 1.

iterm2 on MacOS Sierra; watchman fixed it.

Another data point: I just had this issue on Node 6.9.1, switching to 6.3.1 solved it.

Bummer that this is closed, having to dig through issues in upstream projects does make for a poor initial experience with create-react-app as noted here https://github.com/facebook/jest/issues/1767#issuecomment-256346095

As I noted above, please feel free to dig into why this happens. While this is inconvenient, this is an open source project, and you can help us. Right now I have a lot of work on React itself and unfortunately don’t have time to look into why this happens.

I will try to take a look at it and see if I can figure anything out. It definitely feels like the issue is coming from sane and may be related to this https://github.com/nodejs/node-v0.x-archive/issues/5463

@gaearon installing watchman resolved the issue for me. Thanks!

I decided to research this, as I didn't want to make people install watchman.
The error seems to be thrown by walker when it searches too many files/directories using fs.lstat. You can pass a predicate function that will ignore certain folders. (Ignoring node_modules solves the issue.)
However, walker is called by sane which doesn't have the ability to pass the ignore function. (They have recently added an ignore option, but it doesn't seem to work with nodejs-walker)
It appears a PR will need to be made to update sane to accept an ignore function and then a PR to jest to pass that to sane, and create a function based on the jest ignores. Add it in jest-haste-map here

@ro-savage thank you so much for doing this investigation. Would you be open to make a change to sane? I'm also happy to switch off of sane if you'd like to write a file-watching system directly within this repo, but that is probably a bigger challenge.

@cpojer - Already in the works. Once the changes to sane have been merged and released, I'll make a PR for jest.

That's awesome. Looking forward to it.

Something to keep in mind: it would be nice if we ignored specifically the root node_modules rather than /node_modules/ generally. See https://github.com/facebook/jest/pull/2796 and https://github.com/facebook/jest/pull/2318 for some context for why I’d like src/node_modules to still be working.
Also,

The error seems to be thrown by walker when it searches too many files/directories using fs.lstat. You can pass a predicate function that will ignore certain folders. (Ignoring node_modules solves the issue.)

sounds more like a workaround than a solution. I would like to better understand this. Yes, ignoring node_modules works around the problem because there is less files. But presumably on a large enough project you could hit this limit too. Is there a way to fix the underlying problem (“error seems to be thrown by walker when it searches too many files/directories”)?

First comment wasn't quiet clear.
The root issue isn't actually an issue with walker that works fine.
The issue is MacOS Serria + Node, how it executes fs.watch. As discussed here nodejs/node-v0.x-archive#5463
I didn't dive too deep into that, but looks like it was never fixed or possibly isn't a node issue.
Instead the fix allows walker to crawl all the directories (which is fast + works fine), it then removes everything that matches the predicate function, and sane will only attempt to attach watchers to files that aren't in the ignore.
@gaearon sane is using anymatch to decide what to ignore, which accepts regex. Therefore CRA can update its jest ignore with something that will only match node_modules at the root level.

I can in fact confirm as others have that brew install watchman works. Dang tho it'd be cool not to have to now add that step to my project's README. :-D. If there's anything I can do to help test or anything, let me know!

I have submitted PR #2957 that should fix this issue without installing watchman.
Would love for people to try it out and confirm it fixes on their systems as well. @jcreamer898 @mulchy @MoOx
Steps to test:
git clone https://github.com/ro-savage/jest.git
git checkout fix-watcher-bug-osx
yarn install
yarn build
cd packages/jest-cli
yarn link
Then go to your project that you had crashing tests in a run
yarn link "jest-cli"
Make sure you have testPathIgnorePatterns config set to includenode_modules
Run your tests as usual.
Once you're done. run yarn unlink jest-cli in the project folder to go back to your regular jest.

Does this only fix crashing tests, or hanging tests too? Most commonly I just observed Jest hanging on "Determining test cases to run..."

I have never had jest hanging on Determining test cases to run.... So unless it's by accident, it doesn't fix that issue

The issue hits me too.
brew install watchman solved it.

@mulchy - Thanks for taking the time to test it!
Did you checkout the fix-watcher-bug-osx and then run yarn run build, and cd to the packages/jest-cli folder and run yarn link?
Everything you pasted in seems correct.
What version of node are you running?
My error coming from at FSEvent.FSWatcher._handle.onchange (fs.js:1282:11) while yours is FSEvent.FSWatcher._handle.onchange (fs.js:1406:11) which might imply a different FSEvent (or imply nothing at all)

@ro-savage yes. Ran it again just to be sure and re-linked it in the failing project, I still see the same errors.
λ jakku jest → λ git fix-watcher-bug-osx → git branch
* fix-watcher-bug-osx
  master
λ jakku jest → λ git fix-watcher-bug-osx → git log --oneline | head -1
ad182a0 Changed jest-haste-map to pass modulePathIgnorePatterns
λ jakku jest → λ git fix-watcher-bug-osx → yarn run build
yarn run v0.19.1
$ node ./scripts/build.js
Building packages
babel-jest.....................................................................[  OK  ]
... edited for brevity

✨  Done in 4.11s.
λ jakku jest → λ git fix-watcher-bug-osx → cd packages/jest-cli
λ jakku jest-cli → λ git fix-watcher-bug-osx → yarn link
yarn link v0.19.1
warning There's already a module called "jest-cli" registered.
✨  Done in 0.17s.
λ jakku jest-cli → λ git fix-watcher-bug-osx →

When I originally ran into this bug I was on 7.x, I recently switched back to 6.9.5 for a work thing. Not sure if this is helpful, but here is that line in fs.js https://github.com/nodejs/node/blob/v6.9.5/lib/fs.js#L1406

@mulchy - Oh, it might be when you check out 'fix-watcher-bug-osx' you need to yarn install again, so that you're running sane 1.6.0 (you can also check node_modules, find sane (either root directory or within jest-haste-map).
On the default branch jest is running sane 1.5.0
(I tested v6.9.5 and it ran fine on my machine. So it not that)

I'm still not able to run Jest in watch mode:
$ node -v && npm -v && jest --version
v7.4.0
4.0.5
v19.0.2

macOS v10.12.4
It's throwing the same error again and again:
> jest --watch --no-watchman

2017-04-25 14:24 node[2209] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2017-04-25 14:24 node[2209] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2017-04-25 14:24 node[2209] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: Error watching file for changes: EMFILE
    at exports._errnoException (util.js:1022:11)
    at FSEvent.FSWatcher._handle.onchange (fs.js:1283:11)

I've increased the max file limit as recommended here with no success.
I also checked @ro-savage PR and even using modulePathIgnorePatternsno luck. Am I missing something here?
I don't think to install watchman is a solution, even if that makes it work, because it's not listed as a dependency and Jest claims it works out of the box in any react project.

@valgreens - My PR has been merged into master but there hasn't been a Jest release since the merge.
So unless you were running a Jest you built yourself from the repo, the changes the fix won't be there.

@ro-savage ah! that makes more sense, thanks! I'll try to run from the repo reproducing your steps.

Thanks @robzolkos for brew install watchman, would never had found that in a million years!

@ro-savage heads up i just installed the jest 20.0.0 release and have sane 1.6.0 installed but i'm still seeing this emfile error. installed watchman to fix for now, was there any other package upgrade i could be missing? i'm using yarn so everything's pretty locked down obviously

Also having this issue here within a small CRA project. Installing watchmen fixed is for me ...

Any ETA for when the fix will be released? It is still broken for me in jest 20.0.3, node 6.10.3

Any ETA for when the fix will be released?

Any fix that Jest 20 might have is already released as of<EMAIL_ADDRESS>so if you’re still having issues, I guess Jest 20 didn’t fix them.

We are using an ejected version of Create React App v1.0.5.
node: v6.10.2
npm: 3.10.10
jest: v20.0.3
macOS Sierra: 10.12.4

I get the following error when I run yarn test
2017-05-23 12:11 node[7644] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2017-05-23 12:11 node[7644] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: Error watching file for changes: EMFILE
    at exports._errnoException (util.js:1018:11)
    at FSEvent.FSWatcher._handle.onchange (fs.js:1420:11)

But only after I add stylelint-scss to the app
yarn add stylelint-scss --dev

same as @mistermendez ... haven't yet installes watchman is that now a dependency of create-react-app / jest?

The fix PR #2957 in Jest 20 updated the optionmodulePathIgnorePatterns to correctly ignor the the folders/patterns. Previously it was still load them all and then just skip when it came time to run the test. The PR fixed the issue (for myself anyway).
However, create-react-app v1.0.0+ is now using testMatch  to decide what it should be watching instead.
Which means the original PR i did would have no affect. I do not know how testMatch works and if it fully ignoring founds not found in match, or if it still loads them then skips when it finds a match.
@mistermendez - Since you have ejected. Could you try uninstalling watchman and then updating your jest config to to remove
testMatch: [
      '<rootDir>/src/**/__tests__/**/*.js?(x)',
      '<rootDir>/src/**/?(*.)(spec|test).js?(x)',
    ],

and replace with
modulePathIgnorePatterns: [
      '<rootDir>[/\\\\](build|docs|node_modules|scripts)[/\\\\]'
    ],

And then run the tests? And let us know if that fixes the issue?

Hmm. My impression was that testMatch is supposed to be the "new way" of doing things and modulePathIgnorePatterns would eventually get deprecated. Am I wrong? Can we fix testMatch too?

I might be wrong, but from a very quick look at the latest code base.
Jest seems to be watching every file is a project based on its extension, minus the ignored files.
Pinging @pugnascotia @cpojer - should the regex/glob from testMatch be passed to the watcher?

@ro-savage I got it to work with watchman, uninstalled it, added
    "modulePathIgnorePatterns": [
      "<rootDir>[/\\\\](build|docs|node_modules|scripts)[/\\\\]"
    ],

and it works.

We might be getting somewhere here. https://github.com/facebookincubator/create-react-app/pull/2395#issuecomment-304747927

So I'm not a huge fan of adding a dependency like watchman even if it does speed up things with lots of files in your repo. I'll probably install it personally if it does speed things up, but don't want to force it to be a requirement in the README. So it sounds like the main thing you need to do is reduce the amount of files Jest is watching in your repo by adding the modulePathIgnorePatterns and testPathIgnorePatterns configs and including all of the directories you don't need to have Jest watch. That's basically what the root of the problem is correct?

As I just mentioned in the above comment, we’re going to fix this by using fsevents on OS X which doesn’t suffer from this issue. Please track https://github.com/amasad/sane/pull/97.

This is ready for testing; anyone wants to try it?

Yes, would love to get --watch back. What branch should I check out?

https://github.com/amasad/sane/pull/97

Not sure how I would run Jest with that. When there’s a branch on this repo I’m happy to test it.

@kirkstrobeck probably the easiest way is to clone the repo replacing your local copy of sane (which will be in node_modules/jest/node_modules/sane or node_modules/sane).

I cloned https://github.com/amasad/sane/commits/3875a728e588306a27815e09468ddb90493fb094 and replaced the sane folder in node_modules of a local repo where I was experiencing the following issue.
Prior to and after replacing sane I experienced the following when issuing the command ./node_modules/.bin/jest --watch:
2017-06-16 23:33 node[2282] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2017-06-16 23:33 node[2282] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2017-06-16 23:33 node[2282] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
events.js:163
      throw er; // Unhandled 'error' event
      ^

Error: Error watching file for changes: EMFILE
    at exports._errnoException (util.js:1050:11)
    at FSEvent.FSWatcher._handle.onchange (fs.js:1374:11)

@kirkstrobeck see my successful test https://github.com/amasad/sane/pull/97#issuecomment-309203580 (note jest-hastle-map needs to be modified)

I installed watchman through brew and jest watchmode works again. Nevertheless I get an error which I wonder if I should be concerned about:
jest-haste-map: Watchman crawl failed. Retrying once with node crawler.
  Usually this happens when watchman isn't running. Create an empty `.watchmanconfig` file in your project's root folder or initialize a git or hg repository in your project.
  Error: Watchman error: unknown command watch-project. Make sure watchman is running for this project. See https://facebook.github.io/watchman/docs/troubleshooting.html.

I did not invest further time in the above error message, since things seem to be working for now. However, incorporating @thisconnect 's solution seems like less a hassle.
MacOS: 10.12.5
Jest: 20.0.4

Feel free to install<EMAIL_ADDRESS>and beyond, which should not cause any more issues with this.

Upgrading to<EMAIL_ADDRESS>sees this message hang on the screen forever:
Determining test suites to run...

However, installing watchman via Brew solved the issue for me (with Jest @ 20.0.4).

Ditto.
For anyone else who stumbles on this issue and and doesn't use Homebrew regularly, the following worked for me after now having this issue over multiple projects for several months:

Take ownership of your local directory (not required with new versions of homebrew):

$ sudo chown -R $USER /usr/local/

Update homebrew:

$ brew update

Install watchman:

$ brew install `watchman`

Enjoy properly working Jest with --watch :)

Thanks @tcrosen , It worked for me. Saved my day.

Thanks @tcrosen , It worked for me. Saved my day.

I just wanted to pop in and add that brew install watchmen only worked for me after following the create-react-app README verbatim:
watchman shutdown-server
brew update
brew reinstall watchman

What if we don't want to have the extra dependency of Watchman?
Using jest via the create-react-app test script, so I don't want to directly bump up jest.
Are there any other solutions?

None of the above solutions worked while I was working inside a tmux session.
 I don't have Watchman installed, and I am on Node 8.4.0 currently. Removing and reinstalling Node modules didn't work either, so I reinstalled my Node binary from NVM and then removed and reinstalled Node modules which solved the problem for me.

I get this error with jest 21, but not with jest 20.

I didn't have Watchman installed, but a brew install watchman fixed this for me.

Incredibly strange, I was trying to figure this out, I uninstalled watchman using brew uninstall watchman like @BookOfGreg and it now works.

This is still broken in High Sierra with a create-react-app generated app, node v9.5.0,
npm 5.6.0, and jest 18.1.0.

I had to install watchman, which is weird that everyone is saying they had to uninstall it.
I'm just happy it's working :)

I once again had to downgrade Jest because of some cryptic error. Love Jest and downgrading worked. But I'm not getting the most recent version of Jest to play along in any way!

https://github.com/facebook/jest/issues/1767#issuecomment-248883102
brew install watchman fixed it for me.

I was working on a simple React project created from Create React App.
I was simply trying to add some Jest tests running npm run test
Resulted in an error:
the owner of /usr/local/var/run/watchman/factornine-state is uid 0 and doesn't match your euid 501

Watchman:  watchman --no-pretty get-sockname returned with exit code=1, signal=null, stderr= 2018-03-25T14:38:11,538: [2754904896] the owner of /usr/local/var/run/watchman/factornine-state is uid 0 and doesn't match your euid 501

OSX - 10.13.3
Node - v6.13.0
NPM - 3.10.10
watchman 4.7.0
Project Enviroment
React 16.2.0
Jest 22.4.3
I tried brew upgrade watchman -> watchman 4.9.0 to no avail.
Setting the permissions on the /usr/local/var/run/watchman directory didn't work either.
This did though:
rm -rf node_modules/
npm update
brew uninstall watchman

npm run test ran without error!

I had the issue with create-react-app when I ran npm run test
2018-04-13 09:58 node[15400] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2018-04-13 09:58 node[15400] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
events.js:165
      throw er; // Unhandled 'error' event
      ^

Changing the "test" script in package.json gave a more descriptive error.
 "test": "CI=true react-scripts test --env=jsdom",

> CI=true react-scripts test --env=jsdom

 FAIL  src/actions/someActions.spec.js
  ● Test suite failed to run

    Cannot find module 'redux-mock-store' from 'someActions.spec.js'

In my case I had some imports that were unresolved.

I had exactly the same problem. $ brew install watchman worked perfectly for me aswell

brew install watchman or brew reinstall watchman or brew uninstall watchman did not work for me :(.
Whether the test succeeds or not, it just hangs after all tests are executed. Using --forceExit did not help.

node -v
v10.1.0
yarn -v
1.6.0
yarn jest --version
v21.2.1

I'm using create-react-app and following instructions here:
https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#testing-components
Removing jest-enzyme fixed the error for me.  I'll try downgrading jest-enzyme to see if it helps.

After adding Enzyme 3.3.0, this issue started for my team using an ejected version of CRA. We're all on High Sierra if that matters.
I explored all of the options outlined in the many links here and, aside from brew install watchman, nothing seemed to work. That was not an acceptable solution for me so I continued to investigate. Ultimately, updating to Jest 23.1.0 resolved the issue.

+1 more for installing Watchman. Don't like it, but it did work

@robzolkos thanks. But I don't want to install watchman by myself

I just ran into this myself, but what caused it was installing these packages in my CRA as dev dependencies:
    "enzyme": "^3.4.1",
    "enzyme-adapter-react-16": "^1.2.0",
    "react-test-renderer": "^16.4.2"

removing these dependencies fixed the issue.
node: 8.9.4 || 8.11.3
npm: 5.6.0
I didn't bother to install watchman with brew.

How i fixes this was.
At first i tried brew install watchman and yes it worked like charm, However i was thinking if this could be the real issue? i again uninstalled it brew uninstall watchman
then i removed my node modules rm -rf node_modules and hit npm i again
also when i hit npm list --depth=0 I had Err of UNMET PEER DEPENDENCY<EMAIL_ADDRESS>and then i moved jest from dependencies to devDependencies using npm i -D jest
in short

rm -rf node_modules
npm i
npm i -D jest (if required)

might help someone. :)

I've solved removing the --watch option and using instead --no-watchman

Upgrading Jest (or react-scripts if you use cra) fixed it for me. React-scripts 2 went stable recently.

i always have the same issue

Still have the same issue here. Someone has opened an issue on the watchman repository?

For anyone else still having this problem, I was able to resolve it by adding my node_modules directory to watchPathIgnorePatterns in my jest config.
watchPathIgnorePatterns: ["node_modules"]

Credit owed to @reergymerej from here.

I'm still having this issue. Using latest create-react-app and I spent about 30 minutes going down the watchman issues however I completely uninstalled and verified that watchman was gone and yarn test is still hanging.

My tests were working perfectly fine, and all the sudden they stopped working.  The reinstall of watchman by the following commands did not work. This is on MacOS Big Sur 11.2.3.
brew upgrade
brew uninstall watchman
brew install watchman


Categories

Additions

Added specific Blog/Newsroom Categories to Related Post options

Changes

Updated article template to render all categories

Testing

visit here and see that blogs now render all categories icons

Load Refresh DB

visit here and see it pulls a hodge podge of posts

edit this page and in the sidebar Related posts organism select a specific category or either blogs or newsrooms or both! Then Publish this page

visit here and see it pulls a posts related to your selections

Review

@kurtw
@richaagarwal

Screenshots
before:

edited:

after:

Nice start...some questions:
So that drop down includes both blog and newsroom categories?
And if I don't make any selection, it'll just pull in items tagged with the relevant topic tags in all categories?
And if I only make a blog category selection, it'll still pull in all categories of news items?
I have to admit, I'm a little worried by the screenshots, cause it looks like the category selection is overriding the topic tag.
If that's the FOIA page, then the results of the FOIA topic tag + the Data & Research Category should look like this in the Blog portion:
/blog/?filter_blog_category=Data%2C+Research+%26amp%3B+Reports&filter_tags=FOIA&filter_range-date-gte=&filter_range-date-lte=
But instead, what's in your screen shot looks like this:
/blog/?filter_blog_category=Data%2C+Research+%26amp%3B+Reports&filter_range-date-gte=&filter_range-date-lte=

@schaferjh

Yes it contains both blog & newsroom categories
If nothing it selected it follows the default behavior of pulling in related posts by tag
Yes if you only make a blog category selection, the newsroom will maintain its default behaviour (as seen in the 2nd screenshot)
yea, i had coded it to find posts using the logic FOIA or Data & Research, but i can rework it make it FOIA and Data & Research

Great re: 1-3, thanks!

yea, i had coded it to find posts using the logic FOIA or Data & Research, but i can rework it make it FOIA and Data & Research. I went this route because our query looks up posts with tags using the Or logic i.e post is selected if it had TagA or TagB or TagC vs TagA and TagB and TagC

We definitely need to maintain the subject matter focus provided by the tags. The categories aren't topic tags per the filters -- they're another filtering facet, so hopefully we can match the filter behavior of categoryA or categoryB AND topicA or topicB or topicC.
Certainly, it's an interesting option to just provide a feed of a specific category with no topic tag focus, but that would be a secondary option, not the primary.

Edited queries to match feedback categoryA or categoryB AND topicA or topicB or topicC to better match blog filtering on /blog/
blog filter:

related posts:

Great job :+1:

:+1:


Cast typedef type

Fix #322

This change is

Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

tests/cast.c, line 62 at r1 (raw file):

	is_eq(i , 123);
	is_eq(j , 123);
	}

Nice :thumbsup:

transpiler/call.go, line 255 at r1 (raw file):

	// Need fix in program function definition for
	// correct convertion of return type
	if functionName == "noarch.Strlen" {

You can modify the function definition internally and leave a comment. Here is an example: https://github.com/elliotchance/c2go/blob/master/program/function_definition.go#L188-L191

Comments from Reviewable

Review status: 8 of 10 files reviewed at latest revision, 2 unresolved discussions.

tests/cast.c, line 62 at r1 (raw file):
Previously, elliotchance (Elliot Chance) wrote…
Nice :thumbsup:

Yes, @yulvil create a cool test

transpiler/call.go, line 255 at r1 (raw file):
Previously, elliotchance (Elliot Chance) wrote…
You can modify the function definition internally and leave a comment. Here is an example: https://github.com/elliotchance/c2go/blob/master/program/function_definition.go#L188-L191

Thank you for clarification. Done.

Comments from Reviewable

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


[Question]: How to train and test on my own dataset?

There is also a dedicated documentation for this below
https://anomalib.readthedocs.io/en/v1.2.0/markdown/guides/how_to/data/custom_data.html


Fix payload unmarshalling for indexed data

Goal of this PR
Fixes #246 .
This PR fixed incorrect data marshalling of indexed data when using the DPS API.
Checklist

[x] Is on the right branch
[x] ~Documentation is up-to-date~
[x] ~Tests are up-to-date~

I updated the tests just so they build, with the codec now in play I guess we could add additional scenarios to the tests.

@Maelkum Whooooops missed your comment, bad timing 😅 Feel free to open an issue for it though :)

No worries, no worries, I think the more important part was getting things
working again :D
On Thu, Jul 1, 2021, 19:28 Brendan Le Glaunec @.***>
wrote:

@Maelkum https://github.com/Maelkum Whooooops missed your comment, bad
timing 😅 Feel free to open an issue for it though :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/optakt/flow-dps/pull/247#issuecomment-872425111, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AE4LQKZEFPXT4RE6AXDRFGDTVSQTZANCNFSM47VDLIOQ
.


support for LLM.int8

add support for summarization models with LLM.int8 (per hf implementation)
add tf32 support
update docs

basic test nb, things work


Structured front-end component files setup

https://github.com/ronitblenz/food4bengal/commit/5b76a1f96d953879f0bff32206e2be84909cfd13
Here is the commit for closing this issue.


[textfield] leading action button

feature request to support textfield leading action (button, textfield, select etc'...)

textfield currently supports only trailing actionable icon buttons (applying styles to slotted icon buttons)

reasons to avoid extending textfield support:

adding more action type support to textfield will overload its objective with multiple concerns.
exposing a prefix, suffix slots will harm its ergonomics by breaking the lockdown

alternative option would be to separate concern with grouping controls (button, textfield, select etc'...) in an action/button group or any other dedicated component for that purpose.

Toolbar?

Example from carbon
https://www.carbondesignsystem.com/patterns/search-pattern/

Examples for similar components

Garden - Input group

This is an architectural challenge of applying certain common variants (such as appearance - ghost) to the integral parts of select, textfield.
break down

[ ] [textfield] appearance ghost support
[ ] [select] state indication should be coherent with button ghost

following the above could be achieved with an elevation visual indication (of 0)
I suggest only applying this to vivid next as the integration of variants would be way easier than in vivid < v3.0.0
(or patch-hardcode current vivid)

Handled in #350


(Optional PR) Add travisCI support. Need replace with main project info.

Hi,
I added travisci.org support for continuous integration for my personal fork. But a pull request if you want to incorporate to main project.

any push in master branch will launch a docker container in travisci to install, test etc
on different erlang releases 17.x & onwards
But I use my account, so if you want to incorporate this:
edit readme.md    Build Status link (I use mine linearregression, please replace with project owner)
.in travis.yml
notifications:
I use<EMAIL_ADDRESS>as a place holder.
Decide if notification

Ref: http://docs.travis-ci.com

I'll update it with my credentials. Thanks!


Add keyboard shortcuts for moving in listing

💻 Environment
Platform: Linux
📒 Description
Continuation of PR: #2823
Shortcuts needed:

jump to listing (We're using shift down in mac so it could also work for linux)
Moving in list with UP/DOWN keys. The selected item is highlighted and the same keys that open up running item in edit view will now open the item selected in the listing.

This is probably already fixed


Bring back AST support for BNLJ inner joins

Signed-off-by: Alessandro Bellina<EMAIL_ADDRESS>Now that https://github.com/rapidsai/cudf/pull/9523 has been merged, this PR brings back the request for AST for the BroadcastNestedLoopJoin InnerJoin case (which had been rolled back for 21.10 https://github.com/NVIDIA/spark-rapids/pull/3746)
This is marked as draft until we get a cuDF nightly pushed.

build


userspace: support MMU-based memory virtualization

Container issue; split into various MMU/VM related stories

[ ] Virtualize address space, 2G/2G user/kernel VM split
[ ] New APIs for supporting Zephyr "processes" which have their own VM, multiple Zephyr threads per process.
[ ] Deprecate Memory Domains for MMU systems.
[ ] ASLR
[ ] Separately loaded position-independent application binaries loaded at runtime
[ ] NuttX style demand paging
[ ] x86: SMEP/SMAP

Is there any activity to support container for Zephyr, e.g. approaches like BalenaEngine?

Hello, is there any activity to support container for Zephyr, e.g. approaches like BalenaEngine?

No this is not currently planned.

Hello, is there any activity to support container for Zephyr, e.g. approaches like BalenaEngine?

No this is not currently planned.

Hi, thank you for the answer. Is there references how to setup/run a container on Zephyr? Thanks a lot

Is there references, ideas or approaches how to setup/run a container on Zephyr? Thanks a lot

There's no container support on Zephyr and nobody has indicated plans to investigate doing so.

Is there references, ideas or approaches how to setup/run a container on Zephyr? Thanks a lot

There's no container support on Zephyr and nobody has indicated plans to investigate doing so.

thank you very much for answering!
Is there an alternative / possibility in Zephyr to separate / hide applications from each other? container-like

@Deliver88 what we have right now is documented here:
https://docs.zephyrproject.org/latest/reference/usermode/index.html
Provided virtual memory spaces for devices with an MMU and introducing the concept of Zephyr processes, is the next step and is being looked at this winter.

@Deliver88 what we have right now is documented here:
https://docs.zephyrproject.org/latest/reference/usermode/index.html
Provided virtual memory spaces for devices with an MMU and introducing the concept of Zephyr processes, is the next step and is being looked at this winter.

@andrewboie thanks a lot, it sounds good :)

AFAIK most of this was done in the context of other issues/enhancements


raidemulator: Remove significantStates

Plus some other minor cleanup related to combatant properties/functions

I think this is definitely simpler overall.  I know I've had questions in the past over significant states as well.


Highlighting files in Filesystem dock can fail to bring them in view on some displays

One of our students reported on the 102 tours that on a step, the highlighted files (room scenes) weren't all in view when the step started, suggesting a problem with the code that tries to scroll the files into view.
They're using a 14" macbook pro.
Screenshot:

Should be fixed now with e33f56a4834e55938cd1a19b6af86988ab118d39, we'll open a new ticket if a new student has the issue


Permit use of commas in stream names

Should fix #3729.
This is just a draft PR because it doesn't take into account the problem of what to do about existing messages in the outbox. (We probably don't want to flush a potential backlog of hundreds of messages all at once. Perhaps, during the following migration, we should drop messages stalled due to this bug that are more than a day old?)

Thanks! Ouch, yeah.
I think a good solution to that last question is: in a commit before the one that fixes this bug, we add some logic for trySendMessages to just drop outbox messages that are ancient, like >1wk old. (And log something to Sentry when they do.)

On reflection, the last two commits ("send messages sequentially" and "continue sending messages on client errors") are arguably a little out of scope.
If there are issues with them, but not with the first three commits, it's probably better to close this PR with just those three merged – the other two can wait for their own issue+PR.

Let's move the last two commits to a separate PR, as you suggested -- they have some complexity, so let's narrow the scope for this bugfix.

After poking at the relevant code a bit, I'm going to have to abandon those commits entirely. The bug they're trying to fix presently masks the potentially severe effects of other bugs. :disappointed: I don't think there's a simpler way to fix the control flow here than a total rewrite.
I'll file a new issue with some notes. In the meantime, :ping_pong:.

Thanks for the revisions! Replied above.

I think then my remaining question is: the commit message says "Always use JSON" for this field [...]

Clarified. (The other option would have required testing.)

Withdrawn pending research and discussion.. The short version is that we may want to use a stream ID here rather than a stream name.

The ability to use stream IDs was only added in 2.0 (zulip/zulip@b8221555d2225594c6fb8b9bbcbb63ce3cedbc87). While it might be a good idea once we can do version detection, we'll have to make do with JSONified names for now.

Looks good, thanks -- merged!


docs: add documentation or support for CSS extraction with rsbuild/rspack

Description
Griffel is a powerful styling solution, and it works seamlessly with modern build tools. However, while rsbuild and rspack are becoming increasingly popular as webpack-compatible tools, there is no documentation or guidance on how to enable CSS extraction when using these tools with Griffel.
CSS extraction is a crucial feature for production builds, where styles are typically separated into standalone .css files for better performance and caching.
Expected Behavior

Clear instructions or built-in support to enable CSS extraction with rsbuild/rspack in projects using Griffel.

@chensid our loader & plugins are compatible with Rspack out of the box. We also have a e2e test to run against Rspack, here is a minimal config: https://github.com/microsoft/griffel/blob/main/e2e/rspack/src/assets/rspack.config.js
However, I agree that having separate docs for Rspack would be great 🐱

@chensid our loader & plugins are compatible with Rspack out of the box. We also have a e2e test to run against Rspack, here is a minimal config: https://github.com/microsoft/griffel/blob/main/e2e/rspack/src/assets/rspack.config.js
However, I agree that having separate docs for Rspack would be great 🐱

Thank you for the example config! I’ll test it out in my project.
Looking forward to dedicated docs, especially with Fluent UI and TypeScript examples for production setups. 😊


Fix S3 multipart upload and add related UTs

What changes are proposed in this pull request?

fix bugs in alluxio.proxy.s3.S3ObjectTask.CompleteMultipartUploadTask#validateParts
CompleteMultipartUpload executes the specified parts  with the specified upload ID rather than all parts.
add initiate / complete / abort MPU and upload part unit tests.
remove XAttr
show all upload-parts to user while listing parts

Why are the changes needed?
there are problems in validateParts() of complete MPU

can’t recognize S3 Error: MalformedXML
throw unexpected error: InvalidPartOrder

we need to fix validateParts() of complete MPU to keep s3 proxy behaviors as consistent with aws as possible.
Does this PR introduce any user facing changes?

can't get the bucket name and object name of the part while executing  ListMultipartUploads

now complete MPU's response is like

part list
response(before)
response(now)

[]
500
MalformedXML

[1,3]
InvalidPartOrder
200

[2,1]
InvalidPartOrder
InvalidPartOrder

[3,3]
InvalidPartOrder
InvalidPartOrder

alluxio-bot, merge this please


Issues while migrating to Serenity 2.0

Hi,
We have been using serenity1.0 for some time. But now, as we try to migrate to serenity2.0, we tried to execute the project at https://github.com/jan-molak/serenity-js/tree/2.0/examples/protractor-cucumber. However, the node modules are getting partially installed and during execution we are being thrown the following errors:
Errors:
[test:update-serenity] > serenity-bdd update --ignoreSSL
[test:update-serenity]
[test:update-serenity] I'm terribly sorry, but something didn't go according to plan.
[test:update-serenity] Cannot read property 'to' of undefined
[failsafe] Script 'test:update-serenity' exited with code 0
----------------------------------------------------------------------------------------------------
[test:report] > serenity-bdd run
[test:report]
[test:report] I'm terribly sorry, but something didn't go according to plan.
[test:report] I couldn't access the Serenity BDD CLI at<EMAIL_ADDRESS>Did you remember to run `serenity-bdd update`?
[failsafe] Script 'test:report' exited with code 0

Can we have the dependencies required for cucumber-protractor projects? @jan-molak  @serenity-js/cucumber

Hi @akshayadesh,
Could you please elaborate a bit more on what you mean by node modules are getting partially installed? The error you're seeing is most likely related to the dependencies not being available at runtime.
Since the repo you have cloned is a mono-repo, it means that it contains both the Serenity/JS source code as well as the examples.
Basically, you can run the examples in 2 ways:
Nice'n'easy
This approach is great if you want to simply run the examples using the latest version of Serenity/JS as published to npmjs.com and avoid having to compile the framework itself (most cases):
git clone https://github.com/jan-molak/serenity-js.git
cd serenity-js
git checkout 2.0
cd examples/protractor-cucumber
npm install
npm test

Advanced
This approach should be used if you're planning to contribute changes to Serenity/JS itself and would like to check if the changes you've made to Serenity/JS still work with the examples. With this approach you'd be using make clean verify which recompiles and tests the Serenity/JS itself.
git clone https://github.com/jan-molak/serenity-js.git
cd serenity-js
git checkout 2.0
npm install
make clean verify
cd examples/protractor-cucumber
npm test

Let me know if this helps,
Jan

Hi Jan!
Your answer helped we could execute the example project. Now we're trying to create our own project with the help of example that you provided. However, we're facing following issues:

Serenity JS1.0 used to show structure of unimplemented steps, with serenity-Js 2.0 we are not getting that. It just shows :
ImplementationPendingError: Step not implemented
at CucumberEventProtocolAdapter.outcomeFrom (C:\ui-automation\serenity-example\node_modules@serenity-js\cucumber\src\listeners\CucumberEventProtocolAdapter.ts:168:54)
at EventEmitter. (C:\ui-automation\serenity-example\node_modules@serenity-js\cucumber\src\listeners\CucumberEventProtocolAdapter.ts:140:54)
at EventEmitter.emit (events.js:187:15)

We are experiencing timeout issues during executions.
For more clarity kindly check the sample repository that we have created: https://github.com/rajeshwarp/serenity-js-example

Please help us with the basic assertions. We want to use targets instead of elements. But assertions demand elementFinder for operations like text equals, element present etc. What is the way out to this?

Thanks,
Akshaya

Hello @jan-molak !
Your answer has helped! There is another issue that we are stuck up with.
The protractor.conf.js uses cucumberOptions like this:
cucumberOpts: {
   require: [
     "features/step_definitions/*/**.ts",
     "core/common-util/hooks.ts",
     "core/persona.ts",
     "core/stage.ts",
   ],
   format: 'pretty',               // enable console output
   compiler: 'ts:ts-node/register'   // interpret step definitions as TypeScript
 },

On execution, we learn that it is unable to find the location for step_definition files. The error reads:
[test:acceptance] [16:27:53] E/launcher - Error: Error: ENOENT: no such file or directory, lstat 'C:\gitrepo\WebFX\Lifecare-Foundation-TestFx-SerenityJS-Starter-Kit\features\step_definitions\*'
[test:acceptance]     at Object.realpathSync (fs.js:1454:7)
[test:acceptance]     at Object.expandPathWithExtensions (C:\gitrepo\WebFX\Lifecare-Foundation-TestFx-SerenityJS-Starter-Kit\node_modules\cucumber\lib\cucumber\cli\path_expander.js:14:23)
[test:acceptance]     at C:\gitrepo\WebFX\Lifecare-Foundation-TestFx-SerenityJS-Starter-Kit\node_modules\cucumber\lib\cucumber\cli\path_expander.js:8:27
[test:acceptance]     at Array.map (<anonymous>)
[test:acceptance]     at Object.expandPathsWithExtensions (C:\gitrepo\WebFX\Lifecare-Foundation-TestFx-SerenityJS-Starter-Kit\node_modules\cucumber\lib\cucumber\cli\path_expander.js:7:31)
[test:acceptance]     at Object.expandPaths (C:\gitrepo\WebFX\Lifecare-Foundation-TestFx-SerenityJS-Starter-Kit\node_modules\cucumber\lib\cucumber\cli\support_code_path_expander.js:6:38)
[test:acceptance]     at getSupportCodePaths (C:\gitrepo\WebFX\Lifecare-Foundation-TestFx-SerenityJS-Starter-Kit\node_modules\cucumber\lib\cucumber\cli\configuration.js:73:49)
[test:acceptance]     at Object.getSupportCodeLibrary (C:\gitrepo\WebFX\Lifecare-Foundation-TestFx-SerenityJS-Starter-Kit\node_modules\cucumber\lib\cucumber\cli\configuration.js:125:30)
[test:acceptance]     at Object.getSupportCodeLibrary (C:\gitrepo\WebFX\Lifecare-Foundation-TestFx-SerenityJS-Starter-Kit\node_modules\cucumber\lib\cucumber\runtime.js:44:46)
[test:acceptance]     at Object.start (C:\gitrepo\WebFX\Lifecare-Foundation-TestFx-SerenityJS-Starter-Kit\node_modules\cucumber\lib\cucumber\runtime.js:12:37)
[test:acceptance] [16:27:53] E/launcher - Process exited with error code 100
[test:acceptance] npm ERR! code ELIFECYCLE
[test:acceptance] npm ERR! errno 100
[test:acceptance] npm ERR<EMAIL_ADDRESS>test:acceptance: `protractor ./protractor.conf.js`
[test:acceptance] npm ERR! Exit status 100
[test:acceptance] npm ERR!
[test:acceptance] npm ERR! Failed at the<EMAIL_ADDRESS>test:acceptance script.
[test:acceptance] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Could you please help us with this?
Thanks,
Akshaya


Patch #77 recommand pass pattern

Close Issue
#77
Problem Description

added javascript function to handel the regex pattern check .
if pattern is correct then border color will turn to green else red.
added icons and description about pattern for similicity
added show password button
made some changes in styles.css
update regex in validate.php to handel specialcase too

screenshots

Easiness

[x] Added comments for better understanding of code.
[x] Reviewed code.

@1-ankush-1, you have successfully made the required changes. I have tested all the edge cases and everything is functioning perfectly. Congratulations on creating your first pull request! 🤗. Merging this PR.


[Docs] Debug Angular CLI TS code

As per the instructions in article https://github.com/angular/angular-cli/blob/master/packages/angular/cli/README.md#debugging-with-vs-code , I was trying to debug angular CLI TS codebase. However, VSCode debugger errors out on startup

Debugger attached.
Waiting for the debugger to disconnect...
internal/modules/cjs/loader.js:311
      throw err;
      ^

Error: Cannot find module<EMAIL_ADDRESS>Please verify that the package.json has a valid "main" entry
    at tryPackage (internal/modules/cjs/loader.js:303:19)
    at Function.Module._findPath (internal/modules/cjs/loader.js:516:18)
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:867:27)
    at Function.Module._load (internal/modules/cjs/loader.js:725:27)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (/Users/dev/work/tmp/angular-cli/dist/@angular/cli/utilities/config.js:11:16)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32) {
  code: 'MODULE_NOT_FOUND',
  path<EMAIL_ADDRESS>  requestPath: '@angular-devkit/core'
}

Also, the docs mention that one could add breakpoints to files under dist/@angular folder. Can we also add breakpoints to uncompiled TS code?

Hi @prabh-62,
Have you linked the built packages in your project (https://github.com/angular/angular-cli/blob/master/packages/angular/cli/README.md#working-with-master)?

Also, the docs mention that one could add breakpoints to files under dist/@angular folder. Can we also add breakpoints to uncompiled TS code?
Not with this type of testing

I tried npm link inside dist/@angular/cli folder and then npm link @angular/cli in the angular project. However, I kept getting the same error.
My intent is to debug TS code. Is it possible to debug typescript code with the VSCode debugger?

BTW, I am able to debug ng cli directly in the angular project from the node_modules without git cloning this repo. However, this is not what I am after.

My intent is to debug TS code. Is it possible to debug typescript code with the VSCode debugger?

Adding a breakpoint in the .ts sourcefile will not work, you need to add the breakpoints in the .js files.

I guess, then we can close this issue. It would still be interesting to know how one can contribute to angular CLI. I read the CONTRIBUTING.md file and the instructions weren't clear enough to dive into the codebase. Thanks for answering my questions and for responding to issues swiftly, Alan.


How to put divider image?

Hi, @cabuhatprince
In the current implementation only supports color line.
When do you use divider image?

Im gonna use an image for every divider.
On Jun 11, 2015 12:04 AM, "ogaclejapan"<EMAIL_ADDRESS>wrote:

Hi, @cabuhatprince https://github.com/cabuhatprince
In the current implementation only supports color line.
When do you use divider image?
—
Reply to this email directly or view it on GitHub
https://github.com/ogaclejapan/SmartTabLayout/issues/32#issuecomment-110812831
.

divider image there is no plan to support.
So, we will close the issue.


Draft outline for sharing and distributing electron apps

Just as the other pull requests #533 and #531, this is an outline for the third unit: Sharing and Distributing Electron Apps.
It touches on what to do after you have a compiled app, where and how to share it for different operating systems, how to set up downloads from a website, and what legal things need to be considered before sharing.
cc @github/services-training and @lee-dohm for review and edits 🎉

To try to honor the deadlines set for the outline, and so that @github/services-training can start working on the copies, I'm going to merge this into the electron-course branch.


chore: add Java test on autoprops from private constructor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Any chance you could update the .NET test to use the static method, and make sure they have the same name?


Import incorrectly mapping unique fields.

I've been trying to import about 500 entries in batches of 100, but each batch does not import dozens of entries I'm expecting it to. If the Duplicate Action is set to "add" it skips the entries, and if it's set to "Update", it updates them.
However I'm positive the unique field is in-fact unique for each entry.
The unique field is a random URL string. Not sure if it's choking on processing a weird unique field such as this: http://cs-recruiting.force.com/careers/ts2__apply_to_job?nostate=1&f=a0pd0000007u3U1AAI&showJobs=100

Following up through Slack. Feel free to get in touch when you're next available!

Closing due to inactivity. Please open if you need assistance.


kicked for exeeding packet rate on servers

Sorts the inventory too quickly, leading to being kicked on servers

I can look to add an option for a delay

Just pushed latest version which contains changes that should help alleviate this issue. v1.1.1


german files need an update

What happened?
@gatonero please update the german files, I added a short english utterance in module-returned-evapotranspiration-deficiency.
Please wait for next beta.
How to reproduce
install beta 26
Relevant log output
No response
Which version are you running?
beta26
Diagnostics file

[X] I have attached a diagnostics file

Additional information
No response

I'm on beta26 and don't see any changes.

it's here: https://github.com/jeroenterheerdt/HAsmartirrigation/blob/v2.0/custom_components/smart_irrigation/translations/de.json#L65

Yes I know. But what's the difference compared to before?

There are literally a couple of Engels words there that need translating... 😂

Haha, i was blind.

Strange this was translated in my local repository. Don't know, why it wasn't pushed. I made a small change and pushed it again.


Adds Face Filtering Project using ML in python

@Romi904 please accept PR and merge it.

you can't contribute more than one here.


Selenoid created new session before stop MicrosoftWebDriver for Edge browser on Windows

Steps to reproduce:

Start selenoid on Windows with -limit 1 -disable-docker parameters
Run two tests that use MicrosoftEdge browser in parallel

Actual result:
Second test will fail with 500 internal error from MicrosoftWebDriver
Expected result:
Second test continue running as first one
Details:
In selenoid output we can see that new session is started before MicrosoftWebDriver is stoped by selenoid.
For now Microsoft Edge doesn't support to run multiple sessions simultaneously
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/7186486/
Workaround:

Create separate batch file with timeout before starting new MicrosoftWebDriver process
In browsers.json set to run your batch file instead of MicrosoftWebDriver directly

Using batch files can lead to memory leak because Windows has no way to destroy the entire process tree with all child subprocesses.

Agree. I forgot to write that you need to kill previous MicrosoftWebDriver process in batch file.

@mdolinin so you are saying that we can't start 2+ processes of EdgeDriver in parallel?

Yes. You can start few EdgeDriver processes, but when you try to use them they will response with 500 internal error

Ok, let me test this first. If Edge does not support this - the only thing we can do is to wait for this feature to be implemented.

I investigated the situation a bit more and can confirm that this is an Edge internal limitation which should be fixed in subsequent releases. I think this could be because of the hard-coded debug port  used for communication or essentially single-threaded debugger implementation. Anyway let's wait for the next Edge update to see whether they have fixed the issue.

Still reproduces with Edge 16.16299 and latest EdgeDriver.


ValueError: Shape must be rank 1 but is rank 0 for 'Batchnorm_0/cond/Reshape_4' (op: 'Reshape') with input shapes: [1,6,1,1], [].

After executing python driving_benchmark.py -c Town02 -v -n test as per your instruction, landed the error below. Kindly suggest how to proceed...
Built Task Block 0_red_light
Traceback (most recent call last):
File "driving_benchmark.py", line 72, in
agent = CAL(args.city_name)
File "/home/deepaknayak/Documents/Reinforcement-learning/CAL/PythonClient/agents/CAL_agent/CAL_agent.py", line 65, in init
self.neural_net = CAL_network()
File "/home/deepaknayak/Documents/Reinforcement-learning/CAL/PythonClient/agents/CAL_agent/perception/cal_network.py", line 83, in init
self.model = ModelSingle()
File "/home/deepaknayak/Documents/Reinforcement-learning/CAL/PythonClient/agents/CAL_agent/perception/cal_network.py", line 21, in init
tup = reload_model_from_episode('full_model_ep_3936')
File "/home/deepaknayak/Documents/Reinforcement-learning/CAL/PythonClient/agents/CAL_agent/perception/model_functions.py", line 58, in reload_model_from_episode
model = get_final_model()
File "/home/deepaknayak/Documents/Reinforcement-learning/CAL/PythonClient/agents/CAL_agent/perception/model_functions.py", line 316, in get_final_model
b1, p1 = get_task_block(HAZARD_STOP)
File "/home/deepaknayak/Documents/Reinforcement-learning/CAL/PythonClient/agents/CAL_agent/perception/model_functions.py", line 197, in get_task_block
model, name = reload_model_from_episode(model_name)
File "/home/deepaknayak/Documents/Reinforcement-learning/CAL/PythonClient/agents/CAL_agent/perception/model_functions.py", line 61, in reload_model_from_episode
model = get_model_master(params)
File "/home/deepaknayak/Documents/Reinforcement-learning/CAL/PythonClient/agents/CAL_agent/perception/model_functions.py", line 152, in get_model_master
model = vgg_to_timedistributed('VGG16', dilated_seq_len, conv_dp)
File "/home/deepaknayak/Documents/Reinforcement-learning/CAL/PythonClient/agents/CAL_agent/perception/model_functions.py", line 98, in vgg_to_timedistributed
x = TimeDistributed(BatchNormalization(axis=1), name='Batchnorm{}'.format(i))(x)
File "/home/deepaknayak/.local/lib/python2.7/site-packages/keras/engine/base_layer.py", line 457, in call
output = self.call(inputs, **kwargs)
File "/home/deepaknayak/.local/lib/python2.7/site-packages/keras/layers/wrappers.py", line 248, in call
y = self.layer.call(inputs, **kwargs)
File "/home/deepaknayak/.local/lib/python2.7/site-packages/keras/layers/normalization.py", line 206, in call
training=training)
File "/home/deepaknayak/.local/lib/python2.7/site-packages/keras/backend/tensorflow_backend.py", line 3123, in in_train_phase
x = switch(training, x, alt)
File "/home/deepaknayak/.local/lib/python2.7/site-packages/keras/backend/tensorflow_backend.py", line 3058, in switch
else_expression_fn)
File "/home/deepaknayak/.local/lib/python2.7/site-packages/tensorflow/python/util/deprecation.py", line 454, in new_func
return func(*args, **kwargs)
File "/home/deepaknayak/.local/lib/python2.7/site-packages/tensorflow/python/ops/control_flow_ops.py", line 2057, in cond
orig_res_f, res_f = context_f.BuildCondBranch(false_fn)
File "/home/deepaknayak/.local/lib/python2.7/site-packages/tensorflow/python/ops/control_flow_ops.py", line 1895, in BuildCondBranch
original_result = fn()
File "/home/deepaknayak/.local/lib/python2.7/site-packages/keras/layers/normalization.py", line 167, in normalize_inference
epsilon=self.epsilon)
File "/home/deepaknayak/.local/lib/python2.7/site-packages/keras/backend/tensorflow_backend.py", line 1908, in batch_normalization
mean = tf.reshape(mean, (-1))
File "/home/deepaknayak/.local/lib/python2.7/site-packages/tensorflow/python/ops/gen_array_ops.py", line 6199, in reshape
"Reshape", tensor=tensor, shape=shape, name=name)
File "/home/deepaknayak/.local/lib/python2.7/site-packages/tensorflow/python/framework
/op_def_library.py", line 787, in _apply_op_helper
op_def=op_def)
File "/home/deepaknayak/.local/lib/python2.7/site-packages/tensorflow/python/util/deprecation.py", line 454, in new_func
return func(*args, **kwargs)
File "/home/deepaknayak/.local/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 3155, in create_op
op_def=op_def)
File "/home/deepaknayak/.local/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 1731, in init
control_input_ops)
File "/home/deepaknayak/.local/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 1579, in _create_c_op
raise ValueError(str(e))
ValueError: Shape must be rank 1 but is rank 0 for 'Batchnorm_0/cond/Reshape_4' (op: 'Reshape') with input shapes: [1,6,1,1], [].

pip uninstall keras
pip install -I keras==2.1.6
Solution works.

Solution works.


(apache-httpd) Make service installation optional

Expected Behavior

When installing apache there will be an option to disable service installation.
Current Behavior

Apache service is installed by default and cannot be disable during install.
Possible Solution

Add package parameter (e.g. /noService) to disable service installation
Context

In my workflow I'm running the server manually (multiple instances) and don't want to run the service at all.

Definitely something that could be added.
I've added this as an up to grabs for now, but it should be an easy addition to the package.

Thanks for implementation. But when it will be propagated to chocolatey database? https://chocolatey.org/packages/apache-httpd doesn't seem to be updated.

it will be available when the next version of apache-httpd software is released, depending on the release cycle of the software we can force an update if it's truly urgent though.


Update zio, zio-test, zio-test-sbt to 1.0.12

Updates

dev.zio:zio
dev.zio:zio-test
dev.zio:zio-test-sbt

from 1.0.7 to 1.0.12.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

labels: library-update, semver-patch

Codecov Report

Merging #154 (70aee2d) into master (31ee328) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #154   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           41        41
=========================================
  Hits            41        41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22ff380...70aee2d. Read the comment docs.


Build error - Cannot find Symbol variable N

Hi,
I'm having build errors when creating a blank Cordova app with and only include the plugin.
IntentShim.java:359
if(Build.Version.SDK_INT >= Build.VERSION_CODES.N && uniAriString.startsWith("file://"))
symbol: variable N

Cordova version 6.31.
Any advice?

Hmmm... maybe related to the change I made this morning - I suggest using version 1.0.4 of the plugin (current version is 1.1.0)

Actually, thinking about it properly, it sounds like you need to have a more recent version of the Android SDK since N is defined at API level 24, https://cordova.apache.org/docs/en/latest/guide/platforms/android/

Presumed resolved


Fix examples

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   48.07%   48.07%
=======================================
  Files          21       21
  Lines        1560     1560
=======================================
  Hits          750      750
  Misses        810      810

Impacted Files
Coverage Δ

src/problemgenerator/filters.py
60.76% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff13b3c...4f7938c. Read the comment docs.


[AST] Introduce the notion of a protocol requirement signature.

This is a generic signature that stores exactly the requirements that a
protocol decl introduces, not letting them be implied by the Self :
Protocol requirement, nor storing any requirements introduced by the
protocols requirements.
Specifically, suppose we have
protocol Foo {}
protocol Bar {}

protocol Baz {
    associatedtype X : Foo
}
protocol Qux: Baz {
    associatedtype X : Bar
}

The normal generic signature and (canonical) protocol requirement
signature of Baz will be, respectively
<Self where Self : Baz>
<Self where Self : Baz, Self.X : Foo>

And for Qux, they will be:
<Self where Self : Qux>
<Self where Self : Qux, Self : Baz, Self.X : Bar>

Note that the Self.X : Foo requirement is not listed.
For the moment, this is unused except for -debug-generic-signatures.

@swift-ci Please test.

@huonw What is the intended use for this feature?

@swiftix it provides the set of new requirements introduced by a protocol in a semantic form, minimized and canonicalized. There are a bunch of places we want to use it:

In the archetype builder, so we don't need to re-walk the contents of a ProtocolDecl to expand out its requirement
In the constraint solver, for the same reason
In IRGen for witness tables, so we know how to store the witness tables of additional protocol conformances that this protocol introduces

@huonw Thanks for the explanation!

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 28d22342594d15cc4b15970b304771d0ffee670c
Test requested by - @huonw

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 28d22342594d15cc4b15970b304771d0ffee670c
Test requested by - @huonw

@swift-ci Please test and merge.

Looks like CI didn't get through the macOS build; the other smoke tests suffice, so I'm going to merge this now.


crystal_1_9: 1.9.0 -> 1.9.2

Description of changes
https://github.com/crystal-lang/crystal/releases/tag/1.9.1
https://github.com/crystal-lang/crystal/releases/tag/1.9.2
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg eval

Result of nixpkgs-review pr 244025 run on aarch64-darwin 1

1 package marked as broken and skipped:

amqpcat

17 packages built:

ameba
blahaj
collision
crystal (crystal_1_9)
crystal.bin (crystal_1_9.bin)
crystal.lib (crystal_1_9.lib)
crystal2nix
crystalline
gi-crystal
icr
invidious
kakoune-cr
lucky-cli
oq
scry
shards (shards_0_17)
thicket


Update code quality badges [ci skip]

change it to one badge per line
move coverage left since it's our primary tracking indicator
remove codacy badges since we have removed it
add LGTM and CodeClimate badges

This should resolve #220 .
The result looks like this:

View rendered README.md

Why can't the CI be skipped?

[ci skip] has to go in the commit message


Gothic 2 controls introduce target lock in melee combat

Apparently the implementation of the Gothic 2 control in g2freeAim have the undesired side effect of locking the target in melee combat. The source for this issue has not been identified so far. It might be related to #118.

This is the normal behavior of the game and not a bug


Club members not displaying at webstorm

Summary
toggle club member seems not working. I've installed this awesome plugin, it works fine except club member doesn't appears. Need help to solve this issue. Thanks in advance!
...
Expected behavior
toggle club member on -> club member appears as shown on preview page
...
Actual behavior
club member not being displayed anyways
...
Steps to reproduce (if needed)

Environment
WebStorm 2018.2
Build #WS-182.3684.70, built on July 20, 2018
Licensed to WebStorm Evaluator
Expiration date: August 18, 2018
JRE: 1.8.0_152-release-1248-b8 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 7 6.1

Hmm, the frame has it's own image, which we see in the screenshot. This frame sits on top (at least on the mac)
Which looks like this

You should be able to see it if you have an editor window open or a tool window open.

Try that out and show me with one of those two opened (with club members being on) :)
This one is for my reference
WebStorm 2018.2
Build #WS-182.3684.70, built on July 20, 2018
JRE: 1.8.0_152-release-1248-b8 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.13.6

And hello there, thanks for fast reply!
I've tried toggle on/off again, even with opened version control tab as the example. Here goes screenshoot

Is it possible that this is Win7 problem?

It may very well be. I will need to get my hands on a window's seven machine in order to test.
So it may take a bit.
I'll keep you posted.

Yo, it seems to be working now, but the thing is WebStorm thought that this images was on my local machine. After i change local path to URI path on raw.githubusercontent.com all started to work.

So yeah, after i switch club member on/off WebStorm still tried to find images at WebStorm/bin/club_members/ . But in my case this folder does not exists.

Well after all magic manipulations with files, problem was figured out
Webstorm thinks that images are storing in folder bin/club_members, but in fact there were no folder at all. After manually downloading images from your repository /src/main/resources/club_members, and placing it into bin/club_members all seem to work now as intended

Thanks for debugging for me, and kudos to for figuring out the work around!

Anyways, it is still an issue that needs to be address.
As you know, the club members are supposed to be stored locally, but in the case of windows, that is not the case. I may have messed the the image copy step. (I package the images in the jar and extract them to be used from the file system). It may be that webstorm is installed in a directory that requires write permission (admin) or it could be I am bad at writing I/O code.
I will get a fix out for it though (I know what needs to be done).
So you do not have to do that for every other IDE you use as well.
Thanks for the help!

 Club members not displaying at webstorm #50

Thanks a lot for your help in solving this problem!
I like your theme a lot, looking forward to see future improvements.
Cheers

PyCharm 2018.2.1 (Professional Edition)
Build #PY-182.3911.33, built on August 5, 2018
JRE: 1.8.0_152-release-1248-b8 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0

I'm using PyCharm and I also cannot see club members.
I copied src/main/resources/club_members to C:\WINDOWS\system32\club_members and I resolved the problem. Thanks for all!

@maxtortime So it it a windows thing! Thanks!
As for the I/O stuff, the Idea core allows you to use images from a URL. That is how the background frame image is used (and why there is a lag time between seeing the image show up as well).
So I  was planning on doing this:

Try to write image to disk.
If that fails, fall back to using the image from a url.

Hey! I will close this issue once it is publicly available.
In the meantime if you want the zip file to install it manually just say so.
Thanks again!


feat(jwt) add none algorithm

Summary
Add none algorithm described in RFC 7515 to the JWT plugin.
see:

https://discuss.konghq.com/t/none-algorithm-for-jwt-plugin/4212
https://tools.ietf.org/html/rfc7515#appendix-A.5

Full changelog

Add none algorithm to the JWT plugin.
Add a related test.

Issues resolved
N/A

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Command addressed, please take a look.

The none algorithm has some pretty substantial security implications; this is a well-known aspect of the JWT standard. https://auth0.com/blog/critical-vulnerabilities-in-json-web-token-libraries/ is a pretty good write on this; are we sure we want to support this functionality?

@p0pr0ck5 see the kongnation post in the op. I think it makes sense, but warrants some clear warnings in the docs.

Edited. Valid now?
Tests all pasted on my fork, in here it's pending :-)

is this valid now?

@bungle mind having a look and merge if ok?

I'm still not sure this makes sense. From what I can gather (and apologies in advance if I'm missing something), this potentially allows a malicious actor to pass a JWT token to Kong that doesn't contain a digital signature, and the user can arbitrarily choose to have not Kong validate the token based on the contents of the request. That seems like a fairly major design flaw, given that operators of a Kong cluster would have no way to not allow unsigned JWT tokens to be sent.
Regardless of the transport mechanism, the none mechanism doesn't really seem to have any benefit. The first full page of results for a Google search on "JWT none signature" involves security issues with the none signature. @Ray-Eldath is there a specific use case you're hoping to solve with this?
At the very least, this plugin should contain a config option to allow none JWTs to be processed (and that option should be false by default).

My use case is that we have enforced HTTPS for all of our services, so the header that JWT using is cryptographically protected by it, and therefore no need for another signature, as described in IETF's document.
By the way, the IETF's document also required that none shouldn't be the default value. It may, in many cases, unsafe, but I think we must provide an option for some cases described.

That said, if a JWT is cryptographically protected by a transport layer, such as TLS using cryptographically current algorithms, there may be no need to apply another layer of cryptographic protections to the JWT. In such cases, the use of the “none” algorithm can be perfectly acceptable. The “none” algorithm should only be used when the JWT is cryptographically protected by other means. JWTs using “none” are often used in application contexts in which the content is optionally signed; then the URL-safe claims representation and processing can be the same in both the signed and unsigned cases. JWT libraries SHOULD NOT generate JWTs using “none” unless explicitly requested to do by the caller.

Yes TLS prevents the contents of the JWT from tampering in flight, but the transport mechanism doesn't prevent a malicious user from sending an unsigned JWT to Kong (nor does this PR enforce that TLS was used as the transport when processing none requests).
Again, at the very least this PR should provide an opt-in schema config that allows processing none tokens. Kong should not unconditionally process JWTs with the none signature without the operations explicit permission.

for reference: https://insomniasec.com/blog/auth0-jwt-validation-bypass
especially: ‘Alg “none” strikes again’


feat(KONFLUX-5480): Update pipeline references

Includes https://github.com/konflux-ci/build-definitions/pull/1688 which bases the FBC pipeline off multi-arch, so expose the build-platforms additional parameter to the PipelineRun parameters.

/retest-required


[RFC] Sass theming, theme zoning, and whitelabelling

This RFC looks at our current Sass architecture to identify how we can better support theming. As-is, we support a page-level theme and Sass variable overrides for theme colors and some component styling properties. The current Sass architecture breaks down quickly if a product is looking to use two or more themes at once, or if they want to modify component styling in a future-friendly way (as opposed to CSS overrides), a.k.a. whitelabel.
Definitions
The word "theme" is currently overloaded, causing confusion. At the end of the day, everything is a Sass variable (or map) so let's start there.
Variables - _vars.scss has been renamed to _variables.scss to better describe the file.
_theme-tokens.scss got moved into _variables.scss as it included theming variables as well as v9 to v10 feature gate variables. Bumping up versions does not constitute a theme.
Variants - button primary, secondary, etc. are variants not themes. Mixin names have been updated accordingly.
Theme - for now let's consider a theme being just colors. These colors are defined as Sass variables.
Inline Theme - when a theme is nested inside another theme.
Tokens - subset of theme variables. These are defined in the carbon website and come from @carbon/carbon-elements as theme tokens.
Whitelabel - if you want to override more than default color variables.
NOTE - inline theming only affects colors. If for some reason you want whitelabel just part your webpage (e.g. this secondary part of the page gets rounded buttons), use CSS overrides, or include two full Carbon builds to target that secondary part of the page.
Theme Overrides
Now that Carbon supports four themes out-of-box (as defined in tokens), you can global override the default theme variable using theme-white, theme-g10, theme-g90, theme-g100, or theme-custom. E.g. in your Sass build:
$token-theme: 'theme-g90';

@import '../node_modules/carbon-components/scss/global/styles.scss';

To support inline themes, token sets need to be in a Sass map. To use custom tokens, simply do this in your Sass build:
$token-theme: 'theme-custom';

$custom-theme-tokens: (
  interactive-03: pink,
);

@import '../node_modules/carbon-components/scss/global/styles.scss';

Any token not recognized is ignored, and unspecified custom tokens default to the white theme.
Inline Themes
Also called theme zones, or styling islands, this is possible by giving your theme a namespace class and deciding which component styling to include. Include just the components that you'll need in the inline themes to keep CSS bloat down. In your Sass build:
@import '../node_modules/carbon-components/scss/global/styles.scss';

@if feature-flag-enabled('components-x') {
  .my-dark-theme {
    @include theme-g90() {
      @include button-theme--x;
    }
  }
}

For the purpose of this RFC, only button Sass has been updated to support inline themes. The CSS output looks like:
.my-dark-theme .bx--btn--primary {
  background-color: #0062ff;
  border-color: transparent;
  color: #ffffff;
}

.my-dark-theme .bx--btn--primary:focus::before {
  border-color: #ffffff;
}

.my-dark-theme .bx--btn--primary:focus::after {
  border-color: #0062ff;
}

...

The inline theme overrides just contain colors to minimize CSS bloat.
If you want, you could even use your custom theme in inline themes:
$custom-theme-tokens: (
  interactive-03: pink,
);

@import '../node_modules/carbon-components/scss/global/styles.scss';

@if feature-flag-enabled('components-x') {
  .my-custom-theme {
    @include theme-custom() {
      @include button-theme--x;
    }
  }
}

Things to review
Carbon-elements
Question: Can we get carbon-elements to include Sass maps of colors? Since we can't interpolate Sass variable names, it's easiest to have the carbon-elements mixins set one $carbon--theme-tokens map. Using maps greatly simplifies handling custom tokens as global Sass override.
Notice how that does not use the !default keyword so our inline theme definitions can override the one $carbon--theme-tokens, print out inline theme declaration blocks, and move on by using @content.
Button
I used the new token map $carbon--theme-tokens instead of token variables, through a new theme-token function. E.g. theme-token(ui-04) instead of $ui-04.
I also shifted around button mixins so the main experimental mixin includes colors via button-theme--x mixin, but that mixin can also be used when defining inline themes. If you look at button-theme--x, it only includes colors.
Question: What would be the best way to test that this mixin refactor doesn't negatively impact selector specificity (order).
Whitelabel
In addition to using a non-default theme, a custom theme, or inline theme, we need a better way to allow styling customizations beyond color. This is where a two-layer Sass variable strategy comes in place.
Some variables are global (token map, color variables, font family, spacing, etc.) and for certain properties, components should use their own variables that reference the global variables. E.g. let's say you want more space between ghost button text and icon.
.#{$prefix}--btn--ghost {
  @include button-variant--x;

  .#{$prefix}--btn__icon {
    margin-left: $spacing-xs;
  }
}

You likely don't want to globally override $spacing-xs. You also don't want to override the declaration block as that becomes a migration nightmare. Instead, use a component variable:
$button-icon-margin-x: $spacing-xs !default;

.#{$prefix}--btn--ghost {
  @include button-variant--x;

  .#{$prefix}--btn__icon {
    margin-left: $button-icon-margin-x;
  }
}

And then in your custom Sass build:
$button-icon-margin-x: 12px;

@import '../node_modules/carbon-components/scss/global/styles.scss';

Things to review
Variables
Question: How many variables are too many variables? Evaluating Boostrap's Sass, it looks like colors, text, and box model can take you a very long way.
Question: What do we think of Bootstrap's variable naming convention? Is a Carbon prefix needed on these variables?

Variables should follow the $component-state-property-size formula for consistent naming. Ex: $nav-link-disabled-color and $modal-content-box-shadow-xs.

Question: What migration risks / actions does this entail? E.g. can we change a file name?
To Do

[ ] Commit with button variables example

Another of my thoughts on naming scheme is that theme is not just for colors IMO. Given the notion of theme involves designers in large extent, let's discuss this with our designers.

@asudoh It comes down to support and drawing a circle around how we intend inline theme functionality to work. Trying to keep this contained, regarding tokens and inline theming, it makes a lot of sense to keep this to just colors. And, if we intentionally use more component Sass variables going forward, that sets us up for improved whitelabelling. Whitelabelling is always going to be "do at your own risk / we don't support your whitelabel customizations / but we've made whitelabelling easy and future-friendly for you".
@IBM/carbon-design-system Please chime in if you see future theme variations that we officially support being more than colors. I'm hoping that component modifiers (cozy data table, condensed data table, etc.) will handle variations not related to color, and theming handles color.

wow @mattrosno thank you for all this work!!!!! I wonder if the designers could have a smaller meeting with you to walk through this and figure out a roadmap for some next steps.
Most importantly how do we make this sass map?
Also I know there's an aversion from the language team to calling the background colors "themes" they refer to themes only at the light and dark level... but that's more of a conceptual vs. a practical issue at the moment.

@jeanservaas I'd be happy to show this to the design team after we have a better idea of development containment (effort and minimizing breaking changes.)
The Sass maps are just a way to put each set of tokens in a single "variable".
As for design input, it'd be nice to know if any future "theming" concepts or ideas extend beyond colors, as that influences how this is architected.

Really like the direction this stuff is heading 💯 I think the only concern would be around theming more than just color, and how extracting color could impact how a contributor authors styles.

@mattrosno Can we mark this as superseded by #1872 - Thanks again for the uddate!


Memory affinity autodetection doesn't work on RHEL 5

Original author: Tom Coles
Original issue: https://charm.cs.illinois.edu/redmine/issues/935

After compiling with --with-numa in SMP mode, memory affinity nodemap auto detection doesn't work on RHEL 5: there are error messages saying that the corresponding NUMA node is not found.
The explanation is in the use of popen in memoryaffinity.c, specifically in CmiNumNUMANodes and getNUMANidByRank. It seems that this use of popen is not thread-safe with Charm++ on RHEL 5, as garbage is returned in most threads most of the time.
The use of popen is just for convenience to obtain directory information using ls, but I would suggest instead doing this directly with C code. In particular, CmiNumNUMANodes could be obtained simply by using numa_max_node()+1, as numa.h is already included anyway.
It would also be possible to calculate getNUMANidByRank using a function from numa.h, but the libnuma API has changed over the years and so this would not be compatible with all systems. Instead, I suggest traversing the directory structure with readdir().
I have attached a patch with these changes. It should be applied to src/conv-core/memoryaffinity.c

Original date: 2016-02-15 20:47:11

A very slightly modified version of Tom Coles' patch is pushed as gerrit ~~https://charm.cs.illinois.edu/gerrit/#/c/1060/~~ https://github.com/UIUC-PPL/charm/commit/d8fc771af5cb64351403c4156cc98d779bfed599
Note: in order to actually test this code your system needs the libnuma API installed (libnuma-dev package on ubuntu) and build charm --with-numa, and run +setcpuaffinity +maffinity +mempol bind  (or other valid policy options).