Fix: Try to close mysql connection properly

⚠⚠⚠ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:

[x] I have read and understand the pull request rules.

Description
Fixes #3020
Searched around and there seems to be no way to determine the state of the connection without sending something, so this should be a good enough solution.
Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist

[x] My code follows the style guidelines of this project
[x] I ran ESLint and other linters for modified files
[x] I have performed a self-review of my own code and tested it
[ ] I have commented my code, particularly in hard-to-understand areas
(including JSDoc for methods)
[x] My changes generate no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

It is quite surprising that many database libraries in Node.js do not handle connection state gracefully. Perhaps they are designed for long-running applications.

thanks!


View details page shows values with variances

As a park operator, I want to be able to view data I have entered into A&R and see which fields have a variance flagged/triggered,
Related to #255 and #291
This is the read only page for A&R forms.
Acceptance Criteria:

view details page in A&R matches designs
if a variance has been triggered on a value within an activity form then it is displayed that way to the user (display shown in designs) so they know it is a variance

Designs:
Figma

Tested on TEST: Passed

Verified that this task has been implemented and working fine.
Passing to PO review.

working as expected mving to done


Creating about page and it's content

Hi @avishkaindula ,
Thank you for your previous contributions and the pull request you submitted. I appreciate your efforts in improving our project.
I wanted to inform you that we've made some additional changes to the project since your last pull request. Specifically, we've added new features and functionality that enhance the overall user experience.
However, I've noticed that the changes in your existing pull request are not responsive, which is crucial for ensuring a consistent user experience across different devices and screen sizes.
To align with the latest project updates and to ensure responsiveness, I kindly request you to make the necessary adjustments to your previous pull request. This will help us integrate your valuable contributions while maintaining the project's usability on various devices.
If you have any questions or need guidance on making the changes responsive, please feel free to reach out. We greatly appreciate your commitment to our project, and we look forward to your updated pull request.


Port doublestar support from Opentelementry

Description of Changes
Ported double star support from this PR: https://github.com/open-telemetry/opentelemetry-log-collection/pull/97
Please check that the PR fulfills these requirements

[X] Tests for the changes have been added (for bug fixes / features)
[N/A] Docs have been added / updated (for bug fixes / features)
[X] Add a changelog entry (for non-trivial bug fixes / features)
[X] CI passes

Log Files
Logs / Second
CPU Avg (%)
CPU Avg Δ (%)
Memory Avg (MB)
Memory Avg Δ (MB)

1
1000
1.534483
+0.18957639
127.35385
+3.6251373

1
5000
5.3448853
+0.051736355
133.01616
+0.17201233

1
10000
10.41405
+0.103425026
139.49799
+0.69181824

1
50000
50.778046
+0.018699646
167.6029
-5.872177

1
100000
99.77845
+1.5515213
231.1879
-8.694916

10
100
1.9138571
-0.017189503
132.28125
+2.0585938

10
500
6.0863123
-0.18959236
135.25296
-1.1895294

10
1000
12.361867
+0.12033367
144.24785
+3.0735474

10
5000
57.087273
+1.205513
180.96713
-2.8376923

10
10000
109.52928
+2.5329819
239.00781
+24.011444

Log Files
Logs / Second
CPU Avg (%)
CPU Avg Δ (%)
Memory Avg (MB)
Memory Avg Δ (MB)

1
1000
1.6034076
+0.25850105
124.155304
+0.42658997

1
5000
5.3794465
+0.08629751
132.43454
-0.40960693

1
10000
10.568939
+0.25831413
140.79202
+1.9858551

1
50000
52.10032
+1.3409729
175.46133
+1.9862518

1
100000
100.76027
+2.5333405
236.52519
-3.3576202

10
100
2.0345914
+0.10354483
128.08984
-2.1328125

10
500
6.172491
-0.10341358
140.71632
+4.273834

10
1000
11.982997
-0.25853634
142.9441
+1.7698059

10
5000
55.10537
-0.7763901
180.51833
-3.286499

10
10000
107.68722
+0.69091797
219.60062
+4.604248

#292 addresses copyright concerns. Thank you for pointing out @jsirianni


sample script for sampling from trained models

Hello- would it be possible to provide a sample script or perhaps some guidance on how one would sample from one of the pre-trained models?

The simplest way is to simply run the training script, and the full images will be shown on the Tensorboard logs. I have never seen our model mode-collapses, so basically you can train it forever.
Another programmatic way is to get it by calling trainer.rand_sample_full_test(). It returns a batch of images as a numpy array.


Update larndsim_validation.py

Updated light validation plots for pps reset, new geometry, and noise improvements.

(Just double-checking something)


Get the real plural name from the CRD, rather than blindly appending 's'.

Resolves https://github.com/kubearchive/kubearchive/issues/136.

@skoved, the kind should not be pluralized. It should be the real kind value.
I've updated the documentation. Nice catch.


stricter children prop typings

as per title, more details at https://github.com/buildo/react-flexview/pull/77

closed by #77


Use types from atom-ide-base

The error here is an internal error of atom-ide-base because JSX is defined by React (or Etch). Here React is not used, so the code throws an error. I think the solution is to use React.JSX.Element in the types.
https://github.com/atom-community/atom-ide-base/blob/8e952b465a6485eee76881cc201108e5bd853668/types-packages/datatip.d.ts#L72


feat: #960 - changed the attribute/importance preference display.

Impacted files:

attribute_button.dart: changed the whole display.
design_constants.dart: added a constant for the default icon size.
product_preferences.dart: removed the downgrading of "very important" to "important".
pubspec.lock: wtf

What

changed the attribute/importance preference display.
we still need to find interesting texts for the info dialog of the different importances.

Screenshot
[Edited screenshot after goldens fixes]

Part of

https://github.com/openfoodfacts/smooth-app/issues/960

Codecov Report

Merging #1590 (9f49ab2) into develop (2ea0da3) will increase coverage by 0.13%.
The diff coverage is 37.80%.

@@            Coverage Diff             @@
##           develop   #1590      +/-   ##
==========================================
+ Coverage     8.86%   8.99%   +0.13%
==========================================
  Files          161     161
  Lines         6623    6657      +34
==========================================
+ Hits           587     599      +12
- Misses        6036    6058      +22

Impacted Files
Coverage Δ

...mooth_app/lib/data_models/product_preferences.dart
27.69% <ø> (-3.74%)
:arrow_down:

...mooth_app/lib/generic_lib/widgets/smooth_card.dart
0.00% <ø> (ø)

...oth_app/lib/pages/onboarding/country_selector.dart
0.00% <0.00%> (ø)

...ges/smooth_app/lib/pages/product/summary_card.dart
0.00% <0.00%> (ø)

...es/smooth_app/lib/pages/scan/ml_kit_scan_page.dart
0.96% <0.00%> (ø)

...kages/smooth_app/lib/widgets/attribute_button.dart
66.10% <60.78%> (-25.90%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad0f2a...9f49ab2. Read the comment docs.

@stephanegigandet ping

@stephanegigandet ping

@stephanegigandet ping

Thank you @stephanegigandet!


TikTok support

Thank you for creating this library! Would be great to see TikTok support here.

I'm also waiting for this change, I will try to do it myself though.

I see you've made the TikTok embed class but not published it yet, any reason for that?

@mzpro10 I have started working full time at the firm for the last few months, so not able to get time to test it. Also, facing a bit of difficulty as Tiktok got banned in my country. So it would be a great help if you could test it and mentions the bugs if any.

@aker99 I definitely will test it and make any bug fixes. Is there a way you can send me the original files of the library with TikTok implemented as I can't find it anymore here in your repo. If you like we can talk in private.

@mzpro10 check the tiktok branch

Any updates about tiktok embed?


typo: Double word "more"

@nschonni : Thanks for your contribution! The author, @rothja, has been notified to review your proposed change.

@nschonni Nice catch that it needs to be "or" and not just a double "more". Thanks! #sign-off


Pin RAT checker version

Description
Pin the RAT version. The trunk currently seems to be broken and to avoided cases like this in future, we're pinning the version.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Pin RAT to 0.12 instead of trunk

Comments
@larroy

Duplicate of https://github.com/apache/incubator-mxnet/pull/12148


Add Contact Us page responsiveness

What is the change?
Remove this line and add a description
Related issue?
closes: #issue_number
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

[ ] I have followed the Code of Conduct.
[ ] I have  checked there aren't other open Pull Requests for the same update/change.
[ ] I have you tested the code before submission.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My changes generates no new warnings.
[ ] I'm Hacktoberfest'21 contributor.

Screenshots (if any)

@hrshammo Don't make pr directly . First create an issue, get it assigned and then make a pr


Prompt Password

Hi,
First of all,  i have to say that this extension is awesome...but one of the most usefull options is the prompt for password popup, when there is no password provided in settings.json .
I think is a must have, especially for secure environment, where the password will never be readable.
Because of this missing feature, i cannot use it at work right now.

@Micene09
For what kind of targets?

@mkloubert  yeah I need that too. I think @Micene09 is talking about sftp target.

@Micene09 @imanilchaudhari
I released version 9.15.0 that will now prompt an input box for sftp targets, if no password is defined.
This will happen by default if you DO NOT use a private key file (privateKeyPassphrase setting).
If you use such a file (and want to use that feature), you also have to set promptForPassword to (true).
I will also implement this for the other targets the next days.

@mkloubert
Wao! Thank you for this fast implementation!
Sorry if i'm late but, i was so busy at work...
BTW, right now i need it for the FTP target (i'm using it with option secure: true), just because the FTP server, where i need to upload is in a LAN.
I think that, having the prompt for password on all targets possible, should be a very nice feature.
Thank you again!

@mkloubert Thanks it is amazing. But there seem some bugs. Password prompt box is asking for three times. And by the way this will be great if you use some session or cache storage for password. Sublime's sftp has really good feature.

@imanilchaudhari
3 times for 3 connections or 3 times for one connection?

@mkloubert 3 times for one connection. While I was trying to deploy a single file. Nevertheless rest is working fine.

@Micene09 @imanilchaudhari
I released version 9.16.0 that now contains all feature, like password prompt for FTP and password caching.
@imanilchaudhari I cannot reproduce the issue. Maybe it is fixed with the new version.
If not: Can you post an example config? Btw: Do you use things like each or map?

Thank you for this new release, I'm ok with the goal of this issue.
Closing.

@mkloubert Thank you. It is working fine with this release.


Completed assignment 2.

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[ ] I can confirm that my changes are working as intended

I'm not sure how to be more robust than by providing a counter example, including my interpretation of the question, and some changes to my partners code.

I think I know where the difference in the interpretation is arising from. If you look at the examples provided for question 3 in the assignment 1 notebook, example 2 is a list with 3 integers [5,0,1]. The problem says that list is n integers in the range [0,n]. Since there is 3 integers in the list, the range is [0,3] = {0,1,2,3}. However, our list contains 5. This implies, that is not a valid example. Suppose my partner checked their code with the provided examples. The code would in fact produce the desired output for that example. However, since that example doesn't align with my interpretation of the problem, I think there is a mistake.


Portal script loading can’t be disabled

Issue Summary
With ghost 4.x {{ ghost_head }} loads a script from unpkg.com
<script defer src="https://unpkg.com/<EMAIL_ADDRESS>data-ghost="https://isabelmeyer.de/"></script>

This can’t be disabled anywhere currently. As privacy is important to me and my customers and in the EU sideloading a script without the users consent is at least problematic from a privacy perspective, it puts ghost users in some jurisdictions (at least Germany) into an impossible situation: We need to have a contract with each party we send our users data to.
So in this case, I’d need to have a contract with unpkg.com as they are processing personal data (at least the IP) of my customers customers.
To Reproduce

Use ghost 4.x
Check any page source for <script defer src="https://unpkg.com

I consider this a bug because it is a new behavior that
a) can’t be disabled
b) is at least in a legal grey area in some jurisdictions
Technical details:

Ghost Version: 4.2.0

Proposal
I propose to package the script with ghost in some way (I prefer this solution because it removes the external dependency. If I can help in any way to implement it, I'm happy to.

Same issue. It also impacts the load page speed as the script is huge

Please give us an option to remove this script (and disable the portal altogether).

This is a duplicate of #12835.
If you want to load a different portal.min.js file you can do so by modifying your Ghost config.environment.json file.
The default config is:
"portal": {
        "url": "https://unpkg.com/<EMAIL_ADDRESS>        "version": "~1.1.0"
    }

You can add this to your config.environment.json to change it if you want to load locally or a forked version or not load anything.
Again though, I stress, the script is used for theme-based Members features, not just portal and so it's in use more than people realise.

@ErisDS Thank you for this information. I still think there should be an option to turn it off completely; if one is not using any members features, leaving the url empty leaves a script tag with an empty src attribute in the page which is not valid.
At least Firefox will note this in the console.
So there has to be a valid URL set which does not do anything - in this case requiring a workaround.
Workaround with nginx
This is the workaround I used with nginx. To anybody with the same issue, feel free to copy it for your setup.
config.production.json:
  "portal": {
    "url": "https://example.com/empty-script.js",
    "version": "1.0.0"
  }

nginx configuration snippet (drop this in the server block for your ghost setup):
location = /empty-script.js {
  add_header Content-Type text/javascript;
  return 200;
}

I agree that having this config value set to false (like sodoSearch__url) should elide the portal script tag (instead it sets src="false").
I set these env vars in my container:
portal__url: "data:text/javascript,(function(){}())"
sodoSearch__url: "false"

Portal still creates a script tag, but my browser doesn't seem to complain.
<script defer="" src="data:text/javascript,(function(){}())" data-i18n="false" data-ghost="https://curiouslynerdy.com/" data-key="ca5fe45a37fb27c668b94ef819" data-api="https://curiouslynerdy.com/ghost/api/content/" crossorigin="anonymous"></script>

The issue seems to be back ...  since the 5.104.0 or maybe before.
When "false" is used as URL like described in the documentation : https://ghost.org/docs/config/
"The script can be relocated by changing the URL, or disabled entirely by setting "url": false."
The member script is injected in the page with "false" as a URL creating 404 error on Web Spiders  :
<script defer src="[false](https://www.geeek.org/benq-screenbar-pro-test-avis/false)" data-i18n="true" data-ghost="https://www.geeek.org/" data-key="81c2fe03bca1f308d4f99f1e54" data-api="https://www.geeek.org/ghost/api/content/" data-locale="fr" crossorigin="anonymous"></script>


[PRM-1115]: Modified LSP and LPP summary card header and footer

Could you rebase please?

The AT's will need to be updated also

PR for AT changes https://github.com/hmrc/penalties-acceptance-tests/pull/127

Could you rebase and then I think it's ready


Support ETags in Dataset CRUD

CRUD operations on datasets should use the ETag header for optimistic locking. See Using patch in a read-modify-write cycle.
Questions:

Opt-in or opt-out?
Raise error on outdated ETag?
Provide some kind of force overwrite?

@blowmage @geigerj @tswast
I have implemented a simple version of this feature that sends the ETag value in the patch request. However, I am not seeing the expected behavior in my acceptance test, which is very similar to the google-cloud-dotnet integration test (which apparently passes.) Here is the test failure that I get both on my dev account and on our shared CI account:
  1) Failure:
Google::Cloud::Bigquery::Dataset::bigquery#test_0003_should fail to set metadata with stale etag [/Users/quartzmo/code/google/codez/gcloud-ruby/google-cloud-bigquery/acceptance/bigquery/dataset_test.rb:110]:
Google::Cloud::Error expected but nothing was raised.

Any ideas?

@jskeet I remember you had a comment on the requirements doc about this. Mind taking a look at the Ruby implementation?

@tswast: I don't know Ruby so would almost certainly miss details. I'm happy to answer specific questions though.
One thing to be aware of is that the etag in the JSON returned when you create a table/dataset is currently different from the etag you'll get if you immediately fetch the object again.

My problem is that no matter what value I send in the etag field of the object in the patch request, I never get an error. (My expectation is that if I send an etag value and it doesn't match the current value in the backend, I should get an error.)
Here is a test run with puts debug logging:
dataset_test.rb
# Modify on the server, which will change the etag
dataset.description = "Description 1"
stale.etag.wont_equal dataset.etag
puts "current etag: #{dataset.etag}"
expect { stale.description = "Description 2" }.must_raise Google::Cloud::Error

dataset.rb
patch_args[:etag] = etag
patch_gapi = Google::Apis::BigqueryV2::Dataset.new patch_args
puts "sending etag: #{patch_gapi.etag}"
@gapi = service.patch_dataset dataset_id, patch_gapi

current etag: "U174L-uZHiGsoJvSMZ_oqpuY9e8/MTUwMjg5OTA0OTc2Mw"
sending etag: "U174L-uZHiGsoJvSMZ_oqpuY9e8/MTUwMjg5OTA0NzA2Ng"
...
  1) Failure:
Google::Cloud::Bigquery::Dataset::bigquery#test_0003_should fail to set metadata with stale etag [/Users/quartzmo/code/google/codez/gcloud-ruby/google-cloud-bigquery/acceptance/bigquery/dataset_test.rb:110]:
Google::Cloud::Error expected but nothing was raised.

Ah - just to check, is anything converting that into an If-Match header? (The .NET REST library does this automatically - implementation.)

@jskeet Thanks for this crucial bit of info. I bet this is the problem.

@jskeet Thanks, setting the If-Match header does the trick, I now get <Google::Apis::ClientError: conditionNotMet: Precondition Failed>. Pretty cool how the .NET REST lib does that.

One thing to be aware of is that the etag in the JSON returned when you create a table/dataset is currently different from the etag you'll get if you immediately fetch the object again.

@jskeet Wow, really? Why is that? Should we always get the resource after creating it to ensure that users always have a valid tag?

Unsure. I'm chasing it internally - I'd really like this to be changed server-side.

One of our requirements is to use etag on changes, so it looks like we will add a get call after create so that the user always has a valid etag. If the server-side implementation changes we can remove the get call.

it looks like we will add a get call after create so that the user always has a valid etag.

@blowmage Do you want to request this on PR #1674?

@jskeet I am seeing a similar issue with service.patch_table. The table representation returned by service.patch_table does NOT have the updated etag, but rather the stale etag. (But a get after a patch returns a table representation with the new etag.)
Here is some debug logging:
def patch_gapi! *attributes
  return if attributes.empty?
  ensure_service!
  patch_args = Hash[attributes.map do |attr|
    [attr, @gapi.send(attr)]
  end]
  patch_gapi = Google::Apis::BigqueryV2::Table.new patch_args
  patch_gapi.etag = etag if etag
  puts "old: #{etag}"
  @gapi = service.patch_table dataset_id, table_id, patch_gapi
  puts "new: #{etag}"
end

And the output:
# Running:

old: "U174L-uZHiGsoJvSMZ_oqpuY9e8/MTUwMjkxNzAwNTgxNg"
new: "U174L-uZHiGsoJvSMZ_oqpuY9e8/MTUwMjkxNzAwNTgxNg"

This is different from patch_dataset, which works correctly.

@quartzmo: Hmm - that's very odd. I haven't looked at that in C#. I'll have a look tomorrow.

Confirmed, I see the same behaviour for both patch and update of tables, but not of datasets. Will pursue that internally too.

Closed by #1674.

@jskeet. As of yesterday (2017-09-29), it appears that this issue with invalid etags from the service has been resolved, based on a couple of acceptance tests that we put in place to detect a fix:
  2) Failure:
Google::Cloud::Bigquery::Dataset::bigquery#test_0004_etag from get dataset is different from etag returned by Service#insert_dataset [/Users/quartzmo/code/google/codez/gcloud-ruby/google-cloud-bigquery/acceptance/bigquery/dataset_test.rb:133]:
Expected "\"qaujFrjMT9Vbhl4LPdRuJLP1c20/MTUwNDExNDkyMjA2MQ\"" to not be equal to "\"qaujFrjMT9Vbhl4LPdRuJLP1c20/MTUwNDExNDkyMjA2MQ\"".

  3) Skipped:
Google::Cloud::Bigquery::Table::bigquery#test_0015_extracts data to a url in your bucket [/Users/quartzmo/code/google/codez/gcloud-ruby/google-cloud-bigquery/acceptance/bigquery/table_test.rb:398]:
The BigQuery to Storage acceptance tests are failing with internalError

  4) Failure:
Google::Cloud::Bigquery::Table::bigquery#test_0005_etag from get table is different from etag returned by Service#insert_table [/Users/quartzmo/code/google/codez/gcloud-ruby/google-cloud-bigquery/acceptance/bigquery/table_test.rb:170]:
Expected "\"qaujFrjMT9Vbhl4LPdRuJLP1c20/MTUwNDExNTAwNjEzNA\"" to not be equal to "\"qaujFrjMT9Vbhl4LPdRuJLP1c20/MTUwNDExNTAwNjEzNA\"".

Therefore, I am now preparing a PR to revert our workarounds for this issue.

Right - I was going to report that good news, but I've been seeing issues with etags being ignored when updating datasets.

Oh, thanks for pointing this out. In that case, I'll do a partial revert just for the inserts.

@jskeet I'm currently seeing etag failures on Table updates, but not Dataset:
  1) Failure:
Google::Cloud::Bigquery::Table::bigquery#test_0003_should fail to set metadata with stale etag [/Users/quartzmo/code/google/codez/gcloud-ruby/google-cloud-bigquery/acceptance/bigquery/table_test.rb:133]:
Expected "\"qaujFrjMT9Vbhl4LPdRuJLP1c20/MTUwNDExODQ5MjM2Nw\"" to not be equal to "\"qaujFrjMT9Vbhl4LPdRuJLP1c20/MTUwNDExODQ5MjM2Nw\"".

  2) Error:
Google::Cloud::Bigquery::Table::bigquery#test_0006_updates its schema:
Google::Cloud::FailedPreconditionError: conditionNotMet: Precondition Failed
    /Users/quartzmo/code/google/codez/gcloud-ruby/google-cloud-bigquery/lib/google/cloud/bigquery/service.rb:606:in `rescue in execute'
    /Users/quartzmo/code/google/codez/gcloud-ruby/google-cloud-bigquery/lib/google/cloud/bigquery/service.rb:604:in `execute'
    /Users/quartzmo/code/google/codez/gcloud-ruby/google-cloud-bigquery/lib/google/cloud/bigquery/service.rb:161:in `patch_table'
    /Users/quartzmo/code/google/codez/gcloud-ruby/google-cloud-bigquery/lib/google/cloud/bigquery/table.rb:975:in `patch_gapi!'
    /Users/quartzmo/code/google/codez/gcloud-ruby/google-cloud-bigquery/lib/google/cloud/bigquery/table.rb:458:in `schema'
    /Users/quartzmo/code/google/codez/gcloud-ruby/google-cloud-bigquery/acceptance/bigquery/table_test.rb:177:in `block (2 levels) in <top (required)>'

We may be talking about different things - I'm talking about deliberately providing an incorrect etag in an If-Match header on update, and expecting (but not getting) a failure. Once that's fixed, I'll look at the other issues we've had :)

Yes, you're right. Thanks for the clarification.


Fix unit tests that depend on info diagnostics from dart analysis

The info/hint category of dart analyzer diagnostics is being removed: https://github.com/dart-lang/sdk/issues/50796
As part of that effort, one of the "info" diagnostics that we use in our unit tests (missing_return) was changed to a "warning" https://dart-review.googlesource.com/c/sdk/+/282164. This broke the Engine -> Framework roller when the dart sdk change bubbled up to the framework: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8789134064052154849/+/u/run_test.dart_for_tool_integration_tests_shard_and_subshard_3_4/test_stdout
I am looking to temporarily revert this change in the dart sdk to unblock the rollers, but it will eventually need to reland. We could use a different info diagnostic to check these tests, but since this entire category of diagnostics is going away, we probably just need to remove some unit tests entirely, and possibly modify the tool to remove command line flags associated with info style diagnostics since they will no longer exist.

IIUC, these tests are checking the behavior of the --fatal-infos and --no-fatal-infos flags. So they don't really care what the diagnostic is, as long as it gets flagged as info. Before the analyzer breaking change missing_return was a "hint", which would get flagged as info, but after the breaking change it is a "static warning", which gets flagged as warning. But we can adjust how the diagnostic is flagged in the analysis_options.yaml, and pin missing_return to info. Trying that here https://github.com/flutter/flutter/pull/120797.

This is fixed by https://github.com/flutter/flutter/pull/120797


exported .map lacks ".css" in filename

OS: macOS 11.3.1
Scout-App Version: V2.18.16
Information from Dev Tools: (no compile error)
When set to „development“ Scout generates a css.map and saves it to the right place.
The filename is [styles].map
The reference at the end of the generated .css looks for  [styles].css.map.
/*# sourceMappingURL=styles.css.map */
Unfortunately no match.
(Scout is wonderful, thanks a lot!)

There is a known issue with maps in 2.18.16. Can you try with the latest code from master to see if this is resolved.

https://github.com/scout-app/scout-app/blob/master/documentation/running-latest.md


JOB-30658 Add ability to set authorization headers

Adds the ability to add headers to the API calls. This will be used to authorize the calls to our proxy server.
Based on https://github.com/FaridSafi/react-native-google-places-autocomplete/pull/660 but made more generic to support arbitrary headers.
To test, you can update the dependency in your jobber-mobile package.json to
"@jobber/react-native-google-places-autocomplete": "GetJobber/react-native-google-places-autocomplete#JOB-30658/add-auth-headers",
And then try supplying a header like so:
            requestUrl={{
              url: "",
              useOnPlatform: "web",
              headers: {
                "myheader": "test",
              },
            }}

Oh it looks like I never put this into review, apologies!

[x] can see headers on the request

LGTM


Landing Page. Pubs Section. Cap Author List to 3 Lines

Consider capping author list to 3 lines given that the 4th line collides with download bar.

We can use line-clamp3 for this (from base.css):
/* Clamps three lines */
@supports (-webkit-line-clamp: 3) {
    .line-clamp3 {
        overflow: hidden;
        display: -webkit-box;
        -webkit-line-clamp: 3;
        -webkit-box-orient: vertical;
    }

    .line-clamp3:after {
        display: none;
    }
}

Should we also clamp the venue to one line (or maybe use the short venue name)? Otherwise we could run into cases like this where a third line of authors will interfere with the download links:

Let's use short venue name and clamp to one line (just in case short venue name is actually too long).

Okay, clamped both. It was already using the short name, defaulting to the long one if a short name isn't available (as is the case for the automatic data from Jon's website).
Here's an example:

I'll include this in my next pull request.

Looks good!
On Mon, Dec 18, 2017 at 1:39 PM, lstearns86<EMAIL_ADDRESS>wrote:

Okay, clamped both. It was already using the short name, defaulting to the
long one if a short name isn't available (as is the case for the automatic
data from Jon's website).
Here's an example:
[image: image]
https://user-images.githubusercontent.com/2319490/34129363-e813db12-e411-11e7-9471-0435654bc772.png
I'll include this in my next pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jonfroehlich/makeabilitylabwebsite/issues/322#issuecomment-352565964,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABi-9dl9m5I4qFtYAkIgWvZ6LxIsa8x8ks5tBtuQgaJpZM4RGBh7
.

--
Jon Froehlich
Associate Professor
Paul G. Allen School of Computer Science & Engineering
University of Washington
http://www.cs.umd.edu/~jonf/
http://makeabilitylab.io
@jonfroehlich https://twitter.com/jonfroehlich - Twitter

Hi @lstearns86. It looks like you solved this issue. Can we close it out? Or do you think we should test it first?

Yes, this issue was solved in pull request #340. Closing it now.


Update README.md

Change forRoot method to provideStore
Add Observable import

Thanks for the PR! The current docs reflect the upcoming V4 release, which uses forRoot instead of provideStore


Refactor vcpkg publishing script

The bulk of vcpkg script living in a single pwsh step is difficult to debug, maintain, and extend https://github.com/Azure/azure-sdk-for-cpp/blob/master/eng/pipelines/templates/stages/archetype-cpp-release.yml#L135
This was necessary to ship in time. Now we can pay the tech debt.

[x] Sync vcpkg master branch fork with upstream
[x] Clone in a separate step
[x] Use checkout logic to bring down the target branch if it exists (link) ... We should not treat a failure condition as the base case (it adds unnecessarily to error logs and unnecessarily couples a normal process to an error handler which could change in the future)
[x] Do we need to use --amend? Should these be one commit or can they be 2 commits? If we squash on merge then we probably don't need to do --amend
[x] We should eliminate setting HasChanges if possible.

These cleanups are complete.


php artisan docs command opens a new shell window instead of browser

Hi guys, I'm very excited about the new artisan docs command.
Unfortunately on my local dev machine the behavior is not as expected.
I'm using vscode with powershell and the artisan docs command does open a new shell window intead of opening my browser.
Might be solveable via a local config update .. but idk where.
Anyone who can give advice?

Laravel Version: Laravel Framework 9.23.0
PHP Version: PHP 8.1.6 (cli)
Database Driver & Version:
OS: Win10 x64
PowerShell: PSVersion 5.1.19041.1682
VSCode: 1.70.0
NodeJS: v18.1.0
Xampp: Xampp with php 8.1.6

Description:
php artisan docs opens a new shell window instead of opening my browser
Steps To Reproduce:
1.) Enter in vscode shell console php artisan docs validation rules
Hint
If I enter into the same console start https://laravel.com/docs/9.x/validation#available-validation-rules  then it is working as expected and a new tab is opened in my standard browser

I'm facing the same issue in the exact same version.

i guess this is solved by https://github.com/laravel/framework/pull/43566

I believe this will be fixed by the above mentioned PR and will be released on Tuesday. Please let me know if issues still persist.

Confirmed. Works now as expected.

Fantastic news. Thanks for reporting back @hopkins385


Add newline to Output

I am using nvim-ipy primarily for data analysis, and I noticed that due to the way the output is displayed, the first row of data (the one in the same row as the Out key word) is always shifted too far right.
This makes looking at tables kind of a pain.
Hence, I propose that a newline is inserted in the Output line in order to fix this display annoyance.

please try latest master.


⚠ Minecraft has degraded performance

In 9491269, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 1525 ms

Resolved: Minecraft performance has improved in 48f7630.


GCC segfaults when compiling engineFunctions.h

Ubuntu 14.04.5 - x86_64 - Kernel <IP_ADDRESS>-generic
gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4 (stock GCC compiler)
When building Torque3D's development branch, GCC 4.8.4 will generate a segmentation fault:
In file included from /home/gstewart/dev/Torque3D/Engine/source/console/consoleObject.h:45:0,
                 from /home/gstewart/dev/Torque3D/Engine/source/console/simObject.h:30,
                 from /home/gstewart/dev/Torque3D/Engine/source/console/simBase.h:33,
                 from /home/gstewart/dev/Torque3D/Engine/source/app/badWordFilter.cpp:26:
/home/gstewart/dev/Torque3D/Engine/source/console/engineFunctions.h: In substitution of ‘template<class ... ArgTs> template<class T> using DefVST = typename EngineTypeTraits<T>::DefaultArgumentValueStoreType [with T = const char*; ArgTs = {<expression error>}]’:
/home/gstewart/dev/Torque3D/Engine/source/console/engineFunctions.h:116:93:   required from ‘static _EngineFunctionDefaultArguments<void(ArgTs ...)>::MaybeSelfEnabled<TailTs ...> _EngineFunctionDefaultArguments<void(ArgTs ...)>::tailInit(TailTs ...) [with TailTs = {const char*, const char*}; ArgTs = {const char*, const char*}; _EngineFunctionDefaultArguments<void(ArgTs ...)>::MaybeSelfEnabled<TailTs ...> = std::tuple<const char*, const char*>]’
/home/gstewart/dev/Torque3D/Engine/source/console/engineFunctions.h:122:91:   required from ‘_EngineFunctionDefaultArguments<void(ArgTs ...)>::_EngineFunctionDefaultArguments(TailTs ...) [with TailTs = {const char*, const char*}; ArgTs = {const char*, const char*}]’
/home/gstewart/dev/Torque3D/Engine/source/app/badWordFilter.cpp:257:1:   required from here
/home/gstewart/dev/Torque3D/Engine/source/console/engineFunctions.h:116:93: internal compiler error: Segmentation fault
       SelfType::copyHelper<TailTs...>(argsT, tailT, typename Gens<sizeof...(TailTs)>::type());
                                                                                ^
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-4.8/README.Bugs> for instructions.
Preprocessed source stored into /tmp/cckocAvX.out file, please attach this to your bugreport.
...

Steps to reproduce:

On Ubuntu 14.04 with GCC 4.8.4, run the following cmake:
cmake ../../../.. -DTORQUE_APP_NAME=MyGame -DCMAKE_BUILD_TYPE=Release -DVIDEO_MIR=0

Run make

Note: Torque3D compiles without issue on the 3.10 release (only development has this issue).  While this does look like a bug with GCC, the fact that this GCC version is the stock one that comes with Ubuntu 14.04 LTS might be worth creating a workaround for.

Some variadic templates were added to cleanup the console api, looks like gcc 4.8.x support for c++11 is not that great. I don't know if gcc 4.9.x works but i know gcc 5.x does.


[KYUUBI #662]Fix run on k8s

Why are the changes needed?

When run on k8s, engine write hostname to zk. But, server can not connect pod by hostname, we should use ip instead.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #663 (736261a) into master (c52b953) will decrease coverage by 0.07%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
- Coverage   80.09%   80.02%   -0.08%
==========================================
  Files         120      120
  Lines        4693     4706      +13
  Branches      568      571       +3
==========================================
+ Hits         3759     3766       +7
- Misses        610      612       +2
- Partials      324      328       +4

Impacted Files
Coverage Δ

...la/org/apache/kyuubi/service/FrontendService.scala
96.38% <71.42%> (-0.61%)
:arrow_down:

...n/scala/org/apache/kyuubi/service/Serverable.scala
44.44% <100.00%> (ø)

...ala/org/apache/kyuubi/util/KyuubiHadoopUtils.scala
62.50% <0.00%> (-20.84%)
:arrow_down:

...org/apache/spark/kyuubi/SQLOperationListener.scala
92.30% <0.00%> (-5.13%)
:arrow_down:

...ache/kyuubi/engine/spark/SparkProcessBuilder.scala
88.60% <0.00%> (-0.73%)
:arrow_down:

...cala/org/apache/kyuubi/config/internal/Tests.scala
100.00% <0.00%> (ø)

.../org/apache/kyuubi/operation/KyuubiOperation.scala
59.09% <0.00%> (+1.51%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c52b953...736261a. Read the comment docs.

cc @zwangsheng

@hddong
Can we control this on the Kyuubi side not based on the cluster manager where engines running against?
We can add a conf directly e.g. kyuubi.engine.connection.url.use.hostname=true, then whether underlying platform change or not, we can use this to switch hostname or IP?

Hi @hddong , What mode did you submit ？

Hi @hddong , What mode did you submit ？
cluster mode, dirver as a pod.

thanks, merged to master for v1.3.0


kernel not starting on Mac

I can't get a kernel with either 1.9-rc1 or 1.8.5. I have tried
build IJulia

and starting over with an empty .julia directory. The latter step has always worked before. I'm getting a banner on the top of the notebook about Notebook 7. Could that be part of the problem.
I'm on a Mac Mini, M2 pro, latest OS.
I added my woes to the older issue  #1062, but it seems that it's closed and nobody is looking at it.

I was able to open an empty notebook and get a kernel with 1.9-rc1, but my older ones will not connect to a kernel. Is there something I need to do that goes beyond changing the kernel?
The red "not connected" box just sits there.

I finally got 1.8.5 working for some, but not all, of my notebooks. The kernel takes a very long time to load, but it finally does, when it works, after reporting failure several times.
I think the notebooks that fail were built with versions prior to 1.8. I have also tried 1.6.7 with no success.
With 1.9-rc1 I am unable to open an existing notebook even if I set the kernel to 1.8.5.

Sorry for posting twice. Posted this on the closed issue by mistake.
I am at a loss. Nothing works consistently and I have no idea how to proceed. I cannot find the .json file. I have tried taking out
ENV["PYTHON"]=""
ENV["CONDA_JL_USE_MINIFORGE"] = "1"
out of my startup.jl, but that did not seem to change anything. I can only hope that this gets fixed eventually. As it stands now, I cannot use IJulia. Even if I create a new notebook, I can't reopen it later.
I tried using the Intel builds with Rosetta, and got similar results.

It's obviously not the same problem as #1062, because (a) that didn't affect Julia 1.8 and (b) it was fixed for 1.9.   Misdiagnosing the problem does not help us to help you.
IJulia works fine for me on M4 macs, so it's hard to say what the problem is on your machine.

Is there anything I can do to clarify this issue?C. T. @.*** Mar 24, 2023, at 4:05 PM, Steven G. Johnson @.***> wrote:
It's obviously not the same problem as #1062, because (a) that didn't affect Julia 1.8 and (b) it was fixed for 1.9.   Misdiagnosing the problem does not help us to help you.
IJulia works fine for me on M4 macs, so it's hard to say what the problem is on your machine.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Telling me everything works for you on Macs helped. So ...
I started completely from scratch. Started 1.8.5 with an empty .julia directory. I only installed IJulia and PyPlot.
Then I successfully started IJulia and made a three line notebook.
Test_IJulia - Jupyter Notebook.pdf
I could close and restart the notebook from the same Julia session. I closed the REPL and tried to open the same notebook from IJulia in the new Julia session and that worked.
Then I tried the same thing with
notebook(;dir=pwd())

and all was well.
I copied the .ipynb file to my Dropbox directory and fired up IJulia from my home direction and tried to open the file in the Dropbox directory. At that point IJulia found the kernel and all was well.
Whan I started from the Dropbox directory and did
notebook(;dir=pwd())

I got a kernel (after a fairly long wait) and the notebook worked.
Then I moved the kernel to a subdirectory of the Dropbox directory. I tried
notebook(;dir=pwd())

and could not get a kernel.
I also tried
notebook()

from my home directory and navigated to the Dropbox subdirectory. I could not get a kernel.
Finally, I copied the Dropbox subdirectory to my home directory. Tried
notebook(;dir=pwd())

from the copied subdirectory, and failed to get a kernel.
This is all I can tell you. If this is a Dropbox or subdirectory issue that you know about, telling me about that would be useful. If a stack trace would help, please tell me how to get one of those.

Then I moved the kernel to a subdirectory of the Dropbox directory.

I don't understand what you mean by this.  You can't just move the IJulia kernel to a different directory and expect it to work.  Or do you mean something different by "kernel" here?
The dir argument in notebook(;dir=pwd()) is not the directory of the kernel.  It is the directory where Jupyter looks for .ipynb files.

Sorry. "move the kernel" means start over with julia in the Dropbox directory.
I am still trying to figure out the problem. I think that the failure consistently happens when I try to open a notebook in a directory that contains a notebook build with a pre 1.8 version of Julia. If that is the issue, I can fix my immediate problem by copying the old notebook one cell at a time into a new one in a different directory.
Is there any reason why an old notebook could cause problems? I deleted the version of Julia that created this notebook long ago.

I tried to copy a notebook I just created into one of the problem directories with an old notebook in it. I got a popup about token authentication
Jupyter Notebook.pdf
I get nothing with I type jupyter notebook list on this MAC. I have been letting Julia deal with python for me and did not expect this.

I cannot create or open notebooks in any directory with old notebooks in it. Nor can I do that in the subdirectories. Even if I more a notebook I just made into a directory with an old notebook, I can't open it. When I move the new notebook out, then I can open it.
This behavior seems to be completely consistent.
Can an old notebook somehow poison a directory?

Sorry. "move the kernel" means start over with julia in the Dropbox directory.

As explained in the docs, if you move the julia binary, you need to re-build IJulia: https://julialang.github.io/IJulia.jl/stable/manual/installation/#Updating-Julia-and-IJulia

I'm not being clear. I never moved julia out of /Applications. I just started Julia in different locations from a terminal windoe.

The problem directories were projects with the old formal for Manifest.toml. This seems to be the problem and I fixed it by reactivating the project and generating a new Manifest.toml.
I'm closing this issue. I can't figure out why IJulia knew about the Manifest.toml file, but it looks like it did.


Blurry Loading Page

Description 📜
This code creates a Blurry Loading Page.
Fixes #8517

Type of change 📝

[ ] Au#dio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
[ ] Vi#deo (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
[x] Documentation (Content Creation in the form of codes or tutorials)
[ ] Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

[ ] Android Dev #(Flutter)
[ ] Android Dev #(Java)
[ ] Android Dev #(Kotlin)
[ ] Backend Dev #(Java)
[ ] Backend Dev #(.NET)
[ ] Backend Dev #(PHP)
[ ] Backend Dev #(Python)
[ ] C/#CPP
[ ] Competitive #Programming
[ ] Cyber #Security
[ ] DS#A
[ ] Data#base
[ ] Datascience with #Python
[ ] Datascience with #R
[x] Frontend Dev HTML/CSS/JS
[ ] Frontend Dev #React/Angular/Vue
[ ] Go#lang
[ ] Interview #Prep
[ ] Java_#Domain
[ ] JavaScript_#Domain
[ ] ME#RN
[ ] Machine #Learning
[ ] Open #Source
[ ] Python_#Domain
[ ] Ru#st
[ ] Statis#tics
[ ] UI/#UX

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

⚠⚠ ⚠ ⚠ ⚠ ⚠
Hello @muskan612
You need to clone and create PR to the correct branch, you are dealing now with the main branch, which can't be merged.


small issue with partials and swig

Hi there. Using the metalsmith CLI, I have trouble configuring / using partials with the Swig templating engine.  Here is a reduced test case.
metalsmith.json
"metalsmith-layouts": {
      "engine": "swig",
      "directory": "layouts",
      "partials": "includes"
    }

layouts/default.html
<!DOCTYPE html>

    <meta charset="utf-8">
    <title>This is a Metalsmith test</title>

    {% include "test.html" %}

    {{ contents|raw }}

src/index.html
---
layout: default.html
---

Hello world

includes/test.html

This is a test

I get the following error
Metalsmith · ENOENT, no such file or directory '/data/weblocal/metalsmith_sandbox/layouts/pouet.html'
Any idea / pointer ?

Try this:

I'd move all layouts outside of ./src. Otherwise you might end up with some unwanted recursiveness. Move them to ./layouts for example (and remove the directory option).
Remove the partials option. It isn't necessary for swig includes.
Put your test.html include in ./layouts. Swig includes are relative to the layouts directory, so that way {% include "test.html" %} should work.

Now it should work. Let me know.

Many thanks for coming back to me so quickly. Much appreciated.

Everything out of ./src (typos in my original issue). I have left the directory option since I like to be explicit (team members are not familiar with Metalsmith)
and 3. Done. It does work like that. That was the issue I was having. Whatever I did before, it was always the ./layouts folder that was called for includes

Couple of related questions

So Swig includes are always relative to the layouts directory ? Is there no way to have layouts and includes in separate directories w/ Swig ? I realise this is just cosmetic but I am used to Twig where this is definitely possible.

With metalsmith, is it possible to use the usual {% block %}{% endblock %} and {% extends 'templates/default.html' %} tags instead of Yaml front matter and {{ content }} tag ? If so, how do you do that ? I haven't managed to get it working.

Again, thanks for your help.

So Swig includes are always relative to the layouts directory?

I'd have to test it to be sure (because each templating engine differs), but it's either relative to the layouts dir, or the current layout. Not certain which of those two it is (it ultimately depends on consolidate's implementation).

Is there no way to have layouts and includes in separate directories w/ Swig?

You could, but then it would be something like {% include "../includes/test.html" %} instead of {% include "test.html" %} because of the relative path.

With metalsmith, is it possible to use the usual {% block %}{% endblock %} and {% extends 'templates/default.html' %} tags instead of Yaml front matter and {{ content }} tag ?

Definitely. You can use both. Basically all that the yaml front matter does is define local variables. And the contents variable is just that, a variable. That variable is passed to the selected layout and the result is compiled.
But that being said; if you're going to use swig I'd recommend metalsmith-in-place. Metalsmith-layouts is just meant as a shim for languages that don't support template inheritance, like handlebars.
Check out https://github.com/ismay/ismaywolff.nl for an example. I'm using nunjucks, which is very similar to swig, so you should be able to adapt it to your liking. Let me know if that helps.

Oh, by the way, metalsmith-in-place render things a little differently, so when using extends and includes paths are relative to the root of the project (since there are no layouts). You'll see that in my repo.

ok. Will have a look. Still not very clear to me how to use that with the CLI but I guess I can figure it out with the various links you provided. Thanks again ! Coming from Jekyll here and the Metalsmith doc is rather sparse ;o)

Coming from Jekyll here and the Metalsmith doc is rather sparse ;o)

Yeah I know :). It can be frustrating but it's worth the effort I think. I'll update the readme to address your questions.
Also, the boilerplates use the javascript api, but the basic configuration should work for the cli just as well. And if you're going to use extends don't forget to use metalsmith-filenames.
I'll close this, but feel free to let me know if you have any further questions!


Connecting ended in an error: websocket: close 4450: SHIP id mismatch

Hello!
I get this error when connecting to a Vaillant eebus device.
Connecting ended in an error: websocket: close 4450: SHIP id mismatch
https://github.com/enbility/ship-go/blob/acb2920b6711f331389cef7f37a6beb209a089a6/ship/hs_access.go#L63
Maybe because the application is using outdated versions of the eebus libraries?

Hi, this usually happens if the device is paired with a service, and that one changed its SHIP ID compared to when it was paired. To fix this, remove the test service from the Vaillant device as a trusted device, and pair it again.


Add privacy and data sharing policy at /privacy-policy

Placeholder for now, copy TBD

Make sure to sync with @EwaPrzem

Closed by https://github.com/findthemasks/findthemasks/pull/537


playwright: Manage specific test contexts to allow to run multiple tests in parallel

Currently in the testHelpers, there is a global context/page objects and object ids are also global.
This means that if we run more than one tests, they get mixed up and use the data that was last set. Each test should define their context objects, that should be passed to all helper functions.

fixed in #496


removed scheduled job in code.yaml and added keepalive-workflow

Closes #104
Removes the scheduled job in code.yaml and adds keepalive-workflow to prevent inactivity after 60 days.
We established there would be inactivity after 60 days in #104.:
          Looks like this is still a problem:

I think we should go ahead and remove the schedule from code.yaml, and add the keepalive-workflow as the last step of linkcheck
Originally posted by @coretl in https://github.com/DiamondLightSource/python3-pip-skeleton/issues/104#issuecomment-1400588421

Please can you squash to a single commit and I'll merge


Revert "module.require" handling as "require" change

Bug report

What is the current behavior?
Since v4.16.2, module.require is handled as require.
If the current behavior is a bug, please provide the steps to reproduce.
module.require has been used to hide import of non-browser modules in many projects.
There is a common idiom to add Node.js-specific functionality with various alternations:
const isNode = /* implementation defined */;

// Target-based implementation
const feature = isNode ? module.require( './node/feature' ) : require( './browser/feature' );

// Or extra features
const api = {};

if (isNode) {
    // adds or replaces some items
    module.require( './some/module' )( api );
}

Yes, the problem can be fixed in the project in question, but other software which already depends on older version of the project release gets still affected.

What is the expected behavior?
Ignore module.require as  before v4.16.2.

Other relevant information:
webpack version:  4.16.5
Node.js version: N/A
Operating System: N/A
Additional tools: N/A
Related #7777 .
The change was introduced in v4.16.2 by PR https://github.com/webpack/webpack/pull/7750 for issue https://github.com/webpack/webpack/issues/7728 without any sane justification and risk analysis.
In any case, such serious behavior change should not be done without major webpack version change and/or without configuration option to control such behavior.

I did a code search on github and didn't found this pattern in the first 100 pages. So it doesn't seem so popular.
It was changed because it is considered as bugfix. Code like const x = module.require("x") reads with the intend to require x. This behavior is even documented in the node.js documentation and the CommonJS implementation of webpack is written with the intend to behave like node.js.
On the other side code like you mentioned above works because it relies on buggy behavior of webpack. It relies on module.require being broken.
We handle semver in a way that bugfixes are not considered as breaking changes by default, even if they are breaking changes when relying on buggy behavior. In this case fixing a bug is worth more than not breaking other code. There may be exceptions when many people are affected, but this doesn't seem to be the case here.
Note that there is a clear way of defining such "target-based" module replacements, which is the browser field:
const isNode = /* implementation defined */;

// Target-based implementation
const feature = require( './node/feature' );

// Or extra features
const api = {};

if (isNode) {
    // adds or replaces some items
    require( './some/module' )( api );
}

{
  "browser": {
    "./node/feature": "./browser/feature",
    "./some/module": false
  }
}

OK, I am closing this for now.


Add pool_recycle and pool_size to mysql sqlalchemy

Add pool_recycle and pool_size to mysql sqlalchemy backend.
MySQL has a setting wait_timeout which will drop connections after being idle for a certain time. This setting is defaults to 8 hours but some distributions default it to 10 minutes. If a connection is dropped by MySQL without SQLAlchemy expecting it it will cause the client to raise an exception with the message (2006, 'MySQL server has gone away'). Setting pool_recycle to less than wait_timeout is a common way in SQLAlchemy to work around this as it will cause SQLAlchemy to replace any connections older than this value.

I set the default to 1 hour as it seems like a reasonably sane value, but I'll be just as happy keeping it as unset by default and letting users configure it via settings.

Saw this pull request after mine ...
I suffered from closed connections too using MariaDB.

Obsoleted by #400 - we should start pushing for ORM integration etc. to be third party packages. (Tho typically you only need that if you want eg. implicit commit/rollback dealt with by event hooks)


[BUG] can't create pvc when using minio

What happened: can't create pvc when using minio
minio have region information, but didn't find how to set it in env

Hi @kozora , you can set env in secret, refer to this doc for more details. Thanks.

Hi @kozora , you can set env in secret, refer to this doc for more details. Thanks.

do I need set AWS_DEFAULT_REGION or AWS_REGION for minio region setting


Using globalSetup and globalTeardown with TypeScript

Description
I'm having a similar problem as in #5164. Consider the following working test code with typeorm:
// AccountResolver.test.ts
describe('Account entity', () => {
  it('add account', async () => {
    await createConnections()
    const defaultConnection = getConnection('default')

    const actual = await callGraphql(
      `mutation {
        addAccount(options: {
          accountIdentifier: "7csdcd8-8a5f-49c3-ab9a-0198d42dd253"
          name: "Jake, Bob (Braine-l’Alleud) JAM"
          userName<EMAIL_ADDRESS>        }) {
          accountIdentifier
          name
          userName
        }
      }`
    )
    expect(actual.data).toMatchObject({
      data: {
        addAccount: {
          accountIdentifier: '7csdcd8-8a5f-49c3-ab9a-0198d42dd253',
          name: 'Jake, Bob (Braine-l’Alleud) JAM',
          userName<EMAIL_ADDRESS>        },
      },
    })

    await defaultConnection.query(`DELETE FROM Account`)
    await defaultConnection.close()
  })
})

The code to create a connection and close it should be executed before all tests and after all tests are done, that's why we've added it to globalSetup.ts and globalTeardown.ts:
// globalSetup.ts
require('ts-node/register')
import { createConnections } from 'typeorm'

module.exports = async () => {
  // console.log('jest setup')
  await createConnections()
}

// globalTeardown.ts
require('ts-node/register')
import { getConnection } from 'typeorm'

module.exports = async () => {
  const defaultConnection = getConnection('default')
  await defaultConnection.close()
}

// AccountResolver.test.ts
describe('Account entity', () => {
  it('add account', async () => {
    const defaultConnection = getConnection('default')
    await defaultConnection.query(`DELETE FROM Account`)

    const actual = await callGraphql(
      `mutation {
        addAccount(options: {
          accountIdentifier: "7csdcd8-8a5f-49c3-ab9a-0198d42dd253"
          name: "Jake, Bob (Braine-l’Alleud) JAM"
          userName<EMAIL_ADDRESS>        }) {
          accountIdentifier
          name
          userName
        }
      }`
    )
    expect(actual.data).toMatchObject({
      data: {
        addAccount: {
          accountIdentifier: '7csdcd8-8a5f-49c3-ab9a-0198d42dd253',
          name: 'Jake, Bob (Braine-l’Alleud) JAM',
          userName<EMAIL_ADDRESS>        },
      },
    })
  })
})

Omitting the line require('ts-node/register') from both files throws this error:

T:\Test\Brecht\Node\prod\backend\src\it-portal\entity\Account.ts:1
import {
^^^^^^
SyntaxError: Cannot use import statement outside a module

Keeping them in throws:

FAIL  src/resolvers/AccountResolver.test.ts
Account entity
× add account (31 ms)
● Account entity › add account
ConnectionNotFoundError: Connection "default" was not found.

Version
    "jest": "^26.0.1",
    "ts-jest": "^26.1.0",
    "ts-node-dev": "^1.0.0-pre.44",
    "typescript": "^3.9.5"

Config
// jest.config.js
module.exports = {
  preset: 'ts-jest',
  globalSetup: './src/test-utils/config/globalSetup.ts',
  globalTeardown: './src/test-utils/config/globalTeardown.ts',
  setupFiles: ['./src/test-utils/config/setupFiles.ts'],
  moduleDirectories: ['node_modules', 'src'],
  globals: {
    'ts-jest': {
      tsConfig: 'tsconfig.json',
      diagnostics: {
        warnOnly: true,
      },
    },
  },
  coverageThreshold: {
    global: {
      branches: 80,
      functions: 80,
      lines: 80,
      statements: 80,
    },
  },
  coverageReporters: ['json', 'lcov', 'text', 'clover'],
}

Thank you for pointing out my mistakes. As I'm new I tried googling but couldn't really find an answer if this is me not understanding the tool or a bug in the tool.
Found a similar issue here with a PR and a similar question on StackOverflow..
Workaround
The only workaround I have found thus far is to add the following code to every test file:
beforeAll(async () => {
  await createConnections()
})

afterAll(async () => {
  const defaultConnection = getConnection('default')
  await defaultConnection.close()
})

I have the same problem, but I think this sandboxing behavior is intended.
The only cleaner solution I found to this is using setupFilesAfterEnvto not copy/paste the logic into every test. If not all tests rely on the connection I consider migrating to testEnvironment.

You're right, I also define the database connection within the setupFilesAfterEnv now.
@impulse  Could you elaborate what you mean with this statement:

If not all tests rely on the connection I consider migrating to testEnvironment.

@impulse Could you elaborate what you mean with this statement:

From the docs

A list of paths to modules that run some code to configure or set up the testing framework before each test file in the suite is executed

So this also affects tests that don't require a TypeORM connection.
With testEnvironment we could just add a comment to be more flexible on whether or not we connect to TypeORM for a specific test:
/**
 * @jest-environment ./path/to/typeorm-environment.ts
 */

Thank you for the clarification, that looks pretty neat! This would also be useful to remove the argument --runInBand so tests could run in parallel. Having a deeper look at that.

This would also be useful to remove the argument --runInBand so tests could run in parallel using the same database connection per file

I think this sadly won't be possible

Note: TestEnvironment is sandboxed. Each test suite will trigger setup/teardown in their own TestEnvironment.


Guide for dataset contribution

I'll add some reference on what i think is missing for the assets contribution page.

Specifies if a parameter is optional or not.
Specifies what a param is needed for ?

https://github.com/methusalah/OpenRTS/wiki/Guide-for-dataset-contribution#unit

 -> GroundProne is a define value or arbritrary ?

https://github.com/methusalah/OpenRTS/wiki/Guide-for-dataset-contribution#actor
https://github.com/methusalah/OpenRTS/wiki/Guide-for-dataset-contribution#mover

these should be done since they seam to be required by the unit and projectile

As example of another way to present information (be kind i don't fully understand what each value is) :
Unit
<Unit id="tank">
    <UIName value="simple combat armored vehicle"/>
    <Race value="human"/>
    <Radius value="0.8"/>
    <Speed value="4"/>
    <Mass value="1"/>
    <MaxHealth value="120"/>
    <MoverLink value="GroundProne"/>
    <WeaponList WeaponLink="TankCanon" TurretLink="TankTurret"/>
    <WeaponList WeaponLink="TankMachinegun" TurretLink="TankMachinegun"/>
    <WeaponList WeaponLink="TankFrontLaser"/>
    <ActorLink value="Tank"/>
</Unit>

Required value :

MoverLink (see # Mover)
ActorLink (see # Actor)
MaxHealth (Maximum amount of health the unit have)
Radius (Collision size of the unit)
Mass (Acceleration and inertia...) (as side note i don't understand the inertia think, deceleration ?)
Speed (How many meter does the unit move by sec (m/s))

Optional value :

WeaponList (one or many) (see # Weapon)
UIName (Description name to use)
Race (...idn...)

About the WeaponList the current one is kinda tricky, i think that it should be renamed WeaponLink and work like all other value, this give us :

WeaponLink value="TankCanon"
WeaponLink value="TankMachinegun"
WeaponLink value="TankFrontLaser"

Then the turret value would be stored inside the Weapon himself as :
Weapon
<Weapon id="TankCanon".>
    <UIName value="ubber powerful canon"/> (I don't think this is needed)
    <EffectLink value="StdDamage"/>
    <Range value="5"/>
    <ScanRange value="7"/>
    <Period value="1.2"/>
    <ActorLink value="TankCanonMainActor"/>
    <SourceBone value="BMuzzle01"/>
    <DirectionBone value="BMuzzleVec01"/>
    <TurretLink value="TankTurret"/>
 </Weapon>

Required value :

EffectLink (see # Effect)
ActorLink (see # Actor)
SourceBone (projectile source)
DirectionBone (projectile direction)
Range (How far the weapon can shoot)
Period (Delay between two attack)
ScanRange (how far the unit start moving to get in range)

Optional value :

TurretLink (Is this weapon a turret)
UIName (Description name to use)

"GroundProne" is the ID of the mover to use. I will change it to a more generic term in the wiki.
About the presentation, indeed, I need to add info and make myself clearer :) I'll try it.
In the current nomenclature, $Link is a parameter containing the ID of another definition, $List is a parameter that may be used many times. It may be not wise to store the turret inside the unit def, because :

a weapon may be reused with or without a turret (or another type of turret). Imagine a gatling under a plane wing, and mounted on a jeep
a turret may be used for many different weapons. Imagine multiple version of the same tank, holding a DCA or a canon, or a missile launcher...

Note that UInames shouldn't be optionnal, as it is shown inside the GUI on the mouseover for exemple.

$Link is a parameter containing the ID of another definition, $List is a parameter that may be used many times.

Add this to the wiki so we know.
I go the point about turret, you can forget what i'd said earlyer, but talk about the turret, the current name is still confusing since when we talk about turret we first think about static turret.
keep in mind that what i wrote is just an exemple idn what is optional or not :D

I adopted you suggestion because it seemed wise to me, thanks ! I will add a short description for the element to avoid any confusion about the "turret" term.
I also added you to collaborators, so you can contribute to the wiki as you wish.
If these changes fit this issue, we may close here :)

You welcome.
Yes we've done there,
if you don't mind I'll add an issue for each missing part of the wiki.


docs: dark mode

Description of changes:
Something like this would be easier on the eyes when most of the time
you are coding in dark mode style themes

[x] Meet tenets criteria

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #471 (a086c3c) into develop (8724294) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #471   +/-   ##
========================================
  Coverage    99.90%   99.90%
========================================
  Files          105      105
  Lines         4233     4233
  Branches       206      206
========================================
  Hits          4229     4229
  Misses           1        1
  Partials         3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8724294...a086c3c. Read the comment docs.

@mergifyio refresh


Does Material Tailwind support SolidJS?

Hey @kulame,
You can use the html version for SolidJS, there is no specific version for SolidJS yet.
Regards,
Sajad


cannot enforce type shape when assigned to a conjunction

TypeScript Version:  3.1.6, 3.2.0-rc, 3.3.0-dev.20181121
Search Terms:
conjunction assignable wrong type
Code
declare const a: { a: string; b: number }
declare const b: { a: string } & { b: number }
declare function f(x: { [k: string]: string }): void
f(a) // error
f(b) // NO error

Expected behavior:
Errors on both f(a) and f(b)
Actual behavior:
Errors only on f(a)
Playground Link: http://www.typescriptlang.org/play/#src=declare const a%3A { a%3A string%3B b%3A number }
declare const b%3A { a%3A string } %26 { b%3A number }
declare function f(x%3A { [k%3A string]%3A string })%3A void
f(a) %2F%2F error
f(b) %2F%2F NO error
Related Issues: https://github.com/gcanti/io-ts/issues/234#issuecomment-440752593
https://github.com/gcanti/fp-ts-routing/issues/37

I'm guessing this type relaxation is required in certain scenario (with named members), however, with an indexed type on string (covering both 'a' and 'b'), I would rather expect it to fail.

T & U is assignable to T
{ a: string } is assignable to { [k: string]: string }

String indexers are unsound like this when properties are 'forgotten'. Another example:

{ a : string; b: number } is assignable to { a: string }
{ a: string } is assignable to { [k: string]: string }

const a: { a: string; b: number } = { a: 'foo', b: 42 };
const b: { a: string } = a
const c: { [k: string]: string } = c;
c.b = "not a number"
const shouldBeNumber: number = a.b;

@jack-williams indeed.
The amount of consequences of the unsoundness is frightening.

@jack-williams Quoting the spec is not advised, as the spec was last updated around 3 years ago.

This was fixed by #35143, whose description contains effectively this issue's repro


Fix show in IE11

Setting element.style.display to null in IE11 has no effect.
So if the suggest widget was hidden for some reason, and then
shown again, it just stayed hidden.
This issue also prevented the "No suggestions" message from displaying.
Fixes: https://github.com/Microsoft/monaco-editor/issues/96

Hi @sandyarmstrong, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Sandy Armstrong). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

I used '' for consistency with other code from this repo (see goToError.ts and extensionsList.ts), but maybe initial or unset would be more appropriate.

Nice catch! Thank you!


Missing  "priority" in the main datadog_monitor resource

Describe the Bug
The provided map with priority set is not passed to the main datadog_monitor resource, the key/parameter is missing from the resource input from the provided map.
Expected Behavior
The main resource should include the "priority" input
Steps to Reproduce
Create any monitor map with priority key
Screenshots

Environment
macOS
Module version: 1.3.0
Datadog Provider 3.35/3.34
Additional Context
I forked and I will add a pull request with the fix

while doing the fix for priority input I have noticed that some other inputs were excluded from the provided monitor map, the investigation shows that the variable limits the usage to the objects, the fully back compatible solution would be updating the variable to use map(any) instead of map(object()) with provided list of inputs.
I have created a fix for all these and included the missing inputs with lookups to the datadog_monitor to cover all inputs in the resource. I'll open a PR with these changes

Thank you for a quick update, also the original but I opened was wrong, I didn't use the example properly, dismissed the path to modules/monitors, instead to the main, after I changed it in my example    all worked ok
Also the new update to Tags is better than before, thank you


Planet radius variable incorrectly described in documentation

Planetary radius is reported in meters. The documentation for EDDI (variables.md) incorrectly indicates that the radius is reported in kilometers.

{ "timestamp":"2017-07-15T02:16:44Z", "event":"Scan", "BodyName":"59 Arietis 1", "DistanceFromArrivalLS":291.981720, "TidalLock":true, "TerraformState":"", "PlanetClass":"High metal content body", "Atmosphere":"", "AtmosphereType":"None", "Volcanism":"", "MassEM":1.081989, "Radius":6234260.500000, "SurfaceGravity":11.095899, "SurfaceTemperature":629.901367, "SurfacePressure":0.000000, "Landable":true, "Materials":[ { "Name":"iron", "Percent":21.747345 }, { "Name":"nickel", "Percent":16.448780 }, { "Name":"sulphur", "Percent":15.598898 }, { "Name":"carbon", "Percent":13.117059 }, { "Name":"chromium", "Percent":9.780503 }, { "Name":"manganese", "Percent":8.981431 }, { "Name":"phosphorus", "Percent":8.397765 }, { "Name":"selenium", "Percent":2.441360 }, { "Name":"ruthenium", "Percent":1.343037 }, { "Name":"tungsten", "Percent":1.194148 }, { "Name":"mercury", "Percent":0.949671 } ], "SemiMajorAxis":87533461504.000000, "Eccentricity":0.000009, "OrbitalInclination":-0.013004, "Periapsis":306.780884, "OrbitalPeriod":15782457.000000, "RotationPeriod":15782763.000000, "AxialTilt":0.253417 }
The system map records the radius of the same body as "6,234 KM"

The journal reports the radius in metres, but EDDI converts it to kilometres by default.
I just added this line into EDDI and set reportbody to 59 Arietis 1.
It has a radius of {reportbody.radius} kilometers.
EDDI spoke this line as "It has a radius of 6234 kilometers."

I thought that I'd proved it to be meters rather than kilometers, but with further testing I can confirm that you're right. Closed.


Update dependencies and workflows

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.21%. Comparing base (f92f123) to head (cd6d8b5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #679   +/-   ##
=======================================
  Coverage   99.21%   99.21%
=======================================
  Files          26       26
  Lines        2042     2042
  Branches      295      295
=======================================
  Hits         2026     2026
  Misses         16       16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


The docs and blogs should be thansferred to https://github.com/seata/seata.github.io

https://github.com/seata/awesome-seata/tree/master/wiki
The docs and blogs should be thansferred to https://github.com/seata/seata.github.io

closed via https://github.com/seata/seata.github.io/commit/8f572c903b6224f89f94b5058d8deb33cfe4b21c


Wrong docs for snippets in suggestion list

From @vvs in https://github.com/Microsoft/vscode/issues/28933#issuecomment-310997352
There is one issue though (actually two), regarding snippets.
Say, I have  a snippet called bidi (for bi-directional SCSS mix-ins).
== Issue 1 ==
I type 'b' and see the following:

The help for my snippet bidi is wrong.
== Issue 2 ==
When I type the full name of the snippet, bidi in this case, it is still listed below the Emmet suggestion (which seems completely unrelated to the name of my snippet):

The first issue will be fixed with https://github.com/Microsoft/vscode/commit/99ffa6afcf86c9ca3dc618570f383a236efaaa2e
Stale docs were showing up for snippet suggestions when suggestion list was initially triggered.
Logged #29473 as it is a different issue altogether

Note to verifier:

Set emmet.useNewEmmet to true
Have the snippet bidi with some description
Type bidi , expand docs to see the emmet related docs
Esc , backspace until you just have b, trigger suggestions again
You should see bidi with the right description


fix: do not break the build when branch names do not begin with a ticket

Here is an example pipeline with a different branch name and a passing build https://github.com/VirdocsSoftware/university-workflows/actions/runs/8898798462


Feature request: use track by in ng-repeat to watch for changes

This has been discussed in #12506, but I guess there wasn't any follow up.
I'm expecting that the following should work:
ctrl.getItems = function () {
  return [{id: 0}, {id: 1}, {id: 2}];
};

{{ item.id }}

But it doesn't and results in not-very-informative "10 $digest() iterations reached. Aborting!".
It would be great if track by would do as it says, i.e. "track" items.
As @coli nailed it:

I thought the whole point of track by was to handle the case where the function returns a new collection/object in the first place

Initialyze your array in your scope. Then replace the items in the array and track by id will work

Track by makes it easier for repeat to "keep track" of the items in a collection. By default, it compares the complete object, with track by it uses the defined unique identifier. The 10 digests error is because on each digest the fn returns a new array. Imo these are two different problems.

Why can't track by use that unique identifier to compare objects in the new array?

@olegskl For the quite common scenario when you have a collection of records, each identifed by an id, and you "refresh" one of them by getting new info from backend and replaces this specific record in the collection.
The track by id is used by angular to know that only this item that must be changed, but as the record is a new object the display is refreshed.
Otherwise track by id could only be used for frozen record.
You have to change your design to avoid to build a new array each time you run getItems.
And even if it would work, returning a new array of items each time is a bad idea because you create objects at each digest loop which is impacting performance.

@olegskl frfancha is right. You use the track by expression to identify an item in the collection uniquely, so that you can update it more efficiently. You are basically asking for a way to tell the digest cycle that the collections you return from a fn are the same. I personally don't think that is possible or worth the effort, but you can open a feature request for that. If you think the track by docs should be more explicit, feel free to open a PR.


[BUG] Replace_rule will fail on Valid operation types (including RUN_INMEMORY_CODE)

I am seeing this behaviour on: (please complete the following information):

OS: [e.g. iOS]: MacOS 12.3.1
Carbon Black Cloud Products: [e.g. Endpoint Standard, Enterprise EDR, Audit & Remediation]: CB CLoud
Python Version: [e.g. 3.6]: 3.9.10

Describe the bug
Carbon Black implements a Rule Update feature as part of its API.
Rules of type REPUTATION are analogous to the "built in rules" that can be specified in a given policy.
In our examples, we try to update a rule as outlined in the API documentation
(https://developer.carbonblack.com/reference/carbon-black-cloud/cb-defense/latest/rest-api/#policy)
See section on 'Update Existing Rule'.
Depending on the content of the JSON, it is possible to receive a notification that malformed JSON has been provided.
This notification (see below), is actually a reference to the fact that an 'Operation Type' is not supported by the Java backend.
HOWEVER, this Operation Type was received initially from the backend and we're simply trying to change the action of the rule.
What this indicates to us, is that when the operation 'RUN_INMEMORY_CODE' code was added, the CB developer neglected to properly updated the supported enum types of 'PolicyOperationType' within the com.scargo.domainmodel.request.support.PolicyOperationType class.
This omission, results in a failure to be able to update rules as outlined within the API.
Please address this issue by fixing your backend code.
Steps to Reproduce
Steps to reproduce the behavior (Provide a log message if relevant):
The following example would trigger the issue:

Have a policy with the UI field 'Executes code from memory' under the 'suspected malware' section set to 'Action' Deny or Terminate.
Use the API or API wrapper to modify that rule.
Observe that the API fails spectacularly

(Pdb) print(updated_rule)
{'action': 'DENY', 'application': {'type': 'REPUTATION', 'value': 'SUSPECT_MALWARE'}, 'operation': 'RUN_INMEMORY_CODE', 'required': 'False', 'id': '816'}
(Pdb) policy.replace_rule(id, updated_rule)
*** cbc_sdk.errors.ClientError: Received error code 400 from API: {"error_code":"MALFORMED_JSON","message":"Malformed JSON input: Cannot deserialize value of type `com.scargo.domainmodel.request.support.PolicyOperationType` from String \"RUN_INMEMORY_CODE\": value not one of declared Enum instance names: [MODIFY_SYSTEM_EXE, PASSTHRU, CRED, RANSOM, NETWORK_SERVER, POL_INVOKE_NOT_TRUSTED, IMPERSONATE, MICROPHONE_CAMERA, INVOKE_SYSAPP, NETWORK_CLIENT, BYPASS_REG, BUFFER_OVERFLOW, BYPASS_API, USER_DOC, CODE_INJECTION, BYPASS_NET, KEYBOARD, BYPASS_ALL, RUN, INVOKE_CMD_INTERPRETER, MODIFY_SYTEM_CONFIG, ESCALATE, BYPASS_FILE, RUN_AS_ADMIN, BYPASS_PROCESS, NETWORK, KERNEL_ACCESS, NETWORK_PEER, PACKED, INVOKE_SCRIPT, MEMORY_SCRAPE, BYPASS_SELF_PROTECT, TAMPER_API]\n at [Source: (PushbackInputStream); line: 1, column: 126] (through reference chain: com.scargo.integration.request.PolicyRuleRequest[\"ruleInfo\"]->com.scargo.domainmodel.request.support.PolicyRuleV2[\"operation\"])","field":"ruleInfo.operation"}

You can also see in the UI when modifying this field that the operation type is mentioned AND supported via the undocumented https://defense-prod05.conferdeploy.net/appservices/v5/orgs/14947/policies/
{
  "application": {
    "type": "REPUTATION",
    "value": "SUSPECT_MALWARE"
  },
  "operation": "RUN_INMEMORY_CODE",
  "action": "DENY"
}

Expected behavior
Updates the rule as expected

Thanks for reporting this - I'll work with the backend team to resolve it.

Hi, apologies for the delay in the response.  This issue was addressed in the release of the v1 Policy Service which replaced the older implementation.

Information on the policy service v1 API is here: https://developer.carbonblack.com/reference/carbon-black-cloud/platform/latest/policy-service/
The v1 policy service API was added in version 1.4.0 of this python SDK.  Release notes: https://developer.carbonblack.com/2022/07/announcing-the-release-of-v1.4.0-of-carbon-black-cloud-python-sdk/
Information on changes and how to migrate to the new API are here: https://developer.carbonblack.com/reference/carbon-black-cloud/guides/api-migration/integrationservices-policy-v3-migration/


Run tests with xpress support

Since we support Xpress solver it would be nice to run tests with XPress as a solver to ensure it works properly

Can't be done much since licence limit the size of problems to solve


[native_pdf_view] Build step for pdfium failed

Hey, great package, thank you for your work!
Describe the bug
I have some troubles when building for Windows.
I get following error after calling flutter run -d windows:
CMake Error at flutter/ephemeral/.plugin_symlinks/native_pdf_renderer/windows/DownloadProject.cmake:179 (message):
  Build step for pdfium failed: 1

To Reproduce
Steps to reproduce the behavior:

create new flutter project
install native_pdf_view
flutter run -d windows
See error

Expected behavior
A Successful build
Screenshots
Smartphone (please complete the following information):

Desktop Windows-x64

Additional context

I'm developing on a Windows machine with Windows 10 SDK version 10.0.18362.0
Flutter (Channel beta, 2.8.0-3.1.pre,)
I ran the cmd as admin.

+1

same here

@CaroloFa CaroloFa @Salam-pc  work around: https://github.com/rbcprolabs/packages.flutter/pull/233#issuecomment-970246427

@CaroloFa @Salam-pc work around: #233 (comment)

Ty for letting us now, it builds successfully with that workaround. Sadly the swipe and zoom does not work, but that is probably another issue

https://github.com/rbcprolabs/packages.flutter/pull/233#issuecomment-970246427 does not work in my case
any other way?

Fixed in [pdfx] package


Hook function failed on SVG fill and stroke attributes.

These doesn't seem to work:
Velocity.hook(someDOMNode, "fill", "#FFF");
Velocity.hook(someDOMNode, "stroke", "#FFF");
// These values doesn't work either: "#FFFFFF", "white", "rgba(255, 255, 255, 1)", "transparent"
Using Velocity.js v1.2.3 (without jQuery) with React.js and Webpack.

http://julian.com/research/velocity/#arguments
Velocity(someDOMNode, {"fill": "#FFF"});

@Rycochet  Ooops... I forgot to type .hook in the examples (I have corrected them).

Ah, that makes more sense ;-)
I don't know for sure, but looks like those two are registered hook types - so you should be getting and setting "strokeRed", "strokeGreen", "strokeBlue", and "strokeAlpha" instead - at least while accessing through .hook, anyone else have more experience of this?

The hook function is now deprecated, see the "style" command documentation.


vault source

https://github.com/hashicorp/vault

Hi @supernovae ,
Will be implemented soon :)
Meanwhile, you can try fresh new source called "shell", it allows you to execute your own command. It's not officially released (yet), but you can get fresh trusted build from here: https://circleci.com/gh/zeroturnaround/configo/94#artifacts
So, if you have Vault's CLI available, then you can do:
export CONFIGO_SOURCE_0='{"type": "shell", "format":"json", "command":"vault read -format=json secret/password"'

@supernovae could you please try this build? https://circleci.com/gh/zeroturnaround/configo/95#artifacts
It has experimental Vault support :)
You can also build from sources:
https://github.com/zeroturnaround/configo/tree/27-vault

I'll give it a whirl! Thanks!

@supernovae ping :)

@supernovae Vault source was merged. It will be included in the next release which will happen really soon (most probably today or tomorrow)

@supernovae https://github.com/zeroturnaround/configo/releases/tag/v0.2.0


Working mods

Pillow - here's the list of working mods. Let me know if you need anything else.
android working.csv

thx


Improvements

Hello,
Thank you for this amazing application!
I have some recommendations to improve the app:

Replace static secret for something else
Change port the webserver runs on
If possible, try to avoid additional installation of software to configure the DB.

Overall, Very impressive!
Good luck!

Hi there!
Thank you for letting me know the issues. These have been solved in https://github.com/fstelte/Business-Impact-Assessment/commit/beec1b67590dbce2a9f320bdd745760e37a84387
Let me know if this is satisfactory for you!


Decorate a Class

Description
This pull request adds new classes with also new decorators.
Task: https://github.com/microverseinc/curriculum-ruby/blob/main/oop/school_library_decorator_v2.md
This PR makes the following changes:

Create a nameable class
Create Decorator classes
Test the name decorators

Type of change

[X] New feature (non-breaking change which adds functionality)
[X] Test (change related to testing)

Checklist

[X] My code follows the style guidelines of this project (no linters errors)
[X] I have checked my code and corrected any misspellings
[X] I have commented on my code
[X] I have deleted any unused code as comments in my codebase

@codepantha Thank you very much for reviewing my code!


feat(http-log): add a feature

Summary

Checklist

[ ] The Pull Request has tests
[ ] A changelog file has been added to CHANGELOG/unreleased/kong or adding skip-changelog label on PR if unnecessary. README.md (Please ping @vm-001 if you need help)
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

[Implement ...]

message:
type:
scope:
prs:
issues:

Changelog
message: add a feature Introduce a new fields a and b
type:
scope: Plugin
prs:
issues:

Issue reference

FTI-1000 KAG-100

/update-changelog


User Authentication / Identity providers

We need to have out of the box ability to integrate with at least one external IAM system (currently considering Zitadel or Keycloak).
Scope of this task includes user authentication (login) to UI and APIs but excludes per-object ACLs and data row security (see #100  for information on authorization features).

Is there any chance to see this feature in Q2?

Is there any chance to see this feature in Q2?

We are pretty close, but release will probably happen in the beginning of the Q3


Same scope for different actions

I have different actions rendering the collection in a different ways, and sort scope with the default option setting column name and the direction. However this column does not exist in the table rendered by one of three actions. Initially I was going to do something like this:
  has_scope :sort, default: "duration.desc", except: :photo
  has_scope :sort, default: "photo_request.asc",  only: :photo

It didn't work, as has_scope call completely overwrites scope definition. I thought there was a way to change the name of the outer scope (key in params) while saving name called on model class, something like reversed as option. But there wasn't.
Right now I'm going to declare an alias for sort scope on model and use different key. Or the same key with except/only. Any better way to solve it?

That's because we need to keep track of the scopes configuration, and that's keyed by the scope name you use, so I don't think there's a better way around this right now.

I may be wrong, but I don't see any calls to scopes_configuration by key (except the moment when it's filled up), so it may be an array, which will work fine, cause scopes are applied sequentially anyway. In this case except and only will work for my initial attempt.

It's what we use to call the model scopes when you call apply_scopes. There might be other ways of implementing that, though, I'm not entirely sure it needs to be a hash, but it's what has been working so far. If you want to go ahead and try to propose something else, as long as it is mostly backwards compat (everything should work, except of course scopes_configuration wouldn't be a hash anymore), we'd be glad to review and discuss. Thanks!


add distributed incident creation rate limiting

if a plan breaches the quota set by incident_quota_max
it will no longer be able to create incidents. After
quota_breach_duration amount of seconds from the first incident
the plan's quota will reset.

repaced with NGINX rate rimiting


Update openfaas-cloud to 0.14.2

Signed-off-by: Brandon Wilson<EMAIL_ADDRESS>Description
Update stack.yml to align with that of OpenFaaS Cloud v0.14.2.
Related to https://github.com/openfaas-incubator/ofc-bootstrap/issues/98
How Has This Been Tested?

Followed the ofc-bootstrap user guide using this changeset to successfully deploy OpenFaaS Cloud to k3s on bare metal. I set the following init.yml fields to true:

tls
enable_dockerfile_lang
scale_to_zero
network_policies

I was able to successfully install the github app on a repo and deploy functions via git push.
Checklist:
I have:

[x] checked my changes follow the style of the existing code / OpenFaaS repos
[ ] updated the documentation and/or roadmap in README.md
[x] read the CONTRIBUTION guide
[x] signed-off my commits with git commit -s
[ ] added unit tests

Thank you for the pr


updating wrapper.StringValue with proto.Merge; nil pointer vs zero-value

Hello all,
Given this message:
message A {
	google.protobuf.StringValue S = 1;
}

this code:
initialMessage := &pb.A{S: &wrappers.StringValue{Value: "Some string"}}

updateWith := &pb.A{S: &wrappers.StringValue{Value: ""}}

proto.Merge(initialMessage, updateWith)

fmt.Printf("the new value is %q\n", initialMessage)

will output "Some string".
Is there any way at all to make it output ""? In other words, is there any way to update the S wrapper field it with its corresponding zero value if this has to be merged into an existing struct? I thought that was the whole point of the wrapper types.
For context, I'm pulling a record off storage, updating only some fields, and storing it back. The storage that I'm using only supports PUT operations so I can't just send some values, I have to send the whole message, hence the need to merge.
Regards

I'm afraid Merge doesn't do what you want (as you've observed). It's one of the places where the proto3 value wrappers are an imperfect replacement for proto2 optional fields.
Java's FieldMaskUtil provides a helper function which can merge a specified set of fields, which partially addresses this use case (although you then have to manage the list of fields to merge yourself somehow). We don't currently have an officially-supported Go equivalent (#398 tracks the desire for one), unfortunately, but building one using protoreflect would be fairly straightforward.

@neild That's what I suspected, then! I'm guessing there are no unofficial equivalents either?
Either way, I'm not particularly proud of this piece of code, but just in case anyone stumbles upon this, you can always do something like this:
package merge

import (
	"bytes"
	"encoding/json"

	"github.com/golang/protobuf/jsonpb"
	"github.com/golang/protobuf/proto"
	"github.com/imdario/mergo"
)

// Merge is the slowest, unsafest way to merge two proto messages preserving
// wrapper types' zero values.
func Merge(dst, src proto.Message) {
	marshaler := jsonpb.Marshaler{}

	sourceBuf := &bytes.Buffer{}
	err := marshaler.Marshal(sourceBuf, src)
	if err != nil {
		panic(err)
	}

	destinationBuf := &bytes.Buffer{}
	err = marshaler.Marshal(destinationBuf, dst)
	if err != nil {
		panic(err)
	}

	sourceMap := make(map[string]interface{})
	destinationMap := make(map[string]interface{})

	err = json.NewDecoder(sourceBuf).Decode(&sourceMap)
	if err != nil {
		panic(err)
	}
	err = json.NewDecoder(destinationBuf).Decode(&destinationMap)
	if err != nil {
		panic(err)
	}

	if err := mergo.Merge(&destinationMap, sourceMap, mergo.WithOverride); err != nil {
		panic(err)
	}

	finalDestinationBuffer := &bytes.Buffer{}
	err = json.NewEncoder(finalDestinationBuffer).Encode(destinationMap)
	if err != nil {
		panic(err)
	}

	dst.Reset()
	err = jsonpb.Unmarshal(finalDestinationBuffer, dst)
	if err != nil {
		panic(err)
	}
}

func deleteNils(in map[string]interface{}) {
	for k, v := range in {
		if m, ok := v.(map[string]interface{}); ok {
			deleteNils(m)
		}
		if v == nil {
			delete(in, k)
		}
	}
}

As it says in the comment, it truly is absolutely horrible and I'll probably never get hired again if anyone ever sees this but it definitely works!

Closing this as working as intended since the proto.Merge is following the expected behavior according to the protobuf data model.
@neild's suggestion of using FieldMasks to select what to merge (or not to merge) can be considered when we address #398.


Strange graphic difference

Laravel Version: 5.5.42
PHP Version: 7.2.9-1
Laravel-admin: 1.5

Hello everybody,
We developed a website using laravel-admin. This is a corner of our grid interface on our test server

and this is the same part of the interface on our customer's server after I installed laravel, laravel-admin and loaded the same database

As you can see the icons are very different and some buttons are moved around.
The same happens when I enter one item for editing. In the lower corner I see the "save" button

this is the same on the customer's server

Could it be due to some missing permission? What could I do in order to check?
Thank you
Marco

The latest version of laravel-admin is installed on your customer's server. In the new version, some changes have been made to the grid.
You should also update the language file by running php artisan vendor:publish --tag=laravel-admin-lang

Thank you so much!

@z-song Add plz this solution to README.md


Add zstd uploads

Description of proposed changes
Adds parallel uploads of zstd compressed files to S3 to slowly transition to this new format.
Related issue(s)
Resolves #341
Testing
~Doing a test run for GISAID on AWS Batch (job id: fe39ec01-6b29-4939-b01d-cddd06316b8f).~
Terminated the test because it was run without zstd in the nextstrain:ncov-ingest image.
Files will get uploaded to s3://nextstrain-ncov-private/branch/add-zstd-uploads/*
(Shellcheck is currently failing due to snapcraft being down)

Whoops, totally missed that zstd is not in the latest nextstrain:ncov-ingest image.
Thanks for letting me know @j23414 🙏
I manually triggered the update image workflow...which has failed. Will investigate.

Converted to a draft PR for now as we figure out what to do with USER in the Dockerfile...
However, I did start a test run on AWS Batch using nextstrain/ncov-ingest:branch-user-in-image (job id: 1213cf20-69ce-4bea-839e-a088af1e8816). Files will get uploaded to s3://nextstrain-ncov-private/branch/add-zstd-uploads/*

The docker-base PR got merged so I'm re-running the Update image workflow.

I have confirmed that the test run completed successfully and that every file at s3://nextstrain-ncov-private/branch/add-zstd-uploads/ has a .zst version.

Amazing @joverlee521 I'm just testing but then let's merge - time to make progress reality!


Close #173 - Add o1-mini Chat models

Close #173 - Add o1-mini Chat models

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.35%. Comparing base (0be346a) to head (cdd7281).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   84.18%   84.35%   +0.16%
==========================================
  Files          18       18
  Lines         373      377       +4
  Branches        5        5
==========================================
+ Hits          314      318       +4
  Misses         59       59

Files with missing lines
Coverage Δ

...d/src/main/scala-2/openai4s/types/chat/Model.scala
96.92% <100.00%> (+0.20%)
:arrow_up:


*: Use inline links for remaining internal references

Since #687, the official style is to only use reference-style links for external links.  I expect the remaining three entries just slipped through.  This commit adjusts everything found with:
$ git grep ']: [a-z]' | grep -v http

It also fixes the underscore → hyphen in the glossary.md#container-namespace target and updates the capabilities location to catch up with #329.

LGTM
Thanks for clarifying @wking. :+1:

LGTM