attempt to fix UART0 mikroBUS pin swap

Attempt to fix https://github.com/jadonk/beagleconnect/issues/67
Using the emulated I2C slave we control the MB1_CTRL for UART
SPDT Analog Switch.Two endpoints are added to set the UART switch
state and also to get the current state through the I2C slave
Corresponding Zephyr PR : https://github.com/jadonk/zephyr/pull/14

For https://github.com/jadonk/msp430F55xx_usb_uart_bridge/pull/7/files#R391 when the USB cable is disconnected, this is a mux change that is asynchronous and doesn't set the state variable.

Will this provide previous functionality if we do not update the CC1352 firmware? What is the objective of the LOCK_MSP430 mode and is there any way the CC1352 can lock out the MSP430 in the case it wants to continue talking to a mikroBUS device? Can you make it clear why the CC1352 should have input (so that it can coordinate swapping its TX/RX pins) and not just check the status?

Yes, if CC1352 firmware is not updated, then MSP430 will only trigger a I2C read request by toggling the boot line, so if CC1352 FW is not updated then no action will be taken

LOCK_MSP430 -> this is a state to indicate the condition where USB is active, so the UART mux state will be locked to enable the USB-UART commnication

when LOCK_MSP430 is active then even if CC1352 requests to change the UART mux state to communicate to mikroBUS device, this request won't be handled i.e whenever USB is active , USB-UART state is selected.

CC1352 initiating the UART mux transition enables us to have this control in the application, e.g greybus application can request for the UART switch in the application itself.. MSP430 taking the decision and triggering the swap according to USB state is also a feasible approach(only difference I can think of is that in this case if CC1352 misses to service the interrupt, then it can end up in a TX-TX connected state and during the transition also this can happen, but in the current implementation this will not happen.

OK, now that I've read it at https://github.com/vaishnav98/msp430F55xx_usb_uart_bridge/blob/mbuart-pinswap/main.c, it makes sense to me. The way it read here made it look like the case statement was part of the while(1) in main and not part of the I2C ISR. I'll merge and we can do any clean-up post-merge.


[Subtask] Reference implementation of file catalog to support local files

Describe the subtask
This issue tracks the work of implementing a local file based file catalog as the reference design and implementation.
Parent issue
#1241

This is duplicated, I'm going to close this.


Support visualizing mesh collisions with convex decomposition

🎉 New feature
Depends on:

https://github.com/gazebosim/sdformat/pull/1380
https://github.com/gazebosim/gz-common/pull/583
https://github.com/gazebosim/gz-physics/pull/603

Summary
Extends VisualizationCapabilities gui plugin to support visualizing mesh collisions with convex decomposition.
if a mesh collision has the new attribute <mesh simplification="convex_decomposition">, the plugin will decompose the meshes on the GUI side before visualizing them.
Test it
I uploaded a Cordless Drill Simplified model on fuel for testing. This model uses convex decomposition on the collision mesh.
Here's the result:

Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

will retarget to main


Add support for 'notBlank' for all types

Work for this issue will begin begin on branch work-liquid-labs/string-input/31.


Traffic Sign Detection Problem

ISSUE TEMPLATE ver. 0.4.0

Which TurtleBot3 platform do you use?

[ ] Burger
[ ] Waffle
[x ] Waffle Pi

Which ROS is working with TurtleBot3?

[ ] ROS 1 Kinetic Kame
[ ] ROS 1 Melodic Morenia
[ x] ROS 1 Noetic Ninjemys
[ ] ROS 2 Dashing Diademata
[ ] ROS 2 Eloquent Elusor
[ ] ROS 2 Foxy Fitzroy
[ ] etc (Please specify your ROS Version here)

Which SBC(Single Board Computer) is working on TurtleBot3?

[ ] Intel Joule 570x
[ x] Raspberry Pi 3B+
[ ] Raspberry Pi 4
[ ] etc (Please specify your SBC here)

Which OS you installed on SBC?

[ x] Raspbian distributed by ROBOTIS
[ ] Ubuntu MATE (16.04/18.04/20.04)
[ ] Ubuntu preinstalled server (18.04/20.04)
[ ] etc (Please specify your OS here)

Which OS you installed on Remote PC?

[ ] Ubuntu 16.04 LTS (Xenial Xerus)
[ ] Ubuntu 18.04 LTS (Bionic Beaver)
[ x] Ubuntu 20.04 LTS (Focal Fossa)
[ ] Windows 10
[ ] MAC OS X (Specify version)
[ ] etc (Please specify your OS here)

Specify the software and firmware version(Can be found from Bringup messages)

Software version: [x.x.x]
Firmware version: [x.x.x]

Specify the commands or instructions to reproduce the issue.

roslaunch turtlebot3_autorace_detect detect_sign.launch mission:=construction

Copy and Paste the error messages on terminal.

Screenshot from 2022-06-02 18-02-07

Please describe the issue in detail.

hi, I'm following the steps of Autonomous Driving (https://emanual.robotis.com/docs/en/platform/turtlebot3/autonomous_driving/#autonomous-driving) and i've a problem with Traffic Sign Detection, when i launch this command :
roslaunch turtlebot3_autorace_detect detect_sign.launch mission:=SELECT_MISSION (construction for example)
i got this error :

and i got it with all missions.
i've all the sign picture

I found the solution, the problem was with the installation of cv2.
So I reinstalled cv2 using
pip3 install opencv-contrib-python
pip3 install opencv-python
you can see the explanation i got :
https://answers.ros.org/question/401862/turtlebot3-traffic-sign-detection-problem/


READDIR on files with more than 1000 objects

not sure if you still maintain this, I had to make a fix for "folders" with more than 1000 objects. so here it is

Seems unmaintained 🤣


i cant change tabs info

Checklist

[x] I have read the tutorials and know the correct effect of the functional design.
[ ] There are no similar question on existing issues (including closed ones).
[ ] I searched the Internet for related problems, but still couldn't solve it.
[ ] My question is based on the latest code of master branch.

Description

when i changed about.md or tags.md  and saved it,there will be no more 'about' tags show on my page.

can u help u sir?

can u help me sir?

i know why lol.encode error


Text file

Hi, really thanks for your effort to make a dataset. But where can I find corresponding text file

When dataset is ready to be published (i'm still recording currently) it will be in LJSpeech format. Basically it has a metadata.csv (text and string length) file besides the wav files.

Download links are currently unavailable since new model training (tacotron v1 and v2) is in progress. I'll publish new download urls when the new models are available.


Unable to deploy in Azure - unclear procedure.

Hi Team,
I was able to get dab to work on my local host and expose APIs for my database. Now I want to deploy it on Azure and the deployment procedure to deploy it as an app service or a container is extremely poorly written and lacks details of major steps.
I tried downloading the source from this repo and build locally using visual studio to to deploy as an app service using Visual studio but the build was not successful(I kept seeing errors for missing .net core packages version 6.0.19)
I tried following the procedure to deploy dab as a container in Azure. The process is extremely unclear. I talks about creating a container which I succesfully did withing nothing further. It also specifies an Azure-deploy.sh file with absolutely no guidance on how/where toe execute it.
All if the YouTube videos just stop at a demonstration of Dab running locally, can someone please help properly list down full set of steps to actually run it in Azure.

hi @noumanqaiser,
apologies for your troubles. Does this documentation help: https://learn.microsoft.com/en-us/azure/data-api-builder/running-in-azure ?

Hi Anirudh, Thanks for your reply.
I tried all the steps in this document, I was able to create a storage account and upload the config file, I was also able to create a container using the dab image. That's where it's extremely unclear on what to do.
"Create the Azure Container Instance using the image from the Microsoft Container Registry, and mount the storage account file share, so that it can be accessed by Data API builder"
After creating the container using Azure portal, what set of steps must be followed to run it?
I see that in the subsequent line in the documentation it starts to talk about deploying using sh file again without explaining at all where and how to run it(FYI, cloud shell kr Azure CLI throws errors when running that script due to unknown commands)
Any help would be greatly appreciated.

Thanks again for reporting the issue and apologies for the vagueness in the docs. I'll capture the follow-up steps here, let us know if those help you, and we will ensure the official docs are updated as well.

Note the FileShare Name from your Container Apps Environment:

A -> just a name to identify the storage account connection in Container Apps Environment
B -> File Share name that you created in Azure Storage Account.
B and C should Match

Edit the Container to specify the volume mount.
If you click on Edit and Deploy option on the container, you will see an option to add the volume mount.

In the volume mount, specify the FileShare name to be the one that you created in the storage account and noted in step 0.

Once this is done you will see it updated in your container information.

What should the Mount path value be while editing the container?
Mount path: :

How did you come up with /mnt/dabconfigs in your example? Does it have any relation to the file share name inside the storage account?
That is why I put configs in the First box. And Mount path can be anything. I have put /mnt/dabconfigs/ for convenience. Better to put it inside /mnt/<anyname>

What if the dab-config.json file is not present at the root in the file share of the storage account? How do you specify a different config file name through the portal?
Doesn’t matter. Lets say dab.config is present in dabconfigs/sqlconfigs/dab-config.json. Then once you mount it /mnt/configs.
you will have all the directory and files mounted on this path /mnt/configs. And then config file can be accessed by /mnt/configs/sqlconfigs/dab-config.json

How do we tell the container about my config file?
Once the directory is mounted. We have to give the commands for the container specifying the path of the config file.
Example: let’s say the config file in your container is here /mnt/dabconfigs/dab-config.json. then you need to give this command to the container. This command is the first command that runs when the container starts. This command can be edited by clicking Edit and deploy.

I just tested out this newly published tutorial. This should resolve your issues in this comment: https://learn.microsoft.com/azure/data-api-builder/how-to-deploy-container-app
Please feel free to re-open the issue if the guide doesn't solve your issue.


Add MIG flavor

Hi! Please assign a reviewer to get your contribution accepted and merged. Choose someone who knows the content.


Scrobble to last.fm

This is my default music player now on macOS and Linux. The only thing that I am missing now is that I can scrobble my tracks to last.fm. I know this is possible with cmus with a standalone scrobbler or via status display programs. So really hopeful that Musikcube will get this in the future.

This has been requested a few times, I'll see about getting it into the next release!

Preliminary last.fm scrobbling support has been merged to master. It will be part of the next release.

Ohh thanks!

Sounds really great! Thanks for supporting this.

0.50.0 was just released with Last.FM support.


NullPointerException org.pac4j.play.PlayWebContext.getRequestParameters

Hi,
I'm having this issue after updating from 4.0.0 to 4.1.0. In PlayWebContext.getRequestParameters you use
request.hasBody() condition which returns true but my body is null. So thats why request.body().asFormUrlEncoded() throws NullPointerException
Stacktrace:
Caused by: java.lang.NullPointerException
at org.pac4j.play.PlayWebContext.getRequestParameters(PlayWebContext.java:160)
at org.pac4j.play.PlayWebContext.getRequestParameter(PlayWebContext.java:146)
at org.pac4j.core.client.finder.DefaultClientFinder.find(DefaultClientFinder.java:28)
at org.pac4j.core.engine.DefaultSecurityLogic.perform(DefaultSecurityLogic.java:96)
EDIT: The problem appears only when I'm using SecurityFilter. Protecting urls by @Secure annotation works fine

OK. I will fix that onthe  3.1.1 and 4.1.1 versions as soon as possible...

In fact, the problem does not happen on the 3.1.0. Only for 4.1.0.
It should be fixed in 4.1.1-SNAPSHOT: @schmielinski can you confirm it's ok? Thanks

Yes, now it's ok. Thanks for quick fix

Thanks for your feedback. I'm releasing the version 4.1.1...


[JENKINS-23477] expand vars in sparse checkout field

JENKINS-23477 git plugin sparse checkout path field does not expand environment variables
Made a bug fix to expand all the sparse checkout paths using the environment variable just before the git command line execution

[x] I have read the CONTRIBUTING doc
[x] I have referenced the Jira issue related to my changes in one or more commit messages
[x] I have added tests that verify my changes
[x] Unit tests pass locally with my changes
[x] I have added documentation as necessary
[x] No Javadoc warnings were introduced with my changes
[x] No spotbugs warnings were introduced with my changes
[x] I have interactively tested my changes

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Hello @MarkEWaite , is it possible to include this change in the next release ? We are waiting for this since 5 years :)
Thanks ! Bye

Hello @MarkEWaite - voting/promoting to please get this released.

Hello @MarkEWaite - voting/promoting to please get this released.

You can use it now, without waiting for a release and then when you have confirmed it is working for you, you can post the results of your use here.  Download the hpi file from https://ci.jenkins.io/job/Plugins/job/git-client-plugin/job/PR-508/lastSuccessfulBuild/ and upload it to your Jenkins controller.
Download the most recent build from


Wireguard peers disappear and interface turns off after restart

I have Worm-Hole running on a fresh Debian VM with nothing else but it's dependencies. The settings I picked during setup were all the defaults. It works great, however each time either the wg_dashboard container is restarted or the entire VM is rebooted, the peer settings are wiped from wg0.conf. The interface settings themselves remain intact in the config file even after changing them and rebooting.
As well as that, after a restart the wg0 interface doesn't start until it's toggled on manually via the dashboard or command line.
Any clues how to fix this?

Comment out this line in WG-Dash/entrypoint.sh if you want the config to stay after restart (rm /etc/wireguard/*.conf). I added it for dev purposes. I'm going to switch to different dashboard soon once integrate 2fa by Authnik.

I knew I missed something. Thanks!

@Kitmitsu ive updated the image to auto start and added functionality for multiple auto starting interfaces


Mark spec as pending for the interpreter

I am sure this is obvious but why add a new method?
With windows support and now the interpreter it seems like tagging it blocks or pending blocks would allow flexibility with multiple work streams and be more clear to the readers.
something like:
it "works", only: :windows do
end

it "will work", skip: :interpreter do
end

I think the main issue is that it is a general construct for tests and it doesn't allow arbitrary named arguments. So we'd have to make it support only and skip specifically for the compiler.
I think eventually we'll get rid of pending_win32, and hopefully the same for pending_interpreter, so maybe the effort of doing something like only or skip isn't worth the gain right now.

Tags probably exist for that purpose. But also sometimes those pending specs simply do not compile on the disabled platforms yet by the time they are written; since #it is a method, not a macro, it cannot conditionally yield based on the tag contents.

I'm thinking it's better to increase the wait time in interpreted mode.


NaN in Input Vectors for MixedVariableGA

Dear Pymoo contributors,
I am using MixedVariableGA and sometimes have the following error:
pymoo/operators/mutation/pm.py:45: RuntimeWarning: invalid value encountered in power
  d = np.power(val, mut_pow) - 1.0

which results in having some input variables as NaN.
Have you already observed this before?
Thank you for your help.

The problem seemed to be on my side! I had a problem of initial population "normalization" in input space. Sorry for bugging you...


href ignores query params

I would expect the following:
<Link href='/path?key=value'>Text</Link>

to render:
Text

but instead, we get:
Text

Clicking on the rendered anchor only directs the browser to /path.

Yeah, that's a reasonable expectation! For now, you can do this:
<Link href={{
  pathname: '/path',
  query: { key: value }
}}>
  Text
</Link>

I'll leave this open since either should be expected to work 👍

Hmm, the workaround appears to behave the same here.

Bummer! I'll look into this tomorrow.

Looks like two separate issues from what I can see. For paths as strings, normalizeHref ignores anything but basename and pathname. For paths as location objects, history.createLocation seems to stripping the query all together. Might be an issue with the useQueries enhancer?
I'm happy to look into this one 😃

That'd be awesome, thanks!
We eventually should upgrade to history v4, I've always run into trouble with the basename and query enhancers. It'd simplify a lot of the link code 😀

@tptee PR up at #100 😄 I can look into what it would take to upgrade to history v4.

That'd be sick! Biggest issue I know of is that the memory history doesn't support basenames anymore in v4...


[WIP] Change folders structure.

For quick code change/test cycles I want to be able to just go run cmd/thanos/main.go --flags and for this we need to keep a single file in that dir.
What do you think about moving some files around to allow this?
obviously the PR is just as a proposal and I will tidy up the whole thing and fix many lint errors if you think this change is a good idea.

We could do that but if you want quick code fun/test changes that's not good enough argument to do this change. (:
Just copy this and paste or use from Linux history:
go run ./cmd/thanos/!(*_test).go
Also after one day you will text enough and outscale single component so starting few by hand will be painful anyway (: you will fallback to script or kubernetes.

ok I will give it a try and will let you know.

Closing then for now (:


[#4725] Ensure correct cause of handshake error is included in the SS…

…LHandshakeException when using OpenSslEngine.
Motivation:
We need to ensure we add the correct handshake error to the SSLHandshakeException before throwing it when failing the
handshake.
Modifications:
Use the correct error string when creating the SSLHandshakeException.
Result:
Correct SSLHandshakeException message included.

@Scottmitch @trustin PTAL

lgtm!

Cherry-picked into 4.0 (ef2cf4625d78d35a956ec8f18d80fb3c2e63cbd7) and 4.1 (38f27b06e7ccc6fac395d0ed85c763b7a14d6471)

@normanmaurer - delete branch?

done


If an error happens during consumption metrics collection, continue.

Previously, any error on any tenant would cause the whole task to exit. That's not nice, because then no more metrics will be collected for any tenant. In fact, I think we will shut down the whole pageserver if the task returns with error.
TODO: With this, if we get stuck on one tenant, we still stop the collection cycle and don't process the other tenants. That's not great.
@lubennikovaav I noticed this while working on PR #3228, and extracted this from that PR. I'm marking this as draft because of the above TODO, and because we probably should add tests for this. Do you have the time to pick up and finish this?

this fix is already merged
follow-up task for TODO is https://github.com/neondatabase/neon/issues/3490


Tweet hyperlink redirecting to wrong link

When I clicked on tweet link from the homepage - https://getstarted.sh/bulletproof-next
It redirected me to - https://github.com/arunoda/github-cms-demo-data/issues

@arunoda


Describe Setup of SDK

Parent #203

Installation of SDK
Verify installation by starting a white-label blockchain application

Solved as part of #205


Add Option to Disable pydevd Warning

Issue Type: Feature Request
pydevd keeps warning that execution of a function was slow in a toaster dialog of VSC.
These messages keep appearing with no clear way to disable them.
VS Code version: Code 1.69.1 (b06ae3b2d2dbfe28bca3134cc6be65935cdfea6a, 2022-07-12T08:21:24.514Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.69.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Example:

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.69.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

The issue remains.

/extPython

It looks like this is caused by the Python extension. Please file the issue to the Python extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!

Actually may be another extension instead of python but doesn't seem like a core VS Code issue


Logic to initialize AFS in SAM

Copied from WSM. AFS needs to register itself with SAM one time per env.

Interesting, TIL


Music affected by environment

The environment the player is located in affects the acoustics of CD player music played.
For example, when the playable cd's are played in the bathroom/toilet the music sound gets distorted by heavy reverb.
The reverb preset can be seen in the LUA output log and is perhaps affected by the type or size of the room.
I don't know if it is possible to disable this effect for sound played by ICDP, but we should look into this.

Yes, I noticed this for a long time, but so far I have no idea where to fix it.


Debug adapter process has terminated unexpectedly

From @Yagneshdxt on March 12, 2017 11:26

VSCode Version: Code 1.10.2 (8076a19fdcab7e1fc1707952d652f0bb6c6db331, 2017-03-08T14:02:52.799Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author
Version

php-debug
felixfbecker
1.10.0

php-intellisense
felixfbecker
1.1.3

csharp
ms-vscode
1.7.0

mono-debug
ms-vscode
0.15.3

laravel-blade
onecentlin
1.8.1

Steps to Reproduce:

click on start debugging button on debugging tab. (I am debugging php file wiht felixfbecker.php-debug extension)
Debugger shows error Debug adapter process has terminated unexpectedly
on my developer tool it shows error in workbench.main.js:103

My debugging was working fine before vscode update after vscode update it started showing this error.
Copied from original issue: Microsoft/vscode#22476

@Yagneshdxt Is this happening consistently? Can you share the error you see in the debug console and developer console if any?
cc @felixfbecker

From @felixfbecker on March 12, 2017 18:32
Feel free to move the issue, I need to see some stack trace from eg dev tools

I'm having the same issue but I don't have it in the insider version. I don't get anything useful from dev tools but I could look a little deeper and see what I can find out

OK after a deeper look it seems that it's my theme that's causing the issue @ramya-rao-a  could you switch to the default editor theme and see if that at least temporarily resolves the issue?

Actually ignore me, it probably won't be the same issue I had something else messing with mine

I'm having the same issue on vs code 1.10.2

Hi @ramya-rao-a  please find attached screen shot
If you can help me with steps to get more details about error.
I will happy to help you with more detail error log.

What is your launch.json?
EACCESS 81 indicates you use port 81 but don't run with root permissions to bind on that port.

{
"version": "0.2.0",
"configurations": [
        {
        "name": "Listen for XDebug",
        "type": "php",
        "request": "launch",
        "port": 9000
    },
    {
        "name": "Launch currently open script",
        "type": "php",
        "request": "launch",
        "program": "${file}",
        "cwd": "${fileDirname}",
        "port": 81
    }
]

}

@felixfbecker
My debugger was working fine before I updated VSCode. I never faced any issue.  I have not changed any access or any of the setting but suddenly after update it stopped working.
Please help me further.  I am not able to find any access issue. I ran VSCode with administrator right but I got the same error.
Please find below my port setting.
; Local Variables:
; tab-width: 4
zend_extension = "D:\Yagnesh\php\ext\php_xdebug-2.5.1-7.1-vc14-nts.dll"
xdebug.remote_enable = 1
xdebug.remote_autostart = 1
xdebug.remote_port = 9000
; End:

Well maybe VS Code broke running as admin. But the log in your screenshot clearly shows listen EACCESS <IP_ADDRESS>:80. Which corresponds to your port setting in launch.json - change the port to 9000

I had a different case lately that was not related to port number... Not sure if this is the cause of the problem but this extension doesn't work reliably when there are many concurrent requests being processed. When there are 4-5+ items in call stack and I hit the restart icon (green round arrow) it always crashes with the above message.
I managed to reproduce this consistently with a sample project attached to this comment. In this project index.php file is sending multiple ajax requests at the same time. In file2.php - file7.php there is sleep(30) to keep the process in call stack for a while. Try opening file8.php and create new breakpoint somewhere in the top. Than reload the browser where index.php is opened and once the breakpoint is hit try to restart the debug process (that green arrow or ctrl + shift + f5).

https://drive.google.com/file/d/0B7Ls870jI1CLZWFkazdySHdBTFE/view?usp=sharing

@levani that is a different issue, please don't hijack the thread. XDebug's protocol is serial, so if your script is in a running state (not stopped on a breakpoint or ended) because of a sleep or whatever, we cannot send it the request to terminate, so we have to wait until it returns a stopped response. If you impatiently spam the restart button, then VS Code will just spawn a new debug adapter despite the old one not properly terminated which results in an EADDRINUSE error because the port is still blocked by the other process. This is a different error than EACCESS.

same for me, after update i can not debug with xDebugger
Version : 1.18.1
So : Win 10

Got this problem too like @bakeiro and I used php_xdebug-2.5.5-5.6-vc11

After the recent VSCode update I get the above error each time I attempt to debug. This worked fine before the update. This is my launch.json:
{
	"version": "0.2.0",
	"configurations": [
		{
			"name": "Listen for XDebug",
			"type": "php",
			"request": "launch",
			"port": 9000,
			"pathMappings": {
				"/mnt/[path to my remote working directory]": "${workspaceRoot}/site"
			}
		}
	]
}

@bakeiro same is happening with on my system after update.

Same issue here. Left work yesterday with it working fine and came in today to it being broken. I haven't changed anything.

I started having the same issue a few hours ago.
VSCode 1.18.1
Windows 10

Same issue started for me :  Debug adapter process has terminated unexpectedly
VSCode 1.18.1
Windows 10

Same problem VSCode 1.18.1
Ubuntu linux 17.10
[14660:1121/123011.834411:INFO:CONSOLE(5)] "[uncaught exception]: Error: read ECONNRESET", source: file:///usr/share/code/resources/app/out/vs/workbench/electron-browser/bootstrap/index.js (5)
[14660:1121/123011.834460:INFO:CONSOLE(5)] "Error: read ECONNRESET
    at exports._errnoException (util.js:1050:11)
    at Pipe.onread (net.js:581:26)", source: file:///usr/share/code/resources/app/out/vs/workbench/electron-browser/bootstrap/index.js (5)
[14660:1121/123011.834476:INFO:CONSOLE(163)] "Uncaught Error: read ECONNRESET", source: events.js (163)
[14660:1121/123011.835207:INFO:CONSOLE(9)] "Debug adapter process has terminated unexpectedly", source: file:///usr/share/code/resources/app/out/vs/workbench/workbench.main.js (9)
[14660:1121/123012.921884:INFO:CONSOLE(5)] "[uncaught exception]: Error: read ECONNRESET", source: file:///usr/share/code/resources/app/out/vs/workbench/electron-browser/bootstrap/index.js (5)
[14660:1121/123012.921920:INFO:CONSOLE(5)] "Error: read ECONNRESET
    at exports._errnoException (util.js:1050:11)
    at Pipe.onread (net.js:581:26)", source: file:///usr/share/code/resources/app/out/vs/workbench/electron-browser/bootstrap/index.js (5)
[14660:1121/123012.921937:INFO:CONSOLE(163)] "Uncaught Error: read ECONNRESET", source: events.js (163)
[14660:1121/123012.922326:INFO:CONSOLE(9)] "Debug adapter process has terminated unexpectedly", source: file:///usr/share/code/resources/app/out/vs/workbench/workbench.main.js (9)

https://github.com/felixfbecker/vscode-php-debug/issues/203

I had same problem after updating to VSCode 1.18.1 on Windows 10.
I tried a reboot and restart VSCode. When it opened up it opened the User Settings file. I have a custom block the php 5.4 I use. This had some errors marked. I'm not sure if this was a result of the VSCode update or not. I fixed the errors. Restarted VSCode -> Still not working.
Then I noticed in my list of extensions, the PHP Debug extension had an update button. I don't know what version it was, but it's now 1.12.1 and it's back working again.

Confirm the bug!!!
Ubuntu 16.04 LTS
Version 1.17.2
and insider version (1.19)
I have the same problem after update.
Also DEB packages were not updated properly (installation script hanged up)
This problem is serious.. do something with it already, please

I am also facing the same issue whenever I tries to step into the debugger stops with error :
debug adapter process has terminated unexpectedly
Here is my launch.json
{
"version": "0.2.0",
"configurations": [
    {
        "name": "Listen for XDebug",
        "type": "php",
        "request": "launch",
        "port": 9000
    },
    {
        "name": "Launch currently open script",
        "type": "php",
        "request": "launch",
        "program": "${file}",
        "cwd": "${fileDirname}",
        "port": 9000
    }
]

}

Can confirm the error.
Windows 8
PHP 7.1.8

Below my launch.json file
{
  // Use IntelliSense to learn about possible attributes.
  // Hover to view descriptions of existing attributes.
  // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
  "version": "0.2.0",
  "configurations": [
    {
      "name": "Listen for XDebug",
      "type": "php",
      "request": "launch",
      "port": 9000
    },
    {
      "name": "Launch currently open script",
      "type": "php",
      "request": "launch",
      "program": "${file}",
      "cwd": "${fileDirname}",
      "port": 9000
    }
  ]
}

Any fix for this error?

Had the same issue this morning, worked yesterday night, updated VSCode to 1.22 and got the error above.  Changed php.ini and launch.json to use port 9002, confirmed via netstat that nothing was using either 9000 or 9002, went back to VSCode 1.21, nothing.  Had to disable auto-update and go back to PHP Debug 1.11 and now it works.

Same here. Updated VSCode to 1.22.2 and got the error.


api_key arg for openai.Audio.transcribe doesn't work

Describe the bug
    def create_transcription(self, audio_file : str):
            if not os.path.exists(audio_file):
                return None
            file = open(audio_file, 'rb')
            resp = openai.Audio.transcribe(
                api_key=self._API_KEY,
                file=file,
                model='whisper-1',
                response_format='text',
                language='it'
            )
            return resp

Using the api_key parameter of openai.Audio.transcribe raises a  openai.error.AuthenticationError.
I know for sure that the api key provided in self._API_KEY is correct  because I have already used it in another function.
Looking in the audio.py module, the function:
    def transcribe(
        cls,
        model,
        file,
        api_key=None,
        api_base=None,
        api_type=None,
        api_version=None,
        organization=None,
        **params,
    ):
        requestor, files, data = cls._prepare_request(file, file.name, model, **params)
        url = cls._get_url("transcriptions")
        response, _, api_key = requestor.request("post", url, files=files, params=data)
        return util.convert_to_openai_object(
            response, api_key, api_version, organization
        )

does not use the api_key that I am passing it and that it inserts a default key, which is therefore not good.
To Reproduce
Try to use the function openai.Audio.transcribe() with the api_key parameter filled with a valid key
Code snippets
No response
OS
linux
Python version
Python 3.10.6
Library version
openai-python-0.27.2

Yes, I faced this too.
Coul you try putting OpenAI key in os.environ and try reading
openai.api_key = os.environ.get("OPENAI_API_KEY")

Yes, I faced this too.
Coul you try putting OpenAI key in os.environ and try reading
openai.api_key = os.environ.get("OPENAI_API_KEY")

yes, this method is what i am currently using and it works fine, thanks

Yes, I faced this too.
Coul you try putting OpenAI key in os.environ and try reading
openai.api_key = os.environ.get("OPENAI_API_KEY")

WORKS. THANK YOU!

Fixed in v0.27.3

Fixed in v0.27.3

You're right, i've done an update to the latest version and works! Thanks!


React 16, props used in getDerivedStateFromProps cause no-unused-prop-types

Could be related to https://github.com/yannickcr/eslint-plugin-react/issues/1751
When running this code (React 16, using a prop only in in getDerivedStateFromProps I get a  no-unused-prop-types error.
I would expect React 16 new lifecycle methods to be taken in account when doing the check.
  class FieldSelector extends Component {
    render () { ... }
  }

  FieldSelector.getDerivedStateFromProps = (props, state) => {
    const selectedFields = props.selectedFields;
    const disabledFields = {};
    ...
    return { disabledFields };
  };

  FieldSelector.propTypes = {
    intl: intlShape,
    value: PropTypes.string,
>>  selectedFields: PropTypes.arrayOf(PropTypes.string),
    onFieldSelect: PropTypes.func.isRequired
  };

my eslint config includes
    settings: {
      react: {
        pragma: "React",
        version: "16.3"
      }

my eslint --debug shows it has been running with the latest version
eslint:plugins Loaded plugin react<EMAIL_ADDRESS>(from /home/.../node_modules/eslint-plugin-react/index.js) +129ms

...

  373:19  error  'selectedFields' PropType is defined but prop is never used  react/no-unused-prop-types

I know those are technically a bit different, but we are handling both forms for fields like propTypes - wouldn't it make sense to do here as well?

Sure, i suppose so, altho there’s no reason to ever define it outside the class.

I'm still facing the issue with the following code.
  static propTypes = {
    width: PropTypes.number,
    height: PropTypes.number,
    energies: PropTypes.arrayOf(PropTypes.number).isRequired,
    surface: PropTypes.symbol
  };

  static getDerivedStateFromProps (props, state) {
    if (!props.surface) return { ...state, loading: true }
    const points = Points[Symbol.keyFor(props.surface)]

    // some code exists here, don't mind it

    return {
      ...state,
      points,
      data: props.energies.map((v, i) => ({
        index: i,
      }))
    }
  }

Running eslint --debug shows it uses version 7.11.1
eslint:plugins Loaded plugin react<EMAIL_ADDRESS>(from /Users/nkprince007/Developer/src/gitlab.viperdev.io/pandas/live-analytics/node_modules/eslint-plugin-react/index.js) +0ms

...

  15:15  error  'energies' PropType is defined but prop is never used  react/no-unused-prop-types
  16:14  error  'surface' PropType is defined but prop is never used   react/no-unused-prop-types

✖ 2 problems (2 errors, 0 warnings)

@nkprince007 what version of react is in your eslint settings?

I'm not sure what you meant by that @ljharb.
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>are the versions installed.
Here's my ESLint config, though.
{
  "extends": [
    "standard",
    "standard-react"
  ],
  "parser": "babel-eslint",
  "env": {
    "browser": true
  },
  "rules": {
    "react/destructuring-assignment": false,
    "no-console": [
      "error",
      {
        "allow": [
          "warn",
          "error",
          "info"
        ]
      }
    ],
    "no-return-assign": 0
  }
}

And here's more info.
❯ npm list | grep eslint
├──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ ├──<EMAIL_ADDRESS>deduped
│ ├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ ├─┬<EMAIL_ADDRESS>│ │ └──<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ ├─┬<EMAIL_ADDRESS>│ │ ├──<EMAIL_ADDRESS>deduped
│ │ ├──<EMAIL_ADDRESS>deduped
│ │ │ └──<EMAIL_ADDRESS>deduped
│ ├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>deduped
│ ├─┬<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>deduped
│ │ ├─┬<EMAIL_ADDRESS>

You haven’t specified a React version in your eslint settings. See https://github.com/yannickcr/eslint-plugin-react#configuration

I believe it's already done here.
https://github.com/standard/eslint-config-standard-react/blob/master/eslintrc.json
And I'm using extends.

Gotcha. gDSFP was added in 16.3, so you’ll need to override that setting with the actual React version you’re using.

Thanks @ljharb. That works as expected. 👍

Seems like this can be closed, right?

I'll go ahead and close it; if there's further problems, please file a new issue.


Autocomplete accessibility glitch

There's something odd going on when typing actual code into Vs Code. To reproduce:

Create a file called index.html.
Type  .
Press enter.
Expected behavior:
The cursor goes to the next line.
Perceived behavior:
Nothing actually happens. You have to press Enter again to go to the next line.

Expected cause: I think an autocomplete list pops up that the accessibility stack isn't aware of. Pressing the first enter likely selects the first option in this list.
Problem with this hypothesis: Arrowing up and down should make different things happen if my theory is correct, however it doesn't seem to do that. Therefore I am not a 100% sure I am correct, someone comment on it to check please.
I think fixing this so the prsumed opup is correctly handled should be the next step for accessibility of this product.

@zersiax we are currently investigating into making auto complete accessiblity aware.

@zersiax Indeed, the autocomplete list "steals" Enter, arrow up and arrow down when it pops up. I have pushed a change this morning to make arrow up and down read through the proposals as they are focused and just now another change to alert when a suggestion is accepted (Enter).
We will do some more testing on our side, and then I would love to give you a VSCode version containing these changes and get more feedback from you in this area.
Thank you!

Hi,
Awaiting that test version. Will wait for it before continuing
conducting tests :)

@zersiax I apologize if I'm going too much into HTML aria details.
Two days ago I made a change to make the suggest widget use proper aria semantics. In other words, when the suggest widget would pop up, I would add aria-haspopup="true", aria-autocomplete="list" and I would set aria-activedescendant to the id of the current suggest proposal.
This would give a pleasant experience when the suggest widget would pop up, it would announce the first suggestion and using arrow up and down would announce each suggestion, while focus was still in the editor (i.e. typing was still possible in the editor to narrow down results or to ignore the suggestions completely).
After further testing, I have discovered that when closing the suggest widget (when accepting a suggestion or when dismissing it with Escape), I would correctly on my side remove the aria-activedescendant attribute from the input element. However, navigating with arrow keys would no longer announce each character or each line, it would be completely silent. I believe this is a bug in Chromium, where they do not handle correctly the removal of aria-activedescendant until you focus out of the input and focus back in to it.
This issue is blocking the usage of proper ARIA semantics, as soon as suggestions are shown once, cursor navigation becomes completely silent. I have captured this issue and another 2 related issues in Chromium bug 593646.
In the meantime, I have commented out for now the usage of proper ARIA semantics, and have replaced them with alerts. I am sorry, I know alerts are probably the worst option, but here is the current behaviour:

when the suggestions pop up, they alert with the pre-selected suggestion. This is useful to inform that Enter will now be accepting said suggestion.
when the suggestions are shown, using arrow down/up or page down/up will change the selected suggestion. This will be announced again through an aria alert. Unfortunately, when pressing arrow down/up, NVDA reads for me the entire line again, and only afterwards the next suggestion. I believe NVDA expects that cursor down/up would move the cursor to a different line, thus its desire to read the entire line again. However, in this case cursor down/up keeps the cursor on the current line and selects the previous/next suggestion. Now that I think about it, we could overcome this by changing the keybindings for selecting previous/next suggestion to something else than arrow up/arrow down. I will try this out and get back to you.
when a suggestion has a documentation label we alert that it "has details". The documentation label can be read by using Ctrl+Space again. Ctrl+Space acts as a sort of toggle between suggestion items and an item's details (when they are available).
when a suggestion item has been accepted, we alert that it has been accepted.

I would be very happy if you could try it out, I am sure this still needs a lot more fine-tuning.
Here is a version of VSCode that will be installed in parallel with the stable version and that we can use for continuous feedback - patches.

Hi,
My primary area of development is the web, so don't worry about going
into aria details :)
AAs for the implementation, I will research the bug you have filed,
see if other projects ran into the same thing. If this bug is fixed,
the ARIA implementation would indeed be preferable.
The interesting thing is that for the longest time, the behavior you
are describing regarding NVDA not reading lines or characters was
actually the default. This was the primary reason I deemed the product
completely inaccessible last year. I'm guessing there's no way to
quickly flip the focus back and forth without inconveniencing the
user?
As for remapping the keyboard keys, the problem with that I think is
that there's not all that many keys that would be suitable. Ideally it
would be single keys to make the interaction as smooth as possible,
which means I guess only the arrow keys and tab + shift+tab would
suffice without sacrificing efficiency. Would like to hear your input.
I will test the current implementation now and report back soon.

I have just tested the current implementation and see the limitations.
At least the feature is usable now, which is already a very big plus.
We will have to wait on the Chromium devs to see if the bug you found
can be fixed on their end.
Also, what is the second element in a help tag supposed to denote,
return type? This reports undefined for HTML elements.

To anyone concerned wondering on status, it seems the chromium bug
reported has been picked up by someone who seems to know their stuff.
It was smart to leave the ARIA code in but commented since we'll be
needing it soon I predict. Also, another disadvantage of only using
alerts is the fact these don't get reported on the braille display.
This is fine for general alerts, but for this having that work
properly could actually be a huge productivity booster. My guess is
that the ARIA way of doingthings rather than alert will make this
happen, which is a big plus. I'll report in once I know more.

@zersiax Thank you for trying this out.
Moving focus to another element only to move it back in the same JS callstack has no effect. I could try to move the focus to another element and then move it back with a setTimeout of 0, but that might lead to the case that a keypress is missed (e.g. if a keypress is queued in the event loop). This might lead to missing typed characters.
Nice catch with the "undefined" for HTML suggestions, that was indeed the "typeLabel", which is undefined for HTML suggestions.
I have also added additional keybindings out of the box for navigating the suggestion list: Alt+DownArrow, Alt+UpArrow, Alt+PageDown, Alt+PageUp. These function the same as DownArrow, UpArrow, PageDown and PageUp when the suggest widget is opened, but have the advantage that they don't confused NVDA into reading the current line again.

heads up peeps :) It seems the chromium bug being referenced here is seeing some activity. @alexandrudima you might want to keep an eye out, I think you'll be able to uncomment the proper ARIA semantics soon

@alexandrudima the chrome issue has been fixed and we are using the version of chrome which has the fix.
Let's look into reusing the proper aria labels and where that leads us.

The textarea of the editor must dynamically change aria-haspopup, aria-autocomplete and aria-activedescendant attributes based on the suggestion widget state.
For this we will need to add editor api setAria(options)
Assigning to next milestone so I invest time then to fix this properly.

Gentle bump :-) I would say this is among the most asked questions I get when people use Code with screen readers, what is the status of this one?

I plan to look into this issue this or next week. Will keep you updated here. Thanks

Perfect, thanks :-)

I have created a PR which should solve this issue  #87880

Kamino cloned this issue to ChaseKnowlden/vscode

Adding verified per twitter thread https://twitter.com/zersiax/status/1216749912370663426


cannot delete uploaded file

Gitea version (or commit ref):
gitea-1.7.5-windows-4.0-amd64.exe
Git version:
git version 2.21.0.windows.1
Operating system:
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x ] No
[ ] Not relevant

Log gist:

Description
Please refer to the version of GitHub for release.
Attachments uploaded when the version is released are not viewable when editing and cannot be deleted. Server corresponding files are not deleted when the version is deleted
...
Screenshots

What kind of uploaded file do you want to delete?

files on issue

What kind of uploaded file do you want to delete?

files on Releases。
step 1：New Release ，upload some files，delete one file(this file was not deleted from the uploaded folder), Publish Release.
step 2：edit step 1 Release version，cannot view step 1 uploaded files，so，cannot delete uploaded files.

Looks like work is being done on this on #677?
You may be able to delete release attachment with the API if you have #6314  but i've not tried.

can we close this issue in fafour of #677?
@lunny


Automated build integration for compat testing unit tests on Mac

Once we have foundation unit tests passing on Mac, this task is to integrate it into our nightly and CI builds to catch regressions.

Replaced this with #916


Migrate odds and ends pages

Migrate the pages still on the old website (past events, dagstuhls etc).

Migrated and links fixed on old site


perf(router) use ngx.ssl.server_name() instead of var.ssl_server_name

Summary
Openresty has a more efficient ffi function ngx.ssl.server_name() ,
it has the same result as var.ssl_server_name,
so I think we can use it both in stream and http subsystem.
Full changelog

use ngx.ssl.server_name() to get the value of  var.ssl_server_name

@chronolaw Could you use a similar test script like https://github.com/Kong/kong/pull/7742#issuecomment-902616472 to validate the replacement from var.ssl_server_name to ngx.ssl.server_name() is indeed beneficial, since now we have
the ngx.var optimization in place?

Here is the test code:
# add "lua_kong_load_var_index $ssl_server_name;" in nginx.conf

local last_time = 0

local function timeit()
    ngx.update_time()
    local a = last_time
    last_time = ngx.now()
    return last_time - a
end

local name
local server_name = require("ngx.ssl").server_name

timeit()

local ITER = 5000*1000
for i=1,ITER do
  name = ngx.var.ssl_server_name
end
ngx.say(timeit())

for i=1,ITER do
  name = server_name()
end
ngx.say(timeit())

The results are:
curl --resolve ngx.test:8443:127.1 https://ngx.test:8443 -k

0.22900009155273
0.073999881744385

0.23200011253357
0.061000108718872

And we can get the conclusion that ffi is better than var mechanism.


Custom Api endpoint support

Fixes #9 : Added support to specify custom API endpoint while using module. By default, http://api.susi.ai is used.

Do not merge.

Please rebase and do the needful.

@DravitLochan @chiragw15 Review please.

@mariobehling Please look into it.


Experiment with Gradle build tools to increase developer productivity

As a developer, I run Maven a dozen times a day. The 45 seconds it takes to do mvn clean package slows down my productivity. Gradle advertises it self as 2x - 5x faster than Maven.
AC:
[ ] Compare the build times of Maven and Gradle
[ ] Azure and CLI packaging
[ ] Gradle output is equivalent to Maven output

Experimented using Gradle with the build and it does indeed save time on subsequent builds.  Some findings:

Subsequent compiles of the code take 10s with Gradle vs 30s with Maven.  This time savings seem to be from the fact that Gradle can efficiently determine what has changed and compile only that.
The Gradle build script may come out a bit cleaner than the maven one as it requires less configuration.
Kotlin can be used in the Gradle build script.  You still need to know Gradle, but you can insert custom code in the scripts if needed.

Based on the time savings alone I would recommend moving to Gradle.  This, however, requires some time to find the correct version of the plugins and regenerate their configuration in the proper format.  Some organization is recommended, specially for the script properties.

[ ] Kotlin compile
[ ] Jooq DB source generation
[ ] build.properties value replacement
[ ] Exclude SQL from resource folder
[ ] Update project configuration to include Jooq sources?
[ ] Azure packaging
[ ] Copy proper resources in fat jar
[ ] copy dependency plugin?
[ ] base jar generation? maybe not needed
[ ] fat jar
[ ] ant run??
[ ] run unit tests
[ ] run migration

Cool. I agree that the move it worth it. Suggest you bring it up in today's dev meeting.

Cool. I agree that the move it worth it. Suggest you bring it up in today's dev meeting.

Will do.


Oracle Disputes

Do we want to give some buffer for disputing an oracles price?

I will not want an oracle dispute, just so we can minimize centralization risks. I would prefer a "backup mechanism" to push the price if the current implementation failed to push price for a specific timestamp.

I am more concerned about the oracle pushing the wrong price at expiry.
That risk falls to either the sell or the buy side depending on where the price lands. If there is window to dispute this than one side can take advantage of the discrepancy.

I think it's kind of hard to define what's a "wrong price" from smart contract's perspective. Considering that the on-chain world takes what oracle said as ground truth, I'd actually prefer we completely trust the oracle and state clearly that it will be used to settle all options.
I feel like adding dispute is another attack surface. Using chainlink as example, having a dispute mechanism means we trust our own disputer key more than Chainlink's "decentralized nodes", which I think is not fair

In a perfect world i would agree with you. But these oracles are not that mature. If you recall there have been major errors with other major oracles (pyth). The errors they had would cause someone to lose significant funds.
If you structure the dispute role correctly (example:  multisig [signer to be determined]) then I think that gives participants some assurance that if things go wrong (which they eventually do) there is something that can be done about it.

I personally would consider separating these into different oracles, like a fully permission-less oracle rely 100% on chainlink, and another one with chainlink + disputable by admins.
Reason is, I think once we have a single component that inherit the centralisation risk, even the fully collateralised engine will become "not decentralized", because admin would be so powerful that they can change the payout of the system. Then we go back to the problem of "should we assume the admin to be good", and eventually the whole assumption go back to "trusting the key owners".
The good things about the current design is we can rely on different oracles, so we can do both and let the integrating team decide which one to go with.

I do feel like a "better" oracle could be something that

has a fullback to avoid single point of failure
compared prices across different oracles (chainlink, pyth and uniswap maybe) while reporting
only give small rooms to disputers (e.g. disputer can't change price 1% different than reported)

These would all be something needed before I consider it "decentralized"


Accesses Programfiles/Windows For what reason?

Title says it all i want to know why it accesses programfiles/windows

Some dependencies might try to load modules from several different places, you could say something better, like when or if some specific directory.
It is noteworthy that the project is completely open-source, you can check yourself if you feel suspicious of something.


Text gets streched while using a long text content (in IE only)

I use doc.text(currentDate,x,y) where the current date is the long string and it prints it as a stretched text like this.

For chrome, it does work correctly.

Please look into this issue

Try using .replace(/[^ -~]/g, ''); on the date before printing it. There's extra LTR and RTL mark characters that get returned by IE. E.g. (new Date().toLocaleDateString("en-IN")).charCodeAt(0) and you'll notice 8206 is returned which is the character code for LTR and RTL marks

Thanks for your solution. It worked as expected. Saved a lot of my time @SmythConor


USHIFT-3153: Speed up container image mirroring

All tests run on a metal AWS host.
Performance gain ~3m.
Note: the gain may be over 5m on dev virtual machines

Number of images to sync
$ cat _output/test-images/container-images-list | wc -l
64
$ sort -u _output/test-images/container-images-list | wc -l
42

Times before the fix
$ time ./test/bin/mirror_registry.sh
real    3m35.432s
user    1m43.600s
sys     0m27.821s

Times after the switch to mirror
$ time ./test/bin/mirror_registry.sh
real    2m15.528s
user    0m23.288s
sys     0m10.137s

Times after the copy parallelization
real    0m26.411s
user    0m30.755s
sys     0m13.053s

/assign @pacevedom
/test metal-periodic-test-arm

Putting on hold to give priority to #3310
/hold

/unhold

The test failures are not related to the changes. Saving on CI cycles
/override ci/prow/metal-periodic-test-arm

/unhold
/test all


Support Nickel patterns

The last (yet to be released) version of the Nickel grammar was extended with enum variants and their corresponding patterns, and patterns can now appear on the left-hand side of a match case (instead of just enum tags). This PR updates Topiary to use the latest Nickel grammar and update the Nickel queries to handle enum variants and patterns.
This PR also adds a scope for the body of a match case (the right-hand side of "=>") for consistency reason, to align with how bound expressions (right-hand side of "=") are flowed.

The playground is failing the CI, but I don't know if it's expected these days or not.

Unfortunately, we don't dynamically generate the wasm grammars (yet). This has to be done manually using the update-wasm-grammars script which is part of the devShell. Yes, not ideal.
Anyway, after the update, it CI seems to pass.


Documentation link is wrong

Issue text goes here.

Context
Version

Code for IBM i version
1.9.0

Visual Studio Code version
1.78.2

Operating System
darwin_x64

Active extensions
COBOL (cobol): 9.5.6
Code Coverage for IBM i (code-coverage-ibmi): 0.1.7
Code Spell Checker (code-spell-checker): 2.20.4
Code for IBM i Walkthroughs (vscode-ibmi-walkthroughs): 0.3.1
Db2 for IBM i (vscode-db2i): 0.2.11
Dev Containers (remote-containers): 0.292.0
ESLint (vscode-eslint): 2.4.0
Emmet (emmet): 1.0.0
Error Lens (errorlens): 3.11.0
Extension Authoring (extension-editing): 1.0.0
Git (git): 1.0.0
Git Base (git-base): 1.0.0
Git Graph (git-graph): 1.30.0
GitHub (github): 0.0.1
GitHub Authentication (github-authentication): 0.0.2
GitHub Pull Requests and Issues (vscode-pull-request-github): 0.64.0
GitLab Workflow (gitlab-workflow): 3.63.0
GitLens — Git supercharged (gitlens): 13.6.0
IBM i Notebooks (vscode-ibmi-notebooks): 0.0.5
JSON Language Features (json-language-features): 1.0.0
Live Share (vsliveshare): 1.0.5864
Merge Conflict (merge-conflict): 1.0.0
Microsoft Account (microsoft-authentication): 0.0.1
NPM support for VS Code (npm): 1.0.1
Node Debug Auto-attach (debug-auto-launch): 1.0.0
RPGLE (vscode-rpgle): 0.19.2
Rainbow CSV (rainbow-csv): 3.7.0
TODO Highlight (vscode-todo-highlight): 1.0.5
WSL (remote-wsl): 0.78.8
vscode-icons (vscode-icons): 12.4.0

Hi link to documentations is wrong:
https://halcyon-tech.github.io/vscode-ibmi/#/

Bye

Indeed, that's not the right URL.
This will be fixed when https://github.com/halcyon-tech/vscode-ibmi/pull/1321 gets merged and released 🙂


Remove double negative in package_discovery.rst

Summary of changes
find_packages() only finds the folder which contains __init__.py.

Oh, you‘re right. I miss the dis part. Double negative makes it harder to understand.
I change it to ignore.

Thank you very much.


Setting MERGIN_AUTH hint for Windows users

When users log in to the service they would see the hint how to set up the env variable:
To set the MERGIN_AUTH variable run:
export MERGIN_AUTH="Bearer .eJwljUkK[....]UPrHSAHfiwwJYPoE"

This works nicely on GNU/Linux machines but would fail on Windows.
Would it be possible to also add a version of the hint for Windows users? For example:
On Windows:
SET MERGIN_AUTH=Bearer .eJwljUkK[....]UPrHSAHfiwwJYPoE

Please note there are no quotations.

Fixed in #175


Automatically bump Homebrew formula on release

Description
This PR adds a GitHub Action script to automatically bump the DITA-OT Homebrew formula whenever a new release tag is pushed to the DITA-OT repo.
Motivation and Context
Currently the Homebrew formula is updated manually after each release.
This configures an existing action from the GitHub Actions Marketplace to update the DITA-OT formula: https://github.com/mislav/bump-homebrew-formula-action.
A new COMMITTER_TOKEN secret has been added to the core repo to authenticate the action.
How Has This Been Tested?
I'm afraid there may be no other way to test this than to merge it and verify whether it works when a new tag is created.
Type of Changes

New feature (non-breaking change which adds functionality)

Documentation and Compatibility

What documentation changes are needed for this feature? NONE
Will this change affect backwards compatibility or other users' overrides? NO

Per https://stackoverflow.com/questions/58177786/get-the-current-pushed-tag-in-github-actions, we should add a step
      - name: Set env
        run: echo ::set-env name=RELEASE_VERSION::${GITHUB_REF:10}

and then change the download URL to be
download-url: https://github.com/dita-ot/dita-ot/releases/download/${{ env.RELEASE_VERSION }}/dita-ot-${{ env.RELEASE_VERSION }}.zip

Not 100% sure this works, though.

The only concern here I have is that this GA completes before Travis has completed the deployment. If the Brew CI tests this PR by trying to run it, it will fail because the artifact is not available yet.
We may need to update the GA code so that we run it manually, somehow.

The only concern here I have is that this GA completes before Travis has completed the deployment.

Not sure if there's any way to introduce a delay in the workflow, so when a new tag is pushed, the workflow would run 10 minutes later, or 30, or something. 🤔

🚧 Deferred to after 3.4.1 release

[ ] Investigate options to delay execution until Travis build artifacts are available

Since GitHub has added support for manual triggers, this should be reopened.


Make cluster-autoscaler resource request/limit configurable

What
We've exposed the cluster-autoscaler deployment resources and made them configurable via cluster.yaml using the same approach taken regarding the kube-dashboard
Why
We've started to experience OOM issues & CPU throttling in our bigger environments.

Codecov Report

Merging #1556 into v0.12.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           v0.12.x    #1556   +/-   ##
========================================
  Coverage    38.13%   38.13%
========================================
  Files           75       75
  Lines         4647     4647
========================================
  Hits          1772     1772
  Misses        2630     2630
  Partials       245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f36c14...37dca98. Read the comment docs.

/assign @davidmccormick

Many thanks Luke! 🙏


show_trailing_blankline_indent is not consistent

After reading #55 and #7, I still have an issue with "VSCode-like" indentation on last blank lines.
Issue
VSCode Reference:

With show_trailing_blankline_indent = true (default):

With show_trailing_blankline_indent = false (VSCode-like indentation with one level less):

On the last picture, we can notice a "hole" in the indentation line (yellow).
It is not present in the VSCode indentation (which is probably more natural), nor on the second picture (where show_trailing_blankline_indent = true) as the yellow line is contiguous till }.
I was only able to reproduce this issue on the last empty line at the end of an indent block.
Code snippet used
def main():

    for i in range(5):
        return {

            "hey",
            i

        }

(Don't mind the code, it doesn't make sense, but it shows the abnormal behavior, also detected in many other languages)
JSON example:
{
    "1": [
        "this"

    ]
}

Same issue here, on the line right before ] the indent line is missing.
Config used
-- https://github.com/lukas-reineke/indent-blankline.nvim
{
  "lukas-reineke/indent-blankline.nvim",
  config = function()
    require("indent_blankline").setup({
      char = "│",
      show_end_of_line = true,
      show_trailing_blankline_indent = false,
      char_highlight_list = {
        "IndentBlanklineIndent1",
        "IndentBlanklineIndent2",
        "IndentBlanklineIndent3",
        "IndentBlanklineIndent4",
        "IndentBlanklineIndent5",
        "IndentBlanklineIndent6",
      },
      filetype_exclude = {
        "lspinfo",
        "packer",
        "checkhealth",
        "help",
        "man",
        "",
      },
    })
  end
}

This is a limitation of the current implementation.
But I have already fixed that for version 3.
Please wait a couple of weeks until v3 is ready.

Fixed in version 3 now

Is it just enabled by default now? I couldn't find any mention of show_trailing_blankline_indent in either :h ibl or the migration guide, but I could be missing something

show_trailing_blankline_indent is no longer relevant, it's always off


Dependencies Old! Bug

For the newbie who want to use it, sbt-0.13.11, sbt-assembly-0.14.5 are preferred. Before sbt-0.13.8, sbt is extremely slow. Community has resolved the problem recently by bumping up to 0.13.11.

Sure, make a pull request.

Maybe just a bit less bluntly: right now I don't have a ton of capacity to
improve Epic, especially since the field has basically moved on to a very
different set of techniques. Anyway, I will probably get to this
eventually, but a PR will also be merged more quickly.
On Mon, Sep 25, 2017 at 11:29 AM, Simon Hafner<EMAIL_ADDRESS>wrote:

Sure, make a pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dlwh/epic/issues/68#issuecomment-331812335, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAloXd4VKRrFoYwMlddQzH8RJo1K0paks5sl2RugaJpZM4PiAmu
.


bug fix: multiple edits do not update UI

Fixes #100

Wow, great work! :smile:

Pull Request Test Coverage Report for Build 125

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 79.26%

Totals

Change from base Build 123:
0.008%

Covered Lines:
1949

Relevant Lines:
2459

💛  - Coveralls


Update myvectors.py

No problem!
Using the function mag as an example, my main focus was readability, since adding additional assignment statements won't noticeably impact the performance of mag. However, while writing up my response, I realized there was an even more comprehensible and Pythonic way of doing it.


Application does not start torrenting anymore

Apparently in commit 093d810, WebTorrent.add() is called using the torrent's infoHash while the API need the magnetURI.

I think @dcposch changed the way torrent information is stored quite a bit since yesterday, you may have to manually delete the application config.

Platform
Location

OS X
~/Library/Application Support/<name>/config.json

Linux (XDG)
$XDG_CONFIG_HOME/<name>/config.json

Linux (Legacy)
~/.config/<name>/config.json

Windows (> Vista)
%LOCALAPPDATA%/<name>/config.json

Windows (XP, 2000)
%USERPROFILE%/Local Settings/Application Data/<name>/config.json

I tested what's on master and it's still working for me, but I was working on it yesterday too and cleared the config multiple times. Sorry! Remember this is under active development and unreleased so There Will Be Bugs :)

Ok. Application works again after a
$ rm ~/.config/WebTorrent/config.json


Created Matrix folder and added code

Kindly merge and add hacktober fest tags
Thanks in advance!!

while creating PR just add the #issue number(106) it will directly refer here


Change MaximumFreeLargePoolBytes to be a global limit

This changes the internal meaning of MaximumFreeLargePoolBytes to be a global limit to the pool size, similar to the limit for the block pool.
Up to now, if you had set a 64 MB limit, for example, this would apply for each of the large pools created. For example, if you specified a MaximumBufferSize of 64 MB and a LargePoolMultiple of 8MB, then you would have 8 sub-pools, and each one would have a limit of 64 MB.
This behavior was not publicly documented in the interface, and could lead to higher memory usage than expected.
I believe the original reason for this was to ensure that the different sub-pools didn't starve requests for specific buffer sizes. This change might introduce this problem, thus there is another implementation tweak: if the target sub-pool is empty, it will move on until a free buffer is found. If no free buffer is found, then the original target size is used to allocate a new buffer, which then has a chance to be pooled.
Resolves #290

Decided not to do this after all. Too many other changes that could have a negative performance impact.


Can't send a View using a Webhook

Summary
View does not appear in message sent from webhook in 2.3.2
Reproduction Steps
Send a message through a webhook with a view. The webhook was fetched through the bot and used in a slash command callback.
Minimal Reproducible Code
# all of the proper NC imports here

bot = Bot(intents = Intents.all())

class TestView(View):
	@button(label = "test")
	async def test_btn(self, btn: Button, intr: Interaction):
		await intr.send("test btn", ephemeral = True)

@bot.slash_command()
async def test(intr: Interaction):
	wh = await bot.fetch_webhook(WEBHOOK_ID_HERE)
	await wh.send("test", view = TestView())
	await intr.send("test", ephemeral = True)

Expected Results
The message sent from the webhook should have a button component.
Actual Results
The message sent from the webhook does not have a button component.
Intents
All
System Information

Python v3.10.1-final
nextcord v2.3.2-final
aiohttp v3.8.1
system info: Windows 10 10.0.19045

Checklist

[X] I have searched the open issues for duplicates.
[X] I have shown the entire traceback, if possible.
[X] I have removed my token from display, if visible.

Additional Context
No response

No, the original webhook was created by me on the channel. I have just tested sending a view with a bot-created webhook and it works as intended. Thank you for pointing this out.


feat: 🎸 update to sdk v22-beta.1

JIRA Link
updates to latest dual-sdk
Changelog / Description
BREAKING CHANGE: 🧨 TransactionHistoryFilersDto removes order and field params, replaced by orderBy field. Affects GET /accounts/{account}/transactions
Checklist -

[ ] New Feature ?
[ ] Updated swagger annotation (if API structure is changed) ?
[ ] Unit Test (if possible) ?
[ ] Updated the Readme.md (if required) ?

:tada: This PR is included in version 4.0.0-alpha.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


chore: release 1.8.0

:robot: I have created a release *beep* *boop*
1.8.0 (2024-02-24)
Features

优雅的报错提示 (93f8889)
可以切换多种引用格式 (9b835bb)
增加了时间范围选择,除arxiv (49a757f)
论文搜索完成进行提示 (6c37459)

Bug Fixes

复制文献问题 (a38b9ce)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/14790897/paper-ai/releases/tag/v1.8.0 :sunflower:


Allow an OkHttpClient to be supplied to Consul?

Consul allows users to supply lots of parameters and configuration, which are then used to create an OkHttpClient instance.
Should Consul also permit callers to supply an OkHttpClient directly? This would override any other configuration related to creating it, but would allow an application to create a single instance and share it, which the OkHttpClient documentation recommends by saying "OkHttpClients Should Be Shared". The documentation then states:

OkHttp performs best when you create a single OkHttpClient instance and reuse it for all of
your HTTP calls. This is because each client holds its own connection pool and thread pools.
Reusing connections and threads reduces latency and saves memory. Conversely, creating a client
for each request wastes resources on idle pools.

So, this might be a "nice to have" to allow direct creation of the OkHttpClient instance that Consul can use.

After looking at the code in Consul, there is a lot of code related to configuring and building the OkHttpClient including other objects such as an ExecutorService and ConnectionPool that are passed to the OkHttpClient . In order to allow a OkHttpClient instance to be passed in, the code would need to be changed so it never creates nor shuts down or closes those resources. This also means that many of those properties related to the OkHttpClient would be irrelevant.
Thus, there is a fair amount of code that would need to change, and at this point I don't think it's worth doing. And in addition, at least in our services, we don't use OkHttpClient so we don't have any real need for it.
So, closing this as "Won't Do".


add manager-hub to .gitignore

/lgtm

Codecov Report
Base: 77.66% // Head: 77.66% // No change to project coverage :thumbsup:

Coverage data is based on head (be99e95) compared to base (1f8d26c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   77.66%   77.66%
=======================================
  Files          26       26
  Lines        2794     2794
=======================================
  Hits         2170     2170
  Misses        517      517
  Partials      107      107

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Enable building latest megaservice image on push event in CI

Description
Enable building latest megaservice image on push event in CI and pushing it to image registry
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would break existing design and interface)

Dependencies
n/a
Tests
n/a

Dockerfile path issue will be fixed in another PR.


Remove image from inputs

Summary
This fixes a bug where when image is specified, it's passed to program inputs in addition to runtime options.
Details and comments
Fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-2.3%) to 61.428%

Totals

Change from base Build<PHONE_NUMBER>:
-2.3%

Covered Lines:
3252

Relevant Lines:
5294

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-2.3%) to 61.428%

Totals

Change from base Build<PHONE_NUMBER>:
-2.3%

Covered Lines:
3252

Relevant Lines:
5294

💛  - Coveralls


Want to set up my Ledger with the Blocks.io account

Hi guys,
I am not sure what I am doing with my EOS that I just bought a few months ago. I want to make sure they are safe. Can you help me set up my ledger with the Blocks.io account that I created for the EOS? Not sure how this wallet works and need assistance with it. Please help.
Regards,
Joe

This project is dead. Ledger support states that they have no control over this wallet. Beware they have no control over the EOS app either!!!


AttributeError: 'NoneType' object has no attribute 'drivername'

AttributeError
AttributeError: 'NoneType' object has no attribute 'drivername'
Traceback (most recent call last)
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\sqlalchemy\util_collections.py", line 1010, in call
return self.registry[key]
During handling of the above exception, another exception occurred:
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\flask\app.py", line 2463, in call
return self.wsgi_app(environ, start_response)
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\flask\app.py",
line 2449, in wsgi_app
response = self.handle_exception(e)
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\flask\app.py", line 1866, in handle_exception
reraise(exc_type, exc_value, tb)
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\flask_compat.py", line 39, in reraise
raise value
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\flask\app.py", line 2446, in wsgi_app
response = self.full_dispatch_request()
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\flask\app.py", line 1951, in full_dispatch_request
rv = self.handle_user_exception(e)
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\flask\app.py", line 1820, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\flask_compat.py", line 39, in reraise
raise value
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\flask\app.py", line 1949, in full_dispatch_request
rv = self.dispatch_request()
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\flask\app.py", line 1935, in dispatch_request
return self.view_functionsrule.endpoint
File "C:\Users\my pc\3D Objects\13-Deployment-Linode\flaskblog\main\routes.py", line 11, in home
posts = Post.query.order_by(Post.date_posted.desc()).paginate(page=page, per_page=5)
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\flask_sqlalchemy_init_.py", line 519, in get
return type.query_class(mapper, session=self.sa.session())
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\sqlalchemy\orm\scoping.py", line 78, in call
return self.registry()
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\sqlalchemy\util_collections.py", line 1012, in call
return self.registry.setdefault(key, self.createfunc())
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\sqlalchemy\orm\session.py", line 3225, in call
return self.class_(**local_kw)
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\flask_sqlalchemy_init_.py", line 138, in init
bind = options.pop('bind', None) or db.engine
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\flask_sqlalchemy_init_.py", line 937, in engine
return self.get_engine()
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\flask_sqlalchemy_init_.py", line 956, in get_engine
return connector.get_engine()
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\flask_sqlalchemy_init_.py", line 560, in get_engine
options = self.get_options(sa_url, echo)
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\flask_sqlalchemy_init_.py", line 575, in get_options
self._sa.apply_driver_hacks(self._app, sa_url, options)
File "C:\Users\my pc\AppData\Local\Programs\Python\Python38\Lib\site-packages\flask_sqlalchemy_init_.py", line 877, in apply_driver_hacks
if sa_url.drivername.startswith('mysql'):
AttributeError: 'NoneType' object has no attribute 'drivername'
The debugger caught an exception in your WSGI application. You can now look at the traceback which led to the error.
To switch between the interactive traceback and the plaintext one, you can click on the "Traceback" headline. From the text traceback you can also create a paste of it. For code execution mouse-over the frame you want to debug and click on the console icon on the right side.
You can execute arbitrary Python code in the stack frames and there are some extra helpers available for introspection:
dump() shows all variables in the frame
dump(obj) dumps all that's known about the object
Brought to you by DON'T PANIC, your friendly Werkzeug powered traceback interpreter.

I deleted this  code from the routes.py and other problems arised in code after this .Then the page started running but when clicked on login and registration "KeyError: 'A secret key is required to use CSRF." is shown
File "C:\Users\my pc\3D Objects\13-Deployment-Linode\flaskblog\main\routes.py", line 11, in home
posts = Post.query.order_by(Post.date_posted.desc()).paginate(page=page, per_page=5)


WIP: Pre-requisites to support basic Metal capture

Description
Hooking and capture serialization for MTLCommandBuffer APIs enqueue and waitUntilCompleted (required to capture test programs with enqueue support). These chunks are added to the command buffer record in order that the chunks are only included in the capture when the command buffer is included. The replay support for these APIs treats them at the global scope and not replayed within the command buffer. The enqueue chunk might not be required or used by replay in the future (currently it is used to verify the order of command buffer reply matches what is expected).
Updated the MetalCmdBufferRecordingInfo struct to store the CA::MetalLayer & WrappedMTLTexture from the MTL::Drawable instead of the MTL::Drawable. This avoids validation asserts about accessing the texture of an MTL::Drawable after calling MTLCommandBuffer::presentDrawable.
Changed member data bool present to uint32_t flags to be able to efficiently store more than one flag. Added MetalCmdBufferStatus enum to store different status flags.
Changed the return of WrappedMTLCommandBuffer::GetCommandQueueReturn to be a WrappedMTLCommandQueue * instead of MTL::CommandQueue *. It makes sense and is more natural to return the m_CommandQueue without casting it. The previous API usage was for the Objective C bridge layer which worked with `MTL::CommandQueue *. This is not required now the Objective C and C++ wrapping/unwrapping has been simplified.
This PR represents the final Objective C change in the current Metal development branch 🥳

https://github.com/baldurk/renderdoc/pull/2635


Fix args reordering when bool flags are present

Bug description
Args reordering possibly leads to wrong args when BoolFlags are present.
How to reproduce
Define some Command "cmd":
Flags: []Flag{
     StringFlag{Name: "option", Value: "", Usage: "some option"},
     BoolFlag{Name: "boolflag", Usage: "some bool"},
}

Call the command like the following:
cmd my-arg --boolflag --option my-option
Cause
Args reordering expects the next arg to be a value when no "=" is present. Providing a BoolFlag, the next args is not a value.

Good catch, thank you for addressing and adding a test case!

Unfortunately, git bisect tells me that this commit is what broke our tests.


Connectivity/HardenedUNCPaths's documentation not clear

Hello Team,
The documentation of the "Connectivity/HardenedUNCPaths" is not clear to us. It is specified that:
If you enable this policy, Windows only allows access to the specified UNC paths after fulfilling other security requirements.
What do they mean by "other security requirements" ? Additionally, providing an example (OMA-URI + value) would be great.
Best,
L.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2e70a68f-210c-b27a-3224-2cfd80028e60
Version Independent ID: c6a94ff0-9ab2-cd09-c053-e09304d0d16a
Content: Policy CSP - Connectivity - Windows Client Management
Content Source: windows/client-management/mdm/policy-csp-connectivity.md
Product: w10
Technology: windows
GitHub Login: @vinaypamnani-msft
Microsoft Alias: vinpa

Thanks @laurentdelosieresfactorial for the feedback. We're automating the CSP docs, which would list the OMA-URI for each policy. I've also updated this policy to include a link to https://support.microsoft.com/en-us/topic/ms15-011-vulnerability-in-group-policy-could-allow-remote-code-execution-february-10-2015-91b4bda2-945d-455b-ebbb-01d1ec191328 which talks about the additional requirements. These changes would be live later this month, so I'm closing this issue now.


Document behaviour of instance on custom initializations.

…lize_with'.

I no longer have merge access, so I will pass this along to @entcheva. Thanks again!

Thank you @Shigawire @composerinteralia!


Allow to display future operations.

Fixes #184.

Preview of future operations:

Thank you for this PR. I haven't tested it and I am pretty sure it would work this way. But we shouldn't have to filter future operations at several different places. Here is another way to do it which would be simpler, in my opinion:

when loading everything / loading operations of an account, put future operations in a separate list futureOperations attached to the enclosing account.
then, in the operation list, when the user wants to display future operations, just concatenate the futureOperations list with the operations list and store this as the operations to display in the operations list.

This should require minimal changes to the existing code (for instance, AccountList wouldn't need any modifications at all).

Review status: 0 of 9 files reviewed at latest revision, 16 unresolved discussions.

client/components/CheckBox.js, line 6 [r1] (raw file):
Can you simply rename it checked?

client/components/CheckBox.js, line 10 [r1] (raw file):
nit: trailing space

client/components/CheckBox.js, line 14 [r1] (raw file):
Probably can do: checked={this.props.isInitiallyChecked

client/components/DisplayOptions.js, line 14 [r1] (raw file):
nit: please rm 2 unnecessary blank lines

client/components/DisplayOptions.js, line 17 [r1] (raw file):
nit: trailing space

client/components/DisplayOptions.js, line 18 [r1] (raw file):
nit: blank space before >

client/components/DisplayOptions.js, line 20 [r1] (raw file):
nit: trailing space

client/components/DisplayOptions.js, line 22 [r1] (raw file):
The setting should be stored and/or retrieved with the right type, to avoid the need for calling toBoolean at each place using it. Maybe we need to add a type field to the Settings? (could be a separate commit / PR)

client/components/DisplayOptions.js, line 23 [r1] (raw file):
nit: simply onChange={this.props.onChangeFutureOperations}

client/components/OperationList.js, line 275 [r1] (raw file):
nit: line too long, please split it at the ? and : levels
condition
  ? blabla
  : blabla;

client/components/OperationList.js, line 279 [r1] (raw file):
nit: trailing space + please put a space before =

client/components/OperationList.js, line 429 [r1] (raw file):
You're using !this.state.showFutureOperations two times, please store it into a temporary variable.

client/components/OperationList.js, line 435 [r1] (raw file):
nit: unnecessary parenthesis + missing semicolon at EOL

client/components/OperationList.js, line 449 [r1] (raw file):
Please retrieve the date number value first, then only apply new Date(dateAsNumber).toLocateDateString(), so the condition is simpler.

client/components/TogglablePanelBody.js, line 3 [r1] (raw file):
Nice refactoring. Can you call it TogglablePanel instead?

client/components/TogglablePanelBody.js, line 6 [r1] (raw file):
details is the actual body, do you mind renaming it this way, please?

Comments from the review on Reviewable.io

Right. Will do like that

Review status: 0 of 9 files reviewed at latest revision, 1 unresolved discussion.

client/components/TogglablePanelBody.js, line 3 [r1] (raw file):
Yep. There might be a small regression : the transition seems slower

Comments from the review on Reviewable.io

There are really performance problems with this implementation. But I don't know if it due to this PR, or it is due to an accumulation of wrong choices on the operation list.

Review status: 0 of 10 files reviewed at latest revision, 1 unresolved discussion.

Comments from the review on Reviewable.io

I've quickly looked at the implementation:

there a few more tests per operation, which is pretty bad (a new test to compare the date, a new test for link||icon). The former could be solved by adding a local attribute member to the Operation model (client-only), isFuture, and fill that in the Operation ctor directly. This would prevent adding a test that involves creating a new Date object per operation. For the latter, I suspect it can be made trivial.
each time you call allOperations, there can be a concatenation, which might invalidate the state. How about setting the state once and for all, if and only if the checkbox gets checked? Then you don't need allOperations or operationsToConsider, as it's directly in the state of the OperationsList. It might still be an issue because we'd have to copy the operations, but let's experiment with that.

If this doesn't fix the issues, please use a browser profiler to check where time is spent. I really think we should have a proper infinite list implementation and will likely look into that the next few days.

Wow, that was a big review! Please get rid of the shouldComponentUpdate, as it's too hard to see if these changes are needed in the context of this PR. I'd rather look at them one by one. Also, the quadratic function in shouldDisplay is problematic, so you'll need another way to select the operations to display. Be brave! :)

Reviewed 13 of 15 files at r4.
Review status: all files reviewed at latest revision, 31 unresolved discussions.

client/components/Charts.js, line 593 [r4] (raw file):
nit: single line comment => //

client/components/Charts.js, line 595 [r4] (raw file):
nit: can you put undefined on the line above?

client/components/CheckBox.js, line 23 [r4] (raw file):
Can you put the label on the next line, please?

client/components/DatePicker.js, line 13 [r4] (raw file):
nit: two blank lines, please rm one

client/components/DisplayOptions.js, line 12 [r4] (raw file):
Is this really necessary?

client/components/DisplayOptions.js, line 24 [r4] (raw file):
Should onChangeFutureOperations be bound to this here?

client/components/DisplayOptions.js, line 34 [r4] (raw file):
Not sure, but it looks like this is not aligned with return by one space

client/components/OperationList.js, line 11 [r4] (raw file):
nit: blank line after this statement please

client/components/OperationList.js, line 16 [r4] (raw file):
Please put this comment on the same line as the TODO above

client/components/OperationList.js, line 274 [r4] (raw file):
nit: one condition per line, please

client/components/OperationList.js, line 279 [r4] (raw file):
nit: just one line for this component + it doesn't contain anything, just use a self-closing tag

client/components/OperationList.js, line 315 [r4] (raw file):
Please rename this into maybeIcon

client/components/OperationList.js, line 319 [r4] (raw file):
link is already a  and we probably don't want to embed a label within another one

client/components/OperationList.js, line 336 [r4] (raw file):
might as well rename the link attribute of OperationListViewLabelComponent

client/components/OperationList.js, line 457 [r4] (raw file):
You can just name this showFutureOperations as well

client/components/OperationList.js, line 462 [r4] (raw file):
This is O(n**2) in the number of operations. Please don't do that. (Try with 1000 operations if you're not convinced :p)

client/components/OperationList.js, line 486 [r4] (raw file):
Please use proper if and local variables to store intermediary state.
Also, you're doing: let lastCheckedAsNumber = new Date(x); let balanceDate = test ? new Date(...).toLocaleString() : lastCheckedAsNumber.toLocaleString()
You can do: let lastCheckedAsNumber = x; let balanceDate = test ? ... : lastCheckedAsNumber; balanceDate = new Date(balanceDate).toLocaleString();

client/components/OperationList.js, line 566 [r4] (raw file):
nit: bind this in the ctor

client/components/SearchOperationList.js, line 6 [r4] (raw file):
nit: unnecessary blank line

client/components/SearchOperationList.js, line 37 [r4] (raw file):
This is referring to state.showDetails although it's been deleted in the ctor. This needs to be changed as well.

client/components/SearchOperationList.js, line 226 [r4] (raw file):
nit: unnecessary blank line

client/components/TogglablePanel.js, line 25 [r4] (raw file):
nit: self-closing tag here

client/models.js, line 57 [r4] (raw file):
Please align the =.

client/store.js, line 206 [r4] (raw file):
No, the DS only stores strings. If you hit this assert, there is something wrong elsewhere in the code (probably default-settings.js). This method should remain unchanged.

client/store.js, line 291 [r4] (raw file):
wrong rebase here

shared/default-settings.js, line 10 [r4] (raw file):
"false" should be set within quotes (the DS only stores strings for the Config's values)

shared/locales/en.js, line 6 [r4] (raw file):
trailing spaces

shared/locales/en.js, line 7 [r4] (raw file):
Wrong rebase in this file :/

shared/locales/en.js, line 23 [r4] (raw file):
ditto

shared/locales/fr.js, line 8 [r4] (raw file):
ditto

shared/locales/fr.js, line 23 [r4] (raw file):
ditto

Comments from the review on Reviewable.io

Review status: 7 of 13 files reviewed at latest revision, 3 unresolved discussions.

client/components/DisplayOptions.js, line 12 [r4] (raw file):
If I don't set this like that, the component is rerendered each time the list of operations is rerendered (on search for an example) . The component only needs to be rerendered when the state changes, which is managed in TogglePanel

client/components/DisplayOptions.js, line 24 [r4] (raw file):
Is is bound in the OPerationList componenent

client/components/OperationList.js, line 462 [r4] (raw file):
Fallback to previous situation

Comments from the review on Reviewable.io

@bnjbvr, it was hard, but finally, the fi is here :P .

Review status: 3 of 13 files reviewed at latest revision, 3 unresolved discussions.

Comments from the review on Reviewable.io

Almost there! Can you remove most shouldComponentUpdate calls? I'm fine with adding them in a separate PR, they need intense double checking.

Reviewed 11 of 11 files at r5.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

client/components/OperationList.js, line 305 [r5] (raw file):
Can you remove the wrapping span here, please? And reuse link so we don't need a third variable to test on.

client/components/OperationList.js, line 482 [r5] (raw file):
Can be made even simpler:
        let showFutureOperations = this.state.showFutureOperations;
        let balanceDate = showFutureOperations ?
            Math.max(lastChecked, Math.max.apply(null, this.state.operations.map(op => op.date))) :
            lastChecked;
        balanceDate = new Date(balanceDate).toLocaleDateString();

the two inner Math.max calls can be grouped (use [lastChecked].concat(this.state.operations.map...))
it shouldn't be this.state.operations but this.state.filteredOperations
I think operations are sorted all the way long, so you'd just have to look at the first (or last) operation, with respect to the sort order

client/components/SearchOperationList.js, line 157 [r5] (raw file):
nit: indent is wrong here

Comments from the review on Reviewable.io

Ha, there's a bug now :p
Also, there's too much blank space between the two operations list panels, can you fix that please? They should be much closer to each other, in my opinion.

Reviewed 5 of 7 files at r6.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

client/components/OperationList.js, line 308 [r6] (raw file):
maybeAttachment isn't defined

client/components/OperationList.js, line 462 [r6] (raw file):
Won't this mean that we don't take the search filters into account anymore? That's a bug!

Comments from the review on Reviewable.io

OK,  I have fixed the distance between the panels, before having a clean solution, as discussed on IRC.

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from the review on Reviewable.io

Well, the sprite was updated, as I genereated it with another script, should not change a lot.

Review status: 4 of 13 files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

Reviewed 7 of 7 files at r7.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

Thanks for the PR! Unfortunately, Reviewable didn't show me a few things during the review.
Also: it seems that all future operations are taking into account when computing the balance / wells amounts. Is it expected? I would have thought that the balance would update when we click on "select pending operations".
I think this should belong to the next release, as a few things are a bit unsure at this point (how to solve the balance problem? potential rendering slowdowns? should we merge the panels?). What do you think? This will let us more time to think about how to answer these questions.

I close until I have a clean way not to have two "togglable panels". I am thinking of using the same tab system as in the chart component. What do you think of such a solution @bnjbvr ?

Sounds good to me!


Elysia throws error if Headers#toJSON doesn't exist

Output

Code
Is this check / fallback still required?
https://github.com/elysiajs/elysia/blob/08a4375b91d9d359fe7a0264b29d7512a729ea8f/src/compose.ts#L211-L219

Yes, thanks for inspecting the code, the error comes from that line and is now fixed in Elysia 0.5.10 in this commit https://github.com/elysiajs/elysia/commit/9db731df33d8fc68948ffb3d790258680b53c6c3
Furthermore, when you were using CommonJS you might get an error from Memorist accidentally shipping ES Module instead CommonJS problem which is also solved in the same release.


Refresh ARM API version

Changes:

update azure.apiVersion with 2022-09-01
update azure.apiVersionForVirtualMachines with 2022-11-01
add azure.apiVersionForAvailabilitySets
increase pom version
fix "All request routing rules should have a priority defined starting from api-version 2021-08-01"

Tests:

Build admin offer
Build cluster offer
Build dynamic cluster offer
Test admin offer
Test cluster offer
Test dynamic cluster offer

Hello @mriccell , can you please merge this? Thanks.