anydesk: 6.0.1 -> 6.1.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/anydesk/versions.
meta.description for anydesk is: "Desktop sharing application, providing remote support and online meetings"
meta.homepage for anydesk is: "https://www.anydesk.com"
meta.changelog for anydesk is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 6.1.0 with grep in /nix/store/lbbam9mfgshk1h4qpwyhdnvii1pv8isk-anydesk-6.1.0

directory tree listing: https://gist.github.com/69c3714561f82a726f39549a99527e24

du listing: https://gist.github.com/33f0fbebea4234acb7de9310aea80660

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
anydesk

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lbbam9mfgshk1h4qpwyhdnvii1pv8isk-anydesk-6.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A anydesk https://github.com/r-ryantm/nixpkgs/archive/901e699b614cb7a09903f6931e14744373f2ff62.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lbbam9mfgshk1h4qpwyhdnvii1pv8isk-anydesk-6.1.0
ls -la /nix/store/lbbam9mfgshk1h4qpwyhdnvii1pv8isk-anydesk-6.1.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

anydesk

Maintainer pings
cc @shyim for testing.

Result of nixpkgs-review pr 111146 run on x86_64-linux 1

1 package built:

anydesk

Result of nixpkgs-review pr 111146 run on x86_64-linux 1

1 package built:

anydesk

According to the changelog, this "Dropped 32bit Linux support", so we should remove that as well.

See also #111622


[UI]

At first glance, the choice of amount is not clear to me as a user. I think these options, a fixed amount and a custom amount, should be open and more understandable at once.

fee 17eth)))

Thanks for the suggestion! We have added the task to our design sprint.


Azure Arc Powerpoint slides still references AAD RBAC (not Entra ID)

Azure Arc Powerpoint slides still references AAD RBAC (not Entra ID)

Particularly noticed in the arc_library.pptx

Although could be in others.

Hi @lukemurraynz thank you.
The old website is no longer, see our new website at https://aka.ms/ArcJumpstart.com.
New Diagrams are available at https://aka.ms/JumpstartDiagrams


try tests: how come the sleep time is zero?

i'm trying to improve the retry tests but it seems for them the waiting time between retries is zero although we call "ofDefaults" which should mean a sleep time of 500ms. I can't find the piece of magic which overrides this sleep time for the tests?

Hi,
thx for contributing. It would be nice if you would like to improve the retry functionality. Maybe by introducing a delay which back offs exponentially instead of a fixed delay between delays.

I have a look at the tests.

yes!! I exactly want to add a setBackoffFunction(Function<Duration,Duration>) :-)

and as a first step I want to improve the tests so it's possible to asset how much time was slept. I'm almost done on that but confused because the tests don't sleep at all :-) sleep time = 0.

Might be a bug

FYI my approach is to make it possible to use another function instead of Thread.sleep, that function has a counter (and doesn't sleep) and that way we can assert how long the sleep last.
Some bits:
private static Try.CheckedConsumer<Long> sleepFunction = Thread::sleep;

RetryContext.testsSetSleepFunction(sleep -> sleptTime += sleep);

assertThat(sleptTime).isEqualTo(RetryContext.DEFAULT_WAIT_DURATION);

In other words the goal before that would be that Thread.sleep is called with the right waiting time. I was looking at this before, it's called with 0. Tried to track down where it's modified for tests and failed.
In the constructor of RetryContext this helps =>
this.waitDuration = 500; //waitDuration.getSeconds() * 1000;

But fixing the caller of RetryContext does NOT help (build()). In addition modifying the tests to build the context like that:
Retry retryContext = Retry.custom().waitDuration(java.time.Duration.ofMillis(500)).build();

also doesn't help. It's like something is mocked in test mode or something...

right. now that i sat down again and looked a it again and saw it immediately...
        this.waitDuration = waitDuration.getSeconds() * 1000;

set a sleep time of 500ms (the default!!!) and getSeconds() will return 0, and you don't sleep at all, it only works at the second resolution. I'll fix that through my PR as well, coming soon!


I am experiencing an issue with receiving the 'delivered' status on iOS

I added the extensions as instructed, but still, I'm not getting the 'delivered' status on iOS.

Hi @flatronwowa,
please can you elaborate, on where you are encountering the problem?
Thanks
Regards


VAPID run error

Hi,
I have downloaded VAPiD-master folder and running VAPID with the following command, it shows following error. Please help me to figure out the error.
run command:
python /VAPiD-master/vapid.py --db all_virus.fasta rndm_assembly.fasta template.sbt
error:
metadata not found in provided .csv or .csv not created -  time for minimal manual entry for sequence - 1
Traceback (most recent call last):
File "/VAPiD-master/vapid.py", line 958, in
metadata, coverage, full_name_list[x] = do_meta_data(virus_strain_list[x], True, full_name_list[x])
File "/home/mmk6053/Bcov_new/rndm-reads/vapid_run/VAPiD-master/vapid.py", line 863, in do_meta_data
col = ' [collection-date=' + raw_input('Enter collection date in the format (23-Mar-2005, Mar-2005, or 2005): ').strip() + ']'
NameError: name 'raw_input' is not defined

Hi!
This is a problem running the python 2 version on python 3. Instead try python vapid3.py ...
Hopefully this works for you and happy annotating!
Ryan

I am trying python vapid3.py. Also, I generated the index files of my genome fasta file using makeblastdb. However, it still showing following error.
running command:
python /VAPiD-master/vapid3.py --db all_virus.fasta rndm_assembly.fasta template.sbt --metadata_loc metadata.csv
BLAST Database error: No alias or index file found for nucleotide database [all_virus.fasta] in search path [/Bcov_new/rndm-reads/vapid_run::]
Traceback (most recent call last):
File "/VAPiD-master/vapid3.py", line 968, in
strain2species[virus_strain_list[x]] = annotate_a_virus(virus_strain_list[x], virus_genome_list[x],
File "/VAPiD-master/vapid3.py", line 634, in annotate_a_virus
name_of_virus, our_seq, ref_seq, ref_accession, need_to_rc = blast_n_stuff(strain, strain + SLASH + strain + '.fasta')
File "/VAPiD-master/vapid3.py", line 186, in blast_n_stuff
record = Entrez.read(Entrez.esearch(db='nucleotide', term=ref_seq_gb))
UnboundLocalError: local variable 'ref_seq_gb' referenced before assignment


Is solana docs are outdated?

Hello, I am trying to generate fungible token. I am  following the official docs, but getting a lot of error and warnings like:
confirmTransaction is deprecated
OR
SolanaJSONRPCError: airdrop to failed: Internal error
OR
Error: signature must be base58 encoded: undefined.
I want to ask is the solana documention is outdated?
My code:
import {
  clusterApiUrl,
  Connection,
  Keypair,
  LAMPORTS_PER_SOL,
} from<EMAIL_ADDRESS>
import { createMint } from "@solana/spl-token";

const payer = Keypair.generate();
const mintAuthority = Keypair.generate();
const freezeAuthority = Keypair.generate();

const connection = new Connection(clusterApiUrl("devnet"), "confirmed");

try {
  const airDropSignature = await connection.requestAirdrop(
    payer.publicKey,
    LAMPORTS_PER_SOL
  );

  const latestBlockHash = await connection.getLatestBlockhash();
  console.log(latestBlockHash);

  await connection.confirmTransaction({
    blockhash: latestBlockHash.blockhash,
    lastValidBlockHeight: latestBlockHash.lastValidBlockHeight,
    airDropSignature,
  });

  console.log("transaction confirmed");

  const mint = await createMint(
    connection,
    payer,
    mintAuthority.publicKey,
    freezeAuthority.publicKey,
    9 // We are using 9 to match the CLI decimal default exactly
  );
  console.log(mint.toBase58());
} catch (err) {
  console.log(err);
}

I have tried all the possible solutions that i can find on internet, but nothing worked for me

Yes we are also having A LOT of errors trying to set up
web3

SPL Token
Metaplex Token Metadata
Auction House

The documentations look clear but all the code keep throwing errors. Example tutorials on the web or on github are also causing multiple errors.
There are so many GitHub accounts and paths .. I'm not sure why?
Nothing has clear versioning.
There is no documentation on conflicting versions (if any).
So far Solana Rust compilation and JS development has been extremely painful for us.
Our client is upset, my developer's morale is low, I'm burning late night oil and still stuck in this tar pit.

@aa21  Yes I can understand your pain. I am also suffering alot.

To help others I will document any documents that help me here:
SPL Token - official introduction and examples:
https://spl.solana.com/token
SPL Token - methods, properties:
https://solana-labs.github.io/solana-program-library/token/js/modules.html
Sol Web3 Examples - Unofficial @yihau :
https://yihau.github.io/solana-web3-demo/

Hello, I am trying to generate fungible token.. .  I want to ask is the solana documention is outdated?

Hi @daniyal-tayyab .. I realised yesterday that there are two main versions of SPL-Token
"@solana/spl-token": "^0.1.x"
and
"@solana/spl-token": "^0.2.x"
0.2.x is the latest version and code that worked on 0.1.x will NOT work on 0.2.x .. e.g. 0.1.8.
I faced a lot of headache without knowing this, because all the code I found online was throwing errors.
I advice you to check your package.json.
This important information is hidden away deep inside this github here:
https://github.com/solana-labs/solana-program-library/tree/master/token/js
Maybe Solana developers believe that pain is the best teacher? 🤷♂

@aa21 Thanks man you saved my day.

@daniyal-tayyab you're welcome :)
Another thing I realised today was that React 18 breaks away from React 17.
Looks like the year 2022 had a lot of breaking changes in multiple libraries.
The lesson I learnt was to start paying more attention to package.json module versions.


By default, parameters.yml contains {} if a compose file is used

PS: It's not the case if no compose-file is used.
How to reproduce
docker-app init -c cp.yml foo
Expected
cat foo.dockerapp/settings.yml

Reality
cat foo.dockerapp/settings.yml
{}

Version
Version:      0.1.0
Git commit:   9eec848
OS/Arch:      linux/amd64
Experimental: off
Renderers:

Won't fix


'az disk grant-access --access-level Write' needs an example

Can this please be documented?
(Sorry, this is possibly a dupe of my other open issue, I thought this would land on a Docs repo... Either way.)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 74997eeb-6fa3-4318-79da-8cf4dce59cfe
Version Independent ID: c8cea09f-196e-7269-dc42-b6b8933dbaf1
Content: az disk
Content Source: latest/docs-ref-autogen/disk.yml
Service: storage
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

For example: get the SAS url and then upload a VHD to it, or do a blob copy from a blob somewhere else in some Azure storage account.

add to S163.

@colemickens we have a few end to end examples that are similar to what you described:
https://github.com/Azure-Samples/azure-cli-samples/blob/master/virtual-machine/copy-managed-disks-vhd-to-storage-account/copy-managed-disks-vhd-to-storage-account.sh
https://github.com/Azure-Samples/azure-cli-samples/blob/master/virtual-machine/copy-snapshots-to-storage-account/copy-snapshots-to-storage-account.sh
Neither of them specifically use the --access-level parameter though, so if you'd like an example with I can write one up.

We can close this, I don't need an example. It now works as one might expect. From my recollection, when I filed this the service wasn't working very... predictably.
Also, when I wrote this up and tested it, due to Azure's polling, this method of direct pushing to a managed disk blob was actually slower than pushing to storage and then creating a MD from the blob. Which of course means that I have to still name and manage storage accounts, but at least I'm not just waiting non-trivial amounts of time to just take/release a lease.


Donor portal not showing aid package update posts when user not logged in

Is your feature request related to a problem? Please describe.
When viewing the detail of an aid package in the donor portal, the update messages associated with the aid package is not shown unless the user is logged in.  Below are screen shots of the same aid package for anonymous and logged in users
Anonymous user view

Logged in user view

Describe the solution you'd like
The updates should be shown for all users

@akbandara This is due to aidpackages/${packageID}/updatecomments API is not being public. We need to make this API public @manuranga

made public


Research checklists not available after consent

After giving consent to a research, the Research checklists should be loaded and made are available for inspections.
At reload of the complete app (refresh of page), they are available, but after giving consent in the app they should immediately be available.

Done

Done


Fix location encoder test on gpu

Partially adddresses #485  (the first 3 errors listed)
Fixes the issue below by removing all deterministic=True usages in the codebase. I don't think we were relying on this for anything but please correct me if I'm wrong @dereklhansen , @jeff-regier. A seed can still be set via training.seed.
E       RuntimeError: scatter_add_cuda_kernel does not have a deterministic implementation, but you set 'torch.use_deterministic_algorithms(True)'. You can turn off determinism just for this operation if that's acceptable for your application. You can also file an issue at https://github.com/pytorch/pytorch/issues to help us prioritize adding deterministic support for this operation.

I don't think the deterministic flag is needed for our use-case. Because of floating point error, the result of a summation can be slightly different depending on the order it is executed in, so "deterministic=True" ensures that all such operations are done in the exact same order (at the cost of computation speed). I think the random seed is more important

I agree, thanks @dereklhansen


etap2_review

[x] text is in C# and use .NET
[x] build succeeded
[x] all UT are green
[x] layers are clearly stated using language terms only
[x] Data API is abstract and contains object model representing process data, which must be clearly stated
[x] prove that the data integration is implemented.
[ ] Logic uses only the abstract Data layer API
[ ] Communication between the client and the server should be made using the Web Socket
[ ] reactive and interactive communication are used
[x] client API must be clearly stated
[x] Unit Test - layers are tested independently using abstract API
[x] Dependency injection (additional framework is not required)
[ ] Mock is used for testing purpose (expected but not required)

9/12


Skip a day from a graph

Is there an elegant way to skip a day in a graph when there is no dailynotes file? Here is the logic - most Saturday's our family life is insanely busy. I usually don't journal etc. So no notes file. It makes my graphs harder to read because the graph is disjoint.

Hi @mlevison,
Set fillGap to true will make all neighbor data points connected.

Looks like it was resolved, will close this issue.


Documentation

Is your feature request related to a problem? Please describe.
Write documentative comments for scripts.
Additional context
This will feature better recognition.

Documentation should also be applied to  CSS.


revise ValueSet/request-intent URL, to resolve CLI upload-definitions problem

Fixes #601

Coverage increased (+0.003%) to 76.701% when pulling dbdebdbcdaca74ec576ae3ec224b06601745e71e on joelsch:upload-definitions-bugfix into 3f712fdf8a801d9248f0cabba874d348834020f8 on jamesagnew:master.

Looksd great, merging it now.


Added redis, which disappeared for some reason...

because you're looking at teh wrong branch :D 2.0 is a dead branch, not used anymore, lemme delete it thx


ClassNotFoundException: kafka.serializer.StringEncoder

when using camel-2.16-SNAPSHOT
Caused by: java.lang.ClassNotFoundException: kafka.serializer.StringEncoder
	at org.apache.camel.impl.DefaultClassResolver.resolveMandatoryClass(DefaultClassResolver.java:80)
	at org.apache.camel.component.kafka.KafkaEndpoint.createProducer(KafkaEndpoint.java:83)
	at org.apache.camel.impl.ProducerCache.doGetProducer(ProducerCache.java:402)

camel-swagger is supposed to migrate off scala. This may be related to the two scala versions currently in use

Blocked on camel-2.16

This seems to have been verified as working for Kafka producers some time ago.
https://github.com/wildfly-extras/wildfly-camel/blob/master/itests/standalone/basic/src/main/java/org/wildfly/camel/test/kafka/KafkaIntegrationTest.java#L108
Unless this was failing in some other scenario, I'm going to close this.


There's no code

You did not provide any implementation.

Hi,
We will upload it soon, will keep you posted.
Thanks.
Roger

Uploaded the code


Make it easier to debug a flutter/engine C++ test

This is a follow up to https://github.com/flutter/flutter/issues/145186
Status quo
Currently the best way to debug a Flutter engine C++ googletest is using a custom VS Code launch.json file:
{
  "version": "0.2.0",
  "configurations": [
     {
      "name": "embedder_unittests",
      "type": "cppvsdbg",
      "request": "launch",
      "preLaunchTask": "Build host_debug_unopt",
      "program": "../out/host_debug_unopt/embedder_unittests.exe",
      "cwd": "${workspaceRoot}",
      "args": [
        "--gtest_filter=EmbedderTest.TestIWantToDebugHere"
      ],
      "logging": {
        "moduleLoad": false,
        "trace": true
      }
    },
    ...
  ]
}

I need a separate configuration for each gtest executable (embedder_unittests.exe, flutter_windows_unittests.exe).
To switch which test I debug, I need to:

Switch the active VS Code launch configuration:

Edit the launch.json file to edit the --gtest_filter.

Potential solution
Ideally we would have a better VS Code integration. Each GTEST macro would:

Have a codelens action to Run or Debug the test:

Show up in the VS Code's testing panel:

It seems that vscode-catch2-test-adapter extensions does the job.
Minimal .vscode/settings.json:
{
  "testMate.cpp.test.advancedExecutables": [
    {
      "pattern": "out/host_debug_unopt/*unittests"
    }
  ]
}

Result:


Storing Image

How can we store Image in the ContentProvider. I tried this, but not working
@Column(Column.FieldType.BLOB)
        public static final String IMAGE = "image"; //objectId

Blob is the way to go. You have to compress your bitmap into a byte array as described here: http://stackoverflow.com/a/9357943

Nothing to fix here


Add pysam to the workflow/envs/mapdamage.yaml

As MinLuke reported in issue #131, newly created conda environments don't work on the mapDamage step because they don't find pysam.
A quick fix is to add pysam in the workflow/envs/mapdamage.yaml like this:
channels:

conda-forge
bioconda
defaults
dependencies:
htslib<1.15.1
mapdamage2
htslib<1.15.1
parallel
samtools
pysam

worked for him and for me

Can confirm the issue!

(testing the workaround)

I close it since the issue was fixed in the previous PR


[Question] self.metadata["render_modes"] assertion error while building custom environment.

Question
Hello!
First of all thank you very much for all the work you guys do maintaining the gymnasium environments.
My question is the following: When I try to build on top of the defined Walker2d-v5 environment defined here, I get the following assertion error message:  assert self.metadata["render_modes"] == [
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: ['human', 'rgb_array', 'depth_array', 'rgbd_tuple']
I was wondering if you could help with this issue. So far it only causes issues with the Walker2d-v5 environment and I encounter no issues building  on top of the Hopper-v5, Ant-v5 and Humanoid-v5 environments.
The custom environments code:
__credits__ = ["Kallinteris-Andreas"]

from typing import Dict, Tuple, Union

import numpy as np

from gymnasium import utils
from gymnasium.envs.mujoco import MujocoEnv
from gymnasium.spaces import Box

DEFAULT_CAMERA_CONFIG = {
    "trackbodyid": 2,
    "distance": 4.0,
    "lookat": np.array((0.0, 0.0, 1.15)),
    "elevation": -20.0,
}

class Walker2dEnv_AC(MujocoEnv, utils.EzPickle):
    r"""
    ## Description
    This environment builds on the [hopper](https://gymnasium.farama.org/environments/mujoco/hopper/) environment by adding another set of legs that allow the robot to walk forward instead of hop.
    Like other MuJoCo environments, this environment aims to increase the number of independent state and control variables compared to classical control environments.
    The walker is a two-dimensional bipedal robot consisting of seven main body parts - a single torso at the top (with the two legs splitting after the torso), two thighs in the middle below the torso, two legs below the thighs, and two feet attached to the legs on which the entire body rests.
    The goal is to walk in the forward (right) direction by applying torque to the six hinges connecting the seven body parts.

    ## Action Space
    ```{figure} action_space_figures/walker2d.png
    :name: walker2d
    ```

    The action space is a `Box(-1, 1, (6,), float32)`. An action represents the torques applied at the hinge joints.

    | Num | Action                                 | Control Min | Control Max | Name (in corresponding XML file) | Joint | Type (Unit)  |
    |-----|----------------------------------------|-------------|-------------|----------------------------------|-------|--------------|
    | 0   | Torque applied on the thigh rotor      | -1          | 1           | thigh_joint                      | hinge | torque (N m) |
    | 1   | Torque applied on the leg rotor        | -1          | 1           | leg_joint                        | hinge | torque (N m) |
    | 2   | Torque applied on the foot rotor       | -1          | 1           | foot_joint                       | hinge | torque (N m) |
    | 3   | Torque applied on the left thigh rotor | -1          | 1           | thigh_left_joint                 | hinge | torque (N m) |
    | 4   | Torque applied on the left leg rotor   | -1          | 1           | leg_left_joint                   | hinge | torque (N m) |
    | 5   | Torque applied on the left foot rotor  | -1          | 1           | foot_left_joint                  | hinge | torque (N m) |

    ## Observation Space
    The observation space consists of the following parts (in order):

    - *qpos (8 elements by default):* Position values of the robot's body parts.
    - *qvel (9 elements):* The velocities of these individual body parts (their derivatives).

    By default, the observation does not include the robot's x-coordinate (`rootx`).
    This can be included by passing `exclude_current_positions_from_observation=False` during construction.
    In this case, the observation space will be a `Box(-Inf, Inf, (18,), float64)`, where the first observation element is the x-coordinate of the robot.
    Regardless of whether `exclude_current_positions_from_observation` is set to `True` or `False`, the x-coordinate are returned in `info` with the keys `"x_position"` and `"y_position"`, respectively.

    By default, however, the observation space is a `Box(-Inf, Inf, (17,), float64)` where the elements are as follows:

    | Num | Observation                                        | Min  | Max | Name (in corresponding XML file) | Joint | Type (Unit)              |
    | --- | -------------------------------------------------- | ---- | --- | -------------------------------- | ----- | ------------------------ |
    | 0   | z-coordinate of the torso (height of Walker2d)     | -Inf | Inf | rootz                            | slide | position (m)             |
    | 1   | angle of the torso                                 | -Inf | Inf | rooty                            | hinge | angle (rad)              |
    | 2   | angle of the thigh joint                           | -Inf | Inf | thigh_joint                      | hinge | angle (rad)              |
    | 3   | angle of the leg joint                             | -Inf | Inf | leg_joint                        | hinge | angle (rad)              |
    | 4   | angle of the foot joint                            | -Inf | Inf | foot_joint                       | hinge | angle (rad)              |
    | 5   | angle of the left thigh joint                      | -Inf | Inf | thigh_left_joint                 | hinge | angle (rad)              |
    | 6   | angle of the left leg joint                        | -Inf | Inf | leg_left_joint                   | hinge | angle (rad)              |
    | 7   | angle of the left foot joint                       | -Inf | Inf | foot_left_joint                  | hinge | angle (rad)              |
    | 8   | velocity of the x-coordinate of the torso          | -Inf | Inf | rootx                            | slide | velocity (m/s)           |
    | 9   | velocity of the z-coordinate (height) of the torso | -Inf | Inf | rootz                            | slide | velocity (m/s)           |
    | 10  | angular velocity of the angle of the torso         | -Inf | Inf | rooty                            | hinge | angular velocity (rad/s) |
    | 11  | angular velocity of the thigh hinge                | -Inf | Inf | thigh_joint                      | hinge | angular velocity (rad/s) |
    | 12  | angular velocity of the leg hinge                  | -Inf | Inf | leg_joint                        | hinge | angular velocity (rad/s) |
    | 13  | angular velocity of the foot hinge                 | -Inf | Inf | foot_joint                       | hinge | angular velocity (rad/s) |
    | 14  | angular velocity of the thigh hinge                | -Inf | Inf | thigh_left_joint                 | hinge | angular velocity (rad/s) |
    | 15  | angular velocity of the leg hinge                  | -Inf | Inf | leg_left_joint                   | hinge | angular velocity (rad/s) |
    | 16  | angular velocity of the foot hinge                 | -Inf | Inf | foot_left_joint                  | hinge | angular velocity (rad/s) |
    | excluded | x-coordinate of the torso                     | -Inf | Inf | rootx                            | slide | position (m)             |

    ## Rewards
    The total reward is: ***reward*** *=* *healthy_reward bonus + forward_reward - ctrl_cost*.

    - *healthy_reward*:
    Every timestep that the Walker2d is alive, it receives a fixed reward of value `healthy_reward` (default is $1$),
    - *forward_reward*:
    A reward for moving forward,
    this reward would be positive if the Swimmer moves forward (in the positive $x$ direction / in the right direction).
    $w_{forward} \times \frac{dx}{dt}$, where
    $dx$ is the displacement of the (front) "tip" ($x_{after-action} - x_{before-action}$),
    $dt$ is the time between actions, which depends on the `frame_skip` parameter (default is $4$),
    and `frametime` which is $0.002$ - so the default is $dt = 4 \times 0.002 = 0.008$,
    $w_{forward}$ is the `forward_reward_weight` (default is $1$).
    - *ctrl_cost*:
    A negative reward to penalize the Walker2d for taking actions that are too large.
    $w_{control} \times \|action\|_2^2$,
    where $w_{control}$ is `ctrl_cost_weight` (default is $10^{-3}$).

    `info` contains the individual reward terms.

    ## Starting State
    The initial position state is $[0, 1.25, 0, 0, 0, 0, 0, 0, 0] + \mathcal{U}_{[-reset\_noise\_scale \times I_{9}, reset\_noise\_scale \times I_{9}]}$.
    The initial velocity state is $\mathcal{U}_{[-reset\_noise\_scale \times I_{9}, reset\_noise\_scale \times I_{9}]}$.

    where $\mathcal{U}$ is the multivariate uniform continuous distribution.

    Note that the z-coordinate is non-zero so that the Walker2d can stand up immediately.

    ## Episode End
    ### Termination
    If `terminate_when_unhealthy is True` (which is the default), the environment terminates when the Walker2d is unhealthy.
    The Walker2d is unhealthy if any of the following happens:

    1. Any of the state space values is no longer finite
    2. The z-coordinate of the torso (the height) is **not** in the closed interval given by the `healthy_z_range` argument (default to $[0.8, 1.0]$).
    3. The absolute value of the angle (`observation[1]` if `exclude_current_positions_from_observation=False`, else `observation[2]`) is ***not*** in the closed interval specified by the `healthy_angle_range` argument (default is $[-1, 1]$).

    ### Truncation
    The default duration of an episode is 1000 timesteps.

    ## Arguments
    Walker2d provides a range of parameters to modify the observation space, reward function, initial state, and termination condition.
    These parameters can be applied during `gymnasium.make` in the following way:

    ```python
    import gymnasium as gym
    env = gym.make('Walker2d-v5', ctrl_cost_weight=1e-3, ...)
    ```

    | Parameter                                    | Type      | Default           | Description                                                                                |
    | -------------------------------------------- | --------- | ----------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
    | `xml_file`                                   | **str**   |`"walker2d_v5.xml"`| Path to a MuJoCo model                                                                                |
    | `forward_reward_weight`                      | **float** | `1`               | Weight for _forward_reward_ term (see `Rewards` section)                                                                                |
    | `ctrl_cost_weight`                           | **float** | `1e-3`            | Weight for _ctr_cost_ term (see `Rewards` section)                                                                                |
    | `healthy_reward`                             | **float** | `1`               | Weight for _healthy_reward_ reward (see `Rewards` section)                                                                                |
    | `terminate_when_unhealthy`                   | **bool**  | `True`            | If True, issue a `terminated` signal is unhealthy (see `Episode End` section)                                                                                |
    | `healthy_z_range`                            | **tuple** | `(0.8, 2)`        | The z-coordinate of the torso of the walker must be in this range to be considered healthy (see `Episode End` section)                                                                              |
    | `healthy_angle_range`                        | **tuple** | `(-1, 1)`         | The angle must be in this range to be considered healthy (see `Episode End` section)                                                                                |
    | `reset_noise_scale`                          | **float** | `5e-3`            | Scale of random perturbations of initial position and velocity (see `Starting State` section)                                                                                |
    | `exclude_current_positions_from_observation` | **bool**  | `True`            | Whether or not to omit the x-coordinate from observations. Excluding the position can serve as an inductive bias to induce position-agnostic behavior in policies (see `Observation Space` section) |

    ## Version History
    * v5:
        - Minimum `mujoco` version is now 2.3.3.
        - Added support for fully custom/third party `mujoco` models using the `xml_file` argument (previously only a few changes could be made to the existing models).
        - Added `default_camera_config` argument, a dictionary for setting the `mj_camera` properties, mainly useful for custom environments.
        - Added `env.observation_structure`, a dictionary for specifying the observation space compose (e.g. `qpos`, `qvel`), useful for building tooling and wrappers for the MuJoCo environments.
        - Return a non-empty `info` with `reset()`, previously an empty dictionary was returned, the new keys are the same state information as `step()`.
        - Added `frame_skip` argument, used to configure the `dt` (duration of `step()`), default varies by environment check environment documentation pages.
        - In v2, v3 and v4 the models have different friction values for the two feet (left foot friction == 1.9 and right foot friction == 0.9). The `Walker-v5` model is updated to have the same friction for both feet (set to 1.9). This causes the Walker2d's the right foot to slide less on the surface and therefore require more force to move (related [GitHub issue](https://github.com/Farama-Foundation/Gymnasium/issues/477)).
        - Fixed bug: `healthy_reward` was given on every step (even if the Walker2D is unhealthy), now it is only given if the Walker2d is healthy. The `info` "reward_survive" is updated with this change (related [GitHub issue](https://github.com/Farama-Foundation/Gymnasium/issues/526)).
        - Restored the `xml_file` argument (was removed in `v4`).
        - Added individual reward terms in `info` (`info["reward_forward"]`, `info["reward_ctrl"]`, `info["reward_survive"]`).
        - Added `info["z_distance_from_origin"]` which is equal to the vertical distance of the "torso" body from its initial position.
    * v4: All MuJoCo environments now use the MuJoCo bindings in mujoco >= 2.1.3
    * v3: Support for `gymnasium.make` kwargs such as `xml_file`, `ctrl_cost_weight`, `reset_noise_scale`, etc. rgb rendering comes from tracking camera (so agent does not run away from screen)
    * v2: All continuous control environments now use mujoco-py >= 1.50
    * v1: max_time_steps raised to 1000 for robot based tasks. Added reward_threshold to environments.
    * v0: Initial versions release
    """

    metadata = {
        "render_modes": [
            "human",
            "rgb_array",
            "depth_array",
            "rgbd_tuple",
        ],
    }

    def __init__(
        self,
        xml_file: str = "walker2d_v5.xml",
        frame_skip: int = 4,
        default_camera_config: Dict[str, Union[float, int]] = DEFAULT_CAMERA_CONFIG,
        forward_reward_weight: float = 1.0,
        ctrl_cost_weight: float = 1e-3,
        ac_cost_weight: float = 1e-3,
        healthy_reward: float = 1.0,
        terminate_when_unhealthy: bool = True,
        healthy_z_range: Tuple[float, float] = (0.8, 2.0),
        healthy_angle_range: Tuple[float, float] = (-1.0, 1.0),
        reset_noise_scale: float = 5e-3,
        exclude_current_positions_from_observation: bool = True,
        **kwargs,
    ):
        utils.EzPickle.__init__(
            self,
            xml_file,
            frame_skip,
            default_camera_config,
            forward_reward_weight,
            ctrl_cost_weight,
            healthy_reward,
            terminate_when_unhealthy,
            healthy_z_range,
            healthy_angle_range,
            reset_noise_scale,
            exclude_current_positions_from_observation,
            **kwargs,
        )

        self._forward_reward_weight = forward_reward_weight
        self._ctrl_cost_weight = ctrl_cost_weight
        self._ac_cost_weight = ac_cost_weight

        self._healthy_reward = healthy_reward
        self._terminate_when_unhealthy = terminate_when_unhealthy

        self._healthy_z_range = healthy_z_range
        self._healthy_angle_range = healthy_angle_range

        self._reset_noise_scale = reset_noise_scale

        self._exclude_current_positions_from_observation = (
            exclude_current_positions_from_observation
        )

        MujocoEnv.__init__(
            self,
            xml_file,
            frame_skip,
            observation_space=None,
            default_camera_config=default_camera_config,
            **kwargs,
        )

        self.metadata = {
            "render_modes": [
                "human",
                "rgb_array",
                "depth_array",
                "rgbd_tuple",
            ],
            "render_fps": int(np.round(1.0 / self.dt)),
        }

        obs_size = (
            self.data.qpos.size
            + self.data.qvel.size
            - exclude_current_positions_from_observation
        )
        self.observation_space = Box(
            low=-np.inf, high=np.inf, shape=(obs_size,), dtype=np.float64
        )

        self.observation_structure = {
            "skipped_qpos": 1 * exclude_current_positions_from_observation,
            "qpos": self.data.qpos.size
            - 1 * exclude_current_positions_from_observation,
            "qvel": self.data.qvel.size,
        }

        # previous actions for action smoothness
        self.prev_action = np.zeros(6)  # run and see the action dim
        self.second_prev_action = np.zeros(6)  # run and see the action dim

    @property
    def healthy_reward(self):
        return self.is_healthy * self._healthy_reward

    def control_cost(self, action):
        control_cost = self._ctrl_cost_weight * np.sum(np.square(action))
        return control_cost

    def ac_cost(self, action):
        # Calculate the second difference of actions for smoothness
        delta_action = action - 2 * self.prev_action + self.second_prev_action

        # Calculate the smoothness cost based on the magnitude of action changes (second derivative)
        ac_cost = self._ac_cost_weight * np.sum(np.square(delta_action))
        return ac_cost

    @property
    def is_healthy(self):
        z, angle = self.data.qpos[1:3]

        min_z, max_z = self._healthy_z_range
        min_angle, max_angle = self._healthy_angle_range

        healthy_z = min_z < z < max_z
        healthy_angle = min_angle < angle < max_angle
        is_healthy = healthy_z and healthy_angle

        return is_healthy

    def _get_obs(self):
        position = self.data.qpos.flatten()
        velocity = np.clip(self.data.qvel.flatten(), -10, 10)

        if self._exclude_current_positions_from_observation:
            position = position[1:]

        observation = np.concatenate((position, velocity)).ravel()
        return observation

    def step(self, action):
        x_position_before = self.data.qpos[0]
        self.do_simulation(action, self.frame_skip)
        x_position_after = self.data.qpos[0]
        x_velocity = (x_position_after - x_position_before) / self.dt

        observation = self._get_obs()
        reward, reward_info = self._get_rew(x_velocity, action)
        terminated = (not self.is_healthy) and self._terminate_when_unhealthy
        info = {
            "x_position": x_position_after,
            "z_distance_from_origin": self.data.qpos[1] - self.init_qpos[1],
            "x_velocity": x_velocity,
            **reward_info,
        }

        # previous actions
        self.second_prev_action = self.prev_action
        self.prev_action = action

        if self.render_mode == "human":
            self.render()
        # truncation=False as the time limit is handled by the `TimeLimit` wrapper added during `make`
        return observation, reward, terminated, False, info

    def _get_rew(self, x_velocity: float, action):
        forward_reward = self._forward_reward_weight * x_velocity
        healthy_reward = self.healthy_reward
        rewards = forward_reward + healthy_reward

        ctrl_cost = self.control_cost(action)
        as_cost = self.ac_cost(action)
        costs = ctrl_cost + as_cost
        reward = rewards - costs

        reward_info = {
            "reward_forward": forward_reward,
            "reward_ctrl": -ctrl_cost,
            "reward_as": - as_cost,
            "reward_survive": healthy_reward,
        }

        return reward, reward_info

    def reset_model(self):
        noise_low = -self._reset_noise_scale
        noise_high = self._reset_noise_scale

        qpos = self.init_qpos + self.np_random.uniform(
            low=noise_low, high=noise_high, size=self.model.nq
        )
        qvel = self.init_qvel + self.np_random.uniform(
            low=noise_low, high=noise_high, size=self.model.nv
        )

        self.set_state(qpos, qvel)

        # reset past actions
        self.prev_action.fill(0)
        self.second_prev_action.fill(0)

        observation = self._get_obs()
        return observation

    def _get_reset_info(self):
        return {
            "x_position": self.data.qpos[0],
            "z_distance_from_origin": self.data.qpos[1] - self.init_qpos[1],
        }

And the line that causes the issue is :    env = Walker2dEnv_AC()
Thank you very much for your help in advance!

are you using the latest git version of gymnasium or 1.0?

are you using the latest git version of gymnasium or 1.0? If you want target to target 1.0 and not the next release, you want to comment this line.
            "rgbd_tuple",

I am using gymnaisum 1.0, however simply uncommenting that line does not solve the issue.


Run containers part 2

I started working on the run containers implementation, my starting point is #56 by @josephglanville.
I fixed some bugs but I'm sure I introduced new ones with the operations on runs, I need to add a lot of new tests for runs.

Awesome! I don't have much time to help atm but will review and comment where I can. :)

I'm going to start picking this back up @Kerollmops. I noticed the remove_range implementation is most likely not working yet which is preventing the new tests I have added from passing so I will focus on fixing that up and adding the remaining run container store operations. I will open a PR against your branch once I have some progress to show.

Thanks a lot @josephglanville, indeed it seems like I didn't take enough time to make this method work. I hope you fix it, and wait for your PR, thank you 😄

@josephglanville I was taking a look through history in #12

I think storing start, end will result in slightly nicer code vs storing start, run_length.
Serialisation will of course follow the format specification

I haven't made an opportunity to look through the code for this PR yet. Is that what were doing?
My concern is if we deviate we wont be able to use the same "frozen" format for lazy containers

when use insert_range in a empty RoaringBitmap , maybe can use RunContainer ?

@saik0 yeah that is a valid concern and not something I had thought of at the time but think it makes sense as to make it easier to support mmaped bitmaps without needing separate code for them. I don't think the code is too hard to modify to use start + len instead just have to adjust when searching for intervals etc.
If you want to work on this go ahead, my progress has been slow because I am (as usual) occupied with other things sadly.

I'm unclear what's needed to finish this, is there anything I can do to help?


Reusing WireMockExtension from abstract base class fails

We are running into an issue with the JUnit 5 WireMockExtension. When the extension is defined as a static final on an abstract base class and re-used in several child classes. The WireMock server is stopped after the first test class finishes (@AfterAll) and not restarted when the second test class is executed (@BeforeAll).
The second test class will execute beforeAll and call startServerIfRequired. The wireMockServer field is already initialized by the first test class and skip initialization of the WireMock server. The test will then try to connect to a stopped server.
A solution could be to dereference the WireMock server in the stopServerIfRunning method. Causing the second test to re-initialize the WireMock server:
private void stopServerIfRunning() {
    if (wireMockServer != null && wireMockServer.isRunning()) {
        wireMockServer.stop();
    }
   wireMockServer = null;
}

WireMock version: 2.31.0
Reproducer: https://github.com/timpeeters/wiremock-bug

I think this is already fixed in c4ece200f318a35a12f281cfc6bb2903800d904f

Fixed after upgrading to 2.32.0.


Add SO_REUSEADDR to socket.

Thanks a lot for making a contribution to SFML! 🙂
Before you create the pull request, we ask you to check the follow boxes. (For small changes not everything needs to ticked, but the more the better!)

[ ] Has this change been discussed on the forum or in an issue before?
[ ] Does the code follow the SFML Code Style Guide?
[ ] Have you provided some example/test code for your changes?
[ ] If you have additional steps which need to be performed list them as tasks!

Description
Now, you can kill your server and instantly restart it without an error message that the address is in use.
This PR is related to the issue #
Tasks

[x] Tested on Linux
[ ] Tested on Windows
[ ] Tested on macOS
[ ] Tested on iOS
[ ] Tested on Android

How to test this PR?
Build an EmptyEpsilon server with it.

As far as I remember, this flag has other implications that made it not so suitable for every situation.
Do you have a strong experience of socket flags, or did you just happen to successfully test this one in your particular case, and thought it should be the default in SFML? 😉

Yeah I've got experience with this flag but would not claim to be a network expert. From my understanding it's a common "quick fix" to allow you to re-bind a port almost immediately after a socket has just closed on it. Typical behaviour is the port is still bound for a short while to allow any delayed messages to come through. The inherent risk is that the new socket may receive packets which were intended for the old socket that was bound to this port
I think there's some debate over whether using this flag is a good idea or not - Some people say the correct thing to do is wait out the timeout until the port can be bound again, some say that's being over-cautious and you can just ignore any stale packets that come through.
I don't feel strongly either way - waiting for the timeout is arguably more correct, but allowing address reuse is arguably simpler.

General practice for SO_REUSEADDR on "normal" sockets is to set it when you have a TCP server socket (i.e. TCP sockets that you call listen() and accept() on) that is bound to a fixed port.
In all other cases, including TCP server sockets that are not bound to a fixed port (e.g. by passing 0 as port number to bind()), TCP client sockets (i.e. TCP sockets that you call connect() on), and all UDP sockets, there is rarely a reason to set SO_REUSEADDR.
(In the case of UDP sockets there can be weird effects, e.g. when the OS allows two applications to simultaneously open a UDP socket on the same address and port...)

Since setting this socket option depends on the concrete use case, it would be something that SFML optionally allows the developer to activate via a member function.

@binary1248 Given that there are separate classes TcpSocket, TcpListener and UdpSocket my suggestion, if fitting for SFML, would be for TcpListener to automatically set SO_REUSEADDR when being bound to a local port that is not 0, and the other two classes to never touch that flag (or optionally have a member function for manual use). That way all three socket classes, by default, do that what is correct for (nearly) all regular use cases.

previously: issue #150.

previously: issue #150.

I believe we'll need a different implementation, if we do decide to support this, as such I'm going to close this PR.


fixed sidebar styles!

changed underscore for body and title classnames to dash to fix problem!

Probably not necessary to make 3 commits for this change, but great job fixing the issue!  Ready to merge 👍

Also in future pull requests please mention the issue you are fixing (#1)

@jacquelynfambrough  This was good to merge, but now you've added more code to it.  I can't accept it with irrelevant changes in it :-(


GitHub with Microsoft

This is not good. Would not be it to be continued better the project on GitLab?

What is the threat model you are concerned about?

Maybe they change their TOS to let Microsoft use anything without restrictions, more data collection, or even more microsoft integration which might not be that beneficial

Changing their TOS may never override the license of our own code. That doesn't make sense in terms of copyright law, it would be like the museum owner saying that he is now the author of the works exposed... even the borrowed ones! ;-)

But everything else could

Properly. It is not for me also about the code. He has the respective licence.
Rather it is for me about Microsoft directly. Now more data are stored definitively. There it comes for users to difficulties can come to get if, for example, also possible Ip's with the "git pull" etc. in wrong hands.
And if one has a look at Skype, this stands in the complete contrast to Twister.
For the purposes of the mind of Twister it would make sense to change.
This as a thought.

Something like git-ssb would make more sense for the project https://git.scuttlebot.io/%256nsHTcWJ3IuXPiFSr4lz3NEROnHGQEu36kjYHTKrWes%3D.sha256/blob/73b4b7d083757d91a5151c23eacbe9c6ae615ebf/volume-0/git-ssb/index.md


Instructions are needed for running against mysql data source

Trying to set this up for a Mysql Data Source required some trial and error in the Data Source configuration. It could be useful to others to add to the documentation/readme some notes on that.
After downloading the JDBC Mysql connector and placing it in jdbc-drivers according to the instructions, In Data Source I had to set the Connection Url to jdbc:mysql://[ip]:[port]/[db] but more importantly I had to set the Driver Class Name to com.mysql.cj.jdbc.Driver.
Attempting to Ping the database gives me a ERROR: java.sql.SQLException: SQL String cannot be empty but I can use the Data Source for Reports.

Add MySQL data source example


chore: Add message to AssertionError

Add a message to Assertion Error when file passed to ModelWrapper does not exist (or is not a file).
A lot of times I pass a wrong path to ModelWrapper and cannot see the error at first glance, but just after I spot the line of code in the traceback. This PR makes this more explicit.

Thanks for the PR @rpitonak ! This was failing the linting check (probably a spaces issue in the line you modified) so I've run the linter and pushed to your source branch. For any future PRs, can you make sure you run linting prior to submission: https://finn-dev.readthedocs.io/en/latest/developers.html#linting


[pg] select version() should return column version

Query: SELECT version().
Now YDB returning column0

We need to investigate a generic solution, but right now I do quick fix for FuncCall

https://github.com/ydb-platform/ydb/pull/1801


Be able to group/tag processes

From Max Leske
The use case I have in mind is again ImageMagick.  Also assume that I invoke another command often, say curl. I want to be able to kill all ImageMagick commands or all curl commands at once. That means I would have to track child processes separately for both (or in some kind of centralised object). If OSSubprocess had a facility for grouping the only thing I’d have to do would be to add something like #groupAs: #imageMagick when creating the process.
I do see that this may take some work. I also concede that it’s not something terribly necessary. I just though it could be nice (think of CGroups for instance: https://www.kernel.org/doc/Documentation/cgroups/cgroups.txt).
Max, would you agree that instead of groupAs: a tag: could do the trick and since it's quite general it might have other use cases besides grouping?

Yes, definitely.


Extract stack configuration into own repo.

Both webpack and gulp to allow users (and me) update their stacks via npm update.

too magic


[SPARK-32940][SQL] Collect, first and last should be deterministic aggregate functions

What changes were proposed in this pull request?

Collect, first and last have mistakenly been marked as non-deterministic. They are actually deterministic iff their child expression is deterministic.
For example collect was marked as non-deterministic in #14749. The reasoning was that its output depends on the actual order of input rows. Although it is correct that these aggregators depend on the order of input rows, it does not make them non-deterministic.
In EliminateSorts optimizer rule, there is a method isOrderIrrelevantAggs, that lists all aggregators that do not depend on their input row order. Collect, first and last are correctly not listed there.
An aggregator would be non-deterministic if its output for a group would depend on previous groups it has aggregated - I can't think of any practical examples of this kind of aggregator in Spark.
An analogous aggregator to these would be sum on float and double datatype  - its result does depend on the order of its inputs, but is deterministic.
Why are the changes needed?

The optimizer rule PushPredicateThroughNonJoin can work in more cases.
Does this PR introduce any user-facing change?

No
How was this patch tested?

UT

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@cloud-fan, you reviewed the related pull request (although years back).

ok to test

Test build #128898 has started for PR 29810 at commit b9fd2f1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33521/
Test PASSed.

Test build #128898 has finished for PR 29810 at commit b9fd2f1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128898/
Test FAILed.

Test build #128910 has started for PR 29810 at commit b0919a2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33532/
Test PASSed.

Test build #128910 has finished for PR 29810 at commit b0919a2.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128910/
Test FAILed.

In EliminateSorts optimizer rule, there is a method isOrderIrrelevantAggs, that lists all aggregators that do not depend on their input row order. Collect, first and last are correctly not listed there.

hmm, it's pretty weird if we list first/last there. Removing sort will definitely change the query result, doesn't it?

In EliminateSorts optimizer rule, there is a method isOrderIrrelevantAggs, that lists all aggregators that do not depend on their input row order. Collect, first and last are correctly not listed there.

hmm, it's pretty weird if we list first/last there. Removing sort will definitely change the query result, doesn't it?

Sorry if I didn't word it correctly - these are not listed there.  I tried to exemplify the difference between deterministic and order irrelevant.

Maybe I am missing something here. AFAIK the problem with First/Last/CollectList methods is that we can't control how results are merged. This depends on how we shuffle fetches results and this is not deterministic.

Maybe I am missing something here. AFAIK the problem with First/Last/CollectList methods is that we can't control how results are merged. This depends on how we shuffle fetches results and this is not deterministic.

You are 100% correct. As a user, this is how I would also understand the term deterministic.
But, internally deterministic has different meaning - by this definition Sum should be also non-deterministic if its input type is float or double.
I'll copy our internal definition:
   * Note that this means that an expression should be considered as non-deterministic if:
   * - it relies on some mutable internal state, or
   * - it relies on some implicit input that is not part of the children expression list.
   * - it has non-deterministic child or children.
   * - it assumes the input satisfies some certain condition via the child operator.

For aggregation expressions the internal state part can introduce extra confusion - of course all of them have some internal state about the current group they are aggregating (running count, largest value seen  so far, etc), but they do not "remember" the previous groups they have aggregated.
There is a separate optimizer rule EliminateSorts, that keeps track of aggregators, that do not depend on input order - max, count, etc. But these are a subset of all deterministic aggregators.
For context, why this is relevant:
A snippet from PushPredicateThroughNonJoin
https://github.com/apache/spark/blob/c336ddfdb81dd5c27fd109d62138dc129a02c30b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala#L1138-L1141
Basically this case will filter out groups in the aggregation before aggregating the values. Within one group the aggregator will still see all the same rows in the same order, but it would not see the groups, that were filtered out. This would change the output of an aggregator, that remembers previous groups (non-deterministic), but it would not change the output of an aggregator, that only cares about the current group (deterministic, but possibly order relevant).

Test build #133545 has started for PR 29810 at commit a080b53.

Test build #133545 has finished for PR 29810 at commit a080b53.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38136/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133545/

Test build #133547 has started for PR 29810 at commit dc6e7c0.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38138/

Test build #133547 has finished for PR 29810 at commit dc6e7c0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133547/

Pinging @maropu

Pinging @maropu

Test build #136279 has started for PR 29810 at commit 4229251.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40861/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40861/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40861/

Test build #136279 has finished for PR 29810 at commit 4229251.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136279/

Test build #136309 has started for PR 29810 at commit 13c92f3.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40891/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40891/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40891/

Test build #136309 has finished for PR 29810 at commit 13c92f3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136309/

Test build #137303 has started for PR 29810 at commit da196d0.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41883/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41883/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41883/

Test build #137303 has finished for PR 29810 at commit da196d0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137303/

Test build #140262 has started for PR 29810 at commit e5e9a04.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44790/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44790/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44790/

Test build #140262 has finished for PR 29810 at commit e5e9a04.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140262/

Test build #143761 has started for PR 29810 at commit 56fbf15.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48272/

Test build #143761 has finished for PR 29810 at commit 56fbf15.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143761/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48272/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48272/

There is inevitable randomness in the input of aggregate functions, because the shuffle reader may produce data with random orders, and we are not able to completely eliminate this randomness. For example, even sum has randomness, as adding up floating values with different orders can lead to slightly different results.
I don't think first/last/collect has a significant difference and +1 to mark them as deterministic.

retest this please

Test build #144906 has started for PR 29810 at commit 0d40311.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49375/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49375/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49375/

Test build #144906 has finished for PR 29810 at commit 0d40311.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class HistogramPlotBase(NumericPlotBase):
class KdePlotBase(NumericPlotBase):
       new_class = type(NameTypeHolder.short_name, (NameTypeHolder,),
class Database(NamedTuple):
class Table(NamedTuple):
class Column(NamedTuple):
class Function(NamedTuple):
class SparkUpgradeException(CapturedException):
  protected class YarnSchedulerEndpoint(override val rpcEnv: RpcEnv)
public class ExpressionImplUtils
class IndexAlreadyExistsException(message: String, cause: Option[Throwable] = None)
class NoSuchIndexException(message: String, cause: Option[Throwable] = None)
trait ExtractValue extends Expression with NullIntolerant
case class AesEncrypt(input: Expression, key: Expression, child: Expression)
case class AesDecrypt(input: Expression, key: Expression, child: Expression)
case class SetCatalogAndNamespace(child: LogicalPlan) extends UnaryCommand
case class CreateFunction(
case class CreateView(
case class SetCatalogCommand(catalogName: String) extends LeafRunnableCommand
case class SetNamespaceCommand(namespace: Seq[String]) extends LeafRunnableCommand
case class ShowCatalogsCommand(pattern: Option[String]) extends LeafRunnableCommand
case class HashedRelationBroadcastMode(key: Seq[Expression], isNullAware: Boolean = false)

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144906/

Test build #144921 has started for PR 29810 at commit e4ed57c.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49393/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49393/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49393/

thanks, merging to master!

Test build #144921 has finished for PR 29810 at commit e4ed57c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144921/


Clean Validation Reports Job

feat(jobs): added job to delete validation reports;

Added config option clean_validation_reports.
Added job to delete validation reports from unsupported formats.

This adds the possible feature (controlled by config option) to delete validation reports for unsupported formats. This is useful in the case that a user updates a Resource to no longer be a format that goes through validation, but the validation report and badge remains. So this helps with keeping the validation table size down a bit, and helps showing the correct validation badge (or lack there of)

@ThrawnCA res['id'] also changed to resource_id for uninitialized res in exception handling

@duttonw would this be able to get merged too?


No Option to Update Channel Name for PPV Channels

Please first read the documentation. Problems affecting the client, e.g. Plex or Emby should be reported there in the forum.
Whenever I try to add my NFL, MLB or PPV channels to Threadfin, they don't have the option to "Update Channel Name" so that the channel and epg update with new events.

Docker
Intel 64 Bit
Threadfin 1.2 (3)

I noticed that in the xepg.json file, the channels that do show the Updated Channel Name option have a "_uuid.key" set.

You do not need to do that. The PPV Dummy data handles that for you, hence why it isnt there. It grabs the content from the channel name and populates the xml with it


If using description for the command line TOC content, only use the first sentence.

Work for this issue will begin begin on branch work-liquid-labs/command-line-documentation/11.


PR: Extend spyder-terminal to Windows

Fixes #22
Fixes #83

Should I include this PR as part of 0.1.2 or rather 0.2.0? @ccordoba12 @goanpeca

0.2 I guess?
Left some comments

@andfoy, before merging this one, please solve the issues that already tagged to 0.1.2. Then release that version, then you could merge this.
I don't want to see you merging this before 0.1.2, ok?

Completely understood!

@ccordoba12 @goanpeca Should we extend our tests to Windows?

Should we extend our tests to Windows?

Absolutely :-)

@goanpeca Can you give me a hand by enabling AppVeyor?

Tests are now working on Windows

@Enabled

@goanpeca Thanks!

@andfoy maybe start a separate PR for that :-)

@andfoy, you need to add an appveyor.yml for tests to start working i this PR.

No, I think it's fine to continue here.

@ccordoba12 appveyor.yml it's empty right now, what should I define inside?

@andfoy, use the Spyder one as a guide. It should easy to adapt here.

@ccordoba12 Is there any way to skip tests on Windows?

Sure, take a look at test_ipythonconsole.py in Spyder to see how to do it.

@goanpeca @ccordoba12 Any additional comments before merging this one?

I need to update the README information

Please squash as most commits as you can about adding appveyor.yml. There are a lot of unnecessary commits there.
Then, please merge. Great work, by the way!!

I left another comment about not using conda-forge to install any packages. That's very important too, so please address it before merging.

@ccordoba12 Do I have to move winpty also?

@goanpeca Can you instruct me about anaconda package migration between channels?

Yes, hoy need to move all pywinpty deps to our channel

https://docs.continuum.io/anaconda-cloud/commandreference

@goanpeca Yes i have already an account at Anaconda, but I don't have access to spyder-ide channel

@andfoy what is your username ?

andfoy, as always

you should have access now

@goanpeca @ccordoba12 Can someone give me the link reference for AppVeyor status badge?

[![Build status](https://ci.appveyor.com/api/projects/status/edsy2hkd3rwcfjrg?svg=true)](https://ci.appveyor.com/project/spyder-ide/spyder-terminal)

Thanks! @goanpeca

@ccordoba12 @goanpeca I think we're ready to merge this one

Nice!! Fantastic work, thanks a lot for it!


bug fixes and logs update

@gokumar
Bug fixes and enhancements

Logging added, can be controlled with parameter.
Bug fix to eliminate duplicate values reported.
default polling interval changed to 5000 ms to handle failure due to RPC response time.
emit changed to emitEvent to eliminate potential crash scenario.
Additional error scenarios handled.

Also, make sure if you bounce the framework.lua version as you have made some minor changes...


doc/effective_go.html: select is not mentioned in control structures section

What version of Go are you using (go version)?
N/A ,  see https://golang.org/doc/effective_go.html#control-structures
Does this issue reproduce with the latest release?
N/A
What operating system and processor architecture are you using (go env)?
N/A
What did you do?
opened effective go and searched for select
What did you expect to see?
documentation about the nuances and patterns of usage for select:

Frequently used within a "while loop" (for {)

 for  {
    select {
        case o := <-one:
           fmt.Println("one", o)
        case o := <- two:
           fmt.Println("two", o)
     }
}

Chooses at random if multiple available

one := make(chan bool)
two := make(chan int)
go func() { one <- true }
go func() { two <- 13 }
select {
   case o := <- one:
        fmt.Println("one", o)
   case o := <- two:
        fmt.Println("two", o)
}
// Output: will randomly output either "one true" or "two 13"

timeout pattern: https://gobyexample.com/timeouts
wait for N channels to close pattern: https://stackoverflow.com/a/13666733/1114274

personally, i prefer:
for o != nil && e != nil {
	select {
	case i, ok := <-o:
		if !ok {
			o = nil
		}
		fmt.Println("o", i)
	case i, ok := <-e:
		if !ok {
			e = nil
		}
		fmt.Println("e", i)
	}
}

What did you see instead?
only one example in "Leaky Buffer" section? https://golang.org/doc/effective_go.html#leaky_buffer

CC: @robpike @rsc

I didnt realize effective go was in the source! LMK if a PR is welcome as I could write something.
This was brought to my attention as I've been mentoring a new go developer in my workplace and I was like "Just read effective go everything you need is there...".

Yeah, not everything. (See also #25107.)

If any of the ideas mooted for Go 2 come to pass, the document will likely get a massive rewrite. Until then I'd prefer to leave the document alone. There are a number of outstanding issues but none pressing enough to worry about now.
It's not "everything". It's just the basics, with some style and background.


custom domain

hook up gh-pages with a proper domain (to escape the medialize.github.io domain).
see https://help.github.com/articles/setting-up-a-custom-domain-with-github-pages/

linked to allyjs.io


Need to require rubygems for ruby 1.8

Still need to require rubygems for ruby 1.8 compatibility

ruby --version
ruby 1.8.7 (2011-06-30 patchlevel 352) [i686-darwin11.2.0]

bin/jeweler
./bin/../lib/jeweler/generator.rb:1:in `require': no such file to load -- git (LoadError)
	from ./bin/../lib/jeweler/generator.rb:1
	from bin/jeweler:4:in `require'
	from bin/jeweler:4

I'm not sure this is quite the right path. In general, you don't want to require rubygems in your executables. With bundler based projects, you can bundle exec stuff that is in bin/, so might be worth checking out how that works

bundle exec would work.
I think a conditional require in the bin/executable is less confusing. Running a executable just as an executable is what people used to. After all, Jewler is trying to use "#!/usr/bin/env ruby" as a shell and not the bundler.
Doing a rubygems require in the library does not make sense because the library will be required at some point somewhere before it gets executed.

Side note, but the commit for this actually has a commented out require :)
I don't think I ever saw this with 1.8 because I turned on rubygems by default for my ruby. Recently turned that off though, since rvm doesn't really recommend it.
Anyways, I'm not sure which is preferred, because I suspect there's weird edge cases either way we go (requiring rubygems or not). I do know that using bundler on a project, you can just bundle exec stuff out of the bin directory as if it was a bin in your Gemfile.

Just kidding, found a better way. I looked up how bundler's gemspec works and copied that :)
bundle exec jeweler will be the preferred way of running in development, or through a rubygems wrapper (ie that it installs when you gem install jeweler) otherwise.

Sounds good :-)


Update retinanet_swin-t-p4-w7_fpn_1x_coco.py

Fix the error encountered during loading the pretrained backbone as follows,
2022-01-10 09:45:12,308 - mmdet - INFO - load checkpoint from http path: https://github.com/SwinTransformer/storage/releases/download/v1.0.0/swin_small_patch4_window7_224.pth
Traceback (most recent call last):
File "tools/train.py", line 185, in
main()
File "tools/train.py", line 159, in main
model.init_weights()
File "/home/shengliliu/anaconda3/envs/cots/lib/python3.7/site-packages/mmcv/runner/base_module.py", line 116, in init_weights
m.init_weights()
File "/home/shengliliu/anaconda3/envs/cots/lib/python3.7/site-packages/mmdet/models/backbones/swin.py", line 706, in init_weights
if list(state_dict.keys())[0].startswith('module.'):
IndexError: list index out of range
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
The documentation has been modified accordingly, like docstring or example tutorials.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM

Hi @ShengliLiu！First of all, we want to express our gratitude for your significant PR in the MMDetection project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA
If you have WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤ @ShengliLiu


Fix stale GVK in benchmark test

Causing postsubmit failure post merge of the v1 change

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
35757c764998efe30a1414a6db81ba100ca2e101
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
35757c764998efe30a1414a6db81ba100ca2e101
link
true
/test lint

gencheck_istio
35757c764998efe30a1414a6db81ba100ca2e101
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
c6ce9c22333a22ad4774e50ab7d459243e6746f7
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ds_istio
c6ce9c22333a22ad4774e50ab7d459243e6746f7
link
unknown
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ds_istio
c6ce9c22333a22ad4774e50ab7d459243e6746f7
link
unknown
/test integ-ds

integ-telemetry-istiodremote_istio
c6ce9c22333a22ad4774e50ab7d459243e6746f7
link
unknown
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest


stryker

changing badge to stryker as of infection 0.26.0

Codecov Report

Merging #6 (7a3cd3f) into master (964eacc) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              master        #6   +/-   ##
===========================================
  Coverage     100.00%   100.00%
  Complexity        88        88
===========================================
  Files             15        15
  Lines            217       217
===========================================
  Hits             217       217

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 964eacc...7a3cd3f. Read the comment docs.


Fixed Exception when start the game

Fixed the exception when start the game #85

Fixes #85

Thanks for this! Great help. I get home to see a mystery game patch and the mod broken :P


Suggestion - Send mails to a subset of the examiners depending on the question or exercise

Hello again,
When the number of students is high, the number of mails for information and details on the corrections can also be high. To avoid sending too many emails, it could be worth to have a tool to enable the selection of some examiners that are responsible for each specific question or exercise (the latter when #333 will be dealt with).
Thank you!

related to #429


[otlLib.builder] Add function to build STAT table from high-level description

Continuation of #1922 after a rebase debacle. Still WIP.

FYI there is a way to mark a PR as "Draft", see the link under the Reviewers section at the top right (it says "Still in progress? Convert to draft")

For now I went for the additional "locations" argument, loosely following @madig's model. I'm not 100% convinced yet, but it's definitely better than what I had before.
Recapping:

This treats AxisValue Format 4 as a separate kind of axis values, to be specified in the locations argument of buildStatTable(). Regular AxisValues (format 1, 2 and 3) are specified as subitems of axis dicts.

The alternative would be to treat all AxisValue items as potentially multi-axis (making format 1 a special case of format 4, as per @Lorp's view). This would mean we need to supply all axis values separate from the axis dicts, leading to some redundancies for the common case, in which a location uses only one axis.

I'm still open for the latter route. While it is a little lower level for the common case, it would be relatively easy to translate the higher level structure to the lower one.

I think this is ready to merge. I've changed the varLib STAT building code with a call to the new function, which was a nice exercise in code deletion.

Does this make statmake obsolete?

Does this make statmake obsolete?

No: statmake is higher level and has ways to come up with the contents of STAT. In @madig's words (from https://github.com/fonttools/fonttools/pull/1922#issuecomment-624860807):

statmake is indeed intended to be a higher-level and opinionated tool to maintain STAT information (because you can't deduce it automatically from the Designspace in all cases) and I'd love to get rid of the bare table generation and filling-in.

This API is only concerned with the compiling user-supplied content to STAT table data ready to compile to binary. statmake could become a client of this API.

Thanks for explaining!


Respectfully request that #238 be left off of this list. I've found it invaluable in my journeys.

I would also like to request that #666 be left off this list as well. This pull request is beauty in code form, almost as if it's straight from djb himself.
Was this, perhaps, a typo? You might have meant to enter in #667, where I believe the requestor was coming down off of his three day PCP binge and decided to write that abomination of code in the mean time. Seriously, have you looked at #667? It's by all means, terrible. And I am not making this comment lightly.

@facto #238, IMO, has made no significant contributions to this project.
If anything, it is going to hurt this project.  I meant #667.

Impressed. But why these are hurting the open source?

@huei90 Because this project was better without those issues/pull requests.

I don't think he gets the joke. I do. Hence, I am impressed.

+1

THE SCROLLING! WON'T SOMEONE THINK OF THE SCROLLING!
We should have an issue for each issue and pull request that is going to hurt this project.

@execat Do you mean that this project should open for public to edit?
There's no need waiting for PR?

#16 Really hurts this one :+1:

@vircung @rrshaban Fixed.

#420 <3

It's true -- why the need for PRs? Should just be able to edit at will. Then the likelihood increases of a sentient being emerging from the aimless "contributions" of thousands of insomniac neckbeards such as myself, which I'm sure is what we all want from this project.

Without PRs people it would be much harder to enforce the contribution rules

I agree what @ProgVal said.

So what's not hurting this project? :cry:

Don't worry guys I already fixed this one :)

I would respectfully request that a separate issue be opened for each PR listed above.

@KrisSiegel I can help you with the scrolling issue: http://theonion.github.io/fartscroll.js/

I'm glad this was brought to my attention.

PR #3001 and onward are fine. Guys keep pushing code! :shipit:

Why last numbers without links ?)

Because they are not created yet

@seyfer Nice :+1:

Stop asking us to fix your problems.


Send ip of the location playing from

Short Description
One of the most probable reasons for ban might be because the ip stays static while the location keeps changing.
Possible solution
Send a fake ip depending on the location
How it would help others
Avoid a perma ban

I see a --proxy argument in /src/pgoapi/pokecli.py but not in /pokecli.py
Could it be re-added to the current pokecli.py? Then use of a proxy could be possible :)

@ciol06 yes but will it send a new ip depending on location every few minutes or just a single proxy ip throughout?

a single ip, sure... but if you stay in the same location, no problem?

I don't think IP is a problem. ISPs NAT users all the time, and some people like me use always-on VPN on my phone.

#3574 for adding a proxy.
I think that is about as close as we will get to this. As long as you're not moving miles away, there wouldn't be much need to keep changing it.
https://www.quora.com/Does-my-mobile-phone-have-a-fixed-IP-address-or-does-it-change-frequently


add Geolocate control buttton

Summary
Added geolocate control button
Test Plan
Run in browser and use button to center map on current location
Related Issues
closes #78

Is there a way to position the button below the menu button?
I realize the geolocate button has its own "turn location off" functionality so you could remove that from dropdown.tsx


feat(package): re-structure package into extensible namespaces and folders

All namespaces have corresponding folders for sensible organizaton.
The root index.ts for reference:
/**
 * Core packages.
 */
import * as Core from './core';
import * as Shape from './shape';
import * as Util from './util';

export {
  Core,
  Shape,
  Util
};

/**
 * Export namespaces for each AWS service
 */
import * as ApiGateway from './api-gateway';
import * as DynamoDB from './dynamodb';
import * as Firehose from './firehose';
import * as Glue from './glue';
import * as Kinesis from './kinesis';
import * as Lambda from './lambda';
import * as S3 from './s3';
import * as SNS from './sns';
import * as SQS from './sqs';

export {
  ApiGateway,
  DynamoDB,
  Firehose,
  Glue,
  Kinesis,
  Lambda,
  S3,
  SNS,
  SQS,
};

/**
 * Supporting packages.
 */
import * as Analytics from './analytics';

export {
  Analytics,
};

It standardizes imports:
import { Core, SNS, Lambda, DynamoDB, Shape } from 'punchcard';

const { integer, string, struct, array, timestamp, } = Shape;

now it's even easier to concisely document punchcard ❤

This structure will scale so much better! It better reveals the patterns and conventions to follow for a service, and it's starting to feel like a standard library :)


Fix bad encoding when creating default PrintWriter

Fix #1320

Thanks for the PR!
Merged and documented in the release notes.


FGA chooses wrong skill targets occasionally

Preparation

[X] I tested the latest release
[X] I looked at other issues (even the closed ones)
[X] I read the Troubleshooting Guide

FGO server
JP
FGA build number
1892
Describe the bug
FGA starts to choose wrong skill targets from time to time. It can work without issues for a couple of runs, then it chooses a second servant as a skill target instead of first/third one. Everything else works ok.
Additional info:
I used FGA before on the same phone, but with MIUI(miui 12, android 10) installed. Had no problems. A couple of day before I flashed new ROM (lineageos 19.1, android 12) and immediately experienced this issue. Although the FGA version was different. So maybe new ROM has nothing to do with thus issue
Video
FGA still conflicts with video recording for me for some reason. It also happened on miui.

Device model
Xiaomi Mi Mix 3
Android version
12
Screen size
2340x1080
RAM
6

Duplicate of #1452 #1450

Duplicate of #1452

It's a bit different. I'll try to explain it better. FGA doesn't miss taps. It also choses correct skills in correct order. It instead makes wrong taps in servant selection window. It can work correctly for some time(although it's not guaranteed, sometime it brokes even in the first battle). But then it will start choosing the second servant(instead of first or third one) as a target of those skills. It just presses in the middle of the second servant's portrait in the selection window. (I "fixed" it by placing my dd in the second slot, it looks like it "works" now. But I haven't used it as much, not sure if it won't break in some other way)
I tried to put "t1" in the command line, like you proposed in 1452, but it doesn't work.
Unfortunately can't provide a video. I will try to capture it using PC through debug mode, but it wasn't compatible with working fga either. So I don't have a lot of expectations.


FINERACT-1761: Loan Product repayment due event values set by default…

… from global configurations
Description
As part of Loan Product enhancements in the create and edit actions some values are being used from the Global Configuration. In particular the Event (notifications) settings values, so those values must to be remarked to indicated the default value is set from the GLobal Configuration
FINERACT-1761

Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[ ] Create/update unit or integration tests for verifying the changes made.

[ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

[ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

TLDR... Not needed it more

TLDR... Not needed it more


Add TokenIssuancePolicy

This adds initial support for the TokenIssuancePolicy resource.
Represents the policy to specify the characteristics of SAML tokens issued by Azure AD. You can use token issuance policies to:

Set signing options
Set signing algorithm
Set SAML token version

I believe it will also be useful for adding resources to azure ad terraform in the future, as it will be used to configure the SAML signature algorithm, etc.
https://learn.microsoft.com/en-us/graph/api/resources/tokenissuancepolicy?view=graph-rest-1.0

The fail in this test does not appear to be related to any change in my code.
=== RUN   TestConnectedOrganizationClient
    connectedorganization_test.go:68: ConnectedOrganizationClient.Create(): ConnectedOrganizationClient.BaseClient.Post(): unexpected status 400 with OData error: ConnectedOrganizationAlreadyExists: The connected organziation already exists.
--- FAIL: TestConnectedOrganizationClient (0.45s)

@manicminer
I have responded to your change request.
Please review my code.

@manicminer How has the progress been coming along?


take list: do not collect array of pointers

This PR proposes a new constructor method on GrowableList. This constructor is generic over &[AsRef[ListArray<O>> and can be constructed with an array over ListArray.
This removes a redundant vector allocation in the take kernel, where a Vec<ListArray> was converted to a Vec<&dyn Array> so that it could be passed to the constructor.

I will go ahead and change all signatures in growable to make this consistent across and avoid the extra allocation altogether.

Proposal in #238

I am closing this one since it was generalized by #238. Thanks a lot for the proposal, @ritchie46 !


Fixes inconsistent combobox description

Fixes #2008
Fixes documented description of combobox filtering behaviour
Changelog
New

{{new thing}}

Changed

Combobox usage docs page

Removed

{{removed thing}}

@laurenmrice I added you as a reviewer here as you worked on this one!

@alisonjoseph would you mind looking at this PR? I'm not seeing the changes on the Files changed tab in the preview. Maybe something is amiss with the build? I'm not sure what to do and if the changes would go through correctly if I approved. Thank you!

Oh yeah that is true, I am seeing the same thing! Weird.

Weird, I'm not seeing the changes in the preview url either, just triggered a rebuild to see if that fixes it. 🤔

Weird, I'm not seeing the changes in the preview url either, just triggered a rebuild to see if that fixes it. 🤔

I still can't see the changes in the build. Any thoughts on what to do next, @alisonjoseph?

@janchild I'm guessing it's just a caching issue, the copy will be correct when it is deployed 👍


Clean up caching-precompiler

Perhaps the methods in CachingPrecompiler could be reordered? There's a fair amount of jumping back and forth now when trying to understand the entire file.
I'm not a fan of the Path suffix on the variable names. I'd prefer sticking to filename (since Babel uses it) and Dir for directories.

I like the smaller functions, makes the whole thing easier to understand.

PR updated.

@sindresorhus @jamestalmage @novemberborn :shipit:❓

LGTM

:shipit:


Admin > Settings > Shop > Basic information does not support localization

Description: In Admin > Settings > Shop > Basic information the UI suggests that the Basic information (Shop name, owner etc.) can be set for different languages (see 1 on provided screenshot). When changing the language the backend UI always prompts for unsaved changes (see 2 on provide screenshot). On save only the last set inputs for all languages get actually saved.
Environment: Plain devenv <IP_ADDRESS> & devenv <IP_ADDRESS> composer setups.
Steps to reproduce: Install Shopware 6 as described above in  "Environment". Go to Backend => Settings => Basic information and provide basic information values for "Deutsch" and "English" language
Expected result: Different basic information like shop name for the defined languages.
Actual result: Only the last values get saved are used for all languages.
[basic-information-issue.png|https://sbp-issuetracker-attachments.s3.eu-west-1.amazonaws.com/1694936192_6506ac80bc489_1694936133_6506ac458d455_basic-information-issue.png]

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-30527
[created from NEXT-30527, comment 514439]


Sphinx version number display

Automatically extract the version from the GPflowOpt package in Sphinx conf.py

Codecov Report

Merging #69 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   99.78%   99.78%   +<.01%
==========================================
  Files          16       16
  Lines         932      933       +1
==========================================
+ Hits          930      931       +1
  Misses          2        2

Impacted Files
Coverage Δ

GPflowOpt/__init__.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae62d6d...6cb192e. Read the comment docs.