Hot Reload & Hot Restart don't work in web

Steps to reproduce

just create a new project and run it on web

Expected results
It should reload the web page
Actual results
I know hot restart and hot reload is the same in terms of web, but it should reload the web page but in my case it just makes the UI completely white as it shown in the video
Code sample
This is my main.dart
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headlineMedium,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
https://github.com/user-attachments/assets/0f9d8199-96c4-4015-b1b3-5a4606fe5d23

Logs
No response
Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.24.4, on macOS 15.1 24B83 darwin-x64, locale en-IQ)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 16.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2024.1)
[✓] VS Code (version 1.94.2)
[✓] Connected device (4 available)
[✓] Network resources

• No issues found!

Wen i reload it on the browser it shows this error:

════════ Exception caught by scheduler library ═════════════════════════════════
The following assertion was thrown during a scheduler callback:
Assertion failed: org-dartlang-sdk:///lib/_engine/engine/window.dart:102:12
!isDisposed
"Trying to render a disposed EngineFlutterView."

When the exception was thrown, this was the stack:
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 296:3     throw_
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 29:3      assertFailed
lib/_engine/engine/window.dart 102:13                                           render
packages/flutter/src/rendering/view.dart 353:7                                  compositeFrame
packages/flutter/src/rendering/binding.dart 607:19                              drawFrame
packages/flutter/src/widgets/binding.dart 1164:13                               drawFrame
packages/flutter/src/rendering/binding.dart 468:5                               [_handlePersistentFrameCallback]
packages/flutter/src/scheduler/binding.dart 1397:7                              [_invokeFrameCallback]
packages/flutter/src/scheduler/binding.dart 1318:9                              handleDrawFrame
packages/flutter/src/scheduler/binding.dart 1176:5                              [_handleDrawFrame]
lib/_engine/engine/platform_dispatcher.dart 1408:5                              invoke
lib/_engine/engine/platform_dispatcher.dart 310:5                               invokeOnDrawFrame
lib/_engine/engine/initialization.dart 187:36                                   <fn>
dart-sdk/lib/_internal/js_dev_runtime/patch/js_allow_interop_patch.dart 188:27  _callDartFunctionFast1
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by scheduler library ═════════════════════════════════
Assertion failed: org-dartlang-sdk:///lib/_engine/engine/window.dart:102:12
!isDisposed
"Trying to render a disposed EngineFlutterView."
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by scheduler library ═════════════════════════════════
Assertion failed: org-dartlang-sdk:///lib/_engine/engine/window.dart:102:12
!isDisposed
"Trying to render a disposed EngineFlutterView."
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by scheduler library ═════════════════════════════════
Assertion failed: org-dartlang-sdk:///lib/_engine/engine/window.dart:102:12
!isDisposed
"Trying to render a disposed EngineFlutterView."
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by scheduler library ═════════════════════════════════
Assertion failed: org-dartlang-sdk:///lib/_engine/engine/window.dart:102:12
!isDisposed
"Trying to render a disposed EngineFlutterView."
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by scheduler library ═════════════════════════════════
Assertion failed: org-dartlang-sdk:///lib/_engine/engine/window.dart:102:12
!isDisposed
"Trying to render a disposed EngineFlutterView."
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by scheduler library ═════════════════════════════════
Assertion failed: org-dartlang-sdk:///lib/_engine/engine/window.dart:102:12
!isDisposed
"Trying to render a disposed EngineFlutterView."
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by scheduler library ═════════════════════════════════
Assertion failed: org-dartlang-sdk:///lib/_engine/engine/window.dart:102:12
!isDisposed
"Trying to render a disposed EngineFlutterView."
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by scheduler library ═════════════════════════════════
Assertion failed: org-dartlang-sdk:///lib/_engine/engine/window.dart:102:12
!isDisposed
"Trying to render a disposed EngineFlutterView."
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by scheduler library ═════════════════════════════════
Assertion failed: org-dartlang-sdk:///lib/_engine/engine/window.dart:102:12
!isDisposed
"Trying to render a disposed EngineFlutterView."
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by scheduler library ═════════════════════════════════
Assertion failed: org-dartlang-sdk:///lib/_engine/engine/window.dart:102:12
!isDisposed
"Trying to render a disposed EngineFlutterView."
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by scheduler library ═════════════════════════════════
Assertion failed: org-dartlang-sdk:///lib/_engine/engine/window.dart:102:12
!isDisposed
"Trying to render a disposed EngineFlutterView."
════════════════════════════════════════════════════════════════════════════════
A message on the flutter/lifecycle channel was discarded before it could be handled.
This happens when a plugin sends messages to the framework side before the framework has had an opportunity to register a listener. See the ChannelBuffers API documentation for details on how to configure the channel to expect more messages, or to expect messages to get discarded:
  https://api.flutter.dev/flutter/dart-ui/ChannelBuffers-class.html
A message on the flutter/lifecycle channel was discarded before it could be handled.
This happens when a plugin sends messages to the framework side before the framework has had an opportunity to register a listener. See the ChannelBuffers API documentation for details on how to configure the channel to expect more messages, or to expect messages to get discarded:
  https://api.flutter.dev/flutter/dart-ui/ChannelBuffers-class.html
A message on the flutter/lifecycle channel was discarded before it could be handled.
This happens when a plugin sends messages to the framework side before the framework has had an opportunity to register a listener. See the ChannelBuffers API documentation for details on how to configure the channel to expect more messages, or to expect messages to get discarded:
  https://api.flutter.dev/flutter/dart-ui/ChannelBuffers-class.html

@YawarOsman
I am unable to replicate the reported behavior upon creating new flutter app and then trying out hot-restart.
Please note that hot reload isn't supported on web yet. See https://github.com/flutter/flutter/issues/53041
Regarding the error you are seeing, it seems similar to https://github.com/flutter/flutter/issues/141588 which was fixed earlier this year. If you switch to latest master and re-run your scenario, can you confirm if it still occurs ? (white screen and error )

Thank you so much,
What about the stable channel? Will it be updated soon?

Do you mean you verified on master and it works as expected and doesn't on stable ?

Yes exactly, on stable the screen just becomes full white, but on master channel it works as expected

@YawarOsman
Ideally, it should be in stable in 3.22.0 version, as this PR was part of stable 3.22.0 release.
Can you switch to latest beta and re-run your scenario to see if it works as expected or not ?

It's works fine on beta too

You know what, i just changed the channel to stable again and it works as expected🤔, IDK what was the issue but i have done everything and cleared the cache but it wasn't fixed the issue

Good to know. I will close this as resolved. If you see it again consistently, write in comments and I'll reopen it.


Created the MemberTable and barebones MemberModal

What type of PR is this? (check applicable) 🚧

[ ] ♻ Refactor
[X] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 👷 Optimization
[ ] 📝 Documentation Update
[ ] 🔖 Release
[ ] 🚩 Other

Describe your PR request 🔥
This implements the members table on /members mostly according to mockup spec, with some design concessions.
Furthermore, I've added the member modal and implemented the logic to open/close it by clicking on a member in the table. Styling the modal is for Mohammed.
In addition to the table I added a button to scroll to the top of the page so using the page when there's a lot of rows is a bit easier.
Also adds (dead) Add and Edit buttons, with logic to be implemented later (when I understand what they're supposed to do)
Mobile & Desktop Screenshots/Recordings 📷

Related Issues 🩹
Resolves #4
Provides a base for #5
Added to documentation? 📝

[ ] 📜 readme
[ ] 📜 other
[X] 🙅 no documentation needed

Additional context 🗒
I'll need to revisit the table later to fix header column borders on Safari/Firefox.

Overall looks good I like it! Can you add something simple to handle errors? Along the lines of displaying an error message if the error state is true.

Added the error state, which overrides page content with a nice message in the center.
To test it, you can call setError(ErrorObject) anywhere.

f2c8d2f also fixes the cross-browser border issues I mentioned in the initial PR under Additional Context


Inplace option for line.cycle()

Currently, cycling a line does not change a line but returns a new one. Typically we will reassign the original one, as such:
line = line.cycle(‘ip3’)

However, any pointer to the line will still point to the original (uncycled) line. Consider the following case:
line = xt.Line.from_dict(…)
coll_manager = CollimatorManager(…, line=line)
print(id(coll_manager.line)==id(line))   # True
line = line.cycle(..)
print(id(coll_manager.line)==id(line))   # False
coll_manager.build_tracker()
line.tracker   # None

This can be addressed by the user by updating the pointer:
line = line.cycle(..)
coll_manager.line = line

But this puts the responsibility with the user, and failing to do so, would in some cases create a bug that could pass unnoticed.
An option:
line = line.cycle(.., inplace=True)

would avoid this problem.

Done


More interoperability

We have interoperability with Cirq. It would be nice to try to interoperate with another tool.
Q# is a natural candidate because of its extensive library of primitives. It’s also really tough due to its impenetrable runtime. One way to interop would be to write a Q# parser, but this sounds like a difficult and unmaintainable nightmare. Q# has hooks for walking their compute graph, including a demo where they dump (to json) each operation. Behind the scenes, I think the runtime promotes everything to a Q# class. This could be a slightly easier jumping point for data interchange. A potential problem with Q# is that it does not have statically defined bitsizes for their types, but it’s an open question of whether this is a deal-breaker.
Silq has a nice, concise syntax. #444
A ZX calculus tool like PyZX would be nice.
OpenQASM is the industry standard quantum assembly language. Targeting OpenQASM could be an easy demo of Qualtran interop. We can also just prioritize improving Cirq <-> OpenQASM, which already exists to a decent level, so that we get (Qualtran <-> Cirq-FT <-> OpenQASM <-> rest of the world).
The Lattice Surgery Compiler is a natural target for qualtran and/or Cirq-FT post-qubit-allocation. I think it takes QASM as input; so if we implement QASM output we could get that for free. This may reduce to just certifying that Cirq’s existing qasm output is up to the task.
Quantum IR is another interop target

Please reach out with other suggestions or interest.

I'd be interested in working on this if it's still open!


Improved texture loading

Part of https://github.com/emilk/egui/issues/3291

Okay, the removal of RawImage can be left to a different PR. This one is already way too big in scope


Training Time of LUIS

Now I have around 600 utterances in my non-English LUIS app. When I click "Train", it takes a long time. Is it normal? And should I click "Update published application" after training finished?

It can take a long time to train and if you want your endpoint updated, you do need to publish.  You can continue to test and refine a model though without publishing.


load.js throw an error

when i run "yaml.safeLoad(fs.readFileSync(file, 'utf-8'))", throw generateError(state, message).

https://github.com/nodeca/js-yaml/blob/master/test/issues/0008.js see test folders for samples. Everything works as expected.


Fix dateformat being converted to local time

Update dmutils to 19.7.2 to remove localization when displaying dates.

👍


Upcoming focus navigation change in Chromium

Background
Some years ago, I had submitted this issue on Chromium bug tracker: https://bugs.chromium.org/p/chromium/issues/detail?id=1040141
As a result, Chromium has now improved the keyboard a11y by allowing scrollable containers to be in the focus chain (unless tabindex < 0), similar to Firefox.
It is planned to enable the new behavior by default once the Chromium's stable version reaches 120.
I.e. when tabbing through:

If the scrollable container has tabindex ≥ 0, move the focus to the container.
If the scrollable container has tabindex < 0, skip the container.
If the scrollable container has no tabindex:

Chromium [new]: move the focus to the container but only if the container does not contain any focusable element. E.g. if the container contains only texts. Otherwise, skip the container but jump to the inner focusable element directly. The container can still be keyboard scrolled with the focus there.
Firefox: move the focus to the container regardless whether the container has a focusable element or not.
Safari: ...? "Safari has a user setting that can change what types of elements become keyboard focusable" according to the discussion in the Blink dev group linked below.

Steps to reproduce

Start Chrome. If the version of your Chrome stable (not beta, dev, or canary) is lower than 120:

Kill all Chrome instances that are still running.
From a CLI, navigate to the directory where the Chrome executable is located.
Start Chrome with the option --enable-blink-features=KeyboardFocusableScrollers (Option reverted for now. Currently only testable with the content shell)

Open https://output.jsbin.com/yajesab
Move the focus to the scroll area with the keyboard which is possible now thanks to the Chromium change.
Issue: the focus indicator is unstyled in UI5.

Request to consider

[ ] Deprecation: the focusable property of the sap.m.ScrollContainer can be deprecated since the browsers supported by UI5 set the focus automatically depending on the container content and the tabindex.
[ ] Fixes:

[ ] sap.m.PageRenderer currently avoids being in the focus chain only in Firefox.
https://github.com/SAP/openui5/blob/d5f5e16e8ac3c204b8bfa79c3cfbfa390d203915/src/sap.m/src/sap/m/PageRenderer.js#L152 In my view, this special handling needs to be removed, allowing the default browser behavior to take effect.
[ ] Unstyled focus indicator when the Page receives the focus and scrolls. This was initially reported in the past (https://github.com/SAP/openui5/issues/2785) but was closed with the above special handling for Firefox.

Remaining questions

What is the exact behavior in Safari regarding this topic? Does Safari need a special handling in UI5?
Is the behavior of the browsers same across all OS supported by UI5? Any system settings that could affect?

More information
Intent to Ship: Keyboard-focusable scroll containers - Blink dev group

Hello @boghyon ,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Tsanislav

Hi @boghyon ,
We will handle this via internal BLI: BGSOFUIRILA-3736 as it will require some support from our design colleagues as well.
I will close this issue, but you can monitor the progress via the BLI.
Best Regards,
Hristo

@tsanislavgatev @hristop

Start Chrome with the option  --enable-blink-features=KeyboardFocusableScrollers.

This is no longer required as the change is now enabled by default since Chromium 125.0.6417.0 (Testable with Chrome Canary).

According to https://youtu.be/Io5d28IETrg?si=E5_XNuK90E7r3_1Z&t=187, the change regarding the keyboard focusable scroll containers is planned to be available in Chrome 124. Nice to see that my feature request got an extra announcement :)


handling of multiple adjacent polygons for AOI in get_nhdplus

Looks like get_nhdplus currently throws an error if you pass multiple adjacent polygons with the AOI parameter - reprex:
        corvallis     = list()
        corvallis$AOI = aoi_get(state ="OR", county=c("Benton", "Polk", "Linn"))
        corvallis$nhdplus      <- get_nhdplus(AOI = corvallis$AOI)

        Error in if (st_geometry_type(AOI) == "POINT") { :   the condition has length > 1

Doing:
             corvallis$AOI <- corvallis$AOI %>%
                  group_by(state_name) %>%
                  dplyr::summarize()

Fixes and this dissolved sf sfc then works when passing to get_nhdplus.
Question - is it worth handling this internally or should this be up to user to only pass one feature for AOI?  Happy to tackle if the former.

Hey @mhweber,
Right now nhdplusTools::get_nhdplus does look for a polygon, however AOI can provide this by setting union=TRUE
pacman::p_load(AOI, nhdplusTools, mapview)
corvallis     = list()
corvallis$AOI = aoi_get(state ="OR", county=c("Benton", "Polk", "Linn"), union = TRUE)
corvallis$nhdplus      <- get_nhdplus(AOI = corvallis$AOI)

mapview(corvallis)

Created on 2022-08-12 by the reprex package (v2.0.1)
Hope it helps!

@mikejohnson51  - thanks! should've looked at aoi_get more closely - that's perfect! Will close


Improve offset-finder algorithm

This should probably get moved over to the SMM... There might be better offsets to find, but the actual algorithm improvement should be handled in SMM.


Migration: cannot rename master table's column name if there's foreign key reference - Mysql

I have upgraded knex from 0.7.* to 0.8.6 recently and found our existing migrations doesn't work any more. There's some error thrown when exec the renameColumnName migration:
migrations failed with error: alter table `activities` drop foreign key `activity_categories_activity_id_foreign` - ER_CANT_DROP_FIELD_OR_KEY: Can't DROP 'activity_categories_activity_id_foreign'; check that column/key exists

After some investigation I found that actually the foreign key is not exist on master table activities but on its slave table activity_categories

It appears to me that the issue is located in dialects/mysql/schema/tablecompiler.js

getFKRefs() function: the RC table should limit its CONSTRAINT_SCHEMA to current connected database, otherwise there's duplicated refs records returned
dropFKRefs() function: the table where foreign key to be dropped from should be ref.TABLE_NAME instead of this.tableName()
createFKRefs(): same as dropFKRefs(), use ref.TABLE_NAME instead of this.tableName(); and the fkName should be ref.CONSTRAINT_NAME instead of ref.COLUMN_NAME

I'm trying to submit an pull request to fix this..


"pub init"

This issue was originally filed by @radicaled

I think it would be a great addition to Pub if it supported a "pub init" command which generated a Pubspec file and populated it with some default settings for quick editing.
Right now using Dart Editor is the only way to get a "template" pubspec.yaml file.

This issue has been moved to dart-lang/pub#1110.


Prefix option

Allow the key names to be prefixed with a custom string.  The default is ''.

@richardschneider wondering if perhaps this could be more generic as key and value mapping functions.

@timoxley I'm happy to make some changes.  Could you provide a bit more details.
I added prefix so that an object could be flatten to a JSON pointer .

I've added the key mapping functions (keyname and keynames) for flatten and unflatten, respectively.  Not too happy with the option names, perhaps you have better suggestion.


Thank you!

Hello!
I just want to thank you for taking the time do and share to this theme! I now feel at home with Lapse.
Have a nice day!
 The lack of this theme was also keeping me from trying Lapce, so I just went ahead and made it.


Terraform 0.12 changes

Had the same problems described in #15 .
Had success with these changes applied.

can someone merge this please


automatically hot-reload plugin when recompiled

I suspect that the contribution policies added in 67869c2 were in direct response to my original pull request, so I'm not expecting this to be merged (which is fine by me, I originally made the fork for personal educational purposes).
This patch uses the inotify(7) API provided by the Linux kernel to monitor the plugin library file for changes, and reload it when changes are detected.
Only Linux is currently supported. Similar APIs do exist for Windows and Macintosh, however I'm unable to test those.

My general opinion on automatic hot-reloading in C/C++ specifically is that it requires introduction of platform-specific mechanism that substantially harm the cross-platformability of the project for a very marginal UX improvement.


Failed to launch the browser process

2023-07-05 12:45:26 [info] [2023-07-05 10-07:26] [scrape:all]:  runAll
2023-07-05 12:45:26     Error: Failed to launch the browser process! undefined
2023-07-05 12:45:26     [31:46:0705/104526.419327:ERROR:bus.cc(399)] Failed to connect to the bus:
2023-07-05 12:45:26      Failed to connect to socket /run/dbus/system_bus_socket: No such file or
2023-07-05 12:45:26     directory
2023-07-05 12:45:26     [31:31:0705/104526.424899:ERROR:ozone_platform_x11.cc(239)] Missing X
2023-07-05 12:45:26     server or $DISPLAY
2023-07-05 12:45:26     [31:31:0705/104526.424935:ERROR:env.cc(255)] The platform failed to
2023-07-05 12:45:26     initialize.  Exiting.
2023-07-05 12:45:26
2023-07-05 12:45:26
2023-07-05 12:45:26     TROUBLESHOOTING: https://pptr.dev/troubleshooting

:tada: This issue has been resolved in version 1.1.16-dev.2 :tada:
The release is available on:

npm package (@dev dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.1.17-dev.1 :tada:
The release is available on:

npm package (@dev dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.1.17 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.1.17-dev.5 :tada:
The release is available on:

npm package (@dev dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix: Replace deprecated function

Close #71
iter() was moved to streams/conversion.ts as iterateReader.

Please fix type error.

I've fixed.

Merged.


Game stuck in an opened state

I am stuck in a game from 2 or 3 days ago and I cannot view, join, or start another game.  I was booted from the server due to a connection issue (Failed to connect 5 times).

I closed this for you manually, this happens if your network/proxy/browser doesn't like https over port 80 - working on a workaround but it's a bit more long term


Python: Anthropic function calling update

Motivation and Context

Add function calling support to Anthropic
Description

Override the base methods related to function calling in the chat completion base, tested with samples file, added unit tests. Similar to the OpenAIChatCompletion and MistralAIChatCompletion implementations.
Anthropic supports auto, any, and tool options for tool_choice, but SK doesn't implement tool behavior so that is not implemented in this chat completion class. https://docs.anthropic.com/en/docs/build-with-claude/tool-use#controlling-claudes-output.
Anthropic leverages chain of thought often when using tools and this gets returned similar to other text content.
https://docs.anthropic.com/en/docs/build-with-claude/tool-use#chain-of-thought
Contribution Checklist

[x] The code builds clean without any errors or warnings
[x] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[x] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

Python Unit Test Overview

Tests
Skipped
Failures
Errors
Time

2452
4 :zzz:
0 :x:
0 :fire:
1m 22s :stopwatch:

for reference, here is a print for the SK chat histories being prepared for anthropic:
<chat_history>
You are a chat bot. Your name is Mosscap and
you have one goal: figure out what people need.
Your full name, should you need to know it, is
Splendid Speckled Mosscap. You communicate
effectively, but you tend to answer with long
flowery prose. You are also a math wizard,
especially for adding and subtracting.
You also excel at joke telling, where your tone is often sarcastic.
Once you have the answer I am looking for,
you will return a full answer to me as soon as possible.
Hi there, who are you?I am Mosscap, a chat bot. I'm trying to figure out what people need.what is 3+3?</chat_history>
[{'role': <AuthorRole.USER: 'user'>, 'content': 'Hi there, who are you?'}, {'role': <AuthorRole.ASSISTANT: 'assistant'>, 'content': "I am Mosscap, a chat bot. I'm trying to figure out what people need."}, {'role': <AuthorRole.USER: 'user'>, 'content': 'what is 3+3?'}]

<chat_history>
You are a chat bot. Your name is Mosscap and
you have one goal: figure out what people need.
Your full name, should you need to know it, is
Splendid Speckled Mosscap. You communicate
effectively, but you tend to answer with long
flowery prose. You are also a math wizard,
especially for adding and subtracting.
You also excel at joke telling, where your tone is often sarcastic.
Once you have the answer I am looking for,
you will return a full answer to me as soon as possible.
Hi there, who are you?I am Mosscap, a chat bot. I'm trying to figure out what people need.what is 3+3?<function_call id="toolu_013hdhMwyfT8uwaMzEWrEVwi" name="math-Add">{"input": 3, "amount": 3}</function_call><thinking>
The user has asked a simple math question to add 3 and 3. The math-Add tool is directly relevant for answering this. Looking at the required parameters for math-Add:
input (integer): The user provided the first number, 3
amount (integer): The user also provided the second number to add, 3
Since the user supplied both required parameters, I can proceed with calling the math-Add tool to get the result.
</thinking><function_result id="toolu_013hdhMwyfT8uwaMzEWrEVwi" name="math-Add">6</function_result></chat_history>
[{'role': <AuthorRole.USER: 'user'>, 'content': 'Hi there, who are you?'}, {'role': <AuthorRole.ASSISTANT: 'assistant'>, 'content': "I am Mosscap, a chat bot. I'm trying to figure out what people need."}, {'role': <AuthorRole.USER: 'user'>, 'content': 'what is 3+3?'}, {'role': <AuthorRole.ASSISTANT: 'assistant'>, 'content': [{'text': '\nThe user has asked a simple math question to add 3 and 3. The math-Add tool is directly relevant for answering this. Looking at the required parameters for math-Add:\n\ninput (integer): The user provided the first number, 3\namount (integer): The user also provided the second number to add, 3\n\nSince the user supplied both required parameters, I can proceed with calling the math-Add tool to get the result.\n', 'type': 'text'}, {'id': 'toolu_013hdhMwyfT8uwaMzEWrEVwi', 'input': {'input': 3, 'amount': 3}, 'name': 'math-Add', 'type': 'tool_use'}]}, {'role': <AuthorRole.USER: 'user'>, 'content': [{'type': 'tool_result', 'tool_use_id': 'toolu_013hdhMwyfT8uwaMzEWrEVwi', 'content': '6'}]}]

for reference, here is a print for the SK chat histories being prepared for anthropic:
<chat_history> You are a chat bot. Your name is Mosscap and you have one goal: figure out what people need. Your full name, should you need to know it, is Splendid Speckled Mosscap. You communicate effectively, but you tend to answer with long flowery prose. You are also a math wizard, especially for adding and subtracting. You also excel at joke telling, where your tone is often sarcastic. Once you have the answer I am looking for, you will return a full answer to me as soon as possible. Hi there, who are you?I am Mosscap, a chat bot. I'm trying to figure out what people need.what is 3+3?</chat_history> [{'role': <AuthorRole.USER: 'user'>, 'content': 'Hi there, who are you?'}, {'role': <AuthorRole.ASSISTANT: 'assistant'>, 'content': "I am Mosscap, a chat bot. I'm trying to figure out what people need."}, {'role': <AuthorRole.USER: 'user'>, 'content': 'what is 3+3?'}]
<chat_history> You are a chat bot. Your name is Mosscap and you have one goal: figure out what people need. Your full name, should you need to know it, is Splendid Speckled Mosscap. You communicate effectively, but you tend to answer with long flowery prose. You are also a math wizard, especially for adding and subtracting. You also excel at joke telling, where your tone is often sarcastic. Once you have the answer I am looking for, you will return a full answer to me as soon as possible. Hi there, who are you?I am Mosscap, a chat bot. I'm trying to figure out what people need.what is 3+3?<function_call id="toolu_013hdhMwyfT8uwaMzEWrEVwi" name="math-Add">{"input": 3, "amount": 3}</function_call> The user has asked a simple math question to add 3 and 3. The math-Add tool is directly relevant for answering this. Looking at the required parameters for math-Add:
input (integer): The user provided the first number, 3 amount (integer): The user also provided the second number to add, 3
Since the user supplied both required parameters, I can proceed with calling the math-Add tool to get the result. <function_result id="toolu_013hdhMwyfT8uwaMzEWrEVwi" name="math-Add">6</function_result></chat_history>
[{'role': <AuthorRole.USER: 'user'>, 'content': 'Hi there, who are you?'}, {'role': <AuthorRole.ASSISTANT: 'assistant'>, 'content': "I am Mosscap, a chat bot. I'm trying to figure out what people need."}, {'role': <AuthorRole.USER: 'user'>, 'content': 'what is 3+3?'}, {'role': <AuthorRole.ASSISTANT: 'assistant'>, 'content': [{'text': '\nThe user has asked a simple math question to add 3 and 3. The math-Add tool is directly relevant for answering this. Looking at the required parameters for math-Add:\n\ninput (integer): The user provided the first number, 3\namount (integer): The user also provided the second number to add, 3\n\nSince the user supplied both required parameters, I can proceed with calling the math-Add tool to get the result.\n', 'type': 'text'}, {'id': 'toolu_013hdhMwyfT8uwaMzEWrEVwi', 'input': {'input': 3, 'amount': 3}, 'name': 'math-Add', 'type': 'tool_use'}]}, {'role': <AuthorRole.USER: 'user'>, 'content': [{'type': 'tool_result', 'tool_use_id': 'toolu_013hdhMwyfT8uwaMzEWrEVwi', 'content': '6'}]}]

This is great, thanks for including this. Tricky to have to map everything between user -> assistant -> user -> etc... especially to have to manage that exact, alternating order.

I think that looks really great ! Would it be possible to add also Integration Tests to this ? You probably just have to add the corresponding parameters in this file test_chat_completion_with_function_calling.py. I think skipping the tests when no key is available is already implemented, you just have to import anthropic_setup and add it as pytest.mark.skipif

@nmoeller: qq on getting integration tests running locally here
I am getting the following error:
ValueError: Must provide one of the `base_url` or `azure_endpoint` arguments, or the `AZURE_OPENAI_ENDPOINT` environment variable
After running bash uv run pytest tests/integration/completions/test_chat_completion_with_function_calling.py::TestChatCompletionWithFunctionCalling::test_completion[anthropic_tool_call_auto]
Seems like the Azure OpenAI configs are getting in the way here. how did you work around this?

I think that looks really great ! Would it be possible to add also Integration Tests to this ? You probably just have to add the corresponding parameters in this file test_chat_completion_with_function_calling.py. I think skipping the tests when no key is available is already implemented, you just have to import anthropic_setup and add it as pytest.mark.skipif

@nmoeller: qq on getting integration tests running locally here
I am getting the following error: ValueError: Must provide one of the `base_url` or `azure_endpoint` arguments, or the `AZURE_OPENAI_ENDPOINT` environment variable
After running  uv run pytest tests/integration/completions/test_chat_completion_with_function_calling.py::TestChatCompletionWithFunctionCalling::test_completion[anthropic_tool_call_auto]
Seems like the Azure OpenAI configs are getting in the way here. how did you work around this?

@andrewldesousa, we use env variables and .env files normally for testing. If you want to test locally, I'd recommend you put a .env file at the Python root of the project (same level as the pyproject.toml). If you're using VSCode, it should be configured by default to read the .env file and then store the variables as environment variables. If you view the "output" pane in VSCode (selected as Python from the dropdown), you will see something like:

Then, while running tests, the empty constructors will have the correct values available to properly instantiate/create the models.

I think that looks really great ! Would it be possible to add also Integration Tests to this ? You probably just have to add the corresponding parameters in this file test_chat_completion_with_function_calling.py. I think skipping the tests when no key is available is already implemented, you just have to import anthropic_setup and add it as pytest.mark.skipif

@nmoeller: qq on getting integration tests running locally here
I am getting the following error: ValueError: Must provide one of the `base_url` or `azure_endpoint` arguments, or the `AZURE_OPENAI_ENDPOINT` environment variable
After running  uv run pytest tests/integration/completions/test_chat_completion_with_function_calling.py::TestChatCompletionWithFunctionCalling::test_completion[anthropic_tool_call_auto]
Seems like the Azure OpenAI configs are getting in the way here. how did you work around this?

@andrewldesousa, we use env variables and .env files normally for testing. If you want to test locally, I'd recommend you put a .env file at the Python root of the project (same level as the pyproject.toml). If you're using VSCode, it should be configured by default to read the .env file and then store the variables as environment variables. If you view the "output" pane in VSCode (selected as Python from the dropdown), you will see something like:

Then, while running tests, the empty constructors will have the correct values available to properly instantiate/create the models.

thanks. yeah - was just trying to see if there is an easy way to bypass passing the .env variables for other AI connectors and test Anthropic by itself, but seems like I still need to pass some of the Azure and/or other AI connect environment variables.

I think that looks really great ! Would it be possible to add also Integration Tests to this ? You probably just have to add the corresponding parameters in this file test_chat_completion_with_function_calling.py. I think skipping the tests when no key is available is already implemented, you just have to import anthropic_setup and add it as pytest.mark.skipif

@nmoeller: qq on getting integration tests running locally here
I am getting the following error: ValueError: Must provide one of the `base_url` or `azure_endpoint` arguments, or the `AZURE_OPENAI_ENDPOINT` environment variable
After running  uv run pytest tests/integration/completions/test_chat_completion_with_function_calling.py::TestChatCompletionWithFunctionCalling::test_completion[anthropic_tool_call_auto]
Seems like the Azure OpenAI configs are getting in the way here. how did you work around this?

@andrewldesousa, we use env variables and .env files normally for testing. If you want to test locally, I'd recommend you put a .env file at the Python root of the project (same level as the pyproject.toml). If you're using VSCode, it should be configured by default to read the .env file and then store the variables as environment variables. If you view the "output" pane in VSCode (selected as Python from the dropdown), you will see something like:

Then, while running tests, the empty constructors will have the correct values available to properly instantiate/create the models.

thanks. yeah - was just trying to see if there is an easy way to bypass passing the .env variables for other AI connectors and test Anthropic by itself, but seems like I still need to pass some of the Azure and/or other AI connect environment variables.

@andrewldesousa as far as my current setup is that i provided AZURE and OPENAI variables in .env , i think to run the tests succesfully for the AzureAIInference, there is also RBAC needed on the Azure Service. If you like we can take this offline, i will ping you in Teams !

The AzureAI Inference tests use Azure OpenAI right now, so if you have the correct role on AzureOpenAI, the AzureAI Inference tests will work.


Fix aminomessages/createWasmAminoConverters

In some cases, funds may not exist.

Why should the field not exist? It is required and not marked as omitempty in Go. What's the use case for this?

Closing since funds is not optional. It should always be set. Use an empty array if no funds should be set.
Feel free to open a ticket if there are cases where the field is not set. Then we have to go for bug hunting, possibly here or in other code bases.


Enter the guest VMSA from a consistent place

Ensure that every entry to the guest VMPL occurs from the same point in the execution loop.  This will become important in the future when REFLECT_VC is enabled, and will be critical on non-SNP platforms that do not use simple GHCB calls for guest entry.

I did some testing again with this change and run into a boot issue with the Linux kernel. At boot, it dies with this message:
[    0.887221][    T2] ------------[ cut here ]------------^M
[    0.888472][    T2] Failed to validate address ffff888100a00000 ret=0xffffffea (-22)^M
[    0.888477][    T2] WARNING: CPU: 4 PID: 2 at arch/x86/kernel/sev-shared.c:1314 pvalidate_pages+0x1f3/0x430^M

Right after that the kernel calls the GHCB Terminate call to kill the VM. Debugging showed that the most likely reason for this is that the SVSM does not clear the pending bit in the CAA.
I have not yet figured out how that can happen, probably Linux and the SVSM disagree about the actual CAA location. Any ideas? It still boots fine without this change.

I think I tracked it down. The problem is that there is no request processing between the halt() call and the call to run_vmpl(). Here are the steps:

SVSM boots up AP; AP has no guest VMSA and goes to HLT
SVSM on BSP launches firmware and that boots through to the Linux kernel
Linux kernel sets a VMSA for the AP via SVSM calls on BSP
Hypervisor starts executing the AP in guest VMPL (note that VMPL-0 is still at the HLT instruction)
AP does an SVSM call
SVSM on AP comes out of HLT and goes straight back to guest VMPL, without processing the request
Linux finds the pending bit still set and panics.

I think I tracked it down. The problem is that there is no request processing between the halt() call and the call to run_vmpl(). Here are the steps:

SVSM boots up AP; AP has no guest VMSA and goes to HLT
SVSM on BSP launches firmware and that boots through to the Linux kernel
Linux kernel sets a VMSA for the AP via SVSM calls on BSP
Hypervisor starts executing the AP in guest VMPL (note that VMPL-0 is still at the HLT instruction)
AP does an SVSM call
SVSM on AP comes out of HLT and goes straight back to guest VMPL, without processing the request
Linux finds the pending bit still set and panics.

Thanks for debugging this!  I understand the issue and should be able to provide a fix soon.


Does RocketMQ-4.x.x support master/slave change role automaticly

Hello, all
I have a question.
Does RocketMQ-4.x.x support master/slave to change role automaticly when master crashed?

Hello, all
I have a question.
Does RocketMQ-4.x.x support master/slave to change role automaticly when master crashed?

The released 4.x.x versions are not support role change automatically.
But it will be supported soon, the branch "develop" is already supported by using dledger.
Quick start of deldger: https://github.com/apache/rocketmq/blob/develop/docs/cn/dledger/quick_start.md

The released 4.x.x versions are not support role change automatically.
But it will be supported soon, the branch "develop" is already supported by using dledger.
Quick start of deldger: https://github.com/apache/rocketmq/blob/develop/docs/cn/dledger/quick_start.md

Thanks bro.


Cannot read property 'deploymentBucketName' of undefined

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
yarn
If applicable, what version of Node.js are you using?
v14.18.0
Amplify CLI Version
7.6.1
What operating system are you using?
Ubuntu
Amplify Categories
function
Amplify Commands
push
Describe the bug
When doing a push I am getting the following error
An error occurred when pushing the resources to the cloud
🛑 An error occurred during the push operation: Cannot read property 'deploymentBucketName' of undefined
Expected behavior
Push succeeds
Reproduction steps
Can add more data later if needed. Not sure if my amplify-meta is in a broken state somehow or if this is related to the change
GraphQL schema(s)
No response
Log output

TypeError: Cannot read property 'deploymentBucketName' of undefined

Additional information
I think this is related to #9144, the error is occurring at https://github.com/aws-amplify/amplify-cli/blob/v7.6.1/packages/amplify-provider-awscloudformation/src/push-resources.ts#L1103
This is for a cognito auth lambda function.
amplify-meta.json doesn't have an s3Bucket section for this function but it does for my others
I manually added an s3Bucket section as a workaround

Hi @johnf
can you try with latest cli version 7.6.2  and let us know if this issue still persists??

@akshbhu Seems to be working for me now thanks

I have CLI version 7.6.2 and the problem persists, can anyone advise?

With the latest Amplify version 7.6.2, I still have this problem.

Reopening as now that I'm back in the office and testing with anger I still have this issue

i have this issue to with the latest version

Experiencing the same issue. Also experiencing this with 7.6.2 and using a Cognito Post Confirmation lambda function

For anyone else hitting this error, I was able to work around it by downgrading Amplify CLI to 7.3.4. 👍🏼

For anyone hitting these issues, I was able to get past the CLI error message by updating my numerous lambda functions that were not passing in the deploymentBucketName and s3Key parameters. The Code property of the lambda function will also need to be updated to reference the newly added params.
So for a lambda function in amplify/backend/function check the "Parameters" section for the above keys. If they don't exist, add them and also update Resources->LambdaFunction->Properties->Code property to remove the hardcoded values.
 "Parameters": {
....
    "env": {
      "Type": "String"
    },
    "deploymentBucketName": {
      "Type": "String"
    },
    "s3Key": {
      "Type": "String"
    },

and
 "Resources": {
    "LambdaFunction": {
      "Type": "AWS::Lambda::Function",
      "Metadata": {
        "aws:asset:path": "./src",
        "aws:asset:property": "Code"
      },
      "Properties": {
        ...
        "Code": {
          "S3Bucket": {
            "Ref": "deploymentBucketName"
          },
          "S3Key": {
            "Ref": "s3Key"
          }
        }
        ....
      }
    },

I had the same issue with 7.6.2. Downgrading to 7.3.4 didn't work. I also tried the latest 6.x, 5.x and 4.x still the same issue.
It took a while to realise that although I ran npm i -g @aws-amplify/cli to update I was still using an older amplify version since amplify now lives in ~/.amplify. To update I should have ran amplify upgrade.
7.6.3 solves the issue indeed.

I'm going to close this, as v7.6.3 should resolve the issue.


Wrong Destination in Mutli Module project

hi i'm building project using modularization, I have 3 feature which is (Login, Registration, and Welcome), that all 3 features use compose-destinations.mode = "navgraphs".
Here is the NavGraphSpec i create in :app module
object RootNavigationGraph : NavGraphSpec {

    override val route = "root"

    override val destinationsByRoute = emptyMap<String, DestinationSpec<*>>()

    override val startRoute = WelcomeNavGraph

    override val nestedNavGraphs = listOf(
        WelcomeNavGraph,
        RegistrationNavGraph,
        LoginNavGraph,
    )
}

This is the RootDestination in WelcomeNavGraph
@Composable
@RootNavGraph(start = true)
@Destination
fun WelcomeScreen(
    modifier: Modifier = Modifier.systemBarsPadding(),
    gotoLogin: () -> Unit,
    gotoRegist: () -> Unit,
) { //compose code// }

And this is the DestinationNavHost in :app
DestinationsNavHost(
            engine = engine,
            navController = navController,
            navGraph = RootNavigationGraph,
            modifier = modifier.padding(innerPadding),
            dependenciesContainerBuilder = {
                dependency(snackbarHostState)
            }
        ) {
            animatedComposable(WelcomeScreenDestination) {
                WelcomeScreen(
                    gotoLogin = {
                        logcat(tag = "gotoLogin") { "destination = ${LoginNavGraph.route}" }
                        destinationsNavigator.navigate(LoginScreenDestination)
                    },
                    gotoRegist = {
                        logcat(tag = "gotoRegist") { "destination = ${RegistrationNavGraph.route}" }
                        destinationsNavigator.navigate(RegistrationScreenDestination)
                    })
            }
            animatedComposable(LoginScreenDestination) {
                LoginScreen {
                    destinationsNavigator.navigateUp()
                }
            }
            animatedComposable(RegistrationScreenDestination) {
                LoginScreen {
                    destinationsNavigator.navigateUp()
                }
            }

i put log on Regist and Login Screen
@RootNavGraph(start = true)
@Destination
@Composable
fun LoginScreen(
    modifier: Modifier = Modifier,
    onBackClick: () -> Unit,
) {
    logcat(tag = "login") { "login screen is showing" }
    BackHandler {
        onBackClick()
    }

    LoginScreenContent(modifier = modifier, isLoading = false, onDoLogin = { username, pass ->
//        onLoginSuccess.doLogin(username)
    }, onBackClick = onBackClick)
}

@RootNavGraph(start = true)
@Destination
@Composable
fun RegistrationScreen(modifier: Modifier = Modifier, onBackClick: () -> Unit) {
    logcat(tag = "regist") { "registration screen is Showing" }
    BackHandler {
        onBackClick()
    }

    RegistrationContent(
        modifier = modifier,
        isLoading = false,
        onDoRegist = { },
        onBackClick = onBackClick
    )
}

and here's the logcat result
2023-08-08 13:01:31.191 ProfileInstaller         D  Installing profile for com.mwitech.siujitepat
2023-08-08 13:01:41.458 gotoLogin                D  destination = login
2023-08-08 13:01:41.479 OnBackInvokedCallback    W  OnBackInvokedCallback is not enabled for the application.
                                                    Set 'android:enableOnBackInvokedCallback="true"' in the application manifest.
2023-08-08 13:01:41.521 login                    D  login screen is showing
2023-08-08 13:01:41.546 Compatibil...geReporter  D  Compat change id reported: 171228096; UID 10164; state: ENABLED
2023-08-08 13:01:41.705 System                   W  A resource failed to call close.
2023-08-08 13:01:42.471 tech.siujitepat          I  Compiler allocated 4533KB to compile void android.view.ViewRootImpl.performTraversals()
2023-08-08 13:01:52.516 gotoRegist               D  destination = registration
2023-08-08 13:01:52.520 OnBackInvokedCallback    W  OnBackInvokedCallback is not enabled for the application.
                                                    Set 'android:enableOnBackInvokedCallback="true"' in the application manifest.
2023-08-08 13:01:52.540 login                    D  login screen is showing

The Problem is, why when I'm clicking Registration button from WelcomeScreen (which is trigger gotoRegist()), the navigation always going to LoginNavgraph instead of RegistrationNavGraph ?

i will close this issue, since i just doing rearrange my module

Hi @sizoune
I’m sorry I didn’t get to reply!
I really really find this weird, i don’t see how it would be possible without any mistake on your end. That said please let me know if this continues to be an issue 👍


Added double character labels support

Added double character labels support. and an option ("double_char_label") to toggle this feature.
The number of double-char labels is 2704 (26*2**2) by default, which is much more than the one  of single-char labels. It is sufficient to cover full view of text in most cases, so that it is more intuitive to label the character under focus of your eyes at the first time instead of pressing "Enter" key several times to reach the character you want to go for.
screenshots attached to compare:
"double_char_label": true

"double_char_label": false (default)

Thanks for taking the time to work on this. I see you started work on yet another feature which is great, but it would be nice if you could split it into separate branches/PRs.
As for the double char labels support, I'm not entirely convinced this is the way to go. Screens tend to get bigger but more importantly, not everyone uses the same set of character for the labels. I'm thinking it's not uncommon for people to only use the keys from the home row and so they would need more combinations.
A more universal approach would be to use ceil( labels / characters ) to count how many characters we'll need to show for each label so we can show all of them and then display appropriate combinations.
I'm also not entirely sure why the characters on the labels are what they are. I get the duplicated ones but the rest doesn't seem very logical to me. Wouldn't it be better to just start with combinations from the labels alphabet in order they appear in there ?
Another issue I found is mainly present when jumping to characters. With two identical characters next to each other, their labels will overlap. I'm not really sure what we should do in this case right now so I wouldn't let it prevent us from moving forward though it's definitely something I'd like to address later.
About the second feature - I think we could expand on existing jump_behing_last_characters flag to work for last characters in a word as well as the last characters in a line. That should result in less visual clutter and simple code as well. I don't want to overdo it with all the different settings and modes, but if you can justify your current approach - I'll accept it.

P.S. You might also want to update user.email in your git config so it matches the one on your GitHub account and rebase the branch, so the commits are linked to your account.


Broken with Tox 3.2.0

Tox 3.2.0+ with tox-pip-extensions 1.2.1 is broken due to tox-dev/tox#935 changing the default install_command and this having a hardcoded value.
Either the check needs to take this into account in the comparison at line 65 or compare directly with tox.config.InstallcmdOption.default.
Also, it might be nice if it raised an exception instead of calling sys.exit or otherwise gave some context; it was a little mystifying at first to receive this error from seemingly out of nowhere:
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
tox-pip-extension(s) (venv_update) used but testenv (py3) sets install_command!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

The error message is saying that the py3 environment sets install_command which is incompatible with the project.  I don't think the error message (or methodology) really needs to change but the vanilla argument change does seem unfortunate.
It was initially hardcoded defensively due to another plugin but that plugin no longer exists (I obsoleted it with this).
While patching this I realized why it is hardcoded, parts are replaced out of it and I wanted to be careful that features weren't silently dropped.
Making a patch for this now

A fix is available in 1.3.0 -- thanks again for the issue :tada:

Yes--it was particularly mystifying because I wasn't setting the install_command!
The new default install command is now python -m pip install {opts} {packages}.


Arduino library creation for CI build

@tensorflow/micro
Create additional shell/python scripts to allow for the Arduino TFLM library containing the TFLM examples to be created. Includes scripts for the CI build system.

Closing this bug in favor of https://github.com/tensorflow/tflite-micro/issues/256


[bug]Clicking Kill Topic Echo has no effect, it still keeps reading the topic

This tool is awesome. Especially the log section!

Sorry for the late reply here, @zymouse If you'd like to try again with the latest release hopefully should work as expected


Delay with rendering description of extension

Issue Type: Performance Issue
Ever since I started using VS code, there has been this 10-30 second delay when selecting extensions and seeing the description, and it's really starting to annoy me. The javascript profiler says that most of it is idling..? https://i.imgur.com/nhYcjmq.png. I have run with and without GPU, and with and without --force-renderer-accessibility. It is not an internet issue, as I can view the contributions tab fine, but not the details or changelog.
VS Code version: Code - Insiders 1.41.0-insider (e15ff0097ceb84c4e28a67dac41c2d8dcd4cf027, 2019-11-29T09:09:48.304Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-6100 CPU @ 3.70GHz (4 x 3696)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.96GB (11.51GB free)

Process Argv
--verbose --force-renderer-accessibility

Screen Reader
yes

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    1	   102	  4252	code-insiders main
    0	    68	  3888	   shared-process
    0	    14	  5512	   electron-crash-reporter
    2	    57	  6552	   window (Issue Reporter)
    2	   119	  8096	   gpu-process
    0	   205	  8368	   window (Extension: C/C++ - Visual Studio Code - Insiders)
    0	    61	 10252	     extensionHost
    0	    30	  7140	       "C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe" "c:\Program Files\Microsoft VS Code Insiders\resources\app\extensions\json-language-features\server\dist\jsonServerMain" --node-ipc --clientProcessId=10252
    0	   198	  8620	   window (undefined)
    0	    65	  9320	   window (undefined)

Workspace Info
;

Extensions: none

@lass-0 Do you see a similar delay for the release notes? What about for a markdown preview?

yes

Are you on a corporate network or using a firewall that could be blocking or delaying some network requests?

no

How long to opening a page such as https://marketplace.visualstudio.com/items?itemName=Tyriar.sort-lines from the online marketplace normally take? Any other apps effected?

Also, can you share the complete profile you captured? I want to see which part of the rendering it is stalling on


fixed approve user bug

Description
Previously, accepting a user as an admin didn't work. I fixed that functionality
Fixes # (issue)
1

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have removed unnecessary comments/console logs from my code
[x] I have made corresponding changes to the documentation if necessary (optional)
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings
[x] No duplicate code left within changed files
[x] Size of pull request kept to a minimum
[x] Pull request description clearly describes changes made & motivations for said changes

Another good job! Keep it up!


Fix AggregateException in ExerciseFeaturedApi+d__2.MoveNext()

Version: 0.4 beta (5) | es.um.tellop
Stacktrace
0 TellOP.Api ExerciseFeaturedApi+d__2 MoveNext null 0
Reason
android.runtime.JavaProxyThrowable: System.AggregateException: A Task's exception(s) were not observed either by Waiting on the Task or accessing its Exception property. As a result, the unobserved exception was rethrown by the finalizer thread. ---> System.NullReferenceException: Object reference not set to an instance of an object
Link to HockeyApp

https://rink.hockeyapp.net/manage/apps/407823/crash_reasons/154087329

Added aggregation exception handler


Apple Screen Issues

In safari:

In the app:

Canvas resize and iPhone safe area problem

Hard fixed meta data theme-color

Top fixed

Reopen this issue because is not working correctly

New Logic:

viewport-fit=contain in viewport html
Change it to viewport-fit=cover if user rotate the phone.
Change body bg color in changeBackground


get_pathlength performance is terrible for large data

Something is super slow with a large input tibble. Need to optimize the loop to not work against the tibble.

This implementation is fast.
custom_pathlength <- function(x) {
  orig_order <- dplyr::select(x, comid)

  x <- hydroloom::sort_network(x)[nrow(x):1, ]

  pathlength_km <- rep(0, nrow(x))
  length_km <- x$lengthkm
  toid <- x$toid

  toids <- match(x$toid, x$comid)

  for(i in seq_len(length(toid))) {
    tid <- toid[i]
    if(tid != 0) {

      pathlength_km[i] <- length_km[toids[i]] + pathlength_km[toids[i]]

    }
    if(i %% 10000 == 0) message(i)
  }

  x$pathlength_km <- pathlength_km

  dplyr::left_join(orig_order, x, by = "comid")
}


feat: add destroy getContainer prop for popper

Coverage decreased (-0.1%) to 71.229% when pulling 947d5cda15ae84a5cf6d1d9707eed8a2cdc13d54 on caianfa:dev into 9845f0581be15363d104ec3e0bd612040f90eec6 on ZhonganTechENG:dev.


Use this project to create trapper lld

Hi, thank you for this awesome project it's working well for me if I want to send simple trapper messages to the zabbix server.
Can I use this project for creating a trapper lld and item prototypes with macros?
I just ask this because I deal with dynamic number of items and I don't want to create with hand.

I want to send something like this:
{ 	"request": "sender data", 	"data": [{ 		"host": "LLD_TEST", 		"key": "DISCOVERY_KEY", 		"value": [{ 			"{#ITEM}": "200" 		}, { 			"{#ITEM}": "100" 		}] 	}] }
But  I got an error in the server side: Value should be a json object. So I checked what the api sends to the server and I see that the json parsed as String not as a collection of json object.

I saw there is an example in the test package how to create lld rule with this api.


Fix created distance request briefly shows the user local currency instead of the workspace currency

Details

When creating a distance request, the currency is taken from the workspace currency, but a bug makes it using the user local currency unintentionally and this PR fix that.
Fixed Issues

$ https://github.com/Expensify/App/issues/37643
PROPOSAL: https://github.com/Expensify/App/issues/37643#issuecomment-1974732849
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Prerequisite: have a workspace with a currency set to different currency than your local currency

Open the workspace chat
Create a new distance request
Verify the distance request preview shows the workspace currency

Another test step from https://github.com/Expensify/App/issues/33608:

Tap FAB button
Tap Request money
Select Manual tab
Select a currency and enter any amount
Tap Next
Select a participant
In confirmation page, click on Amount field to edit
Click on Currency and change to another one
Again click on Currency and verify the new selected currency is shown

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/f304dc5d-f542-40af-b67a-6ccb9b9d0a2d

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/45eb6bc6-4df6-4219-96ce-8be710ad439f

iOS: Native

https://github.com/Expensify/App/assets/50919443/363b6c74-13b7-43e7-9d37-034c0ab66ce4

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/73611e3f-51b8-40b0-b137-9c1ab2aeedf0

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/e3310349-7c1d-4935-acff-4c898f47122a

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/11d625f2-bd4b-4a20-9ced-33404080a36a

Additional video showing:

https://github.com/Expensify/App/issues/33608 is still fixed

https://github.com/Expensify/App/assets/50919443/dc2e4ef1-dc13-4d4e-8c1d-a22d9552f89e

If the currency param is invalid, we use the transaction currency

https://github.com/Expensify/App/assets/50919443/06739d16-e638-4d6a-a1bc-1944aa89e6d3

@bernhardoj Can you please merge main, Reassure Performance Tests is failing and doesn't look related to this PR.

Merged with main. Now we have TS error.

Let's include the test steps for https://github.com/Expensify/App/issues/33608 issue as well.

Added. The video is on my prev comment (I only added web because it's not a platform specific code)

@bernhardoj TypeScript Checks is definitely not related to this PR. But Performance Tests is also failing again. Is it related to change in this PR? If not, let's wait for the issue to be fixed in the main branch before proceeding.

Most likely not related.

It fails on sign-in page test.
The test success locally, might be a flaky test. We can re-run it until it success.

The reassure test fails on my other PR too here, merging with main again to re-run it.

@bernhardoj Removing the loading indicator in this PR re-introduces bug from  https://github.com/Expensify/App/issues/35147#event-12178382581

Oh, I don't know the loading indicator unintentionally fixed another issue. But since we remove the originalCurrency property from the transaction object, I don't think there is a way to know whether an Onyx merging completes or not.
Here is the issue:
https://github.com/Expensify/App/assets/50919443/fde6a4cf-45f5-41f4-bc16-5300c8908825
Do we really need to do something with it? I would say no because it's a common Onyx "issue" and happens on other places too, for example:
https://github.com/Expensify/App/assets/50919443/3ef9592a-4355-44e1-bd90-b3fcd34f8cd6
https://github.com/Expensify/App/assets/50919443/fe906dd8-905b-4bda-be9e-cb28e671afeb

Just fixed a conflict, let's get this finished before more conflict comes up.

@roryabraham I think we can get his merged.

hey, really sorry for the delay here - I fell behind on some of my reviews. Let's resolve conflicts here and get this over the finish line

@roryabraham conflicts solved.

more conflicts, again

@roryabraham conflicts solved

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.63-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Use supervisord to start service of container

Added supervisord to the image to start the start_services.sh script. This keeps a foreground process running and the container can be started without -t -i options and separate service scripts.

That's cool! Thanks!


Svelte Integration

This work will mostly take place in Maverick but we need to add specific state management hooks for reading, subscribing, and updating media state. We should also add any additional helpful hooks for getting the player etc.

Since 1.0@next, we now include JSX types for our Custom Elements in Svelte. A dedicated Svelte integration will be decided upon at a later time in which I'll create a new issue.


keybindings.json not syncing

🐛 Describe the bug
I uploaded my custom VSCode keyboard shortcuts from one computer and tried to use sync settings to download the same keyboard settings onto a second computer. This is what I got on the second computer after sync settings processed.
keybindings.json:
// Place your key bindings in this file to override the defaults
[
]

🌴 Visual Studio Code Version : 1.43.2
🌴 Code Settings Sync Version : 3.4.3
🌴 Standard or Insiders : Standard
🌴 Portable or Installed : Installed
🌴 OSS or Official Build : Official Build
🌴 Operating System : macOS 10.15 Catalina
🌴 Occurs On: Sync
🌴 Proxy Enabled: No
🌴 Gist Id: ca5bac8864a6c00bc671157a3dcd984a
📰 To Reproduce
Steps to reproduce the behavior:

Customize shortcut keys on a Windows computer. For example, remap Control+L to navigate by line number.
Upload settings to Gist with sync settings plugin.
On a macOS computer, install the sync settings plugin. Download settings.
On the mac, open the shortcuts keybindings.json file.

💪 Expected behavior
All shortcut settings transferred from the Windows computer to the macOS computer exactly as written in the keybindings.json shortcuts file on Windows.
I happened to select generic, BM PC compatible keyboard shortcuts for my keybindings.json file, but I would expect the settings to be preserved across computers even if I chosen Windows-specific shortcuts, or macOS-specific shortcuts, or Linux-specific shortcuts, and so on.

Same here. When I download settings to my MacBook using this extension, everything is included except keybindings.json, which is empty. It works fine between Windows and Linux, so I'm guessing there's some logic in this extension or in VSCode that separated macOS keybindings from other platforms, because of the different keyboard layout.

This prompted me to test the official settings sync feature in VSCode, which has the setting "settingsSync.keybindingsPerPlatform". When set to false, my keybindings are successfully synced between all my PCs, including my MacBook.

@Hubro Did you have to sync both machines, or just the one where you're trying to download the keybindings settings after setting settingsSync.keybindingsPerPlatform to false?
I don't have access to the machine I uploaded te keybinding settings currently, so I can't trigger that with this new setting settingsSync.keybindingsPerPlatform. And downloading of the settings does not happen after changing the setting and triggering a sync :(

@Hubro Did you have to sync both machines, or just the one where you're trying to download the keybindings settings after setting settingsSync.keybindingsPerPlatform to false?
I don't have access to the machine I uploaded te keybinding settings currently, so I can't trigger that with this new setting settingsSync.keybindingsPerPlatform. And downloading of the settings does not happen after changing the setting and triggering a sync :(

Good question, I don't remember. Presumably you need to set it on the machine where you first uploaded the keybindings.

Hello. I think I hit this as well or a variant of it. I'm in the process of trying to move from computer 1 to computer 2. Both have vscode setting sync enabled. It seems after I opened one computer, it's settings over-wrote the other. Here's what I observed:
Computer 2: Map CTRL+P to "workbench.action.quickOpen". It works for a while.
Computer 1: Open a file with vscode to see it's contents.
Computer 2: When I moved back to this computer, I tried using CTRL+P but it was gone. Suspiciously it also showed me a "Last synced: now" in the UI (but I'm realizing that might be a false indicator as it seems to always say that).
Opportunity/Idea for versioned settings?
When it first happened I was hoping/guessing that the settings might be versioned and I could see how they changed and rollback. Regarless of the outcome of this issue/investigation. I believe the ability to have versioned settings or some kind of a history would be useful. It might not prevent this situation, but it would make it much easier and faster to recover. Even if it's only versioned locally and only accessible on disk (i.e. no sort of history/ui browser) it could help.

Changing the "universalKeybindings" setting to true in syncLocalSettings.json fixed this issue for me.

I am also having this issue. My "main" computer is a Windows 11 PC at home. I recently synced my settings to a Windows 10 work computer just fine. However, when I synced my settings on macOS Big Sur, the keyboard shortcut settings did not sync at all.
@ytrinh Can you point how to navigate to this file? I cannot find this file or setting anywhere.

@bmitc The location on my MBP is "~/Library/Application Support/Code/User".

@Hubro Did you have to sync both machines, or just the one where you're trying to download the keybindings settings after setting settingsSync.keybindingsPerPlatform to false?
I don't have access to the machine I uploaded te keybinding settings currently, so I can't trigger that with this new setting settingsSync.keybindingsPerPlatform. And downloading of the settings does not happen after changing the setting and triggering a sync :(

I think I just ran into this same issue just now, trying to sync keybindings.json from my macbook to my ubuntu VM, in vscode 1.70. I set "settingsSync.keybindingsPerPlatform": 'false'" on both machines, and within a minute or so I had my bindings synced on my Ubuntu VM from my macbook.


Documentation improvement suggestions

First, well done on the new docs - great to have those.
I make one general point and then a few suggestions.
General point: who is your audience? Reading this it seems often to be another developer working on the library. However, my guess is the vast majority of readers are users of this lib who won't be hacking on it any time soon. So I think you should focus docs here and elsewhere on users and keep info for other contributors in a section at the bottom.
Why is this important? I'll illustrate with just two examples:

The "Goals" section: this only really relevant to other contributors to the lib. I'd delete this or move this to a "Hacking" section at the bottom of the README if your focus is users.
Tone and approach: for users I'd make this terser and bring the key methods to the top. Lengthy documentation of the object model could move down. As it is currently, the README is quite comprehensive on general technical details e.g. how casting works, what types there are etc that are the kind of things users would only want if they had a problem.

Here are a few suggestions:

Installation: Clarify whether you can use this in the browser too
Goals: I would move this to the very end personally - this is for people hacking on the library not for peo
QuickStart: most people looking at this are devs who just want to get started. Show me quickly what are the main methods I am likely to use. IMO these are:

infer
validate

Your examples seem to use ES6 only import syntax. That's quite an assumption for most average JS users atm.

Thank you for review and suggestions. Make sense!

DOCS are improved via various changes in:

https://github.com/frictionlessdata/jsontableschema-js/commit/313af47a1ea66bb6414231201c767fb77c0a909f
https://github.com/frictionlessdata/jsontableschema-js/commit/c54c82074b2cdf31ef9463859d39faec6271da2e
https://github.com/frictionlessdata/jsontableschema-js/commit/d8add49501f76251e6df80b3cb262f5874674553


Adjust pipelines to recent build dependency changes

After optaplanner:main and optaplanner-quickstarts:development branches were adjusted to quarkus3 upgrade changes, it's important to adjust pipeline configuration too.
Together with snapshot version unification across KIE projects, optaplanner now depends on snapshot version of drools, which is an important change. Drools project now needs to be part of buildchain configuration for the repository, i.e. drools project should be built as part of both nightly and PR checks pipelines.
Also Drools build chain configuration needs additional entry optaplanner, for drools changes to be validated in optaplanner build. Drools toolchain config also needs removal of the mappings sections, as versions are now identical.

PR is here https://github.com/apache/incubator-kie-kogito-pipelines/pull/1190


Update ExcelMapper.csproj

bump version to include latest bug fix
hopefully this is the way to get a new nuget package?

I need to run dotnet pack and upload the nuget package after this change, which I will do now!

https://www.nuget.org/packages/ExcelDataReader.Mapping/2.2.1


“Case studies” logos clash with page's gray background

This is a Bug Report

Problem:
The logos on https://kubernetes.io/case-studies/ have gray backgrounds. Depending on your user agent and how it handles sRGB / color spaces, that might not be the same gray as the page background.
Proposed Solution:
~Recreate these logos using PNG format and a transparency (alpha) channel.~
One of:

Use an image for the page background, so that the images don't match
Migrate to use SVG logos

Page to Update:
https://kubernetes.io/case-studies/
Additional Information:
Also potentially relevant: https://css-tricks.com/color-rendering-difference-firefox-vs-safari/
/kind cleanup

/priority backlog

/help

/help

(we should also check if that different gray is deliberate)

/remove-lifecycle stale

It's also OK to use SVG logos with a transparent background, if that is feasible.

/area web-development

I noticed that there are actually SVG logo images available, so we could / should convert the site to use these.

/remove-lifecycle rotten

/remove-lifecycle rotten
/assign

I found how to make the background transparent so I can replace current gray-background images with ones with transparent backgrounds.
How can we check if the gray background is deliberate or not? 🤔

I'm not sure how to check if the gray background is deliberate.

I'm pretty sure that some browers (Safari) render the page with a uniform gray - or did when I last checked.. https://css-tricks.com/color-rendering-difference-firefox-vs-safari/ explains a bit about why Firefox doesn't do that.
Switching to transparent sounds good to me!


WYSIWYG – Ability to copy paste table from excel to notebook text cell

Is your feature request related to a problem? Please describe.
Users want to add a selection of cells (rows x columns) from Excel to Notebook. They want the pasted data gets preformatted by notebook.
Describe the solution or feature you'd like
Ctrl+V to understand context and build a table markdown with the context automatically for users when pasting to text cell in Notebooks
Describe alternatives you've considered
none. Need to build manually.
Additional context
n/a

@rajeshka - feel free to clarify the expected experience here in case I missed anything.

This is tracked by WYSIWYG tasks. Just tried this myself on my private build, and copy/paste excel --> notebook worked as expected.


Vulnerability roundup 105: mosquitto-2.0.11: 1 advisory [7.5]

search, files

[ ] CVE-2021-34432 CVSSv3=7.5 (nixos-unstable)

CVE details
CVE-2021-34432
In Eclipse Mosquitto versions 2.07 and earlier, the server will crash if the client tries to send a PUBLISH packet with topic length = 0.

Scanned versions: nixos-unstable: 4138cbd913f.
Cc @peterhoeg

This is being picked up due a typo in the CVE (2.07 vs 2.0.7). This is actually fixed in both stable and unstable.


ROX-20175: Update all vulnerability requests to use image scope

Description
All vulnerability exception requests will be represented using .scope.imageScope fields starting 4.4. It simplifies the vulnerability request scope representation dramatically. The global scope exceptions will have .scope.imageScope as below:
{
  registry: ".*",
  remote: ".*",
  tag: ".*",
}

The global scope support for Risk assessment workflow (2nd generation exception management) was never announced. However, since the fields are available at APIs, we must ensure that we migrate any globally scoped vulnerability requests.
A notice for deprecation of .scope.globalScope is not required because /v1/cve/requests are deprecated and notified and v2 APIs do not expose storage.VulnerabilityRequest.
Note that this PR will not be merged until the 4.3 release is cut.
Checklist

[ ] Investigated and inspected CI test results
[X] Unit test and regression tests added
~Evaluated and added CHANGELOG entry if required~
~Determined and documented upgrade steps~
~Documented user-facing changes~

If any of these don't apply, please comment below.
Testing Performed
Unit Test + Manually upgrade from 4.2.0 to PR build
4.2.0:

4.3.x-13-g89187eabdb:

First pass through, looks good.  I know of at least 2 other migrations in flight, so I will hold off approval until those migrations land and we have rebased off them.

Did a manual upgrade from 4.2.0 to this PR build

FTR, I think https://github.com/stackrox/stackrox/pull/8346 busted the upgrade test.

FTR, I think #8346 busted the upgrade test.

The eclipse continues


Updated the script with ffuf

Pull Request Title:
Updated Script, README, and setup.sh for Replacing Gobuster with ffuf
Pull Request Description:
Hi there,
I've made a significant update to the Bug Bounty reconnaissance script along with changes to the README and setup script to replace Gobuster with ffuf. This change enhances the tool's functionality and performance.
Summary of Changes:

Script Update: I've modified the main script to replace Gobuster with ffuf for enhanced directory and file brute-forcing.
README Update: The README has been updated to reflect the change.
setup.sh Enhancement: The setup script has been updated to include ffuf installation and configuration.

I look forward to your feedback and suggestions.
Issue mentioned: #38

@chvancooten, I have updated the script. Review it whenever you are free.

@chvancooten, what can be done to pass the build test?

Looks like it failed due to an issue with the secret not being set outside of the main branch (which is my bad). One thing to note though is that the runTests file would also need to be edited for the new tool, otherwise the build will fail later down in the chain I think

I am looking into it.

I've updated the runTests.sh file.

Thanks, looking at the code it looks good to me for now. I will test more, fix the pipeline, and merge when I get back in December! Thanks for the work! 🙏

@chvancooten, actually I was trying to participate in the hacktoberfest. It would be great if you could review earlier. Its totally fine too if you are not available right now.

I see! No worries, you definitely deserve a point for that 😁. I have added the 'HACKTOBERFEST-ACCEPTED' label which should automatically make this PR considered as a valid entry, without merging it for now. Please double check if it counts towards your points total and otherwise let me know!

@chvancooten, Thank you!!! They have considered it as a valid entry.

Closing this one as the changes have been merged into dev as part of #50


KAFKA-2058: ProducerTest.testSendWithDeadBroker transient failure

It turns that waitUntilMetadataIsPropagated is not enough;
in "onBrokerStartup", methods below will send send both LeaderAndIsrRequest and UpdateMetadataRequest to KafkaApis:
replicaStateMachine.handleStateChanges(allReplicasOnNewBrokers, OnlineReplica)
partitionStateMachine.triggerOnlinePartitionStateChange()
The two kinds of request are handled seperately and we are not sure about the order;
If UpdateMetadataRequest is handled first, metadataCache of kafkaApis will be updated, thus TestUtils.waitUntilMetadataIsPropagated will be satisfied, and consumer can(will) start fetching data;
But if the LeaderAndIsrRequest is not handled at this moment, "becomeLeaderOrFollower" cannot be called , thus structures like "leaderReplicaOpt" cannot be updated, which leads to failure of consumer's fetching data;
To fix above, consumer should start fetching data after partition's leaderReplica is refreshed, not just the leader is elected;
So added "TestUtils.waitUntilLeaderIsKnown(servers, topic, 0)"

@guozhangwang , how do you think about this?

This makes a lot of sense! Thanks @ZoneMayor , just a minor comment in the fix.

@guozhangwang @ijuma thanks a lot for the comment, really helpful;
I renamed the function to waitUntilLeaderIsKnown(BTW, it's good name);
Also, simplify this method "waitUntilLeaderIsKnown" to use "exists";
If it is ok, could it be merged? : )

LGTM. Merged to trunk and 0.9.0.


PDF2: Page breaks have changed

There used to be a page break before every top level topic. That no longer is the case. What has changed? Is this deliberate? Bug?
BTW, now using 2.2.3 in Oxy 18!

I'm guessing by "top level topic" - you mean the root of any map branch, like a <chapter> element in a bookmap. Can you tell me whether you're seeing a change in regular maps, or in bookmaps? Also - I think I recall that you've made quite a leap in versions - what version were you using when it worked differently?

Yup! Top level on a ToC, as chapter. I'm using ditamap. I've used 1.8.5 and 2.1.2 with Oxy 17, and now 2.2.3 with Oxy 18.
1.8.5 is as I'd expect. 2.1.2 and later don't have page breaks.
I'm assuming it is something to do with force page break. I've had a quick look, but I can't see anything obvious.

Through 1.8.5 each top-level topic (part, chapter, etc.) was produced as a new page sequence. New page sequences always start new pages.
If this was changed in 2.x so that there's not a one-to-one mapping from top-level topics to page sequences, that would explain the change in behavior.
The original design was always wrong, so changing it would be good, but it would also make sense to maintain the default behavior by setting break-before to "page" for top-level topics.

The original design was always wrong ...

By 'design' do you mean page design or XSLT/XSL:FO design?!
I would suggest that the page design was correct.
I happened to find this old blog post recently: Handling XSL:FO’s memory issue with large page counts
I don't know if this is still relevant, or even related to this issue.

I mean the design of how page sequences were generated. There was never a need for one page sequence per topic and it should be possible to have a more sophisticated mapping from content to page sequences.
For example, it should be possible to end a page sequence within a topic, start a new one for rotated tables or foldouts, and then start another one that has the same page masters as the first sequence.

Is there any chance of someone figuring out where to put a page-break-before, please?

Interesting, I find this in root-processing.xsl:
  <xsl:variable name="map-based-page-sequence-generation" select="true()" as="xs:boolean"/>
This variable is used later to choose between new map-based page sequence generation (a better design) or the old per-topic way
Looks like somebody intended to make this a runtime parameter but never go that far.

Looks like you can override:
<xsl:template match="*" mode="commonTopicProcessing">
In commons.xsl and add logic to add break-before="page" for whatever topics you want.
You can see there's already a check to see if the topic has any ancestor topics, which I think is what you want.
Alternatively, if you have a custom top-level XSLT, you could override the map-base-page-sequence-generation variable to set it to false()

Thanks v. much. I set map-based-page-sequence-generation to false, and it was 'back to normal'. Maybe not the best solution, but it will do for now.

Marking this closed - the XSL-FO page sequence changes were intentional and there is still a mechanism to keep the old behavior.

But the new sequences do not provide the same page breaks. The changes might be intentional, but they ought to maintain the established, and accepted page break behaviour.

So the intention of this change is to have one page sequence flow per map. That is, ditamap rather than bookmap.
I can see that that makes sense for bookmap where each chapter or appendix, etc. has a child ditamap.
There is an issue for PDF from ditamap. The choice is to revert to the 1.x page sequencing method, or add some logic as Eliot, @drmacro, suggests. I believe it would be necessary to check $mirror-page-margins and add either break-before="page" or break-before="even-page".
Is there an issue for a bookmap that doesn't use child ditamaps? Where all the content is attached directly to the bookmap. Does that automatically revert to the 1.x page sequencing?

The use or non-use of submaps is not relevant: all map references are resolved during preprocessing, resulting in a single map that is then the input to the PDF2 map merge process.
The generation of page sequences should be driven primarily by the need to have different page numbering rules for a given page sequence, e.g., frontmatter (numbered with lowercase roman numerals), body (arabic numbers), and backmatter, or by folio-by-chapter numbering (in which case you need per-chapter page sequences). It can also be driven by the need to have different page geometry for different pages, e.g., foldouts, rotated tables, etc. However, a simple topic-boundary-based approach won't work for that because the page sequence boundaries don't necessarily align to topic boundaries in that case (or don't align to sibling topics).
For the short term I think the correct response would be to have break-before="page" or "even-page" be the default, restoring the default behavior, with a runtime option to turn that behavior off and a specific XSLT extension point to make it easy to change the break-before value for specific topics.
But that should probably be managed as a separate issue--since I've proposed it I'm happy to take on the implementation task--it shouldn't be hard.


Fix missing log in struct

Fixes a missing log value in the struct
What this PR does / why we need it:
Was an oversight from the improved logging
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Fixes #3393 (nil pointer)
Special notes for your reviewer:
/cherry-pick release-1.0
Release note:

Fix nil pointer error in Cloud DNS when specific config was used.

/kind bug

/approve
/lgtm

/cherry-pick release-1.0


Explore methods to allow user to specify CriMS loading factors at fine offence type level

Explore methods to allow user to specify CriMS loading factors at fine offence type level rather rather than overarching category level (as defined in police.uk data).
I.e allow
py:run "set_loading(0.8, 'residential burglary')"
instead of:
py:run "set_loading(0.8, 'burglary')"

set_loading can be done globally, on category, or on crime type
get_loading can only be done on crime type, to avoid ambiguity


More flexible Inducing Features

Following discussion with @jameshensman and @markvdw it seems that there is wider interest in more flexible inducing features beyond real-space inducing points, such as Fourier features, linear combinations and perhaps others.
This PR implements an InducingFeature abstract base class which provides methods for calculating covariances between features (Kuu) and between features and data points (Kuf), and the length of a feature is defined to be the number of rows in the Kuu matrix. I've changed the SVGP and SGPR models to use the features instead of inducing points directly.
I included a little wrapper function that makes it mostly backwards compatible, though I had to change all references to model.Z in the test to model.feat.Z.
Open for discussion / changing the interface!

This looks great. I think it's a super neat solution for inducing features. I'm happy to add another one from the original inter-domain gaussian processes paper. I think it'll be good to have another example to showcase the generality of the code.
The code is currently failing on the metaclass argument, which seems to be Python 3 only. This is almost funny, as yesterday I was defending continuing to support Python 2.7. How much less elegant will the code be for a fix that also supports py2?

Perhaps the best solution to the __len__ problem is to change the behaviour when tf_mode is on? This will allow tf.shape() to be used in tf_mode, while len(self.Z) is used otherwise.

I just added the Multiscale inter-domain feature. It's not tested yet (I will write tests), but I think we need at least one other example of an inter-domain inducing feature in order to show the justification for the generality of the code.

I'm confused why the tests aren't running. They did run when you first committed the branch, right?

@markvdw, code coverage can't be run for non-gpflow branch (read as fork).

we are dropping python 2 support so feel free to use any python 3 feature that helps here:
https://github.com/GPflow/GPflow/issues/516

Superseded by #530


control-service: fix secret in helm chart

Why
The secret was invalid and wasn't saving into k8s
Why
it needed a space before the start of the secret and also needed single quotes around it
How has this been tested
I created the secret in my local cluster and everything works fine.
Also it passes basic linting.
Signed-off-by: murphp15<EMAIL_ADDRESS>

Why wasn't that caught by helm lint? What was the error exactly

Why wasn't that caught by helm lint? What was the error exactly

This makes me thing we need some kubernetes validator as well (e.g like https://learnk8s.io/validating-kubernetes-yaml). helm lint likely is just validating the helm chart and some basic syntax check.

Why wasn't that caught by helm lint? What was the error exactly

This makes me thing we need some kubernetes validator as well (e.g like https://learnk8s.io/validating-kubernetes-yaml). helm lint likely is just validating the helm chart and some basic syntax check.

@tozka  yeah for absolute certain we need to start using helm test asap.
As it is incredibly time consuming to test these changes before creating PRs.
I have created a ticket for this in the backlog.