Docker inside default Codespaces image fails or the dev container fails to start

The codespaces-linux image switched from using the docker-from-docker/docker-outside-of-docker pattern to doing true docker-in-docker as of version 1.1.0 of the image.  This model has advantages particularly in the Codespaces environment because you can "bind" mount from anywhere in the codespace into your containers - which some CLIs and extensioons require.
Unfortunately, this turned out to be a breaking change for the definition since the --priviledged flag needs to be included in runArgs in devcontainer.json. As reported here and here, you may find Docker has not started or get an error about permissions of the /tmp folder without adding this flag.
To resolve this problem, update your devcontainer.json from:
"runArgs": [ "--cap-add=SYS_PTRACE", "--security-opt", "seccomp=unconfined"],

...to...
"runArgs": [ "--cap-add=SYS_PTRACE", "--security-opt", "seccomp=unconfined", "--privileged", "--init" ],

You can also remove the mount property as it is no longer needed, but leaving it there does not cause harm. We'll be sure to bump the major image version number in these situations in the future rather than the minor version number.

@Chuxel I think this might be something I am experiencing. I placed this issue https://github.com/microsoft/vscode-dev-containers/issues/726. When I built the docker-in-docker on my linux machine locally, I was able to run docker...however things got hairy when I tried to follow some of the documentation/scripts inside the container. Let me know if you would like for me to try something out locally!

@Chuxel I think this might be something I am experiencing. I placed this issue https://github.com/microsoft/vscode-dev-containers/issues/726. When I built the docker-in-docker on my linux machine locally, I was able to run docker...however things got hairy when I tried to follow some of the documentation/scripts inside the container. Let me know if you would like for me to try something out locally!

@erinxocon Yeah, saw that issue as well - @2percentsilk was planning to respond there, but yes, the README is wrong. That code needs to be in an ENTRYPOINT script to work which is what the definition actually does.
To clarify this issue, however, there's now two separate definitions:

docker-from-docker - This uses your local docker engine from inside the container.
docker-in-docker - This is a brand new definition that should be setup correctly that actually runs the docker engine inside the container itself. This adds overhead, but better bind mounting support. It requires --priviledged in runArgs to function.

This particular issue relates to the codespaces-linux definition, which did not previously include the --priviledged flag and now uses the approach in the new docker-in-docker definition.

@erinxocon Yeah, saw that issue as well - @2percentsilk was planning to respond there, but yes, the README is wrong. That code needs to be in an ENTRYPOINT script to work which is what the definition actually does.
To clarify this issue, however, there's now two separate definitions:

docker-from-docker - This uses your local docker engine from inside the container.
docker-in-docker - This is a brand new definition that should be setup correctly that actually runs the docker engine inside the container itself. This adds overhead, but better bind mounting support. It requires --priviledged in runArgs to function.

This particular issue relates to the codespaces-linux definition, which did not previously include the --priviledged flag and now uses the approach in the new docker-in-docker definition.

@Chuxel Got it, that makes sense. I was saw the new docker-in-docker when I cloned the repository but didn't bother with it as I just wanted the docker-from-docker. The terminology is a bit confusing to me as I use the docker:dind image in CI all the time and that is what y'all're calling docker-from-docker. Thanks for the clarification!

@Chuxel Got it, that makes sense. I was saw the new docker-in-docker when I cloned the repository but didn't bother with it as I just wanted the docker-from-docker. The terminology is a bit confusing to me as I use the docker:dind image in CI all the time and that is what y'all're calling docker-from-docker. Thanks for the clarification!

@erinxocon Actually - you nailed it on the head. docker-from-docker isn't docker:dind.   docker-from-docker is forwarding the local docker socket and only the CLI is in the container. docker:dind has the docker engine inside, which is what the new docker-in-docker definition does. Bind-mounting is the one downside of docker-from-docker, but DinD has a number potential issues depending on your setup. See here. But for the codespaces image, DinD is the better choice.

@erinxocon Actually - you nailed it on the head. docker-from-docker isn't docker:dind.   docker-from-docker is forwarding the local docker socket and only the CLI is in the container. docker:dind has the docker engine inside, which is what the new docker-in-docker definition does. Bind-mounting is the one downside of docker-from-docker, but DinD has a number potential issues depending on your setup. See here. But for the codespaces image, DinD is the better choice.

@Chuxel Gosh! I was confusing my terminology again! When I setup the CI/CD for my company we were originally using dind, we now pass the context into the containers a la docker-from-docker and socket binding! We were using the docker image to avoid having to install all the docker tools, however I've rolled our own base image. Long day :sweat_smile: Insert Xzibit Yo Dawg docker meme here.

@Chuxel Gosh! I was confusing my terminology again! When I setup the CI/CD for my company we were originally using dind, we now pass the context into the containers a la docker-from-docker and socket binding! We were using the docker image to avoid having to install all the docker tools, however I've rolled our own base image. Long day :sweat_smile: Insert Xzibit Yo Dawg docker meme here.


Release Notes for 202008 release

This is to track conversation about what changed in the D&I WG since the last release

Added Inclusive Leadership metric

Added Inclusive Leadership metric

Apologies if this is not the right place to ask this! In the spreadsheet, the upcoming metric is listed as "Leadership Diversity" but should it read "Inclusive Leadership" to align with what's here in this repo?

Yes, the spreadsheet needs to be updated. Thanks for catching this.

Done!
On Tue, Jun 16, 2020 at 1:20 PM Georg J.P. Link<EMAIL_ADDRESS>wrote:

Yes, the spreadsheet needs to be updated. Thanks for catching this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/chaoss/wg-diversity-inclusion/issues/293#issuecomment-644929819,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFAGUETQIJDOCJOCETH4WTRW6ZVVANCNFSM4N3WU5RA
.

--
Mutual of Omaha Professor
Information Systems
College of Information Science & Technology
University of Nebraska Omaha
CV: https://bit.ly/2kftONr
CHAOSS Board Member
https://chaoss.community/
<EMAIL_ADDRESS>he / him / his

This issue was created to capture the continuous release notes. Insight from comments will be used to create the regular release note.
Example comments could be:
name of new metric and date of release
descriptions of changes to existing metric
Changes to focus areas or restructuring of WG

Added new focus area - Projects and Communities

closing for release 2020-08


refactor code using .editorconfig

In order to keep the same formatting for all IDE, I added .editorconfig file which specify the rules for formatting the code.
A plugin for visual studio code should exist for that (might be there by default).
For other java project, using the same .editorconfig file could be good.
No need to do a release once this is approved.

Agreed


Add support for serializing enum.Enum classes

Is your feature request related to a use case or problem? Please describe.
In #3821 I added a cirq.Alignment enum and attempted to make it serializable. Unfortunately, it's not possible to define _json_dict_ on an enum subclass because enum reserves single underscore _names_ for internal use. To allow serializing enums we would need to do something different. For now, I've marked the enum as not yet serializable. We have a few other enums, e.g. in the placement/routing code, but none of them are serializable.
Describe the solution you'd like
It'd be great if there were a somewhat generic way to make enums serializable, something like json_serializable_dataclass but specific to enums.
What is the urgency from your perspective for this issue? Is it blocking important work?
P3 - I'm not really blocked by it, it is an idea I'd like to discuss / suggestion based on principle

Some ideas that have been thrown around for this:

Provide a default JSON conversion for enum types, e.g. { cirq_type: {enum_type} value: {enum_value} }

Defining enum conversion separate from the enums themselves may be confusing

Use strings and Literal types instead of enums, e.g. {enum_type} = Literal[{enum_value_1}, ..., {enum_value_N}]

Puts the onus on users/developers to know this convention

General recommendation here is to not use the Enum class; trying to get a change to Enum accepted into Python is pretty much the only full solution to this, but it would take a very long time for that to be available to Cirq.


Upgrade to 1.10.0 with Helm doesn't work

Bug description
My GitLab pipeline to upgrade to version 1.10.0 fails because of a problem with RabbitMQ passwords:
$ helm repo add stable https://charts.helm.sh/stable
"stable" has been added to your repositories
$ helm repo add bitnami https://charts.bitnami.com/bitnami
"bitnami" has been added to your repositories
$ helm repo update
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "bitnami" chart repository
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈ Happy Helming!⎈
$ helm dependency update ./helm
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "bitnami" chart repository
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 4 charts
Downloading mysql from repo https://charts.helm.sh/stable
Downloading postgresql from repo https://charts.bitnami.com/bitnami
Downloading rabbitmq from repo https://charts.bitnami.com/bitnami
Downloading redis from repo https://charts.bitnami.com/bitnami
Deleting outdated charts
$ helm upgrade --install --atomic --timeout 10m0s --values ${CHART_DIR}/values.yaml --namespace ${NAMESPACE} --set createSecret=false --set createRabbitMqSecret=true --set createPostgresqlSecret=true --set DD_SOCIAL_AUTH_AZUREAD_TENANT_OAUTH2_KEY=${DD_SOCIAL_AUTH_AZUREAD_TENANT_OAUTH2_KEY} --set DD_SOCIAL_AUTH_AZUREAD_TENANT_OAUTH2_SECRET=${DD_SOCIAL_AUTH_AZUREAD_TENANT_OAUTH2_SECRET} --set DD_SOCIAL_AUTH_AZUREAD_TENANT_OAUTH2_TENANT_ID=${DD_SOCIAL_AUTH_AZUREAD_TENANT_OAUTH2_TENANT_ID} --set DD_SOCIAL_AUTH_AZUREAD_TENANT_OAUTH2_ENABLED=True --set DD_SITE_URL=https://vulnerabilities.example.com ${RELEASENAME} ${CHART_DIR}
Error: UPGRADE FAILED: template: defectdojo/charts/rabbitmq/templates/NOTES.txt:138:4: executing "defectdojo/charts/rabbitmq/templates/NOTES.txt" at <include "common.errors.upgrade.passwords.empty" (dict "validationErrors" (list $requiredRabbitmqPasswordErrors) "context" $)>: error calling include: template: defectdojo/charts/postgresql/charts/common/templates/_errors.tpl:18:48: executing "common.errors.upgrade.passwords.empty" at <fail>: error calling fail:
PASSWORDS ERROR: you must provide your current passwords when upgrade the release
    'auth.password' must not be empty, please add '--set auth.password=$RABBITMQ_PASSWORD' to the command. To get the current value:
        export RABBITMQ_PASSWORD=$(kubectl get secret --namespace defectdojo-fe defectdojo-rabbitmq -o jsonpath="{.data.rabbitmq-password}" | base64 --decode)
    'auth.erlangCookie' must not be empty, please add '--set auth.erlangCookie=$RABBITMQ_ERLANG_COOKIE' to the command. To get the current value:
        export RABBITMQ_ERLANG_COOKIE=$(kubectl get secret --namespace defectdojo-fe defectdojo-rabbitmq -o jsonpath="{.data.rabbitmq-erlang-cookie}" | base64 --decode)

Weirdly the error message mentions PostgreSQL as well, very confusing. I have tried with --set createRabbitMqSecret=false --set createPostgresqlSecret=false and --set createRabbitMqSecret=true --set createPostgresqlSecret=true but that doesn't make any difference.
Steps to reproduce
Steps to reproduce the behavior:

Copy /helm/defectdojo to my repository for the deployment
Start GitLab pipeline, you can see the commands in the log above
GitLap pipeline fails

Expected behavior
Upgrade of DefectDojo to version 1.10.0 without errors
Deployment method (select with an X)

[X] Kubernetes
[ ] Docker
[ ] setup.bash / legacy-setup.bash

Environment information
Kubernetes version:
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.10", GitCommit:"62876fc6d93e891aa7fbe19771e6a6c03773b0f7", GitTreeState:"clean", BuildDate:"2020-10-16T20:43:34Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"}

Here is my values.yml file: values.zip

See my latest PR. Got bitten by it yesterday.

Fixed by https://github.com/DefectDojo/django-DefectDojo/pull/3347 normally (worked for me at 4am yesterday)

Thank you @madchap, it seems to have work. These error messages are gone. Upgrade still not running, now due to some permission problems caused by the healthcheck. This is something I have to discuss with our kubernetes admins.

The problems with RabbitMQ were caused by our local environment. #3347 fixed the initial problem of this bug report.


WIP: add env var for configuration

PR Template:
Describe your changes
Add ENV variables in config.yaml

...

Ticket reference (if applicable)
Fixes #
Checklist

[ ] Are the agreed upon acceptance criteria fulfilled?

[ ] Was the 4-eye-principle applied? (async PR review, pairing, ensembling)

[ ] Do your changes have passing automated tests and sufficient observability?

[ ] Are the work steps you introduced repeatable by others, either through automation or documentation?

[ ] If automation is possible but not done due to other constraints, a ticket to the tech debt sprint is added
[ ] An SOP (Standard Operating Procedure) was created

[ ] The Changes were automatically built, tested, and  - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)

[ ] Are the agreed upon coding/architectural practices applied?

[ ] Are security needs fullfilled? (e.g. no internal URL)

[ ] Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)

[ ] For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?

https://github.com/go-kratos/kratos/issues/3198#issuecomment-1943440755

@akoserwal @merlante
I'm glad to see that RedHat is using Kratos. What are the reasons for using Kratos? We would like to know why users choose to use Kratos to help improve the project continuously.
Can you also add a use case, https://github.com/go-kratos/kratos/issues/969
If you have any questions, suggestions or opinions while using it, please feel free to give me feedback.

@akoserwal @merlante
I'm glad to see that RedHat is using Kratos. What are the reasons for using Kratos? We would like to know why users choose to use Kratos to help improve the project continuously.
Can you also add a use case, go-kratos/kratos#969
If you have any questions, suggestions or opinions while using it, please feel free to give me feedback.

Hi @shenqidebaozi thank you for reaching out.
We are evaluating Kratos for a POC project. Kratos enabled us to develop a proto-to-open API spec workflow and build APIs quickly.
Suggestions: The discord go-kratos forum isn't active much. Is there any other forum where I can engage for doubts/discussions?
As we go along with the development, I'll definitely identify areas to improve and where we see an opportunity to contribute.

@akoserwal Due to certain network restrictions, Discord cannot be directly accessed within China. At present, our main focus is on maintaining the community on WeChat. But you can also add my Discord(baozi6562) for communication, and I am also considering how to improve the issue you encountered when using config env.
Since the values of environment variables are all strings, it is necessary to convert them to the expected target type when using them. I am considering how to implement this feature. Do you have any ideas?

Since the values of environment variables are all strings, it is necessary to convert them to the expected target type when using them. I am considering how to implement this feature.

@akoserwal Due to certain network restrictions, Discord cannot be directly accessed within China. At present, our main focus is on maintaining the community on WeChat. But you can also add my Discord(baozi6562) for communication, and I am also considering how to improve the issue you encountered when using config env.
Since the values of environment variables are all strings, it is necessary to convert them to the expected target type when using them. I am considering how to implement this feature. Do you have any ideas?

One way would be to define the type: int along the fields in config.yaml and, post-reading the environment variable, do the conversion like this:
envVar := os.Getenv("ENV_VAR_INT")
var1, err := strconv.Atoi(envVar)

Or allow users to read all environment variables as strings, and then they can do the conversion.


Remove version: Jackett.Jackett version 0.21.1638

404 - release deleted
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Jackett/Jackett/releases/download/v0.21.1638/Jackett.Installer.Windows.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 918)


Login not working anymore

17wo changed the login procedure.

:cry:  17wo use captcha  by default

There is only 1 possibility.
17wo does not use captcha when random SMS code is used to login.
We can use a 3G modem to receive SMS and get the code for automation.
I already had an 3G modem linked to my Server for receiving SMS. And could trigger file copy to other location.
The code can be easily extracted as it is the first 6 digit as below:-
012345（一起沃平台验证码）【省流量，就上 http://17wo.cn 】

good idea!

请问下还更新吗这个？


Add the SMO opcode to sway-core

Changes Made

allocated_ops.rs

Added to enum AllocatedOpcode
Added to Display trait for AllocatedOpcode
Added to impl AllocatedOp function to_fuel_asm

mod.rs

Added to impl Op function parse_opcode
Added to Display trait for Op

virtual_ops.rs

Added to enum VirtualOp
Added to impl VirtualOp function

registers
use_registers
def_registers
update_register
allocate_registers

Related
Closes #2176

Where should this be tested?
I swear that I did not simply copy and paste things without knowing what they are.
I assure you dear reader that I am competent.

12 failing checks huh. I have been duped. I will fight you tomorrow.

cargo fmt
cargo clippy
cargo run (in sway/test)
And then the stdlib tests which I think you know how to run.

 That issue needs to come first...
Should I try that one or leave it to the compiler team?
@mohammadfawaz

Looks like sway-core needs to be bumped to 0.6 (fuel-asm) to get the SMO opcode but that turns out to remove a bunch of other opcodes... That issue needs to come first...
Should I try that one or leave it to the compiler team?
@mohammadfawaz

Do you want to just remove those opcode then? I don't think they are used in any useful way anywhere in the compiler or the tests. They have to be removed anyways.
Cc @nfurfaro who wants to add gtf too.

The discussion we had in the app-dev sync was around adding these opcodes (smo and gtf) pre-emptively, knowing that they won't work until the upstream changes trickle down to the compiler. You could try bumping deps, I'm not sure if there are any blockers there or not. I'm ok to wait till the compiler is ready for these new instructions and then merge them.

Note that the SMO is UNTESTED because I don't know how to test this.
I have disabled it for now, the TRO opcode is also disabled for some reason so despite disagreeing with this being disabled I thought that it might get picked up later.

Skeleton test that is disabled (and panics when enabled because it is incorrect)

I might be missing some context, but could you explain why this is the case?

Comment here

Note that the SMO is UNTESTED because I don't know how to test this.

@Braqzen  do you not know how to test this because you are not familiar with the Sway compiler, or because it is not currently possible to write an accurate test? I'm trying to figure out if I would be able to think of test suggestions to offer 😄

Note that the SMO is UNTESTED because I don't know how to test this.

@Braqzen do you not know how to test this because you are not familiar with the Sway compiler, or because it is not currently possible to write an accurate test? I'm trying to figure out if I would be able to think of test suggestions to offer smile

I don't understand the spec and how to implement the test for it

Note that the SMO is UNTESTED because I don't know how to test this.

@Braqzen do you not know how to test this because you are not familiar with the Sway compiler, or because it is not currently possible to write an accurate test? I'm trying to figure out if I would be able to think of test suggestions to offer smile

I don't understand the spec and how to implement the test for it

Do we have all the changes from fuel-core and the VM for this to be functional? I suspect not. I wonder if we also have to bump their version up when they're ready.

Note that the SMO is UNTESTED because I don't know how to test this.

@Braqzen do you not know how to test this because you are not familiar with the Sway compiler, or because it is not currently possible to write an accurate test? I'm trying to figure out if I would be able to think of test suggestions to offer smile

I don't understand the spec and how to implement the test for it

Do we have all the changes from fuel-core and the VM for this to be functional?

According to @Voxelot the client has some pending code for review for the SMO opcode.

According to @adlerjohn I just need to get it to compile.

It's not a great idea to add the empty test -- do you have a simple example of how it should be used, @nfurfaro?

do you have a simple example of how it should be used

There's really no simple way to test this. The most straightforward solution is to add SDK tests, which makes more sense for testing a stdlib wrapper function around this opcode.


Ghost fails when trying to register blog

When I go to /ghost and try to sign up with a new build of this image the page loads, but it fails when I submit the page.
Here is the log from ghost:
GET /ghost/api/v0.1/authentication/setup/ 200 15.310 ms - 28

/usr/src/ghost/core/server/mail.js:95
                if (data.error.errno === 'ENOTFOUND') {
                              ^
TypeError: Cannot read property 'errno' of null
    at EventEmitter.<anonymous> (/usr/src/ghost/core/server/mail.js:95:31)
    at EventEmitter.g (events.js:180:16)
    at EventEmitter.emit (events.js:95:17)
    at DirectMailer.<anonymous> (/usr/src/ghost/node_modules/nodemailer/node_modules/directmail/lib/mailer.js:138:30)
    at asyncCallback (dns.js:68:16)
    at Object.onanswer [as oncomplete] (dns.js:147:9)

npm ERR! Linux 3.18.5-tinycore64
npm ERR! argv "node" "/usr/local/bin/npm" "start"
npm ERR! node v0.10.36
npm ERR! npm  v2.7.0
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: `node index`
npm ERR! Exit status 8
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'node index'.
npm ERR! This is most likely a problem with the ghost package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node index
npm ERR! You can get their info via:
npm ERR!     npm owner ls ghost
npm ERR! There is likely additional logging output above.
npm ERR! Linux 3.18.5-tinycore64
npm ERR! argv "node" "/usr/local/bin/npm" "start"
npm ERR! node v0.10.36
npm ERR! npm  v2.7.0

npm ERR! Uncaught, unspecified "error" event.
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <http://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /usr/src/ghost/npm-debug.log

I'm going to start looking at additional setup required from Ghost, but if there is any required, it seems like this should be mentioned in the readme.
I'm just running it as apart of my docker-compose:
ghost:
  image: ghost:0.5.9
  ports:
  - "8080:2368"

Here is the failure message on the webpage itself:

It doesn't seem to be a common error.
Due to the error log, I'm assuming I probably need to setup a mail server. My suggestion for the readme for this image would be to include how to create a basic config.js and copy it to this image to get it fully setup. This way people understand that they need that to get going.

@ryanjm can you share your whole config? can't seem to reproduce the error you're getting. I'm also using docker-compose

Having a similar issue here—definitely appears to be a mailer issue:
GET /ghost/api/v0.1/authentication/setup/ 200 7.287 ms - 28

/usr/src/ghost/core/server/mail.js:95
                if (data.error.errno === 'ENOTFOUND') {
                              ^
TypeError: Cannot read property 'errno' of null
    at EventEmitter.<anonymous> (/usr/src/ghost/core/server/mail.js:95:31)
    at EventEmitter.g (events.js:180:16)
    at EventEmitter.emit (events.js:95:17)
    at DirectMailer.<anonymous> (/usr/src/ghost/node_modules/nodemailer/node_modules/directmail/lib/mailer.js:138:30)
    at asyncCallback (dns.js:68:16)
    at Object.onanswer [as oncomplete] (dns.js:147:9)

Is there a way to resolve this? Running it in a container so I can work on a theme without having to mess with any production sites.

This conversation died. We should close this conversation.
https://github.com/docker-library/ghost/issues/25#issuecomment-247216227


Merge master branch into feature/Swift_2.0 for Carthage build.

Current 23aaf8d (feature/Swift_2.0 branch) doesn't contain any xcodeproj or xcworkspace to build Async.framework, so carthage build will never get started.
It seems current master branch (v1.2.1) already has one, so please merge it into feature/Swift_2.0 so that I can test Swift 2 using Carthage.

Fixed in a7d2aa78c9830ca1ede52fb3db69079e47c32d05. Please let me now if it works as expected.


为文件缓存hash之后的文件名自动添加后缀

#1670

It solves a partial of #1670, but once the key changed to something else (such appended by a non-default processor, the key would become something like image.jpg@size123), this would be not valid anymore.
The feature is useful itself, and I will see if there is a better way to implement it.


[typescript-graphql-request] allow custom Sdk type

Is your feature request related to a problem? Please describe.
Currently, @graphql-codgen/typescript-graphql-request uses a hard-coded Sdk type. If the schema also has a Sdk type, this will cause a conflict.
Describe the solution you'd like
Allow the user to customize the Sdk type, for example by adding the sdkType option to the configuration.

Could also fix via hooks:
  hooks: {
    afterOneFileWrite: [
      `sed -i -e "s|export type Sdk = ReturnType|export type MySdk = ReturnType|g"`,
    ]
  }


JwtAuthentication can't parse float iat

Hi
Title: JwtAuthentication can't parse float iat
Description:
Envoy can't validate JWT with iat as float.
Repro steps:
Create a JWT with iat as float (e.g. 1.688117968E9) and send it through JwtAuthentication
The RFC states that iat must be a  JSON numeric value, not an integer. So I guess envoy should be able to parse this iat.
NumericDate
      A JSON numeric value representing the number of seconds from
      1970-01-01T00:00:00Z UTC until the specified UTC date/time,
      ignoring leap seconds.  This is equivalent to the IEEE Std 1003.1,
      2013 Edition [[POSIX.1](https://datatracker.ietf.org/doc/html/rfc7519#ref-POSIX.1)] definition "Seconds Since the Epoch", in
      which each day is accounted for by exactly 86400 seconds, other
      than that non-integer values can be represented.  See [RFC 3339](https://datatracker.ietf.org/doc/html/rfc3339)
      [[RFC3339](https://datatracker.ietf.org/doc/html/rfc3339)] for details regarding date/times in general and UTC in
      particular.

and
[4.1.6](https://datatracker.ietf.org/doc/html/rfc7519#section-4.1.6).  "iat" (Issued At) Claim

   The "iat" (issued at) claim identifies the time at which the JWT was
   issued.  This claim can be used to determine the age of the JWT.  Its
   value MUST be a number containing a NumericDate value.  Use of this
   claim is OPTIONAL.

Thanks

Sorry, missread my logs. The error comes from ext_authz


0.2.0 Proposal

This makes a good starting point to rename the library to something sane

dont accidentally merge this btw

dont accidentally merge this btw

But it looks like a good pr!

lmaoo okay i'll stop memeing on your repo now. good luck!


Wunderground weather sensor

Description: Sensor to obtain weather data from Wunderground
Obtain Wunderground API here. Free account allows 500 requests per day or 10 per minute.
Related issue (if applicable): https://community.home-assistant.io/t/is-anyone-doing-anything-with-weather-underground/763/1
https://community.home-assistant.io/t/weather-underground-wunderground-weather-sensor/1849/1
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for configuration.yaml (if applicable):
sensor:
    platform: wunderground
    api_key: your_api_key
    pws_id: enter_pws_id
    monitored_conditions:
      - temp_f
      - weather
      - station_id
      - feelslike_c
      - feelslike_f
      - feelslike_string
      - heat_index_c
      - heat_index_f
      - heat_index_string
      - dewpoint_c
      - dewpoint_f
      - dewpoint_string
      - wind_kph
      - wind_mph
      - UV
      - pressure_in
      - pressure_mb
      - wind_dir
      - wind_string
      - temp_c
      - temp_f
      - relative_humidity
      - visibility_mi
      - visibility_km
      - precip_today_in
      - precip_today_metric
      - precip_today_string
      - solarradiation

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If code communicates with devices, web services, or a:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Is it possible to include the forecast as well? If you request it at the same time, it's still 1 API call.
I actually contributed this to kellbot's repo ->
https://github.com/kellbot/hass-wunderground/commit/9a93c16759c8fdb84eaa5c6ee7313183a538dbf7#diff-5c7a37ac885960ee5b7037523b887308R7

@AlucardZero I should be able to incorporate the changes once I get past the "invalid syntax" error....not sure what am I missing.

Isn't there already a Python module/wrapper available for Wunderground? I'm just curious...

There is something....but I was not able to use the pws id with it.

@arsaboo - Let me know if you want to use my documentation and example files in the HA docs task.  If you need help let me know.

@rpitera I updated the initial documentation....please feel free to modify them once we get the initial docs in.

Link your home-assistant.io changes and I'd call this good

I already linked it...here it is again. https://github.com/home-assistant/home-assistant.io/pull/800

Sure...thanks @Teagan42 for all your assistance. Miss the :dolphin: though :wink:

🐬!

@arsaboo are you working on adding forecast data, or should I redo it against home-assistant and submit a PR?

@AlucardZero I am stuck with a few other things...feel free to create a PR for the forecast. It will be useful. Thanks!


Online Sessions

This is another one of my "mind to disk" ideas (before I forget)...

I've got number of machines around the house (work machine, laptop, wife's
machine, etc) which I tend to use Super Putty from time to time on all of them
and it would be great if I could have (with the help of a nice web/php API)
online storage of my sessions as I'm constantly having to update my sessions
file on work machine to laptop and then update on laptop but have to copy it
back to work machine.

Then sometimes I leave my house and go on the road and forget I've added some
new nodes to my list but now onsite without them.

Was thinking of writing a simple PHP code and a Save As/Load From URL option to
work online with the connect details that could be saved centrally.

So far the another solution would be google drive or some other thing like that
but would be nice for some native available code

little wild idea but would save me using vpn and shares which really is
annoying....

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 22 Oct 2012 at 10:47

Closing this issue but all hope is not lost! We still want to help.
See: https://github.com/jimradford/superputty/wiki/Legacy-Imported-Issues on how to help us to help you!


Custimize font size and color.

Hello,
Is there any way to customize the alertView font size and color for our app used?
Thank you very much.

Yes sure!
See here: https://github.com/Codeido/PMAlertController/issues/47
Thanks

Paolo

Hi there, Noted. Thanks for your feedback.


Create MANIFEST.in and include requirement.txt

What's Changed
A description of the issue/feature; reference the issue number (if one exists). The Pull Request should not include fixes for issues other than the main issue/feature request.
Technical Description
Any specific technical detail that may provide additional context to aid code review.

Before opening a Pull Request you should read and agreed to the Contributor Code of Conduct (see CONTRIBUTING.md)

@thewchan can you please populate the pull request description for this change?

I'll take a look the next day to check what should be included in the  MANIFEST.in. Feel free to include these changes in your pull request if you already have any idea of what is missing.
At a glance, https://github.com/mgedmin/check-manifest looks like it could be useful for checking this in future - especially the pre-commit hook.
As for what is missing, the long description comes from the readme so it looks like it will need to be included

https://packaging.python.org/en/latest/guides/using-manifest-in/
There may even be extra files that you need to include; for example, if your setup.py computes your project’s long_description by reading from both a README and a changelog file, you’ll need to include both those files in the sdist so that people that build or install from the sdist get the correct results.

@apoclyps this is actually a very simple PR, nothing is changed except now requirements.txt will also be included in the source code sdist on PyPI. You can check here: https://packaging.python.org/en/latest/guides/using-manifest-in/ to see the default files included, and if you want to include/exclude certain files from the sdist.

@apoclyps thanks so much, if it's possible please let me know when a new release is pushed to PyPI that includes this? My plan is to try putting this package on conda forge for broader exposure

awesome @thewchan; do let me know how that goes 👍
I've released 0.4.1 with this change on PyPi: https://pypi.org/project/reviews


Properly parse task includes

Scenario
p0.yml:
- hosts: all
  tasks:
    - include_tasks: t0.yml

t0.yml:
- import_tasks: t1.yml
- include_role:
    name: r0

Actual Behaviour
The top-level task include in p0.yml is not parsed, and so isn't the role include in t0.yml.
Expected Behavior
We should get the dependency chain
p0.yml ---> t0.yml ----> t1.yml
                   \
                    +--> roles/r0

Also take care of handling includes in blocks. Example (taken from stackoverflow):
- name: test
  hosts: all
  tasks:
    - block:
      - include: include1.yml
      - include: include2.yml
    when: doinclude  | default('true')


transport: enable virtiofs and vhost-user-fs

Bring back virtiofs and vhost-user-fs support so that consumers can use
the latest code to run virtiofs and vhost-user-fs.

Tested with qemu 6.1.0 with arguments like:
        -chardev socket,id=foobar,path=./vhost-fs.sock \
        -device vhost-user-fs-pci,chardev=foobar,tag=sharedfs \


transfer_distrib_spawn_state_on_fit_end in tpu_spawn.py regex path wildcard use can cause opaque error.

🐛 Bug

This function: https://github.com/PyTorchLightning/pytorch-lightning/blob/e126649d19e85c449b007008361f10374878f2f4/pytorch_lightning/plugins/training_type/tpu_spawn.py#L183
is intended to create a file based on another file ending with .ckpt.
However, the "." in re.sub matches any character (not just a dot).
Concretely, in my case, my checkpoint save path was called ".../model_ckpts". This led to this re.sub creating the string ".../model.tmp_end.ckpt", which is a directory that is not found, and leads to the error Exception in device=TPU:0: [Errno 2] No such file or directory: '.../model.tmp_end.ckpts/epoch=11-step=23-v1.tmp_end.ckpt'

Expected behavior
It should not matter how I name my checkpoint directory (more specifically: I should be able to use 'ckpt' as part of the folder name.
That or there should be a warning raised against doing so.
The cause of the issue seems pretty clear, so not making a collab reproduction.

@kaushikb11 mind have look? :]


search-bar snippet contains element id

The search-bar snippet contains an input element with id="search-input". If you use this snippet in multiple places (such as on the search page), then you end up with multiple elements with the same id.

Looks like this was fixed at some point. Feel free to reopen if you see fit.


Pipenv

Description of the change:
Use Pipenv - the Python packaging authority recommended way - as a dependency resolution managemente system and vulnerability checker to install Python dependencies.
This PR is part of #4237 to work towards a more user-friendly way of doing reproducible local builds
Motivation for the change:
Python package dependency is best managed using a fit-for-purpose package manager that checks for dependency conflicts, separates wanted dependencies from required subdependencies and that is able to check for vulnerabilities. The proposed solution is fully backwards compatible.
Checklist
If the pull request includes user-facing changes, extra documentation is required:

[x] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[ ] Add or update relevant sections of the docs website in website/content/en/docs

https://github.com/operator-framework/operator-sdk/pull/4477#discussion_r570484392 was accepted here

I guess 5 commits in a PR is better than 380 😆

@reinvantveer wdyt about pip freeze-ing all deps, to avoid issues like this?

@estroz 👍  This question couldn't have come at a better time. This PR already solves this, in https://github.com/operator-framework/operator-sdk/pull/4494/files#diff-82452578a3e817b3b4dc5c154471041589c4b535216c59dbd8982bc18e2f8d32R125 and using pipenv install --deploy, which will only install the versions from Pipfile.lock
So in short: yes I think pinning is good here and pipenv provides a solid method to implement this.

@estroz I'd consider pinning cryptography in the Pipfile, but only if future versions of the package are expected to break: looks like 3.4.4 still requires a Rust compiler. But instead of pinning, we could also consider adding (and uninstalling) the Rust compiler to the Dockerfile. It just wouldn't help things along in having a local (i.e. non-dockerized) environment, with an extra compiler added to the mix. I guess it's up to you to choose either way. Would you rather

pin the version in the Pipfile to prevent pipenv update-ing to cryptography versions requiring a Rust compiler or
add the Rust compiler to the Dockerfile recipe to be able to follow along with updates on cryptography
?

@reinvantveer I totally missed the lock file, awesome!

add the Rust compiler to the Dockerfile recipe

I’m in favor of this option.

@reinvantveer I totally missed the lock file, awesome!

add the Rust compiler to the Dockerfile recipe

I’m in favor of this option.

@estroz Cool. I do some Rust programming in my spare time and it's awesome. If it's OK with you I'd like to process this PR first before diving into the Rust compiler to upgrade the cryptography package. This PR is pretty much self-contained (with the whole pinning business through the lockfile) so it should be the first next step I think.

/cherry-pick v1.4.x

@varshaprasad96 you can just make the bump on this line in a new PR.

@reinvantveer this PR might've been merged prematurely. Builds for s390x, ppc64le, arm64 are broken due to gcc (and other deps) not being installed, but during some testing I also discovered that the Pipfile.lock's hashes don't resolve on s390x builds (at least) and I can't debug the issue. I'd like to revert this PR until we can test builds on all platforms using Github Actions for each PR since we're moving away from Travis soon. This is something I'm working on right now using docker buildx.


Providing a file blocks the Pyrsia node

Since we do AutoNat bootstrapping by default, a locally started pyrsia node is automatically connected to the 'Pyrsia network'.
As a result, I've found that when connected to the central node(s), providing files (e.g. after a build from source) on the p2p network blocks the Pyrsia node from doing anything else.
Steps to reproduce:

follow the instructions in one of the build from source tutorials (https://pyrsia.io/docs/tutorials/build_from_source_maven/)
after the build succeeds and the files are provided on the network, try to run: pyrsia -s (or hit http://localhost:7888/status)
The result is that this last command will hang, waiting for something happening inside Pyrsia.

Alternatively, this can be reproduced by simply starting a node:
RUST_LOG=debug DEV_MODE=on PYRSIA_ARTIFACT_PATH=/tmp/pyrsia cargo run --package pyrsia_node

and then run curl http://localhost:7888/peers
it then gets stuck in p2p_client.list_peers().await

Keep also in mind that in milestone 0.2 we do not have to support a full featured behind-a-NAT pyrsia node. it would be enough to have a behind-a-NAT node, connect to one of the central nodes and be able to download from the Pyrsia network. It does not necessarily need to participate in the content distribution to other nodes itself.

I can not reproduce the failure on Ubuntu 20.04 with rustc 1.62.0
I can reproduce the failure on Ubuntu 18.04 with rustc 1.63.0

There is a tokio::select call in the eventloop which selects either a swarm event or a received command. The one that is not selected is dropped. I think it is better to process swarm events and received commands in 2 event loops.


R / Python Publish to Web availability?

[Are there any plans to enable R or Python script visuals to appear in 'Publish to Web'? My content is built based on Python visuals but could amend for R]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bc005634-24c6-15c4-4352-e1455d63f4f3
Version Independent ID: 577c460a-08cc-892e-c5f9-e6106958f856
Content: Publish to web from Power BI - Power BI
Content Source: powerbi-docs/collaborate-share/service-publish-to-web.md
Service: powerbi
Sub-service: pbi-collaborate-share
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Hi, @BoscoMoroni -- I'm checking with the product team and will get back to you. Thx!

Hi, @BoscoMoroni -- got a quick reply, though not necessarily what you wanted to hear:
"There is no such work planned for Publish to web as of now."
Thanks for asking.


nuclei Model

i want to run cellpose on a hpc where scripts have no rights to load for example models from the internet. therefore i have to load the models beforehand and copy them to the hpc. the nuclei model achieves the best results in the gui variant, however i can only load the nucleitorch models which achieve much worse results. can i still download the nuclei model somewhere?

When you click on the nuclei button in the GUI, cellpose downloads and uses the model found at https://www.cellpose.org/models/nucleitorch_0. If you are getting different results when you use the nucleitorch model without the GUI, I'd double check that you're defining the correct channels. Here's info on setting the correct channels for CLI/API usage: https://cellpose.readthedocs.io/en/latest/settings.html.
Also, the default is to auto adjust the saturation in the CLI/API which you may have turned off in the GUI. I'd try running the code with using the --no_norm flag in the CLI or normalize set to False in your Cellpose.eval()call. Additionally, the diameter, flow_threshold, cellprob_threshold, and stitch_threshold parameters will need to be adjusted if you change them in the GUI.

thanks @mrariden for answering this.
btw @mrariden  can we please add this info to an FAQ on how to download all the models and use them on a computer without download permissions?


Bug: angular.equals not symmetric given objects with non-enumerable properties

POC:
let o = {}; Object.defineProperty(o, 'a', {value:1});
angular.equals(o , {}); // true
angular.equals({}, o); // true
angular.equals(o, {a: 1}); // false
angular.equals({a: 1}, o); // true

What the results of these should be are debatable but the last two should be at least symmetric. (Presumbly, both should return false to retain transitivity.)
The use case of non-enumerable is I want to ignore certain deep/cyclical/non-important part of the tree from comparison when using Scope.$watch(..., ..., true).

(As mentioned several times) the angular.xyz helpers are not supposed to be general purpose utility functions that cover all use cases. In this case, the recommendation is to use a specialized library.
Is there some part of Angular that is using angular.equals that is causing you problems?

The use case of non-enumerable is I want to ignore certain deep/cyclical/non-important part of the tree from comparison when using Scope.$watch(..., ..., true).

I am not sure this feature can still be trusted if the underlying function behaves incorrectly in this use case.

So, are you trying to deep-watch an expression which sometimes points to an object with enumerable properties and sometimes to an object with non-enumerable? It sounds confusing.
Can you you post an example of what you are trying to do - e.g. a code sample that showcases the unexpected behavior?

There's no expected behaviour in the current implementation, but as the handling of non-enumerable properties are not guaranteed by the documentation of angular.copy, the adverse condition can arise in a future version.
Specifically, angular.copy's documentation says:

... and then all elements/properties from the source are copied to it.

In reality, non-enumerable properties are not copied right now.
If the implementation were to change to copy them, then the copies may not compare correctly with the original.

Currently the way to ignore certain parties of a deep tree is to pass a function that returns the expression to be watched, i.e.
$scope.$watch(() => $scope.foo.bar.baz, () => { ... });

I would be wary about changing Angular's core, as this would be a breaking change with potentially significant effects on some users' apps. IMO, this is a non-standard way to try to eke out perf benefits when there are already existing tricks.

@billccn, this sounds like a documentation issue. The behavior of copy is very specific, but the documentation could be lacking.
If it were to change in the future it would be a breaking change. So, this would only happen in a minor version update, be properly documented and would be expected to break things (that's what breaking changes do :smiley:).
But I don't think it is likely to ever happen.
--
If anyone is interested in updating the docs though, they would be more than welcome! :smiley:


Update client-apis-for-pluggable-widgets.md

Code snippet on section 4.9 is incorrect.
Function call should just be " this.props.myAttributeOnDateSource(...) "

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Re-enable tests

Package version (if known): november release
Let's re-enable tests so it's clear what are intended features and what are bugs.

Tests are running in GitHub Actiosn now.

Tests are running in GitHub Actiosn now.


Create StateSpace.scala

added breeze mcmc using markov chain

Current coverage is 0.00% (diff: 100%)

Merging #46 into master will not change coverage

@@           master   #46   diff @@
===================================
  Files         127   127
  Lines         135   135
  Methods         0     0
  Messages        0     0
  Branches        2     2
===================================
  Hits            0     0
  Misses        135   135
  Partials        0     0

Powered by Codecov. Last update 78f3dff...1ab8a02


nixos/tlp: force necessary settings

Motivation for this change
TLP is very sensitive to certain system settings that we take care to
disable/nullify in the module code. This takes the further step to
mkForce those options to ensure no insane behavior if the user attempts
to set them in disagreement with the module.
cc. @worldofpeace
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I should probably add myself to maintainers of both this module and the package :smile:
I'm not sure this provides the best UX though, like what happens if someone tries to set it?
Perhaps we could use an assert too.

Before:
If someone attempts to set those it will blow up saying it's in conflict with TLP, they can then mkForce it and explode themselves.
After:
If someone attempts to set them TLP will mkForce over them and no one gets hurt.
And yes, you should definitely add yourself :D

@lovesegfault Right, but even before, it would say it conflicted with TLP but you had no idea why. Just that it conflicts. Now, I guess it'll just be silently ignored?

I wouldn't say ignored, now it will silently override you and do-the-right-thing:tm:
I agree that it's not ideal that it happens silently. Is there a way to add a warning like "Hey, we're preventing you from being silly, here's my soundcloud"?

I wouldn't say ignored, now it will silently override you and do-the-right-thingtm
I agree that it's not ideal that it happens silently. Is there a way to add a warning like "Hey, we're preventing you from being silly, here's my soundcloud"?

I believe assertion or warning https://nixos.org/nixos/manual/index.html#sec-assertions

Alright, done @worldofpeace, it will now scream at the user!

I think in this case it is better to

not use mkForce
use real assertions, with links to the part of the tlp documentation which explains why this setting is mandatory.


is that any possible way to use this library on UIViewController instead of swiftUI view ?

I have one situation that I would like to show popup on currently presented screen in app.
to get currently presented screen using UIKit is super easy and fast and than we can show alert.
But this library only works with SwiftUI Views.   If we can use this library on UIKit than would be awesome and very much blessed!

Please refer to this issue
https://github.com/exyte/PopupView/issues/102
Have a nice day


So... what's going on?

Has the project already been abandoned?

Nope!
I've dealing with some of my personal stuffs last two month, so it doesn't update so much.
Actually, I'm working on reconstructing some SQL connection parts. There're some bugs causing very unstable behaviour. So I still cannot release it as production ready yet.
It would likely to get next version released in one or two week.


PANDARIA: Fix show unauthorized when group member to get the monitor

Update prometheus-auth image
Relate issue:
https://github.com/cnrancher/pandaria/issues/1187

this PR need to update when we get the new prometheus-auth image


Camera accumulates rolls (rotation around the forward axis) after moving the mouse around for a while

Just drag your mouse with left click and move it in a circle, many many times.
The camera ends up accumulating rotation around the forward axis.
This may be an issue with the order of operation when applying the quaternion rotations.

That's how it's supposed to work. I guess it's a little bit counterintuitive, but I just wanted a camera that moves in relation to its own forward vector. So if you rotate 90° up (x-axis relative to the camera), 90° right (y-axis relative to the camera), and finally 90° down, you end up rotated 90° on the z-axis (roll) relative to the initial rotation. It seems weird, but it makes navigating complex scenes easy since you move relative to yourself not the world, so you can position yourself in pretty much any way you want, for example, upside down, without any problems. It's also pretty standard camera model for a lot flight simulator games, especially those in space where you don't have any point of reference so you move relative to the camera.

Yeah moving relative to the camera makes sense but I'm not sure you picture the issue I'm seeing.
Here's a video I recorded quickly: https://youtu.be/Y-1TjcK5uyg
Is that intended? I expected the camera to behave like an FPS camera but by simply looking around a scene, you end up upside down even if you don't want to.
I find it hard to control but if that's expected, then I guess it's okay.

If you find yourself accidentally rotated upside down, you can adjust the camera roll using Q and E to get back to the initial position.


Static build?

We ended up going hard into macaroni.nix! Closing this since our windows builds are working ! Thanks again!


Iromlab hangs on "In vivo Optical Imaging of Fluorescent Markers" CD

Only happens when running Iromlab from installed package; disc is rejected if run from source!
Disc contains 3 sessions (probably unrelated to this issue, but only 1st session extracted)!
ISO image is corrupt and throws error in Isolyzer

Following line in isobuster.py:
https://github.com/KBNLresearch/iromlab/blob/9d266a090807fb6284c49f3c08d2a3cccfdbc2cd/iromlab/isobuster.py#L100
If  I replace except IOError: with a catch-all except: the disc is rejected (as it should), so I'm assuming that the error is something other than IOError. Since there is no exception handler in this case, isolyzerSuccess and imageTruncated are then undefined, which would explain the hang-up.
To get the exact exception tried this:
except Exception as e:
    logging.info(''.join(['### Exception: ', str(e)]))

Result:
Exception: 'NoneType' object has no attribute 'write'

caused by bug in Isolyzer, which is fixed there by https://github.com/KBNLresearch/isolyzer/commit/2aaf9452e73d96ffb23ba830cde19949d252c9f9.
BUT after this fix the corrupt UDF image actually passes the check because the expected file size is 0 bytes! Possible solution: set imageTruncated to True if expected image size is 0.

This should fix the issue:
https://github.com/KBNLresearch/iromlab/commit/33c6b6c98083da1cab4f5b58f07fd876da029cc9

Additional info: was initially puzzled that recovered ISO image is only 162 kB whereas manually recovered ISO image through ISOBuster is 3.5 MB, but this is explained by the use of different drives.


chore: bdd-sbhg-1586631715 to 0.0.1

chore: Promote bdd-sbhg-1586631715 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Prevent duplicate item deletes and drop reload collisions

Changes in this pull request
a415ef5552cbfbf2d3884a705241973f4ea72dde exposed a bug in UICollectionView where its state gets corrupted when deleting the same index path more than once in a single batch update block. This resulted crashes like
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x4)
#1  0x000000010c63a451 in -[UICollectionViewData layoutAttributesForItemAtIndexPath:] ()
#2  0x000000010c63a648 in -[UICollectionViewData layoutAttributesForGlobalItemIndex:] ()
#3  0x000000010c5f18d8 in -[UICollectionView _viewAnimationsForCurrentUpdate] ()
#4  0x000000010c5f6c7f in __71-[UICollectionView _updateWithItems:tentativelyForReordering:animator:]_block_invoke.2012 ()
#5  0x000000010bd5bd3e in +[UIView(Animation) performWithoutAnimation:] ()
#6  0x000000010c5f58b9 in -[UICollectionView _updateWithItems:tentativelyForReordering:animator:] ()
#7  0x000000010c5efbbf in -[UICollectionView _endItemAnimationsWithInvalidationContext:tentativelyForReordering:animator:] ()
#8  0x000000010c5f8259 in -[UICollectionView _endUpdatesWithInvalidationContext:tentativelyForReordering:animator:] ()
#9  0x000000010c5f85a0 in -[UICollectionView _performBatchUpdates:completion:invalidationContext:tentativelyForReordering:animator:] ()
#10 0x000000010c5f83c8 in -[UICollectionView _performBatchUpdates:completion:invalidationContext:tentativelyForReordering:] ()
#11 0x000000010c5f834a in -[UICollectionView _performBatchUpdates:completion:invalidationContext:] ()
#12 0x000000010c5f829f in -[UICollectionView performBatchUpdates:completion:] ()

And bizarre ones like
+[NSError _isCell]: unrecognized selector sent to class 0x1aa34

This PR prevents that crash and fixes the flakiness of test:
test_whenDeletingItemsTwice_withDataUpdatedTwice_thatAllUpdatesAppliedWithoutException

I originally fixed the crash by "staggering" duped delete index paths (see function in IGListBatchUpdateData), but that revealed another bug when reloads (which are converted to delete+insert) collide w/ actual deletes. In that case we want to drop the reload entirely. Fixing this required introducing another data structure, IGListReloadIndexPath.
Issue fixed: #651
Internal tasks t17306420, t17422443
Checklist

[x] All tests pass. Demo project builds and runs.
[x] I added tests, an experiment, or detailed why my change isn't tested.
[ ] I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.

Test failed b/c of timeout

I don't completely understand how this won't cause other items to be deleted within a section that has duplicate deletes for the same index path.

Ok backing out my "stagger" idea b/c if you delete the last item twice you will delete something that doesn't exist.
Maybe we could change the API so it validates that deletes are within the range of [collectionView numberOfItemsInSection:section]?
Changing deletes back to NSSet leaves us open to data inconsistency crashes...

Eating my words, I want to fix this for real. Going to need to get clever. Dang u collection view.

could we just bounds-check the "double delete" case and ignore the second delete?

@jessesquires If we drop one of the deletes but a data source is updated assuming 2 deletes are applied, UICV will throw for inconsistency.

Ok stopgap solution for now:

Restore the delete test with a FIXME prefix so it doesn't run
File an issue that this is a known problem
Land this PR with NSSet to dedupe delete operations

We've survived shipping IGListKit on Instagram for over a year w/out this, so we're in no hurry to get this totally working. However w/out a fix this is crashing now and causing tests to fail. Let's get this cleaned up and working for now.

Importing to get internal CI running on this, not landing


Ensure data upload dir present

Context
As part of the AWS migration of support-api, there is a need to deploy the support-api app on the Backend boxes but unfortunately the puppet run fails because /data/uploads directory is not present.
Decisions

Ensure the directory is created in puppet code

Closed because asset-manager is now deployed via puppet after terraforming the project.


Pin the Python version in notebooks

not needed if we all use the same kernel:
Python 3 (Data Science) or Python 3 (Base)


Django Chatterbot Clear Database

If I am using django chatterbot, how do I remove all the training data. How do I drop the storage in this case?
How to get the current instance of chatterbot?

There could be a in your current directory with name sqlite.db, you could drop the file, and start train your bot.


page.deleteCookie() not working (?)

OS : Windows 10 64 bit all updated
Node : v12.13.0
Puppeteer : 2.0.0
Temptative : delete a cookie.
What chromium see :

what i want to do :
delete the cookies named ".ASPXFORMSSD"
my code
beforeEach(async () => {
        console.log("cookies was")
        let before = await page.cookies()
        before.forEach(cookie => {
            console.log(cookie.name)
        })

        await page.deleteCookie({
            name : ".ASPXFORMSSD",
            domain : "integration.solutiondocondemand.com"
        })

        console.log("cookies are")
        let after = await page.cookies()
        after.forEach(cookie => {
            console.log(cookie.name)
        })

        await helpers.loadUrl(page, config.baseUrl)
    })

obtained : cookie is not deleted
the log :
console.log test/loginPage.test.js:21
cookies was
console.log test/loginPage.test.js:24
.ASPXFORMSSD
console.log test/loginPage.test.js:24
ASP.NET_SessionId
console.log test/loginPage.test.js:32
cookies are
console.log test/loginPage.test.js:35
.ASPXFORMSSD
console.log test/loginPage.test.js:35
ASP.NET_SessionId

Removing ASP.NET_SessionId does work right?

my fault.
the domain was not the correct one.
test were pointing to another test environment.
i suggest to print also the cookie.domain to be sure about the cookie domain.

I use this to remove all cookies:
	async clearBrowser () {
		// clear cookies
		const client = await this.page.target().createCDPSession()
		await await client.send('Network.clearBrowserCookies')
	}

I use this to remove all cookies:
	async clearBrowser () {
		// clear cookies
		const client = await this.page.target().createCDPSession()
	        await client.send('Network.clearBrowserCookies')
	}

Thank you, It works


Check for Development Status classifier

I think it is a good indicator to evaluate a package. Consider adding it to the checks.
With such a check you would have seen that it is missing in your own package (https://github.com/regebro/pyroma/issues/25)!

Yeah, that makes sense.


Gathering supplementary data

Hi Patrice,
Do you know how to access the supplementary text files linked into the paper? A lot of my word searches end up needed to access the supplementary texts.
Thanks!

Hello @grace-reed
Normally supplementary sections present in the paper are identified as "annex" but without explicit typing.
Reference to associated external supplementary data (with distinct metadata/publication information, e.g. doi) are not identified currently, but it would be very nice to cover it indeed.


Implement new notifications UX

Implementation task of https://github.com/Microsoft/vscode/issues/22388

This landed via https://github.com/Microsoft/vscode/pull/43770 and can be tried out in our preview release: https://code.visualstudio.com/insiders/


Problem with fine-grain classification

In fine-grained mode, dev percentage is more than 80% in my test, but the result in paper is about 50%. I just wonder how to test the fine-grained classification correctly, thx~

well, it should like in paper ... :|
but i haven't focus on fine grained for a while

thanks, I solve it by remove those preprocess data. And binary/fine-grain classification work with result as in original paper


Make forward slash at beginning optional

In the old client, the forward slash at the beginning of the source path was optional.  We should carry that forward so the transition is easier.

As in, someone could simply write bbockelm/foo/bar instead of /bbockelm/foo/bar?
We should emit a warning if the forward slash is missing and include a formal deprecation timeline in the warning.

More like user/bbockelm/foo/bar, still have to start with user, but, yes.

Merged in #37


docs for Sample's target parameter not consistent with code

In docstring and in documentation page, we have target (str | list[str] | None).  But using target = None when creating a Sample object gives validation error.  Presumbly because in the code, None is not a possible type: target: str | list[str] = Field(default="")

Thanks! Will be addressed in our next sync.

Resolved with https://github.com/UKGovernmentBEIS/inspect_ai/commit/2d7561f02213781d603ed4ff1826f8dfe0963da4


Ambient waypoint 2.0 xDS design

As part of https://docs.google.com/document/d/1DAM_6SajCyC2hD8wBUraaZWZJqUVYPyemzw0-xpHmdY/edit#heading=h.qntbxk5xx45, we need to tweak the xDS config for Istio waypoints.
There will be two modes (maybe): PROXY sandwich and native HBONE.
Both of these are largely the same 2 tier routing, just slightly different first tier.
A nice goal would be to re-use as much of the existing Gateway xDS generation as possible, though we  won't get 100%.
Proposal:
First tier routing needs to pick a service and port destination. For HBONE, this will be HTTP hostname header matches (just like waypoint today). For PROXY, this will be on the TLV.
For HBONE:
connect_terminate:
  Terminate CONNECT
  Single filter chain, terminating TLS and sending through HCM
  Single route, terminating CONNECT, sending to main_internal
main_internal:
  Multiple filter chains, one per service-port
  Matcher tree: Match IP -> Match port -> (if required, sniffed) Match Protocol

For PROXY:
proxy_terminate:
  Listener filter for PROXY termination. TLV sets metadata for destination IP/port
  Multiple filter chains, one per service-port
  Matcher tree: Match IP (from TLV) -> Match port (from TLV) -> (if required, sniffed) Match Protocol

cc @stevenctl @louiscryan

Prototype here:
Istiod: https://github.com/istio/istio/pull/49097
zTunnel: https://github.com/istio/ztunnel/pull/789

The xDS changes are pretty small. In PROXY mode:

Don't generate connect_terminate/connect_originate
"proxy_terminate" above is actually identical to main_internal but adds the PROXY filter and binds
Filter chains do set_filter_state using PROXY TLV instead of original_dst

https://github.com/istio/istio/pull/50006


Update the color scheme to bring in better UX for action buttons

@leecalcote @kushthedude situation report for this issue? 😃

I think we stalled out given that we haven't come up with better suggestions in the meantime. Perhaps, we can let the stale bot have this one.

Not stale
On Sat, 31 Oct, 2020, 04:54 stale[bot]<EMAIL_ADDRESS>wrote:

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/layer5io/meshery/issues/134#issuecomment-719842256,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKQMTLXY3C6EYFUJ5XC3OWDSNNDJHANCNFSM4HYMOFYQ
.


Fix broken import causing integration test failures

There is limited to no pty support on Windows, so test cases calling it are skipped on Windows. Turns out that even importing pty can cause bad. This PR changes test behavior to only import pty on non-NT platforms.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b3203ca). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #440   +/-   ##
=========================================
  Coverage          ?   85.08%
=========================================
  Files             ?       39
  Lines             ?     1824
  Branches          ?        0
=========================================
  Hits              ?     1552
  Misses            ?      272
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3203ca...36b711c. Read the comment docs.

https://allspark.dev.data.humancellatlas.org/HumanCellAtlas/dcp-cli/commit/36b711c7813ae78a45a4e3a45367ce84bf56c379


Fix typo in README.md

Checklist

[x] npm install && npm test passes
[ ] tests are included
[x] documentation is changed or added
[x] commit message follows commit guidelines

Description of change

Thanks for the contribution :)

@gengjiawen prefix needs to be added to commit messages and messages should not start with upper-case, same rules as nodejs/node I think.
I'll fix this one up with a doc: fix typo ... and force push, so just for future reference. Thanks for staying on top though.


Error after leave plugin page

When I openned plugin's page and changed right after to another page, I got this error on console and a white screen.
Same behavior within plugin's configuration page.
STRAPI VERSION
v4.20.3
NODE VERSION
v18.19.1

Hi @mrabello23 ,
Thanks for the issue, I will check it.

Hey @mrabello23,
the issue has been fixed ✅ in v1.0.9.
I also would like to say that a major update will be coming this weekend I am working on it.

Hey @everythinginjs
I really appreciate it, thanks you!


proton-ge-bin: GE-Proton9-15 -> GE-Proton9-16

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Dup of https://github.com/NixOS/nixpkgs/pull/351165


Typo: drawbacks should be one word

Coverage remained the same at 99.317% when pulling e6df66a51af1590ba08c04202f0fd0360c011abf on kylebarron:patch-1 into a461213ba294672f376f10e452a9fbfdb0644508 on uber:master.


opcode naming is invalid (starts with a capital letter)

I'm getting this:
seq > @
      *
        label
          "9456b178-9c9f-4b44-9657-dc689e32a312"
        opcode > ALOAD-1
          25
          0
        opcode > INVOKESPECIAL-2
          183
          "java/lang/Object"
          "<init>"
          "()V"

In EO, we can't have names like this: ALOAD-1 or INVOKESPECIAL-2. The first letter must be small, maybe: oALOAD-1 or oINVOKESPECIAL-2.

@volodya-lombrozo please, check

This issue was solved here: https://github.com/objectionary/jeo-maven-plugin/issues/678


command 'markdown.extension.xxx' not found

What is the problem?
command 'markdown.extension.xxx' not found
How can I reproduce it?
vscode v1.23.1
markdown All in One v1.5.0
Is there any error message in the console?
Ctrl+B: command 'markdown.extension.editing.toggleBold' not found
Backspace: command 'markdown.extension.onBackspaceKey' not found
Enter: command 'markdown.extension.onEnterKey' not found
......

Please see #214.

When typing Ctrl+B，console doesn't  output anything

This is version of VSCode

I cannot find an old version of vscode (v1.23.1) to test. You might need to update your vscode to v1.24.0.

It works after upgrading to v1.24.1，thanks!

@neilsustc I had the same problem with v1.22.x
In case you need older versions you can get them through the release announcements:
https://code.visualstudio.com/updates/v1_23
Just update the version and you should be to retrieve an older version.
Thank you for building this very helpful extension! 👏

@pxlpnk Really useful information, thank you.


Suggestion to add a One PR per file change to Workflow

Need to reopen accidentally hit the open issue button.


How to use this module?

Usage confusion
I am a little bit confused about the usage of this module.
Should I use it like so:
module "terraform_aws_vault" {
  source = "github.com/hashicorp/terraform-aws-vault?ref=v0.10.3"

  ...
}

But then it won't allow me to customize security groups, however in your main.tf it clearly states:

# To make testing easier, we allow Consul and SSH requests from any IP address
# here but in a production deployment, we strongly recommend you limit this to the
# IP address ranges of known, trusted servers inside your VPC.

Or am I supposed to copy main.tf, variables.tf and outputs.tf locally and create my own module based on the submodules you provide in the modules/ directory?
Something like this:
module "vault_cluster" {
  source = "github.com/hashicorp/terraform-aws-vault//modules/vault-cluster?ref=v0.0.1"
  ...
}
module "consul_iam_policies_servers" {
  source = "github.com/hashicorp/terraform-aws-consul//modules/consul-iam-policies?ref=v0.4.0"
  ...
}
module "security_group_rules" {
  source = "github.com/hashicorp/terraform-aws-consul.git//modules/consul-client-security-group-rules?ref=v0.4.0"
  ...
}
module "vault_elb" {
  source = "github.com/hashicorp/terraform-aws-vault//modules/vault-elb?ref=v0.0.1"
  ...
}
module "consul_cluster" {
  source = "github.com/hashicorp/terraform-aws-consul//modules/consul-cluster?ref=v0.4.0"
  ...
}
...

Edit
I was simply looking for something like this as a general guidance for how to actually use this module: https://github.com/terraform-aws-modules/terraform-aws-vpc#usage
Thanks

Or am I supposed to copy main.tf, variables.tf and outputs.tf locally and create my own module based on the submodules you provide in the modules/ directory?

Yes. The module you want to use is in fact the vault_cluster module located at /modules. The main.tf at this root dir is just one example on how to use it. There are other examples located at /examples


Update save method

Update Classfifier.save() method and add a save() method for FileObjectStore class to make the Classfifier.save() method  runable

Looks good to me, thanks @Qukaiyi !


Composer Update - ReflectionException - ClientCreatorCommand does not exis

I updated to the latest dev version (4.0.x@dev) this morning via composer and received this error:
[ReflectionException]
  Class LucaDegasperi\OAuth2Server\Console\ClientCreatorCommand does not exist

Script php artisan clear-compiled handling the post-update-cmd event returned with an error

I went from dev-master 7c94eef to dev-master 171fac7.
Everything I'm working on seems to be working still, but just thought I'd let you know incase it break's anything else for anyone else.

Had no problem on my install when updating the package after I removed the command.

I double checked and realised the problem is on my end. Thanks for the quick response and sorry for any confusion caused.

@iamthewit Could you tell me your solution here? I'm stuck with the same.

@maulsea sure, as I followed the setup on the wiki (https://github.com/lucadegasperi/oauth2-server-laravel/wiki/Laravel-5-Installation#command-to-create-clientid-and-clientsecret) to add the command to  generate clientIDs and clientSecrets, all I had to do was remove this line from Kernel.php:
 'LucaDegasperi\OAuth2Server\Console\ClientCreatorCommand',

Hope that helps.
@lucadegasperi If you are removing the command from the project, maybe you could update the wiki to match?

I just figured. Thanks for your follow up though! :-)
On 22-Apr-2015 2:27 am, "iamthewit"<EMAIL_ADDRESS>wrote:

@maulsea https://github.com/maulsea sure, as I followed the setup on
the wiki (
https://github.com/lucadegasperi/oauth2-server-laravel/wiki/Laravel-5-Installation#command-to-create-clientid-and-clientsecret)
to add the command to generate clientIDs and clientSecrets, all I had to do
was remove this line from Kernel.php:
'LucaDegasperi\OAuth2Server\Console\ClientCreatorCommand',
Hope that helps.
@lucadegasperi https://github.com/lucadegasperi If you are removing the
command from the project, maybe you could update the wiki to match?
—
Reply to this email directly or view it on GitHub
https://github.com/lucadegasperi/oauth2-server-laravel/issues/355#issuecomment-94941206
.

@iamthewit yes, will remove it from the L5 Wiki pages.


Make return structure for "Get Multiple..." type APIs consistent

Get-Multiple APIs have a JSON response structure of with a single entry whose value is a list containing the actual requested items as dictionaries. The audio_features function in client.py was adapted to unwrap the single value in commit 9c0b872e86db479b1ba38a826a7f1f77fa3d68b8, but other functions for similar APIs (eg. tracks, artists, albums, ...) have not been adapted, leading to an inconsistent structure in the returned dictionary. This change modifies those functions to handle the response similar to audio_features.

Thanks for your PR, however I don't think we want this:

https://github.com/plamere/spotipy/commit/9c0b872e86db479b1ba38a826a7f1f77fa3d68b8 looks wrong to me, as according to the doc of that endpoint we expect audio_features, not audio_attributes.
the above not being useful, it would be wrong to adapt other endpoints to it
the change would be backward-incompatible, as current apps are expecting such intermediary fields. You could still raise this in the discussion about spotipy3 https://github.com/plamere/spotipy/issues/652 so we can discuss it, but keep in mind that spotipy's philosophy is to remain "light" and to avoid modifying the resulting JSON


Attributes starting with accent in React Components (.jsx / JavaScript React)

VSCode Version: 1.25.1
OS Version: Mac 10.13.6
Theme: Monokai (issue occurs with any theme)

Steps to Reproduce:

Create a react component with jsx
Pass attributes starting with accents like ícone, ônibus, àrea

Does this issue occur when all extensions are disabled?: Yes

This issue was moved to Microsoft/TypeScript-TmLanguage#640


fix: readme import alias

@fbernaly
I was using the google_mlkit_image_labeling just a little error on the readme
thanks

Thanks @bensonarafat


Add async support

Scrapy now supports calling async methods from many components. It would be great to provide the option to call Scrapinghub API using async methods to avoid either blocking calls or having to work with twisted deferreds and threads.
In order to do that, there are several design decisions that needs to be taken:
Define Async interface

Do we add an async version for each method already available?
Do we create an AsyncScrapinghubClient that only provides support for async methods?

How to implement async methods

Python coroutines
asyncio coroutines

Possible obstacles?
If we want to use python-scrapinghub in standalone mode, will it create their own task loop? or should it expect it to be already created?
If we run it inside Scrapy, could this cause conflict issues?
I don't have much experience designing async libs so It would be great if someone with a better understanding could provide some pointers here.

If we want to use python-scrapinghub in standalone mode, will it create their own task loop?

asyncio.get_running_loop() should be fine, but I'm not sure about interop with Scrapy Twisted. Because asyncio is still optional for Scrapy, many users would use Twisted, and there might be conflicts asyncio with Twisted. Still I'm not sure we need to worry too much about it because there are several use cases of python-scrapinghub and many are outside Scrapy. If async would be optional users can simply opt-out and use blocking version without worries.
I guess main problem will be that async API will be breaking for many applications. You will have to call await before each method call, users would have to update their code. It would be nice to have just one way of doing things, and make library async by default, but for backward compatibility it might make more sense to have async and non async at the same time. This will add complexity and require more development effort to maintain.

I guess main problem will be that async API will be breaking for many applications

That's right, my ideas is to keep offering the old interface and allow people to migrate to the new one if they want.

So maybe indeed separate client would be better? Then we could phase out this library and replace it with new client.

Do you think it would be better to create a new library instead? I was reviewing the code and I found lot of legacy code which I'm not sure if it's still used anywhere. That would make adding new features inside this package much more difficult.

Using the asyncio reactor in Scrapy should not be an issue, and we are promoting the asyncio Twisted reactor in Scrapy at the moment (the settings.py file generated by scrapy startproject sets the asyncio reactor).
I don’t think maintaining both interfaces, sync and async, in the same library, will add complexity. If anything, it will remove it. We can implement new features only in the async interface, to avoid duplicate work. Or we can port them to the sync interface but have the sync interface basically call the asyncio code. In any case, I would keep it in the same library.

I think if the interface is the same or similar, it makes sense to have it a single library.
If API is significantly different, then a separate library looks good to me. It also allows to have separate releases, etc., and it makes it easier to justify not supporting all the features from the day 1, which could be an expectation from the users.
I'm thinking about an example of scrapy-autoextract library, where we provided 2 ways of integration, and it seems it caused nothing but confusion.

Well, another point for the separate library is that it gives us a chance for rebranding, i.e. python-zyte-scrapycloud.

If we scope the lib to the APIs of Scrapy Cloud then it should be python-scrapycloud or python-zyte-scrapycloud as @Gallaecio  proposes.
Also, given that we are still using the endpoints app.scrapinghub.com and storage.scrapinghub.com someone could argue that it makes sense to keep scrapinghub in the name. However, I think we shouldn't link the endpoint name to the library name.

Maybe, you could consider Niquests as part of the solution?
I am willing to help on the subject.


When suppressOthersusedByLayers:... is sent to a class nothing is displayed

Handle the case when RWDiagram suppressOthersUsedByLayers: 1 usingLayers: 1 to: self. is sent to a class.
Currently nothing is displayed at all.
A message should occur and no effect should take place. In a later change this feature should be supported.

The error occurs in RWDiagramLayout>>isModelElementNotShownWithChildren
at:
ifTrue: [ aRWDiagramElement famixElement class asString = self aFAMIXPackage
ifTrue: [ aRWDiagramElement famixElement classes
In case of Java the diagramelement for the package is created and not part of the extracted model.
This "generated" package does not contain the contained classes.


fix: Unsupported operation: onConfigUpdated is not supported for web

Describe the bug
Error occurs because RemoteConfig's onConfigUpdated is not available on the web
To Reproduce
Using the FilterFireRemoteParameterFetcher in Web Apps
Expected behavior
For the Web, functionality should be limited and error-free.
Screenshots
none.
Desktop (please complete the following information):

Browser: chrome

Smartphone (please complete the following information):
none.
Additional context
none.

There are other methods that can be used and should not be published for the web.


Problems with multiple generics in actix?

Hey,
I recently wanted to use a new validation library in my backend.
Unfortunately Utopie panics when executing the path macro.
I do not know if the issue is here or at the 3rd party library.
More information and an example to reproduce can be found here: https://github.com/ranger-ross/actix-web-validation/issues/16

Fix is on the way for this good finding and thanks for reporting it here as well.

Fix is on the way for this good finding and thanks for reporting it here as well.

Thanks
Hope a new version is released soon

@DenuxPlays heres the next pre-release with the fix: https://github.com/juhaku/utoipa/releases/tag/utoipa-5.0.0-alpha.1


Organize templates into subfolders

Resolved via https://github.com/bst-mug/trec-pm/commit/e297e35924b55b237fdbae3d86c37dc36863394f


code --status fails on windows

open vscode workspace
code-insiders --status

This the output I get. It works fine on stable.

@dbaeumer I also got this on Windows just now and it looks like cleanUNCPrefix  might get undefined or null as value?

One thing I did is I ran "code --status" using our EXE directly and not our CMD file, that might have an impact?

@bpasero this was my analysis as well: see https://github.com/Microsoft/vscode/issues/41754#issuecomment-358578385
The problem is that this can only happen if the command line is not existing and this can actually not happen with any VS Code processes. So I was curious why this happens. Can you reproduce?

@dbaeumer tried again and now I cannot reproduce.


Policy configuration failure due to MTU is not reflected to the user

Downstream bug: https://bugzilla.redhat.com/1812559

Fixed now!


Use of Array.prototype.some in matchRoutes

Hi, I just wanted to ask, but couldn't find any issue or doc that clarifies it: is use of some method here intentional? This way it works the same as switch, because some will break after matching first route. In result - we can get maximum one matched route per branch. Potentially there could be more of them in routes array.
https://github.com/ReactTraining/react-router/blob/e634f0bad7796d128a4c4e2c4678487dd7256be2/packages/react-router-config/modules/matchRoutes.js#L4

Ok, my searching skills are not that great, sorry. :sweat_smile: Have been discussed a few times, current PR #6577


Clarify requirements on property names

This change clarifies the requirements on property names when using property dereference syntax.
Why:
The explanation for the syntax of property names in unclear.  It currently reads:

In order to use property dereference syntax, the property name must:

start with a-Z or _.
be followed by a-Z 0-9 - or _.

This could easily be read as only specifying requirements on the first and second characters of a property name.  Moreover, taken literally, it rules out the possibility of one-character property names.
The explanation in the section https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_id describing the required format of a job id (for example) is clearer—

The <job_id> must start with a letter or _ and contain only alphanumeric characters, -, or _.

—and I have adopted it here (suitably adapted).

What's being changed:

Check off the following:

[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@gsrohde Thanks so much for opening a PR! I'll get this triaged for review ✨


Feature add project manager support

This is @danielbrodin's PR #10 from postcasio/custom-title project. All credit goes to @danielbrodin.
Also my first PR attempt, so please let me know if I did something incorrectly.

As an aside, this is the configured format string I use:
<% if (projectName) { %> <%= projectName %> <% } %><% if (gitHead) { %> [ ⛕<%= gitHead %> ] <% } %> <%= fileName %><% if (filePath) { %> - <%= filePath %> <% } %>


Test rav1d against Argon test vectors

Argon test vectors download link. More info here.
This takes a long time so we might want to schedule this as an overnight job.
Run this for x86-64 only or for other targets as well?
Blocked on #213
dav1d contains a helpful script tests/dav1d_argon.bash that we might want to cherry pick into this repo.

Running dav1d_argon.bash takes about 4 minutes on my test machine with the default settings. If testing all cpumask values, it's probably closer to half an hour. Interestingly I didn't run into #213

If it only takes ~4 minutes, I can run it locally before every PR at least.  I'm not sure how much slower CI is.

4 minutes was observed on an 8-core machine. I can actually get it down to 100 seconds when processing multiple test streams in parallel with -j 16

I'm not sure how much slower CI is.
4 minutes was observed on an 8-core machine.

The CI machines are substantially slower since we only get two (virtual) CPUs. Here is an example https://github.com/memorysafety/rav1d/actions/runs/4893817220

debug w/assembly takes 1h12m
release w/o assembly takes 32m

This is when passing -j $NUM_vCPU to dav1d_argon.bash IIRC. The CI builds also need time to download and unpack or cache the tests. Once I hook up a self-hosted runner to test AVX512, we can try switch to running Argon for each PR.

Interestingly I didn't run into https://github.com/memorysafety/rav1d/issues/213

Interesting indeed. I hit it reliably on the 12-core Ryzen 5900X we're using. Same when building the C sources.


Fix typos in the documentation

Fix Zipkin and InfluxDB capitalization as per their respective webpage, and also some minor typos.

This change is

Thanks for your contribution :)

Thanks for your contribution :)


Non-webp fall back?

Thanks again for this great tool.
Testing a site im working on in an old iOS safari doesnt seem to support specifically the transparent webp. Isnt it supposed to fallback to the original image if webp isnt supported? If not is there anyway to configure that?

Hey @Lastofthefirst
Yes that should be the behaviour! Could you do me a favour and test how the standard Next.js image component behaves in this case?

Do I understand right that you mean to try using the default image component from next and have a jpg or png as well as some webp in the srcset? Then test on this iphone?
Also when I examine using the version you've made I don't see any non webp in the srcset:
srcset="/nextImageExportOptimizer/old-paper.d520b480-opt-16.WEBP 16w, /nextImageExportOptimizer/old-paper.d520b480-opt-32.WEBP 32w, /nextImageExportOptimizer/old-paper.d520b480-opt-48.WEBP 48w, /nextImageExportOptimizer/old-paper.d520b480-opt-64.WEBP 64w, /nextImageExportOptimizer/old-paper.d520b480-opt-96.WEBP 96w, /nextImageExportOptimizer/old-paper.d520b480-opt-128.WEBP 128w, /nextImageExportOptimizer/old-paper.d520b480-opt-256.WEBP 256w, /nextImageExportOptimizer/old-paper.d520b480-opt-384.WEBP 384w, /nextImageExportOptimizer/old-paper.d520b480-opt-640.WEBP 640w, /nextImageExportOptimizer/old-paper.d520b480-opt-750.WEBP 750w, /nextImageExportOptimizer/old-paper.d520b480-opt-828.WEBP 828w, /nextImageExportOptimizer/old-paper.d520b480-opt-1080.WEBP 1080w, /nextImageExportOptimizer/old-paper.d520b480-opt-1200.WEBP 1200w, /nextImageExportOptimizer/old-paper.d520b480-opt-1920.WEBP 1920w, /nextImageExportOptimizer/old-paper.d520b480-opt-1920.WEBP 2048w, /nextImageExportOptimizer/old-paper.d520b480-opt-1920.WEBP 3840w"

The exportedImage code has an error check that will return the original src in a case the optimized srcset image fails to load.
Regarding the testing: as I think of it, probably it cannot be tested with Next.js image component as they check the supported features of the browser dynamically and return an appropriate image format.

The dev console/web inspector for the iOs safari doesnt seem to be working, presumably the iOS safari version is to old. the OS version is just 14.8.1 so not that old... I'm not sure.

@Niels-IO sorry to keep bothering you! But now it seems like the behavior I'm getting is the largest version of each image being loaded instead of the smallest for the viewport. Could that be so? Maybe that also would explain the fallback not working (say if files were listed in reverse order, that would cause css to fail at least). Here are two sites I'm testing with: https://ridvan.org https://bahaisofsumtercounty.com
I tried looking at the network tab in incognito to see if I was just observing caching, but behavior seems to be the same. I don't think I changed any settings aside from upgrading to 1.4.0.

Hi @Lastofthefirst
Could you share how you defined the ExportedImage component for the images on https://ridvan.org/articles/brown-and-kirk so that I can look into it, please?

Here are the images from that page:
<ExportedImage
        src={vid}
        alt="A snapshot of brownandkirk.com."
        useWebp={process.env.nextImageExportOptimizer_storePicturesInWEBP}
        placeholder="blur"
        quality={100}
      />

 <ExportedImage
        src={lighthouse}
        alt="Lighthouse audit results for the website."
        useWebp={process.env.nextImageExportOptimizer_storePicturesInWEBP}
        placeholder="blur"
        quality={100}
      />

Heres the background one as well:

    <ExportedImage

          src={stars}
          alt=""
          width="100vw"
          height="auto"
          className="absolute right-0 left-0 -top-10 z-0 pointer-events-none"
          useWebp={process.env.nextImageExportOptimizer_storePicturesInWEBP}
          placeholder="blur"
          loading='lazy'
          quality={75}
        />

The image in the header seems to be working as expected.

My guess is:
As you didn't specify any size behavior, next.js at export time will just produce the next largest width from the imageSizes array that matches the original image width and generates this srcset:

When you specify fill, you also have to specify sizes for small images. Otherwise, Next.js will use the viewport width to choose which image to load. So using fill without sizes only makes sense for large images that span the whole viewport width.
This is an example taken from https://nextjs.org/docs/api-reference/next/image:
For example, if you know your styling will cause an image to be full-width on mobile devices, in a 2-column layout on tablets, and a 3-column layout on desktop displays, you should include a sizes property such as the following:

import Image from 'next/image'
const Example = () => (

    <Image
      src="/example.png"
      fill
      sizes="(max-width: 768px) 100vw,
              (max-width: 1200px) 50vw,
              33vw"
    />

)

Ok thanks, I guess I fundamentally misunderstood how this worked. ¯\_(ツ)_/¯
Its still very useful of course, thank you for your help.

I will close this issue because I cannot test the Safari misbehavior.


Restore cubic resampling to avoid noisy artefacts caused by average resampling

Due to https://github.com/opendatacube/datacube-core/issues/1448, we had to temporarily switch to "average" resampling.
However, tried adding a hillshade to "average" resampled data, but it came out grainy and noisy with lots of vertical/horizontal artefacts across the image:

Running the elevation code with our original "cubic" resampling looks so much nicer - smooth with no obvious vertical/horizontal artefacts:

We should switch back to "cubic" when this fix is available in datacube-core.

Closed by #28


[match] need to encrypt before save

Fixes #13542
Problem/Solution

Need to decrypt before nuking so that we can inspect profiles for the correct UUID
Also need encrypt before saving

👍