Add ...ArgumentToPSVersionTransformationAttribute] to list of patterns to remove for generated ref assembly

PR Summary
A new private attribute was added so we need to remove it from the generated SMA.cs used for the reference assembly as this results in a build break creating the nupkg for the ref assembly.
PR Context
PR https://github.com/PowerShell/PowerShell/pull/15853 made a change to rename an attribute which is private.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

Stop texting me these messages please !
Sent from Yahoo Mail on Android
On Thu, Nov 18, 2021 at 5:32 PM, Steve @.***> wrote:
PR Summary
A new private attribute was added so we need to remove it from the generated SMA.cs used for the reference assembly.
PR Context
PR #15853 made a change to rename an attribute which is private.
PR Checklist

PR has a meaningful title

Use the present tense and imperative mood when describing your changes

Summarized changes

Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header

This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

None
OR
Experimental feature(s) needed

Experimental feature name(s):

User-facing changes

Not Applicable
OR
Documentation needed

Issue filed:

Testing - New and feature

N/A or can only be tested interactively
OR
Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

Issue filed:

Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

Issue filed:

Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

Issue filed:

Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Issue filed:

You can view, comment on, or merge this pull request online at:
https://github.com/PowerShell/PowerShell/pull/16489
Commit Summary

d913af2 Add [Microsoft.PowerShell.Commands.SetStrictModeCommand.ArgumentToPSVersionTransformationAttribute] to list of patterns to remove for generated ref assembly

File Changes
(1 file)

M tools/packaging/packaging.psm1 (1)

Patch Links:

https://github.com/PowerShell/PowerShell/pull/16489.patch
https://github.com/PowerShell/PowerShell/pull/16489.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Merging with Windows Packaging CI failing as it is unrelated. This change also unblocks daily release build.


Release v0.3.3

Pull Request Test Coverage Report for Build 8913e91ced37a8df3112a33feaddf36f7690cf4c-PR-61

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 20876df4b9e86d19fe7f37a997e3d8cfe8d11968:
0.0%

Covered Lines:
302

Relevant Lines:
302

💛  - Coveralls


quetion about the loss and grad of "mbr"

https://github.com/hirofumi0810/neural_sp/blob/2b10b9cc4bdecb5180ecc45575c0ef410fb09aa3/neural_sp/models/seq2seq/decoders/las.py#L535-L548
I don't know much about mbr, according to these lines, it looks like a mWER loss and gradient to me

@Cescfangs yes

@Cescfangs yes

Thanks for the reply, and I'm curious about the improvement of this mWER tuning, say 5% relative wer reduction?

https://github.com/hirofumi0810/neural_sp/blob/2b10b9cc4bdecb5180ecc45575c0ef410fb09aa3/neural_sp/models/criterion.py#L12-L39
Also, I am a little confused about the “mbr” loss, the inputs are not used in backward function, how does the grad flow to model params?


Display glitch in Search component

There is an edge case in the Search component:

Enter some whitespace in the search with expandable=true
Blur the Search (focus something else or using JS)
The Search collapses but the clear button stays visible.

Screenshot:

This is due to the fact that the visibility of the clear button is decided by value === '':
https://github.com/carbon-design-system/carbon-components-svelte/blob/ba27830b2f6ad1fb2c8cc7dc1a8c833cf9e236d0/src/Search/Search.svelte#L162-L162
However the search is collapsed when the trimmed value is empty:
https://github.com/carbon-design-system/carbon-components-svelte/blob/ba27830b2f6ad1fb2c8cc7dc1a8c833cf9e236d0/src/Search/Search.svelte#L142-L146
Possible fixes:

Do not collapse when the value is whitespace only.
On blur, clear the value if it's whitespace only. However this mutates the user input, which could be whitespace intentionally.
Hide the clear button when expanded is false. Again this might hide the search when the contained value is whitespace.

The first version sounds the most consistent with API to me. Users can choose to clear the value if its empty on blur manually.
I can do a PR if this sounds good.

Yes – PRs always welcome.


#121 As a user, I want the ability to hide inactive tabs via CSS inst…

complete task #121

Thanks!


Source Control side panel input treated as editor instead of workbench

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

Change the following settings in your settings.json file:

"workbench.colorCustomizations": {
  "selection.background": "#ff0000"
}

Navigate to the side panel and open the "Extensions" panel.
In the search input, write anything and select the whole text (use the mouse or Ctrl+A)
Note how the selection background is colored red.
Navigate to the side panel and open the "Source Control" panel
In the message input, write anything and select the whole text (use the mouse or Ctrl+A)
Note how the selection background is not red.
To actually change the background of the selected text in the "Source Control" panel, change the following settings in your settings.json file:

"workbench.colorCustomizations": {
  "editor.selectionBackground": "#ff0000"
}

Repeat steps 5-7 and note how now the selection background is red now.

The issue seems to be that the message input in the "Source Control" panel is treated as "editor" instead of as part of the workbench. This also happens in the input box for "Github Copilot" (Chat: Open Chat in Editor). Lastly, the background color of the inputs when text is selected and loses focus changes.

This issue is particularly annoying if you're using Horizon as your theme since it makes it impossible to select text (input and selection background colors end up being the same)


Fix formatting for ricemedia article post

Test

https://www.reddit.com/r/rsgretrivr/comments/ca9ld1/a_rooftop_party_where_aunties_and_ang_mohs_rock/

@fterh for your review.


Crashing on Startup

Bug report
Description
I closed the program temporarily so that I may open a different game.
Expected behavior
The program would close and I would reopen it at some other time.
Actual behavior
The program closed, and then started crashing on startup, consistently.
Steps to reproduce
Press that nice little X button on the window.

ASF is farming cards for you where is the problem?

The problem is that it won't launch you twit..

Keep in mind that IPC works with SteamOwnerID, so if you want to use it you must provide a valid value here.

Before you open an issue please review the contributing guidelines for this repository.

https://github.com/JustArchi/ArchiSteamFarm/blob/master/.github/CONTRIBUTING.md

If my issue is not meeting contributing guidelines specified above, especially if it's a question or technical issue that is not related to ASF development in any way, please close it immediately - I won't complain.

Reason for closing: technical issue is not ASF bug.


Update tests for 0x 4.6.

Checks that a nonzero exit code does not prevent collecting data.
0x still handles signals differently from the other tools, I think—it should throw an error for SIGKILL but doesn't currently do that. I added a skipped test for it so we can fix it later.

Awesome, thanks, LGTM
I'll merge this then update and merge https://github.com/nearform/node-clinic-flame/pull/39


Page for a specific genre contains "Chants by genre" in OldCantus, but only the genre name in NewCantus

Steps:

Pick a manuscript;
Pick a folio;
Click on any "Genre" abbreviation hyperlink (you can only do this in NewCantus).

OR

Pick a feast;
Click on any "Genre" abbreviation hyperlink.

On OldCantus, this leads you to a page about that genre, which contains a list of all the chants that belong to that genre. In NewCantus, the page only has the genre name, and nothing else.
Demo (using the feast route in OldCantus, then NewCantus):
https://github.com/DDMAL/CantusDB/assets/83373378/15c2d683-f9a7-45b0-892a-752b8fcd886a

My bad! I see this has been dealt with. Closing issue.

No,  I think you were right to point this out, because there are actually several things that could or should be done here:
-NewCantus leads to this "Genre" pages in places where OldCantus does not. These should probably go away.
Then either:
-Leave those places where you can get to the genre page, but have something show when you get there (a list of all genres, a set of samples,whatever--not a blank page) or
-Eliminate the links to the genre pages entirely

Let me see if I understand what's going on. There are two distinct differences, right?:

There are several places in NewCantus where we display links to Genre Detail pages, and OldCantus doesn't contain links in the corresponding places

I've been adding links to genre/office/feast detail pages as I come across places where genres/offices/feasts are displayed. I'd been thinking of this as me being helpful, but if you think it would be best, we can go back and get rid of them.  (I don't think this would be a good use of time, though - greater connectivity/more links is generally better in my philosophy, as long as they go where you expect them to)

On the Genre Detail page on OldCantus, there is a list of chants by genre. NewCantus's Genre Detail pages don't have this list

if I recall, this list was not on OldCantus until recently, which was why I thought #536 was justified. But if OldCantus has this, we can put it back in - with what I know now, there are probably optimizations we can apply to make the page load faster than it did. I'll open an issue.

Yes, there are two things. Issue 2 was confusing me, because I thought there was no list of chants by genre on OldCantus, and I wasn't sure if I simply hadn't come across it or if it was newly added or what. It doesn't seem to me like a very useful page in its current incarnation,  so it's probably worth checking if this page is coming or going, so to speak.

In an email discussion with Debra, she expressed that it is fine if we leave this without the list of Cantus IDs for the time being. We may want to implement it eventually if we can make the page load quickly, but it's a low priority for now.


added bosesoundtouch adapter to sources-dist.json (latest)

Hope, that everything is set up correctly.
Testing is successfully set up up and running on Travis-CI, but not for Appveyor.

Thank you for the new adapter!
Please add License file, like this one: https://github.com/ioBroker/ioBroker.admin/blob/master/LICENSE

And add Bluefox to npm owners if not already done
https://github.com/ioBroker/ioBroker.repositories#add-owner-to-packet


transport auto not working after 3.0.36 when saving as option

Issue description:
I tested a basic color and multicolor field and transport auto is not working even though I have valid output setup. It works with transport refresh, and it also works if I change to theme_mods.
Version used:
Was working in 3.0.36 but just updated to 3.0.42 and not working. I still need to test the in between versions to see when it actually stopped working.
Using theme_mods or options?
Options. Theme mods work.
Code to reproduce the issue (config + field(s))
I will get a stripped down version ASAP, but wanted to get the issue posted incase anyone else sees it already, or can confirm it quicker than I can report back.

Okay I cloned the repo and tested prior to 3.0.36 and it works, but 3.0.36 and after does not work. I'm a bit surprised that i'm the first to report, which makes me things it's my code issue. I'll try to get a basic example together.

Hmm, I thought updating may have wiped my fix for this https://github.com/aristath/kirki/issues/2128 but the issue was closed, did this get rolled in? I tried the temp fix and it didn't fix my issue now.

Ahhh I lied. The fix in #2128 works in 3.0.42. I guess it didn't make it into the plugin? Hoping you can add that in to the next update.

The fix was merged upstream - https://github.com/kirki-framework/module-postMessage/commit/2e5f1ff7806eb51af083d43910bc4ddc10edbce1
That means as things stand it won't make it into the plugin until 4.0

Hello and thank you for reporting this issue.
We are closing most open GitHub issues with the release of Kirki 4 to start fresh with this major release.
If you are still running into issues after you have tested your theme with Kirki 4, please let us know so we can reopen the issue.
Please note that Kirki 3 is no longer actively supported. Moving forward, we will only provide support the very latest version of Kirki.
Thank you for your understanding.
Best,
David


Output one-line error messages

SDK needs to output one-line error messages instead of full traces by default.

I don't know the SDK code perfectly but there are many layers where errors are raised and handled. Often the code will work even if it's not trapped properly because an upper layer will handle it, and will just print the trace.
For example, in #3361 a simple fix makes the trace go away, and the exception is properly raised and handled.
On the other hand, in #3364 a simple fix was rejected because the main developers think it should be handled in a lower level.

fixed in #3399

The traces seem to be gone but we may have reduced the verbosity too much. I'm seeing this in the logs now, without any additional context.

lets keep this closed. i opened a new issue: #3419


Connection to oxe-api issue: getApiURL funcion not dynamic

Design
We designed to expose the oxe-api, oxe-web-admin, oxe-web-community as microservices in a Kubernetes Cluster so not configured in a single VM as expected by the documentation.
Furthermore the oxe-web-community has a different domain than oxe-api, oxe-web-admin.
Problem
We are fencing problem to connect the FE component oxe-web-admin and oxe-web-community to the BE component oxe-api due to the construction of getApiURL function in oxe-web-admin/src/utils/env.jsx & oxe-web-community/src/utils/env.jsx:
return "https://api." + window.location.hostname.replace("www.", "").split(".").slice(1).join(".") + "/";
Question
Would it be possible to make this construction dynamic to define with custom values?

Hi,
The usual way to go through is to add settings that are manageable via the the admin platform. In this case, this wouldn't work as the front-end apps require to fetch the settings, which require to know about the API endpoint.. ^^"
Here are three alternatives:
Configure DNS redirection
The first one would be to configure a DNS redirection. if you have your domains as such:
https://my-api.org
https://my-private-space.org
you could allow communication between the client and the API by configurating a DNS redirection as such:
api.my-private-space.org -> my-api.org
Forked the project
Another solution would be to fork the openXeco repository and edit the utils/env.jsx of the webapps directory (oxe-web-admin and oxe-web-community). It leads to some additional management efforts with the forked and its upstream.
Use the "original" domain organisation
By default, the three endpoints (admin, community and API) are organised as such to be working together:
admin.example.org
community.example.org
api.example.org
It remains to be a solution to comply to this structure.
If you have any other suggestion, I am open to hear about.
Regards

Any update on this @mriccit ?
Thanks

Hello,
thanks for the precious reply.
We are trying to follow the first the suggestion "Configure DNS redirection", if it won't work we will try to follow the "Forked the project" suggestion.
I'll let you know as soon as we have some updates or further requests.
Thanks a lot!

I close this issue as it is.
Don't hesitate to reopen if you want to go further exploring a solution.
Regards


Add a function to extract typed data from SpendableOut's

This PR contains a very easy function that takes a SpendableOut and returns Maybe a datum of a given validator type, if there is a datum and if it can be interpreted as something of that type.
I think that something like this a useful addition to the recent features we added around SpendableOuts.

As we discussed live, I'm reluctant to integrate this function to cooked for now because it is the sign of a possible room for improving our design following the v2 changes. Indeed, recreating a type from a utxo means we somehow lose the type information in the process of passing the utxo around, which should be fixed. We could have typed spendable out for instance or something similar, but we might as well wait for v2 to see what would be the best solution.


bluetooth: controller: Added missing variable initializations

In ull.c ll_rx_get, a configuration without CONFIG_BT_CONN would
sometimes return an uninitialized node_rx.
In ull_scan.c, the scanning channel was not initialized to 0 (37). This
would cause new scanning to start at random index (0,1,2).
Signed-off-by: Morten Priess<EMAIL_ADDRESS>

@carlescufi This PR is ready, could you please merge


Proposed formatting updates

Prepare for opening up to other SPHEREx subsystems, and expand the document category rendering in the running header to be a bit more informative.
Finicky aesthetic adjustment to rendering of the document handles.

I'm not sure I've told you already, but there the GitHub Actions CI does upload build preview artifacts. https://github.com/SPHEREx/spherex-tex/actions/runs/873221326

Did you only want the extra letter spacing around the en dash? Otherwise, perhaps reducing the letterspacing would tidy it up? It also looks like the extra spacing is unbalanced around the en dashes? I don't have answers, but I can try to explore this further; I see you linked to https://tex.stackexchange.com/questions/9736/output-hyphen-as-en-dash-in-macro

I didn't realize that you processed a test document, no.  That's great.
This didn't come out at all the way I expected, but that's not a surprise - I was completely flying blind.
I wanted SSDC\kern0.08em--\kern0.08emMS\kern0.08em--\kern0.08em000 - obviously I don't understand how the \ifx and \expandafter really work, because that's certainly not what I got.

For the PR record: ded4453 fixed the problem with the looping macro that expands hyphens in document handles.


Node Filters Doesn't work as expected

nodes_filter.webm

Resource filters don't accept decimal values
Filtered nodes don't include all available nodes

Work completed:

Added filter by total resources
fix filter by decimal values

verified and works fine and accurate

testlodge : https://github.com/threefoldtech/tfgrid-sdk-ts/issues/1725

Verified:

Devnet
ec2ed3d


Validating New Recipe Returns RECIPE_TYPE_NOT_FOUND Warning

Creating a new recipe then clicking the validation comes back with a warning 'Cannot find existing recipe type'.  This appears to be coming from the RecipeTypeManager.validate_recipe_type_v6 method (line 1382) where it's attempting to grab the previous recipe type definition to perform a diff. Of course this check will fail on a brand new recipe. This warning does not prevent the recipe type from being pronounced valid or ultimately created, but should not be happening on brand new recipe types.
recipe/models/RecipeTypeManager.validate_recipe_type_v6 lines 1382-1400:
            try:
                recipe_type = RecipeType.objects.all().get(name=name)
                old_definition = recipe_type.get_definition()
                diff = RecipeDiff(old_definition, definition)
                if not diff.can_be_reprocessed:
                    msg = 'This recipe cannot be reprocessed after updating.'
                    warnings.append(ValidationWarning('REPROCESS_WARNING',msg))
                    is_valid = False
                json = convert_recipe_diff_to_v6_json(diff)
                diff = rest_utils.strip_schema_version(json.get_dict())
            except RecipeType.DoesNotExist as ex:
                if name:
                    msg = 'Unable to find an existing recipe type with name: %s' % name
                    warnings.append(ValidationWarning('RECIPE_TYPE_NOT_FOUND', msg))
                pass
            except Exception as ex:
                errors.append(ex.error)
                logger.exception('Unable to generate RecipeDiff: %s' % ex)
                pass

Names are supposed to be optional for the validate rest endpoint. The create endpoint does not take a name and generates one from the title.  We should update the ui to not ask for a name and not pass it to the validate endpoint when creating a recipe type as the code will ignore the specified name when creating the recipe type anyway.

Permanent fix addressed in #1700


WIP: chore(release): 0.0.11

@simonpasquier the only thing missing is building and pushing the images to the appropriate registry


Install silently but append template to .bashrc

Is it possible to install bash-it silently but append the template to the .bashrc file like it would do in the prompt (if yes would be choosen)?

Sadly, there is no such option currently, but it seems to be a pretty nice first-issue if you want such feature to exist :smile:


bug: problem when getter type is different from property type

Description
when using #[MapToAttribute], when the getter type is different from the property type, the automapper guesses the type from the property, although it should guess it from the getter's return type
How to reproduce
class SomeClass
{
	public function __construct(private SomeEnum $enum){}

    public function getEnum(#[MapToAttribute('foo) string $foo]): string
    {
		return "{$foo}-{$this->enum->value}";
	}
}

$automapper->map(new SomeClass(SomeEnum::FOO, 'array'));

this code produces an error, because the generated mapper thinks SomeClass::getEnum() will return an enum
Possible Solution
don't know yet, need to dig into the generator

Fixed in #77


Error in MAX31855 when using HWSPI on STM32

When I use the original Max31855 library v0.2.4 the temperature display is not correct. (is to high)
Hardware: STM32DUINO STM32F405RGT6
https://www.tindie.com/products/icstation/stm32f4-micropython-stm32-pyboard-module11882/
Hardware SPI:
PA7  // SPI1_MOSI
PA6  // SPI1_MISO
PA5  // SPI1_SCLK
PA4  // SPI1_SS

I changed the source code as follows and the temeprature display was correct.

MAX31855.cpp
uint32_t MAX31855::_read(void)
{
  _rawData = 0;

  if (_hwSPI)
  {
    SPI.beginTransaction(SPISettings(16000000, MSBFIRST, SPI_MODE0));
    digitalWrite(_cs, LOW);

    for (uint8_t i = 0; i < 4; i++)
    {
      _rawData <<= 8;
      _rawData += SPI.transfer(0);
    }
    digitalWrite(_cs, HIGH);
    SPI.endTransaction();
  }
  else
  {
    digitalWrite(_cs, LOW);
    for (int8_t i = 31; i >= 0; i--)
    {
      _rawData <<= 1;
      digitalWrite(_sclk, LOW);
      // delayMicroseconds(1);  // DUE
      if ( digitalRead(_miso) ) _rawData++;
      digitalWrite(_sclk, HIGH);
      // delayMicroseconds(1);  // DUE
    }
    digitalWrite(_cs, HIGH);
  }
  return _rawData;
}

The CS signal must be between SPI.beginTransaction and SPI.endTransaction. Can anyone confirm this?

Seen the issue, might take some time to investigate (I do not have an STM32, so I have to check e.g ESP32)
It looks like a missing/extra pulse as the value seems x2
Can you confirm that the software SPI works?

yes,  Software SP works fine.

Good to hear SWSPI part is working.

Technically if there is only one device it should be possible to connect the CS line to GND permanently.
The SPI protocol should allow that.
looking at your log, I notice that the RAW value shows 26 bits (wrong value) and 25 bits (right value).
It does not show the leading zero's - and it needs "byte separators"  [TODO]
The raw value (lower 11 bits of raw) is the temperature in steps of 0.0625°C  (1/16th)
As this value is shifted one position to the right, one will get a temperature that is exactly a factor 2 too high.
So it appears that SPI.beginTransaction(SPISettings(16000000, MSBFIRST, SPI_MODE0)); does trigger the sending of the first bit if the CS line is already LOW on the STM platform.
On AVR, UNO the library 0.2.4 works, but of course the low level HW SPI is different.
Your solution works too on a AVR, UNO.
Need to find a free ESP32 to test.

Created a develop branch / PR with your modifications plus some minor updates.
Tested with an ESP32 and an UNO at different SPI hardware speeds and works well.
Can you confirm the develop branch works with the STM32?
Thanks,
Rob

ESP32 run

I used your development branch
https://github.com/RobTillaart/MAX31855_RT/tree/develop
Tested with a STM32F405RGT6 at various SPI hardware speeds and works fine.
I can confirm that the development branch works with the STM32.

Thanks
Then I will merge later today.


individual IPs

Since my BAD-GUYS list is getting longer and longer, I was wandering if there is a way to get an individual IP list into that script too?
Let's say I block Monaco and I want to block some IPs / IP ranges from US but I don't want to block the whole US. At the moment I edit another simple script to add those lines

simple script
#!/bin/bash
nft add chain inet filter BAD-GUYS { type filter hook input priority -10 ; policy accept;}
nft add rule inet filter BAD-GUYS ip saddr <IP_ADDRESS>/24 drop
nft add rule inet filter BAD-GUYS ip saddr <IP_ADDRESS>/24 drop

so my idea was to have a file/list with just bad IPs / ranges that are blocked with the countries.
<IP_ADDRESS>/25
<IP_ADDRESS>/24
probably there is already a much smarter way to do it.
all the best

Hmm, I don't think adding individual IPs to the filter sets would be ideal because the script is used to completely block a country and not just a few IP addresses from a particular country. Blocking only a few IP addresses can be easily achieved by using a script as you're doing right now. I don't see anything wrong with it.
Although, instead of using a script which calls nft again and again, you could edit your main nftables.conf file and add an include directive in that file that includes your "bad-guys" table.
Assuming your main nftables.conf is at /etc/nftables.conf. Just add this line at the bottom of the file:
# In /etc/nftables.conf
include /etc/nft-bad-guys.conf

And then in /etc/nft-bad-guys.conf, copy the following table which blocks the IPs that you want:
table inet bad-guys {
      set filter-v4 {
              type ipv4_addr
              flags interval
              auto-merge
              elements = {<IP_ADDRESS>,
                         <IP_ADDRESS>,
                         <IP_ADDRESS>}
      }

      set filter-v6 {
              type ipv6_addr
              flags interval
              auto-merge
              elements = {2001:db8::1,
                         2001:db8::2,
                         2001:db8::3}
      }

      chain filter-chain {
              type filter hook input priority filter; policy accept;
              ip saddr @filter-v4 drop
              ip6 saddr @filter-v6 drop
      }
}

Add whatever IPs you want to block in the filter-v4 and fitler-v6 sets and then restart nftables. Job done!

I see. Yeah, I was thinkin about editing the conf too.
I thought maybe creating a "fantasy country" FC that can be used like all the other countries but the IP ranges are not pulled from a country block website, but from the local file fantasy_country_ip_file.
The file will just get called by your script with a fantasy country name like badland BL - spamhousen SH or something like that.

At that point, we're shifting too many responsibilities from the nftables config to nft-geo-filter. The script will only create filter sets for real existing countries that are supported by ipdeny.com. Adding too much functionality to the script might turn it into an unmanageable mess, so let's try to avoid that.
In fact, one of my goals with this script was to avoid any config files and to only use the Python standard library so that nobody needs to download any third party Python packages. The previous version of this script actually required administrators to create empty filter sets and manually add the ip saddr @filter-v4 drop and ip6 saddr @filter-v6 drop statements to their nftables config. I wanted this script to be able to do everything that's needed to filter a country without asking the administrator to edit any config files, so I rewrote the entire script to do that. I'm trying to keep things as simple as possible.

got it. That's what I like, keep it simple as possible. Let's do that! :)
I will edit the nftables.conf
Thanks for sharing your approach and help, learning a lot right now about nft
Cheers

Thanks for understanding. I'll close this issue.


ODF template  update

@derekpoindexter Could you please verify the new parameter description

@derekpoindexter The newly added param worker-pools & existing param worker-nodes are mutually exclusive. So I think we need to mention this in description of both params. Can you please review description of both parameters and suggest the changes.


Chore: workflows

Description
add publish and test workflows
Motivation and Context
to get pr check workflows standard to homex
closes #7
Type of Change:

[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Maintenance or Refactor

Checklist

[ ] I added tests to cover my changes
[ ] I rebased changes with master so that they can be merged easily
[ ] I have updated the documentation accordingly (if applicable)

wrong remo closin


Add mass ping module to list of "run through banphrases" filters

Probably only if the module is enabled

relevant functions in massping module are already stateless, so this should be very doable

Fixed in https://github.com/pajbot/pajbot/commit/ad26fbb53f35d95dd40c26128c58fbaf9a50c381


TSLA-5207 [docs] add FAQ for helm crd installation workaround

Product Version(s):

Issue:

Link to docs preview:

SME review:

[ ] An SME has approved this change.

DOCS review:

[ ] A member of the docs team has approved this change.

Additional information:

Merge checklist:

[ ] Deploy preview inspected wherever changes were made
[ ] Build completed successfully
[ ] Test have passed

Closing -- content is forthcoming in KB article.


Cant find watch even if it is already connected

app can't find the watch even if it is already connected when trying to "Pair with wearOs device"

Hffy

Hffy

Excuse me ?

A few questions to help look into this:

Which version of the app are you using? (Both on phone and watch)
What is the model of the watch and which Android version?
When trying to pair is bluetooth enabled?

A few questions to help look into this:

Which version of the app are you using? (Both on phone and watch)
What is the model of the watch and which Android version?
When trying to pair is bluetooth enabled?

phone - 1.31.1 watch 1.13.1
Galaxy watch  4, android 14 Pixel 6
Obviously


Error: Cannot find module 'prettier-plugin-tailwindcss'

What version of prettier-plugin-tailwindcss are you using?
^0.1.13
What version of Tailwind CSS are you using?
^3.2.3
What version of Node.js are you using?
v18.9.0
What package manager are you using?
pnpm
What operating system are you using?
Windows
Reproduction URL
Not applicable
Describe your issue
Running prettier from the command line works fine.
But WebStorm is no longer able to run prettier, due to this error:
Error: Cannot find module 'prettier-plugin-tailwindcss'
Require stack:

<EMAIL_ADDRESS>C:\Program Files\JetBrains\WebStorm 2021.2.2\plugins\prettierJS\prettierLanguageService\prettier-plugin.js
C:\Program Files\JetBrains\WebStorm 2021.2.2\plugins\prettierJS\prettierLanguageService\prettier-plugin-provider.js
C:\Program Files\JetBrains\WebStorm 2021.2.2\plugins\JavaScriptLanguage\jsLanguageServicesImpl\js-language-service.js
at Module._resolveFilename (node:internal/modules/cjs/loader:955:15)
at resolve (node:internal/modules/cjs/helpers:109:19)
at C:\git\my-project\node_modules.pnpm\prettier@2.7.1\node_modules\prettier\index.js:37165:25
at Array.map ()
at Object.load (C:\git\my-project\node_modules.pnpm\prettier@2.7.1\node_modules\prettier\index.js:37160:65)
at Object.load [as loadPlugins] (C:\git\my-project\node_modules.pnpm\prettier@2.7.1\node_modules\prettier\index.js:15932:23)
at Object.getFileInfo (C:\git\my-project\node_modules.pnpm\prettier@2.7.1\node_modules\prettier\index.js:37227:24)
at PrettierPlugin. (C:\Program Files\JetBrains\WebStorm 2021.2.2\plugins\prettierJS\prettierLanguageService\prettier-plugin.js:88:58)
at step (C:\Program Files\JetBrains\WebStorm 2021.2.2\plugins\prettierJS\prettierLanguageService\prettier-plugin.js:34:23)
at Object.next (C:\Program Files\JetBrains\WebStorm 2021.2.2\plugins\prettierJS\prettierLanguageService\prettier-plugin.js:15:53)
Process finished with exit code -1

Hey! For help questions please use our discussion, we use issues exclusively for concrete bug reports.
To me the error reads like you haven’t installed the plugin, so I would install it with npm and if that doesn’t work, delete node_modules in case something got into a bad state there and reinstall your dependencies.

If I did not install the plugin, it would not have worked from the command line. And it does.
And the plugin is installed, and reinstalled a few times along with prettier.


Reaper Scans FR broken

Source information
<EMAIL_ADDRESS>Source language
French
Steps to reproduce

Launch

Expected behavior
See mangas
Actual behavior
"Cloudflare error" (this is not a cloudflare error, the domain name changed and new backend.
Mihon/Tachiyomi version
0.17.0
Android version
Android 14
Other details
I will write the PR.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

Add a :+1: reaction to issues you find important.

Ok, for stranges reasons, my app wasn't updated...


Improve error handling in beforeScreenshot

When an error is thrown in beforeScreenshot (can easily happen while creating some more-less complex test case with multiple DOM interactions or if break something in the code), it's not easy to spot it.
Current behavior
In debug mode (viteshot debug) error is visible for a couple of seconds on the page, and after it quickly hides. In the browser console only several framework or DOM errors are visible (at least in the case of React): https://pastebin.com/JhQGnWJR
In non-debug mode (viteshot) only internal DOM error is visible in the output: https://pastebin.com/914mSHvi. Error itself is visible on the screenshot only.
Expected behavior
Only thrown error is visible better in both cases, so it's easy to understand and debug it. In debug mode it should be visible in the console and maybe (debatable, not sure about this one) block rendering of other snapshots. In console mode, it just should show thrown error.
As I see viteshot takes the screenshot of the error to put it in the image, but still would be nicer to show it in the console. And in the debug mode it just hides too fast to understand the root cause.
Minimal code to reproduce:
export const MyScreenshot = () =>
Hello, World!

MyScreenshot.beforeScreenshot = () => {
  throw new Error('test error')
}

viteshot config:
const playwrightShooter = require('viteshot/shooters/playwright')
const playwright = require('playwright')

module.exports = {
  framework: {
    type: 'react',
  },
  shooter: playwrightShooter(playwright.chromium),
  filePathPattern: '**/*.screenshot.@(js|jsx|tsx|vue|svelte)',
}

Hi @dimadk24, thanks for this useful feedback.
I'm planning to rebuild Viteshot on top of Preview.js which should hopefully make this a bit better. No plans to fix it in the short term though (but PRs welcome!).


Fix Reorder When Page is RTL

WHY
Fix RTL Problem With Reorder Sort
BEFORE - What was wrong? What was happening before this PR?
it was not working fine when the page was rtl
AFTER - What is happening after this PR?
work fine depending on the HTML tag dir
HOW
so there's a method called RTL in nestedSortable() that allow RTL and it detects if dir is RTL from HTML dir attribute
How did you achieve that, in technical terms?

check page dir via $('html').attr('dir') == 'rtl')
if it true it wilis l saved at isRtl
if isRtl is true will inject some CSS to fix some indentation issues
add rtl to nestedSortable() with isRtl var

Is it a breaking change?
no
How can we test the before & after?

Hello @EGYWEB-Mohamed
Thanks for the contribution. 🙏
From what I see we are fixing two issues here:
1- sortable plugin has a rtl: true/false attribute that we don't allow developers to change and it's false by default.
2- added styles to make the rtl look similat to ltr.
Am I correct here ?
Also, we have in config/backpack/base.php the following:
// Direction, according to language
    // (left-to-right vs right-to-left)
    'html_direction' => 'ltr',

Can we use that setting instead of the html attribute?
Cheers

Thanks.
Not saying that your approach is better or worst, I think for us, Backpack, would only make sense to merge it using a Backpack config otherwise we would have two different ways in the core system to handle RTL and that would add into maintenance costs and inconsequential bugs.
I mainly agree with this PR, also is probably worth checking if rtl:true in the script initialization adds any rtl specific class or attribute that we can use to target with css, avoiding adding it with JavaScript.
Thanks again for the contribution, if you happen to do the changes I mentioned I think this PR becomes very close to a merge.
Cheers

@pxpm So you think change it to use config/backpack/base.php ->  'html_direction' => 'ltr'
am working on it and will update this PR soon

@pxpm Done :)

Amazing :)

Thanks a lot for the PR @EGYWEB-Mohamed 🙏 We really appreciate it.
Hot tip: in the future, try not to include indentation changes in the same PR, it makes it much more difficult to review. We can always submit a PR later, just with indentation changes. That way, both of them get quickly merged. It's a little more work, but it does help review and merge things a lot faster, and the git history is clearer too 🏆
Thanks again 🙏

@tabacitu Amazing thanks for this tip :)
thank you guys for your efforts @pxpm


[Addons] Extend razzle.config.js from addons

meta issue: #1433

razzle.config.js in an addon is in the the addon src folder.

The razzle.config.js from an addon can export both razzle config wrappers but also razzle plugins.
``
module.exports = {
modify: (config) => config,
plugins: [list_of_razzle_plugins],
}


I’m  having an issue

So after lots of research  I have to just be humble and ask. Soi this is is best is  and is the most user friendly os greet joe  but here comes my question how do I save games i was able to figure out everything else out I have been playing Ark the lad and the in game save says it’s saving but when I restart I and select continue it  just starts Over I know I am probably missing something very simple thanks

When you're done playing the game, how do you exit?  Assuming you're using the rg351p, you have to make sure you exit by hitting start+select.  Then the game save is written to the sd card.  If you're just shutting down the device when done playing, your saves will not be there.  Also, as an additional backup plan, you should use savestates as well.  This way if something is wrong with your save, you can at least restore your savestate.

When you're done playing the game, how do you exit?  Assuming you're using the rg351p, you have to make sure you exit by hitting start+select.  Then the game save is written to the sd card.  If you're just shutting down the device when done playing, your saves will not be there.  Also, as an additional backup plan, you should use savestates as well.  This way if something is wrong with your save, you can at least restore your savestate.

Thanks I will do

Thanks I will do


vcenter vm can't boot due to invalid cdrom config

Description
A vcenter vm will not boot if there is an invalid cdrom configuration such as having a cdrom drive as slave in a bus without master. For example, having only a drive in bus IDE[0:1] is an invalid configuration.
When you import a template or a wild vm with a cdrom and you add a cdrom image from opennebula, this situation can be produced.
To Reproduce

Create a vm in vcenter server with a cdrom drive attached to SATA[0:0].
Import this wild vm from opennebula
Attach a cdrom image to the instance, ( opennebula usually set as IDE[0:1] )
Try to power on the instance, it'll probably returns a "Module 'DevicePowerOn' power on failed." because IDE[0:1] doesn't have a master associate ( IDE[0:0] )

Expected behavior
The cdrom image should be attached to the existing cdrom drive or take care about the bus positions to avoid those invalid configurations.
Details

Affected Component: Core, Scheduler, Sunstone
Hypervisor: ESXi
Version: All versions

Additional context

Progress Status

[x] Branch created
[x] Code committed to development branch
[x] Testing - QA
[ ] Documentation
[x] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

Related to #3224

Branch created:
https://github.com/OpenNebula/one/tree/b-3225

PR crated: https://github.com/OpenNebula/one/pull/3424

Nice! Needs docs + testing

PR to Doc (resolved issues 583 ) https://github.com/OpenNebula/docs/pull/661

PR to Doc ( add comments about limitations on IDE Devices ) https://github.com/OpenNebula/docs/pull/662

PR to Development: new test created
https://github.com/OpenNebula/development/pull/649


Tabular UI: Dataverse marks file as having geospatial data

Within dataverse

Part of categories, simple file flag?
Machine recognition of geospatial data.  Within DV, API to worldmap/geoconnect?
User signalling of geospatial data.  For every file?

[ ]  files may be marked "Geospatial" (see DataFileTag.java in dv)
[ ] tabular files marked as "Geospatial" should receive a "Map Data" button

Qualifications:

[ ] has "Geospatial" tag
[ ] is tabular
[ ] is released / public


Add README.md

ping @Thooms

How to run?
How to contribute?
How to deploy?

README created in #3

MR merged. Closing


Bug: "Subscribe" spills out of div

Describe the bug

Notice how the "Subscribe" button on the highlights page spills over out of the div on Firefox. This looks fine on Chrome:

But, again, is busted on Firefox
Steps to reproduce

Use firefox
Go to https://insights.opensauced.pizza/feed
Notice the "Subscribe" button is spilling over to the right

Browsers
Firefox
Additional context (Is this in dev or production?)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[X] I agree to follow this project's Contribution Docs

I will .take this.

This is still broken.
On firefox:

On Chrome:

This is still broken and looks like it has degraded on both FireFox and Chrome.
On firefox:

On Chrome:

I will check it out and work the fix.

@RitaDee, consider adding flex-wrap to the container element holding the input and Subscribe button so that the UI is more fluid and can adjust to the different screen sizes. And you'll probably need to add the Tailwind class self-start to the input for the email address.

@RitaDee, consider adding flex-wrap to the container element holding the input and Subscribe button so that the UI is more fluid and can adjust to the different screen sizes. And you'll probably need to add the Tailwind class self-start to the input for the email address.

Thank you @nickytonline. This is kind of weird to me I just pulled beta into my forked repo and noticed the changes merged for this issue aren't reflecting. Do you have an idea why?

@RitaDee, hmm not sure. How are you pulling the latest from beta into your fork? Are you using the GitHub user interface, the command line or another tool?

@RitaDee, hmm not sure. How are you pulling the latest from beta into your fork? Are you using the GitHub user interface, the command line or another tool?

I primarily use the GitHub user interface and do a pull on my IDE. I suspect someone might have encountered some conflicts and in the process tempered with the changes. I might be wrong though.

self-start

Going with the above fix alters the design:

So, I went with the former fix I made. The PR is now ready for a review.

Yeah, the button would have to go full width then which we may or may not want as the screen shrinks. With you current suggestion, it works but the text field for the email gets pretty small.
In smaller screens if we went flex-col with the buttons taking the full width, it might be better.
Do you have a preference here style wise @isabensusan?
Current Suggestion

Alternate Suggestion

Yeah, the button would have to go full width then which we may or may not want as the screen shrinks. With you current suggestion, it works but the text field for the email gets pretty small.
In smaller screens if we went flex-col with the buttons taking the full width, it might be better.
Do you have a preference here style wise @isabensusan?
Current Suggestion

Alternate Suggestion

The alternate suggestion looks good. I will wait for the meantime until a decision is made.

Also on Chrome

@chhristopher - looks like this fix hasn't landed on production yet: this should be fixed once it lands but can be viewed in beta: https://beta.app.opensauced.pizza/feed


Move game context logic to this module

As part of this, need to establish a watcher/delegate/listener pattern so we can notify all players, or one player specifically

Completed with #3 and #4


Skip index column instead of checking for it every time

https://github.com/tactlessfish/pokesummary/blob/d55696453db18142510e8270199ce79f54134d36/pokesummary/parsing.py#L23
At this line, we run an if statement in every iteration. It should be possible to remove this by skipping the index column somehow.

Done in f046f7d and 4d3fcfd.


adding support for eu-north-1

wal-e does not work in the eu-north-1 region. This PR fixes the problem

Fixes https://github.com/wal-e/wal-e/issues/424


backup: add checks for non-empty disks when running a backup

Previously a really not user-friendly error was raised when there were no disks to backup:
i.e., when backup was initiated on a VM without any disks attached.
Both backup script & engine errors looked like an internal unexpected error rather then
displaying an error message that should help the user to understand what is wrong.
Adding a simple validation and short error message to solve the issue.
Signed-off-by: Pavel Bar<EMAIL_ADDRESS>

@nirs @ahadas

Previous behavior:
SDK script:
pbar@engine1 ~/dev/git/python-ovirt-engine-sdk4/examples (main) $ ./backup_vm.py -c engine1 full 6be7fd27-2deb-448c-8856-13243da08b24
[   0.0 ] Starting full backup for VM '6be7fd27-2deb-448c-8856-13243da08b24'
Traceback (most recent call last):
File "./backup_vm.py", line 527, in
main()
.........
ovirtsdk4.Error: Fault reason is "Input validation failed.". Fault detail is "Parameter 'backup.disks' is mandatory but was not provided.". HTTP response code is 400.
Engine log:
2022-02-08 11:10:21,612+02 ERROR [org.ovirt.engine.api.restapi.resource.validation.ValidationExceptionMapper] (default task-3) [] Input validation failed while processing 'POST' request for path '/vms/6be7fd27-2deb-448c-8856-13243da08b24/backups'.
2022-02-08 11:10:21,612+02 ERROR [org.ovirt.engine.api.restapi.resource.validation.ValidationExceptionMapper] (default task-3) [] Exception: org.ovirt.api.metamodel.server.ValidationException: Parameter 'backup.disks' is mandatory but was not provided.
....
another 120 stack trace lines

New behavior:
SDK script:
pbar@engine1 ~/dev/git/python-ovirt-engine-sdk4/examples (main) $ ./backup_vm.py -c engine1 full 6be7fd27-2deb-448c-8856-13243da08b24
[   0.0 ] Starting full backup for VM '6be7fd27-2deb-448c-8856-13243da08b24'
Traceback (most recent call last):
File "./backup_vm.py", line 515, in
main()
.........
RuntimeError: Cannot start a backup without disks
Engine log:
N/A

The patch is validated & ready for review, the example runs (before and after) are above.


Electron 12 pre-build

Electron released a month ago but still have no pre-build version. Can you add support?

We now have Electron v12. Any plans for SQLite3 to support newer versions?

Would you be able to try with v5.0.3? 🙂


Replace Ui.png

Codecov Report

Merging #203 (639821d) into master (8b3492d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #203   +/-   ##
=========================================
  Coverage     77.22%   77.22%
  Complexity      688      688
=========================================
  Files            97       97
  Lines          2165     2165
  Branches        267      267
=========================================
  Hits           1672     1672
  Misses          399      399
  Partials         94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3492d...639821d. Read the comment docs.


vendor update keybase/go-framed-msgpack-rpc#117

hmm the same test passed on macOS

what same test?

The CI failed on Windows, on TestBlockRetrievalWorkerShutdown. But it passed on my machine with repeat 10

Oh it's a known flak

I think I see the cause


Uncaught TypeError: Cannot read property 'start' of undefined

[Enter steps to reproduce below:]

select text
drag text
drop text.
uncaught error!

Atom Version: 0.201.0
System: Microsoft Windows 8.1 Enterprise
Thrown From: simple-drag-drop-text package, v0.2.2
Stack Trace
Uncaught TypeError: Cannot read property 'start' of undefined
At C:\Users\marchester\.atom\packages\simple-drag-drop-text\lib\simple-drag-drop-text.coffee:59

TypeError: Cannot read property 'start' of undefined
  at SimpleDragDropText.drop (C:\Users\marchester\.atom\packages\simple-drag-drop-text\lib\simple-drag-drop-text.coffee:59:69)
  at SimpleDragDropText.clear (C:\Users\marchester\.atom\packages\simple-drag-drop-text\lib\simple-drag-drop-text.coffee:63:38)
  at HTMLBodyElement.<anonymous> (C:\Users\marchester\.atom\packages\simple-drag-drop-text\lib\simple-drag-drop-text.coffee:13:63)
  at HTMLBodyElement.jQuery.event.dispatch (C:\Users\marchester\AppData\Local\atom\app-0.201.0\resources\app.asar\node_modules\jquery\dist\jquery.js:4435:9)
  at HTMLBodyElement.elemData.handle (C:\Users\marchester\AppData\Local\atom\app-0.201.0\resources\app.asar\node_modules\jquery\dist\jquery.js:4121:28)

Commands
     -0:04.0 core:undo (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "themes": [
      "atom-dark-ui",
      "twilight-syntax"
    ],
    "destroyEmptyPanes": false,
    "projectHome": "d:\\devel\\active",
    "disabledPackages": [
      "language-make",
      "welcome"
    ]
  }
}

Installed Packages
# User
highlight-line, v0.10.2
minimap, v4.9.0
project-manager, v1.15.7
simple-drag-drop-text, v0.2.2
twilight-syntax, v0.7.0

# Dev
No dev packages

Was gonna report it when I saw this. Please fix ASAP, I can't work without it :)

Thanks for the report.  I'll be getting to that package Sunday.
On Sat, May 23, 2015 at 11:02 AM, Zireael07<EMAIL_ADDRESS>wrote:

Was gonna report it when I saw this. Please fix ASAP, I can't work without
it :)
—
Reply to this email directly or view it on GitHub
https://github.com/mark-hahn/simple-drag-drop-text/issues/3#issuecomment-104931561
.

Thanks again.  Fixed in 0.2.3.

And thank you!


Added Simplified Chinese for readme.md

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: lkysyzxz sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


.zeroRect becomes .zero

closes https://github.com/venmo/Static/issues/34
Although my teammate reminds me that you won't be able to merge this without breaking your 1.2 support. Perhaps a swift-2.0 branch?

:+1:

confirmed this issue.
@paulbruneau Static requires Swift 2 (we use guard and other Swift 2 API on master today).
Thanks for the PR. :octocat:

Thank you!


Connect Four Game

Relevant Issues
Continued #365 as the original contributor ditched it.
Description
Implemented all the changes which were requested in the pr, and changed the bot message to a embed rather than content.

Dynamic Board size
Checks for user already playing/in waiting room.

Screenshots

Did you:

[x] Join the Python Discord Community?
[ ] If dependencies have been added or updated, run pipenv lock?
[x] Lint your code (pipenv run lint)?
[x] Set the PR to allow edits from contributors?

Why did you decide to close this?


Surface observer frequently stops observing after suspend() and resume()

Describe the bug
Consider this:
Suspend sets 'IsRunning' to true.  Suspend does not touch outstandingMeshObject.
public override void Suspend()
        {
            if (!IsRunning)
            {
                Debug.LogWarning("The Windows Mixed Reality spatial observer is currently stopped.");
                return;
            }

            // UpdateObserver keys off of this value to stop observing.
            IsRunning = false;

            // Clear any pending work.
            meshWorkQueue.Clear();
        }

UpdateObserver checks to see if outStandingMeshObject is null, and if it is not, UpdateObserver does nothing, assuming there is some work outstanding.
private void UpdateObserver()
        {
            if (SpatialAwarenessSystem == null)
            {
                return;
            }

            // Only update the observer if it is running.
            if (IsRunning && (outstandingMeshObject == null))

outstandingMeshObject is set when a mesh is requested, SurfaceObserver_OnDataReady is the callback
if (observer.RequestMeshAsync(surfaceData, SurfaceObserver_OnDataReady))
            {
                outstandingMeshObject = newMesh;
            }

SurfaceObserver_OnDataReady does nothing when IsRunning is false; Otherwise it will set outstandingMeshObject to null.
private void SurfaceObserver_OnDataReady(SurfaceData cookedData, bool outputWritten, float elapsedCookTimeSeconds)
        {
            if (!IsRunning) { return; }
if (!outputWritten)
            {
                ReclaimMeshObject(outstandingMeshObject);
                outstandingMeshObject = null;
                return;
            }

            // Since there is only one outstanding mesh object, update the id to match
            // the one received after baking.
            SpatialAwarenessMeshObject meshObject = outstandingMeshObject;
            meshObject.Id = cookedData.id.handle;
            outstandingMeshObject = null;

The consequence of the above is that if you 'Suspend()' an observer while RequestMeshAsync is doing its work, the SurfaceObserver will no longer make progress after calling Resume().

Thanks @darax! Excellent find


Nodes get stuck to cursor when connecting to or from input side of WAS text nodes

Running was-node-suite on ComfyUI in an install with only Comfy, node manager and this node pack on Python 3.11.4 on Kubuntu 22.04, I get the following issue:
The standard Comfy nodes work fine, allowing me to freely connect between compatible ports on nodes. I want to add some WAS text processing nodes. After adding the text find and replace node, I try to connect it to the built in default text box. No matter which way I connect (text to find and replace or find and replace to text), the connecting line is drawn, but when I click on the destination node, it gets grabbed by the mouse and I can't put it down after. I have to reload the page or delete the node to fix things. This happens with the connections on the left of the was node. Those on the right work fine.

Loading: ComfyUI-Manager (V0.15.1)
ComfyUI Revision: 1218 [c910b4a0]
was-node-suite-comfyui$ git log -1
commit ab454b1c9a5f00fc8b41b91a7ea94d60d901ce50 (HEAD -> main, origin/main, origin/HEAD)
Author: Jordan Thompson<EMAIL_ADDRESS>Date:   Thu Jul 27 10:38:42 2023 -0700

Same problem here - I wanted to use WAS for text contatenation, but it doesn't work (latest version of both ComfyUI and WAS), connections cannot be made, and native ComfyUI nodes stick to the cursor, instead (only page reload helps).

WAS-NS doesn't really support Python 3.11. It uses older AI tools based around colabs for 3.8,3.9, the fact they work on 3.10 is great but 3.11 is pushing it. However this is just a node pack. It in no way affects the front end so that sounds like a bug with it handling custom data types.

@WASasquatch In my case it happens with Python 3.10.11 (Anaconda for Windows).

Thanks for the feedback. I'm away for a few days. I'll look at getting the report in on Comfy when I get back.

@WASasquatch In my case it happens with Python 3.10.11 (Anaconda for Windows).

I wasn't referring the the error in general but that you may run into more issues.

I believe this issue has been resolved in base ComfyUI.


[Installation]: Pytorch nightly version 2.6 meets error: error: can't copy '/tmp/tmpv5hlsgcm.build-lib/vllm/_core_C.abi3.so': doesn't exist or not a regular file

Your current environment

click here to view the env
Collecting environment information...
PyTorch version: 2.6.0.dev20241008+cu124
Is debug build: False
CUDA used to build PyTorch: 12.4
ROCM used to build PyTorch: N/A

OS: Ubuntu 20.04.6 LTS (x86_64)
GCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
Clang version: 16.0.1
CMake version: version 3.26.0
Libc version: glibc-2.31

Python version: 3.12.7 | packaged by Anaconda, Inc. | (main, Oct  4 2024, 13:27:36) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-5.4.0-196-generic-x86_64-with-glibc2.31
Is CUDA available: True
CUDA runtime version: 12.6.68
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: Tesla V100-SXM2-32GB
GPU 1: Tesla V100-SXM2-32GB
GPU 2: Tesla V100-SXM2-32GB
GPU 3: Tesla V100-SXM2-32GB

Nvidia driver version: 560.35.03
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.9.4.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv.so.9.4.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn.so.9.4.0
/usr/lib/x86_64-linux-gnu/libcudnn_engines_precompiled.so.9.4.0
/usr/lib/x86_64-linux-gnu/libcudnn_engines_runtime_compiled.so.9.4.0
/usr/lib/x86_64-linux-gnu/libcudnn_graph.so.9.4.0
/usr/lib/x86_64-linux-gnu/libcudnn_heuristic.so.9.4.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops.so.9.4.0
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Byte Order:                         Little Endian
Address sizes:                      40 bits physical, 48 bits virtual
CPU(s):                             20
On-line CPU(s) list:                0-19
Thread(s) per core:                 1
Core(s) per socket:                 20
Socket(s):                          1
NUMA node(s):                       1
Vendor ID:                          GenuineIntel
CPU family:                         6
Model:                              85
Model name:                         Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz
Stepping:                           7
CPU MHz:                            2499.998
BogoMIPS:                           4999.99
Hypervisor vendor:                  KVM
Virtualization type:                full
L1d cache:                          640 KiB
L1i cache:                          640 KiB
L2 cache:                           80 MiB
L3 cache:                           16 MiB
NUMA node0 CPU(s):                  0-19
Vulnerability Gather data sampling: Unknown: Dependent on hypervisor status
Vulnerability Itlb multihit:        KVM: Vulnerable
Vulnerability L1tf:                 Mitigation; PTE Inversion
Vulnerability Mds:                  Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Meltdown:             Mitigation; PTI
Vulnerability Mmio stale data:      Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed:             Mitigation; IBRS
Vulnerability Spec store bypass:    Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; IBRS; IBPB conditional; STIBP disabled; RSB filling; PBRSB-eIBRS Not affected; BHI SW loop, KVM SW loop
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon rep_good nopl xtopology cpuid tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch topoext cpuid_fault invpcid_single pti ssbd ibrs ibpb fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt clwb avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves arat umip pku ospke avx512_vnni

Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] pytorch-triton==3.1.0+cf34004b8a
[pip3] torch==2.6.0.dev20241008+cu124
[pip3] torchaudio==2.5.0.dev20241008+cu124
[pip3] torchvision==0.20.0.dev20241008+cu124
[conda] numpy                     1.26.4                   pypi_0    pypi
[conda] pytorch-triton            3.1.0+cf34004b8a          pypi_0    pypi
[conda] torch                     2.6.0.dev20241008+cu124          pypi_0    pypi
[conda] torchaudio                2.5.0.dev20241008+cu124          pypi_0    pypi
[conda] torchvision               0.20.0.dev20241008+cu124          pypi_0    pypi

How you are installing vllm
related to #8174
I firstly use the following command to install nightly pytorch
pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/cu124

Then I follow the instructions here: https://docs.vllm.ai/en/latest/getting_started/installation.html#use-an-existing-pytorch-installation
After I exec the command
pip install -e . --no-build-isolation

long time later, I got the following error log:
  Building editable for vllm (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building editable for vllm (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [290 lines of output]
      running editable_wheel
      creating /tmp/pip-wheel-vrx9vcb_/.tmp-3zex91m_/vllm.egg-info
      writing /tmp/pip-wheel-vrx9vcb_/.tmp-3zex91m_/vllm.egg-info/PKG-INFO
      writing dependency_links to /tmp/pip-wheel-vrx9vcb_/.tmp-3zex91m_/vllm.egg-info/dependency_links.txt
      writing entry points to /tmp/pip-wheel-vrx9vcb_/.tmp-3zex91m_/vllm.egg-info/entry_points.txt
      writing requirements to /tmp/pip-wheel-vrx9vcb_/.tmp-3zex91m_/vllm.egg-info/requires.txt
      writing top-level names to /tmp/pip-wheel-vrx9vcb_/.tmp-3zex91m_/vllm.egg-info/top_level.txt
      writing manifest file '/tmp/pip-wheel-vrx9vcb_/.tmp-3zex91m_/vllm.egg-info/SOURCES.txt'
      reading manifest template 'MANIFEST.in'
      adding license file 'LICENSE'
      writing manifest file '/tmp/pip-wheel-vrx9vcb_/.tmp-3zex91m_/vllm.egg-info/SOURCES.txt'
      creating '/tmp/pip-wheel-vrx9vcb_/.tmp-3zex91m_/vllm-0.6.3.dev138+g480b7f40.d20241009.cu126.dist-info'
      creating /tmp/pip-wheel-vrx9vcb_/.tmp-3zex91m_/vllm-0.6.3.dev138+g480b7f40.d20241009.cu126.dist-info/WHEEL
      running build_py
      running build_ext
      -- The CXX compiler identification is GNU 9.4.0
      -- Detecting CXX compiler ABI info
      -- Detecting CXX compiler ABI info - done
      -- Check for working CXX compiler: /usr/bin/g++ - skipped
      -- Detecting CXX compile features
      -- Detecting CXX compile features - done
      -- Build type: RelWithDebInfo
      -- Target device: cuda
      -- Found Python: /root/anaconda3/envs/llmfuzz/bin/python (found version "3.12.7") found components: Interpreter Development.Module Development.SABIModule
      -- Found python matching: /root/anaconda3/envs/llmfuzz/bin/python.
      -- Found CUDA: /usr/local/cuda-12.6 (found version "12.6")
      -- The CUDA compiler identification is NVIDIA 12.6.68
      -- Detecting CUDA compiler ABI info
      -- Detecting CUDA compiler ABI info - done
      -- Check for working CUDA compiler: /usr/local/cuda-12.6/bin/nvcc - skipped
      -- Detecting CUDA compile features
      -- Detecting CUDA compile features - done
      -- Found CUDAToolkit: /usr/local/cuda-12.6/include (found version "12.6.68")
      -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
      -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
      -- Looking for pthread_create in pthreads
      -- Looking for pthread_create in pthreads - not found
      -- Looking for pthread_create in pthread
      -- Looking for pthread_create in pthread - found
      -- Found Threads: TRUE
      -- Caffe2: CUDA detected: 12.6
      -- Caffe2: CUDA nvcc is: /usr/local/cuda-12.6/bin/nvcc
      -- Caffe2: CUDA toolkit directory: /usr/local/cuda-12.6
      -- Caffe2: Header version is: 12.6
      -- Found Python: /root/anaconda3/envs/llmfuzz/bin/python (found version "3.12.7") found components: Interpreter
      CMake Warning at /root/anaconda3/envs/llmfuzz/lib/python3.12/site-packages/torch/share/cmake/Caffe2/public/cuda.cmake:140 (message):
        Failed to compute shorthash for libnvrtc.so
      Call Stack (most recent call first):
        /root/anaconda3/envs/llmfuzz/lib/python3.12/site-packages/torch/share/cmake/Caffe2/Caffe2Config.cmake:86 (include)
        /root/anaconda3/envs/llmfuzz/lib/python3.12/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:68 (find_package)
        CMakeLists.txt:84 (find_package)

      CMake Warning (dev) at /usr/local/cmake/share/cmake-3.26/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
        The package name passed to `find_package_handle_standard_args` (nvtx3) does
        not match the name of the calling package (Caffe2).  This can lead to
        problems in calling code that expects `find_package` result variables
        (e.g., `_FOUND`) to follow a certain pattern.
      Call Stack (most recent call first):
        /root/anaconda3/envs/llmfuzz/lib/python3.12/site-packages/torch/share/cmake/Caffe2/public/cuda.cmake:174 (find_package_handle_standard_args)
        /root/anaconda3/envs/llmfuzz/lib/python3.12/site-packages/torch/share/cmake/Caffe2/Caffe2Config.cmake:86 (include)
        /root/anaconda3/envs/llmfuzz/lib/python3.12/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:68 (find_package)
        CMakeLists.txt:84 (find_package)
      This warning is for project developers.  Use -Wno-dev to suppress it.

      -- Could NOT find nvtx3 (missing: nvtx3_dir)
      CMake Warning at /root/anaconda3/envs/llmfuzz/lib/python3.12/site-packages/torch/share/cmake/Caffe2/public/cuda.cmake:180 (message):
        Cannot find NVTX3, find old NVTX instead
      Call Stack (most recent call first):
        /root/anaconda3/envs/llmfuzz/lib/python3.12/site-packages/torch/share/cmake/Caffe2/Caffe2Config.cmake:86 (include)
        /root/anaconda3/envs/llmfuzz/lib/python3.12/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:68 (find_package)
        CMakeLists.txt:84 (find_package)

      -- USE_CUDNN is set to 0. Compiling without cuDNN support
      -- USE_CUSPARSELT is set to 0. Compiling without cuSPARSELt support
      -- USE_CUDSS is set to 0. Compiling without cuDSS support
      -- USE_CUFILE is set to 0. Compiling without cuFile support
      -- Autodetected CUDA architecture(s):  7.0 7.0 7.0 7.0
      -- Added CUDA NVCC flags for: -gencode;arch=compute_70,code=sm_70
      CMake Warning at /root/anaconda3/envs/llmfuzz/lib/python3.12/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:22 (message):
        static library kineto_LIBRARY-NOTFOUND not found.
      Call Stack (most recent call first):
        /root/anaconda3/envs/llmfuzz/lib/python3.12/site-packages/torch/share/cmake/Torch/TorchConfig.cmake:120 (append_torchlib_if_found)
        CMakeLists.txt:84 (find_package)

      -- Found Torch: /root/anaconda3/envs/llmfuzz/lib/python3.12/site-packages/torch/lib/libtorch.so
      -- Enabling core extension.
      CMake Warning at CMakeLists.txt:125 (message):
        Pytorch version 2.4.0 expected for CUDA build, saw 2.6.0 instead.

      -- CUDA target architectures: 7.0
      -- CUDA supported arches: 7.0;7.5;8.0;8.6;8.9;9.0
      -- FetchContent base directory: /root/vllm/.deps
      -- CMake Version: 3.26.0
      -- CUTLASS 3.5.1
      -- CUDART: /usr/local/cuda-12.6/lib64/libcudart.so
      -- CUDA Driver: /usr/local/cuda-12.6/lib64/stubs/libcuda.so
      -- NVRTC: /usr/local/cuda-12.6/lib64/libnvrtc.so
      -- Default Install Location: install
      -- Found Python3: /root/anaconda3/envs/llmfuzz/bin/python3.12 (found suitable version "3.12.7", minimum required is "3.5") found components: Interpreter
      -- Make cute::tuple be the new standard-layout tuple type
      -- CUDA Compilation Architectures: 70;72;75;80;86;87;89;90;90a
      -- Enable caching of reference results in conv unit tests
      -- Enable rigorous conv problem sizes in conv unit tests
      -- Using NVCC flags: --expt-relaxed-constexpr;-DCUTE_USE_PACKED_TUPLE=1;-DCUTLASS_TEST_LEVEL=0;-DCUTLASS_TEST_ENABLE_CACHED_RESULTS=1;-DCUTLASS_CONV_UNIT_TEST_RIGOROUS_SIZE_ENABLED=1;-DCUTLASS_DEBUG_TRACE_LEVEL=0;-Xcompiler=-Wconversion;-Xcompiler=-fno-strict-aliasing;-lineinfo
      -- Configuring cublas ...
      -- cuBLAS Disabled.
      -- Configuring cuBLAS ... done.
      -- Not building Marlin kernels as no compatible archs foundin CUDA target architectures
      -- Not building scaled_mm_c3x as no compatible archs found in CUDA target architectures
      -- Not building scaled_mm_c2x as no compatible archs found in CUDA target architectures
      -- Not building Machete kernels as no compatible archs found in CUDA target architectures
      -- Enabling C extension.
      -- Not building Marlin MOE kernels as no compatible archs foundin CUDA target architectures
      -- Enabling moe extension.
      -- Build type: RelWithDebInfo
      -- Target device: cuda
      -- Found Python: /root/anaconda3/envs/llmfuzz/bin/python (found version "3.12.7") found components: Interpreter Development.Module Development.SABIModule
      -- Building vllm-flash-attn inside vLLM.

              ********************************************************************************
              An error happened while installing `vllm` in editable mode.

              The following steps are recommended to help debug this problem:

              - Try to install the project normally, without using the editable mode.
                Does the error still persist?
                (If it does, try fixing the problem before attempting the editable mode).
              - If you are using binary extensions, make sure you have all OS-level
                dependencies installed (e.g. compilers, toolchains, binary libraries, ...).
              - Try the latest version of setuptools (maybe the error was already fixed).
              - If you (or your project dependencies) are using any setuptools extension
                or customization, make sure they support the editable mode.

              After following the steps above, if the problem still persists and
              you think this is related to how setuptools handles editable installations,
              please submit a reproducible example
              (see https://stackoverflow.com/help/minimal-reproducible-example) to:

                  https://github.com/pypa/setuptools/issues

              See https://setuptools.pypa.io/en/latest/userguide/development_mode.html for details.
              ********************************************************************************

      !!
        cmd_obj.run()
      error: can't copy '/tmp/tmpv5hlsgcm.build-lib/vllm/_core_C.abi3.so': doesn't exist or not a regular file
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building editable for vllm
Failed to build vllm
ERROR: ERROR: Failed to build installable wheels for some pyproject.toml based projects (vllm)

Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

Sry, currently I haven't solved it yet.
I am not sure whether this is caused by the  torch nightly 2.6 and vllm not being all compatible :(

Got a similar issue for editable mode. Haven't solved it just yet. I'm trying to figure this out.

cc @dtrifiro

Can you try deleting the build dir and re-running pip install -v --no-build-isolation -e .

@dtrifiro thank u for your reply
What do you mean by build dir?
Because I didn't find this dir in vllm.
If you are referring to the dir uner /tmp, it is automatically deleted after each build failure

Can you try cloning vllm again to a new directory and re-running the command?

I have tried this. Sadly, I encountered the same issue :(
It's very strange this issue only appears when I install nightly version  of pytorch. If I install pytorch 2.5, I won't meet this issue.

@shaoyuyoung can you build successfully using python setup.py bdist_wheel ?

@shaoyuyoung can you build successfully using python setup.py bdist_wheel ?

It seems that this starts to work.
Actually, I succeed by using following commands:
git clone https://github.com/vllm-project/vllm.git
cd vllm
python use_existing_torch.py
pip install -r requirements-common.txt
python setup.py install

different with https://docs.vllm.ai/en/latest/getting_started/installation.html#use-an-existing-pytorch-installation

My problem has been addressed, so close this issue for now.
If necessary, feel free to reopen or discuss at any time :)

I've seen that happen before when there are some cmake-cached files present that break the build, one example is the build directory that might get created when building the wheel

Shouldn't we have something like make clean to address these kinds of issues?

I also hope so.
If it can make users install the nightly version of pytorch and vllm easily. (to be honest, few people would install nightly version as far as I know)


API Key Error

Hello there!
I'm trying to translate content using your action, however, I keep getting this error 'AI_APICallError: The model gpt-4o does not exist or you do not have access to it.' even though I'm using a paid OpenAI account. I even added my manager as a collaborator and tried running the action on his computer to no effect.
Please advice.

/gt ./README.md README.zh_CN.md simplified-chinese

@MPruthi97
As you can see, I just gave it a try with gpt-4o on my end, and it's working correctly.
Based on the error message you're seeing, it seems that your API key might not have access to the gpt-4o model. While I'm not entirely sure about the specifics, here are a couple of things you can try:

Have you prepaid or added credit to your OpenAI API account?
Could you try accessing the gpt-4o model directly in the OpenAI API Playground?

@3ru I'm trying to run the action by commit. I'll get back to you with answers in sometime as I'm using a key generated through my teammates' paid account so will reach out to him.


Automatically use an image of the same name as the video as a thumbnail

I see that I can manually specify the thumbnail image, but can I do it automatically?
.
├── sample.mp4
└── sample.jpg     # Use this image as a thumbnail

Interesting idea.   My guess it's very uncommon 🤔 🤷♂ ... perhaps some people have cover.jpg file name instead 💭 I'm really unsure.
If you'd like I can help you code the changes so you could build your own version of the app 🤝
I'm unsure whether I'd want the feature to be a part of the app - I'm sort-of on the border. Would love to hear others' opinions 👍

Interesting idea but I agree that multiple people probably use different kinds of formats (yay multiple standards).
The format I'm using is a folder with the movie file in it, an information file (NFO), a trailer, a poster (like a DVD case front) and a background image (fanart). There's also 2 subfolders for thumbnails and backgrounds (fanart).
It looks a bit like this:
extrafanart
├── fanart0.jpg
└── fanart1.jpg
extrathumbs
├── thumb0.jpg
└── thumb1.jpg
.
├── sample.mp4
├── sample.nfo
├── sample-fanart.jpg
├── sample-poster.jpg
└── movie-trailer.mp4
And in the case of TV series there also a theme music file in the same location as the main folder named theme.mp3. But that's outside the scope of this project I think. Besides my TV series folders has a different format with season subfolders. Let's not get in to that (unless you want to).

Thanks for the reply.
It certainly doesn't seem to be an easy solution, as different people manage their cover images differently.
I'll make a fork that is suitable for me :smirk:.

Do let me know if you'd like me to point you to locations in code where to add your changes / if you have any questions 👍
ps - the current main branch already has the changes from 3.0.0 but it might have minor bugs still. The branch is stable-enough that it shouldn't change much before release, but whatever you build would likely benefit from a git merge main update once 3.0.0 comes out 😊

Thank you for the suggestion and the discussion.
I think this is too bespoke and is best handled by individual developers on their end. There's already functionality in the app that can take an arbitrary .jpg or .png and set it as the main thumbnail for a video. It wouldn't be too hard to add a few lines of code that check for presence of a particular image format and use that functionality.
Closing the issue since I don't think this will appear in the production app. Please feel free to comment on it if you'd like any help with getting the code to work for yourself 🤝

I'm interested in this functionality can you please point to me the location where to add the changes and what preexisting functions I can use? thanks

Hey @Gavriik -- looks like @68cdrBxM8YdoJ has already done enough to get the feature working on their end.
You won't need all the code in their branch, but the relevant piece is here:
https://github.com/whyboris/Video-Hub-App/compare/main...68cdrBxM8YdoJ:Video-Hub-App:automatically-use-exist-image-as-thumb#diff-35434f481038fd7aac0dd8caf5dab1a131c5a601cfda35dcf4f98b07111ba0ecR282
Their branch is out of date with my main but you can copy/paste the line I link to above and the few below - and with some minor modifications that might work for you. Let me know if you have trouble, I can help out 🤝

great, thanks!


BUG: Cloned Token Rotates after being created

Kind of a weird one, but when you move your token into a Token Cloning area, the Cloned Token that is generated immediately turns in a different direction. Sometimes it turns 180 degrees, sometimes 90, sometimes like, 5. Once the token moves further it is fine, but it's just that first moment.

I haven't seen something like you described, and I can't reproduce this problem, do you have any other information or steps to show it?

Yeah, this is really weird, but I've tracked it down. It happens when you have this module, Monk's Token Bar, and Auto-Rotate all active at the same time. Disable either one of the others and it doesn't happen anymore. I have no idea why it would be associated with Monk's Token Bar, since to my knowledge that module doesn't affect the actual token at all, so it's pretty weird that it's a necessary component of duplicating this bug.


Immovable Rods can spawn on the wrong maps

Description

The immovable rod event can spawn on the wrong map, including the salvage planets.
Reproduction

addgamerule ImmovableRodSpawn, rinse and repeat until it happens on the wrong map. May require preloading a salvage map.
Screenshots

Additional context

It would also be pretty funny to make rods on planets cause lava in their path, but that's more of a request haha.

Also includes the trade outpost, meaning the cargo shuttle is disproportionately likely to be annihilated.


Package request: kando

Project description
A highly customizable cross platform pie menu for the desktop
Metadata

homepage URL: https://github.com/kando-menu/kando
source URL: https://github.com/kando-menu/kando
license: mit
platforms: unix, linux, darwin, windows

Ops! Duplicate of #297267


[flagd] Support custom schemes (name resolvers)

As described here, we wish to support custom name revolvers for additional control and configuration according to user's infrastructure. In order to make use of this, we must support the creation of channels created with NettyChannelBuilder.forTarget, and expose an options in the flagd that use a "target string" instead of a host/port combination.
Requirements:

optional usage of channel built using .forTarget (see: https://github.com/open-feature/java-sdk-contrib/blob/4197d3231d68fb686b61ac1ca5eb8c278044a0e3/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/common/ChannelBuilder.java#L30)
changes in options to allow specifying a target string

support env-var based configuration as well, as with existing options
consistent with https://github.com/open-feature/go-sdk-contrib/issues/585

no breaking changes
associated unit tests (e2e not necessary)

cc @pradeepbbl

sounds good to me and I'm happy to work on it

sounds good to me and I'm happy to work on it

assigned!


ARROW-13511: [CI][R] Fail in the docker build step if R deps don't install

@github-actions crossbow submit -g r

I think building the things in Suggests has led to the build rebuilding the markdown content, which then causes it to fail due to other dependencies in the vignettes.

I think building the things in Suggests has led to the build rebuilding the markdown content, which then causes test-r-without-arrow to fail due to other dependencies in the vignettes.

Should be unrelated to this change, right?

I think building the things in Suggests has led to the build rebuilding the markdown content, which then causes test-r-without-arrow to fail due to other dependencies in the vignettes.

Should be unrelated to this change, right?

D'oh, of course

I think building the things in Suggests has led to the build rebuilding the markdown content, which then causes test-r-without-arrow to fail due to other dependencies in the vignettes.

Should be unrelated to this change, right?

D'oh, of course

I had originally applied warn=2 to all dependency installation, which would have caused that build you noticed to fail earlier, but it failed in a few other places (test-r-versions failed because duckdb isn't available on R < 3.6, etc.) and it seemed not worth trying to track down all of the quirks of the optional packages in all of our different builds.

@github-actions crossbow submit -g r
It's add there were so many failures before — at least some of which looked transient so I'm running this again. The change looks good + a beneficial one to me.

@github-actions crossbow submit -g r

@github-actions crossbow submit -g r

@github-actions crossbow submit -g r
rebase to bring in the skips on duckdb


Unable to create a signed url for Google Storage using service account on App Engine

I'm unable to successfully retrieve a signed url for a Storage object in our App Engine app, using the default service account.
Logs show the error:
{
  "textPayload": "Message: Client error: `POST https://iamcredentials.googleapis.com/v1/projects/-/serviceAccounts/abstract-key-xxxxxx@appspot.gserviceaccount.com:signBlob?alt=json` resulted in a `403 Forbidden` response:",
  "insertId": "xxxxxx",
  "resource": {
    "type": "gae_app",
    "labels": {
      "module_id": "default",
      "version_id": "20200811t133023",
      "zone": "australia-southeast1-1",
      "project_id": "xxxxxx"
    }
  },
  "timestamp": "2020-08-11T09:13:09.844868Z",
  "labels": {
    "clone_id": "xxxxxx"
  },
  "logName": "projects/xxxxxx/logs/stderr",
  "receiveTimestamp": "2020-08-11T09:13:10.178345276Z"
}

Environment details

OS: Google App Engine runtime: php73
Package name and version: "google/cloud-storage": "^1.22"

Code example
$nowPlus24Hours = new \DateTime();
$nowPlus24Hours->add(new \DateInterval('P1D'));
$storage = new StorageClient();
$signedUrl = $storage->bucket($bucketRef)->object($imageRef)->signedUrl($nowPlus24Hours);

Make certain that your App Engine service account has the iam.serviceAccounts.signBlob IAM permission. It's part of the Service Account Token Creator role.

As viewed in the IAM & Admin section of the Google Cloud Platform console the service account does has the role Service Account Token Creator.

Perhaps interesting is the fact that instead of relying on GOOGLE_APPLICATION_CREDENTIALS if I specify a key file (for the same service account) things work and I no longer get the error message in the logs.
Code Example
$storage = new StorageClient([
  'keyFilePath' => __DIR__ . '/../../config/abstract-key-xxxxxx.json'
]);

Since I'd generated a new key so that I could specify the key file, I tried removing the old key and things are now working as expected (without having to specify the key file in the live environment). The effect was not immediate though - I assume there must be some time before the auth is rechecked (and therefore registering the updated permissions).

Please ignore the last comment. I was mistaken. Without specifying the key the retrieval of the signed url fails.

I just wanted to add that I have the same Environment details (php73 and "google/cloud-storage": "^1.22") and I'm experiencing the exact same problem as bretttoolin.
It's possible to sign the url if I do it on local machine with a key file (for the App Engine default service account). However when deployed to App Engine, it uses the same service account but still fails. I get the same error message but also this:
"Request had insufficient authentication scopes".

I'm also experiencing this issue. php73, "google/cloud-storage": "^1.23".
Trying to let GAE handle authentication itself using the default service account, but getting the same "Request had insufficient authentication scopes" and "...signBlob?alt=jsonresulted in a403 Forbidden..."
Made sure i had the Service Account Token Creator role setup in IAM, but no luck.

I'm experiencing the same issue. Service Account Token Creator role has been assigned to the App Engine default service account, but still no luck.

I'm experiencing the same issue on Coud Run. Service Account Token Creator role has been assigned to service account, but still no luck.

I believe the issue is for some reason the default scope, https://www.googleapis.com/auth/devstorage.full_control, is insufficient when using Compute Metadata credentials. Try this:
$storage = new StorageClient([
    'scopes' => [
        'https://www.googleapis.com/auth/iam',
        'https://www.googleapis.com/auth/devstorage.full_control',
    ]
]);


Determine scoping of Cluster registry types

I realized today that despite our numerous discussions on the subject we don't have an issue dealing with what the scope of the cluster registry API should be.
Options:

Only cluster-scoped
Only namespace-scoped
Both

/sig multicluster

I believe that at a minimum, we should do a namespaced-scoped resource. We know there to be use-cases for namespacing with the cluster registry; example: a multitenant cluster where different tenants know and care about different clusters. This implies that we should make a namespace-scoped resource.
A common theme of discussion has been why we shouldn't make a cluster scoped resource and have everyone operate their own cluster registry (ie, run your own in your own namespace). I don't think that's a good solution because we do not have the any to support for tenant-by-tenant API aggregation or CRDs or ways to make kubectl usable in that scenario. One of the big value adds of API aggregation is that you can use a single client configuration to talk to multiple API groups. If I have an API aggregation, and then a new random API server that I can't use gracefully with the rest of my kube APIs, that outlier API isn't going to work nicely with the rest of the system. For example, do I have to plumb the coordinates of the API server into references from API groups that are aggregated?
To me, the question is whether we should also do a cluster-scoped resource. I don't personally think a cluster-scoped resource is absolutely necessary, but I don't want to prevent people from having it available to them if they want it. Cluster operators can make a choice about which API groups they allow users to use. Likewise, people who want to operate their own copies of the cluster registries if they choose to do so.
I would be in favor of doing both ns- and cluster- scoped in order to move forward on this subject. I don't think everyone needs to accept the same solution. We shouldn't imagine that doing so would be free of cost. Some factors to consider:

We should ensure both scopes stay in sync
If we build two different resources, we're effectively forcing APIs that work with the cluster registry to make a choice about whether to implement integrations with either or both resources

I will say that in another community project, the service-catalog, we made an early design choice to make certain resources cluster-scoped, and that seems to have been viewed as a great limitation due to issues around access control. We are currently working on adding ns-scoped versions of these resources (https://github.com/kubernetes-incubator/service-catalog/pull/1826 if people are interested). Namespaces are the fundamental unit of access control currently implemented in Kubernetes - we should use them. Our users want to.
Another theme that's been discussed several times is finding new ways to solve the problems of access control in order to provide more flexibility for cluster-scoped resources using ACL filtering. I'm supportive of developing better approaches to this problem in Kubernetes, but I don't think we should block on that here. For the record, ACL filtering on list/watch cannot be implemented in a consistent, ordered manner because:

Not all authorizers have the ability to provide a list of resources a subject has access to
Authorizers may have their state changed at any time out of band to kubernetes, making it impossible to implement ACL-filtered list/watch from a particular resource version

We had a call to this discuss this today and arrived at a consensus to make the cluster resource namespace scoped.
As a next step, we will determine a conventional namespace to hold globally available Clusters that will have a permissive RBAC configuration for GET (one example of such a policy would be anyone in system:authenticated group could GET the cluster resource from this namespace).
@thockin mentioned that this would be the third such special namespace that he's aware of and that we should consider discussing the problem of 'special' namespaces in SIG architecture.

Thanks for the summary, @pmorie!
To add a bit more color to the conventional/"special" namespace discussion, we discussed a few potential (not mutually exclusive) ways we can move forward:

A single namespace that is defined to not be shared among control planes, that is commonly accepted as holding a “global” set of clusters, and that is never replicated to other control planes.
A naming convention that specifies which namespaces are private to a specific control plane.

This could be a sig-multicluster or a Kubernetes-level convention.

An annotation (that could potentially become a field) on the namespace object that specifies that the namespace is “special” and should be treated differently from other namespaces. As a strawman example, this could be an IsSystem annotation that multi-cluster tools understand to imply that the namespace should never be duplicated between clusters.

The addition of a special namespace is intended to address the concern that having cluster namespaces means that users who simply want to have a list of clusters, or controllers that want to read a list of clusters, won't know where to find that list of clusters. We believe that defining a conventional namespace in which they live is an acceptable alternative to a cluster-scoped object, and having only one object definition is better in the long run.

So - now that this is determined, can we close the issue?

Yes, I believe so.
Just to close the loop, the decision was to go with a namespaced cluster object and introduce a "global" namespace for cluster registry records that can be used in lieu of the cluster scoped objects.


updated survey text and link in prefooter

Changes in this PR:

Warmed up the pre-footer intro text to 'Help us improve this service"
Reduced button text to 'Complete our short survey"
updated translates to reflex new wording in django.po.
renamed the html include to 'help_improve_this_service.html' to make it match the new text.

Trello card / Rollbar error (etc)
https://trello.com/c/X2pS402f/1081-✔-aa-how-can-this-service-be-improved-button
Screenshots of UI changes:
Before

After

[ ] Requires env variable(s) to be updated

 ✔ AA | PUI - relook at 'How can this service be improved' text & button

Codecov Report

Merging #786 (6a5744d) into main (080ab76) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #786   +/-   ##
=======================================
  Coverage   93.06%   93.06%
=======================================
  Files          30       30
  Lines        1226     1226
  Branches       62       62
=======================================
  Hits         1141     1141
  Misses         68       68
  Partials       17       17

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

not this one

I need to add a aria label for this, but will did it after being merged.
Just safer for me I think.


Create a new vimeo video that features VSecM

There are some (very minor) changes between VSecM and Aegis (such as the current binary is safe in Sentinel, instead of aegis). So it’s fitting to create a new video

Create a new walkthrough video to be hosted on Vimeo and YouTube.
Create a new collection for VSecM on Vimeo.
Share the video in various channels when completed.
add the video to the docs too

I created one; but we need another one for the use cases.
Created an issue for that already.
Those two videos will cover most of the bases.
After that, we can create more on a case-by-case basis, or when we add more use cases etc.


[core,rdstls] fix rdstls parsing

When parsing the rdstls PDU, don't set the stream position at the end.
To know the pduLength is enough getting the last field length and the stream position.
This fixes transport_read_layer_bytes failing because it was getting on toRead = 0.

@joantolo please explain with a little more detail.
you do reduce this to parttial parsing here so if that fixes something it smells like another bug is hidden

@freerdp-bot test
@joantolo ok, added a check in transport_default_read_pdu to handle complete PDU with no additional data to read correctly.