Link generation in custom response object

It would be cool if link generation supports custom response objects.
Example:
        {
            "data": [
                {
                    "firstName": "Jhon",
                    "lastName": "Doe",
                    "links": [
                        {
                            "method": "GET",
                            "uri": "https://localhost:5001/api/person/5",
                            "relation": "Self",
                            "message": "Self link"
                        }
                    ]
                }
            ],
            "statusCode": 200,
            "message": "success"
        }

Hello @vpetkovic, thanks for submitting this issue.
First of all, I'm sorry for the delay in replying to you.
I totally agree with you, and I'll implement an adapter layer on top so we can define our root-level model with access to context information for capturing the request/response data for filling statusCode, for example.
I will also provide a default adapter, which will contain "data" and "links".
Thanks for the suggestion and I will come back to you soon. ✌


Generates wrong type field.

Example section of pipes-csv.cabal:
test-suite hunit
  type: exitcode-stdio-1.0
  main-is: test-pipes-csv.hs
  ghc-options: -w -threaded -rtsopts -with-rtsopts=-N
  hs-source-dirs: test

  if !flag(test-hunit)
    buildable: False
  else
    build-depends:
        base
      , HUnit >= 1.2
      , pipes                 >= 4       && < 5
      , pipes-bytestring     >= 2       && < 3
      , pipes-csv
      , cassava
      , vector
      , bytestring
      , test-framework       >= 0.6
      , test-framework-hunit >= 0.2

transforms to an illegal section whose type has "-":
test-suite hunit

    if !flag(test-hunit)
        type: -
        buildable: False
    else
        build-depends: base -any, HUnit >=1.2, pipes >=4 && <5,
                       pipes-bytestring >=2 && <3, pipes-csv -any, cassava -any,
                       vector -any, bytestring -any, test-framework >=0.6,
                       test-framework-hunit >=0.2
        type: -
        buildable: True
    type: exitcode-stdio-1.0
    main-is: test-pipes-csv.hs
    buildable: True
    hs-source-dirs: test
    ghc-options: -w -threaded -rtsopts -with-rtsopts=-N

IMHO, the issue has caused by a bug in the version of Cabal that was used at the time. I can no longer re-produce this error with any recent build of jailbreak-cabal (which now uses Cabal >= 1.18.x).


HEAP tables not mentioned

The page doesn't say anything about HEAP tables which also exist as an alternative to the 2 already mentioned. It would be useful to include this in the comparison.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5240cd58-9cd1-6492-4f81-3ae2e827835d
Version Independent ID: 0ebfc801-313c-236c-e41a-fed1ca1efbcc
Content: Performance tuning with ordered clustered columnstore index - Azure Synapse Analytics
Content Source: articles/synapse-analytics/sql-data-warehouse/performance-tuning-ordered-cci.md
Service: synapse-analytics
Sub-service: sql-dw
GitHub Login: @XiaoyuMSFT
Microsoft Alias: xiaoyul

@sdebruyn Thank you for sharing feedback. We are actively validating it. We will share updates soon.

@XiaoyuMSFT Could you please validate customer feedback and enhance document as appropriate? Thank you.

Thanks @sdebruyn for taking the time to file this issue. Apologize for the delay. A deeper discussion on heaps isn't really warranted in the optimizing ordered clustered columnstore article, but is discussed as a faster transient data loading alternative in articles such as https://learn.microsoft.com/en-us/azure/synapse-analytics/sql/best-practices-dedicated-sql-pool.
#please-close

#assign:WilliamDAssafMSFT


stake for delegator and guardian needs the last one to be "now" from state and not event.

done before 0.4.0


Bulk add products to collection

In order to make creating collections simpler, there should be a "Add to collection" bulk action in the product list dashboard view. After selecting this option a modal should pop up with a form to select one collection from the list of existing ones.

This would be much easier to implement if the view was a React one. We could even allow a new collection to be created.

We decided to hold this until we have more React views in the dashbaord.

Will be implemented as part of #3537.


why azure langchain  answer question  confusion

System Info
0.0.191 mac os python 3.9
Who can help?
No response
Information

[ ] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[x] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
just simple demo
simply asked who you are, and he answered a lot of inexplicable words

Expected behavior
no

I believe you are using Completion model, instead of Chat Completion model, So llm has continued your sentence.
try AzureChatOpenAI instead of AzureOpenAI
https://python.langchain.com/en/latest/modules/models/chat/integrations/azure_chat_openai.html

I believe you are using Completion model, instead of Chat Completion model, So llm has continued your sentence. try AzureChatOpenAI instead of AzureOpenAI https://python.langchain.com/en/latest/modules/models/chat/integrations/azure_chat_openai.html

👌 thanks


[Question] running runtimes apart from runc (Untrusted Workload Runtime)

As mentioned in Containerd 1.1.0 release notes, I tried to run runv, but it doesn't work.
Is there any example or it is tested for any other runtime than runc ?

@kunalkushwaha It should work, could you please fire issue on runv repo? I believe Kata maintainers would help you out here.

@resouer thanks. Will ask there too. Earlier I had asked one related question.. but there was no activity of that So thought discussing here.

This is supported now.
Containerd 1.1 supports the io.kubernetes.cri.untrusted-workload annotation;
Containerd 1.2 supports the runtime handler.


Speed

This changes most (but not yet all) of our FFT operations to use PyFFTW. With this change, I see speed boosts of a factor of 6+ in both atm.evaluate_galaxy() and atm.evaluate_point_source(). Total runtime is about 4 min. Profiling shows that the main steps take the following amount of time:

fit_galaxy_single: 5s
fit_galaxy_multi: 13s
fit_position_sn_sky_multi: 222s (89%)

The final step just takes a really long time to converge (14 iterations, ~150 function calls), much more than the fit_galaxy_* functions. Also, the final gradient and chisq don't look very good. Maybe l_bfgs_b is not a good optimizer for this part of the problem? Or more probably there's probably a bug...

There is definitely a bug. The final fit no longer finds anything that looks like a sn. I'll see if I can find any obvious issues.

Sorry! :)

I don't know if this has a big enough effect to be the bug, but the only
issue I have found is that in the galaxy/point source evaluate function,
the adr term is not being added to the offset. I would try fixing this, but
I think I don't understand the adr part enough in the new code.
On Fri, Mar 27, 2015 at 11:30 AM, Kyle Barbary<EMAIL_ADDRESS>wrote:

Sorry! :)
—
Reply to this email directly or view it on GitHub
https://github.com/snfactory/ddtpy/pull/6#issuecomment-87044601.

In the refactor, I realized that the ADR and convolution can be combined into a single array, since both are fixed. Both terms are factored into self.fftconv. You can see how the ADR is put into this array in AtmModel.__init__().
Did you add any logging output code? If so, push it and I'll try to use it to debug it myself. Or we can do it next time we get together. I'll also try to write some unit tests (which I should have worked on before this pyFFTW performance stuff!).

I did add logging code, and just pushed it. It just makes a dictionary with
data, atms, and sub-dictionaries with the results of the fit at three
points: after fitting the master ref, after fitting all the final refs, and
after fitting the non-refs. These dictionaries each have the galaxy, sky,
snctr, ctrs, and sn at that point.
The dictionary is saved in the data directory (need to change that) as
DDT_output.pkl. run scripts/ddt-plot DDT_output.pkl to see the model and
residual at each step (need to add labels to plot though.)
On Fri, Mar 27, 2015 at 12:02 PM, Kyle Barbary<EMAIL_ADDRESS>wrote:

In the refactor, I realized that the ADR and convolution can be combined
into a single array, since both are fixed. Both terms are factored into
self.fftconv. You can see how the ADR is put into this array in
AtmModel.init().
Did you add any logging output code? If so, push it and I'll try to use it
to debug it myself. Or we can do it next time we get together. I'll also
try to write some unit tests (which I should have worked on before this
pyFFTW performance stuff!).
—
Reply to this email directly or view it on GitHub
https://github.com/snfactory/ddtpy/pull/6#issuecomment-87058158.


not respon upload image from path source..whay?

https://user-images.githubusercontent.com/78825059/148652591-b6c9ef62-fe1a-4d23-a479-706b6d935106.mp4

https://user-images.githubusercontent.com/78825059/148652569-ec45c52c-9eeb-44c4-989a-91492ab4b1d1.mp4

{
"pin": [
{
"pinboard": "kitchen",
"file_path": "C:/Users/admin/Desktop/images/1.png",
"title": "My Pin",
"description": "This is my pin",
"alt_text": "A beautiful dog",
"link": "",
"date": ""
},
{
"pinboard": "kitchen",
"file_path": "C:/Users/admin/Desktop/images/2.png",
"title": "My Pin",
"description": "This is my pin",
"alt_text": "A beautiful dog",
"link": "",
"date": ""
},
{
"pinboard": "kitchen",
"file_path": "C:/Users/admin/Desktop/images/2.png",
"title": "My Pin",
"description": "This is my pin",
"alt_text": "A beautiful dog",
"link": "",
"date": ""
}
]
}

The problem comes from the Pinboard, I have to update the bot because the Pinboard part is not working.
Your data file is correct by the way.

Hi @maximedrn , did you solve the Pinboard problem already? Thnks ;)

@rpgraul did you find a solution?

@benx13 sorry, no solution yet :/


Delayed laserscans when clock times are out of sync

Description
Webviz shows delayed laserscans when hosted on a robot and a client's clock time is less than the robot's clock time.

Steps To Reproduce
Run webviz on a robot and set your computer's clock back a minute.

Do you experience the same issue with Foxglove Studio? https://foxglove.dev/docs/studio/connection/ros1 / https://foxglove.dev/docs/studio/connection/ros2


WIP: generate chunk geometry using wasm

No description on this PR 🤔.
Let's re-open when it's clear what the contents are.


Add image name suffix if missing

This PR looks at the startup argument name and adds the image suffix ('.img7') if it is missing. This allows one to launch Dolphin7.exe with 'DPRO' instead of 'DPRO.img7'. Given that the VM requires an image, .sml, and .chg it seems reasonable to reduce the typing overhead required.
Since I'm actually submitting new code with temp variables etc, I would welcome feedback and guidance about naming conventions and coding style. Is there some reference to point to?
Finally, while changing the default image from 'Dolphin.img7' to 'DPRO.img7' is useful for us, it raises the question of image names. I wonder if DCORE and DCE are really needed. I appreciate the idea of moving toward a build up model rather than a tear down model (and have contributed some things that I think will eventually help in that direction), but don't see that the other two images are much use now. Perhaps the DPRO image ought to be renamed Dolphin and the prior default image name supported (some users might have scripts that rely on it).
Thanks!

@blairmcg, Thanks. I'll check it out.

Sorry, @jgfoster but even with @blairmcg 's suggestion I still don't think I would be happy with this change.
The problem is that we are splitting the responsibility of command line handling between the VM (here) and the image (where your recent additions give excellent service). Hence you are having here to make inferences about the purposes of the argv array contents that not only increases the complexity of this piece of code but also reduces the flexibility of what the command line handling in the image may subsequently decide to do.
The other observation I would make is that invoking Dolphin without an image name parameter probably shouldn't be allowed at all. Or certainly not encouraged. The only reason I changed the default was to make invoking the debugger easier but that can of course be done by altering the project file anyway.
The first thing any userdev should do it to save the default image (as it stands, DPRO.img7) under a different name. Otherwise, you'll end up modifying what is essentially a system file and have to reinstall if you want to reset back to a known state. I'm writing a new Getting Started page that suggests this. If this step is followed then one should never need to invoke Dolphin7.exe on it's own. The correct way to start Dolphin should always be to double click an image file.
For the same reason I don't think it is necessary to change the booted image names. I agree that at some point DCE can probably go but DCORE and DPRO both convey information in the names more than DOLPHIN on its own would do. As I said before I believe DCORE is useful because it is intended to be the minimum possible working development image (it is currently too big and should probably be pared down in future). Changing the names to me is just "churn" (i.e. effort without commensurate reward) and would involve changing the product classes in the image, the website and the documentation.
With regard to variable naming, I'm not normally a fan of hungarian notation for it's own sake because surely the whole point about having a typed language is that you can always find the type with a single keystroke anyway. The exception to this, of course, is when the C++ type doesn't accurately reflect the "real" type of the variable. e.g. in the case of null terminated strings, it is useful to prefix the variable names with sz because this convey information that the C++ typing system does not. Other than that, I'd just name stuff as you would do in Smalltalk (not in the anInteger stye though).

@jgfoster if there did turn out to be overwhelming enthusiasm for this change I think we should have to ditch the idea of a default image name and always insist that the first parameter in the command line is the image and it must always be present. That way the coding would be trivial and the parsing of the command line in the image would still be straightforward.

Actually, @jgfoster, I think I've been a bit harsh here. If you still want to do this go ahead but with the suggestion above, i.e. that the image name must always be present as the first parameter. I think the in image code will need changing too.

@objectarts, thanks for the comments and the progression in the ideas. This isn't an area I feel strongly about at all. Mostly I tried Dolphin7 DPRO on the command line and it reported that the file did not exist. I figured that if the first argument (if present) is going to be treated as an image name then finding the right file is no worse than reporting an error! I viewed this as a very incremental change that addresses one narrow situation. I probably complicated the discussion by raising the issue of default names (my offered code doesn't address this issue at all). I'll go ahead and try @blairmcg's suggestion--mostly to learn more Windows coding.
I can take out the default but don't see that it does any harm. The image code already ignores the first argument (if present) so there will be no impact on the image code. I was even thinking of presenting a File Open Dialog as an alternative to the default. Again, I'm mostly tweaking in a small area to get my toes in the water. I really don't have a vision of what this should do and welcome your guidance.

Ok, I don't like the loop through all the args looking for a non flag. Can we ensure that the image if present must always be the first parameter. Even that I don't really like because both the VM and image have to know that flags begin with / or -. But I can probably live with that I guess.

@blairmcg, I don't see that there is an ANSI version of PathCchAddExtension while there is one of  PathAddExtension. Thoughts?

Somehow the most recent edits appear to have much more diffs than I actually made. The short version is in StartDevSys starting at line 89:
	if (__argc < 2)
		return ReportError(IDP_NOIMAGENAME);
and then in FindImageNameArg() starting at line 30:
	static char achImageName[_MAX_PATH];
	char* filePart;
	::GetFullPathName(__argv[1], _MAX_PATH, achImageName, &filePart);
	return achImageName;
It turns out that using the built-in functions was more complicated (the basic one is deprecated and the complex one uses wide characters).

I'm OK with that if @objectarts is. It is certainly simple.

There seems to be enough uncertainty about what is wanted that I'll just close this.


PEM_write_TYPE() wrong return value in man-pages

Affected:

openssl 1.1.1s
openssl 3.0.7

Example: https://www.openssl.org/docs/man3.0/man3/PEM_write_bio_ECPrivateKey.html

[...]
PEM_write_TYPE() and PEM_write_bio_TYPE() return the number of bytes written or zero on error.
[...]

Actually this is wrong. For example, PEM_write_bio_ECPrivateKey is implemented using macros (see include/openssl/pem.h:133 for openssl 1.1.1s. The macro returns PEM_ASN1_write_bio(...) which is implemented in crypto/pem/pem_lib.c but returns 1 on success, and 0 on error. Length of data is never returned back to the caller.
This probably affects all PEM_write_TYPE() functions.

@paulidale Hi, can I work on this as my first contribution to open source?

@paulidale Hi, can I work on this as my first contribution to open source?

Sure, just submit a PR, please

Hi, can I work on this if nobody is working ? I will wait for response for few hours.

@blazmonster Hi, can you find where this sentence is written in this repo?

PEM_write_TYPE() and PEM_write_bio_TYPE() return the number of bytes written or zero on error.

I went through the doc folder and tried to search but did not find it.
Other functions' doc are correctly stated in the repo. For example doc of PEM_write_bio_CMS_stream gives that 'returns 1 for success or 0 for failure.'
I'm not sure there anything I missed or not.

@paulidale Hi, can I work on this as my first contribution to open source?

@paulidale Hi, can I work on this as my first contribution to open source?

Please feel free to do so.

Hello, this issue is Always open, i would like work on this

Feel free to work on this.

@LingkKang
We can find the description (about PEM_write_TYPE() and PEM_write_bio_TYPE() return the number of bytes written or zero on error) in following link.
https://github.com/openssl/openssl/blob/OpenSSL_1_1_1s/doc/man3/PEM_read_CMS.pod
you can find some hint from https://www.openssl.org/docs/man1.1.1/man3/PEM_write_bio_ECPrivateKey.html.


Fixes Row slicing. Fixes #184.

Issue #184 reports a bug in the Row.__getslice__ method. This commit fixes that bug and includes a simple test to verify Row slicing works.

Thanks!


ISSUE_TEMPLATES ref pulsar

#235
ISSUE_TEMPLATES ref pulsar
sorry，last pr about this issue have a error  commit name .

We may need : Bug report, Enhancement request, Feature request at this moment.

Close due to no more update.


Rspec/LetSetup

See discussion here https://github.com/datarockets/ruby-style/issues/58 about LetSetup.  LetSetup prevents us from using let! to set up data in the DB, instead prefering before blocks.  let! is a wrapper around before, so I suggest setting this cop to explicitly be false.

I think it already complains if we use let! without an explicit reference within the test no?

Correct - this would remove that complaint and allow you to do let! to set up data instead of (potentially multiple) before blocks.  This is a suggestion to disable LetSetup, that may not have been explicit/clear

Mislinked - reopened


Address the IGPUBuffer concurrency issues with a Readers/Writer lock

The pseudoMoveAssign model is very good.
It allows us to not have to explicitly rebind every single place where the buffer is being used.
However this check bases itself on an assumption of single-thread access, if a thread was to perform the "isRebindNecessary" check while pseudoMoveAssign was being executed and caught the variables in an incomplete state... we would have a problem.
This is why a lock is necessary on most methods of IGPUBuffer to make the pseudoMoveAssign an atomic operation.
Finally to increase paralelism a readers/writer lock should be used, as pseudoMoveAssign is a rare operation and all the read-access to IGPUBuffer's member variables would not need to be serial.
Note: Investigate whether IBuffer in general needs this

@Crisspl is removing this cancerous API from the next vulkan branch


Is necessary to FragmentManager

Hi, I've 2 FrameLayout and replace these guys with 2 fragments. But sometimes, when I try to get the fragment inside the supportFragmentManager(or ChildFragmentManager) when onViewStateRestored is called, the device freeze and logcat say: Fragment (fragment) is not currently in the FragmentManager.
The view(1) of library(SlidingUpPanel) is another fragment and this 2 FrameLayout(2) are inside the view(1).

This doesn't seem like an issue with the library. The panel doesn't do anything specific when it comes to FragmentManagement. If fact, the umanoapp has a very similar functionality, where is slidingView is a fragment, and everything seems to work fine.  I would recommend inspecting your fragment transactions code.


Additional Data Points when scanning for data points for Wipro 16Amp Smart plug

Hi @jasonacox
Great work, this library!
So I'm based in India and I recently purchased this particular 16 Amp Smart Plug, which is based on Tuya protocol version 3.3. I'm using it with Smart Life app and it's working without any hiccups.
Now when I poll for local devices using the scan command with tiny tuya, the following status is returned:
Status: {'1': False, '9': 0, '17': 1, '18': 0, '19': 0, '20': 2295, '21': 1, '22': 552, '23': 35482, '24': 18486, '25': 1850, '26': 0, '38': 'memory', '39': True, '40': 'on', '41': False, '42': '', '43': '', '44': ''}
As you can see, we get a few additional Data Points which aren't listed in the readme for the library.
If we click on the 'setting' option in the app after setting up the device, as shown in the following picture,

we land on page in the Smart Life app:

Now, I've already mapped the extra Data Points(in red) to their respective settings as can be seen in the second image above.
Here's a summary:

DP ID
Function Point
Type
Range

38
Power-on state setting
enum
off, on, memory

39
Overcharge Switch
bool
True/False

40
Indicator status setting
enum
none, on, relay, pos

41
Child Lock
bool
True/False

42
UNKNOWN
NA
NA

43
UNKNOWN
NA
NA

44
UNKNOWN
NA
NA

Can you please add this info to the readme? Please let me know if any concerns.
Thanks!

Hi @manj9501 - Thanks for great information!  Would you want to submit a pull request for the README.md change so you get credit for this contribution?  If not, I can add it.

Submitted PR #133, please take a look.

Thank you @manj9501 !  Changes merged.

Thanks much @jasonacox !


Revert "Adding support for dark mode"

Reverts brave/ethereum-remote-client#59

Reverting due to a lot of white on white on setup screens


Versioning

Replace hardcoded version
Implement global VERSION + bumpversion
Add VERSION to userAgent

Hi @runxinw, could pls review and merge it ? thanks


Log to analytics the total transaction counts users on mainnet and testnet

Upon sending a transaction (confirmation via actionsheet, don't wait for block confirmation)
if testnet
    testnetTransactionCount += 1
else
    transactionCount += 1

Looks like this for iOS SDK:
mixpanelInstance.people.increment(property: "testnetTransactionCount", by: 1)

Bump.
O iOS, we log it along with "Screen: Txn Confirmation Successful" #3028


Skins not working

I don't know if this is origins fault or not but i came into this problem when i downloaded the mod. My skin does not show up when I'm playing as an origin it just shows up as Alex. For the first time i used this mod it worked perfectly but when i logged off and went back later my skin was just Alex and no matter what i did it would not change. I saw somewhere that a possible reason that this happened was because of the launcher not signing into your Microsoft account or just not having internet and i think i have the internet problem because i keep getting these messages in the launcher saying that they cant connect to Microsoft and they cant verify what items i have but i have good internet and signed into my account so i have no idea why this doesn't work. My skin shows up fine on the vanilla launcher but when i use the Cursed Forge Minecraft launcher that's where i have my problem. Hope you can help!

nevermind i fixed it


Condense layers in Docker image?

MicroBadger gives us a nice report on the current layers etc in our image


split ignore unto query and input

fixes #20
Use [GraphQLIgnore] to mark a field as ignored in both Input types and Query schema in EntityGraphQL.
Use [GraphQLIgnore(GraphQLIgnoreType.Query)] to mark a field as ignored in the query schema. If the type is also used in a mutation input type, the field is available.
Use [GraphQLIgnore(GraphQLIgnoreType.Input)] to ignore a field in a mutation input type if the type is also exposed in the query schema, it will be available.
Note [GraphQLIgnore] is shorthand for [GraphQLIgnore(GraphQLIgnoreType.All)]

@JTravis76, does this solve the issue of being able to ignore fields in mutations vs queries?


testing: Feature Request: Better flaky test support

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.10 darwin/amd64.
Does this issue reproduce with the latest release?
N/A
What operating system and processor architecture are you using (go env)?
go version go1.10 darwin/amd64
hklai-macbookpro2:e2e hklai$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/hklai/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/hklai/go"
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/3q/dk8r61l944q42b8g7d2bq57r005d_5/T/go-build136728580=/tmp/go-build -gno-record-gcc-switches -fno-common"
What did you do?
N/A
What did you expect to see?
Better flaky test support, as outlined in the following areas:

Provide a way to annotate flaky tests. For example, there can be a flaky() method in the testing package, and go developers can add a line like "testing.flaky()" in test methods to indicate the tests are flaky. Obviously, this can be done using other mechanisms as well but this needs to be express-able in the test method level (i.e. build tag will not work).

"go test" retries flaky tests natively, if the tests are marked as flaky.

Test options to control the above retry behavior (i.e. number of retries until test passes, delay between retry, etc).

Test retry should work with the -json option, such that downstream processing can determine if a test had been retried, and/or how many times a test is retired.

I understand bazel provides some form of flaky test support, but it does not work well for us because:

the bazel flaky support is per test rule which is not granular enough.
We consciously decided against the use of bazel in our project.

In absence of the above, our only option is to implement a wrapper program that calls "go test", and then run "go test" again on the failed tests that are known to be flaky.
What did you see instead?
N/A

And to be clear, flaky tests are bad and they should be fixed ideally. However, flaky tests do happen from time to time and feature like this is important for productivity and velocity reasons.
And here is the use case I have in mind:

When a test starts to flake, developers can quickly annotate it and "go test" can take care of retrying it, to reduce of chance of test job failing, which can potentially block other developers from merging code. This reduces disruption to dev cycle as developers do not need to manually re-run these flaky test jobs, and their presubmit jobs are more likely to pass.

The developers who are responsible for the flaky tests will fix them and eventually remove the flaky annotation.

Another approach is to completely disable flaky tests in CI but it clearly reduces test coverage, and these tests can be further broken before they can be restored.
CI can be more resilient to flaky tests and developers won't get blocked just because a test starts to flake.
This is also why test retry should be noted so that people can take action to address them as well.

I disagree pretty strongly.  The point of a test is to detect an error.  A flaky test is worthless, because you don't learn anything when it fails.  It just wastes time.  If a test is potentially flaky, then it should be rewritten.  A typical simple rewrite is to loop enough times to make it extremely unlikely that all iterations will fail for flaky reasons.
With that attitude, I think the only support the testing package needs for flaky tests is t.Skip, and we already have that.

As mentioned above, t.Skip() (i.e. disable test) is an alternative, but it reduces coverage. The related feature can be broken by other changes and it will be more difficult to reenable the test.
A flaky test is bad, but it is not always worthless. As the project and number of developers grow, a 10% flaky test affects more and more developers, but the fact that it passes 90% of the time is still a valuable signal. I totally agree that all flaky tests need to be fixed/addressed, but until then, we also want minimize the impact to the 10% developers.
Correct me if I am wrong, but I think the simple rewrite suggestion won't work in case TestMain() is involved. A test may require setup/cleanup steps in TestMain() that are not available in the test method itself.

No I am not saying tests passing 90% is OK.
Having flaky tests is not an end state. Over the course of development, some tests are going to become flaky for various reasons. The end goal is to fix the cause of flakiness and make the tests not flaky, but until then, we are hoping to minimize impact to developers (i.e. presubmit failing) without having to remove the test.

Just as the language does not permit unused imports or unused variables, I don't see a compelling reason that the testing package should provide additional mechanisms for permitting flaky tests.

I don't see why this couldn't be solved in a third party package.
func TestThingThatMayFlake(t *testing.T) {
  otherpkg.RerunOnFlake(t, func(t testing.TB) {
    if err := ThingThatMayFlake(); err != nil {
      t.Fatal(err)
    }
  })
}

I am in agreement with @ianlancetaylor. I don't believe we should be adding additional functionality to into the go tool that placates (and inherently encourages) flaky tests.


Rewriting req.url in router with prefix path results in missing slash (/)

Hello, I've been trying to use a npm module (connect-history-api-fallback) and encounter problems that after a lot of debugging I believe boils down to this issue.
When you're in a router that has a mount path, doing a rewrite on the relative root ('') path result in a missing slash, eg with bug.js as below
const express = require('express')
const app = express()
const port = 3000

var router = express.Router();
router.get('/', function (req, res, next) {
    req.url = "/index.html"
    next()
});

app.use('/app', router);

app.use(function (req, res, next) {
    console.log("Rewritten path: " + req.url)
    res.end()
});

app.listen(port, () => console.log(`Example app listening on port ${port}!`))

Running the following commands:
node bug.js
curl localhost:3000/app

results in the rewritten path to be /appindex.html instead of /app/index.html
Environment:
"node": 12.10.0
"express": 4.17.1

This sounds like a bug to me, but maybe I'm doing something wrong? I'm not too expert in expressjs to know for sure (my hunch is the router code doesn't 'remount' the prefix path properly.
Thanks!

Hi @fchu thanks for the report. I see what you mean, though will need to investigate further on what (if any) a fix would look like. To explain what is happening, is that your original URL is /app (no trailing /). When the /app mount is encountered, the routing system will always make sure there is some path there (as in, it doesn't let it become an empty string), so it ends up as req.url === '/' inside the router. Of course, this would translate to a potential original URL of /app/, though that is not what it was.
Then req.url is set to /index.html inside of router, as far as the upper router knows, that / at the beginning was the fake / it injected to ensure that req.url was not an empty string, and so is trimming it back away.
A quick work-around would be to change /app to /app/ in a rewrite above the /app mount.
Anyway, we will investigate further to see if there is a good solution for this issue, but just wanted to put down the above thoughts and a work-around that may get you unblocked while we work on it.

Hi @dougwilson thanks for the prompt reply. I already have a workaround in place in the form of a rewrite like you suggested, so this is not pressing, but I'll add my few thoughts as well in case it could be useful.
I think the root conceptual issue is whether a route is made of paths, or strings:

if they are paths, then /app and /app/ are equivalent, and so are ''  and /, and any logic for (un/)mounting route prefixes should be insensitive to trailing slashes
if they are strings, then there is nothing special to slashes, and route manipulation should strictly be about concatenation of partial routes.

Now I think when the router is in strict mode, it's opting for 1, which is fine for most people. In that case though, maybe the (un/)mounting of path prefixes should employ logic equivalent to url.resolve instead of manual trimming of slashes and keeping track of that state.
Situation 2 is tricker, as I think one big challenge is that after a mounting point '' and '/' are fundamentally different endpoints, and I'm not sure to whether express can handle the different well throughout.
Right now, the router seem to follow both paradigms, if that makes sense.
Hope it helps!

Is anyone working on this issue?
I would like to work on it.

when router adds removed back it add them here
req.url = protohost + removed + req.url.slice(protohost.length)

and the values in this example
req.url = 'index.html' // the leading slash was removed because router thenk it injected
removed = ' /app'
protohost = ''

a way to solve this is instead of concatinating strings use the node:path module to join the three parts.
or create custom code to do that , but it should cover all scenarios (slashes and not).
the problem of using the module is confimity with the rest of the code
also before deleting added slash we could add check that the first char is a slash


Feature - Hand Controllers + Simulation - OCULUS

Overview
This PR adds the Oculus implenentations for hand tracking. It provides a data provider to convert oculus hand data to platform agnostic hand data usable by the MixedRealityHandController.

[x] Hand Controller Data Data Provider and Converter
[x] Profile and Inspector
[ ] Hand Meshing

How to use

The default profile was updated to include the OculusHandControllerDataProvider. Build and deploy to an Oculus Quest device and hands will appear once tracked.

Blocked by / Requires https://github.com/XRTK/XRTK-Core/pull/216

Not seeing any changes in this PR related to the OculusAPI and the "ShouldResolveControllers" call, which filters whether a controller is resolved or not.
This PR did originally pull the changes in the Oculus API related to hands, but now they are committed, @FejZa ?


Automatically injecting the launch darkly service

Currently, this addon auto injects itself into all routes, all controllers, all components and router:main.
I think this makes consumers code harder to understand. Services should be injected when needed so that it is obvious what this.launchDarkly is referencing in each context.
https://github.com/adopted-ember-addons/ember-launch-darkly#launch-darkly-service

Hi @chrisvdp. Just some context around this.
Originally, what you desire was the case for the same reason you mentioned. However the auto inject behaviour was introduced to make things a little easier for the variation Babel transform (https://github.com/adopted-ember-addons/ember-launch-darkly#experimental-variation-javascript-helper)
I can go deeper in to reasons for the auto inject, as well as the babel transform itself if desired. But just wanted to raise that there is rationale behind things being the way they are right now.
There is also a separate discussion to be had around the transform itself, as I don't think it is even relevant in an @tracked properties world which would possibly make this issue more viable. But there is some thought and discussion around what this addon looks like in an @tracked world that I've not yet dived in to.
Would be good to start those discussions though /cc @mansona @jaredgalanis

Started a new issue (#201) for the discussion around this addon in an @tracked world which should address this issue. Closing this one for now. Hope that's cool @chrisvdp .


⚠ Spryr has degraded performance

In 8a41d1b, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 4411 ms

Resolved: Spryr performance has improved in 1723b2f after 15 minutes.


Implement interface detection of dynamic link

Implement interface detection function for dynamic link functions like EIP165.

closed via https://github.com/line/cosmwasm/pull/245


get selectected row_index

Great tool !
When using configure_selection, it would be nice to get not only the selected rows but also the selected indices.
gb.configure_selection(selection_mode="multiple", use_checkbox=False,  pre_selected_rows=[selectedinx])
gridOptions = gb.build()
data = AgGrid(
        shows,
        gridOptions=gridOptions,
        allow_unsafe_jscode=True,
        update_mode=GridUpdateMode.SELECTION_CHANGED
    )

Example of returned data expected
{ "data" : myPandasDataFrame,
"selected_rows : [ {myselectedRow1},{myselectedRow2}],
"selected_indices" : [ 4, 8 ]
}

I use Aggrid to select a row, then display it and edit, and then I went to move to the next row, which requires to know the indice of selected row
Thanks

It wil be done soon!
I'll improve grid return

Hello. Is capability available? Thanks.

Hi, any update on this issue?


RC.4 CCK AC and AC Virtual Lab

@KatieWoe @arouinfar @ariel-phet @kathy-phet circuit-construction-kit-ac/1.0.0-rc.4 and circuit-construction-kit-ac-virtual-lab/1.0.0-rc.4 are ready for RC testing.  This has been a high priority sim.  Document issues in https://github.com/phetsims/circuit-construction-kit-common/issues and link to this issue.
This is a minor spot check to check credits and the XHTML credits issue.
Assigning to @kathy-phet and @KatieWoe for prioritization.  Assigning to @jessegreenberg to test the XHTML credits issue.

Focus and Special Instructions

Issues to Verify

[x] Credits
[x] XHTML Credits Issue, see https://github.com/phetsims/qa/issues/753#issuecomment-993792021 for a description of the test procedure.

These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed.
Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is
"status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.

Link(s)

AC

AC Virtual Lab

AC XHTML

AC VL XHTML

[x] Tester = KW, Platform = Win 11 Firefox , Time = .5

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

https://github.com/phetsims/qa/issues/753 Looks good

QA is done

I took at look at this version of CCK AC and CCK AC Virtual Lab, the scenery SHA looks good and includes the patch. The About dialog opens in XHTML. From the dev tools I tried setting content in the PDOM with a <br> and it worked without crashing.

Thanks, closing.


New version: NomanDhoni.BlinkEye version 2.5.0

Pull request has been created with WinGet Releaser :rocket:
Microsoft Reviewers: Open in CodeFlow

@nomandhoni-cs please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree [company="{Blink Eye}"]

@microsoft-github-policy-service agree [company="{Blink Eye}"]

@microsoft-github-policy-service agree company="Noman Dhoni"


Zod improvements $10 @bounty

Validate phone and other fields better and create reusable schemas.Ex: walletAddress
https://github.com/colinhacks/zod/discussions/1631

i can work on this please assign me ??

@yurimutti Hi, can you assign this to me?

@coder-pink @yadavshubham01
Some important considerations:

We working on this branch and repository before migrating here:
https://github.com/detrash/recy-api/tree/staging

This bounty is paid using tokens (cRecy)

hey @yurimutti I submit PR on this please review it


[$500] Android-Attachments-App crashes on uploading specific PDF

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.85-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:

Launch app
Tap on a report
Tap plus icon near compose
Tap Add attachments
Tap Choose document
Select the below attached PDF

Expected Result:
User must be able to upload all pdf and app must not crash while trying to upload any pdf.
Actual Result:
When user tries to upload specific pdf app crashes.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/115492554/d1be5106-5736-4c39-a9fc-c02c36ef04e3
utest-dl.s3.amazonaws.com_12102_26469_432782_6239948_bugAttachment_Bug6239948_1697510571673%21pdf_rash.txt_X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20231017T095403Z&X-Amz-SignedHeaders=host&X-Amz-Expires=86400&X-Amz-Credential=AK.txt
class-9-maths-chapter-10-solutions.pdf

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f2fe87b1c515e0af
Upwork Job ID:<PHONE_NUMBER>456812544
Last Price Increase: 2023-11-07

Proposal
Please re-state the problem that we are trying to solve in this issue.
Android-Attachments-App crashes on uploading specific PDF
What is the root cause of that problem?
this bug from react
here when we parse json its throws the error because above pdf has maths logic so that contains json string like this

https://github.com/wonday/react-native-pdf/blob/b700b0a2f27b29728dcc9665289e6e628a669f56/index.js#L374
What changes do you think we should make in order to solve the problem?
we need fix this on upstream adding try catch.
or we can add patch fix for this.

@fedirjh Can you review the proposal that has been submitted for this? thanks!

@fedirjh sorry for the delay. proposal updated https://github.com/Expensify/App/issues/29743#issuecomment-1766313301

@fedirjh Yes this platform-specific code
https://github.com/wonday/react-native-pdf/blob/b700b0a2f27b29728dcc9665289e6e628a669f56/index.js#L408

@pradeepmdk can you address the question by @fedirjh
If we're not able to accept an suitable proposal I will need to pull in another contributor to get this one moving along and finished

i will update now

@fedirjh

this is android specific code
https://github.com/wonday/react-native-pdf/blob/b700b0a2f27b29728dcc9665289e6e628a669f56/index.js#L408

  Platform.OS === "android" || Platform.OS === "windows"?(
                                        <PdfCustom
                                            ref={component => (this._root = component)}
                                            {...this.props}
                                            style={[{flex:1,backgroundColor: '#EEE'}, this.props.style]}
                                            path={this.state.path}
                                            onChange={this._onChange}
                                        />
                                    ):(

so when we upload onchange will be trigger

 _onChange = (event) => {

        let message = event.nativeEvent.message.split('|');
        //__DEV__ && console.log("onChange: " + message);
        if (message.length > 0) {
            if (message.length > 5) {
                message[4] = message.splice(4).join('|');
            }
            if (message[0] === 'loadComplete') {
                this.props.onLoadComplete && this.props.onLoadComplete(Number(message[1]), this.state.path, {
                    width: Number(message[2]),
                    height: Number(message[3]),
                },
                message[4]&&JSON.parse(message[4]));
            } else if (message[0] === 'pageChanged') {
                this.props.onPageChanged && this.props.onPageChanged(Number(message[1]), Number(message[2]));
            } else if (message[0] === 'error') {
                this._onError(new Error(message[1]));
            } else if (message[0] === 'pageSingleTap') {
                this.props.onPageSingleTap && this.props.onPageSingleTap(Number(message[1]), Number(message[2]), Number(message[3]));
            } else if (message[0] === 'scaleChanged') {
                this.props.onScaleChanged && this.props.onScaleChanged(Number(message[1]));
            } else if (message[0] === 'linkPressed') {
                this.props.onPressLink && this.props.onPressLink(message[1]);
            }
        }

    };

first they are splitting the message to array using let message = event.nativeEvent.message.split('|');
2 )after that on message length > 5 means they are splice and join again message[4] = message.splice(4).join('|');
so in this case this specfic pdf data like this

 message[4]  = '[{"children":[],"mNativePtr":-5476376628811613152,"pageIdx":0,"title":"Answer 1:"},{"children":[],"mNativePtr":-5476376628811612288,"pageIdx":0,"title":"Answer 2:"},{"children":[],"mNativePtr":-5476376628811611760,"pageIdx":1,"title":"Answer 3:"},{"children":[],"mNativePtr":-5476376628811610992,"pageIdx":1,"title":"D                        c"},{"children":[],"mNativePtr":-5476376628811609264,"pageIdx":1,"title":"A                                         B"},{"children":[],"mNativePtr":-5476376628811608592,"pageIdx":1,"title":"Answer 4:"},{"children":[],"mNativePtr":-5476376628811464464,"pageIdx":1,"title":"E"},{"children":[],"mNativePtr":-5476376628811462784,"pageIdx":1,"title":"D                            C"},{"children":[],"mNativePtr":-5476376628811461296,"pageIdx":1,"title":"A                            B"},{"children":[],"mNativePtr":-5476376628811459520,"pageIdx":2,"title":"Given:  ABCD is a square in which AB \u003d BC \u003d CD \u003d DA. ΔEDC is an equilateral triangle in which ED \u003d EC \u003d DC and  ∠EDC  \u003d   ∠ DEC \u003d ∠DCE \u003d  60o. To prove:  AE \u003d BE and ∠DAE \u003d 15o Proof: In ΔADE and ΔBCE, as , AD \u003d BC              [Sides of a square]"},{"children":[],"mNativePtr":-5476376628811456928,"pageIdx":2,"title":"Answer 5:"},{"children":[],"mNativePtr":-5476376628811455776,"pageIdx":2,"title":"D                                          C"},{"children":[],"mNativePtr":-5476376628811454912,"pageIdx":2,"title":"A                                           B"},{"children":[],"mNativePtr":-5476376628811452608,"pageIdx":3,"title":"Answer 6:"},{"children":[],"mNativePtr":-5476376628811442448,"pageIdx":4,"title":"Answer 7:"},{"children":[],"mNativePtr":-5476376628811441584,"pageIdx":5,"title":"Answer 8:"},{"children":[],"mNativePtr":-5476376628811441152,"pageIdx":5,"title":"Let ABCD be a quadrilateral with diagonals AC and BD and O is a point within the quadrilateral."},{"children":[],"mNativePtr":-5476376628811439952,"pageIdx":5,"title":"Suppose In ΔAOC, OA + OC \u003e 𝐴𝐶…………..(1)"},{"children":[],"mNativePtr":-5476376628811438464,"pageIdx":6,"title":"Answer 9:"},{"children":[],"mNativePtr":-5476376628811437984,"pageIdx":7,"title":"Answer 10:"},{"children":[],"mNativePtr":-5476376628811437408,"pageIdx":7,"title":"S"},{"children":[],"mNativePtr":-5476376628811435296,"pageIdx":7,"title":"R"},{"children":[],"mNativePtr":-5476376628811434432,"pageIdx":7,"title":"P                                                      Q   Let PQRS be a quadrilateral and ∠1, ∠2, ∠3 and ∠4  are its four angles . Join QR which divides PQRS in two triangles, ΔPQR and ΔQRS. In ΔPQR,  ∠1 + ∠2 + ∠P \u003d 180       ......"},{"children":[],"mNativePtr":-5476376628811433856,"pageIdx":8,"title":"EXERCISE 10B"},{"children":[],"mNativePtr":-5476376628811432944,"pageIdx":8,"title":"Answer 1: (1)"},{"children":[],"mNativePtr":-5476376628811432272,"pageIdx":8,"title":"Answer 2: (1)"},{"children":[],"mNativePtr":-5476376628811427216,"pageIdx":9,"title":"Answer 3: (1)"},{"children":[],"mNativePtr":-5476376628811426736,"pageIdx":9,"title":"Given: parallelogram ABCD, M is the midpoint of side BC and ∠BAM \u003d ∠DAM. To prove: AD \u003d 2CD Proof: Since, AD∥BC and AM is the transversal. So, ∠𝐷𝐴𝑀\u003d∠𝐴𝑀𝐵      (Alternate interior angles) But, ∠𝐷𝐴𝑀\u003d∠𝐵𝐴𝑀 (Given) Thus, ∠𝐴𝑀𝐵\u003d∠𝐵𝐴𝑀 ⇒𝐴𝐵\u003d𝐵..."},{"children":[],"mNativePtr":-5476376628811426016,"pageIdx":9,"title":"As we know angles opposite to equals sides are equal and opposite sides of parallelogram are equal            Now, 𝐴𝐵 \u003d 𝐶𝐷        ⇒2𝐴𝐵\u003d2𝐶𝐷"},{"children":[],"mNativePtr":-5476376628811425344,"pageIdx":10,"title":"So, ⇒(𝐴𝐵+𝐴𝐵)\u003d2𝐶𝐷 ⇒𝐵𝑀+𝑀𝐶\u003d2𝐶𝐷      (AB \u003d BM and MC \u003d BM) ⇒𝐵𝐶\u003d2𝐶𝐷"},{"children":[],"mNativePtr":-5476376628811423904,"pageIdx":10,"title":"∴𝐴𝐷\u003d2𝐶𝐷       (AD\u003dBC)hence proved"},{"children":[],"mNativePtr":-5476376628811422032,"pageIdx":10,"title":"Answer 4: (1)"},{"children":[],"mNativePtr":-5476376628811421504,"pageIdx":11,"title":"Answer 5: (1)"},{"children":[],"mNativePtr":-5476376628811420832,"pageIdx":12,"title":"Answer 6: (1)"},{"children":[],"mNativePtr":-5476376628811419728,"pageIdx":12,"title":"Answer 7: (1)"},{"children":[],"mNativePtr":-5476376628811419248,"pageIdx":13,"title":"Answer 8: (1)"},{"children":[],"mNativePtr":-5476376628811418816,"pageIdx":13,"title":"Answer 9: (1)"},{"children":[],"mNativePtr":-5476376628811418336,"pageIdx":14,"title":"Answer 10: (1)"},{"children":[],"mNativePtr":-5476376628811417904,"pageIdx":15,"title":"Answer 11:"},{"children":[],"mNativePtr":-5476376628811417424,"pageIdx":15,"title":"Let PQRS be a rhombus. ∴ PQ \u003d QR \u003d RS \u003d SP Here, PR and QS are the diagonals of PQRS, where PR \u003d 24 cm and QS \u003d 18 cm. Let the diagonals intersect each other at M.  ∴ ΔPMQ is a right angle triangle in which MP \u003d ,𝐴𝐶-2.\u003d ,24-2.\u003d 12 cm and MQ \u003d ,𝑄𝑆-..."},{"children":[],"mNativePtr":-5476376628811416608,"pageIdx":16,"title":"Answer 12:"},{"children":[],"mNativePtr":-5476376628811366112,"pageIdx":16,"title":"S (1)"},{"children":[],"mNativePtr":-5476376628811365584,"pageIdx":16,"title":"P                                               R"},{"children":[],"mNativePtr":-5476376628811365152,"pageIdx":16,"title":"Q"},{"children":[],"mNativePtr":-5476376628811364720,"pageIdx":16,"title":"Let PQRS be a rhombus. ∴ PQ \u003d QR \u003d RS \u003d SP \u003d 10 cm Let PR and QS are the diagonals of PQRS. Let PR \u003d y and QS \u003d 16 cm and M be the intersection point of the diagonals. ∴ ΔPMQ is a right angle triangle, in which"},{"children":[],"mNativePtr":-5476376628811364240,"pageIdx":16,"title":"MP \u003d ,𝑃𝑅-2.\u003d ,𝑦-2. and MQ \u003d ,𝑄𝑆-2.\u003d ,16-2.\u003d 8 cm. Now, PQ2\u003d MP2 + MQ2              [Pythagoras theorem] ⇒102 \u003d (,𝑦-2.) 2 + 82⇒100 − 64 \u003d ,𝑦2-4. ⇒36 ×4 \u003d y2 ⇒y2 \u003d144 ∴ y \u003d 12 cm Hence, the other diagonal of the rhombus is 12 cm. ∴ Area of the rh..."},{"children":[],"mNativePtr":-5476376628811363520,"pageIdx":16,"title":"Answer 13:"},{"children":[],"mNativePtr":-5476376628811362896,"pageIdx":17,"title":"(i) ABCD is a rectangle. The diagonals of a rectangle are congruent and bisect each other. Therefore, in Δ AOB, as ,    OA \u003d OB     ∴ ∠OAB \u003d ∠OBA \u003d 35o ∴ x \u003d 90o − 35o \u003d 55o In ∆AOB"},{"children":[],"mNativePtr":-5476376628811362464,"pageIdx":17,"title":"∠OAB + ∠OBA +∠AOB \u003d 180∘"},{"children":[],"mNativePtr":-5476376628811361888,"pageIdx":17,"title":"And ∠AOB \u003d 180o − (35o + 35o) \u003d 110o ∴ y \u003d ∠AOB \u003d 110o                     [Vertically opposite angles] Hence, x \u003d 55o and y \u003d 110o  (ii) In ΔAOB, as ,"},{"children":[],"mNativePtr":-5476376628811361456,"pageIdx":17,"title":"Given, ∠AOB \u003d 100         OA \u003d OB    As, ∠OAB \u003d ∠OBA"},{"children":[],"mNativePtr":-5476376628811361024,"pageIdx":17,"title":"Then, ∠AOB + ∠OBA + ∠OAB \u003d 180"},{"children":[],"mNativePtr":-5476376628811360448,"pageIdx":17,"title":"⇒2∠𝐴𝑂𝐵\u003d180−∠𝐴𝑂𝐵…………………..(∠OAB \u003d ∠OBA)"},{"children":[],"mNativePtr":-5476376628811359920,"pageIdx":17,"title":"⇒2∠𝐴𝑂𝐵\u003d180−110\u003d70"},{"children":[],"mNativePtr":-5476376628811359440,"pageIdx":17,"title":"⇒∠𝐴𝑂𝐵\u003d ,1-2.×70\u003d35  so, ∴ y \u003d ∠BAC \u003d 35o                 [Interior alternate angles]"},{"children":[],"mNativePtr":-5476376628811358960,"pageIdx":17,"title":"Here at ∠C  is at right angle ∆ by fig,"},{"children":[],"mNativePtr":-5476376628811358288,"pageIdx":17,"title":"⇒ 90o \u003d  x + y  ⇒x \u003d 90o − y                           ⇒ x \u003d 90o − 35o \u003d 55o                      Thus, x \u003d 55o and y \u003d 35o"},{"children":[],"mNativePtr":-5476376628811357088,"pageIdx":19,"title":"Answer 15:"},{"children":[],"mNativePtr":-5476376628811356128,"pageIdx":19,"title":"Answer 16:"},{"children":[],"mNativePtr":-5476376628811355696,"pageIdx":19,"title":"Given: A rhombus ABCD.  To prove: Diagonal AC bisects ∠A as well as ∠C and diagonal BD bisects ∠B as well as ∠D.  Proof: In ΔABC, 𝐴𝐵 \u003d 𝐵𝐶         (Sides of rhombus are equal.) ∠𝐴𝐶𝐵 \u003d ∠𝐶𝐴𝐵          (Angles opposite to equal sides are equal.)..."},{"children":[],"mNativePtr":-5476376628811355216,"pageIdx":21,"title":"Answer 17:"},{"children":[],"mNativePtr":-5476376628811354784,"pageIdx":21,"title":"Given: In a parallelogram ABCD, AM \u003d CN.  To prove: AC and MN bisect each other. Construction: Join AN and MC.  As, the dia..."},{"children":[],"mNativePtr":-5476376628811354352,"pageIdx":21,"title":"Answer 18:"},{"children":[],"mNativePtr":-5476376628811185744,"pageIdx":22,"title":"Answer 19:"},{"children":[],"mNativePtr":-5476376628811185264,"pageIdx":22,"title":"Given, ABCD is a parallelogram whose diagonals intersect each other at O. A line segment EOF is drawn to meet AB at E and DC at F."},{"children":[],"mNativePtr":-5476376628811184640,"pageIdx":23,"title":"Answer 20:"},{"children":[],"mNativePtr":-5476376628811184160,"pageIdx":23,"title":"Z                                               Y"},{"children":[],"mNativePtr":-5476376628811183584,"pageIdx":23,"title":"N"},{"children":[],"mNativePtr":-5476376628811182960,"pageIdx":23,"title":"W                                              X"},{"children":[],"mNativePtr":-5476376628811182336,"pageIdx":23,"title":"M"},{"children":[],"mNativePtr":-5476376628811181904,"pageIdx":23,"title":"Given: In parallelogram WXYZ, ZM⊥ WX, WN ⊥ XY and ∠MZN \u003d 60  In quadrilateral ZMXN, by angle sum property,  ∠𝑀𝑍𝑁+∠𝑍𝑀𝑋+∠𝑋+∠𝑋𝑁𝑍\u003d360"},{"children":[],"mNativePtr":-5476376628811181424,"pageIdx":23,"title":"⇒60 +90 +∠𝑋+90 \u003d360"},{"children":[],"mNativePtr":-5476376628811180992,"pageIdx":23,"title":"⇒∠𝑋\u003d360 −240 ⇒∠𝑋\u003d120 ⇒∠𝑋 \u003d 120  Also, ∠𝑋\u003d∠𝑍\u003d120            (Opposite angles of a parallelogram are equal.) ∠𝑊+∠𝑋\u003d180            (Adjacent angles of a parallelogram are supplementary.) ⇒∠𝑊+120 \u003d180 ⇒∠𝑊\u003d180 −120 ⇒∠𝑊\u003d60  Also,  ∠𝑊\u003d∠𝑌\u003d60      ..."},{"children":[],"mNativePtr":-5476376628811180464,"pageIdx":23,"title":"Answer 21:"},{"children":[],"mNativePtr":-5476376628811180032,"pageIdx":24,"title":"Given: In rectangle ABCD, AC bisects ∠A, i.e. ∠DAC \u003d ∠CAB and AC bisects ∠C, i.e.      ∠DCA \u003d ∠ACB.  To prove: (i) ABCD is a square, (ii) diagonal BD bisects ∠B as well as ∠D. Proof: (i)  Since, AD∥BC                                   (Opposite sides..."},{"children":[],"mNativePtr":-5476376628811179456,"pageIdx":24,"title":"Answer 22:"},{"children":[],"mNativePtr":-5476376628811178976,"pageIdx":24,"title":"Given, ABCD is  parallelogram in which AB is produced to E."},{"children":[],"mNativePtr":-5476376628811178304,"pageIdx":24,"title":"BE \u003d AB (given)"},{"children":[],"mNativePtr":-5476376628811177680,"pageIdx":25,"title":"Answer 23:"},{"children":[],"mNativePtr":-5476376628811175904,"pageIdx":26,"title":"Answer 24:"},{"children":[],"mNativePtr":-5476376628811174992,"pageIdx":26,"title":"l       X                  P"},{"children":[],"mNativePtr":-5476376628811174464,"pageIdx":26,"title":"Q (1)"},{"children":[],"mNativePtr":-5476376628814540800,"pageIdx":26,"title":"m                              S"},{"children":[],"mNativePtr":-5476376628814540368,"pageIdx":26,"title":"R                    Y"},{"children":[],"mNativePtr":-5476376628814539600,"pageIdx":26,"title":"Given: l ,, m and the bisectors of interior angles intersect at X and Y. To prove: PQRS is a rectangle. Proof: Since, l ,, m                       (Given) So, ∠𝑋𝑃𝑅\u003d∠𝑃𝑅𝑌            (Alternate interior angles) ⇒,1-2.∠XPR\u003d,1-2.∠PRY  ⇒∠𝑄𝑃𝑅\u003d∠𝑃𝑅'

so this data will set on message[4]
now finally
this.props.onLoadComplete && this.props.onLoadComplete(Number(message[1]), this.state.path, {
                    width: Number(message[2]),
                    height: Number(message[3]),
                },
                message[4]&&JSON.parse(message[4]));

enter here message[4] is not a proper JSON stringify so its failed here
i hope this will clarify you if not we can schedule call also.

sure I will create upstream but not sure how long that will take to merge

@pradeepmdk do you have an update?

@abekkala I will create the upstream PR today.

@pradeepmdk do you have a PR for this?

@fedirjh my system is broken I am setting up new system mostly I will pr will up tomorrow

@pradeepmdk do you have an update?

@abekkala working on it on the new system facing some android build issues fixing on it.

@pradeepmdk do you have an estimated time for the PR?

i will push the PR before end of this week. before 26.

@fedirjh @abekkala upstream Pr is up now https://github.com/wonday/react-native-pdf/pull/791

@mountiny do you agree with @fedirjh above

Ueah I think having a patch is fine
@pradeepmdk I see your PR got merged, any guess how long it might take to get a new release?

@mountiny I created a new PR for version upgrade https://github.com/wonday/react-native-pdf/pull/795 i hope this will be merged within in week. can we wait until released or patch we can move?

@pradeepmdk How common are these PDF files? what is the aspect which makes them crash? ie if this crashes for more PDF udpates we should patch if its minority I think we can wait

We can wait for upstream release.
In https://github.com/Expensify/App/issues/30492, they merged the same day PR was created and then it took only 2 weeks to publish new release.

Lets wait then, thanks!

On hold

STATUS:
I'm ooo through Jan 03.
This issue on hold for https://github.com/wonday/react-native-pdf/pull/795.

Issue reported by: Applause-Internal Team
Fix: @pradeepmdk (create a patch fix)
PR Review: @fedirjh

@abekkala - I'll keep an eye out this week, but I'm OOO starting Friday and won't be back online until January 4.

Weekly Check-In: Moving to Weekly now since this one is still on hold. I'm going to be unassigning myself too since I will be offline until January 4.

My PR IS MERGED

Sure

Awesome, I've removed the hold here and we can continue forward. Thanks for the updates here.

@pradeepmdk Let me and @fedirjh know when the PR is ready for testing and review so we can merge this 🚀

I am working on it my android build is failing so maximum tomorrow PR will be ready.

Pr is ready

I checked in today, and it looks like the PR is moving along.

@abekkala - I think you are back online and handing the BZ role back to you here. Thanks!

@fedirjh  what will be the next step here?

@fedirjh I think if there is a clear way to fix this, then we can apply the patch
Ideally we can also help fix this upstream

Ih sorry I misunderstood, I thought a patch for the new issue. Then I think we can go ahead with the patch until the other issue is resolved.

The upstream bug arise from a recently merged PR : https://github.com/wonday/react-native-pdf/pull/792 , I think we should just revert it as the PR doesn’t include any revelent description or details.

If you know its that PR do you want to create Revert PR upstream and tag the maintainer, maybe they will be fine with the revert. Thanks!

thanks @mountiny i will prepare the patch PR

@mountiny can you help untangle this a bit for me?
Did the original PR for this issue (20743) cause the regression noted above that required a revert and patch fix?
I'm not sure how payments works for this one given the original PR, revert, patch, etc. that has occurred here.

@fedirjh

This is not yet ready for payment. We are still awaiting updates from @pradeepmdk.

Perfect, thanks for confirming. It didn't think it was so figured I'd better make sure I hadn't missed something!

@fedirjh PR is ready.

PAYMENTS FOR FEB 14

Issue reported by: Applause-Internal Team
Fix: @pradeepmdk [$500 - if no regressions] Offer Link
PR Review: @fedirjh [$500 - if no regressions] Offer Link

@pradeepmdk payment sent and contract ended - thank you! 🎉

@fedirjh can you complete the checklist, please? I can then send payment for this job

@fedirjh payment sent and contract ended - thank you! 🎉


Arkansas PMC does not have PM3D installed

Their tablet needs the PlantMap3D app. I am going to assume all of the tablets need the push -- does the tablet need to be online for the push to go through?
Their tablet is online and ready to receive the app.

Double checked on esper that they have their app installed.


First early version of the App Manifest.

This also adds some UI changes in the navbar to make it clear this is
still a WIP project.:)

Ok.


[RFC][Tracking Issue] Project API

This is a tracking issue to implement RFC 8: Project API. See the RFC and discuss forum for more details.

duplicate of #8595


Accept a full query as an alternative to the templated parameters

Currently the datadog-importer has a templated set of parameters that defines which metrics to import and associated parameters. In addition to this template, we should allow the user to define a raw datadog query. If a raw query is defined, the rest of the input parameters should be disregarded.
Acceptance Criteria:

User can define a raw datadog query, which is used in the importer in lieu of the existing input parameters
Any checks for existing parameters are skipped if the raw query param is present

Output parameters have minimal changes to allow for above criteria

Please assign this to me, thanks!


⚠ Turnos 24x7 has degraded performance

In 7e31930, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1803 ms

Resolved: Turnos 24x7 performance has improved in 97448a1.


Count distinct boolean

Which issue does this PR close?
Closes #202 .
What changes are included in this PR?
Modified the method to_array_of_size from ScalarValue to add support for boolean lists.
Are there any user-facing changes?
I don't believe so, I couldn't find any relevant documentation about supported datatypes for COUNT DISTINCT but I'm not sure.

@pjmore looks good! Maybe you could also add a test for it?

Codecov Report

Merging #230 (e1114cb) into master (23d02bb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   76.46%   76.46%
=======================================
  Files         135      135
  Lines       23250    23251    +1
=======================================
+ Hits        17777    17778    +1
  Misses       5473     5473

Impacted Files
Coverage Δ

datafusion/src/scalar.rs
54.14% <100.00%> (+0.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d02bb...e1114cb. Read the comment docs.

@Dandandan I've added a test.

@pjmore could you fix the clippy error?

This is great @pjmore  -- thank you -- I also tested locally and it works as advertised. 👍
> CREATE EXTERNAL TABLE t (a boolean) STORED AS CSV LOCATION '/tmp/foo.csv';
0 rows in set. Query took 0 seconds.
> select count(distinct a) from t;
+-------------------+
| COUNT(DISTINCT a) |
+-------------------+
| 1                 |
+-------------------+
1 rows in set. Query took 0 seconds.

👍


Support pthread scheduling functions for WASM

According to emscripten, the pthread is supported.
I quickly went through the documentation and found many things out of it implemented but also a few things which aren't there, for example:

pthread_setschedparam
pthread_getschedparam

And a few others.
Is there any reason those aren't added? Maybe these, in particular, aren't supported for wasm and emscripten? Can I add those if those are supported?
P.S. Asking mainly due to the support of wasm has been asked for in the thread-priority crate.

Okay, waiting for 8 days seems enough, I'll add those. This is their implementation when emscripten is built with posix threads support: https://github.com/emscripten-core/emscripten/blob/e05e72d9c49fe15578e73934ce525a894d1b712a/system/lib/libc/musl/include/pthread.h#L100

Help is still welcome for this from anyone who is interested, labeling hard based on https://github.com/rust-lang/libc/pull/2764. Maybe our newer emscripten toolchain will do better here.


User resizing the visual causes unnecessary rendering overload

Hi,
Is there any option to only load the custom visual once the user finishes dragging/resizing the visual?
I am having lag on the custom visual when a user is resizing and the visual keeps redrawing.
Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1c4c3363-db7e-fa34-3ade-dc56ab85fbdd
Version Independent ID: 71959fd9-4aff-cec0-9f14-93ae3923d8be
Content: Power BI visuals concepts - Power BI
Content Source: powerbi-docs/developer/visuals/power-bi-visuals-concept.md
Service: powerbi
Sub-service: powerbi-custom-visuals
GitHub Login: @KesemSharabi
Microsoft Alias: kesharab

Thanks for your comment, @djpirra . This issue has been assigned to the doc author for review.

Hi @uve,
Can you please assist @djpirra?
Thanks,
Kesem

Hi @djpirra.
Yes, "update" method receives VisualUpdateType as an argument.
Your visual can skip any updates with "Resize" type.


Project Console - Manger View Signature Table Updates - UI

Project Console - View Signature Table Updates - UI Enhancements
As a project manager, I want an enhanced table view for viewing, searching, sorting, paginating, and exporting CLA signatures.
Background
The current implementation provides a simplified table view listing the project signatures. Currently, the table sorting is broken and does not provide searching, pagination or export of CLA signatures. The redesigned UI will have the following new/enhanced features

The table view will be paginated so that a limited number of entries will be shown to the project manager. The manager can navigate through previous and next pages of data to display additional records. The manager can select the number of records to see each page.
The table will include the user's LFID, when present. This is a new column currently not present on the existing view.
The table view will allow column sorting on all columns

User Story
As an Open Source Project Manager:

I need to be able to view the full set of signatures and whitelisted contributors who are interacting with my project.
I should be able to go to the next page by clicking the subsequent page number or clicking the "Next" button.
I should be able to go to the previous page by clicking the previous page number or clicking the "Previous" button.
I need to be able to see the user's LF ID

Tasks

Update UX to include an enhanced table view meeting the above user-story requirements.
Call backend company and signature search endpoints to fetch results.
Show progress indicator when the search is executing and the user is awaiting the results.
Provide the capability to display the results in a paginated view (see references screenshots)
Provide the capability to sort the results by column in a paginated view  (see references screenshots).
Provide the capability to export the results.

Acceptance Criteria

UX provides the above features and works as advertised
Project manager review and sign-off
Demonstrate the set of capabilities to the product team while the code is
running in the STAGING environment.

References
Project Console - Signature Table View - https://confluence.linuxfoundation.org/pages/viewpage.action?pageId=28484537#PRD-EasyCLAv1Performance&UIUpdates-ProjectConsole.1

@dealako @ngozi-ekekwe, I think we need to minimize what we're delivering here considering the DB limitations. Please set the default list to 100 per page (no option to change) and keep the pagination


Batch operations require all records to be of the same type.

It looks like inTableAsBatch and inTableAsBatchAsync both take a sequence of Operation<'T>. This means that all the records I want to batch-insert have to be of the same type. This happens to be the case with your example of inserting 200 Game entities, but this is not the case for my situation.
If I understand Azure Table Storage correctly, the requirement for a batch insert is that all entities have the same partition key, however, the other properties present could be different. Is that correct?
In memory, I have a graph structure:
type Child = ...

type Parent = {
    Children: Child []
    ...
}

I can't store this directly in Azure table storage, so I have to define entity types:
/// represents a parent
type ParentEntity = {
    /// parent guid
    [<PartitionKey>] PartitionKey: string
    /// "" (empty)
    [<RowKey>] RowKey: string
    ...
}

/// represents a reference to a child
type ParentChildEntity = {
    /// parent guid
    [<PartitionKey>] PartitionKey: string
    /// child number
    [<RowKey>] RowKey: string
    /// child guid (PK of child)
    Child: Guid
}

I want to insert one ParentEntity row and many ParentChildEntity rows. These are logically one insert, since they all belong together, and they all have the same partition key.
How should I do this?

You currently can't do it short of using ITableEntity-derived classes instead of F# record types.
I'm planning a feature that would allow you to define a discriminated union:
type ParentOrChild =
    | Parent of ParentEntity
    | Child of ParentChildEntity

which you could then use to insert multiple types:
let entities = [ Parent({ ... }); Child({ ... }) ]
entities |> Seq.map Insert |> autobatch |> List.map insertInMyTableAsBatch

An extra column would be added to your table that would contain "Parent" or "Child" in order to guide the deserializer to use the correct type during querying.
But I don't have a timeline to share for that feature at this point.

I think that would be a good enhancement, but based on my other topic about not wanting to duplicate the partition key and row key, you can predict what I'm about to say. Likewise here I would not want to store "Parent" or "Child", because this is duplicating information I already have.
I can already tell which entity type it is based on the row key. In this example the partition key is the same for both, to allow for batch updates, but in general in any situation like this, I think the two keys together should encode the union case. So I would like to pattern match these two keys and then tell you which case to deserialize, rather than storing the case in a column.
Meanwhile I will use the ITableEntity approach as a workaround.
What is your timeline for enhancements generally? Are you actively working on this package currently, or are you busy with other things? Do you plan to add blob storage (e.g. code for splitting a stream into blocks for upload)?

I don't see the extra column as an issue at all. Table Storage is insanely cheap, so one extra column that you don't even see or need to maintain from a code perspective isn't an issue in my opinion. However, I'll try to keep in mind your request to be able to customise this process in the design the feature. I should be able to design in an extensibility point for you to replace the default behaviour.
I work on the project outside of work in my free time, so it gets done when it gets done. :) Blob storage support is further off than this particular feature; I haven't even started thinking about a design for blob storage yet.
Thanks for your feedback! :)

You are right of course, table storage is insanely cheap, and maybe there are other things I should care more about. Just as a point of reference, the commercial application I'm building is a cloud-hosted CAD system for mechanical design. It will be a freemium offering, with perhaps 90% of people using it for free and 10% of people paying for additional functionality. I have to pay for the data that the free users are creating, which is why I am being picky about this topic. I may well be worrying unduly.


Update the List view Layout in Resources

The current list view in the Resource layout needs to be updated to ensure a consistent design that aligns with the list layout used in the Shifting view. This update aims to enhance visual consistency and improve the user experience across different sections of the application
Before:

Refernce:

@rithviknishad  I would like to work on these issue . assign it to me


fix: illegal http header

Ignore the illegal content-length http header set by application.
Targeting:

v4.12.0
v22.0.0

Ref: https://github.com/laravel/octane/issues/568

Content-length header should not be removed when streaming a file with content-disposition: attachment;... header instead of Transfer-Encoding: chunked header.

Content-Lenght header should not be removed with Content-Disposition header as it prevent browser to display file download size.


Contributor link in the PR template points to the wrong address

Clicking the contributor guideline link in create new PR leads to the wrong address.

How to reproduce

Steps to reproduce:

open CONTRIBUTING.md under .github/
click on the guidelines link
or just create a new PR and click on the link

Expected behavior

Clicking the link should take you to main/.github/CONTRIBUTING.md
Environment (include versions). Did this work in previous versions?
NA

I'd like to work on this


Support JSON CLI output format

Fix #867
Example
$ presto --output-format JSON --execute "select * from tpch.sf1.customer limit 2" | jq
[
  {
    "custkey": 37501,
    "name": "Customer#000037501",
    "address": "Ftb6T5ImHuJ",
    "nationkey": 2,
    "phone": "12-397-688-6719",
    "acctbal": -324.85,
    "mktsegment": "HOUSEHOLD",
    "comment": "pending ideas use carefully. express, ironic platelets use among the furiously regular instructions. "
  },
  {
    "custkey": 37502,
    "name": "Customer#000037502",
    "address": "ppCVXCFV,4JJ97IibbcMB5,aPByjYL07vmOLO 3m",
    "nationkey": 18,
    "phone": "28-515-931-4624",
    "acctbal": 5179.2,
    "mktsegment": "BUILDING",
    "comment": "express deposits. pending, regular deposits wake furiously bold deposits. regular "
  }
]

$ presto --output-format JSON --execute "select * from tpch.sf1.customer limit 2" | jq '.[0].name'
"Customer#000112501"

@ebyhr thanks for your PR!
In https://github.com/prestosql/presto/issues/867 i outlined possible output layouts (single JSON object vs a stream of JSON objects; i added examples in the issue).
I imagine stream of JSON objects may be easier to process in... a streaming fashion.
What are your thoughts about this?

@findepi  Hmm.., it's a difficult choice. How about preparing both format e.g., JSON and JSON_STREAM?

I’d keep the shorter option name for the current streaming format.

Changed to streaming format using JSON option. I imagined some non-jq cases and thought one json is better at first. However, I agree with the current style now.

It might be simpler and more efficient to use theJsonGenerator API, since you could loop and write the key/value pairs directly.

Updated to JsonGenerator API.

There's a typo in the commit message: "formt"

Oh, sorry fixed.

The travis failed by PRODUCT_TESTS_BASIC_ENVIRONMENT=true and this commit looks unrelated.

Merged, thanks!