Remove dead code in EmsCommon#process_emss

We're inside else clause (L1010) for elsif task == "destroy" above (L992), so "destroy" can't happen here.
Am I missing anything?
The part that looks "changed" is just dedented, see ?w=1 diff.
@Fryguy The origin of this structure is lost in depth of time Initial Commit.

@miq-bot add-label technical debt, euwe/no

Yeah, looks good to me.  There's no way the task can be "destroy" in those conditions.
The originating commit is the following where it was created as a brand new file, but that commit is SOOO large, I'm not even going to try to go further :)
commit 5527f02f01c88d9e6c93f1606ca258d5f5154906
Author: Harpreet Kataria<EMAIL_ADDRESS>Date:   Tue Jun 18 12:28:09 2013 -0400

    UI changes for Cloud/Infra split. Added "Cloud" tab.
    Changes to Show only Infrastructure Providers under Infrastructure tab. Added dictionary entries for Infrastructure Providers, Cloud Providers, Availability Zones, Flavors. Changed labels in UI to say Infrastructure Providers in places where it used to Management Systems. Changed all the links that used to point to ext_management_system to ems_infra directory. Added new Cloud tab and Added a list/summary view for Cloud Providers, Availability Zones, Flavors. Added ability to Add/Edit/Delete Cloud Providers and all the other functionality/buttons that are available for Infrastructure Providers. Added placeholder images for summary screens and list views.

 vmdb/app/controllers/application_controller.rb     |  14 +-
 .../application_controller/ci_processing.rb        |   2 +-
 .../controllers/application_controller/explorer.rb |  10 +-
 .../application_controller/miq_request_methods.rb  |   2 +-
 .../app/controllers/application_controller/tags.rb |  14 +-
 .../application_controller/tree_support.rb         |   2 +-
 .../controllers/availability_zone_controller.rb    |  77 ++
 vmdb/app/controllers/configuration_controller.rb   |   1 +
 vmdb/app/controllers/dashboard_controller.rb       |   8 +-
 vmdb/app/controllers/ems_cloud_controller.rb       |  43 ++
 vmdb/app/controllers/ems_common.rb                 | 822 +++++++++++++++++++++
 vmdb/app/controllers/ems_infra_controller.rb       |  43 ++
 vmdb/app/controllers/flavor_controller.rb          |  77 ++
 .../controllers/instance_or_image_controller.rb    | 238 ++++++
 .../controllers/management_system_controller.rb    |  17 +-
 .../custom_buttons.rb                              |   2 +-
 vmdb/app/helpers/application_helper.rb             |  12 +-
 vmdb/app/helpers/availability_zone_helper.rb       |   8 +
 .../availability_zone_helper/graphical_summary.rb  |  26 +
 .../availability_zone_helper/textual_summary.rb    |  47 ++
 vmdb/app/helpers/ems_cloud_helper.rb               |   8 +
 .../helpers/ems_cloud_helper/graphical_summary.rb  |  55 ++
 .../helpers/ems_cloud_helper/textual_summary.rb    | 151 ++++
 .../ems_cluster_helper/graphical_summary.rb        |   4 +-
 .../helpers/ems_cluster_helper/textual_summary.rb  |   6 +-
 vmdb/app/helpers/ems_infra_helper.rb               |   8 +
 .../helpers/ems_infra_helper/graphical_summary.rb  |  97 +++
 .../helpers/ems_infra_helper/textual_summary.rb    | 196 +++++
 vmdb/app/helpers/flavor_helper.rb                  |   8 +
 .../app/helpers/flavor_helper/graphical_summary.rb |  26 +
 vmdb/app/helpers/flavor_helper/textual_summary.rb  |  61 ++
 vmdb/app/helpers/host_helper/graphical_summary.rb  |   4 +-
 vmdb/app/helpers/host_helper/textual_summary.rb    |   6 +-
 vmdb/app/helpers/management_system_helper.rb       |   8 -
 .../management_system_helper/graphical_summary.rb  | 101 ---
 .../management_system_helper/textual_summary.rb    | 200 -----
 .../helpers/miq_proxy_helper/graphical_summary.rb  |   4 +-
 .../helpers/miq_proxy_helper/textual_summary.rb    |   6 +-
 vmdb/app/helpers/ui_constants.rb                   |  17 +-
 .../vdi_desktop_pool_helper/graphical_summary.rb   |   6 +-
 .../vdi_desktop_pool_helper/textual_summary.rb     |   4 +-
 vmdb/app/helpers/vm_helper/graphical_summary.rb    |   4 +-
 vmdb/app/helpers/vm_helper/textual_summary.rb      |   6 +-
 vmdb/app/models/availability_zone.rb               |   1 +
 vmdb/app/models/ems_cloud.rb                       |   5 +
 vmdb/app/models/ems_infra.rb                       |   7 +
 vmdb/app/models/flavor.rb                          |   1 +
 vmdb/app/views/availability_zone/_main.html.erb    |  16 +
 vmdb/app/views/availability_zone/show.html.erb     |  34 +
 .../app/views/availability_zone/show_list.html.erb |   3 +
 vmdb/app/views/configuration/_ui_1.html.erb        |  14 +-
 vmdb/app/views/configuration/_ui_2.html.erb        |  27 +-
 vmdb/app/views/ems_cloud/discover.html.erb         |   1 +
 vmdb/app/views/ems_cloud/edit.html.erb             |   2 +
 vmdb/app/views/ems_cloud/new.html.erb              |   3 +
 vmdb/app/views/ems_cloud/show.html.erb             |   1 +
 vmdb/app/views/ems_cloud/show_list.html.erb        |   3 +
 .../views/ems_cloud/show_policy_timeline.html.erb  |   6 +
 vmdb/app/views/ems_infra/discover.html.erb         |   1 +
 vmdb/app/views/ems_infra/edit.html.erb             |   2 +
 vmdb/app/views/ems_infra/new.html.erb              |   3 +
 vmdb/app/views/ems_infra/show.html.erb             |   1 +
 vmdb/app/views/ems_infra/show_list.html.erb        |   3 +
 .../views/ems_infra/show_policy_timeline.html.erb  |   6 +
 vmdb/app/views/flavor/_main.html.erb               |  17 +
 vmdb/app/views/flavor/show.html.erb                |  34 +
 vmdb/app/views/flavor/show_list.html.erb           |   3 +
 vmdb/app/views/instance_or_image/console.html.erb  |   9 +
 vmdb/app/views/instance_or_image/explorer.html.erb |  54 ++
 vmdb/app/views/layouts/_dhtmlxgrid.html.erb        |   2 +-
 vmdb/app/views/layouts/_listnav.html.erb           |   8 +-
 .../views/layouts/_multi_auth_credentials.html.erb |   4 +-
 .../app/views/layouts/_page_header_navbar.html.erb |  22 +-
 vmdb/app/views/layouts/_pagingcontrols.html.erb    |   6 +-
 vmdb/app/views/layouts/_taskbar.html.erb           |  22 +-
 vmdb/app/views/layouts/_view_buttons.html.erb      |  16 +-
 vmdb/app/views/layouts/_x_view_buttons.html.erb    |   2 +-
 .../layouts/listnav/_availability_zone.html.erb    |  33 +
 vmdb/app/views/layouts/listnav/_ems_cloud.html.erb |  52 ++
 vmdb/app/views/layouts/listnav/_ems_infra.html.erb | 169 +++++
 vmdb/app/views/layouts/listnav/_flavor.html.erb    |  33 +
 vmdb/app/views/layouts/listnav/_host.html.erb      |  10 +-
 .../layouts/listnav/_management_system.html.erb    | 172 -----
 vmdb/app/views/layouts/listnav/_miq_proxy.html.erb |  12 +-
 vmdb/app/views/layouts/listnav/_storage.html.erb   |  10 +-
 .../layouts/listnav/_vdi_desktop_pool.html.erb     |  12 +-
 vmdb/app/views/layouts/listnav/_vm_common.html.erb |  12 +-
 vmdb/app/views/management_system/_config.html.erb  |   9 -
 vmdb/app/views/management_system/_form.html.erb    | 133 ----
 vmdb/app/views/management_system/_main.html.erb    |  19 -
 vmdb/app/views/management_system/discover.html.erb |   1 -
 vmdb/app/views/management_system/edit.html.erb     |   2 -
 vmdb/app/views/management_system/new.html.erb      |   3 -
 vmdb/app/views/management_system/show.html.erb     |  23 -
 .../app/views/management_system/show_list.html.erb |   3 -
 .../show_policy_timeline.html.erb                  |   6 -
 .../views/miq_capacity/_planning_options.html.erb  |   2 +-
 vmdb/app/views/service/_explorer.js.erb            |  27 +
 .../views/shared/views/ems_common/_config.html.erb |   9 +
 .../views/shared/views/ems_common/_form.html.erb   | 133 ++++
 .../views/shared/views/ems_common/_main.html.erb   |  19 +
 .../views/shared/views/ems_common/_show.html.erb   |  25 +
 vmdb/app/views/stylesheets/_template50.html.erb    |  16 +-
 vmdb/db/fixtures/dictionaries.csv                  |  13 +
 vmdb/db/fixtures/miq_product_features.yml          | 508 ++++++++++++-
 vmdb/db/fixtures/miq_shortcuts.yml                 |  10 +-
 vmdb/db/fixtures/miq_user_roles.yml                |  64 +-
 vmdb/lib/report_formatter.rb                       |   4 +-
 .../alerts/rss/smartproxy_settings_changes.yml     |   2 +-
 .../alerts/rss/smartproxy_version_changes.yml      |   2 +-
 vmdb/product/toolbars/ems_cloud_center_tb.yaml     |  58 ++
 vmdb/product/toolbars/ems_clouds_center_tb.yaml    |  73 ++
 vmdb/product/toolbars/ems_infra_center_tb.yaml     |  58 ++
 vmdb/product/toolbars/ems_infras_center_tb.yaml    |  73 ++
 .../toolbars/management_system_center_tb.yaml      |  58 --
 .../toolbars/management_systems_center_tb.yaml     |  73 --
 vmdb/product/views/AvailabilityZone.yaml           |  70 ++
 vmdb/product/views/EmsCloud.yaml                   |  98 +++
 vmdb/product/views/EmsInfra.yaml                   |  98 +++
 vmdb/product/views/ExtManagementSystem.yaml        |  98 ---
 vmdb/product/views/Flavor.yaml                     |  88 +++
 vmdb/product/views/InstanceOrImage.yaml            |  98 +++
 vmdb/product/views/TemplateCloud.yaml              |  98 +++
 vmdb/product/views/VmCloud.yaml                    |  98 +++
 vmdb/public/images/icons/new/availability_zone.png | Bin 0 -> 10929 bytes
 .../images/summary_screens/availability_zone.png   | Bin 0 -> 8240 bytes
 vmdb/public/images/summary_screens/ems_cloud.png   | Bin 0 -> 2971 bytes
 vmdb/public/images/summary_screens/ems_infra.png   | Bin 0 -> 2971 bytes
 vmdb/public/images/summary_screens/flavor.png      | Bin 0 -> 6967 bytes
 129 files changed, 4354 insertions(+), 1123 deletions(-)

Makes sense to me.
✂ 🔥 ✂ 🔥 ✂ 🔥
🍰  🍪 👏 🙇 😍 🎉


Red color for . attributes

Hi, in Atom, fields or attributes after a dot are put in red:

in pycharm this is the result:

Do you think it can be added ?

Hey, sorry for the late response. Have you seen any other JetBrains theme that can color python properties like this? I'm looking for the right field in the xml to set this, but I can't find anything. If I can find another theme that does this, I'll copy what they did.
I'll keep you posted if I figure this out.


integration: Fix test_allow_volume_creation_with_degraded_availability_error

It seems that Longhorn needs to take time to make newly created volumes becoming ready.
This error is hard to be reproduced.
Found this issue during testing longhorn/longhorn#1999
Signed-off-by: Shuo Wu<EMAIL_ADDRESS>

The error logs:
        replica_soft_anti_affinity_setting = \
            client.by_id_setting(SETTING_REPLICA_NODE_SOFT_ANTI_AFFINITY)
        client.update(replica_soft_anti_affinity_setting, value="false")

        nodes = client.list_node()
        node1 = nodes[0]
        node2 = nodes[1]
        node3 = nodes[2]

        # disable node 1, 2 and 3 to make 0 available node
        client.update(node1, allowScheduling=False)
        client.update(node2, allowScheduling=False)
        client.update(node3, allowScheduling=False)

        # create volume
        volume = create_and_check_volume(client, volume_name, num_of_replicas=3)
        assert not volume.ready
        assert volume.conditions[VOLUME_CONDITION_SCHEDULED]['status'] == "False"

        # attach the volume
        self_host = get_self_host_id()
        with pytest.raises(Exception) as e:
            volume.attach(hostId=self_host)
        assert "cannot be scheduled" in str(e.value)

        # enable node 1
        client.update(node1, allowScheduling=True)

        # check only 1 replica scheduled successfully
        common.wait_for_replica_scheduled(client, volume_name,
                                          to_nodes=[node1.name],
                                          expect_success=1, expect_fail=2,
                                          is_vol_healthy=False,
                                          is_replica_running=False)

        volume = client.by_id_volume(volume_name)
>       assert volume.ready
E       AssertionError: assert False
E        +  where False = {'backupStatus': [], 'baseImage': '', 'conditions': {'restore': {'lastProbeTime': '', 'lastTransitionTime': '2020-11-2...77216', 'staleReplicaTimeout': 0, 'standby': False, 'state': 'detached', 'timestamp': '2020-11-26T05:35:58.462105797Z'}.ready

test_basic.py:3221: AssertionError


Deploy Scraper Helm chart on Kind cluster

Deploy Scraper Helm chart on Kind cluster during CI and release pipelines.
Original issue: tomkerkhove/promitor#1182

Done


Added queries and fragments to uri parser

Very handy tool to check the validity of exotic URIs: http://www.websitedev.de/temp/rfc3986-check.html.gz


[release-1.13] chiron: amend cert watch timeout for DNS certificates

This is an automated cherry-pick of #41649

A note that 1.13 is EOL so we wouldn't build any more patch releases.


Snapshot of MicroOS

Why is autoscaler using snapshot for promptly bringing up nodes but the script itself installs MicroOS manually on all nodes? Wouldn't it be more logical and faster to create a single snapshot and use that for installing every node and afterwards continue to use it or just delete it?

@aleksasiriski Yes, good observation, and that is something we will be launching in v2.0, maybe in a month or two. Make sure to follow the releases.

@aleksasiriski While I have you on the line. Just invited you to join the team! Please feel free to accept. I will give you access to our internal team discussion, and move sway on the future of that project. I like your ideas and you have been helping a lot lately, so welcome to the club if you accept!
We have a few members, but some of them don't show up for a long time. It doesn't matter. At least we have a few active ones as you have seen!

@aleksasiriski Now that you are part of the team, that's the vision we have for v2.0. https://github.com/orgs/kube-hetzner/teams/core/discussions/5/comments/23


remove spaces in redirect page

rebased version of #61
no need to waste those precious bytes

Can you please update the spec? https://travis-ci.org/jekyll/jekyll-redirect-from/jobs/49713963

sorry i cloned from master.

got it.  isee what you mean by specs.. i call those "tests"

The change you made broke it. To have this pull request merged, you have to fix the spec too :)


sqlparser bug: Error while trying to parse IN clause list literal

SELECT id FROM todos WHERE category IN (1) parses correctly, but adding more comma separated expressions throws the following error:
Error while trying to parse SELECT id FROM todos WHERE category IN (1,2): line 1, column 42: Error: Expected a closing bracket}

1 │ SELECT id FROM todos WHERE category IN (1,2)
  │                                          ^

IN expressions are not yet supported indeed. Super valid feature request though, will work on them soon.

This works on develop.


Click on track should remove cached playAll tracks

As title, the cache inside player should be removed when the track is clicked by user.

fixed !


Template generator frontend

I added a frontend for the onnx generator to make adding new operators as simple as possible.
usage example:
$ ./gen_template.sh
usage: ./gen_template.sh [domain] [operator] [version]
possible domains:
ai.onnx.preview.training
ai.onnx.ml
ai.onnx
$ ./gen_template.sh ai.onnx
usage: ./gen_template.sh [domain] [operator] [version]
possible operators:
ai.onnx GreaterOrEqual
ai.onnx Celu
ai.onnx ConcatFromSequence
ai.onnx SoftmaxCrossEntropyLoss
ai.onnx SplitToSequence
ai.onnx SequenceErase
ai.onnx SequenceAt
ai.onnx SequenceInsert
ai.onnx SequenceConstruct
ai.onnx SequenceEmpty
ai.onnx Det
[...]
$ ./gen_template.sh ai.onnx Log
usage: ./gen_template.sh [domain] [operator] [version]
possible versions:
ai.onnx Log 1
ai.onnx Log 6
$ ./gen_template.sh ai.onnx Log 1
### GENERATING TEMPLATE FOR ai.onnx Log 1 ###

selecting domains
onnx operator schemas have 3 domains: ai.onnx.preview.training, ai.onnx.ml, ai.onnx
including domain 'ai.onnx'
including onnx operator schemas
included 'ai.onnx' operator schema 'Log' by pattern '^Log$'
excluding onnx operator schemas
selecting onnx operator schema versions
'ai.onnx' operator schema 'Log' has 2 version(s): 1, 6
included 'ai.onnx' operator schema 'Log' version 1
generating onnx operator headers
generating onnx operator type resolvers
generating onnx operator sets
generating onnx operator template
Writing files
writing file /home/drechsler/git/cONNXr/src/operators/ai.onnx/Log/1/operator__ai_onnx__log__1.h
writing file /home/drechsler/git/cONNXr/src/operators/ai.onnx/Log/1/resolve_operator__ai_onnx__log__1.c
writing file /home/drechsler/git/cONNXr/src/operators/ai.onnx/Log/1/prepare_operator__ai_onnx__log__1.c
writing file /home/drechsler/git/cONNXr/src/operators/ai.onnx/Log/1/free_operator__ai_onnx__log__1.c
writing file /home/drechsler/git/cONNXr/src/operators/ai.onnx/Log/1/execute_operator__ai_onnx__log__1.c
writing file /home/drechsler/git/cONNXr/src/operators/ai.onnx/Log/1/execute_operator__ai_onnx__log__1__T_tensor_double.c
writing file /home/drechsler/git/cONNXr/src/operators/ai.onnx/Log/1/execute_operator__ai_onnx__log__1__T_tensor_float.c
writing file /home/drechsler/git/cONNXr/src/operators/ai.onnx/Log/1/execute_operator__ai_onnx__log__1__T_tensor_float16.c
writing file /home/drechsler/git/cONNXr/src/operators/ai.onnx/Log/1/info_operator__ai_onnx__log__1.c
wrote 9 of 9 files (0 already existed, 0 skipped)

### GENERATING NEW OPERATOR SET ###

selecting domains
including onnx operator schemas
excluding onnx operator schemas
selecting onnx operator schema versions
generating onnx operator headers
generating onnx operator type resolvers
generating onnx operator sets
generating onnx operator template
Writing files
overwriting file /home/drechsler/git/cONNXr/src/operators/operator_set.c
overwriting file /home/drechsler/git/cONNXr/src/operators/ai.onnx/opdomain_operator__ai_onnx.c
wrote 2 of 274 files (228 already existed, 44 skipped)

@Coderitter-GmbH
hope you can use this to port your operator.
move your operator files someplace,
generate this template and fill in the missing pieces.

Love the idea. I'm getting an error with:
$ ./gen_template.sh ai.onnx Log 1

find: -printf: unknown primary or operator
usage: onnx_generator [-h] [-v] [-f] [--list-domains] [--list-operators] [--list-versions] [--skip-pattern SKIP_PATTERN [SKIP_PATTERN ...]] [--force-pattern FORCE_PATTERN [FORCE_PATTERN ...]]
                      [--force-header] [--force-resolve] [--force-sets] [--force-template] [--force-info] [-n] [--no-header] [--header <path>] [--no-resolve] [--resolve <path>] [--no-sets]
                      [--sets <path>] [--no-template] [--template <path>] [--no-info] [--info <path>] [--domains <domain> [<domain> ...]] [--version <version>] [-i <regex> [<regex> ...]]
                      [-e <regex> [<regex> ...]]
                      [--] <path>

Aside from that, looks good.

It works for me so far. The only thing I have to complain, is that it is a bit slow.

Love the idea. I'm getting an error with:
$ ./gen_template.sh ai.onnx Log 1

find: -printf: unknown primary or operator
usage: onnx_generator [-h] [-v] [-f] [--list-domains] [--list-operators] [--list-versions] [--skip-pattern SKIP_PATTERN [SKIP_PATTERN ...]] [--force-pattern FORCE_PATTERN [FORCE_PATTERN ...]]
                      [--force-header] [--force-resolve] [--force-sets] [--force-template] [--force-info] [-n] [--no-header] [--header <path>] [--no-resolve] [--resolve <path>] [--no-sets]
                      [--sets <path>] [--no-template] [--template <path>] [--no-info] [--info <path>] [--domains <domain> [<domain> ...]] [--version <version>] [-i <regex> [<regex> ...]]
                      [-e <regex> [<regex> ...]]
                      [--] <path>

Aside from that, looks good.

meh. I assume this is a difference in the find implementation between Gnu/Linux and MacOS.

It works for me so far. The only thing I have to complain, is that it is a bit slow.

It takes about 3 seconds on my laptop. How long does take on your side?
./gen_template.sh ai.onnx Log 1  3.03s user 0.19s system 90% cpu 3.555 total
performance should not be an issue, since it should be only run if a new operator template is required.

time ./gen_template.sh
real	0m3,865s
user	0m4,108s
sys	0m1,675s
It is true that 4 seconds are not a huge deal. I just didn't expected it and thought, that the script might be hanging. I was just to impatient.

time ./gen_template.sh
real 0m3,865s
user 0m4,108s
sys 0m1,675s
It is true that 4 seconds are not a huge deal. I just didn't expected it and thought, that the script might be hanging. I was to impatient.

it runs the generator multiple times that loads the whole onnx operator set description each time, runs a ton of regex etc etc. It's more a beast than a beauty :D
just so you get feeling how much happening under the hood:
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          10            280            338           1593
Markdown                         1              8              0             58
-------------------------------------------------------------------------------
SUM:                            11            288            338           1651
-------------------------------------------------------------------------------

And I found an other little problem: Linux (or at least ubuntu) uses python3 instead python. Sure I can create a system link but that's not the default way as far i know.

was a typo, fixed it

@alrevuelta fixed it, can you try again?

For convTranspose it generates 4 execute c files:
execute_operator__ai_onnx__convtranspose__11__T_tensor_double.c
execute_operator__ai_onnx__convtranspose__11__T_tensor_float.c
execute_operator__ai_onnx__convtranspose__11__T_tensor_float16.c
execute_operator__ai_onnx__convtranspose__11.c

What is the purpose of execute_operator__ai_onnx__convtranspose__11.c or is that a bug?

This executer is not referenced by the code generator atm.
I was thinking about using this in the generated resolver when no typed one can be found as a replacement for the currently used global stub.
The generated files should only be hint how to implement the operator, as long as you define the prepare_* symbol you can implement the operator as you wish.
the prepare_* function should allocate everything and sets the executer that will be called.
@alrevuelta what do you think about using the "typeless" function as the default function if no type specific one can be found?


improve organization of fuzzy images and their dependencies

For instance, I want a blas/lapack + libmath + python fuzzy container... and I'm sure the list goes on beyond that.
Proposal:

The base remains as is.
level1 is basically remapped to be a grid of instruction sets, and every combination in this matrix is computed and given an "index" or "bundle" ID
apps can be built on a single or a subset of all bundle IDs in parallel.

Thoughts, @glatard?

Note: the above proposal does not mention operating system, which would add another dimension to the build matrix.
Also, this proposal would require either a) redundant instruction sets, or b) dynamic Dockerfile creation/modification


reflect: MakeMap() doesn't allow initial allocation size

When using make to create a new map, you can pass a size for the initial allocation to prevent lots of resizes as keys are inserted.  When using reflection, this option is not available.
The reflect package should add MakeMapSize(typ Type, size int) to allow preallocation for maps created via reflection.

I did a little experiment to see if this was worth it.  The test is to allocate a map[int64]int64 and fill it with 1<<16 records.  Without reflect, it seems that preallocation saves about a factor of 2.  With reflect it saves only about 20%.  Reflect is pretty slow already, I'm not entirely convinced that this is worth the API surface.
That said, it is an easy modification.
BenchmarkRawMap        	     200	   8782041 ns/op
BenchmarkRawMapSize    	     300	   4168970 ns/op
BenchmarkReflectMap    	     100	  24216280 ns/op
BenchmarkReflectMapSize	     100	  19667848 ns/op
code here: https://go-review.googlesource.com/10510

I don't believe this is worth the API surface.


PostgreSQL cteless batch id generation

Changed batch ID fetch query for PostgreSQL from recursive CTE to simple query, reducing execution time by half. Tested with requests to 1 000 000 ids at once. Base branch is eazrael:default_schema_support

Thanks, I'll review it when I have some time.

Applied upstream, thanks


Dev static transform

Added some static transforms - should be faster if we consider most things do not move too much in a scene…

OH GOD what is that?


Support media queries with widths expressed in rem.

Add rem to the regular expressions for width-based media queries. This
was already discussed in #18 but not implemented as part of this change.
Tested with IE8 where this works as expected.

Is there any reason tihs is not merged? I tested it and it works fine. This would also solve scenarios that https://github.com/chuckcarpenter/REM-unit-polyfill does not support today.

Actually it look like REM-unitpolyfill has open issues and does not play nice with Respondjs. The solution you provided in this pull request will not function completely. For full REM support, please look into this solution: https://github.com/nbouvrette/remPolyfill


Support workingDir and trim env

[x] All tests passed. If this feature is not already covered by the tests, I added new tests.
[x] This pull request is on the dev branch.
[x] I used gofmt for formatting the code before submitting the pull request.

Support new JF_WORKING_DIR environment variable to handle cases whereby the package descriptor is not in the root of the repository.
Trim environment variables after reading them.

I think we should consider adding a test project to this repo and an integration test for this scenario.


Merge changes to dist/js/materialize.js

Hi
I have cloned from master into packages folder. I want to change something from /js/modal.js to fix some bugs. But I found it won't automatically update dist/js/materialize.js after I save /js/modal.js. So my changes won't reflect because of this.
So I just want to know what's the best way for other people who wants to fix some bug and create PR here?
Thanks

The dist files are only for our official version releases. Once we deem there have been enough fixes or progress to warrant a new release, we will update the dist. Take a look at our contributing.md to see more about writing PRs

I had grunt monitoring.
I dont see /dist/js/materialize.js is updated after changed /js/modal.js
Is my grunt running correctly? This is grunt log from console:

File "js/modal.js" changed.

Running "concat:temp" (concat) task
File temp/js/materialize.js created.

Running "uglify:bin" (uglify) task
>> 1 file created.

Running "notify:js_compile" (notify) task
[BS] Reloading Browsers...

Running "clean:temp" (clean) task
>> 1 path cleaned.

Running "watch:js" (watch) task
Completed in 2.178s at Fri Feb 24 2017 23:48:22 GMT-0500 (EST) - Waiting...

First run grunt monitorthen save the changes. Then it should work

I'm using Meteor framework.
Local changes will only merge to bin/materialize.js NOT dist/js/materialize.js. So a work around I did was modify package.js from:
api.addFiles([
'dist/js/materialize.js'
], 'client');
to
api.addFiles([
'bin/materialize.js'
], 'client');


cannot unmarshal number into Go struct field Client.data.dhcpend_time of type int

I am running the latest docker container on a new install, but getting the following error ...
2020/01/30 18:23:01 [INFO] Loading Configuration File: /etc/unifi-poller/up.conf 2020/01/30 18:23:01 [INFO] UniFi Poller v1.6.3-641 Starting Up! PID: 1 2020/01/30 18:23:01 [INFO] Found 1 site(s) on controller: default (Default) 2020/01/30 18:23:01 [INFO] Polling UniFi Controller at https://<IP_ADDRESS>:8443 v5.12.22 as user influx. Sites: [all] 2020/01/30 18:23:01 [INFO] Everything checks out! Poller started, InfluxDB interval: 30s 2020/01/30 18:23:31 [INFO] Logging Measurements to InfluxDB at http://influxdb:8086 as user unifi 2020/01/30 18:23:31 [ERROR] unifi.GetClients(): json: cannot unmarshal number<PHONE_NUMBER> into Go struct field Client.data.dhcpend_time of type int
I have dropped & recreated the influx db, but still get the same error. It is not clear to me if this indicates bad data being returned from my controller or something unexpected in the code. Any advice on how to fix this issue?

You can try v2 now. The beta is stable.

Thanks, I will give v2 a try soon with a new db to confirm; however, I also wanted to report that after rebooting my UDM, the poller worked again. I'm unsure what caused such a high lease time.

That's actually really good to know! Thanks for the update! I feel like you ran into some where time bug. Maybe the time on the UDM changed and the lease end times got skewed. Hard to say, but it's good to know a reboot fixed it.


checking for manager to be ready not running

Signed-off-by: jasmingacic<EMAIL_ADDRESS>This PR is checking for kusk manager to be ready not just running to ensure that all webhooks are up and running before deploying other manifests.
@kylehodgetts @mbana can you please test this against Minikube, kind, k3d or any other setup @aabedraba reported a weird bug with kusk cluster install:
✅ Installing Kusk...
namespace/kusk-system created
customresourcedefinition.apiextensions.k8s.io/apis.gateway.kusk.io created
customresourcedefinition.apiextensions.k8s.io/envoyfleet.gateway.kusk.io created
customresourcedefinition.apiextensions.k8s.io/staticroutes.gateway.kusk.io created
serviceaccount/kusk-gateway-manager created
role.rbac.authorization.k8s.io/kusk-gateway-leader-election-role created
clusterrole.rbac.authorization.k8s.io/kusk-gateway-envoyfleet-manager-role created
clusterrole.rbac.authorization.k8s.io/kusk-gateway-manager-role created
clusterrole.rbac.authorization.k8s.io/kusk-gateway-metrics-reader created
clusterrole.rbac.authorization.k8s.io/kusk-gateway-proxy-role created
rolebinding.rbac.authorization.k8s.io/kusk-gateway-leader-election-rolebinding created
clusterrolebinding.rbac.authorization.k8s.io/kusk-gateway-envoyfleet-manager-rolebinding created
clusterrolebinding.rbac.authorization.k8s.io/kusk-gateway-manager-rolebinding created
clusterrolebinding.rbac.authorization.k8s.io/kusk-gateway-proxy-rolebinding created
configmap/kusk-gateway-manager created
service/kusk-gateway-manager-metrics-service created
service/kusk-gateway-validator-service created
service/kusk-gateway-webhooks-service created
service/kusk-gateway-xds-service created
deployment.apps/kusk-gateway-manager created
mutatingwebhookconfiguration.admissionregistration.k8s.io/kusk-gateway-mutating-webhook-configuration created
validatingwebhookconfiguration.admissionregistration.k8s.io/kusk-gateway-validating-webhook-configuration created
✅ Kusk installed
resource mapping not found for name: "kusk-gateway-envoy-fleet" namespace: "kusk-system" from "/var/folders/_9/xgx5tyrs0sq_9wr4qf5h0w5h0000gn/T/cmd/kusk/manifests/fleets.yaml": no matches for kind "EnvoyFleet" in version "gateway.kusk.io/v1alpha1"
ensure CRDs are installed first
resource mapping not found for name: "kusk-gateway-private-envoy-fleet" namespace: "kusk-system" from "/var/folders/_9/xgx5tyrs0sq_9wr4qf5h0w5h0000gn/T/cmd/kusk/manifests/fleets.yaml": no matches for kind "EnvoyFleet" in version "gateway.kusk.io/v1alpha1"
ensure CRDs are installed first

Above it sasy it installed the CRD but then it can't find the Kind: Envoyfleet.
To build the CLI
cd cmd/kusk
VERSION=v1.2.5 make build
./kusk cluster install -v

Figured out the issue that @aabedraba had.  I tried to replicate the behavior with various options and only when I did this:
k3d cluster  create && ./kusk cluster install

Which lead to this
...
INFO[0006] Starting Node 'k3d-k3s-default-serverlb'
INFO[0012] Injecting records for hostAliases (incl. host.k3d.internal) and for 3 network members into CoreDNS configmap...
INFO[0014] Cluster 'k3s-default' created successfully!
INFO[0015] You can now use it like this:
kubectl cluster-info
✅ Installing Kusk...
✅ Kusk installed
resource mapping not found for name: "kusk-gateway-envoy-fleet" namespace: "kusk-system" from "/var/folders/p3/5nr8bms91k9brbf2swjrvsg00000gn/T/cmd/kusk/manifests/fleets.yaml": no matches for kind "EnvoyFleet" in version "gateway.kusk.io/v1alpha1"
ensure CRDs are installed first
resource mapping not found for name: "kusk-gateway-private-envoy-fleet" namespace: "kusk-system" from "/var/folders/p3/5nr8bms91k9brbf2swjrvsg00000gn/T/cmd/kusk/manifests/fleets.yaml": no matches for kind "EnvoyFleet" in version "gateway.kusk.io/v1alpha1"
ensure CRDs are installed first

The reason was that the kubeAPI was not ready yet. For kusk cluster install to successfully work cluster needs to be running i.e. all kube-system pods need to be running and ready.


chore(deps): bump dependencies in /test/angular-ngx-echarts

Description
This PR supersedes both Dependabot PRs:

https://github.com/Orange-OpenSource/ods-charts/pull/24
https://github.com/Orange-OpenSource/ods-charts/pull/26

Test checklist
Please check that the following tests projects are still working:

[x] test/angular-ngx-echarts

@jacques-lebourgeois Could you please confirm for me that when running test/angular-ngx-echarts locally on your side with the content of this PR, everything still works?


Generated Apollo Class implements Query interface instead Subscription

I've been figthing with this issue, the generated class implements Query Instead Subscription, when I try to subscribe like Android project :
ApolloSubscriptionCall<ClassRequestFinding.Data> subscriptionCall = application.apolloClient()         .subscribe(new ClassRequestFinding());
I get a wrong types Error.
 subscribe (com.apollographql.apollo.api.Subscription<com.apollographql.apollo.api.Operation.Data,com.project.apollotest.ClassRequestFinding.Data,com.apollographql.apollo.api.Operation.Variables>) in ApolloClient cannot be applied to (com.project.ClassRequestFinding)
this is my .graphql file called :
subscription ClassRequestFinding{         classRequestFinding {             id         } }
Generated Class:
@Generated("Apollo GraphQL") public final class ClassRequestFinding implements Query<ClassRequestFinding.Data, ClassRequestFinding.Data, Operation.Variables> {   public static final String OPERATION_DEFINITION = "subscription ClassRequestFinding {\n"       + "  classRequestFinding {\n"       + "    __typename\n"       + "    id\n"       + "  }\n"       + "}"; }
Schema Auto-Generated:
{ "kind": "OBJECT",           "name": "Subscription",           "description": "",           "fields": [             {               "name": "classRequestFinding",               "description": "",               "args": [],               "type": {                 "kind": "OBJECT",                 "name": "ClassRequest",                 "ofType": null               },               "isDeprecated": false,               "deprecationReason": null             }          ],           "inputFields": null,           "interfaces": [],           "enumValues": null,           "possibleTypes": null }
my Gradle dependencies:
`
dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])
implementation"org.jetbrains.kotlin:kotlin-stdlib-jre7:$kotlin_version"
implementation 'com.android.support:appcompat-v7:26.1.0'
implementation 'com.android.support.constraint:constraint-layout:1.1.2'
implementation "com.apollographql.apollo:apollo-android-support:1.0.0-alpha"  //Android Support
implementation "com.apollographql.apollo:apollo-runtime:1.0.0-alpha" // Runtime
implementation "com.apollographql.apollo:apollo-rx-support:1.0.0-alpha"  //// RX Support
implementation "com.apollographql.apollo:apollo-rx2-support:1.0.0-alpha"  //// RX2 Support
implementation "com.apollographql.apollo:apollo-http-cache:1.0.0-alpha"  //// Http Cache
implementation "io.reactivex:rxjava:1.2.9"
implementation "io.reactivex.rxjava2:rxjava:2.0.5"
implementation "io.reactivex.rxjava2:rxandroid:2.0.1"
implementation "javax.annotation:jsr250-api:1.0"

}
`

I think there is something wrong in your schema, look at the example how subscription is defined:
https://github.com/apollographql/apollo-android/blob/master/apollo-sample/src/main/graphql/com/apollographql/apollo/sample/schema.json#L82
Or could you provide the whole schema that you have.

The Schema.json is apollo-codegen generated.
It contains too that definition as mentioned.
"subscriptionType": {         "name": "Subscription"       }
I've tested with aws appsync plugin and the generated class implements Subscription, But I can not run it with apollo libraries, I got "dex merge" issues.

what version of plugin are you using?
And aws appsync plugin is unofficial fork we don't support it

I see.
I'm using this:
classpath 'com.apollographql.apollo:gradle-plugin:0.4.1'

I've tested with this:
classpath 'com.apollographql.apollo:apollo-gradle-plugin:0.4.4'
it's working fine now, thank you!


Incorrect typedef for DXGI_SWAP_EFFECT

Link to article:
https://docs.microsoft.com/en-us/windows/desktop/api/DXGI/ne-dxgi-dxgi_swap_effect
Problem 1
Artcle Reads:
typedef enum DXGI_SWAP_EFFECT {
   DXGI_SWAP_EFFECT_DISCARD,
   DXGI_SWAP_EFFECT_SEQUENTIAL,
   DXGI_SWAP_EFFECT_FLIP_SEQUENTIAL,
   DXGI_SWAP_EFFECT_FLIP_DISCARD
} ;

Should Read (per dxgi.h):
typedef enum DXGI_SWAP_EFFECT {
   DXGI_SWAP_EFFECT_DISCARD = 0,
   DXGI_SWAP_EFFECT_SEQUENTIAL = 1,
   DXGI_SWAP_EFFECT_FLIP_SEQUENTIAL = 3,
   DXGI_SWAP_EFFECT_FLIP_DISCARD = 4
} DXGI_SWAP_EFFECT;

i.e. enumeration is NOT sequential from '0'
Problem 2 : 🛑 IMPORTANT There is no "comment section" available in this article.

Hello, thank you for the feedback. This syntax block is autogenerated from the header by our content build system. We are tracking a feature request to add enumeration numerical values to the syntax block. Unfortunately, this can't be updated manually at this time and must wait for the engineering fix.

If an enum syntax block is going to be presented, copying the enum values from the header seems like it ought to be a given, not to mention necessary for the online documentation to even be considered useful; otherwise, the enums should just be shown without an enum block.  It's misleading.  Let me know if the engineering department needs assistance.  :-)

So... 2 years and 4 months later the docs are still wrong.

Hi there. I'm sorry this has taken so long, but believe it or not, this engineering update to the docs is coming soon! I just checked the internal work item, and the fix is checked into a branch and is in the final testing / deployment phase. I expect you will see it live on the site in the next month or so.

That's exciting to hear.  The online docs are a disaster right now.  Please leave this issue open until it actually happens.

There are still many, many issues in the documentation where the presented 'typedef enum' is not explicitly enumerated.  The way it's presents implies that the enumeration starts at default '0', which it does not.  Examples are: D3D11_MAP,  D3D11_BIND_FLAG, D3D11_CPU_ACCESS_FLAG... there are undoubtedly hundreds of other entries like this.
This is now a three-year-old problem.  It is very disappointing that we cannot depend on the documentation to be accurate after a three-year opportunity to fix it.
The on-line documentation faces millions of users.  It must be accurate.
We would like to know what steps we need to take to escalate this issue.


❓ Question: Distribution of generated SVGs

Description
Hello, I've been using your service for quite some time and it worked great until yesterday - which made me wonder - is self-hosting the only way to ensure ~100% of uptime?
Or are we allowed to download the generated SVGs and store them in a repository as static files and use them accordingly?
P.S. of course, this refers to static badges (not dynamically generated ones, e.g. commit count, issue count, etc.) and this project would be credited in the repository's README file.
Thanks. 🙏🏼

Feel free to use it however you like. If you want to host generated static files, that's fine, attribution is great, although not required. If you want to host the entire project yourself, that's fine as well as long as it retains the license.

Thanks for the prompt reply!
Indeed, no site/service has a 100% uptime, hence the tilde (~) symbol. 😉
For now, I think I'll host static SVGs that I need to be available 100% of time in the repository where they are used and continue using the service when needed = dynamic badges.
Thanks. 🙏🏼


Add warning for naked commas

We use YUICompressor.NET in our build chain, and we like the "compile"-time checks that are performed to tell us about potential issues in our javascript codebase. We found an issue with IE7 clients around an edge-case in Javascript syntax. If there were any array or object declarations with a comma and no other token between the closing brace or bracket, an exception would be thrown. See below example. This seems to be acceptable in other browsers.
var anObject = {a:1, b:'2',}; // the last comma causes an exception in IE7 and earlier
var anArray = [1,2,3,]; //  the last comma causes an exception in IE7 and earlier

We decided to disallow this in our codebase to be safe, and added a check to YUICompressor.NET to find and warn on these situations.
I have added a new option DisallowNakedComma to warn on the above situation, which is defaulted to NOT warn for backwards compatibility.

Hi,
I'm not sure it is appropriate in yuicompressor - following the principle of single responsibility, the compressor is responsible for compressing JavaScript, not enforcing good practice.
Have you thought of using something like jslint?

Also, you should have one test per test case with a single assert in each, not four test cases in one test and multiple asserts.
@PureKrome is the owner of the repo so up to him, but I would suggest using jslint for your code quality and keep yuicompressor for compressing.

@freeranger YUIC also handles minification ... but I'm not sure if this comes under that umbrella?
unless it's breaking the minification and combining...

"Also" handles minification? That's the main purpose surely! 😅


scrollbar not always visible on IE 9

Hi
I am using perfect scroll bar and I want the vertical scroll bar to be always visible this works fine in firefox and chrome however whenever I start a new e session on IE9 the scroll doest not appear until I mouse over the container element, or even I need to press f12 and then refresh the page
Here is the code:
$(".detail-col").perfectScrollbar({
wheelSpeed: 8,
wheelPropagation: true,
minScrollbarLength: 20,
suppressScrollX: true
});
html code

I have try the following solutions:
create the always visibe class inside the JSP

To affect the div created by the perfect scrollbar
Override the perfect-scrollbar vertical scrollbar property by putting this code on the application css
ps-container.ie .ps-scrollbar-y {
visibility:visible !important;
}
And finally I have modified directly the perfect-scrollbar css directly
.ps-container.ie .ps-scrollbar-x,.ps-container.ie .ps-scrollbar-y{visibility:hidden} to visible
Sometimes works sometimes does not appear until I refresh then only show on mouseover
Please help me on this issue
Thanks in advance
Regards,
Miguel Monraz

html code (only the importan parts

If it occurs only by chance, it may be a timing issue. How do you fill the content? Is it static? Any jsfiddle or codepen examples, or the site example will help us a lot to narrow down the reason.

Closed for the inactivity.


Fixed contours operation empty level bug

Fixes bug in contours operation when a level is empty.

I believe this change is safe. Merging.


Selenide 3.11 git tag doesn't exist

Hi @asolntsev,
It looks like there is no git tag for 3.11 release.
Could you please fix it? :)
Thanks in advance!

Hi!
Yes, sure. I will add tag for selenide 3.11
P.S. why do you need it? Why not upgrade to the latest version?
On Jan 8, 2017 7:01 PM, "Boris Osipov"<EMAIL_ADDRESS>wrote:

Hi @asolntsev https://github.com/asolntsev,
It looks like there is no git tag for 3.11 release.
Could you please fix it? :)
Thanks in advance!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/codeborne/selenide/issues/451, or mute the thread
https://github.com/notifications/unsubscribe-auth/AARE3TGmDxbo9wKC5lc0gUfylzJ3z_MCks5rQRZogaJpZM4LdvL1
.

Thank you@asolntsev!
It needs because it isn't possible to use java 8 :) It's an open source project and they haven't moved on java 8 yet.
I think to backport some bug-fixes\features from master to 3.11. I haven't tried it yet, but I will try.
Can we release 3.11.X or 3.12 with bugfixes still on java 7?  What do you think? Did somebody already ask to do so?

Sorry for the long delay.
I have created tag selenide-3.11
Andrei Solntsev
2017-01-08 23:01 GMT+02:00 Boris Osipov<EMAIL_ADDRESS>
Thank you@asolntsev!
It needs because it isn't possible to use java 8 :) It's an open source
project and they haven't moved on java 8 yet.
I think to backport some bug-fixes\features from master to 3.11. I haven't
tried it yet, but I will try.
Can we release 3.11.X or 3.12 with bugfixes still on java 7? What do you
think? Did somebody already ask to do so?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/codeborne/selenide/issues/451#issuecomment-271179172,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARE3SfKgquSepvNtq4AlyEY7447YN0fks5rQU68gaJpZM4LdvL1
.


doesn't affect createSwitchNavigator?

hello, i use it with createSwitchNavigator, but it doesn't work, but works with others like createSwitchNavigator

I have personally never used a SwitchNavigator but after taking a look at the docs, here is what I have found. The SwitchNavigatorConfig  does not have a key for transitionConfig. This means you cannot use custom transitions with this navigator. See the docs here
If you want to use custom transitions, use the StackNavigator. The StackNavigatorConfig does have a transitionConfig key. See the docs here


Last window size and position not remembered in some cases

Describe the bug
When last window closed for the app is a property window, in the next start up of the app, files-uwp opens with the size and position of property window instead of the main window's last size and position.
To Reproduce
Steps to reproduce the behavior:

Open files-uwp app.
Open properties for any folder.
Close the main window.
Close the properties window.
Relaunch files-uwp app.
See the error.

Expected behavior
App should remember only the main window's position and size and apply that when relaunched.
Desktop (please complete the following information):

OS Version: Windows 10 1903 18362.239
App version: v0.12.0

I suppose that closing any open property windows when the user closes the main app windows would be the correct action here.


DynamicDependencies bug in AppxManifest'd winrt inprocserver handling

2 bugs in AppxManifest-based UndockedRegFreeWinRT support we unnoticed due to a gap in test coverage

2+ <Extension Category='windows.activatableClass.inProcessServer'> in a manifest
2+ inprocservers with the same Path

Code updated to handle these cases as expected.
The PRfwk test package (test\DynamicDependency\data\Microsoft.ProjectReunion.Framework) was updated to ensure coverage of these scenarios
Added new WinRT_RoGetActivationFactory_* test cases to verify the fix. Tests pass now as expected

/azp run

/azp run


Add short.cm app

The website value should be a URL to webpage, not an installer file.
We may eventually add support for specifying URLS of installers.

Thanks!


feat: console log implementation in appsmith

Description
Includes the ability to write and view console statements in the application.
Link for final designs:
Figma
Zeplin
Fixes #15983
Fixes #14594
Type of change

New feature (non-breaking change which adds functionality)

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/ok-to-test sha=959db56

/ok-to-test sha=ebbe5e4

[ ] when the cursor is hovered over system and person icons on the debugger, cursor turns into a CTA icon and nothing happens when you click on it. This happens only when the debugger entry is not collapsible. Else this click action causes the entry to furl and unfurl

[ ] The filter elements don't collapse on smaller screensizes/when Networks tab is open and sometimes completely hides the dropdown filter
https://www.loom.com/share/aafa06a0804a45c3b7354061ccf6752b

[ ] Help icon isn't centered

[ ] Console statement inside a promisified code block  execution gets stuck in a loop - function4 on this app (trying to produce a simplified version)

[ ] Does not work inside promise blocks (both success and failure)

myFun1: () => {
		return randomUserGenerator.run()
		.then((res) => {
				console.log(res)
			  return storeValue('data', res.data )
				//console.log(appsmith.store.data)
		})
		.catch(() => {
			console.log('could not store data')
		})
	},

[x]  when the cursor is hovered over system and person icons on the debugger, cursor turns into a CTA icon and nothing happens when you click on it. This happens only when the debugger entry is not collapsible. Else this click action causes the entry to furl and unfurl

Fixed this now, please check out

[ ]  The filter elements don't collapse on smaller screen sizes/when the Networks tab is open and sometimes completely hides the dropdown filter
https://www.loom.com/share/aafa06a0804a45c3b7354061ccf6752b

This seems to be an issue since designs mention the widths to be static. @parth-appsmith can we instead set a min/max width along with a ratio in which the 2 elements can grow/shrink?

[x]  Help icon isn't centered

This is fixed too now, please check it out.

[ ]  Console statement inside a promisified code block  execution gets stuck in a loop - function3 on this app (trying to produce a simplified version)

I am not able to access this, can you please share the same on<EMAIL_ADDRESS>Will check it out.

[ ]  Does not work inside promise blocks (both success and failure)

Just tried it on both success and failure, works for me. Can you help me with the

/ok-to-test sha=c6a7df7

/ok-to-test sha=fc9d123

/ok-to-test sha=c90da1c

@ayushpahwa - I found a bug while playing around with the feature, in an async function in the first console.log is not executing. Have attached the code blocks for which it is not working
myFun2: async () => {
		console.log("start");
		return await Api2.run().then(() => {
			console.log("hi");
		});
	}

myFun2: async () => {
		console.log("start");
		const a = 1+2;
		console.log(a);
		return await Api2.run().then(() => {
			console.log("hi");
		});
	}

https://user-images.githubusercontent.com/10229595/186826399-91fc216a-d946-429f-8f54-114df667e32b.mov

@ayushpahwa - I found a bug while playing around with the feature, in an async function in the first console.log is not executing. Have attached the code blocks for which it is not working
myFun2: async () => {
		console.log("start");
		return await Api2.run().then(() => {
			console.log("hi");
		});
	}

myFun2: async () => {
		console.log("start");
		const a = 1+2;
		console.log(a);
		return await Api2.run().then(() => {
			console.log("hi");
		});
	}

@rimildeyjsr that was a very nice catch! The issue was with logs being reset whenever the global DTO was being made. That meant whenever a promise was encountered, the function was called hence causing all logs to be reset before the promise started. I’ve now moved the reset to the start of a sync/async eval only. This has fixed the issue. The DP is being updated, please do test out for any such edge case. Thanks!

[ ] Syntax of console log is different to the browser console when using escape characters. This is the case for all escape characters

{{(() => {
	let a = 1+6;
	console.log("async function \\t" , a)
}) () }}

[ ] Printed console statement reads the comma as part of the output and does not behave as the browser console

{{(() => {
	let a = 1+6;
	console.log("async function" , a)
}) () }}

/ok-to-test sha=cb3afff

/ok-to-test sha=8c8e4ac

/ok-to-test sha=b6e04d5

/ok-to-test sha=b75c9a9

[ ] The output seems off when outputting console statement after nested calls
Sample app
Video

IntervalCheck: () => {
		setInterval(() => {
			return storeValue('name', appsmith.user.name)
			.then(() => {
				return Api1.run()
				.then(() => {
					console.log('Api has been executed')
					console.log('from user obj ' ,appsmith.user.name)
					console.log('from store ', appsmith.store.name)
				})
			})
		}, 1000, 'testConsole')
	}

Current result:

[ ] The interval stops on it's own after a while for the above code (toggle window/tab and leave it ideal for a bit)

[ ] values does not show up when filter is on, and only shows up when filter is cleared
https://www.loom.com/share/83ea82274e9e429cbe817b29e839f768

[ ] Dropdown position should be below the field. This only happens when the debugger size is increased as seen in the second screenshot

@ramsaptami

The issue came as the name of the object is not available if the function is inside a JSObject. For now, have handled it by removing the name. We can track it in a separate issue.
For the second point

The interval stops on it's own after a while for the above code (toggle window/tab and leave it ideal for a bit)
this was due to a bug in our pagination that it couldn't handle dynamic data stream. I have updated the same with the new fix.

For point 3

values does not show up when filter is on, and only shows up when filter is cleared
This is due to the first reason only. The filter will only work if the name is attached to the console. In this case, the name is not present in the context of the console, hence the issue.

For point 4

Dropdown position should be below the field. This only happens when the debugger size is increased as seen in the second screenshot
This is a normal behaviour of the ADS dropdown component. If the options don't have enough space, they try to take up space present above.

/ok-to-test sha=ea3c3b9

Verified feature and fixes on DP.

/ok-to-test sha=d1d4370

/ok-to-test sha=d2d62de

/ok-to-test sha=f03000a


Parse data as json string instead of object literal

https://v8.dev/blog/cost-of-javascript-2019#json
This could be faster...

It looks like webpack handles json as a string literal by default


mapcss doesn't render buildings tagged as height=x m

I am working on .mapcss to highlight buildings tagged as height=xx.xx m.

Added a new class to identify to identify tags with " m" as units. But as it a separate class, it would not show respective colours based on height. PR #30
cc: @maning @chtnha


Toast style: Match our current style for error, warning, and success

Context: Extending from issue #1978 on toast alerts. Updating style to look like inline and page alerts
Alerts will not fade away in instances where there is a warning or an error. Errors cannot be close - though I am open to feedback on this.

cc: @timarney @srtalbot

@dsamojlenko is this also part of the alert work you've been doing with Sam


How to build libheadprofd_glibc_preload.so for native heapprofd (on Linux) still?

Edit: All this is based on v20.1 of the SDK.
The documentation at
https://perfetto.dev/docs/data-sources/native-heap-profiler#-non-android-linux-support
indicates steps to get a heap profile on native (non-Android) Linux, but following the instructions, I was never able to get it to build the mentioned libheapprofd_glibc_preload.so library. It builds the other stuff (tools, sdk, etc.) as expected (after fixing a few minor build problems)*.
I've been building (on x86_64 Linux with gcc 8.2) with is_clang = false and both default and is_debug = false, but neither produced that library.
*The problems I ran into were:
diff --git a/src/trace_processor/importers/proto/flamegraph_construction_algorithms.cc b/src/trace_processor/importers/proto/flamegraph_construction_algorithms.cc
index db0e924..97643d3 100644
--- a/src/trace_processor/importers/proto/flamegraph_construction_algorithms.cc
+++ b/src/trace_processor/importers/proto/flamegraph_construction_algorithms.cc
@@ -391,7 +391,7 @@ BuildNativeCallStackSamplingFlamegraph(
   for (const auto& tc : time_constraints) {
     if (!(tc.op == FilterOp::kGt || tc.op == FilterOp::kLt ||
           tc.op == FilterOp::kGe || tc.op == FilterOp::kLe)) {
-      PERFETTO_FATAL("Filter operation %d not permitted for perf.", tc.op);
+      PERFETTO_FATAL("Filter operation not permitted for perf.");
     }

as tc.op wasn't printable using %d according to gcc 8.2's printf warning.
diff --git a/src/trace_processor/sqlite/sqlite_vtable_benchmark.cc b/src/trace_processor/sqlite/sqlite_vtable_benchmark.cc
index 510f776..8a75df2 100644
--- a/src/trace_processor/sqlite/sqlite_vtable_benchmark.cc
+++ b/src/trace_processor/sqlite/sqlite_vtable_benchmark.cc
@@ -49,7 +49,7 @@ void BenchmarkArgs(benchmark::internal::Benchmark* b) {
 class BenchmarkCursor : public sqlite3_vtab_cursor {
  public:
   explicit BenchmarkCursor(size_t num_cols, size_t batch_size)
-      : num_cols_(num_cols), batch_size_(batch_size), rnd_engine_(kRandomSeed) {
+      : num_cols_(num_cols), batch_size_(batch_size), rnd_engine_(1) {
     column_buffer_.resize(num_cols);
     for (auto& col : column_buffer_)
       col.resize(batch_size);

kRandomSeed (from some anonymous namespace iirc) wasn't found during linking, so I just hardcoded a number.
diff --git a/src/traced/probes/ftrace/proto_translation_table_unittest.cc b/src/traced/probes/ftrace/proto_translation_table_unittest.cc
index 0210f71..4f2b98a 100644
--- a/src/traced/probes/ftrace/proto_translation_table_unittest.cc
+++ b/src/traced/probes/ftrace/proto_translation_table_unittest.cc
@@ -371,7 +371,7 @@ TEST(TranslationTableTest, Getters) {
   std::vector<Event> events;

   {
-    Event event;
+    Event event{};
     event.name = "foo";
     event.group = "group_one";
     event.ftrace_event_id = 1;
@@ -379,7 +379,7 @@ TEST(TranslationTableTest, Getters) {
   }

   {
-    Event event;
+    Event event{};
     event.name = "bar";
     event.group = "group_one";
     event.ftrace_event_id = 2;
@@ -387,7 +387,7 @@ TEST(TranslationTableTest, Getters) {
   }

   {
-    Event event;
+    Event event{};
     event.name = "baz";
     event.group = "group_two";
     event.ftrace_event_id = 100;

as event produced an "using initialized fields" warning.

Given this is on an old compiler version + old SDK, closing. Please reopen if this still happens today.


NH-89406: remove debug flag for release version of apm

Description

remove debug flag to reduce the size of apm
add instruction for debugging with core dump file

Test (if applicable)

in order to get extended info out of coredump, the crash needs to be reproduced using special version of solarwinds_apm

For now yes, here is the difference log info
# without .debug symbol file
#5  0x0000ffff92c1fd04 in oboe_ssl_reporter::eventSender() () from /root/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/solarwinds_apm-6.0.6/lib/../ext/oboe_metal/lib/liboboe.so

# with .debug symbol file
#5  0x0000ffff9841c6ac in oboe_ssl_reporter::eventSender (this=0xffff9927c010) at /__w/solarwinds-apm-liboboe/solarwinds-apm-liboboe/liboboe/reporter/ssl.cpp:1677

# with ReleaseAndDebug and .debug file
#5  0x0000ffff9841c6ac in oboe_ssl_reporter::eventSender (this=0xffff9927c010) at /__w/solarwinds-apm-liboboe/solarwinds-apm-liboboe/liboboe/reporter/ssl.cpp:1677
    ptr2 = 0x0
        grpcRequest = {< ...

this special version can be achieved purely at install time by setting env var OBOE_DEBUG which enables more info in the c-extension binding code AND uses a version of liboboe that comes with extended debug info.

Yes, and also need the liboboe build with ReleaseAndDebug


Single user mode

When all the access goes to single bucket (and single user) then getting user record and bucket object from Riak might be bottleneck, because every single operation is serialized there. This patch makes a new separate mode that does not use moss.buckets nor moss.users, but takes them from app.config. Also,  if single user mode is enabled there is no need for stanchion.
Limitations are: no ACLs, policies can be modified at runtime. No users and no buckets can be created on runtime. Enabled APIs are: PUT,GET,DELETE Object, GET Bucket. And pre-defined canned ACLs. This mode cannot be mixed with existing Riak CS setup (or, if very carefully configured, maybe).
To enable this mode, add lines like this to app.config:
              {single_user_mode, enabled},
              {single_users_buckets,
               [
                "su-flat-bucket",
                {"su-acl-public-read", [{canned_acl, "public-read"}]},
                {"su-acl-public-rw", [{canned_acl, "public-read-write"}]}
               ]
              },

The only accessible user is admin, defined via admin_key and admin_secret.

Ping in repo cleanup sweeping.
This PR is inactive for long. Is it worth to keep open
or rebase to develop?


日志根据大小切片时，文件重命名读写冲突。

Codecov Report

Merging #1045 (278e853) into master (7ceb667) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
- Coverage   69.65%   69.64%   -0.01%
==========================================
  Files         352      352
  Lines       24924    24917       -7
==========================================
- Hits        17361    17354       -7
  Misses       6131     6131
  Partials     1432     1432

Impacted Files
Coverage Δ

os/glog/glog_logger.go
73.57% <100.00%> (+0.78%)
:arrow_up:

os/gcache/gcache_adapter_memory_lru.go
86.20% <0.00%> (-10.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ceb667...278e853. Read the comment docs.


Wrong Extension Grabbed

This refer to fix/11
It seems that the extensions grabbed by the module are wrong:
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: Version:  771
nginx_1          |
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: ciphers: length: 16
nginx_1          |
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    cipher: 0x1301 -> 4865
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    cipher: 0x1302 -> 4866
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    cipher: 0x1303 -> 4867
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    cipher: 0xc02b -> 49195
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    cipher: 0xc02f -> 49199
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    cipher: 0xc02c -> 49196
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    cipher: 0xc030 -> 49200
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    cipher: 0xcca9 -> 52393
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    cipher: 0xcca8 -> 52392
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    cipher: 0xc013 -> 49171
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    cipher: 0xc014 -> 49172
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    cipher: 0x009c -> 156
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    cipher: 0x009d -> 157
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    cipher: 0x002f -> 47
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    cipher: 0x0035 -> 53
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    cipher: 0x000a -> 10
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: extensions: length: 14
nginx_1          |
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    extension: 0x0000 -> 0
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    extension: 0x0000 -> 0
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    extension: 0x0017 -> 23
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    extension: 0x0000 -> 0
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    extension: 0xff01 -> 65281
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    extension: 0x0000 -> 0
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    extension: 0x000a -> 10
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    extension: 0x0000 -> 0
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    extension: 0x000b -> 11
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    extension: 0x0000 -> 0
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    extension: 0x0023 -> 35
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    extension: 0x0000 -> 0
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    extension: 0x0010 -> 16
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    extension: 0x0000 -> 0
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: curves: length: 3
nginx_1          |
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    curves: 0x001d -> 29
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    curves: 0x0017 -> 23
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    curves: 0x0018 -> 24
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: formats: length: 1
nginx_1          |
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: |    format: 0
nginx_1          | 2019/05/29 06:55:42 [debug] 12#0: *14 ssl_ja3: fp: [771,4865-4866-4867-49195-49199-49196-49200-52393-52392-49171-49172-156-157-47-53-10,0-0-23-0-65281-0-10-0-11-0-35-0-16-0,29-23-24,0]

while on https://ja3er.com/, it returns the following fingerprint:
771,4865-4866-4867-49195-49199-49196-49200-52393-52392-49171-49172-156-157-47-53-10,0-23-65281-10-11-35-16-5-13-18-51-45-43-27-21,6682-29-23-24,0

@sessa93, could you provide us with hello packet that resulted in such garbled JA3? I have never encountered this. What architecture your nginx was compiled for?

Please check if with new version in master after #12 merge rewrite, that this still happens.


Dev/mass/bottomnavigationbar

GitHub Issue: #5
PR Type
What kind of change does this PR introduce?

Feature

Description
Added the BottomNavigationBar control
PR Checklist
Please check if your PR fulfills the following requirements:

[X] Tested UWP
[X] Tested iOS
[X] Tested Android
[X] Tested WASM
[X] Contains No breaking changes

/azp run

[ ] Badge Entity (to research)
[ ] Remove SelectedIndex
[ ] Add Title to NavigationBarItem (or Label? Look at other controls like TabView what naming they used)
[ ] Change Data to be called Icon of type IconElement


docs: Add Substation to Big Data

@andrzejsydor thanks for the approval! @sbilly good to merge?

That pattern of reviews smells...

That pattern of reviews smells...

love the smell of open source in the morning


Can't build docs locally

I'm trying to run docs website locally. After
git clone https://github.com/ReactTraining/react-router.git
cd react-router/website
yarn
yarn start

I get this:
Macintosh:website dkorduban$ yarn start
yarn run v1.19.1
$ webpack-dev-server --inline --host <IP_ADDRESS>
ℹ ｢wds｣: Project is running at http://<IP_ADDRESS>:8080/
ℹ ｢wds｣: webpack output is served from /
ℹ ｢wds｣: Content not from webpack is served from /Users/dkorduban/workspace/TopTal/react-router/website
ℹ ｢wds｣: 404s will fallback to /index.html
✖ ｢wdm｣: Built at: 11/14/2019 10:04:55 AM
                             Asset       Size  Chunks             Chunk Names
        android-chrome-144x144.png   4.51 KiB          [emitted]
              apple-touch-icon.png   5.41 KiB          [emitted]
                 browserconfig.xml  231 bytes          [emitted]
    bundle-3ed8fb2f6c9d0bfa63c8.js    347 KiB     app  [emitted]  app
bundle-3ed8fb2f6c9d0bfa63c8.js.map    395 KiB     app  [emitted]  app
    bundle-fca722a83a579af46144.js   1.34 MiB  vendor  [emitted]  vendor
bundle-fca722a83a579af46144.js.map   1.55 MiB  vendor  [emitted]  vendor
                 favicon-16x16.png  839 bytes          [emitted]
                 favicon-32x32.png   1.39 KiB          [emitted]
                       favicon.ico   14.7 KiB          [emitted]
                        index.html   1.84 KiB          [emitted]
                     manifest.json  263 bytes          [emitted]
                mstile-150x150.png   2.69 KiB          [emitted]
                  react-square.png   39.8 KiB          [emitted]
             safari-pinned-tab.svg   1.23 KiB          [emitted]
Entrypoint app = bundle-3ed8fb2f6c9d0bfa63c8.js bundle-3ed8fb2f6c9d0bfa63c8.js.map
Entrypoint vendor = bundle-fca722a83a579af46144.js bundle-fca722a83a579af46144.js.map
[0] multi (webpack)-dev-server/client?http://<IP_ADDRESS>:8080 ./modules/index.js 40 bytes {app} [built]
[2] multi (webpack)-dev-server/client?http://<IP_ADDRESS>:8080 react react-dom 52 bytes {vendor} [built]
[./modules/index.js] 1.68 KiB {app} [built] [failed] [1 error]
[./node_modules/react-dom/cjs/react-dom.development.js] 903 KiB {vendor} [built]
[./node_modules/react-dom/index.js] 1.33 KiB {vendor} [built]
[./node_modules/react/cjs/react.development.js] 72.3 KiB {vendor} [built]
[./node_modules/react/index.js] 190 bytes {vendor} [built]
[./node_modules/strip-ansi/index.js] 161 bytes {app} {vendor} [built]
[./node_modules/webpack-dev-server/client/index.js?http://<IP_ADDRESS>:8080] (webpack)-dev-server/client?http://<IP_ADDRESS>:8080 4.29 KiB {app} {vendor} [built]
[./node_modules/webpack-dev-server/client/overlay.js] (webpack)-dev-server/client/overlay.js 3.51 KiB {app} {vendor} [built]
[./node_modules/webpack-dev-server/client/socket.js] (webpack)-dev-server/client/socket.js 1.53 KiB {app} {vendor} [built]
[./node_modules/webpack-dev-server/client/utils/createSocketUrl.js] (webpack)-dev-server/client/utils/createSocketUrl.js 2.85 KiB {app} {vendor} [built]
[./node_modules/webpack-dev-server/client/utils/log.js] (webpack)-dev-server/client/utils/log.js 964 bytes {app} {vendor} [built]
[./node_modules/webpack-dev-server/client/utils/reloadApp.js] (webpack)-dev-server/client/utils/reloadApp.js 1.59 KiB {app} {vendor} [built]
[./node_modules/webpack-dev-server/client/utils/sendMessage.js] (webpack)-dev-server/client/utils/sendMessage.js 402 bytes {app} {vendor} [built]
    + 31 hidden modules

ERROR in ./modules/index.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
ReferenceError: Unknown plugin "@babel/proposal-class-properties" specified in "/Users/dkorduban/workspace/TopTal/react-router/website/modules/.babelrc" at 1, attempted to resolve relative to "/Users/dkorduban/workspace/TopTal/react-router/website/modules"
    at /Users/dkorduban/workspace/TopTal/react-router/website/node_modules/babel-core/lib/transformation/file/options/option-manager.js:180:17
    at Array.map (<anonymous>)
    at Function.normalisePlugins (/Users/dkorduban/workspace/TopTal/react-router/website/node_modules/babel-core/lib/transformation/file/options/option-manager.js:158:20)
    at OptionManager.mergeOptions (/Users/dkorduban/workspace/TopTal/react-router/website/node_modules/babel-core/lib/transformation/file/options/option-manager.js:234:36)
    at OptionManager.init (/Users/dkorduban/workspace/TopTal/react-router/website/node_modules/babel-core/lib/transformation/file/options/option-manager.js:368:12)
    at File.initOptions (/Users/dkorduban/workspace/TopTal/react-router/website/node_modules/babel-core/lib/transformation/file/index.js:212:65)
    at new File (/Users/dkorduban/workspace/TopTal/react-router/website/node_modules/babel-core/lib/transformation/file/index.js:135:24)
    at Pipeline.transform (/Users/dkorduban/workspace/TopTal/react-router/website/node_modules/babel-core/lib/transformation/pipeline.js:46:16)
    at transpile (/Users/dkorduban/workspace/TopTal/react-router/website/node_modules/babel-loader/lib/index.js:50:20)
    at Object.module.exports (/Users/dkorduban/workspace/TopTal/react-router/website/node_modules/babel-loader/lib/index.js:173:20)
Child html-webpack-plugin for "index.html":
         Asset     Size  Chunks  Chunk Names
    index.html  536 KiB       0
    Entrypoint undefined = index.html
    [./node_modules/html-webpack-plugin/lib/loader.js!./index.html.ejs] 2.42 KiB {0} [built]
    [./node_modules/lodash/lodash.js] 528 KiB {0} [built]
    [./node_modules/webpack/buildin/global.js] (webpack)/buildin/global.js 472 bytes {0} [built]
    [./node_modules/webpack/buildin/module.js] (webpack)/buildin/module.js 497 bytes {0} [built]
ℹ ｢wdm｣: Failed to compile.

My Node version is v12.13.0. I tried to remove yarn.lock and yarn again, but the problem persists.

Should be fixed when #7025 lands.


Fix jsx-max-props-per-line options example

Small issues with jsx-max-props-per-line  docs

Codecov Report

Merging #3083 (a8ecd54) into master (a4bf7da) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3083      +/-   ##
==========================================
- Coverage   97.55%   97.54%   -0.02%
==========================================
  Files         115      115
  Lines        7729     7729
  Branches     2764     2764
==========================================
- Hits         7540     7539       -1
- Misses        189      190       +1

Impacted Files
Coverage Δ

lib/rules/jsx-props-no-spreading.js
95.65% <0.00%> (-2.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4bf7da...a8ecd54. Read the comment docs.


Websocket: bad handshake

I've used example code provided in your SDK and replaced api_key & access_key with proper credentials. Nodejs SDK is working as expected.
I'm getting this error -
Error:  websocket: bad handshake
Reconnect attempt 1 in 2.000000s
Error:  websocket: bad handshake
Reconnect attempt 2 in 4.000000s
Error:  websocket: bad handshake
Reconnect attempt 3 in 8.000000s
Error:  websocket: bad handshake
Reconnect attempt 4 in 16.000000s
Error:  websocket: bad handshake
Reconnect attempt 5 in 32.000000s
Error:  websocket: bad handshake
Reconnect attempt 6 in 60.000000s
Error:  websocket: bad handshake
Reconnect attempt 7 in 60.000000s
Error:  websocket: bad handshake
Reconnect attempt 8 in 60.000000s
Error:  websocket: bad handshake
Reconnect attempt 9 in 60.000000s
Error:  dial tcp: lookup ws.kite.trade: no such host

Closing the issue because of non activity. Feel free to reopen it if required.


Travis build failing while installing sails

Sails version: 0.12.1
Node version:4.4.4
NPM version:2.15.1
Operating system:Ubuntu 14.04.3 LTS

I am using<EMAIL_ADDRESS><EMAIL_ADDRESS>and<EMAIL_ADDRESS>Package json has following scripts:
"scripts": {
    "predeploy": "npm install -g",
    "preinstall": "npm remove sails-mysql",
    "start": "BLUEBIRD_W_FORGOTTEN_RETURN=0 sails lift",
    "postinstall": "npm install<EMAIL_ADDRESS>  },

Travis build is throwing following error while installing sails.
><EMAIL_ADDRESS>preinstall /home/travis/build/practo/consumer-payments-api/node_modules/sails
> node ./lib/preinstall_npmcheck.js
Sails.js Installation: Checking npm-version successful
npm WARN deprecated<EMAIL_ADDRESS>wrench.js is deprecated! You should check out fs-extra (https://github.com/jprichardson/node-fs-extra) for any operations you were using wrench for. Thanks for all the usage over the years.
npm WARN deprecated<EMAIL_ADDRESS>'native-or-bluebird' is deprecated. Please use 'any-promise' instead.
npm WARN optional dep failed, continuing<EMAIL_ADDRESS>npm WARN deprecated<EMAIL_ADDRESS>graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to<EMAIL_ADDRESS>as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained. Upgrade to<EMAIL_ADDRESS>npm WARN deprecated<EMAIL_ADDRESS>cross-spawn no longer requires a build toolchain, use it instead!
><EMAIL_ADDRESS>install /home/travis/build/practo/consumer-payments-api/node_modules/db-migrate/node_modules/mongodb/node_modules/kerberos
> (node-gyp rebuild 2> builderror.log) || (exit 0)
make: Entering directory `/home/travis/build/practo/consumer-payments-api/node_modules/db-migrate/node_modules/mongodb/node_modules/kerberos/build'
  CXX(target) Release/obj.target/kerberos/lib/kerberos.o
make: Leaving directory `/home/travis/build/practo/consumer-payments-api/node_modules/db-migrate/node_modules/mongodb/node_modules/kerberos/build'
><EMAIL_ADDRESS>install /home/travis/build/practo/consumer-payments-api/node_modules/db-migrate/node_modules/mongodb/node_modules/bson
> (node-gyp rebuild 2> builderror.log) || (exit 0)
make: Entering directory `/home/travis/build/practo/consumer-payments-api/node_modules/db-migrate/node_modules/mongodb/node_modules/bson/build'
  CXX(target) Release/obj.target/bson/ext/bson.o
make: Leaving directory `/home/travis/build/practo/consumer-payments-api/node_modules/db-migrate/node_modules/mongodb/node_modules/bson/build'
><EMAIL_ADDRESS>install /home/travis/build/practo/consumer-payments-api/node_modules/db-migrate/node_modules/sqlite3
> node-pre-gyp install --fallback-to-build
[sqlite3] Success: "/home/travis/build/practo/consumer-payments-api/node_modules/db-migrate/node_modules/sqlite3/lib/binding/node-v46-linux-x64/node_sqlite3.node" is installed via remote
npm ERR! fetch failed https://registry.npmjs.org/escape-regexp/-/escape-regexp-0.0.1.tgz
npm WARN retry will retry, error on last attempt: Error: fetch failed with status code 502
npm ERR! fetch failed https://registry.npmjs.org/machinepack-urls/-/machinepack-urls-3.1.1.tgz
npm WARN retry will retry, error on last attempt: Error: fetch failed with status code 502
npm ERR! fetch failed https://registry.npmjs.org/escape-regexp/-/escape-regexp-0.0.1.tgz
npm WARN retry will retry, error on last attempt: Error: fetch failed with status code 502
npm ERR! fetch failed https://registry.npmjs.org/machinepack-urls/-/machinepack-urls-3.1.1.tgz
npm WARN retry will retry, error on last attempt: Error: fetch failed with status code 502
npm ERR! fetch failed https://registry.npmjs.org/escape-regexp/-/escape-regexp-0.0.1.tgz
npm ERR! fetch failed https://registry.npmjs.org/machinepack-urls/-/machinepack-urls-3.1.1.tgz
npm ERR! Linux 3.13.0-63-generic
npm ERR! argv "/home/travis/.nvm/versions/node/v4.4.4/bin/node" "/home/travis/.nvm/versions/node/v4.4.4/bin/npm" "install"
npm ERR! node v4.4.4
npm ERR! npm  v2.15.1
npm ERR! fetch failed with status code 502
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>
npm ERR! Please include the following file with any support request:
npm ERR!     /home/travis/build/practo/consumer-payments-api/npm-debug.log
The command "eval npm install " failed. Retrying, 2 of 3.
><EMAIL_ADDRESS>preinstall /home/travis/build/practo/consumer-payments-api
> npm cache -f clean && npm remove sails-mysql
npm WARN using --force I sure hope you know what you are doing.
npm WARN uninstall not installed in /home/travis/build/practo/consumer-payments-api/node_modules: "sails-mysql"
><EMAIL_ADDRESS>preinstall /home/travis/build/practo/consumer-payments-api/node_modules/sails
> node ./lib/preinstall_npmcheck.js
Sails.js Installation: Checking npm-version successful
npm WARN deprecated<EMAIL_ADDRESS>'native-or-bluebird' is deprecated. Please use 'any-promise' instead.
npm WARN optional dep failed, continuing<EMAIL_ADDRESS>npm WARN deprecated<EMAIL_ADDRESS>graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to<EMAIL_ADDRESS>as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained. Upgrade to<EMAIL_ADDRESS>npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to<EMAIL_ADDRESS>as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN deprecated<EMAIL_ADDRESS>cross-spawn no longer requires a build toolchain, use it instead!
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm ERR! fetch failed https://registry.npmjs.org/escape-regexp/-/escape-regexp-0.0.1.tgz
npm WARN retry will retry, error on last attempt: Error: fetch failed with status code 502
npm ERR! fetch failed https://registry.npmjs.org/machinepack-urls/-/machinepack-urls-3.1.1.tgz
npm WARN retry will retry, error on last attempt: Error: fetch failed with status code 502
npm ERR! fetch failed https://registry.npmjs.org/escape-regexp/-/escape-regexp-0.0.1.tgz
npm WARN retry will retry, error on last attempt: Error: fetch failed with status code 502
npm ERR! fetch failed https://registry.npmjs.org/machinepack-urls/-/machinepack-urls-3.1.1.tgz
npm WARN retry will retry, error on last attempt: Error: fetch failed with status code 502
npm ERR! fetch failed https://registry.npmjs.org/escape-regexp/-/escape-regexp-0.0.1.tgz
npm ERR! fetch failed https://registry.npmjs.org/machinepack-urls/-/machinepack-urls-3.1.1.tgz
npm ERR! Linux 3.13.0-63-generic
npm ERR! argv "/home/travis/.nvm/versions/node/v4.4.4/bin/node" "/home/travis/.nvm/versions/node/v4.4.4/bin/npm" "install"
npm ERR! node v4.4.4
npm ERR! npm  v2.15.1
npm ERR! fetch failed with status code 502
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>
npm ERR! Please include the following file with any support request:
npm ERR!     /home/travis/build/practo/consumer-payments-api/npm-debug.log
The command "eval npm install " failed. Retrying, 3 of 3.
><EMAIL_ADDRESS>preinstall /home/travis/build/practo/consumer-payments-api
> npm cache -f clean && npm remove sails-mysql
npm WARN using --force I sure hope you know what you are doing.
npm WARN uninstall not installed in /home/travis/build/practo/consumer-payments-api/node_modules: "sails-mysql"
><EMAIL_ADDRESS>preinstall /home/travis/build/practo/consumer-payments-api/node_modules/sails
> node ./lib/preinstall_npmcheck.js
Sails.js Installation: Checking npm-version successful
npm WARN deprecated<EMAIL_ADDRESS>'native-or-bluebird' is deprecated. Please use 'any-promise' instead.
npm WARN deprecated<EMAIL_ADDRESS>graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to<EMAIL_ADDRESS>as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN optional dep failed, continuing<EMAIL_ADDRESS>npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained. Upgrade to<EMAIL_ADDRESS>npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>cross-spawn no longer requires a build toolchain, use it instead!
npm WARN deprecated<EMAIL_ADDRESS>graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to<EMAIL_ADDRESS>as soon as possible.  Linux 3.13.0-63-generic
npm ERR! argv "/home/travis/.nvm/versions/node/v4.4.4/bin/node" "/home/travis/.nvm/versions/node/v4.4.4/bin/npm" "install"
npm ERR! node v4.4.4
npm ERR! npm  v2.15.1
npm ERR! fetch failed with status code 502
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>
npm ERR! Please include the following file with any support request:
npm ERR!     /home/travis/build/practo/consumer-payments-api/npm-debug.log
The command "eval npm install " failed 3 times.
The command "npm install " failed and exited with 1 during .

Please provide the abrupt solution

Ok, fixed!

Ok, fixed!

It got solved on its own!


wit: init at 3.0.3b

Motivation for this change
I am writing some nix expressions to patch some Nintendo GameCube images.
Wiimm's ISO Tools are helpful for this, and what I normally use.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

I tried a few new things with this package that I wasn't confident around:

Setting sourceRoot
Everything that needs to be built is under project/. I saw that some other packages set sourceRoot.
Am I doing this correctly?

Disabling Hardening
This package doesn't build unless we disable some hardening around format strings.

No Tags
The GitHub repository does not have tags, so I added the rev directly. The version is from this commit:

$ git show --no-patch
commit 7f41a7f1edf2bd1698482cafe1b10f6b87b73da7 (HEAD -> master, origin/master, origin/HEAD)
Author: Wiimm <none>
Date:   Sat Aug 22 10:37:50 2020 +0200

    WIT v3.03b: Intermediate version (no release)

Broken /usr/bin/env ... Scripts
I'm fixing this with sed, using an approach I saw in pkgs/shells/xonsh/default.nix.

Sorry, this is a duplicate of #90324. I need to start checking PRs before trying to package.
Closing, it was a good learning opportunity.


use originalMoveDate for incentive calc on ssw

Description
SSW should use originalMoveDate not actualMoveDate for calculating incentives...
Setup
make server_run
make client_run
In the office app, look at an ssw (i created a new move using the<EMAIL_ADDRESS>login). Ensure the incentive $$.
Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

good catch, thanks!
updated


Steps to validate Automatic Update Enabled

Can someone please add the steps to validate if the automatic update via Microsoft store is enabled or not?
We have MTR which was not auto updated but we don’t know how to troubleshoot automatic update issue. Our MS store is not blocked

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e4fa80cf-0319-c006-e886-4929a508b04c
Version Independent ID: 9d598765-fc30-17f0-6594-57de81d8aa39
Content: Manually update a Microsoft Teams Rooms device - Microsoft Teams
Content Source: Teams/rooms/manual-update.md
Service: msteams
GitHub Login: @dstrome
Microsoft Alias: dstrome

Hello @sbv2291
Have you seen this resource https://learn.microsoft.com/en-us/microsoftteams/rooms/rooms-operations ?
In this case, the best would be to open a support request from your tenant, they will be able to help in your specific scenario.

@scanum


standardize 'function' variable names standards

In the class HARK.ConsumptionSaving.ConsIndShockModel.ConsumerSolution, there are the following fields (with their types):

cFunc : LinearInterp
vFunc : ValueFunc
vPfunc : MargValueFunc
vPPfunc : MargMargValueFunc

These variable names are inconsistent with respect to the F in Func.
That is a little confusing. What is the notational standard here?
Suppose these variables were renamed, in order to establish some notational standard.
Then (these are quibbles): a more descriptive variable name would be appropriate.
"Func" is a very general concept in computing; indeed, arguably everything constructed by a programming language is a function (cf. the lambda calculus).
These variables are each of a different type and stand for a different concept, but only 1-3 characters are used to denote that concept.

The variation in Func vs func is due to whether the preceding character is
capital or lowercase.  This capitalization rule is consistent throughout
HARK, but probably non-standard in general.
These names could be more descriptive, but essentially every economist will
understand what cFunc and vFunc mean if they're told the context.  vPfunc
and vPPfunc are a bit more obscure, but are also fairly straightforward if
you know that vFunc exists.
They're each of a different type because they require different numeric
approaches to accurately represent.  The cFunc is actually a LowerEnvelope
(or LowerEnvelope1D, I can't remember what the class is called), whose two
elements might be a LinearInterp and a CubicInterp or two LinearInterps.
The value function and its derivatives are more accurately represented
numerically by "decurving" them-- composing the value function with the
inverse utility function-- and storing an interpolation of the
"pseudo-inverse" value function vNvrsFunc; these function values are
"re-curved" when the function is called.
On Mon, Feb 17, 2020 at 9:51 AM Sebastian Benthall<EMAIL_ADDRESS>wrote:

In the class HARK.ConsumptionSaving.ConsIndShockModel.ConsumerSolution,
there are the following fields (with their types):

cFunc : LinearInterp
vFunc : ValueFunc
vPfunc : MargValueFunc
vPPfunc : MargMargValueFunc

These variable names are inconsistent with respect to the F in Func.
That is a little confusing. What is the notational standard here?
Suppose these variables were renamed, in order to establish some
notational standard.
Then (these are quibbles): a more descriptive variable name would be
appropriate.
"Func" is a very general concept in computing; indeed, arguably everything
constructed by a programming language is a function (cf. the lambda
calculus).
These variables are each of a different type and stand for a different
concept, but only 1-3 characters are used to denote that concept.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/econ-ark/HARK/issues/528?email_source=notifications&email_token=ADKRAFO5OAKQGJLIDHNJO7TRDKP7JA5CNFSM4KWTD272YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IOBZZKQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKRAFJDJIN6I64J6WQ7TFDRDKP7JANCNFSM4KWTD27Q
.

Reasons for using "Func" here:

c, v, vP, and vPP would be ambiguous, because that might refer to:

The level of an object
The ratio of the level of the object to "permanent income"
A function that yields the level or ratio as a function of state variables

I believe strongly in having unique names for every object that appears regularly in our code

This makes it possible to search globally across all of HARK, REMARK, DemARK, etc for every instance
It also makes it reasonably easy to have a wholesale change in notation if we want

For example, a global replace of VPfunc and VPPfunc with VPFunc and VPPFunc

As a reminder, we do have the NARK for defining notational standards.
We have not really made much effort to abide by those standards, but I would propose that when suggestions for improvements of our usages are made, it would be useful either to

Reference the relevant section of the NARK, if there is one

If there is a relevant section and our usage deviates from it either:

Propose a revision to that section;
Propose that we bring our usages into compliance with that section;
Propose the case in question as a justifiable permanent deviation from the NARK's recommendations

If there is not a relevant section of the NARK, propose whether there should be one

And what its content should be

NARK

On issue with relying on NARK here is that NARK is mainly about mathematical notation.
The issue I'm raising here is more about coding conventions.
There is a section on coding conventions in the HARKmanual.
It says:

use camelcase
avoid single letter names

http://econ-ark.github.io/HARK/Documentation/HARKmanual/#x1-260005.4

The variation in Func vs func is due to whether the preceding character is
capital or lowercase.

This is not camelcase

vPfunc and vPPfunc are a bit more obscure, but are also fairly straightforward if
you know that vFunc exists.

Pardon my ignorance, but what does "P" stand for in these names?

Prime.  It's the marginal value function and the marginal marginal value
function.
On Mon, Feb 17, 2020 at 11:49 AM Sebastian Benthall <
<EMAIL_ADDRESS>wrote:

NARK
On issue with relying on NARK here is that NARK is mainly about
mathematical notation.
The issue I'm raising here is more about coding conventions.
There is a section on coding conventions in the HARKmanual.
It says:

use camelcase
avoid single letter names

http://econ-ark.github.io/HARK/Documentation/HARKmanual/#x1-260005.4
The variation in Func vs func is due to whether the preceding character is
capital or lowercase.
This is not camelcase
vPfunc and vPPfunc are a bit more obscure, but are also fairly
straightforward if
you know that vFunc exists.
Pardon my ignorance, but what does "P" stand for in these names?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/econ-ark/HARK/issues/528?email_source=notifications&email_token=ADKRAFK75DAV3GAIMCFSFC3RDK5YNA5CNFSM4KWTD272YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL7CFTA#issuecomment-587080396,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKRAFO2DJKH36GFGBGEECLRDK5YNANCNFSM4KWTD27Q
.

And vP is super important because of a key result that vP(m) = uP(c(m)):
http://www.econ2.jhu.edu/people/ccarroll/public/lecturenotes/Consumption/Envelope/#x1-14r11
while vPP derives its importance partly from this relationship.
On Mon, Feb 17, 2020 at 8:01 PM Matthew N. White<EMAIL_ADDRESS>wrote:

Prime. It's the marginal value function and the marginal marginal value
function.
On Mon, Feb 17, 2020 at 11:49 AM Sebastian Benthall <
<EMAIL_ADDRESS>wrote:

NARK
On issue with relying on NARK here is that NARK is mainly about
mathematical notation.
The issue I'm raising here is more about coding conventions.
There is a section on coding conventions in the HARKmanual.
It says:

use camelcase
avoid single letter names

http://econ-ark.github.io/HARK/Documentation/HARKmanual/#x1-260005.4
The variation in Func vs func is due to whether the preceding character
is
capital or lowercase.
This is not camelcase
vPfunc and vPPfunc are a bit more obscure, but are also fairly
straightforward if
you know that vFunc exists.
Pardon my ignorance, but what does "P" stand for in these names?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/econ-ark/HARK/issues/528?email_source=notifications&email_token=ADKRAFK75DAV3GAIMCFSFC3RDK5YNA5CNFSM4KWTD272YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL7CFTA#issuecomment-587080396
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ADKRAFO2DJKH36GFGBGEECLRDK5YNANCNFSM4KWTD27Q
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/econ-ark/HARK/issues/528?email_source=notifications&email_token=AAKCK7ZDY7OIF7XXE7BECIDRDLNG7A5CNFSM4KWTD272YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL7MN2A#issuecomment-587122408,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKCK74OWJVZ43VOXG5GCZ3RDLNG7ANCNFSM4KWTD27Q
.

--

Chris Carroll

See also MPCnow

... as what?  An example of non-camel-case?
The MPC is an abbreviation ("Marginal Propensity to Consume").  Abbreviations are exempt from camelCase rules; unless, maybe, you think it should be mpcNow?  Problem is that for acronyms, the capitalization of letters is a signal that each capitalized letter stands for a word...

I think he wants the N in now to be capitalized: MPCNow.  When words that
would ordinarily be capitalized immediately follow a capital letter, I
didn't capitalize them.  Thus MPCnow and vPfunc.  This is what I mean by
the capitalization in HARK being consistent.
On Tue, Mar 3, 2020 at 3:47 PM Christopher Llorracc Carroll <
<EMAIL_ADDRESS>wrote:

... as what? An example of non-camel-case?
The MPC is an abbreviation ("Marginal Propensity to Consume").
Abbreviations are exempt from camelCase rules; unless, maybe, you think it
should be mpcNow? Problem is that for acronyms, the capitalization of
letters is a signal that each capitalized letter stands for a word...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/econ-ark/HARK/issues/528?email_source=notifications&email_token=ADKRAFNNEANOUBL7MCNOJIDRFVUHPA5CNFSM4KWTD272YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENVCXQA#issuecomment-594160576,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKRAFNWY34LGJ3EMFCNLQLRFVUHPANCNFSM4KWTD27Q
.

Yes, I meant that this is an example of MNWcamelCase style.

I see.  This is a good example of a case where it makes sense to have the "now" be lower case, because if it were MPCN people might try to guess what the fourth word in the acronym was ("Normalized?  iNfinite?).  When "now" is not capitalized, it is clear.  We could make this an explicit exception to any general rule.  (We do have a fair number of acronyms: GIC, GICPF, FVAC, etc).

Oh, wow. I hadn't thought of that reason for using MNWcamelCase.
There are some generic Python style guides which might be helpful here:
https://www.python.org/dev/peps/pep-0008/#prescriptive-naming-conventions

Class names use StudyCase
For functions, methods, and members variables, the Python authorities prescribe "lowercase with words separated by underscores" (sometimes known as snake_case )

I very much like the idea of trying to develop usages consistent with rules like the ones above.
But before we get too caught up in designing elaborate schemes, we will need to confer with Pablo.  He already uses underscores to signify subscripts, and I believe has also some other conventions that his code actually interprets syntactically.  And as he develops the DolARK language, I think he is planning to move further in that direction.  We would not want his code to interpret snake_case as the variable snake with a subscript indicating c times a times s times e or something!

This is being dealt with in the governance repository.
Once the Style EEP is passed, then a new issue will be made for the implied changes.