Initial docs for envFrom ConfigMap

corresponds to proposal https://github.com/kubernetes/community/pull/148

This change is

@pmorie can you verify that the yaml looks good so I can merge the request? thx

@fraenkel So is this for 1.6? If so, I'll tag it so that it's not merged before we open a branch for 1.6

Yes, this is 1.6

@fraenkel FYI, the kubernetes:release-1.6 branch is now available. Please change the base branch to that. Thx

@chenopis Base branch is now release-1.6

If the context contains some symbols like "v1.6 above only", that would be much better.
At first sight, I think it was a bug at first sight,=) , because my env is v1.5.2.

@zhangxiaoyu-zidif Do you want to add that to the documentation as a note in another PR?

@chenopis I‘d like to. PTAL https://github.com/kubernetes/kubernetes.github.io/pull/3511
Thanks.=)


Link  Broken

On the rendered page:
https://specs.amwa.tv/is-11/branches/v1.0-dev/docs/Overview.html#introduction
The link to Resource Core JSON Schema is broken
Steps to reproduce.

Open page https://specs.amwa.tv/is-11/branches/v1.0-dev/docs/Overview.html#introduction
Click on Link for Resource Core JSON Schema

Expected behavior
Link opens
Observed Behavior
Link does not open
Extra Hints:
Works ok on the actual repo.
Looks like a double use of with-refs.
Link broken link is: https://specs.amwa.tv/is-04/releases/v1.3.2/APIs/schemas**/with-refs/with-refs/**resource_core.html

Sorry, yes, already tracked here - https://github.com/AMWA-TV/is-11/pull/106#issuecomment-1242636229


Rename package to libdrizzle-redux

Avoids name clashes when having parallel versions of libdrizzle installed.
Requires modifying package name in relevant files used by automake
The valid linker name is now libdrizzle-redux.so

LGTM

@leandro-lucarella-sociomantic, Is there some more elegant way of renaming...e.g. the so and real  name depends on the previously defined variables?

All the .am changes were generated running some autotools command, right?

All the .am changes were generated running some autotools command, right?

Nope, that's what made me wonder. Both are part of the original repo:
http://bazaar.launchpad.net/~drizzle-trunk/libdrizzle/libdrizzle-redux/view/head:/libdrizzle/include.am
http://bazaar.launchpad.net/~drizzle-trunk/libdrizzle/libdrizzle-redux/view/head:/tests/unit/include.am

I'm a bit rusty in terms of autotools, but I know there are some steps that change so rarely that are usually generated and committed to the repo (the project name is one of those I would say). The bootstrap.sh scripts sounds a lot like it could be it...

From a quick look at some autoconf documentation it seems like all .am files are strictly sources, so I guess there is no automated way to change that...

If no further comments, then rebasing this and #20 will finish the changes needed for our use of libdrizzle-redux

This PR LGTM.

Great, feel free to merge

This pull request has been rebased via git hub pull rebase. Original pull request HEAD was ded667c5a56c4a3c13c08ace91f8746488550b29, new (rebased) HEAD is 71ae71f4d9bc509b8c3b442800395acc8d18ae96


Fix ros2 lsim launch

Add group tag to launch file to create scope for arg.
Remove pointcloud relay for localization.

Relay前のトピック
customized: /sensing/lidar/top/rectified/pointcloud
aip_s1:     /sensing/lidar/top/rectified/pointcloud
aip_x1:     /sensing/lidar/top/outlier_filtered/pointcloud
aip_x2:     /sensing/lidar/top/rectified/pointcloud
aip_xx1:    /sensing/lidar/top/rectified/pointcloud
aip_xx2:    /sensing/lidar/top/rectified/pointcloud


SourceOrbit file names problem

I have used SourceOrbit to generate the "Rules.mk" files.:
so -bf bob
It looks like the are problems with objects names that start with "$"
$LOWKXT0F.FILE: $LOWKXT0F.PF
$LOWKXT0L.FILE: $LOWKXT0L.LF $LOWKXT0F.FILE

Is there a way to make SourceOrbit to accept these characters?

When I build the project, I receive lots of errors about the rules.
For Example:
make: *** No rule to make target '/Smedoc/bob/P_FENS/SMEQSM/STG640V.DSPF', needed by 'STG640V.FILE'.
The actual name is not "STG640V.DSPF" but "$TSTG640V.DSPF" and the rule is define with the actual name.

I think this is a BOB issue and not a SO issue. I will transfer the issue.


Remove docs from Osmosis repo

Closes: #800
Description

[ ] Remove Docs from osmosis's repo
[ ] Remove Doc's git action
[ ] Added a placer holder to let people know about the new repository.

Pretty exciting that its already time for them to graduate to their own repo =)


PR Review Template Discussion

Issue summary

Solution Document
This falls under the person raising the PR

This is to provide context for the problem that is being worked on
Following the questions of a) Why this changes were needed b) How it will affect the code c) What changes have been implemented
Refer to this sample solution doc

PR Review Sample Checklist
This falls under the person reviewing the code

Variable Names
Readability
Performance
Test Coverage
CI and Lint
Nits: spacing, spell check
Documentation for new changes added
Comments on why a certain change was added

Feel free to add more points for this section.

Note: Worked on this with @creativcoder

This blog post has a more to say about code review checklists that we can borrow ideas from: https://deepsource.io/blog/python-code-review-checklist/


Variable parser for parsing JSON with JSONPath and adding it to response

Add more flexibility to a stub by providing a variable parser which parses (valid) JSON, queries that JSON using JSONPath and replacing the variable in the response with the result of the JSONPath query. Here is a possible example:
The stub
- id: jsonpath-example
  conditions:
    method: POST
    url:
      path: /jsonpath-example
  response:
    statusCode: 200
    text: The result: ((jsonpath_query:$.phoneNumbers[?(@.type=='iPhone')].number))

The request
POST http://localhost:5000/jsonpath-example
Content-Type: application/json
{
  "firstName": "John",
  "lastName" : "doe",
  "age"      : 26,
  "address"  : {
    "streetAddress": "naist street",
    "city"         : "Nara",
    "postalCode"   : "630-0192"
  },
  "phoneNumbers": [
    {
      "type"  : "iPhone",
      "number": "0123-4567-8888"
    },
    {
      "type"  : "home",
      "number": "0123-4567-8910"
    }
  ]
}

The response text
The result: 0123-4567-8888

Has already been done in #173


[SPARK-37703][BUILD] Upgrade SBT to 1.5.8

What changes were proposed in this pull request?
This PR aims to upgrade SBT to 1.5.8
Why are the changes needed?
 SBT 1.5.8 was released, which includes a fix for CVE-2021-45105.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass the CIs.

Test build #146435 has started for PR 34971 at commit 2f78208.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50910/

Test build #146438 has started for PR 34971 at commit cc4864a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50913/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50910/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50910/

Test build #146435 has finished for PR 34971 at commit 2f78208.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146435/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50913/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50913/

Test build #146438 has finished for PR 34971 at commit cc4864a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146438/

Ur, it seems that this company still ban the personal credits by using<EMAIL_ADDRESS> Authored-by: dch nguyen<EMAIL_ADDRESS>
Maybe, I lost the context about the previous discussion. @HyukjinKwon . Is this the final conclusion with this company?

Hm, this is slightly odd actually. The final decision was that to add<EMAIL_ADDRESS>as a secondary email to @dchvn's personal account, and use his own email as a primary email address. Seems like<EMAIL_ADDRESS>is set as a primary account.
@dchvn mind changing the primary email address in your account as your personal email address? Please change it here at https://github.com/settings/profile

Also, I would encourage to not to use a company image in the profile picture since this is your own personal account, and it would be great to make sure this account is used individually as we discussed.

Thank you for the summary, @HyukjinKwon !

I updated as your suggestion. Thank you, @dongjoon-hyun @HyukjinKwon !


refactor(semantic): remove more-asserts dependency

#5739  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


Feature Request: Warning banner for data entry pages

At the moment, the module is aimed at trying to prevent survey respondents from entering real data in development & practice/just for fun projects, but apart from changing the color of the warning on the Add/Edit Records page from yellow to red, it does not warn logged in users not to enter any real data.
It would be wonderful if the option could be added to configure a warning banner on all data entry pages (potentially even all project pages). You could for example add this banner after the div-element with the id 'subheader', that seems to be present on all project pages.
Adding this option could help reduce the number of incidents where a user requests to move their project to production and starts entering real data before an administrator can perform the necessary checks and approve the request to move the project to production.
Would you consider adding such an option?

Thanks for the suggestion @steentje34, I think that sounds totally reasonable. I'll have a think about whether this should be the standard behaviour (easier to implement), or if it should be controlled by a new EM setting. I'll also consider abstracting out the function that generates the warning div from the hook function so it can be reused better. This all means I'm unlikely to get to it very soon I'm afraid.

@jangari Would it help you if I tried to implement this feature myself and open a pull request once I'm done?

@steentje34 Sorry for late response. There has now been another request for this functionality. I think I would be hard pressed to fit it in. If you are still willing to work on it and submit a PR, I would welcome it!
For a data entry form page, it would be best if it were placed as close to the data entry as possible, say, as the first child of the dataEntryTopOptions div. That way it should be present even when other EMs (like instance table) remove all other elements apart from the data entry itself. Here's a mockup:

I think in the first instance, including this in the default behaviour would work, and later it can be controlled by a config option. What do you think?

@steentje34 I have done this in a quick and inefficient way (see b8370a6). Are you able to test this out?

@jangari Thanks for the new version! We have thoroughly tested it, and are very happy with the result! Thanks!


Richer formats then "conversation"

https://github.com/pluralitybook/plurality/blob/493c1aae9183eb51fa9840b43502b35d52211dc2/contents/english/05-04-deliberation.md?plain=1#L25
There is a very rich set of deliberative methods that have been innovated in the last 50-60 years that do more then support "conversation". I often call these social technologies.
Participedia https://participedia.net/
NCDD has a big collection of methods and a framework for understanding when to use what method - https://www.ncdd.org/streams.html
I know that digital tools present great promise - but I believe this is complementary promise to more broadly using working social technologies and augmenting them with appropriate digital technologies. I think this intersection could be a very fruitful one.
This is a chart I worked on with Tom Atlee exploring his favorite - in person deliberation methods and the steps with potential online complements (which have of course advanced since then)
https://identitywoman.net/wp-content/uploads/ExtremeTaoDemocracy.pdf

Agreed, and when added the earlier chapters in this part of the book plan to highlight some of these practices.  Once they are merged in, I'd encourage you to submit PRs if you think there are important practices not being covered.

Great. Let me know when those sections are merged and I will read and raise some PRs if it makes sense to do so.

Early versions are already there, but you may want to wait as they are not organized in a very comprehensive way.  I'll let you know when they are.

I went to read this page and didn't find any discussion of the highly performant actually in use in person deliberation and decision making methods.  If someone else isn't already doing this. May I add a paragraph about these?

Please.

Research Lead, Plural Technology Collaboratoryhttps://aka.ms/plural, Research Special Projects

Collaboratehttps://github.com/pluralitybook/plurality with Digital Minister Audrey Tang, myself and dozens around the world to tell the story of Pluralityhttps://www.plurality.net/

From: Kaliya - Identity Woman @.>
Sent: Tuesday, February 27, 2024 5:22 PM
To: pluralitybook/plurality @.>
Cc: Glen Weyl @.>; Comment @.>
Subject: Re: [pluralitybook/plurality] Richer formats then "conversation" (Issue #256)
I went to read this page and didn't find any discussion of the highly performant actually in use in person deliberation and decision making methods. If someone else isn't already doing this. May I add a paragraph about these?
—
Reply to this email directly, view it on GitHubhttps://github.com/pluralitybook/plurality/issues/256#issuecomment-1967747173, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABIRKSDETT37IJFYOX23JB3YVZMBJAVCNFSM6AAAAABBDTIPR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRXG42DOMJXGM.
You are receiving this because you commented.Message ID: @.***>


Collaborators receive email notifications

the system sends a notification to unsuccessful EP  and non-EP applications users and collaborators
the system sends a notification to winners to check their press release to EP  and non-EP applications users and collaborators.
we no longer send notifications to the user when an admin approves a press release

https://trello.com/c/XuEdoOAG/290-qae-support-confirm-which-emails-are-sent-to-which-users

Looks good :+1: , but need corrects, explained in slack


fix issue #2775

Close  #2775

@AbraaoAlves you have to change the commit message for the travis CI to pass. Something like:
feat(items): add nav-direction support, fixes #2775

Fixed,
Thanks @arcanis

LGTM, marking this for further testing

Greetings @AbraaoAlves!
Thank you very much from all of us on the Ionic team for submitting this pull request. We appreciate your commitment to improving Ionic. Unfortunately, we are unable to merge this particular PR, as it may cause regressions or is already out of date with regard to recent fixes. We apologize, as we know how much time you may have put into the work.
We hope you will continue to contribute to Ionic in the future. Please note that we are more likely to merge a smaller PR that has a passing test and changes only one meaningful feature in the project.
For more information, please review our Pull Request Guidelines.
Best regards,
Ionitron


ModelAdminMixin: Only remove 'render_inline_actions' if exists

Description
Do not break if customisation removed the render_inline_actions field.
Fixes #39
Checklist

[x] Tests covering the new functionality have been added
[x] Code builds clean without any errors or warnings
[x] Documentation has been updated
[x] Changes have been added to the CHANGELOG.md
[x] You added yourself to the CONTRIBUTORS.md

Pull Request Test Coverage Report for Build 542041598

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 98.947%

Totals

Change from base Build 478775147:
0.006%

Covered Lines:
188

Relevant Lines:
190

💛  - Coveralls


feature/fhir-aggregator

This PR:

creates a fhir service for loading and testing
instructions how to :

start service
load data
count data

python fhir-util.py count-resources

BodyStructure: 537
Condition: 537
DocumentReference: 29352
Encounter: 20
Group: 13069
ImagingStudy: 2177
Medication: 1074
MedicationAdministration: 1074
Observation: 23676
Patient: 537
Procedure: 1616
ResearchStudy: 2
ResearchSubject: 537
Specimen: 17121

Changed the base to ncpi-fhir-aggregator this will be our "main" for now


Neumann Boundary Condition for Electromagnetic Diffusion Problem(ex3.cpp)

I am trying to generalize ex3.cpp for electromagnetic diffusion problem  Curl Curl E + E = f and I need to specify Neumann boundary conditions on some of the boundaries as follows
Curl E x N = g
where N is the surface normal and g is a user-defined vector function.
In the example code (ex3.cpp) all the boundaries are Dirichlet (i.e., ExN=0), and I would like to know how to implement the above Neumann boundary condition on top of that.

Hello, @mortezah ,
Inhomogeneous Neumann boundary conditions can be applied by adding the appropriate surface integral to the right-hand-side vector.  In this example you'll need to add a line near line 125 of ex3.cpp similar to the following:
b->AddBoundaryIntegrator(new VectorFEBoundaryTangentLFIntegrator(CurlECoef));

or
b->AddBoundaryIntegrator(new VectorFEBoundaryTangentLFIntegrator(CurlECoef), nbc_marker);

In either case CurlECoef is a VectorCoefficient which returns the desired value for Curl E, the x N is handled inside the integrator.  The nbc_marker in the second option is an Array<int> which controls which portions of the boundary should use this boundary condition.
Best wishes,
Mark

Thanks, @mlstowell for the pointers. That solved my problem. I am closing this issue.

I am reopening this issue since I have a question related to the same topic.
I am trying to generalize the example by adding adaptivity. Do I need to update any of the information related to the boundary conditions after I adapt the mesh? If yes, how can I achieve that, especially for the Neumann boundary conditions?
For my adaptive loop, I am using the same loop in exp6.cpp (https://github.com/mfem/mfem/blob/ea9aecce9551f0bfb0e9857a641312f027f06d00/examples/ex6.cpp#L140) with the only difference that I am using an external library (PUMI) to do the adaptation. My code fails at the following line after the mesh is adapted
b.Assemble();
with the following error message
Assertion failed: (bdr_marker.Size() == bdr_attr_marker.Size()) is false:                                                                                --> invalid boundary marker for boundary integrator #0, counting from zero                                                                                ... in function: void mfem::LinearForm::Assemble() ... in file: /users/hakimm2/SCOREC/mfem/fem/linearform.cpp:119
I am guessing this is because I may need to update nbc_marker (see @mlstowell comment above) after the mesh changes. Any help/insight into this is appreciated.

This indicates that the boundary attributes have changed after the refinement - this should not happen. This may be an issue in the MFEM <--> PUMI interface. Maybe @KazemKamran or @cwsmith can comment on this - I'm not sure what happens with the boundary attributes when the mesh is converted from MFEM to PUMI and back from PUMI to MFEM.

@mortezah Any process that you do before meshAdapt to apply boundary condition, you should repeat after meshAdapt.  For complicated geometries there is an example that shows the usage of reverse classification to apply boundary condition attribute ( https://github.com/mfem/mfem/blob/master/examples/pumi/ex2.cpp#L176).

Thanks, @v-dobrev, and @KazemKamran for the inputs. I was able to get a working adaptive workflow for ex3.cpp.


WorkflowManager

Here is a very basic implementation of the workflow manager as I described in the last meeting.
A notebook shows the basic principle of how this works and how a workflow step needs to be defined.
There is clearly more functionalities to be added, and I will continue adding some workflow steps in the coming days.
I'll make it a proper pull request once a few more workflow steps are defined.

Thank you @rettigl for looking into this. I'll try answer your questions in a few points

this is intended as an automatic pipe, which runs all provided methods with the given parameters with no need for user input. This is necessary if we want this to run as an automatic correction system (even though only on the long run). Also, makes it the simplest approach for users, as they need only call a list of trnsformations, which can be pre-defined, making for example a standard correction pipe for a given beamtime/experiment.
The definition of the parameters should be a separate problem. Each user should have the freedom of using the tool that they prefer to do this. However, we of course will provide one (python based) method to determine them for each correction method we provide. The structure of these is not yet defined, but could be presented in jupyter notebooks as examples. This also gives a space to properly describe how these transformations work, should a user be interested. The generated parameters can be then stored in a json/config file
this json/config currently these methods need explicit parameters, but this can easily be switched to picking values from a json/config file instead. These could be defined as in point 2, or kept as fixed values provided by the beamline (for corrections which don't change over an experiment)
I know the function is very similar to what you added, but if you look at the structure of it, (class) it does not have the same implementation. Obviously, we should not keep processor and workflow at the end, and the corrections you imported from MPES will need some adaptation for the new system.
I am also planning to make a workflow_step generator function, which passing it a function, returns a subclass of WorfklowStep which runs the given function. THis could both simplify transition of existing mehtods, and add the possibility of user generated transformations

I hope this wall of text answers some of your concerns, and keep in mind this is still work in progress 😄

as discussed, I will try to include #97 in this (just for my reference)

This PR could probably be closed, as I have restarted from an other more recent branch, to avoid needing to merge in all changes made in the mean time.
Other than that there is no real update so far, I hope to have something soon though.


HTML

HTML
User Story
As a bootcamp student
I want the prework notes to be structured on a webpage
so that I can easily find and read information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, Git and Javascript with associated notes listed

CSS
User Story
As a bootcamp student
I want the prework notes to be structured on a webpage
so that I can easily find and read the information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN  I view the study guide
THEN I see a dark blue header and footer, and four boxes with a shadow


Please change the default baseURL

Please change this to something like https://example.org/. In the Hugo forums we get large number of new users that get in to trouble because they keep this example setting.
https://github.com/gethyas/doks/blob/2c955aefc3aa75f0f784e5008900a76c572b9e77/config/_default/hugo.toml#L2

The new local default: https://github.com/gethyas/doks/blob/main/config/_default/hugo.toml#L2
Production URL set in: https://github.com/gethyas/doks/blob/main/config/production/hugo.toml


Remote force check update

updatenotification:
allow force scanning with SCAN_UPDATES notification from other modules

Codecov Report

Merging #3127 (1bfbc00) into develop (e985e99) will increase coverage by 0.06%.
The diff coverage is 48.14%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##           develop    #3127      +/-   ##
===========================================
+ Coverage    25.55%   25.62%   +0.06%
===========================================
  Files           53       53
  Lines        11464    11479      +15
===========================================
+ Hits          2930     2941      +11
- Misses        8534     8538       +4

Impacted Files
Coverage Δ

...s/default/updatenotification/updatenotification.js
0.00% <0.00%> (ø)

modules/default/updatenotification/node_helper.js
81.60% <68.42%> (+3.68%)
:arrow_up:

looks innocent enough for a quick merge :-) sorry for not going through the animate stuff yet, this takes more concentration :-(

Could you also create a PR for adding these notifications to the docs?

Ok, i will take a look for prepare docs for all my stuff (commited or not)

@rejas : have you already had the case locally that the e2e test suite failed (npm run test:e2e) and without touching anything, by relaunching npm run test:e2e it works?
I got it twice (even with the branch master, naturally without any 3rd party modules)

@rejas : have you already had the case locally that the e2e test suite failed (npm run test:e2e) and without touching anything, by relaunching npm run test:e2e it works?

yes, the tests fail sometimes without any good reason. maybe some timing issues or whatever, we couldnt find it out yet. any help there would be greatly appreciated


Support for prompt chaining?

Does this workflow support prompt chaining?
If not, I would love to have it as a feature.
If so, could you mention it in the README with an example?

Thank you for reaching out to me. Currently, I don’t plan to add support for prompt chaining in this workflow.
However, I am working on a new project involving an OpenAI chat API web interface running on Docker. I will create an Alfred workflow for this new app, allowing you to do many things, including prompt chaining, data import/export, voice recognition, speech-to-text, etc. I hope you try it out once it's been released!


Goto Clip - is there feedback for which clip is currently cued

Feature request -
4 buttons map to 4 clips
User desires to have the currently cued clip in green, and pressing a button uses Goto Clip (n) to cue that clip

This is now implemented. You can set feedback based on the clip id and, optionally, the slot.


Adding License file

I'm not sure about the licensing for this repo. Could you therefore add a license file? This would be great.

it's completely open.  I have removed what the absence of a license would have meant.  Hope that helps @Guschti42


SAK-41309:Error when linking an assignment with GradebookNG

Please @ern, could you take a look? Thanks!

Working on a better solution


Update wagtail-flags to 2.0.7

The main change here is that the path condition (which checked that a path started with a particular string) has changed to path matches, and accepts a regular expression to check the path against.
Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the development playbook
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated
[ ] Reviewers requested with the Reviewer tool :arrow_right:

:+1: This looks okay to me, because a review of the current flags defined in settings doesn't show any existing "path" conditions as mentioned by @willbarton here.

And I confirmed that the data migration works for all the flags we currently have configured to use a path.


Prefix Temp on addtemp group

Hi, I have problems adding a user to a group by time
example
/Lp user name parent addtemp vip 7200s global
The problem is that the prefix is not seen in the TAB
But if I use /lp user name parent set vip global
If you can see the prefix in the TAB
The problem I have is the temporary donation system
Any way to make the prefix appear?
Also try
/Lp user name meta addtempprefix 100 & aVIP global but still unseen.
Please look at this image:
My chat is based on permissions with DeluxeChat, I do not use any placeholder because using placeholder the prefix looks blank ... but since this is a good permissions plugin, create groups so that the chat looks cute
otherwise So I could not tell you if the same problem is in the chat
http://s2.subirimagenes.com/imagen/previo/thump_97783302017080600.png

Make sure you're using the same placeholder for the prefix in the tab as you do for DeluxeChat.


[sw] Remove device_id checks from spi host tests

We would like more flexibility to change flash parts in CI without breaking these tests.
Removed the device_id check, but retain the manufacturer ID check.
I have not checked for 0x00 or 0xff as signs of failure since these are legitimate device IDs.

Fix https://github.com/lowRISC/opentitan/issues/23625


update url

Signed-off-by: Wenqi Li<EMAIL_ADDRESS>Checks

[ ] Avoid including large-size files in the PR.
[ ] Clean up long text outputs from code cells in the notebook.
[ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key.
[ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
[ ] Notebook runs automatically ./runner.sh -t <path to .ipynb file>

this notebook breaks the guidelines test, but the code cells looks good to me... @mingxin-zheng

Hi @wyli , the guidelines test did not pass because
Error: Missing the "Setup imports" after the first code cell of file: /home/runner/work/tutorials/tutorials/model_zoo/TCIA_PROSTATEx_Prostate_MRI_Anatomy_Model.ipynb.

In this notebook, there is an extra markdown cell "## Setup the im-joy-jupyter-extension for itkWidgets" between the code of env setup and "## Setup import", which is not accepted by the test.
If there will be notebooks in this style in the future, we can merge the "## Setup the im-joy-jupyter-extension for itkWidgets" and "## Setup imports" into one markdown cell as a hack, and update the runner.sh in another PR to fix this.
If this is a special case, as mentioned in this message, putting it with the "## Setup environment" cell may be better.


Update import to work with newer versions of rxjs

Thanks for that, are you targeting a particular version of it? I'll try to release a new version later :)

My project is using Angular v6, which generally means rxjs 6.x has to be targeted as well.
Before making this change, when I run ng serve I would see:
ERROR in node_modules/spotify-auth/src/service/spotify-auth.interceptor.d.ts(2,28): error TS2307: Cannot find module 'rxjs/observable'.
Capitalizing that 'o' is the only change I had to make to get it up to date, but I haven't tested that with older versions yet.


Fix python3 unittests

'python3 setup.py test' was complaining about failing to import the 'common'
module. Fix by moving the integration tests to a separate folder
All the tests should pass with these changes: https://travis-ci.org/benfred/nmslib

Great this seems to work. I will merge the recent changes into master and create a pipy package!

awesome!

I can't agree more!!! It's in the master now and the badge: build passes is there. A couple of questions:

I want to add a PyPI badge, is this a good website to create a Badge?
what is necessary to activate the automatic build on Windows?
Thank you!

I'm not sure about the best place for pypi badges - but I've seen people use shields.io (like using https://img.shields.io/pypi/v/nmslib.svg for the image - will have the pypi version once you push it).

The windows build wasn't working - I've fixed with that last PR there https://github.com/searchivarius/nmslib/pull/208 . You can enable the build here https://ci.appveyor.com for your project - steps should be similar to travis . The output will look like https://ci.appveyor.com/project/benfred/nmslib .

Great, I think I have tamed the Windows build and the badges. One need to set the build to x64 though. Will try to get a pypi bad as well!

Nice! Thanks for getting the pypi version up and going. I tested out the pypi version by going 'pip install nmslib' on both an ubuntu and osx machine - and it worked seamlessly in both cases.
I've made some minor updates to the README to reflect installing from pypi as the best option for python. Also I tweaked the badges so clicking on the pypi badge takes you to the page on pypi and clicking on the appveyor badge does the same: https://github.com/searchivarius/nmslib/pull/210


chore: setup SQL review CI for Bytebase

This pull request is auto-generated by Bytebase for GitOps workflow.

This PR will be canceled since we use reusable workflow


Extract generic components and add support for binding generation

Goal : Align on the potential avenues to enable Javy's codebase to serve arbitrary use cases.
The proposed solutions should

Keep compatibility with module snapshotting through Wizer
Allow composing JavaScript modules through module linking (more concretely the Component Model)
Provide an interface to the underlying JavaScript that allows:

Allocating and freeing memory, as described in the Canonical ABI
Binding generation for Interface Types (á la wit-bindgen)

Provide a way to configure multiple data serialization mechanisms (i.e. using messagepack instead of relying on interface types)
Not define platform specific behavior. The solution should focus only on providing the necessary building blocks as dependencies so that consumers can import those building blocks to build custom solutions.

Proposed (high level) changes

Publish the quickjs_sys crate as a standalone crate
Remove platform specific behavior from the core crate

Custom function entrypoints
Factor out the messagepack serialization part into its own crate (i.e. javy_messagepack)
Remove crate-type = cdylib, should be a normal lib crate

Add the missing JS_* interfaces in the core crate that will help in Interface Types binding generation.
Introduce a new crate responsible for interface types binding generation (i.e. javy_bindgen / quickjs_bindgen)

Usage
With interface types
In a bindgen-based scenario, a rough sketch of the usage would be:
// In a custom lib.rs

use javy_bindgen::import!("path/imports.wit"); // (1)
use javy_core::Context; // (2)

let import_obj = Context::new_object()?;

imports::bind(&context, &import_obj); // (3)

(1) Generate code for imports (defining a wrapper around the host export, lowering parameters, lifting return values). Similar thing will be done for exports.
(2) javy_bindgen will depend on javy_core; a given consumer could depend directly on javy_core or javy_bindgen could re-export the API from javy_core.  (This is TBD)
(3) The consumer must explicitly call the setup code
With a different serialization mechanism
In a messagepack-based scenario, a rough sketch of usage would be:

use javy_messagepack::{to_js_value, to_bytes};
use javy_core::Context;

let input = to_js_value(&context, &bytes).unwrap();
let output  = to_bytes(&output_value.unwrap()).unwrap();

Open questions/tradeoffs/thoughts

Regarding the CLI: with the proposed changes and approach, the CLI crate becomes irrelevant IMO in the context of reusability, given that each consumer is responsible for creating a project and for putting each of the pieces together depending on each use case, following that line of thought, each consumer/use case will be responsible for providing their own CLI implementation. Thoughts?

Regarding binding generation for exports/imports: I took Suborbital's base implementation^1 as a reference, and therefore this proposal operates under the assumption that import and export generation will always be static (at compile time) and always made completely available to the JS source code,  I could see a possibility where the generation should be done in a more dynamic way, in which the consumer specifies a subset of the functionality that they'd like to import, but I'm not sure if: (i) that's a realistic use case (ii) such use case should be considered as part of this proposal (iii) the feasibility of such use case.

Is there anything else that should be included? Excluded?

each consumer/use case will be responsible for providing their own CLI implementation

Interesting that you say this, because in looking at napi as a means of distributing javy via npm, it occurred to me that we probably want a JavaScript/Node CLI that calls into javy as a library, rather than a Rust-based CLI.

I think we'll revisit this at some point, but for now I'm closing it.


[New Feature]: No API to get the location of a NodeList

Description
$subject.
Encountered this requirement to @TharmiganK when getting the location of absolute-resource-path in service socialMedia:Service /social\-media/api on new http:Listener(8080).
We can get the location of the NodeList from underlyingListNode().location(). However, underlyingListNode() is not exposed to public.
So, I think we can implement an API location() from NodeList class which returns underlyingListNode().location().

This seems like a common requirement. However, I wonder how we didn't encounter such until today. :)

Closing this issue for now since we don't plan on addressing it immediately.


Using the app while connected to a network without internet leads to an unintended sign out

This bug does not seem to happen from me 🤔
Maybe it's under certain circumstances or something.


Make all sendable structs (de)serializable

#20 related.
Just added a couple of attributes.
Also, can't fromstr_deser! and tostr_ser! macros be replaced with derive attribute macro? Do these macros do something important that I don't suspect?

If your question is about replacing these macros with derive(Deserialize) and derive(Serialize)

Yes, my question was about this. I did a little search and found that a macro #[serde(untagged) on Other(String) variant is just what we needed.
Full version:
#[serde(rename_all = "camelCase")]
#[derive(Debug, Clone, Serialize, Deserialize)]
pub enum PathFormat {
    Path,
     Uri,
     #[serde(untagged)]
     Other(String),
}

However, this should be a crate feature that is disabled by default

This crate makes life easier by just mapping DAP structures to Rust structures and enabling smooth conversions between them. I think prioritizing this as the main goal, with client/server code as a bonus, will be a sensible approach.

#[serde(rename_all(serialize = "snake_case", deserialize = "PascalCase"))]

Also we should deserialize to PascalCase, since Rust Structs and Enums have such naming.

Passing all 76 tests. Thanks for them, it would be a living hell to make sure everything okay without tests.
Should we remove gen_enum_from_strings.py script and the macros?

Sorry for the mess, was trying to rename branch name👀

Those two tests I added should be enough because all the enums have the same structure and differ only in names and "tagged" variants. What do you think?

These tests were introduced in commit 84ac086

Sorry, problem appeared in specific adapter

I rechecked my needs and I think dap-rs can be used for client code with current changes and this PR review-ready.

Yeah, go ahead

How is it going?

Hi everyone, I'm using dap-rs in a project and would just like you to know that this patch fixed a bug with the Scope struct and probably a bunch of others too. Here (You have to expand the diff for types.rs) you can see that an erroneous serialization in snake case and not camel case was removed.
Thanks for taking care of this! Updating to the latest crate version made this problem simply go away :)


Remove depremharita.online from malicious website list

Can you please remove depremharita.online from malicious website list. You can visit the website and see that there is nothing related to phishing. Because of you, people weren't able to reach our site since yesterday. I was trying to figure out what the hell is wrong with my domain since yesterday. Please, investigate it well before giving a bad name to people's websites.

@chris-kim-agent1 @cmitchelltudor

If you got this information from somewhere else, please let me know the source.


Make new version with additional record parsing

Hello,
Could you please make a new release with the updated additional record parsing? Thank you!.

Done!

Thanks!


docker stop hangs forever on sqlserver image on LCOW

I think I opened the original issue in the wrong place: https://github.com/moby/moby/issues/39622#issue-474059608
Should I duplicate the entire text here or is the link sufficient?

I'm having the same issue.


Android - calling endAllCalls() does not finish the activity CallkitIncomingActivity

After investigation I found that the endAllCalls() method can't finish the CallkitIncomingActivity because the action used in clearIncomingNotification() is getIntentEnded(context: Context) = ${context.packageName}.${ACTION_ENDED_CALL_INCOMING},
while the broadcast receiver EndedCallkitIncomingBroadcastReceiver is registered with ACTION_ENDED_CALL_INCOMING without the ${context.packageName}.
CAN YOU CHECK PLEASE!

@maher-mobi-dev where you able to fix this?

This happens even when using endCall(uuid); method

@hiennguyen92 is there a fix for this yet?

I was able to remove the popUp notification with this:
await FlutterCallkitIncoming.endAllCalls();
Eraser.clearAllAppNotifications();

this last one is from the library Eraser: https://pub.dev/packages/eraser
And for the fullscreen intent of the incoming call screen notification I made a fork of the repo and modify some classes to add a method for finish the activity that shows the incoming call notification.

await FlutterCallkitIncoming.setCallConnected(this._currentUuid);


Port Validation issue in Inference Service v1alpha2 CRD.

/kind bug
What steps did you take and what happened:
While serving a custom model as an InferenceService, I attempted to configure a readiness probe with a longer timeout window as follows:
          readinessProbe:
            httpGet:
              path: /healthz
              port: 6000
            initialDelaySeconds: 15
            timeoutSeconds: 60
            periodSeconds: 120
            failureThreshold: 10
            successThreshold: 1

I am serving a custom model so I need to be able to configure the port correctly. The only problem is that I yield the following validation error if I add the  port:
for: "STDIN": admission webhook "inferenceservice.kfserving-webhook-server.validator" denied the request: Custom container validation error: must not set the field(s): readinessProbe.httpGet.port

and if I remove the port, I get the following error as well:
error: error validating "STDIN": error validating data: ValidationError(InferenceService.spec.default.predictor.custom.container.readinessProbe.httpGet): missing required field "port" in org.kubeflow.serving.v1alpha2.InferenceService.spec.default.predictor.custom.container.readinessProbe.httpGet; if you choose to ignore these errors, turn validation off with --validate=false

Any guidance would be greatly appreciated!
What did you expect to happen:
I expect to be able to configure a readiness probe with a custom port without a validation error.
Environment:

Istio Version: 1.9
Knative Version: 0.23
KFServing Version: 0.6
Kubeflow version: 1.3
Kubernetes version: (use kubectl version): 1.20

@aba-ca-xi Please see https://github.com/kubeflow/kfserving/issues/1350


Is this pip  package was ever working?

When I install via the pip package manager I don't get the conda yml file as it is contained in the GitHub files. So I can't start the environment. The second thing that I'm experiencing is when I run ai-dungeon-cli I get some errors from the code itself about libraries not containing things, or this is not right until I install the env in conda.
(base) C:\Users\Merlin\anaconda3\Lib\site-packages\ai_dungeon_cli>ai-dungeon-cli
Traceback (most recent call last):
  File "c:\users\merlin\anaconda3\lib\runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\users\merlin\anaconda3\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Merlin\anaconda3\Scripts\ai-dungeon-cli.exe\__main__.py", line 4, in <module>
  File "c:\users\merlin\anaconda3\lib\site-packages\ai_dungeon_cli\__init__.py", line 6, in <module>
    from gql import gql, Client, WebsocketsTransport
ImportError: cannot import name 'WebsocketsTransport' from 'gql' (c:\users\merlin\anaconda3\lib\site-packages\gql\__init__.py)

Yes, this used to work but stopped due to regular API changes, see https://github.com/Eigenbahn/ai-dungeon-cli/issues/29.
As far as I know, pypi packages don’t run under conda. So if you want to use conda you’d have to git clone the repo.
If you’ve got some programming chops, we welcome contributions on adapting to the newest API. The timing might not be ideal, though, given the ongoing war around content moderation. The API is likely to change (again) as things settle down.

So with the gql package import, it is some other problem, independent of that I'm trying to run it with conda? And it will be kind of hard to fix it myself?

So with the gql package import, it is some other problem, independent of that I'm trying to run it with conda?

Yes.
The error message you get is due to breaking changes that were made to the gql package. https://github.com/Eigenbahn/ai-dungeon-cli/commit/f3111417229db54adf8c5b913625060e7dd0b3af fixes it but we didn't publish a new release on PyPI as there are other things to fix to make it work (the idea being to not publish a non-working version).
Namely, play.aidungeon.io API changed and we need to adapt to these changes.
This the error you should be getting when running from git cloned sources (instead of pip installed).
Traceback (most recent call last):
  File "./ai_dungeon_cli/__init__.py", line 393, in <module>
    main()
  File "./ai_dungeon_cli/__init__.py", line 356, in main
    ai_dungeon.make_user_choose_config()
  File "./ai_dungeon_cli/__init__.py", line 177, in make_user_choose_config
    prompt, settings = self.api.get_options(self.api.single_player_mode_id)
  File "/home/eigen/Documents/Code/local/ai-dungeon-cli/ai_dungeon_cli/impl/api/client.py", line 124, in get_options
    prompt = result['content']['prompt']
KeyError: 'content'

And it will be kind of hard to fix it myself?

It's not that hard. It consists of running AI Dungeon in a web browser, inspect the exchanges in developper mode and reproduce the exchanges in impl/api/client.py.
This comment is an example of the process: https://github.com/Eigenbahn/ai-dungeon-cli/issues/23#issuecomment-663181475


Ubiquiti Unifi AP CPU reports 100* actual

Hi, I'm seeing my Ubiquiti APs (U7 Pros running 7.0.59 firmware) reporting CPU values that are 100 times greater than actual.  For example, for an AP I just checked in my Unifi controller showing 1.1% CPU, I see this value in an snmpwalk:
.<IP_ADDRESS>.4.1.10<IP_ADDRESS>.<IP_ADDRESS>.1 = Gauge32: 108
That then translates to 108% in New Relic.
This seems to be a common issue with Unifi with 3rd party SNMP monitoring; could this get adjusted in the unifi-access-point.yml config?

This issue is still outstanding

Can you submit a PR to fix this? This repo isn't currently maintained but we do accept outside pull requests. To fix, you'll want to do something like this example with isolon:
        # This script converts the per mil results into a proper percentage for CPU
        script: |
          def main(n):
            cpuim = n["CPU"]
            n["CPU"] = cpuim * 0.01
            return None

Note above is just an example, you'll need to test it to get it working for real.


Blur effect in Chrome 88

As you may have noticed from your own examples page, after updating Chrome browser to version 88, your carousel began to disintegrate into pixels after swiping the slides.
I checked through browserstack, everything works correctly on version 87 and in beta version 89. The bug is only 88. What should we do? Our sites are broken.

I got the same issue in v88.

I got the same issue in v88.

I get serious distortions during slide transitions in Chrome with any version after 87.  Chrome Beta 89.0.4389.23 does NOT fix the issue for me.  It reminds me of some issues about 5-6 years ago related to translate3d but obviously those particular issues were resolved.  This is disturbing since it has made in all the way to a production Chrome release.  Edge 88.0.705.56 also exhibits this problem.
I even removed any text and I can still see serious distortion/blurriness even with just an image sliding.  There is a noticeable jarring crisp to blurry shift when the slide animation starts, and then a similar blurry to crisp shift when the animation stops.
As of right now I can't even seem to get the Chromium Bugs page (https://bugs.chromium.org/p/chromium/issues/list) to load (there seems to be a known issue with Monorail), and I'm also having difficulty finding any helpful info in general web searches.
Here is a codepen of a basic test (this is just a simple JPEG): https://codepen.io/dlong500/pen/dyOydZE

Here is an animated gif of the test running under Chrome 87 with proper transitioning (Click to expand):

Here is an animated gif of the test running under Chrome 88/89 with blurry transitioning (Click to expand):

I get serious distortions during slide transitions in Chrome with any version after 87.  Chrome Beta 89.0.4389.23 does NOT fix the issue for me.  It reminds me of some issues about 5-6 years ago related to translate3d but obviously those particular issues were resolved.  This is disturbing since it has made in all the way to a production Chrome release.  Edge 88.0.705.56 also exhibits this problem.
I even removed any text and I can still see serious distortion/blurriness even with just an image sliding.  There is a noticeable jarring crisp to blurry shift when the slide animation starts, and then a similar blurry to crisp shift when the animation stops.
As of right now I can't even seem to get the Chromium Bugs page (https://bugs.chromium.org/p/chromium/issues/list) to load (there seems to be a known issue with Monorail), and I'm also having difficulty finding any helpful info in general web searches.
Here is a codepen of a basic test (this is just a simple JPEG): https://codepen.io/dlong500/pen/dyOydZE

Here is an animated gif of the test running under Chrome 87 with proper transitioning (Click to expand):

Here is an animated gif of the test running under Chrome 88/89 with blurry transitioning (Click to expand):

I get serious distortions during slide transitions in Chrome with any version after 87. Chrome Beta 89.0.4389.23 does NOT fix the issue for me. It reminds me of some issues about 5-6 years ago related to translate3d but obviously those particular issues were resolved. This is disturbing since it has made in all the way to a production Chrome release. Edge 88.0.705.56 also exhibits this problem.
I even removed any text and I can still see serious distortion/blurriness even with just an image sliding. There is a noticeable jarring crisp to blurry shift when the slide animation starts, and then a similar blurry to crisp shift when the animation stops.
As of right now I can't even seem to get the Chromium Bugs page (https://bugs.chromium.org/p/chromium/issues/list) to load (there seems to be a known issue with Monorail), and I'm also having difficulty finding any helpful info in general web searches.
Here is a codepen of a basic test (this is just a simple JPEG): https://codepen.io/dlong500/pen/dyOydZE
Here is an animated gif of the test running under Chrome 87 with proper transitioning (Click to expand):
Here is an animated gif of the test running under Chrome 88/89 with blurry transitioning (Click to expand):

@dlong500, I tested version 89 via BrowserStack. Perhaps the bug has not been fixed in a real browser. Bad.. I don't even know what to do. I don't want to rewrite the project at all.
P.S. Was closed by mistake. I missed the button.

Also getting this with my image slider on Chrome Version 88.0.4324.150 (Official Build) (64-bit). Bug not showing up on Firefox.

It seems like this Chromium bug is probably related to this.
For my use case applying in css will-change: transform to the class slick-list seems to have fixed it. I'm leaving this here in case it might help anyone else facing the same problem.

It seems like this Chromium bug is probably related to this.
For my use case applying in css will-change: transform to the class slick-track seems to have fixed it. I'm leaving this here in case it might help anyone else facing the same problem.

Yes, it works. Thank you!


Unable to use fetch API on Azure Static web apps

Environment
node:20 in azure static web apps
Reproduction
https://stackblitz.com/edit/github-p3avvp?file=server%2Froutes%2Findex.ts
Describe the bug
In this product environment of Azure, even if it is set to node:20, it still does not include the fetch api
https://github.com/nuxt/nuxt/issues/28611
Additional context
A valid Azure subscription is required to test Static web apps. This error only occurs in the cloud, not in the local simulator.
Logs
{
    "url": "/",
    "statusCode": 500,
    "statusMessage": "",
    "message": "[GET] \"https://www.baidu.com\": <no response> _fetch1 is not a function",
    "stack": ""
}

### Tasks

When using ofetch directly it works
import { $fetch } from 'ofetch';
export default defineEventHandler(async (event) => {
  return await $fetch('https://unjs.io/');
});

when using the exact example from the docs, it also works
export default defineEventHandler(async (event) => {
  const data = await $fetch('https://ungh.cc/orgs/unjs/repos');
  return data;
});

I configured preset: 'azure' and executed build. The artifacts were then deployed using swa deploy .\.output\public\ --api-location .\.output\server\ --deployment-token TOKEN --api-language "node" --api-version "20" --env production.
I think you are not using fetch correct, as your reproduction already fails in stackblitz. Please check the docs about native fetch:
https://nitro.unjs.io/guide/fetch

$fetch (same as fetch) should work in every file without any import, this seems like a bug.

$fetch (same as fetch) should work in every file without any import, this seems like a bug (but harder to reproduce, as rollup sometimes mess up with chunk orders in more complex builds)
@itpropro by your testing, if you avoid import, do you reproduce issue or not?

It could also be a fetch keyword error caused by a packaging issue, but I may have time to track this down later

$fetch (same as fetch) should work in every file without any import, this seems like a bug (but harder to reproduce, as rollup sometimes mess up with chunk orders in more complex builds)
@itpropro by your testing, if you avoid import, do you reproduce issue or not?

The second version I tested was without any imports, it works as well in Static Web Apps.

Okay, then it is most certainly a rollup chunk ordering issue.
@censujiang If can still reproduce, do you think you can share a public repository? (Nuxt setup is also acceptable in this case since it might be also needed for reproduction)
If it is not reproducible anymore I would suggest closing the issue in the meanwhile.

Okay, then it is most certainly a rollup chunk ordering issue.
@censujiang If can still reproduce, do you think you can share a public repository? (Nuxt setup is also acceptable in this case since it might be also needed for reproduction)
If it is not reproducible anymore I would suggest closing the issue in the meanwhile.

I'd like to provide a Nuxt/Nitro repository that can be used for reproduction, but I'm currently on the Chinese National Day public holiday, so it's not convenient for now. I'll talk about it after the holiday.

No hurry thanks @censujiang!

I was wondering if this was resolved by anyone? I am basically trying all options in this thread and others.
Thanks!


gnome-builder: 43.5 → 43.6

https://gitlab.gnome.org/GNOME/gnome-builder/-/compare/43.5...43.6
Description of changes
This fixes a crash when opening Preferences -> Programming Languages
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build vala-language-server


Force Channel Failed - Balance Pending

Background
I opened a channel with another node and attempted to make a payment which failed with an error stating there was no route to the target. I tried again later but had the same issue and the other node appeared to be down. I used the force close method and waited 24h for the transaction to mature. However the channel is still in a Pending state.
My logs don't go back far enough but here's the current status:
lnd successfully unlocked!
bitcoin@bitseed3:~$ lncli pendingchannels
{
"total_limbo_balance": "0",
"pending_open_channels": [
],
"pending_closing_channels": [
],
"pending_force_closing_channels": [
{
"channel": {
"remote_node_pub": "02a94aadd09055ca615bd76aacb6bba748ed8a0d2e5924aea643e3dc3912085314",
"channel_point": "1a310f6ad4daad7362782eb0423145782ffdc864d5158784ce8c943d1a3bf09e:1",
"capacity": "506475",
"local_balance": "73955",
"remote_balance": "0"
},
"closing_txid": "e8660ca0d580cff4c0c7bc75c1df3b303ab98995cc0661d3c14192e106bb107a",
"limbo_balance": "0",
"maturity_height": 0,
"blocks_til_maturity": 0,
"recovered_balance": "0",
"pending_htlcs": [
]
}
],
"waiting_close_channels": [
]
}
Your environment
0.4.1 LND
UBUNTU
Bitcoind
Steps to reproduce
Force close channel after a failed attempt at making a payment.
Expected behaviour
Channel should close and pending/limbo  balance should have been returned
Actual behaviour
Closing transaction has matured but the channel is still in a Pending state

At this point, it looks like your "to self" output has been spent. But there are still HTLC outputs that haven't been swept. Once these become mature, then these will be swept as well. Also I would recommend updating to 0.4.2 once these channels have been swept, as many bugs have been fixed in this new version.


[HOLD for payment 2024-08-05] [$250] Add Offline and Error Patterns to Remaining Integrations

With https://github.com/Expensify/App/pull/44739 we added offline and error patterns to the Sage Intacct connection menu.
One observation from discussion in Slack was that this pattern is not necessarily implemented for the other integrations (QBO, Xero, and NetSuite) and we'd like to maintain parity between all integrations menus.
Solution
Implement the same offline and error patterns implemented for Intacct in the other integrations
cc @war-in @JmillsExpensify @shawnborton @trjExpensify
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014b0b4b88631ddf1d
Upwork Job ID:<PHONE_NUMBER>565563336
Last Price Increase: 2024-07-15
Automatic offers:

ikevin127 | Reviewer | 103126194

Issue OwnerCurrent Issue Owner: @ikevin127

Hi, I'm Marcin from Software Mansion and I'd like to work on this issue!

@kabeer95 Thanks for your proposal. Unfortunately this issue was already assigned to Marcin from Software Mansion based on https://github.com/Expensify/App/issues/45406#issuecomment-2228787133. Additionally, in the future - in order for reviewers to be able to consider your proposal you need to precisely follow the proposal template when posting a proposal.

@ikevin127 okay.

Posting my update because I'll be OOO till Monday
I started working on fixing offline and error patterns in Xero integration and created a draft PR. You can check the web video in the PR description but I haven't worked on offline handling yet.
The best (and fastest) way will be splitting this work into a few PRs (one per integration). It should help with testing.

I also found and fixed some bugs (e.g. showing offline state for all export subpages when only one is updated). It will require thorough review but @hungvu193 is up-to-date (he reviewed my Sage Intacct offline and error PR) so we should be able to merge things fast 🚀

Will @hungvu193 review all PRs here or just 1 of them ? Asking to know whether I should unassign myself.

@hungvu193 What are your thoughts?

@ikevin127  Hey, this issue is not urgent so if you're interested, please go ahead Kev 😄

Not overdue, war-in is working on PRs.

Not overdue, war-in is working on PRs.

That's right! The first one (Xero) is ready for internal review :)

I'm working on the Sage Intacct integration now and there are some places where two components can modify the same onyx value. If the request fails we should somehow show the error message but should we show it only in one place or maybe both?
Example
https://github.com/user-attachments/assets/4544296b-1d04-4d20-a245-28d0bb26bbdd

(0:01): toggle sets some key
(0:03): request fails and error is there (so far so good)
(0:04): toggle sets key again and menu item is shown
(0:05): error appears in both toggle and menu item
(0:09): we clear the error and it disappears from both places

Is this behaviour correct? Or should we show this error only inside the menu item? 🤔
In my opinion, the best solution is to show an error message below the disabled toggle and not to show it when the toggle is enabled
https://github.com/user-attachments/assets/e307df42-c807-4c03-8bbb-09da3acd1dbc
cc @shawnborton

hi there, I'm from SWM and would like to help @war-in with this issue :) I will take care of QBO part 👩🏽💻

Hmm @Expensify/design @yuwenmemon  any strong feelings about the comment above? I don't have a strong opinion really.

How does one fix this error? Is it just a connection issue that'll resolve by itself?
I generally prefer one error unless there's multiple places to fix it, but also don't feel too strongly.

Is it just a connection issue that'll resolve by itself?

The error shows when the API call fails. To fix it someone will have to choose the value again

Then perhaps show it both places given one is a toggle 👍

This issue should not be closed until we handle all integrations. We finished Xero and have a PR for Sage Intacct. QBO is in development by @zfurtak and one of us will take NetSuite in the upcoming days

[x] [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

Regression Test Proposal - https://github.com/Expensify/App/pull/45493
A. Error testing

Set Simulate failing network in Troubleshooting (Ctrl / CMD + D).
Go to Settings -> Workspaces -> your Xero workspace -> Accounting.
Go through every page and try changing values.
When the requests fail, verify that  RBRs and error messages are displayed.

B. Offline testing

Go to Settings -> Workspaces -> your Xero workspace -> Accounting.
Set Force offline in Troubleshooting (Ctrl / CMD + D).
Go through every page and try changing values.
Verify that changed values / fields are displayed with 50% opacity.

Do we agree 👍 or 👎.

Hi all 👋 I'm currently working on the NetSuite integration update (offline and error patterns) and I saw that on every API call failure, we revert the state to the previous value.
That's not the case in any other integration and OldDot (checked with Xero).
I think we should update this behaviour for the NetSuite integration to align it with the others.
I can handle it here or create a separate PR (the second option is preferred because my NetSuite update PR is already big).
cc @trjExpensify

Yeah, we apply offline pattern B here right?
So if it fails, we show the in-line error message on the updated value and then when you dismiss we revert to the previous value.

Ah gotcha, I think that's the standard for pattern B across the board in App for failed add/updated values.

Ah gotcha, I think that's the standard for pattern B across the board in App for failed add/updated values.

That's clear now :) Let's use this issue to keep track of implementing this pattern correctly in all integrations.
All of them will require additional work

@trjExpensify This is what I found:

we would have to store failure data in Onyx to be able to access them while closing errors
those failure data would bring back the previous state (from before the changes)
to achieve that we need to create a new Onyx key under the policy_[someID].connections.[someConnection] with the same structure as a connection. Let's call it failureData (we could access it like that: policy_[someID].connections.[someConnection].failureData)

Let me know what you think about all this and if we want to put some effort here I'll prepare a POC (proposal) 🙏

A much easier approach is one currently used in NetSuite integration -> removing changed value and displaying an error.
But it has drawbacks too. It's not always obvious where to show the error because sometimes optimistic data adds a row and if this row disappears there is no correct place to show it.
Considering the above I think we should focus on adding failure data (maybe the right name is previous data 👀 ) to Onyx

Notes:

comment on the first PR (which requires payment today), and my BZ Checklist here
comment regarding why this issue shouldn't be closed after the first payment

cc @stephanieelliott

Hi! I'm from SWM and I would like to help @war-in with Sage Intacct part of this issue.

@289Adam289 will update the behaviour on failing network requests discussed here.
tl;dr We want to revert optimistic data on failed requests

cc @stephanieelliott 👋 Bump for the first payment which was due yesterday (see https://github.com/Expensify/App/issues/45406#issuecomment-2270057330).

cc @stephanieelliott 👋 Bump for the first payment which was due yesterday (see https://github.com/Expensify/App/issues/45406#issuecomment-2270057330).

Sorry, I think I'm confused about the payment situation -- are we paying in installments here? Generally 1 issue = $250, irrespective of the number of PRs, paid when final PR is merged +7 (which it seems like is 8/13). Standalone PRs typically get their own auto-created payment issue.
I've paid out the existing offer, but I'm not sure how to handle future payments. Left the Upwork contract open in case we need to create multiple milestones, I'll just need to know how many.

ℹ Notice that @shubham1206agra will take over the NetSuite PR https://github.com/Expensify/App/pull/46667 as they have credentials for the integration and I don't - the passing over was discussed on Slack. Please remove me from the PR as reviewer and assign them!
Also @hungvu193 took over the SageIntaact PR https://github.com/Expensify/App/pull/46294 for the same reason. This PR is already merged and payment is coming up on 13th.
@stephanieelliott Both C+ reviewers mentioned above will require payment as part of this issue.

cc @yuwenmemon @deetergp

I'm continuing with the review of the other PRs / follow-ups (QBO and Xero).

What's the difference between:

https://github.com/Expensify/App/pull/46294
and
https://github.com/Expensify/App/pull/47079

I thought we already handled that one 🤔
cc @war-in @289Adam289

Yeah, I can take that one 😄 . Hey @war-in @289Adam289, can you answer the above question?

I see, I'll review today 😄

Ok, so I want to make sure i have this right -- these are the PRs and reviewers due payment I have on this issue @hungvu193 @ikevin127 can you look this over and confirm I have the relevant PRs and correct person due payment?

Sage

https://github.com/Expensify/App/pull/44739 - reviewer @ikevin127  [PAID 8/5]
https://github.com/Expensify/App/pull/46294 - reviewer @hungvu193 [DUE 8/13]

NetSuite

https://github.com/Expensify/App/pull/46667 - reviewer @hungvu193

QBO:

https://github.com/Expensify/App/pull/46511 - reviewer @ikevin127

Xero:

https://github.com/Expensify/App/pull/45493 - @ikevin127 [UNPAID, was due 8/5]

I reviewed 2 SageIntacct PRs, but no payment needed for me, I will be paid centrally later when SageIntacct project is completed

@stephanieelliott The 2 Sage Intaact merged PRs were both reviewed by @hungvu193 which as they mentioned will not be due payment per every PR.
The Xero PR I reviewed first was already paid out to me on 8/5.

So far we're all good with payments, there will be other PRs reviewed by me as part of this issue where I'll need payment once the regression period is over.

⚠ Production deploy automation failed here -> a new payment date should be on [HOLD for Payment 2024-08-22] according to yesterday’s production deploy confirmed in https://github.com/Expensify/App/pull/46898#issuecomment-2294134343 and deploy checklist.
I will require payment as reviewer of PR:

https://github.com/Expensify/App/pull/46898

cc @stephanieelliott

cc @stephanieelliott

Summarizing payment for https://github.com/Expensify/App/pull/46898
Contributor @war-in - no payment due (agency)
C+ @ikevin127 -$250 via Upwork on this job, milestone 2 - PAID

Status check on the remaining PRs on this issue:

https://github.com/Expensify/App/pull/46667 - reviewer @ikevin127, Reviewing
https://github.com/Expensify/App/pull/46511 - reviewer @ikevin127, Reviewing

The NetSuite one was taken by @shubham1206agra as C+ reviewer since only they have the credentials required to trst NetSuite integration.
The 2nd one is correct, currently waiting kn CME for final approve and merge, hopefully soon 😁

https://github.com/Expensify/App/pull/46667 - reviewer @shubham1206agra, Reviewing
https://github.com/Expensify/App/pull/46511 - reviewer @ikevin127, Reviewing

Both on staging!

⚠ Automation failed here -> the last 2 payments should be on [HOLD for Payment 2024-09-17] according to 3 days ago production deploy from https://github.com/Expensify/App/issues/48664#issuecomment-2338463845 (both PRs are in this deploy checklist, first two).
Notes for payments

⚠ looks like the NetSuite one had a regression and the QBO one had no issues

cc @stephanieelliott

cc @stephanieelliott

All paid! Thanks


I can't find a way to contact you

Is there a method to chat? I have specific questions about some of your projects. My wechat is c-bossman. Add me please

my telegram is cutepro


Basic "Git Blame" and "Git Graph" plugin recommendations

I hope vsode can officially provide basic "Git Blame" and "Git Graph" plug-ins.

Try the extension called Gitlens for this. Some features are under pro version
Gitlens vscode extension


search results return empty for key kerberos terms

searching the docs site for key terms like kerberos, gssapi or kdc all return "no results" even though these terms are used frequently in this docs page: https://www.cockroachlabs.com/docs/v19.1/gssapi_authentication.html

ldap also returns "no results"  i think we need to include a blurb about how we support ldap if that does not already exist in the docs site.

@j-low , need your advice again here. That particular page doesn’t ever seem to show up in search results, even if you search for language in the title. Any idea why or what we might do?

@jseldess how recently was this page included in the docs?  It might be the case that we need to reach out to the DocSearch maintainer for Algolia and ask them to reindex the site.  There is nothing that jumps out at me in our config that would suggest this page being ignored by the indexer (i.e. the selectors on the GSSAPI page are the same as other pages and therefore should be indexed).

is it possible to have the site automatically re-indexed on a schedule like nightly?

@timveil Daily recrawling happens but per the issue I filed it apparently was broken recently and is now fixed.  I was advised by the maintainer to alert them if results are still empty in another day or so.

Thanks for helping with this, @j-low. I'll check again in the morning and close if the page is indexed properly.

Sounds great.  Let me know if there are still issues and I will follow up.

Filed #5138 to track the update to the GSSAPI page to mention LDAP.

@j-low, that page has been around for quite some time, so I don't know why it wasn't indexed.

this looks resolved.   curious about the solution and the root cause.

@timveil, quick explanation: We currently use algolia's free docs search, which is a great offering for open source docs but is somewhat limited in our control of the search experience. We maintain a config that they use to determine how to index our docs, but they drive the actually indexing, which is suppose to happen daily. In this case, their daily crawler was broken.
In the near future, we're planning to upgrade our subscription to be able to better control our destiny. @lhirata gave a 5-min presentation on this at a recent team meeting and can point you to more info if you like.


Can I use O365 GCC or O365 GCC High AAD to integrate with my custom apps or 3rd party apps (saas)?

It's clear that one can use the AAD that comes with every O365 subscription for Authentication with 1st party custom app or 3rd party SaaS. Would that be the case also for O365 GCC or O365 GCC high subscription? Can I use the AAD behind O365 GCC or GCC high to synchronize my on-premise AD DS? And use it to authenticate/authorize the Custom Web App hosted in App Service plan? Otherwise what is the difference w.r.t O365 AAD apart from the fact that O365 GCC or O365 GCC high is hosted in Azure Gov cloud O365 AAD is in public (global) cloud?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bf4bfe19-070d-9ceb-d88c-e60d72f362c1
Version Independent ID: 69af3732-0341-a054-6f4b-43407640a94b
Content: Integrated Apps and Azure AD for Microsoft 365 administrators
Content Source: Enterprise/integrated-apps-and-azure-ads.md
Service: o365-administration
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

Yes. Based on the article here.


Custom DB Full CRUD operations

Adding onto an inverted index is easy, but updating or deleting is considerably more complicated:

On delete we need to know where the item was previously indexed, then delete those pointers
On update we need to know where the item was previously indexed, where it should be indexed in the future, calculate the deltas and remove/add accordingly


reinit in case of already expired ticket

reinit Ticket in case if it is already expired

Thank you for the PR. I found a few problems in my original code related to this issue. Let me fix them...

Fixed a wrong condition for reinit, and unclear code by #35


Only Libvirt - Version : 4.5.0 and Terraform - v0.11.10 supported network mode bridge

System Information
Linux distribution
Ubuntu.2204.
Terraform version
terraform -v >v0.11.10

Provider and libvirt versions > 4.5.0
terraform-provider-libvirt -version > 4.5.0

If that gives you "was not built correctly", get the Git commit hash from your local provider repository:
git describe --always --abbrev=40 --dirty

Checklist

[ ] Is your issue/contribution related with enabling some setting/option exposed by libvirt that the plugin does not yet support, or requires changing/extending the provider terraform schema?

[ ] Make sure you explain why this option is important to you, why it should be important to everyone. Describe your use-case with detail and provide examples where possible.
[ ] If it is a very special case, consider using the XSLT support in the provider to tweak the definition instead of opening an issue
[ ] Maintainers do not have expertise in every libvirt setting, so please, describe the feature and how it is used. Link to the appropriate documentation

[ ] Is it a bug or something that does not work as expected? Please make sure you fill the version information below:

Description of Issue/Question
Why only Libvirt - Version : 4.5.0 and Terraform - v0.11.10 supported network mode bridge ?
Setup
(Please provide the full main.tf file for reproducing the issue (Be sure to remove sensitive information)
Steps to Reproduce Issue
(Include debug logs if possible and relevant).

Additional information:
Do you have SELinux or Apparmor/Firewall enabled? Some special configuration?
No special configuration, no SELinux and Apparmor is disabled
Have you tried to reproduce the issue without them enabled?

I am using tf v1.3.6 and terraform-provider-libvirt v0.7.0 (and libvirtd 6.0.0 on the server side) and had no trouble creating a direct bridge-mode network interface in a libvirt_domain, nor a bridge-mode libvirt_network resource.

Ok, you can creating a direct bridge-mode but you can't set  a lan adress ip .

I am using tf v1.3.6 and terraform-provider-libvirt v0.7.0 (and libvirtd 6.0.0 on the server side) and had no trouble creating a direct bridge-mode network interface in a libvirt_domain, nor a bridge-mode libvirt_network resource.
Hi @jtackaberry
Can you please share your setting using bridge mode and network interface?
My goal is to assign a static IP address to a new VM using bridge mode.
I'm using these setting:

``
resource "libvirt_network" "vm_public_network" {
name = "${var.VM_HOSTNAME}_network"
#mode = "nat"
mode = "bridge"
bridge = "br_v12"
#domain = "${var.VM_HOSTNAME}.local"
addresses = ["${var.VM_CIDR_RANGE}"]
dhcp {
enabled = false
}
dns {
enabled = true
}
}
resource "libvirt_domain" "vm" {
count = var.VM_COUNT
name = "${var.VM_HOSTNAME}-${count.index}"
memory = var.VMEM
vcpu = var.VCPU
cloudinit = "${libvirt_cloudinit_disk.cloudinit.id}"
qemu_agent = true
network_interface {
network_id = "${libvirt_network.vm_public_network.id}"
network_name = "${libvirt_network.vm_public_network.name}"
addresses      = ["${var.IP_MAIN}"]
}
console {
type      = "pty"
target_port = "0"
target_type = "serial"
}
disk {
volume_id = "${libvirt_volume.vm[count.index].id}"
}
graphics {
type      = "spice"
listen_type = "address"
autoport   = true
}
}
cat network_config.cfg
version: 2
ethernets:
eth0:
dhcp4: true
``
The result is that the VM is created but I can't ping to its IP.
When using "nat" mode, it is working fine, but the host is the only one that can reach (ping/ssh) to the new VM. that is why I would like to use bridge mode.
Thanks,
Lavi

Hi @scabala
My issue above was fixed long ago, thanks for your comment anyway.
Lavi

Great to hear it.


ERROR: status is REQUEST_DENIED. You must use an API key to authenticate each request to Google Maps Platform APIs.

Error: Status is REQUEST_DENIED. You must use an API key to authenticate each request to Google Maps Platform APIs. For additional information, please refer to http://g.co/dev/maps-no-account
at /home/api/node_modules/node-geocoder/lib/geocoder/googlegeocoder.js:89:25

I have same issue.

Are you using an API key?

I was using just your api

in my issue, i was use mapquest provider.

[SOLVED] I'm sorry, my env config not load. so the api key not work. @nchaulet thank you for your attention.

Are you using an API key?

yes, I am using mapquest


Error Running App Locally

Please provide us with the following information:

This issue is for a: (mark with an x)
- [x ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

When starting the app locally via the start.cmd in the app folder, the website does start up but its just a blank white page with. The error message is in the console window.

Any log messages given by the failure

Failed to load module script: Expected a JavaScript module script but the server responded with a MIME type of "text/plain". Strict MIME type checking is enforced for module scripts per HTML spec.

Followed By
SyntaxError: Unexpected end of JSON input
at JSON.parse ()
at window.onload (app.js:59:731)

Expected/desired behavior

The start.cmd should fire the website up without issue.

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

Versions

Windows 10

Mention any other details that might be useful
Using VS Code

Thanks! We'll be in touch soon.

So apparently this app is running a python server using the Flask framework. On windows machines Flask looks at the registry to get its mime type for javascript files. Windows by default in the registry treats javascript as text/plain. So to fix this issue just drop in this code in the app.py file
fix windows registry stuff
import mimetypes
mimetypes.add_type('application/javascript', '.js')
mimetypes.add_type('text/css', '.css')

I added :
mimetypes.add_type('application/javascript', '.js')
mimetypes.add_type('text/css', '.css')
but still return the question


empty folders show 'empty' in lil.gut but nothing in dat.gui

I'm guessing this is intentional but just FYI, it kind of breaks things. In dat.gui you could use an empty folder as a label/separator since it wouldn't show anything but itself. With lil.gui, since it shows "empty", those usages kind of break or a least don't look nice
https://jsgist.org/?src=32828379140004c21e3bbc698b360474

Yea, I wanted to alleviate confusion for this very use case: since lil-gui doesn't indent first level folders, without the "Empty" line, those values would look like they belonged to the folder. I think the real "breaking" change here is that folders are open by default.
You've got me thinking there needs to be like a dat.gui => lil-gui polyfill 😅


Adds delete sub-command to the CLI

Changes proposed in this PR

adding the delete sub-command
adding associated tests

Why are we making these changes?
To allow token deletion via the CLI.
Demo

Merging as the failure looks like a flaky test.


[RFC] [ci] Enforce flake8 on Python code

Created based on this conversation with @jmoralez : https://github.com/microsoft/LightGBM/pull/5559#pullrequestreview-1162264926.

Proposal
LightGBM should use flake8 in CI.
Motivation
flake8 is a static analyzer for Python that I've found very useful in catching efficiency and correctness issues like:

unused imports
unused variables
unnecessary use of f-strings
repeating dictionary keys (which silently ignores all but the last one)

And many more! ([full list of error codes])
flake8 by default has 4 types of checks:

style (via pycodestyle)
efficiency and correctness (via pyflakes)
efficiency and correctness (via its own checks)
code complexity (via mccabe)

It also has a rich ecosystem of optional plugins (see e.g. https://github.com/DmytroLitvinov/awesome-flake8-extensions).
LightGBM already enforces pycodestyle
https://github.com/microsoft/LightGBM/blob/0c0eb2a6a1ba111f0896dd16a579342fa16f7629/.ci/test.sh#L80
So integrating this wouldn't change any of LightGBM's expectations for code style.
We've also had several instances over the last few years where flake8 was use to catch issues. Enforcing it in CI could have prevented those issues from being introduced at all:

#3023
#4233
#4850
#5559

flake8 can also be adopted gradually, via:

ignoring specific lines with #noqa commments
ignoring specific checks with --ignore command-line flag

Description
If this is accepted, the work would look like:

[ ] address all flake8 warnings on master
[ ] replace pycodestyle with flake8 in the lint CI task
[ ] (maybe) put flake8 configuration for --ignore and --exclude in a file, instead of in CI scripts, for easier local development (docs for reference)

References
As of https://github.com/microsoft/LightGBM/commit/0c0eb2a6a1ba111f0896dd16a579342fa16f7629 and the latest version of flake8 (v4.0.1), the following
flake8 \
    --ignore=E501,W503 \
    --exclude=./.nuget,./external_libs,./python-package/build/,./python-package/compile \
    .

Returns the following.
./tests/python_package_test/test_callback.py:6:1: F401 '.utils.pickle_obj' imported but unused
./tests/python_package_test/test_callback.py:6:1: F401 '.utils.unpickle_obj' imported but unused
./tests/python_package_test/test_dask.py:1720:29: F841 local variable 'client' is assigned to but never used
./tests/python_package_test/test_dask.py:1799:29: F841 local variable 'client' is assigned to but never used
./tests/python_package_test/test_sklearn.py:446:5: F841 local variable 'gbm_clone' is assigned to but never used
./python-package/setup.py:99:5: F841 local variable 'err' is assigned to but never used
./python-package/lightgbm/compat.py:39:5: F401 'matplotlib' imported but unused
./python-package/lightgbm/compat.py:46:5: F401 'graphviz' imported but unused
./python-package/lightgbm/dask.py:20:1: F401 '.basic._safe_call' imported but unused
./python-package/lightgbm/dask.py:24:1: F401 '.sklearn._LGBM_ScikitCustomEvalFunction' imported but unused
./python-package/lightgbm/sklearn.py:6:1: F401 'typing.Iterable' imported but unused
./docs/conf.py:108:5: F401 'sklearn' imported but unused

Request for Comment
@jmoralez @StrikerRUS will you please comment on this proposal when you have time?
I think LightGBM would benefit from adopting more static analyzers, and that flake8 is a powerful and easy one to add next.

I agree with this, as you pointed out it's been several times where we miss unused imports in reviews that would've been caught by it. Unused variables is also a good catch because sometimes they're just typos and are easy to miss in reviews if they manage to get past the tests.


Discrepancies between gcc compiler and clang parser

The default compiler in juCi++ is gcc/g++ (for some reason), while the parser uses clang. Clang and GCC have different levels of standards compliance which can very rarely lead to problems, for example this:
#include <iostream>

int main() {
  std::string 〄 = "Hello, World!";
  std::cout << 〄 << std::endl;
}

Is completely valid in clang, it compiles, outputting Hello, World!
gcc on the other hand does not compile and throws these errors:

Compiling and running /home/***/prog/emoji_variables/build/emoji_variables
[ 50%] Building CXX object CMakeFiles/emoji_variables.dir/main.cpp.o
/home/***/prog/emoji_variables/main.cpp:4:15: error: stray ‘\343’ in program
std::string 〄 = "Hello, World!";
                 ^
/home/***/prog/emoji_variables/main.cpp:4:16: error: stray ‘\200’ in program
std::string 〄 = "Hello, World!";
                   ^
/home/***/prog/emoji_variables/main.cpp:4:17: error: stray ‘\204’ in program
std::string 〄 = "Hello, World!";
                     ^
/home/***/prog/emoji_variables/main.cpp:5:16: error: stray ‘\343’ in program
std::cout << 〄 << std::endl;
                    ^
/home/***/prog/emoji_variables/main.cpp:5:17: error: stray ‘\200’ in program
std::cout << 〄 << std::endl;
                      ^
/home/***/prog/emoji_variables/main.cpp:5:18: error: stray ‘\204’ in program
std::cout << 〄 << std::endl;
                        ^
/home/***/prog/emoji_variables/main.cpp: In function ‘int main()’:
/home/***/prog/emoji_variables/main.cpp:4:19: error: expected unqualified-id before ‘=’ token
std::string 〄 = "Hello, World!";
                 ^
/home/***/prog/emoji_variables/main.cpp:5:20: error: expected primary-expression before ‘<<’ token
std::cout << 〄 << std::endl;
                         ^~
make[2]: *** [CMakeFiles/emoji_variables.dir/build.make:63: CMakeFiles/emoji_variables.dir/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:68: CMakeFiles/emoji_variables.dir/all] Error 2
make: *** [Makefile:84: all] Error 2

The problem here is that the code looks completely valid in the IDE, there are no error markers, etc.
Proposed fix: Give the user an option to set the preferred compiler from within the IDE and then generate this in the CMakeLists.txt
SET(CMAKE_CXX_COMPILER g++) or SET(CMAKE_CXX_COMPILER clang++) for example, depending on the user settings.

This is as it should be as prepackaged libraries on Linux are mostly compiled with g++, so the default compiler is used to avoid ABI incompatibilities. Additionally, parsing with libclang and compiling with g++ gives the warning and error capabilities of two compilers.
One can change the default compiler in preferences (cmake_command) if one wishes, and one can even create the build directories manually in case a project should have some specific cmake options added.

Alright then, I'll close the issue. :)


Can we make SoftBreakAddsNewLinePlugin optional?

I understand the use case for SoftBreakAddsNewLinePlugin.
I also read this issue: https://github.com/jeziellago/compose-markdown/issues/43
And I know your code: https://github.com/jeziellago/compose-markdown/blob/a3896eb128f529ed464bb51cd956a717abe85225/markdowntext/src/main/java/dev/jeziellago/compose/markdowntext/MarkdownRender.kt#L31
Sure, there are use cases where it makes sense to have this plugin. But I don't think it should be the default since it is not in line with Markdown standards.
In any case I think this should be configurable.
Any chance to do so?
PS: Apart from that, great library. Maybe at some point with better support for Fonts and LocalContentColor. ;-)

Thank you! Works as expected.


Cannot ask questions on StackOverFlow

Very basic issue, default issue system suggests we ask questions on stackoverflow using the tag 'dvajs', unfortunately, this cannot be done as this tag doesn't exist, and cannot be created unless we have at least 15k points on SO.
If anyone has 15k points +, can he create the tag ? I've got a lot of questions about DVA, but cannot ask them the way you want.

https://stackoverflow.com/questions/tagged/dvajs


need upgrade to {N} V4 ?

Hi, I'm trying to use this plugin in my app that use {N} v4, but it does not work with me.
When I'm trying to connect to the server I got this error:

CONSOLE LOG file:///app/tns_modules/nativescript-socket.io/socketio.common.js:55:22: nativescript-socket.io on error ["Transport unknown"]

I don't know the reason but I suspect the reason from the version.
Any help please ?

Hi @OPADA-Eng,
I have this plugin functional with NativeScript v4 on production with latest Socket.IO on server.
Is the provided log part of crash error? in that case please provide stack-trace and server version of Socket.IO.

Hi @naderio  Thank you for support.
I have reconfigured the server and discovered that the problem from the server.
now it's working fine!


task/153/new-play-button

asdf

Codecov Report

Merging #185 (9d0c0b7) into main (8b6ac12) will increase coverage by 0.07%.
The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   76.36%   76.43%   +0.07%
==========================================
  Files          79       80       +1
  Lines        2204     2211       +7
  Branches      351      348       -3
==========================================
+ Hits         1683     1690       +7
  Misses        520      520
  Partials        1        1

Files
Coverage Δ

client/src/components/PlayButtonSvg.tsx
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


⚠ Bofrost.at has degraded performance

In 80442b6, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1006 ms

Resolved: Bofrost.at performance has improved in ba0c712 after 6 minutes.


fix:fix globalWatcher is nil,when source is enable

Proposed Changes:

When there is only one source and it is enabled, globalWatcher is nil. If the helper interface is requested later, core will occur.

Which issue(s) this PR fixes:

pipelines:
  - name: local
    sources:
      - type: file
        enabled: false
        name: demo
        paths:
          - /home/zhanglei/*.log
        fields:
          "@topic": "loggie"
    interceptors:
      - type: normalize
        name: global
        processors:
          - addMeta: ~
          - add:
              fields:
                "metadata.module": "loggie"
                "metadata.type": ""
                "metadata.version": 1.444
          - rename:
              convert:
                - from: "meta.systemState.collectTime"
                  to: "colleciton.@collectiontime"
                - from: "body"
                  to: "collection.@message"
                - from: "meta.systemState.filename"
                  to: "collection.@path"
                - from: "meta.systemState.lineNumber"
                  to: "collection.@rownumber"
          - drop:
              targets: ["meta"]

    sink:
      #      type: dev
      #      printEvents: true
      #      codec:
      #        pretty: true
      type: router
      hosts:
        - "<IP_ADDRESS>:7070"
      max_client: 1

Fixes #
if globalWatcher == nil {
		return watcherMetrics
}

Additional documentation:

fix globalWatcher is nil


[manila-csi-plugin] Replaced ChooseExportLocation with FindExportLocation

What this PR does / why we need it:
This PR replaces ChooseExportLocation with FindExportLocation and adds a unit test for this function.
FindExportLocation retains the behavior of its predecessor, but adds the ability to further constrain the result by using a filter function that's supplied to FindExportLocation as an argument.
We'll need this for the NFS share adapter (at least), where we'll need to filter out unsuitable export locations (e.g. those that are not from a certain subnet).
xref https://github.com/kubernetes/cloud-provider-openstack/issues/1136
Release note:

NONE

PTAL @tsmetana @tombarron @gouthampacha @ramineni

FYI @JPRbrs there will be one or (at most) two more PRs till we get a fix for https://github.com/kubernetes/cloud-provider-openstack/issues/1136 in

Thanks Robert!
On Thu, 13 Aug 2020, 22:53 Róbert Vašek<EMAIL_ADDRESS>wrote:

FYI @JPRbrs https://github.com/JPRbrs there will be one or (at most)
two more PRs till we get a fix for #1136
https://github.com/kubernetes/cloud-provider-openstack/issues/1136 in
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/cloud-provider-openstack/pull/1157#issuecomment-673704760,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEBZZ7Y22AVHYQA3YRUGKNDSARHETANCNFSM4P6Y5ZSA
.

/lgtm
/assign gouthampacha

/approve

@ramineni this is in preparation for an upcoming PR that will fix the issue

@ramineni I see gouthampacha's "approve" didn't trigger merge, even though he is an approver for pkg/csi/manila, and this PR already had a LGTM label at that time. Any idea why this might be?

@gman0 This PR is merged.


UI: There is not anymore the Plagiarism button in the Course management view neither in the course view.

Describe the bug
There is not anymore the Plagiarism button in the Course management view neither in the course view.
To Reproduce
First verification

Go to Course management
Check there is no plagiarism button there

Second verification
3. Open a course and verify there is no plagiarism button there
Expected behavior
should be the button in both sites
Screenshots
Course management view:

Course view:

Which version of Artemis are you seeing the problem on?
6.1.0
What browsers are you seeing the problem on?
Chrome
Additional context
No response
Relevant log output
No response

Click on the dropdown arrow or go to the assessment dashboard. 😉