cannot find module error

When I use composer-concerto into another package  and then I use this new package into an application it throws this error:
Error: Cannot find module 'doctrine'
Context
doctrine and acorn are required by the application but have been moved in devDependencies
Expected Behavior
no errors
Actual Behavior
this error:
Error: Cannot find module 'doctrine'
Possible Fix
move doctrine and acorn to dependencies
Steps to Reproduce

use composer-concerto in a module
import the module into an application
run the application

Context
import composer-concerto in another package
Your Environment

Version used: 0.71.3
Environment name and version (e.g. Chrome 39, node.js 5.4): node.js v11.10.1
Operating System and version (desktop or mobile): Fedora Linux
Link to your project:

It think this is a dependency issue. I believe doctrine and acorn should be in the dependencies category rather than the devDependencies part of the package.json.

For some reason there has been a bit of ping pong on those:
https://github.com/hyperledger/composer-concerto/commit/67b7150bcee9c8c1e1c5f4005ab019c425810fa1#diff-b9cfc7f2cdf78a7f4b91a753d10865a2
https://github.com/hyperledger/composer-concerto/commit/533b80f1e28be57de7a2806ee827ecab58a98536
And a PR to put those back to dependencies is at #44

thank you


customize output

I have few things in my mind, customization for output.

custom output folder names

instead of 0, 1, 2, can be do like "Batch 1, Batch 2, Batch 3"

custom output directory where the split happens

for example, I want to specify the path where the folders show up.

Just some ideas, I can do all of this manually with FS in node.js maybe useful as an upgrade in the future.
Adding your project to my projects, will wait for updates.

Added both features on version 2.2.0 and pushed to npm
const fstd = new FileSplitToDirectory();
fstd.directoryNameGenerator = (i: number) => i.toString();
fstd.runSync('D:/download', 100, 'E:/processed');

Added both features on version 2.2.0 and pushed to npm
const fstd = new FileSplitToDirectory();
fstd.directoryNameGenerator = (i: number) => i.toString();
fstd.runSync('D:/download', 100, 'E:/processed');

That was quick! How do you use the other one? For example "Batch 1"
fstd.directoryNameGenerator = (i: number) => i.toString();

// i=0, i=1, i=2, i=...
// Batch 1, Batch 2, Batch 3, ...
fstd.directoryNameGenerator = (i) => Batch ${i + 1};

// i=0, i=1, i=2, i=...
// Batch 1, Batch 2, Batch 3, ...
fstd.directoryNameGenerator = (i) => `Batch ${i + 1}`;

Updating the latest version, checking this.

Works like a charm, I noticed that it does move the files to the output folder. Maybe good to have an option for moving or copying the files. Instead of moving only. All good! Thanks for the quick updates!


Windows client is not starting

Hi,
just tried to get you Windows client up and running, but unforntunately, it won't start here on Windows 7.
The error code is (roughly translated) "The application couldn't be started correctly (0xc000007b)  \n Click on "OK" to close the application"
I tried various compatbility settings, but nothing worked. Any ideas?
Regards,
Jan
PS: Windows7 Enterprise (64Bit)

Installed on a second computer (notebook). Doesn't work either, but different error message though.
Freely translated from German:
"MSVCR100.dll is either not meant for execution under windows or is faulty. Reinstall form the original media or ask a system administrator or software manufacturer for assistance."
The later I do right now ;-)
Anyone managed to run it on Windows 7?
Regards,
Jan
Window7 enterprise (32Bit)

I'm actually running it right now on Win7, seamlessly...

mmmh.... nothing here... two entirely different PCs both on Windows 7 (one 32bit other 64 bit) and the above mentioned (slightly) different error messages...
Are any prerequsited known? VCR-libaries (apart from the two supplied?) anything special installed?
Regards,
Jan

I fixed both problems this way : ("The application couldn't be started correctly (0xc000007b)..." and "MSVCR100.dll is either not meant for execution under windows or is faulty...")

Delete (or rename) msvcr100.dll from the bbox install directory.
Install Microsoft Visual C++ 2010 SP1 Redistributable Package (x86) :
http://www.microsoft.com/download/en/details.aspx?id=8328

(I tried with the x64 version because I'm running Win7 x64 but it's only working with the x86 package)
Hope this will help!
Mike

tried on WinXP x32, dont started, say that something wrong with msvcrt100.dll. I download it from microsoft, replace and then it start work. Anso on russian it show wrong logs and other in wrong codepage. for win it cp1251, not 866

can you send me the file.. or a link to the mscvcrt100.dll? Or can someone explain to me why it's so complex to release stuff for windows? :)


build: remove sync-repo-settings file in order to remove summary checks

@bcoe, I think we'll need administrator access to merge this


fix: return correct types from model factories

[ ] Added or updated tests
[ ] Documented user facing changes
[ ] Updated CHANGELOG.md

Changes

Breaking changes

Thank you. But I'll open it when I think it's ready.


[bash-completion] Fix endless loop when completion.bash sourced twice

I forgot to add the "not _fzf" check into __fzf_orig_completion, so
invoking it twice would rewrite the _fzf_orig_completion_xxx variables
and then cause an endless loop when completion is requested.
Fixes: https://github.com/junegunn/fzf/pull/2246
Reported-by: @wingpin6

Thanks for the quick fix!


Added TabBar.splashFactory, TabBarTheme.splashFactory,overlayColor

Adds a splashFactory property to TabBar and adds splashFactory and overlayColor properties to TabBarTheme.
This enables defeating ink splashes by specifying splashFactory: NoSplash.splashFactory. The overlay color can be now be overridden for the pressed state, as well as the hovered and focused states (as before).  For example, to create a TabBar that does not draw ink splashes, and only draws the default focused state highlight:
TabBar(
  splashFactory: NoSplash.splashFactory,
  overlayColor: MaterialStateProperty.resolveWith<Color?>(
    (Set<MaterialState> states) {
      // Use the default focused overlay color
      return states.contains(MaterialState.focused) ? null : Colors.transparent;
    }
  ),
  ...
)

Fixes #86661

This PR failed a couple of internal tests that had configured InkWell.overlayColor with a MaterialStateProperty<Color> whose resolution depended on MaterialState.pressed. Previously this distinction was ignored and now it isn't. This caused a few golden image tests for widgets in the pressed state to fail.

@HansMuller When I originally brought up the issue I thought I exhausted all options but it seems setting the highlightColor to transparent in the nearest Theme ancestor works. This begs the question of if we should have a wrapper Theme be the way to disable the splash via splashColor and highlightColor or should we have the splashFactory and overlayColor constructor params? I've seen both done for styling and configuration settings in other places


[Serverless] Fix tagging in Azure Function App traces

What does this PR do?
When in an Azure App Service environment, the trace-agent will now check if the app is an Azure Function and add the appropriate tags. This was previously done by the .NET tracer but we overlooked it when moving tagging to the trace-agent.

Motivation

This has led to misconfigured function apps, missing tags and issues with how the apps are displayed in the UI
https://datadoghq.atlassian.net/browse/SLES-1417
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[x] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[x] A release note has been added or the changelog/no-changelog label has been applied.
[x] Changed code has automated tests for its functionality.
[x] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[x] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[x] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[x] If applicable, the need-change/operator and need-change/helm labels have been applied.
[x] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[x] If applicable, the config template has been updated.

Added the QA tag but could not rerun the circleci test


Add mode to RelationalBone where dest should hold a SkeletonInstance with the full Skeleton instead of a RefSkel

So ignore refKeys and act as mix of a KeyBone and RelationalBone

relates to #1101

also relates to #905


Questions & Suggestions

Hi @caiogondim!
Great work on this! I also appreciate the very thorough blog post. It was incredibly enlightening. After reading it, in fact, I wanted to try to implement something on my own and compare against your benchmarks. After including my own memoization method (Mark's memoized) and running the benchmark script, I got these results:

I have a couple of questions regarding the above:

Did I incorporate my method properly into the benchmark tests?
If so, does my method forget important edge cases that you are accounting for?

Thanks for your time, code, and awesome blog post!

That's amazing.
You're missing only to check if the value is primitive or not.
In your case, if a non-primitive value is passed, it will be coerced to string will not work as key of the cache.

I'm using this function:
function isPrimitive (value) {
  return value == null || (typeof value !== 'function' && typeof value !== 'object')
}

@caiogondim Thanks! I really appreciate your help. I will attempt to integrate something similar and let you know what I find.

Here to help 😄
Let me know when you're comfortable on merging your PR.

@caiogondim I ended up integrating the primitive check into the method. I checked the method against the relevant tests within index.text.js and these are the results I got.

Let me know what you think. Am I missing anything else? Thanks!

I would love to merge your lib in the fast-memoize.js
You interested on it?
In case you're, we need to pass a custom cache and serializer.
And that's it 🎉

In other words, I would like to use your code and make the tests pass without modification.
This way we don't need to release a major version.

@caiogondim Sounds perfect! Let's do it! How would you like to proceed from here?

@caiogondim Does your library currently pass tests if you pass an object literal {} as the custom cache?

It does not.
It needs a facade with:

has
get
set
delete

Like documented here: https://github.com/caiogondim/fast-memoize.js#custom-cache

Got it. Is there any reason why we would need to include delete or has for that matter? I only ask because when I run benchmark tests this:
class Cache {
  constructor () { this.cache = Object.create(null) }
  has (key) { return (key in this.cache) }
  get (key) { return this.cache[key] }
  set (key, value) { this.cache[key] = value; return value }
  delete (key) { delete this.cache[key] }
}

function memoize(fn, options) {

  const {
    cache,
    serializer,
    monadic
  } = Object.assign({}, {
    cache: new Cache(),
    serializer: JSON.stringify,
    monadic: fn.length === 1
  }, options)

  function isPrimitive(value) { return value == null || (typeof value !== 'function' && typeof value !== 'object') }

  return function memoized(first, ...args) {
    const key = monadic && isPrimitive(first) ? first : serializer([first, ...args])
    const value = cache.get(key)
    if (value) { return value }
    return cache.set(key, fn(first, ...args))
  }
}

module.exports = memoize

is much faster than this:
class Cache {
  constructor () { this.cache = Object.create(null) }
  get (key) { return this.cache[key] }
  set (key, value) { this.cache[key] = value }
}

function memoize(fn, options) {

  const {
    cache,
    serializer,
    monadic
  } = Object.assign({}, {
    cache: new Cache(),
    serializer: JSON.stringify,
    monadic: fn.length === 1
  }, options)

  function isPrimitive(value) { return value == null || (typeof value !== 'function' && typeof value !== 'object') }

  return function memoized(first, ...args) {
    const key = monadic && isPrimitive(first) ? first : serializer([first, ...args])
    if (cache.has(key)) { return cache.get(key) }
    const value =  fn(first, ...args)
    cache.set(key, value)
    return value
  }
}

module.exports = memoize

Under what circumstances would the user need has and delete do you think? Also, I have the set returning the value, which isn't necessary - it was just easier if I wanted it all in one line similar to return cache[key] = fn(first, ...args).

Sorry for the delay.
Can you reopen the PR so we discuss about it?


When uploading test results using the AppVeyor.UploadTestResults method, no test results appear in the appveyor build, but there is no error produced.
After some debugging, it appears the appveyor api is returning 415 Unsupported Media Type
What is Expected?
The tests should upload correctly, or some sort of error should be produced
What version of Cake are you using?
<IP_ADDRESS>
Are you running on a 32 or 64 bit system?
x64
What environment are you running on?  Windows? Linux? Mac?
Windows
Are you running on a CI Server?  If so, which one?
AppVeyor
How Did You Get This To Happen? (Steps to Reproduce)
Cake build with NUnit tests, then upload to AppVeyor
Task("Run-Tests")
    .IsDependentOn("Build")
    .Does(() =>
{
    NUnit(testAssemblies);

    if(AppVeyor.IsRunningOnAppVeyor)
    {
        AppVeyor.UploadTestResults(testOutput, AppVeyorTestResultsType.NUnit);
    }
});

Output Log
There is no output produced on failure
Possible Resolution
The appveyor example for this uses powershell: https://www.appveyor.com/docs/running-tests#uploading-xml-test-results
I have tried adding content-type, changing to multipart content upload and a few other changes, but nothing worked.
However, the powershell example uses System.Net.WebClient rather than System.Net.Http.HttpClient.  Changing to this worked for me.  I can submit a pull request with this change, but wondered if there were any other factors that I hadn't considered?

In addition to the fix, would it be possible to report the error here?
I've hit a 'silent failure' here also - at the time I had bigger problems so didn't investigate further. Would be great if the failure could be logged though!

@ChrisMaddock said...
In addition to the fix, would it be possible to report the error here?
I've hit a 'silent failure' here also - at the time I had bigger problems so didn't investigate further. Would be great if the failure could be logged though!

I think we need to tackle this as a separate issue.

@ChrisMaddock new issue created here: https://github.com/cake-build/cake/issues/1112

Thanks @gep13 :-)
Appveyor.exe doesn't appear to be used for uploading test results however - these just go through a web request, which I thought might be easier to handle. Is this still covered by #1112?
Thanks for spotting it when closing the issue, regardless!

Hmmm, yes and no, I think your particular requirement is already going to be met.  This was added:
https://github.com/cake-build/cake/pull/1099/files#diff-5ea055597d8263244198033de799294dR82
Which as documented here:
https://msdn.microsoft.com/en-us/library/system.net.http.httpresponsemessage.ensuresuccessstatuscode(v=vs.118).aspx
Will throw an exception, if not a successful operation.  The other AppVeyor methods will get similar treatment as a result of #1112

Aha - great! Don't think that was in the first version of the PR I looked at. Thanks @gep13, and @Philo!


Test 'Action fails because of a bad hostname.' fails on Android in WIFI mode

https://gist.github.com/evabishchevich/9cff989bf1a69284ea8167901808604e

https://gist.github.com/evabishchevich/af73830958713dbe598255b43261992e
branch : vNext_yarong_417_812_848, commit 082d05c
mode: WIFI
Merged after Artem's fix on thaliproject/Thali_CordovaPlugin#1167

@evabishchevich It should be fixed in #1180
Please, try vNext_yarong_417_812_chapko_1059 branch


Strategy does not implement Sync

I'm not sure if there is a technical reason this is not possible, but I thought I would check.
I would like to create the regex strategy using lazy_static! but Strategies don't implement Sync.
Thanks!
error[E0277]: the trait bound `proptest::strategy::Strategy<Value=std::boxed::Box<proptest::strategy::ValueTree<Value=std::string::String> + 'static>> + 'static: std::marker::Sync` is not satisfied
  --> src/test_name.rs:38:1
   |
38 | / lazy_static!{
39 | |     static ref GEN_NAME_PROP: prop::string::RegexGeneratorStrategy<String> =
40 | |         prop::string::string_regex(GEN_NAME_RE).unwrap();
41 | | }
   | |_^ `proptest::strategy::Strategy<Value=std::boxed::Box<proptest::strategy::ValueTree<Value=std::string::String> + 'static>> + 'static` cannot be shared between threads safely
   |
   = help: the trait `std::marker::Sync` is not implemented for `proptest::strategy::Strategy<Value=std::boxed::Box<proptest::strategy::ValueTree<Value=std::string::String> + 'static>> + 'static`
   = note: required because of the requirements on the impl of `std::marker::Sync` for `std::ptr::Unique<proptest::strategy::Strategy<Value=std::boxed::Box<proptest::strategy::ValueTree<Value=std::string::String
> + 'static>> + 'static>`
   = note: required because it appears within the type `std::boxed::Box<proptest::strategy::Strategy<Value=std::boxed::Box<proptest::strategy::ValueTree<Value=std::string::String> + 'static>> + 'static>`
   = note: required because it appears within the type `proptest::string::RegexGeneratorStrategy<std::string::String>`
   = note: required by `lazy_static::lazy::Lazy`
   = note: this error originates in a macro outside of the current crate

error: aborting due to previous error

error: Could not compile `artifact-data`.

also, any advice on speeding up generation of random strings? I'm seeing significant (i.e. 10x) slowdowns compared to quickcheck + regex_generate.

one thing I did: reduce the number generated for tests that don't need a large number. Very hard to do with quickcheck!

Strategies don't implement Sync

I originally wanted to leave the possibility of using interior mutability within a strategy. But as I found out trying to implement prop_recursive with it, you can't usefull track state in a strategy anyway, so I don't think there's any reason not to add Sync at this point.

seeing significant (i.e. 10x) slowdowns compared to quickcheck + regex_generate

That's somewhat expected. Proptest needs to build and retain a more complicated structure for shrinking to work correctly. The generation could also benefit a lot from small string optimisation; currently, each individual element of the regex becomes its own Vec<u8>, so you may be paying for an enormous amount of allocations depending on the regex. I'll look into improving this soon.

Thanks for the replies. It would be nice to add Sync.
As for the slowdown, I think it's mostly fine -- obviously faster is always better :)
It would probably be worth documenting eventually though, especially if a solution cannot be found.

It turns out that adding Strategy: Send + Sync would actually be pretty painful as combinators like prop_map would need to require the closures to be Send + Sync. Instead, I'm just fixing the immediate problem which was specific to the regex strategy, which used Box<Strategy> under the hood and so erased the OIBITS. I'm also adding a conventional way to make a Box<Strategy + Send + Sync> so external users can get the same benefit.
The only other remaining internal use of BoxedStrategy is in prop_recursive(), but I'm not sure what could be done there since switching to the Send + Sync version would restrict how people could use that combinator.

@vitiral Would you be able to provide the regex in question? I started looking into optimising the string generation, but the regex I tried ([0-9]{4}-[0-9]{2}-[0-9]{2} .*) ended up being faster than I anticipated (~9μs per iteration), so it would help to have a slow-but-realistic test case.

Here is the regex I am using:
const GEN_NAME_RE: &str = r#"(?ix)
(REQ|SPC|TST)-              # the type followed by `-`
([a-z0-9_]{1,20}-){0,8}     # an optional number of `elem-` elements
[a-z0-9_]{1,20}             # required final element
"#;

originally I was using * instead of the ranges {1,20} or {0,8}. That was slow, so I adjusted the ranges to (I think) up to 50 and then down to 20/8.
Hope that helps!

The various string-generation strategies are now Send + Sync as of 0.3.2.
I also did look into the performance of string generation, and I believe the main bottleneck is actually character generation due to the inefficient way it accomplishes biasing towards particular characters. Changing that will likely require breaking backwards compatibility, so I'll make another pass at that at a later time.

I've moved the regex performance concerns to a separate issue (https://github.com/AltSysrq/proptest/issues/16) since the problem referenced by the title of this one has been fixed.

Thanks! Wow, you are really responsive on these issues. Hope they were helpful for you as a lib designer!


Add UItest for http request

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes
I created ui test cases for HTTP requests on cookbook.
Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[x] I have run grunt to verify the unit tests pass
[x] I have added suitable unit tests to cover the new/changed functionality

Coverage remained the same at 75.071% when pulling 2201c9062fe33ea3eded15d5cd63a6468a77ac08 on node-red-hitachi:uitest-httprequest into 6bccdd015f347e6c3423a50fb02ac549c5a7e531 on node-red:master.


Game crashes as soon as someone else joins.

When we would make a private lobby, the person who joins would be able to see the other persons avatar, but then both games would crash. The mods I am using are: beattogether, multiquestensions, noodle, mapping, chroma, qosmetics  and the core mods.

Join our Discord for assistance.


Add Rule: Block a list of words from being used.

Description

Code CV09
Rule convention.blocked_words
List will need to be defined and should be a warning not error.
Anti Pattern

SELECT * FROM deprecated_table WHERE 1 = 1;
CREATE TABLE myschema.t1 (a BOOL);

Best Practice

SELECT * FROM another_table WHERE 1 = 1;
CREATE TABLE myschema.t1 (a BOOLEAN);

not appropriate for extension


Metalhead has broken MLJFlux

Tests are now failing for MLJFlux. The tests are running with Metalhead 0.9.3, but if I pin to 0.9.0 the tests pass.
┌ Error: Builder does not appear to build an architecture compatible with supplied data.
└ @ MLJFlux ~/MLJ/MLJFlux/src/mlj_model_interface.jl:61
ImageClassifier basic tests (typename(CPU1)): Error During Test at /Users/anthony/MLJ/MLJFlux/test/test_utils.jl:38
  Got exception outside of a @test
  UndefVarError: `VGG_CONV_CONFIGS` not defined
  Stacktrace:
    [1] VGGHack(depth::Int64; imsize::Tuple{Int64, Int64}, inchannels::Int64, nclasses::Int64, batchnorm::Bool, pretrain::Bool)
      @ MLJFlux ~/MLJ/MLJFlux/src/metalhead.jl:133
    [2] VGGHack
      @ ~/MLJ/MLJFlux/src/metalhead.jl:116 [inlined]
    [3] build(b::MLJFlux.MetalheadBuilder{typeof(MLJFlux.VGGHack)}, rng::StableRNGs.LehmerRNG, n_in::Tuple{Int64, Int64}, n_out::Int64, n_channels::Int64)
      @ MLJFlux ~/MLJ/MLJFlux/src/metalhead.jl:101
    [4] build(model::ImageClassifier{MLJFlux.MetalheadBuilder{typeof(MLJFlux.VGGHack)}, typeof(softmax), Adam, typeof(Flux.Losses.crossentropy)}, rng::StableRNGs.LehmerRNG, shape::Tuple{Tuple{Int64, Int64}, Int64, Int64})
      @ MLJFlux ~/MLJ/MLJFlux/src/image.jl:14
    [5] fit(model::ImageClassifier{MLJFlux.MetalheadBuilder{typeof(MLJFlux.VGGHack)}, typeof(softmax), Adam, typeof(Flux.Losses.crossentropy)}, verbosity::Int64, X::Vector{Matrix{RGB{Float64}}}, y::CategoricalVector{Int64, UInt32, Int64, CategoricalValue{Int64, UInt32}, Union{}})

Here's the Metalhead commit that appears to have caused the breakage: https://github.com/FluxML/Metalhead.jl/commit/09f91c0581676ad2b88163c6cc4ba59c8e67d037


'JSON_SORT_KEYS'

The 'JSON_SORT_KEYS' config key is deprecated and will be removed in Flask 2.3

not actual


Web deploy fix

Fix command and remove ref to empty file

@will-moore did you have a chance to look at it?

Looks good. @pwalczysko You've been successfully testing these updated commands today, right?

@will-moore :

You've been successfully testing these updated commands today, right?

So for example virtualenv omerowebvenv --system-site-packages is not included in https://ci.openmicroscopy.org/job/OMERO-DEV-merge-docs/ws/src/omero/_build/html/sysadmins/unix/install-web/walkthrough/omeroweb-install-centos7-ice3.6.html and thus not run today by me at all.

Looking at the page again, I will be more in favour of removing the commands since we now have the walkthrough links at the top and they do not offer much and add some confusion

@will-moore @pwalczysko I have removed the "default" configuration section
I don't think we need to keep it now that we have re-organized the page and added the links to the walkthroughs

Makes sense. Looks good.

@mtbc done

Thanks merging


Make code flake8-compatible, add "Styling" to docs.

Hope this is useful! I wanted to pull some code (setup.py & version.py) into an existing flake8-compatible project, and I couldn't without modifying the code... so here we are :)

Do you want to add the flake8 thing into the travis configuration?

@arokem Fixed the README (thanks!), and added flake8 to the Travis run.

Thanks!


Date format import-export

I am simply trying to import-excel and export-csv.  When i do this the dates are in excel serial number.  I have tried multiple ways to convert the date to ddmmmyyyy without success.  Any suggestions would be appreciated.

Try this https://github.com/dfinke/ImportExcel/issues/289


Buffer size for vector tiles is hard-coded

may be related to #57.
Vector tiles are currently generated with a hard-coded buffer size of 256.
mapbox-gl-js has known issues with handling tiles that include geometry well past the extent
(such as https://github.com/mapbox/mapbox-gl-js/issues/2854, https://github.com/mapbox/mapbox-gl-js/issues/2676)
The suggested workaround is to use a smaller buffer size. However, this currently cannot be done without forking tilelive-bridge.

A smaller buffer size can be set by setting it at the layer level in the Mapnik XML like
<Layer name="name" buffer-size="5">

See also #94


Application change does not always propagate to Deployment automatically

We've had a few cases, always with one particular application (even after recycling/redeploying), where some changes can get made in the repo, propagate via fluxcd, and show up in the Application, but do not propagate to the Deployment without manually deleting it and redeploying.
For example, adding a new exposed port.

Helm chart in question is here https://github.com/input-output-hk/marlowe-cardano/tree/main/deploy/marlowe-runtime

Oops, sorry, this was misuse of publishVersion.


mqtt message - Double slash

Hi,
I can see that the Kerberos agent is using the following MQTT topic

kerberos//device/...

I would have expected that it would be

kerberos/device/...

(notice the difference between one and two slashes)
Is this correct or a bug?
Thanks,
Tom

This is related to the upload issue with missing credentials! Thanks for reporting. If no credentials are set, no outgoing MQTT session should be made to Hub as well!

Hey @Hooch76, I just had a look and it should not open any outgoing MQTT missages if the hubkey is not set. https://github.com/kerberos-io/agent/blob/master/machinery/src/routers/mqtt/main.go#L62
Can you validate your config, and the version of your Kerberos Agent?

I am using d9694ac and a local MQTT server:

Sending PUBLISH to <my_local_server>(d0, q0, r0, m0, 'kerberos//device/cam_front_door/motion', ... (6 bytes))

My local MQTT server is configured under Settings > Streaming: Broker URI, Username and Password.

Ok thanks for the feedback! Will verify that.

Just a question: now I am using

image: "kerberos/agent:71cd315"

Nothing is configured in the "Kerberos Hub", "Persistence" and "STUN/TURN" sections, but I've configured MQTT (Broker URI (which points to my own MQTT server), Username and Password).
This does no longer trigger a MQTT message when motion is detected (which is bad because I was using MQTT to kick off stuff in Home Assistant). MQTT messages were sent in https://github.com/kerberos-io/agent/releases/tag/d9694ac though.
Is this a configuration error on my side or a bug?

Good point! I didn't get the usecase, apologies. Now I understand the underlaying question. When bringing your own MQTT broker, without connecting to Kerberos Hub, you still want to receive motion messages on your own broker. Therefore we cannot disable the MQTT messages on motion (what we did now).
As you suggested earlier, I propose the following:
Kerberos Hub connected -> Motion -> kerberos/${hubkey}/device/${devicekey}...
No Kerberos Hub connected -> Motion -> kerberos/device/${devicekey}...

Kerberos Hub connected -> Motion -> kerberos/${hubkey}/device/${devicekey}... No Kerberos Hub connected -> Motion -> kerberos/device/${devicekey}...

Sounds good (if you were asking me ;-) )

fixed in latest release! https://github.com/kerberos-io/agent/blob/master/machinery/src/computervision/main.go#L167-L173

Works perfectly fine. Thank you!


send file failed get file stat failed stat /var/lib/sealer/data/default/certs/sea.hub.crt: no such file or directory

[root@iZuf6c8ilqr0nyyx2lsitxZ ~]# sealer apply -f .sealer/default/Clusterfile
2022-03-15 14:23:47 [INFO] [local.go:161] Start to scale this cluster
copying files to <IP_ADDRESS>: 33/33
2022-03-15 14:24:05 [INFO] [runtime.go:83] [<IP_ADDRESS>] will be added as worker
Error: send file failed get file stat failed stat /var/lib/sealer/data/default/certs/sea.hub.crt: no such file or directory
Usage:
  sealer apply [flags]

Examples:
sealer apply -f Clusterfile

Flags:
  -f, --Clusterfile string   apply a kubernetes cluster (default "Clusterfile")
      --force                We also can input an --force flag to delete cluster by force
  -h, --help                 help for apply

Global Flags:
      --config string   config file (default is $HOME/.sealer.json)
  -d, --debug           turn on debug mode

send file failed get file stat failed stat /var/lib/sealer/data/default/certs/sea.hub.crt: no such file or directory

When I try to takeover a cluster, then try to apply or join a node, it failed.
[root@iZuf6c8ilqr0nyyx2lsitxZ ~]# sealer join --nodes <IP_ADDRESS>
2022-03-15 14:28:02 [INFO] [local.go:161] Start to scale this cluster
copying files to <IP_ADDRESS>: 33/33
2022-03-15 14:28:13 [INFO] [runtime.go:83] [<IP_ADDRESS>] will be added as worker
Error: send file failed get file stat failed stat /var/lib/sealer/data/default/certs/sea.hub.crt: no such file or directory

#1246


Use mongo.getServerAddressList() instead of getAllAddress

This allows a mongodb+srv:// URI to be used.
Fixes #255

I've tried it locally with:
spring:
  data:
    mongodb:
      uri: mongodb://localhost:27017
      database: ${DB_NAME}

and:
spring:
  data:
    mongodb:
      uri: mongodb+srv://${MONGO_USER}:${MONGO_PASSWORD}@${ATLAS_CLUSTER}.mongodb.net/test?retryWrites=true
      username: ${MONGO_USER}
      password: ${MONGO_PASSWORD}
      database: ${DB_NAME}

Both appears to work.

Could you please fix formatting and make CI to pass?
[ERROR] /home/travis/build/opentracing-contrib/java-spring-cloud/instrument-starters/opentracing-spring-cloud-mongo-starter/src/test/java/io/opentracing/contrib/spring/cloud/mongo/TracingMongoClientPostProcessorTest.java:35: Wrong lexicographical order for 'java.io.IOException' import. Should be before 'org.mockito.Mock'. [CustomImportOrder]
Audit done.

@pavolloffay Done :)

@pavolloffay Could I get a release with this change as well? So I can remove my workaround?

I will cut it now. Thanks for the contribution


CI misses lint warnings in rustdocs

Remove the #[allow(deprecated)] from the rustdocs of sha256t_hash_newtype and run just lint - gives a warning. But CI passed on https://github.com/rust-bitcoin/rust-bitcoin/pull/3528#issuecomment-2444070959 without it.

Props to @jamillambert for noticing.


Shell out as the correct user in helper methods

Fixes #37.

Coverage remained the same at 100.0% when pulling d126c56b7ef5a676a9d89ed9ceb1ef3c5a28fbf5 on jdh-fix-signed-in-as into f4b7e8387996c3f6649fde8aefbdbfa1673c0e75 on master.

Coverage remained the same at 100.0% when pulling 3bcb970d96f163b1fd234f6c083f8f59b53aed16 on jdh-fix-signed-in-as into f4b7e8387996c3f6649fde8aefbdbfa1673c0e75 on master.


Introduce Isolated Projects-safe builder for Kotlin DSL models

Introduces a separate IP-safe model builder used for the Kotlin DSL model requested during sync.
The existing builders have to be compatible with generic parametrization, while the modern versions of IntelliJ do not use them during sync. With Isolated Projects feature enabled, we can assume more constraints, which ultimately make the implementation of the model builder cleaner.

@bot-gradle merge

I've triggered a build for you. Click here to see all failures if there's any.


[BUG] When i use controller.insertHtml(); method in web it doesn't work and throws this message. What can be reason

Type question here.
TypeError: Cannot read property 'includes' of null
                at handleMessage (about:srcdoc:47:30)

Hmm this is a bug in the javascript code, I'll look into this. Could you post your widget code to make sure I can replicate it?

I tried this using the example app but I could not reproduce (click the Insert HTML button below the editor).

Without further details I will close this, let me know if it is still an issue. Thanks.

I tried this using the example app but I could not reproduce it (click the Insert HTML button below the editor).

I got this error when I'm loading the text in the init state
@tneotia  the issue still exists.


Response should include 202 response with detail of Location header

Not issue, just suggestion on clearer documentation. On page for Copy (https://learn.microsoft.com/en-us/graph/api/driveitem-copy?view=graph-rest-1.0&tabs=http) you have 202 response with helpful information:
"The value of the Location header provides a URL for a service that will return the current state of the copy operation. You can use this information to determine when the copy has finished."
This same long-running-action behaviour occurs for Move too with common response being a 202, not a 200; so this helpful information could be included as an alternate response. It was not at first obvious why my Content was returning empty.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9d11b87a-816c-c20a-3cb3-d13ee68b64cb
Version Independent ID: 9e15b4d9-7612-cc57-b1b0-5bab8e3775a5
Content: Move a file or folder - Microsoft Graph v1.0
Content Source: api-reference/v1.0/api/driveitem-move.md
Product: sharepoint
Technology: microsoft-graph
GitHub Login: @JeremyKelley
Microsoft Alias: MSGraphDocsVteam

As part of a repository clean up effort we are closing older issues. If this issue remains, please: open a new issue, reference this issue, and provide any additional details that may help in resolution. Thank you for your understanding as we work to improve our responsiveness.


[BUG]: using  sandbox clientId always return INVALID_RESOURCE_ID

Is there an existing issue for this?

[X] I have searched the existing issues.

🐞 Describe the Bug
using  sandbox clientId always return INVALID_RESOURCE_ID
😕 Current Behavior
throw INVALID_RESOURCE_ID
🤔 Expected Behavior
create lunch paypay window.
🔬 Minimal Reproduction
crete order via `local` api to create paypal order with `sandbox` using server API .

🌍 Environment
| Software         | Version(s) |
| ---------------- | ---------- |
| react-paypal-js  | "@paypal/react-paypal-js": "8.0.0" |
| Browser          | chrome     |
| Operating System |  macos     |

Relevant log output
{
    "errors": [
        {
            "data": {
                "message": "The specified resource does not exist."
            },
            "message": "RESOURCE_NOT_FOUND",
            "path": [
                "updateClientConfig"
            ],
            "_name": "RESOURCE_NOT_FOUND",
            "checkpoints": [
                "patchClientConfig"
            ],
            "meta": {},
            "contingency": true,
            "statusCode": 200
        }
    ],
    "data": {
        "updateClientConfig": null
    },
    "extensions": {
        "tracing": {
            "version": 1,
            "startTime": "2023-07-09T13:20:27.647Z",
            "endTime": "2023-07-09T13:20:27.747Z",
            "duration": 100231338,
            "execution": {
                "resolvers": [
                    {
                        "path": [
                            "updateClientConfig"
                        ],
                        "parentType": "Mutation",
                        "fieldName": "updateClientConfig",
                        "returnType": "Boolean",
                        "startOffset": 1343334,
                        "duration": 98452377
                    }
                ]
            }
        },
        "correlationId": "f735996fe9af7"
    }
}

Code of Conduct

[X] I agree to follow this project's Code of Conduct

➕ Anything else?
the createOrder  will invoke local server

I'm experiencing the same problem. Any idea how you solved it?

Yes you should use correct client id, This happens occasionally, and the frequency is not high,create order via local server


validtionChecker becomes TRUE only after closing the keyboard

I defined a FloatingLabelTextField (with var isValidMasterPwd2  as validtionChecker) whose content must be the same as the string inserted in another TextField. If I insert a string identical to the other in this TextField, the variable isValidMasterPwd2 becomes TRUE only after closing the keyboard.
Is there a way for the variable to immediately become TRUE as soon as the validity conditions are satisfied?
FloatingLabelTextField($masterPwd2, validtionChecker: $isValidMasterPwd2,
placeholder: "Re-type Password", editingChanged: { (isChanged) in
                }) {
                }
                .isShowError(true)
                .addValidations([.init(condition: masterPwd1 == masterPwd2, errorMessage: "Password not equal")])
                .isRequiredField(true, with: "Password field is required")
                .isSecureTextEntry(!self.isMasterPwd2Show)
                .modifier(ThemeTextField())

Hello @ezamp ,
For some limitation from my side right now there is no any way for immediately become TRUE. I don't know why you need this but you can use this approch :
Declare one computed variable like
   var isPasswordMatch: Bool {
        password == password2
    }

and use isPasswordMatch variable as per your requirement.


make it so the mobile view of the app still displays figures

mobile scales down but the images don't get small enough:

@jread-usgs  this should fix it #56

Still same issue. Got a screen shot of what you are seeing?

@jread-usgs What I see on smaller screens

fixed


go release notes for the 2022-03 release

This is an automated pull request to gather the go release notes for the 2022-03 release. See Producing Release Notes for details of the processing.

@weshaggard how do I fix the broken link on this PR?


OSC-Platform-023: Create a single application dashboard access

We need a simple link consolidating access to all tools under Data Commons platform, similar to https://odh.operate-first.cloud/
Right now it should ideally link to: JupyterHub, SuperSet, CloudBeaver, Trino. The page should be maintained under OS-Climate repository and easily maintainable so we can add new tools as they become available.

Can the links to JupyterHub drill into specific Jupyter notebooks within the JupyterHub?  If so, users can directly access ITR, PhysRisk, etc.

@MichaelTiemannOSC as in JupyterHub user notebook servers? No that's not supported by Jupyterhub or the ODH dashboard. There is no way for one user to access another user's notebook either.

There are notebooks that are used for ingestion, they are all separate, and that's fine.
Maybe what I'm thinking about is that there should be a "Data Scientist's Laucher" which, from a single (Jupyter) environment is able to launch the different analytic tools that can independently access the PROD data, do various analysis, give the data scientists the opportunity to upload and download data as permitted, and that's the unified interface that these analysts see.  Is that possible?

Following on this item: can we just proceed with having at least the existing dashboard used by Operate First environment (which would show links to Jupyter, CloudBeaver, Superset, Trino), maybe with an OS-Climate Data Commons logo? We raised this to make the access across easier during the demo flow and had agreed with this approach in our sprint call. @HumairAK

@HumairAK is there a pattern / example I can follow to prepare such a page consolidating access to the different tools please? I'd like to build one for the Summit demo if possible.

This looks very nice for cluster monitoring but I was more thinking about something a bit more "visual" like a dedicated landing page for OS-Climate community with the OS-Climate logo, access to key systems, token retrieval service, key documentation links from one single page. It should not prevent us from populating the info for OS-Climate in the operate-first cluster page though, i guess there's value in showing this when explaining in the demo how we leverage operate first.

@HumairAK can we open an issue in the ODH community and figure out why we can't use the ODH dashboard?

@durandom we have brought this up sometime ago, and did so again in their slack recently. the reason is because we deploy components in different namespaces and this is not supported. We also want to be able to show services not in ODH, which is also not currently supported (and I'm not sure if it will be).

@HumairAK  Did we get a response from the ODH slack channel.  Did they ack this a feature.

If we upgrade to ODH we get the standard dashboard .  We are on Version 1.2 need to be on 1.3 . @HumairAK will check with ODF group to see if this feature is available on 1.3 and the LOE .

pending update from ODH

reached out to ODH slack here
Looks like the feature for adding custom links is not in yet, but will be available after this pr is merged.
As per @cfchase

[Humair Khan]
any idea if this is on a milestone for any release?
[Chris Chase]
it's supposed to be reviewed and merged this week

If that's the case, by the time we updade odh to 1.3+ we can probably expect this feature to be available.

Humair reached out to ODH .  There is no PR that is ready for merging but its queued up for 1st Week of September.
Dependency :
Patch needs to be merged 1st week of Sep
ODH needs to be upgraded. 1.2 is our current version  . Humair needs to to figure out the upgrade path
Deploy the dashboard.

still pending on ODH upgrade - revisit task in mid Oct, Not blocker for COP27 - lower priority

wait for next operator version - date TBD, check w/ODH team - perform after COP27 (this will be operations centric - separate from user front end).

Gregory from ODH team working on this.  Humair will also get Ryan and Eric B up to speed on this.

@MightyNerdEric to follow-up with Gregory to understand timeline for ODH upgrade; sync up with Humair on dashboard

@MightyNerdEric to ping the OSC-Ops or support channel (Harshad, Marcel Hild)

Discuss ODH implementation on Thurs 15-Dec (need to move from jupyter hub to notebook controller - must make sure users can still run their existing notebooks)

Will discuss general use ODH implementation on 10-Jan (fork that OS-C will have to maintain).  Decide if use for 1) mgmt components; 2) latest version of operator w/out Trino.  Preference to start with latest version, but need to remove existing implementation from CL1.


Fix how ROCm platform is initialized and registered

This should remove the benign but alarming messages that ROCm StreamExecutor
components be doubly registered.
@sunway513 Please help check if this patch works fine with r1.13 branch. It should be better cherry-picked over there.

@whchung done, cherry-picked to r1.13-rocm branch.


absl::Status matchers in googletest

This may be more of a question for googletest. Now that absl::Status is available, I was wondering if the community should expect a corresponding set of matchers such as EXPECT_OK. It would make testing code that returns absl::Status nicer.

Some of the maintainers of Abseil also maintain GoogleTest :-)
The answer is that we do plan on releasing the absl::Status matchers, though the plan is to release them in Abseil, not GoogleTest.
There are some things that we have to figure out how to deal with though. Abseil doesn't release forks of code, though sometimes we do strip out features. It would be easy if we just forked them, but it would make maintenance harder. We do have a plan to deal with the issues, but it will take some time. I can't give you an estimate of when this might happen.
If you need them in the short term, you might be able to copy a simple implementation from
https://github.com/abseil/abseil-cpp/blob/bcc11a8918f8cc9b43c9a0dc5da7b52d48452bd3/absl/status/statusor_test.cc#L46-L161

Awesome, thanks! Looking forward to it!
Also, I'm happy to contribute to abseil the RETURN_IF_ERROR and ASSIGN_OR_RETURN macros as seen elsewhere on the web if the project finds them useful (and if plans aren't already underway).

It would be great to have RETURN_IF_ERROR and ASSIGN_OR_RETURN macros in the public API, since these helps a lot to write concise yet fairly readable code IMHO.

Just wanted to bubble this back up now that GoogleTest has officially announced plans to take on abseil as a dependency :).

Until RETURN_IF_ERROR and ASSIGN_OR_RETURN become part of abseil, I've posted a bazel target for them here.

Are there any updates to this? Currently, there are various versions of these matchers floating around in various OSS projects. Having an officially-supported version of the macros, as well as matchers like IsStatus, will be greatly helpful.

Are there any updates to this? Currently, there are various versions of these matchers floating around in various OSS projects. Having an officially-supported version of the macros, as well as matchers like IsStatus, will be greatly helpful.

Someone (not me) is actively working on this. There is a surprising amount of work though.

The absl::Status GoogleTest matchers are now published: https://github.com/abseil/abseil-cpp/blob/master/absl/status/status_matchers.h
Note that EXPECT_OK is intentionally not included. Use EXPECT_THAT(status, IsOk()) instead.
The macros like RETURN_IF_ERROR are probably a few months away. We currently believe that there are some performance wins we can get by changing their current interface, so we want to investigate making that change before releasing them.

Woot! Thanks @derekmauro!


how do i clear the cache ?

please be a bit detailed as i'm new to this and programming. thanks in advance.

This error is not related to the cache. It is due to a large batch_size that exceeds the GPU memory capacity. To resolve this, you can reduce the batch_size.

↑ is right.

This error is not related to the cache. It is due to a large batch_size that exceeds the GPU memory capacity. To resolve this, you can reduce the batch_size.

thANKS


Adding examples

Closes https://github.com/MicrosoftDocs/office-docs-powershell/issues/6867

Docs Build status updates of commit 764cbae:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsTeamsMeetingBroadcastPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@Kateyanne Please merge this PR. Thanks

Docs Build status updates of commit 06bff00:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsTeamsMeetingBroadcastPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Scope options invalid.

Business rule's scope options should include Entity and not table, to be aligned with current options available in the PP portal.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 76443691-3e03-e2ac-53e6-a2af78659435
Version Independent ID: 3ca3568e-bcab-1892-309e-31be43c9d33f
Content: Create a business rule in Microsoft Dataverse - Power Apps
Content Source: powerapps-docs/maker/data-platform/data-platform-create-business-rule.md
Service: powerapps
Sub-service: dataverse-maker
GitHub Login: @lancedMicrosoft
Microsoft Alias: lanced

@hugobarona - The scope table in step 5 does indicate Entity as the item to select from the business rule editor. Entity is still the term used instead of table because the business rule editor hasn't been updated to reflect the current naming.
Closing issue.


Fixed plugin build SDK, updated Firebase to latest

The build SDK for the plugin was still set at 27 instead of the required 28.  This created problems with CI/CD servers and command line builds even though Flutter and Android Studio seemed to find a way around it.
The specific error this resolves is:
Execution failed for task ':fast_qr_reader_view:verifyReleaseResources'.
> java.util.concurrent.ExecutionException: com.android.builder.internal.aapt.v2.Aapt2Exception: Android resource linking failed
  Output:  /.../build/fast_qr_reader_view/intermediates/res/merged/release/values/values.xml:197: error: resource android:attr/fontVariationSettings not found.
  /.../build/fast_qr_reader_view/intermediates/res/merged/release/values/values.xml:198: error: resource android:attr/ttcIndex not found.
  error: failed linking references.

@jpeiffer thanks a lot for the PR!


test: add missing tests

:tada: This PR is included in version 0.20.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Save Server Log - Suggestion

Hey there!
I would suggest saving somewhere server log, to be possible to get access to it after server restart or access more to the top. Becauase there are many usefull information. Thank you for reading. For any futher questions about it do not hesitate to contact.
Have a nice day
Squizer

it already saves to C:[SERVER NAME]\txData\default\logs

it already saves to C:[SERVER NAME]\txData\default\logs

This isn't 100% correct, if the user has the server in a different place then txDdata will be in a different place, the logs are saved in <citizen_root>/../txData/[profile name]/logs for Windows and <citizen_root>/../../../txData/[profile name]/logs for Linux


[Azure.Core] ModelSerializer delete Readme and associated files

Deleting the current md file and its associated samples because we want to use actual Azure SDK models in the sample file. We need to release the ModelSerializer first and re-generate the models to have the ModerSerializer interface. The ReadMe and samples will then be updated. ReadMe work is being tracked in this PR: https://github.com/Azure/azure-sdk-for-net/pull/37998.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Core


Move cherry-pick automation to ADO

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

Move cherry-picking automation from Github Actions to ADO

Change Log

Remove cherry-pick github workflow files
Add pipeline definition for cherry-picking

Does this affect the toolchain?

NO
Test Methodology

Example PR that bumps a package version: https://github.com/microsoft/CBL-Mariner/pull/6384
Example PR created by cherry-pick automation: https://github.com/microsoft/CBL-Mariner/pull/6386

/cherry-pick fasttrack/2.0


Fix Jira transition identification

There is no opened issue, I've directly opened this PR. I can create an issue if required :)
The Jira sink documentation says that one is allowed to pass following params

doneStatusName : [Optional - default: 'Done'] The name of the "Done" status in Jira. Will be used to identify "Done" tasks in Jira.
reopenStatusName : [Optional - default: 'To Do'] The name of the "To Do" status in Jira. Will be used to identify "To Do" tasks in Jira.

So the user expects for Robusta to compare provided params (if any) with Jira status name, while the code instead compares that params with a transition name, and it's wrong.
So the PR fixes that, it makes Robusta compare a transition "TO" status' name with a target status name, which is provided by the user

Here is an example of a Json that identifies a Jira transition
{
            "id": "171",
            "name": "Resolve TODO issue",
            "to": {
                "self": "https://my.atlassian.net/rest/api/3/status/10000",
                "description": "",
                "iconUrl": "https://my.atlassian.net/images/icons/statuses/closed.png",
                "name": "Done",
                "id": "10000",
                "statusCategory": {
                    "self": "https://my.atlassian.net/rest/api/3/statuscategory/3",
                    "id": 3,
                    "key": "done",
                    "colorName": "green",
                    "name": "Done"
                }
            },
            "hasScreen": False,
            "isGlobal": False,
            "isInitial": False,
            "isAvailable": True,
            "isConditional": True,
            "isLooped": False
        }


[React Native] Support Hermes for IOS

Description
React Native 0.64 adds support for Hermes on IOS.
Describe the solution you'd like
Please support Hermes on IOS.

👋 hey @smacgregor, this is something that we'll be taking a look into. We'll let you know as soon as Bugsnag support for Hermes on iOS is available.

Yeah we would like to see this in as well to get the performance gains of Hermes!

@xander-jones is there any progress on this? We'll release our app on monday and would love to have the sourcemaps for hermes in there.

Hi! We're still at the stage of designing the required changes for Hermes source maps on iOS so we don't have a timeline for release yet, but this is being worked on. We'll provide updates here as soon as we release support for this.

We now support Hermes on iOS. You can find our updated documentation here:
https://docs.bugsnag.com/build-integrations/js/source-maps-react-native/#ios

Hi @mattdyoung and @xander-jones, before I update my project to use Hermes for iOS. Does your library still sends the Hermes source maps like used to be automatically, or do I need to get back to the manual way of uploading it to Bugsnag?

Hey @pedpess, unfortunately because source map output works a little differently when using Hermes (for both Android and iOS), you won't be able to use the Bugsnag automatic source map uploads.
However, that's not to say that you can't automate it in your pipeline post-build: You can find our docs on how to get & upload source maps here: https://docs.bugsnag.com/build-integrations/js/source-maps-react-native/#hermes

@pedpess 🤦 apologies, an error in my previous comment that has now been updated: yes, you can use automated source map uploads with Hermes on iOS and Android (so long as you're not also using CodePush: in which case check out the docs here: https://docs.bugsnag.com/build-integrations/js/source-maps-react-native/#codepush-and-hermes

Thanks, @xander-jones 🙏🏻 . In my case, I'm not using CodePush to make JS releases. So, I can expect that my Bugsnag Fastlane plugin on iOS 🍎 and the Gradle Bugsnag plugin on Android 🤖 will do the job for me?


WIP: Add playback rate implementation

This commit adds playback rate support. It also removes the enum
of playback rates from the constants, since the playback rate can
be any value between 0.25 and 2.0.
TODO: Check if the chromecast command "SET_PLAYBACK_RATE" is correct and works (I have no idea how to test for chromecast).
Tested on API 30 and works like a charm (except the limitations of the value set by the YouTube API).
Example usage of the new feature:

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_simple_example);

    YouTubePlayerView youTubePlayerView = findViewById(R.id.youtube_player_view);

    youTubePlayerView.addYouTubePlayerListener(new AbstractYouTubePlayerListener() {
        @Override
        public void onPlaybackRateChange(YouTubePlayer youTubePlayer, float playbackRate) {
            super.onPlaybackRateChange(youTubePlayer, playbackRate);
            Log.d("PLAYBACK", "Playback changed to:" + playbackRate);
        }
    });

    youTubePlayerView.getYouTubePlayerWhenReady(youTubePlayer -> youTubePlayer.setPlaybackRate(1.5f));

    getLifecycle().addObserver(youTubePlayerView);
}

Closes #101.
Closes #645.

Can somebody test this on chromecast to see if the command is correct? Or provide at least information where I can find these commands to check it myself. This would complete this PR and remove it from WIP state.

The YouTubePlayer does not guarantee that the playback rate will actually change or change to the specified value.

what does this mean?
It is probably not going to work on chromecast, we need to add support for ChromecastCommunicationConstants.SET_PLAYBACK_RATE in the javascript code (chromecast-receiver)

From the IFrame API under player.setPlaybackRate(suggestedRate:Number):Void: "[...] Calling this function does not guarantee that the playback rate will actually change. However, if the playback rate does change, the onPlaybackRateChange event will fire, and your code should respond to the event rather than the fact that it called the setPlaybackRate function."
I guess they mean that there are specific situations, where setPlaybackRate is ignored. Might be for example when you have set the max speed (2.0) and call setPlaybackRate(3.0) for example. Might also be the case if the player is in a state that cannot handle the call (I have however no idea how exactly they mean it).
And about the constant, you are right. I have overseen it because Android Studio hid it from the overview. I hope I haven't forget anything else now.

Sorry for never getting to this. Changing playback speed has been implemented in version 11.0.0.


Vegan Meatball

About the PR
Adds a new salvage called "Vegan Meatball"
I was sorta going for a "mystical plant orb" feel
Why / Balance
Just one anomaly salvage wasn't enough
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl:

add: Salvagers can now pull in overgrown floral anomalies.

Imagine an overgrown bluespace anom
Or an overgrown gravity anom (just a singularity)

strange theres no wreck
ill fly forward a bit see if i hit anything
:trollface:

please, put chromite floor under walls


pass Actor to cartridge messages

About the PR
title
Why / Balance
needed downstream, no reason not to pass it
Technical details
EntityUid not NetEntity since its not sent over network, no idea why LoaderUid is a NetEntity since its assigned by server to a GetNetEntity result... (on top of not making sense to use what the client says)
Media
Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes
no
Changelog
.

Please just burn the stock market instead

the rich continue to get richer


fix leak reuse

https://github.com/tensorflow/tensorflow/issues/6220
https://github.com/tensorflow/models/issues/901

Thanks! See also another solution to this on the main DIGITS project: https://github.com/NVIDIA/DIGITS/blob/master/digits/tools/tensorflow/model.py

Thanks！ But that repo's  solution  does not work yet.   Maybe this PR is correct:
https://github.com/NVIDIA/DIGITS/pull/1739


IOU - Currency in the amount editor is USD when the request is created in local currency

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.63-5
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Go to staging.new.expensify.com
Go to 1:1 DM.
Create a manual request in local currency.
Go to transaction thread.
Click Amount.

Expected Result:
The currency in Amount editor should be the local currency,.
Actual Result:
The currency in Amount editor is USD, when the request is created in local currency.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/95f49bee-4c0c-4803-a28a-02afa03c0fae

View all open jobs on GitHub

@joekaufmanexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #collect project.

Production
https://github.com/Expensify/App/assets/115492554/c79b040c-a514-4f31-985d-2ec3e301aac3

Proposal
Please re-state the problem that we are trying to solve in this issue.
The currency in Amount editor is USD, when the request is created in local currency.
What is the root cause of that problem?
We're passing wrong transaction data to get the currency here. we should pass is as transaction when we're editing instead of draftTransaction
https://github.com/Expensify/App/blob/305f12c52ef228e7ed4845735a1794942a2b8d87/src/pages/iou/request/step/IOURequestStepAmount.tsx#L82
What changes do you think we should make in order to solve the problem?
Update this line to
const {currency: originalCurrency} = ReportUtils.getTransactionDetails(isEditing ? transaction : draftTransaction) ?? {currency: CONST.CURRENCY.USD};

https://github.com/Expensify/App/blob/305f12c52ef228e7ed4845735a1794942a2b8d87/src/pages/iou/request/step/IOURequestStepAmount.tsx#L82
What alternative solutions did you explore? (Optional)
NA

Proposal
Please re-state the problem that we are trying to solve in this issue.
The currency in Amount editor is USD, when the request is created in local currency.
What is the root cause of that problem?
We're passing wrong transaction data to get the currency here. we should pass it as transaction when we're editing instead of draftTransaction
https://github.com/Expensify/App/blob/305f12c52ef228e7ed4845735a1794942a2b8d87/src/pages/iou/request/step/IOURequestStepAmount.tsx#L82
What changes do you think we should make in order to solve the problem?
Update this line to
const {currency: originalCurrency} = ReportUtils.getTransactionDetails(isEditing ? transaction : draftTransaction) ?? {currency: CONST.CURRENCY.USD};

https://github.com/Expensify/App/blob/305f12c52ef228e7ed4845735a1794942a2b8d87/src/pages/iou/request/step/IOURequestStepAmount.tsx#L82
What alternative solutions did you explore? (Optional)
NA

Oof ya i would say this is a blocker, it's not great to show it's $100 when it's actually 100 in some other currency 😬

Hmm this one looks pretty sus: https://github.com/Expensify/App/pull/38892
cc @roryabraham @sobitneupane

Posted in slack & tagged ^ those people - https://expensify.slack.com/archives/C01GTK53T8Q/p1713538343234679?thread_ts=1713521084.907369&cid=C01GTK53T8Q

Hmm, based on @nkdengineer root cause and solution which I already tested, it shouldn't be coming from our PR because we don't change the isEditing ? draftTransaction : transaction code/logic.

I think it's coming from https://github.com/Expensify/App/pull/39144. In amount page, we are creating a backup transaction if we are editing a money request.
https://github.com/Expensify/App/blob/4654d6ed3389916e750ecdfdbdad08d637535b8d/src/pages/iou/request/step/IOURequestStepAmount.tsx#L107-L114
createBackupTransaction will take the current transaction data and copy it to transactionsDraft, but the PR above changes the name to transactionsBackup.
That's why when we are editing, we pass the draftTransaction instead of transaction to get the data from the backup data.
https://github.com/Expensify/App/blob/4654d6ed3389916e750ecdfdbdad08d637535b8d/src/pages/iou/request/step/IOURequestStepAmount.tsx#L82
Rename the key to transactionsBackup and the issue is fixed.
https://github.com/Expensify/App/blob/4654d6ed3389916e750ecdfdbdad08d637535b8d/src/pages/iou/request/step/IOURequestStepAmount.tsx#L269-L272
ONYXKEYS.COLLECTION.TRANSACTION_BACKUP

Thanks @bernhardoj ! I agree it does look like https://github.com/Expensify/App/pull/39144 is the real culprit - they modified createBackupTransaction which now updates a new onyx key, and they didn't look where else that function was used & if we needed to subscribe to the new onyx key there (which it looks like we do need to)

Ok I have a PR up for the fix - note I used @bernhardoj 's solution

My proposal  will cover this issue

@Beamanator @bernhardoj The new field ONYXKEYS.COLLECTION.TRANSACTION_BACKUP should only be used in distance requests as explained here. With the manual request, we should use draftTransaction as before.

@DylanDylann I see you were already paid for this PR in https://github.com/Expensify/App/issues/40631#issuecomment-2089321279, so I don't think any payment is due here. Closing this out for now, but LMK if you think that is not correct!


multi processing with sounddevice

Hi there,
Newbie, hope this is the correct place to raise issues.
I'm trying to build a program with both input and output using 'sounddevice'.
The program outputs into a USB audio interface and reads back the data from it.
The process is very heavy so I had separated the incoming data (from USB audio interface) to a different process. Hence - multi processing.
The program uses 'multiprocess queue' between the two processes.
For some reason, I couldn’t set the processes to work with the same queue.
What am I doing wrong ?

MP_SingleProgram.txt

Problem seems to be not relevant to multi processing.

There have been issues with the multiprocessing module before (#120, #147).
But if it's not related to multiprocessing, can you please provide a minimal example without it?

Yes I will provide an example soon.


Add "how to add an example" guide to the docs site

Related:

https://github.com/rerun-io/rerun/issues/2313

We have some guide here https://github.com/rerun-io/rerun/blob/main/examples/README.md#adding-a-new-example, we have a template https://github.com/rerun-io/rerun/tree/main/examples/python/template and we even have a sort of template engine for external examples!
I'd say we have enough on this front for the time being.


Multi-line Queries

Great work Guillermo! Just a couple of minor annoyances with multi-line queries.
Line breaks in a query don't retain white-space when sent to the query function, causing a syntax error in the database query engine.
E.g.
+++QUERY SELECT id
FROM records
USE KEY "myRecord::1234"
+++

becomes
SELECT idFROM recordsUSE KEY "myRecord::1234"

Expected behavior would be to either retain a newline character, or to replace with a single space.
The easy work-around is to add some explicit white-space at the beginning of each line, but I keep forgetting to do this after pasting a query.
I've also noticed that you must start the query on the same line as the QUERY tag, or it doesn't work.
e.g. this works
+++QUERY SELECT id
    FROM records
+++

this does not (it just resolves to null)
+++QUERY
   SELECT id
   FROM records
+++

In principle, the first issue you mentioned is fixed in v2.5.2. Regarding the second, I wasn't able to reproduce it; but maybe it was also fixed as a side effect ;). Could you please check? If needed, please reopen this issue.


Unable to set CSP directive in options

Version
nuxt-security: 0.9.0
nuxt: 3.0.0
Steps to reproduce
Load an image from an external source, for example: <img src="https://images.mycdn.com/image.png" />
Set the nuxt-security options to allow the url:
export default defineNuxtConfig({
security: {
    contentSecurityPolicy: {
      value: {
        'base-uri': ["'self'"],
        'font-src': ["'self'", 'https:', 'data:'],
        'form-action': ["'self'"],
        'frame-ancestors': ["'self'"],
        'img-src': [
          "'self'",
          'data:',
          "https://images.mycdn.com",
        ],
        'object-src': ["'none'"],
        'script-src-attr': ["'none'"],
        'style-src': ["'self'", 'https:', "'unsafe-inline'"],
        'upgrade-insecure-requests': true,
      },
      route: '/**',
    },
  },
})

What is Expected?
The image should be allowed to load.
What is actually happening?
Chrome still gives an error:
Refused to load the image '<URL>' because it violates the following Content Security Policy directive: "img-src 'self' data:".
It seems the options are not applied and it's not possible to load images from a cdn.

Hey @alexbikazzan
You forgot about headers in the config.
A proper config structure should be:
export default defineNuxtConfig({
security: {
    headers: {
     contentSecurityPolicy: {
      value: {
        'base-uri': ["'self'"],
        'font-src': ["'self'", 'https:', 'data:'],
        'form-action': ["'self'"],
        'frame-ancestors': ["'self'"],
        'img-src': [
          "'self'",
          'data:',
          "https://images.mycdn.com",
        ],
        'object-src': ["'none'"],
        'script-src-attr': ["'none'"],
        'style-src': ["'self'", 'https:', "'unsafe-inline'"],
        'upgrade-insecure-requests': true,
      },
       route: '/**',
     },
    }
  },
})

Also, I have just noticed that by using the array approach, you will get duplicated header value so I recommend to use a string instead:
security: {
    headers: {
      contentSecurityPolicy: {
        value: "base-uri 'self'; font-src 'self' https: data:; form-action 'self'; frame-ancestors 'self'; img-src 'self' data: https://images.mycdn.com; object-src 'none'; script-src-attr 'none'; style-src 'self' https: 'unsafe-inline'; upgrade-insecure-requests",
        route: '/**',
      },
    }
  }

Yes, I just forked the repo and noticed that. Also I needed to add crossOriginEmbedderPolicy to the config as well.
Sorry for opening an issue about it, I was just sloppy! Thanks for the quick response.

No worries! Thanks to it, I managed to find another issue! :)


My C++ snippets unworking after update.

VSCode Version: Code 1.10.2 (8076a19fdcab7e1fc1707952d652f0bb6c6db331, 2017-03-08T13:56:35.908Z)
OS Version: Darwin x64 16.4.0
Extensions:

Extension
Author
Version

insertnumbers
Asuka
0.9.1

calculate
acarreiro
1.1.0

vscode-theme-onedark
akamud
1.3.1

Bookmarks
alefragnani
0.12.0

python
donjayamanne
0.6.0

code-runner
formulahendry
0.6.14

Theme-FlatlandMonokai
gerane
0.0.4

CppSnippets
hars
0.0.7

cpptools
ms-vscode
0.10.4

sublime-keybindings
ms-vscode
2.0.1

vscode-icons
robertohuertasm
7.3.0

My C++ snippets unworking after update.
I only update new version.
I don't change any setting.
what happen?
I update new version will change default setting?
Steps to Reproduce:

Please file the issue against the corresponding extension.


fix: credential_definition type -> vct

According to https://vcstuff.github.io/oid4vc-haip-sd-jwt-vc/draft-oid4vc-haip-sd-jwt-vc.html#name-authorization-details
@fmarino-ipzs I think that this PR should be extended with some words in the text that says something about this requirement
if W3C dt is used, type would be then used. I'd create a warning box ...

I see your point, but this is not aligned with https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html#name-credential-issuer-metadata-2.
Am I missing something?

@fmarino-ipzs type is fow W3C dt 1.1, while vct is for sd-jwt-vc ...

@fmarino-ipzs profile merge here
https://github.com/openid/OpenID4VCI/pull/128/files

Closed by https://github.com/openid/OpenID4VCI/commit/12d5ede25056daba991906e845d80128ad57572c


Implement cross-platform compilation and usage (Linux & MacOS)

I have no plans to implement Linux support, so this pull request will be terminated

Very well.

I might consider adding Linux support in the future with my own code, but I know nothing about Linux coding and how to port my Rickroll program to those platforms. I do still thank you for your contribution (even if it got shot down in the end)


add secure mode document

What type of PR is this?
/kind documentation

What this PR does / why we need it:
The Karmada Security Mode document aims to assist users in ensuring the security of their Karmada deployments.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
NONE

/lgtm for style

cc @XiShanYongYe-Chang  @RainbowMango


chore: Add Remix To Vite section of docs

I added Remix to the Vite compiler section of the docs
Please describe the changes this PR makes and why it should be merged:
Status

[ ] Code changes have been tested against prettier, or there are no code changes
[ ] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

[ ] This PR changes the codebase

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
[ ] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)

[x] This PR only includes non-code changes, like changes to documentation, README, etc.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 25.706%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1257

Relevant Lines:
5082

💛  - Coveralls

This change is subject to review from @aidenybai, but, I'll merge this for now


Mockhandler: OutOfBoundsException: Mock queue is empty

Q
A

Bug?
yes

New Feature?
no

Version
6.3

Actual Behavior
I try to test my service class, which sends a get request to an external REST-API. I follow these quidelines:

http://www.inanzzz.com/index.php/post/7cwp/mocking-guzzle-and-testing-external-api-with-phpunit
https://wellingguzman.com/notes/guzzle-http-upgrade-mocking-from-version-5-to-6

and read also the documentation, but i get always a OutOfBoundsException if I run the test.
Here is my class:
class PaladinsApiService
{
    protected const API_ENTRY_POINT = 'http://api.paladins.com/paladinsapi.svc/';
    protected $devId = '';
    protected $authKey = '';
    protected $requestClient;

    public function __construct($devId, $authKey, $requestClient = null)
    {
        $this->devId = $devId;
        $this->authKey = $authKey;
        $this->requestClient = $requestClient;
    }

    public function calculateSignature($method): string
    {
        $date_utc = new \DateTime("now", new \DateTimeZone("UTC"));
        $timestamp = $date_utc->format('YmdHis');

        return md5($this->devId . $method . $this->authKey . $timestamp);
    }

    public function getSessionFromApi(): string
    {
        $response = null;
        try {
            $signature = $this->calculateSignature('createsession');
            $date_utc = new \DateTime("now", new \DateTimeZone("UTC"));
            $timestamp = $date_utc->format('YmdHis');

            // this line throws the error because there is no response in the queue
            $response = $this->requestClient->get(self::API_ENTRY_POINT . "createsessionJson/{$this->devId}/$signature/$timestamp");
        } catch (\Exception $exception) {
            echo $exception;
        }

        return $response->getBody()->getContents();
    }

    // Getter and setter
    ...
}

My test:
class PaladinsApiServiceTest extends TestCase
{
    protected $cut;
    protected $mockHandler;
    protected $devId = '1234';
    protected $authKey = '23FDA345DAF523FSDAF32341DAFDSDA3';

    public function setUp()
    {
        $this->mockHandler = new MockHandler();

        $requestClient = new Client([
            'handler' => $this->mockHandler,
        ]);

        $this->cut = new PaladinsApiService($this->devId, $this->authKey, $requestClient);
    }

    public function tearDown()
    {
        $this->cut = null;
    }

    public function testCreatedSessionByGivenDevIdAndAuthKey(): void
    {
        $response = file_get_contents(__DIR__.'/../Mock/Service/responseTestCreatedSessionByGivenDevIdAndAuthkey.json');
        $this->mockHandler->append(new Response(200, [], $response));

        $this->assertJson($this->cut->getSessionFromApi());
        $this->assertJsonStringEqualsJsonString($response, $this->cut->getSessionFromApi());
    }
}

And the fixture:
{
  "ret_msg": "Approved",
  "session_id": "0ECDF26BC1F04EE4BA4AF10EC3604E04",
  "timestamp": "2/14/2013 7:50:20 PM"
}

What do I wrong?
If I dump the count of mockhandler I get right back the value one.
Why is the queue of mock handler empty in my class?
If I execute the get method directly in my test class, it works as expected.
Expected Behavior
No empty queue in the tested class.
Steps to Reproduce
| PHP        | 7.1
| PHPUnit | 6.5
| Symfony| 4.1 (That should not be relevant)

All works right.
I call the method 'getSessionFromApi' twice, but add only one response to the queue.
So the second call don't have a response and fails.
I close this issue.
Thanks for attention.

@GagaMen how did you solved this?

@isaacdarcilla
Mocking works like a queue (First In First Out) and every defined mock response is used once.
So I defined the mock response only one time with this line:
$this->mockHandler->append(new Response(200, [], $response));

But in the assert action I called the function I want to test twice:
$this->assertJson($this->cut->getSessionFromApi()); $this->assertJsonStringEqualsJsonString($response, $this->cut->getSessionFromApi());

So the second call of the function getSessionFromApi doesn't get a response from the mock handler.
There are two possible solutions:

You can register the mock response for each necessary function call (in this case twice)
You can save the return value of the function getSessionFromApi in a variable and use this in the assert calls

In my opinion, the last solution is the best because it matches the AAA (Arrange, Act, Assert) test pattern.
I hope this helps.


Rename ordered item to order line

I want to merge this change because...
#1315
Pull Request Checklist

[ ] Privileged views and APIs are guarded by proper permission checks.
[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Database queries are optimized and the number of queries is constant.
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] Python code quality checks pass: pycodestyle, pydocstyle, pylint.
[ ] JavaScript code quality checks pass: eslint.

Codecov Report

Merging #1353 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1353   +/-   ##
=======================================
  Coverage   82.04%   82.04%
=======================================
  Files         114      114
  Lines        5487     5487
  Branches      636      636
=======================================
  Hits         4502     4502
  Misses        830      830
  Partials      155      155

Impacted Files
Coverage Δ

saleor/order/models.py
89.51% <100%> (ø)
:arrow_up:

saleor/dashboard/order/forms.py
67.6% <100%> (ø)
:arrow_up:

saleor/dashboard/order/views.py
56.4% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 750124d...e7437d0. Read the comment docs.


Change ipv4 value to ip address instead of an integer

Pull Request Test Coverage Report for Build 149

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.06%) to 88.312%

Totals

Change from base Build 148:
-0.06%

Covered Lines:
340

Relevant Lines:
385

💛  - Coveralls


Better handling of aws secrets when adding a new inventory

Currently, the syntax for adding a new inventory requires this:
pentagon add inventory -Dtype=aws -Dname=prod -Daws_access_key=REDACTED -Daws_secret_key=REDACTED -D=aws_default_region=us-east-1

This is confusing since the start project syntax is:
pentagon add inventory -Dtype=aws -Dname=prod -Daws-access-key=REDACTED -Daws-secret-key=REDACTED -D=aws-default-region=us-east-1

It would be preferred to use the same syntax (dashes) for both.

Those look exactly the same to me. Is there a difference I'm not spotting?

Underscores vs Dashes in the parameter names.

Ah, yes. 🤦♀


Show events in metrics bar

This PR adds events to MetricsBar and closes #1431. All pages (dashboard, website, real-time) would have the triad (views, visitors, events):

According to your comment here, it might not be super-interesting to show this metric in the dashboard page. Please let me know if you prefer to hide it in that case; I believe, though, that for consistence it would be better to show it always.
Session filters (OS, browser, device, country), as well as the URL filter, work with this implementation correctly and affect the events metric. View-related filter "referrer" does not affect the metric. Maybe when selecting such a filter we could gray out the "events" metric?
I look forward to your feedback!
Please note that the ClickHouse queries have been implemented, but unfortunately I couldn't test them.

Thank you for this PR, but we will be refactoring events in the next version and moving them completely to a new section.


double parser returns unexpected result for the input ". " when the lexical feature is enabled

Prerequisites

Rust version : rustc 1.39.0 (4560ea788 2019-11-04)
nom version : 5.0.1/master
nom compilation features used: lexical

Test case
The number::complete::double parser returns an unexpected result when passed the input ". ". I would expect it to fail, but it returns Ok((" ", 0.0)). If the lexical feature is disabled, then the expected error of: Err(Error((" ", Digit)) is returned.
Sample repo: https://github.com/evant/nom-double-parse-issue
use nom::number::complete::double;
use nom::IResult;

fn main() {
    println!("nom double parse: {:?}", nom_double(". "));
}

fn nom_double(input: &str) -> IResult<&str, f64> {
    double(input)
}

The specific issue is here, where the complete nom parser uses lexical (which I maintain) to provide a streaming-like feature detection, which I believe is an issue here. Older versions of lexical detected the first invalid digit, which would raise an InvalidDigit if only a '.' character was found (or a '.' character follow by any non-valid digit), which was fairly amibiguous.
My new fork should correct this issue with a more modern version of lexical:
https://github.com/Alexhuszagh/nom-double-parse-issue
Newer versions, which I will shortly submit a PR for, will correctly fail with this input.
nom double parse: Ok((" ", 0.0))
lexical_043 double parse: Result { value: 0.0, error: Error { code: InvalidDigit, index: 1 } }
lexical_070 double parse: Err(Error { code: EmptyFraction, index: 0 })

#1101 is merged, new version coming up


Multiple class with the same fully declared type could not be generated

Hi!
If I'd like to generate from multiple schema files and those schemas are all containing a full description of an object - for example MessageContext - the generator will fail.

Found conflicting definition of type hu.****.*****.MessageContext in

In our company we have to fully declare this object in every schema. So I don't know if it is a useage problem from our side and the generator implemented specificly this way.

That is an intentional behavior of this plugin.  It ensures that, if a nested type is defined in multiple schema files, the definition matches to avoid a potentially undesired result if a different variation is used last for source file generation.
You have two approaches you can take:

Make sure that the definitions of your nested types match exactly between all relevant schema files (the plugin will detect that they match and not treat it as an error)
Don't use files with multiple definitions of nested types, instead pulling the nested types out into their own files (ensuring that there is no ambiguity, as there is only a single definition of the type).


Setting Channel Default Currency Issue

Bug report
Title
New Currency issue.
On a fresh install of the project, I am given this error when trying to change the default currency on a channel The base currency id field does not exist in currencies. .
Issue Description
Give the following error when changing the default currency on a channel The base currency id field does not exist in currencies.. This curreny is a new one that I added
Preconditions
Please provide as detailed information about your environment as possible.
Latest Version
Steps to reproduce
It is important to provide a set of clear steps to reproduce this bug.If relevant please include code samples.
1. Add currency with the following:

Code: GBP
Name: Pound Sterling
Symbol: £

2. change the default channel's default currency to this.

Expected result
Tell us what should happen.

For the curreny to be changed to GBP

Actual result

Tell us what happens instead.

[points....]

Order:
1:

2:

@DubStepMad
to add the GBP as the base currency, select this currency under the currencies in channel https://prnt.sc/xslj1z

@DubStepMad
to add the GBP as the base currency, select this currency under the currencies in channel https://prnt.sc/xslj1z


🔧  Missing namespace information required by Gradle 8

How were you trying to build the app?
Tried to build my app using pnpm run android
Full build logs
> Task :react-native-vision-camera:processDebugManifest FAILED

Incorrect package="com.mrousavy.camera" found in source AndroidManifest.xml: [redacted]/node_modules/react-native-vision-camera/android/src/main/AndroidManifest.xml.
Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported.
Recommendation: remove package="com.mrousavy.camera" from the source AndroidManifest.xml: [redacted]/node_modules/react-native-vision-camera/android/src/main/AndroidManifest.xml.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-vision-camera:processDebugManifest'.
> A failure occurred while executing com.android.build.gradle.tasks.ProcessLibraryManifest$ProcessLibWorkAction
   > Incorrect package="com.mrousavy.camera" found in source AndroidManifest.xml: [redacted]/node_modules/react-native-vision-camera/android/src/main/AndroidManifest.xml.
     Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported.
     Recommendation: remove package="com.mrousavy.camera" from the source AndroidManifest.xml: [redacted]/node_modules/react-native-vision-camera/android/src/main/AndroidManifest.xml.

Project dependencies
"dependencies": {
    "@aws-amplify/auth": "^5.6.5",
    "@aws-amplify/core": "^5.8.5",
    "@aws-amplify/pushnotification": "^5.0.45",
    "@aws-amplify/rtn-push-notification": "^1.1.7",
    "@react-native-async-storage/async-storage": "^1.19.3",
    "@react-native-community/netinfo": "^9.4.1",
    "@react-native-masked-view/masked-view": "^0.3.0",
    "@react-navigation/native": "^6.1.9",
    "@react-navigation/stack": "^6.3.20",
    "@rescript/core": "^0.5.0",
    "@rescript/react": "^0.11.0",
    "@sentry/react-native": "^5.11.1",
    "@urql/rescript": "^4.0.0",
    "amazon-cognito-identity-js": "^6.3.6",
    "graphql": "^16.8.1",
    "jsc-android": "^250231.0.0",
    "react": "18.2.0",
    "react-intl": "^6.5.1",
    "react-native": "0.72.6",
    "react-native-gesture-handler": "^2.13.4",
    "react-native-get-random-values": "^1.9.0",
    "react-native-gradle-plugin": "^0.71.19",
    "react-native-localize": "^3.0.2",
    "react-native-reanimated": "^3.5.4",
    "react-native-safe-area-context": "^4.7.4",
    "react-native-screens": "^3.25.0",
    "react-native-url-polyfill": "^2.0.0",
    "react-native-vision-camera": "^3.6.4",
    "rescript-react-native": "^0.72.0",
    "rescript-react-navigation": "^6.0.3",
    "rn-slide-button": "^1.0.3",
    "urql": "^4.0.5",
    "zustand": "^4.4.4"
  },

VisionCamera Version
3.6.4
Target platforms
Android
Operating system
MacOS
Can you build the VisionCamera Example app?
I didn't try (⚠ your issue might get ignored & closed if you don't try this)
Additional information

[ ] I am using Expo
[ ] I have enabled Frame Processors (react-native-worklets-core)
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

I could be wrong on this but, isn't RN going to be using Gradle 8 starting 0.73?

Hi @zzz08900, I'm using 0.72.6

Currently, a namespace is set (incorrectly) in build.gradle:
https://github.com/mrousavy/react-native-vision-camera/blob/f4617a3918783ff188c8b63f0694b1ad94ce3fae/package/android/build.gradle#L76
The .example needs to be removed.

No idea why I didn't run into this while testing vision camera v3 with RN 0.72 but yeah that does look like a bug.

Whoops my bad. Do we also need it in AndroidManifest.xml?

Related PR: https://github.com/mrousavy/react-native-vision-camera/pull/2104

Whoops my bad. Do we also need it in AndroidManifest.xml?

I think we also need that in AndroidManifest.xml if namespace is used and both need to match.
It appears @adolfogc also took care of that.


My Created Markets Bug

After creating a market and approving pre-liquidity I see a line in My Created Markets that says in reporting liquidity depleted.  (Also the All and Open show extra numbers in there)....see screenshot (only had created one market in fresh account)....Refreshing makes it go away

got this after creating my second market in that account

When a user creates a market, UI adds a placeholder so processing ... can be shown.
This placeholder isn't being removed, so it's still shown after market has been created.
not sure why this is happening after recent deployment.
looks like the transaction hashes aren't matching up so the UI doesn't have the data needed to remove the placeholder. Need to look more into it.

not seeing this anymore- closing


Calculate all leaf nodes for knownDirectSubclasses

Might fix #88.

Confirm, my test case for #88 passed with this :+1:


💡 [FEATURE] - Implement Persistent Dark Mode Across Website Pages

Idea Contribution

[X] I have read all the feature request issues.
[X] I'm interested in working on this issue
[X] I'm part of GSSOC organization

Explain feature request
Users currently have to re-enable dark mode on each page they visit, leading to an inconsistent and frustrating experience.
Explain your solution
Implement a feature that remembers the user's dark mode preference using localStorage. This preference will be automatically applied whenever the user navigates to any page on the website.
Any alternative approaches/features
No response
Additional Context
Benefits:
Consistent user experience across all pages.
Increased user satisfaction by reducing the need to repeatedly toggle dark mode.

@jfmartinz Kindly assign this issue to me under Gssoc


[Bug]: Profile tracking is not scrollable

Related Issue
fixes - #282
Description
fixed the scrollability of profile tracking  and adding no scroll to background as it was just scrolling the body if try to scroll
Type of PR

[x] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
https://github.com/ashutosh-rath02/git-re/assets/104522651/63ee78e0-9ead-49df-8e03-e1827f6d1985
Checklist:

[x] I have performed a self-review of my code
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Latish705 didn't fix the issue. So removing the tags, please raise another PR

@ashutosh-rath02 working on that , actually when u refresh the page its working that is the issue working on that


Remove the need for the .nib file

The primary reason for the .nib file currently is for the debug command. This change uses a tool to convert the docker-compose.yml into JSON which is then parsable by jq.
Resolves #38

This PR isn't completed because it appears that the help has been mangled by the changes. For example:
❯ nibdev run --help
Usage: nib run [SERVICE]

   Attach an interactive shell session to a running container Connect to a running byebug server for a given service Wraps normal 'docker-compose run' to ensure that --rm is always passed

Services:
   [ "foo", "web" ]

The description contains the description of several commands and the services are not printed in the desired vertical list.

The description containing several commands is an unrelated bug.

I think this is good to go now. Can you give it some 👀 @blankenshipz?

LGTM


Inventory: show equipments by types

Hello again!
To be more similar to units page, here is a PR to present equipments by types:

...

No name are shown, since there is, for now, no equivalent between internal type (e.g. greatSword) and full type name (e.g. Great Sword). Also it would have to be translated and all. So to keep it simple, only picture type is shown.
The async aspect was kept, but with types, the equipments are loaded by batch of same type (instead of batch of 20).
The materia listing is not modified, as the data currently doesn't allow us to discriminate between them (they all have materia as type). It would have been cool to sort by type as well (active, passive, etc...) like in game.

I like it !
For the materia, I hesitate. First, they are sorted alphabetically, to help input them, and in game, I never use the materia category, as they fell very lacking in pertinence most of the time... I mean, they could create a killer category, for instance, that would be usefull

Yes, the category are weird in game.
Maybe we can have our own useful categories?
The issue would be materia that falls into multiple categories (e.g. ATK passive + Killer...).

Note : I'm adding the jump list, please do not merge :wink:

I saw you comment just as I was going to merge it XD We're safe !

Done! It looks like this:

Merged an released ! Thanks !


Added fix for Issue 253 & Updated libphonenumber to 8.10.2

Suggested Fix for - https://github.com/patw0929/react-intl-tel-input/issues/253
Update libphonenumber-js-utils to 8.10.2
Updated package-lock.json -- npm start would be fixed as well.

@patw0929 can you upgrade the version of libphonenumber to 8.10.2
Then I will push yarn.lock & package-lock as well.

I still meet the issue of #253 (window is not defined) with this PR.

Oh, by the way, I had already published libphonenumber-js-utils to v8.10.2.

Coverage decreased (-0.1%) to 94.027% when pulling 49bb27ec41c3c5cb7d5dfb527492328f1ca89011 on superhit0:issue-253 into 76f2671aebe00157bb7d3ee287e19f0d31820c30 on patw0929:master.

It works!
Screenshot:

next.config.js
const withCSS = require('@zeit/next-css');

module.exports = withCSS({
  webpack: function (config) {
    config.module.rules.push({
      test: /\.(png|jpg|gif)$/,
      use: {
        loader: 'file-loader',
        options: {
          publicPath: '../../static/',
          outputPath: './static/',
        },
      }
    })
    return config
  }
});

attempt-to-import.js
import { Fragment } from 'react';
import IntlTelInput from 'react-intl-tel-input';
import style from 'react-intl-tel-input/dist/main.css';

export default () => (
  <Fragment>
    <style dangerouslySetInnerHTML={{ __html: style }} />
    <IntlTelInput />
  </Fragment>
);

@superhit0 Could you update yarn.lock?
Thanks!

@patw0929 updated yarn.lock