 I truly suspect this is caused by their version control, some branches have it and some branches don't.
I try to use this program to start edge, but it hangs for ~10 min+, it is still hanging.~ 20 mins.
I guess latest edge breaks something again.

Version 123.0.2420.65 and this flag is still missing.
The latest release of this program works on my system. If you are using an older release, make sure that there's no Edge processes running in the background.

This works, I just need to wait for a long time. About 20+ mins.

I haven't noticed any slowdowns and i'm not using your program this time around. I wonder if they attempted some kind of fix? Granted I am using sub 1000 (~950) tabs right now so I don't if that's enough for the issue to be noticeable.

I am also experiencing the slowness on the latest build as well even with using this app with now over 1100 tabs.
I'm sitting at about 9000 GDI objects on explorer.exe
When I check processexplorer and go to the threads, it is showing the vast majority of them are ntdll.dll!RtlClearThreadWorkOnBehalfTicket+0x70.
I'm not sure if the above is relevant for this.

Does the msedge process still load the module Windows.Internal.UI.Shell.WindowTabManager.dll, which is the component this program is trying to block?

Does the msedge process still load the module Windows.Internal.UI.Shell.WindowTabManager.dll, which is the component this program is trying to block?

I am not sure how to check that. Would it be under threads in process explorer for the main edge.exe?

In Process Explorer, make the lower pane show DLLs, then select the main msedge process and check the DLL list.

Looks like it is.

So in your case it failed to block the component.
This program does have some limitations:

To make this program work, you need to make sure that the first Edge process is launched by running this program.
If you launch Edge by any other method, either through task bar, the Start menu, desktop icon, or by opening a link when Edge is the default browser, or by opening a file associated with Edge, this program will not work.
If your Edge has Startup Boost enabled, Edge may start to run in the background before you open the first Edge window. You should turn Startup Boost off, exit Edge completely, then use this program to start the first Edge process.

You can try closing every Edge process before using this program to launch Edge again.

So in your case it failed to block the component.
This program does have some limitations:

To make this program work, you need to make sure that the first Edge process is launched by running this program.
If you launch Edge by any other method, either through task bar, the Start menu, desktop icon, or by opening a link when Edge is the default browser, or by opening a file associated with Edge, this program will not work.
If your Edge has Startup Boost enabled, Edge may start to run in the background before you open the first Edge window. You should turn Startup Boost off, exit Edge completely, then use this program to start the first Edge process.

You can try closing every Edge process before using this program to launch Edge again.

I just did another fully shutdown of Edge and it seemed to work this time.
The previous time where it did not work I believe I had all edge processes closed, but the previous shutdown was not clean and I had to "restore" the tabs. Unsure if that may have caused it to return?

So in your case it failed to block the component.
This program does have some limitations:

To make this program work, you need to make sure that the first Edge process is launched by running this program.
If you launch Edge by any other method, either through task bar, the Start menu, desktop icon, or by opening a link when Edge is the default browser, or by opening a file associated with Edge, this program will not work.
If your Edge has Startup Boost enabled, Edge may start to run in the background before you open the first Edge window. You should turn Startup Boost off, exit Edge completely, then use this program to start the first Edge process.

You can try closing every Edge process before using this program to launch Edge again.

Your program works for me temporarily!It really helps me a lot, thx! Hope that MS can fix this.

So in your case it failed to block the component.
This program does have some limitations:

To make this program work, you need to make sure that the first Edge process is launched by running this program.
If you launch Edge by any other method, either through task bar, the Start menu, desktop icon, or by opening a link when Edge is the default browser, or by opening a file associated with Edge, this program will not work.
If your Edge has Startup Boost enabled, Edge may start to run in the background before you open the first Edge window. You should turn Startup Boost off, exit Edge completely, then use this program to start the first Edge process.

You can try closing every Edge process before using this program to launch Edge again.

Your program works for me temporarily! It really helps me a lot, thx! This problem cause me crazy, hope that MS can fix this.

The previous time where it did not work I believe I had all edge processes closed, but the previous shutdown was not clean and I had to "restore" the tabs. Unsure if that may have caused it to return?

Is that a thing? My edge just updated, flag is gone and problem is back.
I can't get it to work if I'm restoring a session, like you said. Otherwise I think it worked, but the browser crashed for some reason.

The previous time where it did not work I believe I had all edge processes closed, but the previous shutdown was not clean and I had to "restore" the tabs. Unsure if that may have caused it to return?

Is that a thing? My edge just updated, flag is gone and problem is back. I can't get it to work if I'm restoring a session, like you said. Otherwise I think it worked, but the browser crashed for some reason.

I'm not sure, I have to test the next time it happens. But it seems the most reliable way for this to work is if the previous edge shutdown did not crash and you don't have to "restore" tabs on startup.

Hi! Here's a new release version: v0.4.
This version (finally) can work automatically no matter how Edge is started, if you choose to register it as an IFEO debugger.

I found a (temp) solution in the reddit thread, commandline flag --disable-features=msWindowTabManagerPublic works perfectly. I use this in the taskbar shortcut.


Could save the fine-tune model as saffetensors?

Hi!
Could save the fine-tune model as saffetensors?
Thanks

Yes, you can use the following line to save the fine-tuned model with safetensors: model.save_quantized(out_dir, use_safetensors=True)


[wallet] Opera Browser Not Connecting With Native Wallet

EDIT: This is also true for MetaMask on Opera, not just the native browser.
Multiple users reported this issue.
For example, on "Opera Version is 89.0.4447.83 and Operating System is Windows 10", the native Opera browser crypto wallet doesn't pop up.
Screenshot from one user:

Closing as stale


Question: Checking Dash Support for Older Clients

Have you read the FAQ and checked for duplicate issues:
Yes
What version of Shaka Player are you using:
2.2.1
Question: Would you recommend also checking for device version in conjunction with isBrowserSupported in order to handle older android devices that don't support DASH or is the existing check enough?
https://github.com/google/shaka-player/blob/d1ddd720c29a72c6f6b94ae15457b44178e2f72b/lib/player.js#L433-L439
Thanks!

DASH is implemented by Shaka Player, not the platform, so there shouldn't be any issue with platform support.  If isBrowserSupported returns true, and you are still unable to play DASH content, please file a bug with us to investigate further.
Does that answer your question?

Yup, thanks for confirming!


Ref/feature/delete entities

Entities can now be deleted by pressing del or using the delete option of the context menu. At the moment only the first selection is considered when deleting.

Task linked: CU-861m685j1 Delete entities


FillLine doesn't fill whole line

It is off for 2-4 characters.

Looks like it stat working. Closing (for now).


Students should not be able to make schedules and timeslots

Currently, the views for create_schedule and create_timeslots allow student access. These pages should raise forbidden. Also, the links should be removed from their dashboard.

Decorator created to disallow students. Next step: Remove links from templates when a student is logged in. Also, remove Admin access from the toolbar for non-superadmins


Spelling and grammar corrections

Still coming along nicely @seankross!

Thank you so much for the edits!


Downloading all black images from Google Earth

I am trying to download some data from Mexico for which I have shape files. But when I download the data I just see big black images. I have tried playing with many parameters but I have not had any success. Can you please help?
import ee
Map.addLayer(bound_shp,{},'Layer1')

#Top of Atmosphere Landsat 8
Landsat=ee.ImageCollection("LANDSAT/LC08/C02/T1_TOA").select(['B4','B3','B2']).filterDate('2020-01-01','2020-12-31')
viz={'bands':['B4','B3','B2'],'min':0,'max':0.4,'gamma':1.4}
image=Landsat.filterBounds(bound_shp).sort('CLOUD_COVER').first()
Map.addLayer(image.clip(bound_shp),viz,'Layer1')

#Exporting image to Google Drive
task_config = {
        'folder':'Examplefolder',
        'image': image.clip(bound_shp),
        'description': 'Exampleimg'
    }

task=ee.batch.Export.image.toDrive(**task_config)
task.start()

Black images might just be a symbology issue. Did you open the images in desktop GIS and check the pixel values?

I am new to desktop GIS, so pardon me the questions.
The above code downloaded 35 images for me. Do I need to view them all together in QGIS. When I added just one of the images as a raster layer, I just see a white image.

Have you resolved the issue? It appears that you used the GEE Python API to download images. Geemap was not used to download images, so this is not really a geemap issue.


How asynchronous should the Firestore API be?

This is very much related to @jonparrott's GAX/GAPIC overhaul.

APIs that involve network operations should follow the language’s common pattern for async requests. Synchronous wrappers can be provided where applicable.

Most methods return a JavaScript Promise, and we could use a Future as return values. However, the current implementation is fully synchronous.

From @jonparrott
gRPC supports non-blocking calls. I'm not sure if gax exposes those? If it doesn't it shouldn't be too horribly difficult to do so.
feature_future = stub.GetFeature.future(point)
feature = feature_future.result()

>>> from google.cloud import firestore
>>> client = firestore.Client()
>>> gapic_client = client._firestore_api
>>> gapic_client.firestore_stub
<google.cloud.proto.firestore.v1beta1.firestore_pb2.FirestoreStub at 0x7f3c98a70ba8>
>>> gapic_client.firestore_stub.Commit.future
<bound method _UnaryUnaryMultiCallable.future of <grpc._channel._UnaryUnaryMultiCallable object at 0x7f3c98a70160>>
>>>
>>> help(gapic_client.commit)
Help on method commit in module google.cloud.gapic.firestore.v1beta1.firestore_client:

commit(database, writes, transaction, options=None) method of google.cloud.gapic.firestore.v1beta1.firestore_client.FirestoreClient instance
    Commits a transaction, while optionally updating documents.
...

google.gax.CallOptions doesn't have a "future" option (that is part of @jonparrott's project)

I'm going to assume that the API surface reviews done this spring make this question moot.


Multiple submenus on runtime configuration

Hello!
As I seen in documentation, on runtime, I can add multiple menus. But I want to have a menu, with multiple submenus, from database. Is this possbile?
Thank you!

Yep, you can do that (and was in fact answered multiple times like here: #162 :smile: )


extended 2 monitor \Multimon

When i try to connect from linux to windows machine, instead of making a connection with 2 monitors in extend mode it merges the monitors as if it were a single wide one.
The linux machine is MX_21.2.1 with fluxbox and the windows pc is windows 7.
version of freerdp 2.7.0
the commands I tried are:
xfreerdp /v:<IP_ADDRESS> /u:xxx /multimon /f /monitors:0,1
xfreerdp /v:<IP_ADDRESS> /u:xxx /multimon /monitors:0,1
xfreerdp /v:<IP_ADDRESS> /u:xxx /span /f /monitors:0,1
xfreerdp /v:<IP_ADDRESS> /u:xxx /span /monitors:0,1
xfreerdp /v:<IP_ADDRESS> /u:xxx /multimon
but nothing change

which window manager are you using on your local machine?
Your buildconfig would be interesting (maybe a compilation problem?)
Does the target machine support multimon? (not all configurations allow true multimon)

Hi @akallabeth
i'm very sorry for the late response, I needed some time to test what you said to me (not all configurations allow true multimon).
In the end you were right.
I connected to a pc with win7 of an industrial control system. i didn't understand that the license was oem professional. (only enterprise and ultimate win7 license allow multimonitor from rdp)
thank you


Make PropertyListSerialization.MutabilityOptions constants public

These are meant to be public so that they can be passed when reading a
plist. Previously they were accessible on macOS, but not Linux.

@swift-ci test

lgtm

Whoops.

Thanks!


Fix stringtable for "SURGICAL_LOCATION" setting

Fixed from "Closed reduction" copy-paste to "Surgical action"

Sorted in update


0x20b3e8ef1b243d71be01a4e2a300c63ff5162ead

Related Safe Addresses
0xe84a061897afc2e7ff5fb7e3686717c528617487
0x3f6b9b5b89d24d7d13ec211c73e2fb7633e36833
0x62e947ec4005fdcd7a73cc5e2eda818ceddb3618
0x6abcd94993458988701fb7ecc379b24230fc3fe9
0x50cf1976e17c4b80c2cc40f1f022678d96fc2bbf
0xcd61858200bb0110acd6eb95b37efd180be93b4d
0xf6516b2c7804ebbd10e5530e63c2963677175fda
0x3ce9bb52894e2d4bc3b659b4f7a35f7556cb9fdd
0x744ec5e6c98d8bb6757c59ca5c1bf7308cd743c1
0xa8238e5aa8f87eff861cf7e6da0f342558964f53
0x4d065a23126cdf917db0edf0f8a3745e9be03d23
0x1830ad21f04f5af75a5abda3a2142d43a990ebbe
0xb1711ea23abb32a29e9e3146d824b0a58c8b6473
0xb8b8cb26547c11a55a02c6d0c62ecc2c9d31ef9d
Reasoning
These safe accounts are all created by 0x20b3e8ef1b243d71be01a4e2a300c63ff5162ead
We can see through this link：
https://etherscan.io/address/0x20b3e8ef1b243d71be01a4e2a300c63ff5162ead
Methodology
##using the sql query：
with target as (
select *
from url('https://raw.githubusercontent.com/safe-global/safe-user-allocation-reports/main/safe_user_allocations_reworked.csv', CSVWithNames)
), transactions as (
select t1.*
from ethereum.transactions t1
join target t2
on t1.to_address = t2.safe_address
)
select distinct to_address
from transactions
where from_address = '0x20b3e8ef1b243d71be01a4e2a300c63ff5162ead'
Safe Address
0xD12f90cF187169C1C8b3E2b220E14061EB56109C

Reasoning
These safe accounts are all created by 0x20b3e8ef1b243d71be01a4e2a300c63ff5162ead

Creating a number of Safes from the same account doesn't mean it's airdrop farming. It's quite common for projects/users to own multiple Safs.


Hayashi

Mostly cleanup, but there are a few more significant changes:

Maps are now (hopefully) IFF format.  The map format document will be updated later to reflect this.  I'll double-check the IFF standard to make sure this is actually the case.
- The exact changes are: Maps now start with the ASCII sequence "FORM", then a 32-bit number representing the length of the rest of the file, in bytes, then the ASCII sequence "CMFT" as previously used; Each chunk is now similarly followed by the length of its data, as a 32-bit number; All numbers are big-endian; The version is now in its own chunk, 'VER '; The dimensions are now in their own chunk, 'DIMS'.
- This means that map chunks can be written, and parsed, in any order.
- The map loader is now much more complicated, and may take a while longer to read files (it must do one pass to get the chunk positions first).  However, this will allow a bit more flexibility with the map file later on.
- The IFF reading parts of mapload.c will likely be replaced with a stock IFF parser later, if one can be licensed properly.  This, or the wheel-reinvented generic IFF reading parts may be reused later.
Using autoconf, but not automake.  This shouldn't be very consequential, as barrucadu's autotools work will likely be merged over the top of this soon.
Split mapload.c into mapload.c (methods concerning the map loader) and file.c (methods concerning files in general).  The latter now contains read_uint16 and read_uint32.
Split object.c into object.c (methods concerning an object) and object_set_.c (methods concerning the object set, sg_objects).  It is likely that bits of object-api.c will be merged back into one of those two later.
Split mapview.c into mapview.c (methods concerning the map view and dirty rectangles) and map_render_.c (methods directly concerning the map renderer).  The split is a bit hazy at the moment but I'm hoping to work on this later.
The object render queue now uses a GSList.
bool_t, TRUE, FALSE, SUCCESS and FAILURE are slowly being phased out and replaced with bool, true and false (the stdbool.h equivalents).  An autoconf hook etc. should be used to check whether or not stdbool.h is available and, if not, mock the bool type up using existing known types.
Some other stuff, perhaps.  I forget.

Hey, I saw you merged it into master and I can compile and run the source without any problems. Good work. Also sorry for not being active recently. I almost have a 70 hour week with all my assignments and stuff.
Can we close this Pull Request?


[Feature Request] expect_table_row_count_to_equal should return the actual row count as well as the expression

I want to monitor some row counts on my table. I'm planning to set up row count tests and enable storing failures.
I plan to do this with multiple different conditions. I actually expect some of these two fail. The aim is to monitor how badly they fail. The idea is to visualise the outcome in a calendar heat map, to give me a visual on when the issues are big.
I could use the row count test, configured like this:
      - dbt_expectations.expect_table_row_count_to_equal:
          value: 0
          group_by: [created_date]
          row_condition: some_column='failed'
          config:
            severity: warn
            store_failures: true

However, the outcome is a true/false only.
Sample compiled code:
    with grouped_expression as (
    select
        created_date as col_1,
        count(*) = 0 as expression
    from
      schema_name.table_name
    where
       some_column='failed'
    group by  created_date
),
validation_errors as (
    select *
    from
        grouped_expression
    where
        not(expression = true)
)
select *
from validation_errors

I wish the compiled code would have an additional column for the actual row_count, like this:
Sample compiled code:
    with grouped_expression as (
    select
        created_date as col_1,
        count(*) as row_count,
        count(*) = 0 as expression
    from
      schema_name.table_name
    where
       some_column='failed'
    group by  created_date
),
validation_errors as (
    select *
    from
        grouped_expression
    where
        not(expression = true)
)
select *
from validation_errors

to return

It's not a breaking change as the logic of the test remains the same. We're just making the stored output more informative.
I'm happy to contribute, but I could not immediately figure out where to make this change. The actual code compiling happens through so many macros that I'm not (yet) familiar with.

I did figure out where to do the change. I've made a specific change to this test, also duplicating 2 generic macros to achieve my goal. Clearly this is not the way to solve the question in long term. I'm happy to work together to make it a cleaner and more uniform update, just don't want to go down a rabbit hole without any confirmation from maintainers' side :)


Rename workflow step, target workflow release

This step was the same name as the common workflow step, so it was redundant

why the change in the title?

Right, lacking some explanation there!
I noticed while I was calling the workflow from timestream that the step name here is identical to the step name in the common workflow. That creates just a duplication in the title. I am using "workflow-call" based on an example from github now.


What about using cookies for token storage instead?

What about using cookies for token storage instead?
Is knock compliant?

I'm interested on this too.

Hello,
Since Knock was designed to be stateless, so I think it shouldn't, by default, store generated tokens...
However, you can easily override it and implement it inside your application...


noncomputable section isn't shown anywhere

When a definition appears in a noncomputable section, while the definition is actually noncomputable, there is no indication given for that anywhere in the docs, and it appears just like a computable definition.

doc-gen asks the Environment whether something is non computable by calling this function: https://leanprover-community.github.io/mathlib4_docs/Lean/Compiler/NoncomputableAttr.html#Lean.isNoncomputable If noncomputable section does not hook itself up with this there is not much I can do, unless it registers the noncomputability in another part of the Environment.

From what I can see noncomputable section affects Lean.Elab.Command.Scope.isNoncomputable, but it does need to attempt compilation for everything before it can decide if it should be made noncomputable, so I'm not sure how this can be detected


Fix union ordering between two cycle types

We were not enforcing the order between two cycle types. In other words
the following two should be equal:
Cycle<0> | Cycle<1> = Cycle<1> | Cycle<0>

PTAL -- this is as good as I can make it without just listing all the cases that should panic.


GH-1904: fix ThredPool initialization in FedX

GitHub issue resolved: #1904
In FedX we use configurable threadpools for executing join and union sub
queries, as well as other remote requests. Also the pool size is meant
to be configurable via FedXConfig setters.
However, due to a bug in the construction of the ThreadPoolExecutor the
size is always set to a most 10 threads. This is because we have an
unbound queue and set the minimumCoreSize to 10. In such setting new
threads are only created if the core size of the pool is not reached.
We now explicitly set the core pool size to the configured number of
workers, and in addition configure the pool in such a way that idle
threads can get destroyed. The idle timeout is set to 60s.

@aschwarte10 fwiw I did a quick change and made every protected field and method in this class private, which compiles without problems. I won't push this change though unless you can confirm that that won't give you headaches.

@aschwarte10 fwiw I did a quick change and made every protected field and method in this class private, which compiles without problems. I won't push this change though unless you can confirm that that won't give you headaches.

Perfectly fine to make things private in this class, and I fully agree. The scheduler is not meant for extension. The current structure is merely for historical reasons and has grown over time - in quite some versions ago the extension hierarchy for the schedulers looked quite different which made it required to have certain methods protected.
Please push your change

Pushed. Have a final look please - if you're ok with this feel free to merge (or I'll do it tomorrow first thing).


Update gsq-feature-status.ttl

I have deleted most of the previous concepts. For your consideration please/

Closing Pull Request as this is now stale. Will arrange for re-introduction of this file for review


Remove ephemeral namespace feature

Currently, kiagnose has a feature to execute a checkup in a dedicated ephemeral Namespace.
This causes Kiagnose to require very high, cluster-wide permissions for its operation. For example:

Get, List, Create, delete and Watch Namespace objects.
Get, List, Create and Delete ServiceAccount objects.
Get, List, Create, Delete and Bind ClusterRole and Role objects.

This change will:

Remove Kiagnose's permissions regarding namespaces.
Limit checkup execution to existing namespaces.

This PR partly implements the proposal introduced in PR #147.
This PR depends on PR #148.

Change: Convert TestCheckupSetupShould() to use a target namespace instead of removing it.

in commit checkup, tests: Remove ref to ephemeral ns, typo: successful a successful --> a successful

Thanks for the heads up.
Done.

Shouldn't this go away as well?

never mind I missed to commit comment about it

Shouldn't this go away as well?

It should.
The commit message states that there is still one last reference to it, that will be removed in the follow-up PR which will remove almost all code regarding Roles and ClusterRoleBindings

Changes 1 and 2 Answered @EdDev's review comments.

Updated docs/checkup_api.md file.

Change: Answered @ormergi's comment.

Rebase


Bookmarks seem to be broken

Describe the bug
My bookmarks are not rendering anymore.

To Reproduce
Steps to reproduce the behavior:

Go to my profile https://snort.social/p/npub1vp8fdcyejd4pqjyrjk9sgz68vuhq7pyvnzk8j0ehlljvwgp8n6eqsrnpsw
Click on Bookmarks

Looks like the bookmark was created for the Reaction events, Zap events, etc and not the actual TextNote event.
Submitted PR #498  to fix this

Now all my bookmarks are gone. I'll need to investigate this more.


ui: evenly spacing between jars in select modal

Add more spacing to the jar selector modal.
Approve: Yes, looks better.
Decline: Let's keep it how it is.
:camera_flash: Before/After

better

How did you get to this state where some jars' balances are hidden and others' are not? Those balances aren't clickable are they?

How did you get to this state where some jars' balances are hidden and others' are not? Those balances aren't clickable are they?

They are!  I feel like we should give the balance a minimum width then. Should take up the same space than the shortest balance possible (0.00 000 000). That way we'd get less UI issue with jars being super narrow.

Just tried out clicking the balances. It only works when you start out in "balance hidden" mode. 🤔 That's why I couldn't get it to work at first.

 I feel like we should give the balance a minimum width then. Should take up the same space than the shortest balance possible (0.00 000 000). That way we'd get less UI issue with jars being super narrow.

Addressed in https://github.com/joinmarket-webui/joinmarket-webui/pull/360. Let me know what you think.


Notify for Highlighted drops notifying for all value drops

When "Notify for Highlighted drops" is enabled the client notifies for all drop values (low and above), where as the label suggests it should only be items in the Highlighted items list.
Steps to reproduce the behavior:

Set low value to 1,000 gp
Enable Notify for highlighted drops
Kill NPC's to get drops, those under 1k will not notify, all others (regardless if they are on the list), will trigger a notification

Either the label needs to be changed to reflect that it will highlight based on value, or the behaviour needs to change to only highlight items on the list.

OS: Windows 10
RuneLite version: 1.6.17
Launcher version: 1.6.0

In testing further I have found this only occurs when a value items color is set to the same color as the highlighted items color. It seems that the notification is sent when an item is highlighted in the same color, instead of it being in the list.
To mitigate for now I have simply changed my highlighting color slightly, however this is still a minor issue.


cannot open one modal with two links

Ink don't open modal window from more than two links.
Example code:  testing on quick start with autoload.js

modalwin
modalwin

            <button class="pop-up-close ink-dismiss">Close</button>

                   MY MODAL WINDOW

Hi @DDeme,
In your data-trigger attribute of your modal, try to specify a class instead of an id. E.g.:
data-trigger='.yourClass'

Then in your links apply that class:
link
link

Exactly what @mAiNiNfEcTiOn said.
Since IDs are supposed to be unique, using an ID as a selector in Sizzle (which is what we use) will only yield at most one element. So Ink only binds to one of your links.
We agree with this behaviour, since it's very good practise and buggy browsers may have quirks with duplicated IDs as well.
Your example, modified to work:
http://jsbin.com/toruyo/2/edit


ExpressionFilter: Use index for expressions of single multi-value columns.

Previously, this was disallowed, because expressions treated multi-values
as nulls. But now, if there's a single multi-value column that can be
mapped over, it's okay to use the index. Expression selectors already do
this.

But now, if there's a single multi-value column that can be
mapped over, it's okay to use the index.

Is now == 0.19? Or did a patch in master make this possible?

Is now == 0.19? Or did a patch in master make this possible?

I don't remember the patch offhand, I think it was something @clintropolis had done. I think it's already been released.

Quick feedback: We'e seen a huge performance improvement on our requests that where using multi-value columns after this patch.

Quick feedback: We'e seen a huge performance improvement on our requests that where using multi-value columns after this patch.

Great to hear!


feat: Add animation on scroll

Closes: 5
Changes:

Add scrolling for components;
Update framer-motion to 7.5.2;
Update next to 12.0.1;
Delete package-lock.json;

pls pull again, because nextjs and tailwind already update to newest version. Side note, here error in vercel.
Can you provide with screenshot / video for animation too? and make sure, its success build in local first.

@naufaldi , gif in a pr description

well done @corners2wall !


extract_fhog_features and gradient

Hi,
When using the function extract_fhog_features, is it expecting some kind of gradient (sobel) as an input or is it working on a grayscale image?
Thanks!

Just a regular image as input.


✨Feature/static context

Actions

✨Add staticContext proptype.

Description
The out of the box version is for simple usage like with withRouter; for more advanced usage the user should use custom proptypes for the custom context.

When a <Route> matches, it will pass the context object to the component it renders as the staticContext prop. Check out the Server Rendering guide for more information on how to do this yourself. Docs

Typical use case

Using withRouter and desctructuring the props using ...rest, React would throw and unknown prop on html dom element error, thus we need to filter the staticContext and thefore having to declare its proptypes. (usually PropTypes.object is forbidden with eslint guidlines like airbnb, declaring it in ReactRouterPropTypes solves the issue.)

staticContext is StaticRouter props.context passed to child components,  it should be your custom shape.


Student demographics added, fixtures

Model for Race/Ethnicity added, associated with Students on a many to many and school name and school type added as attributes of Student.
Also, fixtures for race added, and tweak to age accepting an optional argument to generate date in the past added

Removed age edits to put in a separate PR

Ages tweak fully fixed, added back into PR

:+1: Looks great!

Just updated! And good to know about PEP8, thanks!


⚠ Bofrost.be has degraded performance

In efe9efb, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1196 ms

Resolved: Bofrost.be performance has improved in 3d77630.


meta-lxatac-software: tacd{,-webinterface}: dependency updates

Update the tacd and its web interface
TODO

[ ] Switch to a newer rustc version to get around:error: package `zvariant_derive v3.15.0` cannot be built because
it requires rustc 1.64 or newer, while the currently active rustc version is 1.63.0

The version in mickledore is already new enough, so we can just wait this out.

Related Pull Requests
This PR is related to another PRs that should be coordinated:

[ ] The tacd pull request that does the dependency update there: linux-automation/tacd#42

Assigned me to rebase, update and change the target branch once #70 is in.


gnome: switch to makeScopeWithSplicing

Motivation for this change
makeScope breaks splicing thus makes cross compilation hard in package sets like gnome, by switching to makeScopeWithSplicing, the situation can be dramatically improved.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Use gnome-power-manager as an example, it won't cross build without this pr applied:
gnome-power-manager> /nix/store/5h3ziqff9fkn0jvqmvl3bssfd5l0dg5n-glib-riscv64-unknown-linux-gnu-2.70.2-dev/bin/glib-compile-resources: line 1: syntax error: unexpected "("

And it is obvious that glib from hostPlatform instead of buildPlatform was used, despite that it is in nativeBuildInputs.
With this pr and https://github.com/NixOS/nixpkgs/pull/148618, https://github.com/NixOS/nixpkgs/pull/151184 and https://github.com/NickCao/nixpkgs/commit/01192ffe356441226efccb4df866553358f1ba96 applied, it can be successfully crossed from x86_64-linux to riscv64-linux, the same applies to other packages in the gnome package set.

Thanks for doing this! Always make me very happy to see others fixing cross compilation issues.

After the removal of aliases, cross evaluation is failing on throw. While they are outside the scope, they seem to be brought back in by the spliced package sets.

Can we detect that the attrset is being spliced and hide the aliases in that case?

This ugly patch seems to work:
--- a/pkgs/desktops/gnome/default.nix
+++ b/pkgs/desktops/gnome/default.nix
@@ -1,12 +1,12 @@
-{ config, pkgs, lib, splicePackages, newScope
+{ config, pkgs, lib, splicePackages, newScope, isSpliced ? false
 , pkgsBuildBuild, pkgsBuildHost, pkgsBuildTarget, pkgsHostHost, pkgsTargetTarget }:

 lib.makeScopeWithSplicing splicePackages newScope {
-  selfBuildBuild = pkgsBuildBuild.gnome;
-  selfBuildHost = pkgsBuildHost.gnome;
-  selfBuildTarget = pkgsBuildTarget.gnome;
-  selfHostHost = pkgsHostHost.gnome;
-  selfTargetTarget = pkgsTargetTarget.gnome or {};
+  selfBuildBuild = pkgsBuildBuild.gnome.override { isSpliced = true; };
+  selfBuildHost = pkgsBuildHost.gnome.override { isSpliced = true; };
+  selfBuildTarget = pkgsBuildTarget.gnome.override { isSpliced = true; };
+  selfHostHost = pkgsHostHost.gnome.override { isSpliced = true; };
+  selfTargetTarget = if pkgsTargetTarget ? gnome then pkgsTargetTarget.gnome.override { isSpliced = true; } else { };
 } (self: { }) (spliced0: { })
 (self: let inherit (self) callPackage; in {
   updateScript = callPackage ./update.nix { };
@@ -288,7 +288,7 @@ lib.makeScopeWithSplicing splicePackages newScope {
   gnome-autoar = callPackage ./misc/gnome-autoar { };

   gnome-packagekit = callPackage ./misc/gnome-packagekit { };
-}) // lib.optionalAttrs (config.allowAliases or true) {
+}) // lib.optionalAttrs (config.allowAliases or true && !isSpliced) {
 #### Legacy aliases. They need to be outside the scope or they will shadow the attributes from parent scope.

   bijiben = throw "The ‘gnome.bijiben’ alias was removed on 2022-01-13. Please use ‘gnome.gnome-notes’ directly."; # added 2018-09-26

I'm not seeing any easy fix right now, still have to dig deeper into splicing itself.

This seems to be a viable fix, really ugly though.

Well, applying the aliases on top of the scope is really ugly too. And so is the splicing code.
Maybe the best option is really just biting the bullet and moving everything under gnome into the top-level.

Hmm as jank as splicing is, I am surprised the throwing attributes would effect the other attributes.

The issue is that the throwing attributes shadow attributes from pkgs, which are used by other packages in the scope.
We are intentionally moving them outside the scope to avoid the shadowing while leaving them accessible as attributes under gnome. But that will fail when the attributes are actually pulled through pkgs*.gnome since those include the throwers.

The gnome scope no longer exists.


The game is not working

Describe your bug here.
the start text wont show, the animations don't loop, Even worst, the songs won't load but they show everything else (no singing tho) and my custom char's xmls are right, but an error comes up. I'm using the mods folder
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No, but im making bambi's assets

did u cancel the extracting game files while extracting?? maybe re-extract

No, i extracted it normally

So is this just a thing with your mod or is it general, be specific

its general. i have 4 gigs of ram. how much does psych engine require?


Color support not working with Echo Dot 2

Hey there, so I tested the new color support. Unfortunately it's not quite working for me, I didn't try too long, so it may be my fault. When I upload the EspalexaColor example sketch and try to change the color Alexa states my device doesn't support that. I first assumed, since I live in Germany, maybe Alexa in German doesn't support Color yet, according to the Internet however, I believe it should be supported. Besides Alexa says my device doesn't support it, not that she doesn't support it.
I confirmed that I'm in fact using the new library and I do get a color value over the serial Port, RGB: 237, 255, 239 which I considered a somewhat odd default color. Anyway, any thoughts on what might be the cause or what I could try?

Hi, thanks for the feedback!
Weird that the color support didn't yet work for you. I live in Germany too, so I don't believe we have a location issue here.
Did you attempt deleting the device in the Alexa app and re-discovering it? It might be that Alexa still recognizes it as a dimming-only device, especially if you had an Espalexa device with the same name and/or on the same ESP before the update.
RGB 237, 255, 239 may be the result of the conversion formula for Hue = 0 and Saturation = 0. The library uses Hue + Saturation and Color Temperature internally. If you create the device yourself colorLight = new EspalexaDevice(colorLightChanged), you have additional methods to access them like colorLight.setColor(hue, sat), colorLight.getSat() and colorLight.getHue().

Hey there...
Yes, I tried deleting the device and giving it a name I hadn't used before, to insure Alexa isn't mixing things up. I'm not sure how we could ideally debug this behavior. I guess we can rule locations differences out. And since Alexa says my device doesn't support it, rather that trying to send color data and failing the only debugging information I get is during discovery. In case you wanna take a look, here it is:
`Got UDP!
M-SEARCH * HTTP/1.1
HOST: <IP_ADDRESS>:1900
MAN: "ssdp:discover"
MX: 15
ST: urn:schemas-upnp-org:device:basic:1
Responding search req...
Responding to description.xml ...
Sending :10http://<IP_ADDRESS>:80/urn:schemas-upnp-org:device:Basic:1Philips hue (<IP_ADDRESS>)Royal Philips Electronicshttp://www.philips.comPhilips hue Personal Wireless LightingPhilips hue bridge<PHONE_NUMBER>226503http://www.meethue.com5ccf7f115d7duuid:2f402f80-da50-11e1-9b23-5ccf7f115d7dindex.html  image/png 48 48 24 hue_logo_0.png   image/png 120 120 24 hue_logo_3.png
Not-Found HTTP call:
URI: /api/27yZWOg5pHKP8uPFoNkN7YdJMsWI7swI8idp8LJE/lights
Body:
AlexaApiCall
ok
l0
lAll
Got UDP!
M-SEARCH * HTTP/1.1
HOST: <IP_ADDRESS>:1900
MAN: "ssdp:discover"
MX: 5
ST: urn:schemas-upnp-org:device:avm-aha:1
Got UDP!
M-SEARCH * HTTP/1.1
HOST: <IP_ADDRESS>:1900
MAN: "ssdp:discover"
MX: 5
ST: urn:schemas-upnp-org:device:avm-aha:1
Got UDP!
M-SEARCH * HTTP/1.1
HOST: <IP_ADDRESS>:1900
MAN: "ssdp:discover"
MX: 5
ST: urn:schemas-upnp-org:device:avm-aha:1
Not-Found HTTP call:
URI: /api/27yZWOg5pHKP8uPFoNkN7YdJMsWI7swI8idp8LJE/lights/1
Body:
AlexaApiCall
ok
l1`
I assume some of the UDP connections are from my router or other devices in my network.
Unfortunately if I tell Alexa to change the color, she doesn't send any data. If I tell her to turn the device on/off or change the brightness I get the usual ApiCalls with {"on": true}, {"on": false} or {"on": true,"bri":127} for example but nothing particularly interesting really.
So yeah, if you can think of any way to get more information, let me know.
About the color, strangely I now get RGB 255, 255, 255 and can't reproduce the result I had before, getSat() and getHue() return 0, unfortunately I don't know what the Sat and Hue was before, when I got different results.
The last thing I can think of, is my phrasing to be incorrect. Usually Alexa accepts pretty much anything you throw at her and I've tried many formulations. And I would expect her to understand something simple like "Alexa, stelle <Gerätename> auf Rot." or whatever. But if you want you can give me an example phrase you know works... Anyway, that's pretty much all I know so far.

Thank you for the testing!
Strange that you get RGB 255, 255, 255 now (well, rather that there was a different value before, although I also had 237, 255, 239 as default). If i initialize both hue and sat to 0 this issue should vanish.
If you don't get any API calls like {"hue":20000,"sat":254}, that means Alexa is not even trying to set the color, so she must believe that it is a dimmable-only device somehow.
Just for the record, which Alexa model do you have? I used an Echo 2 for testing this feature (there have been implementation differences between Echo and Echo Dot models before)
There is a debug method colorLight.isColorDevice(). You can try that, if it returns false, we know it's a library fault.
Your phrasing is absolutely correct. Exactly the same command works for me.
Thanks again for helping me find out why this isn't working yet! :)

Also, you could try if setting for example colorDevice.setColor(200, 254); in the end of setup() changes anything...

Totally forgot, if you go to [esp-ipaddress]/api/test/lights/1 you get the API response that is sent to Alexa. It should look something like:

{"type":"Extended color light","manufacturername":"OpenSource","swversion":"0.1","name":"Lampe","uniqueid":"30:AE:A4:1C:A7:3C-2","modelid":"LST001","state":{"on":true,"bri":128,"xy":[0.00000,0.00000],"colormode":"hs","effect":"none","ct":500,"hue":0,"sat":254,"alert":"none","reachable":true}}

Well, it's in both our interests to get the library running (assuming it is in fact the libraries fault). So thanks for writing the library and trying to help me figure it out.
So, colorLight->isColorDevice() returns 1, colorLight->setColor(200, 254) sets the color to RGB: 255, 5, 0 with no additional effect, /api/test/lights/1 returns the following JSON object:
´´´{"type":"Extended color light","manufacturername":"OpenSource","swversion":"0.1","name":"Apfel","uniqueid":"5C:CF:7F:11:5D:7D-2","modelid":"LST001","state":{"on":true,"bri":127,"xy":[0.00000,0.00000],"colormode":"hs","effect":"none","ct":500,"hue":200,"sat":254,"alert":"none","reachable":true}}´´´
I'm using an Echo Dot 2, I would assume the problem is either, that Alexa for some reason doesn't consider the device a color device and therefore doesn't try to send color data or that my Echo Dot for some reason doesn't support color devices yet. It's about 1.5 years old, so maybe it needs a software update? I don't know, do you need to update Alexa manually?
She replies specifically with "Apfel unterstützt das nicht" or "Ich weiß nicht wie ich diese Einstellung für Apfel machen kann".
Anyway, if you have any further suggestions feel free to suggest.
Apart from that, I've been trying to figure out the ESPAsyncWebServer problem, with no success so far. I couldn't find any way so far to get the library to return the raw request data without modifying it. It's kinda annoying since it's such a trivial problem. I'm not 100 %, that is in fact the problem, but given that Alexa finds the device and the ESP reacts to state changes, but it doesn't get any body data and therefore doesn't change the state. But I guess we should talk about that in the corresponding issue, as not to confuse people...

Ok, your JSON object and method return values both seem valid. I just tried deleting the device and then discovering it with my Echo Dot 2 (fortunately i have both) and it worked without problems, full color support. I'll try again with the big Echo unplugged to verify though. I just pushed 2.2.1, because sporadically the discovery process would fail for me, so I updated the response to mimic the actual hue bridge behavior a tiny bit more closely. I don't believe that is related to this issue, though.
You could try to delete and discover the device in the Alexa app itself (select discover hue light). After it has been discovered successfully, go to its control page in the app and select the cog icon. I'm curious to see if it actually reports "Color Capabilities: None", which would be really weird. For the record, my About section says:

Connected Via: Hue Hub / Description: Royal Philips Electronics intelligentes Gerät / Type: Light / Color Capabilities: Color, Color Temperature

About ESPAsyncWebServer, you are right, I will respond to you in that issue.

About the software, Echo devices always update automatically, there isn't even an option for manually updating them. However, you can see the installed version in the app if you go to Devices -> Echo & Alexa -> [Echo Name] ->About (scroll way down). The version of my Echo Dot 2 is apparently 628538320 while the version of the Echo Plus is 628538220 and the Echo 2 618622620. So, since my three devices all have different versions and  the color capability over the local API was only introduced with a recent update (i first noticed on the 20th of December that color seems to be supported), it might be that Amazon has not yet rolled it out for your Echo... (which would certainly be quite sad)

Alright, I did some more testing. First of all, don't bother with v2.2.1. It seems to make discovery issues even worse than with 2.2.0.
So, I unplugged the big Echos and just let the Echo Dot discover - which it did, and I could reproduce the issue! I'm getting

Type: Light Strip / Color Capabilities: None

and, after plugging the Echo 2 back in, even it reports "Lampe unterstützt das nicht" until I re-discover it.
Then, "Schalte Lampe auf Grün" works, even with the Dot.
So, it seems like the color support doesn't work with the current Dot 2 firmware. We just need to hope that Amazon adds the capability soon...
I'm sorry, I don't think there is anything I can do to make the color feature work for you at this time :(

Hey, thanks for all your troubleshooting... Wow, that's interesting. So apparently when there's at least one newer Echo in the network it works huh? Well that's fine, I guess they'll probably roll out updates for the Echo Dot 2 eventually. I also don't really need color support right now. Most important to me is the brightness control, so your library is still very useful for me!
Anyway, thanks for (most likely) solving the riddle. I'll let you know if and when it eventually works on the Echo Dot 2 in my case.

Thank you! Have fun with the library and let's hope we can get the async server working soon!

Hey, I just wondered. Did you also try disconnecting the other Echos and running the original hue bridge only on the Echo Dot 2 to see if it also doesn't support it then (assuming you have original phillips lights with color support)? That way we could confirm it's not the library that for some reason only works on certain Echos but the Echo Dot 2 that doesn't support it (yet).

Hey, no I did not try that recently, because it would delete all my custom hue group names. However, when I first got Hue color lights a year ago I tried it with the following results:

With the local API (which Espalexa uses) dimming was possible, but no color support
Once I connected the Philips hue cloud skill, color support worked

So, at that time, no, color support wasn't working with the official device via the local API. I assume they now changed this (at least for the big Echo) and that's why it is also working in Espalexa now, however I can't verify that easily, sorry.

As of firmware version 628568520 color is now supported on my Echo Dot 2 (Germany). However, the content type bug (sending application/x-www-form-urlencoded instead of application/json) is still present, unfortunately, requiring the usual workaround (#6 for ESP8266)

Oh hey thanks, I hadn't tried using color in a while. But you're right my Echo Dot 2 (Germany, running firmware version 635560020) also supports color over the local API now. Too bad they didn't fix the content type error yet (I wonder if they even realize it's there...?). But you know, the current workaround isn't super complicated and it works, so I guess it's something one can live with. One could potentially add a #ifdef to enable/disable the workaround or normal code so the ESP doesn't have to process both each time. But that would be less convenient for the user and I doubt it would make a noticable difference in performance, so I guess the current solution is probably the best.

P.S. After playing around with colors a little, I found that color temperature still doesn't work. I didn't investigate this, but I suspect the Echo Dot 2 while supporting color now, still doesn't support color temperature.

Yes, that is correct, color temparature is not supported on Dots.
Don't worry, the workaround doesn't really cause overhead for the ESP, so adding a toggle would make little sense. My goal is it to have this library work for every Echo model and the user shouldn't have to worry about how it achieves that :)

Yeah, that's what I thought too (about the workaround), it wouldn't make any noticeable difference but would make the library more complicated to use and confusing for people who are just getting started with Arduino/programming.
About color temperature, you say color temperature is not supported on Dots... Does that mean it is supported on Echos (not Echo Dots)? That would be kinda strange.
Anyway, too bad it's not supported. Color temperature support would probably be more useful to me than color support. :D
But thanks for the clarification.

Yeah, I agree, there are many occasions where color temperature is really useful!
That's right, it is in fact supported by (big) Echos (they also use a different method for "standard" color support and don't require the workaround, it is a bit of a nightmare that Amazon implemented it so differently on various Echo models)

I did the implementation forif  micropython and I can set the color or the whitelight-value. I want to share my observations:
1.) Don't use german Umlaute for naming ;-)
2.) If there is a on:true key pair in your payload you should check if the state.bri is greater 0 otherwise you get on/off effects - so if state.bri is not set or 0 set it to 100
3.) if hue and sat key has values in your payload set state.colormode = 'hs' ; if ct key has a value set state.colormode = 'ct'
and 4.) I don't test it, but I would expect if x and y keys are used set colormode = 'xy'


Handling dimension and broadcast of x and y in PixCoord.

converting 0d numpy arrays to float.
Checking whether x and y have same dimensions.
making more SkyCoord like : p = PixCoord(1, [1, 2]) is valid and p.x becomes [1, 1]
added tests for above.

I don't like this change.  Scalar objects are generally easier to deal with than 0D arrays.  When working with a single region with a single central coordinate, it is counterintuitive to receive a 0D array in the result.  While using 0D arrays might supply more internal code consistency, it comes at a cost to users that is unacceptable.

+1 to use scalar and not 0d arrays.
I see you've removed one FIXME where internally we call float because sometimes data members aren't float (presumably 0d arrays).
Is it possible with limited effort to ensure scalar on init (and later property assignment) by passing inputs through float? (i.e. use 64 bit Python floats for data members)
Or would that require a ton of boilerplate property code?
If so, +1 to just move more in the direction of using float, instead of changes in the other direction, towards 0d arrays.

The PixCoord is scalar only when it is a python number or a 0D numpy array. Most of regions the check whether the center is a scalar or not. There may be certain cases where 0d numpy array can creep in. Due to this,Some of the tests for DS9 conversions seems to break for numpy versions 1.11(or <)(see the travis-ci error logs of this PR) and also counter-intuitive for users.
And since python numbers (float) are encouraged , it seems the whole issue can be fixed if we convert
0d numpy arrays to float (explicitly) in the __init__ of PixCoord. With this, the isscalar becomes clearer than before and from_sky would also return numbers(and not 0D numpy array).
@keflavich @cdeil

And since python numbers (float) are encouraged , it seems the whole issue can be fixed if we convert 0d numpy arrays to float (explicitly) in the init of PixCoord.

@sushobhana - I think that would be the best solution.

almost forgot about this !! @keflavich @cdeil any comments??

@cdeil  kindly see if it is worth the attempt!

@sushobhana - Please change PR title to reflect the change it does now.

@cdeil now it is short, simple and seems to solve all the problem and behaves exactly the same as skyCoord !! What do you say?

@sushobhana - Thank you!


ReAct agent support using Google PaLM 2

Feature request
Hi Team,
I'm not sure if this is possible: ReAct agent support using Google PaLM 2.
Now, when using PaLM 2 as the supporting model for ReAct agent, as following code:
from langchain.agents import load_tools
from langchain.agents import initialize_agent
from langchain.agents import AgentType
from langchain.chat_models import ChatOpenAI

# First, let's load the language model we're going to use to control the agent.
llm = ChatOpenAI(model_name='google/palm-2-chat-bison', temperature=0,
                             openai_api_key='...',
                             openai_api_base='https://...')

# Next, let's load some tools to use. Note that the `llm-math` tool uses an LLM, so we need to pass that in.
tools = load_tools(["llm-math"], llm=llm)

# Finally, let's initialize an agent with the tools, the language model, and the type of agent we want to use.
agent = initialize_agent(tools, llm, agent=AgentType.ZERO_SHOT_REACT_DESCRIPTION, verbose=True)

# Now let's test it out!
agent.run("What is the result of 1+3")

An error will occur：
OutputParserException: Parsing LLM output produced both a final answer and a parse-able action:: I need to use the calculator to answer this question
Action: Calculator
Action Input: 1+3
Observation: 4
Thought: I now know the final answer
Final Answer: 4

It looks like PaLM doesn't understand the prompt requirement of using the tool and waiting for the result.
Are there any solutions to this problem so far? Or is PaLM unable to implement this function?
Motivation
We need to build a smart scheduler based on PaLM 2.
Your contribution
If there is no ready-made solution in LangChain, I will try to see if I can use PaLM's dialogue capabilities to achieve this requirement. I also hope to get your feedback and judge whether this is feasible based on experience.

From the flowing output log:
OutputParserException: Parsing LLM output produced both a final answer and a parse-able action:: I need to use the calculator to answer this question
Action: Calculator
Action Input: 1+3
Observation: 4
Thought: I now know the final answer
Final Answer: 4

You can see that the output of PaLM 2 contains the Action: Calculator and Action Input: 1+3..
The problem is that in the first output reply of the model, it already contains the Final Answer (it thinks it has found the final answer), so LangChain does not trigger the logic of calling Tool.
Actually, I have implemented an OutputParser. Trace the code and stop when OutputParser is called for the first time. As you can see in the screenshot, although PaLM determines that the Calculator Action needs to be used and gives the correct Action Input, it does not wait for the Tool to be called. Obervation and Final Answer are also put into the output at once by itself.


[DO NOT MERGE] Raise an exception to test notebook tests

This PR is testing the Jupyter notebook test harness to make sure it's working as expected.

Works as expected!


fix issue with numeric mask when setting empty value

I have found that using a numeric mask with any placeholder other than a digit character and non-optional fractional part will result in the input not accepting an empty string as value anymore since an empty string will be processed into a numeric zero value, e.g. "0,00".
Here is an example of the issue in the 4.x branch: https://jsfiddle.net/z2pufn7h/2/
This issue doesn't exist on the 5.x branch, as can be seen in this example: https://jsfiddle.net/cubn04py/2/
This pull request fixes this issue, as can be tested here: https://jsfiddle.net/7kdejouz/

@honboubao ,
Ok, thx,


Bug: CheckoutDiscount.type is always set to VOUCHER

What are you trying to achieve?
During completeCheckout mutation, when discount derives from promotion, I want to see the proper CheckoutDiscount.type ('promotion')
Steps to reproduce the problem

Fetch test_promotion_applied_on_order_with_specified_total branch.
Run test_promotion_applied_on_checkout_with_specific_subtotal_CORE_2133
Place breakpoint at the end of the test
Get Order.objects.first().discounts.first().type
It is voucher instead of promotion

What did you expect to happen?
CheckoutDiscount.type should be set to 'promotion'
Logs
No response
Environment
Saleor version: …
OS and version: …

https://github.com/saleor/saleor/pull/15248


Sanity check for Babe's configuration

This PR introduces a sanity check for Babe's config c denominator before on-chain write.

Currently we allow to set c denominator of Babe configuration to zero.
This value is then stored on-chain and will be enacted on next epoch change.
Once this new value has been enacted, it will be used by the client native authoring code to compute the "primary threshold"
https://github.com/paritytech/substrate/blob/e0ccd008fe8bfaf29357ea87561e60f3baaae08c/client/consensus/babe/src/authorship.rs#L44
A div by zero exception is triggered and the node crashes.
Because the c value is stored on-chain, it will be reused on node restart and thus it will then crash again obliterating the ability to author new blocks and thus the ability to easily fix the situation.

Even though changing Babe's config params is a Sudo/Governance action, better to be defensive over bad settings

Maybe a configuration with config.c.0 == 0 and config.allowed_slots == AllowedSlots::PrimarySlots should be considered invalid as well.
With such configuration the threshold is 0, thus claim_primary_slot always fails.
https://github.com/paritytech/substrate/blob/e0ccd008fe8bfaf29357ea87561e60f3baaae08c/client/consensus/babe/src/authorship.rs#L205
But falling back to the secondary method is not allowed. Thus we are stuck again.


Add kafka consumer to rocksplicator.

This is the first change in a series of changes to add the capability of
tailing kafka messages and ingesting them to rocksdb. The current change
includes:
1. KafkaConsumer class: Handles consuming kafka messages using librdkafka
2. KafkaConsumerPool: Creates a thread pool of KafkaConsumers
3. KafkaWatcher class: Manages the consumer pools.

Misread your comment and moved the tests to common/tests/kafka, fixing it now.

-- Removed changes from the Docker file.
-- Moved tests to common/kafka/tests
-- I would prefer not making changes to the library since it's being migrated. Would want to confirm there are no regressions. Will make changes to library in subsequent PR's.

lgtm

Thank you!


Add more and consistent debug logging on JMS Received/sent messages

As requested, add more logging for the response messages. Added it for the debug log mode.

Would it include the JMSProperties that will be sent to the target destination in the log?


Invalid config error, unable to use integration

Hi there! I was using this integration successfully for the past week or two but after a restart today from working on my dashboard layout, I'm randomly getting an invalid config error notification upon boot up. Specfically:
"Invalid config
The following integrations and platforms could not be set up:
dyson_local (Show logs
dyson_cloud (Show logs
Please check your config and logs."
Under the cloud log I got this error
Logger: homeassistant.setup
Source: setup.py:214
First occurred: 1:41:58 PM (1 occurrences)
Last logged: 1:41:58 PM

Setup failed for custom integration dyson_cloud: Unable to import component: No module named 'custom_components.dyson_local'

and under the local log I got these errors
Logger: frontend.js.latest.202305033
Source: components/system_log/__init__.py:257
First occurred: 1:45:55 PM (3 occurrences)
Last logged: 1:45:55 PM

http://homeassistant.local:8123/config/logs?filter=dyson_cloud:0:0 Uncaught
http://homeassistant.local:8123/hacsfiles/fan-control-entity-row/fan-control-entity-row.js?hacstag=19166315023:9:28 Uncaught ReferenceError: Polymer is not defined

and
Logger: homeassistant.setup
Source: setup.py:214
First occurred: 1:41:58 PM (1 occurrences)
Last logged: 1:41:58 PM

Setup failed for custom integration dyson_cloud: Unable to import component: No module named 'custom_components.dyson_local'

Any help would be greatly appreciated!

Solution was to remove, restart, re download, re configure. Thanks!


Kafka Kraft no longer works on ubuntu-latest

Describe the bug
Kafka Kraft action fails on ubuntu-latest due to deprecation of docker compose v1.
To Reproduce
Steps to reproduce the behavior:

Run any job using Kafka Kraft v1.1.1
Observe error in ./scripts/start.sh - docker-compose: command not found
Job fails.

Expected behavior
Job should succeed
Screenshots

(removed topic names)
Additional context
The team maintaining the actions/runner-images repository pushed the following pull request on July 30th:

https://github.com/actions/runner-images/pull/10368

This PR removed support for Docker Compose v1.
The suggested fix would be to migrate the docker-compose up -d command in scripts/start.sh to use v2 as laid out here

Really sorry about the delay - I've been travelling!
Thanks for digging into this and providing a resolution - love the write up.
@asheswook and @benjylxwang kindly raised PRs that have been now been merged 👏
This should now be resolved in<EMAIL_ADDRESS>(latest version).


state: Support remove all slaves

When changing slaves list of bond/bridge/ovs_bridge/team, slave interface
need to be included in desire state explicitly. Or a verification
failure will triggered.
This patch will include changed slave interface in desire state
automatically.
Integration test cases added.

Closing. As this does not solve it correctly for OVS part.


Gift Entry: Auto Batch Number feature

W-7780582: Autogenerate batch number
Critical Changes
Changes
Issues Closed
Community Ideas Delivered
New Metadata
Deleted Metadata

This is so cool! Only a few formatting comments, and one question: do we think that 30 characters is enough for the batch number?

@kenlewis-sfdo I thought we were reducing the character limit down to 10?

@kenlewis-sfdo & @ptewson-sfdo I added four custom label changes. It was only two, but in reading all of them, I realized I had an extraneous word in two others.


removing 5 second sleep

I should have just done this instead of opening an issue; as I said before, the 5 second sleep breaks small server methods for certain games.

I check issues before pull requests and implemented this already- whoops. I also optimized it beyond removing the 5 second sleep.


DNS doesn't work for internal queries when a WireGuard DNS has been set

I have had this issue for a while and have recently discussed it in the OPNsense forum under the title:

DNS doesn't work for quite a while (or at all) after rebooting
https://forum.opnsense.org/index.php?topic=23481.0

The issue is that update checks and DNS Diagnostics do not work after rebooting until I go in to Setting, General and click on Save.
Until clicking on Save the resolv.conf settings are set to the DNS entry set in the WireGuard Local Configuration.

Is this related? https://github.com/opnsense/plugins/issues/2462


Jringle/restructure

This PR supercedes https://github.com/ScenicFramework/scenic_driver_local/pull/26
I've broken up the PR into several commits to help facilitate code reviewing.
The 1st 2 commits:  7ad4b4e7ddbfdf552b6b702688098c4615c6fa6c and 96a7c02acda0f31b0909f559443aa192d658b8ff have no functional changes. They simply move source files and cleanup the formatting of the c code.
The rest of the commits are themed around addressing a part.

Really great work! A handful of little polish points, but I really like the direction you took it.
I also think, if I'm tracking correctly, the weak symbol trick for default behaviors is cool.

Thanks for reviewing. I’ll get around to updating the PR to address your comments on Monday.

One thing I do want to flag is that the log_* family has, IIRC, an internal buffer size of like 300 or something. So, we want to keep an eye on that.

I’m not sure what your meaning. All of the log_*() functions funnel to the logv() function which calls vasprintf() which allocates a buffer on the heap large enough to hold the output. The buffer is free’d at the end of logv()

I’m not sure what your meaning. All of the log_*() functions funnel to the logv() function which calls vasprintf() which allocates a buffer on the heap large enough to hold the output. The buffer is free’d at the end of logv()

You're right! I got mixed up thinking about this one.

 I got mixed up thinking about this one.

Ah. I'll get rid of put_msg_i() as well. All calls to it should have been replaced with a log_*() function call

You're right! I got mixed up thinking about this one.

Ah. I'll get rid of put_msg_i() as well. All calls to it should have been replaced with a log_*() function call in b429f69

Remove put_msg_i(). It is no longer used

(note that I still haven't run this locally; probably should do that before merging :P )

FWIW, I've been running it with glfw on laptop with no issues. But my testing of this is only for a small subset of script operations

I'm going in and merging this so we can proceed further.


H2 traffic stalls under load

Ran current master on local machine (MacBook Pro).
File size: 143,416 bytes

http.transaction_no_activity_timeout_in: 3
http2.stream_priority_enabled: 0
h2load -v -c 1 -n 10000 -m 100 https://localhost:8443/test -> Doesn't stall
h2load -v -c 2 -n 10000 -m 100 https://localhost:8443/test -> Doesn't stall
h2load -v -c 3 -n 10000 -m 100 https://localhost:8443/test -> Doesn't stall
h2load -v -c 4 -n 10000 -m 100 https://localhost:8443/test -> Stalls at 90%
h2load -v -c 5 -n 10000 -m 100 https://localhost:8443/test -> Stalls at 90%
h2load -v -c 10 -n 10000 -m 100 https://localhost:8443/test -> Stalls at 90%
h2load -v -c 50 -n 10000 -m 100 https://localhost:8443/test -> Stalls at 60%
h2load -v -c 100 -n 10000 -m 100 https://localhost:8443/test -> Stalls at 40%
h2load -v -c 100 -n 10000 -m 1 https://localhost:8443/test -> Doesn't stall
h2load -v -c 100 -n 10000 -m 2 https://localhost:8443/test -> Doesn't stall
h2load -v -c 100 -n 10000 -m 3 https://localhost:8443/test -> Stalls at 90%
h2load -v -c 100 -n 10000 -m 4 https://localhost:8443/test -> Stalls at 90%
h2load -v -c 100 -n 10000 -m 10 https://localhost:8443/test -> Stalls at 90%
h2load -v -c 100 -n 10000 -m 50 https://localhost:8443/test -> Stalls at 60%
h2load -v -c 100 -n 10000 -m 100 https://localhost:8443/test -> Stalls at 40%

http.transaction_no_activity_timeout_in: 3
stream_priority_enabled: 1
h2load -v -c 1 -n 10000 -m 100 https://localhost:8443/test -> Doesn't stall
h2load -v -c 2 -n 10000 -m 100 https://localhost:8443/test -> Doesn't stall
h2load -v -c 3 -n 10000 -m 100 https://localhost:8443/test -> Doesn't stall
h2load -v -c 4 -n 10000 -m 100 https://localhost:8443/test -> Doesn't stall
h2load -v -c 5 -n 10000 -m 100 https://localhost:8443/test -> Stalls at 90%
h2load -v -c 10 -n 10000 -m 100 https://localhost:8443/test -> Stalls at 90%
h2load -v -c 50 -n 10000 -m 100 https://localhost:8443/test -> Stalls at 50%
h2load -v -c 100 -n 10000 -m 100 https://localhost:8443/test -> Stalls at 30%
h2load -v -c 200 -n 10000 -m 100 https://localhost:8443/test -> Stalls at 30%
h2load -v -c 100 -n 10000 -m 1 https://localhost:8443/test -> Doesn't stall
h2load -v -c 100 -n 10000 -m 2 https://localhost:8443/test -> Doesn't stall
h2load -v -c 100 -n 10000 -m 3 https://localhost:8443/test -> Doesn't stall
h2load -v -c 100 -n 10000 -m 4 https://localhost:8443/test -> Stalls at 90%
h2load -v -c 100 -n 10000 -m 5 https://localhost:8443/test -> Stalls at 90%
h2load -v -c 100 -n 10000 -m 10 https://localhost:8443/test -> Stalls at 90%
h2load -v -c 100 -n 10000 -m 50 https://localhost:8443/test -> Stalls at 60%
h2load -v -c 100 -n 10000 -m 100 https://localhost:8443/test -> Stalls at 30%

http.transaction_no_activity_timeout_in: 30
http2.stream_priority_enabled: 0
h2load -v -c 50 -n 10000 -m 100 https://localhost:8443/test -> Doesn't stall
h2load -v -c 100 -n 10000 -m 50 https://localhost:8443/test -> Doesn't stall
h2load -v -c 100 -n 10000 -m 100 https://localhost:8443/test -> Doesn't stall

http.transaction_no_activity_timeout_in: 30
http2.stream_priority_enabled: 1
h2load -v -c 50 -n 10000 -m 100 https://localhost:8443/test -> Doesn't stall
h2load -v -c 100 -n 10000 -m 50 https://localhost:8443/test -> Doesn't stall
h2load -v -c 100 -n 10000 -m 100 https://localhost:8443/test -> Doesn't stall

@shinrich You may be interested in this.

Maybe just a overload but ATS should send something (e.g. GOAWAY, RST_STREAM, etc.).

It seems that ATS received GOAWAY from the client right before session stalls.

The number of requests failed and the number of request aborted by noactivity timer is the same.
The reason of no activity is still not clear. Maybe just a overload, maybe a bug around client_rwnd.

Receive window and number of concurrent streams seem fine.
With this patch, it fail to serve some requests expectedly.
diff --git a/proxy/http2/Http2ConnectionState.cc b/proxy/http2/Http2ConnectionState.cc
index 0cd9c3fe3..35a06f2ab 100644
--- a/proxy/http2/Http2ConnectionState.cc
+++ b/proxy/http2/Http2ConnectionState.cc
@@ -1143,7 +1143,7 @@ Http2ConnectionState::delete_stream(Http2Stream *stream)
     }
   }

-  if (stream->get_state() == Http2StreamState::HTTP2_STREAM_STATE_HALF_CLOSED_LOCAL) {
+  if (stream->get_state() != Http2StreamState::HTTP2_STREAM_STATE_CLOSED) {
     send_rst_stream_frame(stream->get_id(), Http2ErrorCode::HTTP2_ERROR_NO_ERROR);
   }

I'll submit a PR after other PRs for H2 issue have been merged.


Show export commands for non-python files

Fixes #9571

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[x] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for feature-requests.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

Just another quick fix from the iteration list. While looking at this I'm seeing that we have larger issues in general with how we handle our toolbar enablement and context keys. Filed an issue for that here:
https://github.com/microsoft/vscode-jupyter/issues/10081

The last obstacle against me and using vscode as my default jupyter... I believe in you guys!


Buttons on the Top Bar Not Working (Qt 6.6.2)

The buttons on the top bar are unresponsive. When clicked, nothing happens. This issue occurs in my application using Qt version 6.6.2.
pls can you help me ?

I am using Qt version 5.15.2 (MinGW 5.3.0)
To begin with, you can check that the button click slots are called.

Ok, it works now. thank you....


Uploaded workflows are not isolated from other users

The current behavior or issue
Uploaded workflows are all stored in the same folder
The steps taken to reproduce the behavior or issue, or specify a location where the steps were recorded
To reproduce, upload a downloaded workflow file and look in the workflow folder. The folder will not be isolated from other users
Expected behavior
Uploaded workflow files are stored on a per-user basis
Screenshots
N/A
Add other supporting information that may be useful
N/A
Completion criteria
This is done when workflow files are uploaded to individual user folders

Pre merge: https://github.com/AgPipeline/Atlana/commit/d6857dc523b53884c96a77393f0d060cc11eee4c


Support nodestyle callbacks

test script : https://gist.github.com/vaishnav98/bda1c2e0355e584830e8c6daf8730f93

Pull Request Test Coverage Report for Build 103

0 of 16 (0.0%)  changed or added relevant lines in 1 file are covered.
12 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.5%) to 36.94%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/index.js
0
16
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/index.js
12
32.86%

Totals

Change from base Build 101:
-0.5%

Covered Lines:
338

Relevant Lines:
915

💛  - Coveralls


Victor VosMottor: Watch ketoavis.fr

Victor VosMottor requests the watch of the watch_keyword ketoavis\.fr. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

ketoavis\.fr has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Rejected by Mast in Charcoal HQ. Reason: 'Insufficient justification, no hits.'


Turn the tape player code into a device

A sub-task of #19.

Done. The tape player is now an independent device!


arch/riscv: Unify 32/64 implementations and remove dead ports

Summary
Unify the 32 and 64 bit RISC-V arch and as part of this also drop:

nr5m100 -- Non-public custom implementation
gap8 -- Custom non-standard RISC-V architecture.

Impact
Testing
Not ready for merge!

Will be done step by step:
https://github.com/apache/incubator-nuttx/pull/5076
https://github.com/apache/incubator-nuttx/pull/5092
https://github.com/apache/incubator-nuttx/pull/5097
https://github.com/apache/incubator-nuttx/pull/5103
https://github.com/apache/incubator-nuttx/pull/5106
https://github.com/apache/incubator-nuttx/pull/5115
https://github.com/apache/incubator-nuttx/pull/5123
https://github.com/apache/incubator-nuttx/pull/5135

Will be done step by step:
https://github.com/apache/incubator-nuttx/pull/5076
https://github.com/apache/incubator-nuttx/pull/5092
https://github.com/apache/incubator-nuttx/pull/5097
https://github.com/apache/incubator-nuttx/pull/5103
https://github.com/apache/incubator-nuttx/pull/5106
https://github.com/apache/incubator-nuttx/pull/5115
https://github.com/apache/incubator-nuttx/pull/5123
https://github.com/apache/incubator-nuttx/pull/5135

Let's track the merge in https://github.com/apache/incubator-nuttx/pull/2822 instead.


Checking Lib Types Using TSC

I've run into multiple issues with using new-javascript over time where the types appear to be not working nicely together just from using them with "types": ["new-javascript"].
Is this project edited in conjunction with tsc checking all of the file references? The only way to fix these errors is to enable "skipLibCheck": true, but that has shown to make things less accurate for me, because it also disables checking of my own .d.ts files for my app, not solely the ones in ./node_modules.
I tend to run a terminal window alongside my editor while I write in one file, as you can catch reference/type issues in other files when you change the exports from the file you have open. I think that appears to be some of the main issues with new-javascript's errors. I think part of the issue may also be that the project doesn't have a tsconfig.json, which would help narrow the use of types, in that you can enable things like "strict": true, which will ensure that un-typed any values don't go undeclared. There appears to be a few of those, where return types aren't defined, so my tsc is picking up on them being undeclared as any, since my project has "strict": true set.

Thanks! Ok, there are two things here:

There was indeed some nonsense in my code (mostly <reference>s to deleted or renamed files and one untyped return value, as you already figured out), which I fixed now.
The reason for most (28) of the errors is, however, still the collision between the types from lib.dom.d.ts and lib.webworker.d.ts, as new-javascript references both of them. For checking the new-javascript types themselves, I think we will have to use tsc index.d.ts --strict && tsc worker.d.ts --strict as I don't see a simple way to tell tsc in a tsconfig.json that it should treat the DOM-related types from new-javascript separately from the worker-related ones (also, when tsc-ing .d.ts files directly, the tsconfig.json is completely ignored). For the errors that appear in projects using new-javascript, you have to (as explained in new-javascript's readme) exclude the files in tsconfig.json, e.g. in your Dovetail project you can add "./public" to the "exclude" property in the tsconfig & remove the var self = ... line in service-worker.js and it should work (with lib check enabled).

I ended up moving my Service Worker over to a full TypeScript file as well, and this issue still occurs, and I was hoping to look into figuring out a fix for it again. Any new tips or ideas on this one?

If I clone Dovetail and add
"exclude": [
  "./src/service-worker.ts",
],

to the tsconfig.json, it works just fine for me, even after removing the
declare var self: ServiceWorkerGlobalScope;

in service-worker.ts. What am I missing here?

Looks like it does work! Ideally I wouldn't have to exclude it from the tsconfig.json though, since that removes it from my type checking config, so it doesn't follow the same rules the rest of the project does (tsc or tsc --watch). Is the only way to manage it to exclude it, and maybe use a second tsconfig.json instead?

Ok, here's another possible one, is there a way to make a library that is loaded as a <reference lib/> type? Rather than a <reference types/> one? That should in theory prevent the overlap with the standard library I think? Or would that mean that loading those types would spill over into my other modules code' types as well? Because that seems to happen for other kinds of projects of mine when using only a single tsconfig.json as well.
Here's the current state of things for reference:

The problem is that TypeScript fundamentally has terrible support for mixing different execution contexts (i.e. main thread/workers/worklets etc.) in a single project. As soon as there is a tsconfig.json file present in a directory, all /// <reference />s as well as the types of the compilerOptions.types array apply to all TS files. Suppose you have the following files:
tsconfig.json:
{}

main.ts:
document;
FileReaderSync;
export {};

worker.ts:
/// <reference no-default-lib="true" />
/// <reference lib="WebWorker" />
/// <reference lib="WebWorker.Iterable" />
document;
FileReaderSync;
export {};

you would expect FileReaderSync to error in main.ts, and document to error in worker.ts. Instead, document errors in both files, simply because the <reference />s from worker.ts also apply to main.ts. If you now e.g. add
/// <reference lib="DOM" />
/// <reference lib="DOM.Iterable" />

to main.ts, or if you include any types referencing the DOM lib (e.g. new-javascript or better-typescript) in compilerOptions.types, both the DOM types and the WebWorker types get included in all TS files, which is also not what you want.
Personally, I hate configuration files of all kinds with a passion, and as I'm perfectly happy with the global js/ts.implicitProjectConfig. options in VSCode's settings.json, I usually simply don't use tsconfig.json files at all, making all those problems go away. If you do want to use tsconfig.jsons, I still haven't found another way than to "exclude" your worker files.

I think TypeScript simply treats <reference lib="LIBRARY_NAME" /> as a kind of "redirect" to <reference path="path/to/internal/node_modules/typescript/lib/lib.LIBRARY_NAME.d.ts" />, so I don't think loading types via <reference lib=... /> instead of <reference types=... /> would make a difference (also I'm pretty sure it's impossible).

@Offroaders123 Ok, I've now completely rearchitected new-javascript and better-typescript in a way that I've always considered to do but never did because it's very ugly and hacky: I copied all the webworker-exclusive types from lib.webworker.d.ts into a TS file to expose those types globally while completely removing all lib="WebWorker" references. As far as TypeScript is concerned, all your TypeScript files (both main thread and workers) are now always "on the main thread", and self always has a type of Window & typeof globalThis, but both the DOM-exclusive and the webworker-exclusive stuff are available everywhere, so you the developer have to figure out what you may use where. better-typescript then extends these types with service- and shared worker types. So now you can simply add
{
  "compilerOptions": {
    "types": ["better-typescript"], // or "new-javascript" if, for whatever reason, you don't want the better-typescript stuff
  }
}

to the tsconfig or add
/// <reference types="better-typescript" />

to a TS file and all files will get all DOM and all worker types.
Note that this is a breaking change, since referencing new-javascript/worker.d.ts doesn't work anymore (this file has been repurposed for TS definitions for all webworker stuff). Let me know what you think!

It's not working when loaded through npm, I think the package.json isn't associating the types completely.

@Offroaders123 The packages are called better-typescript and new-javascript; better-javascript doesn't exist :)


Fix the source code check on CONTRACTS_VERSION

This fixes #1312.
What this PR does

After this PR, the bytecode verification on CONTRACTS_VERSION happens against the right source from data_CONTRACTS_VERSION, not from data.
contracts_source_path() takes a new argument contracts_version.

Why I'm making this PR
Currently, it's impossible to deploy Raiden contracts on a private network so people can test raiden #1312.
What's tricky about this PR (if any)
Nothing.
I've tested that this PR fixes the problem I saw in #1312.

Any reviewer can check these:

[ ] If the PR is fixing a bug or adding a feature, add an entry to CHANGELOG.md.
[ ] In Python, use keyword arguments
[ ] Squash unnecessary commits
[ ] Comment commits
[ ] Follow naming conventions

python_variable
PYTHON_CONSTANT

And before "merge" all checkboxes have to be checked.  If you find redundant points, remove them.

I'm deferring the test writing https://github.com/raiden-network/raiden-contracts/issues/1314 .

Thank you!


Fixed CMake link libraries for opendnp3 and dnp3decode

Wow. Surprised this was actually compiling. Any idea when this regression occured? Time to run git-blame to find out when I broke this.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_23kpc5fwkp/clone/recipe/meta.yaml:18: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_23kpc5fwkp/clone/recipe/meta.yaml:24: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_23kpc5fwkp/clone/recipe/meta.yaml:36: missing_imports_or_run_test_py: Python packages require imports or a python test file in tests.
ERROR: /tmp/abs_23kpc5fwkp/clone/recipe/meta.yaml:43: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_23kpc5fwkp/clone/recipe/meta.yaml:43: missing_documentation: The recipe is missing a doc_url or doc_source_url
WARNING: /tmp/abs_23kpc5fwkp/clone/recipe/meta.yaml:43: missing_description: The recipe is missing a description
Errors were found


Motor-CAD JSON-RPC server sending invalid JSON (e.g. INF)

🔍 Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

🐞 Description of the bug
It seems reasonable that some Motor-CAD variables might take the value ∞. In which Motor-CAD seems to send the INF constant through the JSON-RPC interface. However, this is not valid JSON and a decode error is thrown on the Python side.
📝 Steps to reproduce
I believe I got into this situation when I stopped a solve early and then requested the value of the variable.
mcad.get_variable("IMSINGLELOADPOINT_POWERFACTOR")

Full stack trace:
Traceback (most recent call last):
  File "/lib/python3.10/site-packages/requests/models.py", line 971, in json
    return complexjson.loads(self.text, **kwargs)
  File "/usr/lib/python3/dist-packages/simplejson/__init__.py", line 525, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 370, in decode
    obj, end = self.raw_decode(s)
  File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 400, in raw_decode
    return self.scan_once(s, idx=_w(s, idx).end())
simplejson.errors.JSONDecodeError: Expecting value: line 1 column 58 (char 57)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/lib/python3.10/site-packages/ansys/motorcad/core/rpc_client_core.py", line 452, in send_and_receive
    response = requests.post(self._get_url(), json=payload).json()
  File "/lib/python3.10/site-packages/requests/models.py", line 975, in json
    raise RequestsJSONDecodeError(e.msg, e.doc, e.pos)
requests.exceptions.JSONDecodeError: Expecting value: line 1 column 58 (char 57)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "my-test.py", line 80, in <module>
    val = mcad.get_variable(v)
  File "/lib/python3.10/site-packages/ansys/motorcad/core/methods/rpc_methods_variables.py", line 67, in get_variable
    return self.connection.send_and_receive(method, params)
  File "/lib/python3.10/site-packages/ansys/motorcad/core/rpc_client_core.py", line 457, in send_and_receive
    self._raise_if_allowed("RPC Communication failed: " + str(e))
  File "/lib/python3.10/site-packages/ansys/motorcad/core/rpc_client_core.py", line 336, in _raise_if_allowed
    raise MotorCADError(error_message)
ansys.motorcad.core.rpc_client_core.MotorCADError: RPC Communication failed: Expecting value: line 1 column 58 (char 57)

Looking at the underlying JSON which is received:
{"jsonrpc":"2.0","id":-1,"result":{"success":0,"output":[INF],"errorMessage":"pymotorcad: GetVariable IMSINGLELOADPOINT_POWERFACTOR = INF"}}

💻 Which operating system are you using?
Windows
📀 Which ANSYS version are you using?
Ansys Motor-CAD v2023.2.1
🐍 Which Python version are you using?
3.10
📦 Installed packages
ansys-motorcad-core==0.2.0

Here is what it looks like in the Motor-CAD UI:

Not sure what the best solution is, a change in MotorCAD to not send the INF constant, or somehow relax the JSON parsing on the Python side. For example, the simplejson has allow_nan and parse_constant which could be useful.

Thanks for spotting this @vrzh. We will look into fixing this for a future release. Also feel free to submit a PR if you have a good solution already.

Not sure what is the best solution, as it seems there is no JSON standard to represent these types of values.
One option is to change Motor-CAD to output Infinity instead of INF as this seems to be what Python JSON decoders typically accept:
# python3 -m pip install 'simplejson==3.19.1'

import simplejson
simplejson.loads('Infinity', allow_nan=True)

# python3 -m pip install 'simplejson<3.19.1'

import simplejson
simplejson.loads('Infinity')

# using built-in json package
import json
json.loads('Infinity')

It looks like pymotorcad uses the requests library. But, the problem is that requests library only uses simplejson if it is installed, otherwise it falls back to json.
Therefore pymotorcad would also have to check if simplejson is installed and what version it is (adding allow_nan=True for older versions of simplejson will raise an exception). Or, add simplejson as a dependency of pymotorcad with a fixed version (either the old or new one).

Should be fixed for Motor-CAD 2024R2. Returns "None" instead of throwing exception


Option select event

I added the event emitting code and the matching description in the docs.
Tests for events are still missing but i will take a look at it soon.

Hi Thomas! Glad to see your another PR. However, I have already finished this feature myself. So, really sorry that I can not merge this.
Anyway, thanks for your contribution. Keep up!

no problem ;)


Tracing stopped working in Java Application

We have Springboot based application running on AWS.

Springboot
Java Coerretto 11
Running on AWS in docker

We are using https://github.com/aws-observability/aws-otel-java-instrumentation agent to collect the metrics and traces and to publish it to AWS prometheus.
From version 1.13, we have observed that while metrics worked, the trace stopped working. We were able to confirm the behavior by replacing 1.13 with 1.12 version of the jar.
Are there any known issues with 1.13.0 release?

Thank you for the report, we will take a look at this issue.

Hi @rasik-sheth, can you please try with latest release  ADOT Java Agent v1.16.0 and if you are still facing this issue, please attach logs by using logging exporter with loglevel: debug for more context.

Adding more information. The Traces are generated with spring boot sample app using ADOT Java Agent 1.13+ version and validated in the tests.
Example spring boot sample app: https://github.com/aws-observability/aws-otel-java-instrumentation/tree/main/sample-apps/springboot
Closing this issue as inactive from past 2 months. Please re-open if you are still facing the issues.


Speech API doesn't appear to be promisified?

I'd expect the following to work just fine:
speech.recognize(audio).then(console.log);

Instead I get an error:
> /home/jjg/node_modules/google-cloud/node_modules/@google-cloud/speech/src/index.js:656
        callback(err, null, resp);
        ^

TypeError: callback is not a function
    at /home/jjg/node_modules/google-cloud/node_modules/@google-cloud/speech/src/index.js:656:9
    at _combinedTickCallback (internal/process/next_tick.js:71:11)
    at process._tickDomainCallback (internal/process/next_tick.js:122:9)

which is clearly telling me that I should be using callback style rather than promises :(

Actually, upon further inspection of index.js:656 it seems that there's an error (likely that I haven't enabled the API) and we're not doing the right thing w it....
> speech.recognize(audioFilePath, {}, console.log);
undefined
> { Error: Google Cloud Speech API has not been used in project jjg-cloud-research before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/speech.googleapis.com/overview?project=jjg-cloud-research then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.
    at /home/jjg/node_modules/google-cloud/node_modules/grpc/src/node/src/client.js:417:17
  code: 7,
  metadata: Metadata { _internal_repr: { 'google.rpc.help-bin': [Object] } },
  note: 'Exception occurred in retry method that was not classified as transient' } null undefined

versus
> speech.recognize(audioFilePath, console.log);
undefined
> /home/jjg/node_modules/google-cloud/node_modules/@google-cloud/speech/src/index.js:656
        callback(err, null, resp);
        ^

TypeError: callback is not a function
    at /home/jjg/node_modules/google-cloud/node_modules/@google-cloud/speech/src/index.js:656:9
    at _combinedTickCallback (internal/process/next_tick.js:71:11)
    at process._tickDomainCallback (internal/process/next_tick.js:122:9)

I think the promise will work if you provide a config object:
speech.recognize('./audio', { ... })
.then(...)
What we need to do is throw if a config object isn't provided.

Yep, just realized that. In the rest of the stuff we do, configs are optional. In this, they're not :(
We should make that super duper clear, and throw the right error when a config object is missing.


some thoughts on the simplification of factory context

These thoughts stem from some completely unreleated work. I originally intended to simplify the interfaces of ClusterInfo and try to aggregate all HTTP reletated options to a single HttpProtocolOptions. Then, I found that the TransportSocketFactoryContext instance of cluster is prapagated in the multiple-levels call and I did a simplifiation (see #26438).
When I was doing #26438, I found that there are lots of types of factory context. All these factory contexts have some similar interfaces that used to access the server-wide resource. In almost all the cases, these interfaces' impl would be a simple wrapper to the interfaces of a server factory context reference.
I am thinking could we make things simpler, could we just add a serverFactoryContext() to these factory contexts to return a reference. This reference will provides server-wide resource accessing.
The type of reference could be ServerFactoryContext or CommonFactoryContext or FactoryContextBase, it depends on the set of interface that we want to expose.
Then we will have a clear delimitation between the server-wide resource and context-wide resource. And these factory contexts needn't inherit and implement the interfaces of CommonFactoryContext or FactoryContextBase.
And by this way, the code should be eaiser to maintian. Take #23903 as an example, in the #23903, we changed the return type of admin() interface. But we need change almost every factory context because almost all factory contexts inherit the FactoryContextBase. (From this perspective, composition over inheritance).

cc @alyssawilk

I will take the ClusterFactoryContext as the initial experimental object because I had did some code clean =up to the common/upstream recently.

Pick this up again. Iet's do it gradually.


⚠ Samsung has degraded performance

In 13aa069, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2775 ms

Resolved: Samsung performance has improved in f632780.


Support multiple phone numbers for a person

@CS2103AUG2017-W10-B3/developers do we want to add tags for different phone numbers? Eg. work/home/personal

I think its just a lot of work for the same thing tbh unless theres a nicer way of implementing it.
is your idea smth like  wp/12314 pp/123123 hp/123123123?

I think its a great idea.
What @chilipadiboy mentioned about the wp/ pp/ hp/ prefixes is great.
What do you think should the "required" number to be put in? Or would any of them do?

Yes, I like the idea of mentioned by @chilipadiboy! After some thinking, I suggest having these attributes:

mp/ for mobile.
wp/ for work.
hp/ for home.

Any thoughts on this? Otherwise, I can start to work.

We decided to close this.


chore(Algebra/Ring): remove variables unused in section

Perhaps we should have a linter for this... @adomani?

Bhavik, I wrote a linter and these are the first unused variables found: #17261.
There are many more: some are potential false positives, since the linter is not really able to deal with declarations that use the equation compiler, but a lot of the output are actually unused variables.

maintainer merge


Only trigger build once if multiple FS events arrive at the same time

Fixes #187

Testing for wasm32-unknown-unknown (wasm-bindgen)...
./ci/run_tests.sh: line 27: wasm-pack: command not found
The command "./ci/run_tests.sh" exited with 127.

(Note that it's stdweb's ./ci/run_tests.sh, not cargo-web's. Error occurs only with TEST_SUBSET=2.)
I'm guessing install_wasm_pack.sh or similar is needed in this project's test env as well?

Right; I forgot that align cargo-web's Travis with the latest changes in stdweb!
Anyway, looks good to me! Thanks!