CardinalityIT/NestedIT test failures with concurrent search enabled and AssertingCodec

Description
The tests were failing because during the concurrent segment search for each slice the codec producers for the leafs were initialized by the slice thread. Later in reduce phase, the post collection happens over those codec producers on the search thread. With AssertingCodec it verifies that all access is done by the same thread causing the failures. More details are in #8095
Related Issues
Resolves #8095
Check List

[X] New functionality includes testing.

[X] All tests pass

[] New functionality has been documented.

[X] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff
[] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta Can you please help to review ?

Gradle Check (Jenkins) Run Completed with:

RESULT:  ❌
URL: https://build.ci.opensearch.org/job/gradle-check/19968/
CommitID: f493a09
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Failed tests are unrelated:
[org.opensearch.remotestore.RemoteStoreIT.testStaleCommitDeletionWithInvokeFlush](https://build.ci.opensearch.org/job/gradle-check/19968/testReport/junit/org.opensearch.remotestore/RemoteStoreIT/testStaleCommitDeletionWithInvokeFlush/)
[org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure](https://build.ci.opensearch.org/job/gradle-check/19968/testReport/junit/org.opensearch.remotestore/RemoteStoreRefreshListenerIT/testRemoteRefreshRetryOnFailure/)
[org.opensearch.remotestore.multipart.RemoteStoreMultipartIT.testStaleCommitDeletionWithInvokeFlush](https://build.ci.opensearch.org/job/gradle-check/19968/testReport/junit/org.opensearch.remotestore.multipart/RemoteStoreMultipartIT/testStaleCommitDeletionWithInvokeFlush/)

@sohami could you please add changelog (may be using different phrasing), it seems we are changing not the tests but core functionality.

@sohami could you please add changelog (may be using different phrasing), it seems we are changing not the tests but core functionality.

Added the changelog entry

@reta Can this be merged ?

@reta Can this be merged ?

@sohami  Green build? Please rebase may be

@reta Can this be merged ?

@sohami Green build? Please rebase may be

I did rebase yesterday as part of final commit and gradle seems to be failing for bwc2.9 jar. Let me rebase again to see if that fixes below issue.
* What went wrong:
Execution failed for task ':distribution:bwc:minor:buildBwcLinuxTar'.
> Building 2.9.0 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/minor/build/bwc/checkout-2.x/distribution/archives/linux-tar/build/distributions/opensearch-min-2.9.0-SNAPSHOT-linux-x64.tar.gz

Hehe @sohami please backport manually to 2.x, thank you

Hehe @sohami please backport manually to 2.x, thank you

@reta Created backport pr https://github.com/opensearch-project/OpenSearch/pull/8687. Thanks!


Auto-derive display

If description() is defined, display() could default to it instead of "".

Closing for #58.


Bump cudarc version to 0.11.4

A new cudarc version was just released which:

Uses nvcc to find CUDA toolkit
Adds a fix for finding curand

Thank you!


feat: add error messages for error cases

closes #3

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


FIX Minor issues in docs, re-raising exception

A few unrelated things I noticed:

Typos in docs
Add mention that DoRA now supports Conv2d
Re-raise a caught exception (to not hide original error)

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


RealmEye API Error

When RealmEye is down, the current API used -- Tiffits -- would return an error that the bot would have interpreted as a private profile error.
This should be acknowledged so that the bot notifies the user that there is an error connecting to RealmEye, as opposed to a private profile warning.

We only need to check Tiffit's API, not the custom one.

I might have acknowledged this.


NodeJS Collector: connect ECONNREFUSED <IP_ADDRESS>:4318

Describe the bug
I am using the NodeJS Lambda layer and I am seeing the following error in the logs upon each invocation. I am not sure if this is a bug, or if I am doing something wrong. Appreciate the help regardless!
{
  "stack": "Error: connect ECONNREFUSED <IP_ADDRESS>:4318\n    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1595:16)\n    at TCPConnectWrap.callbackTrampoline (node:internal/async_hooks:130:17)",
  "message": "connect ECONNREFUSED <IP_ADDRESS>:4318",
  "errno": "-111",
  "code": "ECONNREFUSED",
  "syscall": "connect",
  "address": "<IP_ADDRESS>",
  "port": "4318",
  "name": "Error"
}

Steps to reproduce
I am including the layer in my SAM template.yml
EventProducer:
    Properties:
      ...
      Layers:
        - arn:aws:lambda:eu-west-1:184161586896:layer:opentelemetry-nodejs-0_5_0:1

exporting the following environment variables
OPENTELEMETRY_COLLECTOR_CONFIG_FILE: /var/task/collector.yaml
AWS_LAMBDA_EXEC_WRAPPER: /opt/otel-handler
OTLP_EXPORTER_OTLP_ENDPOINT: 'http://ENDPOINT:PORT'

In my handler I am acquiring a Tracer using the following code and generating a span
const tracer = trace.getTracer('EventProducer', '1.0');

function createPayload(traceEvent: Event, itemLoadedEvent: Event): Promise<Input> {
  return tracer.startActiveSpan('EventProducer.createPayload', async (span: Span) => {
    // do smth
    span.end();
    return payload;
  });
}

What did you expect to see?
I expect to see a trace signal exported to Collector
What did you see instead?
Error above
What version of collector/language SDK version did you use?
NodeSDK: "@opentelemetry/sdk-node": "^0.49.1",
What language layer did you use?
Config: arn:aws:lambda:eu-west-1:184161586896:layer:opentelemetry-nodejs-0_5_0:1
Additional context
collector.yaml config
receivers:
  otlp:
    protocols:
      grpc:
        endpoint: '<IP_ADDRESS>:4317'
      http:
        endpoint: '<IP_ADDRESS>:4318'

exporters:
  otlp:
    endpoint: 'ENDPOINT:PORT'
    tls:
      insecure: true

service:
  pipelines:
    traces:
      receivers: [otlp]
      exporters: [otlp]

Hello @hampusrosvall,
I am facing the same issue. Would you say explicitly what you have done when you added it...?
Thank you !

Hello!
@SophieDel I managed to make it work using two lambda layers:
    layers:       - arn:aws:lambda:us-east-1:184161586896:layer:opentelemetry-nodejs-0_7_0:1       - arn:aws:lambda:us-east-1:184161586896:layer:opentelemetry-collector-amd64-0_8_0:1
In my case will not work because i need to send to Datadog and Datadog hasn't been implemented yet using ADOT.
If you face the issue, you can expose a OTLP url and use on environment, like:
OTEL_EXPORTER_OTLP_ENDPOINT: "your exporter url endpoint here"


Refresh Token

Hi!  Maybe I am in the wrong place, but is there documentation for how to handle refresh tokens??  Thank you :)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 04ee7d3a-9e1f-dcef-0ac2-e8382d39a796
Version Independent ID: 15c4c20f-7d81-5d27-3de6-fa9868356c70
Content: Get Started with the Outlook REST APIs
Content Source: docs/rest/get-started.md
Product: outlook
GitHub Login: @jasonjoh
Microsoft Alias: jasonjoh

The Azure OAuth documentation covers this for the different flows. All of our tutorials that support refresh tokens have sample code to do the refresh, unless refresh is "built-in" with the OAuth library being used. For example, the ASP.NET tutorial uses MSAL, which handles refresh for you.


Socket Eception not working in getx im doing get request using getConnect

i'm implementing a get request using only getx for api call using getConnect and getxService but the socketexception not throw exception it' another error NoSuchMethodError: The method '[]' was called on null. Receiver: null
:- my get request method

 Future<dynamic> getData(
      String uri,
      {
        Map<String, dynamic> ?query,
      }
      ) async {

    try {
      Response response= await get(uri , query: query,headers: _mainHeader ,);
      return response;
    } on SocketException catch(e){
      print("socketeeeeeeeeeeeeeeeeeeee");
      throw SocketException(e.message.toString());
    } on FormatException catch (_) {
      print("format");
      throw const FormatException("Unable to process the data");
    }
    catch (e) {
      print("socket");
      return  NetWorkExceptions.getApiException(e);
    }
  }

 : - here i call the method

Future<List<ArticlesDataModal>> getData()async {
    var queryParameter = {
      'q': 'apple',
      'from': '2023-02-02&to=2023-02-02',
      'to': '2023-02-02',
      'sortBy': 'popularity',
      'apiKey': '5e6f727d8434446a8bda705dc0d1b22e',
    };
     var getResponse = await _homeRepo.getApi('v2/everything?', query: queryParameter);
    // jsonDecode(getResponse .body);
    print( 'statusssssss  ${getResponse.body['articles']}');
    if (getResponse.statusCode == 200) {
      return getResponse.body['articles'].map<ArticlesDataModal>((obj) =>
          ArticlesDataModal.fromJson(obj)).toList();
    }else{
       throw Exception(getResponse.body['message']); // here its throw error
    //  print('faildddddddd');
    }
  }

: this is my controller called this method in onInit

 @override
  void onInit() {
    // TODO: implement onInit
    super.onInit();
    getData();
  }
  Future getData()async{
    try{
      data.assignAll( await _appApi .getData() );
    }  catch(e){
      Get.showSnackbar(Ui.ErrorSnackBar(message: e.toString()));
    }
  }

can any one help me i'm stuck

If you want to handle exceptions all by yourself, you should set httpClient.errorSafety to false. You can do this inside the onInit function of your GetConnect instance. I usually doing it by creating a base provider class so I don't repeat myself overtime.
Example:
class BaseProvider extends GetConnect {
  @override
  void onInit() {
    httpClient.errorSafety = false;

    /// You can also set base configuration / behavior through the interceptor feature
    /// available inside this function too!
  }
}

And then on your provider, extend it, like so:
class MyApiDataProvider extends BaseProvider {

  Future<dynamic> getData(
      String uri,
      {
        Map<String, dynamic> ?query,
      }
      ) async {

    try {
      Response response= await get(uri , query: query,headers: _mainHeader ,);
      return response;
    } on SocketException catch(e){
      print("socketeeeeeeeeeeeeeeeeeeee");
      throw SocketException(e.message.toString());
    } on FormatException catch (_) {
      print("format");
      throw const FormatException("Unable to process the data");
    }
    catch (e) {
      print("socket");
      return  NetWorkExceptions.getApiException(e);
    }
  }
}

On your Binding class, don't forget to register it and use Get.put(...) on your provider injection so GetConnect could use the configuration you provide inside the onInit function.
class MyBinding extends Bindings {
  @override
  void dependencies() {
    Get.lazyPut<MyController>(
      () => MyController(
          repository: MyRepository(provider: Get.put(MyApiDataProvider()))),
    );
  }
}

By the way, I'm using get_cli to do these job of generating the files for me. It's an awesome package, you should definitely check it out!
P.S:
I'd recommend you to let GetX to handle the exception tho, and just use response.hasError and play with error codes to distinguish which error goes to which exception if you want to display some error message to the user of your app. That way, you might be able to perform any other actions without having a debugger pausing your code or crashing the app on production.
Hope it helps!


postgresql: enable pre-install checks

Motivation for this change
Postgres' pre-install checks are quite minimal but could catch basic problems early. For some reason the make target detection thinks make check doesn't exist, so I need to set it explicitly.
Tests pass reliably for me on non-nixos linux x86_64 & macos 10.13, from postgres 11 all the way back to 9.4.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

You should set checkTarget instead i think.

Well whaddya know...
Done.

Cool - just wanted to start off with something that's quick for people to build & verify (now I know I can switch a PR's target...)


[HOLD] Revert "Add DraggableList component"

Reverts Expensify/App#26307
Just in case we need to revert the PR that has the performance regression as a deploy blocker.

no need for this revert PR anymore


Typo in the docstring of hvp!

https://github.com/gdalle/DifferentiationInterface.jl/blob/main/DifferentiationInterface/src/second_order/hvp.jl#L33
dg should be replaced by tg.

extras is still the last argument in hessian and hessian!:
https://gdalle.github.io/DifferentiationInterface.jl/DifferentiationInterface/dev/api/#DifferentiationInterface.hessian!


LoadLibrary Failed with error 126 when trying to load onnxruntime_providers_cuda.dll

Hi,
I'm trying this sample but I'm getting the following error:
[ErrorCode:RuntimeException] D:\a_work\1\s\onnxruntime\core\session\provider_bridge_ort.cc:1106 onnxruntime::ProviderLibrary::Get [ONNXRuntimeError] : 1 : FAIL : LoadLibrary failed with error 126 "" when trying to load "E:\Development\ThirdParty\StableDiffusion-main\StableDiffusion\bin\Debug\net6.0\runtimes\win-x64\native\onnxruntime_providers_cuda.dll"
I installed CUDA Toolkit 12.1 and cudnn for Cuda12. Both are in the path. I'm running Windows 11 and Visual Studio 2022.
What am I doing wrong?
Thanks in advance!

I had the exact same problem. I solved it by uninstalling CUDA Toolkit 12.1. Installed CUDA Toolkit 11.8. I got a different message that cublasLt64_12.dll was missing so I installed CUDA Toolkit 12 again (Without removing 11.8) and it seems to work now.

I have a similar problem, but with ortextensions.dll
[ErrorCode:Fail] LoadLibrary failed with error 126 "" when trying to load "ortextensions.dll"
File exists and is in correct working directory - also tried with absolut path, but the same.
I also uninstalled all CUDA Toolkit versions and reinstalled 11.8 and than 12.1 like @Spatacoli
Windows 11, Visual Studio 2022

The current supported version of CUDA Toolkit for ONNX Runtime v1.14 is CUDA 11.6. Glad to hear 11.8 was able to fix the issue as well. Thanks!

I have a similar problem, but with ortextensions.dll [ErrorCode:Fail] LoadLibrary failed with error 126 "" when trying to load "ortextensions.dll" File exists and is in correct working directory - also tried with absolut path, but the same.
I also uninstalled all CUDA Toolkit versions and reinstalled 11.8 and than 12.1 like @Spatacoli I use the latest version with the included fix of #3
Windows 11, Visual Studio 2022

Are you still having this issue?

Before I also had CUDA 11.6 installed.
I also have the same ortextensions.dll issue, also on x64 target.
Is it somehow possible to check what dependency of ortextensions.dll is missing/creates the issue?

Before I also had CUDA 11.6 installed. I also have the same ortextensions.dll issue, also on x64 target.
Is it somehow possible to check what dependency of ortextensions.dll is missing/creates the issue?

I have the same issue here. File exists and is in correct working directory.
Windows 10, using the direct-ML-EP branch, since I don't have CUDA supported graphic card.
Stack as follows:
Unhandled exception. Microsoft.ML.OnnxRuntime.OnnxRuntimeException: [ErrorCode:Fail] LoadLibrary failed with error 126 "" when trying to load "D:\Projects\StableDiffusion\StableDiffusion\ortextensions.dll"    at Microsoft.ML.OnnxRuntime.NativeApiStatus.VerifySuccess(IntPtr nativeStatus)    at Microsoft.ML.OnnxRuntime.SessionOptions.RegisterCustomOpLibraryV2(String libraryPath, IntPtr& libraryHandle)    at StableDiffusion.TextProcessing.TokenizeText(String text) in D:\Projects\StableDiffusion\StableDiffusion\TextProcessing.cs:line 17    at StableDiffusion.Program.Main(String[] args) in D:\Projects\StableDiffusion\StableDiffusion\Program.cs:line 26

nearly same here Windows 11 Surface Pro 8 (so no CUDA my guess) uses direct-ML-EP branch

My graphic card supports CUDA, but is maybe to old (GTX1070). I am using the latest Driver v531.29 which also supports CUDA 12.1
Changed to direct-ML-EP branch but still the same error.

Before I also had CUDA 11.6 installed. I also have the same ortextensions.dll issue, also on x64 target.
Is it somehow possible to check what dependency of ortextensions.dll is missing/creates the issue?

I have the same issue here. File exists and is in correct working directory. Windows 10, using the direct-ML-EP branch, since I don't have CUDA supported graphic card. Stack as follows: Unhandled exception. Microsoft.ML.OnnxRuntime.OnnxRuntimeException: [ErrorCode:Fail] LoadLibrary failed with error 126 "" when trying to load "D:\Projects\StableDiffusion\StableDiffusion\ortextensions.dll" at Microsoft.ML.OnnxRuntime.NativeApiStatus.VerifySuccess(IntPtr nativeStatus) at Microsoft.ML.OnnxRuntime.SessionOptions.RegisterCustomOpLibraryV2(String libraryPath, IntPtr& libraryHandle) at StableDiffusion.TextProcessing.TokenizeText(String text) in D:\Projects\StableDiffusion\StableDiffusion\TextProcessing.cs:line 17 at StableDiffusion.Program.Main(String[] args) in D:\Projects\StableDiffusion\StableDiffusion\Program.cs:line 26

Finally I solved this issue, by build the ortextension.dll from source, and use the freshly built out dll.
the repo is  https://github.com/microsoft/onnxruntime-extensions clone the repo and run build.bat in Developer command prompt vs 2022.
the dll is in the out/Windows/bin/RelWithDebInfo folder when build success.

Thanks @pinkli
I build the onnx-extensions with Release 0.7 (Branch rel-0.7) and fixes this problem. But get also stuck with error #9
Hint: If you get only "file not found" output at build.bat check if you have C++-CMake-Tools for Windows installed in your Visual Studio.

Okay, I can't fix this. I've installed CUDA toolkit up and down the version ladder and I always get LoadLibrary failed with error 126 on onnxruntime_providers_cuda.dll when executing AppendExecutionProvider_CUDA(). Where does this DLL actually come from? Maybe I can recompile that?

Or is there any way to get an error printout of what the issue actually is? Code 126 is uniquely unspecific.

I have the same problem as IronFox ... if I open up a commandline inside of the build directory and manually delete onnxruntime.dll I still get the same error Unable to find an entry point named 'OrtSessionOptionsAppendExecutionProvider_CUDA' in DLL 'onnxruntime'. which leads me to believe that the onnxruntime.dll is being loaded from some other place?  I appear to have onnxruntime.dll's inside of Windows/System32 as well as Windows/SysWOW64 ... I have various CUDA toolkits installed and my CUDE_PATH is currently set to C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.6 and the CUDA toolkit path is FIRST thing in my %PATH% dir before the other gazillion versions I appear to have installed... If I try and delete the .dll's inside of Windows dir its not letting me which suggests that those files are open and are being used instead of the .dll's in the build dir.... no idea where these came from... I'm presuming CUDA toolkit doesn't install to Windows dir?


Ability to export reports and other data

Ability to export to an excel file the result of searches, this would allow people to manipulate the data as they see fit.
This was at first implemented as a client side functionality. We need to rewrite it as server side.
Backend side:

when the GET graphql query is called with an output=xlsx, do the following:
execute the query and get the json results
identify the top level lists in the results
for each top level list, create a new excel sheet
for each list item create a row in the sheet
for each unique attribute in the items create a column
initial implementation should deal with basic types and anything else convert the value to a string

Frontend side:

Create a download button in the UI with the new service at all locations where there is a graphql query that returns a list.

Reference item 1

We need to update the client code to make sure that:

clicking on the export button has the following behavior:  take the graphql query of the current context without the pagination constraint, then call the server side graphql export with output=xlsx
Review and the add export button to more (possibly all) pages that have a graphql query which returns a list


Rewrite local expectation values as a single contraction

Rewrites the local expectation values as a single contraction and switches on the optimal contraction ordering in @tensor. This should improve performance, since I'm a bit skeptical the approach of first contracting the full environment and then multiplying in the operator afterward is the most efficient. This currently bypasses the operator_env function entirely, although I left it in just in case it is still needed elsewhere.
In particular, this should fix the OnSite expectation value, which was wrong before I think (it seems it assumed a transposed environment?). Also, I chose to transpose the NearestNeighbor environment density matrix to be consistent with the usual interpretation.

Nice! I'll try and add some more tests to cover the onsite case later today, so let's wait just a second before merging


Fix issue in DatastoreRequestBuilder.

Fix issue in DatastoreRequestBuilder.

Bug affects users, who use olp-sdk-dataservice-api directly.
Bug was reproduced when a javascript object is passed to the init.headers instead of Headers instance, a new empty instance of Headers was created and the input parameters was missed.

Now to the method init.headers can be passed an instance of Headers or an javascript object and the method should handle this two options.
Also token is added to init.headers.
Add unit tests for DataRequestBuilder.addBearerToken method.
Resolves: OLPSUP-9743
Signed-off-by: Drapak Iryna Angelica<EMAIL_ADDRESS>

Codecov Report

Merging #221 into master will decrease coverage by 0.6%.
The diff coverage is 85.7%.

@@           Coverage Diff            @@
##           master    #221     +/-   ##
========================================
- Coverage    91.1%   90.5%   -0.6%
========================================
  Files          57      57
  Lines        1548    1582     +34
  Branches      186     192      +6
========================================
+ Hits         1411    1432     +21
- Misses         73      84     +11
- Partials       64      66      +2

Impacted Files
Coverage Δ

...dk-dataservice-read/lib/DataStoreRequestBuilder.ts
94.4% <85.7%> (+1.6%)
:arrow_up:

@here/olp-sdk-dataservice-api/lib/lookup-api.ts
72.5% <0%> (-27.5%)
:arrow_down:

...ataservice-read/lib/utils/RequestBuilderFactory.ts
88.6% <0%> (-4.9%)
:arrow_down:

...k-dataservice-read/lib/cache/ApiCacheRepository.ts
100% <0%> (+12.5%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bc921d...28ab1aa. Read the comment docs.

Changed a bit fix and added unit end integration tests


MpmSinewaveTest fails for 77.0

[----------] 7 tests from MpmSinewave/MpmSinewaveTest
[ RUN      ] MpmSinewave/MpmSinewaveTest.GetFreq/0
test/sinewave_test.cpp:18: Failure
The difference between freq and pitch is 78, which exceeds 0.01 * freq, where
freq evaluates to 77,
pitch evaluates to -1, and
0.01 * freq evaluates to 0.77000000000000002.

This is kind of on purpose - it proves that YIN can handle lower pitches.
https://github.com/sevagh/pitch-detection/blob/master/include/pitch_detection_priv.h#L7
https://github.com/sevagh/pitch-detection/blob/cc2e6678b80839ff2382baec007a28cb6b0d6b2d/src/mpm.cpp#L79
Looking at the code now it seems that I just discard lower values for no reason - I don't see any mentions in the paper that low pitches are invalid...

I disabled the 77.0Hz test for the MPM, and put a note in the test comment: https://github.com/sevagh/pitch-detection/blob/master/test/sinewave_test.cpp#L82
Now the test suite succeeds on every run.


Mediatyp constant removed in octokit v3.4.1

The constant PREVIEW_MEDIA_TYPE was removed in this commit and hound deployments with newer octokit versions than v3.4.0 are crashing when running RepoSynchronizationJob in this line.

How are you deploying Hound with newer octokit versions, since we have it locked in Gemfile.lock. Are you deploying some fork? I don't think this is a Hound issue, but I'm willing to help out.

Thanks for your quick response @gylaz and your offer to help :+1:
I was deploying with capistrano on a different branch to a staging machine. Maybe the gems where updated there. As I didn't see any version specification of octokit in the Gemfile, I wanted to give you guys a heads up about the 'problem'.

The master branch was updated to the latest Hound yesterday. Give that a try.


Add option to include Sent messages in Unified inbox

Checklist

[X] I have used the search function to see if someone else has already submitted the same feature request.
[X] I will describe the problem with as much detail as possible.
[X] This issue only contains a request for one single feature, not multiple (related) features.

App version
6.904
Problem you are trying to solve
There is no option to include Sent messages in Unified inbox.
Suggested solution
Add option to include Sent messages in Unified inbox, like i.e. Aqua Mail.
Screenshots / Drawings / Technical details
No response

You can already include sent messages in the Unified Inbox by going to Manage folders → [Sent folder name], then enabling the "Unify" option.

You can already include sent messages in the Unified Inbox by going to Manage folders → [Sent folder name], then enabling the "Unify" option.

I looked for it everywhere but there, thank you!

Option was already implemented in manage folders section.


Autoplay if fixed

I have fixed the autoplay but there is a delay of certain seconds as usual while playing the next video automatically
Usual time of autoplay next video is : 5 second
And delay with this code: 3-4 second (ie. automatically next video playing time is around 8-9 second)

solved


rewrite correlation script with qstat() and qlayer()

https://evamaerey.github.io/statistics/covariance_correlation.html#56
mysetseed(199402)
create_x_y(relationship = .5) %>%
data_create_scatterplot() %>%
plot_draw_mean_x() %>%
plot_draw_mean_y() %>%
plot_draw_differences_x() %>%
plot_draw_differences_y() %>%
plot_multiply_differences() %>%
plot_take_average_rectangle()
Assume qlayer() and qstat() exists:
compute_group_xmean <- function(data, scales){data |> mutate(xintercept = mean(x))
geom_xmean <- function(...){qlayer(geom = GeomVline, stat = qstat(compute_group_xmean), ...)}
compute_group_ymean <- function(data, scales){data |> mutate(yintercept = mean(y))
geom_ymean <- function(...){qlayer(geom = GeomVline, stat = qstat(compute_group_ymean), ...)}
compute_group_xmeandiff <- function(data, scales){data |> mutate(xend = mean(x), yend = y, xdiff = x - mean(x)}
geom_xmeandiff <- function(...){geom_segment(stat = qstat(compute_group_xmeandiff, default_aes = aes(color = after_stat(sign(xdiff))), ...)}
compute_group_ymeandiff <- function(data, scales){data |> mutate(yend = mean(y), xend = x, ydiff = y - mean(y))}
geom_ymeandiff <- function(...){geom_segment(stat = qstat(compute_group_ymeandiff, default_aes = aes(color = after_stat(sign(ydiff)))), ...)}
compute_group_xymeandiffs <- function(data, scales){data |> mutate(xmin = mean(x), ymin = mean(y), xmax = x, ymax = y, area = (xmax- xmin)*(ymax-ymin), ...)}
geom_xydiffs <- function(...){geom_rect(stat = qstat(compute_group_xymeandiffs, default_aes = aes(fill = after_stat(sign(area)), alpha = .2 )...)  }
compute_average_of_xymeandiffs <- function(data, scales){data |> summarize   ... A little tricky to think about.  Come back.

Really nice.
library(tidyverse)

qstat <- function(compute_group, ...){ggproto("StatTemp", Stat, compute_group = compute_group, ...)}

qlayer <- function (mapping = NULL, data = NULL, geom = "point", stat = "identity", position = "identity",
    ..., na.rm = FALSE, show.legend = NA, inherit.aes = TRUE)
{
    layer(data = data, mapping = mapping, stat = stat, geom = geom,
        position = position, show.legend = show.legend, inherit.aes = inherit.aes,
        params = rlang::list2(na.rm = na.rm, ...))
}

# https://evamaerey.github.io/statistics/covariance_correlation.html#56

# mysetseed(199402)
# create_x_y(relationship = .5) %>%
# data_create_scatterplot() %>%
# plot_draw_mean_x() %>%
# plot_draw_mean_y() %>%
# plot_draw_differences_x() %>%
# plot_draw_differences_y() %>%
# plot_multiply_differences() %>%
# plot_take_average_rectangle()

# Assume qlayer() and qstat() exists:

compute_group_xmean <- function(data, scales){data |> mutate(xintercept = mean(x))}
geom_xmean <- function(...){qlayer(geom = GeomVline, stat = qstat(compute_group_xmean), ...)}

compute_group_ymean <- function(data, scales){data |> mutate(yintercept = mean(y))}
geom_ymean <- function(...){qlayer(geom = GeomHline, stat = qstat(compute_group_ymean), ...)}

compute_group_xmeandiff <- function(data, scales){data |> mutate(xend = mean(x), yend = y, xdiff = x - mean(x), sign = factor(sign(xdiff)))}
geom_xmeandiff <- function(...){geom_segment(stat = qstat(compute_group_xmeandiff, default_aes = aes(color = after_stat(sign))), ...)}

compute_group_ymeandiff <- function(data, scales){data |> mutate(yend = mean(y), xend = x, ydiff = y - mean(y),
                                                                 sign = factor(sign(ydiff)))}
geom_ymeandiff <- function(...){geom_segment(stat = qstat(compute_group_ymeandiff, default_aes = aes(color = after_stat(sign))), ...)}

compute_group_xymeandiffs <- function(data, scales){data |> mutate(xmin = mean(x), ymin = mean(y), xmax = x, ymax = y, area = (xmax-xmin)*(ymax-ymin), sign = factor(sign(area)))}
geom_xydiffs <- function(alpha = .2, ...){geom_rect(
  stat = qstat(compute_group_xymeandiffs,
               default_aes = aes(fill = after_stat(sign))), alpha = alpha, ...)}

compute_average_of_xymeandiffs <- function(data, scales){

  xmean = mean(data$x)
  ymean = mean(data$y)
  xsd = sd(data$x)

  data |>
    mutate(xdiff = x - mean(x),                                      ydiff = y - mean(y),
           area = xdiff * ydiff) %>%
    summarize(mean_area = mean(area)) %>%
    pull(mean_area) ->
    mean_area

  data.frame(x = xmean, y = ymean,
             xmin = xmean, ymin = ymean,
             xmax = xmean + xsd, ymax = ymean + mean_area/xsd,
             sign = factor(sign(mean_area)))

}

geom_xydiffs_means <- function(...){

  geom_rect(stat = qstat(compute_average_of_xymeandiffs,
                         default_aes = aes(fill = after_stat(sign))), ...)

}

cars %>%
  ggplot() +
  aes(x = speed, y = dist) +
  geom_point() +
  geom_xmean() +
  geom_ymean() +
  geom_xmeandiff() +
  geom_ymeandiff() +
  geom_xydiffs() +
  geom_xydiffs_means(color = "black") +
  geom_smooth(method = lm)
#> `geom_smooth()` using formula = 'y ~ x'

Created on 2024-09-20 with reprex v2.1.0


Show individual discussions in a split window

Feature Description
In #126 I suggest to implement filtering of discussions. After some time of using gitlab.nvim I think that a more useful feature would be showing discussion content separately from the discussions list. I imagine it could look something like this:

I think this would make navigation in discussions much easier - now I very often lose track what thread a specific comment belongs to. I would very much prefer having this implemented before any filtering.

Hello Jakub,
With this plugin users can have the tree underneath the reviewer; to the side of the reviewer; or even underneath/side of a normal file (outside of the reviewer). Implementing these views as a split would probably interfere with most workflows so it's not something I'm keen to merge. However, someone could implement a preview popup which would be very similar to what you have here.
Essentially replicating the current contents of a discussion into a smaller, fully expanded subtree like you've shown here, and then render that in a popup view. It'd essentially involve duplicating the contents of the highlighted discussion into the popup buffer. The popup would have to be positioned relative to the current split discussion tree. Definitely worth considering, but it'd be a pretty hefty feature add. Thank you for the idea!

Hi Harrison,
Thanks for your reply, let me add some more detail on why I came up with the idea. When I first installed gitlab.nvim, the discussions were already a split window - discussions and notes. Even after they have been merged into a single window, I still prefer to have them below the reviewer, so that the reviewer windows are not too narrow (leading to wrapped lines etc.). But now I've noticed that a considerable part of my screen is empty - the place where there used to be notes.
Placing individual discussions into that empty spot seemed like a double win - using otherwise wasted space and also making the discussions more easily navigable - currently it's really difficult for me to see what are threads in a single discussions and where are the boundaries between discussions.
Maybe the clearer separation of individual discussions could be helped by adding some kind of indent markers (lines that connect nodes on the same level) in the tree. Otherwise I'll probably just stick to the simple tree type.

Sounds good, seems like the simple tree type is right for you then


denormalise poses?

I imagine the camera poses in reconstruction.json are normalised, in that they were computed from normalised image points.
I want to use these poses in a system where the pose translation is in meters. I don't know how to "denormalise" the poses in reconstruction.json so that I can use them in my system.
Do you know how could I do this?

I've been able to align the poses to an initial camera pose and it seems to work well.


REFPLTV-1146 Bring up 64bit support in Rpi4 (for both kernel and user…

… space).
Reason for change: In RPi4 64bit combatibility typecasting changes
Test Procedure: Build should be successful. rdkservices should build fine.
Risks: Low/None.

Change looks good

Internal ticket for Tracking

Internal ticket for tracking https://ccp.sys.comcast.net/browse/RDKCOM-3107


Inline styles doesn't work properly in SSR

Excerpt from a server response:

Hi @IPRIT, try ViewEncapsulation.None on the component metadata, might be helpful.


It will be great if we could modify the calendar header.

You can modify header with a help of utils

Can you please provide a small example hw to do this ?


DB API and SQLAlchemy support

And when working with other community tools such as LangChain, Querybook, Superset, SQLAlchemy plays as the driver role.
It is better that Timeplus python sdk can support it.

pep-0249
<EMAIL_ADDRESS>https://www.sqlalchemy.org/

Related ticket https://github.com/timeplus-io/superpartner/issues/34 (private repo)

(Jove Github Bot) added it to the current sprint.


ERROR  [nuxt] [request error] [unhandled] [500] Cannot read properties of undefined (reading 'dir')

Environment
ERROR  [nuxt] [request error] [unhandled] [500] Cannot read properties of undefined (reading 'dir')
Reproduction
ERROR  [nuxt] [request error] [unhandled] [500] Cannot read properties of undefined (reading 'dir')
Describe the bug

i work on nuxt 3 project and i get this error on npm run generate
Additional context
No response
Logs
No response

Would you provide a reproduction? 🙏


Fix a dependency issue that will cause deployment error.

Issue #, if available:
https://github.com/awslabs/fhir-works-on-aws-deployment/issues/565
Description of changes:
Changed the version dependency from 1.100.0 to 1.137.0
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

More information about the bug fix is described in this issue
https://github.com/aws/aws-cdk/issues/18252


Switch console to logger

Hey @dotansimha
What do you think about having a bit nicer logs? Especially to catch problems fast.

Awesome!! Thanks @jycouet !!!


Notebook/hierarchy flow

Why are these changes needed?
This notebook demonstrates how to control the conversation flow using select_speaker of the GroupChat class.

Related issue number
nil
Checks

[x] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[x] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Hi @gagb, thank you for the review, I have worked on the three points you've brought up.

Added llm_config to all 5 assistant agents.
Added llm_config to 1 user proxy agent.
Clarfied why use_cache was set to false.

This PR adds an example that demonstrates how one could create custom group chat logic. It will help others create custom such examples. The example in the notebook is very cleverly designed to demonstrate information flow between the agents.

Thank you for the kind words. :)

Thanks for the PR. The notebook output seems incomplete, and there is some warning which needs to be checked.

It does look incomplete. Tho on my local run it output messages consistent with the diagram. @joshkyh did you commit an earlier version of your nb?

Thanks both, I would work on this over the next 24 hours.

Thanks for the PR. The notebook output seems incomplete, and there is some warning which needs to be checked.

Thanks for the review @sonichi, please see responses in-line with your comments.

Codecov Report

Merging #482 (a4e6ae8) into main (1c4a5e6) will decrease coverage by 1.84%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
- Coverage   32.39%   30.55%   -1.84%
==========================================
  Files          22       22
  Lines        2772     2772
  Branches      630      630
==========================================
- Hits          898      847      -51
- Misses       1807     1854      +47
- Partials       67       71       +4

Flag
Coverage Δ

unittests
30.55% <ø> (-1.77%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

Would you like to add a link in https://microsoft.github.io/autogen/docs/Examples/AutoGen-AgentChat and https://microsoft.github.io/autogen/docs/Use-Cases/agent_chat#diverse-applications-implemented-with-autogen ? It's OK to do it in a separate PR.

Yes, no problem, I'll work on this in a new PR. :)

Would you like to add a link in https://microsoft.github.io/autogen/docs/Examples/AutoGen-AgentChat and https://microsoft.github.io/autogen/docs/Use-Cases/agent_chat#diverse-applications-implemented-with-autogen ? It's OK to do it in a separate PR.

Yes OK. I'll work on this in a separate PR.

There is still a code format issue: https://github.com/microsoft/autogen/actions/runs/6761693140/job/18376828027?pr=482 to fix before merging.

There is still a code format issue: https://github.com/microsoft/autogen/actions/runs/6761693140/job/18376828027?pr=482 to fix before merging. BTW, have you tested the new pyautogen version v0.2.0b1? "api_base" has been renamed into "base_url".

Thanks for the review @sonichi.

I have rebuilt my .devcontainer to use the 0.2.0b1 release, and changed to "base_url".

I have passed pre-commit run --all-files locally before pushing this time, apologies. Still learning pre-commit. :)

Thanks for the patient guidance everyone!


[feature]: add AuxLeafStore for dynamic aux leaves in lnd

Tracking issue for https://github.com/lightningnetwork/lnd/pull/8562

Fixed in https://github.com/lightningnetwork/lnd/pull/8684


Jesse: Watch wabisabistyles.com

Jesse requests the watch of the watch_keyword wabisabistyles\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

wabisabistyles\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Mast in Charcoal HQ


Minification with merge not working properly

Songsear.ch uses bootstrap and when running for two different URLs it clearly fails to merge the CSS.
Consider:
./bin/minimalcss.js https://songsear.ch/ https://songsear.ch/q/Have%20sweeter%20sound..%20now%20i%20see

In the output there are two distinct occurrences of:
html{font-family:sans-serif;-webkit-text-size-adjust:100%;-ms-text-size-adjust:100%}

Ah! The reason is that csso can't merge across blocks separated by a /*! important */ comment. E.g. If this is the input:
html{font-family:sans-serif;-webkit-text-size-adjust:100%;-ms-text-size-adjust:100%}
/*! Source: https://github.com/h5bp/html5-boilerplate/blob/master/src/css/main.css */
html{font-family:sans-serif;-webkit-text-size-adjust:100%;-ms-text-size-adjust:100%}

When running csso.minify the output is, the exact same as the input.
However, if you remove that second line the output does become
html{font-family:sans-serif;-webkit-text-size-adjust:100%;-ms-text-size-adjust:100%}

Hmmm... What to do? Basically, csso.minify will only do its magic per block of CSS separated by "important-comments". If the "total CSS" consists of some CSS from Bootstrap, some from Normalize.css and some from your own, there is bound to be overlap.
In on real example I tested with, the file was 13,025 bytes but when csso.minify was allowed to minify "across blocks" it was able to get it down to 12,528 bytes.

https://github.com/peterbe/minimalcss/commit/a26b290e7c02de1b1ac530094d4ad77394f65062 solves this.


Add support for Form parameters in Helidon SE

We currently support path parameters and query parameters. It would be useful to add support for form parameters.
This may be either through direct support in ServerRequest or through entity supports, such as
request.content().as(FormParams.class) (if I remember correctly, form parameters are passed in entity).

Even though forms can be seen as a special case of the more generic multipart, perhaps we can provide support for this sooner and later tweak the implementation if needed when multipart becomes available. The form API shouldn't really change if/when we make that change.

If we can agree on an API to support form parameters, our team may be able to contribute to implement this feature. Any suggestion for an API or any pointers to help us get started?


stock nginx configuration misconfigured?

running a bancho.py instance at https://halcyon.moe, wanted to try this out
running the api in development mode

leads me to the api on the root domain, where the frontend should be (web.halcyon.moe)
running the api in production mode will eternally redirect until the browser errors out
nginx configuration attached, symlinked as it should be a la the instructions in the readme
https://files.catbox.moe/o7tkqd.conf

Hey thanks for checking this out. I'm surprised someone stumbled upon this frontend. So I ran though the install on a local VM using your config file and I didn't have any issues. From what I can see, your nginx config looks good to me.
You mentioned the nginx config being symlinked, however the setup doesn't actually include any symlinks. The conf is stored in /etc/nginx/conf.d, which is supposed to be the "newer" method of storing nginx configs.
https://github.com/salad-server/lettuce-web/blob/main/README.md?plain=1#L69
There is a chance that the current frontend you have running is preventing lettuce from running. I'm not sure if this will help, but here are my exact configs that I'm using to run the frontend.

config.json
config.yaml
lettuce.conf

Also, you can find a live version of the server here (ignore the guy). I also recommend you read this. If you still can't get it running feel free to pm me or continue the thread.
Nice server btw. The material design is pretty well done.

i thought it was symlinked, guess not -- however i do have a symlinked nginx configuration in my gulag installation, so i just placed the lettuce stuff there and removed the copy to conf.d
instead of web (frontend) and conn (api) both leading to conn, web now throws a 500 error with nothing in the console to tell me why
i have copied your configuration files as closely as i can

turns out this was a permissions issue
running sudo tail -f /var/log/nginx/error.log gave me

2022/09/10 08:15:56 [crit] 147912#147912: *59326 stat() "/home/jupiter/halcyon/lettuce-web/dist/index.html" failed (13: Permission denied), client: <IP_ADDRESS>, server: web.halcyon.moe, request: "GET /favicon.ico HTTP/1.1", host: "web.halcyon.moe", referrer: "https://web.halcyon.moe/"
2022/09/10 08:15:56 [error] 147912#147912: *59326 rewrite or internal redirection cycle while internally redirecting to "/index.html", client: <IP_ADDRESS>, server: web.halcyon.moe, request: "GET /favicon.ico HTTP/1.1", host: "web.halcyon.moe", referrer: "https://web.halcyon.moe/"

running sudo chmod -R o+x /home/halcyon fixes this issue, and allows the user to connect to the website.


Model functions and points

Updated model functions to v4
Updated points to penalize for use of cleaner fish and salmon mortality

ok


CLI: Add sensors commands

This PR adds the sensors, sensors create, sensors update, sensors send-data and sensors simulate-data commands to the CLI. This PR depends on #127.

sensors create allows to create sensors for all the available restaurants,
sensors update allows to update all the sensors for all the available restaurants,
sensors send-data allows to send sensor measurements using UL20 for a single sensor,
sensors simulate-data allows to simulate a sensor sending data over time.

This will fail until https://github.com/telefonicaid/iotagent-ul/issues/135 is fixed.

We have tried this PR four times from a clean state ( removing all containers and images) and we still get the following error:
devtourguide@devtourguide:~/workspace/fiwareulpgc/fiware-devguide-app$ ./tour-guide sensors create
Waiting for tourguide to be ready [1]... OK.
Generating sensors for restaurants...
Response code: 400
Response headers: { 'x-powered-by': 'Express',
  'fiware-correlator': 'eddb9e57-f9b9-48aa-ba4f-7dfaec0ca81b',
  'content-type': 'application/json; charset=utf-8',
  'content-length': '118',
  etag: 'W/"76-nwOyJPj8ZTs2yftSro6J6w"',
  date: 'Thu, 08 Sep 2016 20:07:03 GMT',
  connection: 'close' }
Response data: {"name":"MISSING_CONFIG_PARAMS","message":"The following mandatory configuration parameters were missing: [\"type\"]"}
{"name":"MISSING_CONFIG_PARAMS","message":"The following mandatory configuration parameters were missing: [\"type\"]"}

In order to test this PR we are following this steps:
git checkout develop
git fetch --all
git merge upstream/develop
git checkout -b test_branch
git merge dmabtrg/feature/cli-sensors
./tour-guide start
wait until tourguide started
./tour-guide sensors create

I'll check it out!

The issue here was the same as with the Keyrock image. Until the image is build with the new changes, the changes are not in the image so, the cli scripts for the sensors are not inside the container. To test it, you can modify the docker-compose.yml to have the scripts available inside the container adding a volume in Tourguide:
tourguide:
    image: fiware/tutorials.tourguide-app:latest
    hostname: tourguide
    container_name: tourguide
    links:
        - orion
        - keyrock
        - idas
        - cygnus
    environment:
        - ORION_HOSTNAME=orion
        - ORION_NO_PROXY_HOSTNAME=orion
        - ORION_PORT=1026
        - ORION_PEP_ENABLED=false
        - IDAS_PORT=7896
        - IDAS_ADMIN_PORT=4041
        - IDAS_FIWARE_SERVICE=tourguide
        - IDAS_FIWARE_SERVICE_PATH=/
        - IDAS_API_KEY=tourguide-devices
        - IDM_HOSTNAME=keyrock
        - IDM_PORT=8000
    volumes_from:
        - keyrock
    volumes:
        - ../tutorials.TourGuide-App:/home/tourguide/tutorials.TourGuide-App

Then you can start it and create the sensors:
./tour-guide start
wait until tourguide started
./tour-guide sensors create

I've tested and worked for me!

Thanks for the test instructions! We have followed them and now we can use ./tourguide sensors create but we have a problem related to simulate data. If we perform ./tour-guide sensors create  and then ./tour-guide sensors simulate-data -i b4056ec69fece581ef3319aba1b72c11cc4684ba-dining-temperature -t temperature -d 5 we get the following:

If we perform ./tour-guide sensors simulate-data -i b4056ec69fece581ef3319aba1b72c11cc4684ba-dining-temperature -t temperature -d 5 without create sensors we get:

Are we using the command incorrectly?

Fixed in 2dcd7c1 . Still, I'm having some issues using send-data and simulate-data. By executing the command, I get the following response:
./tour-guide sensors send-data -i d0136015ae5bda329a2d3211bfbfca53705ac687-kitchen-temperature -d 't|18'
{"name":"DEVICE_GROUP_NOT_FOUND","message":"Couldn\t find device group"}

But I still don't know the reason. I guess it's something related with https://github.com/telefonicaid/iotagent-ul/issues/135#issuecomment-245243227 so I'll have a look and ping you back!

I've updated the latest commit 7edf8601a3f1e92c4aac4a9d15f30e5b1bf68be6 fixing the last issue. Could you test it? Thanks!

LGTM


BitCoin parsing is wrong.

code
    money = Money.parse('₿1.99', CommonCurrencies().btc);
    expect(money.format('#.###'), '1.990');

result
Expected: '1.990'
  Actual: '1.000'

The parsing is actually correct (at as money defines it currently).
Money.parse uses the currencies format to parse the amount.
As the default format for BTC is S0 it will only parse out the integer component of the passed amount.
So to correctly parse the amount you passed use:
final money = Money.parse('₿1.99', CommonCurrencies().btc, format: 'S0.00');

There is a question here about how money parses amounts.
Should it parse in minor units that exceed the passed format?

@ttyniwa I've had a harder look at this problem and I've made some changes to the api to better handle this type of situations.
From the 2.3.0 release notes (which I've just published):

In response to issue #53 we have modified how excess minorUnits (decimals) are parsed.  Even if the parse pattern doesn't contain decimal places we will still parse decimal places in the Monetary Value. This ensures that we always retain the original parsed values precisions. However the api is currently quiet on how precision is treated when parsing decimals. We have now documented the api to state that we will parse upto the Currencies defined precisions.

This means:
if you pass a monetary value with decimal digits in excess of the Currencies precision they will be ignored.
If you pass a monetary value with decimal digits in excess of the passed pattern then they will be parsed upto the precision of the Currency.

Fixed a bug where parsing a no. of the form '.99' (i.e. no leading major digit) would thrown an exception.

The result of these changes is that your example will now work as you expected.
I'm closing this issue but If you find further issues feel free to re-open it.

@ttyniwa I do have question.
I'm wondering if the default pattern for bitcon is correct.
Currently it is $0 with a precision of 8.
For most currencies the no. of decimals in the default pattern matches the precision.
Should this be changed?
/// current
final Currency btc = Currency.create('BTC', 8, symbol: '₿', pattern: 'S0');
/// proposed
final Currency btc = Currency.create('BTC', 8, symbol: '₿', pattern: 'S0.00000000');

Thank you for your prompt response.
This is the behavior I was hoping for.

Currently it is S0 with a precision of 8.
For most currencies the no. of decimals in the default pattern matches the precision.
Should this be changed?

In my opinion, BTC pattern should be 'S0.########'.
A single digit, omitted if the value is zero

The new BTC pattern is:
final Currency btc = Currency.create('BTC', 8, symbol: '₿', pattern: 'S0.00000000');
This is to make it consistent with other currencies.
You can still get the output you desired by using your proposed pattern be either
registering your own version of BTC via Currencies.register(btc);
or supplying your own pattern when calling Money.format()


How to update or increment previously inserted values?

Let's say I'm tracking the value of items 0-n in a t-digest.   As time goes on, the value for item-i increases.  I'd like to update the previous value in the t-digest to reflect the new state.  I don't think I can just add the new value for item-i because it will distort the data.   Is there a way to update or remove previous values?
Thank you

I can't see a good way to do this because it would change our trade-offs of accuracy. There are some approaches that can allow samples to be removed, but these all lose accuracy. The most egregious problem occurs with the modification of the extreme values (because we maintain those exactly). If those move, we can't know the new extreme value.
I am going to close this as WONT_FIX


Uncaught TypeError when try to add members from drop down

Possibly related: rancher/rancher#19676
Version: Master (4/22/19)
What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Create a cluster and for the roles drop-down pick an entry:

Do the same for GDNS entries / MCapp / etc across the product

Result:
You will get a TypeError "this.change is not a function" line 375 of component.js
Uncaught TypeError: this.change is not a function
    at n.setSelect (component.js:375)
    at n.selectUnGroupedItem (component.js:86)
    at e.n._run (backburner.js:1064)
    at e.n._join (backburner.js:1040)
    at e.n.join (backburner.js:759)
    at h (index.js:165)
    at glimmer.js:6123
    at s (index.js:135)
    at HTMLDivElement.<anonymous> (glimmer.js:6122)

Version: Master (v2.3) (6/13/19)
I can confirm the Uncaught TypeError is no longer happening and this is working correctly now without any issues.


feature request: also support https://github.com/urfave/cli

urfave/cli is also a useful package for managing flags and command line arguments.
Having support for generating man pages also for urfave/cli would be great.
Thanks for creating mango.

Good idea, I'll see what I can do!


Added deploy step

No need to have an additional task, you can simply do sd-builder build config. The only caveat is that the two tasks are executed in parallel. If that's not desirable, we can consider supporting  sequential execution.


Error deleting secret from ExtensionContext.secrets on Windows

Does this issue occur when all extensions are disabled?: N/A

VS Code Version: 1.67.0
OS Version: Win11 (also seen on Win10)

Steps to Reproduce:

Add a secret to the extension secret store via ExtensionContext.secrets.store()
Try removing the secret with ExtensionContext.secrets.delete()

Expected:
Secret is removed
Actual:
An error is thrown:
{
    "message": "Cannot delete password",
    "name": "Error",
    "stack": "Error: Cannot delete password\n    at I.$deletePassword (vscode-file://vscode-app/c:/Users/username/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1712:49953)"
}

Found via https://github.com/microsoft/vscode-docker/issues/3515.

May be due to https://github.com/microsoft/vscode/commit/042921eee9e3c6b214271ca8b6153a5963c21a92.

Closing since we won't need to do anything to pick up a fix.

pinging @TylerLeonhardt

Also started seeing this on macOS

This bug has been fixed in the latest release of VS Code Insiders!
@bwateratmsft, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version 6428d0fc7dae5801cdaf2d160ac39a3dfc8f0c06 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!

/verified


“Uncommented issue” is not always a problem

The maintainers might create issues to track their task, as a to-do list.

Agreed! In fact, with this in mind I originally set up the code so that if the user who opened the issue is the same as the user who owns the repo, it won't count as a problem. I think in 90% of cases, the to-do list use case will be fine. For instance, this uncommented issue does not show up as a problem with Forkability because I created it.
However, I did not account for the possibility that multiple people may be maintainers, or that the repo may be owned by an organisation. Do you mind if I edit your issue slightly to reflect these things?

Do it.
--
Chris Warrick https://chriswarrick.com/
Sent from my Galaxy S3.
On 1 Sep 2015 5:19 pm, "Daniel Hough"<EMAIL_ADDRESS>wrote:

Agreed! In fact, with this in mind I originally set up the code so that if
the user who opened the issue is the same as the user who owns the repo, it
won't count as a problem. I think in 90% of cases, the to-do list use case
will be fine. For instance, this uncommented issue
https://github.com/basicallydan/forkability/issues/10 does not show up
as a problem with Forkability because I created it.
However, I did not account for the possibility that multiple people may be
maintainers, or that the repo may be owned by an organisation. Do you mind
if I edit your issue slightly to reflect these things?
—
Reply to this email directly or view it on GitHub
https://github.com/basicallydan/forkability/issues/57#issuecomment-136757736
.


Added FAQ item for minimum SAS policy permissions

Added FAQ item for minimum SAS policy permissions required when exporting data to Azure Event Hub

Learn Build status updates of commit 183b7d2:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/defender-for-cloud/continuous-export.md
:warning:Warning

Details

articles/defender-for-cloud/continuous-export.md

Line 251, Column 175: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/defender-for-cloud/export-to-splunk-or-qradar#step-1-create-an-event-hubs-namespace-and-event-hub-with-send-permissions' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 251, Column 175: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/defender-for-cloud/export-to-splunk-or-qradar#step-1-create-an-event-hubs-namespace-and-event-hub-with-send-permissions' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 545fa1b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/defender-for-cloud/continuous-export.md
:warning:Warning

Details

articles/defender-for-cloud/continuous-export.md

Line 251, Column 175: [Warning: file-not-found - See documentation] Invalid file link: './export-to-splunk-or-qradar'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit f87f146:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/defender-for-cloud/continuous-export.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@bmansheim
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Add option to keep metadata

This PR adds the option to preserve the image metadata. More explanation https://manpages.debian.org/stretch/optipng/optipng.1.en.html

Hey folks, -strip all causes optipng to break my APNG files, so it would be very nice to be able to turn this off. Would anybody mind if I resubmitted this PR with the changes requested?


User reports validation types do not work when sending a signature request with the PHP SDK

"We have started using the Validation Types but it appears they have no affect. Alphabetical fields still accept numerals, SSN fields accept less than 9 digits, etc.
$embedded_request = new HelloSign\EmbeddedSignatureRequest($request, $client_id);
try {
$response = $client->createEmbeddedSignatureRequest($embedded_request);
But I see the uxVersion is supported there also:
public function createEmbeddedSignatureRequest(EmbeddedSignatureRequest $request, $ux_version = null)
$request = new HelloSign\TemplateSignatureRequest;
$request->setTemplateId(...)
$request->setSubject(...);
$request->setMessage(...);
$request->setSigner(...);
$request->setCustomFieldValue(...);
$embedded_request = new HelloSign\EmbeddedSignatureRequest($request, $client_id);
try {
$response = $client->createEmbeddedSignatureRequest($embedded_request,2); // UX version 2
The Validation Types are still not enforced. The Labels in our templates are still not pre-filled when used in multiple forms."

As discussed with @johnnycupcakes there does not appear to be an issue with this functionality and logically if there was an issue it would most likely be tied to the HelloSign application directly rather than this SDK.


accept only image/* type of file

currently we you select a file you see all the file selectable in finder window, if you can add some option to select only image/* it will be great. I have used dropzone they have this feature https://www.dropzonejs.com/#config-acceptedFiles
Let me know if its already there

Yes, you can specify the MIME types for the local service: https://uppload.js.org/services/local:

In the constructor parameter, you can specify the mime types you want to support and the maximum file size. By default, JPG, PNG, and GIF images are allowed, since Uppload is primarily an image uploader (but you can easily extend it to be a general-purpose file uploader).

const localServiceWithVideo = new Local({
  maxFileSize: 25000,
  mimeTypes: ["image/png", "image/jpeg", "video/mp4"]
});


CVE-2024-25885

I didn't see any issue open for this security advisory: https://github.com/advisories/GHSA-jj5c-hhrg-vv5h.
Is there any work taking place towards correcting this?

I am not sure how these advisories are usually communicated with the affected packages (given that there is a (possibly outdated) security policy as well), but general activity on this repository tends to be low and I am not aware of any previous reports or fixes (although not being a maintainer myself).

@Trupal00p Thanks a lot for bringing this issue to the table! I did not receive any information on this, our security policy lists luisza {at} gmail.com as recipient for responsible disclosure requests, @luisza did you receive any mail?
In any case, I think we should update the policy, since this package does not guarantee security maintenance anymore due to the lack of maintainers.
If somebody wants to contribute a fix for this issue, PRs are very welcome.

Gotcha, just want to check before I redid any work. I just opened a PR with fixes for this.

to fix your trouble check this solution click
maybe this will solve your problem.


No PIM Join messages

Hi,
I'm using pimd-2.3.2. my setup is pretty simple
R1 is RP
MCAST RECVR <-->  R1(little endian) <------> R2 (big endian)   <------> MCAST SENDR   = works
MCAST SENDR <-->  R1(little endian) <------> R2 (big endian)   <------> MCAST RECVR   = works
R2 is RP
MCAST RECVR <-->  R1(little endian) <------> R2 (big endian)   <------> MCAST SENDR   = works
MCAST SENDR <-->  R1(little endian) <------> R2 (big endian)   <------> MCAST RECVR   = fails
Only the last case fails, it happens that R2 is RP and when R1 starts sending the mcast packets , I expect R2 to send "PIM JOIN/PRUNE" message to R1 and packet would flow but its not happening.
Curiously, if R1 and R1 are both little endian , there is no problem and all cases work.
Is this endianess problem or something else?

In the last paragraph I'm assuming you mean "if R1 and R2" are both little endian?
Yes, I wouldn't be at all surprised if this turns out to be an endian issue.

@jp-t What do you think, is it possible your fixes in a9aaeb4 and a1a9b5e addressed this?

I don't think so, because my fixes are only related to SSM and the pseudo RP it uses.
In the failing setup, R1 is DR and sends encapsulated data frames to R2 "register" port, I would suspect an endianness problem in the encapsulation/decapsulation.
@pramoddevendra: How does R1 know the RP? from static configuration or from negotiation? Could you run tcpdump on R2 to see if the link to R1 is actually receiving register frames?
I think R2 will not send join messages if it cannot identify R1 as the DR for the source.

Since I only use big-endian devices I cannot know for sure, but reading the code, there cannot be an issue in registers encapsultation. But there could be one in BSR/RP negotiations.

@jp-t Thank you for taking the time to respond!  Maybe I get some time to look into this, or someone else beats me to it. Either way your info is most helpful!

Possibly related fix 892acbe, found by Ventus Networks, on master now.

I have tried to recreate the issue above with various configurations.
With the standard configuration BSR/RP-Cand they often do not agree on who is the RP for some groups. If they both think themselves as the RP, no register/join will be sent.
When using static RP the problem goes away.
Also seems to be fixed on latest master branch.

@josvarix That is awesome feedback, thank you so much! :fireworks: :rocket: :smiley:
I suspected as much, a year ago, but wasn't really sure.  Guess this means we can close this issue now.


.NET MAUI iOS can't debug or publish arm-64 without iossimulator-x64

From @rstolpe on Wed, 28 Dec 2022 21:21:07 GMT
Description
you can't debug or publish iOS-arm-64 without the folder iossimulator-x64.

Steps to Reproduce

delete all the folders inside the Debug folder both the one that are located in obj and bin.
In the .csproj file add the following as debug and release, make sure that you delete the other enteries.

	<PropertyGroup Condition="$(TargetFramework.Contains('-ios')) and '$(Configuration)' == 'debug'">
		<RuntimeIdentifier>ios-arm64</RuntimeIdentifier>
		<CodesignEntitlement>Entitlements.plist</CodesignEntitlement>
		<ArchiveOnBuild>true</ArchiveOnBuild>
		<BuildIpa>true</BuildIpa>
		<IpaPackageName>Mvi</IpaPackageName>
	</PropertyGroup>
	<PropertyGroup Condition="$(TargetFramework.Contains('-ios')) and '$(Configuration)' == 'Release'">
		<RuntimeIdentifier>ios-arm64</RuntimeIdentifier>
		<CodesignEntitlement>Entitlements.plist</CodesignEntitlement>
		<ArchiveOnBuild>true</ArchiveOnBuild>
		<BuildIpa>true</BuildIpa>
		<IpaPackageName>Mvi</IpaPackageName>
	</PropertyGroup>

Now try to debug or build you will get an error that it's not possible.

Link to public reproduction project repository
don't have
Version with bug
7.0 (current)
Last version that worked well
Unknown/Other
Affected platforms
iOS
Affected platform versions
iOS 16
Did you find any workaround?
Yes,

Run the debug or build without the <RuntimeIdentifier>ios-arm64</RuntimeIdentifier> line.
Now add <RuntimeIdentifier>ios-arm64</RuntimeIdentifier> back and then run the build or debug again and now it will work.

Relevant log output
No response

VS bug #1748626

Copied from original issue dotnet/maui#12323

From @KSemenenko on Fri, 30 Dec 2022 21:30:48 GMT
Yah this is annoying one

From @rstolpe on Sat, 31 Dec 2022 08:27:26 GMT
It's the same for Mac Catalyst

From @mattleibow on Fri, 06 Jan 2023 15:28:43 GMT
@rolfbjarne thoughts?

From @msftbot[bot] on Fri, 06 Jan 2023 15:28:58 GMT
Hi @rstolpe. We have added the "s/needs-repro" label to this issue, which indicates that we require steps and sample code to reproduce the issue before we can take further action. Please try to create a minimal sample project/solution or code samples which reproduce the issue, ideally as a GitHub repo that we can clone. See more details about creating repros here: https://github.com/dotnet/maui/blob/main/.github/repro.md
This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

From @rstolpe on Fri, 06 Jan 2023 16:11:48 GMT
Why? You have everything above. No need for any code Mr. boot :)

From @rstolpe on Sat, 07 Jan 2023 19:28:21 GMT

Hi @rstolpe. We have added the "s/needs-repro" label to this issue, which indicates that we require steps and sample code to reproduce the issue before we can take further action. Please try to create a minimal sample project/solution or code samples which reproduce the issue, ideally as a GitHub repo that we can clone. See more details about creating repros here: https://github.com/dotnet/maui/blob/main/.github/repro.md
This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

You have everything you need above

From @rolfbjarne on Mon, 09 Jan 2023 09:09:30 GMT

Run

How? Are you using VS for Mac? VS for Windows? Command line? VSCode?

From @rstolpe on Mon, 09 Jan 2023 10:22:48 GMT

Run

How? Are you using VS for Mac? VS for Windows? Command line? VSCode?

In this I was using vscode on MacOS

From @rolfbjarne on Mon, 09 Jan 2023 11:53:46 GMT
This is an issue in VSCode then (or an extension) - @mattleibow do you know where this should go?

From @mattleibow on Thu, 12 Jan 2023 19:39:53 GMT
Before we move the issue to VSCode, @rstolpe can you run this app using the command line?
@rolfbjarne  what would be the commands to use in order to determine if the launch is failing because the build did not happen properly for some reason?

From @rstolpe on Thu, 12 Jan 2023 20:16:30 GMT
@mattleibow  I can try that tomorrow.

From @rolfbjarne on Fri, 13 Jan 2023 11:05:48 GMT

@rolfbjarne what would be the commands to use in order to determine if the launch is failing because the build did not happen properly for some reason?

I'm not sure I understand, if the app wasn't built properly, there should have been a build error. The only real way to ensure a build happened properly (if there were no build errors), is to run the actual app to see if it works.

From @rstolpe on Fri, 13 Jan 2023 19:32:11 GMT

Before we move the issue to VSCode, @rstolpe can you run this app using the command line?
@rolfbjarne  what would be the commands to use in order to determine if the launch is failing because the build did not happen properly for some reason?

Everything work from terminal.
Vs2022 for Mac are throwing many false positiv errors. Can I report them somewhere?

From @rolfbjarne on Fri, 13 Jan 2023 20:54:22 GMT

Vs2022 for Mac are throwing many false positiv errors. Can I report them somewhere?

Yes: menu "Help" -> "Report a Problem"

From @msftbot[bot] on Thu, 16 Feb 2023 19:26:48 GMT
Thanks for the issue report @rstolpe! This issue appears to be a problem with Visual Studio, so we ask that you use the VS feedback tool to report the issue. That way it will get to the routed to the team that owns this experience in VS.
If you encounter a problem with Visual Studio, we want to know about it so that we can diagnose and fix it. By using the Report a Problem tool, you can collect detailed information about the problem, and send it to Microsoft with just a few button clicks.

Go to the Visual Studio for Windows feedback tool or Visual Studio for Mac feedback tool to report the issue
Close this bug, and consider adding a link to the VS Feedback issue so that others can follow its activity there.

From @rolfbjarne on Fri, 24 Feb 2023 10:23:48 GMT
This seems like an issue in VSCode, so I'm moving the issue there.

Sorry, the error message is showing an error thrown from dotnet or a dotnet extension, can you tell me how this is a VS Code issue?

@akoeplinger would you happen to know if this should be in https://github.com/microsoft/vscode-mono-debug instead? (or if there's a better place for it)

Debugging .NET MAUI apps in VSCode is not yet officially supported so there's not really any better place for this.

Yeah I think you can close it.


Adding detailed comments, making things final and reducing visibility

I saw some classes are marked as final but others are not. Is there a general rule to determine when we should make a class final?

The way I'm trying to set it up is that each class is either:

final
abstract
package-private

I wasn't super thorough in making sure everything has been covered yet though.

PTAL

LGTM


Automatically open card modal based on the URL

This PR adds the following features:

Updates the URL hash when a card is opened
If the initial URL has a valid hash, automatically open the card modal.

For some reason I was having weird errors when trying to run the ClojureScipt tests. I decided to change how some of the JavaScript code is loaded and make it possible to run these tests through lein cljsbuild test. In a future PR I'll remove the ClojureScript tests from the browser and make it possible to run then with autotest from the command line.

@emfigo @andistuder @timstott @johnwake @jamesmarkcook please :eyes: !

I'm not one to be judging your Clojure @cassiomarques but all looks good to me :blush:
You must let me know what you use to create those fancy GIFs :+1:

LGTM @cassiomarques Nice changes :+1: :bow:
:memo: Now i've pulled the OAuth changes i will have a play around locally.

@jamesmarkcook I use this app: https://itunes.apple.com/us/app/picgif-lite/id844918735?mt=12
You need to record your screen using Quicktime and then use PicGif to create the gif. The default number of frames is too low, usually I change it to something between 100 and 200, depending on the length of the original video :smiley:

@johnwake Thanks, do let me know if you find any :bug: :bee: :beetle: !


Missing grant info

Describe the bug
Some of our grants in Elements do not show data about dates or funder, even though most do. What is different about them?
To Reproduce
These are the grants that are in Elements only as Titles, associated with investigators. How do they appear in our feed to Elements? Do they have other data elements?
ark:/87287/d7gt0q/grant/119843
ark:/87287/d7gt0q/grant/114244
ark:/87287/d7gt0q/grant/127601
ark:/87287/d7gt0q/grant/116828
ark:/87287/d7gt0q/grant/110381

I don't find these IDs in our feed file. These examples where uploaded to QA on our first import attempt (9/27). Since then we have narrowed our selection and these grants were excluded. We also fixed our import file so that the complete records are mapped. We have no way to delete these or we would do that. They will be deleted when CDL does a data refresh from prod to QA.

Great!


jQuery compatible (but not required) + AMD + CommonJS?

I'm a bit confused with so many different UMD templates.
What if I want to build a javascript library, which can be used by itself, or together with a jQuery adaptor, and I also want it to be compatible with AMD and commonJS?
In that case, which of the UMD templates is the appropriate one?

@alvarotrigo your required template format is jquery template you can handle additionaly if jquery is not available you can attach your code to the window level https://github.com/umdjs/umd/blob/master/templates/jqueryPlugin.js


Bug: extract_time preprocessor removes time axis from data array with one time value.

Hi,
just reporting a bug. The extract_time array removes the time dimension from observations files when the observation files has length 1 in the time dimension. This causes other preprocessors to fail (like time_slice, loaded as time_average), when they assume that the time dimension exists.
I'm processing an annual climatology for WOA oxygen as described in issue #640, to help debug, I've turned on the save_intermediary_cubes boolean.
The third processed file is: 03_cmor_check_metadata.nc
mole_concentration_of_dissolved_molecular_oxygen_in_sea_water / (mol m-3) (time: 1; depth: 102; latitude: 180; longitude: 360)
     Dimension coordinates:
          time                                                                 x         -              -               -
          depth                                                                -         x              -               -
          latitude                                                             -         -              x               -
          longitude                                                            -         -              -               x

But this cube becomes: 04_extract_time.nc
mole_concentration_of_dissolved_molecular_oxygen_in_sea_water / (mol m-3) (depth: 102; latitude: 180; longitude: 360)
     Dimension coordinates:
          depth                                                                 x              -               -
          latitude                                                              -              x               -
          longitude                                                             -              -               x

which is missing the time dimension now.
I suspect that this is caused by the standard numpy trick  of returning an n-1 dimensions array when a slice removes a single point. ie:
import numpy as np
a = np.zeros((3,2,2,2,))
b = a[0]
print(a.shape)
  (3,2,2,2)
print (b.shape)
  (2,2,2)

In this case, we want the shape of b to be (1,2,2,2), not (2,2,2).
I hesitate to edit the time_slice as it is used in every recipe and wouldn't want to break it for another edge case. Any ideas?

I've solved this bug with only a couple changes needed. The changes are in cmor/check.py: line 336 and 337, and preprocessor/_time_area.py, lines 48-54.
I hope to address some other issues and them make a larger pull request which would include this bug fix.

If possible, we would prefer one PR for each issue addressed.
This makes the review easier and the bugfix more quickly available to the others.

Is it possible to create a PR with these two bug commits? (0ac0082 and a9d6a79)

Yes. Create a new branch from version2_development and use git cherr-pick to apply those changes (https://git-scm.com/docs/git-cherry-pick). Then you can create a pull request just to address this issue


Missing website

This repository is missing a website link in its description. Reasons to do this are listed in this Discourse thread.
https://frbny-dsge.github.io/DSGE.jl/latest/ is an example of a good link for this purpose.

Thanks for the heads up, README has been updated.

@chenwilliam77 I meant it should be there:

My bad, thanks for the clarification.


yarn install issue

Having an issue with yarn though it seems to work fine when I do npm install. Any insights? Thanks in advance.

NPM version (npm -v): 8.1.0
Yarn version (yarn -v): 1.22.17
Node version (node -v): 16.13.0
Node Process (node -p process.versions): yarn install
Node Platform (node -p process.platform): darwin
Node architecture (node -p process.arch): arm64
node-sass version (node -p "require('node-sass').info"): 6.0.0
npm node-sass versions (npm ls node-sass):
├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>deduped

<EMAIL_ADDRESS>doesn't support Node 16  https://github.com/sass/node-sass#node-version-support-policy

Okay, but could you help me understand how to upgrade it? Because in my package.json node-sass appears as 6.0.0. Also why would it work for npm but not yarn?

Found a fix. Add this to package.json:
"resolutions": {
    "node-sass": "6.0.0"
  },

still would like a better understanding as to why it would have worked for npm and not for yarn prior to my fix.

Found another solution. Updated gulp-sass to 5.0.0


Merge master into the edit views ui branch

The only changes that won't be resolved by this are differences in girder/girder_large_image/web_client/templates/itemList.pug

@jeffbaumes This appears to do no harm to the edit views branch.


How to choose the loss function for Binary Autoencoders

Hi all,
I wish to train a stacked auto-encoder, but the input vectors** are binary, ie [0,0,1,1,0,1..1], and they are quite sparse......**
so picking the loss function as mse doesnt work so well, I wish to know

will it makes sense  changing the last layer of decoder into a **softmax activation **
which loss function should I use.

Thanks

binary_crossentropy

@lemuriandezapada
no, it is not a one-hot vector, it has multiple ones in it.


validation doesn't work in a particular situation

the req.assert inside if(data === null) { never works! i get output in console.log, but it never causes validation error. Whereas the second one works perfectly.
async.eachSeries(associatedProfessionals_arr, function(item, cb) {
	console.log(item);
	var pair = item.split('[id:');

	if(pair[1]) { // Check if it matches with a profile _id
		var given_id = pair[1].split(']')[0];
		if(given_id.match(/^[0-9a-fA-F]{24}$/)) {
			Profile.findById(given_id, function(err, data){
				if(err) throw err;
				console.log(data);
				if(data === null) {
					console.log('couldn\'t find');
					// isEmail() & phone has nothing to do. It just generates the error.
					// req.assert('phone', 'The given associated id doesnt match.').isEmail();
					req.assert('associatedProfessionals', 'The given associated id doesnt match.').genError();
					cb();
				} else cb();
			});
		} else {
			req.assert('associatedProfessionals', 'Please insert the associated professionals field correctly.').genError();
			cb();
		}
	} else cb();
}, function(err) {
	if(err) throw err;
});

Here goes the genError custom validator:
expressValidator.Validator.prototype.genError = function() {
  //You could validate against this.str, instead of just erroring out.

  this.error(this.msg);
  return this;
};

@amritb Was this issue ever solved? If so, could you post your solution or at the very least, close the issue?


Add rerankers to the list of supported models (Supported_Models.ipynb)

Reranker models are not listed on https://qdrant.github.io/fastembed/examples/Supported_Models/
I added them at the end.
I had to add TextCrossEncoder to fastembed/init.py. I don't know if that's the best way to do this
All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Hi @paulmartrencharpro
Thank you for the contribution!
I updated it a little bit, so we could keep the imports as is


version lock each release in package.json and typings.json

I'm submitting a change request

Aurelia Skeleton Version
skeleton-esnext
skeleton-esnext-aspnetcore
skeleton-esnext-webpack
skeleton-typescript
skeleton-typescript-aspnetcore
skeleton-typescript-webpack

Framework Version:
1.2.0

JSPM Version
JSPM

Browser:
all

Language:
TypeScript

Current behavior:
Skeleton releases are tagged with a version number in the git repository, but package.json uses ^1.0.0 AND typings.json references the master branch for each module.
Expected/desired behavior:
Within the release for each skeleton version, package.json would use exact version syntax AND the commit hash versions would be used in typings.json.
What is the motivation / use case for changing the behavior?
Since the typings.json reference master branch type definitions, over time they become out of alignment with what package versions are installed for the project. This might be fine if you always want the latest release, but it can cause issues if you're shooting for a consistent build.

I agree this is something we all fight with at some point with npm and packages managers using semver... My only concerns about locking the versions inside the skeletons would be that most people won't notice, same goes with not locking them and always pulling the latest version of a given version. In both cases, it creates an issue IMHO.

Locking dependencies, cause an issue where people will use old versions of the libs if they don't keep up with the releases. I see that often in business where a product use out-dated dependencies because devs don't follow the news/releases.
Not locking dependencies, can cause issues with changes in libraries people are not aware of. While this isn't really supposed to happens while using semver, since breaking change should make the major version number bumps, there's still a chance some behavior slightly changes with bug fixes, which can definitely cause some hair pulling if you didn't run npm i or yarn for a while and suddenly pick up the latest version.

So, in both cases, it can cause issues.
On thing is, before shipping any product or stamping it as RTM, IMHO, you should lock the dependencies, to avoid a tons of issues later when releasing bug fixes or small changes. From the moment you product is RTM and shipped, all upgrade should be planned.
Meanwhile, while your still in active development, I don't see the benefits of locking dependencies because you always want to be using the latest version, I don't see any downfall of doing this while in active development.
Beside that, I'm very curious to understand your standpoint about this, bringing you to ask for that change.

Basically agree with your two issues. My team has been bitten by the second on a few occasions over the course of a lengthy project, specifically around the version of a package and the typings definition getting out of sync since neither are version locked.


Duplicate struct field generated

Problem statement
A duplicate struct field is generated in the models if the swagger spec has keys named in the fashion below.
"searchAfter": {
  "type": "string",
  "description": "Use this in future searches to get the next page of data"
},
"search_after": {
  "type": "integer",
  "format": "int64",
  "description": "deprecated"
}

This results in the struct for the associated model having two SearchAfter fields:
// Use this in future searches to get the next page of data
SearchAfter string `json:"searchAfter,omitempty"`

// deprecated
SearchAfter int64 `json:"search_after,omitempty"`

Which means the generated code does not compile. Ideally, I'd control the swagger.json source and change it, but that is defined elsewhere. I could change the generated client code, but it's not best practice to edit it.
Swagger specification
The WiGLE 2.0 API. Can be found here.
Steps to reproduce
curl https://api.wigle.net/swagger.json -o swagger.json
swagger generate client
go get -u -f ./...

Environment
swagger version: v0.24.0
go version: 1.14.4
OS: Ubuntu 20.04

like this should work
curl https://api.wigle.net/swagger.json -o swagger.json
sed -i 's/search_after/search_after_deprecated/' swagger.json
swagger generate client
go get -u -f ./...

we also have a swagger mixin command or you can make a small script that rewrites the spec. There is also the x-go-name extension you could add to override the go name that would get generated

The sed command will result in non-duplicate struct field names, but the JSON struct tag for the renamed one will not map to the original field, it'll map to the renamed field.
I wasn't able to find how swagger mixin would help, but I was able to use x-go-name to solve the problem perfectly. Here is a link to the docs relating to these vendor extensions.
This means the spec on my local machine looks slightly different:
"searchAfter": {
  "type": "string",
  "description": "Use this in future searches to get the next page of data"
},
"search_after": {
  "type": "integer",
  "x-go-name": "SearchAfterDeprecated",
  "format": "int64",
  "description": "deprecated"
}

But the underlying swagger spec remains unchanged. A non-duplicate struct field generated with swagger generate client after this edit:
// deprecated
SearchAfterDeprecated int64 `json:"search_after,omitempty"`


Add ALBNoSQLDB

Did you want to merge this? I'd be happy to have it in the index.

Yes I did. For some reason it failed the pre-check.

On Aug 15, 2019, at 10:11 AM, Dave Verwer<EMAIL_ADDRESS>wrote:
Did you want to merge this? I'd be happy to have it in the index.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/daveverwer/SwiftPMLibrary/pull/82?email_source=notifications&email_token=AAFSSRU6CZAN4HP3WPGVVVLQEVPZDA5CNFSM4IL55XV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4L5HSY#issuecomment-521655243, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFSSRQRKKFAYWJCKDID2KTQEVPZDANCNFSM4IL55XVQ.

Fixed up and merged. Thanks!


Audio gets cut at the end

Hello all,
I'm facing this issue where the audio gets cut (~1 sec) at the end and can't figure out why it's happening. I hope someone can help me out here please!
Here's the code snippet (it's really just the sample code):
var ao = new portAudio.AudioIO({
  outOptions: {
    channelCount: 2,
    sampleFormat: portAudio.SampleFormat16Bit,
    sampleRate: 22000,
    maxQueue: 1,
    closeOnError: true
  }
});

var rs = fs.createReadStream('./audio/output.wav');
rs.pipe(ao);
ao.start();

Troubleshooting 1:
I've tried to debug and step through the code, however during debugging, the full audio gets played fine and I don't see anything amiss throughout code stepping.
Troubleshooting 2:
I've also played the same file via VLC media player and the audio file was complete (no cut at the end).
Using a different audio file also results in audio getting cut at the end too.
Troubleshooting 3:
To narrow down the issue more, I did the following:
var rs = fs.createReadStream('./audio/output.wav');
var ws = fs.createWriteStream('./audio/output-write.wav');

rs.on('data', (chunk) => {
  console.log(chunk);
  ws.write(chunk);
});

and the file write out complete without audio cut when played via VLC media player.
However when I change it to:
ao.write(chunk);
the output audio gets trimmed at the end.
Troubleshooting 4:
I realized that changing the outOptions.maxQueue  affects how much audio is being cut at the end. Setting to 1 and I get the longest audio play, setting it to 2 and it gets shortened more, 3 even more and so on. Setting it to 0 and no audio was played.
Troubleshooting 5:
I've also logged out the close event from the readstream and finish event from ao write stream,
it seems that the close event gets called, then the finish event and that's when the audio gets cut. It does not seem to wait for the audio to finish playing.
I hope someone can help me out with this! Thanks for your time!

Please try again with the latest version.

Please try again with the latest version.

The last output buffer (by default 16384 bytes) was not getting sent to the output. This should be fixed now.


fix(core): handle schema Cache expandCapacity concurrent problem

Purpose of the PR
fix #2330

Main Changes

Verifying these changes

[ ] Trivial rework / code cleanup without any test coverage. (No Need)
[ ] Already covered by existing tests, such as (please modify tests here).
[x] Need tests and can be verified as follows:

org.apache.hugegraph.unit.store.RamIntObjectMapTest

before：

after:

Does this PR potentially affect the following parts?

[x]  Nope
[ ]  Dependencies (add/update license info)
[ ]  Modify configurations
[ ]  The public API
[ ]  Other affects (typed here)

Documentation Status

[ ]  Doc - TODO
[x]  Doc - Done
[ ]  Doc - No Need

@imbajin PTAL

Find another critical bug @conghuhu


Make PkgEval badge link to this package's evaluation

As a suggestion, make the PkgEval badge link directly to the evaluation page for this package, instead of linking to the full report of all packages. This is better IMO and is also how the official repo recommends it at https://github.com/JuliaCI/NanosoldierReports#badges.

thanks!