AWS IAM Permissions

Hello,
I'm wondering if you could outline what AWS IAM Policy Actions are needed for this to run out of the box?
Thanks,

As I use it for side projects, I don't need too restrictive rules.
So this is enough for me:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
                "lambda:*"
            ],
            "Resource": "*"
        }
    ]
}

But maybe you were asking for more restricting rules?

Correct, I was looking for what the minimum IAM Actions that are needed to run this.

In this case, If you need a simple Lambda without versions, aliases, and layers,
I think the minimum IAM Actions needed is this :
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
              "lambda:UpdateFunctionCode",
              "lambda:UpdateFunctionConfiguration"
            ],
            "Resource": "*"
        }
    ]
}

If you need versions, aliases, and layers:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
              "lambda:UpdateFunctionCode",
              "lambda:UpdateFunctionConfiguration",
              "lambda:UpdateAlias",
              "lambda:PublishVersion",
              "lambda:ListLayerVersions"
            ],
            "Resource": "*"
        }
    ]
}


WIP: Add documentation for CRI API moving to v1beta1

This is a placeholder PR for this enhancement: https://github.com/kubernetes/enhancements/issues/2040
Signed-off-by: Mrunal Patel<EMAIL_ADDRESS>

/milestone 1.20

/sig node

/milestone 1.20

/milestone 1.20

/assign @SomtochiAma

Hi @mrunalp
What help would you like towards getting this PR ready for review? Here in SIG Docs we'd really appreciate a chance to get as much reviewing done as we can before KubeCon.

Hi @mrunalp since this is been merged kubernetes/kubernetes#96387  and the rest will be on 1.21 wondering if there's something we could help so that we can proceed with this placeholder?

@irvifa, we will have to hold this till 1.21. We don't need doc updates in 1.20.

@irvifa, we will have to hold this till 1.21. We don't need doc updates in 1.20.

Since this is no longer required, I'll close this PR. Feel free to reopen when the next release milestone and branch is available
/milestone clear
/close


Authorization template styling added

Left in sample authorization code in template html to test scrolling.

please merge this to dev instead of master


custom view

how do i make this dialog to display my custom activity or have a custom look to the display e.g. display an order or checkout form, or a login form? And how is the CustomDalog  option used? Any example?

i managed to sort it out using the .setView method


ensure igi_gq is initialized

This fixes a crash caused by garbage in igi_gq when trying to drain the
queue in igi_delete_locked()
Signed-off-by: Ruslan Babayev<EMAIL_ADDRESS>

ping @bogdanPricope

Note: the comment was created automatically with bugzilla2github tool

Bugzilla bug ID:  18
Renumbered to issue: #141

Hi,
I am not an OFP maintainer (but Linaro assignee) so I cannot review it myself.
Dear OFP maintainers, please take a look.
BR,
Bogdan
From: Ruslan Babayev<EMAIL_ADDRESS>Sent: Monday, January 23, 2017 8:19 PM
To: OpenFastPath/ofp<EMAIL_ADDRESS>Cc: Bogdan Pricope<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [OpenFastPath/ofp] ensure igi_gq is initialized (#18)
ping @bogdanPricopehttps://github.com/bogdanPricope
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/OpenFastPath/ofp/pull/18#issuecomment-274571659, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJpgrjX5ViIYOs32UGGdGMk-0Gy-eNUDks5rVO8PgaJpZM4LmWq_.

Hi,
I want to push your proposed patch to OFP repository with your signed-off-by.
Anyone who wants to contribute to the OpenFastPath Foundation needs to sign the contribution agreement.
If you work for a company, this should fill and sign the Contribution License Agreement and add you to the "Schedule A".
http://www.openfastpath.org/downloads/OpenFastPath_ContributionAgreement.pdf
Then, please send a scanned PDF of it to me.
BR,
Sorin Vultureanu
OFP Maintainer

Pushed to master.
Reviewed-by: Sorin Vultureanu<EMAIL_ADDRESS>


test as default rake task

this is a small change that would make the repository follow the rule of least surprise for contributors (like myself).
when i'm forking a project and trying to provide a PR i usually run bundle exec rake as almost all libraries then run the test-suite as their default task.
thanks for the great library!

👍 thanks for the improvement


Update build-overrides to accommodate new top-level hooks dir

Accidentally created on wrong branch

Closed the wrong PR. Sorry about that


0.4 release

[0.4] - March 10, 2020
Changed [⚠ Breaking Changes]

getShareScores & getInsights have been decoupled from the check class, they now have to imported separately.
Minor changes in the analyze.py module.

Hello @Bhupesh-V! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file plagcheck/plagcheck.py:

Line 73:80: E501 line too long (80 > 79 characters)

In the file plagcheck/plagcheck_test.py:

Line 23:80: E501 line too long (84 > 79 characters)

In the file setup.py:

Line 18:80: E501 line too long (84 > 79 characters)


Mod incompatibility

Hey, this mod is currently incompatible with 24HourClock
With both of these mods installed, when you land the ship it will not let you go and you have to wait the entire day to leave.
I've got into contact with the other mod creator and got a temporary fix for now, but they said to get into contact with the creator of this mod if I want a long-term fix.
The other mod creator "zduniusz" has said that this mod expects both AM and PM in the clocks text, and because that part's removed it crashes.
The other mod creators discord is: zduniusz

@FreeSpeechMC I'm currently working on it. Soon it'll be patched. Thanks for the feedback

A patch has been released. You can download the new version of the mod here


Autocomplete doesn't trigger for .c & .h files. but it works for .cpp

Describe the bug
A clear and concise description of what the bug is.
intellisense is not working when a file is .c or .h, but it works for cpp files.
when created a new workspace to take the images. it worked for header file. but still not working for c files.
Screencaps

Your System:

OS: [Linux]
VS Code Version [1.63.2]
Doxdocgen Code Version [1.3.2]

while in the same file, changing the language mode in the lower right corner in the status bar in vscode seems to workaround the issue.
while in c language mode, the extension doesn't trigger intellisense.
but it seems to work in cpp language mode.
hope this can help.

I have exactly the same experience, i.e. it works when I change to C++ when editing a C file.

Hi @masriomarm ,
thank you for bringing this to my attention. Maybe this is related to #273 or #261.

Hi @cschlosser ,
thanks for your effort.
let me know if i could provide more help.

Is there any way to solve this problem?

Still a problem


KAFKA-7963: Extract hard-coded Streams metric name strings to centralized place

Moved hard-coded 'expired-window-record-drop' and 'late-record-drop' to static Strings in StreamsMetricsImpl
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@guozhangwang @bbejeck @mjsax @vvcephei

\cc @vvcephei

First pass found only these two strings appearing in more than one file (in the context of StreamsMetricsImpl#XXLevelSensor() calls) but there may be others worth including in this scope..?

Failures unrelated: retest this, please

Known flaky test failed: https://issues.apache.org/jira/browse/KAFKA-7978
Retest this please.

LGTM.
@bbejeck please feel free to merge.
One side note that after we merged https://github.com/apache/kafka/pull/6080 maybe we can do another follow-up to move the constant string names to the StreamsMetricsImpl class as well and let test classes as well as internal classes like MeteredXXStores reference those strings instead.

Merged #6355 into trunk


Change the color of floating-button (Floating Action Button) icon

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Framework7 Version: 1.5.3

Platform and Target: CORDOVA, ANDROID.

What you did
I added the Floating Action Button:

Expected Behavior
I want yellow button with black icon.
Actual Behavior
I have yellow button with white icon.

What should I do to change white icon to black icon in Floating Action Button?

The colour of the image is hardcoded in a url encoded data uri.

Thank ZanderBrown.
I added in my-app.css code:
i.icon.icon-plus {
  background-image: url("data:image/svg+xml;charset=utf-8,%3Csvg%20fill%3D'%23000000'%20height%3D'24'%20viewBox%3D'0%200%2024%2024'%20width%3D'24'%20xmlns%3D'http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg'%3E%3Cpath%20d%3D'M19%2013h-6v6h-2v-6H5v-2h6V5h2v6h6v2z'%2F%3E%3Cpath%20d%3D'M0%200h24v24H0z'%20fill%3D'none'%2F%3E%3C%2Fsvg%3E");
}

and the icon has become black ))


Update to make invoice screen for dark mode

@secondl1ght can you resolve the conflict?

@bumi resolved


MD013: Text after url

So, going off of this issue, I actually don't seem to have false positives with urls.
However, I do get errors on lines with text after a url. I'm not sure if this was a purposeful error though.

(Note that in the screenshot the blue "here" is concealed text -- the line is indeed longer than 80 chars).
Is this intentional? I would expect line lengths to be calculated by summing the "url" text and all other characters and then testing that length against 80. Instead, normal urls exceeding 80 characters are (correctly) not linted, butothers with text after are.

I can't tell much from that screenshot, sorry. Could you please paste the text of a complete reproduction or link to a file that demonstrates this? If it helps, you might find the web demo handy: https://dlaa.me/markdownlint/

Sorry, here you go.

# Markdownlint Explanation

[correctly non-linted line technically longer than 80 chars including url length](https://akfdjajdf.asdfljbadfjladsfadsjfbafbjhbflajdf)

[line starting with url](https://wiki.archlinux.org) incorrectly linted despite being less than 80 chars

Your example produces no errors in the current release of the library: https://dlaa.me/markdownlint/#%25m%23 Markdownlint Explanation

[correctly non-linted line technically longer than 80 chars including url length](https%3A%2F%2Fakfdjajdf.asdfljbadfjladsfadsjfbafbjhbflajdf)

[line starting with url](https%3A%2F%2Fwiki.archlinux.org) incorrectly linted despite being less than 80 chars

My mistake, MD013 is off by default in the web demo. Here is your example with it enabled and reporting: https://dlaa.me/markdownlint/#%25m%23 Markdownlint Explanation

<!-- markdownlint-enable MD013 -->

[correctly non-linted line technically longer than 80 chars including url length](https%3A%2F%2Fakfdjajdf.asdfljbadfjladsfadsjfbafbjhbflajdf)

[line starting with url](https%3A%2F%2Fwiki.archlinux.org) incorrectly linted despite being less than 80 chars

In your example, the error reported for line 7 is "Line length [Expected: 80; Actual: 104]". That line is indeed 104 characters long in Markdown, so this seems correct. (The length is shorter when rendered, but this rule runs on the original Markdown source.)

So my question is why is the first line not linted then? Its evidently much longer than 80 chars.

I would expect line lengths to be calculated by summing the "url" text and all other characters and then testing that length against 80

The rule is because of the 80 char wrapping rule from old IDE/diff editors, not the visual representation. When the part that exceeds the 80 chars is a link text, it doesn't complain for the reasons explained in the docs https://github.com/DavidAnson/markdownlint/blob/v0.26.2/doc/Rules.md#md013

That's right. To put it a little differently, this rule tries to help you keep Markdown content to within a particular line length, but doesn't force you to break up long content like a link.

Ah ok. So by erroring on the second line it is indicating you should "break up" the line because it ends on text -- if it is a url then it assumes you don't.
Odd, but i guess I get it. The "80 char" width definitely isn't an old thing, though. It is still standard practice in many common code formatters.


Upper case in stack name causes deployment failure

The stack failed to deploy:

The reason is the explicit use of AWS::StackName in the BucketName.
  S3Bucket:
    Type: AWS::S3::Bucket
    Properties:
      BucketName: !Sub '${AWS::StackName}-${AWS::AccountId}-${AWS::Region}'
      BucketEncryption:
        ServerSideEncryptionConfiguration:
          - ServerSideEncryptionByDefault:
              SSEAlgorithm: AES256

Valid Stack names include uppercase (eg Agent-BioMarkerDiscovery) but bucket names do not.
I think the template should ideally avoid explicitly naming the bucket - it will be named automatically by CfN if you omit the BucketName property.

fixed


initial MPRIS support

This PR adds support for the MPRIS Dbus protocol as described in #4080. My first approach was to directly use the low level API, but unfortunately the usage of the library is discouraged:

This manual documents the low-level D-Bus C API. If you use this low-level API directly, you're signing up for some pain.

So I felt back on the glib API and tried to get an glib event loop running in a worker thread.
For now the only event that has been wired up is the Raise method.
The goal for the first iteration is to only get the media keys working. Later iterations could also update the current track metadata if they can be extracted from the device. I haven't looked at the server implementation yet.
This implementation is unfinished and meant as an opportunity to see if @rom1v considers the approach acceptable.
addresses #1824, #4080

Thank you for your PR, and for posting an early draft :+1:
AFAIU, dbus/mpris is useful to control a player with a feedback, i.e. the client knows the state of the media player and get asynchronous updates.
Here, IIUC this is not the case (we are not able to receive the Android player state to synchronize with the client). In that case, maybe shortcuts are sufficient (#1824)?
Also, how does it interact with a local media player? For example, in my case, I don't want the media keys to control the Android device but my audio player on the computer.

So I felt back on the glib API and tried to get an glib event loop running in a worker thread.

I would like to avoid adding a dependency to glib. The low-level API can still be used, like in VLC:
https://code.videolan.org/videolan/vlc/-/blob/master/modules/control/dbus/dbus.c
But without state feedback from the device, I'm not sure the feature is useful. What do you think?

My usecase: Since scrcpy supports audio forwarding (❤❤❤), I really enjoy putting my phone into the dock and my desktop and seamlessly continue listening to music/podcasts on my desktop. While scrcpy is pretty good at forwaring, the integration of my android players into my desktop environment would be a real cherry on top.

Also, how does it interact with a local media player? For example, in my case, I don't want the media keys to control the Android device but my audio player on the computer.

That depends on the desktop environment. Gnome for example can handle multiple sources:

Also, in the final version, I would hide it behind a cmdline option: --mpris

I would like to avoid adding a dependency to glib. The low-level API can still be used, like in VLC:

Thanks! It looks quite massive, but I'll have a look.

But without state feedback from the device, I'm not sure the feature is useful. What do you think?

I believe that it would already have a benefit if a user can control the music on the android device without having scrcpy in focus. At least that would be a nice start for me.
I'm currently looking into the MediaSessionManager (src) API of android.
Up to now I'm unable to instantiate it, but if I understand correctly, it would allow control over all MediaSessions of a device and also can request metainformation about these sessions. I'm not that familiar with the Android API.
Do you think that's feasible?

Update: I finally got access to a functional MediaSessionManager instance. That would make it possible to create proxy controls for most Android Media Applications in mpris. That's exciting!
I haven't looked into the libdbus itself. So for now it'll remain in libgdbus. Now to figure out how to wire everything up...

I updated the PR. Currently I'm facing the issue, that the MediaSessionManager and the MediaController do not emit any events. Any pointers what the issue could be here?


Timeouts reading large description files

Reading a large OpenAPI YAML file that refers to many subcomponent $ref references on the web, I am encountering "timed out" messages partway through pulling in the description.

Is this timeout controllable?

Can OpenAPI input be provided through a URL rather than just by a local starting YAML file?

@alansill

Not for now but it is possible to do so
https://github.com/p1c2u/openapi-spec-validator/blob/master/openapi_spec_validator/handlers.py#L25
Yes, you can use validate_spec_url (check README file)

Thanks. Worked around these issues by creating a combined single description file using swagger-combine.


misspelling

[Enter feedback here]
Unix-Like Kernal should be Kernel. Not Kernal.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 95f1bfc6-27ee-d6b0-6823-bf44d37ae207
Version Independent ID: 278e483a-9b38-451c-8b79-5c36da9190fe
Content: What is Xamarin? - Xamarin
Content Source: docs/get-started/what-is-xamarin.md
Product: xamarin
Technology: xamarin-crossplatform
GitHub Login: @profexorgeek
Microsoft Alias: jusjohns

Hi @emceelovin
I just searched this doc for "kernal" and there aren't any hits. There aren't any hits for "kernel" either. The diagram in the doc has the correct spelling.


fix: Allow an explicit MustExist precondition for update

This addresses a bug reported against the .NET SDK (https://github.com/googleapis/google-cloud-dotnet/issues/11361) but applies to all SDKs. The conformance test was updated accordingly in https://github.com/googleapis/conformance-tests/pull/82 and https://github.com/googleapis/conformance-tests/pull/84.
This PR is a port of https://github.com/googleapis/nodejs-firestore/pull/1985.
Googlers see b/321064909 for more information.

NOTE: The unit tests will fail until the conformance tests are updated to a version that includes https://github.com/googleapis/conformance-tests/pull/82 and https://github.com/googleapis/conformance-tests/pull/84. I would expect a bot-created PR to do just that in the coming days.


Question on property: sortable of geometry

G2 Version: 3.3.0
Platform: mac OS
Mini Showcase(like screenshots): N/A
CodePen Link: N/A

Thanks for the great library. I am working with a project using another package based on g2, and have some questions when reading the source code of geom (here). There is a property called sortable and it is involved in paint method. When I search it for the documentation, I find there is another library called f2 and from its api, it mentions that sortable can set to false if data is already sorted to save time.
However, if sortable is false, the condition on line 712 becomes true and the mappedArray created are sorted which is unnecessary. So, is it a bug and the "!" operator on line 712 should be removed?
Thank you for taking time to read this.

After taking more time to read the source code, it seems that sortable property is only available in f2 but not in g2. Because in my case, unnecessary sorting triples the time spent. So is it possible to have such property in g2 as well?

为什么中国人要用英文写字...

Already support at v4.0.0.


Try.NET link doesn't work

the Try.NET link doesn't work . Just links to a empty white page

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d710feeb-8f03-b211-a070-155938929d6b
Version Independent ID: c980ea8e-ffb4-fbb1-1761-292858616cdd
Content: C# foreach statement
Content Source: docs/csharp/language-reference/keywords/foreach-in.md
Product: dotnet-csharp
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Ping @jonsequitur
The samples on this page that use Span<T> fail because Span<T> is not found.  Other samples work correctly.
Do you have insight on how we should fix this one?

The issue reported here is different than what you're stating @BillWagner and it's very odd (although the samples are also broken and need to be fixed).
The issue is that when you click on the link that takes you to https://try.dot.net/, the page opens blank.

@BillWagner We would have to set up a custom Try .NET package on the server or modify the default package to include System.Memory.
@mairaw The link issue will take some more investigation. I suspect there's JavaScript running in the page that's falling afoul of some security mechanism on the Try .NET site. In any case, I think the link should possibly go here instead: https://dotnet.microsoft.com/platform/try-dotnet, which would make this moot.

@jonsequitur I think adding System.Memory would make sense.  I can think of a number of page where using Span<T> would be useful (stackalloc, ref locals, and so on...).
Should I add an issue at dotnet/try?

That sounds good. Thanks!


Modify metab import to create missing tool authors.

Metab import will now ingest new people for tool authors.
What does this change do? Please be clear and concise.
This change has metab_import create new people for missing authors. This change also fixes two issues. One being people imported with trailing whitespace resulting in non-matching authors. The other being that the Person class was changed from having a uri attribute to function however this was never updated in Tool match_authors.
Why was this change made? Including an issue number is sufficient. Otherwise, briefly explain the benefit of the change.
SEP-142
Verification
List the steps needed to make sure this thing works. Be precise.

From the command-line, run python metab_import.py -d config.yaml

Here is the new result showing the people being created and there being 204 tools now:

Affirmations
All of these should have a check by them. Any exception requires an explanation.

[x] I matched the style of the existing code.
[x] I added and updated any relevant documentation (inline, README, CHANGELOG, and such).
[x] I used Python's type hinting.
[x] I ran the automated tests and ensured they ALL passed.
[x] I ran the linter and ensured my changes have not introduced ANY warnings or errors.
[x] I have made an effort to minimize code changes and have not included any cruft (preference files, *.pyc files, old comments, print-debugging, unused variables).
[x] I have made an effort maintain a clear commit history (haven't merged other branches or rebased improperly).
[x] I have written the code myself or have given credit where credit is due.

More consideration is needed before merging. This introduces stripping the spaces on making people. This would require a datafix for current names.


sticky-sidebar z-index issue

Self explanatory
(lowering the z-index of the sticky header from 90 to 1 seems to fix that specific problem)
Example:

Thanks for the report! I will be fixed by #4364


Support time-based forking

Closes #937

Let's discuss this before merging

@gakonst yeah I made some impacting changes...
And yet I held back, I was this close to replace:
https://github.com/paradigmxyz/reth/blob/78ffd0a7c0ce573e669d0fb0960a7806f279221d/crates/primitives/src/lib.rs#L65
by
pub struct BlockNumber(u64);

pub struct BlockNumber(u64);

what's the motivation for this? this would be super inconvenient imo.

edit: to distinguish between timestamp and blocknumber?

Exactly, to be able to impl From<BlockNumber> for ForkDiscriminant and From<Timestamp> for ForkDiscriminant

@Rjected I think I've taken all change requests into account, the PR can be reviewed again

I think this introduced a regression.

getting a lot of  Failed to validate header error=HeaderValidation { hash: 0xb4fbadf8ea452b139718e2700dc1135cfc81145031c84b7ab27cd710394f7b38, error: TheMergeDifficultyIsNotZero }

This happens all the time. @onbjerg probably correctly identified that this is incorrect:
https://github.com/paradigmxyz/reth/blob/e8d7c051cab95a383f9bcd34c00bec3ea47adfa1/crates/primitives/src/chain/spec.rs#LL147C2-L148C73
because of how it's called here:
https://github.com/paradigmxyz/reth/blob/e8d7c051cab95a383f9bcd34c00bec3ea47adfa1/crates/consensus/src/verification.rs#L53


Fix proposed blocks develop

Purpose

How does the solution address the problem

Changes made

LGTM. The change in storage means this will require a network reset correct?
yes we must reset devnet after this change


Handle Content-Type when it contains a charset

For example: Content-Type': 'text/html; charset=utf-8'.
If this is not done, the base_content_types may not match the value in the event and you get a error like the following:
[ERROR] UnicodeDecodeError: 'utf-8' codec can't decode byte 0x8b in position 1: invalid start byte
Traceback (most recent call last):
File "/var/task/gofer_flask_lambda.py", line 656, in lambda_handler
base64_content_types={"image/jpeg","text/html"}
File "/var/task/awsgi/init.py", line 173, in response
return sr.response(output)
File "/var/task/awsgi/init.py", line 95, in response
rv = super(StartResponse_GW, self).response(output)
File "/var/task/awsgi/init.py", line 89, in response
rv.update(self.build_body(headers, output))
File "/var/task/awsgi/init.py", line 75, in build_body
converted_output = convert_str(totalbody)
File "/var/task/awsgi/init.py", line 13, in convert_str
return s.decode('utf-8') if isinstance(s, bytes) else s

Hi, @headljdghub. Thanks for reporting  and fixing this bug.

My pleasure @slank.  Thank you for providing this project and for the quick turn around on this pull request.


[Transmit] Asks to open Transmit when it is installed (post last update)

Extension
https://www.raycast.com/kennonb/transmit
Raycast Version

macOS Version

Description
Reference: https://github.com/raycast/extensions/issues/15584#issuecomment-2515463361
Steps To Reproduce

Current Behaviour
No response
Expected Behaviour
No response

@matthewpinto I've moved your issue here I suspect I know the cause and pushing a fix as we speak.


bug: hardhat must be installed to use Hardhat plugin

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
1.3.9
Current Behavior
For this app we rely on the hardhat plugin from @wagmi/cli/plugins and on wagmi generate.
Running wagmi generate locally works fine. But since a few days/weeks it stopped working in CI environment and fails with error hardhat must be installed to use Hardhat plugin.
So I expect this bug has been else introduced in recent Wagmi versions as we don't have modified Wagmi CLI stuff since at least a month.
I've seen issue #1877 which seems related.
Expected Behavior
As you can see in this CI log, hardhat looks properly installed, so I would expect Wagmi CLI not failing because of missing hardhat installation.
(HIDDEN PART)
[11:15:24.517] dependencies:
(HIDDEN PART)
[11:15:24.518] - @wagmi/core 1.3.7
[11:15:24.518] + @wagmi/core 1.3.8
[11:15:24.518] - viem 1.2.14
[11:15:24.518] + viem 1.4.2
[11:15:24.518] - wagmi 1.3.8
[11:15:24.518] + wagmi 1.3.9
(HIDDEN PART)
[11:15:24.518]
[11:15:24.518] devDependencies:
(HIDDEN PART)
[11:15:24.519] - hardhat 2.16.1
[11:15:24.519] + hardhat 2.17.0
[11:15:24.519] + hardhat-contract-sizer 2.10.0
(HIDDEN PART)
[11:15:24.520]
[11:15:24.542] Done in 21.6s
[11:15:24.569] Detected Next.js version: 13.4.9
[11:15:24.655] Running "pnpm run build"
[11:15:25.171]
[11:15:25.171] ><EMAIL_ADDRESS>build /vercel/path0
[11:15:25.171] > pnpm cc:compile && next build
[11:15:25.171]
[11:15:25.674]
[11:15:25.674] ><EMAIL_ADDRESS>cc:compile /vercel/path0
[11:15:25.674] > hardhat compile && wagmi generate && ts-node ./contracts/extract-abis.ts
[11:15:25.674]
[11:15:26.710] Downloading compiler 0.8.18
[11:15:31.104] Generating typings for: 42 artifacts in dir: typechain-types for target: ethers-v6
[11:15:33.455] Successfully generated 126 typings!
[11:15:33.462] Compiled 42 Solidity files successfully
[11:15:34.118] - Validating plugins
[11:15:34.929] hardhat must be installed to use Hardhat plugin.
[11:15:34.929] To install, run: pnpm add hardhat

Steps To Reproduce

Rely on hardhat plugin for Wagmi CLI in wagmi.config.ts
Call wagmi generate from a Github workflow file

Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
No response
Anything else?
No response

Wagmi CLI hasn't released any new code since June 25th. CI issues are tough to work on without a minimal reproducible example so closing until one is added. Some additional questions in the meantime:

What version of @wagmi/cli are you using?
What package manager are you using? Monorepo?
Have you changed anything with your CI setup?

@tmm Oh ok! I'll investigate more the issue and will provide you with a minimal reproduction then.

Wagmi version: 1.3.0
Package manager: pnpm
Monorepo: No
Changes in CI setup: Not recently (2 months ago)

I think this is also important to mention that it fails in Vercel CD environment.

see https://github.com/egoist/detect-package-manager/issues/13


Added C++ module interface .ixx extension

Description

Visual Studio uses the .ixx extension for C++20 module interface files, and currently these files get no syntax highlighting on GitHub.
Checklist:

[x] I am associating a language with a new file extension.

[x] The new extension is used in hundreds of repositories on GitHub.com

Search results for each extension:

https://github.com/search?q=extension%3Aixx+NOT+nothack&type=Code

[x] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

https://github.com/pat-sweeney/Caustic/blob/master/Libraries/Rendering/Caustic/Shader.ixx

Sample license(s): MIT

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

I changed the sample and updated the PR description to contain a link to the source of this sample.


400 bad request

I make sure username and password is true

This is just documentation for the API. There is no support for the API itself.


[BUG/Help] 在谷歌colab平台上运行失败

Is there an existing issue for this?

[x] I have searched the existing issues

Current Behavior
Explicitly passing a revision is encouraged when loading a model with custom code to ensure no malicious code has been contributed in a newer revision.
Explicitly passing a revision is encouraged when loading a configuration with custom code to ensure no malicious code has been contributed in a newer revision.
Explicitly passing a revision is encouraged when loading a model with custom code to ensure no malicious code has been contributed in a newer revision.
2023-06-19 03:05:27.249011: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
Loading checkpoint shards:  62% 5/8 [00:47<00:28,  9.39s/it]^C
最后一直卡在Loading checkpoint shards:  62%，然后终止运行了
Expected Behavior
No response
Steps To Reproduce
{
"cells": [
{
"cell_type": "code",
"execution_count": null,
"metadata": {
"id": "UjcLVSLBLdHX"
},
"outputs": [],
"source": [
"#@title ##挂载谷歌硬盘（可选）\n",
"from google.colab import drive\n",
"drive.mount('/content/drive')"
]
},
{
"cell_type": "markdown",
"source": [],
"metadata": {
"id": "ZRBwmAYTbE-6"
}
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {
"id": "52QXFL73_0Pl"
},
"outputs": [],
"source": [
"#@title ##1.1克隆库、安装依赖\n",
"\n",
"!git clone https://github.com/ADKYUSHU12321/ChatGLM-6B1.git\n",
"%cd /content/ChatGLM-6B1\n",
"print(f"正在安装依赖，请耐心等待")\n",
"!pip install -r requirements.txt > /dev/null 2>&1\n",
"print(f"依赖安装完成")\n",
"!ls\n",
"#切换编码\n",
"import locale\n",
"print(locale.getpreferredencoding())\n",
"locale.setlocale(locale.LC_ALL, 'en_US.UTF-8')\n",
"print(locale.getpreferredencoding())\n",
"import os\n",
"os.environ['PYTHONIOENCODING'] = 'UTF-8'\n",
"\n",
"!apt-get install git-lfs\n",
"!git lfs install\n",
"!git clone https://huggingface.co/THUDM/chatglm-6b\n",
"print(f"模型下载完成")\n",
"\n",
"!ls"
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {
"id": "WBmCewXMBVTz"
},
"outputs": [],
"source": [
"#@title 将cuda文件，两个环境路径填入代码块，并运行\n",
"cuda_file_path = "/usr/local/cuda-11.8/compat/libcuda.so.1" #@param {type:"string"}\n",
"environment_path1 = "/usr/local/nvidia/lib" #@param {type:"string"}\n",
"environment_path2 = "/usr/local/nvidia/lib64" #@param {type:"string"}\n",
"\n",
"import os\n",
"\n",
"!mkdir -p {environment_path1}\n",
"!mkdir -p {environment_path2}\n",
"\n",
"!cp -p {cuda_file_path} {environment_path1}\n",
"!cp -p {cuda_file_path} {environment_path2}\n",
"\n",
"print("cuda文件拷贝完成")\n",
"\n",
"#@markdown !!!运行完后，点击代码执行程序--重新启动代码执行程序完成刷新!!!"
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {
"id": "jIiNeWyKAL6V"
},
"outputs": [],
"source": [
"#@title ###2.1.1 设置参数并开始对话\n",
"\n",
"%cd /content/ChatGLM-6B1\n",
"!ls\n",
"!pip install gradio"
]
},
{
"cell_type": "code",
"source": [
"#启动\n",
"!python web_demo.py"
],
"metadata": {
"id": "DjUL_eE8jfW9"
},
"execution_count": null,
"outputs": []
}
],
"metadata": {
"accelerator": "GPU",
"colab": {
"provenance": [],
"gpuType": "T4"
},
"kernelspec": {
"display_name": "Python 3",
"name": "python3"
},
"language_info": {
"name": "python"
}
},
"nbformat": 4,
"nbformat_minor": 0
}
Environment
- OS:colab
- Python:Python 3
免费T4GPU
- PyTorch:
- CUDA Support (`python -c "import torch; print(torch.cuda.is_available())"`) :True

Anything else?
No response

是不是RAM不够用


A single missing comma causes 2 errors and 5 warnings

Currently, a single missing comma in an object declaration will trigger 7 different errors/warnings in jshint, rather than just detecting that a comma is missing and showing a single relevant error:

Not sure if it can be lumped together in one error for this particular case, but it would be a bit cleaner.

so, it's certainly possible to recover parsing as though an , were correctly inserted. The trouble is, doing this makes it harder to know when to terminate trying to parse an ObjectLiteral production.
So, if the closing brace is omitted by accident, we will keep trying to parse the entire script as property definitions, and you run into a whole lot of "expected :" errors.
I'm not sure it's worth it, especially since this particular syntax error is an early error in every VM, and does not require the code to be hit in order to be reported as such, so linting tools aren't really needed to catch it, imo

Generally, it's difficult to intuit the author's intention in the case of invalid input. We do our best, but as @caitp explains, it's not always possible. The important thing is that the error is reported.
An alternative solution would be to support bailing in the first of errors (but not warnings). This could be implemented by reporters without a change to JSHint's core.

Thanks for looking into it.


Extra exception detection boxes

when i train the model on my owner dataset， recall is very high but when i check the badcase , i find some extra exception detection boxes even on clean surface. What could be the cause?

To suppress FP boxes, you could set a higher threshold or add another NMS process. We discard the output NMS process because running it on 80 categories(COCO) is slow. You can add it in other cases to achieve better performance.

Thanks for reply, Perfectly solved our problem.👍


"See All" button for the "Transaction History" on asset pages goes to a blank page

Overview
On asset pages like Ethereum, in the "Transaction History" section when enough transaction are present there is a "See All" button that appears next to the title. Clicking on it leads to an empty/blank page.
References and additional details

Log into app.shapeshift and connect to wallet of choice
Navigate to asset page with multiple transactions
Under the transaction history select "See All"
Note it takes you to a blank page

Acceptance Criteria
See All should list all transaction history
Need By Date
No response
Screenshots/Mockups
No response
Ownership

[X] If my bounty needs engineering or needs product I have added the respective labels on the right
[X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort
No response
Sponsor / Stakeholder
No response
Bounty Hunters

Join our discord
Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
Please refer to this link for some basic info
Please do not start work on this issue until you are approved in Gitcoin.

Fixed by https://github.com/shapeshift/web/pull/4955


initialize and Statevector don't play nicely

Informations

Qiskit Aer version: 0.5.1
Python version: 3.7.3
Operating system: OSX

What is the current behavior?
Using initialize in a circuit and then running with Statevector results in the error "Cannot apply Instruction: reset"
Steps to reproduce the problem
import qiskit as qk
import qiskit.quantum_info as qi
from numpy import sqrt

n = 2

ket0 = [1/sqrt(2),0,0,1/sqrt(2)]

qc = qk.QuantumCircuit(n)
qc.initialize(ket0,range(n))

ket_qi = qi.Statevector.from_instruction(qc)

That is not just the initial state of the qubits?  That is what used to be there.  It is hard to tell the difference here.  So that means that initialize is no longer a unitary operation like it was before?  I guess I missed that as well.

A reset method was added to the Statevector class last release, so the simulator could be updated to work with initialize via adding support of reset to the the from_instruction method.

@nonhermitian I think this was changed recently in the draw function. Now circuits are drawn without any initial states, so any time you see them they refer to reset instructions.

Yeah, it is just that the original text drawing is very close to the reset instructions so it is hard for the user to understand.

In principle I could also add support for Measure instructions in the from_instruction, but this would just simulate measurement sampling and collapse, you wouldn't actually get the measurement outcome value. Is this preferable to raising an exception or is it better to leave it as raising an exception if measurements are in the circuit? (@ajavadia @jaygambetta )


Fix long variable preview

Problem
When the variable preview is too long, it stays on the same line, making it impossible to read the fallback content
Fix
We remove the white-space:nowrap; and set a min-height. that way it can span on multiple line if needed. Not the prettiest render since it's an inline node within a paragraph, but we are shooting for usability here

Write to your heart's content, include:

[ ] A link to the Figma design in your story (list regularly updated here)
[ ] A link to the Story(ies) in the description
[ ] Is there a Jira ticket associated?
[ ] If useful, add screenshots or videos
[ ] If useful (and unclear), add a little explanation of why a certain path was taken
[ ] Instructions on how to test
[ ] Found any restrictions/limitations? Let us know!

Guidelines
Make sure the pull request:

[ ] Follows the established folder/file structure
[ ] Adds unit tests
[ ] If it is a refactor or change to an existing component, have you verified it won't break existing Cypress tests or have you updated them?
[ ] Did you verify some accessibility (a11y) basics?
[ ] Adds/updates stories. Guidelines
[ ] Adds/updates documentation (ie proptypes) Guidelines
[ ] Has it been tested in Help Scout's supported browsers?
[ ] Requests review from designer of the feature
[ ] Add label (bug? feature?)

@plbabin I actually have a fix for that here: #1023 😄 (the solution has been agreed on with Alex)

that's perfect then 😃 , I'll close this PR


fix: don't deadlock when lots of async reactors are sharing a concurrency pool.

Some notes from a discussion:
state.current_tasks needs to not be used anywhere to limit, we should instead atomically "claim X or fewer available concurrency limit" and then start those tasks. And state.current_tasks is just for us to track what is currently running, not playing a part in the concurrency limit calculation.


Will there come any new tutorials?

I look almost every day onto the Jobeet page for month now.
I am wondering if the rest of the tutorials will be uploaded.
Best regards
Michael

Hello @Slowwie
Of course I plan to publish the rest of tutorial and partially it's done for now. But at the moment I'm a little bit busy and can't finish it in coming days.
Your interest motivates me to find the time as soon as possible.
Thank you!

Hi i am also interested in the rest off the tutorial.
Keep up the good work

Yes, I am very interested in this tutorial. I am a Symfony programmer since 5 years. But I really learned new things - the SendGrid thing is very nice. I always had problems with my mails on certain providers (hotmail). Now that's history. Also I tried that docker thing. I thing its amazing. I struggle now to deploy that to AWS Fargate but I will do also thing in a while. All this I learned from this tutorial. So I am very interested in the last parts ;). It´s amazing.

Hi, thank you for these useful tutorials. I started learning symfony few months ago and they were very helpful for me. I'm looking forward to the rest of the tutorials.

Upgraded the tutorial to Symfony 4.2 in PR #32

Looking forward for the rest of tutorial :)

I'm anticipate with pleasure new updates! :heart_eyes:

Hi from Italy. I am new to Symfony. I am also interested in the rest off the tutorial.
Sorry for bad english.

Latest update:
@sergey-bleih helps with tests part. So you can see PR with code for unit tests: https://github.com/gregurco/jobeet/pull/8

Пора уже на 4.3 обновляться ;)

I am very interested in the deployment part. I wonder, how u deploy such docker containers.
I watch out for updates of this series now since November last year. I guess there is not really hope this tutorial will be completed, isn't it?

@Slowwie thank you for question and interest. I will continue tutorial as soon as will have enough free time.
For deployment part: it's quite hard part, especially with docker, but you can read more about AWS / Azure / Google Cloud Engine - all they have integration for containers (docker).

Yes, I know. I managed to deploy my project with AWS Fargat (EC2 would be too much maintenance work). But its quite expensive. I was wondering if u can present some cheaper solution in your tutorial.

@Slowwie I don't think that docker is right solution for cheap target. It is good, stable, secure, adjusted for complex architectures, BUT it's not cheat. In case you would like to deploy production with docker and not in cloud (aws/azure/gce) then you will have to study a bunch of tools/technologies besides docker and to rent not just 1 server (at least one dedicated for orchestrator and one for registry). So docker in production probably is not proper solution for small projects (IMHO).

@gregurco very good initiative to rewrite this tutorial in a more modern framework version, but, is there any possibility to you create this tutorial with SF 5?


Upgraded packages to latest version (incl. major releases)

Story

upgraded all packages to latest version, including major releases (eg. redux from 3.7.2 to 4.0.0, and react to 16.3.2 and sass-loader to 7.0.1)

Pull Request Test Coverage Report for Build 60

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.898%

Totals

Change from base Build 56:
0.0%

Covered Lines:
427

Relevant Lines:
503

💛  - Coveralls


Wallet Backup: Level 2 is not completing

The Backup process is getting stuck at level 2. Even after confirming Personal Device 1 and a contact at level 2(as can be seen in my F&F screen), the shares aren’t turning green and therefore level 3 is kind of locked.

@Parsh Could you please check again? I can complete level 2 (1 cloud, 1 device, 1 contact) and (1 cloud, 1 device, 1 pdf)

Update: I've tried it today as well and I'm still finding it hard to complete level 2. Especially the personal device health is behaving oddly, initially, it gets confirmed after acceptance of share by the Guardian but then the app sends a new keeper info updated notification to the guardian and then the expiry timer on my device again start appearing with health going to red on manage backup for the personal device.

-Verified this issue on staging app v1.6.0(277)


Interruptible test command

First pass at stealing ordeal's approach
Wanted to get this rolling so hopefully someone picks it up :)
here is a 30 second clip of the new behavior

added a --spawn flag that would background the test command and restart it on file change.

 Currently the spawned process is left running.
[ ] stream tests ?
[ ] Interpret exit code perhaps? Fold a successful test run back into "All good"
[ ] Render test output nice

Thanks! I was just thinking of making a release of ghcid, and bumping this feature to the next release, but given your progress I'll revise my plans and hope to get this incorporated. Looking at the code so far, two things spring to mind:

I'd push the ProcessHandle type inside Ghci as a field, and have stopGhciTest (perhaps named interrupt?) be a member of the API in Language.Haskell.Ghcid. The initial applicability test bit would need pulling out into the main loop.
Why would anyone not want to run with --spawn? Are there any downsides?

I was just thinking of making a release of ghcid, and bumping this feature to the next release, but given your progress I'll revise my plans and hope to get this incorporated.

Hehe yes I noticed lots of changes came in :)

I'd push the ProcessHandle type inside Ghci as a field, and have stopGhciTest (perhaps named interrupt?) be a member of the AP

:+1: yes, interrupt is better

Why would anyone not want to run with --spawn? Are there any downsides?

I think I remember you mentioning performance I somewhere in the issue so I thought maybe you didn't want it as the default, but I probably I interpreted it wrong.
I just realized that I've forgotten to handle outputting test output when the background process is done since I was trying it only for non terminating commands

In fact, I think I'll release now anyway, since I've got it in a nice state, and there are a lot of improvements. Having two releases in quick succession is no bad thing anyway, and letting this change bake a bit isn't a bad idea either.
My performance concerns were all with spawning a separate process to run the test, which will be a lot slower. If we can interrupt using the existing ghci process then it seems like purely a win. We might want a streaming version of exec at some point, to make it easier to relay test output as it comes back.

In fact, I think I'll release now anyway, since I've got it in a nice state, and there are a lot of improvements.

I agree :)
more releases with new features are always well received

My performance concerns were all with spawning a separate process to run the test, which will be a lot slower. If we can interrupt using the existing ghci process then it seems like purely a win.

I see

We might want a streaming version of exec at some point, to make it easier to relay test output as it comes back.

:+1: yes
--
A bit late to the train, but ghcid is awesome and fast for dev!! :zap: :zap:

A bit late to the train, but ghcid is awesome and fast for dev!! :zap: :zap:

One reason for wanting to get a new release out is that today I doubled the speed for some of my projects - Shake in GHCid goes from 7s to 3s :)

Shake in GHCid goes from 7s to 3s :)

:zap: :fire: @ndmitchell :fire: :zap:

This is looking great! Thanks @luigy

@luigy - do you want to take another crack at this pull request taking into account my comments, or would you prefer me to merge your changes and then make my suggestions on top? I'm happy either way.

@ndmitchell I've update the PR and I think this should now work on windows as well :raised_hands:
Also, took a stab at handling ctrl-c. Let me know if anything can be improved :)

I'd push the ProcessHandle type inside Ghci as a field

done :+1:. Is that what you meant?

The initial applicability test bit would need pulling out into the main loop

I'm not sure what you mean here or also how to properly test this :joy:

Why would anyone not want to run with --spawn?

If the approach seems reasonable it should be ready for cleanup and probably taking a stab at making spawn the default

@ndmitchell I was playing with this https://github.com/luigy/ghcid/compare/interruptible-test-command...luigy:interruptible-test-command-rfc
thoughts?

For info, I'm happy to clean up those little pieces after merge, other than the interrupt handler, which I don't understand enough yet.
The RFC stuff all seems like sensible direction to go, from that I can see:

You invert the Ghci type so it contains the methods you can run on it, rather than the data it needs to run. Sensible, although then it probably wants moving out of Types, and also using field names rather than positional data types.
You add locking around the operations, which seems like a good idea. I would need to read the locking carefully, but very sensible plan.
You are adding an interactive test output process. I'd probably call it something else (not withTestResult, but execWithOutput or similar - not sure of a good name). But it looks like a good addition. Any chance exec can be implemented on top of the more general version? Fewer primitives is always good.

here is another short clip showing off rfc branch

You invert the Ghci type so it contains the methods you can run on it, rather than the data it needs to run.

I wasn't sure if we really wanted to expose process handle? (are there any downsides if we do?)

Sensible, although then it probably wants moving out of Types, and also using field names rather than positional data types.

Yes, it should just be record, right?  I was going for something similar to exec in Ghci and ended up with my rfc branch

You add locking around the operations, which seems like a good idea. I would need to read the locking carefully, but very sensible plan.

the testLock is to guarantee that interrupt or execTest are not happening at the same time to avoid a possible false positive of testRunning Var.  Also calling execTest simultaneously would discard all the following test commands until the first one has finalized or been interrupted.

You are adding an interactive test output process. I'd probably call it something else (not withTestResult, but execWithOutput or similar - not sure of a good name). But it looks like a good addition.

execWithOuput :+1: I like this

Any chance exec can be implemented on top of the more general version? Fewer primitives is always good.

I'll try something out

On unix systems, I recommend using pid <- forkProcess myMain, and later doing signalProcess sigKILL pid.  See my comment here.  This is helpful in circumstances where terminating the main thread does not cause a full termination of the application.

No need to expose all the Ghci fields, just some - exposing the process handle seems like a bad idea, since it leaks implementation detail.
For the interrupt thing, I still don't fully understand. Are you saying your GHCi test command spawns a process itself?  I don't understand the reason for doing anything special on Ctrl-C.

On unix systems, I recommend using pid <- forkProcess myMain, and later doing signalProcess sigKILL pid. See my comment here. This is helpful in circumstances where terminating the main thread does not cause a full termination of the application.

@mgsloan doesn't this defeat the whole purpose of this being fast?  I would say if interrupting your function doesn't clean up threads it spawns, then, Don't Do That.

Before figuring out how to send interrupts and deal with signals I'd like to be convinced that we need to go anywhere near this area at all - as far as I can tell sending Ctrl-C kills ghcid which should end up with ghci dying which should end up with spawned tasks dying. Windows might need more (explicitly kill ghci), but this code is non-Windows only.

@reiddraper forkProcess creates a new process separate from your Ghci process, which efficiently uses a copy-on-write scheme in memory.  So, you get an entirely new process which can be killed without terminating your ghci session.  This works extremely well in practice, I have written a ghci driver that uses this approach.  ide-backend also used this approach...

@mgsloan huh, ok. I would have been worried about:

forkProcess comes with a giant warning: since any other running threads are not copied into the child process, it's easy to go wrong: e.g. by accessing some shared resource that was held by another thread in the parent.

But I guess in this specific use-case it might be safe.

Yes, I don't recall any problems with using forkProcess for this.  ide-backend tries to control stdio pretty tightly, and there's some trickiness there, but if you don't care about that stuff, it's really straight forward.
One example of a shared resource is, say, an MVar.  You can't use MVars for inter-process communication - mutating it in one process will not mutate it in the other.

For the interrupt thing, I still don't fully understand. Are you saying your GHCi test command spawns a p rocess itself?

Before figuring out how to send interrupts and deal with signals I'd like to be convinced that we need to go anywhere near this area at all - as far as I can tell sending Ctrl-C kills ghcid which should end up with ghci dying which should end up with spawned tasks dying.

I meant that after Control-C ghciddd process died, but  the spawned "ghci"(and it's child processes)  from createProcess did not.
Here are some images of the behavior I'm seeing without handling Control-C...
create_group=False
Running

Control-C on ghciddd

create_group=True
Running

Control-C on ghciddd

This is helpful in circumstances where terminating the main thread does not cause a full termination of the application.

:hand: Wait a second! are you saying that ghciddd's child processes like ghci, cabal ghci, etc(created by createProcess) might not always receive a signal on Control-C?
if so, this explains why my spawned process(from createProcess) was left alive when hitting Control-C on ghciddd

On unix systems, I recommend using pid <- forkProcess myMain, and later doing signalProcess sigKILL pid. See my comment here.

what do we mean by later doing? catching UserInterrupt?
...

. This works extremely well in practice, I have written a ghci driver that uses this approach. ide-backend also used this approach.

...wait, what!!!  so you mean it as an alternative to sending sigINT for reloading (:reload) + rerunning (:test_cmd) the "test" command passed to ghciddd? :open_mouth:

forkProcess creates a new process separate from your Ghci process, which efficiently uses a copy-on-write scheme in memory. So, you get an entirely new process which can be killed without terminating your ghci session.

!!!!! I have to go see some code + test it + inspect it with htop to let this sink in :)
I guess this could be an alternative to the current approach, but what about the Control-C issue?
What an odd behavior on Control-C with create_group=False :confused:
@ndmitchell I think that at least in unix it is probably more reliable to use a combination of createProcess with create_group=True and installHandler(which uses sigaction under the hood) to get more guaranteed control what actually happens on Control-C.
From what I understand the create_group gives us a fresh group process id that we can send signals with more confidence.
I'm sure y'all been probably doing this a bit longer than me and I want to learn, so let's discuss :)
--
@ndmitchell also apart from the Control-C issue does the reloading of test command work of windows?
I was hoping maybe 2c966aa was enough :cold_sweat:

￼> Wait a second! are you saying that ghciddd's child processes like ghci, cabal ghci, etc(created by createProcess) might not always receive a signal on Control-C?
if so, this explains why my spawned process(from createProcess) was left alive when hitting Control-C on ghciddd
Yes, when the child ghci process is running some code, it might not handle SIGINT properly if it gets caught by the running code.  Both ghcid and the child process will receive SIGINT, but if the child doesn't handle it properly, it will continue running.

On unix systems, I recommend using pid <- forkProcess myMain, and later doing signalProcess
sigKILL pid. See my comment here.

what do we mean by later doing? catching UserInterrupt?

Ahh, I misunderstood the featureset / scope of ghcid.  I thought it did something like yesod devel, where on code change, it reloads, kills the old application, and runs the new one.  So, off the topic of this PR for running tests.

!!!!! I have to go see some code + test it + inspect it with htop to let this sink in :)

You can read about it here! https://en.wikipedia.org/wiki/Fork_(system_call)

I guess this could be an alternative to the current approach, but what about the Control-C issue?

I'm not sure I grok all the details of the Ctrl-C issue, but this forkProcess stuff may be helpful.  At least that way, you can see if it's the child GHCI process, or its child, the forked process interpreting the tests, which is causing issues.

Ahh, I misunderstood the featureset / scope of ghcid. I thought it did something like yesod devel, where on code change, it reloads, kills the old application, and runs the new one. So, off the topic of this PR for running tests.

the "test" name is misleading imo, but at least I was using it like yesod devel in the original clip right? not sure if the original scope was only test, though :)
the flow is something like... ghciddd with "test" command=":main port" will start my server
then wait for file changes of loaded files...
on file change -> send interrupt to "ghci" -> :reload -> rerun "test" command (":main port")

This stuff is particularly helpful for web servers. If you kill the main thread of the web server but other threads remain running, it can hold on to the port binding. Then, the next time the application is launched, it can't get the port, and you're stuck running the old version of the application. With forkProcess, you can force things to get cleaned up.

looks like what I'm trying to achieve with using fresh process group?

It might be cool to do something even fancier. It'd be cool if there was a way to ask the RTS about what threads are running. Then it might be possible to do the kill on the main thread, and wait a bit for the app to tear down all its threads. If it doesn't do so promptly, detect this case, warn the developer about it, and kill the process.

on file change -> send interrupt to "ghci" -> :reload -> rerun "test" command (":main port")

I'm not sure how important this is, but another benefit of using forkProcess is that you can wait till :reload has finished before killing the old one.

looks like we are really trying not to handle Control-C directly? is there a particular reason? I mean I'm not trying to do anything fancy with it, but only enforcing that every child process is completely killed

It seems fine to me to try to enforce this - I'm ambivalent.  I just figured I'd bring up the forkProcess stuff because it seems quite relevant and I found it made my internal yesod-devel-alike more reliable when working on projects with bad async exception behavior.

I'm not sure how important this is, but another benefit of using forkProcess is that you can wait till :reload has finished before killing the old one.

hmm interesting
currently there is a lock that only let's one command at a time to "write" to ghci so no :reload can happen until the "test" command is done or interrupted.
I'm probably missing something and I haven't looked at ghci code to achieve what you're saying :)

It seems fine to me to try to enforce this - I'm ambivalent. I just figured I'd bring up the forkProcess stuff because it seems quite relevant and I found it made my internal yesod-devel-alike more reliable when working on projects with bad async exception behavior.

was this more in particular to the "reloading" behavior of it, rather than when you're done with yesod-devel-alike and just wanted to exit? or both?

currently there is a lock that only let's one command at a time to "write" to ghci so no :reload can happen until the "test" command is done or interrupted.

Hmm, good point.  In order to do this 100% right, some fancy stuff needs to be done with stdio for the forked process.  This wouldn't be able to use this for programs that expect stdin, because it would go to the ghci process which is still running a repl.
No modification of ghci itself should be necessary (in line with the goals of ghcid)

was this more in particular to the "reloading" behavior of it, rather than when you're done with yesod-devel-alike and just wanted to exit? or both?

Mostly relevant to the reloading behavior.

I'm very keen to avoid forkProcess unless it produces significant benefits and can be done in a way that abstracts over the cross-platform differences between Windows and Linux. I develop on Windows and will continue to do so, so the less chunk of code I can't test the better.
I've got a paper deadline on Wednesday, but will take a look at reading all the comments, understanding the issues, and merging the code, after that. Thanks all for your thoughtful insights into the issue - Ctrl-C seems pretty subtle.

Thanks for the advice and code everyone. I've merged, and will be going through the code in detail tomorrow morning to clean it up, partly incorporating the changes from the rfc above, and partly just to make sure I understand all the details and try it out.

:tada: :clap: :+1:
@ndmitchell I've noticed that :reload might be interrupted in some cases and rerun test command with old code
I had some local changes that I've forgotten to push here that only sends interrupt if a test command is running https://github.com/luigy/ghcid/commit/c1a4760b91c0989966ea27f20a152a0b9042f0ef

@luigy They look handy, so I've merged as #54 and will look at in the same go.


motoko-san: Stop using (==) in trans.ml and prep.ml

Turns out that == in OCaml is physical (pointer) equality, and is not guaranteed to work as a test for an empty list.

Also we could replace it with List.is_empty (just thinking out loud)

That's what I tried initially but it does not seem to be available. It was added in 5.1 and we're on 4.12


test(e2e): upgrade e2e deps

Test plan

Green CI
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
N.A.

@kulshekhar  would you pls try to install Renovate Bot App https://github.com/apps/renovate as well ? We should migrate to renovate bot as it's smarter than dependabot

@ahnpnl renovatebot has been added!

https://github.com/kulshekhar/ts-jest/pull/3541


[WFLY-5668] Correct singleton schema

https://issues.jboss.org/browse/WFLY-5668

:+1: Good to go, thanks.


Adding install of Xcode command line tools

Lloyd, please can you review this changeset as I'm interested in your opinion about whether we should have the text under the command to install the Xcode command line tools or not?

@lroseblade changes made, please merge.


Addition of links, updates of faq

Added link to dBFT explanation. Awesome because it is a very expansive explanation and it is something people keep asking about.

Going to do this again with PR #23 added for ease of use


Redesigned the Project manager to waste less space in the UI

The old project manager had a lot of empty space so I've made it a bit more compact, made the search bar bigger and left-aligned the tabs because that's what godot uses everywhere by default now...
Here are pictures before and after the change

I would recommend to squash commits once you have the changes finalized. Which I think you have now.

Oops, this made it even worse...

my 2cents, I think the whole project manager needs a fresher look. For me, compacting things makes it look even worse. Who is complaining about lack of space in the project manager? :)

Long time user so I might be biased, but I prefer the old one, just because there is "space to breathe" / more room to not misclick. New design feels cramped.

Have to agree with Zylann here, this new design feels a little cramped. I'm not entirely against it, but I'm not really for it either.
Perhaps maybe remove the label "Godot Engine - Project Manager"? That's already in the window title, so there's no reason we should be displaying it twice, and maybe it might make it feel a little less cramped.

also, take a look at a previous discussion https://github.com/godotengine/godot/issues/8135

@LikeLakers2 like this?

@LaBlazer Yeah, those feel a bit better. I'm not sure how everyone else feels, but that little bit of extra space makes it feel that much less cramped to me.
I have no opinion on the positioning of the tabs, though. Either looks fine to me.

If the space-saving effort were to make room for a more splash-screeny experience (with differing images for new releases), release notes, easy access to news headlines/featured addons... That would be pretty cool.

I also agree, that there is no. Need to save space in the project manager. Omyou Don't do actual work (which needs screen realastate) there.
Things that would actually matter:

cooler design (splashscreen like) since it is more a welcome screen it is actually worth caring aboht those things.
organization features (demos, favorties, featured projects, also a temp project would be really nice which gers deleted after closing the editor. So you can just est without creating a folder)
layout options to actually get more projects on screen. (Like a two column one, or a "only thumbnail version)

@adrianperreault Maybe something like this? Covers and articles would be loaded from godotengine.org and it would open the website once you click on it...

Covers and articles would be loaded from godotengine.org and it would open the website once you click on it...

I think that is a waste of space.  It should be more function and less form. Also, Godot never connects to the internet without the user intent, and IMO it should remain this way.
I agree that the project manager can look better and be more usable. I don't think treating it as splash screen is the solution though.

Instead of a splash screen, I don't think it'd be too bad if a link to the Godot's website were added, personally. It would effectively serve the same purpose as the splash screen, just without using so much space, and only really requiring one or two more clicks. Where you would want to put that, though, I'm unsure.


graphqlExpress has no way of accepting express request through context

express-graphql passes the express request as a default value for context. This is very convenient when I want to do something such as check a user's authentication from the request header.
However, it does not appear that there is a way to get a handle on the express request object from inside a resolver when using graphql-server-express. Is there a specific reason you left this out? Am I missing some other way to get a handle on the req?
Thanks.

@pikelnys if you want, you can pass the request object into the context that every resolver gets. you can do this in the function that returns the configuration. Something like this (copied from here) will do:
graphqlExpress(request => ({
  schema: typeDefinitionArray,
  context: { user: request.session.user }
}))

@helfer Thank you! But this should be documented 😅

@helfer wait how?
app.use('/api', bodyParser.json(), jwt({     secret: process.env.JWT_SECRET,     credentialsRequired: false,   }), graphqlExpress(request => ({       schema,       context: {         authUser: request.user     } })));
returns typeerror: graphqlExpress is not a function
i can't figure that out

@Muphet when your importing graphqlExpress you need to do
const { graphqlHTTP } = require("express-graphql");
then use graphqlHTTP in place of graphqlExpress


/locatebiome command can't find Biomes

Hello!
Whenever I try and locate a biome on my server it tells me it can't find a biome within reasonable distance. This issue also applies to the biome I'm currently in. I figured this might be related to the mod and wanted to raise attention towards this issue, as I personally had issues getting flowers to spawn on my world and thought my world was bricked (only had Badlands).
Hopefully this information helps y'all out one way or another :3

Could you please provide all the required information to reproduce the issue? I already fixed this kind of issue and it would good to know which version you use and all the other stuff in the form when creating a new issue.


getAll requires manual batching

Currently putAll operations work around the maximum batch size limitation of DynamoDB by batching the operations behind the scenes, but inconsistently getAll requires the user to do the batching themselves.
getAll should manage the batching so that the user of the library doesn't have to worry about it.

https://github.com/guardian/scanamo/pull/116

This is now out in 0.9.5


Model Test Cases and fixtures

@lucianghinda please have a look!

@obaidashfaq20 thank you for implementing this.
I merge all the other PRs that you submitted so now I think you need to rebase this branch on the main - because I see that the fixtures there contain the old attributes that we renamed via the 3 PRs.


[Bug] startParams  Not in effect

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

设置了启动参数 , 但是没生效
What you expected to happen
启动参数生效
How to reproduce
添加spark工作流 , 主程序参数定义${}变量 , 执行一次时启动参数设置该变量的值
Anything else
No response
Version
2.0.x
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

English is needed


Deploying the API succeds on build, but no API is presented in Azure?

I'm having a problem with the API deployment and I don't see any error messages. It looks like its deploying the API, but in the APIs tab does not show any active APIs.

Why might this be the case? What else can I look at to debug?

staticwebapp.config.json: https://github.com/nkdAgility/NKDAgility.com/blob/main/staticwebapp.config.json
{
  "platform": {
    "apiRuntime": "dotnet-isolated:8.0"
  }
}

Build: https://github.com/nkdAgility/NKDAgility.com/blob/main/.github/workflows/main.yaml
- name: Build and Deploy
        uses: Azure/static-web-apps-deploy@v1
        id: azureDeploy
        env:
          VERBOSE: true
        with:
          repo_token: ${{ steps.app-token.outputs.token }}
          action: "upload"
          app_location: ./_site
          api_location: ./_api
          skip_app_build: true
          skip_api_build: true
          output_location: ""
          deployment_environment: ${{ (needs.Setup.outputs.nkdAgility_AzureSitesEnvironment) }}
          azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN }}

Log: https://github.com/nkdAgility/NKDAgility.com/actions/runs/11594635655/job/32281460532
Verbose logging enabled
Try to validate location at: '/github/workspace/./_site'.
Build timeout not specified, defaulting to 15 minutes
App Directory Location: './_site' was found.
Try to validate location at: '/github/workspace/swa-db-connections'.
Looking for event info
Event info parsed from GitHub event json.
Skipping step to build /github/workspace/./_site with Oryx
Found staticwebapp.config.json file: '_site/staticwebapp.config.json'
Didn't find Oryx manifest file under location: /bin/staticsites/e47c04cd-260e-4fbf-86ed-29ba95663724-swa-oryx/app-manifest/oryx-manifest.toml
Determined default file to be: index.html
Using 'staticwebapp.config.json' file for configuration information, 'routes.json' will be ignored.
Calculating the size of app artifacts: 409548339 B
Try to validate location at: '/github/workspace/./_api'.
Api Directory Location: './_api' was found.
Skipping step to build /github/workspace/./_api with Oryx
Function Runtime Information. OS: windows, Functions Runtime: ~4, dotnetisolated version: 8.0
Found functions.metadata file
Zipping Api Artifacts
Api Zip will be created from directory: /github/workspace/./_api
Api Content Hash: 4ea5b8d7[19](https://github.com/nkdAgility/NKDAgility.com/actions/runs/11594635655/job/32281460532#step:7:20)77aadda19207122664a342
Done Zipping Api Artifacts
Zipping App Artifacts
App Zip will be created from directory: /github/workspace/./_site
Done Zipping App Artifacts
Uploading build artifacts.
Finished Upload. Polling on deployment.
Status: InProgress. Time: 0.1541086(s)
Status: InProgress. Time: 15.3149439(s)
Status: Succeeded. Time: 30.4664566(s)
Deployment Complete :)
Visit your site at: https://yellow-pond-042d21b03-68.westeurope.5.azurestaticapps.net/
Thanks for using Azure Static Web Apps!
Exiting

This is an unmonitored / rarely monitoed location! Get faster answers https://learn.microsoft.com/en-us/answers/tags/448/static-web-apps


Unable to answer question from otomi cli

Describe the bug: (a clear and concise description of what the bug is)
While performing command in otomi cli, the otomi makes sure that actions are performed on the right cluster and asks a user to confirm switching to the right kubernetes context. Unfortunately it does not parse user answers correctly.
To Reproduce Steps to reproduce the behavior:

Perform the following shell commands"

kubectl config use-context otomi-eks-dev
export CLOUD=aws CLUSTER=dev-1
otomi diff
Warning: Your current kubernetes context does not match target context: <context-name>. Would you like to switch kube context to target first? Yn

Answer Y
Observe that otomi exists immediately with non-zero exit code.

Expected behavior: (a clear and concise description of what you expected to happen)
The otomi cli parses correctly user answers.
Moreover, better formatting and white spaces after question, so
Would you like to switch kube context to target first? [Yn] Y

Instead of:
Would you like to switch kube context to target first? YnY

Screenshots: (if applicable, add screenshots to help explain your problem)
Cluster(s):

Cloud: aws
Cluster: dev

Versions: (seen in console's /settings)

Core Version 0.11.53

You report in observation step 3 that it exits with non zero exit code after giving false input, which is correct. Can you please rephrase what is going on? As I see this now this is intented behaviour and I will have to close this if you can't provide clearly what the problem is.

@Morriz, Apparently, it is not clear what is the right input.
Is Y an incorrect input, if so then there should be an error printed.

It is standard behaviour to offer the default value in capital, closing

I think @j-zimnowoda also was confused about the formatting here, it can be improved. Ie.:
YnY to [Yn] Y] where Y is what the user put in. At the moment there is no spacing between Yn and Y.

Look, just do what others do, and add the brackets then:
[Yn]

On 24 Dec 2020, at 08:32, Sebastiaan Verbeek<EMAIL_ADDRESS>wrote:

I think @j-zimnowoda also was confused about the formatting here, it can be improved. Ie.:
YnY to [Yn] Y] where Y is what the user put in. At the moment there is no spacing between Yn and Y.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.


Added DefaultAssembly parameter

This will allow compilation of XAML files which use clr-namespace references from within their own assembly, which are not allowed to have assembly directives under WPF.

Turn out that while this is generating seemingly valid XAML, the parser continues to fail, probably because the requested dll isn't actually referenced

Further testing into breaks has been done - the current branch is working, but only in debug configuration (hosting from VS doesn't seem to matter). Reopening the pull request for now, but more work is likely needed.

Merging and resolving a small conflict - still would like to see this included with the main build

I thought you are still working on it. I will test it and add that to next version. :)

My apologies for not being clearer sooner - there was a break, but I couldn't reproduce it after a rebuild, so I reopened. All's well now, hope to see this functionality soon


[CR] Waterbutler OneDrive Plugin

@felliott: This is ready for you to review.
Could you please review the copy functionality?  OneDrive's "Copy" function is asynchronous (the other methods are not) and requires the client to check the status of the copy job in order to know when it has completed.  If there's a better way than a for loop to check the OneDrive job status, please let me know.
Thanks!

Hey @caseyrygt,
It's looking good!  I'm going to pause on this for now, but I should be able to resume next week.
Cheers,
@felliott

Hey @caseyrygt,
Sorry for the long wait.  This is looking good, and your solution for copying is working perfectly for me!  I've left a few more issues to be addressed, and I think the downloading text files is still busted, but we're getting closer.  Thank you!
Cheers,
@felliott

hey @felliott, thanks for the feedback.  I'll get this and the OSF side of
things taken care of!
Best,
-Ryan
On Mon, Jul 11, 2016 at 3:13 PM, Fitz Elliott<EMAIL_ADDRESS>wrote:

Hey @caseyrygt https://github.com/caseyrygt,
Sorry for the long wait. This is looking good, and your solution for
copying is working perfectly for me! I've left a few more issues to be
addressed, and I think the downloading text files is still busted, but
we're getting closer. Thank you!
Cheers,
@felliott https://github.com/felliott
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CenterForOpenScience/waterbutler/pull/151#issuecomment-231834944,
or mute the thread
https://github.com/notifications/unsubscribe/ABVki-JVpHuPB4KVdmdU92KEAT3Gl-Gfks5qUpXpgaJpZM4IhV5S
.

--
Ryan Casey
CEO
http://www.growingtechnologies.com/
growingtechnologies.com
<EMAIL_ADDRESS>Direct:<PHONE_NUMBER>
For Technical Support:<PHONE_NUMBER> option 2 /
<EMAIL_ADDRESS>

I think the OneDrivePath code might need a rework.  Except for validate_v1_path and validate_path, the path argument to the methods you've implemented should always be an instance of OneDrivePath.  It's okay for you to provide OneDrive-specific implementations of WaterButlerPath methods.  one_drive_parent_folder should probably be parent and operate on self.  I'm not entirely sure but it looks file_path and ids are doing double-duty as constructors and accessors.  You might replace them with a _build_from_onedrive_response(self, data) class method that builds a new OneDrivePath object.  Then, the accessor functionality of those methods come from the WaterButlerPath.parts.  Also, WaterButlerPath has a from_parts class method that lets you build a new path object from an existing objects parts.

Closing in favor of #205, which extends the work done in this PR.  Thanks, @caseyrygt!


Page Updates

Could we get a RSS feed or twitter account update for when new content is posted? (Or is there and I can't find it?)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ee159bf-1044-a912-9920-288ac4e62050
Version Independent ID: 5f8063d7-034b-e708-685f-396659fa59d0
Content: What's new with Cloud App Security
Content Source: CloudAppSecurityDocs/release-notes.md
Service: cloud-app-security
GitHub Login: @rkarlin
Microsoft Alias: rkarlin

Hi @tmguinn
Thanks so much for your feedback. Those options aren't currently available in Docs, but I'll be sure to pass along your interest to the right people.
#docs-experience

I am lost reading the list. One thing I can not do is code..I have been saying that. Thank God for those that can. I haven't used Microsoft in a long while. It's on my daughter's computer. We can't even log onto it. I took it to my brother's, so he could look at it.. He said that he couldn't access it either. It's just been sitting here. My husband said we need to take it back to office max and let them look at it. I think it's still under warranty.


Add binary-search exercise (#297)

Related to #297
I put 2 as difficulty, what do you think?
Is the prototype and naming good (i.e. binary-search array value), or should it follow the instruction story (i.e. find-song-index playlist song)?
Do not hesitate to tell me there are things to modify @BNAndras. 😉

I put 2 as difficulty, what do you think?
Seems fine. The website bins difficulties 1 - 3 as "easy" so the specific level isn't too important. I try to avoid level 1 simply because exercises at the same level should be roughly equivalent in difficulty. hello-world is level 1 so only pretty straightforward exercises should also be level 1 in my opinion.

Is the prototype and naming good (i.e. binary-search array value), or should it follow the instruction story (i.e. find-song-index playlist song)?
The naming is fine. Typically, I'd go with the property name from the canonical test json if it makes sense (so find array value). If the name can be tweaked to be more idiomatic, I'd do that like when transforming a to b, you'll often see a->b like number->string'. However binary-search` is fine, and other tracks take that approach as well.

Ok, thanks!
Well, I think it's ready then. I'll wait for your review and try to work on another in the meantime. 😉

Sorry, I didn't see your review on my phone. The formatting issues are resolved.
Do not hesitate to tell me if there's anything else.

Done. 😉

Oh, and could you please add the hacktoberfest-accepted label? 🙏😄


Create a styles.css file.

Create the styles.css file for the Homepage project.

Created a styles.css file that contained CSS code for the resume template.


cargo doc generates ugly documentation

cargo doc seems to generate documentation for the trait based on the expanded code, rather than the pre-expansion code. e.g.

Is this fundamentally unfixable, or is there some way of getting cargo doc to display the trait with the pre-expansion form, document the methods as async fn etc?

This would need to be a feature request for rustdoc to support emitting async fn in traits. Currently there is no way.

That is very unfortunate. Is the only way manually documenting the async fns then?

Yeah you can do:
# Cargo.toml

[package.metadata.docs.rs]
rustdoc-args = ["--cfg", "docs_rs"]

// lib.rs

#![cfg_attr(docs_rs, feature(async_fn_in_trait))]

#[cfg_attr(not(docs_rs), async_trait::async_trait)]
pub trait Trait {
    async fn f();
}

I don't think this doc trick works universally anymore since the official async trait is stabilized but with a lot limitations.  In other words, some of the traits I created are not valid (can no longer compile) under the official async trait. So it might be the time to reconsider this ticket.


Switch CLI to yargs

[ ] This is a small change
[ ] This change has been discussed in issue #<?> and the solution has been agreed upon with maintainers.
[X] Completely forgot to open up an issue, will for sure do next time 😇

Description:
Hey there,
I switched our commander interface out with yargs, which should be a more reliable interface, plus it has these awesome features:

We can abstract common patterns (which config do I have, which platform am I supposed to run, etc) into nice middlewares, making the actual CLI code more human readable (To be done, if we agree that it makes sense)
We can test each CLI command, which is really nice to be sure we don't break anything while improving the user experience
It supports CLI plugins out of the box (which I think is cool because it allows third parties to make the CLI more powerful without writing their own wrappers with shell outs
Yargs allows bash completion, I will investigate how this works, it was not my top prio
Extendable configs from files and package.json like with babel presets.
We can write a lot of validation inside the yargs real already, making this outer bound of our system as rigorous as possible, so we don't have to check everything 100 times within the main code base.

I choose not to test init, as it seems a lot of effort for not too much win, do you agree?
If you have any questions please leave comments :)

@rotemmiz Answered and fixed everything 💪

@DanielMSchmidt I moved cli.js to local-cli.js.
I am still having a weird issue I can not trace:
running detox test --configuration ios.sim.release results in
node_modules/.bin/mocha e2e --opts e2e/mocha.opts --configuration ios.sim.release  --no-colors    --grep :android: --invert  --record-logs none --take-screenshots none --record-videos none --artifacts-location "artifacts/ios.sim.release.2019-02-07 20-17-13Z"  --testRunner mocha --configurations [object Object]

I couldn't find where --configurations is being added to program. The only place it exists in is:
const config = require(path.join(process.cwd(), 'package.json')).detox;

But I can't see how that is applied into program.
Your help is appreciated here :)

The issue seems bigger than the purposed fix in a0582e308cfea47b29f12f3cd77b68f7663b57c2.
Currently --testRunner is also leaked into collectExtraArgs.
Seems like these are all parameter of the detox config from package.json. I couldn't find where this is injected, but it probably should be filtered from collectExtraArgs as well.

@rotemmiz Ah yeah, that explains why I did not catch it in the very first moment, when this feature is not enabled, interesting 🤔 I'll think a bit about how to fix this, I mean we basically would also need to be carful about all other input options, so just filtering them out might not be the best option

Both confiurations and test-runner/testRunner are not CLI args, they are configuration parameters, they are somehow leaked into program.

@rotemmiz I think I got it, at least theoretically. We could create a new instance of a yargs program without any configuration within collectExtraArgs, then it should work just fine.


Make the transformation work for multiple models and modules

With other words: automatically sync modules and models that are imported in the model we use, but have not been synched yet.
When downloading modules (models) are dependent modules (and models) will be downloaded into MPS.

question: why do you save references to singletons e.g.
private val nodeMap = MpsToModelixMap
occurences in ModelBinding, ModuleBinding, ModelixTreeChangeVisitor, ModelTransformer, ModuleTrensformer, NodeTransformer, ModuleChangeListener, ModuleSynchronizer, NodeSynchronizer, SyncServiceImpl

question 2: can you use Javadoc coments within a method and what dies it do?
occurences in ModelBinding, ModuleBinding, SyncQueue, ModuleChangeListener

finding: why did you remove exception handeling for more specific Exceptions in ModelSyncService?

question: why do you save references to singletons e.g. private val nodeMap = MpsToModelixMap

Previously these Singletons were passed to the classes via constructor parameters to ease the unit testing of those classes (in unit testing those parameters can be replaced by mocks). However, those tests have not happened yet, but our code started to be jammed by the passing of the most common Singletons (i.e. NodeMap, SyncQueue, BindingsRegistry) between constructors. Therefore, I moved them to fields inside the classes where they are used. This way, they can be still replaced by mocks if needed.
The drawback of using them directly in-place in the code is, it's almost impossible to replace them there.

question 2: can you use Javadoc coments within a method and what dies it do?

I use javadoc (more specificalyl multiline) comments inside methods when I had to add some context and explanation to why we do some actions that do not seem to be trivial and obvious in those contexts. Another use-case was when I added some future TODOs that are also documented in the corresponding YouTrack issues.

why did you remove exception handeling for more specific Exceptions in ModelSyncService?

I joined them into the Exception block, because the other blocks were not adding any specific value to how we handle the exceptions. With other words: the error message prefixes were very similar and from the StackTrace we can see anyways what kind of exception flew.
However, I can revert that change if you wish to have the previous error handling.

https://github.com/modelix/modelix.core/pull/597#issuecomment-1993664529
As discussed on Slack, I've replaced javadoc-like comments with multiline comments inside methods. 57d1f81 fixes this


Error when git repository is listed in requirements.txt.

Description
Background
When I contributed with Llama-Hub, there was a complication that I could not register a new pypi account,
I specified a git repository (git+https://github.com/HawkClaws/main_content_extractor.git) in requirements.txt.
At that time, the following error occurred
error log
Exception has occurred: InvalidRequirement       (note: full exception trace is shown but execution is paused at: _run_module_as_main)
Parse error at "'+https:/'": Expected string_end
  File "C:\Users\XXX\AppData\Local\Programs\Python\Python311\Lib\site-packages\pkg_resources\_vendor\packaging\requirements.py", line 102, in __init__
    req = REQUIREMENT.parseString(requirement_string)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\XXX\AppData\Local\Programs\Python\Python311\Lib\site-packages\pkg_resources\_vendor\pyparsing\core.py", line 1141, in parse_string
    raise exc.with_traceback(None)
pkg_resources._vendor.pyparsing.exceptions.ParseException: Expected string_end, found '+'  (at char 3), (line:1, col:4)

During handling of the above exception, another exception occurred:

  File "C:\Users\XXX\AppData\Local\Programs\Python\Python311\Lib\site-packages\pkg_resources\_vendor\packaging\requirements.py", line 104, in __init__
    raise InvalidRequirement(
  File "C:\Users\XXX\AppData\Local\Programs\Python\Python311\Lib\site-packages\pkg_resources\__init__.py", line 3102, in __init__
    super(Requirement, self).__init__(requirement_string)
  File "C:\Users\XXX\AppData\Local\Programs\Python\Python311\Lib\site-packages\llama_index\download\download_utils.py", line 231, in <listcomp>
    pkg_resources.require([str(r) for r in requirements])
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\XXX\AppData\Local\Programs\Python\Python311\Lib\site-packages\llama_index\download\download_utils.py", line 231, in download_module_and_reqs
    pkg_resources.require([str(r) for r in requirements])
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\XXX\AppData\Local\Programs\Python\Python311\Lib\site-packages\llama_index\download\download_utils.py", line 287, in download_llama_module
    download_module_and_reqs(
  File "C:\Users\XXX\AppData\Local\Programs\Python\Python311\Lib\site-packages\llama_index\readers\download.py", line 44, in download_loader
    reader_cls = download_llama_module(
                 ^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\XXX\Desktop\TEST\main_content_extractor_test\reader_test.py", line 13, in <module>
    MainContentExtractorReader = download_loader("MainContentExtractorReader")
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\XXX\AppData\Local\Programs\Python\Python311\Lib\runpy.py", line 88, in _run_code
    exec(code, run_globals)
  File "C:\Users\XXX\AppData\Local\Programs\Python\Python311\Lib\runpy.py", line 198, in _run_module_as_main (Current frame)
    return _run_code(code, main_globals, None,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pkg_resources.extern.packaging.requirements.InvalidRequirement: Parse error at "'+https:/'": Expected string_end
InvalidRequirement

Fixes
The error occurs in the pkg_resources.require part of the following code in `download_utils.py
        try:
            requirements = pkg_resources.parse_requirements(
                Path(requirements_path).open()
            )
            pkg_resources.require([str(r) for r in requirements])
        except (DistributionNotFound, InvalidRequirement):
            subprocess.check_call(
                [sys.executable, "-m", "pip", "install", "-r", requirements_path]
            )

The implementation seems to allow git+https:hogehoge as well, since it executes pip install in case of a DistributionNotFound exception, but the error when git+https:hogehoge is specified is packaging.requirements.InvalidRequirement.
So I fixed it to allow InvalidRequirement exceptions as well.
Fixes # (issue)
Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[x] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I ran make format; make lint to appease the lint gods

Hey @HawkClaws,
Thanks for the submission. Our llama-hub is fairly new as you know, and so admittedly we have not yet figured out our standards when making submissions — there is a focused effort to get us to a good spot on this soon.
As llama-hub is essentially a registry of packages that can be installed, we do want to keep in mind the safety of our consumers. As such, we've decided at this time to not allow requirements coming from a github repo.
Could you kindly upload your package to pypi?

Due to a technical problem on the pypi side, I am having difficulty uploading to pypi as the new registration button does not take me to the registration page. I will try to give more time on this one.
Another point of view is the idea of installing from pypi instead of from the git repository for security reasons, which I think is a good idea.
However, I do not agree with not allowing requirements from the github repository.
Because the requirements.txt of the package deeplake_multimodal_retrieval from Llama-Hub says clip @ git+https://github.com/openai/CLIP.git. The clip @ git+ is
We think it is not a good idea for individuals to upload libraries from the openai repository to pypi
Translated with DeepL.com (free version)

I decided to upload the package to pypi
I'm going to close it.


Added maxValueSize to allow configuration of the value size to allow

Memcache can now be configured on how big is the value to be stored, so, this should be configurable. We are using right now a 10MB size.

@victorquinn whenever you can, could you check this PR? Thanks!

Looks great, thanks!
Apologies on the long response, I somehow wasn't subscribed to notifications for this repo so your mentioning me was the first message I actually got about it.
I'll push this to npm and update here.

Ok, this is deployed to npm as 0.2.4!

Ahhh whoops ignore my comment which referenced this PR, meant to reference #10 which broke callbacks, sorry!


revise rates for emnlp20/emnlp21/acl21/naacl21

I revise the rates for EMNLP 2020, EMNLP 2021, ACL-IJCNLP 2021, and NAACL 2021. I separately show the acceptance rates for long and short papers in Main Conference and Findings.

Cool, it looks better now. Thank you for your contribution.


Fix multiple emails in notification policy

Setting data["id"] only saves the last value as it keeps writing to the same map. Instead a new map should be created for each value.
Fixes: https://github.com/cloudflare/terraform-provider-cloudflare/issues/1917

thanks for this @Qantas94Heavy. can you please add an acceptance test that will demonstrate this fixes the issue?

acceptance tests all looking good
TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareNotificationPolicy_" -timeout 120m -parallel 1
=== RUN   TestAccCloudflareNotificationPolicy_Basic
--- PASS: TestAccCloudflareNotificationPolicy_Basic (26.83s)
=== RUN   TestAccCloudflareNotificationPolicy_WithFiltersAttribute
--- PASS: TestAccCloudflareNotificationPolicy_WithFiltersAttribute (24.59s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	52.330s

thanks @Qantas94Heavy 💯


Add sidecar to Keycloack deployment

Description
I would like to add a container sidecar to Keycloack deployment. Is it possible to create this sidecar with  the Keycloak CR?
Discussion
No response
Motivation
No response
Details
No response

Hello, if this is still valid, could you please open an issue in the main Keycloak repository? This repository is not monitored or used for tracking issues.
Thank you.


Create uiz

https://www.uiz.ac.ma

@amhamdi74 First stage of verification passed, official domain is uiz.ac.ma as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@amhamdi74 Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Made the applet to honour the colour setting of bind_mode_*

Now is also honouring the colour settings for the binding mode.
Please review it and take into account that these are among the first lines of python I ever wrote...
Thanks.

Thanks for doing these! I'm out travelling now, but will take a good look at these PRs next week.

Thanks! I will cut a new release with your changes right now.


pkg/controller/grafanadashboard: avoid refetching URL

If dashboard has only URL set in GrafanaDashboard spec, the operator should fetch it once and avoid refetching it on every reconciliation. Fetched contents would be written in .spec.json.
Dashboard provider may start throwing "429 Too Many Requests" after some time (i.e. grafana.com),
so dashboard can no longer be fetched.
URL may change contents, so users should remove .spec.json in order to refetch dashboard contents.
Related to #45 (not entirely sure if it fixes it)

Merging this, avoiding network requests makes sense. We should follow up by updating the docs and example.