Add Ingress resource support to Galley

fixes https://github.com/istio/istio/issues/9490

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren
If they are not already assigned, you can assign the PR to them by writing /assign @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS
install/kubernetes/helm/subcharts/galley/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
4a4ab13ddd4df17f2380a30d5cf86251097f23bb
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
4a4ab13ddd4df17f2380a30d5cf86251097f23bb
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
4a4ab13ddd4df17f2380a30d5cf86251097f23bb
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
4a4ab13ddd4df17f2380a30d5cf86251097f23bb
link
/test istio-integ-k8s-tests

prow/istio-integ-local-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-dashboard

prow/e2e-mixer-no_auth-mcp.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-dashboard

prow/e2e-mixer-no_auth-mcp.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-mixer-no_auth-mcp

prow/istio-pilot-multicluster-e2e.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-dashboard

prow/e2e-mixer-no_auth-mcp.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-mixer-no_auth-mcp

prow/istio-pilot-multicluster-e2e.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-dashboard.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-dashboard

prow/e2e-mixer-no_auth-mcp.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-mixer-no_auth-mcp

prow/istio-pilot-multicluster-e2e.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-simpleTests

prow/e2e-mixer-no_auth.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth-mcp.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-mixer-no_auth-mcp

prow/istio-pilot-multicluster-e2e.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
af5e69a3a5dbc36ca115fb05ba2f77e08351fa3f
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
af5e69a3a5dbc36ca115fb05ba2f77e08351fa3f
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
af5e69a3a5dbc36ca115fb05ba2f77e08351fa3f
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
a1e2c2e2935e6aa2e59f7bce14251f8247ac269f
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-local-tests.sh
af5e69a3a5dbc36ca115fb05ba2f77e08351fa3f
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
af5e69a3a5dbc36ca115fb05ba2f77e08351fa3f
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
af5e69a3a5dbc36ca115fb05ba2f77e08351fa3f
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth-mcp.sh
af5e69a3a5dbc36ca115fb05ba2f77e08351fa3f
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
af5e69a3a5dbc36ca115fb05ba2f77e08351fa3f
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
af5e69a3a5dbc36ca115fb05ba2f77e08351fa3f
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth-mcp.sh
af5e69a3a5dbc36ca115fb05ba2f77e08351fa3f
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-local-tests.sh
ca6c2d234c5b531af11a99bb3279491c0824971d
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
af5e69a3a5dbc36ca115fb05ba2f77e08351fa3f
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth-mcp.sh
af5e69a3a5dbc36ca115fb05ba2f77e08351fa3f
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-local-tests.sh
ca6c2d234c5b531af11a99bb3279491c0824971d
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
ca6c2d234c5b531af11a99bb3279491c0824971d
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
ca6c2d234c5b531af11a99bb3279491c0824971d
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
ca6c2d234c5b531af11a99bb3279491c0824971d
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth-mcp.sh
ca6c2d234c5b531af11a99bb3279491c0824971d
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
ca6c2d234c5b531af11a99bb3279491c0824971d
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
ca6c2d234c5b531af11a99bb3279491c0824971d
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth-mcp.sh
ca6c2d234c5b531af11a99bb3279491c0824971d
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
ca6c2d234c5b531af11a99bb3279491c0824971d
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
ca6c2d234c5b531af11a99bb3279491c0824971d
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth-mcp.sh
ca6c2d234c5b531af11a99bb3279491c0824971d
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
ca6c2d234c5b531af11a99bb3279491c0824971d
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
ca6c2d234c5b531af11a99bb3279491c0824971d
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
ca6c2d234c5b531af11a99bb3279491c0824971d
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
ca6c2d234c5b531af11a99bb3279491c0824971d
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ayj
If they are not already assigned, you can assign the PR to them by writing /assign @ayj in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS
install/kubernetes/helm/subcharts/galley/OWNERS
pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Accommodated all feedback. PTAL.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
5cd9c19a4933017df980af547a7e021ee445ea84
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
5cd9c19a4933017df980af547a7e021ee445ea84
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
5cd9c19a4933017df980af547a7e021ee445ea84
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth

prow/istio-integ-k8s-tests.sh
5cd9c19a4933017df980af547a7e021ee445ea84
link
/test istio-integ-k8s-tests

prow/istio-integ-local-tests.sh
ea091b5893a256b2d950211363207f1346e481b7
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
ea091b5893a256b2d950211363207f1346e481b7
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
ea091b5893a256b2d950211363207f1346e481b7
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
ea091b5893a256b2d950211363207f1346e481b7
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
ea091b5893a256b2d950211363207f1346e481b7
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ea091b5893a256b2d950211363207f1346e481b7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
ea091b5893a256b2d950211363207f1346e481b7
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
ea091b5893a256b2d950211363207f1346e481b7
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ea091b5893a256b2d950211363207f1346e481b7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
ea091b5893a256b2d950211363207f1346e481b7
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [ayj]
install/kubernetes/helm/subcharts/galley/OWNERS [ayj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth

prow/istio-integ-k8s-tests.sh
ea091b5893a256b2d950211363207f1346e481b7
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ea091b5893a256b2d950211363207f1346e481b7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
ea091b5893a256b2d950211363207f1346e481b7
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/istio-integ-local-tests.sh
09775a4ac050fb8892093ec3d701f942602a628d
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ea091b5893a256b2d950211363207f1346e481b7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
ea091b5893a256b2d950211363207f1346e481b7
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/istio-integ-local-tests.sh
09775a4ac050fb8892093ec3d701f942602a628d
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
09775a4ac050fb8892093ec3d701f942602a628d
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth

prow/istio-integ-k8s-tests.sh
09775a4ac050fb8892093ec3d701f942602a628d
link
/test istio-integ-k8s-tests

prow/istio-integ-local-tests.sh
5e4aa1ec268d149cbe6d948ae1917b70579246ec
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
5e4aa1ec268d149cbe6d948ae1917b70579246ec
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
5e4aa1ec268d149cbe6d948ae1917b70579246ec
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth

prow/istio-integ-k8s-tests.sh
5e4aa1ec268d149cbe6d948ae1917b70579246ec
link
/test istio-integ-k8s-tests

prow/istio-integ-local-tests.sh
067dc7c9fa6dd3901317eb4e337411bb70120589
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
067dc7c9fa6dd3901317eb4e337411bb70120589
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
067dc7c9fa6dd3901317eb4e337411bb70120589
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth

prow/istio-integ-local-tests.sh
067dc7c9fa6dd3901317eb4e337411bb70120589
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
067dc7c9fa6dd3901317eb4e337411bb70120589
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
067dc7c9fa6dd3901317eb4e337411bb70120589
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth

prow/istio-integ-k8s-tests.sh
067dc7c9fa6dd3901317eb4e337411bb70120589
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
067dc7c9fa6dd3901317eb4e337411bb70120589
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
067dc7c9fa6dd3901317eb4e337411bb70120589
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/istio-integ-local-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
067dc7c9fa6dd3901317eb4e337411bb70120589
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
067dc7c9fa6dd3901317eb4e337411bb70120589
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/istio-integ-local-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/e2e-mixer-no_auth.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
067dc7c9fa6dd3901317eb4e337411bb70120589
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-integ-local-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
067dc7c9fa6dd3901317eb4e337411bb70120589
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-integ-local-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-mixer-no_auth.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-local-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-mixer-no_auth.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-local-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-mixer-no_auth.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

failed to get a Boskos resource

/test istio-pilot-e2e-envoyv2-v1alpha3
/test e2e-simpleTests
/test e2e-mixer-no_auth
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [ayj]
install/kubernetes/helm/subcharts/galley/OWNERS [ayj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test e2e-mixer-no_auth

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
bc06b1112dd50f0ca09ff9d39ae6899f1f20c40e
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-local-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-mixer-no_auth.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-simpleTests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfoTests-envoyv2-v1alpha3

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-e2e-envoyv2-v1alpha3-mcp

prow/e2e-mixer-no_auth.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@ozevren: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ayj
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
53dede468147b70fcab7d58c58400d6ef21b596c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
53dede468147b70fcab7d58c58400d6ef21b596c
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
53dede468147b70fcab7d58c58400d6ef21b596c
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
53dede468147b70fcab7d58c58400d6ef21b596c
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
53dede468147b70fcab7d58c58400d6ef21b596c
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
53dede468147b70fcab7d58c58400d6ef21b596c
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
53dede468147b70fcab7d58c58400d6ef21b596c
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
53dede468147b70fcab7d58c58400d6ef21b596c
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
53dede468147b70fcab7d58c58400d6ef21b596c
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
53dede468147b70fcab7d58c58400d6ef21b596c
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [ayj]
install/kubernetes/helm/subcharts/galley/OWNERS [ayj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
53dede468147b70fcab7d58c58400d6ef21b596c
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
53dede468147b70fcab7d58c58400d6ef21b596c
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
53dede468147b70fcab7d58c58400d6ef21b596c
link
/test istio-presubmit

prow/istio-integ-local-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-k8s-tests.sh
53dede468147b70fcab7d58c58400d6ef21b596c
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
53dede468147b70fcab7d58c58400d6ef21b596c
link
/test istio-presubmit

prow/istio-integ-local-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth-mcp

prow/istio-presubmit.sh
53dede468147b70fcab7d58c58400d6ef21b596c
link
/test istio-presubmit

prow/istio-integ-local-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-local-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-local-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-presubmit

prow/istio-unit-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-local-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-integ-local-tests

prow/istio-presubmit.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-presubmit

prow/istio-unit-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-local-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-presubmit

prow/istio-integ-local-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-presubmit

prow/istio-integ-local-tests.sh
fda8771c8340210a53a90579d2b2f79bb03a0cc9
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth-mcp.sh
bc4bf5f44098e7f088e285dc61f14dbc2e281bcd
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-unit-tests

prow/istio-presubmit.sh
e340adb6998e8fffd456a430173edf65ae09ce6f
link
/test istio-presubmit

prow/istio-integ-local-tests.sh
fda8771c8340210a53a90579d2b2f79bb03a0cc9
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
fda8771c8340210a53a90579d2b2f79bb03a0cc9
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [ayj]
install/kubernetes/helm/subcharts/galley/OWNERS [ayj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
fda8771c8340210a53a90579d2b2f79bb03a0cc9
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
fda8771c8340210a53a90579d2b2f79bb03a0cc9
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth-mcp.sh
fda8771c8340210a53a90579d2b2f79bb03a0cc9
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


ternary conditional operator

Hello there,
hope you're fine,
Isn't it possible to use ternary conditional operators in eta template views?
As an example:
<text x="0" y="0" fill="<% = it.condition ? it.value1 : it.value2 %>"/>
It would be great if we could use this feature in our template views, it makes our code clean and concise.
Thanks!

@AmirABody You can use ternary operators because Eta interpolates JS.
<text x="0" y="0" fill="<%= it.condition ? it.value1 : it.value2 %>"/>

100% works. I'll add this to the docs soon though.


Fix empty span node is inserted

An empty span node was inserted in content editable upon completion. This fix remove the span node that was created only to compute the position of the caret.

Good catch!

Thanks! Can you bump the version on Bower?

Done!


[big-refactor] Question with parallelize=True

With parallelize=True, I think it should be like fsdp and each gpu should use similar memory:
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 515.65.01    Driver Version: 515.65.01    CUDA Version: 11.7     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  NVIDIA A100-SXM...  On   | 00000000:3F:00.0 Off |                    0 |
| N/A   39C    P0    95W / 400W |  57607MiB / 81920MiB |      0%      Default |
|                               |                      |             Disabled |
+-------------------------------+----------------------+----------------------+
|   1  NVIDIA A100-SXM...  On   | 00000000:44:00.0 Off |                    0 |
| N/A   46C    P0   360W / 400W |  29373MiB / 81920MiB |     92%      Default |
|                               |                      |             Disabled |
+-------------------------------+----------------------+----------------------+
|   2  NVIDIA A100-SXM...  On   | 00000000:62:00.0 Off |                    0 |
| N/A   36C    P0   204W / 400W |  29373MiB / 81920MiB |     18%      Default |
|                               |                      |             Disabled |
+-------------------------------+----------------------+----------------------+
|   3  NVIDIA A100-SXM...  On   | 00000000:68:00.0 Off |                    0 |
| N/A   39C    P0    78W / 400W |  29373MiB / 81920MiB |      0%      Default |
|                               |                      |             Disabled |
+-------------------------------+----------------------+----------------------+
|   4  NVIDIA A100-SXM...  On   | 00000000:A9:00.0 Off |                    0 |
| N/A   39C    P0    83W / 400W |  29373MiB / 81920MiB |      0%      Default |
|                               |                      |             Disabled |
+-------------------------------+----------------------+----------------------+
|   5  NVIDIA A100-SXM...  On   | 00000000:AD:00.0 Off |                    0 |
| N/A   32C    P0    73W / 400W |  29373MiB / 81920MiB |      0%      Default |
|                               |                      |             Disabled |
+-------------------------------+----------------------+----------------------+
|   6  NVIDIA A100-SXM...  On   | 00000000:D2:00.0 Off |                    0 |
| N/A   33C    P0    93W / 400W |  36099MiB / 81920MiB |      0%      Default |
|                               |                      |             Disabled |
+-------------------------------+----------------------+----------------------+
|   7  NVIDIA A100-SXM...  On   | 00000000:D5:00.0 Off |                    0 |
| N/A   35C    P0    77W / 400W |   1057MiB / 81920MiB |      0%      Default |
|                               |                      |             Disabled |
+-------------------------------+----------------------+----------------------+

As you can see, the first gpu is much more cosuming and at each time, only one gpu is running.

Thanks for noting this! I've added more description to the README about this option https://github.com/EleutherAI/lm-evaluation-harness/pull/638 , let me know if this clears things up.
We do however support FSDP in addition to parallelize=True, which @fattorib will be documenting in this readme section soon!


Fix/TransformersRerankPlugin: Fix query and choices encoding

Fix and improve the usage of encode_plus function:
Set the return_token_type_ids flag to prevent KeyErrors when using
custom models. Currently "token_type_ids" key is not present in the encoded dict
Set max_length while encoding, to reduce computation cost and avoid
unnecessary warnings

Thanks 👍


Does this library support child (namespaced) routers?

If supported, how to write the config object?

Would be nice to be able to do this. +1

Seems like a useful addition. Will look into it soon.
In the meantime, consider sponsoring this project or at least starring it :)

Should be done in https://github.com/omar-dulaimi/trpc-shield/releases/tag/0.4.0

Hey @moranbw
Could open a new issue/feature request for this?
I usually forget closed issues


Failed to get the template icon from Gitee on environment dependency graph

Describe the bug

Steps to reproduce

Add catalog form Gitee https://catalog.seal.io/walrus-catalog.
Using Gitee template to create resources.
Check the dependency graph of the environment.

Result

Cannot get the template icon from Gitee.

Expected behavior

Environment

Walrus version: main 942e758b93603e9ad40f9da90260c30af5ea350b
UI version: dev-b511a81

Additional context
Add any other context about the problem here.

Environment

Walrus version: main 98e5445080de1e1017db16951dd12d8e1e52b27f
UI version: dev-3fcbabe

Test Result: pass


Support Multiple LoRa Adapters, Closes #7627

Hi, so I've updated the Llama server by allowing it to handle multiple LoRa adapters. Previously, the server supported only one LoRa adapter, limiting users who needed to apply multiple adapters for advanced fine-tuning.
Changes Made:

Command-Line Parsing:

Updated to accept multiple --lora flags.
Introduced multiLPath to handle multiple LoRa paths.

Model Loading:

Modified the loadModel function to loop through and apply each specified LoRa adapter.
Removed the restriction that only one adapter can be used at a time in llm/server.go.

Hi, I've moved the utils down to the loadModel function and have added the "closes" phrase in the commit title.

Thank you for your contribution!


buildFHSEnv: disable security features by default

Description of changes
The implicit contract of buildFHSUserEnv was that it allows to run software built for a typical GNU/Linux distribution (not NixOS) without patching it (patchelf, autoPatchelfHook, etc.). Note that this does not inherently imply running untrusted programs.
buildFHSUserEnv was implemented by using chroot and assembling a standard-compliant FHS environment in the new root. As expected, this did not provide any kind of isolation between the system and the programs.
However, when it was later reimplemented using bubblewrap (PR #225748), which is a security tool, several isolation features involving detaches Linux namespaces were turned on by default. This decision has introduced a number of breakages that are very difficult to debug and trace back to this change.
For example: unshareIPC breaks software audio mixing in programs using ALSA (dmix) and unsharePID breaks gdb,
Since:

the security features were enable without any clear threat model;
buildFHSEnvBubblewrap is supposed to be a drop-in replacement of buildFHSEnvChrootenv (see the release notes for NixOS 23.05);
the change is breaking in several common cases (security does not come for free);
the contract was not changed, or at least communicated in a clear way to the users;

all security features should be turned off by default.
P.S. It would be useful to create a variant of buildFHSEnv that does provide some isolation. This could unshare some namespaces and mount only limited parts of the filesystem.
Note that buildFHSEnv mounts every directory in / under the new root, so again, very little is gained by unsharing alone.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Looks sane to me!
On a side note: we probably should write down the unwritten contract somewhere?

@xaverdh
https://github.com/NixOS/nixpkgs/blob/2fa96bfc08a1150ad148bedb62ab11e928c9446e/doc/builders/special/fhs-environments.section.md?plain=1#L4

@xaverdh
https://github.com/NixOS/nixpkgs/blob/2fa96bfc08a1150ad148bedb62ab11e928c9446e/doc/builders/special/fhs-environments.section.md?plain=1#L4

ah, I missed that. Then it really should be fine!

Given the docs and the compat raison d'être this is a desirable change to increase compat.

We might want to ping all maintainers of packages that still use chrootenv for some reason or another. I've got a script for that but I might forget '^^

@buckley310 for vmware-horizon-client
@jshcmpbll for davince-resolve
@kwohlfahrt  for quartus

I suggest backporting to release-23.05 due to https://github.com/NixOS/nixpkgs/pull/260906#issuecomment-1774070797.

@rnhmjoj could you add a little release note on this? Despite the obscurity and unintended nature, changing this might still break users' setups.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/23-11-good-time-to-switch-to-unstable/34950/5


[#7962] record configured response header

Feature
Record response header on server/client side.
Configuration
profiler.http.record.response.headers=Connection,Location,ExternalTraceid,Set-Cookie
Status
Server Side
Plugin        Implemented         Tested
Jetty                 Yes                    Yes
Tomcat             Yes                    Yes
Reactor-netty    Yes                    Yes
Undertow           Yes                    Yes
Jboss                 Yes                    No
Resin                 Yes                    No
Weblogic            No                      No
Websphere         No                      No
Note: If the feature for Weblogic & Websphere plugins had been implemented, the status code recorder can be removed from the ServletRequestListener completely and currently is kept for compatibility.
Client Side
Plugin        Implemented         Tested
httpclient4         Yes                       Yes
httpclient3          Yes                       Yes
okhttp                  Yes                      Yes
okhttp3                 Yes                      Yes
jdk http                Yes                        Yes
resttemplate        Yes                      Yes
webflux                Yes                      Yes
reactor-netty        Yes                       Yes
Demo
Configured header occurred once:

Configured header occurred multiple times:

Configured header applied on client side:

Additional changes

Move response status recorder to ServletResponseListener.
Extract the common interface methods of SpanRecorder and SpanEventRecorder to SpanCommonRecorder.

Codecov Report

Merging #7968 (e3940d9) into master (66c9d18) will decrease coverage by 7.94%.
The diff coverage is 29.65%.

@@             Coverage Diff              @@
##             master    #7968      +/-   ##
============================================
- Coverage     38.57%   30.62%   -7.95%
- Complexity        0    11262   +11262
============================================
  Files          3516     3282     -234
  Lines        100607   117310   +16703
  Branches      12348    16188    +3840
============================================
- Hits          38806    35930    -2876
- Misses        58798    78022   +19224
- Partials       3003     3358     +355

Impacted Files
Coverage Δ

...int/bootstrap/async/AsyncContextAccessorUtils.java
25.00% <ø> (ø)

...point/bootstrap/classloader/BootLoaderFactory.java
37.50% <ø> (ø)

...otstrap/classloader/DynamicClassLoaderFactory.java
0.00% <ø> (ø)

...p/pinpoint/bootstrap/classloader/J9BootLoader.java
0.00% <ø> (ø)

...oint/bootstrap/classloader/LauncherBootLoader.java
56.75% <ø> (ø)

...oint/bootstrap/classloader/MergedEnumeration2.java
82.60% <ø> (ø)

...int/bootstrap/classloader/ParallelClassLoader.java
39.53% <ø> (ø)

...tstrap/classloader/ParallelClassLoaderFactory.java
100.00% <ø> (ø)

...tstrap/classloader/PinpointClassLoaderFactory.java
52.38% <ø> (ø)

...npoint/bootstrap/classloader/ProfilerLibClass.java
80.00% <ø> (ø)

... and 3960 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d98f1d...e3940d9. Read the comment docs.

@emeroad PTAL and looking forward to your advice.

Rebased on the current master.

@yjqg6666 :+1:
It seems to be a very useful feature.
I will merge in 2.3.1

I will add more commits for recording response header on http client side and still working on it.

Work on the client side is done.

@yjqg6666 👍
It seems to be a very useful feature.
I will merge in 2.3.1

@emeroad When will 2.3.1 be released? and will it support to record request header? I need this feature to get mapping with our internal monitoring system. Thank you!

@linxu163 Recording request header feature has already been available since version 2.1.0. You may check the release note:
https://github.com/pinpoint-apm/pinpoint/releases/tag/v2.1.0 under section "Record request header & cookie" and the related PR is #6897 if you are interested.

@linxu163 Recording request header feature has already been available since version 2.1.0. You may check the release note:
https://github.com/pinpoint-apm/pinpoint/releases/tag/v2.1.0 under section "Record request header & cookie" and the related PR is #6897 if you are interested.

@yjqg6666 Thank you so much! I would enable it right now

For JDK HttpUrlConnection reading response header will cause the output stream closed, so we need to read response header only when the getInputStream is being intercepted.

This PR contains bugfix for #8019 for recording https call made by jdk http client.

Set the config value to HEADERS-ALL to record all of the response headers from server/client side.

Rebased on the current master (2.3.1-snapshot).


Arc - Update Postgres name length limit

Arc - Update Postgres name length limit.  It was recently reduced from 12 to 11:
azdata arc postgres server create -n abcdefghijkl
Azure Arc enabled PostgreSQL Hyperscale server group name 'abcdefghijkl' exceeds 11 character length limit

Pull Request Test Coverage Report for Build 422031973

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 43.161%

Totals

Change from base Build 421908751:
-0.001%

Covered Lines:
24109

Relevant Lines:
51208

💛  - Coveralls


Allow media picker to use same orientation as it was called from

This PR addresses Issues #6 and #7 that I opened earlier.
This PR opens the FSMediaPicker in the same orientation from which it was called.  This is done by subclassing UIImagePickerController to FSImagePickerController and adding:
- (UIInterfaceOrientationMask)supportedInterfaceOrientations {
    return UIInterfaceOrientationMaskAllButUpsideDown;
}

Inadvertently left other unneeded code changes in.  Will submit a new PR


Launch error

Dear Sir,
(roslaunch ros_autonomus_slam turtlebot3_world.launch ) command can not be executed. The error mentions that it “ is neither a launch file in package“. Instead (roslaunch turtlebot3_gazebo turtlebot3_world.launch) can be executed.
Can you please help me out.

cd workspace
source devel/setup.bash

I have fix the issue. In RVIZ the robot is not moving, can anyone tell me where I am wrong.

I unfortunately have got the same problem.
I already did:
"cd workspace
source devel/setup.bash"
However, I still receive the error "RLException: [turtlebot3_world.launch] is neither a launch file in package [ros_autonomus_slam] nor is [ros_autonomus_slam] a launch file name"

There is a fix in issue #8


Document passing text argument to sort

The problem
Please document how does sort works on text. does it split every word to chars then compares each char? and if that is the case, does that mean sorting happens twice?
Please also see: https://colabti.org/irclogger/irclogger_log/perl6?date=2019-09-18#l91

The docs for sort already say “Sorts iterables with cmp”, so as far as I'm concerned the docs for sort are OK. It's cmp that is missing documentation on how it works for strings.


Deesharma/exttypescli

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

k8s-extension

ModuleNotFoundError: No module named 'azext_k8s_configuration.vendored_sdks.v2021_09_01.aio.operations._cluster_extension_type_operations'

This CI issue is caused by the absence of _cluster_extension_type_operations file in directory src/k8s-extension/azext_k8s_extension/vendored_sdks/v2021_09_01/aio/operations
This may be caused by you did not specify the api-version for cf_k8s_extension_operation
https://github.com/Azure/azure-cli-extensions/blob/654355f4ec9f070371df68b99c62bd897950b77a/src/k8s-extension/azext_k8s_extension/_client_factory.py#L15-L16
So there should still be a reference to api-version v2021_09_01 in the Python SDK
https://github.com/Azure/azure-cli-extensions/blob/654355f4ec9f070371df68b99c62bd897950b77a/src/k8s-extension/azext_k8s_extension/vendored_sdks/aio/_source_control_configuration_client.py#L221-L222

Please write the description of these change into the HISTORY.rst. In addition, if you want to release a new extension for this PR, please also modify the setup.py


JWT-based GUI authentication

What does this PR do?
Adds a better authentication system for the Agent 6 GUI.
Here's how it works:

if the GUI is enabled, at agent start-up it creates a server which listens at <IP_ADDRESS>:8080 (or whichever port was specified in datadog.yaml) and serves

a secured filesystem containing the GUI files at the default endpoint
a single, unsecured file at <IP_ADDRESS>:8080/authenticate

it then creates a pair of RSA keys, creates a JWT and signs it with the private RSA key, and then opens <IP_ADDRESS>: 8080/authenticate with this JWT present as a URL parameter
in the browser, when <IP_ADDRESS>:8080/authenticate loads it

parses the URL
saves the URL parameter as a cookie (named "token")
redirects to the default endpoint

when the server receives a request to load a file from the secured filesystem, the server reads the client's "token" cookie and then validates it against the public RSA key

if this passes, it serves the requested file
if this fails (or if the cookie isn't present), it responds with HTTP 401 Status: Unauthorized error

similarly, all the API endpoints are rejected if they do not contain an authorization header containing the correct token

Motivation
The GUI needs a strong authentication system because it enables clients to see & edit secured files.
Additional Notes
Since a new JWT is generated every time the agent starts & therefore is only valid during the lifetime of the agent that starts it, I didn't add an expiration date to the token. If we do decide to add one, we would also have to add some kind of agent command which would generate a new JWT and re-open the GUI.

 [GUI] Needs a reasonable authentication method.


added run_name_prefix to tensorboard

DO NOT MERGE THIS, simply an example of maxtext and vertex ai tensorboard integration.


Ember 1.12 support?

Hi there, first of all thanks for the great plugin which replaces the lack of support of the native checkbox.
I'm trying to use this on a project with Ember 1.12 (did not have a chance to upgrade yet) and it appears that when I use onchange=(action 'listChanged') it throws an error saying Cannot read property 'setAttribute of undefined
In Ember 1.12 and it's components we do not use onchange=(action 'actionName') . We simply use onchange='listChanged' (action name), however this does not work because it seems the code is calling functionName() instead of using the sendAction ( https://github.com/RSSchermer/ember-multiselect-checkboxes/blob/master/addon/components/multiselect-checkboxes.js#L29 ) .
Do you have any thoughts on how I could use this with 1.12 and fix this problem with the action?
Bedankt en groetjes :+1:

Hey, thanks for bringing this up.
I can't give you a solution off hand. I think we'd have to support both passing a string and a function to handle this. However, I'm not sure how well that would play with the current and future versions of Ember. Although it would of course be nice to support older versions of Ember as much as possible, supporting the current (and future) version as best as possible takes priority.
I'll have to investigate and experiment a bit. You've caught me at a somewhat busy time, so please bear with me for a bit (feel free to bump this in a couple of days though if I haven't come back to this). If this doesn't pan out, I could still always create a separate 1.12 branch that supports this for you. I wouldn't be supporting and updating that branch as this addon evolves further, but it should cover you're use case for now, untill hopefully some day you'll be to upgrade to Ember 2.x.

It has been a while, my apologies. It has been a busy time for me and this fell of my radar.
Is this still an issue for you? It occurred to me that depending on what your use case is, you might be able to use an observer on your selection property. Something like this:
// some-controller.js
import Ember from 'ember';

export default Ember.Controller.extend({
  mySelection: [],

  selectionChanged: Ember.observer('mySelection', function () {
    let selection = this.get('mySelection');

    // Do something with the selection
  })
});

If this doesn't work for your use case, I'll see about setting up a 1.12 branch.

Closing for now. Feel free to reopen if this issue persists.

We upgraded ember to the latest and we now get:
vendor.js:30409 Assertion Failed: You modified "activeNotifications" twice on foo:header-block::ember761 in a single render. It was rendered in "component:section-header-block" and modified in "component:multiselect-checkboxes". This was unreliable and slow in Ember 1.x and is no longer supported. See https://github.com/emberjs/ember.js/issues/13948 for more details.
Error


ZEDx Xacro cam pose arguments error

Preliminary Checks

[X] This issue is not a duplicate. Before opening a new issue, please search existing issues.
[X] This issue is not a question, feature request, or anything other than a bug report directly related to this project.

Description
By adding the cam pose to the zedx.launch.py, it cause an error related with Xacro command.
Steps to Reproduce

Add the cam pose as a str (e.g. "0.1, 0.2, 0.3, 0, 0, 0" ) to the zedx.launch.py.
Launch zedx.launch.py

Expected Result
Launch the ZEDx camera launch file as it launch without any issue, if i do not add the cam_pose param.
Actual Result
File "/opt/ros/foxy/lib/python3.8/site-packages/launch/substitutions/command.py", line 116, in perform     raise SubstitutionFailure(f'executed command failed. Command: {command_str}') launch.substitutions.substitution_failure.SubstitutionFailure: executed command failed. Command: xacro /home/nvidia/ros2_ws/install/zed_wrapper/share/zed_wrapper/urdf/zed_descr.urdf.xacro camera_name:=zedx camera_model:=zedx base_frame:=base_link gnss_frame:= cam_pos_x:=0.1 cam_pos_y:= 0.2 cam_pos_z:= 0.3 cam_roll:= 0 cam_pitch:= 0 cam_yaw:= 0
ZED Camera model
ZED
Environment
Jetson AGX Orin 32GB
L4T: 35.2.1
Jetpack: 5.1
OS: Ubuntu 20.04
Release: 5.10.104-tegra
CUDA: 11.4.315
ROS2: Foxy
ROS foxy Xacro installed: ros-foxy-xacro 2.0.7-1

Anything else?
Otherwise if for example i consider only a cam_pose_x, it generates the xacro without any issue. The xacro version i have installed is  ros-foxy-xacro 2.0.7-1After debug by executing xacro command isolated, i notice the issue is once you pass as argument more then one cam_pose_*, it gives the error:
xacro /home/nvidia/ros2_ws/install/zed_wrapper/share/zed_wrapper/urdf/zed_descr.urdf.xacro camera_name:=zedx camera_model:=zedx base_frame:=base_link cam_pos_x:=0.1 cam_pos_y:= 0.2 Usage: xacro [options] <input> xacro: error: expected exactly one input file as argument

Hi @aaraujo11
the launch parameter cam_pos_x does not exist anymore starting from the version v4 of the Wrapper. You must set the pose of the camera as an array by using the cam_pose parameter: e.g. cam_pose:=[0.1,0.2,0.0,0.0,0.0,0.0]
You can get more information about the launch parameters by using the command
ros2 launch zed_wrapper zedx.launch.py -s
[...]
    'cam_pose':
        Pose of the camera with respect to the base frame (i.e. `base_link`): [x,y,z,r,p,y]. Note: Orientation in rad.)
        (default: '[0.0,0.0,0.0,0.0,0.0,0.0]')

Hello @Myzhar, solved thank you!


Document why we use _at and _by fields

What does this pull request do?
Document why we use _at and _by fields
What is the intent behind these changes?
To make sure this knowledge isn't completely lost (I'm sure I forgot lots of context already)

cc @tomsmyers


Closing this issue.


next/previous error

Can you please provide the command for next/prev error? I know you can build and get the errors,
but it's another step, and slow. Also you can open error list, however, click on the lines in error list do nothing.

Ok, I figured it out myself:
,{ "keys": [" ", "p"], "command": "typescript_go_to_error", "context": [{ "key": "setting.command_mode"}]}
The go_to_error is undocumented, and there is no command for it.
worth a PR.

ok, this typescript_go_to_error command only works when error list is open, and only in the error list panel. It would be better to be able to go to error in the source code view, without even open error list.

I think this would be very useful. VS Code has support for this.


FIX:Unexpected duplicate "display".

ISSUE-:#2896

@xonx4l thanks for this, three things!

i think you need to remove display: block above instead as @dimaMachina noted
can you add a changeset with patch as per the comment?
can you sign the CLA, and make sure your commit is signed with the same email you signed the CLA with?

@xonx4l thanks so much! good to go!


[stable/metallb] Add defining priorityClassName to pods

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
It's adding ability to define priorityClassName in pods of deployment metallb-controller and daemonset metallb-speaker in values.yaml.
Its is needs for  prioritize pods of metallb in relation to other non pods and avoid of evicting metallb pods
Which issue this PR fixes

fixes #20840

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

I'm not sure why I was assigned to review, but I am not qualified, as I've never used nor heard of this chart.

My blind feedback would be that the minor version needs a bump, instead of patch, as this adds a feature.

/ok-to-test

/assign @jlegrone

@davidkarlsen
@jlegrone
any updates?

=(

any chance to re-open this? We need this feature


Fail to make -j

Hi there, thanks for your work.
I'm meeting a problem with the make step for generating the executable files. Based on other issues, I'm using the Pangolin v0.6. When trying to compile the DeepSDF, the error is as follows:
(graph) a@b:/mnt/data/allusers/shuaibi/DeepSDF/build$ make -j
[ 14%] Built target cnpy
[ 28%] Built target cnpy-static
[ 42%] Built target example1
[ 50%] Linking CXX executable ../bin/PreprocessMesh
/usr/bin/ld: CMakeFiles/PreprocessMesh.dir/src/PreprocessMesh.cpp.o: undefined reference to symbol '_ZNK8pangolin12OpenGlMatrix7InverseEv'
//usr/local/lib/libpango_opengl.so: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
CMakeFiles/PreprocessMesh.dir/build.make:134: recipe for target '../bin/PreprocessMesh' failed
make[2]: *** [../bin/PreprocessMesh] Error 1
CMakeFiles/Makefile2:147: recipe for target 'CMakeFiles/PreprocessMesh.dir/all' failed
make[1]: *** [CMakeFiles/PreprocessMesh.dir/all] Error 2
Makefile:148: recipe for target 'all' failed
make: *** [all] Error 2.
The system is Ubuuntu 18.04, with GCC and G++ as 8.4.0. I tried to use v0.6, v0.7, v0.8 versions of Pangolin but they all didn't work.
If anyone with the similar setting that successfully compile this, please kindly tell me about your GCC and G++ version, and the Pangolin version that you used. Thanks a lot.

Solved! Thanks a lot

Solved with Pangolin-0.7, GCC, and G++ 8.4.0. Use cmake .. -DCMAKE_CXX_STANDARD=17 for compiling the DeepSDF

Solved! Thanks a lot


feat: Add /api/versions endpoint to worker that returns recent Deno versions

This is an idea for how we could do #138.
You have to have 'Accept: application/json' in your headers. Returns the 10 most recent versions like this:
[{"tag":"v0.29.0","url":"https://github.com/denoland/deno/releases/tag/v0.29.0"},{"tag":"v0.28.1","url":"https://github.com/denoland/deno/releases/tag/v0.28.1"},{"tag":"v0.28.0","url":"https://github.com/denoland/deno/releases/tag/v0.28.0"},{"tag":"v0.27.0","url":"https://github.com/denoland/deno/releases/tag/v0.27.0"},{"tag":"v0.26.0","url":"https://github.com/denoland/deno/releases/tag/v0.26.0"},{"tag":"v0.25.0","url":"https://github.com/denoland/deno/releases/tag/v0.25.0"},{"tag":"v0.24.0","url":"https://github.com/denoland/deno/releases/tag/v0.24.0"},{"tag":"v0.23.0","url":"https://github.com/denoland/deno/releases/tag/v0.23.0"},{"tag":"v0.22.0","url":"https://github.com/denoland/deno/releases/tag/v0.22.0"},{"tag":"v0.21.0","url":"https://github.com/denoland/deno/releases/tag/v0.21.0"}]

I don't know if there is rate limiting on the GitHub release feed - I don't think so.

fixes #138

I have added a latest version display to the website now:
 If the api fails to respond, a fallback message without the version is shown.
To test this locally, replace the REMOTE_URL in the worker with a netlify deploy preview URL (e.g.
https://5e3744598c2f9b00077fa57f--denoland.netlify.com/) and run wrangler preview.

@lucacasonato Thanks for this patch - I understand the need for it - but it's just too brittle and niche. It's not something I want to take on at this point. Sorry for the slow review. Closing without merge.


Remove reference to Fortran module references in .gitignore

For some reason we have references to Fortran module files in the README. This PR removes them as unneeded.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.08%. Comparing base (3ef699d) to head (29fa4be).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   75.08%   75.08%
=======================================
  Files          17       17
  Lines         602      602
  Branches       59       59
=======================================
  Hits          452      452
  Misses        150      150


Best practice question regarding the removal of old tables

NOTE: I'm not gonna get into the specifics of our DB since this applies at a higher level in terms of best practices for sqitch. I'll provide them if it becomes necessary.

So we're using sqitch, have been for a while and it's working great. I'm at a point where I need to DROP a few tables that are no longer in use. The deploy script for this is simple enough, but I was wondering what an appropriate revert script would be for such an operation? I couldn't think of a clear way to revert this without recreating the whole table from a backup of it, which is obviously highly impractical.
What's the suggested method here? Is there an entirely different approach I'm unaware of for dealing with this situation? Any help would be great.
If this is an inappropriate place for this discussion, please let me know and I'll move it elsewhere.

One way to do it would be to rename the old table, instead, and not drop it. You can always drop it manually later (or in a later deployment) once you're comfortable with it being dead for good.
I suggest posting to the mail list for a broader audience of possible opinions. :-)


Warn developers of Coming Deprecation of Universal Wallet API Keys

Blocked / on-hold until December announcement.


Singularity can eat containment and pull stuff through containment

Description
title
Screenshots
none my game crashed right after it happened (perhaps unrelated)
Additional context

Pretty sure this is fixed.


Updated generator test code to work with rails 5

Prior to adding generator support for mongoid, I fixed some broken tests when running with rails 5.
Tested also with rails 4.2 (found that <=4.1 isn't supported due to dependencies)
Also got rid of some deprecation warnings and changed some indenting -- not sure about conventions for this project yet=(
Let me know if anything should be changed

thanks @jrhee17 !


Extension appears above instead of below the navigation bar when the navigation controller pushes a view controller that hides the navigation bar.

The title says it all.

Here is a screen recording of the issue.
https://user-images.githubusercontent.com/17903236/103686010-d4465580-4f96-11eb-8ddf-3540d0ae4f42.MP4

Here is a screen recording of the issue.
https://user-images.githubusercontent.com/17903236/103686010-d4465580-4f96-11eb-8ddf-3540d0ae4f42.MP4

@OmerFlame thanks for reporting the issue. We will fix it as soon as possible

@OmerFlame thanks for reporting the issue. We will fix it as soon as possible

Should be fixed in 1.0.2

Should be fixed in 1.0.2


ESM errors when building.

What version of starlight are you using?
0.11.0
What version of astro are you using?
3.3.0
What package manager are you using?
yarn
What operating system are you using?
Mac
What browser are you using?
Chrome
Describe the Bug
When I try to build with astro build I get:
dist/_astro/MagnifingImage.astro_astro_type_script_index_0_lang.42c36336.js   0.12 kB │ gzip:  0.13 kB
dist/_astro/Tabs.astro_astro_type_script_index_0_lang.ea48f09d.js             0.99 kB │ gzip:  0.49 kB
dist/_astro/hoisted.dbfb2330.js                                               6.03 kB │ gzip:  2.43 kB
dist/_astro/ui-core.42dfa298.js                                              51.45 kB │ gzip: 16.83 kB
✓ built in 648ms
Completed in 664ms.

 generating static routes
 error   Named export 'execaSync' not found. The requested module 'execa' is a CommonJS module, which may not support all module.exports as named exports.
  CommonJS modules can always be imported via the default export, for example using:

  import pkg from 'execa';
  const { execaSync } = pkg;

file:///Volumes/Mattia%20SSD/web-development.nosync/monarchy-projects/astro-air/packages/documentation/dist/chunks/pages/404_2ceafa5d.mjs:8
import { execaSync } from 'execa';
         ^^^^^^^^^
SyntaxError: Named export 'execaSync' not found. The requested module 'execa' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'execa';
const { execaSync } = pkg;

    at ModuleJob._instantiate (node:internal/modules/esm/module_job:124:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:190:5)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

package.json:
{
  "name": "documentation",
  "type": "module",
  "version": "0.0.1",
  "scripts": {
    "dev": "astro dev",
    "start": "astro dev",
    "build": "astro build",
    "preview": "astro preview",
    "astro": "astro"
  },
  "dependencies": {
    "@astrojs/starlight": "^0.11.0",
    "astro": "^3.3.0",
    "sharp": "^0.32.6"
  },
  "devDependencies": {
    "typescript": "^5.2.2"
  }
}

tsconfig is standard.
I cannot give a repro repo right now.
It builds cleanly with bun. Yarn gives this issue, any clues?
Link to Minimal Reproducible Example
https://google.com
Participation

[ ] I am willing to submit a pull request for this issue.

This comment seems to contain a possible workaround for Starlight, would you be able to try it?

Thank you!!
The workaround works! I would keep the issue open though as it's still.. an issue imo

Agreed. From what I’ve seen it’s specific to Yarn, but I’m not sure why exactly. For some reason the module is being understood as CJS? But execa does not ship CJS and the package.json specifies "type": "module", so it’s a weird one. Is it possible another project dependency is pulling an old version of execa in and that one is being resolved or something? 🤔

One thing I could try is to see if upgrading to execa@8 helps at all. The only breaking change there was dropping Node 14 support and Astro doesn’t even support Node 16, so should be safe — https://github.com/sindresorhus/execa/releases/tag/v8.0.0
v8 also switched the exports style in execa’s package.json, so might help?

@ZeldOcarina Any chance you could provide a reproduction? I’ve tried a few things, but haven’t been able to trigger this error, which makes it more or less impossible to test or fix.

I've extracted the repo from the monorepo I was in and it builds without the workaround..
I really hope Bun becomes stable soon, these modules quirks are just a nightmare to work with..

Going to close this for now as we can’t do much without a reproduction unfortunately. Maybe we’re lucky and the execa update released in Starlight v0.11.1 was enough to fix this 🤞

I have the same issue here and just add execa as a dependency direct on the repo can solve the issue
{
    ...
    "dependencies": {
        "@astrojs/starlight": "^0.11.0",
        "execa": "^8.0.0",
        "astro": "^3.3.0",
        "sharp": "^0.32.6"
    },
    ...
}

Maybe an another version o execa in another repo of this monorepo could be causing this

@caiquecamargo Were you also using Yarn?

@caiquecamargo Were you also using Yarn?

Yes

Same thing with npm.  I have a CJS version of execa elsewhere in my monorepo; adding a newer version to the astro workspace fixes the issue.