math/big: Float.Sqrt does not set accuracy

What version of Go are you using (go version)?

$ go version go1.13.8 linux/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/root/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/root/app/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/root/app/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build510748991=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I was researching ieee 754, and when using go, I found that the big.Float.Sqrt function always output exact results. I calculate sqrt(pi) with go and cpp on one enviroment:
Go
package main

import (
	"log"
	"math/big"
)

func main() {
	pi := big.NewFloat(3.14159265)
	r := big.NewFloat(0).Sqrt(pi)
	log.Println(r, r.Acc())
}

Cpp
#include <iostream>
#include <cfenv>
#include <cmath>

#pragma STDC FENV_ACCESS ON

double pi = 3.14159265;

int main()
{
    std::feclearexcept(FE_ALL_EXCEPT);
    std::cout << "sqrt(pi) = " << sqrt(pi) << '\n';
    if(std::fetestexcept(FE_INEXACT)) {
        std::cout << "inexact result reported\n";
    } else {
        std::cout << "inexact result not reported\n";
    }
}

What did you expect to see?
golang: 1.7724538498928541 "InExact"
cpp     : sqrt(pi) = 1.77245, inexact result reported

What did you see instead?
golang: 1.7724538498928541 "Exact"
cpp     :  sqrt(pi) = 1.77245, inexact result reported

I don't think this is an accurate value, for sqrt(pi) = 1.7724538498928541 in go

Yeah Sqrt never sets the acc field. It's true that the Acc( ) doc says

Acc returns the accuracy of x produced by the most recent operation.

but I'm not sure it applies to Sqrt. In general, I'm not sure we can report accuracy correctly at a small cost. It might require to run another Newton iteration in the worst case, which is pretty expensive (like it could double the time).
cc @griesemer

(small note: the Go equivalent of cmath's sqrt( ) is math.Sqrt( ), the big.Float type you are using is for arbitrary precision math).

Another point, 0.1 + 0.2 = 0.3 is "Inexact" in go.
r := big.NewFloat(0).Add(big.NewFloat(0.1), big.NewFloat(0.2))
log.Println(r.Acc())
// "Above"

@mohanson that is correct. 0.1 and 0.2 and 0.3 are not exactly representable in IEEE-754.

I see four ways this could be addressed:

Do nothing.
Document that Sqrt doesn't set the accuracy (and thus its value is invalid).
Have Sqrt compute the square of the result in full precision and see if it is exactly the argument for Sqrt (in which case its result was accurate).
Perhaps it's possible to track accuracy through the Newton iteration and report it that way.

Solution 1) is not a good idea. 4) might not be very expensive but I don't know if it is feasible. This leaves us with 2) or 3).
We should start with 2) (easy), and then follow up with 3) if if turns out that the extra multiplication is an acceptable cost. Since we always care about speed, it probably isn't.
For an application that needs to know whether the Sqrt was exact, it's always possible to do 3) separately. If this turns out to be important (which I doubt), one could even have a IsSqrtExact function that takes the original value and the sqrt of it and computes the accuracy.

The original issue was fixed by updating the documentation.
Leaving this issue open as a reminder to investigate a better solution. No urgency. See also https://github.com/golang/go/issues/37915#issuecomment-601820538.


Fixes CityOfZion/neo-python#344 block synchronization being behind with one block

What current issue(s) does this address, or what feature is it adding?
CityOfZion/neo-python#344
Block height is always 1 block behind in synchronization
How did you solve this problem?
Found a - 1 in the HeaderHeight property that I believe should not be there.
How did you make sure your solution works?
Tested synchornization and block retrieval, compared to neo-cli implementation
Are there any special changes in the code that we should be aware of?
I don't think so

Thanks.
A small change, but might have bigger impact. Great that you checked conformity with neo-cli! @localhuman what's your thoughts on this?

It probably needs more extensive testing before merging. I'm going to do more testing and let you know my results.

I would not make this change this way, as this matches the current C# implementation of HeaderHeight.
https://github.com/neo-project/neo/blob/master/neo/Implementations/Blockchains/LevelDB/LevelDBBlockchain.cs#L34
There is probably a different solution to this issue 😉

Thanks! I agree that the proposed change is more a workaround than a fix. I couldn't find any other flaws in the synchronization logic. For now the change seems to work well.  I'll keep looking for a better way to fix the issue. - Thomas Lobker


Enable UnusedBlockArgument

Coverage decreased (-0.6%) to 97.193% when pulling 27cdb06bd83a7c2b2ae0c1d9188e8e37f18e76d6 on enable_UnusedBlockArgument into 1bd9a6b01ac79fcdf2577ab1365b224501e72c60 on 0.7.

Coverage decreased (-0.6%) to 97.193% when pulling 27cdb06bd83a7c2b2ae0c1d9188e8e37f18e76d6 on enable_UnusedBlockArgument into 1bd9a6b01ac79fcdf2577ab1365b224501e72c60 on 0.7.

🎉


[README] Add FAQ about how to make the package load with proprietary deps

I link to https://github.com/JuliaRegistries/RegistryCI.jl/issues/283 every other day, so I guess this earned the right to be a frequently asked question:

The text is maybe too verbose, please suggests improvements

Worth mentioning that it can be useful to have the package load for other purposes too. For example package A, with proprietary deps, might be installed as a dependency when I install package B. Perhaps will only use the parts of B that doesn't require A, and in such a case it is useful if using B doesn't error.

Good point, I added it, mentioning also CUDA.jl, so hopefully people understand how this is useful.  Thanks!


"bgsave backup" take too much time, is it right?

latest ardb 0.9.6, bits=64 engine=rocksdb
backup command : bgsave backup
backup cost alomst 50 minute
size of database is 20g

it's too slow for that data size.  is there any error info in the log?

don't find error in the log.
this db is a online db,  has read and write happen frequently.  whether because of this?


Added Gravity Drops(VanillaJS)

Closes: #750

Title : Gravity Drops
Name: :  Kosuri Indu
Idenitfy yourself: :  GSSOC'24

Describe the add-ons or changes you've made 📃
Added Gravity Drops
How Has This Been Tested? ⚙

I have tested it on my system.
Screenshots 📷

Type of change ☑

What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist: ☑

[x] My code follows the Contributing Guidelines & Code of Conduct of this project.
[x] This PR does not contain plagiarized content.
[x] I have performed a self-review of my own code.
[x] My changes generate no new warnings.

Note to reviewers 📄

@Avdhesh-Varshney
Please review and merge this PR :)
Thank you


Project layout update

We should keep sources in src, libs (maybe) in lib, binary output and build artifacts in build

Will be included in v3.0.0


Demo HTML page does not work

On page https://bl.ocks.org/spond clicking on "Hello World" example opens a page without any tree display, with console message ReferenceError: require is not defined from phyloTree.js line 1
Tried on Firefox ESR 52.7.3  and on  Chrome 66.0.3359.139 (Official Build) (64-bit)

Dear @david-chambliss,
Thanks for pointing this out! We recently introduced webpack into this project, which apparently broke some existing references to source code.
The example you mentioned should now work (you may need to do a hard refresh). Please let me know if you have any other issues.
Best,
Stephen


feat: a linter to flag potential confusing conventions

Currently, the linter flags all uses of

a - b where a b : Nat;
a / b where a b : Nat or a b : Int;
a / 0 more or less whenever the type of a has a 0 and a division.

This comes up often when starting to use Lean and hopefully the flag can help mitigate initial confusions.
A recent Zulip discussion

As of the Zulip discussion, I do think we should let users

know what they need to prove in order to ensure the inputs to the contentious function are not garbage
turn off the linter when they do prove it

@YaelDillies, I made the warning more verbose, so now it also mentions facts that may be useful.

a - b where a b : Nat;

ENNReal and NNReal and NNRat are also good candidates.

Thanks, Eric!  I added warnings to ENNReal, NNReal and NNRat and subtraction.
If we end up adding many more of these, I may make the warning no longer tailor made to the type.

As of the Zulip discussion, I do think we should

let users know what they need to prove in order to ensure the inputs to the contentious function are not garbage
turn off the linter when they do prove it

Thanks Damiano for implementing this! A concern I have is that the current error message doesn't explicitly say that proving the required hypothesis will silence the linter. Could it say something like "Make a proof of x ≤ y available in context to silence the linter"?


Fix secrets to push to Docker Hub

Nice fix. I find it pretty cool that now anyone in the GitHub waldronlab organization can create an image on hub.docker.com through GHA without even having an account there.


Possible bug on use.automaticKeepAlive

Stack trace:
══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY
╞═════════════════════════════════════════════════════════
The following assertion was thrown during performLayout():
setState() or markNeedsBuild() called during build.
This PostWidget widget cannot be marked as needing to build
because the framework is already in the
process of building widgets. A widget can be marked as
needing to be built during the build phase
only if one of its ancestors is currently building. This
exception is allowed because the framework
builds parent widgets before children, which means a dirty
descendant will always be built.
Otherwise, the framework might not visit this widget during
this build phase.
The widget on which setState() or markNeedsBuild() was called
was:
  PostWidget-[<'8eb9a794-0e3b-493d-8c1e-34d30ae254bf'>]
The widget which was currently being built when the offending
call was made was:
  SliverList

The relevant error-causing widget was:
  SliverList
  SliverList:file:///C:/Users/vicen/workspace/FLUTTER/LIBS/bu
  sslina-flutter-web-lib/lib/v2/widgets/screens/posts/posts.s
  creen.dart:90:26

When the exception was thrown, this was the stack:
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/err
ors.dart 296:3       throw_
packages/flutter/src/widgets/framework.dart 5047:9
<fn>
packages/flutter/src/widgets/framework.dart 5058:14
markNeedsBuild
packages/flutter_rearch/src/widgets/consumer.dart 151:5
rebuild
packages/rearch/src/side_effects.dart 71:12
setter
packages/flutter_rearch/src/side_effects/keep_alive.dart 34:7
<fn>
packages/flutter_rearch/src/widgets/consumer.dart 114:7
deactivate
packages/flutter/src/widgets/framework.dart 2095:12
_deactivateRecursively
packages/flutter/src/widgets/framework.dart 6755:7
visitChildren
packages/flutter/src/widgets/framework.dart 2097:12
_deactivateRecursively
packages/flutter/src/widgets/framework.dart 5539:7
visitChildren
packages/flutter/src/widgets/framework.dart 2097:12
_deactivateRecursively
packages/flutter/src/widgets/framework.dart 6755:7
visitChildren
packages/flutter/src/widgets/framework.dart 2097:12
_deactivateRecursively
packages/flutter/src/widgets/framework.dart 5539:7
visitChildren
packages/flutter/src/widgets/framework.dart 2097:12
_deactivateRecursively
packages/flutter/src/widgets/framework.dart 6755:7
visitChildren
packages/flutter/src/widgets/framework.dart 2097:12
_deactivateRecursively
packages/flutter/src/widgets/framework.dart 6755:7
visitChildren
packages/flutter/src/widgets/framework.dart 2097:12
_deactivateRecursively
packages/flutter/src/widgets/framework.dart 6755:7
visitChildren
packages/flutter/src/widgets/framework.dart 2097:12
_deactivateRecursively
packages/flutter/src/widgets/framework.dart 5539:7
visitChildren
packages/flutter/src/widgets/framework.dart 2097:12
_deactivateRecursively
packages/flutter/src/widgets/framework.dart 2109:7
add
packages/flutter/src/widgets/framework.dart 4382:5
deactivateChild
packages/flutter/src/widgets/framework.dart 3772:9
updateChild
packages/flutter/src/widgets/sliver.dart 860:37
updateChild
packages/flutter/src/widgets/sliver.dart 887:33
<fn>
packages/flutter/src/widgets/framework.dart 2845:11
buildScope
packages/flutter/src/widgets/sliver.dart 883:5
removeChild
packages/flutter/src/rendering/sliver_multi_box_adaptor.dart
376:7                [_destroyOrCacheChild]
packages/flutter/src/rendering/sliver_multi_box_adaptor.dart
571:9                <fn>
packages/flutter/src/rendering/object.dart 2688:51
<fn>
packages/flutter/src/rendering/object.dart 1097:7
[_enableMutationsToDirtySubtrees]
packages/flutter/src/rendering/object.dart 2688:7
invokeLayoutCallback
packages/flutter/src/rendering/sliver_multi_box_adaptor.dart
569:5                collectGarbage
packages/flutter/src/rendering/sliver_list.dart 299:5
performLayout
packages/flutter/src/rendering/object.dart 2577:7
layout
packages/flutter/src/rendering/viewport.dart 601:12
layoutChildSequence
packages/flutter/src/rendering/viewport.dart 1516:12
[_attemptLayout]
packages/flutter/src/rendering/viewport.dart 1427:20
performLayout
packages/flutter/src/rendering/object.dart 2416:7
[_layoutWithoutResize]
packages/flutter/src/rendering/object.dart 1051:17
flushLayout
packages/flutter/src/rendering/object.dart 1064:14
flushLayout
packages/flutter/src/rendering/binding.dart 577:5
drawFrame
packages/flutter/src/widgets/binding.dart 1138:13
drawFrame
packages/flutter/src/rendering/binding.dart 443:5
[_handlePersistentFrameCallback]
packages/flutter/src/scheduler/binding.dart 1392:7
[_invokeFrameCallback]
packages/flutter/src/scheduler/binding.dart 1313:9
handleDrawFrame
packages/flutter/src/scheduler/binding.dart 1171:5
[_handleDrawFrame]
lib/_engine/engine/platform_dispatcher.dart 1404:5
invoke
lib/_engine/engine/platform_dispatcher.dart 307:5
invokeOnDrawFrame
lib/_engine/engine/initialization.dart 187:36
<fn>
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/ope
rations.dart 426:37  _checkAndCall
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/ope
rations.dart 431:39  dcall

Parent widget:
return Column(
      mainAxisSize: MainAxisSize.min,
      mainAxisAlignment: MainAxisAlignment.center,
      children: [
        // Create post button
        if (debugInfo.postCreate || auth.isRoot)
          ElevatedButton(
            onPressed: () => context.beamToNamed(Routes.postsCreate),
            child: Label(
              lang.createNewPost.firstUpper,
              color: Colors.black,
            ),
          ),

        // Posts
        Expanded(
          child: CustomScrollView(
            controller: scrollController,
            scrollDirection: Axis.vertical,
            slivers: [
              SliverList.list(
                addAutomaticKeepAlives: false,
                children: posts
                    .map(
                      (post) => PostWidget(
                        post: post,
                        parentHeight: parentConstraints.maxHeight,
                      )
                          .withSizeConstraints(postConstraints)
                          .withMargin(
                            const EdgeInsets.symmetric(vertical: 30),
                          )
                          .centered(key: Key(post.id)),
                    )
                    .toList(),
              ),
            ],
          ).withRawScrollbar(controller: scrollController, active: true),
        ),

        // Posts loading indicator
        if (!postsDataState.loaded)
          const CircularProgressIndicator().marginBottom(20).centered(),

        // Load more button
        if (postsDataState.loaded &&
            !postsController.reachedLastPost() &&
            isScrollAtBottom.value)
          ElevatedButton(
            onPressed: () => postsController.load(),
            child: Label(
              lang.loadMore.firstUpper,
              color: Colors.black,
            ),
          ),
      ],
    ).sized(width: double.infinity);

Child widget (PostWidget):
@override
  Widget build(BuildContext context, WidgetHandle use) {
    use.automaticKeepAlive();

    return LayoutBuilder(
      builder: (context, constraints) => RearchBuilder(
        builder: (context, use) {
          final lang = use(languageCapsule);
          final state = use.data(_PostState.normal);

          return Stack(
            children: [
              // Default layer
              Column(
                mainAxisSize: MainAxisSize.min,
                children: [
                  // Title
                  _buildTitle(lang),

                  // Divider
                  const Divider(
                    height: 10,
                    thickness: 2,
                    color: Color.fromARGB(255, 117, 117, 117),
                  ),

                  // Body
                  buildBody(context, use, constraints, lang),
                ],
              ),

              // Actions layer
              if (state.value.normal)
                _ActionsLayer(
                  post: post,
                  postState: state,
                ),

              // Removing state layer
              if (!state.value.normal)
                Positioned.fill(
                  child: const CircularProgressIndicator().centered().bgColor(
                        Colors.grey.withOpacity(0.5),
                        active: false,
                      ),
                ),
            ],
          )
              .withPadding(
                const EdgeInsets.symmetric(
                  horizontal: 20,
                  vertical: 10,
                ),
              )
              .bgColor(
                const Color.fromARGB(255, 189, 171, 171),
              )
              .roundedCrownBorder(
                color: const Color.fromARGB(255, 117, 117, 117),
                radius: 15,
              );
        },
      ),
    );

So... I found this Flutter bug, and also I found a bypass solution to it. Now thus ReArch issue seems gone. But I found another related that seems to indicate that something is wrong with use.automaticKeepAlive. I'm opening another issue...

If this is triggered by a bug in the framework, then I'm going to close this in favor of the bug in the framework (as it's not a ReArch-specific issue).


Update Makefile

Thanks for making these pull requests... but why did you split the changes into 4 separate PRs?

Sorry I was on my mobile phone

Thanks for your contribution. @franz101 It seems puppeteer 5.2.1 changed the path again over 5.1

let me see if I can clean it up and create a proper merge request.


NivoLightbox and Infinite Scroll

Hi
I want to use the NivoLightbox with Paul Irish Infinite Scroll. After new content is loaded, the lightbox is not working on the new items.
It look like the lightbox does not know that there are new elements and should be initialized again. On this page (-> http://www.infinite-scroll.com/lightbox-compatibility-code/) I found some code for other lightboxes. What do I have to do for the NivoLightbox to work with the inifinite scroll plugin?
Thanks
Regards
Martin

I'm getting the same error when clicking on my student examples lightbox imagesbut its only not working on mobile device (works fine on desktop computers on all current browsers).  Web address is:  http://www.ailedgarcia.com/112/#studentwork       Any and all help is appreciated :)


SOV-2365: fix metamask connection errors

https://sovryn.atlassian.net/browse/SOV-2365

@creed-victor I tried on https://deploy-preview-48--sovryn-onboard.netlify.app/ If the user has a pending MM request and they refresh they would still see the error

@Rickk137, this is expected because metamask wants you to complete actions in the extension before proceeding. Issue this PR fixing was that error was showing up without user refreshing dapp when they are using app for the first time


Adds in-publish script which prevents running prepublish on npm insall

Your call - If you'd like to have npm install not run prepublish script.
More discussion here:
https://github.com/npm/npm/issues/3059
Note: The eslint step fails now.

Actually no!
You need to run babel to run on preinstall and prepublish.
Closing this.


[aws_cloudwatch] endtime is unused variable in struct

Also for key := range map_variable works just as well as for key, _ := range map_variable

Thanks :)


[FEATURE] Algebraic transformations in the preprocessor

There are a number of expressions that can be significantly simplified by using logical and algebraic equivalences.
Example 1:
x \in X \union Y

can be simplified to
x \in X /\ x \in Y

Example 2:
\E x \in a..b: P

can be simplified as
\E x \in Int: a <= x /\ x <= b /\ P

We are doing some of simplifications in the preprocessors already, but we should do that more systematically by introducing a rewriting framework. By doing so, we should eliminate a large class of issues, where our encoding is suboptimal.

By a rewriting framework I meant something like the worklist algorithm. The point is to avoid unnecessary recursive calls when subexpressions were not optimized. However, I am not sure about how to do that in Scala.

I'm not capturing the necessity of this type of algorithm here. My understanding is that we never need to re-simplify/optimize subexpressions of an expression we are rewriting, as long as we always rewrite using a bottom-up approach and never change the contents of a subexpression while rewriting. This is how ConstSimplifier is working: there is a single deep recursion and anything that changes halfway of the recursion is simplified before continuing to recurse and simplify its parent.
We could take a look at other rewrite implementations besides ConstSimplifier and check that they can work under this 2 assumptions and, if so, make sure that new nodes (created from a rewrite rule) are shallow simplified/optimized. This could be a first step towards unifying all rewrite implementations as suggested in https://github.com/informalsystems/apalache/issues/138

Right. We don't need any special framework to implement this kind of preprocessing. It would be great, if we could call different optimizers when one of the optimizers has changed a subexpression. A naive fixpoint approach applied to a whole expression over and over again would be really slow. I think we would need some form of recursion that applies different optimizations to subexpressions and once nothing new has been produced, it produces the result upwards to the parent.


wip: fix(docs): fix drivers installation anchors

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind event

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area community

What this PR does / why we need it:
Fixing some minor errors in documentation
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ekoops
Once this PR has been reviewed and has the lgtm label, please assign vjjmiras for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ekoops, Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 9a8a01ac92618ab6393a188bb6651ae3219fb19f

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ekoops
Once this PR has been reviewed and has the lgtm label, please ask for approval from issif. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ekoops, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 407dfa6893f76c45bbe671a69df0be3420d612a9


Enable SuppressWarnings annotation

Addresses https://github.com/gaul/modernizer-maven-plugin/issues/3
This PR allows users to suppress modernizer errors by adding @SuppressWarnings("modernizer") at class/method level.
@gaul
cc @jhaber @stevegutz

How can a user suppress modernizer warnings?
modernizer-annotation-processor should be added as a provided-scoped dependency in the project.
Any class or method can be annotated with @SuppressWarnings("modernizer") to suppress all modernizer errors
in that block of code.
Implementation strategy

The code base has been organized into 3 modules:

modernizer-maven-plugin has the main plugin code.
modernizer-maven-policy has checkstyle rules and is added as a dependency to maven-checkstyle-plugin
in the plugin's pom.
modernizer-annotation-processor has annotation processing code and is added as a dependency in plugin.

When a project is run, before compiling the source code in the project, annotation processor scans to see if there are any
methods/classes annotated as @SuppressWarnings("modernizer"). These annotations can be added to methods or classes.

If the annotation is on a class, the processor constructs a regex that matches the fully qualified class name of the
annotated class and its subclasses.
For example: org/gaul/package/ClassOne\$ClassTwo(\$.+)?
If the annotation is on a method, the processor constructs a string with 4 parts, delimited by spaces - the fully
qualified class name, the method name, the return type, and the list of parameters. These are normalized to be compared to the format
expected by ASM.
For example: org/gaul/package/ClassOne methodOne int[] java.util.List

The results of step 2 are dumped into 2 different files - ignore-annotated-classes.txt and
ignore-annotated-methods.txt. These files are created in the /target/modernizer/test and /target/modernizer/main
directories of the processing environment. Adding the files to these directories makes them accessible to the plugin while excluding them
from the jar of the project being built.
The plugin reads the files created in the previous steps and uses them to ignore violations in the places specified.

Testing strategy
ModernizerSuppressionsEndToEndTestClass has helper classes/methods annotated with @SuppressWarnings("modernizer").
The processor scans this class before compiling and creates the ignore files.
End-to-end flow tests are added in ModernizerSuppressionsEndToEndTest which read the ignore files and check if
violations in the code are as expected.
We have benchmarked the plugin after this implementation, and haven't seen any performance issues.
Further improvements

The format of ignore-methods file could be improved by making it more structured by using XML, JSON, or YAML.
@SuppressWarnings("modernizer") blocks all modernizer errors in that code block. Suppressing specific checks/errors can
be done by adding something like <id>ViolationIdentifier</id> to the violations file structure, which uniquely
identifies each violation. We can then use @SuppressWarnings("modernizer:ViolationIdentifier") to suppress errors
related to those particular checks in the code block.

This is a decent approach, though I wonder if it wouldn't be simpler to introduce another annotation with CLASS retention similar to @SuppressFBWarnings used by FindBugs / SpotBugs.
Please also note that the correct way to use an annotation processor is the recently added <annotationProcessorPaths> configuration for the maven-compiler-plugin (not as a project dependency).

This is a decent approach, though I wonder if it wouldn't be simpler to introduce another annotation with CLASS retention similar to @SuppressFBWarnings used by FindBugs / SpotBugs.

Could we explore this simpler approach?  Sorry that I have been tardy with reviewing but don't understand much about annotation processing.


Need clarification about Other Activity tracked in the report

In the Microsoft Teams user activity report, which other activities are included under Other Activity value?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 81440b2f-391b-5856-a216-15866f37082a
Version Independent ID: cdd15cd4-d4ed-c413-e2b9-ebf6dad8b33b
Content: Use activity reports for Microsoft Teams
Content Source: Teams/teams-activity-reports.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

Regarding Other Activity: Other activity is any action a user takes within the app, such as clicking, scrolling, or hovering inside the app. In our telemetry it's any event with EventInfo_BaseType: panelaction.
Hope that helps. Thank you.


Improvements adaptive script editor in console

Is your suggestion related to an experience ? Please describe.
Currently, as we add steps in the authentication sequence the adaptive script gets modified automatically.
However, If the auto-generated script is modified once (Let's say by adding a comment etc.), Thereafter it does not adjust with new steps or removal of steps.
It doesn't warn when there are missing executeStep() statements for steps added on a modified adaptive script.
For example, I might configure 3 steps but only have executeStep(1) and executeStep(2) in the script. The editor should warn me of the missing step.
This happens in the management console editor

Describe the improvement

Show warnings for missed executeStep() statements.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


TopAppBar subcomponents failing to import

All of the sub components in the example fail to load with the exception of TopAppBarFixedAdjust.  This is my first attempt at using this component, so I am just attempting to get the the example javascript initiation code on this page working.  I broke the import apart to see if i could pinpoint what was happening.
import React, { Component } from 'react';
import TopAppBar from '@material/react-top-app-bar';
import {TopAppBarFixedAdjust} from '@material/react-top-app-bar'
import {TopAppBarRow} from '@material/react-top-app-bar'
import {TopAppBarSection} from '@material/react-top-app-bar'
import {TopAppBarTitle} from '@material/react-top-app-bar'
import {TopAppBarIcon} from '@material/react-top-app-bar'
import MaterialIcon from '@material/react-material-icon'
import './App.css';
import<EMAIL_ADDRESS>import<EMAIL_ADDRESS>class App extends Component {
  render() {
    return (
    <div>
      <TopAppBar>
        <TopAppBarRow>
          <TopAppBarSection align='start'>
            <TopAppBarIcon navIcon tabIndex={0}>
              <MaterialIcon hasRipple icon='menu' onClick={() => console.log('click')}/>
            </TopAppBarIcon>
            <TopAppBarTitle>Miami, FL</TopAppBarTitle>
          </TopAppBarSection>
          <TopAppBarSection align='end' role='toolbar'>
            <TopAppBarIcon actionItem tabIndex={0}>
              <MaterialIcon
                aria-label="print page"
                hasRipple
                icon='print'
                onClick={() => console.log('print')}
              />
            </TopAppBarIcon>
          </TopAppBarSection>
        </TopAppBarRow>
      </TopAppBar>
      <TopAppBarFixedAdjust>
        My exciting content!
      </TopAppBarFixedAdjust>
    </div>

    );
  }
}

export default App;

Error:

Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.
 Did you install @material/react-material-icon?

yes, that is just one of the many errors... MaterialIcon works fine by itself, its the topappbar subcomponents.

the documentation is for a new version than what is available on npm.

@kagneta where are you now in trying to get this to work? Yes you are pointing to the newer version's docs that aren't yet released, so a lot of those components do not yet exist. Sorry for the confusion, but please look at https://github.com/material-components/material-components-web-react/tree/v0.10.0/packages/top-app-bar

@moog16 Thanks, I see now I am following new documentation with older code ... The main github page brings me to rc0.11.0 when i click on the top app bar component.
Thanks for the help.. this can be closed.

Ya the default working branch is rc0.11.0...we need that set for contributions. Otherwise it is confusing for documentation.

Please fix the documentation in npmjs to the right version

@alvaroarenas I've switched it back to master, as I suspect more people are looking at the docs than opening PRs. Is this what your request is?


[otbn] Provide Ibex-based test for secure boot RSA implementation

With #6132 we have a tailored RSA implementation for boot verification. Write a test similar to the RSA test we have currently that runs on Ibex and triggers the RSA routine on OTBN.

I think this has probably been superseded by top_earlgrey/data/chip_testplan.hjson. Closing.


How to open Drawer using a custom event / action within a screen

Version
react-native-router-flux v4
Expected behaviour
A way to open the drawer from within a scene
Actual behaviour
Only the navbar button opens the drawer
Steps to reproduce
This is my Router
<Scene key="root" titleStyle={{}} hideNavBar>
    <Scene key="auth">
        <Scene key="login" component={Login} title={ I18n.t('loginTitle') }/>
    </Scene>
    <Scene key="drawer" drawer contentComponent={SideMenu} initial drawerPosition="right" drawerWidth={200} drawerLabel="Hi">
        <Scene key="main">
            <Scene key="menu" component={Menu} title={ I18n.t('menuTitle') }/>
            <Scene key="orders" component={Orders} title={ I18n.t('ordersTitle') }/>
        </Scene>
    </Scene>
</Scene>

I need a custom button within the Menu scene to open the drawer.
I tried:
Actions.refresh({key: "drawer", open: true})

But that does not work since the new DrawerNavigatior does not have "open" as a config option. Docs say the way to open is:
this.props.navigation.navigate('DrawerOpen');

Not sure how to call that?

Try Actions.drawerOpen()

Just Add in root scene a prop drawer={true}

Can anyone tell me how to customize the drawer which is added in root scene
??

@Tanumay92
You can define your own component for the drawer
<Drawer key="app" contentComponent={DrawerContent} drawerWidth={300} >

Can you explain a Bit @sujayjaju

@Tanumay92 read the doc :

contentComponent
React.Component

Component used to render the content of the drawer (e.g. navigation items).

Worked also for me, good job :)

I'm currently facing this problem. Because I have 2 drawers, Actions.drawerOpen() will only open the root drawer.

I'm currently facing this problem. Because I have 2 drawers, Actions.drawerOpen() will only open the root drawer. I need to be able to open a specific drawer.

How did you solve this?


Add PAI env variables in init scripts

Add PAI env variables in init scripts.
This is a temporal solution, will refine later.

Coverage remained the same at 50.639% when pulling ffd84f4db340eddd0a52a80e04dc7bab598fd89f on xiongyf/k8s-env into 8eb5d8c9a105abbe85171d926159bf61bf161793 on feature/pure-k8s.


Allow disabling background dim on CupertinoPageRoute

Addresses issue #117654. The source of the problem was that the CupertinoTabView leverages CupertinoPageRoute, which assumes the widget either needs a modal dimming, or is a full screen dialog that doesn't dim, but has different built in route transitions. As CupertinoTabView is neither, this PR adds in the ability to just disable the color dimming from the barrier color.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Closing as this doesn't seem to be the right approach


checkpointing vs parsl.AUTO_LOGNAME

parsl.AUTO_LOG_NAME is resolved into a dynamically generated path before memoization happens. This means that an app invoked with parsl.AUTO_LOG_NAME will not be memoizable/checkpointable, as the arguments differ each time.
Maybe this resolution to a concrete path should be ignored by checkpointing: if an explicit stdout is specified, then it is reasonable to assume that the stdout/stderr really is an output; but if it is an automatic log name, it is debugging-style output and should not affect checkpointing.

PR #1568 allows stdout/stderr to be ignored for memoization purposes. I've been using this in production for a few weeks and it works ok. This issue can be closed if/when #1568 is merged.

@benclifford I just got burned by this. Since there is no conceivable situation where a user would want parsl.AUTO_LOGNAME to make an app un-memoizable, what do you think about us adding stdout and stderr to ignore_for_cache automatically if parsl.AUTO_LOGNAME is set? Otherwise this is probable to result in significant time wasted for people who haven't studied the docs closely to debug the unexpected behavior.

what do you think about us adding stdout and stderr to ignore_for_cache automatically if parsl.AUTO_LOGNAME is set?

@annawoodard i think that's probably ok, in the sense of "deal with my stdout sensibly for me" rather than specifically "generate a filename"


Improve DNS diagnosis instructions

Include information about discoveryd and how to confirm if the DNS docker resolver has been picked up by OSX.

good info, thanks!


Fixes #5, Added "inverse whitelist" feature

This commit adds a feature to turn the application list into a
blacklist where only matching applications have the device blacklist
applied.  The use of the word "blacklist" was specifically avoided in
order to not be confused with the device blacklist. This feature
includes the following changes:

HidHide driver - added two new ioctl's that set and get the inverse
whitelist flag. Changed whitelisted logic to apply the inverse state.
HidClient - added "Inverse application cloak" checkbox to change the
inverse whitelist state in the driver.
HidCLI - added inv-on, inv-off, and inv-state commands to control the
inverse whitelist state
FilterDriverProxy - changed to remove the client's path from the
whitelist if the inverse whitelist flag is on

Nice work, thank you very much!


fix: add PseudoPromise catch for use in ZodType.object validation

This PR fixes the async multi-error accumulation bug (#179) by adding a catch method to the PseudoPromise class and using it in while parsing object schemas.

WOW this is some great work. I started trying to fix #179 before I saw this PR and I arrived at the exact same solution. Wonderful! I've already merged this locally and made some some stylistic changes.
I left one comment regarding the someError short-circuiting logic. I'm switching back to a Promise.all approach that runs all the custom checks in parallel and getting rid of the short-circuit. Unless you had a compelling reason for doing it that way?

Nice, I'm glad we arrived at the same solutionI I replied to the code comment. I consider avoiding unnecessary async validations to be useful.  What do you think about offering serial custom validation checking as an opt-in?


feat: 🎸 copy paste to upload

Could you please fix the eslint errors?

Thanks for your contribution.


Record #7375 Elijah Hayes.doc cannot retrieve file

When trying to open the doc referenced in the title the following error is received by the user:

The file is active and not corrupted at AWS storage. Permissions appear to be ok.

The issue was caused by the name of the file being saved in AWS with the spaces URLEncoded.  The expected filename was 7375 Elijah Hayes.doc, but the saved filename was 7375%20Elijah%20Hayes.doc.

I'd like to test another file upload with you @joesmare, we can go over requirements to allow me to test during our weekly meeting.


Add a book and a read by Congyang Wang

book: Algorithms for Data Science
read: The Data Science Weekly Newsletter

This is an interesting addition - did you read this book? what did you find most valuable in it? what should it replace in the existing curriculum?


GEOMESA-596,GEOMESA-603 Ingest from lon/lat without lon/lat in SFT

Ingest from lon/lat fields from a csv/tsv to a geom in the SFT without requiring
the lon/lat fields to exist in the SFT
Throw exception when lon/lat fields don't exist and don't overwrite wkt geom

Looks good.

Committed as e3175bad1dfb864e25485ce39e6598924e53bcf4 on 1.5.


row series with missing values

hello,
i am dealing with row series and i have some series like
[100,98,70]
[null,null,50]
if i draw this values with row series, chart gets the '50' value in the second serie to index 0. and use these series like
[100,98,70]
[50,null,null]
and if i put double.NaN then returns 'NaN' is not a valid value for property 'To'
but if i draw this values with line series and put double,NaN for every null value. everything works fine.
how can i draw this values with row series.
I am using
Live-Charts version 	<IP_ADDRESS>
Windows 	Windows 10

Hello, this is a good question, double.NaN feature exists only for LineSeries.
Why?
I really don't know, this could be extended also to all the series, feel free to create a PR, but I think this is not a vital feature for the rest of the series, check out in the next snippet how I handle your case, I only explicitly give the point the X coordinate, so I can ignore where I don't need a point:
    <lvc:CartesianChart>
            <lvc:CartesianChart.Series>
                <lvc:ColumnSeries Values="{Binding V1}" SharesPosition="False" />
                <lvc:ColumnSeries Values="{Binding V2}" SharesPosition="False" />
            </lvc:CartesianChart.Series>
        </lvc:CartesianChart>

public class Vm
    {
        public Vm()
        {
            //case
            //[null,null,50]

            V1 = new ChartValues<ObservablePoint>
            {
                //no point when x = 0
                //no point when x = 1
                new ObservablePoint
                {
                    X = 2,
                    Y = 5
                }
            };

            //case
            //[50,null,null]
            V2 = new ChartValues<ObservablePoint>
            {
                new ObservablePoint
                {
                    X = 0,
                    Y = 3
                }
                //ignore x= 1 and x=2
            };
        }

        public ChartValues<ObservablePoint> V1 { get; set; }
        public ChartValues<ObservablePoint> V2 { get; set; }
    }

Let me know if this is enough for your case, then I can close the issue, thanks for the report and good question.

I am closing this for now, let me know if this was not enough.

I'm having the same issue at trying to set null (double.NaN) points into a ColumnSeries().
Winforms Code:
return new ColumnSeries()
{
    Title = _serie.Title,
    Values = _serie.Values,
    SharesPosition = false
};

this (i think) is the equivalent posted for WPF in this post. But it does not solve the problem i'm still having the "Additional information: 'NaN' is not a valid value for property 'To'." error. Is there any other solution to this? Or ColumnSeries is not able to handle NaN points? :(


Unable to Search correctly

Hi, I was trying to use your modules but i can't research successfully, but im able to create entry, so it's not a connection problem
here is my code
use DB::ORM::Quicky;

   my $orm = DB::ORM::Quicky.new(config => {default-col-id => 'id'});
   $orm.connect(
           driver  => 'mysql',
           options => %(
                   database => 'database',
                   user => 'user',
                  password => 'password'
          )
  );

  my $newpost = $orm.create('posts');
  $newpost.set({com => 'TestPost', img => 'TestImg'});
  $newpost.save;

my $search = $orm.search('posts', {img => 'TestImg'});
 my @users = $search;
 say $search;

and there is the output
Use of uninitialized value of type Str in string context.
Methods .^name, .perl, .gist, or .say can be used to stringify it to something meaningful.
  in block  at /Users/mudada/.rakudobrew/moar-nom/install/share/perl6/site/sources/4C58C9F30DEC7EA3A4CDA0176B103CCCFFD9B443 (DB::ORM::Quicky::Model) line 315
DBDish::mysql: Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '"posts" WHERE "img" = ?  ORDER BY "id" asc' at line 1 (1)
  in method handle-errors at /Users/mudada/.rakudobrew/moar-nom/install/share/perl6/site/sources/34CFFE95AC96F456CAC15D5929C71AC7BE6FC6CC (DBDish::mysql::Connection) line 15
  in method prepare at /Users/mudada/.rakudobrew/moar-nom/install/share/perl6/site/sources/34CFFE95AC96F456CAC15D5929C71AC7BE6FC6CC (DBDish::mysql::Connection) line 22
  in method search at /Users/mudada/.rakudobrew/moar-nom/install/share/perl6/site/sources/FFE18E123D0571E65A36455345C9459CADADC765 (DB::ORM::Quicky::Search) line 91
  in method count at /Users/mudada/.rakudobrew/moar-nom/install/share/perl6/site/sources/FFE18E123D0571E65A36455345C9459CADADC765 (DB::ORM::Quicky::Search) line 56
  in block <unit> at post.pm6 line 21

my database is a really simple one who look like that
Posts

id
com (varchar)
img (varchar)

1
"TestCom"
"TestImg"

Even if it drag an error the creation is still working.
Did i miss something?

@Mudada  it's likely that your MySQL config doesn't like the " as the quoting mechanism.  Try changing line 4 of your code to: my $orm = DB::ORM::Quicky.new(quote => '', config => {default-col-id => 'id'});

Thanks, that did the trick !
the
Methods .^name, .perl, .gist, or .say can be used to stringify it to something meaningful.
 in block  at /Users/mudada/.rakudobrew/moar-nom/install/share/perl6/site/sources/4C58C9F30DEC7EA3A4CDA0176B103CCCFFD9B443 (DB::ORM::Quicky::Model) line 315```

is still there tho, even if it's not important


Autocomplete breaks in tests run with jsdom and vitest

Description
This issue may better exist on primer/behaviors  (or even upstreamed to jsdom if we can repro simply enough)
Initially reported in slack by @itsbagpack
https://github.slack.com/archives/C01L618AEP9/p1666186967969609
:wave::skin-tone-2: hi friends, i’m running into some testing issues around using the Autocomplete component and i was wondering what we were missing
for context, here’s the PR we’re working with: https://github.com/github/delorean/pull/127
TypeError: Failed to execute 'addEventListener' on 'EventTarget': parameter 3 dictionary has member 'signal' that is not of type 'AbortSignal'.
❯ exports.convert node_modules/jsdom/lib/jsdom/living/generated/AddEventListenerOptions.js:53:11
❯ HTMLDivElement.addEventListener node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:139:46
❯ Module.focusZone node_modules/@primer/behaviors/dist/esm/focus-zone.js:248:15
   246|     });
   247|     let elementIndexFocusedByClick = undefined;
   248|     container.addEventListener('mousedown', event => {
      |               ^
   249|         if (event.target instanceof HTMLElement && event.target !== document.activeElement) {
   250|             elementIndexFocusedByClick = focusableElements.indexOf(event.target);
❯ node_modules/@primer/react/lib-esm/hooks/useFocusZone.js:21:34

It appears that jsdom is throwing when trying to add an event listener, and appears that's due to the primer/behaviors focusZone attempting to pass a signal, which appears to conflict with the accepted signal jsdom expects. I added
Primer/react uses JSDOM (with jsdom) to test this component, which is confusing to me, given there's no indication that it currently has issues here
This leads me to think either
a version of JSDOM begins breaking
vite and jest somehow differ in the globals they send to jsdom in this scenario
I suggested a workaround, temporarily, mocking focusZone entirely -
vi.mock("@primer/behaviors", async () => {
 const behaviors = await vi.importActual<typeof import("@primer/behaviors")>(
   "@primer/behaviors",
 )

 return {
   ...behaviors,
   focusZone: vi.fn(),
 }
})

but this changes behavior of the autocomplete, and is not ideal
Steps to reproduce
start a project with vite/vitest
render an AutoComplete in a test using the jsdom environment
see jsdom throw
Version
All related versions of multiple packages
It's unclear to me whether this problem already exists and is becoming clear due to versioning  of react and testing-libary, is due to something with how vite interops globals compared to jest, or if this is jest/jsdom.
"dependencies": {
    "@primer/octicons-react": "^17.7.0",
    "@primer/react": "^35.11.0-rc.65a8bb8a",
    "react": "^18.2.0",
    "react-dom": "^18.2.0",
    "styled-components": "^5.3.5"
  },
  "devDependencies": {
    "@testing-library/jest-dom": "^5.16.5",
    "@testing-library/react": "^13.4.0",
    "@testing-library/user-event": "^14.4.3",
    "@types/react": "^18.0.17",
    "@types/react-dom": "^18.0.6",
    "@vitejs/plugin-react": "^2.0.1",
    "typescript": "^4.6.4",
    "vite": "^3.0.7",
    "vitest": "^0.23.4"
  }

Browser
No response

This is likely due to using an old version of jsdom<EMAIL_ADDRESS>is the first version of the lib to add support for signal in addeventlistener. Looks like the monolith and Delorean now use a version > 20, so I'll close this.
If in doubt, in future, please update to the latest version of jsdom as it'll likely fix issues like this.

This is likely due to using an old version of jsdom<EMAIL_ADDRESS>is the first version of the lib to add support for signal in addeventlistener. Looks like the monolith and Delorean now use a version > 20, so I'll close this.
If in doubt, in future, please update to the latest version of jsdom as it'll likely fix issues like this.

makese sense.  IIRC that wasn't an option at the time we opened this


Release the latest main branch that includes custom url change

Hello! First of all, thank you for your amazing SDK. I'm really excited to use it. But, I ended up debugging and found that it works only for Baserow cloud (via installing it from npmjs though). I found that the latest main code already includes this PR but the npmjs still recognizes v.0.1.0 as latest release. Can you help release main branch again so that it includes the custom url changes? My workaround is to install the package directly from the Github repo. But it would be more convenient to have it on npmjs!

Thanks for your request. I just release version 0.3.0 with this changes. Thanks for your support.


[Flaky Test] test_operator_gpu.test_ftrl

Description
test_ftrl() is located in https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_optimizer.py#L671
Occurrences

http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/PR-18001/2/pipeline/429
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/PR-18001/2/pipeline/418
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/PR-17779/17/pipeline
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/PR-17531/28/pipeline

@mxnet-label-bot add [gpu, optimizer]

Also seen in #17995.

Hmm, something is wrong with the random seed generation of tests - all those failing test_ftrl got the same seed:
common: INFO: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=386103813 to reproduce.

FYI @roywei Since you are already looking at random-related stuff and @DickJC123 since you wrote the @with_seed facility.

@szha plans to switch the testing suite to pytest
This involves refactoring the randomness logic and may fix the issue. The new code would likely be inspired by the code in GluonNLP, where we transitioned to pytest already in the initial release and thus refactored the random-related stuff for pytest.
https://github.com/dmlc/gluon-nlp/blob/v0.9.x/conftest.py#L41

Occurred again in http://jenkins.mxnet-ci.amazon-ml.com/blue/rest/organizations/jenkins/pipelines/mxnet-validation/pipelines/unix-cpu/branches/PR-18146/runs/2/nodes/365/steps/784/log/?start=0

With the new random infrastructure, the test failure can be reproduced deterministically:
MXNET_TEST_SEED=1632189249 pytest tests/python/unittest/test_optimizer.py  -k test_ftrl


HOC issuse

Hi
I clone https://github.com/xuanye/typescript-redux-sample/tree/master/src/TypescriptRedux/TypescriptRedux.WebHost/source/sample06. webpack build is ok
but i GOT error with atom-typescript. Any ideas?
JSX element attributes type 'ProviderProps & { children?: ReactElement | string | number | {} | (ReactElement | stri...' must be an object type.at line 25 col 6

Hi FYI. my issue seems like this https://github.com/Microsoft/TypeScript/issues/4362.

I've updated 8.11 fixed. Thank you.


Access Control on Devtron UI

The users who do not have Production Access are able to view the production pipeline, edit the branches in them and are able to abort an ongoing build process.

User can view production pipeline but should be authorised before editing branch, abort ongoing build for applications which have CD pipelines

The user has admin access to other namespaces except production , but is still able to update the branch on production. if someone from devtron team wants , we can get on a call and show it.


Assertion failed: cannot dereference end string_view iterator in rfc7230.ipp with MSVC std::string_view

Assertion failed: cannot dereference end string_view iterator
when compiling with BOOST_BEAST_USE_STD_STRING_VIEW in Debug mode
The "culprit" is in rfc7230.ipp lines 363,364:
v_.second = param_list{string_view{&*it_,
static_caststd::size_t(pi.it - it_)}};
when checking "permessage_deflate\r\n".
I know this is just because of iterator debug helpers being enabled in debug mode. So it's not critical.
Version of Beast 189 (Boost 1.69.0 release)
Steps necessary to reproduce the problem
Compile CppCon2018 example with BOOST_BEAST_USE_STD_STRING_VIEW and run
connect to Websocket
All relevant compiler information
MSVC v141 cl 19.16.27026.1 x64
VS 2017 15.9.6 /std::c++17

Appveyor build should be setting BOOST_BEAST_USE_STD_STRING_VIEW to catch this sort of thing, although the examples aren't really tested they are only compiled.

Do you have a fix?

I'm not sure if it handles all cases correctly:
if(!pi.empty())
v_.second = param_list{string_view{&*it_,
static_caststd::size_t(pi.it - it_)}};
It's also a bit inelegant, because it checks pi.empty() again, which is already checked the line before.

Hm... it_ is the end-iterator of the extension list string, only if the extension is parameterless.
"chunked;a=b;i=j,gzip;windowBits=12" is okay, but
"chunked;a=b;i=j,gzip;windowBits=12;permessage-deflate" isn't
so also: it_ = pi.it = pi.first = pi.last = last_
so, it's probably better to test after lines 351,352:
v_.first = string_view{&*p0,
static_caststd::size_t(it_ - p0)};
if (it_ == last_) return;
and skip the whole detail::param_iter pi;

Any chance I can talk you into submitting a pull request with a test, and the fix?
https://github.com/boostorg/beast/blob/develop/test/beast/http/rfc7230.cpp#L344
No idea why those tests are commented out...might look into that too...

seem that you can ;-)

Thank you for your great work on Beast, it's highly appreciated!

Release and Debug behave different?

Yes, that's why I don't deem it critical. Without iterator debug helper assertions, everything worked fine. But it was annoying. It's also hard to turn those elemental checks off, in a way that only affects beast includes. Because without intermediate precompiled headers the define influences all includes first seen through beast...

Oh, I see that you mean the pull request comment(?)
The lower part was auto constructed from my local commits. It wasn't those two tests, but my own new tests that failed. I just mistook the #number from the output at first.
But yes, previously them and some others produced errors in debug but not in release.


Please provide builds for the usual Linux distributions (Ubuntu, EL7, EL8, Debian)

This would solve the libicu issues that have been reported in a couple of places :
https://github.com/ClickHouse/clickhouse-odbc/issues/384
https://github.com/ClickHouse/clickhouse-odbc/issues/358

@dima-altinity
Dependency on packaged libraries is nonsense; it should build all dependencies from the sources and link them statically. See how ClickHouse itself does it. The build with OS dependencies should not exist at all.

Fell down this rabbit hole for a few hours as well, please fix this issue, it was kinda of hard to figure out


services.down() fails if container_name is set in the dockerfile

If the dockerfile defines the container name,  then the calling services.down() fails as the down method looks for a container named with the following pattern:
projectName + '_' + serviceName + '_1'

In such case, the down method() should use the container_name defined in the dockerfile instead of its own naming format.

Indeed, the dreaded message `'Conflict. The container name "/" is already in use by container "". You have to remove (or rename) that container to be able to reuse that name.'
One workaround, as based on the current implementation of down would be:
const projectContainers = await docker.listContainers({
  all: true,
  filters: { label: [`com.docker.compose.service=${serviceName}`] },
});

for await (const projectContainer of projectContainers) {
  const container = await docker.getContainer(projectContainer.Id);

  if (projectContainer.State === 'running') {
    console.log('Stopped running container', projectContainer);
    await container.stop();
  }

  await container.remove();
}

Whereas serviceName is the name used under your docker-compose's services list/array.
One can also add one's own labels.

There hasn't been any progress on this issue and thankfully this was mentioned in here, because the error is "eaten" and I was confused why down is not working.
Am I missing something or is it really just taking the "container_name" property (or use default if it doesn't exist).
I'm willing to write a PR, just want to be sure I'm not missing something.
I also noticed there is an empty array services = [] which does nothing.
I would propose that this error will return successfull / unsucessfull downs, so a developer can react to this properly without being kept in the dark.

I'm having a similar issue. compose.down() is not killing the containers
And also, compose.up() does not do what docker compose up -d command does, that is to replace current running containers with new version in case something in the config changed


[WIP] Remove our special duckdb installing

We've updated the way that duckdb gets used so that it is only needed to (re)create tpc-h data, and thus should be able to be installed only when that happens.

Created a test run: https://buildkite.com/apache-arrow/arrow-bci-benchmark-build-test/builds/72

Ok, looking at that build, there are two failures:

(1) tpc-h seems to be failing on validation (though this might be due to rounding | floating point precision?). I tried this out locally and could not reproduce (and the code I've altered in arrowbench has been running successfully for a while now on the actual benchmarks) So I think this is fine
(2) it looks like generating scale factor 10 data also failed — this isn't totally surprising if the machine running this test doesn't have a huge amount of memory. Maybe we should disable that test for this test build?
(3) micro c++ benchmarks failed — I'm not totally sure why, nothing I changed should impact them.

I suspect these issues are all from the test harness and not the change to the code — but would love a second opinion on that @ElenaHenderson

@jonkeane I am pretty confident that builds failures are not caused by the changes in this PR.
I created https://github.com/ursacomputing/arrow-benchmarks-ci/issues/74 to fix environment used for running arrow-bci-benchmark-build-test builds.


Slime Blocks

When you jump on a slime block you will occasionaly sink into it. When you do you will be locked to a 1x1 area and cannot leave even in creative. Upon reloading the world terrain does not generate.

Are you using the latest version? I remember fixing that issue

Using version 1.4.3

On my bad, the fix isn't in that version XD
I'll get an update out later today :3

Awesome. Thanks much :)


Use webrtc rev 13046

Updates WebRTC to rev 13046 by putting the binary lib files(no update from the repo), which fixes crash on media stream removed event.

Upstream updated the Android binary of WebRTC to r13317 and I merged us with upstream so this PR is no longer necessary.


could Soso fit on a floppy?

Even today the floppies are still being used, for example - as virtual floppies inside the coreboot open source BIOS. Just imagine: your wonderful OS could be a part of someone's BIOS build! (for coreboot supported motherboard, maybe you have or could get one - see https://www.coreboot.org/Supported_Motherboards )
@ozkl , If you already have a coreboot-supported motherboard, or a real chance to get one, - wouldn't it be cool to be able to launch your own OS straight from the BIOS chip? ;) With one simple command its possible to add any floppy to coreboot BIOS build - and then you see it as a boot entry! Multiple floppies could be added this way (as long as you have enough space left inside the BIOS flash chip, luckily LZMA compression could be used for the stored floppies to reduce their occupied size)

Soso would not fit on a floppy disk as it is not intended. Its initial ramdisk and kernel are bigger than a loppy disk.

@ozkl Even bigger than a 2.88MB floppy? (these double sized floppies are also supported by coreboot)


Multiple TS2564 (Property has no initializer) errors

A lot of "Property '' has no initializer and is not definitely assigned in the constructor." when running the build command.
This is a new issue coming along with the latest TypeScript version (2.7), more can be read here:
https://blogs.msdn.microsoft.com/typescript/2018/01/31/announcing-typescript-2-7/#stricter-class-property-checks
I'd make a pull request to fix but I don't know if you want to deactivate this check or manually assign all variables that have this error, if it is the latter, still don't know how you'd want to initialize most of them.

Thanks for bringing this up, will look into it!

I can try to infer the default values by analyzing how they are used when first defined and define them at the constructor.
It will also help me understand the codebase for future contributions

Thanks, any help is appreciated! I plan to look into this in the next couple of days, but one of my other priorities is adding full Floating-Point support.

@MikaelMello Just started a new branch floating-point to start adding FP support on. While working, I noticed what you mean about the new TypeScript initializer errors. Those fixes would definitely require a bit of context about the code-base. I will definitely get to them, so don't feel pressured. Thanks!


GRANT statements are not deparsed

irb(main):003:0> PgQuery.parse('GRANT SELECT ON "table" TO "user"').deparse
RuntimeError: Can't deparse: GrantStmt: {"is_grant"=>true, "targtype"=>0, "objtype"=>1, "objects"=>[{"RangeVar"=>{"relname"=>"table", "inh"=>true, "relpersistence"=>"p", "location"=>16}}], "privileges"=>[{"AccessPriv"=>{"priv_name"=>"select"}}], "grantees"=>[{"RoleSpec"=>{"roletype"=>0, "rolename"=>"user", "location"=>27}}], "behavior"=>0}

(Yes, I'll fix it as soon as I have the time available ;) )

Fixed by https://github.com/lfittl/pg_query/pull/115


If using request for proxy fwd, need to add req/res dispatch events

Not using request. See similar issue #22


Added rules in PR template checklist

Changes
Added rules in PR template checklist
Checklist

[x] I have read the contributing guidelines.
[x] I have manually tested the proposed changes.
[x] I have written new test cases to avoid regressions. (if necessary)
[x] I have updated the documentation. (e.g. README.rst)
[x] I have added [change!] to commit title to indicate a backward incompatible change. (if required)
[x] I have checked the links added / modified in the documentation.

Coverage remained the same at 99.295% when pulling 12d140bc168c244758c0f165358aa44f6d6cda9c on commit-checklist into 6b5c365fafaa47a0e69a66768bbd1f5c6578bced on master.


Implement cross-level twins

Fixes #157.
Please review very thoroughly. This is a fragile part of the library, and it is nearly impossible to write automatic tests for it. Just throw it onto a large grammY code base and check that everything still compiles. I tried out a bunch of toy examples for testing purposes, but it would be nice to have an independent confirmation that this works.

One approval in https://t.me/grammyjs/34660, would like to see at least one more

Additionally needs to be applied to ctx.update.

Thank you for your work! That's perfectly the kind of testing I was hoping for. I'll merge this soon and publish a patch release.


update to be dependent on Net 6.0

You library is very helpful! Thank you so much! Do you guys plan to update the Target Framework to be Net 6.0 instead of Net 5.0 ?

Hi @btayakin, I'm glad you enjoy it!
The library has several targets including .NET 5, but you can use it in .NET 6 applications.
If I add .NET6-specfic code I'll update the targets, but even without this you can use it as it is in .NET 6, .NET 7, .NET 8, etc. without this package having to be recompiled and redeployed for those versions.
I hope that explanation makes sense! 🚀


Optimization of lab submission retrieval

To speed up loading of the page with lab results, multiple server requests (currently - one request for every student) will be batched into a single server call.

Coverage decreased (-0.2%) to 46.767% when pulling bbd6598ffa358c388fab666628679de510fff2dc on labresult_page_optimization into 8984ab3097679f09d9647ab4517fa4807da76d13 on master.


Verify that "Cioara de Sus" is listed in the dropdown menu when searched

Description:
"Cioara de Sus" should appear in the dropdown menu with correct spelling and locality information.
Preconditions:
The website is up and running.

Step 2
Observe the dropdown menu.
Expected results:
"Cioara de Sus" is displayed and selectable from the dropdown menu.


PR: Update the running Github clone procedure in the readme and contributing guide to include spyder-kernels

Pull Request Checklist

[x] Read and followed this repo's Contributing Guidelines
[x] Based your PR on the latest version of the correct branch (master or 3.x)
[x] Followed PEP8 for code style
[x] Ensured your pull request hasn't eliminated unrelated blank lines/spaces,
modified the spyder/defaults directory, or added new icons/assets
[x] Wrote at least one-line docstrings for any new functions
[x] Added at least one unit test covering the changes, if at all possible
[x] Described your changes and the motivation for them below
[x] Noted what issue(s) this pull request resolves, creating one if needed
[x] Included a screenshot, if this PR makes any visible changes to the UI

Description of Changes

Following the separation of the spyder-kernels module in 3.3.0, running Spyder from a github clone needs to have the correct version of spyder-kernels installed. Therefore, this PR ensures that is made clear in the readme and contributing guide, the counterpart of spyder-ide/spyder-docs#69
Issue(s) Resolved

Fixes #7337

We can't merge this one until there are official conda packages for spyder-kernels. I was told that that will happen next week.

Okay, thanks @ccordoba12 . I wasn't sure what the situation was on that since I didn't see any currently. I'm addressing your other feedback as we speak.

@ccordoba12 Implemented your feedback, thanks!

@ccordoba12 Removed the double backticks a few dozen places in both the Readme and Contributing guide, per your request.

@ccordoba12 Sorry, I didn't notice my push failed before so it was still the version with the double backticks. Should be updated now.


[lab] Fix AdapterDateFns export

Fixes #31915

[x] I have followed (at least) the PR section of the contributing guide.

Why do you need an export of AdapterDateFns from the root ?
You should be able to import it from the sub-package as described here
import DateAdapter from '@mui/lab/AdapterDateFns';

If we export it from the root, projects that uses our date pickers with another date library (moment for instance) will have to import date-fns, which is not something we want.

I am sorry, I saw #31915 and made the PR. I should have asked a moderator first


Fix inconsistent button height bug

.btn--outline is 2px higher than any other button.
Before:

After:

Epic change  :+1:


Decryption Help

Hi team,
Great addon. thanks!
I'm just trying to understand how to decrypt the data on reading.
I have been suing your html example and can see the data is encrypted
Thanks

Hi there,
You should not have to encrypt / decrypt data yourself. It saves data encrypted in the Dexie database and encrypt it on reading. I've made a test example and it seems to work fine:
StackBlitz expamle
If its not working for you please provide an example or fork and edit the StackBlitz to your setup.
I did notice an error in the HTML example concerning the namespace of the Encrypted class. This will be corrected.
Fixed with commit 620651a8e4ebb542d2ccbd6c230372936063037e

Thank you for such a speedy response.
I will try your example and let you know.

@PVermeer
I know where I went wrong by using your example.
Thank you once again.


Azure.Cosmos sdk4 - GetItemLinqQueryable?

When will GetItemLinqQueryable (or equivalent LINQ based query) be available in sdk4?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7cf376a4-4551-ef9d-f7dc-da6e8850398c
Version Independent ID: e5023416-823e-62bc-2c32-d6e829eead18
Content: Manage Azure Cosmos DB SQL API resources using .Net V4 SDK
Content Source: articles/cosmos-db/create-sql-api-dotnet-v4.md
Service: cosmos-db
Sub-service: cosmosdb-sql
GitHub Login: @ealsur
Microsoft Alias: maquaran

@efreeman518, thank you for reaching out. We are looking into this and would get back to you soon on this thread.

V4 preview is using AsyncEnumerable and asyn iterators. This is in sync with the Azure Core SDKs. Linq provider is not async and thus not included at this point until we have a clear guideline from the Azure Core SDK https://github.com/Azure/azure-sdk-for-net/blob/master/README.md

@efreeman518 We will proceed to close this issue now.
If there are further questions regarding this matter, please comment and we will gladly continue the discussion.

Where can I review proposals/plans for async Linq, if they exist? Can we utilize Rx?

@lightw8 Any questions should be done to the Azure Core SDK: https://github.com/Azure/azure-sdk-for-net/

I don't understand whats wrong with the approach in v3 where you would formulate your linq query and pass it to the GetItemQueryIterator method with queryable.ToQueryDefinition().QueryText;
I just don't want to write SQL and it seems like such a non issue to do

EF Core and System.Linq.Async have no issue with combining iqueryable with async. Why do you @ealsur ?

@onionhammer I don't have any issues, what I'm saying is that the API surface of the V4 SDK (which is currently a preview experimental SDK) is governed by the Azure Core SDK guidelines, which currently have no guidelines for Linq support, and that is the reason V4 SDK has no Linq. You can use Linq on V3 SDK which is the current SDK for production.

@ealsur Then perhaps the linq-to-cosmos query translation should be broken into a separate package?

That could be a possibility based on the review of the Azure Core SDK board, yes. V4 is still a long ways off, when we get closer we'll review the options we are provided. In the meantime, please use V3 SDK for any production apps.


Beyond Amass: Features that move past enumeration

This is a feature that might not fit Amass, but is more about what to do with the data:

Take snapshot of the homepage of each subdomain, present it with visjs in a report.
Scan the subdomains on common ports, (perhaps have smart filters for known ports on known subdomain names e.g. ftp.example.com, mail.example.com etc..).
Enumerate the technologies running on an FQDN (language/framework/CMS/etc..).
Run google dorks agains an FQDN or whole domain and identify potential issues on the site(s).
Createing an original feed, this maybe a project in and of itself, but a feed within Amass's control would significantly speed up the enumeration process.

This issue has been moved to the official OWASP Amass repository.


Go plugin: init.lua:255 [go-auth] /usr/local/share/lua/5.1/kong/db/dao/plugins/go.lua:439: no data, client

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
Kong 2.2.2
Current Behavior
I use go plugin write some plugin. It can work, but work after few month, It can`t work
kong version:  2.2.2
go plugin server: v0.5.1
go version: 1.14
it is request response
HTTP/1.1 500 Internal Server Error
Date: Mon, 09 May 2022 08:54:47 GMT
Content-Type: application/json; charset=utf-8
Connection: keep-alive
Content-Length: 42
vary: Origin
Access-Control-Allow-Origin: *
Access-Control-Expose-Headers: Origin,Authorization
X-Kong-Response-Latency: 79413
Server: kong/2.2.2

{"message":"An unexpected error occurred"}

I find server log
init.lua:255 [go-auth] /usr/local/share/lua/5.1/kong/db/dao/plugins/go.lua:439: no data, client

I try to reload the openrest
kill -HUP 1

it can work again
Expected Behavior
No response
Steps To Reproduce
No response
Anything else?
No response

Go plugin server is deprecated and we recommend migrating. Please refer to: https://docs.konghq.com/gateway/latest/reference/external-plugins/#legacy-configuration


chore(deps): update terraform terraform-ibm-modules/landing-zone-vpc/ibm to v7.5.0

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/landing-zone-vpc/ibm (source)
module
minor
7.3.2 -> 7.5.0

Release Notes

terraform-ibm-modules/terraform-ibm-landing-zone-vpc (terraform-ibm-modules/landing-zone-vpc/ibm)
v7.5.0
Compare Source
Updates  (#621) (753b89d)
IBM Cloud Terraform provider v1.56.0 has added a new option for the "ibm_is_vpc" resource that will cause the default VPC ACL and Security Group to contain no rules (empty).
This release will retire the usage of existing backend scripts to remove all rules from the VPC default ACL and SG, and instead use this new provider option to accomplish the same feature.
Input variable changes:
The new provider option covers both security group and ACL in one variable, so we will be deprecating the individual "clean_" variables and replace them with a new single boolean to enable the feature.

REMOVED: clean_default_security_group and clean_default_acl
ADDED: clean_default_sg_acl, if set to "true" will trigger new VPC option to have empty default groups (default is "false")
CHANGED: security_group_rules now has a default of empty, instead of a broad default inbound rule that may not be desired
Validation has been added to make sure that clean_default_sg_acl has not been set to "true" while having rules specified in the security_group_rules input, which are in direct conflict with each other

Upgrade Notes:
If you have already deployed module with the "clean_" variables not specified, you should see no difference after upgrade.
If you have already deployed module with "clean_" variables set to "true/false", you will get an error after upgrade due to those variables being removed, and you should set the new clean_default_sg_acl variable instead. During a plan phase after upgrading, you may see the following resources marked for DESTROY, this is expected as these are the retired scripts that handled this feature in the past, and have been removed:
module.slz_vpc.null_resource.clean_default_acl[0] will be destroyed
module.slz_vpc.null_resource.clean_default_security_group[0] will be destroyed

v7.4.2
Compare Source
Bug Fixes

add fix to support passing null for the prefix input variable (#605) (51856ff)

v7.4.1
Compare Source
Bug Fixes

added workaround for known provider issue (#592) (8707703)

v7.4.0
Compare Source
Features

subnet CRN now added to the subnet_detail_list output (#587) (518204d)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.

/run pipeline

/run pipeline

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fixed sidenav on smaller screens

Hi!
I want the sideNav to be fixed and open on all screen sizes - not just large ones. How can I achieve this?

Just out of curiosity, why was this closed without any comment whatsoever? @tomscholz

Sorry that I didn't told you whats wrong with this issue, it must have been late that evening ;) Back to your issue. Can you provide some kind of screenshot or somethings else to illustrate what you mean? Just a quick reminder: If the sidenav is fixed and open at all time, then on mobile it isn't possible to view the site correctly. Thats why it is currently not possible without editing the source files. You can ask over at stackoverflow or gitter for help ;) gitter.im/Dogfalo/materialize


chore: fix render syntax

It looks like shell is no longer a valid value from the render property. When I use it in a YAML template, I get a "value is not accepted" error in VSCode. I scrolled through the list of possible values, and the closest one seems to be console.

Check off the following:

[x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Thanks for the PR @schalkneethling. Shell is still listed as valid (see https://github.com/github/linguist/blob/master/lib/linguist/languages.yml#L6045), and I just tested to confirm it still works in a test template. I'm not sure what's causing that error to get thrown in VSCode, but since this still works as expected I'm going to close this out.


404 for get file content with special characters

We are using Rest API to download files from the OneDrive storage ( /content endpoint). It works perfectly fine for normal files, but when there are special characters in the file name we are getting 404 error. It is only for /content endpoint, we are able to get the details of that file using https://docs.microsoft.com/pl-pl/onedrive/developer/rest-api/api/driveitem_get?view=odsp-graph-online endpoint.
About month ago everything was ok.
Category

[ ] Question
[ ] Documentation issue
[x] Bug

Expected or Desired Behavior
Expected response:  302 Found
Observed Behavior
Observed response: 404 Item not found
Steps to Reproduce
File name: !@#$%^&()_+{}[];',.=-+ (1) (1) (1) (1).txt
Encoded file name: !%40%23%24%25%5E%26()_%2B%7B%7D%5B%5D%3B'%2C.%3D-%2B%20(1)%20(1)%20(1)%20(1).txt
Get content endpoint url:
https://graph.microsoft.com/v1.0/drives/{driveId}/root:/Folder/HELLO/!%40%23%24%25%5E%26()_%2B%7B%7D%5B%5D%3B'%2C.%3D-%2B%20(1)%20(1)%20(1)%20(1).txt:/content
Response for content endpoint: 404
Get item endpoint url:
https://graph.microsoft.com/v1.0/drives/{driveId}/root:/Folder/HELLO/!%40%23%24%25%5E%26()_%2B%7B%7D%5B%5D%3B'%2C.%3D-%2B%20(1)%20(1)%20(1)%20(1).txt:/
Response for get item endpoint: 200

Could you please provide the following response headers for the 200 and the 404 responses:

Date (in UTC, please)
request-id
SPRequestGuid (for requests made to OneDrive for Business)

@chackman
Headers for 200 response:
Date: Mon, 17 Dec 2018 15:10:20 GMT
request-id: eb5a69d6-2181-4358-a66d-7be5aa9cde55
Headers for  404 response:
Date: Mon, 17 Dec 2018 15:14:15 GMT
request-id: 43dd61b9-41d9-4539-8459-7ae1461648f7

Thanks, we'll investigate.

@chackman any update on that?

Looks like it's fixed now. Thank you for taking care of that.


First attempt at CI for exdown

Closes #1

I used GHC 8.10.7 because 8.10.4 seems to be no longer available in nixpkgs.
We should also try to see if the CI effectively fails when some invalid haskell code is written in a markdown file.

It indeed fails on invalid haskell code, see https://github.com/smelc/tn-fp-haskell-course/runs/7633678566

LGTM champagne
Just one remark. This looks clunky:

Could you easily fix it? If not, let's not bother.

I think that I solved the issue with my latest commit, but the build takes a little bit longer (I suppose that it might need to redownload the nixpkgs thing several times?). We should ask the help of a nix guru to see it what I did makes sense.

but the build takes a little bit longer

@tbagrel1> It takes less than 3 minutes, we're good, hence merging :slightly_smiling_face:
Thanks for your help, very much appreciated! :100:


Add guard to run tests when files change

We can evolve the Guardfile according to our needs, using the default one for now. I like this for productivity reasons, but happy to discuss if anyone is opposed to adding this. 🤔

@heidar add a note about the addition of Guard to the README - it's a good heads up for people cloning the repo for development.

Nice one. Let's get a Makefile in soon with a make guard?


can't compress css

i use the latest template
when i run npm run build, but css doesn't compressed
how can i solve it
thanks

It seems that the code does not include the cssnano the documentation implies. You will have to add your own css compressor. You can for example manually add cssnano to your vue-loader-config postcss processors.
build/vue-loader-config.js
module.exports = {
   ...
  postcss: [
    require('autoprefixer')({
      browsers: ['last 2 versions']
    }),
    require('cssnano')() //add this
  ]
}

Requiring the cssnano in postcss options will now compress your production CSS when running build. You can also pass the cssnano options as an object (same as the autoprefixer above).
See also:

Vue loader PostCSS docs
cssnano

Look #484

I follow you suggestion, i install the cssnanao, and now my css looks like below
.hello[data-v-92426efa]{background-color:#f6f6f6;display:-ms-flexbox;display:flex;-ms-flex-direction:column;flex-direction:column}.hello p[data-v-92426efa]{color:#00a0b0}h2 {
  color: #ff3c4e; }

h1 {
  color: blue; }

/*# sourceMappingURL=site.e0104a2f410f57f26be4466bea0b1cfd.css.map*/

It means worked?

@limichange I add this plugin, but it doesn't worked, you can see my prod.config.js
    new webpack.optimize.UglifyJsPlugin({
      compress: {
        warnings: false
      }
    }),
    new OptimizeCssAssetsPlugin({
      assetNameRegExp: /\.optimize\.css$/g,
      cssProcessor: require('cssnano'),
      cssProcessorOptions: { discardComments: {removeAll: true } },
      canPrint: true
    }),
    // extract css into its own file
    new ExtractTextPlugin(utils.assetsPath('[name].[contenthash].css')),

@radicalviva 🍻

@radicalviva If you have solved your problem, please close this issue :D


[HOLD for payment 2023-10-27] [$500]  IOS- Receipt border radius is not round

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696931354301509
Action Performed:

Go to any chat
Click on + icon and select request money option
Request money manually
Go to transaction thread
Click on three dots and add receipt
Go back to previous screen
Verify the receipt border radius

Expected Result:
receipt border radius should be round
Actual Result:
receipt border radius not round
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

https://github.com/Expensify/App/assets/93399543/b19225b2-6ffa-4e78-9ba7-8101849e7043

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c9f60635e933b6e7
Upwork Job ID:<PHONE_NUMBER>727636480
Last Price Increase: 2023-10-10
Automatic offers:

eh2077 | Contributor | 27239377
gadhiyamanan | Reporter | 27239379

Proposal
Please re-state the problem that we are trying to solve in this issue.
Receipt border radius is not round
What is the root cause of that problem?
https://github.com/Expensify/App/blob/b5445bd0da78132d602b2f3de36a19b1cf495fce/src/styles/styles.js#L3588-L3599
It seems that the value assigned to borderTopLeftRadius and borderTopRightRadius is not enough (which is 16 btw).
What changes do you think we should make in order to solve the problem?
increase the borderTopLeftRadius and borderTopRightRadius value

Proposal
Please re-state the problem that we are trying to solve in this issue
Receipt border radius should be rounded.
What is the root cause of that problem?
The problem comes from the fact that ThumbnailImage and Image  rendered components from within the ReportActionItemImage.js component do not have borderRadius styles applied:
https://github.com/Expensify/App/blob/11acdc2a4918859a3e1b8dfe23f10ad9a6f24218/src/components/ReportActionItem/ReportActionItemImage.js#L41-L53
This causes both receipt and receipt placeholder pictures to not have rounded borders since currently both only have style={[styles.w100, styles.h100]} styles applied.
What changes do you think we should make in order to solve the problem?
Add styles.reportContainerBorderRadius to both rendered components which will match the same borderRadius as the card has, like so:
    const receiptImageComponent = thumbnail ? (
        <ThumbnailImage
            previewSourceURL={thumbnailSource}
-            style={[styles.w100, styles.h100]}
+            style={[styles.w100, styles.h100, styles.reportContainerBorderRadius]}
            isAuthTokenRequired
            shouldDynamicallyResize={false}
        />
    ) : (
        <Image
            source={{uri: image}}
 -         style={[styles.w100, styles.h100]}
+            style={[styles.w100, styles.h100, styles.reportContainerBorderRadius]}
        />
    );

What alternative solutions did you explore? (Optional)
N/A
Videos

iOS

https://github.com/Expensify/App/assets/56457735/806ab2e1-7d41-4409-9391-194463c778cb

Proposal
Please re-state the problem that we are trying to solve in this issue.
Receipt border radius should be rounded.
What is the root cause of that problem?
We don't have borderRadius to wrapper of ReportActionItemImage
What changes do you think we should make in order to solve the problem?
We need to add borerRadius and overflow: hidden to wrapper.
https://github.com/Expensify/App/blob/562f9d8ff66d1e90285df088fa785c9638aa3861/src/components/ReportActionItem/ReportActionItemImages.js#L64
Need to add reportActionItemImage
        borderRadius: variables.componentBorderRadiusLarge - 4,
        overflow: 'hidden',

https://github.com/Expensify/App/blob/562f9d8ff66d1e90285df088fa785c9638aa3861/src/styles/styles.js#L3588
What alternative solutions did you explore? (Optional)

@allroundexperts could you review the proposals here?

I'm going to post a proposal to fix this issue.

Proposal
Please re-state the problem that we are trying to solve in this issue.
IOS- Receipt border radius is not round
What is the root cause of that problem?
The root cause of issue is from RN lib. On iOS platform, border radius is not working when using transparent border color.
See style of reportActionItemImages
https://github.com/Expensify/App/blob/fe282b45cb13e01519282ccc023e5bfbd7714158/src/styles/styles.ts#L3711-L3719
We can reproduce it using snack: https://snack.expo.dev/@eh2077/4c412a?platform=ios
iOS
https://github.com/Expensify/App/assets/117511920/a84a8a04-461f-4802-ac58-797c52eb5a49
I reported this issue to upstream RN repo, see https://github.com/facebook/react-native/issues/40969
It seems that the transparent or opacity border issue is tricky in RN, see also https://github.com/facebook/react-native/issues/39286
What changes do you think we should make in order to solve the problem?
From the style of reportActionItemImages
https://github.com/Expensify/App/blob/fe282b45cb13e01519282ccc023e5bfbd7714158/src/styles/styles.ts#L3711-L3719
We're using border-width: 4 and border-color: 'transparent' to introduce 4px space between image and the container.
We can use margin: 4 to achieve the spacing we want instead of using border-width and border-color.
We can just replace
https://github.com/Expensify/App/blob/fe282b45cb13e01519282ccc023e5bfbd7714158/src/styles/styles.ts#L3713-L3714
with
            margin: 4,

By doing so, we can get rid of the tricky inconsistent case of RN and solve the issue on iOS. Note we need to ensure the fix works for one or more than one receipts. See demo
https://github.com/Expensify/App/assets/117511920/7b9dd958-13f0-4c85-825a-5f127dd33b64
What alternative solutions did you explore? (Optional)
N/A

Could you work on the checklist for this one @allroundexperts? Thanks!

Payment summary:

Bug reporter: @gadhiyamanan $50
Contributor: @eh2077 $750
Contributor+: @allroundexperts $750

Payments made in Upwork for @eh2077 and @gadhiyamanan.
Bump @allroundexperts for the checklist :)

All set!

$750 payment approved for @allroundexperts based on BZ summary.


Upgrade ocamlPackages.odoc-parser and ocamlformat

Description of changes

The first commit adds versions 1.0.1 and 2.0.0 versions of odoc-parser. All the versions are required by the different versions of ocamlformat. Selecting a different version is easy with the version argument that was already here.
The second commit changes the default version of odoc-parser. It's a separate commit because it might cause breakage and can be reverted.
Init ocamlformat_0_24_0
The last commit change the ocamlformat definition to use the .override { version ...; } pattern. This might be a good pattern to use in the future for other ocaml packages.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I’ve just changed the order of the second and third commits, so as to avoid any breakage.


Set jquery is set to newer version for metalsmith-kalastatic-dot-module

@madeofpeople said, and I quote:

I get this when i point metalsmith-kalastatic-dot-module to the test-bed Error: Bootstrap's JavaScript requires jQuery version 1.9.1 or higher, but lower than version 3

@madeofpeople do you even remember what this was about?

We figured out the root cause.
We were having jquery issues, because of the kalastatic / drupal Js loading.
I think this one can be put away.
T

On Mar 10, 2016, at 12:18 AM, Josh<EMAIL_ADDRESS>wrote:
@madeofpeople https://github.com/madeofpeople do you even remember what this was about?
—
Reply to this email directly or view it on GitHub https://github.com/kalamuna/kalastatic_dot_module/issues/4#issuecomment-194674388.


Listen db changes

Hello guys!
I want to look for changes in my db(when created new record, when record is updated and ect.), how I can do it?

Right now you can't. However, I have started work on this in the database driver. Unfortunately I was unable to finish it. Maybe someone else would like to take over? ankhers/mongodb#205


Fix type signature conversion

Reviewed By: mbasmanova
Differential Revision: D45357874

Merged in https://github.com/facebookincubator/velox/commit/254537d68c9afda9dfa57328bca06cc0ccc9f17c


rv-value overrides "value" attribue of a radio button

Not sure if this is an issue (quite new to rivets),
I found this using rivets v0.6.9 (http://jsfiddle.net/#&togetherjs=Kkbvn4R3zg)
But I was unable to reproduce it with v0.8.0 because i get the following error "rivets is not defined"
(http://jsfiddle.net/#&togetherjs=Kkbvn4R3zg)
Here's the sample I used for my tests :
<!DOCTYPE html>

	<meta charset="utf-8">

		<input type="radio" name="enabledOrDisabled" rv-value="test.enabled" value="enabled">Enabled</input>
		<input type="radio" name="enabledOrDisabled" rv-value="test.enabled" value="disabled">Disabled</input>

Thomas.

Hi Thomas,
The keypath engine used by rivets was split into its own repo. So, if you are going to use rawgit to serve the files, you will need to use the bundled version of rivets and not the stand alone minified version. Looking at the dist directory you should be able to see the 3 diff versions.
Your rawgit script tag for rivets should look like: https://rawgit.com/mikeric/rivets/master/dist/rivets.bundled.min.js
Please let me know if this helps. I would have updated your jsfiddle, but there was no content in the fiddle.

Hi and thank you for your help !
I updated the reference to rivets in my sample with the bundled one, and managed to make a proper jsfiddle example this time ! Here it is : https://jsfiddle.net/qxztdLk0/
When I use rv-value on radio inputs, their default value attribute gets overridden. Is that the correct behaviour ?
Thanks,
Thomas.

Hi Thomas,
You would need to use the rv-checked binder with radio inputs.
Your updated fiddle: https://jsfiddle.net/cqebn38c/
If you look in rivets source, https://github.com/mikeric/rivets/blob/master/src/binders.coffee#L32
You should see the rv-checked binders definition.
If you look at this binders routine function, there is a check for the type of input, if the input type is a radio, then rivets will set the value of the bound option to the value of the value attribute on the input.
I only say these things so that you might get used to looking at the source and making your own binders (and thus rivets will unveil its inner workings to you and become the One Ring to your Sauron)
Please close if this helps you.
Greg

Thanks a lot for your help ! Looking at the source helps indeed.
Closing the thread as this is not an issue.