BUG: contradicting description in mannwhitneyu test

Describe your issue.
The description provided for the alternative is contradicting itself. For instance, the explanation for less is phrased that "the distribution underlying x is stochastically less than the distribution underlying y", but the mathematical formula following is stating the relationship in the other way: i.e. F(u) > G(u) for all u.
It would be clearer to state that for less: the H0 hypothesis is that the distribution underlying x is stochastically greater than the distribution underlying y, F(u) >= G(u)* for all u. The H1 hypothesis is that the distribution underlying x is stochastically less than the distribution underlying y, F(u) < G(u).
This would reflect how the test is working.
Similar update should be made to the greater explanation as well.
Reproducing Code Example
Input:
sample1 = [10 for i in range(100)]
sample2 = [20 for i in range(100)]
mannwhitneyu(x = sample1, y = sample2, alternative='less')

Output:
MannwhitneyuResult(statistic=0.0, pvalue=1.7608079411973e-45)

Error message
No error message related to this issue.

SciPy/NumPy/Python version information
1.7.1 1.20.1 sys.version_info(major=3, minor=8, micro=8, releaselevel='final', serial=0)

I understand the confusion, but the direction of the inequality is correct as-written. Remember that F and G are the cumulative distribution functions underlying the variables. The math of stochastic ordering is not always familiar, so maybe the solution is to rewrite the mathematical statement in terms of the PDFs, which has more immediately intuitive notation. Would that work?
We could add the null hypothesis, too. But regardless of alternative, the null hypothesis is that the two distributions are identical (i.e. CDFs are equal for all x). The calculation of the p-value depends on that. Would that be good?

Oh! NO, I didn't realise that F and G are the cumulative distribution function, although it is clearly written. Thank you for calling my attention to it.
I noticed that there is an explanation of this at the ks_2samp test, which might be a consensus solution, so no need to rephrase, but add some explanation to be super clear.
"Note that the alternative hypotheses describe the CDFs of the underlying distributions, not the observed values. For example, suppose x1 ~ F and x2 ~ G. If F(x) > G(x) for all x, the values in x1 tend to be less than those in x2."
This also leads me to another question, if I may: these two tests are using the alternative "less" in the opposite way. Or am I missing something again?
It would be great to use them consistently, where the H1 hypothesis means F(u) > G(u) where F and G are cumulative distribution functions. I am very interested in your view! Thanks a lot in advance!

Yes, I added that note in gh-13188 to resolve similar confusion about ks_2samp. I don't have much time to review or submit PRs now, but I wouldn't block such an addition to MWU. I wouldn't really want to be involved in it, though, because it involves formatting math, and there tends to be more contention about how best to do that than one would expect.

This also leads me to another question, if I may: these two tests are using the alternative "less" in the opposite way. Or am I missing something again?

That's true. But I can see the reason for it. Certainly mannwhitneyu's convention is intuitive; e.g. alternative "less" means that the random variable underlying x "tends to be less" than the one underlying y. Most SciPy hypothesis tests are like that. I think that is much more common to think about most tests in terms of the random variables than in terms of the CDFs underlying the data. We just add the bit about the CDFs to make the meaning of "stochastically less" precise in terms of concepts that users are probably familiar with. But ks_2samp is naturally thought of in terms of the CDFs underlying the data rather than the random variables. For example, on Wikipedia

"The Kolmogorov–Smirnov statistic quantifies a distance between the empirical distribution function of the sample and the cumulative distribution function of the reference distribution, or between the empirical distribution functions of two samples."

So for ks_2samp, having "less" correspond with the alternative "F(x) < G(x) for at least one x" makes some sense. Since there is some rationale behind the way it is, there would need to be a lot of support to make a backwards-incompatible change.

Thank you for the clarification. This was very helpful! I see your point how the different formulations makes sense. One has to pay careful attention what 'less' means in each test.


Rework I2cController and I2cDevice

Description

Rework I2cController class to allow multiple instances.
Add new internal class to handle multiple I2cController.
Rework I2cDevice class accordingly.
Decorate fields with DebuggerBrowsableState to hide them on debug session.

Motivation and Context

Current implementation only supported a single controller.
Improve the debugging experience.
Fixes nanoFramework/Home#421

How Has This Been Tested?

Screenshots
Types of changes

[ ] Improvement (non-breaking change that improves a feature, code or algorithm)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Signed-off-by: José Simões<EMAIL_ADDRESS>

@steffalk thank you for your review. Your comments are most welcome.
Apart from some "it's-ok-to-simplify-it-here" at the class libraries you can almost forget that you are coding for MCUs. All the knowledge, baggage and principles of C# do apply here!!

Let's test on real hardware.

Already done and, guess what, it works!! 🤣

@sharmavishnu

I2cControllerManager design should also be carried over to SPI. I2C and SPI should be similar in approach as both are buses.

That's the plan as I've already mentioned in Discord channel. Just waiting for feedback abou the current changes to see if there are rough edges to polish before porting these to the other class libs.

Rather than using controller = (I2cController)I2cControllerManager.ControllersCollection[controllerId]; perhaps , it is better to design it as
controller = I2cControllerManager.GetControllerById(controllerId);

I like this suggestion. Basically you are suggesting that we move that accessor to the collection to it's own method in I2cControllerManager, correct?
Let's do that. Actually, can you please take care of if and submit a PR? 😉

The ControllerManager class is more of a "synchronized Hashtable". If we agree to carry-over similar design pattern for SPI, then maybe, we should have a base class implementing "synchronized Hashtable" and then extend it to create I2cControllerManager and SPIControllerManager. This prevent code duplication.

These are in separate repos... I understand your concern but I'm afraid it would be more trouble setting up something like sub-modules just to get this piece of code than just have it on each repo...

Yes. Will make the change and submit the PR


Flaky test: HttpOverHttp2Test.recoverFromCancelReusesConnection

Example run: https://travis-ci.org/square/okhttp/builds/478641194

Probably related to https://github.com/square/okhttp/issues/4633.

I believe this is fixed.


Updated lot'so code so that json is used instead of CSV

I've found that LLM's format json much better then csv's and it looked like a lot of work was being done to fix csv output into something manageable.
Very cool project!

Thanks you for your kind words and effort here. Yes, I agree, JSON is probably a more reliable option than CSVs. The response from the LLM looked good, but the validation threw an error.
I'm happy to implement this once we test it and iron out the bugs (as seen here):
autocrew.log

Changed CRLF's at end of lines. (driving me mad)
Allowed 3 retries when talking to LLM, as I believe the error you saw was the LLM not giving a good response.

Hmm, the crlf issue makes all files unmergable I'm going to redo this pull, so ignore it for now.

Changed CRLF's at end of lines. (driving me mad)
Allowed 3 retries when talking to LLM, as I believe the error you saw was the LLM not giving a good response.

It should be retrying 10 times...this function appears to have disappeared


"Refactor"

Is see a number of issues:

I would rename it to "Create As Function..."
it creates a function below the global var section .. which means that the global vars ends up somewhere in the middle of procedures.
by default, it's a global function - i would turn it into a local.
the "PROCEDURE" is capitals - should be lower cased.
the formatting is quite off

this is my "refactored" function:
  PROCEDURE foo();
begin
Message('let us show another message');
        repeat
            Message('Customer %1',mycust."No.");
        until mycust.Next < 1;end;

True. This is me fooling around with TypeScript in an airplane.
Daniel is already ahead of me and he has changed the code to support the "lightbulb". I have to look at it, test it and create a new version. Probably not going to happen before NAVTechDays. (Sorry)
Thanks for the feedback


Allow to register APISurface endpoints and handlers on an external HTTP server

This PR is implementing the proposal done in the issue: #32

LGTM

@shawn-hurley right, I will add an unit-test.

@shawn-hurley unit-test added

Thanks for the patch @clamoriniere1A


Make all mapview constraints optional, correct export of esri request

I was unable to partially set mapview constraints, hence the pull request

Thank your for this PR. We'll include most of these changes into the upcoming 4.2 release.

yeah, thanks @ayush000. very cool!


Crash with CP as the only mod

Hello! The only mod I have is the Community Patch mod. I get an error when I click the Community Patch Options on the main menu, or when I click the "Campaign" button. The error is "the application faced a problem. We need to collect the...". In the mod order, it is at the bottom of all those "Native" stuff. The only other mod that I have (I just remembered) is the Fixed Launcher mod.
I unblocked the dlls through the Unblock dll mod, and didn't mess with the game version so it is what it is when you install the game. Sorry, but what am I doing wrong?

im having the same issue x.x


fix: don't update view after opening and immediately closing a popover

Close: #4430
Signed-off-by: Bram Meerten<EMAIL_ADDRESS>PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
When opening and closing a popover synchronously, the following error is thrown:
TypeError: Cannot read property 'rootNodes' of undefined
Issue Number: #4430
What is the new behavior?
When handling the content-check events in the ClrPopoverContent, make sure view is still defined before updating the renderer style.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Hey,
I was wondering if it is possible to get a second reviewer and merge this before the next release?
Because this is a major issue for us, a lot of our tests fail because of this issue when we upgrade Clarity.

@BramMeerten you need this for Clarity v3.x, right?

@Jinnie Yes that is correct

@gnomeontherun will you be merging this in? We saw this error come up in Sentry and led me to #4430.

I was wondering the same thing. I don’t want to be pushy but hopefully this can be added to the next release? I actually expected it to be in the previous release since it’s a small change with two approvals and has been ready for a while..
@gnomeontherun
Just noticed there are conflicts though. Do I resolve these? If I understand the contribution doc correctly, you guys usually do this, but I’m not sure.
If not I’d be happy to resolve the conflicts, and if so: Do I also need to sign merge commits, or are they excluded from the check?

Yes I want to have this in the release this week. It would be great if you could squash your commits and fix the conflicts on your end, then we handle the backporting. The formatting changes in master are likely the issue with an update to eslint/prettier. Thanks!

Hey @BramMeerten,
Can you rebase your branch so we could merge it and backport it? We plan to have release this week so it will be nice to include this as well.
Thanks ;)

Hey @bdryanovski,
Done
Kr.

Thanks @BramMeerten for the quick respond :)


Refactor workflows to add deployment of contracts migrated on Celo

Workflows have been refactored so that Celo-related artifacts could be
deployed in the chain of automatic execusions triggered by the manual
dispatch of the Main workflow in the ci project (with environment
set to alfajores).
Similar changes have been introduced to keep-core and tbtc
workflows. See:
https://github.com/keep-network/keep-core/pull/2492
https://github.com/keep-network/tbtc/pull/804

@michalinacienciala can we solve the conflicts, please?

@michalinacienciala we've got some formatting problems.

@michalinacienciala we've got some formatting problems.

Fixed in 08bdbe82831b53bd53a2a8c75536aa71bb533cad.

@nkuba, after merging the change, there would be a need for change in the configuration of required jobs - client-build-test-publish-ethereum should become required (instead of client-build-test-publish).
We should also consider whether to make celo-related jobs required...


OAuth error

Hi There! I'm trying to finish installation of MAS.
I'm on:

"b. In Setup, go to the Named Credential record, click Edit, ensure the Start Authentication Flow on Save checkbox is selected, then click Save."
"c. Salesforce will prompt you to log in with the user credentials you want Mass Action Scheduler app to use. On the login page, click Use Custom Domain and enter nei.my.salesforce.com."

But I'm getting the error:

We can't authorize you because of an OAuth error. For more information, contact your Salesforce administrator.
OAUTH_APPROVAL_ERROR_GENERIC : An unexpected error has occured during authentication. Please try again.

I've tried as both named principle and user, and get the same error.
Any help appreciated. thanks!

Hi @JulianJ88, I think perhaps the recommendation to enter nei.my.salesforce.com for your custom domain was incorrect. On the salesforce login page, when you click the button Use Custom Domain, I believe you only need to enter your My Domain prefix. In this case, that's everything before .my.salesforce.com, so simply nei.
Please try just entering nei for the custom domain (or whatever you see in the URL left of .my.salesforce.com).
Sorry for the inconvenience. In the next release that I'm currently working on, there will be no need to set up Connected App, Auth. Provider, or Named Credential. My goal (safe harbor) is to have this next version released by end of 2018.
Thanks for your interest in Mass Action Scheduler :)

Hi @JulianJ88, I'm assuming that the 👍 on my last reply means you were able to move forward with setting up the Named Credential? I'll go ahead and close this issue, but feel free to reply back if you're still having problems authorizing the Named Credential. Thanks


chore: merge master into next-major-spec + fix bug in bundler

Description
This PR, besides merging master into next-major-spec, does the following:

Fixes a bug in the bundler to -without-$id where $ref pointing to definitions without .json extension fail. For example, "$ref": "http://asyncapi.com/definitions/3.0.0/operation.json#/properties/title" like the OperationTrait in v3 has now
It adds support for bindings $id to without-$id transformation. For example http://asyncapi.com/bindings/mqtt/0.1.0/operation.json to bindings/mqtt/operation.

Both matching are now done through regex, since there is no easy silver bullet solution without doing tons of hacks.
Pinging @derberg who made the changes in the bundler for creating schemas without $id. So I expect you can review my last commits where the fix is done.

Warning
Manually merge and not rebase!

@derberg @jonaslagoni  I need some help debugging what's the issue with the produced 3.0.0-without-$id.json.
Here you can find the validator error: https://www.jsonschemavalidator.net/s/3OO3lvSb

Could not resolve schema reference '#/operation#/properties/title'. Path 'definitions.operationTrait.properties.title', line 4675, position 26.

Interesting, it is only with operationTrait, not a serious stuff imho
the oryginal schema has http://asyncapi.com/definitions/3.0.0/operation.json#/properties/title and the no-id bundler is dummy and replace http://asyncapi.com/definitions/3.0.0/operation.json with a local reference. So simple fix is just have an if that if there is a url with anchors, then not only http://asyncapi.com/definitions/3.0.0/operation.json but http://asyncapi.com/definitions/3.0.0/operation.json# should be replaced new local reference so it looks like "$ref": "#/definitions/operation/properties/title"

"$ref": "#/definitions/operation/properties/title"

@derberg The issue is with JSON pointer here and the fact we should scape / characters with ~1, which doesn't look pretty good from DX perspective.
I decided to use - instead now (See the last commit I pushed). For example,http://asyncapi.com/bindings/http/0.1.0/message.json in regular file is bindings-http-0.1.0-message in -without-$id file.
I also added support for testing and validating the schemas without $id which was not added before.

@smoya I don't get why you need ~1? we use it in parser-js only if we need to handle encoding of / in the channel names that may have it. But in case of stuff like "#/definitions/operation/properties/title" there is no need to do any tilde encoding really 🤔

@smoya I don't get why you need ~1? we use it in parser-js only if we need to handle encoding of / in the channel names that may have it. But in case of stuff like "#/definitions/operation/properties/title" there is no need to do any tilde encoding really 🤔

My bad for the confusing explanation. Gonna try again.
1. Bug with #/operation#/properties/title
The issue was that the extra # was not required. That's fixed, and now it is #/operation/properties/title.
2. Bug with definition ids with / characters
Ids can have extra / characters. That's the case for the bindings, for example, where you can find things like http://asyncapi.com/bindings/mqtt/0.1.0/operation.json.
If we convert that to bindings/mqtt/0.1.0/operation, then references will need to use ~, such as "#/definitions/bindings~1mqtt~10.1.0~1operation". Otherwise, the JSON Pointer will try to find in the path definitions.bindings.mqtt.0.1.0.operation. Meaning it will only work if a definition like the following is in the file (which is not our case):
 "bindings": {
            "mqtt": {
                "0.1.0": {
                    "operation": {
                        "type": "object"
                    }
                }
            }
        },

"0.1.0

ah yeah, makes a lot of sense


Improved logging.

Use the logger name to correlate messages logged within a reconcile.
Example:
{"level":"info","ts":1557442000.3781226,"logger":"cluster|p8w44","msg":"[rWatch] Starting manager"}
{"level":"info","ts":1557442000.378142,"logger":"cluster|p8w44","msg":"[rWatch] Manager started"}
{"level":"info","ts":1557442000.3781505,"logger":"cluster|p8w44","msg":"Remote watch started.","cluster":"ocp4"}

Thanks for finding a way to implement this!
This PR reminds me once again of how much I dislike the variable length timestamp on each log message... Will fix that someday.
I think what you're doing is setting the global logger per pkg. Want to think about this a little more tomorrow and make sure it will actually result in what we want given that the logger is shared.

Just tried this out; makes it so much easier to interpret the flow of individual reconcile loops in the logs.


Angular 8 support

I'm submitting a ...  (check one with "x")
[ ] bug report => Search github for a similar issue or PR before submitting
[x] feature request => Please check if similar feature request does not exist
[ ] support request => Suggested place for help and support is [stackoverflow](https://stackoverflow.com/), search for similar question before posting

Description

Here is how I updated my fork : https://github.com/gilsdav/ngx-translate-router/compare/ca881c27954d878554976b8b3fed92dea1b98c63...master
Hope it will help

@gilsdav Unfortunately this solution is not going to work with AOT enabled. You're trying to inject compiler which is not available at runtime.
Is there any way to do it differently without accessing compiler?

@kamilchlebek ngx-translate-router is now compatible AOT and Universal on Angular 8 with the version 2.0.1

Thank you, I'll check it out

Any updates on this?

Yes it's all good now. 2.0.1 works for AOT and JIT

Hi Guys, can anyone give me an example that how should work this in node?
I've  mean, the configuration for the browser.module it's fairly OK, but in the server side it seems not complete at all, I've reviewed a lot of outdated repos using this localize-route and others but it doesn't seem to work on compilation.
Please if anyone has a better example of how should work this in server side please share with me, so far the only thing that I've, (following all steps in the README.md from this repo) is an ERROR [Error] in (node) server side.
When I'm setting up the application in debug mode works like a charm but not in the same way after compilation process.
Thanks!


How does FVDB average pooling work?

Hi,
I am trying to implement an average pooling filter on a sparse VDBTensor. In regular PyTorch I would use torch.nn.AvgPool3d(kernel, kernel, divisor_override=1) and divide the result by the number of active values if any (between 1 and $kernel ^3$).
However I cannot replicate that with AvgPool in fvdb.
I also tried to define my own convolution with:
conv = SparseConv3d(n_c, n_c, kernel, kernel, False)
with torch.no_grad():
    conv.weight[:] = 0
    for i in range(n_c):
        conv.weight[i,i,:] = 1.
sum_pool = conv(vdbtensor).jdata # vdbtensor.feature[...,  n_c-1]=1 to count the number of active sites
sum_pool = sum_pool[..., :n_c-1]/sum_pool[..., n_c-1, None]

But I could not match what I obtain in the dense case.
How is AvgPool supposed to work?

Hi @nissmar
Thanks for the question! There are two ways to average pool in fvdb. (1) Directly using the GridBatch and a feature JaggedTensor or (2) using fvdb.nn
Option 1:
The first uses a GridBatch directly via GridBatch.avg_pool whose signature is:
def avg_pool(self, pool_factor: Vec3iOrScalar, data: JaggedTensorOrTensor, stride: Vec3iOrScalar = 0, coarse_grid: Optional[GridBatch] = None) ->  Tuple[JaggedTensor, GridBatch]

The arguments are:

pool_factor: the width/height/depth of the filter to pool in (either a triple or a scalar)
data: a JaggedTensor of features per-grid in the batch to be pooled
stride: a stride for the pooling
coarse_grid: (optional) -- if you've precomputed the coarse pooled grid, you can pass it in and it won't be recomputed
The function returns:
pooled_data: a JaggedTensor of average pooled feature for each voxel in the output grids
out_grids: a GridBatch of pooled grids.

Option 2:
Using fvdb.nn.AvgPool whose constructor takes in a pooling size and stride, and whose forward function takes in a VDBTensor.

Thank you!


Add icon to describe form

Description
Add icon to describe issue input
Fixes #381
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] My changes generate no new warnings

Screenshots
Before

After

needed**

Hello @MisterMickey!
Thank you for submitting this pull request Your pull request will be reviewed by maintainers shortly. Meanwhile make sure you have referenced the respected issue in this pr Your pr will not be merged if it does not have reference to respected issue
please read our Contributing Guidelines https://github.com/UBA-GCOEN/StichHub/blob/main/CONTRIBUTING.md And Code of Conduct https://github.com/UBA-GCOEN/StichHub/blob/main/CODE_OF_CONDUCT.md

Build is failing as you haven't exported describe
Please export it.

@MisterMickey Build is failing as you haven't exported describe Please export it.

@Naresh-chandanbatve Resolved!!


Fix broken :runners:java-fn-execution:spotbugsMain task

CC @robertwb
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---

---
---

Java

Python

---

---
---

XLang
---
---
---

---
---
---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

13:16:26 FAILURE: Build failed with an exception.
13:16:26
13:16:26 * What went wrong:
13:16:26 Execution failed for task ':runners:java-fn-execution:spotbugsMain'.

We are back to the "normal" failures:
14:23:06 FAILURE: Build failed with an exception.
14:23:06
14:23:06 * What went wrong:
14:23:06 Execution failed for task ':runners:direct-java:needsRunnerTests'.
14:23:06 > There were failing tests. See the report at: file:///home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit/src/runners/direct-java/build/reports/tests/needsRunnerTests/index.html


Extend Redux to support optimistic data updates

A little background first. Right now, the way we are doing updates is by dispatching a thunk, waiting for the response and then updating the UI. This creates a really bad UX. The correct way of doing this is by dispatching an action first to update the state in the store, ensuring instant feedback for the user, then dispatching the thunk in the background and reverting the update if an error comes back.
This way we can also normalize the state in the store and do the mapping to the desired shape in the reducers, improving app performance.

fixed with the new version


要设置WORLD_SIZE and LOCAL_RANK

(visualglm) D:\visuaglm\VisualGLM-6B>python api.py
[2023-10-29 14:47:17,801] [INFO] DeepSpeed/CUDA is not installed, fallback to Pytorch checkpointing.
[2023-10-29 14:47:17,974] [WARNING] DeepSpeed Not Installed, you cannot import training_main from sat now.
[2023-10-29 14:47:18,524] [INFO] building VisualGLMModel model ...
[2023-10-29 14:47:18,539] [INFO] [RANK 0] > initializing model parallel with size 1
[2023-10-29 14:47:18,539] [INFO] [RANK 0] You are using model-only mode.
For torch.distributed users or loading model parallel models, set environment variables RANK, WORLD_SIZE and LOCAL_RANK.

请问怎么解决这个问题？

请问解决该问题了吗

你好，这个问题解决了，这个并不是警告或者是报错，只是某种参数信息的显示，之后就会开始加载权重参数并开始模型推理，如果没有开始加载权重参数那说明显存可能不够，没法进行下一步
在 2024-02-26 19:59:13，"Jayson" @.***> 写道：
请问解决该问题了吗
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Two pages at once

Hello!
Is there any opportunity to show two pages at once with swapping between two-page turns, like a magazine or book?

No, there is no such possibility.


slighty clean up the metrics generation code

Scope & Purpose
Fix some smaller metrics-related issues:

feed metric "arangodb_http_request_statistics_async_requests" with correct input value
fix a typo in description of metric "arangodb_http_request_statistics_http_patch_requests"
remove requirement that metrics descriptions have to end with \n in order to work. This is unexpected and has led to a few metrics not being reported properly.

[x] :hankey: Bugfix
[ ] :pizza: New feature
[x] :hammer: Refactoring
[ ] :book: CHANGELOG entry made
[x] :muscle: The behavior in this PR was manually tested
[ ] :computer: The behavior change can be verified via automatic tests

Backports:

[ ] No backports required
[x] Backports required for: 3.7

Testing & Verification

[x] This change is a trivial rework / code cleanup without any test coverage.

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/11846/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/11852/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/11857/

Tests blue


Migrate to VS2017 and support Net Standard 1.6 where possible

Hello, I've created this PR to open a line of conversation and see if there's a possibility of bringing this project up-to-date. We use Banzai on a couple of projects and we're looking to freshen up the code and consider a move to Net Core at some future point.
I've completed the following:

Migrated all projects to VS2017
Attempted to support Net Standard 1.6 on all but a few (due to dependencies)
Used FluentAssertions instead of Should (almost identical syntax)
Some minor code clean-up (can return FlowComponent instead of dynamic)
Cleaned up async tests to return Task instead of void
Updated packages

I've not completed the following:

Nuget packaging (still to understand this)

All tests are passing. Let me know if this project is still alive and you're accepting PRs?

Sorry @neildobson-au I've been super busy and haven't used this project in a while now.  I totally missed your PR.  I'll take a look and see if I can complete the updates.

OK thanks. I haven't touched this in a while. Need to review what's happened since NET Standard / NET Core 2.0. Perhaps we consider moving straight to 2.0 as the APIs are more complete. Also I think the NUnit situation has been resolved so all projects can target the same runtime.
We are using Banzai in production so it's important for us this project is kept fresh. I'm happy to do all the legwork, just need a bit of help with CI and packaging.

I've pushed an experimental branch targeting NetStandard 2.0
https://github.com/barnardos-au/Banzai/tree/NetStandard20
All tests passing, however I had an issue with Ninject in that I couldn't upgrade to v3.3 or the v4 beta. Not sure what's happening but I keep getting failed to load assembly exceptions. Tried multiple times including clearing out assembly cache and re-installing packages etc.
Apart from that all good except JSON & Javascript test projects which are dependent on the ClearScript binaries. These don't play nicely with NetStandard so I've left them at 4.6.1. Maybe there's something else we can do here.


Add containerd example

Hi 👋
first of all I want to say thank you for this great repository!
I mainly do experiments with KinD or MicroK8s. Both are using containerd under the hood. Therefore I thought that it would be great if I could adapt this example to containerd. That worked with almost no changes. I swapped crio with containerd and was able to start the wasm-wasi-example with ctr as well as with nerdctl.
However, when I run Kubernetes on top of containerd I get an error when starting a wasm container. It says:
Error: failed to create containerd task: OCI runtime create failed: open `/proc/1591420/ns/ipc`: No such file or d
irectory: unknown

But thats a task for later 😁
If it fits your concept of this repository I'd like to contribute the changes I made to demo the containerd integration, even if they are small.
The links to the scripts in the Readme already point to your repo, the links to Successful run and in the workflow file need to be changed after merge and the first run of GH actions in your repo. A successful run can be found here
Since this is an unsolicited PR feel free to ask for changes or to reject it.

Hi @0xE282B0
Thanks for contributing. This is fantastic.
We never encountered this issue when using k8s + CRI-O. Maybe there is anything different between containerd and CRI-O?

Error: failed to create containerd task: OCI runtime create failed: open /proc/1591420/ns/ipc: No such file or directory: unknown


Add disclaimer to the live leaderboard(s)

If a leaderboard is live add a disclaimer to it:

done


Introduce protocol aliases for the notification protocol

Each notification protocol may have aliases/fallback names which are used for negotiation if the main protocol is not supported by both peers

https://github.com/altonen/litep2p/commit/695c374cb83a285162870464464c6128eb775dbd


DS-3279: Retrieval of Anonymous group's UUID for read rights query

PR for jira ticket
https://jira.duraspace.org/browse/DS-3279
Retrieve UUID from anonymous group

@jonas-atmire , could a similar issue exist for permissions in the OAI repository?

+1 via code review. The code looks correct and this looks like an obvious bug to me.  Needs a quick test though before merging.
I agree with @terrywbrady that we should double check this same issue doesn't exist in other Solr indexes.

I've checked the oai and statistics cores; neither appears to store group IDs. The statistics core stores the eperson ID if a logged-in user accesses an item/bitstream/etc and this is using the uuid. I don't believe the eperson information is actually ever used by the default stats code anyway. I haven't checked the authority core but the solr schema for that core looks like it doesn't store this type of information at all.

+1 to this PR after testing

Gave this a test as well today. It works. As I already voted +1 and @aschweer tested/voted as well, I'm going to merge this fix immediately.


Update Dockerfile to run Java 17

The latest Version of the diga-api-client 2.0.0-beta.1 will break when validating or billing codes other then the test code because the dependency update of base32check-java to 0.1.0 requires Java 17.
This PR updates the production docker image to use Java 17. It uses the eclipse-temurin:17-alpine image to have a more lightweight docker image. It also adds a new user in order to avoid running the application as root.

Upgrade production docker image to use Java 17 to make the build compatible with the latest diga-api-client

in the production docker image create a new user so the application is not run as root

@jakob-p thanks for your contribution. Your changes together with the changes from https://github.com/gtuk/diga-api-service/pull/25 are now released as version v2.0.0 https://github.com/gtuk/diga-api-service/releases/tag/v2.0.0


Goldpage express handler calls next() even when it sends a response

I was noticing the following ERR_HTTP_HEADERS_SENT  error for requests when Goldpage handles the response:
App listening on port 8000
Press Ctrl+C to quit.

GET / 304 - - 392.773 ms
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (_http_outgoing.js:470:11)
    at expressInit (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/middleware/init.js:30:42)
    at Layer.handle [as handle_request] (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/router/index.js:317:13)
    at /Users/chriscalo/Projects/viaticus/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/router/index.js:335:12)
    at next (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/router/index.js:275:10)
    at query (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/middleware/query.js:45:5)
    at Layer.handle [as handle_request] (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/router/index.js:317:13)
    at /Users/chriscalo/Projects/viaticus/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/router/index.js:335:12)
    at next (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/router/index.js:275:10)
    at Function.handle (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/router/index.js:174:3)
    at Function.handle (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/application.js:174:10)
    at mounted_app (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/application.js:230:10)
    at Layer.handle [as handle_request] (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/router/index.js:317:13)
    at /Users/chriscalo/Projects/viaticus/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/router/index.js:335:12)
    at next (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/router/index.js:275:10)
    at Immediate.<anonymous> (/Users/chriscalo/Projects/viaticus/node_modules/express/lib/application.js:233:9)

It seems that Goldpage is calling next() even when it sends a response, so later handlers also try to respond. If I insert the following logic, it fixes things:
import express from "express";
import goldpage from "goldpage";

const server = express();
export default server;

server.use(goldpage.express);

// prevent later handlers from being called if goldpage has responded
server.use((req, res, next) => {
  if (!res.headersSent) next();
});

I think the fix is to not call next() when Goldpage sends a response. (Is @universal-adapter/express calling next() even when a response has been sent?)

(By the way, I really appreciate that Goldpage calls next() at all so that later handlers are able to run. Some express integrations assume that no other handlers need to run after their code, which is really frustrating. So please keep calling next() when Goldpage can't respond to the current request.)

Fixed & new Goldpage version 0.5.4 published.

Working great, thanks!


Sentinel is getting too crowded with flags; maybe it’s time to introduce subcommands

package main

import (
	"fmt"
	"os"

	"github.com/akamensky/argparse"
)

func main() {
	parser := argparse.NewParser("program", "A program")

	if len(os.Args) <= 1 {
		fmt.Printf("No command provided. Exiting.\n")
		os.Exit(1)
	}

	switch os.Args[1] {
	case "command1":
		// Define arguments
		arg1 := parser.String("a", "argument", &argparse.Options{Required: false, Help: "Argument for command1"})

		// Parse
		err := parser.Parse(os.Args[2:])
		if err != nil {
			fmt.Print(parser.Usage(err))
		}

		// Use your arguments
		fmt.Printf("command1, arg1: %s\n", *arg1)
	case "command2":
		// Similar to command1 but with different args
	default:
		fmt.Printf("Unknown command: %s\n", os.Args[1])
		os.Exit(1)
	}
}

In retrospect, it does not make sense to do it.
Reasoning:
All of the flags in the safe command is related to modifying secrets in one way or other.
So in a likely multiple command scenario, all of those flags will be jumbled under safe secret -k -i …etc kind of a command anyway.
The only exception to that is the -i (input key) command.
While splitting it as a separate binary will be a good separation of concerns, and will provide some level of split/security; doing this for only a single flag will be an overkill.
I’m closing this for now.
We can discuss it when/if we need more flags to support.


Button "accept" missed up

Admin panel > withdrawl> bank transfer   button accept is missed up

Closed via #515.


Merge scala-js-cli repository into scala-js-cli-native-image

Going to (squash-and-)merge I think.


[New Feature]Added internationalization configuration to Fury.

"Added internationalized routing configuration and internationalization framework setup to Fury, and included a Simplified Chinese version."

@theweipeng  could you take a look at this pr?


chore: bump Eigen's version 8.29.0

Description
This PR bumps Eigen's version 8.29.0.
PR Checklist

[ ] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

chore: bump Eigen's version - araujobarret

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Dev changes (chore: bump Eigen's version - araujobarret)

  Generated by :no_entry_sign: dangerJS against 8d3bf45178b30e18ed87469525295514437d0cc8


IE11 (not Edge) and ES6

Can I just check this won't work on IE11 because of ES6, right?

I was able to get it working on IE11 using a combination of the following.
Adding an alias to the minified version in my webpack config:
aliases: {
      'marquee': 'marquee3000/marquee3k.min.js'
    }

And installing and loading babel-polyfill (https://babeljs.io/docs/usage/polyfill/) before importing and initializing Marquee3k:
import 'babel-polyfill';
import Marquee3k from 'marquee';

Ran into this issue too.  Following the instructions from @MikeMcChillin worked.
But would like a real fix please @ezekielaquino  :D.

anyone with an marquee3000 just thats not in ES6? (does this make sense?)
the current one doesnt work transpiling(?) and im not sure how to make that work

I've been using the minified version because of errors with uglify.js (even though I'm transpiling with babel, I still get an error due to es6 syntax).
It seems like the error in Marquee3000 was caused by IE not supporting the Array.from function. To fix the IE issue, instead of using @babel/polyfill (which added a lot of bloat to my code) I instead added the Array.from polyfill from polyfill.io
Here's the script tag you'll need to add before your Marquee scripts -
<script src="https://cdn.polyfill.io/v2/polyfill.js?features=Array.from"></script>

If you're not familiar with polyfill.io, it's a cdn which detects what browser your'e using and determines whether your browser needs a polyfill or not. if you look at https://cdn.polyfill.io/v2/polyfill.js?features=Array.from in Chrome or Firefox, you'll see an almost empty file. If you look at the same file in an older browser like IE, you will see that you are served the polyfill script.
The downside is that your site will have to make an external request to polyfill.io just for the sake of supporting IE which you may not like. You might want to write a more clever solution with actual feature detection instead, but using polyfill.io this is a pretty easy alternative.


PI-SPI-DIN-4FREQ Frequency / Pulse Counter

Hello,
I try to use the PI-SPI-DIN-4FREQ module but i can't do it.
I succeed to use the Pi-SPi-DIN-RTC-RS485 ad the PI-SPI-DIN-4KO module.
I made the configurations of this page "https://widgetlords.com/pages/getting-started-with-pi-spi-libraries"
But when i run the demo python script pi_spi_din_4freq_demo.py , the output is :

Channel 1 frequency: -1 Hz
Channel 2 frequency: -1 Hz
Channel 3 frequency: -1 Hz
Channel 4 frequency: -1 Hz
Channel 1 pulses: -1
Channel 2 pulses: -1
Channel 3 pulses: -1
Channel 4 pulses: -1
DI: 255
Channel 1 frequency (variable): -1 Hz
Channel 2 frequency (variable): -1 Hz
Channel 3 frequency (variable): -1 Hz
Channel 4 frequency (variable): -1 Hz

This CE jumper is on "CE0" and the ADDR Jumper is on " | | | " (all jumpers plugged)
Do you have you a technical documentation for the PI-SPI-DIN-4FREQ module ?
Do you have any tips ?

Do you have any other modules connected?
If so, do they have different CE settings?

Thanks for your interest.
I tried with and without a PI-SPI-DIN-4KO module but the issue is the same and the CE settings were different.
For your information :

linux kernel : 4.14.34-v7+ armv7l

/boot/config.txt  :

dtparam=audio=off
dtparam=i2c_arm=on
dtparam=spi=on
dtparam=i2c1=on
dtparam=i2c0=on
disable_touchscreen=1
dtoverlay=pi3-disable-bt
dtoverlay=vpe-2701c
dtoverlay=vpe-3011b
lcd_rotate=2
`

I removed the 3011b overlay and i rebooted the RPI but the issue is same.
:(

Can you help me ?
Do you have documentation for this module ?

My help will be limited unless I am able to reproduce the issue.
Have you tried using the PI-SPI-DIN-4FREQ module with the same CE setting that worked with the PI-SPI-DIN-4KO? Make sure to update the sample code accordingly.
All currently available documentation for this module is available here in the repository as source code and here


ngmodules.org - include 'npm install angular-highlightjs'

The ngmodules page, The Getting Started section, I think should contain:

npm install angular-highlightjs

I didn't read anywhere that this would install the directive, so I pretty much guessed and confirmed it was the same (it works). Just a suggestion for the ngmodules page which advertises this git repo and is the first google hit
Also, since this is such a short github issue I'm shamelessly going to plug my markdown editor/renderer that I made. this suggestion was for a change to a readme file anyway :P

Hey thanks @juliusakula !
The npm support was released on v0.4.0, and I forgot to add it to README.

BTW, I also updated the page on ngmodules, hope that would help people better understand the module.
It's so terrible that ngmodules' page doesn't support git-flavored markdown. :weary:

as an aside, I couldn't get angular-highlightjs to work with angular-md. my project is also open source so I can convienently link to the revelant files - so, quick question with context, if you look at mysrc/views/hompage.tpl.hmtl you can see the rendered markdown is pretty much:

Is there a way I can have the $scope.text variable have the syntax highlighting in the same manner?

It's like
<div hljs source="text"></div>

I guess ?


Correlation or Association rule of phrases and answers to them

Maybe i am  asking in the wrong  topic, but maybe someone will hint where to look for research by this task(github or kaggle).
I try find methods, methodology to create predicative model. Namely, I want to investigate the relationship between the sentences and the answer to them. For example when person communicate they often say
person1:Hi, how are you?
person2:Fine, thank you.
In some sense, this is a correlation between the text and or the rules of associations and answer phrases, if the phrase is  x then answer is y
I have big dataset with dialogs between people (~100Gb txt files with different dialogs of daily speech) What method in line of Text Mining can I use to learn that if one person said such a phrase, then on this phrase is usually answered with such a phrase (or a set of words)?
any help appreciated

Closed as off topic. You might want to look at NLTK and/or scikit-learn.


Add literev as a partner

@EverVino I am adding the literev logo as a partner.
next I will add the logo of osl to literev page

@EverVino  , I am also updating the email as well


can't enable menu-bar-mode

when i enable menu-bar-mode, I get an error
Debugger entered--Lisp error: (wrong-type-argument arrayp nil)   undo-tree-current(nil)   (undo-tree-node-previous (undo-tree-current buffer-undo-tree))   (and undo-tree-mode (not buffer-read-only) (not (eq t buffer-undo-list)) (undo-tree-node-previous (undo-tree-current buffer-undo-tree)))   redisplay_internal\ \(C\ function\)()
my emacs version : 25.3.1
os: deepin linux 15

I occasionally see a similar error on other functions.
Does this happen on any other functions? If so, as far as I can tell, this sometimes occurs if the desktop file does not save correctly. Quickest repair is:

Shut down Emacs
Delete the saved desktop (usually $HOME/.emacs.d/.emacs.desktop)
Start Emacs

I'm not able to reproduce this, sorry, so I'm not really sure how to help.

I found that when commented (require 'init-gui-frames) in the init.el file, I can enable menu-bar-mode.
I checked out to the commit  4e487d4ef2ab39875d96fd413fca3b075faf9612 . On this commit，there is no conflict between menu-bar-mode and undo-tree.
I got this problem on windows7 and linux .
Here is what I do:
I  clone the master branch from github, start emacs ,then type "M-x menu-bar-mode" , then I got this error .

I have a similar issue. After replacing undo-tree with the latest version 0.6.6, it is fixed.

I have a similar issue. After replacing undo-tree with the latest version 0.6.6, it is fixed.

This solve the problem for me, thanks


AzureBackup support for backend

Adding a new customer type in Hydra to support the backend service upgrade.

Hi @dragonfly91, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;


Liberty merge into Mitaka

What issues does this address?
Merging changes from Liberty branch into Mitaka
What's this change do?
Adds singlebigip tests to the functional test suites.

@richbrowne I'm +1 on this.   I talked with @dflanigan about it yesterday.
I made one small simplifying change to the codebase a week or two ago.  I spoke with @jlongstaf about it at the time.   It was to remove the "CertManagerBase" class and module (not 100% that's the exact name).   The main effect was to slightly simplify things since that class was effectively unused.
Here's the PR for that if anyone wants to review:  https://github.com/F5Networks/f5-openstack-agent/pull/546


Fix QuickNav Preview scrolling issue on iOS mobile device

Bug/issue #, if applicable: 108269711
Summary
Fixes the QuickNav Preview scrolling issue on iPad, by adding exclusion zones to the scroll-locking.
This should be carefully merged with #634
Dependencies
NA
Testing

Open the app on iPad and then toggle QuickNav
Search for something vague, so you can see a scroll area for the content and suggestions
Assert you can scroll both while the background is still not scrollable.

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran npm test, and it succeeded
[x] Updated documentation if necessary

This should be carefully merged with https://github.com/apple/swift-docc-render/pull/634

Does it depend on that PR to work or are you just calling that out? Just checking.

Does it depend on that PR to work or are you just calling that out since they're so closely related? Just checking.

That PR just moves the scrollable area to another element, so the data attribute would have to be moved there too.

@swift-ci test

@swift-ci test


Feature Suggestion: Plain text markdown/Org interface.

The basic is that i can use Emacs/Vim or some other more rational editor and edit text in markdown/org-mode. Ideally i want to be able to 'connect' to the document to edit it, and when i make changes, the windows client and the word document is updated/recreated.
Not sure how close to the actual implementation this is, but would it be possible to use python-docx to control MS word like this?

I think this is the same as #49, isn't it?

Not quite, my concept was more 'live' than post processing a markdown file, i can do some of that with pandoc. I will close this though and check into the possibilities for re-use.


mkcloud: DO NOT MERGE THIS FAKE PULL REQUEST

its just for testing - DO NOT MERGE

-1 please provide unittest

Still no unittests but I added a bar. It should be possible to order drinks now.

Still no unittests but I added a bar. It should be possible to order drinks now.

LBTM
i tried to order a drink, but i got nothing. so i went to the crowbar

This was the first automatic mkcloud self-gating run.

Woooo! :)

Now rebuilding all open PRs. All are pending.
Unfortunately we only have one mkcloud worker currently as the github-status.rb does not work on SLE11SP3. But we wanted to migrate the 2nd host anyway.

Unfortunately we only have one mkcloud worker currently as the github-status.rb does not work on SLE11SP3. But we wanted to migrate the 2nd host anyway.

Why does it not work there?

@tboerger current octokit requires ruby > 1.9.$something , and with older octokit versions various errors raise. A we wanted to update the node anyway, I think we should not invest much time here.


[Event Request] Codeunit 221 Resource-Find Price

The following events are required for this object:
    [IntegrationEvent(false, false)]
    local procedure OnAfterCopyResourcePrice(ResourcePrice: Record "Resource Price"; var Res: Record Resource)
    begin
    end;

    trigger OnRun()
    begin
        ResPrice.Copy(Rec);
        OnAfterCopyResourcePrice(Rec, Res); //EVENT REQUEST
        with ResPrice do
            if FindResPrice then
                ResPrice := ResPrice2
            else begin
                Init;
                Code := Res."No.";
                "Currency Code" := '';
                "Unit Price" := Res."Unit Price";
            end;
        Rec := ResPrice;
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 12404.


Support other methods of configuring a TaskScheduler

Goal
The Spring Notifier sets an ErrorHandler on the application's TaskScheduler, which is required to capture unhandled exceptions that occur in scheduled tasks. This is configured via a SchedulingConfigurer which is invoked on application startup.
Previously the notifier assumed that if the taskRegistrar.getScheduler() returned null, then no TaskScheduler was configured. The notifier therefore set a custom TaskScheduler with a bugsnag error handler, and a single-threaded Executor. However, this misses two alternative methods for configuring a scheduler that Spring provides:

exposing a TaskScheduler bean
exposing a ScheduledExecutorService bean

This led to a scenario where an application defined an Executor with a thread pool of 4, which was reset to a thread pool of 1 when bugsnag-spring was included, which meant the scheduled tasks did not run successfully.
This proposed changeset alters the notifier to handle these two cases.
Changeset
This changeset is currently delivered in 3 separate commits, which are easiest to review in isolation:

Add mazerunner coverage for unhandled exceptions in scheduled tasks, where the TaskScheduler has been configured in different ways: https://github.com/bugsnag/bugsnag-java/commit/88ceab29ffe60df7f9f50b2dd008643ed8c39b54

Resolve the TaskScheduler and ScheduledExecutorService beans in the default BeanFactory: https://github.com/bugsnag/bugsnag-java/commit/feb849f300523132a0ff2246b668318e6225cb14

Fix ScheduledTaskConfiguration to search for beans before overriding the TaskScheduler: https://github.com/bugsnag/bugsnag-java/commit/f3456773930a3fb921937fb30f61e5f6eccd5749

Tests
New mazerunner and unit tests have been added, as described above.
Additionally, I have manually tested an example app to ensure that defining TaskScheduler and ScheduledExecutorService beans results in them being set as the TaskScheduler in the ScheduledTaskConfiguration class.

I have added an additional mazerunner scenario that tests a TaskScheduler can be resolved by name, if multiple beans of the same type are available.

After discussion with Simon, it was decided that getting the maze scenarios running on a plain Spring app is not something we need to do right now.


test: refactor to benchmark suite and add test-benchmark target

https://github.com/runfinch/finch/issues/345
Description of changes:
Refactor to benchmark suite so we can insert vm init between vm benchmark and container benchmark.
Testing done:
✗ make test-benchmark-container
cd benchmark/container && go test -ldflags "-X github.com/runfinch/finch/pkg/version.Version=v0.6.0-2-g4b15328.modified -X github.com/runfinch/finch/pkg/version.GitCommit=4b15328755164eeea3549dbc02926e0fd4e1e14f.m" -bench=. -benchmem --installed="false"
goos: darwin
goarch: arm64
pkg: github.com/runfinch/finch/benchmark/container
BenchmarkContainer/BenchmarkContainerRun-8                     3         429230791 ns/op                 1.822 %cpu_avg/op         41.41 %cpu_peak/op               0.4292 cpu_seconds/op       -2730 disk_bytes/op           27608 B/op           464 allocs/op
BenchmarkContainer/BenchmarkImageBuild-8                       1<PHONE_NUMBER> ns/op                 1.396 %cpu_avg/op         85.71 %cpu_peak/op               1.688 cpu_seconds/op      5341184 disk_bytes/op           83360 B/op          1668 allocs/op
PASS
ok      github.com/runfinch/finch/benchmark/container   12.491s

✗ make test-benchmark-vm
cd benchmark/vm && go test -ldflags "-X github.com/runfinch/finch/pkg/version.Version=v0.6.0-2-g4b15328.modified -X github.com/runfinch/finch/pkg/version.GitCommit=4b15328755164eeea3549dbc02926e0fd4e1e14f.m" -bench=. -benchmem --installed="false"
goos: darwin
goarch: arm64
pkg: github.com/runfinch/finch/benchmark/vm
BenchmarkVM/BenchmarkVMInit-8                  1<PHONE_NUMBER>7 ns/op                1.473 %cpu_avg/op             100.0 %cpu_peak/op          68.26 cpu_seconds/op<PHONE_NUMBER> disk_bytes/op         3097904 B/op      65977 allocs/op
BenchmarkVM/BenchmarkVMStart-8                 1<PHONE_NUMBER>8 ns/op                1.143 %cpu_avg/op             100.0 %cpu_peak/op          23.87 cpu_seconds/op       1945600 disk_bytes/op         1079840 B/op      23035 allocs/op
PASS
ok      github.com/runfinch/finch/benchmark/vm  177.623s

✗ make test-benchmark
cd benchmark/all && go test -ldflags "-X github.com/runfinch/finch/pkg/version.Version=v0.6.0-2-g4b15328.modified -X github.com/runfinch/finch/pkg/version.GitCommit=4b15328755164eeea3549dbc02926e0fd4e1e14f.m" -bench=. -benchmem --installed="false"
goos: darwin
goarch: arm64
pkg: github.com/runfinch/finch/benchmark/all
BenchmarkAll/BenchmarkVMInit-8                 1<PHONE_NUMBER>0 ns/op                0.9251 %cpu_avg/op            100.0 %cpu_peak/op          70.06 cpu_seconds/op<PHONE_NUMBER> disk_bytes/op         3175968 B/op      67751 allocs/op
BenchmarkAll/BenchmarkVMStart-8                1<PHONE_NUMBER>0 ns/op                1.204 %cpu_avg/op             100.0 %cpu_peak/op          23.54 cpu_seconds/op        942080 disk_bytes/op         1066296 B/op      22697 allocs/op
BenchmarkAll/BenchmarkContainerRun-8           3         425348166 ns/op                 2.545 %cpu_avg/op              44.17 %cpu_peak/op          0.4253 cpu_seconds/op           0 disk_bytes/op           27061 B/op        459 allocs/op
BenchmarkAll/BenchmarkImageBuild-8             1<PHONE_NUMBER> ns/op                 0.5392 %cpu_avg/op             31.08 %cpu_peak/op          3.013 cpu_seconds/op      3842048 disk_bytes/op          144184 B/op       2941 allocs/op
PASS
ok      github.com/runfinch/finch/benchmark/all 240.898s

[ X ] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Maybe out of scope, but you might want to delete the persistent volume before/after the container tests, or between tests in general.
LGTM other than the comments I left

Is it necessary to delete persistent volume? I already removed the container and image.

Maybe out of scope, but you might want to delete the persistent volume before/after the container tests, or between tests in general.
LGTM other than the comments I left

Is it necessary to delete persistent volume? I already removed the container and image.

It's probably not strictly necessary, but there could be other things cached in nerdctl's data stores from previous runs of the e2e tests or benchmarks. Also, when you run vm init, it technically takes time to create a new persistent volume (but this will never happen if you already have a persistent volume).
It's up to you, I don't really have a strong opinion one way or the other. You may or may not notice weird bugs in the future if there are any issues with lingering images/containers/layers, but I guess we don't need to address that until it actually happens.

Maybe out of scope, but you might want to delete the persistent volume before/after the container tests, or between tests in general.
LGTM other than the comments I left

Is it necessary to delete persistent volume? I already removed the container and image.

It's probably not strictly necessary, but there could be other things cached in nerdctl's data stores from previous runs of the e2e tests or benchmarks. Also, when you run vm init, it technically takes time to create a new persistent volume (but this will never happen if you already have a persistent volume).
It's up to you, I don't really have a strong opinion one way or the other. You may or may not notice weird bugs in the future if there are any issues with lingering images/containers/layers, but I guess we don't need to address that until it actually happens.

I see. Benchmarking should measure whatever the users experience daily. If something is cached in persistent disk, as users don't clean up persistent disk daily, it also applies to the users. So I think we can start from the direct scenarios now and add cleaner scenarios later if needed.

I see. Benchmarking should measure whatever the users experience daily. If something is cached in persistent disk, as users don't clean up persistent disk daily, it also applies to the users. So I think we can start from the direct scenarios now and add cleaner scenarios later if needed.

I agree with that generally, but you also want to have a static reference point so that benchmarks can be compared over time. If there is any corruption or weird artifacts left on the persistent disk over time, it may skew the benchmark results. We don't need to act on that right now though, we can wait and see if that type of issue presents itself first.


CRS strconv.Atoi: parsing tx.blocking_outbound_anomaly_score: invalid syntax

Description
With Core Rule Set ver.4.0.0-rc1 I'm seeing Coraza log an error when parsing the RESPONSE-980-CORRELATION.conf rule. I have tested this with Coraza v3.0.4 and also pinning to a specific commit https://github.com/corazawaf/coraza/commit/2624bf31de378fffc793bdc738240062f7fdf6f1
Steps to reproduce
Send an HTTP request that triggers an interrupt through Coraza with the default config + core ruleset 4.0.0-rc1
	cfg := coraza.NewWAFConfig().
		WithDirectivesFromFile(directivesDir + "coraza.conf").
		WithDirectivesFromFile(directivesDir + "coreruleset-4.0.0-rc1/crs-setup.conf").
		WithDirectivesFromFile(directivesDir + "coreruleset-4.0.0-rc1/rules/*.conf").
		WithDirectives(`SecDebugLogLevel ` + fmt.Sprintf("%d", logLevel)).
		WithDebugLogger(adapter)
        wafInstance, err := coraza.NewWAF(cfg)
	if err != nil {
		return nil, err
	}
        ...
        tx := wafInstance.NewTransactionWithID(req.GetId())
	defer func() {
		tx.ProcessLogging()
		tx.Close()
	}()

	tx.ProcessConnection(req.GetIp(), 0, req.GetHost(), 0)
	tx.ProcessURI(req.GetPath(), req.GetMethod(), req.GetProtocol())

	for k, v := range req.Headers {
		tx.AddRequestHeader(k, v)
	}

	if it := tx.ProcessRequestHeaders(); it != nil {
        ...

Actual result
a-analyze-1         | 2023-10-13T12:32:09.101Z	DEBUG	logger/waf_adapter.go:147	Evaluating rule	{"tx_id": "req_01hcmgbma0et7tnygqn81ntbkh", "rule_id": 980099}
a-analyze-1         | 2023-10-13T12:32:09.101Z	DEBUG	logger/waf_adapter.go:147	Forcing rule to match	{"tx_id": "req_01hcmgbma0et7tnygqn81ntbkh", "rule_id": 980099}
a-analyze-1         | 2023-10-13T12:32:09.101Z	DEBUG	logger/waf_adapter.go:147	Evaluating action	{"tx_id": "req_01hcmgbma0et7tnygqn81ntbkh", "action": "t"}
a-analyze-1         | 2023-10-13T12:32:09.101Z	DEBUG	logger/waf_adapter.go:147	Evaluating action	{"tx_id": "req_01hcmgbma0et7tnygqn81ntbkh", "action": "nolog"}
a-analyze-1         | 2023-10-13T12:32:09.101Z	DEBUG	logger/waf_adapter.go:147	Evaluating action	{"tx_id": "req_01hcmgbma0et7tnygqn81ntbkh", "action": "noauditlog"}
a-analyze-1         | 2023-10-13T12:32:09.101Z	DEBUG	logger/waf_adapter.go:147	Evaluating action	{"tx_id": "req_01hcmgbma0et7tnygqn81ntbkh", "action": "setvar"}
a-analyze-1         | 2023-10-13T12:32:09.102Z	DEBUG	logger/waf_adapter.go:147	Action evaluated	{"tx_id": "req_01hcmgbma0et7tnygqn81ntbkh", "var_key": "blocking_anomaly_score", "var_value": "tx.blocking_inbound_anomaly_score", "rule_id": 980099}
a-analyze-1         | 2023-10-13T12:32:09.102Z	DEBUG	logger/waf_adapter.go:147	Evaluating action	{"tx_id": "req_01hcmgbma0et7tnygqn81ntbkh", "action": "setvar"}
a-analyze-1         | 2023-10-13T12:32:09.102Z	DEBUG	logger/waf_adapter.go:147	Action evaluated	{"tx_id": "req_01hcmgbma0et7tnygqn81ntbkh", "var_key": "blocking_anomaly_score", "var_value": "+tx.blocking_outbound_anomaly_score", "rule_id": 980099}
a-analyze-1         | 2023-10-13T12:32:09.102Z	ERROR	logger/waf_adapter.go:147	Invalid value	{"tx_id": "req_01hcmgbma0et7tnygqn81ntbkh", "var_value": "+tx.blocking_outbound_anomaly_score", "rule_id": 980099, "error": "strconv.Atoi: parsing \"tx.blocking_outbound_anomaly_score\": invalid syntax"}
a-analyze-1         | a/a-decide/internal/logger.(*ZapEvent).Msg
a-analyze-1         | 	/app/internal/logger/waf_adapter.go:147
a-analyze-1         | github.com/corazawaf/coraza/v3/internal/actions.(*setvarFn).evaluateTxCollection
a-analyze-1         | 	/go/pkg/mod/github.com/corazawaf/coraza/v3@v3.0.5-0.20231011104936-2624bf31de37/internal/actions/setvar.go:158
a-analyze-1         | github.com/corazawaf/coraza/v3/internal/actions.(*setvarFn).Evaluate
a-analyze-1         | 	/go/pkg/mod/github.com/corazawaf/coraza/v3@v3.0.5-0.20231011104936-2624bf31de37/internal/actions/setvar.go:115
a-analyze-1         | github.com/corazawaf/coraza/v3/internal/corazawaf.(*Rule).matchVariable
a-analyze-1         | 	/go/pkg/mod/github.com/corazawaf/coraza/v3@v3.0.5-0.20231011104936-2624bf31de37/internal/corazawaf/rule.go:436
a-analyze-1         | github.com/corazawaf/coraza/v3/internal/corazawaf.(*Rule).doEvaluate
a-analyze-1         | 	/go/pkg/mod/github.com/corazawaf/coraza/v3@v3.0.5-0.20231011104936-2624bf31de37/internal/corazawaf/rule.go:220
a-analyze-1         | github.com/corazawaf/coraza/v3/internal/corazawaf.(*Rule).Evaluate
a-analyze-1         | 	/go/pkg/mod/github.com/corazawaf/coraza/v3@v3.0.5-0.20231011104936-2624bf31de37/internal/corazawaf/rule.go:172
a-analyze-1         | github.com/corazawaf/coraza/v3/internal/corazawaf.(*RuleGroup).Eval
a-analyze-1         | 	/go/pkg/mod/github.com/corazawaf/coraza/v3@v3.0.5-0.20231011104936-2624bf31de37/internal/corazawaf/rulegroup.go:219
a-analyze-1         | github.com/corazawaf/coraza/v3/internal/corazawaf.(*Transaction).ProcessLogging
a-analyze-1         | 	/go/pkg/mod/github.com/corazawaf/coraza/v3@v3.0.5-0.20231011104936-2624bf31de37/internal/corazawaf/transaction.go:1257
a-analyze-1         | a/a-decide/internal/analyze.(*analyzer).Analyze.func1
a-analyze-1         | 	/app/internal/analyze/waf_analyzer.go:88
a-analyze-1         | a/a-decide/internal/analyze.(*analyzer).Analyze
a-analyze-1         | 	/app/internal/analyze/waf_analyzer.go:109
a-analyze-1         | a/a-decide/internal/processing.(*analyzeService).Analyze
a-analyze-1         | 	/app/internal/processing/analyse_service.go:47
a-analyze-1         | main.main
a-analyze-1         | 	/app/cmd/analyze/main.go:186
a-analyze-1         | runtime.main
a-analyze-1         | 	/usr/local/go/src/runtime/proc.go:267

Hi @davidmytton, thanks for reporting it. It seems like you are facing some problems related to variable expansion. The value is indeed the string name "+tx.blocking_outbound_anomaly_score" rather than its real numeric value.
I'm trying to reproduce it, but I'm not succeeding. This is the branch where I'm trying to follow your steps: https://github.com/M4tteoP/coraza/tree/atoi_repro.
Would you be able to provide a branch starting from that branch that reproduces the issue?
I did the following steps:

Added the whole coreruleset-4.0.0-rc1 under examples/http-server
Did little tweaks to the main.go adding the whole coreruleset and a debug logger.

Thanks for your help

Thanks for looking into this @M4tteoP
I pushed 76aee6e which reproduces the issue from your branch with a test rule a-suspicious.conf that triggers on a specific header: curl -H 'x-a-suspicious: true' http://localhost:8090 but only in certain circumstances.

I have written a zap adapter for logging. Without the zap adapter it does not error.
If you disable the CRS rules and just use your default.conf and my a-suspicious.conf then the header triggers the WAF and does not error (including with my zap adapter enabled).
So it seems to be a combination of CRS + a-suspicious.conf + the custom zap logging adapter.

Interested to hear your thoughts on whether this is an issue in the zap adapter or whether there's something else going on. Seems like CRS has something to do with it given my zap adapter works fine without CRS.

Thanks for your repro example! As far as I can see, the root cause of the issue is a misconfiguration originated by the rules order. Specifically by the a-suspicious.conf file added before the CRS rules.
The inclusion order of your rules files is the following:

coraza.conf
a-suspicious.conf
coreruleset-4.0.0-rc1/crs-setup.conf
coreruleset-4.0.0-rc1/rules/*.conf

Expanding it a little:

coraza.conf
a-suspicious.conf

rule id:10000000 ← phase:1 custom rule with deny action

coreruleset-4.0.0-rc1/crs-setup.conf
coreruleset-4.0.0-rc1/rules/*.conf

REQUEST-901-INITIALIZATION.conf

rule id: 901200 ← phase:1

...
RESPONSE-980-CORRELATION.conf

rule id:980099 ← phase:5 (log phase)
...

Rules are executed following the inclusion order according to phases, so, within each phase, the order of rules matters. In your specific case, the a-suspicious.conf file, with rule id:10000000 is set before the CRS rules, and specifically, before the initialization rules of the CRS. These rules are the ones in charge of initializing the interval variables. E.g. rule 901200 has the following actions:
    setvar:'tx.blocking_inbound_anomaly_score=0',\
    setvar:'tx.detection_inbound_anomaly_score=0',\
    setvar:'tx.inbound_anomaly_score_pl1=0',\
    setvar:'tx.inbound_anomaly_score_pl2=0',\
    setvar:'tx.inbound_anomaly_score_pl3=0',\
    setvar:'tx.inbound_anomaly_score_pl4=0',\

So, the following happens:

Request headers are received, phase:1 rules are triggered
Following the inclusion order of phase 1 rules, the custom rule id:10000000 is executed very early. It is triggered, alongside its disruptive deny action.
Being a deny action triggered, the subsequent rules are skipped. Notably, also initialization rules, like the 901200 will not be executed.
phase:5 is the logging phase. It is a special phase in which the rules are executed at the end of each transaction, no matter what happened in the previous phases. Here we have rule id:980099 which is trying to rely on variables that have not been initialized with actions like setvar:'tx.blocking_anomaly_score=+%{tx.blocking_outbound_anomaly_score}'.
When a variable is not found, the returned value is the variable name itself, therefore the value becomes +tx.blocking_outbound_anomaly_score  (as we can see from your initial logs). At this point, the code tries to perform an arithmetical operation, trying to convert whatever is after the plus sign into an integer.
Here is where the strconv.Atoi raises the conversion error.

To recap: custom rules should be added after the CRS rules, or integrated into the CRS order logic. To grasp a bit more about rules positioning, a nice reference is https://github.com/coreruleset/template-plugin#order-of-rules-with-plugins-and-existing-crs-rules. It is about extending the CRS with custom plugins (aka extra rules), and current limitations of the CRS plugin architecture.
Digging into this I opened https://github.com/corazawaf/coraza/pull/892. I think that we should at least be a bit more verbose when this error happens, clearly stating that a variable has not been found. Among other small fixes and improvements, the PR proposes to add a warning log in that case.

I have written a zap adapter for logging. Without the zap adapter it does not error.

Just for the sake of completeness, I added https://github.com/corazawaf/coraza/commit/980737f1b4b42f13a572700c4af8db776e35feb4 in which I'm able to reproduce the Atoi error even without the zap adapter. The only difference I saw is that with a smaller logger, the error is limited to a single error line, not including the full trace printed with the Zap adapter.

Thanks for the detailed explanation, that makes sense. Moving the custom rule after CRS resolves this! The extra debug info in #892 will also be helpful.


Add linear Search

Hey @ankitapuri .. Can you please specify the language?

I'm interested to work on this issue.

Can I work on this?

Make a folder regarding it and then add code in these following along with README
Python
C++
Java
JavaScript
README.md file with explanation of the algorithm

In which language you will work @hridyakrishna @sifat009

In which language you will work @hridyakrishna @sifat009

I have given a pull request by creating a directory named Linear_search and added C programming code into it

I'll pick Java

https://github.com/ankitapuri/DSA-guide/pull/8

I'll pick Java

can we write in golang as well?

can i pick it for java if not assigned to anyone else?

can we write in golang as well?

no please

can i pick it for java if not assigned to anyone else?

its done

In which language you will work @hridyakrishna @sifat009

javascript.

In which language you will work @hridyakrishna @sifat009

javascript.

Ok and if possible create a readme for it so that I can close this issue


Feature: Add PostgreSQL/MySql?

I think this feature is quite good to add in wakatime

What does this even mean?


Screensize Y

Screensize function isnt give correct value on Y direction.

Check #630

What resolution you used?

Not fix, flexible. But Y coordinate bigger than 480.

I need to know what resolution you used, the Y packet sent by the clietn is not properly sent

What is a client? ClassicUO, OrionUO or original? When the client is first turned on, it will not receive this data from the sphere if you have not made any changes to the screen size. First you have to make a change and exit the game once. It depends on the client version you are using. It only sends the screen size directly in the latest client versions. This is entirely a client issue.

I use ClassicUO and resolution is 1542x1023.

Like that.

Can you try that sphere to see if works fine. Because as we can't do anything while Y value not sent by default clients we have to set default values but if your ClassicUO works fine I can add a Y == 0 condition to not set Y value on default values so, can you test that version and see if it works for you.
https://www.mediafire.com/file/1uls29llqyri55b/SphereSvrX64_nightly.rar/file

This package content works a little strangely, the Original client only sends the width value of the screen size, not the height, but since the ClassicUO client sends both height and width, the x and y data coming to the sphere are mixed. There are skips in between. This may be related to sphere's package content/length. The problem persists.


feat(autoware_auto_perception_rviz_plugin): add twist information for detected object on rviz

Description
Add twist information for detected object on rviz.
I would like to put off fixing from string label to one string, as mentioned point in https://github.com/autowarefoundation/autoware.universe/pull/1014 and https://github.com/autowarefoundation/autoware.universe/pull/1015.
For now, the changing point is same string label with TrackedObject and PredictedObject.

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@miursh
add TODO comment

@miursh
How about this PR?


Changing gizmo mode while modifying the current gizmo mode causes crash. #523

Fixes #523

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)


CLEAN (by Arktekko) documentation

Hello
I am trying to use the CLEAN architecture by Arktekko, but there is no documentation or any instruction how to use this architecture or Getx architecture.
Is there any that i didn't find??!
Or there is really no documentation for them??

@Katekko is responsible for the architecture. example here

Great
Thanks so much
I was looking for this for two days
Please add that link to readme file.

His clean architecture is great but if possible we need more explanation about what to put and where to put/implement things. Global layer such as domain,infrastructure and presentation are clear but for instance i don't know what to implement in dal folder. It would be great if @Katekko  can made some doc about it,based on getx_pattern made by @kauemurakami
Thanks for reading

Tq

any documentation or examples for clean architecture?.

Unfortunately I change this CLI for one that I made. So here will not have any support no more.
And I find a new way to do boilerplates, called Mason
https://www.youtube.com/watch?v=qjA0JFiPMnQ&ab_channel=Flutter
I will use this in the future. Sorry for delayed response.
If anyone wanna talk with me about anything related to flutter, just call me on my discord.
Katekko#1429

https://github.com/Katekko/ekko_app
This is deprecated.
Does mason compete against get_cli tool? Or coexist?

https://github.com/Katekko/ekko_app This is deprecated.
Does mason compete against get_cli tool? Or coexist?

I think so.
See the brick I created: https://github.com/Katekko/ekko_brick


Create ability to retrieve data only from selected hierarchies

It would be nice to have the functionality to only retrieve timeseries that are part of certain hierarchies. This is useful because hierarchies can be used to differentiate between timeseries that are "issue-free" and ready for data analysis and timeseries that are not yet ready for analysis.
One way to implement this is to pass a list of hierarchies as an optional argument to the getInstances() function, and have the filtering logic in that function.
This logic might already exist in Microsofts TSI apis, maybe it is possible to use a POST request with this url https://{environmentFqdn}/timeseries/instances?api-version=2018-11-01-preview and only retrieve the instances that have a certain hierarchy. I havent completely looked through that, it is described here: https://docs.microsoft.com/en-us/rest/api/time-series-insights/dataaccess(preview)/timeseriesinstances/search.
Another option would be to use the existing GET request in getInstances(), implement the filtering logic ourselves, and initially retrieve all instances, and then filter the results before returning on line 310 in TSIClient.py.

If we do the logic ourselves, we might want to do this generally, such that we can filter on any instance attribute and not just the hierarchy id. Meaning allow filtering on any of these instance attributes:
{
  "instances": [
    {
      "typeId": "9b84e946-7b36-4aa0-9d26-71bf48cb2aff",
      "name": "F1W7.GS1",
      "timeSeriesId": [
        "006dfc2d-0324-4937-998c-d16f3b4f1952",
        "T1"
      ],
      "description": "ContosoFarm1W7_GenSpeed1",
      "hierarchyIds": [
        "33d72529-dd73-4c31-93d8-ae4e6cb5605d"
      ],
      "instanceFields": {
        "Name": "GeneratorSpeed",
        "Plant": "Contoso Plant 1",
        "Unit": "W7",
        "System": "Generator System"
      }
    }
  ],
  "continuationToken": "aXsic2tpcCI6MTAwMCwidGFrZSI6MTAwMH0="
}


project member cannot use volumes

A project member should be able to view/list all the Persistent Volumes and StorageClasses in the cluster and Create/Read/Update/Delete persistent volume claims in their project(s).

Tested with latest 2.0 build from master
Project member is not able to list  Persistent Volumes and StorageClasses in the cluster.

Tested with latest build from master.
A project member/project owner is able to list Persistent Volumes and StorageClasses in the cluster and Create/Read/Update/Delete persistent volume claims in their project.
They are also able to deploy workloads using the volumes created from PVClaims.


Fix include matcher fuzzy matched key errors when encountering hash errors

When a class that looks like a hash but has custom behaviour (such as Racks header hash which case insensitively compares keys and always assumes its asked for keys with a downcase method) we currently still try to shortcut key lookup using key? which than fails for fuzzy matching using matchers, instead ignore that error and use the fallback method.

(This was released in 3.12.3)


virtual env and caching in dockerfile

balena python image goes out of its way to use the recent version of python which created a lot of issues installing grpcio wheel. It was becoming impossible to find a python wheel that matches balena image's glibc version and python 3.10. And building grpcio as part of 'pip install' take more than 1hr 40min.
Using a virtual env with debian provided python is the only solution that worked. Addionally added caching support to our github docker build workflow.
Acceptance Criterion

grpcio wheel gets used instead of setup.py
docker file uses cache from container registry

@pritamghanghas divide this up into multiple tickets. This sprint we will work on caching only.

@marvinmarnold When I looked at it for division, I realized that all the original concerns have been fulfilled already.


Add information on multi-clusters for Civo

What type of suggestions?
Missing Information
What page is concerned?
https://docs.kubefirst.io/civo/overview
What version of the docs?
2.3
What is the issue?
Add information on multi-clusters for Civo in the overview page, but also create a new page in the explore section about it.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Done


As a user, I want to see cards dued before some specific date in addition to showing for today

*** showdue command
- showdue d/1 m/1 y/1 s/dd-mm-yyyy
Use the date parser created in schedule command

#92

#129


Peer depend @types/form-data

Because @types/form-data is imported in index.d.ts it should also be installed by end-users writing in TypeScript otherwise compiling their projects will fail, assuming skibLibCheck compiler option is not set to true (which is default). Noticed this on my own project when I enabled lib checking again which resulted in this error:
$ yarn build && cross-env NODE_ENV=development node ./dist/app.js
$ yarn lint
$ eslint . --ext .js,.jsx,.ts,.tsx --fix
$ tsc
node_modules/sagiri/index.d.ts:2:27 - error TS7016: Could not find a declaration file for module 'form-data'. 'E:/dev/ribbon/node_modules/form-data/lib/form_data.js' implicitly has an 'any' type.  Try `npm install @types/form-data` if it exists or add a new declaration (.d.ts) file containing `declare module 'form-data';`

2 import * as FormData from 'form-data';
                            ~~~~~~~~~~~

Found 1 error.

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

and it gets fixed on end-user side with yarn add -D @types/form-data

I'm also just going to hijack my own PR with a question. Since I really like this library I would be willing to rewrite it entirely into TypeScript for you if you're interested. I've given this makeover to other libraries (immfranco/nintendo-switch-eshop and AtlasTheBot/booru) as well in the past and they liked the result. To give you an idea of how such a project would be structured you can check out my own template github repo which I use as the starter template for TS based libraries: https://github.com/favware/yarnts-template.
Naturally I would take your compilation climate into account, such as TravisCI, CodeClimate and Codacy, but you would gain

A lib written entirely in TS, obviously
It gets build and bundled by Rollup producing just about the most optimal bundle achievable
Tests using the Jest framework
Automatic doc generation using jsdoc-to-markdown - by default I personally put this in README but it can of course be placed in API.md
Probably more that I'm forgetting, just check the structure of the template

That all said, just let me know. I do have 1 requirement which is that we get a contact line on something like Discord or Twitter DMs as it's a far better way to ask questions than GitHub issues / PRs.

Hm.. The failing test is that it fails to find the token. That can't be fixed by me, I'm not sure how you've set up your TravisCI but ideally you would configure it as environment variable for Travis (I believe you can do that through the project settings) and use process.env.TOKEN (assuming you assigned the env var as TOKEN key).

Don't worry about the failing builds. This is a simply dependency update so I'll just merge it,
Thanks @Favna!

As for writing it entirely on TypeScript, be my guest.


Fix open source builds

Our ocamlbuild and ocpbuild builds broke due to some changes in Hack. This fixes.

@facebook-github-bot shipit-ninja

Normally, gabelevi, someone else should review and ship your pull request. However, we will trust that you know what you are doing. Shipping!

Thanks for importing.If you are an FB employee go to Phabricator to review internal test results.


Remove irrelevant hosting documentation

Page 404s, so LGTM. Also you were the one to commit it, so I'll trust you know what you're doing.


Add compute shader support to render-test and eliminate slang-eval-test

Right now we have:

render-test which drives the actual graphics APIs, and does minimal vertex/fragment shading

slang-eval-test which currently runs a trivial compute shader on CPU via the Slang "VM" layer

We should clean up and unify the solution as follows:

Add compute shader support to render-test using D3D11 and GL (the currently supported graphics APIs)

Add some mechanism by which a test compute shader can embed control directives (hidden in comments) that help set up the initial contents of buffers, output buffers to print on exit, etc.

Add an additional "graphics API" to render-test that uses the Slang VM API to load and run compute shaders. Making this work might involve revisions to the Slang API.

The end result of this will be that we are better set up to do end-to-end tests that don't involve image comparisons, and we can also support running more of those tests on CPU via the VM to work around the limitations of our CI setup.

In PR #225, @csyonghe added initial compute shader support to render-test.
The next step is to replace the current slang-eval-test by making the VM another back-end for render-test. I figure I should own that since the VM and the eval test are both my messes.

I had been keeping this open with the intention of adding the Slang "VM" as another backend for render-test. While I still want to do that at some point, it is clear that this issue isn't very high on the priority list, so it is better to consider the original issue closed by the work Yong did.


Move Geth to a plugin connected at runtime

removed coreth + geth dependency for the C-chain, still have nat + crypto dependencies

Added first past of nat traversal

Removed go-eth dependency for secp256k1

renamed db files to not repeat the package title

Added rpcdb, untested

Added rpcdb tests

removed defer from loop

cleaned up tests

Started working on the rpc chain VM

First pass of vm plugin support

Added http over grpc

added beta support for http handlers

updated vms for the rpcvms

Added error returns for factories

Added EVM back to the genesis

Added the EVM factory

Added EVM aliasing, fixed nil pointer bugs during shutdown

Added plugin folder

Removed plugins folder, add default params for the plugin dir

Added http RPC test

Added cascade evm genesis

Removed debug line

removed more debug lines

Cleaned up import statement

Changed default plugin dir to ./plugins

build evm plugin auto in the build script

Resolves #56


MudLink, MudPagination, MudSnackbarElement: Improve accessibility

Description

MudLink

Add aria-disabled=true when Disabled
Add role=button when OnClick has delegate
Always apply user attributes last so they take precedence

MudPagination

Use localizer for all aria labels
Other accessibility concerns not addressed in this PR

MudSnackbarElement

Add role=alert
Add aria-live=polite
Lightly format markup

How Has This Been Tested?

visually
Type of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (fix or improvement to the website or code docs)

Checklist

[X] The PR is submitted to the correct branch (dev).
[X] My code follows the code style of this project.
[ ] I've added relevant tests.

@igotinfected Got one more for ya :)

@henon Ready to review

Thanks!


Contributing.md

How/when to raise issue
PR style guidelines (storybook new ui components if PR requires it)
Adding Labels
Template: https://gist.github.com/PurpleBooth/b24679402957c63ec426

Also link somewhere in README as well as CONTRIBUTING to Jaco's magic update-all scripts gist for @polkadot deps. #139