initial code to serve and display tango viz

Adds initial viz for tango
notes:
the allennlp team wants no build steps (no typescript, no webpack, etc)
i have opted to use graphviz + d3 but not react
this is admittedly a v0 and if gets any more complex, should move to react (and possibly a build process where we make an artifact in npm. for this script to use)
still to do:
only showing the first run, but there are multiple runs (will be left for later)

FWIW, I am in favor of going through the effort to setup a build process. However, if you think we won't need to build much more than this or deal with extended maintenance on it I trust your judgement.
Some benefits to upgrading this project would be:

being able to better track versions of packages and monitor them for security vulnerabilities
having code that is more testable
getting to import things like varnish's theme colors
adding typescript to help self-document and potentially catch some errors

Our build should be able to spit out a compiled version that functions more or less like what you're hand writing here.

Minor UI suggestion: It would be nice to increase the contrast between the status (especially the green color) and the graph node box. Perhaps having the node box white would help?

FWIW, I am in favor of going through the effort to setup a build process. However, if you think we won't need to build much more than this or deal with extended maintenance on it I trust your judgement.

The issue is that there isn't a good place to put one. This repo is not primarily a website. It is primarily a tool to structure experiments and decompose them into reusable steps. We happen to use a local server to visualize your experiment.
There is no build process for the library. You just pip install it, and it copies some Python files into your site-packages directory. That's all. So when would we run the build?

FWIW, I am in favor of going through the effort to setup a build process. However, if you think we won't need to build much more than this or deal with extended maintenance on it I trust your judgement.

The issue is that there isn't a good place to put one. This repo is not primarily a website. It is primarily a tool to structure experiments and decompose them into reusable steps. We happen to use a local server to visualize your experiment.
There is no build process for the library. You just pip install it, and it copies some Python files into your site-packages directory. That's all. So when would we run the build?

we have decided to NOT have a build.
but if we did, we would build to npm and tango would act exactly the same.... no build IN tango

[ ] There should be a way to choose runs. There could be 100s of runs in a single workspace.
[ ] Copy and paste from the steps. I think it's more important to be able to select and Ctrl-C than having a button that copies things.
[ ] The UI blinks, probably because of the refreshes.
[ ] Running the UI consumes 50% of my CPU. The browser shows a warning about energy usage.
[ ] Dirk will read over the Python code, fix some things, make it pass tests
[ ] I think the way the code is written, the link to the results will be shown even if the step failed. This should not happen.
[ ] The date format isn't great for copy and paste. Can we use the browser default format? If not, can we default to YYYY-MM-DD?
[ ] Max render size is huge!
[ ] The otter in the background looks a bit broken with the transparency on. You can clearly see the pieces it's made of.

@jonborchardt 01f03435069ebf48830e9794454502dd4e51098c is all good?

[ ] When you mouse over a step, you get an empty pop-over window.
[ ] Dragging text to select it does not work. This is bad for copy and paste.
[ ] Double-clicking text to select it does work, but it also zooms in. It's hard to copy and paste.

@jonborchardt ^

[ ]  When you mouse over a step, you get an empty pop-over window.
[ ]  Dragging text to select it does not work. This is bad for copy and paste.
[ ]  Double-clicking text to select it does work, but it also zooms in. It's hard to copy and paste.

to copy text, simply click the text, and it will be added to your clipboard
dragging to select text is not possible, we would need to move to react.
the empty popover is ahrd but i might be able to hide it... i assume this is low pri @dirkgr

dragging to select text is not possible, we would need to move to react

That's a pretty big bummer. That's what people would expect.

to copy text, simply click the text, and it will be added to your clipboard

That's great functionality, but impossible to discover. Can you disable double-click-to-zoom? Double-clicking a word is the other common way of selecting it. Then people could do at least that.

the empty popover is ahrd but i might be able to hide it

I tried this, and the popover just said "hello". I thought, surely Jon doesn't think that saying "hello" in the popover is all that meaningful? Then I realized "hello" was the name of my step. 🤦🏻
This is a good workaround.

1- we can add a message when the user copies to clipboard
plop in this function
{
 var el = document.createElement("div");
 el.setAttribute("style","position:absolute;top:40%;left:20%;background-color:white;");
 el.innerHTML = msg;
 setTimeout(function(){
  el.parentNode.removeChild(el);
 },duration);
 document.body.appendChild(el);
}```

can in the click code, call

```tempAlert("Text copied to clipboard.",500);

2- we can change the tooltip to say Step: x (instead of just x)
On Tue, Nov 30, 2021 at 10:18 AM Dirk Groeneveld @.***>
wrote:

dragging to select text is not possible, we would need to move to react
That's a pretty big bummer. That's what people would expect.
to copy text, simply click the text, and it will be added to your clipboard
That's great functionality, but impossible to discover. Can you disable
double-click-to-zoom? Double-clicking a word is the other common way of
selecting it. Then people could do at least that.
the empty popover is ahrd but i might be able to hide it
I tried this, and the popover just said "hello". I thought, surely Jon
doesn't think that saying "hello" in the popover is all that meaningful?
Then I realized "hello" was the name of my step. 🤦🏻
This is a good workaround.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/allenai/tango/pull/79#issuecomment-982896907, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6QQEMBDTGCV2ON6SJX24DUOUIQHANCNFSM5H5L6Z7Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Cheers,
Jon Borchardt

That works, but it's super ugly. The text appears at a random spot on the canvas, without formatting or anything.

Ya, I can clean it up.
On Tue, Nov 30, 2021, 4:54 PM Dirk Groeneveld @.***>
wrote:

That works, but it's super ugly. The text appears at a random spot on the
canvas, without formatting or anything.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/allenai/tango/pull/79#issuecomment-983176164, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6QQEJWBOLFOWZTULJKLL3UOVW4TANCNFSM5H5L6Z7Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

WOOO!
On Wed, Dec 1, 2021 at 1:20 PM Dirk Groeneveld @.***>
wrote:

Merged #79 https://github.com/allenai/tango/pull/79 into main.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/allenai/tango/pull/79#event-5701867922, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6QQEOO727ZJ7IWKLCXHYDUO2GRXANCNFSM5H5L6Z7Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Cheers,
Jon Borchardt


[Raw API]: Unhandled error on running fixture without tests

1.testcafe
{
    "fixtures": [
        {
            "name": "1",
            "pageUrl": "http://mail.ru"
        }
    ]
}

testcafe version: 0.14.0-alpha3

It's by design. The main purpose of RAW API is that it intended to be created by machine, so we can avoid validation-related burden.

@miherlosev Then you should open issue in studio repo.

We decide to add in compiler a checking of not well formatted file structure.


Refactor the Button into a function component

Highlights:

Converted the button to function component.
Removed the onDisabledClick prop.
Made some improvement.

Closes: #4943

If this works for you, I can make this change!
Putting the value in the html is a nice idea, however the value attribute of button doesn't accept boolean, which is tricky to workaround. As you noticed its only in 5 places so not an insurmountable challenge. I'm just not sure which workaround is best. 🤷


Travis build failing

Travis build failing.

featured JavaScript Date library alive, maintained ...

I hope @abritinthebay is on holidays because I could really use his help in the next weeks :)

Alive and well but slammed with other (paying) work. :/


chore: update security monitor action workflows

Implemented option 1 from https://hpinc.kanbanize.com/ctrl_board/79/cards/12517/details/
I also removed review_requested event type because it seems redundant now that we won't be running the action on dependabot PRs and this way we'll trigger less workflows.
Also removed concurrency because I think it creates some difficulties queuing workflows and leaving them pending. Plus github has a note on docs saying Concurrency is currently in beta and subject to change. so there's no guaranty it works ok.

:tada: This PR is included in version 2.0.17 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Small change: remove unintentional whitespace

On other challenges, only the affected places would have a placeholder whitespace, if there is one. Leaving extra whitespaces might be confusing for some users. Removed the unnecessary ones from this challenge.

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the master branch of freeCodeCamp.
[X] None of my changes are plagiarized from another source without proper attribution.
[X] My article does not contain shortened URLs or affiliate links.

I think this change is fine.


NCDA Add a New page that shows all the 5 Child Scorecard Pillars

Issue
A page to list all the five pillars of Child Scorecard before starting the checklist.
TODO

Implementation of the page before the antenatal checklist
Add buttons that will direct to antenatal ckecklist

@LudmilaGoichman on Nutrition env.


Support multiple search results

Problem:

Typing in a query that matches multiple brothers will only return one result based on first match of nodes.find()

Proposed solution:

Populate list of all matches within nodes using nodes.filter()
Show indicator of multiple matches near search box
Add Next button or hit Enter to cycle through all results

I wonder, is this necessary? For example, if I search for nick and get the wrong one, I'll usually type in a last name. Do you have a scenario in mind for where my approach wouldn't be as natural a response?

It's not super high priority, but my issue with it is a matter of defined behavior: it seems nodes.find() will return an arbitrary match which doesn't seem like the best practice for a search function.

Fair point. Maybe after we change the internals to return multiple search results, we could score and order the results. Currently, sometimes the returned result isn't the best one (e.g., "jose" points to "Joseph Dominguez).


Adjust log fields

use app & version.
add container_name.
use appdynamics_app & appdynamics_tier labels.
override existing job files if it is the first run.

👍

:+1:


Values are not passed, if i download the file and simulate it

If i download the file and import the xcodeproject in xcode, there are no labels shown.
It doesnt show "one" "two" "three" on the watch and not 1, 2 or 3 on the iphone.
What's the problem here? I haven't changed any code.
It just doesn't work like the gif shows.
Thank you

You'll need to setup the project with your own App Groups and bundle identifiers for it to work correctly. There's some instructions for how to do this on the developer portal.
https://developer.apple.com/library/ios/documentation/General/Conceptual/ExtensibilityPG/ExtensionScenarios.html


Log stderr in get_latest_image_version_deb()

It was being suppressed needlessly. Also fix lots of linter issues.
Signed-off-by: Zack Cerza<EMAIL_ADDRESS>

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/teuthology-pull-requests/1381/
Tests passed for this pull request.


Create Hargun-Kaur.md

Notes for Reviewers

This PR fixes #

For ui changes: Please add a screenshot showcasing the UI before/after changes.

Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit 7bfcb556252ee7bf4df79fc04a76333e5cc5cb4f at: https://6723808ba52404886b8b2621--meshery-docs-preview.netlify.app


KeyPath observers not removed

Using version 1.0.0 installed via CocoaPods, when I dismiss a view controller that I presented with DeskTransition, I receive the following crash:
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'An instance 0x7fbb03e54680 of class UIView was deallocated while key value observers were still registered with it. Current observation info: <NSKeyValueObservationInfo 0x6080002373e0> (
<NSKeyValueObservance 0x608000243e40: Observer: 0x7fbb03c56370, Key path: frame, Options: <New: NO, Old: NO, Prior: NO> Context: 0x0, Property: 0x608000240120>
<NSKeyValueObservance 0x608000240660: Observer: 0x7fbb03c56370, Key path: transform, Options: <New: NO, Old: NO, Prior: NO> Context: 0x0, Property: 0x608000243750>
)'

I believe that these key path observations in DeckPresentationController.swift are never removed via removeObserver(_:forKeyPath:):
presentedViewController.view.addObserver(self, forKeyPath: "frame", options: [.initial], context: nil)
presentedViewController.view.addObserver(self, forKeyPath: "transform", options: [.initial], context: nil)

Thanks for all of your hard work on this!

Thank you for this find! For some reason I hadn't run into this in the example app or another app I'm working on. Fixed in 1.0.1, which should be out soon (already out on GitHub/Carthage, pod trunk push is processing as I type this).
Glad you like it! Feel free to post any further issues or requests on here!

👍


Constructor Deserialization Remote Code Execution

In backend/backend/pom.xml:1
https://github.com/bcgov/nr-spar/security/code-scanning/21
https://avd.aquasec.com/nvd/2022/cve-2022-1471/
https://www.veracode.com/blog/research/resolving-cve-2022-1471-snakeyaml-20-release-0

Closing as duplicate of #50


v0.1.2

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.671%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
297

Relevant Lines:
301

💛  - Coveralls


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v4.12 to before v5.12.13",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=51f3baad7de943780ce0c17bd7975df567dd6e14",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=d0760a4ef85697bc756d06eae17ae27f3f055401"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "51f3baad7de943780ce0c17bd7975df567dd6e14",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "d0760a4ef85697bc756d06eae17ae27f3f055401",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "can: mcba_usb: fix memory leak in mcba_usb\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.12.13 by commit d0760a4ef85697bc756d06eae17ae27f3f055401, it was introduced in version v4.12 by commit 51f3baad7de943780ce0c17bd7975df567dd6e14. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001077


⚠ Bofrost.be has degraded performance

In 15340dc, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1561 ms

Resolved: Bofrost.be performance has improved in 67ce7b5 after 10 minutes.


Inlay Hints: Improve hints for complex data types and arrays in particular

Suggestion

🔍 Search Terms

inlay hints
inlay hints array

Related: https://github.com/microsoft/TypeScript/issues/45295
✅ Viability Checklist

My suggestion meets these guidelines:

not relevant, this is about tooling

⭐ Suggestion

I've been told that this repo is the correct place to suggest such a feature (via https://github.com/typescript-language-server/typescript-language-server/issues/639).
Sometimes Inlay hints are too long and get cut off at some point (after 30 characters) and having the array braces at the end makes them very likely to be cut off despite it being the outer-most structure,
making it almost impossible to tell from the hint that this function returns an array (only from the leading (), whereas this would be easy if instead it showed : Array<{ key: string; tdC....
For reference, rust-analyzer does this more elegantly by leaving out details in the inner element if a configurable threshold of characters would otherwise be exceeded while still including all relevant punctuation for the outer types:

For this example, that would probably become  : Array<{ key: string; … }> or : ({ key: string; … })[] (depending on a configurable threshold).
📃 Motivating Example

The following example illustrates the current problem with not being able to tell (quickly) that the return type is an array.
:: --> LSP-volar textDocument/inlayHint(657): {'textDocument': {'uri': 'file:///File.vue'}, 'range': {'end': {'line': 129, 'character': 0}, 'start': {'line': 0, 'character': 0}}}
:: <<< LSP-volar 657: [{'kind': 1, 'position': {'line': 71, 'character': 23}, 'paddingLeft': True, 'label': ': ProductionSpecification[]'}, {'kind': 1, 'position': {'line': 79, 'character': 28}, 'paddingLeft': True, 'label': ': boolean'}, {'kind': 1, 'position': {'line': 82, 'character': 21}, 'paddingLeft': True, 'label': ': ({ key: string; tdClass: st...'}, {'kind': 1, 'position': {'line': 90, 'character': 63}, 'paddingLeft': True, 'label': ': Promise<void>'}, {'kind': 1, 'position': {'line': 91, 'character': 24}, 'paddingLeft': True, 'label': ': any'}]

💻 Use Cases

See above.

Rereading this, I missed to stress the point that I generally prefer the generic syntax for arrays, so making that configurable (like you can for eslint, for example) would be appreciated because I'm sure some people will think otherwise.


New Blocker - Prevent elevate on dnsonly

Since dnsonly is so simple to re-install, we should just block on it and encourage a new install with a link to a tech support doc on how to do this.

RE-91


Properly umount fuse when killing the process

It’s just a draft for fast review in #13239

@yabola  are you still working on this PR?

@apc999 right, but I want to confirm whether the idea of intercepting kill requests is appropriate or any other new idea on this issue.I will continue to complete this PR if it is an appropriate way.

@apc999 I remember that you took a look before and think that another function other than umount should be used?

@yabola
We don't have a pretty good idea of how to properly umount fuse, so would like to know what's the behavior before and after your changes? Have you tested your changes out in standalone fuse and worker fuse? what's the behavior looks like.

@LuQQiu
My test step:
set properties alluxio.fuse.umount.timeout=5s ->  mount fuse dir ->
vi fuse_dir/b.txt ->  find fuse JVM Pid -> kill pid
Before this PR:
fuse JVM is killed.  the file which i vi before show"fuse_dir/b.txt" E212: Can't open file for writing (i use :wq command)
After this PR:
fuse JVM is not killed.The fuse JVM acts normally as before.
now this PR only catch kill signal 15 (kill pid). it hadn't catch other kill signal like kill -9.

Codecov Report

Merging #13373 (a3b14a8) into master (65f804c) will decrease coverage by 19.27%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #13373       +/-   ##
=============================================
- Coverage     43.94%   24.66%   -19.28%
+ Complexity     8971     1377     -7594
=============================================
  Files          1362      516      -846
  Lines         78649    33179    -45470
  Branches       9541     4353     -5188
=============================================
- Hits          34560     8184    -26376
+ Misses        41164    24578    -16586
+ Partials       2925      417     -2508

Impacted Files
Coverage Δ

...thentication/AuthenticatedChannelClientDriver.java
0.00% <0.00%> (-75.35%)
:arrow_down:

...thentication/AuthenticatedChannelServerDriver.java
0.00% <0.00%> (-90.91%)
:arrow_down:

...rity/authentication/AuthenticatedUserInjector.java
0.00% <0.00%> (-43.91%)
:arrow_down:

...n/java/alluxio/jnifuse/AbstractFuseFileSystem.java
0.00% <0.00%> (ø)

...common/src/main/java/alluxio/grpc/GrpcService.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...common/src/main/java/alluxio/time/TimeContext.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mmon/src/main/java/alluxio/metrics/MetricInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mmon/src/main/java/alluxio/time/ThreadSleeper.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mon/src/main/java/alluxio/concurrent/LockMode.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mon/src/main/java/alluxio/shell/CommandReturn.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 1140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4abe1...a3b14a8. Read the comment docs.

@yabola this behavior looks good for the standalone fuse. When fuse is in the worker process, what's the behavior before and after your changes?
Basically we would want a solution that properly umount fuse in both standalone way and worker fuse. Ideally, when fuse device is busy, standalone fuse umount should be tricked as noop. Fuse in worker is a little tricky, we don't want the worker process components to be killed while the fuse mount is still there leaving the fuse mount in unusable state. We would rather force the fuse to be unmounted or prevent the whole worker process from exiting (trick worker process kill as noop). Not sure if it's possible

@LuQQiu
When fuse is in the worker process, it can act like standalone fuse . when use kill AlluxioWorker pid command, worker process kill as noop.

@LuQQiu @apc999
what's your opinions about that?

@yabola
When fuse is in the worker process, it can act like standalone fuse . when use kill AlluxioWorker pid command, worker process kill as noop.

Can you elaborate more on this line?  why worker process kill will be treated as noop? Fuse will directly capture the kill signal and prevent that? it will prevent Alluxio worker stop all other functionalities?

@LuQQiu
worker and  fuse is in one JVM when embedded-fuse worker started.SignalHandler is also registered in this JVM.  However, it can't catch kill -9 pid signal.

As long as we get the desired behavior, your design and initial draft LGTM.
Thanks for the detailed description.
One small question is about the umount(force), the force parameter doesn't look like doing anything useful.
For alluxio-stop.sh worker, we can add a force parameter, by default turn on to sync with the previous behavior, but user can pass in force=false to not trigger kill -9

@LuQQiu fine,I will complete my PR later~

Sorry for late. I have updated alluxio shell command as you said.
This is my test evidence.

mount fuse dir in worker
alluxio.worker.fuse.enabled=true
alluxio.worker.fuse.mount.alluxio.path=/fuse_data
alluxio.worker.fuse.mount.point=/Users/chenliang.lu/soft/alluxio_data/fuse_data

open operation on mount file
less /Users/chenliang.lu/soft/alluxio_data/fuse_data/b.txt

sh bin/alluxio-stop.sh -s worker  ---> won't kill worker
error message:
 Error, process [70125] did not complete after 120 seconds, failing to kill it.

Awesome!! @yabola Thanks for doing all the testing!!
The behavior LGTM!

@LuQQiu
My test evidence in alluxio-fuse shell command:
when device is busy,fail to kill:

when device is free, successfully kill it:

I am not sure if -s should apply to all processes. If it needs, I'm willing to update it.

can you help fix the conflicts as well? thanks!

@yabola Please modify the bin/alluxio-stop.sh usage as well, and add some related docs on the Alluxio POSIX API doc?

@yabola Can you help fix the integration/fuse/bin/alluxio-fuse umount output message while saying that the fuse is mounted but actually fuse is not mounted because fuse divice is busy?
Another question is about the -s soft kill option. I will prefer to apply it to all processes not only AlluxioWorker. @apc999 @ggezer what's your advice about adding a soft kill option that do not force all processes to be killed? do not kill -9 if kill -15 doesn't work

@LuQQiu I think that's fair. However, I'd like to get that done outside of this PR. ( Ideally this PR just rebases after that PR is merged.)

Sounds good @ggezer, do you prefer @yabola to work on adding the -s to all processes or other engineers?

Sounds good @ggezer, do you prefer @yabola to work on adding the -s to all processes or other engineers?

Whoever has bandwidth really :D
@yabola We'd appreciate if you could isolate this change into a separate PR complete with all processes.

Sounds good @ggezer, do you prefer @yabola to work on adding the -s to all processes or other engineers?

Whoever has bandwidth really :D
@yabola We'd appreciate if you could isolate this change into a separate PR complete with all processes.

@ggezer @LuQQiu Do you mean first pull a PR for -s option, then  to compete umount fuse option PR?  I am willing to compete it~~

I have updated my PR to add soft kill option to all process. I will separate PR into two PR.


White spaces in @NotEmpty annotation

Hi,
There is a simple issue that when I enter white spaces in a field that has the annotation @NotEmpty, validation rule just passes normally and no error is displayed, while the rule should fire validation error saying "This field is required".
Please advise.

厉害


_connect_rtpfunnel: assertion failed: (stream)

Hi,
when using Firefox for receiving video VP8, i get below error:
_connect_rtpfunnel: assertion failed: (stream)
With Debug level 6 for webrtc i also get:
16924 00000205F33F2280 INFO               webrtcbin gstwebrtcbin.c:3532:_set_description_task:<sendrecv> Attempting to set local answer in the have-remote-offer state
But using Chrome browser works.
Any idea why Chrome works and not with firefox?

I change my implementation, i was creating the offer from the client (browser) . Now i redid so that the gstreamer makes the offer and the browser answer instead. Solved alot problems.

I am using your demo as a reference and ran into this issue creating offers on the client (browser). This is my first time using gst. Do you have any ideas why this is happening/where to start with debugging?


Issue using StreamingResponse

Hello,
I tired to make an import similar to below in the docs
https://github.com/tiangolo/fastapi/blob/e77ea635777d2494690ba3eb62bd005b9edeefde/docs_src/custom_response/tutorial007.py#L2
but got the following
Traceback (most recent call last):
File "app/main.py", line 6, in <module>
from fastapi.responses import StreamingResponse
ModuleNotFoundError: No module named 'fastapi.responses'

The workaround I used was
from starlette.responses import StreamingResponse

I'm using fastapi==0.42.0 within docker

 from fastapi.responses import StreamingResponse works after 0.51.0.
Would suggest upgrading since there's a lot of other stuff you would need to import from starlette and not fastapi.

Thanks for the help @ArcLightSlavik ! 🍰
And thanks for closing the issue @ryan-wolbeck ☕

Sorry for the long delay! 🙈  I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.


Can we correctly use AdapterFusion for mBART?

I am trying to use AdapterFusion to fuse some adapters when having mBART as the core. But after adding AdapterFusion using model.add_adapter_fusion(adapter_setup[0]), it has added a BertFusion component as follows.
(layers): ModuleList(
(0): MBartEncoderLayer(
(self_attn): MBartAttention(
(k_proj): Linear(in_features=1024, out_features=1024, bias=True)
(v_proj): Linear(in_features=1024, out_features=1024, bias=True)
(q_proj): Linear(in_features=1024, out_features=1024, bias=True)
(out_proj): Linear(in_features=1024, out_features=1024, bias=True)
)
(self_attn_layer_norm): LayerNorm((1024,), eps=1e-05, elementwise_affine=True)
(fc1): Linear(in_features=1024, out_features=4096, bias=True)
(fc2): Linear(in_features=4096, out_features=1024, bias=True)
(final_layer_norm): LayerNorm((1024,), eps=1e-05, elementwise_affine=True)
(attention_adapters): BartSelfAttentionAdaptersModule(
(adapters): ModuleDict(
(si_ta): Adapter(
(non_linearity): Activation_Function_Class()
(adapter_down): Sequential(
(0): Linear(in_features=1024, out_features=512, bias=True)
(1): Activation_Function_Class()
)
(adapter_up): Linear(in_features=512, out_features=1024, bias=True)
)
(en_ta): Adapter(
(non_linearity): Activation_Function_Class()
(adapter_down): Sequential(
(0): Linear(in_features=1024, out_features=512, bias=True)
(1): Activation_Function_Class()
)
(adapter_up): Linear(in_features=512, out_features=1024, bias=True)
)
)
(adapter_fusion_layer): ModuleDict(
(si_ta,en_ta): BertFusion(
(dropout): Dropout(p=0.0, inplace=False)
(query): Linear(in_features=1024, out_features=1024, bias=True)
(key): Linear(in_features=1024, out_features=1024, bias=True)
(value): Linear(in_features=1024, out_features=1024, bias=False)
)
)
)
(output_adapters): BartOutputAdaptersModule(
(adapters): ModuleDict(
(si_ta): Adapter(
(non_linearity): Activation_Function_Class()
(adapter_down): Sequential(
(0): Linear(in_features=1024, out_features=512, bias=True)
(1): Activation_Function_Class()
)
(adapter_up): Linear(in_features=512, out_features=1024, bias=True)
)
(en_ta): Adapter(
(non_linearity): Activation_Function_Class()
(adapter_down): Sequential(
(0): Linear(in_features=1024, out_features=512, bias=True)
(1): Activation_Function_Class()
)
(adapter_up): Linear(in_features=512, out_features=1024, bias=True)
)
)
(adapter_fusion_layer): ModuleDict(
(si_ta,en_ta): BertFusion(
(dropout): Dropout(p=0.0, inplace=False)
(query): Linear(in_features=1024, out_features=1024, bias=True)
(key): Linear(in_features=1024, out_features=1024, bias=True)
(value): Linear(in_features=1024, out_features=1024, bias=False)
)
)
)
)
Is this correct?
Is 'BertFusion' just a name?

Hi @thisaltennakoon, this is expected. BertFusion is just the name of the module, it works with any of the supported model classes.

Thank You


show: use dot for wire aliases instead of BUF

The "BUF" display is confusing as it is easy to misinterpret as a $_BUF_ cell.

Probably best to mention this in the changelog since people can be used to reading the show graphs a certain way.


[Java] Makes tail initialisation atomic

A TermAppender fallen behind (ie in a past active partition), but that has already passed the backpressure check, could perform the claim when the tail is going to be reinitialised (ie the partition reactivated), hence the initialisation is needed to be atomic (a memory relaxed operation).
It is more likely to happen with a lot of producer threads (ie much more than the core count)and very small term capacity.

Thanks.

BTW it would only happen if the producer was 3 or more terms behind as the result of an interrupt taken between reading the active index and then the tail.

Got it! Just to know: what could happen to such claim if it will land right after an activation beyond the producer limit?

Can you try and ask the question another way? I don't quite understand.

Np, my fault: I'll try to explain it better.
Suppose to have a Publication::offer that go through the back-pressure check and is going to perform the (XADD) claim on the term.
Suppose that it will perform the claim right after the tail has been reinitialised by another producer, but in a termId different from the one used for the backpressure check.
(A) If the term will have enough capacity the offer operation will succeed.
Now, suppose to be already in a overclaiming scenario ie where multiple producers has already surpassed the backpressure check and were able to (over)claim until the end of a term: there will be a producer that will trip the term and perform the initialisation of the next term tail before changing the active term.
Other concurrent offers will fail by design and be backpressured (we are already beyond the producer limit!).
If a "late" claim (described in (A)) will land right after the tail initialisation there won't be any counter-measures to stop that offer to succeed. it is correct?


kubernetes-helm: 3.8.2 -> 3.9.0

Description of changes
https://github.com/helm/helm/releases/tag/v3.9.0
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 173533 run on aarch64-darwin 1

3 packages built:

kubernetes-helm
kubernetes-helm-wrapped
telepresence2


remove duplicated subprocess32 from setup.py

Already fixed in https://github.com/aldryn/aldryn-devsync/commit/d27f0150b8505e06f95df4980d043324ff8323ae


Solve issue with loading jvm when using AdoptJDK or Adoptium

I ran into the issue below when starting the adoptium temurin jre 8.0.312 with Janel.exe. For some reason a few random Windows machines wouldn't be able to locate the dlls awt.dll required.
java.lang.UnsatisfiedLinkError: jre\jre-temurin-8.0.312\bin\awt.dll: Can't find dependent libraries
	at java.lang.ClassLoader$NativeLibrary.load(Native Method)
	at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934)
	at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838)
	at java.lang.Runtime.loadLibrary0(Runtime.java:871)
	at java.lang.System.loadLibrary(System.java:1124)
	at java.awt.Toolkit$3.run(Toolkit.java:1636)
	at java.awt.Toolkit$3.run(Toolkit.java:1634)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.awt.Toolkit.loadLibraries(Toolkit.java:1633)
	at java.awt.Toolkit.<clinit>(Toolkit.java:1670)
	at java.awt.Component.<clinit>(Component.java:593)
	at javax.swing.ImageIcon$2.run(ImageIcon.java:130)
	at javax.swing.ImageIcon$2.run(ImageIcon.java:128)
	at java.security.AccessController.doPrivileged(Native Method)
	at javax.swing.ImageIcon.createNoPermsComponent(ImageIcon.java:127)
	at javax.swing.ImageIcon.access$000(ImageIcon.java:69)
	at javax.swing.ImageIcon$1.run(ImageIcon.java:103)
	at javax.swing.ImageIcon$1.run(ImageIcon.java:100)
	at java.security.AccessController.doPrivileged(Native Method)

With some Googling I found this thread https://github.com/adoptium/adoptium-support/issues/135 and with some trial and error this PR solves the issue.
I tried a few oracle JRE's aswell and this change doesn't seem to break anything.

Thank you very much for your contribution... and sorry that I saw your PR so late....

No problem, thanks for the merge :)


DataCollatorForCompletionOnlyLM defaults can create a model that never generates eos_token_id

Copied from: https://github.com/huggingface/trl/pull/456#issuecomment-1804665261
First of all - thanks for the great library
I have been trying to fine-tune some models using this collator, but the resulting model I created does not generate the stop token </s>. I have been using Mistral, which of course does not have a pad_token_id, so I set it to eos_token_id
Looking into the implementation DataCollatorForCompletionOnlyLM, I see that it inherits from CollatorForLanguageModeling, which sets label=-100 for all the pad tokens. Since we set the pad_token_id=eos_token_id, this means that the eos_token is getting a label of -100, meaning we never teach the model to end a sentence :). When I have been using the model I trained with this flow, I have been seeing that the model rarely (if ever) generates the eos_token. I wanted to flag this b/c I am sure many will face the same issue

Is it possible to set tokenizer.pad_token_id=tokenizer.bos_token_id as a workaround?

In concept, not backpropogating loss for bos_token_id seems okay (and I don't think there is any case where we ever end up predicting this token since it should only ever be the first token in the sequence with attention_mask=1). However, I am not sure if I don't know what I don't know

cc @tomaarsen can you elaborate more on how you subclassed DataCollatorForLanguageModeling and fixed your issue? 🙏

In my case, i used the vicuna's training solution which set pad token to unk token

Thanks a lot @tomaarsen for sharing your solution
Thanks also @MustSave for your solution as well
@tomaarsen - if I am not mistaken your solution would work well in case one uses packing (i.e. no padding token in the input sequences), for that case @MustSave 's solution would be better but I am not sure if all tokenizers have an unk_token attribute.

So it would still not be completely foolproof in that scenario, I imagine. Definitely tricky.

thanks for the feedback --> I think using a custom collator that sets label[i]=-100 if attention_mask[i]=0 is the approach to take

Sorry for the question, but I am also facing this issue. is there a temporary solution that might work for mistral (if one is using packing or without packing)?


Ability to set authorization via Envar

In tctl we can set TEMPORAL_CLI_AUTH="Bearer $token",  in temporal cli from my quick look we have to continuously use --grpc-meta.
From common/flags.go I couldn't find any way to set such a thing.
	&cli.StringSliceFlag{
		Name:     FlagMetadata,
		Usage:    FlagMetadataDefinition,
		Category: CategoryGlobal,
	},

Duly noted, will keep this in mind for a future release!

It would be great to see this implemented! It's not ideal to be passing credentials back and forth on the command line.

@cretz is planning to add a --api-key option that will have an associated environment variable in #478, so we can probably drop this one in favor of that.


MINOR: Fix spelling and grammar issues in ReplicaFetcherThread detailed comment

I noticed them while looking at the recent commit:
https://github.com/apache/kafka/commit/87eccb9a3bea56e5d7d5696aaddef1421f038903

LGTM

Merged to trunk and 0.9.0.


For in experiment

1st commit : Replaces object.keys + for/forEach with for..in statement
Safe change, easier to read and should be fine performance wise (more benchmark/osgjs example would be great though).
2nd commit : Stops using Map for uniforms/texture and rely only on native {}
Needs more benchmark
I started using native window.Map for uniforms/textures but didn't do it because :

[] accessor doesn't work and it requires set/get so lots of change
it requires for..of in order to iterate on it which isn't supported in android <=50 and IE11 (https://kangax.github.io/compat-table/es6/), also I have no idea about the performance of for..of

The 2 commits are separate (1st one can be merged without the second).

@jtorresfabra @cedricpinson @Kuranes

Can be merged imo

Did not notice performance improvement but agree if it's not a problem it can simplify some code. Did you check on firefox / mobile ?

yes same


support key-value params in JSONRPC

Refs #1, #8, #7

remove Client interface (reason: empty)
introduce HTTPClient interface, which can be used for both ClientURI
and ClientJSONRPC clients (so our users don't have to create their own) (Refs #8)
rename integration tests script to integration_test.sh
do not update deps on get_deps

Upd.

use golang default if an arg is missing

--- FAIL: TestJSONBroadcastTxSync (0.00s)
        Error Trace:    client_test.go:76
        Error:          Expected nil, but got: &errors.errorString{s:"Response error: Error converting json params to arguments: encoding/hex: invalid byte: U+002F '/'"}

--- FAIL: TestURIABCIQuery (0.00s)
        Error Trace:    client_test.go:104
                        client_test.go:109
        Error:          Expected nil, but got: &errors.errorString{s:"Response error: Error converting json params to arguments: encoding/hex: invalid byte: U+0052 'R'"}

--- FAIL: TestJSONABCIQuery (0.00s)
        Error Trace:    client_test.go:104
                        client_test.go:118
        Error:          Expected nil, but got: &errors.errorString{s:"Response error: Error converting json params to arguments: encoding/hex: invalid byte: U+002F '/'"}

--- FAIL: TestJSONBroadcastTxCommit (0.00s)
        Error Trace:    client_test.go:149
        Error:          Expected nil, but got: &errors.errorString{s:"Response error: Error converting json params to arguments: encoding/hex: invalid byte: U+0079 'y'"}

--- FAIL: TestWSNewBlock (0.00s)
panic: Expected map but got type string [recovered]
        panic: Expected map but got type string

goroutine 82 [running]:
testing.tRunner.func1(0xc420464000)
        /usr/local/go/src/testing/testing.go:622 +0x29d
panic(0xa1fda0, 0xc4201eecd0)
        /usr/local/go/src/runtime/panic.go:489 +0x2cf
github.com/tendermint/tendermint/rpc/test.waitForEvent(0xc420464000, 0xc420064000, 0xae6fae, 0x8, 0xae6f01, 0xc2e998, 0xc2e9a0)
        /home/vagrant/go/src/github.com/tendermint/tendermint/rpc/test/helpers.go:179 +0x53a
github.com/tendermint/tendermint/rpc/test.TestWSNewBlock(0xc420464000)
        /home/vagrant/go/src/github.com/tendermint/tendermint/rpc/test/client_test.go:190 +0x12e
testing.tRunner(0xc420464000, 0xc2e9a8)
        /usr/local/go/src/testing/testing.go:657 +0x96
created by testing.(*T).Run
        /usr/local/go/src/testing/testing.go:697 +0x2ca

got a few errors in tendermint

Ok, I think the 4 first tests are failing because I changed wire to json.Marshal here. But wire doesn't support maps. So I probably will need to convert the map to the slice. I hope to finish it tomorrow (1 or 2 hours).

Also, this library could use more testing since I only found these errors while testing with tendermint.

Also, this library could use more testing since I only found these errors while testing with tendermint.

Yes please.
Thanks Anton.

Trying to pinpoint the last error. Not so easy thing to do. The stack trace is not clear. I mean, it shows what test is failing and reason, but doesn't show the exact location.

CircleCI is lying! Looks like it operates on the old code. Misconfigured?

Ok. So I wrote 2 more test cases, fixed 2 errors above. Now, both tendermint and go-rpc tests are green on my machine.

Do you have access to Circle? Sometimes you need to run Rebuild without cache from the little dropdown in the upper right. I just reran it like that, still failing though.

I just reran it like that, still failing though.

hm.. now I am confused.

Do you have access to Circle?

yes


[docs] Added xrefs from UDP CLI to UDP Concepts Guide

Oh, after this is in, you'll want to update this section in ot-docs as well, to add the new tag https://github.com/openthread/ot-docs/blob/main/site/en/reference/cli/contribute.md#doxygen-special-commands


Pressing  while in command-line opens QuickOpen

Thanks @romgrk for logging the issue! I could see two possibilities for fixing this:

Option 1: Don't allow <C-p> / <C-S-p> actions while the command line is open
Option 2: Close the command line when a menu is open

I think Option 1 is probably the expectation - especially since <C-p> would have some behavior if there is a wildmenu open.
@Akin909 - is this something we need to fix by setting an input control mode for <C-p>/<C-S-p>?

Option 3: bind QuickOpen to a command and map <c-p> to it in normal/insert/visual modes.

@bryphe the fix here would be to set the input control to MenuFocus when either the commandline or wildmenu open, since they idea with that is it should tell other bits of UI where the current focus is but the wildmenu etc. pre-date that.
So the quick open is unaware that there is already another menu open, when it opens


implement handler class

implement Handler class. Goal is parity with the ruby lib.
we might be able to use ehazlett's work - https://github.com/ehazlett/sensu-py

Sadly, ehazlett's work is incompatible with later sensu versions.
One year on and no progress with the python handler
https://github.com/sensu/sensu-plugin-python/issues/4

handler support has now been added into 0.4.0


Mask values in assignment expressions

This change will mask lines that match the pattern of "" = "" which usually shows up in property that are maps.
For example:
When passing secrets to the AWS lambda environment variables resource, terraform spits out the plan for the lambda with the environment looking like
 ~ environment {
          ~ variables = {
              - "Environment"           = "sandbox"
              - "db_host"     = "foo.rds.amazonaws.com"
              - "db_password" = "super_secret"
              - "db_port"     = "5432"
              - "db_username" = "randomuser"
            } -> (known after apply)
        }

The change will mask out the "super_secret" value.

fwiw looks good to me @osterman


Everytime I start run sd I need to install torch and something,it takes some time.Is there any tricks to avoid this?

What happened?
Everytime I start run sd I need to install torch and something,it takes some time.Is there any tricks to avoid this?
Colab cell output
Everytime I start run sd I need to install torch and something,it takes some time.Is there any tricks to avoid this?

Which colab and model(s) were you using when the error occurred?
Everytime I start run sd I need to install torch and something,it takes some time.Is there any tricks to avoid this?
Which Public WebUI Colab URL were you using when the error occurred?
remote.moe
If you used HiRes mode when the error occurred, please provide the Hires info
No response

if you just refer to the installing torch process: it's because the recent (last month) changes of google colab updated the torch, but stable-diffusion-webui runs on a specific version of it, so the download and installing process is the one slowing it down. (torch is huge, about 2/3 Gb, though colab's internet is fast, it still takes time)
if you refer to the overall 'waiting 8 min before the actual thing starts': it's downloading dependencies used for the entire webui thing.
If you don't want to wait, you can use the google drive version here by camenduru himself to basically install the entire stable-diffusion-webui on your google drive, so the next time you open it, it will be way faster.
Or use some community made colabs like NoCrypt's or Cagliostro, they use pre-compiled dependencies, it's fast, probably 3-4 minute faster.

Ok, thanks.


Transport params can be set to "null"

As noted in offline discussions, whilst the original intent was to deal with a few cases where devices may need to set 'null' during initialisation (and hence backport the fix), the fact this could potentially be applied to PATCHes too suggests it's a normative change. That opens a can of worms with regard to versioning behaviour, so we may be best parking this one unless it's reported as a more major issue at a later date.


Error while running hi-patch_v1.m

Hi,
I am getting the following error while running the hi-patch script:
Unrecognized field name "at_name".
Error in hi_patch_v1 (line 586)
lyscount = sum(count(surfdata.at_name(:,1),'NZ')); % count number of lysine primary NH2s
Can you help to resolve this?

Sure thing. Would you mind sharing your crystal structure? Either PDB ID, or if you'd rather send me your structure via email<EMAIL_ADDRESS>that would work too.

Hi,
I am getting the following error while running the hi-patch script:
Unrecognized field name "at_name".
Error in hi_patch_v1 (line 586) lyscount = sum(count(surfdata.at_name(:,1),'NZ')); % count number of lysine primary NH2s
Can you help to resolve this?

Sure thing. Would you mind sharing your crystal structure? Either PDB ID, or if you'd rather send me your structure via email<EMAIL_ADDRESS>that would work too.

Hi Hector,
Thank you for the quick response. The protein I am working upon is basically modeled and is in the process of getting published. Hence, I am not allowed to share the PDB file. I am trying to use hi-patch to characterize its hydrophobic and hydrophilic surface area.
Is there another way you can help me resolve this error?


Will the source code be made available soon?

[ ] Installation
[ ] Administration
[ ] Custom Content
[x] M365 learning pathways web part

As title asks, I understand that the source code was questioned back in May 2019, however I was curious to the status of the release of the source code as it's marked as an open source project?
Kind regards,
Luke

It’s my understanding that it is the intent to have the code become available, however I have no ability to give you a timeline and I don’t know if it will be source open or open source.

Source code is now available.

Source code is now available.


[pre-sve] TC-I-2.2 after waiting 10s identify-time is unchanged

Problem

Expected - Set identify-time to 60, read identify time as 60, wait 10s, read identify-time as ~50
Actual - After 10s identify-time is still 60
TC-I-2.2 steps to 2c
qpg6105 + x64 chip-tool

TC_I_2_2.1653981452.log
Proposed Solution
No fix

Cert Blocker Review: @franck-apple to find a platform owner for this.

Cert Blocker Review: Removing cert blocker, given the Core SDK supports this, but does need resolution in the specific platform.

I have exactly the same problem on nRF.
chip-tool and DUT commit id : 5d8599d (pre-sve SHA)
Logs:
TC_I_2_2_nRF.log
TC_I_2_2_nRF_DUT.log

@woody-apple could this reviewed by TSG again given 2 platforms (one FreeRTOS, other Zephyr based) have this issue ? The code seems to re-use code generic timer code that's also used in other clusters, but there might be some detail missing I don't fully grasp.
chip::DeviceLayer::SystemLayer().StartTimer

Issue was related to application level implementation of Identify behavior.
Without a handling class, the cluster does not take any action.
Fixed by adding placeholder implementation of Identify handling at application level


Feat/listening globs

Use glob expressions (via minimatch) for listening instead of regular expressions (via RegExp).

Closing for now since we need this to match the same pattern matchin as redis


Does not work with Wayland

I am running Debian 13 testing with the standard configuration of Gnome which uses Wayland
First of all normal raylib examples compile and run normally so it's not an issue with something outside of these bindings.
What i have tried for raylib-zig:

cloning raylib-zig locally and changing linux_display_backend to .Wayland
setting .linux_disply_backend = rlz.LinuxDisplayBackend.Wayland for raylib_dep
adding these linksSystemLibrarys for raylib_artifact, exe and the exe in the local raylib-zig
as they are what the build.zig of raylib uses

.linkSystemLibrary("wayland-client");
.linkSystemLibrary("wayland-cursor");
.linkSystemLibrary("wayland-egl");
.linkSystemLibrary("xkbcommon");
and yet even though it compiles i get this error when i try to run the program:
INFO: Initializing raylib 5.5-dev
INFO: Platform backend: DESKTOP (GLFW)
INFO: Supported raylib modules:
INFO:     > rcore:..... loaded (mandatory)
INFO:     > rlgl:...... loaded (mandatory)
INFO:     > rshapes:... loaded (optional)
INFO:     > rtextures:. loaded (optional)
INFO:     > rtext:..... loaded (optional)
INFO:     > rmodels:... loaded (optional)
INFO:     > raudio:.... loaded (optional)
WARNING: GLFW: Error: 65544 Description: Wayland: Failed to load libwayland-client
WARNING: GLFW: Failed to initialize GLFW
Segmentation fault at address 0x0
???:?:?: 0x0 in ??? (???)
fish: Job 1, './zig-out/bin/tetris' terminated by signal SIGABRT (Abort)

Could you try, in addition to your linkSystemLibrary calls, to add raylib_artifact.defineCMacro("_GLFW_WAYLAND", null);

Sadly this doesn't change anything

On arch with wayland (hyprland) I can't reproduce this.

Are you using Nvidia?
https://wiki.debian.org/Wayland :
"GDM (GNOME Display Manager) will automatically use Wayland when supported, except when using the proprietary NVIDIA driver, in which case it will fall back to X11 due to instability."

No I'm using an integrated specifically that of an i7-1185G7.
And echo "$XDG_SESSION_TYPE gives me wayland,
as well as the examples of normal raylib which give the same INFO statement as in your screenshot.

normal raylib examples compile and run normally so it's not an issue with something outside of these bindings.

I also noticed this. The solution for me was to have both raylib and raylib-zig as dependencies and then link the library with the module like so:
const raylib_dep = b.dependency("raylib", .{
    .target = target, .optimize = optimize,
});
const rayzig_dep = b.dependency("raylib_zig", .{
    .target = target, .optimize = optimize,
});
const raylib_module = rayzig_dep.module("raylib");
const raylib_artifact = raylib_dep.artifact("raylib");
raylib_module.linkLibrary(raylib_artifact);

Still doesn't change anything, the same "... Failed to load libwayland-client" error remains.
I tried looking into what zig links in the build process as this seems like a linking issue. With zig build --verbose-link it gives some more insight and confuses me even more: it outputs a long ld.lld command which does include the correct libwayland-client.so but it states that the command had an error and failed. Yet still produces a working executable.

Sounds like a Zig issue, opening an issue with is probably best.

I tried to get zig to first compile an object file and then link it separately, trying to force it to link against libwayland-client. But after throwing a bunch of options at it my program just crashes with a SIGFPE.
I think I will have to postpone working on this further until I understand how to get it to link properly. For now, I will move this to the official zig repo as it seems like zig ignores my linking of libwayland-client because it is not explicitly used in my program.


remove par and par_py until they work on apple silicon.

par and pay_py will cause ERROR: Something is wrong with flag 'flagfile' in file 'Users/corentinl/work/main/build_make/_deps/absl-src/absl/flags/parse.cc'. One possibility: file 'Users/corentinl/work/main/build_make/_deps/absl-src/absl/flags/parse.cc' is being linked both statically and dynamically into this executable. e.g. some files listed as srcs to a test and also listed as srcs of some shared lib deps of the same test. on apple silicon when launches executable, so temporarily remove until or-tools fix this problem.

@maliberty yes, this is the same error that lead us to disable mpl2 on macOS. Other users have reported the same problem, including Cherry and Eder.


AMI for ap-northeast-2 (Seoul) and US-east (Ohio)

Would be possible to set up an AMI for these new places that have p2 instances since last month?
I am specially interested in the Asia Pacific region :D
Thanks!

Great idea! Thanks for letting us know.

same for Frankfurt. Thanks again for his course !

can i get an AMI for OH, us-east-2?

also one for ap-southeast-2 (Sydney) would be great!
(Or, if you could make the snapshots the AMIs are built off public, that would allow us to copy it - in us-west-2, it's snap-2b6c1a18)


Carbon fields appended with .ca and AOD fields have 001

The latest x run, x0048, is running with MAPL v2.35.2 but Ben's fix for this went in with v2.34.0. For example, brown carbon is getting written to the netcdf file as CA.brEXTTAU001 despite this line in HISTORY: 'CA.brEXTTAU'    , 'CA.br'     , 'BREXTTAU'    ,.

Hmm. Let me mention @atrayano and @bena-nasa. This does look incorrect.
I mean, I think it should be putting out BREXTTAU001 and not CA.brEXTTAU001 (I think the 001 will always happen since this has ungridded dims).

It is actually the x48 experiment, configured by Ricardo and being run by Mohar. The path is /discover/nobackup/projects/gmao/dadev/dao_it/Summer_Runs/x0048/run.

Thanks. I did not see "splitField = 1" for this collection. I believe we still need it (@bena-nasa could you please confirm). But this alone cannot explain the behavior...

The issue here is a grads problem not an actual source code issue.

I think point that Allie was making w/ this PR is that we need a fix to remove the "ca." from the carbon species names ... and anything else that would have a period in the name.
Whereas in practice we can do tricks of the sort I say, the fact is that there is still a problem that needs to be fixed in the source code.

Ah - allies!    I don't want "." in component names for (almost?) completely unrelated reasons.

Reopening as I'm not sure this is fixed yet...

Yes. This is still an issue.
@bena-nasa @atrayano can you look at this?

I'll also ping @tclune in case I forget about this again.

Going to be hard to get attention of GOCART developers on this, esp. over the summer.    Can force the issue with MAPL 3 when that rolls out in 2040.

Going to be hard to get attention of GOCART developers on this, esp. over the summer. Can force the issue with MAPL 3 when that rolls out in 2040.

I think it must be a MAPL issue as it seems like HISTORY is not respecting the alias passed in.

Sorry, I'm late to the game here...Just adding my two cents that I don't think this is a GOCART issue, but rather MAPL. The aliases were getting ignored in HISTORY.
Allie

From: Tom Clune @.>
Sent: Monday, July 3, 2023 11:03 AM
To: GEOS-ESM/MAPL @.>
Cc: Collow, Allie (GSFC-610.1)[UNIVERSITY OF MARYLAND BALTIMORE CO] @.>; Mention @.>
Subject: [EXTERNAL] [BULK] Re: [GEOS-ESM/MAPL] Carbon fields appended with .ca and AOD fields have 001 (Issue #2058)
CAUTION: This email originated from outside of NASA.  Please take care when clicking links or opening attachments.  Use the "Report Message" button to report suspicious messages to the NASA SOC.
Ah - I misunderstood Ricardo's comment. If it is MAPL, we should have addressed this a while back. Now a priority.
—
Reply to this email directly, view it on GitHubhttps://github.com/GEOS-ESM/MAPL/issues/2058#issuecomment-1618562941, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHNRAK5UCZLWKHP5YJK5NV3XOLNLDANCNFSM6AAAAAAWVM3UJY.
You are receiving this because you were mentioned.Message ID: @.***>

Following up on this since it showed up in another run I am looking at. In case it helps, the build has v2.35.3 for MAPL and v2.1.2 for GOCART. The issue was not in runs that used v10.22.0 of the GCM.

Not reflected in this thread,  but @atrayano is actively looking into this now.

@acollow There is a new MAPL 2.39.5 now with this fix. If you need it backported to a previous MAPL, please let us know and we can work on that.

Thanks Matt! I will need to check with others, but there is a possibility we will need this for x48 should it get promoted and/or R21C.

From: Matthew Thompson @.>
Sent: Monday, July 10, 2023 11:12 AM
To: GEOS-ESM/MAPL @.>
Cc: Collow, Allie (GSFC-610.1)[UNIVERSITY OF MARYLAND BALTIMORE CO] @.>; Mention @.>
Subject: [EXTERNAL] [BULK] Re: [GEOS-ESM/MAPL] Carbon fields appended with .ca and AOD fields have 001 (Issue #2058)
CAUTION: This email originated from outside of NASA.  Please take care when clicking links or opening attachments.  Use the "Report Message" button to report suspicious messages to the NASA SOC.
@acollowhttps://github.com/acollow There is a new MAPL 2.39.5 now with this fix. If you need it backported to a previous MAPL, please let us know and we can work on that.
—
Reply to this email directly, view it on GitHubhttps://github.com/GEOS-ESM/MAPL/issues/2058#issuecomment-1629167834, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHNRAK5CN5NRKSEKAMKUCBDXPQLVFANCNFSM6AAAAAAWVM3UJY.
You are receiving this because you were mentioned.Message ID: @.***>

@acollow Okay. Just let us know the MAPL version that will be used in R21C and x48 and I can work with @atrayano to make a patch for that as well.


Opening a page from the top menu should open a new tab, not a new window

The problem comes from the changes related to GtWorldUtility and the fact that we have a dropdown in a dropdown.


Test fails but Set doesn't configure Choco

Test fails because:
$InstallDir is not equal to $env:ChocolateyInstall
Set does not enter loop because:
if (-not (DoesCommandExist choco) -or -not (IsChocoInstalled))
Command exists and Choco is installed. If Set is called, it should always set the configuration.

#32 has gone part way to fixing this. now if the only issue is that the ENV variable isn't set it will set that.
Just needs another bit of code to uninstall chocolatey from incorrect location and install it in correct location


Database collection technique

Hi, thank you for the excellent work. Could you tell me how the initial dataset was created?

Hi,
I cloned the dataset from the git repo mentioned below. Hope this helps.
https://github.com/anooppoommen/malayalam-transliteration


Consider confidence values in 'ensure_consistent_bilou_tagging'

Proposed changes:
The method ensure_consistent_bilou_tagging now also considers the confidence values of the predicted tags
when updating the BIlOU tags.
closes https://github.com/RasaHQ/rasa/issues/6039
Status (please check what you already did):

[x] added some tests for the functionality
[ ] updated the documentation
[x] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

You mean the tags before they got updated? mmhh... not that easy, as the tags are converted into proper entities and I am not sure how you would add the "old" tags in there.

Let's create an issue for it to discuss it. So that this PR is not blocked

https://github.com/RasaHQ/rasa/issues/6647

Could you please add the description of this substitution process to docs, please?

Where should it go? We do not have a section for it as far as i know.

hm, it seems that we don't have a place where we describe bilou tagging scheme. I think we should add it some where

@erohmensing tagging you as a review as I added a section about BILOU tagging to the docs. As the information about NLU Training Data was already included in Training Data Format I removed it and kept just the entity related stuff. Let me know if that does not work and the section should be moved somewhere else.

followed the suggestion of @Ghostvv and added the page about nlu training data again and just added the bilou section to that page

Applied all review comments, thanks for the comments!
@erohmensing or @Ghostvv can someone please approve so that we can merge this PR? Thanks.

oh no, just realised that we will not be able to merge as a lot of tests will all fail due to the convert issue


Refactor suggestion: Wrap all responses on a data field

The json payload returned by some calls is redundant, for example:
/v4/character/<name>
# Before
{
  "character": {
    "character": {
    ...
    }
}

# After
{
  "data": {
    "character": {
    ...
    }
}

/v4/boostablebosses
# Before
{
  "boostable_bosses": {
    "boostable_boss_list": [
    ]
}

# After
{
  "data": {
    "boostable_bosses": [
    ]
}

It makes more sense to always return a data field with the data we are expecting. This is a step towards standardization of the api responses.
In addition, the information field is irrelevant in most of the cases, the status header would be enough for status code and the api information could have a dedicated endpoint if we want to retrieve this information.

hello @refl3ction,
Thanks for your suggestion!
The section part instead of data is partly some legacy from earlier versions from TibiaData and could in upcoming versions be changed.
And yes, parts could be moved from the information.api section as well to some other endpoint in future as well.
Since this is a breaking change and we just release V4, I'll not add this for now :)
Kind regards,
Tobiass


define lower bound php-version

as discussed for *nix systems 5.4 is enough for win 5.5+ is recommended

Is there any way how to specify a Windows specific requirement?

I am not aware of one

I don't think so. Why is it 5.5 on Windows?

@staabm 5.4 is only needed because Amp needs it. If Amp were supporting 5.3, it would work there too on *nix.
I prefer to not add my own requirement here, but let the minimum version of this lib be implicitly defined by Amp.
@kelunik There exist bugs like https://bugs.php.net/bug.php?id=51800 which prevent this lib from working in every case… This failure is Windows specific though…


Jest not picking up changed files

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
When running jest --watch or jest -o in a folder with changed files Jest output is No tests found related to files changed since last commit. , but git status clearly shows that there are changed files. I have also changed them again and Jest is not picking them.

I've tried to run it with --no-watchman and --no-cache options, but result is the same as above.
Thank you for your help.
Please provide your exact Jest configuration and mention your Jest, node, yarn/npm version and operating system.
Jest: v21.2.1
Node: v6.11.3 and v8.6.0
Yarn: 1.1.0
Npm: 5.5.1 and 5.3.0
Windows: 6.1.7601
{
  "configs": [
    {
      "automock": false,
      "browser": false,
      "cache": true,
      "cacheDirectory": "C:\\Users\\pdanis\\AppData\\Local\\Temp\\jest",
      "clearMocks": false,
      "coveragePathIgnorePatterns": [
        "\\\\node_modules\\\\"
      ],
      "globals": {},
      "haste": {
        "providesModuleNodeModules": []
      },
      "moduleDirectories": [
        "node_modules"
      ],
      "moduleFileExtensions": [
        "js",
        "json",
        "jsx",
        "node"
      ],
      "moduleNameMapper": {},
      "modulePathIgnorePatterns": [],
      "name": "abaaceb2144daed787b0dcf49bd2e56e",
      "resetMocks": false,
      "resetModules": false,
      "rootDir": "C:\\users\\pdanis\\Desktop\\Projects\\my-js-learning",
      "roots": [
        "C:\\users\\pdanis\\Desktop\\Projects\\my-js-learning"
      ],
      "runner": "jest-runner",
      "setupFiles": [],
      "snapshotSerializers": [],
      "testEnvironment": "jest-environment-jsdom",
      "testMatch": [
        "**/__tests__/**/*.js?(x)",
        "**/?(*.)(spec|test).js?(x)"
      ],
      "testPathIgnorePatterns": [
        "\\\\node_modules\\\\"
      ],
      "testRegex": "",
      "testRunner": "C:\\users\\pdanis\\Desktop\\Projects\\my-js-learning\\node_modules\\jest-jasmine2\\build\\index.js",
      "testURL": "about:blank",
      "timers": "real",
      "transformIgnorePatterns": [
        "\\\\node_modules\\\\"
      ],
      "watchPathIgnorePatterns": []
    }
  ],
  "globalConfig": {
    "bail": false,
    "changedFilesWithAncestor": false,
    "coverageDirectory": "C:\\users\\pdanis\\Desktop\\Projects\\my-js-learning\\coverage",
    "coverageReporters": [
      "json",
      "text",
      "lcov",
      "clover"
    ],
    "expand": false,
    "listTests": false,
    "mapCoverage": false,
    "maxWorkers": 3,
    "noStackTrace": false,
    "nonFlagArgs": [],
    "notify": false,
    "rootDir": "C:\\users\\pdanis\\Desktop\\Projects\\my-js-learning",
    "runTestsByPath": false,
    "testFailureExitCode": 1,
    "testPathPattern": "",
    "testResultsProcessor": null,
    "updateSnapshot": "new",
    "useStderr": false,
    "verbose": null,
    "watch": false,
    "watchman": true
  },
  "version": "21.2.1"
}

This doesn't repro here, it must be an issue with your setup and unfortunately it's probably really hard to help on this :(

It is caused by case-sensitivity.
If I run jest -o from C:\users\... and C:\Users\..., the outcome is different. On Windows the paths and filenames should be case-insensitive.

I can reproduce it on a second Windows machine with different versions.
Windows: 10.0.15063
Jest: 21.0.1
Git: 2.14.1.windows.1
Command used jest -o
Correct full path is D:\Projects\Temp\my-js-learning
Outcome:

with correct path Jest picks up changed file
with an incorrect case in working dir - Jest picks up changed file
(D:\Projects\Temp\My-js-learning)
with an incorrect case in any dir preceding working dir - Jest does not pick up changed file
(D:\ProjectS\Temp\my-js-learning)
(D:\Projects\temp\my-js-learning)
(D:\projects\Temp\my-js-learning)

Could you please try to reproduce it again? Thanks.


fix(1433): prevent default behavior for e, +, and -  in number input

Description
Added an onkeydown event handler for number inputs that prevents typing characters like e, + and -, which are allowed in number inputs, but cause the built-in value sanitization algorithm to get NaN when parsing a string like "1e", and then set the value to an empty string. Also added a regex filter to block any input that isn't a number or decimal point, so that if a user were to copy and paste a number containing those characters, it would still be filtered out.
Checklist

[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

Issue(s)
Fixes #1433

FWIW There's other issues with number inputs, such that I think the better solution is a pre-submit check rather than managing every key stroke.  I'm guessing key stroke limiting is not great for accessibility either. As far as I know this is the only situation we manage the key strokes.
https://github.com/seattle-uat/civiform/issues/1623

FWIW There's other issues with number inputs, such that I think the better solution is a pre-submit check rather than managing every key stroke. I'm guessing key stroke limiting is not great for accessibility either. As far as I know this is the only situation we manage the key strokes.
#1623

I can move this code back to validation.ts and turn it into a pre-submit check if that's the better option. My goal here was to try to keep the existing behavior, which blocked non-numeric characters from the input.


Opinionated template 3 - bug punchlist

P1

[ ] High-priority item 1

P2

[ ] Medium-priority item 1

P3

[ ] Low-priority item 1

/to @abeck000 to fill out

didnt need, closing


Fix keyboard avoid view behaviour

Please verify the following:

[x] yarn ci:test jest tests pass with new tests, if relevant
[x] README.md has been updated with your changes, if relevant

Describe your PR
Fix the values passed to KeyboardAvoidingView behaviour prop.
As per React Native documentation behaviour is an enum (link) which means one of the values must be provided. In case there is no need to use behaviour, the correct value should be undefined.
Please see screenshot below for the TS warning:

:tada: This PR is included in version 6.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add rgb to bgr in ndarray utils and test

Codecov Report

Merging #373 (6ed731b) into main (e8d35bd) will increase coverage by 0.06%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
+ Coverage   70.15%   70.22%   +0.06%
==========================================
  Files         223      223
  Lines        8101     8130      +29
  Branches     1065     1068       +3
==========================================
+ Hits         5683     5709      +26
- Misses       2159     2160       +1
- Partials      259      261       +2

Impacted Files
Coverage Δ

towhee/utils/ndarray_utils.py
84.21% <66.66%> (-5.45%)
:arrow_down:

towhee/tests/utils/test_ndarray_utils.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8d35bd...6ed731b. Read the comment docs.


Dose some code still not completed in the project?

I couldn't run pretrain process when using scannet.

What is the detailed error？

Thanks for reply. When running sh tool/pretrain.sh scannet, I facing some errors such as no attribute 'data_path', shm file exits in file batch_load_scannet_data.py, and I also need to add addition files such as load_scannet_data.py. I already fixed some, but still can't run the code process.

The code has been updated, please try again

Thanks! And there still have an error UnboundLocalError: local variable 'item' referenced before assignment in line 68, dose this code can run successfully in your work station?

After replacing 'item' with 'scan', I still facing errors such as FileExistsError: [Errno 17] File exists: 'shm://scene0546_00', how can I fix it, thanks!

The code uses sharedArray, the data needs to be pre-loaded into /dev/shm. /dev/shm is not on the hard disk, but in memory and belongs to tmpfs (Virtual Memory System). You can try cleaning /dev/shm.

Thanks, but after I cleaning /dev/shm, the error still occurred.

This could be a distributed problem, perhaps try to pre-load data to /dev/shm in a single thread

Thanks for advice! It works.


jquery.pjax.js:233 Uncaught TypeError: Cannot read property 'type' of undefined

I have used kartik/treemanager extension model for this extension . Everything work as well for initial node , but when i change the node of tree and after that submit the comment , comment button stuck in "loading..." and shows the below error . although comment saved in database .

How can disable pjax for form submit at all?

You need to create own view and override this property for Comment widget

i think this issue is because every node content load via ajax in kartik/treemanager and somethings lose for reload comments via pjax . But still can't fix it...

i found the solution .
1-  set a Flash message in actionCreate in DefaultController that store commentModel->entityId value .
2-  set displayValue property  in kartik/treemanager with that Flash message

Nice!


Jest v21.x.x is missing jest.restoreAllMocks()

Jest v21 introduced jest.restoreAllMocks(), which is missing from the definition.

Fixed with #1686


There seems to be a socket issue related to Dapr Client (vs. HTTP client)

Status(StatusCode="Internal", Detail="Error starting gRPC call. HttpRequestException: No connection could be made because the target machine actively refused it. (<IP_ADDRESS>:50001) SocketException: No connection could be made because the target machine actively refused it.", DebugException="System.Net.Http.HttpRequestException: No connection could be made because the target machine actively refused it. (<IP_ADDRESS>:50001)
---> System.Net.Sockets.SocketException (10061): No connection could be made because the target machine actively refused it.
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
at System.Net.Sockets.Socket.g__WaitForConnectWithCancellation|277_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
--- End of inner exception stack trace ---
at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.AddHttp2ConnectionAsync(HttpRequestMessage request)
at System.Threading.Tasks.TaskCompletionSourceWithCancellation1.WaitWithCancellationAsync(CancellationToken cancellationToken)    at System.Net.Http.HttpConnectionPool.GetHttp2ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)    at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)    at System.Net.Http.DiagnosticsHandler.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)    at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)    at Grpc.Net.Client.Internal.GrpcCall2.RunCall(HttpRequestMessage request, Nullable`1 timeout)")

Interesting - apologies for not catching this sooner I'll take a look to see if I can replicate


Find a new way to do publish

https://github.com/js-sdsl/js-sdsl/actions/runs/3964428948
Since I was forced to enable secondary authentication by npm, the automated CI could not be released successfully.

Good news!
https://hackernoon.com/publish-npm-packages-using-github-actions-a-how-to-guide-q31c34fg
I will use the new automatic token to do publish next time.

I just tried it and using Require two-factor authentication or an automation or granular access token option, publish works well without any code modification.

I think you can close this issue in the next publish.

Version 4.4.0 successful automatic published.


chore: update the screenshots with the new UI

Signed-off-by: Harikrishnan Balagopal<EMAIL_ADDRESS>

Thanks Hari! Very glad to have it.
One question I have is the number of images we are uploading, and especially since this is our main repo. Is there a way to keep the images in some other location, other than the main repo, so that when we change/add new images, we don't increase the size of our main repo?

Thanks Hari! Very glad to have it.
One question I have is the number of images we are uploading, and especially since this is our main repo. Is there a way to keep the images in some other location, other than the main repo, so that when we change/add new images, we don't increase the size of our main repo?

yes we can do that. I am not sure where we could upload it though. Are you thinking of making a new repo like konveyor/move2kube-website-images just for the images?
For now, I have compressed the images so that they are all less 100KB in size.


Issue #197 - Revert individual or all changes to contributions made

Fixes #197

@jeffmcaffer I've made some updates based on your suggestions.
You can now review again the PR.

@storrisi Note that I merged but there is still an unaddressed comment relating to the error handling in getDefinitionsAndNotify. I think it should be using a try/catch with async/await structure.

@jeffmcaffer thanks, i was actually working on that yesterday. I will address this in another PR.


replace util/bytes.go with binary.BigEndian

The built-in package binary provides the same functionality, possibly faster since it has no for-loops.

This is reverted because of this error report:
Hi Chris,
curl 'http://<IP_ADDRESS>:9333/dir/assign?replication=000&count=14'
{"fid":"5,8dd1f19f23","url":"<IP_ADDRESS>:8080","publicUrl":"<IP_ADDRESS>:8080","count":14}
curl -F<EMAIL_ADDRESS>http://<IP_ADDRESS>:8080/5,8dd1f19f23
Apr  8 22:22:34 haystack012 weed: 2016/04/08 22:22:34 http: panic serving <IP_ADDRESS>:34909: runtime error: index out of range
Apr  8 22:22:34 haystack012 weed: goroutine 56 [running]:
Apr  8 22:22:34 haystack012 weed: net/http.(*conn).serve.func1(0xc82010c210, 0x7f075c4bd3b8, 0xc8201087c0)
Apr  8 22:22:34 haystack012 weed: /usr/lib/golang/src/net/http/server.go:1287 +0xb5
Apr  8 22:22:34 haystack012 weed: github.com/chrislusf/seaweedfs/go/storage.ParseKeyHash(0xc820108868, 0xa, 0xcf8f28, 0x1, 0x0, 0x0)
Apr  8 22:22:34 haystack012 weed: /home/mockbuild/weed-fs/rav/weed/src/github.com/chrislusf/seaweedfs/go/storage/needle.go:225 +0x2f4
Apr  8 22:22:34 haystack012 weed: github.com/chrislusf/seaweedfs/go/storage.(*Needle).ParsePath(0xc8200a21e0, 0xc820108868, 0xa, 0x0, 0x0)
Apr  8 22:22:34 haystack012 weed: /home/mockbuild/weed-fs/rav/weed/src/github.com/chrislusf/seaweedfs/go/storage/needle.go:201 +0x1f2
Apr  8 22:22:34 haystack012 weed: github.com/chrislusf/seaweedfs/go/storage.NewNeedle(0xc8209f60e0, 0x0, 0xc8200a21e0, 0x0, 0x0)
Apr  8 22:22:34 haystack012 weed: /home/mockbuild/weed-fs/rav/weed/src/github.com/chrislusf/seaweedfs/go/storage/needle.go:187 +0x619
Apr  8 22:22:34 haystack012 weed: github.com/chrislusf/seaweedfs/go/weed/weed_server.(*VolumeServer).PostHandler(0xc82017e0e0, 0x7f075c4bd510, 0xc82010c2c0, 0xc8209f60e0)
Apr  8 22:22:34 haystack012 weed: /home/mockbuild/weed-fs/rav/weed/src/github.com/chrislusf/seaweedfs/go/weed/weed_server/volume_server_handlers_write.go:27 +0x4e8
Apr  8 22:22:34 haystack012 weed: github.com/chrislusf/seaweedfs/go/weed/weed_server.(*VolumeServer).PostHandler-fm(0x7f075c4bd510, 0xc82010c2c0, 0xc8209f60e0)
Apr  8 22:22:34 haystack012 weed: /home/mockbuild/weed-fs/rav/weed/src/github.com/chrislusf/seaweedfs/go/weed/weed_server/volume_server_handlers.go:37 +0x3e
Apr  8 22:22:34 haystack012 weed: github.com/chrislusf/seaweedfs/go/weed/weed_server.(*VolumeServer).privateStoreHandler(0xc82017e0e0, 0x7f075c4bd510, 0xc82010c2c0, 0xc8209f60e0)
Apr  8 22:22:34 haystack012 weed: /home/mockbuild/weed-fs/rav/weed/src/github.com/chrislusf/seaweedfs/go/weed/weed_server/volume_server_handlers.go:40 +0x30a
Apr  8 22:22:34 haystack012 weed: github.com/chrislusf/seaweedfs/go/weed/weed_server.(*VolumeServer).(github.com/chrislusf/seaweedfs/go/weed/weed_server.privateStoreHandler)-fm(0x7f075c4bd510, 0xc82010c2c0, 0xc8209f60e0)
Apr  8 22:22:34 haystack012 weed: /home/mockbuild/weed-fs/rav/weed/src/github.com/chrislusf/seaweedfs/go/weed/weed_server/volume_server.go:64 +0x3e
Apr  8 22:22:34 haystack012 weed: net/http.HandlerFunc.ServeHTTP(0xc8200103f0, 0x7f075c4bd510, 0xc82010c2c0, 0xc8209f60e0)
Apr  8 22:22:34 haystack012 weed: /usr/lib/golang/src/net/http/server.go:1422 +0x3a
Apr  8 22:22:34 haystack012 weed: net/http.(*ServeMux).ServeHTTP(0xc820157b30, 0x7f075c4bd510, 0xc82010c2c0, 0xc8209f60e0)
Apr  8 22:22:34 haystack012 weed: /usr/lib/golang/src/net/http/server.go:1699 +0x17d
Apr  8 22:22:34 haystack012 weed: net/http.serverHandler.ServeHTTP(0xc820106000, 0x7f075c4bd510, 0xc82010c2c0, 0xc8209f60e0)
Apr  8 22:22:34 haystack012 weed: /usr/lib/golang/src/net/http/server.go:1862 +0x19e
Apr  8 22:22:34 haystack012 weed: net/http.(*conn).serve(0xc82010c210)
Apr  8 22:22:34 haystack012 weed: /usr/lib/golang/src/net/http/server.go:1361 +0xbee
Apr  8 22:22:34 haystack012 weed: created by net/http.(*Server).Serve
Apr  8 22:22:34 haystack012 weed: /usr/lib/golang/src/net/http/server.go:1910 +0x3f6
Any idea how to fix it?
Tried with empty volumes, same thing.
(using latest git)

I'll take a look at it, and make some tests too.


Javascript comments

WHEN I view the javascript file.
Then I see that the code is explained with detailed comments.

DONE. Also commented out a commented out line 43-46 because it's an extra thing I want to try but just wouldn't work. Kept it in just cause I want to see if i can figure it out. The code seems correct and it's the only answer I can find online but it won't work here.


Metrics per job

Hi,
Is there any way to export metrics per job? Summary allows to have an overview of Avg execution time, but it would be great to see it on a job level.
Please advice!

No 100% sure what you're asking but:
If you want stats per queue (job type) you can filter with labels ie:
bull_queue_complete_duration { quantile="0.999", queue="someJob" } will get you the .999 p for just  jobs of type someJob
If you want something to query per specific job instance that's not something Prometheus is good at in general, we use arena to dig into specific jobs

Sorry, did not see your reply before...
Here is the simple example:

1 queue;
2 jobs were ran in this queue:
a) Download docs - Job ID: 1; Job name: download-doc
b) Store docs - Job ID: 2; Job name: store-doc

So the point is - want to have stats based on Job Name. What you are proposing is based on Queue name.


`require': cannot load such file -- resque (LoadError)

Even though I don't use Resque in my project (I use Sidekiq) I get the following, when trying to start the rails console, after adding Cobweb to my gemfile:
/Users/NK/.rvm/gems/ruby-2.0.0-p353@au_rails4/gems/activesupport-4.0.5/lib/active_support/dependencies.rb:229:in `require': cannot load such file -- resque (LoadError)
  from /Users/NK/.rvm/gems/ruby-2.0.0-p353@au_rails4/gems/activesupport-4.0.5/lib/active_support/dependencies.rb:229:in `block in require'
  from /Users/NK/.rvm/gems/ruby-2.0.0-p353@au_rails4/gems/activesupport-4.0.5/lib/active_support/dependencies.rb:214:in `load_dependency'
  from /Users/NK/.rvm/gems/ruby-2.0.0-p353@au_rails4/gems/activesupport-4.0.5/lib/active_support/dependencies.rb:229:in `require'
  from /Users/NK/.rvm/gems/ruby-2.0.0-p353@au_rails4/gems/cobweb-1.0.19/lib/cobweb.rb:3:in `<top (required)>'
  from /Users/NK/.rvm/gems/ruby-2.0.0-p353@au_rails4/gems/bundler-1.6.2/lib/bundler/runtime.rb:76:in `require'
  from /Users/NK/.rvm/gems/ruby-2.0.0-p353@au_rails4/gems/bundler-1.6.2/lib/bundler/runtime.rb:76:in `block (2 levels) in require'
  from /Users/NK/.rvm/gems/ruby-2.0.0-p353@au_rails4/gems/bundler-1.6.2/lib/bundler/runtime.rb:72:in `each'
  from /Users/NK/.rvm/gems/ruby-2.0.0-p353@au_rails4/gems/bundler-1.6.2/lib/bundler/runtime.rb:72:in `block in require'
  from /Users/NK/.rvm/gems/ruby-2.0.0-p353@au_rails4/gems/bundler-1.6.2/lib/bundler/runtime.rb:61:in `each'
  from /Users/NK/.rvm/gems/ruby-2.0.0-p353@au_rails4/gems/bundler-1.6.2/lib/bundler/runtime.rb:61:in `require'
  from /Users/NK/.rvm/gems/ruby-2.0.0-p353@au_rails4/gems/bundler-1.6.2/lib/bundler.rb:132:in `require'
  from /Users/NK/Programmering/au/config/application.rb:4:in `<top (required)>'
  from /Users/NK/.rvm/gems/ruby-2.0.0-p353@au_rails4/gems/railties-4.0.5/lib/rails/commands.rb:60:in `require'
  from /Users/NK/.rvm/gems/ruby-2.0.0-p353@au_rails4/gems/railties-4.0.5/lib/rails/commands.rb:60:in `<top (required)>'
  from script/rails:6:in `require'
  from script/rails:6:in `<main>'

This should now be resolved, can you confirm, latest version 1.0.29.
thanks,
Stewart.


overflow-x / overflow-y conflict

I need to set the rightbar CSS overflow-x to visible for laboratory info popups to render properly.
However, this overrides the overflow-y setting at auto that is needed for the user to be able to scroll vertically through a long details table.
See: https://stackoverflow.com/questions/6421966/css-overflow-x-visible-and-overflow-y-hidden-causing-scrollbar-issue

Tobi @GISAID suggests that re-implementing the page layout in divs instead of a table, as follows:
Left:
box-sizing: border-box;
position: fixed;
overflow: auto;
top: 50px;
left: 0px;
width: 250px;

Middle:
box-sizing: border-box;
position: fixed;
overflow: auto;
top: 50px;
left: 250px;
width: calc(100%-500px);

Right:
box-sizing: border-box;
position: fixed;
overflow: auto;
top: 50px;
right: 0px;
width: 250px;

He also suggests assigning higher z-indices to popups to prevent covering.


calling c code with osqp,eigen and osqp-eigen in matlab simulink

Has anyone tried calling c code with osqp, eigen and osqp-eigen in matlab simulink 2015b through the S function builder module?

Hello @DRETQ, as I already replied in https://github.com/orgs/osqp/discussions/655#discussioncomment-9909254 the main way in which the developers of this library used it in Simulink is https://github.com/robotology/wb-toolbox, but we never used that with OSQP with VS2015 .

Thanks for your replyI! I regret not being able to use this toolkit as it is relatively new!


Upgrade EF version?

I was trying to use this library along with EF 6.1.3 but this is using EF5. Can we upgrade this library to the last version of EF or we got something similar in EF6 onwards?

Hello Fagner!
Unfortunately I don't use this library much anymore and I won't have much time to spend on it.
I would :heart: to take a PR for this if you're up to the taks?
AFAIK there's no built-in feature for this in EF6 still...

I've pushed v0.2 withe recent changes. I also upgraded to EF 6.1.3. It would be super cool if you could test it out and let me know how it works :smile:

Hello Kristian.
I used the new version and it seems to be running smoothly. I really appreciate your time on this!
Thank you for everything. :smiley:

No problem! Glad someone else found this project useful :grin:


Add a getter for if a language is RTL

Motivation
I was implementing

https://github.com/adil192/saber/issues/576

and I needed to find out if the current language was right-to-left. This is the code I used:
import 'package:intl/intl.dart' as intl;

final rtl = intl.Bidi.isRtlLanguage(
  LocaleSettings.currentLocale.languageTag
);

Developer Experience
Add a getter to AppLocale so that the developer can just use e.g.
final rtl = LocaleSettings.currentLocale.isRtl;

Ah okay, for some reason I just assumed that slang was already depending on intl
Thanks for your consideration


Repository support using proxy

Hi there, nice little utility! Unfortunately I would like to try that out in an Openshift cluster that is using a proxy to connect to the Internet, so atm I can't connect to Github. I guess that's not implemented yet, is there any plan to add this? Thanks!

I think it should work?
It's using the Go standard HTTP client which has support for the environment variables HTTP_PROXY, HTTPS_PROXY and NO_PROXY and lower-cased versions too https://golang.org/pkg/net/http/#ProxyFromEnvironment
Is it not picking up your configuration?

I tried with a public repo (no auth) and I get timeout errors so I assumed it was because of the proxy. It could be caused by something else but I think it would be quite the coincidence.

How are you configuring the deployment?
Are you putting the correct env vars into it?

Thanks for the answer, so I thought this was being picked up by the cluster settings but I was wrong I think. I now tried setting the proxy as env var in the deployment and also as a config map and in both cases I get Proxy Timeout. In any case, I think the operator does work indeed and it's on my side that something is wrong

Setting this up locally requires a fair bit of effort, but I can do it, and I'l see what I can discover.

Just another thing to mention, the error I get is when trying to start up the pod, more specifically at step "Trying to become the leader". So after the proxy change in the env, the pod fails to start up properly, that's why I think it's still something on my side.

Can you paste the startup logs ?
Feel free to mask out anything sensitive, but it would help me to see how far along it's getting.

Small update, the pod did start successfully after I set the NO_PROXY env var to the same value as the cluster settings. It seems to connect to the repo now but I get a 422 error. I've changed the namespace and repo name in the logs:
{"level":"error","ts":1603713192.20771,"logger":"controller_repository","msg":"Repository poll failed","Request.Namespace":"my-namespace","Request.Name":"my-repository","error":"server error: 422","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/Users/kevin/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128\ngithub.com/bigkevmcd/tekton-polling-operator/pkg/controller/repository.(*ReconcileRepository).Reconcile\n\ttekton-polling-operator/pkg/controller/repository/repository_controller.go:112\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/Users/kevin/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.5.2/pkg/internal/controller/controller.go:256\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/Users/kevin/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.5.2/pkg/internal/controller/controller.go:232\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker\n\t/Users/kevin/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.5.2/pkg/internal/controller/controller.go:211\nk8s.io/apimachinery/pkg/util/wait.JitterUntil.func1\n\t/Users/kevin/go/pkg/mod/k8s.io/apimachinery@v0.16.5/pkg/util/wait/wait.go:152\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/Users/kevin/go/pkg/mod/k8s.io/apimachinery@v0.16.5/pkg/util/wait/wait.go:153\nk8s.io/apimachinery/pkg/util/wait.Until\n\t/Users/kevin/go/pkg/mod/k8s.io/apimachinery@v0.16.5/pkg/util/wait/wait.go:88"}
Thanks btw for spending the time to help with this, much appreciated :)

New update, stupid mistake on my side but I hadn't changed the branch to master, in your example it was main. I now get a 403 but it looks like it's because there is a limit on unauthenticated accounts (I can resolve the API call on my browser at my local machine). I will now try to figure the auth part since I need it anyhow for the actual repo. Thanks a lot for the help!

Great, let me know if this doesnt't help https://github.com/bigkevmcd/tekton-polling-operator#authenticating-against-a-private-repository

So I have now configured 2 different repositories, one a public repo on Public Github where I do authorise to avoid rate limits and a private one on Enterprise Github where I also authorise. The first one seems to work fine (even though it doesn't trigger the pipeline atm) but for the second one I get a 406 error from Github. Do you know if the operator works with enterprise Github? The URL is <company_name>.github.com and https://api.github.company_name>.com/repos/<org_name>/<repo_name>/commits/master works on Postman.

It should work, but I tested it it against a company.com installation, rather than a company.github.com installation.
Basically, it takes what you provide as the RepoURL, and attempts to talk to https://host/path if you provide a straight github.com then it will talk to https://api.github.com.
I suspect that if you try https://api.company.github.com/my-org/my-repo.git as a repository URL it will work.
If so, I can change the code to detect this case and simplify it.

Thanks for the reply, indeed it works with your suggestion 👍
Not sure how common this URL scheme is for Github Enterprise, but it would be a welcome addition I guess :)
I will now try to see if I have the same issue with not starting the pipeline.


Add infrastructure for running sqlite TCL tests

See https://github.com/superfly/litefs/issues/17
This is very rough but wanted to get something up quickly

This is awesome! Thanks for getting this up and running. Sorry it's taken me so long to review it. I made some minor changes (moving the Dockerfile to the root and calling it Dockerfile.test, etc). I squashed the changes and merged them as https://github.com/superfly/litefs/commit/b98dd8febd2ff683a5716c83c7199a8bd40cea68.

No worries at all on the delay - glad it was helpful!