[$500] IPAD - LHN is missing in IPAD

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Sign in to new expensify app on an iPad

Expected Result:
Able to use NewDot in IPAD
Actual Result:
LHN is missing in IPAD
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[x] MacOS / Desktop
[ ] IOS / IPAD

Version Number: 1.3.66-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/45c984c1-0f91-4f0a-9154-b87592b66e5c
https://github.com/Expensify/App/assets/93399543/e1ee6e0d-36ab-4d21-bbd2-fb0af1e56e63
Expensify/Expensify Issue URL:
Issue reported by: @aswin-s
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693878764944479
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014f2b5dc76517b53d
Upwork Job ID:<PHONE_NUMBER>178431488
Last Price Increase: 2023-09-18

QA team is able to reproduce it on modal: iPad Pro11 2nd gen/iPadOS 15.7

Thanks! I don't have an iPad nor can I test this on Browserstack, so going to add the external label to move this forward.

@aimane-chnaif what's the latest here? have you been able to test this on iPad?

bump @aimane-chnaif ?

@aimane-chnaif what do we need to do to get some more propsals?

@aimane-chnaif should we adjust the bounty here do you think?

added additional context and details for this one - https://expensify.slack.com/archives/C049HHMV9SM/p1695610964837529?thread_ts=1695610733.526209&cid=C049HHMV9SM

This should be already fixed as we have disabled landscape configuration here
https://github.com/Expensify/App/pull/27016

Thanks. @aimane-chnaif what do we need to do to move ahead here?

bumped the slack thread - https://expensify.slack.com/archives/C049HHMV9SM/p1696236374230869?thread_ts=1695610733.526209&cid=C049HHMV9SM

CLosing - as not supporting IPAD bugs - https://github.com/Expensify/App/issues/26421#issuecomment-1702965441

I fully support dropping iPad support, but we should officially drop iPad support in the AppStore in that case to prevent downloads, as the app looks horrendous and is totally unusable.

WOW. Apple won't let us  drop iPad support. This is going to cause us problems in the future, as they have already held releases due to broken iPad functionality...

Started a Slack discussion here, as I don't think we can simply drop iPad support.


Annotations out of sync after concatenate_raws?

I'm working on a dataset where I cut 10 minute chunks out of a 1h recording, do some artifact detection and then concatenate the chunks that interest me. It seems that after the concatenation with concate_raws the artifact annotations are out of sync. I have a minimal example that creates an artificial raw structure that shows this behavior:
import mne
# Generate some random data
data = np.random.randn(5, 1000)*10e-12

sfreq = 100.
# Initialize an info structure
info = mne.create_info(
    ch_names=['MEG1', 'MEG2', 'MEG3', 'MEG4', 'MEG5'],
    ch_types=['grad']*5,
    sfreq=sfreq)

# Create 5 raw structures with annotations at 1 and 2 seconds into recording. Each
# raw has 10s of data
raws = []
for fs in [1000, 100, 12, 2001, 171]:
    ants = mne.annotations.Annotations(onset=[1., 2], duration=[.5, .5], description='x')
    r = mne.io.RawArray(data.copy(), info, first_samp=fs)
    r.annotations = ants
    r.annotations.onset += fs/sfreq
    raws.append(r)

conc = mne.concatenate_raws([r.copy() for r in raws])

# Correct annotations should be visible at 1,2, 11, 12, 21, 22, 31, 32, 41, and 42s
# when calling conc.plot().
corr_ants = mne.annotations.Annotations(
            onset=[1., 2, 11, 12, 21, 22, 31, 32, 41, 42], duration=[.5]*10, description='x')
corr_ants.onset += raws[0].first_samp/sfreq

assert all(conc.annotations.onset == corr_ants.onset) # This should fail

It seems that the way how annotations are combined is buggy. My guess is that the repeated call of mne.annotations._combine_annotations in mne.io.raw.append does not properly subtract and add the necessary offsets. Since this code is fairly central to mne and I don't understand the consequences of changing it I'm not proposing a PR. But for the example above the following code gives a valid annotation for the concatenated raw object:

def combine_annotations(annotations, first_samples, last_samples, sfreq):
    durations = [(1+l-f)/sfreq for f, l in zip(first_samples, last_samples)]
    offsets = cumsum([0] + durations[:-1])
    onsets = [(ann.onset-(fs/sfreq))+offset
                        for ann, fs, offset in zip(annotations, first_samples, offsets)]
    onsets = np.concatenate(onsets) + (first_samples[0]/sfreq)
    return mne.annotations.Annotations(onset=onsets,
        duration=np.concatenate([ann.duration for ann in annotations]),
        description=np.concatenate([ann.description for ann in annotations]))

d = combine_annotations([r.annotations for r in raws],
                        [r.first_samp for r in raws],
                        [r.last_samp for r in raws], sfreq)

assert all(d.onset == corr_ants.onset)

@nwilming indeed there is some problem with the code there.
@jaeilepp is on holiday till the end of the month. Feel free to make a PR with a minimal diff. Your code looks reasonable. Only comment is that you need to take care of the fact that some of the raw files being concatenated may not have annotations.

I think this has to do with the mess with first_samp. I can take a look when I get back.

I think the problem was just with the syncing with raw.plot. See https://github.com/mne-tools/mne-python/pull/3540.


SL2 Line Level / Instrument Level

thanks for creating the interface to edit the SL2 patches. i am new to editing these patches and working out how to use the SL2 in an instrument level rig line for guitar.
would you have any tips on how to edit a patches volume levels so i can make it sit in the instrument level mix? right now, when i turn on the SL2 the signal drops about -6db
thank you

Hey there, I think I can help if you haven't already solved this.
While the slicer is powered on, press and hold the pedal down until the CHECK light flashes.
The TEMPO knob then becomes the LEVEL knob.
adjust as needed.
Press and hold the pedal again to return to normal functions.
Done!

you're a legend, thank you

Hey there, I think I can help if you haven't already solved this.
While the slicer is powered on, press and hold the pedal down until the CHECK light flashes.
The TEMPO knob then becomes the LEVEL knob.
adjust as needed.
Press and hold the pedal again to return to normal functions.
Done!
Edit to add: This will adjust levels globally

thanks for the tip but the setting can't be saved, but it's useful to figure out the global volume level with this function then save it in the patch with the editor andrew hill created


Could not resolve com.sedmelluq:lavaplayer-natives:1.3.13.

> Could not resolve com.sedmelluq:lavaplayer-natives:1.3.13.
  Required by:
      project : > com.sedmelluq:lavaplayer:1.3.22
   > Could not resolve com.sedmelluq:lavaplayer-natives:1.3.13.
      > Could not get resource 'https://jitpack.io/com/sedmelluq/lavaplayer-natives/1.3.13/lavaplayer-natives-1.3.13.pom'.
         > Could not HEAD 'https://jitpack.io/com/sedmelluq/lavaplayer-natives/1.3.13/lavaplayer-natives-1.3.13.pom'. Received status code 522 from server: Origin Connection Time-out

I'm sure I'm doing something wrong, but I don't know what.
I put this under my dependencies
compile 'com.sedmelluq:lavaplayer:1.3.22'

gradle is trying to resolve your dependencies using jitpack, which doesn't have any lavaplayer-natives package, since that's not a github repo.
make sure to add jcenter to your repositories.

It is added to my repositories.

Removing jitpack from my repositories has fixed it.
Thanks for your time,

EazyFTW


Problem with #anchor links

Hi, a couple of problems with anchor links.
By using JS provided in the advanced help section
$( 'a[href^="#"]' ).on( 'click', function( event ) {
  event.preventDefault();

  var target = $( this ).attr( 'href' );

  $( '[canvas="container"]' ).animate( {
    scrollTop: target.offset().top,
  }, 1000 );
} );

It jumps to the anchor point, but no smooth scrolling.
Other anchor links not in the Slidebars don't work.
I got an compiling error on "target.offset().top;". Changing it to "," or nothing let's it compile.

Any help around this issue?

I think the
scrollTop: target.offset().top line should be scrollTop: $(target).offset().top
That should help you.

Thanks, but it did not change any behaviour. It still jumps to the anchor, no smooth scroll.


Resolve a few development-related issues

Gems should specify their dependencies in the .gemspec file, not Gemfile, unless the gem—during active development—needs to reference non-released gems.
A gem should never publish its Gemfile lock, as gems need work with versions of gems bundled with the app.
The gem was relying on an old version of Minitest. Let's bring it up to date to avoid warnings and make it compatible with projects that use latest version of Minitest.

https://trello.com/c/Y4E9sJEB/1825-enhancements-to-stathat-ruby-library

 Enhancements to stathat gem and dev configuration

if/when they start to accept our changes

let's keep this PR around for a couple weeks and see what we hear back from stathat

😭 🙃 😱

Hahaha, took me too much time to understand what was going on here 😂


Compatibility with whitelist plugins that only use nicknames

Hi, I wanted to ask about one possibility with your plugin. As a long time server owner, I am annoyed with the vanilla whitelist system which mostly doesn't work because it adds wrong UUIDs to people and I would like to use nickname whitelist using a plugin which some developer has improved the whitelist system with custom messages etc... I used to use a plugin called Whitelist+, but now I switched to AutoWhitelist (link: ).
Anyway moving on to my problem why am I writing here. Would it be possible to add your plugin support for these custom whitelist plugins? If somewhere in the config there was a request for the path to the whitelist file, which these plugins usually have in their \plugins\pluginname\ folder
In my case, the AutoWhitelist plugin has the path \plugins\Whitelist\whitelist.txt and the file has cleanly typed names for newlines
This would be so awesome because I love your plugin so much since I have the whole Discord server integrated and this makes my whitelisters job so much easier and looks visually nice.
Thanks.
-Sajmon

Hi, I can take a look at supporting this, do you mind resending the link for AutoWhitelist? I think it got left out of the comment.

Oh, sorry
https://dev.bukkit.org/projects/autowhitelist


Feature request: memory limit

I've tried Guetzli on a large batch of images, and my macOS machine ended locking up hard. I presume it's because macOS doesn't fail malloc, but instead switches to using a combination of compressed RAM and swap, which on such a large memory demand bring performance to a halt.
I'm interested in limiting Guetzli's memory use to a percentage of machine's RAM size (e.g. no more than half of all RAM).
Will it be reliable enough if it's done heuristically based on number of pixels in the image?
Is CacheAligned::Allocate used for the majority of allocations? Would it be better to put a limit there?

agrees with you Guetzli's is use to much memory , my linux only have 4gb ram is very lag

Will it be reliable enough if it's done heuristically based on number of pixels in the image?

The 300MB/MPix estimate is reasonable conservative. There is no mechanism that can cause memory usage to grow superlinearly with the size of an image.

I second the memory limit request. This becomes even more important if you run the algorithm in parallel on multiple images at once (to help with the slow performance when batch-processing images.)
I've also found it easy to bring my Mac to a screeching halt. Those with fewer than 16GB of RAM will be especially vulnerable.


data does not arrive properly in req.body when sending data through requestify

Hi Guys,
am not able to send data properly to other server using requestify. can you guys figure it out whats wrong with below data.
POST /1mmh0v8 HTTP/1.1
Host: requestb.in
Content-Type: application/json
app_user_token: 301e415579646e
Cache-Control: no-cache
{"data":[{"user_id":"1","username":"prav","firstname":"prav","lastname":"chel","exit":true,"is_delete":false},{"user_id":"2","username":"hubertp","firstname":"hubert","lastname":"pin","exit":true,"is_delete":false}]}
am not able to receive posted data through requestify . the other end data that what i am receiving is
{"data":[{"user_id":"1","username":"prav","firstname":"prav","lastname":"chel","exit":true,"is_delete":false},{"user_id":"2","username":"hubertp","firstname":"hubert","lastname":"pin","exit":t
i cant able to figure it out. i debugged and checked each and everything still i cant able to figure it out

its working fine guys .. there is some hidden unicode char in the json response . decoded ,figured it out.


How can we play YouTube private video on player.

Users can watch YouTube private videos from my channel with YouTube player, How to do this?

It doesn't seem that the library support user authentication (yet). At least I couldn't find any information about that.
As a workaround you might consider setting the youtube videos as "not listed", so the users still be able to watch the video.


HttpUser on_stop method could not be called via debugger

Describe the bug
When debugging from Vscode, there is no option to call on_stop method in HttpUser. If i click ctrl+c it stops as keyboard interrupted. There must be a way to trigger on_stop
Expected behavior
When we click ctrl+c ,it should run on_stop method code

👍 but dont hold your breath waiting for someone else to fix it for you :)


Include member_keypair_TPM in omnibus include file

Coverage remained the same at 96.127% when pulling 73803af285e3c07a6c2da7e3b0c7faf8e9809ebf on zanebeckwith:fix-tpm-keypair-include into 8a02c7efe699536b2329483107b116ce81fc228a on xaptum:master.


feat(notification): add support for links

Closes IBM/carbon-components-angular#1240
Adds support for links in notifications as part of the NotificationContent interface

@Donisius everything should be good now!


Negeative Point Cloud

Hello , First of all i just want to say thank you for a wonderfull projeckt!
I have a issue : when i use PotreeConverter and open the web site the point cloud is negative. See image

The screen shot where the collors are corrected i activated negative colors in windows.

#rgb Seems similar to this.

@torehovland did you also use a PTX file as input?

Yes it looks similar
I used .xyz file, but i wil definitely try out the solutionsin the other post!
Thanks!

@m-schuetz No i used .xyz

@m-schuetz i also used : ./PotreeConverter.exe C:/data.xyz-o C:/potree_converted -p pageName

@m-schuetz Do you have any suggestions

I found a work-around
Import the model to Cload-compare and export it as .las.
Than use potree-converter as normal


Can we use coveragepy in azure databricks

I wish to generate coverage report on azure databricks, let me know if we can use coveragepy in databricks
Also it would be more helpful, if you can share an example of coveragepy usage in databricks

Sorry, I don't know anything about Databricks.  I suggest reaching out to the Databricks community for help.


[Removal]: Blunt Glossy Raccoon

Hotspot Name
Blunt Glossy Raccoon
Hotspot b58 Address
112ppdNapwFk6vAoH8QAhFoEvaSuSNS1FfR7UTAcE7HNaa8BLM9C
Discord Handle
No response
Hotspot Manufacturer
Heltec Automation
Removal Reason
To whom it may concern, My friends and I were both deployed in the real location and somehow blacklisted. I did not pay attention to the drop in earnings since February 1. They were also not be found on https://blacklist.longap.community/. Then I found the list at denylist.csv. I hope the official will remove my machine from blacklist as soon as possible. Thank you very much.
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
Dear Helium team,
Thank you very much for supporting us all the time. I am writing this e-mail about some machine problems.  however when everything was set up, the earnings appeared very low. I found them are banned spots through website. But the truth was that I deployed them at the right location to provide services to local devices as part of the network.
The machine is inconvenient to take pictures at my friend's father's house

#794


Intermittent Missing Interfaces, Recovery via setConfiguration(0...)

If I unplug/plug in a USB device, about 10% of the time the device object's interfaces is null and never resolves. Additionally, "_configDescriptor" remains undefined. I believe this has something to do with interrupted reads/writes, but I'm not positive.
Things I've tried:
• Delay calling getDeviceList() after USB.on('attach')
• Resetting the device with device.reset()
• Clearing any halted/stalled with endpoint.clearHalt()
Crazily, if I set USB.setDebugLevel(4) I can't reproduce the problem. This points to a timing issue.
Upon studying the API... is device.open(true) truly synchronous? The libusb docs say it's non-blocking, but can we immediately begin with other interactions?
If device.open(false) must be paired with device.setConfiguration(number, callback), then setting the configuration is async, right?
After referencing this:
http://libusb.sourceforge.net/api-1.0/group__dev.html#ga186593ecae576dad6cd9679f45a2aa43
... I tried to setConfiguration(0...) as a recovery method. And lo and behold, it seems to restore the missing interfaces without having to restart my app, or replug a device. 👏
Thoughts?

Closing this issue due to inactivity, please create a new issue as required.


Remove "Browser testing" and "Testing with assistive technologies" from Tabs component page

We don't know if listing the devices/AT in the current manner on the Tabs page is the right approach.
We would like to research this with users but meanwhile we'll remove the "Browser testing" and "Testing with assistive technologies" sections to make Tabs consistent with the other component pages.

You can preview this change here:
Built with commit afe560ac9bd7bacf229a84d083be9b9a1c9a3a87
https://deploy-preview-514--govuk-design-system-preview.netlify.com

Merging as we agreed in standup 👍


Modify shell's pattern to handle locals other than english, fixes #69

As the title said

Yep, makes sense. Cheers! :beers:


Explore better options for project SDK resolution

Right now, the source-build infra uses a special msbuild sdk resolver https://github.com/dotnet/dotnet/tree/main/eng/tools/tasks/SourceBuild.MSBuildSdkResolver to enable using the correct msbuild SDK version when building a repo. We need behavior that achieves this for unified build. Is this the best option? I dunno.
For instance, when you build arcade initially, you want to use the arcade version that the VMR has, not what Arcade's global.json specifies. When you build any repo after arcade, you want to use the newly built arcade SDK, not what that repo mentions in its global.json either.
The custom SDK resolver feels a little bit hacky? Maybe maybe not.

The custom SDK resolver feels a little bit hacky? Maybe maybe not.

Are there things we can infer from the VMR build that would enable us to achieve the same result?

I don't think so? I think the root of the issue is that SDKs are listed in global.json with their versions. The version of the SDK that we need to use in the build will be unknown until we build it.

The custom SDK resolver feels a little bit hacky? Maybe maybe not.

I agree that it is hacky. It copies binaries into the immutable .NET SDK directory. That means that developer won't be able to build with their globally installed SDK (when versions match). That would be very unfortunate as we worked really hard on supporting this in the individual repositories.
https://github.com/dotnet/dotnet/blob/2017edaa9105ca502bc09f6f9cd0346ae2fecdff/eng/tools/tasks/SourceBuild.MSBuildSdkResolver/SourceBuild.MSBuildSdkResolver.csproj#L9C59-L9C92 and https://github.com/dotnet/dotnet/blob/6934a8c588bf8627c9e60aec98c156c3e00bf203/Directory.Build.props#L54C30-L54C42

Totally agree. IMO overriding of the versions of msbuild SDKs should be supported as first class concept.

Would we still need this if we would cloak the global.json file in the individual repos away and unify them into the root global.json one? Or alternatively, if we would update the global.json SDK entries?

We would. Because once you build arcade, you want to use that arcade SDK downstream. And ideally you do so without updating the root global.json. Same goes with the Windows desktop SDK

@marcpopMSFT @dsplaisted @rainersigwald Any opinions here? Some ideas:

Official support in the default SDK resolver for env var based overrides (vs. installing one of our own)
Official support within msbuild for overriding the versions based on properties/envvars (without using an sdk resolver)
Official support for custom resolvers that do not have to be installed in the sdk layout.

@marcpopMSFT @dsplaisted @rainersigwald Any opinions here? Some ideas:

Official support in the default SDK resolver for env var based overrides (vs. installing one of our own)
Official support within msbuild for overriding the versions based on properties/envvars (without using an sdk resolver)
Official support for custom resolvers that do not have to be installed in the sdk layout.

I thought about this further and the SDK resolver solutionrelies on actually finding the resolver on disk. That's a little late if you want to override the version. So the second option seems somewhat better.

Yes the second option definitely sounds better if it would mean that we could express the override versions inside msbuild before the SDK is fetched and used. That would allow us to not depend on env vars.

SDK resolvers don't have access to MSBuild properties, so I think it would still need to be environment variable based.  It would be great to have the support to override SDK resolution built in.  That will require it to be more complicated to ensure it's performant and appropriately cached.  I think @ladipro has been working on performance improvements for the MSBuild SDK resolvers.

The default .NET SDK resolver already has override support using DOTNET_MSBUILD_SDK_RESOLVER_SDKS_DIR and DOTNET_MSBUILD_SDK_RESOLVER_SDKS_VER environment variables. They work only in MSBuild.exe, though, because this code is intentionally skipped in dotnet build. I am currently planning to make changes to:

Bring dotnet build and MSBuild to functional parity w.r.t. SDK resolution (as we found in another investigation, the effective resolution order is different between the two).
Optimize the common case of resolving in-box SDKs (benchmarks show that for simple projects ~5% of build time is spent loading resolver assemblies and invoking resolvers).

If these two environment variables are sufficient to support your scenario I think it would make sense to add them to the dotnet build code path as part of the work.

@ladipro does those env vars also work for other msbuild sdks, not just Microsoft.NET.Sdk? Can you please give an example for the Microsoft.DotNet.Arcade.Sdk on how to override its version and the directory that is looked up?

@ViktorHofer this would work for everything you put in the directory pointed to by DOTNET_MSBUILD_SDK_RESOLVER_SDKS_DIR . Basically the first thing MSBuild would do when resolving an SDK is check if this variable is defined. If it is and the directory contains a subdirectory matching the name of the SDK we're resolving, it would be used. DOTNET_MSBUILD_SDK_RESOLVER_SDKS_VER is used to indicate the version the resolved SDK is pretending to be.
So for Microsoft.DotNet.Arcade.Sdk specifically, it would override the NuGet because all this would happen before the NuGet resolver is called.

@mmitche - It sounds like this ENV would address the issue described in https://github.com/dotnet/source-build/issues/1532.

That sounds great and would solve this issue.

If these two environment variables are sufficient to support your scenario I think it would make sense to add them to the dotnet build code path as part of the work.

Agreed. Do you have a rough ETA on when this work would be ready?

Agreed. Do you have a rough ETA on when this work would be ready?

This should be done by mid January. I still have a few days before the holidays but unless this is P1 for you, I will spend it finishing other work.

It sounds like for the DOTNET_MSBUILD_SDK_RESOLVER_SDKS_DIR environment variable, you might need to copy the rest of the SDKs that are in the dotnet/sdk/<version>/Sdks folder into the same folder as the SDK you're trying to resolve to, otherwise SDKs such as Microsoft.NET.Sdk wouldn't resolve.  Also, you wouldn't be able to specify a separate version for each SDK.  Would that work?

Would it be possible to specify multiple directories in that env var? I.e. DOTNET_MSBUILD_SDK_RESOLVER_SDKS_DIR=<dotnet-sdk>;C:\git\dotnet\artifacts\live-msbuildsdks

This would be new functionality (in dotnet build) so we can make it behave the way it fits your case. At least some parity with MSBuild.exe would be nice but I don't think is strictly required.
Have you considered using a local NuGet package source to restore the package from a local directory? That would let you use a custom SDK today in a less hacky / more supported way.

Have you considered using a local NuGet package source to restore the package from a local directory? That would let you use a custom SDK today in a less hacky / more supported way.

Right, using the NuGet SDK resolver would be sufficient for what we need BUT we still need a way to override the msbuild sdk version specified in the global.json, i.e. we need to use the live produced version of the Microsoft.DotNet.Arcade.Sdk package. Is there a way to change that version dynamically?

Aaah, I think I understand now. For the override to work at NuGet level, you'd need to change at least the contents of NuGet.config, i.e. add a local package source, use a throw-away cache directory to force it to use the local version.. maybe more. But I guess writing to the source tree is undesirable, hence the need for an env-based solution.

Right, exactly. As is mutating the local dotnet SDK.

What does seem to be a general awkwardness is that while much of the build logic can be made customizable on the command line, via passing in global properties, global.json (and to a lesser extent, NuGet.config), are static data files that that require source level edits to customize.

What does seem to be a general awkwardness is that while much of the build logic can be made customizable on the command line, via passing in global properties, global.json (and to a lesser extent, NuGet.config), are static data files that that require source level edits to customize.

With global.json, does that have more to do with being ingrained in the host?

I think that's the case for some elements of global.json, but I would be surprised if the host knows about the msbuild SDK versions?

Right. The msbuild sdk section was added to global.json as they had to be stored somewhere outside of msbuild logic that doesn't require an evaluation. The host doesn't respect that at all.

So after more days thinking about this, here's my take:
We currently need to specify which msbuild sdks get live produced and should be extracted to an intermediate folder in the VMR so that subsequent repositories can depend on it. There are a lot of hardcodes involved (msbuild & env vars) and extracting the nuget packages leads to issues like wrong chmod permissions on Unix and is in-efficient. In addition to that, the current custom resolver is copied into the SDK toolset directory and with that mutates the immutable layout.
Ideally the nuget sdk resolver component would provide a hook (i.e. env var) that allows to override a requested msbuild sdk's version. That would work for all cases that we have today inside the VMR.
For in-built SDKs like Microsoft.NET.Sdk, switches are already exposed that make it possible to point to a specific local folder. As mentioned, we don't use a live Microsoft.NET.Sdk msbuild sdk in the VMR today, but probably want / should at some point.

Ideally the nuget sdk resolver component would provide a hook (i.e. env var) that allows to override a requested msbuild sdk's version. That would work for all cases that we have today inside the VMR and lets us utilize the components/infrastructure that our customers use (common path), instead of building a custom SDK resolver that is hard to get right.

Tagging @jeffkl to comment on this.

For in-built SDKs like Microsoft.NET.Sdk, switches are already exposed that make it possible to point to a specific local folder. As mentioned, we don't use a live Microsoft.NET.Sdk msbuild sdk in the VMR today, but probably want / should at some point.

Would you still like to have DOTNET_MSBUILD_SDK_RESOLVER_SDKS_DIR supported in dotnet build now, or better leave this for when it's actually needed? This would be easy to include in the PR I'm working on, though it's sort of a public contract so ideally we would have thought it through.

The NuGet-based MSBuild project SDK resolver gets its configuration from the NuGet.config and the package ID/version from either the project or global.json.  As far as I know, overriding the package feeds is only possible by changing the NuGet.config.  At least if the MSBuild project SDK versions are in global.json, changing them in the repo at build time would also work.  But if an individual project had something like <Project Sdk="SomeCustomSdk/1.0.0"> that would obviously be harder.
If we wanted to completely override the NuGet-based MSBuild project SDK resolver with environment variables, that's just a feature we'd have to add.  The package feeds and SDKs are potentially more structured data than an environment variable could handle but we can design that if needed.
SET NUGET_OVERRIDE_PACKAGE_SOURCES=https://myfeed/v3/index.json;https://myotherfeed/v3/index.json
SET NUGET_OVERRIDE_MSBUILD_SDKS=SomeSdk=1.0.0;SomeOtherSdk=2.0.0

Does the build system know ahead of time all of the MSBuild project SDKs and versions and only want those specified in an env var to be made available?  Or would the overrides just apply to the ones that are known?

Would you still like to have DOTNET_MSBUILD_SDK_RESOLVER_SDKS_DIR supported in dotnet build now, or better leave this for when it's actually needed?

Ideally we would enable that scenario already now so that we wouldn't be blocked when we decide to or realize that we need to use the live Microsoft.NET.Sdk.

Does the build system know ahead of time all of the MSBuild project SDKs and versions and only want those specified in an env var to be made available? Or would the overrides just apply to the ones that are known?

The latter. We need to override msbuild sdk versions specified in global.json / directly in a project via the <Sdk /> tag for the msbuild sdks that we live build in the VMR.

If we wanted to completely override the NuGet-based MSBuild project SDK resolver with environment variables, that's just a feature we'd have to add. The package feeds and SDKs are potentially more structured data than an environment variable could handle but we can design that if needed.

We were thinking of having an env var per msbuild sdk and make the name similar to the output of NuGet's $(GeneratePathProperty). I.e. Microsoft.DotNet.Arcade.Sdk would become NUGET_OVERRIDE_MSBUILD_SDK_MICROSOFT_DOTNET_ARCADE_SDK. Does that make sense?

@ViktorHofer we have an existing issue about the SDK resolver not being able to respect MSBuild properties: https://github.com/NuGet/Home/issues/7855
Feel free to file a new one about having it also respect versions from environment variables.

Filed https://github.com/NuGet/Home/issues/13301


hi~ g0v Tainan great！

the reason is qr-code png size less than url-loader limit setting, so it compile to base64.
use import to compile.

Thank you so much for fixing this!

This fixes #190


Fatal bug in kernelUtil.cpp that runs undetected due to the amount of memory given to QEMU

In kernel/src/kernelUtil.cpp, there is this code:
    for (uint64_t t = 0; t < GetMemorySize(bootInfo->mMap, mMapEntries, bootInfo->mMapDescSize); t+= 0x1000){
        pageTableManager.MapMemory((void*)t, (void*)t);
    }

which, on 256M of RAM, which is given to QEmu in run.bat, runs perfectly fine.
Yet, allocate 512M of RAM, and the code causes a fatal error. In stock QEMU, this runs in the background, wreaking havoc on the kernel. In QEMU with accel -kvm, and most likely real hardware, this error causes a crash.
Please test the code on 512M to see what I mean.

If I'm not mistaken he once ran the code with 2,048M (2 GB) allocated ram.

i don't know what i did but it somehow works...

i don't know what i did but it somehow works...

BRUH.

very useful information


keyboardDismissMode = "on-drag" on ScrollView not working with Android

🐛 Bug Report
When scrolling in ScrollView when device keyboard active, on Android emulator keyboardDismissMode = "on-drag" does not close the keyboard
To Reproduce
<ScrollView keyboardDismissMode = "on-drag">       {content}   </ScrollView>
Expected Behavior
Keyboard should close when scrolling on Android device.
Code Example
Minimal Expo example
https://snack.expo.io/@hakkikonu/scrollview-bug
Environment
react-native info output:
React Native Environment Info:
System:
OS: macOS 10.14.2
CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
Memory: 369.48 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.15.1 - /usr/local/bin/node
Yarn: 1.13.0 - /usr/local/bin/yarn
npm: 6.5.0 - /usr/local/bin/npm
SDKs:
iOS SDK:
Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
Android SDK:
API Levels: 15, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28
Build Tools: 19.1.0, 20.0.0, 21.1.2, 22.0.1, 25.0.0, 26.0.2, 27.0.0, 28.0.3
System Images: android-15 | Intel x86 Atom, android-19 | ARM EABI v7a, android-19 | Intel x86 Atom, android-21 | Android TV ARM EABI v7a, android-21 | Android TV Intel x86 Atom, android-21 | Android Wear ARM EABI v7a, android-21 | Android Wear Intel x86 Atom, android-21 | ARM EABI v7a, android-21 | Intel x86 Atom, android-21 | Intel x86 Atom_64, android-21 | Google APIs ARM EABI v7a, android-21 | Google APIs Intel x86 Atom, android-21 | Google APIs Intel x86 Atom_64, android-22 | ARM EABI v7a, android-22 | Intel x86 Atom, android-22 | Intel x86 Atom_64, android-22 | Google APIs ARM EABI v7a, android-22 | Google APIs Intel x86 Atom, android-22 | Google APIs Intel x86 Atom_64, android-23 | Google APIs ARM EABI v7a, android-23 | Google APIs Intel x86 Atom_64, android-25 | Google APIs Intel x86 Atom_64, android-25 | Google Play Intel x86 Atom, android-26 | Google APIs Intel x86 Atom, android-27 | Google APIs Intel x86 Atom, android-27 | Google Play Intel x86 Atom, android-28 | Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom_64, android-28 | Google Play Intel x86 Atom
IDEs:
Android Studio: 3.3 AI-182.5<IP_ADDRESS>99772
Xcode: 10.1/10B61 - /usr/bin/xcodebuild
npmPackages:
react: 16.6.3 => 16.6.3
react-native: 0.58.4 => 0.58.4
npmGlobalPackages:
react-native-cli: 2.0.1

👋 there
is this issue still present on RN 59? You posted a repro (thanks for that!) but it's on Snack, which is currently based on latest Expo which is using 0.57.

I'm seeing the same issue RN v0.59.5 on iOS and Android

@kelset Yes, still I'm seeing

RN 0.59.8 still has the same issue here on Android.

Ok thanks everyone - we just released the first 0.60 RC, could anyone try the repro with that version?

@kelset Still happening on 0.60 RC, keyboard will dismiss only on tap but not on scroll.
I don't know if its related but i'm unable to show the keyboard with input.focus() as well.
On iOS everything works fine.

my workaround for now is to call Keyboard.dismiss() in my onScroll function. Its definitely annoying

Any plan for fixing this bug ?

Hi, Im experiencing the issue too , im using 0.59.10 , any work arounds?

@yasir-netlinks
this is the current workaround
onScrollBeginDrag={Keyboard.dismiss}

Repro on RN 0.60.5. FlatList with keyboardDismissMode: 'on-drag' which does dismiss keyboard on drag on iOS, but does not on Android (emulator API 26)

What about 61?

Yes, 0.61.1 too. Still need to monkey patch it.

@kelset  hello , I found why this issues happened, because of the fix in Fix for scrollview android #18785 @mistenkt added the code
this.state.isTouching, but it always return false...

@kelset Hello, I have this problem too, it would like that this problem was solved, thanks.

Hi, same problem here. It still present with React Native 0.61.5

Same problem with 0.61.5, but can confirm the current workaround works.  Need this to work. Any updates?

hello folks - it seems that this bug has been around for quite some time but no one attempted a PR to fix it. If you have time I'd recommend you create a PR with a proper fix and link it here.

still not fixed for 0.62

TLDR
This functionality was never implemented for android and this is a feature request
LONG VERIONS
I think this functionality was never implemented on android
https://github.com/facebook/react-native/blob/9263eb5d3864a42925b699343db2c09cc8934ed0/ReactAndroid/src/main/java/com/facebook/react/views/drawer/ReactDrawerLayoutManager.java#L155
but somehow was included in the documents which should be updated..
The best way to have functionalities like this is using this workaround

No bot.
And no, there's already PR which fixes it: https://github.com/facebook/react-native/pull/26422
I'm using by monkey patching with patch-package, and it works. So merging that would be nice.

@fungilation it's working fine for both Android and IOS ? and if you can share the patch as sample it would be nice, as I am using the patch-package too

my react-native+0.63.2.patch

diff --git a/node_modules/react-native/Libraries/Components/ScrollView/ScrollView.js b/node_modules/react-native/Libraries/Components/ScrollView/ScrollView.js
index c344ac4..0f34d3c 100644
--- a/node_modules/react-native/Libraries/Components/ScrollView/ScrollView.js
+++ b/node_modules/react-native/Libraries/Components/ScrollView/ScrollView.js
@@ -969,6 +969,16 @@ class ScrollView extends React.Component<Props, State> {
     }
   }

+  _handleBeginScroll = (e: ScrollEvent) => {
+    if (
+      this.props.keyboardDismissMode === 'on-drag' &&
+      Platform.OS === 'android'
+    ) {
+      dismissKeyboard();
+    }
+    this._scrollResponder.scrollResponderHandleScrollBeginDrag(e);
+  };
+
   _handleScroll = (e: ScrollEvent) => {
     if (__DEV__) {
       if (
@@ -985,14 +995,6 @@ class ScrollView extends React.Component<Props, State> {
         );
       }
     }
-    if (Platform.OS === 'android') {
-      if (
-        this.props.keyboardDismissMode === 'on-drag' &&
-        this.state.isTouching
-      ) {
-        dismissKeyboard();
-      }
-    }
     this._scrollResponder.scrollResponderHandleScroll(e);
   };

@@ -1175,8 +1177,7 @@ class ScrollView extends React.Component<Props, State> {
         .scrollResponderHandleResponderRelease,
       onResponderTerminationRequest: this._scrollResponder
         .scrollResponderHandleTerminationRequest,
-      onScrollBeginDrag: this._scrollResponder
-        .scrollResponderHandleScrollBeginDrag,
+      onScrollBeginDrag: this._handleBeginScroll,
       onScrollEndDrag: this._scrollResponder.scrollResponderHandleScrollEndDrag,
       onScrollShouldSetResponder: this._scrollResponder
         .scrollResponderHandleScrollShouldSetResponder,

Wow this only took 2,5 year to fix. This is why I love react-native, constant hacking needed 😂


Add Proxarr

Add Proxarr

Please fix the CI failure

Would you mind restructuring the sentence? It reads a little weird to me. Something like, "Prevents Sonarr/Radarr from downloading media already available for your region on streaming services (e.g., Netflix, Amazon Prime Video)."

Done! Thanks for the suggestion


[WFLY-19418]: AMQ229031: Unable to validate user from /<IP_ADDRESS>:…

…62207. Username: null; SSL certificate subject DN: unavailable
reusing the login/password from the initial connection factory .
Jira: https://issues.redhat.com/browse/WFLY-19418

@bstansberry test added, sorry it took so long to create a reproducer

Thanks @ehsavoie


data_pipeline.worker_preprocessor not working as expected

🐛 Bug
In the branch datapipeline_poc_1 when I use DataPipeline.worker_preprocess if the input is List[PIL.Image] I get the following error:
TypeError: pic should be PIL Image or ndarray. Got <class 'list'>
To Reproduce
x: List[PIL.image] = [dataset[i] for i in range(self._data_module.batch_size)]
x: torch.Tensor = data_pipeline.worker_preprocessor(running_stage)(x)

Additional context
The error seems to come from here:
https://github.com/PyTorchLightning/lightning-flash/blob/datapipeline_poc_1/flash/vision/classification/data.py#L193
which can be hacked as return self.to_tensor(sample[0]) but not sure what else can be affected.
Where are those classes/methods tested ?

@edgarriba does this issue still persist on master?

fixed


Caching AVAssets

Hi again @piemonte,
What would be the best way for caching AVAssets for multiple Player instances, i.e. a tableview and in each cell holds a Player instance with a different URL path? I am striving for the same logic being done for images, like in many other image caching optimised examples and libraries specialised with images. I will probably use HanekeSwift or something that I have to build from the ground up. Probably I have to modify or customize the setupAsset function in Player, but I am not certain yet.
I am just curious what comes to your mind about this @piemonte?

+1

+1

+1

I'm doing this with a tableview using this branch at my fork: https://github.com/gazialankus/Player/tree/separating
I separated the contents to a PlayerContents class.
However, this line seems to happen a bit too early and sometimes I see the first frame of the previous video right after the video is loaded:
https://github.com/gazialankus/Player/blob/separating/Sources/Player.swift#L665
I hide/show, remove/add Player, but I still see the first frame sometimes.
Any input or help is appreciated to get rid of this "first frame" bug. Feel free to use this idea to separate assets from Player.

+1

had a big request for caching support, so may add in the coming weeks

+1

🙏 any updates on caching? @piemonte

Can you check this repo? This has resolved the video cache:
https://github.com/wxxsw/GSPlayer

@honga negotiations never finalized on the contract, unfortunately

+1 - Any updates on adding caching support?
Or, does anyone have any suggestions on how to implement your own version of video caching?


Embed Colors in Messages from Bots missing

Describe the bug
On Embeds from Bots are the Embed Color missing.
To Reproduce
Steps to reproduce the behavior:

Enable Zelk Theme
search for an Embed from a Bot
There is the Embed Color Missing

Screenshots

Setup

OS: Windows 11
Client Mod: BetterDiscord 1.3.0
Release Channel: Stable 108924
Enabled Themes: Zelk
Enabled Plugins:
Custom CSS: no
Discord Language: German

I think it's worth moving this code into variables like this:

added a --embed-color variable, you'll be prompted to update as soon as it's approved


nodejs tweaking out(nodejs error)

I'm not very experienced with javascript, but when I used npm to install the required packages/modules(whatever node calls them) I got these warnings:
npm warn deprecated<EMAIL_ADDRESS>this library is no longer supported
npm warn deprecated<EMAIL_ADDRESS>request-promise has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm warn deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.npm warn deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142

At first, I thought "whatever, hopefully it'll still work", but when running the script, node popped out this error:
~ $ node main.js
/data/data/com.termux/files/home/main.js:315
undefined
             ^

Error [ERR_REQUIRE_ESM]: require() of ES Module /data/data/com.termux/files/home/node_modules/pretty-ms/index.js from /data/data/com.termux/files/home/main.js not supported.
Instead change the require of index.js in /data/data/com.termux/files/home/main.js to a dynamic import() which is available in all CommonJS modules.
    at TracingChannel.traceSync (node:diagnostics_channel:315:14)
    at Object.<anonymous> (/data/data/com.termux/files/home/main.js:6:28)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14) {
  code: 'ERR_REQUIRE_ESM'
}

Node.js v22.5.1

It seems to be a problem with outdated code meant for an older release of node. Normally, if this was python or almost literally anything else, I would just fix it myself(and this issue would probably be a pr instead), but unfortunately I have no idea how javascript works so I'm just gonna have to bug you to fix it instead. I doubt anything will happen seeing as this repo hasn't had a commit since last year.

Hey! The error message says that you need to replace the require command with the import command
in your JS files, wherever you find the line
const var = require("abc") where the var and abc can be any variable and package respectively, replace it with
import "something" from "abc"
try this and lemme know if that solves your issue

You can't use the rpc on android using termux, the mobile app no longer has a websocket for presence


next使用畅言问题

我的站点在配置畅言遇到一个问题是PC端和移动端的评论无法互相显示，按照畅言官网的方法配置sid过后还是一样的情况，怎么解决呀？

NexT is rebased into organization repo.
If you want new feature, fix, or support, create new in NexT v6.x repo (desirable in English).
There is instructions on English or Chinese how to update from v5.1.x to v 6.x
You also may read this for details.


Code doesn't build.  Missing usings and incorrect variable names

Does anyone actually build these code samples before publishing them?
Needs
using Microsoft.DurableTask.Entities;
using Microsoft.DurableTask.Client.Entities;
Also
return request.CreateResponse(HttpStatusCode.NotFound);  //request does not exist in current context
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 87e12177-bb3a-d00c-99a5-422e00f9b03f
Version Independent ID: 2fa1cf0d-2a5f-2fb0-ef25-bccfac3279fd
Content: Durable entities - Azure Functions
Content Source: articles/azure-functions/durable/durable-functions-entities.md
Service: azure-functions
Sub-service: durable
GitHub Login: @cgillum
Microsoft Alias: azfuncdf

@skykingjwc
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.


Feature Request: support all file types

Currently only supports a few files, Is there any plan to support more file types.

What file types would you like to support?

@yzhang-gh
such as jsx, js and css file.
Now I use all autocomplete and dic-complteion these two plugin to implement this feature which seems a little complex.

The concern is I try avoiding unwanted completions in certain contexts. For example,
https://github.com/yzhang-gh/vscode-dic-completion/blob/26a131340e14e0085c2a4da4514176a85d2d7158/src/completion.ts#L154-L155
https://github.com/yzhang-gh/vscode-dic-completion/blob/26a131340e14e0085c2a4da4514176a85d2d7158/src/completion.ts#L160-L162
https://github.com/yzhang-gh/vscode-dic-completion/blob/26a131340e14e0085c2a4da4514176a85d2d7158/src/completion.ts#L175-L176
In JS or CSS files, only strings and comments may need completions from the English dictionary.
Are you requesting this?

I used the coc.nvim plugin to provide some common word completions, no matter which file type.
Is it possible to add some arguments to support specified file types, in code context?

我感觉我的意思没有表达很清楚😂
这个插件的目标是：只在写作（并且非编程环境）的时候提供单词补全
而在编程的时候，变量名往往并不是一个单词（可能是缩写 tmp，或者多个单词复合 getWorkspace），纯单词补全不但没什么意义反而还增加了噪音
唯一能用上的地方就是字符串或者注释中
看起来你的希望是 在所有文件中的所有地方都提供单词补全
我个人感觉逻辑上和这个插件本身不合
现在是

和

改之后

了解啦 ^ ^
感谢 🙆

噔噔，v0.9.1 增加了对编程语言的支持（在注释或字符串中提供补全）. 看起来之前你是在写 JS，那就可以用这个新功能啦.


Is there a list of dependencies needed to use this?

I'm on Fedora 25 Linux and I needed to install a lot of development libraries and now, when I try to go get github.com/golang-ui/nuklear/nk I'm getting the error:
# github.com/go-gl/glfw/v3.2/glfw
/usr/bin/ld: cannot find -lXi
collect2: error: ld returned 1 exit status

What am I missing?

Well.. I needed libXi-devel
and also libXinerama-devel libXranr-devel libXcursor-devel


[stable/mattermost-team-edition] Fix automatic restarts on config change

The deployment will restart the pods it controls if the pod spec
annotation changes. By hashing the config and annotating the pod spec
with the hash, the pods will restart whenever the config is changed. The
issue right now is that it did not work to reference config.tpl, but it
does work to reference configmap-config.yaml. When referencing
config.tpl, we only get the first line from the template for some
reason, so only if we would change the first line (\n) of config.tpl
we would get a new hash and restart the pods.
Signed-off-by: Erik Sundell<EMAIL_ADDRESS>What this PR does / why we need it:
It fixes the bug of not restarting when changing values rendered in the configmap-config.yaml.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

thanks so much for this PR @consideRatio i will review

/ok-to-test

/assign

@cpanato oh hmmm hmmm okay while this now works, we have a new thing to consider:
You are automatically generating things in the configmap:
"InviteSalt": "{{ randAlphaNum 32 }}",

This causes the annotation to change on every template generation, or on every helm upgrade.

I will make that a variable. thanks for the catch!

/lgtm
/approve

thanks so much for the fix @consideRatio


Having an error with reCAPTCHA v3 on a Blazor Server project

I followed the instructions for reCAPTCHA v3 (Blazor Server). When executing the following line in SubmitAsync:
var result = await ReCaptcha.VerifyAsync(action: "submit");
The variable result contains the following error:
grecaptcha is not defined
ReferenceError: grecaptcha is not defined
at https://localhost:7233/_content/KITT.Web.ReCaptcha.Blazor/v3/recaptcha-v3.js:3:9
at new Promise ()
at Module.execute (https://localhost:7233/_content/KITT.Web.ReCaptcha.Blazor/v3/recaptcha-v3.js:2:12)
at https://localhost:7233/_framework/blazor.web.js:1:3244
at new Promise ()
at y.beginInvokeJSFromDotNet (https://localhost:7233/_framework/blazor.web.js:1:3201)
at fn._invokeClientMethod (https://localhost:7233/_framework/blazor.web.js:1:62869)
at fn._processIncomingData (https://localhost:7233/_framework/blazor.web.js:1:60344)
at connection.onreceive (https://localhost:7233/_framework/blazor.web.js:1:53985)
at i.onmessage (https://localhost:7233/_framework/blazor.web.js:1:82130)
Please note that I had also added the component tag in my App.razor

Hi @zawarq ...I'm just trying to figure out where the problem could be.
I'm currently review all the samples to use the new Blazor Web App with "Auto" interactivity mode and my code seems working.
May I ask you to try to put the  component above the Blazor javascript file as in this example:
<ReCaptchaScript />
<script src="_framework/blazor.web.js"></script>

If in this way your problem is solved, this is anyway a good point of lack of documentation, so in any case this issue to me is a bug to be solved in some way (code or documentation).
Many thanks!

Hi
I made the changes you suggest and still get the same error. Please note that my application is set to the render mode InteractiveServer through:
<Routes @rendermode="InteractiveServer" />
Do you think this could be causing the issue? The application is needed to be in this mode for certain functionality to work

Thanks! I appreciate your efforts in solving this

Hi @zawarq, finally I have tried to reproduce the problem.
I created a Blazor Web App new project with global Server interactivity but everything seems working to me. I pushed the sample in this branch: https://github.com/albx/KITT.Web.ReCaptcha/tree/bug/31-error-v3-blazor-server/samples/v3/KITT.Web.ReCaptcha.Samples.v3.BlazorServerInteractivity
Maybe you could start from there to compare your solution and try to understand if there are some differences.
Thank you

Thanks @albx ! Changing Program.cs according to this sample did the job!

@zawarq Good!
So the problem was the components registration on the Program.cs? I keep this issue open in order to improve documentation for this use case.
Thank you for your contrib!

Closing with PR #33


Should I apply only to the discriminator?

Should I apply only to the discriminator?
Do not apply spectral normalization to both generator and discriminator?

In the paper, only the discriminator is trained with spectral normalization. The generator uses batch norm.
"We trained the parameters of the
generator with batch normalization" (p. 5 Miyato et al.)


DAC gain should change the range, and not just the voltages being read

Gain setting should not affect the voltages being read back. When writing voltages to DAC with gain disabled, the voltage will be read back as half (i.e. write 4 volts to DAC, this will be read back as ~2). However, when the gain is enabled, the voltage will be read back correctly (i.e. write 4 volts to DAC, this will be read back as ~4). Gain should only change the range that voltages can be inputted, rather than how they are read when they are inputted.

There are few hardware related issue cause this DAC voltage issue.

The Power-on-reset setting of DAC_GAIN GPIO pin
The internal DAC_GAIN amplifier

>>> from edgepi.dac.dac_constants import DACChannel as Ch
>>> from edgepi.dac.edgepi_dac import EdgePiDAC
>>>
>>> edge_dac = EdgePiDAC()
>>> edge_dac.get_state(Ch.AOUT1, True,True,True)
(0, -0.01619785465300083, True)
>>> edge_dac.write_voltage(Ch.AOUT1, 1.000)
6619 # P-1
>>> edge_dac.get_state(Ch.AOUT1, True,True,True)
(6619, 1.0162652694642433, True)
>>> edge_dac.enable_dac_gain(False)
False
>>> edge_dac.get_state(Ch.AOUT1, True,True,True)
(6619, 0.5000337074056213, False)
>>> edge_dac.write_voltage(Ch.AOUT1, 1.000)
13029 # P-2
>>> edge_dac.get_state(Ch.AOUT1, True,True,True)
(13029, 0.9999648620809147, False)
>>> edge_dac.enable_dac_gain(True)
True
>>> edge_dac.get_state(Ch.AOUT1, True,True,True)
(13029, 2.0161275788148303, True)
>>>

On power-on-reset, DAC_GAIN GPIO pin is configured with input direction and state high. get_state() method only checks the state of the pin. As a result, it thinks the DAC_GAIN is enabled when it is not. Therefore the writing 1.000V at P-1 above result in the code value equivalent to 1.000V when DAC_GAIN is enabled. The actual measured voltage is 0.5V. When enable_dac_gain(False) is called, the DAC_GAIN pin is configured to output a low state that actually enforces the state. As a result, the dac_get_state() call returns the correct voltage.
At P-2 when 1.000V is written to the channel, the measured voltage matches the written voltage.
When enable_dac_gain(True) is called, the internal gain is enabled. This internal gain affects the voltage directly without changing the code value in the memory.
A suggested fix for this issue would be determining the range of voltage before writing voltage to any channel after instantiating the DAC module. Or when the range of voltage changes, it also calls write voltage to modify the code values of each active channel to accommodate the change in gain.

@farzadpanahi @jarell-santella
There's an edge case for enable_dac_gain()
the current implementation of enable_dac_gain() has a flag to re-write channel code values when the dac_gain is enabled or disabled.
ex)
enable_dac_gain(True, True)
this reads the code value of each channel and divides the value by 2 then writes it back to the channel. This way, the output voltage stays the same.
enable_dac_gain(False, True)
this does the opposite of the above example. Instead of dividing the code value by 2, it multiplies. However, it only works when the code value is less than half of the maximum range.
To avoid writing the value greater than the maximum code value, it has a condition to check whether the current code value is less than Max_code/2. If it is greater, the code will stay the same.

@sjpark608 I am not sure what is the best solution for this edge case.  the other option is to set it to max in this edge case. because I think the behaviour you mentioned is what will happen in (False, False) scenario.

@sjpark608 I am not sure what is the best solution for this edge case. the other option is to set it to max in this edge case. because I think the behaviour you mentioned is what will happen in (False, False) scenario.

This edge case is for (False, True) where we want to match the output voltage to what it shows on the dashboard after disabling the DAC_GAIN.
ex)

Initially the DAC is set to range 0~10 and 7V.
The user wants to change the DAC range back to 0~5.
If the backend call (False, False), the DAC will just output 3.5V. If (False True) is called, it'd try multiplying the current code value with 2 to keep the current output voltage in the dashboard. However, the value would be over the maximum allowable code value.

as discussed let's throw exception in edge case


fix typo

Note to Hacktoberfest 🎃 participants:
While we appreciate the enthusiasm, we are experiencing a high volume of drive-by pull requests (one-line changes, README tweaks, etc.). Please remember that hundreds of people are subscribed to this repo and will receive notifications for these PRs. Spam submissions will be closed and won't count towards your Hacktoberfest goals.
Please search for issues tagged good first issue or hacktoberfest to find things to work on.
You can also search all of GitHub.

哈喽。这里没有错误。falsy 这个词语指的是“像 false 一样的值”，而不是真的 false。比如 0, "", null, undefined。这些值不是 false，但是有些行为和 false 很像，比如在 if 语句中如果条件传入了【falsy】的值，则不会执行。
原文：https://github.com/reactjs/reactjs.org/blob/master/content/docs/jsx-in-depth.md


PoC using TipTap

This PR is the PoC for using TipTap within the evaluation of text editors being discussed in #4

POC with 3 panels:
Left Panel: List of project's documents
Center Panel: TipTap editor
Right Panel : references and AI interactions

Selecting text in the editor sends it to the backend and shows the result in the AI interactions panel (currently only returning the length of the selected text followed by the uppercased selection)
Clicking on a reference adds it to the editor as a special, uneditable node

The editor supports basic text formatting and draggable collapsible blocks.
Due to tauri's limitation (see this issue), HTML drag events don't work properly with the fileDropEnabled config

Nice! A lot of the comments from https://github.com/refstudio/refstudio/pull/13#issuecomment-1553256104 also apply here.
A few additional thoughts

It's nice to see blocks with handles that can be relocated here.
Text selections showing up in the AI interactions component already! I didn't notice this on the Lexical demo, I think it's working there too.
Toggling block collapse with Cmd-Enter does not work as expected.
File browser +/- not yet working it seems
Vertical scroll within a component not working yet

@sergioramos @danvk @cguedes could y'all review this PR and get it ready for the merge to main?

@sergioramos this is ready for review


bot-teams-authentication-python Teams Sign In Popup closing immediately (working in Webchat)

Hello!
I have been trying to integrate the SSO authentication into my Azure Bot using this repository as a guideline: [https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/bot-teams-authentication/python]
Unfortunately I have been stuck with an issue that is only occuring in Teams. The Bot will send me an adaptive card with a button to sign in:

Clicking on the button opens a popup window with a Microsoft Login screen. Logging in with my Microsoft account causes a new popup to open that contains the Verification Code for the authentication, which has to be pasted into the chat with the bot.
While this process works in the Webchat, in Teams this popup closes after 0.5-1s making it impossible to copy the code.
Clicking again on the button shows this message:

(Sign-In Code is invalid or expired. Ask the bot to send a new sign in link)
I have been able to reproduce this issue in the Webchat by simply also closing the popup with the authentication code, causing the same error message to appear.
Can you look into this issue or is there a known fix?
Thank you! BR, Marvin
Steps to reproduce:

Create new Bot Service in Azure
Create Client secret
Create Web URI with this link: https://token.botframework.com/.auth/web/redirect
Create new OAuth connection in Azure Bot (Azure active directory or AADv2)
Copy git repository into python IDE
Install requirements.txt
Adjust config.py with correct APP ID, PWD and connection name
Adjust manifest.zip with correct APP ID and also validDomains
Start devtunnel on Port 3978
Copy devtunnel link into Azure bot endpoint
Start app.py
Open in Bot in Teams
Write anything
Click on Sign In Button

Thank you for reporting this, we will check this and get back to you.

Hi, sorry for the late response!
Issue seems to have been fixed in the meanwhile. Its working in my environment now!
Thank you for your time.

Done


fix(local-path-provisioner): escape $ from helm

Some more information in discord: https://discord.com/channels/673534664354430999/1063710847890903070

Nice find, this is probably due to flux envsubt.


Light refactoring of some transport code

****************************************************************

libgrpc.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.0%    +200 [None]                                                                               +1.19Ki  +0.0%
      +0.0%    +200 [Unmapped]                                                                           +1.19Ki  +0.0%
      [NEW]    +192 read_channel_args(grpc_chttp2_transport*, grpc_channel_args const*, bool)::settings_    +192  [NEW]

 -------------- SHRINKING                                                                            --------------
  -0.1%     -32 src/core/ext/transport/chttp2/transport/chttp2_transport.cc                              -32  -0.1%
      [DEL]    -382 try_http_parsing(grpc_chttp2_transport*) [clone .isra.4]                                -382  [DEL]
      -9.9%     -65 grpc_core::Chttp2IncomingByteStream::Pull                                                -65  -9.9%
      -0.2%      -8 grpc_create_chttp2_transport                                                              -8  -0.2%
      -0.4%      -3 [Unmapped]                                                                                -3  -0.4%

  +0.0%    +168 TOTAL                                                                                +1.16Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,605      Total (<)      1,955,633

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,844,715      Total (>)     10,844,443

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.0%    +168 [None]                                                                               +1.22Ki  +0.0%
      +0.0%    +200 [Unmapped]                                                                           +1.22Ki  +0.0%
      [NEW]    +192 read_channel_args(grpc_chttp2_transport*, grpc_channel_args const*, bool)::settings_    +192  [NEW]

 -------------- SHRINKING                                                                            --------------
  -0.1%     -32 src/core/ext/transport/chttp2/transport/chttp2_transport.cc                              -32  -0.1%
      [DEL]    -382 try_http_parsing(grpc_chttp2_transport*) [clone .isra.4]                                -382  [DEL]
      -9.9%     -65 grpc_core::Chttp2IncomingByteStream::Pull                                                -65  -9.9%
      -0.2%      -8 grpc_create_chttp2_transport                                                              -8  -0.2%
      -0.4%      -3 [Unmapped]                                                                                -3  -0.4%

  +0.0%    +136 TOTAL                                                                                +1.19Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,954,974      Total (<)      1,955,002

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,844,026      Total (>)     10,843,749

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences


IdentitySelector required is not honored

If I add this to the control
"constraints": {
"required": true
},
it does not listen to it and does not put the red asterisk by the control like the other controls do.  How do I make it required?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a3229bf2-ea0e-a540-ab95-e2541bc07de3
Version Independent ID: cb307ac4-0c97-897e-8444-089b754bf589
Content: IdentitySelector UI element - Azure Managed Applications
Content Source: articles/azure-resource-manager/managed-applications/microsoft-managedidentity-identityselector.md
Service: managed-applications
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

#assign:davidsmatlak

davidsmatlak is not a valid GitHub ID, or is not a collaborator on this repo.

#assign:davidsmatlak

Only Microsoft employees can manage issues via commenting in this repo.

I'll contact the developers about this question and post a comment after I receive a response.

Tested the IdentitySelector control using the constraints property and confirmed it doesn't make properties required.
The IdentitySelector schema doesn't specify support for constraints.
The constraints description in CreateUiDefinition elements mentions that some elements don't support constraints.

@chuckthompsonprofisee Thanks for submitting your question.

I tested the IdentitySelector control using the constraints property and confirmed it doesn't make properties required.
The IdentitySelector schema doesn't specify support for constraints.
The constraints description in CreateUiDefinition elements mentions that some elements don't support constraints.

You can submit feature requests on the Azure feedback forum for review by engineering teams.

#please-close


Value of type 'Transaction' has no member 'environment' in xcode

Value of type 'Transaction' has no member 'environment'

check this link:
https://usmanabid477.medium.com/in-app-purchase-integration-in-react-native-app-96c0acd13649

Facing same problem

did anyone get the solution?

what is your xcode version ?

did anyone get the solution?

what is your xcode version ?

xcode version  13.3.1

you have to update macos and xcode

ok thanks, I will update it

Please update if there is any success on this.

The functionality has been verified on both Xcode versions 14.2 and 14.3.1, and it is working as expected without any issues.

@Abhishek1792 Can you share any sample for example ?

any update on this ??

It works on Xcode versions 14.2 and 14.3.1, and while I found a solution for the older version, it isn't the right method to use.
This code only needs a few comments to function correctly and error-free.
//    if #available(iOS 16.0, tvOS 16.0, *) {
//        environment = t.environment.rawValue
//    } else {
//        let env = t.environmentStringRepresentation
//        if ["Production", "Sandbox", "Xcode"].contains(env) {
//            environment = env
//        }
//    }

I have an older version of XCode (13.2.1), and I had to comment out a few lines in node_modules/react-native-iap/ios/IapSerializationUtils.swift to make it work :
@available(iOS 15.0, tvOS 15.0, *)
func serialize(_ t: Transaction) -> [String: Any?] {
    // comment the next 10 lines of code
    // var environment: String?

    // if #available(iOS 16.0, tvOS 16.0, *) {
    //    environment = t.environment.rawValue
    // } else {
    //    let env = t.environmentStringRepresentation
    //    if ["Production", "Sandbox", "Xcode"].contains(env) {
    //        environment = env
    //    }
    // }

    return ["appAccountToken": t.appAccountToken?.uuidString,
            "appBundleID": t.appBundleID,
            "debugDescription": serializeDebug(t.debugDescription),
            "deviceVerification": t.deviceVerification,
            "deviceVerificationNonce": t.deviceVerificationNonce.uuidString,
            "expirationDate": t.expirationDate?.millisecondsSince1970,
            // "environment": environment, <-- comment this line
            ...

Don't forget to make a patch to keep your changes: npx patch-package react-native-iap

@SamiChab is there any release or update in the react-native-iap on this ?


[stable/locust] support the new

Describe the bug
With the new locust release of locust >=1.0, the config flags have changed for the master/worker to connect, and moving away from previously terms like master slave terminology. This will make easier to use the updated locust images.
Config options are to be updated here. https://docs.locust.io/en/stable/configuration.html
Image specified/to be udpated:
https://github.com/helm/charts/blob/master/stable/locust/values.yaml#L5
Env Variables to be updated:
https://github.com/helm/charts/blob/master/stable/locust/templates/master-deploy.yaml#L38
Master config flags/env vars to be updated

name: LOCUST_MODE_MASTER
value: 'true'
name: LOCUST_EXPECT_WORKERS
value: '5'

Worker config flags/env vars to be updated
https://github.com/helm/charts/blob/master/stable/locust/templates/worker-deploy.yaml#L42

name: LOCUST_MODE_WORKER
value: 'true'
name: LOCUST_MASTER_NODE_HOST
value: {{ template "locust.master-svc" . }}

Additionally worker command needs to be updated with this option or a similar variable
containers:
- command:
- locust
- "--worker"
https://docs.locust.io/en/stable/changelog.html
A clear and concise description of what the bug is.
Version of Helm and Kubernetes:
version.BuildInfo{Version:"v3.3.4", GitCommit:"a61ce5633af99708171414353ed49547cf05013d", GitTreeState:"dirty", GoVersion:"go1.15.2"}
Which chart:
stable/locust
What happened:
What you expected to happen:
Startup the chart
How to reproduce it (as minimally and precisely as possible):
Try using a new image in the values file and the tasks would not run because of old locust syntax and workers not able to interact
Anything else we need to know:
Move this chart into to locust directory

I can contribute to this feature/bug if someone can let me know if they would like to chart to be moved over to https://github.com/locustio/locust

@scottrigby This chart seems pretty much abandoned by this point, and Locust has moved on a lot since then. In the issue above that @nickhalden opened on locustio/locust, the locust team pointed towards this chart https://github.com/deliveryhero/helm-charts/tree/master/stable/locust that deploys locust 1.3.0 (the stable chart is currently pinned to 0.9.0, the docker images that feed the chart stopped being updated past 0.14.5). It might be worth reaching out to the maintainer of that chart to see if it could become the new stable chart.


Prerender:true error

Hi there, thanks for the great tutorial.  As I turned prerender: true .
I got this error..  I searched in issues and someone had a similar error but in different context.  Could you help me out?  thanks!
`
ERROR in SERVER PRERENDERING
Encountered error: "uninitialized constant #Class:0x00007fa4ec57e638::ExecJS"
when prerendering HelloWorld with props: {"name":"Stranger"}
code:
    (function() {
      var railsContext = {"railsEnv":"development","inMailer":false,"i18nLocale":"en","i18nDefaultLocale":"en","rorVersion":"11.2.1","rorPro":false,"href":"http://localhost:3000/hello_world","location":"/hello_world","scheme":"http","host":"localhost","port":3000,"pathname":"/hello_world","search":null,"httpAcceptLanguage":"en-US,en;q=0.9","serverSide":true};
          ReactOnRails.clearHydratedStores();

      var props = {"name":"Stranger"};
      return ReactOnRails.serverRenderReactComponent({
        name: 'HelloWorld',
        domNodeId: 'HelloWorld-react-component-48dffa88-d404-4a79-9368-09cea348084d',
        props: props,
        trace: true,
        railsContext: railsContext
      });
    })()

`

I'm actually getting this precise error. I'm sidestepping Foreman in favor of Docker Compose, but it appears to achieve the same end. Here are my relevant configurations:
docker-compose.yml
version: '3'
services:
  db:
    image: postgres
    volumes:
      - ./tmp/db:/var/lib/postgresql/data
  web:
    build: .
    command: >
      sh -c "rm -f tmp/pids/server.pid &&
      rails s -p 3000 -b '<IP_ADDRESS>'"
    volumes:
      - .:/deploy
    ports:
      - "3000:3000"
    environment:
      - WEBPACKER_DEV_SERVER_HOST=webpacker
    depends_on:
      - db
  webpacker:
    image: cc_web
    env_file:
      - ".env.docker"
    command: >
      sh -c "rm -rf public/packs/* || true &&
      bundle exec rake react_on_rails:locale &&
      bin/webpack -w"
    volumes:
      - .:/deploy
    ports:
      - "3035:3035"

webpacker.yml
version: '3'
services:
  db:
    image: postgres
    volumes:
      - ./tmp/db:/var/lib/postgresql/data
  web:
    build: .
    command: >
      sh -c "rm -f tmp/pids/server.pid &&
      rails s -p 3000 -b '<IP_ADDRESS>'"
    volumes:
      - .:/deploy
    ports:
      - "3000:3000"
    depends_on:
      - db
  webpacker:
    image: cc_web
    command: >
      sh -c "rm -rf public/packs/* || true &&
      bundle exec rake react_on_rails:locale &&
      bin/webpack -w"
    volumes:
      - .:/deploy
    ports:
      - "3035:3035"


API documentation

Recently, when working on this PR, I needed to learn about a bunch of viv functions. The natural place to look is viv_api.py. Taking one real example:
def get_run_status(run_id: int) -> dict[str, Any]:
    """Get the run status."""
    return _get("/getRunStatus", {"runId": run_id})

The documentation here is too limited to help me quickly understand what I'd like to understand. How does viv do this? What are the possible statuses? What other metadata might go in the output dict? What language is /getRunStatus implicitly in? How could I find out this info?
I looked through a bunch of folders that didn't contain the answers. Eventually Sami showed me schema.sql, general_routes.ts, and raw_routes.ts. where all this is implicitly documented.
Ideally I would have liked to create a PR for this, but I'm not sure what viv devs think is the right level for documentation to be at. (viv_api.py docstrings? Markdown tutorials? Somewhere else?) Happy to kick this off if someone has an authoritative answer.

Yes seems reasonable to have docs for Vivaria API endpoints!
I'd like to autogenerate them. If possible, from the TypeScript route definitions, not from Python code. The TypeScript should be the source of truth for the API endpoints' request and response body shapes.
I see e.g. https://github.com/jlalmes/trpc-openapi for turning tRPC to OpenAPI, then we could use e.g. Redoc to generate docs for the OpenAPI spec. I feel like this might not carry code comments through, though.
I don't see a good way to autogenerate API docs in a way that would carry comments through.

I'm very interested in improving this documentation (and intend to do so). I'm having similar difficulties myself. I'm adding such documentation to functions as I understand them, and at some point I intend to check if the comments could automatically become OpenAPI and so on. And yes I agree that autogenerating from the typescript is the way to go. (but I'd have to investigate how it's done, I'm a nodejs noob)

Vivaria has a script server/src/scripts/zod-to-json-schema.ts that can generate a JSON Schema from a Zod type. Maybe we could reuse some of that logic.

I don't think that creating a json schema would be a significant help because you'd still need to refer to it. The code already somewhat refers to Zod, I vote for adding the documentation in those objects.
In the example in the description here, I think we're mainly missing more specific types (what is -> dict[str, Any]: ? I vote being more specific. Is it dict[RunIdType -> RunType]?)
I am of course in favor of being able to convert whatever our source of truth is (for example, zod) into everything else (for example, json schema), just don't think it would help here

Only if we auto generate the Zod from the json schema. Otherwise we'll have an extra source of truth that will get out of sync
[I feel pretty strongly about this but open to hear I'm missing something]

No, my suggestion was autogenerating the JSON Schema from the Zod. I agree that there shouldn't be a separate source of truth.

I see.
So I'm not against.
I do think the bottleneck (or whatever the word is here) is "make the zod very clear" (it currently often isn't imo) rather than "take the existing zod and turn it into a different format of docs / json-schema",
but again, I'm not against.


[WIP] High Content Screening OME-NGFF example

I'm trying to add an HCS example dataset, here's a WIP PR for this.
Motivation: Provide example data in the OME-NGFF High Content Screening format spec
My example dataset contains 2x2 field of views (fovs) for a single well, with label images, already saved in the OME-Zarr HCS spec. Additionally, I have feature measurements for each site saved as csvs and an example script that loads those measurements and saves them as an AnnData table per site. The saving seems to work nicely and I have an AnnData tables folder per fov. Really cool to see this working already!
Current issues:

I don't have a nice way to share example data. It's currently on a Google Drive, but my attempts to use gdown to download it from there directly have failed. Does anyone know an easy way to fix this? At the moment, one needs to follow the instructions in the example file to manually download the data first, unzip the OME-Zarr file & then run the example.

It seems the load_to_napari_viewer function is flipping x & y dimensions here. Is that intentional? When I open my images with the napari-ome-zarr plugin, they are displayed like this:

But when I open them with load_to_napari_viewer, x&y dimensions are flipped for the images (but not for the label, thus making the label not match the images anymore)

It appears the loading isn't designed to handle the plate spec. I haven't had time to look into it much. At the moment, I just load the first field of view, because load_to_napari_viewer throws a zarr.errors.ContainsGroupError: path 'tables' contains a group if I provide e.g. the full well (and full plates currently don't support displaying label images in ome-zarr-py, see here: https://github.com/ome/ome-zarr-py/issues/65#issuecomment-1155295470

Solved Issues:

I also used the library originally to save my label images to the OME-Zarr file. Saving 3D label images needed axes parameters & I added parsing for those for label images (not used in the example anymore, but maybe useful to somebody else)

The upper image is opening it with the napari-ome-zarr plugin. With the plugin, it works as expected, because the dimensions are zyx.
My impression is that the load_to_napari_viewer function flips the x & y dimensions. Maybe that was to support images saved in non-standard OME-Zarr fashion? i.e. saved as zxy so far?

Got it. I think that must be due to an issue with our test data having flipped axes. In any case, this won't be the final reader/writer code implemented, so I think it's okay for now. Thanks for flagging!


"Rate it" shouldn't appear on a note which reader has already rated

Describe the bug
Rate it button appears for a CN which I've already rated.
Expected behavior
I should not be asked to Rate it if I've rated it.
I can't always remember if I've already rated a particular note or not, especially since some posts may have several notes.
Screenshots
I get invited to rate a note:

But when I click on the button I get told I've already rated the CN. In this case there are additional notes, but maybe I don't want to rated additional notes, or there may be no additional notes.

Environment
Firefox (latest)

It appears has been fixed (https://x.com/CommunityNotes/status/1753214807640326290?s=20)


Added code that should've been moved

Corey Kaylor wrote:
I meant to move that code to the CreateLogQueuesAction, but it looks like I forgot.
See https://groups.google.com/group/rhino-tools-dev/browse_thread/thread/f94fbee3228c696f/ed3759228baa73fb?hl=en&lnk=gst&q=messageloggingmodule#ed3759228baa73fb for details

This won't get pulled out because it will break for rhino queues.


Last attempt in the wild goose chase to make this code simpler...

I had one last idea for how to do this in a simpler way, and this time made sure the tests are actually working too. I realized that there's no benefit (that I can think of) to having one map from X to task set manager, and a second mapping from task id to X; we might as well just directly store a mapping from TaskId to task set manager.  Let me know what you think.

@kayousterhout I like the code cleanup of this change, but I think we might be stuck b/c of cancelTasks.
I do like the change from
val taskIdToStageIdAndAttempt = new HashMap[Long, (Int, Int)]

to
val taskIdToTaskSet = new HashMap[Long, TaskSetManager]

at least, though I know you were hoping for a bigger cleanup.


FR: make it possible to place button link in redactor field

Add a custom button to redactor to display links as buttons
style button with tailwind classes

Added in commit 4c68c54


Ignore JSX?

Has anybody requested an option to ignore JSX when formatting? Is that a possibility?
I love the JS formatting. Generally the prettier-formatted JS ends up looking great. I find that when it comes to JSX, though, I'm willing to make more compromises when it comes to long line length and stuff.
Currently, the one thing that prettier does that I don't think I'll ever get used to is it puts closing > on their own line if the JSX line exceeds max length.
export default function FooterNavbar() {
  return (

        <NavLink to="/article">
          News
        </NavLink>

  );
}

This happens a lot if you have real long props, such as className, etc. I find that this formatting ends up making things less understandable at a glance due to the hanging > all over the place. I realize that in this situation there's not really a great solution, because either you go with > on their own line, which I think looks bad, or you put the > at the end of the JSX line, which can make it visually blend with the child elements. No real great solution, imo, but I tend to prefer the latter just to avoid > on their own lines.
export default function FooterNavbar() {
  return (

        <NavLink to="/article">
          News
        </NavLink>

  );
}

This is a situation where I tend to just let really long JSX lines exceed the max width for sake of readability.
export default function FooterNavbar() {
  return (

        <NavLink to="/article">
          News
        </NavLink>

  );
}

Currently, the one thing that prettier does that I don't think I'll ever get used to is it puts closing > on their own line if the JSX line exceeds max length.

Facebook coding style is also to put it the way you currently do it. Right now prettier follows the airbnb style guide and there isn't any option to configure that. More examples like this are great to make a case for evaluating more options.

This is a situation where I tend to just let really long JSX lines exceed the max width for sake of readability.

There is another issue where a similar this is requested for long descriptions of tests. I could see not splitting in multiple lines when:

There is only one prop
The value of the prop is a string

as it's not likely going to make the output look worse and not make a huge difference trying to be < 80 columns.

@ryancole
I implemented this option (with the code from @vjeux in #474) as "jsxFbCloseTag" in arijs/prettier-with-tabs.
Please give it a try! 😃

@rhengles wow, this was fast!

I like @vjeux 's proposal of not breaking due to a single long attribute.
@ryancole do you think you could theoretically stomach the dangling > in cases such as this?
<SomeHighlyConfiguredComponent
  onEnter={this.onEnter}
  onLeave={this.onLeave}
  onChange={this.onChange}
  initialValue={this.state.initialValue}
  ignoreStuff={true}
>

and the children go here

and here too

</SomeHighlyConfiguredComponent>

@rattrayalex I mean, preferably I'd be able to put that trailing > at the end of the last JSX line, but I'm not going to raise a big stink over it or anything. I understand why some folks like it as it is, in your example, too. I personally think both ways sort of look bad, but I personally think the > at the end of the last line is the lesser of the two (ignoreStuff={true}>).

From my view, we are open to the idea of adding a few more configuration options, with that being one of them. However, in my opinion we should give that decision a long time to be made. If people still want that after using prettier for several weeks, we can talk. If we implemented a config option for every tweak that looked weird to someone new, we'd have a ton of them, but I'm betting that once you use it for a while that will become the new norm.
Our brain tends to adapt to whatever we're using the most. That doesn't mean there aren't a few things we should give on, though, like bracket spacing and the few other config we have.

I might suggest either closing this issue (perhaps citing #488) or renaming it to "[JSX] Add configuration option for >on newline".
Closing it for now and re-opening the latter if it persists as an issue might be worthwhile, depending on how you want to run things @jlongster .

Let's close this one and if someone wants to create an issue for the > position that would be great.

Yeah, I'd prefer to not leave issues open. I haven't been too stringent on issues recently because I've been able to spend full-time on this and it hasn't been too bad, but over time we shouldn't let issues linger.
We can think about adding an option for this in a while if users are still really wanting that.

We can think about adding an option for this in a while if users are still really wanting that.

It would definitely make my life easier selling it inside of Facebook.


setup telemetry and add account_connected event

Summary
Setup telemetry for ServiceNow.
Track account_connected event when the user succeeds to connect their ServiceNow account.
server/telemetry has been mostly copied (with some tweaks) from pluginapi package in order to avoid being forced to upgrade to mattermost-server/v6.
A couple of opportunistic improvements done in Makefile to speed-up builds while developing.
Ticket Link
FIxes https://mattermost.atlassian.net/browse/MM-51748

@trilopin Can we wait for that PR to be merged?

yes, no prob

Codecov Report
Patch coverage has no change and project coverage change: -1.38 :warning:

Comparison is base (fefb220) 65.22% compared to head (63143f0) 63.84%.

:exclamation: Current head 63143f0 differs from pull request most recent head 9c1eb3e. Consider uploading reports for the commit 9c1eb3e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   65.22%   63.84%   -1.38%
==========================================
  Files          16       17       +1
  Lines        1990     2033      +43
==========================================
  Hits         1298     1298
- Misses        653      696      +43
  Partials       39       39

Impacted Files
Coverage Δ

server/plugin/activate_hooks.go
0.00% <0.00%> (ø)

server/plugin/api.go
68.79% <0.00%> (-0.22%)
:arrow_down:

server/plugin/configuration.go
38.46% <0.00%> (-2.64%)
:arrow_down:

server/plugin/plugin.go
62.06% <ø> (ø)

server/plugin/telemetry.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

closed in favor of https://github.com/mattermost/mattermost-plugin-servicenow/pull/183, where we protect min_server_version by avoiding pluginapi update.


157 update board interface

The interface changes have been made. They assume that the sensors always have new data when queried. This hasn't caused strange behavior, and I believe that is how it was done before changing the interface. Just something that seems odd.

@JMoore5353 @bsutherland333
I am curious as to your thoughts with the having the SENSOR_has_new_data() methods always returning true.

There was a bug with the return true, so I adjusted it to match the imu_new_data which uses gazebo time. This can be easily switched to generic sim time when we finally disconnect gazebo.


[Github] fix: Add visibility to block defaults

1. Why is this change necessary?
Without this change, when you switch the layout type in the administration to "Listing Page" it results in an error and a not visible block:

Note that on saving it is set anyway:
https://github.com/shopware/shopware/blob/db40a63b963056473632f5709ed38ace84a60ae1/src/Administration/Resources/app/administration/src/module/sw-cms/component/sw-cms-page-form/index.js#L58
2. What does this change do, exactly?
Add the visibility to the default block configuration, as far as I can see this is the only place where it is used in the default administration.
Not sure where or how to add a test though.
3. Describe each step to reproduce the issue or behaviour.
Change the layout type to "Listing Page".
4. Please link to the relevant issues (if any).
-
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Imported from Github. Please see: https://github.com/shopware/shopware/pull/3842

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-37699.
[created from NEXT-37699, comment 485190]


Added support for clientOptions in generated code; Fixed several ApiView issues

Added support for clientOptions in generated code; removed a few sync withResponse APIs that were accidentally left in; Removed a bunch of unused generated code; added tests for telemetry and distributed tracing
Code updates include:

Reduced the generated API surface by removing sync and other unused generated APIs.
Added clientOptions to builder classes.
Removed a few synchronous attestation APIs that shouldn't have been created.
Stopped using the auto-generated builder in favor of manually creating the pipeline to ensure that User-Agent is correctly set.
Fixed a couple of telemetry related bugs and added tests to verify that tracing headers are correctly generated.

All SDK Contribution checklist:

[X] The pull request does not introduce [breaking changes]
[X] CHANGELOG is updated for new features, bug fixes or other significant changes.
[X] I have read the contribution guidelines.

General Guidelines and Best Practices

[X] Title of the pull request is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[X] Pull request includes test coverage for the included changes.

API changes have been detected in com.azure:azure-security-attestation. You can review API changes here
API changes
-         opens com.azure.security.attestation to com.fasterxml.jackson.databind;
-         public AttestationAdministrationClientBuilder addPolicy(HttpPipelinePolicy customPolicy)
+         public AttestationAdministrationClientBuilder addPolicy(HttpPipelinePolicy policy)
+         public AttestationAdministrationClientBuilder clientOptions(ClientOptions clientOptions)
-         public Response<AttestationResult> attestOpenEnclaveWithResponse(BinaryData report, Context context)
-         public Response<AttestationResult> attestSgxEnclaveWithResponse(BinaryData quote, Context context)
-         public AttestationClientBuilder addPolicy(HttpPipelinePolicy customPolicy)
+         public AttestationClientBuilder addPolicy(HttpPipelinePolicy policy)
+         public AttestationClientBuilder clientOptions(ClientOptions clientOptions)

API changes have been detected in com.azure:azure-security-attestation. You can review API changes here
API changes
-         opens com.azure.security.attestation to com.fasterxml.jackson.databind;
-         public AttestationAdministrationClientBuilder addPolicy(HttpPipelinePolicy customPolicy)
+         public AttestationAdministrationClientBuilder addPolicy(HttpPipelinePolicy policy)
+         public AttestationAdministrationClientBuilder clientOptions(ClientOptions clientOptions)
-         public Response<AttestationResult> attestOpenEnclaveWithResponse(BinaryData report, Context context)
-         public Response<AttestationResult> attestSgxEnclaveWithResponse(BinaryData quote, Context context)
-         public AttestationClientBuilder addPolicy(HttpPipelinePolicy customPolicy)
+         public AttestationClientBuilder addPolicy(HttpPipelinePolicy policy)
+         public AttestationClientBuilder clientOptions(ClientOptions clientOptions)

/check-enforcer override


Add more information to long async logs

Explain your changes:

Annotate every usage of try_with with a ~here parameter
Print callstack of O1trace.thread and O1trace.sync_thread calls
Remove O1trace.sync_thread for check_next_block_timing in block_producer.ml

Logs from it are too polluted due to recursive design

These changes ease investigation of long async cycle by allowing to determine the subsystem in which the long async cycle was generated.
Explain how you tested your changes:

Tested on a private cluster, successfully used in investigation of a long async cycle

Checklist:

[x] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[x] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[x] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[x] All tests pass (CI will check this if you didn't)
[x] Serialized types are in stable-versioned modules
[x] Does this close issues? None

Closes #0000

!ci-build-me

!ci-build-me

!approved-for-mainnet

Force merging since the gating bot isn't working.


How to Download?

https://github.com/Xakkit/Xakkit#installation

https://github.com/Xakkit/Xakkit#installation

RTFD


[bug] Solito starter not working correctly

The latest solito starter template doesn't work for Expo. Yeah the CI might be giving it a pass but in reality it doesn't load the styles correctly. I would like one of the contributors to try it out. The next.js side of things work fine but when opening the Expo app, components are not what we see in the next.js version.
To Reproduce
Simply follow your installation instruction on the website:
npm create tamagui-app@latest

Ah, thought I fixed this in the last release but left a couple lines out, fixed in fb2e3342a5fbef2e95d54dd3da80ece41e54cb8b and beta 207. Thanks for the report.

Hi @natew ,
Thanks for looking at the bug quickly but the useMemo fix didn't work, I suspect it's related to the "@my/ui" package:
Here are the screenshots of Next.js version and Expo app, notice the sheet button from starter template, it's not circular and layout is not getting enforced in Expo app. If you can spot what's the issue let me know:
Next.js:

Expo:

That’s a different bug fixed in the latest release that just went out.

Tried out the latest release - upgraded via yarn upgrade:tamagui
Now metro builder reports this error and hangs my laptop completely:
iOS Bundling failed 17363ms
Unable to resolve "./icons/user" from<EMAIL_ADDRESS>

Deleted yarn.lock and node_modules, issue went away. Maybe the upgrade script doesn't work every time.

Also, the latest release fixed the original issue. Thanks Nate!


feat: logging

Fix #30

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


cosmetic fix: exemple -> example

"example" is the correct English word; "exemple" is French

That's right!