fix: larger batches

Fixes #1596
Related: https://github.com/philipturner/metal-flash-attention/pull/16

https://github.com/philipturner/metal-flash-attention/pull/16#issuecomment-1898868823

If the current fork works for your use case, that's great. The whole point of open-sourcing it and the build process. But the main repo is going to keep the more flexible API. This is a more workable approach from a software engineering perspective.

Good points from Phil.
I've now changed to just using a buffer, but still requires changes to MFA so we will forever be on a fork. Thoughts @Narsil?

If we are going to be in a fork forever, I'd rather apply the previous solution as it's simpler and requires less memory initialization.
However, if the buffer solution can be merged upstream, then I'd totally go for it.
I don't fully understand Phil's comment about a better software engineering approach. I'd prefer to understand the actual use cases it unlocks. Batching is a clear use-case to me.

I'd prefer to understand the actual use cases it unlocks. Batching is a clear use-case to me.

Let's say you want to multiply a series of 8 RHS matrices over an over again, by several sets of 8 LHS matrices. This is not something achievable with cublasXgemmStridedBatched. It requires a rule-based offset pattern that wouldn't be possible with a fixed stride.
0 x 0
1 x 1
2 x 2
3 x 3
4 x 4
5 x 5
6 x 6
7 x 7
8 x 0
9 x 1
...

You can probably think of an easier solution. Make the N dimension of the RHS matrix just 8x larger. But you see how the choice of where a matrix starts, where it ends in memory, is something left to the user. One might want a non-contiguous memory layout where the 49th and 50th matrices skip 200 units of memory. One might source matrix data from another tensor, originally reshaped at a different dimension — any padding within the original tensor changes the memory spacing. Emulating an irregular sliding window (sliding window attention). Overlapping accesses to the same matrix. Writing C into a subrange of a KV cache. There is a combinatorial explosion of use cases.

I don't fully understand Phil's comment about a better software engineering approach.

The better approach is to keep the main repo as it is. What happens in the divergent fork is up to you.

This should be finalized now, you can see the single line change for batching on my fork here: https://github.com/FL33TW00D/metal-flash-attention/blob/feature/larger-batches/Sources/GEMM.metal#L269


Quickly clicking tags/categories causes strange behavior

I achieved this by clicking quickly between tags or categories. Usually I get the {{==}}, but you can see one time I did produce a different result.

Probably an issue with async code execution.
Since rendering the view is basically the main functionality of the website, possibly switching to synchronous execution could alleviate the issue.


added react-tooltip package

removed reactstrap tooltips due to crashing on mobile

https://github.com/reactstrap/reactstrap/issues/1425
Tried fixing using suggested "delay" but unsuccessful as hover and onclick still conflicting


fix: remove image().refine from a code snippet in guides/images.mdx

Description (required)
Since v5, we cannot use refine() with the image() helper, so I updated an outdated example in guides/images.mdx.
I also slightly reworded the sentence above the code snippet because I believe this is no longer validated with Zod. But happy to revert or to reword if I'm wrong.

Related issues & labels (optional)

Closes #10151
Suggested label: code snippet update

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File
Note

en/guides/images.mdx
Source changed, localizations will be marked as outdated.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


fix translate my note es

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/27592
PROPOSAL:
Tests

Go to Settings > Preferences >Language
Change Language to Spanish
Go to any chat with another user
Click on header
Go to Private notes, and verify that "My note" translated to Spanish "Mi nota"

[x] Verify that no errors appear in the JS console

Offline tests
The same test

QA Steps
The same test

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/39086067/1ba43241-03e4-4940-bc6a-2a8951a37cb2

Android: mWeb Chrome

https://github.com/Expensify/App/assets/39086067/28baad53-e3a8-4229-925b-ff8d7678fefd

iOS: Native

https://github.com/Expensify/App/assets/39086067/6c0fd6a6-9b4b-4455-b3a1-1d5602ecd5f0

iOS: mWeb Safari

https://github.com/Expensify/App/assets/39086067/2e1d98aa-1b37-4b51-b3b5-bc0289c43842

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/39086067/40c93e86-3843-4512-9448-46b14fed4190

MacOS: Desktop
https://github.com/Expensify/App/assets/39086067/3e744958-e3b4-4081-a220-3f3ad154f4b5

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.88-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


test-azure-win2016-x64-1 : OutOfmemory, please check?

test-azure-win2016-x64-1 extended.functional tests hung with OutOfMemory, can we check for any issues please?
https://ci.adoptopenjdk.net/job/Test_openjdk16_j9_extended.functional_x86-64_windows/45/consoleFull
05:47:08  [SoftmxRASTest2] [INFO] Starting RAS testcase 2:
05:47:09  JVMDUMP039I Processing dump event "systhrow", detail "java/lang/OutOfMemoryError" at 2021/03/25 05:47:09 - please wait.
05:47:09  JVMDUMP039I Processing dump event "systhrow", detail "java/lang/OutOfMemoryError" at 2021/03/25 05:47:09 - please wait.
05:47:09  JVMDUMP032I JVM requested Java dump using 'C:\Users\jenkins\workspace\Test_openjdk16_j9_extended.functional_x86-64_windows\openjdk-tests\TKG\output_16166408282638\SoftmxRASTest2_0\javacore.20210325.054709.9044.0001.txt' in response to an event
05:47:10  JVMDUMP010I Java dump written to C:\Users\jenkins\workspace\Test_openjdk16_j9_extended.functional_x86-64_windows\openjdk-tests\TKG\output_16166408282638\SoftmxRASTest2_0\javacore.20210325.054709.9044.0001.txt
05:47:10  JVMDUMP013I Processed dump event "systhrow", detail "java/lang/OutOfMemoryError".
05:47:10  JVMDUMP032I JVM requested Java dump using 'C:\Users\jenkins\workspace\Test_openjdk16_j9_extended.functional_x86-64_windows\openjdk-tests\TKG\output_16166408282638\SoftmxRASTest2_0\javacore.20210325.054709.9044.0002.txt' in response to an event
Aborted by Andrew Leonard
10:18:06  Sending interrupt signal to process
10:18:11  PASSED: testSoftmx_RAS_Test_2

Hmm, actually looking at a good test run that Passed, this testcase causes an OOM:
05:16:40  [SoftmxRASTest2] [INFO] Starting RAS testcase 2:
05:16:41  JVMDUMP039I Processing dump event "systhrow", detail "java/lang/OutOfMemoryError" at 2021/03/23 05:16:41 - please wait.
05:16:41  JVMDUMP032I JVM requested Java dump using 'C:\Users\jenkins\workspace\Test_openjdk16_j9_extended.functional_x86-64_windows\openjdk-tests\TKG\output_16164674842500\SoftmxRASTest2_0\javacore.20210323.051641.4860.0001.txt' in response to an event
05:16:41  JVMDUMP010I Java dump written to C:\Users\jenkins\workspace\Test_openjdk16_j9_extended.functional_x86-64_windows\openjdk-tests\TKG\output_16164674842500\SoftmxRASTest2_0\javacore.20210323.051641.4860.0001.txt
05:16:41  JVMDUMP013I Processed dump event "systhrow", detail "java/lang/OutOfMemoryError".
05:16:42  PASSED: testSoftmx_RAS_Test_2
05:16:42
05:16:42  ===============================================
05:16:42      SoftmxRASTest2
05:16:42      Tests run: 1, Failures: 0, Skips: 0
05:16:42  ===============================================

https://ci.adoptopenjdk.net/job/Test_openjdk16_j9_extended.functional_x86-64_windows/44/consoleFull

Looks like a openj9 issue, raised: https://github.com/eclipse/openj9/issues/12289


Fix controller yml

In khi_robot_bringup/config/rs007l_controllers.yaml
    constraints:
      goal_time: 2.0                   # Defaults to zero
      stopped_velocity_tolerance: 0.1 # Defaults to 0.01
      lower_joint1:
        trajectory: 0
        goal: 0.2
      lower_joint2:
        trajectory: 0
        goal: 0.2
      lower_joint3:
        trajectory: 0
        goal: 0.2
      lower_joint4:
        trajectory: 0
        goal: 0.2

Correct joint names are joint1 ~ 6
but settings are lower_joint1 ~ 4.
Similar descriptions are found in
khi_robot_bringup/config/rs007n_controllers.yaml
khi_robot_bringup/config/rs007l_controllers.yaml
khi_robot_bringup/config/rs013n_controllers.yaml
khi_robot_bringup/config/rs080n_controllers.yaml
khi_rs_gazebo/config/rs007n_gazebo_control.yaml
khi_rs_gazebo/config/rs007l_gazebo_control.yaml
khi_rs_gazebo/config/rs013n_gazebo_control.yaml
khi_rs_gazebo/config/rs025n_gazebo_control.yaml
khi_rs_gazebo/config/rs080n_gazebo_control.yaml
This PR changes ..

rename lower_joint1~4 -> joint1~6.
change the trajectory and goal  value to default: 0.0.

The reason to set default values is to not change robot move from previous versions.

Thank you for opening the PR.
I checked this change. I will merge this PR.


Analytics of need magnitude, by area, by organization type, etc

As we saw before, states/govt entities are interested in our dataset because we have visibility into PPE needs beyond those of formal healthcare systems.
A few ideas for analytics to run:

Relative magnitude of need, to direct donations to areas with greatest need? (suggested by @saikatbhadra)

Once we get categories backfilled (see https://github.com/findthemasks/findthemasks/issues/277), we could look at what % of requests are coming from each category. My sneaking suspicion from looking at our dataset is that home health care, nursing homes/skilled nursing, and group/residential care facilities are underserved and in the greatest need.

@marcuscollins

Hope to finally get to this today.

Great; we just got an inquiry from someone on behalf of groups of donors about which areas have most need, so this will be super helpful.

@4kbt  - some ideas for blog post #2? maybe


Netatmo massive error log

Home Assistant release with the issue:
0.85.1
Last working Home Assistant release (if known):
None for me
Operating environment (Hass.io/Docker/Windows/etc.):
Hassio on docker/Ubuntu 18.01
Component/platform:
Netatmo
Description of problem:
The Netatmo component gives errors in the log all throughout the day.
This is not new for the 0.85.x. Just wondering is it the Netatmo API that causes this, or the
component. The log under is for humidity but happens for all values connected to the unit.
BUT, the sensor is working as expected for all values.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):
Log Details (ERROR)
Fri Jan 18 2019 18:25:31 GMT+0100 (Central European Standard Time)

Update for sensor.netatmo_fosshaug_ute_humidity fails
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity.py", line 221, in async_update_ha_state
    await self.async_device_update()
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity.py", line 349, in async_device_update
    await self.hass.async_add_executor_job(self.update)
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/sensor/netatmo.py", line 159, in update
    self.netatmo_data.update()
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/sensor/netatmo.py", line 363, in update
    for module in self.data:
TypeError: 'NoneType' object is not iterable

Additional information:

Does anyone know how I can supress this error message. The log files up all the all time. Have tried setting components to critical only.

@jonare77 In my case the Wifi connection of the netatmo base was suboptimal. I found a new location for the base und I updated the firmware to 137. Since then the data in the cloud dashboard has no delay anymore and the messages in the HA log are gone.


TO-DO LIST WEB PAGE

This is TO-DO list page done using HTML  , CSS and Javascript

just make another file with your username.html and copy the code from index.html to that and then make changes.
Refer to Issue1


Relax version constraint on rainbow, allow 3

There do not appear to be any breaking changes that
should concern rubocop.
https://github.com/sickill/rainbow/blob/master/Changelog.md

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests (N/A)
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests(rake spec) are passing.
[x] The new code doesn't generate RuboCop offenses that are checked by rake internal_investigation.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

changelog entry removed

i can't wait to make a tom clancy joke when rainbow releases version 6


Turf: what can it do for OutbreakMappers

https://www.mapbox.com/blog/turf-government-data/

https://www.mapbox.com/blog/walkability-with-turf/
https://www.mapbox.com/blog/walkability-with-turf/
https://www.google.com/search?q=site%3Awww.mapbox.com+inurl%3Ablog+turf&oq=site%3Awww.mapbox.com+inurl%3Ablog+turf


Bug Report: get_instruction_addresses returning 0 instructions

Hello,
Thank you for creating such great plugins. I have identified a small issue with the Tenet plugin that I would like to address. Specifically, I noticed that the get_instruction_addresses function returns zero instructions when running certain programs, such as /bin/ls. After debugging, I determined that this issue comes from the code snippet that drops data segments, as shown below:
if seg.sclass != ida_segment.SEG_CODE:
    continue

Although I was able to resolve the issue by removing this code, doing so may slow down the loading of traces. I would like to explore alternative solutions to this problem to ensure optimal performance of the plugin while still preserving its functionality.

I resolved the issue by changing that code to the following,
if seg.sclass != ida_segment.SEG_CODE and seg.sclass != ida_segment.SEG_DATA
...


Request to update Readme...

Hi,
The library available is not compatible with .net 4.5, please update it to c# 7 i.e 4.7 for rebuild purposes.
Thanks

At the moment we don't have any plans to port it because we have a few legacy systems depending on this. Can you elaborate on your use case? If it is just for using it with your project then I would recommend using the NuGet package instead of adding this project to your solution.


fix(registration): fix region mapping

Description
Changed the mapping of Region Field with District
Why
User is sending this data from FE which is sent via BE using District field to BPDM but when user try to fill it again from BPN search it becomes null as it is mapped with another field in BPDM
Issue
#979
Checklist
Please delete options that are not relevant.

[x] I have followed the contributing guidelines
[x] I have performed a self-review of my own code

@MaximilianHauer should this be included in 2.2.0 or in main?


Added V2C Trydan charger.

Added V2C Trydan charger:
https://v2charge.com/trydan/

@pmec could you please contact<EMAIL_ADDRESS>

No progress, closing.

I would be interested in this integration progressing. Would it be possible that I contact<EMAIL_ADDRESS>instead of @pmec doing it?

Of course!

There is one fix for a bug that I introduced on the fists commit.
I've committed just now.
@aleixpellicer if you wish, you can maintain this device code.

@andig should I do another PR for the fix?


[Beginner]How to open the ［Location Services］ screen of IOS by react-native？？

How to open the ［Location Services］ screen of IOS by react-native？？
By the way. I tried the way to open location services screen like this.
if (&UIApplicationOpenSettingsURLString != NULL) {
   NSURL *url = [NSURL URLWithString:UIApplicationOpenSettingsURLString];
    [[UIApplication sharedApplication] openURL:url];
}
else {
  // Present some dialog telling the user to open the settings app.
}
but it not work!!!
PS. I am also a Beginner Of the Objective-c.

Think if its better to ask this question on: https://stackoverflow.com/questions/tagged/react-native

@facebook-github-bot stack-overflow


Expose ServerEnvironment via a capability

Issue: https://issues.redhat.com/browse/WFCORE-6321

/retest

Core -> Full Integration Build 12635 outcome was FAILURE using a merge of 1815b7142033cea79920bc5b5626bf4b1b8e32ae
Summary: Tests failed: 1 (1 new), passed: 7315, ignored: 122 Build time: 03:21:24
Failed tests
org.wildfly.test.integration.elytron.oidc.client.propagation.OidcIdentityPropagationTestCase(standalone-enabled-elytron-oidc-client-test).testServletToEjbSingleDeploymentOutflowNotPossibleTrustNotConfigured: java.lang.AssertionError: Unexpected result alice,false
	at org.wildfly.test.integration.elytron.oidc.client.OidcBaseTest.loginToApp(OidcBaseTest.java:383)
	at org.wildfly.test.integration.elytron.oidc.client.propagation.OidcIdentityPropagationTestCase.testServletToEjbSingleDeploymentOutflowNotPossibleTrustNotConfigured(OidcIdentityPropagationTestCase.java:569)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor52.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor51.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor50.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor15.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor13.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor17.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor16.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor15.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor13.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
------- Stdout: -------
 [0m12:41:38,904 INFO  [org.wildfly.security.http.oidc] (default task-1) ELY23004: Loaded OpenID provider metadata from 'http://localhost:32936/realms/WildFly/.well-known/openid-configuration'
 [0m

@parsharma we need the Jira Issue on the commit message and PR title.

Core -> Full Integration Build 12571 outcome was FAILURE using a merge of 3be5b14631be1cbfa9a170ade4120a6f2946f697
Summary: Exit code 1 (Step: Build & test full (Maven)) (new) Build time: 00:04:46

Core -> WildFly Preview Integration Build 12653 outcome was FAILURE using a merge of 3be5b14631be1cbfa9a170ade4120a6f2946f697
Summary: Exit code 1 (Step: Build & test full (Maven)) (new) Build time: 00:05:08

Core -> Full Integration Build 12772 outcome was FAILURE using a merge of 3be5b14631be1cbfa9a170ade4120a6f2946f697
Summary: Tests passed: 1439, ignored: 18; exit code 1 (Step: Build & test full (Maven)) (new) Build time: 00:09:40

@parsharma errors are legit.
You still need to address all the pending points commented on above: add a Jira number to the PR title, use an alias for the service, add a comment to the @Deprecarte annotation, review any usage of the current service server/src/main/java/org/jboss/as/server/ServerEnvironmentService.java#SERVICE_NAME and replace it with the capability, ensure the capability is correctly registered. In addition, when done, please squash the commits in a single one.
If you are pushing changes but you still think there is pending work to do, please, move the PR to a draft so we can ignore its review until is done from your side, thanks!

@yersan I will change it to draft because I am still working on it. Thanks for the review comments. I will update the code soon.

Core -> WildFly Preview Integration Build 12666 outcome was FAILURE using a merge of 179eb0125e3a1db8bffdbbc928cde93084ed61fa
Summary: Exit code 1 (Step: Build & test full (Maven)) Build time: 00:06:24

Core -> Full Integration Build 12587 outcome was FAILURE using a merge of 179eb0125e3a1db8bffdbbc928cde93084ed61fa
Summary: Exit code 1 (Step: Build & test full (Maven)) Build time: 00:09:04

Core -> Full Integration Build 12793 outcome was FAILURE using a merge of 179eb0125e3a1db8bffdbbc928cde93084ed61fa
Summary: Tests passed: 1443, ignored: 18; exit code 1 (Step: Build & test full (Maven)) Build time: 00:12:41

Thanks, @parsharma and @pferraro!


Implement XSS prevention measures

Please consider adding XSS countermeasures for this product. It's possible to run an arbitrary JavaScript code.
To reproduce

go to https://letsmarkdown.com/
Get the generated URL ( https://letsmarkdown.com/pink-things-6832 )
Add the following details

<img src=1 onerror="console.log(top.document.body.innerHTML='Unexpected_Page')">

Ask people to access https://letsmarkdown.com/pink-things-6832

Suggested Fix
Consider disabling HTML feature on src/components/Score.tsx, or use the sanitizer package while HTML is turned on.
https://github.com/Cveinnt/LetsMarkdown.com/blob/d88c75b132e60733a5bc3eae43cf72d82eaafa4d/src/components/Score.tsx#L30
I assume HTML tags are not required for the most of the time.
Reference: https://github.com/markdown-it/markdown-it/blob/master/docs/security.md

Hi @stypr , thanks for pointing this out - really appreciate the effort!
Unfortunately I do not have the time to work on this yet -  would you consider making a pull request that might fix this?


Remove text trim

This was added when we were computing the width without adding "pre" behavior. Now it is no longer an issue
Test plan:

Create a text with "  a  a   "
Commit the text, make sure it looks the same
Edit the text, make sure it still has the spaces

I'd make keep trimming on paste. The common case is you copy some text on a website, mistakenly with spaces around it.

Honestly, I'd rather not mess up with the input from the user...

This breaks the vertical alignment of text in Firefox (mac) for me. #417 was the original issue.

Huh. The peril of having code comments instead of tests :smile:.

@jamesblight  https://github.com/excalidraw/excalidraw/pull/999

Thanks @dwelle


fix:TraceId null or empty judgment

resolved https://github.com/masastack/MASA.Scheduler/issues/351


Commit 616e82e7 works

This works,
https://github.com/mlavik1/GodotVolumeRendering/commit/616e82e7
Not the latest ones

Hi @GeorgeS2019 ,
Thanks for notifying me. What issues are you having?
For me it works on both Linux (Ubuntu) and Windows, but it's not that straight forward..

Clone the repository
Open the project in Godot (.NET build)
In "MSBuild" tab, click the build-butotn
Open Project settings - Plugins - and enable the volume rendering plugin
Select the "VolumeContainerNode" and click "Import dataset" in the properties window.
(I believe that last step is what changed since that commit you linked)

The documentation warned that .NET plugins is still a bit experimental, but I might have done something wrong as well.. I'm new to making Godot plugins, so I'll do some more reading this weekend :)

I compare the Godot codes to the Unity code.
Beside the shader and compute shader (there are now NEW Godot compute shader demo project under the Repos Godot Demo Project), the port should be straight forwards.

I compare the Godot codes to the Unity code.
Beside the shader and compute shader (there are now NEW Godot compute shader demo project under the Repos Godot Demo Project), the port should be straight forwards.

Thanks! I'll have a look at that too :)


Adding BigQuery support for legacy SQL.

Fixes #1607.

Not sure how long this has been around but there is a branch miss in gcloud.stream.transfer.

@dhermes Coveralls makes me cry.

OK. I'll try to clean that up soon-ish.

I've got that one

@tseaver Any issues with this PR?

LGTM

@dhermes @tseaver thank you!


Roll engine 2e8e96fad1ad..2302bea9cf08 (7 commits)

https://github.com/flutter/engine/compare/2e8e96fad1ad...2302bea9cf08
git log 2e8e96fad1ad..2302bea9cf08 --no-merges --oneline
2302bea9c Roll src/third_party/skia 9369031fde2d..c9873a5f8b8e (11 commits) (flutter/engine#6287)
71457a67d Roll dart to c688d0c0c3ad3dece3a79ce0e115d787a94707ea. (flutter/engine#6285)
150135929 Roll src/third_party/skia 1d6281d4bb47..9369031fde2d (27 commits) (flutter/engine#6284)
f3d51b0cf Fix Top, Left, and Right padding for fullscreen android apps. (flutter/engine#6282)
7ec1d211e Compute maxIntrinsicWidth based on the width of styled runs added to the line breaker (flutter/engine#6281)
2b25fd7da Don't use unix or win namespaces (flutter/engine#6277)
60c5bb86d Return null instead of throwing if an instance method is passed to PluginUtilities.getCallbackHandle (flutter/engine#6260)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@rmistry @liyuqian : New roll has been created by https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Trybots failed. These were the failed builds: https://flutter-dashboard.appspot.com/build.html

Commit queue failed; closing this roll.


Mark uimanager annotations as deprecated in new architecture

Summary:
This diff marks uimanager annotations as deprecated in new architecture becasue we've decided the native codegen will not be addopted in new architecture
changelog: [internal] internal
Differential Revision: D51228379

Closing as abandoned internally


[BUG maybe] sample_baked_with_rotation return wrong rotation when offset=0

Godot version
v4.1.stable.official [970459615]
System information
Godot v4.1.stable - Windows 10.0.19045 - Vulkan (Mobile) - integrated AMD Radeon(TM) Vega 8 Graphics  () - AMD Ryzen 5 3550H with Radeon Vega Mobile Gfx (8 Threads)
Issue description

As shown in the picture above, when the curve offset is 0, the rotation angle seems to be incorrect. I just get the rotation of the offset (contained in the transform) and then copy the sprite2d to this position.
The other offset are correct, And I've also looked at existing questions and there doesn't seem to be the exact same problem as mine.
code as below.

Thanks for any help.
Steps to reproduce
1, create a Node Path2D
2, invoke path2d's curve with sample_baked_with_rotation(0) # only offset=0 seemd not correct
3, display path in debug and run
Minimal reproduction project
Curve2DSampleTest.zip

It seems that there is also a problem with the calculation of point positions.
I just want the image to line up across the entire curve

Can reproduced in 4.2.dev6
The rotation at the start and end of the curve remains in the state when handle vector is 0.
path-start-end.webm

Is there anyone who can follow up on this issue please?


timeout query per server in 20seconds

so that if i have server that does: "sleep 30; return 200" it will be reported as "err: aborted in 20 seconds"

use a timeoutclient, smth like https://github.com/refiito/timeoutclient (if know/find smth better, use that)


8 Update and rename content/actions/quickstart.md to محتوى/الاجراءات/qu…

…ickstart.md

Why:
Closes [issue link]

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

0x52dCF5BEdc061604D8C592B0079A0FF2ceA22eB7
All thing to
0x3EA21b58B8F73bB70A8df9Fb4528246668BAE46E

El vie., 17 sept. 2021 12:06, yasminazaze @.***>
escribió:

0x52dCF5BEdc061604D8C592B0079A0FF2ceA22eB7
All thing to
0x3EA21b58B8F73bB70A8df9Fb4528246668BAE46E
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/docs/pull/10134#issuecomment-921949516, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AVPAARXTXCLNWNAOCI74EMLUCNYSTANCNFSM5EHFDCGQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Memory leak: ExpandoMetaClass' retaining old gen heap with weakrefs

Context:
In-development news site for biggest Belgian brand using Thymeleaf + this decorator provided and suggested by Spring Boot.
Problem statement:
Old-gen heap is overrun by Groovy - classes from this decorator.

Short-term solution provided
Removal of this layout decorating dependency and using core thymeleaf includes where needed.

Long-term solution expectations
Finding and fixing this memory leak so we can use  this great layout decorator. Has anyone been having the same issue?

How timely - I'm working on memory and performance improvements at this very second and doing some profiling to see how it's all going 😁  I've got a general performance GitHub issue over at #102, and the first item I was tackling was the memory thing as previous issues raised and fixes made around them have shown some really good gains.
To answer your question though: yes, other people have been seeing similar things (see #122), and I've been able to tackle them on a case-by-case basis to the point of being good enough for the use case of the person raising the issue, but just now I'm taking another view of the whole thing to find out where some more gains can be made.
The current (release) state of things
I've developed a simple test project over the course of the memory issues that uses a basic layout and every dialect feature in it, that I then hit with JMeter to simulate continuous load.
Libraries:

thymeleaf-3.0.2.RELEASE
thymeleaf-spring4-3.0.2-RELEASE
spring-context.4.3.3.RELEASE
spring-web-4.3.3.RELEASE
spring-webmvc-4.3.3.RELEASE

Using 2.0.4, the current latest version of the layout dialect:

Main takeaways:

old generation space at 99MB used at the end of the test
groovy.lang.ExpandoMetaClass having a retained size of ~52MB
27 million objects created
35 garbage collections over the course of the test
test took about 3 minutes 10 seconds to complete (started around the 30 second mark)

An in-development state of things
I've just uploaded a 2.1.0-SNAPSHOT which, as per my comment on the general performance GitHub issue:

removed more uses of dynamic objects/classes as a follow-through of #122, taken to the extreme

Results:

Main takeaways:

old generation space at 21MB at the end of the test (~80% improvement)
groovy.lang.ExpandoMetaClass having a retained size of ~119KB (~99.99...% improvement!!!  I had to scroll to find the item on the list as it wasn't even in the first page of results any more!)
6.6 million objects created (~75% improvement)
20 GCs over the course of the test (~40% improvement)
test took about 1 minute to complete (~66% improvement.  I ran this test 3 more times and even restarted all the tools just to make sure I wasn't screwing something up!)

I've got several more things to work on, so these are the results as of posting.  Future snapshots may be better or worse, but I expect them to hover around these results since it looks like one of the worst performance offenders was tackled.
If you, or anybody watching this repo, would like to try out the performance improvements, then feel free to put the 2.1.0-SNAPSHOT branch into your project and please report your results.

Thanks for quick response, E.
Could you push the 2.1.0-SNAPSHOT - branch? We can't locate it. We'll put it through exactly the same stress test which gave above results.

Heya, I'm gonna be away from the computer that has that code for the next day (maybe it'll feel like 2 in your timezone), so can't push the source code branch 😞  I did however upload the artifact to Maven, so if you configure Maven/Gradle for snapshot repositories and pick the 2.1.0-SNAPSHOT version, you should be able to add it to your project to test.
Alternatively, the Maven snapshot repository can be navigated with your browser so you can download the built artifact here: https://oss.sonatype.org/content/repositories/snapshots/nz/net/ultraq/thymeleaf/thymeleaf-layout-dialect/2.1.0-SNAPSHOT/thymeleaf-layout-dialect-2.1.0-20161017.092221-3.jar

Did you manage to get the snapshot version working on your project without the source code?  Otherwise, I'm finally home and have managed to upload the in-development performance improvements to a performance branch which you can check out here: https://github.com/ultraq/thymeleaf-layout-dialect/tree/performance

We put the 2.1.0-SNAPSHOT through the same set of tests.

Results above. We can see a significant improvement, which confirms your claims. Young gen, survivor, and old gen all remain stable.

Any idea when you're releasing?

Woohoo!  That's good news 😀
As for when there'll be an official 2.1.0 release, that will be at least 2 weeks away - there's a 2.0.5 bug fix version I'm working on now, and several more general performance-related ideas I want to try get in as per the other GitHub issue I linked to before.  I'll be keeping the snapshot version updated with all main branch fixes, but it is still a while away.

FYI, I've just released 2.1.0 today.


Fix typo on 02.06-Boolean-Arrays-and-Masks

do ---> to, In phrase "We are then free do operate..."

Thanks!


New Device - Outon S1 Floor Lamp

Outon S1 RGBCW floor lamp and RGB strip
Firmware Dump:
Outon_S1-MF18228-RGBCW-floor-lamp-and-RGB-strip.bin.zip

v1.1.3 posted offers to update to 1.1.5
1.1.5_boot.txt
1.1.5_Outon_S1-MF18228-RGBCW-floor-lamp-and-RGB-strip.zip

Added version to old, added profile for new version.


Add spec creation validation for the SubRequestType parameter

Impact of the new feature
ReqMgr2
Is your feature request related to a problem? Please describe.
Given that we started using this field to take decisions in different parts of the system (mostly microservices as far as I remember), we better add some validation and make sure the data type and the value is as expected.
Here is its definition: https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/WMSpec/StdSpecs/StdBase.py#L1035
Describe the solution you'd like
Add a validation function for the SubRequestType field. It needs to be evaluated during request creation, and request creation should fail if the provided value does not pass the validate function.
The supported values for this parameter are (still discussing with Justinas/PdmV the last bits):
["MC", "ReDigi", "Pilot", "RelVal", "HIRelVal", "ReReco"]

if value is not provided, it should default to an empty string.
Describe alternatives you've considered
Not add this validation and suffer the consequences in the future.
Additional context
none

@justinasr Hi Justinas, it looks like another development will depend on this field, so I think right now is the best moment to get this validation in place (to be deployed in production in the next week). Could you please review the list of allowed values above? @jordan-martins and @haozturk might have some input as well.

Hi @amaltaro,
Looks good to me, McM uses "MC", "ReDigi" and "Pilot", RelVals use "RelVal" and fingers crossed for "ReReco" TaskChain becoming a thing.

Great! Thanks for the prompt confirmation, Justinas! We seem to have everything in place and ready to deploy in testbed today.


[FEATURE] NVMe/TCP

Is your feature request related to a problem? Please describe
iSCSI is a bottleneck when using nvme ssd volumes.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
Make possible to use NVMe/TCP instead of open-iscsi
Describe alternatives you've considered
Mayastor
Additional context
Add any other context or screenshots about the feature request here.

@orboan  +1 According to #3377 and https://github.com/longhorn/longhorn/issues/3037#issuecomment-930651029.
The bottleneck might be in communication. @yasker @innobead @shuo-wu @joshimoo  Maybe this should be done before #3202?

@keithalucas  you are right. Maya guys pointed out these concerns as the main reasons for them to  start Mayastor. As @yasker  pointed out early that it is too much work for longhorn go nvme style, hence had been so long way to come, it is about more than two years now, I believe. So I am wondering if there is a way to forward step wise.   Maya guys pointed out these concerns as the main reasons for them to start Mayastor. As @yasker pointed out early that it is too much work for longhorn go nvme style, hence had been so long way to come, it is about more than two years now, I believe. So I am wondering if there is a way to forward step wise. Otherwise, it look like nothing happening, like in the past two years. :(

We are evaluating engine/replica part feature parity right now so this is what @keithalucas is working on. It will come to the development phase after all ongoing evaluations are done. This is our priority because people are expecting and we hear.

@keithalucas do you have any performance numbers on your SPDK prototype versus the iSCSI that longhorn currently supports. I would be very interested in seeing that as a justification for why Longhorn should add native NVMe and NVMe-oF support. I am a huge fan of NVMe so I do like the idea of supporting it, but only if the performance numbers justify it.

Attaching a whitepaper published by lightbitslabs comparing performance of iscsi and nvme/tcp on same hardware
NVMe-vs-iSCSI.pdf
Summarising it here

Any movement on this?


Loose "esy " sandboxing restrictions

Currently esy <command> overrides $PATH env var so some of a user's commands stop working. We should make it not override $PATH but augment it instead.

We found that esy vim won't work because esy strips the environment so cleanly that the $SHELL env var is even reset, so Vim doesn't load anything useful.

I found another case where we really want pure behavior, and I thought I'd document it for future reference.
For global installations we want to create a set of wrapping scripts that appear to be binaries binaryName but where:

binaryName is in the global npm modules path.
binaryName is a wrapping script thatcds into the right directory then calls esy binaryName to call the real binary.

When you call binaryName from the CLI, it gets picked up by the global npm install paths - not esy. When the binaryName wrapper script runs esy binaryName, esy should be pure and scrub away the npm PATH. Why?

We don't want esy binaryName to invoke the wrapper script itself! (could that infinitely loop?)
If binaryName (the actual binary, not wrapper script) were to call anotherBinaryName, we don't want it to see the wrapper scripts, because that would cause loading of environment twice.

So as it is the current implementation of esy works really well for these wrapper scripts, but if we make esy command more "relaxed" this approach will no longer work and the wrapper scripts must be updated to use esypure command.


ValueError: No more features left.  Check to make sure that the sample names between sample-metadata and table are consistent

Running the stand-alone version of gemelli on the example data used in the tutorial I get the error ValueError: No more features left.  Check to make sure that the sample names between sample-metadataandtable are consistent
As I'm not a Python person, I filter the example data in R.
mdat <- read.table("IBD-2538/data/metadata.tsv", sep='\t', header=T) # nrow(mdat) 516
ftbl <- biomformat::read_biom("IBD-2538/data/table.biom")
ftbl <- as(biomformat::biom_data(ftbl), "matrix") # ncol(ftbl) 470

mdat <- mdat %>% filter(sample_name %in% colnames(ftbl))
rownames(mdat) <- mdat $sample_name

ps <- phyloseq(otu_table(ftbl, taxa_are_rows=T),
                   sample_data(mdat))
# here I skip adding the taxonomy

ps <- metagMisc::phyloseq_filter_prevalence(ps, prev.trh=0.2, abund.trh=10, abund.type="total", threshold_condition="AND")

> ps
phyloseq-class experiment-level object
otu_table()   OTU Table:         [ 236 taxa and 318 samples ]
sample_data() Sample Data:       [ 318 samples by 128 sample variables ]

# Do we need to filter to only keep subjects with >=t timepoints?

biomformat::write_biom(biomformat::make_biom(t(otu_table(ps))), "table_filt.biom")
write.table(sample_data(ps), "metadata_filt.txt", sep="\t", quote=F)

Having made sure that samples match between the feature table and the metadata (plus filtered the our rare stuff), I run gemelli and get the following error
gemelli \
--in-biom table_filt.biom \
--sample-metadata-file metadata_filt.txt \
--individual-id-column 'host_subject_id' \
--state-column-1 'timepoint' \
--output-dir results

Traceback (most recent call last):
  File "/Users/johannesbjork/python/miniconda3/bin/gemelli", line 8, in <module>
    sys.exit(standalone_ctf())
  File "/Users/johannesbjork/python/miniconda3/lib/python3.7/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/Users/johannesbjork/python/miniconda3/lib/python3.7/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/Users/johannesbjork/python/miniconda3/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/johannesbjork/python/miniconda3/lib/python3.7/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/Users/johannesbjork/python/miniconda3/lib/python3.7/site-packages/gemelli/scripts/_standalone_ctf.py", line 131, in standalone_ctf
    feature_metadata)
  File "/Users/johannesbjork/python/miniconda3/lib/python3.7/site-packages/gemelli/ctf.py", line 97, in ctf_helper
    raise ValueError(("No more features left.  Check to make sure that "
ValueError: No more features left.  Check to make sure that the sample names between `sample-metadata` and `table` are consistent

Hi @johannesbjork,
Thank you for reporting this! The standalone CLI is the only tutorial I did not make and it seems that was an oversight on my part.
The error is occurring because the sample ids are labeled in the float format. So pandas are loading them as floats while biom is loading them as strings. This is causing the no sample ID matches between the table and metadata error seen above from gemelli.
I just fixed this in the tables here (fixed-IBD-example.zip) by adding a string ('s') to the sample names.
I will put in a PR for this fix and a standalone tutorial (issue #35).
The following command runs fine:
mkdir standalone-results

gemelli \
    --in-biom fixed-IBD-example/table.biom\
    --sample-metadata-file fixed-IBD-example/metadata.tsv \
    --individual-id-column 'host_subject_id' \
    --state-column-1 'timepoint' \
    --output-dir standalone-results

But to save runtime (since this is an example) you could also remove singletons with the --min-feature-count flag:
gemelli \
    --in-biom fixed-IBD-example/table.biom\
    --sample-metadata-file fixed-IBD-example/metadata.tsv \
    --individual-id-column 'host_subject_id' \
    --state-column-1 'timepoint' \
    --min-feature-count 1\
    --output-dir standalone-results

This also brings up a good point that a tutorial with R integration would be nice. I have added that to issue #35.
Thank you again for letting me know! and please let me know if this does not solve the problem for you.


⚠ Bofrost.es has degraded performance

In 69f1c95, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1539 ms

Resolved: Bofrost.es performance has improved in 61821d8 after 6 minutes.


[Doc]: update color prop description in all layers

For #

Background
[Doc]: update color prop description in all layers
Ref: #3358

Change List

Coverage remained the same at 83.091% when pulling cbbd272b63faded0da9b33281142de95491dc8d6 on ColorPropDoc into b8f0a10c8cbcba6af6be900dfb5cfaffecceb9f0 on master.


Ability to access device contacts

I want to be able to prompt user to provide access to device contacts, and get contact list upon user granting access.

@vusters @amin-nas
Sample YAML
I am using https://pub.dev/packages/fluttercontactpicker/ flutter package, which shows a native contact picker.
Button:
  label: Pick Phone Contact
  onTap:
    pickPhoneContact:
      id: phoneContactId
      options:
        linkToken: ${getLinkTokenFromServer.body.linkToken}
      onSuccess: |
        //@code
        console.log("Contact fetched successfully");
        console.log(event.data);
        console.log("Phone Number" + event.data['phoneNumber']);

      onExit: |
        //@code
        console.log("Something went wrong!");

@vinothvino42 - I want to be able to get the full contact list so that I can display them with Ensemble widget of my choice. Here's an example:

Okay @amin-nas Then I'll use this package instead - https://pub.dev/packages/flutter_contacts
Here, you need to use your own view to populate all the contacts

@vinothvino42 we use onAccept and onReject for notification access request. Let's change the above to be consistent.
cc @vusters

@amin-nas I think we've used onSuccess in other widgets too.


allTenants Call to a member function newQueryWithoutTenants() on null

When calling ::allTenants() on a model that has not been booted I get the following error.
PHP error:  Call to a member function newQueryWithoutTenants() on null in vendor/hipsterjazzbo/landlord/src/BelongsToTenants.php

I found that this is due to that the Model has not yet booted (it was never instantiated). This means the bootBelongsToTenants() will never get called, so in turn $landlord will never be set to a TenantManager.
I'm using the newest version of LandLord with Laravel 5.5.

I see a PR was created to fix this. Pull Request #75

Workaround for people stumbling upon this: instantiate the model you want to call allTenants() on. Example:
use App\Books;

public function getAllBooks()
{
    // Workaround to call boot method, needed for Landlord to work correctly.
    new Books;

    return Books::allTenants()->get();
}


Namespaces independent from prefixes leads to inadvertent duplicate attributes

You can create a document programmatically that contains a prefix definition x to namespace http://example.com/y. Then in a sub-element, this prefix is redeclared to be http://example.com/x. Now if we have an attribute that uses namespace /y as well another one that as /x on the sub element, this serializes to use the x prefix both. This could lead to duplicate attributes in the serialized XML.
But in fact, x was overridden and serialization should not use the same prefix for /y.
Instead, the serializer should not use the redeclared namespace prefix for the namespace that is now shadowed.
The prefix cleanup procedure could fix this by creating a synthetic prefix in such cases.

I've reworked the way this is generated now in 0.9.0 and this should be fixed.


HBASE-25469 Add detailed RIT info in JSON format for consumption as metrics

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
11m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m 38s
branch-1 passed

+1 :green_heart:
javadoc
0m 56s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m  3s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

_ Other Tests _

-1 :x:
unit
157m 43s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 40s
The patch does not generate ASF License warnings.

186m 40s

Reason
Tests

Failed junit tests
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3557/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3557

Optional Tests
dupname asflicense javac javadoc unit

uname
Linux da29ed4dc49e 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3557/out/precommit/personality/provided.sh

git revision
branch-1 / 8f82cbf

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3557/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3557/1/testReport/

Max. process+thread count
4767 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3557/1/console

versions
git=1.9.1 maven=3.0.5

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Adapt aesc_close_mutual_tx to new spec

Pivotal story
Since the description of channel_close_mutual has changed not to include initiatior and participant, this PR is addressing that.
Most notable change is getting peers in the channel: now they're fetched from the DB (whenever possible - from state trees)

Since the spes is updated, I'm adapting this PR to it

My old approval seems to stick past later commits. Very well, I still have no objections.


Numbro's syntax not working on numericFormat with typescript

Description
Can't seem to be able to use Numbro's syntax for numeric type cells while using typescript. As mentioned here and here an update was made to use the pattern: { mantissa: 0 } syntax for the numericFormat option, but typescript won't compile it because of a type mismatch (it expects a string for the pattern option and not an object)
const columns = [
    { data: 'cxp', name: 'CxP', type: 'numeric', numericFormat: { pattern: { mantissa: 0 }}, readOnly: true },
];

const data = [
    { cxp: 12.5 },
    { cxp: 18.502 },
    { cxp: 234 },
    ...
];

return (
    <HotTable
      ref={ref}
      licenseKey={HANDSONTABLE_KEY}
      language="es-MX"
      columns={columns}
      data={data}
    />
);

Environment

React wrapper version: 4.0.0
Handsontable version: 8.2.0
Browser Name and version: any
Operating System: any

The problem is with handsontable.d.ts file where numericFormat is outdated: https://github.com/handsontable/handsontable/blob/34793d5e9ee10176941ebe2589996daa80b5effd/handsontable.d.ts#L1935-L1938
Thanks for reporting.

Thanks! Should I report an issue on the main repo?


White space is removed after page transition with Pjax

Hi there
I am using your awesome library for text animations but got a weird problem is quite annoying making use of this library almost useless in my scenario. The problem is that after page transition through Pjax or Ajax, text containing data-splitting attribute loses their whites pace and it animates quite jumpy. It kinds of travel through the whole website like sometime will happen on page 1 and sometime on 2nd page and so on. How this problem can be tackled.
I am quite sure this problem is related to splitting bcs in 2nd video I am not using splitting on home page and white space is not removed.
Below is the short videos  for your reference.
1 - https://user-images.githubusercontent.com/65112198/112987578-4f756d00-917c-11eb-8bcf-eff2f7d33228.mp4
2 - https://user-images.githubusercontent.com/65112198/112988442-48029380-917d-11eb-8cf3-ae8181e1c935.mp4
Do I need to destroy and reinitiate it on every page if yes, how it can be done. I do not see any method in docs.
Although I am calling "splitting()" on each page.
Any kind of help and guidance will really appreciate.
Regards,
Shehzad Asif

Hey
Can I expect some words!


Try different params with QUBO

I should investigate embedding as well

See if it's possible to use advantage (the new solver with 5000+ qubits)

using leap's hybrid solver is also interesting

I think #44 already did enough of this


refactor: refactor integration tests to use mempool_node modules

Stack:

#339 ⬅
#311
#310
#309

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.21%. Comparing base (36c6040) to head (d77bedb).

Additional details and impacted files
@@                          Coverage Diff                          @@
##           pr/lev-starkware/lev_dev/8df0f3c6     #339      +/-   ##
=====================================================================
+ Coverage                              78.36%   84.21%   +5.85%
=====================================================================
  Files                                     33       33
  Lines                                   1622     1628       +6
  Branches                                1622     1628       +6
=====================================================================
+ Hits                                    1271     1371     +100
+ Misses                                   287      185     -102
- Partials                                  64       72       +8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Make Animation an EventTarget again

According to the spec, Animation inherits from EventTarget. While the polyfilled Animation exposes add/removeEventListener, it is missing dispatchEvent because it doesn't actually use an EventTarget as its prototype.

See #17.


Grouped Accordion

Hi,
How can I add plus and minus symbol / sign to accordion so when it open, shows minus sign and close plus sign.
And also, I would like to know if i can make fix position for close X sign in Launch overlay. I tried to set the position but the content's height is not fixed so every time it changes the position.
Thanks,
h

Hi there,
Sorry for the slow reply. I'll knock up an example accordion for you as soon as I can.
I'm not sure I follow what you are trying to achieve with the  second question. Do you mean the modal plugin? Could you post an image of what you are looking for?

Could be talking about the X to close the Modal window being at the top right of the screen rather than the top right of the content (like Fancybox etc.). Similar issue with the title too. Position relative to window rather than content.

Ah maybe...
The layout was done the way it was for good reason, a constantly changing location is bad for usability and the behaviour I chose matches others like Magnificent Popup and Google's internal lightbox designs.
I doubt I'll ever be changing it.

CSS would be the best approach here I think. Use the following selectors.
/*
 * Expanded
 */
.accordion-head [aria-expanded="true"] {
}

/*
 * Collapsed
 */
.accordion-head [aria-expanded="false"] {
}


Add [UIView] to UIStackView

Create an extension to add an array of views to UIStackView.
Suggested names:

addArrangedSubviews(_views: [UIView])
appendArrangedSubviews(_views: [UIView])

Calling dips ☝😜
Sent with GitHawk


Added support for javascript and typescript files

Added default support for .js, .jsx, .ts, and .tsx files.

This will have conflicts with the upcoming update, so I will copy/paste your added list.
thank you so much Ali

I'm glad to help.


error: conflicting declaration 'using EncodeRange = struct lgfx::v1::EncodeRange'  using EncodeRange = lgfx::EncodeRange;

Describe the bug
Error on compile in Arduino IDE that wasn't present before, guessing that Arduino auto library update triggered issue.
Traced as far as:
#include <M5Core2.h> // No error with M5Unified.h
Error msg:
In file included from /Users/.../Documents/Arduino/core2-base-iot/core2-base-iot.ino:4:
/Users/.../Documents/Arduino/libraries/M5GFX/src/M5GFX.h:263:38: error: conflicting declaration 'using EncodeRange = struct lgfx::v1::EncodeRange'
using EncodeRange = lgfx::EncodeRange;
^
In file included from /Users/.../Documents/Arduino/libraries/M5Core2/src/utility/In_eSPI.h:480,
from /Users/.../Documents/Arduino/libraries/M5Core2/src/M5Display.h:10,
from /Users/.../Documents/Arduino/libraries/M5Core2/src/M5Core2.h:12,
from /Users/.../Documents/Arduino/core2-base-iot/core2-base-iot.ino:3:
/Users/.../Documents/Arduino/libraries/M5Core2/src/Fonts/GFXFF/gfxfont.h:26:3: note: previous declaration as 'typedef struct EncodeRange EncodeRange'
} EncodeRange;
^~~~~~~~~~~
To reproduce
Error on compile that wasn't present before, guessing that Arduino auto library update triggered issue.
#include <M5Core2.h> // No error with M5Unified.h
In file included from /Users/.../Documents/Arduino/core2-base-iot/core2-base-iot.ino:4:
/Users/gavinbeattie/Documents/Arduino/libraries/M5GFX/src/M5GFX.h:263:38: error: conflicting declaration 'using EncodeRange = struct lgfx::v1::EncodeRange'
using EncodeRange = lgfx::EncodeRange;
^
In file included from /Users/gavinbeattie/Documents/Arduino/libraries/M5Core2/src/utility/In_eSPI.h:480,
from /Users/gavinbeattie/Documents/Arduino/libraries/M5Core2/src/M5Display.h:10,
from /Users/gavinbeattie/Documents/Arduino/libraries/M5Core2/src/M5Core2.h:12,
from /Users/gavinbeattie/Documents/Arduino/core2-base-iot/core2-base-iot.ino:3:
/Users/gavinbeattie/Documents/Arduino/libraries/M5Core2/src/Fonts/GFXFF/gfxfont.h:26:3: note: previous declaration as 'typedef struct EncodeRange EncodeRange'
} EncodeRange;
^~~~~~~~~~~
Expected behavior
No errors
Screenshots
No response
Environment

OS: macOS
IDE &IDE Version: Arduino IDE
Repository Version:

Additional context
No response
Issue checklist

[X] I searched for previous reports in the issue tracker
[X] My report contains all necessary details

Exactly the same error here:
Environment #1
OS: macOS
IDE &IDE Version: PlaformIO Core 6.1.11
Environment #2
OS: macOS
IDE &IDE Version: Arduino IDE Latest
Environment #3
OS: Windows 11
IDE &IDE Version: PlaformIO Core 6.1.11

Environment that is possible to compile:
libraries' versions: M5Core2-v0.1.3 and M5GFX-v0.1.8
OS:Windows 10
IDE&IDE Version:Arduino-v2.0.0
Man those versions are are all too old!

So newer versions seem to be buggier?

@GavinBeattie I installed M5Core2 0.1.9 and no errors were encountered during compilation. Please provide test code.


Food Website

Project title
(Write project title over here)
Food Website
Project Description
(Describe the project over here)
Hello Sir/ma'am,
I want to add my new Food website project in this repo.
This project includes contains my project on my Food Website😋. I have made it using HTML,CSS & JS. It contains a menu card of different cuisines such as Biriyani , Chinese, Paneer Mania, Veg as well as South Indian.🍕 .
Doc Domain

[x] Solidity , Html, Css , JavaScript , Web3.js / Ether.js
[] Solidity , ReactJs /NextJs , Web3.js /Ether.js
[] Solidity , Python3 , Web3.py
[] Other , feel free to mention below

Are you contributing under any open-source program ?
I am participating in OSEN(Collab-code-carnival)

@shubhisingh184 @Vikash-8090-Yadav Please assign me this issue

Start working on this


update credits in portfolio

missing acknowledging part of one code

Pull Request Test Coverage Report for Build 571

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.741%

Totals

Change from base Build 570:
0.0%

Covered Lines:
2395

Relevant Lines:
2930

💛  - Coveralls


Native error is thrown when blob is read with FileReader.readAsDataURL

Description
I'm using FileReader.readAsDataURL to consume a Blob returned by RN's networking layer as an ArrayBuffer to implement FileReader.readAsArrayBuffer (https://github.com/facebook/react-native/issues/21209) and it has been working just fine, at least with the data I've been processing.
I'm working on an implementation of the Fetch API for RN where the underlying response is always a ReadableStream (so Response.body can be implemented at all times). All chunks of the stream are Uint8Arrays and the only way at the moment to convert a Blob to an ArrayBuffer is through FileReader.readAsDataURL.
However, when I use console.error or console.warn on iOS (didn't test on Android yet), the error shown in the image below is occurring.

React Native version:
System:
    OS: macOS 10.15.6
    CPU: (4) x64 Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz
    Memory: 427.45 MB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 14.7.0 - /usr/local/bin/node
    Yarn: 1.15.2 - /usr/local/bin/yarn
    npm: 6.14.7 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.9.1 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.1, DriverKit 19.0, macOS 10.15, tvOS 14.0, watchOS 7.0
    Android SDK:
      API Levels: 25, 28, 29
      Build Tools: 28.0.3, 29.0.2
      System Images: android-28 | Google Play Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 3.5 AI-191.8<IP_ADDRESS>10548
    Xcode: 12.1/12A7403 - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_201 - /usr/bin/javac
    Python: 3.8.5 - /usr/local/opt/python@3/libexec/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: ^16.9.0 => 16.9.0
    react-native: ^0.63.3 => 0.63.3
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.
Given any app, patch Body.text() in node_modules/whatwg-fetch/dist/fetch.umd.js as follows:
this.text = async function() {
   var rejected = consumed(this);
   if (rejected) {
      return rejected
   }

   if (this._bodyBlob) {
	  function readBlobAsDataURL(blob) {
         var reader = new FileReader();
         var promise = fileReaderReady(reader);
         reader.readAsDataURL(blob);
         return promise
      }

      const { toByteArray } = require('base64-js');
      const { TextDecoder } = require('text-encoding'); // needs to be installed
      const dataURL = await readBlobAsDataURL(this._bodyBlob);
      const base64 = dataURL.split(',')[1];

      return new TextDecoder().decode(toByteArray(base64));
   } else if (this._bodyArrayBuffer) {
      return Promise.resolve(readArrayBufferAsText(this._bodyArrayBuffer))
   } else if (this._bodyFormData) {
      throw new Error('could not read FormData body as text')
   } else {
      return Promise.resolve(this._bodyText)
   }
};

Then, call console.error or console.warn.
Expected Results
I expect to be able to consume a Blob as a data URL without any error being thrown.

Using base64 instead of blob as response type for RCTNetworking gets rids of the issue.

Ran into the same problem today.
I'm relatively sure the problem is here:
https://github.com/facebook/react-native/blob/master/Libraries/Blob/RCTFileReaderModule.mm#L71
There is a null check for "type" on the subsequent line (defaulting it to application/octet-stream), but it actually should be prior to the RCTConvert, since that may fail if it is null and spit out an error.
So in other words, I think this:
    NSString *type = [RCTConvert NSString:blob[@"type"]];
    NSString *text = [NSString stringWithFormat:@"data:%@;base64,%@",
                      type != nil && [type length] > 0 ? type : @"application/octet-stream",
                      [data base64EncodedStringWithOptions:0]];

Should be something like:
    NSString *blobType = blob[@"type"] != nil && [blob[@"type"] length] > 0 ? blob[@"type"] : @"application/octet-stream";
    NSString *type = [RCTConvert NSString:blob[@"type"]];
    NSString *text = [NSString stringWithFormat:@"data:%@;base64,%@",
                      type,
                      [data base64EncodedStringWithOptions:0]];

I hacked around it by just setting blob.data.type to something manually before calling readAsDataURL.
I'd try to submit a PR, but this is like my fourth day touching either React Native or ObjC, so somebody else should probably take it from here.

أُرسلت من الـ iPad

في 22/11/2020 الساعة 8:00 ص، كتب/كتبت Dan Menssen notifications@github.com:

Ran into the same problem today.
I'm relatively sure the problem is here:
https://github.com/facebook/react-native/blob/master/Libraries/Blob/RCTFileReaderModule.mm#L71
There is a null check for "type" on the subsequent line (defaulting it to application/octet-stream), but it actually should be prior to the RCTConvert, since that may fail if it is null and spit out an error.
So in other words, I think this:
NSString *type = [RCTConvert NSString:blob[@"type"]];
NSString *text = [NSString stringWithFormat:@"data:%@;base64,%@",
                  type != nil && [type length] > 0 ? type : @"application/octet-stream",
                  [data base64EncodedStringWithOptions:0]];

Should be something like:
NSString *blobType = blob[@"type"] != nil && [blob[@"type"] length] > 0 ? blob[@"type"] : @"application/octet-stream";
NSString *type = [RCTConvert NSString:blob[@"type"]];
NSString *text = [NSString stringWithFormat:@"data:%@;base64,%@",
                  type,
                  [data base64EncodedStringWithOptions:0]];

I hacked around it by just setting blob.data.type to something manually before calling readAsDataURL.
I'd try to submit a PR, but this is like my fourth day touching either React Native or ObjC, so somebody else should probably take it from here.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I hacked around it by just setting blob.data.type to something manually before calling readAsDataURL.

@menssen did that work?

in case @menssen's workaround wasn't clear, you can silence the error by manually setting a data type:
fetch(src)
  .then(res => res.blob())
  .then(blob => {
    // https://github.com/facebook/react-native/issues/30378
    blob.data.type = 'image/jpeg';

    var reader = new FileReader();

    reader.readAsDataURL(blob);

    reader.onloadend = () => {
      var base64data = reader.result;

      console.log(base64data);
    };
  })
  .catch(e => console.error(e));

The problem being that the type information at the start of your base64 string will be whatever you set it to, not whatever the blob actually contained. Could be fine if you always know what kind of data you will be dealing with.
This kind of thing really isn't my wheelhouse either, but you might be able to determine/repair the type information using something like:
https://github.com/sindresorhus/file-type

Any chance we can get some feedback with this ?

it's the same issue with me , any solutions

I found a solution to put blob response as a new Blob with desired type:
const blob = new Blob([response.data], {
  type: "base64",
});

Any solutions to this? I am experiencing a similar problem on iOS utilizing react-native-webview. It throws the JSON value '' error only for a particular website that I navigate to in the webview. Other websites don't throw the error and it doesn't throw at all in Android.

I ran into this when the HTTP response was missing Content-Type header. Just update the server to include the content-type header to fix.


"Directly committed to branch" popover can't be discarded for good

The popover warning about directly committing to some branch includes a link/button to "Don't show again".
Hovering over that link/button doesn't display a pointer cursor, and the expected functionality also doesn't happen:
Clicking on it discards the message, but also unfocuses the commit message input. Once the input is selected again, the popover appears.
The popover is actually pretty annoying, because I usually click into the input and want to think about what this commit is about. The popover then hides some of the staged files which would be helpful to see for coming up with a good commit message.
Version: 1.65.2
Commit: c722ca6c7eed3d7987c0d5c3df5c45f6b15e77d1
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/99.0.4844.74 Safari/537.36 Edg/99.0.1150.55
Embedder: github.dev

This is https://github.com/microsoft/vscode-remote-repositories-github/issues/120. 'Don't Show Again' is a command link but doesn't do anything.
As a temporary workaround you can disable this popover in settings:

Closing as duplicate of https://github.com/microsoft/vscode-remote-repositories-github/issues/120


update doctor plugin

fix where no problem was found, no msg given
add triage for services
minor ui changes

Thanks!

Looks good. Thanks!


RFC: split this repository in five different (maybe more) repositories

The problem
The main problem is testing time #2498. But that's not the only one. There are so many things in this repo, with more added every month, that it comes a time when it's become unmanageable, with author tests only run from time to time due to time restrictions, for instance, and the requisites of some tools conflicting with the requisites from others. The different parts are also too tightly coupled (described somewhere as a "rats nest") that it's difficult to think about testing (see #2529 #2539) lots of parts (including the main site-generation app) that are not being tested right now.
The five parts here are:

The documents themselves. They are housed in the docs/ directory. Some auxiliary files are in writing-docs and of course t/ and xt/ directories.
p6doc. This is an user-facing script which should be used to consult/search documentation, but which has right now lots of issues: #2014 #2532 #2103 #2534. This uses a set of files, but it's not clear which ones; Build.pm6 in the root dir is one of them.
The website docs.perl6.org It's difficult to find out where p6doc ends and this starts. Mainly htmlify.p6 (which has lots of issues: #1997 #1823 #2499 )
Auxiliary modules used by these above, including Pod::Documentable (see #1937 ) and many others under the lib/ directory.
Other different files that have some relationship with this repo, including the Dockerfile, utility files that might or might not be part of the first block

Suggestions
I already proposed #2295 to general indifference, but I think we should go further tnan that, leaving the docs in this directory, and filter commits to create all new repositories that keep the history, which could be called App::doc, doc-site, several repos, one for each lib Module which is functionally independent and doc-kerfile (pun intended).

A related discussion just came up on #2662 - Specifically addressing the thought of splitting out some items from the documentation itself - if the goal is to have targeted distributions of docs via p6doc, or a copy of the website, that is something that can be done by generating user-specific artifacts at regular interviews (say, quarterly) for the users. IMO, this isn't something we should solve at the git repo level. That said, having it installable (say via a CPAN module via zef) would be great, but we don't need separate repos to accomplish that.
Additionally, one of the comments on #2662 was regarding the size of downloads for the user; note that removing a file from HEAD doesn't mean it's not in the repo anymore; it's still there and being transferred, so any solution that simply removes the file from one repo and puts a copy in the other isn't helping on that front, if they're using git. (And if they're not using git, that's another pro for same repo, different artifacts, IMO)
Regarding pulling out modules - it very much depends on purpose of those modules; Pod::Cache, for example, is very basic and only for build/testing, and exists as a module only to avoid code duplication. (The issue that it's untested is a separate one and can be addressed in place.) Pulling it out into a separate repo complicates development for little benefit.

The thing is that we should create different repositories for different
targets. Right now this repo includes everything and the kitchen sink:
tools for doccers, the documentation itself, tools for generating an HTML
file from the documentation, the p6doc... That makes difficult to refactor,
makes testing take a loooong time, makes difficult to attract new
contributors... Splitting would have all kinds of benefits for developers,
with little or no negative impact on user experience.

Strongly disagree that breaking the repository into smaller repositories is the correct approach.

@lizmat this is the "big split" issue.

Strongly disagree that breaking the repository into smaller repositories is the correct approach.

Several of these steps were already done, please feel free to ignore my old opinion here for the remaining items.

@JJ , can you summarize what's left to do before we can close out this ticket?

Will try to next week.
El sáb, 16 abr 2022 a las 18:40, Will Coleda @.***>)
escribió:

@JJ https://github.com/JJ , can you summarize what's left to do before
we can close out this ticket?
—
Reply to this email directly, view it on GitHub
https://github.com/Raku/doc/issues/2542#issuecomment-1100704091, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAD5FHMKIJLVKMNNHVRILVFLUO5ANCNFSM4GONS3WQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
JJ


WIP: Add feature set for kubelet podresources

We want to enable the kubelet podresources feature gate,
needed to enable the node topology resources reporting.
Since this feature gate doesn't seem to fit very well in
any existing feature set, we add a new one.
Signed-off-by: Francesco Romani<EMAIL_ADDRESS>

/hold
posted to foster the discussion

note: this feature gate was introduced in kubernetes 1.21: https://github.com/kubernetes/kubernetes/blob/release-1.21/pkg/features/kube_features.go#L742

we will wait for kube 1.23 and we will re-evaluate


Renovate all the things

As a Software Factory Package maintainer
I want capabilities to be tied to their upstream sources
So that new versions cascade..
As a Software Factory Package maintainer
I want the Software Factory Package to be tied to the capabilities
So that updates to capabilities are automatically bundled into new SWF packages

Specifically the uds-capability-gitlab repository
Follow the example laid out in the dubbd repo

Or you can look at Jordan's example here https://github.com/corang/uds-package-dubbd-kind


183 tasks

closes #183

I noticed weird behavior locally when using runserver. Initially the task card is shown as 100% still open although there are closed tasks. And once I open the admin interface the page updates and the correct amount of open tasks is shown. Can someone reproduce that?


cannot use 'top' as a variable name

With new type inference, get the error
src/lab/view/EnergyBarGraph.js:378: WARNING - Cannot change the value of a constant.
    top = this.visibleRect_.getTop();
    ^

in this method:
/**
* @param {number} height
* @private
*/
EnergyBarGraph.prototype.resizeRect = function(height) {
  goog.asserts.assertObject(this.visibleRect_);
  var top = (this.rect_.isEmpty() || !this.beenDragged_) ?
      this.visibleRect_.getTop() : this.rect_.getTop();
  var bottom = top - height;
  if (top > this.visibleRect_.getTop() || height > this.visibleRect_.getHeight()) {
    top = this.visibleRect_.getTop();
    bottom = top - height;
  } else if (bottom < this.visibleRect_.getBottom()) {
    bottom = this.visibleRect_.getBottom();
    top = bottom + height;
  }
  // code omitted...
};

I understand that top is a property of window, but it should be possible to create a local variable with the same name.

Thanks for the report.
Small repro:
/** @const */
var x = 1;
function g() {
  var x = 2;
  x = x + 3;
}

confirm fixed in Version: v20150505-58-g39bb337


Tag Helpers: Support @removetaghelper in ViewStart.

With the addition of Tag Helpers we need to ensure that @removetaghelper directives are supported in view start and therefore propagated to all underlying pages.  This way we can specifically remove Tag Helpers that were added via @addtaghelper.
Associated @addtaghelper directive issue: #1166

#1657


allow /p option without value

If /p is used without value the password is asked by
freerdp_passphrase_read (in command line)

@maxime1986 May I ask what is wrong with just using /from-stdin instead of /p?

I don't have admin access to the RDP server I am connecting to.
From my tests it appears (but I am not sure) that this server doesn't support /sec:nla nor /sec:tls, only /sec:rdp.
To connect to this server I tried xfreerdp /d:mydomain /u:myusername /from-stdin /app:'||calc' /v:myserver.net but xfreerdp never asked for the password.
client_cli_authenticate_raw nor freerdp_passphrase_read was called.
The comment on client_cli_authenticate_raw say:

Callback set in the rdp_freerdp structure, and used to get the user's password, if required to establish the connection.

The if required to establish the connection makes me think this only work when NLA is supported.
So I make this patch to clarify things and be able force xfreerdp to ask for the password from stdin.
My interpretation may be wrong. If that so, could you explain to me how to force xfreerdp to ask for the password with /from-stdin ?

@maxime1986 I see, looks like you're right. Still, would be better to fix /from-stdin than to kind of misuse /p.

@akallabeth with /sec:rdp is it possible to configure a server to allow client to log in without password (something like guest account) ?
If it's the case, I think /from-stdin can't be fixed because it will not know if it has to ask for a password or not.
Maybe /from-stdin with /sec:rdp should alway ask for password, and disable it if the user leave it blank ?
What do you think ?

If you think it's better to stay with /from-stdin, is transport_connect_tls and transport_connect_rdp good places to add client_cli_authenticate (or similar) ?

@freerdp-bot test.

@maxime1986 Sorry, don't remember the exact call graph, would have to dig into that myself.

@tchernomax I've refactored your idea as an extension to /from-stdin in #4229.


Enfore upper limit for minTtl when using DefaultCacheEntry.

Motivation:
a598c3b69b55f930b91a8265f42d1a3cceb75ddd added a upper limit for ttl but missed to also do the same for minTtl.
Modifications:

Add upper limit for minTtl
Add testcase.

Result:
No more IllegalArgumentException possible.

Just merging this as the previous fix was incomplete.


Memory leaks while reading crl

Can anyone tell my what's wrong with this crl and why it can generate memory leaks ?
http://repo.e-dowod.gov.pl/crl/PLID_Authorization_CA_20201202.crl

The CRL is quite large (though there are some really large ones out there), so significant memory usage of the loaded object should be expected. From a quick test there appear to be around 18,000 entries, corresponding to your counts of DerInteger, DerSequence, DerUTCTime. Could you explain why you are describing this as a memory leak as opposed to just number of heap objects?
By the way, there is the option to load CRLs lazily using new X509CrlParser(true) for the parsing. Lazy here means that the ASN.1 is not fully parsed until you drill down, so this may lower overall memory usage unless you are going to process the whole CRL anyway. You would probably want to make sure the CRL is validated by non-lazy parsing at least once though before "installing" it.

thats was my mistake something else was source of memory leaks i already fix that. Thank you for your feedback and advice.


Remove commbadge waffle and old emails (bug 1099355)

Mainly rewriting tests that depended on the old emails.

This looks fine to me. I may want to give it another pass just b/c it's a lot of changing and I glossed over on parts of it.

I think we can remove reviewers/includes/review_history.html . Still planning on switching over to do direct DB queries rather than API calls later, but been busy with frontend UI changes. Glossed over, looks good.

removed unused imports; removed review_history.html

r+. Needs a rebase.


ci: remove old hasura database url secret from preprod / prod

remove old hasura database url secret that are provided by pg_user

:tada: This PR is included in version 1.114.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: