Added input file sorting to many diagnostic to make output exactly reproducible

Description
The exact output of many diagnostics depends on the order in which input files are read, which can vary between runs (e.g., 1D netcdf files with dataset coordinate whose order depends on the order of the input files). This makes the output non-reproducible and lets tools to check differences between the output fail (see https://github.com/ESMValGroup/ESMValTool/issues/2704).
This PR adds sorting to many of these diagnostics to make them reproducible.

Related to https://github.com/ESMValGroup/ESMValTool/issues/2704

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 This pull request has a descriptive title
[x] 🛠 Code is written according to the code quality guidelines
[x] 🛠 Documentation is available
[x] 🛠 Tests run successfully
[x] 🛠 The list of authors is up to date
[x] 🛠 Any changed dependencies have been added or removed correctly
[x] 🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

[x] 🧪 Recipe runs successfully
[x] 🧪 Recipe is well documented
[x] 🧪 Figure(s) and data look as expected from literature
[x] 🛠 Provenance information has been added

To help with the number of pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

@sloosvel I will run all affected recipes overnight and post the output here so you can add these results to the table of recipes. That way we can also use these new runs as references and hopefully get less differences from the comparison tool in the future (together with https://github.com/ESMValGroup/ESMValTool/pull/2709).

All recipes ran successful and the output ran fine.
@sloosvel could you please copy the output from here (/scratch/b/b309141/recipe_testing) to the results page mentioned here and have a brief look at this PR?
Thanks!!!

Cheers, thanks Saskia!!


Add request init as second arg

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.
Description
Add second argument for RequestInit.
Related # (issue)
https://github.com/ardatan/feTS/issues/708

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
yarn test packages/fets/tests/client-abort.spec.ts

Test Environment:

OS: macos
package-name:
NodeJS: v18.18.0

Checklist:

[ ] I have followed the
CONTRIBUTING doc and the
style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests and linter rules pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Ready for another review!
Note: yarn ts:check passing locally but CI says "Cannot find module './fixtures/example-client-query-serialization-oas'". Not sure why.


Update sbt, scripted-plugin to 1.4.7

Updates

org.scala-sbt:sbt
org.scala-sbt:scripted-plugin

from 1.4.6 to 1.4.7.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt" } ]

labels: library-update, semver-patch

Superseded by #4.


Add an option to GetWalks to allow partial walks to be returned

Linked to gh-1754. This is a simple quick solution to allow all walks to be returned. gh-1754 is more complex and could be implemented in the future.

Merged into develop


Integrate simple dependency injection container into common bootstrap

Provides a path to replace a service's global variables with instances managed by the DIC which are injected into controller methods.
Fixes: https://github.com/edgexfoundry/edgex-go/issues/1837

Hold -- dependency on #1858

Codecov Report

Merging #1861 into master will increase coverage by 0.53%.
The diff coverage is 44%.

@@            Coverage Diff             @@
##           master    #1861      +/-   ##
==========================================
+ Coverage   40.81%   41.35%   +0.53%
==========================================
  Files         182      180       -2
  Lines       12328    12239      -89
==========================================
+ Hits         5032     5061      +29
+ Misses       7020     6902     -118
  Partials      276      276

Impacted Files
Coverage Δ

internal/pkg/telemetry/telemetry.go
52.63% <0%> (-1.43%)
:arrow_down:

cmd/core-data/main.go
0% <0%> (ø)
:arrow_up:

internal/system/agent/setconfig/executor.go
0% <0%> (ø)
:arrow_up:

internal/core/metadata/init.go
0% <0%> (ø)
:arrow_up:

internal/support/logging/init.go
0% <0%> (ø)
:arrow_up:

cmd/support-logging/main.go
0% <0%> (ø)
:arrow_up:

cmd/export-distro/main.go
0% <0%> (ø)
:arrow_up:

internal/core/data/init.go
0% <0%> (ø)
:arrow_up:

cmd/core-metadata/main.go
0% <0%> (ø)
:arrow_up:

cmd/support-scheduler/main.go
0% <0%> (ø)
:arrow_up:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40e7ffc...645ca4a. Read the comment docs.

Rebased

Rebased

Rebased

Discussed in today's Core WG call.  Community will continue the higher-level discussion of the pros and cons of DI and implementation in the project at next week's scheduled face-to-face architect meetings in Chicago.

Rebased

Rebased with additional changes resulting from https://github.com/edgexfoundry/edgex-go/pull/1834 merge.

Rebased.

Codecov Report

Merging #1861 into master will decrease coverage by 0.38%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1861      +/-   ##
==========================================
- Coverage   42.51%   42.13%   -0.39%
==========================================
  Files         182      181       -1
  Lines       11682    11646      -36
==========================================
- Hits         4967     4907      -60
- Misses       6445     6462      +17
- Partials      270      277       +7

Impacted Files
Coverage Δ

internal/pkg/telemetry/telemetry.go
52.63% <0%> (-1.43%)
:arrow_down:

cmd/core-data/main.go
0% <0%> (ø)
:arrow_up:

cmd/export-distro/main.go
0% <0%> (ø)
:arrow_up:

cmd/core-command/main.go
0% <0%> (ø)
:arrow_up:

internal/support/logging/init.go
0% <0%> (ø)
:arrow_up:

cmd/support-logging/main.go
0% <0%> (ø)
:arrow_up:

cmd/support-notifications/main.go
0% <0%> (ø)
:arrow_up:

internal/core/data/init.go
0% <0%> (ø)
:arrow_up:

internal/support/notifications/init.go
0% <0%> (ø)
:arrow_up:

cmd/core-metadata/main.go
0% <0%> (ø)
:arrow_up:

... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 529ef62...aaa62b1. Read the comment docs.

Codecov Report

Merging #1861 into master will decrease coverage by 0.91%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1861      +/-   ##
==========================================
- Coverage   43.04%   42.13%   -0.92%
==========================================
  Files         182      181       -1
  Lines       11597    11646      +49
==========================================
- Hits         4992     4907      -85
- Misses       6335     6462     +127
- Partials      270      277       +7

Impacted Files
Coverage Δ

internal/pkg/telemetry/telemetry.go
52.63% <0%> (-1.43%)
:arrow_down:

cmd/core-data/main.go
0% <0%> (ø)
:arrow_up:

cmd/export-distro/main.go
0% <0%> (ø)
:arrow_up:

cmd/core-command/main.go
0% <0%> (ø)
:arrow_up:

internal/support/logging/init.go
0% <0%> (ø)
:arrow_up:

cmd/support-logging/main.go
0% <0%> (ø)
:arrow_up:

cmd/support-notifications/main.go
0% <0%> (ø)
:arrow_up:

internal/core/data/init.go
0% <0%> (ø)
:arrow_up:

internal/support/notifications/init.go
0% <0%> (ø)
:arrow_up:

cmd/core-metadata/main.go
0% <0%> (ø)
:arrow_up:

... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42e05e...9da69ed. Read the comment docs.

Rebased.


Migrate to Bevy 0.13

Migrating to Bevy 0.13
Only minimal changes were necessary :tada:

@azazdeaz thank you for those changes! :pray: No worries about breaking the wireframe feature before. This is something that I should have caught.
To avoid such issues in the future I've added a second example, and set up a github action.


You should just use SVG Emoji2

You should use the SVG Emoji2 Extension code. You could change the emoji's if you want though. Working on getting it published :)

Nvm

Nvm?

What the heck...


ScatterPlot min/max (WIP) - Closes #117

(Excuse the extraneous commits, will be squashed before merge)
Working fine on the 32 bit layer, might need a little help on the 64 bit layer - work in progress on that. Thought I would get this up as a POC to start getting feedback before I finish it off.
Does this look alright?

LGTM, @shaojingli could you check on the fp64 in case I missed anything?

32-bit shaders looks good to me. We may need to change the code a bit for it to work on 64-bit scatterplot. Let's merge 32-bit first

Yeah, 64 bit was only implemented up to the shader - the vars are unused there, figured @shaojingli  would be best for that, seems like the 64 bit stuff is tricky.


CiliumNetworkPolicy egress overrides CiliumClusterwideNetworkPolicy egress

Is there an existing issue for this?

[X] I have searched the existing issues

Version
equal or higher than v1.16.0 and lower than v1.17.0
What happened?
I have a clusterwide egress policy for coredns that selects all endpoints.  If a CCNP and CNP both have toEndpoints the CCNP rule gets lost.  If CNP does not have toEndpoints the CCNP still applies.  I would expect that the CCNP and CNP array's to get merged.
These are the policies I have that are conflicting
apiVersion: cilium.io/v2
kind: CiliumClusterwideNetworkPolicy
metadata:
  name: core-dns
specs:
  - endpointSelector:
      matchLabels:
        io.cilium.k8s.policy.serviceaccount: coredns
        k8s:io.kubernetes.pod.namespace: kube-system
    ingress:
      - fromEndpoints:
          - {}
        toPorts:
          - ports:
              - port: "53"
                protocol: UDP
              - port: "53"
                protocol: TCP
  - endpointSelector:
      matchLabels: {}
    egress:
      - toEndpoints:
          - matchLabels:
              io.cilium.k8s.policy.serviceaccount: coredns
              k8s:io.kubernetes.pod.namespace: kube-system
        toPorts:
          - ports:
              - port: "53"
                protocol: UDP
              - port: "53"
                protocol: TCP
            rules:
              dns:
                - matchPattern: "*"

apiVersion: cilium.io/v2
kind: CiliumNetworkPolicy
metadata:
  name: argocd-redis-ha-haproxy
spec:
  description: Network policy for argocd redis-ha-proxy pods
  endpointSelector:
    matchLabels:
      app: redis-ha-haproxy
  ingress:
    - fromEndpoints:
        - matchExpressions:
            - key: app.kubernetes.io/name
              operator: In
              values:
                - argocd-server
                - argocd-repo-server
                - argocd-application-controller
            - key: k8s:io.kubernetes.pod.namespace
              operator: In
              values:
                - argo
      toPorts:
        - ports:
            - port: "6379"
              protocol: TCP
  egress:
    # egress to redis-server
    - toEndpoints:
        - matchExpressions:
            - key: k8s:app
              operator: In
              values:
                - redis-ha
            - key: k8s:io.kubernetes.pod.namespace
              operator: In
              values:
                - argo
      toPorts:
        - ports:
            - port: "6379"
              protocol: TCP
            - port: "26379"
              protocol: TCP

How can we reproduce the issue?

Create CCNP with an egress using toEndpoints that selects all endpoints
Create a CNP for a resource that contains a toEndpoints egress rule.
Observe that the CCNP rule no longer applies and traffic is dropped/audited.

Cilium Version
1.16
Kernel Version
Linux ip-10-0-156-208.ec2.internal 5.15.160 #1 SMP Tue Jul 16 23:47:08 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Kubernetes Version
EKS 1.27
Regression
No response
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Cilium Users Document

[ ] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Actually this may be related to https://github.com/cilium/cilium/issues/34066 instead.  If I remove the cidrgroup ingress DNS is allowed as it should be.  I believe this ticket implied the error did not affect anything but it appears it does.

Reopening.  This is actually valid.  I just managed to also hit the issue linked above in my testing.  Had another policy that this is happening with that doesn't use cidrset.

Added sysdump

cilium-sysdump-20240815-141151.zip
Added sysdump

Thanks for logging this with the sysdump @eric-engberg. I've labelled this to get it into the right backlog.

I'll look into this issue.

@eric-engberg, on further discussion among the committers, we have determined that this is not a bug in Cilium. The requires fields are indicated in the documentation to apply universally to their endpoint selectors. This documentation PR includes a warning on the requires labels that they are unmodified by other ingress or egress rules.

The example policies in the initial posting do not use the requires fields

@eric-engberg , I am unable to reproduce this issue without the requires fields. I found them in the sysdump you provided, and it applied to two policies that looked like the examples you gave. The requires fields apply to all rules that share their endpoint selector, regardless of other rules near them (toPorts, for example, does not limit a toRequires rule to just the specified port-protocol in toPorts). It does not matter which rule has the requires fields, it will still apply to all the other rules.

@eric-engberg in the example in the issue description, which applications are talking to which other applications in order to experience the issue?


feat: add onlyAggregator to respondToTask

This PR
onlyAggregator modifier was added to respondToTask.
For this, address aggregator was added on storage (and GAP decreased)
Implementation
To implement this contract upgrade, the same structure of implement pausable PR was followed;

A new solidity stored variable was created, alignedAggregator.
This variable is set on a reinitializer(2) function, as the industry standard.
The variable is also set on the first initialize of the contract, to avoid having to run the reinitialize on a freshly deployed contract (i.e mainnet). This doesn't change the current testnet deploys as this function can not be ran again, thus the reinitializer(2) function.
2 new make targets were made, to deploy in devnet and testnet.

Deploying
Devnet:
make anvil_upgrade_add_aggregator

Testnet:
(stage or prod should be set accordingly on the contracts/scripts/.env file)
make upgrade_add_aggregator

Testing this PR

Deploy previous version of contracts:

git checkout main

make anvil_deploy_aligned_contracts

make anvil_start_with_block_time

The following call should revert:
cast call 0x1613beB3B2C4f22Ee086B2b38C1476A3cE7f78E8 "aggregator()(address)" --rpc-url <IP_ADDRESS>:8545

But the following call should not revert:
(this is just to verify we have the correct ServiceManager address)
cast call 0x1613beB3B2C4f22Ee086B2b38C1476A3cE7f78E8 "balanceOf(address)(uint256)" 0x1613beB3B2C4f22Ee086B2b38C1476A3cE7f78E8 --rpc-url <IP_ADDRESS>:8545

Then close anvil
ctrl + c

You must preserve this anvil state before you switch to the new branch, for this you can:
git stash

git checkout 851-add-max-limit-eth-in-payment-from-batcher-to-aggregator-make-the-respond-to-ask-only-callable-by-one-agg

git apply

Upgrade to new version of contracts (make sure you are using previous anvil-state !)

The following upgrade should run and work without problems:
make anvil_upgrade_add_aggregator

Then you must start the devnet
make anvil_start_with_block_time

And the following call should return the aggregator's address:
cast call 0x1613beB3B2C4f22Ee086B2b38C1476A3cE7f78E8 "alignedAggregator()(address)" --rpc-url <IP_ADDRESS>:8545

Testing the modifier
To make sure the onlyAggregator modifier actually works, you must:

save a backup of anvil.aggregator.ecdsa.key.json
copy (for example) operator-3.ecdsa.key.json with the name anvil.aggregator.ecdsa.key.json, where this was before
run aggregator, operator, batcher.

make batcher_send_risc0_burst

Aggregator should revert when trying to submit:
Error: execution reverted: custom error 2cbe4195:00000000000000000000000090f79bf6…1aad88f6f4ce6ab8827279cfffb92266 (64 bytes)

same comment as @NicolasRampoldi on my side too

I have fixed the steps to test this PR , the contract had a refactor renaming the aggregator variable to alignedAggregator , so the call to get this variable is cast call 0x... alignedAggregator()(address)


Server compile error, need Java 8

I'm currently trying to deploy my Spring Boot app on a Java 8 server, but it seems it's not possible due to the simple-openai library, which requires Java 11.
Is there an older version of simple-openai that supports Java 8, or is there a way to make it work?
I’m also investigating how to install Java 11 without setting it as the default and use it only for my project. I cannot upgrade the server's default JDK to 11 because there are many projects that might encounter issues or stop working if I upgrade.

Hi @SitaMelark thanks for your question.

Is there an older version of simple-openai that supports Java 8, or is there a way to make it work?

No, there is not. Currently, you need Java 11+ to make it work.

I’m also investigating how to install Java 11 without setting it as the default and use it only for my project. I cannot upgrade the server's default JDK to 11 because there are many projects that might encounter issues or stop working if I upgrade.

For that point, I recommend you to use sdk to install and work with multiple Java versions.


Homebrew Releases

Automatically release new with goreleaser to homebrew

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Resampling artifacts for Int16 datasets on CENTOS

I'm seing some resampling artifacts on tile bottom border but only when the tile cover area with nodata.

The artifacts disappear when using nearest resampling.
https://github.com/cogeotiff/rio-tiler/blob/9618f13c38d35225d1e2de2cf58b986c7f5c3986/rio_tiler/utils.py#L234-L256
To Do

[ ] check which resampling is responsible (WarpVRT at L235 or read at L255)
[ ] check if the artifact is present when using gdalwarp
[ ] create Notebook

also need to re-check #78
cc @sgillies (FYI)

This seems to be fixed by #104

This is still present but can only see it in ubuntu and centos (not on Mac OS)

Making baby steps here, I confirmed the bug appears when using GDALCreateGenImgProjTransformer3 and GDALCreateWarpedVRT
https://gist.github.com/vincentsarago/361ab25c070be47934c1e14c79adbc27
👇 images created using ☝ on a centos docker image with rasterio build against gdal sources (same appears with wheels). Docker images: remotepixel/amazonlinux:gdal3.0-py3.7-build

gonna check rasterio version before https://github.com/mapbox/rasterio/pull/1073 to see if it change something

In addition to resampling artefacts I'm also seeing some difference in the WarpKernel used by GDAL and rasterio, and also in the number of GET requests needed to read the tile in the test case above.
I'll see if we can dig deeper and see if the WarpedVRT class should be optimized (or if we need to write a new Cython code calling other GDAL functions).
Next:

Add more tests proving the GET requests and WarpKernel differences
start a discussion on https://rasterio.groups.io/g/dev/topics
Investigate GDAL C++ API

cc @sgillies

Just run some test to see if we could use https://github.com/mapbox/rasterio/blob/master/rasterio/_warp.pyx#L925-L929 to handle non-boundless read (VRT doesn't support boundless), it removes the artifacts but then it fetches more data 😢

Update, this seems to happen only on CENTOS arch

if it still exists it's not a rio-tiler bug


Issue with popover placement with first load, using zustand to open

Related page
https://mui.com/material-ui/api/popper/
Kind of issue
Unclear explanations
Issue description
No response
Context
No response
Search keywords: Popover, zustand, placement

It doesn't look like the issue contains reproduction for us to investigate. Please create a CodeSandbox with a reproduction and a better description of the problem.


Creating Rsa3072KeyPair under ucrypto feature panics

I'm using the branch v2.0.0-preview-11-17, creating Rsa3072KeyPair works for tcrypto feature (within enclave) but not with ucrypto for non-enclave.
It can be reproduced by:
use sgx_crypto::rsa::Rsa3072KeyPair;
fn main() {
    let _ = Rsa3072KeyPair::create().unwrap();
}

Running it gives SGX unexpected error:
called `Result::unwrap()` on an `Err` value: Unexpected

Dependency in TOML:
[dependencies]
sgx_crypto = { git = "https://github.com/apache/incubator-teaclave-sgx-sdk", branch = "v2.0.0-preview-11-17", default-features = false, features = ["ucrypto"] }

Thanks!

I'm trying to apply newer intel-sdk version to v2.0.0 branch and this problem seems to occur again with intel-sdk-2.21, I'm referring to this dexlabs' version on v2.0.0-sgx-emm branch
It seems I'll get Unexpected error with or without this fix.
To reproduce this, simply change the TOML dep to:
sgx_crypto = { git = "https://gitlab.com/dexlabs/incubator-teaclave-sgx-sdk", rev = "1b80455857b16fef02348a5b6db01f2888a49fd5", default-features = false, features = ["ucrypto"] }

I'm trying to apply newer intel-sdk version to v2.0.0 branch and this problem seems to occur again with intel-sdk-2.21, I'm referring to this dexlabs' version on v2.0.0-sgx-emm branch
It seems I'll get Unexpected error with or without this fix.
To reproduce this, simply change the TOML dep to:
sgx_crypto = { git = "https://gitlab.com/dexlabs/incubator-teaclave-sgx-sdk", rev = "1b80455857b16fef02348a5b6db01f2888a49fd5", default-features = false, features = ["ucrypto"] }

@Kailai-Wang Thanks for reporting, I am the maintainer for DEX Labs' fork. I am not user if I have rebased @volcano0dr fix to our fork. I will take a look and reply to you. Meanwhile, you are welcome to check it and report issues to the gitlab issues.

I'm trying to apply newer intel-sdk version to v2.0.0 branch and this problem seems to occur again with intel-sdk-2.21, I'm referring to this dexlabs' version on v2.0.0-sgx-emm branch
It seems I'll get Unexpected error with or without this fix.
To reproduce this, simply change the TOML dep to:
sgx_crypto = { git = "https://gitlab.com/dexlabs/incubator-teaclave-sgx-sdk", rev = "1b80455857b16fef02348a5b6db01f2888a49fd5", default-features = false, features = ["ucrypto"] }

@Kailai-Wang Thanks for reporting, I am the maintainer for DEX Labs' fork. I am not sure that if I have rebased @volcano0dr fix to our fork. I will take a look and reply to you. Meanwhile, you are welcome to check it and report issues to the gitlab issues.

Thank you, that would definitely help!
I tried my branch (which includes the sgx_rand fix) but it didn't seem to work either :(

I created an issue in your repo too: https://gitlab.com/dexlabs/incubator-teaclave-sgx-sdk/-/issues/4 : )
@yangfh2004


Zoom in/out animation

Hi @korre, thanks for this great library! I would like to implement zoom in/out animation for EPGEvent cause some text cant be visible properly. My approach is to increase hours per pixel but when I increase it and redraw scroller stays behind at the old position. I tried to move it by startScrolling to the time of the event but it is not smooth.

Hi I too wanted to add zoom functionality, did you manage to do it, if so could you share your solution please


chore: cleanup some unintended files (#748)

Backport
This will backport the following commits from k8s-24/main to k8s-22/main:

chore: cleanup some unintended files (#748)

Questions ?
Please refer to the Backport tool documentation

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 749

Questions ?
Please refer to the Backport tool documentation


Where does one find kbid's these days?

21337 just dropped and I installed it.
D:\>wmic qfe
Caption                                     CSName           Description  FixComments  HotFixID   InstallDate  InstalledBy          InstalledOn  Name  ServicePackInEffect  Status
http://support.microsoft.com/?kbid=5001029  DESKTOP-930EG0A  Update                    KB5001029               NT AUTHORITY\SYSTEM  3/18/2021
http://support.microsoft.com/?kbid=5001030  DESKTOP-930EG0A  Update                    KB5001030               NT AUTHORITY\SYSTEM  3/18/2021

http://support.microsoft.com/?kbid=5001029 resolves to only http://support.microsoft.com.  Googled, etc. but no joy.

How is this WSL-related?

Oh my god - you're absolutely right.


Add vertical variation to divider component

A use case is in the new data toolbar component. Relevant - https://github.com/patternfly/patternfly-next/pull/2119#discussion_r313624056

:tada: This issue has been resolved in version 2.67.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Added new recordtypes and usertypes

Docs Build status updates of commit 42bae2a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

office-365-management-api/office-365-management-activity-api-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


rust: fix build of pam-sys package

Motivation for this change
Fix cargo build failure when I depend on pam-sys package
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@Mic92 Thanks!


Not getting full file path of spec in terminal

For some reason when I run any of the vim-rspec commands it shows up in my terminal as something like "rspec ~/railsapp/user_spec.rb" instead of "rspec ~/railsapp/spec/models/user_spec.rb". I changed
function! s:CurrentFilePath()
  return @%
endfunction

to
function! s:CurrentFilePath()
  return expand('%:p')
endfunction

in plugin/rspec.vim and it seemed to fix it. I was wondering if anyone else had this problem?

It's likely you are in the directory of the file that you have open.
What is the result of running :echo @% from Vim when you have the file open? Do you have something that changes the directory when you open the file?

Running :echo @% from Vim when I have the file open returns the current file name without the path. I don't think I have anything that changes the directory when I open the file. Perhaps this is just an issue with some dotfile I have somewhere.

What is the result of :pwd?

:pwd always prints full path to the file but not including the file name. For example if I had the file /Users/Patrick/project/app/controllers/user.rb open, then :pwd would output /Users/Patrick/project/app/controllers. (This is on a mac)
Also here are the versions I'm using:

Vim is 7.4 (installed by Homebrew)
Rails 4.2
RSpec 3.4
iTerm 2.1.4

I'm also not sure if I'm using vim-rspec correctly. We are supposed to hit <leader>t from the controller file or from the test file? Actually, neither work for me when I use @% instead of expand('%:p'). For example if I call <leader>t from something like spec/controllers/user_controller_spec.rb or from the controller file e.g. app/controllers/user_controller.rb using @% nothing happens (a terminal window doesn't even show up) but when I use expand('%:p') then I can call the tests from both of these places.

I am also getting the same issue but I only came across this since I started using this vim distribution https://github.com/spf13/spf13-vim . I'm assuming there is a configuration within spf13's vim distribution that changes the file path somehow.

I'm getting the same behavior...but only some times. I'm using FZF using  Ag to build list of files (vimrc). It seems that on occasion when a file is opened with :FZF @% will only expand to the relative and not the full path. But expand('%:p') does get the fully qualified path.


Need validation before unmarshall response in restlib

When we generate a client file in golang with two expected kinds of response it will generate code like responses := []interface{}{&A{}, &B{}}
This response will pass into restlib.DoHTTPRequest()
In this method's
for _, respInterface := range response {
	err = json.Unmarshal(respBody, respInterface)
	if err == nil {
		return makeHTTPResult(httpResponse, respBody, respInterface), nil
	}
}

It didn't do the validation before unmarshall, so this unmarshall method never failed, it always marshall the respBody to the first respInterface come up from the for loop.
In this case, the response body will always return as &A{}.

Issue happened here: https://github.com/anz-bank/syslgen-examples/blob/master/restlib/restlib.go#L74-L79
https://play.golang.org/p/vJ46sZ-VqKh  What I did in this example is just like the restlib unmarshal the response body.
And this example shows how Human unmarshal to Car!
Propose to use https://godoc.org/gopkg.in/go-playground/validator.v10(Just know they got v10, we still use v9 in gobff)to validate json struct before unmarshal.
This may need changes for both restlib(add validation logic) and the transform file(add validation tag) we use.

The longer term solution is for the generated code to derive the type of the response from the response code. @gkanz and I have discussed this before and come up with a strategy, which is why I assigned it to him (so he can elaborate the solution here, possibly for someone else to work on).

Agree, the unmarshall needs to be fixed. This is a restlib issue, tenerated code does cast assertions to check which type is returned.

Random musings: Since Sysl (and Swagger, I think) maps status codes to return types, the following concept provides a very flexible way to access results based on either status codes or return types. The case in point is overkill (done that way for illustrative purposes) since there is only one return type and one error type. In practice, if there's a single type, the codegen could simply return the given types directly without the type-casting machinery.
Generated code

func FooBar(ctx context.Context, arg1 string) (FooBarResult, error) { … }

type FooBarResult interface{}

type FooBarResultStatusOK interface {
	CustomerProfile() *CustomerProfile
}

type FooBarErrorStatusBadRequest interface {
	ErrorInfo() *ErrorInfo
}

type FooBarErrorStatusUnauthorized interface {
	ErrorInfo() *ErrorInfo
}

type FooBarResultTypeCustomerProfile struct {
	result *CustomerProfile
}

func (r *FooBarResultTypeCustomerProfile) CustomerProfile() *CustomerProfile {
	return r.result
}

type FooBarErrorTypeErrorInfo struct {
	result *ErrorInfo
}

func (r *FooBarErrorTypeErrorInfo) ErrorInfo() *ErrorInfo {
	return r.result
}

Developer code
func foo() {
	r, err := FooBar(...)
	if err != nil {
		switch r := r.(type) {
		case FooBarErrorStatusBadRequest:
			panic("wat?")
		case *FooBarErrorTypeErrorInfo:
			fmt.Error(r.ErrorInfo())
		}
	}
	switch r := r.(type) {
	case FooBarResultStatusOK:
		doSomethingWith(r.CustomerProfile())
	}
}

This is also a bit messier than it initially looks as I have not seen any Swagger or SYSL that fully specifies all the return types. I have seen some shorthand in Swagger that specifies different types against 2XX, 4XX and 5XX. It would be good to not have to specify every possible status.
Returning multiple types also lends itself to a switch btw:
switch {
  case customerProfile != nil:
    doSomethingWith(customerProfile)
  case errorInfo != nil:
    fmt.Error(errorInfo)
  case err != nil:
    panic(err.Error())
}

and the status can be passed back in the context if someone really wants to know what it was.


Improve latency tests

Run latency test for 5H
Save only the latency of the first SV of each 4000 iteration as a temporary workaround due to current memory limitations

In this case, you can just create the branch to run the CI in the action tab. No need to create the PR.


Create Azure Service Principal

As a developer, I can run bedrock create az-sp and a sample service principal will be created.
Low priority, this just reduces looking up az-cli documentation

Do we want to support this or should we make the expectation that users will bring their own SP?

i think this is just a simple ticket. it just calls az ad sp create-for-rbac --subscription <subscription>. But this is used to get a service principal that we can track for the cluster. BYOSP or have the cli create one, i'm okay with either.

Discussed this with Jim. For now, let's settle with a "BYO" Service Principal.


tokio::time::sleep panics

My Tokio runtime:
let rt = tokio::runtime::Builder::new_multi_thread()
    .worker_threads(1)
    .enable_all()
    .build()
    .unwrap();

I even tried enabling time and net features.
async:
rt.spawn(
    async move {
        ffi_fn().await;
    }
}

ffi_fn (shared lib - works if from same lib...):
pub extern "C" fn ffi_fn() -> FfiFuture<()> {
    async {
        tokio::time::sleep(std::time::Duration::from_millis(500)).await;
    }.into_ffi()
}

tokio version: 1.6.16
async-ffi: 0.4.0

This is the specific error:
https://github.com/tokio-rs/tokio/blob/ed187ddfb8d99682ff104832c798022a69bd7016/tokio/src/runtime/context.rs#L52
pub(crate) fn time_handle() -> crate::runtime::driver::TimeHandle {
        match CONTEXT.try_with(|ctx| {
            let ctx = ctx.borrow();
            ctx.as_ref().expect(crate::util::error::CONTEXT_MISSING_ERROR).time_handle.clone()
        }) {
            Ok(time_handle) => time_handle,
            Err(_) => panic!("{}", crate::util::error::THREAD_LOCAL_DESTROYED_ERROR),
        }
    }

This is due to trying to access this:
thread_local! {
    static CONTEXT: RefCell<Option<Handle>> = RefCell::new(None)
}

There is actually a solution I know of to solve this sort of gnarly issue with thread local.
That is to compile and link tokio as a shared library dependency. That way, the thread-local var will be initialized equally by all parties.

I've basically solved this: https://github.com/tokio-rs/tokio/pull/4493
Let me know if you'd like me to try to upstream a macro.

The issue is caused by tokio using specific thread local variables to talk with the runtime when calling leaf async functions (sleep, etc). Thus nearly all of its functions require to be run inside an initialized tokio runtime, and not generally compatible with just Future interface. That's also the reason why tokio libraries can only be run under tokio runtime. If I remember correctly, async-std functions are not exclusive and are compatible with any runtime.
If you do want to use tokio runtime, or being runtime-agnostic, I'd suggest to export necessary leaf async functions (sleep, write, send, etc) in host side. For client side, don't include any async runtime, and just use these exported async basics to implement your plugin functions. This can also avoid initializing the runtime twice in client side.

That's not feasible if I were using one of the libraries built on top of tokio like Tower, Hyper etc.
I'd like to be able to plug and play. I am now investigating how feasible this is.
Note that I am not, as you assume, instantiating a new runtime in the client side. Rather, I am merely passing a handle to the runtime from the host.
However, thanks for the tips about async-std.
I have to do a lot more testing now to see what situations my solution works in and in which ones it breaks.

Note that I am not, as you assume, instantiating a new runtime in the client side.

TL;DR: Blame tokio. Try other runtimes to work out-of-box.
Longer version: tokio uses hidden shared statics besides the standard Future/Waker interface, while this crate can only handle the latter one. So tokio cannot be used crossing FFI boundary without starting a new runtime. It's an issue of tokio itself. Other runtimes like async-std, futures or your handwriting one, would work without any issue.

Rather, I am merely passing a handle to the runtime from the host.

Sorry but you cannot. Because the host and client side are compiled in two batch and cannot co-work. Rust uses static linking now.
Detail version:

tokio from the host and the client are different and cannot communicate through internal static or thread locals, since they are linked in two batches. So your sleep doesn't even know it's inside a tokio runtime.
Due to its exclusive implementation, tokio's reactor (sleep, write, send, etc), must be called in the same tokio runtime, or it will panic.
This crate wraps the standard Future/Waker interfaces. So Futures can correctly communicate through it. But we cannot wrap other hidden ways.
Other runtime like async-std, futures are runtime-agnostic because they only use the standard interfaces to communicate with the runtime. If you use their reactor, like sleep, they work under any runtime, no matter it's tokio, async-std, or your handwriting one. (They also don't need to auto-start a new runtime, unless you call spawn in client side.)

So my suggestions are,

Use non-tokio async basics in client side. So they always work regardless of the runtime of host side. (See example, I use async-std's sleep in tokio runtime. But you cannot do the reverse.)
If you stick on tokio, you could either start a new tokio runtime and carefully write your C-exported functions to not directly using any tokio functions. Or,

...export necessary leaf async functions (sleep, write, send, etc) in host side. For client side, don't include any async runtime, and just use these exported async basics to implement your plugin functions. This can also avoid initializing the runtime twice in client side.

@oxalica I've managed to solve the problems you described more or less entirely.
I register some callbacks which initialize the thread_local vars from the Handle of the outer callback.
I will turn this into a crate, tokio-dynlib, unless you are interested in also hosting this here? (I think the scope is related but somewhat separate)


Remove gaia dependency

Removes dependency on Gaia, also cleans up some Travis assumptions that worked only when there was a build cache.
@kotfic  PTAL

@mgrauer I am still having trouble getting the ansible/girder-install to work with minerva on a local integration branch but that isn't a problem with this.
LGTM


PackageId:CPython39.Exe.x64;PackageAction:DownloadPackage;ReturnCode:0x80131505;

This issue has been moved from a ticket on Developer Community.

[severity:It's more difficult to complete my work]
Describe your issue here
===DO NOT EDIT BELOW THIS LINE===
PackageId:CPython39.Exe.x64; PackageAction:DownloadPackage; ReturnCode:0x80131505;

Original Comments
Feedback Bot on 5/10/2023, 01:05 AM:
(private comment, text removed)

Original Solutions
(no solutions)

It seems the problem occurs when installer tries to download python. This could be due to network timeouts, corporate firewall policy, VPN configuration, anti-virus, or other problems. See if a retry helps, and if not, see if you can download the Python runtime directly from https://python.org/ and install it manually.
If that doesn't solve your issue, we could use more detailed logs to see what's really going on. Can you please collect more logs by running http://aka.ms/vscollect.exe and uploading %temp%\vslogs.zip and reopen the ticket if it persists? Thank you!😊


Is this addon expected to ship in production?

I have read through the code and seems that this addon is unconditionally including the proptypes library and reopening components, unless I've missed something.
Is this intended? I think it should only run in development and tests but be removed in production.
Disclaimer: i've never used PropTypes in react, so I don't know if there is any reason to run it in production too.

You're correct, currently this will all ship in production builds. Right
now it should be possible to blacklist the addon for prod in an app's
ember-cli-build.js, however I will be shipping an update in the next day
or two that will ensure both the library and the component reopening are
only included in development builds.
Thanks for filing this!
On Thu, May 18, 2017 at 06:22 Miguel Camba<EMAIL_ADDRESS>wrote:

I have read through the code and seems that this addon is unconditionally
including the proptypes library and reopening components, unless I've
missed something.
Is this intended? I think it should only run in development and tests but
be removed in production.
Disclaimer: i've never used PropTypes in react, so I don't know if there
is any reason to run it in production too.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/healthsparq/ember-cli-prop-types/issues/1, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAOWfVuWCWnWERaxAQAUXrCU3vmaKO_vks5r7EYGgaJpZM4NfN5_
.

This is now resolved in 1.1.0. I would love some feedback on the approach used to handle removing the code for prod builds; while the approach I have works, I suspect there is a better way to handle this.

How about a babel-plugin which removes proptypes and import statements when env is in production mode ?

I summon @rwjblue since he has experience with removing code in production.
Do you know any good example we can copy from to get this library, and the propTypes of each component, completely removed in production?

I was referring something related like this https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types

@asvny Thanks for the suggestion, I'll definitely explore that as an option. Could be much simpler/easier to utilize than my current approach.
Would definitely appreciate some input from @rwjblue on this matter as well, I'm sure he's got some great insight. Thanks for thinking to mention him, @cibernox

@cibernox the prop-types library has a prop-types.js and a prop-types.min.js. The .min file is only 2KB (0.8KB gzipped). I'll be merging in PR #2 soon, which imports the .min file for production builds.
The Component.reopen will be stripped out in production builds (the initializer is still run).
I am planning on implementing a getDefaultProps to allow for default props on Components with optional passed properties, where the component is always declared in template with the property passed, but a value may only be passed some of the time (this is not a common case, but we've run into it in our application a few times, especially when using the component helper with dynamic passed property values 😅 ).
B/c of incoming getDefaultProps, which should be run in production, this addon is intended to be included in production builds, but the prop-types validators will only be imported in dev builds and the call to checkPropTypes will also only occur in dev builds.
@asvny would love to use a babel plugin 👍 , have any interest in porting over the babel-plugin-transform-react-remove-prop-types to work with Ember apps?
Thanks for your interest in the addon, we're very excited about borrowing the React props validation patterns into our Ember applications. Keep the ideas coming!

@DHedgecock  Much happy to help !
I'm am very interested in using this plugin because in a glance I can know what all are props it takes and shape of it .

Alright, #2 is merged, which upgrades the dev vs prod imports. I also added some notes to the README here: https://github.com/healthsparq/ember-cli-prop-types#in-production.
tldr:

Yes, this addon needs to be included for prod builds or your propType definitions and imports will throw errors
In production the addon will import a very lightweight set of AMD shims. Application is not altered.
Addition of getDefaultProps that will run in production is planned.

I'm going to close this issue, feel free to add additional comments if you have additional concerns. And thanks again for all the scrutiny. Feels good to get all the ducks lined up 👍 .

🙌🙌🙌🙌
On Mon, May 22, 2017 at 16:19 Dan Hedgecock<EMAIL_ADDRESS>wrote:

Alright, #2 https://github.com/healthsparq/ember-cli-prop-types/pull/2
is merged, which upgrades the dev vs prod imports. I also added some notes
to the README here:
https://github.com/healthsparq/ember-cli-prop-types#in-production.
tldr:

Yes, this addon needs to be included for prod builds or your propType
definitions and imports will throw errors
In production the addon will import a very lightweight set of AMD
shims. Application is not altered.
Addition of getDefaultProps that will run in production is planned.

I'm going to close this issue, feel free to add additional comments if you
have additional concerns. And thanks again for all the scrutiny. Feels good
to get all the ducks lined up 👍 .
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/healthsparq/ember-cli-prop-types/issues/1#issuecomment-303245890,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOWfVDB4bmjLGagHAAPU9bjbwMX35Goks5r8hfngaJpZM4NfN5_
.


Github markdown doesn't allow for embedded videos

GitHub Issue: (link)
Corrects the page view within Github.
From

To

What does this Pull Request do?
Switches out the html <embed> with the Github suggested alternative for youtube videos.
What's new?
Just the image.
How should this be tested?
Make sure the image links to the correct spot and the thumb is correct.
Additional Notes:
N/A
Interested parties
@Islandora/8-x-committers

This looks better in markdown, but doesn't embed the video in the generated html.  I don't mind that, just pointing it out.  If other folks don't mind, I'm more than happy to merge this in :+1:


Heroku App does not work anymore

The URL linked in the title, http://angular2-seed.io/ (redirecting to http://angular2-seed.herokuapp.com/) results in an Application Error.

Thanks for the heads up.
I've just checked the Heroku logs and found out what the issue is.
[09:00:04] Starting 'build'...
[09:00:05] 'build' errored after 289 ms
[09:00:05] Error: File not found with singular glob: /app/typings/main.d.ts
   at Glob.<anonymous> (/app/node_modules/glob-stream/index.js:39:11)
   at Glob.g (events.js:273:16)
   at Glob.emit (events.js:182:7)
   at emitOne (events.js:90:13)
   at Glob._processSimple2 (/app/node_modules/glob/glob.js:652:12)
   at Glob._stat2 (/app/node_modules/glob/glob.js:736:12)
   at /app/node_modules/glob/glob.js:640:10
   at done (/app/node_modules/glob/glob.js:159:12)
   at Glob._finish (/app/node_modules/glob/glob.js:172:8)
[09:00:05] 'build' errored after 426 ms
[09:00:05] Did you forget to signal async completion?
   at RES (/app/node_modules/inflight/inflight.js:23:14)
   at FSReqWrap.oncomplete (fs.js:82:15)
   at lstatcb_ (/app/node_modules/glob/glob.js:728:12)
   at f (/app/node_modules/once/once.js:17:25)
Process exited with status 1

I think it's because since the new version of Typings it deploys the definition files .d.ts to a different folder and Gulp can't find them.
Unfortunately I haven't had time to work on this project lately. But please feel free to send a PR.


fixed issue #6

The code of passwordmeter is really hard to read (so kudos for rewriting this in nice style), I didn't find a description of algorithm, but I've applied what I see they mean there. There was a bug in flatTest and requirements stragegy missed few details.
Related to #6.

Alex,
Thank you  very much for your interest in the project and for your pull request. Buildium is in the process of working out its Contributor's License Agreement, and I can't merge this request until that is settled.
Thanks again for your contribution, and I hope to get back to you in the near future.

@benmj ping :)


Published Service Bus messages do not persist correlation (traceparent) into Diagnostic-Id

According to the docs for distributed logging with service bus, the WC3 traceparent header should be persisted to the message  Diagnostic-Id property.
However, in my testing this does not seem to happen.
import { ServiceBusClient, ServiceBusMessage } from '@azure/service-bus';

/* Test function that sends a service bus message
const httpTrigger = async function (context, req) {

  const sbClient = new ServiceBusClient(serviceBusEndpoint, credentialChain);

   // Service Bus Sender for specific topic/queue
   const sender = sbClient.createSender(topic);

    try {
      // Send Messages to topic/queue
      await sender.sendMessages(
        {body: {"hello": "world"}}
      );

      // Close Sender
      await sender.close();
    } finally {
      // Close connection
      await sbClient.close();
    }

    context.res = {
        status: 200
    };
};

export default async function contextPropagatingHttpTrigger(context, req) {
    // Start an AI Correlation Context using the provided Function context
    const correlationContext = appInsights.startOperation(context, req);

    // Wrap the Function runtime with correlationContext
    return appInsights.wrapWithCorrelationContext(async () => {
        const startTime = Date.now(); // Start trackRequest timer

        // Run the Function
        const result = await httpTrigger(context, req);

        // Track Request on completion
        appInsights.defaultClient.trackRequest({
            name: context.req.method + " " + context.req.url,
            resultCode: context.res.status,
            success: true,
            url: req.url,
            time: new Date(startTime),
            duration: Date.now() - startTime,
            id: correlationContext.operation.parentId,
        });
        appInsights.defaultClient.flush();

        return result;
    }, correlationContext)();
};

The resulting Message has a different Diagnostic-Id to the current correlationContext.operation.parentId
Should it not pickup the tracecontext by default?  The docs seem very unclear around this...

@ChuckJonas can you share docs you are referring to? I'm not really familiar with Diagnostic-Id property

ya Sorry, I thought I had included it:
https://learn.microsoft.com/en-us/azure/service-bus-messaging/service-bus-end-to-end-tracing?tabs=net-standard-sdk-2


[OTHER] Add new Quotes

Description
Try to add new quotes with previous categories.
you dont have to get assigned for adding quotes.
and make sure to read the contribtion guideline
Screenshots
No response
Additional information
No response
👀 Have you checked if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read and understood the rules in the contribution guideline

Are you willing to work on this issue ?
None

Hello @Shariar-Hasan I would like to work on this issue

you dont have to get assign for adding quotes.

@Shariar-Hasan  Assign This To me under Hacktoberfest

you dont have to get assigned for adding quotes

.

you dont have to get assigned for adding quotes

.

Why ?

you dont have to get assigned for adding quotes

.

Why ?

what do you mean by why?
adding quotes does not need to get assigned,
just make a PR.
you should read contribution guideline

you dont have to get assigned for adding quotes

.

Why ?

what do you mean by why?
adding quotes does not need to get assigned,
just make a PR.
you should read contribution guideline

@Shariar-Hasan this is the reason that I don't know that's why m asking why ?
Ok then.

that why i told you to read the contribution guideline.

@Shariar-Hasan Check It Sir #125

@Shariar-Hasan Check It Sir #125

do not mention any PR for Quote.

@Shariar-Hasan Check It Sir #125

do not mention any PR for Quote.

@Shariar-Hasan But After this Merged it is not reflecting in Hacktoberfest ?

@Shariar-Hasan Check It Sir #125

do not mention any PR for Quote.

@Shariar-Hasan But After this Merged it is not reflecting in Hacktoberfest ?

no problem,
as long as the repo has a topic : hacktoberfest,
your PR will still be count for it.
and, i am just asking not to mention issue in PR Only for Quote add


Allow yield expression in a closure referencing the generator body.

The compiler complains when an yield is employed inside a function even though directly enclosed by the generator body.
TypeScript Version:  2.1.5
Code
function *myGenerator(base: string, file: string) {
    const fs   = require("fs");
    const lines1 = fs.readFileSync(`${base}/${file}`, {encoding: "utf-8"}).toString().split('\n');
    for (let i=0; i<lines1.length; i++) {
        const line = lines1[i];
        yield line; // COMPILES
    };

    const lines2 = fs.readFileSync(`${base}/${file}`, {encoding: "utf-8"}).toString().split('\n')
        .forEach(function (line) {
            yield line; // DOES NOT COMPILE
        });
}

Expected behavior:
Being absolutely oblivious about the current capabilities of the compiler in regards to this functionality, I'm naively hoping that the compiler is able to capture the outer scope of the generator definition.
Actual behavior:
error TS1163: A 'yield' expression is only allowed in a generator body.

Question raised at StackOverflow:
http://stackoverflow.com/questions/41810518/cannot-compile-async-code-with-generators-in-typescript

yield is only valid in generator functions and cannot be used in the body of function expressions inside generators. This is actually a syntactic error in JS; TS just gives you a more informative error message.


find() has no _type condition when using gsi

ISSUES will not receive priority that do not follow this template or cannot be easily reproduced or diagnosed
Describe the bug
find() has no _type condition when using gsi
To Reproduce
Table Schema
{
  "TableName": "example-local",
  "AttributeDefinitions": [
    { "AttributeName": "pk", "AttributeType": "S" },
    { "AttributeName": "sk", "AttributeType": "S" },
    { "AttributeName": "gsi1pk", "AttributeType": "S" },
    { "AttributeName": "gsi1sk", "AttributeType": "S" },
    { "AttributeName": "gsi2pk", "AttributeType": "S" },
    { "AttributeName": "gsi2sk", "AttributeType": "S" }
  ],
  "KeySchema": [
    { "AttributeName": "pk", "KeyType": "HASH" },
    { "AttributeName": "sk", "KeyType": "RANGE" }
  ],
  "GlobalSecondaryIndexes": [
    {
      "IndexName": "gsi1",
      "KeySchema": [
        { "AttributeName": "gsi1pk", "KeyType": "HASH" },
        { "AttributeName": "gsi1sk", "KeyType": "RANGE" }
      ],
      "Projection": {
        "ProjectionType": "ALL"
      }
    },
    {
      "IndexName": "gsi2",
      "KeySchema": [
        { "AttributeName": "gsi2pk", "KeyType": "HASH" },
        { "AttributeName": "gsi2sk", "KeyType": "RANGE" }
      ],
      "Projection": {
        "ProjectionType": "ALL"
      }
    }
  ],
  "BillingMode": "PAY_PER_REQUEST"
}

Model
{
  pk: { type: String, value: 'example#${id}' },
  sk: { type: String, value: 'example#' },

  id: { type: String, uuid: 'ulid' },
  name: { type: String },

  gsi1pk: { type: String, value: 'example#${id}' },
  gsi1sk: { type: String, value: 'example#' },

  gsi2pk: { type: String, value: 'example#' },
  gsi2sk: { type: String, value: '${name}' },
};

Code
const table = new Table({
  name: process.env.TABLE_NAME,
  client,
  schema,
  logger: true,
});

const exampleClient = table.getModel<Example>('Example');

const result = await exampleClient.find({}, {
      limit: 25,
      next,
      index: 'gsi2',
      log: true,
      follow: false,
    });

Log
info OneTable result for "find" "Example" {
    "cmd": {
        "ExpressionAttributeNames": {
            "#_0": "gsi2pk"
        },
        "ExpressionAttributeValues": {
            ":_0": "example#"
        },
        "KeyConditionExpression": "#_0 = :_0",
        "TableName": "example",
        "ConsistentRead": false,
        "IndexName": "gsi2",
        "Limit": 21,
        "ScanIndexForward": true
    },
    "items": [],
    "op": "find",
    "properties": {
        "gsi2pk": "example#"
    },
    "params": {
        "parse": true,
        "high": true,
        "limit": 25,
        "index": "gsi2",
        "log": true,
        "follow": false,
        "checked": true
    }
}

Expected behavior
"cmd": {
        "ExpressionAttributeNames": {
            "#_0": "_type",
            "#_1": "gsi2pk"
        },
        "ExpressionAttributeValues": {
            ":_0": "Example",
            ":_1": "example#"
        },
        "FilterExpression": "#_0 = :_0",
        "KeyConditionExpression": "#_1 = :_1",
        "TableName": "example",
        "ConsistentRead": false,
        "IndexName": "gsi2",
        "Limit": 19,
        "ScanIndexForward": true
    }

Environment (please complete the following information):

OS : Mac OSX
Node Version : 16.4.2
OneTable Version : 2.1.0

Were you expecting a filter expression to test _type == 'Example'?
But that not necessary.  If the GSI2PK == 'example#' then that will only match example types. A filter expression on _type is not required and not used.
Even if finding with the primary index, a filter expression on _type is not required.

AWS Example
refer to this example
HR-Employee - PK: EmployeeID, SK: Employee Name
OE-Order - PK OrderID, SK: CustomerID
Both have the same gsi1pk EMPYLOYEE1
If there is no _type expression, EmployeeClient returns Employee and Order both when using gsi1
"ExpressionAttributeNames": {
            "#_0": "gsi1pk"
        },
        "ExpressionAttributeValues": {
            ":_0": "EMPLOYEE1"
        },
        "KeyConditionExpression": "#_0 = :_0",
        "TableName": "example",
        "ConsistentRead": false,
        "IndexName": "gsi1",
        "Limit": 21,
        "ScanIndexForward": true

There is no filter in this expression that filter Employee and Order

I don't see any 'type' attribute in that table at all.  Am I missing something?
Some early AWS examples were before thinking evolved on how to do single-table patterns and before the use of a 'type' attribute was seen as best practice.
OneTable expects and requires a 'type' attribute. It automatically defines this in the schema behind the scenes so all items have a type. Newer AWS examples by Rick H et al, have a type attribute for items.
Now if you are using an existing model, you need to first ensure it has a type attribute and it is set to the name of each model.
You

I attached it only to show gsi1pk is the same model.
To explain in more detail,
Assuming that there are 1 Employees and 10 orders that have a same gsi1pk 'EMPLOYEE1'
When this code was executed,
const employeeClient = table.getModel<Employee>('Employee');

const result = await employeeClient.find({
    gsi1pk: 'EMPLOYEE1',
}, {
      limit: 25,
      next,
      index: 'gsi1',
      log: true,
      follow: false,
    });

I expected that employclient returns only 1 data that _type is Employee.
But this code returned 11 data including Orders.

That query will return any items that use that GSI PK which is 'EMPLOYEE1'. So you will get multiple items. Your GSI SK does not discriminate based on type. You use:
  gsi1sk: { type: String, value: 'example#' },

Whereas if you used:
gsi1sk: {type: String, value: 'example#${_type}'}

that would then return only the employee (provided your data has a _type attribute).
Also, typically you should not be providing the GSI PK, but rather be providing the ID and let OneTable calculate the PK value from the value template.

I'm going to move this to discussions as this is a useful stream for others.


DateTime literals

Might be nice.
We also don't have a method for dealing with Time, only dates. I know @markhibberd has a few misgivings about exposing time in expressions, so maybe this is best.

yeah, probably worth doing


Cannot install KingPhisher onto CentOS7

Issue Description
I've been trying to install KingPhisher onto a CentOS7 server, and it keeps failing on the "Synchronizing King Phisher's pipenv environment"
It delays on that step for a while, then returns with:
pipenv encountered the following error:
Installing dependencies from Pipfile.lock (49fa41)…
Installing initially failed dependencies…
ERROR    failed to install the pipenv environment
It then continues on, and tries to start KingPhisher service, but fails.
Reproduction Steps
Deploy basic CentOS7 server
Download install.sh and run (as root)
Environment Details

CentOS Linux release 7.6.1810 (Core)
King Phisher Version: Latest, as of today
Error Details / Stack Trace
INFO: Synchronizing King Phisher's pipenv environment
pipenv encountered the following error:
Installing dependencies from Pipfile.lock (49fa41)…
Installing initially failed dependencies…
ERROR    failed to install the pipenv environment
Loaded plugins: fastestmirror
Loading mirror speeds from cached hostfile

base: centos.mirror.serversaustralia.com.au
epel: d2lzkl7pfhq30w.cloudfront.net
extras: centos.mirror.serversaustralia.com.au
ius: syd.mirror.rackspace.com
updates: mirror.ventraip.net.au
Package postgresql-server-9.2.24-1.el7_5.x86_64 already installed and latest version
Nothing to do
Data directory is not empty!

INFO: Creating King Phisher admin group: 'king-phisher'
INFO: Configuring the PostgreSQL server
INFO: PostgreSQL configuration file found at /var/lib/pgsql/data/pg_hba.conf
INFO: Created the PostgreSQL user 'king_phisher' with a random password
INFO: Installing the King Phisher systemd service file in /lib/systemd/system/
INFO: Starting the King Phisher service
Created symlink from /etc/systemd/system/multi-user.target.wants/king-phisher.service to /usr/lib/systemd/system/king-phisher.service.
Job for king-phisher.service failed because a timeout was exceeded. See "systemctl status king-phisher.service" and "journalctl -xe" for details.
When running KingPhisher manually (/usr/bin/python3 /opt/king-phisher/KingPhisherServer /opt/king-phisher/server_config.yml)
Loading .env environment variables…
Traceback (most recent call last):
File "/usr/lib64/python3.5/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/usr/lib64/python3.5/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/opt/king-phisher/king_phisher/server/main.py", line 42, in
from king_phisher import color
File "/opt/king-phisher/king_phisher/color.py", line 41, in
import termcolor
ImportError: No module named 'termcolor'

King Phisher now utilizes pipenv to maintain packages and prevent issues with system level packages. You will need to change directories to King Phisher directory in this case /opt/king-phisher then run the server from there, please run in DEBUG mode and provide us the output to help you trouble shoot the issue.
Commands to change to King Phisher directory and run the server in debug mode.
cd /opt/king-phisher
sudo ./KingPhisherServer -L DEBUG -f ./server_config.yml

I am having issues starting KingPhisher, but i'm fairly sure it's related to it not installing correctly, and the pipenv.
I've manually created the /opt/king-phisher directory, run install.sh from there, but same issue.
I also tried cloning the repo into /opt/king-phisher and running install.sh from there too, and again, fails on "INFO: Synchronizing King Phisher's pipenv environment"  with:
pipenv encountered the following error:
Installing dependencies from Pipfile.lock (49fa41)…
Installing initially failed dependencies…
ERROR    failed to install the pipenv environment
When running KingPhisher server with the DEBUG switch i get:
DEBUG    target diretory: /opt/king-phisher
INFO     checking for the pipenv environment
DEBUG    pipenv path: '/usr/bin/pipenv'
DEBUG    pipenv Pipfile: /opt/king-phisher/Pipfile
Loading .env environment variables…
Traceback (most recent call last):
File "/usr/lib64/python3.5/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/usr/lib64/python3.5/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/opt/king-phisher/king_phisher/server/main.py", line 42, in
from king_phisher import color
File "/opt/king-phisher/king_phisher/color.py", line 41, in
import termcolor
ImportError: No module named 'termcolor'
Thanks

Just a quick update, i'm a noob with anything Python related, but i tried running "pipenv install" from the /opt/king-phisher directory and got the following:
Installing dependencies from Pipfile.lock (49fa41)…
An error occurred while installing pycairo==1.18.0 --hash=sha256:abd42a4c9c2069febb4c38fe74bfc4b4a9d3a89fea3bc2e4ba7baff7a20f783f! Will try again.
An error occurred while installing https://github.com/matplotlib/basemap/archive/v1.2.0rel.tar.gz#egg=basemap! Will try again.
An error occurred while installing python-dateutil==2.7.2 --hash=sha256:3220490fb9741e2342e1cf29a503394fdac874bc39568288717ee67047ff29df --hash=sha256:9d8074be4c993fbe4947878ce593052f71dac82932a677d49194d8ce9778002e! Will try again.
An error occurred while installing pynacl==1.3.0 --hash=sha256:05c26f93964373fc0abe332676cb6735f0ecad27711035b9472751faa8521255 --hash=sha256:0c6100edd16fefd1557da078c7a31e7b7d7a52ce39fdca2bec29d4f7b6e7600c --hash=sha256:0d0a8171a68edf51add1e73d2159c4bc19fc0718e79dec51166e940856c2f28e --hash=sha256:1c780712b206317a746ace34c209b8c29dbfd841dfbc02aa27f2084dd3db77ae --hash=sha256:2424c8b9f41aa65bbdbd7a64e73a7450ebb4aa9ddedc6a081e7afcc4c97f7621 --hash=sha256:2d23c04e8d709444220557ae48ed01f3f1086439f12dbf11976e849a4926db56 --hash=sha256:30f36a9c70450c7878053fa1344aca0145fd47d845270b43a7ee9192a051bf39 --hash=sha256:37aa336a317209f1bb099ad177fef0da45be36a2aa664507c5d72015f956c310 --hash=sha256:4943decfc5b905748f0756fdd99d4f9498d7064815c4cf3643820c9028b711d1 --hash=sha256:57ef38a65056e7800859e5ba9e6091053cd06e1038983016effaffe0efcd594a --hash=sha256:5bd61e9b44c543016ce1f6aef48606280e45f892a928ca7068fba30021e9b786 --hash=sha256:6482d3017a0c0327a49dddc8bd1074cc730d45db2ccb09c3bac1f8f32d1eb61b --hash=sha256:7d3ce02c0784b7cbcc771a2da6ea51f87e8716004512493a2b69016326301c3b --hash=sha256:a14e499c0f5955dcc3991f785f3f8e2130ed504fa3a7f44009ff458ad6bdd17f --hash=sha256:a39f54ccbcd2757d1d63b0ec00a00980c0b382c62865b61a505163943624ab20 --hash=sha256:aabb0c5232910a20eec8563503c153a8e78bbf5459490c49ab31f6adf3f3a415 --hash=sha256:bd4ecb473a96ad0f90c20acba4f0bf0df91a4e03a1f4dd6a4bdc9ca75aa3a715 --hash=sha256:e2da3c13307eac601f3de04887624939aca8ee3c9488a0bb0eca4fb9401fc6b1 --hash=sha256:f67814c38162f4deb31f68d590771a29d5ae3b1bd64b75cf232308e5c74777e0! Will try again.
An error occurred while installing tzlocal==1.5.1 --hash=sha256:4ebeb848845ac898da6519b9b31879cf13b6626f7184c496037b818e238f2c4e! Will try again.
An error occurred while installing graphene-sqlalchemy==2.1.0 --hash=sha256:5bfc93986c5e6001861e8cdfe33eeb5094ca1f30efde6822387e13070ec3ab82 --hash=sha256:8260a128f360eda5437147a3cb72809e267fa8e2464f9996ff95ddc47239dcec! Will try again.
An error occurred while installing promise==2.2.1 --hash=sha256:2ebbfc10b7abf6354403ed785fe4f04b9dfd421eb1a474ac8d187022228332af --hash=sha256:348f5f6c3edd4fd47c9cd65aed03ac1b31136d375aa63871a57d3e444c85655c! Will try again.
An error occurred while installing geoip2==2.9.0 --hash=sha256:a37ddac2d200ffb97c736da8b8ba9d5d8dc47da6ec0f162a461b681ecac53a14 --hash=sha256:f7ffe9d258e71a42cf622ce6350d976de1d0312b9f2fbce3975c7d838b57ecf0! Will try again.
An error occurred while installing cycler==0.10.0 --hash=sha256:1d8a5ae1ff6c5cf9b93e8811e581232ad8920aeec647c37316ceac982b08cb2d --hash=sha256:cd7b2d1018258d7247a71425e9f26463dfb444d411c39569972f4ce586b0c9d8! Will try again.
An error occurred while installing graphene==2.1.3 --hash=sha256:b8ec446d17fa68721636eaad3d6adc1a378cb6323e219814c8f98c9928fc9642 --hash=sha256:faa26573b598b22ffd274e2fd7a4c52efa405dcca96e01a62239482246248aa3! Will try again.
An error occurred while installing paramiko==2.4.2 --hash=sha256:3c16b2bfb4c0d810b24c40155dbfd113c0521e7e6ee593d704e84b4c658a1f3b --hash=sha256:a8975a7df3560c9f1e2b43dc54ebd40fd00a7017392ca5445ce7df409f900fcb! Will try again.
An error occurred while installing alembic==1.0.2 --hash=sha256:04bcb970ca8659c3607ddd8ffd86cc9d6a99661c9bc590955e8813c66bfa582b! Will try again.
An error occurred while installing graphql-relay==0.4.5 --hash=sha256:2716b7245d97091af21abf096fabafac576905096d21ba7118fba722596f65db! Will try again.
An error occurred while installing pygobject==3.28.3 --hash=sha256:250fb669b6ac64eba034cc4404fcbcc993717b1f77c29dff29f8c9202da20d55! Will try again.
An error occurred while installing graphql-core==2.1 --hash=sha256:889e869be5574d02af77baf1f30b5db9ca2959f1c9f5be7b2863ead5a3ec6181 --hash=sha256:9462e22e32c7f03b667373ec0a84d95fba10e8ce2ead08f29fbddc63b671b0c1! Will try again.
An error occurred while installing icalendar==4.0.3 --hash=sha256:07c2447a1d44cbb27c90b8c6a5c98e890cc1853c6223e2a52195cddec26c6356 --hash=sha256:83f7248b7485ddd29c7d69b706b21c441e34855d9c1d888939fd24aefdd9d19b! Will try again.
🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 66/66 — 00:01:56
Installing initially failed dependencies…
☤  ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 16/16 — 00:00:58
[pipenv.exceptions.InstallError]:   File "/usr/lib/python3.5/site-packages/pipenv/cli/command.py", line 254, in install
[pipenv.exceptions.InstallError]:       editable_packages=state.installstate.editables,
[pipenv.exceptions.InstallError]:   File "/usr/lib/python3.5/site-packages/pipenv/core.py", line 1874, in do_install
[pipenv.exceptions.InstallError]:       keep_outdated=keep_outdated
[pipenv.exceptions.InstallError]:   File "/usr/lib/python3.5/site-packages/pipenv/core.py", line 1253, in do_init
[pipenv.exceptions.InstallError]:       pypi_mirror=pypi_mirror,
[pipenv.exceptions.InstallError]:   File "/usr/lib/python3.5/site-packages/pipenv/core.py", line 862, in do_install_dependencies
[pipenv.exceptions.InstallError]:       _cleanup_procs(procs, False, failed_deps_queue, retry=False)
[pipenv.exceptions.InstallError]:   File "/usr/lib/python3.5/site-packages/pipenv/core.py", line 681, in _cleanup_procs
[pipenv.exceptions.InstallError]:       raise exceptions.InstallError(c.dep.name, extra=err_lines)
So, is it failing to find/install some of the dependencies?  Cheers

Just for my own sanity, i just spun up a Ubuntu 18.10 box, and was able to install KingPhisher fine, just by running ./install.sh.
So CentOS specific it seems.

I ran into similar issues with this while trying to install on a Debian server, but starting from scratch fixed the problem for me. As far as I could tell, it was because of something wrong with my environment, specifically pip or possibly python itself, which is strange but not impossible. Just to clarify, I've installed king-phisher on Fedora, Ubuntu, Debian, Kali, and Arch without issues, but once in a blue moon, it seems like something with Pip goes haywire and throws a wrench in the gears. Sometimes it's because of permission issues, sometimes it's a complete mystery.  ¯_(ツ)_/¯
Start by blowing away the /opt/king-phisher directory completely, and install the essentials from yum (or DNF is that's what CentOS is using these days).
yum install python3 python3-dev python3-pip
Verify your Python version by doing python3 --version
My current version is Python 3.7.2 but latest stable of Python 3.4.x should be fine. Whatever the case, just make sure you're on the latest stable version.
Verify your pip version by doing pip3 -V
Latest stable is 19.0.1 at the time of this issue.
At this point, I recommend you sudo to root and perform everything as the root user from here forward. This will make pip install everything globally and should make everything available for all users.
git clone https://github.com/securestate/king-phisher /opt/king-phisher
cd /opt/king-phisher/tools
chmod +x ./install.sh
./install.sh

If you still get errors related to the hashes or install process, print the output of pipenv install --verbose from /opt/king-phisher. Again, make sure you're installing as root.

Hey, thanks for your help.
So python3 isn't installed in CentOS7 by default, so i did the following:
yum install -y https://centos7.iuscommunity.org/ius-release.rpm
yum install gcc openssl-devel bzip2-devel
yum install epel-release
yum install python36
python3.6 -m ensurepip
ln -s /usr/bin/python3.6 /usr/bin/python3
ln -s /usr/local/bin/pip3 /usr/bin/pip3

[root@template_kp_v1 ~]# python3 -V
Python 3.6.6
[root@template_kp_v1 ~]# pip3 -V
pip 10.0.1 from /usr/local/lib/python3.6/site-packages/pip (python 3.6)

I then ran the installer exactly as you suggested (as root) and it failed again on the pipenv.  When i ran
./KingPhisher --env-install -L DEBUG
I got
DEBUG    target diretory: /opt/king-phisher INFO     checking for the pipenv environment DEBUG    pipenv path: '/usr/local/bin/pipenv' INFO     installing the pipenv environment pipenv encountered the following error: Installing dependencies from Pipfile.lock (49fa41)… Installing initially failed dependencies… ERROR    failed to install the pipenv environment INFO     removing the incomplete .venv directory
I then ran pipenv install --verbose from /opt/king-phisher and got the attached (lot of output.)
pipenv_install.log
I then reverted my VM, and stepped through the install.sh for CentOS7, installing the same version of python (3.5) and all the dependencies, and again it fails when running ./KingPhisher --env-install
Cheers

thank you for the information, it looks like a package is missing for basemaps that needs to be installed through the package manager. I'll need to kick it around some more to narrow down the missing packages

Thanks, happy todo more testing my end too if it helps.

Looks like libgeos, except the naming convention doesn't match in yum/dnf as it does in apt like the error suggests.
yum/dnf install geos geos-devel appears to resolve the dependency issue on Fedora. Should be the same for CentOS. Might be a necessary pre-requisite for RPM distros if it's not included in the basemap tarball that's pulled with the install.sh script.

Hi, cheers for that.  I did a clean build again, and the  manually installed geos and geos-devel by using:
yum install geos geos-devel
Now when running:
pipenv install --verbose
It seems to go further, but failing on cairo
` .......
running install
running build
running build_py
creating build
creating build/lib.linux-x86_64-3.6
creating build/lib.linux-x86_64-3.6/cairo
copying cairo/init.py -> build/lib.linux-x86_64-3.6/cairo
copying cairo/init.pyi -> build/lib.linux-x86_64-3.6/cairo
copying cairo/py.typed -> build/lib.linux-x86_64-3.6/cairo
warning: build_py: byte-compiling is disabled, skipping.
running build_ext
Package cairo was not found in the pkg-config search path.
Perhaps you should add the directory containing `cairo.pc'
to the PKG_CONFIG_PATH environment variable
No package 'cairo' found
Command '['pkg-config', '--print-errors', '--exists', 'cairo >= 1.13.1']' returned non-zero exit status 1.
Running setup.py install for pycairo: finished with status 'error'

Cleaning up...
Removing source in /tmp/pip-install-d5md_5m6/pycairo
Removed build tracker '/tmp/pip-req-tracker-zje42ax3'
Exception information:
Traceback (most recent call last):
File "/opt/king-phisher/.venv/lib/python3.6/site-packages/pip/_internal/cli/base_command.py", line 179, in main
status = self.run(options, args)
File "/opt/king-phisher/.venv/lib/python3.6/site-packages/pip/_internal/commands/install.py", line 393, in run
use_user_site=options.use_user_site,
File "/opt/king-phisher/.venv/lib/python3.6/site-packages/pip/_internal/req/init.py", line 57, in install_given_reqs
**kwargs
File "/opt/king-phisher/.venv/lib/python3.6/site-packages/pip/_internal/req/req_install.py", line 945, in install
spinner=spinner,
File "/opt/king-phisher/.venv/lib/python3.6/site-packages/pip/_internal/utils/misc.py", line 761, in call_subprocess
% (command_desc, proc.returncode, cwd))
pip._internal.exceptions.InstallationError: Command "/opt/king-phisher/.venv/bin/python3 -u -c "import setuptools, tokenize;file='/tmp/pip-install-d5md_5m6/pycairo/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /tmp/pip-record-6epk7ozi/install-record.txt --single-version-externally-managed --compile --install-headers /opt/king-phisher/.venv/include/site/python3.6/pycairo" failed with error code 1 in /tmp/pip-install-d5md_5m6/pycairo/
Traceback (most recent call last):
File "/usr/local/bin/pipenv", line 10, in
sys.exit(cli())
File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 764, in call
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/decorators.py", line 64, in new_func
return ctx.invoke(f, obj, *args, **kwargs)
File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/decorators.py", line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File "/usr/local/lib/python3.6/site-packages/pipenv/cli/command.py", line 254, in install
editable_packages=state.installstate.editables,
File "/usr/local/lib/python3.6/site-packages/pipenv/core.py", line 1874, in do_install
keep_outdated=keep_outdated
File "/usr/local/lib/python3.6/site-packages/pipenv/core.py", line 1253, in do_init
pypi_mirror=pypi_mirror,
File "/usr/local/lib/python3.6/site-packages/pipenv/core.py", line 862, in do_install_dependencies
_cleanup_procs(procs, False, failed_deps_queue, retry=False)
File "/usr/local/lib/python3.6/site-packages/pipenv/core.py", line 681, in _cleanup_procs
raise exceptions.InstallError(c.dep.name, extra=err_lines)
pipenv.exceptions.InstallError: ERROR: ERROR: Package installation failed...`

Odd that it would fail on that dependency...
You should try to rerun the king-phisher tools/install.sh script, since that should resolve any remaining dependencies, and your earlier problem of the basemap dependency is solved.
For good measure / curiosity's sake, can you run
pip freeze | grep -i cairo to verify whether it's installed and what version it's at.
Assuming it's not installed or behind it's version, you can try installing it manually.
Global Install: sudo pip install pycairo
User-only Install: pip install pycairo --user
Upgrade: sudo pip install -U pycairo
Either way, if you absolutely need to, you can always install each dependency that is mentioned in the Piplock file after a failed installation attempt. Pipenv will always default to using the locally installed version of whatever dependencies are needed, assuming they aren't pinned to a specific version and the local version exceeds the minimum required version.
Let us know how it progresses.

Hi folks.
OK, i've tried a few things, including install a few dependencies manually
yum install -y cairo cairo-devel geos geos-devel
And have managed to get to state where
./KingPhisher --env-install -L DEBUG
completes without any errors and also
pipenv install --verbose
completes successfully too, but when i try running ./install.sh it fails again on :
INFO: Synchronizing King Phisher's pipenv environment pipenv encountered the following error: Installing dependencies from Pipfile.lock (49fa41)… Installing initially failed dependencies… ERROR    failed to install the pipenv environment
And if i try starting the service manually, it seems to fail on various options.
I might have to just give up installing on CentOS, as it looks like it's just gonna work.
Cheers

This issue has been resolved in commit 20ca83a25fa0c40423c60bdb60be508e8a7308be . This is currently in the dev branch. If you would like to get into beta testing King Phisher the instructions are located at https://github.com/securestate/king-phisher/wiki/Updating-King-Phisher#beta-testing .
This issue was due to cairo-devel, gobject-instrospection-devel, cairo-gobject and cairo-gobject-devel not being installed for required packages pipenv was installing.


[$250] [Held requests]  owes -0.00 displayed in LHN preview after partially approving report

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
precondition: user is a member of a collect workspace with a set approver

Log in as a member on secondary device
Open the workspace chat and submit 2 expenses
Submit the report
On the primary device log in as an approver
Open the workspace chat
Select the submitted report
Put on hold an expense
Partially approve the report
Wait until the held expense gets moved to a new report
Navigate to the LHN

Expected Result:
The correct amount that workspace owes is displayed in the LHN preview
Actual Result:
 owes -$0.00 until the workspace chat is opened again
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/edef81b7-ecb8-4ecf-b22d-b8d46e5a6475
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01536daf4c62d44622
Upwork Job ID:<PHONE_NUMBER>894730679
Last Price Increase: 2024-06-17

Issue OwnerCurrent Issue Owner: @robertjchen

@garrettmknight  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@robertjchen is this expected as part of the rollout? https://github.com/Expensify/Expensify/issues/274076

It's a bug with partial pay- we're working on this one here: https://github.com/Expensify/App/issues/41652

@garrettmknight Should we hold/close this issue in favor of https://github.com/Expensify/App/issues/43689#issuecomment-2175801300 issue?

I think we can keep it open for now and re-test after the fixes are done there.

Still holding

Still holding on https://github.com/Expensify/App/issues/41652

Still holding on https://github.com/Expensify/App/issues/41652

Still holding on https://github.com/Expensify/App/issues/41652

Still holding on https://github.com/Expensify/App/issues/41652

@mallenexpensify can you keep an eye on this one next week while I'm OOO? Once https://github.com/Expensify/App/issues/41652 is done we can expect this to be off hold. I'll pick back up when I get back. 🤝

The PR we're held on hit staging 16 hours ago https://github.com/Expensify/App/pull/42573#issuecomment-2252008241

@robertjchen After approving the partial payment, I can see <WS> owes -0.00 for a second before it shows the correct value that the workspace owes.
Here's a clearer breakdown of the flow:

LHN Preview shows WS owes ₹1345.01
Approved ₹340.00
LHN shows WS owes $12.00
LHN shows WS owes ₹0.00
LHN shows WS owes ₹1005.01

https://github.com/user-attachments/assets/0ebaa701-09e8-412a-922d-2e0092a7b7ce
Sidenote: The same values are reflected in the IOU Preview in the report.

@jayeshmangwani the PR we were holding on hit production yesterday and your comment was 11 hours ago so I'm assuming you were on the latest version of production, comment if now.
Let's see what Bobby Bottles has to say

Weird, commented but it didn't remove the Overdue label

your comment was 11 hours ago so I'm assuming you were on the latest version of production

Yes, I've tested in the latest version

Thanks for the latest tests- some discussion going on Slack as well as to the source of the 0.00. It appears to be coming from the backend- investigating further.

@robertjchen Do you want to take this one on?

yep, I can take this one given that it's related to the other linked one that we're investigating.

@robertjchen Should we make this Issue a weekly?

This is on the BE- it seems like the core issue is that OpenReport may not be not returning the total that incorporates the hold expenses.

A potential BE fix was deployed, let's re-test this!

Still reproducible- potential other cause, investigating.
https://github.com/user-attachments/assets/6e241147-171b-497c-b8bc-f54142b93b17

Still working on potential fix locally, it's a hairy one!

I fixed it!! 🎉 Going to get the changes reviewed and deployed
https://github.com/user-attachments/assets/3893aa73-a208-423e-842b-5007c2b8cf99

PR under review

Auth change deployed!


Fix sonar plugin

Hey, I just made a Pull Request!
useTheme() imported from @material-ui/styles returns null. This change gets the sonar plugin working. Other plugins seem to be importing from @material-ui/core, e.g. the catalog
I'm using the latest versions of everything.
Before the change I see this error in the UI:

And this trace in the console:
The above error occurred in the <Percentage> component:
    in Percentage (created by SonarQubeCard)
    in div (created by ForwardRef(Grid))
    in ForwardRef(Grid) (created by WithStyles(ForwardRef(Grid)))
    in WithStyles(ForwardRef(Grid)) (created by RatingCard)
    in div (created by ForwardRef(Grid))
    in ForwardRef(Grid) (created by WithStyles(ForwardRef(Grid)))
    in WithStyles(ForwardRef(Grid)) (created by RatingCard)
    in div (created by ForwardRef(Grid))
    in ForwardRef(Grid) (created by WithStyles(ForwardRef(Grid)))
    in WithStyles(ForwardRef(Grid)) (created by RatingCard)
    in a (created by ForwardRef(Typography))
    in ForwardRef(Typography) (created by WithStyles(ForwardRef(Typography)))
    in WithStyles(ForwardRef(Typography)) (created by ForwardRef(Link))
    in ForwardRef(Link) (created by WithStyles(ForwardRef(Link)))
    in WithStyles(ForwardRef(Link)) (created by RatingCard)
    in RatingCard (created by SonarQubeCard)
    in div (created by ForwardRef(Grid))
    in ForwardRef(Grid) (created by WithStyles(ForwardRef(Grid)))
    in WithStyles(ForwardRef(Grid)) (created by SonarQubeCard)
    in div (created by ForwardRef(Grid))
    in ForwardRef(Grid) (created by WithStyles(ForwardRef(Grid)))
    in WithStyles(ForwardRef(Grid)) (created by SonarQubeCard)
    in div (created by ForwardRef(CardContent))
    in ForwardRef(CardContent) (created by WithStyles(ForwardRef(CardContent)))
    in WithStyles(ForwardRef(CardContent)) (created by InfoCard)
    in ErrorBoundary2 (created by InfoCard)
    in div (created by ForwardRef(Paper))
    in ForwardRef(Paper) (created by WithStyles(ForwardRef(Paper)))
    in WithStyles(ForwardRef(Paper)) (created by ForwardRef(Card))
    in ForwardRef(Card) (created by WithStyles(ForwardRef(Card)))
    in WithStyles(ForwardRef(Card)) (created by InfoCard)
    in InfoCard (created by SonarQubeCard)
    in SonarQubeCard (at EntityPage.tsx:67)
    in div (created by ForwardRef(Grid))
    in ForwardRef(Grid) (created by WithStyles(ForwardRef(Grid)))
    in WithStyles(ForwardRef(Grid)) (at EntityPage.tsx:66)
    in div (created by ForwardRef(Grid))
    in ForwardRef(Grid) (created by WithStyles(ForwardRef(Grid)))
    in WithStyles(ForwardRef(Grid)) (at EntityPage.tsx:62)
    in OverviewContent (at EntityPage.tsx:113)
    in article (created by Content)
    in Content (created by Layout)
    in Layout (created by EntityPageLayout)
    in div (created by Page)
    in ThemeProvider (created by Page)
    in Page (created by EntityPageLayout)
    in EntityPageLayout (at EntityPage.tsx:109)
    in WebsiteEntityPage (at EntityPage.tsx:148)
    in ComponentEntityPage (at EntityPage.tsx:198)
    in EntityPage (created by EntityPageSwitch)
    in EntityPageSwitch (created by Router)
    in EntityLoaderProvider (created by Router)
    in Route (created by Router)
    in Routes (created by Router)
    in Router (at App.tsx:58)
    in Route (at App.tsx:56)
    in FlatRoutes (at App.tsx:54)
    in div (created by SidebarPage)
    in SidebarPage (at App.tsx:52)
    in Route (created by AppRouter)
    in Routes (created by AppRouter)
    in Router (created by BrowserRouter)
    in BrowserRouter (created by AppRouter)
    in AppRouter (at App.tsx:51)
    in RoutingProvider (created by Provider)
    in CssBaseline (created by WithStyles(CssBaseline))
    in WithStyles(CssBaseline) (created by AppThemeProvider)
    in ThemeProvider (created by AppThemeProvider)
    in AppThemeProvider (created by Provider)
    in AppContextProvider (created by Provider)
    in ApiProvider (created by Provider)
    in Provider (at App.tsx:48)
    in App (at src/index.tsx:6)

After the change I see the SonarQube card as expected:

Tugboat has finished building the preview for this pull request!
Link:

https://pr4551-weppfoohwkiw0jkl7fv99xq9n0aasllh.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/602bfb0bfcb22d64ee56ef00

Tugboat has finished building the preview for this pull request!
Link:

https://pr4551-weppfoohwkiw0jkl7fv99xq9n0aasllh.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/602bfb0bfcb22d64ee56ef00


Fix duplicated code in cluster builder

What this PR does / why we need it:
Fix duplicated code in cluster builder. In s3_context.py and minio_context.py, defined args but does not use that, and the push option does not work. The PR is going to fix that, remove duplicated code.

This change is

/assign @abhi-g
Could you please take a look? Thanks.

/lgtm
/approve


EFT correction

i overlooked a set of arrays, because the file i used for testing didn't have them. this set contains 2 floats per array. i also changed the sample, so a file name can be typed into the console.

corrected my mistake in the sequence class, and used the common vector types as requested.


[Request]

not a bug but it would be really great if there could be an auto refresh on the warnings,
i mean i use this mod mainly to locate empty mines right now, and i have to clear then search again the empty mine warning because even with the miners removed, the locator still indicate the location..
thanks for your great work :)

as i was trying the fix you made, i went for a round of cleaning my empty miners and it seems that what you did for this enhancement is working as well as the warning were being removed as i removed the miners
thanks again
PS i leave the closing of this case to you as i don't know if you re still working on it


Can't create non-trainable keras variables

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version (use command below):
Python version:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

You can collect some of this information using our environment capture script
You can also obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
tf.GIT_VERSION, tf.VERSION == v1.13.1-0-g6612da8951, 1.13.1
Describe the current behavior
You should be able to specify K.variable(..., trainable=False) to create a non-trainable variable. Currently, I'm having to do:
import tensorflow.keras.backend as K

variable = K.variable(5)
variable._trainable = False
...

But this doesn't seem like a proper/safe way to do this.
Describe the expected behavior
variable = K.variable(5, trainable=False)

Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

Please fill the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks!

Closing due to lack of recent activity. Please update the issue when new information becomes available, and we will open a new issue. Thanks!


Problem flashing C.H.I.P. pro

Hi, I am trying to use your meta layer in order to build a chip pro release...
When I try to flash my image to the board (dev kit 1.0) I have the following error:
BUILDROOT_OUTPUT_DIR = ..
== preparing images ==
PADDED_SPL_SIZE=0x000000c4
0+1 records in
1+0 records out
4194304 bytes (4,2 MB, 4,0 MiB) copied, 0,00673643 s, 623 MB/s
UBOOT_SIZE=0x00400000
PADDED_UBOOT_SIZE=0x400000
0+0 records in
0+0 records out
0 bytes copied, 0,000147694 s, 0,0 kB/s
echo Configuring Video Mode
reset
Image Name:   flash CHIP
Created:      Wed Mar 29 17:45:27 2017
Image Type:   ARM Linux Script (uncompressed)
Data Size:    1022 Bytes = 1.00 kB = 0.00 MB
Load Address: 00000000
Entry Point:  00000000
Contents:
Image 0: 1014 Bytes = 0.99 kB = 0.00 MB
== upload the SPL to SRAM and execute it ==
waiting for fel.............OK
== upload spl ==
== upload u-boot ==
== upload u-boot script ==
== upload ubi ==
100% [============================================================]
== execute the main u-boot binary ==
== write ubi ==
flashing.......................................................................................................TIMEOUT
ERROR: could not flash:
Any help will be appreciated.
Stefano.

Hi @JubaHub
Thanks for this report, I ave just received my CHIP pro dev kit, but not yet tried to load it.
I will try to check this issue soon, but if you find any solution before, thanks for sharing :-)
Joel

Support of C.H.I.P. PRO finally added after few months not available to work on this subject :-) The examples of my meta layer https://github.com/myfreescalewebpage/meta-chip-examples have also been updated and all are working with both C.H.I.P. and C.H.I.P. PRO boards.
@junahub, you can test it, if not too late for you of course :-)
Closing the issue.

Hi, unfortunately I am not using the CHI Pro right now.
I hope to start working again on that but not in the next month.
I worked with @texierp on this layer https://github.com/texierp/meta-chip .
It could be a good comparison point.
Thank you for your effort,
Stefano.

I have tried texiep meta-layer too, but not successfully build here.
However, in any case, we have not the same philosophy, that's good to see different solutions :-)
Joel

Hi @myfreescalewebpage,
Thanks for your feeback :)
Which branch did you test for your build ?
Thanks
PJ
PS: great job for your layers ;)

Hi @texierp
Used repo as described in your readme so branches selected by the default.xml file.
Thanks, what was motivating is the $!!$/*$** scripts and setup provided by NTC to load the boards. I prefer not to "hide" this kind of parts to the developers, I think they must be clear (a reason for which I'm not using repo also!)
I'm currently working on the integration of xenomai based on my layer :-) A little bit hard because nobody seems to have port xenomai on this arch... (sun4i).
Joel