Create LayoutComponent classes

Proposal
LayoutComponent will be the base class for a family of utility classes which handle the layout of their children. This would be quite similar to Flutter layout widgets such as Align, Column, Center, Container, Padding, SizedBox, etc.
The purpose of these new components is to assist with constructing UIs within a game: dialogue boxes, HUD, informational screens, in-game UIs such as dialogue or trade windows, etc.
PR #1971 already attempts to add two such layout classes: Row and Column -- this proposal is to have more of them, all under a single umbrella of LayoutComponent.
For example, suppose you're making a game and you want to display current score in the top right corner. Then, you should be able to declare it like this:
camera.viewport.add(
  Padding(
    padding: EdgeInsets.all(20),
    children: [
      Align(
        anchor: Anchor.topRight,
        child: ScoreComponent(),
      ),
    ],
  ),
);

After this, the game would take care to properly position the ScoreComponent and move it whenever the game resizes.
Implementation
LayoutComponent would rely on the onParentResize lifecycle method (#1421).
The tree structure can be either normal (the target is added as a child of the LayoutComponent), or flat (the target is added to the parent directly, and layout component is a sibling). I'm not sure which option is better here.

Sounds good! Should we close #1971 then?

Should we close https://github.com/flame-engine/flame/pull/1971 then?

We'll add the new layout classes, and then #1971 could use this new interface to implement the Row and Column.


Polygon boundary support

#Render particles only inside polygon, bounce inside polygon.
The following options were added:
polygon: {
    debug: true,
    type: 'inside',
    url: '/demo/svg/star.svg',
    raw: null
}

If url to the SVG (on server) and type are specified, only particles (and lines between them) that are inside generated polygon are rendered. This is concept work and will sure need optimization and better integration into particles.js library.
Does anyone have an idea on how to center the polygon so that the detection works?
Demo can be seen here.
Edit: Sorry for the typo in commit message, i have huge fingers.

I've now realized this needs way much more work than i thought. Closing.


Standard User role changes for clustertemplates resource

As a standard user, one should be able to create clustertemplates and clustertemplaterevisions
https://github.com/rancher/rancher/issues/21067

LGTM


unable to install from the binaries

on linux 18.04, I get the following error when following the installation instruction (https://ignitionrobotics.org/docs/acropolis/install#option-1-installation-on-ubuntu-bionic)
Unpacking ignition-gazebo (1.1.0-1~bionic) ... dpkg: error processing archive /tmp/apt-dpkg-install-uGiRNL/338-ignition-gazebo_1.1.0-1~bionic_amd64.deb (--unpack):  trying to overwrite '/usr/bin/ign-gazebo', which is also in package ignition-gazebo2 2.20.1-1~bionic
I tried it on two different computers and I get the same result. any fix to this issue?

Note that, as stated in the top of the page:

Acropolis has reached end-of-life on September 2019. This page exists for archival purposes. Please refer to the latest supported version.

To have the most recent install version of ignition-gazebo, you can follow the instructions at:
https://ignitionrobotics.org/docs/citadel/install_ubuntu
However, Ignition Citadel will install Ignition Gazebo 3, while it seems that you already have ignition-gazebo2 installed, so perhaps you already installed the ignition blueprint release  that contained ignition-gazebo2. If you do not need it anymore, you can uninstall it with the  following  command:
sudo apt remove ignition-gazebo2

Then it seems like a bad link/documentation. I went to the Ignition robotics website, then doc -> get started -> the latest install tutorial.

I'll close this in favour of https://github.com/ignitionrobotics/docs/issues/4


added latest code max_sum rectangle

Have you read the Contributing Guidelines on Pull Requests?
yes
Description
added the code for maximum sum rectangle
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#937

Please check the latest changes done as per the  changes requested @iamrajiv  and @Kajol-Kumari
let me know if any changes

done @iamrajiv

@plazzy99  done the changes as per told ,please check


[Reveal] Reveal doesn't work on iOS Safari

How can we reproduce this bug?

Open http://foundation.zurb.com/sites/docs/reveal.html on iPad Safari
Try fullscreen example http://foundation.zurb.com/sites/docs/reveal.html#full-screen
Try to scroll when you have open fullscreen modal window

What did you expect to happen?
I expect that I will be scrolling only inside modal window.
What happened instead?
I scroll with content behind and modal window disappear.
How to solve it
I've found that solution can be adding overflow: hidden; to <html> tag when you open modal window. And remove this property when you close modal window.

Duplicate of #7548


wagtail admin slow to load on site with lots of pages with fine grained permissions (explorable_pages() issue?)

Issue Summary
I have a site with around 4000 pages which is using fine grained permissions on around 400 of those pages. For some users accessing the /admin/ page the page loads in a second or so. For others the page can take around 5 minutes to load.
Profiling and debugging into the code seems to show that the area of concern is the wagtail\core\models.py explorable_pages() function, in particular the
page_permissions = Page.objects.filter(group_permissions__in=self.permissions)
line. This seems to return, for my data at least, over 2000 results with each result repeated 6 or 7 times (returning a result for each permission type?). There are only around 400 distinct results.
Adding a distinct() improves matters
page_permissions = Page.objects.filter(group_permissions__in=self.permissions).distinct()
getting the number down to around 400. My page loads are now around 90 seconds - not ideal but better.
Related to https://github.com/wagtail/wagtail/pull/5069
Steps to Reproduce

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: no

Technical details

Python version: 3.7.9
Django version: 3.1.3
Wagtail version: 2.11.2
Browser version: n/a

I doubt that Page.objects.filter(group_permissions__in=self.permissions) is the right thing to do for Wagtail.
Both group_permissions and self.permissions are multiple values. Like stated, SQL duplicates Page entries if the __in condition.
When calling distinct, the set of pages is filtered down to one page. But if the filter evaluates true or false is not deterministic. Querysets are unordered, and distinct probably gives the first item.
We probably need to do something with through to not get Page duplicates: Page.group_permissions.through.objects
Also wagtail/core/models.py:3102
        page_permissions = Page.objects.filter(group_permissions__in=self.permissions)
        for page in page_permissions:
            explorable_pages |= page.get_ancestors()```

Using `get_ancestors` in a for loop gives N+1 queries.

Yes, its the N+1 queries in
for page in page_permissions:
    explorable_pages |= page.get_ancestors()

that is taking all the time - made worse by iterating over 7 times as many pages as it needs to.
With Django debug on I can't see any SQL being generated by the get_ancestors() call but I may be looking at the wrong level or could it be the the Django ORM is doing this internally and there will be no SQL logged?
(As you may be able to guess I am no expert on Wagtail or Django)

I'm not so sure that the repeated calls to page.get_ancestors would be generating N+1 queries - Django is generally pretty good at deferring querying to the last possible moment, and in this case I think it would end as a large number of subqueries or WHERE clauses in the final query.
Either way, I think there's plenty of room to optimise this - I think the best strategy would be to fetch the path strings corresponding to the pages in self.permissions and do as much as we can through string manipulation before going back to the database.
It does seem a bit of an extreme case to have one user with 400+ distinct permission records applying to them - permission rules propagate down the page tree, so it would normally be sufficient to have a few permission records near the top level of the tree (maybe a few tens at most) which then grant permission for everything within those subtrees. Even so, I'm surprised the performance falls off a cliff so quickly with larger permission sets...

That makes sense. I think in my case this is legacy and there has been some restructuring of the site. Removing the large number of per page group permissions and setting a single page higher up in the hierarchy has sorted the issue. So, although the code could be improved and made faster it is not going to be an issue on any well structured site.

This may have been fixed (or at least much improved) by #10562. Would be nice if we could get some reports for large sites so we can find out the impact!


Allow ignoring unknown keys in RPC responses by set env

Closes #1305

Remove hardcoded unknown=EXCLUDE from deserializing in FullNodeClient
Allow ignoring unknown keys in RPC responses by set env

I had to leave some unknown=EXCLUDE because devnet sometimes returns more fields than starknet-spec claim should be sent
Introduced changes

[ ] This PR contains breaking changes

Rest of unknown="EXCLUDE" I will remove after merging RPC 0.7.0 development

Could we add some unit tests by setting a temporary environment variable?

It's problematic because we need to keep broken schema in our code to test it

This PR should be updated with apropriate docs section that will explain this feature and give some examples.
Any idea about an example, IMO the description how to set it seems to be clear

This PR should be updated with apropriate docs section that will explain this feature and give some examples.

Any idea about an example, IMO the description how to set it seems to be clear

The description you've provided should be enough


Fix CMake REGEX path variable from PR #3179

📒 Description

Fix CMake error Error:string sub-command REGEX, mode REPLACE needs at least 6 arguments total to command when building. It happens probably at some environments like archlinux AUR makepkg fakeroot. Add quotes to CMakeLists.txt to not lost the path argument.
🕶 Types of changes

Bug fix (non-breaking change which fixes an issue)

🤯 List of changes

CMakeLists.txt
👫 Relationships

PR #3179

🔎 Review hints

Hmm, sorry for causing you trouble. I assume this is not the complete fix thought, it'll at least alleviate the issue when running cmake.
With your fix, does the app show the right (that is, not 7.0.0 or an empty string) version in the About dialog?

Thank you for the fast reply @MartinBriza!
Hmm, you're right, I'm getting 7.0.0 currently :thinking: Will look for solution later, feel free to close my PR if I'm freezing with it :)

No, the PR is perfectly fine and it actually solves an issue for you, so I'm merging it. :) Thank you!
The issue with the version string for you is a different one - I assume the build is being run from a directory that's not a git repository, so it's impossible to determine what version you're currently building.

Got it, thanks! :) Looked at CMakeFiles.txt version string: I could probably ask package maintainer to pass something like -DTOGGL_VERSION:STRING="${pkgver}" as cmake argument during building here so it won't be a problem in my case

Oh yeah, definitely, that would solve the issue in a much clearer way.
Also, while you're pinging him, you can tell him I fixed the crash he mentioned in the AUR comments ( #3136 ) :)


Add secure etcd communication

This PR adds etcd certificates and configuration for secure communication with apiserver and backup sidecar. It is disabled by default for now.

go away stale bot

@databus23 I rebased this on current master, looks good afaik.

CA and cert generation has been moved to separate PRs #502 #515

@databus23 I removed all peer settings from deployment. Please have a look.

@BugRoger good to go from my side. from your end as well?

LGTM


Stuck at Building dataloader & Testing

When trying to train, it stucks at 'Building data loader' stage.
In addition, when Testing, stops at 34% of validation

I guess I had to wait more


error in train my dataset

i have this error when i train my dataset
if name == 'main':
freeze_support()
...
The "freeze_support()" line can be omitted if the program
is not going to be frozen to produce an executable.

Can you share me your dataset format
Check its in the COCO YOLO format

I think its the issue with your data.yaml
Checkout my data.yaml file: _**https://github.com/naseemap47/YOLO-NAS/blob/master/data.yaml**_

I also have this problem too , my format is yolo
This is my screen image

Can you share your repository or data, So that I can check what is the issue.

I think the issue with windows path format,
In Linux or Mac its look like: /home/path
But in Windows, its look like: \User\Downloads
I didn't face issue, I think its due to my OS is Ubuntu

@oussaifi-majdi @Andrewhsin
Try with google colab, it will work.

I copy this code on my file , it’s work!
if name == 'main':
# train code

Thank you @Andrewhsin for using my repository and solving this issue.
If you have any feedback let me know.
Hope problem solved for @oussaifi-majdi
So, I am closing this issue.


showModalBottomSheet with DraggableScrollableSheet failure during golden tests

Hey, Flutter team and contributors!
I've created similar issue to golden_toolkit repository. I don't know, if it's only related to golden_toolkit or it's a general problem, so I'm creating this issue.
Let's say, we'd like to display draggable bottom sheet, which height is 200. It's snaps are 0 (closed) and 1 (fully opened).
When we wrote such code and run on any device - it works fine. But when we try to write golden tests for such case, it fails.
Source code
    showModalBottomSheet<void>(
      context: context,
      constraints: const BoxConstraints(
        maxHeight: 200,
      ),
      builder: (_) {
        return DraggableScrollableSheet(
          minChildSize: 0.0,
          initialChildSize: 1.0,
          snap: true,
          snapSizes: const [0.0, 1.0],
          builder: (context, scrollController) {
            return Container(
              color: Colors.blue,
            );
          },
        );
      },
    );

See entire demo project.
How to reproduce
Run flutter test.
Failure cause
Seems like DraggableScrollableSheet's builer requires scrollable Widget with controller passed into constructor when it's displayed by showModalBottomSheet.
How to fix
Wrap sheet's content into scrollable widget with NeverScrollableScrollPhysics and pass scrollController into such widget.
    showModalBottomSheet<void>(
      context: context,
      constraints: const BoxConstraints(
        maxHeight: 200,
      ),
      builder: (_) {
        return DraggableScrollableSheet(
          minChildSize: 0.0,
          initialChildSize: 1.0,
          snap: true,
          snapSizes: const [0.0, 1.0],
          builder: (context, scrollController) {
            return CustomScrollView(
              controller: scrollController,
              physics: const NeverScrollableScrollPhysics(),
              slivers: [
                SliverFillRemaining(
                  child: Container(
                    color: Colors.blue,
                  ),
                ),
              ],
            );
          },
        );
      },
    );

Stack trace
00:03 +1: MyHomePage golden tests shows bottom sheet
══╡ EXCEPTION CAUGHT BY SCHEDULER LIBRARY ╞═════════════════════════════════════════════════════════
The following assertion was thrown during a scheduler callback:
ScrollController not attached to any scroll views.
'package:flutter/src/widgets/scroll_controller.dart':
Failed assertion: line 107 pos 12: '_positions.isNotEmpty'

Either the assertion indicates an error in the framework itself, or we should provide substantially
more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
  https://github.com/flutter/flutter/issues/new?template=2_bug.md

When the exception was thrown, this was the stack:
#2      ScrollController.position (package:flutter/src/widgets/scroll_controller.dart:107:12)
#3      _DraggableScrollableSheetScrollController.position (package:flutter/src/widgets/draggable_scrollable_sheet.dart:725:13)
#4      _DraggableScrollableSheetState._replaceExtent.<anonymous closure> (package:flutter/src/widgets/draggable_scrollable_sheet.dart:656:27)
#5      SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1144:15)
#6      SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1089:9)
#7      AutomatedTestWidgetsFlutterBinding.pump.<anonymous closure> (package:flutter_test/src/binding.dart:995:9)
#10     TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:71:41)
#11     AutomatedTestWidgetsFlutterBinding.pump (package:flutter_test/src/binding.dart:982:27)
#12     WidgetTester.pump.<anonymous closure> (package:flutter_test/src/widget_tester.dart:608:53)
#15     TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:71:41)
#16     WidgetTester.pump (package:flutter_test/src/widget_tester.dart:608:27)
#17     _twoPumps (package:golden_toolkit/src/multi_screen_golden.dart:18:16)
#18     multiScreenGolden.<anonymous closure> (package:golden_toolkit/src/multi_screen_golden.dart:71:30)
#19     multiScreenGolden.<anonymous closure> (package:golden_toolkit/src/multi_screen_golden.dart:66:13)
#20     WidgetFlutterBindingExtensions.runWithDeviceOverrides (package:golden_toolkit/src/widget_tester_extensions.dart:32:17)
<asynchronous suspension>
<asynchronous suspension>
(elided 7 frames from class _AssertionError, dart:async, and package:stack_trace)
════════════════════════════════════════════════════════════════════════════════════════════════════
══╡ EXCEPTION CAUGHT BY SCHEDULER LIBRARY ╞═════════════════════════════════════════════════════════
The following assertion was thrown during a scheduler callback:
ScrollController not attached to any scroll views.
'package:flutter/src/widgets/scroll_controller.dart':
Failed assertion: line 107 pos 12: '_positions.isNotEmpty'

Either the assertion indicates an error in the framework itself, or we should provide substantially
more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
  https://github.com/flutter/flutter/issues/new?template=2_bug.md

When the exception was thrown, this was the stack:
#2      ScrollController.position (package:flutter/src/widgets/scroll_controller.dart:107:12)
#3      _DraggableScrollableSheetScrollController.position (package:flutter/src/widgets/draggable_scrollable_sheet.dart:725:13)
#4      _DraggableScrollableSheetState._replaceExtent.<anonymous closure> (package:flutter/src/widgets/draggable_scrollable_sheet.dart:656:27)
#5      SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1144:15)
#6      SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1089:9)
#7      AutomatedTestWidgetsFlutterBinding.pump.<anonymous closure> (package:flutter_test/src/binding.dart:995:9)
#10     TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:71:41)
#11     AutomatedTestWidgetsFlutterBinding.pump (package:flutter_test/src/binding.dart:982:27)
#12     WidgetTester.pump.<anonymous closure> (package:flutter_test/src/widget_tester.dart:608:53)
#15     TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:71:41)
#16     WidgetTester.pump (package:flutter_test/src/widget_tester.dart:608:27)
#17     _twoPumps (package:golden_toolkit/src/multi_screen_golden.dart:18:16)
#18     multiScreenGolden.<anonymous closure> (package:golden_toolkit/src/multi_screen_golden.dart:71:30)
#19     multiScreenGolden.<anonymous closure> (package:golden_toolkit/src/multi_screen_golden.dart:66:13)
#20     WidgetFlutterBindingExtensions.runWithDeviceOverrides (package:golden_toolkit/src/widget_tester_extensions.dart:32:17)
<asynchronous suspension>
<asynchronous suspension>
(elided 7 frames from class _AssertionError, dart:async, and package:stack_trace)
════════════════════════════════════════════════════════════════════════════════════════════════════
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following message was thrown:
Multiple exceptions (2) were detected during the running of the current test, and at least one was
unexpected.
════════════════════════════════════════════════════════════════════════════════════════════════════
00:03 +1 -1: MyHomePage golden tests shows bottom sheet [E]
  Test failed. See exception logs above.
  The test description was: shows bottom sheet

00:04 +2 -1: Some tests failed.

Hi,
Have you tried with by adding ' maxChilSize' ?
It may or may not be related. Sorry if its not.

@grafovdenis
Thanks for the report. I cloned your repo and ran it which does show the error you reported. Although you are using a third party plugin https://pub.dev/packages/golden_toolkit for your golden tests. Does it produce the same error if you don't use the plugin and just use framework code in your tests ? Something like below:

 updated code

void main() {
  group('MyHomePage golden tests', () {
    const myHomePage = MyHomePage();

    testWidgets('screen renders correctly', (tester) async {
      await tester.pumpWidget(myHomePage);

      await expectLater(tester, matchesGoldenFile('my_home_page'));
    });

    testWidgets('shows bottom sheet', (tester) async {
      await tester.pumpWidget(myHomePage);

      await tester.tap(find.text('Open BottomSheet'));

      await tester.pumpAndSettle(const Duration(seconds: 1));

      await expectLater(tester, matchesGoldenFile('my_home_page_bottom_sheet'));
    });

    testWidgets('shows fixed bottom sheet', (tester) async {
      await tester.pumpWidget(myHomePage);

      await tester.tap(find.text('Open fixed BottomSheet'));

      await tester.pumpAndSettle(const Duration(seconds: 1));

      await expectLater(tester, matchesGoldenFile('my_home_page_bottom_sheet_fixed'));
    });
  });
}

you might need to update it to run properly.

@darshankawar, thanks for the response.
I tried to run golden tests without golden_toolkit.
And all tests passed. Thanks for your help!
So, I'm closing this issue.

import 'package:bottom_sheet_golden_test_failure/main.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
  group('MyHomePage golden tests', () {
    const myHomePage = MyApp();

    testWidgets('screen renders correctly', (tester) async {
      await tester.pumpWidget(myHomePage);

      await expectLater(
        find.byType(MyApp),
        matchesGoldenFile('my_home_page.png'),
      );
    });

    testWidgets('shows bottom sheet', (tester) async {
      await tester.pumpWidget(myHomePage);

      await tester.tap(find.text('Open BottomSheet'));

      await tester.pumpAndSettle(const Duration(seconds: 1));

      await expectLater(
        find.byType(MyApp),
        matchesGoldenFile('my_home_page_bottom_sheet.png'),
      );
    });

    testWidgets('shows fixed bottom sheet', (tester) async {
      await tester.pumpWidget(myHomePage);

      await tester.tap(find.text('Open fixed BottomSheet'));

      await tester.pumpAndSettle(const Duration(seconds: 1));

      await expectLater(
        find.byType(MyApp),
        matchesGoldenFile('my_home_page_bottom_sheet_fixed.png'),
      );
    });
  });
}


Fix Issue #8 -- a bug in number treatment and compile time warnings

This fixes warnings caused by the recent changes in https://github.com/strongloop/loopback-sdk-ios.
Also fix a bug in number treatment -- it used to map JS number to NSInteger mistakenly although number could be a float value.
@bajtos could you please review the changes?

Landed, thank you @hideya


Automatically create blog post PRs

At this point, GoldMiner only prints the blog post. It would be convenient if it automatically opened a draft PR with that blogpost on our blog repo.

[ ] PR title is New article: #{article.name}
[ ] PR reviewers are the people mentioned in the blogpost

This now can be implemented as a new distributor


gui.Array fixerupper

Support 'remove' by member reference (instead of member index).
@nealstewart

Is this one still getting merged?

Apparently not, since there's a merge error. But I guess we can wait, since this is coming in via "jmo-buttons" anyways?


Touchdown Update for Localization strings

What
Adds localization for missing strings.
Why

How Tested

Process & policy checklist

[ ] I have updated the project documentation to reflect my changes if necessary.
[ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

Woohoo! (Are the automated PRs for this not working currently?)

I didn't know we  had automated PR setup for this.
@mgamis-msft might know more.

Woohoo! (Are the automated PRs for this not working currently?)

No, automated PRs are not working currently. I will work on creating a machine account for azure pipelines that has push permissions to create a PR and with that create weekly azure pipeline to commit to a non-main branch (which is tricky because I have to somehow branch off the trigger branch which is main).


CI: add typos check

Lets add a typos CI check that will make sure we are not misspelling things
Example [link]

Another example


Backward compatibility

Are you requesting a feature, reporting a bug or ask a question?
Question
We were wondering whether we are right in assuming that the SurveyJS Editor library is backward compatible with older versions of the Survey.JS. Libary.
So for instance, if we would use a new version of the Editor to build a form,  and then try to show it using an older version of the Survey.JS library (for existing projects), would that create a problem?

@Lynn42
SurveyJS Editor should able to edit all survey jsons, that has the same or early versions.
SurveyJS Library should be able to run  all survey jsons, that has the same or early versions.
We fully support the very first version of survey JSON that has been released almost two years ago by our last version, v0.96.1 at the current moment.
We want to continue doing it.
However if survey json has been created by the latest version of Survey Editor and you do not have the latest version of SurveyJS library in run-time, the new features will be simply ignored.
For example. We have added QuestionExpression 2-3 weeks ago. If you add this question type into your survey and try to run it by SurveyJS library, that has been released 2 months ago, the library will just ignore type "expression", since there is no QuestionExpression in it. It doesn't know what object should it create.
Thank you,
Andrew

Amazing, we hoped this to be the case. Thank you for the quick response!


+X% to Chaos Damage Over Time Multiplier is not applying to the "more" section for poison stacks.

As far as I know +X% chaos damage over time multiplier should be treated as a source of more for poison stacks while it is currently not listed at all.
This is most likely a hold over from the previous patch where those passive nodes were listed as "+X% to non-ailment chaos damage over time multiplier" which specifically did not apply to poison.

All ailments have this problem currently. "+#% to X damage over time"  mods are recognized and calculated correctly, but not displayed. Their multiplier is rolled into the source damage.


Using cfu unit as storage

Hi @tcal-x and @mithro ,
In my network/model, I've noticed that there is a high memory bottleneck compared to computation time, so I wanted to try to use the cfu unit (single cycle) for storage/ as extra buffers used by the vexriscv core to show speedup. However, surprisingly, I'm either seeing the same runtimes or actually worse. Is it an issue with how long the core takes to interface with the cfu? Any advice on this/ any other alternative like a data-scratchpad memory? Ive tried changing the cache sizes, L2 sizes, maxxed out I-cache as well, but Im not seeing improvements.
Another weird thing Ive seen is that when I remove the condition checks for checking if the point is in the image ( in conv.h ), I'm noticing really high reduction in runtimes. For example, as in the original conv.h file, you can see this below
   const bool is_point_inside_image =
                  (in_x >= 0) && (in_x < input_width) && (in_y >= 0) &&
                  (in_y < input_height);

              if (!is_point_inside_image) {
                continue;
              }

Please let me know about this,
Thanks,
Bala.

@bala122 , we also used CFU storage as an isolated function as an intermediate step in some of our accelerators.  For example, we'd push the data in, then in our main processing loop, the CPU would pull a data word out of CFU storage for processing either on the CPU or by using a different CFU function.   As you saw, this usually did not gain a speedup.   I don't think we dived into waveform-level analysis, but that would be a useful thing to do here.   In this case, the Renode (with Verilator) simulation is not so useful since the CPU modeling is not cycle accurate.   Here, you would want to do full Verilator simulation (including the CPU).   The build is a single step:
make PLATFORM=sim load <other options>

Don't set TARGET; it is ignored.    But you can set the --cpu-variant using EXTRA_LITEX_ARGS.
The CFU-Playground software, when compiled for simulation, has a menu item to enable tracing.  So, if you have your small benchmark added to the project menu, then start the simulation, enable tracing, run your benchmark, and quit as quickly as possible to keep the trace  file size reasonable.  Note there's a bug that it produces .vcd files even though it should be producing .fst files.
Finally, that computation that you show is very familiar to me --- that was the very first code that I attempted to speed up using a CFU!!  I converted the sequence of comparisons to a single-cycle CFU instruction.   And I did get more improvement than I expected, given that it's not even in the inner-most loop.   The sequence of conditional branches seems to be quite expensive.   However, you may be seeing another effect.   Any time the software is changed, you may indirectly cause an increase or decrease in I-cache misses due to changes in code placement.
(Also note that this check is suboptimal as written; the check in one of the dimensions can be moved to a more-outer loop.)

Thanks for that @tcal-x ,
Actually, I realised that the stagnation in runtimes might have been due to the small size of the layer I was dealing with. I used lower d-cache and L2 sizes/ moved to a bigger layer with the same size and noticed improvements. However, it's still surprising that the runtime stagnated at such a high value ( in millions of cycles for the give layer), even though it could fit in all the data in d-cache or L2.
I thought that fundamentally the vexriscv core can't do better than this given the number of instructions in the inner most loop and the total counts it takes.
Or , it could be that there is still instruction data traffic between L1 and L2 even though the L1 I cache is big which seems unlikely. That's why, I wanted to know about the exclusivity/inclusivity of the L1-L2 cache hierarchy (here)

@bala122  there is an interesting potential project here -- since it's a soft CPU core, we are free to modify it to add instrumentation counters.   For example we could add counters to record the number of Icache hits & misses, and same for Dcache.   It would take some mucking around in the SpinalHDL Scala, but it is doable (I've already prototyped a dcache miss counter CSR).
Or, again, looking at waveforms might be informative and reveal unexpected stalls and such.


python310Packages.hap-python: update source hash to fix build

Description of changes
Fixes https://github.com/NixOS/nixpkgs/issues/242236.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 242417 run on aarch64-darwin 1

4 packages built:

python310Packages.hap-python
python310Packages.hap-python.dist
python311Packages.hap-python
python311Packages.hap-python.dist

Result of nixpkgs-review pr 242417 run on aarch64-linux 1

5 packages built:

home-assistant-component-tests.homekit
python310Packages.hap-python
python310Packages.hap-python.dist
python311Packages.hap-python
python311Packages.hap-python.dist


Return application/json as content-type header

What this PR does / why we need it:
Set application/json as content-type header in response.
Which issue(s) this PR fixes:
Fixes issue where the response type header is incorrectly set to text/html
* upload completely sent off: 27 out of 27 bytes
< HTTP/1.1 200 OK
< content-length: 20
< content-type: text/html; charset=UTF-8
< date: Thu, 19 Dec 2019 12:54:43 GMT
< server: istio-envoy
< x-envoy-upstream-service-time: 6

Release note:

This change is

/ok-to-test

/retest

@yuzisun I believe it's ready to be merged, any more suggestion?

Awesome!
/lgtm
/approve


"currently available for .NET Standard only" is incorrect

The doc reads:
> This library is currently available for .NET Standard only, it's not yet available for .NET Core.
This is incorrect - .NET Core implements .NET Standard, so if it was available for .NET Standard, it would be compatible with .NET Core.
I think the doc author confused .NET Standard with .NET Framework, and the text should read something similar to "... currently available for .NET Framework only..."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a9ca205b-55ab-683a-46ee-afc9f6fc239b
Version Independent ID: 065b8cb0-d218-b759-ce69-e8901d89b422
Content: Get started with Azure Table storage and Azure Cosmos DB Table API using .NET
Content Source: articles/cosmos-db/table-storage-how-to-use-dotnet.md
Service: cosmos-db
GitHub Login: @wmengmsft
Microsoft Alias: wmeng

Also, a new package https://www.nuget.org/packages/Microsoft.Azure.Cosmos.Table appears to have just hit 1.0.0 and supports .NET Standard/Core, so perhaps this sample is also out of date and references to Microsoft.Azure.CosmosDB.Table should be updated/removed?

@zarenner, thanks for the feedback. We already have updated documentation for this page (as well as updated samples, already live in GitHub) in the pipeline that will be published very soon.
@SnehaGunda can provide more details.

@zarenner  and @wmengmsft thanks for pointing out the issue, actually this doc is a duplicate of the following table API tutorial. we have recently updated the following tutorial and fixed the comment pointed out in this issue. I submitted another PR to delete the old sample doc and redirect it to the new tutorial:
https://docs.microsoft.com/en-us/azure/cosmos-db/tutorial-develop-table-dotnet
Hope the update helps, we will now close this issue if there aren't any further questions.
#please-close


NOT FOR MERGE measure impact of /components/material-icons

See github checks for changed timings
All deploys were manually triggered while clearing cache:

without /components/material-icons (d26fb0c26d488d0d8acf66e220df1f51ebf8768b): https://app.netlify.com/sites/material-ui/deploys/6040f4ce890cea2d29a506da
with /components/material-icons (2499035c65d233d2a68abeb0cf6c086b76519125): https://app.netlify.com/sites/material-ui/deploys/60412f57e2badc00b9720ab9

In these two builds, we get for yarn docs:build:

without icons: 559s, 9min
with icons: 783s, +4min

But is the build duration stable? At least, it gives us some idea.

But is the build duration stable?

It's never "stable". That's just how shared resources work. But having +-4min within a 15min timeframe is highly unlikely.
But this gives an estimate about how much it impacts build performance.

Another data point. I have tried to build the docs locally with the two commits and without cache.

d26fb0c26d488d0d8acf66e220df1f51ebf8768b: 279s.
2499035c65d233d2a68abeb0cf6c086b76519125: crash memory heap allocation issue (I didn't configure the same option as in Netlify env). Once configured: 441s.

diff --git a/docs/package.json b/docs/package.json
index 9d96dc6c38..fa16b2b25b 100644
--- a/docs/package.json
+++ b/docs/package.json
@@ -5,7 +5,7 @@
   "author": "Material-UI Team",
   "license": "MIT",
   "scripts": {
-    "build": "cross-env NODE_ENV=production next build --profile",
+    "build": "cross-env NODE_ENV=production NODE_OPTIONS=--max_old_space_size=4096 next build --profile",
     "build:clean": "rimraf .next && yarn build",
     "build-sw": "node ./scripts/buildServiceWorker.js",
     "dev": "next dev",


fix ts generation modeling

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Error on the prerelease branch

I was testing the speed of the prerelease when I got the error
[ERROR] stdout maxBuffer length exceeded

[FATAL ERROR] The aria2c rpc server crashed with the previous message

This happened after I downloaded about 3 files that I supplied the links via the file.txt input.
EDIT
Always crashes with the error above after downloading 2 whole videos and finishes the video segment of the third, about when starting to download the audio segments.

Could you please tell me the platform/os you are running and how long were the videos?
Are you comfortable with editing the code a little bit yourself to test a possible solution?

I'm running windows 10. Can give you all the specs if it is necessary.
Sure, I can take a crack at it and do the necessary changes.

Please add a space and -q after {port} on this line, compile and try again
https://github.com/snobu/destreamer/blob/331efd9773dcc45c470d5ed474d9e7e3fff3dd3e/src/destreamer.ts#L167

I got this error
(node:17988) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 message listeners added to [WebSocket]. Use emitter.setMaxListeners() to increase limit

In the middle of downloading the 5th video.
The old problem with maxBuffer was fixed with -q.

Middle of 5th download, do you remember when? Before the video download, before the audio download or somewhere else?

Maybe this can help.

It does! Thank you very much for your patience and help beta testing this branch!

I'll let you know when I have a solution but I have a suspect on what's wrong here so I hope it won't take much

No problem mate, let me know if there is anything I can help with.

Oh and btw my PC just crashed because chromium was using to much RAM memory. Idk what happened but my RAM was at 99.8%. No logs sorry.

pull the newest release, I couldn't fix it in the little time I had but there's a workaround in place, so you can use it

Oh and btw my PC just crashed because chromium was using to much RAM memory. Idk what happened but my RAM was at 99.8%. No logs sorry.

I really have no idea, Destreamer should always clean up after itself :/ if it happens again let me know

I really have no idea, Destreamer should always clean up after itself :/ if it happens again let me know

I downloaded 20-30 videos in batches of 10 while testing and everything was normal until that moment, it was a couple hours later. Maybe there is a process stuck.

Did it crash again because of Chromium @Dunsteer ?

Was talking about the bug earlier, didn't test it after that. Maybe next weekend.

Ok, open a new issue if needed. Closing


Catch from a Promise returns IPromise instead of IPromise

Old Code:
`
public override IPromise Access()
{
    return new Promise<object>((resolve, reject) =>
    {
        StartCoroutine(Access(resolve: resolve, reject: reject));
    })
    .Catch(error => Debug.LogError(error));
}

`
After moving from 2.6 to 3.00 the compiler reports an error stating that Catch is returning IPromise instead of IPromise like in 2.6.
Have I missed something or is this a bug?

This is intended behaviour. From version 3.0, you can return a value from a .Catch to be used in a later then:
var defaultValue = "foo";

FunctionReturningPromise()
    .Catch(ex => {
        Console.Error(ex.Message);
        return defaultValue;
    })
    .Then(v => Console.Log(v));

This means that, like JavaScript promises, if your .Catch handler doesn't return a value, no value will be passed through and you will end up with a non-value promise (IPromise as opposed to IPromise<T>).
To work around this, you should either return a default value in your .Catch handler or move the error handling outside of the function returning the promise.


source location failed

Hi Kuangdai,
some of the sources in my finite rupture simulations are not found in the mesh and I cannot figure out why. I had the code output the spz coordinates and they seem to be in range. The SE_Model::locateInplane function also considers it in range. In a single-processor test, SE_Model::locateInplane runs until the final "return -1" statement. I'll paste a zip folder of a minimal example which reproduces the error.
Thanks for your help!
Claudia
input.zip

As a single-source problem, you should use SOURCE for geodesy:lat_lon_north_pole_mesh.
 If yes, put it further away from axis to avoid the axial singularity (numerical error of inverse Newton is greatly amplified in this region).

It's not a single source in the original simulation. The finite rupture consists of 40,000 sources and the input file is several MB. That's why I only included the source that causes the problem in the example.

This is the full source file.
inparam.source.zip

For now you can manually increase the tolerance used to judge if a point belongs to an element.
Change
mQuads[iquad].inverseMapping(sz, xieta)

to
mQuads[iquad].inverseMapping(sz, xieta, 10, 0.005)

There are two such lines: 587, 599 in SE_Model.cpp.
In the long term, maybe we need make this tolerance as an input in advanced.

Ok, it now fails at a later source. I think I can fix this by gradually increasing the tolerance until everything is found. Is there any point in increasing maxIter?

Setting the tolerance to 0.1 fixed it!

Ignore my previous answer. That is not the right fix.
I believe the real problem is that some of your elements have too skewed shapes, like the one I highlighted in the figure. Inverse mapping ((s,z) to (xi, eta)) on such elements are very unstable or non-unique. The right fix is to make a more isotropic mesh, e.g., by adding some factious discontinuities.

I have just reverted the code changes and tried a different mesh and it didn't work. I'll attach the new mesh.
AxiSEMCartesian_sfba_1.zip

Can you  add more discontinuities so that the minimum angle is no less than about 45 degree?

Nope, still no luck...
AxiSEMCartesian_sfba_plus_1.zip

Reason found and fixed.
https://github.com/kuangdai/AxiSEM-3D/commit/d70a67ac3c6545df0ac70fa30895d0e0e06c6ff8


Modern logo for Windows 8 and 10

Windows 8, 8.1 and 10 should use the modern logo, like in the shell script version of screenFetch.

Definitely. I don't remember where I got most of the original logos from, but using KittyKatt's with a GPLv3 notice in the LICENSE should be fine.

The Modern Windows logo was originally submitted by me: https://github.com/KittyKatt/screenFetch/commit/8d962abe4bd15ec86840c3f1daddbf56d8f8ae6d
So, if I say you can add it under the MIT license I guess that should be fine (?).

Yeah, that should be fine then. I'll commit it shortly.

Included it in b7eb30d. I'll close this issue once you confirm things are working smoothly.

Works. But now it shows Font: Unknown. Is there even a detection method for "Font" in detect.c?

On Windows, only for Cygwin (see the poorly named detect_gtk function).
Font detection on Linux was actually broken because of a clobbered variable until 4a9a61e. It's still not very reliable, though.

Okay then. I'll close this issue.


Changing values in the settings and task modals is laggy

There's a little bit of lag when I try to change values in both of these modals. I probably just need to update on debounce or something.

It's worth noting that I notice the lag when adding characters to these fields, but not when deleting them.

I did some preliminary looking-in to this and I have no idea what's going on. I hate to say it, but this might have to simmer on the backburner for a while.

This issue seems to have resolved itself. I'm a little concerned, but if it's not an issue, it's not an issue. Closing for now.


Revert "unpin holoviews"

Reverts intake/xrviz#45

@jhamman I merged because yes, you no longer need to pin holoviews, but then realized you need to do something like:
  - pyviz/label/dev::hvplot
  - pyviz/label/dev::holoviews
  - pyviz/label/dev::panel
  - pyviz/label/dev::datashader
  - metpy
  - numpy
  - xarray
  - pip
  - pip:
    - git+https://github.com/pyviz/geoviews.git

to get the tooltips to accurately show lon/lat.

Ugh! This is too bad. xrviz is basically unusable in its current state. A package this small shouldn't be pinning a widely used dependency like this. My preference would be forgo tool tips today and push holoviews to make a release ASAP. Thoughts?

@jhamman, indeed, this is a sad state of affairs.  Hopefully things will change : https://github.com/pyviz/hvplot/issues/324
My preference would be to use the dev channels and geoviews master for now:
 channels:
  - conda-forge
dependencies:
  - cartopy
  - fsspec
  - pyviz/label/dev::hvplot
  - pyviz/label/dev::holoviews
  - pyviz/label/dev::panel
  - pyviz/label/dev::datashader
  - metpy
  - numpy
  - xarray
  - pip
  - pip:
    - git+https://github.com/pyviz/geoviews.git

and then switch to conda-forge when the next release is made, after which @philippjfr says things should calm down for a while.

Will try my best to release datashader, holoviews and panel today. @jsignell probably has a better handle on how far out an hvPlot release is.

Thanks @philippjfr - those efforts will be much appreciated.


Be explicit about sugar.lift parameter being typed instead of untyped

With Nim's current overloading system, since lift has an overload with the first parameter having a type, the first parameter of any lift call is assumed to be typed (which is not preferable, discussion about it here). lift currently breaks if this behavior is changed, unless we explicitly write typed, so do this in case this gets changed.

Feel free to add this patch yourself

Sorry it took a while, I applied the change manually as you suggested. Thank you!


Added Instruqt hands-on tutorials

Instruqt offers hands-on tutorials that are free to play for anyone.

/assign @zacharysarah

@bastichelaar Thanks for the update. Could you please sign the CLA. Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.


Fix errors in compile_fail_utils

Objective

compile_fail_utils is a helper crate that we use to support our UI testing infrastructure. (UI tests are how we verify that the output of macros do not change spontaneously.)
compile_fail_utils is outside of the workspace, so it is not checked by default nor caught by CI. Its example test has been failing since it was originally introduced.

Solution

Fix compile_fail_utils's example test so that it now compiles.
Bless the results, which were outdated.

Testing

cd tools/compile_fail_utils && cargo check --all-targets
cd tools/compile_fail_utils && cargo test --test example

Good fix, but can we add something to CI to ensure that this is automatically checked?

Yup! The simplest fix I could find was to add all of the compile_fail tests to the Cargo workspace. (Which works, surprisingly, so I'm unsure why we didn't do this in the past!)

I thought that we don't include the compile_fail tests because it doesn't work with crater. @alice-i-cecile am I hallucinating that? 😆

I don't remember that! And not seeing any issues on https://github.com/rust-lang/crater. Are you sure you haven't been replaced by an LLM?
Anyways @BD103 CI is now mad at you, so kicking this back to you until it's placated.

https://github.com/bevyengine/bevy/blob/main/tools%2Fcompile_fail_utils%2FREADME.md

https://github.com/bevyengine/bevy/blob/main/tools%2Fcompile_fail_utils%2FREADME.md

I wonder why it says that! As far as I can tell, Crater just runs cargo build && cargo test. The only time Crater may fail is if it manually runs rustc on any .rs file it finds, which wouldn't make sense... @cart, do you have anything to add to this?
Either way, let me fix the final few Clippy lints!

Turns out CI was running cargo test --benches, which would cause all of our benchmarks to be run for every PR. I turned that off in 2d763ab8965c733baa264c1bed4c808f338b6808, since that seems undesired.

For the lifetime elisions, disable that clippy lint to be in line with the workspace.

While there's a bit more I could do to improve the code quality of the benchmarks, I'm going to save it for a separate PR.

I'm going to take another shot at this tomorrow. For some reason I'm unable to reproduce CI locally...


Add roadmap of the project

Some people like me would like to contribute, but sadly, I dont know what to start with. Having somekind of a todo/gh project/roadmap would be great, so more people would contribute.

one with the new beta projects perhaps

Done. I'll add more specific and targeted issues to the roadmap as I think of them.


Fix 'dotnet restore' when the extension tries to run it for a specific project

I fixed running restoring packages in one scenario in #1176 but missed another.

I don't think this is contentious. I'm going to go ahead and merge.


Godot 4 - CharacterBody2D does not actively detect Area2D (regressed from Godot 3.5.3)

Godot version
4.1.2.stable.flathub [399c9dc39] (regressed: v3.5.3.stable.flathub [6c814135b])
System information
Godot v4.1.2.stable (399c9dc39) - Freedesktop SDK 23.08 (Flatpak runtime) - Wayland - Vulkan (Compatibility) - Mesa Intel(R) Xe Graphics (TGL GT2) () - 11th Gen Intel(R) Core(TM) i5-11320H @ 3.20GHz (8 Threads)
Issue description
I noticed an inconsistent behavior between CharacterBody2D (Godot 4) and KinematicBody2D (Godot 3).
In Godot 3, KinematicBody2D actively detects an Area2D, if Area2D sets a collision bit and KinematicBody2D sets a corresponding mask. The detection can only be prevented by setting Area2D.monitoring = false (Note: it's not .monitable property.).
The behavior is different in Godot 4, that when Area2D sets a collision bit and CharacterBody2D sets a corresponding mask, the detection does not happen anymore.
Note before continuing
This issue can have two interpretations, that a) it's a designd change that Godot 4 intentionally prevent CharacterBody2D detecting Area2D, just didn't explain in documentation, or b) it can be a Godot 3 quirk because .monitoring property does not seems to affect this behavior.
Given there's a clear workaround (described below), it should be a low priority issue, but a confirmation of expected behavior is needed.
Use case scenario
I've developed an action game with a reactivatable enemy. The enemy supports two behaviors:

An Enemy can be defeated by player. Once defeated, enemy is still placed on map. Player can't collide with it.
A defeated enemy can be reactivated by an effect released by other enemies, say, flame.

In Godot 3, this feature is implemented by settings collision bits. A brief setup looks like below:

Enemy is an KinematicBody2D node with GDScript. In normal state, it calls set_collision_layer_bit(ENEMY, true). When it's defeated, it calls set_collision_layer_bit(ENEMY, false) and set_collision_mask_bit(FLAME, true).
Flame is an Area2D node, with $Area2D.set_collision_layer_bit(FLAME, true).

With setup above, player does not collide with a defeated enemy (it has no collision layer bit). The defeated enemy responds to flame (KinematicBody2D sets mask bit while Area2D sets layer bit). Requirements are met.
However, when migrating my game to Godot 4 with same setup, the defeated enemy does not respond to flame. When I calls $CharacterBody2D.set_collision_layer_value(ENEMY, true) and $Area2D.set_collision_mask_value(ENEMY, true), the defeated enemy responds to both flame and player. Neither is expected.
Workaround in Godot 4
A workaround is to add a new collision layer, DEFEATED_ENEMY.

When enemy is defeated, it sets collision layer to DEFEATED_ENEMY while in normal case it sets collision layer to ENEMY.
Flame sets collision mask DEFEATED_ENEMY.
Player sets collision mask to ENEMY.

When an enemy is defeated, player does not collide with enemy (because player collides with ENEMY but not DEFEATED_ENEMY), while flame can reactivate enemy (because it detects DEFEATED_ENEMY).
Side effect of the workaround: The layer/mask bits are limited to 32 slots. It needs to be shared between terrain, characters and players. Adding more complicated interactions for enemies with different skills can exhaust the slots.
Steps to reproduce
Use my minimal comparison project repository. https://github.com/fuzhouch/godot-3to4-comparison/

Use Godot 3.5.3 to launch Godot 3 project, godot3
Run scene, Demo_Area2D_Detection_Object_Layer_Mask_Match.tscn
Use Godot 4.1.2 to launch Godot 4 project, godot4
Run scene, demo_area2d_detection_object_layer_mask_match.tscn.

Both scenes define two Area2Ds, a Blue area and a Red area. Every area is equipted with a corresponding character (a big gold). Every gold repeats 2-sec cycle of moving into the area, then moving out. Every area has a body_entered signal handler, printing a line on called.
Blue area represents a good case (area-detect-body mode), that characeter sets collision layer as PLAYER (value == 1), and area sets collision mask as PLAYER (values == 1).  Red area represents a bug-reproduce case (body-detect-area mode), that character sets collision mask as EFFECT (value == 4), and area sets collision layer as EFFECT(value == 4).
Expected results
When running scene, we expect both Godot 3 and Godot 4 prints 2 lines every 2 seconds:
detector area Blue entered: Character_LayerSet_MaskUnset
detector area Red entered: Character_LayerUnset_MaskSet
...

Actual results
Only Godot 3 prints 2 lines every 2 seconds
detector area Blue entered: Character_LayerSet_MaskUnset
detector area Red entered: Character_LayerUnset_MaskSet
...

In Godot 4, it prints 1 line every 2 seconds. The Red area do not trigger callback.
detector area Blue entered: Character_LayerSet_MaskUnset
...

Minimal reproduction project

Code repository https://github.com/fuzhouch/godot-3to4-comparison/
Godot 3 project: https://github.com/fuzhouch/godot-3to4-comparison/tree/main/godot3
Godot 4 project: https://github.com/fuzhouch/godot-3to4-comparison/tree/main/godot4

In one sentence: Area doesn't monitor Bodies with a mask on the corresponding Area layer,
it is a regression to v3.x in both 2D and 3D.

Actually, this seems to be the fixed behavior in Godot 4, as by #51801. The 3.x behavior was a source of a lot of confusion, I've even found my own old comments on the subject as long as #15243, and there were plenty of similar issues (and actual bugs too).
The proposal (and the related fixes) which addresses this can be found here: https://github.com/godotengine/godot-proposals/issues/2775
Documentation definitely needs a clear paragraph with examples about how layers and masks are expected to interact, for sure.
AFAIK, this is not a bug tho.

Thanks @voidexp for clarification! So it is indeed a quirk in Godot 3. Yes a documentation will be helpful. Though my workaround mentioned in bug report (seems we should not call it workaround anymore...) has its side-effect, it's not a showstopper.
A crazy thought quickly jumps in my mind: I'm thinking a comparison project btw 3 and 4 may be helpful to game developers who work on migration projects like me. I'm happy to contribute my comparison project if Godot team think it useful.

There’s a doc about migration from Godot 3 to 4, and perhaps you can PR about things not mentioned there that you’ve found and reproduced.

Also, the automatic project conversion tool can benefit from a PR too, if there’s a clear one-way fix for some of the scenarios in your demo project, although I’m not really familiar with its workings.

Thanks Ivan @voidexp, could you guide me how to do PR on the documentation?
Actually, I opened around 5 issues in the past 2 weeks. 2 have been confirmed to be undocumented design change while some are really bugs. Unfortunately, I did read migration doc before migrating, but didn't find corresponding answer, that's why I chose to open issues.

@fuzhouch - there's a documentation about... how to contribute to documentation :) https://docs.godotengine.org/en/latest/contributing/documentation/contributing_to_the_documentation.html

I think the proper way to do what you want is to tell the dead enemy to add a collision exception with the player when it is dead, and then remove the exception if it gets reactivated by the flame. There's no need to mess around with collision layers and masks at runtime in this example.
https://docs.godotengine.org/en/4.0/classes/class_physicsbody2d.html#class-physicsbody2d-method-add-collision-exception-with

Thanks @Deozaan for the suggestion! I didn't notice an API since 3.5. New things is learned.
Unfortunately this API may not be a good solution just as you pointed out. In my game, the dead enemy does not respond only to player, but also almost all enemies. Think about an idea: You see a Pumpkin Head is defeated by a ghost hunter.   These effects can be triggerred from different characters, but not a single Node.
And thank you @voidexp for pointing out the link. I may need some time to finish my current project this month. Then I will summrize all my findings and request updating the doc. Hopefully it can minimize the destraction I made to team. :)


Allure for Bamboo plugin generates empty allure report

I've just switched from the Allure-Plugin to Allure-for-Bamboo, and believe I have the plugin configured correctly - building a report using the 'Allure Report' task as part of a build job, and pointing the plugin at my 'allure-results/' directory, I see the report I'm expecting is generated as I'm expecting (which I can then host as an artefact)
However, I believe that by enabling Plan Configuration > Miscellaneous > Allure Reporting > Enable Allure Building, the report should be automatically built and added as a new tab once the job completes.
In my case, my allure-results folder is at ${bamboo.working.directory}/allure-results. After successfully completing a run, I do get the 'Allure Report' tab, however it contains 0 test results.

@robertgates55 please refer the "Troubleshooting" section of the docs. Empty report tab most might mean that you haven't configured the directory for the generated Allure reports correctly. Usually it means that report has been removed after the generation.
Please check the configured directory and see what files you have there.

Sorry, I probably misunderstood your problem. So you actually have the report, but it does not contain the tests, right?

I checked the 'troubleshooting' docs, but my scenario is none of those - I get a report generated, but the report itself has no test results:

Using the allure report task to build a report from my allure-results folder however, I get a report with 10 test cases generated, as expected.
How do I configure the directory to look in? How can I tell what directory the allure plugin is looking for/building a report from?

@robertgates55 Thanks for the explanation. In your case you actually have the built report, which is good, so the report storage directory is configured correctly. I assume that something is wrong with the allure artifacts that are produced by the job.

Please check the built artifacts for your job and make sure that you have the Allure results correctly generated by the job.
Please refer to the Bamboo server logs and find the lines that contain AllureBuildCompleteAction. This might help you to debug the process of Allure report generation. And post them here if possible.
Also indicate the Allure adaptor that you're actually using for collecting of the test results.

Thanks.
I wasn't aware that build artifacts need to be produced by the job - do I need to define those in the job configuration? Obviously the job is writing allure results into  ${bamboo.working.directory}/allure-results - do I need to create a bamboo artifact to collect these? What artifact name does it need for the allure report to be built from those results?
I'm using the rspec adaptor - I've confirmed that allure will build a report (with 10 test cases!) with these results.

@robertgates55 AFAIU all you need is to define an artifact with the following pattern "**/allure-results".
The name of the artifact does not matter. Allure plugin downloads all the artifacts that are produced by the job and finds the Allure results in them.

I am definitely creating a shared artifact that contains the allure-results directory (with results xmls inside), but sadly the allure report that is being generated still contains 0 test cases.

Has anyone had this working? Has it been tested with bamboo agents, or perhaps only with a shared server/agent on a single box?

We're actually using this plugin at Atlassian internally.
Have you checked the Bamboo server logs as I suggested?
Please indicate the following:

version of Bamboo server
version of Allure Report builder
version of allure-rspec
version of Allure Report builder command line which you were using to test that a report is correctly generated

Also please note that allure-rspec currently generates results in the old (1.x) Allure format, whereas this Bamboo plugin uses the new (2.x) builder command line. This might be also the cause of your issue.

Turns out this was becuase the artifact wasn't defined in the correct way.
I can confirm that the following artifact config has resolved the issue for me:

@robertgates55 good to know, thanks. I'm closing this then.
The new docs will contain the info about the artifact configuration.


Resource viewer

Resource viewer/editior
View and or even edit(not really needed but could be nice) a text or a resource file in the jar
This makes life easier, don't have to open it with winwar, or use luyten

Already in the works for 2.0.0 - https://github.com/Col-E/Recaf/blob/redesign/src/main/java/me/coley/recaf/ui/controls/view/FileViewport.java
Currently supports a text editor and hex editor.

Closing since on the redesign branch this is already implemented (viewing & editing with syntax highlighting)
If you have further ideas to add to the feature I'd love to hear them though :+1:


Fix grammar in basic-types-and-values.md

Link: https://c3-lang.org/language-fundamentals/basic-types-and-values/#pointer-types

Thank you!


fix(ci): seed db before type-check job

Type-check requires a seeded db schema to work.
https://github.com/DevelopingSpace/starchart/pull/201#issuecomment-1428876224

This change works as expected and fixes the issue
https://github.com/DevelopingSpace/starchart/pull/201#issuecomment-1429062279


US19: A logged-in user can access the profile page from the menu.

This issue was closed with commit 0dbdce43654a88c4f6243981842007515259265d


passthrough more args to node_modules

... cos why not?
for example, let me say
npmlock2nix.shell {
  packageLockJson = ./npm-shrinkwrap.json; # shrinkwrap is not yet supported
}

I too would like to specify the location for the lock file instead of having to ln -s npm-shrinkwrap.json package-lock.json.

sorry, this PR is outdated

I too would like to specify the location for the lock file

already supported via node_modules_attrs
npmlock2nix.shell {
  node_modules_attrs = {
    packageLockJson = "${src}/npm-shrinkwrap.json";
  };
}

closing

already supported via node_modules_attrs

Doesn't work for me .. I tried both:
      devShell = npmlock2nix.shell {
        src = ./.;
        node_modules_attrs = {
          packageLockJson = builtins.trace "evaluating shrinkwrap" ./npm-shrinkwrap.json;
        };
      };

And:
      devShell = npmlock2nix.shell {
        src = ./.;
        node_modules_attrs = {
          packageLockJson = builtins.trace "evaluating shrinkwrap" "${src}/npm-shrinkwrap.json";
        };
      };

and that trace command doesn't evaluate.

Doesn't work for me

Seems to be working now from some reason. Thanks for the help @milahu :).


react-table with 75k+ rows is very slow and CPU-expensive

What version of React-Table are you using?
<EMAIL_ADDRESS><EMAIL_ADDRESS>What bug are you experiencing, or what feature are you proposing?
I have loaded a simple react-table component with 75k lines (in 6 columns) as per the "simple table" example at https://react-table.js.org/#/story/simple-table
The data source is being loaded into a Redux store and is fully loaded before the table component renders. Once loaded, the react-table is sluggish - if I click "next", I see the next page of data, but have to wait 7-10 seconds while the CPU churns before I can click "next" or "previous" again.
I do not (and will not) require any type of sorting for this data set but do plan to use the filtering functions of react-table. The component is not crashing in any way and seems to work well - is there anything I can do to speed it up and stop it from hogging the CPU? Is some background sorting operation eating up cycles or something? Suggestions welcome!
Note that your "100k" example at https://react-table.js.org/#/story/100k-rows-w-pivoting-sub-components displays a "RangeError" in Chrome....
Use https://codesandbox.io/s/X6npLXPRW (by clicking the "Fork" button) to reproduce the issue.
I cannot share the data online, and this much data would be impractical anyway...
Thanks in advance for any suggestions! Should I take this to stackoverflow? I see that there is a react-table tag.
John
Edit: aaaaand now an hour or so later (and a few npm restarts later) it seems to be working fine, which kinda makes me nervous.... Any idea what could have bogged it down?

Fistly - the error in the 100K example is related to a change on codesandbox.io. if you change the makeData prop to 25000 it will work (it's something they have done recently to avoid infinite loops). But, those 100K rows are also pivoted (so the top level is less than 100K rows - but the rendering does start to slow down if all the levels of the pivot are open on any one page and more rows are being rendered).
Secondly, ReactTable is VERY MUCH page based. Without seeing the code I would not know but if you are trying to render a LOT of rows in the page it will be slow (there is no optimisation around virtualising the rendering). If you are using the height property to add a scroll-bar then this might be a hint that you are expecting something from ReactTable that it is not really designed to do (i.e. that number of rows probably requires progressive/infinite rendering/scrolling).
So... What is your pageSize set to?
I can't begin to explain what would have bogged it down and now started working without playing around with the implementation (which I realise is tricky).

The defaultPageSize is set to 10, and I have some simple filters in place and working. I'm not sure what was bogging it down but it seems to be on it's feet and working fine now. I won't get back to this code til likely 1/2 and will have more cycles to dig into it then. Thanks for getting back to me!


Implement a solution that converts the doc to md

To have a visual appealing documentation we need to convert it from md to latex and then to pdf.
For this task I recommend Sphinx.
As an example I used the eclipse/winery dev docu.
Links in the pdf are not working.

The example can be found here.

Actually, you've provided a mechanism for converting our .md to pdf, the issue title claims the oposite.
What is the current status of the issue?
Are here any open tasks?

Opened the task at night so the title contains a mistake and check the todos.


feat(Codebytes): move codebytes parent disc 351

Overview

Please Note: this is the foundation for migrating the Codebytes package to a new repository. To our best of our knowledge, this repository is client-modules.
I've confirmed with @Codecademy/web-platform that it's ok to merge packages that are in progress to main, as long as there are no consumers yet. We'll be merging this upon approval. 😄
This first pull request does a couple things:

Moves the Codebytes parent component to client modules (packages/codebytes/src/index.tsx)

the Codebytes parent component currently just accepts text from whatever is calling it

Renders a dummy Editor component (packages/codebytes/src/editor.tsx)

the Editor displays a text area
the onChange in text area sets the text whenever it is entered

Sets up a local storybook to see the component's UI (packages/codebytes/src/stories/Codebytes.stories.tsx)

(packages/codebytes/.storybook/preview.js)
(packages/codebytes/.storybook/main.js)
(all dist files are autogenerated!)

Migrates a few essential package-related files that we have in gamut for individual packages, including babel.config.js, tsconfig.json, package.json. These are configuration files that are local to a package, and need not be in the root configuration.

PR Checklist

[x] Related to JIRA ticket: DISC-351
[x] I have run this code to verify it works

Note, I will make a pr with tests against the full integration branch once the UI is complete.
To test

[x] Can be viewed on storybook locally by running yarn storybook and viewing localhost:6006
[x] Enter text, textarea will be updated. No errors should show in storybook.

IMPORTANT: If your PR contains breaking changes, please remember to follow the instructions for breaking changes!

📬Published Alpha Packages<EMAIL_ADDRESS>
@JoshuaKGoldberg, i'm tagging you right now as an early reviewer with two questions, since you have context on this!

yarn format:verify/prettier is failing for me, but i'm not quite sure why.
after creating a local babel.config.js, my yarn.lock file is much longer. does this generally seem ok?

yarn format:verify/prettier

Try yarn format? See it in package.json, it passes --write and so should fix up any issues.
If that's not it, ugh, it might be something with endlines/whitespace?

creating a local babel.config.js, my yarn.lock file is much longer

I bet those two are unrelated.

I bet those two are unrelated.

Actually, scratch that, it's the same length! @JoshuaKGoldberg

📬Published Alpha Packages<EMAIL_ADDRESS>
looks great @BandanaKM . i wonder if it would make sense to just merge this after approval instead of keeping the pr open until the rfc is done. we can always copy it into the new repo later, but it might be easier to parallel work and make sure things don't get stale if don't leave this pr open?
i also wonder if it might make sense to keep the naming conventions and file structure from static sites for now to make it clear what has been moved and what hasn't?

📬Published Alpha Packages<EMAIL_ADDRESS>

looks great @BandanaKM . i wonder if it would make sense to just merge this after approval instead of keeping the pr open until the rfc is done. we can always copy it into the new repo later, but it might be easier to parallel work and make sure things don't get stale if don't leave this pr open?

@borisonr The one question I had about merging once approved is that, if this repo is opensource, is it okay to have packages that are still a work in progress? I can bring it up with the web platform team too!

i also wonder if it might make sense to keep the naming conventions and file structure from static sites for now to make it clear what has been moved and what hasn't?

Yes, indeed! I am actually keeping the component file structure and names identical. There is logic in Codebytes parent that we do not need here, thus I didn't move those. The Editor component will be moved in full in the next pr!

looks great @BandanaKM . i wonder if it would make sense to just merge this after approval instead of keeping the pr open until the rfc is done. we can always copy it into the new repo later, but it might be easier to parallel work and make sure things don't get stale if don't leave this pr open?

@borisonr The one question I had about merging once approved is that, if this repo is opensource, is it okay to have packages that are still a work in progress? I can bring it up with the web platform team too!

i also wonder if it might make sense to keep the naming conventions and file structure from static sites for now to make it clear what has been moved and what hasn't?

Yes, indeed! I am actually keeping the component file structure and names identical. There is logic in Codebytes parent that we do not need here, thus I didn't move those. The Editor component will be moved in full in the next pr!

cool, imo it's fine to merge, but what do you think @Codecademy/web-platform?
and i think static sites uses slightly different file names? like CodeByteEditor instead of Codebytes. not a huge deal

cc @JoshuaKGoldberg, do you think it's ok to merge a package that is in progress?

cc @JoshuaKGoldberg, do you think it's ok to merge a package that is in progress?

Confirming this is a yes as discussed on slack with jake and josh!

Maybe it would be useful to leave a comment in the storybook file that let's people looking at storybook that this is preliminary and not ready to be used?

Is there a reason to wait on the Monaco editor?  Seems it could be added to this PR?

Is there a reason to wait on the Monaco editor? Seems it could be added to this PR?

@j10sanders, the monaco editor is a bit more complex than it seems. the editor component itself has a lot of configuration (will be next), and that is the parent of the monaco editor. the monaco editor will need to be imported from gamut, which we didn't use in the original codebytes and will require some new dependencies.
there's a bit more groundwork and some questions for reach which is why i am keeping it as a separate ticket!

Maybe it would be useful to leave a comment in the storybook file that let's people looking at storybook that this is preliminary and not ready to be used?

makes absolute sense!

📬Published Alpha Packages:@codecademy/codebytes@0.0.2-alpha.093a46.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/codebytes@0.0.2-alpha.ae7edb.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/codebytes@0.0.2-alpha.e3edfc.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/codebytes@0.0.2-alpha.518af8.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/codebytes@0.0.2-alpha.d83a50.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/codebytes@0.0.2-alpha.c5fa0c.0@codecademy/styleguide@0.0.2-alpha.c5fa0c.0


firebase-admin-node needs to declare a dependency on @types/google-cloud__storage

[REQUIRED] Step 2: Describe your environment

Operating System macOS 10.13 (High Seirra)
Firebase Admin Node 5.3.0
Firebase Product: Firebase Functions

[REQUIRED] Step 3: Describe the problem
firebase-admin needs to declare a dependency on @types/google-cloud__storage for TypeScript projects.
Steps to reproduce:

Define a Typescript project which depends on firebase-functions.
Install the firebase-admin node package (peer dependency)
tsc fails with this error.

  Try `npm install @types/@google-cloud/storage` if it exists or add a new declaration (.d.ts) file containing `declare module '@google-cloud/storage';`

We declared @types/google-cloud__storage as a dev dependency since it never gets referenced during actual runtime. We have been asking TypeScript developers to install it separately as needed. But perhaps we should make it a regular dependency so the TypeScript developers get a better experience out of the box.

That would be awesome. It's easy enough to install it. But consumers should not have to install types that are a dependency for firebase-admin-console as this list of types increase.

Does your code make any references to Cloud Storage types? Perhaps you can post your package.json and a code snippet?

{
  "name": "...",
  "version": "...",
  "description": "... Backend",
  "main": "built/index.js",
  "scripts": {
    "start": "node_modules/.bin/tsc",
    "watch": "node_modules/.bin/tsc --watch",
    "setupProject": "node_modules/.bin/functions-emulator config set projectId ...",
    "create": "node_modules/.bin/functions-emulator deploy ... --trigger-http",
    "search": "node_modules/.bin/functions-emulator deploy ... --trigger-http",
    "start-emulator": "yarn start && node_modules/.bin/functions-emulator start",
    "stop-emulator": "node_modules/.bin/functions-emulator stop && node_modules/.bin/functions-emulator stop"
  },
  "keywords": [
    "...",
    "..."
  ],
  "author": "rahulrav",
  "license": "MIT",
  "dependencies": {
    "@types/node": "^8.0.31",
    "@types/node-uuid": "^0.0.28",
    "@types/request": "^2.0.3",
    "firebase-admin": "^5.3.0",
    "firebase-functions": "^0.6.3",
    "node-uuid": "^1.4.8",
    "request": "^2.83.0",
    "typescript": "^2.5.3"
  },
  "devDependencies": {
    "@google-cloud/functions-emulator": "^1.0.0-alpha.25",
    "@types/google-cloud__storage": "^1.1.5"
  }
}

This is what it looks like. I redacted a few uninteresting parts.
I had to add @types/google-cloud__storage to my list of devDependencies for the compiler to be happy.

This should be fixed v5.4.0 and up.


Default Apache mirror for Zookeeper doesn't store previous versions

I believe this cookbook should not throw exceptions if the the required version of Zookeeper wasn't found in the stable mirror. Instead it should search for it in the archive: https://archive.apache.org/dist/zookeeper/
================================================================================
Error executing action `install` on resource 'ark[zookeeper]'
================================================================================

Net::HTTPServerException
------------------------
remote_file[/var/chef/cache/zookeeper-3.4.10.tar.gz] (/var/chef/cache/cookbooks/ark/providers/default.rb line 41) had an error: Net::HTTPServerException: 404 "Not Found"

Cookbook Trace:
---------------
...

Resource Declaration:
---------------------
# In /var/chef/cache/cookbooks/zookeeper/resources/default.rb

 69:   ark 'zookeeper' do
 70:     url         "#{mirror}/zookeeper-#{new_resource.version}/zookeeper-#{new_resource.version}.tar.gz"
 71:     version     new_resource.version
 72:     prefix_root install_dir
 73:     prefix_home install_dir
 74:     checksum    new_resource.checksum if new_resource.checksum
 75:     owner       username
 76:     group       username
 77:   end
 78:

Compiled Resource:
------------------
# Declared in /var/chef/cache/cookbooks/zookeeper/resources/default.rb:69:in `block in class_from_file'

ark("zookeeper") do
  action [:install]
  retries 0
  retry_delay 2
  default_guard_interpreter :default
  declared_type :ark
  cookbook_name "exhibitor"
  url "http://apache.mirrors.tds.net/zookeeper//zookeeper-3.4.10/zookeeper-3.4.10.tar.gz"
  version "3.4.10"
  prefix_home "/opt"
  prefix_root "/opt"
  owner "zookeeper"
  group "zookeeper"
  extension "tar.gz"
  prefix_bin "/usr/local/bin"
  home_dir "/opt/zookeeper"
  path "/opt/zookeeper-3.4.10"
  release_file "/var/chef/cache/zookeeper-3.4.10.tar.gz"
end

Platform:
---------
x86_64-linux

Sorry, I missed the repo. The issue must be here: https://github.com/evertrue/exhibitor-cookbook/


Error when starting Flow Launcher

Hi
I was referred to you after having opened an issue over at Flow Launcher.
The error below happens everytime FL starts. ClipboardR is version 0.3.1.

Please open new issue in: https://github.com/Flow-Launcher/Flow.Launcher/issues

upload log file: C:\Users...\AppData\Roaming\FlowLauncher\Logs\1.18.0\2024-05-29.txt
copy below exception message

Flow Launcher version: 1.18.0
OS Version: 22631.3593
IntPtr Length: 8
x64: True
Python Path: C:\Users...\AppData\Roaming\FlowLauncher\Environments\Python\PythonEmbeddable-v3.11.4\pythonw.exe
Node Path:
Date: 05/29/2024 11:19:32
Exception:
System.NullReferenceException: Object reference not set to an instance of an object.
at ClipboardR.ClipboardR.Save()
at Flow.Launcher.Core.Plugin.PluginManager.Save() in C:\projects\flow-launcher\Flow.Launcher.Core\Plugin\PluginManager.cs:line 58
at Flow.Launcher.PublicAPIInstance.SaveAppAllSettings() in C:\projects\flow-launcher\Flow.Launcher\PublicAPIInstance.cs:line 84
at Flow.Launcher.PublicAPIInstance.RestartApp() in C:\projects\flow-launcher\Flow.Launcher\PublicAPIInstance.cs:line 64
at Flow.Launcher.Plugin.Sys.Main.b__16_12(ActionContext c) in C:\projects\flow-launcher\Plugins\Flow.Launcher.Plugin.Sys\Main.cs:line 337
at Flow.Launcher.Plugin.Result.ExecuteAsync(ActionContext context) in /_/Flow.Launcher.Plugin/Result.cs:line 246
at Flow.Launcher.ViewModel.MainViewModel.OpenResultAsync(String index) in C:\projects\flow-launcher\Flow.Launcher\ViewModel\MainViewModel.cs:line 307
at CommunityToolkit.Mvvm.Input.AsyncRelayCommand.AwaitAndThrowIfFailed(Task executionTask)
at System.Threading.Tasks.Task.<>c.b__128_0(Object state)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
2024-05-29.txt

Deactivating the plugin also does not work, you get the error message all the same.


Created assets folder as mentioned in the Issue

As suggested in the issue, I created assets folder and made separate folder in it for images, css and js Also did the required changes in the code. Currently the site is working fine like before

Thank you so much for contributing!

Hey I had to revert it because as I merged the PR it broke something, maybe you missed few files or in few lines, I couldn't see the background or the GIFs of planets

Maybe deploy the branch you're making changes on GitHub pages and check it. Then I can merge it sooner


Added error messages (and config.php)

Hey,
I was confused on my server if the cpu load was queried correctly or if it showed 0 because of an error (turns out it really was avg zero over the last 15minutes).
So I added error messages that get displayed when commands fail:

To do this I moved quite a bit of your code around, I hope that was ok :D.

All system information gathering is now in methods in system.php
The file swmp.php is pretty much only calling these functions
The few extra functions from mainclass.php are now in utils.php as normal methods (getHumanTime, getSize, etc)
I removed a bit of the json_encode decode stuff, some values where two times encoded and then in js again decoded. But JSON is already valid javascript (the JS stands for javascript :D) so you can directly print them into the js code.

I also added a config.php / config.local.php where it is possible to disable the shown errors and set the theme. This is useful when the code is automatically updated via git, because otherwise the theme changes in index.php will always get overriden (this ways config.local.php is not in the git repo and does not get overriden).
Thats quite a cool project, if you have any problems with my changes just say it - perhaps I can do it better/different.
Greets
~ Mike
PS: Perhaps wait with merging until tommorrow, I want to test my changes a bit more but for today it's too late for me :)

Hey @Mikescher!
This is awesome! I did think about implementing some sort of error display but didn't get round to it, I even started making a configuration file and gave up after some hurdles so the fact that you have done both is nice! haha
However, this was submitted the other day and I don't know the situation with it so I can't just merge yours without taking into consideration others major code changes also.
https://github.com/fuzzymannerz/swmp/issues/3 - @daison12006013
The two code changes of both you guys would most likely conflict with each other so maybe you could work something out with what you both have already and implement it into one pull request? :)

Hey @Mikescher, please sync merge the updates buddy and maybe fix the updates I did.
@fuzzymannerz, buddy, you don't need to close an issue or PR automatically, we should mostly close those if not necessary, this PR can still fix by @Mikescher once he applied a merge to the master itself.

@daison12006013 Very good point, re-opened! :+1:

Okay, stuff is merged and everything seems ok.
From my POV iit's ready to be merged.

@Mikescher Nice one man! :grinning:


proposal: net/http: Expose underlying Conn in http.ResponseWriter?

I'd like to be able to mark the outgoing response packets with TOS values to support QOS based on different incoming client requests.  Would it be reasonable to expose the Conn in http.ResponseWriter?  Or perhaps enable some other way to support TOS?

CC @bradfitz

I'd rather not expose the conn. It leads to people being too clever and messing with the stream.
I think this is a bizarre enough requirement (I've never head of anybody ever setting TOS based on the HTTP request) that it's not worth supporting directly. I think you can just write a net.Listener implementation that tracks the underlying TCP conn fds, returns a RemoteAddr() that net/http puts in stringified form in Request.RemoteAddr, then an http.Handler wrapper which unwraps that RemoteAddr string to find the TCP connection and resets RemoteAddr to its usual form.
It sounds kinda hacky, but so is the original problems, so it seems fitting.


remove obsolete ist0 handling

IST0 isn't used by common interrupt. Just to close the session.
=> don't create IST0 for every task, just for every core

bors try

bors r+


Where is BDBOAuth1RequestOperationManager?

This class is not included the pod anymore.

AFNetworking removed support for NSURLConnection-based APIs in version 3.x, which is used by version 2.x of this library. (AFNetworking 3.0.0 release notes, PR) If you need support for NSURLConnection-based APIs, you'll have to use AFNetworking 2.x and version 1.x of this library.


No license set for the project

There is no license set for this project's source code. There is not tons of code, and it's relatively straight forward, but could you please set a license to avoid any ambiguity. I suggest MIT or Apache2

Agreed, this is very important as currently, theoretically nobody can safely use your project :)
https://help.github.com/articles/open-source-licensing/#what-happens-if-i-dont-choose-a-license
Also, I love MIT!

MIT License added
Thanks for the feedback

Amazing, thanks :)


Unrecognized app. Please make sure you trust this app before proceeding #455

Log {"signature":"MEQCICzhmoYWxb4vG9IHzEEilfkKGSNCD78ZvglqnohA2rq5AiAow/fRv340jiXNl1tpJryIAT4/S7QNikKB8PNdVsSZPg\u003d\u003d","protocolVersion":"ECv1","signedMessage":"{"encryptedMessage":"iv4J1uBmZGsNO4UJw4JYRmwJyf2TTf1KWO1KWTUm/k+0h4GXIU3a3mtoSYOv8vsT81bdRJGmUdPw4m3RFMzp7aQcSaT0nYImgHKcd4ikmOOPI3xMoxg8akhFR4tVjdUB4+D1E03J8QwUKn69DLKKiB+2vCztVXuM1XaEEdWYt6vy0d2u9rMgEf+CvuwJu9eDNsidaHGp95BzfNn0O7yVehKrSnW2G2AbaMjylKWbZ+EsGqulpx+lqrs5//TnNt/nWb6G6/WsYCcDXpkpDPu/ipavvEjVThqmQObJPdJxIPYR9FjCjyJvkffctZshJdUYHSu5ZR1qTJW7USB35EmkFb40Uam8Jg5PvbqxxsioQ8jeQkKQdZsUu6MBk8byHEoAjAvv/rVZ4yE0fJeNw3y5Hn3RIY3VtJx1prm740av614eJfLCl7apy01et57TKDzD5AZuHTIx1gLADlU\u003d","ephemeralPublicKey":"BHV/YrV7zcP31132pWiri3hw4k9Z48v4s4KV4w5m3XBGEa27rCcH3v6Sfqxn2J4bSTHDp3i54A3d9KAlVwNIkcc\u003d","tag":"hIaXJ1/0xwN2YXYF84twoQm5OZWSt6KA55Ttn12b8g4\u003d"}"}}, type: CARD, info: {
I/flutter (23619): VISA, cardDetails: 5111, billingAddress: {phoneNumber: +91 93255 09271, address3: , sortingCode: , address2: 5, countryCode: IN, address1: Na, postalCode: 413504, name: vaibhav mali, locality: Pune, administrativeArea: Maharashtra}}}}

Hello @vaibhavmali123, I'd recommend to avoid including full production responses publicly.
The message you are referring to appears when you operate in TEST mode (take a look at the troubleshooting guide). You can get your application approved for production through Google Pay's Business Console.


Fix support for "module": "node16"/"nodenext"

With "module": "node16" and "module": "nodenext", look at package.json to determine whether module type is es6 or commonjs. Previously, these values would unconditionally be treated as es6.
https://github.com/songkeys/tsconfig-to-swcconfig/issues/23

There is one test failing. Could you fix it?

should output module:es6 if the nearest package.json is of type:module

I think we should edit the "module" field to "node16" or "nodenext" of tsconfig in fixtures to make this test true.


Team view shows the wrong teams

Redo logic. Rewrite controller/model function, less logic in controller/view.

Fixed in latest commit.


Soup up the 'empty storage' button

The "empty storage" button on the Storage panel of the Item Manager is now disabled unless:

You are not in Hardcore
You are not in Ronin
You actually have items in Storage

Leaving Hardcore or Ronin (via freeing the king, for example) will fire a state change which will make the button enable itself.
New CLI command - test toggle {ronin|hardcore} - let me test that functionality.
Additionally, the StorageRequest now forbids the EMPTY_STORAGE action if you are in Ronin.
I rationalized the run() method of StorageRequest. I also wrote tests for all seven cases that will cause that method to abort without submitting a request to KoL.

And now I have souped the response text parsing to notice "You already pulled one of those today" and add the corresponding item to the roninStoragePulls set.


Please tag release 2.5 (or 2.4.1)

I need your PHP v5.4 compat fixes, but don't want to use dev-master in my project's composer for your library (I don't want to fork your master either; I'm lazy). Thanks =)
Thanks for the shout-out for lifo/typeahead-bundle, btw. =)

Done.  2.5
Sorry, I should have done that earlier.

awesome, thanks


Submitting Blank "Available Corporation" in Corporation Filter Causes Server Error

Summary
Inadvertently omitting to choose a corporation in the "Corporation Filter" when creating a SeAT group causes an Internal Server Error.
Discussion
Looks like the input for the "Corporation Filter" in "Available for Whom" doesn't sanity check for missing input and then tries to do something with that missing input. Oops!
At least it should be a simple fix.  Next release will include this again


kaptKotlin failed when invoke fetchSourcePath in CodeGenProcessor

Version
4.0.0-milestone5
Context
I encountered an exception which looks suspicious while gradle execute kaptKotlin.
A Gradle build scan is available here.
Caused by: java.nio.file.InvalidPathException: Illegal char <:> at index 2: /C:/workspace/moumoux/Outles/build/tmp/kapt3/classes/main/PathForCodeGenProcessor.class
at io.vertx.codegen.CodeGenProcessor.fetchSourcePath(CodeGenProcessor.java:152)
at io.vertx.codegen.CodeGenProcessor.loadJsonMappers(CodeGenProcessor.java:197)
at io.vertx.codegen.CodeGenProcessor.init(CodeGenProcessor.java:67)

Do you have a reproducer?
A reproducer is a simple project hosted on GitHub (or another forge supporting git clone operation) that has a build file that can be executed to reproduce the issue.
Reproducers are very helpful for contributors and will likely help them fixing your bug faster.

https://github.com/Project5E/outlets

Steps to reproduce

clone it on Windows 10 with a Java8 env
./gradlew.bat build

Extra
Build on Linux is successful

Env
Name

Operating system
Windows 10 10.0

CPU cores
6 cores

Max Gradle workers
6 workers

Java runtime
Eclipse OpenJ9 OpenJDK Runtime Environment 1.8.0_265-b01

Java VM
Eclipse OpenJ9 Eclipse OpenJ9 VM openj9-0.21.0 (mixed mode)

Max JVM memory heap size
536 MB

Locale
Chinese (China)

Default charset
UTF-8

fixed in Beta.1


x/website/internal/dl: include docs on how to init datastore or memcache dependencies

I am trying to make changes to the /dl page, but this page requires the ability to pull data from a memcache or Cloud datastore in order to render the page contents, and it does not look like there is documentation on how to put the necessary data in the Cloud datastore.

/cc @dmitshur

Unrelated to documentation, please be sure to discuss changes to the /dl page in an issue first.

My idea was to try to fall back to loading the release history from internal/history if the datastore is not initialized, but everything seems too tightly coupled to google cloud to make that work.

As of CL 362496 (CC @rsc), a copy of live server data is embedded in the golangorg binary, allowing the go.dev/dl/ page to be rendered and developed locally without needing to set up a datastore or memcache client. With that, I think this issue is resolved.


Read all GO terms in gaf file, and not just BP terms.

Hi, I am opening a new issue relating to this request https://github.com/tanghaibao/goatools/issues/75#issuecomment-505065958.
Is possible to read all GO terms not just BP ? For example, in the read_gaf, there is a namespace="BP", is possible to have an option namespace="all" ?
Thanks.

Hello @datduong,
Thank you for taking your time to open this issue. We have this functionality, but accessing it certainly could be more user-friendly.
Now, if you add an argument, namespace=all, to read_gaf or any of the annotation readers function, get_id2gos, you will get all namespaces (BP, MF, CC) in one id2go dict.
from goatools.base import get_godag
from goatools.anno.factory import get_objanno

godag = get_godag('go-basic.obo')

id2gos_ncbi = get_objanno('gene2go', taxid=9606).get_id2gos(namespace='all')
id2gos_gaf = get_objanno('goa_human.gaf').get_id2gos(namespace='all')
id2gos_gpad = get_objanno('goa_human.gpad', godag=godag).get_id2gos(namespace='all')
id2gos_orig = get_objanno('data/association', 'id2gos', godag=godag).get_id2gos(namespace='all')

Great, thanks for the quick reply. I will close issue.


Malformed crashdump causes OOM by allocating far too much memory

On the base64 decoded data of TURNUJOnAAAA/2ZmZFlmZmZmZkAKCmZwCrv///8K/wo=, it OOMs when parsing through the minidump::Minidump::read(data) method, and when running minidump-stackwalk (version 0.9.6), I get
# minidump-stackwalk crash.txt
memory allocation of<PHONE_NUMBER>4 bytes failed
zsh: abort (core dumped)  minidump-stackwalk crash.txt

I think this is related to https://github.com/luser/rust-minidump/issues/326.
Also ❤ @5225225 I also saw your https://github.com/getsentry/symbolic/issues/476 which shows a very similar issue.

Yeah, both this crate and symbolic seems incredibly underfuzzed (as in, not at all) considering what they're doing.
I wouldn't expect any RCE or anything, it's Rust, not $memory_unsafe_language, but still, it would be nice if whatever processes crashes doesn't crash itself :D


Add --no-clean flag

cargo-llvm-cov cleans some build artifacts by default to avoid false positives/false negatives due to old build artifacts.
This behavior is disabled when --no-clean, --no-report, or --no-run is passed, and old build artifacts are retained.
When using these flags, it is recommended to first run cargo llvm-cov clean --workspace to remove artifacts that may affect the coverage results.
cargo llvm-cov clean --workspace # remove artifacts that may affect the coverage results
cargo llvm-cov --no-clean

Closes #198 (In the long term I want to remove the need for these clean, but it is not easy.)

bors r+


Build failing on repo with Julia 0.6, NoneType object has no attribute get

I am trying to build the following repo:
https://mybinder.org/v2/gh/tpoisot/ScientificComputingForTheRestOfUs/master
It was working up until last week-ish.
When I try now, the build fails, and the only message I get is:
Error during build: Build failing on repo with Julia 0.6, NoneType object has no attribute get

The notebooks run on multiple machines locally.

This is probably a problem in repo2docker (https://github.com/jupyter/repo2docker). If you want to debug a bit more yourself you can install repo2docker locally and see the Dockerfile it generates and watch the build process. repo2docker is the tool mybinder.org uses to build.
I'd suggest we move the issue to the repo2docker repository for longer term tracking, Is that Ok with you?
(While this doesn't look like an error related to load, mybinder.org is experience a lot of load from the jupyterlab announcement, so trying to build locally would be a good way to exclude "weird failure due to load".)

hey all - any movement on this? Looks like it was a repo2docker bug but I don't see an issue in that repository of the same nature...

Looks like the issue is the fact that there is an empty environment.yml. Is there a reason there's an empty file instead of no environment.yml at all?


Documentation specifies 'run_on' when it should use 'runs_on'

Component
other
Describe the bug
The multi-pipeline documentation says run_on can be used to allow a pipeline to run even if a dependent pipeline has failed:
pipeline:
  task2:
    ...
depends_on:
  - task1
run_on: [ success, failure ]

While testing this I discovered that the tag is actually runs_on.
System Info
{"source":"https://github.com/woodpecker-ci/woodpecker","version":"0.15.1"}

Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

I forgot to include a link to the repo where I tested this.
https://github.com/fracai/woodpecker-test

thanks for finding this docu bug :+1:


fix: Make Translation-module admin_info configurable

Currently, the translation module is shown in every project using viur-core 3.6. By default, it should be non-visible, and at least, it is a part of the admin tool. Nevertheless, the possibility of hiding or entirely omitting it should be given.

@sveneberth see #326dd18 for an updated implementation.