Fix codecov

The output from Travis builds to codecov.io is not working. No test results are showing up at codecov. My suspicion is that it has to do with paths of files, as that is one of the things codecov says can go wrong: https://docs.codecov.io/docs/fixing-paths.
This seems to be backed up by Travis output:
../setup.py ...                                                          [  6%]
../plugins/__init__.py ...                                               [ 13%]
../plugins/tex_discovery_plugin/__init__.py ...                          [ 20%]
../plugins/tex_discovery_plugin/tex_discovery_plugin.py ...              [ 27%]
../plugins/tex_tool_plugins/__init__.py ...                              [ 34%]
../plugins/tex_tool_plugins/chktex_tool_plugin.py ...                    [ 41%]
../plugins/tex_tool_plugins/lacheck_tool_plugin.py ...                   [ 48%]
../tests/chktex_tool_plugin/test_chktex_tool_plugin.py ........          [ 67%]
../tests/lacheck_tool_plugin/test_lacheck_tool_plugin.py ........        [ 86%]
../tests/tex_discovery_plugin/test_tex_discovery_plugin.py ......        [100%]

That shows the path to the files relative to the repository structure. However, when determining line coverage the output is:
/home/travis/build/tdenewiler/statick-tex/.tox/py27/lib/python2.7/site-packages/statick_tool/plugins/discovery/tex_discovery_plugin.py      38      1    97%   27
/home/travis/build/tdenewiler/statick-tex/.tox/py27/lib/python2.7/site-packages/statick_tool/plugins/tool/chktex_tool_plugin.py             54      0   100%
/home/travis/build/tdenewiler/statick-tex/.tox/py27/lib/python2.7/site-packages/statick_tool/plugins/tool/lacheck_tool_plugin.py            53      0   100%

For some reason the line coverage is being determined relative to the .tox directory. This might have something to do with the remapping done to the files in setup.py.
I tried creating a .codecov.yml file that has mappings to fix the paths. The few patterns I tried did not work.

This seems to have been automagically fixed by #15.


2i2c Service Outage for Openscapes Hub

Hi @yuvipanda - I added a comment to our closed issue, but wanted to make sure you all saw this. We are getting a service outage on our hub. Is this an issue on your side or something we troubleshoot?

@erinmr taking a look now!

@erinmr can you try now? Should be fixed

The hub is working for me now.

Thank you so much, @yuvipanda! It's working for me too

Thanks for reporting it here, @erinmr! Glad we could get it sorted. We'll write an incident report soon


Indentation shortcut not working

Many editing shortcuts are working, but the following indentation related (which I use a lot) shortcuts are not working for me:

Decrease Indentation | Cmd/Ctrl Shift M
Increase Indentation | Cmd/Ctrl Alt K

My tusk is installed from AUR on Arch Linux. I'm using yinxiang.com. Thanks for looking into it in advance.

Same issue, but using ubuntu 18.04.3 LTS installed using snapcraft and using evernote web stable version.


Update tests for latest PL release

Fix eco-system failures with PL latest release.

CI is red

In fact, tensorboard pins a really old version of protobuf:
# See: https://cs.opensource.google/tensorflow/tensorflow/+/master:tensorflow/tools/pip_package/setup.py?q=protobuf
protobuf >= 3.9.2, < 3.20

Related:

https://github.com/Lightning-AI/lightning/pull/13189
https://github.com/Lightning-AI/lightning/pull/13177
https://github.com/Lightning-AI/lightning/issues/13159

@rohitgr7 I think you need:
protobuf >= 3.9.2, < 3.20

See my comments above, or my branch.


JPype should populate doc on exposed Java methods

We use JPype in combination with Jupyter notebooks, and one thing we noticed is the doc string is not correctly populated for Java methods; as a result the online help() function does not correctly describe the interface. It would be very useful to add this to allow proper introspection of Java interfaces in Jupyter.

Do you mean producing __doc__ strings from javadoc?  If so I don't think that is currently possible.  Java does not by default compile the javadoc into the jar file.  Of course it you just mean give me a table of the signatures for the interface, that may be doable.
I tried once to just use reflection to generate __doc__ to give me the types of the arguments and the overloads, but that means that the __doc__ would need to act as a property so that it could be generated on demand.  Like generating the signatures #297, one just needs to figure out how to convince python to call a function that would populate it.  Assuming that we could get Python to look it up rather that trying to take the value from the slot, I can then add a new hook to setResource that would provide improved output.
I am going to place this on the requested enhancement list.  Perhaps I will give it another attempt this evening to see if it is technically possible to dynamically generate these properties.  I have gotten a bit better at tracing into CPython paths so maybe it will go more smoothly this time.  It would be very nice to have better looking docs and autocomplete.

All we are interested in is an accurate description of the method, parameters and return type; extracting javadoc is not necessary. Ideally it should leverage / extract as much of the generic type info as possible.

Python has not made this easy.  Here is the __doc__ property on types.
static PyObject *
type_get_doc(PyTypeObject *type, void *context)
{
    PyObject *result;
    if (!(type->tp_flags & Py_TPFLAGS_HEAPTYPE) && type->tp_doc != NULL) {
        return _PyType_GetDocFromInternalDoc(type->tp_name, type->tp_doc);
    }
    result = _PyDict_GetItemIdWithError(type->tp_dict, &PyId___doc__);
    if (result == NULL) {
        if (!PyErr_Occurred()) {
            result = Py_None;
            Py_INCREF(result);
        }
    }
    else if (Py_TYPE(result)->tp_descr_get) {
        result = Py_TYPE(result)->tp_descr_get(result, NULL,
                                               (PyObject *)type);
    }
    else {
        Py_INCREF(result);
    }
    return result;
}

Rather than giving a call to GetAttr, they directly consult only the slot and the hardwired dictionary slot.    Thus I will have to make a dict on methods to provide this feature.  It can be a property as they allow for descriptor.   But there is no provision to get the object instance that I see.  It is clear they never intended for an object to be able to supply a __doc__ dynamically.  Perhaps it is possible to intercept the process earlier in process.

Okay I think I figured it out.   Adding the attribute __doc__ to the tp_getset lets me catch the request and redirect it to another method.  Now I just need to create a resource hook and point back to python where we can generate the doc string.

@kyle-downey I assume #478 is along the lines of what you are looking for.  If you have alternative fields/formatting that you would like to see, please post it to this thread or submit a pull request.

Hi @Thrameos this looks good -- we are going to make a cut and try it out on Monday morning and will let you know if any issues. Thanks for the quick turnaround!

This worked well, thanks @Thrameos. We did notice two bugs in the patch:
(1) _jclass.py like 499 has a typo, variable name should be fieldInfo
(2) when a method is overloaded and has different return types, e.g. String#getBytes() is a good example because it returns both byte[] and void, the reported returns document should probably be dropped; right now it seems to just pick the first return type

The typo on line 499 was corrected in a later commit.
The behavior for mixed returns was to list all with the exception of void.  Thus if it were byte[] and void it would list just byte[] as the result would be "byte[]" or "None" which "byte[]" is a type of thus the documentation would be correct.  If it were byte[] and int[] it would list both.   The intention of this was to keep void from producing a return statement and as void isn't a return type but the result None would be.  Thus the behavior is as was intended.  The test case you selected just happened to be the corner case in which the void was dropped.
Here are examples of a few cases:
Mixing with void gives everything but the void.
Java method dispatch 'getBytes' for 'java.lang.String'

  Virtual Methods:
    * void getBytes(int, int, byte[], int)
    * byte[] getBytes(java.nio.charset.Charset)
    * byte[] getBytes(java.lang.String)
    * byte[] getBytes()

  Raises:
    java.io.UnsupportedEncodingException: from java

  Returns:
    byte[]

Void only lists nothing.
Java method dispatch 'wait' for 'java.lang.String'

  Virtual Methods:
    * void wait()
    * void wait(long, int)
    * void wait(long)

  Raises:
    java.lang.InterruptedException: from java

Return with multiple types (except void) list all.
Java method dispatch 'remove' for 'java.util.Map'

  Virtual Methods:
    * java.lang.Object remove(java.lang.Object)
    * boolean remove(java.lang.Object, java.lang.Object)

  Returns:
    boolean, java.lang.Object

I debated trying to add a reference to the javadoc as a http link for java.lang based classes, but didn't have time to work through it.  Also if the javadoc jar for the package is in place we could link to it instead.  If you have an improvement to the doc generator, please submit a pull request.


Expansion Panel Header gets hidden

This problem is raised by the testing team. header gets hidden when they try to find some text by selenium xpath. It should be highlighted instead of getting hidden.
Before -

After i search 'textToFind' from developer console by using the command -
//span[contains(text(),'textToFind')]
then expansion panel header gets hidden

Can you share the stackbBlitz code link ?

Yes, Sure
https://stackblitz.com/edit/angular-czakrt

Can anyone help me with the solution. Testing team is sitting idle waiting for it to get resolved.
I have heavily used expansion panel in my project

It looks like this is actually occurring because when the browser "finds" the text in the expansion panel body, it pushes the expansion panel header up.  Since the expansion panel has overflow: hidden, the header text is "above" the expansion panel header container, and the expansion panel body is within the header container, but visibilty: hidden is still applied to it.

Closing this since I believe that this isn't a bug that would affect human use of the component, and the official test harnesses can be used to interact with the component in tests


Adding KS css and js as Drupal libraries

This ensures we can just add the kalastatic library in themes/pages and we'll know we're getting it all rather than adding individual files.

This makes the default KSTAT path to /kalastatic.


GEMINI: Cancel all active orders

cancelAllOrders would  be a better name IMO.

@timmolter I'll open another PR to modify the method names later today, looks like I missed the boat :(

Didn't realize you already took care of it. Thanks @timmolter!


storeAPI: Extend ExternalLabels Selector for LabelsNames and LabelValues

This would be really awesome for further multi-tenancy support with https://github.com/prometheus-community/prom-label-proxy
Since tenants never share the same TSDB block or DB we can easily allow LabelValues and LabelNames API selection support for tenant's data.
The only open question is compatibility. Do we want extra check to ensure if server supports this or not? Without such check we know nothing: The lack of selection might be transparent causing tenant data leak.
cc @pracucci @brancz @yeya24 @kakkoyun

I think this would be best solved with a combination of https://github.com/prometheus/prometheus/issues/6178 and support for enforcing a matcher for this API in prom-label-proxy.

Nice, the only problem - or rather a potential improvement I can see here is that we can do it much faster IF the selectors match external label. But we can implement that easily indeed.

Yeah sounds pretty much equivalent to labelset in series queries ("definitely not in set").

:+1: :+1:

Hi, I am looking at the implementation at https://github.com/prometheus/prometheus/pull/7496.
For labels query with matchers, it actually send a Series call first and filters the labels from the series sets.
Do we want to do the same thing in Thanos? It should work but is performance a problem (though we support skip-chunk) ?

@yeya24 have we validated that it is indeed a problem performance wise? I can see what you mean of course, just want to make sure we base this on measurements and not fear :)

@yeya24 have we validated that it is indeed a problem performance wise? I can see what you mean of course, just want to make sure we base this on measurements and not fear :)

You are right and I haven't benchmarked it.
We can do a Series based version first to get this feature working.
After Prometheus supports these matchers in the TSDB level, we can change our code and do the matchers push down to leaf nodes.


OS X: dialog.showMessageBox: icon option does nothing

I've tried both passing the result of nativeImage.createFromPath('/Users/adam/Desktop/x.png') and just the string path as the icon but it's still just the Electron icon;

@zcbenz I see you added the bug label but could you confirm if the two things I tried would be ok if there wasn't a bug? I mean: if it was working, could I pass a string or the result of nativeImage.createFromPath(filePath)? Thanks.

It is a bug that the icon option doesn't work on OS X. Passing image's path as string or the NativeImage instance should both work.

:+1:


Definition of 'SAMKeychain' must be imported from moudule 'SAMKeychain.SAMKeychain' before it is required

How to solve this problem

try #import <SAMKeychain/SAMKeychain.h>


upgrade protobuf-java and jackson-databind

Signed-off-by: Kaushal Kumar<EMAIL_ADDRESS>Is your feature request related to a problem? Please provide an existing Issue # , or describe.
This change is to protobuf-java and jackson-databind as we are upgrading these packages in the PA plugin package as well.
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List

[ ] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #242 (7acc905) into main (c94afaf) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #242      +/-   ##
============================================
- Coverage     71.53%   71.53%   -0.01%
+ Complexity     2987     2986       -1
============================================
  Files           380      380
  Lines         18952    18952
  Branches       1463     1463
============================================
- Hits          13558    13557       -1
- Misses         4798     4799       +1
  Partials        596      596

Impacted Files
Coverage Δ

...performanceanalyzer/collectors/StatsCollector.java
92.59% <0.00%> (-0.75%)
:arrow_down:

...nsearch/performanceanalyzer/rca/RcaController.java
80.61% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

The tests are failing due to apache http utils package which will be merged once the CVE-42003 PR or CVE-3171 PR are approved.


[Monaco] Make minimap toggleable

Summary of the Pull Request
Adds the option to toggle the minimap for file preview (Peek and Preview Pane)

PR Checklist

[x] Closes: #33471
[x] Communication: I've discussed this with core contributors already.
[x] Tests: Added/updated and all pass
[x] Localization: All end user facing strings can be localized
[x] Dev docs: No need
[x] New binaries: None
[x] Documentation updated: No need

Detailed Description of the Pull Request / Additional comments
Adds a setting to Peek and File Explorer add-ons to toggle the Monaco minimap. Disabled by default. Also adds a context menu item to Monaco to toggle the minimap (doesn't work in Peek, but that is a different issue).
Validation Steps Performed
Testing Peek and Preview Pane

/azp run

@PesBandi
Please merge main in, fix the conflicts and update your code changes.

Hi @htcfreek, is there anything blocking this? If yes, is there anything I can do to help it. I'd like to get this merged before something else breaks it again :)

@PesBandi
Don't think so. But unfortunately it's not on me to do the final review and merge.
@crutkas , @jaimecbernardo


feat(sdk): add bucket resource type, modify the schedule, function source type

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

2. What is the scope of this PR (e.g. component or file name):

SDK

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

Bucket resource type added, currently only supports AWS S3.
Schedule resource type adapted for Python, enabling periodic tasks such as rebuilding the vector store for RAG applications.
Function resource type now includes a memory option to specify instance memory size.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[x] Other

PR conflict


Not able to send json data in body

I would like to execute hey with following params:
hey -m POST -T "application/json" -H "Authorization: Key XXX" -d '{"x": 0, "y": 1}' server-url

But the server receives following header and body:
Header:
'Authorization': 'Key XXX'
'Transfer-Encoding': 'chunked'
'User-Agent': 'Go-http-client/1.1'
'Host': 'server-url'
'Content-Type': 'application/json'
'Accept-Encoding': 'gzip'

Body:
'' (empty string)

What am I doing wrong? :) Why is the body not sent to the server?
I've checked how curl does it and cannot see the problem.
Thanks.

Sry, I've just found that it's the same as #36, will move it there.


FIXED - issue : validationInput fails if onChangeText is undefined

FIXED - issue : validationInput fails if onChangeText is undefined

Thanks! 👍


Telegram Settings added

to fix Telegram crashing the bot

👍

@Xairooo did you mean to post this to master?

sorry was a misstake


Client crash with handheld modular storage on opening.

http://pastebin.com/gX5rb1sf
This happened during worldgen lagspikes, might be related.

I'll check it out

I'm getting a similar crash with a standard t3 modular storage, no other cards
https://hastebin.com/avazamucep.sql
I did have some recipes saved in it before the crash.

This seems to be caused by some mod adding a 'null' recipe for something. I'll add code to protect against this but essentially the bug is not in rftools.
Also added a fix for the first bug. Both crashes are unrelated btw.

Not sure it was a mod that added it, I tried to clear out the inventory slot in the first slot and basically set a null recipe, so rftools itself let me set that, which I guess caused the issue?

Not sure. That's not where it crashed though. But anyway next release should fix the crash


Fix psalm assert

Dockblock allIsInstanceOf method replaces the type for Psalm.
Create class:
$integrationEvent = KppExpertiseCreated::createFromBody([
    'attachments' => array_map(function (CaseAttachment $attachment): Attachment {
        return new Attachment(
            $attachment->getId(),
            $attachment->getName(),
            $this->urlGenerator->generate('files.read', ['id' => $attachment->getResourceId()]),
        );
    }, $case->getAttachments()),
]);

$this->dispatcher->dispatch([$integrationEvent]);

public static function createFromBody(string $id, DateTimeImmutable $datetime, array $body): AmqpEvent
{
    Assert::allIsInstanceOf($body['attachments'], Attachment::class);
    $event->attachments = $body['attachments’];
    return $event;
}

Error:
ERROR: InvalidPropertyAssignmentValue - src/Integration/App/Listener/Estimation/Expertise/Event/KppExpertiseCreated.php:48:31 - $event->attachments with declared type 'array<array-key, App\Integration\App\Listener\Estimation\Expertise\Event\Attachment>' cannot be assigned type 'iterable<array-key|mixed, App\Integration\App\Listener\Estimation\Expertise\Event\Attachment>' (see https://psalm.dev/145)         $event->attachments = $body['attachments'];
When using @psalm-assert array<ExpectedType> $value, the error disappears

Have you tried to do like this?
public static function createFromBody(string $id, DateTimeImmutable $datetime, array $body): AmqpEvent
{
    /** @var Attachment[] $attachments */
    $attachments = $body['attachments'];

    Assert::allIsInstanceOf($attachments, Attachment::class);
    $event->attachments = $attachments;

    return $event;
}

What type is $body['attachments'] initially?

Have you tried to do like this?
public static function createFromBody(string $id, DateTimeImmutable $datetime, array $body): AmqpEvent
{
    /** @var Attachment[] $attachments */
    $attachments = $body['attachments'];

    Assert::allIsInstanceOf($attachments, Attachment::class);
    $event->attachments = $attachments;

    return $event;
}

Yes, I tried. It only helps this way:
public static function createFromBody(string $id, DateTimeImmutable $datetime, array $body): AmqpEvent
{
    /** @var Attachment[] $attachments */
    $attachments = $body['attachments'];

    Assert::allIsInstanceOf($attachments, Attachment::class);
    $event->attachments = $body['attachments'];

    return $event;
}

Have you tried to do like this?
public static function createFromBody(string $id, DateTimeImmutable $datetime, array $body): AmqpEvent
{
    /** @var Attachment[] $attachments */
    $attachments = $body['attachments'];

    Assert::allIsInstanceOf($attachments, Attachment::class);
    $event->attachments = $attachments;

    return $event;
}

It works with explicit annotation. Also, he does not swear at the error when using it in this way:
public static function createFromBody(string $id, DateTimeImmutable $datetime, array $body): AmqpEvent
{
    /** @var Attachment[] $attachments */
    $attachments = $body['attachments'];

    Assert::allIsInstanceOf($attachments, Attachment::class);
    $event->attachments = $body['attachments'];

    return $event;
}

What type is $body['attachments'] initially?
Initially type /** @var$ attachments Attachment[] */

If you care that a collection is an array in particular you need an additional assertion right before that:
Assert::isArray($body['attachments']);

https://psalm.dev/r/1134245193

Yes, so there are no errors. And why does the method not initially support the array type?
Here is my mistake in psalm: https://psalm.dev/r/d4657c51a6


Issues training models on FluxBench

Ref https://buildkite.com/julialang/fluxbench-dot-jl/builds/84#627a51df-aa8d-4357-963d-877ff8fdef41
some models seem to fail. this is likely due to changes made to Zygote. Is it possible to do a bisect to find out which version of Zygote broke differentiability of certain models? We found this in Metalhead as well, but I would love to have a good idea of what caused this. It is likely aligned with when Zygote started wrapping ChainRules' outputs.

I'll have a look in the next few days. Reminds me a bit of #22, where going from Zygote 0.6.21 to 0.6.22 gave ChainRulesCore.NoTangent errors.

Okay, so I am running with 0.6.22 now as well. This needs an mwe so we can inspect it in zygote.

The old issue was fixed in a later version of Zygote. The example code to cause the error is still available here. IIRC, it was hard to get it down to a "minimal" example - those seemed to work fine.

Are you sure that this is related to Zygote? I have two branches in my repo:

faonly_up3, which is your up3 branch, just with everything non FluxArchitectures commented out, and
faonly, which is an old branch of mine with just the FluxArchitectures benchmarks

I updated my faonly branch to use the latest FluxArchitectures and Zygote 0.6.33, and the CPU benchmarks run fine. When I use the faonly_up3 branch however, I get the error that you saw as well with the same version of Zygote.
It might be worth having a look at the diff, especially the Manifest. I can for example see that there are different versions of CUDA and ChainRules. Do you think that these can be the most likely candidates for the error?

It had to do with ChainRules breaking code downstream. The latest FluxBench should be working and has the FA benchmarks in there as well. Thanks for the help!


Incorrect letter color

When I played todays warmle, I found a bug. The first z in pzazz should also be yellow

.

i think that's right -- in warmle the colors only tell you about that position, it's gray because Z isn't within 3 letters of I.


fix: fix modal position and styles

Pull Request Template
Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Add a TL;DR when description is extra long (helps content team)
Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change
Links to Notion, Figma or any other documents that might be relevant to the PR

PR fixes following issue(s)
Fixes # (issue number)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/build-deploy-preview skip-tests=true

/ok-to-test<EMAIL_ADDRESS>

/build-deploy-preview skip-tests=true

/ok-to-test<EMAIL_ADDRESS>

/build-deploy-preview skip-tests=true

/ok-to-test<EMAIL_ADDRESS>

/ok-to-test<EMAIL_ADDRESS>

/build-deploy-preview skip-tests=true

/ok-to-test<EMAIL_ADDRESS>

/ok-to-test<EMAIL_ADDRESS>

/ok-to-test<EMAIL_ADDRESS>

@KelvinOm The changes look fine to me. The areas which are effected and need to be tested:

Canvas scrolling When banners like the following show up (Editor, Preview and Deployed)

The Main canvas resizer in AutoLayout.

I tested this briefly and found an issue:
https://github.com/appsmithorg/appsmith/assets/103687/94256735-1811-4f38-82a9-7847f0b5e2ae

/ok-to-test<EMAIL_ADDRESS>

/build-deploy-preview skip-tests=true

@KelvinOm The changes look fine to me. The areas which are effected and need to be tested:

Canvas scrolling When banners like the following show up (Editor, Preview and Deployed)

The Main canvas resizer in AutoLayout.

I tested this briefly and found an issue:
Screen.Recording.2024-02-05.at.4.58.59.PM.mov

Checked and fixed the behavior you mentioned.
https://github.com/appsmithorg/appsmith/assets/11555074/ab99d5f3-4613-4ebb-9460-4fb2ffc96da6


Builds and runs, but no Unity Script intellisense

First, thank you for this sample.
I was able to get this to work in my project, it builds and runs without an issue, I can communicate between unity and the app. But I get intellisense errors for the code that communicates with the unity scripts. Your project has no intellisense issues (see screenshots). I built mine in Unity 2018 if that makes any difference.
I used agent ransack to search between the projects and references to ButtonHandlers, I see no difference. Do you some extra reference to Assembly-CSharp to get intellisense to work?

Your project:

@DavidShoe any ideas? It is making debugging quite difficult


Build(deps-dev): Bump webpack from 5.72.0 to 5.72.1 (#3458)

Pull request opened by the merge tool on behalf of #3458

Merged in 835c3c0c223462d89b4e2901bffe06484e12768d


Add serve-base image

f0fc4ab worker/Containerfile: Drop GITHUB_TOKEN
6a0950f Add new ilab serve base image
commit f0fc4abd595ebf8a11fe91e03761cc42c4d06996
Author: Russell Bryant<EMAIL_ADDRESS>Date:   Mon Apr 22 18:01:40 2024 -0400
worker/Containerfile: Drop GITHUB_TOKEN

This is no longer necessary to clone the `instructlab/instructlab`
repo.

Signed-off-by: Russell Bryant<EMAIL_ADDRESS>
commit 6a0950f33f56f192e1279d329f699ba259ed3c19
Author: Russell Bryant<EMAIL_ADDRESS>Date:   Mon Apr 22 18:03:05 2024 -0400
Add new ilab serve base image

Add an image that includes `ilab` but without any GPU support.

Signed-off-by: Russell Bryant<EMAIL_ADDRESS>

This build on my mac (linux/arm64) while the normal worker/Containerfile won't build on mac right now. This base is all I really wanted at the moment.


yaml: wrap domain-specific variables under switches

Some domain-specific things, like .dtb and .cfg are always used without any regard to the presence of corresponding domains. This commit wraps all domain-specific stuff under corresponding switches.

Successfully tested by the build of DomU, DomA.
Works as expected.


update integration to use keen-tracking v2 and parsers

Hi Devs!
This PR updates Segment integration with Keen.IO
Please note, there are some breaking changes, so publishing this package on NPM requires Major version update (to 3.0.0)
Fixes: #17 , #5 , #1
Thanks
@tysonmote

@segment-integrations/destinations for your review.
Thanks,
Emilio

Hi @adamkasprowicz, as part of the monorepo migration, this issue has been moved to new issue. Our engineers have been notified and will prioritize and work on it ASAP. Thank you!
For more information, see README.md.


fix: making crc32c field optional to properly decode response

This PR makes crc32c field in object response optional.

Thanks!


Grunt default revamp.

This PR fixes #12325.

npm run dev should work, yes. But that only compiles Builder's js.
El 15 jun. 2017 14:17, "Javier Álvarez Medina"<EMAIL_ADDRESS>escribió:

@xavijam approved this pull request.
In general 🇪🇸 , I've tested it and works like a charm. Just the
question I've made.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CartoDB/cartodb/pull/12329#pullrequestreview-44281094,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABTbO39f1HXGjljQYqm2KXPc4S9fO-WPks5sESDygaJpZM4N7AIj
.

:+1:, let's go then man!

cc @AleGoiko and @javitonino ❤  thanks to @nobuti


WIP: Ignore containers

Codecov Report

Merging #45 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   96.42%   96.45%   +0.02%
==========================================
  Files           7        7
  Lines         140      141       +1
==========================================
+ Hits          135      136       +1
  Misses          5        5

Impacted Files
Coverage Δ

ouroboros/cli.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33f92b1...d7ab9e9. Read the comment docs.

@circa10a How do you think we should handle a situation in which a user does the following:
$ ouroboros --monitor test1 test2 --ignore test1

Should we throw an error and refuse to do anything, or should one flag take precedence over the other?

@circa10a How do you think we should handle a situation in which a user does the following:
$ ouroboros --monitor test1 test2 --ignore test1

Should we throw an error and refuse to do anything, or should one flag take precedence over the other?

I think an error should be thrown for a couple of reasons:

Logging to display what the problem is
I wouldn't something to cancel out and proceed in case the intention is for test1 to absolutely NOT be upgraded

The only issue I have with the reasons above is I would hate for the application not to start because of user error, but I think it's more vital not to update a potentially import container...

So what if we do this:

Ouroboros still starts, but --ignore takes precedence
Ouroboros logs that it is ignoring container because it was specified in both --monitor and --ignore

So what if we do this:

Ouroboros still starts, but --ignore takes precedence
Ouroboros logs that it is ignoring container because it was specified in both --monitor and --ignore

I like it :)

TIL intersection!
Ready to merge?

Nope still WIP

@circa10a Gonna update the integration test and then it'll be ready to merge

@circa10a It's ready when you are my d00d

$ docker pull busybox:1.28
1.28: Pulling from library/busybox
07a152489297: Pull complete
Digest: sha256:141c253bc4c3fd0a201d32dc1f493bcf3fff003b6df416dea4f41046e0f37d47
Status: Downloaded newer image for busybox:1.28

$ docker run -d --name bb busybox:1.28 tail -f /dev/null
b44a2839e91141468c223115f7bf8e2f1f00afde22b56a49a8731ced6933c173

$ docker run -d --name ignore busybox:1.28 tail -f /dev/null
70dd2426b27b12c5eebba8b3cbabab26236204f7791429c079cc395ee08491f3

$ docker ps
CONTAINER ID        IMAGE               COMMAND               CREATED             STATUS              PORTS               NAMES
70dd2426b27b        busybox:1.28        "tail -f /dev/null"   2 seconds ago       Up 2 seconds                            ignore
b44a2839e911        busybox:1.28        "tail -f /dev/null"   25 seconds ago      Up 24 seconds                           bb

$ ouroboros --interval 5 --monitor bb ignore --ignore ignore --runonce --cleanup
[INFO] 2018-11-03 16:11:27 Running job Every 5 seconds do main(args=Namespace(cleanup=True, ignore=['ignore'], interval=5, loglevel='info', monitor=['bb', 'ignore'], run_once=True, url='unix://var/run/docker.sock'), api_client=<docker.api.client.APIClient object at 0x100e8b320>) (last run: [never], next run: 2018-11-03 16:11:27)
[INFO] 2018-11-03 16:11:27 Ignoring container(s): ignore
[INFO] 2018-11-03 16:11:29 bb will be updated
[INFO] 2018-11-03 16:11:40 Removing image: busybox:1.28
[CRITICAL] 2018-11-03 16:11:40 Could not clean up image: busybox:1.28, reason:
409 Client Error: Conflict ("conflict: unable to delete 8c811b4aec35 (cannot be forced) - image is being used by running container 70dd2426b27b")
[INFO] 2018-11-03 16:11:40 1 container(s) updated

$ docker ps
CONTAINER ID        IMAGE               COMMAND               CREATED             STATUS              PORTS               NAMES
a462e84a78d9        busybox:latest      "tail -f /dev/null"   23 seconds ago      Up 21 seconds                           bb
70dd2426b27b        busybox:1.28        "tail -f /dev/null"   2 minutes ago       Up 2 minutes                            ignore


Rad storm event triggering during the evac shuttle kills the whole lobby.

Description
It doesn't feel good when a rad storm aimbots players on the evac shuttle. Everyone is so confined in there and it is almost a 100% guarantee that everyone is going to be dead before the shuttle docks at centcom. The storm spheres were still triggering on FTL making it hopeless.
Reproduction
Have the rad storm trigger when the shuttle is docked.

isnt rad storm disabled

or like. literally not even in the code anymore

someone brought a rad artifact on the shuttle and it killed everyone

someone brought a rad artifact on the shuttle and it killed everyone

Certified skill issue.


Npm repo url not good

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[x] Other... Please describe:

Just to inform repository url is not good in npm
https://www.npmjs.com/package/@ngneat/hot-toast

Not sure where did you check. But it's correct on NPM.

nope the repository url on the right side

I don't now what happened but the repo went from @ngneat/hot-toast to @ngxpert/hot-toast
It would have been nice to warn user about this change, is it still Netanel Basal behind @ngxpert ?

nope, I manage ngxpert org.


perhaps deprecate the npm package?

Seeing as the npm package haven't been updated in two years and the suggestion in the "Readme -> Note" about using native promises when possible still stands, would it make sense to deprecate this package on npm?
I'm in the process of trying to refactor a package to using native promises, async/await and async iterators and it's sometime a risky business unknowingly if something dose some abnormal to the promise chain like tapping in and calling .delay(), .spread() or any of the other utilities after a promise chain.
I'm more okey with this kind of code:
return bluebirdPromise.delay(250)

than something like
function foo() {
  return Promise.resolve(123)
}

foo().delay(250).then(console.log)

At any point i might refactor foo to a async/await and perhaps use native promises or async/await instead.
I think it would be better to depend on a spec'ed promise A+ polyfill instead.
beside, this bluebird promise did not have Promise.allSettled so i had to use globalThis.Promise.allSettled to avoid the imported bluebird-promise imported in at the top of the file.
maybe bluebird have run its course, and say that it's time to say goodby to bluebird?
you have done an amazing work with promises and made browser lookup to bluebirds promise tools and speed so a big thank you.

I don't want the 25+ million downloads to get a "This package is deprecated" message that will be bad developer experience for them.
If you want to push this I would go and suggest this to dependents of bluebird (I've done so and opened PRs in the past to replace bluebird when it was used only a little with native promises).
It's true that we upstreamed everything we can - the helpers to readable streams in Node.js, cancellation to all APIs with AbortSignal, async stack traces and performance.
If there are bugs they will still be fixed, if there are security issues they will still be fixed.

if something dose some abnormal to the promise chain like tapping in and calling .delay(), .spread() or any of the other utilities after a promise chain.

In general I avoid promise chaining mostly altogether in new code - this syntax mostly exists because there was no async/await back then.

beside, this bluebird promise did not have Promise.allSettled so i had to use globalThis.Promise.allSettled to avoid the imported bluebird-promise imported in at the top of the file.

That was actually added at some point (to bluebird) as an alias.

That was actually added at some point (to bluebird) as an alias.

Hmm, then i must have a outdated version of bluebird...

I don't want the 25+ million downloads to get a "This package is deprecated" message that will be bad developer experience for them.

i get what you are saying, wondering when that time will come for node-fetch myself.
maybe we can add something to @types/bluebird that some of the promise chain is best avoided and mark only some chain methods as deprecated? 💁

maybe we can add something to @types/bluebird that some of the promise chain methods is best avoided and mark only some chain methods as deprecated? 💁

Honestly it would be great if people just stopped using it (and stuff like Q) altogether. Bluebird is often the dependent of a dependent so I really don't want to show people a ton of deprecation warnings they can't really handle because libraries they use use it.
I'll ping Myles (he's a PM at NPM) and ask if NPM has a way to do a "less disruptive soft deprecation".

maybe we can add something to @types/bluebird that some of the promise chain methods is best avoided and mark only some chain methods as deprecated? 💁

Another good idea might be an ESLint rule that warns on these methods and then suggest adding it to the airbnb base config people use?

As a side note I really wish there was a way to port the warnings since they're the main thing still missing (though less so since async await became more dominant)

Verified nothing (yet) on the NPM side but they're working on it.

Bluebird still provides a ton of great functionality not built into Node/JS. For me that's Promise.then, myPromise.tap and myPromise.tapCatch. Regardless, rather than deprecating Bluebird, what I'd like to see is a modern version of Bluebird that maintains its functionality, but 100% builds on top of the modern runtime support for Promises rather than Bluebird's own promise engine.
(Having never looked at Bluebird's source, perhaps I'm making too many assumptions...)

@benjamingr I understand the desire to not pester users, but I think people do not "get the message" when there isn't that big billboard when they install dependencies. It's been a couple of years since this issue was opened, and I can say with surety that there is still a significant amount of usage of bluebird on modern releases of Node.js (e.g. v20).

and I can say with surety that there is still a significant amount of usage of bluebird on modern releases of Node.js (e.g. v20).

Yes but as a maintainer in both I care more about not breaking or annoying users than I do about fixing that quickly rather than letting it drag out, new projects probably adopt bluebird less and less and older code gets migrated.

I think the notice that q provided (https://github.com/kriskowal/q/issues/866#issuecomment-2161615101) straddles these concerns quite well. It's really the only way we have to educate people.

Yes but as a maintainer in both I care more about not breaking or annoying users than I do about fixing that quickly rather than letting it drag out, new projects probably adopt bluebird less and less and older code gets migrated.

While I understand where you're coming from and genuinely appreciate how much you care about users, valid deprecation notices aren't annoyances, they're extremely important communications.  Realistically, bluebird is never going to die out.  It's last version was released ~5 years ago and it still receives ~22M downloads per week.  In another 5 years, it's probably still going to easily be in the 10s of millions per week category.
Many developers simply copy/paste things between projects, templates that never get updated, tutorials and guides where people don't know any better, etc.  Put another way, if this isn't a textbook example of what npm deprecation notices were built for, I honestly have no idea when anyone would ever use them.  Please reconsider deprecating it on npm; it will help orders of magnitude more users than hurt.

While I understand where you're coming from and genuinely appreciate how much you care about users, valid deprecation notices aren't annoyances, they're extremely important communications. Realistically, bluebird is never going to die out. It's last version was released ~5 years ago and it still receives ~22M downloads per week. In another 5 years, it's probably still going to easily be in the 10s of millions per week category.

I know I'm also a Node maintainer but as a bluebird maintainer I have to do what's best for bluebird's users rather than push my agenda.
What I've been doing to try and help is coordinate through the cleanup discord, people have been super nice and have spent time PRing popular packages replacing bluebird with native promises https://discord.com/channels/1227627367204257852/1227653370945474590

Many developers simply copy/paste things between projects, templates that never get updated, tutorials and guides where people don't know any better, etc. Put another way, if this isn't a textbook example of what npm deprecation notices were built for, I honestly have no idea when anyone would ever use them. Please reconsider deprecating it on npm; it will help orders of magnitude more users than hurt.

Part of the philosophy has always been to annoy developers as little as possible and be as useful as possible - hence why bluebird has no deps, low overhead, good errors and good performance (not saying this so you use it - please don't, we've been able to upstream the important bits to Node).

I am open to other non-destructive ideas but I think PRing packages that have bluebird as a dependency and don't need it is a great step.
There are still valid use cases for bluebird (like people stuck supporting old platforms) and I don't want to create the false impression it's abandoned. Q was deprecated but it always had a different philosophy, also I've gotten complaints from people about that.


Scully fail to make pages - plugin "storeRoutes has thrown the below error,

🐞 Bug report
Description
🔬 Minimal Reproduction
💻Your Environment
Angular Version:

➜  git:(master) ✗ nx --version
15.3.0

Scully Version:

"@scullyio/ng-lib": "^2.1.41",
"@scullyio/scully": "^2.1.41",
"@scullyio/scully-plugin-puppeteer": "^2.1.41",

🔥 Exception or Error

➜  git:(master) ✗ npx scully --pr docs --scanRoutes
  ⚠ Folder "./scully" doesn't seem to contain custom plugins
  x Could not find project "docs" in 'angular.json'.
  ✔ new Angular build files imported
  ✔ Starting servers for project "docs"
  ✔ Started Scully static server on "http://localhost:1668/"
  ✔ Started Angular distribution server on "http://localhost:1864/"
  ✔ Scully Development Server is up and running
  ✔ Puppeteer is being launched
  ✔ Successfully scanned Angular app for routes
  ✔ Successfully added routes created from routePlugins
  x  The scullySystem plugin "storeRoutes has thrown the below error,
              while trying to render route "unknown"
              Scully will exit
  x TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
                                               %                                                                                ➜

import { ScullyConfig } from '@scullyio/scully';
import '@scullyio/scully-plugin-puppeteer';

const defaultPostRenderers = ['seoHrefOptimise'];

export const config: ScullyConfig = {
  projectRoot: './apps/docs/src',
  projectName: 'docs',
  distFolder: './dist/apps/docs',
  outDir: './dist/docs-static',
  routes: {},
  defaultPostRenderers,
  target: 'targets',
  puppeteerLaunchOptions: {
    args: ['--no-sandbox'],
  },
};

@boskiv  @djmcgrath101
I managed to make the script working by adding the key sourceRoot with the same value as projectRoot in the scully config file.

@maximegris this worked for me as well 👍 thank you!

storeRoutes.ts

@boskiv @djmcgrath101 I managed to make the script working by adding the key sourceRoot with the same value as projectRoot in the scully config file. (My project is with Nx : 15.6.3)
storeRoutes.ts line 16
const srcFile = join(scullyConfig.homeFolder, scullyConfig.sourceRoot, routesFileName); // wrong path generated when sourceRoot is not set

hi @maximegris , may i know where is storeRoutes.ts ?

Hi @FanYeeChok
The file is here

@FanYeeChok Yes it was by adding sourceRoot in your own Scully config, not by modifying the Scully code :)
The Scully code showed me the way !


[Testing] Add IsContinueAsNewError For Checking Errors in Tests

This adds a helper method to check if it is a continue as new error. I don't see any use cases aside from testing, so happy to close - or happy to put elsewhere. Made this practically copy-paste of temporal.IsCanceledError but I see that this can't exist in temporal for cyclic dependency reasons.

Should we put this in the error.go instead?

Should we put this in the error.go instead?

Should we put this in the error.go instead?

@vitarb - it can't for the same reason that NewContinueAsNewError doesn't exist there - there's a cyclical dependency if it were to be there. At least according to the PR that moved the ContinueAsNewError to this new location.

Should we put this in the error.go instead?

@vitarb - it can't for the same reason that NewContinueAsNewError doesn't exist there - there's a cyclical dependency if it were to be there. At least according to the PR that moved the ContinueAsNewError to this new location.

Makes sense, alright, let's keep it the way you did then.

Makes sense, alright, let's keep it the way you did then.

@vitarb - I actually can't merge this PR since I don't have write access. Mind merging for me?

@vitarb - I actually can't merge this PR since I don't have write access. Mind merging for me?

@vitarb or @alexshtin - can someone merge this PR for me? Thanks!
I just keep having to update with master lol

@vitarb or @alexshtin - can someone merge this PR for me? Thanks!
I just keep having to update with master lol


Couldn't mount VMware tools ISO. Please check the 'guest_os_type' in your template.json.

Operating System Version: Ubuntu 20.04
Deploying via (VirtualBox/VMWare/AWS/Azure/ESXi): ESXi
Vagrant Version (if applicable):

Please verify that you are building from an updated Master branch before filing an issue.
Description of the issue:
While building the logger host, I'm running into the following error message that causes the build to stop:
Build 'vmware-iso' errored after 18 minutes 55 seconds: Couldn't mount VMware tools ISO. Please check the 'guest_os_type' in your template.json.

Link to Gist Containing Build Logs:
https://gist.github.com/aleixsb/179ffcf1b2370251ca63cc68ba356519

During what step are you seeing this error?

On Sep 14, 2021, at 3:57 AM, Aleix Sala Bach @.***> wrote:

Operating System Version: Ubuntu 20.04
Deploying via (VirtualBox/VMWare/AWS/Azure/ESXi): ESXi
Vagrant Version (if applicable):
Please verify that you are building from an updated Master branch before filing an issue.
Description of the issue:
Link to Gist Containing Build Logs:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Hi @aleixsb - what version of Packer are you using?

Closing due to inactivity. Feel free to re-open if you're still having issues.

Hey!
Apologies for the delay!
I'm using Packer v1.7.4


[proposal] try using swc for building assets

Pre-Flight checklist

[ ] Testing

[ ] Code is tested
[ ] Changes have been manually tested

What are the relevant tickets?
none
What's this PR do?
This is a dev tooling change which I want to propose and see what everyone things. It basically swaps out babel and the typescript compiler in our build / test toolchain for swc, which is a series of tools built in Rust for compiling and bundling web things. Because the tools are written in Rust and compiled to native code they are generally much faster than tools written in JS (like babel, the typescript compiler, etc) so our builds and tests run quite a bit quickly.
In my testing I observed the tests running in a little under half the time, and CI builds seem to go from ~4 minutes to ~2.5. Nice!
How should this be manually tested?
Test a few things:

the build should be passing!
you should be able to run tests locally
the local dev build (in the watch container) should work without issue

My thought is that it would be good to get some feedback on this. I like the speed increase, but I'm not 100% sure we want to adopt it. What do y'all think?

I tried it out, it does run tests faster, seems to be regularly updated and popular on github so unlikely to disappear or go unmaintained anytime soon.  Seems nice overall.
Maybe one cause for concern is if we someday need a plugin that's available for babel but not swc, not sure how likely that is.
I read this recent article about swc which was overall positive but mentioned that its error reporting isn't very good:

SWC's error messages need some love; add an extra comma in .swcrc and it blows up without any indiciation where the problem is.

I tested this out by adding an extra comma, and got a detailed error message about it.  So error reporting already seems to have improved since this article was written.

I think we're probably not likely to need babel plugins in the future, as we've mostly moved away from them already in newer projects and we tend to just write standard TypeScript nowadays (and I think we should do that on all new projects going forward).


Add portable report

Allow setting portable flag for pipestat summarize such that report resources (images, pdfs) are copied to a resource folder within the report folder, allowing for the entire HTML report to be more easily shared across systems.
Example CLI usage:
pipestat summarize -c /home/drc/pepatac_tutorial/processed/looper_pipestat_config.yaml --portable True

Should this go ahead and zip up the portable report?

Should this go ahead and zip up the portable report?

Yeah, I was thinking that would be a nice addition.

I've changed the CLI such that you do not have to input a bool:
pipestat summarize -c ./looper_pipestat_config.yaml --portable

Closes #139


add es6 eslint config

it may not good to leave  the eslint error msg such asThe keyword 'const' is reserved The keyword 'class' is reserved out there when people open the project,  since we already have eslint config file,  I think it  may be helpful to give a quick and low risk update

the same problem. @evilebottnawi  Do you consider adopting this pr?


docs: add bytewax integration

Add integration of bytewax with ydata-profiling.

Codecov Report
Patch and project coverage have no change.

Comparison is base (dde4bd4) 89.88% compared to head (f9dbbb1) 89.88%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1396   +/-   ##
========================================
  Coverage    89.88%   89.88%
========================================
  Files          192      192
  Lines         6147     6147
========================================
  Hits          5525     5525
  Misses         622      622

Flag
Coverage Δ

py3.8-ubuntu-22.04-pandas
89.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@miriamspsantos Made a few changes:

Content
the PR was missing changes to the documentation index


feat: HACBS-2315: Remove outdated EC dependency

Description
The ec-defaults ConfigMap in the enterprise-contract-service namespace contain values for which policy and data refs to use when creating a new EnterpriseContractPolicy resource. However, we have moved away from using this ConfigMap for this purpose. Although the values still exist, they are no longer updated by automation.
The automation now keeps a few EnterpriseContractPolicy resources up to date. This commit changes the release tests to no longer fetch the policy and data refs from the ConfigMap. Instead, it uses the default EnterpriseContractPolicy as the basis for creating a new resource. This default has the added benefit of only including certain policy rules that shouls always pass under normal operation.
NOTE: The ConfigMap is still useful for determining the most up to date ref for the ec Tekton Task. There are no plans to change this.
Issue ticket number and link
https://issues.redhat.com/browse/HACBS-2315
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

/retest

@lcarva so does this mean https://github.com/redhat-appstudio/release-service/commit/cc4fad5c5caf9bbc81a6c8e0336e1c95be585e45#diff-8eff55eb33d97decdaa9236ca4f3a041900247f2b860ecfab656f2bf7f7a1549R74 is wrong?

@lcarva so does this mean redhat-appstudio/release-service@cc4fad5#diff-8eff55eb33d97decdaa9236ca4f3a041900247f2b860ecfab656f2bf7f7a1549R74 is wrong?

Negative. I mentioned in the PR description but I probably wasn't very clear. The ConfigMap is still the proper way to fetch the ref to the latest tested Tekton task bundle. Just the policy and data refs that now reside somewhere else.

/retest-required

/retest

/retest

/retest
@flacatus this keeps failing to what appears to be unrelated issues in the demo tests.

/retest

Finally got a passing test but now the branch is out of date :sob:

/test redhat-appstudio-e2e

/test all


feat(container): add support for autofac

Description
Add Support for Autofac along with other DI
How Has This Been Tested?
Running manually the sample using local Kafka cluster
Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have added tests to cover my changes
[ ] I have made corresponding changes to the documentation

Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

Opening a PR just in case anyone looking for autofac integration . My first PR :)


SUGGESTION: Inform user about new version

Inform the user if there is a new version of the cli out.
Add an easy command like wcli upgrade.

Love this one!

Can we push this forward?

A simple upgrade function is now implemented


ServerAPIVersions incorrectly squashes config.Prefix

discovered while testing #9171

LGTM

Please add the "lgtm" label so that the oncall knows the PR is ready to merge.

Tests didn't run. Will close and re-open.

Integration tests failed. Here's a snippet
I0608 21:32:10.934376   28161 config.go:244] Setting pods for source file : {[] 0 file}
I0608 21:32:10.984597   28161 integration.go:953] Running 4 tests in parallel.
I0608 21:32:10.986342   28161 integration.go:391] Creating replication controllers
F0608 21:32:10.986448   28161 integration.go:420] failed to get api versions: the server could not find the requested resource
I0608 21:32:10.998678   28161 factory.go:214] About to try and schedule pod foo
I0608 21:32:10.998819   28161 replication_controller.go:199] No controllers found for pod foo, replication manager will avoid syncing

@jdef Could you run the integration tests (./hack/test-integration.sh I think) and fix this? Thanks.

@krousey I ended up adding a new func UnversionedPath() in order to pass the tests. I think it captures the intent of what ServerAPIVersions() needs, although I'm not proud of the "is-this-a-version" test that it implements. Is there a better way to test such?

@jdef I'm on interrupts today.
@brendandburns could you take this?

Oh wait, @smarterclayton was the original reviewer, not @bgrant0607.
@smarterclayton could you take a look at the changes?

LGTM


Update Dutch translations

Translations are now more in line with recommended Dutch spelling and grammar rules. Also, general improvements to the Dutch translations.
This change implements the following rules of grammar:

Compositions should not include spaces
Words in titles should minimize the amount of capital letters

It also includes some translations I believe to be more understandable for users. For instance the change to update the text toegankelijkheidsrechten to benodigde permissies.

This PR has not pulled the latest English localization file and, as such, does not add new lines of text that is currently untranslated.

first resolve conflicts

There you go, @ofsho. It now also has updated translations for strings that weren't previously translated.

ok i will review it


endswith

Changed start command from node app.js to node --harmony_strings app.js to take advantage of new endsWith string function
Use endsWith() instead of indexOf for email check
Modified postinstall commands to invoke node runtime explicitly to support deployments in non-Unix environments

Looks like the way Node.js scripts are run was changed as well (e.g. in postinstall). I think we should probably make this change, but it should be a separate commit (and probably a separate pull request) as these are two unrelated changes.

-1.  Can we split this into 2 commits?  The script stuff should be in a seperate commit.

@jsloyer, @bradley-holt backed out the additional change. Sorry about that.

@ptitzler it still shows the change to the start command in the commit.

@jsloyer , I left that change in because it is still required to enable the new ES6 string features in node v0.12.7. If the flag is omitted, node will  fail due to an unknown symbol error:
 if (email.toLowerCase().endsWith("ibm.com")) {
                        ^
TypeError: undefined is not a function

I've observed this behavior in my local environment and the Bluemix environment using a small sample application.


build: use TPI

goreleaser/goreleaser-action takes ~30min to build 8 packages on GHA atm. Advantages of using a cloud instance to build instead:

doubles up as a form of e2e testing
provision the instance with TPI itself (dogfooding) so if TPI is broken it won't release
faster builds

And we can always fallback to local builds on failure.


HTML  in Temml home page

In the HTML source for Temml home page, at line 51,
Output:

The value of the for attribute of the  element refers to a
 element, but:
Cite MDN

Elements that can be associated with a  element include <button>, <input> (except for type="hidden"), <meter>, <output>, <progress>, <select> and <textarea>.

Also, the  tag on line 20 is not closed:

I suggest adding  before  on line 233.

Thank you for alerting me to these issues. Fixed now.


loading data error

Hi,
When I run the code on CIFAR10, CUDA_VISIBLE_DEVICES=0 python train_search.py --unrolled,
there is strange error which is
07/31 05:43:39 PM train 050 1.986851e+00 26.960785 81.188728 07/31 05:52:04 PM train 100 1.871319e+00 29.965965 84.189354 07/31 06:00:27 PM train 150 1.797943e+00 32.926323 85.844368 Exception ignored in: <bound method _DataLoaderIter.__del__ of <torch.utils.data.dataloader._DataLoaderIter object at 0x7fc27522edd8>> Traceback (most recent call last):   File "/data1/yinzheng/anaconda2/envs/py36/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 399, in __del__     self._shutdown_workers()   File "/data1/yinzheng/anaconda2/envs/py36/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 378, in _shutdown_workers     self.worker_result_queue.get()   File "/data1/yinzheng/anaconda2/envs/py36/lib/python3.6/multiprocessing/queues.py", line 337, in get     return _ForkingPickler.loads(res)   File "/data1/yinzheng/anaconda2/envs/py36/lib/python3.6/site-packages/torch/multiprocessing/reductions.py", line 151, in rebuild_storage_fd     fd = df.detach()   File "/data1/yinzheng/anaconda2/envs/py36/lib/python3.6/multiprocessing/resource_sharer.py", line 58, in detach     return reduction.recv_handle(conn)   File "/data1/yinzheng/anaconda2/envs/py36/lib/python3.6/multiprocessing/reduction.py", line 182, in recv_handle     return recvfds(s, 1)[0]   File "/data1/yinzheng/anaconda2/envs/py36/lib/python3.6/multiprocessing/reduction.py", line 153, in recvfds     msg, ancdata, flags, addr = sock.recvmsg(1, socket.CMSG_LEN(bytes_size)) ConnectionResetError: [Errno 104] Connection reset by peer
Can you tell me what is wrong with this error?
Thanks very much

I can't reproduce the error. I'd first tweak the options in DataLoader, e.g. num_workers.

hi,
It seems setting num_worker to 1 (default is 2) is fine. However, this error does not appear on train.py (not search), even it sets num_worker=2. BTW, I use pytorch 0.4.1, will the version cause the problem?
Thanks!

Perhaps num_worker=1 would also work. I see similar issues being discussed here where people are posting their workarounds. I'm not sure but this appears to be a bug of pytorch, including v0.4.


Newest Update broke the Auto Tagger

I'm getting the following error while trying to launch the auto-tagger;
Traceback (most recent call last):
  File "D:\AI Art\Tagger\interrogator_rpc\main.py", line 31, in <module>
    import rpc_proto.services_pb2
  File "D:\AI Art\Tagger\interrogator_rpc\rpc_proto\services_pb2.py", line 9, in <module>
    from google.protobuf import runtime_version as _runtime_version
ImportError: cannot import name 'runtime_version' from 'google.protobuf' (C:\Users\XXXX\AppData\Local\Programs\Python\Python310\lib\site-packages\google\protobuf\__init__.py)

I have no idea how to fix this, I've tried reinstalling, updating protobuf and even ran it through ChatGPT to see if it could fix the issue, but nothing.

Please write the version of python and installed protobuf:
python --version
pip show protobuf

C:\Users\FatMa>python --version
Python 3.10.6
C:\Users\FatMa>pip show protobuf
Name: protobuf
Version: 5.28.2
Summary:
Home-page: https://developers.google.com/protocol-buffers/
Author<EMAIL_ADDRESS>Author-email<EMAIL_ADDRESS>License: 3-Clause BSD License
Location: c:\users\fatma\anaconda3\lib\site-packages
Requires:
Required-by: grpcio-tools, onnx, onnxruntime-gpu, tb-nightly

This may be because you are using a base anaconda environment and there are some conflicts. Try the following:
Copy this file to the interrogator_rpc folder (With replacement of the existing file)
In the anaconda console, create a new environment and install the dependencies.
conda create -n bdtm python=3.10.13
conda activate bdtm
conda install conda-forge::vs2015_runtime
Go to the interrogator_rpc directory
pip install -r requirements.txt
python main.py
I tested the installation in the new environment and everything worked successfully.

Installing collected packages: pytz, mpmath, flatbuffers, urllib3, tzdata, typing-extensions, sympy, six, safetensors, regex, pyyaml, pyreadline3, protobuf, pillow, packaging, numpy, networkx, MarkupSafe, idna, grpcio, fsspec, filelock, einops, colorama, charset-normalizer, certifi, tqdm, requests, python-dateutil, onnx, jinja2, humanfriendly, grpcio-tools, bottleneck, torch, pandas, huggingface_hub, coloredlogs, torchvision, torchaudio, tokenizers, onnxruntime-gpu, transformers, timm
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
basicsr 1.4.2 requires addict, which is not installed.
basicsr 1.4.2 requires lmdb, which is not installed.
basicsr 1.4.2 requires opencv-python, which is not installed.
blendmodes 2022 requires aenum<4,>=3.1.7, which is not installed.
facexlib 0.3.0 requires opencv-python, which is not installed.
filterpy 1.4.5 requires matplotlib, which is not installed.
gfpgan 1.3.8 requires lmdb, which is not installed.
gfpgan 1.3.8 requires opencv-python, which is not installed.
realesrgan 0.3.0 requires opencv-python, which is not installed.
tb-nightly 2.14.0a20230623 requires absl-py>=0.4, which is not installed.
tb-nightly 2.14.0a20230623 requires google-auth<3,>=1.6.3, which is not installed.
tb-nightly 2.14.0a20230623 requires google-auth-oauthlib<1.1,>=0.5, which is not installed.
tb-nightly 2.14.0a20230623 requires markdown>=2.6.8, which is not installed.
tb-nightly 2.14.0a20230623 requires tensorboard-data-server<0.8.0,>=0.7.0, which is not installed.
tb-nightly 2.14.0a20230623 requires werkzeug>=1.0.1, which is not installed.
torchsde 0.2.5 requires boltons>=20.2.1, which is not installed.
torchsde 0.2.5 requires trampoline>=0.1.2, which is not installed.
blendmodes 2022 requires numpy<2,>=1.22.1, but you have numpy 2.1.2 which is incompatible.
blendmodes 2022 requires Pillow<10,>=9.0.0, but you have pillow 11.0.0 which is incompatible.
numba 0.57.1 requires numpy<1.25,>=1.21, but you have numpy 2.1.2 which is incompatible.
scipy 1.10.1 requires numpy<1.27.0,>=1.19.5, but you have numpy 2.1.2 which is incompatible.
Successfully installed MarkupSafe-3.0.1 bottleneck-1.4.1 certifi-2024.8.30 charset-normalizer-3.4.0 colorama-0.4.6 coloredlogs-15.0.1 einops-0.8.0 filelock-3.16.1 flatbuffers-24.3.25 fsspec-2024.9.0 grpcio-1.66.2 grpcio-tools-1.66.2 huggingface_hub-0.26.0 humanfriendly-10.0 idna-3.10 jinja2-3.1.4 mpmath-1.3.0 networkx-3.4.1 numpy-2.1.2 onnx-1.17.0 onnxruntime-gpu-1.19.2 packaging-24.1 pandas-2.2.3 pillow-11.0.0 protobuf-5.27.2 pyreadline3-3.5.4 python-dateutil-2.9.0.post0 pytz-2024.2 pyyaml-6.0.2 regex-2024.9.11 requests-2.32.3 safetensors-0.4.5 six-1.16.0 sympy-1.13.1 timm-1.0.11 tokenizers-0.20.1 torch-2.5.0+cu118 torchaudio-2.5.0+cu118 torchvision-0.20.0+cu118 tqdm-4.66.5 transformers-4.46.0.dev0 typing-extensions-4.12.2 tzdata-2024.2 urllib3-2.2.3

[notice] A new release of pip is available: 23.3.2 -> 24.2
[notice] To update, run: python.exe -m pip install --upgrade pip
(bdtm) PS D:\AI Art\Tagger\interrogator_rpc> python main.py
Have CUDA:  True
CUDA Count:  1
Using interrogator device: cuda
C:\Users\FatMa\AppData\Roaming\Python\Python310\site-packages\scipy\__init__.py:160: UserWarning: A NumPy version >=1.19.5 and <1.27.0 is required for this version of SciPy (detected version 2.1.2)
  warnings.warn(f"A NumPy version >={np_minversion} and <{np_maxversion}"
Traceback (most recent call last):
  File "C:\Users\FatMa\anaconda3\envs\bdtm\lib\site-packages\transformers\utils\import_utils.py", line 1770, in _get_module
    return importlib.import_module("." + module_name, self.__name__)
  File "C:\Users\FatMa\anaconda3\envs\bdtm\lib\importlib\__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "C:\Users\FatMa\anaconda3\envs\bdtm\lib\site-packages\transformers\models\blip\modeling_blip.py", line 29, in <module>
    from ...modeling_utils import PreTrainedModel
  File "C:\Users\FatMa\anaconda3\envs\bdtm\lib\site-packages\transformers\modeling_utils.py", line 48, in <module>
    from .loss.loss_utils import LOSS_MAPPING
  File "C:\Users\FatMa\anaconda3\envs\bdtm\lib\site-packages\transformers\loss\loss_utils.py", line 19, in <module>
    from .loss_deformable_detr import DeformableDetrForObjectDetectionLoss, DeformableDetrForSegmentationLoss
  File "C:\Users\FatMa\anaconda3\envs\bdtm\lib\site-packages\transformers\loss\loss_deformable_detr.py", line 6, in <module>
    from .loss_for_object_detection import (
  File "C:\Users\FatMa\anaconda3\envs\bdtm\lib\site-packages\transformers\loss\loss_for_object_detection.py", line 28, in <module>
    from scipy.optimize import linear_sum_assignment
  File "C:\Users\FatMa\AppData\Roaming\Python\Python310\site-packages\scipy\optimize\__init__.py", line 404, in <module>
    from ._optimize import *
  File "C:\Users\FatMa\AppData\Roaming\Python\Python310\site-packages\scipy\optimize\_optimize.py", line 30, in <module>
    from numpy import (atleast_1d, eye, argmin, zeros, shape, squeeze,
ImportError: cannot import name 'Inf' from 'numpy' (C:\Users\FatMa\anaconda3\envs\bdtm\lib\site-packages\numpy\__init__.py)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "D:\AI Art\Tagger\interrogator_rpc\main.py", line 29, in <module>
    import interrogator
  File "D:\AI Art\Tagger\interrogator_rpc\interrogator.py", line 13, in <module>
    from ext_kohya import (
  File "D:\AI Art\Tagger\interrogator_rpc\ext_kohya\tagger.py", line 8, in <module>
    from .interrogators import WaifuDiffusionTagger, DepDanbooruTagger
  File "D:\AI Art\Tagger\interrogator_rpc\ext_kohya\interrogators\__init__.py", line 1, in <module>
    from .blip_large_captioning import BLIPLargeCaptioning
  File "D:\AI Art\Tagger\interrogator_rpc\ext_kohya\interrogators\blip_large_captioning.py", line 3, in <module>
    from transformers import BlipProcessor, BlipForConditionalGeneration
  File "<frozen importlib._bootstrap>", line 1075, in _handle_fromlist
  File "C:\Users\FatMa\anaconda3\envs\bdtm\lib\site-packages\transformers\utils\import_utils.py", line 1759, in __getattr__
    value = getattr(module, name)
  File "C:\Users\FatMa\anaconda3\envs\bdtm\lib\site-packages\transformers\utils\import_utils.py", line 1758, in __getattr__
    module = self._get_module(self._class_to_module[name])
  File "C:\Users\FatMa\anaconda3\envs\bdtm\lib\site-packages\transformers\utils\import_utils.py", line 1772, in _get_module
    raise RuntimeError(
RuntimeError: Failed to import transformers.models.blip.modeling_blip because of the following error (look up to see its traceback):
cannot import name 'Inf' from 'numpy' (C:\Users\FatMa\anaconda3\envs\bdtm\lib\site-packages\numpy\__init__.py)
(bdtm) PS D:\AI Art\Tagger\interrogator_rpc>

I'm not sure if I did something wrong?


nothing showed until I select language

my middleware:
 public function handle($request, Closure $next)     {         App::setLocale(session('locale'));         config(['translatable'=>session('locale')]);         return $next($request);     }
I found default locale not working before I select a language.

First: to format multiline code in markdown/github pls use the gravis three times - also with possible language after this like
```php

public function handle($request, Closure $next) {
    App::setLocale(session('locale'));
    config(['translatable'=>session('locale')]);

    return $next($request);
}

Where do you specify your default locale? And what do you get from a dump(App::getLocale()) - is it your default locale or anything else?

closed due to inactivity


hvac actions supported?

Hi,
I'm new to the integration and using it for less than two days now... so sorry, if this is already known or expected...
First - the integration of my AC works well - it is a Comfee Eco Cool Pro 2.9
But when I set the AC to cool, and it powers on, the Thermostat does not show, that the device is cooling.
Is this feature (hvac action) not supported?

compared to a heating Device:

Hi.
Unfortunately no this integration does not support hvac_action. The device doesn't provide any information about it's current state (e.g. idle, cooling, heating).

OK, thank you.


graphiql to autoupdate url parameters

Pull request checklist

[ ] Please read our contributor guide
[X] Consider creating a discussion on the discussion forum
first
https://github.com/Netflix/dgs-framework/discussions/475
[ ] Make sure the PR doesn't introduce backward compatibility issues
[ ] Make sure to have sufficient test cases

Pull Request type

[ ] Bugfix
[X] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Other (please describe):

Changes in this PR
Updates graphiql/index.html include script to trace user query in url parameters.
This makes query bookmarkable and shareble.
Describe the new behavior from this PR, and why it's needed
Issue #
Updates script to include generic solution used in all graphiql libraries to track user query
Alternatives considered

Allowing user to set custom spring property for customizing graphiql/index.html

Describe alternative implementation you have considered

Thanks for contributing this, @subbarao !
LGTM apart from one minor request: could you also add onEditHeaders to handle that GraphiQL operation?

Thanks for reviewing pr. Updated pr. Awesome library.


Remove Spartan support

DC/OS official Windows support will start with 1.11 release, which already has Spartan deprecated.

LGTM. Just one more thing before dropping support: can you make a different branch with what we have now i.e.: spartan_support ?

Nvm I just saw the tag for it.
Thanks for the PR!

@aserdean Yes. I had a tag for it. But I think that having a separate branch is a better idea. I removed the tag and created spartan_initial_support with the codebase before merging this PR.


Allow animating any component

Render children with no wrapper element.  That way you can render any component.

Or just allow setting the wrapper component...

Done in 0.5.0.  You can now specify the wrapping component.  It defaults to an 'g' elements.


CVE-2024-24786 - GHSA-8r3f-844c-mc37

A CVE with a moderate severity was published.
https://github.com/advisories/GHSA-8r3f-844c-mc37
The protobuf dependency needs to be updated to v1.33.0 or newer to mitigate this CVE.

Obsolete by now.


Alternative constructor that accepts multiple pairs as varargs?

The first thing I tried (because I didn't read the README carefully enough) was
dt = DispatchedTuple(Center() => "c", Face() => "f")

which didn't work because the input needs to be a tuple of pairs.
Would it helpful to users to define a constructor like
julia> DispatchedTuple(multiple_pairs...) = DispatchedTuple(Tuple(multiple_pairs))

so that the initial example works:
julia> dt = DispatchedTuple(Center() => "c", Face() => "f")
DispatchedTuple{Tuple{Tuple{Center, String}, Tuple{Face, String}}, DispatchedTuples.NoDefaults}(((Center(), "c"), (Face(), "f")), DispatchedTuples.NoDefaults())

I completely agree. I'm not sure how we can get that while still having a default argument while also avoiding keywords (which is purely my paranoia due to this issue). Maybe we can make a typed parameter constructor that has different interfaces?

Going to experiment a bit

Ah I guess default could become a keyword argument?
I think https://github.com/JuliaGPU/KernelAbstractions.jl/issues/114 might not apply here since the kwarg is just for the constructor and isn't used in the @kernel?
Unless you're constructing DispatchedTuples in kernels...

Yeah, I'd like for it to be fully gpu-friendly-- that said, based on how I think this might be used in ClimateMachine, I don't think the constructors will be used in gpu kernels.


feat: Add error callback

Summary
Adds an error callback to the various event logging methods
The tricky part to this is that the existing callback has very specific behavior not to be called when there's an error, except in the case where the error is with the state of the sdk client. In order to not break that behavior, I did the following

call both the existing callback and the new error callback wherever just the old callback was previously called for errors (not instantiating the API key, etc)
Calling just the error callback when a log request returns with something besides a 200

Checklist

[ ] Does your PR title have the correct title format?
Does your PR have a breaking change?:

https://amplitude.atlassian.net/browse/AMP-35348

Found a JIRA ticket from the last time this was encountered https://amplitude.atlassian.net/browse/AMP-35348

Still having the same issue
Hey there!
Today I installed amplitude-js 8.16.0, and it's not working when uBlock is turned on.
When I switch it off, it works just fine.
Any idea how to solve this?
Thanks!

Hi @gigiRa, this fix allows developers to detect when the JS SDK is blocked by uBlock or other blocker extensions, but it cannot bypass the extensions by itself.
If you're looking for a way to work around a blocking extension, one solution Amplitude recommends is to set up a proxy on your own servers https://developers.amplitude.com/docs/domain-proxies


Handle dark theme on MacOS.

What steps will reproduce the problem?
Open app
What is the expected output? What do you see instead?
Handle dark theme. Instead, some things are unreadable!

What version of the product are you using. (Please use the latest version of bittorrent-tracker-editor and your torrent client)
v1.33
On what operating system?
MacOS 12.6.3 (Monterey)
Please provide any additional information below.
This was just from opening the app and clicking around. No specific torrent files needed to visualize the issue.

Thanks for reporting the problem. It is now fixed in the latest released software.


[Feature] Shared defaults for load_yaml_dags

Description
It'd be nice to pass some shared default_args for a directory, either via a python object or a defaults.yml file in the directory.
Use case/motivation
One DAG per file is easier for users IMO, and as a system administrator I'd like to be able to give them a shared set of pre-baked defaults (env vars, etc.)
Related issues
#289, #290
Are you willing to submit a PR?

[x] Yes, I am willing to submit a PR!

Something like this?
./dags/default.yml
default:
  catchup: false
  default_args:
    start_date: "2024-01-01"
  schedule_interval: "0 0 * * *"
  tasks:
    extract:
      operator: airflow.operators.python.PythonOperator
      python_callable_file: /usr/local/airflow/include/etl_helpers.py
      python_callable_name: extract_helper
    load:
      dependencies:
      - transform
      operator: airflow.operators.python.PythonOperator
      python_callable_file: /usr/local/airflow/include/etl_helpers.py
      python_callable_name: load_helper
    transform:
      dependencies:
      - extract
      op_kwargs:
        ds_nodash: '{{ds_nodash}}'
      operator: airflow.operators.python.PythonOperator
      python_callable_file: /usr/local/airflow/include/etl_helpers.py
      python_callable_name: transform_helper

./dags/bi.yml
business_analytics:
  schedule_interval: "@daily"
  tasks:
    load:
      op_kwargs:
        database_name: BA
        table_name: inventory

./dags/ds.yml
data_science:
  tasks:
    load:
      op_kwargs:
        database_name: DS
        table_name: daily_sales

./dags/ml.yml
machine_learning:
  tasks:
    load:
      op_kwargs:
        database_name: ML
        table_name: training_data

...

@cmarteepants, only thing I think I'd add here is referencing the default values in .dags/bi.yml, etc.

@cmarteepants So basically bi.yml etc are merged on top of default.yml? Could you clarify how that works - does that happen for the entire yaml object tree key-by-key / lists extended / etc? How would you do overrrides? (Take a look at ChainMap for a simple comparison).
I had been mainly thinking of this only for default_args and that defaults.yml wouldn't provide any tasks (could use cross-dag dependencies for that)... but if defaults.yml is more like a template / base class that can be extended/overriden, that opens up some interesting possibilities, but not totally clear how that would work.
Docker compose does something similar, but the merge rules are kind of adhoc-yet-sensible

@wearpants If everything is contained in the same yaml today, yes anything in default is more like a template that can be extended AND overridden.
As for the how? I'll be honest: I haven't delved much into the source code to understand how this was implemented. Could be something we are getting "for free" from pyyaml, but never looked into it as the capability was around from before Astronomer took over the project. I opened up issue #295 so we can we document this properly. The examples in the issue are for extending, overriding and even generating the exact same dag structure with different task ids, and they all work.
I really like your idea about splitting up the definitions into different files though, and allowing for different defaults per folders. I'd even go so far as push that as a best practice. We'd need to allow for an order of precedence, but assuming we can pull it off (and I don't see why not, but I'm the PM :D) I agree, I think it would be really powerful.
I'll have someone on the engineering team start looking into this within the next few sprints. Do you want to be kept to update as things progress?

@cmarteepants yes please keep me in the loop, happy to hop on a quick design brainstorming session call as well if that be helpful

Sounds like a perfect use for https://hydra.cc
Might I suggest https://github.com/airflow-laminar/airflow-config


nixos/firefox-syncserver: init

Description of changes
@mweinelt asked for a non-ancient version of syncserver and we wanted to try it anyway, so here we go.
still some non-zero number of maintainers. we probably can't maintain this adequately, so it would be great if someone else wants to.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module
[x] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I intend to review this, I'm just a bit short on time right now, so I have to prioritize.

guess we'll try to maintain this after all. they seem to release rather rarely anyway.
latest update added CORS defaults, that's why the module changed.

tried to rebase to current master and mdize the docs, but git refused to work so we'll just have to do that another time

Deployed and works well enough. Package and module look well done, the documentation is better than most other modules out there and I love that the systemd unit has excellent hardening.


add a tag or tags  like ""  for escape character  ( or use Unix pattern-matching? )

Reported by Ansley B Manke on 29 Sep 2004 21:25 UTC
Difficult to embed an ESCAPE into a character string, for using special PPLUS
characters when in ASCII font.  Can't do it at all from an interactive session,
and not all text editors make it easy to put into a script (also, the script
isn't very human-readable).
We have the syntax  to set up multi-line labels - could easily add  as
well.

OR -

Do this with  a Unix-like (c-language like) approach that would support getting
a wide variety of special characters
\t == tab

== newline
\b == backspace
(see next bug for a bit of discussion) about a Ferret function that called the
Unix regular expression pattern matching functions.  Maybe there would be a way
to achieve the goal through that -- as in
let tab = STR_REGEXP("\t", " ")
(or something of that sort)
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/995

Comment by<EMAIL_ADDRESS>on 5 Nov 2004 19:05 UTC
changing "Severity" tag of bugs under Ferret Tasks to "enhancement"

Comment by<EMAIL_ADDRESS>on 5 Nov 2004 19:19 UTC
Changing Component of bugs in "Ferret Tasks" from All to Main


Enhancement/pr titles

TODO: With these changes we're successfully showing PR titles but we're not grouping all comments into a single PR title. Fix this.


feat(web-components): add React wrapper

Related Ticket(s)
Refs #4251.
Description
Adds React wrapper generator (createReactCustomElementType), based on one in carbon-web-components to @carbon/ibmdotcom-web-components codebase.
It helps our adaptors using React to use our components, with the following support that React itself lacks for non-intrinsic elements:

Element attributes mapping to non-string element property values (e.g. Boolean attributes)
React props mapping to element properties instead of element attributes
Event handlers

Also adds a Babel plugin that automatically creates React wrappers of our components from our components' @property() annotations, as well as the corresponding build process that generates the React wrappers to es/components-react directory. So in the most typical scenario, our users can use components in es/components-react directory in the same
manner as regular React components.
Also adds React stories so we can demonstrate the React integration.
Changelog
New

React wrapper generator (createReactCustomElementType).
Build logics to generate React wrapper, one for running in browser and one for running in Node.

Changed

Moves enums to defs.ts to make above build steps simpler.

Thank you @asudoh ! Can you resolve the conflicts?

Thanks @kennylam for reviewing! @jeffchew Merged.


Backport BF16 Support to Necessary Ops

See details in this comment: https://github.com/ROCm/frameworks-internal/issues/9790#issue-2591852147

Thanks! @ScXfjiang could sqush as one commit and list all added bf16 supports in thie one commit message, please?

Thanks! @ScXfjiang could sqush as one commit and list all added bf16 supports in this one commit message, please?

done


Add link to Code of Conduct

This adds a link to the Rust Code of Conduct to the repo, so that it is also tracked by GitHub. Although all of the rust-lang org is part of this code of conduct, I think it is good to be explicit in each repo just for clarity. I'm adding just a link to the actual CoC just to avoid needing to deal with synchronizing it should it ever change.

I don't believe a change like this warrants a few consensus round, so I'll merge this as is.


Add process distribution

Description of the issue
From issue #832: Add the economic concept of distribution.
Ideas of solution
First idea: Distribution is the process of delivering goods and services to consumers.
Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every entry in the ontology should have a definition
[ ] classes should arise from concepts rather than from words

Any objections against my proposed definition: Distribution is the process of delivering goods and services to consumers.

I like it.
Maybe add ... or intermediaries / providers. ? Not sure if that's true @han-f ?

I like it too, can't we formulate it even more general: Distribution is the process of delivering goods and services to agents. ?

I agree, too.
Can we formulate some relations between:

distribution
goods/service
agent
?

If the definition of distribution would only include goods, then at least the relation between good and distribution would be easy: distribution has participant some good. But as good is a material entity and thus an independent continuant while service is a process and thus a occurant we cannot use the relation has participant here (has participant connects a process with a continuant).
Regarding the relation to agent I have currently no idea how to formulate this. The agent is here somehow the recipient of the output/participant/whatever of the distribution process.
But maybe as distribution is (at least currently) not a core concept, we maybe can implement now only the definition but leave out the relations. We can still deal with that at some point in future when we see that really needs some relations here.


NSError init

Hi, heads up, got this error when compiling for ios9

[NSError init] called; this results in an invalid NSError instance. It will raise an exception in a future release. Please call errorWithDomain:code:userInfo: or initWithDomain:code:userInfo:. This message shown only once.

I haven't tried fixing it, but assume it's how the NSError is being instantiated at line 114 in SocialAuthPlugin.m

How to solve this problem?

I solved it replacing:
NSError *error = [[NSError alloc]init];
to
NSError *error = nil;


this error is showing after update 2.2.31 version update

\GeneratedPluginRegistrant.java:129: error: cannot find symbol
flutterEngine.getPlugins().add(new fman.ge.smart_auth.SmartAuthPlugin());
^
symbol:   class SmartAuthPlugin
location: package fman.ge.smart_auth
1 error

SmartAuth was removed from Pinput in versions ^5.0.0, so that I don't force people who don't want to use SMS autofill to depend on it and avoid building issue like this.
If you need the SMS autofill on android and still having same issue, please checkout the SmartAuth repo.


[FLINK-25553][filesystem][mapr] Remove MapR filesystem

What is the purpose of the change

Remove the MapR filesystem implementation

Brief change log

Removed MapR implementation
Removed references to MapR in documentation
Remove references to MapR in CI scripts

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): yes
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

I still found a mention in flink-python/pyflink/datastream/stream_execution_environment:303
There are also some in the Kafka Connector but I am unsure if it is safe to remove the codepath

I still found a mention in flink-python/pyflink/datastream/stream_execution_environment:303 There are also some in the Kafka Connector but I am unsure if it is safe to remove the codepath

Thanks, I've removed the Python one. The MapR is related to MapR Kafka's implementation for metrics, not to MapR filesystem so let's leave that for now (even though I don't think anyone is still running MapR Kafka)


Some question about Layernorm and GroupNorm.

Thanks for your good work in the CV area.
I have some questions about GroupNorm and LayerNorm.  The GroupNorm with group_num = 1 is equivalent to the LayerNorm. Why does GroupNorm outperform LayerNorm in your ablation study (Table. 6)?
A simple example from https://pytorch.org/docs/stable/generated/torch.nn.GroupNorm.html
input = torch.randn(20, 6, 10, 10)
# Separate 6 channels into 3 groups
m = nn.GroupNorm(3, 6)
# Separate 6 channels into 6 groups (equivalent with InstanceNorm)
m = nn.GroupNorm(6, 6)
# Put all 6 channels into a single group (equivalent with LayerNorm)
m = nn.GroupNorm(1, 6)
# Activating the module
output = m(input)
Looking forward to your reply!

Hi @Yangr116 , this is a small mistake in the PyTorch GroupNorm API explanation. I have reported it to PyTorch. This issue is duplicated to issue #9 where I have given some explanation. Hope this can help you to understand it.

Duplicate of #9

Thanks for your quickly reply!
---Original---
From: "Weihao @.>
Date: Thu, Dec 2, 2021 18:57 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [sail-sg/poolformer] Some question about Layernorm and GroupNorm. (Issue #11)
Duplicate of #9
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.