[Bug]: Existing types don't permit anything custom in event.locals

Package
@lucia-auth/sveltekit
Package version
0.5.2
Describe the bug
Adding anything custom to event.locals, results in handleHooks(auth) types being incompatible.
For example, if I want to add something to event.locals in the second hook in the sequence like so:
// hooks.server.ts
import { auth } from "$lib/server/lucia"
import { handleHooks } from "@lucia-auth/sveltekit"
import type { Handle } from "@sveltejs/kit"
import { sequence } from "@sveltejs/kit/hooks"

const customHandle: Handle = async ({ event, resolve }) => {
	event.locals.somethingCustom = "Hello"
	return resolve(event)
}

export const handle = sequence(handleHooks(auth), customHandle)

// app.d.ts
import type { SetSession, Validate, ValidateUser } from "@lucia-auth/sveltekit"
import type { RequestEvent } from "@lucia-auth/sveltekit/types"
import type { Session } from "lucia-auth"

declare global {
	namespace App {
		// interface Error {}
		interface Locals {
			validate: Validate
			validateUser: ValidateUser
			setSession: SetSession
			somethingCustom: string
		}
		// interface PageData {}
		// interface Platform {}
	}
	/// <reference types="lucia-auth" />
	declare namespace Lucia {
		type Auth = import("$lib/server/lucia").Auth
		type UserAttributes = {
			email: string
		}
	}
}
export {}

I get the following TypeScript error:

Due to this:
// @lucia-auth/sveltekit/types.d.ts
export type RequestEvent = {
    request: Request;
    locals: {
        validate: () => Promise<Session | null>;
        validateUser: () => Promise<{
            session: Session;
            user: User;
        } | {
            session: null;
            user: null;
        }>;
        setSession: (session: Session | null) => void;
    };
    url: URL;
    cookies: {
        get: (name: string) => string | undefined;
        set: (name: string, value: string, options: any) => void;
        delete: any;
        serialize: any;
    };
    fetch: any;
    getClientAddress: any;
    platform: any;
    params: any;
    route: any;
    setHeaders: any;
    isDataRequest: any;
};

System info
"@lucia-auth/sveltekit": "^0.5.2",
Reproduction
No response
Relevant log output
No response
Additional information
No response

Hi @huntabyte, nice to see you here!
Will try to fix it today

@pilcrowOnPaper happy to be here! This project is fantastic and exactly what I've been looking for personally. Currently working on a video about it so I'm getting into the weeds a bit 😃

Should be fixed with @lucia-auth/sveltekit 0.5.3

@huntabyte Super happy to hear that! If you have any questions, feel free to ask them in Discord (most active there)!

@huntabyte
Will push a new breaking change this weekend so you might want to hold off the video just a bit

@huntabyte
I'll be attempting to push a new breaking change this weekend so you might want to hold off the video for just a bit.

Thank you for the heads up! @pilcrowOnPaper

Thank you for the heads up! @pilcrowOnPaper


Add chapter on release workflow

Hi @didier-wenzek !
Here are the changes @rina23q and I would like to add to the governance for the release workflow as requested by @TheNeikos and you!
This PR is done towards your rfc/governance branch!
I think the best idea would be that you merge (or cherry-pick) this patch to your bnanch/PR and we discuss there, so that the discussion is not spread over multiple repositories and pull requests!

I will merge this PR unchanged into the main PR. As you said it's better to have all the comments in a single place. However, I have   the feeling that this proposal is over-sized for the current state of thin-edge and even for the mid-term.


Broken links mostly

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
AcrolinxScore
LowestCategoryScore
Issues
Scorecard
Processed

enterprise-graph/concepts/inheritance.md
80
32
3
link
:white_check_mark:

enterprise-graph/concepts/ontology.md
87
39
3
link
:white_check_mark:

enterprise-graph/index.yml

link
:warning:

enterprise-graph/input-data-concepts.md
80
41
7
link
:white_check_mark:

enterprise-graph/ontology-tutorial.md
81
53
17
link
:white_check_mark:

enterprise-graph/source-schema-concepts.md
78
40
23
link
:white_check_mark:

enterprise-graph/source-schema-tutorial.md
78
53
6
link
:white_check_mark:

More info about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues

OPS Build status updates of commit 3edc48d:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

enterprise-graph/index.yml
:x:Error

Details

enterprise-graph/input-data-concepts.md
:warning:Warning

Details

enterprise-graph/ontology-tutorial.md
:warning:Warning

Details

enterprise-graph/source-schema-concepts.md
:warning:Warning

Details

enterprise-graph/source-schema-tutorial.md
:warning:Warning

Details

enterprise-graph/index.yml

[Error] Unable to load file 'index.yml' via processor 'YamlDocumentProcessor': (Line: 56, Col: 13, Idx: 2412) - (Line: 58, Col: 3, Idx: 2507): While scanning a quoted scalar, find unexpected end of stream.

enterprise-graph/input-data-concepts.md

Line 27: [Warning] Invalid file link:(~/../source-schema-tutorial.md).
Line 27: [Warning] Invalid file link:(~/../ingestion-tutorial.md).
Line 27: [Warning] Invalid file link:(~/../ontology-tutorial.md).
Line 27: [Warning] Invalid file link:(~/../schema-map-tutorial.md).

enterprise-graph/ontology-tutorial.md

[Warning] Author stflanag cannot be recognized in GitHub.

enterprise-graph/source-schema-concepts.md

Line 0: [Warning] Invalid file link:(~/schema-map-concepts).
Line 20: [Warning] Invalid file link:(~/media/creating-your-ontology/1_ontology_config.png).
Line 42: [Warning] Invalid file link:(~/media/creating-your-ontology/create_source_schema.png).
Line 58: [Warning] Invalid file link:(~/media/creating-your-ontology/fields_not_mapped.png).

enterprise-graph/source-schema-tutorial.md

[Warning] Author stflanag cannot be recognized in GitHub.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
AcrolinxScore
LowestCategoryScore
Issues
Scorecard
Processed

enterprise-graph/concepts/inheritance.md
80
32
3
link
:white_check_mark:

enterprise-graph/concepts/ontology.md
87
39
3
link
:white_check_mark:

enterprise-graph/index.yml
100
100
0
link
:white_check_mark:

enterprise-graph/input-data-concepts.md
80
41
7
link
:white_check_mark:

enterprise-graph/ontology-tutorial.md
81
53
17
link
:white_check_mark:

enterprise-graph/source-schema-concepts.md
78
40
23
link
:white_check_mark:

enterprise-graph/source-schema-tutorial.md
78
53
6
link
:white_check_mark:

More info about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues

OPS Build status updates of commit bf0c45b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

enterprise-graph/input-data-concepts.md
:warning:Warning

Details

enterprise-graph/ontology-tutorial.md
:warning:Warning

Details

enterprise-graph/source-schema-concepts.md
:warning:Warning

Details

enterprise-graph/source-schema-tutorial.md
:warning:Warning

Details

enterprise-graph/concepts/inheritance.md
:white_check_mark:Succeeded

enterprise-graph/concepts/ontology.md
:white_check_mark:Succeeded

enterprise-graph/index.yml
:white_check_mark:Succeeded

enterprise-graph/input-data-concepts.md

Line 27: [Warning] Invalid file link:(~/../source-schema-tutorial.md).
Line 27: [Warning] Invalid file link:(~/../ingestion-tutorial.md).
Line 27: [Warning] Invalid file link:(~/../ontology-tutorial.md).
Line 27: [Warning] Invalid file link:(~/../schema-map-tutorial.md).

enterprise-graph/ontology-tutorial.md

[Warning] Author stflanag cannot be recognized in GitHub.

enterprise-graph/source-schema-concepts.md

Line 0: [Warning] Invalid file link:(~/schema-map-concepts).
Line 20: [Warning] Invalid file link:(~/media/creating-your-ontology/1_ontology_config.png).
Line 42: [Warning] Invalid file link:(~/media/creating-your-ontology/create_source_schema.png).
Line 58: [Warning] Invalid file link:(~/media/creating-your-ontology/fields_not_mapped.png).

enterprise-graph/source-schema-tutorial.md

[Warning] Author stflanag cannot be recognized in GitHub.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Added support for GitHub Container Registry

Is there a related GitHub Issue?
No related Issue.
What is this change about?
The GitHub container registry is a good place to try out korifi because private images are available for free.
So, I added a description of the GitHub container registry to the installation instructions.
Does this PR introduce a breaking change?
No breaking change.
Acceptance Steps
NA
Tag your pair, your PM, and/or team
NA
Things to remember
NA

Thank you for your contribution @kei-yamazaki


Build generic derivation of UIs

Build generic derivation / type directed metaprogramming construction of UIs. So give, for example, a case class we can automatically construct a UI that renders it, and a form that fills it in.
It would be useful to have this for functions as well, to support Doodle Explore.
Look at Scala 3 libraries for this: Magnolia and Shapeless.

Handling the Algebra type in Component is challenging in generic derivation. Working without a library seems the best route.


Hbase [READ-FAILED] during YCSB Benchmarking

I am using CDH and through that insatlled HBase and downloaded YCSB Package.Now while running test on Hbase using following command :
ycsb run hbase10 -p columnfamily=cf -P /usr/share/ycsb/workloads/workloada -s -threads 100 -p  recordcount=5000 -p operationcount=5000
Its giving output as follows where near about 50% reads are failing :
[OVERALL], RunTime(ms), 7059.0
[OVERALL], Throughput(ops/sec),<PHONE_NUMBER>426973
[READ-FAILED], Operations, 938.0
[READ-FAILED], AverageLatency(us), 6417.266524520256
[READ-FAILED], MinLatency(us), 897.0
[READ-FAILED], MaxLatency(us), 157567.0
[READ-FAILED], 95thPercentileLatency(us), 18223.0
[READ-FAILED], 99thPercentileLatency(us), 45887.0
[CLEANUP], Operations, 200.0
[CLEANUP], AverageLatency(us), 1489648.93
[CLEANUP], MinLatency(us), 3.0
[CLEANUP], MaxLatency(us), 5054463.0
[CLEANUP], 95thPercentileLatency(us), 4960255.0
[CLEANUP], 99thPercentileLatency(us), 5046271.0
[READ], Operations, 1559.0
[READ], AverageLatency(us), 7588.287363694676
[READ], MinLatency(us), 970.0
[READ], MaxLatency(us), 178047.0
[READ], 95thPercentileLatency(us), 21903.0
[READ], 99thPercentileLatency(us), 59583.0
[READ], Return=OK, 1559
[READ], Return=NOT_FOUND, 938
[UPDATE], Operations, 2503.0
[UPDATE], AverageLatency(us), 13026.518977227328
[UPDATE], MinLatency(us), 2686.0
[UPDATE], MaxLatency(us), 200575.0
[UPDATE], 95thPercentileLatency(us), 33599.0
[UPDATE], 99thPercentileLatency(us), 61599.0
[UPDATE], Return=OK, 2503
I tried changing split_no during database creation,Also read replication factor also enabled and made 3 during table creation.
I am searching why this is happening, but no luck, Can anybody please help me to make this work ??

bump @AnkitaD can you please post the load command you ran?

I came to know the solution for an issue , actually loading data command had an issue not able to load data properly. YCSB tests are going good now

Excellent. Thanks for following up!


Input group addon w/ calendar icon

I see a closed issue/request #45 for this feature.. i'm sure i'm not the only person that would be interested to see this feature added.
I'd be willing to contribute if you give me your guidelines to make a PR.

I'm closing this as this could be achieved by what we're discussing in #153. So continue any further discussions there. Thanks.


Add a clear button the to jsonlint.com page

Hi,
Json lint is a very useful app.
Could you add a "Clear" button which removes the json text and resets the focus back to the input area. At the moment you have to drag and select all and then hit delete to remove the existing text.
thanks!

I've created a Pull Request for this, if you don't mind.


Fix variables serialization bug in TestProxyRecordPolicy

Description
Fixes a bug in TestProxyRecordPolicy where additional " were being added to the serialized variables. Also, adds an inspection of the status code when stopping recording and throws an error if it's an error status code.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Task management menus

This is great - I really like this new format. I have a couple of suggestions simplify things.
Under "New Task" only have 3 options: Current task w custom expressions, without custom expressions and Empty.
Put the "default" tasks in the Library.
Under Browse/Load/Edit, specify SQUID**3**where appropriate (not just squid).  I would change the name to "built in Task Library" to make it very clear what the library represents.  Likewise I would change the menu item to say "custom Task folder", rather than just folder.  Those two edits might make the difference between library and folder more clear.
It also seems to me that there is no need in this menu to have the option to load/edit an individual task as well as browse the folder.  It is simpler, but just as effective to call this menu item Browse,  and it would only contain 3 choices: SQUID3 Built In Task Library, SQUID3 Custom Task Folder, SQUID2.5 Folder.  From within the browse you then get to pick the individual task where you can either edit or replace.   On a related note, when I select a folder (and this is the case when I select a folder for importing of custom expressions) I can never see a list of the files that are within that folder (not to select, just to see the list of file names).  That is not great if I want to confirm that I have selected the "correct folder", but not sure if that is not really a tractable problem as it implicates operating systems etc.

great ideas!

On a related note, when in Data > Manage spots and RMs,  the blue hint bar should now read:
Task > View, New or Browse (not Task > Manage Task)

@NicoleRayner - when you say see list of file names do you mean all names even files that are not tasks?  If just valid task files, we could provide file name in tool tip hover, but they will likely be the same as the task name;  the folder name is displayed at the top;  also, when choosing folder, you can open it in your file explorer and still choose the whole directory .... need more details here as to what is needed.

When I browse files in my normal Windows File Explorer I see this:

When I browse to the same folder within SQUID3, this is what I see:

The task is in there, it just doesn't show in a list so I can be 100% sure I have selected the correct folder until I actually say "Select Folder" and view in in the SQUID3 browser.

can't you click one more time and show the contents?  what is the filter at the bottom showing as an extension?  are you showing extensions in your file browser?  might need a screen-sharing session.


Fix/183 ack not supported in core nats

Should close #183

Thanks for your amazing work once again ! I'll merge it ASAP.
I still have to write the contribution documentation, but if one day you want to be a maintainer, you would be more than welcomed :)


Private entry fields

I did not add methods to mutate fields yet. We can add those if the need arises.
Not only privatises Entry, but also Range3d and Area.

What does making these fields private get us? To make it impossible to mutate fields after construction?

That is not the primary reason. It allows us to later change the definition of the types. We might have an enum where one variant looks like the current struct, but another variant is simply a pointer into a refcounted buffer that contains an encoded version we got from somewhere. Or for Entry, we might decide to group path, subspace_id and timestamp together in a substruct that can be used for addressing things in a store.
By using public fields, all those options would require a breaking change.


Use indexmap to preserve order (optional)

Introduces an optional indexmap feature which uses IndexMap in Value::Map to preserve the order of deserialized elements.
Fixes #129

If I understand correctly, this would only preserve the order of Value types but not regular maps?

Exactly. If one wants to preserve the order elsewhere, they should use IndexMap there, too.

Thanks for the review!
bors r+


Crash on Android

After upgrading to RN 0.34, the sample app crashes on Android.

Did you do the manual upgrade between v0.28 -> v0.29? My PR upgrades the SampleApp to v0.36 https://github.com/d-a-n/react-native-modal-picker/pull/25


Extract the Printers into munit-diff

In the #756  munit-diff was extracted, so that it can be used outside of munit context, as it is a very useful micro library.
The diffing mechanism is based on class Diff(val obtained: String, val expected: String), where a string representation of a datatype is expected. It is optimized for the Printers, which are currently in munit module (for toString it doesn't work as nicely, in munit it is merely a fallback mechanism if Printers do not reveal any difference).
I can work on extracting it into munit-diff, but wanted to ask for green light here, maybe there are some gotchas that I missed and it was left out on purpose.

I don't remember any issues, but maybe @majk-p does?

Cant tell for sure, but likely it was due to Printers dependency on munit.Clue, which we didn't want to include in munit.diff.

I'm closing this issue, turns out there is an ongoing effort to have the pretty diffing baked into weaver as part as ongoing migration to typelevel.


Upgrade tcell to v2.x

A draft PR to close #254
I'll push stuff here as I get stuff working.

Pull Request Test Coverage Report for Build 1897

34 of 34 (100.0%)  changed or added relevant lines in 2 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 91.924%

Files with Coverage Reduction
New Missed Lines
%

terminal/terminalapi/color_mode.go
5
0%

Totals

Change from base Build 1886:
-0.04%

Covered Lines:
7968

Relevant Lines:
8668

💛  - Coveralls


Disable hover

Hi, I would really appreciate the option for disabling the option to hover.
The color change in the star ratings while hovered can limit the use in mobile phones or touch users.
Thanks

@lidoraz You can do something with CSS like you can add style to StarRating with pointer-events:none which will disallow all pointer-events though.

@lidoraz remove changeRating method it will disable component.


ci: drop unused python exclusions

Drop some exclusions for python 3.6, this version is not tested in the first place anyway so these are redundant.

this version is not tested in the first place anyway

and EOL'd nearly 3 years ago, too :)


Kubewatch getting restart due to Nats

Kubewatch gets restart whenever Nats throws error while creating stream.
To Reproduce
this bug is intermmittent, trying to reproduce it.
Expected behavior
We should have a retry mechanism atleast during these cases.
Current behavior
We restart the kubewatch for this scenario.
Logs
2022/08/31 10:02:32 No stream was created already. Need to create one.Stream nameKUBEWATCH
2022/08/31 10:02:37 Error while creating streamstream nameKUBEWATCHerrorcontext deadline exceeded

AB#202

Yes @anupdhiran Sure.


Logs not enabled

The LOGS_DIR has no effect. If you take a look at the wrapper (at least for ubuntu) the only variable that has effect it's LOGS (which it's commented).
# This file is managed by Puppet

# enables mesos logging, otherwise stdout goes to LOG_DIR
#LOGS=/var/log/mesos
# both master and slave will log into syslog file
USE_SYSLOG="<%= @use_syslog %>"
# separate 'master.log' and 'slave.log' files
LOG_DIR="<%= @log_dir %>"

From the mesos-init-wrapper:
[[ ! ${LOGS:-} ]]           || args+=( --log_dir="$LOGS" )

Right, I guess we can set the LOGS variable, but by default it will be undefined, so that we won't break current installations. Is that ok for you?

Of course, It was just that I didn't know what was happening. Thank you!


Still can't get it working

HI,
thanks for your prompt response. Sorry, I did try that as well, just forgot to mention it. I may not have done it 100% correctly then, here is what I did:
Opened the global.lua file from in vscode. copy and pasted the contents from first file, copy and pasted second file and removed the #include part. I tried two ways, I put it inside the onLoad function, and I tried adding it after the function. None worked, I did not put before the function, would that really make a difference? I will try it again at some point today.
Also, can it just go in the global.lua file or does it have to go in all lua files if I want to debug each file?
Thanks again!
EDIT: I Have a feeling this maybe outdated now. I just installed Atom and did as you said, it seems to import the files correct but when I follow your tutorial inside TTS the commands don't work. I noticed your tut says to type the commands in to the "game" windows, but you can't do this? Maybe TTS has changed this and this is why it no longer works?? Would really appreciate it if you could give it a quick test yourself to see if indeed it now longer works with new TTS versions.

Found out what it was I was doing wrong. I was mixing bits up from another mod. Gotta say buddy, you did a great job with this mod! thanks


Lambda-selenium-java

Initial commit of lambda-selenium-java source code. Includes requests needed to activate test suite in lambda, as well as run tests in parallel.
This PR is not for the finished POC but to have a start to make adjustments to.

Try not to get too carried away... Make sure that any tests that are included are easy to follow, thats the ultimate goal of this, to present an easy way to use selenium/chrome/lambda with Java. Looking good so far, it is quite featured.


Globus Learning - Write and test initial API code for (standard) transfer

Write, verify, and test Python Globus API code for (standard) file transfer from endpoint to endpoint.

This issue is essentially completed. AND the intent is superseded by other issues in the cited epic: #1219


Usage of old mongoose index practice

DeprecationWarning: collection.ensureIndex is deprecated. Use createIndexes instead.

@ItayKatzCC thanks for reporting. Could you open a Pull Request with the fix?


NameError: name 'CriterionType' is not defined

bash single_file_inference.sh
../../utils/inference/single_file_inference.py:29: UserWarning: flashlight python bindings are required to use this functionality. Please install from https://github.com/facebookresearch/flashlight/tree/master/bindings/python
"flashlight python bindings are required to use this functionality. Please install from https://github.com/facebookresearch/flashlight/tree/master/bindings/python"
Traceback (most recent call last):
File "../../utils/inference/single_file_inference.py", line 381, in
result = parse_transcription(args_local.model, args_local.dict, args_local.wav,  args_local.cuda, args_local.decoder, args_local.lexicon, args_local.lm_path, args_local.half)
File "../../utils/inference/single_file_inference.py", line 348, in parse_transcription
generator = W2lViterbiDecoder(args, target_dict)
File "../../utils/inference/single_file_inference.py", line 143, in init
super().init(args, tgt_dict)
File "../../utils/inference/single_file_inference.py", line 84, in init
self.criterion_type = CriterionType.CTC
NameError: name 'CriterionType' is not defined
Trying to run bash single_file_inference.sh but getting error related to flashlight. Searched for resolution but nothing helps.
please can someone help me.
I tried reinstalling flashlight multiple times but getting the same issue everytime

@vpurandara @harveenchadha Can you please tell how you have solved this issue? I am also facing same issue. It would be great if you share the solution of it.


this.context.router.getCurrentPathname() returns this.context.router.getCurrentPath()

Hello,
I would like to retrieve the name of current route in my app, in order to apply a layouts according to route names. Unfortunately, this.context.router.getCurrentPathname() doesn't give me the name of the route but the path.

Yes, pathname refers to the path in the URL without the query string, similar to window.location.pathname.
You might want to look into isActive(routeName, ...) and see if that can solve your problem. Otherwise, you can get the current route names with getCurrentRoutes(). It'll give you an array since there are usually multiple routes active at a time. For example
var routes  = router.getCurrentRoutes();
var innerRouteName = routes[routes.length - 1].name;

Thanks for your help @taurose but this is not working for me... I use the este.js dev stack that is not using mixins but exports... Here is my code :
render() {
    // TODO: Fix route name, use real ones in stead of pathname

    var {router} = this.context,
        routeName = router.getCurrentPathname(),
        currentLayoutConfig = RoutesLayoutsLinks[routeName] || RoutesLayoutsLinks['defaultLayout'],
        CurrentLayoutComponent = layouts[currentLayoutConfig.name];

    console.log(router.routes[0].childRoutes[router.routes[0].childRoutes.length-1].name);

    return (
      <ReactCSSTransitionGroup component="div" transitionName={currentLayoutConfig.layoutTransitionName}>
        <CurrentLayoutComponent {...this.state} key={currentLayoutConfig.name}>

            <ReactCSSTransitionGroup component="div" transitionName={currentLayoutConfig.pageTransitionName} >
              <RouteHandler {...this.state} key={routeName}/>
            </ReactCSSTransitionGroup>

        </CurrentLayoutComponent>
      </ReactCSSTransitionGroup>
    );
  }

It gives me a route but it is not the current one...

Thanks @taurose ! It worked for me !

render() {
    var {router} = this.context,
        currentRoutes = router.getCurrentRoutes(),
        routeName = currentRoutes[currentRoutes.length - 1].name,
        currentLayoutConfig = RoutesLayoutsLinks[routeName] || RoutesLayoutsLinks['defaultLayout'],
        CurrentLayoutComponent = layouts[currentLayoutConfig.name];

    return (
      <ReactCSSTransitionGroup component="div" transitionName={currentLayoutConfig.layoutTransitionName}>
        <CurrentLayoutComponent {...this.state} key={currentLayoutConfig.name}>

            <ReactCSSTransitionGroup component="div" transitionName={currentLayoutConfig.pageTransitionName} >
              <RouteHandler {...this.state} key={routeName}/>
            </ReactCSSTransitionGroup>

        </CurrentLayoutComponent>
      </ReactCSSTransitionGroup>
    );
  }


Correct TryGetCollectionCount usage in PadStart

Previous updates had attempted to correct the behavior of PadStart by moving TryGetCollectionCount into a local method, but since that method is not an iterable method, it does not correctly address the issue. PadStart should be updated to correctly use TryGetCollectionCount.

Completed by #175


ubloxd_main.cc : should be 'delete msg', not 'free(msg)'

https://github.com/commaai/openpilot/blob/10cb6ab87ab812ada7c26d5b67d95a739d8d3b54/selfdrive/locationd/ubloxd_main.cc#L105-L107
@pd0wm
btw, I'v submitted a PR for single SubSocket https://github.com/commaai/openpilot/pull/1716

Fixed! Saw your PR, still need to review it but like the cleanup.


Metrics interpretation

Hi, and thank for this great integration! :)
I have a couple of questions regarding the calculated metrics:

How to interpret "Body score"? How is it calculated?
How to interpret "Lean body mass"? In my case it's a bit off from simple "body weight" - "body fat weight" formula.
Should "Lean body mass" and "Visceral fat" be in kilograms (currently they don't have units)?
Why different metrics have different decimal precision (e.g. "Muscle mass" has 2, "Lean body mass" 1 and "Visceral fat" 0).

Thanks!

Hi, I was close to create an issue, but it seems I'm not alone and I confirm that body mass and visceral fat do not have unit while others do.
I saw somewhere else someone asking for having BMI in kg/m². Personally, I'm not a big fan and I'm not sure if this unit is registered in the HA core, but, well, why not?
Now, thanks to the issue created by BishKopt, it came to my eyes that the decimal precision is indeed not the same. If this 'glitch' is not intentional and is easy to fix, I vote for having at least one decimal place of precision. Anyway, the sensors are not that precise, and the metrics are just rough approximate functions based on rough statistics gathered years ago from a non-fully representative population.
Thank for the integration and your consideration

I have a somewhat relateed question... Do these values make sense at all?
It makes sense that the body fat percentage can be estimated based on impedance, age, weight and gender. However, for example the in visceral fat calculation:
https://github.com/dckiller51/bodymiscale/blob/7294b9a1653b111042dff0fb0ee700f79926ac5f/custom_components/bodymiscale/metrics/weight.py#L41-L74
...all the input variables present are height, weight and age. If I'm not mistaken, this is essentially something similar to the BMI, but in no way is this value actually a measure of visceral fat, correct? Every person with the same age, height, weight and gender will get exactly the same visceral fat value, no matter how their body is built.


Replace Black Box term with Opaque or similar neutral terms

The terms black box / white box are seen borderline racist by many due to common perception of black being used for something negative and white with something good. The racist implications of such terms are not always clear, and there is rarely consensus. It may be however better to avoid and replace such terms with more neutral language. It is therefore requested to use more neutral terminology instead of such oppressive language.
Lets replace:

blacklist / whitelist -> blocklist / allowlist
master / slave to leader / worker
white/black box -> clear/opaque or closed/glass box
whitespace -> Emptyspace

The term black box appears:

line 54 of setup.py
line 7 of README.rst
line 64/66 of maggy/experiment.py
line 33 of maggy/optimizer/bayes/base.py

Closing this, the term "Black Box" is well established in the research community, which I personally perceive as very diverse and representative, and to this point the term had no connection to race or anything the like.


Break tag missing in Main README file

There is a missing tag in the main README file. I am a contributor in SSOC '24. My name is Akarsh Gupta

Closing this issue as spam. Adding a <br> tag in a README file will not give you points anyway.


Add Convex integration

This PR adds an integration with Convex: https://convex.dev/
Convex is a cloud database, in a similar category to Firebase, Supabase, Neon or Planetscale.
This PR includes three integration points:
ConvexVectorStore powered by https://docs.convex.dev/vector-search
ConvexKVStore powered by the database for easy embedding caching
ConvexChatMessageHistory powered by the database for easy memory-backed conversations
There are integration tests for all three pieces, and documentation. Below is example of all three of them coming together, following the https://js.langchain.com/docs/use_cases/question_answering/ guide. Langchain makes this sophisticated setup super easy with Convex. Let me know what else is required to get this PR merged.

  Click me to show the example, save it in convex/ai.ts

"use node";

import { CheerioWebBaseLoader } from "langchain/document_loaders/web/cheerio";
import { CacheBackedEmbeddings } from "langchain/embeddings/cache_backed";
import { RecursiveCharacterTextSplitter } from "langchain/text_splitter";
import { OpenAIEmbeddings } from "langchain/embeddings/openai";
import { ConvexVectorStore } from "langchain/vectorstores/convex";
import { ConvexKVStore } from "langchain/storage/convex";
import { ConvexChatMessageHistory } from "langchain/stores/message/convex";
import { ConversationalRetrievalQAChain } from "langchain/chains";
import { ChatOpenAI } from "langchain/chat_models/openai";
import { BufferMemory } from "langchain/memory";

import { action } from "./_generated/server";
import { v } from "convex/values";

// Action that downloads a blog post, chunks it, embeds it, and stores
// the chunks with associated embeddings in Convex.
export const populate = action({
  handler: async (ctx) => {
    const loader = new CheerioWebBaseLoader(
      "https://lilianweng.github.io/posts/2023-06-23-agent/"
    );
    const data = await loader.load();
    const textSplitter = new RecursiveCharacterTextSplitter({
      chunkSize: 500,
      chunkOverlap: 0,
    });

    const splitDocs = await textSplitter.splitDocuments(data);

    const embeddings = new CacheBackedEmbeddings({
      underlyingEmbeddings: new OpenAIEmbeddings(),
      documentEmbeddingStore: new ConvexKVStore({ ctx }),
    });

    await ConvexVectorStore.fromDocuments(splitDocs, embeddings, { ctx });
  },
});

// Action that allows interrogating GPT3.5 about the downloaded blog post.
export const ask = action({
  args: {
    session: v.string(),
    question: v.string(),
  },
  handler: async (ctx, args) => {
    const embeddings = new CacheBackedEmbeddings({
      underlyingEmbeddings: new OpenAIEmbeddings(),
      documentEmbeddingStore: new ConvexKVStore({ ctx }),
    });

    const vectorStore = new ConvexVectorStore(embeddings, { ctx });

    const sessionId = args.session;
    const model = new ChatOpenAI({ modelName: "gpt-3.5-turbo" });
    const memory = new BufferMemory({
      chatHistory: new ConvexChatMessageHistory({ sessionId, ctx }),
      memoryKey: "chat_history",
      outputKey: "text",
      returnMessages: true,
    });
    const chain = ConversationalRetrievalQAChain.fromLLM(
      model,
      vectorStore.asRetriever(),
      { memory }
    );

    const response = await chain.call({
      question: args.question,
    });

    return response;
  },
});

This is very slick. Nice work @xixixao 🙏

@jacoblee93 I removed all the _generated folders, but I wonder if we should keep them for examples, to not have TypeScript errors in them?
Hopefully addressed all the other feedback as well.

Ah, yes please add them back to examples then!

Sorry for the misunderstanding, I didn't realize the generated files were hard required. If they're absolutely necessary, yes add them back.
Looks good otherwise once it passes CI! Thanks for this!

@jacoblee93 I reverted the generated files, but looks like CI needs approval to run. Is there a good way to simulate the CI locally, so I can make sure it passes before we run it here?

Test is failing with:

Can you try running yarn test:exports:docker or yarn test:single yourtest.int.test.ts?

@jacoblee93 I fixed the build now, and tests are working again.

Thank you!

Rebased to remove merge conflict

@jacoblee93 I fixed the code, there are no real side effects there but it needed the #PURE annotations, as is used by other code in langchain.
We'll work on our side to add the appropriate annotations to the library functions so this is not necessary in the future.

@jacoblee93 I just rebased, would love to merge the PR in, thanks!

Small change above, will merge this and make another PR on top since it's gone on for a long time!
Thanks for your patience, there was a lot to look at, especially with the generated files. Breaking it up next time would be helpful.


Update README.md

Add instruction for installing required go package.

Great! Thank you for the contribution.


If URL changes the new URL is not downloaded

Hey guys,
I'm pretty new to SwiftUI therefore I'm not a big help fixing this, but I noticed that when changing the URL of the AsyncImage the new URL is not downloaded an displayed. I'm guessing the view needs to be destroyed first?
Here is what I'm using and what does not work:
...
if(libraryArtwork != nil) {
            AsyncImage(url: libraryArtwork!.artworkUrl(width: urlResolution(), height: urlResolution())!, content: { image in
                image.resizable()
            }, placeholder: {
                Rectangle().frame(width: width, height: width).foregroundColor(.gray)
            }).frame(width: width, height: width)
        } else {
            Rectangle().frame(width: width, height: width).foregroundColor(.gray)
        }
...

So in this case the libraryArtwork might be changed externally because it is coming from the viewModel.
Is the intended behaviour. Can I fix this somehow?

Hmm, I confirmed that SBPAsyncImage behaves differently with SwiftUI.AsyncImage.
It seems that onAppear is not called in ContentBody when the URL changes.
https://github.com/yutailang0119/SBPAsyncImage/blob/9033e10e719f0cfe670fc81c3278a1f7e92dd25b/Sources/SBPAsyncImage/BackportAsyncImage.swift#L124-L130
I'm thinking of solution.

I was able to reproduce it with following code.
struct ContentView: View {
    @State var isBool: Bool = true

    var body: some View {
        VStack {
            AsyncImage(url: url)
            Button("toggle") {
                isBool.toggle()
            }
        }
    }

    private var url: URL? {
        isBool ?
        URL(string: "http://httpbin.org/image/png")
        : URL(string: "http://httpbin.org/image/webp")
    }
}

I've tried another Package SDWebImageSwiftUI.
They have the same problem, but solved it in a hacky way: https://github.com/SDWebImage/SDWebImageSwiftUI/blob/336d3f6d3b53729c1f274bf6b75f4532ada116eb/SDWebImageSwiftUI/Classes/WebImage.swift#L58

Hey guys,
I'm pretty new to SwiftUI therefore I'm not a big help fixing this, but I noticed that when changing the URL of the AsyncImage the new URL is not downloaded an displayed. I'm guessing the view needs to be destroyed first?
Here is what I'm using and what does not work:
...
if(libraryArtwork != nil) {
            AsyncImage(url: libraryArtwork!.artworkUrl(width: urlResolution(), height: urlResolution())!, content: { image in
                image.resizable()
            }, placeholder: {
                Rectangle().frame(width: width, height: width).foregroundColor(.gray)
            }).frame(width: width, height: width)
        } else {
            Rectangle().frame(width: width, height: width).foregroundColor(.gray)
        }
...

So in this case the libraryArtwork might be changed externally because it is coming from the viewModel.
Is the intended behaviour. Can I fix this somehow?

Instead of generating the url when you init AsyncImage, if you create a new View struct and take in width and height as params then set create the url and assign it to a let, then create AsyncImage using the url created, it usually solves problems like this because this is how SwiftUI works - body is only called if the View's lets are different.


Introducing a UpdateRecord

In order to support more general updates, this commit introduces the
concept of UpdateRecord. The first two versions of this record are
equivalent to DeleteRecord versions 1 and 2, The third version is
able to encapsulate different types of records.
This commit adds read support. A future commit will convert the
DeleteMessageFormatInputStream to write in the new format.

Codecov Report

Merging #897 into master will increase coverage by <.01%.
The diff coverage is 68.99%.

@@             Coverage Diff              @@
##             master     #897      +/-   ##
============================================
+ Coverage     67.16%   67.16%   +<.01%
- Complexity     4275     4279       +4
============================================
  Files           356      357       +1
  Lines         27887    27946      +59
  Branches       3547     3558      +11
============================================
+ Hits          18731    18771      +40
- Misses         8176     8187      +11
- Partials        980      988       +8

Impacted Files
Coverage Δ
Complexity Δ

...in/java/com.github.ambry/store/DumpDataHelper.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ava/com.github.ambry/store/HardDeleteVerifier.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ambry.messageformat/MessageSievingInputStream.java
77.45% <100%> (ø)
14 <0> (ø)
:arrow_down:

....messageformat/DeleteMessageFormatInputStream.java
100% <100%> (ø)
2 <0> (ø)
:arrow_down:

...a/com.github.ambry.messageformat/DeleteRecord.java
100% <100%> (ø)
1 <1> (-3)
:arrow_down:

...a/com.github.ambry.messageformat/UpdateRecord.java
100% <100%> (ø)
7 <7> (?)

...ithub.ambry.messageformat/BlobStoreHardDelete.java
87.64% <60%> (-1.05%)
6 <0> (ø)

....github.ambry.messageformat/BlobStoreRecovery.java
78.04% <75%> (-1.7%)
6 <0> (ø)

...ithub.ambry.messageformat/MessageFormatRecord.java
85.71% <76.92%> (-1.24%)
26 <0> (+1)

...c/main/java/com.github.ambry.network/Selector.java
78.48% <0%> (-3.59%)
44% <0%> (-1%)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c313d78...49874a6. Read the comment docs.

Ran ./gradlew build && ./gradlew test both on the code as it is in this PR and by locally changing the version used for deletes to Update_Format_V3 - the "write" change that will follow this change (tweaks in the DeleteMessageFormatInputStream and some tests - like the ServerHardDeleteTest). Succeeded on both counts.

@pnarayanan @zzmao addressed comments

LGTM.

@pnarayanan Addressed comments. Can update the other patch once this is merged


about the result

| Test: [6][59/807] Err 0.16707 (0.17657) Err 0.05300 (0.04383) Acc 94.77 (94.820) mRec 67.03 (67.790) mIOU 47.87 (41.304)
| Test: [6][60/807] Err 0.19414 (0.17686) Err 0.04501 (0.04385) Acc 94.45 (94.814) mRec 62.64 (67.704) mIOU 38.60 (41.259)
is the training result right?

Seems right. You may also use evaluation code in tools to see if the F-measure matches with our rights.


serve all clerk hosted images with crossorigin="anonymous" attribute so that they can be viewed with COEP.

Package + Version

[ ] @clerk/clerk-js
[x] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore
[ ] other:

Version:
4.8.0

Browser/OS
Chrome latest
Description
There is a feature of the site that I'm working on that requires that I serve my content "Cross-Origin Isolated". This requires that all assets from 3rd party domains (clerk) specifically opt into allowing cross-origin requests by adding the crossorigin=" anonymous" attribute. This applies to images, videos, and scripts.
The specific issue I've run into is that the social button icons do not show up.

Thanks for reporting. We will fix it this week.

Any progress on this? All Clerk images are not now showing up in my app.
Note that the images themselves need also to be served with CORs headers. Images from the images.clerk.dev domain appear not to have appropriate cors headers.

Working


add ability to pass alt and style props down to img with typescript

summary
fixes 👇

tests
ran npm run build and npm start:storybook with success

@samuelmeuli could you please review this?


Questions and little issues for TQoiImage on Delphi XE2

Hi Angus,
Thank you very much for your work on TQoiImage and Image32.
I have tried your TQoiImage project and the example program on Delphi XE2 and could get it to work with little effort.
There were a few things I had to adjust.

Once in The Vcl.Imaging.QOI.pas and once in Unit1.pas you create a bitmap with a width and height argument.
 Result := TBitmap.Create(img.Width, img.Height);
This did not work on XE2 and I replaced it with:

  Result := TBitmap.Create;
  Result.Width := img.Width;
  Result.Height := img.Height;

It is an idea to have this updated in the source, for better backward compatibility?

XE2 did not accept
	class function CanLoadFromStream(Stream: TStream): Boolean; override;
I guess the function doesn't exist yet in XE2 in the base class so there's nothing to override. By quoting away the override I could compile and get a working result. Maybe it's an idea to make the override conditional.
Although my solution seems to work I wonder: Do you think of any possible problem for this?

I had to quote away
Vcl.Imaging.Utils in 'Vcl.Imaging.Utils.pas';
in the main program. It seemed not necessary, and I couldn't find it anywhere (both on XE2 and 10.4).  Could you tell me whether that is a good idea, or where I can get it?

Again, thanks very much for your work.
Best regards, JP.

HI JP. Thank you for the very helpful feedback. I'll update hopefully soonish, but I'm currently occupied with other things.

Hopefully fixed now.


修改了 network.host: 即可根据IP访问 无法启动服务

[2017-11-03T17:44:33,725][INFO ][o.e.n.Node               ] [z8FH8OO] starting ...
[2017-11-03T17:44:34,084][INFO ][o.e.t.TransportService   ] [z8FH8OO] publish_address {<IP_ADDRESS>:9300}, bound_addresses {[::]:9300}
[2017-11-03T17:44:34,099][INFO ][o.e.b.BootstrapCheck     ] [z8FH8OO] bound or publishing to a non-loopback or non-link-local address, enforcing bootstrap checks
ERROR: bootstrap checks failed
max file descriptors [4096] for elasticsearch process is too low, increase to at least [65536]
max virtual memory areas vm.max_map_count [65530] is too low, increase to at least [262144]
[2017-11-03T17:44:34,119][INFO ][o.e.n.Node               ] [z8FH8OO] stopping ...
[2017-11-03T17:44:34,152][INFO ][o.e.n.Node               ] [z8FH8OO] stopped
[2017-11-03T17:44:34,152][INFO ][o.e.n.Node               ] [z8FH8OO] closing ...
[2017-11-03T17:44:34,187][INFO ][o.e.n.Node               ] [z8FH8OO] closed
出现了这个致命的 错误

在生产环境，这里面还有一些配置需要修改
https://www.elastic.co/guide/en/elasticsearch/reference/current/bootstrap-checks.html


Reverse lookup of node and component names

The MicroFlo commandstream converts string idenifiers to numbers for nodes and components. When building up this stream, a nodemap is kept in memory that allows to look up the human-readable string identifier from the numeric nodeId.
We need to persist this to disk so that when connecting (without uploading new graph), we can use this map. Finding the correct map requires embedding an ID of the graph+componentset into the device. This should probably be a hash of a normalized representation of the complete graph (including subgraphs).
It should be possible (but not mandatory) for the device to contain the maps, and provide them to connecting code, so that one does not need a side-channel to get the map. On Embedded Linux this could maybe be the default.

This comes back to bit again and again, like when working with automated testing. Needs a proper fix sooner rather than later.
We now produce a componentmap.json when we generate the build, and can load this into the ComponentLibrary. What remains is a way to store and perform lookup of this information.


Cleans up PTransform validation across Beam

Moves validation from validate() to expand() when possible
Replaces checkNotNull() with checkArgument() when possible
Shortens overly verbose validation messages in a few IOs

As a piggyback, one of the sites to be cleaned up was AssignWindows which happened to be unused (it is also unused by Dataflow Worker), so I deleted it.
R: @tgroh

run dataflow validatesrunner

Changes Unknown when pulling e9bbabde484f23f2e494c4002fe3a8fffd77d5b9 on jkff:validate-cleanup into ** on apache:master**.

Coverage increased (+0.04%) to 70.005% when pulling 0a83f8381f913e8aadafbf184d7fce9404b573a8 on jkff:validate-cleanup into d261d6bde1a9fe128c7a5c56936c88caca7ca9eb on apache:master.

Coverage increased (+0.02%) to 69.984% when pulling 45b267b42a2cd2744ee1ef13eda303a1bf380595 on jkff:validate-cleanup into d64f2cce8735392e3f2a29c6ed070c323bb49af5 on apache:master.

Rebased, PTAL.

retest this please

Coverage decreased (-0.2%) to 69.489% when pulling 7b81dcb75ffc83571503f47e434e876adf9ff667 on jkff:validate-cleanup into 6dfd3a2b7d748bff049a34ea39cb5e2a0c45dba0 on apache:master.


Random KeyNotFoundException in ProxyTypeEmitter.GetProxyType during requests again TestServer

Not sure if this is the correct place to post this, but I'm experiencing the same issue described in https://github.com/aspnet/Mvc/issues/6292 & https://github.com/aspnet/EventNotification/issues/76, randomly getting the following error in requests against a TestServer  (Microsoft.AspNetCore.TestHost v2.0.1)
----- Inner Stack Trace -----
   at System.ThrowHelper.ThrowKeyNotFoundException()
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at Microsoft.Extensions.DiagnosticAdapter.Internal.ProxyTypeEmitter.GetProxyType(ProxyTypeCache cache, Type targetType, Type sourceType)
   at Microsoft.Extensions.DiagnosticAdapter.Internal.ProxyFactory.CreateProxy[TProxy](Object obj)
   at Proxy_Method_From_<>f__AnonymousType0`3_To_Void OnBeforeAction(Microsoft.AspNetCore.Http.HttpContext, IRouteData)(Object , Object , IProxyFactory )
   at Microsoft.Extensions.DiagnosticAdapter.DiagnosticSourceAdapter.Write(String diagnosticName, Object parameters)
   at Microsoft.Extensions.DiagnosticAdapter.DiagnosticSourceAdapter.System.IObserver<System.Collections.Generic.KeyValuePair<System.String,System.Object>>.OnNext(KeyValuePair`2 value)
   at System.Diagnostics.DiagnosticListener.Write(String name, Object value)
   at Microsoft.AspNetCore.Mvc.Internal.MvcCoreDiagnosticSourceExtensions.BeforeAction(DiagnosticSource diagnosticSource, ActionDescriptor actionDescriptor, HttpContext httpContext, RouteData routeData)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.<InvokeAsync>d__15.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Builder.RouterMiddleware.<Invoke>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Builder.RouterMiddleware.<Invoke>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Swashbuckle.AspNetCore.Swagger.SwaggerMiddleware.<Invoke>d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Cors.Infrastructure.CorsMiddleware.<Invoke>d__7.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Hosting.Internal.RequestServicesContainerMiddleware.<Invoke>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.TestHost.ClientHandler.<>c__DisplayClass3_0.<<SendAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.TestHost.ClientHandler.<SendAsync>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
   at System.Net.Http.HttpClient.<FinishSendAsyncBuffered>d__58.MoveNext()
Result Message:
System.AggregateException : One or more errors occurred. (The given key was not present in the dictionary.)
---- System.Collections.Generic.KeyNotFoundException : The given key was not present in the dictionary.

Project configuration:
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp2.0</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.TestHost" Version="2.0.1" />
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.5.0" />
    <PackageReference Include="xunit" Version="2.3.1" />
    <PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
  </ItemGroup>

I tried to repro with the sample but was unable to. I basically ran the Post request in the suspected test on a loop but no luck.
cc @rynowak to see if there is further action required.

I'm getting the error running 50-60 tests (all of them making use of HttpHelper class) and allowing built-in Visual Studio parallel tests mode (which might or might not be relevant).
Despite of that, it only shows up ocasionally, that's why I stated the reproduction might not be easy :(

We managed to find a pretty reliable repro for this problem when multiple test servers are created. We are going to try and reduce this repro further to just involve the event notification code.
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.TestHost;
using System;
using System.Collections.Generic;
using System.Net;
using System.Text;
using System.Threading.Tasks;
using Xunit;

namespace API.TEST
{
    class Program
    {
        public static string Uri { get; private set; } = "api/dtos/";

        public static void Main(string[] args)
        {
            Parallel.For<TestServer>(
    0,
    100,
    () =>
    {
        var hostBuilder = new WebHostBuilder().UseStartup<Startup>();
        return new TestServer(hostBuilder);
    },
    (i, state, server) =>
    {
        var client = server.CreateClient();
        DTO DTOToTest = new DTO(1, "str");

        DTO savedDTO = HttpHelper.Post(client, Uri, DTOToTest, out HttpStatusCode statusCode);
        Assert.Equal(HttpStatusCode.OK, statusCode);
        Validate(DTOToTest, savedDTO);

        DTO saveddtoFromServer = HttpHelper.Get<DTO>(client, Uri + savedDTO.Id, out statusCode);
        Assert.Equal(HttpStatusCode.OK, statusCode);
        return server;
    },
    (_) => { });
        }

        private static void Validate(DTO entityToCreate, DTO createdEntity)
        {
            Assert.NotNull(createdEntity);
            Assert.True(createdEntity.Id > 0);

            Assert.Equal(entityToCreate.Number, createdEntity.Number);
            Assert.Equal(entityToCreate.String, createdEntity.String);
        }
    }

}

We've just detected some issues related to Delete calls too.
In this case, instead of exceptions, InternalServerError StatusCode have been detected as a result of some of our delete tests.

@eduherminio We tried to address a race condition we were able to repro for 2.1.0-preview2. You can try our nightly build on myget https://dotnet.myget.org/gallery/aspnetcore-dev to check if it works. You can always feel free to reopen the issue as well!

Hey,
I'm on .NET Core 2.1.1, should this bug have been fixed? Just encountered it again.
Thank you

I didn't have the chance to test new packages in the real project where this issue was detected, since it's still stuck on 2.0.x versions, but I thought it was solved too :/

Same stack trace? If so please open a new issue in Home.

Figured it out, the latest Microsoft.ApplicationInsights.AspNetCore NuGet package 2.3.0 still references an older Microsoft.Extensions.DiagnosticAdapter with this bug (1.x). I've removed AppInsights.

https://github.com/Microsoft/ApplicationInsights-aspnetcore


change output warping field and explicit in help

currently, the function outputs a warping field with name "warp_template2..._gmseg", this should be changed for "warp_XXX..._gmseg", XXX being copied from the input warping file name.
also, please indicate the expected outputs of the function in the help.

Fixed with PR #1121


How can I initialize filter value of dashboard?

let's say I have a filter on dashboard. I'd like to initialize the global filter to downsize the data size on dashboard level. is that possible?

what do you mean by downsize ?
by the way gitter channel is a better place for questions:
https://gitter.im/airbnb/caravel

Maybe "downsize" here means "reduce", we wonder if it possible to set default(initial) filter value in Filter box widget


Track deleted files

Great theme - very clean, very nice.
I've noticed that the Git status doesn't track deleted (D) files, only modified and untracked/added. Was this intentional? If not, can it be added?
I'm happy to open a PR if that's easier.

Thanks, Brody
Not intentional, just missed - happy for you to open a PR.


Change currentValue to targetValue in the fan template docs

Change currentVaue to targetValue in the fan template like changed in:
https://github.com/zwave-js/zwavejs2mqtt/commit/0d0fbd678070dc2e979a809363815628b5a8a5d8

Pull Request Test Coverage Report for Build 501469781

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 22.912%

Totals

Change from base Build 501298160:
0.0%

Covered Lines:
1950

Relevant Lines:
8705

💛  - Coveralls

Pull Request Test Coverage Report for Build 501469781

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 22.912%

Totals

Change from base Build 501298160:
0.0%

Covered Lines:
1950

Relevant Lines:
8705

💛  - Coveralls


Stringbuilder::substituteCommon can fail when buffer grows

If ensureRoom needs to grow the stringbuilder buffer, the 'occur' param in substituteCommon may be invalidated. This preserves the param across reallocation.
Note: This was failing for me when using a rather long path for the local filesystem.

Good catch! Thanks a lot :)

I have also added 2 assert checks, one at the start of StringBuilder::substituteCommon() and one in StringBuilder::Append() to make sure that your fix, and the case if ensureRoom() grows in Append work as expected.


🪲 HAVING filters on aggregates pushed past aggregates

Thank you for taking the time to report a problem with Opteryx.
To help us to respond to your request we ask that you try to provide the below detail about the bug.
Sample Code/Statement If you can, please submit the SQL statement or Python code snippet, or a representative example using the sample datasets.
SELECT p.name, COUNT(s.id) FROM $planets p JOIN $satellites s ON p.id = s.planetId GROUP BY p.name HAVING COUNT(s.id) > 3

Additional context Add any other context about the problem here, for example what you have done to try to diagnose or workaround the problem.
Creates this plan - note the FILTER on COUNT(id) is pushed past the AGGREGATE step which evaluates COUNT(id)
AFTER COST OPTIMIZATION
└─ EXIT
   └─ PROJECT (COUNT(id), name)
      └─ AGGREGATE (COUNT(id)) GROUP BY (name)
         └─ INNER JOIN (p.id = s.planetId)
            ├─ SCAN ($planets AS p) [id, name]
            └─ FILTER (COUNT(id) > 3)
               └─ SCAN ($satellites AS s) [id, planetId]

This is a side effect of updating the predicate pushdown code to be able to push filters which involve functions if they only reference identifiers from one relation, previously these weren't pushed.


Local names for Chinese and Traditional Chinese

Just some translations.

In fact, modern Chinese has at least 2 main writing system:

简体中文, Simplified Chinese, zh-Hans or zh-CN, used in Singapore, Malaysia and Mainland China except HK/Macau
繁體中文 or 正體中文, Traditional Chinese, zh-Hant or zh-TW, used in Taiwan/HK/Macau

It's a bit complicated, I'm considering it's good or bad for using region here.
I read Typst's code, We haven't encountered more complex problems yet. Now that's good enough.
Maybe we should check some LaTeX packages for more good ideas, like ctex.

Thanks for the translations and further investigation!


Support zwave glob & domain device settings.

Description:
Support zwave glob & domain device settings.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):
zwave:
  device_settings:
    light.bed:
      ignored: true
  device_settings_domain:
    light:
      ignored: true
  device_settings_glob:
    light.b*:
      ignored: true

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io TODO

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Finally restored, with different name but still :1st_place_medal:
Looking forward to this this merged so I can update my config.

Off-topic question @andrey-git: how did u managed to name your devices nice, is it from the .homeassistant/zwcfg_*.xml, because my devices have their old ugly names given by their manufacturers ?

🐬

@balloob, @andrey-git I know it would not be valid yaml to have smth like:
device_settings_glob:
    light.b*, light.c*:
      ignored: true

Still, u think it's a bad idea to add it for both customize and also zwave configurations ?


:robot: Triggering CI on branch 'release-next' after syncing to upstream/main

/test 416-test-e2e-aws-416

OCF Webhook is merging this PR


adata.copy() doesn't deepcopy layers

After copying an anndata via adata.copy(), layers of the resulting object are still pointing to the layers of the original object:
import scanpy as sc

adata = sc.datasets.paul15()
adata.layers['L'] = adata.X.copy()
adata.layers['L'].sum()

Output: 6083492.0
bdata = adata.copy()
adata.layers['L'] *= 2.0
bdata.layers['L'].sum()

Output: 12166984.0
I realized that when I saw scvelo normalizing the layers of the original object even though I passed a copy to scv.pp.filter_and_normalize...

What version are you on? I'm not able to reproduce on master.

Hi Gokcen, I just run this minimal example and couldn't reproduce that either.

Can anybody try with the stable anndata package?

With your version ('0.6.22.post1') I get the same error, with the latest ('0.6.22.post1+29.g16615d7') it's fixed.

ok, thanks. Adding a test would be useful then.


lanetix/issues#2172 Actually log errors

This corrects three issues with the previous error handler implementation.

Actual Error objects weren't logged because of the way they get converted to json
JSON.stringify will fail for some valid objects (e.g. circular references). When logging, you should prefer util.inspect.
There weren't any tests :stuck_out_tongue:

CR @lanetix/engineers

:mag:

:+1:


HTML5 bitmapdata.copypixels applies incorrect alpha (aquired from previous .draw calls)

when compiling for the HTML5 target, bitmapdata.draw and bitmapdata.copypixels are as yet incomplete, and only partial functionality is available.
A bigger issue exists, in that, there is very strange behaviour is occuring currently with bitmapdata.copypixels effectivly collecting the alpha value from pervious calls to bitmapdata.draw.
The code below demonstrates this issue precisely - (greensquare is given alpha 0.5, this alpha value is also applied to the blue square)
var canvasbmp:Bitmap;
var canvasbitmapdata:BitmapData;
var redsquare:Bitmap;
var greensquare:Bitmap;
var bluesquare:Bitmap;

function init() {
	canvasbitmapdata = new BitmapData(300, 150, true, 0xff000000);
	canvasbmp = new Bitmap(canvasbitmapdata);
	addChild(canvasbmp);

	redsquare = new Bitmap (new BitmapData(20, 20, true, 0xffff0000));
	greensquare = new Bitmap(new BitmapData(20, 20, true, 0xff00ff00));
	bluesquare = new Bitmap (new BitmapData(20, 20, true, 0xff0000ff));

	greensquare.alpha = 0.5;

	canvasbitmapdata.copyPixels(redsquare.bitmapData, new Rectangle(0, 0, 20, 20), new Point(50, 50) , null, null, true);

	var matrix:Matrix = new Matrix();
	matrix.translate(100, 50);
	canvasbitmapdata.draw(greensquare, matrix, null, null, null, true);

	canvasbitmapdata.copyPixels(bluesquare.bitmapData, new Rectangle(0, 0, 20, 20), new Point(150, 50) , null, null, true);
}

copyPixels only calls lime so most likely a bug from there.
Also strangely on flash the green square is drawn at full alpha,
not sure what's the expected behavior here.


enhancement: separate config files from cache directories

As a general best practice, cache files and directories and config / user data and directories should not be mixed together.
In the specific case of dashd (and dash-qt), it's common to need to delete the blockchain data when it becomes corrupted from:

the program being quit unexpectedly
crashing due to running out of RAM
the server not being shut down correctly
not finishing during a sync
changing certain settings
etc

The -testnet flag already does the right thing by creating a separate testnet3 which can be removed at any time without an issue (I think).
It would make a lot of sense to create a mainnet folder for the mainnet cache rather that putting it alongside dash.conf and settings.json which contain valuable secrets, user config, etc.
I'm not sure which other files also contain valuable data (Wallet Phrase, legacy private keys), but it would be a lot easier to manage the mistakes if there were a clear delineation between what needs to be backup up and what doesn't before blowing away the cache directories - because if they aren't blown away then it seems they just duplicate information rather than resuming from the last good state or pruning the unrecoverable data entirely.
My greatest preference would be to follow the existing standards used by most other CLI tools and switch configuration data to ~/.config/dashcore/ by default, and ~/.local/opt for program files, and other folders in ~/.local for larger important data specific to the user according to standards and best-practice conventions.

Also, -datadir is a misnomer, at least from a user perspective. Perhaps that should be -cachedir.
Or there should be some clear distinction between "data that is unique to no one" and "data that is unique to this instance" and "data unique to this user".
In the case of running a Full Node, I assume the purpose is just for creating APIs to interact with transactions and balances, etc, so it's not a big deal - but dashcore as a package doesn't really distinguish between use cases of "User is doing stuff with money" vs "Service provider is providing services" vs "MNO is voting" - everything is everything is everything, which makes it even more important to provide clear distinction at the folder level.

The current behavior is also dangerous because there's no way to future-proof against it.
I can personally change -datadir and -conf, but then later -walletdir comes along and then -settings comes along and so on and so forth.
It needs to be the responsibility of the developers to choose safe defaults, not the responsibility of the user to be constantly vigilant in setting command line options, checking the notes of each release, etc, etc, etc.
Users are dumb. I'm dumb. Computers should protect us from our dumbness, not lead us into traps. Y'know?

The -testnet flag already does the right thing by creating a separate testnet3 which can be removed at any time without an issue (I think).

Fwiw, it is not safe to remove the testnet3 (or regtest or devnet-*) directory at any time. This is because wallet files for each network type are stored within that network's directory.

wallet files for each network type are stored within that network's directory

I found a bug there too: https://github.com/dashpay/dash/issues/5423


Added Docker to the project

Adds docker-compose and build files for the API and the React front-end.

workflows failed, because there's no more requirements.txt in root directory, which they use. will fix that in a moment and then merge.

still won't pass, because changes doesn't sync across branches. can't see any more problems, merging.


Newtonsoft Error

I am getting this error when I'm debugging mode and I take a picture on the Hololens:
Newtonsoft.Json.JsonSerializationException HResult=0x80131500 Message=Cannot deserialize the current JSON object (e.g. {"name":"value"}) into type 'Candidate_RootObject[]' because the type requires a JSON array (e.g. [1,2,3]) to deserialize correctly. To fix this error either change the JSON to a JSON array (e.g. [1,2,3]) or change the deserialized type so that it is a normal .NET type (e.g. not a primitive type like integer, not a collection type like an array or List) that can be deserialized from a JSON object. JsonObjectAttribute can also be added to the type to force it to deserialize from a JSON object. Path 'error', line 1, position 9. Source=Newtonsoft.Json StackTrace: at ...
Does anybody know what to do?
Thank you!

Hi @xbaranova
This repo is for the Mixed Reality documentation.  Please ask this kind of help on Stack Overflow using the tag HoloLens, as that is where we are providing this sort of support.
Thanks,
Jesse


Method Filament\Forms\Components\Group::table does not exist error when using with SelectFilter in filters method of admin resource

Package
filament/filament
Package Version
v2.17.49
Laravel Version
v10.14.0
Livewire Version
v2.12.3
PHP Version
v8.1.19
Problem description
use Filament\Resources\Form;

        ->filters([
            Forms\Components\Group::make()
//                ->label('Status')
//                ->columns(1)
                ->schema([
                    SelectFilter::make('status')
                        ->multiple()
                        ->options([
                            Friend::NEW => 'New',
                            Friend::ACCEPTED => 'Accepted',
                        ]),
                ]),
        ]);

This is my filament admin panel Resources code ->filters() and it is giving me the Method Filament\Forms\Components\Group::table does not exist. error.

Expected behavior
Should be working but somehow not.
Steps to reproduce
add the filter I mention and try it yourself.
Reproduction repository
https://github.com/faizananwerali/filament_demo
Relevant log output
No response

This is not supported, only filters can be passed into the filters() array, not form components raw

how did the 'webbingbrasil/filament-advancedfilter' plugin have done it? I'm just asking, it looks bad in my app.

I think you're looking for custom filter forms: https://filamentphp.com/docs/2.x/tables/filters#custom-filter-forms.


BatchNormalization make bad results

Hi everyone,
I tried to add somes BatchNormalization layers into my network today.
Without BatchNormalization, I get a decent 75% of accuracy on the test set.
But when I add BatchNormalization layers, my train accuracy increase, but my test accuracy remains to 50. (Or increase a little bit, to 55)
What could be the cause ? I use BatchNorm with default values (Since I use tf ordering, that's the good thing to do I guess)
For conv1d and dense layers.
I tried to add them after Activation Layer, and before it, but the results stay the same.. Do you have an idea of why it's stuck, or had a similar problem ?

Do you have any dropout layers in your network before BatchNorm? That can cause train accuracy to appear high but test accuracy to stay low.
This is really a stackoverflow question, not a github issue.


Typescript errors from using "navigate"

Describe the bug
Navigate from useNavigate of Tanstack Router is throwing a typescript error in later versions when about a month or so ago this setup did not produce a typescript error/warning
Your Example Website or App
https://stackblitz.com/github/tanstack/router/tree/beta/examples/react/quickstart?file=src%2Fmain.tsx
Steps to Reproduce the Bug or Issue
const navigate = useNavigate();
navigate({
    to: '/register',
    replace: false,
});

gives the following typescript error:
Argument type {replace: boolean, to: string} is not assignable to parameter type NavigateOptions<RegisteredRouter["routeTree"], string, string, string, "">
Expected behavior
No error should be given, only the later versions of Tanstack Router are giving this error for a fairly simple setup
Screenshots or Videos
No response
Platform

OS: Windows
Browser: Chrome
Version: "@tanstack/react-router": "^1.23.1"

Additional context
No response

please provide a minimal complete example by forking and modifying one of the examples on stackblitz

hi @schiller-manuel I dug little and found out some issues in the command stated above and had made some amends and that works well in stackblitz can u please assign me the issue

@tushar-coin, as requested I've assigned the issue to you.
Could you give us a bit of context about what you found out?

hey @SeanCassiere on some digging i found out there were certain syntax changes in the useNavigate hook I am not 100% sure about the history of the syntax of this hook .
But i found that if we write the query differently using this syntax it does not give any error as mentioned by @roastdev
const navigate = useNavigate(); navigate('/register', {   replace: false, });

hey @SeanCassiere on some digging i found out there were certain syntax changes in the useNavigate hook I am not 100% sure about the history of the syntax of this hook . But i found that if we write the query differently using this syntax it does not give any error as mentioned by @roastdev
const navigate = useNavigate(); navigate('/register', { replace: false });
I verified the same on stackblitz

Are you sure you've got @tanstack/react-router on the latest version (not beta or something, right now latest is 1.26.1)?
Because looking at the implementation of the result of the useNavigate function, it cannot accept a second input parameter at all.


net/http: apparent TestServerAllowsBlockingRemoteAddr flakes due to hard-coded timeouts

#!watchflakes
post <- pkg == "net/http" && (test == "TestServerAllowsBlockingRemoteAddr" || `^\s+TestServerAllowsBlockingRemoteAddr \(\d+m`) && (`panic: test timed out` || `context deadline exceeded`)

2019-12-16T20:38:31-f7f9866/plan9-386-0intro
2019-06-12T14:58:18-65f53da/plan9-amd64-9front
--- FAIL: TestServerAllowsBlockingRemoteAddr (1.08s)
    serve_test.go:1300: Request 1: Get "http://<IP_ADDRESS>:55517": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
    serve_test.go:1349: response 1 addr = ""; want "RA:<IP_ADDRESS>:21"
http.test 1018696: warning: process exceeds 100 file descriptors
FAIL
FAIL	net/http	114.189s

As far as I can tell, the root cause is the hard-coded time.Second here:
https://github.com/golang/go/blob/931fe39400006e6c272d13f2a4d46de2a6736761/src/net/http/serve_test.go#L1326-L1330
It's not obvious to me why a timeout is needed there at all. If the test deadlocks, we presumably want a goroutine dump anyway.
CC @bradfitz @0intro @fhs

That's the regression test for #12943.

Is this one still one still open

The failure log linked in https://github.com/golang/go/issues/57995#issuecomment-1405051874 matches this issue; I'm not sure why watchflakes isn't posting it here.

Interesting! Those dragonfly failures look like actual deadlocks, not just spurious timeouts.

Nope, it is still the same spurious timeout:
https://cs.opensource.google/go/go/+/master:src/net/http/serve_test.go;l=1362;drc=133e0bca0be23980604ee98589ddcacdb1262afd
It's just manifesting as a deadlock due to some synchronous cleanup code.

Oops, missed another arbitrary timeout.

Hopefully completely fixed this time, by CL 476035.


remove returns undefined

ensured that the correct key was used. Got an undefined return from the local storage remove function.

I'm experiencing the same behavior.  The documentation states that a boolean should be returned, but I receive undefined as well.

remove function doesn't return anything. Only clearAll returns something.

+1 on this.
Could the documentation be updated to reflect this behavior?

I believe that the documentation should be updated, but could be useful if you return a boolean to know if the data has been removed.


Loading Issue with 3G data on mobile

When we play on mobile with 3G data, then it continuously loading even on small files. So please fix the issue.

What device, android version, and browser/version are you using?


Document that the Equals predicates equate only two nouns

Description of the PR
The current documentation seems to indicate that a single HashEqual, PkgEqual, or VulnEqual predicate may equate more than two nouns.
PR Checklist

[x] All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
[ ] All new changes are covered by tests
[x] If GraphQL schema is changed, make generate has been run
[x] If OpenAPI spec is changed, make generate has been run
[x] If collectsub protobuf has been changed, make proto has been run
[ ] All CI checks are passing (tests and formatting)
[x] All dependent PRs have already been merged

We could also split it to have one field for each noun instead of a list, but that's a more involved change

We could also split it to have one field for each noun instead of a list, but that's a more involved change

@mihaimaruseac that is what we technically do in the backend implementation: https://github.com/guacsec/guac/blob/main/pkg/assembler/backends/ent/schema/hashequal.go#L38-L39

Yes, but then we can enforce this from the GQL schema

Yes, but then we can enforce this from the GQL schema

yup I agree.


Merge with havriuk branch

Changelog
Implemented tasks assigned at Notion.
Classes

PlaceFigures.java
ResourceSource.java
TribeFedStatus.java

Interfaces

InterfaceFeedTribe.java
InterfaceFigureLocation.java
InterfaceFigureLocationInternal.java
InterfaceNewTurn.java

Data structures

Player.java
PlayerBoard.java
ResourceSource.java
TribeFedStatus.java

Tests

PlaceFiguresStateTest.java
ResourceSourceTest.java
TribeFedStatusTest.java

To pass the tests (mvn test), PlayerFigures and other classes need to be implemented.

I will make some changes to account for new files in main branch, will merge later.


apache2 server under wsl can't be accessed from the web

Your Windows build number:  Version 10.0.17074.1002

What you're doing and what's happening:  Trying to allow my wsl apache2 server to be accessed from the web

What's wrong / what should be happening instead: The webbsite is configured via apache vhost and I can access it locally by using the host file to resolve the registered domain name to my local servers IP address, but when I try to check the server is accessible using http://downforeveryoneorjustme.com it reports that it is not up for anyone. The web server is set up in the vhosts file to use port 80  as follows:

Listen 80
<VirtualHost *:80>
ServerName nhw.foobar.co.uk
ServerAdmin webmaster@localhost
# NB: The DocumentRoot path name needs quoutes around it, whilst the Directory
# path doesn't
DocumentRoot "/mnt/i/var/www/vhosts/dev.foobar.co.uk/httpdocs"
<Directory /mnt/i/var/www/vhosts/dev.foobar.co.uk/>
Options Indexes FollowSymLinks MultiViews
AllowOverride All
Require all granted

ErrorLog ${APACHE_LOG_DIR}/error.log
CustomLog ${APACHE_LOG_DIR}/access.log combined

The site has been enableda (2ensite) and the apache2 service has been restarted.
I have a Windows Defender firewall rule set up for incoming on port 80
I have set up a port forwarding rule on my netgear router to forward incoming traffic on port 80 to my local machine on port <IP_ADDRESS> that is running on port 80.
If I create a record in the windows host file for the registered domain name and ip <IP_ADDRESS> the server is accessible from my PC, so I know the apache config is good and the site works.

If I turn off the Windows Defender Firewall for Guest or public networks, the website can be reached from the web. However, I already have the incoming rile defined to allow the port be be opened for incoming TCP/IP traffic.
I'll try a a reboot of my PC to make sure the incoming rule is in force.

A reboot didn't help... so how do I open up the Firewall for WSL's Apache2 server?
Here's the incoming rule I defined:

Can anyone advise?

You need to open the outgoing port too.

Sadly @xama5 it made no difference:

Your rule is currently restricting the remote port to 80 as well. Try changing this to 'Any'.

Thanks for the suggestion Brain, but this also made no difference:

@nickweavers Sorry, I was referring to your original inbound rule.

I do actually only want to open up port 80 in both directions since It's just for http traffic , but I tried your suggestion of relaxing it to any ports both incoming and outgoing Brian. It made no difference. Thanks for the suggestion though.

Correction just so it is on the books; you don't need to open the "outgoing port too" as suggested. Nothing is outgoing port 80 here. Which is probably why Brian took as given he meant the incoming rule. The problem is you restricted the remote port (the one Chrome or Firefox or Edge got) on the incoming connections to port 80.

Thanks @therealkenc, I thought that too, but am willing to try anything in a quest for an answer. So are you saying by restricting the remote incoming port to 80, if I was visiting a website with an SSL certificate that expects to use 443 I would have blocked it? I had the idea that a state-full firewall would only block unsolicited packets coming in, so anything coming back to my browser as a response would be allowed through despite what a rule says, since I effectively sanctioned it by making a request - something reflected in the packets state? I'm not much of an expert though.

We're treading way out of WSL territory here, but if you are using https then you need to open incoming local port 443. And do some other stuff. The remote port needs to be Any regardless, except under special circumstances which wouldn't apply to you. There isn't any "despite what the rule says" -- there are incoming ports, and there are outgoing ports. You have an incoming port. I don't know what else to tell you other than I assure you it works. If it didn't then people's heads would explode.

I believe that it works in 99.9999% of cases. I'm just trying to understand why it doesn't in the case I have here with an apache web server running under wsl and if it's my fault (misconfigurartion) which is most likely.
So here's where I'm at:

With the Windows Defender Firewall for Guest or public networks turned OFF, the website CAN be reached from the web.

With incoming rules defined for HTTP and HTTPS and  Windows Defender Firewall for Guest or public networks turned ON, the  site and CANNOT be reached from the web.

My bad, it is now working... just forgot to restart apache after reboot. Doh!
Thanks to @therealkenc and everyone else for helping out.


[impl] config prune and serialization

Allows pruning of dupe config keys and fix serialization of nested config object.
This is an improvement for #9.

Pull Request Test Coverage Report for Build 94

24 of 29 (82.76%) changed or added relevant lines in 6 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.6%) to 79.627%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/config/index.ts
9
10
90.0%

src/apis/init.ts
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/monitor.ts
2
61.41%

Totals

Change from base Build 83:
0.6%

Covered Lines:
499

Relevant Lines:
606

💛  - Coveralls

Just a comment for now: we probably want to eventually make sure any further change to the config schema is backwards compatible. Having some kind of automated test for backwards compatibility on the schema would be nice.

Yeah good point.


Uninstall Documentation

I’m looking for some help on how to uninstall the web portal since it interferes with PiHole. I’m not finding any documentation on the uninstall process or where the web portal and its related services are installed to be able to do a manual removal. I’d really appreciate it if someone could help. Thanks in advance! (bonus points if you can point me how to get both PiHole and the ADS-B web portals to work simultaneously)

I’m looking for some help on how to uninstall the web portal since it interferes with PiHole.  I’m not finding any documentation on the uninstall process or where the web portal and its related services are installed to be able to do a manual removal. I’d really appreciate it if someone could help. Thanks in advance!  (bonus points if you can point me how to get both PiHole and the ADS-B web portals to work simultaneously)

It looks as though PiHole installs the same webserver and uses the same default Lighttpd root directory in which the files making up both web interfaces are served. The following should(?) get PiHole's web interface up and running if I am correct and the GithHub repository linked to does indeed PiHoles's web interface.
Keep in mind I do not run PiHole and have NO experience with it.
Be sure to back things up!
Pi-hole Dashboard for stats and more
https://github.com/pi-hole/AdminLTE

Remove the files making up the portal from /var/www/html/.
Place the contents of the PiHole administration interface in the directory /var/www/html/.
Visit the PiHole admin interface???
(You may need to edit a config file not sure...)

I am working on v3 and will look into changing the location of the portal files so they do not conflict with other systems using the same train of thought as I used. Until then you should be able to get both working side by side by copying the contents of /var/www/html/ to a separate directory say /var/www/html/adsb/ and running it from there if the portal works in its present state. You may need to adjust paths in the file classes/settings.config.php in order for things to work.

@jprochazka Thanks for the thorough reply!
Some followup details for others that might have this issue:
Note: I had PiHole installed before the adsb-receiver portal install.
So, deleting the portal specific files from /var/www/html/ mostly worked.  I was careful to not delete the existing PiHole admin page files.
I think my major issue was caused during the initial portal install since it overwrites PiHole's /admin/index.php.  I only needed to replace the portal's version of this file with PiHole's (available here) and PiHole admin web interface is working again.
I'm not seeing mysql-server installed via this command:  apt list --installed, is it perhaps sqlite3 ?
Looking forward to v3 and it playing nice with PiHole...  =). Thanks to @jprochazka  for all your work!

Glad to hear you are back up and running.

I'm not seeing mysql-server installed via this command: apt list --installed, is it perhaps sqlite3 ?

If you did not enable the advanced features then you are good to go. Apparently you did not install a MySQL/MariaDB server so there should be no overhead issues. If sqlite3 is installed you should be fine with leaving it in place being there is no overhead involved with it being there.

Looking forward to v3 and it playing nice with PiHole...

Depending on how comfortable you are with changing things you could get it going using v2.x with a little hacking. Mainly by creating a Lighttpd configuration file such as the one dump1090-mutability uses, which is linked to below, modified to point to the location of the portal files. But you will need to be sure to set proper permissions and not run the portal install scripts.
https://github.com/mutability/dump1090/blob/master/debian/lighttpd/89-dump1090.conf


Backport v sphere collectors to06 release branch

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


UdonSharpBUildCompile' VRCSDKBuildRequestedCallback"

I am not sure what too do and I just got done working on a bunch of stuff and I am not sure why its not working

Hey, this looks like a VRC SDK issue.


docs: add docs on <IP_ADDRESS> gotcha

Description
A few users (including myself) have run into this issue so it's important to document.

Thank you 🙏


Rework .NET samples and snippets instructions

Fixes dotnet/docs#17297
We've updated our samples and snippets structure. This PR describes the new structure, and migration guidelines for existing snippets. In addition, rework the samples section to include the metadata necessary for the samples browser experience.
/cc @Thraka

@tdykstra Do you know who needs to approve this before merging? Or was there a issue with recording your review?

#sign-off
/cc @Jim-Parker


Confluent Kafka install with Archive installer

Description
Can now install confluent-kafka (not confluent-server) with the archive installer
Fixes # (issue)
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Created two new scenarios to test archive installers
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules
[ ] Any variable changes have been validated to be backwards compatible

pushed branch to public repo in case customer needs it sooner than merge goes thru


New version: MathiasSvensson.MultiCommander version <IP_ADDRESS>83

Pull request has been created with komac v2.0.3 :rocket:

https://github.com/microsoft/winget-pkgs/pull/137455#pullrequestreview-1856675254

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping @Exorcism0666, I'll get a notification.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！


Update Share transaction details screen

New versions are here
mainnet https://zpl.io/awPeoDM
testnet https://zpl.io/ad10ApK
masternet https://zpl.io/beW0gAW

сhecked on testnet
Version: 3.1.30


Cannot add yabai to accessibility

I followed the wiki installation guide and when I'm adding yabai to system accessibility, the yabai binary is not highlighted (can't not be chosen) like figure below. (I also found the linked yabai binary, which is also gray and cannot be added)

My system is 10.13.6 (17G7024)
Is there anything I can do to add yabai to the accessibility?

If you cannot add it in there for 10.13, try running yabai once and then immediately quit it (brew services start yabai and brew services stop yabai). You will get spammed with accessibility prompts, which will add yabai as unchecked to the list of apps asking for these permissions. I really don't see why this would not work, though.

If you cannot add it in there for 10.13, try running yabai once and then immediately quit it (brew services start yabai and brew services stop yabai). You will get spammed with accessibility prompts, which will add yabai as unchecked to the list of apps asking for these permissions. I really don't see why this would not work, though.

It worked, thank you very much. I should have known that running yabai for once would invoke the prompts. It's been a long time since I use mac last time. Back for yabai! 👍


JBPM-4935 - execution server missing REST API endpoint to start process form signal

backport to 6.4.x

merged into 6.4.x


Minified global var names in conflict with other libraries

Describe the bug
this is output of our project, and lodash is external as _.
To be honest, not every build will have the global variable _， This problem is a recent one, maybe it will be gone sometime in the future

https://github.com/vitejs/vite/issues/7188 has a similar problem, but this is for library
Reproduction
https://stackblitz.com/edit/vitejs-vite-mfiuov?file=counter.js,vite.config.js,dist%2Fassets%2Findex-4b6c22ce.js&terminal=dev
Steps to reproduce
run npm run build
you will see the output of js has many global vars, but this time there is no global variable _
System Info
  Binaries:
    Node: 16.20.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 8.19.4 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.2.0 - ~\AppData\Local\Yarn\bin\pnpm.CMD
  Browsers:
    Chrome: 116.0.5845.141
    Internet Explorer: 11.0.14393.2007
  npmPackages:
    @vitejs/plugin-react: ^4.0.3 => 4.0.3
    vite: ^4.4.6 => 4.4.7

Used Package Manager
yarn
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Declaring a variable in the top level scope won't make the variable global in ESM. Since the build output is ESM, the declared variable is not a global variable.


Maintenance on SNP effects and allele frequencies functions

This PR has several pieces of maintenance, which came up as worth doing while working on the SNP effects example notebook. Includes:

clean up intron effects and make get_effects() a method (resolves #36)
rename seqid to contig (resolves #37)
accelerate snp_effects and snp_allele_frequencies with site mask
fix unnecessary geneset renaming (resolves #41)
add description to default cols (resolves #42)
rename maximum to max_af (resolves #43)

Hi @cclarkson, sorry to bundle a few things in together here, but hopefully not too difficult to parse. Let's talk through at 2.

Going ahead with merge but happy to address any comments in a follow-up.


Filename is always the same

https://github.com/futurice/docker-volume-backup/blob/96b702cbf1af642d0b96b6bfbea104141863fe04/src/entrypoint.sh#L11
Because the entrypoint.sh is only executed at startup, the filename used is always the same.
Only the Pattern for the date format should be saved, and then evaluated when the new backup file is created.
I will submit a PR soon.

hey,
this repo seems pretty inactive thats why i maintained my fork of it and i also fixed this bug over there with some other useful stuff
https://github.com/breuerfelix/docker-volume-backup

Sorry for dropping the ball on this; for whatever reason I hadn't subscribed to notifications on this repo, even though I'm the maintainer. :facepalm:
@breuerfelix feel free to send PR's for your improvements, this time I'll notice them!

Merged in #10, thanks for the fix @BacLuc!

@jareware i will try to reopen my PR once i got some time ! :) since i am currently not using it it is hard to find some time :D


Update Github link to SUSE

Update the GitHub links to the SUSE project instead of linking to cfconrad's home project.

thanks for PR ! Sorry I didn't notice it before

thanks for PR ! Sorry I didn't notice it before

No worries, I also forgot about it :sweat_smile:


Alternative closure syntax

The current closure syntax {|arg| command} is modeled after ruby blocks. There are two things I don't like about it:

When the argument list is absent, a closure literal is distinguished from a list by a whitespace after the opening brace; e.g. {echo} is a list, but { echo} is a closure. This is too subtle. We can make the argument list (along with the bars) compulsory, but {|| echo} isn't too nice either.

It doesn't read nice. This is reflected by a need for syntax sugar in fn; fn f a b c { command } is equivalent to fn f {|a b c| command} since I find the latter unnatural. It would be better if we can separate the argument list from the body more clearly.

http://rigaux.org/language-study/syntax-across-languages.html#FnctnnnmsFnct collects the syntax for anonymous functions in other languages.

The lambda now uses the syntax [arg1 arg2]{chunk}.