Fetch API cannot load file:///xxxxx/assets/FontManifest.json. URL scheme “file” is not supported  (on android device)

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

run flutter build web.
copy build/web dir to android phone.
use a webview load web/index.html

Expected results
show the main.dart screen.
Actual results
inspect the device,  found error "Fetch API cannot load file:///xxx/assets/FontManifest.json. URL scheme “file” is not supported"
& blank screen.
build web under flutter 3.7.0 everything is ok.
flutter 3.10.x error & not work.
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[Paste your output here]

we are not using webview_flutter. we use native webview to load the html source with 'file://' scheme.  The web source is stored in the sandbox(ios)&SD card(android).

Can you please share a minimal sample code for android native part? (The flutter web build output can be skipped as I can do it)
It would be appreciated if you could provide a GitHub repository in this case. Thank you!

Can you please share a minimal sample code for android native part? (The flutter web build output can be skipped as I can do it)
It would be appreciated if you could provide a GitHub repository in this case. Thank you!

this.webview?.loadUrl(Uri.fromFile(File("file:///sdcard/index.html"))

Unfortunately, I'm hitting ERR_ACCESS_DENIED error when doing this. Below is my settings to load web on Android:
        val flutterWebFile = File("${extStoragePath}/web/index.html")
        Log.d("TAG", "flutterWebFile path: ${flutterWebFile.path}") // /storage/emulated/0/web/index.html
        Log.d("TAG", "pathFlutterWeb is existed: ${flutterWebFile.exists()}")   // true
        val pathFlutterWeb = "file:///$flutterWebFile"

        binding.webview.settings.allowFileAccess = true
        binding.webview.settings.allowContentAccess = true
        binding.webview.loadUrl(pathFlutterWeb)

Is there missing something to replicate this issue? (checking this on Pixel 3a, Android 12)

Unfortunately, I'm hitting ERR_ACCESS_DENIED error when doing this. Below is my settings to load web on Android:
        val flutterWebFile = File("${extStoragePath}/web/index.html")
        Log.d("TAG", "flutterWebFile path: ${flutterWebFile.path}") // /storage/emulated/0/web/index.html
        Log.d("TAG", "pathFlutterWeb is existed: ${flutterWebFile.exists()}")   // true
        val pathFlutterWeb = "file:///$flutterWebFile"

        binding.webview.settings.allowFileAccess = true
        binding.webview.settings.allowContentAccess = true
        binding.webview.loadUrl(pathFlutterWeb)

Is there missing something to replicate this issue? (checking this on Pixel 3a, Android 12)

1、put the builded web source to android device, for example, go to source dir(/xxx/flutter/build/web/), adb push all files to where you will load later:
cd /xxx/flutter/build/web/
adb push  *   /storage/emulated/0/Download/

2、add<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />to  AndroidManifest.xml
3、 add click method:
  if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
                when {
                    ContextCompat.checkSelfPermission(
                        MainActivity@this,
                        android.Manifest.permission.READ_EXTERNAL_STORAGE
                    ) == PackageManager.PERMISSION_GRANTED -> {
                        val outdir =    Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS)
                        if (!outdir.exists()) {
                            outdir.mkdirs()
                        }
                        // eg: /storage/emulated/0/Download/
                        this.webview?.loadUrl("file://${File(outdir.absoluteFile,"index.html").absoluteFile}")

                    }
                    shouldShowRequestPermissionRationale(android.Manifest.permission.READ_EXTERNAL_STORAGE) -> {

                }
                    else -> {
                        requestPermissions(
                            arrayOf(android.Manifest.permission.READ_EXTERNAL_STORAGE),
                            0x100)
                    }
                }
            }

Thanks but that error still persists with your updated code. I'm checking this on Pixel 3a, Android 12.

Screenshot

I was thinking to storage permission on Android version change, so I checked this on Android 11 device and add requestLegacyExternalStorage = true to bypass scope storage if any. But the result is still the same.
Also, the web path to index.html is existing (path.exists() is true). I added these settings too, but not working as well:
binding.webview.settings.allowContentAccess = true
binding.webview.settings.allowFileAccess = true

Maybe this is a new issue with native webview recently that I'm not aware?
Can you check this sample code if it's missing anything? load_flutter_web_128760

Thanks but that error still persists with your updated code. I'm checking this on Pixel 3a, Android 12.
Screenshot
I was thinking to storage permission on Android version change, so I checked this on Android 11 device and add requestLegacyExternalStorage = true to bypass scope storage if any. But the result is still the same.
Also, the web path to index.html is existing (path.exists() is true). I added these settings too, but not working as well:
binding.webview.settings.allowContentAccess = true
binding.webview.settings.allowFileAccess = true

Maybe this is a new issue with native webview recently that I'm not aware?
Can you check this sample code if it's missing anything? load_flutter_web_128760

https://github.com/huycozy/Android-Native-Sample/blob/load_flutter_web_128760/app/build.gradle
line 13.
plugins {
    id 'com.android.application'
    id 'org.jetbrains.kotlin.android'
}
android {
    namespace 'com.example.androidnativesample'
    compileSdk 33

    defaultConfig {
        applicationId "com.example.androidnativesample"
        minSdk 24
        targetSdk 33

build.gradle  change targetSdk 33 to targetSdk 28.

It's only displaying a white screen instead. In order to make this issue actionable and faster, please provide a sample code and affected Android devices (OS, model) so I can just clone and check it. Thanks!

It's only displaying a white screen instead. In order to make this issue actionable and faster, please provide a sample code and affected Android devices (OS, model) so I can just clone and check it. Thanks!

can you connect android device to chrome & inspect the web?
maybe you should modify your /web/index.html file.

It's only displaying a white screen instead. In order to make this issue actionable and faster, please provide a sample code and affected Android devices (OS, model) so I can just clone and check it. Thanks!

can you connect android device to chrome & inspect the web?
maybe you should modify your /web/index.html file.

<head>
  <!-- <base href="/"> -->
</head>

When I inspect the webview, I got another error:
Access to internal resource at 'file:///storage/emulated/0/Download/manifest.json' from origin 'null' has been blocked by CORS policy: Cross origin requests are only supported for protocol schemes: http, data, chrome, https, chrome-untrusted.

Inspector

Can you share a complete and workable sample code along with device info that you are seeing this issue?

you have repoduced this error.  this error will block the first view.  but if you build with flutter 3.7.x, everything is fine.
all android device will show this error, but iphone works.

same flutter code build web.
flutter 3.7.x build web.

flutter 3.10.2 build web.

Unfortunately, I get a similar result as my previous comment when using Flutter 3.7.0 (it's not worked on 3.7.0 as your result). Also, I see a similar error on desktop browser which also uses file scheme as mobile.

Access to XMLHttpRequest at 'file:///Users/huynq/Desktop/file_scheme_128760/build/web/assets/FontManifest.json' from origin 'null' has been blocked by CORS policy: Cross origin requests are only supported for protocol schemes: http, data, isolated-app, chrome-extension, chrome, https, chrome-untrusted.

There is a difference between XMLHttpRequest and internal resource (my result)/Fetch API (your result) in the error message.
Based on what you share at https://github.com/flutter/flutter/issues/128760#issuecomment-1592301391, it may be related to https://github.com/flutter/engine/pull/39657. Keeping this issue open and labeling it for further investigation.
Sample code: load_flutter_web_128760

Is there anything Flutter Web does that prevents this? It seems to be a restriction on Android webivews that disallows loading local files as HTTP requests. Does fetch work if you just load a plain HTML+JS page without Flutter Web?

Unfortunately, I get a similar result as my previous comment when using Flutter 3.7.0 (it's not worked on 3.7.0 as your result). Also, I see a similar error on desktop browser which also uses file scheme as mobile.

Access to XMLHttpRequest at 'file:///Users/huynq/Desktop/file_scheme_128760/build/web/assets/FontManifest.json' from origin 'null' has been blocked by CORS policy: Cross origin requests are only supported for protocol schemes: http, data, isolated-app, chrome-extension, chrome, https, chrome-untrusted.

There is a difference between XMLHttpRequest and internal resource (my result)/Fetch API (your result) in the error message.
Based on what you share at #128760 (comment), it may be related to flutter/engine#39657. Keeping this issue open and labeling it for further investigation.
Sample code: load_flutter_web_128760

Our Android developer has reviewed your Sample code: load_flutter_web_128760,  and has found that you need to change some WebView settings.
https://github.com/huycozy/Android-Native-Sample/blob/load_flutter_web_128760/app/src/main/java/com/example/androidnativesample/FirstFragment.kt
line 55
        binding.btn.setOnClickListener {
            when {
                ContextCompat.checkSelfPermission(
                    requireActivity(),
                    android.Manifest.permission.READ_EXTERNAL_STORAGE
                ) == PackageManager.PERMISSION_GRANTED -> {
                    val outdir =    Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS)
                    if (!outdir.exists()) {
                        outdir.mkdirs()
                    }
                    // eg: /storage/emulated/0/Download/
                    val path = File(outdir.absolutePath,"index.html").absoluteFile
                    Log.d("TAG", "is existed: ${path.exists()}")
                    val webSetting: WebSettings =  binding.webview.getSettings()
                    webSetting.allowContentAccess = true
                    webSetting.javaScriptEnabled = true
                    webSetting.javaScriptCanOpenWindowsAutomatically = true
                    webSetting.allowFileAccess = true
                    webSetting.setSupportZoom(false)
                    webSetting.builtInZoomControls = true
                    webSetting.useWideViewPort = false //##千万不能用
                    webSetting.loadWithOverviewMode = true
                    webSetting.databaseEnabled = true
                    webSetting.domStorageEnabled = true
                    webSetting.setGeolocationEnabled(true)
                    webSetting.pluginState = WebSettings.PluginState.ON
                    webSetting.setRenderPriority(WebSettings.RenderPriority.HIGH)
                    webSetting.cacheMode = WebSettings.LOAD_DEFAULT
                    webSetting.allowFileAccessFromFileURLs = true
                    webSetting.allowUniversalAccessFromFileURLs = true
                    webSetting.savePassword = false
                    webSetting.mediaPlaybackRequiresUserGesture = false
                    WebView.setWebContentsDebuggingEnabled(true)
                    binding.webview.settings.allowContentAccess = true
                    binding.webview.settings.allowFileAccess = true
                    this.binding.webview.loadUrl("file://$path")

                }
                shouldShowRequestPermissionRationale(android.Manifest.permission.READ_EXTERNAL_STORAGE) -> {}
                else -> {
                    requestPermissions(
                        arrayOf(android.Manifest.permission.READ_EXTERNAL_STORAGE),
                        0x100)
                }
            }
        }

BTW, you should comment out this line in the index.html file of the website source.
<head>
  <!-- <base href="/"> -->
</head>

Is there anything Flutter Web does that prevents this? It seems to be a restriction on Android webivews that disallows loading local files as HTTP requests. Does fetch work if you just load a plain HTML+JS page without Flutter Web?

Fetching to load the file:// schema does not work on the Android WebView, but it works on the iOS WebView.
https://fetch.spec.whatwg.org/

https://github.com/huycozy/Android-Native-Sample/blob/load_flutter_web_128760/app/src/main/java/com/example/androidnativesample/FirstFragment.kt

This is not part of the Flutter framework code. I think it's just an example that you can copy and paste into your project and then fix it to make it work. There's nothing the Flutter team can do to fix it.

Fetching to load the file:// schema does not work on the Android WebView, but it works on the iOS WebView.

I'm still not sure what we'd need to change in Flutter to make it work. Is there a different method for loading the manifest file that Android WebView would accept?

https://github.com/huycozy/Android-Native-Sample/blob/load_flutter_web_128760/app/src/main/java/com/example/androidnativesample/FirstFragment.kt

This is not part of the Flutter framework code. I think it's just an example that you can copy and paste into your project and then fix it to make it work. There's nothing the Flutter team can do to fix it.

Fetching to load the file:// schema does not work on the Android WebView, but it works on the iOS WebView.

I'm still not sure what we'd need to change in Flutter to make it work. Is there a different method for loading the manifest file that Android WebView would accept?

https://github.com/flutter/flutter/issues/128760#issuecomment-1600034131
The same Android code that loads web source built with Flutter 3.7.x will work, but it will not work with Flutter 3.10.x.
I believe the 'main.dart.js' generated by the engine is different.

One option is to monkey-patch fetch to operate on top of XHR such that the webview would accept it. I'm going to keep this issue in case we can find a volunteer to implement this.

Not sure how current this docs are, but here's some documentation about CORS, and the android web_view:
https://chromium.googlesource.com/chromium/src/+/HEAD/android_webview/docs/cors-and-webview-api.md#file_android_asset_res_urls

One option is to monkey-patch fetch to operate on top of XHR such that the webview would accept it. I'm going to keep this issue in case we can find a volunteer to implement this.

Why can't we roll back to using the old way to load the resources(FontManifest.json etc) that were used in Flutter 3.7.0?

https://chromium.googlesource.com/chromium/src/+/HEAD/android_webview/docs/cors-and-webview-api.md#file_android_asset_res_urls
(It seems the file: needs to be an asset or a resource of the app for this to work?)

You are correct. We have added webSetting.allowFileAccessFromFileURLs = true, so there is no CORS problem.

guys , any update on this issue ? I also encountered that ~_~.
"Access to script at 'file:///android_asset/flutter_assets/static/services/xxxxxx.js' from origin 'null' has been blocked by CORS policy: Cross origin requests are only supported for protocol schemes: http, data, chrome, https.", source: file:///android_asset/flutter_assets/static/index.html (0)

guys , any update on this issue ? I also encountered that ~_~
"Access to script at 'file:///android_asset/flutter_assets/static/services/xxxxxx.js' from origin 'null' has been blocked by CORS policy: Cross origin requests are only supported for protocol schemes: http, data, chrome, https.", source: file:///android_asset/flutter_assets/static/index.html (0)
Really appreciate if you comment , it's important for me , thanks
@JiaoLiu @yjbanov @ditman @huycozy

use flutter branch 3.7.0 to build web


smartcase in ripgrep searching doesn't work when searching non-latin filenames

🐛 Describe the bug
This bug is the same as in telescope: https://github.com/nvim-telescope/telescope.nvim/issues/3337
When using :ObsidianQuickSwitch for filenames in non-latin languages, the smartcase option doesn't work, i.e. I have to explicitly type the uppercase letters if using a non-latin language, (for example: Ф,П characters instead of ф, п)
Config
{
	"epwalsh/obsidian.nvim",
	version = "*",  -- recommended, use latest release instead of latest commit
	lazy = true,
	ft = "markdown",
	dependencies = {
		-- Required.
		"nvim-lua/plenary.nvim",
		"nvim-telescope/telescope.nvim",
		"nvim-treesitter/nvim-treesitter",
	},

	opts = {
		disable_frontmatter = true,
		workspaces = {
			{
				name = "personal",
				path = "~/stellardriven/",
			},
		},
	},
},

Environment
NVIM v0.11.0-dev-1326+g3bb2d02759
Build type: RelWithDebInfo
LuaJIT 2.1.1732813678
Run "nvim -V1 -v" for more info

I've switched to fzf-lua and it doesn't have this issue.


PyQGIS QGIS Python API docs are not properly formatted

URL
https://qgis.org/pyqgis/master/
Type(s) of Problems
Other
Summary
https://qgis.org/pyqgis/master/

https://qgis.org/pyqgis/3,4/

Thanks for reporting @agiudiceandrea, it has been fixed. It might require clearing the cache.


Binding error - query.lua -  attempt to index field 'query'

Getting this error when calling refactor('Extract Function'):
Error executing lua ...ck/packer/start/plenary.nvim/lua/plenary/async/async.lua:14: The coroutine failed with this message: .../packer/start/refactoring.nvim/lua/refactoring/query.lua:57: attempt to index field 'query' (a nil value)

Looks like a binding issue.
Tree-sitter works fine. It might be plenary (I only installed it for this test).
Anyone else getting this?

This is awesome.  Thanks for sharing.
Could you please provide the code you were using and the highlighted region?  If you cannot provide the code, can you change it enough to make it shareable?
Thanks :)
Also, I cannot imagine it being a bindings issue.
I checked everywhere that calls line 57 of query.  It is always called with : so it shouldn't be that.
Could you also PlugUpdate (or however you update your plugins)?

Thanks for the quick reply!
It doesn't work on any file for me :bomb:
I'll do some more debugging later today, the idea is amazing and after seeing it, I need it :smile:
Here's my setup:
 -- setup (packer)
{
"ThePrimeagen/refactoring.nvim",
requires = {
  {"nvim-lua/plenary.nvim"},
  {"nvim-treesitter/nvim-treesitter"}
}

-- config
local setup = require("core/setup")
local refactoring_ok, refactoring = pcall(require, "refactoring")
if not refactoring_ok then
  return
end
refactoring.setup()
local handlers = {
  extract_to_buffer = function()
    refactoring.refactor("Extract Function")
  end,
  extract_to_file = function()
    refactoring.refactor("Extract Function To File")
  end
}
local VISUAL = "v"
setup.mappings(
  {
    {VISUAL, "<leader>re", handlers.extract_to_buffer},
    {VISUAL, "<leader>rf", handlers.extract_to_file}
  }
)

Sample file (js):
const main = () => {
  const a = 10;
  const b = 20;

  // SEL_START
  for (let i = a; i < b; i++) {
    console.log(i);
  }
  // SEL_END
};
main();

Logged self at query.lua:56 before it crashes:
{
  bufnr = 1,
  lang = "javascript",
  root = <userdata 1>,
  <metatable> = <1>{
    __index = <table 1>,
    find_occurrences = <function 1>,
    get_root = <function 2>,
    get_scope_by_position = <function 3>,
    get_scope_over_region = <function 4>,
    new = <function 5>,
    pluck_by_capture = <function 6>,
    query_type = {
      Block = "definition.block",
      FunctionArgument = "definition.function_argument",
      LocalVar = "definition.local_var",
      Reference = "reference",
      Scope = "definition.scope",
      Statement = "definition.statement"
    }
  }
}
-- E5108: Error executing lua ...ck/packer/start/plenary.nvim/lua/plenary/async/async.lua:14: The coroutine failed with this message: .../packer/start/refactoring.nvim/lua/refactoring/query.lua:57: attempt to index field 'query' (a nil value)

This makes it work:
((formal_parameters
    (identifier) @definition.function_argument))
((formal_parameters
  (assignment_pattern
    (identifier) @definition.function_argument)))

Ahah!  Yes!
We don't have javascript support quite yet.  Just typescript.
I'll try to get javascript up and running soon.

still working on tmux script, start this soon.

Closing as we have js support. I believe we will make rust another ticket itself (as it's its own pile of work).


Make failurePolicy for webhooks configurable.

What this PR does / why we need it:
This is a workaround for issue #3415. It will allow cert-manager cluster-issuers to be created for users experiencing this issue.
-->

I don't think this should be accepted - the issue described in #3415 should be fixed, rather than patching around it and allowing the error to be skipped. This will lead to instability and potentially crashes in cert-manager clients (e.g. our own controller, and any other ecosystem tools/controllers that expect validation/mutation/conversion to be possible)

I don't think this should be accepted - the issue described in #3415 should be fixed,

I agree.
@brokencode64 the webhooks are an integral part of cert-manager and must not be disabled.
Let's go back to https://github.com/jetstack/cert-manager/issues/3415 and investigate further.


[Feature] storage disk temperature

Description of the feature
Would it be possible to have the all storage disk temperature displayed ?
Additional context
No response

duplicate of #688


Revert "Fix typo in nightly deploy project list (#3853)" [skip ci]

This reverts commit ba5bc08062d07dee593170a00399260de109031a.
fixes https://github.com/NVIDIA/spark-rapids/issues/3857

added skip ci because this script is not tested by premerge


[v4.0beta17-mono] Windows Release Builds Frozen on Launch

Godot version
4.0.dev (c40020513) (4.0 beta 17 Mono Version)
System information
Windows 10/11 Nvidia GPU (varied)
Issue description
Several of my players that are windows users are reporting that the game does not launch on their system. It reaches to the splash screen then does nothing.
I have had several reports of it working and several of it not working. One user opened an issue on the project repository noting they got an error of having run out of RAM. Both of us verified that it seems to cap out around 700 Mb of memory usage. But since I'm on Linux I can't test much myself.
Another user was helping me to do some debugging and was able to generate this verbose log file. But I'm having trouble making heads or tails of it. It seems to imply one of the autoload scenes is loaded, and then everything stops
WhereTheDeadLie_WindowsTrace.txt
I haven't had any reports from Linux or Mac users, and from the analytics on the project page I know several users on each system have downloaded the project. So I believe this is a strictly windows issue?
I'm actually really hoping that this is an issue with the engine of some sort, because I'm at a complete loss what it could be. Thanks for any help that can be provided!
Steps to reproduce
Run the game on a windows machine (Unsure if Nvidia GPU is related). Launch should stop before fully loading the main menu.
Minimal reproduction project
N/A (I don't know what's causing this.)

I forgot some important links:

Project Repository: https://github.com/QueenOfSquiggles/DumbJumpscareGame
Project Download Page: https://queenofsquiggles.itch.io/where-the-dead-lie
For the download page, I've been uploading "Windows DEBUG" versions as demos so they are free to download. I've been incrementing the version number for those with each iteration. I'm not sure how to link a direct download otherwise I would

I think the crash happens because none of your theme's SystemFont options are available on Windows. So to get readable text on Windows, you'd have to add the appropriate font(s) to the list.

Consider adding Segoe UI as a last option to your system font.


Cleanup verilog emitter casts

Checklist

[x] Did you specify the type of improvement?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?

Type of Improvement
This is a backend code generation improvement. It removes unnecessary casts that are frequently lint warnings in standard Verilog tools

API Impact

Adds new isCast utilities to firrtl.Utils to check if a PrimOp or an Expression is a cast
Adds InlineCastsTransform which is used by the VerilogEmitter to create complex expressions if one of the expressions is a cast

Backend Code Generation Impact
This is intended to make our generated Verilog more friendly to standard lint tools (eg. Spyglass). Because we emit all wires/regs/ports as unsigned, statements like
assign foo = $signed(bar);

are pointless, foo is unsigned as is bar.
Assuming we're then adding SInt foo to a negative literal, we emit:
assign x = $signed(foo) + $signed(-8'sd10);

This PR will instead emit the more sensible:
assign x = $signed(bar) + -8'sd10;

To accomplish these improvements, this PR does the following:

Optimize unnecessary casts in ConstantPropagation
Inline cast Expressions for cleaner Verilog emission
Remove redundant casts in Verilog emission

(1) is straight forward asUInt on a UInt is replaced with the UInt itself (Works for other casts of course)
(2) has 2 forms:
2a)
node _T_1 = asSInt(x)
node _T_2 = add(_T_1, y)

becomes
node _T_2 = add(asSInt(x), y)

And
node _T_1 = add(x, y)
out <= asUInt(_T_1)

becomes
out <= asUInt(add(x, y))

(3) is perhaps the weirdest part of this PR. Basically, the Verilog emitter is already injecting $signed casts for any signed primitive operations irrespective of the types of the arguments. We could be a bit more principled about this and only inject them if the argument is a signed reference, otherwise emit the cast as appropriate. That's not how I've done it though, at the moment it just ignores all casts, assuming the circuit is in a valid form, and then injects the casts for the operators that need them. This is more in line with the existing implementation of the emitter, but I'm not against small to moderate cleanups.
Desired Merge Strategy
Merge commit

Future Work
It would be good to clean up the Verilog emitter primitive operation emission a bit. This is not necessarily easy because you would like to know if the prim-op is a "top-level" Expression (ie. outer most in the LHS of a Statement), but that information is not available and isn't trivial to add as architected.
InlineCastsTransform is extremely similar in analysis and structure to ReplaceTruncatingArithmetic. I'd like to chain the transforms manually to (1) improve performance, but (2) illustrate how we might reason about transform chaining (and analysis sharing) in the future. This is definitely beyond the scope of this PR, but something I am thinking about.

I'd also like to backport this to 1.2.x since it is a pretty nice lint improvement

There is a real failure, let's not block https://github.com/freechipsproject/firrtl/pull/1270 on this

I will want to rebase this before merging (or I guess we can just squash-and-merge), but I think it's now actually good to go

I want to highlight the addition of LegalizeClocksTransform which I found to be necessary due to https://github.com/freechipsproject/chisel3/blob/954cc41e1349d0df6d2250d6270590340cd36e82/src/test/scala/chiselTests/MultiClockSpec.scala#L182. While this is rare and a strange occurrence that we should optimize away, we need to handle it even when optimizations are disabled (note MinimumVerilogCompiler in the tests). It's really a workaround Verilator not supporting what I suspect is legal Verilog, but even lint tools are very unhappy about it so it's a good thing to do regardless.

Just the LEC tests on ICache timing out/running out of memory, will manually verify

This PR includes [skip formal checks], but I ran them manually. They all pass using using the standard Yosys flow, the ICache just needed 10 GB (Travis provides 3-4 GB).


Once applicant enters email/phone, we send them verification code

Then, once they enter the right verification code on the UI, any information associated with their account is pre-filled into questions they've answered before.
Note that we should have some UX writing that reminds people to be mindful of the email address they're entering, since we'll preload everything for that address -- if they previously used a different email address to apply for a friend or family member and want to apply on behalf of that same person again, they should enter the same email again.
See tiny.cc/cvf-ux-tracker for more details.

Apparently IDCS doesn't support magic sign in links -- has to be email and password.


[VL] Daily Update Velox Version (2024_06_19)

Upstream Velox's New Commits:
1a50a8afe by wypb, Add support OrcReader based on DwrfReader (10194)
11bdeb831 by Kevin Wilfong, Fix Velox counts incomplete UTF-8 chars differently than Presto Java (10204)
c6d7390db by Zac Wen, Add a limit on loadQuantum (10242)
3810cbb8a by Orri Erling, Add timeout to profile test (10063)
760339dd0 by Orri Erling, Add extra info to Profiler, Hooks for memory stats recording (10196)
f7d4d3332 by Bikramjeet Vig, Fix NaN handling in set_agg, set_union and count(distinct) (10047)
6896ded20 by xiaoxmeng, Add folly cancellation token support in task and connector source (10157)
db287c997 by Zac Wen, Fix cache shutdown order (10239)

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_6153_time.csv
log/native_master_06_19_2024_27c32f1b15_time.csv
difference
percentage

q1
36.55
34.61
-1.940
94.69%

q2
23.81
25.46
1.653
106.94%

q3
38.52
38.59
0.075
100.20%

q4
32.16
33.98
1.817
105.65%

q5
72.19
70.97
-1.218
98.31%

q6
6.49
6.54
0.055
100.85%

q7
84.25
85.08
0.831
100.99%

q8
86.50
87.11
0.618
100.71%

q9
122.65
123.67
1.024
100.83%

q10
44.87
44.85
-0.020
99.96%

q11
19.98
20.56
0.582
102.91%

q12
24.99
27.28
2.293
109.18%

q13
39.64
39.58
-0.065
99.84%

q14
19.36
18.81
-0.544
97.19%

q15
33.40
33.35
-0.051
99.85%

q16
13.06
14.28
1.219
109.33%

q17
105.41
105.60
0.187
100.18%

q18
146.09
144.60
-1.487
98.98%

q19
14.79
13.77
-1.025
93.07%

q20
27.12
29.04
1.928
107.11%

q21
269.67
265.23
-4.449
98.35%

q22
13.29
12.88
-0.418
96.85%

total
1274.79
1275.86
1.066
100.08%


Audio moves to Earpiece from Speaker when incoming call ends

Describe the bug
During video session ( session is going on speaker) call comes on Android device. When accepting the call, video session goes into background.
After while when call ends then video session comes into foreground again and at that time audio goes into Earpiece but it should be in speaker as it was in speaker before.
To Reproduce
Steps to reproduce the behavior:

When the video session is going on and it is on speaker, at that time call comes into the Android device.
Receive the call and talk for a while.
End the call
Video session comes into the foreground from the background
Now audio goes into Earpiece

Expected behavior
Before the incoming call video session was on the speaker and after ending the call video session should be on the speaker
Actual behavior
Before the incoming call video session was on the speaker and after ending the call video session goes into Earpiece.
AudioSwitch Version

Version: 1.1.1

Android Device (please complete the following information):

Device: Android

Hi @BlCop ! Thank you for reaching out regarding this issue. We are aware of this one and have a bug ticket to fix it in our next sprint. I'll be sure to update this ticket with the PR that resolves the issue. Thanks!

Hey @Alton09 Any update on it? I am also facing this issue on some particular devices like Realme and Samsung Galaxy Note 9

Hi @himanshu-my . I'm currently working on this bug at the moment and will provide an update soon. Thank you for sharing those problematic devices. I'll be sure to test on them or similar devices that we have available.

@BlCop @himanshu-my I found a workaround that you all can use in the meantime while we implement support for this in the library. Check out this commit in the Twilio Video App. It uses PhoneStateListener to toggle AudioSwitch based on the system phone call state. More updates coming soon regarding library support.

@BlCop @himanshu-my After digging into this issue a bit more I have discovered that this problem can be avoided by providing a AudioManager.OnAudioFocusChangeListener implementation to the AudioSwitch constructor, which will be less boilerplate than the PhoneStateListener solution. Within the implementation you will want to call activate() every time the AUDIOFOCUS_GAIN focusChange event is received. I have noticed some odd behavior with bluetooth is active, so make sure to add a check for all audio devices besides a BluetoothHeadset. Here's what this implementation looks like:
AudioManager.OnAudioFocusChangeListener { focusChange ->
        if (focusChange == AUDIOFOCUS_GAIN && audioSwitch.selectedAudioDevice !is AudioDevice.BluetoothHeadset) {
            audioSwitch.activate()
        }
}

Hope this helps! Thanks.


Update AWS Java SDK to 1.10.22

This upgrades the AWS Java SDK from 1.9.40 to 1.10.22. Although this version is only relevant in testing, I'm upgrading because older versions of the SDK have bugs in the getBucketLifecycleConfiguration configuration. According to an automated email from AWS:

Your account has been identified as a user of the AWS SDK for Java making API requests to Amazon S3's getBucketLifecycleConfiguration operation. With the recent launch of the Standard – Infrequent Access storage class, getBucketLifecycleConfiguration's response can now have a new valid value for the StorageClass attribute: "STANDARD_IA".
The AWS SDK for Java models this response element as an Enum, and STANDARD_IA was not a valid Enum value in previous versions of the SDK. Therefore, if a lifecycle policy involving the new storage class is configured on your bucket through other means such as the AWS Management Console, all getBucketLifecycleConfiguration calls made by previous versions of the AWS SDK for Java will fail with an AmazonClientException. If you plan to utilize Amazon S3's lifecycle feature with the new Standard - Infrequent Access storage class, it is critical that you update your AWS SDK for Java to 1.10.19 or later to avoid running into this error.

This upgrade should help other developers who test this library to avoid receiving the same message from Amazon.

Ugh, looks like a Jackson conflict:
com.fasterxml.jackson.databind.JsonMappingException: Could not find creator property with name 'id' (in class org.apache.spark.rdd.RDDOperationScope)

Current coverage is 95.00%

Merging #104 into master will not affect coverage as of d06325f

@@            master   #104   diff @@
=====================================
  Files           12     12
  Stmts          501    501
  Branches       122    122
  Methods          0      0
=====================================
  Hit            476    476
  Partial          0      0
  Missed          25     25

Review entire Coverage Diff as of d06325f

Powered by Codecov. Updated on successful CI builds.


Updates to model or form data should be reflected in the form (data binding)

If form values are updated outside the dynamic form, the form should recognize this and rerender or update its values accordingly.
We should have a separate attribute to provide data, with the assumption that data will be stored and handled separately from schema.
{{dyanamic-form schema=schemaObj data=dataObj}}

where the data object has keys that match the ids of each item defined by the schema
When the data object is updated, the dynamic form component should be re-rendered and display the new values.

I'll pick up this one next...

I'd say the priority with the work item is to support "Data Down",  meaning changes to the base model should be reflected in the UI.  I think we should de-emphasize "Data Up", meaning changes that the user makes on the form are not automatically set to the model, but rather require an action.
I'm currently working on issue #21 where I'll give the ability for the caller to provide a change action for this.  Another possibility would be to look into supporting the mut helper, though the this.attrs convention may not be stabilized until glimmer 2.
thoughts?  @jeremywrowe @cliffpyles @samchrisinger ?

Definitely in favor of single-directional binding here as it provides a looser coupling between the parent component/controller and the dynamic-form child. I'm not an Ember pro by any means, but the pattern of passing an action down to a child component seems very common.
Additionally this could have the benefit that the parent controller/component get's a stronger guarantee that it's state is only being updated with valid data (i.e. the dynamic form component runs all of it's validations, and only notifies the parent if there are no errors).

This is what I'm working on and hope to have this deployed within a week:
Today we work if you pass a plain JavaScript Object { } as the data argument.
I will also support passing an ember object, whether it be an Ember.Object, or a DS.Model.   Properties will be accessed from these objects using get so things computeds can be honored.

Cutting a release this weekend where the data param takes ember objects.  I had more trouble updating alpaca forms external to the form.  It looks like while we use alpaca, I'm going to have to do something that uses observers to listen for data changes and then programmatically update the rendered alpaca objects.  I started a branch for this but will probably treat it as a lower priority until a find out about someone who wants to update form values external to the form.  In the meantime like I said we do now support ember objects as data (starting and 0.0.9), so things like computed properties are now honored.

Hey @toddjordan, My schema changes dynamically based on a users input, I need my form to rerender based on when the schema changes, any idea how i could do that?

Hi @Rytiggy The schema is rendered in the component's didReceiveAttrs hook, which runs when the component is initially rendered.  We could add some functionality to add a didUpdateAttrs hook that ill re-create and render the schema when that specific attribute is updated.
See https://github.com/toddjordan/ember-cli-dynamic-forms/blob/master/addon/components/dynamic-form.js#L32-41
Feel free to submit a PR if you want to play with it and get it going.  Let me know if you have questions.

@toddjordan afik didRecieveAttrs runs any time a component receives new attributes. This can be at instantiation or later in the component's lifecycle. So we're noticing that didRecieveAttrs does fire when schema is updated, but the Alpaca form never get's re-rendered (looks like rendering happens in didInsertElement?).
I'm wondering if it's reasonable to refactor the rendering code from didInsertElement into a helper and then actually triggering an Alpaca rerender if the schema is changed?

yes, I think that would make sense.  try it out and if it works for you we can incorporate it.
We should probably save the renderer object as an instance variable on the component and then just call this.get('renderer').render(this.get('renderSchema'), this.$()); in didReceiveAttrs

WIP PR here: https://github.com/toddjordan/ember-cli-dynamic-forms/pull/37. Still working through some integration tests... probably not going to happen today, but hopefully soon.

awesome!  Will take a look this afternoon/evening.  Hoping to get some time in the next week to work on rendering ember components as well B-)


panic: runtime error

root@ubuntu-do:~# chaos -d target.com -key API_KEY -o output.txt

        __
  _____/ /_  ____ _____  _____
 / ___/ __ \/ __  / __ \/ ___/
/ /__/ / / / /_/ / /_/ (__  )
\___/_/ /_/\__,_/\____/____/  v0.4.0

                projectdiscovery.io

Use with caution. You are responsible for your actions
Developers assume no liability and are not responsible for any misuse or damage.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x38 pc=0x6bbc9d]

goroutine 6 [running]:
github.com/projectdiscovery/chaos-client/pkg/chaos.(*Client).do(0xc000036380, 0xc00015c1b0)
        /root/go/pkg/mod/github.com/projectdiscovery/chaos-client@v0.4.0/pkg/chaos/chaos.go:37 +0x13d
github.com/projectdiscovery/chaos-client/pkg/chaos.(*Client).GetSubdomains.func1(0xc000102120)
        /root/go/pkg/mod/github.com/projectdiscovery/chaos-client@v0.4.0/pkg/chaos/chaos.go:120 +0x1bb
created by github.com/projectdiscovery/chaos-client/pkg/chaos.(*Client).GetSubdomains
        /root/go/pkg/mod/github.com/projectdiscovery/chaos-client@v0.4.0/pkg/chaos/chaos.go:111 +0xe5

@0xPugazh it was fixed in last release - https://github.com/projectdiscovery/chaos-client/issues/153, make sure to update to the latest version.

Closing this issue as this is already fixed.


Intent Handling doesn't work with satellite setup

It seems that homeassistant intents do not work with a satellite setup. The intents are recognized, but not handled. Everything works via the web browser on the base station as long as the field handle is checked.
While other sections have an input field called Satellite siteIds, the Intent Handling section does not have this field. Is this a problem?

I have a working satellite setup in v2.5.8 via rhasspy's own mqtt server.
Intent handling is only enabled on the base. the satellites' names are added to the list of ids there.
Works without problems.

Closing due to inactivity. Please re-open if the problem persists.

Closing due to inactivity. Please re-open if the problem persists.


Update SKU details to match portal

The portal wizard shows different sku dimensions than this page. (also there is a new 20 Core sku needed. I've not added as i don't know all the details.)

@tbertenshaw : Thanks for your contribution! The author, @CarlRabeler, has been notified to review your proposed change.

@tbertenshaw : Thanks for your contribution! The author, @CarlRabeler, has been notified to review your proposed change.

@tbertenshaw : Thanks for your contribution! The author, @CarlRabeler, has been notified to review your proposed change.

@tbertenshaw Thank you.
#sign-off


Add support of the new data structure HyperLogLog

As a plan in Kvrocks 2023 Roadmap, we are eager to explore the ability to implement HyperLogLog commands in Redis for kvrocks.
Everyone is welcome to ask questions, or contribute your ideas/PRs.

I am working on this

Glad to hear that. Assigned.

Hi @dongdongwcpp, how is it going now?

I'd like to design the part in kvrocks. And I'm considering the storage about hyperloglog.

In a few days, I will present a concrete idea.

In a few days, I will present a concrete idea.

Thanks! Assigned.

@infdahai How is it going now? Feel free to share your problems with us.

I'd like to take over this task. @PragmaTwice

I'd like to take over this task. @PragmaTwice

Great! Assigned.

Hello, I have observed that this issue has not progressed for a long time.. Are you still doing it now? If not, I want to try it. @Yangsx-1

@qujihan Sure, I have changed the assigned. Thank you!

You can first draft a format in discussion, and then move forward to implement it.
Some database uses HLL to optimize the ndv:

https://github.com/facebookincubator/velox/tree/main/velox/common/hyperloglog
https://github.com/ClickHouse/ClickHouse/blob/92e63bf45c3cd36163131e42d4bd003e543031f4/src/Common/HyperLogLogCounter.h

You can choose them or using similar like HLL in Redis

Hello, I have observed that this issue has not progressed for a long time.. Are you still doing it now? If not, I want to try it. @Yangsx-1

Just do it! I'm very busy these days, you can take this task.

@PragmaTwice I create a PR #2142 for support hyperloglog.
The core algorithm code is transplanted from redis, and may have optimization room on disk storage.


Upgrade Electron

Before submitting, please confirm you've

[x] read and understood our Contributing Guidelines
[x] completed Mattermost Contributor Agreement
[x] executed npm run lint:js for proper code formatting

Please provide the following information:
Summary
Upgrade Electron from 1.7.11 to 1.8.2.
As far as reading release notes, I didn't find important changes for us excepting https://github.com/electron/electron/pull/10517.
Issue link
#702, #601
Test Cases
General usecases.
Additional Notes
https://circleci.com/gh/yuya-oc/desktop/603#artifacts

I couldn't find new significant issues on Windows 10 and macOS 10.12.6. There might be potential problem, but I merge this for now.


memory_dff: Fix checking of feedback mux input when more than one mux

Fixes a regression from #1130
cc @gsomlo, this was found in https://github.com/gsomlo/yoloRISC

Assuming we are happy with this, I think this should be added to the 0.9 RC as it fixes a relatively serious regression. Not sure how we want to approach that (either cherry-pick, or submit this PR straight to yosys-0.9-rc instead?)

Tested (with and without "-nowidelut -abc9") on both yoloRISC and LiteX+RocketChip (https://github.com/enjoy-digital/litex); fixes regression on both -- thanks for the quick turnaround!

Looks good. Sorry this was something I introduced.
The only minor concern I have is that when it comes to support reset-able read ports, this needs to be revisited.


Basic Command Processor

Add a command (CLI) processor (cyberdefense.py)
and
updates torch* dependencies.

Withdrawing request.


Update indent

My brain has not yet adapted to this new tab size... but here are a few more places where it's specified.

Thanks for the pull request @emackey!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

Thanks @emackey!


[HALLOWEEN] Halloween lobby music!!!

About the PR
Spooky music!
Why / Balance
Scary Music for everyone!
Technical details

Media

Requirements

[x] I have read and am following the Pull Request and Changelog Guidelines.
[x] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog
:cl:

add: Added scary halloween music! Be aware of ghosts on the station! :ghost:

huh

Are you aware of #8524 ?

Due to the two week release cycle, this is a bit late, and it will not be entirely trivial to undo. Additionally there's a freeze on any extra music due to increasing size of the game, until asset streaming from the server is implemented. Which would go really nicely together with seasonal or holiday specific music like this, but I'm not sure there's a system for that as of yet.

Are you aware of #8524 ?

oh i forgor about it


Yes, that is possible.  To decide if this is something that we should do it would be useful to understand the costs and benefits of such a decision.

I guess my current issue is that we are optimizing the execution graph based off of sinks, but some of the other nodes may do things that effect the system overall but are not sinks. Eg a map which saves something to a database or writes out some file. Currently that node would be removed if it isn't attached to a sink.
I guess one could argue that that function should be split into two parts, the first which does computation and the second which sinks to a database but to some extent we may want to meet users where they are and encourage changes without causing breakage.
This does make some things a bit more complex as the user will need to understand the difference between strong and weak ref'ed nodes, but that may be ok as it will nudge users towards the weak ref workflow while giving them a safety release valve for the short term. It will also increase our complexity some, but maybe not in a truly awful way (I don't know what this means implementation wise yet)?
Maybe another workflow is to have a dummy sink and attach it to things that we care about?

Two cheap options come to mind that don't require changing the codebase.

Replace map with sink in your code
Create a keep function that registers your stream to a global set

_kept_streams = set()

keep = _kept_streams.add

keep(source.map(func))

I like option 2, thank you!

Great. OK to close then?

Out of curiosity, what is the aversion to using sink?

Sink and map mean different things in SHED and I've inherited the weak ref system from streamz. In this case map dispatches between the different document types (start, event, etc.) whereas sink just passes the documents to the callable (which has to handle the heterogeneity itself).


#0: Increase multi-device post-commit and nightly to every 3 and 4 hours respectively to get models more feedback on main

…

Are you skipping them - or we no longer want them?

Are you skipping them - or we no longer want them?

Could we skip them until Joseph is back? might be a minor fix in the ttnn api

Yes assigned https://github.com/tenstorrent/tt-metal/issues/7664 to @cfjchu


[Proposal] Use alpine containers

i am not sure about this yet, the idea was to have all the containers derived from the same base (debian) so when one of them downloads the OS layer, all of them have it. Also debian is just a little bit easier to extend (not all things are easy to compile, haskell needs glibc).
Do you have other reasons for this change?


Enable issue to allow contributors to discuss features for website

Some contributors would like to refactor the homepage for Kvrocks website and there's no way to discuss it now.

Per Pulsar and SkyWalking's practice, you can discuss on the main repo, i.e., http://github.com/apache/incubator-kvrocks.
Scatter discussions into multiple issue trackers (instances) may not be a good idea. You may think of Flink has a number of sub repos but all the issues are tracked on FLINK jira project.

@tisonkun Thanks for your advice, let's move to Kvrocks discussion.


Make View.Interactable a regular View

So you don't need to always wrap Views, you can also just add Interactable to an existing view (decorator style)

Hey,
I've commented in other issues but wasn't lucky to get a reply. First, thanks for creating the great library, I am creating the web version of the library, you can see it working at:
https://github.com/wix/react-native-interactable
And the fact of not understanding if Interactable.View is a real view or not is where I am struggling the most.
In the web version I use an Animated.View as the component that renders Interactable.View as I can track the movements using the PanResponder and animate it. But that's a problem, I am actually adding a wrapper, that has its own styles, so the content of Interactable.View is really affected by the wrapper. To explain it better:
// if I use Interactable.View like this
<Interactable.View>
  <View style={ position: 'absolute', top: 0}><Text>Hola</Text><View>
</Interactable.View>

// internally is transforming it to
<Animated.View style={ transforms }>
  <View style={ position: 'absolute', top: 0}><Text>Hola</Text><View>
</Animated.View>

If in the web version I set that Animated.View's position is relative the content is confined inside Interactable.View. The same for other style properties like alignItems, justifyContent...
Ideally Interactable.View should be transparent for the user, like if it doesn't exist, so the user can set the styles wanted in the content. Since I can't achieve that, the alternative solution is that the user could set the style property for the Interactable.View like:
<Interactable.View style={{position: 'absolute'}}></Interactable.View>

So the user regains the control of the styling, but react-native-interactable doesn't accept the style prop, so that would make both libraries not compatible.
Could you add that style prop that would pass the styles down to the wrapper?
Thanks!!


feat: update to eye v8.5.0

feat: update to eye v8.5.0

:tada: This PR is included in version 10.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v10.5.0

Your semantic-release bot :package::rocket:


Azure Web App for container and swap support

In documentation, Microsoft don't say if this feature is supported in Azure web app for container ( Linux )

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f6e09089-1ae2-8943-5ce2-9d48f458c81f
Version Independent ID: ba780cba-f604-b0a4-a81a-23c7d2384762
Content: Set up staging environments - Azure App Service
Content Source: articles/app-service/deploy-staging-slots.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@chtourou-youssef, Thanks for the feedback! We are taking a look into this and will get back to you soon.

chtourou-youssef, Apologies for the delay. We have raised a PR, once it's reviewed and merged, the doc would reflect changes appropriately. We will close this for now, thanks again for taking time to share your feedback.


Geoserver

Finished implementation of ENDDAT-164. The cida-owsutils-geoserver version needed to be updated to the latest (1.0.6) in order to bring in the correct dependencies for the cida proxy.
When the shapefile is uploaded successfully, the code buts a property on the workflow state model containing the feature name to be used when displaying on the map. The MapView added an event handler for this property in order to draw (or remove the previous) uploaded feature.

:+1:
Looks great! Must admit I would have struggled to put all the puzzle pieces together. :stuck_out_tongue:


UDP checksum function and test case

Created function for calculating UDP checksum which uses a pseudo header
Test case added within test_dhcp.py

Great!

Tested and confirmed to work.

It works!

Conforms to RFC768 from what I can tell. LGTM
I didn't realize TCP, UDP, and IPv4 share the same checksum algorithm (IP_checksum function in dhcp.py.) Very cool!


making builds work on macos

Attempted to build for macos and ran into some gl.h issues where the linker wasn't able to find them.
Commenting it out seems to work since clang can find the functions if gl.h isn't included (I'm really not too sure why, think it has to do with mac bundled entry points?). Managed to build on both x86_64 and M1 arm64 macos. Can also provide a zip of the build for x86
I know #ifdef isn't really the best solution - willing to refactor to multiple files or whatever solution you prefer. Also this should not have any affect for the windows / linux build, but I haven't tested that yet.

I think I know how to sort out the second #ifdef, instead of using a constuctor the window can be built explicitly. This makes vsync work for macos as well.

 You used raylib-cpp 4.2.5 which doesn't have 4 argument initialization for Window. I'll include dependencies in the repo to avoid issues like this as well as to simplify the setup procedure.

I've added you as a collabrator for the repo, can you provide x64 and arm64 builds for the game? Thanks in advance!

sure, I can provide the x86 ones at the moment, m1 arm requires me to cross compile (or see if my friend still has a binary somewhere) so that might take a bit.
I think usually people use git submodules for vendored dependencies (would definitely be easiest I think)

I don't like messing with git so dumping all the files into the repo it is. The macos x64 build is uploaded onto itch.io now.


macOS: exception on startup

Hi, great project!
On my Mac I get an exception as soon as I open http://localhost:8001 in Safari or immediately if I run_debug() instead of run_server() in main.
./run.sh
Serving http server on http://localhost:8001
Websocket ready and running on http://localhost:6789
<IP_ADDRESS> - - [30/Dec/2022 18:32:11] "GET / HTTP/1.1" 200 -
<IP_ADDRESS> - - [30/Dec/2022 18:32:11] "GET /static/js/remarkable.js HTTP/1.1" 200 -
<IP_ADDRESS> - - [30/Dec/2022 18:32:11] "GET /static/js/menu.js HTTP/1.1" 200 -
<IP_ADDRESS> - - [30/Dec/2022 18:32:11] "GET /static/js/handler.js HTTP/1.1" 200 -
<IP_ADDRESS> - - [30/Dec/2022 18:32:11] "GET /static/img/pen-solid.svg HTTP/1.1" 200 -
connection handler failed
Traceback (most recent call last):
  File "..../pipes-and-paper-enhanced/.venv/lib/python3.9/site-packages/websockets/legacy/server.py", line 236, in handler
    await self.ws_handler(self)
  File "..../pipes-and-paper-enhanced/.venv/lib/python3.9/site-packages/websockets/legacy/server.py", line 1175, in _ws_handler
    return await cast(
  File "..../Develop/pipes-and-paper-enhanced/src/server.py", line 73, in handler
    screen_input = await get_screen_input(listener)
  File "..../Develop/pipes-and-paper-enhanced/src/screen_api.py", line 92, in get_screen_input
    raise ValueError(f"Buffer is not 16 bits: {len(buffer)=} {buffer=}")
ValueError: Buffer is not 16 bits: len(buffer)=0 buffer=b''

./run.sh
Listening on /dev/input/event1
Traceback (most recent call last):
  File "..../pipes-and-paper-enhanced/./main.py", line 32, in <module>
    run_debug()
  File "..../pipes-and-paper-enhanced/./main.py", line 18, in run_debug
    screen_input = loop.run_until_complete(get_screen_input(listener))
  File "..../3.9/lib/python3.9/asyncio/base_events.py", line 642, in run_until_complete
    return future.result()
  File "..../pipes-and-paper-enhanced/src/screen_api.py", line 92, in get_screen_input
    raise ValueError(f"Buffer is not 16 bits: {len(buffer)=} {buffer=}")
ValueError: Buffer is not 16 bits: len(buffer)=0 buffer=b''

I had .venv set up and ssh access was already configured. I changed the hostname in main.py to match mine (rm2usb for USB connection). Checked rM was connected.

Hello,
Your issue might be solved by this commit currently on the dev branch
https://github.com/Pyrrhu5/pipes-and-paper-enhanced/commit/14502c870bafddb31cc804a6eae133fc69680de4
Can you retest with these changes?
If it fails, can you provides the version of your ReMarkable (1 or 2?)

Thanks, it works now :)
I also changed run.sh (locally), so the new CLI options can be used with it, too
python $ROOT_PATH/main.py $1 $2 $3 $4 $5 $6

https://github.com/Pyrrhu5/pipes-and-paper-enhanced/commit/14502c870bafddb31cc804a6eae133fc69680de4

I also changed run.sh (locally), so the new CLI options can be used with it, too
python $ROOT_PATH/main.py $1 $2 $3 $4 $5 $6

Changed made for the run.sh to pass the arguments to main.py


Shadow of rose is not in first person

I bought shadow of rose (re8 DLC) and it's in third person instead of first.

Tried the nighly build based on 627e6dbfb5f97bccf822a1e4a31b8efbde63d29f (RE8: fix)  Same problem.

I try to play Shadow of Rose with the great VR Praydog RE8 mod in first person and I can't achieve It. Someone with success?

News about this?

No. If anything, you aren't going to see anything for a while. Nothing is planned at the moment.
Already busy with RE4 (a mainline entry, more important), and the UE injector.


link validator: AbstractFunction2

the link validator for PRs is failing with:
## HTTP failure response
`[https://www.scala-lang.org/api/2.13.13/scala/runtime/AbstractFunction2.html`](https://www.scala-lang.org/api/2.13.13/scala/runtime/AbstractFunction2.html%60) status 404 Not Found
 - ../../../../../target/scala-2.13/unidoc/org/apache/pekko/cluster/index.html
 - ../../../../../target/scala-2.13/unidoc/org/apache/pekko/remote/index.html

... it seems this problem also exists on the main branch. Did scala-lang change or did we miss it in a recent PR?

We've had to add link validator excludes for this in a few places.

@raboof see https://github.com/apache/incubator-pekko/blob/main/scripts/link-validator.conf#L64
Looks like we need to upgrade the URLs to have 2.13.13 or find a way not to hardcode the version in the URL.

I think this is fixed


Creating app for static app on asp

Resolves #22

Not happy at-all about the classic asp page that provides msal configuration from asp-service settings, but merging in as a working MVP.


Hugo server confused by copying and pasting directories in content

Small inconvenience,
When I move a dir between two subdirs under content (using cut and paste), hugo server generates html for the moved subdir twice (both in the new and old location). Restarting hugo server fixes the problem.
Thanks,

What version? If not the last one, you should test it.

Hugo Static Site Generator v0.46/extended darwin/amd64 BuildDate: unknown

You should try 0.47.

Thanks,
I tried: Hugo Static Site Generator v0.47/extended darwin/amd64 BuildDate: unknown
I am still seeing the same behaviour.
In case it is helpful, am using this theme https://learn.netlify.com/en/

it works with the dirs/subdirs' index.md files whether you copy or create your own content.. but I agree it defeats the purpose.

Not a major issue. I am just restarting hugo server if I need to copy-paste. Thanks,


Template breaking bug

Today's update inclues the rows
START Super hosts.deny Block List # DO NOT EDIT
%%content%%
END Super hosts.deny Block List # DO NOT EDIT
at the beginning of the list, breaking the entire hosts.deny file, blocking further ssh access.
Second breaking-bug in a few weeks, looks like this one is not ready for production servers...

@unbranched apologies we are building a new deployment system due to size issues. I have manually fixed commented out that line of superhosts.deny for now until @funilrys can fix the deployment script.

@unbranched New version distributed without the issue.
Thanks again and my apologies - again - for the noise.


Don't skip empty arguments in build commands

This is more of a question rather than a real PR. ocsigenserver build command contains an empty string argument which is important and fails because of this.
Why is this useful ?

This is important because of the (admittedly somewhat hacky) way opam-nix handles optional stuff in opam (e.g. "some-build-command" "--do-test" {with-test} or something). It "transpiles" it to a shell command like _ "some-build-command" "$(if [[ $opam__with_test == true ]]; then echo "--do-test"; fi)"
As you can see, it would produce an empty argument if with-test is not enabled, hence we filter out those arguments.

Thanks for the answer! I'd think an array based calling convention wouldn't be more complex than the _ solution. Though I should try.

Continued in https://github.com/tweag/opam-nix/pull/78


Drag gesture doesn't follow the movement

Hi,
great project to reproduce Android bottom sheets.
It would be great to have a drag gesture that follow the movement, not just a toggle up/down.
Best.

Yep, this is something that I have in mind but I need to find time to implement it 😄

hello, any chance to implement this enhancement anytime soon :D


Small typos.

Hello (again)
(sorry for the previous pull request, I messed up between the different organizations I'm part of on Github)
So, I'm really excited about starting the course and while going through the first session, if I understood right, I think these are two typos.
I corrected them here. Hope this helps.
Have a nice day and looking forward to the next steps.

Much appreciated! Thank you!


services/horizon/ingest: remove the force flag on reingestion cmds

What problem does your feature solve?
the force flag is incompatible with the new flushed data-flow of ingestion where we batch multiple ledgers in a single transaction, done in prior #5099
What would you like to see?
removal of force flag to avoid unintended mis-use
What alternatives are there?

Actually, we can close this issue. The force flag is only incompatible when you have parallel workers and we already check for that:
https://github.com/stellar/go/blob/master/services/horizon/cmd/db.go#L398-L400


adopt the new V5 token format

Hi Ryan,
Can you please review the change adopting the new v5 token format.
Did not handle the expiration so 8 minutes is always the token's timeout limit.
Please pay attention that StandardCharsets added requires Java minimum 1.7. Hope it is ok. Couldn't find the Java versioned used for Conjur V5.
Thanks

@nahumcohen I don't see any new commits since your latest comments, where can I find these changes?

I reverted the test and add the test prefix.
Now the tests passes.


Add PermanentDeleteChecker to check if messages will be deleted permanently

It's surprisingly complex to find out whether deleting a message in the app will permanently delete this message, i.e. delete the local copy and the server copy (if available).
This is required functionality for #7707.

I'm not quite happy with this approach. Having to perform disk I/O to be able to display a confirmation dialog (#7707) feels wrong. I think we should change the message (list) loading code to include the information necessary to answer the question whether a delete operation will permanently delete the message.
Closing this PR. I will open new PRs with the useful refactorings from this PR.

@cketti Have new PRs been opened for the required refactorings finally?
If the code provided the information to the email list for where each email is stored would not only allow for the delete confirmation to be implemented for the trash specifically, but it could allow for the addition of folder labels within the email list. For example, if you add the "Junk" folder to the unified inbox (which is useful when your email provider has a crappy, over-agressive junk filter), it is useful to specify that this was flagged as junk right from the email list.


FLOE-505: Make floeproject.org site responsive

This updates the floeproject.org site to have a responsive layout based on Foundation 6's flexbox-based grid system.
JIRA at https://issues.fluidproject.org/browse/FLOE-502

Do you think if it makes sense to place the Foundation library in the root lib/ directory instead of css/lib/ directory.
It would be helpful to include a README in lib/foundation to specify which build it is. Is it a complete or essential download? If it's a custom build, what components are included.

Videos on prefsEditors.html and security.html pages are in fixed width and height. Can we make them responsive too? This article might help: https://css-tricks.com/NetMag/FluidWidthVideo/Article-FluidWidthVideo.php

Good idea on both, done.

Merged at 5c7a712f4c14ad40a0453a245ad058d2a7b3824b


Allow configuring default location for workspaces

See original issue on GitLab
In GitLab by [Gitlab user @TheRealMichaelCatanzaro] on Feb 5, 2018, 16:53
It would be nice to allow configuring a default location for workspaces. For instance, I always want to create all my workspaces under ~/Projects. Instead of having to type this:
bst workspace open apps/libgnome-games-support.bst ~/Projects/libgnome-games-support

It would be nice, after setting some configuration option, to be able to just type this:
bst workspace open apps/libgnome-games-support.bst libgnome-games-support

Update by [Gitlab user @toscalix]: this proposal sent to the mailing list covers this enhancement.

In GitLab by [Gitlab user @TheRealMichaelCatanzaro] on Feb 5, 2018, 16:54
changed the description

In GitLab by [Gitlab user @sstriker] on Apr 4, 2018, 12:11
I would also like this configuration to be able to support a project relative path.

In GitLab by [Gitlab user @valentindavid] on Apr 18, 2018, 13:31
mentioned in merge request !420

In GitLab by [Gitlab user @tristanvb] on Apr 19, 2018, 05:09
I think this needs a lot more design before landing a feature.
Last night [Gitlab user @cs]-shadow and I briefly discussed #222, which should at least involve some semantic for project relative workspaces, this might mean some user state caching in ~/.cache/buildstream/... somewhere, so one consideration is; does this have to be explicit on the command line when opening a workspace ? I think yes because when one opens a project relative workspace, and then moves the project to a new directory but not the workspace, an error message telling them they screwed up makes more sense if relative workspace opening had to be explicit.
That is one consideration which may not directly effect this new user facing option, but should be taken into consideration.
I'll go a bit further, [Gitlab user @TheRealMichaelCatanzaro] asks specifically for:
bst workspace open apps/libgnome-games-support.bst libgnome-games-support

Which basically means to my mind, if a relative path is given as the <DIRECTORY> argument, it is taken to mean relative to the workspace directory, which makes some sense in [Gitlab user @valentindavid]'s patch on !420, but I would take this a step further.
If we have a default workspace directory, which defaults to the cwd, then I would rather make the <DIRECTORY> argument optional, such that an invocation of:
bst workspace open apps/libgnome-games-support.bst

Results in a workspace being opened in the directory: ${workspacedir}/libgnome-games-support by default; this is already easily achievable using the Element._normal_name attribute we use to generate logfile names and build directories.
Finally, making the <DIRECTORY> argument optional may make it easier to address #362, such that we could only support opening multiple workspaces at once if we dont specify <DIRECTORY> targets, and allow:
bst workspace open --multiple element1.bst element2.bst [...]

And they would open in the automatically derived locations in the workspace directory.

In GitLab by [Gitlab user @TheRealMichaelCatanzaro] on Apr 19, 2018, 05:28

If we have a default workspace directory, which defaults to the cwd, then I would rather make the <DIRECTORY> argument optional

Yes, that's much better since it requires even less typing.

In GitLab by [Gitlab user @cs-shadow] on Apr 19, 2018, 09:26
I also agree that making <DIRECTORY> will be a good UX improvement as most of the times, my workspaces have the same name as the element anyway. Naturally, there is a possibility that the directory with the same name as Element._normal_name might already exist, in which case I think we have at least these two options:

Error out with some helpful error message
Start appending numbers to the end of directory names (element-name-1, element-name-2) and tell user clearly what happened.

In GitLab by [Gitlab user @valentindavid] on Apr 19, 2018, 16:15
What should be the behavior for:
bst --directory /some/absolute/project/path workspace open element.bst relative/path

Should it be relative to the project? Or to the current directory?

In GitLab by [Gitlab user @tristanvb] on Apr 19, 2018, 16:52
[Gitlab user @valentindavid]:

Should it be relative to the project? Or to the current directory?

My intuition tells me I would expect that if I had "." as the default workspace directory, then the default workspace directory should be relative to $CWD, not the project directory.
The same would be true without specifying a target directory:
bst --directory /some/absolute/project/path workspace open element.bst

In GitLab by [Gitlab user @tristanvb] on Apr 19, 2018, 16:54
[Gitlab user @cs]-shadow:

Naturally, there is a possibility that the directory with the same name as Element._normal_name might already exist, in which case I think we have at least these two options:

Error out with some helpful error message

Yes, error out if it exists, that matches the current behavior.
However
I don't think we currently print anything very informative about where the workspace has been opened yet, and I think we should make sure that with this addition we start to.

In GitLab by [Gitlab user @tristanvb] on Apr 19, 2018, 16:58
One last thing unrelated to the above comments, as it looks like we're jumping full steam ahead into implementation...

What happens with opening multiple workspaces with a single bst open command ?

Even if multiple workspaces is not handled in this patch, it's on the menu, so [Gitlab user @valentindavid] and [Gitlab user @cs]-shadow who are working on the closely related features, should sort this detail out between them and propose a solution, before submitting more patches, I think.
Is it simply unsupported to open multiple workspaces at once while also specifying exact <DIRECTORY> locations for each workspace ? I could live with this option.

There is still the greater problem of how is the path recorded in workspaces.yml

If there is a default checkout directory, it makes no sense at all to record a project relative path to the workspace in workspaces.yml
As [Gitlab user @sstriker] mentions in https://gitlab.com/BuildStream/buildstream/issues/229#note_66577386 above, it is also desirable to support a project relative path

How do we reconcile all of these desires into a sane interface, what will it look like ?

In GitLab by [Gitlab user @valentindavid] on Apr 20, 2018, 13:33
[Gitlab user @tristanvb]:

My intuition tells me I would expect that if I had "." as the default workspace directory, then the default workspace directory should be relative to $CWD, not the project directory.

How would you specify in the configuration a project relative path from the default workspace directory?

In GitLab by [Gitlab user @valentindavid] on Apr 23, 2018, 10:12
Sorry, my sentence did not make much sense. So I rephrase.
In the configuration, how would one specify workspacedir path relative from the project directory (and not from the current working directory)?

In GitLab by [Gitlab user @tristanvb] on Apr 27, 2018, 07:44
Circling back here...
[Gitlab user @sstriker] says:

I would also like this configuration to be able to support a project relative path.

I failed to find the link for that last time, but what I take this to mean is already part of an enhancement issue outlined in #191.
As far as I can see, there are a lot of desired features here which are a bit cross purposes.
Any proposals or patches for this should consider the full picture before designing new CLI semantics which cannot be reversed.
If anyone is going to propose an approach for this, they should take into account:

#191 Support for project relative workspace paths
Ability to open workspaces without specifying a directory, I personally feel that a workspace directory configuration should really come with this

This should consider #362 and how semantics would work for multiple workspace commands

In GitLab by [Gitlab user @valentindavid] on May 1, 2018, 18:49
mentioned in merge request !444

In GitLab by [Gitlab user @LaurenceUrhegyi] on Jun 1, 2018, 14:55
marked this issue as related to #191

In GitLab by [Gitlab user @LaurenceUrhegyi] on Jun 1, 2018, 14:56
marked this issue as related to #222

In GitLab by [Gitlab user @LaurenceUrhegyi] on Jun 1, 2018, 14:56
marked this issue as related to #222

In GitLab by [Gitlab user @LaurenceUrhegyi] on Jun 1, 2018, 14:56
marked this issue as related to #191

In GitLab by [Gitlab user @LaurenceUrhegyi] on Jun 1, 2018, 14:56
removed the relation with #222

In GitLab by [Gitlab user @LaurenceUrhegyi] on Jun 1, 2018, 14:56
removed the relation with #191

In GitLab by [Gitlab user @valentindavid] on Jun 7, 2018, 15:58
mentioned in commit 9dd928dc7ad033b475ce6a2afd66aef71d5ea8ac

In GitLab by [Gitlab user @toscalix] on Aug 28, 2018, 11:41
changed the description

In GitLab by [Gitlab user @toscalix] on Aug 28, 2018, 11:41
[Gitlab user @willsalmon] sent this proposal to the mailing list that covers this enhancement.

In GitLab by [Gitlab user @toscalix] on Aug 28, 2018, 11:52
marked this issue as related to #362

In GitLab by [Gitlab user @tpollard] on Sep 21, 2018, 12:20
This was issue was part of the summary email for Workspace DX here: https://mail.gnome.org/archives/buildstream-list/2018-September/msg00036.html

In GitLab by [Gitlab user @willsalmon] on Oct 3, 2018, 15:38
I am closing this issue as it has become a Discussion Issue and the implementation for this has now been agreed in the ML and #695 now covers the implementation of this Issue.

In GitLab by [Gitlab user @willsalmon] on Oct 3, 2018, 15:38
closed

In GitLab by [Gitlab user @toscalix] on Oct 3, 2018, 16:25
marked this issue as related to #695


Rewrite frontend

Changes:

Better UI (new layout)
Support dark & light themes
Drop possibility of serving whole application under 404 routes. Support browsing only through search uri param, for instance:domain.com/#/releases/org/panda-lang

Extend configuration possibilities
Use Vue 3.x instead of Vue 2.x
Use Windicss instead of Tailwindcss
Move to Vite
Add possibility to use custom frontend implementation

UI concept:

UI concept v1

Looks good despite fact that this is almost 1:1 copy of https://vercel.com/ dashboard 😁

Atm it's a mix of Chakra UI, Vercel dashboard and Fluent Dark UI + some old pins from hub project. I kinda like it, because such a design does not really require styling, especially with windicss. We're also still limited to a small number of ported libraries for Vue 3 :/ I'd be glad if you or community could come up with a fancy UI proposal, because I'm focused on preventing regression over the 2.x rather than UI design. We need to rewrite whole frontend in a decent amount of time to catch up 3.0 schedule.

I might take a look at it at my free time (in 1-2 weeks?) and eventually I will contact you via email or here however I can't promise anything 🤙


gowall: init at 0.1.5

Description of changes

Tool to convert a Wallpaper's color scheme / palette https://github.com/Achno/gowall
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thanks for the quick reviews! I've added autocompletions to the output

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1886


Prune large AppMaps using the CLI

Closes https://github.com/getappmap/appmap-intellij-plugin/issues/244
This is best tested with a project containing large and giant AppMaps.

Executes the AppMap CLI to purge large AppMaps
Always adds the "stats" property (loaded via AppMap CLI) to the JSON passed to the AppMap webview
Adds tests to test the CLI with the prune and stats commands

:tada: This PR is included in version 0.33.0 :tada:
The release is available on:

v0.33.0
GitHub release

Your semantic-release bot :package::rocket:


Look's like Battery Level Widget is not updated when removing charge cable

Version 2v05, removed all apps and tried with the latest version.
Bootloader was 9 and is now 10
Cable is removed but

or

or

Let me know if you need more details or tests.

Ahh - you mean because the battery widget resizes and things move around, and we now don't clear the whole top and bottom row because it interferes with the analog watch face, part of the widgets in the previous position gets left behind?
I think this'll require a change in Espruino firmware itself :( I guess the simple solution is just to move to erasing the entire top/bottom row if there were any widgets there. It'd make the code simpler anyway.

This is my workaround: just do a reset with BTN3 and everything is fine

In some watch faces (the ones which do g.clear() when the LCD is turned on) it'll clear up pretty quick.
We could just modify the bootloader to overwrite Bangle.drawWidgets with the older version


Nidoran problems

How to make pokepast recognize it is Nidoran male or female?
Cause when i copypaste the showdown importable with a Nidoran-M, it didn't recognize it.

It'll be a few hours before I'm able to push this to the live site, sorry.

thx for answering ^^


vq-wav2vec RoBERTa extract all features or just final layer?

❓ Questions and Help
What is your question?
To get the results achieved in the vq-wav2vec paper were the features extracted from all layers of the RoBERTa model or just the final layer i.e. was return_all_hidden set to True or False? roberta.extract_features(tokens, return_all_hiddens=True)
Many thanks

@alexeib

we only use features from the final layer


Contract static method was missing DelegatesTo

https://github.com/spring-cloud/spring-cloud-contract/commit/f09b96a524f9dff2fe47d8864d184c1055368f6f


performance Tuning for Queries⚙

IN This PR We present performance Tuning for Queries⚙:
Below are some of my implementations as well as going over the project requirements 🤝 .
Requirements

use GitFlow 🌊.
Add to the schema.SQL file with the required content. ⛱

Alter the owners table and add an Email column

Add to the data.SQL file with the required content. 🛰

Insert Data into visits and owners Tables.

Add to the query.SQL file with the required content. 🧭

Write queries to answer the following questions :
‣Show execution time before any changes

‣Show the execution time of Querry 1 before performance Tuning.

‣Show the execution time of Querry 1 After performance Tuning.

‣Show the execution time of Querry 2 before performance Tuning.

‣Show the execution time of Querry 2 After performance Tuning.

‣Show the execution time of Querry 3 before performance Tuning.

‣Show the execution time of Querry 3 After performance Tuning.

Achievements

use GitFlow 🌊 .✅
Add to the schema.SQL file with the required content. ⛱✅
Add to the data.SQL file with the required content. 🛰✅
Add to the query.SQL file with the required content. 🧭✅

Conclusion
We are looking forward to hearing 👂  from you Our CR in terms of what can be better implemented 👨💻  for the project thankyou!. And we look forward to hearing from you soon.  🙇

Thank you for the great review.👍 @Omar-Muhamad


[typescript] updating to 2.6 and latest tslint

Doing the update to 2.7 will take some time since it points out more errors. I'll be doing a release of this soon and go over all the other PRs.

@buzinas can we make travis use npm > 5.0? it would be useful to have the same package-lock.json

@buzinas can we make travis use npm > 5.0? it would be useful to have the same package-lock.json

How about switching to yarn?

I have conflicts about yarn. I tried it since I really wanted to "flat" install so that we don't get repeated packages but somehow it didn't work. I suppose we could try it. Is that what tslint is using? Lets do it when we update everything to be compatible with typescript 2.7. Sorry I haven't had time to work on this.

IT PASSED!!!


[Build/CI] Set FETCHCONTENT_BASE_DIR to one location for better caching

We use CMake's FetchContent for managing dependencies that are compiled as part of vLLM's build process, e.g. CUTLASS, and vllm-flash-attn. FetchContent will by default place dependencies at CMAKE_BINARY_DIR/_deps. See documentation here.
When building vllm with python setup.py build_ext --inplace, this is OK, as CMAKE_BINARY_DIR will always be vllm/build/temp.linux-x86_64-cpython-310
However most people use pip install -e ., in which case CMAKE_BINARY_DIR will be a path like /tmp/tmp9cnuhpg3.build-temp. This path varies, which seems to be causing sccache misses and excessive compilation.
This PR sets FETCH_CONTENT_BASE_DIR in CMakeLists.txt to vllm/.deps to avoid these misses

If possible could you also check the flash attention source path? I recall it has the simile issue.

Just double-checked, and we should be good there. The  vllm-flash-attn src is under .deps as well


Kruize recommendations don't match with the values in grafana dashboard

Description
Kruize recommendations don't match with the values in grafana dashboard. Below are the values
kruize recommendations API => graphana dashboard values
{
"application_name": "kruize",
"resources": {
"requests": {
"memory": "71.0MB", => 74.4 MB
"cpu": 0.3 => 0.5
},
"limits": {
"memory": "121.0MB", => 126.8 MB
"cpu": 0.3 => 1.0
}
}
},

This is consistently reproducible for me. One more data point is that the kruize logs and API both match each other ... so not sure why the grafana query is different.


feat: update env validation module

Changes Made:

Updated the project to use the newer dotenvx package.

Modified package.json scripts to use dotenvx.

Simplified the env validation logic.

Attached a screenshot showing how the output looks like

Thanks, but I'm going to stay with dotenv and dotenv-expand for now.
I also prefer the current validation as is.


include html in Express render callback

http://expressjs.com/en/api.html#res.render

./travish.sh works for me locally.
@marudor looks like something's up with the Travis config https://travis-ci.org/flowtype/flow-typed/builds/154836301

Not sure what's going on with travis, but this looks good to me! I have one nit, which I mentioned inline, but happy to merge even without it being fixed.

Good catch on the callback being called sometimes with only one argument!
I think you might need to update the test too, though

Looks good! Thanks for bearing with me and thanks for your contribution!

btw, what's your current philosophy on aligning with definitelytyped? Seems a waste to write all these types twice.
I've heard Facebook wants a flow2typescript rather than typescript2flow because Flow can express more. Seems like it would be easier to make a subset work in a superset than reduce that extra expressivity, but I don't know much of the details here.
Before either one, could the two repos be made to support the same test files? That's a lot of the work right there, figuring out what the spec is for these JS libs.


Upgrade com.uber.nullaway:nullaway 0.8.0 -> 0.9.0

This PR contains the following updates:

Package
Update
Change

com.uber.nullaway:nullaway
minor
0.8.0 -> 0.9.0

Release Notes

uber/NullAway
v0.9.0
Compare Source

IMPORTANT: Error Prone minimum version moved to 2.4.0 (#447)

This allows compatibility with Error Prone 2.5.1 by
moving to updated APIs.
Remove Checker Framework shadow config from nullaway module (#449)

@Contract annotations are now checked (#312) (#428) (#450)
Add support for @RequiresNonnull/@EnsuresNonnull annotations (#423)
[Fix] Handle WideningConversionNode in Map key specifiers (#415)
[Fix] Try to handle lombok.Builder without crashing. (#414)
[Fix] Ignore library models return nullability on first-party code (#446)
Update to Checker Dataflow dependency to 3.6.0 (#416)
Library Models:

Add library model for TextView.getLayout() (#418)
Add library model for Service.onStartCommand (#419)
Models for common Spring/Spark/Apache utility classes (#436)
Add support for jakarta.inject-api (#439)

Build / CI tooling for NullAway itself:

Update to Gradle 6.6.1 (#420)
Switch CI to GitHub Actions (#440) (#442) (#450)

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade NullAway 0.8.0 -> 0.9.0

See:
- https://github.com/uber/NullAway/blob/master/CHANGELOG.md
- https://github.com/uber/NullAway/compare/v0.8.0...v0.9.0


cmake: Print out the versions of ninja, cmake, and clang that we are

A patch to print the ninja, cmark, and clang/clang++ paths in the cmake config for the build system. This patch would be useful for reproducing which tools were used in a build, since I don't think the version gets printed in the build logs right now.
On my system:
+ /Applications/Xcode.app/Contents/Developer/usr/local/bin/cmake --build /Users/erg/src2/build/Ninja-ReleaseAssert/swift-macosx-x86_64 -- -j8 all swift-test-stdlib-macosx-x86_64 swift-benchmark-macosx-x86_64
[0/1] Re-running CMake...
-- Finding version for: /usr/local/bin/ninja
-- Found version: 1.7.1
--
-- Finding version for: cmark
-- Found version: cmark 0.26.1 - CommonMark converter (C) 2014-2016 John MacFarlane
--
-- Finding version for: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
-- Found version: Apple LLVM version 8.1.0 (clang-802.0.17) Target: x86_64-apple-darwin16.3.0 Thread model: posix InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
--
-- Finding version for: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++
-- Found version: Apple LLVM version 8.1.0 (clang-802.0.17) Target: x86_64-apple-darwin16.3.0 Thread model: posix InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
--

@llvm-beanz @jrose-apple
Is there a better way to do this, or are we doing this already?

@swift-ci Please smoke test

Seems fine to me.

I would actually suggest printing this via the build-script not CMake. CMake doesn't necessarily re-run with every build, and I think the point of having this logged is that it would be logged in every build.

Good suggestion, I'll move it to build-script. In practice, I think build-script reruns cmake every time for Swift anyway...
It looks like we only use the cmark library and not the cmark binary, which is at:
find_version("${SWIFT_PATH_TO_CMARK_BUILD}/src/cmark" "--version")

I think it's much simpler to have the version checks in cmake than in python and bash. python builds ninja, and bash builds cmark, so I end up having to write this code 2-3 times, and I wanted to move away from build-script anyway.
I really only care if it runs on a clean build. It shouldn't affect most users to know which version of ninja is running.

@swift-ci Please smoke test

@swift-ci Please smoke test

I really only care if it runs on a clean build. It shouldn't affect most users to know which version of ninja is running.

I disagree with this logic 100%. You think it shouldn't impact most users, but I'm the person who gets contacted whenever things go wonky in CMake or Ninja, and I really want to see the versions in the log. If you don't want to print it in the build-script, that's fine, but I'll be showing up in your doorway whenever there is an issue that causes me to want to know the versions :-).

@swift-ci Please smoke test

@swift-ci Please smoke test


Multiple tables in a single database file.

This probably already works. Write a test to verify.

Indeed it works. Just specify the same database file.


Best practices for read only QHOME

Questionnaire removed as query unrelated to specific version of PyQ or a specific bug in the code.
Context:
The following issue was raised via internal channels and is a high priority item for the client.
Query:
When we install the package to a conda environment, it creates a q/ directory within that environment. Afterwards, we need to copy files from our QHOME to that q/ directory for pyq to work. Can the conda package add all the necessary files during installation, so we won’t need to copy additional files afterwards?
Related question, I’ve generally had one QHOME, a read-only central location, and I’ve not found a good way to install pyq without building in pyq to QHOME. Is there a clean way to install pyq that doesn’t involve adding files to QHOME?
In my case, the setup.py wants to put files into QHOME, but some other user owns it, and it is read only to me.
We have a central QHOME installation, and if I put pyq in there, it would mean that all users have to settle on using the same pyq (and the same python too, as pyq-config.q hardcodes the libpython path). Is this avoidable?
I just today experimented with this as my pyq-config.q and it seems to work… but I’m not sure if it’s a good idea in the long term. This does away with the hardcoded python path at least…
Some of this I lifted from what setup.py does to create the hard-coded pyq-config.q.
$ cat pyq-config.q

\d .pyq

python_dll:raze[system "python -c 'import sys;from distutils import sysconfig; print(\"{}/libpython{}.{}m.so\".format(sysconfig.get_config_var(\"LIBDIR\"), *sys.version_info[:2]))'"],"\000";

pyq_executable:raze[system "which pyq"];

In order to run pyq in a way that was decoupled from the q QHOME installatio, I have had to make code changes to python.q (\l p.k from an absolute path instead of relying on the limited flexibility of how to influence where \l looks in absence of an absolute path).
I also had to make some changes to pyq.c to influence where it finds python.q. This line is what I had to change  https://github.com/KxSystems/pyq/blob/master/src/pyq.c#L357.
Doing it this way (making some code changes) allows me to have different versions of pyq but only 1 QHOME (with no built-in pyq.so, python.q, pyq-*.q, etc.). However, it makes upgrading somewhat painful as I would have to go and make all these changes to each version (I have a makefile doing some kludgy things with sed to change some paths when building pyq).
I’d love to know if there is an accepted and cleaner way to handle the situation where users don’t have access to change QHOME, but still want to be able to install pyq into their custom conda/venv environments (with the assumption that they can’t change the Q/kdb QHOME deployment).

We have a central QHOME installation, and if I put pyq in there, it would mean that all users have to settle on using the same pyq (and the same python too, as pyq-config.q hardcodes the libpython path). Is this avoidable?

Did you consider using symlinks from $QHOME into $VIRTUAL_ENV/q to avoid need to copying anything around?  We considered that $QHOME in $VIRTUAL_ENV/q is the best option to avoid conflicts between python and kdb versions. i.e each virtual environment is kind of hard-coded combination of Python and kdb+ versions.
Will leave to @abalkin to answer other questions.


replaceReducer() does nothing.

When replaceReducer(someReducerFunction) is run, nothing is set in the mock store. Also, mock stores don't actually have a reducer to begin with.

I'm throwing an error when replaceReducer is called on my TypeScript fork, @jedmao/redux-mock-store.

Why is there a refusal to allow this library to use a reducer as is?

Any progress on that?

all replaceReducer does is throw an error if you do not pass a function... https://github.com/reduxjs/redux-mock-store/blob/master/src/index.js#L66 that is it! this is a little confusing. one might expect it to do something. might be better to just remove it

You can pass a function to the mockStore instead of object. It will receive all the dispatched actions, thus you can dynamically return new state from the dispatched actions and treat it as a reducer. Hope this will help.

🤔 ...i found it useful to recreate a mini-redux like this.
    const initialState = { slice: [{}] }
    let currentState = initialState;

    const mockStore = configureStore([middleware])(actions => {
      const action = actions[actions.length - 1];
      currentState = { ...currentState, slice: sliceReducer(currentState.slice, action) };
      return currentState;
    });


Nodegit doesnt work on LinuxMint (Ubuntu, I guess)

Getting this error when running nodegit on LinuxMint (equal to Ubuntu i guess)
Error: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /usr/lib/node_modules/nodeschool-admin/node_modules/nodegit/build/Release/nodegit.node)

Please read the README this is discussed under installing.

Thank you for explaining, opened a pull request so future users have less problems.


Problem with the integration tests for the integration accounts

Describe the bug
The integration tests for the integration accounts were not added to the integration test project, which made them unavailable for testing.
To Reproduce
Add the integration tests for the integration accounts to the integration test project.
Expected behavior
Tests work.
Additional context
PR build log where the tests were activated: https://dev.azure.com/codit/Arcus/_build/results?buildId=55758&view=logs&j=e595d565-167d-56a5-1759-bf5fff8f3218&t=b8c9c00a-6085-5dc3-1e59-52b0164a1841

Ah, nm, is not correct.


[dizquetv] Migrate to common v3

Description of the change
Upgrades dizquetv chart to the latest common library version.

Benefits

Possible drawbacks

Applicable issues

fixes #

Additional information

Checklist

[X] Chart version bumped in Chart.yaml according to semver.
[X] Title of the PR starts with chart name (e.g. [home-assistant])
[X] Variables are documented in the README.md (this can be done with using our helm-docs wrapper ./hack/gen-helm-docs.sh stable <chart>)

@bjw-s  It looks like this PR is failing the auto-generate docs.

Yeah I noticed 😦 looks like it's because branches don't have those secrets :/ I'll work on a fix tomorrow, will probably move it to the main branch as a pre-release step after all :(

Going to merge this because it looks fine otherwise :)


New user accounts need to be approved before they can access the site

We can do this by starting them out is "inactive" and showing a note that tells them they need to be approved first.

https://docs.djangoproject.com/en/4.0/topics/auth/default/#the-login-required-decorator says:

The login_required decorator does NOT check the is_active flag on a user, but the default AUTHENTICATION_BACKENDS reject inactive users.

That's OK, that's what I want here I think. I still want inactive users to be able to login so they can see they page saying they have not been activated yet!

No that doesn't work, because I use from django.contrib.auth import login as django_login which checks to see if they are active or not.

https://docs.djangoproject.com/en/4.0/ref/contrib/auth/#django.contrib.auth.models.User.is_active says:

This doesn't necessarily control whether or not the user can log in. Authentication backends aren't required to check for the is_active flag but the default backend (ModelBackend) and the RemoteUserBackend do. You can use AllowAllUsersModelBackend or AllowAllUsersRemoteUserBackend if you want to allow inactive users to login