chore: refactor osmosis swapper in preparation for exchange client

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #4888   👈

This comment was auto-generated by Graphite.


Fix bad equality check in security scheme template

Thanks much, for spotting and taking care of the issues... it saved a lot of time on our end as many of our automated tests were failing !!!


Fix typo stdin/stdout

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:akimd/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@akimd: Can you please change the base branch of this PR to master?

Also, can you please sign the commit, as explained in https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work ?

opened https://github.com/moby/moby/pull/33085 against master and with the suggestion @aaronlehmann made


[BUG] circular dependency error of vite

Bug Description
Sometimes, terminal shows the vite error for circular dependency
Error: [vite] The dependency module is not yet fully initialized due to circular dependency. This is a bug in Vite SSR
    at ssrImport (file:///Users/j_igarashi/Documents/git/UNDP-Data/geohub/node_modules/.pnpm/vite@5.4.11_@types+node@22.10.1_sass@1.81.0/node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:52922:19)
    at eval (/Users/j_igarashi/Documents/git/UNDP-Data/geohub/packages/svelte-undp-components/dist/components/ui/Breadcrumbs.svelte:4:37)
    at async instantiateModule (file:///Users/j_igarashi/Documents/git/UNDP-Data/geohub/node_modules/.pnpm/vite@5.4.11_@types+node@22.10.1_sass@1.81.0/node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:52972:5)

but this is only problem in local, it works without any issues in production
Bug Reproduction

run pnpm dev
run make build in different terminal
error of circular dependency is shown sometimes

Bug Impact
No response
Bug Screenshots
No response
Bug References
No response
Bug System Information

OS: [e.g. Windows 10]
Browser: [e.g. Google Chrome, Firefox]

let me close it for now


Optionally enforce algorithm to pick the default device

When using some weird devices or debugging OpenCL stacks & compilers, it does not make sense to run the application on anything else.
If I correctly understand find_default_device()algorithm in https://github.com/boostorg/compute/blob/master/include/boost/compute/system.hpp#L210 on using the very handyBOOST_COMPUTE_DEFAULT_ variables, when some criteria cannot be fulfilled we fall-back on returning the first GPU found, etc.
So I'd like to add another variable environment for example (BOOST_COMPUTE_DEFAULT_ENFORCE? Bike-sheding welcome! :-) ) to change the selection algorithm to throw when a BOOST_COMPUTE_DEFAULT_ variable is set but the criteria cannot be fulfilled.
Any comment?
I can write a PR.

How throwing an exception would be helpful in such situations? I mean if you forget to set environment  variables so find_default_device() picks device you want to use, you can always forget about adding `BOOST_COMPUTE_DEFAULT_ENFORCE.

I mean, if it's not about forgetting to set environment variables, how otherwise would it be possible there is no device you want to use?

@keryell I think I understand what you're getting at. If you could submit a PR with the proposal that would be great! Thanks!

I'm waiting for that PR ;)

Yes I know. :-(
But I am quite busy with a lot of deadlines. Such as the Khronos face-to-face meeting next week.
Perhaps see you there?

Yes I know. :-( But I am quite busy with a lot of deadlines.

Sure :) I understand. Just remember it's assigned to you.

Such as the Khronos face-to-face meeting next week. Perhaps see you there?

Maybe you'll hear me :), but it seems I won't be there in person.

Do you guys mean something like https://github.com/ddemidov/compute/commit/a7aa6cb564e3176d844c6fa4eb23cf448dcb502c?

Yes, I think so :) @keryell?

Implemented in https://github.com/boostorg/compute/issues/712.

Amazing!
@ddemidov you are motivating me to procrastinate... :-)


Regex added

Added Regex code instead of hardcoding it each year as discussed  here https://github.com/openstreetmap/iD/issues/9946

I think this should fix that


Implement sensor class for real time clock (RTC)

Add new class for real time clock. Product page: https://www.adafruit.com/product/3295

electrical switched the rtc


Use latest keystone-operator API

pkg/external has been moved to api/v1beta1 so adapt the cinder-operator to this new change.
The keystone change was https://github.com/openstack-k8s-operators/keystone-operator/pull/90

Need this PR to unblock the gate, because we can see how it fails on this earlier PR https://github.com/openstack-k8s-operators/cinder-operator/pull/20
To me it looks like tests are ignoring the pinned version.


fix: deprecation warning when not using uri for provider connection

Small fix to the deprecation warning when user chooses to use connection parameters in favour of uri.

Pull Request Test Coverage Report for Build a029784ee-PR-850

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 45.397%

Totals

Change from base Build e0468fe36:
0.004%

Covered Lines:
5582

Relevant Lines:
12296

💛  - Coveralls


Help needed installing mraa for intel galileo

Can someone tell me what are the prerequisites and steps needed to install latest mraa and upm on intel galileo with yocto image on it?
I could install it once 2 months ago with an old read me file on the repo which had clearer steps for installing.
things got changed and I can't remember how I did it so I tried as docs says in here

but I get error in command make that I must use c99 flag and here is the full error message I get on the terminal
https://pastebin.com/guDYxNua
I'm a total newbie so pardon me for any stupid step I made.

Your compiler is old so default C standard is also old. Add -DCMAKE_C_FLAGS="-std=gnu99" to your cmake line (make sure to wipe the build/ dir before hand).
I made a branch c99x with a probable fix and will probably merge something like that in next few days. Other option is just to compile latest stable afaik that still works.

Sounds like it. Thanks for your support

Closing as clarified.


Compare with quickcheck-state-machine?

Would it be possible to elaborate in README how this library compares to quickcheck-state-machine? I'm sorry if it's a dumb question, I don't know much about the field.

Apologies for the late reply! It's definitely not a dumb question and one that several people have already asked. We will add it to the documentation.


PowerToys Run encountered some problems

Microsoft PowerToys version
"0.37.0"
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
First issue:
Wake up pc from dormancy and popup shows " PowerToys Run encountered some problems".
Second issue:
PowerToys Run didn't start when I start the computer.

The bug report log was generated after restarting the PowerToys.

PowerToysReport_2021-05-04-09-32-32.zip
✔ Expected Behavior
First issue: No error, no popups.
Second Issue: PowerToys Run could be used normally.
❌ Actual Behavior
First issue:
When I woke up my pc from dormancy, two same pop-up showed that PowerToys Run encountered some problems with their forms blank.
After about half minute, forms disappeared with all PowerToys Process ended.
Second issue:
PowerToys Run didn't start although I've already set status "on" ( and PowerToys is running at startup ) .
Other Software
No response

It occurred again and again.

Hi @Frank-Ye7104
Are you still experiencing the issue with the latest version of PowerToys?
/needinfo

Hi @Frank-Ye7104 Are you still experiencing the issue with the latest version of PowerToys? /needinfo

Now PowerToys Run is working well.


Implement the max_fragment_length extension

This PR is for the issue #534

I think we should block this change on an integration test with a known good implementation of Maximum Fragment Length Negotiation.

Max Fragment Length test case has been added to the s2n_handshake_test_gnutls.py acceptance test.
I have manually confirmed successful TLS negotiation using Wireshark for the following cases:

S2N client (with mfl extension) & S2N server
GnuTls client (with recordsize extension) & S2N server


[BUG]ValueError: Redis failed to connect: Redis cannot be used as a vector database without RediSearch >=2.4Please head to https://redis.io/docs/stack/search/quick_start/to know more about installing the RediSearch module within Redis Stack

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
Using the below code for semantic cache
from langchain.globals import set_llm_cache
from langchain_openai import OpenAI
from langchain.cache import RedisSemanticCache
from langchain_huggingface import HuggingFaceEmbeddings
import time, os
from langchain_openai import AzureChatOpenAI
llm = AzureChatOpenAI(<my credentials>)
huggingface_embedding = HuggingFaceEmbeddings(model_name="all-MiniLM-L6-v2")
set_llm_cache(
    RedisSemanticCache(redis_url="redis://<IP_ADDRESS>:6379", embedding=huggingface_embedding)
)
question = "What is capital of Japan?"
res = llm.invoke(question)

both redis db and redis python client I installed.
redis-5.0.6
redis-cli 7.2.5
Still its getting the given error
[BUG]ValueError: Redis failed to connect: Redis cannot be used as a vector database without RediSearch >=2.4Please head to https://redis.io/docs/stack/search/quick_start/to know more about installing the RediSearch module within Redis Stack.

But the strange thing is, there is no 2.4 version available for the python client RediSearch in pypi
Error Message and Stack Trace (if applicable)
No response
Description
Using the below code for semantic cache
from langchain.globals import set_llm_cache
from langchain_openai import OpenAI
from langchain.cache import RedisSemanticCache
from langchain_huggingface import HuggingFaceEmbeddings
import time, os
from langchain_openai import AzureChatOpenAI
llm = AzureChatOpenAI(<my credentials>)
huggingface_embedding = HuggingFaceEmbeddings(model_name="all-MiniLM-L6-v2")
set_llm_cache(
    RedisSemanticCache(redis_url="redis://<IP_ADDRESS>:6379", embedding=huggingface_embedding)
)
question = "What is capital of Japan?"
res = llm.invoke(question)

both redis db and redis python client I installed.
redis-5.0.6
redis-cli 7.2.5
Still its getting the given error
[BUG]ValueError: Redis failed to connect: Redis cannot be used as a vector database without RediSearch >=2.4Please head to https://redis.io/docs/stack/search/quick_start/to know more about installing the RediSearch module within Redis Stack.

But the strange thing is, there is no 2.4 version available for the python client RediSearch in pypi
System Info
python 3.9
ubuntu machine
langchain==0.1.12
langchain-community==0.0.36
langchain-core==0.2.9

https://github.com/langchain-ai/langchain/issues/13611
some related issue, But is there any way to solve it without docker dependency?


Please add properties to customize text in wheel

please add more text properties like color, size to customize text in wheel
below pull request seems to have fixes to change text size if it can be reviewed and merged please
https://github.com/mmoamenn/LuckyWheel_Android/pull/27

bellow are the steps to customize text size:
1.add maven { url 'https://jitpack.io' } at settings.gradle
2.add implementation 'com.github.alirezaafkar:LuckyWheel_Android:0.5.0' at build.gradle in dependencies
3.go to layout.xml and create a LuckyWheel View
4.use app:text_size to set the text size


Add basic validation to enclosure function

/cc @akirk

Fixes Fatal errors if the enclosure meta does not match the core-format.

There is an array_filter and it also filters false.


Stat summary api output should filter out irrelevant rows

http://localhost:8084/api/tps-reports?resource_type=deploy&resource_name=web without a specified namespace will return all deployments, but only list stats for the named deploy. Instead, we should filter out resources that don't match the name query.
If a namespace=emojivoto parameter is supplied, the query does filter out the other deployments.
 I think we should reject the command you pasted as invalid. That's the approach that kubectl get takes, and I'd like for us to maintain as much consistency with them as possible:
$ kubectl get deploy/web --all-namespaces
error: a resource cannot be retrieved by name across all namespaces

This relates to #776, which describes some additional validation that I'd like to add for the stat command.


Q: What is the reasoning behind the naming of mapStateToProps?

I have used Redux for many projects, and I use React daily.  I was asked a great question today: "why call it mapStateToProps -- wouldn't that be easy to confuse with a React component's state?". Why not call it something else?
I was hoping someone would have thoughts. Thanks! :)

Did some digging through the issue archives and commit logs.  Looks like the argument name was changed from "select" to "mapStateToProps" roughly around August 7, 2015, in commit 3079d0045f8ced7c79db9b255172295d2294ae51, but I'm having trouble finding specific discussion around that.
Beyond that, given that Redux is explicitly a "state management library", and connect() is supposed to hook together your Redux store to your React components, the intent is hopefully clear.  Also, the word "state" is sorta overloaded contextually anyway in that it means "the current values / variables / data that make up your application", so the same point could be made in regards to React.Component.state as well.

Redux store has a getState method. mapStateToProps maps this state to some props that should be provided to the connected component.
Same thing for dispatch property and mapDispatchToProps.
The state name is overloaded but you can see that the naming is derived from redux terminology itself.


When finetuning, previous networks are kept fixed?

Hi, Simmon!
Thanks for your wonderful code!
But I have some questions now, please give me some advices.
When finetuning, such as use the UnFlowC experiment for first network and UnFlowCS for the second network when training UnFlowCSS, you said that only the final network is trained and any previous networks are kept fixed.
But I can't figure out how you make the previous networks fixed in code, are there any settings in code to make sure the previous networks are fixed?
Please give me some clues, thank you very much!!

These lines ensure that the previous network outputs are assumed to be static (and thus avoids feeding back gradients through these networks): https://github.com/simonmeister/UnFlow/blob/master/src/e2eflow/core/flownet.py#L51

Oh, I get it, thank you very much.
Sorry for my careless.
But in that way, if I don't just want to finetune the final network, I still want to finetune some layers in previous networks , I think things may be difficult.
Do you have any advices for that?
Thanks a lot.
Best wishes!

No problem! If you only want to add a few layers, you would need to insert the stop gradients directly before these layers in the flownet code, but it shouldn't be too hard.

But in fact I want to finetune the first layer in every networks to adapt my 1 channel input image.
In this case, using the stop gradients directly seems not very suitable.
I'm trying to find some ways to solve this problem, can you give me some advices to modify your codes?
By the way, if I turn the 1 channel images to 3 channels images by copying directly, does it make sense?
Sorry to bother you again, thank you very much.

Ah so i am unsure if what you want to do would work (from the learning side of things). Technically it would be easy to filter out variables by name if you collect the gradients manually and then update the variables by using apply_gradients.
However, if you modify previous layers without adapting the later layers, i think you would run into problems with the learning, as the later layers can't adapt to the changing inputs and can't make sense of your "improved" representations from earlier layers. I would either re-train from scratch, fine-tune end-to-end or you could maybe really try to just copy the channels first.


scripts/code.sh broken since 1.50.0

VSCode Version: 1.49 and 1.50
OS Version: opensuse Tumbleweed

Steps to Reproduce:

clone the vscode git repository, checkout any of the 1.49.* tags
run ./scripts/code.sh and verify that it works
check out either 1.50.0 or 1.50.1
run ./scripts/code.sh, which fails for me with:

$ ./scripts/code.sh
internal/modules/cjs/loader.js:834
  throw err;
  ^

Error: Cannot find module '/home/dan/packages/github.com/microsoft/vscode/build/lib/preLaunch.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:831:15)
    at Function.Module._load (internal/modules/cjs/loader.js:687:27)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
    at internal/main/run_main_module.js:17:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Note that the file /home/dan/packages/github.com/microsoft/vscode/build/lib/preLaunch.js does not exist, only its typescript source exists. So maybe a compilation step is missing there?

Does this issue occur when all extensions are disabled?: irrelevant

Indeed, running yarn install and yarn run compile before ./scripts/code.sh fixes the issue for me.

Yes, you need to build before trying to run VS Code.
For details see: https://github.com/microsoft/vscode/wiki/How-to-Contribute#prerequisites


List of other Godot MIT repos we could borrow code from with detals

https://github.com/securas/Daisy_Dangerous
Has

Ladders.
Water Shader.
Bullets.
Transistions.
Enemies.


Which keys should be used for github actions?

Hello,
I am a little bit confused by the read.me file. Should I add prod or staging supabase secrets to github actions secret section?

Hello,
I'm a bit confused too 😂
Actually ... it depends of your strategy (e2e on staging or production env) 🙃
I forked github ci from Remix indie stack (witch use a sqlite locally and a sqlite "containerized" on fly.io).
I should take a moment to rewrite the readme and the ci :/
For the moment, I put my staging database credentials on github secrets, it's just for cypress task.
In real situation, I guess I would still put staging secrets to run cypress on staging env before releasing to production.

I think of a step to add : checking if production database has been migrated before "deploy to prod" or adding a step to apply migration (i'm always cautious with steps like that).

Github action is new for me, so, I'm sorry if it's not usable out of the box


.cpgz zile

Hi there,
im currently using Zipper to zip 8 CSV file exports. For some reason when my code is live on the server and i download the ZIP i cant actually open it but on my local server i can.
Ive noticed sometimes when i try to open the zip file it extracts another file which looks like this with a weird extension on the end: ZIPFILE.zip.cpgz. Which cant be opened also.
This is my code.
public function zipCSV()
{

    $zipper = new Zipper;
    $files = glob(storage_path().'/downloads/all/*');
    $filepath = storage_path().'/downloads/zips/Backup - '.date("d-m-Y").'.zip';
    $zipper->make($filepath)->add($files)->close();

    return $filepath;

}

any ideas im pretty stumped?
thank you

I am having the same issue on my Ubuntu server, but not my Homestead vagrant box

Same to me. Some fix?


Support prometheus 2.3 read hints

Prometheus 2.3 supports ReadHints now to allow pre-aggregating the data queried from remote storage.
message Query {
  int64 start_timestamp_ms = 1;
  int64 end_timestamp_ms = 2;
  repeated prometheus.LabelMatcher matchers = 3;
  prometheus.ReadHints hints = 4;
}

message ReadHints {
  int64 step_ms = 1; // Query step size in milliseconds.
  string func = 2;   // String representation of surrounding function or aggregation.
}

step_ms gives an exact value for time granularity of aggregation
func is fuzzy, and is used to determine how the value should be aggregated (mean/ min/ max/ avg/ sum) and is more complicated

Added together, these two allow us to reduce the amount of data returned from elasticsearch, when querying for longer timeframes.
Just adding a marker issue here to keep track :)

Thanks for the suggestion.  Would definitely be something to include in a future release.


How to calculate the evaluation metrics in your paper？

Hello, I have successfully tested the model based on your modified code, but found that, the test results do not contain the evaluation metrics, can you please provide the calculation metrics in the code? Looking forward to your reply.

Hi @wjaycyf
I've just added eval.py


[2145] Review app Makefile targets

Context
Manage review apps via command line (and delete if necessary)
Changes proposed in this pull request
Amend targets to make them work with review apps
Guidance to review
run deploy-plan and destroy

 Delete old review apps


Follow reference mechanism

Environment

Nuget Package: JsonSchema.Net
Nuget Version: 3.2.1
OS: any
.Net Target: .net6

Can this library make doing something simpler?
There is not an easy way to follow reference other than implementing extension with simmilar implementation as internal "FindSubschema" method.
More so, decription of IRefResolvable contains:

Defines functionality required to resolve $ref and $recursiveRef keywords

but it doesn't provide the mechanism to resolve $ref keyword.
Describe alternatives you've considered
Changing access modifier of FindSubschema method to public, or better to create extension or public method with following definition:
public JsonSchema ResolveReference(JsonPointer path);

May I ask, why do you need to resolve a reference into a schema?  The system handles resolving references by itself.  (Also note that the next version will do this quite differently, and it's actually internalized more.)

I'm working on a conversion from xsd schema to json schema and vice versa.
We need to reproduce exactly the same xsd when doing round trip conversion. Some complex xsd schemas producing complex json schema with lot of references.  In some cases, when converting back to xsd we need to follow references to determine what was the original xsd structure.
Also I'm working on generating c# classes based on the input json schema. Ability to follow references comes handy here.
Could be that this feature is project specific, but to me it looks like it's not a bad idea to have this extension as part of the library it self.

That sounds like a neat project.  I'd like to mention it to the JSON Schema team, actually.  Also, what's the project (if it's public)?  I wouldn't mind giving it a mention on this project's readme.
There's already some code in OpenAPI.Net to do C# generation.  Maybe use that directly or as a reference.  They (soon to include me) are working on updating for Open API 3.1, which will likely use JsonSchema.Net for their validation engine.
As for your immediate need, I suggest that you serialize the schema to a JsonNode (or deserialize to JsonNode before going to JsonSchema) then just apply the pointer to that using the JsonPointer class.  I think the serializer is fast enough that the performance impact would be negligible.

@gregsdennis  It's an opensource project called Altinn used by public sector in Norway.
More you can find on the documentation here.
You're might most interested in datamodeling part were we've used your library. It's in this repo. You can explore more here.
Feel free to reference it in readme if you want.
cc @RonnyB71

@mirkoSekulic I've recently pushed v4.0-beta which actually removes IRefResolvable as it handles all of the registration stuff internally now (see full release notes on https://json-everything.net/json-schema.
I'm open to helping you get what you need, though.  There is a FindSubschema() method that I have as internal.  I was debating making it public, though.

@mirkoSekulic can you please take a look at ☝ (bundling) and see if that will solve your need?

Also, regarding FindSubschema(), since it's now defined by IBaseDocument, that's now exposed.  You just need to pass an evaluation options object (the registry is needed).  I think I'm going to close this.

@gregsdennis Sorry, I didn't had time to follow up on the previous comment.
But yes, this can be closed. Exposing FindSubschema is something that we needed.


Login page with features:

Fixed #301 Inclusion of Login Page with Username and Password, Registration, and Password Recovery
Implemented a login page with the following features:

Username and Password Login: Users should be able to log in using their username and password.
Registration: There should be an option for new users to register with the system.
Password Recovery: In case users forget their password, there should be a mechanism in place for them to recover/reset their password.

Kindly merge PR and assign GSSoC'24 label and appropriate level.
Regards,
Shreyas

Solve conflicts and preview changes.

I have made multiple attempts, but I am unable to resolve the conflicts. @sunny0625, please assist me.

Try to reopen the PR or pull from main branch.


[PHP] Updates to keep up with PHP 8

At the moment, highlight.js is a bit behind the major changes in PHP 8.0 and upcoming syntax in PHP 8.1.

PHP 8.0 adds a new WeakMap built-in class class.
Add trait to list of class-like naming patterns. This was supported since PHP 5.4.
PHP 8.1 adds support for Enums with enum syntax. Adding enum keyword.
PHP 8.0 adds a new built-in interface called Stringable.
PHP 8.0 match expression throws an UnhandledMatchError exception

This PR updates the PHP keywords list to with these changes. Please note that PHP 8.1 is not yet released, and the Enum syntax is not merged to PHP source yet. The voting is in favor, and it will likely be merged on after the vote ends next week.
Changes

Add WeakMap, Stringable, UnhandledMatchError to built-in class and interface list.
Update keywords list to include mixed. PHP also supports static keyword as return/paremter types, but static is already in the keywords list.
Add trait and enum to class-like name matching list.

Checklist

[x] Added markup tests, or they don't apply here because...
[x] Updated the changelog at CHANGES.md
[x] Added myself to AUTHORS.txt, under Contributors

Screenshots

Thanks for the great write-up and clean commit history.  Very nice.

Thanks a lot for the review @joshgoebel - I'm so grateful for these insights. I will work on the failing tests. They fail locally (node 15.2) for me as well. I'm not 100% sure what keeps them from failing, but I will take a thorough look.

Try commenting out all the illegal keys and see if it starts working... if so that's a clue.

Thank you, tinkering with illegal key did the trick! There was a [:($"] regex there, and it was ruling out the potential enum Foo: string syntax because of the : sign. I relaxed the illegal regex to allow : characters. Triggering CI because it passed locally.
I will update with a negative look behind to tune the regex there.

I will update with a negative look behind to tune the regex there.

Can't use negative look-behinds, they aren't supported by all browsers yet.

I understand, thank you.
I can't think about a way to make the illegal rule more strict. I think allowing : character is worth the relaxed illegal rule to allow enum Foo: string {} syntax.

So then we probably hold this PR at least until the end of the voting.
Yes. I will remove the draft status from this PR on Feb 17, that's when the vote should end and code gets officially merged.

Thanks a lot for shedding the light throughout this PR @joshgoebel.

Brilliant, that was great idea. Tests should pass now too. Thank you.

You seem to know your PHP, perhaps you could add your thoughts to: https://github.com/highlightjs/highlight.js/issues/2996 if you have time.

@joshgoebel Spot on with the beginKeywordS. I force-pushed with it fixed.

I added a new commit that expands our number detection. It now supports all numerals supported up to PHP 8.1.

Decimal numbers
Floats
Binary numbers (0b1100 and 0B1100).
Hex number support (0xAFAF and 0XAFAF).
Octal number support (0777)
New 0o and 0O prefix support for Octals (0o777 and 0O777) (Already accepted and merged to upcoming PHP 8.1)
Scientific notation (7E-10 and 1.2e3)
Underscore number separator (Already implemented in PHP 7.4)

Thank you.

I think this PR will creep up with more changes, so I will wait for the Enum vote to finish on Feb 17, and then take out this PR from the draft state. Once these changes are made, I will see to open another with the only two missing syntax changes:
So far, the two other features we could improve are:

Attributes (#[Foo(Bar)]): They are currently matched as a comment because PHP also follows hash-comment syntax.
Named parameters: (call_foo(foo: 1, bar: 2)). I could get attributes to work, but I will do some more testing with named parameters.

I think this PR will creep up with more changes

Personally I'd rather see this frozen and then another PR opened (it can be on top of this commit history, and rebased later) - but I'm also trying to be flexible since you're one of the cleanest committers I've ever seen here. :-)  Perhaps the real issue is my rush to review things, lol.  Don't get a lot of draft PRs.

Attributes (#[Foo(Bar)])

That would be a great and easy add I think... would these be meta then?

Named parameters: (call_foo(foo: 1, bar: 2)).

This involves detecting functionDispatch( style patterns, most likely, yes?  If so we should highlight the dispatch also (function name), though there is some question on what class we should see. See #2500, etc.  But if you just slap something on it I can sort out the proper class afterwards.

Hi @joshgoebel - thanks for the help with attributes and named parameters. You are right, I think it's good to go with "meta" for Attributes. Rust seems to get same treatment too.

So far, the only change that is not yet landed on PHP is Enums. All other features are already released or merged. I rebased off #3000, and applied all other patches except a couple related to Enums. I will send a separate PRs for Enums, Attributes, and Named parameters.
Thank you.

Taking this PR out of draft state, because all changes are already landed in PHP, and all changes except octal numerals are working in the already released PHP 8.0.
Fingers crossed :)

@Ayesh Thanks so much!

Yay, thank you.


Build fails due to Microsoft.Toolkit.Uwp.Notifications package being a prelease

Need to wait for stable release of Microsoft.Toolkit.Uwp.Notifications, which could take a while...

I tried the example with windows and worked great thanks.
I a create a console app with .net code 3.1. Added your  projects as dependencies plus added them to the solution.
I have Microsoft.Toolkit.Uwp.Notifications packages added version 7.0.0.
I'm getting this error and not sure how to resolve. Can you suggest what to look at?

Getting error in stable release  Microsoft.Toolkit.Uwp.Notifications 7.0.0. Any help would be great.

Updated to Microsoft.Toolkit.Uwp.Notifications 7.0.0 stable.


Implements MessageBox functions engine-side

Implements various message box functions engine-side.
Doesn't completely close the related issue (#451) yet. A separate PR will need to be created to refactor the uses in OPHD.

First off, these functions should never be called from within the NAS2D library itself. Ever.

Why?

Additionally, these methods don't test easily though unit tests.

Not everything will be. Testing the graphics code and shaders, for example, will need to be tested manually.

Further, having these functions available can encourage the use of modal popup boxes, which I really don't want to do. I would much prefer non-modal dismissable popups, much like the Windows tray messages.

@ldicker83 wants modal message boxes.
Toast messages are for when your application is not in use.
See: https://docs.microsoft.com/en-us/windows/uwp/design/shell/tiles-and-notifications/send-local-toast

A toast notification is a message that an app can construct and deliver to the user while they are not currently inside your app.

Toast messages do not work in fullscreen, exclusive or non-exclusive. Windows disables them.
Users can disable them. This is not ideal for error messages:
https://www.askvg.com/windows-10-tip-disable-toast-notifications-and-enable-classic-balloon-tips/

With that said, such messages are commonly used in early prototypes or while debugging, and we don't currently have a non-modal alternative to offer.

There are several times where if something fails and the program literally cannot continue without user input (or at all!) a message box popping up is preferred rather than a hard crash with the obscure "Unhandled exception" error.
An example is compiling shaders at runtime. A library feature of the engine. If the shader fails to compile, I want a message saying it failed and a Retry option to recompile after I fix the shader. These solve that problem.

I don't much like the use of platform detects. Since SDL has support for popups, and the code is already there for other platforms, I'm kind of wondering why it isn't just used consistently for all platforms. I think it would be better to get rid of Windows specific code.

We're trying to move away from SDL handling everything. In this case, it's only here for Linux. MacOSX has their own too.
SDL's implementation of message boxing is horrible. Windows has more options with less code. I'd prefer Windows' one-liners than SDL's multi-function call and multi-struct declarations. Failing that, these functions turn the god-awful SDL code into a sensible one-liner like Windows' versions.

I think I would prefer "Ok", rather than "Okay". The use of "Ok" is just too widespread.

This was an attempt to keep inline with Windows' MB_* arguments that denote what type of message box you are getting.
See: https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-messagebox

There are some minor code formatting issues I see, such as how multiline structure initializers are formatted, in particular with line leading , rather than trailing ,, and line trailing };.

Noted.

The client app should always be in control of error reporting and termination. Any error code must be written such that the error can be delivered to client code so the client code can decide how to act upon it there.
Your shader example sounds like a higher app level concern, not a library concern.

To clarify, I don't think Leeor wants modal popup boxes. I think he's resigned to use them due to other difficulties. Should those difficulties be worked around through some other means, we may very well want to get rid of modal popup boxes.

I had mentioned Windows tray messages as an example of non-modal dismissable messages. Not for their use when the app is not active. There are other examples of in-app non-modal dismissable messages. Browsers sometimes use such messages, such as when the page slides down so the browser can insert a short message about some warning across the top of the page.

I'm not aware of any plan to move away from SDL. It's not even feasible to move away from SDL. Particularly not if we want things to be cross platform, which I certainly do.
As for one liners, that's what the methods are for. If the code inside them was only one line, there wouldn't be much need for the method.

Okay. That sounds like a good reason. As for my shader example, it was just an example. The same can easily be accomplished as Unity does it: No messages at all, your shader just outputs an ugly magenta (255, 0, 255) solid color on whatever you're trying to attach the shader to and you get to figure out why.
I was also going to mention the XMLValidation where loud failures are a must. But again, throwing accomplishes the same thing.

Yeah, makes sense. I've been moving in that direction with the UI. It's slow-going. I'm not a UI dev.

Ohhh....

The OpenGL refactor will be moving away from SDL in favor of up-to-date GL 4.x programmable pipelines with a material/shader system and away from SDL's GL 2.0 implementation. Keeping SDL for cross-platform application window management is required though. Windows vs SDL implementations can easily be encapsulated inside a Window class and an RHI layer.

@ldicker83, it might be good if you could weigh in on direction here. I don't think you need to do a line by line check of the code, just a general check if this is something we are interested in adding to the library, or leaving in the game, and perhaps if the public API is acceptable.

The nas2d-tests repo uses OS-specific calls and defines to use Windows' MessageBox function for reporting errors. This code would get rid of that and make it cross-platform. Realistically, any downstream project that wraps Game in a try-catch block can use them now.
//...
try
{
	NAS2D::Game game("NAS2D Graphics Test", "NAS2D_GraphicsTest", "LairWorks", argv[0]);
	game.go(new TestGraphics());
}
catch(std::exception& e)
{
	std::cout << e.what() << std::endl;
	NAS2D::MessageBox_Okay("Application Error", e.what(), MessageBoxSeverityLevel::Error);
        return 1;
}
catch(...)
{
	std::cout << "Unknown error occurred." << std::endl;
	NAS2D::MessageBox_Okay("Unexpected Error", "Unknown error occurred", MessageBoxSeverityLevel::Error);
	return 2;
}
//...

OPHD uses a MessageBox function with a confusing name at the very end of main.cpp:
            cf.save(); // force configuration to save any changes.
        }
        catch(const std::exception& e)
        {
            doNonFatalErrorMessage("Application Error", e.what());
        }

        #ifdef NDEBUG
        filestr.close();
        #endif

        SDL_Quit();

It reads like: Catch exception, Pop a non-fatal message box: "Application Error"....uhhhh.
Clearly the name of the function is misleading.

I believe it means non-fatal in the sense that the message popup routine doesn't try to terminate the application. It just displays a message box.
Though yes, we could stand to improve the naming and increase consistency between the various message functions.

Do the SDL methods produce ugly or non-native looking popup boxes on Windows?

As written they do (using the SDL_ShowSimpleMessageBox function). Part of the refactor will be to use the fully-featured SDL_ShowMessageBox, but that requires filling out SDL structs beforehand. They aren't needed for Windows so I'd rather they be compiled out on Windows, hence, the platform detects.
The platform detects are safely hidden behind function calls so if you don't like them, don't look at them. :P

That kind of sounds like premature optimization of code that isn't performance critical.
I'd rather have less code to maintain in this case.

I took a look at the structs. They do seem a bit unfortunate with how they are filled out. We could use predefined constexpr values for the buttons and colorScheme fields, though I'm not sure of an easy convenient inline way to set all of numbuttons, buttons, and colorScheme, while also being able to freely set flags, window, title, and message. I kind of wish they'd used sub-structures or something there.


Revert "Avoid using temp_await in SwiftTestTool.swift"

Reverts apple/swift-package-manager#7016 to fix macOS CI regression:
duplicate symbol '_async_MainTu' in:
    /Users/ec2-user/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx/branch-main/swiftpm/.build/x86_64-apple-macosx/debug/swift_package.build/Entrypoint.swift.o
    /Users/ec2-user/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx/branch-main/swiftpm/.build/x86_64-apple-macosx/debug/swift_test.build/Entrypoint.swift.o
duplicate symbol '_async_Main' in:
    /Users/ec2-user/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx/branch-main/swiftpm/.build/x86_64-apple-macosx/debug/swift_package.build/Entrypoint.swift.o
    /Users/ec2-user/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx/branch-main/swiftpm/.build/x86_64-apple-macosx/debug/swift_test.build/Entrypoint.swift.o
ld: 2 duplicate symbols for architecture x86_64

This error was fixed in Swift 5.10, which is not available on CI yet.

cc @AndrewHoos

@swift-ci test


Build Problems with Storage ACLs

I saw this locally yesterday, but the builds worked in Travis. Today, Travis is reporting the same errors:
https://travis-ci.org/GoogleCloudPlatform/gcloud-node/#L2635
1) storage acls buckets should add entity to default access controls:
     Error: Not Found
      at Object.handleResp (lib/common/util.js:9:4858)
      at Request._callback (lib/common/util.js:9:20254)
      at _stream_readable.js:908:16
  2) storage acls buckets should grant an account access:
     Error: Not Found
      at Object.handleResp (lib/common/util.js:9:4858)
      at Request._callback (lib/common/util.js:9:20254)
      at _stream_readable.js:908:16
  3) storage acls buckets should update an account:
     Error: Not Found
      at Object.handleResp (lib/common/util.js:9:4858)
      at Request._callback (lib/common/util.js:9:20254)
      at _stream_readable.js:908:16
  4) storage acls files should grant an account access:
     Error: Not Found
      at Object.handleResp (lib/common/util.js:9:4858)
      at Request._callback (lib/common/util.js:9:20254)
      at _stream_readable.js:908:16
  5) storage acls files should update an account:
     Error: Not Found
      at Object.handleResp (lib/common/util.js:9:4858)
      at Request._callback (lib/common/util.js:9:20254)
      at _stream_readable.js:908:16

Seems to be a problem upstream with defaultObjectAccessControls.delete. Using https://cloud.google.com/storage/docs/json_api/v1/defaultObjectAccessControls/insert to add a user works, then it cannot be deleted with https://cloud.google.com/storage/docs/json_api/v1/defaultObjectAccessControls/delete.
@jgeewax have you already heard of this issue?

I haven't -- do we need to escalate? If so can you give the minimum explanation of what exactly is failing? If something can't be deleted I'd expect a 403.. not a 404, right?

If something can't be deleted I'd expect a 403.. not a 404, right?

Yeah, it's weird, since doing a GET returns the object and a 200.
It probably couldn't hurt to have someone look at it.
To reproduce:

Create a new bucket in the dev console (ex. name: "unique-bucket-name-stephen") https://console.developers.google.com/project/nth-circlet-705/storage/browser
Use the API explorer to insert a default object acl https://cloud.google.com/storage/docs/json_api/v1/defaultObjectAccessControls/insert

bucket: bucket name created in step 1
fields: Leave blank
request body:

entity: user-[emailaddress]
role: READER

Confirm 200 response (expected)
Use the API explorer to delete that default object acl https://cloud.google.com/storage/docs/json_api/v1/defaultObjectAccessControls/delete

bucket: bucket name created in step 1
entity: entity used in step 2

Confirm 404 response (unexpected)

This was previously working, but we started getting the 404 yesterday.

/cc @capstan

I found something interesting. After I insert "user-[emailaddress]", then list the defaultObjectAcls, it comes back like this:
{
  "kind": "storage#objectAccessControl",
  "entity": "user-00b4903a970617830a8fbdf72fc0df7976b1dd9624224cf3c6053d64383e6851",
  "role": "READER",
  "entityId": "00b4903a970617830a8fbdf72fc0df7976b1dd9624224cf3c6053d64383e6851",
  "etag": "CAY="
}

I can get the defaultObjectAcl by user-[emailaddress], but I can only delete it with its encoded name. Should we be getting back the encoded version at all?

/cc @hurstdog who can probably comment on what the intended behavior is and why.

related to https://github.com/GoogleCloudPlatform/gcloud-golang/issues/147

@jgeewax Since this breaks our tests, we're blocked on getting a new release out as well as our various doc fixes for the last 2 weeks. Is this being looked at?

Sounds like GCS is going to send back some magical hash...
I'm asking @hurstdog and @Capstan about how we can now tell GCS to delete the ACL for user-<email> given that they're storing it as user-<magical hash>

Great, thanks!

My current plan is to give it until Wednesday, then skip these tests from the build so we can get a release. Let me know if that doesn't work.
The releases we have out now (< 0.16.0) will fail under the same test, since this was a change in the upstream API, not ours. If we wait much longer before a release, our bug reports (should we get any) will increase in difficulty to track down due to the scope of things we've changed.

I tracked down the issue, and it should be fixed with our release next week.

Awesome, thanks @royalpeasantry!

Fixed in #837

The magical hash in Google Cloud Storage has been updated with email address. Will this library be updated to also return the email address?
I am seeing the below returned for getting acl.
{ entity: 'user-00b4903a9789bd9a7c7e3ba01e6f5eeb40503bc3318102a6fdd2f', role: 'OWNER' }

I don't believe this is the library as it wouldn't be able to translate the email into a hash if the server returned the email.  My guess is that you are not making exactly the same request as the library is, as we still have a few paths server side that are returning the hash that I am working on fixing.

@royalpeasantry any ideas on when all paths to the storage API will return email address?


WIP: CuTorch Mode

This diff implements mode for CudaTensors, which is currently not a supported function. This first stab implementation sets up the scaffolding for the call, and also has a correct (if inefficient) implementation.
Next steps:

[x] 1. Refine serial implementation so that it has less allocs/frees during the loop. Instead use a buffer - so we don't need to rely on the Caching Allocator for good perf.

[x] 2. Extend to all types.

[x] 3. Clean up code. Wrap calls outside of Lua, and verify no memory leaks when using Cuda functions.

[x] 4. Benchmarking Script.

[x] 5. Write a custom kernel that is more efficient by fusing the operations so that we can compute the mode/indices in parallel.

I have addressed @wickedfoo's comments:

Move from SoA to AoS during reductions / segmentedInclusivePrefixScan
Re-use existing generic reduction code for reductions. Required adding a new generic reduction kernel with per-thread register reduction prior to warp reduction
More efficient uses of shared memory for increased occupancy
Remove unnecessary use of __syncthreads() during segmented scan initialization

The only thing I really care about here is that reduceBlockN should take input values in registers, not smem. Merging the two reductions or not I leave up to you.

Address more comments:

Reduce in registers prior to performing block-wide reductions
Remove reduceBlockN option for data initially in shared memory


[Feature Request] Add ability to unlike if liked + add "I don't like this song" shorcut

Hey, I really love your extension, it's really useful and I'll appreciate it so much if you looked into my request.

Add the ability to use the shortcut key again to unlike a song if it's liked so, check the saved songs for the current song then delete track from saved songs

I don't know if this is possible using the API or not because I searched for it but I didn't find an Endpoint for it but, I use Release Radar and Discover Weekly a lot and I use the "I don't like this song" button when I'm discovering new songs in those playlists so, if possible can you add it?
Button:

Maybe this?
https://developer.spotify.com/documentation/web-api/reference/#/operations/remove-tracks-playlist

Hello! I pushed some code to add the first feature request you mentioned.

Add the ability to use the shortcut key again to unlike a song if it's liked so, check the saved songs for the current song then delete track from saved songs

Basically, if you re-use the shortcut on a already liked song, then it is gonna unlike the song(Remove from your Liked Songs library) and I hope that's what you requested.
For the second request, I didn't find any endpoint either, but I'll keep looking for a possible solution and update the app if I find any.
I haven't setup an auto-update system inside the app itself. I won't be able to compile a Windows standalone executable for now since I don't have a Windows machine with me currently, the updated code is in the repo so you can either manually freeze it or run it from source.


Add setting to delete associated home directory when deleting a user

This role currently enables users to be easily deleted but this action leaves behind the old user's home directory.
It would be good if there was an option to also remove home directories when deleting users.

Issue address in PR https://github.com/singleplatform-eng/ansible-users/pull/48


v5.0.0-alpha.25

[ ] I have followed (at least) the PR section of the contributing guide.

Now skeleton also Migrate to emotion.
#24652
Add in changelog if Possible .
@oliviertassinari


v5: Move from widget to modal

Currently, the picker is an a Bootstrap drowndown menu widget. While this works in most cases, it does strange things with positioning and is restrictive in that the element the picker is attached to must have position: relative.
A v5 change could move away from this method to the much more flexible modal style popup. Since the BS modal's are responsive, the picker would take up the right amount of space and would likely be more mobile friendly.
The cost might be that the UX will be different from how other inputs work.
There are three paths here:

Leave it
Use a BS modal window for the popup. By this, I mean that the picker will place the html inside of the modal-body
A custom modal window. This would be the similar to option 2 except that the picker won't be in the bootstrap modal with the header, footer and white box.

Example of the modal window
Please leave a comment with your opinion and a reason why.

Leave it.

@PaitoAnderson ok. why?

Not decided yet, maybe an option like "keep both and make options", because each use case is different.
Just a question : If I have a field without button, and I want to click on it to edit the text directly, what would be the behaviour? Opening a window can be frustrating in that case, and may break tab navigation : the picker should be a way to help the user to write the content, but should not be mandatory.

@jeremyVignelles without the button might be an issue. One of the goals of v5 is to remove the input dependency. It will still work with an input and without a button.
I'm not talking about opening a browser window/tab or a popup. I'm talking about a modal window. No navigation.

With 2 variant you will need to solve a problem of "modal over modal" when datepicker is called from modal. There is a hack to solve this, but you need to know about this ;)

I like the modal idea, but not yet any need for this. Internet users are so used to datepickers to appear below or near the field. And together with a Bootstrap input-group with a calendar icon, it's even better :-)

@Eonasdan I don't think removing the input dependency is a good idea, semantically speaking. The input should be there to store the form data, even if it is an <input type="hidden" />. But I'm okay to have the ability to have a picker without any input visible, that's what inline is for, right? One could wrap this inline into a dropdown on a button.
I know it isn't a browser tab, I was talking about the tab key that is used to navigate between form inputs. Sorry for the misunderstanding.

I like the modal window concept, but I find that there's too much mouse movement required after clicking to the centre of the window.  Is there a way we can make the modal pop up right under where it was clicked?  I'm thinking the window could be opened such that it's centre is wherever the user clicked, or shifted as needed if near to a window edge.
(I also would love it if it could have a Material Design look to it as that example seemed to, but I don't think that's what you were getting at!)

I would prefer (1), largely because of the modal-on-modal issue.

I vote for option 4. Implement modal window and offer it as an option. Right now I'm dealing with integration of datetime picker into modal window and if having this as an option, that would be superb! Also others have pointed out, modal-on-modal does not work so it would be up to developer to decide if widget should appear in modal window or not.

As a feature request, could you possible add the ability to have multiple "quick-pick" options like the Today button.
Maybe a Yesterday, Last Week, and Last Month option.
Today shows the value of "now"
Yesterday - "now - 24 hours"
Last week - "now - 7 days"
Last Month - "now - 30 days"
The use case is for choosing a time frame for a generated report. Typically the most common dates chosen are Last Week TO Today or Last Month TO Today vs specific TIMES or even dates.

Leave it.
I agree with @PaitoAnderson, moreover, the modal isn't friendly in enterprise application, it's can't change the date & time values manually.

Leave it for the same reason as @KienLP. I choose for this datetimepicker because it works ánd on mobile, ánd on desktops (quickly insert date by typing, or viewing the monthly overview for selecting a date by clicking).


Add placeholder and hint for URL input box on Website Plugin Configuration Page

The URL input box for the Website Plugin does not currently have a placeholder, which may confuse users regarding the required format (HTTP or HTTPS).
Proposed Changes:
Add a placeholder to the URL input box:
•	Placeholder text: https://www.raggenie.com
Include a hint below the input box stating:
•	“Include http or https in the URL.”

Sir can you please assign this issue to me . I have tried to fixed it
BEFORE

AFTER

Changes made in File :
ui>src>components>SearchInput.jsx
ui>src>components>SearchInput.module.css
Add a placeholder to the URL input box:
Include a hint below the input box stating:

Hi @uchiha-vivek  sorry to miss adding screnshots
Firstly appriciating your quick effort and result ,  unfortunately this is not the screen where it was required
This is the Samle path : /plugins/4/website/2/details
Screenshot marked the field

You need to run the backend also to see the pluggin list, currently i can see plugins are not loaded on your screen

Yes @ashmilhussain noted, Will do it.

**Changes Made **

I tried to run the backend and then made the changes successfully .

@ashmilhussain  we have to create seperate branch_name by feature or issue  name right ?

Will update once reviewed, regarding branch let it go to main for now

Ok @ashmilhussain   Thanks


Mock locations not received

I have Lockito setup to send mock locations on my OnePlus 3T. I see that Google Maps shows the fake locations, so I know that Lockito works correctly, but in my application, the location change handler never triggers.
PS: I took care so that the mock accuracy in bellow desider accuracy.

I have a small update: even with mock locations enabled, I still get the real location ... This is very peculiar...

Hi @surdu
The problem was that the plugin was based on the native Android location manager, not the Google Play Services one.
We had a lot of issues because of this approach and we fully replaced it with the Google Play Services one (used by Google Maps). The watchLocation method could use mock locations now (however the getCurrentLocation method is still working only with real locations).
I hope this is applicable to you.
You could check the v4.0.0 release notes here.


feat: implementation for custom protocols

related close #8
What I did

This PR is the implementation for custom protocols using maplibregl.addProtocol().
you can find example page in http://localhost:5173/examples/protocols

Notes

Please tell me better interfaces if you have!

Summary by CodeRabbit
Release Notes

New Features

Added a new "Protocols" link in the examples section for easier navigation.
Introduced a new mapping interface that supports custom tile protocols and displays vector and raster tiles.
Added documentation for custom protocols to enhance user understanding.

Enhancements

Integrated a new optional property for custom protocols in the mapping component, allowing for more flexibility in map configuration.

These updates improve usability and expand functionality for users working with map interfaces.

myprotocol doens't work, fix it...


404 for link to minimal mistakes

What happened?

Minimal Mistakes version:
Ruby gem or remote theme version:
Jekyll version:
Git repository URL:
Hosted on GitHub Pages (if yes provide URL to site):
Operating system:

Expected behavior
No 404
Steps to reproduce the behavior
This is the file - https://github.com/mmistakes/minimal-mistakes/blob/master/_includes/footer.html
Other
The link goes to a 404 on mademistakes site.

I'm not seeing anything wrong. The link https://mademistakes.com/work/jekyll-themes/minimal-mistakes/ goes normally.

I think it is a missing slash.
When I go to https://mademistakes.com/work/minimal-mistakes-jekyll-theme it is a 404. When going to https://mademistakes.com/work/minimal-mistakes-jekyll-theme/ it works

@iBug ^^

The code doesn't seem to miss anything:
Minimal Mistakes


[WIP] [prototype] Optimize Center Crop performance

cc @vfdev-5 @bjuncek @pmeier

@datumbox thanks for the PR, do you have a table with runtime speed-up ?


The Renaissance of Event-Driven Architectures

Talk about what event-driven architectures are, where they're used (hardware, kernels/OS, distributed systems), prominent examples such as AWS Lambda and OpenFaaS, the rise of event-streaming (Kafka, Beam/Dataflow) and why you might consider this architecture over "typical" request/response, e.g. REST/gRPC.

Potential topics include:

eventing and streaming as provided by knative
what kinds of problems that are solved with eventing and streaming


feat(field): programmatically associate inputs with field messages

Fixes #935

Proposed Changes

Improve a11y by:

Add a unique ID to the field message p element.
Make the attributes defined by the field available for inputs.
Bind the attributes defined by the field to the input element.

@mmazanec22 could you please a have a look about this PR, if it suits your feature request? Thanks a lot!! :)


Improve Examples to include additional customization hidden fields

https://sdk.collaboraonline.com/docs/theming.html#content-of-hidden-field-css-variables

I think we should also add the UI modifications:
https://sdk.collaboraonline.com/docs/theming.html#user-interface-modifications


feat(pixels): add my new pixel

Checklist

[x] I ran npm test locally and it passed without errors.

[x] I only edited the _data/pixels.json file.

[x] I entered the username in the pixels.json that I'm also using to create this pull request.
[x] I acknowledge that all my contributions will be made under the project's license.

Hey @jrraymundo it seems like that someone unfortunately already grabbed the pixel you are trying to contribute. Could you please sync your fork and contribute a different pixel instead? Thank you for your contribution!

Hi! Sure I'll do that


Use a different config name for connection sorting

This PR fixes #15272 by using a different config name for connection sorting.

I updated the loc id for the two enum options as well just to be consistent and avoid any confusion.

Pull Request Test Coverage Report for Build 794249796

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 43.414%

Totals

Change from base Build 794097825:
0.002%

Covered Lines:
26310

Relevant Lines:
55159

💛  - Coveralls

Let's go with datasource.connectionsSortOrder instead to match what the other sorting settings in VS Code are

Done. I also updated enum variable name and setting description just to be consistent.


Native ad not populating in scroll view until user scroll

[REQUIRED] Step 1: Describe your environment
Plugin Version
3.0.0

[REQUIRED] Step 2: Describe the problem
Seeing an issue with a native ad appearing in app only after scrolling (and the ad is loaded correctly).
Steps to Reproduce

Sample application
To reproduce:

tap 3 dots button in top right corner
tap 'native template'

If issue didn't reproduce then repeat. It doesn't reproduce every time. It takes me 5 minutes to reproduce that issue, but it may take more or less time.
Expected results:
I expected the content of the native ad to appear on screen once it has been loaded successfully.
Actual results:
Native ad was "blank" until I started to scroll

Logs

Analyzing example...

   info • Unused import: 'constants.dart' •
          lib/native_template_example.dart:19:8 • unused_import

1 issue found. (ran in 1.1s)

[✓] Flutter (Channel stable, 3.7.12, on macOS 13.4.1 22F82 darwin-arm64, locale
    en)
    • Flutter version 3.7.12 on channel stable at
      /Users/jmalandruccolo/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4d9e56e694 (3 months ago), 2023-04-17 21:47:46 -0400
    • Engine revision 1a65d409c7
    • Dart version 2.19.6
    • DevTools version 2.20.1

[!] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at /Users/jmalandruccolo/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio with Blaze
      Beta.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio with Blaze.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.80.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (4 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554                        •
      android-arm64  • Android 12 (API 32) (emulator)
    • iPhone 14 Pro (mobile)      • 51E0B954-0AF4-4FCF-A358-2FD3680501DA • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-17-0 (simulator)
    • macOS (desktop)             • macos                                •
      darwin-arm64   • macOS 13.4.1 22F82 darwin-arm64
    • Chrome (web)                • chrome                               •
      web-javascript • Google Chrome 114.0.5735.198

[✓] HTTP Host Availability
    • All required HTTP hosts are available

Possible duplicate of https://github.com/googleads/googleads-mobile-flutter/issues/875?

Is this a generic implementation issue or does this work depending on implementation?  I need to put native ads into my app, but don't want to get started if it means I cannot actually push it to production.

@mulderpf it does work, it's just that the ads take a long time to load and render on screen. This can look janky, especially if the ads are integrated into a scrollable list between widgets. Also, if the ads appear within a scrollable list, sometimes the user has already scrolled past the ad by the time the ad has loaded and rendered.

@Wes1324 this has been escalated to the engineering team and I will respond here as soon as I have an update. Thanks.

I have the same problem . the ad takes 2-3 seconds to display when the user scrolls.

@Knackynouille do you have the same problem using the sample app and following the steps in the original post?

I noticed Filip Hráček talking about this very issue at 17:34 in his video about the Flutter casual games toolkit. It seems like he got around it by preloading the ads.
I'm not doing much on ads at the moment and won't have time to look into this for a while, but it feels like the google_mobile_ads package should handle this preloading if possible.

@Wes1324 good find but I think there are two issues being described.
The issue that I've noticed: The ad loads successfully but the view is blank until the user starts to scroll.
The issue the video seems to be describing is just latency during ad loading. That being said, preloading ads is a valid strategy.
We are always exploring SDK-driven pre-loaded ads in our iOS/Android SDKs but nothing concrete at this time. For now, you can use ad load calls to build up a cache of preloaded ads before you intend to show them, so that ads can be shown with zero latency when needed. However; since ads expire after an hour, you should clear this cache and reload with new ads every hour.

For now, you can use ad load calls to build up a cache of preloaded ads before you intend to show them, so that ads can be shown with zero latency when needed. However; since ads expire after an hour, you should clear this cache and reload with new ads every hour.

There is any exemple code of this ? A same cached Ad to be used on N pages.
When user scrolls the list, to bottom and up again, he should see the same Ad (instead of reaload a new one).
I'm afraid of implement Ads on a list and get ban from admob, as I got on the past, being without income for months.
Because of that, I'm currently using only Fixed banner ads at bottom of home menu navigator. No ban for more than a year.
However, to obtain more income, I need to implement more banners, within the pages. And the fact of Open a page, and close it N times, I think the best approach is to cache the ad to show the same one, everytime.

Hi @marcellocamara, at this time there no example code of this (provided by Google). You can also check the forum for any insight.

Closing this out - isolating the issue to a new bug, tracking the "The ad loads successfully but the view is blank" here https://github.com/googleads/googleads-mobile-flutter/issues/1171


Native Terminal: Improve tmux support

VSCode Version: Version 1.8.1 (1.8.1)
OS Version: OS X 10.11.6

Summary: Highlighting text between tmux splits, and scrolling within tmux, does not work reliably when using the native terminal vs. (e.g.) iTerm2. Mouse support (clicking between splits) is also not supported.
Steps to Reproduce:

Have tmux running inside your shell
Open a split (prefix + %)
Try to highlight text within a split with the mouse (ends up crossing splits, and putting them both into 'normal' mode)
Try to scroll within a split, or use PgUp, and it breaks the tmux history.

Moved upstream https://github.com/sourcelair/xterm.js/issues/456

Wysłane z programu Outlookhttp://aka.ms/weboutlook

Od: Daniel Imms<EMAIL_ADDRESS>Wysłane: 6 stycznia 2017 16:21
Do: Microsoft/vscode
DW: Subscribed
Temat: Re: [Microsoft/vscode] Native Terminal: Improve tmux support (#18182)
Closed #18182https://github.com/Microsoft/vscode/issues/18182.

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/vscode/issues/18182#event-914152620, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJXhXPieL8xUtKYrXTDzymmAvbHaGYY9ks5rPlvkgaJpZM4Lb9ux.

Also In windows (with Ubuntu bash shell) I experience different visual bugs after adding panels and resizing the window:

For example tmux reacts badly on window resize events, and doen't react on on minimize/maximize window and going to full-screen, resizing terminal panel.


Webgpu support?

Description
Chrome webgpu support is around the corner, should be finally enable by default in chrome 113 in like ~3 weeks.
Is mugl will remains purely webgl2, or is there any plan to also handle webgpu (maybe providing some webgl2 fallback).
The syntax is really similar and having the combo webgpu + assemblyscript binding sounds really promising.

Yes! It's always the goal to transition to WebGPU when I created mugl.
Experimental WebGPU support was just added in v0.3.0. Switching between WebGPU and WebGL backend at runtime is possible: https://andykswong.github.io/mugl/examples

Wow really cool, thanks for that.
I was experimenting with some Zig Raylib or Zig GLFW -> wasm for the past few days.
But suddenly with this solution, assemblyscript looks interesting once again 😄


[TASK] prefix salesforce components with MCDO_

Apex

type
old
new
done

Apex
RetriveCompletion
mcdo_RetrieveCompletion (note the extra "e" in retrieve)
[ ] done

Apex
marketingCloudCopadoDataTable
mcdo_RetrieveTable
[ ] done

Apex
RunCopadoFunctionFromLWC
mcdo_RunCopadoFunctionFromLWC
[ ] done

Apex
RunCopadoFunctionFromLWCTest
mcdo_RunCopadoFunctionFromLWCTest
[ ] done

Apex
ChildEnvironmentVariableController
mcdo_ChildEnvironmentVariableController
[ ] done

Apex
ChildEnvironmentVariables
mcdo_ChildEnvironmentVariables
[ ] done

Apex
ChildEnvironmentVariablesTest
mcdo_ChildEnvironmentVariablesTest
[ ] done

Apex
TestDataFactory
mcdo_TestDataFactory
[ ] done

LWC

type
old
new
done

LWC
MarketingCloudCopadoDataTable
mcdo_RetrieveTable
[ ] done

LWC
ChildEnvironmentVariables
mcdo_ChildEnvironmentVariables
[ ] done

Field

type
old
new
done

Object.Field
copado__Environment__c.Parent_Environment__c
copado__Environment__c.mcdo_Parent_Environment__c
[ ] done

for MarketingCloudCopadoDataTable we needed to change the custom metadata type setting here:
custom metadata type to update the custom component for the commit page https://copadonull71743980.lightning.force.com/lightning/setup/CustomMetadata/page?address=%2Fm0F09000000pzOO
found under "Extension Package Configuration":
https://copadonull71743980.lightning.force.com/lightning/setup/CustomMetadata/page?address=%2Fm0C09000000gfIJ

for environment, the lightning record page needs to be updated to point to the renamed LWC:

delete old apex classes & LWC:

starting with the LWCs
then the ...Test apex classes
then the TestDataFactory,
then the rest of the apex classes

afterwards, comment out whatever code is referencing the copado__Environment__c.Parent_Environment__c and rename that to ...mcdo_Parent_Environement__c in the GUI.

make sure you download this again and commit it into git!
same for the page layouts:

lastly, make sure that the permission set is updated to allow access to the "new" classes and the (renamed) field on environment:


Moliholy GitHub signature

Updates to #77

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests


Incorrect Challenge Test Case result on Chrome

Challenge Name
FEDC -> Basic Javascript -> Nest one Array within Another Array
https://www.freecodecamp.com/challenges/nest-one-array-within-another-array
Issue Description
var myArray = [myArray]; is treated as a correct solution. Sometimes it isn't immediately treated as correct, but upon running tests a second time it is. I haven't ever had to run tests more than twice to have this treated as correct.
Browser Information

Browser Name, Google Chrome - Version 54.0.2840.59 (64-bit)
Operating System: Linux Mint 17.3 Xfce 64-bit
Mobile, Desktop, or Tablet: Laptop on a desk top.

I did try this bug on a Windows machine with Firefox. It isn't present. It is present on Chrome however. I've used incognito mode in all cases. Windows Chrome version: 54.0.2840.71 m (64-bit)
Your Code

Full challenge code:
// Example
var ourArray = [["the universe", 42], ["everything", 101010]];

// Only change code below this line.
var myArray = [myArray];

@zairmubashar thanks for the issue. I wasn't able to fully reproduce your error but I think I know what is going on. The reason why it takes two tries for your code to work is that the tests are run right after each other and the values from the previous test run are still saved.
In other words, when you run the tests the first time, you get an array myArray = [myArray], which when you console.log() it, it will return [undefined].
However, when you run it again, you'll run myArray = [myArray] once more using the previous myArray, which will not change myArray to being a multi-dimension array of [[undefined]], which satisfies the challenge.
This issue may or may not be fixed with the new changes upcoming.
cc/ @FreeCodeCamp/issue-moderators

Looks like the trouble with using global vars?

@raisedadead I would say it is a problem in assignment that doesn't require specific value inside the nested array. It passes when you give it to him [[one_array]] inside another.

Here we passed ourArray in myArray variable

Here we passed myArray in myArray

Both are good. And here is picture from Codepen with this assignment

And parser find it ok to let it pass on:
Array [ Array[1] ] example

@erictleung I think you're right, though it only takes two tries after I've already set myArray to something like 1 and failed the tests. I think that's because the default line var myArray = []; actually already sets myArray to [] before the user has a chance to play with the code.
I used
// Example
var ourArray = [["the universe", 42], ["everything", 101010]];

// Only change code below this line.
var myArray = [myArray];
console.log(myArray);

to arbitrary nest myArray in the method you suggested. I did notice that each run logged myArray twice, but with 2 different values! The first was the arbitrarily nested array, while the second was always [undefined] (the keyword undefined). Firefox always returns [undefined] twice.

You would get [undefined], because the lexer hasn't had a chance to assign anything to myArray.
Doing the same in my console might explain it better:
let myArray = [myArray];
console.log(myArray); // Uncaught ReferenceError: myArray is not defined

If however you do:
let myArray = [];
myArray = [myArray];
console.log(myArray); // [[]]

It is not a bug with FreeCodeCamp, but a feature(?) of the language.
I hope this clears up the issue.


Add security.md

The security hardening should be in the form of a checklist
Also is there a way to set rate limit? or maybe other security params we recommend?


Update Push Notification docs to remove support for vibrate

The vibrate param is no longer supported on Android when showing notifications. Need to update docs.

https://bugs.chromium.org/p/chromium/issues/detail?id=971422


Mark stack as NOLOAD

We need to reserve space for the stack in the linker script but it doesn't
actually get loaded. Mark this section as NOLOAD to account for this.
While everything seems to usually work okay without NOLOAD I ran into
an issue on a newer toolchain where data was not getting loaded in
the correct place because it was offset by the stack size. Better to
be a little cautious.

I couldn't reproduce the issue but this change doesn't seem to harm. The integration tests are green so:
bors r+


TypeError: $(...).bsMultiSelect is not a function

Hello everyone!
I'm trying to use a plugin on Bootstrap v5.3.2 and JQuery 3.7.1
In the head section, I included:
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS><script src="/public/js/jquery-3.7.1.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS><script src="/public/js/bootstrap.bundle.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>
Then I created a "select" with id="day_of_week" in the body and added at the bottom of the page:
<script>
    $("#day_of_week").bsMultiSelect();
</script>

However, I'm getting an error: "Uncaught TypeError: $(...).bsMultiSelect is not a function"
What could be the issue?

same here

Thank you... I will test it today.

@rpokrovskij any updates?


Add ability to add context to a Target.

By adding context a multi-stage attack can be carried out. The context for the Target is passed through to Result which allows you to execute another attack based on the additional context
inside the Result.
For example, if you want to first create a session in the first HTTP request and then use that session ID in the second request:
for res := range loginAttacker.Attack(targeter, rate, duration) {
    sessionIdChan <- res.Context["sessionId"].(string)
}

Then the other Targeter can read the sessionId for the next request in the stage:
return func(tgt *vegeta.Target) error {
    sessionId := <- sessionIdChan
}

Hello,
I don't want to introduce a free-form context map into the Result and Target types in the library without a symmetric CLI use case and interface. Doing so would violate the design consistency we now have.
However, note that we already have an http.Header in the Target type, and as this is exposed through the CLI as well, it'd be rather simple to pass it back in the Result type.
What do you think? Would this solve your particular problem?

Thanks for the response  @tsenart.
It's possible but those headers would end up getting sent into the HTTP request and also limits what  kind of context you can pass through (i.e just a string).
I've actually used the context to implement a generic, multi-stage attack pipeline. It might give you a better idea of what I'm trying to do. See https://gist.github.com/chrismoos/0673df867b1f9e820c5f2bab1e6f1af5.
Also, I think a complex multi-stage attack (that has contextual stages) would be difficult just via CLI...probably there would need to be some sort of scripting to facilitate that.
Sample usage of the above multi-stage attack:
pipeline := NewAttackPipeline()
pipeline.Add(stage1Targeter, resultHandler, rate, duration)
pipeline.Add(stage2Targeter, resultHandler, rate, duration)
pipeline.Run(vegeta.Timeout(10*time.Minute), vegeta.KeepAlive(true))

That's a cool use-case! Let's work through this then. What sort of context data do you imagine wouldn't fit nicely in HTTP headers? I'm adamant we keep the consistency between lib and cli. If we were to extend the Target with a general context map, we'd need a way to represent it in the plaintext target language schema that feeds into vegeta attack.
I don't see how to do it cleanly with the current language, which is quite close to plain old HTTP 1.1

The usefulness of the context is mostly derived by extracting something from the HTTP response (i.e a response header, something from body, etc,.) and then passing it through the context to the next stage of the attack.
If you want to integrate this into the current target language schema there would need to be a facility to run a script/handler/etc,. when evaluating the target. One way to do it might be to allow for a user-defined script to be set for a target.
For example:
POST http://goku:9090/things
X-Account-ID: 99
@/path/to/newthing.json;post-run=/path/to/post-run.sh

/path/to/post-run.sh:
echo '{"variableInContext": "test123"}'

The post-run script would be invoked and the full HTTP response (raw, or maybe parsed and placed into a JSON object, for example) sent into stdin. The script would have a defined set of exit codes to indicate success and failure(s). In addition, the script can write to stdout a JSON object that contains the context associated with the request.
Then, to be able to use the context, we can use variable interpolation (or full featured text/template support) to allow for a target to use a context variable:
PATCH http://goku:9090/thing/71988591
My-Customer-Header: ${variableInContext}
@/path/to/thing-71988591.json

Not pursuing this approach for now.

Sorry for the threadomancy but I'd like to know if I could use Vegeta for my use case using the approaches described here. I'd like to make alternate calls creating a resource and then delete it in the next call, using a UID parsed from the response body of the first call. (How) can I do this using vegeta?


Structure tries to spawn multiple times in the same location (causing world generation to take a lot more time) and sometimes spawns at level 0

Through logging I've noticed that spawnCheecks and so the getStructureLocation get called over and over again dozens of times for the same location in the same thread consecutively, causing the world generation to take a lot of time.
Also I'm creating some end tree structures that should spawn on end islands Repo, but some spawns on Y=0 near the islands edges, and I could not figure out why.

And I also get another error

Not all defined tags for registry ResourceKey[minecraft:root / minecraft:worldgen/biome] are present in data pack: improved_end:has_structure/end_highlands

I really hope you can help me out with this.

You have 3 structure sets all with spacing/separation of 1/2 which means each structure set tries to run the different structures for every other chunk. Thus the multiple running per chunk is not the same structure. It’s different structures of yours running for that chunk.
https://github.com/Pyrix25633/Fabric-ImprovedEnd/tree/main/src/main/resources/data/improved_end/worldgen/structure_set
The check for the valid biome happens in the StructurePoolBasedGenerator.generate method as it needs the final position due to 3D biomes in overworlds. In end, you can get away with adding a biome check for starting position at y = 60 or so before the terrain checks because terrain checks are expensive and you’re doing it every other chunk.
I would say if your structure is spawning this frequently, it should be a feature instead. Structures are for larger stuff that are more uncommon. It is not very suited for these kinds of every other every other chunk spawning due to all the checks and all the piece boundary data that is saved into the chunk.

Your biome tag error is due to the tag name file being typoed here
https://github.com/Pyrix25633/Fabric-ImprovedEnd/blob/main/src/main/resources/data/improved_end/tags/worldgen/biome/has_structure/end_higlands.json

You’re probably spawning at y=0 Because you never actually checked to make sure the center position fed into the generate method is actually at a terrain greater than 0.

I've understood the rest, but how do I solve this?

Call getHeightOnGround for startBlockPos and make sure terrain y there is not world bottom

Now I see the problem, I'm checking for ground height at chunk center, but spawning it at chunk start, so given that some structures are smaller than 8 blocks they "fall" to y=0, I'll see if I've solved it

Not completely solved, I'll let you know

I made the structures bigger (added 16x16 circle base), but the problem is still not solved... Also what exactly are "max_distance_from_center" and "size"? Could they be the problem?

I forgot that the vanilla jigsaw system picks a random piece from the structure pool, rotates it around passed in coordinate as if it is the corner of the piece, and finds the center of that piece, and that's where it snaps to heightmap. So I added a check for your thing to the end of the method
https://github.com/Pyrix25633/Fabric-ImprovedEnd/pull/7
However, I looked at your trees. They are 100% not fit for a structure. They are perfect for a feature. This is because well, ever structure spawn has extra data saved into the chunk. Specifically the bounding box of every piece. Since you have no need for knowing if a chunk has a tree, or that a player entered a tree bounding box, and there are so many trees, they should be a feature because right now, the world save is getting bloated with a huge amount of data regarding the structure trees.
Before you ask, yes you can spawn nbt files as part of a feature like vanilla's fossils do. Bonus of this is you control exactly where the nbt file gets placed much easier, is faster to generate during worldgen, and is less memory/data intensive.
Here, you can take my nbt feature class and use/modify it for your purposes. (Not, I use Mojmap mappings so the names of the stuff I use in it may be called something different than in your workspace).
https://github.com/TelepathicGrunt/RepurposedStructures-Quilt/blob/latest-released/src/main/java/com/telepathicgrunt/repurposedstructures/world/features/NbtFeature.java
https://github.com/TelepathicGrunt/RepurposedStructures-Quilt/blob/latest-released/src/main/resources/data/repurposed_structures/worldgen/configured_feature/wells/forest.json

Oh, thank you very much. I think this issue can be considered now closed.


Help!

Hi friend, could you help me load my list of sertifications in the dialog box that appears? that appears on it is that no certificate exists.
Thank you!

Hi, without any code that will be difficult. So, post the code which you think doesn't work and we can take a look.
Please also note, that this repo is not meant to be a library or something like that. It's an example, how one could implement such things, however, it's untested, incomplete and absolutely nothing that should be used in production :)


More code dir structure

More directory structure for src (client, server, common) and test (client, server).

Can we rename test/ to tests/ and do we need a utils directory

Can we rename test/ to tests/ and do we need a utils directory
Sure, we can add utils when we need it

Use "squash and merge" when you can


fix: fixed description not being long enough in embeds

add a check if description length is not bigger than 0, then use "No description"
a fix for issue #78

fix prettier errors


Kindly add booking by center ID directly

(https://cdn-api.co-vin.in/api/v2/appointment/sessions/public/calendarByCenter?center_id={centerID}&date={date})
using above url provid a booking option for particular "center ID" directly
@pallupz

@pallupz
while user selects option pincode, prompt for option to book by center id, so now there will given list of centers in that picodes along is center name.
I am asking for this option because center in one pincodes is located with 3-5kilometers, during lockdown its hard to travel.
kindly look in to it.
thanku

that is a good idea. Problem is where to get this part:

list of centers in that picodes along is center name

@pallupz
when we get on below link, which is used for find by pincode and date
https://cdn-api.co-vin.in/api/v2/appointment/sessions/public/findByPin?pincode=110011&date=29-05-2021

we get response as
{
  "sessions": [
    {
      "center_id": **624711**,
      "name": "Naval Medical Center INS India",
      "address": "Dara Shukoh Road New Delhi",
      "state_name": "Delhi",
      "district_name": "New Delhi",
      "block_name": "Not Applicable",
      "pincode": 110011,
      "from": "09:00:00",
      "to": "17:00:00",
      "lat": 28,
      "long": 77,
      "fee_type": "Free",
      "session_id": "d0ed0de1-ae90-4616-85ca-57b7def5e76a",
      "date": "29-05-2021",
      "available_capacity_dose1": 0,
      "available_capacity_dose2": 0,
      "available_capacity": 0,
      "fee": "0",
      "min_age_limit": 45,
      "vaccine": "COVISHIELD",
      "slots": [
        "09:00AM-11:00AM",
        "11:00AM-01:00PM",
        "01:00PM-03:00PM",
        "03:00PM-05:00PM"
      ]
    }
  ]
}

so filter by
centerId = sessions[center_id]

same with get request on findByDistrict
https://cdn-api.co-vin.in/api/v2/appointment/sessions/public/findByDistrict?district_id=512&date=31-03-2021
we get response as..
{
  "sessions": [
    {
      "center_id": 605499,
      "name": "PHC NANGI BALHEER",
      "address": "",
      "state_name": "Rajasthan",
      "district_name": "Alwar",
      "block_name": "Shahjahanpur",
      "pincode": 301703,
      "from": "09:00:00",
      "to": "17:00:00",
      "lat": 27.56093,
      "long": 76.62502,
      "fee_type": "Free",
      "session_id": "c67953da-d9ce-4e56-9c97-4b2f96a49e79",
      "date": "31-03-2021",
      "available_capacity_dose1": 0,
      "available_capacity_dose2": 0,
      "available_capacity": 100,
      "fee": "0",
      "min_age_limit": 45,
      "vaccine": "COVISHIELD",
      "slots": [
        "09:00AM-11:00AM",
        "11:00AM-01:00PM",
        "01:00PM-03:00PM",
        "03:00PM-05:00PM"
      ]
    }
  ]
}


make idle_timeout configurable at runtime

Thanks!
Note to self: need to audit the use of the global variable

Small point: missing doc/protocol.txt update for the command.
Larger point: It looks like doing this properly isn't quite as trivial as it looks.

If started with idle_timeout 0 the bg thread never starts.
There are a few points where bad things can happen if idle_timeout has a junk read, so it probably needs to be wrapped in a lock (conn_timeout_lock?).
Mainly the bg thread decides how long to sleep based on a read from the idle_timeout setting, thus if it gets a junk value it may end up sleeping for a few years.
The thread has some rate limiting code with a usleep, but is holding the lock while doing this.. Meaning reusing the lock for idle_timeout could hang a worker thread.

Probably the simplest solution is to add a mutex just for the idle_timeout value, and cut the number of times it's read directly:

memcached.c:conn_close_idle(): lock at the top, grab the value, continue with the double check under coniditional
memcached.c:conn_timeout_thread(): probably best to grab the idle_timeout value just under the first while loop, so it stays consistent through a whole run.
there's stats settings output check, not sure it matters as much to lock there but should for completeness.

think that's it? the rest is startup code and should be fine.
Second problem: thread doesn't exist if idle_timeout was zero.

There are start and stop thread funcs, but stopping the thread will hang due to that sleep.
Proper fix: rewrite conn_timeout_thread() so that it's logically locking once per chunk and carries state. Not sure I can describe this here better than writing it myself though, sorry.
Acceptable alternative: do not allow setting idle_timeout from or to zero. Throw an informative error and we can do more work later.

Sorry, I know this looked super easy and probably Just Works most of the time, but when it fails it'll be terrible to debug and user expectations will be broken for setting from/to 0. This is probably why it wasn't added with the original code.


Update Chromedriver version

What is the context of this PR?
Functional tests are broken in Runner as chromedriver needs to be updated
How to review
Check functional tests pass
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

 Update Chromedriver


[release-0.30]Add tests to make sure qemu processes are MCS constrained

Signed-off-by: Kedar Bidarkar<EMAIL_ADDRESS>
What this PR does / why we need it: Add tests to make sure qemu processes are MCS constrained
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer: Add tests to make sure qemu processes are MCS constrained
Release note:

NONE

backport of #3599

/assign @jean-edouard

/retest

/retest

/lgtm

/retest

/retest

/close
Let's not create and approve PRs which  are not already merged on master. At least put a /hold on such a PR. I instructed prow to do a backport once it is merged on master.


apply_acrylic does not display properly in windows 22H2

I tried using this in fltk-rs.
Seems to work only for the menu bar.
I have tried it on windows 22H1 and it is displayed normally.
But this will not work properly in windows 22H2.
# Cargo.toml
[package]
name = "fltk-acrylic"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
fltk = { version = "1.3.22", features = ["rwh05"] }
window-vibrancy = "0.3"

# main.rs
use fltk::{prelude::*, *};
use window_vibrancy::apply_acrylic;

fn main() {
    let a = app::App::default().with_scheme(app::Scheme::Gtk);
    let mut win = window::Window::default().with_size(400, 400);
    win.end();
    win.show();

    apply_acrylic(&win, Some((10, 10, 10, 90))).expect("Unsupported");
    a.run().unwrap();
}

Are you sure the window is transparent? you need to make sure the window is transparent. for example, try cloning this repo and running:
cargo r --example winit
cargo r --example tao

you can see that in the first example, the window is not transparent, due to a bug in winit but you can see that the effect works fine in tao.
The reason why it worked in 22H1 because we use a different API there which has a lag issues when resizing/moving.


Support qcow2 image format for HostDisk & FS PVC

What this PR does / why we need it:
Adds support for qcow2 images for HostDisk and file-system PVC configurations whereas currently only raw images are supported. This does not add support for creating qcow2 images on those configurations, only supports existing images.
Release note:

Add support for exisiting qcow2 images on HostDisk and file-system PVC configurations.

/cc @aglitke FYI

@rmohr @aglitke
Sorry it took me so long to get back to this. I added validation in the virt-handler context.

ok, I still think that we should know at this stage already what we are dealing with. We can extract and save the information somewhere else after a first successful extraction.

I have not found a good place to save this other than the VMI spec itself. Maybe you had something more specific in mind or I am missing something?

You will probably need to modify this PR so that the disk file format is exposed in the VM spec. It's unfortunate that such a detail must be exposed to the end user but I do not see any way around it.

If we do this, I am assuming it would only be used in the cases where the image already exist to verify the format (vs allowing to create an image of the specified format)? And that no empty value would be allowed? Or do you have a different opinion?


workflows: build and push container from GitHub Actions

Quay builds are amd64-only and haven't been especially reliable.  Use GitHub Actions to build both amd64 and arm64 containers for the main branch and for tags, and push them to Quay.  Continue building but not pushing containers on PR.  Requires the QUAY_AUTH repo secret to be set to a Docker credential.
Ideally we would cross-build the arm64 container by having the Dockerfile specify FROM --platform=$BUILDPLATFORM for the builder container and set GOARCH=$TARGETARCH.  However, Buildah < 1.24.1 doesn't support --platform in FROM.  Build in emulation for now, and skip arm64 in PRs to speed up CI.
Fixes https://github.com/coreos/butane/issues/324.  Alternative to #325.

Before landing this:

[ ] Get Quay robot account in coreos namespace
[ ] Add robot account credential to shared credential storage
[ ] Add QUAY_AUTH secret
[ ] Drop Quay build trigger and build failure notification


setup.py wasn't installing templates nor media dirs

I fixed it with a Manifest.in
Also, you may not like it sorry, I cleaned up setup.py.
It's my first fork, my first pull request, and also my first setuptools fixing.
I took this repo as a reference: https://github.com/bradleyayers/django-tables2
Thanks!

no prob :) and thanks.


update installation docs

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

remove /cluster-operator/quickstart/


New enhancement in the design

Description
We want to add a new enhancement to the design which is this:

Make sure that you add it right below the Navbar with no gap in between.
Take reference from here https://www.amazon.com/ 🚀
Desired Behaviour

Note: Don't make any changes in the Navbar, Just work on the enhancement.

Hey I would like to work on this issue. :)

@Jai-Solania-29 assign me this task, i will enhance this as per your requirements.

Hey, @developer-irfan Thanks for showing interest, You can start working on this 🚀
Assigning the issue to you ✅

Any updates @developer-irfan ?