feat: gsheets schema UI

Description
Added a Gsheet Schema to show a preview of sheet data if the gsheet datasource is authorized successfully. User can change the spreadsheet and specific sheet to check the preview.
PR fixes following issue(s)
Fixes #25647
Media

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/ok-to-test

/build-deploy-preview

/ok-to-test

/build-deploy-preview skip-tests=true

/ok-to-test

/build-deploy-preview

/ok-to-test

/build-deploy-preview skip-tests=true

/ok-to-test


Incompatible with jQuery 3.x

Galleria 1.4.7 isn't compatible with jQuery 3:

JQMIGRATE: jQuery.fn.load() is deprecated

at Galleria.loadTheme:
$( window ).load( function() { ... });

I got around this with an ugly hack, in the meantime, rather than using an older version of jQuery:
$.fn.load = function() {
  var a = $.merge(["load"], arguments);
  return this.on.apply(this, a);
};

This will be fixed in the next version. Until then you could simply use jQuery migrate if you need jQuery3, please see #373

"dist" folder is not updated in release 1.5.0. Can you update this?

sorry, don't push releases in a hurry ;(

There are still problems with jQuery 3.x in the dist folder Release 1.5.1:

JQMIGRATE: jQuery.fn.load() is deprecated at loadTheme

Can you check this again:
https://github.com/worseisbetter/galleria/tree/1.5.1
Because this is the version I get with bower update...

the tag got a wrong commit hash, just released 1.5.2


Fix build and migrate to GitHub Actions

I noticed there are a number of failing tests in this project's build, and that it appears Travis CI have shut off this project at some point (😭), so there's no build feedback on PRs any more.
This PR fixes the build, and adds a GitHub Actions CI step covering all the previously-tested ruby versions. You can see the build success status for each commit in the compare view over in my forked repo.
Any and all feedback welcome – I did a little tidying of the build output (e.g. warnings are now only shown on CI, and rspec profiling is disabled), but if it's preferred that these are both kept by default I'm happy to add them back.

@hallelujah Can you review this, please? It looks like this fixes https://github.com/hallelujah/valid_email/issues/120 and https://github.com/hallelujah/valid_email/issues/107 and supersedes https://github.com/hallelujah/valid_email/pull/123 and https://github.com/hallelujah/valid_email/pull/124.

@hallelujah @torrocus Can you push a new release to RubyGems including these changes, please?

@torrocus @hallelujah Sorry to bother you, but is there a specific date for when there is going to be the next release of the gem with these changes?


Create package.json for package informateion

Hi, @zhangxinxu
Your great work had been recommend being added in cdnjs.
However, we need more confirmed information when include it in our project.
Would you mind to add package.json for the package :)?
And we would appreciate your help. #5737
Thank you!
Piicksarn

OK,  thanks~ hold a minute~

done!

Thank you!

@zhangxinxu 唔，还以为你已经弃坑了


Feat/lesq 11/downloads layout [LESQ-11]

Description

Deleted old download card
Renamed DLCard to ResourceCard so it can be used for share
made a new component ResourcePageLayout to handle the layout for download & share pages
added some logic to organise the resouce cards according to ACS
moved some components from the LessonDownloads.page into ResourcePageLayout

How to test
I've added a few test cases in storybook on the DownloadCardGroup component to cover the different scenarios of resources present (with & without presentation, with one/two worksheets) : https://deploy-preview-2064--owa-storybook.netlify.thenational.academy/?path=/story/download-components-download-card-group--all-resources

Go to https://deploy-preview-2064--oak-web-application.netlify.thenational.academy/teachers/programmes/combined-science-secondary-ks4-foundation-ocr/units/measuring-waves/lessons/transverse-waves/downloads?preselected=all
You should see the new layout
Go to https://deploy-preview-2064--oak-web-application.netlify.thenational.academy/teachers/programmes/religious-education-secondary-ks4-l/units/islamic-practices-690d/lessons/shahadah-6gu68c/downloads?preselected=all
See fewer resources

Screenshots
How it used to look (delete if n/a):

How it should now look:

ACs

[ ]  Column x 2 format (resources on left and details on right)
[ ]  Swap to new resource selector component

Slide deck appears on its own row
Unless there is only 1 worksheet resource, in which case that buddies up with the slide deck on the top row
Everything else pairs with its no answer/answer variant
Everything just moves up if there is no slide deck

[ ]  Remove old download card component
[ ]  Reposition t’s & c’s, copyright details and download button
[ ]  Heading changes - check figma notes

:tada: This PR is included in version 1.295.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ReferenceError: event is not defined - Firefox

I have just installed from master branch and on firefox (any version) following error shows in developer console:
"ReferenceError: event is not defined"

I observe the same issue on FF.

Thanks for reporting this! I'm going to try and take a look tonight / over the weekend / over the break.

I tried testing XSelect v4.0.0-beta.2 on codesandbox with Firefox 63 & 65 and couldn't reproduce. https://codesandbox.io/s/kkw0nk5j6v (you might have to edit a file, & hit save for the server to start on codesandbox 🤷♂ )
Could anyone provide more info or a reproduction? or an error stack trade screenshot?

+1 Very annoying.

@Robdel12 screenshot if it helps.

I can't reproduce this (Firefox 68) but I got an error from Sentry with this exact issue.
Sentry says that it happens in __setDefaultValues like others here are mentioning.
What I found interesting was that looking at the code for __setDefaultValues we see (this was checked today) this
__setDefaultValues() {
    let canSet = !this.isDestroying && !this.isDestroyed;

    if (canSet && this.get('value') == null) {
      // `onChange` is the default event we use
      this._handleAction('onChange', this._getValue(), event);
    }
  },

That event variable that's passed to handleAction is nowhere to be found on this code (not passed as argument, defined as parameter, local variable). I thought "of course, that must be it". But while debugging I found that event is actually defined, so I assumed it's some implicit global variable (because in both Chrome and Firefox it wasn't undefined).
Even more interesting is that in MDN there are some notes regarding to this (https://developer.mozilla.org/en-US/docs/Web/API/Window/event). Interesting, about compatibility... it says that Firefox started supporting this in version 63/65 but it was reverted.
Also interesting is that the Sentry report I got was from a Firefox of version 64.  In the MDN page they recommend:
This property can be fragile, in that there may be situations in which the returned Event is not the expected value. In addition, Window.event is not accurate for events dispatched within shadow trees.
So I think only a subset of Firefox versions are affected by this? (maybe 64). Not sure the solution, but maybe explicitly invoke handleAction with window.event ?


Reducing memory usage by adjusting data frame usage

Installation tested by installing direct from github:
pip install -e git+https://github.com/pixalytics-ltd/Landsat578.git@feature/1#egg=Landsat578


Enable scale codec for SQL proposal txIDs

Motivation

Part of #3271
Changes
Introduced EncodeSlice/DecodeSlice codec methods + enabled scale codec for SQL proposal txIDs
DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

xdr2scale binary

xdr2scale binary

removed, cheers

bors try

bors merge


[SPARK-46899][CORE] Remove POST APIs from MasterWebUI when spark.ui.killEnabled is false

What changes were proposed in this pull request?
This PR aims to remove POST APIs from MasterWebUI when spark.ui.killEnabled is false.
Why are the changes needed?
If spark.ui.killEnabled is false, we don't need to attach POST-related redirect or servlet handlers from the beginning because it will be ignored in MasterPage.
https://github.com/apache/spark/blob/8cd0d1854da04334aff3188e4eca08a48f734579/core/src/main/scala/org/apache/spark/deploy/master/ui/MasterPage.scala#L64-L65
Does this PR introduce any user-facing change?
Previously, the user request is ignored silently after redirecting. Now, it will response with a correct HTTP error code, 405 Method Not Allowed.
How was this patch tested?
Pass the CIs with newly added test suite, ReadOnlyMasterWebUISuite.
Was this patch authored or co-authored using generative AI tooling?
No.

Could you review this PR, @LuciferYang ?

 I verified it locally. Let me merge this.
$ build/sbt "core/testOnly *.ReadOnlyMasterWebUISuite"
...
[info] ReadOnlyMasterWebUISuite:
[info] - /app/kill POST method is not allowed (59 milliseconds)
[info] - /driver/kill POST method is not allowed (2 milliseconds)
[info] - /workers/kill POST method is not allowed (2 milliseconds)
[info] Run completed in 1 second, 438 milliseconds.
[info] Total number of tests run: 3
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 3, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 11 s, completed Jan 28, 2024, 10:37:34 PM

Merged to master for Apache Spark 4.0.0. Thank you again, @LuciferYang !

Sorry for missing your ping, @JoshRosen . I'll take a look at that part. Thank you.

I made a follow-up, @JoshRosen . Could you review this?

#45010


added my profile card

your pr is conflicted, plz make a new pr, and star the repo this is mandatory and you can also follow me.


Pagination fencepost error

Pagination seems to have an issue where per_page is set to the exact total number of items in the unpaginated response, in some, but not all circumstances.
In this example, staff is defined as a relationship on the School model as such:
staff = db.relationship(         'User',         secondary='grant',         primaryjoin='School.id==Grant.school_staff_target_id',         secondaryjoin='Grant.user_id==User.id',         lazy='dynamic',         backref='schools_staff'     )
I query without pagination like this, and I get the expected number of staff, two:
staff = School.query.filter_by(id='5d2ab3bb1f28426f8148e47543b1cbee').one()\         .staff.filter_by(deleted=False).all()
Staff: [<User 56fde169-f7bd-4ca1-9e4d-2268a0d71dc7>, <User b3769431-b48a-4303-8ec6-b2f0763d21f1>]
If I paginate setting per_page=2, I correctly get has_next=False, but items only has one result:
staff = School.query.filter_by(id='5d2ab3bb1f28426f8148e47543b1cbee').one()\         .staff.filter_by(deleted=False).paginate(1, 2)
Staff: [<User 56fde169-f7bd-4ca1-9e4d-2268a0d71dc7>]
If I paginate setting per_page>2, such as 3, items has two results:
staff = School.query.filter_by(id='5d2ab3bb1f28426f8148e47543b1cbee').one()\         .staff.filter_by(deleted=False).paginate(1, 3)
Staff: [<User 56fde169-f7bd-4ca1-9e4d-2268a0d71dc7>, <User b3769431-b48a-4303-8ec6-b2f0763d21f1>]
This may not actually be a fencepost error. A comprehensive output is below:
Staff ORM query: School.query.filter_by(id='5d2ab3bb1f28426f8148e47543b1cbee').one().staff.filter_by(deleted=False).paginate(1, 2)
Staff: [<User 56fde169-f7bd-4ca1-9e4d-2268a0d71dc7>]
Staff pages: 1
Staff has_next False
Staff per_page: 2
Staff total: 1
Staff query: SELECT user.id AS user_id, user.legacy_id AS user_legacy_id, user.email AS user_email, user.first_name AS user_first_name, user.last_name AS user_last_name, user.password AS user_password, user.deleted AS user_deleted
FROM user, grant
WHERE ? = grant.school_staff_target_id AND grant.user_id = user.id AND user.deleted = 0
Staff ORM query: School.query.filter_by(id='5d2ab3bb1f28426f8148e47543b1cbee').one().staff.filter_by(deleted=False).paginate(1, 3)
Staff: [<User 56fde169-f7bd-4ca1-9e4d-2268a0d71dc7>, ]
Staff pages: 1
Staff has_next False
Staff per_page: 3
Staff total: 2
Staff query: SELECT user.id AS user_id, user.legacy_id AS user_legacy_id, user.email AS user_email, user.first_name AS user_first_name, user.last_name AS user_last_name, user.password AS user_password, user.deleted AS user_deleted
FROM user, grant
WHERE ? = grant.school_staff_target_id AND grant.user_id = user.id AND user.deleted = 0
Staff ORM query: School.query.filter_by(id='5d2ab3bb1f28426f8148e47543b1cbee').one().staff.filter_by(deleted=False).all()
Staff: [User 56fde169-f7bd-4ca1-9e4d-2268a0d71dc7, User b3769431-b48a-4303-8ec6-b2f0763d21f1]

This appears to be an issue with sqlalchemy.orm.limit() in these circumstances. This query only returns one result:
staff = School.query.filter_by(id='5d2ab3bb1f28426f8148e47543b1cbee').one()\         .staff.filter_by(deleted=False).limit(2).all()
Whereas this query returns both results (expected):
staff = School.query.filter_by(id='5d2ab3bb1f28426f8148e47543b1cbee').one()\         .staff.filter_by(deleted=False).limit(3).all()

Sounds like that needs to be reported to SQLAlchemy instead?

For reference, here is the issue over at SQLAlchemy
https://github.com/sqlalchemy/sqlalchemy/issues/4891


Federated Status Implementation for federated types

This pr implements a generic federated status for federated types by extending the sync controller. The federated status is a list of resource status in member cluster, as outlined in the first alternative in issue https://github.com/kubernetes-sigs/federation-v2/issues/246
Later the controllers depending upon the status in member clusters can make use of this without monitoring the resource in individual clusters.
/cc @onyiny-ang @pmorie @marun @kubernetes-sigs/federation-wg

@shashidharatd Am I missing something, or is the entirety of status being collected?  I wasn't aware that chatty fields like conditions were useful?

I'm reviewing this.

cool, waiting for your inputs. Thanks !


Add the SE23 IMU EKF example for one robot

The PR for the SE23 IMU EKF for one robot. You will realize I also made some minor changes to the other examples.

This PR is now ready for merging, and I will start working on the multi-robot version. Feel free to add any comments/make any changes, I will merge this in the coming few days


How to decode input data of ERC20 token transaction?

I used abi-decoder to decode and parse input data of transaction to find the transfer amount of token when I developing with Javascript.
But how to decode the input data of standard ERC20 token's transaction using web3swift?
I want to find out token transfer data like this.

@shamatar Thank you for your answer. I tried to decode input data using ABIv2Decoder, But can't get transfer amount that I want with the code bellow.

Could you show me an example how to parse out transfer amount from input data of Tx bellow?
https://etherscan.io/tx/0x4f3300460c52f139a103709d018bb65a80ed5e1bcade2846992dd061b5bc94c6

Hello @ToToDoDo
Would you try a method
web3rospten.contract.decodeInputData("methodName", data: bigI.transaction.data)

Yet untested, but should work out of the box

Hello @ToToDoDo
The latest code from "master" now has functions to decode input data with and without explicit method naming, ERC20 "Transfer" test passes. I'll close for now, feel free to reopen if necessary.
Sincerely, Alex

@shamatar Thank you very much!
I can parse out method name from input data, but value was not correct.
How to decode the value decode by contract.decodeInputData() ?

Please update to the latest master branch version, by the structure of addresses I see you have one without an important bug fix

From: ToToDoDo<EMAIL_ADDRESS>Sent: Thursday, May 10, 2018 8:59:50 AM
To: BANKEX/web3swift
Cc: Alexander; Mention
Subject: Re: [BANKEX/web3swift] How to decode input data of ERC20 token transaction? (#93)
@shamatarhttps://github.com/shamatar Thank you very much!
I can parse out method name from input data, but value was not correct.
How to decode the value decode by contract.decodeInputData() ?
[df0df8fbf420a769c352e34045b8e556]https://user-images.githubusercontent.com/1905256/39854379-6b2d1a02-5462-11e8-8490-8c84c475e48b.jpg
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/BANKEX/web3swift/issues/93#issuecomment-387960337, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGKv90Muql8jJWi14woPUL40ElngFTjgks5tw9dWgaJpZM4T2ULm.

Thank you! It works well after update to the last master branch version.


Add ability to delete users on white theme

With a confirmation popup.
Should go next to "edit profile" on their main page https://alonetone.com/alterego

https://github.com/sudara/alonetone/issues/195 is to get that "Delete your Account" button working again.
I was hoping for a button on pages like alonetone.com/someusername, for mods only:

Ah, OK. So user story:
As an admin, I want to be able to see a pretty Delete button (next to edit button) on a user#show page.


pyusb on windows timesout

on my windows 10 system I consistently get;
usb.core.USBError: [Errno None] b'libusb0-dll:err [_usb_reap_async] timeout error\n'
Are there any problems on windows with pyusb.

Please use mailing list for technical support.


Wrangler dev --remote command yields error in Browser Rendering Worker with Durable Objects tutorial

Existing documentation URL(s)

https://developers.cloudflare.com/browser-rendering/get-started/browser-rendering-with-do

What changes are you suggesting?
In section 7,  it instructs the user to npx wrangler dev --remote command. When I run this command via the terminal (MacOS Sonoma 14.6.1) it does not work. I get the error in the attached screenshot.

Additional information
No response

Howdy @tbrooks007, it looks like the error might be with your local certificate setup, as opposed to the tutorial itself?
I'm more on the writing than engineering side, so could be wrong... but SELF_SIGNED_CERT_IN_CHAIN sounds like it's not a Wrangler issue per se.

Checked internally with ENG and they validated my assumption. Closing out for now.

Could you please elaborate on what was actually confirmed or why it maybe happening? The issue only happens when I use the --remote command. It does not happen otherwise.

@danielgek, any insight into why it might be happening only in this case?

Browser Rendering --remote works a bit different from the the other products, I will discuss this internally
Tho I can't reproduce this on my side, @tbrooks007 any way you can try this on a different machine ?
I will follow up this once i discuss internally as well

The issue was WARP being turned on. When I turned it off and tried again, all is good. Thank you for your help. We can close the ticket.

The issue was WARP being turned on. When I turned it off and tried again, all is good. Thank you for your help. We can close the ticket.


vocabulary is larger than expected

What is the issue?
ollama create model  -f ./Modelfile report errors： Error: vocabulary is larger than expected '128257'instead of '128256'
OS
Linux
GPU
Nvidia
CPU
No response
Ollama version
0.5.4

The size of the vocabulary in config.json doesn't match the size of the vocabulary in the model file.  Where did you get the model you are trying to convert?

config.json 中的词汇表大小与模型文件中的词汇表大小不匹配。您从哪里获取要转换的模型？

from huggingface，The problem caused by introducing ollama running after training with llama factory，The vocabulary in config. json remains unchanged after training，May I ask how to solve this

What model from HF?

What model from HF?

shenzhi-wang/Llama3-8B-Chinese-Chat

How are you exporting you model from LLaMaFactory?  LORA adapter, merged GGUF, etC?

I wasn't able to reproduce this. Can you update your weights?
% git clone https://huggingface.co/shenzhi-wang/Llama3-8B-Chinese-Chat
Cloning into 'Llama3-8B-Chinese-Chat'...
remote: Enumerating objects: 159, done.
remote: Counting objects: 100% (154/154), done.
remote: Compressing objects: 100% (154/154), done.
remote: Total 159 (delta 77), reused 0 (delta 0), pack-reused 5 (from 1)
Receiving objects: 100% (159/159), 2.34 MiB | 9.91 MiB/s, done.
Resolving deltas: 100% (77/77), done.
Filtering content: 100% (4/4), 2.95 GiB | 9.26 MiB/s, done.
% cd Llama3-8B-Chinese-Chat
% ollama create test
transferring model data 100%
converting model
using existing layer sha256:287463ff7eee5fc4bf5a1efcb0d141c0c5e919da256f507cfb523531fba22c4c
using existing layer sha256:b21e6799b8a71e0aafad1d38392d77f128894477c5d942701fd7d5b37441e7f8
writing manifest
success

I suspect that the original weights had the wrong vocab_size value in config.json. NOTE you'll see need to add the correct TEMPLATE in your Modelfile.
I'll go ahead and close the issue.

I wasn't able to reproduce this. Can you update your weights?
% git clone https://huggingface.co/shenzhi-wang/Llama3-8B-Chinese-Chat
Cloning into 'Llama3-8B-Chinese-Chat'...
remote: Enumerating objects: 159, done.
remote: Counting objects: 100% (154/154), done.
remote: Compressing objects: 100% (154/154), done.
remote: Total 159 (delta 77), reused 0 (delta 0), pack-reused 5 (from 1)
Receiving objects: 100% (159/159), 2.34 MiB | 9.91 MiB/s, done.
Resolving deltas: 100% (77/77), done.
Filtering content: 100% (4/4), 2.95 GiB | 9.26 MiB/s, done.
% cd Llama3-8B-Chinese-Chat
% ollama create test
transferring model data 100%
converting model
using existing layer sha256:287463ff7eee5fc4bf5a1efcb0d141c0c5e919da256f507cfb523531fba22c4c
using existing layer sha256:b21e6799b8a71e0aafad1d38392d77f128894477c5d942701fd7d5b37441e7f8
writing manifest
success

I suspect that the original weights had the wrong vocab_size value in config.json. NOTE you'll see need to add the correct TEMPLATE in your Modelfile.
I'll go ahead and close the issue.

I have fine tuned the model through llamafactory, and the unadjusted model can be loaded into ollama

vocab_size

I manually changed the VOCAB_Size variable in config. json, which can be loaded into ollama using the create command, but cannot run the model
(base) [root@iZ8psj2fjgopvor6vx3rtyZ ~]# ollama run Llama3-8B-Chinese-Chat-new-merged:latest Error: llama runner process has terminated: error loading model: check_tensor_dims: tensor 'token_embd.weight' has wrong shape; expected  4096, 128257, got  4096, 128256,     1,     1


problematic files report

when a file apperas in more reports we should mark them as problematic and at the end list top 5/10

Hi, I'd like to give it a try to this issue but I don't get this part "and at the end list top 5/10". Could you elaborate more on it please? 🧑🏼💻

Currently the report is grouped by rule.
The idea with this is grouping by file.
So in the current report a file can be reported for multiple rules and it is not as convininet in cases when somebody wants to clear the code file by file and not rule by rule. This implementation would give an output listing problematic files and all offended rules in the particular file.
The last part wanted to say to list only the top 5 or 10 problematic file, but now I think it would be nicer to list all.
Ordering the files is a question,

order the files by starting the most problematic (with the most rules offended).
order them as the checks runs

As a starter we can go with the later, and if we want we can add and order option later. If you like the idea we can create a dedicated issue for this, to keep this issue focused.
As we want to keep the current rule based listing we need a new command line parameter like group what can defaults to rule (current solution), or can be file for this new report structure.

Ohh I get it now!

The last part wanted to say to list only the top 5 or 10 problematic file, but now I think it would be nicer to list all.

I agree, It would be nicer to list it all.

As a starter we can go with the later, and if we want we can add and order option later. If you like the idea we can create a dedicated issue for this, to keep this issue focused.

the order option would be great to have so yes, let's create a dedicated issue for this to have it on the radar.

Hi @rrd108
What do you think of this output layout for the group by file report?

looks cool
yellow is a warning level, right?
what is the message for?

yellow is a warning level, right?

Yes, the background color depends on the one used in each rule. In this example, those two rules uses BG_WARN. But I've been confused about when to use each one... only BG_ERROR in vue-strong and vue-essential rules?

what is the message for?

All rules have a loop and console logs of the final message to the user... in this case parameterCount always shows the functionName and inside parenthesis the number of parameters it has.
But for the top-level-element-order the message was the name of the file... so in that case its not worth it to show the name of the file again (its already at the top). So the message depends on each rule.

yellow is a warning level, right?

Yes, the background color depends on the one used in each rule. In this example, those two rules uses BG_WARN. But I've been confused about when to use each one... only BG_ERROR in vue-strong and vue-essential rules?

I wanted to have 2 levels because soe rules - like script length, or complexity - can have a softer and harder limit. By default I would use warnings.
some explanation should be added to the docs #100 and to the contribtuin guide #101

what is the message for?

All rules have a loop and console logs of the final message to the user... in this case parameterCount always shows the functionName and inside parenthesis the number of parameters it has.

Ah ok. I guess we should add some text to the number to make it more clear what is it.

But for the top-level-element-order the message was the name of the file... so in that case its not worth it to show the name of the file again (its already at the top). So the message depends on each rule.

Ok. Thanks for the explanation.

I wanted to have 2 levels because soe rules - like script length, or complexity - can have a softer and harder limit. By default I would use warnings.

You mean to use warnings in ALL cases by default? and if some rules need to use BG_ERROR we will change it.

I mean most of the rules will be warnings.
If it can multiple levels then warnings and errors.
If it is something serious then an error.
Unfortunately I have no objective measures.

Got it, thanks!

same as #64

@rrd108

the order option would be great to have so yes, let's create a dedicated issue for this to have it on the radar.

We never created an issue for the order option right?

No we did not yet

Okay, I'll create it and assign it to myself 👌 #140


Make future changes easier by resolve CICD errors.

Resonance audio fails cicd
Video player gdextension

Removed gdextension and updates spatial audio https://github.com/V-Sekai/godot/commit/b3d26e84bb2d72c4ca4c9886d2b941e8bb817a08.


Allow selecting aggregations per resource

This PR extends the config file with aggregations, a list of aggregations to query Azure for. If not given, the same list (total, min, max, avg) as was previously always used is used.
Fixes #17

Added (strict) validation now.

Thanks!


toFixed converts x and y coordinates to strings

Since Victor#toFixed() uses Number#toFixed() under the hood, it is turning the x and y coordinates of the vector into strings: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toFixed

Although you are correct, I would argue that it makes sense to keep the API consistent with the JavaScript one. I agree that Number#toFixed is kind of annoying, but when I call it I expect a string.

The problem is that it will break all further functionality of the vector/point, since all other functions are expecting numbers, not strings.
If you want to follow Number#toFixed() you should return a new object, since Number#toFixed() does not change the object itself - it returns a new string.
var a = 10;
var b = a.toFixed();
a is still a number..
b is "10"

Good point. How do you feel about keeping #toFixed as returning a string (and change it to stop it mutating). And then adding a #roundToDecimalPlaces (or similar) method to allow for the functionality that you want?

Sounds perfect!


AutoComplete - add control to allow open on focus

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the Modus style guidelines

Proposal
Submission approved and final version of Figma available https://app.clickup.com/t/8684uve2r
Motivation and context
https://docs.google.com/document/d/1juSdxo5G6jmB_8MrrpZL3WdtVzOvzEL1S3MbuxNkc8M/edit
What is the issue regarding ?
@trimble-oss/modus-web-components
Priority
Medium
What product/project are you using Modus Components for ?
e-Builder
What is your team/division name ?
e-Builder
Are you willing to contribute ?
Yes
Are you using Modus Web Components in production ?
yes

Related to https://github.com/trimble-oss/modus/issues/488

https://mui.com/material-ui/react-autocomplete/#asynchronous-requests
Plan is to implement the behavior for "Load on open"

@msankaran0712 To create an issue for updating the Modus styleguide

@acomsto The request has been approved by Modus, and everything is now set for development.


mount options

I am trying to pass mount options to spawn_mount:
info!("options are {:?}", options);
fuse::spawn_mount(fs, &flags.mount_point, &options)?;

running it gives:
INFO:: options are ["nonempty"]
fuse: mountpoint is not empty
fuse: if you are sure this is safe, use the 'nonempty' mount option

Am I doing anything wrong?

ah maybe I need to leave -o in there too


Use compile-time constant for the size of the signal parameters

Address feedback by @pouleyKetchoupp regarding the use of arrays on stack with dynamic size.

Thanks!


[help]: K230 data caching for addr range

Help
I am wondering how to share a memory zone between two CPU cores in SRAM or DDR?
Currently I am using volatile pointers to access the data fields  from two cores in M-mode, but still got different data. I am wondering that the independent CPU caches are causing inconsistency.
Can you please teach if there is any way to set that memory zone as non-cacheable for both cores? if not, do you have any suggestions?

close this as M-mode doesn't have cacheability control.


Move execution to system-config

playbook and roles are moved to system-config (drop from here). Job definition (https://github.com/opentelekomcloud-infra/system-config/blob/main/zuul.d/infra-prod.yaml#L97) is also implemented there. This project stays for the organization description (org folder). Syntax checks stay here and the deploy pipeline get "infra-prod-manage-github" job to apply changes once PR is merged.
role development and tests should be moved into the system-config

Done


fix(theme-default): sidebar begining top items was unchanged after page switch

Summary
https://github.com/web-infra-dev/rspress/assets/18117084/eeffe26f-5e8e-4428-9880-9f7db3bfac29
Related Issue

relate: https://github.com/web-infra-dev/rsbuild/issues/1798
fixes: #770

Checklist

[x] I have added changeset via pnpm run change.
[ ] I have updated the documentation.
[ ] I have added tests to cover my changes.

Nice!


Cleaning up "None" vs "none" instances

@taylor13 @dnadeau4 we have instances of both "None" and "none" in the experiment_id and source_id entries and I think these should be standardised.. @dnadeau4, what tests do you have that expect one or another case?

sub_experiment_id is always none.  So I think we should set everything to none and let None be python's (NULL) instance.


assert len(indices) == len(self) AssertionError

Traceback (most recent call last):
File "tools/train.py", line 198, in
main()
File "tools/train.py", line 193, in main
meta=meta,
File "/media/smn/Elements SE/SoftTeacher-main/ssod/apis/train.py", line 206, in train_detector
runner.run(data_loaders, cfg.workflow)
File "/home/smn/anaconda3/envs/Soft/lib/python3.6/site-packages/mmcv/runner/iter_based_runner.py", line 117, in run
iter_loaders = [IterLoader(x) for x in data_loaders]
File "/home/smn/anaconda3/envs/Soft/lib/python3.6/site-packages/mmcv/runner/iter_based_runner.py", line 117, in
iter_loaders = [IterLoader(x) for x in data_loaders]
File "/home/smn/anaconda3/envs/Soft/lib/python3.6/site-packages/mmcv/runner/iter_based_runner.py", line 23, in init
self.iter_loader = iter(self._dataloader)
File "/home/smn/anaconda3/envs/Soft/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 359, in iter
return self._get_iterator()
File "/home/smn/anaconda3/envs/Soft/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 305, in _get_iterator
return _MultiProcessingDataLoaderIter(self)
File "/home/smn/anaconda3/envs/Soft/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 944, in init
self._reset(loader, first_iter=True)
File "/home/smn/anaconda3/envs/Soft/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 975, in _reset
self._try_put_index()
File "/home/smn/anaconda3/envs/Soft/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 1209, in _try_put_index
index = self._next_index()
File "/home/smn/anaconda3/envs/Soft/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 512, in _next_index
return next(self._sampler_iter)  # may raise StopIteration
File "/home/smn/anaconda3/envs/Soft/lib/python3.6/site-packages/torch/utils/data/sampler.py", line 226, in iter
for idx in self.sampler:
File "/media/smn/Elements SE/SoftTeacher-main/ssod/datasets/samplers/semi_sampler.py", line 187, in iter
assert len(indices) == len(self)
AssertionError

Maybe you can refer to this link https://github.com/microsoft/SoftTeacher/issues/109#issuecomment-976335577


Light-flash pattern and actions for potential hardware issue(s)

New light-flash pattern for potential hardware issue(s). Actions to verify. Call to action to contact support if issue & light-flash pattern persist.

@DaniHalfin @Teresa-Motiv - Heads up, Luke is on my team and this is a good update.

@lukeoreilly - merged. If you can, please go through the private repo in the future. Thanks!


Refactor JSON and CSV logic in AnnotationCategoriesController to new class methods of AnnotationCategory model

Motivation and Context

In AnnotationCategoriesController.rb there is some code related to creating JSON and CSV representations of AnnotationCategory data which could have been refactored into the model class for better code modularity, readability, and more intuitive code design (i.e. operations on data fit into the classes that handle data). Also, there was just one method in AnnotationCategoriesHelper whose logic also belongs more in the AnnotationCategory model as a static class method because it also has to do with data conversion.
Your Changes

Description:

refactored json logic in AnnotationCategoriesController#index to new class method AnnotationCategory.to_json
refactored csv logic in AnnotationCategoriesController#download to new class method AnnotationCategory.to_csv
moved AnnotationCategoriesHelper#prepare_for_conversion logic to AnnotationCategory.prepare_for_conversion
deleted AnnotationCategoriesHelper (as there was nothing left in it and it was redundant)

Type of change (select all that apply):

[X] Refactoring (internal change to codebase, without changing functionality)

Testing

Manually tested functionality of viewing as JSON and downloading as CSV on the UI.
Ran full RSpec test suite to ensure that existing functionality in the codebase was not affected from the refactor.

Checklist

[X] I have performed a self-review of my own code.
[X] I have verified that the pre-commit.ci checks have passed.
[X] I have verified that the CI tests have passed.
[ ] I have reviewed the test coverage changes reported on Coveralls.
[ ] I have added tests for my changes.
[ ] I have updated the Changelog.md file.
[ ] I have made changes to the documentation and linked to that pull request below.

Pull request to make documentation changes (if applicable)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-4 of 20 (80.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.002%) to 91.692%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/controllers/annotation_categories_controller.rb
1
2
50.0%

app/models/annotation_category.rb
15
18
83.33%

Files with Coverage Reduction
New Missed Lines
%

app/controllers/annotation_categories_controller.rb
1
93.71%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
38811

Relevant Lines:
41706

💛  - Coveralls


 However, at said level I just get stat increases instead.
eg. Secret Report says I'll acquire Fire at Level 8 but at Level 8 I get AP Up instead

Actually upon further investigation of the spoiler log it seems like I'm just not being awarded the magic at those levels.
Seed name is Lukey all settings default

If you could attach a zip of your seed, it will be easier for us to diagnose, thanks!


allow passing in a parsd dictionary to the tokenizer

I would like to compress the tiktoken dictionary in copilot chat, as
they're pretty big (especially with 200k.) This allows us to manually
parse the file ourselves instead of having to pass it in to be read in
its standard format.

Build failure seems unrelated


Remove hard-coded Java version in security scan

Hard-coding Java 11 is a bad idea since we plan to EOL it in the next few months.

@strangelookingnerd A number of these YML files are inconsistent. Can you please normalize them to avoid hard-coding a Java version in any of these YML files:
apache-httpcomponents-client-4-api-plugin
      java-version: 21 # What version of Java to set up for the build.
--
asm-api-plugin
      java-version: 11 # What version of Java to set up for the build.
--
authentication-tokens-plugin
      java-version: 21 # What version of Java to set up for the build.
--
blueocean-plugin
      java-version: 21 # What version of Java to set up for the build.
--
branch-api-plugin
      java-version: 21 # What version of Java to set up for the build.
--
cloudbees-folder-plugin
      java-version: 21 # What version of Java to set up for the build.
--
commons-lang3-api-plugin
      java-version: 11
--
commons-text-api-plugin
      java-version: 11
--
configuration-as-code-plugin
      java-version: 21 # What version of Java to set up for the build.
--
credentials-plugin
      java-version: 17 # What version of Java to set up for the build.
--
dashboard-view-plugin
      java-version: 17  # What version of Java to set up for the build.
--
docker-workflow-plugin
      java-version: 21 # What version of Java to set up for the build.
--
eddsa-api-plugin
      java-version: 11 # What version of Java to set up for the build.
--
favorite-plugin
      java-version: 17 # What version of Java to set up for the build.
--
git-client-plugin
      java-version: 21 # What version of Java to set up for the build.
--
git-plugin
      java-version: 21 # What version of Java to set up for the build.
--
git-server-plugin
      java-version: 17 # What version of Java to set up for the build.
--
gson-api-plugin
      java-version: 11 # What version of Java to set up for the build.
--
htmlpublisher-plugin
      java-version: 17 # What version of Java to set up for the build.
--
instance-identity-plugin
      java-version: 17 # What version of Java to set up for the build.
--
javadoc-plugin
      java-version: 21 # What version of Java to set up for the build.
--
joda-time-api-plugin
      java-version: 11 # What version of Java to set up for the build.
--
json-api-plugin
      java-version: 11 # What version of Java to set up for the build.
--
json-path-api-plugin
      java-version: 11 # What version of Java to set up for the build.
--
junit-plugin
      java-version: 21 # What version of Java to set up for the build.
--
kubernetes-credentials-plugin
      java-version: 21 # What version of Java to set up for the build.
--
kubernetes-plugin
      java-version: 21 # What version of Java to set up for the build.
--
mailer-plugin
      java-version: 17 # What version of Java to set up for the build.
--
matrix-project-plugin
      java-version: 17 # What version of Java to set up for the build.
--
metrics-plugin
      java-version: 21 # What version of Java to set up for the build.
--
oauth-credentials-plugin
      java-version: 21 # What version of Java to set up for the build.
--
pipeline-input-step-plugin
      java-version: 21 # What version of Java to set up for the build.
--
pipeline-maven-plugin
      java-version: 11 # What version of Java to set up for the build.
--
saml-plugin
      java-version: 11 # What version of Java to set up for the build.
--
ssh-agent-plugin
      java-version: 11
--
ssh-agents-plugin
      java-version: 17 # What version of Java to set up for the build.
--
support-core-plugin
      java-version: 17 # What version of Java to set up for the build.
--
token-macro-plugin
      java-version: 17 # What version of Java to set up for the build.
--
view-job-filters-plugin
      java-version: 17 # What version of Java to set up for the build.
--
workflow-api-plugin
      java-version: 21 # What version of Java to set up for the build.
--
workflow-job-plugin
      java-version: 21 # What version of Java to set up for the build.

@strangelookingnerd A number of these YML files are inconsistent. Can you please normalize them to avoid hard-coding a Java version in any of these YML files:

I will look into it. My template uses the default, however I left the property and its description in place (commented-out). I thought this allows maintainers to change it more easily without consulting the documentation first.
I downgraded some builds because they simply did not run with Java 17 / 21.

This build obviously didn't need Java 11 to be hard-coded and I suspect almost all of the above are the same. I agree that it is nice to leave the defaults commented out to allow for customization. When there is a customization, the reason for the customization can be provided in a comment. A customization without a reason should not be retained.

Thanks for your PR.
I wanted to open a PR on https://github.com/jenkinsci/plugin-modernizer-tool to perform the cleanup (The GSoC 2024 project on openrewrite)
But it looks there is a bug on the original recipe to comment out a YAML property
https://github.com/openrewrite/rewrite/pull/4392

This build obviously didn't need Java 11 to be hard-coded and I suspect almost all of the above are the same. I agree that it is nice to leave the defaults commented out to allow for customization. When there is a customization, the reason for the customization can be provided in a comment. A customization without a reason should not be retained.

I did as requested. I'll keep an eye open for other dereviations.

I did as requested. I'll keep an eye open for other dereviations.

Thanks! Here are some more that I found:
./active-choices-plugin
      java-version: 11
--
./adoptopenjdk-plugin
      java-version: 11
--
./amazon-ecr-plugin
      java-version: 17  # What version of Java to set up for the build.
--
./amazon-ecs-plugin
      java-version: 17
--
./android-emulator-plugin
      java-version: 17 # What version of Java to set up for the build.
--
./ansicolor-plugin
      java-version: 11
--
./archetypes
      java-version: 17 # What version of Java to set up for the build.
--
./authorize-project-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./aws-beanstalk-publisher-plugin
      java-version: 11
--
./azure-ad-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./azure-artifact-manager-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./azure-container-agents-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./azure-cosmosdb-plugin
      java-version: 17 # What version of Java to set up for the build.
--
./azure-credentials-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./azure-keyvault-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./azure-storage-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./badge-plugin
      java-version: 17 # What version of Java to set up for the build.
--
./build-monitor-plugin
      java-version: 11
--
./build-name-setter-plugin
      java-version: 17 # What version of Java to set up for the build.
--
./build-user-vars-plugin
      java-version: 11
--
./categorized-view-plugin
      java-version: 11
--
./chucknorris-plugin
      java-version: 11
--
./claim-plugin
      java-version: 11 # What version of Java to set up for the build.
--
./cloud-stats-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./commons-httpclient3-api-plugin
      java-version: 11
--
./compact-columns-plugin
      java-version: 17  # What version of Java to set up for the build.
--
./conditional-buildstep-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./console-column-plugin
      java-version: 17 # What version of Java to set up for the build.
--
./cppcheck-plugin
      java-version: 11
--
./crowd2-plugin
      java-version: 11 # What version of Java to set up for the build.
--
./custom-folder-icon-plugin
      java-version: 17 # What version of Java to set up for the build.
--
./database-sqlite-plugin
      java-version: 11
--
./dependency-check-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./design-library-plugin
      java-version: 11 # What version of Java to set up for the build.
--
./dimensionsscm-plugin
      java-version: 11 # What version of Java to set up for the build.
--
./docker-java-api-plugin
      java-version: 11
--
./docker-plugin
      java-version: 11
--
./doclinks-plugin
      java-version: 11
--
./elastic-axis-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./email-ext-recipients-column-plugin
      java-version: 11 # What version of Java to set up for the build.
--
./emailext-template-plugin
      java-version: 11
--
./embeddable-build-status-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./envinject-api-plugin
      java-version: 11
--
./envinject-plugin
      java-version: 17 # What version of Java to set up for the build.
--
./exclusion-plugin
      java-version: 11
--
./extended-read-permission-plugin
      java-version: 11 # What version of Java to set up for the build.
--
./extensible-choice-parameter-plugin
      java-version: 11
--
./extra-tool-installers-plugin
      java-version: 11
--
./file-leak-detector-plugin
      java-version: 11
--
./file-operations-plugin
      java-version: 11
--
./git-bisect-plugin
      java-version: 11
--
./github-oauth-plugin
      java-version: 11
--
./github-pr-coverage-status-plugin
      java-version: 11
--
./gitlab-oauth-plugin
      java-version: 11
--
./gitlab-plugin
      java-version: 17 # What version of Java to set up for the build.
--
./git-parameter-plugin
      java-version: 11
--
./gravatar-plugin
      java-version: 17
--
./groovy-events-listener-plugin
      java-version: 17  # What version of Java to set up for the build.
--
./http-request-plugin
      java-version: 11
--
./ivy-plugin
      java-version: 11
--
./jdepend-plugin
      java-version: 11
--
./jenkins-keycloak-plugin
      java-version: 11 # What version of Java to set up for the build.
--
./jira-ext-plugin
      java-version: 11
--
./jnr-posix-api-plugin
      java-version: 11
--
./jobcacher-plugin
./.github/workflows/jenkins-security-scan.yaml:      java-version: 11
--
./job-config-history-plugin
      java-version: 17 # What version of Java to set up for the build.
--
./job-dsl-plugin
      java-version: 11
--
./junit-attachments-plugin
      java-version: 17 # What version of Java to set up for the build.
--
./localization-support-plugin
      java-version: 11
--
./lockable-resources-plugin
      java-version: 11
--
./logstash-plugin
      java-version: 17
--
./m2release-plugin
      java-version: 11
--
./mail-watcher-plugin
      java-version: 17
--
./matrix-combinations-plugin
      java-version: 11
--
./maven-metadata-plugin
      java-version: 11
--
./maven-repository-plugin
      java-version: 11
--
./mercurial-plugin
      java-version: 17 # What version of Java to set up for the build.
--
./monitoring-plugin
      java-version: 17 # What version of Java to set up for the build.
--
./multibranch-action-triggers-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./nexus-artifact-uploader-plugin
      java-version: 11
--
./nodelabelparameter-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./office-365-connector-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./oic-auth-plugin
      java-version: 11 # What version of Java to set up for the build.
--
./parameterized-scheduler-plugin
      java-version: 11
--
./parameterized-trigger-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./pipeline-agent-build-history-plugin
      java-version: 11 # What version of Java to set up for the build.
--
./pipeline-aggregator-view-plugin
      java-version: 11 # What version of Java to set up for the build.
--
./platformlabeler-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./postgresql-fingerprint-storage-plugin
      java-version: 11 # What version of Java to set up for the build.
--
./priority-sorter-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./publish-over-cifs-plugin
      java-version: 11 # What version of Java to set up for the build.
--
./publish-over-plugin
      java-version: 11 # What version of Java to set up for the build.
--
./publish-over-ssh-plugin
      java-version: 17 # What version of Java to set up for the build.
--
./remote-file-plugin
      java-version: 11
--
./resource-disposer-plugin
      java-version: 11
--
./role-strategy-plugin
      java-version: 11 # What version of Java to set up for the build.
--
./run-condition-plugin
      java-version: 11
--
./saferestart-plugin
      java-version: 11 # What version of Java to set up for the build.
--
./schedule-build-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./scmskip-plugin
      java-version: 11 # What version of Java to set up for the build.
--
./scriptler-plugin
      java-version: 17 # What version of Java to set up for the build.
--
./servicenow-cicd-plugin
      java-version: 11
--
./simple-theme-plugin
      java-version: 17  # What version of Java to set up for the build.
--
./skip-notifications-trait-plugin
      java-version: 11 # What version of Java to set up for the build.
--
./slack-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./sloccount-plugin
      java-version: 11
--
./ssh2easy-plugin
      java-version: 11
--
./swarm-plugin
      java-version: 11
--
./testng-plugin-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./text-finder-plugin
      java-version: 11
--
./theme-manager-plugin
      java-version: 11
--
./thin-backup-plugin
      java-version: 17 # What version of Java to set up for the build.
--
./throttle-concurrent-builds-plugin
      java-version: 11
--
./versioncolumn-plugin
      java-version: 21 # What version of Java to set up for the build.
--
./webhook-step-plugin
      java-version: 11
--
./ws-cleanup-plugin
      java-version: 11
--
./xunit-plugin
      java-version: 11

Thank you very much! I have merged the PRs for critical plugins. If I have time I will try to go through the remaining long-tail plugins as well.

For the Sonargraph Plugin, if I remove the Java version it defaults to Java 8 and that does not work. Higher Java versions should be ok...


Polling Interval setting

The recommendations may be too narrow for some situations and don't give enough buffer for false positives.
If you are using ADFS in production I would recommend Polling Interval of 30 - 180 Seconds depending on how big the farm. And a consecutive failure  of 10 - 30. This will take into account network issues and high volume traffic scenarios.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 679f53fd-e671-c4a5-6f6a-b50784019282
Version Independent ID: 10735486-07a5-829c-4523-e11b7d722826
Content: Configure load balancing and outbound rules by using the Azure portal - Azure Load Balancer
Content Source: articles/load-balancer/configure-load-balancer-outbound-portal.md
Service: load-balancer
GitHub Login: @asudbring
Microsoft Alias: allensu

@D4-AzIdentity , We are looking into this query and will update you as soon as possible.

@D4-AzIdentity , Appreciate your patience. Thanks for sharing your feedback. The document aims at demonstrating key concepts and provides step-step instructions on how to configure outbound rules in Standard Load Balancer with a simple scenario. You can configure the probes based on your application needs with custom probing options.
Here is a ref doc for you reference in configuring /adfs/probe.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


[Toolbar] Theme mixins.toolbar has the media-query styles merged in the wrong order using system

Duplicates

[X] I have searched the existing issues

Possibly related (but v4.2.0) https://github.com/mui/material-ui/issues/16528
Latest version

[X] I have tested the latest version

Current behavior 😯
With the following code:
<Box sx={theme => theme.mixins.toolbar} />

The box gets the height corresponding to the min-height: 0px media query in all viewports.
Expected behavior 🤔
It should get the correct height depending on the current viewport width. The media-query related styles should be merged in the correct order such that for instance: min-height: 600px has higher priority than min-height: 0px.
Steps to reproduce 🕹
https://codesandbox.io/s/mystifying-hoover-yf2ehh?file=/src/App.js
Context 🔦
I'm trying to have an empty element take as much height as the toolbar for my application. My sidebar has a header and it should be aligned with the main toolbar.
Your environment 🌎
Reproducible on all browsers.

Hi, indeed the order of declaration differs in these cases. Looks like a bug.

I looked into this. But I could not find any solution.
Just posting my investigation if it helps. The following approaches work:

With raw media queries in sx prop which the theme.mixins.toolbar gets converted into (very much not ideal approach):

<Box
  sx={(theme) => ({
    border: 1,
    minHeight: 56,
    '@media (min-width: 0px) and (orientation: landscape)': {
      minHeight: 48,
    },
    '@media (min-width: 600px)': {
      minHeight: 64,
    },
  })}
>
  With mixins.toolbar
</Box>;

With the styled API (would help as a workaround until the issue is solved):

const StyledBox = styled(Box)(({ theme }) => ({
  ...theme.mixins.toolbar,
  border: '1px solid',
}));

;

While the following approach does not work:
<Box
  sx={(theme) => ({
    border: 1,
    minHeight: 56,
    [theme.breakpoints.up('sm')]: {
      minHeight: 64,
    },
    [`${theme.breakpoints.up('xs')} and (orientation: landscape)`]: {
      minHeight: 48,
    },
  })}
>
  With mixins.toolbar
</Box>;

Maybe this investigation could help in narrowing down that it is an issue with the sx prop for theme.mixins.toolbar default theme.

Could be related to #27532


Close Unbound stats socket after each scrape

Close the the unbound socket explicitly, at the end of CollectFromSocket, rather than relying on GC to close it for us.
I also made the same change to the unused (presumably left for debugging) CollectFromFile function, for consistency

LGTM. As a slight clarification, without the explicit Close: there is no guarantee the file descriptor will ever be closed. There are some serious sharp edges to finalizers in Go: https://golang.org/pkg/runtime/#SetFinalizer
This PR is the correct option.

LGTM

LGTM

LGTM

Thanks @mattgray! This was fixed in https://github.com/letsencrypt/unbound_exporter/pull/28.


How to set time range?

Thanks for the awesome TTRangeSlider. But can you tell  me how to set time range?
like 10:00 AM to 10:00 PM

Try to format your time from 1-24 and change the label to AM PM format like 10 AM mean 10 and 10PM mean 22

what is the delegate to update the label @run time..... why can't you just simply add time feature by default. its very useful.

I would go with what @fiantinangon said above and set your range to be 1-24 then use the numberFormatterOverride property (it's not a delegate) to set a number formatter that converts numbers to time format (keeping in mind device locale)
I do understand it would be a useful feature but i don't want to add it to the control because it's too specific - the numberFormatterOverride is there for these cases to allow you to customise it without complicating the control's set of features

Thanks for the kind comments about the control though! :-)


chore(e2e): move e2e tests from AppVeyor windows to Travis windows

Set prettier linebreak-style to 0 and force endOfLine setting in prettier to lf to work around the issue with prettier on Windows vs Unix.
Add text=auto eol=lf to force jest snapshot always uses lf setting for end of line.
Force endOfLine setting in prettier to lf.
Remove AppVeyor badge.
Remove all references in codes related to AppVeyor.

Pull Request Test Coverage Report for Build 4022

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.72%

Totals

Change from base Build 4020:
0.0%

Covered Lines:
1087

Relevant Lines:
1132

💛  - Coveralls


rasa test nlu comparison mode

Proposed changes:

--config argument now supports multiple configs in rasa test nlu
If multiple are found, the respective models are trained and tested against multiple exclusion percentages
All models, train/test splits, graphs and evaluation results are saved to a directory

Status (please check what you already did):

[x] made PR ready for code review
[x] added some tests for the functionality
[x] updated the documentation
[x] updated the changelog
[ ] reformat files using black (please check Readme for instructions)

The errors should not show up anymore on rasa test nlu. The schema was expecting a list for the pipeline. Updated it so that also string is allowed.

@tabergma There are currently some merge conflicts. I try to review it today.


[regression][linux][build] 1dd3730 cause build error

System information

CPU information(cat /proc/cpuinfo | grep "model name" | uniq):
GPU information(lspci -nn | grep -E 'VGA|isplay):
Display server if rendering to display (X or wayland):
Good VPL runtime version?
Bad VPL runtime version?
Underlying media stack (libva/libgmm/media-driver) version?

Issue behavior
Describe the current behavior
Describe the expected behavior
Catch build error on current version: 0ac1151a
last build passed version is: 175cd3ee

bisect build error from: 1dd37303

verify on 66851a7 + #235 build error fixed
wait for PR merge to close this issue

verify on 276868714b54 without build error, close issue


Undefined is not an object

I am getting the following error TypeError: undefined is not an object (evaluating 'this.content_elem.lastChild.style.height = data.bottom_offset + 'px'')
Stack trace:
InsertToDOM
scrollEv
I have a list of 7196 elements. If I slice the list to only 200 elements, Clusterize works fine. But with the full size, I get the error above.

Hey
Can I see demo at codepen please?

how do you slice?
https://codepen.io/NeXTs/pen/jaYMMK

Hi Denis, here's the short demo https://codepen.io/kempkens/pen/jaYwoY
It's pretty much mimicking how we use it in our codebase. I don't slice, I was doing it just to see if the problem is related to the size of the list. Thanks!

https://codepen.io/NeXTs/pen/mqpMxw
Those classnames are quite important
Also I've included clusterize's styles
Are you sure problem was in that?

I just copied your pen over and it still wasn't working for me until I copied the css resource as well (https://cdnjs.cloudflare.com/ajax/libs/clusterize.js/0.18.0/clusterize.css). With that included it works.
I'm using npm to include clusterize dependency in my package.json:
"devDependencies": {
...
"clusterize.js": "0.18.0",
...
}
Anything else I should be adding to include the css as well? Thanks so much!

Hi Denis, I added the stylesheet, but it didn't help solve the problem. I ended up copying the js files and debugging it. In the end it turned out there was an extra white space after the closing li tag, which caused the lastChild element to be a textObject and not the list object, which resulted in the style property being undefined. I fixed my template and now everything works perfectly. Thanks for your help!

Probably I should .trim() rows to avoid such cases


Add new CLI sub-command result

Fixes #112.

Thank you so much @mmdbalkhi for working on this. The past few weeks have been extremely busy and chaotic for us so I really appreciate that you put up with me and continued improving this PR as needed. We're lucky to have you as a contributor. ❤


I have hosted the backend on Render , but due to inactivity the website has a delay , any solutions to this ??

yeah i have many website  that i hosted on render including backend but the render as sleep time after 30 - 60 min of inactive so the application get roll off and takes 60 - 120 seconds to roll on. So don't deploy backend on render use vercel.vercel is best for backend deployment both backend and frontend.So Vercel is best.

or you can create an automated script that not only hits your current but all of your repositories API after a certain amount decided by you.

I think writing script for Vercel is great but if you deploy the backend on Vercel the deployment get automatically when the main branch /server get update no need to write script it's easy.correct me if I am wrong.

You could host the backend on vercel ,and complete it by creating a vercel.json file then it gets automatically deployed as soon as you update your hosted dev branch.

assign this issue to me under gssoc'24 @Tushtiadlakha . I have faced the same issue, i can fix it on render itself. We can use something like uptime bot.


Write tests and run them on Travis CI

Thoughts?

Tests added at commit https://github.com/AlienVault-Labs/OTX-Python-SDK/commit/9205a435755f518fe19971b85d9b65f46f50e26b by Bill Smartt.
This issue can be closed.


Provide a way to test logical equality

Description
At the moment, there's no easy to assert that a deserialized record is logically the same as its original one. This mostly due to the fact that the origin and the deserialized object are different implementations. This is to be expected, since any implementation could override equals and hashCode, for good reasons. However, as one of the main use cases of this library is writing end to end tests, it would be very useful to be able to assert logical equality between the original record and the deserialized one, including recursive comparison.
I think the safest option would be to write assertion code, as opposed to overwriting equals and hashCode.
// given
final Record<?> record = ...;

// when
final String serialized = MAPPER.writeValueAsString(record);
final Record<?> deserialized = MAPPER.readValue(serialized, new RecordTypeReference<>());

// then
assertThat(deserialized).isLogicallyEqualTo(record);

At the moment there's no easy alternative - you can try using the assertions provided by zeebe-protocol-asserts, but you still have to manually compare each property.

Solved - clone your record using ImmutableRecordCopier, and you can then easily compare equality.


Add className to make customization easier

This pull request adds CSS class to make customization easier from the end user's code (for example, changing overflow behavior).
Let me know if it makes sense, and if you can think of a better name than dotdotdot for the class.

@krzysztofczernek you can already pass additional className to Dotdotdot component, so there is probably no need for adding such redundant class:
<Dotdotdot className="my-custom-class">
  ...
</Dotdotdot>

I must agree with @kkwiatkowski. Thank you for your effort :)


Add Sematic Versioning Documentation to Project

We just want to document in the project sematic versioning

We added documentation for semantic versioning


Update fs2-core to 3.2.9

Updates co.fs2:fs2-core from 3.2.8 to 3.2.9.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "co.fs2", artifactId = "fs2-core" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

@Mergifyio rebase


Eat operation not support error for change version on DB

Currently workflow.getVersion will always add an UpsertWorkflowSearchAttributes event for searchable change version. While without visibility on Elasticsearch, cadence server will failed when process transfer task with error: "Operation not support. Please use on ElasticSearch".
This PR change the error to an no-op for searchable change version.

Coverage increased (+0.1%) to 67.929% when pulling 98ee710d0f2bec80815725dd6668aaf68941607c on eserr into 7cd172469e485f0d2f335f4fe0800b1c207b0be4 on master.


[BUG][iOS] react-native-clarity is not using the latest version of Clarity

Describe the Bug
https://github.com/microsoft/clarity-apps/issues/59
This issue also occurs in React Native.
I would like to upgrade Clarity to version 2.1.0. However, the latest version of react-native-clarity (3.0.1) is currently using Clarity 1.0.0. I believe the react-native-clarity.podspec file should be updated as follows:
- s.dependency "Clarity", '1.0.0'
+ s.dependency "Clarity", '2.1.0'

Since this code is not present in the repository, I am submitting this as an issue instead.
Repro Steps
X
Expected Behavior
I’m not sure if any modifications will be needed on the TypeScript side for the native bridge.
Screenshots
X
Project Info
react-native-clarity (3.0.1)
Platform/Framework Info

Clarity Version (1.0.0)
react-native-clarity (3.0.1)

Additional Context
X

@gronxb Thanks for reporting this!
We've just released a new version of react-native-clarity, 3.0.2, which internally uses latest Clarity versio,n 2.1.0. This should resolve the issue you're facing.
Please update your project to use react-native-clarity version 3.0.2, and let us know if you encounter any further problems.

@gronxb We recommend upgrading to version 3.0.3 instead as it includes more fixes.


Controller node should be tagged appropriately

Apparently there are some well-known-but-not-documented-tags which are taken into consideration by AWS cloud provide, one example of it would be:
https://github.com/kubernetes/kubernetes/pull/41702/files#diff-07ba008af9c76b0539556ff7fde3105eR162
so we should follow the pattern and tag our nodes

Thanks as always @redbaron 👍
After looking into the code, "kubernetes.io/role/master" and "k8s.io/role/master" referred in the PR you've shared are only tags seems to be used as of today.
So just let's tag our with those.

Hi @redbaron @mumoshu
I'm facing an error when I fetch the instance data and store it into mongodb. The dotted field "kubernetes.io/role/master" is not valid for storage
For me this tag does not make any sense, but an error ...
Since the value of this tag is empty, what do you think about tagging with role: kubernetes.io/role/master or something like that?

@zhangtiny123 controllers are tagged with tag expected by AWS cloud provider code in Kubernetes, so we can't change it

@redbaron  Could you share the reference page about this expectation?

look at the link in the first message

@zhangtiny123 As @redbaron kindly described, we don't seem to be able to fix/avoid it from k8s side.
AFAIK, you'd need to flatten retrieved object before updating MongoDB with them like mentioned in a SO question here so that you can still query your MongoDB by something like  db.find({'node.spec.labels.kubernets.io/role/master': ''})?

@mumoshu Thanks for your suggestion, but it seems not fit my situation...
Currently I just delete the tag kubernetes.io/role/master from my cluster manually, since it seems there's no one else reference the tag, and everything looks OK , but is there any hidden danger?

@zhangtiny123 , just a heads up, that there is new tagging scheme in Kube 1.6, where ALL resources are tagged with kubernetes.io/cluster/<CLUSTER_NAME> , and you better not to remove any of those tags, otherwise at least LoadBalancer services wont be able to create ELBs

@zhangtiny123 Thanks for the reply.
Just a quick thought but can you script to replace every dot with a hyphen(-) or maybe underscore(_) after you've fetched the instance data? so that dots on original keys won't affect MongoDB

@mumoshu Thanks man, good idea !
@redbaron I've already add it back... thanks for your patience


Alerts behind other hud elements

Not sure if this is an issue with the outlaw alert or with other elements of our hud, but the alerts are showing behind other things. I've attached a picture of an example.

Not sure if this is an issue with the outlaw alert or with other elements of our hud, but the alerts are showing behind other things. I've attached a picture of an example.

Just start the alert system after the HUD or before

And you can join his discord and get support there

Thanks, loading it after the hud worked!


CI test flake: ../cilium/cilium: Command not found when building docs.

Looks like building cilium/cilium succeeds, but cmdref step can’t find it:
18:03:14     runtime: make[1]: Entering directory '/home/vagrant/go/src/github.com/cilium/cilium/cilium'
18:03:14     runtime: go build -i -ldflags '-X "github.com/cilium/cilium/pkg/version.Version=1.0.0-rc9 f0145341d 2018-04-12T17:45:28+00:00 go version go1.9.3 linux/amd64"' -tags lockdebug -o cilium
18:03:25     runtime: make[1]: Leaving directory '/home/vagrant/go/src/github.com/cilium/cilium/cilium'
...
18:04:06     runtime: MAKE=make contrib/scripts/check-cmdref.sh
18:04:06     runtime: make[1]: Entering directory '/home/vagrant/go/src/github.com/cilium/cilium/Documentation'
18:04:06     runtime: # We don't know what changed so recreate the directory
18:04:06     runtime: rm -rvf /tmp/tmp.iD8CI6DRVV/cilium*
18:04:06     runtime: ../cilium/cilium cmdref -d /tmp/tmp.iD8CI6DRVV
18:04:06     runtime: make[1]: ../cilium/cilium: Command not found
18:04:06     runtime: Makefile:35: recipe for target 'cmdref' failed
18:04:06     runtime: make[1]: *** [cmdref] Error 127
18:04:06     runtime: make[1]: Leaving directory '/home/vagrant/go/src/github.com/cilium/cilium/Documentation'
18:04:06     runtime: Makefile:269: recipe for target 'postcheck' failed
18:04:06     runtime: make: *** [postcheck] Error 2
18:04:06 The SSH command responded with a non-zero exit status. Vagrant
18:04:06 assumes that this means the command failed. The output for this command
18:04:06 should be in the log above. Please read the output to determine what
18:04:06 went wrong.
18:04:06 time="2018-04-12T18:04:06Z" level=error msg="Error starting VM" error="exit status 1"
18:04:06
18:04:06 • Failure in Spec Setup (BeforeEach) [201.815 seconds]
18:04:06 RuntimeValidatedChaos [BeforeEach]
18:04:06 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:280
18:04:06   Endpoint recovery on restart
18:04:06   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:312
18:04:06
18:04:06   error starting VM "runtime": exit status 1
18:04:06
18:04:06   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/test_suite_test.go:155
18:04:06 ------------------------------
18:04:06 SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
18:04:06
18:04:06 Summarizing 1 Failure:
18:04:06
18:04:06 [Fail] [BeforeEach] RuntimeValidatedChaos Endpoint recovery on restart
18:04:06 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/test_suite_test.go:155
18:04:06
18:04:06 Ran 1 of 274 Specs in 201.817 seconds
18:04:06 FAIL! -- 0 Passed | 1 Failed | 0 Pending | 273 Skipped --- FAIL: TestTest (201.82s)
18:04:06 FAIL
18:04:06
18:04:06 Ginkgo ran 1 suite in 4m12.377176492s
18:04:06 Test Suite Failed

Did not reproduce in the next build.

@jrajahalme this looks like a compilation error, do you have the full log of this one?

@jrajahalme please link the build where this occurred so we can see more logs. Thanks!


Add pre-push hook for pytest

Add hook for pytest, a python testing framework.
Closes #462.

Looks good to me. I'm happy to merge once you get the tests passing.
Thanks @proinsias!

@trotzig – thanks for the help. I have the tests passing locally. Not sure what's going on with the Travis build. I'll keep investigating.

Yeah, don't know what's up with that. It's the jruby one that's failing, but it doesn't look like it's related to your change. I think this is safe to ignore. I'll make sure to follow up if this continues to be a problem post-merge.


Move dat into a 'daemon' process

This PR moves dat's networking stack and the folder-sync logic into a separate process (the "dat daemon"). The database and web-api implementations remain in the main process, and call out to the daemon via RPC.

Published 3.0.0


parser: support more analyze options

What problem does this PR solve?
Support more analyze options.
What is changed and how it works?
Add new syntax like analyze table t with 4 buckets, 4 topn, 4 cmsketch width, 4 cmsketch depth.
Check List
Tests

Unit test

Code changes

Has exported function/method change

Side effects

None

Related changes

Need to update the documentation

For https://github.com/pingcap/tidb/pull/11278

@lzmhhh123 It does not matter if the internal implementation changed as long as the syntax is the same.

@lamxTyler CI failed, PTAL

@eurekaka It is expected since it removed some asts, that is it requires the tidb version of https://github.com/pingcap/tidb/pull/11278.


Support installing Datalad with brew

Datalad is in Homebrew now, so datalad-installer can now install it with brew.

Codecov Report

Merging #23 (ac80365) into master (96f9e03) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   65.82%   65.86%   +0.03%
==========================================
  Files           1        1
  Lines         910      911       +1
  Branches      174      174
==========================================
+ Hits          599      600       +1
  Misses        257      257
  Partials       54       54

Impacted Files
Coverage Δ

src/datalad_installer.py
65.86% <100.00%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f9e03...ac80365. Read the comment docs.

sweet! thanks!

Looking over the formula, I didn't spot p7zip in the dependency list (although I may have looked into the wrong places). It is available via brew, as far as I know. Does anything speak against adding this dependency in the brew formula?


Install CAPI task for controller via CLI

Issue #, if available:
Description of changes:
Install CAPI task for controller via CLI
Testing (if applicable):

unit tests

Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


thin-edge health-check not functioning when mqtt bind address is changed

Describe the bug
thin-edge health-check not functioning when mqtt bind address is changed

To Reproduce
Preconditions

thin-edge is installed on DUT
DUT is connected to c8y
tedge-mapper-c8y.service file is updated with WatchdogSec+30
Subscribed to tedge/health tedge mqtt sub tedge/health/#
The expected payload is received as expected
Unsubdscribed from mqtt with Ctrl+c

Steps to reproduce

Change the MQTT bind address sudo tedge config set mqtt.bind_address XXX.XXX.XXX.XXX
Disconnect from c8y sudo tedge disconnect c8y
Connect to c8y sudo tedge connect c8y
Check the tedge settings tedge config list and observe that the mqtt.bind_address is changed to the address from Step 2
Subscribe to tedge/health tedge mqtt sub tedge/health/#

Observe that no messages will be received
Expected behavior
Health messages to be received as before the bind address change

Screenshots

Environment (please complete the following information):

OS [incl. version]
Hardware [incl. revision]
System-Architecture: Linux raspberrypi 5.15.32-v8+ #1538 SMP PREEMPT Thu Mar 31 19:40:39 BST 2022 aarch64 GNU/Linux
thin-edge.io version 0.7.4

Additional context

Can you tell which services are up on your device? Only tedge-mapper-c8y and tedge-agent?
If you have other services like tedge-mapper-collectd, c8y-log-plugin, those are not managed by tedge connect, if you change the MQTT address, you need to restart those services. Otherwise, their mqtt clients cannot know the address change.

In order to connect to thin-edge MQTT bus, you have to use the external mqtt address
When you configure an external address with:
sudo tedge config set mqtt.external.bind_address XXX.XXX.XXX.XXX

then thin-edge is accessible from two different addresses:

The thin-edge components use the localhost interface.
While child-devices and other systems (for instance the tests) use the mqtt.external.bind_address.

The use of mqtt.bind_address is very specific. This is when a thin-edge component is not deployed on the same host as the mosquitto server. For instance, if the mapper is running in a container, this mapper must be configured with a mqtt.bind_address set to the mqtt.external.bind_address of the main thin-edge box where mosquitto is running.
=> I see this as a documentation bug. A visual representation might help a lot here as suggested by https://github.com/thin-edge/thin-edge.io/issues/1238.

In order the new bind address to be working the relevant service needs to be restarted after change is made.
The How to: https://thin-edge.github.io/thin-edge.io/html/howto-guides/008_config_local_mqtt_bind_address_and_port.html
is outdated and missleading.
My expectation would be that with propper change of the How to guide this bug could be closed

The bug is no longer applicable as of 0.10.0


Add Spark Shuffle Service Support

Enable shuffle service by default by setting spark.shuffle.service.enabled true in spark-defaults.conf.
Also, open port 7337 in container.
https://spark.apache.org/docs/latest/configuration.html#shuffle-behavior

why are we setting non-default configurations for spark? Shouldn't this be something we allow them to enable if they wish.

This is similar to the decision we made regarding the chunk size for data. It's a 'better' default for distributed spark clusters since it makes it more reliable to nodes leaving the cluster. In this case, we can rely on Spark's shuffle system to move data around and not force a re-compute if a node goes away. With our focus on low-pri nodes, I feel this is probably a good default for AZTK.

Additionally, enabling the shuffle service is required for dynamic allocation. And dynamic allocation allows re-scaling of the cluster during Spark application execution.
So without the shuffle service and dynamic allocation enabled by default, resizing your cluster will only affect subsequent jobs.
This is a very large deal for job submission mode, where the spark submits are executed immediately after the master is elected, and potentially before all workers in the cluster are up.

makes sense. thanks guys


Improve PDF Upload Feature

feat: Improve PDF Upload and Processing Functionality

Refactored main.py to dynamically manage vector stores
Implemented robust file handling for PDF uploads
Added explicit file saving mechanism
Cleared previous FAISS index before processing new PDFs
Enhanced error handling in website.py
Resolved issue of persistent first PDF upload
Enabled seamless PDF file replacement

Changes improve the PDF processing workflow by:

Ensuring clean embeddings for each new document
Providing more reliable file upload experience
Adding basic error handling for upload process

LGTM


Q: Proposed workflow for new dependencies

Given a central Dependencies.kt in buildSrc where all dependency coordinates are kept, I came up with the following workflow when a new dependency should be added:
 *  (1) Declare your dependency in `Dependencies.kt`, with the version placeholder, e.g. `const val foo = "org.foo:foo-impl:_"`
 *  (2) Add your dependency in the module where you need it, e.g. `implementation(Dependencies.foo)`
 *  (3) Add a new entry at the end of versions.kt of the form `version.<group-name>..<artifact-name>=<version>`,
 *      e.g. "version.org.foo..foo.impl=1.0-beta-2"

Now I wonder if the plugin could make the third step a little easier, since the shortening / recognition of version strings from versions.properties might not be trivial. Would therefor the following workflow be equally supported? I couldn't get it to work with 0.5.8:
 *  (1) Declare your dependency in `Dependencies.kt`, with the version placeholder, e.g. `const val foo = "org.foo:foo-impl:_"`
 *  (2) Add your dependency in the module where you need it, e.g. `implementation(Dependencies.foo)`
 *  (3) Run `./gradlew refreshVersions` which inserts a new version line at the end of `versions.properties` for your
        dependency of the form `version.<group-name>..<artifact-name>=<version>` and pick the right version

Ok, I must have done something wrong that it didn't work for me out of the box. I watched your talk at https://www.youtube.com/watch?v=y_9Wkd9ZGj0 and it seems as if adding the placeholder maven coordinates should be enough to kick-off dependency resolution and versions.properties updates.


⚠ Bofrost.de has degraded performance

In 74a971c, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 2888 ms

Resolved: Bofrost.de performance has improved in 35ac727 after 3 hours, 47 minutes.


Fix some QoL issues introduced by #19

Changes in #19 introduced a few new edge cases that need to be accounted for:

[ ] Right now, mouse controls for graph panning (middle mouse drag) are handled everywhere. We should restrict that to be inside the graph's Ui.
[ ] The 'new node' dropdown is not clipped to the graph's ui contents.
[ ] The 'new node' dropdown sometimes draws before the window containing the graph, making it invisible.

None of this affects the original mode of operation, where the graph was being drawn as a full-screen CentralPanel.

The 'new node' dropdown is not clipped to the graph's ui contents.

I'm not sure if this might violate assumptions in egui, but I prefer the menu not clipping to the ui. From a consistency standpoint that's how menus usually work (see blender, for instance). From a user standpoint, if they're seeing that menu it's almost always because they are currently using it, so giving it screen real-estate is worthwhile and won't cover something else that they're trying to interact with.

Pull request #40 has imlpemented is going to fix these issues.


Fixed some paths in the docs

Thanks for the contribution. You are welcome to add yourself to CONTRIBUTORS


int[]? model maps as null

PersonRequest.cs:
public int[]? Ids { get; set; } = null;
Swagger Call:
http://localhost:3000/api/person?ids=5&ids=15
Result:
PersonRequest.Ids is null.
Expected array of ints with 5 and 15 as items.

as mentioned in the docs, only scalar values can be bound from query parameters atm. multiple value binding is in the todo list.
in the meantime you could access the query items like so:
public override Task HandleAsync(CancellationToken ct)
{
    var ids = HttpContext.Request.Query["ids"]
        .Select(i=> int.Parse(i));

    return SendAsync(ids);
}

or send the array in the request body.
if someone would like to contribute this feature, please submit a PR.

@nefarius yeah i also don't really like the idea of multiple query params with the same name. it's just a bad design inherited from mvc. that's why i'm not too keen to work on this feature myself before knocking out more important stuff on the todo list ;-)

Isn't ids=5&ids=15 a quite unusual approach to specify a range? Looks to me as you're setting/overwriting the same value again in one query. Wouldn't ids=5,15 or ids=[5,15] or similar make more sense?

It's what swagger does.   The "manual" solution is probably good enough for now tbh

Isn't ids=5&ids=15 a quite unusual approach to specify a range? Looks to me as you're setting/overwriting the same value again in one query. Wouldn't ids=5,15 or ids=[5,15] or similar make more sense?

@nefarius yeah i also don't really like the idea of multiple query params with the same name. it's just a bad design inherited from mvc. that's why i'm not too keen to work on this feature myself before knocking out more important stuff on the todo list ;-)

I thought using the same name for multiple query params is actually what has been done since the beginning of web forms. When you have a select which allows to select multiple values, the values are sent like that... might be a bad design (definitely not mvc's as it predates that significantly)... but at least everything on the internet (should) understand and be able to parse that...


Azure PowerShell label in Article do not have PowerShell command codes.

The article talks about using Azure CLI commands. However, if you view the example codes, they are labeled under Azure PowerShell and not Azure CLI. Commands mentioned under Azure PowerShell are Azure CLI commands and not PowerShell commands.

@mukeshdora
It would be great if you could add a link to the documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!!

Here is the link:
Quickstart: Deploy your first container app with containerapp up | Microsoft Learn

@mukeshdora
I've delegated this to @mukeshdora, a content author, to review and share their valuable insights.


feat: add config file reader for sshnp

@CurtlyCritchlow this PR is for you
- What I did
I added a static method: SSHNPParams.getConfigFilesFromDirectory(); which allows you to read in the config files to an iterable of SSHNPParams objects. This method also accepts an optional directory argument, although it is likely unnecessary to provide as the default should be suitable for our usage.
SSHNPParams is the main object which is used to generate the SSHNP class via SSHNP.fromParams(params);
Example code:
import 'package:sshnoports/sshnp/sshnp.dart';
import 'package:sshnoports/sshnp/sshnp_params.dart';

void main() async {
  /// This is a new method which returns an Iterable of [SSHNPParams] based on the folder it reads
  /// By default it reads from ~/.sshnp/config which is defined in [getDefaultSshnpConfigDirectory()] (in common/utils.dart)
  Iterable<SSHNPParams> cfg = await SSHNPParams.getConfigFilesFromDirectory();

  /// Iterate through the list of SSHNPParams and print some of the info out
  for (var c in cfg) {
    print((c.clientAtSign, c.device, c.localPort));
  }

  /// Create an [SSHNP] object from the first [SSHNPParams] object in the list
  /// Then see bin/sshnp.dart for how to use this appropriately
  SSHNP sshnp = await SSHNP.fromParams(cfg.first);

  // PROGRAM OUTPUT (specific to my machine):
  // (@xavierchanth, playpen, 0)
  // (@xavierchanth, playpen, 2222)
}

- How I did it
- How to verify it

Create your own config files in ~/.sshnp/config (see here for a template of this)
Then run the sample code

- Description for the changelog
feat: add config file reader for sshnp

After adding the write functionality and testing, it duplicated the first config file as expected:
import 'package:sshnoports/common/utils.dart';
import 'package:sshnoports/sshnp/sshnp.dart';
import 'package:sshnoports/sshnp/sshnp_params.dart';

void main() async {
  /// This is a new method which returns an Iterable of [SSHNPParams] based on the folder it reads
  /// By default it reads from ~/.sshnp/config which is defined in [getDefaultSshnpConfigDirectory()] (in common/utils.dart)
  Iterable<SSHNPParams> cfg = await SSHNPParams.getConfigFilesFromDirectory();

  /// Iterate through the list of SSHNPParams and print some of the info out
  for (var c in cfg) {
    print((c.clientAtSign, c.device, c.localPort));
  }

  /// Create an [SSHNP] object from the first [SSHNPParams] object in the list
  /// Then see bin/sshnp.dart for how to use this appropriately
  SSHNP sshnp = await SSHNP.fromParams(cfg.first);

  /// Get the config dir
  var configDir = getDefaultSshnpConfigDirectory(getHomeDirectory()!);

  print('Rewriting first config file to sshnp_test.env');

  await cfg.first.toFile('$configDir/sshnp_test.env');

  print('Reading the files again');
  cfg = await SSHNPParams.getConfigFilesFromDirectory();

  for (var c in cfg) {
    print((c.clientAtSign, c.device, c.localPort));
  }
}

  // OUTPUT:
  // (@xavierchanth, playpen, 0)
  // (@xavierchanth, playpen, 2222)
  // Rewriting first config file to sshnp_test.env
  // Reading the files again
  // (@xavierchanth, playpen, 0)
  // (@xavierchanth, playpen, 0)
  // (@xavierchanth, playpen, 2222)

@CurtlyCritchlow in general the goal with the GUI should be to work with SSHNPParams whenever possible, only converting it to the SSHNP object when you want to actually run that particular "profile". In essence, one SSHNPParam object represents one "profile"

@gkc as for the failed tests it looks like we have a regression where new client is no longer backwards compatible with >= 3.2.0. I think because sshnpd >= 3.2.0 don't share a username.

@gkc as for the failed tests it looks like we have a regression where new client is no longer backwards compatible with >= 3.2.0. I think because sshnpd >= 3.2.0 don't share a username. Or is it that there is an issue with those versions of the at_client... maybe you have better visibility as to where the issue is occurring.

sshnpd does still share a username (via a notification) if that option is passed as an sshnpd command line argument.
versions 3.1.2 and 3.2.0 as I recall used a put and thus required a sync to complete.
So I think this is just a test race condition; maybe we need to increase the delay in the local, v3.1.2 and local, v3.2.0 tests? Note that a re-run succeeds

@gkc as for the failed tests it looks like we have a regression where new client is no longer backwards compatible with >= 3.2.0. I think because sshnpd >= 3.2.0 don't share a username. Or is it that there is an issue with those versions of the at_client... maybe you have better visibility as to where the issue is occurring.

sshnpd does still share a username (via a notification) if that option is passed as an sshnpd command line argument. versions 3.1.2 and 3.2.0 as I recall used a put and thus required a sync to complete (since the PutRequestOptions.useRemoteAtServer flag was not available back then).
So I think this is just a test race condition; maybe we need to increase the delay in the local, v3.1.2 and local, v3.2.0 tests? Note that a re-run succeeds
[EDIT] Looking at the logs, I can see that, in the runs that failed, sshnpd had not completed its sync

Ah, it happened twice in a row on me, I can increase sync based timeout from 30s -> 60s