////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/lib/net/address.h:178: undefined reference to __imp_ntohl' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/lib/net/address.h:178: undefined reference to __imp_ntohl'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1044.o: in function fmt_addr32': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/address.c:1216: undefined reference to __imp_htonl'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1044.o: in function tor_addr_to_ipv4h': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/lib/net/address.h:162: undefined reference to __imp_ntohl'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1044.o: in function get_interface_address6_via_udp_socket_hack': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/address.c:1669: undefined reference to __imp_htons'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: ////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/address.c:1673: undefined reference to __imp_htonl' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/address.c:1661: undefined reference to __imp_htons'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1044.o: in function tor_addr_to_ipv4h': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/lib/net/address.h:162: undefined reference to __imp_ntohl'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: ////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/lib/net/address.h:162: undefined reference to __imp_ntohl' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/_x1044.o: in function tor_addr_parse_mask_ports':
////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/address.c:609: undefined reference to __imp_htonl' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/address.c:668: undefined reference to __imp_ntohl'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1044.o: in function tor_dup_ip': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/address.c:2053: undefined reference to __imp_htonl'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1044.o: in function tor_addr_to_ipv4h': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/lib/net/address.h:162: undefined reference to __imp_ntohl'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1045.o: in function sock_drain': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/alertsock.c:176: undefined reference to __imp_recv'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1045.o: in function send_ni': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/alertsock.c:76: undefined reference to __imp_send'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1046.o: in function flush_chunk': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/buffers_net.c:153: undefined reference to __imp_send'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1046.o: in function read_to_chunk': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/buffers_net.c:52: undefined reference to __imp_recv'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1047.o: in function tor_gethostname': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/gethostname.c:29: undefined reference to __imp_gethostname'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1048.o: in function tor_inet_aton': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/inaddr.c:69: undefined reference to __imp_htonl'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1048.o: in function tor_inet_ntoa': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/inaddr.c:81: undefined reference to __imp_ntohl'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: ////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/inaddr.c:81: undefined reference to __imp_ntohl' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/_x1049.o: in function subsys_network_shutdown':
////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/network_sys.c:33: undefined reference to __imp_WSACleanup' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/_x1050.o: in function tor_addr_lookup_host_impl':
////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/resolve.c:153: undefined reference to __imp_gethostbyname' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/resolve.c:155: undefined reference to __imp_WSAGetLastError'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1050.o: in function tor_addr_to_ipv4h': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/lib/net/address.h:162: undefined reference to __imp_ntohl'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1051.o: in function network_init': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socket.c:48: undefined reference to __imp_WSAStartup'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1051.o: in function tor_connect_socket': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socket.c:253: undefined reference to __imp_connect'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1051.o: in function tor_open_socket_with_extensions': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socket.c:298: undefined reference to __imp_socket'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1051.o: in function set_socket_nonblocking': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socket.c:564: undefined reference to __imp_ioctlsocket'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1051.o: in function tor_open_socket_with_extensions': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socket.c:278: undefined reference to __imp_WSASetLastError'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1051.o: in function tor_accept_socket_with_extensions': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socket.c:408: undefined reference to __imp_accept'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1051.o: in function set_socket_nonblocking': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socket.c:564: undefined reference to __imp_ioctlsocket'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1051.o: in function tor_accept_socket_with_extensions': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socket.c:386: undefined reference to __imp_WSASetLastError'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1051.o: in function tor_getsockname': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socket.c:535: undefined reference to __imp_getsockname'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: ////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socket.c:535: undefined reference to __imp_getsockname' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/_x1051.o: in function set_socket_nonblocking':
////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socket.c:564: undefined reference to __imp_ioctlsocket' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/_x1051.o: in function read_all_from_socket':
////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socket.c:597: undefined reference to __imp_recv' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/_x1051.o: in function write_all_to_socket':
////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socket.c:617: undefined reference to __imp_send' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/_x1051.o: in function tor_socket_errno':
////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socket.c:642: undefined reference to __imp_WSAGetLastError' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socket.c:644: undefined reference to __imp_getsockopt'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1051.o: in function tor_close_socket_simple': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socket.c:159: undefined reference to __imp_closesocket'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: ////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socket.c:159: undefined reference to __imp_closesocket' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/_x1052.o: in function get_local_listener':
////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socketpair.c:58: undefined reference to __imp_socket' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socketpair.c:75: undefined reference to __imp_bind'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: ////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socketpair.c:77: undefined reference to __imp_listen' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socketpair.c:82: undefined reference to __imp_closesocket'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: $WORK/b113/x1052.o: in function tor_ersatz_socketpair': //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socketpair.c:176: undefined reference to __imp_socket'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: ////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socketpair.c:181: undefined reference to __imp_getsockname' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socketpair.c:216: undefined reference to __imp_closesocket'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: ////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socketpair.c:216: undefined reference to __imp_closesocket' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socketpair.c:159: undefined reference to __imp_WSAGetLastError'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: ////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socketpair.c:216: undefined reference to __imp_closesocket' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socketpair.c:185: undefined reference to __imp_connect'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: ////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socketpair.c:189: undefined reference to __imp_accept' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socketpair.c:216: undefined reference to __imp_closesocket'
/mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: ////github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socketpair.c:201: undefined reference to __imp_closesocket' /mnt/nvme/toolchains/x86_64-w64-mingw32-cross/bin/../lib/gcc/x86_64-w64-mingw32/10.2.1/../../../../x86_64-w64-mingw32/bin/ld: //_/_/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/tor/src/../src/lib/net/socketpair.c:216: undefined reference to __imp_closesocket'
collect2: error: ld returned 1 exit status
github.com/gen2brain/go-libtor/libtor
In file included from /home/user/go/pkg/mod/github.com/gen2brain/go-libtor@v1.2.0/libtor/windows_openssl_crypto_bio_b_sock.go:12:
<EMAIL_ADDRESS>In function ‘BIO_get_accept_socket’:
/home/user/go/pkg/mod/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/openssl/include/../crypto/bio/b_sock.c:202:13: warning: overflow in conversion from ‘long long unsigned int’ to ‘int’ changes value from ‘18446744073709551615’ to ‘-1’ [-Woverflow]
202 |     int s = INVALID_SOCKET;
|             ^~~~~~~~~~~~~~
/home/user/go/pkg/mod/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/openssl/include/../crypto/bio/b_sock.c:207:16: warning: overflow in conversion from ‘long long unsigned int’ to ‘int’ changes value from ‘18446744073709551615’ to ‘-1’ [-Woverflow]
207 |         return INVALID_SOCKET;
|                ^~~~~~~~~~~~~~
/home/user/go/pkg/mod/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/openssl/include/../crypto/bio/b_sock.c:210:16: warning: overflow in conversion from ‘long long unsigned int’ to ‘int’ changes value from ‘18446744073709551615’ to ‘-1’ [-Woverflow]
210 |         return INVALID_SOCKET;
|                ^~~~~~~~~~~~~~
/home/user/go/pkg/mod/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/openssl/include/../crypto/bio/b_sock.c:217:13: warning: overflow in conversion from ‘long long unsigned int’ to ‘int’ changes value from ‘18446744073709551615’ to ‘-1’ [-Woverflow]
217 |         s = INVALID_SOCKET;
|             ^~~~~~~~~~~~~~
/home/user/go/pkg/mod/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/openssl/include/../crypto/bio/b_sock.c:224:13: warning: overflow in conversion from ‘long long unsigned int’ to ‘int’ changes value from ‘18446744073709551615’ to ‘-1’ [-Woverflow]
224 |         s = INVALID_SOCKET;
|             ^~~~~~~~~~~~~~
github.com/gen2brain/go-libtor/libtor
In file included from /home/user/go/pkg/mod/github.com/gen2brain/go-libtor@v1.2.0/libtor/windows_openssl_crypto_bio_b_sock2.go:12:
<EMAIL_ADDRESS>In function ‘BIO_socket’:
/home/user/go/pkg/mod/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/openssl/include/../crypto/bio/b_sock2.c:45:16: warning: overflow in conversion from ‘long long unsigned int’ to ‘int’ changes value from ‘18446744073709551615’ to ‘-1’ [-Woverflow]
45 |         return INVALID_SOCKET;
|                ^~~~~~~~~~~~~~
/home/user/go/pkg/mod/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/openssl/include/../crypto/bio/b_sock2.c:51:16: warning: overflow in conversion from ‘long long unsigned int’ to ‘int’ changes value from ‘18446744073709551615’ to ‘-1’ [-Woverflow]
51 |         return INVALID_SOCKET;
|                ^~~~~~~~~~~~~~
<EMAIL_ADDRESS>In function ‘BIO_accept_ex’:
/home/user/go/pkg/mod/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/openssl/include/../crypto/bio/b_sock2.c:297:16: warning: overflow in conversion from ‘long long unsigned int’ to ‘int’ changes value from ‘18446744073709551615’ to ‘-1’ [-Woverflow]
297 |         return INVALID_SOCKET;
|                ^~~~~~~~~~~~~~
/home/user/go/pkg/mod/github.com/gen2brain/go-libtor@v1.2.0/libtor/../windows/openssl/include/../crypto/bio/b_sock2.c:302:16: warning: overflow in conversion from ‘long long unsigned int’ to ‘int’ changes value from ‘18446744073709551615’ to ‘-1’ [-Woverflow]
302 |         return INVALID_SOCKET;
|                ^~~~~~~~~~~~~~
`
Any ideas what could be going wrong here? After your post I appreciate the benefits of having the tor binary not shipped seperately and would like to attempt to try and cross compile a reproducable windows build using your library if anyone has any ideas on what I should be looking at from here would be greatly appreciated

commenting a bit out of context, one general solution to windows is to embed the whole compiled tor binary into the Go program, upon start up, extract it on disk, in temp/whatever, then use ExePath. The downside is ~10/15mb increase on the binary size, though looking at my local build here it is 19mb, looks fairly identical increase. Dirty, but a rock solid solution of the poorman. I am always lost into those C cross compilation header things.

any update on this?


Add all Terms isn't working when creating a Data Element CodeSet and Data Element

Peter - could you have a look at this issue and help please.
I am trying to create a new Data Element and CodeSet in CR8000: PERSON STATED EYE COLOUR.
I have successfully created the Code Set and selcted all Terms:

However, when I look at the Data Element CodeSet, it is not showing any Terms.
There was an issue with adding all Terms that you noted on one of our calls, did you fix this? This must be related to #544

I then tried to create the Data Element but when I try to submit the Data Element, I received the following.
Can you please help to explain what I have done wrong?

Select "Add all terms" and it not working is an issue with Mauro itself, and should be raised to @jamesrwelch.
Your second issue, not being able to create the "Reference to CodeSet" whilst creating the Data Element - an existing reference already existed, but it referenced a Code Set which does not exist anymore. I think I had to manually fix something around this area for you before. I have removed all references to that old Code Set, you should now be able to follow your instructions to create a new Data Element again.
However, this raises another issue that @jamesrwelch must look into. When a "Reference to CodeSet" data type exists but the referenced model does not, you cannot use the UI to locate that data type anymore, I had to go into the database and manually delete it. The reason is because the UI which try to fetch the referenced model to display the label for it, but will return a 404 (obviously) which is handled badly.
Apart from where I have fixed the database for you @AngelaFaulding , I believe the rest falls out of scope for System C and needs to be picked up with @jamesrwelch.

@jamesrwelch - re the above.
I have created a new Attribute, Attribute Terminology, Data Element and Data Element Codeset in branch CR8008.
I added 7 terms to the Attribute Terminology:

I selected "Add all Terms" to add all terms to the codeset.
When I view the codeset, there are no terms added:

The Orchestrator shows the Terms on the Attribute and none on the Data Element:

Peter did identify this as an issue a while ago when he showed us how to create a codeset, but has not resolved this and has now said it is an issue for you to resolve.
Can you help please?

James will investigate.

16/10/24 - this is still not working:

Reopening as closed automatically by GitHub


Remove all bazel build files

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 27.005%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
687

Relevant Lines:
2544

💛  - Coveralls

Bazel isn't being used to build any of the repo and as a result no one's been maintaining it. Currently the bazel code doesn't build, and we had some vendors get confused. Figured we'd remove it to mitigate confusion.


bug(slider): Using a slider with a formControl breaks change detection

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
I have a widget that uses mat-slider. This widget takes a value as an input and sets it to the form control bound to the slider:
// template
<mat-slider>
  <input matSliderThumb [formControl]="sliderValue">
</>

// component
@Input() value: number

sliderValue = new FormControl(0, {nonNullable: true})

ngOnChanges() {
  this.sliderValue.setValue(this.value) // <-- this

  // derived value used in the template
  this.isDefaultValue = this.value === 0
}

Looks like the .setValue call breaks change detection. The isDefaultValue value is properly derived (as per console.log output), but is not reflected in HTML. It will get updated after the next interaction with the widget (which triggers change detection), or after manually calling changeDetectorRef.detectChanges().
This happens with a single-handle or a two-handle slider.
It only happens when the value is bound to the slider via a form control. If I pass the value as a property binding instead ([value]="sliderValue.value"), everything works fine.
Also moving the isDefaultValue calculation up to be before the .setValue call magically solves it, too.

Reproduction
StackBlitz link: https://stackblitz.com/edit/xsoedg?file=src%2Fexample%2Fapp-widget.component.ts

Click the "set to 2" button

Expected Behavior

Slider value is printed as "2"
Slider default state is printed as "false"
The slider turns blue

Actual Behavior

Slider value is printed as "2" (correct)
Slider default state is printed as "true" (incorrect)
The slider remains gray (incorrect)

Environment

Angular: 16
CDK/Material: 16
Browser(s): Firefox, Chrome
Operating System (e.g. Windows, macOS, Ubuntu): macOS

@wagnermaciel could you please clarify what you mean?
just removing the formControl binding from the template makes everything work well

Furthermore, replacing mat-slider with a text input, keeping the same fomrControl binding, also solve the CD issue.
So whatever it is, it is specific to the slider


Cesium captures all mouse and touch events which doesn't bubble up document.activeElement

All mouse and touch events are capture during viewer init.
The focus events do occur when trying to change focus from a different non Cesium UI element to Cesium canvas.
Basically if a NON Cesium UI element has focus and we try to unfocus from that element by clicking on the Cesium canvas, the unfocus event cannot work correctly.
Cesium is capturing these events and thus not bubbling to allow for changing of the document.activeElement
EX: https://codesandbox.io/s/test-quasar-cesium-vue3-edjxls?file=/src/index.template.html
Oddly this doesn't appear to be an issue with Firefox. Only Chromium browsers.
This should be consistent with all browsers.
See example above in both browsers to notice the issue.
Browser: Firefox, Chrome
Operating System: windows

Thanks for the report @cmcleese. If I understand correctly, this is the same issue as https://github.com/CesiumGS/cesium/issues/9134. Is that correct?

Hi @ggetz, yes this does sound very similar.
However this seems to affect any element which was set via document.activeElement.
I can also believe it was a relatively recent code change that change the way this behavior is handled.
Not quite sure exactly which version yet however.

Hi.
I am the author of the similar issue you mentioned.
As I wrote in my issue, the pr that broke the behavior was [https://github.com/CesiumGS/cesium/pull/8662(this one)

My idea was to make this behavior configurable via the ViewerConstructorOptions - so the blurActiveElement function will not be passed for the addEventListener.

Thanks for the interest in contributing @yonzmeer. That should be fine so long as the default behavior remains the same when this option is not provided.

My idea was to make this behavior configurable via the ViewerConstructorOptions - so the blurActiveElement function will not be passed for the addEventListener.

Thanks for the interest in contributing @yonzmeer. That should be fine so long as the default behavior remains the same when this option is not provided.

Opened one. Would love some help with it, especially with my naming.


Compiler throws panic on a function w/o return value

neo-go master-2.x branch
neo-go version 0.74.1-pre-148-ge097e86b
I got a loop function with for loop over slice, stored in the contract storage.
package foo

import "github.com/nspcc-dev/neo-go/pkg/interop/storage"

func loop(ctx storage.Context, key string, value int) {
	list := storage.Get(ctx, key).([]int)
	for i := 0; i < len(list); i++ {
		if list[i] == value {
			return
		}
	}
	list = append(list, value)
	storage.Put(ctx, key, list)
}

func Main() int {
	ctx := storage.GetContext()
	loop(ctx, "foo", 1)
	return 1
}

When I run this code in a tests, I expect to get a storage error, something like this one.
error encountered at instruction 71 (SYSCALL): failed to invoke syscall: could not find [102 111 111]

But instead compiler throws panic.
panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

If I add return value in a loop function then it compiles correctly:
func loop(ctx storage.Context, key string, value int) int {
	list := storage.Get(ctx, key).([]int)
	for i := 0; i < len(list); i++ {
		if list[i] == value {
			return 0
		}
	}
	list = append(list, value)
	storage.Put(ctx, key, list)
	return 0
}

Are there any special rules for functions without return values?

I'm not sure whether it's caused by attempt to Put/Get []int (which probably won't work) or function return value.

@roman-khimov You can omit storage operations and you'll have the same issue (loop function will be kinda useless though)
func loop(ctx storage.Context, key string, value int) {
	var list = []int{2,3,4,5,6}
	for i := 0; i < len(list); i++ {
		if list[i] == value {
			return
		}
	}
}

It is cause not by the function itself, but rather by return with no arguments.

Closed via #931 .


An implicit requirement

deeppavlov.core.commands.infer.build_model_from_config doesn't work without gensim and tensorflow (trying to run goo.gl/V2gfxn tutorial on windows)

Tensorflow has cpu-version tensorflow and gpu-compatible version tensorflow-gpu.
You should choose yourself and install any of them BEFORE installing deeppavlov.
gensim is not required by all deeppavlov models, and is not installed by default. Before using any model you should firstly install it's requirements by python -m deeppavlov install path/to/config. Maybe that was in your case?


Question - Register-ArgumentComplete

This can be installed from Install-Module PSPulumi.
Two questions, the module doesn't auto load. I'm not sure what I need to make that happen,
I can ctrl+space and autocomplete all of these pulumi stack ls --all
I want to be able to ctrl+space and get the --json to complete pulumi stack ls --all --json
Here is the section for the tree.
https://github.com/dfinke/PSPulumi/blob/master/PulumiCompletion.ps1#L177
How do I need to re-work the completer to enable this?

I don't think auto-loading can be triggered from argument completion - at least in any reasonable sort of way.
I'm not sure where the problem lies or how to change your completer, but I'll point out for anyone wanting to take a look, you'll need to install TabExpansionPlusPlus before investigating because the sample code use New-CommandTree from that module.


Starting concrete dom components from AppFacade

startComponents logic should be handled from appComponent
parseOptions should be handled from appComponent
example in startComponent

itemInstance = this.appComponent.createItem(item, options)

Done with this commit: https://github.com/HenriPodolski/complay/commit/8fe7533ed3b8b190574d241e452752707ba80b3b


DCOS-15164: Add #isSDKService to ServiceUtil

This PR adds a method to ServiceUtil to determine when a service is an SDK service. It does this by checking for the existence of the label DCOS_COMMONS_API_VERSION.
cc @mlunoe
Checklist

[x] Did you add a JIRA issue in a commit message or as part of the branch name?
[x] Did you add new unit tests?
[ ] Did you add new integration tests?
[ ] If this is a regression, did you write a test to catch this in the future?

LGTM Let's merge this.


adding the ability to disable the collector in develop

Documentation is missing.

i will try to upload tomorrow


Fixed integration tests

This fixes and reenables frontend integration tests for 3.5

Coverage increased (+0.007%) to 79.66% when pulling 8aeeb9925b6ff4fad1d8e323f7a3c09a94344da7 on vxsx:feature/3.5.x/integration-tests into 6f0cd2eb911fb8bdc12b890751833b650f5f455b on divio:develop.

Coverage increased (+0.007%) to 79.66% when pulling f7b8f51acf02cad3241a34d5e236a1d99deac1c3 on vxsx:feature/3.5.x/integration-tests into 6f0cd2eb911fb8bdc12b890751833b650f5f455b on divio:develop.

Coverage increased (+0.007%) to 79.66% when pulling 42614687eeb7240316fcdecf16158c48c40aeec6 on vxsx:feature/3.5.x/integration-tests into 6f0cd2eb911fb8bdc12b890751833b650f5f455b on divio:develop.


xds-sotw: reset nonce when reconnecting

Commit Message: xds-sotw: reset nonce when reconnecting
Additional Description:
Similar to #16037, this PR resets the nonce after reconnection for SotW.
This change is a bug fix that ensures SotW behaves according to the xDS protocol.
Risk Level: low
Testing: Added a test.
Docs Changes: N/A.
Release Notes: Added.
Fixes: #30155

Would be good to backport to the previous version as it causes friction with the control plane runtime switch.


Generic source compatible with anyhow (or similar)

Sometimes, it may make sense to compose an error enum of generic sources. This is easily possible by using std::error::Error + 'static trait bounds:
#[derive(Debug, Error)]
pub enum FetchError<
    L: std::error::Error + 'static,
    S: std::error::Error + 'static,
> {
    #[error(transparent)]
    Load(L),

    #[error("Failed to save new value")]
    Save(#[source] S),
}

This supports errors which implement std::error::Error directly, however, it can't be used when the sources are, say, an anyhow::Error:
FetchError<anyhow::Error, anyhow::Error>> =
    |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `StdError` is not implemented for `anyhow::Error`

I have seen that thiserror internally uses thiserror::private::AsDynError<'a>, but that's (a) a private API and (b) I wouldn't know what to supply as a lifetime parameter when using this as a trait bound.
Could you help me find a way to support both implementations of StdError as well as anyhow::Error (or other types that dereference to a dyn StdError) as generic arguments?
Would it be possible for thiserror to simplify these trait bounds in some way?

Hi @nthuemmel, sorry that no one was able to provide guidance here. If this is still an issue, you could try taking this question to any of the resources shown in https://www.rust-lang.org/community.


Apply ProgressBar Refresh among all epoch and not across train and validation.

Proposed refactor

From #https://github.com/PyTorchLightning/pytorch-lightning/pull/11213#discussion_r778632304 conversation, the refresh rate from the Progress Bar is computed as follows:
# train_batches, val_batches, refresh_rate
[5, 3, 6]
would give train_updates, val_updates on the following global batch_idx
[8], [3]

This means, the train_batches + val_batches aren't used as a single unit but instead the refresh counter is restarted at the beginning of the validation loop.
Instead, we should have
[8], [1, 3]

The 1 comes as 5 batches from the train were processed and 1 batch from the validation which makes the total number of batches seen divisible by 6.
Should we refactor the code to account for refreshing over the total number of batches seen in the epoch 🚀 or leave it as is 😊.
Motivation

Pitch

Additional context

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

This was fixed / is now obsolete because we separated the two progress bars in https://github.com/Lightning-AI/lightning/pull/16695


Apply URL encoding to the fragmentPath

According to RFC3986 section 3.5, only certain values are legal in the fragment. # in particular isn't one of them - its not a "pchar", but this is a character that appears in room names.
This seems to cause element:// urls to fail to load Element on OS X; it might cause issues elsewhere as well.
It shouldn't hurt to escape other, otherwise legal characters in the fragment such as @ and :.
Fixes https://github.com/vector-im/element-web/issues/17446
Fixes https://github.com/matrix-org/matrix.to/issues/230

Oh, great find! Thanks for this, I was a bit puzzled as to what the reason was for it not working just on mac.


some streams not working on a android tablet

Sorry for those questions, but I can´t find the answer. Maybe anybody can tell me, what i am doing wrong.
I use 3 Cams. 2 Tapo and one other chinese cam.
Now everything is working well on my windows pc with chrome.
On my Redmi Pad the two tapo streams which are working on the windows pc, dont play. The last one from the chinese cam is working fine.
Is there some codec missing or what can i do to find out the reason?

i cant get the streams run with chrome and Fully on the tablet. If i use firefox it works.
Hm whats the reason?

Seems its the same Issue
https://github.com/AlexxIT/go2rtc/issues/286


[WebSite] Design Thinking / approach for public website

From the final Community call of 2023, I took the action items to open an issue for the team to come together on design thinking for a public website for Theme Builder-
Leaving this as a placeholder for comments and assignment-

Need to assign Lise, Paula, Cody, Yessel - @aaronreed708

Sounds great to me!

From Jun 5 Community call - @lwnoble to set up design thinking session!


Add more labels to a custom trained model

💡 Your Question
I have a custom trained model model . It was trained using 13,000 images and labels and took 12 hours to train.
I want to add more training data (images and labels)
Is there a way to incrementally add a small amount of additional training data and re-run training without it taking 12 hours to complete?
Versions
No response

You can always load a weights of the trained model from previous step and continue training it from that state.
model = models.get(...., checkpoint_path=<ABSOLUTE_PATH_TO_CHECKPOINT_FROM_PREVIOUS_TRAINING>)

Or via cmd-line if you are using YAML recipes: python -m super_gradients.train_from_recipe --config-name=YOUR_RECIPES checkpoint_params.checkpoint_path=<ABSOLUTE_PATH_TO_CHECKPOINT_FROM_PREVIOUS_TRAINING>

Hi @BloodAxe
Thanks for the suggestion. Is this this what you mean?
model = models.get("yolo_nas_l", num_classes=2, checkpoint_path=r"custommodel/ckpt_best.pth").cuda()
trainer.train(model=model,                training_params=train_params,                train_loader=train_data,                valid_loader=val_data)

Exactly

The re-trained custom model is not giving me the results I expect
The original custom model predicts correctly, i.e it identifies an object with 0.9 confidence.
However, when I run the same prediction of the re-trained custom model I don't get any prediction.
I wonder am I missing something from my training_params
`
train_params = {
# ENABLING SILENT MODE
'silent_mode': False,
"average_best_models":True,
"warmup_mode": "linear_epoch_step",
"warmup_initial_lr": 1e-6,
"lr_warmup_epochs": 3,
"initial_lr": 5e-4,
"lr_mode": "cosine",
"cosine_final_lr_ratio": 0.1,
"optimizer": "Adam",
"optimizer_params": {"weight_decay": 0.0001},
"zero_weight_decay_on_bias_and_bn": True,
"ema": True,
"ema_params": {"decay": 0.9, "decay_type": "threshold"},
"max_epochs": EPOCHS,
"mixed_precision": True,
"loss": PPYoloELoss(
    use_static_assigner=False,
    # NOTE: num_classes needs to be defined here
    num_classes=len(dataset_params['classes']),
    reg_max=16
),
"valid_metrics_list": [
    DetectionMetrics_050(
        score_thres=0.1,
        top_k_predictions=300,
        # NOTE: num_classes needs to be defined here
        num_cls=len(dataset_params['classes']),
        normalize_targets=True,
        post_prediction_callback=PPYoloEPostPredictionCallback(
            score_threshold=0.01,
            nms_top_k=1000,
            max_predictions=300,
            nms_threshold=0.7
        )
    )
],
"metric_to_watch"<EMAIL_ADDRESS>
}
`

The provided snippet is not enough to help. Please show the rest of code including a data loader's preparation (before and after you add more data) and tensorboard plots for regular training and with additional data

I'm using an AWS Sagemaker Training job to train the model.
Here is the code I use to create the Training Job
estimator = PyTorch(     entry_point="train.py",     role=role,     source_dir="./yolo-nas-model-scripts",     instance_count=1,     instance_type='ml.g4dn.12xlarge',     framework_version="1.13.1",     py_version="py39",     sagemaker_session=sagemaker_session,     input_mode='File',  # FastFile causes a issue with writing label cache     output_path=dataset_s3_uri+'/output', )
estimator.fit(train_input, job_name=job_name)
train.py attached, renamed to train.txt
train.txt

@BloodAxe

Is there a way to incrementally add a small amount of additional training data and re-run training without it taking 12 hours to complete?

My original question quoted above ^^
I have seen in the following discussion: https://github.com/ultralytics/ultralytics/issues/4554#issuecomment-1695218721

Currently, YOLOv8 does not have a feature for incremental learning

Is the same true of YOLO-NAS?

So what you are looking for is continual learning. A technique which allow to train a model on a few data samples without forgetting the existing knowledge.
Unfortunately at the moment we don't supoort this.


Unable to connect to my Kafka Server in local

I'm testing your kafka client
I don' t really know kafka but i have to plug to it from iOS Application.
I tried your client in a local mode :
I set up local kafka using  https://kafka.apache.org/documentation.html#quickstart
in swift code i use
BioKafkaInterface(ip: "<IP_ADDRESS>", port: 2181, clientId: "", groupId: "test-consumer-group", partition: 0, topic: "test");
Where BioKafkaInterface is :
import Foundation
import ReactiveCocoa

@objc class BioKafkaInterface: NSObject, BioCommunicator, HighLevelConsumerDelegate {

let cluster : Cluster

init(ip:String, port:Int, clientId:String, groupId:String, partition:Int, topic:String) {
    print("init ip string")
    self.cluster = Cluster(brokers:[(ip, Int32(port))], clientId:clientId);
    super.init()
    self.cluster.getHighLevelConsumer(topic, partition: Int32(partition), groupId: groupId, delegate:self)

}

func read(size:UInt) -> Signal<[Int8], NSError> {
    return Signal.empty
}

func write(data:[Int8]) -> SignalProducer<Int, NSError> {
    return SignalProducer.empty;
}

func consumerDidReturnMessage(message: Message, offset: Int64) {
    print(NSString(data: message.value, encoding: NSUTF8StringEncoding))
}

func consumerIsReady(consumer: Consumer) {
    print("Consummer is ready")
    if let highLevelConsumer = consumer as? HighLevelConsumer {
        print("\(highLevelConsumer.broker?.description)")
        highLevelConsumer.poll()
    }
}

func shouldCommitOffset(topic: String, partition: Int32, offset: Int64) -> Bool {
    print("shouldCommitOffset \(topic, partition, offset)")
    return true
}

func shouldAttachOffsetMetadata(topic: String, partition: Int32, offset: Int64) -> String? {
    print("shouldAttachOffsetMetadata \(topic, partition, offset)")
    return "toto"
}

func offsetDidCommit(topic: String, partition: Int32, offset: Int64) {
    print("offsetDidCommit \(topic, partition, offset)")
}

func offsetCommitDidFail(topic: String, partition: Int32, offset: Int64, errorId: Int16, errorDescription: String) {
    print("offsetCommitDidFail \(topic, partition, offset, errorId, errorDescription)")
}

func shouldRetryFailedOffsetCommit(topic: String, partition: Int32, offset: Int64, errorId: Int16, errorDescription: String) -> Bool {
    print("shouldRetryFailedOffsetCommit \(topic, partition, offset, errorId, errorDescription)")
    return true;
}

func fetchDidFail(
    topic: String,
    partition: Int32,
    errorId: Int16,
    errorDescription: String
    ) {
        print("fetchDidFail \(topic, partition, errorId, errorDescription)");
}

func shouldRetryFailedFetch(
    topic: String,
    partition: Int32,
    errorId: Int16,
    errorDescription: String
    ) -> Bool {
                    print("shouldRetryFailedFetch \(topic, partition, errorId, errorDescription)");
        return true
}

func topicPartitionLeaderNotFound(topic: String, partition: Int32) {
    print("topicPartitionLeaderNotFound \(topic, partition) ");
}

}
The error in my log are :
INPUT STREAM STATUS: End
Zero Lenth Response
Log from zookeeper :
INFO Accepted socket connection from /<IP_ADDRESS>:49591 (org.apache.zookeeper.server.NIOServerCnxnFactory)
[2016-03-08 11:20:46,397] WARN Exception causing close of session 0x0 due to java.io.IOException: Unreasonable length =<PHONE_NUMBER> (org.apache.zookeeper.server.NIOServerCnxn)
[2016-03-08 11:20:46,397] INFO Closed socket connection for client /<IP_ADDRESS>:49591 (no session established for client) (org.apache.zookeeper.server.NIOServerCnxn)
Have you any idea what's going on there?
Co you have a solution, or an alternative to use kafka client

Ok I found My error :
I should not use <IP_ADDRESS> as the ip adress of the server some how it convert it to the real ip adress and then not find the broker
In Cluster.swift :
private func getGroupCoordinator(id: String, callback: Broker -> ())
the response from GroupCoordinatorResponse give the real ip of the host and not <IP_ADDRESS> so the broker is not found in self._brokers
To correct without touching your code we have to use directly the real local ip
This error may not occur other than in local mode


feat: support leetgo open

About
This PR is to support leetgo open feature. Closes #113
Tested on Windows/amd64.
How it works
I borrowed the implementation from pick, in which the ParseQID function has processed the parameters after open. It only needs to determine whether it is a contest based on the number of questions we get and open the corresponding page.
Demo video here
https://user-images.githubusercontent.com/101162387/219935470-c2391514-40ab-4c28-a9d4-228abe9c62ca.mp4

Thank you for your PR, most of it looks good to me, I left two minor comments. Also, you still need to use golanglint-ci run --fix to fix some lint issues.

Updated.
Thanks for your review. Glad to contribute to this great project! : )


Add support of training samples with weights

This will be useful in many applications

This has been implemented in the branch weighted-samples and awaits further testing before merging to the main branch.


Bug: Hashtags with Korean characters in Safari don't work well.

Hashtags with Korean characters in Safari don't work well.

Lexical version: 0.11.3
Steps To Reproduce

In Safari, enter https://playground.lexical.dev/
Type "#안녕하세요"

Link to code example:

The current behavior
#ㄴㅇ요세하ㅕㄴ아
The expected behavior
#안녕하세요

Hi can you confirm this still happening? I can't reproduce it.


Created Tetris clone "Reblox"

The main Makefile in the Redox OS repository will need to be updated to build this game.

Are you sure the Makefile has to be changed? I thought other games didn't need that…

@EGhiorzi Take a look at line 236 in the main Makefile for redox-os. The other games are specified there. If you just build and run redox-os without any changes, the game reblox is not available.

Looks very good! I have left quite a few comments, mostly about style and conventions.

I made changes according to your recommendations with some exceptions:

Did not #[derive(Default)] for struct Grid because it has an array and I wasn't able to get it working with that array.
Falling blocks are not stored as array of cells but rather stored in Grid::grid. This is done purposefully so that outside this module, one would only need to look at the Grid::grid to draw the board. The only thing not drawn from Grid::grid is the next falling block.

Great!


Long driving time leading to SoC/margin-error

A very long driving time (see "max_driving") leads to an error that the soc of a vehicle is below the desired_soc, even though the margin is set to 1.
Is this intended? This could lead to failures in simulations with very long driving times, like busses.

JSON with failure: test_fail.json.txt
If "max_driving" is lowered to 16h, the simulation does not fail. The output shows no sign of why the soc can not be reached.

JSON without failure: test.json.txt

i get a similar error. Although in my case the margin is reset to it's default value after a while. It is read out from the kwags / options in the beginning, but later it appears to be the default value again. Maybe because the strategy class is initialized without kwags at some point? screenshop of my simulate.cfg and the debugger at the point where the assert is failing in strategy.py


Attempting to run a .py file makes vscode open instead of running it!

Re-opening this issue (see: #9987), as I'm experiencing the exact same issue.
To reproduce:

Install Python (win 10 64-bit in my case. Installed from full installer on python.org, not the 'limited build' available in the Microsoft store).
Install VSCode (v1.61.1)
Open a command prompt.
Type 'hello.py' (name of a python script).
VSCode opens & displays the python script.

Per the last comment on #9987 (@kieferrm), 'ftype Python.File' displays:
Python.File="C:\WINDOWS\py.exe" "%L" %*
which seems correct to execute the python launcher to run a python script.
Instead, VSCode opens & displays the python script.
I removed the VSCode Python extension & re-tested to ensure it was not a problem with the extension, but behavior was unchanged.

@mainr When you installed VS Code you have been presented with the following screen:

You have probably continued the installation with "Register Code as an editor for supported file types" checked.
That means that VS Code has defined at the OS level that VS Code can edit .py files. That is why double clicking / opening a .py file results in VS Code opening the file for editing. If you do not like this behavior, you can uninstall VS Code and install it again with unchecking the checkbox. Alternatively, if you don't want to uninstall and install again VS Code, you can do the steps provided in https://github.com/microsoft/vscode/issues/9987#issuecomment-237612280 to tweak the file association only for .py files on your computer.


State of the field

It would strengthen the paper (the quality of the writing) if the text makes clearer that rejected article tracking is only one important application of the software, where the core functionality is finding DOI records in Crossref using metadata such as title and authors.
openjournals/joss-reviews#3348

Thank you for the feedback. We added this paragraph to the paper after initial feedback from the other referee. Does this address your point? Happy to make further changes if not:

The target audience for the tracker is researchers studying rejected articles. The task performed by the tracker is 'DOI-resolution'. I.e. finding the correct Digital Object Identifier given incomplete data about a paper. So, while the intended use of the tracker is to track rejected articles, it might be used by researchers performing DOI-resolution for other reasons, such as assigning DOIs to preprints in order to connect the preprints to their published versions, e.g. [@Cabanac2021]. This is a particularly topical application at the current time due to the rapid growth of preprint servers in recent years [@Hoy2020].

The comment addresses my point, thank you.  I suggest one small change: DOI resolution is in the PID community understood as looking up the URL associated with the DOI, not finding a DOI for a given set of metadata. Could you use a different term?

Yes, I was thinking about this already. I can see the potential for confusion.

I'm not sure that the 2 definitions are mutually exclusive. E.g. if we have a URL, we are checking to see if that information refers to a real DOI. The same is true in this process where we have incomplete metadata and we are checking to see if that information refers to a real DOI. This seems to fit with definitions for entity-resolution found with Google, e.g. : https://www.sciencedirect.com/topics/computer-science/entity-resolution but that doesn't mean there's no potential for confusion, which I would rather avoid.
If we change the terminology, I'm not sure what would be the best thing to use. In the reference you recommended, the process is called 'reference-matching', but this isn't appropriate for rejected article tracking, because we don't have 'references' as input.

Did you have an alternative phrasing in mind? Happy to change it, just not sure what to!

DOI retrieval?

Sounds good.

Thanks again for the feedback. I've changed this to 'record-linkage' in the paper.


Does the Minio SDK use multiple connections to saturate the bandwidth?

I read that the AWS SDK uses multiple connections when downloading an object. I'm not trying to compare the two; I would just like to know if the Minio SDK does something similar to speed up the transfer.

Not by itself. But you can easily add that to your client, if it makes sense in your setup.


Display number of likes for each item on Homepage

The following functionalities were implemented in this branch;

[ ] The number of likes for all items is fetched from the involvement api
[ ] Each item on the homepage is updated with the number of likes
[ ] Click listeners are set on like click buttons and the like value is updated when the user clicks

Okay. I will work on it right away. Thanks


Smjs

Do you think you're achieving something doing this?

@Black-DeathPE why you blocked me in twitter?

Leave a comment @zhuowei


feat(Datastore/API): custom primary keys support for delete and update

Issue #, if available: None
Description of changes:  This is a merge PR for
https://github.com/aws-amplify/amplify-ios/pull/1256
https://github.com/aws-amplify/amplify-ios/pull/1246
https://github.com/aws-amplify/amplify-ios/pull/1228
Check points:

[x] Added new tests to cover change, if needed
[x] All unit tests pass
[x] All integration tests pass
- [ ] Documentation update for the change if required
[x] PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1261 (bdb7ce1) into main (a0ae77d) will decrease coverage by 0.04%.
The diff coverage is 51.16%.

:exclamation: Current head bdb7ce1 differs from pull request most recent head ada4f59. Consider uploading reports for the commit ada4f59 to get more accurate results

@@            Coverage Diff             @@
##             main    #1261      +/-   ##
==========================================
- Coverage   59.97%   59.92%   -0.05%
==========================================
  Files         653      653
  Lines       19330    19364      +34
==========================================
+ Hits        11593    11604      +11
- Misses       7737     7760      +23

Flag
Coverage Δ

API_plugin_unit_test
63.30% <ø> (-0.21%)
:arrow_down:

AWSPluginsCore
77.06% <100.00%> (+0.32%)
:arrow_up:

Amplify
48.45% <0.00%> (-0.14%)
:arrow_down:

Analytics_plugin_unit_test
73.41% <ø> (ø)

Auth_plugin_unit_test
82.31% <ø> (ø)

DataStore_plugin_unit_test
73.88% <20.00%> (-0.11%)
:arrow_down:

Predictions_plugin_unit_test
33.51% <ø> (ø)

Storage_plugin_unit_test
57.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../DataStore/Model/Internal/Schema/ModelSchema.swift
64.58% <0.00%> (-23.99%)
:arrow_down:

...ngMutationQueue/SyncMutationToCloudOperation.swift
54.72% <0.00%> (-2.32%)
:arrow_down:

...PluginsCore/Model/Decorator/ModelIdDecorator.swift
92.59% <100.00%> (+9.25%)
:arrow_up:

...aphQLRequest/GraphQLRequest+AnyModelWithSync.swift
86.00% <100.00%> (ø)

...re/Model/GraphQLRequest/GraphQLRequest+Model.swift
95.12% <100.00%> (ø)

...Queue/ProcessMutationErrorFromCloudOperation.swift
70.75% <100.00%> (ø)

...lugin/Operation/AWSAPIOperation+APIOperation.swift
78.37% <0.00%> (-5.41%)
:arrow_down:

...CategoryPlugin/Operation/AWSGraphQLOperation.swift
58.22% <0.00%> (-2.54%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0ae77d...ada4f59. Read the comment docs.


Automatically reopen idle connections

Connections that have been idle for more than five minutes are automatically reopened. This is done in order to preempt the broker-side connection killer, which by default kicks in after 10 minutes of idleness.

cool ! it will surely fix https://github.com/zendesk/ruby-kafka/issues/395

@Elyahou it did fix it!


Allow external services (EPNS) to hook into notification system

I would like to create a push notification server with EPNS. Currently, the Lens protocol notification API will only return notifications for the logged-in user.
In what ways could we allow authorized services to access notifications?
And once we've fixed that, perhaps rather than having to pull the API for changes, it would be ideal if we can use webhooks or WebSockets to listen for new notifications.

Hey Rick, sorry for the delay on the response.
Feel free to build notification services for Lens, that would be awesome.
For API specific questions, I'll kindly ask you to redirect them to the #lens-api channel in our official Discord. Thank you!


feat: added ability to update the primary course on the learn tab

Added ability to update the primary course on the learn tab automatically

closed because of https://github.com/edx/edx-mobile-marketplace-android/pull/18


<!--https://github.com/twitter/twemoji/issues/471

Description

Feature Workflow

[First Action]
[Second Action]
[and so on...]

Additional Information

Provide pictures or links that demonstrate a similar feature or concept.
See How Can I Contribute for additional guidelines.

Originally posted by @BROSVORN in https://github.com/MarlinFirmware/Marlin/issues/21101

https://github.com/twitter/twemoji/issues/471


Rev compute package to 0.33.rc1

@yugang-msft

@brendandburns , you need to re-record, or at least update one acs test's recording file to match the new API version


Update README with go prerequisite for make

Make it clear to new contributors which version of go to install prior to them blindly running make app and expecting a positive result

I have read the CLA Document and I hereby sign the CLA

recheck


Deprecate #shared tag, use not #volatile and volatile storage key instead to register shareable stores.

and distinguish between 'ramdisk' and 'volatile' in runtime.ts and java code

@shans can you, please, take a look?


Waypoint optimizations

These are some optimizations that came from Adai's profiling and looking at flamegraph.
There is much more optimizing to be done (and I'll update the bottlenecks issue accordingly)... this was limited to just dealing with waypoints (and even there, more could still be done, but trying not to disrupt too much at this point).
Note that the Makefile change came out of our discussion today and is unrelated.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: iman512003:x: sah-huaweiYou have signed the CLA already but the status is still pending? Let us recheck it.

How much time did we save per episode by

changing numpy/scipy implementation (i.e., np.unwrap, interp1d),
caching waypoints, and
reducing lookaheads?

How much time did we save per episode by
* changing numpy/scipy implementation (i.e., np.unwrap, interp1d),

* caching waypoints, and

* reducing lookaheads?

The total amount of time saved will depend on many things (for example, depending on how many times each of these things are used in a scenario), but I have been watching both the average steps per second and (better) percentage spent in the functions (via the flame-graphs), which improved with each of the above.  However, I don't know the best way to report this as data here.
Of the above 3 things, the caching of the waypoints is currently the least helpful, because the cache is only rarely hit.  The current lru_cache (while convenient to add) only helps in the circumstance of redundant picalls to retrieve waypoints starting from the same waypoint, which is rare.  A better cache would handle overlapping calls too (for example, allowing for the lookahead parameter not to have to match, and even for different starting waypoints, among other things).  However, given the complexity of that change, I decided to leave it until a later sprint -- we can file it as a separate issue as Tucker requested -- and just push what we have now.

Of the above 3 things, the caching of the waypoints is currently the least helpful, because the cache is only rarely hit. The current lru_cache (while convenient to add) only helps in the circumstance of redundant picalls to retrieve waypoints starting from the same waypoint, which is rare. A better cache would handle overlapping calls too (for example, allowing for the lookahead parameter not to have to match, and even for different starting waypoints, among other things). However, given the complexity of that change, I decided to leave it until a later sprint -- we can file it as a separate issue as Tucker requested -- and just push what we have now.

This is now tracked as Issue #679.


Clarification on usage?

I'm looking to pull the list of current GlobalProtect users from a PA using this module, and I can connect to the PA okay using Get-PaDevice so I know the creds are good. When I try to show the current GP users, I get an Illegal parameter [request] error. I may be using the command wrong but there weren't any examples provided. Is there a clarification on the intent of the Invoke-PaApiOperation cmdlet? Happy to retract the issue if I'm using the module wrong...
PS C:\Users\test> Invoke-PaApiOperation -Cmd ""
Invoke-WebRequest: C:\Users\test\Documents\PowerShell\Modules\PowerAlto\4.0.46\Classes\Main\PaloAltoDevice.Class.ps1:163:26
Line |
163 |              $rawResult = Invoke-WebRequest @QueryParams
|                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| Illegal parameter [request]

Hey @nfields03,
I don't know if you have found a solution but I needed something similar and I came across this issue.

Go to: https://firewall1/php/rest/browse.php XML API  > Operational Commands > show > global-protect-gateway > current-user.

Copy the contents from the xml text area:

<show><global-protect-gateway><current-user></current-user></global-protect-gateway></show>

Connect to the firewall:

 Get-PaDevice -DeviceAddress firewall1 -Credential (Get-Secret -Name supersecretapikey)

Paste the contents of the xml text aera in the -Cmd parameter of the Invoke-PaApiOperation and execute the command:

$Response = (Invoke-PaApiOperation -Cmd "<show><global-protect-gateway><current-user></current-user></global-protect-gateway></show>").response

View the current GP users:

 $Response.result.entry | Select-Object -Property *

In general, it'd be great if there were more usage examples to help jump start users in using this module.


add documentation for extra volume mounts in agent

I noticed this documentation was either missing or had incorrect syntax.

My example for volumeMounts is bad. I will work on fixing this.

@CrimsonFez Do you want to update your example still?

I did. It should be this commit https://github.com/woodpecker-ci/helm/pull/78/commits/b11c531850d88a9a4399881644a4fd83db99c8cd

Ah sorry, totally overlooked this commit!


Document decision leading to dbt/QuickSight

What does this pull request do?
Document decision leading to dbt/QuickSight
What is the intent behind these changes?
The intent behind specific solutions is essential for posterity to check if something still meets the original purpose.

Thank you!


C# Fix ByteString namespace qualification

Codecov Report

Merging #1921 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1921      +/-   ##
============================================
+ Coverage     85.76%   85.77%   +<.01%
- Complexity     4784     4786       +2
============================================
  Files           441      441
  Lines         19164    19172       +8
  Branches       1998     1999       +1
============================================
+ Hits          16436    16444       +8
  Misses         2046     2046
  Partials        682      682

Impacted Files
Coverage Δ
Complexity Δ

...codegen/transformer/csharp/CSharpSurfaceNamer.java
91.69% <100%> (+0.05%)
86 <1> (+1)
:arrow_up:

...en/transformer/csharp/CSharpCommonTransformer.java
95.08% <100%> (+0.08%)
13 <1> (ø)
:arrow_down:

...ansformer/csharp/CSharpModelTypeNameConverter.java
94% <100%> (+0.2%)
34 <1> (+1)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b571b37...d0d7176. Read the comment docs.


docs(readme): change from react

Codecov Report

Merging #323 (20e4536) into master (beab5be) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   58.55%   58.55%
=======================================
  Files          45       45
  Lines        2560     2560
  Branches      559      559
=======================================
  Hits         1499     1499
  Misses        926      926
  Partials      135      135

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56470a...20e4536. Read the comment docs.


Code blocks are rendered incorrectly if they come after text without a new line

    Example:
    ```clojure
    (def spouse
      {:name "Alice"
       :profile-pic-href "alice.png"})
    ```

gets rendered like:

HTML:

Example:
`clojure
(def spouse
  {:name "Alice"
   :profile-pic-href "alice.png"})

Same when there is no empty line after the code block:
    ```clojure
    :foo
    ```
    Now the ugly update function from above becomes as simple as:

    ```clojure
    :bar
    ```

renders like:

This is by design. Clarktown parses blocks, and blocks are created by having two line breaks in-between. Thus, your example is just one block of text as far as Clarktown is concerned and not two different ones. And since the block starts with regular text, it determines it's just a paragraph and not a code block, which starts with with the uptick characters. You really want to have two line breaks between blocks.
To make this work would require some significant rewrite of the underlying architecture as the whole premise is built under the idea that blocks are separated by two newlines.


Add tin snips

I added tin snips

what are they, if i may ask

cutting metal sheets
for make more drills with that metal sheets but cutted


[Bug]: Typescript SDK dataflow classic template issues

What happened?
When trying to create a dataflow classic template (using -runner=dataflow --template_location='${gcsPath}') the program never exits, which makes it hard to setup as part of CI/CD.
Also getting this error, while this happens after the template was uploaded, so it doen't effect deployment:
ERROR:apache_beam.runners.portability.local_job_service:Error running pipeline.
Traceback (most recent call last):
  File "/Users/cheskeltwersky/.apache_beam/cache/venvs/py-3.11-beam-2.53.0rc2-da39a3ee5e6b4b0d3255bfef95601890afd80709/lib/python3.11/site-packages/apache_beam/runners/portability/local_job_service.py", line 297, in _run_job
    self.result = self._invoke_runner()
                  ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/cheskeltwersky/.apache_beam/cache/venvs/py-3.11-beam-2.53.0rc2-da39a3ee5e6b4b0d3255bfef95601890afd80709/lib/python3.11/site-packages/apache_beam/runners/dataflow/dataflow_job_service.py", line 39, in _invoke_runner
    dataflow_runner.DataflowRunner.poll_for_job_completion(
  File "/Users/cheskeltwersky/.apache_beam/cache/venvs/py-3.11-beam-2.53.0rc2-da39a3ee5e6b4b0d3255bfef95601890afd80709/lib/python3.11/site-packages/apache_beam/runners/dataflow/dataflow_runner.py", line 142, in poll_for_job_completion
    job_id = result.job_id()
             ^^^^^^^^^^^^^^^
  File "/Users/cheskeltwersky/.apache_beam/cache/venvs/py-3.11-beam-2.53.0rc2-da39a3ee5e6b4b0d3255bfef95601890afd80709/lib/python3.11/site-packages/apache_beam/runners/dataflow/dataflow_runner.py", line 682, in job_id
    return self._job.id
           ^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'id'
Exception in thread Thread-4 (_run_job):
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 1045, in _bootstrap_inner
    self.run()
  File<EMAIL_ADDRESS>line 982, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/cheskeltwersky/.apache_beam/cache/venvs/py-3.11-beam-2.53.0rc2-da39a3ee5e6b4b0d3255bfef95601890afd80709/lib/python3.11/site-packages/apache_beam/runners/portability/local_job_service.py", line 297, in _run_job
    self.result = self._invoke_runner()
                  ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/cheskeltwersky/.apache_beam/cache/venvs/py-3.11-beam-2.53.0rc2-da39a3ee5e6b4b0d3255bfef95601890afd80709/lib/python3.11/site-packages/apache_beam/runners/dataflow/dataflow_job_service.py", line 39, in _invoke_runner
    dataflow_runner.DataflowRunner.poll_for_job_completion(
  File "/Users/cheskeltwersky/.apache_beam/cache/venvs/py-3.11-beam-2.53.0rc2-da39a3ee5e6b4b0d3255bfef95601890afd80709/lib/python3.11/site-packages/apache_beam/runners/dataflow/dataflow_runner.py", line 142, in poll_for_job_completion
    job_id = result.job_id()
             ^^^^^^^^^^^^^^^
  File "/Users/cheskeltwersky/.apache_beam/cache/venvs/py-3.11-beam-2.53.0rc2-da39a3ee5e6b4b0d3255bfef95601890afd80709/lib/python3.11/site-packages/apache_beam/runners/dataflow/dataflow_runner.py", line 682, in job_id
    return self._job.id
           ^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'id'

Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
Issue Components

[ ] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[X] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam YAML
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[X] Component: Google Cloud Dataflow Runner

https://github.com/apache/beam/pull/29887 fixed the error, but it still does not exit


HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

…is strange

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 35s
master passed

+1 :green_heart:
compile
2m  6s
master passed

+1 :green_heart:
shadedjars
5m 32s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 13s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

-1 :x:
mvninstall
1m 45s
root in the patch failed.

-1 :x:
compile
0m 37s
hbase-server in the patch failed.

-0 :warning:
javac
0m 37s
hbase-server in the patch failed.

-1 :x:
shadedjars
4m  7s
patch has 16 errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 44s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m  4s
hbase-client in the patch passed.

-1 :x:
unit
0m 38s
hbase-server in the patch failed.

26m 23s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1850

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 096938a592c1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 08c97d3a87

Default Java
1.8.0_232

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt

javac
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/testReport/

Max. process+thread count
340 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 33s
master passed

+1 :green_heart:
checkstyle
1m 52s
master passed

+1 :green_heart:
spotbugs
6m  3s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

-1 :x:
mvninstall
1m 42s
root in the patch failed.

+1 :green_heart:
checkstyle
0m  9s
The patch passed checkstyle in hbase-protocol-shaded

+1 :green_heart:
checkstyle
0m 30s
hbase-client: The patch generated 0 new + 189 unchanged - 4 fixed = 189 total (was 193)

+1 :green_heart:
checkstyle
1m  0s
hbase-server: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
hadoopcheck
1m 51s
The patch causes 16 errors with Hadoop v3.1.2.

-1 :x:
hadoopcheck
3m 48s
The patch causes 16 errors with Hadoop v3.2.1.

-1 :x:
hbaseprotoc
0m 33s
hbase-server in the patch failed.

-1 :x:
spotbugs
0m 30s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

29m 12s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1850

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool

uname
Linux e96a2a80f353 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 08c97d3a87

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-general-check/output/patch-javac-3.2.1.txt

hbaseprotoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt

spotbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

-1 :x:
mvninstall
2m 39s
root in the patch failed.

-1 :x:
compile
0m 54s
hbase-server in the patch failed.

-0 :warning:
javac
0m 54s
hbase-server in the patch failed.

-1 :x:
shadedjars
5m 20s
patch has 16 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 30s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 45s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m  8s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 29s
hbase-client in the patch passed.

-1 :x:
unit
0m 50s
hbase-server in the patch failed.

35m 58s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1850

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 71fac8e0c290 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 08c97d3a87

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

javac
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/testReport/

Max. process+thread count
208 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 42s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  1s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  6s
master passed

+1 :green_heart:
checkstyle
1m 57s
master passed

+1 :green_heart:
spotbugs
6m 46s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 58s
the patch passed

+1 :green_heart:
checkstyle
0m  8s
The patch passed checkstyle in hbase-protocol-shaded

+1 :green_heart:
checkstyle
0m 33s
hbase-client: The patch generated 0 new + 192 unchanged - 4 fixed = 192 total (was 196)

+1 :green_heart:
checkstyle
1m 13s
hbase-server: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 47s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
hbaseprotoc
2m 21s
the patch passed

+1 :green_heart:
spotbugs
8m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

54m 21s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1850

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool

uname
Linux d83a3782ccd4 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 61a7468df7

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 19s
master passed

+1 :green_heart:
checkstyle
1m 53s
master passed

+1 :green_heart:
spotbugs
2m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 26s
the patch passed

+1 :green_heart:
checkstyle
0m 32s
hbase-client: The patch generated 0 new + 189 unchanged - 4 fixed = 189 total (was 193)

+1 :green_heart:
checkstyle
1m  7s
hbase-server: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 24s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

39m 51s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1850

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux be0579bcf86c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b2ec4c1ea0

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 28s
the patch passed

+1 :green_heart:
compile
2m  6s
the patch passed

+1 :green_heart:
javac
2m  6s
the patch passed

+1 :green_heart:
shadedjars
7m 42s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 35s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 54s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 51s
hbase-client in the patch passed.

+1 :green_heart:
unit
193m 24s
hbase-server in the patch passed.

234m  0s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1850

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3362cf04bdc2 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b2ec4c1ea0

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/3/testReport/

Max. process+thread count
3707 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 55s
master passed

+1 :green_heart:
compile
1m 21s
master passed

+1 :green_heart:
shadedjars
6m  4s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 43s
the patch passed

+1 :green_heart:
compile
1m 21s
the patch passed

+1 :green_heart:
javac
1m 21s
the patch passed

+1 :green_heart:
shadedjars
6m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  6s
hbase-client in the patch passed.

+1 :green_heart:
unit
205m 13s
hbase-server in the patch passed.

234m 42s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1850

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f4096ed218b1 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b2ec4c1ea0

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/3/testReport/

Max. process+thread count
3030 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1850/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Different events for 404 and 410

I think the event name ambiguity is a little misleading (although it is documented in the readme that 410 triggers fetch404). I have implemented a quick fix for this to distinguish the event names if you want the pull request?
My rationale is that fetch404 should not have the 410 event status code bundled in because there are instances when they would need to be handled differently.
My use case is that I am building a tool that downloads all text/html and application/xhtml+xml pages and validates them using the nu validator. I want to add the logic to download and validate 404 errors but ignore 410 errors. Clearly I can just switch on the status code in fetch404 but there is something about the event name that bothers me.
I suggest that either:

fetch404 and fetch410 are emitted (quickly implemented, tests passing)
the event name is renamed to notFound or something similar

Sorry if this is a little pedantic.

Clearly, renaming to notFound is a breaking change and requires a minor version bump, as does distinguishing event names too (people might already be switching on status code in fetch404).

Good suggestion, and definitely an artefact of simplecrawler's evolution. I'm thinking we could add a notFound event which would take both 404s and 410s, but remove the 410 responses from emitting a fetch404, which is clearly confusing.

I was thinking it wouldn't hurt to emit notFound, fetch404 and for consistency also emit fetch410. That should cover all requirements. I don't think emitting the additional events would impact performance much, this should do the trick:
// Emit 404 event
crawler.emit("fetch" + response.statusCode, queueItem, response);
crawler.emit('notFound', queueItem, response);

I think separating the 404's and the 410's sounds like a sound idea! I'm not 100% sure that making 3 events out of 1 feels like the best way to go about this though (but I'm not 100% sure it's the wrong way either). Instinctively I'd probably vote for doing one fetchnotfound (404 and 410) and one fetch404 (just 404).

You are correct, three is not the way to go, thinking some more, my preference is fetch404 and fetch410, then when both need to be handled with the same logic:
crawler.on('fetch404', onError)
  .on('fetch410', onError);

Done :)
Incidentally, I believe when a 404/410 is encountered the body of the document is not downloaded, is that correct? If so, how should I go about fetching the body content in this situation?

On second thought, I agree with you, fetch404 and fetch410 seems to be the simplest and most consistent way of going about it. Feel free to submit a PR for it, but since it's a breaking change, I'd argue for us to wait a little before merging it. That way we can aggregate a few breaking changes and then bump the major version number

@fredrikekelund, I agree that makes sense. I just need to write a test for the 410 event and then I think the PR can be submitted. Not much to it ;)

Oops, the answer to my previous question is in the readme:
https://github.com/cgiffard/node-simplecrawler#a-note-about-http-error-conditions
!

Closing this as #224 was merged


Got an error on dataset r6.2 in feature extraction

hi, i got an error on dataset r6.2 in feature extraction and it seems to appear in step 2
the python version is 3.10.14, and pandas version is 2.2.2
`Traceback (most recent call last):
File "/home/test/miniconda/envs/cert_dataset_preprocess/lib/python3.10/site-packages/pandas/core/indexes/base.py", line 3805, in get_loc
return self._engine.get_loc(casted_key)
File "index.pyx", line 167, in pandas._libs.index.IndexEngine.get_loc
File "index.pyx", line 173, in pandas._libs.index.IndexEngine.get_loc
TypeError: '186    False
187    False
188    False
189     True
190    False
Name: scenario, dtype: bool' is an invalid key
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/test/miniconda/envs/cert_dataset_preprocess/lib/python3.10/site-packages/pandas/core/frame.py", line 4562, in _set_value
iindex = self.index.get_loc(index)
File "/home/test/miniconda/envs/cert_dataset_preprocess/lib/python3.10/site-packages/pandas/core/indexes/base.py", line 3817, in get_loc
self._check_indexing_error(key)
File "/home/test/miniconda/envs/cert_dataset_preprocess/lib/python3.10/site-packages/pandas/core/indexes/base.py", line 6059, in _check_indexing_error
raise InvalidIndexError(key)
pandas.errors.InvalidIndexError: 186    False
187    False
188    False
189     True
190    False
Name: scenario, dtype: bool
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/disk1/PycharmProject/rx.2/r6.2/r6.2/feature_extraction.py", line 1073, in
users = get_mal_userdata(dname)
File "/disk1/PycharmProject/rx.2/r6.2/r6.2/feature_extraction.py", line 224, in get_mal_userdata
if data == 'r6.2': listmaluser.at[listmaluser['scenario'] == 4, 'start'] = '02' + listmaluser[
File "/home/test/miniconda/envs/cert_dataset_preprocess/lib/python3.10/site-packages/pandas/core/indexing.py", line 2586, in setitem
return super().setitem(key, value)
File "/home/test/miniconda/envs/cert_dataset_preprocess/lib/python3.10/site-packages/pandas/core/indexing.py", line 2542, in setitem
self.obj._set_value(*key, value=value, takeable=self._takeable)
File "/home/test/miniconda/envs/cert_dataset_preprocess/lib/python3.10/site-packages/pandas/core/frame.py", line 4581, in _set_value
raise InvalidIndexError(
pandas.errors.InvalidIndexError: You can only assign a scalar value not a <class 'pandas.core.series.Series'>`

Sorry for late reply.
Please use python 3.8 with the recently added packages in requirements.txt


chore: add role assignment of Users to blob storage without a group

that can`t be the solution but it shows a difference to adding yourself without a group directly as a role assignment @felixzieger can you test it in your environment?

Works for me.


New floors

About the PR
aka "can we have tiles that aren't impossible to modify please thanks"
Screenshots

Changelog
:cl: moony

add: A whole new tileset to help make future tiles easier to make, and also to reduce the grunge just a little.
remove: Removed sovl.

wheres my di- oh right it's not rsi this is so sad.

absolutely refuse to bikeshed this just merge it and let players decide if they like it

tbh feeling the same way. Better just to test it out rather than having petty bikeshedding over probably the most insignificant topic imaginable.

Something every player will be staring at for almost the entire duration of gameplay is not insignificant.
There will be many people that dislike such a change anyways, and you will hear it. Good luck figuring out if they are a minority or majority.

why not both?

why not both?

seems weird to have two very similar tiles in the game. Better to choose one or the other.

to be honest, as long as the game is functional it can legit look liek a 5 year olds crayon drawing of the end of the world for all i care, also ithe tiles dont look that bad just kinda wonder why all of them got this grill pattern to them

It might look different when actually in game, but going off the screenshot I'm not a huge fan of the grill pattern/texture on the tiles. It makes them look blurry. Other than that they look great though

I really don't like the way this looks tbh.

the smooth-tiles & grill pattern feel... off, that's all i have to say at least

Not as a replacement, possibly as an alternative for marking out depts or whatever. Looks too stylised (yet not?) to be a common floor and or anyone else's comments on blurry / low res.