[CLOSED] Test-AdfsServerToken fails if AD FS or WAP doesn't support TLS1.0

 Issue by maweeras-msft
Friday May 11, 2018 at 14:28 GMT
Originally opened as https://github.com/Microsoft/adfsManagementTools/issues/8

If an AD FS farm has been hardened for TLS by disabling TLS1.0, TLS 1.1 as per https://docs.microsoft.com/en-us/windows-server/identity/ad-fs/operations/manage-ssl-protocols-in-ad-fs then the Test-AdfsServerToken will fail as invoke-webrequest uses TLS 1.0 by default.
PS C:\WINDOWS\system32> $error[0] | fl * -f

PSMessageDetails      :
Exception             : System.Net.WebException: The underlying connection was closed: An unexpected error occurred on
                        a send. ---> System.IO.IOException: Unable to read data from the transport connection: An
                        existing connection was forcibly closed by the remote host. --->
                        System.Net.Sockets.SocketException: An existing connection was forcibly closed by the remote
                        host
                           at System.Net.Sockets.NetworkStream.Read(Byte[] buffer, Int32 offset, Int32 size)
                           --- End of inner exception stack trace ---
                           at System.Net.Sockets.NetworkStream.Read(Byte[] buffer, Int32 offset, Int32 size)
                           at System.Net.FixedSizeReader.ReadPacket(Byte[] buffer, Int32 offset, Int32 count)
                           at System.Net.Security.SslState.StartReceiveBlob(Byte[] buffer, AsyncProtocolRequest
                        asyncRequest)
                           at System.Net.Security.SslState.CheckCompletionBeforeNextReceive(ProtocolToken message,
                        AsyncProtocolRequest asyncRequest)
                           at System.Net.Security.SslState.ForceAuthentication(Boolean receiveFirst, Byte[] buffer,
                        AsyncProtocolRequest asyncRequest)
                           at System.Net.Security.SslState.ProcessAuthentication(LazyAsyncResult lazyResult)
                           at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext,
                        ContextCallback callback, Object state, Boolean preserveSyncCtx)
                           at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback
                        callback, Object state, Boolean preserveSyncCtx)
                           at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback
                        callback, Object state)
                           at System.Net.TlsStream.ProcessAuthentication(LazyAsyncResult result)
                           at System.Net.TlsStream.Write(Byte[] buffer, Int32 offset, Int32 size)
                           at System.Net.ConnectStream.WriteHeaders(Boolean async)
                           --- End of inner exception stack trace ---
                           at Microsoft.PowerShell.Commands.WebRequestPSCmdlet.GetResponse(WebRequest request)
                           at Microsoft.PowerShell.Commands.WebRequestPSCmdlet.ProcessRecord()
TargetObject          : System.Net.HttpWebRequest
CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-WebRequest], WebException
FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeWebRequestCommand
ErrorDetails          :
InvocationInfo        : System.Management.Automation.InvocationInfo
ScriptStackTrace      : at Test-AdfsServerToken, C:\Program
                        Files\WindowsPowerShell\Modules\ADFSDiagnostics\1.1.0\Public\Test-AdfsServerToken.ps1: line 79
                        at <ScriptBlock>, <No file>: line 1
PipelineIterationInfo : {}

As a workaround setting TLS1.2 to be used like so then makes this cmdlet work.
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
Can we have the logic for the cmdlet updated to handle the error and use TLS 1.2 if required?

 Comment by madhavpatel6
Monday May 21, 2018 at 17:12 GMT

Thanks for the feedback, we have addressed this issue in PR #9. You can now specify a switch to indicate which Tls version you want to utilize. -TestTls10, -TestTls11, or -TestTls12. If you installed the module via Install-Module you can run Update-Module and you will have the new changes.

 Comment by bongiovimatthew-microsoft
Monday May 14, 2018 at 15:17 GMT

Thanks for finding this @maweeras-msft,.We'll take a look and see what we can do.


Return point

Return to clinical services tab after filling or canceling form.
Always return to previous selected tab after editing or viewing patient information.
Use $state.go instead of $location.url.

Coverage decreased (-0.03%) to 42.789% when pulling 27c42774719ca2965f1da1974df9e05e8f702a78 on ynurmahomed:return-point into 59af7a4a6d1ca73b587ae8a52ba473d198bbfddf on esaude:master.

 Provide a return to the starting point after completing a task

Coverage increased (+1.003%) to 43.822% when pulling cfabb3d54313ff2fe904cce43b7c5b467cb7b4e7 on ynurmahomed:return-point into 59af7a4a6d1ca73b587ae8a52ba473d198bbfddf on esaude:master.


Deeplink to launch multiple credentialOffer process

with &uri_list=[....]

In jeprouvemonage, altme and talao;

deeplink example:
https://app.altme.io/app/download?uri_list=https%3A%2F%2Fissuer.talao.co%2Fmy_route_to_wallet_endpoint%2F1111111111&uri_list=https%3A%2F%2Fissuer.talao.co%2Fmy_route_to_wallet_endpoint%2F2222222222
uri_list appear for each element of the list.
first step of dev: write a dart test with this deeplink to check ability of dart to parse it correctly.


Runner stopping due to node limit not approached

Hi Max,
I use the Runner with usize::MAX as the e-graph size limit. However, the stopping reason of the runner turns out to be Some(NodeLimit(11476)), although I don't anticipate that e-graph size would reach MAX if the runner didn't stop (and there are no loops in the e-graph). Could there be a limit on the e-graph size specified somewhere else in the codebase which precedes what the user specifies through with_node_limit?
Thanks!

Hmm that sounds fishy. Could you show a code snippet where you set up the
runner?
On Fri, Jan 7, 2022 at 7:09 AM Ecenur Ustun @.***>
wrote:

Hi Max,
I use the Runner with usize::MAX as the e-graph size limit. However, the
stopping reason of the runner turns out to be Some(NodeLimit(11476)),
although I don't anticipate that e-graph size would reach MAX if the runner
didn't stop (and there are no loops in the e-graph). Could there be a limit
on the e-graph size specified somewhere else in the codebase which precedes
what the user specifies through with_node_limit?
Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/egraphs-good/egg/issues/154, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANTPTBFUOUNKN7YQLS6QRTUU363JANCNFSM5LO7RQ5A
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I assigned MAX to time limit, iter limit, node limit, and used the SimpleScheduler so that the e-graph can be fully saturated. But somehow runner.stop_reason gives Some(NodeLimit(11476)).
let runner = Runner::default().with_expr(&start).run(rules).with_time_limit(Duration::from_secs(u64::MAX)).with_iter_limit(usize::MAX).with_node_limit(usize::MAX).with_scheduler(SimpleScheduler);

I can't see a reason that would be the case. Can you point me to some code where I can reproduce the bug?

I just created a mirror and added this test to math.rs. Sent you a github invitation. Thank you!

Ah! The issue is the order of method calls in the builder pattern. run() actually runs the Runner with the arguments you have so far. So your with_*_limit calls aren't doing anything.
I moved .run() to the end of the chain and things work as I would expect them too (it saturates after 12 iterations).


Nullalbe variable will be validated if not configured

Describe the bug

Steps to reproduce

Add a template with source https://github.com/unitong/test-variable.
Create a service and don't fill in the Test Map field.

Result

Failed to create service.

Check the api response, test_map is nullable.

Expected behavior

Environment

Walrus version: main ab30b62917ad1ab35c43d37fb7a646efbd9a1572
UI version: dev-6e415a8

Additional context
Add any other context about the problem here.

Environment

Walrus version: main e462fc8e68c52778f70f5b56c9eb0401a9a88fcf
UI version: dev-aae40b4

Test Result: Failed

Environment

Walrus version: main 8ff16bfe4326036642753b1ba895fa5b0e3b1791
UI version: dev-2fca30f

Test Result:
The concept of 'nullable' has been deprecated.


ckb-next doesn't provide ckb-next-daemon

Describe the bug
When running the ckb-next application, an error dialog appears stating the ckb-next-daemon isn't running.
When looking at the available systemd daemons, ckb-next-daemon isn't there.
Have installed ckb-next using both system nix configuration and home-manager. Both exhibit the same issue.
Have tried rebooting.
ckb-next doesn't seem to provide the systemd daemon required for the application to communicate with the devices.
To Reproduce
Steps to reproduce the behavior:

add ckb-next application to either system configuration.nix or home-manager home.nix
sudo nixos-rebuild switch or home-manager switch
Run ckb-next

Expected behavior
ckb-next app appears and runs
Screenshots

Notify maintainers
@kierdavis
Metadata
$ nix-shell -p nix-info --run "nix-info -m"

system: "x86_64-linux"
host os: Linux 5.4.62, NixOS, 20.03.2913.4bd1938e03e (Markhor)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.6
channels(root): "home-manager-20.03, nixos-20.03.2913.4bd1938e03e"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: ckb-next
# a list of nixos modules affected by the problem
module: ckb-next

Ok, it seems I have to install this with hardware.ckb-next.enable = true.
As soon as I did that, the daemon ran.
Found this out by reading through issue #64032.
I find this quite confusing. Is there a way to determine when I need to do this and when I need to just install it like a normal application?


opt refactor the log dir config

Proposed changes
Refactor the config for log dir of FE and BE
TLDR:

Use env variable LOG_DIR to set root log dir
Remove sys_log_dir for FE and BE

Details:

FE

The root log dir is set by env variable LOG_DIR in fe.conf
The default value of audit_log_dir is same as ${LOG_DIR}/
The default value of spark_launcher_log_dir is ${LOG_DIR}/spark_launcher_log
The default value of nereids_trace_log_dir is ${LOG_DIR}/spark_launcher_log
The origin sys_log_dir is deprecated, and default value is "".
But for compatibility, if user already set sys_log_dir before, Doris will still use it as root log dir.

BE

The root log dir is set by env variable LOG_DIR in be.conf
Remove pipeline_tracing_log_dir, use ${LOG_DIR} directly.
The origin sys_log_dir is deprecated, and default value is "".
But for compatibility, if user already set sys_log_dir before, Doris will still use it as root log dir.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall


[#152241494] Billing API

What
We are extending the event collector application to give us a "Billing API" that allows us to query resource usage and calculate costs for that usage. It may make sense to rename this repository "paas-billing" in the future, and use it to contain those items that are dependent on the billing database.

A MATERIALIZED VIEW is created in the database that gets updated at a set interval (currently 1hr) which normalizes the raw event data into rows of resource_guid, time period, pricing_plan_id , then joins the rows with data from a pricing_plans table that contains the information required to calculate the prices. The view caches and indexes data in the following form so that we can perform queries against it efficiently.

...
duration
guid
org
space
pricing_plan_id
price
...

...
2017-11-01 08:14 to 2017-11-19 08:14
{thing1}
{org1}
{space1}
{planA}
£x
...

...
2017-11-01 09:10 to 2017-11-19 10:10
{thing2}
{org2}
{space1}
{planB}
£x
...

A pricing_plans table is added to the database that contains the formulas required to calculate costs for each resource. For example a pricing_plan row might look like:

id
name
valid_from
plan_guid
formula

2
compute instance
2017-11-01
{plan_guid}
($memory_in_mb / 1000) * ($time_in_seconds)

3
tiny postgres
2017-11-01
{plan_guid}
1 * $time_in_seconds

Pricing plans can change over time so they have a valid_from field. The view calculation handles splitting usage over the valid ranges.

A REST/JSON API exposes aggregated data at several levels. Only guid details are returned in the data at the moment. If you want names you would need to call out the cf:

/organisations list totals for all orgs
/organisations/:org_guid list total for a single org
/organisations/:org_guid/spaces list totals for each space in an org
/organisations/:org_guid/resources list totals for each resource in org (a resource is a single thing - like an "app" or a "service")
/spaces list totals for all spaces
/spaces/:space_guid list total for a single space
/spaces/:space_guid/resources list totals for each resource in space
/resources list totals for all resources
/resources/:resource_guid list total for a single resource
/events [experimental] list all events ("events" are all the start/stop points with calculated billing, unlike "resources" which are aggregate totals for each item over a range). Events would allow you to see when something happens
/resources/:resource_guid/events as above but for a single resource
/pricing_plans fetch the pricing plans

A (throwaway) example HTML rendering of an aggregated report can be found at / you will be prompted to login via UAA. This is meant purely as an illustration of what is possible for now.

How to review

Deploy to dev using https://github.com/alphagov/paas-cf/pull/1116
Go start/stop some apps/services to generate some events in your dev environment (ie. restart the healthcheck apps, create a postgres service etc
Visit https://paas-usage-events-collector.$DEPLOY_ENV.dev.cloudpipelineapps.digital/
Login as an admin when prompted and authorize the app
Visit /pricing_plans and create a pricing plan for the compute plan with guid: f4d4b95a-f55e-4593-8d54-3364c25798c4
Visit /pricing_plans and press the "Seed pricing plans" button to create initial pricing plans for all known services.
Visit / to see an HTML report of some pricing
Query the Billing API for some results

Who can review
Not @chrisfarms, @46bit, @camelpunch, @samcrang

Thoughts

Manifest has no-route :true
Starting with an empty db causes the app to crash
Lacking in security, it uses basic auth at present. I have not checked for other issues as yet
The app currently doesn't bind to the port provided by CF, this has restricted my testing to using the local method so far.

App and service events have been recorded and I have been able to run queries against them whilst working locally.

It seems to me we run the database migration queries at every start which might be not optimal, because we drop the billing view every time before recreating it. Probably we should store which migrations ran in the db so we run only the new ones.

Yeah it's not really a "migration" at the moment... more like a set of definitions executed in order.
I agree we could improve it and have a table for storing where we are in the migration, however since I expect we will be tweaking these things a fair bit in coming iterations, and since most of the things in the "migration" can safely be destroyed and recreated without issue (functions/views), this was preferable than ending up with lots of migrations that redefine the same things over and over with slight changes.
The main "billable" view gets recreated every hour anyway, and doing it on startup (to get the latest version on first start) would be less confussing than altering the view but getting the old one for an hour on start.

Two remaining issues:

new indexes were created on the wrong table
if I post to repair events it results in an infinite redirect loop and doesn't do anything (tried with curl)

Good catch on indexes ... I didn't notice in the query plan output as I assumed it was doing a seq scan due to the small size of the service events table!... fixed
I believe the redirect loop is due to curl. Did you use -X POST by any chance? ... since I think that forces it to follow redirects using POST too, which is weird and would cause the behaviour you describe.... you can use -d "" instead and it should do as you expect.
Wether or not it "does anything" is somewhat dependant on the state of your data. You would probably have to manually delete events from the database so that there are some missing.

@chrisfarms yeah, you were right with curl - I was expecting something like that. Thanks for the other fix.
Notes for repair for the follow-up story:

we should insert missing start events for apps where the first seen event was a stopped one (or even an update one), the current mechanism won't do this
we should insert missing start events for services where the first seen event was a stopped one (we can't do anything about an update as we don't know the previous state)

Great work, I will approve this now.
@chrisfarms could you please squash the commits before I merge this?


Merch

Create a route for /merch and merch related data should be displayed there , u can pick up  the exact same card from the 7.0 website

I am interested to work in this issue


Main repo

Check out releases if you haven't yet

i can't do anything with .ipa files until my ipad arrives

tell me when you get it I'll teach you how to download it on your iPad


Update version in package.json

The version reported from the GUI still says 0.1.0

Thanks. All fixed! 👍


baseColorFactor-parameter isn't exported

When I set the baseColorFactor-parameter in Blender, it isn't exported.
Nodes in Blender — https://yadi.sk/i/aIuzNlej3NNgKL
Exported material:
{             "name" : "Metal",              "normalTexture" : {                 "index" : 5             },              "occlusionTexture" : {                 "index" : 6             },              "pbrMetallicRoughness" : {                 "metallicFactor" : 0.6000000238418579,                  "roughnessFactor" : 0.6000000238418579             }         }

baseColorFactor is only exported, when directly manipulated in the node.

Hello,
BaseColorFactor is actually exported when a texture is associated with the node but no material is created in the Json file. Is this normal?
Thank you


Can't install libfranka and franka-ros

When I try to install these through the ROS repositories with ROS melodic already installed, I get an error message that apt can't find the .deb files it's looking for, and indeed, the .deb files it's looking for don't match the ones on the ROS repo. What am I doing wrong? My ROS melodic install is fully up to date and I simply tried: sudo apt install ros-melodic-libfranka ros-melodic-franka-ros

Did you try running sudo apt-get update before? Otherwise, can you post the full error output?

Funnily enough I did not. Sorry, I'm used to the more AUR-style system of package management. Thanks for humoring me. Everything works.


update quest point total to 287

Updated the required quest point total to 287

I've pushed another fix as of the new quest that came out today, so closing this.


Added tracker and dht from pigg.es

Added tracker and DHT from pigg.es as known DHT and tracker nodes.

Coverage: 56.58% (-0.06%) from 56.642% when pulling 186061a83e347808fa305cd905b6f86ae81f5ede on Pigges:patch-1 into<PHONE_NUMBER>f851190582be69c92cc476289c0bc8 on lbryio:master.


Layered Navigation Filters

My company sells shoes and t-shirts. The problem is that the filter in navigation shows all sizes for example when I'm in shoes it will show XXL which is not a valid shoe size but is a size for t-shirts. We would really like to get this fixed so we can turn on additional filters and allow bagisto user's customers a better much improved shopping experience.
Simplely - Only show filterable options relevant for the results (including size and brand)
Thanks!

You could create 2 attributes & attribute families
https://bagisto.com/en/bagisto-product-attribute-families/

Hi @CarlJKashnier
We have already fixed it. You can see -https://github.com/bagisto/bagisto/issues/1160
I think, your category consist both of this product that why filterable attribute of both products are showing & recommend you to take pull from master branch, may be you are using old one.
Thanks

Framework Version: 0.1.6

Fixed


Updates README to describe plugin order

Updates README.md to spell out the obvious, that this plugin needs to be applied after the android plugin in order to generate the appropriate task names

Thanks

No problem, thanks for the plugin!


metrics: polish the metrics on Raft IO and Raft Propose sections.

What is changed and how it works?

Issue Number: Close #16251

What's Changed:
This pr add missing legend on filtering statistics by TiKV instance in Raft IO and Raft Propose sections.

Related changes

[ ] PR to update pingcap/docs/pingcap/docs-cn:
[ ] Need to cherry-pick to the release branch

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Release note

None.

/check-issue-triage-complete

We can post a comparison of the effects.

We can post a comparison of the effects.

Already specified in the issue: #16251, and Supplemented more details in the description.

/hold

/merge


Handle pagination errors in chats

Details
Currently we do not handle errors properly in getOlderActions and getNewerActions. All we do is set the loading state back to false, but that will cause the list onEndReached or onStartReached to be called again and a new network request to load more will be triggered. If we are near any edge of the chat, or even worse if we have a chat with few messages we will trigger these requests in a loop.
To solve this we should add an error state to those pagination methods and display an error UI with an option to retry loading. This will prevent this request loop from happening.
Here's the UI I implemented for this error state
Top error:

Bottom error:

Example with comment linking:
https://github.com/Expensify/App/assets/2677334/1c281a27-91ba-490f-b39a-866deb5f5f51
Fixed Issues
$ https://github.com/Expensify/App/issues/40641
PROPOSAL:
Tests

[x] Verify that no errors appear in the JS console
[x] Test error state by failing pagination requests adding the following code in HttpUtils.ts here

if (url.includes('GetNewerActions') || url.includes('GetOlderActions')) {
    return {jsonCode: CONST.JSON_CODE.EXP_ERROR};
}

[x] Test comment linking

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console
[ ] Test error state by failing pagination requests adding the following code in HttpUtils.ts here. It might also be possible to simulate this by turning off internet after loading a chat.

if (url.includes('GetNewerActions') || url.includes('GetOlderActions')) {
    return {jsonCode: CONST.JSON_CODE.EXP_ERROR};
}

[ ] Test comment linking

Go in a long chat and scroll to an old message
Right click and "Copy link"
Go in another chat and paste the link
Clear the cache (Account Settings -> Troubleshoot -> Clear cache and restart)
Go back to the chat with the link and click it
You will be in the middle of a chat and can test loading older / newer messages

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/2677334/1c281a27-91ba-490f-b39a-866deb5f5f51

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Is someone familiar with this code? I noticed the loading indicator for newer messages never seem to show even when comment linking in the middle of a chat that has new messages to load. This also causes the error state not to show since I'm implementing it in ListBoundaryLoader, which I think is the ideal place.

@mountiny Do you know if there is an issue related to this already? Should I create one?
This is currently coming from this convo on slack.

Might also need help here with design and texts, not sure who to tag and I can't seem to add the Design label.

@janicduplessis I dont think there is one, feel free to create it please.
Then we can add design label there too to ensure the looks are as we expect

@mountiny Thanks! Done https://github.com/Expensify/App/pull/40610

@dannymcclain would you be able to help with the design on this PR? thanks!

Going to cc @Expensify/design in here as well. How do you all feel about the Couldn't load UI?
A couple thoughts from me:

I think the message text should be text-supporting color
I think I would propose swapping the button for a spinner when you tap Try again instead of swapping out the whole message for the wall of skeleton loaders—it's kinda weird when the whole message disappears, a bunch of skeleton loaders show up, and then it comes back.

I realize this is unlikely to happen "in real life" as much as it during me testing this, but still, I think it's pretty weird. I would rather the Try again button just change to a spinner, and then if we still can't load, it changes back to the button. If we CAN load new messages, the new messages just replace the whole error message block.
https://github.com/Expensify/App/assets/7516624/d2f707d0-5fe2-4535-8caf-e8ab7aac791c

@dannymcclain Thanks, I like the suggestion, will look at making those changes this week.

Maybe said another way, why exactly does the "Try again" button do to fix the pagination error? Why wouldn't we just do that automatically for the user instead of making them tap a button?

The network requests can fail for various reasons, whether it be a network issue, or some outage on our end. This happened recently to both @mountiny and @quinthar, with the current behaviour the requests are retried in a loop so this is why I suggested introducing an error ui. I’m pretty sure I’ve seen similar in other chat apps before.

with the current behaviour the requests are retried in a loop

@shawnborton This is shown in the attached video here. I've been seeing it a lot in the product too—it's super disorienting and there's seemingly no way to make it stop other than quitting the app and reopening it.

Yeah that's fair, but why does the Try again button work and the automatic retry doesn't?

The main goal is to let the user know there is a problem, and avoid spamming our servers with network requests. Currently it just keeps flashing the loading skeleton while immediately retrying the request. If we show some ui it stops the loop and warn the use about the problem. They can decide to try again and if it fails again then it will show the error state again.

It would be possible to retry the requests a few times, but at some point we need to stop if it keeps failing and let the user know. That is the main goal of this change. If we want to add some automatic retry behaviour it should probably be implemented somewhere else though, more at the networking layer.

So just to make sure I understand correctly, in this PR, if the request fails we'll show you a button to retry. But when you retry, it's likely just going to fail again?

Yes, depending on what the problem was, if it was a random network error it might succeed when retrying, but if it is an outage it probably won’t. At least the user will be warned that an error occurred instead of being stuck in a loading loop.

The current behaviour that causes a loading loop can also be very bad in case of an outage where all clients will start spamming the backend with network requests.

Cool, thanks for explaining. I definitely don't want to block on progress here and agree that this is better than what we currently experience. Thanks for hearing me out!

There is definitely a good case for retrying failed requests automatically, but that would be a different project. It would be more like whenever a request fail we can try to see what the reason for the failure is and if we think it could work if trying again (let’s say its a network error) then we can re-send the request automatically. Those retries could be limited to only a few times and possibly with a delay. Then in case the retries fail it would throw an error which would be handled by the error states of the app (including the one added here).

@janicduplessis, let me know when this is ready for review!

@Gonals Should be ready today, working on it now!

Updated the UI as per @dannymcclain suggestions. Here's an updated video of loading failing.
https://github.com/Expensify/App/assets/2677334/82d0a8b7-cb54-4cb1-8a56-f6b658b2406c

@Gonals This is ready!

Conflicts! 😆

@Gonals Fixed!

Looks like we have some conflicts now, I will fix it soon. Do we want a 2nd review? I will try to get more attention on this.

Assigning @rojiphil as the C+ reviewer. @rojiphil, will you be able to take a look at this?

Sure. Will take a look at this today and update.

I am still reviewing but no updates yet. I will continue tomorrow and update again.

Conflicts fixed

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari
TODO

Android: Native
TODO

Android: mWeb Chrome
TODO

iOS: Native
TODO

iOS: mWeb Safari
TODO

MacOS: Desktop
TODO

@janicduplessis  Is the test case for  Testing comment linking  added to address an edge case, or did we use this for testing error message for newer actions? If this is to address an edge case, please provide testing steps for this as I am not clear on how to reproduce this.

Yes, it is to test GetNewerActions, will provide clearer testing steps on how to test comment linking.

@rojiphil I added the steps to test comment linking under QA Steps.
Addressed your review feedback too, let me know if it's good.

@rojiphil What is your ETA for finishing this review? Can you please prioritize this one over others please?

Addressed your review feedback too, let me know if it's good.

@janicduplessis Thanks for the changes. I just tested error condition for GetNewerActions and the error UI came up.
But we have another problem to address. When we retry GetNewerActions, the entire error message UI disappears for a moment and shows up again on failure of the API request. Like the GetOlderActions, shouldn't the error message Ui remain on retry until the API response is known? Here is a video to demonstrate this:
https://github.com/Expensify/App/assets/3004659/beeea6cf-9a18-4aaf-91ef-b4bdaaa8000f

@rojiphil good catch. I think they should behave the same like you're suggesting.

It currently disappears during loading because canShowHeader is false, which I think shouldn’t be. I’m a bit hesitant to add some workaround here since it seems like canShowHeader shouldn’t be false here and there might be a bug with it that could be addressed separately. What do you think?

I think it would work, but I am still hesitant on adding more complexity. For example we do rely on loading state in a few places like here to not trigger additional requests. I am worried that if we have cases of loading data, but not setting this loading state might cause problems and make it more likely to introduce bugs in the future.
My current idea would be to merge it like this, and investigate the canShowHeader issue separately since currently there are just no loading states for new messages so it seems bugged. If canShowHeader is actually working as expected then maybe we can consider another solution.

I agree we should avoid adding too much complexity. If it comes done to the issue with the button disappearing until new failure comes in, i think its fine for use to merge. Its rare case
@rojiphil can you please continue with the checklist and treat that issues as nab?

My current idea would be to merge it like this, and investigate the canShowHeader issue separately since currently there are just no loading states for new messages so it seems bugged. If canShowHeader is actually working as expected then maybe we can consider another solution.

Would be happy to work on this when we do.

can you please continue with the checklist and treat that issues as nab?

@mountiny Checklist is done.

Thanks @mountiny !

@janicduplessis Can you help us with this step?

Test error state by failing pagination requests adding the following code in HttpUtils.ts here. It might also be possible to simulate this by turning off internet after loading a chat.

@rojiphil @mountiny could you help with the QA steps.

Test error state by failing pagination requests adding the following code in HttpUtils.ts here. It might also be possible to simulate this by turning off internet after loading a chat.

@janicduplessis @rojiphil @mountiny Can we run only the following step?

Go in a long chat and scroll to an old message
Right click and "Copy link"
Go in another chat and paste the link
Clear the cache (Account Settings -> Troubleshoot -> Clear cache and restart)
Go back to the chat with the link and click it
You will be in the middle of a chat and can test loading older / newer messages

Yea I think this might be hard to test on staging without being able to change the code. I will see if I can think of something.

@robertjchen @janicduplessis It would be great if you can validate this PR internally then.

@Beamanator Could this PR be validated internally?

@rojiphil I figured out the issue that was preventing the loading state from showing, fix here https://github.com/Expensify/App/pull/42332

@mountiny @rojiphil @janicduplessis  can one of you please test this internally in staging? QA is having trouble 🙏

@janicduplessis is that PR required to be CPed to staging or it can go through the normal deploy process?
I am not sure how this can be tested without changing code. I think we could however mark this off the checklist and we can monitor this change in the #newdot-quality room

I think it can just go to normal deploy process. It is hard to test since it requires specific network failures or outage to happen. We can monitor it and make sure we do not have reports of infinite loading after network errors.

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Getting old report actions gets stuck in a retry infinite loop, could it be related to this PR: https://expensify.slack.com/archives/C05LX9D6E07/p1717711999602319?thread_ts=1717462134.645329&cid=C05LX9D6E07
?


Hide InternalLogger from Http2FrameLogger

InternalLogger is intended for internal use only.  We should hide it from users.

Instead of InternalLogLevel, we can use io.netty.handler.logging.LogLevel`.
Instead of accepting InternalLogger, we can accept String and Class<?> to create an InternalLogger in the constructor of Http2FrameLogger.

@trustin @normanmaurer is there any action that I can take on this currently? And if so, will it be backward compatible with 4.1?

@nmittler The thing is InternalLogger and InternalLogLevel are internal API and thus a user or an example should not use and should not be exposed to them.  My suggestion was to use LogLevel in the io.netty.handler.logging package instead and let user pass the name of the logger instead of InternalLogger, but I'm fine if there's a better idea.


mom5: should we explicitly add netcdf-c's include directory in the SPD?

GCC compiles contain the Makefile snippet:
CFLAGS += $(shell nc-config --cflags)

that results in the following being added:
-I$SPACK/opt/spack/linux-debian12-x86_64/gcc-12.2.0/netcdf-c-4.7.4-jzburrwbsqhi6cjth7nm4zdnunhcyhaq/include -I$SPACK/opt/spack/linux-debian12-x86_64/gcc-12.2.0/hdf5-1.12.2-igvxfglba4p6pcufko2mbprzeampoljh/include

Instead, should we explicitly add netcdf-c's include directory? e.g. (spec["netcdf-c"].headers).cpp_flags

mpicc appears to compile the C files without explicitly needing netcdf-c's include directory.

pio.h contains:

#include <netcdf.h>

Turns out there is very limited use of the netCDF C interface in MOM5 itself (or FMS as that is where this comes from):
https://github.com/mom-ocean/MOM5/blob/master/src/shared/mosaic/read_mosaic.c#L27
There is widespread use in the tools subdirectory, but none of that is used directly by MOM5. The only use of read_mosaic in the code is also in the tools subdirectory
https://github.com/search?q=repo%3Amom-ocean%2FMOM5 read_mosaic&type=code
apart from compiling EBM (mom5_ebm_compile.csh) which is not relevant.
From the limited searching I've done above it seems to me that read_mosaic.c is not required for MOM5, but it is included in the generic build of FMS because that is used for a number of builds.


refactor: code changes for stateless cni and swift v2

Reason for Change:

Modifies Add and Delete flow (PR made for pipeline testing)
Issue Fixed:

Requirements:

[X] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[X] relevant PR labels added

Notes:

/azp run CNI Release Test

/azp run CNI Release Test

/azp run CNI Release Test

/azp run CNI Release Test

/azp run CNI Release Test

/azp run CNI Release Test

/azp run CNI Release Test

/azp run CNI Release Test

/azp run Azure Container Networking PR


Edge Kiosk mode with silent printing - how?

How do I launch Microsoft Edge with parameters? I am especially interested in launching Edge with the --kiosk-printing option, so that the print dialogue box does not appear.
I have posted my troubles here: https://stackoverflow.com/questions/68322730/how-to-set-up-microsoft-edge-chromium-in-kiosk-mode-with-silent-printing

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 229e4d46-19a6-c042-8ce1-844c44c00112
Version Independent ID: 8ab07629-42a6-e7a1-86a9-f8103825ebc4
Content: Configure Microsoft Edge kiosk mode
Content Source: edgeenterprise/microsoft-edge-configure-kiosk-mode.md
Product: microsoft-edge
GitHub Login: @Aguta
Microsoft Alias: aguta

Clean up of old issues.  The team does have --kiosk-printing in the backlog but there is no ETA.  You can also submit feature requests through the browser.  ("..." menu > Help and feedback > Send feedback)
Currently "UI print settings lockdown" is a supported feature in kiosk mode (Link to documentation: https://docs.microsoft.com/en-us/deployedge/microsoft-edge-configure-kiosk-mode#kiosk-mode-supported-features)


Create canonical device selection recipe

For macOS, choose an audio device (can be aggregate).
For iOS, choose input and output devices.
For MIDI, same sort of thing but same for both OSs.

Too old.


Defining the $ErrorView preference variable in the current scope does not take effect (only in parent scope)

Preference variables generally take effect in the scope in which they're defined, which appears not be  the case for $ErrorView, which only honors it in an ancestral scope:
Steps to reproduce
& { Set-Variable -Scope 0 VerbosePreference Continue; Write-Verbose 'I will display.' }
& { Set-Variable -Scope 0 ErrorView CategoryView; Get-Item /NoSuchItem }
& { Set-Variable -Scope 1 ErrorView CategoryView; Get-Item /NoSuchItem }

Note: To re-run the test, start a new session, because the last command sets $ErrorView in the global scope.
Expected behavior
I will display.
ObjectNotFound: (/NoSuchItem:String) [Get-Item], ItemNotFoundException
ObjectNotFound: (/NoSuchItem:String) [Get-Item], ItemNotFoundException

Actual behavior
I will display.
Get-Item : Cannot find path '/NoSuchItem' because it does not exist.
At line:1 char:54
+ ... t-Variable -Scope 0 ErrorView CategorizedView; Get-Item /NoSuchItem }
+                                                    ~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (/NoSuchItem:String) [Get-Item], ItemNotFoundException
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.GetItemCommand
ObjectNotFound: (/NoSuchItem:String) [Get-Item], ItemNotFoundException

Setting $ErrorView in the same scope as the failing Get-Item command didn't take effect - contrast this with the $VerbosePreference variable.
Environment data

PowerShell Core v6.0.0-alpha (v6.0.0-alpha.18) on Darwin Kernel Version 16.5.0: Fri Mar  3 16:52:33 PST 2017; root:xnu-3789.51.2~3/RELEASE_X86_64

Same here with V7.1.3. Further testing:
& { $ErrorView ; Set-Variable ErrorView 'ConsiseView' -Option AllScope  ; 1/0 ; $ErrorView }
This doesn't work either. It changes the variable in the current scope only but also ignores it in preference for the parent scope setting.
The following does work, but you are changing the parent scope variable. In my case this is what I wanted to do:
& { $ErrorView; $global:ErrorView = 'ConciseView; 1/0 ; $ErrorView } NormalView ConciseView RuntimeException: Attempted to divide by zero. ConciseView
So I guess the answer is, grab the current setting of ErrorView, change it in your script using $global to do what you want it to do, then change ErrorView back at the end.

I was just testing the addition of a new error view DetailedView on a PR branch and noticed the same thing.


Document recursive aliases

To see the list of recursive aliases, I had to search in the source code. I did not see any mention of them as "recursive aliases" in the manual.
https://github.com/janestreet/jbuilder/blob/master/src/alias.ml#L75-L85

We talked a bit about recursive aliases in the design meeting yesterday. It seems that in most cases, the preferred behavior is to have recursive aliases (examples, runtest-blah, ...) and we only want non-recursive aliases in a few cases.
In the end, we should change jbuilder so that all aliases are recursive by default, and only a specific subset are non-recursive. For instance the rule could be that all aliases ending with .local are non recursive.

Actually, looking at the jbuilder-universe and the usage of aliases inside of jbuilder, it's clear that when we depend on an alias, we almost always mean the non-recursive version. And for internal aliases (for instance to depend on all the .cmi files of a lib), we always want the non-recursive behavior.
On the contrary, the recursive behavior seems to be always what we want when requesting an alias from the command line.
As a result I propose the following:

we  make all aliases non-recursive
we allow (alias_rec <path>/<name>) in dependency specifications to mean alias <name> in all descendants of <path> where it is defined. If none of the descendants of <path> define alias <name>, then an error is reported
@<path>/<name> on the command line is interpreted in the same way as (alias_rec <path>/<name>)

I was thinking the same thing.  It seems that within the command line interface it is much more common to want the recursive behavior by default.  However, I think it should also be possible to perform the non-recursive behavior if desired.  I'm not hesitant about @bobot's proposal only because I'm curious what the rationale was for initially introducing the @-sign syntax in the first place.
As of today, what makes:
jbuilder build my/alias
different than
jbuilder build @my/alias
?

Basically aliases are not represented by files. You can have a rule that produce a file my/alias and an alias my/alias and there is no interaction between the two. Internally jbuilder uses files to represent aliases, but this is an implementation detail.
That said, I have no objection to extending the CLI so that if there exist an alias my/alias, then jbuilder build my/alias means building the alias my/alias as well as the target my/alias (if any).


feat(tutorial): complete step 1

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

👍 Looks good - 🎉 You are one step closer to completion of the Carbon React tutorial and earning the digital credential.

@gmoehler I've recorded your completion of step 1 🥇.


add Iterations Interval Callback

Feature to add and execute your own callbacks after every iteration interval.
To perform clean, check etc. regularly but not at every iteration.

:+1:

:+1:

:+1:

v1.4.0


Add markdown linter for high quality READMEs

Fixes: #574

@blumamir can you please take a look? It should be the same as of the resource provided in the issue right?


cleanup rubocop and use CHILD_STATUS

@dblock went through the cops just for fun, the new alignment is nice since it does not add extra spaces/does not need to be indented, also liked the $CHILD_STATUS
what do you think ?

... CHILD_STATUS is not actually a thing ... need to require 'English' ... who names files uppercase ... leaving it out ...

Generally working with the TODO is easier, you just run rubocop --auto-gen-config, but I don't care ;)

locked the version down.
todo sounds like this should be fixed, but it's more of a 'we choose to
ignore these' list :)
On Thu, May 14, 2015 at 12:29 PM, Daniel Doubrovkine (dB.) @dblockdotorg <
<EMAIL_ADDRESS>wrote:

Generally working with the TODO is easier, you just run rubocop
--auto-gen-config, but I don't care ;)
—
Reply to this email directly or view it on GitHub
https://github.com/dblock/rspec-rerun/pull/41#issuecomment-102144814.


[FZ Editor] editor doesn't launch when RivaTunerStatisticsServer (MSI Afterburner) is running

Environment
Windows build number: Microsoft Windows [Version 10.0.18362.418]
PowerToys version: <IP_ADDRESS>
PowerToy module for which you are reporting the bug (if applicable): FancyZones

Steps to reproduce
Run RivaTunerStatisticsServer (via MSI Afterburner)
Expected behavior
layout editor launches
Actual behavior
fancyzones crashes but remains in tray. Errors in Event Viewer

Hi @addrum
thank you for reporting the crash.

@enricogior no worries. Let me know if you need further info 😄

It seems this is actually more related to RivaTunerStatisticsServer. I disabled all the monitoring in MSI afterburner which stops the server from running and now the layout editor works again. Still the same error/crash logs as before.
I'll adjust the title.

Thanks for the extra info.

Sidenote: we had a similar issue in the past https://github.com/microsoft/PowerToys/issues/455, but we could not reproduce it and it was for an older PowerToys version.

This problem keep happening and in the last case PowerToys wasn't the only application effected
https://github.com/microsoft/PowerToys/issues/1872
This seems an external problem, not something wrong in the FZ editor.

Added to the Wiki page https://github.com/microsoft/PowerToys/wiki/Application-Compatibility#applications-that-cause-fancyzones-editor-to-fail-to-open


Fixed issue #8 in SwagLyrics repo (reading unsupported.txt from site-packages)

I've created a config.py file for general global level variables, there I've added the site-packages directory path for unsupported.txt
cli.py and main.py now read/write from the site-packages unsupported.txt rather than creating a new one and updating that one in the local directory from which swaglyrics is run.

Hello @chriswang030! Thanks for opening this PR.

In the file swaglyrics/__main__.py:

Line 23:1: W191 indentation contains tabs

In the file swaglyrics/cli.py:

Line 64:1: W191 indentation contains tabs
Line 64:3: E117 over-indented
Line 91:1: W191 indentation contains tabs
Line 91:4: E117 over-indented

Do see the Hitchhiker's guide to code style

it cannot write in site-packages folder, if not run with sudo access after install. I tried it and it spits following error.

Looks okay but I'd like to ensure this works across all operating systems. Doesn't seem to work on Linux ^

@adhv45 is there any way to get around that? seems like we can't update the site-packages unsupported.txt unless the user installs with sudo access

Hello @chriswang030! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file swaglyrics/__main__.py:

Line 23:1: W191 indentation contains tabs

In the file swaglyrics/cli.py:

Line 64:1: W191 indentation contains tabs
Line 64:3: E117 over-indented
Line 91:1: W191 indentation contains tabs
Line 91:4: E117 over-indented

In the file tests/test_cli.py:

Line 70:1: W191 indentation contains tabs
Line 72:1: W191 indentation contains tabs
Line 89:1: W191 indentation contains tabs
Line 91:1: W191 indentation contains tabs
Line 108:1: W191 indentation contains tabs

@chriswang030 I've set pep8speaks to ignore the tab in indentation error and have set maz line length to 120 characters so you needn't fix those 👍

@chriswang030 so do you think you can get this working? I'd prefer to write to site-packages but if that's not possible I guess I'd have to go with the AppData option in #1085

Hey sorry, I've just been working on it on my local repo. I don't think there's a way to write to site-packages without sudo access from what I've tried right now.

So I found that pip install --user installs the package in the user directory which is accessible w/o root so that might be helpful but I'm not sure if we can leave that in their hands.

But not everyone installs with --user permission. It will cause a problem there for the root permissions.

But not everyone installs with --user permission. It will cause a problem there for the root permissions.

yeah which is why I can't decide which approach to go with


Add Controller

Add CLI controller for minows, similar to minogrpc/controller

[ ] Go unit tests for Minows and RPC
[ ] Go integration tests for Call() and Stream(): multiple mino instances, multiple RPCs
[ ] Go unit tests for Controller struct


Please consider implementing dynamic port forward with socks as in ssh.

While the portforward over aws ssm is useful, it would incredibly useful to have a socks proxy instead a port forward.
What I'd like to have is something similar to:
ssh -D <port> where  port starts listening as a http socks proxy you can configure in your browser to tunnel any and all traffic over it.
This allows for http to https redirects and more in general reach internal servers without needing to create a new portforward for each one.
¡Thanks!

With the setup according to this I was able to do ssh -ND <port> <host> and use it as a socks proxy.
What's not working for you?

Needs to be through SSM agent, without any Public IPs assigned to the Instance.  You were able to do this through ssm connection ?

@basigabri Yes. No public IPs, just SSH over SSM.
The test was done on Max apple silicon, and server is Amazon Linux. I was able to see private subnet web server on browser when going through the SOCK5 port.

Thanks @joy13975 for sharing. @basigabri  @sjmunizsantex  please let us know if you run into issues following @joy13975 's suggestion.


Adds createOCRHMMTransitionsTable() utility function

allows to create a tailored language model transitions table from a given list of words (lexicon).

:+1:


It's not possible  to override ListBoxItem triggered brushes

Describe the bug
This issue results from #3899
It's not possible  to override ListBoxItem triggered brushes via own style like
<Style TargetType="{x:Type ListBoxItem}" BasedOn="{StaticResource MahApps.Styles.ListBoxItem}">
    <Setter Property="Controls:ItemHelper.HoverBackgroundBrush" Value="{DynamicResource MahApps.Brushes.Gray}" />
    <Setter Property="Controls:ItemHelper.HoverSelectedBackgroundBrush" Value="{DynamicResource MahApps.Brushes.Gray1}" />
    <Style.Triggers>
        <EventTrigger RoutedEvent="PreviewMouseRightButtonDown">
            <BeginStoryboard x:Name="BeginStoryboard_IsPressed">
                <Storyboard>
                    <ObjectAnimationUsingKeyFrames Duration="0:0:0"
                                                   Storyboard.TargetProperty="Background">
                        <!--
                            Note: It's not possible to use DynamicResource inside a Storyboard.
                            So use StaticResource or a static Brush instead.
                         -->
                        <DiscreteObjectKeyFrame KeyTime="0:0:0" Value="{x:Static Brushes.Red}" />
                    </ObjectAnimationUsingKeyFrames>
                </Storyboard>
            </BeginStoryboard>
        </EventTrigger>
        <EventTrigger RoutedEvent="PreviewMouseRightButtonUp">
            <RemoveStoryboard BeginStoryboardName="BeginStoryboard_IsPressed" />
        </EventTrigger>
    </Style.Triggers>
</Style>

Expected behavior
The Background of the ListBoxItem should be changed if the user clicks the right mouse button.

Actual behavior
Nothing happens.

Environment
MahApps.Metro version: v2.2.0
Target Framework: .Net Core 3.1 (v4.5.2, v4.7.2)

Screenshots

@punker76, these changes break if you're using an alternation index background on the container:
<Style.Triggers>             <Trigger Property="ItemsControl.AlternationIndex" Value="0">                 <Setter Property="Background" Value="{DynamicResource MahApps.Brushes.Gray10}" />             </Trigger>         </Style.Triggers>
It's now no longer possible to set a normal background for these while retaining the hover backgrounds etc.


Added post routes and insert query for adding new trips

 Add post request for new trips on client and routes and queries for server


Compress images

Description
I have compressed some images from the blog to make them load faster. The blog-resources folder has reduced its size by 11.16MB (19.42MB -> 8.26MB)

@yaira2 If you also think the images look fine, feel free to merge this PR

Out of curiosity, why is the Git screenshot smaller than the previous one?

This should probably be reverted.

@AgentRBY thank you for your contribution, for the future I think it's worth noting that we use ImgBot to take care of compressing images. While it's sometimes possible to compress images further, we'd rather rely on ImgBot to ensure a balance between image quality and size.


Add Microsoft Windows 10 UWP build support

This change adds support for building Windows UWP compatible binaries.

Removed gen_config_h, getarch and getarch_2nd from CMake generation when building for UWP.  When built as UWP applications, these require running in an appcontainer and cannot be invoked during build time.  In order to build OpenBLAS for UWP, first run CMake as regular win32/64 configuration to generate executables.  Then remove CMakeCache.txt and CMakeFiles directory and re-run CMake for UWP configuration and build resulting OpenBLAS.sln.
UWP doesn't support environment variables.  Changed environment variable functions to no-ops.
UWP doesn't support TerminateThread(). #ifdef'ed out for UWP compilation.
config.h still requires #define OS_WINNT 1 to build UWP library.  Explicitly add during CMake phase.
Update CMakeLists.txt to still build gencblas, genconfig, and genf77blas for ALL_BUILD target.

It looks good. It could be perfectioned with lots of typing to distinguish 2 build steps involved, but your description could land in FAQ instead as well.

@neilsh-msft , Could you add a note at https://github.com/xianyi/OpenBLAS/wiki/ ?

I've updated the page https://github.com/xianyi/OpenBLAS/wiki/How-to-use-OpenBLAS-in-Microsoft-Visual-Studio

I have added explanatory 3rd party source to avoid misunderstandings. Feel free to fix me with permalink.

Link to Wikipedia article on UWP looks fine.


Some cached pages have encoding or compression issues

I've been informed that some pages seem to be cached with either wrong encoding, or more probably compression algorithm, causing those pages to appear like so on subsequent visits:

I have had to completely bypass the cache for the time being because it started to impact our SEO.
Can I provide you with more information, maybe files, so that you can track down the issue?

Hey @jerome-pilotin ! I missed this earlier. I had discovered the same last week and have already started updating.
I wasn't aware it was being used in a production setting outside of my use.
I'll create a slack group so we and others can connect. I'll leave this issue open and notify when updated.

Hey @jerome-pilotin . Here's a slack chat if you want to join. It may work better to communicate through there:
https://join.slack.com/t/thatmiracle/shared_invite/zt-2hxi2pz12-0Pnf8zwCB3zWZ9SJmC0Qtg

Hey @jerome-pilotin . I just pushed changes that should correct the caching issue. I'll run a build on it and send over the test docker image.

Here is the Docker tag that should have this caching issue fixed.
stephenmiracle/frankenwp:beta-1.0.0
https://hub.docker.com/r/stephenmiracle/frankenwp/tags


docs: better syntax highlighting

Summary of Changes
Add rules for all applicable builtin tokens of Pygments to the lexer to improve syntax highlighting in the grammar. In particular, syntactic elements now get highlighted similarly to their Python equivalent, where possible.

:tada: This PR is included in version 0.2.0 :tada:
The release is available on:

Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


Produce Whole SDG Pop Estimates for Scotland by sex

This is to produce estimates based on Male/Female split.
Steps for Developer:

The data for Male/Female on an output area is contained with the Scottish Usual Population file already read in.
Apply these disaggregation in a similar way to the way the SDG England & Wales script performs this.

I'll look into this one Antonio - assigned myself.

Have put in some code to add in sex. Currently an issue with female and male values being incorrect in the dataset (they don't add up correctly). I'm going to look at this early next week (w/c 15th August).


What is the level of the meeting SLT?

I did not find it in CCF meeting list.
Would you mind telling me about the meeting

There's more info at https://signalprocessingsociety.org/get-involved/speech-and-language-processing/newsletter/ieee-slt-2018-announcement or http://www.conferenceranks.com/


fix(leadSpace): multiple visual bugs

Related Ticket(s)
https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/4385
List of visual bugs by breakpoints
Breakpoint max - lg
Default state:

[x] 1. Spacing top should be 64px (48px on md, sm)
[ ] 2. Sub head text style should be $expressive-heading-05 which is 60px
[x] 3. Grid of field should be 10 columns wide, hang both sides into gutter (no hang on sm)
[x] 4. Spacing between search icon and text should be 16px here (8px on md, sm)
[x] 5. Spacing bottom should be 64px (48px on md, sm)
[x] 6. Bottom rule missing for all breakpoints less than max

Typing state:

[x] 1. Type style of input text is wrong. Should be $expressive-heading-03
[x] 2. "X" icon should be 24px in size (20px on md, sm). Padding 20 left and right, making the icon centered on a 64x64px square background

Breakpoint md default & typing state

[x] 1. Heading and subhead's type size seems a little off. Currently 36, only slightly different from spec (32), please double check if this should still use $expressive-heading-06 and -05
[x] 2. Grid of search field. Should hang both sides into gutter, at width 6 columns
[x] 3. Bottom rule missing

Breakpoint sm default & typing state

[x] 1. Bottom rule missing

Should be expressive-heading-05

Already set to 05 =/

Bottom rule / border bottom should be using $ui-03, currently too dark.
Changed to $ui-03

On xlg - md search field doesn't sit on grid
Removed gutter hang

Upon clicking into text field, the placeholder text should clear
Added rule that makes placeholder transparent on focus

Typing text is too small. Should be $expressive-heading-03 (20px)
Fixed, it was only set for the placeholder

On sm, 'x' icon is misplaced. Should be centered in a 48px square, 14px in from edge of the search field
Fixed

@shixiedesign any other feedback on this? This PR is getting a bit stale.


refactor: Replace ObjectName with String

Goal
Currently table_name, alias and index_name are using ObjectName(Vec<String>) but redundant.
Let's replace all ObjectName with String
Todo

[x] replace all ObjectName with String
[ ] Throw Error if the number of ObjectName is more than 2

In Future
To support multiple schemas or databases in future, it would be inevitable to replace with better struct.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

125 of 125 (100.0%)  changed or added relevant lines in 30 files are covered.
3 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.03%) to 98.284%

Files with Coverage Reduction
New Missed Lines
%

core/src/executor/execute.rs
1
93.33%

core/src/plan/evaluable.rs
1
97.21%

core/src/translate/mod.rs
1
95.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
37695

Relevant Lines:
38353

💛  - Coveralls


Added GEMS WEK Al Khail

@T-O-R-U-S First stage of verification passed, official domain is twitter.com as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://twitter.com/thiruvasu/status/1395066566027448321

Note that this email is used by multiple schools under the GEMS company. GEMS Wellington Academy Al Khail is only one of such schools -- I'm not fully aware of the list of all the schools that use it. It seems that not even GitHub is aware of this distinction, as they seem to only allow one other GEMS school (I think?) the @gemselearning.com address... which is quite annoying...

@T-O-R-U-S Thank you for your request and the details. Regrettably, I have to reject the request. As it was mentioned in #18013, the domain gemselearning.com has suspicious signs, which prevents it from being eligible for adding to this repository.
We generally do not add to this repository the domains that represent a large network of schools, especially distributed online schools, because of high security risk. Please ensure that you read the rules of the repository at the bottom of this page.
Please feel free to apply for educational license with an official document which proves that you are a student. You can do it using "OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students.
Thank you for your understanding!


new release?

We're still seeing the bug from #42 in the latest. Possible to push a new release? If not, more work to be done? Thanks.

v3.0.2 is released :)

much appreciated!


python310Packages.databricks-sql-connector: 2.9.3 -> 3.0.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

WARNING: Package has meta.broken=true; Please manually test this package update and remove the broken attribute.

meta.description for python310Packages.databricks-sql-connector is: Databricks SQL Connector for Python
meta.homepage for python310Packages.databricks-sql-connector is: https://docs.databricks.com/dev-tools/python-sql-connector.html
meta.changelog for python310Packages.databricks-sql-connector is: https://github.com/databricks/databricks-sql-python/blob/v3.0.0/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.0.0 with grep in /nix/store/vpjgxzbliv660jpbxwv1p8rpnvack79w-python3.10-databricks-sql-connector-3.0.0
found 3.0.0 in filename of file in /nix/store/vpjgxzbliv660jpbxwv1p8rpnvack79w-python3.10-databricks-sql-connector-3.0.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
databricks-sql-cli
python310Packages.databricks-sql-connector
python311Packages.databricks-sql-connector

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vpjgxzbliv660jpbxwv1p8rpnvack79w-python3.10-databricks-sql-connector-3.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.databricks-sql-connector https://github.com/r-ryantm/nixpkgs/archive/7b082959ebfbbc678238eb99f792a8766217e5ea.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7b082959ebfbbc678238eb99f792a8766217e5ea#python310Packages.databricks-sql-connector

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vpjgxzbliv660jpbxwv1p8rpnvack79w-python3.10-databricks-sql-connector-3.0.0
ls -la /nix/store/vpjgxzbliv660jpbxwv1p8rpnvack79w-python3.10-databricks-sql-connector-3.0.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages marked as broken and skipped:

databricks-sql-cli
python310Packages.databricks-sql-connector
python311Packages.databricks-sql-connector

Maintainer pings
cc @harvidsen for testing.

@ofborg build python310Packages.databricks-sql-connector python310Packages.databricks-sql-connector.passthru.tests

Already on staging-next.


Added scope for notifications only

Please add a test for this commit. Can you also add some documentation to explain how this would be used and why it's necessary?


Modify the working suitability of the Pal

I'm not sure if it's technically possible, maybe we can modify the working adaptability of the Pal to make them more versatile

Not possible

sad..


Error while using topoplot() function

While using topoplot() function, I get an error that mne.viz.plot_topomap() does not have some parameters (vmin and vmax, instead it only has a vlim parameter which takes a tuple of the two limits). I solved this by updating the function parameters as they are on the mne documentation. I suppose the mne library was updated, but the current yasa version uses the old version of men.
Also when passing the kwargs arguments mne says that there is no show_names keyword argument.
packages versions:
yasa = 0.6.3
numpy =  1.23.5
mne = 1.3.1
scipy = 1.10.1
Python = 3.10.9

Hi @k0ruy,
Apologies for the late response. This is a known issue that has been fixed in the development version of YASA (#119). This will be released in the main (stable) version of YASA within the next weeks or months.
Thanks,
Raphael

Just released a new version of YASA that includes the fix: https://github.com/raphaelvallat/yasa/releases/tag/v0.6.4


[WIP] Add FT to certifier

Codecov Report

Merging #268 (2590cad) into master (8b9e7bd) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 2590cad differs from pull request most recent head 32d5420. Consider uploading reports for the commit 32d5420 to get more accurate results

@@           Coverage Diff           @@
##           master     #268   +/-   ##
=======================================
  Coverage   89.73%   89.73%
=======================================
  Files          37       37
  Lines        1101     1101
  Branches      155      155
=======================================
  Hits          988      988
  Misses         83       83
  Partials       30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b9e7bd...32d5420. Read the comment docs.


Automatically size charts based upon the canvas size.

This allows charts to be drawn to the canvas's current size, wether this be automatically determined through css
or through manually sizing the canvas, you can't rely on the canvas reported size as it defaults to a imo silly size.
Note I recompressed the js with this fix but as there was no noted preferred build chain I used uglifier which I had
to hand. Hence the change.

It seems that this commit can't be automatically merged, can you please update and rebase?

Done, I left off the compressed result this time

Okay thanks, I'm +1 for merge.


API is Obsolete

The Android api Camera gives obsolete warnings for this sample.  It needs to be updated to the latest api.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e3b172d5-2dc1-88e7-ca23-96e87ae24a42
Version Independent ID: 1ca93300-738f-4af7-b47c-0e170b7205a4
Content: Implementing a View - Xamarin
Content Source: docs/xamarin-forms/app-fundamentals/custom-renderer/view.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @koenigm-seattleu
I'd been waiting for the CameraView control, promised in the Xamarin.Forms 4.x series, to make this article redundant. However, CameraView hasn't arrived.
With that said, it's going to be part of the Xamarin Community Toolkit (see https://github.com/xamarin/XamarinCommunityToolkit/issues/211). Once it gets fully merged it'll make this article redundant.

The problem with that, is this example is used by us when we want to have a preview of the camera.  The toolkit version does not support preview.  So we will need to continue to use this example.
From: David Britch<EMAIL_ADDRESS>Sent: Friday, August 28, 2020 4:39 AM
To: MicrosoftDocs/xamarin-docs<EMAIL_ADDRESS>Cc: Koenig, Michael<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/xamarin-docs] API is Obsolete (#3023)
Hi @koenigm-seattleuhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkoenigm-seattleu&data=02|01|koenigm%40seattleu.edu|d378f818bae54a906f7408d84b46f02c|bc10e052b01c48499967ee7ec74fc9d8|0|0|637342115335242263&sdata=jTrtVq8%2FtsJE%2FNKh4j%2BMYGWt2zxSFp%2BvRHuH1AcJ6UI%3D&reserved=0
I'd been waiting for the CameraView control, promised in the Xamarin.Forms 4.x series, to make this article redundant. However, CameraView hasn't arrived.
With that said, it's going to be part of the Xamarin Community Toolkit (see xamarin/XamarinCommunityToolkit#211https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxamarin%2FXamarinCommunityToolkit%2Fissues%2F211&data=02|01|koenigm%40seattleu.edu|d378f818bae54a906f7408d84b46f02c|bc10e052b01c48499967ee7ec74fc9d8|0|0|637342115335252261&sdata=uvchDYuG0jjMShfSmJ1%2B3u6MbYD04hkVcZVbkRwkxGk%3D&reserved=0). Once it gets fully merged it'll make this article redundant.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fxamarin-docs%2Fissues%2F3023%23issuecomment-682478116&data=02|01|koenigm%40seattleu.edu|d378f818bae54a906f7408d84b46f02c|bc10e052b01c48499967ee7ec74fc9d8|0|0|637342115335252261&sdata=6MI%2FFIGy8Qk%2BguDMbMXL6hQrYMraO1Ftkoag8HV5grE%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJAZI2WVNE6ZJ3FUMT5KA6DSC6JMXANCNFSM4QA3NKFA&data=02|01|koenigm%40seattleu.edu|d378f818bae54a906f7408d84b46f02c|bc10e052b01c48499967ee7ec74fc9d8|0|0|637342115335262257&sdata=O7h6%2BLOIcZwmdZ2K1%2F4LGfC4VekpJe3T5NpWhVzWtSc%3D&reserved=0.

It is expected to be updated to version 2 camera ?

The doc and sample was updated last week to use Camera2.


Supplier websites are now linked

Update to the supplier app adds hyperlinks to supplier's website fields, so the test need to look inside the anchor tag to find the required text.

:+1:


[2.11.1] Bug: web wallet not loading, showing error and goes away again

Bug found testing with Stacks Wallet for Web, suddenly it does not load the page to show wallet balances/transactions and such. Switching network does nothing to resolve it, although the url changes in the error. First time I have encountered this. It happened shortly after I made two more accounts, but that may be unrelated.
If I wait, eventually the window will show the wallet again and I can send transactions, see here:
https://user-images.githubusercontent.com/33360391/125104950-37e44380-e0de-11eb-898f-b9a098475262.mp4
Error
Loadable: accounts/CURRENT_ACCOUNT_DATA
Message: Error: Unable to fetch API data from https://stacks-node-api.regtest.stacks.co/extended/v1/address/ST2PBEZB3ZPHJE1XJHFQKGF6E08SV29K96WCRJA13/transactions?limit=50
Environment
Version: 2.11.1
Branch: refs/heads/main
Commit: d807ddc6c0ec9aceaa773c1bb8f25d31a950562e
On Brave (latest) and windows 10

The underlying API experienced some problems around the time you reported this issue last week. Mind trying again to see if the behavior is resolved?

Thanks, I have been testing the last hour and it has not reappeared, this behavior looks resolved to me.


Security Vulnerability Bug Report

See the full details of the vulnerability below in the following docs link

Request access to the docs link. I will accept ASAP. You will find the full vulnerability report there

Request access to the docs link. I will accept ASAP. You will find the full vulnerability report there

you can send the report to techadmin at gooddollar.org
we dont accept reports based on automated tools. only critical bugs you found.

@sirpy  Is that the email address<EMAIL_ADDRESS>This is not an automated tools report; it is a manual finding related to full admin access issue.I sent the report to<EMAIL_ADDRESS>Alternatively, please access the docs link and request access.I will accept, and you can find the full details of the report and review it.
Thank you

@sirpy  Is that the email address<EMAIL_ADDRESS>This is not an automated tools report; it is a manual finding related to full admin access issue.I sent the report to<EMAIL_ADDRESS>Alternatively, please access the docs link and request access.I will accept, and you can find the full details of the report and review it.


Remove zeros=nans from objectModel3D in C++ and HDevelop samples

Our Genicam producer sets the invalid points to (0,0,0). This means the output object model 3D has many points in (0,0,0), which need to be removed by the user/programmer. For example, in the case of the surface-based matching, the algorithm will slow down and the 3D edge extraction will fail. That means, if we do not remove the invalid points (or the zero's), the user/programmer has to do it by hand (for example using the operator select_points_object_model_3d()). But, this is often forgotten by the user and therefore worsens the performance.
Before we can remove zeros from the SDK we should remove them here.

I've been talking to MVTec about this and they said that several customers of them forget to remove these zero points. This makes later processing slow and/or wrong. I think it is a good idea to implement this


Update to 2018 edition

This PR includes the minimal amount of changes to use 2018 edition Rust. All tests are passing.
There are additional changes that could be made (removing all extern declarations for example) but I left those alone to keep this PR as small as possible.

Already done, thanks @liamcurry !


Review: ICssUnit props

I have implemented some props accepting e.g. "5rem" as accepting ICssUnit, since my understanding is that ICssUnit is basically just a stand-in for a correctly formatted string.
Examples:
https://github.com/cmeeren/Feliz.MaterialUI/blob/4bb895bad20efc55afdfa0def9a31f623e61c322/src/Feliz.MaterialUI/Props.fs#L753-L754
https://github.com/cmeeren/Feliz.MaterialUI/blob/4bb895bad20efc55afdfa0def9a31f623e61c322/src/Feliz.MaterialUI/Props.fs#L819-L820
https://github.com/cmeeren/Feliz.MaterialUI/blob/4bb895bad20efc55afdfa0def9a31f623e61c322/src/Feliz.MaterialUI/Props.fs#L819-L820
Usage:
circularProgress.size (length.px 24)

Does that make sense?

Does that make sense?

Yes, that is how Feliz does its CSS units

Thanks! :)


update external process documentation to reflect move to scala.sys.process

First attempt to address #427

Hi @bpholt,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
http://www.lightbend.com/contribute/cla

Awesome. Thanks!

Oh wow. Thank you very much, @bpholt.


fix nacos password

Description:
fix nacos password

Testing done:
Done

Affected area:

Functional Area

New Functionality
[ ]

CI System
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[ ]

Demo
[ ]

Documentation
[ ]

Egress
[ ]

Ingress
[ ]

Install
[ ]

Networking
[ ]

Observability
[ ]

Performance
[ ]

SMI Policy
[ ]

Security
[ ]

Sidecar Injection
[ ]

Tests
[ ]

Upgrade
[ ]

Other
[X]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? no

Is this a breaking change? no

Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)? no

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.14%. Comparing base (7f01986) to head (9175dcd).
Report is 57 commits behind head on release/v1.2.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.2     #246      +/-   ##
================================================
+ Coverage         46.83%   47.14%   +0.30%
================================================
  Files               199      196       -3
  Lines             15232    12118    -3114
================================================
- Hits               7134     5713    -1421
+ Misses             8052     6361    -1691
+ Partials             46       44       -2

Flag
Coverage Δ

unittests
47.14% <ø> (+0.30%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cant tag a user with <@userid> this way

Shouldn't the text be able to tag users? What's the syntax?

Hi,
you can find here how to mention users, groups ..
https://api.slack.com/reference/surfaces/formatting
Example
var slackMessage = new SlackMessage
           {
               Channel = "m_channel",
               Text = "<!here> test",
               IconEmoji = Emoji.Ghost,
               Username = "username"
           };

@johnkwaters just hit this, did you find a way?


nixos/mastodon: fixup sidekiq jobClasses assertion

See https://github.com/NixOS/nixpkgs/pull/225005#issuecomment-1516677321
Description of changes
Accidentally only counted the number of entries, not the number of scheduler occasions.
The following should work now:
$ cat test.nix
let
  inherit (import <nixpkgs> { }) lib;
in
1 ==
  (lib.count (x: x)
  (lib.mapAttrsToList
    (_: v: builtins.elem "scheduler" v.jobClasses || v.jobClasses == [ ])
    {
      all = {
        jobClasses = [ ];
        threads = null;
      };
      ingress = {
        jobClasses = [ "ingress" "schedulear" ];
        threads = 5;
      };
      default = {
        jobClasses = [ "default" ];
        threads = 10;
      };
      push-pull = {
        jobClasses = [ "push" "pull" ];
        threads = 5;
      };
    }))

$ nix eval -f test.nix
true

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Can you give me a ping when the others had a chance to take a look at the PR?

@Izorkin care to have a look at this?

@Izorkin care to have a look at this?

I use default sidekiq settings. I can't test more accurately.

Can you give me a ping when the others had a chance to take a look at the PR?

@SuperSandro2000 I think we got all approvals we are going to get on this one.


Did you release the evaluation dataset in your paper?

As title. The dataset mentioned in the paper includes animal, object and colors.

Hi @YasminZhang, thanks for your interest!
please refer to this issue where we attached our full list of prompts for evaluation.

Hi @YasminZhang, thanks for your interest!
please refer to this issue where we attached our full list of prompts for evaluation.

Thanks a lot!


[GSSoc '23] Python script to download Unsplash Website images

Hey @neelshah2409 ,
I would like to contribute python script that will download images from unsplash website.
The script will accept :

search query
image resolution
number of images

and smoothly download the images.
Please allow me to contribute to this issue.

Please assign this to me as a GSSOC contributor.

sir can you assign me this task i would like to resolve it under GSSoc '23

@ritik48  you can start working on this issue

@neelshah2409 please add level tag to this issue.


update circleci.yml to use ruby 2.7

Updates circleci config.yml to also use Ruby 2.7 now that it has been released.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[ ] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[ ] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

CI has failed because circleci/ruby:2.7 image has not been released yet.
https://hub.docker.com/r/circleci/ruby/tags
I will close this PR because I will try this later. Thank you.


dvc-data: move load/check/iterobjs to hashfile

Leftover from #164

Codecov Report
Base: 57.69% // Head: 57.61% // Decreases project coverage by -0.08% :warning:

Coverage data is based on head (bd348ee) compared to base (9962ab4).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   57.69%   57.61%   -0.09%
==========================================
  Files          40       40
  Lines        2437     2437
  Branches      435      435
==========================================
- Hits         1406     1404       -2
- Misses        950      952       +2
  Partials       81       81

Impacted Files
Coverage Δ

src/dvc_data/hashfile/tree.py
57.06% <0.00%> (ø)

src/dvc_data/hashfile/__init__.py
47.05% <47.05%> (ø)

src/dvc_data/cli.py
32.01% <100.00%> (ø)

src/dvc_data/index.py
79.67% <100.00%> (ø)

src/dvc_data/hashfile/build.py
73.80% <0.00%> (-1.59%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Presenter>>onCloseRequested never called

If this plays a role in the Presenter lifecycle it should be documented in the method comment. As it is, I can't find a way to use it and its existence took me on a detour that wasn't very productive.

It's just an old bug that has gone unnoticed for a couple of decades (it would seem).
View>>wmClose:wParam:lParam: doesn't forward to the presenter as it should: