Gogs: you are not the owner of SSH key

Hi guys !
I need your help because I don't understand this error...
I have my admin user IMACODE with this an SSH Key (I check in the database).
But when I want git clone a project, I get this error "Gogs: you are not the owner of SSH key". My project is in organization, and my admin user is the owner of the organization.
Thanks for your help :-)

Hi there, thanks your feedback!
Did you add SSH key through Gogs web UI?

Hi,
Yes, only by that way.

This error happens when user ID recorded in SSH key file is not match your user ID in Gogs database.

Ok, I removed keys in database and /home/gogs/.ssh/authorized_keys and add ssh key to my account again. It's seems works!
But now, git clone ask me the password for gogs user. What is this password ?

But now, git clone ask me the password for gogs user. What is this password ?

What is the command you used for git clone? Complete string please.

git clone ssh://gogs@git.imacode.net:1453/potternetwork/potternetwork-web.git

Would you mind to dump your  /home/gogs/.ssh/authorized_keys file?

command="/opt/gogs/gogs serv key-9 --config='/opt/gogs/custom/conf/app.ini'",no-port-forwarding,no-X11-forwarding,no-agent-forwarding,no-pty ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCvFUqy3j5jgn04E+aE1vRv7qM3RHcohlii0kpx/8eW6th2W6MaE18oM3lrAvGLxtcVkIw9hunvRoje4UrKgSO/NshNan22IXQl0JyiAUrTXhQrLIpFsIh2YvxUQ/96Y8DYAqN9pa1FC+/S+TS8asxXG71ElxToGZxzG6qik7jM9V8rFuTEIgPc+W09BriZ7xyo79Wxh0GJ0wrupMCW2YWyqEE39LGjRv1hpkh4K+lQCpnjmS7OWSChpDzfz/ruO2ikiz01OMmqp/H4n41KBeyiDo9LBKgOQRD7WjfqehCFmFADwXhzbvZXoE/0DQ0fDX8oh+lA02XhBxtQll2DFHQ1<EMAIL_ADDRESS>

Thanks!
If SSH asks for password means SSH server doesn't find match, your request hasn't even been passed to Gogs.

So, when the request will have been passed to Gogs ?

I don't know, I think it's local config problem with your SSH server.

Somehow your SSH server doesn't read/recognize the key in  /home/gogs/.ssh/authorized_keys file.

I uncomment this line AuthorizedKeysFile %h/.ssh/authorized_keys in /etc/ssh/sshd_config and restart ssh but it still does not work, have you any idea ?

If the permission is anything except 0600 , ssh refuse to read the .~/ssh directory.
Verify that the ~/.ssh and all content inside that are 0600

My ~/.ssh permissions are drw------- and my ~/.ssh/authorized_keys permissions are -rw-------

Can you add SSH key normally to gogs user and try SSH login?

What do you mean by "normally" ?

Add a SSH key like you want to login your server with it.

What is the Gogs user password ?

I don't know what's the user password you create on your machine. :)

I have the same problem. Gogs change ownership on file authorized_keys.
I use init.d script for debian and git user for start gogs but after start gogs i see in process list
root     29946  0.0  0.1  64528  1772 ?        S    11:52   0:00 /bin/su - git -c cd "/opt/gogs" && /opt/gogs/gogs -- web
git      29947  0.0  0.1  20860  1628 ?        Ss   11:52   0:00 -su -c cd "/opt/gogs" && /opt/gogs/gogs -- web
root     29948  4.0  1.8<PHONE_NUMBER>0 ?        Sl   11:52   0:00 /opt/gogs/gogs -- web
gogs run as root user and when i add new key from web interface, gogs changes owner on   /home/git/.ssh/authorized_keys

DeletePublicKey  changes owner  when user remove public key in web interface because  DeletePublicKey create new file and call rename

@uchti run Gogs on root is not a wise choice, and you may never able to log in with SSH to access your machine again...

@Unknwon  I know but how explain this situation on my vds server
root@git ~ # su - git
git@git:~$ cd /opt/gogs/
git@git:/opt/gogs$ /opt/gogs/gogs web &
[1] 32140
git@git:/opt/gogs$ 2015/03/03 21:54:29 [T] Custom path: /opt/gogs/custom
2015/03/03 21:54:29 [T] Log path: /opt/gogs/log
2015/03/03 21:54:29 [I] git.etnix.net <IP_ADDRESS>4 Beta
2015/03/03 21:54:29 [I] Log Mode: File(Trace)
2015/03/03 21:54:29 [I] Redis Enabled
2015/03/03 21:54:29 [I] Memcache Enabled
2015/03/03 21:54:29 [I] Cache Service Enabled
2015/03/03 21:54:29 [I] Session Service Enabled
2015/03/03 21:54:29 [I] Mail Service Enabled
2015/03/03 21:54:29 [I] Register Mail Service Enabled
2015/03/03 21:54:29 [I] Notify Mail Service Enabled
2015/03/03 21:54:29 [I] SQLite3 Enabled
2015/03/03 21:54:29 [I] Run Mode: Production
2015/03/03 21:54:29 [I] Listen: http://<IP_ADDRESS>:8080

git@git:/opt/gogs$ ps aux | grep gogs
root     32140  0.8  1.8<PHONE_NUMBER>6 pts/0    Sl   21:54   0:00 /opt/gogs/gogs web
git      32151  0.0  0.0  11740   932 pts/0    S+   21:54   0:00 grep --color=auto gogs

I know but how explain this situation on my vds server

Sorry, to explain what for the dump of ps?

/opt/gogs/gogs web running from root, but gogs was started from git user.
how gogs can fork porcess from git to root user ?

git@git:/opt/gogs$ /opt/gogs/gogs web &

Didn't you start in git user? So /home/git/.ssh/ is the directory Gogs is modifying.

that's it, I start process as git and get the process from root. I can not understand how this is possible.

I would say this is a system-matter thing, I have not enough knowledge to answer you that.

@uchti that is really odd. Gogs doesn't escalate permissions on it's own. I tested the same thing on mine and gogs always runs as the user it is started with.
In your config file, what do you have RUN_USER set to?
Is /opt/gogs/gogs the actual gogs binary or a script pointing to it?

Now i test on my dedicated server , no problem with permissions. maybe something is wrong with VDS

I found the answer
ls -all  /opt/gogs/gogs
-rwsr-sr-x 1 root git 23729252 Feb 20 08:06 /opt/gogs/gogs

Gogs owner was root user, but group git.
And git can start gogs but process have root permissions.
I fix it.
chown git:git -R /opt/gogs

@uchti cool!
So the problem is:
because Gogs runs under root, then it tries to match wrong SSH key file for you.
Do my observation correct?

In my case, gogs run under git user but process have permissions root and when any web user delete any public key, gogs change owner from git user on /home/git/.ssh/authorized_keys to root user.

@uchti I see, is your problem solved?

Because func DeletePublicKey  in models/publickey.go overwrites the file instead of to remove the line.
Yes, my problem solved. Thanks

Because func DeletePublicKey in models/publickey.go overwrites the file instead of to remove the line.

It was used to remove a line, but turns out that's not robust(once wrong, always wrong). So overwrite entire file based on database is more robust.

agree that the current version is more reliable

@iMac0de  Is this problem solved  in current version or still occurs?

Close for now, but open for continuing discussion. :dizzy:

I'm testing Gogs on Debian Jessie x64 minimal. It seems that I'm having the same issue.
Here my case:

Gogs is installed to /home/git/gogs/
Current Gogs user has 2 pub-keys (actually there is just 1 organization and 2 users)
Repositories are located under /home/git/gogs/repos/
~/.ssh/authorized_keys seems normal, (4 drw-------  2 git  git  4096 Oct 27 01:31 .ssh)
To change  the permission(s) of ~/.ssh/authorized_keys didn't helped
On the client computer for example: $ git push -u origin master
-->  Will ask for git@server password in terminal
Adding a new user with new keys did't help.

@ByteM3 try admin dashboard, click regenerate ~/.ssh/authorized_keys file.

I'm testing Gogs on Docker hypriot/rpi-gogs-raspbian. It seems that I'm having the same issue.
On the client computer : $ git push -u origin master --> Will ask for git@server password in terminal.
regenerate ~/.ssh/authorized_keys file  don't help.

regenerate ~/.ssh/authorized_keys file

How did you regenerate?

In admin > click on button regenerate ~/.ssh/authorized_keys

OK, check if file permission is 600

ls -la /home/git/.ssh/
-rw------- 1 git git 1609 Nov 19 18:10 authorized_keys

Please check your SSH auth.log

I think the problem is with the ssh port redirection docker container. I will ask creator hypriot / rpi-gogs-Raspbian. Thank you

@vignolet OK.. I did a quick search seem like last updated was 5 months ago..

I found
http://stackoverflow.com/questions/1558719/using-a-remote-repository-with-non-standard-port
and
http://serverfault.com/questions/218256/specify-ssh-port-for-git

@vignolet thanks your info! Does that solve your problem?

@Unknwon Yes, thx

@vignolet that's cool!


react performance impact?

Hi is there a performance impact with calling ReactDOM.render again upon changes in the model?
Does it work the same as a normal re-render?

Hi @ryuken
In short, most often there is no significant performance impact when re-rendering upon model changes.
Please see the following for more detailed discussion and examples:

Medium article regarding performance concerns
Preventing Re-renders on the Meiosis Wiki


when clicking links

Profile pages/Links
when I click a link on the site, it takes me to that site in my current tab, I'd like to recommend perhaps having it open a new tab

Great idea! I'll work on this tomorrow.
The change will make it, so all links included in markdown descriptions open up in a new tab.

Implemented with #11


[windows] When installing Rust, add the i686 target to enable building 32-bit binaries

Description
Currently when rust is installed on windows, it only includes the default target (x86_64-pc-windows-msvc). This change adds the equivalent i686 target so that 32-bit binaries may be built out of the box. Unfortunately 32-bit windows is still extremely common, so many (most?) projects that want to test and ship windows artifacts will need both 32-bit and 64-bit support.
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

@alex am I right that it takes about 5 seconds to install in runtime so the issue is that you need to add the installation step every time?

@alex could you pull the latest main to your branch, please?

Done

/azp run windows2016, windows2019, windows2022

/azp run windows2016, windows2019, windows2022

@sanking23

Thanj

But I ask you every time. I request a translation inventory for Koreans. I want to contribute.

@alex thank you for your contribution!


Please, explicitly inform that OU needs to be on AADC sync scope.

Dear all,
As the title already states, it would be better to customers if documentation explicitly stated that the OU chosen to receive group writeback needs to be inside Azure AD Connect scope of synchronization (step 6 - Enable group writeback).
As obvious as it might be, some customers just want to see the groups synced back to on-premises, not expecting to manage it from on-premises. However, AADC setup will fail with "OU is excluded" message, which can result in some less prepared IT personnel being clueless.
Regards
Rodrigo Dias
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cba137cc-67ca-2766-b436-54e3634f0c2f
Version Independent ID: 2f185fba-dcf2-04f5-17a1-b641dc104edd
Content: Azure AD Connect: Group writeback
Content Source: articles/active-directory/hybrid/how-to-connect-group-writeback.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@Rodrigo30Horas
Thanks for your feedback! I have assigned this issue to the author who will investigate and update as appropriate.

I have created an internal work item for this.
#please-close


(PUP-9509) Update unit tests for cache loader

Previously the unit tests for the cache loader only checked that a loadable was
specified.  However order is important.  This commit updates the unit test to
confirm that all loadables are specified in the correct order.

Related to https://github.com/puppetlabs/puppet/pull/7402

CLA signed by all contributors.


JBPM-5454 - KIE Server router - support for advanced queries and work…

…bench integration

jenkins retest this

@sutaakar any other comments or ready to merge?

Look good to me

Just one side thing, loosely related. Request handling for non GET request from [1] should be followed by return; to avoid further processing.
[1] https://github.com/droolsjbpm/droolsjbpm-integration/blob/master/kie-server-parent/kie-server-router/kie-server-router-proxy/src/main/java/org/kie/server/router/handlers/AbstractAggregateHttpHandler.java#L63

very good catch @sutaakar, merged your PR into this one so let's wait for it to rebuild, thanks


bug: Sidebar navigation not working properly.

Describe the bug
When you open the course and try navigating through the sidebar, the moment you click it, it will redirect you to the homepage.
To Reproduce
Steps to reproduce the behavior:

Open course (https://app.100xdevs.com/)
click on any lecture from sidebar

Expected behavior
open the video
Screenshots or GIFs
https://github.com/user-attachments/assets/1eae636b-c7e8-4e4e-ab21-5a2edf29beb7
Info (please complete the following information):

chrome
Version 127.0.6533.89 (Official Build) (64-bit)

works for me, check again and revert please

It works fine for me.

Works fine for me.

Now it is working fine . It has not been working for the last two days.

@Roshanbhadauriya @siinghd close this issue


[Feature] Installing and running Spleeter on Windows

Description
Installing and running Spleeter on Windows (Python 3.7)
virtualenv spleeterenv && cd spleeterenv/Scripts/ && activate
pip install . && pip install pytest pytest-xdist
Also install
pip install musdb
pip install museval
Then:
python setup.py install
It worked
Ex: spleeter separate -i song.mp3 -o audio_output -p spleeter:5stems

Hey there, I'm trying to follow these steps with a fresh installation of Python 3.8.5 and spleeter 2.0.
Firstly, I could be wrong, but I think there's meant to be a cd .. after the first line, because otherwise the pip install . gives:
ERROR: Directory '.' is not installable. Neither 'setup.py' nor 'pyproject.toml' found.

But then even when I change the working directory to be the "spleeterenv" folder, the pip install . gives me this error:
ERROR: Could not find a version that satisfies the requirement tensorflow==2.3.0 (from spleeter==2.0) (from versions: none)
ERROR: No matching distribution found for tensorflow==2.3.0 (from spleeter==2.0)

I also tried with spleeter 1.4 but it seems it doesn't support Python version 3.8 or higher:
ERROR: Package 'spleeter' requires a different Python: 3.8.5 not in '>=3.6, <3.8'

Any idea what I'm doing wrong?

You are right.
I will re-edit the steps.

Hi @OSINTAI
I'm not sure why you would need to open this issue, does the standard installation guide not work for your setup ?

Hi @mmoussallam
It did not work the first time and I installed musdb and museval as they were missing. I just wanted to help in case someone has the same issue as I did. I have put it under enhancement. :)

Thanks for the initiative :+1:  but I'm wondering because basically musdb museval are only useful for training and advanced usage and not required to just run spleeter


Use 'value' property to comply with v-model

For more info: https://vuejs.org/v2/guide/components.html#Form-Input-Components-using-Custom-Events

So for a component to work with v-model, it should (these can be configured in 2.2.0+):

accept a value prop
emit an input event with the new value

This allows creating a two-way binding of the editor content to a component's data.
<editor v-model="myEditorContent" ... />

It is still possible to specify only a 1-way binding with :value or listen for edits with @input.
I think using v-model might also be more elegant than using the "sync" option and a Watcher, but that could be a matter of taste. 😄

That would be a breaking change, I think it would be better to add the v-model/value instead of replacing the content with the value. This way users have the choice between the watcher and the v-model approach.
Unfortunately I don't have much time until Saturday, so I will only be able to have a look at everything this weekend.

Good point!
It is actually possible to use a differently named prop instead of value, I'll refactor to keep content and let v-model use that.
v-model can also use a differently named event, so editor-update instead of input but it has to fire on the component itself , not on the parent. So to keep compatibility I'll make it fire on both.
Firing an event on a parent is weeeird behaviour though, IMO. ;)

I also think the v-model approach is complicated by an issue like this: https://github.com/marcosmoura/vue-material/issues/412
But I have that on other (regular) <input> fields too:

Change something in form
input event is fired
form field is re-rendered
cursor is at the end of input.

I'm sorry for the late reply but I read through the Vue documentation today and saw another possibility which would be non-breaking.
I will commit everything tonight but what I ended up doing was the following:
In the parent component we include the following code:
<editor v-model="variable" :content="variable" :options="options"></editor>
And in the editor I just added a value prop and the following emit:
vm.$emit('input', editor.getValue());
By this the v-model gets automatically updated without the need to listen on an editor-update emit.
To clarify the situation with the watcher and the sync it a bit more: The sync is not necessary if you want to update your original variable. The sync only should be used if your original variable gets updated by a third party (= not you typing in the editor) and you want to trigger an update in the editor.


Pymarl branch

This PR will be accepted once:

Everything can be executed properly from the root.
A script to retrieve seed of any algo_env config.
A step by step guide to reproduce experiments has been created.

TODO:

merge the seed scripts
Execute the whole instructions to ensure no remaining errors.

I added a couple of minor comments. I understand we have to further test this before merging.


Tiles metadata fix

Fixed Tiles metadata API

Updated all the metadata APIs related to OGC Tiles API
Updated SQL queries to incorporate new database schema changes
Supports both vector and map tiles metadata informations

BUG FIX: Accept headers without weightage

If no weightage is provided or only one Accept type is mentioned, it will assume that as the encoding type for Tiles

Build finished.


This line seems to contain a bug: if classpathEntry turns out to be a directory, this comparison unsurprisingly always fails:

original description
    This line seems to contain a bug: if classpathEntry turns out to be a directory, this comparison unsurprisingly always fails:

Invalidating '.../build/classes/scala/main/.../Foo.class' because
 .../build/classes/scala/main/....class (farm(77c283a23fed88f2)) != .../build/classes/scala/main (absent)
                                                                         ^^^ RHS is a ***directory***.

The resolve step was completely dropped in this PR.
Originally posted by @mernst-github in https://github.com/sbt/zinc/pull/712#discussion_r1002970496

Try enabling https://github.com/sbt/zinc/blob/develop/internal/zinc-core/src/main/scala/sbt/internal/inc/IncrementalCommon.scala#L46 in the compileScala.scalaCompileOptions.forkOptions.

Seems to be working for us. Thanks 🙏


PersonDAO: Remove "type" property from return values.

Remove the internal type attribute from the return values.

Done. Switched to separate namespaces within the database (see lib/storage) for more information.


Authentication for Signup and Login

Authenticate login & signup
Updated UserContext and AuthContext

Authentication Login & Signup, this is good.

React integrated with authentication apis.


Documentation - wireSet[]

How about to add small paragraph abut wireSet[] in readme?
I've spent some time unless found this feature is ready to use.

Sure - do you have anything specific in mind? If so, maybe a PR? :)

No I don't have anything specific at the moment, but I can work on it :)


Dashy add to Home Screen opens to 404

Environment
Self-Hosted (Docker)
Version
Latest stable also tested last two stable versions
Describe the problem

Not sure if this is bug or feature requests but I picked bug as it should work as is. I have web browser (safari,chrome etc) opens my dashy perfectly fine but not sure if you are using IOS, it has this “add to Home Screen” feature which is basically very convenient for me to use rather than opening browser and opening url. So opening this added page of dashy leads me to the screenshot and clicking on back home takes me to my actual dashy page. Why is this happening why not just opens my dashy right away like the url in browser? I cannot really figure this out. Any help is appreciated.
Additional info
Not really needed I believe simple dashy, one page yml config.
Please tick the boxes

[X] You are using a supported version of Dashy (check the first two digits of the version number)
[X] You've checked that this issue hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

Try setting appConfig.routingMode to hash

great, it worked. I could not figure this out myself :) thanks a lot!

After latest update this problem is back :)

I have got the behaviour with Android too, tested both with Firefox and Chrome.
See my comment on the other issue for a possible fix/workaround.


Crash on start

Cant even start when lsposed module is off

dupicate https://github.com/vendetta-mod/Vendetta/issues/145


Migrated set-output command

Current dependencies on/for this PR:

main

PR #356   👈

This comment was auto-generated by Graphite.


Make determinant work consistently on size 0 inputs

Summary
Fixes #1431 by returning 1 for size 0 inputs.
Tests
Added the one mentioned in the issue.
Side Effects
None.
Checklist

[X] Math issue #1431

[X] Copyright holder: Marco Colombo
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[X] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[X] the code is written in idiomatic C++ and changes are documented in the doxygen

[X] the new changes are tested

Thanks Rok! I have another PR ready to go on its own, but a few other of this sort that I could merge together. Good to know. :)


Deploy to BCR

With https://github.com/mvukov/rules_ros/pull/59 we already get all deps from BCR. How about contributing this module to BCR as well @mvukov?
With https://github.com/bazel-contrib/rules-template/tree/main/.bcr, this deployment could be even automated.

Linking https://github.com/bazelbuild/bazel-central-registry/issues/2223 as cross reference

Sure, fine with me. Practical question: this repo follows live-at-head approach. Does BCR support this workflow?

On BCR you can only download a dedicated pinned version. But if we setup the automated BCR deployment, we could do this for every commit on master or triggered by a tag.
If we don't want to do semver, we could also use yyyy-mm-dd-hh style versions.

Hi, I've had a few clients asking for ROS support so I could help out a bit in this repo.
I highly recommend doing releases. As one datapoint, it's required for repos in the Linux Foundation (https://bazel-contrib.github.io/SIG-rules-authors/hosting-policy.html#adding-criteria)
I suggest we set this up with a simple "push a tag to trigger a release" - so there's no effort required from maintainers. This is how it's done in the rules-template: https://github.com/bazel-contrib/rules-template/blob/main/CONTRIBUTING.md#releasing


Compressed gfa

It adds support for both compressed and uncompressed GFA files. They can be mixed freely. It fixes #3

That's a workaround. The correct way will be to update the GFAParserBuilder in rs-gfa to support compressed files.


@conda-forge-admin,please add bot automerge

Additional comment:
No response

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/tsid-feedstock#14.


Increase request-timeout to deal with timeouts in Marklogic tests.

This should prevent the timeouts we're seeing. 🤞

This only moved the timeout from Marklogic to the test suite. The failing tests here are simply slow and timeout in five minutes. I guess I was just lucky when it fixed the problem in my branch.


clippy: ptr_as_ptr

Motivation
Change casts that don't change mut to .cast<T>().

Great, thank you very much! I really need to look into clippy and extend CI to run these checks.


prefix all functions with jd_ ?

https://github.com/microsoft/jacdac-c/blob/052213885e2cfe9158869d22dd36b31206835513/inc/interfaces/core/jd_app.h#L3

Probably a good idea, yes. I assume there is some sort of C library convention we should follow? At the moment though "jd_" is prefixed to "library" calls. We should use a different name prefix for low-level apis: "_jd"

Just start everything with jd_, then maybe jd_ll_

same for an constants #define JD_ ... we want to be as consistent and conflict free as possible.

Okie dokie, this is the first cut. Let me merge into jacdac-tiny first please.

All exported symbols should be jd_* or JD_*. I guess I would prefer _jd_* for internals, _ll_ suggests you can still call them, they are just low level.
As per C standard you cannot start names with _, but everyone does it anyways. I would avoid double underscore though.

👍 for the underscore prefix!


fluid:telemetry:SummaryStatus:Behind

let buildId = "60809";
database("Office Fluid Test").office_fluid_ffautomation_error
| where Event_Time > ago(7d) and Data_hostName  == "@fluid-internal/test-service-load" and Data_buildId == buildId
| summarize count() by Data_eventName

Happened after https://github.com/microsoft/FluidFramework/pull/8951

@tyler-cai-microsoft can you please add a more descriptive title and add a description for this? Right now, this does not give any information at all.

Resolved with PR: https://github.com/microsoft/FluidFramework/pull/9891.
We are not seeing this anymore.


Issue running notebook

After installing via pip install google-vizier and then cloning this repo to obtain the running_vizier.ipynb notebook, I ran the first cell and had the following error:
File ~/miniconda3/lib/python3.8/site-packages/vizier/_src/pyvizier/oss/metadata_util.py:6, in <module>
      3 from typing import Tuple, Union, Optional, TypeVar, Type, Literal
      5 from vizier._src.pyvizier.shared import trial
----> 6 from vizier.service import key_value_pb2
      7 from vizier.service import study_pb2
      8 from vizier.service import vizier_service_pb2

ImportError: cannot import name 'key_value_pb2' from 'vizier.service' (/home/.../miniconda3/lib/python3.8/site-packages/vizier/service/__init__.py)

Have other folks ran into this when trying to run the notebook and have any solutions?

Hi folks thanks for replying!
@sagipe running install.sh resolved the cannot import key_value_pb2 error in the original issue message
However now I am getting the following error when trying to run the first cell of imports in the notebook
  File "temp.py", line 5, in <module>
    from vizier.service import clients
  File "/home/sprakash/Documents/Repos/vizier/vizier/service/clients.py", line 9, in <module>
    from vizier.service import pyvizier as vz
  File "/home/sprakash/Documents/Repos/vizier/vizier/service/pyvizier/__init__.py", line 5, in <module>
    from vizier._src.pyvizier.oss import metadata_util
  File "/home/sprakash/Documents/Repos/vizier/vizier/_src/pyvizier/oss/metadata_util.py", line 119, in <module>
    metadata: common.Metadata) -> list[key_value_pb2.KeyValue]:
TypeError: 'type' object is not subscriptable

@xingyousong I get this same error when I simply try to copy and paste the code into a .py file and execute it too.
Any thoughts y'all? Thanks again!

Ah ok - the next issue is that I realize there's a mix of pytyping via list (which is supported starting from Python 3.10) and not List in the code, sorry - can you try Python 3.10?

Alright looks like that worked :) Thanks @xingyousong!
The first cell with the imports throws this warning still now (but it runs to completion at least).
warning in stationary: failed to import cython module: falling back to numpy
warning in coregionalize: failed to import cython module: falling back to numpy
warning in choleskies: failed to import cython module: falling back to numpy

I am able to run the rest of the notebook successfully though it seems!
This is the final two cells output:

Does this look right to you @xingyousong @sagipe ?

Two things I learned from this issue that were not clear to me before so I just want to note here for future reference if it helps out!

Need to run ./install.sh
Need to use Python 3.10

@ShvetankPrakash Yeah the output looks correct - Note that some of the cells in certain colabs aren't meant to be run (e.g. the ones involving class definitions).
I'll send a commit to change back to Python 3.9 typing for now to be consistent and avoid dict / list Pytyping.
Closing for now.

One follow up question @xingyousong! I am trying to integrate your open source version of Vizier with (CFU-Playground)[https://github.com/google/CFU-Playground], a fully open source framework for designing TinyML accelerators. That framework currently uses Python 3.7. Is there a package version of your open source Vizier compatible with Python 3.7? Thanks!

@ShvetankPrakash One of the nice things about OSS Vizier is that it's using a server-client architecture.
This means that you can install OSS Vizier, run the server on your machine (from the terminal, or from a notebook runtime with Python 3.10+), and then in a separate Colab / Python script / IPython, run the client to connect to the server.
If you want to run everything from Colab, then you could:

Run one Colab with Python 3.10+, and execute only the "Setting up the server" section
Run another Colab with Python 3.7, where you skip the "Setting up the server", but run "Setting up the client" and all other related sections.

Best,
Sagi

@sagipe thank you so much for the great suggestion! This I think should work as a solution :)
One thing to mention: I did have to manually add the changes from @xingyousong [PR} (https://github.com/google/vizier/pull/168) to test it for now in order for the client code to be compatible with 3.7.
When I made those changes I was able to run the Colab notebook using 3.7 for the client side code and the server code using 3.10!
Thanks again for the terrific help to you both!

Hi folks!
I was able to get Vizier integrated and working with CFU-Playground! :)
I had a follow up question that is related to this issue:
In the notebook running_vizier.ipynb in is there an example of how you Vizier parallelizes the following code block (in the notebook) when searching:
suggestions = study_client.suggest(count=5)
for suggestion in suggestions:
  x = suggestion.parameters['x']
  y = suggestion.parameters['y']
  print('Suggested Parameters (x,y):', x, y)
  final_measurement = vz.Measurement({'maximize_metric': evaluate(x, y)})
  suggestion.complete(final_measurement)

Would appreciate your insight on this @sagipe or @xingyousong , thank you so much!

Hi @ShvetankPrakash, when we say parallelization, we mean that the server can handle multiple clients working on the same study. So for example, if it requires a single thread to compute your objective, then multi-threading can be used where each thread uses a client, see here for an example: https://github.com/google/vizier/blob/main/vizier/service/performance_test.py#L43
Another case is if an entire machine needs to be used to compute a single objective (e.g. in settings where you're training a large neural network). In this case, you'd have to perform some real distributed networking to have all of the worker machines connect to the server machine.

Hi @xingyousong -
Appreciate the explanation, makes sense! I had one more follow up to make sure I understand that code block in my previous comment.
When the user requests 'count' number of suggestions, are all the suggestions determined at that moment or iteratively? As in when we write:
suggestions = study_client.suggest(count=5)
for suggestion in suggestions:
  ...
  suggestion.complete(final_measurement)

Is each iteration thru the for loop using a suggestion that takes into account the result of the previous suggestion? Just trying to understand how the feedback loop works for Vizier to explore the design space :) Thanks!
`

@xingyousong I see! But that is all handled by the algo specified when instantiating the study_client ? As in, as a User we do not need to feedback the suggestion outputs ourselves to the study_client
(perhaps suggestion.complete(final_measurement) is what does that) ? Just trying to see if like at the end of the for loop there is anything I need to feed back in to get more suggestions.

We conveniently wrapped the StudyClient API to return technically a TrialClient which also has a link to the server: https://github.com/google/vizier/blob/main/vizier/service/clients.py#L146, so those suggestions are actually instances of TrialClient.
So suggestion.complete(...) is all you need to do, and underneath the hood, the feedback will be sent to the server.

Got it, thank you so much for your replies @xingyousong ! They really helped a lot :)


Add fuzz test for deepcopy

Please provide a description of this PR:
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
19e6f078892cd3e06e010f67cc887190f331dc83
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
19e6f078892cd3e06e010f67cc887190f331dc83
link
true
/test release-notes_istio

integ-cni_istio
19e6f078892cd3e06e010f67cc887190f331dc83
link
true
/test integ-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
19e6f078892cd3e06e010f67cc887190f331dc83
link
true
/test integ-cni_istio

release-notes_istio
19e6f078892cd3e06e010f67cc887190f331dc83
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio


The user has created 12 multi-signatures for one address, and the three signatures set by himself are used for transactions

0xC41Dd7D65444cdCD80d7E2FBd9d20c4B191Cf988
0x2d737cd0eBbdB40f4bCDDCbd0FcE1C03eB4a60Ba
0x821B7C84313B4901094246621181e995E5F1A83A
0xA4E870BFf703007E8a039b8947168cff22b50C90
0xB7E850025f77292c1602E2a48123b1455864FeCE
0x78eDDdE998E446A09A5b2054516f1da0B72CadA5
0xbdAE68423e2aB0Ff3164e02478a62CBfd73FbB68
0x865032F9ecF34F31f901bd420A476C6322fD13d4
0x5Adb607541cA9c1FA7bfc451A4b825EB56fD04D9
0x6E7497241C416fCC5E3447180882756dcf7Df5a0
0xEB17f902307dC052701e501F07e1C556Beb1a368
Reasoning
The airdrop hunter used the 0xf9d38489b6fd704fd112934322908ee0b6cfbdd4 mainnet wallet to create 12 multi-signature ，
0xf9d38489b6fd704fd112934322908ee0b6cfbdd4
0x442f821b35c919b713625e0a7a1564c5d9f8d0a0
0x3620e4ba3927181acb286ff481e275fd29a39530
0xeac3bf0b39a5e3e7ee8bdc92bf3cdb18f82e69ba
The four addresses above are used for signing
Methodology
Analysis according to the query results of the Ethernet browser，Most of the executed transactions are used to trade TRVL, hash:0xb9bd9cb25235b6240a24b5163aa87d765f0416a9315e16222ec91c21700237d8
Tokens with some contract addresses are transferred from the wallet creation, hash: 0x1fa79f947a5d70565351ecc12c50f8f325aae856e904faa94f4c841e46c7a98c
Or transfer from Binance
All of them have nothing to do with the repeater, because 40 wallets that execute transactions and create contract addresses are initiated,0x3620e4BA3927181ACb286Ff481E275FD29A39530 Execute 142 strokes。If it is a repeater, its signature and execution will have nothing to do with the creation of the main wallet, rather than from the main wallet。hash:0x7473339c827c3f2ac889ec076dc604a3a55d912011fe9ef2975bc9f616e4a481
most important point 0xf9d38489b6fd704fd112934322908ee0b6cfbdd4 and 0x3620e4ba3927181acb286ff481e275fd29a39530 Of the nearly 200 transactions initiated, all were transfers TRVL
My Safe Address
0x04b9f219331e4586Ae35cff9065eFc2A09F29751

Checked the first 2 Safes
https://etherscan.io/address/0xC41Dd7D65444cdCD80d7E2FBd9d20c4B191Cf988
https://etherscan.io/address/0x2d737cd0eBbdB40f4bCDDCbd0FcE1C03eB4a60Ba
Both have an etherscan label related to https://dtravel.com/.
This seems like legitimate usage to me.


useInfiniteQuery does not continue to fetch after first load

Describe the bug
Just upgraded from 2.4.15 to 2.5.11 and noticed a breaking change in my application.
When using useInfiniteQuery and immediately calling fetchMore to exhaust the list of resources, the request is skipped due to this.promise stuck in pending state. See example below:
const useListClusters = () => {
  const query = useInfiniteQuery<ClustersQuery, string, string>(
    'listClusters',
    async (_, prevNextToken?: string) => {
      const { clusters, nextToken } = await listClusters({ nextToken: prevNextToken });
      return { clusters, nextToken };
    },
    { getFetchMore: (last) => last.nextToken }
  );

  return query;
};

Usage:
const CardView = () => {
  const { data, canFetchMore } = useListClusters();

  React.useEffect(() => {
    if (canFetchMore) {
      fetchMore();
    }
  });

  const clusters = React.useMemo<string[]>(() => {
    return data?.reduce((acc, curr) => acc.concat(curr.clusters), []) ?? [];
  }, [data]);

  return (
    <View data={clusters}>...</View>
  );
};

After tracing the call with the debugger, I have found that the issue is because the promise is still stuck in the pending state even though it has completed and the ui has updated.
/src/core/query.ts#L397-L399:
To Reproduce
Steps to reproduce the behavior:

Use a paginated api (in my case, it is the aws list clusters api from ecs)
Create example component from above.
Create enough resource for the call to return a nextToken
See only 1 call get made even when nextToken is returned.

Expected behavior
If nextToken is returned, I should see another call to the api.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: MacOS Mojave
Browser: chrome
Version: 84

Additional context
I believe the functionality was broken shortly after 2.4.15. I will try to verify which version broke it. In the meantime, I will also try to find an open source API and create a code sandbox for easier repro steps.

Another interesting bug somewhat related to this:
So I have about 16 pages worth of data. After the page mounts, the current page count in the query is 1 (due to the bug above). After the page is settled, I click a button that calls refetch. In the network tab, I see the correct amount of queries (16 total). However, the query object only shows 9 and the total list of items is reflected inaccurately on the page.
Seems like there is some sort of race condition going on here causing some queries to be skipped or overlooked?

So I've hacked up an environment to repro this issue here: https://codesandbox.io/s/react-query-test-ebsco
However, as you'll see, it works just fine...
So I went back to my environment to test this out and come to find out that the query stops after the first request depending on what I render in the return statement..
If I just return something like:
return (

        {clusters.map((i) => (

{i}

        ))}

);

Everything works just fine. I see 16 network calls in the network tab.
In my case I have a component UnifiedLayout
and where it breaks is the moment I render something like:
return (
  <UnifiedLayout>

        {clusters.map((i) => (

{i}

        ))}

  <UnifiedLayout>
);

I see only 1 network call in this case...
Any idea whats going on here?


Add features to readme and create new section for features in messages

also added nice formatting to list of commands in readme

Squashed it.


WIP - Issue 16

:construction: work in progress
Fixes #16
Things that should be made to work

a=b; domain=example.dev should work for www.example.dev (Note .dev isn't a registered top-level domain)
a=b; domain=www.example.dev should work for http://www.example.dev
a=b; domain=localhost should work for http://localhost:3000 (Note localhost isn't a registered top-level domain)

Just realized that I can't use https://github.com/request/request on my dev environment because it uses tough-cookie and tough-cookie can't set cookie with domain .bla.dev.
@stash are you still interesting in this repo?
Is there some alive maintainer?

Looks like we can just close this PR

@apsavin Is issue still exists in v1.1.0 which was released recently?

No: this test passes.

@apsavin Thanks for taking a look. Closing this PR.


[WIP] UIPickerView reactive adapter

Hi, guys the draft version of UIPickerView based on discussion here
Concerns

I feel like we will need to have some bits in the main repo as well. Probably we'll need access to this method
Also since titleForRow, attributedTitleForRow and  viewForRow are part UIPickerViewDelegate we need to have Adapter that implements both UIPickerViewDataSource and UIPickerViewDelegate and for sure we need to be able for user to use itemSelected: ControlEvent<(Int, Int)> so I believe we gonna use rx.setDelegate
I've chosen inheritance over composition here because it's fine     ¯_(ツ)_/¯

Screenshots

Hm.. I need to update the prods to use latest API from RxCocoa, and they are in the main repo.
Do you want me to make a PR with updating pods? or you want update them your self and I just pull the changes?

Let's make another PR with updating dependencies.

Hi @sergdort ,
could you please comment public interface of these these classes, and then I think we can merge this. I think the most important thing to document is how does each parameter relate with delegate method, although that should be pretty evident.
I like this immutable adapter way better then what we had before and I'm hoping to refactor table and collection view interfaces to have this form.


RaGOO Chr > reference Chr

Hello,
I am trying to use RaGOO to map a frog draft assembly (4.6G) of another 30Mya diverged high quality assembly (4.4G), RaGOO is doing a great job for chr1-10 except the strange pattern i observe for the chr11-13: the constructed Chr are larger than the reference. Would appreciate any suggestion how to deal with that.

Hi there,
All I can say is that, for some reason, many of your contigs are preferentially aligning to those chromosomes. Given the distance between the two genomes, I suppose there could be a variety of biological reasons why this could happen. For example, are you sure these even have the same # of chromosomes?
Certainly, this would be outside the usual scope of RaGOO which was designed for closely related genomes. Though you can use any two genomes, this may indicate that they are just too diverged to expect accurate scaffolding.


Scaling of Laplacian pre-computation

First, I would like to say that I think there are some very good ideas in the paper. Nice work! I have some questions though:
Could you tell me what the largest graph is that you've used this approach on? Do you have any recommendations for Laplacian eigenvector encodings for large graphs? The way it's implemented now, using np.linalg.eig and the .to_array() call, which seems to lose the sparsity, could give some problems.

Hi @JellePiepenbrock,
The largest graph size (i.e. number of nodes in a single graph) that is considered in our experiments is 190 (for SBM).
Thank you for raising the issue of scaling of pre-computation -- something we shall focus in future works.


Add a license

This project does not have a license.
Would it be possible to release it under an MIT license? If so, I think more people would consider using it, or contributing to it.

of course

Actually... it DOES have a license -
check package.json
Sincerely


Issue in Broadcast Parameters (Posting Comments)

From last few days I'm working on steem methods. What I found was there is no proper documentation for the parameters used in broadcast methods.
Eg.
steem.broadcast.comment(
' 5J9--------3emc', //wif
' ',   //parentAuthor
'steemit', //parentPermlink
'holwylb', //author
'render-en-cinema-4d',  //permlink
'Render en cinema 4d',   //title
' ',    //body
' ',     //jsonMetadata
function(err, result) {
console.log(err, result);
});
Q) Whatever I want to comment will come inside body parameter or in jsonMetadata?
I have tried both but getting error "3030000 tx_missing_posting_auth: missing required posting authority" .
Any other key is also required for doing comments?
Can anyone plz share working eg. for the same and other examples related to broadcast methods.
Thanks in advance..

The comment content has to be inside body parameter. jsonMetadata parameter is an object with post details. You need only a private posting WIF to broadcast a comment. Here is an example how to do:
steem.broadcast.comment(
  '5Jd...', // Your posting wif
  'siol', // Parent Author
  'test', // Parent Permlink
  'pj1423', // Your username
  'this-is-a-test', // Your post permlink
  '', // Title
  'This is a test!', // Body
  { tags: ['test'], app: 'steemjs/test' }, // Json Metadata
  function(err, result) {
    console.log(err, result);
  }
);

We updated the file /examples/broadcast.html on this repo to include an example of comment operation, you can checkout the file here: https://github.com/steemit/steem-js/blob/361a172d33d04889c1315c3056830701c7bf8eb8/examples/broadcast.html and test it localy.

Hey thanks buddy.. it worked..
It would be very helpful if you can explain how to post blogs and how can we follow and unfollow users.

For broadcast a post you need also to use comment operation. Leave parentAuthor + parentPermlink empty and add a title. Like this:
steem.broadcast.comment(
  '5Jd...', // Your posting wif
  '', // Parent Author
  '', // Parent Permlink
  'pj1423', // Your username
  'this-is-a-test-post', // Your post permlink
  'This is a test post', // Title
  'Just trying to post using steem.js', // Body
  { tags: ['test'], app: 'steemjs/test' }, // Json Metadata
  function(err, result) {
    console.log(err, result);
  }
);

Follow and unfollow works with custom_json operation here is the format:
var json = JSON.stringify(
  ['follow', {
    follower: 'YOUR_USERNAME',
    following: 'USERNAME_TO_FOLLOW',
    what: ['blog'] // Use an empty array "[]" to unfollow
  }]
);
steem.broadcast.customJson(
  'YOUR_POSTING_WIF',
  [], // Required_auths
  ['YOUR_USERNAME'], // Required Posting Auths
  'follow', // Id
  json, //
  function(err, result) {
    console.log(err, result);
  }
);

I've updated this page with follow/unfollow https://github.com/steemit/steem-js/blob/04fc58e5eeef6f4fbcc5194da35da07cadb59ff1/examples/broadcast.html#L44-L85

Thanks
Just used above method to post data but every time getting same error.
steem.broadcast.comment(
'5Jd...',
'',
'',
'pj1423',
'test-post-to-check-steem-method',
'Test post to check steem method',
'Just trying to post using steem.js',
{ tags: ['test'], app: 'steemjs/test' },
function(err, result) {
console.log(err, result);
});
assert_exception: Assert Exception permlink.size() > STEEMIT_MIN_PERMLINK_LENGTH && permlink.size() < STEEMIT_MAX_PERMLINK_LENGTH: Permlink is not a valid size.

My mistake, actually parentPermlink has to be filled. It's used as main tag of the post. I've updated the example in my last comment and added it on the page examples/broadcast.html

Thank you
Really very helpful.. 👍
Can you please tell one more thing. While using Login method it is always returning true, whether giving correct steem name and password or not.
steem.api.login( 'pj1423',  //username '5J9...', //password  function(err, result) {   console.log(err, result); });
Is there any other method for login and what are the parameters will we get after login.

It's not safe to run this method with your password as it's sent plain to the node websocket. This method will only return true, its used in intern with empty values to enable broadcast. You don't need to login for broadcast an operation.

Yes I'm able to use all broadcast methods but I was making a small app using these methods and what I want is a login screen where all steem members can login using there user name and password.
Is there any other way to do the same.
I'm stuck in this process of login.
Please help.

In following method Required_auths will be blank and what parameters will come inside  Required Posting Auths.
steem.broadcast.customJson(
postingWif,
[], // Required_auths
[follower], // Required Posting Auths
'follow', // Id
json, //
function(err, result) {
console.log(err, result);
}
);

For login i recommend you to use steemconnect.com for secure the keys of your users, you can find a tutorial here: https://steemit.com/tutorial/@krnel/tutorial-how-to-add-steemit-login-to-your-site-with-steemconnect
Required posting auths require your username inside an array. following is the user you want to follow/unfollow.

Hey Fabien
Thanx :-)
This tutorial was very helpful and now I'm able to login through my steem id and password and redirect to different page.
Now I want to create my own login page where user can login using there steem id and password.
From where I can get API's or  steemConnect methods related to Login and forgot password, which I can use in my login page as I don't want to redirect user to steem login page.
Please guide.


Windows script issues

After #1157 lands, one of the issues I face on Windows will be fixed. These leaves us with two more issues I've noticed so far:

Using updateReadme.py results in broken Unicode characters. Example: Christian Martínez becomes Christian MartÃnez
The script results in backslashes used in Readme URLs:-Unified hosts **+ fakenews** | [Readme](https://github.com/StevenBlack/hosts/blob/master/alternates/fakenews/readme.md) | [link](https://raw.githubusercontent.com/StevenBlack/hosts/master/alternates/fakenews/hosts) | 52,621 | [link](http://sbc.io/hosts/alternates/fakenews/hosts)
+Unified hosts **+ fakenews** | [Readme](https://github.com/StevenBlack/hosts/blob/master/alternates/fakenews\readme.md) | [link](https://raw.githubusercontent.com/StevenBlack/hosts/master/alternates/fakenews\hosts) | 52,628 | [link](http://sbc.io/hosts/alternates/fakenews\hosts)

2 ==> #1165
1 ==> It comes from the readme_template. It's probably because you're not reading in UTF-8 ?

I got frustrated with this and just started my own repo, but it's good to see some work being done on this again.

@funilrys about the second point, there's still at least once we end up with backslashes, see https://github.com/StevenBlack/hosts/pull/1165#issuecomment-590111613
About the UTF issue, I didn't do anything myself, I just ran the scripts.

@StevenBlack there's still an issue with backslashes, see my comment above https://github.com/StevenBlack/hosts/issues/1166#issuecomment-590247036

BTW what's the exact scripts/command you run @StevenBlack to generate the files? I'm asking because whenever I try it on Windows I get too many changes in each file

@XhmikosR I haven't used Windows in at least 10-years.  I'm on MacOS and Ubuntu.
I run makeHosts.py which generates all the variants, in turn.
What do you mean, "I get too many changes in each file"?

@StevenBlack understandeable, but please re-open the issue until we manage to fix everything; we are so close :)
C:\Users\xmr\Desktop\hosts>git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

C:\Users\xmr\Desktop\hosts>python makeHosts.py
Updating source data\adaway.org from https://raw.githubusercontent.com/AdAway/adaway.github.io/master/hosts.txt
Updating source data\add.2o7Net from https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.2o7Net/hosts
Updating source data\add.Dead from https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.Dead/hosts
Updating source data\add.Risk from https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.Risk/hosts
Updating source data\add.Spam from https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.Spam/hosts
Updating source data\Badd-Boyz-Hosts from https://raw.githubusercontent.com/mitchellkrogza/Badd-Boyz-Hosts/master/hosts
Updating source data\hostsVN from https://raw.githubusercontent.com/bigdargon/hostsVN/master/option/hosts-VN
Updating source data\KADhosts from https://raw.githubusercontent.com/PolishFiltersTeam/KADhosts/master/KADhosts_without_controversies.txt
Updating source data\malwaredomainlist.com from https://www.malwaredomainlist.com/hostslist/hosts.txt
Updating source data\mvps.org from https://winhelp2002.mvps.org/hosts.txt
Updating source data\someonewhocares.org from https://someonewhocares.org/hosts/zero/hosts
Updating source data\StevenBlack from https://raw.githubusercontent.com/StevenBlack/hosts/master/data/StevenBlack/hosts
Updating source data\tiuxo from https://raw.githubusercontent.com/tiuxo/hosts/master/ads
Updating source data\UncheckyAds from https://raw.githubusercontent.com/FadeMind/hosts.extras/master/UncheckyAds/hosts
Updating source data\yoyo.org from https://pgl.yoyo.org/adservers/serverlist.php?hostformat=hosts&mimetype=plaintext&useip=<IP_ADDRESS>
Updating source extensions\fakenews from https://raw.githubusercontent.com/marktron/fakenews/master/fakenews
Updating source extensions\gambling from https://raw.githubusercontent.com/Sinfonietta/hostfiles/master/gambling-hosts
Updating source extensions\porn\clefspeare13 from https://raw.githubusercontent.com/Clefspeare13/pornhosts/master/<IP_ADDRESS>/hosts
Updating source extensions\porn\sinfonietta from https://raw.githubusercontent.com/Sinfonietta/hostfiles/master/pornography-hosts
Updating source extensions\porn\sinfonietta-snuff from https://raw.githubusercontent.com/Sinfonietta/hostfiles/master/snuff-hosts
Updating source extensions\porn\tiuxo from https://raw.githubusercontent.com/tiuxo/hosts/master/porn
Updating source extensions\social\sinfonietta from https://raw.githubusercontent.com/Sinfonietta/hostfiles/master/social-hosts
Updating source extensions\social\tiuxo from https://raw.githubusercontent.com/tiuxo/hosts/master/social
==>fe00::0 ip6-localnet<==
==>ff00::0 ip6-mcastprefix<==
==>ff02::2 ip6-allrouters<==
==>ff02::3 ip6-allhosts<==
Success! The hosts file has been saved in folder alternates/gambling
It contains 54,006 unique entries.
==>fe00::0 ip6-localnet<==
==>ff00::0 ip6-mcastprefix<==
==>ff02::2 ip6-allrouters<==
==>ff02::3 ip6-allhosts<==
Success! The hosts file has been saved in folder alternates/porn
It contains 67,654 unique entries.
==>fe00::0 ip6-localnet<==
==>ff00::0 ip6-mcastprefix<==
==>ff02::2 ip6-allrouters<==
==>ff02::3 ip6-allhosts<==
Success! The hosts file has been saved in folder alternates/social
It contains 54,153 unique entries.
==>fe00::0 ip6-localnet<==
==>ff00::0 ip6-mcastprefix<==
==>ff02::2 ip6-allrouters<==
==>ff02::3 ip6-allhosts<==
Success! The hosts file has been saved in folder alternates/fakenews
It contains 52,627 unique entries.
==>fe00::0 ip6-localnet<==
==>ff00::0 ip6-mcastprefix<==
==>ff02::2 ip6-allrouters<==
==>ff02::3 ip6-allhosts<==
Success! The hosts file has been saved in folder alternates/fakenews-gambling
It contains 54,948 unique entries.
==>fe00::0 ip6-localnet<==
==>ff00::0 ip6-mcastprefix<==
==>ff02::2 ip6-allrouters<==
==>ff02::3 ip6-allhosts<==
Success! The hosts file has been saved in folder alternates/fakenews-porn
It contains 68,596 unique entries.
==>fe00::0 ip6-localnet<==
==>ff00::0 ip6-mcastprefix<==
==>ff02::2 ip6-allrouters<==
==>ff02::3 ip6-allhosts<==
Success! The hosts file has been saved in folder alternates/fakenews-social
It contains 55,095 unique entries.
==>fe00::0 ip6-localnet<==
==>ff00::0 ip6-mcastprefix<==
==>ff02::2 ip6-allrouters<==
==>ff02::3 ip6-allhosts<==
Success! The hosts file has been saved in folder alternates/gambling-porn
It contains 69,975 unique entries.
==>fe00::0 ip6-localnet<==
==>ff00::0 ip6-mcastprefix<==
==>ff02::2 ip6-allrouters<==
==>ff02::3 ip6-allhosts<==
Success! The hosts file has been saved in folder alternates/gambling-social
It contains 56,474 unique entries.
==>fe00::0 ip6-localnet<==
==>ff00::0 ip6-mcastprefix<==
==>ff02::2 ip6-allrouters<==
==>ff02::3 ip6-allhosts<==
Success! The hosts file has been saved in folder alternates/porn-social
It contains 70,121 unique entries.
==>fe00::0 ip6-localnet<==
==>ff00::0 ip6-mcastprefix<==
==>ff02::2 ip6-allrouters<==
==>ff02::3 ip6-allhosts<==
Success! The hosts file has been saved in folder alternates/fakenews-gambling-porn
It contains 70,917 unique entries.
==>fe00::0 ip6-localnet<==
==>ff00::0 ip6-mcastprefix<==
==>ff02::2 ip6-allrouters<==
==>ff02::3 ip6-allhosts<==
Success! The hosts file has been saved in folder alternates/fakenews-gambling-social
It contains 57,416 unique entries.
==>fe00::0 ip6-localnet<==
==>ff00::0 ip6-mcastprefix<==
==>ff02::2 ip6-allrouters<==
==>ff02::3 ip6-allhosts<==
Success! The hosts file has been saved in folder alternates/fakenews-porn-social
It contains 71,063 unique entries.
==>fe00::0 ip6-localnet<==
==>ff00::0 ip6-mcastprefix<==
==>ff02::2 ip6-allrouters<==
==>ff02::3 ip6-allhosts<==
Success! The hosts file has been saved in folder alternates/gambling-porn-social
It contains 72,442 unique entries.
==>fe00::0 ip6-localnet<==
==>ff00::0 ip6-mcastprefix<==
==>ff02::2 ip6-allrouters<==
==>ff02::3 ip6-allhosts<==
Success! The hosts file has been saved in folder alternates/fakenews-gambling-porn-social
It contains 73,384 unique entries.
==>fe00::0 ip6-localnet<==
==>ff00::0 ip6-mcastprefix<==
==>ff02::2 ip6-allrouters<==
==>ff02::3 ip6-allhosts<==
Success! The hosts file has been saved in folder
It contains 51,685 unique entries.

which results in a diff like this:
 alternates/fakenews-gambling-porn-social/hosts     | 80242 +++++++++---------
 alternates/fakenews-gambling-porn-social/readme.md |   184 +-
 alternates/fakenews-gambling-porn/hosts            | 80242 +++++++++---------
 alternates/fakenews-gambling-porn/readme.md        |   180 +-
 alternates/fakenews-gambling-social/hosts          | 80216 +++++++++---------
 alternates/fakenews-gambling-social/readme.md      |   176 +-
 alternates/fakenews-gambling/hosts                 | 80216 +++++++++---------
 alternates/fakenews-gambling/readme.md             |   172 +-
 alternates/fakenews-porn-social/hosts              | 80244 ++++++++++---------
 alternates/fakenews-porn-social/readme.md          |   182 +-
 alternates/fakenews-porn/hosts                     | 80244 ++++++++++---------
 alternates/fakenews-porn/readme.md                 |   178 +-
 alternates/fakenews-social/hosts                   | 80216 +++++++++---------
 alternates/fakenews-social/readme.md               |   174 +-
 alternates/fakenews/hosts                          | 80216 +++++++++---------
 alternates/fakenews/readme.md                      |   170 +-
 alternates/gambling-porn-social/hosts              | 80242 +++++++++---------
 alternates/gambling-porn-social/readme.md          |   182 +-
 alternates/gambling-porn/hosts                     | 80242 +++++++++---------
 alternates/gambling-porn/readme.md                 |   178 +-
 alternates/gambling-social/hosts                   | 80216 +++++++++---------
 alternates/gambling-social/readme.md               |   174 +-
 alternates/gambling/hosts                          | 80216 +++++++++---------
 alternates/gambling/readme.md                      |   170 +-
 alternates/porn-social/hosts                       | 80240 +++++++++---------
 alternates/porn-social/readme.md                   |   180 +-
 alternates/porn/hosts                              | 80240 +++++++++---------
 alternates/porn/readme.md                          |   176 +-
 alternates/social/hosts                            | 80216 +++++++++---------
 alternates/social/readme.md                        |   172 +-
 data/Badd-Boyz-Hosts/hosts                         |     2 +-
 data/KADhosts/hosts                                |     6 +-
 data/adaway.org/hosts                              |     4 +-
 data/hostsVN/hosts                                 |     2 +-
 data/someonewhocares.org/hosts                     |     5 +-
 data/yoyo.org/hosts                                |     2 +-
 hosts                                              | 80216 +++++++++---------
 readme.md                                          |   168 +-
 readmeData.json                                    |     2 +-
 39 files changed, 643446 insertions(+), 643057 deletions(-)

The changes are not in the line endings, they are in the way the entries are sorted, which I can see in the Readme too:
Host file source | Description | Home page | Raw hosts | Update frequency | License | Issues
-----------------|-------------|:---------:|:---------:|:----------------:|:-------:|:------:
Steven Black's ad-hoc list | Additional sketch domains as I come across them. |[link](https://github.com/StevenBlack/hosts/blob/master/data/StevenBlack/hosts) | [raw](https://raw.githubusercontent.com/StevenBlack/hosts/master/data/StevenBlack/hosts) | occasionally | MIT  | [issues](https://github.com/StevenBlack/hosts/issues)
Malware Domain List | Malware Domain List is a non-commercial community project. |[link](https://www.malwaredomainlist.com/) | [raw](https://www.malwaredomainlist.com/hostslist/hosts.txt) | weekly | 'can be used for free by anyone'  | [issues](https://www.malwaredomainlist.com/contact.php)
add.Dead | Dead sites based on [hostsfile.org](http://www.hostsfile.org/hosts.html) content. |[link](https://github.com/FadeMind/hosts.extras) | [raw](https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.Dead/hosts) | occasionally | GPLv3+  | [issues](https://github.com/FadeMind/hosts.extras/issues)
hostsVN | Hosts block ads of Vietnamese |[link](https://github.com/bigdargon/hostsVN) | [raw](https://raw.githubusercontent.com/bigdargon/hostsVN/master/option/hosts-VN) | occasionally | MIT  | [issues](https://github.com/bigdargon/hostsVN/issues)
add.Spam | Spam sites based on [hostsfile.org](http://www.hostsfile.org/hosts.html) content. |[link](https://github.com/FadeMind/hosts.extras) | [raw](https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.Spam/hosts) | occasionally | GPLv3+  | [issues](https://github.com/FadeMind/hosts.extras/issues)
Dan Pollock – [someonewhocares](https://someonewhocares.org) | How to make the internet not suck (as much). |[link](https://someonewhocares.org/hosts/) | [raw](https://someonewhocares.org/hosts/zero/hosts) | frequently | non-commercial with attribution  |<EMAIL_ADDRESS>
MVPS hosts file | The purpose of this site is to provide the user with a high quality custom HOSTS file. |[link](http://winhelp2002.mvps.org/) | [raw](http://winhelp2002.mvps.org/hosts.txt) | monthly | CC BY-NC-SA 4.0  |<EMAIL_ADDRESS>
yoyo.org | Blocking with ad server and tracking server hostnames. |[link](https://pgl.yoyo.org/adservers/) | [raw](https://pgl.yoyo.org/adservers/serverlist.php?hostformat=hosts&mimetype=plaintext&useip=<IP_ADDRESS>) | frequently |   |<EMAIL_ADDRESS>
Mitchell Krog's - Badd Boyz Hosts | Sketchy domains and Bad Referrers from my Nginx and Apache Bad Bot and Spam Referrer Blockers |[link](https://github.com/mitchellkrogza/Badd-Boyz-Hosts) | [raw](https://raw.githubusercontent.com/mitchellkrogza/Badd-Boyz-Hosts/master/hosts) | weekly | MIT  | [issues](https://github.com/mitchellkrogza/Badd-Boyz-Hosts/issues)
UncheckyAds | Windows installers ads sources sites based on https://unchecky.com/ content. |[link](https://github.com/FadeMind/hosts.extras) | [raw](https://raw.githubusercontent.com/FadeMind/hosts.extras/master/UncheckyAds/hosts) | occasionally |   | [issues](https://github.com/FadeMind/hosts.extras/issues)
add.2o7Net | 2o7Net tracking sites based on [hostsfile.org](http://www.hostsfile.org/hosts.html) content. |[link](https://github.com/FadeMind/hosts.extras) | [raw](https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.2o7Net/hosts) | occasionally | GPLv3+  | [issues](https://github.com/FadeMind/hosts.extras/issues)
KADhosts | Fraud/adware/scam websites. |[link](https://kadantiscam.netlify.com) | [raw](https://raw.githubusercontent.com/PolishFiltersTeam/KADhosts/master/KADhosts_without_controversies.txt) | frequently | CC BY-SA 4.0  | [issues](https://github.com/PolishFiltersTeam/KADhosts/issues)
AdAway | AdAway is an open source ad blocker for Android using the hosts file. |[link](https://adaway.org/) | [raw](https://raw.githubusercontent.com/AdAway/adaway.github.io/master/hosts.txt) | occasionally | CC BY 3.0  | [issues](https://github.com/AdAway/AdAway/issues)
add.Risk | Risk content sites based on [hostsfile.org](http://www.hostsfile.org/hosts.html) content. |[link](https://github.com/FadeMind/hosts.extras) | [raw](https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.Risk/hosts) | occasionally | GPLv3+  | [issues](https://github.com/FadeMind/hosts.extras/issues)
Tiuxo hostlist - ads | Categorized hosts files for DNS based content blocking |[link](https://github.com/tiuxo/hosts) | [raw](https://raw.githubusercontent.com/tiuxo/hosts/master/ads) | occasional | CC BY 4.0  | [issues](https://github.com/tiuxo/hosts/issues)

becomes:
Host file source | Description | Home page | Raw hosts | Update frequency | License | Issues
-----------------|-------------|:---------:|:---------:|:----------------:|:-------:|:------:
AdAway | AdAway is an open source ad blocker for Android using the hosts file. |[link](https://adaway.org/) | [raw](https://raw.githubusercontent.com/AdAway/adaway.github.io/master/hosts.txt) | occasionally | CC BY 3.0 | [issues](https://github.com/AdAway/AdAway/issues)
add.2o7Net | 2o7Net tracking sites based on [hostsfile.org](http://www.hostsfile.org/hosts.html) content. |[link](https://github.com/FadeMind/hosts.extras) | [raw](https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.2o7Net/hosts) | occasionally | GPLv3+ | [issues](https://github.com/FadeMind/hosts.extras/issues)
add.Dead | Dead sites based on [hostsfile.org](http://www.hostsfile.org/hosts.html) content. |[link](https://github.com/FadeMind/hosts.extras) | [raw](https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.Dead/hosts) | occasionally | GPLv3+ | [issues](https://github.com/FadeMind/hosts.extras/issues)
add.Risk | Risk content sites based on [hostsfile.org](http://www.hostsfile.org/hosts.html) content. |[link](https://github.com/FadeMind/hosts.extras) | [raw](https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.Risk/hosts) | occasionally | GPLv3+ | [issues](https://github.com/FadeMind/hosts.extras/issues)
add.Spam | Spam sites based on [hostsfile.org](http://www.hostsfile.org/hosts.html) content. |[link](https://github.com/FadeMind/hosts.extras) | [raw](https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.Spam/hosts) | occasionally | GPLv3+ | [issues](https://github.com/FadeMind/hosts.extras/issues)
Mitchell Krog's - Badd Boyz Hosts | Sketchy domains and Bad Referrers from my Nginx and Apache Bad Bot and Spam Referrer Blockers |[link](https://github.com/mitchellkrogza/Badd-Boyz-Hosts) | [raw](https://raw.githubusercontent.com/mitchellkrogza/Badd-Boyz-Hosts/master/hosts) | weekly | MIT | [issues](https://github.com/mitchellkrogza/Badd-Boyz-Hosts/issues)
hostsVN | Hosts block ads of Vietnamese |[link](https://github.com/bigdargon/hostsVN) | [raw](https://raw.githubusercontent.com/bigdargon/hostsVN/master/option/hosts-VN) | occasionally | MIT | [issues](https://github.com/bigdargon/hostsVN/issues)
KADhosts | Fraud/adware/scam websites. |[link](https://kadantiscam.netlify.com) | [raw](https://raw.githubusercontent.com/PolishFiltersTeam/KADhosts/master/KADhosts_without_controversies.txt) | frequently | CC BY-SA 4.0 | [issues](https://github.com/PolishFiltersTeam/KADhosts/issues)
Malware Domain List | Malware Domain List is a non-commercial community project. |[link](https://www.malwaredomainlist.com/) | [raw](https://www.malwaredomainlist.com/hostslist/hosts.txt) | weekly | 'can be used for free by anyone' | [issues](https://www.malwaredomainlist.com/contact.php)
MVPS hosts file | The purpose of this site is to provide the user with a high quality custom HOSTS file. |[link](https://winhelp2002.mvps.org/) | [raw](https://winhelp2002.mvps.org/hosts.txt) | monthly | CC BY-NC-SA 4.0 |<EMAIL_ADDRESS>Dan Pollock – [someonewhocares](https://someonewhocares.org) | How to make the internet not suck (as much). |[link](https://someonewhocares.org/hosts/) | [raw](https://someonewhocares.org/hosts/zero/hosts) | frequently | non-commercial with attribution |<EMAIL_ADDRESS>Steven Black's ad-hoc list | Additional sketch domains as I come across them. |[link](https://github.com/StevenBlack/hosts/blob/master/data/StevenBlack/hosts) | [raw](https://raw.githubusercontent.com/StevenBlack/hosts/master/data/StevenBlack/hosts) | occasionally | MIT | [issues](https://github.com/StevenBlack/hosts/issues)
Tiuxo hostlist - ads | Categorized hosts files for DNS based content blocking |[link](https://github.com/tiuxo/hosts) | [raw](https://raw.githubusercontent.com/tiuxo/hosts/master/ads) | occasional | CC BY 4.0 | [issues](https://github.com/tiuxo/hosts/issues)
UncheckyAds | Windows installers ads sources sites based on https://unchecky.com/ content. |[link](https://github.com/FadeMind/hosts.extras) | [raw](https://raw.githubusercontent.com/FadeMind/hosts.extras/master/UncheckyAds/hosts) | occasionally |  | [issues](https://github.com/FadeMind/hosts.extras/issues)
yoyo.org | Blocking with ad server and tracking server hostnames. |[link](https://pgl.yoyo.org/adservers/) | [raw](https://pgl.yoyo.org/adservers/serverlist.php?hostformat=hosts&mimetype=plaintext&useip=<IP_ADDRESS>) | frequently |  |<EMAIL_ADDRESS>

@XhmikosR please explain the problem here.  I don'y understand.  That diff is perfectly normal.  What do you expect?  All hosts files, all readme files, get re-generated.  This is 100% by design.

The order of sources listed is not determinate; it never was.    I certainly don't.   readmeData.json is just a JSON structure and everything comes from that.

When you push a patch which updates the data, not every line changes. On Windows all lines change, but not because of line endings, but because of the order the folders are traversed and thus the data are processed/output. You can  see this in the Readme part I pasted above.
I'm not saying it matters, it just doesn't make any sense, though.

@funilrys it seems the README Unicode issue is back 🙁
For example:
-**Windows XP**: Start → Run → `cmd`
+**Windows XP**: Start â†’ Run â†’ `cmd`

or
-* [ViHoMa](https://github.com/cmabad/ViHoMa) is a Visual Hosts file Manager, written in Java, by Christian Martínez.  Check it out!
+* [ViHoMa](https://github.com/cmabad/ViHoMa) is a Visual Hosts file Manager, written in Java, by Christian MartÃnez.  Check it out!

-* [Blocking ads and malwares with unbound](https://deadc0de.re/articles/unbound-blocking-ads.html "Blocking ads and malwares with unbound") – [Unbound](https://www.unbound.net/ "Unbound is a validating, recursive, and caching DNS resolver.") is a validating, recursive, and caching DNS resolver.
+* [Blocking ads and malwares with unbound](https://deadc0de.re/articles/unbound-blocking-ads.html "Blocking ads and malwares with unbound") â€“ [Unbound](https://www.unbound.net/ "Unbound is a validating, recursive, and caching DNS resolver.") is a validating, recursive, and caching DNS resolver.

Honesty, Windows is such a shitshow.  I know this doesn't help this issue; sometimes I just need to vent. @XhmikosR @funilrys

There's only one last issue on Windows after #1296 is merged.
readmeData.json still contains 2 backslashes at the end of the location strings, for example:
{
  "fakenews-gambling-porn": {
    "location": "alternates/fakenews-gambling-porn\\",
  }
}

I tried to fix it without success so far. Maybe @funilrys you have some idea.
That being said, finally everything is the same on Windows after #1296. 🙂


Config types test

Purpose
Add a test to make sure config type declarations are compatible with config/environment.js
Summary of Changes

Added a node-test to keep config types synced

Added it to lint-staged and travis

Tweaked config types to match config/environment.js

Side Effects / Testing Notes
n/a
Ticket
n/a
Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
[ ] testable and includes test(s)
[ ] changes described in CHANGELOG.md

Coverage remained the same at 47.817% when pulling d67896f4fbfbe1983165e4aa4a398bd64755db39 on jamescdavis:config_types_test into 0b3638d912531c57ad502e90c9aa01d322b3c344 on CenterForOpenScience:develop.


remove unuseful callback

Thanks you for the simple and good example, here's my contribution. There's no point to call member functions with callback.

You are right :-) I do not remember why I wrote it like that.


deprecate [com.google.fonts/check/repo/vf_has_static_fonts]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
The only case where we need the static folder is when teh statics are manually hinted, which almost never occurs. Maybe the check could instead warn to remove the fonts in the static folder if they are not manually hinted.
cc @m4rc1e @vv-monsalve @yanone thumbs up if you agree.

Maybe the check could instead warn to remove the fonts in the static folder if they are not manually hinted.

Agree. We haven't used/required this dir in a while.


add contact section

Ah, ok, it is only possible to commit suggestions if you are have write permissions to the fork. I thought it's a bit smarter than that

@Arriven I updated the contact section, the data was taken from the channel info

There were conflicts due to #128 so I applied the patch manually


add Ueli.app

Ueli.app is a helpful replacement for Spotlight (and an alternative to Alfred).
Project URL
https://ueli.app/
Category
productivity
Description
Ueli.app is a helpful replacement for Spotlight (and an alternative to Alfred).
Why it should be included to Awesome macOS open source applications  (optional)
I use it everyday and it boosts my productivity a lot.
Checklist

[x] Edit applications.json instead of README.md.
[x] Only one project/change is in this pull request
[x] Screenshots(s) added if any
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

@maehr Thank you! 🚀


Create moonshines.yml

Hello,
Adding a small french dataset based on only one hand!
I have 2 questions:

since it's a private project, do you think it is ok to save save the catalog file under {username}/{dataset_name}.yml or should we do {dataset_name}/{dataset_name}.yml? The first option allows someone to potentially add more datasets created after a personal initiative.

I copied the content of htr-united.yml from the repo, which also contains the list of characters, etc. Is it ok? Or should we stick to what the online form in able to generate?

since it's a private project, do you think it is ok to save save the catalog file under {username}/{dataset_name}.yml or should we do {dataset_name}/{dataset_name}.yml? The first option allows someone to potentially add more datasets created after a personal initiative.

username/dataset.yml seems good to me

* I copied the content of `htr-united.yml` from the repo, which also contains the list of characters, etc. Is it ok? Or should we stick to what the online form in able to generate?

It's totally ok.


Add wrapper class for JWT plugin

Implementation for https://github.com/therealgambo/kong-php/issues/1

Do you know when you will go to tag the master branch?
Thanks

Done. https://github.com/therealgambo/kong-php/releases/tag/v0.10.3


Morgue glass airlock doesnt exits

but should

As morgue access no longer exists and morgue doors use the default medical skin, there is no need for a specific glass airlock for morgues. I recommend using a Glass Airlock [Medical, Locked] for the same effect.

As morgue access no longer exists

there was no morgue access, this door has medical, chaplain and detective accesses, so it just should be good to have glass variant


Official Ably Client Broadcaster Doc

Updated broadcaster.md as per latest ably client
Marked old AblyBroadcaster section as Deprecated

Thanks for approval, merging the PR since all comments are addressed!


fix: withdrawal (asset unlock) txes to use Platform Quorum on RegTest

Issue being fixed or feature implemented
Asset Unlock tx uses platform's quorum on devnets, testnet, mainnet, but still quorum type "Test (100)" on Reg Tests
That's part II PR, prior work is here: https://github.com/dashpay/dash/pull/5618
What was done?

Removed consensus.llmqTypeAssetLocks which has been kept only for RegTest - use consensus.llmqTypePlatform instead.
Functional test feature_asset_locks.py uses llmq_type_test = 106 instead llmq_type_test = 100 for asset unlock tx
there's 4 MNs + 3 evo nodes instead 3 MNs as before: evo nodes requires to have IS to be active

How Has This Been Tested?
Run unit/functional tests
Breaking Changes
Asset Unlock tx uses correct quorum "106 llmq_test_platform" on reg test instead "100 llmq_test"
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone

Guix Automation has began to build this PR tagged as v20.1.0-devpr5800.d6909f8f. A new comment will be made when the image is pushed.

guix flag to get a docker image

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v20.1.0-devpr5800.d6909f8f. The image should be on dockerhub soon.

this is more of a refactor than a fix imo;

All changes here are necessary here to change quorum.
Changing quorum from trst to platform requires Evo nodes.
Evo nodes requires enabling instant sent to create them.
Instant send requires 4 rotation quorum (see TODO).
That's almost minimal fix when commits are squashed, so, that's a fix, not a refactoring.


When filtering on "unlocked", a locked record still appears.

Bug description
When filtering on "unlocked", a locked record still appears.
There was one case that got solved by switching it to unlocked and locked again – that one does not appear in the list any longer. Not sure if this is something that will happen regularly or is a one off.
This record was recently edited, so it would be a recent hiccup.
Steps to Reproduce

Go to https://backoffice.biblio.ugent.be/publication?q=&f[locked]=false&f[status]=public&f[classification]=A1&f[classification]=A2&f[classification]=A3&f[classification]=A4&f[classification]=B1&f[classification]=B2&f[classification]=B3&f[classification]=C1&f[classification]=C3&f[classification]=D1&f[classification]=P1&f[classification]=V
(unlocked, public, all types selected but "U").
See locked record

Automatic testing scenario
Feedback from filters?
Risk classification
Likelihood
Unsure
Consequences
Unsure

a former reindexation stopped to early?

ok again after reindexing, closing for now

I can still see new cases appear, this time:

Maybe related: when I copy the URL of this record, it looks like this
https://backoffice.biblio.ugent.be/publication/01H4JE867G1TQMA7A58SC4N4Y3?redirect-url=%2Fpublication%3Fq%3D%26f%255Blocked%255D%3Dfalse%26f%255Bstatus%255D%3Dpublic%26f%255Bclassification%255D%3DA1%26f%255Bclassification%255D%3DA2%26f%255Bclassification%255D%3DA3%26f%255Bclassification%255D%3DA4%26f%255Bclassification%255D%3DB1%26f%255Bclassification%255D%3DB2%26f%255Bclassification%255D%3DB3%26f%255Bclassification%255D%3DC1%26f%255Bclassification%255D%3DC3%26f%255Bclassification%255D%3DD1%26f%255Bclassification%255D%3DP1%26f%255Bclassification%255D%3DV

@mietcls is this still a problem? I cannot replicate this.

Yes, found a whole bunch on page 2 (13) and on page 8 (1)
Page 2::

Page 8:

If you edit them the problem will probably disappear again.
It seems to be a problem for more recent publications  (I started testing on the last page and clicked until I found some, so this was quite painful :p please test beyond page 1 🙏)

Check ES6 instances: biblio-backoffice is using only one node. So that cannot be the problem:
BIBLIO_BACKOFFICE_ES6_URL=http://jensen.ugent.be:9200

Number of non-deleted publications that are not locked in the database:
biblio_backoffice_prod=> select count(*) from publications where date_until is null and not (data->>'locked')::boolean and data->>'status' <> 'deleted';
 count
-------
 10482
(1 row)

Number of non-deleted publications that are not locked in ES: 10496

Why would you close it if you cannot reproduce it? The problem still persists.

Picking this up after DICT transfer, following up

Investigating this record: 01HRVFJ8XM45WR1M7R0QZAXGPN
On the search overview page with filter "status": "withdrawn": the publication is shown with status "public"
https://backoffice.bibliodev.ugent.be/publication?q=&f[status]=returned
On the detail page: the publication is shown with status "public"
https://backoffice.bibliodev.ugent.be/publication/01HRVFJ8XM45WR1M7R0QZAXGPN
In the PostgreSQL database, I find 6 snapshots.  These are the last 2 snapshots:

snapshot_id
id
date_from
date_until
publication status

01HRVFJDM33QCAA2KYVSEXBGR4
01HRVFJ8XM45WR1M7R0QZAXGPN
2024-03-13 09:41:25.891174+01
2024-03-13 09:41:26.603889+01
returned

01HRVFJEACCZEJ7S27Q23FKD1V
01HRVFJ8XM45WR1M7R0QZAXGPN
2024-03-13 09:41:26.603889+01
NULL
public

In the elastic search index biblio_backoffice_dev_publication, I find a document for ID: 01HRVFJ8XM45WR1M7R0QZAXGPN which has these properties:
{
  "date_created": "2024-03-13T08:41:21.076Z",
  "date_updated": "2024-03-13T08:41:25.89Z",
  "legacy": false,
  "locked": false,
  "extern": false,
  "status": "returned",
  "publication_status": "missing"
}

So, the record is included in the search results because the status in the index is set to returned (withdrawn).  However, the status in the PostgreSQL database for the latest snapshot is set to public.  The field data displayed in the summaries of each result doesn't come from the search index: it comes from the database.
Why is there a mismatch between the search index and postgreSQL?
Take a look at the timestamps between those two snapshots: about 0.71 seconds. So, within less then one second, the status of the publication was changed twice.  This publication was created by automated Cypress testing, hence the rapid sequence of status updates.
My guess is a concurrency issue either at the level of elastic or at the level of backoffice. I'll do a few tests to see if I can replicate this.

Edit: I understand it's the same issue probably. How do we deal with this mismatch in database and index?

these issues can only have 2 causes:

indexing failed
timing issue (older version wins)

both can be addressed, but will take some effort, especially with the current architecture:

a combination of more robust incremental indexing (persistent queue, retries etc) + periodic full reindex to fix the cases that remain

use Elasticsearch versioning (https://www.elastic.co/guide/en/elasticsearch/reference/6.8/docs-index_.html). This requires that we include an integer version number in each index doc.

@mietcls issue is probably to big to fix if we want a June release
we can mitigate the issue in the meanwhile by doing a daily index switch for example

as an example, minibiblio handles search doc versioning correctly: https://github.com/ugent-library/minibiblio/blob/4397c1685f3a243c77700435159e6397d37ca05e/opensearchindex/index.go#L99


Flow EVM versus Ethereum

closes #821

@franklywatson any topic/question that you have recently heard that I might be missing in this doc?

@Aliserag ready for another round of review.


Allow for installing of whatever the latest version of neo4j is in rake neo4j:install

Should be able to use GitHub API:
https://github.com/neo4j/neo4j/releases

Also maybe when running rake tasks we can notify somebody if there's a point release?  If so, we should probably look into https://github.com/neo4jrb/neo4j/issues/823 at the same time to make sure it's easy to run a command to update the version of Neo4j without wiping the data

Suggestion from @jexp:
curl https://api.github.com/repos/neo4j/neo4j/releases/latest

See https://github.com/neo4jrb/neo4j-core/commit/b4014edc23226ec511aacd1b6de4b7d05952c82a


some recent enhancements

Pull Request Description
Describe what this PR does / why we need it

enhance error logging
save recognized subnet set
filter ipinstances by recognized subnet set

Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

Codecov Report

Merging #175 (a588d3d) into main (aa97675) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #175   +/-   ##
=======================================
  Coverage   31.54%   31.54%
=======================================
  Files          22       22
  Lines        1452     1452
=======================================
  Hits          458      458
  Misses        942      942
  Partials       52       52

Flag
Coverage Δ

unittests
31.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa97675...a588d3d. Read the comment docs.


⚠ Bofrost.be has degraded performance

In f46a1ce, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2960 ms

Resolved: Bofrost.be performance has improved in 02ed6ed.


Tolgee question: What's the context of this?

I'm unsure my translation is correct

Yes, it is correct.
Btw, i'm working on adding screenshots on difficult keys


Regex not matching route when querystring is present

For example, the url is http://something.com/mypage/?q=blah
Navigo.FOLLOWED_BY_SLASH_REGEXP = '(?:\/$|$)';
is not able to match 'mypage' as my route.
My question is, is there any consequences if I change the _cLoc from
return clean(window.location.href);
to
return clean(window.location.pathname);
So far I haven't encountered any problems with it.  Or can anyone provide a regex that can match url with querystring?  I was having a hard time coming up with one.

@janetha what are your route definitions?

I chose not to to use hash
router = new Navigo(null, false);
    router.on({
        'zipcode': function () {
            $('button').click(function(){
                 var z = $('input').val();
                 router.navigate('/nextpage/?zipcode=' + z);
            });
        },
        'nextpage': function () {
            //get zipcode in url and do something
        },

The regex '(?:/$|$)' won't match the entire url http://something.com/nextpage?zipcode=10001 but would match if there is no querystring http://something.com/nextpage/

Never mind. I understand now that for my scenario, I should really use hash. Thanks for this great library.


Create interface(s) for evaluation of expressions

Create and design interface for evaluation of expressions according concept.

Resolved.


Bump node version used on QA/Dev

This is necessary because the 0.10.26-1nodesource1~trusty1 package is no longer available.

I think we might want to switch to the latest version. This shouldn't force us to update the version manually every time.

Back to @bp323

"I think we might want to switch to the latest version. This shouldn't force us to update the version manually every time." - if you can find a way to do this which ensures we get the latest *nodesource1~trusty1 versions then go for it.


Should fix missing tags

Fixes #25

@cascadianblue $TAGS here is used differently than in other NLP Sandbox repositories you may have seen. This change has been introduced in the NLP Sandbox Spark repository to support the build of multiple images.


Get release notes into the subtree repos

Presently the release notes are generated from git history, but it leverages the @nodenv/devutil package. However, the subtrees do not have a package.json nor do they have deps. So this doesn't work.

fixed by d4a3b25f42b4a95a57285426ee175533ef36b217


478: Added colors and clickability to filter string

Closes #478: Feature Add colors to the search string and make it clickable

@danielhers I'll make all necessary changes tonight and update the branch. I need to make a habit on cross-browser testing, because on my chrome (macbook pro 13 inch screen) it look fine for all filterations.

You could try https://www.browserling.com/ :)
On Thu, Nov 5, 2015 at 10:01 AM Liron Shalev<EMAIL_ADDRESS>wrote:

@danielhers https://github.com/danielhers I'll make all necessary
changes tonight and update the branch. I need to make a habit on
cross-browser testing, because on my chrome (macbook pro 13 inch screen) it
look fine for all filterations.
[image: screen shot 2015-11-05 at 9 59 46 am]
https://cloud.githubusercontent.com/assets/12143791/10962874/36915ab0-83a4-11e5-9ba7-fc452b0b28db.png
—
Reply to this email directly or view it on GitHub
https://github.com/hasadna/anyway/pull/479#issuecomment-153982234.

@danielhers it's ready for final code review :)


Implementation of ST2094

Need to pay.
https://ieeexplore.ieee.org/document/7513370
https://ieeexplore.ieee.org/document/9095450
A free PPT.
https://forum.selur.net/attachment.php?aid=611

Reopen when I know the details.

Move to https://github.com/natural-harmonia-gropius/hdr-toys/issues/7


Link test with -lm to fix build problem with ld --no-add-needed

0001-Fix-build-failure-with-DSO-link-changes.patch from Debian, see
http://bugs.debian.org/604797 .

This seems harmless enough, but can you please give steps to reproduce? -lm should have already been added to VORBIS_LIBS by configure.
E.g. on my system (Debian bullseye):
$ make -f test/Makefile V=1 test
[...]
libtool: link: gcc -O3 -Wall -Wextra -ffast-math -D_REENTRANT -fsigned-char -Wdeclaration-after-statement -DUSE_MEMORY_H -o .libs/test util.o write_read.o test.o  ../lib/.libs/libvorbisenc.so ../lib/.libs/libvorbis.so -logg -lm
``
Note the `-lm` at the end of the link line without this patch.

Thanks to pere's help, I tested removing this patch on a Debian bullseye (testing) system and didn't see any build errors. I suggest debian try removing it from their stack.
$ apt-get install devscripts
$ apt-get source libvorbis
$ cd libvorbis-1.3.6
$ quilt pop -a
<Edit debian/patches/series to remove this change>
$ quilt push -a
$ debuild

or
$ apt-get install git-buildpackage
$ git clone https://salsa.debian.org/multimedia-team/libvorbis
$ cd libvorbis
<edit debian/patches/series to remove this change>
$ git commit -a -m "Remove patch for testing"
$ gbp buildpackage

Both successfully run tests before failing for lack of a signing key. Old-style fakeroot debian/rules binary succeeds in making packages.

[Ralph Giles]

Thanks to pere's help, I tested removing this patch on a Debian
bullseye (testing) system and didn't see any build errors. I suggest
debian try removing it from their stack.

I tested to build using 'LDFLAGS=-Wl,--no-copy-dt-needed-entries
debuild' (the --no-add-needed options was renamed), and I suspect you
are right, this patch is no longer needed.
--
Happy hacking
Petter Reinholdtsen

Ok, thanks for confirming!


Styling issues with character count / textareas

Issues:

When a user goes over the limit, the border does not turn red as it's meant to (it does if you blur the field though).
The border width is inconsistent if the field is scrollable.

Note, when we did the original research on the character count component, we found that users didn't always see the message change. In addition to the message updating and changing colour, we also turned the border red. This is different than other design system things that lose the red border when focused (I think that change happened later).
Screenshot from the original character count (note the highlighting was later dropped as a feature):

Inconsistent border:

Also, if submitting a form with a character count field, but invalid/no value, the field is shown with a black border, not a red one as with other text fields.

@edwardhorsford thanks for raising. Would you mind splitting the 'inconsistent border' out into a separate issue, and updating this to cover just the missing red border on the character count? They're unrelated, so I think we'd prioritise them separately.
If you prefer I can do it on your behalf.

Also, if submitting a form with a character count field, but invalid/no value, the field is shown with a black border, not a red one as with other text fields.

@paulrobertlloyd this has been raised before and we think this behaviour makes more sense than the other options – see @timpaul's reply here:
https://github.com/alphagov/govuk-frontend/issues/1858#issuecomment-661070056

I thought this might have been affected by the changes in 3.8.0, but actually this has been the case since v3.0.0.
The changes in v3.8.0 might actually make this fixable, as we can rely on the border getting thicker when focused but consistently tie the colour to the 'error state'? That would only work as long as there's a 3:1 contrast between the red and the black, unless we consider the colour change an enhancement.

@36degrees Ah, thanks for the pointer. Kind of makes sense, I guess (hard to balance the competing validations at play in this case).

@edwardhorsford thanks for raising. Would you mind splitting the 'inconsistent border' out into a separate issue, and updating this to cover just the missing red border on the character count? They're unrelated, so I think we'd prioritise them separately.

Done


util: Account for hash collisions in ObjectSharedPool

Fixes #24617
Commit Message:
Additional Description:
Risk Level: Low
Testing: TODO
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

/assign @jmarantz @zyfjeff

/wait

@yanjunxiang-google


[WIP] Improve unsaved changes modals

closes https://github.com/TryGhost/Ghost/issues/9514

simplify wording and buttons for "unsaved changes" dialog when leaving the editor
trigger save when closing post settings menu (allows saving of tags)
standardise saving behaviour in the PSM

new/draft post = save every change automatically
published/scheduled post = explicit saves only (Cmd-S, publish menu, or unsaved changes dialog)

increase and standardise modal footer spacing

TODO:

[x] fix PSM closing when making changes on a new post
[ ] standardise slug update/saving behaviour
[ ] clean up usage of scratch values

many don't currently make sense because the actual model value is being changed in the PSM then set again to the scratch value when saving

[ ] replace "unsaved changes" modal for settings screens with the newly updated modal
[ ] tests

Closing this to be picked up again later.


[ISSUE #160]Fix compile error

Close #160

Codecov Report

Merging #162 (24034d7) into develop (eccebec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #162   +/-   ##
========================================
  Coverage    40.08%   40.08%
========================================
  Files          122      122
  Lines         5319     5319
  Branches       767      767
========================================
  Hits          2132     2132
  Misses        2824     2824
  Partials       363      363

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


sync code from release-2.7.0 into master

Codecov Report

Merging #201 (eb8252b) into master (5a5afc4) will increase coverage by 0.43%.
The diff coverage is 37.20%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a5afc4...eb8252b. Read the comment docs.