Support for gofiber.

Is there a working example for using this library with gofiber?
I tried this:
import (
	"github.com/gofiber/adaptor/v2"
	"github.com/zishang520/socket.io/socket"
)

// ...
io := socket.NewServer(nil, nil)
App.Use("/socket.io", adaptor.HTTPHandler(io.ServeHandler(nil)))

and socket.io can not connect to the websocket. (it resorts to using polling)

I have received your question and will give you a relevant answer after follow-up research.

Thanks for your patience, as Fiber is built on top of Fasthttp, Fiber is not compatible with net/http interface, please look forward to follow-up support.

alright, thanks

@zishang520 any status on this?

@zishang520 any status on this?

At present, the work based on fasthttp is basically completed, and it is still being debugged. There are still some other work in progress: redis-based adapter.

sounds good!

any status on this?

It may take some time. I am updating engine.io to 6.5.3 and some work has not been completed yet.

another status?

another status?

I'm really sorry. The project is progressing slowly. I've been experiencing some financial stress recently. I have been without income for more than half a year, and my baby is about to be born. For me, it's double pressure. But don't be discouraged, I will continue to complete the development when I have enough time and financial resources. Thank you all for your anticipation and understanding. Finally say sorry again.

That's perfectly fine, take any time you need to sort yourself out. Life comes first.

is there a way we can support this implementation? gofiber is quite popular that it won't be supported

Sorry, due to technical issues, I cannot solve this problem: https://github.com/valyala/fasthttp/issues/965. Currently, this requirement will be updated after fasthttp has a next step plan.
Currently, the submitted engine.io-server-go-fasthttp project and socket.io-server-go-fasthttp project cannot be used normally

New progress: Currently it can only be implemented based on the Websocket transport interface, and the Polling transport interface will be abandoned.

Fasthttp has been updated not long ago (https://github.com/valyala/fasthttp/pull/1525/commits/9c12719b5fe70391ac9babc759478786ab96dff3), and it was found to work properly in the test case:
package main

import (
	"os"
	"os/signal"
	"syscall"
	"time"

	"github.com/gofiber/fiber/v2"
	"github.com/gofiber/fiber/v2/middleware/adaptor"
	"github.com/zishang520/engine.io/v2/log"
	"github.com/zishang520/engine.io/v2/types"
	"github.com/zishang520/socket.io/v2/socket"
)

func main() {
	log.DEBUG = true
	c := socket.DefaultServerOptions()
	c.SetServeClient(true)
	// c.SetConnectionStateRecovery(&socket.ConnectionStateRecovery{})
	// c.SetAllowEIO3(true)
	c.SetPingInterval(300 * time.Millisecond)
	c.SetPingTimeout(200 * time.Millisecond)
	c.SetMaxHttpBufferSize(1000000)
	c.SetConnectTimeout(1000 * time.Millisecond)
	c.SetCors(&types.Cors{
		Origin:      "*",
		Credentials: true,
	})
	socketio := socket.NewServer(nil, nil)
	socketio.On("connection", func(clients ...interface{}) {
		client := clients[0].(*socket.Socket)

		client.On("message", func(args ...interface{}) {
			client.Emit("message-back", args...)
		})
		client.Emit("auth", client.Handshake().Auth)

		client.On("message-with-ack", func(args ...interface{}) {
			ack := args[len(args)-1].(func([]any, error))
			ack(args[:len(args)-1], nil)
		})
	})

	socketio.Of("/custom", nil).On("connection", func(clients ...interface{}) {
		client := clients[0].(*socket.Socket)
		client.Emit("auth", client.Handshake().Auth)
	})

	app := fiber.New()

	// app.Put("/socket.io", adaptor.HTTPHandler(socketio.ServeHandler(c))) // test
	app.Get("/socket.io", adaptor.HTTPHandler(socketio.ServeHandler(c)))
	app.Post("/socket.io", adaptor.HTTPHandler(socketio.ServeHandler(c)))

	go app.Listen(":3000")

	exit := make(chan struct{})
	SignalC := make(chan os.Signal)

	signal.Notify(SignalC, syscall.SIGHUP, syscall.SIGINT, syscall.SIGTERM, syscall.SIGQUIT)
	go func() {
		for s := range SignalC {
			switch s {
			case syscall.SIGHUP, syscall.SIGINT, syscall.SIGTERM, syscall.SIGQUIT:
				close(exit)
				return
			}
		}
	}()

	<-exit
	socketio.Close(nil)
	os.Exit(0)
}


Project drop-down buttons are broken for long titles

This is on both Firefox and Chrome:

This has been fixed.


Implement Suspended condition

In Condition.scala we describe the task life cycle for resident tasks that aren't described by a Mesos TaskState, such as Created or Reserved.
A consequence of this is it becomes difficult to describe termination statuses for resident tasks. Currently, when a resident task dies, we transition the task condition directly from Running to Reserved. This can be confusing because Reserved comes before Running in the normal life-cycle, and leads us to need to interpret Reserved as a terminal status in certain conditions.
Also, when reporting the task status via the API, it could be confusing to pause a task and see the task status go directly to staging. It would be better to show suspended.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-4801. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-4801. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


[SPARK-38175][CORE][SQL][SS][DSTREAM][MESOS][WEBUI] Clean up unused parameters in private methods signature

What changes were proposed in this pull request?
The aim of this pr is clean up unused parameters of private methods
Why are the changes needed?
Cleanup unused symbol.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA

Looks fine. Are there any other such simplifications available here in private methods?

I think there should be other similar cases, let me try to find and fix them

My idea is to add the - wunused: params' option for compilation, then analyze the compilation log to find unused parameters in private methodsin Spark code and fix them, It will take some time to complete the work because the compilation log  also includesunused parameters in non private methods` @srowen @dongjoon-hyun

There are still some cases to be checked

Could you re-trigger GitHub Action?

thanks all ~


Why do I display "Not a valid Win32 application"?

First,I copied the "lvgl" and "lvgl_examples" into "LVGL.Windows/lvgl" and "LVGL.Windows/lvgl_examples" directories.
Then,I used the Visual Studio 2019 and double click the "LVGL.Simulator.sln" to open the VS2019.
Select the x64 and Local Windows Debugger in the top bar.
The compilation seemed to go smoothly.
Finally,the VS2019 shows “"lv_sim_visual_studio-master\Output\Debug\x64\LVGL.Windows.lib" Not a valid Win32 application".

Please set the LVGL.Windows.Desktop project as the startup project.

Thank you very much for your answer!
This is my first time using VS2019 and I was not aware of the existence of "startup option".
I noticed that your README.md already stated it, but I didn't notice it.
I set "LVGL.Windows.Simulator" as "Start the project ".
It worked perfectly.
I'm really sorry for the trouble caused to you. Thank you very much for recovering me and solving my big problem.
Thank you very much!

But I think I will merge the projects in the recent days.

But I think I will merge the projects in the recent days.

I think that's great, because then this problem doesn't arise.

@TaXue-DuBa You can try the latest commit.


Crash when compiling file:///Users/lutang/Developer/flutter/packages/flutter_tools/lib/src/version.dart, at character offset 32933: type 'AmbiguousBuilder' is not a subtype of type 'Expression'

My Flutter totally crashed:
It was all ok yesterday, but this morning I suddenly want to try Flutter web, so I did this following the step in https://flutter.dev/docs/get-started/web:
flutter channel beta
flutter upgrade
flutter config --enable-web
And somehow I got all kinds of error. And now I couldn't run any App, not even starting a new app. I double check, my Flutter, Dart and Android Studio all updated.

It can not recognize any device, so I can not run the code on emulator or physical device, and I got error like this:

Can't load Kernel binary: Invalid kernel binary format version.

Then I googled, and seems people say  to delete bin/cache, and the run flutter doctor,   so I did, but then I got the following error, below are Logs and what I got after running flutter doctor:

Logs

What does this mean? why it crashed and how can I get it running? Well, I don't have to run web or change channel, at least help me get back and being able to run a normal mobile app like I was yesterday. I have been trying and searching for answer and have tries a few hours, nothing works.
And here is what I have after running flutter doctor, it's basically the same error message as above.

% flutter doctor -v
Building flutter tool...
Crash when compiling file:///Users/lutang/Developer/flutter/packages/flutter_tools/lib/src/version.dart,
at character offset 32933:
type 'AmbiguousBuilder' is not a subtype of type 'Expression'
#0      BodyBuilder.doBinaryExpression (package:front_end/src/fasta/kernel/body_builder.dart:1767:46)
#1      BodyBuilder.endBinaryExpression (package:front_end/src/fasta/kernel/body_builder.dart:1718:7)
#2      Parser.parsePrecedenceExpression (package:_fe_analyzer_shared/src/parser/parser_impl.dart:4644:20)
#3      Parser.parseExpression (package:_fe_analyzer_shared/src/parser/parser_impl.dart:4466:13)
#4      Parser.parseSingleLiteralString (package:_fe_analyzer_shared/src/parser/parser_impl.dart:5522:17)
#5      Parser.parseLiteralString (package:_fe_analyzer_shared/src/parser/parser_impl.dart:5467:13)
#6      Parser.parsePrimary (package:_fe_analyzer_shared/src/parser/parser_impl.dart:4892:14)
#7      Parser.parseUnaryExpression (package:_fe_analyzer_shared/src/parser/parser_impl.dart:4793:12)
#8      Parser.parsePrecedenceExpression (package:_fe_analyzer_shared/src/parser/parser_impl.dart:4525:13)
#9      Parser.parseExpression (package:_fe_analyzer_shared/src/parser/parser_impl.dart:4466:13)
#10     Parser.parseReturnStatement (package:_fe_analyzer_shared/src/parser/parser_impl.dart:4373:13)
#11     Parser.parseStatementX (package:_fe_analyzer_shared/src/parser/parser_impl.dart:4240:14)
#12     Parser.parseStatement (package:_fe_analyzer_shared/src/parser/parser_impl.dart:4217:20)
#13     Parser.parseBlock (package:_fe_analyzer_shared/src/parser/parser_impl.dart:6380:15)
#14     Parser.parseStatementX (package:_fe_analyzer_shared/src/parser/parser_impl.dart:4238:14)
#15     Parser.parseStatement (package:_fe_analyzer_shared/src/parser/parser_impl.dart:4217:20)
#16     Parser.parseIfStatement (package:_fe_analyzer_shared/src/parser/parser_impl.dart:6080:13)
#17     Parser.parseStatementX (package:_fe_analyzer_shared/src/parser/parser_impl.dart:4254:14)
#18     Parser.parseStatement (package:_fe_analyzer_shared/src/parser/parser_impl.dart:4217:20)
#19     Parser.parseFunctionBody (package:_fe_analyzer_shared/src/parser/parser_impl.dart:4122:15)
#20     DietListener.buildFunctionBody (package:front_end/src/fasta/source/diet_listener.dart:990:14)
#21     DietListener._endClassMethod (package:front_end/src/fasta/source/diet_listener.dart:714:5)
#22     DietListener.endClassMethod (package:front_end/src/fasta/source/diet_listener.dart:665:5)
#23     Parser.parseMethod (package:_fe_analyzer_shared/src/parser/parser_impl.dart:3726:20)
#24     Parser.parseClassOrMixinOrExtensionMemberImpl (package:_fe_analyzer_shared/src/parser/parser_impl.dart:3467:15)
#25     Parser.parseClassOrMixinOrExtensionBody (package:_fe_analyzer_shared/src/parser/parser_impl.dart:3141:15)
#26     Parser.parseClass (package:_fe_analyzer_shared/src/parser/parser_impl.dart:1852:13)
#27     Parser.parseClassOrNamedMixinApplication (package:_fe_analyzer_shared/src/parser/parser_impl.dart:1810:14)
#28     Parser.parseTopLevelKeywordDeclaration (package:_fe_analyzer_shared/src/parser/parser_impl.dart:578:14)
#29     Parser.parseTopLevelDeclarationImpl (package:_fe_analyzer_shared/src/parser/parser_impl.dart:474:14)
#30     Parser.parseUnit (package:_fe_analyzer_shared/src/parser/parser_impl.dart:354:15)
#31     SourceLoader.buildBody (package:front_end/src/fasta/source/source_loader.dart:425:14)

#32     Loader.buildBodies (package:front_end/src/fasta/loader.dart:242:15)

#33     KernelTarget.buildComponent. (package:front_end/src/fasta/kernel/kernel_target.dart:358:20)
#34     withCrashReporting (package:front_end/src/fasta/crash.dart:122:24)
#35     KernelTarget.buildComponent (package:front_end/src/fasta/kernel/kernel_target.dart:356:12)
#36     generateKernelInternal. (package:front_end/src/kernel_generator_impl.dart:177:38)

#37     generateKernelInternal. (package:front_end/src/kernel_generator_impl.dart)
#38     withCrashReporting (package:front_end/src/fasta/crash.dart:122:24)
#39     generateKernelInternal (package:front_end/src/kernel_generator_impl.dart:73:10)
#40     generateKernel. (package:front_end/src/kernel_generator_impl.dart:53:18)
#41     CompilerContext.runWithOptions. (package:front_end/src/fasta/compiler_context.dart:135:20)

#42     CompilerContext.runWithOptions. (package:front_end/src/fasta/compiler_context.dart)
#43     CompilerContext.runInContext.. (package:front_end/src/fasta/compiler_context.dart:123:46)
#44     new Future.sync (dart:async/future.dart:223:31)
#45     CompilerContext.runInContext. (package:front_end/src/fasta/compiler_context.dart:123:19)
#46     _rootRun (dart:async/zone.dart:1190:13)
#47     _CustomZone.run (dart:async/zone.dart:1093:19)
#48     _runZoned (dart:async/zone.dart:1630:10)
#49     runZoned (dart:async/zone.dart:1550:10)
#50     CompilerContext.runInContext (package:front_end/src/fasta/compiler_context.dart:122:12)
#51     CompilerContext.runWithOptions (package:front_end/src/fasta/compiler_context.dart:133:10)
#52     generateKernel (package:front_end/src/kernel_generator_impl.dart:52:32)
#53     kernelForModule (package:front_end/src/api_prototype/kernel_generator.dart:99:17)
#54     SingleShotCompilerWrapper.compileInternal (file:///b/s/w/ir/cache/builder/src/third_party/dart/pkg/vm/bin/kernel_service.dart:441:17)
#55     Compiler.compile. (file:///b/s/w/ir/cache/builder/src/third_party/dart/pkg/vm/bin/kernel_service.dart:208:45)
#56     new Future. (dart:async/future.dart:175:37)
#57     _rootRun (dart:async/zone.dart:1182:47)
#58     _CustomZone.run (dart:async/zone.dart:1093:19)
#59     _CustomZone.runGuarded (dart:async/zone.dart:997:7)
#60     _CustomZone.bindCallbackGuarded. (dart:async/zone.dart:1037:23)
#61     _rootRun (dart:async/zone.dart:1190:13)
#62     _CustomZone.run (dart:async/zone.dart:1093:19)
#63     _CustomZone.bindCallback. (dart:async/zone.dart:1021:23)
#64     Timer._createTimer. (dart:async-patch/timer_patch.dart:18:15)
#65     _Timer._runTimers (dart:isolate-patch/timer_impl.dart:397:19)
#66     _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:428:5)
#67     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)
#0      DietListener.buildFunctionBody (package:front_end/src/fasta/source/diet_listener.dart:998:7)
#1      DietListener._endClassMethod (package:front_end/src/fasta/source/diet_listener.dart:714:5)
#2      DietListener.endClassMethod (package:front_end/src/fasta/source/diet_listener.dart:665:5)
#3      Parser.parseMethod (package:_fe_analyzer_shared/src/parser/parser_impl.dart:3726:20)
#4      Parser.parseClassOrMixinOrExtensionMemberImpl (package:_fe_analyzer_shared/src/parser/parser_impl.dart:3467:15)
#5      Parser.parseClassOrMixinOrExtensionBody (package:_fe_analyzer_shared/src/parser/parser_impl.dart:3141:15)
#6      Parser.parseClass (package:_fe_analyzer_shared/src/parser/parser_impl.dart:1852:13)
#7      Parser.parseClassOrNamedMixinApplication (package:_fe_analyzer_shared/src/parser/parser_impl.dart:1810:14)
#8      Parser.parseTopLevelKeywordDeclaration (package:_fe_analyzer_shared/src/parser/parser_impl.dart:578:14)
#9      Parser.parseTopLevelDeclarationImpl (package:_fe_analyzer_shared/src/parser/parser_impl.dart:474:14)
#10     Parser.parseUnit (package:_fe_analyzer_shared/src/parser/parser_impl.dart:354:15)
#11     SourceLoader.buildBody (package:front_end/src/fasta/source/source_loader.dart:425:14)

#12     Loader.buildBodies (package:front_end/src/fasta/loader.dart:242:15)

#13     KernelTarget.buildComponent. (package:front_end/src/fasta/kernel/kernel_target.dart:358:20)
#14     withCrashReporting (package:front_end/src/fasta/crash.dart:122:24)
#15     KernelTarget.buildComponent (package:front_end/src/fasta/kernel/kernel_target.dart:356:12)
#16     generateKernelInternal. (package:front_end/src/kernel_generator_impl.dart:177:38)

#17     generateKernelInternal. (package:front_end/src/kernel_generator_impl.dart)
#18     withCrashReporting (package:front_end/src/fasta/crash.dart:122:24)
#19     generateKernelInternal (package:front_end/src/kernel_generator_impl.dart:73:10)
#20     generateKernel. (package:front_end/src/kernel_generator_impl.dart:53:18)
#21     CompilerContext.runWithOptions. (package:front_end/src/fasta/compiler_context.dart:135:20)

#22     CompilerContext.runWithOptions. (package:front_end/src/fasta/compiler_context.dart)
#23     CompilerContext.runInContext.. (package:front_end/src/fasta/compiler_context.dart:123:46)
#24     new Future.sync (dart:async/future.dart:223:31)
#25     CompilerContext.runInContext. (package:front_end/src/fasta/compiler_context.dart:123:19)
#26     _rootRun (dart:async/zone.dart:1190:13)
#27     _CustomZone.run (dart:async/zone.dart:1093:19)
#28     _runZoned (dart:async/zone.dart:1630:10)
#29     runZoned (dart:async/zone.dart:1550:10)
#30     CompilerContext.runInContext (package:front_end/src/fasta/compiler_context.dart:122:12)
#31     CompilerContext.runWithOptions (package:front_end/src/fasta/compiler_context.dart:133:10)
#32     generateKernel (package:front_end/src/kernel_generator_impl.dart:52:32)
#33     kernelForModule (package:front_end/src/api_prototype/kernel_generator.dart:99:17)
#34     SingleShotCompilerWrapper.compileInternal (file:///b/s/w/ir/cache/builder/src/third_party/dart/pkg/vm/bin/kernel_service.dart:441:17)
#35     Compiler.compile. (file:///b/s/w/ir/cache/builder/src/third_party/dart/pkg/vm/bin/kernel_service.dart:208:45)
#36     new Future. (dart:async/future.dart:175:37)
#37     _rootRun (dart:async/zone.dart:1182:47)
#38     _CustomZone.run (dart:async/zone.dart:1093:19)
#39     _CustomZone.runGuarded (dart:async/zone.dart:997:7)
#40     _CustomZone.bindCallbackGuarded. (dart:async/zone.dart:1037:23)
#41     _rootRun (dart:async/zone.dart:1190:13)
#42     _CustomZone.run (dart:async/zone.dart:1093:19)
#43     _CustomZone.bindCallback. (dart:async/zone.dart:1021:23)
#44     Timer._createTimer. (dart:async-patch/timer_patch.dart:18:15)
#45     _Timer._runTimers (dart:isolate-patch/timer_impl.dart:397:19)
#46     _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:428:5)
#47     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)

update:
I then put back this cache file in Flutter/bin/cache (as I said I deleted this cache file after searching on google for solution, but I got new error as I shown above, so then I put it back, but still I have the following error:
Flutter device daemon #1: process exited during startup. Exit code: 253, stderr: Can't load Kernel binary: Invalid kernel binary format version.
I don't understand this, what happened? Is it because I run Flutter upgrade? so how do I go back or solve the problem, right now when I open any flutter app, I got this error and it can't detect the available device, so I can not run any app, nor can I start any new app.
I am relatively new to software development, just started using Flutter since April this year, so I don't have a lot of experience. Any help is highly appreciate. Thanks for everyone reading this.

/cc @johnniwinther

This might have been fixed recently in https://dart-review.googlesource.com/c/sdk/+/157941.
@lutang123 What version of flutter are you running?

This might have been fixed recently in https://dart-review.googlesource.com/c/sdk/+/157941.
@lutang123 What version of flutter are you running?

Hi, John, thank you for your quick response.
I was running the latest version of Flutter, as I said:
"I did this following the step in https://flutter.dev/docs/get-started/web:
flutter channel beta
flutter upgrade
flutter config --enable-web"
so I upgraded flutter, so the version I was running should be the latest, and I always upgrade whenever possible. But I don't know what's wrong and why it got crashed. I have read the link you forwarded to me before I posted the issue, but honestly I didn't understand and didn't see a clear message on how to fix it.
But anyway, last night I re-do everything from beginning, I installed a new flutter sdk and replaced the current one, updated Andriod Studio and downloaded new Xcode too, and eventually it started working normally, only some packages I included in "pubspes.yaml" can't be recognized, I don't know why, I indeed ran 'flutter pub get' several times and the packages are all latest version, so then I downloaded the package github repo, and added a separated dart file for those package (instead of in"pubspes.yaml"), then my App is working Ok, I am glad.
Even though it's ok now, I would still like to understand where it goes wrong and how can I prevent such things happen again. Should I not upgrade Flutter? Should I not change channel to beta? What should I do if i want to enable web for a current mobile project?
Thank you very much for any comment and help.

I don't know enough about the flutter development process to answer your questions. Maybe @jonahwilliams knows more?

@lutang123 this might happen if the tool cache breaks in an unexpected way. you could verify this by checking that the downloaded dart sdk version matches the commit in the flutter repo, so essentially:
bin/cache/dart-sdk/bin/dart --version

and then:
git status
git rev-parse HEAD

If you include that information it will help me narrow down what went wrong here.  On the otherhand if you want to unblock yourself, you could delete the entire flutter/bin/cache directory and try again.

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


API for funders

It would be useful for the harvesters to look up funders, rather than relying on a hard-coded ID.

Yes, that would be great.


.github, Makefile: sanity workflow fixes, simplify mod-* targets, bump golang to 1.19.x

This PR

simplifies go.{mod,sum} tidying and fixes existing deviations from tidy go mods
fixes the existing gofmt check in the sanity workflow and existing gofmt violations in the code
adds go mod tidiness verification to the sanity workflow
bumps go version to 1.19.x everywhere
updates go deps

/lgtm


Adjust navigation header black bar height

What
This changes the height of the navigation header to match the GOV.UK Frontend header.
Also fixes :focus:hover state for browsers that support :focus-visible - to support both :focus and :focus-visible we need to add the styles for both :focus and :focus-visible - then undo the styles :focus styles for browsers that support :focus-visible. This means that any undone styles need to be re-addded back - and the :focus:hover state was previously missed.
Why
In the far distant past and for reasons unknown the black bar in the header component was adjusted to be a different height to the height of the GOV.UK Frontend / Design System header component. This meant that when a user goes from www.gov.uk to a service, the header would change height - which is not the seamless experience that we're aiming for.
Visual Changes
Height change

Screen size
Before
After

< 360px

>= 360px

Desktop

State fixes for no-JavaScript layout links
Search link :focus-visible:hover
Before:

After:

Search link :focus:hover
Before:

After:

Search link :focus
Before:

After:

Link :hover
Before:

After:

Link :focus:hover
Before:

After:

@miaallers has checked this and said it's all good 👍

Code looks lovely. One little issue and then we're all good.
On no-js, the menu bar is still coming up at 60px on desktop. I reckon this is a result of the padding on the no-js links:

Bother - thanks for spotting that. Now fixed in https://github.com/alphagov/govuk_publishing_components/pull/2422/commits/f7bede135aaa583de1d6fd5e34e8fa7790e6aca0.
I spotted some other things that weren't quite right with the :focus:hover states in browsers that support :focus-visible - I'll update the pull request description with these.

I haven't been able to replicate this using live so I think it might be isolated to this PR

@injms I take that back! I've just been able to replicate it outside this PR. Would you rather I made an issue for this or a new card on our backlog?

I haven't been able to replicate this using live so I think it might be isolated to this PR

@injms I take that back! I've just been able to replicate it outside this PR. Would you rather I made an issue for this or a new card on our backlog?

@owenatgov can you try and replicate the bug with the force-pushed version of this branch? And if the problem is still there then raise an issue.

@injms It's still happening on safari 😬 I'll approve this for now if you're ok to make an issue for this. Happy to do it instead.

Can you raise the issue? I can't replicate this in Safari, so can't really explain what's triggering the problem.

Rebase needed (twice) to make sure the changelog was correct.


Expected tests for protocol upgrade functionality

Plan for developing the protocol upgrade functionality
Several changes to the core code base are needed to facilitate protocol upgrade features.
First, it is necessary to build the foundations for protocol feature upgrades before a single (pre-activated) protocol feature of interest can actually be implemented.
The first part of building the foundations has already been completed. PR #6588 and PR #6624 which complete the refactors of block header state and fork database in preparation for the changes needed for protocol features have already been merged into a separate branch protocol-feature-foundations. This branch (which is forked off of a recent develop branch) will host the changes for the protocol feature foundations. In addition to changes from PR #6588 and PR #6624 (and possibly some code changes that may be required to satisfy the requirements on irreversible mode documented in #6704), the main portion of the protocol feature foundations are the changes tracked by issues #6429, #6431, and #6437.
After the protocol feature foundations are completed, the protocol-feature-foundations branch will be forked off to the forced-replay branch which will be kept in sync with develop. The idea will be for the individual protocol features to merged into this branch (and any other PRs assuming replay from genesis is required) as they are developed rather than into develop directly. The protocol feature foundations include large changes that will force a replay from genesis. We do not want to merge these changes into develop, which would commit those changes to the next minor release of eosio release candidate, until we are confident that we will be able to get the desired set of initial protocol features in together with the protocol feature foundations for an RC release.
In particular, it is important to ensure that the protocol feature tracked in issue #6103 is at least included in this initial set prior to a release, since that is the protocol feature that imposes the requirement of forced replay from genesis. In general, it would be ideal to include the protocol features intended for the initial set of protocol features that require a change to ChainBase data structures. The protocol features that require a change to the ChainBase data structures (and thus also a change to the deterministic snapshot specification) are labeled with SNAPSHOT on GitHub; not all protocol feature issues labeled SNAPSHOTS on the eos GitHub will be included in the initial set of protocol features to be released.
See the section below called "Candidates for initial protocol features" for the candidate set of protocol upgrade features to be considered for the initial release and the tests (at a high-level) expected for each.
Testing the protocol feature foundations
The protocol feature foundations will require testing.
The protocol upgrade tracked by #6431 (pre-activation intrinsic) itself acts as a good test of #6429 and especially #6437.
A sufficient automated test of #6437 (and a significant part of #6429) would be to:

Start off with the base protocol and no contracts deployed on the eosio account.
Attempt and fail to deploy a new version of the eosio.bios contract that links to the new intrinsics introduced in #6431.
Activate the protocol feature for #6431.
Deploy the new version of the eosio.bios contract that links to the new intrinsics introduced in #6431.
Test an action that uses the is_feature_active intrinsic.

(The above test is handled in protocol_feature_tests/activate_preactivate_feature from PR #6831.)
Instead of duplicating work to create a fake protocol upgrade feature solely to test #6431 that then needs to somehow be special cased to not actually be supported in production, it is simpler to just use one of the protocol upgrades already planned as the test case of the functionality of #6431 (and by extension more of the functionality of #6429).
A sufficient automated test of #6431 would be to:

Setup the test chain with #6437 activated (requires doing steps 1, 3, then 4 from above) with the protocol features config setup to require the target protocol feature to need pre-activation.
Verify that the old behavior of the target protocol feature is enforced.
Attempt and fail to activate the target protocol feature without pre-activation.
Push an action that pre-activates the target protocol feature.
Verify that creating the next block that avoids activating the target protocol feature is not acceptable to other chains.
Actually create the next block properly by activating the target protocol feature.
Verify that the new behavior of the target protocol feature is enforced.

(All of the above parts of the test are handled in protocol_feature_tests/only_link_to_existing_permission_test and protocol_feature_tests/require_preactivation_test from PRs #6831 and #7006.)
These tests would also be testing the functionality of #6429 (at least the parts of intended to be implemented for the first protocol upgrade release of eosio). However, it is desirable to create additional automated tests to handle some additional scenarios related to protocol upgrade activation. These tests include:

protocol_feature_tests/activate_and_restart (from PR #6831): Ensures activation information is preserved through a restart.
protocol_feature_tests/double_preactivation (from PR #6831): Verifies that double pre-activation is not allowed.
protocol_feature_tests/double_activation (from PR #6831): Verifies that double activation within a block is not allowed.
protocol_feature_tests/subjective_restrictions_test (from PR #6831): Checks that the conditions of subjective_restrictions are properly respected during attempted activation.

To test that the nodeos process and its plugins do not alter the intended behavior that would already be tested at the libchain level with the automated tests listed above, Python tests are also added:

tests/prod_preactivation_test.py (from PR #6831): Simulates activating the PREACTIVATE_FEATURE protocol feature in a two producer blockchain test.
tests/nodeos_protocol_feature_test.py (from PR #6831): Verifies that changes to the JSON files in config/protocol_features are properly read by nodeos on startup.

Candidates for initial protocol features
In addition to the protocol feature foundations, the release of eosio that introduces support for protocol upgrades will come with support for some initial set of protocol features. The candidates for this initial set (not all of the protocol features below will necessarily be included in the first release) are listed below along associated testing requirements:

✅Disallow linking to non-existing permission (codename: ONLY_LINK_TO_EXISTING_PERMISSION, details at #6333)
Testing requirements:

Check that it is possible to link an action to a non-existing permission prior to ONLY_LINK_TO_EXISTING_PERMISSION activation.
Check that it is not possible to link an action to a non-existing permission prior to ONLY_LINK_TO_EXISTING_PERMISSION activation.

(The above test is handled in protocol_feature_tests/only_link_to_existing_permission_test from PR #6831.)

✅Fix excessive restrictions of eosio::linkauth (codename: FIX_LINKAUTH_RESTRICTION, details at #6672)
Testing requirements:

Check that it is not possible to link actions (of a non-system contract) with any of the unintentionally restricted names (updateauth, deleteauth, linkauth, unlinkauth, canceldelay) prior to FIX_LINKAUTH_RESTRICTION activation.
Check that it is possible to link actions (of a non-system contract) with any of the unintentionally restricted names (updateauth, deleteauth, linkauth, unlinkauth, canceldelay) prior to FIX_LINKAUTH_RESTRICTION activation.

(The above test is handled in protocol_feature_tests/fix_linkauth_restriction from PR #7025.)

✅Disallow proposing an empty producer schedule (codename: DISALLOW_EMPTY_PRODUCER_SCHEDULE, details at #6458)
Testing requirements:

Check that it is possible to propose an empty producer schedule prior to DISALLOW_EMPTY_PRODUCER_SCHEDULE activation.
Check that it is not possible to propose an empty producer schedule prior to DISALLOW_EMPTY_PRODUCER_SCHEDULE activation.

(The above test is handled in protocol_feature_tests/disallow_empty_producer_schedule_test from PR #7026.)

✅Restrict authorization checking when sending actions to self (codename: RESTRICT_ACTION_TO_SELF, details at #6705)
Testing requirements:

Prior to RESTRICT_ACTION_TO_SELF activation, push an action authorized by alice@active to a contract which sends an inline action to itself with an authorization by alice@active. This should be successful.
After RESTRICT_ACTION_TO_SELF activation, check that it is not possible for a contract deployed on an account that is not inline in the permission tree of any other account to:

send an inline action to itself in which the action is authorized by an account other than the contract account;
or, send a deferred transaction containing an action to itself in which the action is authorized by an account other than the contract account.
The above two cases should be handled by a contract executing in the context of both a regular action and an action notification.

(The above test is handled in protocol_feature_tests/restrict_action_to_self_test from PR #7088.)

✅Fix problems associated with replacing deferred transaction (codename: REPLACE_DEFERRED, details at #6103)
Testing requirements:

Prior to REPLACE_DEFERRED activation:

With the subjective mitigations in place, push two actions that try to each send a deferred transaction from the same contract with same sender_id and verify the second one is rejected.
With the subjective mitigations disabled, repeat pushing the prior two actions and verify that the second replaced the first but kept the old transaction ID and did not return the RAM appropriately.

Activate REPLACE_DEFERRED and immediately after verify that the RAM usage of the account that lost RAM due to earlier actions has been corrected.
After REPLACE_DEFERRED activation, and subjective mitigations again in place, repeat pushing the two actions again, but this time verify that the second properly replaces the first with a new transaction ID and with the RAM usage properly accounted for.

(The above test is handled in protocol_feature_tests/replace_deferred_test from PR #6997.)

✅Avoid transaction ID collision of deferred transactions (codename: NO_DUPLICATE_DEFERRED_ID, details at #6115)
Testing requirements:

Prior to NO_DUPLICATE_DEFERRED_ID activation:

Creating a deferred transaction with non-empty transaction extensions is allowed. However, retiring that deferred transaction should fail with a subjective error.

After NO_DUPLICATE_DEFERRED_ID activation:

Creating a deferred transaction with an invalid transaction extension is not allowed.
After creating a deferred transaction with no transaction extension, it should be stored in the generated_transaction_multi_index with the appropriate generation context transaction extension.
Verify that a contract can create a deferred transaction with an appropriate generation context transaction extension.

(The above test is handled in protocol_feature_tests/no_duplicate_deferred_id_test from PR #7072.)

✅Modify restrictions on RAM billing (codename: RAM_RESTRICTIONS, details at #6105)
Testing requirements:

Prior to RAM_RESTRICTIONS activation:

Setup a contract that enables storing some data in a table record with RAM paid by alice and has an action to migrate that record to another table in such a way that continues to bill the same payer but reduces the RAM usage. Provide a way to also trigger that migration operation through a notification rather than a direct action. Furthermore, the contract should have a mechanism (which can be triggered either by direct action or through notification) to schedule a deferred transaction that is billed to an arbitrarily specified account.
Verify that calling that migration action for a table record paid by alice fails if the action does not have the authorization of alice. (Test case 1)
Verify that calling that migration action for a table record paid by alice succeeds if the action does have the authorization of alice.
Verify that calling the action to schedule the deferred transaction paid by alice succeeds if the action is authorized by alice. (Test case 2)
Verify that calling the action to schedule the deferred transaction paid by alice fails if the action is not authorized by alice. (Test case 3)

Prior to RAM_RESTRICTIONS activation and with the subjective mitigation of v1.2.3 not enforced:

Push an action authorized by alice to contract A which notifies contract B which attempts to bill alice. This should be successful. (Test case 4)

After RAM_RESTRICTIONS activation:

Verify that test case 1 now succeeds.
Verify that test case 2 still succeeds.
Verify that test case 3 still fails.
Verify that test case 4 now fails.
Verify that an action (that is not authorized by alice) which increases the RAM usage of alice still fails.

(The above test is handled in protocol_feature_tests/ram_restrictions_test from PR #7131.)

✅Only bill CPU and network bandwidth to first authorizer of a transaction (codename: ONLY_BILL_FIRST_AUTHORIZER, details at #6332)
Testing requirements:

Prior to ONLY_BILL_FIRST_AUTHORIZER activation:

Push a transaction authorized by two accounts. Verify that the network (and CPU) usage of both accounts increases by the same amount.

After ONLY_BILL_FIRST_AUTHORIZER activation:

Push a transaction authorized by two accounts. Verify that the network and CPU usage of the first authorizing account increases. Verify that the network and CPU usage of the other account has not changed.

(The above test is handled in protocol_feature_tests/only_bill_to_first_authorizer from PR #7089.)

✅Forward setcode action to WebAssembly code deployed on eosio account (codename: FORWARD_SETCODE, details at #6988)
Testing requirements:

Prior to FORWARD_SETCODE activation:

With a contract to reject all actions (including eosio::setcode but not if it's setting code on the eosio account) deployed on eosio, ensure that it is still possible to set code on some other arbitrary account.

After FORWARD_SETCODE activation:

With a contract to reject all actions (including eosio::setcode but not if it's setting code on the eosio account) deployed on eosio, ensure that it is not possible to set code on some other arbitrary account but it is possible to replace the code on the eosio account with the bios contract.
Ensure it is not possible to set the code on the eosio account to a contract that will reject all actions with no exception.

(The above test is handled in protocol_feature_tests/forward_setcode_test from PR #7109.)

✅Allows contracts to determine which account is the sender of an inline action (codename: GET_SENDER, details at #7028)
Testing requirements:

Prior to GET_SENDER activation:

Ensure a contract using the get_sender intrinsic cannot be deployed.

After GET_SENDER activation:

get_sender called from a top-level action should return 0.
get_sender called from an inline action should return the receiver of the action that sent the inline action.
get_sender called from a notified action execution should return the receiver of the action that first called the require_recipient to notify the contract.

(The above test is handled in protocol_feature_tests/get_sender_test from PR #7111.)

I guess it's better to have one more api has_auth2(account_name, permission_name) as it was suggested quite frequently.

All tests in above issue were implemented in various PRs. See the parenthetical notes below each protocol feature in the above list for the relevant PRs.


Auto play with loop does not dispose video

Description
I am using gridview populated with a combination of images and videos (similar to what Instagram looks like when you selecting media to upload)
Issue
Clicked onto video, then click onto an image the audio from the video is still playing on a loop in the background, the audio doesn't dispose.
Code Snippet
This determines what type of file is clicked
file = await mediaList[index].file;  assetType = mediaList[index].type.toString();  setState(() { if (assetType == 'AssetType.video') {  _videoController = VideoPlayerController.file(file);  _videoController.setLooping(true);  _videoController.setVolume(100);  _videoController.play();  _initializeVideoPlayerFuture = _videoController.initialize(); } });
This displays the video
FutureBuilder(  future: _initializeVideoPlayerFuture,  builder: (context, snapshot) {  if (snapshot.connectionState ==ConnectionState.done) {  return GestureDetector(  onTap: () {  setState(() {  if (_videoController .value.isPlaying) {  _videoController .pause();  } else {  _videoController.play(); }});},
void dispose() { _videoController.dispose(); }
logs
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 1.22.4, on Microsoft Windows [Version 10.0.18362.356], locale en-ZA)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[!] Android Studio (version 3.5)
X Flutter plugin not installed; this adds Flutter specific functionality.
X Dart plugin not installed; this adds Dart specific functionality.
[√] VS Code (version 1.51.1)
[√] Connected device (1 available)
I am not sure if I've missed anything

Hi @cavedweller
Can you please provide your flutter doctor -v and a minimal complete reproducible code sample?
Thank you

Flutter Doctor
[√] Flutter (Channel stable, 1.22.4, on Microsoft Windows [Version 10.0.18362.356], locale en-ZA)
• Flutter version 1.22.4 at C:\Users\ricca\flutter
• Framework revision 1aafb3a8b9 (2 weeks ago), 2020-11-13 09:59:28 -0800
• Engine revision 2c956a31c0
• Dart version 2.10.4
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at C:\Users\ricca\AppData\Local\Android\sdk
• Platform android-29, build-tools 29.0.2
• Java binary at: C:\Program Files\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
• All Android licenses accepted.
[!] Android Studio (version 3.5)
• Android Studio at C:\Program Files\Android Studio
X Flutter plugin not installed; this adds Flutter specific functionality.
X Dart plugin not installed; this adds Dart specific functionality.
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
[√] VS Code (version 1.51.1)
• VS Code at C:\Users\ricca\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.16.0
[√] Connected device (1 available)
• SM G950F (mobile) • ce081718e4a08f1b04 • android-arm64 • Android 9 (API 28)
! Doctor found issues in 1 category.
Pubspec.yaml
version: 1.0.0+1
environment:
sdk: ">=2.7.0 <3.0.0"
dependencies:
flutter:
sdk: flutter
cupertino_icons: ^1.0.0
dev_dependencies:
flutter_test:
sdk: flutter
photo_manager: ^0.5.6
video_player: ^1.0.1
Required
The code Retrieves the 10 latest media files from the device, to see what i'm experiencing, I have 9 images and 1 short video as my 10 recent media.
Once the code runs click on either an image or the video first, then click on another item of media, you will see the the audio is still playing on loop in the background.
Apologies if i have overlooked something or done something incorrect which is leading to this problem.
Additional error
Once you have clicked on the video and paused it, then click on another image, then lock your device and unlock your device the audio resumes even though the video isn't currently selected.
Code
import 'package:flutter/material.dart';
import 'package:photo_manager/photo_manager.dart';
import 'dart:io';
import 'package:video_player/video_player.dart';
class SampleCode extends StatefulWidget {
SampleCode({Key key}) : super(key: key);
@override
_SampleCodeState createState() => _SampleCodeState();
}
class _SampleCodeState extends State {
List _mediaList = [];
List mediaListpath = [];
int currentPage = 0;
int lastPage = 0;
List media = [];
File file;
String assetType;
List added = [];
VideoPlayerController _videoController;
Future _initializeVideoPlayerFuture;
@override
void initState() {
super.initState();
_fetchNewMedia();

}
@override
void dispose() {
_videoController.dispose();
super.dispose();

}
_fetchNewMedia() async {
lastPage = currentPage;
var result = await PhotoManager.requestPermission(); //gets permission
if (result) {
  List<AssetPathEntity> albums =
      await PhotoManager.getAssetPathList(hasAll: true);
  media = await albums[0].getAssetListPaged(0, 10);
  List<AssetEntity> tempMedia = [];
  List<ListItem> listOfListItems = [];
  for (var asset in media) {
    tempMedia.add(asset);
    listOfListItems.add(ListItem(
      //temp.add(
      FutureBuilder(
        future: asset.thumbDataWithSize(200, 200),
        builder: (BuildContext context, snapshot) {
          if (snapshot.connectionState == ConnectionState.done)
            return Stack(
              children: <Widget>[
                Positioned.fill(
                  child: Image.memory(
                    snapshot.data,
                    fit: BoxFit.cover,
                  ),
                ),
                if (asset.type == AssetType.video)
                  Align(
                    alignment: Alignment.bottomRight,
                    child: Padding(
                      padding: EdgeInsets.only(right: 5, bottom: 5),
                      child: Icon(
                        Icons.videocam,
                        color: Colors.white,
                      ),
                    ),
                  ),
              ],
              // ),
            );
          return Container();
        },
      ),
    ));
  }
  setState(() {
    _mediaList.addAll(listOfListItems);

    mediaListpath.addAll(tempMedia);
  });

  //currentPage++;
} else {
  PhotoManager.openSetting();
}

}
@override
Widget build(BuildContext context) {
final devicesize = MediaQuery.of(context).size;
double _width = devicesize.width;
double _height = devicesize.height;
return SafeArea(
  child: Scaffold(
    body: Column(
      children: [
        Container(
          height: _height * 0.5203,
          width: _width,
          color: Colors.grey,
          child: file == null
              ? Center(
                  child: Text('Tap on media'),
                )
              : assetType == 'AssetType.image'
                  ? Center(
                      child: Image.file(file),
                    )
                  : FutureBuilder(
                      future: _initializeVideoPlayerFuture,
                      builder: (context, snapshot) {
                        if (snapshot.connectionState ==
                            ConnectionState.done) {
                          return GestureDetector(
                            onTap: () {
                              setState(
                                () {
                                  if (_videoController.value.isPlaying) {
                                    _videoController.pause();
                                  } else {
                                    _videoController.play();
                                  }
                                },
                              );
                            },
                            child: Center(
                              child: AspectRatio(
                                aspectRatio:
                                    _videoController.value.aspectRatio,
                                child: VideoPlayer(_videoController),
                              ),
                            ),
                          );
                        }
                        return Container();
                      },
                    ),
        ),
        Container(
          height: _height * 0.3872,
          width: _width,
          child: GridView.builder(
              itemCount: _mediaList.length,
              gridDelegate: SliverGridDelegateWithFixedCrossAxisCount(
                  crossAxisCount: 4),
              itemBuilder: _getListItemTile),
        ),
      ],
    ),
  ),
);

}
Widget _getListItemTile(BuildContext context, int index) {
return GestureDetector(
  onTap: () async {
    file = await mediaListpath[index].file;
    assetType = mediaListpath[index].type.toString();
    if (assetType == 'AssetType.video') {
      _videoController = VideoPlayerController.file(file);
      _videoController.setLooping(true);
      _videoController.setVolume(100);
      _videoController.play();
      _initializeVideoPlayerFuture = _videoController.initialize();
    }
    setState(() {
      file = file;
    });
  },
  child: Container(
    color: Colors.white,
    child: Padding(
      padding: EdgeInsets.all(0.5),
      child: Stack(children: <Widget>[
        _mediaList[index].data,
      ]),
    ),
  ),
);

}
}
class ListItem {
T data;
ListItem(this.data);
}

Hi @cavedweller
It seems that the issue it has nothing to do with the plugin but with your code. You should dispose (or pause) the video controller yourself, it is not something the plugin will do for you.
I've tried to solve your issue, add the code bellow in the onTap of your item:
        file = await mediaListpath[index].file;
        assetType = mediaListpath[index].type.toString();
        if (assetType == 'AssetType.video') {
          _videoController = VideoPlayerController.file(file);
          _videoController.setLooping(true);
          _videoController.setVolume(100);
          _videoController.play();
          _initializeVideoPlayerFuture = _videoController.initialize();
        } else {
          // pause if the selected file is not a video
          _videoController.pause();
        }
        setState(() {
          file = file;
        });

It seems you are asking for assistance on personal code. Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


qps_worker logs are not available on Jenkins

Means that any failures first need to be reproduced locally before even trying to fix them.

Was this in regards to the Jenkins master performance job? Or is this also in issue for PR performance jobs?

Example what's missing?
I can definitely see the logs for many qps workers:
https://grpc-testing.appspot.com/view/Performance/job/gRPC_performance_master/10390/consoleFull
2017-03-08 15:16:03,376 ++ dirname tools/run_tests/performance/run_worker_csharp.sh
+ cd tools/run_tests/performance/../../..
+ cd src/csharp/Grpc.IntegrationTesting.QpsWorker/bin/Release/netcoreapp1.0
+ dotnet exec Grpc.IntegrationTesting.QpsWorker.dll --driver_port=10100
D0308 15:15:07.923356 Grpc.Core.Internal.UnmanagedLibrary Attempting to load native library "/home/jenkins/workspace/gRPC_performance_master/src/csharp/Grpc.IntegrationTesting.QpsWorker/bin/Release/netcoreapp1.0/libgrpc_csharp_ext.x64.so"
D0308 15:15:07.972016 Grpc.Core.Internal.NativeExtension gRPC native library loaded successfully.
Running qps worker server on <IP_ADDRESS>:10100
D0308 15:15:27.914745 Grpc.IntegrationTesting.ServerRunners ServerConfig: { "serverType": "ASYNC_GENERIC_SERVER", "securityParams": { "useTestCa": true, "serverHostOverride": "foo.test.google.fr" }, "payloadConfig": { "bytebufParams": { } } }

2017-03-08 15:16:03,376 PASSED: qps_worker_csharp_0 [time=55.7sec; retries=0:0]
QPS worker "localhost:10100" is still running.
QPS worker "localhost:10110" is still running.
2017-03-08 15:16:03,394 ++ dirname tools/run_tests/performance/run_worker_csharp.sh
+ cd tools/run_tests/performance/../../..
+ cd src/csharp/Grpc.IntegrationTesting.QpsWorker/bin/Release/netcoreapp1.0
+ dotnet exec Grpc.IntegrationTesting.QpsWorker.dll --driver_port=10110
D0308 15:15:07.918494 Grpc.Core.Internal.UnmanagedLibrary Attempting to load native library "/home/jenkins/workspace/gRPC_performance_master/src/csharp/Grpc.IntegrationTesting.QpsWorker/bin/Release/netcoreapp1.0/libgrpc_csharp_ext.x64.so"
D0308 15:15:07.965844 Grpc.Core.Internal.NativeExtension gRPC native library loaded successfully.
Running qps worker server on <IP_ADDRESS>:10110
D0308 15:15:28.216655 Grpc.IntegrationTesting.ClientRunners ClientConfig: { "serverTargets": [ "localhost:34207" ], "clientType": "ASYNC_CLIENT", "securityParams": { "useTestCa": true, "serverHostOverride": "foo.test.google.fr" }, "outstandingRpcsPerChannel": 1, "clientChannels": 1, "asyncClientThreads": 1, "rpcType": "STREAMING", "loadParams": { "closedLoop": { } }, "payloadConfig": { "bytebufParams": { } }, "histogramParams": { "resolution": 0.01, "maxPossible":<PHONE_NUMBER>0 } }
W0308 15:15:28.216819 Grpc.IntegrationTesting.ClientRunners ClientConfig.AsyncClientThreads is not supported for C#. Ignoring the value

2017-03-08 15:16:03,394 PASSED: qps_worker_csharp_1 [time=55.7sec; retries=0:0]

Closing this because we have transitioned from Jenkins to Kokoro.


[BUG]: PublishCodeCoverageResults complains "Can't find loc string for key: InstallDotNetCoreForPublishing"

Task name
PublishCodeCoverageResults
Task version
2.229.0
Environment type (Please select at least one enviroment where you face this issue)

[ ] Self-Hosted
[X] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
Ubuntu 20.04 ARM64
Task log
2023-11-06T05:55:18.9342371Z ##[section]Starting: PublishCodeCoverageResults
2023-11-06T05:55:18.9348362Z ==============================================================================
2023-11-06T05:55:18.9348716Z Task         : Publish code coverage results v2
2023-11-06T05:55:18.9348961Z Description  : Publish any of the code coverage results from a build
2023-11-06T05:55:18.9349332Z Version      : 2.229.0
2023-11-06T05:55:18.9349449Z Author       : Microsoft Corporation
2023-11-06T05:55:18.9349654Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/test/publish-code-coverage-results
2023-11-06T05:55:18.9350243Z ==============================================================================
2023-11-06T05:55:19.8281402Z Found 1 result(s) matching pattern: /mnt/vss/_work/1/a/lcov.info
2023-11-06T05:55:19.8285296Z /mnt/vss/_work/1/a/lcov.info
2023-11-06T05:55:19.8340445Z ##[warning]Can't find loc string for key: InstallDotNetCoreForPublishing
2023-11-06T05:55:19.8349455Z ##[warning]InstallDotNetCoreForPublishing
2023-11-06T05:55:19.8354881Z ##[section]Finishing: PublishCodeCoverageResults

Relevant log output
2023-11-06T05:55:19.8340445Z ##[warning]Can't find loc string for key: InstallDotNetCoreForPublishing
2023-11-06T05:55:19.8349455Z ##[warning]InstallDotNetCoreForPublishing

Aditional info
We're seeing this only on the Linux (Ubuntu 20.04) ARM64 variant of our build. Windows/AMD64 and Linux/AMD64 are unaffected.

Ran into the same issue on a linux vmss pool. I missed the bit in the doco that says you need to "use .net core". Did you happen to include that task before running publish code coverage results? https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/reference/publish-code-coverage-results-v2?view=azure-pipelines#prerequisites

Tasks should really be self-contained and not rely on the user installing things on the machine.

This is not resolved.
I agree that the tasks should be self-contained, but at the very least the documentation should be more clear and the message should be translated. As of right now, it lists no demands or prerequisites.
Work around: PublishCodeCoverageResults@1 seems to do its job just fine without dot net


Inappropriate quick fix suggestion text

class C {
    foo() {
        this./**/lol()
    }
}

The quick fix suggestion text asks the user if they want to declare a static method, even though the method will (appropriately) be placed on the instance side.

@rdosanjh, I imagine it will require more than just updating a string literal or message resource, but it should be a straightforward change to the logic that determines which string is surfaced.

This seems to be fixed in the lastest version in master. Am I correct ?

@assuncaocharles it's entirely possible that @andy-ms fixed this in one of his routine fix-up passes.


fix issue displaying date + commit in info view

Issue is Date + Commit are not displayed:

This PR fixes the issue:

[Vue warn]: Error in render: "TypeError: Cannot read property 'length' of undefined"

found in

---> <Information> at src/components/Information.vue
       <Dashboard> at src/components/Dashboard.vue
         <Repo> at src/components/Repo.vue
           <App> at src/App.vue
             <Root>

Version 83.0.4103.116 (Developer Build) built on Debian bullseye/sid, running on Debian bullseye/sid (64-bit)


Default value for the number of threads

The current default value is cpu_count/2:
https://github.com/abetlen/llama-cpp-python/blob/b2a24bddacc7b10d1ba8a0dff1d8b5fae9bfbad3/llama_cpp/llama.py#L102
This value does not seem to be optimal for multicore systems. For example, a CPU with 8 cores will have 4 cores idle. Or to put it simply, we will get twice the slowdown (if there are no more nuances in model execution).
Related issues: https://github.com/abetlen/llama-cpp-python/issues/71
In this discussion I would like to know the motivation for such a default value, as it seems that it is not obvious to most users.

Most physical systems are hyperthreaded
Hyperthreading doesn't seem to improve performance due to the memory I/O bound nature of llama.cpp
Might be invalid for VMs

Hyperthreading doesn't seem to improve performance due to the memory I/O bound nature of llama.cpp

It's a bit counterintuitive for me. Hypertreading was created to fully utilize the CPU during memory bound programs.
If we are talking about limited CPU utilization on the VM, in my opinion, the library should not solve such case and should offer the most productive option for the base scenario.
In general, it is necessary to test the performance on different systems and choose the most performance default value.

Okay. If the systems with hypertrading receive reductions, then for them this logic can be left, but why for systems with all physical cores logic is not different?

Closing as it is impossible to support every config of hardware.


Possible wrong tutorial (Arithmetic operation Tut for Python)

Studying opencv in python as new here, I came across the Arithmetic operations tutorial and the cv2.threshold(...) command. In the Bitwise operation section I runned the code multiple times  and the result was not as show in the pictures below.
I got somthing closer to the  desired result by changing the thresold method as it is to:
ret, mask = cv2.threshold(img2gray, 250, 255, cv2.THRESH_BINARY_INV)
which results in the desired mask (Results attached)
I can see that the tutorial tried to extract the mask by the complementary command (low thres, cv. THRES_BINARY) but this results in a non desired output (in my case at least and unless I miss something)

Hi, just want to mention the code runs fine for me.
ret, mask = cv2.threshold(img2gray, 250, 255, cv2.THRESH_BINARY_INV) is the correct way to do it, when not proceeding to invert the mask, as done in the example, possibly leading to the confusion.
Thanks.

Hi, just want to mention the code runs fine for me.
ret, mask = cv2.threshold(img2gray, 250, 255, cv2.THRESH_BINARY_INV) is the correct way to do it, when not proceeding to invert the mask, as done in the example, possibly leading to @Ales919 's confusion.
Thanks.


Add resume link, logic and icon.

Changes:

Adds resume link to author frontmatter & logic in /authors/single.html.
Adds resume icon svg.
Adds instructions to new_contributors/enged-author-profile-guidelines.md.

How to Test:
Navigate to beta.section.io/engineering-education/authors/ahmad-mardeni/. Ensure that the resume link displays under the students Skills section. It should match the mockup below. This students resume link should navigate to www.google.com. This is just for testing purposes and will be removed before merging to master. The resume link should not appear for other students without the information in their frontmatter.

cc - @hectorkambow

👍


[BUG]: Problem with working with maven shaded

Description of the bug
There is issue with working with this plugin when maven-shade plugin is used
Details and fix in flatten plugin is here https://github.com/mojohaus/flatten-maven-plugin/issues/100
Steps To Reproduce
Use shade plugin and check if in dependency-reduced-pom.xml ${revision} is replaced
Additional Information
it seems that we lack of one extra call around https://github.com/outbrain/ci-friendly-flatten-maven-plugin/blob/main/src/main/java/com/outbrain/ci/friendly/flatten/maven/plugin/FlattenMojo.java#L57
this.project.setOriginalModel( flattenedPom );

https://github.com/mojohaus/flatten-maven-plugin/pull/281/files#diff-9f8ec1d13bc75e576b6c21b96d277373eb856d5465ef87ef675a983b3ade36beR425

Thanks @piotrwielgolaski-tomtom
We will look into it .

@piotrwielgolaski-tomtom
Can you please create a Pull Request with this change ?

@ayoukhananov I created the simplest fix, tested in my scenario and it works

@piotrwielgolaski-tomtom We have few junit tests and lack of integration tests , this is the main reason it takes so long.

@piotrwielgolaski-tomtom Was released with 1.0.16


skip a check

We have a switch to do just a check; can we add a switch to skip a check? Eg.
fontbakery check-googlefonts -nc com.google.fonts/check/034 fontymcfont.ttf
would skip check 34. This would enable the user who is tuning one particular thing to skip a check that takes a while (i.e. contours).

we do have -x for that!
  -c CHECKID, --checkid CHECKID
                        Explicit check-ids (or parts of their name) to be executed.
                        Use this option multiple times to select multiple checks.

  -x EXCLUDE_CHECKID, --exclude-checkid EXCLUDE_CHECKID
                        Exclude check-ids (or parts of their name) from execution.
                        Use this option multiple times to exclude multiple checks.

Hi, did you know I can't read? 😂

no worries! I'm here to help :-)


CL and Pref Label having the same name

Currently pref labels might have the same/similar name as CL terms making it confusing
A previous example was L5 T Martinotti cell (see #129)
Another example of this that is more blatant is neurogliaform cell in which there is a CL term that correctly encompasses L5,6 neurogliaform too, but also a BDSO term that only encompasses neurogliaform lamp5 (which to be fair is a bit confusing a name too). My guess is that is has to do with some transcriptomic grouping thing? am I right @jeremymiller?

Either way, we should find a way to clarify these naming schemes in the BDSO terms by changing pref label to something else

I'm not sure I'm following, but it seems to me that "L5,6 Neurogliaform Lamp5..." should be a child of "Neurogliaform Lamp5 ...," and that the extra "Neurogliaform cell" node under that should be removed (e.g., there shouldn't be any cell type that has the same parent and child).  Is this what you are asking?

I think this is the issue - there's a MET term for neurogliaform cell and one for L5,6 NGC cell (which i take NGC as neurogliaform cause lamp5 lhx6 is a https://www.biorxiv.org/content/10.1101/490797v1.full.pdf which does bring up more issues, but we are taking the data at face value atm)
I guess now that you mentioned, it looks more like an assigning problem than a transcriptomics problem.
Wonder if NGC cell could actually mean neurogliaform chandelier cell now that I'm re-looking at it?

Wonder if NGC cell could actually mean neurogliaform chandelier cell now that I'm re-looking at it?

From https://www.biorxiv.org/content/10.1101/490797v1.full.pdf
In particular, the Nkx2.1 and Lhx6
transcription cascade drives the MGE but not the CGE clade (23, 26, 27). Interestingly and
surprisingly, a group of Lamp5 subclass interneurons with prominent Lhx6 and Nkx2.1 expression was
classified as CGE derived putative neurogliaform cells (NGFC) (16). Notably, this Lamp5-Lhx6 type
was identified as transcriptionally similar to the CHC2 type, which was considered L5/6 chandelier
cells that were fate mapped from Nkx2.1 progenitors in the MGE clade (20).

NGC means Neurogliaform Cell.  Chandelier cells are completely different.

NGC means Neurogliaform Cell. Chandelier cells are completely different.

Yeah, in that case the reason for the above is that MET type neurogliaform cell doesnt encompass L5/6 NGC whereas CL pulled neurogliaform (by function of both neurogliaform and L5/6 NGC having "has characteristic" some "neurogliaform morphology") encompasses both those types.
We either have to rename it or remove it. I also think this is a problem in CL actually, cause technically neurogliaform lamp5 should include L5/6 neurogliaform.

Suggestions by @tgbugs

When clashes like that happen, can use a tag at end of name eg (BDS Taxonomy) to differentiate and add a comment or something to state that it is defined through the dataset with a xref link out
Alternatively, for NGC - could it be changed to non L5/6 NGC instead? (not sure how accurate this is @jeremymiller)

I'm not sure whether "non L5/6 NGC" would be appropriate in that specific case, although it probably is.  My understanding is that most NGCs are in L1, so unless something else is specified (like "L5/6 NGC") that would be my guess about it.  That said, don't update it based on my guess.  Someone should look into the details to confirm.  Maybe Ray could do this?

@jeremymiller I think the best way to deal with this issue might be to just remove the label of neurogliaform cell, and allow the reasoner to automatically classify cells with neurogliaform morphology to the CL mapping, this is especially so as there isn't going to be a cell type card for this anyway. Thoughts?

That's probably fine.  Make the edits in the appropriate places :-)

Fixed in local repo - will make edit in Allen repo and create PR - closing for now to clean up ticket list


Fix missing icon on PS < <IP_ADDRESS>

Moved the icon from the core into the module where it belongs.

Thanks guys!


Suggestion: Add #Requires -Assembly AssemblyName support

Currently, if I want to reference a .NET assembly like System.Configuration, I do something like this at the top of my scripts:
try{[void][Configuration.ConfigurationManager]}catch{Add-Type -AN System.Configuration}

it would be much more readable (and declarative) as something like:
#Requires -Assembly System.Configuration

Why do you put Add-Type in catch? You could also put using assembly System.Configuration on top of script.

I, too, have used this in a script of mine. It would absolutely be beneficial to be able to include it this way.

@PetSerAl I wasn't aware of the using keyword, though I don't see assembly documented as argument to it. Also, our servers are not uniformly on PowerShell 5 just yet, so that extended syntax isn't something we can fully rely on yet (my workstation is stuck on version 5.0.10105.0-April2015Preview which doesn't support using assembly, and I'm unable to upgrade or downgrade or uninstall it from Windows 7). It seems odd to have another thing that must come first in the script, along with [CmdletBinding()]Param(…). It looks like using must precede [CmdletBinding()]Param(…).
The reason I use the above formulation is to Add-Type only if referencing the type causes an exception, that way I'm only adding it once per session.

The reason I use the above formulation is to Add-Type only if referencing the type causes an exception, that way I'm only adding it once per session.

You can not load same assembly twice anyway. No harm on calling Add-Type for already loaded assembly.
$a = Add-Type -AssemblyName System.Configuration -PassThru | Select-Object -First 1 -ExpandProperty Assembly
$b = Add-Type -AssemblyName System.Configuration -PassThru | Select-Object -First 1 -ExpandProperty Assembly
[Object]::ReferenceEquals($a, $b)

I'll have to look into the using syntax (I hope it gets added to the docs, and is officially supported) once I can finally upgrade things and get the new features.
However, even on a newer machine, there's a pretty big performance difference:
PS C:\Users\me> "$(Measure-Command {0..10000|% {iex 'using assembly System.Configuration'}})"
00:00:08.2655849
PS C:\Users\me> "$(Measure-Command {0..10000|% {Add-Type -AN System.Configuration}})"
00:00:04.6386843
PS C:\Users\me> "$(Measure-Command {0..10000|% {try{[void][Configuration.ConfigurationManager]}catch{Add-Type -AN System.Configuration}}})"
00:00:00.0728870

on my older machine, it's even bigger:
PS C:\Users\me> "$(Measure-Command {0..10000|% {Add-Type -AN System.Configuration}})"
00:00:08.1306933
PS C:\Users\me> "$(Measure-Command {0..10000|% {try{[void][Configuration.ConfigurationManager]}catch{Add-Type -AN System.Configuration}}})"
00:00:00.2983187

I've opened an RFC on updating the behaviour of #requires. Please feel free to comment in the PR.


Reversion cannot recover PartialDateField versions with an empty value

How to reproduce:
Make sure you have enabled the custom module in your Python virtual environment:
pip install django-partial-date==1.3.2 django-reversion==5.0.4

Create the following class in the django models.py:
from partial_date import PartialDateField

class Station(models.Model):
    name = models.CharField(max_length=200)
    created = PartialDateField(blank=True, null=True)

Register the administration of the object with reversion in admin.py:
from reversion.admin import VersionAdmin

@admin.register(Station)
class StationAdmin(VersionAdmin):
    pass

run migrations on your commandline:
python manage.py makemigrations
python manage.py migrate

Login in the admin interface and create a Station object. Provide only a value for the "name" field and leave all the rest empty. Click save and continue editing.
Provide a partial date value in the "Created" the field. E.g. "2020-05". Click save and continue editing
Click on history.
Click on the older version you created before: unintended behavior: "Could not load Name version - incompatible version data."
Click on the latest version with the partial date specified: intended behavior. The version loads properly

https://github.com/etianen/django-reversion/issues/933

Hello. Sorry for the late response. Thanks for the report, I will try to work on it asap


[BUG] Link to field description on article package.json is broken

What / Why

When
Scroll down to the section description (not Description above)
Where
https://docs.npmjs.com/cli/v7/configuring-npm/package-json
How
URLs don't care about casing so the HTML anchor is ambiguous. Interestingly, the ToC uses a better strategy for creating unique anchors but the HTML content itself does not adopt this strategy.
Current Behavior
Cannot create a valid link to the field description
Steps to Reproduce
Option 1: Click here

Option 2: Click on description here

Expected Behavior
Option 1: Link is invalid
Option 2: Link refers to wrong section

This is a known problem with a proposed PR here. Not sure if removing the original "description" is the solution here though.

The proposed solution was not the right one, this is something that is going to need to be fixed in the docs site itself. It should be able to handle this (in fact the t.o.c appears to already try)

@wraithgar what are you imagining the next steps here are"?

@MylesBorins I have no idea where to start. There seems to be a bug with whatever markdown rendering library is being used when there are headers w/ duplicate names.  The table of contents does it correctly, but the page itself does not.

Github's markdown renderer also does not have this bug https://github.com/npm/cli/blob/latest/docs/content/configuring-npm/package-json.md#description-1

Close


Stars are not interpolated

Stars use a method of transforms that we cannot easily interpolate. Someone else more knowledgeable can probably fill out more details here

Resolved by #871


Fix missing variable

{"error":{"code":500,"message":"#<NameError: undefined local variable or method 'file_content' for Validator:Class>"}}

Closed by PR #735


Add kvint4/8 ete testcase

benchmark.yaml change

add kvint4/8 benchmark
change cuda allocate for more effectiveness

daily_ete_test.yaml change

remove kvint8 quantization
remove timeout setting and reorder teststep because the testcase is much more stable

evaluate.yaml change

change model path

pr_test_case chage

remove -s -v to make result more simpler and clearer

autotest/chat_prompt_case.yaml  and autotest/prompt_case.yaml

react testcase to reduce error results

autotest/config.yaml and autotest/utils/config_utils.py

split models into chat model and base model and add more models
refactor kvint setting

autotest/interface/restful/test_restful_interface_func_common.py

add more testcase into restful interface

autotest/tools/chat/*

Streamline test cases, use one test case to cover multiple previous test cases
split testcases into chat and base model

autotest/tools/pipeline/*

add kvint4/8 testcases

autotest/tools/restful/*

add kvint4/8 testcases
refactor start and stop restful server process

other changes:

rename -inner-w4a16 models into -inner-4bits
change temperater=0.01 into top_k=1 to make response more stable
remove useless code after refactor kvint4/8 quantization

test result
daily ete testcase:
https://github.com/zhulinJulia24/lmdeploy/actions/runs/8720843216
some response in some model is still not stable. I will still follow and improve it.

benchmark testcase:
https://github.com/zhulinJulia24/lmdeploy/actions/runs/8724161035

evaluation testcase:
https://github.com/zhulinJulia24/lmdeploy/actions/runs/8720159669

and
https://github.com/zhulinJulia24/lmdeploy/actions/runs/8724058314

pr_test time cost reduce to about 30mins, because of streamline test cases, use one test case to cover multiple previous test cases in cli chat. Currently 4bits quantization is still reserved.

pr_test time cost reduce to about 30mins, because of streamline test cases, use one test case to cover multiple previous test cases in cli chat. Currently 4bits quantization is still reserved.

How long did pr_test workflow cost before this PR?

pr_test time cost reduce to about 30mins, because of streamline test cases, use one test case to cover multiple previous test cases in cli chat. Currently 4bits quantization is still reserved.

How long did pr_test workflow cost before this PR?

currently about 1hours.

--no-deps fixed


46 Explorer > Add preferred classes

https://github.com/geovistory/design-system/issues/46
Added handling of preferred Items.
Still missing is the tag functionality, which implies multiple selection.

Great work! Thank you @flicksolutions. PR approved.
I also like the UI simplification ("All classes" instead of chip).
Did you manually run the linter?

Thank you!
Yes I did since the hooks in place wouldn't let me commit without linting.


No support for segmented odp packet in tcp_output & ofp_sosend_dgram

Hi there
I know that we have set the Interface MTU to 1500 at https://github.com/OpenFastPath/ofp/blob/f6580bb675386b0599390daaabbb0a06c1c1be0c/include/api/ofp_config.h#L61
which is smaller than the packet size(1856) set at
https://github.com/OpenFastPath/ofp/blob/f6580bb675386b0599390daaabbb0a06c1c1be0c/include/api/ofp_config.h#L56
But in my use case, I'd like to make the MTU configurable to meet the requirements of jumbo frames (both TCP & UDP).
If I increase my MTU to some value that is greater than the packet size, it will result in a segmented odp_packet_t.
But the memcpy here in ofp_tcp_output.c
https://github.com/OpenFastPath/ofp/blob/f6580bb675386b0599390daaabbb0a06c1c1be0c/src/ofp_tcp_output.c#L870-L871
and the memcpy here in ofp_uipc_socket.c
https://github.com/OpenFastPath/ofp/blob/f6580bb675386b0599390daaabbb0a06c1c1be0c/src/ofp_uipc_socket.c#L1009
do not check the segmented packets at all, which will cause a buffer overflow.
A simple approach to duplicate this issue is to reduce the SHM_PKT_POOL_BUFFER_SIZE to 1024 or smaller. Or calling ofp_sendto on the UDP sockets with len set to 2000 or greater.
Are there any plans to support this feature?
BRs.

Hi @HsuJv,
To support jumbo frames you will need to:

re-write ofp_mtu_set() to actually set the the MTU on the interface (odp_pktio_maxlen_set() ??) considering max capabilities (capa.maxlen.max_output, capa.maxlen.max_input) etc. Can be tricky .. if I remember correctly, ODP is considering ETH header in this frame size.
Set a pkt_pool.buffer_size large enough for your use-case
Fix the two memory copies... Good find!!

My code is different .. cannot say right now if this is enough.
I don't have plans to contribute to the project (I have my own version) but maybe the other members will. Else, it does not seems too complicated.
BRs

Btw, pkt segments are not well supported in the entire stack... you should try to keep it simple with large enough packets and first segment size = pkt size...

Hi @bogdanPricope
Thanks for the quick reply.
For your answer:

Yes, I've already hooked the ofp_mtu_set with a function pointer to export it to my application so that I can change it dynamic ly.
Actually it is not a feasible approach to increase buffer_size as it will consume a lot more memory for connections that run small packets and will decrease the capability of traffic offload of my application sharply.
Yes the memory copies are the root cause. I've not walked through the whole packet paths but I found that the ofp_cksum  in ofp_in_cksum.c did do the segment check. So I assume that at least some of the developer has taken the segmented packets into consideration.

So in a short, fixing the issues with segmented packets seems necessary for memory saving and may not be very complicated work. It seems that this project has been active again recently so I submitted issues here to let the contributors know.
BRs.


Using enumerate on a Swaths object causes a segfault

We found a bug in Version 2.
Trying to use enumerate on a Swaths object causes a segmentation fault.
It appears that enumerate is going beyond the length of swaths.
Here is a minimal example (that runs nicely in tests/python/types/Swaths_test.py)
def test_fields2cover_swath_enumerate():
  n = 10;
  swaths = f2c.Swaths();
  for i in range(1, n + 1):
    swaths.emplace_back(f2c.LineString(f2c.VectorPoint(
            [f2c.Point(i, i), f2c.Point(i, i + 1)])), i);
  for idx, swath in enumerate(swaths):
    pass
  assert True

I suspect that this is not isolated to Swaths but this is where we found it first.
Hoping to dig in and find the root cause soon but thought we would document it here first.

Trying to get a better idea of the underlying issue. Why was this not an issue before v2. Were there changes made to f2c::types::Swaths? I don't see any changes in https://fields2cover.github.io/source/migration_to_v2.html

It is fixed now. The swig interface had a bug that didn't check if the loop was getting out of the boundary. Feel free to reopen it if it happens again, and thank you for the issue!


Performance tests for event processing

#1785

@csviri The EventSource is sending events but they are not arriving in the Reconciler.


New Titan: Archon

https://northstar.thunderstore.io/package/GalacticMoblin/MoblinArchon/

archon was added, but seems like it doesn't play nice with rebalanced


Fixed logging of errors in BrokerViewCacheActor

Throwable cause instead of being passed as template argument, should be passed as first argument to log.error calls (see http://doc.akka.io/api/akka/current/index.html#akka.event.LoggingAdapter )
This bug is causing warnings like https://github.com/yahoo/kafka-manager/issues/67

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

CLA is valid!


SaaS deployment at resource initialization stage

check saas-config and common-service-maps to check the SaaS deployment and obtain the corresponding configurations.
generate control namespace if it is SaaS deployment.
Deploy secretshare and webhook into control namespace

@horis233 @bitscuit This PR is ready for reviewing.
For deploying webhook and secretshare in control namespace, we add below to cs-operator's cluster role.

several permission for services
get, create permission for serviceaccounts and deployments

After the discussion with @horis233
Firstly, user need to decide whether the multi instances of CS will be enabled for this cluster before installing the first CS, indicating that we did not support the switch between singleton CS and multiple CS.
If it is the singleton CS, the installation flow will be the same as now. we would check len(requested-from-namespace) is 1 to ensure the compatibility between arbitrary namespace installation and multi instances.
If it is the multiple CS installation, user need to set multiInstanceEnabled: true in common-service-maps
apiVersion: v1
kind: ConfigMap
metadata:
  name: common-service-maps
  namespace: kube-public
data:
  common-service-maps.yaml: |
    multiInstanceEnabled: true
    controlNamespace: ibm-cs-control
    namespaceMapping:
    - requested-from-namespace:
      - cp4i
      - cp4mcm
      map-to-common-service-namespace: cp-common-service
     - requested-from-namespace:
      - iaf
      - watson
      map-to-common-service-namespace: watson-common-service

The control namespace ibm-cs-control is for share cluster scope resource.
Additional check:

We are not allowed to for one CloudPakANS in requested-from-namespace  to map twice.

We only allow to add more mapping into into ConfigMap, did not support replace or change the existing mapping.

If user wanna to remove one of namespace mapping. For example, removing cp4mcm mapping, firstly user needs to remove the services cp4mcm and cs-operator in cp4mcm namespace.

@bitscuit Please check the above note, welcome for the objection ^_^

/retest

Temporarily disable the lint-go check for avoiding cyclomatic complexity check, will optimize it later.
Also will have a separate issue to track the enhancement for multi CS instances on non-SaaS deployment
@horis233 @bitscuit This PR is ready for reviewing.

No problem, I will integrated those two in bootstrap structure in this PR https://github.com/IBM/ibm-common-service-operator/pull/450
Also will separate the install flow for SaaS and non-SaaS and remove secretshare CR after the separation in future PR

/lgtm


Prismatic pack

Pack 4 of 4. Though there's a collaboration with Diamsword that might also make it in.
Nothing out of the ordinary here, though there's a few classes that could in theory be useful for others (AbstractChooseOneAction for making Discovery-like cards, PrismaticUtil for generating cards of any color with conditions).
Also included in this PR: small tweaks to my previous packs (a bug fix and a balance change).

Isn't Sword and Dagger supposed to cost 1? Also maybe nerf it to do 7 damage instead (I know Blade Dance exists and is a thing but at least Blade Dance has the downside of pissing off Gremlin Nob)


[Docs] Error links in readme

Description

The layer5 communtiy welcome guide link is leading to wrong link

Expected Behavior

it could be possible that the link is deleted or we can switch it with the newcomer's guide
Screenshots

Environment:

OS: [e.g. Ubuntu]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]
Device: [e.g. laptop, iPhone 8]

[Optional] To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

[Optional] Additional Context

in either of the cases  , i would love to work on this issue

@Ghat0tkach, thanks. Yes, please do copy what has been done in one of the other readmes.

@leecalcote , i raised the same issue on the meshery-osm repo . Please have a look
https://github.com/meshery/meshery-osm/issues/245


gh #40 Removed L1 tests for dsEnableDTCP(), dsIsDTCPEnabled(), dsSetActiveSource()

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@srinivasgtl to review

changes are addressed in this PR
https://github.com/rdkcentral/rdk-halif-test-device_settings/pull/90/


extension cant show in front screen

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

SQLTools Version [e.g. v0.17.x]
VS Code Version: [e.g 1.x.y]
OS: [e.g. Windows, Linux, Mac]
Driver:

[ ] PostgreSQL/Redshift
[ ] MySQL/MariaDB
[ ] MSSQL/Azure
[ ] SQLite
[ ] Other? Which...

Database version: [e.g. MySQL v5.6, PostgreSQL vX...]

Additional context
Add any other context about the problem here.

please solved my problem how it is find i  am so confused

it's a error i cant upload my resporitiries properly please share me any proper and easy way solution

This is not related to the SQLTools extension.


Something was bad, very bad

It really, really didn't work at all.

Looking, I can't see what's wrong.


cranelift: Fix fmin/fmax in interpreter when dealing with zeroes

👋 Hey,
This PR fixes a bug with the interpreter where it is returning the wrong value when comparing 0.0 and -0.0
in fmin and fmax.
This happens because fmin/fmax are defined as returning -0.0 as smaller than 0.0.
However this is not how these values are specified in IEEE754 and the interpreter was
returning the wrong value in these operations since it was just using the standard IEEE754 comparisons.
This also tries to preserve NaN information by avoiding passing NaN's
through any operation that could canonicalize it.

It looks like there's a merge conflict wrt another interpreter PR, but I'm happy to merge this once that's fixed.


A few weird runtime errors

Not sure how to set up a reproducible setup.
Here is the command I ran:
ra-aid -m "Run 'make test' and fix errors"  --provider anthropic --model claude-3-5-haiku-20241022 --cowboy-mode

Here are the errors:
Error: 1 validation error for emit_key_snippets snippets Field required [type=missing, input_value={}, input_type=dict] For further information visit    │
│ https://errors.pydantic.dev/2.10/v/missing Please fix your mistakes.

another similar error which unclear if they are related
Error: 1 validation error for run_shell_command command Field required [type=missing, input_value={}, input_type=dict] For further information visit     │
│ https://errors.pydantic.dev/2.10/v/missing Please fix your mistakes.

Is this on master or a release?

This is from the release.

Ah, actually I have seen these errors. I believe this is actually the AI not correctly formatting the tool call.
It will often resolve itself, but often get into a doom loop.
It's something we should study/gather more data on. For one, we have next to no logging, just the UI outputs.
We should open a new issue/feature request to add a logging system which would essentially use standard Python logging facilities to output much more detailed logging to a log file.

Added logging feature issue here: https://github.com/ai-christianson/RA.Aid/issues/8
We can leave this issue open bc it's definitely a real issue and hopefully once #8 is implemented, we can get some logs to look into this issue more.
In the meantime, it'd be great to report any additional info or anecdotes here.

Makes sense. I'll give it a try.

Something else I wanted to note about this:
I briefly changed the default model temperature to 0 in order to have more deterministic behavior of the agent, but realized that was a mistake because temp 0 makes it impossible for the agent to have some randomness and work its way out of issues like this.
I have seen cases where it makes the wrong function parameters 1-5 times but recovers. I think that having non zero temp is crucial for this recovery to be possible.
My current working theory for this issue in general is that it may be part of the normal course of operations that some models will fail to properly make function calls some percentage of the time. It may therefore end up being an expected operating condition. If so, we could address this by having a better UI representation of what is going on, e.g. not make it look like a major error occurred and represent it more as "the agent made a bad function call and is trying to correct itself."

Makes sense. Curious how aider handles this since I've not seen these during usage. It likely does happen but gets handled internally.

Is aider using function calling? I'm not sure how it works internally.
But I have seen models in aider fail to format the edit correctly and it retries multiple times. Aider has a default limit of 3 retries then it will abort.


Fail to download the pretrained models

The first step of Quick Demo is : Download the provided pretrained models as shown in the README.md.
Then all the pretrained models are stored in gdriver. But, Hmmm… can't reach this page  。
So，请问有没有国内可下载的预训练权重地址链接呀 ？

Sorry, currently we do not have a cloud space to store the pre-trained models within China. Maybe you can train it by yourself. If you only need a single model, you can also email me then I can send one to you.


Deploy

Fixed the issue with Heroku and the app is now hosted on Heroku rather than render avoiding lag times on server.

HEROKU COMPATIBLE


Turn OpenCL CPU tests back on

Summary
The Gelman group Linux machine is back online so we can turn these back on for when changes are done to OpenCL source files.

@serban-nicusor-toptal you can disable the AWS instance now.

@rok-cesnovar Done.

4h15 min for Jenkins tests is nice! :tada:


Nuget package has wrong dependencies

Hi,
I have had som issues with Nlog.Slack.
I found out that a dependency is now NewtonSoft.Json but it isn't stated in the Nlog.Slack nuget package.
Instead a dependency is ServiceStack.Text which I thought you removed according to this issue:
https://github.com/eth0izzle/NLog.Slack/pull/4
Also, when I download the source the version on Nlog.Slack is 1.0.1, not 1.0.2. Isn't the latest code in git?
Regards,
Christian

I just had the same issues as Christian. Luckily I found this as I couldn't understand why one project wasn't working whereas the other did. Turned out to be the NewtonSoft.Json package being missing!
Is this project dead or still going?

@gurufordy : @eth0izzle doesn't seems to be active on GitHub anymore. I have made PR for removing those dependencies, you can check them out. I have also fork the project to keep updated with last version of NLog : https://github.com/cyrilgandon/NLogToSlack

Nice one Cyril, got the feeling this was not as alive as I'd like so I've made the switch to your forked project :+1:

Thanks for the PR Cyril, I'll merge in today!
On 24 March 2016 at 09:16, gurufordy<EMAIL_ADDRESS>wrote:

Nice one Cyril, got the feeling this was not as alive as I'd like so I've
made the switch to your forked project [image: :+1:]
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/eth0izzle/NLog.Slack/issues/11#issuecomment-200749001

Hi @eth0izzle glad to see you again, NLog.Slack has been a great help for my projects. Nlog 4.3 will be out pretty soon, do you plan to update the dependency?
https://github.com/NLog/NLog/releases
I've made a PR for updating to 4.0.1 a while ago, I can update it if necessary!

Yes, I'm going to do an update this weekend :)

Created #15 that resolves this issue.


⚠ Samsung has degraded performance

In e33ae1f, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 1968 ms

Resolved: Samsung performance has improved in 904ac87.


Some german translations added

Refers to #78

Added some of the german translations I was sure of

👍 Danke schön!


v1.0.5-beta5

I think there has been a mistake with the naming of the tags for the v1.0.0 beta line
v1.0.5-beta5 means beta5 toward v1.0.5.
It should have been:

v1.0.0-beta1
v1.0.0-beta2
v1.0.0-beta3
v1.0.0-beta4
v1.0.0-beta5

Regards.

@sylr thanks for the report. The next time we have a beta cycle, we'll make the versioning more clear.
The purpose of incrementing the the semantic version is so that we can quickly see the version in an issue report's output logs while troubleshooting issues that are reported. If we did not increment the semantic version, Trickster it would report 1.0.0 for all beta releases, and that could be confusing.
The next time we re-enter beta after 1.0, I'll make sure to address this by adding an additional field, separate from the version field, that contains information about pre-release builds when needed. Then we can adopt the recommended versioning convention.
For now, however, as we are 5 beta releases deep, it is likely more confusing to users to modify the naming than it is to leave it alone. I will keep the issue open until we have pre-release field ready as described above.

The problem here is that if you release 1.0.0 now people might install 1.0.x-betax because they will think it’s newer than 1.0.0.

On 29 May 2019, at 22:17, James Ranson<EMAIL_ADDRESS>wrote:
@sylr thanks for the report. The next time we have a beta cycle, we'll make the versioning more clear.
The purpose of incrementing the the semantic version is so that we can quickly see the version in an issue report's output logs while troubleshooting issues that are reported. If we did not increment the semantic version, Trickster it would report 1.0.0 for all beta releases, and that could be confusing.
The next time we re-enter beta after 1.0, I'll make sure to address this by adding an additional field, separate from the version field, that contains information about pre-release builds when needed. Then we can adopt the recommended versioning convention.
For now, however, as we are 5 beta releases deep, it is likely more confusing to users to modify the naming than it is to leave it alone. I will keep the issue open until we have pre-release field ready as described above.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Osm model initial setup

Initial set of functionalities for Osm object model.
Entity, Node, Way, Relations - inheritance & essential properties added

This is really clean work!  We can eventually iterate towards this, but for now it is too different from existing iD code to use as a drop-in replacement.