[CSL-1732] Compress logs

This PR introduces support for sending tar.lzma archives to reporting server.
Changes that were made:

Report server can now accept binary files: https://github.com/input-output-hk/cardano-report-server/pull/7
Reporting Methods was restructured to support this change.
Before sending memory logs (from the node itself), we write it to file and tag.lzma this single file. After it's send, archive is deleted. Compression level is maximum.
When node fails from launcher point of view, we do the same, though logs number is more than one (that's where tar is being actually used).

Compression level is maximum.

Is this a good idea? LZMA compression is very CPU and memory intensive and going for the maximum may be excessive compared to the size saving.
Can you post a simple benchmark: take a typical log and compress it with lzma with the minimum, maximum and default settings and measure: 1. the time; 2. maximum memory use and 3. final file size.
My bet is that a lower setting will give a better trade-off of time, memory and filesize.

@dcoutts we've already discussed it with @domenkozar and decided to go with lzma w/ maximum compression. See
https://catchchallenger.first-world.info/wiki/Quick_Benchmark:_Gzip_vs_Bzip2_vs_LZMA_vs_XZ_vs_LZ4_vs_LZO
It should be pretty quick as log size is usually small (30mb or something at most). But i can do benches, sure.

I have said to go with minimum compression level, maybe we understood each other wrong :)

@domenkozar oh, alright then, no problem.

My ballpark estimate was: given the above benchmark of 445M being compressed in 30s with minimum level compression, our logs 2-5MB should take up to a second to compress, which is "good enough".

@domenkozar can you also take a short look at CI here please?

@volhovM you'll need to provide headers (lzma.h) on windows.
https://tukaani.org/xz/

@dcoutts may you please review this PR again?

@gromakovsky Another review round please?


Vulnerability roundup 98: opendkim-2.10.3: 1 advisory [7.8]

search, files

[ ] CVE-2020-35766 CVSSv3=7.8 (nixos-20.09, nixos-unstable)

Scanned versions: nixos-20.09: aa5b9cd16b9; nixos-unstable: 257cbbcd3ab.
Cc @abbradar

Doesn't affect us since we don't install the tests: https://github.com/trusteddomainproject/OpenDKIM/issues/113

Doesn't affect us since we don't install the tests: https://github.com/trusteddomainproject/OpenDKIM/issues/113


[Technical task]: Refactor the code to support unit test

For some feature implementation, I tried to implement unit tests, to have the capability to check request content with Pytest and adapter = requests_mock.get('https://localhost/').
Currently, it is quite complicated mainly due to:

- in script name
argument parsing & some concrete code outside the main function

=> Is it possible to "coordinate" this refactor to achieve that (all current PRs should be updated with this kind of change => it should be done after accepting all the relevant).

https://github.com/fullhunt/log4j-scan/blob/070fbd00f0945645bd5e0daa199a554ef3884b95/.gitignore#L1
@mazen160 : I'm surprised by that 😬. Are there already some existing tests (locally?) ?

Reopen for merge in original repo.
Testable from https://github.com/axel3rd/log4j-scan


[Feature] notification settings 🔔 & user settings menu ⚙

Checklist

[x] I tested all changes and all related features with different users (student, tutor, editor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Server: I followed the coding and design guidelines.
[x] Server: I added multiple integration tests (Spring) related to the features (with a high test coverage)
[x] Server: I added @PreAuthorize and check the course groups for all new REST Calls (security)
[x] Server: I implemented the changes with a good performance and prevented too many database calls
[x] Server: I documented the Java code using JavaDoc style.
[x] Client: I followed the coding and design guidelines.
[x] Client: I added multiple integration tests (Jest) related to the features (with a high test coverage)
[x] Client: I documented the TypeScript code using JSDoc style.
[x] Client: I added multiple screenshots/screencasts of my UI changes
[x] Client: I translated all newly inserted strings into English and German.

Motivation and Context
Adds Settings for Notifications. Additionally, provides a new container, module & polymorphic structure for further user settings.
These settings are intended to be very similar to the ones in GitHub.
Description

A) How to access the new settings page(s)
a)  Click on the Profile Icon 👤. The DropDown menu shows a new settings icon ⚙. (It works just like a link). If clicked, it will redirect you to the new User Settings Menu.

demo

b) Click on the Notification Bell Icon 🔔. Once the notification sidebar is open click on the gear ⚙to directly open the Notification Settings.

demo

B.a) User Settings Menu (Overview Page)

Here you can see the new user settings page.

In the top left corner is the full name and login of the current user (the avatar icon 👤 can be easily replaced by a custom picture in the future)
On the left side, you can see the menu bar to switch between the different settings.
On the right side, the current settings page itself is displaced

B.b) First User Settings Page : Account Information

Shows the most important account information of the current user.
This page is currently primary a dummy page without any customization.

Further comments about the Account Information Page & TS2 Settings/Password Component ⚠
I added the Account Information page so the new User Settings Menu/Overview page does not only consist of the new Notification Settings.

Just last week (when this feature was already implemented but the tests were missing) during a (not-related) testing session on TS2 I noticed for the first time ever an already existing account settings component where you can customize certain things.
This feature seems to be only activated in TS2 (not on TS1, TS3, or production (as far as I am aware of it now).
It should be quite easy to transfer these components in the new User Settings Menu.

C) Notification Settings
To dis-/enable the respective notification option simply toggles the check box and press the save button to confirm your changes

In depth explanation of the notification settings
(We decided to use a button instead of saving the changes directly to optimize the communication between client and server)
The main goal of the notification settings is to give the user the choice to decide which notifications should be displayed.
But regardless of one's settings, certain critical notifications should always be displayed (not possible to deactivate them) (e.g. errors, failures, etc.)
To be able to filter notifications there should be a way to differentiate them.

The easiest way to do so is to look at the origins of the notifications. (E.g. was this notification created because a new exercise has been released or because an attachment has been updated by an instructor? These are two very distinct notifications where one user might be only interested in the first notification (regarding the new exercise), but another user would like to only receive the latter one (attachment update) and a third user would like to receive both, and a fourth one would like to receive none.)
This notification origin can already be traced back to the NotificationType.java enums.
These enums are used in a factory pattern to create the actual notifications.
But after their creation, this information (which enum was used) gets lost (due to the inheritance transformation from abstract notifications to group notifications (for easier "multicasting"), i.e. there was no way to deduce how a notification was created when it arrived at the client (Of course you could look at the notification text and title, but these can vary drastically due to no fix conventions) ->, therefore, I decided to add a new column to the notification table called OriginalNotificationType and save the used "factory-enum" there. -> Now you can easily find out how a notification was created just by looking at this new property.

But to simply take each notification origin (enum) and give it a respective option in the new user settings page would be too confusing due to the big number of different enums.
We decided to group (very) similar enums together to reduce the total number of options (+ simply not show/provide options to toggle crucial notification types).
After trying different grouping strategies we decided to use the following ones (which you can also see in the final implementation)

Steps for Testing
I will provide respective video demos to follow along to test if the notification settings work as they should.

Check if the gear icons in the UI are correctly displayed (in the account drop-down as well as in the notification sidebar)
Make sure that the translation works for every new UI element (aka. the icons and the User Settings Menus, Account Information Page, and Notification Settings Page) (if there is a translation error, try refreshing the page (with/without cache) first)
Play around by disabling/enabling the WebApp checkboxes ☑ and trying to envoke the respective notification (you will have to use a different user for this (i.e. use a different incognito tab/browser in parallel)

"TestAlong" A : new Post for Exercise

"TestAlong" B : Attachment change

IMO: If issues occur only at specific options than this issue is most likely not related to this PR but to the legacy code.
Very detailed explanation of the code and design choices (for code reviewers) 👀

 open here
Please have a look at the new README.md file. Please keep in mind that you can change the view for .md files in GitHub (click on the icons to the right of the file name to view the same file in the markdown styling view which is way more pleasant to look at.)
My goal is to create a very easily reusable and extensible user settings structure (& conventions).
(This is a completely new and isolated module therefore the huge number of changes (LoC).
Also, it is my first time modifying the database and creating a new REST controller, thus I simply lacked the experience to plan this out in advance and split this PR into multiple parts (everything is connected). Multiple PRs would also made many things more complicated and IMO not possible to create manual testing (e.g. you can not test the new UI if the database (which the UI depends on is not yet implemented, etc.))
General Structure:
new Module: user-settings (to keep everything in one common place)
user-settings.model (describes the basic data structure that is intended to be reused for many other settings in the future)
- Each "sub-page" in the new User Settings Menu (e.g. Notification Settings) is represented via the new UserSettings interface.
The category is a new enum that is used to differentiate between the different user settings (notifications, vs ...)
(i.e. for Notification Settings this category will be NOTIFICATION_SETTINGS)
- This UserSettings interface also has a property called groups : OptionGroup[]
These groups should group similar options together, e.g. groupName = "Exercise Notifications" (with options: "Exercise created or started", "Exercise open for Practice", etc.)
This should make it easier to collect and display similar options instead of simply giving the user a huge chaotic list of options.
Such groups have restriction levels, e.g. the OptionGroup "Instructor Exclusive Notifications" will have a restriction Level of Authority.INSTRUCTOR (the default is of course USER).
Therefore this OptionGroup will only be shown to Instructors or Admins.
- The individual options of such an OptionGroup are what the settings are actually for. These can be changed by the user.
- Such an Option has a name (e.g. "Attachment Changes"), a description (what this option does) (e.g. "Receive a notification  when an attachment was changed") and OptionCore.
- A OptionCore is the most relevant part of the option. It is used to ensure lightweight communication between client, server, database. (If the name and description of each Option would be saved there would be a huge redundancy)
- A OptionCore is abstract, i.e. you need to create a concrete implementation for it, also such an option core can differ vastly from one settings page to another.
Every OptionCore has an id (to have a unique identifier in the database (as an entry), a boolean flag if it was changed by the user (only changed cores will be saved (more lightweight))
Lastly, every core has a unique option specifier (enum) (used for mappings, translation, etc.)
There is a naming convention for them to ensure a correct automatic translation.
E.g. for a concrete implementation NotificationOptionCore which adds 2 bools webapp, email. (Indicating if the notification should be shown in the Artemis web app / send via email)
As you can imagine these two bools are only useful for NotificationSettings but not for other (future) settings, that's the reason for polymorphism and inheritance.
The goal is to (re)use this structure/hierarchy to make the creation of new settings, options, groups as easy as possible.
To create the entire settings structure you have to create a x-settings.default.ts file (look at the notification settings one).
Such an object is very easy to write and should be intuitive to understand/read. (Especially when correctly using the collapsing feature of your IDE)
This structure will be rendered in the respective HTML template.
The basic shared logic is collected in the (abstract) user-settings.directive.ts.
The different Resource calls are done by user-settings.service.ts
There is also a simple guide/read-me inside of the user-settings folder to help other developers to adjust the current or create totally new settings. (txt. file).
Further changes:

I refactored the title property that is set in the factory for Group and Single User Notifications by creating a bidirectional map between NotificationType (used for creation) and constant String title (used for display, legacy, and now also filtering by settings)
Notifications about new Exercise/Lecture Posts will now also be sent to students. I decided to make this change, because now it is possible to deactivate this option so spam for students will not be a problem and from my experience, there are students that really like to help and enjoy discussing difficult questions/problems, they will appreciate this option.

Review Progress

Code Review : Client Side

[x] Review 1
[x] Review 2

Code Review : Server Side

[x] Review 1
[x] Review 2

Manual Tests

[x] Test 1
[x] Test 2

Test Coverage

Client Side:
user-settings.service  > 95%
notification.service ~ 90%
notification-sidebar.component ~ 90%
notification-settings.service >70% ( I tested the logic to 100%, there is a big static mapping happening in this service, if I would test if every mapping is working correctly this would be just a code duplication IMO)
user-settings-prototype.component > 90%
notification-settings.component > 90%
Server Side:
NotificationSettingsService ~ 100%
NotificationResourceIntegrationTest ~ 100%
NotificationSettingsResourceIntegrationTest ~ 100%
Concerning the open issues where help was needed. They are all solved with the help of @SimonEntholzer 👍 (in 30 mins)
I received so much great advice and support during code reviews so I wanted to tell you who reviews that I really appreciate your time and effort 💙: Thank you very much (in no specific order): @lschlesinger , @MerlinMehmed , @ndricimrr , @Olimbia23 , @MaisiKoleni, and @imstreetspirit !

I implemented the change request from @krusche. I.e. I renamed the option to setting (server and client side), moved the default settings to the server (default-settings in the client now only consist of permanent hierarchical structures and translations, therefore I renamed them to settings-structures). The REST loading call now always returns settings.
I tested it locally, everything works as intended (so far the test servers are occupied).
The failing TypeScript Client Test confuses me because all client tests work for me locally and the error in the logs do not really make sense to me (issue seems to be based on used dependencies, but mine are the exact same as the newest ones)

Quick update: Because this PR takes quite a long time to be merged, naturally a merge conflict occurred.
The change is very very small. I only replaced the name of a constant:

All tests still work :

The PR has been extensively tested multiple times and approved:

=> It is still mergable

@Malyuk-A As this is a large PR, I would appreciate some more reviews and tests.

Thank you all very much for testing, your feedback!
The requested changes will be fixed in the email support or a smaller follow-up PR. (The mentioned sidebar issues are legacy-related because we could observe similar behavior on development.)
So I think It is ok to merge this PR.


feat: port Analysis.SpecialFunctions.Trigonometric.Basic

I'm going to fix most of the errors in this file right now. There are just two kinds of failures remaining: four continuity failures and five convert failures.

I'm going to fix lint errors

@pechersky Is it ready for review? If yes, then adjust the labels, please.


Streaming audio on separate channels

Greetings.
First of all I would like to thank you for all your tutorials, they provide excellent entry point to learn WebRTC for beginners like myself.
Now for the question: Is it possible to set up WebRTC to output certain audio streams to selected sound card channels? For example, I have a 5.1 surround system and I want to output WebRTC audio stream 1 to a certain channel (e.g. central speaker) and to output audio stream 2 to another channel (e.g. back left speaker).
I've found that WebRTC has a internal API called VoeBase, which should provide multichannel support but I am not sure this applies my problem.
Thank you very much for your answer in advance.
Best regards.

Hi doctorA, Muazkhan
I have the same your question, have you found a solution for this issue? Can you help me?


feat(plugin-eslint): create groups from rules' metadata

Closes #200

Valuable change. We should add this to the eslint plugin docs.

Good call, just added it :grin:


remove deprecated and unused migrate command

remove deprecated and unused migrate command

Should we remove MigrateIDs at the same time?

as we discussed we will remove the migrateids in 3 weeks :)


_ Other Tests _

+1 :green_heart:
unit
0m 35s
hbase-protocol-shaded in the patch passed.

6m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5411

Optional Tests
unit

uname
Linux 02a2a416391b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 787d524d55

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/testReport/

Max. process+thread count
75 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded U: hbase-protocol-shaded

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 24s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 52s
master passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 47s
root in the patch failed.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hbaseprotoc
0m 43s
the patch passed

+1 :green_heart:
spotless
0m 37s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m  8s
The patch does not generate ASF License warnings.

7m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5411

Optional Tests
dupname asflicense cc hbaseprotoc spotless prototool

uname
Linux e620c5b7839b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 787d524d55

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded U: hbase-protocol-shaded

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Ah, the Any class has some help messages like pack and unpack, so can not be simply changed to a self defined protobuf message.
Although the two methods are not very hard to implement by our own, let me also relocate the proto files in HBASE-28096 and try again to see if we can rely on the relocated proto files. If not, will try to copy these two methods to our code bases too to fix the problem.
Thanks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  1s
prototool was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 47s
master passed

+1 :green_heart:
compile
4m 57s
master passed

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s
the patch passed

-1 :x:
compile
1m 20s
root in the patch failed.

-0 :warning:
cc
1m 20s
root in the patch failed.

-0 :warning:
javac
1m 20s
root in the patch failed.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
9m 20s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
hbaseprotoc
2m 51s
the patch passed

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 22s
The patch does not generate ASF License warnings.

32m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5411

Optional Tests
dupname asflicense cc hbaseprotoc spotless prototool javac hadoopcheck xml compile

uname
Linux 1bef86855c98 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 94e4055fd1

Default Java
Eclipse Adoptium-11.0.17+8

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/artifact/yetus-general-check/output/patch-compile-root.txt

cc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/artifact/yetus-general-check/output/patch-compile-root.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/artifact/yetus-general-check/output/patch-compile-root.txt

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 45s
master passed

+1 :green_heart:
compile
1m 52s
master passed

+1 :green_heart:
shadedjars
4m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  3s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 34s
the patch passed

+1 :green_heart:
compile
1m 54s
the patch passed

+1 :green_heart:
javac
1m 54s
the patch passed

+1 :green_heart:
shadedjars
4m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  1s
the patch passed

_ Other Tests _

-1 :x:
unit
242m 44s
root in the patch failed.

271m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5411

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux 0f070e5ed8d0 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 94e4055fd1

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/testReport/

Max. process+thread count
4957 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 12s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 24s
master passed

+1 :green_heart:
compile
1m 36s
master passed

+1 :green_heart:
shadedjars
4m 29s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 33s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 15s
the patch passed

+1 :green_heart:
compile
1m 36s
the patch passed

+1 :green_heart:
javac
1m 36s
the patch passed

+1 :green_heart:
shadedjars
4m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
362m 54s
root in the patch passed.

390m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5411

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux 629bcd6ea2a5 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 94e4055fd1

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/testReport/

Max. process+thread count
8225 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Ah, an error prone error...
Let me check what is the root cause, maybe the problem is we upgrade the error prone annotation version in hbase-thirdparty.

OK, I think the problem is I removed the exclusion for CanIgnoreReturnValue in protobuf so error prone is working now...
It is excluded in HBASE-18666, because we found a lot of error prone problems in HBASE-18656 which causes build to fail...
Anyway, we have done a bunch of error prone cleanup now, I think it is time to remove these exclusions and get all the checks back.
@saintstack FYI.

Oh, it is not related to the exclusive, there is no CanIgnoreReturnValue annotation for protobuf 3.21.x, it is introduced in 3.22.x, so we will hit this error.
Let me open an issue to fix the problem.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 36s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 55s
master passed

+1 :green_heart:
compile
4m 42s
master passed

+1 :green_heart:
spotless
0m 39s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 35s
the patch passed

+1 :green_heart:
compile
4m 36s
the patch passed

+1 :green_heart:
cc
4m 36s
the patch passed

+1 :green_heart:
javac
4m 36s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
9m 58s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
hbaseprotoc
2m 49s
the patch passed

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

36m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5411

Optional Tests
dupname asflicense cc hbaseprotoc spotless prototool javac hadoopcheck xml compile

uname
Linux 6f05e8e2932d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ff0f0e4318

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
77 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 38s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 53s
master passed

+1 :green_heart:
compile
1m 44s
master passed

+1 :green_heart:
shadedjars
5m  9s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 57s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 35s
the patch passed

+1 :green_heart:
compile
1m 46s
the patch passed

+1 :green_heart:
javac
1m 46s
the patch passed

+1 :green_heart:
shadedjars
5m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
268m  0s
root in the patch passed.

298m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5411

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux b4dfe2739407 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ff0f0e4318

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/testReport/

Max. process+thread count
8194 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 12s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 15s
master passed

+1 :green_heart:
compile
1m 36s
master passed

+1 :green_heart:
shadedjars
4m 46s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 14s
the patch passed

+1 :green_heart:
compile
1m 37s
the patch passed

+1 :green_heart:
javac
1m 37s
the patch passed

+1 :green_heart:
shadedjars
4m 41s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 33s
the patch passed

_ Other Tests _

-1 :x:
unit
331m 58s
root in the patch failed.

358m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5411

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux 4287d9f1e5bb 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ff0f0e4318

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/testReport/

Max. process+thread count
5760 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 49s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 53s
master passed

+1 :green_heart:
compile
5m 54s
master passed

+1 :green_heart:
spotless
0m 54s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 36s
the patch passed

+1 :green_heart:
compile
5m 41s
the patch passed

+1 :green_heart:
cc
5m 41s
the patch passed

-0 :warning:
javac
5m 41s
root generated 1 new + 909 unchanged - 1 fixed = 910 total (was 910)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
10m 37s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
hbaseprotoc
2m 53s
the patch passed

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

42m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5411

Optional Tests
dupname asflicense cc hbaseprotoc spotless prototool javac hadoopcheck xml compile

uname
Linux cf833c81bed2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7ec0176b2f

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/artifact/yetus-general-check/output/diff-compile-javac-root.txt

Max. process+thread count
82 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 59s
master passed

+1 :green_heart:
compile
1m 49s
master passed

+1 :green_heart:
shadedjars
5m 23s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 54s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 45s
the patch passed

+1 :green_heart:
compile
1m 51s
the patch passed

+1 :green_heart:
javac
1m 51s
the patch passed

+1 :green_heart:
shadedjars
5m 19s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 51s
the patch passed

_ Other Tests _

-1 :x:
unit
262m  3s
root in the patch failed.

292m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5411

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux 78a156d55f9f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7ec0176b2f

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/testReport/

Max. process+thread count
5312 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 14s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 22s
master passed

+1 :green_heart:
compile
1m 33s
master passed

+1 :green_heart:
shadedjars
4m 45s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 32s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 14s
the patch passed

+1 :green_heart:
compile
1m 34s
the patch passed

+1 :green_heart:
javac
1m 34s
the patch passed

+1 :green_heart:
shadedjars
4m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 32s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
403m 34s
root in the patch passed.

431m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5411

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux b2d13ca3d0c7 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7ec0176b2f

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/testReport/

Max. process+thread count
7988 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5411/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


[docs] Fix @material-ui/styles release version number

NPM currently has a 4.9.0 version, so I think that's what this was supposed to be.

[x] I have followed (at least) the PR section of the contributing guide.

Thanks


Only half of the traceid is used when using the LightstepPropagator.

Not sure if anyone is still using this library, but I believe I found a bug (unsure of the correct behavior).
If a traceId is 32 characters, then the SpanContext will split it into upper/lower: https://github.com/lightstep/lightstep-tracer-javascript/blob/67019d6773f26dc97495e418818ffe8b08e702b2/src/imp/span_context_imp.js#L51-L54
But when the X-Cloud-Trace-Context header is created for propagation, only the lower section is used since only the private _traceGUID is accessed: https://github.com/lightstep/lightstep-tracer-javascript/blob/67019d6773f26dc97495e418818ffe8b08e702b2/src/imp/propagator_ls.js#L25
A fix would be to instead use the traceGUID function: https://github.com/lightstep/lightstep-tracer-javascript/blob/67019d6773f26dc97495e418818ffe8b08e702b2/src/imp/span_context_imp.js#L31-L33
As it is today, this results in headers like:
X-Cloud-Trace-Context 5d22122a52f8d5400000000000000000/7676538251468309227;o=1

The zeros are a result of only using the bottom "bits" of the split traceId.
Is there a specific reason why the Lightstep propagator does not use both parts of the trace id? I'm unsure if there is more implicit information there, such as a parent trace, that I don't know about. I did notice that the dd propagator encodes more information in there:
https://github.com/lightstep/lightstep-tracer-javascript/blob/67019d6773f26dc97495e418818ffe8b08e702b2/src/imp/propagator_dd.js#L24-L29
While the B3 propagator also skips some:
https://github.com/lightstep/lightstep-tracer-javascript/blob/67019d6773f26dc97495e418818ffe8b08e702b2/src/imp/propagator_b3.js#L21-L24
OpenCensus' Stackdriver implementation appears to use all the bits:
https://github.com/census-instrumentation/opencensus-node/blob/ef5712fd3b279b0e80494322231232047b06f9e6/packages/opencensus-propagation-stackdriver/src/stackdriver-format.ts#L80-L87
Is this a bug? or is it expected / spec'ed behavior?

This is the expected behavior.  The underlying reason for all of this is that Lightstep only accepts 64 bit trace IDs (which maps to 16 hex characters), but context propagation formats typically allow for 128 bit trace IDs (32 hex characters).  We truncate those trace IDs (by taking the least-significant 64 bits / 8 bytes / 16 hex chars) before sending them to a satellite.  Typically propagators send the full 128-bit trace ID and the truncation happens later, right before we send data to a satellite.  But, for the Lightstep context propagation format, we assume the data is eventually going to a Lightstep satellite, so do the truncation earlier, as part of the context propagation.
The B3 spec dictates that it will propagate what it receives, so if it receives just 16 hex chars, it will propagate those 16 (that's the behavior in the code snippet you linked), or otherwise it will propagate the full 128 bit (32 hex chars) trace ID.
I'm not sure whether there is something wrong in the X-Cloud-Trace-Context header you linked - that looks like a GCP-specific header format (that I don't think could have been emitted by the code here? But perhaps was in a connected service?).
Let me know if this all makes sense or if there seem to be remaining bugs here!

@kayousterhout Thank you very much for the clear explanation! I'm sorry I didn't know that Lightstep only used 64 bit trace ids. Not knowing that was very confusing when comparing this implementation to the new OpenTelemetry libraries! I'm glad I know now.
You are also correct that the X-Cloud-Trace-Header is not in the code in this repo; again, my apologies. It's from an internal extension of the Tracer from this repo that does something like this to construct the header:
public inject(
    spanContext: any,
    format: string,
    carrier: LightstepCarrier,
  ): void {
  LightstepTracer.prototype.inject.call(this, spanContext, format, carrier);
  const traceGuid = carrier['ot-tracer-traceid'];
  const spanGuid = carrier['ot-tracer-spanid'];
  const traceGuidForHeader: string = traceGuid.padEnd(32, '0');
  const spanGuidForHeader: string = hexToIntString(spanGuid);
  const traceValue = `${traceGuidForHeader}/${spanGuidForHeader};o=1`;
  carrier['X-Cloud-Trace-Context'] = traceValue;
}

Since it's using the values placed into carrier by LightstepTracer.prototype.inject, I assumed showing the header was a good example to illustrate the most significant bits being dropped (since it's basically just using the values from this library), but forgot that the header was GCP/opencensus. Sorry for the confusion.


Survey building levels

Surveying building:levels seems to be a task well suited for Kort.

Sorry, I didn't see that it's already covered.


Auto poll

does this need an interactive rebase or should it be squashed?

for now, please stick with the existing conventions as defined in tslint

@DrewAns Could you do the fixes, my system isn't setup for the running npm lint (Proof in Pic) nor do I have the tslint setup for vscode. As for the prettier fixes, didn't realize until we already pushed, meant to do most editing on Drew's side for the ui


Added notebook for quick build tests

As Keras has now been shifted to a new repo, build times have reduced dramatically. It is now possible to run unit tests in Colab with reasonable speeds. In this PR I've added a notebook link which basically sets up environment for testing and runs the tests mentioned by the user. However it is not advisable to run all tests in Colab as it will be quite slow.
Please share your thoughts on this.
/cc @qlzh727 @chenmoneygithub

@haifeng-jin
I see. Thanks for the clarification!


Enhance SubstituteFrom to allow crossnamespace

Usually we have some variables to store on secret or configmap, we use the kustomize-controller to sustitue these variable from the secret or configmap.
But the limitation of the kustomize-controller is that now don't support crossnamespace.
So we hope to enhance kustomize-controller for this part.

/assign @JaneLiuL

We discuss this in our Flux public meetings and the decision was not to allow cross-namespace references to secrets outside RBAC. The same way Kubernetes doesn't allow a Deployment to mount secrets from other namespaces, so should Flux.


auth.user null after login

Im using feathers-vuex with nuxt and could not get the auth.user to populate after login
     const payload = Object.assign({ strategy: 'local' }, {email: this.email, password: this.password});
      try {
        const ans = await feathersClient.authenticate(payload)
        if (ans.accessToken) {
          ******* HERE THE store.auth.user should be set but is not
          this.$router.push({name: 'index'})
        }
        else {
          this.errorText = 'Innloging feilet'
          this.showError = true
        }
      } catch (error) {
        this.errorText = 'Innloging feilet'
        this.showError = true
      }

So I had to insert this code (where ****** is) to populate it
const user = await this.$FeathersVuex.User.get(this.$store.state.auth.payload.userId)
this.$store.state.auth.user = user

Is there a better solution than this hack?
Store setup:
    actions: {
      nuxtServerInit({ commit, dispatch }, { req }) {
        return initAuth({
          commit,
          dispatch,
          req,
          moduleName: 'auth',
          cookieName: 'feathers-jwt'
        })
      },
      togglerefresh({ commit }) {
        commit('togglerefresh')
      },
    },
    plugins: [
      service('/api/points'),
      service('/api/users'),
      auth({
        userService: '/api/users',
        state: {
          publicPages: [
            'login',
            'signup'
          ]
        }
      })
    ]

Same issue here

Please reopen if your idField is set correctly but it's still not working.  I'm fairly certain that will fix your issue.

My problem was that i had
userService: '/api/users',
outside of state
The correct way is like this:
    plugins: [
      service('/api/points', { debug: true }),
      service('/api/users'),
      auth({
        state: {
          userService: '/api/users',
          entityIdField: '_id',
          publicPages: [
            'login',
            'signup'
          ]
        }
      })
    ]


More attempts to fix Travis CI runs

Add RCTBridge+Private to exported headers for unit tests
Fix tvOS build

configure: error: in '/Users/travis/build/facebook/react-native/third-party/glog-0.3.4':
configure: error: C compiler cannot create executables
See 'config.log' for more details

Trying https://gist.github.com/mattyohe/31552b6543ae0cf2fdca912c29e9bb17#file-makefile to get rid of the error 65


More Documentation

Hello,
I'm trying to understand the network itself. Could we get some comments for the classes in capsule_layers.py?
Thanks!

I agree there should be more documentation. Unfortunately I was very sick for nearly two weeks and was receiving many requests for the code so I pushed it out with less comments than I would have preferred. I will try to make a point to add more comments when I can find some free time. Busy life of a PhD student :)


[FLINK-30016][docs] Mention system metrics dependencies update

What is the purpose of the change

Mention system metrics dependencies update in release note.

@MartijnVisser Updated content.zh as requested.

@MartijnVisser PR in https://github.com/apache/flink/pull/21320.


DS3231 not correctly reading date

According to the Maxim data sheet, the DS3231 has a century bit in BIT 7 of the 5th register. The current code does not mask this out, which means that the returned date is incorrect (2023 returned for 2016).  See the .c file line 471 which reads
uint8_t d = bcd2bin(Wire._I2C_READ());
The same masking should be applied as is done in the seconds register
uint8_t d = bcd2bin(Wire._I2C_READ() & 0x7F);
Presumably the century flag should be incorporated somewhere else too ?? I didn't look at this since I dont need it at the moment.
This problem is visible if you hook up an Arduino to a Raspberry Pi on the same I2C bus, then have the RPi obtain time via NTP, then do a "hwclock -w" to write the current time to the RTC module.  Its not clear why the RPi sets the century flag given that we are in 2016, but that's a different issue !!
You can also demonstrate the same point by clearing the month bit with something like
i2cset -f -y 1 0x68 0x05 0x11
However the RPi will reset the bit to 0x91 when the next "hwclock -w" is performed
I note that the same logic is used in the PCF8523 device, but I've not checked that data sheet. This should be checked against that data sheet too.

This issue is still present.
The PR that tried to fix it was closed because some other issues fixed in there were dealt with by another PR.
See datasheet:

If the module was set on another device, it might have the month set to some value > 12.
Also strictly speaking if the module is set using this library, and read out via other code, it may show the wrong century.
Something similar can happen to the hours as the module can be set to AM/PM mode.
From the datasheet:

The DS3231 can be run in either 12-hour or 24-hour mode. Bit 6 of the hours register is defined as the 12- or 24-hour mode select bit. When high, the 12-hour mode is selected. In the 12-hour mode, bit 5 is the AM/PM bit with logic-high being PM. In the 24-hour mode, bit 5 is the 20-hour bit (20–23 hours). The century bit (bit 7 of the month register) is toggled when the years register overflows from 99 to 00.

Also not sure what will happen to the DOW if the century is wrong.
I doubt there is a check in the chip to recompute the DOW, but it might be set using another library.

Added mask for the century bit in #246 . Hopefully fixes this.


[BUG] Whoops! An error occurred: {'transaction underpriced: gas tip cap 245466, minimum needed<PHONE_NUMBER>'}

when attempting python promocode_ledger.py create_promo_code ALPHAGROWTH 0x6e57181D6b4b7c138a6F956AD16DAF4f27FC5E04 BSC
warnings.warn(
Creating promocode...
Promo code:  ALPHAGROWTH
Promo code HEX:  0x000000000000000000000000000000000000000000414c50484147524f575448
Recipient:  0x6e57181D6b4b7c138a6F956AD16DAF4f27FC5E04
Chain name:  BSC
RPC URL:  https://bsc-dataseed1.binance.org/
Derived Path:  44'/60'/71'/0/0
Nodesale contract address:  0x496C48d24a33B1Fd45782537eBd42157Bf265703
ENV variables MAX_ACCOUNTS_FETCH:  100
Whoops! An error occurred: {'code': -32000, 'message': 'transaction underpriced: gas tip cap 245466, minimum needed<PHONE_NUMBER>'}

https://github.com/VolumeFi/w3tools/pull/15
@taariq
It looks BSC gas estimation error.
I added the manual gas fee for BSC chain.


License changes

Related issues
License change from Apache 2.0 to MIT.

@PabloCarmona why are all the tests not passing? And why are there so many other commits? For this change, I am just expecting a change that changes the license.


Deploy DAP by default for backwards compatibility

We changed the default behaviour that this repo deploys OSS by default. That change was reverted and we need to do it again. We have the deploy-oss restored and we can continue the work from there.
We need to:

[ ] Deploy DAP by default and OSS with the --oss flag
[ ] Decide what the default value will be in kubernetes-conjur-demo & secrets-provider-for-k8s
[ ] Challenge the way we deploy the OSS cluster. It may be different than the way described in the docs
[ ] Challenge the way we handle different deployments

Currently both deployments are handled in the same scripts where the differences are handled by if [[CONJUR_DEPLOYMENT == "oss" ]] clauses. It may be more readable to have 2 sets of scripts with duplications.

[ ] Uniform the way we update files with text. We have some sed and some sh.yml replacements.
[ ] Wait for Conjur server to be ready when configuring Conjur CLI. At this point we just sleep for 45 seconds. We should wait for it properly.
[ ] Add tests for OSS - at this point we have tests in this repo for DAP. We should have the same for OSS  so we don't catch errors only in the consuming projects
[ ] Update kubernetes-conjur-demo & secrets-provider-for-k8s to consume kubernetes-conjur-deploy properly and run both OSS & DAP tests.

@orenbm, this is a great set of items.  It feels like we need to be a bit more explicit about the stated purpose of each of these key project:

kubernetes-conjur-deloy
kubernetes-conjur-demo
secrets-provider-for-k8s
That's outside the scope of the work you're describing here.

Challenge the way we deploy the OSS cluster. It may be different than the way described in the docs

The kubernetes-conjur-deloy project references Helm.  With this shift, we'll need to provide two sets of documented options for OSS Conjur.

Are we deploying tests into OpenShift as well as Kubernetes?

Are we deploying tests into OpenShift as well as Kubernetes?
Yes

@izgeri @jasongarabedian - Please see if and how you want to promote this task and give it the needed priority
@orenbm - Thanks for putting all this information together

When this effort is done - also continue working on this PR: https://github.com/conjurdemos/kubernetes-conjur-demo/pull/78
It uses the changes in deploy to run tests in demo

@Tovli I think you meant @jvanderhoof
We should use a separate repo for deploying OSS. Can you ask in Slack which would be appropriate? We have the helm chart, the docker-compose for the quick start, I think a few people (in the field? devs?) have their own repos they use for deploying it, @doodlesbykumbi one time created this POC in Secretless (not merged) - having a single canonical repo for OSS deploys (like we have this repo for deploying DAP followers) makes sense. I suspect you could just use the helm chart in your automation and call it a day.
I don't think OSS deploy tools belong in this repo.

Thanks @izgeri, I am really want to raise the lack of OSS test in k8s and trying to understand who should be assigned such task.
We did try to deploy using the helm chart but found the kubernetes-conjur-deploy repo easier to work with
@jvanderhoof - Please consider if you want to progress this task, I'll be happy to assist

for Secretless OSS support, we tested manually and left automated tests for a future effort. since our group owns the OSS, I would really love for this group to be able to define what appropriate automated e2e tests are for OSS and own that going forward - it is just a little tricky right now because we are staffed on other projects.
I will wait for @jvanderhoof to weigh in further before saying more, but I really don't think OSS deploy tools belong in this repo.


add children for the Button

Codecov Report

Merging #839 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #839   +/-   ##
=======================================
  Coverage   99.75%   99.75%
=======================================
  Files         276      276
  Lines        7012     7012
  Branches     1719     1719
=======================================
  Hits         6995     6995
  Misses         17       17

Impacted Files
Coverage Δ

src/components/button/Button.tsx
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9718f80...a6236d2. Read the comment docs.


Change blocktime to float

Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The change updates the BlockTime field type from int64 to float64 in the AnvilConfig struct to allow more granular block time configurations.
What

config/network.go

Changed the type of BlockTime from int64 to float64 in the AnvilConfig struct. This change allows for more precise block time configurations, accommodating the need for sub-second block times.

Anvil is not accepting sub second blocktime.closing this


unpkg

Use unpkg in README CDN URLs.

You should shorten this to:
<script src="https://unpkg.com/d3-array@1"></script>
<script<EMAIL_ADDRESS>

Oh nice!


Upper/Lower Case of Column Names and other Identifiers is not preserved in some Drivers

In some driver modes, such as MSSQL, the case of column names and other identifiers is not preserved.  This results in output with the incorrect key names.   i.e., ColumnOne is not the same as columnone.
The Sequel library has an API to change the default behavior, but the corresponding option is not available in Logstash configuration.
In my specific case, I was losing capitalization on my MSSQL Column Names.  To workaround, I modified plugin_mixins/jdbc.rb, adding the following line:
@database.identifier_output_method = :to_s

under the existing Sequel.connect line.

I worked with Jay @PhaedrusTheGreek on this.  The underlying problem is that Sequel has a downcase converter default that is applied to all field names when processing the resultset.  An option is available on the Sequel class or the database connection to provide a different operation.  The mechanism is .send(:symbol) so we can only use methods available on the String class.
Consider adding a config to give the user a way to control what case conversion is applied to the fields from the resultset, or perhaps the resulting keys in the event.

@PhaedrusTheGreek and @guyboertje, do you have the gem file for windows with this workaround in place? I am using the LogStash 2.0 and running into this exact behavior. It would be wonderful if I could download the gem file and use it. Thanks!

Ok, figured it out. Works like a charm!
Under the function "prepare_jdbc_connection", add the workaround after
    @database = jdbc_connect()
add => @database.identifier_output_method = :to_s

@guyboertje are we going to this this, or this is a jdbc mysql specific issue?
Looks like we can have an extra parameter which is identifier_output_method and add that as required. Does this makes sense? any other option on how to resolve this ?

According to the documentation this will happen in many different databases, identifiers will be lowercased, so we should fix this by setting to_s or nil.

@gmoskovicz - I was waiting for anyone to pick this up.  I thought even Jay might create a PR.
Thinking about it though, the reason why Sequel makes it lowercase is to help with the datamapper and activerecord type frameworks that make the identifiers into Ruby method calls.
We don't do this. We make the identifiers into string Hash keys or LS Event keys.  There is no reason why they need to be lowercase, is there?
Therefore we don't need a config option, we should always use to_s.
Proposal: if people create their tables with mixed case identifiers then we should reflect that in the Event that is generated.

@PhaedrusTheGreek, @gmoskovicz gimme a plus one if you agree with ^

+1 @guyboertje , that seems like a better default.    As a workaround for any regression, i wonder if it would be possible to lowercase the identifiers in a LS filter if desired.

Proposal: if people create their tables with mixed case identifiers then we should reflect that in the Event that is generated.

:+1:
And also a :+1: for @PhaedrusTheGreek idea, the best option is to add a lowecarse_keys to deafult false. Does this makes sense?

@gmoskovicz - it makes sense to include a config option to force_lowercase_keys defaulting to false

Where can I find the jdbc.rb file in logstash folder. In lib folder I have two folders bootstrap and pluginmanager but no jdbc.rb file in those folders. There is no folder like plugin_mixins.

@srinvas i think that this should be under .../logstash-2.0.0/vendor/bundle/jruby/1.9/gems/ inside the jdbc folder.

maybe ,,,/logstash-2.0.0/vendor/bundle/jruby/1.9/gems/logstash-input-jdbc-2.1.0/lib/logstash/plugin_mixins/jdbc.rb

Got it  thanks @gmoskovicz  @guyboertje


[Bug] error occurred while saving preferences

version 0.26.0 gives an error when trying to save preferences:
"An error occurred while saving preferences"
(tested on windows with a new install or portable)
happens e.g. on change of SSL/TLS Certificate Verification
to make it work, one has to set the proxy.port to a number e.g. 1000 even when not used
( devtools output
Error: Error invoking remote method 'renderer:save-preferences': ValidationError: proxy.port must be a number type, but the final value was: NaN (cast from the value ""). )

Not able to reproduce the issue
I was able to reproduce the issue just once
after that it didn't occured

This is happening for me on an Intel Mac running Sonoma.  It started when I downloaded Bruno v0.26.0.  I was running v0.17.0 before.  My settings were reset after the update to v0.26.0.

I guess to issue occurs when this condition evaluates to a NaN
Would be great if someone can share more light Thank you


Re-export UTF8 generators from quickcheck-text

Just to make it less effort to test with non-ASCII character sets when appropriate rather than always using the ASCII-only corpus, which I think is something we want to encourage.
/cc @charleso

:+1:


Improve Atom Flight Manual: 3.3 Package: Word Count

Someone generate package as wordcount, his or her package will be shown as a deprecated package.
Because many names look like lib/wordcount.coffee and keymaps/wordcount.cson, many os use can name their packages wordcount and will get deprecated messages.

This is a duplicate of atom/docs#85. Please subscribe there for updates.


Closing connection doesn't stop execution

Closing a connection using  something like the example below doesn't stop the execution of the code.
Right now we're putting everything in if and else statements and stopping further execution like that.
Is there a better way or proper way to do this?
Function to kill connection:
public function forceClose(ConnectionInterface $conn, $reason) {
        // Close connection to client, violated security
        $conn->close();
        $this->clients->detach($conn);
        echo "PeerId: {$this->peerID}'s connection has been terminated for security reasons\n";
        echo "Reason: {$reason}\n";
    }

Example of calling said function:
$this->forceClose($conn, 'onMessage parameter check failed');

@citadelnetworks If there are any open connections, listening connections, or timers open, the loop will not exit.

Well I have an option connection and that function above will close the connection if it fails a security check point. But the code execution will  continue for the connection even if the connection is closed.
I couldn't figure out how to really stop the execution, I'm thinking a while loop but that didn't really work for some reason.
Any ideas? Sorry it's my first time using Ratchet.
Also this is a single connection.

I am not sure what you mean that "code execution will continue for the connection even if the connection is closed".
Are you still receiving messages after you call close?

No the client side closes, but the code execution on the server doesn't stop.
So when the user enters, I have a function run. In the middle of the function, if the forceClose is called, the function doesn't stop executing. It'll kill the client connection and run the rest of the function outputting stuff.

@citadelnetworks The server is supposed to continue running. If you would like the server to shutdown, you will need to stop listening for connections.

@citadelnetworks The code will continue to run. It is up to the developer to prevent that code from running.
You may want to look into some reactphp tutorials that can explain better than I can how the event loop and connections work.
https://reactphp.org/#articles

You just need to return from the function.. Basic php


[x] You added test for bug fixes or new features?
[x] All tests passed?
[x] You have rebased with master branch?

Does this pull request introduce any breaking change?

[ ] Yes
[x] No

Other note

Publish without building code 👎


question

Hellow sir,thank you very much for your code,but I want to know how you set path element,await your reply.

If you are talking about the visualization, please take a look at the 80s lines in infotaxis_gui.py.
The agent's position is stored in self._pos in infotaxis.py.


[Berkeley] Fixup broken handling of lookup feature flag

This PR depends on https://github.com/MinaProtocol/mina/pull/13547. This fixes the bug in the lookup flags, where the lookup flag representing the lookup gate selector was the sole flag controlling the lookup argument, causing the argument to fail when the gate was unused.
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

!ci-build-me

LGTM modulo comments above.

!ci-build-me

!approved-for-mainnet


VM: inefficient "x is String" test

In _StringBase.== there is a hot-path test
(other is! String)

It compiles to:
0x7f727ee9ad95			test al,0x1
0x7f727ee9ad97			jz 0x7f727ee9add8
0x7f727ee9ad9d			movl r10,[rax+0x3]
0x7f727ee9ada1			cmpl r10,0x7e
0x7f727ee9ada5			jz 0x7f727ee9adde
0x7f727ee9adab			cmpl r10,0x43
0x7f727ee9adaf			jz 0x7f727ee9adde
0x7f727ee9adb5			cmpl r10,0x44
0x7f727ee9adb9			jz 0x7f727ee9adde
0x7f727ee9adbf			cmpl r10,0x45
0x7f727ee9adc3			jz 0x7f727ee9adde
0x7f727ee9adc9			cmpl r10,0x46
0x7f727ee9adcd			jz 0x7f727ee9adde
0x7f727ee9add3			jmp 0x7f727ee9add8
0x7f727ee9add8			movq rax,[r14+0x50]	true
0x7f727ee9addc			jmp 0x7f727ee9ade2
0x7f727ee9adde			movq rax,[r14+0x58]	false
0x7f727ee9ade2			pop rdx
0x7f727ee9ade3			cmpq rax,[r14+0x50]
0x7f727ee9ade7			jz 0x7f727ee9ae23

This sequence has many small problems. It compares against an abstract class id (0x7e = String). The range of values is compared element by element. The code generates a bool value and compares that against 'true' instead of branching directly to a target.
Compare this to the immediately following equivalent test generated as a guard on other.length:
0x7f727ee9adfd			test al,0x1
0x7f727ee9adff			jz 0x7f727ee9af98
0x7f727ee9ae05			movl rbx,[rax+0x3]
0x7f727ee9ae08			subq rbx,0x43
0x7f727ee9ae0c			cmpq rbx,0x2
0x7f727ee9ae10			ja 0x7f727ee9af98

The irony here is that not only should the is-check look more like the guard for other.length,  the guard for other.length should not even be be necessary, since the other is! String test ensures the same condition.
Perhaps the code could be rewritten to make this visible to the compiler?

This does not repro for dart2js.  I think the new type propagation may have helped.


Uploading empty mission on mission_raw_server  lead to core dump

Uploading an empty mission to a mission_raw_server instance will trigger a core dump.
This's probably a faulty behaviour of the GCS itself but QGroundControl leave users sending empty missions without complains.
Unluckly in mission_raw_server_impl.cpp this function:
void MissionRawServerImpl::set_current_seq(std::size_t seq)
{
    if (_current_mission.size() < static_cast<size_t>(seq)) {
        return;
    }

    _current_seq = seq;

    // If mission is over, just set item to last one again
    auto item = seq == _current_mission.size() ? _current_mission.back() :
                                                 _current_mission.at(_current_seq);
    auto converted_item = convert_item(item);
    _parent->call_user_callback([this, converted_item]() {
        if (_current_item_changed_callback) {
            _current_item_changed_callback(converted_item);
        }
    });

    mavlink_message_t mission_current;
    mavlink_msg_mission_current_pack(
        _parent->get_own_system_id(),
        _parent->get_own_component_id(),
        &mission_current,
        static_cast<uint16_t>(_current_seq));
    _parent->send_message(mission_current);
}

such case is not trapped by the if guard on top and then:
    auto item = seq == _current_mission.size() ? _current_mission.back() :
                                                 _current_mission.at(_current_seq);

Will dump a core...

Would you be willing to contribute a fix for that? Maybe it could return a RESULT_INVALID_ARGUMENT for an empty mission? Or some other error?

Maybe I can arrange a fix and submit a pull-request... but I have not idea
bout how to return  RESULT_INVALID_ARGUMENT  .
Il giorno mer 25 gen 2023 alle ore 11:56 Jonas Vautherin <
@.***> ha scritto:

Would you be willing to contribute a fix for that? Maybe it could return a
RESULT_INVALID_ARGUMENT for an empty mission? Or some other error?
—
Reply to this email directly, view it on GitHub
https://github.com/mavlink/MAVSDK/issues/1962#issuecomment-1403427741,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABOP54SRWVFYPRBP2WUYK6TWUEBFDANCNFSM6AAAAAAUGCRZUI
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
bye by(t)e[s]... WeirdGyn!


Add empty display for element list panel

Changes

Add empty display for element list panel
IMPORTANT! To merge this PR before this
[delete] branch

Additional information

You may refer to this ticket

hello do resolve the merge conflicts


--prod Build stops without any message

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x ] 3.x
[ ] 4.x
I'm submitting a ...  (check one with "x")
[ x] bug report
[ ] feature request
Current behavior:
My application works when deploying to the device. It also works when I use
ionic cordova build --minifyjs --minifycss --optimizejs
However, when trying to run
 ionic cordova build --prod --release it gets stuck at  "copy finished in..."
C:\Users\martin\Documents\Coding\Hybrid Apps\markerl4>ionic cordova build android --prod --release Running app-scripts build: --prod --platform android --target cordova [22:35:57]  build prod started ... [22:35:57]  clean started ... [22:35:57]  clean finished in 4 ms [22:35:57]  copy started ... [22:35:57]  deeplinks started ... [22:35:57]  deeplinks finished in 42 ms [22:35:57]  ngc started ... [22:36:02]  ngc finished in 4.70 s [22:36:02]  preprocess started ... [22:36:02]  preprocess finished in 1 ms [22:36:02]  webpack started ... [22:36:02]  copy finished in 4.90 s
I could let it run for hours it nothing changes. The process thakes 15% of my I7-8700K CPU. I couldn't find any solution anywhere.
Expected behavior:
It should just jump to the next part (which is webpack, I believe) and finish the process.
Steps to reproduce:
I cant't tell. When starting with a tab-starter, building in --prod mode is working. It must have to do with a configuration within the app.
Related code:
My package.json
{
  "name": "xxx",
  "version": "xxx",
  "description": "xxx",
  "main": "index.js",
  "dependencies": {
    "cordova-plugin-ionic-keyboard": "^2.0.5",
    "cordova-android": "^7.0.0",
    "cordova-plugin-device": "^2.0.2",
    "cordova-plugin-splashscreen": "^5.0.2",
    "cordova-plugin-ionic-webview": "^1.1.19",
    "cordova-plugin-whitelist": "^1.3.3",
    "@angular/common": "5.2.10",
    "@angular/compiler": "5.2.10",
    "@angular/compiler-cli": "5.2.10",
    "@angular/core": "5.2.10",
    "@angular/forms": "5.2.10",
    "@angular/http": "5.2.10",
    "@angular/platform-browser": "5.2.10",
    "@angular/platform-browser-dynamic": "5.2.10",
    "@firebase/app": "^0.1.6",
    "@ionic-native/clipboard": "^4.7.0",
    "@ionic-native/core": "^4.7.0",
    "@ionic-native/diagnostic": "^4.7.0",
    "@ionic-native/geolocation": "^4.7.0",
    "@ionic-native/google-maps": "^4.7.0",
    "@ionic-native/launch-navigator": "^4.7.0",
    "@ionic-native/social-sharing": "^4.7.0",
    "@ionic-native/status-bar": "4.7.0",
    "@ionic/app-scripts": "^3.1.9",
    "@ionic-native/splash-screen": "4.7.0",
    "@ionic/storage": "^2.1.3",
    "angularfire2": "^5.0.0-rc.6.0",
    "cordova-clipboard": "^1.2.1",
    "cordova-plugin-actionsheet": "^2.3.3",
    "cordova-plugin-dialogs": "^2.0.1",
    "cordova-plugin-extension": "^1.5.4",
    "cordova-plugin-geolocation": "^4.0.1",
    "cordova-plugin-googlemaps": "^2.2.9",
    "cordova-plugin-x-socialsharing": "^5.4.0",
    "cordova-sqlite-storage": "^2.3.1",
    "cordova.plugins.diagnostic": "^4.0.5",
    "es6-promise-plugin": "^4.2.2",
    "firebase": "^4.12.1",
    "firebase-tools": "^3.18.4",
    "install": "^0.11.0",
    "ionic-angular": "3.9.2",
    "ionicons": "3.0.0",
    "promise-polyfill": "^7.1.2",
    "rxjs": "5.5.10",
    "sw-toolbox": "3.6.0",
    "uk.co.workingedge.phonegap.plugin.launchnavigator": "^4.2.0",
    "zone.js": "0.8.26"
  },
  "devDependencies": {},
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "xxxl",
  "license": "ISC",
  "cordova": {
    "platforms": [
      "android"
    ]
  }
}

Other information:
When I add the --aot to ionic cordova build it gets also stuck. Maybe those are connected.
Ionic info:
cli packages: (C:\Users\martin\AppData\Roaming\npm\node_modules)

    @ionic/cli-utils  : 1.19.2
    ionic (Ionic CLI) : 3.20.0

global packages:

    cordova (Cordova CLI) : 8.0.0

local packages:

    @ionic/app-scripts : 3.1.9
    Cordova Platforms  : android 7.0.0
    Ionic Framework    : ionic-angular 3.9.2

System:

    Node : v8.10.0
    npm  : 6.0.0
    OS   : Windows 10

Environment Variables:

    ANDROID_HOME : not set

Misc:

    backend : pro

I tried a few other combinations and it stops working with the --optimizejs tag. As far as I know, --prod is a summary of --minifyjs --minifycss  --optimizejs and --aot

I resolved this issue by recreating the whole project just to find out that it has to do with Firebase. I am not sure wether it is angularfire2, ionic-firebase or anything else, it just builds fine now. Hope this helps someone.


this is a title

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior.
Expected behavior
A clear and concise description of what you expected to happen.
Sample
A link to a GitHub repository with a minimal, reproducible sample.
Reports that include a sample will take priority over reports that do not.
At times, we may require a sample, so it is good to try and include a sample up front.

这是一个页码

eee对对对


Added show password buttons #180

Pull Request Format
PR Title: Add show password buttons
Issue #180
Type of PR

[ X] Feature enhancement

Description
This pull request aims to fix an issue where show password buttons were not present in login and signup pages.
Screenshots / Videos (if applicable)
Before:

After:
https://github.com/user-attachments/assets/33a85b22-af3d-4787-97d1-4f180b21d760
Checklist

[X] I have performed a self-review of my code.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

Thank you for reviewing my pull request!

@swaraj-das plz check my PR

@devarsheecodess There is merge conflict. please resolve it.

@swaraj-das i have resolved the conflicts, merge before i get more conflicts
Also add the labels here too

@devarsheecodess There is conflict till now.

@swaraj-das , i have resolved the merge conflicts again, plz merge before i get more conflicts :')

@swaraj-das plz merge my PR with labels

@swaraj-das i have resolved the conflicts again, plz merge my PR


Consider adding allow-navigation and allow-intent to config.xml

A forum user was trying to test an app that used an iframe but was unable to set allow-navigation or allow-intent
<allow-navigation href="*" />
<allow-intent href="*"/>

Would there be any security implications beyond the obvious?

Hrm, I'm not sure but we can add it in.

Discussion of this problem on Cordova JIRA: https://issues.apache.org/jira/browse/CB-10709


capital H

My man

Coverage remained the same at 100.0% when pulling d1b090c3f6aa5539d84f1d8099b4734b44ed2fd9 on retlehs:patch-1 into 9954588eea24f58e26dd5644775a5f246b1d2279 on austinpray:master.

ty @coveralls


feat: upgrade configuration for Zeebe 0.23.x

Description
Upgrades configuration to be 0.23.x compatible - note that this is not backwards compatible with any image pre 0.23.x. Adds an extra value, extraConfig, which allows users to add additional Spring Boot configuration paths as described by the Spring Boot documentation.
As a bonus, allows enabling/disabling the Elasticsearch exporter via the value elasticExporter.enabled. When enabled, the proper configuration will be added to the zeebe.cfg.yaml.
Tested against 0.23.0-alpha2 - the tag is also fixed to this now, but should be updated to the correct stable release when available.
Closes #46

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: npepinpe
If they are not already assigned, you can assign the PR to them by writing /assign @npepinpe in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Note that this depends on #43 at the moment, as I wanted to migrate this as well. If #38 also gets merged I'll update it in a separate PR (or here depending on which gets merged first).
/ok-to-test

I think we should merge this after the 23 release.

I'm OK with this, as with custom environment variables we're not blocked to test different configurations until then :+1:

@npepinpe could you rebase the branch?
@salaboy any thoughts? Can we merge it after it is updated?

Let's put this on hold, as I want to re-do it with Peter anyway - he knows this topic well, and I also want to get him onboard into the whole Helm topic.

@npepinpe should we close this PR? as there is a new one already :)

Yes, will close in favor of #55


Does this actually work?

I'd find this very useful, but unlike all of the other Sublime LSP languages I've tried so far, this is the only one that doesn't work and doesn't even error. Is there an npm library I need to install globally?
I'd love to use this, but I'm at a loss for why it isn't working and I don't want to waste time messing with it if it isn't quite ready for primetime yet.
If it shoud be working, anything I can look for to figure out why it isn't? Thanks!

Does it even start up? Do you see lsp-stylelint in the status bar?
What extension does the file you are trying it on has?
https://lsp.readthedocs.io/en/latest/troubleshooting/

I just found an issue related to ST3 + SCSS so I'll fix that.

Actually, for CSS it was already not triggering in ST3. :)
The problem was with the wrong syntaxes being assigned. In ST4 those don't matter anymore so it worked there.

@rchl Thanks for responding. I tried with SCSS and CSS, both in ST3. No signs of anything happening in the status bar either, but sounds like you're on top of it.
Let me know if there's anything I can do to help, and thanks for your work on this.

BTW, just tried it again with 1.0.1 and its working!

I don't think it's working, at least for me. It says it intializes but it doesn't give any other than Code Action that doesn't seem to work.

@peterlobster try opening a new issue, and make sure to write which sublime text version you are using and paste your server logs in the issue(see this page on how to enable logging )


Check preset blocks_order

What are you adding in this PR?
Solves https://github.com/Shopify/theme-tools/issues/590
When presets have blocks as a hash, they must also be included in the block_order array... Unless they are a static block (a block with static: true), then they have to NOT be included in the block_order.
Note: this check doesn't validate the existence of block_order, it assumes it's there to run this check.
To test:
{% schema %}
{
  "class": "container-background-image",
  "name": "A test section",
  "blocks": [{ "type": "@theme" }],
  "presets": [
    {
      "name": "Preset One",
      "blocks": {
        "block_1": {
          "type": "text",
          "static": true
        },
        "block_2": {
          "type": "text"
        }
      },
      "block_order": ["block_1"]
    }
  ]
}
{% endschema %}

What's next? Any followup issues?
Does JSON Schema enforce that block_order is present when dealing with preset blocks as a hash? If not, this should be added.
What did you learn?
To use CP's new building blocks :)
Before you deploy

[x] This PR includes a new checks or changes the configuration of a check

[x] I included a minor bump changeset
[x] It's in the allChecks array in src/checks/index.ts
[x] I ran yarn build and committed the updated configuration files

[ ] If applicable, I've updated the theme-app-extension.yml config

[ ] I included a minor bump changeset
[ ] My feature is backward compatible

[ ] I included a patch bump changeset

@navdeep5 just warned me that copy+pasting the same schema code from my tests didn't work in the f5 vs code instance so I'm definitely going to look into that shortly

@navdeep5 just warned me that copy+pasting the same schema code from my tests didn't work in the f5 vs code instance (which is weird, since, tests pass with the same schema) so I'm definitely going to look into that shortly

Yeah, it early returns since validSchema is false and contains an error -- so the check does not run. It thinks block_order is not a valid property within nested blocks.

 Should this message be an error instead of a warning? Our BE validation should hard reject this case.

@albchu I had this reflection as well, the problem is that this check also checks that blocks be added to block_order but not having a block in the block_order is not an error, it's just not ideal. Since I have to set the severity for the check, and not for individual cases, I put warning for now. We could consider splitting the checks.


(chocolatey-core.extension) regex pattern vs wildcard pattern usage in Get-AppInstallLocation

(chocolatey-core.extension)  The first parameter for the Get-AppInstallLocation function, $AppNamePattern, is documented/commented to be a "Regular expression pattern" and the function itself uses it as a regex pattern when using the -match operator in its body, BUT Get-AppInstallLocation also calls Get-UninstallRegistryKey, which does NOT use a regex pattern but instead a wildcard pattern.  Regex patterns and wildcard patterns aren't interchangeable like that, however (ex. a regex pattern "Notepad\+\+.*" versus wildcard pattern "Notepad++*").
Expected Behavior
Since Get-AppInstallLocation takes a regular expression pattern (used with -match operator) as its parameter, it shouldn't use other functions or operators that treat that same parameter value as a wildcard pattern (used with -like operator).  Get-UninstallRegistryKey (called by Get-AppInstallLocation) takes a wildcard pattern.  Because of this interchangeable use, unexpected matches or lack of matches may occur when looking for the path.  Errors occur ("ERROR: Bad argument to operator '-match': parsing "Notepad++*" - Nested quantifier +..") when passing in a wildcard pattern into Get-AppInstallLocation because of the use of -match (ex. "Notepad++*").
When passing a regex pattern into the Get-AppInstallLocation method, if a regex is pattern is provided, the calls -like operation used in Get-UninstallRegistryKey will be unexpectedly unmatched.
Possible Solution

Change Get-AppInstallLocation to not call any functions or operators that use wildcard pattern matching, since the parameter in this function is a regex pattern.
I would imagine this would mean maybe adjusting Get-UninstallRegistryKey to have an alternative parameter to pass in a regex pattern instead of a wildcard pattern, then have Get-AppInstallLocation call Get-UninstallRegistryKey with the new regex pattern parameter instead of the default (current) wildcard pattern.  This would allow Get-UninstallRegistryKey to continue to function with existing calls while also supporting an alternative of using regex pattern matching instead of wildcard patterns so that other functions using wildcards could still use the same functions/logic.
Steps to Reproduce (for bugs)

choco install notepadplusplus -y

I'm not sure what exactly is triggering the error I receive (see gist below), but when I attempt to install "notepadplusplus" (which installs "notepadplusplus.install"), I get a bad argument error due to a wildcard pattern being used.  I discovered this issue in Get-AppInstallLocation in investigating that (https://github.com/chocolatey/chocolatey-coreteampackages/issues/782 was submitted in regards to adjusting the notepadplusplus.install package as a seperate fix & PR https://github.com/chocolatey/chocolatey-coreteampackages/pull/783 has also been submitted as a fix localized to the "notepadplusplus.install" package).
Context

This occurred when attempting to install the "notepadplusplus.install" package on a Windows 7 Pro 32 bit machine.
Your Environment

Package Version used: 1.3.1
Operating System and version: Windows 7 Pro (Windows v6.1.7601.65536) (32 bit)
Chocolatey version: v0.10.7
Install/uninstall gist: https://gist.github.com/michaelray/fa3ad48d81026988810923226d86e7bf

Related issue:
https://github.com/chocolatey/chocolatey-coreteampackages/issues/782

Attention!
@ferventcoder or @gep13 could have a more thorough idea about what might not be working correctly.
The feature useRememberedArgumentsForUpgrades could be playing a part in this issue, and could be related to choco issue(s) #797 and #1390
I had a similar problem awhile back, but thinking it was due to being on the windows insider program. I am sorry to report that I didn't think it a issue. My solution on my system was to just disable the feature. Since it  "... is considered in preview ..." Then I ran the command cinst notepadplusplus --x86 -y
Since this has been seen by someone else. I will speculate that this could be possibly due to notepadplusplus  being a meta-package.

Simple solution would be to espace reg ex chars for Get-UninstallRegistryKey. via RegEx.Escape method.

It would be better tho to make all functions work with either globs or regex for consistency.

@RedBaron2 This doesn't seem to be related to the meta-package or the "useRememberedArgumentsForUpgrades" feature since I wasn't using that feature when the issue appeared (gist shows that option set to 'False').
@majkinetor I don't think just escaping the regex chars alone (in Get-AppInstallLocation when calling Get-UninstallRegistryKey) is an effective solution because the issue still remains with calling functions/operations that are using the pattern as a wildcard when it is actually a regex.  If a regex is actually being provided to Get-AppInstallLocation as specified, it will still fail to match expected keys when calling Get-UninstallRegistryKey since the use of -like in Get-UninstallRegistryKey will actually be using it to wildcard match the name of the registry key (for example, if "Software Name.*" is provided in the call to Get-AppInstallLocation (which is a valid regex), the -like wildcard match (in Get-UninstallRegistryKey) will fail to find registry keys that have names like "Software Name (v1.2)" because there is no period after "Name").  Using Regex.Escape would still cause registry key mismatches (and make it match even less than it currently does) because it would add \'s to escape regex, but the wildcard matching would look for those \'s in the actual string value.
Like you said, the fix and ultimate goal would be to make all of the functions work with either globs/wildcard or regex for consistency (probably regex would be better since it is more powerful).  Since just changing Get-UninstallRegistryKey to use a regex alone would not be backward compatible (for packages that are using Get-UninstallRegistryKey directly already, that would be a breaking change), it would be more ideal (to move toward the use of regex without breaking existing calls) to maybe add a new, separate argument to Get-UninstallRegistryKey that accepts a regex pattern and just have Get-UninstallRegistryKey support both regex (new) and wildcard (as it currently does) as a shim until the next major version of chocolatey-core.extension is released, at which point the wildcard matching argument for Get-UninstallRegistryKey can be deprecated.  In the meantime, Get-AppInstallLocation could then be updated to use the new regex-based parameter when calling Get-UninstallRegistryKey so that it properly matches registry key names when using a regex.
It looks like Get-UninstallRegistryKey is getting keys from certain registry locations, then looping through them applying the -like wildcard check against them, so I would think it would be simple enough for it to support both for now by adding a new optional regex argument, which, when used, will override the current wildcard pattern argument and apply a regex -match instead.  Again, once the next major version of chocolatey-core.extension is released, support for wildcard/glob patterns could be deprecated in Get-UninstallRegistryKey.
Doing it that way could seemingly achieve fixing this in a backward compatible way where existing calls using these functions would not break or have behavior changed, while also moving toward using consistent patterns (regex vs wildcard/glob) as extension function parameters.

Chocolatey side - https://github.com/chocolatey/choco/issues/1342

After some thinking I believe globs are probably better to use here even tho regex is more powerful .
Maybe I am wrong but my reasoning is:

Get-UninstallRegistryKey is used way longer then Get-AppInstallLocation
I am even not sure Get-AppInstallLocation is used a lot outside of the core team repo and if it is, its probably always used without regex but with simple search pattern so it would probably not cause any serious problems switching it to globs.
Occasions in which Get-AppInstallLocation progresses later then call to Get-UninstallRegistryKey do not for majority.

https://github.com/chocolatey/chocolatey-coreteampackages/issues/784#issuecomment-313296467
@majkinetor this is probably the best solution here. I thought there was a fix that needed to be done Chocolatey side, but just realized it was in Get-AppInstallLocation.

OK @ferventcoder , will do that.

I think we should close this and related PR #1210 based on my previous comment. It looks like this isn't produce much problems anyway so its tolerable.
Any comments ?

Ideally, I think it would be better to have expected and consistent behavior in these helper methods/APIs, at least as a long term goal.
I'm not as involved in the Chocolatey community as you, though, and if you believe this is not causing any problems and prefer to close this issue, I'm fine with that.
The original issue came up when installing the Notepad++ package, but that issue has been resolved on that end via PR https://github.com/chocolatey-community/chocolatey-coreteampackages/pull/783 .  This isn't actively causing me any issues now, but I just wanted to make sure this was reported.


Fixing 3 typos (spaces missing or superfluous)

Microsoft Teams For Government(
Project Online Desktop Client For Government(
Microsoft Stream For Office 365 E3 (9e700747-8b1d-45e5-ab8d-ef187ceec15 6)

missing spaces or superfluous space

@DEberhardt : Thanks for your contribution! The author(s) have been notified to review your proposed change.


feat(electron): build now works

:tada: This PR is included in version 1.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: