Check Existence

Hello.
I tried to use fetch() to check for existence, but it doesn't worked, any ideas?
// Doesn't work, neither callback dispatches
calls.find({ from: 'hnordt' }).fetch()
  .subscribe(r => console.warn(r), e => console.error(e))

A work-around is using the final callback with a local variable like this:
let foundCall = false;
calls.find({ from: 'hnordt' }).fetch()
  .subscribe(() => { foundCall = true; console.log("Call existed"); }, (e) => console.error(e), () => {
    if (!foundCall) {
      console.log("Call did not exist");
    }
  });

We should come up with an API for providing a nicer way of detecting non-existence.
Maybe find should call the result callback with null if no row exists?

@danielmewes that would be what I expected initially. Awesome.

I think this is the best way to do it. We could potentially return null, but I think this works better with observable operators. For example, if you do
require('rxjs/add/operator/isEmpty')

calls.find({ from: 'hnordt' }).fetch().isEmpty().subscribe(
 empty => console.log('It was', empty? ' ' : ' not', 'empty')
)

Oh I forgot there were all those nice Observable operators.
One point in favor of generating a null is that it makes it easier to throw an error if a document should exist but doesn't.
@deontologician Is there an option to "split" an Observable stream? Like what if I want to use the result, but do something different if it's empty?

@danielmewes .partition() will split an observable sequence into two observable streams based on some condition. There's also .defaultIfEmpty() which is probably the way to go in this case.

Cool, defaultIfEmpty() sounds like what I wanted. We should probably add an example with that do our docs.
@hnordt Does that satisfy your use case?

@danielmewes yes, thank you!


Issue with the Captcha.  Repeats constantly.

I have changed the captcha version from V2 to V3.
Now we don't face the repeats circle.


Takeoff in mission: Vehicle rises unlimited

@AndreasAntener @sanderux @tumbili If I take off in SITL from the ground using a mission (NO GAMEPAD! SWITCH TO MISSION, THEN ARM!) the vehicle raises uncontrolled and never switches to to flying to the actual waypoint.

The mission item here https://github.com/PX4/Firmware/blob/master/src/modules/navigator/mission_block.cpp#L65 seems to be initialized with nan values in SITL, but not on hardware. This breaks the takeoff check. I changed this in the mission update and will make a PR to master in a sec.

The zero might be an issue. The braces should be empty.

Same problem with empty braces. But there is definitely something wrong with the init, or the memcpy from mission reading. I get different random values on different branches (2 branches where the mission item struct is different).
For example: next item 22, rel 1, lat 47.3669, lon 8.5498, alt 25.00, yaw 0.00, loirad 0.00, loidir -1, rad nan, tin<PHONE_NUMBER>57085407282649366528.00, pmin 0.26, auto 1, origin 0, jmi 2121728, jrc -742746624, jcc 0, p1 0.00, p2 0.00, p3 -0.00, p4 0.00, p5 0.00, p6 0.00, p7 0.00

is https://github.com/PX4/Firmware/issues/3685 related to this?
i get different values depending on what sitl model i use (gazebo or gazebo_standard_vtol)

On current master i can not reproduce this. I have tried;

make posix_sitl_default jmavsim
make posix_sitl_default gazebo
make posix_sitl_default gazebo_standard_vtol
make posix_sitl_default gazebo_tailsitter

I'm on gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4

Is this maybe just related to OSX and struct alignment?
Debugging mission items with master gives me the following values after reading the first item:
WARN  next item 22, rel 1, lat 47.3669, lon 8.5498, alt 25.00, yaw 0.00, loirad 0.00, loidir -1, rad nan, tin 0.00, pmin 0.26, auto 1, origin 0, jmi 2121728, jrc 174511104, jcc 0, p1 0.00, p2 0.00, p3 -0.00, p4 0.00, p5 0.00, p6 0.00, p7 0.00

Note the "rad nan"
After changing the mission_item_s struct (using different datatypes), I get the following output for the same mission item after reading:
WARN  next item 22, rel 1, lat 47.3669, lon 8.5498, alt 25.00, yaw 0.00, loirad 0.00, loidir -1, rad -39614680997675493241714114560.00, tin 0.00, pmin 0.26, auto 1, origin 0, jmi 816840704, jrc -1845379908, jcc 0, p1 0.00, p2 -0.01, p3 0.00, p4 0.00, p5 0.00, p6 0.00, p7 0.00

(I deleted the dataman file in between)

Fixed on master.


add new seeds

Running on targets other than process_message generated a bunch more seeds than I expected. I'll try to follow the directions on #18 to make it more manageable.

Are the seeds already merged? https://github.com/bitcoin-core/qa-assets/pull/36/files

@MarcoFalke 5937cbd is now merged.


NullPointerException

https://gist.github.com/ziceptor/bbbe2f2ef6895b4b9a491901142f4fdf
forge-1.11.2-<IP_ADDRESS>7-universal.jar
spongeforge-1.11.2-2227-6.0.0-BETA-2275.jar
griefprevention-1.11.2-<IP_ADDRESS>9.jar
LuckPerms-Sponge-3.1.7.jar

This shouldn't be an issue with latest builds.


Support for database diagram

Okay, so here's the idea which I'll try to implement (as it is one of features my mentor requests me to do, and I guess it would be really nice one to have!). I was thinking of making database diagramming component which would produce database visualization based on database tables, views and their references (primary and foreign keys! -> this will need some smaller extension of back-end API). The idea is to spit out simple HTML tables connected with related tables. Furthermore, user would be able to reopen diagram once it's already generated (so some simple JSON with coordinates would be created upon generating diagram). I was searching around for suitable library and found JointJS and JS-graph-it to be probably the best choice for this use case. Both mentioned libraries have things we need - simple API, connecting custom HTML elements (which would be our tables/views), draggable nodes and connections. Of course, if anyone has better library to propose, please do.
TL;DR: I'll try to build support for creating database diagrams and storing them so user can reopen already existing diagrams.
EDIT: Think I'll go with JointJS as it is hosted on npm, supports nesting children elements inside of a parent (i.e. each table is a parent element with sub elements for each attribute), offers a rich API and supports graph export to JSON and reading it from JSON, so persisting the graph object should be trivial.

@maxcnunes @krolow @esnunes : All suggestions and opinions are welcome!

This would be an awesome feature. Not sure which library is the best for ERD diagramas. Seems like JointJS has a better documentation/support. I have found this GoJS (erd example http://gojs.net/latest/samples/entityRelationship.html). But I am not sure it is free.

GoJS is $1350 per developer :smile:  But no worries, I think JointJS has everything necessary to customly build simple ERD diagram. Will give it a try!

UPDATE:
After including latest changes in sqlectron-core, this is what I got so far:

It's working on live data! (on picture it's some sample database I had locally)
Most time it took me debugging JointJS in modal window, but it works smooth now. Diagram is generated on clicking database context menu option. Since every diagram needs columns and links, I call fetchColumnsIfNeeded for every table included. Since it takes some time, here's what I was thinking in implementing next:

Upon right click modal would be shown up asking user to select which tables he wants to include on diagram (with 'Select All' option available). This is because it might not work proper on much bigger databases with > 100 tables. Furthermore, sometimes because of pure simplicity one only wants some of the objects included on diagram.

After user selects tables and views he wants to include on diagram, loading spinner would show up until all needed data is fetched. Then diagram would be rendered in the same modal window.

Also changes I've in mind:

Further enhancements on diagram looks.

Storing and opening previously generated diagrams.

Exporting graph to SVG. Check out if there is possibility to export graph to PNG or some other picture format.

It is looking pretty cool. I agree with all your suggestions of implementation. They seem the right approach.

@BornaP
This is awesome. I was thinking about doing type of functionality last week.
I was wondering if you have thought about how the ERD auto layout works ? Not many people have heard of the concept of "Crows feet up" in ERDS, but i have found it to work wel with every DB schema i have worked on. Essentially it means that the things you are referencing are located on the page above the other tables.
So any lookup / enum style table like "Countries" would be above "User" tables, because Users has a FK to Countries.
The layout logic needs to counts the FK for each table and the interdependencies, and then it can work out whats above others.
Horizontal layout i am not sure about.
The othr way to do this is totally disregard the auto layout feature, and let devs do it how they like, but to allow saving of the layout.
If a new table is added, then it just slapped in the center in front of others. This is what SQL Server does or example ( many moons ago).

Hey @joeblew99 ,thanks for the feedback. The 'other way' you have mentioned is actually currently implemented (the SQL Server way) in the master. New tables are added in front of the others, so devs can move them as they like and SAVE the layout. This is fully resolved with #192 .
I'm don't think first approach you mentioned would be good in our case as it might make use of 'paper' badly, because there might be lots of scroll vertically and lot of empty space horizontally. That's why I think its the best to let developers move tables and joints (arrow might be moved around the table and links can be pulled on any point you like). Just makes user move flexible and a lot of them are used to this because SQL Server studio does the similar thing :)
Currently I'm still working on this, next thing is marking PR and FKs on the table, enabling export to SVG and 'add related tables' feature which would enable user to add tables that current table has references to. This would provide easy way to check referential integrity constraints. I plan on finishing this withing the week, I'll keep you update on this issue.

Sounds good . All of it.
What about saving the view, ? Json format is fine.
You could save the view in the a tual dB.
On Sun, 12 Jun 2016, 09:56 Borna Perak<EMAIL_ADDRESS>wrote:

Hey @joeblew99 https://github.com/joeblew99 ,thanks for the feedback.
The 'other way' you have mentioned is actually currently implemented (the
SQL Server way) in the master. New tables are added in front of the others,
so devs can move them as they like and SAVE the layout. This is fully
resolved with #192 https://github.com/sqlectron/sqlectron-gui/pull/192 .
I'm don't think first approach you mentioned would be good in our case as
it might make use of 'paper' badly, because there might be lots of scroll
vertically and lot of empty space horizontally. That's why I think its the
best to let developers move tables and joints (arrow might be moved around
the table and links can be pulled on any point you like). Just makes user
move flexible and a lot of them are used to this because SQL Server studio
does the similar thing :)
Currently I'm still working on this, next thing is marking PR and FKs on
the table, enabling export to SVG and 'add related tables' feature which
would enable user to add tables that current table has references to. This
would provide easy way to check referential integrity constraints. I plan
on finishing this withing the week, I'll keep you update on this issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sqlectron/sqlectron-gui/issues/165#issuecomment-225415698,
or mute the thread
https://github.com/notifications/unsubscribe/ALcacx5LUdud682fhJPpY9M-gJ-4FVFBks5qK7ulgaJpZM4Ikd_b
.

I'm not sure I quite understand you. We're already saving the whole diagram into a JSON as a file, so that user can load it from file. All tables, links (their 'view') and their positions are saved, actually whole SVG is saved and you can manipulate the diagram when you open it as you want.
I don't think there is a need to save a diagram into a actual database, as this application uses none. This is primary SQL editor. If someone wants to save JSON into DB he can do it manually after save :)

ah did not see that - awesome stuff :)

i wil try it out.

Since the feature was implemented with #189 and further enhanced with #192 , #194 ,#195 and #198 , I'll close the issue. Further enhancements or possible bugs should be discussed in their own issues.


Do not include inactive services in calculation for dashboard

I noticed that the calculations at the dashboard (ram, storage, prices etc.) account inactive services too. It makes more sense to me if inactive services are excluded from the dashboard so one can get a quick overview over the current sitation and not for everything that is in the database.

Good pick up. I had a look and from what I can see the only one that includes inactive is the pricing.
I can get around to fixing this soon

It could also be a cache issue if you find this effects the specs

Good pick up. I had a look and from what I can see the only one that includes inactive is the pricing. I can get around to fixing this soon

Yes, it's the pricing only apparently.

Should be fixed now
https://github.com/cp6/my-idlers/commit/171eb63b9aecfc96a700ca287b3c84532ac54c29

It actually does not seem that this issue is resolved.
I am still seeing inactive services included in the pricing.


minor changes (removes commented out code and print statements) and f…

…ixes one test

and adds some documentation..


Nested Sweeping

Initial version of the Nested Sweeping framework together with its use in bdd_exists, bdd_forall, and zdd_project. What is left are:

Statistics
Optimisations for edge cases
Partial Quantification (independent of Nested Sweeping.

The decrease in coverage seems be due to the following things

Quantification Algorithms

We do not hit the external memory case for the nested sweeps of quantify.
We do not hit the unreachable default cases.

Nested Sweeping Framework

We do not hit either of the bucketed cases in down__sweep_switch(...), inner::up(...), nor in nested_sweep(...)
We do not hit the external memory version of __reduce_level inside of __nested_sweep(...).
We do not hit the std::max(terminal_stop_level, outer_roots_stop_level) case of the stop_level ternary.
We do not seem to hit the outer_pq_decorator.push(arc(node::ptr_t::NIL(), reduction_rule_ret)); line.


SLC resolution

Hi all!
I was wondering how best to include sar:resolution_range & sar:resolution_azimuth for SLC data as it is dependent on the incidence angle as listed here. The example provided in this repository is only for GRD, which is of course more straightforward.
The description says "maximum ability to distinguish two adjacent targets", so in this case it would be the best resolution for a given range. However, I think this would be misleading for users who are not familiar with GRD and SLC resolutions.

We use the best resolution of the maximum for range or azimuth of the entire scene. For Sentinel 1 for instance, here is our logic along with an example:
private double GetGroundSampleDistance(string pt, string mode, string res)
        {
            if (pt == "RAW") return 0;
            if (pt == "GRD")
            {
                if (res == 'F' && mode == "SM") return 9;
                if (res == 'H')
                {
                    if (mode == "SM") return 23;
                    if (mode == "IW") return 22;
                    if (mode == "EW") return 50;
                }
                if (res == 'M')
                {
                    if (mode == "WV") return 25;
                    return 40;
                }
            }
            if (pt == "SLC")
            {
                if (mode == "SM") return 4.9;
                if (mode == "IW") return 22;
                if (mode == "EW") return 43;
                if (mode == "WV") return 4.8;
            }
            if (pt == "OCN") return 20000;

            return 0;
        }

https://gist.github.com/emmanuelmathot/3d210fb95adf86e4f4ea2a52bb09e7eb

In the card4l extension both sar:resolution_range and sar:resolution_azimuth are being used. Since the latest update in the related specification documents, it is required to provide both per beam ID. No matter if SLC or GRD.
I assume adjusting these fields is not so easily done, as @m-mohr has mentioned in another context already. I'm not sure how best to further procede with this, but I thought it makes sense to connect this issue with https://github.com/stac-extensions/card4l/issues/14 as a first step.


Inconsistency between behavior and documentation: fault_livespan = 0

According to https://github.com/Fraunhofer-AISEC/archie/blob/master/fault-readme.md#fault_lifespan , "fault_lifespan" + "trigger_address" must be larger than, or equal to "0" if "trigger_address" is negative, otherwise ARCHIE will issue a warning and remove the fault:

If the trigger_address is set to a negative number, trigger_address + fault_lifespan must be larger or equal to 0. Otherwise ARCHIE will remove the fault configuration with a warning. In addition, the fault_lifespan is automatically reduced if the trigger address is calculated to be before the start point.

However, with this fault.json I don't see any warning although "trigger_address" is negative and "trigger_address" + "fault_lifespan" < 0:
{
  "max_instruction_count" : 1000,
	"start" : {
		"address" : 0xffff0000,
		"counter" : 0
	},
	"end" : {
    "address" : 0xffff06b0,
		"counter" : 0
	},
	"faults" :[
			[
				{
					"fault_address"		: [0xffff47C8, 0xffff4888, 4],
					"fault_type"		: "instruction",
					"fault_model"		: "overwrite",
					"fault_lifespan"	: [0],
          // fault_mask = bytes to insert: ARMv7 NOP
					"fault_mask"		: [0xE320F000],
					"trigger_address"	: [-1],
					"trigger_counter"	: [0],
					"num_bytes"		: [4]
				}
			]
		],
}

Also, it seems both "fault_lifespan" and "fault_livespan" are used throughout the code/documentation and examples. This is rather confusing.
Regards,
Robert

Hello Robert,
fault_livespan and fault_lifespan are the same thing. It is a typo which we patch out. Where did you encounter this typo? I thought i had corrected all occurrences.
In regards of the behaviour of trigger_lifespan:
If fault_lifespan is set to 0, it is a permanent fault, therefore fault_lifespan calculations are not performed.  From the documentation this is stated ambiguous. Would changing the documentation to "If the trigger_address is set to a negative number and fault_lifespan non zero," make it clearer for you?


Added TeamMemberSettings and TeamGuestSettings

Pull Request (PR) description
Added TeamsMemberSettings and TeamsGuestSettings
This Pull Request (PR) fixes the following issues

Codecov Report

Merging #58 into Dev will increase coverage by 0.03%.
The diff coverage is 94.39%.

@@            Coverage Diff             @@
##              Dev      #58      +/-   ##
==========================================
+ Coverage   93.92%   93.95%   +0.03%
==========================================
  Files          14       16       +2
  Lines        1234     1341     +107
  Branches        1        1
==========================================
+ Hits         1159     1260     +101
- Misses         74       80       +6
  Partials        1        1

Impacted Files
Coverage Δ

...FT_TeamsGuestSettings/MSFT_TeamsGuestSettings.psm1
93.87% <93.87%> (ø)

..._TeamsMemberSettings/MSFT_TeamsMemberSettings.psm1
94.82% <94.82%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5ec8ee...83dc52a. Read the comment docs.


Textual replacement of exports.blabla in client code doesn't scale

This code
var foo = function ()
{
	var exports = {}
	exports.bar = function () {}
	return exports
}

alert(foo().bar)

when put to /client/foo.js, translates to:
if (typeof(SS.client.foo) == 'undefined') SS.client.foo = {};
var foo = function ()
{
	var exports = {}
	SS.client.foo.bar = function () {}
	return exports
}
alert(foo().bar)

and starts unexpectedly printing undefined instead of [Function].
Proper modules as per #69 or similar approaches will fix such bugs easily without a need to implement a full ECMAScript parser.

I have been working on a new solution for SocketStream 0.3 which does away with the textual replacement problem altogether. Closing this now, but thanks for raising.


atom-environment.js is error when starting Atom via xrdp

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
I using atom on linux mint OS via xrdp.
atom-environment.js is error when atom starting:
Uncaught TypeError: Cannot read property 'addWarning' of undefined
 /usr/share/atom/resources/app.asar/src/atom-environment.js:335

but after, that I can use atom without problems.
Steps to Reproduce

install atom
run it

Actual behavior: [What actually happens]
Developper Tool open in atom and show the error message.
Reproduces how often: [What percentage of the time does it reproduce?]
100%
Versions
$ apm -v
apm  1.14.1
npm  3.10.5
node 4.4.5
python 2.7.12
$ atom --version
Atom    : 1.13.1
Electron: 1.3.13
Chrome  : 52.0.2743.82
Node    : 6.5.0

OS : Linux Mint 18 MATE 64bit
xrdp : 0.6.1
vnc : TigerVNC 1.7.80
Additional Information
Error does not occur with super user command
$ su atom

Can you give some information about xrdp and what it is please?  In addition, how did you install Atom?

xrdp info
xrdp is open source remote desktop protocol server.
here to detail -> http://www.xrdp.org/
Atom install step

download atom-amd64.deb from Atom.io -> https://atom.io/
sudo dpkg -i atom-amd64.deb

Thanks for reaching out!
While we understand that this is a valid and useful use case. This isn't something that we're going to have the resources to investigate and correct by ourselves anytime soon. Since the maintainer team isn't going to be able to work on it and we're trying to use the open issues list as our backlog, I'm going to close this.
We would accept a well-written PR for this functionality, so I've labeled this as help-wanted. Hopefully someone from the community will be able to help with a solution.

thank's for your action!


Missing dependency in Maven Central

Problem
Using pf4j causes Failed to load class "org.slf4j.impl.StaticLoggerBinder" Error
Cause
The POM file in Maven Central is missing the slf4j-simple dependency
Workaround
Manually include slf4j-simple version 1.7.5 into your project.

Can you tell me what PF4J version you use?

Yes, I'm using 0.11.0, which seems to be the newest one available on mvn central

The idea is that PF4J use only slf4j-api to produce (log) events. In your application you must use a slf4j concret implementation. You can choose from slf4j-simple, slf4j-log4j, logback. java.util.logging, ... (see http://www.slf4j.org/ for a full list). In my opinion your issue is not a bug because you must choose a concrete implementation of slf4j in your application. I cannot add slf4j-simple as dependency because in my projects I use slf4j-log4j and someone maybe works with slf4j-logback.
Make sense for you?

Yes, this makes perfect sense. However, there may occur problems with different versions.
Currently, you use version 1.7.5 of slf4j-api.
So, as soon you update that version in pf4j, users (that change to newer versions of pf4j) need to update their version of slf4j implementation as well (if the api changes).
It somehow breaks the dependency management idea that every package manages all of it's own dependencies.
In my project I use plain java.util.logging, so I had no slf4j installed. The problem I had, is that due to that, pf4j was very silent and I was unable to detect bugs.
The basic issue is that you can never know, which logging library a user might use. And not logging anything in case the user has not included slf4j is somewhat irritating.
However, I don't know how other libraries handle this issue..

I think that it's not a problem if you use other sl4j version in your pom.xml.
If you don't have a slf4j implementation in your application then slf4j throws a gentle and informative message in console. So, based on that message you know that you must add a concrete slf4j implementation in your application.
I prefer to use a simple facade (abstraction) for various logging frameworks because for this 26KB (the size of slf4j-api) you offer a freedom to use their desired logging framework.


Eliah Kagan: Watch shellshockgame.tk

Eliah Kagan requests the watch of the watch_keyword shellshockgame\.tk. See the MS search here and the Stack Exchange search here.

shellshockgame\.tk has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Shree in Charcoal HQ


chore(Deps) actions/upload-artifact action to v4

This PR contains the following updates:

Package
Type
Update
Change

actions/upload-artifact
action
major
v3 -> v4

Release Notes

actions/upload-artifact (actions/upload-artifact)
v4
Compare Source

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

🦙 MegaLinter status: ✅ SUCCESS

Descriptor
Linter
Files
Fixed
Errors
Elapsed time

✅ COPYPASTE
jscpd
yes

no
1.14s

✅ CSS
stylelint
1
0
0
1.36s

✅ JAVASCRIPT
standard
1
0
0
1.58s

✅ JSON
eslint-plugin-jsonc
3
0
0
3.48s

✅ JSON
npm-package-json-lint
yes

no
0.6s

✅ JSON
prettier
3
0
0
0.32s

✅ JSON
v8r
3

0
10.96s

✅ MARKDOWN
markdownlint
8
0
0
0.52s

✅ MARKDOWN
markdown-link-check
8

0
1.59s

✅ MARKDOWN
markdown-table-formatter
8
0
0
0.34s

✅ REPOSITORY
gitleaks
yes

no
0.15s

✅ REPOSITORY
git_diff
yes

no
0.01s

✅ REPOSITORY
grype
yes

no
11.92s

✅ REPOSITORY
secretlint
yes

no
1.37s

✅ REPOSITORY
trivy
yes

no
6.57s

✅ REPOSITORY
trivy-sbom
yes

no
1.78s

✅ YAML
prettier
3
1
0
0.76s

✅ YAML
v8r
3

0
5.68s

See detailed report in MegaLinter reports
MegaLinter is graciously provided by

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


MWPW-134545 Move in E2E Tests

The goal is to have a single repo for prod and test code
Devs can run E2E tests easily on a local machine and familiarize test scenarios
GitHub Actions workflow can trigger E2E tests in this repo
This PR is a groundwork. More relocation and reorganization of E2E tests may be needed
README will be updated later after merging

FYI only, the E2E tests in Platform-UI-DC repo did not run successfully.
https://github.com/adobecom/dc/actions/runs/5892491838/job/15981889177
 "message" : "Project not found"
 HTTP Status 401 – Unauthorized
I noticed that the PR was made from a fork, which may not have access to the base repo's secrets.
Secret source: None
cc @TsayAdobe


Bug azure-identity version 1.11.0 vs 1.10.0

Package Name: azure-identity
Package Version: 1.11.0
Operating System: Linux (https://github.com/Azure/azure-functions-docker/blob/dev/host/4/bullseye/amd64/python/python39/python39-core-tools.Dockerfile)
Python Version: 3.9

Describe the bug
Version 1.10.0 of azure-identity works great DefaultAzureCredential works great, but after updating to 1.11.0 it fails when using it to access keyvault. See example bellow.
To Reproduce
Steps to reproduce the behavior:
Using (https://github.com/Azure/azure-functions-python-library and the docker file https://github.com/Azure/azure-functions-docker/blob/dev/host/4/bullseye/amd64/python/python39/python39-core-tools.Dockerfile)
Use AZ LOGIN to login
        credential = DefaultAzureCredential()
        key_client = SecretClient(
            vault_url= "********",
            credential=credential
        )
        print(key_client.get_secret("*****").value)

Expected behavior
Be able to login
Screenshots
Exception has occurred: ClientAuthenticationError       (note: full exception trace is shown but execution is paused at: _run_sync_func)
DefaultAzureCredential failed to retrieve a token from the included credentials.
Attempted credentials:
	EnvironmentCredential: EnvironmentCredential authentication unavailable. Environment variables are not fully configured.
Visit https://aka.ms/azsdk/python/identity/environmentcredential/troubleshoot to troubleshoot.this issue.
	ManagedIdentityCredential: ManagedIdentityCredential authentication unavailable, no response from the IMDS endpoint.
	SharedTokenCacheCredential: SharedTokenCacheCredential authentication unavailable. No accounts were found in the cache.
	VisualStudioCodeCredential: The current credential is not configured to acquire tokens for tenant [REMOVED]. To enable acquiring tokens for this tenant add it to the additionally_allowed_tenants when creating the credential, or add "*" to additionally_allowed_tenants to allow acquiring tokens for any tenant.
To mitigate this issue, please refer to the troubleshooting guidelines here at https://aka.ms/azsdk/python/identity/defaultazurecredential/troubleshoot.

Additional context
I have tried clearing login, using az extension in vs code to login, a lot of work arounds tried but nothing works. The only fix is to switch to 1.10.0

@pvaneck
That seems to fix the issue, thank you!
How do I see what the default tenant is assigned to my DefaultAzureCredential()? How to set my default tenant in code?

Each credential type has a different way of determining the tenant ID. For example, EnvironmentCredential will check for the AZURE_TENANT_ID envvar. AzureCliCredential will check for the tenant of the current logged in user (az account show).
As you can probably see by the error message, DefaultAzureCredential is going through an authentication flow, successively checking different credentials until one works. However, because of the multi-auth breaking change, when VisualStudioCodeCredential is checked, the flow is halted due to the ClientAuthenticationError. This is likely raised because the tenant ID is defaulting to the special ID "organizations" unless you have "azure.tenant" in your vscode settings,json set as the correct tenant ID.
Ideally, we'd just continue on with the flow, but even if you were logged in via Azure CLI, due to the flow order and premature halting, the CLI credentials are never checked (as VSCodeCred is checked before AzureCliCred). There is current ongoing discussion about changing the behavior of DAC to always continue the flow despite an error being raised by a checked credential.
VisualStudioCodeCredential has a few issues right now due to implementation changes in the VS Code Azure Account extension. The next azure-identity release will remove it from the DAC token chain until we can get it properly working again. This will help alleviate some of the pain points for users trying to use DAC with the Azure CLI.
In the meantime, I will add an additional troubleshooting entry to the DAC troubleshooting section regarding this VSCodeCred shenanigans.

Thank you for the explanation.

@nicolaschaillan It's possible you have have environment variables configured (i.e. AZURE_CLIENT_ID, AZURE_CLIENT_SECRET, AZURE_TENANT_ID, etc.), but those credentials are invalid which causes a ClientAuthenticationError and halts the DefaultAzureCredential flow. This was by design in order to surface possible misconfigurations/errors to the user because if those envvars are set, it is assumed that the user wants to use them. If your intention is not to use them, then you can try unsetting one of the checked envvars like AZURE_CLIENT_ID. This should then cause EnvironmentCredential to be skipped and the next credentials in the DefaultAzureCredential flow to be checked.


Vertaisarviointi

19.30 14th June 2023
The project is overall in good shape. It already has extensive and detailed documentation. On my laptop the project seemed to work as expected. User interface is extensive and has a lot of details on how to use the program. Making the UI a bit more simple could maybe enhance usability, but also that would cause diminishing of the thoroughness of the program, so it might be just fine the way it is at the moment. On the code level, it was easy to follow what each function etc. is responsible for as variable names are proper. I think the project is great and the idea has been successfully implemented. Just add a release to this project once it is ready. Great job!

Thanks


Attempt to handle Issue #53

One of the inner Lin Kernighan loops gets hanged forever when the incoming distance matrix has only two nodes.
This seems to happen regardless of the matrix being symmetric or asymmetric.
In this pull request I setup a test that should pass once the bug has been solved.
I leave the rest to @luanleonardo to handle it properly.

suggestion: @fillipe-gsm, the Lin-Kernighan heuristic assumes the existence of at least 4 nodes (named a, b, c, d) that play important roles in defining the neighborhood of a solution. If the problem is small, with less than 4 nodes, the heuristic does not apply. In this case, it is preferable to solve the problem using brute force.
I committed this suggestion, what do you think? If it's ok for you, I suggest merging the PR.


refactor stream output and progress bars (part 1)

motivation: continue cleanup work, fixing issues when diagnositics output ay interleave with deelgates writing directly to the output or reportig progress
changes:

change ToolWorkspaceDelegate to use provided  output and progress handlers instead of wirting to OutputStream directly
add print and progress handlers to SwiftToolObservabilityHandler, including a serial queue to maange the sequence of outputing to the output stream
adjust tests to wait on diagnostics when necessary given the queue setup

@swift-ci smoke test

@swift-ci smoke test


Use typeof(DllModule).Assembly for faster resolution

Now that ActivationFactory is in WinRT.Runtime, we can use typeof(Foo).Assembly for faster resolution.

On a related note, this is possible a change in behavior? Does it matter what Assembly we pass here?

On a related note, this is a change in behavior from the ActivationFactory PR. Does it matter what Assembly we pass here?

"this is a change in behavior from the ActivationFactory PR. Does it matter what Assembly we pass here?"

Yeah I think that PR did change the behavior there. I can't really imagine what difference that would make though, other than... Maybe like, you have an app that's dynamically loading some plugin .dll that's in some other folder, and that .dll tries to activate some WinRT type that's in a .dll that's next to that .dll, and not to your app's .dll? Not sure if that matters? 🤔

"this is a change in behavior from the ActivationFactory PR. Does it matter what Assembly we pass here?"

Yeah I think that PR did change the behavior there. I can't really imagine what difference that would make though, other than... Maybe like, you have an app that's dynamically loading some plugin .dll that's in some other folder, and that .dll tries to activate some WinRT type that's in a .dll that's next to that .dll, and not to your app's .dll? Not sure if that matters? 🤔

Yea I can see maybe some plugin scenarios being impacted.  Will need to monitor for any failures or reports.  The change to AppContext.BaseDirectory from several releases ago was more likely to run into similar issues here but never got any reports there.


Set Mutations

Solved and added to the Repo : https://github.com/jarvismayur/Hackerrank-Problem-Solutions/blob/main/Python/Set Mutations/Set_Mutations.py


[Bug]: false value cant be quoted

Version

Karpenter: 0.13.2

Kubernetes: v1.22
Server Version: version.Info{Major:"1", Minor:"22+", GitVersion:"v1.22.10-eks-84b4fe6", GitCommit:"cc6a1b4915a99f49f5510ef0667f94b9ca832a8a", GitTreeState:"clean", BuildDate:"2022-06-09T18:24:04Z", GoVersion:"go1.16.15", Compiler:"gc", Platform:"linux/amd64"}
Expected Behavior
trying to enable AWS_ENI_LIMITED_POD_DENSITY via env var
Actual Behavior
issue with quoting
module.base_system.module.karpenter[0].module.eks_blueprints_kubernetes_addons_karpenter.module.helm_addon.helm_release.addon[0]: Still modifying... [id=karpenter, 20s elapsed]

Error: failed to replace object: Deployment in version "v1" cannot be handled as a Deployment: v1.Deployment.Spec: v1.DeploymentSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.Containers: []v1.Container: v1.Container.Env: []v1.EnvVar: v1.EnvVar.Value: ReadString: expects " or n, but found f, error found in #10 byte of ...|,"value":false}],"im|..., bigger context ...|}},{"name":"AWS_ENI_LIMITED_POD_DENSITY","value":false}],"image":"public.ecr.aws/karpenter/controlle|...

  with module.base_system.module.karpenter[0].module.eks_blueprints_kubernetes_addons_karpenter.module.helm_addon.helm_release.addon[0],
  on .terraform/modules/base_system.karpenter.eks_blueprints_kubernetes_addons_karpenter/modules/kubernetes-addons/helm-addon/main.tf line 1, in resource "helm_release" "addon":
   1: resource "helm_release" "addon" {

Steps to Reproduce the Problem
module "eks_blueprints_kubernetes_addons_karpenter" {
  source = "git::ssh://git@github.com/aws-ia/terraform-aws-eks-blueprints.git//modules/kubernetes-addons/karpenter?ref=v4.5.0"
  # source = "git::ssh://git@github.com/aws-ia/terraform-aws-eks-blueprints.git//modules/kubernetes-addons/karpenter?ref=main"

  # enable_aws_node_termination_handler = true
  helm_config = {
    cleanup_on_fail = true
    force_update    = true
    replace         = true
    version         = var.karpenter_helm_config_version
    set = [
      # {
      #   name  = "logLevel"
      #   value = "debug"
      # },
      {
        name  = "hostNetwork"
        value = "true"
      },
      {
        name  = "controller.env[0].name"
        value = "AWS_ENI_LIMITED_POD_DENSITY"
      },
      {
        name  = "controller.env[0].value"
        value = "false"
        type  = "string"
      },
    ]
  }
  addon_context = var.addon_context
}

tried a few combinations to quote and escape false but it either fails or when it works, leaves the wrong value in the Deployment
      {
        name  = "controller.env[0].value"
        value = "\"false\""
        type  = "string"
      },

this applies
but then looks like this:
    spec:
      containers:
      - name: controller
        image: public.ecr.aws/karpenter/controller:v0.13.2@sha256:af463b2ab0a9b7b1fdf0991ee733dd8bcf5eabf80907f69ceddda28556aead31
        ports:
        - name: http-metrics
          containerPort: 8080
          protocol: TCP
        - name: http
          containerPort: 8081
          protocol: TCP
        env:
        - name: CLUSTER_NAME
          value: fernando-rare-anchovy
        - name: CLUSTER_ENDPOINT
          value: https://8F0612BE376069E8F02961CDADE488AF.gr7.us-east-1.eks.amazonaws.com
        - name: KARPENTER_SERVICE
          value: karpenter
        - name: SYSTEM_NAMESPACE
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: metadata.namespace
        - name: AWS_ENI_LIMITED_POD_DENSITY
          value: '"false"'
        resources:
          limits:
            cpu: "1"
            memory: 1Gi
          requests:
            cpu: "1"
            memory: 1Gi

trying to enable AWS_ENI_LIMITED_POD_DENSITY via env var

Do you mean you are trying to disable it by setting it to false? It seems to be enabled by default.

This doesn't seem like it's a Karpenter issue in the sense that as long as you pass that env variable correctly to Karpenter it would work.
Could be a problem with either Terraform itself or the Terraform module you are using.
Out of curiosity, why are you trying to disable this? Are you trying to get less than 110 pods per node?
Also some other values to try in case you have not already: {0,-1,False, FALSE, 'false', "false", `false"}

Out of curiosity, why are you trying to disable this? Are you trying to get less than 110 pods per node?

following karpenter docs
https://karpenter.sh/preview/tasks/pod-density/#networking-limitations

Also some other values to try in case you have not already: {0,-1,False, FALSE, 'false', "false", `false"}
i did try ´0´ with no luck.

the module I'm using maintainer confirmed there is some issue with their merging stage of values.
so maybe that is the root cause
https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/793#issuecomment-1192961691


[Do Not Merge] Change Nexus URL's to point to Artifactory

This change points the nexus URL's to Artifactory artifacts
I will open a Jira issue and add FAB numbers later
Signed-off-by: Brett Logan<EMAIL_ADDRESS>

LGTM

/ci-run

/azp run


Page build error

I have been getting the following error when I try to build me web page:
Permission to kakawait/hugo-tranquilpeak-theme.git denied to blh5yb.
fatal: unable to access 'https://github.com/kakawait/hugo-tranquilpeak-theme.git/': The requested URL returned error: 403
I tried initializing the theme using the git submodule init and git submodule update commands, but the page still failed to build

Please use http://discuss.gohugo.io/ for questions/troubleshooting. Also see  Hugo Documentation.


”Racșa” is listed in the drop-down menu

Description:
"Racșa" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Racșa" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Racșa, SATU MARE".


[google_sign_in_web] renderButton broken in master

Steps to reproduce
Attempt to renderButton
Expected results
The Google SignIn renders.
Actual results
[GSI_LOGGER-TOKEN_CLIENT]: Instantiated.
Error: Assertion failed:
file:///usr/local/google/home/dit/.pub-cache/hosted/pub.dev/google_sign_in_web-0.12.3/lib/src/flexible_size_html_element_view.dar
t:109:12
root != null
"DOM is not ready for the FlexHtmlElementView"
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 328:3  throw_
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 38:3   assertFailed
packages/google_sign_in_web/src/flexible_size_html_element_view.dart 109:16  [_registerListeners]
packages/google_sign_in_web/src/flexible_size_html_element_view.dart 127:13  <fn>
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54           runBody
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 127:5           _async
packages/google_sign_in_web/src/flexible_size_html_element_view.dart 126:39  <fn>
packages/flutter/src/widgets/_html_element_view_web.dart 65:30               <fn>
dart-sdk/lib/async/zone.dart 1661:54                                         runUnary
dart-sdk/lib/async/future_impl.dart 162:18                                   handleValue
dart-sdk/lib/async/future_impl.dart 838:44                                   handleValueCallback
dart-sdk/lib/async/future_impl.dart 867:13                                   _propagateToListeners
dart-sdk/lib/async/future_impl.dart 643:5                                    [_completeWithValue]
dart-sdk/lib/async/future_impl.dart 713:7                                    callback
dart-sdk/lib/async/schedule_microtask.dart 40:11                             _microtaskLoop
dart-sdk/lib/async/schedule_microtask.dart 49:5                              _startMicrotaskLoop
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 181:7           <fn>

Code sample
(See flutter/cocoon)
Screenshots or Video
No response
Logs
No response
Flutter Doctor output
(n/a)

"DOM is not ready for the FlexHtmlElementView"

The implementation of the button relies on knowledge from the framework, which shouldn't be used. The issue this time is attempting to select from the DOM immediately after rendering, rather than using the correct mechanisms.
Related:

See: https://github.com/flutter/packages/pull/5785
Continuation of: https://github.com/flutter/packages/pull/5660

(Adding fyi-infra because this affects cocoon)

The actual problem is that flutter/cocoon is using an outdated version of the plugin, because its dependabot instance seem to be fully ignoring +z versions!


Use 1-indexed numbers for invalid ranges?

Should the error messages show 1-indexed values instead of 0-indexed? When I originally wrote the message I was only thinking about linter package authors, but it's users that most often see the message so it might make more sense to use 1-indexed values.

If it shows 1-indexed numbers for invalid ranges, it'll actually only add to the confusion. As the developers will not know if it's 0-indexed or 1-indexed. At least I would be

How about a hint in the message saying that the range displayed is a 0-indexed one?

This is getting trapped and handled differently by providers handling this "nicely" so it's not really relevant there, I think this is fine as is since we are requiring 0-indexed values to be input.


Using slivers results in a 1-pixel gap between slivers

Using slivers results in a 1-pixel gap between slivers.
You can see the 1px gap in the image below. I got this problem in every app I wrote with flutter. It is very annoying. And should really be fixed. Or maybe I am doing something wrong?
Could be related:
https://github.com/letsar/flutter_sticky_header/issues/8
https://github.com/flutter/flutter/issues/14288
This is the code used to get reproduce this issue:
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.black12,
      body: CustomScrollView(
        slivers: [
          SliverToBoxAdapter(
            child: Container(
              height: 150,
            ),
          ),
          SliverToBoxAdapter(
            child: Container(
              decoration: BoxDecoration(
                borderRadius: BorderRadius.only(
                  topLeft: Radius.circular(ThemeDimens.largeBorderRadius),
                  topRight: Radius.circular(ThemeDimens.largeBorderRadius),
                ),
                color: Colors.white,
              ),
              child: Padding(
                padding: const EdgeInsets.all(2),
                child: Container(
                  height: 16,
                ),
              ),
            ),
          ),
          SliverToBoxAdapter(
            child: Container(
              color: Colors.white,
              height: 5000,
            ),
          ),
        ],
      ),
    );
  }

I ran into this too.
A possible workaround for this is to use a SliverList with a SliverChildListDelegate instead of multiple SliverToBoxAdapter.
This prevented the 1-2 pixel gaps from occurring.
I had another issue with a pixel gap in a SliverFillRemaining, but I was able to work around this by using wrap the child of the SliverFillRemaining with a  Transform.translate(offset: const Offset(0, -2) , child: .....
This doesn't solve the underlying issue, but may help anybody who runs into the same issue.

And does it work for all phones? Because I found that I only had this issue with android devices. but not all android devices. depends on pixel density

It works on all phones that I tested it, which is both iOS and Android and a range of various pixel densities. Can't guarantee it won't cause any anti aliasing artefacts for all use cases an configurations, though.

I have this problem too. Someone found a solution ?

I think this issue cause by undefine item height. if use SliverFixedExtentList may resolve this.

I've had this happen several times due to different things.
One time was due to a Padding widget with a top or bottom set to anything above 0.  Another was due to padding you can set on the Container widget.
The time after that it was due to the expandedHeight of the SliverAppBar.  129.0, 131.0 looks good when fully expanded but then the gap appears when scrolling.  130.0 means the gap is there from the start. 128.0 and 132.0 both have no gap when expanded or when scrolling.  Here is a Gif of me scrolling the SliverAppBar slowly to show the problem:
https://i.imgur.com/g9xbRVO.gif
Reminds me of old sub pixel rendering problems with Flash where you would get gaps and blurriness when objects were placed at non whole number locations like top: 100.5 left: 50.2
The magic number method is not a good solution as it looks good on one content page but then for another it makes the gap appear even clearer due to the difference in content height.
For now I'm cheating around this using two different methods depending on the situation.  One method is to set the background color on parents and the scaffold.  The second method is the transform trick knaeckeKami suggested.

Reproduced with dev v1.18.0-8.0.pre. Not always visible with the initial code sample.

flutter doctor -v
[✓] Flutter (Channel dev, v1.18.0-8.0.pre, on Mac OS X 10.15.4 19E287, locale en-GB)
    • Flutter version 1.18.0-8.0.pre at /Users/nevercode/dev/flutter_dev
    • Framework revision e0c63cd35e (5 days ago), 2020-04-23 22:29:01 -0400
    • Engine revision d2ec21221e
    • Dart version 2.9.0 (build 2.9.0-3.0.dev b0d35855d8)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/nevercode/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4.1, Build version 11E503a
    • CocoaPods version 1.9.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.44.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.1

[✓] Connected device (5 available)
    • Android SDK built for x86 • emulator-5554                            • android-x86    • Android 10 (API 29) (emulator)
    • Nevercode’s iPhone        • b668e524315069f3db3661ac11ff1f66afafebdb • ios            • iOS 13.4.5
    • macOS                     • macOS                                    • darwin-x64     • Mac OS X 10.15.4 19E287
    • Web Server                • web-server                               • web-javascript • Flutter Tools
    • Chrome                    • chrome                                   • web-javascript • Google Chrome 81.0.4044.129

• No issues found!

And does it work for all phones? Because I found that I only had this issue with android devices. but not all android devices. depends on pixel density

@vanlooverenkoen I managed to reproduce on iPhone 11 Pro also, using v1.17.0

Any Progress in this issue?

I found a trick to hide this 1px line.
Is possible cover this gap using a BoxShadow.
@override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.black12,
      body: CustomScrollView(
        slivers: [
          SliverToBoxAdapter(
            child: Container(
              height: 150,
            ),
          ),
          SliverToBoxAdapter(
            child: Container(
              decoration: BoxDecoration(
                  borderRadius: BorderRadius.only(
                    topLeft: Radius.circular(20.0),
                    topRight: Radius.circular(20.0),
                  ),
                  color: Colors.white,
                  boxShadow: [
                    BoxShadow(
                        color: Colors.white,
                        blurRadius: 0.0,
                        spreadRadius: 0.0,
                        offset: Offset(0, 2)),
                  ]),
              child: Padding(
                padding: const EdgeInsets.all(2),
                child: Container(
                  height: 16,
                ),
              ),
            ),
          ),
          SliverToBoxAdapter(
            child: Container(
              color: Colors.white,
              height: 5000,
            ),
          ),
        ],
      ),
    );
  }

I found a trick to hide this 1px line.
Is possible cover this gap using a BoxShadow.
@override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.black12,
      body: CustomScrollView(
        slivers: [
          SliverToBoxAdapter(
            child: Container(
              height: 150,
            ),
          ),
          SliverToBoxAdapter(
            child: Container(
              decoration: BoxDecoration(
                borderRadius: BorderRadius.only(
                  topLeft: Radius.circular(20.0),
                  topRight: Radius.circular(20.0),
                ),
                color: Colors.white,
                boxShadow: [
                  BoxShadow(
                    color: Colors.white,
                    blurRadius: 0.0,
                    spreadRadius: 0.0,
                    offset: Offset(0, 2),
                  ),
                ],
              ),
              child: Padding(
                padding: const EdgeInsets.all(2),
                child: Container(
                  height: 16,
                ),
              ),
            ),
          ),
          SliverToBoxAdapter(
            child: Container(
              color: Colors.white,
              height: 5000,
            ),
          ),
        ],
      ),
    );
  }

I found a trick to hide this 1px line.
Is possible cover this gap using a BoxShadow.
@override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.black12,
      body: CustomScrollView(
        slivers: [
          SliverToBoxAdapter(
            child: Container(
              height: 150,
            ),
          ),
          SliverToBoxAdapter(
            child: Container(
              decoration: BoxDecoration(
                borderRadius: BorderRadius.only(
                  topLeft: Radius.circular(20.0),
                  topRight: Radius.circular(20.0),
                ),
                color: Colors.white,
                boxShadow: [
                  BoxShadow(
                    color: Colors.white,
                    blurRadius: 0.0,
                    spreadRadius: 0.0,
                    offset: Offset(0, 2),
                  ),
                ],
              ),
              child: Padding(
                padding: const EdgeInsets.all(2),
                child: Container(
                  height: 16,
                ),
              ),
            ),
          ),
          SliverToBoxAdapter(
            child: Container(
              color: Colors.white,
              height: 5000,
            ),
          ),
        ],
      ),
    );
  }

I can confirm this trick works.
If, like in my case, you need to cover from below the SliverAppBar, ensure the following container has the same color and boxshadow color as the appBar.
Container(
     decoration:
         BoxDecoration(
             color: Color(0xFF44444F),
             boxShadow: [
                  BoxShadow(
                        color: Color(0xFF44444F),
                        blurRadius: 0,
                        spreadRadius: 0,
                        offset: Offset(0, -2),
                 ),
             ],
         )
)

Nevermind - issue still present, fix not always working.

my situation, The color of the gap is the color of the SliverAppBar, So Let me do it this way
_CustomScrollViewController.addListener((){
if(_CustomScrollViewController.offset>180.0){
setState(() {
SliverAppBarBackgroundColor= Colors.orange;
});
}else{
setState(() {
SliverAppBarBackgroundColor= Colors.white;
});
}
});

code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.black12,
      body: CustomScrollView(
        slivers: [
          SliverToBoxAdapter(
            child: Container(
              height: 150,
            ),
          ),
          SliverToBoxAdapter(
            child: Container(
              decoration: BoxDecoration(
                borderRadius: BorderRadius.only(
                  topLeft: Radius.circular(15),
                  topRight: Radius.circular(15),
                ),
                color: Colors.white,
              ),
              child: Padding(
                padding: const EdgeInsets.all(2),
                child: Container(
                  height: 16,
                ),
              ),
            ),
          ),
          SliverToBoxAdapter(
            child: Container(
              color: Colors.white,
              height: 5000,
            ),
          ),
        ],
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.5, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.5 at /Users/tahatesser/Code/flutter_stable
    • Framework revision<PHONE_NUMBER> (6 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (2 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64 • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios           • iOS 14.3

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-2.0.pre.419, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-2.0.pre.419 at /Users/tahatesser/Code/flutter_master
    • Framework revision 913d5933c1 (4 hours ago), 2021-01-19 22:34:03 -0800
    • Engine revision b58dbc88fc
    • Dart version 2.12.0 (build 2.12.0-240.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (4 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64  • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS 14.3
    • macOS (desktop)      • macos                     • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 87.0.4280.141

• No issues found!

code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.black12,
      body: CustomScrollView(
        slivers: [
          SliverToBoxAdapter(
            child: Container(
              height: 150,
            ),
          ),
          SliverToBoxAdapter(
            child: Container(
              decoration: BoxDecoration(
                borderRadius: BorderRadius.only(
                  topLeft: Radius.circular(15),
                  topRight: Radius.circular(15),
                ),
                color: Colors.white,
              ),
              child: Padding(
                padding: const EdgeInsets.all(2),
                child: Container(
                  height: 16,
                ),
              ),
            ),
          ),
          SliverToBoxAdapter(
            child: Container(
              color: Colors.white,
              height: 5000,
            ),
          ),
        ],
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.5, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.5 at /Users/tahatesser/Code/flutter_stable
    • Framework revision<PHONE_NUMBER> (6 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (2 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64 • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios           • iOS 14.3

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-2.0.pre.419, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-2.0.pre.419 at /Users/tahatesser/Code/flutter_master
    • Framework revision 913d5933c1 (4 hours ago), 2021-01-19 22:34:03 -0800
    • Engine revision b58dbc88fc
    • Dart version 2.12.0 (build 2.12.0-240.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (4 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64  • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS 14.3
    • macOS (desktop)      • macos                     • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 87.0.4280.141

• No issues found!

Ran into this issue too.
Code example: https://gist.github.com/Moonspeaker/0e8573ff6620a7e00b8f7b04937b51a1
This is how it looks on any flutter branch: https://www.youtube.com/watch?v=DDxu1NTkaMA&feature=youtu.be

@TahaTesser still found in Flutter 2.0.1

I did some research and this is likely a result of anti-aliasing algorithm in skia, the layout is perfectly fine and all values passed to into painting functions are accurate.
Here's a simplified version of the reproducible

Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MaterialApp(home: App()));
}

class App extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.black12,
      body: Column(
        children: [
          Container(
            height: 150,
          ),
          Container(
            height: 20,
            color: Colors.white,
          ),
          Container(
            color: Colors.white,
            height: 1000,
          ),
        ],
      ),
    );
  }
}

I found a trick to hide this 1px line.
Is possible cover this gap using a BoxShadow.
@override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.black12,
      body: CustomScrollView(
        slivers: [
          SliverToBoxAdapter(
            child: Container(
              height: 150,
            ),
          ),
          SliverToBoxAdapter(
            child: Container(
              decoration: BoxDecoration(
                borderRadius: BorderRadius.only(
                  topLeft: Radius.circular(20.0),
                  topRight: Radius.circular(20.0),
                ),
                color: Colors.white,
                boxShadow: [
                  BoxShadow(
                    color: Colors.white,
                    blurRadius: 0.0,
                    spreadRadius: 0.0,
                    offset: Offset(0, 2),
                  ),
                ],
              ),
              child: Padding(
                padding: const EdgeInsets.all(2),
                child: Container(
                  height: 16,
                ),
              ),
            ),
          ),
          SliverToBoxAdapter(
            child: Container(
              color: Colors.white,
              height: 5000,
            ),
          ),
        ],
      ),
    );
  }

Thanks @paulosigales,
your solution is the best workaround to solve the gap while waiting for Google to fix this 3 years long-lasting issue (#14288).

This looks like a duplicate of #14288, if so, we should close this to keep discussion and efforts focused in one place. Thanks!


"Current Iteration" updated with Future date ?

Current Iteration updated with Future date ?
Steps to reproduce :

Moved one iteration from future to current , it automatically set up its date to today and end day after a week
Edit the Current sprint date to Future date as 2 weeks later , it git updated
Is it a valid behavior @fabric8io/uxd  ?

Once an iteration is started (thus making it current), the only date that should be changeable is the end date.


Seamlessly execute file scope "Global (file head declarations)" local variable to allow for future methods execution

Is your feature request related to a problem? Please describe.
Executing lua nvim function e.g. require("notify")  which are usually declared as abbreviation e.g.
local notify = require("notify") at top of the file (head) for ease of future use now if I want to snip run just a single function a wrote it the file using  notify("Hello") would yield an error even if local notify = require("notify") is executed once since it's local it doesn't get saved in successive SnipRuns
Describe the solution you'd like
There might be a cleaner solution the developers more experienced with code interperters but I think having the option to auto execute all local variable (Through treesitter) that are at the file head and the relevant once for "the selected execution scope" before :SnipRun automatically would suffice.
but a more proper solution of somehow loading the local variables like how global onces are loaded'd be more ideal.

The Lua_nvim interpreter should remember variable declarations, even locals as long as they're in global scope...
Could you share a minimal reproducer (code, config) ?

Yes
Code Running both works running them seperately doesn't:
local notify = require("notify")
notify("Hello there")

Config:
local M = {

  -- 'arjunmahishi/flow.nvim',
  "michaelb/sniprun",
  branch = "master",

  build = "sh install.sh",
  -- do 'sh install.sh 1' if you want to force compile locally
  -- (instead of fetching a binary from the github release). Requires Rust >= 1.65

  config = function()
    require("sniprun").setup({

      display = {"NvimNotify"},
      repl_enable = {'Python3_jupyter', "Lua_nvim"},
      selected_interpreters={'Python3_jupyter', "Lua_nvim"},
      live_mode_toggle='enable',

    -- your options
    })
  end,

return M

}

I see... I indeed doesn't work, but also, so it is when you type directly into neovim's cmd....
Treesitter has been experimented with but (at the time) was rather hit-or-miss. However detecting local <keyword> = require<stuff> and inserting <keyword> = require<stuff> instead is quite easy; other languages (python, mostly) do this for much more complex import patterns.
What are your thoughts about this ? Do you have a regex in mind that covers the relevant corner cases you're aware of (like, possible indentation, require syntax, etc...) ?

I see... it indeed doesn't work, but also, so it is when you type it directly into neovim's cmd....
Treesitter has been experimented with but (at the time) was rather hit-or-miss. However detecting local <keyword> = require<stuff> and inserting <keyword> = require<stuff> instead is quite easy; other languages (python, mostly) do this for much more complex import patterns.
What are your thoughts about this ? Do you have a regex in mind that covers the relevant corner cases you're aware of (like, possible indentation, require syntax, etc...) ?

Since I still don't understand the philosophy of regex, treesitter, lsp and the philosophy of how to capture should one think when capturing elements using regex and treesitter and  how to Perfectly (unlike heruistically(solving big chunk but not whole/perfectly)) parsing but I tend to stick to the idea of giving Fallbacks to Errors in our case from the compiler and based on that have out own middle man code interperter and resolver that add the local x_from_error declarations parsing  based on treesitter or lsp basically having our middle man try to handle the compiler/interperter
error and complete the execution successfully (while giving relevant notify warning when it doe's such thing)
Again there is probably be a faster(for the algorithem) more efficient way and philosophy to handle that but I only still understand the whole parsing , compiling and interpreting paradigms heuristically rather than perfectly as a whole to take complete responsibility for such task. In other words I don't feel like I'm knowlegefull / enough of an expert to make and stand behind such a thing.

The 1.3.14 release is out with fixes for this issue.
The minimal example you shared now works, but maybe more complex patterns will need some adjustment.
If after updating you experience related problems, please reopen this issue

Thanks already an improvement and a peace of mind, it'd be nice if it could also "remmember" local variables inside functions with the respectable context to maybe be able to check / recheck other call down the lines, running it with  it's essentials "from the top" and skipping the rest of the "unselected" and "unrelated" functions but I might be talking ahead of myself because developing in nvim doesn't feel and smooth as the nvim ideal reflects, but it might be just me though it definitely gets better over time somewhat.
It'd also be nice to be able to "plugin cache" some code with visual selection from one file and be able to execute it in another (guess mostly useful for nvim dev) for testing purposes, though it might be easy to do but once's sniprun interpretation gets more involved it's gonna require some integration matching with whatever it does,
but the meaning is more towards "run by reference" rather than "run by a copy"

Hmm I feel like de-'local'izing variables from functions is bound to conflict with some other thing at some point in the dev' workflow.
I rather have sniprun simply (and understandably) not work rather than produce weird/wrong behavior, so what you're asking for is a lot more involved. Though, for many other languages with REPL, there is no such 'local' barrier preventing function's variables to enter global scope.... I'll think about it
I can't reasonably build parsers for every language to select only "related" code from anywhere in the file/project, so I'll have to build a generic thing around either treesitter or a LSP, both of which have rather obscure APIs. They are in the roadmap but I don't personally feel like spending time on that


feat: port Order.Interval

(Edit by @joneugster)
The issue about the wrongly generated ext-Lemmas for NonemptyInterval has been brought up on zulip. A suggestion is to extend ext by an option @[ext (flat := false)] in order to be able to toggle whether ext should flatten structures or not:

[ ] leanprover/std4#122

Replaces #1272

Now most of the remaining errors have something to do with the interplay of NonemptyInterval.toProd and NonemptyInterval.toDualProd. It seems that lean3 could somehow change one into the other, and here lean4 fails to do so. I dont really understand much about that

todo: I just uncommented all @[simp, norm_cast] attributes where the linter was not happy, search for simpNF. Usually it was because LHS a ⊆b got simplified to a ≤ b and I don't know what to do about them. Should maybe be fixed before merging.

bors merge


FR: Configure .picker DOM location

The .picker class is by default inserted after the <input>. My <input> is inside a div that has css that cuts off .picker. It would be nice to be able to set where .picker is placed in the DOM, eg:
$('#date').pickadate({appendTo: 'body'})

Found this config:
https://github.com/amsul/pickadate.js/blob/master/lib/picker.js#L130
Was only looking on "API" page for settings, but I see now that it's listed on this page:
http://amsul.ca/pickadate.js/date/


CLI-339:  Help formatter extension

Fix for CLI-339
Implementation of a commons client help production system.
Creates a new package containing the classes used by commons-cli to produce the help output.
In general there are 4 classes that users/developers may be interested in.

HelpFormatter - the class used to produce the help output for most users.
HelpPrinter - Writes the output in a specific output serialization format (e.g. text, XHTML, Markdown, etc.)
OptionFormatter - Determines how to format the various data elements in an Option
TableDef - Defines a table to be displayed.  Useful for developers who want to build custom option displays or use the help system to produce additional information in the help system
TextStyle - Defines the style for text in tables and the default style for the TextHelpPrinter.

Java 24-ea fails due to issues with spotbugs plugin under java-24

As far as making HelpWriter extends Appendable I think that is a good idea.  However I feel that it moves the class further from the "Writer" concept as delineated by the Javadoc for Writer.  I want to rename HelpWriter to Scribe and the implementing calsses to TextScribe, AptScribe, etc.

As far as making HelpWriter extends Appendable I think that is a good idea. However I feel that it moves the class further from the "Writer" concept as delineated by the Javadoc for Writer. I want to rename HelpWriter to Scribe and the implementing calsses to TextScribe, AptScribe, etc.

😄 Since Java's Write implements Appendable, HelpWriter extending Appendable would move the class closer to the "Writer" concept IMO, not further. But, this could be the issue with having named the class "*Writer" in the first place 😄 ❓ Either way, we agree: extend Appendable, whatever the class name is.

The Javadoc is still off (See Java 23 build output):
[ERROR] C:\Users\ggregory\git\a\commons-cli\src\main\java\org\apache\commons\cli\HelpFormatter.java:597: error: reference not found
[ERROR]      * @deprecated use {@link OptionFormatter#getArgName()} or {@link OptionFormatter.Builder#getArgName()}
[ERROR]                                                                       ^


CMEC compliant metrics output

The overarching goal is to make PMP outputs CMEC-compliant (https://cmec.llnl.gov/). The first step is to add functionality that writes the output metrics files in the CMEC format.

@acordonez I guess this is about complete so might be ready to close this... do I have that right?   Attempting a little clean up ;-)

Since we have the option to output CMEC metrics JSONs in all of the metrics now, it does seem ok to close this.


Build error

When I want to build app in android studio I get:
Configuration cache state could not be cached: field `__librarySourceSets__` of task `:app:mapDebugSourceSetPaths` of type `com.android.build.gradle.tasks.MapSourceSetPathsTask`: error writing value of type 'org.gradle.api.internal.file.collections.DefaultConfigurableFileCollection'
> Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
   > Could not find me.jahirfiquitiva:FABsMenu:1.1.4.
     Searched in the following locations:
       - https://dl.google.com/dl/android/maven2/me/jahirfiquitiva/FABsMenu/1.1.4/FABsMenu-1.1.4.pom
       - https://jcenter.bintray.com/me/jahirfiquitiva/FABsMenu/1.1.4/FABsMenu-1.1.4.pom
       - https://jitpack.io/me/jahirfiquitiva/FABsMenu/1.1.4/FABsMenu-1.1.4.pom
     Required by:
         project :app
Possible solution:
 - Declare repository providing the artifact, see the documentation at https://docs.gradle.org/current/userguide/declaring_repositories.html

Please can someone help with this?

Can you try setting the configuration cachr to false in gradle.properties? This error has been causing the CI to fail for the last few days and I can't explain why. That said, I was planning to move away from said legacy FABsMenu library anyway, so I will try to accelerate that now.

Like this? Maybe I'm doing something wrong, but there are more mistakes.

Thank you for testing it. The issue is more complicated I guess and is caused by the outdated FAB dependency, which I am currently working on replacing. One that is done, you can pull the changes from main and Gradle should build fine.

Should be fixed now! Can you try rebuilding from the latest main branch?

Thanks. Now it works perfectly


Question about error code "Fail to Open Port"

Hi there,
Not sure what I did wrong but when I try print or connect I get failed to open port error.  The printer is definitely on network and tested working with another device (not written via react native)
As far as I can tell StarPRNT.checkStatus works as I can get printer info, just not print or connect below.
Thanks in advance.
StarPRNT.print('StarGraphic', commands, printer.portName).then(()=>{
  console.log('printed');
}, err=>{
  this.setState({
    printerError: err.code
  })
});

StarPRNT.connect(printer.portName, 'StarGraphic', false).then(()=>{
  this.setState({
    connectedPrinter: printer
  });
}, err=>{
  this.setState({
    printerError: err.code
  })
})

User error here.  Closing this issue.

Actually reopening to see if anyone had these two issues:

Looks like I can connect fine via ios emulator, but when connecting to devices (react-native run-ios/android) I still kept getting Failed to open port.

Whenever in emulator mode, after a hot-reload I can't seem to re-connect the printer again (Failed to open port).  Disconnect won't help either.  I would have to rerun react-native run-ios command to start over.   Is anyone else seeing this issue?

Hi @jeremycy. You need to make sure your app closes the connection on pause and on close events otherwise the connection will remain open and it will block new connections. My advice is not to use the connect() function, instead, you should send the commands to the printer passing the portName every time. This will guarantee that the connection is only open while printing and then immediately close it when finished, this helps preserve the battery life of your device by not having open connections that are not used very often.
thanks

@infoxicator , great advice.  It solved both of my problems.  Apparently it's already blocked when I run on my device with connect method rather than passing port ondemand.
Thank you very much.

@infoxicator In my app, i let the user choose the printer model name and i give the emulation value according to that.
So i have a TSP100 printer, when i try to connect that TSP100 with the emulation value of TSP650, the connection does not close. It gives me a timeout error. And also it doesn't close the connection immediately when i got that error message. So i have to wait or restart the app to  try my TSP100 with a correct emulation value from the list. Is there any solution for that?
Btw i am not using the connect or disconnect method. It works perfectly when i choose the right one. But when i click accidentally wrong printer. It messes up.


cannot open shared object file

I'm getting an error when trying to use jellyfin-cover:
Traceback (most recent call last):
  File "/home/ubuntu/.local/bin/jellyfin-cover", line 5, in <module>
    from cli.cli import main
  File "/home/ubuntu/.local/lib/python3.10/site-packages/cli/cli.py", line 6, in <module>
    from cli.image import create_library_image
  File "/home/ubuntu/.local/lib/python3.10/site-packages/cli/image.py", line 7, in <module>
    import cv2
  File "/home/ubuntu/.local/lib/python3.10/site-packages/cv2/__init__.py", line 181, in <module>
    bootstrap()
  File "/home/ubuntu/.local/lib/python3.10/site-packages/cv2/__init__.py", line 153, in bootstrap
    native_module = importlib.import_module("cv2")
  File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
ImportError: libGL.so.1: cannot open shared object file: No such file or directory

The call I'm making looks like this:
jellyfin-cover create --image image-name.jpg --title 'Library Title'

Try installing opencv-python-headless, I've read that this will install necessary dependencies that may be missing in some installations.
pip install opencv-python-headless


Fix: forgot password regex failure fix and error message display

Pre-Flight checklist

[x] Screenshots and design review for any changes that affect layout or styling

[x] Desktop screenshots

[x] Testing

[x] Code is tested
[x] Changes have been manually tested

What are the relevant tickets?
#39
What's this PR do?

Updates the forgot-password API URL to match a regex of accurate length as of Django3
Adds an error message for the user in case the API fails

How should this be manually tested?

Setup, make sure the Django version is above 3 and visit signin/forgot-password/.
Add dummy MAILGUN keys which will make the email API fail or forcefully throw an error from mail/API.
Make sure that an error message is shown to the user
Now configure the right MAILGUN creds and visit signin/forgot-password/
Make sure that the user is able to reset the password correctly

Where should the reviewer start?

Probably run an instance and verify the generated token length as mentioned in here
Now, run this PR and make sure that the acceptance criteria mention in the ticket is met.

Screenshots (if appropriate)
Email Success Message

Email Error Message

Seems like we should add some unit tests to avoid this problem in the future? I'd like to get this merged ASAP, so if the tests can't be added today, I'd be fine with opening an issue to follow up with it later.

@rhysyngsun is this something we need to update in https://github.com/mitodl/ol-django/ ?

Codecov Report

Merging #44 (9259ff6) into main (5c22dda) will increase coverage by 6.61%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   91.10%   97.71%   +6.61%
==========================================
  Files         201      119      -82
  Lines        5978     2800    -3178
  Branches      290        0     -290
==========================================
- Hits         5446     2736    -2710
+ Misses        450       64     -386
+ Partials       82        0      -82

Impacted Files
Coverage Δ

.../containers/pages/login/LoginForgotPasswordPage.js
96.29% <100.00%> (+0.46%)
:arrow_up:

mail/forms.py

users/factories.py

authentication/middleware.py

courses/factories.py

users/constants.py

users/models.py

main/test_utils.py

mail/views.py

mail/verification_api.py

... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c22dda...9259ff6. Read the comment docs.

@pdpinch Could you please take a look at the screenshots and let me know if they are fine by you.

Seems like we should add some unit tests to avoid this problem in the future? I'd like to get this merged ASAP, so if the tests can't be added today, I'd be fine with opening an issue to follow up with it later.

I've added some tests for the backend. For the frontend, I'll try to add some today otherwise I'll create a ticket for that and get to it later.

Could you please take a look at the screenshots and let me know if they are fine by you.

Thanks. Screenshots look OK. The line breaks are awkward, but I don't want to worry about that.
And thanks for the tests.


Use bincode for data instead of serde

99 compiler errors on the wall
99 compiler errors on the wall
take one down and patch it around
121 compiler errors on the wall

there was really no need to use serde anyway
i fixed so many compiler errors in the last 8 hours. please end me.

please.


Uploads fail on IE 11

Trying to upload any image file on Windows 10 (IE ver: 11; update version 11.0.25)  and IE immediately throws the "Internet Explorer has stopped working" dialog.
I've tried this on several machines and all exhibit the same behavior.
Could you take a look?

You are right ... I have never tested it before. Did not know that people are still using IE :) Unfortunatelly I do not have time to debug this now ... if you manage to find time I would be greatfull. Plugin has been around for more than a year now and this is a first report, so it is not a stressing issue for now. Sorry :/

No prob, and IE -  I know!  Win10 is bringing a whole new set of IE (and Edge) users.  Great…I’ll take a look and see what I can do.SteveOn Feb 1, 2016, at 11:10 PM, Tomas Trescak<EMAIL_ADDRESS>wrote:You are right ... I have never tested it before. Did not know that people are still using IE :) Unfortunatelly I do not have time to debug this now ... if you manage to find time I would be greatfull. Plugin has been around for more than a year now and this is a first report, so it is not a stressing issue for now. Sorry :/—Reply to this email directly or view it on GitHub.
muse megav:<PHONE_NUMBER> c:<PHONE_NUMBER> l : www.linkedin.com/in/stevenejackson/

Is this just when using the upload_bootstrap or upload_semanticUI components? I just set up meteor-uploads using the custom template from the README, and it's working fine on Windows 10 in Edge, IE11 and IE10. I haven't tried with the build in components, mind you.
Very nice package, by the way.

It is the upload_semanticUI component.  I haven't had the cycles to take a look yet, but it's on the task list.

Thanks for the clarification! I'm working with the bootstrap component at the moment, but I'll keep on eye open on the semantic side if I stumble over there. Cheers.


Adding Terminal Velocity Check for CameraCaptureUI Experimental API

This PR introduces a TerminalVelocity check to control the availability of an experimental feature in the Windows App SDK. The feature is enabled in the Experimental channel, while it remains NOOP'd in the Preview and Stable channels, following the TerminalVelocity guidelines for efficient code stripping.
For more information:
https://github.com/microsoft/WindowsAppSDK/blob/main/docs/Coding-Guidelines/Experimental.md
https://github.com/microsoft/WindowsAppSDK/blob/main/docs/Coding-Guidelines/TerminalVelocity.md

/azp run


[backup] update sample configs

Motivation

use relative paths so backups are interchangeable among platforms
add gzip filters

Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
Related PRs

/land


Create an intro

I'm Mark Niño, an aspiring web developer. With only an academic knowledge about programming, I'm dedicated to learning more about code and potentially building my own projects in the future!


Improve package versioning to resolve #7

Add automatic version bumping when a new release is created via
https://github.com/loicleyendecker/deeppath/releases/new
tag name must be semver and follow va.b.c
move bump2version config from setup.cfg to .bumpversion.cfg
since it will delete any comments in the cfg files
see https://github.com/c4urself/bump2version/issues/37

I guess we shouldnt allow bump2version to tag for us since we create the tag via https://github.com/loicleyendecker/deeppath/releases/new ?

I guess we shouldnt allow bump2version to tag for us since we create the tag via https://github.com/loicleyendecker/deeppath/releases/new ?

Have a look at https://github.com/1Mark/deeppath/runs/5523775597?check_suite_focus=true
Look at the fourth step bump package version

Ready to be reviewed @loicleyendecker


[stable/redia-ha] Update redis-ha-statefulset.yaml

What this PR does / why we need it:
Add "config-sentinel.conf" to checksum/init-config annotation so that changes to the sentinel.conf trigger a restart of the Redis pods
Which issue this PR fixes

fixes #147

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

@ArcticSnowman Worth mentioning if you make any changes, its good to helm template . to ensure syntax all looks good.


Docker build issues

Hi. Thanks for making this great work open source!
I just tried to play with the tool a bit by reproducing your experiments with Skia using the given docker files.
However, I got this error while building graphfuzz_base image
Collecting msgpack>=0.5.2 (from cachecontrol[filecache]<0.13.0,>=0.12.9; python_version >= "3.6" and python_version < "4.0"->poetry)
  Downloading https://files.pythonhosted.org/packages/22/44/0829b19ac243211d1d2bd759999aa92196c546518b0be91de9cacc98122a/msgpack-1.0.4.tar.gz (128kB)
Collecting filelock>=3.8.0; extra == "filecache" (from cachecontrol[filecache]<0.13.0,>=0.12.9; python_version >= "3.6" and python_version < "4.0"->poetry)
  Could not find a version that satisfies the requirement filelock>=3.8.0; extra == "filecache" (from cachecontrol[filecache]<0.13.0,>=0.12.9; python_version >= "3.6" and python_version < "4.0"->poetry) (from versions: 0.2.0, 0.2.1, 0.2.2, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 2.0.0, 2.0.1, 2.0.4, 2.0.5, 2.0.6, 2.0.7, 2.0.8, 2.0.9, 2.0.10, 2.0.11, 2.0.12, 2.0.13, 3.0.0, 3.0.2, 3.0.3, 3.0.4, 3.0.6, 3.0.8, 3.0.9, 3.0.10, 3.0.12, 3.1.0, 3.2.0, 3.2.1, 3.3.0, 3.3.1, 3.3.2, 3.4.0, 3.4.1)
No matching distribution found for filelock>=3.8.0; extra == "filecache" (from cachecontrol[filecache]<0.13.0,>=0.12.9; python_version >= "3.6" and python_version < "4.0"->poetry)
The command '/bin/sh -c python3 -m pip install poetry' returned a non-zero code: 1

Have you face the (similar) issue? I am using Ubuntu 20.04 64-bit.
Best regards,
Thuan

Hi Thuan, not the creator here, but in one of my projects I build my own container and run these commands successfully. Its based on Ubuntu 22.04 aka Jammy though.
Maybe it helps.

I think the poetry installation issue was caused by python3.6 being deprecated (and the default in ubuntu 18.04). I just pushed a change to switch the base image to python3.8 instead as I fear switching from ubuntu 18.04 in all those images might break other things...
I was able to build the base images with this change, could you let me know if this fixes your issue?
Happy to help debug if there are other issues!

Thanks both. @hgarrereyn, I get this error with your newest code
Step 5/10 : WORKDIR /graphfuzz
 ---> Running in 4762fe818a26
Removing intermediate container 4762fe818a26
 ---> cb09ae8a8311
Step 6/10 : COPY cli /graphfuzz/cli
COPY failed: file not found in build context or excluded by .dockerignore: stat cli: file does not exist

I tried to run docker build from both the graphfuzz root folder (docker build experiments/base) and the experiments/base folder (docker build .) but I got the same error. I don't think this is related to Ubuntu version but I can try to follow Nik's suggestion and build the images on Ubuntu 22.04.

There is a build and run script in the /experiments folder that will set up the proper context when building. E.g. inside the /experiments folder, run./build base to build the graphfuzz_base image then ./build skia to build the skia image, then ./run skia to launch the skia image.
If you want to run the commands outside of that wrapper, you can use this command for the base image:
cd experiments
docker build .. -f base/Dockerfile -t graphfuzz_base

For other images (e.g. skia), use this command:
cd experiments
docker build ./skia -f ./skia/Dockerfile -t graphfuzz_skia


Connect the repo to Reviewable

Please connect this repo at https://reviewable.io/repositories so that all PRs get linked to reviews. Thanks!

People are free to use reviewable for their reviews (and some do), but many people use vanilla GitHub or other tools so we don't want to codify reviewable into our check-in process. I believe you can review using reviewable on any PR even without us linking the repo.

Yes, we used to have this set up but disabled it due to many people finding it annoying when they would rather use a separate tool and not have the Reviewable message show up on every PR.


Add export utterances, export proposed actions to utterance table

Part of #297
Description:
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

[x] ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
[x] PRE-COMMIT. You ran pre-commit on all commits, or else, you
ran pre-commit run --all-files at the end.
[x] USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
our users.
[x] DEV CHANGES.

Update the documentation if this PR changes how to develop/launch on the app.
Update the README files and our wiki for any big design decisions, if relevant.
Add unit tests, docstrings, typing and comments for complex sections.

Thank you @JosephMarinier for taking up your time in reviewing and suggesting some valuable inputs :)


How i get HttpWebRequest in crawler_ProcessPageCrawlStarting ?

I Need this to add a cookie in the page like a login and password ? Any tips ?

Please add this question on the forum. git issues are not a place for "how do i" questions.

Sorry for that and Thanks