passing a list as a workflow parameter

Is this a BUG REPORT or FEATURE REQUEST?:
A request for help at first and if not possible then feature request.
What happened:
Below is a workflow with a workflow parameter that is a list of templates that should run.
The task at hand is using a webhook to run workflow but under some conditions skip certain DAG steps.
apiVersion: v1
kind: ConfigMap
metadata:
  name: coinflip-dag-workflow
  namespace: eim
data:
  wf: |
    apiVersion: argoproj.io/v1alpha1
    kind: Workflow
    metadata:
      generateName: dag-diamond-coinflip-
      labels:
        rerun-timestamp:
    spec:
      entrypoint: diamond
      arguments:
        parameters:
        - name: transformations
          value: ("dimension1,dimension2,fact1")
      serviceAccountName: argo
      templates:
      - name: diamond
        dag:
          tasks:
          - name: dimension-workflow
            template: dimension-workflow
          - name: fact-workflow
            dependencies: [dimension-workflow]
            template: fact-workflow

      - name: dimension-workflow
        dag:
          tasks:
          - name: transform-dimension1
            template: check-transformation
            arguments:
              parameters:
                - name: transformation
                  value: "dimension1"
                - name: name
                  value: "dim1-name"
          - name: transform-dimension2
            template: check-transformation
            arguments:
              parameters:
                - name: transformation
                  value: "dimension2"
                - name: name
                  value: "dim2-name"
          - name: transform-dimension3
            template: check-transformation
            arguments:
              parameters:
                - name: transformation
                  value: "dimension3"
                - name: name
                  value: "dim3-name"

      - name: fact-workflow
        dag:
          tasks:
          - name: transform-fact1
            template: check-transformation
            arguments:
              parameters:
                - name: transformation
                  value: "fact1"
                - name: name
                  value: "fact1-name"
          - name: transform-fact2
            template: check-transformation
            arguments:
              parameters:
                - name: transformation
                  value: "fact2"
                - name: name
                  value: "fact2-name"

      - name: check-transformation
        inputs:
          parameters:
            - name: transformation
            - name: name
        steps:
        - - name: transform-task
            template: transform-task
            arguments:
              parameters:
                - name: transformation
                  value: "{{inputs.parameters.transformation}}"
                - name: name
                  value: "{{inputs.parameters.name}}"
            when: "{{inputs.parameters.transformation}} in {{workflow.parameters.transformations}}"

      - name: transform-task
        inputs:
          parameters:
            - name: transformation
            - name: name
        container:
          image: alpine:3.6
          command: [sh, -c]
          args: ["sleep 2 && echo \"For transformation {{inputs.parameters.transformation}} name was {{inputs.parameters.name}}\""]

What you expected to happen:
Through a webhook, I would like to pass a list of values as argument parameter.
apiVersion: argoproj.io/v1alpha1
kind: Sensor
metadata:
  name: "coinflip-sensor"
  namespace: eim
  labels:
    sensors.argoproj.io/sensor-controller-instanceid: argo-events
    argo-events-sensor-version: v0.10
spec:
  template:
    spec:
      containers:
        - name: "sensor"
          image: "argoproj/sensor:v0.9.3"
          imagePullPolicy: Always
      serviceAccountName: argo-events-sa
  dependencies:
    - name: "coinflip-gateway:coinflip-webhook"
  eventProtocol:
    type: "HTTP"
    http:
      port: "9300"
  triggers:
    - template:
        name: coinflip-workflow-trigger
        group: argoproj.io
        version: v1alpha1
        kind: Workflow
        source:
          configmap:
            name: "coinflip-dag-workflow"
            # name: eim-pdm-workflow
            namespace: eim
            key: wf
      resourceParameters:
        - src:
            event: "coinflip-gateway:coinflip-webhook"
            path: timestamp
          dest: metadata.labels.rerun-timestamp
          operation: overwrite
        - src:
            event: "coinflip-gateway:coinflip-webhook"
            path: dimensions
          dest: spec.arguments.parameters.0.value
          operation: overwrite

The json passed through a webhook is like below:
_{"dimensions": ["dimension2","dimension3","fact1","fact2"]}_
I was expecting that passing a json array would be translated as a list into the workflow parameter but that does not seem to be the case.
Is this even possible at all currently? Otherwise can we use a conditional to see if a certain value is part of an array?  Condition _when dimension1 in ("dimension1","dimension2")_ works but _when dimension1 in ["dimension1","dimension2"]_ does not work.
Environment:

Argo version:

$ argo version
  BuildDate: 2019-05-20T22:11:23Z
  GitCommit: 88fcc70dcf6e60697e6716edc7464a403c49b27e
  GitTreeState: clean
  GitTag: v2.3.0
  GoVersion: go1.11.5
  Compiler: gc
  Platform: darwin/amd64

Kubernetes version :

$ kubectl version -o yaml
clientVersion:
  buildDate: "2019-03-26T00:04:52Z"
  compiler: gc
  gitCommit: 641856db18352033a0d96dbc99153fa3b27298e5
  gitTreeState: clean
  gitVersion: v1.14.0
  goVersion: go1.12.1
  major: "1"
  minor: "14"
  platform: darwin/amd64
serverVersion:
  buildDate: "2019-08-20T22:39:46Z"
  compiler: gc
  gitCommit: 5ac0f1d9ab2c254ea2b0ce3534fd72932094c6e1
  gitTreeState: clean
  gitVersion: v1.13.10-eks-5ac0f1
  goVersion: go1.11.13
  major: "1"
  minor: 13+
  platform: linux/amd64

Other debugging information (if applicable):

workflow result:

$ argo get <workflowname>

Name:                dag-diamond-coinflip-bvzlf
Namespace:           eim
ServiceAccount:      argo
Status:              Failed
Created:             Tue Oct 01 16:55:50 -0400 (35 minutes ago)
Started:             Tue Oct 01 16:55:50 -0400 (35 minutes ago)
Finished:            Tue Oct 01 16:55:50 -0400 (35 minutes ago)
Duration:            0 seconds
Parameters:
  transformations:   ["dimension2","dimension3","fact1","fact2"]

STEP                           PODNAME  DURATION  MESSAGE
 ✖ dag-diamond-coinflip-bvzlf
 └-✖ dimension-workflow
   ├-✖ transform-dimension1                       Failed to evaluate 'when' expresion 'dimension1 in ["dimension2","dimension3","fact1","fact2"]': Value '"dimension2","dimension3","fact1","fact2"' cannot be used with the comparator 'in', it is not a number
   | └---⚠ transform-task                         Failed to evaluate 'when' expresion 'dimension1 in ["dimension2","dimension3","fact1","fact2"]': Value '"dimension2","dimension3","fact1","fact2"' cannot be used with the comparator 'in', it is not a number
   ├-✖ transform-dimension2                       Failed to evaluate 'when' expresion 'dimension2 in ["dimension2","dimension3","fact1","fact2"]': Value '"dimension2","dimension3","fact1","fact2"' cannot be used with the comparator 'in', it is not a number
   | └---⚠ transform-task                         Failed to evaluate 'when' expresion 'dimension2 in ["dimension2","dimension3","fact1","fact2"]': Value '"dimension2","dimension3","fact1","fact2"' cannot be used with the comparator 'in', it is not a number
   └-✖ transform-dimension3                       Failed to evaluate 'when' expresion 'dimension3 in ["dimension2","dimension3","fact1","fact2"]': Value '"dimension2","dimension3","fact1","fact2"' cannot be used with the comparator 'in', it is not a number
     └---⚠ transform-task                         Failed to evaluate 'when' expresion 'dimension3 in ["dimension2","dimension3","fact1","fact2"]': Value '"dimension2","dimension3","fact1","fact2"' cannot be used with the comparator 'in', it is not a number

It appears that if the list is passed as a string:
      entrypoint: diamond
      arguments:
        parameters:
        - name: transformations
          value: "dimension1,dimension2,fact1"

And it can be consumed as
when: "someValue in ({{workflow.parameters.transformations}})"
However this approach works only if the value supplied is is a comma separated list.
If the value is a single value it fails.
Actually when condition fails when with one parameter only like below without using parameters at all and that is a bug as it should be able to translate it into a list of one item.
when: "someValue in (someValue)"

Just faced the same issue when outputting comma-separated values. I found this as a workaround :
when: "someValue in (dummy,{{workflow.parameters.transformations}})"
When {{workflow.parameters.transformations}} is a single value, adding dummy, before tells Argo that the value is a list.
I'm not particularly proud of this, being more a workaround than a real solution, but can't find a way to do better.


Uses bit shifting even for full-range depth conversions

for a function call like this:
clip = core.std.BlankClip(format=vs.GRAY8, color=255)
clip.fmtc.bitdepth(bits=16, fulls=True, fulld=True).set_output()

the clip should have a color of 65535 (255 * 257) but instead is 65280 (255 * 256)

Even RGB.

Vapoursynth resize filter acts in the same way. But theoratically the factor should be 257 to do evenly matched mapping.

In full range it should be 257, when limited it's 256 checked out in vapoursynth.

Right. Thank you for the report. Fixed in 1695707dec303da59e8eb7d0133c70d804c62190, will be available in upcoming r22 release.


[Doc] Update Pulsar Connector Guide

Currently, the Pulsar connector guide is not clear, accurate and complete.

Old Structure of Pulsar Connector Guide:

Updated Structure of Pulsar Connector Guide:

PRs related to this issue:
[placeholder]

[placeholder for other related info]

[placeholder for other info]

@sijie @tuteng could you please help review the "Updated Structure of Pulsar Connector Guide"?


Evaluate selective squashing with secrets

Task for me - I need to make sure that selective squashing would work the way I imagine, where

layers (possibly just at the top) can be selectively squashed, and
squashing erases any trace of the build arguments from history or docker inspect

Hmmm: https://github.com/goldmann/docker-squash/issues/138

Nope, confirmed: even after squashing build arguments are still present in the history.
Alternatives therefore are:

don't use build arguments, stage files in and then delete them (makes me a little nervous)
find/create alternative squash method that directly applies new layers without metadata

It works. Implemented 1 above


Add failover() + basic monitor() actions to ovc.node

Description
The failover() action should allow to move a VM to another G8 node.
With a basic monitor() action we should be able to trigger an event for which the failover() should be the event handler
We need this (in Russia) in order to start showing (demo + training) how self-healing works

Moving a vm to another G8 node is a cloudbroker action, meaning that only an administrator would be able to do it.
From my understanding this addresses endusers... and in this case it will only fail

Yes you are right @rkhamis
Scenario is when a VM fails (for whatever reason). At that point you don't want OVC to automatically just restart the machine (on another node). You rather want that the workload (for instance a Docker container) gets properly restarted (or even reinstalled) too, and in order to have that work you'd need an AYS service for that workload.
For AYS itself for instance, which is an example of such a workload, I've had many situations where VM hosting the JS9 docker had to be restarted manually, but that didn't bring the AYS server back...
So a better FR might be to create an AYS template for AYS server, one that doesn't only installs, but also keeps it healthy, able to survive host reboots for instance...

I'm not sure I understand. You want an AYS server to monitor the AYS server?

Yep

In that case, I'll close this issue. Having a service deploy/install AYS somewhere else is another discussion altogether. I'd like to first have all jumpscale modules be pip installable to make it absolutely clean.
Thanks Yves


Add a boolean flag about complete-compress in grpc network protocol

This is a requirement from @peng-yongsheng , because of #423 . Agent can provide this flag with little cost， and help collector to support #423 with less cost.
@peng-yongsheng Let's discuss about where should I add in the proto file.
IMO:
service TraceSegmentService {
    rpc collect (stream UpstreamSegment) returns (Downstream) {
    }
}

message UpstreamSegment {
    repeated UniqueId globalTraceIds = 1;
    bytes segment = 2; // the byte array of TraceSegmentObject

   #add the flag here?
   bool isCompleteCompress = 3;
}

@peng-yongsheng These is a case which we must pay attention for. If add this flag, if a already stable system updates and reboots only. the agent definitely lost all caches(peer/operationName dictionary). So agent upstreams segments with isCompleteCompress = false.
By that, collector save the segments and try to process in async ways, with more disk and CPU lost, and more latency. Actually, the peer/operationName caches work fine if you try to compress those segments.
This is not an infrequent scenario. Every time, application reboots, this happens. So you must be careful to deal with it.

Through PMC meeting, this feature will be abandoned. @peng-yongsheng has confirmed this, collector will provide a un-compress data detection mechanism during the parsing.


CPU’s do not wrap

Environment

OS: Ubuntu 16.04.3 LTS
Node version: v4.2.6
gtop version: 0.1.5

Description
I realize that this is ridiculous and most people will never encounter this, but on my 40 core, 80 thread server, the CPUs get cut off a little bit. It gets to CPU 27 and just stops. CPU 43 peaks through a little bit but that’s it.

Just realized this is a duplicate of #34, closing


ronn files not getting copied into build tree

i created build and install directories inside the geopm source tree.  After running autogen.sh in the source directory and configure in the build directory, I'm hitting the following error during the execution of make.
mkdir -p man
export GEM_PATH=`readlink -f ../ruby`:$GEM_PATH && \
cd ronn && \
../ruby/bin/ronn --date=`date "+%Y-%m-%d"` \
                 --organization="GEOPM 1.1.0+dev12gd32094ef" \
                 `basename man/GEOPM_CXX_MAN_Agent.3`.ronn
Traceback (most recent call last):
	6: from ../ruby/bin/ronn:150:in `<main>'
	5: from ../ruby/bin/ronn:150:in `map'
	4: from ../ruby/bin/ronn:150:in `block in <main>'
	3: from ../ruby/bin/ronn:150:in `new'
	2: from /usr/lib/ruby/vendor_ruby/ronn/document.rb:75:in `initialize'
	1: from /usr/lib/ruby/vendor_ruby/ronn/document.rb:72:in `block in initialize'
/usr/lib/ruby/vendor_ruby/ronn/document.rb:72:in `read': No such file or directory @ rb_sysopen - GEOPM_CXX_MAN_Agent.3.ronn (Errno::ENOENT)
Makefile:5584: recipe for target 'man/GEOPM_CXX_MAN_Agent.3' failed
make[1]: *** [man/GEOPM_CXX_MAN_Agent.3] Error 1
make[1]: Leaving directory '/home/rountree/llnl/geopm/build'
Makefile:2284: recipe for target 'all' failed
make: *** [all] Error 2

The ronn directory looks like this:
rountree@Solvent:~/llnl/geopm/build$ ls ronn
geopm.7  geopm.7.html  geopm.7.ronn

The man/GEOPM_CXX_MAN_Agent.3 file exists in the source tree.  Looks like the ronn files are not getting copied over into the build tree.  Copying the files over manually allows the build to complete without error.

related to #3


digital-audio quality_impressions_per_duration_s update

updated quality_impressions_per_duration_s for digital-audio to match streaming-video.

@pymble2073  I took a look at this for you. I discovered that a validation test was failing and that causes this PR to say some checks not passed.

The fix was to update the quality_impressions_per_duration_s fields in the templates/property/digital-audio.yaml file rather than the defaults/property-defaults.yaml file. The default directory is autogenerate and we have an automatic test in the build pipeline to check its never manually updated.
This changed also made a python unit test fail so updated that too.
This PR is looking good now from my POV. Able to get a review @EmmaLouise2018. FYI this is my first code change to the repo so let me know if theres any process ive not followed correctly.


Diesel "Getting Started" Guide Note on Installing diesel_cli Doesn't Work as Advertised

Versions

Rust: 1.38.0
Diesel: 1.4.0
Database: MySQL
Operating System: MacOS Catalina 10.15.1

Cargo Command
cargo install diesel_cli --no-default-features --features mysql
Problem Description
The Diesel getting started guide indicates that diesel_cli should be installed.  It provided a note that suggests if one sees an error such as "note: ld: library not found for -lmysqlclient" that either the library should be installed/configured differently or that the provided command should fix the issue.
The provided command (above) produces the same error.
What are you trying to accomplish?
Install diesel for use with MySQL
What is the expected output?
Successful installation
What is the actual output?
https://gist.github.com/akesling/da7a849c15d0f1cb11c22c3c9c2d211e
Are you seeing any additional errors?
Yes, see gist above.
Steps to reproduce
Run "cargo install diesel_cli --no-default-features --features mysql" on MacOS.
Checklist

[ x ] I have already looked over the issue tracker for similar issues.
[ x ] This issue can be reproduced on Rust's stable channel. (Your issue will be
closed if this is not the case)

If you want to use the mysql backend you need to install the corresponding native library. This is literally stated in the sentence before that one you cited. The other option only applies to backends you don't want to use.
Additionally we use the bug tracker to track feature request and bugs not to answer questions. Please use our gitter channel or the forum for that.

The getting started guide explicitly stated either or:

You can resolve this issue by either installing the library (using the usual way to do this depending on your operating system) or by specifying the backends you want to install the CLI tool with.

(emphasis mine)
If the guide is incorrect, then that's the source of my confusion and it should be a fixed (thus this is still a bug, just with the guide).

I don't think the guide is incorrect, that would mean nobody other noticed that in the last 2 years which is quite unlikely.
To cite the whole paragraph:

This means you are missing the client library needed for a database backend – mysqlclient in this case. You can resolve this issue by either installing the library (using the usual way to do this depending on your operating system) or by specifying the backends you want to install the CLI tool with.

The first sentence is quite explicitly saying that a client library is missing for some backend, which implies for me that this library is required for a specific backend.  The name of the library also clearly states that this backend is mysql. The second sentence indeed says that you could resolve that error either with installing the libs or specifying the backend you want to install. For me this does not mean that this choice is independent from what backend you want, but depending on you use case either one or the other variant is the solution you are looking for. Could be that I'm missing a nuance there as English is not my native language but for me this is pretty clear.
Anyway if you have a better wording there feel free to submit a PR changing that specific paragraph to the correct repository.

That being said (whether this is a bug in the documentation or the actual install), why can't this dependency be resolved wholly within Cargo / via crates? Why does there need to be an out-of-band dependency resolution?

This is not really possible because those database client libraries are plain old c libraries. Cargo does not control them therefore it cannot be managed via cargo. In theory it is possible to rewrite them in rust but at least for diesel that is out of scope. If someone does maintain such a rewrite in rust we may look into replacing the native dependency.


Get Attributes

Hello
how is the best way to get the attributes from a Block in a Layout?

Hi @Gora1000
To get the attributes for an instance of a block you have to get all the Inserts in the model, like:
CadDocument doc = DwgReader.Read(path);
foreach (Insert insert in doc.Entities.OfType<Insert>())
{
	//Do something with: insert.Attributes;
}

Let me know if this helps.

Hi DomCr,
thaks for your answer. With doc.Entities you get all blocks of type insert in the model space, but not from layout. For exsample I added a test.dwg to my answer.
[Test.zip]
I you open the file, you will find 3 Blocks in the Model space and in each layout the same one. In test.dwg two Layouts. If you use
CadObjectCollection<Entity> ent= doc.Entities;
you will get only three blocks from model space, but i need the Attributes from the Block in Layout.
If it should work, and i can change attribute values on the block in a layout. It is possible to save the changes at the same dwg file?

Each Layout has it's own Block associated to it, which is the one that contains all the entities, you can iterate throw all layouts using:
foreach (Objects.Layout layout in doc.Layouts)
{
      BlockRecord block = layout.AssociatedBlock;
      foreach (Insert insert in block.Entities.OfType<Insert>())
      {
	      //Do something with: insert.Attributes
      }
}

This way you will get all the block instances (Insert) in the Layout that you want.
You can save the file using DwgWriter but keep in mind that ACadSharp doesn't guarantees the integrity of the resulting file, so I would not recommend to override the file, instead save it with a different name.
Let me know if this helps.


create/ enhance Review page

Users can put their comments and reviews of  a particular place they have been to, or if they have purchased a particular package they can share their experience.

Hey mentor, I am participation in JWoC and I want to contribute in this, please assign this issue to me.

@Sushwetabm @prasukjain07 Welcome to the repo.
Sorry to close this issue.
Make sure to open the issues after coding period starts


requires 'osgi.bundle; org.eclipse.jdt.ls.core 0.0.0' but it could not be found

I'm attempting to follow the https://github.com/salesforce/bazel-eclipse/blob/master/docs/bef/install.md#installing-bazel steps (using the https://opensource.salesforce.com/bazel-eclipse/update-site location, not dragging that button as that somehow doesn't work for me), but am stuck with:
Cannot complete the install because one or more required items could not be found.
  Software being installed: Bazel JDT LS Eclipse Feature 1.5.3.v20221001-0354 (com.salesforce.b2eclipse.jdt.ls.feature.feature.group 1.5.3.v20221001-0354)
  Missing requirement: Bazel JDT LS Plugin 1.5.3.v20221001-0354 (com.salesforce.b2eclipse.jdt.ls 1.5.3.v20221001-0354) requires 'osgi.bundle; org.eclipse.jdt.ls.core 0.0.0' but it could not be found
  Cannot satisfy dependency:
    From: Bazel JDT LS Eclipse Feature 1.5.3.v20221001-0354 (com.salesforce.b2eclipse.jdt.ls.feature.feature.group 1.5.3.v20221001-0354)
    To: org.eclipse.equinox.p2.iu; com.salesforce.b2eclipse.jdt.ls [1.5.3.v20221001-0354,1.5.3.v20221001-0354]

Oh, simply installing using Help > Eclipse Marketplace searching for "Bazel" (and finding this) somehow makes it find that org.eclipse.jdt.ls.core.
FYI I faced this with both the Eclipse IDE for Java Developers as wel as the Eclipse IDE for Enterprise Java and Web Developers.
Do you want a PR to update the install.md recommending to use Eclipse Marketplace?
@guw

Looks like the install button is broken because the entry no longer exists.
Did you see this in the install.md:

Note: BEF users do not need the BJLS Feature. You should leave that unchecked.

I think "do not need" is wrong. It should say "must not".
Can you try with https://opensource.salesforce.com/bazel-eclipse/update-site-release-candidate/?

Yes, I always uncheck the JDK LS feature.


Embed Models Implementation

working on all the embed models, will do a first pass then see if we can optimize. the embed model has a lot of sub-models associated with it, so it will most likely be a bit heavy regardless.
will also add unit tests

(fyi, this wont build on it's first try, still need to commit the sub models)

I fixed this up manually and merged. In theory.


Syntax error

Syntax error from daemon_handler.py Traceback (most recent call last):   File "/opt/yin-yang/main.py", line 13, in <module>     from src import daemon_handler   File "/opt/yin-yang/src/daemon_handler.py", line 52     match change_values['key']:

You need at least python 10 to run it. Update all your packages, that should hopefully fix it.


Fix cc on only line

On the only line in a file, cc should not add a \n.
Also, finished the implementation of SubstituteLine with Change (alias S to cc as it should be).

Great!


Correct dist-git repo name

It turns out that dist-git repos for container images are all under
containers/.

/lgtm


Added option to maximize update rate of ICM on supported boards.

Tested on esp8266.
Left off by default as battery life will likely be more noticeable than performance increases.

@ThreadOfFate please rebase against main and look at the reviews.


Feature request: Merged build previews

As far as I can tell, a PR's preview is only based on the source branch's code and not on what the result of merging the PR into the target branch would give. Given that other PRs could be merged into the target branch in the meantime, I'd like to have build previews that show, assuming no merge conflicts, how changes in the target branch could affect the preview without necessarily having to merge the target branch back into the source branch first. I know services like Travis-CI offer this for their tests.
Thanks

Maybe I don't fully understand the request could you help me understand?
As it stands currently if you have your mainline branch say main which is just a static HTML page with "Hello" on it.
And you're working on coolnewfeature branch configured for previews against main.
When you make a text change on coolnewfeature to change "Hello" to "Hello World" and submit it for preview it will build on top of main and display "Hello World".
That is already the default behavior for PR previews.  Am I misunderstanding your request?

What if I have a branch called anothernewfeature that changes something else and I merge it before merging coolnewfeature, and then I push something new to coolnewfeature?

This sounds like something that can be solved with the following git workflow:
You can to rebase coolnewfeature against main to get the latest changes from anothernewfeature which was checked into main.
Then once you do that you can push changes to coolnewfeature which would have both changes.
So the workflow would be:

Check-in anothernewfeature changes
git pull to get latest changes in main branch
Rebase coolnewfeature against main
Add whatever new changes to coolnewfeature locally
Push coolnewfeature changes to your git repo on github so PR previews would pickup the changes.


Multi-threading support was not running the desired number of threads

This PR fixes an issue regarding the parallel procedure implemented for retrieving the derivatives in solvers. This issue was spotted by @wxmerkt yesterday, when he observed that the multi-threading support was using all the cores (making conflict with other components such as the Gazebo simulator).
Additionally, the PR includes a few extra parallelization routines.
@wxmerkt -- please try this PR from your side ;)

For me the PR is good to go. The last thing remaining is to remove the duplicate definitions of nthreads in shooting problem, and use only the nthreads from solver. Other than that, it is ready to merge

I also think it is better (i.e., more flexible) to have different nthreads. With this, the user can enable a Ns number of threads for simd (or potentially forward and backward passes), and Np number of threads for computing derivatives, rollouts, quasiStatic, etc.
What is your final though about this?

I don't see any reason for separating the two. It is better to have a simpler API for a user. Multiple definitions of the same feature is an exposure that would provoke more faqs than user benefit.

I don't see any reason for separating the two. It is better to have a simpler API for a user. Multiple definitions of the same feature is an exposure that would provoke more faqs than user benefit.

Ok, we can do that.
However, we still need to keep nthreads_ internally in the shooting problem class.
There are two options that I see:

Remove SolverAbstract::nthreads_ and use Shooting::nthreads_ in each solver routine.
Keep both nthreads_ (for solver and shooting problem) and then call ShootingProblem::set_nthreads when we call SolverAbstract::set_nthreads.

The option 1 seems to be more aligned with what you prefer to do.
The option 2 also makes the work that you request, but still give the freedom to have different nthreads (for advanced users). But this option is also a bit more complex than current one.

Option 1 sounds good to me

Option 1 sounds good to me

done!

Thank everyone for reviewing this PR


Channel Master: Alternative Maya's channel box

Channel box alternative

[ ] custom channel list configurations
[ ] color coding
[ ] easy keyframe icons and functions (like softimage)
[x] slider precision options (like houdini)
[ ] quick filter/search
[ ] not need to have the object selected to have an active channel list
[ ] option to controls the Channel Master widget transparency.

Some inspirational references:
Naughty Dog

https://youtu.be/oGDIMftV4ng?t=2797
Softimage Keying panel

XSI right click menu ref

Icons color coding

[ ] Callbacks for sync. Deactivate when playback or scrolling time
[ ] Configuration needs to be persistent in the scene
[ ] Also Export/import configuration
[ ] Selected channels and middle-click scroll in the 3d view should function as default channel box

This seems nice @miquelcampos
It might worth creating a css stylesheet for this gui as well so that we can give it a controlled display... I could actually build color themes as well on this...

@jdrese  I will check on that.

here is a little WIP image using Pyflow widgets.

@jdrese these widgets already work with CSS style :D

This is so cool @miquelcampos
Definitely going to be a super useful add. Maya's channelbox is rudimentary in some ways. The do have the precision incremental values thing but the readability of it all is quite bad.

WIP image

The slider is then in a different box than the typing value right? In Maya they are both in the sale box. Could by nice (preference wise) to be able to hide the sliders. What do you think?

Nop it is in the same box. it is a widget from pyflow
But yep hide the slider can be a cool addition :)

@jdrese I think just by setting a minimum width will work like expected

@miquelcampos that is great !

another WIP Gif

Nice I really like it @miquelcampos. 👏
Good addition the open source icons. 👍
From what I see on the gif I have one single comment and that would be that I am not a huge fan of the copy/paste top bottom layout on those buttons. I know this is purely personal. It is just that menu bars have more often their layout been horizontal and not vertical. The +/- buttons make more sense to me as you place them. I would say as well that the borders on the big menu box thingy (don't know what it is)  are too round. It visually clashes with the buttons on the side. Again this is purely subjective.

@jdrese thanks for the feedback
I have removed the round corners.   The big box is just a search box. I did it bigger to fill the space

about the copy-paste icons. I kind of like it like that to keep everything compact.

I think these 2 buttons will be used less. But still want to add it to the UI.
this is a little inspired in Softimage UI design

Okay I see what you are going for. What are the +/- buttons for?
Due to the size of the icons I would recommend putting the search bar bellow or above the buttons layout and make it thinner.  What I find visually bothering is the fact that the horizontal line gets cluttered with the lock and reload/cycle buttons.
Promise I will stop now 😃 bothering you with UI stuff. I am not an expert on this matter. Exited of checking this one out.

@jdrese  the +/- buttons are to add channels from other controls. This will allow creating configurations/ combinations of channels from different objects.
I will think more about the layout arrangement. :)
Thanks for the feedback!

@jdrese here is a quick re-arrange

Still thinking about it :P

another option:

I like the last one better for sure as the search bar clutters less the view now and you have more space for the buttons. If you are not adding new buttons to fill the hole that you now have I would recommend just using some passing in between them (horizontally) to fill the space evenly and this spacing reduces the margin of miss-clicks specially when you are using a tablet or touch device...

@jdrese  good point,

but...  when it is very small

The one on the right seems good no? You can still try to drive the icon size depending on the UI with size but I think that is not fully necessarily. As long as on the "default" type of size things are readable and tight then it's up to the user to set the size they want. When it comes to responsible UI's like on webdesign Qt is not make for this type of things unfortunately.

@jdrese after a few tests I think I have one that I like

I will keep it for the moment and maybe review later when the tool is close to finish :)

HAhaha, now I feel bad about myself making you go all that way. I'll let myself out 🚶...

The notes in this ticket are now split in a different ticket to track better all the progress and commits


Routes

Coverage increased (+5.7%) to 81.746% when pulling d76dd331eb33ddec71520505f997e4d41880ea4d on detail-routes into 2501354edea8b6bed9e413846505d2051f3a4192 on master.

Coverage increased (+5.7%) to 81.746% when pulling d76dd331eb33ddec71520505f997e4d41880ea4d on detail-routes into 2501354edea8b6bed9e413846505d2051f3a4192 on master.

Coverage increased (+5.7%) to 81.746% when pulling d76dd331eb33ddec71520505f997e4d41880ea4d on detail-routes into 2501354edea8b6bed9e413846505d2051f3a4192 on master.

Coverage increased (+5.7%) to 81.746% when pulling d76dd331eb33ddec71520505f997e4d41880ea4d on detail-routes into 2501354edea8b6bed9e413846505d2051f3a4192 on master.

Coverage increased (+8.9%) to 84.936% when pulling 0a854aac2f17952abf278f80157e887fbcc303ee on detail-routes into 2501354edea8b6bed9e413846505d2051f3a4192 on master.

Coverage increased (+10.8%) to 86.77% when pulling 0a01ba5feb2bd65ed118935a2434da4098a6353f on detail-routes into 2501354edea8b6bed9e413846505d2051f3a4192 on master.

Coverage increased (+10.8%) to 86.77% when pulling 0a01ba5feb2bd65ed118935a2434da4098a6353f on detail-routes into 2501354edea8b6bed9e413846505d2051f3a4192 on master.

Coverage increased (+10.0%) to 85.992% when pulling bc6471b61e58bf88014f08c3b089c1690136556e on detail-routes into 2501354edea8b6bed9e413846505d2051f3a4192 on master.

Coverage increased (+10.0%) to 85.992% when pulling bc6471b61e58bf88014f08c3b089c1690136556e on detail-routes into 2501354edea8b6bed9e413846505d2051f3a4192 on master.

Coverage increased (+12.8%) to 88.803% when pulling 7955af4b2a423995940c48ee2ebfe96eee17017a on detail-routes into 2501354edea8b6bed9e413846505d2051f3a4192 on master.

Coverage increased (+12.8%) to 88.803% when pulling 7955af4b2a423995940c48ee2ebfe96eee17017a on detail-routes into 2501354edea8b6bed9e413846505d2051f3a4192 on master.


fixes a panic! when searching from ‘val_start_idx’ in ‘haystack’

the result has a ‘val_start_idx’ offset that should be added for slicing haystack properly

Good catch!


add python backend

Using tornado web framework

Hi... thanks for this!!! Very appreciate contribution.. I will test it and merge .
👍 👍 👍

Thank you!


NhatTruyen: Update the domain

Closed #4173
Checklist:

[ ] Updated extVersionCode value in build.gradle for individual extensions
[x] Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
[x] Referenced all related issues in the PR body (e.g. "Closes #xyz")
[ ] Added the isNsfw = true flag in build.gradle when appropriate
[x] Have not changed source names
[ ] Have explicitly kept the id if a source's name or language were changed
[x] Have tested the modifications by compiling and running the extension through Android Studio
[ ] Have removed web_hi_res_512.png when adding a new extension

Link to an issue in your PR so we can see what you are trying to solve

I new in here, how i can link to issue ?

Link to an issue in your PR so we can see what you are trying to solve

I new in here, how i can link to issue ?

You write the number of the issue after a # (so like #number) in the pull request up top before the checklist

Thank for helping me!!!

Now should I just wait or do I need to do anything else?

Question, did you install Android Studio to do this? Or did you do this in the GitHub editor? Did you test that it works?

my friend help me with this, he using some thing to test and is work, i just up file to github.

My friend just check, everthing is work, he just check by Android Studio.


APP fix - not working with more than 4 units

If connected 5 or 6 units, Android app, can controll only 4 first, 5ft unit will change 1 unit values, 6th unit not changing band/channel (tested with 9600 and 57600 baud rate)

Duplicate of #22


git pre-commit hooks for detecting credentials

I'd like to get the community's input on this topic before I do a pull request.
When a credential is leaked to a public GitHub repo, it is a pain rotating credentials.
Cloud Foundry uses these git-hooks for solving this problem. I tested our last two leaks. This tool caught both of them. The git-hooks rely on cred-alert for detecting issues.
I'm thinking of including git-hooks-core into workstation-setup.

+1 for automating this process.
If used with a repo, what types of activities will cause cred-alert to trigger?

This is a great idea.
I was reading about this tool earlier today: https://github.com/awslabs/git-secrets
Not sure what is the best practice. I’m guessing we could automate setting up a global git hook? The AWS one seems to need to be set up with some regular expressions which wouldn’t make it a set-it-and-forget-it solution.


Improve error messages

In some cases, java exceptions are displayed directly in error message notification. Need to provide more user-friendly messages.

We need to display the amount of skipped lines due to errors and the n first errors. An advanced parameters in all steps should be "max_errors". Technically speaking, we already have an error_handler in most steps. We can refactor it in more abstract classes to handle errors with this advanced setting. By default i suggest max_errors should set to 0 .

@millboh Putting a max_errors for each step sounds like a bit overkill. We can add a global settings max_errors, and pass it in dag request. For the default value, 0 seems too strict, and it will break some existing projects.

@bhou I suggested max_errors to be step specific because it actually depends on the volume of data processed. For an excel source 0 might fit but if you process TB of data you'll need a different max_error value.


Doesn't work on Ubuntu 16.04, firefox 56

Installed eve-ng-integration 0.4.1-0 on Ubuntu 16.04.3 LTS with Firefox 56.
When accessing a running node I got this: "Firefox doesn’t know how to open this address, because one of the following protocols (telnet) isn’t associated with any program or is not allowed in this context."
Couldn't find telnet, capture or docker in Preferences → Applications.
Tried logout/login and reboot.
Chrome on the same machine is working fine.

Firefox says The address wasn't understood when you clicked on a device


Decide on some sensible Rubocop defaults

Leave comments here for pain points that we should fix, when we come to it.

Metrics/MethodLength:
  Enabled: false

Though the default method length in rubocop is too short, I think it's probably good to have SOME protection from our future selves writing unreadbly-long methods!

Dan mentioned pulling over the gov uk robo cop integration at some point: https://github.com/alphagov/rubocop-govuk


Test examples incrementally

currently we test all examples every time and do so outside of bazel
its not really possible (or at least not easy) to make the examples truly hermetic - mostly because they rely on system docker - if we were to switch to rules_docker they would still need to parse/translate the docker-compose instructions into docker rules
we can however make it almost hermetic - by using a bazel sourced docker-compose, using the required files as inputs and setting an action_env that set the container hash to use for envoy
potentially this can take a massive load off ci as well as making it faster, and also making it easier to (incrementally) test examples locally

one downside to using docker-compose from pypi is that it doesnt easily work on ARM (due to pynacl compile issues)

actually seems docker-compose release binaries - so that should resolve that issue i think


Update 4.0 Readme documentation

The way to set up the bullet kits seems to have changed, current docs confused me a little while setting it up.
I've made some changes locally but I'm not sure how to create a pull request.

Ah yeah, you mean the BulletKit creation step?
Right, it has to be updated.
Did you find other outdated parts?

That was the main source of my confusion, yes :)
The part about selecting animated_shader.gdshader could be expanded on a little. It seems like it is necessary to add the shader for the bullet to display at all. Also, when you are configurating a bullet you need to change the file selector to display all files to be able to select the shader (not sure if this is worth mentioning.)
In the collision detection section there is a line:
var bullet_damage = Bullet.get_bullet_property(bullet_id, "data").damage
That should be "Bullets" rather than "Bullet"
Finally, For best performance, toggle use_bvh off in Project Settings -> Physics -> 2d. - I don't think this option exists anymore in Godot 4 (or it got renamed to something else.)
Thanks for the quick reply.

Updated the 4.x branch.


Align CSS scrollbar styling to MDN for Samsung Internet 25

Fixes https://github.com/Fyrd/caniuse/issues/7118.
I have not tested it myself, but relying much like OP of that issue on MDN:

https://developer.mozilla.org/en-US/docs/Web/CSS/scrollbar-width#browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/CSS/scrollbar-color#browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/CSS/scrollbar-gutter#browser_compatibility

Thanks!


[feature] ViewersCanDownload editable

Can you add the feature which allow to enable or disable "ViewersCanDownload" flag from file stats?

Hello there @andre4nap, thank you for reporting this issue and welcome to drive!
So this will be an awkward one as there isn't yet have a way of properly editing an individual file. However I think this is reason enough to spin up a command to edit attributes on a file, so sure this can be added :)
Thank you for requesting for this.

thanks for reply. i'm looking forward to see this feature :)


[Bug] Image/video files get corrupted when uploading from AmazonS3 plugin

Description
Image/video files get corrupted when uploading from AmazonS3 plugin
Steps to reproduce the behaviour:

Go to AmazonS3 plugin.
Upload file using filepicker widget.
Download the file from AmazonS3 directly or using download option in button.
Try to open file.

Important Details

Version: Cloud
OS: MacOS/Linux
Browser: Chrome

fixed with PR #3012


Aborting deploys

I think it should be possible to do the following:

Abort a deploy while the builder is building the image
Abort (and rollback) while the application is partially rolled out
Abort when the first node can't be deployed because health checks are failing (iirc, this isn't being done right now)

In the worst case, you don't want to wait until a faulty commit has been fully deployed before you can roll it back.
I would love to hear thoughts on this. Thanks!

https://github.com/deis/controller/pull/792 addresses 3) for RCs and when Deployments lands (and people enable that) that is also the default way it behaves (part way due to Deployments themselves)

regarding the point 1 if you are talking about the stopping a git push deis master we had tried that but it is not possible as the git client doesn't send any signals or interrupts while aborting it.

we had tried that but it is not possible as the git client doesn't send any signals or interrupts while aborting it(CTRL+C).

To elaborate on this, we perform the build operation during git's pre-receive hook. Aborting the git push won't send a signal to the hook because it has no attached connection to the user. The user invokes an SSH session when they run git push deis master, but that session is not attached to the user's keyboard in any way.

deis/controller#792 addresses 3) for RCs and when Deployments lands (and people enable that) that is also the default way it behaves (part way due to Deployments themselves)
– @helgi

Thanks, I think that solves that point indeed!

regarding the point 1 if you are talking about the stopping a git push deis master we had tried that but it is not possible as the git client doesn't send any signals or interrupts while aborting it(CTRL+C).
– @kmala

Thanks for the explanation. It makes sense to me indeed, although it's a pity. I guess checking if a connection is still open would be a workaround, but I don't think that implementation would be really nice.

To elaborate on this, we perform the build operation during git's pre-receive hook. Aborting the git push won't send a signal to the hook because it has no attached connection to the user. The user invokes an SSH session when they run git push deis master, but that session is not attached to the user's keyboard in any way.
– @bacongobbler

Thanks for the backstory on this, appreciate all of your input on this!

Closing as these are design issues that we cannot resolve at this time due to how Workflow's infrastructure is set up.

@bacongobbler although sad, I understand completely. I asked Heroku as well, and they don't support this either (so they haven't thought about any way to do this either).
Maybe some day Git hooks will be allowed to be interactive. Till then, we'll be extra careful :)


(PUP-5014) Base class for JSON indirection terminus calls

log_exception() wrong.
In Puppet::Indirector::JSON, Puppet.log_exception() is called without
the required exception as the first argument value, instead the message
is passed.
This breaks further along in format_exception() as it attempts to get
the exception message attribute but finds a string:

@tdevelioglu good catch!
We did a quick audit and it looks like https://github.com/puppetlabs/puppet/blob/fb15a86cc822929fa346ea4ae27da3a6ac0e68bb/lib/puppet/indirector/msgpack.rb#L26 suffers from the same problem. (IIRC the msgpack support used the json support as a model, so this omission may have been faithfully reproduced.)
Do you mind extending your patch to include a fix for that one too?

Thanks the controbution @tdevelioglu! In addition to Kylo's comment, would you mind fixing up your commit message a little bit?
It would be a little clearer if you described what the fix is (passing the exception into log_exception) and why the fix was necessary (this broke formatting further down the line and caused puppet to raise an error).

@HAIL9000
Fix extended to the msgpack base class and updated the commit message.

Thanks again, @tdevelioglu !

@HAIL9000 in our triage notes, you were going to grep jira for tickets that might map to this. Did you get a chance to do that?

@kylog Not yet! I'll make some time for that this week


Disable centos-7-predictable-nic-builds

We don't need new images to continue testing the existing ones. The evidence looks pretty conclusive in favor of this being the culprit already.
/hold

DeleteAfter is set to 6 months, so we will still have the existing images for plenty of time while we test. Periodics will keep running.
/unhold
/cc @zmarano @elicriffield

/lgtm


mdx-loader not working with<EMAIL_ADDRESS>

After updating an existing React app lxkns to react-scripts 5.0.0 the documented method of using mdx-loader with babel-loader
import AboutMDX from "!babel-loader!mdx-loader!./About.mdx"

does not work anymore. AboutMDX contains a string which is the path name to the Javascript file compiled from the .mdx source, but not the required React component or function.

Yup, having the same issue here. Had to downgrade react-scripts to 4.0.3


Move to a different weather API

Expected behaviour.
!wea waters and !wea 49735 should output data
Actual behaviour.
Could not find weather data for:
Steps to reproduce behaviour.
!wea waters and !wea 49735
Notes/Code/Other information.
Using a valid API key

Now using Apixu's API!


[ui-grid-save-state] Placeholder gets stored and restored in gridApi.saveState.save()

I let the user save the grid state on the server using the plugin ui-grid-save-state.
When I call gridApi.saveState.save(), the filters object also contain the placeholder text. So when I later decided to remove the placeholder text in the configuration of the grid, the text magically reappears when gridApi.saveState.restore is called.

Yes, placeholder is one of the things it is designed to save.  You have four options:

Set the flag so that it doesn't save filters
Massage the state object so that the placeholders are removed
Call save state again when you remove the placeholder text
Remove the placeholder text again after you restore state.

Aha. Per design. That doesn't quite make sense to me - but you must have considered benefits that I don't see right now.
I messed around quite a bit with Kendo UI Grid before ui-grid.info solved all my requirements, so you must have thought the specifications out quite thoroughly. Thanks!

There's a huge assumption in there - that we know what we're doing!!  I wanted to save filters, as they're clearly something a user can change that we would want to restore.  I included placeholders mostly as a side effect of that - I wanted the whole filter object because we allow people to create custom directives and therefore put custom attributes in the filter object.  I hadn't considered that people might change placeholders dynamically, so hadn't really considered needing to avoid saving them.

That's how development is, right? Different needs create different solutions. You must do what you think is best for ui-grid as a whole. Listen to everyone but don't do as everyone says :+1:

I think I modified this a week or so again to not save placeholder, and therefore I hope to not restore placeholder.  Could you check again?


Update README to clarify repository main goal

Update README to more precisely describe the problem which is solved by this library. The essential part of this repo is not only provide wraps of Polly policies, but also create proper order in which policies should applied to provide correct request/response flow. Otherwise you may get unexpected behavior of you http client.

Also should add link to the NuGet repo in the README header

Will be released in version v2.0.0.
See milestone v2.0.0


Discuss and implement PGP support.

I am a heavy GPG user, and I belive it's a PITA for a mass audience. But it's almost the only game in town for hardware keys support, so security-minded people will probably want to use that.
GPG support is not implemented, but can be added at later time.
The identity would look like this:
from:
  id-type: pgp
  id:  4488680DA3CF5F2B4756ED873D23EC2392F2EDE7
  url: "https://github.com/someuser/crev-proofs"

The exported public key will be embedded into git repo somewhere.The pgp WoT won't be involved at all here: just 1:1 match between the ID and gpg identity to use to check the signatures against.
Also, review timestamp should be checked to within time of life of a PGP identity.
When the PGP key goes out of life, the author will just create a new one, and set the trust to the old one as high.
It should be fairly straightforward to add, but it is not high on my personal priority list.

I think it makes sense to reuse existing key infrastructure like PGP yes. Though trusting a PGP identity should of course not be equal to trusting his code reviews ;)

@stevenroose Yes. GPG's WoT is completely out of the picture for Crev. WoT-s between GPG and Crev serve different purposes: confirming that underlying identity is true vs trusting someones code reviews.

But that doesn't take away the utility of using PGP identities for crev, though.

I have created this ticket for a reason. I'm not disputing utility of supporting PGP. 😎

In terms of integration with cargo-crev, what would be considered acceptable?
I can think of the following models, in increasing level of complexity:

cargo crev just outputs unsigned files, then the user manually signs them using plain gpg, then cargo crev reimports the signed files
cargo crev invokes the gpg cli to automatically sign the files (I think it should work as long as gpg-agent is running in the same session, but I am not 100% sure)
cargo crev integrates natively with gpg via Rust somehow (not sure there are even the necessary bindings for this)

I guess a similar interface to git for signing commits may be used: https://help.github.com/en/github/authenticating-to-github/telling-git-about-your-signing-key

https://sequoia-pgp.org/ , haven't checked if they have SC support already.

there is a pure rust pgp implementation available under the pgp crate. this is currently used in rustup for signature validation, so already is in use by the wider rust community
disclaimer: I maintain that crate

Another way is to only cross link identities, as you can not only use email in gpg identities. See e.g.: https://github.com/wiktor-k/openpgp-proofs


Fix math client

I fixed some points because src/ruby/bin/math_client.rb does not work.

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @ganmacs isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
CLA GitHub bot

CLA signed.

LGTM, and thanks. But can you please squash these four commits down into one before merging?

Thanks 😄


Kaizoku doesnt load properly

Describe the bug
So I wanted to install the docker container on my homeserver while its bound to gluetun (vpn).
The deployment of the container seems to work but for some reason the page on port 3000 is permanently loading

I took a look at the logs of each service and found this in the kaizoku service:

My current docker compose file looks like this:
docker-compose.txt
Could anyone here help me to figure out the problem?
Thanks in advance!
Reproduction steps

Start a gluetun (vpn) container
Edit the docker compose file of Kaizoku so that it is bound to the vpn container (as above)
Run the docker compose file of Kaizoku
Wait a minute so that the web interface shows up
See that the gui is up
Wait another few minutes so that the service of kaizoku can generate some logs
See that the circle on the webpage is permanently spinning
Take a look at the logs and see that theres the mentioned error

Expected behavior
The expected behaviour in my case would be that the gui isnt in a permanently loading state and that there wouldnt be any errors in the kaizoku service
Additional context
UserID and GroupID 1004 is my docker user which has full access to each of the directories that are mentioned in the compose file
No response

I fixed the problem myself.
I had to change the entry
- REDIS_HOST=redis
to
- REDIS_HOST=localhost
after that everything worked without a problem


Suggestion: Ender I/O Remote Awareness Automation

The Ender I/O need an Upgrade in the time of the Inventorypanel. The Ender I/O with the RAA Upgrade should give the player the abillity to autocraft things in the panel in this way:
In a range of 5x5x5 Blocksthe I/O with the RAA upgrade should be able to be linked to 3 Machines and hold 3 crafting recipies per machine. With each capacitor upgrade, the count of machines that can be linked to the I/O increase by 1 and recipie slots should increase by 2.
To function it need 1mb per action of "dew of the void"
To create crafting tasks you have to encode crafting task crystals or something like that. A nice additon is that purple particles move from the I/O to the machine where your automatic crafting task is done.

Thank you for your suggestion. It has been added to our list or possible enhancement.
This ticket will be closed because we want the list of open tickets to reflect known issues.


Dashboard: most common phrases

Extract the most common phases used (for the current month).
To implement this, you should look into full text search solutions, like Elasticsearch (Heroku has free Elasticsearch add-ons).
The technique to extract common phrases is called n-gram tokenisation, see Elasticsearch's implementation here: https://www.elastic.co/guide/en/elasticsearch/reference/current/analysis-ngram-tokenizer.html
The dashboard should consider 2 and 3-word n-grams, and should display the ten most common n-grams. See the picture attached for reference.
You are required to display the 10 most common n-grams together with their frequency. No other data shown in the reference picture is required.

close in https://github.com/GRP-17/feedback-frontend/commit/5278a21089dfc3d691fc629e4d92d9add580806b


Have to sign in every day

I am using the PWA version of the app (which mostly works awesome), but the one problem I have is that it requires me to sign in every day I use the app - can the token lifetime be extended or something?

Hi!
Oh, you are among the rare users of the PWA, congrats ;)
This is strange because I don't need to sign in every day... Will look into this next week.
Do you have more details to share to help us investigate?

Every time I open the PWA (have tried numerous delete/install cycles, no change) I get the "No legacy projects! Well done!" screen.
On clicking "Back to dashboard", then first time each day I get "Please login before accessing the required page.". I don't have to actually enter credentials, but it is a clunky process of clicking sign in and waiting a while.

Oh I see.
Indeed this launch screen worked with the previous version but is a bit off now.
Will fix this and let you know.

Hi @stacy-rendall do you still have issues?

Hi @loicknuchel, it still seems to be happening:

close Azimutt browser/PWA
open browser/PWA
always redirects to https://azimutt.app/login page - just clicking "Sign In with GitHub" will sign in without requiring username/password, but requiring that step means it is not as smooth as it could be

That's strange, I don't have it personally.
Are you on private browsing or did you cleared cookies? (they are needed to keep you authed).
Would you be able to make us a video showing this with you dev tools opened? (you can send it ah<EMAIL_ADDRESS>


How to trigger "to.owl.carousel" event on clicked Item

Please give the solution for this

same problem. how to interact with the main carousel from thumbnails ?

Same problem, you can't interact with a thumbnail

Same problem

Same problem. I think this issue is related to , which is not merged yet.

Hi, any solution on this? I need the to.owl.carousel event on my project.

Same problem

Still an issue? It got solved?


Add casts to RegisterECSTaskDefinition.ps1

Issue #, if available:
fixes #132
Description of changes:
Add casts and change protocol to tcp
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This one as well!


fix: pop logs in log segment after cleaning up logs

Description
The description of the main changes of your pull request
Related Issue(s)

closes https://github.com/delta-io/delta-rs/issues/3062

The snapshot is not valid anymore after you remove the logs from the object store. The logs don't exist, hence the snapshot should not reference them anymore.
However in its current state we still reference files in the log segment that are deleted from the object store, which causes vacuum to fail because it tries to read each file from the log segment

The snapshot is not valid anymore after you remove the logs from the object store.

I still donÄT understand how that situation arises :) - are we deleting data?

hence the snapshot should not reference them anymore.

could we just discard the snapshot then? i.e. have the function just consume the snapshot? It is a snapshot after all :) which can go invalid if the table is updated ...

The snapshot is not valid anymore after you remove the logs from the object store.

I still donÄT understand how that situation arises :) - are we deleting data?

Yes, cleanup_metadata removes the physical log files, and also post_commit_hook removes logs if the interval for it has been met.
So in two instances the Snapshot will become invalid. Only by forcefully reloading the table it will be fixed

hence the snapshot should not reference them anymore.

could we just discard the snapshot then? i.e. have the function just consume the snapshot? It is a snapshot after all :) which can go invalid if the table is updated ...

Replaying the log stream seems more compute intensive, then just popping the log files you know got deleted from the object store


New version: TrajectoryOptimization v0.4.2

Registering package: TrajectoryOptimization
Repository: https://github.com/RoboticExplorationLab/TrajectoryOptimization.jl
Created by: @bjack205
Version: v0.4.2
Commit: d55d44069f097c16d0081e4f8beaeb989a0e0ed0
Reviewed by: @bjack205
Reference: https://github.com/RoboticExplorationLab/TrajectoryOptimization.jl/commit/d55d44069f097c16d0081e4f8beaeb989a0e0ed0#commitcomment-46553331

@bjack205 :point_up:
[noblock]

@bjack205 :point_up:
[noblock]


Various back-end spelling and grammar corrections

Most of these corrections are within comments in the code, but there are a couple from the Markdown documents.

Conflicts

Conflicts

Fixed.

Remove anything that changes run-time code.
Remove all edits of Foundry type definitions.


Attributes refactor and specification

The attributes are currently not well-specified and there seem to be ways to implement them better before we release the (much more stable) v0.3.
Goals:

Rust structures (with serde) with typed values for known attributes (and a map for user/unknown)
Split Task and DataObject attributes (required by the above, will allow checking in Python and other clients)
Specify a fixed encoding for rich and user-specified values (current proposal: JSON with base64 binary data) (note that non-trivial binary data in attributes are generally discouraged)
Create a rich Attributes class in Python (underway in #60)
Fix and document the new structure semantics

Schema for spec/info transfers

Resolved in v0.3 both in client, server and executor, documentation updated to describe individual attributes.


Fetch wrapper error handling

TODO: Make it compile

TODO:

Fix sign-in.tsx
Fix create-account.tsx
Fix manage-account.tsx
Supply router in account-button calls to api.tsx
Supply router in sampling page to api.tsx
Proceed to fix remaining compilation problems
Write in the Issue the logic behind my management of AccountButton state and cookies
Remove user email references since I'm not going to bother with a confirmation email

TODO:

Figure out why 401 responses get "Error while fetching" error messages as opposed to something more informative.

TODO for future branches:

Write in the Issue the logic behind my management of AccountButton state and cookies
Remove user email references since I'm not going to bother with a confirmation email
Fix backend problem with delete-account (currently I get a 500 Internal Server Error).

Okay, the culprit for the generic "Error while fetching" bug seems to be with redirecting to the sign-in page. The error message mentions something about mutable cookies. I don't know what's going on, but I'm wrapping fetchWrapper inside client-side code that has access to a router anyway, so let's just do redirecting there.

Let's merge!


Call CRASH_COND_MSG if key not found in HashMap get(key) functions.

HashMap is currently calling ERR_FAIL_COND_V(!res, *res) when calling get(TKey) and TKey isn't found in the HashMap table. This would result in a dereferenced null pointer being returned to the caller, which is what (I assume) the ERR_FAIL_COND was trying to prevent. If the key is not found in the HashMap then there is no safe TData to return. A CRASH_COND_MSG at least enables a message to be generated before crashing.

@madmiraal Is this still desired? If so, it needs to be rebased on the latest master branch.

Rebased as suggested.

18:17 <Akien> reduz: do you agree with #33061 or should another approach be used?
18:19 <reduz> Akien: looks good

Thanks!

Cherry-picked for 3.2.3.


responseValidator:  value expected to be an array/object but is not

one call to my api generates a 301 redirect response. the function call in node looks like this:
res.redirect(301, 'http://example.com');

my swagger-spec for this api-call looks like this:
      responses:
        301:
          description: "Successful request."
          headers:
            Location:
              description: "redirect URI"
              type: "string"
          schema:
            type: "string"

on validation i get the the following 500 Internal Server Error:
SyntaxError: Response validation failed: value expected to be an array/object but is not

this is because swaggerValidator thinks the response value is a model (see swagger-validator.js:91).
the schema passed to mHelpers.isModelParameter() to retrieve if the value is a model does not have a "type" key since its the "301" object from the swagger-spec. although the schema does not allow a "type"-key at this level. any suggestions?

Is that the actual response definition that throws the Error because based on that, and my testing, it should validate whether or not the response is a string.  The only way mHelpers.isModelParameter() would think the value is a model is if it's of type object or there is no type in which case the default is object.  The schema you have does not fit either of these scenarios.
On a different note, I would expect a 301 to not have a schema attribute for its response because a 301 does not have a payload body.  When you have a response without a schema, it means that is a void response or a response with no body.

yes, i think so. when i debug i see the value that shall be validated is the message generated by express i guess:
Moved Permanently. Redirecting to http://example.com

the schema that validateValue() uses to retrieve whether its a model or not is
{
    "description":"Successful request.",
    "headers":{
        "Location":{
            "description":"redirect URI",
            "type":"string"
        }
    },
    "schema":{
        "type":"string"
    }
}

although validateValue() expects to have a key type at the same level as description but thats not allowed by swagger schema specs

That is the response definition, not the response schema.  That could explain why it's broken but why that is being chosen instead of the schema value above is beyond me.  Let me see if I can create a test case that reproduces this.  What surprises me is this use case is no different than the existing test cases we have already: https://github.com/apigee-127/swagger-tools/blob/master/test/2.0/test-middleware-swagger-validator.js#L634  That test tests response validation passing for a primitive (non-object) without issue.    DEBUG=swagger-tools* node app.js (Change for whatever the server's entry point script name is)

i made a gist here. maybe its more explaining.

With your gist, I get this:
_http_outgoing.js:335
    throw new Error('Can\'t set headers after they are sent.');
          ^
Error: Can't set headers after they are sent.
    at ServerResponse.OutgoingMessage.setHeader (_http_outgoing.js:335:11)
    at Array.write (/private/tmp/testing/node_modules/express/node_modules/finalhandler/index.js:126:9)
    at listener (/private/tmp/testing/node_modules/express/node_modules/on-finished/index.js:169:15)
    at onFinish (/private/tmp/testing/node_modules/express/node_modules/on-finished/index.js:100:5)
    at callback (/private/tmp/testing/node_modules/express/node_modules/on-finished/node_modules/ee-first/index.js:55:10)
    at IncomingMessage.onevent (/private/tmp/testing/node_modules/express/node_modules/on-finished/node_modules/ee-first/index.js:93:5)
    at IncomingMessage.emit (events.js:104:17)
    at _stream_readable.js:908:16
    at process._tickCallback (node.js:355:11)

This is due to you calling next() after calling res.redirect.  If I remove that line, I do get an error content issue but it seems to be valid.  Basically, Express is returning a Content-Type of text/html with a payload of:

Moved Permanently. Redirecting to http://example.com

If I update your produces from text/plain to text/html, the error no response validation no longer occurs and the redirect works as expected.  This is working as designed.


distortion and irregularities in simulation in ignition gazebo 4

Environment

OS Version: Ubuntu 18.04 (Virtual Machine)
Source or binary build?
binary installed (version below)

adwaitnaik@ubuntu:~$ ign gazebo -v
[Msg] Ignition Gazebo GUI    v4.6.0
[Msg] Ignition Gazebo Server v4.6.0

Description

Expected behavior: The animal should simulate normally as it does in the Blender (version 2.8). Please see the images below

Actual behavior: File format

terminal throws the following error

[GUI] [Err] [RenderUtil.cc:879] invalid animation update data

The animal is distorted and disoriented in the ign gazebo (please see the image below)

Steps to reproduce
Link to the files below (files are in .dae and .sdf format)

model file
collada file

Thanks

Cool model :deer:
We have some actors that were created on Blender and animate correctly on Ignition, like Male visitor. The tricky part is that it usually takes us some back-and-forth with various Blender export settings until we get the models to work correctly on Ignition. Once we figure out the fail-proof export settings, we'll write a tutorial for the community.
Meanwhile, I think you could try changing some settings when you export from Blender. You could also try exporting the animation to BVH to see if that helps. It's also possible that our ColladaLoader may need some tweaks to properly support that model.
Please let us know if you get it to work!

https://answers.gazebosim.org/question/26731/irregularities-in-simulation-in-ignition-gazebo-4/


Replace 'trade markers' with a more generic markers

I like the trade markers. They're great.   But often, you just want to also put markers at other random points, on the chart to highlight things for whatever reason.
This is why I think the 'trade marker' should just be abstracted into a more generic 'marker' on-chart display and you just set the marker you want to use.
Maybe something like.. .
onchart {
	'drawings': [
		{
			'name': 'my first set of markers'
			'type': 'marker'
			'data': [
				[x,y],
			]
			'settings': {
				'marker': '↑'
				'color': '#A2FF00'
				...etc
			}

		}
	]
}

Thanks for the suggestion, of course, I thought about this, but I'm kinda short on time now. The main priority is to make an extended data structure to provide greater freedom for users (e.g. see your previous issue about custom candles).
Meanwhile you can easily implement your own marker class! And it's really easy if you know the canvas API. This library called hackable for a reason.

I'm new to npm/vue.
I did manage to get this running, however the grin example didn't work for me.
I will have a play, I would love to contribute more in terms of overlays etc

Have you tried trading-vue-101 ?
Yeah, if you create an advanced marker overlay (or something else) I'd love to add it in the collection.

Yes I did get the grin running on the 101, will keep trying and playing with it see if I can ultimately add some value to this project. Which I would like to do because this is imo the best plotting library there is right now.
Few other things of importance of course, multiple y axis on each chart 'pane', feeding in real time data, good for live or 'playback' etc etc. .  but yeah this project is ace. I tell everyone about it .

Great!
The project was designed specifically to be easy-expandable. And even at this stage almost every possible indicator could be implemented. However, I'd like to focus more on the implementation of the building blocks, because the main goal of the project is to be expressive. Custom y-axis is on the map for sure.
I hope to push some updates next week.
Thanks for promoting the stuff!


Add  to FAQArticleDetailContent

LiveURL: https://kiwicomsmart-faq-gjookrrjtq.now.sh

@jaroslav-kubicek I have made the requested changes + resolved merge conflicts.
However, I get flow errors on the merge commit, and I don't understand why. I'm a little stuck. Do you have a suggestion? :-)

@kantord I have a suggestion for another approach.
If you decorate the export of src/StaticFAQ/FAQArticle.js with the withRouter provided by react-router, you will have access to all the past entries of history - particularly at props.history.entries of that component.
I.e.
//Rest of src/StaticFAQ/FAQArticle.js
export default createFragmentContainer(
  withRouter(FAQArticle),
  graphql`
    fragment FAQArticle_article on FAQArticle {
      id
      title
      perex
    }
  `,
);

Wouldn't this solve the Breadcrumbs info-requirements?

notice breadcrumb designs for articles that come from search or articles that are found from going through the tree structure are different:

@git-toni

you will have access to all the past entries of history - particularly at props.history.entries of that component.

As @jaroslav-kubicek pointed it, it might be harmful to assume that there will be any history entries at all.  If, in a future version, we have to use a magic URL to take the user to a specific article for example, history will be empty.

@kantord

If, in a future version, we have to use a magic URL to take the user to a specific article for example, history will be empty.

That's also a concern indeed. I imagine we need to clarify how the magic links will be created - eg. will it have the user history embedded? My initial idea regarding magic links was that they would be built on backend looking something like /smart-faq?info=4rWnKLaW_3e0R, and that we could decode that hash and read data about the route. But that might not be enough? :sweat_smile:

@git-toni
Yes but in that case, I think it'll still be easier to use an URL internally, because:

we are already using a router based on URL
If we used history inspection, then we'd have to reconstruct history based on that API

However, if we use URL for the same purpose, just by pushing a new URL to history, the state reconstruction will already be implemented.

@jaroslav-kubicek @git-toni looks like I finally solved the issues and now the solution correctly handles search + has all path steps. I also resolved the conflicts

Some relay issues apparently, can you confirm? :broken_heart:

@git-toni hmm, seems to work fine here. Does yarn relay change anything?

I'm talking about the deployed version to now.sh

hmmm weird :-D Any ideas?

Great job!


set_logger wants to panic

This is the same as https://github.com/rust-lang-nursery/log/pull/187. Seeing if the CI is any less confused by this PR. cc @alisha17

The answer is 'no'.


error in chainable piping with event emitters

TypeScript Version:
1.8.7
Code
private streamProcess(stream: NodeJS.ReadableStream): Promise<void> {
    return new Promise<void>((ok, fail) => {
        stream
            .pipe(this.parser.createStream()) // returning type is `NodeJS.ReadWriteStream`
            .on("error", fail)
            .pipe(this.transformer.createStream()) // returning type is `NodeJS.ReadWriteStream` and error appears in the line
            // error TS2339: Property 'pipe' does not exist on type 'EventEmitter'.
            .on("error", fail)
            .pipe(this.persister.createStream()) // returning type is `NodeJS.WritableStream`
            .on("error", fail)
            .once("finish", () => {
            });
    });
}

Expected behavior:
Actual behavior:
i got error if only set event emitters, what's the wrong of the code?

What version of node.d.ts are you using? Can you make sure it's completely up to date?
The version I'm looking at seems to use this typing so that your chained calls should maintain the type. See here.

Also, as a general rule, these sorts of questions really belong on StackOverflow since the team gets so many issues a day. I am curious as to whether there's a bug on our end though.

i use "github:DefinitelyTyped/DefinitelyTyped/node/node.d.ts#2d64e0d9450e084b30f5c0e39e88a5a861a6d7c1"
https://raw.githubusercontent.com/DefinitelyTyped/DefinitelyTyped/2d64e0d9450e084b30f5c0e39e88a5a861a6d7c1/node/node.d.ts

Update your .d.ts file to the latest and it should work.


support includes and not_includes filter

Hi Aakash,
thanks for your effort. I am not against having that feature, but there a couple of things to discuss

The not is redundant, that can be achieved with just negating the condition
There seem to be no tests
I would prefer sub tree that does not require changes to the string literal

Hi Michael, sorry for delay. I am busy with some other commitments so give me some more time I will make the changes according the points that you have mentioned. Thanks!

Hi Michael, I have made changes as you suggested. Please let me know if any further polishing is required. Thanks!

Hi @AakashSorathiya
I took your code and your intention and reworked it a bit so that it fits the goal of our project here.
The only difference here is that I switched the meaning of lhs/rhs.
So now it reads lhs.includesAll(rhs).
I hope that it is ok, it just feels more in line how things have been don in this project so far. Sorry if this is probably different in your (spoken) language.
Thanks for your contribution, will merge soon.


[Suggestion] Add line removal option for annotations

Annotations are a very good resource because they allow you to place text exactly where you want. For some use cases, having a line that attaches the annotation to a specific location is not a nice approach to add an information box in a specific area, but the text boxes element are not explicitly staying in a location but moving within the map.
I created this JS example that hides line of the annotation by reducing the width of the ball (the line length can't be set to 0, minimum seems to be 5 px but still the ball doesn't disappear).
Is there any easy approach that we could use to make the annotations usable in cases where you want to "label an area"?

cc @saleiva

I too would love to see this feature added to the Editor. I can think of many instances where we would have implemented this and it would be a great value add.
Thanks, Mark

Hey @MarkWS, getting this to the backlog. Thanks for your feedback!

I @MarkWS Could you provide some more use cases for this?

we just came across this as well. It was an Oil/Gas map and the client wanted the main basins labeled, not with a pointer but with just the annotated box in the 'general area'. If we were to have had a line, the end users could make the mistake that the indicated point is the oil production basin, when it's actually thousands of sq miles.
Also for the Fodor's maps we are working on, we had the designers ask for 'geographic areas' to be labeled with the annotated boxes. Like "National Parks of the South West" or "Great Basins National Parks". These are just a few examples and the removal of the line and pointer ball would be very helpful and we would use that quite often. ~ Mark


DestinationArn for vendor kinesis cannot be used without roleArn

Hi @theburningmonk.
I am getting the following error in the subscribe function when I create a new log group.
{
    "errorMessage": "destinationArn for vendor kinesis cannot be used without roleArn",
    "errorType": "InvalidParameterException",
    "stackTrace": [
        "Request.extractError (/var/task/node_modules/aws-sdk/lib/protocol/json.js:48:27)",
        "Request.callListeners (/var/task/node_modules/aws-sdk/lib/sequential_executor.js:105:20)",
        "Request.emit (/var/task/node_modules/aws-sdk/lib/sequential_executor.js:77:10)",
        "Request.emit (/var/task/node_modules/aws-sdk/lib/request.js:683:14)",
        "Request.transition (/var/task/node_modules/aws-sdk/lib/request.js:22:10)",
        "AcceptorStateMachine.runTo (/var/task/node_modules/aws-sdk/lib/state_machine.js:14:12)",
        "/var/task/node_modules/aws-sdk/lib/state_machine.js:26:10",
        "Request.<anonymous> (/var/task/node_modules/aws-sdk/lib/request.js:38:9)",
        "Request.<anonymous> (/var/task/node_modules/aws-sdk/lib/request.js:685:12)",
        "Request.callListeners (/var/task/node_modules/aws-sdk/lib/sequential_executor.js:115:18)"
    ]
}

If I add the roleArn property as:
let options = {
    destinationArn: arn,
    logGroupName: logGroupName,
    filterName: 'ship-logs',
    filterPattern: '[timestamp=*Z, request_id="*-*", event]',
    roleArn: role_arn,
  }

and
      role_arn:
        Fn::GetAtt:
          - CloudWatchLogsRole
          - Arn

Then I get the following error.
{
    "errorMessage": "User: arn:aws:sts::275307759108:assumed-role/cloudwatch-logs-to-logzio-dev-subscribe-eu-west-1-lambdaRole/cloudwatch-logs-to-logzio-dev-subscribe is not authorized to perform: iam:PassRole on resource: arn:aws:iam::275307759108:role/cloudwatch-logs-to-logzio-dev-cloudwatchrole",
    "errorType": "AccessDeniedException",
    "stackTrace": [
        "Request.extractError (/var/task/node_modules/aws-sdk/lib/protocol/json.js:48:27)",
        "Request.callListeners (/var/task/node_modules/aws-sdk/lib/sequential_executor.js:105:20)",
        "Request.emit (/var/task/node_modules/aws-sdk/lib/sequential_executor.js:77:10)",
        "Request.emit (/var/task/node_modules/aws-sdk/lib/request.js:683:14)",
        "Request.transition (/var/task/node_modules/aws-sdk/lib/request.js:22:10)",
        "AcceptorStateMachine.runTo (/var/task/node_modules/aws-sdk/lib/state_machine.js:14:12)",
        "/var/task/node_modules/aws-sdk/lib/state_machine.js:26:10",
        "Request.<anonymous> (/var/task/node_modules/aws-sdk/lib/request.js:38:9)",
        "Request.<anonymous> (/var/task/node_modules/aws-sdk/lib/request.js:685:12)",
        "Request.callListeners (/var/task/node_modules/aws-sdk/lib/sequential_executor.js:115:18)"
    ]
}

Any thought what can it be? I haven't modify the code from the repo.
Thanks,
Pedro

Try adding passRole to iamRoleStatement eg
  iamRoleStatements:
    - Effect: "Allow"
      Action:
        - "logs:PutSubscriptionFilter"
      Resource: "*"
    - Effect: "Allow"
      Action:
        - "iam:PassRole"
      Resource: "*"

Seems to match what is required/documented here:
https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/SubscriptionFilters.html

The above recommendation by @hampsterx didn't work for me.

@hampsterx, @pedrodelgallego @andrhamm, thank you for raising the issue and finding a fix for it.
I've added a PR for fixing this issue.
In addition I've changed the configuration to be more robust, so you can use environment variables to override some basic configurations.
@theburningmonk - Can you please review it?

Hi guys, thanks for reporting this. Sadly this project is no longer necessary, per se, as I have published a version of this as a SAR app, here which lets you specify the ARN for the target to be either Lambda or Kinesis.


[BUG] Ally/neutral team relation trough command from admin/console

What is the bug?
Missing command (/teama) to set ally/neutral team relation as an admin or console.
Expected Behaviour
Implement this command
How to Reproduce
None
Error message
No response
Output of /teama version
None
Additional Information
No response

This bug has been fixed and the patch will be included in the next update. Thank you for reporting.


Add serialize support.

Close #11

Do we need NoSkip mode that doesn't skip serializing the unset flags and values?
Do we need NoSkip in runtime or can be a feature?

NoSkip might be good for generation schema?


Feature/communities served table join test

Description
Clearly documents the reason for the pull request and what has changed. Delete this test and add your own.

[ ] This is a bugfix.
[x] This is a new feature.
[ ] This is part of a feature.

Organization

[x] Have you linked this pull request to a Trello card?

Review

[x] Have you added two reviewers to this pull request?
[ ] Is this a work in process?
[x] Is this ready to be reviewed?

 build database table structure and relationships


lxd/images: calculate sha256 as image is written

This pull request didn't trigger Jenkins as its author isn't in the whitelist.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

jenkins: test this please


first readme example breaks

$ node -v
v7.0.0
$ npm -v
3.10.8

$ tree . -L 2
.
├── package.json
└── pages
    └── index.js

$ cat pages/index.js
import React from 'react'
export default () => {

Welcome to next.js!

}

$ cat package.json
{
  "name": "next-play",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "dependencies": {
    "next": "^1.0.0"
  },
  "devDependencies": {},
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1",
    "start": "next"
  },
  "author": "",
  "license": "ISC"
}

$ npm start

><EMAIL_ADDRESS>start /Users/ext.dmosher/code/next-play
> next

> Ready on http://localhost:3000
Warning: Component(...): A valid React element (or null) must be returned. You may have returned undefined, an array or some other invalid object.
{ Invariant Violation: Component(...): A valid React element (or null) must be returned. You may have returned undefined, an array or some other invalid object.
    at invariant (/Users/ext.dmosher/code/next-play/node_modules/fbjs/lib/invariant.js:38:15)
    at ReactCompositeComponentWrapper.mountComponent (/Users/ext.dmosher/code/next-play/node_modules/react/lib/ReactCompositeComponent.js:194:121)
    at Object.mountComponent (/Users/ext.dmosher/code/next-play/node_modules/react/lib/ReactReconciler.js:47:35)
    at ReactCompositeComponentWrapper.performInitialMount (/Users/ext.dmosher/code/next-play/node_modules/react/lib/ReactCompositeComponent.js:370:34)
    at ReactCompositeComponentWrapper.mountComponent (/Users/ext.dmosher/code/next-play/node_modules/react/lib/ReactCompositeComponent.js:257:21)
    at Object.mountComponent (/Users/ext.dmosher/code/next-play/node_modules/react/lib/ReactReconciler.js:47:35)
    at /Users/ext.dmosher/code/next-play/node_modules/react/lib/ReactServerRendering.js:46:36
    at ReactServerRenderingTransaction.perform (/Users/ext.dmosher/code/next-play/node_modules/react/lib/Transaction.js:138:20)
    at renderToStringImpl (/Users/ext.dmosher/code/next-play/node_modules/react/lib/ReactServerRendering.js:44:24)
    at renderToString (/Users/ext.dmosher/code/next-play/node_modules/react/lib/ReactServerRendering.js:74:10) name: 'Invariant Violation', framesToPop: 1 }

@davemo
pages/index.js should be:
import React from 'react'
export default () => (

Welcome to next.js!

)

() let's you return the expression while {} creates the block and not a return

@impronunciable ah, thanks, I typed it out instead of copy/pasted and had the wrong parens :(

@davemo that's how we learn :)


fix(env-wrapper): handling user handler import error

:tada: This PR is included in version 1.63.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Audioband not working

After I installed I placed the utility on my Taskbar but when I hover over audio source option I don't get anything. I am not very good with this stuff but I can follow specific instructions. I read the last comment pertaining to this issue and did as you said. I ran the Unblock script but still no fix.

Also is there any way to stop the process so I can delete the folder to attempt to re-install from step one?

Run the uninstall and then restart explorer. Some files are probably still blocked so try unblocking the zip file itself and re-extract the files, then install. If that works, I'll update the documentation to make it better.


Please invite me to the GitHub Community Organization

Name
Super Smile
Discord Username (if applicable)
No response
Additional Context
I want to learn here and I want to help others also.

It's great having you contribute to this project
If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Invitation sent for the GitHub Organisation. Welcome to the community 🎉#
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/jaidevstudio/people
Like this

Tips for practising:
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps


hydra: 2019-11-13 -> 2020-02-06

Motivation for this change
https://github.com/NixOS/hydra/compare/20dd0bbe6a90d9066e635ee82e98efec23b17e51...2b4f14963b16b21ebfcd6b6bfa7832842e9b2afc
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg test hydra

@GrahamcOfBorg test hydra.nixStable hydra.nixUnstable hydra.nixFlakes


Order state updated from filling to open

It appears its possible that the app receives a offer before it finished to submit the market order. Judging from the logs below, the order was set to Filling when the RenewOffer was received and afterwards set to Open. That unfortunately overwrites the execution price, thats why the app finally crashes because the order did not have an execution price.
[ERROR] TIME: 2024-05-15T18:26:50.552849Z r: Aborting after panic in task info: panicked at mobile/native/src/trade/position/mod.rs:88:59:
order to be filled

[INFO] TIME: 2024-05-15T18:26:45.468012Z r: Processing message from: 022ae8dbec1caa4dac93f07f2ebf5ad7a5dd08d375b79f11095e81b065c2155156,kind: RenewOffer
[DEBUG] TIME: 2024-05-15T18:26:45.468842Z r: Received message from: 022ae8dbec1caa4dac93f07f2ebf5ad7a5dd08d375b79f11095e81b065c2155156
[INFO] TIME: 2024-05-15T18:26:45.487135Z r: Automatically accepting renew offer channel_id: b6d22404bc4ef1e2c38654a982cced949bd5d4b3299b7954b1726af40337718d
[INFO] TIME: 2024-05-15T18:26:45.491164Z r: Received match from orderbook order_id: ba7d33e2-dbff-4025-899e-af926a0caee8
[INFO] TIME: 2024-05-15T18:26:45.496266Z r: Updated order state new_state: Filling,order_id: ba7d33e2-dbff-4025-899e-af926a0caee8
[WARN] TIME: 2024-05-15T18:26:45.497527Z r: Could not remove non-existing order order_id: f3512254-099b-4607-a74d-37af01fddb9a
[WARN] TIME: 2024-05-15T18:26:45.523602Z r: Could not remove non-existing order order_id: f4fc4404-3659-4b74-995d-37651b6946f0
[WARN] TIME: 2024-05-15T18:26:45.524633Z r: Could not remove non-existing order order_id: 4eadb96f-6999-4a63-b173-e7e101b4f4b3
[WARN] TIME: 2024-05-15T18:26:45.525520Z r: Could not remove non-existing order order_id: 9a4f1eb6-2ee7-49b4-8e03-cecf0460ccba
[INFO] TIME: 2024-05-15T18:26:45.541125Z r: Updated order state new_state: Open,order_id: ba7d33e2-dbff-4025-899e-af926a0caee8

I was able to reproduce this bug by adding a small timeout after posting the market order and before updating the order state to Open


Change using db

Let's say I have a main database, and I need the auditlog to have its own database

Let's say I have a main database, and I need the auditlog to have its own database

Hi ! Thanks for this issue !
This is a duplicate of #321, which has a link to the doc. So, I'm closing this issue.


Fix PATH processing when creating a Ruby process

The RubyHelper manipulates the path environment however due to Object property names being
case sensitive it could simply be that it's called Path or path, particularly on Windows
not so much on Linux etc.. It's also possible that there is no PATH set but unlikely.
This causes issues on some systems whereby it can't start the Language Server.

Merged


Updates for mkdocs.

I have not, I moved it forward because features were needed
Nautobot, pynautobot are both on versions close to this or this
Will do, wonder how we can automate this.

Read through all of them. Nothing that looks to deviate from SemVer. Interesting that the combination we have been using works at all. Found this nugget in release notes for 9.1.19: Added support for MkDocs 1.5+

Read through all of them. Nothing that looks to deviate from SemVer. Interesting that the combination we have been using works at all. Found this nugget in release notes for 9.1.19: Added support for MkDocs 1.5+

Hah! Thanks for reading through :)
I think this is ready to go, but we'll hold on merging PRs for a wee bit until we release v2.3.0.

I've updated this PR with changes tested in https://github.com/nautobot/nautobot-app-dev-example/pull/37 to fix #147 and update dependencies to latest for docs builds.


Add options to self-host mclo.gs

This is an extremely helpful utility, however in some cases (for public servers and specifically in my case, self-hosted servers), it's nice to keep everything as centralized to the owner as possible in order to maintain control. This can be especially true for server logs as (even with IPs being removed) they can hold relatively private information depending on the plugins used. For example the coordinates to a player's secret base, or the link to a private web page used by server staff that's logged to the console on server startup as a plugin is loaded.
This is why I'd like to request a configurable way to change the destination from https://mclo.gs to someone's own self-hosted instance of aternosorg/mclogs. This is additionally also helpful (although not a proper solution) in combating search engine crawlers as mclo.gs is now a pretty commonly used site and I've personally had one of my uploaded logs easily findable by typing the server name in quotes into Google.

This has been added in v2.3.0


Reset declined weather location

If user declines location in their browser, they should be able to reset their settings and enable location for weather.
Add "enable weather button" to the settings section.

Already fixed in #49