Prevent UpdateStatus loops

There is a regression introduced in #14 that made controller to go into infinite UpdateStatus loop.
When we create a EtcdStorage object, we create a ReplicaSet and a Service, and then set the Deployed condition.
Then, it calls the updateEtcdStorageStatus function, which invokes the UpdateStatus function.
However, the UpdateStatus function invokes UpdateFunc method, which requeues the EtcdStorage object.
It goes in the syncHandler again, but as we're not checking is there any difference, we're updating the status again, using the UpdateStatus function, which invokes UpdateFunc method again, and we go into the infinite loop.
That causes the controller to misbehave, as well as causes the performance degradation.
In logs that looks like:
...
I0628 17:51:50.408695   32568 etcdproxy_controller.go:240] Successfully synced 'etcd-name'
I0628 17:51:50.408749   32568 event.go:218] Event(v1.ObjectReference{Kind:"EtcdStorage", Namespace:"", Name:"etcd-name", UID:"76da23f5-7aea-11e8-8dec-7085c249f105", APIVersion:"etcd.xmudrii.com", ResourceVersion:"7967", FieldPath:""}): type: 'Normal' reason: 'Synced' EtcdStorage synced successfully
I0628 17:51:50.608408   32568 etcdproxy_controller.go:240] Successfully synced 'etcd-name'
I0628 17:51:50.608452   32568 event.go:218] Event(v1.ObjectReference{Kind:"EtcdStorage", Namespace:"", Name:"etcd-name", UID:"76da23f5-7aea-11e8-8dec-7085c249f105", APIVersion:"etcd.xmudrii.com", ResourceVersion:"7969", FieldPath:""}): type: 'Normal' reason: 'Synced' EtcdStorage synced successfully
I0628 17:51:50.808702   32568 etcdproxy_controller.go:240] Successfully synced 'etcd-name'
I0628 17:51:50.808784   32568 event.go:218] Event(v1.ObjectReference{Kind:"EtcdStorage", Namespace:"", Name:"etcd-name", UID:"76da23f5-7aea-11e8-8dec-7085c249f105", APIVersion:"etcd.xmudrii.com", ResourceVersion:"7971", FieldPath:""}): type: 'Normal' reason: 'Synced' EtcdStorage synced successfully
...

This PR adds the check before applying the Deployed condition. If condition is already present and true, we're not updating the EtcdStorage object.
/cc @deads2k @sttts

One nit. But lgtm.


Nearest neighbors doesn't work

from apricot import FacilityLocationSelection
import numpy

X = numpy.random.uniform(0, 1, size=(500, 500))

FacilityLocationSelection(100,n_neighbors=10, verbose=True).fit(X)

n_neighbors parameter gives an error, when I remove it it works fine.

I have a similar error when I import apricot.
Traceback (most recent call last):
File "", line 1, in
File "/Users/mac/opt/anaconda3/lib/python3.7/site-packages/apricot/init.py", line 4, in
from .functions import FeatureBasedSelection
File "/Users/mac/opt/anaconda3/lib/python3.7/site-packages/apricot/functions/init.py", line 4, in
from .featureBased import FeatureBasedSelection
File "/Users/mac/opt/anaconda3/lib/python3.7/site-packages/apricot/functions/featureBased.py", line 7, in
from .base import BaseSelection
File "/Users/mac/opt/anaconda3/lib/python3.7/site-packages/apricot/functions/base.py", line 12, in
from ..optimizers import BaseOptimizer
File "/Users/mac/opt/anaconda3/lib/python3.7/site-packages/apricot/optimizers.py", line 11, in
from .utils import PriorityQueue
File "/Users/mac/opt/anaconda3/lib/python3.7/site-packages/apricot/utils.py", line 20, in
from sklearn.neighbors import KNeighborsTransformer
ImportError: cannot import name 'KNeighborsTransformer' from 'sklearn.neighbors' (/Users/mac/opt/anaconda3/lib/python3.7/site-packages/sklearn/neighbors/init.py)

What version of apricot and sklearn are you using?

I have a similar error when I import apricot.
Traceback (most recent call last): File "", line 1, in File "/Users/mac/opt/anaconda3/lib/python3.7/site-packages/apricot/init.py", line 4, in from .functions import FeatureBasedSelection File "/Users/mac/opt/anaconda3/lib/python3.7/site-packages/apricot/functions/init.py", line 4, in from .featureBased import FeatureBasedSelection File "/Users/mac/opt/anaconda3/lib/python3.7/site-packages/apricot/functions/featureBased.py", line 7, in from .base import BaseSelection File "/Users/mac/opt/anaconda3/lib/python3.7/site-packages/apricot/functions/base.py", line 12, in from ..optimizers import BaseOptimizer File "/Users/mac/opt/anaconda3/lib/python3.7/site-packages/apricot/optimizers.py", line 11, in from .utils import PriorityQueue File "/Users/mac/opt/anaconda3/lib/python3.7/site-packages/apricot/utils.py", line 20, in from sklearn.neighbors import KNeighborsTransformer ImportError: cannot import name 'KNeighborsTransformer' from 'sklearn.neighbors' (/Users/mac/opt/anaconda3/lib/python3.7/site-packages/sklearn/neighbors/init.py)

This error can be fixed by replacing the following line in "utils.py"
from sklearn.neighbors import KNeighborsTransformer
from sklearn.neighbors import KNeighborsClassifier as KNeighborsTransformer


How do you make it not generate a .ini

You can override the ini filename to nothing, which prevents imgui to save settings and therefor write a ini file.
You will have to manually save your window settings if you do that if you want to remember your window position, sizes, etc.
IO = imgui.get_io()
IO.ini_file_name = "".encode()

You can pass the imgui.WINDOW_NO_SAVED_SETTINGS flag into when calling imgui.begin(...).
Note that you will likely need to add this flag everywhere you call begin.  So you may want to set it as a variable with other default flags you use.
Example:
imgui.begin('This has no saved settings', False, imgui.WINDOW_NO_SAVED_SETTINGS)

You can pass the imgui.WINDOW_NO_SAVED_SETTINGS flag into when calling imgui.begin(...).
Note that you will likely need to add this flag everywhere you call begin. So you may want to set it as a variable with other default flags you use.
Example:
imgui.begin('This has no saved settings', False, imgui.WINDOW_NO_SAVED_SETTINGS)

This is a per-window option, the comment from @Froyok completely disables ini writing.


In loadShader() casting between pointers is an undefined behavior.

According to strict aliasing rule casting a pointer type to another pointer type with a more strict alignment is undefined behavior. So in loadShader() casting char *shaderCode to moduleCreateInfo.pCode (which is uint32_t*) is undefined behavior.

The strict aliasing rule has a special exception for char pointers. Char pointers may alias any other pointer (except restrict pointers).

That's true. But in the function the alias is a uint32_t* pointer, not char.

The original pointer is a char pointer and may alias. The cast is valid as long as the alignment requirements of uint32_t are satisfied, which they are since all allocations from new satisfy alignof(max_align_t).

Why do you think that char pointer can be aliased? I'd be very grateful for the link to the standard or similar. I'm not a language lawyer and my reasonings are based exclusively on cppreference documentation, stackoverflow questions, and numerous articles.
For example, the aforementioned Type aliasing section enumerates all valid cases. And it doesn't mention I can cast from char. But I can do the opposite way (AliasedType is std::byte, char, or unsigned char: this permits examination of the object representation of any object as an array of bytes).
Additionally, this very often quoted article has a similar to our discussion example where it shows that casting char array to an int violates strict aliasing.

Closing this due to inactivity. If the issue still persist, please open a new issue.


Re-org QG code to align with OneQA folders

jaydesen created the following on Apr 20:
    - utils folders to have helper functions.
   - table processors would be in /the processors folder.
   - R2G/QG can share Table specific helper functions.

Original issue: https://github.ibm.com/ai-foundation/PrimeQA/issues/130

On May 09, jaydesen commented:
TableQG folder structure is re-orged to match the OneQA/MRC folder structure with /models, /processors, /trainer and ../oneQA/Exxamples folder.

On Jun 07, saneem-cg commented:
This is done.

This is done. Changes merged in PrimeQA.


Updated .help to include all commands

Add all commands to the .help command for a better experience for users.

Added with v1.3.0.


express.text({ type: '*' }) doesn't parse requests bodies without Content-Type header on express 5.x

express.text({ type: '*' });
express.put('*', (req, res) => {
  console.log('Request Body:', req.body);
  res.end();
});

now If you send a PUT request without Content-Type header, it will print this:
Request Body: undefined

Which means express.text didn't work and thus req.body remained unpopulated.
Workarounds
Although a workaround like this works but it doesn't feel right. type: '*' is supposed to be able to handle everything.
// working workaround
express.text({ type: () => true });

Working Implementations
https://github.com/touhidurrr/UncivServer.xyz/blob/03cf8bff12ab5e69fa416291906fae608e04e5bc/src/server.js#L49

Although I have encountered this on express 5.x, It might persist on 4.x too.

Hello, yes, this is working as designed. String arguments are passed to type-is which are used to match against a content-type header. As you saw, you can pass a function thay returns tru if you want to match every request. I hope that helps!

Oh then should I close this? I dunno what is done when an issue with the tag https://github.com/expressjs/express/labels/question is answered.


codegen output b692d349ad634744a30432902b3ea47c

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 37.91%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
6134

Relevant Lines:
12163

💛  - Coveralls


GraphQL Endpoint Example

Hi, I am trying to write a GraphQL Apiary documentation for my team, but doesn't see one yet.
Do you have some suggestions? It has to cover both query and mutation usage.
If I got time later, I could submit a pull request.

@yuchunc,
at this point you can document the GraphQL endpoint and pretty much define all the types with MSON / Attributes however you will have problems with queries and mutation definitions.
At this moment API Blueprint is tailored to HTTP APIs and not really useful with RPC-like API (such as GraphQL). There is a plan to abstract protocol layer and enable other API styles but no work has started on it..


Add elastic-ci-stack pod definition

The goal of this pod definition is to make it walk and talk as close to the Elastic CI Stack for AWS AMI as possible, to allow lift and shift of those existing pipeline workloads on to Buildkite On-Demand.
TODO

[ ] Add waiter for the agent/main container to wait until the docker in docker container has booted and created the docker listen socket, currently there is a race condition between the main container and dind container
[ ] Add container reaper to cluster that kills the sidecar containers once the "main" container that runs the agent has exited, something like https://github.com/nrmitchi/k8s-controller-sidecars, so that the dind container is killed
[ ] Add horizontal pod auto scaler

[ ] Deploy metrics-server https://docs.aws.amazon.com/eks/latest/userguide/metrics-server.html ?
[ ] Figure out pod graceful termination a la ASG lifecycle hooks

[ ] Docs / automation (possibly using terraform with mixed aws + k8s providers) for:

[ ] A pod-spec that encodes the 'instance type' as resource requirements
[ ] An on-cluster k8s service account and IAM mapping for the stack’s required IAM policy + any provided managed policy arns (https://docs.aws.amazon.com/eks/latest/userguide/create-service-account-iam-policy-and-role.html)
[ ] ConfigMap that stores the stack’s parameter json for the init-container to consume and configure the pod at runtime a la EC2 UserData

I’ve added docs and a working example CloudFormation template + k8s service account to get per-pod IAM roles working:

The last part of this will be to utilise the pod role to ssm:GetParameter & kms:Decrypt the agent token at the point of use, as well as authenticate the s3secrets plug-in.

I’ve added config and a pre-agent install-elastic-ci-stack.sh script which prepares the pod for the agent in the same way as the EC2 UserData does.

The plug-ins are running with the pod IAM identity now. We still need a way to pair individual "stack" pods with their config, right now it is simply hard coded in the agent-scheduler to get it working.
I think ideally this would be hard coded in a "pod definition library" entry which the agent scheduler reads at schedule time. So what we’ll need is a way (or simply docs!) to generate the pod spec for the definition library from an example or template YAML file.


Metrics Improvements project request

and a few typo fixes

Can we merge this as a proposed PD even if it is not (exactly) happening this quarter?

@cshenry @dcchivian @aparkin @RoyKBase @psdehal @eapearson: Apropos our recent email thread about usage metrics, how about weighing in on this Usage Metrics Improvements PD? I think we should add a "User Stories" section for our usage metrics wishlist. For example, Erik mentioned
classify narratives by how well-used they are — e.g. app and data contents, run time, # of saves (versions), # collaborators.
Chris listed a number of metrics that would be interesting; he grouped these into three categories (users who enter KBase via a featured Narrative link; new "fresh" users; and SDK user/developers).
Pathway 1: Featured narratives linked either from KBase.us narrative library or publications
1.) How many users come to look at any existing narrative in the system?
2.) Of these users, how many ever return for a second visit?
3.) Alternatively, how many of these users create their own copy of the narrative?
4.) How many of these users actually run a method in this copy of the narrative?
Pathway 2: New fresh user
1.) How many users create a new narrative?
2.) What fraction of these go on to run a single methods?
3.) Of the users who run at least one method, on average, how many methods to they run?
4.) Of the users who run at least one method, how many return to the site over the course of multiple days?
Pathway 3: SDK
1.) How many users have successfully registered an SDK module in any of our deployed systems?
2.) Of these, how many have created a method different from the default example method?
3.) How many methods on average do users who make at least one different method make?
4.) How many such users have registered a module multiple times (signifying on-going dev)?
Other usage metrics requests:

How many usable "modern" Narratives are there now?
How many users with 2+ narratives created?  1 narrative?
How many users created a globus account, did not complete the signup process and join the kbase_users group, and never visited KBase?

I just copied those from the thread--I'm sure we can think of others! Let's create a wishlist and then, if/when this campaign is approved, Erik will have to prioritize the list of requested metrics based on how much time he has and how hard he estimates they'd be to implement.

Agreed! There are a few more.
Searchers
How do we characterize people who are just trying to find information:
How many people just use search and landing pages on the system?
How many people repeatedly use search?
Basic Narrative Stats:
Are Narratives being used to do collaborative work with complex data.
Mean shares per Narratives
Mean data objectsper NArrative
Mean object types per Narrative
Contains links to other Narratives
Total computational time used by Narrative

This is a year old, and much of the material is outdated. If it is still wanted, please merge and resolve conflicts against the current repo and resubmit.


[CARBONDATA-2098]Add Documentation for Pre-Aggregate tables

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[x] Any interfaces changed?
No
[x] Any backward compatibility impacted?
No
[x] Document update required?
Updated documentation
[x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
NA
[X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA

@sraghunandan  please add pre-agg example, it is better to have the performance comparison inside example.

@jackylk @chenliang613 added examples. pls review

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2167/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3406/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2171/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3283/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2201/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3441/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3305/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3471/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2231/

LGTM

verified, LGTM

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2233/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3473/


failed to load the emmet package...

linter-php,linter-jshint,atom-beautiy,and so on.many packages are failed to load width the same reason  since update atom to ver-1.012
env: ver1.015; win10 x86_64

the 'tab'  command not not found for me.

Config
{
  "core": {
    "audioBeep": false,
    "autoHideMenuBar": true,
    "openEmptyEditorOnStart": false,
    "projectHome": "e:\\",
    "themes": [
      "one-light-ui",
      "atom-dark-syntax"
    ],
    "disabledPackages": [
      "wrap-guide",
      "language-make",
      "language-mustache",
      "language-objective-c",
      "language-perl",
      "language-property-list",
      "language-python",
      "language-ruby",
      "language-ruby-on-rails",
      "language-sass",
      "language-shellscript",
      "language-todo",
      "language-toml",
      "language-yaml",
      "markdown-preview",
      "metrics",
      "timecop",
      "language-gfm",
      "language-go",
      "language-clojure"
    ],
    "excludeVcsIgnoredPaths": false
  },
  "editor": {
    "invisibles": {},
    "fontSize": 22,
    "fontFamily": "Source Code Pro",
    "softWrap": true,
    "showIndentGuide": true,
    "tabLength": 4,
    "zoomFontWhenCtrlScrolling": false
  }
}

Installed Packages
# User
No installed packages

# Dev
No dev packages

@netmou can you please move this over to emmetio/emmet?  Thanks.

no, update atom from v1.0.11 to  v1.0.15

then disabled the package  atom-beautify, the same just the errors were thrown from other packages

the specific error-info like this
Atom Version: 1.0.15
System: Unknown Windows Version
Thrown From: atom-beautify package, v0.28.12
Stack Trace
Failed to load the linter-csslint package
At Cannot find module 'atom-linter'

Error: Cannot find module 'atom-linter'
    at Module._resolveFilename (module.js:334:15)
    at Function.Module._resolveFilename (D:\Program Files\Atom\resources\app.asar\src\module-cache.js:383:52)
    at Function.Module._load (module.js:284:25)
    at Module.require (module.js:363:17)
    at require (module.js:382:17)
    at Object.<anonymous> (C:\Users\志强\.atom\packages\linter-csslint\lib\main.coffee:4:13)
    at Object.<anonymous> (C:\Users\志强\.atom\packages\linter-csslint\lib\main.coffee:62:4)
    at Module._compile (module.js:428:26)
    at Object.defineProperty.value [as .coffee] (D:\Program Files\Atom\resources\app.asar\src\compile-cache.js:169:21)
    at Module.load (module.js:353:32)

My os is windows 10, but atom can't recognize


Update README to reflect current API pricing... i.e. free.

HEY LOOK, I FIXED SOMETHING!  :cake:

Closing to open a second pull request which will resolve issue #2.


[WIP] M3-34 Tag component

This is not a big deal for me, but the X no longer has a border on the comps

@asauber fixed it, note to myself to always check the latest comps


Add functionality to allow addition of new value from yaml

This PR seems generally useful, thanks!
But I'm unsure of one aspect of the design. Can you give some more context on why you want to prevent adding new keys to a CfgNode when that node has a child CfgNode?
For example, in your test case you have:
cfg.KWARGS = CN(new_allowed=True)
cfg.KWARGS.z = 0

and to this, one can inject a new key, e.g. KWARGS.a, if it's of a valid primitive type.
But if I have
cfg.KWARGS = CN(new_allowed=True)
cfg.KWARGS.z = 0
cfg.KWARGS.q = CN()
cfg.KWARGS.q.foo = "123"

then I cannot inject KWARGS.a and in fact this config fails on construction.

It seems generally more useful to allow for adding new keys even when a child CfgNode exists.
It also seems like you might want to enable adding new child CfgNodes if the parent has new_allowed set to true (and these new child nodes should have new_allowed=True as well).

then I cannot inject KWARGS.a and in fact this config fails on construction.

Actually, you should be able to inject a new key, but as you say it fails on construction.

Can you give some more context on why you want to prevent adding new keys to a CfgNode when that node has a child CfgNode?

I think that adding CfgNodes from yaml is not necessarily a good idea, since we can't check that new keys have required type and might lead to subtle bugs (e.g. wrong indentation in yaml file) which would be difficult to figure out.

I think that you are right, we should let the end user decide how to organise the config.
Therefore, I removed the restriction from new values.
Now new nested CfgNodes can be added from yaml.

Thanks for the the back-and-forth refinement. I'll merge now.


Instagram now uses new image sizes

As some of you may know, Instagram now allows all sorts of image dimensions (not just a square). However, Instafeed.js always pulls in a square photo. This causes some white margins around each photo.
Has anyone found a way around this?

Came here to ask this. I hope the API isn't limiting us to squares!

I haven't seen any additions to the API that would allow me to grab the new image sizes.

Please let me know if anyone is able to discover something different.

I think it's possible!
http://developers.instagram.com/post/128288227716/api-migration-for-landscape-and-portrait-formats
"This is done by enabling a new setting called Migrations in the “Edit Client” dashboard."

Great minds think alike. Also looking for a solution...

Cool, thanks @ekauffer, I should have checked the blog. I'll have to dig into that.
Interested that its an "opt-in" feature currently. I'm not sure yet how that will affect this library.

I was wondering the same. Maybe we can also have an option to "opt-in" with instafeed? Off my default but there if required.
That way nothing will change for those who already have styles based on the square format.

+1 on this. I'd really like to be able to crop the white margins. On instagram, when browsing your feed, you see all square images; even if it's been shot as a different dimension. Something similar to that via this plugin would be fantastic.

Hey everyone! I released an update today v1.4 that includes instructions on using the new sizes, as well as a few template helpers to work with the varying image sizes.
Hope it helps! :tada:

Thank you Steven. Works perfect.

Thank you Steven!

Hi! I can't make it work. What is the solution to display images without white bars if non-square image? :) (Could anyone provide an example?)


fix(headless): modifying filters (facets) should reset the pagination

https://coveord.atlassian.net/browse/KIT-669

I can some cypress tests covering the full loop of these!


⚠ Bofrost.be has degraded performance

In 805008d, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2424 ms

Resolved: Bofrost.be performance has improved in 738c0e8.


API call Failed

When i try to get data's through API call(Web API) using fetch, the following error occurred please help me out on this
TIA

@react-native-bot please help me on this


Replace Twig_SimpleFunction with Twig_Function

Issue

#1417
tl;dr: A fatal error was thrown by activating a WPML Translation Management plugin stating that Twig_Function was expected instead of Twig_SimpleFunction.
This only happens when timber is installed via composer in the theme folder. So the cause could be that the file that was extending Twig_Function into Twig_SimpleFunction (in Twig code) was loaded after all the plugins.
Another point is that Twig_Simple_Function is getting deprecated in Twig 2.x, which Timber uses.
Solution
Search & Replace for Twig_SimpleFunction to Twig_Function.
Impact
Users should now be using Twig_Function, instead of Twig_SimpleFunction
Nothing that I'm aware of. The class named Twig_SimpleFunctionthat was extending Twig_Function was empty, so I guess there are no problems.
Usage
Use  Twig_Function instead
Considerations
To protect the ones still using Twig_SimpleFunction, we could create a file with the sole purpose of creating a class named  Twig_SimpleFunction and extending it from Twig_Function

Coverage remained the same at 93.427% when pulling b2b3fe37adcf9140fdfcb36534a57cd8d16fc606 on luism-s:develop into 8f54e7cb27f66859f43f82d3f7ad318c772f3218 on timber:master.

Coverage remained the same at 93.427% when pulling b2b3fe37adcf9140fdfcb36534a57cd8d16fc606 on luism-s:develop into 8f54e7cb27f66859f43f82d3f7ad318c772f3218 on timber:master.

oops, Travis failed, but only on PHP5, don't know why

@luism-s thanks! I'm rerunning those PHP 5 tests, it said there was a MySQL error...

Coverage remained the same at 93.427% when pulling bc30442b38dcd8ff0e2372e2db1d5335f9a5ec85 on luism-s:develop into 642130e2d1991ccbefd6e4efa5fec84fc3dd3917 on timber:master.

Coverage remained the same at 93.427% when pulling bc30442b38dcd8ff0e2372e2db1d5335f9a5ec85 on luism-s:develop into 642130e2d1991ccbefd6e4efa5fec84fc3dd3917 on timber:master.

Coverage remained the same at 93.427% when pulling 554b34a0c9f10101d555156dd9e1897a45a369e8 on luism-s:develop into 642130e2d1991ccbefd6e4efa5fec84fc3dd3917 on timber:master.

Coverage remained the same at 93.427% when pulling b10d8d3129d88fa38f4f45e8242dd80d8c5c3e0b on luism-s:develop into 642130e2d1991ccbefd6e4efa5fec84fc3dd3917 on timber:master.

Coverage remained the same at 93.427% when pulling b10d8d3129d88fa38f4f45e8242dd80d8c5c3e0b on luism-s:develop into 642130e2d1991ccbefd6e4efa5fec84fc3dd3917 on timber:master.

Coverage decreased (-11.5%) to 81.949% when pulling fca802374e7f95a167958fb9e99b5e8d4f286a12 on luism-s:develop into 642130e2d1991ccbefd6e4efa5fec84fc3dd3917 on timber:master.

Coverage remained the same at 93.427% when pulling 2ceba284e0df6918cb14b47aa0cf63326b0299bb on luism-s:develop into 642130e2d1991ccbefd6e4efa5fec84fc3dd3917 on timber:master.

Coverage decreased (-0.06%) to 93.368% when pulling 5970c565c4dc18cbaf29815e7de6cb4f7e6b0fbb on luism-s:develop into 642130e2d1991ccbefd6e4efa5fec84fc3dd3917 on timber:master.

Coverage decreased (-0.06%) to 93.368% when pulling 5970c565c4dc18cbaf29815e7de6cb4f7e6b0fbb on luism-s:develop into 642130e2d1991ccbefd6e4efa5fec84fc3dd3917 on timber:master.

Coverage decreased (-0.06%) to 93.368% when pulling 5970c565c4dc18cbaf29815e7de6cb4f7e6b0fbb on luism-s:develop into 642130e2d1991ccbefd6e4efa5fec84fc3dd3917 on timber:master.

Coverage decreased (-0.06%) to 93.368% when pulling 40d244a681e65657cdd486bab4e292f75d99adbc on luism-s:develop into 642130e2d1991ccbefd6e4efa5fec84fc3dd3917 on timber:master.

Coverage increased (+0.1%) to 93.56% when pulling 3676ac317bad5b79d59fa1de1ab4f943516f09af on luism-s:develop into 642130e2d1991ccbefd6e4efa5fec84fc3dd3917 on timber:master.

Coverage increased (+0.1%) to 93.56% when pulling 7917d096b0bca14affc0140c80f998e9551749fa on luism-s:develop into 642130e2d1991ccbefd6e4efa5fec84fc3dd3917 on timber:master.

@jarednova I made it. Only codecov is failing due to the large number of lines I changed on that file. I covered some lines of code with unit tests, but there's still some to go.
What do you think of this solution?

@luism-s thanks for updating this! Glad to see it works (my confusion on #1478). My only question is whether the naming makes sense. Right now its full path is...
Timber\Timber_Function
... because the functionality is really about exposing functions to Twig, I'm wondering if Timber\Twig_Function might make more sense?

Hm, OK, I really don't mind your name idea. I can do it later ;)

@jarednova Renaming the function to Twig_Function made the tests in PHP5 fail. Maybe it's a conflict with Twig's Twig_Function? I don'know what I'm doing wrong, honestly

Coverage increased (+0.3%) to 93.688% when pulling 662e090dd6181d9e70ce416dbfaed78614d96b4a on luism-s:develop into 642130e2d1991ccbefd6e4efa5fec84fc3dd3917 on timber:master.

Coverage increased (+0.3%) to 93.688% when pulling<PHONE_NUMBER>49eef60312fb2e5d07a6fc3760e49b on luism-s:develop into 642130e2d1991ccbefd6e4efa5fec84fc3dd3917 on timber:master.

Coverage increased (+0.3%) to 93.688% when pulling 0e4ea6c7b3e5d0a30a52c62a4d6236977bccb554 on luism-s:develop into 642130e2d1991ccbefd6e4efa5fec84fc3dd3917 on timber:master.

Coverage increased (+0.3%) to 93.688% when pulling 0e4ea6c7b3e5d0a30a52c62a4d6236977bccb554 on luism-s:develop into 642130e2d1991ccbefd6e4efa5fec84fc3dd3917 on timber:master.

Ok I figured out the problem. Good news, all tests checked 👌 ready to merge

🎉  Hooray 🎉 ! Thanks so much @luism-s — wouldn't have thought that one would be so tough, but it really helps smooth out the Twig 2.0 integration. Thanks for all your work!!!

All I wanted was really to be able to update Timber to the latest version, now I can :) When are you releasing the next release (pleonasm unintended)?

@luism-s I like to do those on Tuesdays (my normal night for working late) — so look out for it tomorrow!


Sets default number of bins to 5

Closes #10357
This PR sets the default bins count of the numeric view of the Fill component to 5.

CR: @xavijam

As suggested by @javisantana, I've added a .json file to handle the bins and quantifications settings for the fill component.

Ok, fixed the quotes in the json file. If there's no other comment, once the build are green I'll merge it.

:es:


Override File Name base prefix

At present, the extension appends APIM name in file. We like to override that prefix while exporting itself. Please help provide an option for the same.
Thanks,
Ashish

@ashishmundrajll  not sure I follow, could you please shed more light on the scenario?


Several fixes for new dashboard (v2)

[x] Empty results text for liked section (fixes #2243).
[x] Firefox problems in new create dialog (fixes #2862).
[x] Clicking anywhere on the welcome modal should close it (fixes #2759).
[x] IE11 styles reviewed (fixes #2854).
[x] Remove SEGOE fonts.
[x] Add Lato fonts (fixes #2360).

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Not a big deal @viddo, but could you check at least the mixin change?

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

:+1:

Frontend tests were OK :+1: (details)


Fix things.

Fix concatenation of s/y in sample classes' add method.
Fix audio datamodules.

Can't put this in the review as it is on an unchanged line.
        num_frames_segment = int(
>           self.num_frames_in_segment / self.sample_rate * metadata.sample_rate
        )
E       AttributeError: 'Ecoacoustics' object has no attribute 'num_frames_in_segment'

../conduit/data/datasets/audio/ecoacoustics.py:266: AttributeError

i think lines 266 and 270 just need to have an underscore at the start of the num_frame_in_segment var

Can't put this in the review as it is on an unchanged line.
        num_frames_segment = int(
>           self.num_frames_in_segment / self.sample_rate * metadata.sample_rate
        )
E       AttributeError: 'Ecoacoustics' object has no attribute 'num_frames_in_segment'

../conduit/data/datasets/audio/ecoacoustics.py:266: AttributeError

i think lines 266 and 270 just need to have an underscore at the start of the num_frame_in_segment var

No the problem was with the setter using the underscored version.

If line 154 of tests/data_test.py is removed so that the default transforms are used, there is an error:
        # Test size().
>       assert test_sample.x.size()[1] == dm.dims[0]
E       assert 1 == 75

data_test.py:164: AssertionError


Python API style - chaining

In using the nascent tiledbsoma API, one pattern that I would find useful is if the create and related methods returned self, allowing chained code like the second line:

an_arrow_tbl  = pa.Table.from_pandas(pd.DataFrame(...))
soma_df = soma.SOMADataFrame(uri).create(an_arrow_tbl.schema).write(an_arrow_table)

Methods that would benefit from this:

create
write
write_from_pandas
write_all_from_pandas
etc.

This deserves some discussion with Pythonic style experts, of which I am not one....

Fluent syntax is awesome, and super-easy to code up! I think we should do it (my $0.02) ...

cc @thetorpedodog

I'm not personally the biggest fan of fluent APIs but I am not morally opposed to them (it's very much a personal thing). The thing I would want to make sure of is that the methods where you get a self back make sense. For instance, assuming some_data_frame.write(...) writes something into the dataframe, getting the dataframe back would certainly make sense, but a method that was like something_else.write(some_sink) (where something_else is being written to some_sink) could sensibly return some information about the write result and might not be as good a candidate for chaining. Based on my (still fairly new) understanding, all the methods you've listed seem like they are reasonable methods to chain.
If only we could jump to Python 3.11 which has the Self annotation!

make sense

fully agree. There are many methods where it does not make sense (eg, delete).  I am supportive of doing this selectively and iteratively.

This change has been applied to create() with good effect.  We should decide if we want to retain that, and if other functions would benefit.  Should be resolved alongside single-cell-data/SOMA#41

@bkmartinjr @thetorpedodog anything else to cover here, given #663? Otherwise I could close this task.

I don’t think there’s anything else that needs to be done on this at the moment.

OK -- @bkmartinjr (or anyone else) -- if you think of something we can re-open this.


Use pnpm@9 for lockfile >= 9.0

Related: https://github.com/dependabot/dependabot-core/issues/9522

Is pnpm 9 supported at github immediately or are we waiting on a release?

@fflaten The update to support pnpm 9 is live, Dependabot is ready to handle your pnpm projects. If you have any other issues, please raise them in the issues tab.

@robaiken – although lockfiles v9.0 can be parsed, pnpm 9 won’t be used as long as this is not released.
Lockfiles will get re-generated using v6.0 format.

We deploy main at GitHub before it goes into an official tagged release.
Deploys are invisible to the public, but we often follow a deploy-then-merge strategy, and if we don't, we generally merge a couple of low-risk PR's and then do a fast-follow deploy which will pick up the whole 🚂 .
So this is already live on GitHub.com.

It still does not work at all

https://github.com/dependabot/dependabot-core/pull/9687#issuecomment-2139150623
https://github.com/dependabot/dependabot-core/issues/9684#issuecomment-2137899341


Brightness controlled from iOS Home app changes wrong slider in WLED

Hello, thanks for this great plugin. I am not sure if this is question for HB plugin or directly to WLED so I try it here, if wrong please correct me. I have 2 questions:
1: what is this 1st slider under the color wheel in WLED GUI? (for next question let's call this slider Unknown slider)
2: why does this happen in video? in WLED GUI If i change brightness level using Brightness slider than it effects only Brightness slider but no change in Unknown slider. That is expected. Now if I change brightness level in iOS home app than in WLED GUI we can see that it affected Brightness slider but also Unknown slider. And this is causing the problem shown on video - values below 24% shows no light on the strip. Brightness controlled from iOS Home app affects also Unknown slider, how can I stop this? Is there some settings for it that I might overlook?

https://user-images.githubusercontent.com/7964597/196511116-e34bf1ab-3849-4e7c-94b8-7d0ef472023a.mov

This is duplicate of #36. closing.


anyOf query returns duplicate records

When querying data against a multi-key (ex: *tags) and a record matches more than one value, multiple duplicate records are returned.
  db.version(1).stores({
    friends: "id,name,*tags"
  });

  await table.add({ id: "1", name: "john", tags: ["1"] });
  await table.add({ id: "2", name: "sam", tags: ["1", "2"] });
  await table.add({ id: "3", name: "bill", tags: ["1", "2", "3"] });

  const result = await table
    .where("tags")
    .anyOf("1", "2")
    .toArray();

   // result will be 5 records (2 duplicates) even though
   // the table only contains a total of 3 records

Working example of the issue:
https://stackblitz.com/edit/typescript-dexie-duplicate-issue?file=index.ts
Seems like maybe this is related to #796

No it's not related to #796. The reason this happens in due to how MultiEntry indexes work. In your case you will get ID 2 matched 2 times.
To fix, use distinct()
const result = await table
    .where("tags")
    .anyOf("1", "2")
    .distinct()
    .toArray();

No it's not related to #796. The reason this happens in due to how MultiEntry indexes work. In your case you will get ID 2 matched 2 times.
To fix, use distinct()
const result = await table
    .where("tags")
    .anyOf("1", "2")
    .distinct()
    .toArray();

Gotcha. Thanks, @dfahlander!


SimpleRatingBar lacks accessibility support

The rating bar is not recognised by accessibility helpers such as TalkBack and thus is not selectable. Users should be able to select the rating bar when using touch exploration and they should be able to get audible feedback about it as well as about the rating value selected.
As this rating bar is a custom view with virtual child views, the virtual view hierarchy (in the accessibility node provider, for example) and the accessibility events applicable to the view have to be individually defined.
I would really appreciate if you could add this as accessibility is quite an important issue.

Hi, sorry for the late response. I agree that this is an important issue, but I have never worked with the accessibility API. I will be looking to the docs and see if I can come up with a fix (PRs are welcomed, though).


Add option to select search order

Right now, the surfaces are sorted by name. This means that in particular when browsing anonymously, it's always the same surface that shows up first. My suggestion is to sort by date with the newest shown first. This gives an impression of activity on the site. It also means that we should show the publication date in this list.
For unpublished surfaces, we should probably show the creation date or the last date of modification. (If would actually prefer the latter.)
Any thoughts @mcrot @tdbjacobs ?

I agree that sorting by date is more useful. You can always search by name.
Using the creation date is easier to implement, because the time of the last modification is not saved yet.
But yes, the latter is more interesting - so you will also see first the surfaces which someone is working on.

The just use the creation date... We can always change this later.

I agree. Didn’t we also discuss adding some controls about how surfaces are
sorted (user can choose by alpha or date or other, and ascending or
descending)
Maybe that is a separate issue
On Fri, Dec 18, 2020 at 5:31 AM Lars Pastewka<EMAIL_ADDRESS>wrote:

The just use the creation date... We can always change this later.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ComputationalMechanics/TopoBank/issues/569#issuecomment-748010204,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFOUYWSGXOYVGU2MTGII4FTSVMVOLANCNFSM4VA3IYOA
.

--
Tevis Jacobs
Mechanical Engineering and Materials Science
University of Pittsburgh
[Sent from my phone. Please forgive typos.]

@tdbjacobs , you're right that there is an issue, it's #479. We could implement this here first and then the other.

Agreed. This one sounds easier to implement and should be the default
anyway.
Tevis Jacobs
William Kepler Whiteford Faculty Fellow and Associate Professor
Mechanical Engineering and Materials Science
University of Pittsburgh
http://www.engineering.pitt.edu/JacobsLab/
Mail: 636 Benedum Hall, 3700 O'Hara St., Pittsburgh, PA 15261
Office: 538-E Benedum Hall,<PHONE_NUMBER>
<EMAIL_ADDRESS>On Fri, Dec 18, 2020 at 11:21 AM Michael Röttger<EMAIL_ADDRESS>wrote:

@tdbjacobs https://github.com/tdbjacobs , you're right that there is an
issue, it's #479
https://github.com/ComputationalMechanics/TopoBank/issues/479. We could
implement this here first and then the other.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ComputationalMechanics/TopoBank/issues/569#issuecomment-748185597,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFOUYWS4CGJ4WALI2ZKYRGTSVN6SHANCNFSM4VA3IYOA
.

The whole frontend code for the seach results is here:
https://github.com/ContactEngineering/topobank/blob/main/topobank/frontend/manager/SearchResults.vue
You need to update the backend to respect search order. The respective view that returns the JSON to fancytree is here:
https://github.com/ContactEngineering/topobank/blob/2e6d58be5dc0f29b0c5b97af0795699dc67272d1/topobank/manager/views.py#L1806

Note that ListAPIView is part of `django-rest-framework', the documentation can be found here: https://www.django-rest-framework.org/api-guide/generic-views/#listapiview

The sorting should probably occur in filtered_surfaces, code is here:
https://github.com/ContactEngineering/topobank/blob/2e6d58be5dc0f29b0c5b97af0795699dc67272d1/topobank/manager/utils.py#L203

To modify that function, you need to understand how Django QuerySets work. The documentation is here:
https://docs.djangoproject.com/en/4.2/ref/models/querysets/

To have a template how to look for the new order_by by parameter, look at how the category is determined. Insinde filtered_surfaces the category is extracted here:
https://github.com/ContactEngineering/topobank/blob/2e6d58be5dc0f29b0c5b97af0795699dc67272d1/topobank/manager/utils.py#L228C21-L228C21
The get_category function is defined here:
https://github.com/ContactEngineering/topobank/blob/2e6d58be5dc0f29b0c5b97af0795699dc67272d1/topobank/manager/utils.py#L956
I suggest you use the same implementation style and add a get_order_by function.

get_category, get_sharing_status and the new get_order_by could actually become on function, something like get_query_parameter that also does checking on whether the parameter is among the allowed choices.


[Crashlytics] - Failed to download settings

Getting the following error on startup when using Firebase.Crashlytics:
[Fabric] failed to download settings Error Domain=FABNetworkError Code=-5 "(null)" UserInfo={status_code=403, type=2, request_id=34fcf524b69c2457ddbdcf9237814641, content_type=application/json; charset=utf-8}
I've looked at the sample project and tried many different things, but have not received any extra information to debug this issue.
Full Application Output:
`

[Crashlytics] Version 3.10.1 (129)
[Crashlytics:Crash:Reports] Packaged report with id 'c91d8593456b41c7678eae127dfd0966' for submission
[Crashlytics:Crash:Reports] Submitting report
[Crashlytics:Crash:Reports] Submitting async /Users/*/Library/Developer/CoreSimulator/Devices/8CAAC29E-7BE8-345D-B4F8-0C49A055280C/data/Containers/Data/Application/4A0A2C3C-64D8-4DCE-A63A-B6B19E8E423B/Library/Caches/com.crashlytics.data/com.app.test/v3/prepared/78CC5C5F-F6F5-4563-BDB4-342A3A73534E.multipartmime
[Crashlytics:Crash:Reports:Event] Sending event.
[Fabric] failed to download settings Error Domain=FABNetworkError Code=-5 "(null)" UserInfo={status_code=403, type=2, request_id=34fcf524b69c2457ddbdcf9237814641, content_type=application/json; charset=utf-8}
[Crashlytics:Crash:Reports] completed submission of /Users/*/Library/Developer/CoreSimulator/Devices/8CAAC29E-7BE8-345D-B4F8-0C49A055280C/data/Containers/Data/Application/4A0A2C3C-64D8-4DCE-A63A-B6B19E8E423B/Library/Caches/com.crashlytics.data/com.app.test/v3/prepared/78CC5C5F-F6F5-4563-BDB4-342A3A73534E.multipartmime
[Crashlytics:Crash] report submission successful
`

I figured out this was due to having the Fabric and Firebase apps linked. I unlinked them and went through the setup again on Firebase Crashlytics.


Offer GCD function in Rust again

Rust used to offer this pre-1.0, but once the numeric traits were ditched in favour of inherent methods, these were removed.
Considering how the implementation is nontrivial, but very commonly used, it makes sense to re-offer this in the standard library. I'm not sure if it would make the most sense as an inherent method (although it seems reasonable), but I don't think it's unreasonable to include it.

very commonly used

Is it? Assuming you mean greatest common denominator I only remember using it once, since high school.

@SimonSapin I've ended up using GCD-like computations a lot but a lot of the code I tend to use it in is more mathematical in nature. Factoring numbers, simplifying fractions, etc.
I shouldn't have said very, but I do think that it's common enough to include.

There probably already exists some math crate impleneting this. Else just implement it yourself, isn't difficult

greatest common denominator

(Oddly enough, I have a terrible habit of calling it this, too, and only notice the mistake when other people do it.)

@porky11 it is offered by the num-integer crate currently. I was just a bit confused why it wasn't included in the standard library, as it seems useful enough in a general context to provide upstream.

@ExpHP Yeah, it's greatest common divisor. Some people call it HCF (highest common factor) but most implementations call it GCD.

Triage: @clarcharr Are you still interested in this? If so, file an RFC perhaps / move to internals?

GCD is not as basic as other operations like sin, cos etc. I personally think this feature should indeed belong to a third-party crate, with more math-related functions.

I think it’s fine for this algorithm to live in an external crate. sin and cos are already provided by libc/libm, so we’re only providing bindings.

Doesn't seem like there's interest from the libs team to put this in libstd so ill close.

GCD is not as basic as other operations like sin, cos etc.

If you mean Lehmer's algorithm, yes, but that's too overkill for small ints. If you mean the Euclidean algo, that's just plain wrong, it's quite simple!
If you mean "basic" as "frequently used", then you're right, but the term is misleading


How can you tell if Query Caching is working?

This sounds like the answer to our prayers (we have lots of QPU-intensive calculations but loads of memory headroom), but it doesn't seem to work. I enabled it on one of our heavy datasets, which has a calculation that typically takes around 80 seconds to complete. After enabling, that calculation still takes 80 seconds to complete every time I load the report.

Hi @rogersmj - thanks for the question. Was this related to a specific doc you were reading? We might be able to add something to the docs, but in the meantime, you might find a solution in the Power BI Community. If not, try our support page.

Assigning to @Bhavik-MSFT to see if he has any insight into this.

Hi @rogersmj , i assume you are talking about Query Caching in Premium/Embedded. We mention in the documentation that we only cache the first page of a report for a security context (including bookmarked state). We also don't cache queries generated by in-report interactions like slicer selections. In your case it seems the slow query is not actually cached - it should not even hit the engine if we have a cached result. Please try disabling caching for the dataset, then make sure the first page you view thereafter is the one with the slow query. We have work in progress right now to extend this caching to additional scenarios.


Could not resolve<EMAIL_ADDRESS>

In the file src/plugins/asset-loader.js at line 33, the assetLoaderPlugin function includes a default value for the assetRegistryPath parameter. However, this default value is outdated and needs to be updated.
Current line:
assetRegistryPath =<EMAIL_ADDRESS>Expected line:
assetRegistryPath =<EMAIL_ADDRESS>Since the release of version 0.72.1 of the react-native, the correct path to the asset registry file should include an additional directory called assets-registry. The current default value causes an error as below.
✘ [ERROR] Could not resolve<EMAIL_ADDRESS>
    react-native-asset:/Users/jeonjinho/Development/projects/sullog-app/sullog/node_modules/react-native/Libraries/LogBox/UI/LogBoxImages/alert-triangle.png:1:25:
      1 │ module.exports = require('@react-native/assets/registry.js').registerAsset({"__packager_asset":true,"scales":[1],"name":"alert-triangle","type":"png","hash":"4f355ba1efca4b9c0e7a6271af047f61","httpServerLocation":"/assets/node_modu...
        ╵                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  You can mark the path<EMAIL_ADDRESS>as external to exclude it from the
  bundle, which will remove this error. You can also surround this "require" call with a try/catch
  block to handle this failure at run-time instead of bundle-time.

I would suggest updating the default value of assetRegistryPath to<EMAIL_ADDRESS>to resolve this issue.
Please let me know if any further information is required. Thank you!

Fixed in https://github.com/oblador/react-native-esbuild/pull/31


Incorporate log anomaly services to use better-proto Python library.

Currently, the default Google protobuf python library is being used for Opni log anomaly detection. Modifications need to be made to the code base for preprocessing, DRAIN service, Inferencing service and Opensearch updating service to use the better-proto library.

Protofile was included as a Pypi package and that has been incorporated into the Opni log anomaly microservices.

PRs have been submitted:
https://github.com/rancher/opni-preprocessing-service/pull/27
https://github.com/rancher/opni-drain-service/pull/18
https://github.com/rancher/opni-inference-service/pull/25
https://github.com/rancher/opni/pull/310


Cannot cross-compile git2 to aarch64-linux-android

I cannot cross-compile git2. Please see sample code and build output.
edit: actually, to show the error, all I need to do is:
git clone https://github.com/rust-lang/git2-rs
cd git2-rs/
cargo build --target aarch64-linux-android

my original example follows:
src/lib.rs:
use anyhow::{Result};
use git2::{
    build::RepoBuilder,
};
pub fn run(
    remote_url: &str,
    path: &std::path::Path,
) -> Result<()> {
    let _repo = RepoBuilder::new()
        .bare(false)
        .clone(&remote_url, &path)?;
    Ok(())
}

Cargo.toml:
[package]
name = "build-error"
version = "0.1.0"
edition = "2018"

[dependencies]
anyhow = "1.0.44"
git2 = "0.13.22"

Compiler command: cargo build --target aarch64-linux-android
Compiler output:
  Compiling openssl-sys v0.9.67
error: failed to run custom build command for `openssl-sys v0.9.67`

Caused by:
  process didn't exit successfully: `/home/martin/git/codex-git/build-error/target/debug/build/openssl-sys-6091c7eb1d059737/build-script-main` (exit status: 101)
  --- stdout
  cargo:rustc-cfg=const_fn
  cargo:rerun-if-env-changed=AARCH64_LINUX_ANDROID_OPENSSL_LIB_DIR
  AARCH64_LINUX_ANDROID_OPENSSL_LIB_DIR unset
  cargo:rerun-if-env-changed=OPENSSL_LIB_DIR
  OPENSSL_LIB_DIR unset
  cargo:rerun-if-env-changed=AARCH64_LINUX_ANDROID_OPENSSL_INCLUDE_DIR
  AARCH64_LINUX_ANDROID_OPENSSL_INCLUDE_DIR unset
  cargo:rerun-if-env-changed=OPENSSL_INCLUDE_DIR
  OPENSSL_INCLUDE_DIR unset
  cargo:rerun-if-env-changed=AARCH64_LINUX_ANDROID_OPENSSL_DIR
  AARCH64_LINUX_ANDROID_OPENSSL_DIR unset
  cargo:rerun-if-env-changed=OPENSSL_DIR
  OPENSSL_DIR unset
  cargo:rerun-if-env-changed=OPENSSL_NO_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_ALLOW_CROSS_aarch64-linux-android
  cargo:rerun-if-env-changed=PKG_CONFIG_ALLOW_CROSS_aarch64_linux_android
  cargo:rerun-if-env-changed=TARGET_PKG_CONFIG_ALLOW_CROSS
  cargo:rerun-if-env-changed=PKG_CONFIG_ALLOW_CROSS
  cargo:rerun-if-env-changed=PKG_CONFIG_aarch64-linux-android
  cargo:rerun-if-env-changed=PKG_CONFIG_aarch64_linux_android
  cargo:rerun-if-env-changed=TARGET_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_aarch64-linux-android
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_aarch64_linux_android
  cargo:rerun-if-env-changed=TARGET_PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
  run pkg_config fail: "pkg-config has not been configured to support cross-compilation.\n\n                Install a sysroot for the target platform and configure it via\n                PKG_CONFIG_SYSROOT_DIR and PKG_CONFIG_PATH, or install a\n                cross-compiling wrapper for pkg-config and set it via\n                PKG_CONFIG environment variable."

  --- stderr
  thread 'main' panicked at '

  Could not find directory of OpenSSL installation, and this `-sys` crate cannot
  proceed without this knowledge. If OpenSSL is installed and this crate had
  trouble finding it,  you can set the `OPENSSL_DIR` environment variable for the
  compilation process.

  Make sure you also have the development packages of openssl installed.
  For example, `libssl-dev` on Ubuntu or `openssl-devel` on Fedora.

  If you're in a situation where you think the directory *should* be found
  automatically, please open a bug at https://github.com/sfackler/rust-openssl
  and include information about your system as well as this message.

  $HOST = x86_64-unknown-linux-gnu
  $TARGET = aarch64-linux-android
  openssl-sys = 0.9.67

  ', /home/martin/.cargo/registry/src/github.com-1ecc6299db9ec823/openssl-sys-0.9.67/build/find_normal.rs:174:5
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

System details:
Linux xiaosan 5.13.19-200.fc34.x86_64 #1 SMP Sat Sep 18 16:32:24 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Also:
sudo dnf list '*openssl*'
Last metadata expiration check: 0:06:36 ago on Fri 01 Oct 2021 14:42:56 HKT.
Installed Packages
apr-util-openssl.x86_64                               1.6.1-16.fc34    @anaconda
openssl-devel.x86_64                                  1:1.1.1l-2.fc34  @updates
openssl-libs.x86_64                                   1:1.1.1l-2.fc34  @updates
openssl-pkcs11.x86_64                                 0.4.11-2.fc34    @anaconda
python3-pyOpenSSL.noarch                              20.0.1-2.fc34    @anaconda
xmlsec1-openssl.x86_64                                1.2.29-3.fc34    @anaconda

This isn't a bug in this crate. You'll need to arrange for OpenSSL to be available for the target platform, and perhaps the easiest way to do that is to enable the vendored-openssl feature.

I have raised an openssl error.

This is still not working for me. At the stage I am up to, the archive file does not contain git_repository_open. I'm not getting any compile errors but when I try running the code I get java.lang.UnsatisfiedLinkError: dlopen failed: cannot locate symbol "git_repository_open" from Android. The archive file that I am referring to is the output from my Rust cross-compile.


some suggestions

Ore and Fluid processor, as sender and receiver pipes should display in buildcraft guide book. They should have a gui as other Buildcraft machines.

I have to disagree on the GUI: Quarry never had one, as well as GUI's being overdone in the modding community. That's the reason I like the mod so much, no boring GUI's, as simple as it gets, but so much possibility!


[GEP-1911] websocket backend protocol conformance

/kind test
/area conformance
What this PR does / why we need it:
This PR adds a conformance test validating implementations support websocket over cleartext when the target Kubernetes Service Service Port has a kubernetes.io/ws appProtocol
This PR includes echo-basic changes so it will need to bumped after this PR
Which issue(s) this PR fixes:

Related https://github.com/kubernetes-sigs/gateway-api/issues/1911 https://github.com/kubernetes-sigs/gateway-api/issues/205
Does this PR introduce a user-facing change?:

NONE

this PR looks good, lets wait for https://github.com/kubernetes-sigs/gateway-api/pull/2456 to land first, since this PR will need a rebase

/cc @mlavacca

/lgtm


Rewrite and bugfix no-switch-case-fallthrough

PR checklist

[x] Fixes: #785, #950, #1033, #1538
[x] New feature, bugfix, or enhancement

[x] Includes tests

What changes did you make?
[bugfix] handle break, throw, continue and return nested in block, if-else and switch
[bugfix] allow empty case clauses before default clause
[enhancement] allow single line comment // falls through
Is there anything you'd like reviewers to focus on?
Depends on #2217

@ajafff thanks!

Github didn't automatically closed the other open issues mentioned above: #950, #1033, #1538

The // falls through comment check should probably be case-insensitive and allow additional text.

// falls through
// Falls through
// Falls through.
// Falls through -- for reasons.

@glen-84 makes sense. I opened #2983 to address this.


The error:  Cannot find module '../build/Release/zmq.node' Require stack:

Hydrogen can't run on Atom. I installed the hydrogen using the command line: apm install hydrogen. But the Hydrogen produce bug. I tried to install the old version hydrogen. The hydrogen can't be used on atom. The error is following:
Cannot find module '../build/Release/zmq.node'
Require stack:

/Users/xxx/.atom/packages/hydrogen/node_modules/zeromq/lib/index.js
/Users/xxx/.atom/packages/hydrogen/node_modules/zeromq/index.js
/Users/xxx/.atom/packages/hydrogen/node_modules/jmp/index.js
/Users/xxx/.atom/packages/hydrogen/lib/zmq-kernel.js
/Users/xxx/.atom/packages/hydrogen/lib/kernel-manager.js
/Users/xxx/.atom/packages/hydrogen/lib/store/index.js
/Users/xxx/.atom/packages/hydrogen/lib/utils.js
/Users/xxx/.atom/packages/hydrogen/lib/panes/inspector.js
/Users/xxx/.atom/packages/hydrogen/lib/main.js
/Users/xxx/Documents/Software/Atom/Atom.app/Contents/Resources/app.asar/static/index.html

I checked ../build/Release/.   The file is empty.  May be some files can't be compiled. But I'm not sure. How should I do???
Atom version: 1.48.0
Hydrogen version:2.14.1
Mac version: MaOS 10.15.5

Please redownload the latest version.


[Feature] Doris manager module

Proposed changes
Doris Manager is a platform product that integrates one-click automatic installation, deployment, management, monitoring, and tuning of doris clusters. Its service is independent of Doris and aims to provide convenient user functions through a graphical interface. Manager is compatible with multi-cluster mode, and its functions are divided into general functions and single-cluster functions as a whole.
Types of changes
What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
[ ] Code refactor (Modify the code structure, format the code, etc...)
[ ] Optimization. Including functional usability improvements and performance improvements.
[ ] Dependency. Such as changes related to third-party components.
[ ] Other.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have created an issue on (Fix #6422 ) and described the bug/feature there in detail
[ ] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If these changes need document changes, I have updated the document
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

👍

👍

add doris manager server api interface documentation


fix(curriculum): add empty line in box-model-lesson-d for better display

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #56020
add empty line after img tag and before assignment section for better display

THe issue is limited to first timers only, this would be your second contributions. We would appreciate more contributions from you, please keep an eye out for issues labelled with help wanted


Remove filter plan node in pipeline

Describe This Problem
For filter pushdown, we only pushdown partial filters to table scan now, that means the filter plan node is still preserved. For example:
Query:
SELECT  * FROM system.public.tables where table_name='1';

Plan:
| logical_plan  | Projection: #system.public.tables.timestamp, #system.public.tables.catalog, #system.public.tables.schema, #system.public.tables.table_name, #system.public.tables.table_id, #system.public.tables.engine
  Filter: #system.public.tables.table_name = Utf8("1")
    TableScan: system.public.tables projection=[timestamp, catalog, schema, table_name, table_id, engine], partial_filters=[#system.public.tables.table_name = Utf8("1")] |
| physical_plan | ProjectionExec: expr=[timestamp@0 as timestamp, catalog@1 as catalog, schema@2 as schema, table_name@3 as table_name, table_id@4 as table_id, engine@5 as engine]
  CoalesceBatchesExec: target_batch_size=4096
    FilterExec: table_name@3 = 1
      ScanTable: table=tables, parallelism=8, order=None,

Proposal
We have three derives of Table trait:
https://github.com/CeresDB/ceresdb/blob/28be2ed754a8dc404499b01797d0e45a412b3f65/analytic_engine/src/table/mod.rs#L84
https://github.com/CeresDB/ceresdb/blob/28be2ed754a8dc404499b01797d0e45a412b3f65/system_catalog/src/lib.rs#L91
https://github.com/CeresDB/ceresdb/blob/28be2ed754a8dc404499b01797d0e45a412b3f65/table_engine/src/memory.rs#L78
In #326, we will support filters pushdown fully in TableImpl. If we want to remove filter plan node in pipeline, we need add same filter logic to the other two derives.
Additional Context
No response

I remember that the predicate used by the filter plan node can be controlled by the implementation of TableProvider:
https://github.com/CeresDB/ceresdb/blob/a8fb2c92edb979051fbfbd339d72f65f94628f2c/table_engine/src/provider.rs#L143
That is to say, for different Table implementations, we can use different TableProviderFilterPushDown, and there is no need to add the same filter logic for the other two Table implementations: SystemTableAdapter & MemoryTable.

That is to say, for different Table implementations, we can use different TableProviderFilterPushDown, and there is no need to add the same filter logic for the other two Table implementations: SystemTableAdapter & MemoryTable.

Yes, it is better to use  different TableProviderFilterPushDown.
We use the same TableProvider(TableProviderAdapter) for all tables now, seems we can move the control of TableProviderFilterPushDown to the implementations of tables. like:
pub trait Table: std::fmt::Debug {
    fn supports_filter_pushdown(&self, _filter: &Expr) -> Result<TableProviderFilterPushDown>;
}

impl TableProvider for TableProviderAdapter {
    fn supports_filter_pushdown(&self, _filter: &Expr) -> Result<TableProviderFilterPushDown> {
        self.tableref.support_filter_pushdown()
    }
}

That is to say, for different Table implementations, we can use different TableProviderFilterPushDown, and there is no need to add the same filter logic for the other two Table implementations: SystemTableAdapter & MemoryTable.

Yes, it is better to use different TableProviderFilterPushDown.
As you mentioned in #326, we can move the control of TableProviderFilterPushDown to the implementations of tables. like:
pub trait Table: std::fmt::Debug {
    fn supports_filter_pushdown(&self, _filter: &Expr) -> Result<TableProviderFilterPushDown>;
}

impl TableProvider for TableProviderAdapter {
    fn supports_filter_pushdown(&self, _filter: &Expr) -> Result<TableProviderFilterPushDown> {
        self.table.support_filter_pushdown()
    }
}

👍 It's true. However, I guess it will be better to avoid using  TableProviderFilterPushDown  as the returned type of supports_filter_pushdown  of our Table trait because Table trait has no any dependency on datafusion.

From the context, we can just change supports_filter_pushdown in TableProvider to return TableProviderFilterPushDown::Exact to fix this issue?

https://github.com/CeresDB/ceresdb/blob/dfdf4b615948572d6932f897b5bb94b4450cff1f/table_engine/src/provider.rs#L238
https://github.com/CeresDB/ceresdb/blob/dfdf4b615948572d6932f897b5bb94b4450cff1f/table_engine/src/provider.rs#L265


Bring back "Live Share: Create Reusable Session link"

(Non insider version)
Apparently this feature was replaced with planned sessions, which in turn was deprecated ( #4613 ) due to low usage.
Could we possibly have the original feature (reusable links) back?
Was the removal of the original feature intender or merely accidental due to the removal of the panned sessions feature?
I found this feature very helpful back when it was available and today I found myself missing it as we were working on devcontainers which needed rebuilding, which involved having to recreate the link each time.

bump

will this be coming back? We need it!

@Al12rs super interesting to hear that you find this feature useful. Would love to dive deeper into this. What niche does reusable links solve for you currently? We found that most users didn't find the act of creating a link when needed super high friction and reusable links were not as useful without having session context stored between two sessions.

@phifa I would love to know from you as well- how did use reusable links in your workflow?

@fubaduba The use case as I mentioned was for docker dev-containers.
We where collaborating on development of a series of microservices and where using dev containers to make our development environment for each microservice more portable and easier get started on for all the members of our team.
We would split our team in pairs and have each handle different tasks, the pairs allowed members to learn from each other especially in case where some didn't have previous experience with the language we where using (we used go, scala and js).
During development of the services though there was often the need to update the dev container, for example to update an embedded database, or to add dependencies etc.
In those cases we needed to restart the vscode instance which required sending a new invite, and manually reconnecting each time.
This became very tedious very quickly enough that in some sessions the guest would simply stop and just watch screen share of the host, greatly reducing what the guest could contribute.
After a while we stopped using dev containers due to them being too inconvenient to pair program on and the team became more fragmented between those that had the scala environment and those that had the go environments.
Basically the two subgroups solidified into becoming dedicated to scala and go respectively and there was much less interchange and crossover, while before the pairs where completely dynamic.
Hope that explained the use case and why it mattered in our case.

@fubaduba it's just simple to have the same link ready to go if you're pairing with the same partner for a few days/ weeks. You could call the link via a shortcut and be done with it. Now it's always multiple steps: copy link, open chat tool, look for partner, paste in and send. The other guy has to click and allow again all the security stuff, trusted source etc.
I know that instead of link you can invite via UI directly, but that only works sometimes, often the other guy does not show up as online, etc. and you still have approve the codebase again.

Thanks for taking the time to file this issue to submit this request. Unfortunately, we’re not able to prioritize this feature over the other current areas of focus on the team. We understand that this may be disappointing. We appreciate your input and comments on this issue till now.


Code comment history not shown on lazily loaded diffs

Gitea Version
1.16.0+dev-581-gbaed01f24
Git Version
No response
Operating System
No response
How are you running Gitea?
try.gitea.io
Database
No response
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Description
The comment edit history dropdowns are only initialized once when the page loads.
If additional diffs are loaded afterwards (via "Show More" or "Load Diff"), their code comments don't have the edit history.
Example:

https://try.gitea.io/jpraet-org/test-repo/pulls/1/files -> "Show More" -> you'll see the edited comment on file 99 has the edit history dropdown, while the edited comment on file 105 does not
https://try.gitea.io/jpraet-org/test-repo/pulls/2/files -> "Load Diff" -> the edited comment does not have the dropdown

Screenshots
ok:

not ok:

@silverwind What if we add a call to initRepoIssueContentHistory on these lines:
https://github.com/go-gitea/gitea/blob/3d996c85a5a56a0c680c80653813ba361c21cc4a/web_src/js/features/repo-diff.js#L101-L103

@gusted I think that would work.


FIX: Removed Unverified status in Seller Profile Page

Hi @Mrhb787 ,
Fixed 2 issues.

Filepond library was not added as a dependency
Removed UnVerified chip  from the Seller Profile page.

Please check below screenshot.

Please let me know if anything is missing.
Thank you,
Bhavesh Kumar.

Great Work @bkjain655.  Thanks For the contribution.


Bug on home loading[Todoist] ...

Extension
https://www.raycast.com/doist/todoist
Raycast Version
1.82.3
macOS Version
14.5
Description
Error:
TypeError: Cannot read properties of null (reading 'due')

Um:TodayTasks.tsx:16:51

---
13:
14: type TodayTasksProps = { quickLinkView: QuickLinkView }

log:
XD a NullPointerException

TypeError: Cannot read properties of null (reading 'due')

Um:TodayTasks.tsx:16:51

---
13:
14: type TodayTasksProps = { quickLinkView: QuickLinkView };
15:
16: export default function TodayTasks({ quickLinkView }: TodayTasksProps) {
17:   const [data] = useCachedData();
18:
19:   const tasks = useMemo(() => {
---

Lr:index.js:8:3631
    at ray-list
lt:index.js:20:24444

### Steps To Reproduce

1. open home

### Current Behaviour

nothing there

### Expected Behaviour

something there

Hello!! @jpalmerov :)
fix: #14364
The TypeError occurs because data is null, leading to attempts to read properties like due on it. To fix this, ensure data is not null before accessing its properties. Add a conditional check in the TodayTasks component to handle the null case and prevent accessing properties on null objects. For example, include a check like if (!data) return
No data available
; before proceeding with property access.

Thanks for reporting this bug. Would you like to work on it? If yes, here's our guide on extension contributions so that you can open up a pull request. Feel free to contact me here or in the Slack community if you need further help.


Kotlin Multiplatform Compose support for RichText

Convert richtext-ui, richtext-ui-material, richtext-commonmark to KMP

Add a desktop app
Slightly modify sample android app to work with KMP version of Richtext
Carry Previews to jvmMain as no Preview is rendered within common or androidMain
Change package name prefixes to com.halilibo in KMP libraries
Update docs
Implements #25

Using the latest configuration, a snapshot release is published on S01 SonaType MavenCentral
https://s01.oss.sonatype.org/content/repositories/snapshots/com/halilibo/compose-richtext/


Use "bundles/avanzuadmintheme" instead of @AvanzuAdminThemeBundle

With this change the app don't need to have the vendors (install using avanzu:admin:fetch-vendor). The app will only need the assets installed inside web/bundles/bundles/avanzuadmintheme/vendor so you don't need to have bower to have a working application.

@jmontoyaa could you rebase the conflicts so it could be reviewed and considered for future merge?

@jmontoyaa I manually merge your changes in master and update more paths. Thanks for your contribution! Closing the issue


manager_ could be a dangling reference when Envoy shuts down

Thank @JuniorHsu for reporting a crash.
manager_ could be a dangling reference when Envoy shuts down
Originally posted by @lambdai in https://github.com/envoyproxy/envoy/pull/19971#discussion_r882135365

/assign lambdai

this occurs again.

This is quite convoluted. I think the remaining bit of information missing is https://github.com/envoyproxy/envoy/pull/14954. That PR modified the destructor of ClusterInfo which owns the last SSL socket context to be dispatched and deleted on the main thread. So it should be easy to delay manager_ destruction after dispatcher_ to fix this crash.


infinite loop with patterns on ctx.fill();

Minimal test case (hangs browser on "ctx.fill();")
http://test.geogebra.org/~mike/canvas2svgPatternBug/imageFill.html
Proof of concept for suggested fix:
http://test.geogebra.org/~mike/canvas2svgPatternBug/imageFill_fixed.html
Changing
while(value.__ctx.__defs.childNodes.length) {
id = value.__ctx.__defs.childNodes[0].getAttribute("id");
this.__ids[id] = id;
this.__defs.appendChild(value.__ctx.__defs.childNodes[0]);
}

to
var len = value.__ctx.__defs.childNodes.length;
for (var i = 0 ; i < len ; i++) {
id = value.__ctx.__defs.childNodes[i].getAttribute("id");
this.__ids[id] = id;
this.__defs.appendChild(value.__ctx.__defs.childNodes[i]);
}

seems to fix it although maybe removing the elements would be better (I guess there's a line of code missing to do that)

Same as #49


platform-cli seems to cache project list

I created a new project when typing just platform I did not see the new project in the list.
When I type platform projects the new project appeared
When typing now platform I get the correct list

In 1.x and 2.x, the projects list expires after 1 hour, and the environments list after 10 minutes. And it's (still) invalidated if you run platform projects or platform environments, respectively.
2.x has the potential for proper HTTP caching (it would be a simple config switch), if it is implemented on the API side.

Good enough. And as some remember I will be extatic if we set on the API side the etag to the commit hash.


@workspace agent fails with Without the actual implementation... yet it HAS the implementation

typed @workspace analyze function cropCenterResize2() for correctness, clarity, and simplify when possible
copilot's response after collecting 9 files including the entire implementation for cropCenterResize2() in one of the 9 files is...
Used 9 references
...
Without the actual implementation of the cropCenterResize2() function, it's impossible for me to analyze it for correctness, clarity, or potential simplifications. The function signature you provided suggests that it's a method...

Setup
Version: 1.85.1 (system setup)
Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
Date: 2023-12-13T09:49:37.021Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22631

copilot v1.143.601
copilot chat v0.11.1

Repro

type @workspace analyze function cropCenterResize2() for correctness, clarity, and simplify when possible into copilot chat window

Result
Used 9 references
...
Without the actual implementation of the cropCenterResize2() function, it's impossible for me to analyze it for correctness, clarity, or potential simplifications. The function signature you provided suggests that it's a method...

Expected
To provide the analysis of the function and not complain that it doesn't have the actual implementation.
The workspace agent listed in its reply both the header and the cpp of the declaration and definition of cropCenterResize2. Therefore, it has full view on all the code.
Notes
I found that if I change my inquiry so that it doesn't have the () after the function name, then the reply is more reasonable.
Specifically, using @workspace analyze function cropCenterResize2 for correctness, clarity, and simplify when possible resulted in a workable reply.
I suspect that some part of the end-to-end on this is failing with me using () after the function name. It seems to be taking it very literally and not finding a function signature () which is true...the signature actually has 4 parameters. I think it would be better in cases like this that copilot realize that...like misspellings...that I didn't get the signature in my inquiry exactly right and that using () is a casual way to indicate a function and not necessarily the explicit exact signature (which technically is incomplete since even if I listed the 4 params I still wouldn't list the needed modifiers like const, noexcept, etc...)

Seeing this issue, too
Kinda defeats the purpose of using @workspace lol

Please give this a try in the next insiders release of the vscode-chat extension. There was a bug that caused that function name of that form (name + digit + ()) not to get resolved correct
Going forward you should be able to use: cropCenterResize2(), cropCenterResize2, cropCenterResize2(arg1, arg2, ...), or even just cropCenterResize

I'm not having any luck with a similar query, even if I highlight the entire function implementation.
From the vscode-jupyter repo


Flutter Hot reload not working on save (android studio)

I'm currently using android studio as a IDE for developing flutter app.  Here is the version of my android studio :

Android Studio Arctic Fox | 2020.3.1 Patch 4
And I'm using flutter ver 65.2.1 and Dart ver 203.8452.
When I'm trying to hot reload my app on save, the dart analysis showed : "Reload not performed, Analysis found issues", but when I'm opened the dart analysis, there is 0 error shown. But when I'm clicking the hot reload button or using the keyboard shortcut, the hot reload working fine.
I have checked my android studio settings for flutter and I have checked the function for 'Perform hot reload on save'. This is really bugging me, since I have no issues regarding this hot relaod months ago. Maybe it's the package problem ? Thanks in advance

Hi @ricophie03, can you check if https://github.com/flutter/flutter-intellij/issues/6311 is similar to your case?


Implement "meta-code-verify" in "eth-kv-store"

Meta-code-verify can be found at - https://github.com/facebookincubator/meta-code-verify/
We want to use "Meta-code-verify" for verifying the integrity of eth-kv-store app.

https://engineering.fb.com/2022/03/10/security/code-verify/


Add HeatmapLayer example to the website

For #3591
Change List

Add HeatmapLayer example to the website
Rename the old HeatmapDemo to HexagonDemo
Update thumbnails of the new demos

Coverage increased (+2.9%) to 82.685% when pulling 0f682c809d86f967523f560f5b601127d5582732 on x/heatmap-example into 54e709364dd49f1d4e7bfb695ce65361df5f4e02 on master.


New config on Heroku

When using heroku with the following config, I still get the error Web process failed to bind to $PORT within 60 seconds of launch
const CONFIG = {
    headless: true,
    api: {
        host: '<IP_ADDRESS>',
        port: process.env.PORT || 3000,
    },
    ui: {
        ssl: true,
        host: 'heroku-appy-name.herokuapp.com',
        port: 443,
        path: '/'
    },
    adapter: 'sqlite'
}

Using a procfile
web: node gekko --config sample-config.js

Scouring the web trying to understand why this wont work (tried 3000 as a string also).
Anything I can do to help?

The command you posted does not start the gekko UI, and thus nothing that Heroku calls a "Web process". The CLI version of Gekko is a script that keeps running forever, but Heroku is meant for "webservices".
So: You should be able to use the UI on heroku (untested, but I don't see why not). But you cannot run the commandline version on Heroku.

Even still, starting the web process web: node gekko --ui gives me nothing. I'm assuming that I need to start the API on 3000 and the web-ui on heroku's port?

Here some context:
When using the UI gekko starts a server, which the frontend (webpage) will connect to:
[ UI ] ---> [ gekko server ]

In the UI config those are split up since if you want to run Gekko in the cloud you want to secure the gekko server so that other people do not have access to this server. You can do this by putting a reverse proxy between the two components:
[ UI ] ---> [ reverse proxy ] ---> [ gekko server ]

In this reverse proxy you can configure SSL and BasicAuth (or whatever you want really) so that no one can access the gekko server.
This setup is not possible on Heroku (AFAIK), so the only thing you can do is the basic setup above. For the basic setup you configure the api and the UI to use the same port / host / no SSL.

That's what I thought ^.
To summarize: There should be no issue running the UI on heroku, but it will need the gekko server hosted somewhere else?

I think you can run everything on heroku, example config:
const CONFIG = {
    headless: true,
    api: {
        host: 'heroku-appy-name.herokuapp.com',
        port: 3000,
    },
    ui: {
        ssl: false,
        host: 'heroku-appy-name.herokuapp.com',
        port: 3000,
        path: '/'
    },
    adapter: 'sqlite'
}

And you point your browser to: http://heroku-appy-name.herokuapp.com:3000. This is under the assumption that you can use port 3000 on heroku (I have no idea). You cannot use port 443 since that is for SSL traffic which you can only do with a reverse proxy (gekko does not support it).

Thanks for the help. I'll try a bit more later this weekend...would be great to host on heroku just for simplicity, but at this point I'll probably use a private server. If you have the time to confirm this since you're a little more familiar with the product, it'd probably help a few more people than just me.
Thanks!

Confirmed that your proposed config does not work on heroku. I'm not sure it's possible to start both the api and the ui on heroku. Would be interested if you have success. Thank you for your help.

Any news on this one ? I'm trying to set an instance on Heroku as well


Fix identifier with special character

Purpose

This PR will add escape delimeter for unsupported identifiers.

Codecov Report

Merging #18595 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #18595   +/-   ##
=======================================
  Coverage   15.15%   15.15%
=======================================
  Files          48       48
  Lines        1254     1254
  Branches      197      197
=======================================
  Hits          190      190
  Misses       1050     1050
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad3aa55...ebf13b3. Read the comment docs.


Add Tests for concurrent runtime map item access

There is no custom logic for runtime map item access at the moment, so this issue in unneccesary


Map content goes 100% height?

Hi, just a simple question from me. How to make map goes 100% in height? I know it already stated that 100% in height will not have any effects. But, is there any other way? If I set a specific number in px (e.g 500px), it works, but it might looks smaller in bigger screen? Sorry for my bad english.

Please ask on StackOverflow. Issues are for issues/bugreports, not general questions!


Involving Android Studio

Hey Amaury,thanks for this magnificent work but I have been trying to add your library to Android Studio for 2 days without any success.If it is possible could you upload a .jar file or create a option to add this library using build.gradle.Thanks in advance.
Best regards.

I'm under the impression this wouldn't work well because Recognito is too sensitive to noise present in the surroundings


[web] MissingPluginException

When starting a scan on web I get an error an the console logs:
MissingPluginException(No implementation found for method listen on channel dev.steenbakker.mobile_scanner/scanner/event)
followed by:
Uncaught MissingPluginException(No implementation found for method updateScanWindow on channel dev.steenbakker.mobile_scanner/scanner/method)
The interesting thing though is everything works fine while developing and debugging. But as soon as I build and run in release mode (flutter build web --release) I get the errors above. It only affects release build on web. All other plattforms and releases work fine
Any ideas?
mobile_scanner version 91bb85b8808a34f80a87d897424762de7ab1250d

Flutter doctor
[✓] Flutter (Channel stable, 3.16.9, on macOS 14.2.1 23C71 darwin-x64, locale en-DE)
  • Flutter version 3.16.9 on channel stable at /Users/<user>/fvm/versions/3.16.9
  • Upstream repository https://github.com/flutter/flutter.git
  • Framework revision 41456452f2 (3 weeks ago), 2024-01-25 10:06:23 -0800
  • Engine revision f40e976bed
  • Dart version 3.2.6
  • DevTools version 2.28.5

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
  • Android SDK at /Users/<user>/Library/Android/Sdk
  • Platform android-34, build-tools 34.0.0
  • ANDROID_HOME = /Users/<user>/Library/Android/Sdk
  • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
  • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
  • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
  • Xcode at /Applications/Xcode.app/Contents/Developer
  • Build 15C500b
  • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
  • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
  • Android Studio at /Applications/Android Studio.app/Contents
  • Flutter plugin can be installed from:
    🔨 https://plugins.jetbrains.com/plugin/9212-flutter
  • Dart plugin can be installed from:
    🔨 https://plugins.jetbrains.com/plugin/6351-dart
  • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] VS Code (version 1.86.2)
  • VS Code at /Applications/Visual Studio Code.app/Contents
  • Flutter extension version 3.82.0

[✓] Connected device (3 available)
  • macOS (desktop) • macos                     • darwin-x64     • macOS 14.2.1 23C71 darwin-x64
  • Chrome (web)    • chrome                    • web-javascript • Google Chrome 121.0.6167.184

[✓] Network resources
  • All expected network resources are available.

Follow up:
A simple flutter clean followed by flutter pub get solved the issue. :)
Seems to me that's the Flutter version of turning it off and on again :)


Splitting work incorrectly

First, please take a look at this code snippet:
https://repl.it/repls/FrugalBumpyBackend
The polygon and the splitter line in the code are plotted here:
https://www.desmos.com/calculator/atmkms5teg
Expected behavior and actual behavior.
Just look at the graph, I can expect it to output 2 polygons. But running the code, the output is 10 polygons
Steps to reproduce the problem.
Just run the above code and it'll output to the numbers of split polygons
Operating system
Windows 10
Shapely version and provenance
1.6.4.post1 installed from PyPI using pip

Look like this is duplicate of #600


SAH Commons "Member" page buttons are formatting incorrectly.

Describe the bug
On SAH Commons, the "Members" page showed duplicate buttons. One is gray and cannot be selected. The other follows typical Commons styling. This only is affecting SAH Commons and not our other nodes.
To Reproduce
Steps to reproduce the behavior:

Go to 'sah.hcommons.org/members'
Click on 'All Members' and 'SAH Members'
See error.
Click on 'Following.' A similar bug occurs with slightly different text.

Expected behavior
Only one button should occur.
Context
Does this bug on production, development, or both?

[ ] Tested on development instance
[ ] Occurs on development instance
[x] Tested on production
[x] Occurs on productions

Screenshots

This has been corrected.


Set close_fds in cmd?

Hi,
looking at the list of open files of a process spawned by a shake program, I noticed that it has, among other things, the shake data base open. At least on Linux, if you fork and exec, any open files are also available to the client.
I don’t think that this is ever, or at the most very rarely, the intended behavior in a shake program. Maybe close_fds should be set to True in process in General.Process?
Greetings,
Joachim

Yep, seems perfectly sensible - I've done that unconditionally.


Documentation for EndpointConvention

I stumbled across the EndpointConvention  class while digging through sources. It's incredibly useful, and yet I see it is not documented anywhere; is there specific a reason for this, other than time?

It's not ready for prime time, and thus hasn't been documented. It's dark functionality at this point.

So after the last commit can we document it? I can write something.

@phatboyg I was messing around with this method of registering send endpoints and I ran into a bit of a challenge. It doesn't seem to understand type hierarchies, so registrations are matched only on exact type matches. Thus, I can't register a base type and then expect it to properly route a derived implementation. Furthermore, if I register ISomeCommand and then call  _bus.Send(new SomeCommand(), it will try to route on the type SomeCommand and fail to select the convention for ISomeCommand. You must be explicit: _bus.Send<ISomeCommand>(new SomeCommand()).
For this to be ready for prime time, I think the functionality of the type matching needs to be expanded to respect derived types.

Which is why I said it wasn't ready! :)
Seriously good suggestions and ones that are easily implemented. An exact type match should have priority, but lacking an exact match would defer to the next closest type.

No problem, totally understand.
Is there any any advice with the current version of MassTransit around making endpoint Uris configurable? With NServiceBus, routes can be defined using the App.config, but with MT, there doesn't seem to be anything configurable. I found something for MT 2.x which was registering some kind of routing service, but it was not 3.x compatible.
If necessary, I can pass around some kind of Uri service and make it available anywhere I need to send a command- services, controllers, consumers, etc, but that is clearly cumbersome. I'd really like to take advantage of this EndpointConvention, if there's not a more developed option.
Cheers

Implemented messages types will now be supported as well, in the next release :)

I built something rather handy which you may be able to benefit from. My implementation understands the "hierarchy" of interfaces such that the "most specific" message convention can be selected when registering  multiple conventions. Thus, given conventions for both IBase and IDoUpdate, sending a DoUpdate : IDoUpdate message would select the IDoUpdate convention, over IBase.
Here's you go: https://gist.github.com/lakario/b9d73099e453c1832fc3638ff397f29a.

Complicated!
I think the message type check does the same thing without the ambiguity check, which is what I'm doing now. It checks at each level using the same approach to finding messages types on the most derived type.

I may have over-engineered my implementation.... just a little. =)

Is there anything more to document than EndpointConvention.Map<TMessage>(Uri uri)? I use it, can write a page.

Not really, I'm replacing almost everything related to this with the topology/routing/policy features I'm working on in the topology branch.

So I am really to early to use it or you keep the convention mapping as well?

I'm sure it will remain for a while, even after the new stuff is introduced, but it will be replaced by a well documentation system for defining the topology (how the broker is configured, and how features like routing keys and partition keys are applied from messages), routing (for commands and non-published types), and policy (for dealing with availability issues, rerouting traffic, etc. based upon application conditions.

Wow, that's a lot!

It's a big effort for sure, and topology will launch first, quickly followed by routing and policy.

Is there any update on these new features? I am at a place where I need to use the EndpointConvention.Map but I am not sure if this is still the only (or best) way to register the Conventions?

New functionality is not released yet.

The ScheduleSend api will also take advantage of this endpoint convention? It will also be usefull to allow to configure destination address for scheduled commands.


Added a contrib folder which contains Docker examples

@MalloZup and @dmacvicar when you get a chance could you look over the Docker examples I provided.
Added a contrib folder which contains Docker examples for Alpine, Debian, openSUSE. Additionally, included a build Dockerfile for building the provider. Provided documentation for all Dockerfiles via README.md files.
Fixes #617

@james-crowley  I just had quick look on this, seems pretty good thx!

Make the commit message better then the actual ones.  Fixes , Pushing changes etc. Just squash them or make a good Title and description.

You can add a Link to the contrib/Readme.md in to the global readme. Imho you could reference it  here:
https://github.com/dmacvicar/terraform-provider-libvirt#upstream-projects-using-terraform-libvirt

After that section, you can create one saying a short desc about it and the link

@MalloZup I updated the root's README.
I tried to do a squash but something went terribly wrong as you can see with all my new commits. Any suggestions/fixes? Don't squash my commits that often.

@james-crowley  git rebase and git sqaush is a secret/dark art which Is difficult to explain. It is pita.
I don't mind if you close the PR and open new one. As you wish.
IF you want to solve the conflicts, you need to git pull upstream then rebase to upstream and then you need to figure out the conflicts individually

I am going to close this, fix the issues then open a PR. Thanks for the insights into git rebase.


Octave 5.1.0 package for Ubuntu 18.04 Bionic

I want to use GitHub Actions for CI with octh https://github.com/ctaggart/octh/issues/47. They support 18.04 Ubuntu for CI and already have Rust installed. I noticed that @svillemot recently added support for Octave 5.1.0 in Debian Sid. It would be amazing if that could be down-streamed to Ubuntu 18.04 Bionic.
I grabbed the source code from these two places to compare it, which is what this issue is for.
https://salsa.debian.org/pkg-octave-team/octave
https://code.launchpad.net/~octave
I realize that I have no idea what the process is or how to do this.
BTW, the helloworld is working now in Rust with if someone wishes to try it.
cc @mtmiller

I'm just going to build the package using cargo deb instead of trying to figure all this out. #4