Batch DELETE throws batch-response-parser error

Hello,
I am doing a batch request which contains DELETE requests for PurchaseOrderItems using the following code:
public async deletePurchaseOrderItems(purchaseOrderId: string, purchaseOrderItemIds: string[]): Promise<void> {
    try {
        const deleteRequests = purchaseOrderItemIds.map(poi =>
            PurchaseOrderItem.requestBuilder().delete(purchaseOrderId, poi)
        )
        // Execute the batch request
        await batch(changeset(...deleteRequests)).execute(Constants.DESTINATION);
        this.logger.debug(`Purchase Order ${purchaseOrderId} items deleted`);
    } catch (err) {
        this.logger.debug(err);
    }
}

The request does what I need, which is to mark for deletion the items in the Purchase Order, but the logs show an error:

Could you please help me figure out where is the error coming from an how to handle it?

Hi @stefania-santimbrean , thank you for approaching us.
From the log statement, I assume this is either because of the unexpected response format from the service or there is a bug from the sdk.
Is it possible to provide the response so that we can understand better?
Please be aware, I see logs with both error and warn levels, which might come from different cases.
Therefore, if you see batch response with different format, please share them together.
Thank you very much.
Junjie

Hi @stefania-santimbrean , thank you for approaching us.
From the log statement, I assume this is either because of the unexpected response format from the service or there is a bug from the sdk.
Is it possible to provide the response so that we can understand better?
Please be aware, I see logs with both error and warn levels, which might come from different cases.
Therefore, if you see batch response with different format, please share them together.
Thank you very much.
Junjie

Hello @jjtang1985 ,
Thanks for responding so quick!
I changed the code to:
// Execute the batch request
const response = await batch(changeset(...deleteRequests)).execute(Constants.DESTINATION);
this.logger.debug(response);

The logged response object looks like this:
[
  {
    "responses": [
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      }
    ]
  }
]

Snapshot of response object from debugger maybe is better:

Please let me know what else can I do to further provide information about the issue.
Thank you,
Kind regards,
Stefania

Hello @jjtang1985 ,
Thanks for responding so quick!
I changed the code to:
// Execute the batch request
const response = await batch(changeset(...deleteRequests)).execute(Constants.DESTINATION);
this.logger.debug(response);

The logged response object looks like this:
[
  {
    "responses": [
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      },
      {
        "body": {},
        "httpCode": 204
      }
    ]
  }
]

Snapshot of response object from debugger maybe is better:

Please let me know what else can I do to further provide information about the issue.
Thank you,
Kind regards,
Stefania

Hi @stefania-santimbrean , thank you for your example.
Theoretically, 204 means the response body should be empty, but the error was Unexpected token d....
I guess the raw response body contains some lines or words starting with a d.
May I ask you to debug further via e.g., postman so that we can see the complete raw response from the service?
By the way, I assume you are using this pre-built client @sap/cloud-sdk-vdm-purchase-order.

Hi @stefania-santimbrean , thank you for your example.
Theoretically, 204 means the response body should be empty, but the error was Unexpected token d....
I guess the raw response body contains some lines or words starting with a d.
May I ask you to debug further via e.g., postman so that we can see the complete raw response from the service?
By the way, I assume you are using this pre-built client @sap/cloud-sdk-vdm-purchase-order.

Hello @jjtang1985 ,
I tested now the BATCH delete with the same payload in Postman and this is the response:
--3B17E95920A7FAF8BCB7495D043515000
Content-Type: multipart/mixed; boundary=3B17E95920A7FAF8BCB7495D043515001
Content-Length:      2427

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001--

--3B17E95920A7FAF8BCB7495D043515000--

I attach also the versions I use:
"@sap-cloud-sdk/core": "^1.35.0",
"@sap/cloud-sdk-vdm-purchase-order-service": "^1.23.0",

Please let me know what else can I do.
Thank you so much,
Stefania

Hello @jjtang1985 ,
I tested now the BATCH delete with the same payload in Postman and this is the response:
--3B17E95920A7FAF8BCB7495D043515000
Content-Type: multipart/mixed; boundary=3B17E95920A7FAF8BCB7495D043515001
Content-Length:      2427

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001
Content-Type: application/http
Content-Length: 71
content-transfer-encoding: binary

HTTP/1.1 204 No Content
Content-Length: 0
dataserviceversion: 2.0

--3B17E95920A7FAF8BCB7495D043515001--

--3B17E95920A7FAF8BCB7495D043515000--

I attach also the versions I use:
"@sap-cloud-sdk/core": "^1.35.0",
"@sap/cloud-sdk-vdm-purchase-order-service": "^1.23.0",

Please let me know what else can I do.
Thank you so much,
Stefania

Hi @stefania-santimbrean,
Thank you for your raw response example.
I can reproduce your error by using the example provided.
This is a bug from the SDK and we will work on it.
Please correct me.
From my understanding, the batch request is executed without any issues, meaning the delete operations are successfully applied.
The response object looks also fine, since 204 should not return any real data as body.
The issue is about the false-positive error message.
Best regards,
Junjie

Hi @stefania-santimbrean,
Thank you for your raw response example.
I can reproduce your error by using the example provided.
This is a bug from the SDK and we will work on it.
Please correct me.
From my understanding, the batch request is executed without any issues, meaning the delete operations are successfully applied.
The response object looks also fine, since 204 should not return any real data as body.
The issue is about the false-positive error message.
Best regards,
Junjie

Hello @jjtang1985 ,
Yes, you are right, the issue is about the error & warn logs. I rely on the logging for the app (someone might look at the logs often to make sure the app does its job).
Do you happen to know when you can release a fix?
Thank you so much for the support,
Best regards,
Stefania

Hi @stefania-santimbrean ,
the backlog item was refined and we might start working on it next week, but there is no guarantee.
Could you please share whether the issue is related a productive application, staging environment or maybe PoC project?
Thank you.
Best regards,
Junjie

Hello @jjtang1985 .
It's intended for a productive application that I developed and is going into testing now.
Best regards,
Stefania

Hi @stefania-santimbrean ,
I'll share this information with the team and will let you know once there are some updates.
Best regards,
Junjie

Hello @jjtang1985 ,
Thanks so much for all the support!!
Best regards,
Stefania

Hey @stefania-santimbrean, we have solved the issue and it should be available to you in the next release, please let us now if the issue was solved for you.

Hi @stefania-santimbrean ,
we released a new version 1.40.0 this morning.
I'll close the ticket.
Please feel free to reopen or comment in case you have further questions.
By the way, we release a canary version to npm for every commit, which means actually you could already test the canary version when the PR was merged.

@tomfrenken @jjtang1985 ,
Thanks so much for the support with the issue! Just got around to test it and it works, sorry for the delay :)


Direct launch for RetroFlow/HexFlow

Here is the LUA+ code I used as a test.
System.executeUri("psgm:play?titleid=YYOLOADER&param=ux0:data/gms/Bombastic/")
System.exit()

The game works fine normally, but when I launch it like this, it downloads the Yoyoloader compatability list then crashes.
What is the proper format for launching?

Actually after searching the code I'm doubtful this app supports direct launch.
Here is how they implemented reading these URI calls in fake-08, a different emulator written in C++ that started supporting direct launch like a year ago.
https://github.com/search?q=repo%3Ajtothebell%2Ffake-08+param&type=code

Thank you x999999 if you can add this


How to SSR with php V8 the vue 3 website?

What problem does this feature solve?

I know v8 can server side render vue 2.5.
Maybe there's better strategy to server side render vue 3 code integrated in laravel 8 (php) website?
Benefit would be huge, just finished migrating from vue 2. SSR could be next thing if a sharp, pro person could help
What does the proposed API look like?
Just be compatible with V8 as in 2.5 (unless there' better way)

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server or StackOverflow.


RE: VariantLens

2 thoughts

rename: VariantLens.GenerateUsed -> NoMissingVariantPrism
a. One because in Optics terms "Lenses" don't operate over Sum types / ADT's only "Product Types" aka records. Prisms operate over Sums/ADTS/Variants...
b. To match better with NoMissingRecordFieldLens 🤷♂

Generate Prisms inline below the definition of the Variant to not force the defining module to expose its constructors.
EG: I'd like to "expose" some lenses for operating over say pieces of an otherwise opaque record... something like...

module OpaqueThing exposing (Stuff, current)

type Stuff = Stuff Internal
-- generated opaque Prism constructor for composing helpers for accessing pieces of internal state.
onStuff : Lens Stuff Internal reach wrap
onStuff  = -- ...

type alias Internal =
    { current_ : String
    , toggle : Bool  -- Notice callers have no access to this toggle property.
    }

current : Lens Stuff String reach wrap
current = onStuff << Lens.current_

renaming variant lens to prism → approve

i didn't know terminology better then
i've added this to plans for the next breaking version

GenerateUsed is more clear than NoMissing IMO
internal prism reference is a good idea

are you motivated to implement this yourself? Otherwise you might have to wait some time, sorry
i've added this to plans for the next breaking version

internal prism reference is a good idea are you motivated to implement this yourself? Otherwise, you might have to wait some time, sorry

It's what I had in the original PR see here for how I had implemented it before.
https://github.com/lue-bird/elm-review-missing-record-field-lens/pull/2/files#diff-51ee51156bc0e70de37a9487fc4867daf98cb8a198b9d400d5cb974889677868

Done


Update custom.props for 21.03 release

Bump version to 2.8.0 for 21.03 release on iOS and .NET
Microsoft Reviewers: Open in CodeFlow

Closing since we are not shipping 21.03


Add orgs Rethink Charity and Rethink Priorities

Because the latter is an offshoot of the former, it makes sense to work on both together, I think.

Rethink priorities is ready for review. I'll create a new file for Rethink Charity.

I created file rethink-charity.sql and added 14 incomplete positions. rethink-charity.sql is not ready for review yet.

I completed 44 positions on rethink-charity.sql. Both rethink-charity.sql and rethink-priorities.aql are ready for review.


perf(deps): update component to use the latest version of auro-menu

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Summary:
Updates the component to use the latest version of auro-menu
Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 1.10.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Endpoint to discover a providers consumers

Is there a way to discover which consumers have pacts registered for a given provider. I'd rather dynamically run the ones available rather than hard code the ones I know about.

You'd need to do some filtering on the /pacts/latest endpoint. It wouldn't take much to make a /pacts/provider/xxx endpoint.
However, you still need to write code to set up the provider states for each consumer, so you'll never be able to run it completely dynamically.

Oh, you know what, I did make an endpoint /pacts/provider/<provider_name>/latest.


Further tweaks to public site.

Description

Sort the samples in a very particular way based on name.
Change "menu" to "terms" in the header.
Add a new more permanent url at /covid-19.
Open the Betacoronavirus genus row by default in the report page.

I'm going to merge this!


KAFKA-7204: Avoid clearing records for paused partitions on poll of MockConsumer

The previous version of MockConsumer does not allow the clients to test consecutive calls to poll while consuming only from a partial set of partitions due to the fact that it clears all the records after each call. This change makes MockConsumer clearing the records only for the partitions that are not paused (whose records are actually returned by the poll). The remaining paused partitions will retain the records.
Unit test added accordingly.
Committer Checklist (excluded from commit message)

[x] Verify design and implementation
[x] Verify test coverage and CI build status
[x] Verify documentation (including upgrade notes)

retest this please

@guozhangwang @mjsax @ableegoldman can any of you guys have a look at this MR? I don't think the test failing has anything to do with the changes. Thanks 🙏

The proposed fix LGTM, cc @cmccabe @rajinisivaram for another review.

Overall LGTM. I would simplify the test a little bit.

Thanks for the review and the suggestions @mjsax . Just pushed a revised version. 👍

All three runs failed. Result not available any longer. Could it be a checkstyle issue?

All three runs failed. Result not available any longer. Could it be a checkstyle issue?

Indeed it was. Wildcard import. Solved now. Tks again.

Just cycling back to this PR. Seems the Jira ticket was not assigned. I found user epinto (not efgpinto as the GitHub user) -- hope that is correct?

Would like to get a review from core team. \cc @cmccabe @rajinisivaram

Just cycling back to this PR. Seems the Jira ticket was not assigned. I found user epinto (not efgpinto as the GitHub user) -- hope that is correct?

It is correct. Thanks.

Ping @cmccabe and @rajinisivaram for second review and merging.


Add argument to specify listener port instead of random available

Has this been tested?

"it works on my machine"

good enough for me lol, code looks fine


Orbit run kickoff - ValueError: dictionary update sequence element #0 has length 20; 2 is required

Hello,
please check the error I found while doing run for the command
vagrant@homestead:~/Code/priips$ sudo orbit run kickoff
Setting UID (0) to "www-data" user in Docker Sync configuration file ...
Traceback (most recent call last):
File "bin/docker-compose", line 6, in
File "compose/cli/main.py", line 68, in main
File "compose/cli/main.py", line 121, in perform_command
File "compose/cli/main.py", line 768, in run
File "compose/cli/main.py", line 1178, in run_one_off_container
File "compose/service.py", line 288, in create_container
File "compose/service.py", line 795, in _get_container_create_options
File "compose/service.py", line 1338, in build_container_labels
ValueError: dictionary update sequence element #0 has length 20; 2 is required
Failed to execute script docker-compose
this run inside vagrant machine

Resolved/fixed
downgrade from docker-compose 1.17.0 to 1.14.0

Sorry for the late answer!
For the kickoff project, you should never use root user (nor sudo) :-)


[black] formatted comp file

PARTIALLY Fixes #30
In order to solve Issue #30, I applied black to the file: tofu/geom/_comp.py
Since this is a time consuming process, I rather check if the first first file fits the rest of the team's expectation (notably @Didou09). If so next PR will be with all *.py files, changed analogically.

Hello @lasofivec! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tofu/geom/_comp.py:

Line 896:28: E203 whitespace before ':'

Hello @lasofivec! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tofu/geom/_comp.py:

Line 889:28: E203 whitespace before ':'

Comment last updated at 2019-09-09 17:02:59 UTC

This is a know difference between flake8 and PEP8 rules. I decide we can ignore it

Codecov Report

Merging #182 into devel will increase coverage by <.01%.
The diff coverage is 63.82%.

@@            Coverage Diff             @@
##            devel     #182      +/-   ##
==========================================
+ Coverage   45.16%   45.17%   +<.01%
==========================================
  Files          70       70
  Lines       20608    20611       +3
==========================================
+ Hits         9307     9310       +3
  Misses      11301    11301

Impacted Files
Coverage Δ

tofu/geom/_core.py
64.7% <100%> (ø)
:arrow_up:

tofu/geom/_comp.py
60.3% <63.7%> (+0.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c8cf8...025af3e. Read the comment docs.

Good moves :-)

@Didou09 did you see in detail the code ?
Should I do the same changes for all *.py files? There are other tools to do the pep8 formatting it's a matter of taste :)


CookieStore API missing

Available in Chrome as of version 87.
https://wicg.github.io/cookie-store/
Not on standards track yet but sorely needed as an async solution for dealing with cookies.

Duplicate of #5659. But as mentioned in https://github.com/Fyrd/caniuse/issues/5659#issuecomment-715689093 still not live on the site. Data is here: https://github.com/Fyrd/caniuse/blob/master/features-json/cookie-store-api.json

Closing as duplicate of #5659 .


Compilation using old version of CMake

Hey guys,
I was looking for a library to realize an RTP-stream and found yours, which seems to be amazing. I am working on a Jetson and wanted to install your library but was not able to as my CMake version (3.10.2) does not support the command in line 79 (add_compile_definitions(HAVE_GETRANDOM=1). I tried to just step over that issue by commenting it out. After commenting it out I was able to install it following your instructions. But when I now try to compile your main.cc example I get a huge error stating that there are a lot of undefined references to the cryptopp and I wanted to ask you if it probably has something to do with my hack in line 79 in the CMakeLists.txt file.
Is there another possibility to install it using my CMake version?

sorry guys, a typical pebcac mistake, I forgot to include the cryptopp lib while compiling


Feature notification permission

Description
Adjust plist for ios notification, add notification permission field
About #3770
Checklist:

[x] PR title matches follow: (Feature|Bug|Chore) Task Name
[x] My code follows the style guidelines of this project
[x] I have followed all the instructions described in the initial task (check Definitions of Done)
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have added reference to a related issue in the repository
[x] I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
[ ] I have added screenshots related to my pull request (for frontend tasks)
[ ] I have pasted a gif showing the feature.
[ ] @mentions of the person or team responsible for reviewing proposed changes

Will ask
2, 3. In this case will remove remote. Android and ios doesn't need configuring in plist and manifest for local notifications, we only need to request permission in code for ios

ok, please test my changes tomorrow


Allow for arbitrary conditions as join condition.

This is rebased onto #1018, please review that first.
Closes #995

Adding conditions turned out it a pretty small change in exchange for much more increased flexibility.

Yeah, that was a nice surprise for a change.

That's merged and polished now.


env::KeyOrValue stores raw T, not Value

This is slightly cleaner, and allows interacting with the Concrete
item directly without needing to downcast from Value.
Split this out as a separate commit because I want to run bloatcmp.

/bloat

Cool, I was curious about this; Value is taking up a bunch of space in various places, likely because of the size of FontDescriptor.


Accept tags files that use line number, not just complete line search

See https://github.com/elaforge/fast-tags/issues/19
Whereas Vim will accept tags files that just have a number in the command (jump to definition means go to the given line number), Atom only accepts the text string of the complete line for a search. This means less flexibility in working with various tools that create tags files.
Atom should be updated to accept the line number approach. Incidentally, Atom does work with such files to at least search by tag and go to the right file, but it totally fails to jump to definitions under the cursor when the tags file uses just line numbers rather than full text.

Is this a duplicate of atom/symbols-view#92?

Yes, this is a duplicate of https://github.com/atom/symbols-view/issues/92


fix: shutdown node issue

Can we increase the timeout to 60 seconds for slower pcs

Can we increase the timeout to 60 seconds for slower pcs

Can we increase the timeout to 60 seconds for slower pcs

Hmm it's already 30 minutes. I can adjust the time, which one you prefer?

Can we increase the timeout to 60 seconds for slower pcs

Hmm it's already 30 minutes. I can adjust the time, which one you prefer?

Oh then that's too long, let's make it 5 minutes

Oh then that's too long, let's make it 5 minutes

Updated @monstrobishi

Updated @monstrobishi


Is the API supposed to be public?

I'm trying to test the example on the website but I'm getting an error regarding cross origin requests not being enabled.
XMLHttpRequest cannot load https://tinyfac.es/api/users. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://s.codepen.io' is therefore not allowed access.

Hi @marcorivm , yeah it should! I will start investigating this now. Stay tuned!

@marcorivm Can you check now? I pushed a potential fix.
http://codepen.io/anon/pen/pRaJWq

Due to inactivity this will be closed...

Sorry, I had to opt for another API since I was in a hurry and couldn't check it later. But the codepen example looks like it's working.


Bump jira version to support 7.13.x

Prism is now listed as incompatible with JIRA 7.13.0
It seems to be working fine though

Yes, it's compatible with 7.13.0 so I just updated the supported versions on Marketplace.


[Container cert] Preflight blows up on MongoDB RPMs with "invalid tag summary"

Bug Description
A container whose RPM data shows that both of these RPMs are installed:
https://repo.mongodb.org/yum/redhat/8Server/mongodb-org/5.0/x86_64/RPMS/mongodb-org-shell-5.0.3-1.el8.x86_64.rpm
https://repo.mongodb.org/yum/redhat/8Server/mongodb-org/5.0/x86_64/RPMS/mongodb-cli-1.20.3.x86_64.rpm
will cause Preflight to blow up:
time="2022-06-13T16:39:54-04:00" level=info msg="check completed: HasNoProhibitedPackages" ERROR="could not get rpm list: invalid package info: invalid tag summary" result="could not get rpm list: invalid package info: invalid tag summary"
Version and Command Invocation
Preflight version 1.2.1
Command:
preflight check container quay.io/redhat_emp1/jfrancin-quaytest-1:9.30 --docker-config /run/user/1000/containers/auth.json
Steps to Reproduce:
(How can we reproduce this?)

Create a simple container that has the two MongoDB packages mentioned above installed using Yum in the Dockerfile (see Additonal Context)
Push the container to a registry.
Run the preflight command above

Expected Result
The "could not get rpm list" error would not occur
Actual Result
The error in the Description occurred.
Additional Context
Minimal Dockerfile to reproduce this:
---cut here----

Test dockerfile to reproduce Preflight error

FROM registry.access.redhat.com/ubi8/ubi-init
LABEL name="abot/stacks"
summary="Stacks image for Abot application"
description="ABot-Stacks(Red Hat UBI)"
maintainer="Rebaca Technologies<EMAIL_ADDRESS>vendor="Rebaca Technologies Pvt. Ltd"
version="9.22"
io.openshift.tags="abot-stacks 9.22"
io.k8s.display-name="abot-stacks 9.22"
RUN yum -y install https://repo.mongodb.org/yum/redhat/8Server/mongodb-org/5.0/x86_64/RPMS/mongodb-org-shell-5.0.3-1.el8.x86_64.rpm &&
yum -y install https://repo.mongodb.org/yum/redhat/8Server/mongodb-org/5.0/x86_64/RPMS/mongodb-cli-1.20.3.x86_64.rpm &&
yum clean all
USER 1001
---cut here----

For some reason the mongocli's summary in the RPM package header tag value is coming as a value of a string instead of international string even though it parses as an international string. I think we can fix this in go-rpmdb library, but I'd like to understand why this library is coming across differently.

My guess - and it's only a guess - is that MongoDB is using an old set of RPM generation tools, which pre-date the change of that field from string to international string.


Trigger CI

Just verifying if the CI is happy with master or not.

None of the tests in the odf-console-e2e-aws step actually go to the OCS-SC-SS page, which is probably why the tests passed. However, for a brief moment here (https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/red-hat-storage_odf-console/82/pull-ci-red-hat-storage-odf-console-master-odf-console-e2e-aws/1470319419677741056/artifacts/odf-console-e2e-aws/tests/artifacts/gui-test-screenshots/videos/list-page.spec.ts.mp4) we can see that from 0:18 to 0:21, the page fails to load.


[backport/1.26] Backport stack

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@wbpcode this should be ready to land i reckon - not sure if there is anything else to include


TypeError from 'styled-jsx'

Bug report
Describe the bug
I tried to run next with custom server, but i got error when accessing to page.
TypeError: _stylesheetRegistry.default is not a constructor

ssr/server.js:
// This file doesn't go through babel or webpack transformation.
// Make sure the syntax and sources this file requires are compatible with the current node version you are running
// See https://github.com/zeit/next.js/issues/1245 for discussions on Universal Webpack or universal Babel
const { createServer } = require('http');
const { parse } = require('url');
const next = require('next');

const dev = process.env.NODE_ENV !== 'production';
const app = next({ dev, dir: 'src/' });
const handle = app.getRequestHandler();

app.prepare().then(() => {
    createServer((req, res) => {
        handle(req, res, parse(req.url, true));
    }).listen(4000, err => {
        if (err) {
            throw err;
        }

        console.log('> Ready on http://localhost:4000');
    });
});

next.config.js:
const path = require('path');
const withPlugins = require('next-compose-plugins');
const sass = require('@zeit/next-sass');
const typescript = require('@zeit/next-typescript');
const sourceMaps = require('@zeit/next-source-maps');
const ForkTsCheckerWebpackPlugin = require('fork-ts-checker-webpack-plugin');

module.exports = withPlugins(
    [
        [sass],
        [typescript],
        [sourceMaps],
    ],
    {
        dir: 'src/',
        distDir: path.resolve(__dirname, '.next/'),
        webpack(webpackConfig, { defaultLoaders, isServer }) {
            webpackConfig.resolve.modules.push(path.resolve('./src'));

            webpackConfig.module.rules.push({
                test: /\.js$/,
                include: /node_modules/,
                use: [defaultLoaders.babel],
            });

            if (isServer) {
                webpackConfig.plugins.push(
                    new ForkTsCheckerWebpackPlugin({
                        tsconfig: path.resolve('./tsconfig.json'),
                    })
                );
            }

            return webpackConfig;
        },
    }
);

To Reproduce
Expected behavior
Screenshots
System information

OS: macOS
Browser (if applies) [e.g. chrome, safari]
Version of Next.js: 8.0.3
Version of styled-jsx: 3.2.1

Additional context

Please provide a full reproduction repository so that we can look into the actual code. This is missing pages.

Got this error after upgrading from Next.js 7 to 8. Clearing out .next, node_modules, and package-lock.json, followed by a fresh npm install fixed it.
(probably only need to clean out .next)


The KERNEL environment variable must be set for building the bootloader

Hi, phil-opp. thanks for the great tutorials!
I get a error message while running bootimage build,  as below.  Did I forget something?
Building kernel
    Finished dev [unoptimized + debuginfo] target(s) in 0.04s
Building bootloader v0.5.2
   Compiling bootloader v0.5.2 (/home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/bootloader-0.5.2)
error: failed to run custom build command for `bootloader v0.5.2 (/home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/bootloader-0.5.2)`
process didn't exit successfully: `/home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/bootloader-0.5.2/target/release/build/bootloader-32a07e818805476f/build-script-build` (exit code: 1)
--- stderr
The KERNEL environment variable must be set for building the bootloader.

Your version of bootimage is probably too old. Try updating it through cargo install bootimage --force.
The build system of the bootloader changed with version 0.5.0 (it now requires a KERNEL environment variable), so we needed to release a new version of bootimage as well.
I just published a new bootloader version (0.5.3) that improves this error message and suggests updating bootimage.

Thanks, compiled success!!!!!!!

Perfect, thanks for the quick update!


Improved UserDefault propertyWrapper

Added support for UserDefaults "type coercing" e.g. string "1" can be read from UserDefaults as 1 Int
UserDefault can now be used with optional types and will also get correctly removed if nil
Also added nested optional handling

💯


Fix @require function name on some function comments

In order to avoid the Sassdoc [WARN]

Thank you!

Thank you Hugo! We use a lot Sassdoc and SassyCast!


Teams admin center: change of behaviour in blocking an app with new app centric management functionality

Steps to reproduce
Make sure the teams admin center is utilizing the new feature "app centric management" doc here

Create a bot app that is working and responding
Create another app with staticTabs and make sure to point to the the BOT (app id) created in STEP 1. install the app
Make sure the app is working and BOT is responding to messages
Now, block the app created in STEP 1 from manage apps module
Make sure the bot app created in STEP 1 has "assignments" as "everyone"
Now go to the app created in STEP 2 (wait for 24hrs until changes reflect) try to communicate with bot, the BOT does not respond

Previously with "manage apps -> permissions policies" doc here the above steps worked, blocking the app STEP 1 never caused issue to the app STEP 2. the communication in BOT always worked.
Expected behavior
Bot should respond
Actual behavior
Bot does not respond
Error details
No response

Thanks for raising your issue. We will check this at our end and will update you accordingly.

@raguravindran - We have raised a bug for the same. We will inform you once we get any further update from engineering team. Thanks!

@raguravindran - We have raised a bug for the same. We will inform you once we get any further update from engineering team. Thanks!

Thank you

@Prasad-MSFT  its been 2 weeks, could you please let me know if there any update?

Hi @raguravindran - We got update from engineering team saying, "we do not support multi app bots for this reason. The behavior is non-deterministic and thus can change at any time."


ENH: Raise Warning when a user hedges derivative with an unrelated hedging_instruments

cf. https://en.wikipedia.org/wiki/Directed_acyclic_graph ?

closing as priority is low


How to run faster in the co-simulation between CARLA & SUMO?

Hi! I'm trying to run more simulation time in real time. (e.g. 1s in real life →1 min in simulation world)
To achieve this, I've tried change the settings.synchronous_mode from TURE to FALSE in the wish to run the server as fast as possible, but it doesn't work.
If you know how to solve it, please give some advises, thanks in advance!

Also, when my scene gets more complex(more vegetation or vehicles), the simulation speed slows down(1s in real life≈5s in simulation). I also notice that vegetation in CARLA are dynamic which is unnecessary for me. Whether the simulation speed will rise, if I change the mode from dynamic to static.

Hi @EchoYJJ. The co-simulation between CARLA and SUMO needs to be run in synchronous mode for both simulators. Otherwise, it is likely to lose the synchronization between both simulations at some point.
I've made a couple of changes to get faster co-simulation between CARLA and SUMO by default in this branch: https://github.com/carla-simulator/carla/tree/joel-mb/sumo_layers. Could you test if this is speeding up the co-simulation for your use case? I've added a new argument to be able to unload all the map layers and increase the performance (https://carla.org/2020/12/22/release-0.9.11/#map-sublevels). Take into account that this feature is available in the latest CARLA version (0.9.11) and that you need to use Opt maps.
# Load opt map for Town01 (execute in <CARLA_ROOT>/PythonAPI/util)
python3 config.py -m Town01_Opt

# Run co-simulation (execute in <CARLA_ROOT>/Co-Simulation/Sumo)
python3 run_synchronization.py examples/Town01.sumocfg --sumo-gui --unload-all-map-layers

Also, take into account that the run_syncrhonization script will be always faster than spawn_npc_sumo. The lastest needs to check in every tick if the SUMO vehicle has arrived to the end of its route and reassing a new one if needed.

Thanks a lot for your replying!
I think the first thing I need to do is to update my CARLA 0.9.10 to 0.9.11.
Also, I first notice that github sources have branches from different authors. Can I perceive it as slight improvement to handle bugs but still base on CALRA 0.9.11, and you focus on the SUMO co-simulation?

@EchoYJJ Yes, you need to use at least CARLA 0.9.11. You can download it from here: https://github.com/carla-simulator/carla/releases/tag/0.9.11. You can also build CARLA from source using the branch I said in my previous comment. However, for this test, is enough using the package.
We use different branches to introduce new features and bug fixes into the dev branch. In the end, the dev branch is the one used to release new versions of CARLA (e.g., 0.9.12).


docs: Replace OS codenames with numbers

I always struggle to recall what number a codename is related to, so this would be a +1 in my book. I might however suggest having both, e.g. Debian 12 (Bookworm)

I always struggle to recall what number a codename is related to, so this would be a +1 in my book. I might however suggest having both, e.g. Debian 12 (Bookworm)

Thanks for your feedback @nickanderson.
There is however an extra hidden motivation in doing this change: to have our tabs render in one line! See how they look right now:

So having both the codename and the number would defeat this.

So having both the codename and the number would defeat this.

Screen space is the toughest final boss

@mender-test-bot cherry-pick to:

hosted
3.7.x


Add linked list Order Independent Transparency to the OITZoo example

Gonna implement Adaptive Transparency with KHR_pixel_shader_interlock in https://github.com/Devsh-Graphics-Programming/Nabla


RuntimeError: storage has wrong size: expected -4885659930368473377 got 589824

Hi, Zhuang.
I meet a problem in /ShelfNet18_realtime/train.py
 if it % 1000 == 0:
    ## dump the final model
    save_pth = osp.join(respth, 'shelfnet_model_it_%d.pth'%it)
    # net.cpu()
    # state = net.module.state_dict() if hasattr(net, 'module') else net.state_dict()
    # if dist.get_rank() == 0: torch.save(state, save_pth)
    torch.save(net.module.state_dict(),save_pth)

    if it % 1000 == 0 and it > 0:
        evaluate(checkpoint=save_pth)

when this code block runs in the following line evaluate(checkpoint=save_pth), it appears the problem in /ShelfNet18_realtime/evaluate.py
def evaluate(respth='./res', dspth='/home/cjj/datasets/CityScapes/Fine', checkpoint=None):
...
if checkpoint is None:
        save_pth = osp.join(respth, 'model_final.pth')
    else:
        save_pth = checkpoint
    net.load_state_dict(torch.load(save_pth))
    net.cuda()
    net.eval()
...

and the line net.load_state_dict(torch.load(save_pth))  arises a error like that :
RuntimeError: storage has wrong size: expected -4885659930368473377 got 589824
Have you meet this problem like that? Thx

Hi, I have not met this error before. Did you check PyTorch version? The repretrained weight is saved by PyTorch1.1. If you generate your own weights, I guess it's either related to PyTorch version or the file is corrupted. Perhaps you can train for only 1 epoch, then test if can resume using saved weights.


Project tidying

bits and pieces of tidying in pyproject.toml and dependencies

make ruff configuration consistent with the main project
make mypy configuration consistent with the main project
~remove unused fixtures, and unused dependency virtualenv (though it shows up via pre-commit anyway)~

apparently I forgot pytest --integration, so virtualenv and the fixtures had better go back

guessing the pipeline failure is because github have changed something about the environment that they are providing for macos, and the CI cache does not spot the difference


Make CrashReporting.SharedInstace static

As seen here, FIRCrash.sharedInstace is a class func, so it should be represented as a static method.

@willsb,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@willsb The fix is in the review process. It will be released soon. Thank you so much for your contribution!

@willsb Just letting you know that the fix is now live.


Clear termguicolors guibg with :hi * guibg=NONE

This is a patch by @nuko8 from #981, allowing terminal vim to clear the background when using termguicolors

You forgot to mention which problem this fixes.

@chrisbra in terminal vim when using :set termguicolors it is not possible to clear the background (allowing transparency or the terminal background to be displayed). :hi Normal guibg=NONE has no effect, so the only way to get a transparent background in a true color terminal is by not setting the guibg - which in many cases means patching colorschemes.
This patch (not written by me) allows :hi Normal guibg=NONE to clear an existing guibg highlight. See #981 for more information.

Nick Jensen wrote:

This is a patch by @nuko8 from #981, allowing terminal vim to clear
the background when using termguicolors

Can we have some examples of what this fixes?  And how do we know this
doesn't break anything?
--
"You're fired." (1980)
"You're laid off." (1985)
"You're downsized." (1990)
"You're rightsized." (1992)
(Scott Adams - The Dilbert principle)
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Minimum steps to reproduce:

vim -u NONE
:set termguicolors
:hi Normal guibg=Red
:hi Normal guibg=NONE

Without this patch, the background remains red.
I have built and tested vim and gvim on Arch linux, and vim on cygwin (Windows 7)

Codecov Report

Merging #2332 into master will increase coverage by 0.05%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #2332      +/-   ##
==========================================
+ Coverage   74.42%   74.48%   +0.05%
==========================================
  Files          90       90
  Lines      132167   132174       +7
  Branches    30902    29028    -1874
==========================================
+ Hits        98367    98446      +79
+ Misses      33775    33728      -47
+ Partials       25        0      -25

Impacted Files
Coverage Δ

src/syntax.c
77.5% <71.42%> (+0.01%)
:arrow_up:

src/version.c
80.8% <0%> (ø)
:arrow_up:

src/gui_gtk_x11.c
47.6% <0%> (ø)
:arrow_up:

src/ex_cmds2.c
80.64% <0%> (+0.09%)
:arrow_up:

src/gui.c
47.63% <0%> (+0.15%)
:arrow_up:

src/if_xcmdsrv.c
84.71% <0%> (+0.17%)
:arrow_up:

src/message.c
68.26% <0%> (+0.19%)
:arrow_up:

src/term.c
50.94% <0%> (+0.21%)
:arrow_up:

src/window.c
81.38% <0%> (+0.52%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dcada1...5cf8d1f. Read the comment docs.

Landed here as well after having read #981.
Could this PR be revived by chance?

Thanks Bram 👍

Awesome! My vim looks reasonably now, not like a malnourished tiger. Thank you. Made me even make out-of-cycle build on my COPR for Fedora/RHEL.

Thanks Bram, this is great.


New Feature: SystemMessage and History for Plugins

Is there a way to pass properly SystemMessage and history into SK plugin/function?
I like the idea to have it, or maybe use ChatHistory to pass as parameter into function.

    public IAsyncEnumerable<StreamingKernelContent> InvokeStreamingAsync(
        Kernel kernel,
        KernelArguments? arguments = null,
        CancellationToken cancellationToken = default) =>
        this.InvokeStreamingAsync<StreamingKernelContent>(kernel, arguments, cancellationToken)

and maybe as part of arguments we can add ChatHisory? or so?

Hi @KSemenenko and thanks for creating this issue. We currently do not have a great way to inject ChatHistory into a plugin, but we are hoping to get a solution for this soon. The backlog item tracking this is #6610.
If you create a plugin from a prompt template, you can define system and user messages there.

Closing for now, feel free to reopen if needed. Thanks.


Android Studio Render Problem

I cloned this MQTTClientSample_Android repo and I opened this with android studio. But I had got render problem in Layout. Fragment Connect, content main, activity main did not render. Fragment client layout had not problem and Fragment Client was rendered.

Dear bthncll,
Thanks for interest in my project and for reporting this issue.
What Android Studio version are you using?

The problems fixed :D thanks


Support Interface with No Methods When it Extends A Base Interface with Methods

See https://github.com/vert-x3/vertx-service-proxy/issues/74
This reproducer is created by following @vietj 's advice to remote @VertxGen from the base interface. Just load the maven module and you should get an IDE compiler error (Interface io.openinnovationlabs.cabit.domain.dispatch.DriverRepository does not contain any methods for generation ). Else mvn clean compile will do as well: https://github.com/sherl0cks/explore-ddd-2018-demo/tree/vertx-codegen-204/cabit/dispatcher. Adding back in the @VertxGen annotation results in Type variable bounds not supported io.openinnovationlabs.cabit.domain.Aggregate

I think I removed this limitation recently

this commit removed this limitation https://github.com/vert-x3/vertx-codegen/commit/ea1b1a885150b1e93f5f4fbc95a4e6ec369efd25#diff-7c8b812b9ac2f99d87c64bed561bc9aa

can you check with master ?


Newer version of DBUtils has different naming schema

It seems that newer versions of DBUtils (and will automatically install if using pip3 to install this exporter) have a slightly different naming schema. Instead of DBUtils and PersistentDB, it was changed to dbutils and persistent_db. Thus, the exporter will have issues running unless the import statement is changed to:
from dbutils.persistent_db import PersistentDB
Unrelated, but it doesn't appear the exporter has a way to input mysql passwords via a secure prompt, and can only be done as an argument. This is generally a poor security practice. A quick fix is to add
from getpass import getpass
comment out the two lines at line ~160 that starts with
@click.option('--mysql password...
and change line ~191 to
password = getpass()
This does make it so that the program asks for the password every time, but it fit our needs and you can likely just hit enter if no password is necessary.

Hi @cdudarchiktw, thanks for reporting the DBUtils issue. I'll release a patch with a DBUtils 1.x version restriction, and upgrade to 2.x in the next minor release.
Regarding the password, the exporter is generally run by some sort of deployment system that has its own way of managing password security, rather than run manually on an interactive command line. e.g. in Kubernetes, you can store the password in a secret, and map it to the MYSQL_EXPORTER_MYSQL_PASSWORD environment variable in the exporter pod. There's usually no reasonable way to provide a password interactively.
However, if you have a use case for running it interactively, please open a separate issue, and I can look into adding an additional interactive password input option.

Fixed in 0.4.2


Would you guys be open to refactoring?

    I see a lot code repetitions and props tunnelings. They just add more complexity as the project gets bigger.
      So, if it's okay with all of you, I want to refactor the code using Redux as state manager. And I want to refactor css as well, for the sake of responsive design, I'd like to use rem instead of pixels. And I think if we start using SASS right now, when we write media queries, it'll make them be easier. And finally, I want to restructure the code to be make it more simple and readable.

Thanks for the contribution! I truly appreciate it as a main contributor of this open source project. This project really helped me get a job as a software engineer during the interview sessions. Please go ahead refactor anything that you want. It's all yours. Here's my suggestions.

React Hooks instead of using Redux.
Styled-components instead of CSS (In terms of scalability, you might consider to use styled-components. You can look it up why it's more recommended. One of the issues with CSS is it can mess up the global scope.)

I got a job because of this community too.

But on the topic at hand, I already refactored almost everything. I used Redux not Hooks because Hooks are for replacing class components. But if you're talking about useReducer hook, I think of it as poor man's  Redux.
(Context API is the one that you can replace Redux)
Styled-components might confuse beginners , so, I plan of using scss with BEM syntax and nesting.
So, we don't have to worry about global name space problem.
So, I'll close this issue now


Add documentation link for hex

Please.
If not I will try and contribute it later on, but as of now I don't know enough about rebar and am trying to make use of this library today.

@CrowdHailer Welp, several years later and the hex docs are now published here: https://hexdocs.pm/libsodium/, but they're semi-useless since I didn't typespec any of my functions.
This library is using the antiquated port driver pattern, is focused mostly on low-level libsodium access, and eventually needs to be rewritten as a NIF.  For most modern high-level use-cases, I'd recommend using jlouis/enacl instead.


Feature: Feedback files

Summary
Provide a simple and secure method for child-processes started by fzf to send back actions that fzf should execute after they exit. This allows child processes, especially those launched with execute or execute-silent, to provide custom logic that controls the way fzf reacts.
How does it work
This pull-requests changes FZF, so that on every execute-type action (such as execute, execute-silent,
transform-*, etc.), it generates a random temporary filename. The file itself is not created, but the executed process can create the file and fill in with actions (separated by either newlines or +s). After the executed command returns, fzf will parse the feedback file if present and enqueue the commands on t.serverChan, so they would be executed by fzf later.
Rationale
Existing Alternatives
The only existing alternative that I know that can be used to implement equivalent functionality is fzf --listen. This is a powerful features, but requires additional complexity and (more importantly) a compromise on security.
Listening on localhost without any sort of authentication exposes the user to several threats:

A malicious script on the internet can bypass CORS and execute arbitrary commands on a running fzf instance by employing a DNS rebinding attack. (This vulnerability can mitigated by limiting the host headers accepted by fzf)
Non-browser applications have no concept of CORS, but often allow arbitrary POST requests to arbitrary URLs which can be manipulated by remote code.
Any non-containerized process running on the same machine, can force the fzf process to execute arbitrary shell commands, even if the other process is running as a different, non-privileged, user. This creates an opportunity for privilege escalation.

Security considerations
The implementation relies on the appending a random suffix to the generated feedback filename. This provides enough security due to the following reasons:

The random suffix is generated using 192 bits from cryptographically secure RNG (crypto/rand), which is secure enough against unlimited-ratio brute-forcing.
The feedback file is never created by fzf, so malicious processes cannot scan for the file.
Even if a malicious process is somehow fast enough to find the feedback file after it was created by the fzf child process, but before it is consumed by fzf, it cannot write to that that file unless it is given write permission by the child process which created it.
The feedback filename is exposed through an environment variable, so it is available only to fzf child processes.

Example use cases
Navigate directory hierarchy
This example builds a very simple file browser that can navigate into directories (including '..') when selecting them with enter, while selecting a file just accepts it:
read -r -d '' RELOAD_OR_ACCEPT_CMD <<-'EOF'
	ITEM='{}'
	if [[ $ITEM == ".." ]]; then
		dirname "$(<$CWD_FILE)" > $CWD_FILE
		echo 'reload(echo .. ; ls -1p "$(<$CWD_FILE)")' > $FZF_FEEDBACK_FILE
	elif [[ $ITEM == */ ]]; then
		echo "$(<$CWD_FILE)/${ITEM%/}" > $CWD_FILE
		echo 'reload(echo .. ; ls -1p "$(<$CWD_FILE)")' > $FZF_FEEDBACK_FILE
	fi
	else
		echo accept > $FZF_FEEDBACK_FILE
	fi
EOF

(echo .. ; ls -1p) | \
	CWD_FILE=$(mktemp | tee >(pwd > $(cat))) \
	./fzf \
		--reverse \
		--bind="enter:execute-silent@$RELOAD_OR_ACCEPT_CMD@"

Context menus with embedded fzf
The example below implements a very simple context menu that lets you either accept or copy the selected item.
fzf --bind 'tab:execute[echo "Accept\taccept\nCopy\texecute-silent(echo {} | pbcopy)+abort" | fzf -d"\t" --with-nth=1 | awk -F "\\t" "{ print \$2 }" > $FZF_FEEDBACK_FILE]'

This toy example betrays the main driver behind my pull-request. I would be happy if I could implement Alfred-like action menu inside FZF.

Thanks for the suggestion, but I would take a different approach.
Setting up and cleaning up the file whenever running an external command feels a bit wasteful. For example, few would want to perform extra side-effects on transform-prompt.
I would instead add a separate action just for the purpose (not sure about the name, for some reason, feedback doesn't really click with me. act(...), perform(...), execute-perform(...), execute-effect(...), transform(...), transform-state(...), ... 🤔 ) where you don't have to write to a file, but you can just echo the list of actions to the standard output, and fzf will run them on completion.
fzf --bind 'tab:transform:echo "Accept\taccept\nCopy\tbecome:pbcopy <<< {}" | fzf -d"\t" --with-nth=1 | awk -F "\\t" "{ print \$2 }"'

And thanks for pointing out the security concerns for --listen. I personally wouldn't worry too much about it, but those are valid points. We can maybe consider adding --safe-listen which forbids process execution.

Thank you for the feedback.
I wanted to add a new command at first, but I thought you might be against adding new commands to fzf. I agree that this feature has very little value for most execute-like commands, but I think I will still need to support at least a version for execute, and execute-silent (after all, I gave useful example for both), so that means adding two actions. Perhaps act and act-silent or perform and perform-silent?
Regarding the feedback file - capturing the commands to execute from stdout would work perfectly for the silent version, but not for the non-silent one. For instance, this would not work:
fzf --bind 'tab:transform:echo "Accept\taccept\nCopy\tbecome:pbcopy <<< {}" | fzf -d"\t" --with-nth=1 | awk -F "\\t" "{ print \$2 }"'

Since the second fzf launched inside the action, needs stdout to display itself. There needs to be some way to separate the command's normal output from the list of actions to execute. That can either be a named pipe, unnamed pipe (possibly passing a write fd to the child process?), a socket or a file. From all options a file seemed to be the cleanest and easiest to use option to me. Standard output is cleaner of course, but it just won't work on the non-silent case.

Regarding making listen safer, the best option in my opinion is to allow the user to set an optional API Key. If they can specify an API key using a command line argument or an environment variable and then fzf would require requests to specify the same key in the X-API-Key (or non-standared Authorization?) header, then there should be no way to exploit fzf without knowing that key.  Child processes should probably be ok to access fzf in almost every conceivable case.

To be honest, I'm not confident fzf really needs this feature because fzf is basically an interactive filter rather than an omnipotent framework for sophisticated TUI programs, while it's tempting to see it that way (sadly because of the feature bloat fzf has gone through, should we keep bloating it even more?). Maybe you're expecting too much out of it.

I would be happy if I could implement Alfred-like action menu inside FZF.

I'm not sure if you'll be happy with the result even if you manage to do it. You'll see a flickering of the screen when switching between instances of fzf. If you're on tmux, you can try using fzf-tmux like so
fzf --bind 'enter:execute-silent:seq 10 | fzf-tmux -p'

FZF_API_KEY=$(base64 < /dev/urandom) fzf --listen

I like this approach better (making the existing feature safer) than adding a yet another similar mechanism.

To be honest, I'm not confident fzf really needs this feature because fzf is basically an interactive filter rather than an omnipotent framework for sophisticated TUI programs, while it's tempting to see it that way (sadly because of the feature bloat fzf has gone through, should we keep bloating it even more?). Maybe you're expecting too much out of it.

I'm not expecting fzf to be a sophisticated framework for TUI programs, of course. I can limit this PR for to add a single action that goes through stdout (similar to execute-silient).

I'm not sure if you'll be happy with the result even if you manage to do it. You'll see a flickering of the screen when switching between instances of fzf. If you're on tmux, you can try using fzf-tmux like so.

I wasn't very happy with the result, but it worked. I had a few ideas to get around that, like reloading the context menu and then reloading the list again if necessary, but they have their own issues. I also thought about tmux, but I have been avoiding it so far, since I never managed to get used to it.

I like this approach better (making the existing feature safer) than adding a yet another similar mechanism.
This is pretty simple to do. I will send a PR.


webgui fails to start when haproxy is enabled

I managed to find a configuration setup that while resonable will render your opnsense webgui useless as it will fail to restart.
How to reproduce?

install haproxy
add a Virtual IP for your LAN (<IP_ADDRESS> in my case)
configure haproxy to use that virtual-ip (<IP_ADDRESS> in my case)
restart web gui (or wait till next day)
enjoy not having a web gui anymore and not being able to start the service at all.

Apr 15 06:00:00 q opnsense: /usr/local/etc/rc.restart_webgui: The command '/usr/local/sbin/lighttpd -f /var/etc/lighty-webConfigurator.conf' returned exit code '255', the output was '2019-04-15 06:00:00: (network.c.309) can't bind to socket: <IP_ADDRESS>:443 Address already in use'

In fact this issue could happen with any service binding on any 80/443 ports on the router, is not limited to haproxy.
If you create a Virtual IP on LAN and assign it to a service running on 80/443 you will render your web gui unable to start.
Recovery
#service haproxy stop
#service lighttpd stop
#service lighttpd onestart
Starting lighttpd.
2019-04-15 09:28:39: (network.c.166) warning: please use server.use-ipv6 only for hostnames, not without server.bind / empty address; your config will break if the kernel default for IPV6_V6ONLY changes

Now you go and disable haproxy... or reconfigure it not bind to a different interface.

By default the webgui listens on all interfaces, you can configure a static interface in System->Settings->Administration

@AdSchellevis I think this is a genuine bug: once you add a Virtual IP, the webgui will try to bind to it when services is restarted. This means that you cannot really use ports 80/443 on any LAN Virtual IPs.

It could be a feature request, not a bug. when selecting an interface, it will listen on all addresses for that interface.

Since the gist here is that you want to bind to the same port on the same IP this is not a bug. We cannot inspect if someone already uses the port and lighttpd will simply fail to start so it is what it is.

Considering that the outcome is rendering the UI broken (even locking out some poor folks that missed to configure ssh) while doing normal operations, it would count as a bug, clearly not something to be closed. Probably it should not have huge priority because few people use haproxy.
In fact this bug is not even caused by haproxy itself, is a bug in the way the lightttpd is configurable: that it binds to all ip_addresses on an interface and from the web interface it is not possible to force it to bind to a single IP, even if the product supports this: https://redmine.lighttpd.net/projects/lighttpd/wiki/Server_bindDetails
Another way to prevent suck lock-down would be if the web interface would be restarted when a virtual ip is added to its interface, assuring that no other service could start using it (so when someone tries to configure haproxy, they will realise that they cannot bind to the new IP). I do not like this approach because it only protects UI without providing a solution for those wanting to start other services using the same port.

In fact this bug is not even caused by haproxy itself, is a bug in the way the lightttpd is configurable:

This is debatable. You know my opinion and I will continue to prioritise "core" over "plugins" and consider "plugins" breaking "core" an unfortunate misconfiguration.

that it binds to all ip_addresses on an interface and from the web interface it is not possible to force it to bind to a single IP, even if the product supports this: https://redmine.lighttpd.net/projects/lighttpd/wiki/Server_bindDetails

And this is definitely untrue. :)


how can i use chainlit for react-native app?

Description of current situation
when i use @chainlit/react-client in react-native for android app.I get the The following error：

I think I've made a preliminary discovery of what caused this anomaly.
At present, I have solved the problem with the following methods.
Firstly, download the source code of @chainlit/client v0.1.2 (which in github repo tag:chainlit-1.1.306);

Secondly, put the source code into the react-native project code;

Thirdly,change the import alias etc...In order to import the source code just like my project code;

Endly,import the module and use them.

I will continue to monitor this issue and its solution, and keep active updates on ichigo-ichie😄

@dosu Could you please try and help this user along? In addition, could you suggest a more appropriate title for this issue?

@dosu Could you please try and help this user along? In addition, could you suggest a more appropriate title for this issue?

Can i attribute the a react-nagive app demo to the cookbooks repo?😃

Yes, contributing a React Native app demo to the cookbooks repository would be a great idea! It could serve as a valuable resource for others facing similar compatibility issues. Make sure to include detailed instructions and any necessary modifications to help others integrate @chainlit/react-client smoothly into their React Native projects. If you need guidance on how to structure the demo or any specific content to include, feel free to ask!
To continue talking to Dosu, mention @dosu.

Here I just contributing a React Native app demo to the cookbooks repository  -> PR Link pull/156
Please review, thank you.


doc: Remove mode="side" since it breakes the backtick

Hello,
The mode="side" breaks the backtick of the start sidenav and therefore I removed it since it is not a working example, the example here works just fine though but that's because the mode="side" is not present in that example.

Or this may actually be a bug to take care of?

@drager I don't understand the issue you're trying to fix.

@jelbourn: I thought a backdrop should always be present independently of the mode setting. But there should be no backdrop present when using mode="side"? If that is correct you can close this pull request.

It is correct that mode="side" intentionally does not have a backdrop.

I see, great. Then I had misunderstood it before.


why can i not install tensorflow library at python 3.8?

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):windows
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version:2.2
Python version:3.8
Installed using virtualenv? pip? conda?:pip
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

Describe the problem
ERROR: Could not find a version that satisfies the requirement tensorflow (from versions: none)
ERROR: No matching distribution found for tensorflow
Provide the exact sequence of commands / steps that you executed before running into the problem
pip install tensorflow==2.2
pip install tensorflow
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

@Motasem2000
What is the output of
pip list
pip --version
python -vv
python -w

In general you don't need to download the pip from storage.googleapis.com, a pip install tensorflow should be able to get it, assuming your Python is on 64 bits, your pip is up to date, you have the needed MSVC redistributable installed and that Python is installed from the Python website, not from Microsoft Marketplace (apparently, there is a bug with that).
Make sure your python was installed 64 bit.Thanks!


Enable publishing of ARM64 images to Azure

What this PR does / why we need it:
Enables publishing of ARM64 images to Azure.
Release note:

ARM64 images can now to published to Azure

@fwilhe let us take a look at this together the next days


Make more Issue template

We need issue template for Bugs, Enhancement, Documentation and more.
Anyone feel free to add your inputs also in this.

can I take this up @Rajdip019

Sure. @kaustav202

issue is resolved


Feature Request: Introduce ABAP-Cleaner Pragmas (e.g. skip certain code sections from applying rules)

We were thinking of a new option to skip the ABAP Cleaner from cleaning certain areas in our classes. Sometimes we would like to just skip a few lines - as the readability would be better when self-formatted.
e.g. when we look at this code:
    add_field_to_table( field_name = 'firstname' field_value = 'John' ).   "#AC NO_FORMATTING START
    add_field_to_table( field_name = 'lastname'  field_value = 'Doe' ).
    add_field_to_table( field_name = 'age'       field_value = 40 ).       "#AC NO_FORMATTING END

It looks good - but the ABAP Cleaner formatting rules is changing it to this format:
    add_field_to_table( field_name  = 'firstname'
                        field_value = 'John' ).
    add_field_to_table( field_name  = 'lastname'
                        field_value = 'Doe' ).
    add_field_to_table( field_name  = 'age'
                        field_value = 40 ).

The Pseudo Comment "#AC NO_FORMATTING START should prevent the ABAP Cleaner from changing the formatting in between START and END.
For sure you'll be able to find a better syntax for this ABAP-Cleaner Pragmas / Pseudo comments and also maybe other pragmas that prevent from applying other parts of the ruleset.
Thanks in advance :-)

I like the idea in general, but your specific problem can be solved via the ABAP Cleaner Configuration.
In rule "Align parameters and components" you can change the behavior "Keep other one-liners" to "always" or to "if maximum line length A is observed".

Hi Benny,
thanks for opening this, and thanks, raymx42 for pointing out this configuration for the specific example!
So far, we've tried to avoid introducing another set of pseudo-comments (there are already ##pragmas, "#EC… pseudo-comments for extended check, "#EC CI_… code inspector, …): If someone wanted to deactivate just a specific cleanup rule, we'd need a fixed name for each rule (̀"#AC NO_FORMATTING[ALIGN_PARAMETERS, REMOVE_NEEDLESS_SPACES] START), which can then never be changed again once they are out there in the code. Also, the need for class-/method-/section-/command-scope pseudo-comments might come up etc.
So, I would rather prefer to find solutions for the specific issues – either finding ways to automatically align them better, or at least to automatically determine the "keep as is" cases (and create configuration accordingly, if needed). From my experience, once you start to consider "why would I intuitively want this case to be aligned differently than that other case?", you can often find rules to determine those cases (depending on existing alignment, number of involved elements, required line length etc.)
Kind regards,
Jörg-Michael
P.S.: By the way, it has been on my wish list for a long time to enable ABAP cleaner to automatically align and even create this "tabular style" as in your example. Esp. rows in VALUE statements (often in test code) can become nicely readable with it, so I completely agree with your perception that
    add_field_to_table( field_name = 'firstname' field_value = 'John' ).
    add_field_to_table( field_name = 'lastname'  field_value = 'Doe' ).
    add_field_to_table( field_name = 'age'       field_value = 40 ).

is better readable (up to a certain line length, of course).

Hi raymx42,
Thanks for pointing that out. Works well for my example.
Hi jmgrassau Jörg-Michael,
Thanks for your detailed response and the explanations why adding pragmas is not the way to go. I agree on finding individual solutions. Also I wouldn't like to add something to the code just for the formatting.
Have a good day
Benjamin


Expose sushi version as parameter

It would be nice to have the sushi version exposed as an optional parameter. This would enable to try beta versions or fall back to an older version in the pipeline.

Done in version 0.3.5.


Some Python 3.6 builds are just not compiling

I can't tell what the causes, but it appears as through some of the builds are simply not being staged for Python 3.6. There is no record of them ever being attempted or even considered in the Travis log files, so there is no error to debug.
Most notably is OpenMM, but there is also things like nose-timer on osx.
The big one is OpenMM which is holding back a number of the other packages from being built on Python 3.6 as well. Is there possibly something going in the conda-build-all code which is iterating through the list of Python and NumPy versions and just missing a combination sometimes?

It looks like the logic for skipping some python 3.6 builds must be causing all of them to be skipped.
@marscher : Any ideas?

I think we need to temporarily disable python 3.6 builds until we can figure out what's going on.


Ability to set notification icon/color

The notification icon is currently set to the application icon inside CustomerIOPushNotificationHandler. I'd like a way to set a different notification icon as for the majority of cases, the application icon will have a shape background which will be masked on Lollipop+ devices (Display a white circle/square).
See screenshot:

Why are we doing this for our customers?
--
How do we test that this change is successful?
Send test notification when a custom notification icon has been set.
How are we building this?
Currently setting the application icon when building the notification:
https://github.com/customerio/customerio-android/blob/1.1.0-alpha.2/messagingpush/src/main/java/io/customer/messagingpush/CustomerIOPushNotificationHandler.kt#L118
FCM has some documentation that sets defaults when the icon does not exists. Unfortunately because the call to setSmallIcon these defaults do not seem to take.
<!-- Set custom default icon. This is used when no icon is set for incoming notification messages.
     See README(https://goo.gl/l4GJaQ) for more. -->
<meta-data
    android:name="com.google.firebase.messaging.default_notification_icon"
    android:resource="@drawable/ic_stat_ic_notification" />
<!-- Set color used with incoming notification messages. This is used when no color is set for the incoming
     notification message. See README(https://goo.gl/6BKBk7) for more. -->
<meta-data
    android:name="com.google.firebase.messaging.default_notification_color"
    android:resource="@color/colorAccent" />

I'm not sure if I'd prefer to set ApplicationManifest metadata to set the notification, or if a programmatic method similar to CustomerIOFirebaseMessagingService.onMessageReceived in order to achieve this.

Thank you for bringing this to our attention @atreat
We can surely look into it and add support for notification icon, you can expect this in the upcoming releases.


A mistake in the file name

> 1. In Solution Explorer, open the EmployeeAdder.cs file.
Should be EmployeeAdder**.aspx**.cs

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2b2f2c15-847c-4041-676d-ce5693354660
Version Independent ID: 7a845c03-a74a-4cfe-7347-3984fb795856
Content: Add SharePoint write operations to the provider-hosted add-in
Content Source: docs/sp-add-ins/add-sharepoint-write-operations-to-the-provider-hosted-add-in.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Good catch...

Unfortunately, nothing changed. The mistake is still here.

Patience :) Once the updates have been made to the master branch, they are queued up to be pushed to the production site, as indicated by the live branch. It can take a day or few for this to happen... as of right now, there are over 20 changes in master that haven't been published to live... this will likely happen in the next few days.
Issues are automatically closed/flagged as merged when the related PR is merged.


[SPARK-31153][BUILD] Cleanup several failures in lint-python

What changes were proposed in this pull request?
This PR cleans up several failures -- most of them silent -- in dev/lint-python. I don't understand how we haven't been bitten by these yet. Perhaps we've been lucky?
Fixes include:

Fix how we compare versions. All the version checks currently in master silently fail with:
  File "<string>", line 2
    print(LooseVersion("""2.3.1""") >= LooseVersion("""2.4.0"""))
    ^
IndentationError: unexpected indent

Another problem is that distutils.version is undocumented and unsupported.

Fix some basic bugs. e.g. We have an incorrect reference to $PYDOCSTYLEBUILD, which doesn't exist, which was causing the doc style test to silently fail with:
./dev/lint-python: line 193: --version: command not found

Stop suppressing error output! It's hiding problems and serves no purpose here.

Why are the changes needed?
lint-python is part of our CI build and is currently doing any combination of the following: silently failing; incorrectly skipping tests; incorrectly downloading libraries when a suitable library is already available.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Lots of manual testing with set -x enabled.

Test build #119787 has started for PR 27910 at commit 51488cf.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24517/
Test PASSed.

Test build #119787 has finished for PR 27910 at commit 51488cf.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119787/
Test FAILed.

Test build #119792 has started for PR 27910 at commit 02184d3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24522/
Test PASSed.

Test build #119793 has started for PR 27910 at commit 5ad9396.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24523/
Test PASSed.

Both Jenkins and GitHub are reporting:
The pydocstyle command was not found. Skipping pydocstyle checks for now.

So we are not running doc style tests anywhere...
I will address this in a separate PR.

Test build #119793 has finished for PR 27910 at commit 5ad9396.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119793/
Test FAILed.

Test build #119792 has finished for PR 27910 at commit 02184d3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119792/
Test PASSed.

I think it's OK if it fixes the linter, and doesn't uncover old failures that would currently fail.

Jenkins, retest this please.

Test build #119801 has started for PR 27910 at commit 5ad9396.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24531/
Test PASSed.

Test build #119801 has finished for PR 27910 at commit 5ad9396.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119801/
Test PASSed.

It has a bunch of mistakes we should avoid in general ...

Merged to master and branch-3.0.

@nchammas, it has conflicts with branch-3.0. Do you mind if I ask to make a backporting PR? We should port it back to branch-3.0 as https://github.com/apache/spark/commit/42c48387c047d96154bcfeb95fcb816a43e60d7c laded to to branch-3.0 too.

late "lgtm" from me.  catching up now that i'm locked in my house for the
foreseeable future.  :)
On Sat, Mar 14, 2020 at 9:11 PM Hyukjin Kwon<EMAIL_ADDRESS>wrote:

@nchammas https://github.com/nchammas, it has conflicts with
branch-3.0. Do you mind if I ask to make a backporting PR? We should port
it back to branch-3.0 as 42c4838
https://github.com/apache/spark/commit/42c48387c047d96154bcfeb95fcb816a43e60d7c
laded to to branch-3.0 too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/27910#issuecomment-599165500, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMIHLEGY7DHF5HINOUFXMTRHRIOZANCNFSM4LINRG5Q
.


new function

Can this plugin return the imageURl or base64 data for the screenshot image?

This plugin can only listen for screenshot events. iOS does not expose a way to fetch what was screenshotted, however, you could listen for a screenshot and use something like cordova-screenshot to get what's on the screen at the time.
Closing for now as it's outside of the scope of this (tiny) plugin.


Invariant Violation: loadable: SSR requires @loadable/babel-plugin, please install it

💬 Invariant Violation: loadable: SSR requires @loadable/babel-plugin, please install it
Hi Loadable Components Team,
I have a react project which is ejected from a create-react-app. Now I want to add dynamic import to this project. After following the server side rendering doc in loadable-components, I start the server, and it gives the error
Invariant Violation: loadable: SSR requires `@loadable/babel-plugin`, please install it

I am sure that I have this plugin installed and put in .babelrc. And I did not use typescript in my project.
codebase
please check my dev branch
and the PR for my changes
reproduce steps:

please clone and check to the dev branch
npm install
npm run express
visit http://localhost:3000

Duplicate of #466


[BUGFIX] Ensure ol/ul buttons have correct active state

See https://github.com/bustlelabs/mobiledoc-kit/pull/359.
Changes the activeSectionTagNames map to use the parent tag name
for nested sections, so that it has isUl and isOl instead of isLi.
Fixes #22.

released in v0.4.1


How to draw the picture of Fig(b) and Fig(c) in your ECCV2022 paper?

How to draw the DCT-based spectral maps of Fig 1(b) and Amplitude-Frequency curves of Fig(c) in your ECCV2022 paper?
Thank you very much!

After obtaining the HR images by your model, you can transmit the images into the DCT domain by cv2.dct.
Then, you will get the spectral maps and you can visualize them and draw the figures.


Correctly indent ternary statements in JSX

Current auto-indentation
trainerProfile.backgroundImageLink
  ? <Image style={styles.video} source={{uri: `${AppConfig.apiURL}${trainerProfile.backgroundImageLink}`}} />
: <Image style={styles.video} source={{uri: `https://placehold.it/375x140`}} />

desired auto-indentation
trainerProfile.backgroundImageLink
  ? <Image style={styles.video} source={{uri: `${AppConfig.apiURL}${trainerProfile.backgroundImageLink}`}} />
  : <Image style={styles.video} source={{uri: `https://placehold.it/375x140`}} />

Just tried it and It seems to auto-indent correctly for me,  i.e. as in your 'desired' indentation.
Can you let me have any surrounding JSX code as well?

closing issue. post some more more info if you want to reopen.

Hello! I have a similar issue with ternary statements.

@irrvrsl thanks for that. I will do something to fix auto indentation of ternaries as it seems to be a contentious area. I've been looking at the issues raised on the prettier repo and everyone has a different idea. Anyway leave it with me.

Thanks for a quick response! Let me know if you need my configuration or any other information related to this question.

@peterjacobson @irrvrsl I hope the latest release fixes your issues.


Lots of 'something went wrong...remote refs' errors

Lots of errors appearing with certain addons.
Environment:

Windows 10
AddOnsUpdateTool version 1.3.0

To Reproduce
Steps to reproduce the behavior:
Press exe
Screenshots or Powershell/CMD log
DEBUG    | Path to config file is not specified, will be used from the current directory
INFO     | Vault loaded: github
INFO     | Repositories in Vault cache: 19
ERROR    | Something went wrong while checking bkader/HalionHelper-WoTLK remote refs
ERROR    | Something went wrong while checking bkader/GarbageProtector remote refs
ERROR    | Something went wrong while checking ElvUI-WotLK/ElvUI_DTBars2 remote refs
ERROR    | Something went wrong while checking ElvUI-WotLK/ElvUI_SwingBar remote refs
ERROR    | Something went wrong while checking bkader/ButtonFacade remote refs
ERROR    | Something went wrong while checking ElvUI-WotLK/ElvUI remote refs
ERROR    | Something went wrong while checking ElvUI-WotLK/ElvUI_EnhancedFriendsList remote refs
ERROR    | Something went wrong while checking bkader/FixGroups-WoTLK remote refs
ERROR    | Something went wrong while checking ElvUI-WotLK/ElvUI_VisualProcs remote refs
ERROR    | Something went wrong while checking Bunny67/Details-WotLK remote refs
ERROR    | Something went wrong while checking bkader/Dominos remote refs
ERROR    | Something went wrong while checking ElvUI-WotLK/ElvUI_CustomTags remote refs
ERROR    | Something went wrong while checking bkader/Masque-WoTLK remote refs
ERROR    | Something went wrong while checking bkader/PlateBuffs_WoTLK remote refs
ERROR    | Something went wrong while checking bkader/SharedMedia remote refs
ERROR    | Something went wrong while checking Bunny67/WeakAuras-WotLK remote refs
ERROR    | Something went wrong while checking bkader/TidyPlates_WoTLK remote refs
ERROR    | Something went wrong while checking Zidras/DBM-Warmane remote refs
ERROR    | Something went wrong while checking Zidras/ElvUI_ProjectZidras remote refs
ERROR    | Something went wrong while checking RomanSpector/LossOfControl remote refs
ERROR    | Something went wrong while checking RomanSpector/CompactRaidFrame remote refs
ERROR    | Something went wrong while checking RomanSpector/UnitFrameLayers remote refs
ERROR    | Something went wrong while checking Zidras/ElvUI_ImprovedSpecSwitch remote refs
DEBUG    | Updated: ElvUI-WotLK/ElvUI_ExtraActionBars@master
DEBUG    | Updated: bkader/NameplateSCT_WoTLK@main
DEBUG    | Downloaded: ElvUI-WotLK/ElvUI_CustomTweaks@master
DEBUG    | Updated: bkader/BigWigs-WoTLK@main
DEBUG    | Updated: bkader/Skada-WoTLK@main
DEBUG    | Downloaded: ElvUI-WotLK/ElvUI_AddOnSkins@master
DEBUG    | Downloaded: ElvUI-WotLK/ElvUI_Enhanced@master
INFO     | Vault updated: github
INFO     | Repositories in Vault: 22
INFO     | Game folder initialized
INFO     | ElvUI_AddOnSkins will be installed
INFO     | ElvUI_Enhanced will be installed
DEBUG    | ElvUI_AddOnSkins backup has been saved
DEBUG    | ElvUI_Enhanced backup has been saved
INFO     | All updatable AddOns has beed saved
DEBUG    | ElvUI_AddOnSkins@b4542ba has been installed
DEBUG    | ElvUI_Enhanced@245e896 has been installed
INFO     | All AddOns up to date
WARNING  | Bye-bye! Will close in 5 seconds

Fixed!


Geocoder.geocode returns 'Request denied' status

navigator.geolocation.getCurrentPosition  returns success but, geocoder.geocode returns status -'Request denied'
Code:
navigator.geolocation.getCurrentPosition(onSuccess, onError);
function onSuccess(position) {
var geocoder;
geocoder = new google.maps.Geocoder();
var latlng = new google.maps.LatLng(position.coords.latitude, position.coords.longitude);
geocoder.geocode(
{ 'latLng': latlng },
function (results, status) {
if (status == google.maps.GeocoderStatus.OK) {
//mycode
}

What platform? What version? What device?

both android and iOS

Realised this is old now but this plugin has nothing to do with geocoders so I don't think this is the best place to ask this kind of question. For this reason I'm closing this issue.


Make code typesafe by using generics

Thanks! :-)

Would it be possible to allow issues on this fork as I don't have the admin priveges to do such a thing?

Done, thanks for noticing!


Add Weak Heap implementation

https://en.wikipedia.org/wiki/Weak_heap

Hi @theodesp, I'll make a PR for this issue.


Set svelte:compiler as weak dependency and validate svelte npm dependency

Set svelte:compiler as weak dependency and validate svelte npm dependency existence.
Solves issue #14 and makes it possible to use this package with the latest svelte compiler.
Meteor 2.6.1 and on introduces an update on Babel set of dependencies, which makes the current svelte version imported by this package break with a missing "sourcemap" field error.
As this package is included in our skeleton, it's important that it works always with the latest version of svelt, so I think it's also a good addition.
Thanks for your great work here!

Thanks for this change.
I see you are requiring Meteor 2.6 now.  This is breaking one of my projects which hasn't yet updated to 2.6.  Is this part strictly necessary?
What's the reason for changing some of the imports to use require()?

@rdb yes! 2.6 is not needed in the package, sorry.
The change was to avoid hoisting the 'imports' at the top level, but as the index.js is always included in the server this change is not needed. (and I'm also only checking for the npm dependency in there, it would be needed if the check was everywhere)
I've updated the pr, thanks!

I've updated the pr, thanks!

Did you forget something?  I don't see the changes.

I've updated the pr, thanks!

Did you forget something? I don't see the changes.

You are faster than me, I was pushing =D You should see them now!

hum...
actually, if you are only including svelte:compiler for the "svelte" npm package, it could be removed completely, right?
What do you think about removing it?

Taking a step back: a weak dependency says "if package x is present, it must conform to this version", right?
If so, there is probably no harm in leaving it in and forcing it to be at least 3.25 if it is present, since nothing good will happen otherwise.
Are you aware of problems that might be caused by leaving it in?

yes, that would work too!
You can use something like:

<EMAIL_ADDRESS>{weak: true});

Unless there are major versions released on svelte:compiler, this will work.