[KED-950] Turn on the branch coverage for unit tests

Description
According issue #243 branch test on coverage needed to be turned on
Development notes

branch test has been added on .coveragerc
Adding test to bump coverage back to 100% (WIP)

Checklist

[ ] Read the contributing guidelines
[X] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added a description of this change and added my name to the list of supporting contributions in the RELEASE.md file
[ ] Added tests to cover my changes

Notice

[X] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@Cheukting Thank you for working on this! Let us know if you need any help/questions on this :)

@Cheukting proud of your work! Always learning so quickly!

Hey @Cheukting 😄 We want to review your PR and merge it in for the next release. Is it ready to come out of draft mode?

Hey @yetudada sorry for leaving it open for so long. I am afraid there are too many tests (more than I can handle) that are needed to bump the new coverage to 100% Please feel free to assign it to someone else or close if you see fit.

Hey @yetudada sorry for leaving it open for so long. I am afraid there are too many tests (more than I can handle) that are needed to bump the new coverage to 100% Please feel free to assign it to someone else or close it if you see fit.

I'm happy to help but sounds like it's many hands needed to help finish the task.
@Cheukting do you mind zipping the code-coverage folder generated by coverage or pycov and share it here so I can take a quick look at it and find low-hanging fruits and the inflection points.

@neomatrix369 can you just pull my commits?

You should be able to see the coverage output here: https://circleci.com/gh/quantumblacklabs/kedro/8974

@neomatrix369 can you just pull my commits?

I have cloned your pull request now, thanks. I'll take it from here.

You should be able to see the coverage output here: https://circleci.com/gh/quantumblacklabs/kedro/8974

@mzjp2  I don't see a coverage html or xml report generated after the tests finish, this is useful for local/remote machine consumption. Happy to use the link you shared in the meanwhile.

You should be able to see the coverage output here: https://circleci.com/gh/quantumblacklabs/kedro/8974

@mzjp2 I don't see a coverage html or xml report generated after the tests finish, this is useful for local/remote machine consumption. Happy to use the link you shared in the meanwhile.

Gotcha. If you run make test yourself locally it should generate a xml report (and a .coverage file too, I think?) but you're right that on CI it just shows the CLI output (it does generate the report but we don't surface it as an artifact on our CI build).

You should be able to see the coverage output here: https://circleci.com/gh/quantumblacklabs/kedro/8974

@mzjp2 I don't see a coverage html or xml report generated after the tests finish, this is useful for local/remote machine consumption. Happy to use the link you shared in the meanwhile.

Gotcha. If you run make test yourself locally it should generate a xml report (and a .coverage file too, I think?) but you're right that on CI it just shows the CLI output (it does generate the report but we don't surface it as an artifact on our CI build).

No worries, I'll take care of it and see what I can do, I have done something similar in the past, a HTML based report is a lot more productive to work with, and we can close the PR quicker ;)

I'll go ahead and close this for now, seeing as the work has been overtaken and done in #327 -- thanks all! :)


How to restrict between two users of same role??

Make sure these boxes are checked before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if any
[ ] I have reproduced the issue with at least the latest released version of superset
[ ] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
0.20.6
Expected results
I want to use two users with same role.
But the database,tables,slice and dashboard created by one user should not be visible to other user and vice versa.
Actual results
One user can see all datas (database,tables,slices and dashboards) created by another user.
This result is due to adding this permission:
all datasource access on all_datasource_access
all database access on all_database_access
Steps to reproduce
Is this type of permission is possible in superset.
If yes, What are the permissions to be added for that role.
Thanks in advance.

If you don't want a user to see evertyhing, avoid the all_*_access permissions. Am i misisng something?

Thanks..
But how can we make one user's datas(including database,tables,slices and dashboards ) invisible to other user??

They should not be accessible to other users until you give other users permissions to do so. Have you read the permissions related documentation?

They should not be accessible to other users until you give other users permissions to do so. Have you read the permissions related documentation?

Yes...I have seen that permissions like : datasource access on [XXX].(id:2)
This permissions will be set by higher level user like admin to lower level user say, alpha.
But how to make datas hide between users of same role(like within alpha users).

Just create 2 different roles. User 1 can have "gamma" + "set of tables 1" and user 2 can have "gamma" + "set of tables 2"

Thanks...
I will try this...

I can find 'menu access on sources' and 'menu access on tables' are enabled in 'alpha' role.
But why the sources tab is not available to the alpha user.
Do we want to enable some other permission to the alpha user to get access to sources ??

Gamma should be able to see the datasources, if that's not the case it's a bug.

does anyone feel that the auth model of superset is too hard to use?
can we stop using flask_appbuilder, and choose another RBAC framework?

RBAC in FAB is fine, plus it's baked deeply in the web framework, can't change that. The missing element in the FAB model is "group".

@AnithaMurugesan +1
Did you find a solution to this?


Free Response Question No. 1

Self-Grade: 3.0

Converted imperative monkey iteration into object-orientated monkey iteration with adding and removing features
Added word counter to personal webpage showing knowledge of front-end and back-end

Work

FRQ 1: Methods and control structures
Iteration with 2d Array Notebook

Extra

Word Counter for personal webpage

2.7+

reflection upon FRQ solving
extra ASCII art
good object code
word counter!!!! WITH DELIMETERS


Disallow non-configurable globals from being redeclared

Based on the spec (1, 2), it's an early error to redeclare non-configurable globals with lexical variables at the top level of a program. This is determined by calling [[GetOwnProperty]] on the global object at parse time.
The spec mandates three non-configurable globals: undefined, Infinity, and NaN. As a result, let undefined; at the top level is always a syntax error for any compliant engine. This commit updates acorn to report these redeclarations as syntax errors.
Some environments create additional non-configurable globals (e.g. window in browsers), and the global object can also be modified at runtime, so it's not possible to statically detect all syntax errors for a script if it's parsed after other code has been run.

Some environments create additional non-configurable globals (e.g. window in browsers), and the global object can also be modified at runtime, so it's not possible to statically detect all syntax errors for a script if it's parsed after other code has been run.

That's why I'm leaning towards not checking this at all -- if we can only half-check it, doing so is more confusing that not checking it at all.
@RReverser Do you have an opinion on this?

As a result, let undefined; at the top level is always a syntax error for any compliant engine.

It is, but, for example, var undefined = 1 is not in sloppy mode and var undefined is not in either mode. I'm not sure how this patch would handle such cases, but I'd also don't see value in going down that path, only added complexity.

I think this patch handles var undefined = 1, var undefined and let undefined correctly (erroring for the last one but not the first two). I might be mistaken, but I don't think strict mode makes a difference in this case.
Since we already track declared variables by scope to address https://github.com/ternjs/acorn/issues/487, this is a relatively simple patch (it just initializes the top-level scope with three variables that are already declared). My point of view is that it's worth merging this because it's a simple fix and it catches three patterns that are always syntax errors (even though it can't catch all related syntax errors). However, I understand your point about simplicity/consistency.

I might be mistaken, but I don't think strict mode makes a difference in this case.

That's what I said above - var undefined = 1 is not an error in sloppy mode, but it is in strict mode.

Unlike let undefined, var undefined = 1 in strict mode is a runtime error, not a static error, so Acorn wouldn't be concerned with it anyway.

at the top level is always a syntax error for any compliant engine

For what it's worth, V8 also appears to throw a "syntax" error only when running code and not parsing.
This is how parsing time errors show up:
> script = vm.createScript('#blabla')
evalmachine.<anonymous>:1
#blabla
^
SyntaxError: Invalid or unexpected token

As opposed to this:
> script = vm.createScript('let NaN')
ContextifyScript {}
> script.runInNewContext()
SyntaxError: Identifier 'NaN' has already been declared
    at evalmachine.<anonymous>:1:1
    at ContextifyScript.Script.runInContext (vm.js:32:29)
    at ContextifyScript.Script.runInNewContext (vm.js:38:15)
    at repl:1:8
    at ContextifyScript.Script.runInThisContext (vm.js:23:33)
    at REPLServer.defaultEval (repl.js:339:29)
    at bound (domain.js:280:14)
    at REPLServer.runBound [as eval] (domain.js:293:12)
    at REPLServer.onLine (repl.js:536:10)
    at emitOne (events.js:101:20)

Can you provide a link where you saw this being defined as an early error? (1, 2) from your issue description don't seem to show that - (2) refers to runtime semantics and (1) is just a function that these runtime semantics use.

Oh, it looks like I was wrong -- it is considered a "runtime error" rather than an "early error" by the spec.
This might mean that Acorn shouldn't raise an error for it -- if so, feel free to close this PR. However, it's worth noting that the runtime error occurs when the execution context is created, not when the offending statement is executed. For example, the following program will not print anything:
print('foo');
let undefined;

When executing code, I'm not sure there is any observable difference between treating this as a runtime error rather than a parsing error.

Sure, I'm just saying that, since this is part of runtime semantics, it relies on runtime behaviour of specific engines (namely extra non-configurable globals which we mentioned above), and having a solution that chooses to only partially simulate the runtime spec feels kinda wrong.
@marijnh what do you think given these new details?

I agree, we shouldn't be checking this, since it's runtime behavior and depends on implementation specifics we can't know.


Support for image cropping

Crop a rectangle from the original image before resizing it to the desired max width/height. Useful for purposes such as providing a user interface to allow users to select a square from an image to use for a profile photo thumbnail.

I will merge this into the v0.x branch and release v0.9.0. v1.0 takes another approach to resize / cropping and no longer uses the gm package. See #24.


fix: logging interface are never exported

Description
This PR started with being a simple doc PR, but apparently, the logging interface is never exposed and unusable...
This PR fixes this by exporting the type and adapting tests to use the exposed type to make sure it stays like that.
Related issue(s)
Fixes #189

Coverage remained the same at 94.561% when pulling 8013985deacee9cce5b7a6c0101280b35f72abc1 on jonaslagoni:feature/add_logging_documentation into f47276c22db4c9e987a2f8e77b9ecdcee74aff54 on asyncapi:master.

Thanks 👍


Removed double fetching of projects from Supabase

after testing this i think that i am not getting consistent results as i am with previous code - will close this PR for now since I was the one that asked for this change


Undo/Redo

Not sure how large a request this is but I think a good enhancement for this app would be an undo (and optionally redo) button.
The use case for me is if I have accidentally deleted something that I didn't mean to it is very useful to have an undo button so that text is not lost.

added in new version, coming soon.


Avoid loading files that we know are binary ahead of time

Avoids jest-haste-map reading formats we know they are binary, even when requested to do so via extensions. This fixes a bug in Metro, where, in order to process assets, we need to pass Haste the corresponding extensions, but causes an OOM when opening a ~600 Mb video.

Codecov Report

Merging #5612 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5612      +/-   ##
==========================================
+ Coverage   60.63%   60.64%   +<.01%
==========================================
  Files         213      214       +1
  Lines        7311     7315       +4
  Branches        3        3
==========================================
+ Hits         4433     4436       +3
- Misses       2877     2878       +1
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-cli/src/search_source.js
45.07% <ø> (ø)
:arrow_up:

packages/jest-haste-map/src/blacklist.js
100% <100%> (ø)

packages/jest-haste-map/src/worker.js
96% <100%> (ø)
:arrow_up:

packages/jest-config/src/normalize.js
93.4% <0%> (ø)
:arrow_up:

.../src/legacy_code_todo_rewrite/jest_adapter_init.js
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5879c0...414e63a. Read the comment docs.


Update South Korea holidays, add l10n support

Proposed change

Add South Korea holidays (en_US, kr, th localization).
Implement Election Date Calculation (as per Article 34 of the Public Official Election Act ).
Inclusion of all Temporary Public Holidays from 1948-2023 as part of the StaticHolidays class.
Revise holiday logic work from the 1st-18th amendment of the Public Holidays Act.

Type of change

[ ] New country/market holidays support (thank you!)
[x] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've added references to all holidays information sources used in this PR
[x] The code style looks good: make pre-commit command generates no changes
[x] All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

This PR is marked as a draft to wait for #1535 's eventual merge (mostly so that we can include the historic, short observances in 1959-1960, 1989 done (as seen here; Point 4.2.1  Before the 2010s ).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

70 of 70 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.978%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
10116

Relevant Lines:
10116

💛  - Coveralls

Turns out #1535's new special_holidays_observed requires the usage of ObservedHolidayBase
We may as well go and revamp the existing codes for _add_alt_holiday( ) and _add_three_day_holiday( ) at this rate, as the change to the new observed class requires at least one observed_rule.

I'm trying to migrate South Korea to ObservedHolidays, but I'm not satisfied with the result yet. Their rules are quite complex and unique.


add pens module containing Cu2QuPen, Cu2QuPointPen, etc.

I will add docstrings and tests tomorrow, but this is a start.
The Cu2QuPen follows the fonttools (segment) pen protocol, whereas the Cu2QuPointPen follows the robofab point pen protocol. They both take another segment or point pen in the constructor, and call that with the result of the cubic-to-quadratic conversion.
I believe it's useful to have a reverse_direction argument to invert the contours' winding direction. Now, the ReverseContourPointPen from the robofab.pens does the job. However, I didn't want to add a dependency on robofab, since things are in transition, so I simply copied it here...
We can add it to the future "penBox" package (or whatever it'll be called) once that is set up, no?
Please excuse the mixing of underscores and camelCase: cu2qu uses the former, the pens traditionally use the latter. I tried to to be consistent as much as possible.
Let me know if you have any comments.
Thanks

PS: All pens work on a single-glyph basis. I still haven't figured out how to properly handle collections of glyphs as in cu2qu.rf to maintain the interpolation compatibility. I was thinking of a PenCollection but it didn't work very well. Ideally the GlyphCollection should have a getPen, draw and drawPoints methods like regular glyph objects do. But it's complicated.

r? @behdad @jamesgk

please do not merge this just yet as I'm still working on the tests. Thanks

Sorry I got sidetracked with other stuff. I've finally the promised unit tests for the Cu2Qu pens. I'll send another PR for setting up the continuous integration.
In the next days I'll look into ways of integrating the pen protocol with the GlyphCollection class (i.e. to keep interpolation compatibility across multiple fonts).
Please let me know if you have any comments. Thanks

Ah, about the *.glif test files that are in the test/data/cubic folder: I could have made these up but I wished to use some "real" glyphs. So I took them from existing open source fonts:

"a.glif" is from Roboto_Regular.ufo;
"A_.glif" and the "E" contour in "E_acute.glif" are from Pablo Impallari's Lobster; I converted them from the vfb using vfb2ufo and normalized the indentation.

The corresponding *.glif files in test/data/quadratic -- i.e. the expected results -- were converted using the current cu2qu.rf.font_to_quadratic.

I feel like collection classes are less useful with this pen approach. It might be easier to do the error checking outside of _init_ or the pen, instead in some new fonts_to_quadratic which uses pens to draw quadratic curves with a fixed # of points and then checks errors and bumps up # points itself. Though this may be slower and seems to require that the pen take in an optional fixed num points argument.

Never mind, of course that won't work because you have different # points for different segments in a single glyph. Hmm.

OK, one idea for using collections with pens. It's kind of messy and involves many passes over a glyph (i.e. "drawing" the glyph many times).

Draw the glyph once to get a count "n" of the cubic curves. Save an array of n 1s representing the necessary control points for each approximation. Assert n is equal for every glyph in the collection.
Draw each glyph in the collection, approximating each i'th cubic with # control points determined by the value in our array at i, and keeping track of each error. If any glyph's error is beyond the bound for an i'th cubic, increment our array at i and try again. Repeat until no error is beyond the bound.

This still doesn't really require any collection objects. You can just do it by zipping the UFOs and extracting lists of glyphs.

I think this PR can be merged, as it's already useful as is: if, say, one wants to use cu2qu in environments with different glyph APIs than defcon or robofab.objectsRF, and does not need to keep interpolatibility.
I would still like to add support in the top-level cu2qu.__init__ for converting groups of "glyphs" compatibly; not just "UFO" glyphs, but any objects having either a drawPoints and/or draw methods (e.g. fonttools, robofab.objectsFL, etc.); such general glyphs_to_quadratic function should not make assumptions about implementation details like glyph.clearContours(), etc., which are not available in all environments; and should not modify the input glyph objects in-place, but only returns new glyph-like objects exposing draw/drawPoints methods which the caller can then use to extract the quadratic segments and draw them on their canvas.
I see that in PR #23, James added a file called "Lib/cu2qu/test.py". This conflicts with the "Lib/cu2qu/test/init.py" module in this PR.
I'd suggest we merge this one first in master, and then modify #23 so that the content of "test.py" goes into "test/init.py"?

I would still like to add support in the top-level cu2qu.init for converting groups of "glyphs" compatibly; not just "UFO" glyphs, but any objects having either a drawPoints and/or draw methods (e.g. fonttools, robofab.objectsFL, etc.); such general glyphs_to_quadratic function should not make assumptions about implementation details like glyph.clearContours(), etc., which are not available in all environments; and should not modify the input glyph objects in-place, but only return new glyph-like objects exposing draw/drawPoints methods which the caller can then use to extract the quadratic segments and draw them on their canvas.

Interesting. I definitely want to reduce duplicate functionality throughout cu2qu, but maybe the ufo module can be adjusted to use a model like this.

Thanks James!
About https://github.com/googlei18n/ufo2ft/issues/35, now that #20 is merged and we have a ReverseContourPointPen at disposal, I think cu2qu.font[s]_to_quadratic could expose a reverse_direction=False or similar option, and just flip the path orientation if True (provided a UFO editor has already correctly set the PS contour direction)?

maybe the ufo module can be adjusted to use a model like this.

definitely. I just need to find the time to finish it. Unless you fix it first ;)

@anthrotype Let's also review this together in Berlin.  I haven't had time to do that.


update-locatedb: fix update-locatedb service for mlocate

The locate service does not properly handle flags during update of the
relevant database when configured to use the mlocate package.
The manual entry for updatedb associated with mlocate does not say
that it supports environment variables in place of command line flags,
whereas the findutils package's updatedb does so.
Fixes #29279
Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Thank you @matthewbauer!


Regent-Fortran interop

For Regent to work with Fortran tasks, Regent needs to understand the Fortran dope vector.

Just an additional note -- I think dope vector implementations are still very compiler dependent so this may require several versions to support the gamut...

@pmccormick Is that documented or are we on our own in terms of reverse engineering what the compilers do?
Is there a specific app that needs this?

At one point there was some documentation per compiler (of varying quality) but it has been a long time since I've gone looking for it -- I'd have to dig it up again.  There are no specific apps on the critical path that I'm currently aware of that need this.  @alexaiken, was there a particular use case you were thinking of specifically for this?

This item is a carryover from the planning document we were maintaining
separately.  I don't remember the use case that caused this item to be put
on that list of things to do.
On Tue, Oct 8, 2019 at 11:30 AM Pat McCormick<EMAIL_ADDRESS>wrote:

At one point there was some documentation per compiler (of varying
quality) but it has been a long time since I've gone looking for it -- I'd
have to dig it up again. There are no specific apps on the critical path
that I'm currently aware of that need this. @alexaiken
https://github.com/alexaiken, was there a particular use case you were
thinking of specifically for this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/StanfordLegion/legion/issues/640?email_source=notifications&email_token=ABBIV7ZHBNA3FPUC2JIEEWDQNTGUDA5CNFSM4I6K3CFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAVE45Q#issuecomment-539643510,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABBIV7YDI365OMPTW5HVFADQNTGUDANCNFSM4I6K3CFA
.

We've actually been using interop between Regent and Fortran for MPAS, so I guess this works well enough? @alexaiken what do you think?


fix: listv2 moved pagesize from meta to widget props and refactor

Description
Fixes

the page size being 0 for queries when server side rendering is enabled.
Auto adjustment of page no when moved from server to client side and the current page is > max page.
Refactors

Fixes #16586
Fixes #18206
Media
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

Note to QA: Verify all the cases for pageSize as this PR aims to fix any remaining issues related to it

Tested and verified for:

Issues with evaluation of pageSize on reload
pageSize being 0 for queries when server side rendering is enabled
pageSize computation scenarios for list v2 with DB queries


haruna: 0.7.3 -> 0.8.0

Description of changes
https://apps.kde.org/haruna/

Changelog: 0.8.0 2022-04-20

Features:
Support for global menu
Setting to pause playback when minimized
Setting to set the "time-position" saving interval
Recent files menu inside the file menu
More actions to the menubar
Action to load last played file (Ctrl+Shift+L), usefull when loading last played file on startup is disabled
Action to restart playback/seek to beginning (F5 key)
Action to seek to watch later position (Ctrl+Shift+P), usefull when resume playback on startup is disabled
Bugfixes:
There were two "remember time position" settings, doing different things, renamed the startup one to "resume playback"
Fixed a case where the playlist could not be closed with mouse hover anymore
OSD: When file can't be played show filename if there's no title
Stuttering caused by slow disks
Playlist items collapsing into each other

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This fixes #169970, but it should do more stuff like changing homepage, moving some dependencies to nativeBuildInputs or (optionally) changing from youtube-dl to yt-dlp.
I was going to do a PR before I saw yours, here's my commit (I may have done something wrong there): https://github.com/SuperSamus/nixpkgs/commit/719c2e2a88173a240b5afb49a789f6253eea092f
Problem is, Haruna doesn't open with that (see the issue), and I don't know why, maybe it's something on my end?
By the way, does upgrading Haruna do anything about #170026?

@SuperSamus I don't have any problem when using, though it has error message when open form terminal:
unknown() : qrc:/qml/main.qml:148:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }

unknown() : qrc:/qml/HProgressBar.qml:209:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }

unknown() : qrc:/qml/MpvVideo.qml:312:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }

unknown() : qrc:/qml/Menus/AudioMenu.qml:34:9: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }

unknown() : qrc:/qml/Menus/AudioMenu.qml:34:9: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }

Cannot load libcuda.so.1
unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : qrc:/qml/HProgressBar.qml:177:9: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/izy6p14ja697kf9r9himsjr80bk2wsmm-qqc2-desktop-style-5.93.0-bin/lib/qt-5.15.3/qml/QtQuick/Controls.2/org.kde.desktop/Menu.qml:32:15: QML MenuItem: Binding loop detected for property "implicitWidth"

unknown() : file:///nix/store/xla2811i11mf0k21cci65x7vch1cw0qm-kirigami2-5.93.0/lib/qt-5.15.3/qml/org/kde/kirigami.2/AbstractApplicationWindow.qml:270:5: QML Binding: Not restoring previous value because restoreMode has not been set.
This behavior is deprecated.
You have to import QtQml 2.15 after any QtQuick imports and set
the restoreMode of the binding to fix this warning.
In Qt < 6.0 the default is Binding.RestoreBinding.
In Qt >= 6.0 the default is Binding.RestoreBindingOrValue.

unknown() : file:///nix/store/xla2811i11mf0k21cci65x7vch1cw0qm-kirigami2-5.93.0/lib/qt-5.15.3/qml/org/kde/kirigami.2/AbstractApplicationWindow.qml:276:5: QML Binding: Not restoring previous value because restoreMode has not been set.
This behavior is deprecated.
You have to import QtQml 2.15 after any QtQuick imports and set
the restoreMode of the binding to fix this warning.
In Qt < 6.0 the default is Binding.RestoreBinding.
In Qt >= 6.0 the default is Binding.RestoreBindingOrValue.

[1]    60155 segmentation fault (core dumped)  haruna

Also i tested your commit, it works well.
Seems it still has many things to do, but i am not good at QT packaging, so close this PR.

I think these error messages are because of Haruna itself, not the packaging.


The dialog box is not displaying properly on Windows 10

版本	Windows 10 专业版
版本号	22H2
安装日期	2023/8/1
操作系统内部版本	19045.3570
体验	Windows Feature Experience Pack 1000.19052.1000.0

It seems normal now.

That's great, a nice dialog box


feature request: built-in printer for command-only?

The defualt printer prints command and stdout/stderr: "By default, when a command is run, the command and the output are printed to stdout using the :pretty printer."
:quiet will "only output actual command stdout and stderr", without the command.
:null and :progress will both print neither.
There is one thing missing from this matrix! I often want only the command printed out, without the stdout/stderr.
I could write my own custom printer, but is this common enough to justify including as a default? printer: :command maybe?
Or I might actually want the Running.. and Finished... lines, the Finished line too, just NOT the stdout/stderr!  (Or actually, more advanced... I want to somehow capture stdout/stderr to ruby strings, but print out Running/Finished.... that is a more complicated usecase I'm not sure about how to do)

Hi Jonathan,
What you suggest sounds reasonable. A printer that shows the command and the exit status only seems to complement the :quiet. I'm not sure how common a request it is though. It feels as though the stdout/stderr should be made available somehow in the case when the command fails. There is :only_output_on_error which seems more like what you need? It doesn't show any output unless the command fails.

In my case, the problem is certain commands that produce too much output, so I woudn't want to see it even on failure, it's just too much.
But that is starting to sound like more of a special edge case maybe. And I realized it might make more sense and work fine for me to just explicitly 2>1 >/dev/null  my command, and use the pretty printer still.
So I'll just close this! Thanks for the response!


chirp: 20220823 -> unstable-2022-12-07

Description of changes
Similar with #204489, but switching to the Python 3 branch instead.
#201859
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 205093 run on x86_64-linux 1

1 package built:

chirp


Difference between local shap values coming from global and from the "shap_values"-method

Hi,
I have a tree explanation object containing ".data", ".values" and ".base_values". If I extract the shapley values from this object for a single data row ("local" value), I get the shapley values for the 32 features of my single data row.
Now, if I run the method "shap_values" on the explainer object and pass to it the feature data for that particular row, I also get the shapley values for the same row as above.
In my understanding, the shapley values extracted from the explanation object and the shapley values from the "shap_values"-method run on the explainer object should be the same.
But they are not. Very often (not always), there is a difference for only ONE feature shapley value. In my case, the shapley values for 31 features are exactly the same (for the two approaches), but most often there is a difference in ONE feature shapley value. I tried this on different data sets ... .
Why is that? And is this a bug?

I was not able to reproduce that error in my environment. Can you please tell me the code to reproduce it?
My code and output is as follows.
from sklearn.model_selection import train_test_split
import xgboost as xgb
import shap
import numpy as np

X, y = shap.datasets.adult()
train_x, valid_x, train_y, valid_y = train_test_split(X, y, test_size=0.25, random_state=7)
dtrain = xgb.DMatrix(train_x, label=train_y)
dvalid = xgb.DMatrix(valid_x, label=valid_y)

params = {
    "objective": "binary:logistic",
    "eval_metric": "auc",
    "eta": 0.7
}
model = xgb.train(params, dtrain, evals = [(dvalid, "valid")])

explainer = shap.TreeExplainer(model)
shap_values = explainer(X)
shap_values2 = explainer.shap_values(X)
np.allclose(shap_values.values, shap_values2)

outputs True

Having the same issue, the values are just different... Could it be that the two methods handle categorical dtype differently?

You guys should index based on the second axis to get the Shap's for each feature alone:
shap_values.values[:,feature_index]
where feature_index is the index in the train set of the feature in the column.


ClangImporter: Targeted fix for rdar://problem/29081276

@swift-ci Please smoke test and merge

@swift-ci Please smoke test and merge

The timeout is a bug (we need to skip the new logic on Linux)

@swift-ci Please smoke test and merge

@swift-ci Please smoke test and merge


HELM-415: Docs direct user to create a Custom Action when creating a …

…Dashboard but this feature no longer exists in Grafana v9
Updated Grafana Plugin docs to remove references to "custom actions". Also updated some procedures based on Grafana UI.
Pull Request Check Sheet

[ ] Have you read and followed our Contribution Guidelines?
[ ] Have you made an issue in the OpenNMS issue tracker?If so, you should:

update the title of this PR to be of the format: ${JIRA-ISSUE-NUMBER}: subject of pull request
update the JIRA link at the bottom of this comment to refer to the real issue number
prefix your commit messages with the issue number, if possible

[ ] Have you made a comment in that issue which points back to this PR?
[ ] Have you updated the JIRA link at the bottom of this comment to link to your issue?
[ ] If this is a new feature, is there documentation?
[ ] If this is a new feature or substantial change, are there tests that cover it?

Pull Request Process
One or more reviewers should be assigned to each PR.
If you know that a particular person is subject matter expert in the area your PR affects, feel free to assign one or more reviewers when you create this PR, otherwise reviewers will be assigned for you.
Once the reviewer(s) accept the PR and the branch passes continuous integration in Bamboo, the PR is eligible for merge.
At that time, if you have commit access (are an OpenNMS Group employee or a member of the Order of the Green Polo) you are welcome to merge the PR.
Otherwise, a reviewer can merge it for you.
Thanks for taking time to contribute!
External References

JIRA (Issue Tracker): http://issues.opennms.org/browse/HELM-415
Continuous Integration: CircleCI

Please advise if the updates to the procedures are not valid. I was working of Grafana in the Cloud. I did not update all of the docs, just the procedures in the chapter that had the custom actions section.

Just noticed the Jira ticket has instructions for using this type of functionality. Will update this content and create another PR.


Add git to Docker image

Use a node image that includes git for fetching npm dependencies. This is needed when our dependencies use "github:..." instead of a version number in package.json.
Fixes #89.

@thorsteinsson just installing git instead of pulling the non-slim image didn't work?

I've changed it to installing git on the slim image.


Re: Code is not pushing

Please review previous closed issues before filling out a new one! Duplicate issues will be closed without comment.
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

My gfg solution is also not syncing to github

Same here. my code is not pushing to github as it previously did. README's are pushing just fine, but no .py files


Is anyone working to catch illegal STR rentals aka AirBnbs?

It seems really easy to compare the permit GIS data to advertised addresses on services like AirBnb.
The benefit to our community would be more fair rental prices and fewer disrespectful parties. I know SF has a nonprofit really working to reign them in for many civic reasons.
http://www.sharebetter.org/what-you-can-do/
How could we begin?
https://www.austintexas.gov/str

Hi Nicholas, Maybe reach out to city government to identify a "client" to help spearhead the project. See mentions of AirBNB on City of Sacramento site at https://www.google.com/search?q=vacation+rental+licensing+site%3Acityofranchocordova.org&ie=utf-8&oe=utf-8#safe=off&q=airbnb+site:www.cityofsacramento.org (maybe Jeff Harris or Jay Schenirer?)
I will ask my city if this is on their radar (not that Rancho Cordova is a premier vacation destination)


How would I call a texture (or any asset in that matter) without it being manually selected?

Hello again,
I'm creating a script that imports big amount of textures (around 300), and each texture has the material name it should go to, and the slot it should go to. for example :

231490213_Diffuse.TGA
-- 231490213 Is the material it's targeted to
-- Diffuse - Material slot.

While I know how to send a texture to it's right material & node, I don't know how to call each texture asset from UE. I have all textures in same folder, imported and set up, under '/Game/Textures/'
I would like to make a loop that takes texture(asset) name and attach it to a variable that I can later use to send to the material, over and over, till there's no textures left to "send".
thanks for the help 👍

https://github.com/20tab/UnrealEnginePython/blob/master/docs/ManagingAssets.md


Missing NullMarker in UploadCsvOptions - Big Query API

The UploadCsvOptions function is missing the nullMarker . The nullMarker is available trough the CreateLoadJobOptions function when processing a .csv file trough a LoadJob.

To set expectations, we've certainly been trying to target the most common options first. Given that the API evolves and this is a hand-written wrapper meant to simplify things, it's always possible for there to be missing options.
Where an option that you need is missing, it's perfectly fine to file an issue like this (and I'll address it in a future release, although I'm half-way through building the release with Autodetect in...) but as a temporary measure you can drop down to use the Service directly.


Dynamically select destination light (group)

Is there any way to dynamically select the light which will be used with this app?
Why? I would like to have different mood lights based on time of the day.
PS: Thanks for this great and fun app!

Hey @K4CZP3R, did you manage to achieve what you were looking for with the constraints solution? If so, I'd like to close this issue.


Do you guys have a proper documentation on how to get the kubernetes Pod CPU usage

I am trying to figure out, how can i get the CPU usage of a pod or pods running in a namespace or service running in kubernetes using log analytics.
I don't see any documentation on how to do that and also I tried it on log analytics and no luck so far.
any idea if you have a documentation on how to get CPU metrics in kubernetes through OMS.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 14844115-45f0-0552-75d5-a903f3514ff9
Version Independent ID: 340ebed6-c8dd-f530-4093-39888b4f93b8
Content: Overview of Azure Monitor for containers
Content Source: articles/monitoring/monitoring-container-insights-overview.md
Service: azure-monitor
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@akramwaseem Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

@akramwaseem - In the following article - https://docs.microsoft.com/en-us/azure/monitoring/monitoring-container-insights-analyze?toc=%2Fazure%2Fmonitoring%2Ftoc.json#search-logs-to-analyze-data, it covers how to view the performance data in Log Analytics and includes some example queries.  To evaluate POD CPU usage for a specific node, here is an example query to get you started -
Perf
| where Computer == ""
| where ObjectName == "Container"
| where InstanceName contains "k8s_POD_" and CounterName == "Processor Usage sec"
| summarize AvgCPUUsage = avg(CounterValue) by bin(TimeGenerated, 30m), InstanceName
To rescope to all pods you can remove "where computer==" from the query.  I hope this helps.

#triaged

#please-close as I believe I have appropriately answered the question and have not heard back from @akramwaseem indicating otherwise.


dotnet build not working web app

Hi,
Built a project earlier without any errors (targeted netcoreapp1.0).
Went on to another project (netcoreapp1.1) and it worked at a start. Then I migrated it to the new VS17 RC2 csproj-style (as i did with the previous) and now it stopped working. Tried to switch to netcoreapp1.0 but without any result. The project has built just fine on Mac (now it probably wont :)
Installed .NET Core SDK/Runtimes

>dotnet --info
.NET Command Line Tools (1.0.0-preview4-004233)

Product Information:
 Version:            1.0.0-preview4-004233
 Commit SHA-1 hash:  8cec61c6f7

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.14393
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\1.0.0-preview4-004233

Exception
C:\Program Files\dotnet\sdk\1.0.0-preview4-004233\Sdks\Microsoft.NET.Sdk\build\Microsoft.PackageDependencyResolution.targets(140,5): error MSB4062: The "Microsoft.NET.Build.Tasks.ResolvePackageDependencies" task could not be loaded from the assembly C:\Program Files\dotnet\sdk\1.0.0-preview4-004233\Sdks\Microsoft.NET.Sdk\build\..\tools\netcoreapp1.0/Microsoft.NET.Build.Tasks.dll. Assembly with same name is already loaded Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\..\App.csproj]
C:\Program Files\dotnet\sdk\1.0.0-preview4-004233\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.Sdk.targets(82,5): error MSB4062: The "GenerateDepsFile" task could not be loaded from the assembly C:\Program Files\dotnet\sdk\1.0.0-preview4-004233\Sdks\Microsoft.NET.Sdk\build\..\tools\netcoreapp1.0/Microsoft.NET.Build.Tasks.dll. Assembly with same name is already loaded Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\..\App.csproj]

The issue was that the UserSecretsId wasn't enclosed in its own <PropertyGroup>. The project now builds from VS but fails from root-folder when using command line.
App
  App.sln
  -src
    -App
       App.csproj

This should go to https://github.com/dotnet/cli

I see the same error when a sln includes projects from newer sdk (<Project Sdk="Microsoft.NET.Sdk">) and older sdk (<PackageReference Include="Microsoft.NET.Sdk">).
May be related to https://github.com/dotnet/sdk/issues/352

Did you get resolution on this?

Please re-activate if this is still an issue.


Update stirling-pdf to 0.33.1 and some enhancements

Support pinning image sha
Use by default ghcr.io to prevent docker hub rate limit
Update image repository name
Upgrade stirling-pdf to 0.33.1

@Frooodle you can use rebase merging to keep commits history :)

@Frooodle can you merge it 👀


remove lighthouse as an explicit dependency

Currently, the lighthouse that the module uses exists explicitly in the dependency folder, while it can simply use the module.
This will significantly reduce the module size (currently 21.5MB)
This has passed npm test

You're saying we don't need the lighthouse in dependency folder, right?
But,
The lighthouse in the dependency folder has been modified to allow screenshots to be displayed in the report. So, we need to use this as a dependency instead of the original.

Currently, the lighthouse that the module uses exists explicitly in the dependency folder, while it can simply use the module.
This will significantly reduce the module size (currently 21.5MB)
This has passed npm test

Removing the lighthouse dependency will pass the test, but the reports generated won't have the Screenshot section in it.
We have explicitly modified lighthouse dependency and added our template to support the generated reports with screenshots.

One thing which we can improve upon is -
Right now there is need of lighthouse package to be installed while running web-review
We can shift this need by directly using our custom lighthouse from dependency!
This will certainly reduce the package size.

But that should make upgrading dependencies much tougher right? Is there any flag / parameter that can be set for lighthouse to get the required behaviour

But that should make upgrading dependencies much tougher right?
Yes
Is there any flag / parameter that can be set for lighthouse to get the required behaviour
No


Scoary missing from the docker/singularity containers

zDB fails due to a missing module when run with the following option :
zdb webapp --debug --dev_server
File "/usr/local/lib/python3.9/threading.py", line 980, in _bootstrap_inner
self.run()
File "/usr/local/lib/python3.9/threading.py", line 917, in run
self._target(*self._args, **self._kwargs)
File "/usr/local/lib/python3.9/site-packages/django/utils/autoreload.py", line 64, in wrapper
fn(*args, **kwargs)
File "/usr/local/lib/python3.9/site-packages/django/core/management/commands/runserver.py", line 134, in inner_run
self.check(display_num_errors=True)
File "/usr/local/lib/python3.9/site-packages/django/core/management/base.py", line 487, in check
all_issues = checks.run_checks(
File "/usr/local/lib/python3.9/site-packages/django/core/checks/registry.py", line 88, in run_checks
new_errors = check(app_configs=app_configs, databases=databases)
File "/usr/local/lib/python3.9/site-packages/django/core/checks/urls.py", line 14, in check_url_config
return check_resolver(resolver)
File "/usr/local/lib/python3.9/site-packages/django/core/checks/urls.py", line 24, in check_resolver
return check_method()
File "/usr/local/lib/python3.9/site-packages/django/urls/resolvers.py", line 480, in check
for pattern in self.url_patterns:
File "/usr/local/lib/python3.9/site-packages/django/utils/functional.py", line 49, in get
res = instance.dict[self.name] = self.func(instance)
File "/usr/local/lib/python3.9/site-packages/django/urls/resolvers.py", line 696, in url_patterns
patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)
File "/usr/local/lib/python3.9/site-packages/django/utils/functional.py", line 49, in get
res = instance.dict[self.name] = self.func(instance)
File "/usr/local/lib/python3.9/site-packages/django/urls/resolvers.py", line 689, in urlconf_module
return import_module(self.urlconf_name)
File "/usr/local/lib/python3.9/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1030, in _gcd_import
File "", line 1007, in _find_and_load
File "", line 986, in _find_and_load_unlocked
File "", line 680, in _load_unlocked
File "", line 850, in exec_module
File "", line 228, in _call_with_frames_removed
File "/home/bkm/storage/Chlam_poisson/zDB/webapp/settings/urls.py", line 8, in
re_path(r'^chlamdb/', include('chlamdb.urls')),
File "/usr/local/lib/python3.9/site-packages/django/urls/conf.py", line 38, in include
urlconf_module = import_module(urlconf_module)
File "/usr/local/lib/python3.9/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1030, in _gcd_import
File "", line 1007, in _find_and_load
File "", line 986, in _find_and_load_unlocked
File "", line 680, in _load_unlocked
File "", line 850, in exec_module
File "", line 228, in _call_with_frames_removed
File "/home/bkm/storage/Chlam_poisson/zDB/webapp/chlamdb/urls.py", line 5, in
from views import (entry_lists, fam, gwas, hits_extraction, locus,
File "/home/bkm/storage/Chlam_poisson/zDB/webapp/views/gwas.py", line 11, in
from scoary import scoary
ModuleNotFoundError: No module named 'scoary'
Scoary is apparently missing from the singularity and dockers containers, or the startup script does not use the most recent version (uses 1.3 for now).

Yes, we do not have containers for master, only for the latest release. If you are working on master you need to be using conda.

Ok I've made a new release some time ago, this issue should be fixed.


Fastfile: gym and pilot

I'm having a bit of a trouble with Fastfile. I have this issue that if I run a lane like
appid='com.example.xyz'
gym(scheme: "Some scheme")
pilot(app_identifier:appid)

and there's another ipa abc.ipa on the folder, pilot seems to load that other file and not the file gym created. This seems weird, I though gym set the path to the generated ipa to some var and pilot would pick that up and use that.
I think this might be solved by doing something like
appid='com.example.xyz'
ipa = gym(scheme: "Some scheme")
pilot(app_identifier:appid, ipa:ipa)

but seems like it shouldn't be needed. Also, deleting the other ipa file seems to work too.
When pilot runs, it doesn't print out the path to the ipa file in use, and neither does iTunesTransporter, but looking into the .itms package I saw a different ipa, and iTunesConnect complained with
ERROR ITMS-90054: "This bundle is invalid. The bundle identifier cannot be changed from the previous version. If you want to change your bundle identifier, you will need to create a new application in iTunes Connect.
I'll try to figure this out better soon…

Thanks for the issue @carlosefonseca, if this is still an issue for you, would you mind opening a new one in the pilot repo here: https://github.com/fastlane/pilot.
I'm going to close this comment for now and we can track work over there.
Thanks!


image doesnt load the first time in IE11

The first time IE browser loads, image doesn't load, but it loads if we resize the device-screen.

I ran into this issue a while back while trying to troubleshoot a WordPress plug in that enqueued picturefill. Make sure picturefill is loaded on document ready and not On window load. We had success on every browser but ie11


Manual refinement of generated schemas?

Now that we have a test suite in place, we could probably manually refine the generated zod schemas. This would allow us to:

Reduce boilerplate and reuse code across versions (also strict vs regular schemas)
Allow more complex validation logic (assert correct axes order, duplicated row/columns)

For example, zod intends to implement a switch utility for more efficient parsing of discriminated unions:
import { z } from "zod";

let IdentityTransformation = z.object({ type: z.literal("identity" });
let TranslationTransformation = z.object({ type: z.literal("translation"), translation: z.array(z.number()).min(2) });
let ScaleTransformation = z.object({ type: z.literal("scale"), scale: z.array(z.number()).min(2) });

let CoordinateTransformation = z.switch(x => {
  switch(x.type) {
    case "translation":
      return TranslationTransformation(x);
    case "scale":
      return ScaleTransformation(x);
    default:
      return IdentityTransformation(x);
  }
});

and we could reuse the CoordinateTransformation schema for v0.4/latest and strict vs non-strict.

Implemented in #5


README: added conditional init.lua

Yes, when I got to this I was going to suggest if vim.g.vscode then.
I was also planning on giving some tips on conditional loading with packer.nvim.

@theol0403 yes definitely cleaner. I updated the docs!

Thank you for the PR!


Replace single quotes with double quotes to enable variable substitution

$versions is not substituted for its value when using single quotes, resulting in a gradle error when trying to use said dependency

Oh shi..

Thanks, @zsoltk!


Improve defineExpose()

What problem does this feature solve?
I would like to propose 2 things to defineExpose.

Make expose variable more cryptic like __expose (like props) so we could use another expose variable (in my case I had to use exposed:

const _sfc_main$k = {
  __name: 'DialogComponent',
  setup(__props, { expose }) {

const exposed = {};
expose(exposed);

Nice feature of the expose that you can add to it later like in onMounted() when we have our DOM ready:

    Object.assign(exposed, {
        showModal: async loader => {
            if (loader) {
                ({ default: component.value } = await loader());
            }
            $dialog[0].showModal();
        },
        close: () => $dialog[0].close()
    });

To make the syntax shorter in the first item of this proposal I suggest to return the exposed object from the expose function:
function createSetupContext(instance) {
    const expose = exposed => {
        // return here
        return (instance.exposed = exposed || {});
    };
    let attrs;
    {
        return {
            get attrs() {
                return attrs || (attrs = createAttrsProxy(instance));
            },
            slots: instance.slots,
            emit: instance.emit,
            expose
        };
    }
}

so our exposed object could be declared like that giving we solved the both problems:
const expose = defineExpose();
// later add props to the expose for example in `onMounted()`

What does the proposed API look like?

Encrypt encode script setup parameter generated with defineExpose()
Return from the expose function the exposed object to use it later;

The first one is resolved in #7949


Login Via Twitter

This is the the new pull request for the backend code allowing the users to login through twitter.
Kindly preview and merge @codervivek5

kindly close the issue related to this issue


Remove dataviz instance from Dataviz.visuals on destroy

Scratch this.. unless there's good reasoning to the contrary, chart instances should hang around so that they can be re-rendered. Perhaps a new method should be introduced to handle permanent deletion?


archive openyurt-helm repo and create charts repo.

In order to make the repo name more readable, it is a good idea to rename openyurt-helm to charts, because the org name: openyurtio has already included the word openyurt. repo name openyurt-helm include word openyurt is duplicated.

moreover, i want to use openyurtio/charts repo to host OpenYurt charts from v1.5.0.

openyurtio/charts repo has been created, and charts have also been uploaded. so i will close this issue.


Additional review items from collabdoc editor changes

I've left a few late comments here:
https://github.com/oaeproject/Hilary/pull/1099
The most important thing is the un-returned error handling which risks invoking the callback multiple times. There are a couple minor things that could be changed at the same time.

Assigned to @stuartf -- I think this should block the point release we're bug-bashing tomorrow, so would be good to get these changed today if possible.

ready for review


⚠ Community has degraded performance

In e1148de, Community (https://community.wrk.com/health) experienced degraded performance:

HTTP code: 200
Response time: 202 ms

Resolved: Community performance has improved in a177b5d.


react-react-intl changes for GCP table details

issue: https://issues.redhat.com/browse/COST-1372

Codecov Report

Merging #2114 (dceac17) into react-intl_changeover (3ba2124) will not change coverage.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##           react-intl_changeover    #2114   +/-   ##
======================================================
  Coverage                  70.37%   70.37%
======================================================
  Files                        410      410
  Lines                       7506     7506
  Branches                    1457     1457
======================================================
  Hits                        5282     5282
  Misses                      2192     2192
  Partials                      32       32

Impacted Files
Coverage Δ

src/locales/messages.ts
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3d7ee0...dceac17. Read the comment docs.


[SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference

What changes were proposed in this pull request?
Document DESCRIBE FUNCTION statement in SQL Reference Guide.
Why are the changes needed?
Currently Spark lacks documentation on the supported SQL constructs causing
confusion among users who sometimes have to look at the code to understand the
usage. This is aimed at addressing this issue.
Does this PR introduce any user-facing change?
Yes.
Before:
There was no documentation for this.
After.

How was this patch tested?
Tested using jykyll build --serve

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14532/
Test PASSed.

Test build #109474 has started for PR 25530 at commit 6984101.

Test build #109474 has finished for PR 25530 at commit 6984101.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109474/
Test PASSed.

cc @gatorsmile

Test build #109513 has started for PR 25530 at commit 964aa71.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14570/
Test PASSed.

Test build #109513 has finished for PR 25530 at commit 964aa71.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109513/
Test PASSed.

Test build #110030 has started for PR 25530 at commit 9a4db23.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15049/
Test PASSed.

Test build #110030 has finished for PR 25530 at commit 9a4db23.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110030/
Test PASSed.

LGTM
Thanks! Merged to master.

@gatorsmile Thank you very much for fixing the mistakes and merging.


SDK changes to support group- and account-level analytics

SDK changes to support group and account level analytics

Is there an article or documentation about groups in Mixpanel? I'm curious what it is.


Update banner CSS

-add underline text decoration to link
-change link color when hovering

@maxfieldk29 - It didn't occur to me before, but for this site rather than changing the main.css file directly, instead make your changes to the SCSS files from which the CSS gets compiled; in this case: _sass/partials/_awards-banner.scss
If you haven't used scss before, the three biggest things that are different from standard CSS are:

it supports the use of variables (you'll see in this file that there's  references to $main-color that is commented out -- that's not used here, but the main color is defined elsewhere in the site and is reusable throughout
scss files can be broken into lots of short parts and compiled into one big CSS file, so the contents of the "partial" files are easy to find, and eventually generate the big, unwieldy main.css
class and id declarations can be nest (which does happen here), so this code:

.awards-banner {
  a {
    h1 {
     color: #ff3
     }
  }
}

gets compiled to:
.awards-banner a h1 { color:#ff3 }

So: you can make your CSS changes to the partial file and the jekyll-build process will compile the changes to main.css for you. Give it a try in a different branch and submit a pull request for it instead. If you want help figuring any of it out, give me a holler; I should be around all day today.

When I was testing out the SASS to make sure I was telling you the right thing, I tested it with a change in line 4 of the _awards-banner.scss file:
background-image: linear-gradient($primary-color, #2faaa4);
I found that changing the second value #2faaa4 to something darker (I went with #000) created an interesting sense of gravity in the image. I think the pure black might be overkill, but a dark version of the ALAO colors might be worth exploring, e.g.: #05302e
You might want to look at how tinkering with those gradients could spice up the look.
Here's a demo of what a few different looks could be like -- all that's changing is the second value in the gradient declaration:
https://codepen.io/kenirwin/pen/wvdGMJr


supported in mi

@jovanpop-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.


macOS(tauri): Inject plist in the runtime for webRTC & al.

Is your feature request related to a problem? Please describe.
Yes. We should allow an option to inject a plist in the runtime to ask permissions.
Describe the solution you'd like
Add a new configuration field in tauri.conf.json for macOS to customize the plist.
Option 1
We build a schema where they can define their own dict in tauri.json.conf (will require more works)
Option 2
Ask for a path but the user should take care of all aspects of the plist (app name etc..)
Another field should allow enabling or disabling the plist injection at the runtime (in dev mode), in prod it should never be injected as we use the bundler plist.
Will require some update in the bundler as well to make sure dev and prod reflect the same.
Describe alternatives you've considered
N/A
Additional context
Refer to https://github.com/tauri-apps/wry/issues/85#issuecomment-823499749

I am all for option #1 & #2
#1 we keep it REALLY simple
#2 is if they want to break it themselves

@lucasfernog if you want i can do it, i would love to know how you see it and which option you prefer.

I think we should go with #2, writing a plist in JSON must be weird (and prevents someone to just copy a file from stackoverflow lol).

I think we should go with #2, writing a plist in JSON must be weird (and prevents someone to just copy a file from stackoverflow lol).

make sense lol!
gonna draft that quickly


Questions

This is a well designed project because you noticed from the beginning that the ADC sampling rate of the ESP was inadequate. I just realized that the other day and thought that was due to the Arduino layer.
Do you control the Ti chip sampling rate or do you just read the pin data?
I couldn't see on the video, is it connected via SPI? Seems that you'd hit its bandwidth limit pretty quickly. Oh from the code it looks like it's I2S.... hmmm

Hi, I used I2S in parallel mode (look for "Camera connection over I2S" for further details). esp32 generates master clock for the ADC and reads data synchronously from 12 bit parallel data bus (output of ADC). Such combination is the only solution that let us get so high speed data flow with esp32 and without any additional components.


azure.core.exceptions.DeserializationError: Cannot deserialize content-type: text/html

Version
4.16.2
Describe the bug
I'm trying to test a python based MS azure bot using a webchat emulator.. i couldn't get the response from the bot..
When i try it locally with the bot emulator, i could a successful connection establishment between bot and emulator and getting an expected responses.. And when both the bot and webchat emulator runs in my local, i'm even 200 response.
Problem is when I deploy the bot, and use this service url and test on the local emulator i'm getting responses like
Error while invoking bot API - Response{protocol=http/1.1, code=500, message=Internal Server Error, url=http://xxxxxxxxxxxx:3972/bot}
        at com.mase.webchat.client.AzureClient.postActivity(AzureClient.java:104) ~[classes/:na]
        at com.mase.webchat.controller.ChatController.addUser(ChatController.java:86) ~[classes/:na]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_202]
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_202]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_202]
        at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_202]

And from the bot end, I could see
 File "/usr/local/lib/python3.9/site-packages/botbuilder/core/cloud_adapter_base.py", line 93, in send_activities
    response = await connector_client.conversations.reply_to_activity(
  File "/usr/local/lib/python3.9/site-packages/botframework/connector/aio/operations_async/_conversations_operations_async.py", line 524, in reply_to_activity
    response = await self._client.async_send(
  File "/usr/local/lib/python3.9/site-packages/msrest/async_client.py", line 115, in async_send
    pipeline_response = await self.config.pipeline.run(request, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/msrest/pipeline/async_abc.py", line 159, in run
    return await first_node.send(pipeline_request, **kwargs)  # type: ignore
  File "/usr/local/lib/python3.9/site-packages/msrest/pipeline/async_abc.py", line 79, in send
    response = await self.next.send(request, **kwargs)  # type: ignore
  File "/usr/local/lib/python3.9/site-packages/msrest/pipeline/async_requests.py", line 106, in send
    return await self.next.send(request, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/msrest/pipeline/async_abc.py", line 84, in send
    self._policy.on_response(request, response, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/msrest/pipeline/universal.py", line 250, in on_response
    response.context[self.CONTEXT_NAME] = self.deserialize_from_http_generics(
  File "/usr/local/lib/python3.9/site-packages/msrest/pipeline/universal.py", line 226, in deserialize_from_http_generics
    return cls.deserialize_from_text(body_bytes, content_type)
  File "/usr/local/lib/python3.9/site-packages/msrest/pipeline/universal.py", line 203, in deserialize_from_text
    raise DeserializationError("Cannot deserialize content-type: {}".format(content_type))
azure.core.exceptions.DeserializationError: Cannot deserialize content-type: text/html

Even cross-verified the content-type in the request payload and it is set as application/json as expected.. and also verified the versions between local and deployed server.
I'm not sure why is this Cannot deserialize content-type: text/html  occurs..
Used versions,
aiohttp - 3.10.5
azure-core -  1.30.2
botbuilder-core -  4.16.2
botbuilder-integration-aiohttp - 4.16.2
botbuilder-schema - 4.16.2
botframework-streaming - 4.16.2
urllib3  - 1.26.19
yarl - 1.9.4

@Stevenic @pcostantini @mgiovani Can _someone help with this.

Hi, can anyone help on this

I'm not familiar with the context of this.  It would appear when trying to send a response to the original request.  i.e., The bot receives an Activity via an HTTP POST, and likely sends a response to the endpoint indicated in the Activity.ServiceUrl property.  In no case would HTML even be expected.  Though I don't know in this case where it's sending the response to.

Closing due to inactivity. Please feel free to reopen if the issue persists or you have new details to share.


Fail if meta is not a pandas object

[x] Closes #8537
[x] Tests added / passed
[x] Passes pre-commit run --all-files

Still need to add a test to prove it.

FYI I believe this is failing distributed/tests/test_collections.py::test_dataframe_groupby_tasks: https://github.com/dask/distributed/runs/4927021633?check_suite_focus=true#step:12:1679

ooh thanks for mentioning that. I will open a PR on distributed.


Drawer (type=sidebar) Toggle Button Alignment

When I fixed the gap between the sidebar and the main container in electrofishing, to be consistent with the other gaps, it made the toggle button offset in the wrong place:

Yeah our drawer/tray implementation was very depending on the layout. Do you have any suggestions for correcting it?

It looks like it's a problem in Atlas as well:

The only thing that is different between this project and atlas is that I fixed the gap to the left of the map so that it matched everything else. I'm happy to make the same fix to atlas. Or maybe you think that it should stay?
The issues with the tray seem to be unrelated to the app layout to me.

this was closed by #361


[Feature Request]: Nvidia Triton Tensor RT LLM Integrations

Feature Description
I would like to add support for Nvidia Triton TensorRT LLMs in llama index. There is currently support for several other LLM endpoints and Nvidia has several interesting offerings with their Triton LLM endpoints that I think others would find useful in llama_index.
Reason
There are several implementations of this floating around the internet already. However, end users must "hack" together the solution and build from source. This will allow users to not have to go through those efforts.
Value of Feature
New LLM endpoints that give users more options and control over how they can use llama index and potential keep their data under their own control.

The issue is a feature request for the integration of Nvidia Triton TensorRT LLMs (Language Model) into the llama index. The llama index currently supports several other LLM endpoints, and the user believes that Nvidia's Triton LLM endpoints would be a valuable addition.
The reason for this request is that there are already several implementations of this feature available on the internet. However, these require end users to manually piece together the solution and build it from the source. The proposed feature would eliminate this need, making it easier for users to utilize the llama index.
The value of this feature lies in the new LLM endpoints it would provide. These would give users more options and control over how they use the llama index, potentially allowing them to keep their data under their own control.
To address this issue, the following actions could be taken:

Research Nvidia Triton TensorRT LLMs and understand how they can be integrated into the llama index.
Identify the existing implementations of this feature on the internet and understand how they work.
Develop a plan for integrating Nvidia Triton TensorRT LLMs into the llama index, taking into account the need to make the process easy for end users.
Implement the plan, ensuring that the new feature works as expected and does not introduce any new issues.

The relevant files for this issue are:

llama_index/llms/llama_cpp.py: This file contains the implementation of the LlamaCPP class, which is a custom LLM. It seems to be the main file where the integration of Nvidia Triton TensorRT LLMs would take place.

llama_index/langchain_helpers/agents/__init__.py: This file contains the initialization of the llama integration with Langchain agents. It might be relevant if the integration of Nvidia Triton TensorRT LLMs involves changes to the way llama interacts with Langchain agents.


Enable sed command generated by unused-imports to correctly handle file paths containing spaces

The unused-imports program currently generates sed invocations to remove import statements which operate on relative file paths, these paths should be quoted in order to handle the case where the path to the source file contains a space.

Looks like the cla needs a fix


mvp-cockpit: Make the breadcrum navigation more consistent to Cloud Broker Portal style

For the Repository Details page it currently looks like this:

And for the Blueprints page:

Can we make it look more consistent to what we do in the Cloud Broker Portal:

So change to:

Repository Details Page: Cockpit Portal / Repositories / Repository: {repository name}
Blueprints Page: Cockpit Portal / Repositories / Repository: {repository name} / Blueprints

This should be filed under the portal repo. Moved to https://github.com/Jumpscale/jumpscale_portal8/issues/120

ok


How do I set response models to not be optional as typescript is saying a value can be undefined when it can never be the case.

I'm using fast endpoints with a typescript client automatically generated from the Open API specification generated by Fast Endpoints.
I have response models which I know they will always have a value, however, currently the response models are being created with all fields being marked as nullable, for example:
    id?: string;
    name?: string;
    headerImage?: string;

my understanding is that this is happening because the Open API definition is created as per the below:
    "schemas": {
      "Response": {
        "type": "object",
        "additionalProperties": false,
        "properties": {
          "id": {
            "type": "string"
          },
          "name": {
            "type": "string"
          },
          "headerImage": {
            "type": "string"
          }
        }
      },

I'd like to generate this definition instead:
    "schemas": {
      "Response": {
        "type": "object",
        "required": [
          "id",
          "name",
        ],
        "additionalProperties": false,
        "properties": {
          "id": {
            "type": "string"
          },
          "name": {
            "type": "string"
          },
          "headerImage": {
            "type": "string"
          }
        }
      },

Is it possible to create this OpenAPI definition?

looks like this is a known issue with nswag+oas3+typescript:
https://github.com/RicoSuter/NSwag/issues/3110
and the current workaround seems to be to use a custom schema processor to mark all non-nullable properties of the schema as required.
public class MarkNonNullablePropsAsRequired : ISchemaProcessor
{
    public void Process(SchemaProcessorContext context)
    {
        foreach (var (_, prop) in context.Schema.ActualProperties)
        {
            if (!prop.IsNullable(SchemaType.OpenApi3))
                prop.IsRequired = true;
        }
    }
}

which you can register like this:
builder.Services.AddSwaggerDoc(s =>
{
    s.SchemaProcessors.Add(new MarkNonNullablePropsAsRequired());
});

which seems to solve it for typescript client generation.
i'm wondering whether i should incorporate this into FE so it'll be on by default.
would there be some unforeseen issues? why doesn't nswag do this by default?
let me know your thoughts.

Thanks for the update. I can confirm that the code above is a valid workaround, however, I think there will be some cases where this wouldn't work, particularly if you don't enable the nullable reference types feature of C#8.
From what I can gather, the IsNullable function listed above doesn't return true for arrays, strings or reference types which means that unless you enable nullable reference types this functionality will probably cause issues down the line in clients.
I will do some further investigation and will update the issue with any information.

This works well for me too. I have nullable reference types enabled. I wonder if it would be better to include it in the library as a option that can be toggled.

Yes, this is useful for me since I have nullable reference types enabled. The processor above allows the NSwag TS client generator to generate the correct required props. Perhaps it could be an option in the library to toggle.

Nice addition of MarkNonNullablePropsAsRequired, worth adding to documentation in my opinion :)

@dziedrius
done...


PHPStan level 6 with AuditReader not generic

Subject
Alternative to https://github.com/sonata-project/EntityAuditBundle/pull/487 making AuditReader not generic.
Raising PHPStan level after this to level 7 shows 23 errors.

I am targeting this branch, because this is BC.

Changelog

### Added
- Specify iterable types
### Changed
- Make `AuditReader` not generic

Removing the template would create issues for the sonata compatibility since there is one in the SonataAdmin interface
https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/Model/AuditReaderInterface.php#L19
I wonder if we shouldn't have both
/**
 * @phpstan-template T of object
 */
class AuditReader
{
    /**
     * @phpstan-template TT of T
     * @phpstan-param class-string<TT>
     * @phpstan-return TT
     */
    public function find($classname): object
    {
    }
}

This way we can define an AuditReader<Foo|Bar>, but then
if we use find(Foo::class), it will be understood as a Foo object and not only Foo|Bar.
WDYT ?
We should update https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/Model/AuditReaderInterface.php phpdoc then and the same could be done for the ModelManager https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/Model/ModelManagerInterface.php#L55

Removing the template would create issues for the sonata compatibility since there is one in the SonataAdmin interface https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/Model/AuditReaderInterface.php#L19
I wonder if we shouldn't have both
/**
 * @phpstan-template T of object
 */
class AuditReader
{
    /**
     * @phpstan-template TT of T
     * @phpstan-param class-string<TT>
     * @phpstan-return TT
     */
    public function find($classname): object
    {
    }
}

This way we can define an AuditReader<Foo|Bar>, but then if we use find(Foo::class), it will be understood as a Foo object and not only Foo|Bar.
WDYT ?

IMHO that seems overcomplicated.
I understand that AuditReader::find should be generic and maybe some other methods, but to me this class seems to work more like the EntityManager from doctrine/orm rather than a repository.

I understand that AuditReader::find should be generic and maybe some other methods, but to me this class seems to work more like the EntityManager from doctrine/orm rather than a repository.

For SonataAdmin, it's considered as a repository, and the AuditManager would be the EntityManager
https://github.com/sonata-project/SonataAdminBundle/blob/4.x/src/Model/AuditManagerInterface.php#L42-L46
We can use different AuditReader for different classes.
But I think the generic part of the AuditReader of this project can be removed,
this shouldn't break the SonataDoctrineORM static analysis, with this code https://github.com/sonata-project/SonataDoctrineORMAdminBundle/blob/4.x/src/Model/AuditReader.php#L41-L44

Thanks @franmomu


Vue 3.2.31 breaks ckeditor5-vue

Version
3.2.31
Reproduction link
stackblitz.com
Steps to reproduce
change vue to "3.2.30" and watch the error "ckeditor.js:84 TypeError: Cannot read properties of undefined (reading 'model')" go away.
What is expected?
ckeditor works without error before vue 3.2.31
What is actually happening?
ckeditor throws a console error

Linked to this issue in ckeditor
https://github.com/ckeditor/ckeditor5-vue/issues/203

Your reproduction is not minimal, please read and follow https://new-issue.vuejs.org/?repo=vuejs/vue-next#why-repro when reporting a bug. Most bugs should be reproducible with the SFC Playground. In other words, we need a repro without ckeditor to check what the issue.

As the vue (3.2.31) update breaks ckeditor I can't really reproduce the bug without including ckeditor.

Reproduction: https://jsfiddle.net/Linusborg/wdb4scfv/

Likely solved once #5417 is published, but still wanna take a look

FYI #5417 did not fix this issue.

Aah, so it's just because the $test needs to be referenced as $data.$test because it starts with $. If that doesn't solve it, please open a new issue without ckeditor so we can take a look.


REST API frontend abstraction

The code currently directly interacts with the REST API, in the sense that individual components issue GET, PUT etc. requests and consume the output.
This issue suggests refactoring part of this code to mirror backend ORM classes in the frontend.
Suggested steps:

Implement OpenAPI documentation for the backend, e.g. using django-spectacular
Generate automatic frontend classes, e.g. using openapi-ts
Switch code to use this abstraction layer

A key advantage of this is:

Checking the reponse against a schema (encoded in the frontend classes)
Easier testing because those classes can be mocked

See also: https://github.com/ContactEngineering/topobank/issues/1094


v1.17.0

Codecov Report

Merging #26 (4b2b39e) into main (fcbb23f) will decrease coverage by 0.84%.
The diff coverage is 87.75%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   84.47%   83.62%   -0.85%
==========================================
  Files          14       14
  Lines         496      507      +11
  Branches        4        4
==========================================
+ Hits          419      424       +5
- Misses         77       83       +6

Impacted Files
Coverage Δ

src/main/scala/ton/sdk/client/modules/Crypto.scala
84.05% <87.75%> (-7.33%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcbb23f...4b2b39e. Read the comment docs.


[Update] Update image versions

Automated changes by create-pull-request GitHub action

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (e6b68c7) 86.75% compared to head (3511cfb) 86.75%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #313   +/-   ##
========================================
  Coverage    86.75%   86.75%
========================================
  Files           78       78
  Lines         4582     4582
========================================
  Hits          3975     3975
  Misses         522      522
  Partials        85       85

Flag
Coverage Δ

unittests
86.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Gifs

Is there any plans this app will support animated gifs?

The following media file formats are Roku supported:
Video	MKV (H.264), MP4 (H.264), MOV (H.264), WMV (VC-1, firmware 3.1 only)
Music	AAC, MP3, WMA, FLAC (firmware 5.3 and later), WAV (firmware 5.3 and later)
Photo	JPG, PNG, GIF (non-animated)
While Roku supports GIF's (as does this channel) it is only non-animated due to a technical limitation from ROKU.
Thanks
Chris


HELP ME

Problem encountered on https://dotnet.microsoft.com/en-us/learn/dotnet/hello-world-tutorial/edit
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

What problem did you encounter?


Add featuretools?

Consider adding featuretools to the environment.yml file. A good library for automated feature engineering for classic ML approaches would be useful.

Interesting the featuretools depends on `dask!
https://github.com/Featuretools/featuretools/blob/master/requirements.txt


removed possibility for undefined in Message's id value

Related Issue:  open-cluster-management/backlog#12024
Description of changes

Changed value type from String to String! of Message query to prevent undefined value.

/lgtm


installation depends implicitly on aclocal

The installation depends on presence of aclocal. This needs to be part of pre-requirements or users need to install automake

How exactly?

Closing due to inactivity.


[Downstream] Configure/create a slave for microshift bundle generation

We don't want to disturb our current node which create podman and OCP bundle but add another slave or reuse different slave to create microshift bundles for x86_64. As of now crc-gcp-instance slave is under utilized and we need to upgrade it config and use it for microshift bundle purpose.

Already done downstream.


ERROR: 'NoneType' object has no attribute 'db_name'

(UPDATED traceback for most recent commits)
Hello!
I managed to load a data set of 1000 pictures (named it "test_data") and now attempted to train a model ("test_model") on it.
For the model I select my data set of 19 colored 256x256-sized pictures. I select "AlexNet" and keep the defaults.
After a second I get the following error message:
ERROR: 'NoneType' object has no attribute 'db_name'

Traceback (most recent call last):
  File "/home/ubuntu/digits/digits/scheduler.py", line 394, in task_thread
    task.run(**options)
  File "/home/ubuntu/digits/digits/task.py", line 161, in run
    self.before_run()
  File "/home/ubuntu/digits/digits/model/tasks/caffe_train.py", line 98, in before_run
    self.save_prototxt_files()
  File "/home/ubuntu/digits/digits/model/tasks/caffe_train.py", line 224, in save_prototxt_files
    val_data_layer.data_param.source = self.dataset.path(self.dataset.val_db_task().db_name)
AttributeError: 'NoneType' object has no attribute 'db_name'

Any ideas what might be the issue here?
Kind Regards
Raffael
PS: The following two screenshots show the chosen settings and the error message:

Ahaaaa .... apparently a validation set isn't optional ...
# causes trouble in caffe_train.py:224 and ...
val_data_layer.data_param.source = self.dataset.path(self.dataset.val_db_task().db_name)

# ... calls this function which returns None if no validation set is provided
def val_db_task(self):
        """
        Return the task that creates the validation set
        """
        for t in self.tasks:
            if isinstance(t, tasks.CreateDbTask) and 'val' in t.name().lower():
                return t
        return None

apparently a validation set isn't optional

No, it should be. If you're getting this error then that's a bug. I'm looking into it now...


Remove finalized api proposals from package.json

Part of microsoft/vscode#191605

@karrtikr done, I'm assuming it's correct to just stick today's date in


I solves my problem but it breaks other stuff.


chore(deps): update dependency less-loader to v7

This PR contains the following updates:

Package
Type
Update
Change

less-loader
devDependencies
major
5.0.0 -> 7.0.0

Release Notes

webpack-contrib/less-loader
v7.0.0
Compare Source
⚠ BREAKING CHANGES

move less to peerDependencies, the implementation option was removed
prependData and appendData option were removed in favor the additionaldata option

Features

added webpackImporter option (#377) (12dca5b)
added loader context in less plugins (#378) (7b7fc5e)
added additionaldata option (#374) (2785803)

v6.2.0
Compare Source
⚠ BREAKING CHANGES

move less to peerDependencies, the implementation option was removed
prependData and appendData option were removed in favor the additionaldata option

Features

added webpackImporter option (#377) (12dca5b)
added loader context in less plugins (#378) (7b7fc5e)
added additionaldata option (#374) (2785803)

v6.1.3
Compare Source
Features

support condition names from package.json (#369) (671395d)

6.1.3 (2020-06-29)
Bug Fixes

revert restrictions (e758837)

6.1.2 (2020-06-22)
Bug Fixes

ignore watch for remove URLs (3946937)
resolution logic (2c3a23a)
resolve absolute and root relative imports (3d01b82)

6.1.1 (2020-06-11)
Bug Fixes

do not rebuilt unmodified files on windows in watch mode (6537a3d)

v6.1.2
Compare Source
v6.1.1
Compare Source
v6.1.0
Compare Source
Features

new implementation option (#354) (d2de80f)

Bug Fixes

respect third-party plugins for Less (#353) (d0db4f9)

v6.0.0
Compare Source
Features

new implementation option (#354) (d2de80f)

Bug Fixes

respect third-party plugins for Less (#353) (d0db4f9)

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 7.x releases. However, if you upgrade to 7.x manually then Renovate will then reenable updates for minor and patch updates automatically.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.