Test suite for functional test

Implements simple functional test for the hello-world endpoint.
The base URL for the server is taken from an environment variable APP_BASE_URL, so that we can test against a deployed URL in the future. For now this tests against localhost.
Steps:

Start the server locally make run
Run the functional tests make functional-test

/hold

This repo is no longer in use.


multitenanted hydrations

Please make sure you consider the following:

[x] Add tests that use __typename in queries
[x] Does this change work with all nadel transformations (rename, type rename, hydration, etc)? Add tests for this.
[x] Is it worth using hints for this change in order to be able to enable a percentage rollout?
[x] Do we need to add integration tests for this change in the graphql gateway?
[x] Do we need a pollinator check for this?

The idea is that we will add a callback to the gateway where the gateway will partition in batches based on a shard. Need to pass more data to the callback though, arg definitions probably and the service as a minimum

Function name in hook needs to be more specific. Would prefer test to be closer to a real world example but nbd if you need this change in soon.
Looks good otherwise.

renamed it to partitionBatchHydrationArgumentList


using SCRAM implemented in pure Nim

@rgv151, thanks a lot! But have you tested this?

yes I do, im using it in my rethinkdb driver too

Cool!


default arguments not supported

function(tmp = 9){} throws errors when used (ES6)

I'm mass closing issues due to the release of 1.0 obviating lots of bugs. If you feel this issue is something we still need to address feel free to reopen.


Fix annotation and namespace issue

Fixes #16, and a variety of other issues hit in processing my existing grammars to extract documentation

Support documentation (or any other annotations) on groups and references to a named define
use a: as the xmlns prefix for http://relaxng.org/ns/compatibility/annotations/1.0, but don't assume that the user has already defined it, and make sure to qualify the case where they defined namespace a=... to be something else too.
Follow the spec for whitespace handling in a:documentation
Fix combining |=, &= productions in the presence of annotations.
Fix handling of datatag and literals with possibly-namespaced type references.

For now using the rule that the first datatype reference becomes the default datatypeLibrary for the whole <grammar>, and is therefore not referenced explicitly. trang uses this same rule. That minimizes changes to the output, but it does cause a few headaches (and at least one failing test, hence the draft status).
https://github.com/djc/rnc2rng/blob/2b2c3c7c7f6a59055e68aea53769028609b469e9/rnc2rng/serializer.py#L244 requires that the root and included file have chosen the same default datatypeLibrary, and with this rule that is not the case.
it's easy to fix, but I'm submitting the draft for an opinion on which way you'd prefer:

In a lot of cases, your output has already done many (though not all) of the RELAX NG simplification steps. e.g. you use <element><name ns="...">a</name></element> instead of <element name="prefix:a"/>, you write the redundant <group> tags,  etc. So brevity doesn't seem to be a huge goal. serializer.py could just write the datatypeLibrary on every <data> and <value> element, and not set a <grammar>-level default. But this changes quite a lot of test outputs (in the trivial sense of adding datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes" in a lot of places.

the root could force any already-chosen default down for any included file, and/or adopt any default that the included file picked if it hadn't yet picked itself (i.e. need for types prior to the include). This ensures consistency at the expense of having the included file alter how the parent serializes.

include could (IMO should) be translated from RNC into the RNG <include> element, instead of following the simplification to inline it all away. But then you have to write multiple output files, which doesn't really work with the current shape of dumping it all to stdout.

Solution 1, but only for elements in an include (anything from an include is written explicitly). Or, they are allowed to use a default from the root, but not to set a new one if it hasn't been chosen yet

Probably still more variations possible... all are basically equivalent in terms of what you end up with after simplification, of course.

(Note  the committer and author are different on your patches. I'm fine with  that, but usually when I end up in that situation it's because I tried  to change it after the fact and partially failed...)

The names are the same, but the dates differ, because I did a bunch of rebase/squashing to put things into logical chunks. I can reset that before I I move it out of draft.

On the issue of multiple type libraries, I wonder if it would be hard to use a hybrid approach: use your approach 1 but only if the type library is not the default/first. What do you think?

It isn't really about multiple type libraries (though I did test that), as it is about handling both xsd:type and the built-in token/string types, and getting the namespaces right. RELAX has no concept of a default datatypeLibrary like it does for default namespaces (in fact RELAX NG doesn't even have prefixes, Only the compact syntax introduces that concept of prefixes, the XML scheme always just uses the full URLs, but might copy the datatypeLibrary attribute from an ancestor element during simplification if it's missing.
I suppose since xsd is magically predefined: https://relaxng.org/compact-20021121.html

In the initial environment used for the start symbol [...] and xsd is bound as a datatype prefix to http://www.w3.org/2001/XMLSchema-datatypes;
And cannot even be changed:

It is an error if the value of datatypePrefix is xsd and the the value of the literal is not http://www.w3.org/2001/XMLSchema-datatypes.

We could just run with that bit of magic; a grammar-level datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes" gets printed if xsd:* was ever referenced, and otherwise nothing is set for on <trammar>. Any other datatypes URI (that is not http://www.w3.org/2001/XMLSchema-datatypes) is always written explicitly on <data> or <value>, and thus doesn't care what's in its ancestors.
That avoid most of the cosmetic changes to changed output, and I think it would match what previous version (which just ignored the datatypePrefix and had the needs['types'] thing) did except where the previous one was subtly incorrect (e.g. using string, and having it get turned into xsd:string.
And then that assert just gets removed, because they can only disagree about whether it needs to get printed (if either wanted to print it, it does), not about what value it can have (which might not be reconcilable).
I like that solution, will try to make it so.

Ah, maybe the names are the same, but the emails are different? GitHub shows me two different identities. I never really look at the dates, so you don't have to fix them up on my account.
The type library solution you came up with sounds great!

Hi @puetzk, are you still interested in finishing this up?

Going to close this for now. Feel free to reopen (or open a different PR) if this is of interest.


Reliable mechanism to test if DNS queries are secured?

Hello,
I wanted to ask if there's a reliable mechanism to know that my DNS queries are essentially encrypted, in addition to seeing Intra running background?
I meant no offense to the Intra team. I had this question because I checked out the Cloudflare DNS blogs and run a test at https://<IP_ADDRESS>/help ; this test seems to show that neither DoH nor DoT was in use for me. The attached screenshot shows my result on my Pixel C tablet.
I should note that if I switched DNS server from Google to Cloudflare, it would show that DoT was in use.
Hope to hear from you soon!
Cheers,
Sam

Hi @shaomeng.  Unfortunately, I think the Cloudflare status page is a bit confusing here.  The "Using DNS over HTTPS (DoH)" and "Using DNS over TLS (DoT)" status indicators only apply to Cloudflare's DNS service.  As you noted, if you switch to cloudflare-dns.com in Intra, the status page correctly indicates that you are connected to Cloudflare DNS using DoH.


CMake Error in CMakeLists.txt:

We are seeing errors while trying to build the Postgres-rdkit. Not aware of this error. It was running fine previously. Please let us know the fix. whereas mcs07/docker-rdkit is building fine.
CMake Error in CMakeLists.txt:
Imported target "AvalonLib" includes a non-existent path
"/usr/include/python3.7m"

in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

The path was deleted, renamed, or moved to another location.

An install or uninstall procedure did not complete successfully.

The installation package was faulty and references files it does not
provide.

-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.
The command '/bin/sh -c cmake -Wno-dev     -D CMAKE_BUILD_TYPE=Release     -D CMAKE_SYSTEM_PREFIX_PATH=/usr     -D CMAKE_INSTALL_PREFIX=/usr     -D CMAKE_MODULE_PATH=/rdkit/Code/cmake/Modules     -D RDK_BUILD_AVALON_SUPPORT=ON     -D RDK_BUILD_INCHI_SUPPORT=ON     -D RDKit_DIR=/usr/lib     -D PostgreSQL_ROOT=/usr     -D PostgreSQL_TYPE_INCLUDE_DIR=/usr/include/postgresql/12/server/     .' returned a non-zero code: 1.

Also having this issue. Not sure how to fix this. Previously would build fine but now it's broken.

Any Updates on the fix? Please let us know

Thanks to Matt for creating this docker image, it has been a very helpful resource for many.
TLDR;  To upgrade to the latest version, I've created a beta build postgres-rdkit Dockerfile which is available from docker at docker image
Out of necessity I spent a little time on this, I want/need to upgrade to the latest version.  Like many of you first I tried to fix this Dockerfile, but ran into odd issues, so decided to just build a new Dockerfile from the ground up.  Caveat, I'm a long time docker user, and I'm still discovering the nuances of Dockerfile building, so even though this works as a drop in replacement for me, YMMV (let me know in the github project if you encounter issues with my image).


Grafana makes CrateDB crash

Hi guys,
I installed FIWARE components through docker compose file following this page: https://quantumleap.readthedocs.io/en/latest/admin/
While data are sent from the Broker to CrateDB, Grafana comes slower and slowe until CrateDB crashes.
I'm sure that is Grafana that make CrateDB crash because if nobody open a dashboard in Grafana, CrateDB continues to live.
What can i do for avoiding this slowing and crashing?
Thanks in advance for the answers.

hi @AngeloIapichino
it is hard to reply to your question:

you haven't provided any concrete information on the deployment neither simple way to reproduce the bag;
clearly this is not anything specific to quantumleap, but rather a problem of crate related to your environment.

now, my wild guess is that your are poor on ram in your docker machine, and that when it saturates, due to queries, your deployment gets first slow and the crash.

Deployment with this docker-compose file:

version: '3'
services:
orion:
image: fiware/orion:${ORION_VERSION:-2.2.0}
ports:
- "1026:1026"
command: -logLevel DEBUG -noCache -dbhost mongo -corsOrigin __ALL
depends_on:
- mongo
healthcheck:
test: ["CMD", "curl", "-f", "http://<IP_ADDRESS>:1026/version"]
interval: 1m
timeout: 10s
retries: 3
mongo:
image: mongo:3.2.19
ports:
- "27017:27017"
volumes:
- mongodata:/data/db
quantumleap:
image: ${QL_IMAGE:-smartsdk/quantumleap}
ports:
- "8668:8668"
depends_on:
- mongo
- orion
- crate
environment:
- CRATE_HOST=${CRATE_HOST:-crate}
- USE_GEOCODING=True
- REDIS_HOST=redis
- REDIS_PORT=6379
crate:
image: crate:${CRATE_VERSION:-3.1.2}
command: crate -Clicense.enterprise=false -Cauth.host_based.enabled=false
-Ccluster.name=democluster -Chttp.cors.enabled=true -Chttp.cors.allow-origin="*"
ports:
# Admin UI
- "4200:4200"
# Transport protocol
- "4300:4300"
- "5432:5432"
volumes:
- cratedata:/data
grafana:
image: grafana/grafana
ports:
- "3000:3000"
environment:
- GF_INSTALL_PLUGINS=grafana-clock-panel,grafana-worldmap-panel,flant-statusmap-panel
- GF_PANELS_DISABLE_SANITIZE_HTML=true
depends_on:
- crate
volumes:
- grafanadata:/var/lib/grafana
redis:
image: redis
deploy:
# Scaling Redis requires some extra work.
# See https://get-reddie.com/blog/redis4-cluster-docker-compose/
replicas: 1
ports:
- "6379:6379"
volumes:
- redisdata:/data
volumes:
mongodata:
cratedata:
redisdata:
grafanadata:
networks:
default:
driver_opts:
com.docker.network.driver.mtu: ${DOCKER_MTU:-1400}

I have about 14k records.
Do you think that the problem is the deployment (all in a local and docker machine)? Can you suggest a different way to deploy it?
Thanks in advance.

As said, I think the issue is the memory, but it's a guess. You can:

check the logs of the different components and try to guess what's going wrong; 2) measure (with top) resources in the docker machine to see if you are hitting memory limit; 3) see what happens if you increase memory assigned to your virtual machine.

I know that the problem is the memory because CrateDB crashes with outofmemoryerror.
The question is: the solution can be only increasing the memory or maybe i have to change the deployment approach (i read about HA deployment)?

i am not sure that just going HA will solve your memory issue :) you should just make proper amount of memory available in your docker machine.
anyhow, if you wanna use docker swarm:
https://smartsdk-recipes.readthedocs.io/en/latest/data-management/quantumleap/readme/
alternatively, on kubernetes:
https://github.com/orchestracities/charts

I solved the crashes increasing the crate's heap space memory setting the environment variable CRATE_HEAP_SIZE to 3 giga.
In the docker-compose file:
crate:
    image: crate:${CRATE_VERSION:-3.1.2}
    environment:
      - CRATE_HEAP_SIZE=3000M
    command: crate -Clicense.enterprise=false -Cauth.host_based.enabled=false
      -Ccluster.name=democluster -Chttp.cors.enabled=true -Chttp.cors.allow-origin="*"
    ports:
      # Admin UI
      - "4200:4200"
      # Transport protocol
      - "4300:4300"
      - "5432:5432"
    volumes:
      - cratedata:/data

Grafana is still very slow and laggy, but i'm doing some test increasing the RAM amount of the machine.

Be careful with heap memory, it should not be more than half of the actual memory available on your machine, or you will end up swapping. https://crate.io/docs/crate/guide/en/latest/performance/memory.html#mobile-nav

Can we consider this issue closed?

Hi there,
even when coming late to this, I would like to add that swapping can be avoided for CrateDB by configuring bootstrap.memory_lock: true, see also [1]. But still, @chicco785 is right - a good starting point for the heap space is 25% of the system memory.
With kind regards,
Andreas.
[1] https://crate.io/docs/crate/howtos/en/latest/performance/memory.html#swap


ofetch.create is not a function

Environment
node version is 14.18.0,ofetch version is 1.0.0
Reproduction

Describe the bug
I want to use ofecth.create function to create baseUrl,but appear ofetch.create is not a function . plz
Additional context
No response
Logs
No response

Use createFetch

import { ofetch } from 'ofetch';

const fetch = ofetch.create({ baseURL: '/api' });

console.log(fetch);
// [Function: $fetch2] {
//   raw: [AsyncFunction: $fetchRaw2],
//   native: [Function (anonymous)],
//   create: [Function (anonymous)]
// }

@daguanren21
Would you provide a minimal reproduction instead of a screenshot and reopen this issue later?

This seems to be an issue with cjs exports.
cjs (create is not a function): https://stackblitz.com/edit/node-9rgwsr?file=index.js
module (create runs correctly): https://stackblitz.com/edit/node-wqz68m?file=index.js


Docs shows an outdated view

Side bar view of docs.sigstore.dev in browser:

View in incognito:

If I were to guess, page caching is too long-lived. Is this something that is controllable?

Dear @ltagliaferri @haydentherapper
I am writing this to express my interest in participating in the Google Season of Docs program, 2023. I am a final year student at IIT Mandi, pursuing Bachelors of Technology in Computer Science. I am doing minors in Data Science and have done a significant number of courses as well as projects in this domain.
Could you please guide me on how to proceed. I would appreciate any advice or recommendations you may have regarding the project.
Regards
Pritish Chugh

Done, closing as a dup of https://github.com/sigstore/docs/issues/43


This my branch i had some errors to fix don't know how it is done

teacher  have maybe few question wanna ask but maybe ill remember to ask in the class

check the commit 51697fa, may help


x/pkgsite: search no longer finds built-in modules

What is the URL of the page with the issue?
https://pkg.go.dev/search?q=time
What is your user agent?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.131 Safari/537.36
Screenshot

What did you do?
Searched for time
What did you expect to see?
https://pkg.go.dev/time should be the first result, or a least on the first page
I believe this worked correctly even a few days ago.
What did you see instead?
Lots of other packages, many not even named time.

Duplicate of #47555


Update pkg-config and imagemagick

This PR will update the pkg-config package to include BSD support,
then update the imagemagick package to include BSD support.
This first commit only updates the pkg-config package,
once it passes CI checks, I will work on the imagemagick package.

The FreeBSD CI... can't find ./configure? That's odd, I downloaded and checked the tarball and it does indeed have it.

Oh wait, the shebang in ./configure has #! /bin/sh.
Does that exist on FreeBSD?

It looks like FreeBSD dropped all support for pkg-config back in 2012.
They use some tool called pkgconf now.
It might be better if I make a package for that, and use that for BSD packages that require pkg-config.

The FreeBSD CI... can't find ./configure?
That's odd, I downloaded and checked the tarball and it does indeed have it.

Sorry, I forgot this pr.
We should add bsd to the if condition of add_urls, otherwise no tarball will be downloaded, so the configure file will not be found.
    if is_host("macosx", "linux") then <--- add `bsd` here
        add_urls("https://pkgconfig.freedesktop.org/releases/pkg-config-$(version).tar.gz")
        add_urls("http://fco.it.distfiles.macports.org/mirrors/macports-distfiles/pkgconfig/pkg-config-$(version).tar.gz")
        add_versions("0.29.2", "6fc69c01688c9458a57eb9a1664c9aba372ccda420a02bf4429fe610e7e7d591")
    end

It looks like FreeBSD dropped all support for pkg-config back in 2012.
They use some tool called pkgconf now.
It might be better if I make a package for that, and use that for BSD packages that require pkg-config.

But most other autotools packages still rely on pkg-config. Is pkgconf compatible with pkg-config and can also be used automatically by autotools?

We should add bsd to the if condition of add_urls, otherwise no tarball will be downloaded, so the configure file will not be found.

Oh wow, I did not even notice that the urls were behind an if condition. My bad. :sweat_smile:

But most other autotools packages still rely on pkg-config. Is pkgconf compatible with pkg-config and can also be used automatically by autotools?

According to it's README, it should be.
It looks like all we need to do is set the PKG_CONFIG env variable to the path of pkgconf binary.

According to it's README, it should be.
It looks like all we need to do is set the PKG_CONFIG env variable to the path of pkgconf binary.

This looks like a good substitute. Maybe on bsd, it can work better.

This looks like a good substitute. Maybe on bsd, it can work better.

From what I can tell, it's recommended over pkg-config on FreeBSD.
So this PR will focus on adding BSD support to pkg-config and imagemagick.
Then I'll make another PR adding pkgconf, and edit the imagemagick package to use it over pkg-config.

Should be ready now. All CIs are passing.

ok, thanks!


Modify to new Slack API.

I found that web hook API is modified.
This implementation should be compatible current slack webhook api.

Please merge that

When do you guys plan to merge this?

Sorry about this, I didn't see this PR, merging now.


[SPARK-12471] [Core] Spark daemons will log their pid on start up.

Test build #48133 has started for PR 10422 at commit 4eaee2c.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48140/
Test FAILed.

Test build #48133 has finished for PR 10422 at commit 4eaee2c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * case class Range(\n  * case class Range(\n

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48133/
Test FAILed.

Should we add this to the SignalLogger and just use the SignalLogger everywhere?

Test build #48209 has started for PR 10422 at commit a74ac7e.

Test build #48209 has finished for PR 10422 at commit a74ac7e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48209/
Test PASSed.

Merged build finished. Test PASSed.

LGTM.

Merging in master.


NIFI-1900: Verify that connection's destination is not running when t…

…rying to change destination

Reviewing...

+1 LGTM, reproduced the error then applied the patch and retested, verified that a connection cannot be moved if its destination has active threads (even if stopped).


[FEATURE] Enable memory tracking on regression tree algorithms (single-target and multi-target)

The classification version of Hoeffding Tree implements mechanisms for ensuring the memory usage of the models does not exceed a chosen maximum. This action is implemented by the enforce_tracker_limit function and follows the ideas of Richard Kirkb et al. (2007). The function manages inactive and active learning nodes according to the current memory usage. Next, the mentioned function is presented:
https://github.com/scikit-multiflow/scikit-multiflow/blob/e054d7fbd6c9d6c781a4dd6843329ad748880a22/src/skmultiflow/trees/hoeffding_tree.py#L1299-L1328
The regression tree algorithms invoke the enforce_tracker_limit in the same way as in the classification tree, but they do not implement this method.

Single-target regression:

https://github.com/scikit-multiflow/scikit-multiflow/blob/e054d7fbd6c9d6c781a4dd6843329ad748880a22/src/skmultiflow/trees/regression_hoeffding_tree.py#L593-L594

Multi-target regression:

https://github.com/scikit-multiflow/scikit-multiflow/blob/e054d7fbd6c9d6c781a4dd6843329ad748880a22/src/skmultiflow/trees/multi_target_regression_hoeffding_tree.py#L821-L822
Would the solution be just removing the current implementations for regression (with the pass statement) and letting the implementation of the Classification Hoeffding Tree be used instead?
Does anyone have some opinion on that matter?

I don't think this is straightforward. My first concern arises from this line:
https://github.com/scikit-multiflow/scikit-multiflow/blob/e054d7fbd6c9d6c781a4dd6843329ad748880a22/src/skmultiflow/trees/hoeffding_tree.py#L1309
The promise calculation is specific for classification. What would be the proper/analogous way to do this for regression?

You are right. The promise calculation takes into account the distribution of the classes in each leaf node. I thought this decision would be simpler to implement. As you mentioned, defining the likelihood of a node being split is not a straightforward decision.
I have some ideas regarding that question. Maybe some procedure considering the variance of the data in the current node could be a starting point. For example, we could reason that higher variances in a node would imply in a high potential for a split. But for sure, that is not a simple matter.
I will perform a little bit of research on this subject, and try to come with a possible solution. Any other ideas are welcome!

Are there any updates on this? I like the idea of using the leaf's variance since it is straightforward. We could also consider the count of observed samples.

I recently performed some preliminary tests, and it seems that the linear correlation could be a better option.
Nevertheless, to calculate correlations incrementally, the trees would have to also monitor an additional statistic: the sum of the feature values times the target. This change is not straightforward anymore since multiple parts of the Hoeffding Tree regressor code must be changed.
Nevertheless, I intend to perform other tests using as, you mentioned, the count of observed examples, for example.


Set Java 8 release compiler option

Use --release flag to target JDK 8 bytecode compatibility
My recent change to capture HTTP requests contained a fascinating bug resulting in the bug-fix not working when running on JVMs <= 1.8 due to a NoSuchMethodError being thrown when this line executes.  This was incredibly surprising to me, because the position(int) API exists on Buffer (the superclass of ByteBuffer ) in java 1.8, so why do we have problems here? Confused, I did a quick google search and found an incredibly helpful article right away: ByteBuffer and the Dreaded NoSuchMethodError. The tl;dr of this change is that, the bytecode we produce prior to this change  looked like this:
BEFORE
  public static void handleRead(java.nio.ByteBuffer, int, org.hypertrace.agent.core.instrumentation.SpanAndBuffer);
    descriptor: (Ljava/nio/ByteBuffer;ILorg/hypertrace/agent/core/instrumentation/SpanAndBuffer;)V
    flags: (0x0009) ACC_PUBLIC, ACC_STATIC
    Code:
      stack=3, locals=6, args_size=3
         0: iload_1
         1: ifgt          5
         4: return
         5: aload_0
         6: aload_0
         7: invokevirtual #23                 // Method java/nio/ByteBuffer.position:()I
        10: iload_1
        11: isub
        12: invokevirtual #24                 // Method java/nio/ByteBuffer.position:(I)Ljava/nio/ByteBuffer;

AFTER
 public static void handleRead(java.nio.ByteBuffer, int, org.hypertrace.agent.core.instrumentation.SpanAndBuffer);
    descriptor: (Ljava/nio/ByteBuffer;ILorg/hypertrace/agent/core/instrumentation/SpanAndBuffer;)V
    flags: (0x0009) ACC_PUBLIC, ACC_STATIC
    Code:
      stack=3, locals=6, args_size=3
         0: iload_1
         1: ifgt          5
         4: return
         5: aload_0
         6: aload_0
         7: invokevirtual #23                 // Method java/nio/ByteBuffer.position:()I
        10: iload_1
        11: isub
        12: invokevirtual #24                 // Method java/nio/ByteBuffer.position:(I)Ljava/nio/Buffer;

Spot the difference? The bytecode for this snippet is identical, but when compiled without the --release 8, the invokevirtual #24 call refers to a method reference in the constant pool with a signature matching the descriptor Method java/nio/ByteBuffer.position:(I)Ljava/nio/ByteBuffer. However, when we compile it with the --release 8 flag the method reference in the constant pool is Method java/nio/ByteBuffer.position:(I)Ljava/nio/Buffer. This resolves the cross-jre compatibility issue of using the ByteBuffer.position(int) API because  Method java/nio/ByteBuffer.position:(I)Ljava/nio/ByteBuffer does not exist on JDK 1.8 or below.
Other notes
It's worth noting that this has impacted many well-known open source projects. The blog i linked above links to several other projects that encountered this exact issue:

Eclipse Jetty
Apache Pulsar
Eclipse Vert.x
Apache Thrift
the Yugabyte DB client
Debezium (the project the author found the bug on)

The author also evaluated other methods of resolving this issue and verifying that it couldn't happen again, and determined the --release flag was the best option:

Note that theoretically you could achieve the same effect also when using --source and --target; by means of the --boot-class-path option, you could advise the compiler to use a specific set of bootstrap class files instead of those from the JDK used for compilation. But that’d be quite a bit more cumbersome as it requires you to actually provide the classes of the targeted Java version, whereas --release will make use of the signature data coming with the currently used JDK itself.

we should start testing against JVM 8 and 11. Can you file a ticket for it?

Agreed, but this is definitely an interesting one as this code compiles and works properly when compiled and run on 1.8, just not when it was compiled with 11 and run on 1.8. I think we'd want to leverage gradle's support for toolchains to register a test task that uses a different jvm to run the tests than the one used to compile the instrumentation module. Did you have an idea of how this might look?

We should be building with Java 11 and using --release=8 as this PR does. Then define matrix build and test against all supported LTS versions (8, 11)  and the latest release (16).

Yeah that makes sense, I'm just curious if you had any other ideas for how that might be implemented in practice. The simplest option (to me) would seem to be using the GitHub actions setup-java matrix to run the tests in the instrumentation module across multiple JREs after compiling on 11. However, when running the test task on a different JDK, Gradle would detect changes and recompile, making it difficult to detect niche bugs like this one. How are you envisioning coercing Gradle to compile with one JDK and run tests with a different JDK?


xref with keydef generating wrong link

I created a keydef for an image:
<keydef keys="caution_image"          href="../media/images/caution.png"         format="png"/>
and then referenced it in content:

<image keyref="caution_image"/>

<xref keyref="caution_image">Download</xref>

The url for the image is created correctly:

but the url for the xref doesn't have the correct relative url:

Download

Is this a bug in the toolkit? or is the source wrong? I have added the files below - I tested with 2.2.2

dita-bug.zip

Sounds very much like what @shaneataylor describes here.

Note that having a cross reference to an image doesn't make any sense--an image is not a thing you can usefully navigate to.

Note that having a cross reference to an image doesn't make any sense--an image is not a thing you can usefully navigate to.

You could have a cross-reference to something like a PDF file, though, and this bug affects that scenario as well.
There's multiple issues here. One is that keydefs that point to non-external non-DITA resources aren't resolved correctly. Tacking something like this on top of #2223 should fix the issue (untested — this is more like a reminder-to-self type of thing):
diff --git a/src/main/java/org/dita/dost/writer/KeyrefPaser.java b/src/main/java/org/dita/dost/writer/KeyrefPaser.java
index e344070..d47652f 100644
--- a/src/main/java/org/dita/dost/writer/KeyrefPaser.java
+++ b/src/main/java/org/dita/dost/writer/KeyrefPaser.java
@@ -402,6 +402,12 @@ public final class KeyrefPaser extends AbstractXMLFilter {
                                     final URI f = currentFile.resolve(targetOutput);
                                     normalProcessingRoleTargets.add(f);
                                 }
+                            } else if (!ATTR_FORMAT_VALUE_DITA.equals(elem.getAttribute(ATTRIBUTE_NAME_FORMAT))
+                                    && !ATTR_SCOPE_VALUE_EXTERNAL.equals(elem.getAttribute(ATTRIBUTE_NAME_SCOPE))) {
+                                valid = true;
+                                final File topicFile = toFile(currentFile.resolve(stripFragment(keyDef.source.resolve(href))));
+                                final URI targetOutput = URLUtils.getRelativePath(currentFile, topicFile.toURI());
+                                XMLUtils.addOrSetAttribute(resAtts, refAttr, targetOutput.toString());
                             } else {
                                 valid = true;
                                 final URI targetOutput = normalizeHrefValue(href, elementId);

Another is that such keydefs are added onto the map/topic list for some reason:
λ : tail temp/.job.xml
    <string>false</string>
  </property>
  <files>
    <file src="file:/Users/eerohele/Git/dita-ot-issues/fixtures/1951/media/images/caution.png" uri="media/images/caution.png" path="media/images/caution.png" format="dita" resource-only="true"/>
    <file src="file:/Users/eerohele/Git/dita-ot-issues/fixtures/1951/root.ditamap" uri="root.ditamap" path="root.ditamap" format="ditamap"/>
    <file src="file:/Users/eerohele/Git/dita-ot-issues/fixtures/1951/content/test.dita" uri="content/test.dita" path="content/test.dita" format="dita" has-keyref="true" non-conref-target="true" target="true"/>
    <file src="file:/Users/eerohele/Git/dita-ot-issues/fixtures/1951/defs/defs.ditamap" uri="defs/defs.ditamap" path="defs/defs.ditamap" format="ditamap" resource-only="true"/>
  </files>
</job>

Which will cause errors in the debug-filter stage:
     [java] debug-filter:
     [java]    [filter] Using Xerces grammar pool for DTD and schema caching.
     [java]    [filter] Processing file:/Users/eerohele/Git/dita-ot-issues/fixtures/1951/media/images/caution.png
     [java]    [filter] Invalid byte 1 of 1-byte UTF-8 sequence.

Which in turn will cause the image (or other referenced file) to be corrupted in the output. Didn't get to the bottom of that yet, though.

Probably resolved in https://github.com/dita-ot/dita-ot/commit/3612e55aab141e664a78c2720e65b8a5759eae9b

Fixed with #3234


The Portal Doesnt Work

So I Made The Portal And I Activated But It Doesnt Take Me To The Aether Dimension

Currently the small portal given to you on world creation is the only portal that works.


Add more advanced features for groups

Nowadays structurizr allows creating groups of elements, but with some limitations:

It is not possible to create nested groups
It is not possible to create relationships using groups (element from/to group, group from/to group). At least I was not able to make it working.
An element cannot be part of more than one group.
When defining a group, we need to explicitelly list the elements in the group. We cannot create a group based on tags.
They are automatially displayed. There is no option to decide if we want to group or not elements in a view. Or even select the specific grouping we want to see.

It would be great if we remove these limitations, allowing creating views like this:

Layers: I could create some groups representing layers: Experience Layer, API Layer, .... and I could include elements in the group based on tags. Then, when rendering, I could see the elements together within the same layer.
Domains: I could also create some groups representing domains: Consumer, Products, Orders, ... and I could include elements based on tags. Notice that a speficic element would be part of a Domain and Layer group, so in this view I would like to only group based on Domain and not on Layer.
Ownership: In a very high level, I could group elements by owner areas within a big organization, having groups of groups. I could represent some elements in a group are connected to others in another group, without adding specific relationship between elements.

In case you think there is another recommended to get it, please let me know. Thanks!

You're correct, the groups feature is just a way to group elements at the same level on a diagram. Removing these limitations essentially requires redeveloping the entire way that Structurizr works ... i.e. moving away from having a predefined set of abstractions (software systems, containers, and components) to an arbitrary set of hierarchical abstractions, with zooming and implied relationships at all levels. To set expectations, it's very unlikely this will happen I'm afraid.

Thanks Simon for quick response. I undertand your concerns, but before rejecting let me clarify something: I'm not suggeting different levels of abstractions, I do want to keep using the level of abstractions defined in C4 model. I'm suggesting these new features for groups just to have a way to group elements in the view based on some criteria. The views I described (Layers, Domains, Ownershop) are just the result we could get by using groups in the predefined set of abstractions. For example, let's say I have a System Context Diagram with big number of systems. I could create groups representing domains in a way I would see the containers grouped based on domains, so that would be easier to understand. Alternatively, or even additionally (as described in my request), I could decide on creating groups representing layers in a way I would see the systems grouped based on layers, so that would be easier to understand.  The same example could be valid for a Container Diagram.
In fact, I can patically achive that nowadays by creating groups, but with the limitations described.

I'm not sure I understand what you're asking in that case. Let's look at this piece by piece.

I could create groups representing domains in a way I would see the systems grouped based on domains, so that would be easier to understand.

This seems possible with the current functionality - what's missing for you here?
workspace {

    model {
        1 = group "Domain 1" {
            a = softwareSystem "A"
            b = softwareSystem "B"
        }
        2 = group "Domain 2" {
            c = softwareSystem "C"
            d = softwareSystem "D"
        }

        a -> b
        b -> c
        c -> d
    }

    views {
        systemLandscape {
            include 1 2
            autoLayout lr
        }
    }

}

Makes sense, let's go step by step. So, starting from your example, let's say that in addiction to landscape view grouping by domains, I want to create an separate landscape view grouping by layers. Then, for example, I would like to be able to create 2 new groups: Layer 1 and Layer 2 adding A+C and B+D, respectively. Then, the additional Landscape view would show:

So, for now, it is refering to some of my points:

An element cannot be part of more than one group.
They are automatially displayed. There is no option to decide if we want to group or not elements in a view. Or even select the specific grouping we want to see.

It's a similar reason to why I've resisted creating view-specific styling (i.e. styles that are only used on a single view) ... I want the views to show a consistent representation of the model. Creating an alternative version of the model, with different groupings can be done using the workspace extensions feature though, for example:

Base workspace with no groups
Domain groups
Layer groups

Interesting! Honestly, I was not aware of that feature. Thanks for sharing. I'll explore it.
Let me then come to the next step
Let's assume I can achive my goals using the workspace extension feature. Then, on the new workspaces for Domains and Layers I would need to add the elements to the specific groups. In the example you shared, they are selected one by one. It would be great to add elements in a group based on tags. So, in the original workspace I can use the tags like "domain_1", "domain_2", "layer_1", "layer_2", and the views in the extended workspaces would automatically group elements accordantly. What do you think?
This is related to my point:

When defining a group, we need to explicitelly list the elements in the group. We cannot create a group based on tags.

Including elements by tag is very useful for views, where you only want to show a subset of the model. Having different groups is really about manipulating the model though ... and once you get to that stage, it's possibly time to break out of the DSL and into code. For example, with the Java client library and DSL parser as dependencies, you can do something like this:
    public static void main(String[] args) throws Exception {
        StructurizrDslParser parser = new StructurizrDslParser();
        parser.parse(new File("base-workspace.dsl"));
        parser.getWorkspace().getModel().getSoftwareSystems().stream().filter(ss -> ss.hasTag("Layer 1")).forEach(ss -> ss.setGroup("Layer 1"));

        // ...
    }

Sorry for the delay in my response. I see, thanks for sharing.
I've been rethinking about this topic and wanted to share my thoughts: I have the feeling we can see groups from two different perspectives (probably two separate concepts).
On one hand, I fully agree with you on having groups as part of the model: for example, grouping systems in ecosystems, grouping containers in subsystems, grouping components in modules. I do have some usecases of groups in that sense, and some part of my initial request (for supporting relatioships and nested groups) are related to this concept of group. In this case, I also agree with you that doesn't make sense to implement a way to add elements to a group based on tags.
On the other hand, there are some other usecases in which I see "grouping" (maybe we should use a different name) as a view feature, not part of the model, in which I'm basically interested on keeping elements together according to some criteria. In parctice, it would be like disabling autolayout and reorganizing the elements to manually group all of them according to that spefific criteria. From my view, this feature would help a lot and would provide lot of flexibility. In this case, as a "grouping" feature on views, creating "groups" based on tags makes more sense.
You know already shared some concerns related, but I would appreciate your feedback on this high level proposal

It's a similar reason to why I've resisted creating view-specific styling (i.e. styles that are only used on a single view) ... I want the views to show a consistent representation of the model. Creating an alternative version of the model, with different groupings, can be done using the workspace extensions feature though, for example:

Base workspace with no groups
Domain groups
Layer groups

I wanted to view the examples for the Domain Groups and Layer Group do not work anymore.
Both yield and error:
The element is already registered with an identifier of "a" at line 5: softwareSystem "A"
@simonbrowndotje Could you provide new versions?

It doesn't look like this works any more ... feel free to raise a new issue.

Since the discussion on extending features for groups is still open, I'd like to ask, if you consider to add the capability to set the background color of the box of the group or other stylings.
We are looking into using groups for different domains (as in the example in the comments above) - some simple coloring would be very handy and improve the readability of the diagram.
What do you think @simonbrowndotje ?

If you want to use nested groups you need to add in the model area addtional property

properties {
"structurizr.groupSeparator" "/"
}
List of properties available here
https://structurizr.com/help/properties


Changelog links and date format

In the readme.md file you made a wrong link to the changelog. And if it possible make changelog date format more readable. Example: July 25, 2016. Here is an example of changelog how facebook writes: React changelog example.

See #106


Add user sign up / log in feature

Add sign up and log in feature for users.

Please assign this issue to me with the "Hactober Fest" label


Anerdw: Watch projectserum.com

Anerdw requests the watch of the watch_keyword projectserum\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

projectserum\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Fastnlight in Charcoal HQ


[Feat]: Add "Getting Started" Button to Direct Users to Comprehensive Documentation and Feature Overview

What feature?
I am in GSSOC'23
I propose adding a "Getting Started" button to the ProjectHut website, which will provide users with easy access to a dedicated page containing comprehensive documentation and a detailed overview of the website's basic features. This feature aims to enhance user onboarding, improve user engagement, and provide a clear understanding of the platform's functionalities.
The implementation of this feature involves the following steps:
Button Placement: Add a prominently placed "Getting Started" button on the homepage, navigation bar, or any other relevant location where it is easily visible to users.
Getting Started Page: Create a dedicated page that serves as the entry point for new users. This page will provide a comprehensive overview of the website's basic features, functionalities, and their benefits. Include detailed documentation, guides, and tutorials to assist users in getting started with the platform.
Feature Description: Clearly describe the core features of the website, including project sharing, project filtering, sorting, project details page, project discussion forum, project ratings, collaboration tools, user profiles, and any other significant features. Explain how each feature enhances the user experience and contributes to the overall functionality of the platform.
UI Showcase: Include screenshots or interactive elements that showcase the website's user interface (UI). Highlight the visually appealing design, intuitive navigation, responsive layout, and the use of ReactJS and TailwindCSS to create a seamless and user-friendly experience.
Documentation: Provide detailed documentation that covers the various aspects of using the platform, such as account creation, project submission, collaboration tools, project management, and any other relevant topics. Include code samples, step-by-step instructions, and best practices to help users navigate and utilize the platform effectively.
Benefits and Value Proposition: Clearly communicate the advantages and benefits of using ProjectHut for open-source projects. Emphasize the platform's unique selling points, such as increased project visibility, streamlined collaboration, and a vibrant community. Highlight how ProjectHut simplifies the process of project sharing and fosters a collaborative environment for developers.
By implementing the "Getting Started" button and creating a comprehensive documentation and feature overview page, we aim to provide users with a clear understanding of the platform's functionalities and facilitate a smooth onboarding experience.
I'm excited to contribute to this feature and improve the user experience on ProjectHut. Your feedback and guidance on the content and presentation of the "Getting Started" page will be greatly appreciated.
Thank you for considering this proposal!
Add screenshots
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@exploring-solver please try to add valid points don't add unnecessary points.
also, we already have a docs page & ig we don't need to add this button.


404 when I try to download the resources

The link in the Getting Started page is returning a 404
https://raw.githubusercontent.com/google/code-prettify/master/distrib/prettify-small.tgz

#479

There seems to be a .zip available here
https://github.com/google/code-prettify/blob/master/distrib/prettify-small.zip

yep, forgot to update the docs. ZIP file is still provided.
Closing as duplicate of #479.


Add Option to Package App as a Standalone Executable

Please support packaging to a Standalone Executable.
This would add an additional layer of source code protection in conjunction with the --asar option and it will simplify launching the application; people could just download the app and run it without having to poke around hunting which file is the executable.

This is outside the scope of Electron Packager, which only customizes the prebuilt Electron binary and optionally bundles the source code in the asar format. You want to create a distributable file (such as an installer) which is handled by other modules.

@malept :+1:  Thanks for the link.
Please help me with my terminology. What do you call what I'm looking for?
I'm not looking for an installer, I'm looking for something that produces one executable file, that does NOT "install" the electron app.
Instead, this single solitary file contains within it all dependencies needed to just simply launch the program upon double-clicking it the file.

This is probably a "portable app", although by default, Electron apps write configuration to the user's config directory, as it's based on Chromium.


Autoprune - checkpoints not always moved

I've noticed an issue when I add checkpoints to the Autoprune folder. Sometimes when it processes them it will remove them from the folder but other times it doesn't. When I then restart the UI, it will create a new copy of the checkpoints.

Windows seems to be locking the file which prevents it from being deleted. What types of models are being left behind? Just .safetensors or is it random?

I suspect the safetensors library is leaving a file handle open somehow, so ive changed to a different loading in 3bdd18475d363095db2cbc44c2a9658d144cf3d9. Could fix it.

I only tend to use files in .safetensors format. I'll try the fix. Thank you.

I tested with 8 .safetensors files. 5 were removed and 3 failed.

I will have to boot up windows and see if i can replicate the issue. Another thing it could be is an antivirus, they scan files that get opened which may be locking them.

I am presently having this issue, also on Windows.
No antivirus that would be scanning them, and I see no access to the file other than python. I haven't noticed any pattern to the files affected, although I also haven't been watching them too closely.


Update FactorialOfANumber.py

Description
I had modified the code so now it will only work for positive no. only
Issue No.- #217

Type issue number after hash(#)

Checklist

[x] Yes, this task assigned to me.
[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] My Filename is in camelCase format
[x] I have added Problem statement, Problem link in file.

Please mention the correct issue number.

Hey sorry for the mistake I had corrected it please review. its issue  #323
Thank You


Revert "[MXNET-979] Add fix_beta support in BatchNorm (#12625)"

This reverts commit 0bab6d529343f0ce186859ba75c9bb02067e9cfe.
Because master branch started to fail with this change.
I have created a PR with the fix - https://github.com/apache/incubator-mxnet/pull/12788
If PR 12788 is not fixing the issue, does not pass CI and unable to merge, I would like to revert the changes by merging this PR and bring master builds to green.
[Do not merge this if https://github.com/apache/incubator-mxnet/pull/12788 build is green and merged]
@zheng-da

I am taking the liberty to merge this change as an important change for the following reasons:

I was unable to get the issue fixed in PR. I will be taking more time to root cause as the same tests are passing on Python2 but fail on Python3 - https://github.com/apache/incubator-mxnet/pull/12788
Master builds are failing.
All PR tests are failing.
Not sure why this PR tests passed during PR stage. Need to root cause why CI did not catch this failure.


Assorted surgeries to make material more accessible for new people

Moving things around to make them more intelligible to new people joining the team with less context (including both 18F people and contractors/vendors)

This should be sufficient to address #2. @afeld or @dlapiduz, want to review?

This all looks great @mogul 🎉 I'll merge it in.


Bugs with address generation

Any kind of preview methods should use newAddress.peek() rather than newAddress.new() since new() increments the index in bdk.
If new() is being used, the address must be saved in the wallets Addresses so that when a new wallet is created the previewed address is included.
Currently, when a coldcard is imported for example, the preview before import shows the correct first address but once the wallet is loaded, it starts generating addresses from an incremented index.

Fixed.
Note: currently displaying address index to debug while wallet update refactor is ongoing.


QuickPick.onDidChangeActive fires before QuickPick.onDidChangeValue on a value change

I would expect that QuickPick.onDidChangeValue would fire before any other events when the value of the input changes.

This seems to happen because this.ui.list.onDidChangeFocus fires before this.ui.inputBox.onDidChange... how could I control the order of events? 🤔


OP-18325 : Mapping query params for argo projects listing API

https://devopsmx.atlassian.net/browse/OP-18325
We prefer small, well tested pull requests.
Please refer to Contributing to Spinnaker.
When filling out a pull request, please consider the following:

Follow the commit message conventions found here.
Provide a descriptive summary for your changes.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Add inline code comments to changes that might not be obvious.
Squash your commits as you keep adding changes.
Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.

This PR  triggered this build in this execution, please merge to master only if this succeeds:  https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01GHKC3SZS8H0ASSP8FYWKHNVY

SUCCESSFUL RunTests RESULT: Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 Reviewers ,  this PR did not cause the failures in  https://jenkins.opsmx.net:8181/jenkins/job/Dev-API-Automation-Test-GitPR/611/artifact/test-output/extentreport.html


feat: Build and publish pre-release Code extension versions

Closes #11026

r? @matklad
Any opinion about meeting this sooner (this week) rather than later (in February)?

bors r+
Let's create authentic nightly experience!


fix(wasm): turn off Parser::preserve_parens for the playground

Current dependencies on/for this PR:

main

PR #1498   👈

This stack of pull requests is managed by Graphite.

Merge activity

Nov 22, 6:45 AM: @Boshen merged this pull request with Graphite.


MapAssert allow for values

Feature summary
Improve matching only MapAssert Value Properties.
Example
I feel like this could be one statement
assertThat(cpCard.getAltIds())
  .as("AlternateId saved on card")
  .hasSize(1); // avoids getAltIds() possible NPE...

assertThat(cpCard.getAltIds().values())
  .as("AlternateId saved on Card")
  .first()
  .returns(LoyaltyCardsValueAltIdsValue.StatusEnum.ACTIVE, LoyaltyCardsValueAltIdsValue::getStatus);

It feels like I should be able to do something like. I tried a number of extracting but it all ended up more convoluted than 2 statements, or required a weaker static typing
assertThat(cpCard.getAltIds())
  .hasSize(1)
  .values()
  .first()
  .returns(...);

I slightly modified the formatting of your code snippets to better visualize each method call.
If I understand it correctly, the second snippet contains what you'd like to have.
With values, the following could be written:
assertThat(cpCard.getAltIds())
  .values() // returns AbstractCollectionAssert after calling Map::values
  .singleElement()
  .returns(...);

Would that satisfy your use case?

in this particular case sure. I just grabbed first() from the existing chain. I'm not certain though that there isn't another case that wouldn't need more. I guess it made sense to me that after grabbing values I'd be in the same context as the thing that works and so the API would be the same.

Ok, so let's add values as a start and see if any other concrete use cases arise.


Cumulative implementation

see issue #20

@SanderDevisscher , @stijnvanhoey : nice work.
I rebased from the master, then @SanderDevisscher applied the little changes in order to read correctly the new column names first_observed and last_observed and the spreading of type.
Finally, I further worked in order to increase graph aesthetics: now we can specify less x-labels in order to not have superimposition in facet graphs. I removed x_scale_stepsize from indicator_total_year() in order to add two parameters: x_major_scale_stepsize and x_minor_scale_stepsize. This results in better graphs and more adaptability while faceting.
The last version of .gitignore has been imported as well (no zip files from GBIF occurrence downloads and relative subdirectories even if this has no importance within this branch)
The .html file produced after knitting has been added so that you can see the final result as well. In this kind of repository focusing on workflows, the html are updated on GitHub (see other trias-project repositories like alien-macroinvertebrates)
After merging, I will

move the function indicator_total_year() to trias repository (further deployment of the function can be done from trias repo)
create a "fast" branch in order to udpate the Rmd: function sourcing instead of function writing

@stijnvanhoey : you requested changes, so no merging without your approval :+1:

I thought https://github.com/trias-project/pipeline/issues/18 would be integrated within this PR to have the concept of uncertainty explained in #18 would be taken into account. Is that something for a separate PR or am I missing something here?

@stijnvanhoey : I would prefer to solve it in a separate PR. My idea is the following:
put the function asap in trias repository/package so that the indicators html pages will look as they should and trias package as well.
Moreover, we don't have still a definitive answer by @timadriaens about #18. I will have time to speak to him next week. Once issue #18 is solved then I will add code to trias::indicator_total_year() function if needed.

@stijnvanhoey : the issue #18 has been closed.
I also found that the function was not calculating the cumulative sum.
I solved it, just a little change:
... %>%
  do(year = .data$first_observed:as.integer(format(Sys.Date(), "%Y")))

instead of ending at .data$last_observed.
Other minor change: we are interested to speciesKey, not just key: in this way we count at species levels (at least if all subspecies share same first_observed).
Once I move it to trias I go further in parallel with the other functions in order to improve the facet aspect (e.g. number of subplots per figure).
Your last review is more than welcome.

I will also resolve the conflicts after your review.

Thanks @stijnvanhoey. Yes, the idea is to move all functions in trias. Then, I would start a new branch here in order to finalize all indicator-related pipelines by using the right functions from trias package.


[AVM Module Issue]: Virtual Machine backup module scope cannot be null or empty

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Bug
Module Name
avm/res/compute/virtual-machine
(Optional) Module Version
No response
Description
module vm_backup 'modules/protected-item.bicep' = if (!empty(backupVaultName)) {
  name: '${uniqueString(deployment().name, location)}-VM-Backup'
  params: {
    name: 'vm;iaasvmcontainerv2;${resourceGroup().name};${vm.name}'
    location: location
    policyId: az.resourceId('Microsoft.RecoveryServices/vaults/backupPolicies', backupVaultName, backupPolicyName)
    protectedItemType: 'Microsoft.Compute/virtualMachines'
    protectionContainerName: 'iaasvmcontainer;iaasvmcontainerv2;${resourceGroup().name};${vm.name}'
    recoveryVaultName: backupVaultName
    sourceResourceId: vm.id
  }
  scope: az.resourceGroup(backupVaultResourceGroup)
  dependsOn: [
    vm_azureGuestConfigurationExtension
  ]
}

scope: az.resourceGroup(backupVaultResourceGroup)
If the backupVaultName is empty, backend should not process it, however scope is taken into consideration during deployment, because the backend throws back an error:
 Evaluation result of language expression '[parameters('backupVaultResourceGroup')]' is type 'Null', expected type is 'String'
Scope value cannot be empty or null.
(Optional) Correlation Id
No response

@attbusmolgroup thanks for bringing it up. I will look into it


docs: updated homepage, interfaces and reference architectures

Issue # (if applicable)
Closes #.
Reason for this change

Description of changes

Description of how you validated changes

Checklist

[x] My code adheres to the CONTRIBUTING GUIDE
[x] I have updated the relevant documentation (if applicable).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

I'm not sure about the ref arch inclusion here. Let's wait for @madcommit to comment before approval.


It Fixes Generation of API routes in Laravel 5.4 with Passport API Guard

If the routes as Passport API Guard setup It was returning unauthenticated.
this fixes that.
example command to generate
php artisan api:generate --routePrefix="api/*" --header 'Authorization: Bearer c8b10ace7d1ccaa21c38fef6d9c5a1716d4abeb2f25e95d9f377dc6eeab0d59510a43dbac23c8ca2' --force --useMiddlewares --actAsUserId=1

Codecov Report

Merging #202 into master will increase coverage by 0.3%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #202     +/-   ##
===========================================
+ Coverage     79.51%   79.82%   +0.3%
+ Complexity      206      205      -1
===========================================
  Files             7        7
  Lines           708      704      -4
===========================================
- Hits            563      562      -1
+ Misses          145      142      -3

Impacted Files
Coverage Δ
Complexity Δ

src/Mpociot/ApiDoc/Generators/LaravelGenerator.php
87.68% <ø> (+1.76%)
40 <0> (-1)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b1c502...ad445b1. Read the comment docs.


Some queries return JSONResultBatch result type, causing errors

It appears some queries return results as a JSONResultBatch, which causes issues as the connector assumes the format will be arrow.
Specific error:
RuntimeError: Received unknown result batch type <class 'snowflake.connector.result_batch.JSONResultBatch'>

The query in this case was SHOW TABLES;. Not sure if snowflake makes it clear what types of results we can get, if so we can add some validation to the connector to check the different types perhaps? (More than just arrow)
Validated that a normal query would return the proper result SELECT * FROM TABLE LIMIT 100, which worked.

Thanks @noyoshi for trying dask-snowflake out and raising an issue. Indeed it appears Snowflake will return JSONResultBatch objects in some scenerios. Perhaps @sfc-gh-mkeller has thoughts on how we should handle both JSONResultBatch and ArrowResultBatch objects. For example, today we're using the ArrowResultBatch.to_pandas method to retrieve a pandas DataFrame for the underlying batch -- what is the recommended way of doing this for JSONResultBatch?

So this is caused by the fact that Snowflake cannot always provide results in Arrow format. Currently only SELECT statements can generate Arrow result formats. Which is the only thing that our connector supports turning into data frames.
One workaround would be to execute your query and then use a result scan on its results, like:
with snowflake.connector.connect(
    ...
) as cnx:
    with cnx.cursor() as cur:
        cur.execute(f"SHOW TABLES")
        cur.execute(f"select * from table(result_scan('{cur.sfqid}'));")
        print(cur.fetchall())

Thanks for the additional context @sfc-gh-mkeller -- I hadn't realized that only SELECT statements were supported for turning results into DataFrames.
I could be missing something, but it looks like the snippet you posted might cause the entire query result to be loaded into memory -- is that the case?
Is there a standard way to convert a JSONResultBatch into a JSON blob? I'm wondering if we could convert these result batches to JSON and then use pandas' read_json function to convert into a DataFrame

That's right, @jrbourbeau
The snippet was only to show you how to work around this limitation.
I didn't mean for you to use it that way exactly, my apologies!
Not currently, unless you could convert the Python results yourself into DataFrames. I have never used read_json, but if it's that simple then you could try patching the following function: https://github.com/snowflakedb/snowflake-connector-python/blob/ffdd6b3339aa71885878d047141fe9a77c4a4ae3/src/snowflake/connector/result_batch.py#L525
I'd imagine that this might return different data types than what our Arrow converter does, but if this works at all I'd be happy to get us to take over and add a way to do this natively in our connector.


Fixed self-introduced numpad issue on Unix.

As discussed here I seem to have changed the wrong values when rebasing @mickelson's code.
Thanks @Hapaxia for spotting it and pointing it out!

:+1: :cat2:

:+1:

This PR has been added to my merge list, meaning it will be merged soon into the 2.3.x branch, unless someone raises any concerns.

We noticed some more inconsistency with the XK_* codes. It's not that important since it's just about the keys and not about the actual values.

Just so you know: on Debian 8.0 it appears the numpad keys are mapped to Key::NumpadX only when the Numlock is OFF, otherwise it's still "Unknown". Gonna test on my other Linux machine asap, but I expect the same behaviour.

I can confirm the same results as silverweed. The Numpad keys only work when numlock is turned off.


Status of Key Vault client for .NET 5 Core CLR

@herveyw
Was wondering if there is any status on getting https://github.com/Azure/azure-sdk-for-net/tree/master/src/KeyVault/Microsoft.Azure.KeyVault.Core for Core CLR (dnxcore50)?

@GuardRex
Its planned but won't happen until early next year.

Thx


Documentation improvement

Feature Request
I tried to find a way to handle notification in the foreground and I figure out modifying AppDelegate.m
This will trigger function onNotification when the app is shown. I think this can be implemented in the installation guide.
Why it is needed
This feature in nonrelevant for functional purpose. But this can help the developers to use as best he can this framework
Possible implementation
on Docs modify the AppDelegate.m
Code sample

In AppDelegate.m

-(void)userNotificationCenter:(UNUserNotificationCenter *)center willPresentNotification:(UNNotification *)notification withCompletionHandler:(void (^)(UIBackgroundFetchResult))completionHandler
{
  [RNCPushNotificationIOS didReceiveRemoteNotification:notification.request.content.userInfo fetchCompletionHandler:completionHandler];

  completionHandler(UNAuthorizationOptionSound | UNAuthorizationOptionAlert | UNAuthorizationOptionBadge);
}

Thank you @FrancescoPicazio ! This helped me.


How to run the multigp code?

There exists some errors while running some of the multigp code although some of codes in the multigp directories can run correctly.
After I downloaded the multigp、biglasso、collab、deepGP、drawing、GPmat、hsvargplvm、meu、multigp、netlab、SGPLVM、vargplvm directories and copied them to the Matlab directory. Then I clicked right button on these directories and choose "add to path" and then click "choosed directories and sub-directories". After these, I tried running some codes in the multigp directories. Some codes can run correctly while others can't.  Some examples are listed as follows.

While running toy1DGgFITCExample.m, it wouldn't go wrong until running to the line "save(['demSpmgp' capName num2str(experimentNo) '.mat'], 'model', 'initialLoc')" and sent a wrong message which is "can't find variable 'initialLoc'".
While running DemGgToy1.m, it wouldn't go wrong until running to the line "ggToyResults(dataSetName, experimentNo, XTemp, yTemp)" and sent a wrong message which is "undefined variable XGT".
While running demSpmgpGgToy5KL.m, it sent a wrong message which is "undefined function or variable 'addToolboxes'".
While running some other files, it may sent a wrong message which is "lacking of  'sarcos_inv.mat'" or other Loading error .
So I want to know how to solve these questions and run codes in the multigp directories correctly.

Hi,
If you want to start with the basic start with demGgJura download the database and run it.
Many samples had problems as there are multiple exercises and all databases are not provided.
Ggwhite toy also runs from the start


[FEATURE] Add Garena LoL inclusivity / Allow users to choose the LoL folder directly instead of finding Riot Games folder

Without any knowledge whether folder contents in the LoL folder are the same between the Garena and the Riot versions, I think the Garena LoL can be easily included by asking users to directly go to the LoL folder instead of strictly finding the "Riot Games" folder. The supposed Riot Games folder in Garena are named as some random numbers which I think indicate game version. The LoL folder has a different name, which is why I suggested the above change. I think the pictures explain it better.

Also I have trouble finding the appropriate directory format for long directories. Which format am I supposed to use? The first 2 crashes the software even before going into the main UI, while the last one cannot detect the League Client (which I think is the intended result). Still I wish to clarify the correct format.
D:\Garena\32771
D:\\Garena\32771
D:\\Garena\\32771

I have the same problem，I don't know what to write there


RangeError: Maximum call stack size exceeded

TSC 1.6.0

/usr/local/lib/node_modules/typescript/bin/tsc.js:35011
                throw e;
                ^

RangeError: Maximum call stack size exceeded
    at instantiateType (/usr/local/lib/node_modules/typescript/bin/tsc.js:16928:33)
    at instantiateList (/usr/local/lib/node_modules/typescript/bin/tsc.js:16795:33)
    at instantiateType (/usr/local/lib/node_modules/typescript/bin/tsc.js:16941:44)
    at instantiateList (/usr/local/lib/node_modules/typescript/bin/tsc.js:16795:33)
    at instantiateType (/usr/local/lib/node_modules/typescript/bin/tsc.js:16938:61)
    at getTypeOfInstantiatedSymbol (/usr/local/lib/node_modules/typescript/bin/tsc.js:15200:30)
    at getTypeOfSymbol (/usr/local/lib/node_modules/typescript/bin/tsc.js:15206:24)
    at inferFromProperties (/usr/local/lib/node_modules/typescript/bin/tsc.js:18200:40)
    at inferFromTypes (/usr/local/lib/node_modules/typescript/bin/tsc.js:18184:25)
    at inferFromTypes (/usr/local/lib/node_modules/typescript/bin/tsc.js:18122:25)

//another call

RangeError: Maximum call stack size exceeded
    at resolveStructuredTypeMembers (/usr/local/lib/node_modules/typescript/bin/tsc.js:15797:46)
    at getPropertiesOfObjectType (/usr/local/lib/node_modules/typescript/bin/tsc.js:15823:24)
    at instantiateAnonymousType (/usr/local/lib/node_modules/typescript/bin/tsc.js:16916:49)
    at instantiateType (/usr/local/lib/node_modules/typescript/bin/tsc.js:16935:25)
    at instantiateList (/usr/local/lib/node_modules/typescript/bin/tsc.js:16795:33)
    at instantiateType (/usr/local/lib/node_modules/typescript/bin/tsc.js:16938:61)
    at getTypeOfInstantiatedSymbol (/usr/local/lib/node_modules/typescript/bin/tsc.js:15200:30)
    at getTypeOfSymbol (/usr/local/lib/node_modules/typescript/bin/tsc.js:15206:24)
    at inferFromProperties (/usr/local/lib/node_modules/typescript/bin/tsc.js:18200:40)
    at inferFromTypes (/usr/local/lib/node_modules/typescript/bin/tsc.js:18184:25)

Can you include the code that causes the stack overflow?

It is difficult to include, because project is huge, I don't know where it happen. I investigate it

It looks like the issue is caused by infinite instantiation of generic types. You may want to try compiling with the latest compiler in master (npm install typescript@next). We have recently fixed a few bugs in that area.

Yeah, I have updated to TS next and stack overflow is fixed

Excellent. I will close this issue then.


v7.0.1 still contains a number of surprising changes

Even with 7.0.1, there are a lot of changes that cause a lot of churn.
@brendandburns updated Kubernetes to use commit 0984e0641ae43b89283223034574d6465be93bf4 (aka, )  of azure-sdk-for-go and had to make this many changes: https://github.com/kubernetes/kubernetes/pull/37783/commits/ea14bba4b2412c3403c4a1036348ae745bb93331
Is this expected? It looks like in a number of places, Properties was removed, or renamed. Maybe this is all due to flattening?
Also, the CHANGELOG wasn't updated for 7.0.1.

All that is because of flattening, yes.

@mcardosos @colemickens is this also going to become an issue when more API's are migrated towards Composite Swagger's out of interest?
There's a couple of really painful unannounced changes in v7.x - particularly with regards to CDN's - where the method signature has changed from (name, profileName, resourceGroupName) to (resourceGroupName, profileName, name). Given they both have the same types for the method signature - this compiled and I initially assumed all was well - luckily our acceptance tests caught this.
Is there anything we can do about documenting that kind of painful breaking change a bit better next time around? Submitting 231 files in a single commit (in the case of 7.0.1) makes it pretty hard to review for breaking changes tbh :)

Reopening for further discussion

Hey @tombuildsstuff,
I think your point is really really valid. As a team, we're working on some proposals that should address this and some of the other broader related issues. Expect to see some news next week.
For now, I'm going to close this issue. If you feel there is further discussion that needs to happen specifically with the v7.0.1 changes, feel free to open it back up.


douyin live

this mistake happened here, it shows that it couldn't snap douyin right now?

@luxcgo I see the same error, can you help to debug? Or teach me how to check if my ip is banned, or cookie is obsolete? Thank you!
INFO[2022-11-22 23:35:50] dispatch add monitor                          id=136999369331 pf=douyin
INFO[2022-11-22 23:35:50] dispatch remove recorder                      id=136999369331 pf=douyin
INFO[2022-11-22 23:35:50] monitor start                                 id=136999369331 pf=douyin
TRAC[2022-11-22 23:35:50] snap failed, fail to find url                 id=136999369331 pf=douyin
INFO[2022-11-22 23:35:50] split program starts...
INFO[2022-11-22 23:35:50] parser-monitor program starts...

btw, the bilibili works well.
And I see there's command biliup to generate cookie for bili, is there such command for douyin too?


client, ctr: allow specifying unmanaged rootfs dir

e.g. ctr run -t --rm --rootfs /tmp/busybox-rootfs foo /bin/sh
(--rm removes the container but does not remove rootfs dir, of course)
Signed-off-by: Akihiro Suda<EMAIL_ADDRESS>

Codecov Report

Merging #1182 into master will decrease coverage by 0.02%.
The diff coverage is 12.5%.

@@            Coverage Diff             @@
##           master    #1182      +/-   ##
==========================================
- Coverage   30.06%   30.03%   -0.03%
==========================================
  Files          28       28
  Lines        2292     2297       +5
==========================================
+ Hits          689      690       +1
- Misses       1454     1458       +4
  Partials      149      149

Impacted Files
Coverage Δ

spec_unix.go
61.79% <12.5%> (-1.01%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eadcb8...97ce1d9. Read the comment docs.

Why is this flag not just rootfs?

If we simply call it rootfs, containerd.WithNewRootfs (and its famiy) is very confusing as containerd.WithNewRootfs is used for managed rootfs

If we simply call it rootfs, containerd.WithNewRootfs (and its famiy) is very confusing as containerd.WithNewRootfs is used for managed rootfs

What is the difference here? We should set things up so that --rootfs can just be a rootfs. Any other details here are confusing and should be secondary (even if they are the default).

@AkihiroSuda Also, those do a new rootfs, vs this is just WithRootFS. Does that make sense or am I way off here?

ok, renamed WithNewRootFS -> WithNewSnapshotRootFS, WithUnmanagedRootFS -> WithRootFS

done @stevvooe

will rebase when https://github.com/containerd/containerd/pull/1249 is merged

@AkihiroSuda thanks!

rebased

I spoke to Stephen, it is fine to have this flag change the meaning of the first positional. The alternatives are not better and we don't want to infer the meaning of the reference. Please update the usage as requested and rebased and it looks good to me.

done

LGTM
@AkihiroSuda This will grow on me, I think!


Error of shapenet num_classes

🐛 Bug
I find out that the label of shapenet dataset is begin with 1, so num_classes of this dataset is always plus 1. Please check it, thank you!

Already fixed in master :)


Enable and configure Managed Identities for the AKS cluster using Terraform

Summary
Similar to what we do for EKS and are preparing for GKE, we want to define fine grained permissions for any cluster where Jenkins X will be installed.
An example for EKS can be found in the Jenkins-x module, here:
https://github.com/jenkins-x/jx-cloud-provisioners/blob/master/eks/terraform/jenkins-x/irsa.tf
Here we create IAM Policies and IAM Roles that will be used to annotate Kubernetes Service Accounts so any pod using these Service Accounts can assume the roles.
The idea is to configure the AKS cluster to use Managed Identities an have an easy way to define new Service Accounts and permissions.
For now, the Service Account being configured with IAM permissions should be:

tekton-bot: This is the Service Account that the pods running the builds use. The necessary permissions will be defined later.

Acceptance Criteria
Configure the AKS cluster to use Managed Identities and define an easy way to create and configure new Service Accounts with the necessary permissions.

This might be relevant in this context:

https://docs.microsoft.com/en-us/azure/aks/operator-best-practices-identity
https://github.com/Azure/aad-pod-identity

Just been looking in to this with regards to setting up Velero service accounts. Currently the fine-grained authorisation from a service account to Azure RM APIs is handled via the aad-pod-identity project. This attaches identities to pods directly using its CRDs and not service accounts. So the approach I've seen being used in GKE with service account annotations probably isn't going to work immediately here. For the Velero use case that I'm going to raise a separate ticket for this the aad-pod-identity can be used as the Azure Velero plug-in is MSI aware.
Feels like some more work required with AKS and its satellite open source projects to get service accounts associated with external identity contexts unless I'm missing something.

/area/aks

Closed by #34


How to add array param?

How to write like this, thanks!

  tags:
  - "pet"
  summary: "Finds Pets by status"
  description: "Multiple status values can be provided with comma separated strings"
  operationId: "findPetsByStatus"
  produces:
  - "application/xml"
  - "application/json"
  parameters:
  - name: "status"
    in: "query"
    description: "Status values that need to be considered for filter"
    required: true
    type: "array"
    items:
      type: "string"
    collectionFormat: "multi"

This is supported now. Please test and open an issue if is the case.
Example:
// @Param status query string true "Payload"


Add true multitouch trackpad support.

What problem does this solve or what need does it fill?
At present, trackpad events are captured as if the trackpad were a mouse. For example, on a MacBook Pro, events come in as a left mouse press / release event. The MacBook Pro trackpad is actually a multitouch display, however. Bevy should emit touches as if it were any other multitouch display, along with press / release events.
What solution would you like?
After talking to @alice-i-cecile, it seems the solution is to have Bevy emit touches (as if it were a multitouch display) and emit the mouse behavior if someone wants to opt into that default behavior. An example of what I'd like to accomplish using the trackpad is:

Pan the camera by dragging two fingers on the trackpad.
Zoom in and out by detecting pinch to zoom gestures.
Other multitouch gestures as things come up.

One potential issue is that the MacBook Pro trackpad touch events should support press / release states when your finger touches and releases from the screen, and also trackpad click events as the trackpad itself can be fully depressed. Both types of touches should be supported which might be an issue with the current Touches implementation:
pub struct Touches {
    /// A collection of every [`Touch`] that is currently being pressed.
    pressed: HashMap<u64, Touch>,
    /// A collection of every [`Touch`] that just got pressed.
    just_pressed: HashMap<u64, Touch>,
    /// A collection of every [`Touch`] that just got released.
    just_released: HashMap<u64, Touch>,
    /// A collection of every [`Touch`] that just got cancelled.
    just_cancelled: HashMap<u64, Touch>,
}

It may be that Bevy should have a Trackpad input abstraction for this case that supports both touch events and button-click events in one interface but I'm not sure. There may even be trackpads that support multitouch but also have separate physical buttons.
What alternative(s) have you considered?
For now, I'm getting around this by using keyboard shortcuts to zoom the world and holding a modifier key while dragging my finger on the trackpad for drag events which is not ideal.

Complete support for that needs to be done in winit: https://github.com/rust-windowing/winit/issues/2379. It's not really possible in Bevy without winit support.
Next version of winit will expose TouchpadMagnify and TouchpadRotate events (https://github.com/rust-windowing/winit/pull/2157). 2 fingers dragging already works and is detected as mouse wheel.

Yeah, I wasn't sure if Bevy should directly support gestures as they're totally up to the user, but I guess there are some common ones (pinch to zoom, drag with two fingers, etc.).

Complete support for that needs to be done in winit: rust-windowing/winit#2379. It's not really possible in Bevy without winit support.
Next version of winit will expose TouchpadMagnify and TouchpadRotate events (rust-windowing/winit#2157). 2 fingers dragging already works and is detected as mouse wheel.

Huh, I don't get any MouseWheel events when dragging with two fingers, at least on my MacBook Pro (or are you saying in winit, not Bevy)?

I get them with Bevy on my Mac, with example mouse_input_events

Huh, I don't get any MouseWheel events when dragging with two fingers, at least on my MacBook Pro (or are you saying in winit, not Bevy)?

Also works fine on my MBP. I don't see anything in system preferences that might break it, so this seems like it could be caused by another app?

Marking this as blocked until winit supports this.

Complete support for that needs to be done in winit: rust-windowing/winit#2379. It's not really possible in Bevy without winit support.
Next version of winit will expose TouchpadMagnify and TouchpadRotate events (rust-windowing/winit#2157). 2 fingers dragging already works and is detected as mouse wheel.

Hey, just stumbled upon this issue and it looks like winit now supports TouchpadMagnify and TouchpadRotate as of v0.28.0?
I'd be down to make a PR to support this in Bevy, although I'm not very familiar with the engine's internal's atm (I only started playing around with Bevy a few weeks ago 😅)

I believe those two events were added in https://github.com/bevyengine/bevy/pull/8791 :)

@james7132  @alice-i-cecile  This is no longer blocked

@james7132 @alice-i-cecile This is no longer blocked

Is it not? I was looking for a way to support two-finger drag, but Winit's features page still mentions multitouch as not implemented for macOS.

It seems like they maybe just forgot to update the feature matrix:
https://github.com/rust-windowing/winit/pull/2157


Perfect Numbers: update exercise

The tests for this exercise had severely deviated from the problem specification:
canonical-data.json
Unfortunately the large number tests take some time, but the range built off of the square root in the previous example did not yield a complete list of factors.  It could be worth it to find a more efficient method for getting the factors of a given number, but for now this at least gets the exercise up to spec.

I noticed, because I did the exercise today.

Not to be antsy, but is anybody interested in reviewing this?

Hey @guygastineau, I think my poor github notification management strategy caused this to fall off my radar. My bad! Ill get to this today!

No problem.

You're welcome.


[Site] Update demo pages

Add comment about DynamicForm install
Remove LICENCE from Codeblocs

(resolves #1207)

That was fast - thank you Simon!


Looking for a new maintainer

I used this for about a couple years at my old job. I personally don't have any production app using this (other then my personal blog website).
Maintenance needs:

Update and test when new Ember.js stable releases land.
Lead future development and improvements.
Update to docs and guides when changes warrant updates.

Mmmmm... I'm still using this, and probably will be for quite some time. But I'm reluctant to fully commit to maintaining, as I simply won't have the time to do a good job.
But, most recent and upcoming changes are my doing/requests, and I'm very willing to commit to those at least.
I guess what I'm saying is; I'd happily co-maintain this lib, and if no other option, fully maintain it.
Here's what I can commit to at least:

update/improve tests as to provide good/better tests for:
my PRs, and:
update docs & guides accordingly. And:
handle github issues, review PRs.

I guess that could be summed up as being a maintainer, but again, I don't have a lot of (free) time to handle this.


Text exercises: Allow text assessment when adblocker is running on browser

Checklist
General

[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Motivation and Context

Fixes #4989 issue.
Description

In this PR I changed resource name from api/analytics/ to /api/event-insights/ and therefore adblocker does not block text assessment API endpoint.
Steps for Testing

Prerequisites:

1 Instructor
1 Students
1 Text Exercise

Log in to Artemis as student
Navigate to text exercise and submit your solution
Then log in as instructor with adblocker extension
Navigate to assessment of the text exercise
Try to asses the exercise, it should asses without error

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Changed files:
src/test/java/de/tum/in/www1/artemis/TextExerciseAnalyticsIntegrationTest.java
src/test/javascript/spec/service/text-assessment-analytics.service.spec.ts
src/test/javascript/spec/service/text-assessment.service.spec.ts

When I search for the String "/analytics/" in IntelliJ, I find 16 occurrences. Why did you not include the others?

@JohannesStoehr I changed the api and api calls, but there are "/analytics/" strings across project because there are imports of analytics service and its imported as below:
import { TextAssessmentAnalytics } from 'app/exercises/text/assess/analytics/text-assesment-analytics.service';
And after my changes, I only find 9 occurrences in the project. Can you maybe upload a screenshot of occurrences?

And after my changes, I only find 9 occurrences in the project. Can you maybe upload a screenshot of occurrences?

You're right, sorry. Seams that I hallucinated some more...
But maybe we should also rename the import paths in the same way as the rest URLs, what's your opinion on that?

And after my changes, I only find 9 occurrences in the project. Can you maybe upload a screenshot of occurrences?

You're right, sorry. Seams that I hallucinated some more... But maybe we should also rename the import paths in the same way as the rest URLs, what's your opinion on that?

Okay, I thought about that and at the beginning i started renaming but, this leads to a lot of change like function names and variable names in backend as well as in frontend. There is a possibility that in the future adblocker might block also insights keyword inside the rest URLs, and therefore this will make maintenance difficult in the future so i renamed only the necessary places.
Changing everything does not make much sense to me because this api still does analytics so in my opinion we shouldn't. @JohannesStoehr  What do you think?


Add .xml.fr and .html.fr

In #1779, I tried to add samples for .xml.fr and .html.fr.  However, #1731 doesn't accommodate this, although that was probably the intent.
This tries to fix the bug.  New extensions and samples serve as test cases, but would also be nice to add.

@arfon @bkeepers So now that the first part of this PR is merged, thumbs up or down for the second part?

Example of misidentified files:
https://github.com/hlkzmy/windows-php-webserver/search?l=frege

Sorry for not helping push this forward. I'm a little uneasy about adding .html.rf as an extension for HTML when there are a bunch of other extensions that we would also have to add.
I took a stab at fixing this in https://github.com/github/linguist/pull/2009 by using all parts of the extension to get possible languages. The idea being then we would leave it up to the classifier to properly detect the right one.

Cool, I'll close this when your branch is merged.

I'm going to work on getting #2009 ready. But in the mean time, I'm going to go ahead and close this, because I don't think adding extensions for locales is the route we should go.


Support namespace URLs by regex

This will be a cleaner way of handling small variations of the namespace URL (e.g., https, trailing slashes).

Done.


Allow proxymanager v2 installation

This patch allows installation of ProxyManager v2.*
The changes are not breaking, but ProxyManager v2 has PHP 7 type-hints everywhere, which means that PHPUnit 5.* is required in order to mock them (specifically, PHPUnit 5.2.9+). This patch adds the required changes, as well as the polyfills required to have ProxyManager v2 behave like ProxyManager v1, configuration-wise

@weierophinney Any reasons why this PR is not already merged. The lazy_services setting write_proxy_files has no effect with ProxyManager 2.0.

@ocramius Patch looks good to me; feel free to merge and tag a release.

Included into 3.1.0 via zendframework/zend-servicemanager@d27e1092a7ed20f6894257168be33009175ef928


sync: init at 0.10.1

Description of changes
https://git.taler.net/sync.git
https://taler.net/en/news/2024-06.html
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 311933 run on x86_64-linux 1

1 package failed to build:

sync


Is there a way to control the fan speed?

Thanks for posting.  I managed to get pretty much as far as you with my H1735 however I am having no luck with fan speed control or other controls.  Just wondering if you had any luck with that?

Nevermind! I overlooked it!
Thanks


Unauthorized error when creating the check

Not sure if this is a problem with this code or with the setup of our repo, but I thought I'd reach out to see if you had any insight. I'm getting a Unauthorized error, and when I lookup the (docs on the permissions)[https://developer.github.com/v3/checks/runs/#create-a-check-run] it says "Your GitHub App must have the checks:write permission to create check runs."
Any idea how Github Actions relate to this permissions-wise? Thanks!
https://github.com/workarea-commerce/workarea/runs/204931063#step:6:13

@bencrouse you need to add your github token to the environment. Here is some documentation I found helpful when I hit this error.
Ex:
- name: Rubocop checks
  uses<EMAIL_ADDRESS>  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Note: if you are using any dependencies of rubocop like rubocop-rails, rubocop-performance, etc. this action will not work for you. I am working on cooking up my solution for these cases.

Ok perfect, thanks for responding.

I also hit this. I copied the suggested code from github, perhaps this env should be added to the instructions too?

Although I can't see any code in this repo setting that, assuming that's just a default github thing?

And for future readers: I also went through the docs setting up a personal github token for this, before I realised github actions automatically generates one for me.


rc-9front: init at unstable-2022-11-01

Description of changes
There exists a nixpkg already for another lineage of the rc shell.
The rakitzis shell is a re-implementation that has been out of the plan9 tree for quite a while now.
This package provides a unix port of the current 9front rc shell, which has been maintained, bug fixed,
and hacked on as part of 9front.
There are enough little differences in design and implementation that I thought it would be alright to purpose this as an alternative.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 240232 run on x86_64-linux 1

1 package built:

rc-9front

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2381


update links to openmetrics to reference the v1.0.0 release

Related to https://github.com/prometheus/OpenMetrics/issues/287
The OM 2.0 effort is kicked off, and will start developing on main. This updates the links to OpenMetrics to reference the 1.0 release. The OM project has also been moved into the prometheus github org.

The auto-merge folder is a scripted merging process from the opentelemetry-js, opentelemetry-js-contrib folders and should not be updated manually -- I've just kicked off a new automated merge.