Add equality and diversity response rate to the feature metric dashboard

Context
So that Support users can easily view the rate of E&D survey completion, this value needs to be exposed on the Feature Metrics Dashboard.
Changes proposed in this pull request
This PR achieves this in much the same way as: https://github.com/DFE-Digital/apply-for-teacher-training/pull/4663

Guidance to review
Please test in review app.
Link to Trello card
https://trello.com/c/dSrr6jRd/3375-add-equality-and-diversity-response-rate-to-the-feature-metric-dashboard
Things to check

[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] This code does not rely on the addition/removal of Azure config environment variables in the same Pull Request
[x] New environment variables have been added to the Azure config

The code looks good George. I've just got one question on the scope of which application forms we include. I'm interested to hear what you and other people think.


HBASE-23129 Move core to use hbase-thirdparty-3.1.0

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
1m 14s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:yellow_heart:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

:blue_heart:
mvndep
0m 44s
Maven dependency ordering for branch

:green_heart:
mvninstall
5m 44s
master passed

:green_heart:
compile
3m 14s
master passed

:green_heart:
shadedjars
5m  3s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
3m 13s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 24s
Maven dependency ordering for patch

:green_heart:
mvninstall
5m 35s
the patch passed

:green_heart:
compile
3m 17s
the patch passed

:green_heart:
javac
3m 17s
the patch passed

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

:green_heart:
shadedjars
4m 56s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
17m 15s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
javadoc
3m 11s
the patch passed

_ Other Tests _

:broken_heart:
unit
10m  3s
root in the patch failed.

:green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

71m 11s

Reason
Tests

Failed junit tests
hadoop.hbase.shaded.protobuf.TestProtobufUtil

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-695/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/695

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux d941bf3d7f2e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-695/out/precommit/personality/provided.sh

git revision
master / 10180e232e

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-695/1/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-695/1/testReport/

Max. process+thread count
282 (vs. ulimit of 10000)

modules
C: hbase-common . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-695/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

HBase will use hbase-thirdparty 3.1.1 once it is released, right?

Yes. Need to update this patch when it is out. Thanks for review @petersomogyi

This latest push has been pointed at the just-released 3.1.1 hbase-thirdparty (Thanks @petersomogyi )

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:yellow_heart:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

:blue_heart:
mvndep
1m  4s
Maven dependency ordering for branch

:green_heart:
mvninstall
5m 48s
master passed

:green_heart:
compile
3m 14s
master passed

:green_heart:
shadedjars
4m 52s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
3m 17s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 24s
Maven dependency ordering for patch

:green_heart:
mvninstall
5m  9s
the patch passed

:green_heart:
compile
3m  0s
the patch passed

:green_heart:
javac
3m  0s
the patch passed

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

:green_heart:
shadedjars
4m 54s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
17m 38s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
javadoc
3m 20s
the patch passed

_ Other Tests _

:broken_heart:
unit
183m 24s
root in the patch failed.

:green_heart:
asflicense
1m  1s
The patch does not generate ASF License warnings.

244m 30s

Reason
Tests

Failed junit tests
hadoop.hbase.regionserver.TestBulkLoadReplication

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-695/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/695

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux d86a81685945 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-695/out/precommit/personality/provided.sh

git revision
master / fd9cfd789b

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-695/2/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-695/2/testReport/

Max. process+thread count
4700 (vs. ulimit of 10000)

modules
C: hbase-common . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-695/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

Rerunning build. The failure does not look related. I tried locally and indeed it failed... but then it started passing and kept passing.  It shows in our flakey dashboard but it is not too healthy these times: https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/HBASE-22514/lastSuccessfulBuild/artifact/dashboard.html

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
1m 12s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:yellow_heart:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

:blue_heart:
mvndep
0m 45s
Maven dependency ordering for branch

:green_heart:
mvninstall
6m  7s
master passed

:green_heart:
compile
3m 15s
master passed

:green_heart:
shadedjars
4m 59s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
3m 15s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 21s
Maven dependency ordering for patch

:green_heart:
mvninstall
5m 28s
the patch passed

:green_heart:
compile
3m 15s
the patch passed

:green_heart:
javac
3m 15s
the patch passed

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

:green_heart:
shadedjars
4m 57s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
17m 12s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
javadoc
3m 11s
the patch passed

_ Other Tests _

:broken_heart:
unit
248m 38s
root in the patch failed.

:green_heart:
asflicense
0m 54s
The patch does not generate ASF License warnings.

310m 21s

Reason
Tests

Failed junit tests
hadoop.hbase.regionserver.TestBulkLoadReplication

hadoop.hbase.master.assignment.TestOpenRegionProcedureHang

Subsystem
Report/Notes

Docker
Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-695/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/695

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux 3eedb4ceb010 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-695/out/precommit/personality/provided.sh

git revision
master / fd9cfd789b

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-695/3/artifact/out/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-695/3/testReport/

Max. process+thread count
4758 (vs. ulimit of 10000)

modules
C: hbase-common . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-695/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

TestBulkLoadReplication is broken, it is on the flaky list now. Failure shouldn't be related to this change.


Test owners should fail if unnecessary owners are added

In https://github.com/flutter/flutter/pull/97385, I removed the ios32 entries. This would have left unused owners for the 32 bit tests.
Instead, the validation should fail explicitly to ensure unused owners are removed.

\cc @keyonghan @chunhtai

Closing because the bug has not been updated for more than one year.
Feel free to reopen any bugs that you believe are important but please provide updates on how to resource the fix of the bug and what can be done to prevent the issue from not getting updates for another year.


How add SteamVR pligin in Megacity demo done with ECS?

Hi
Sorry for my ignorance but I am trying the new Megacity project done with ECS and I am interested in adding the SteamVR plugin to it, for it, What is the best to do it? Is SteamVR plugin for Unity  ECS compatible?
Does anybody try it?
Thanks for your time
Alejandro
PS. I added the Camera Rig prefab from Steam VR plugin in Megacity project and I see all Black in the game and I got the following warning
Cannot set field of view on camera with name PlayerCam while VR
Does anybody know how to fix it?
Thanks again

Hi Castana,
If you wanna try MegaCity in VR, just install in package manager >OpenVR and in XR settings tick Virtual Reality Supported.
I haven't try to add SteamVR plug-in.

MegaCity should work with any type of Unity Project. You can still run GameObjects along side any Entities you have created.
I don't think this is an issue with this github repo and should probably be closed.

This isn't really related to the steamvr plugin. I'd recommend asking on the unity forums.


Unable to override basepath for api routes

Which project does this relate to?
Start
Describe the bug
It is sometimes required to setup tanstack start app with a basepath.
For the router, it is possible to pass a basepath to createTanStackRouter
For server fns, it is possible to set this in app.config.ts
  routers: {
    server: {
      base: '/path/_server',
    },

However, the config apiBase doesn't seem to work with a custom basepath.
tsr: {
    apiBase: '/api',
    // apiBase: '/path/api', <- throws 503 Server unavailable
  },

And this makes it impossible to define api routes inside a subpath.
Your Example Website or App
https://stackblitz.com/edit/tanstack-router-rfnhqhpv?file=app.config.ts
Steps to Reproduce the Bug or Issue

In attached stackblitz, update apiBase with a base url (uncomment line 25 - /path/api)
Note error 503 Server Unavailable

Expected behavior
Should be able to provide a custom basepath for api routes, like the router itself
Screenshots or Videos

Platform

OS:  macOS
Browser: Chrome

Additional context
No response

Once you've changed the apiBase to /path/api, you need to change and update your API route files to match the new pathing.
So, these files need to have their locations changed as well. So in app/routes,

Old Location
New Location
Alternate Location

api/users.ts
path/api/users.ts
path.api/users.ts

api/users.$id.ts
path/api/users.$id.ts
path.api/users.$id.ts

@SeanCassiere Thank you for responding - do you think it is a bit confusing because we don't have to do that for file routes, only API routes?

@SeanCassiere Thank you for responding - do you think it is a bit confusing because we don't have to do that for file routes, only API routes?
i.e, for file routes base path prefix is "automatic" once added in config, no need to rename files themselves

Not in my opinion, since file routing also uses the similar keys which require changes to your file structure.
That being said, we are exploring other ways doing API routes that could make this easier.


FeatureRequest: Compine PDF Pages to one PNG

Would be nice if we can combine multible PDF Pages to one Image.

@Tobias-Keller Thanks for the request. Could you please share benefits or use cases for this type of conversion?


Cross compilation

Hi, not really an issue. Just want to know if there's any way to ONLY download binary for user's OS?
I'm talking about this...

Thank you!

Hi, not really an issue. Just want to know if there's any way to ONLY download binary for user's OS?
I'm talking about this...

Thank you!

Not at the moment. I had the option to make each (binding) package separately which I didn't want to do because it would unnecessarily create 11 more packages so I put everything in 1 for now because the files are not that big. But I plan to make it so that I will release a release on GitHub where all the bindings will be and they will be automatically downloaded in the program.

For now, you can delete other files.

For now, you can delete other files.

Gotcha. Thanks

But I plan to make it so that I will release a release on GitHub where all the bindings will be and they will be automatically downloaded in the package after start.

So the trick here is like create a script file, maybe a js file, that downloads the build based on user's platform after running bun add bun-utilities, right?

But I plan to make it so that I will release a release on GitHub where all the bindings will be and they will be automatically downloaded in the package after start.

So the trick here is like create a script file, maybe a js file, that downloads the build based on user's platform after running bun add bun-utilities, right?

If I'm not mistaken, I couldn't automate this since bun probably doesn't support postinstall so I'll make it delete unnecessary bindings when the program starts.


List gets under other components

Hi, would it be possible to attach the list to the body so when the list is displayed won't be under other components?
It seems to be a bootstrap problem relative to the z-index, I've to do it with other components created by myself, the component vue2-datepicker has it and save me a lot of time fix in it.
Thanks in advance.

I have the opposite issue. Using Leaflet map the z-index of some leaflet elements is set to values up to 1000.
I tried to fiddle with CSS with no success.

I have the opposite issue. Using Leaflet map the z-index of some leaflet elements is set to values up to 1000.
I tried to fiddle with CSS with no success.

I solved this by enclosing the component in a span with a higher z-index. Hope it helps.


[Addition]: Another spoofing in Turkey, Edirne province

Hotspot b58 Addresses
11fEpqb3Ja7bhWC4cUDu5KALmGrem2xuvAGHAkL2EsB9TWsCcg2
111JNXssceRSyddgsWpVMtSjP1WrjXQnmEj8AWaSGM3wnEreq6
11jWv7HurZ62sR4hHSSoaK5Ed8ZotiXBqvn7CvThjqd57DLDDjE
112Va37DHYq4XbXv9C49g1ZuEuch8rBo544QGu7AzPZZQBCCvyd
11V8FH2suyqJT5dDGwAB2ZvRwi8BeVPjpozKjnh1SrgnaQQuFcP
11h2hYu25zSmcwGLcqvn7hLH9qPXEnbxbGsUVNgnTpPPBmQz7YU
Discord Handle
cowybank#8842
Reason(s)
These hotspots are linked to one wallet:
144FvCNayc2aFgsERV4VfvpRyyvYuRfsEwcv2aWVSzoZnPVtmKt
Looking at the IP addresses of these devices, you can see that they all come from Frankfurt, Germany. However, the hotspots seem to be located in Edirne, Turkey.
The list of hotspots' IP addresses is like this:
11fEpqb3Ja7bhWC4cUDu5KALmGrem2xuvAGHAkL2EsB9TWsCcg2 ---> <IP_ADDRESS>
111JNXssceRSyddgsWpVMtSjP1WrjXQnmEj8AWaSGM3wnEreq6 ---> <IP_ADDRESS>
11jWv7HurZ62sR4hHSSoaK5Ed8ZotiXBqvn7CvThjqd57DLDDjE ---> <IP_ADDRESS>
112Va37DHYq4XbXv9C49g1ZuEuch8rBo544QGu7AzPZZQBCCvyd ---> <IP_ADDRESS>
11V8FH2suyqJT5dDGwAB2ZvRwi8BeVPjpozKjnh1SrgnaQQuFcP ---> <IP_ADDRESS>
It appears to be joining the network using VPN with only one internet connection from the same place. Already the hotspots appear on the explorer installed in weird places such as highways and fields.
Thank you!

Hotspots go offline/online simultaneously despite being in different locations.


Update configuration-management-reference-microsoft-defender-antiviru…

…s.md
Added Microsoft defender antivirus to the applied to section.

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/5471

@msbemba

@denisebmsft Please merge this PR. Thanks


[bug] X button doesn't close the modal on the first click

Link to minimal reproducible example
https://lab.web3modal.com/library/wagmi-all/
Summary

open the modal
try to close it

List of related npm package versions
last version

https://linear.app/walletconnect/issue/APKT-914/[bug]-first-click-doesnt-close-the-modal-with-the-x-button2737

It's closing but taking more time than usual


Support Flutter Web on all samples

This should hopefully be pretty straight-forward, since the repository layer is the only layer that needs to be swapped out. Many apps already accept a repository as part of the root widget or runMyApp type of function.
This would require a web-backed storage repository, using something like window.localstorage.

Added to most examples!


Remove #aggregate method from repo

This does nothing more than forward arguments to #combine on the root relation. Keeping this method here makes repos more confusing (users need to understand how aggregate works, and its special connection to the root relation) and also confuses the fact that a repo should be able to work with more than one relation.

@solnic reckon this is worth getting done before 4.0.0?

@timriley not really, feels too late. I'll remove it in rom-repo 3.0 and for now just remove it from docs and deprecate in rom-repo 2.1

@solnic for now, we could add an alias alias_method :combine, :aggregate


Unit Photos and Videos Upload/Hosting [ Epic 🏔 ]

Overview
Enable users to upload and view images and videos of units
Figma
Tasks

[x] #79
[x] #86
[x] #92

completed by #96


(WIP) support dropping server from the cluster

Issue #1471

Generally makes sense, but I don't see the value of allowing base and bit-size control of that new function.

@otoolep We have to have two separate functions if we don't allow the bitSize param.

OK, thanks @dgnorton -- perhaps allow bit-size, but not base?

Branch merge history corrupted and unable to use git to fix.  Closed and re-opened in new branch as #2486


comb sort fails with certain input.

The following array of integers is not sorted into ascending order correctly:
[400,300,520,100,110,500,60,100,250,460,470,90,340,216,411,378,158,38,272,272,378,216,470,520,60]
I believe the wikipedia pseudo code continues the sort loop if there is a swap, even if gap == 1.

Thanks for letting us know!

@dmarnel i ould like to add a linter support which works on all the editors named "coala", this is a part of my winter project, can someone guide me.


Soycode sshdhub

Docker Hub for uproxy-sshd - works on Linode.

Will need to do minor merging of OPTARGS stuff after #73 is merged, but should be straightforward. To be explicit, I used the sshd/makehub/Dockerfile to make and upload the soycode/uproxy-sshd image, which the new sshd/usehub/Dockerfile uses (with the option to just use the old sshd/Dockerfile if desired to build from "scratch").

OK, I'm going to suggest something very similar to zork:

a new switch which specifies the Docker image to use for sshd, with a default value of uproxy/sshd
this script never tries to build that image
once uproxy/sshd has been pulled down, this script applies:
banner
hostname
keys

Periodically, we'll refresh uproxy/sshd. Since it's very simple, I don't think we need any script to build it - a few lines in the README should suffice. What do you think?

For run_cloud.sh itself that makes sense - we'll still need something along the lines of sshd\makehub\Dockerfile in order to make an sshd image that lacks preset banner/hostname/keys. If that sounds right to you, I'll move as much as possible into that image creation and script the rest via run_cloud.sh as you described.

So, I don't think we need sshd/makehub- in fact, we shouldn't have to change anything under sshd/. run_cloud.sh can create/apply /banner, /hostname, and authorized_keys once it's pulled down the image.
Basically, there was no need for run_cloud.sh to ever have baked /banner or /hostname into the image...we can rectify now :-)

Well we still need a way to make the actual uproxy/sshd image to be pushed to Docker Hub, and specifically a variant of the image lacking banner/hostname/keys. Are you picturing that being another option with run_cloud.sh?

Building the Docker image should be really simple:

cd to sshd
docker build -t uproxy/sshd .

Won't that build an image that has preset private keys?

Hmm. Do you mean preset private keys for sshd? I guess that's true - in that case, yes, I guess run_cloud.sh should replace/update them.

Alright, I'll try that approach - just want to be sure that we don't bake in anything that should definitely be generated by the end-user.

Did as we discussed - and on second examination I don't think we were baking in actual keys anyway (just the chmod'd and sudo-enabled issue_invite.sh, but it wasn't actually executed), so the cleanup just removed the banner/host.

OK getting closer but what about removing all image building from run_cloud.sh? As with zork, it can try to pull the image from Docker hub, find it locally, or fail.

FYI I pushed https://hub.docker.com/r/uproxy/sshd/ based on the current sshd/Dockerfile in this branch.

Fantastic, thanks for uploading the image!
So so close now, just a couple of tiny things - and I'll do some testing this afternoon.

Thanks! Addressed comments, and I'll give it a test on Linode as well.

Hrm, generates the invite just fine, uProxy recognizes it but doesn't add the server - could not login: Timed out while waiting for handshake
The "could not login" bit is from here - https://github.com/uProxy/uproxy-lib/blob/1dfe26b2ac0b8440d8aa16e33a05d1050dbea1a9/src/cloud/social/provider.ts#L542
And the "timed out" bit is from ssh2 - https://github.com/mscdex/ssh2/blob/23bd66f723d2c72c007ed7a3b3afb9f50284bac4/lib/client.js#L670
Still trying to figure why it's a timeout and not a userauth failure (which is what I would expect if the uproxy/sshd image has issues). I may just try rebuilding and repushing, again based on sshd/Dockerfile in this pull request (which is the old one minus banner/hostname).

I was just trying out this branch but I'm getting an error from bash about a syntax error...
sh: 1: Syntax error: "(" unexpected

Weird!

Was testing this just now, all looks good! :+1:


shuffling a lot for consistency with howe we're doing others

This is an attempt at following more closely to our recent conventions, so that we can use the generic state with dead messages.
I'm sure that there is still a little bit more to shuffle, but I was beginning to lose my place of what did and didn't need to be updated.

Looks to be a nice improvement, especially with the state diagram.

The idea of Shelve vs Reject was definitely something I was waffling between. Hence the inconsistency in the PR.
First and foremost, I'd absolutely rather force prioritizing resolving bugs and tech debt by not being able to shelve a message to replay later. Either "done" or "todo" and no shades in between. The second we allow shades, we get the old problem of not every dead message being an alarm.
Originally I was looking at Reject purely for a ripcord situation. I can think of roughly 5 or less messages over the past 3 years that we had to delete and couldn't do anything with. Shelve only came in because of some old notes, and isn't really something I'm fond of over all.
So, the one addition I want to advocate for is a database-brain-surgery-free way of breaking glass and permanently removing a message from the list that doesn't involve replay.


Generate correct sourceMapUrl

All minified files are created with an invalid sourceMapUrl path. I.e. instead of a relative file.map it uses an absolute local file path like path/on/my/disk/to/file.min.js.
Browsers then complain about the invalid source map and actually reveal the local path in the dev console (!)

Just wanted to drop a note here to remind you that there are some outstanding changes needed to this PR before we can merge it. Thank you.


localize type definition is not consistent with the example

If I try the following example in TypeScript from Medium:
import { localize } from 'react-localize-redux';

const App = (props) => (
  ...
);

// if you use localize make sure to pass the name of the slice
// that localeReducer was attached to.
export default localize(App, 'locale');

I get the following typescript error:

error TS2345: Argument of type '(props: any) => Element' is not assignable to parameter of type 'ReactElement'.
Property 'type' is missing in type '(props: any) => Element'.

I think localize typescript definition is not matching with this example.

@acerola1 if you have some time you mind taking a look at the typescript def and see if you can get it working with your project? If you’re able to find a solution and submit a PR I can get that published quicker. I’ve done the project in Flow do testing the TS testing on my end is cumbersome at best.

I just started my first project in React, Redux and TypeScript. All three are new for me.
I can use the connect method to get the translate function for now. I feel sometimes Typescript just slows me down. I do not use its full capabilities. So I think I'm not the right person for this task yet. But thanks for this package it is up and running now.

@acerola1 no problem thanks for the heads up. Also you may want to take a look at flow type. I've used both flow type, and TypeScript and I personally find flow type much less cumbersome than TypeScript.

@acerola1 as a temp fix until I figure things out with the type definition you can do the following:
export default localize(App as any, 'locale');

Thanks, it works

@acerola1 the latest release now has official fix so you can stop using any.


(PUP-2310) Allow agent to refresh CRL periodically

Allow the agent to periodically refresh its CRL using If-Modified-Since
header support added in PUP-8913.
By default, the agent will never refresh its CRL. However, a refresh interval
can be specified in Puppet[:crl_refresh_interval]. If set, the agent will
refresh at most once within that interval, eg once every '8h'.
If the refresh request succeeds, then the agent will use the newly downloaded
CRL for subsequent requests.
If the refresh request fails, then the agent will ignore the error and continue
running with the existing set of CRLs. However, if the failure occurs when
downloading the initial CRL, then the agent run will fail.

Initial CRL download fails, agent run aborts:
$ rm ~/.puppetlabs/etc/puppet/ssl/crl.pem
$ bx puppet agent -tv --certname foobar --crl_refresh_interval 10s --ca_port 9999
Error: Could not run: Failed to open TCP connection to puppet.delivery.puppetlabs.net:9999 (Connection refused - connect(2) for "puppet.delivery.puppetlabs.net" port 9999)

Initial CRL download succeeds:
$ bx puppet agent -tv --certname foobar --crl_refresh_interval 10s
Info: Downloaded certificate revocation list for ca from puppet.delivery.puppetlabs.net
Info: Using configured environment 'production'

CRL is not expired, refresh is skipped:
$ bx puppet agent -tv --certname foobar --crl_refresh_interval 10s
Info: Using configured environment 'production'

CRL is expired, but unmodified on the server:
$ bx puppet agent -tv --certname foobar --crl_refresh_interval 10s
Info: Refreshing CRL
Info: CRL is unmodified, using existing CRL
Info: Using configured environment 'production'

CRL is expired and modified on the server:
$ bx puppet agent -tv --certname foobar --crl_refresh_interval 10s
Info: Refreshing CRL
Info: Downloaded certificate revocation list for ca from puppet.delivery.puppetlabs.net
Info: Using configured environment 'production'

CRL is expired, but connection fails, run continues:
$ bx puppet agent -tv --certname foobar --crl_refresh_interval 10s --ca_port 9999
Info: Refreshing CRL
Warning: Failed to refresh CRL, using existing CRL: Failed to open TCP connection to puppet.delivery.puppetlabs.net:9999 (Connection refused - connect(2) for "puppet.delivery.puppetlabs.net" port 9999)
Info: Using configured environment 'production'

CLA signed by all contributors.

jenkins please test this on windows2016-64a with servertests


break if file is not written

this PR closes the issue #142
now the vcf_validator will throw runtime error is it is unable to write the output file.
srb@srb-pc:~$ ./vcf_validator -i /data/my_vcf.vcf.gz
[error] The validation could not be completed: Unable to write output file stdin.errors_summary.1529587453100.txt

still, this is one of fastest resolutions ever of an issue!

The unnoticed error is fixed, but maybe we can improve this message in the case of ODB report:

./vcf_validator_linux -i no_write_permissions/a.vcf  -r database
[error] The validation could not be completed: ODB report: Can't initialize database: 14: unable to open database file

should say the path of the "database file"


possibly outdated formatter

With an up to date community repository, I also needed to make the following change in order get "groß geschrieben" to work:
 großgeschrieben | mach groß:
     edit.select_word()
-    user.formatters_reformat_selection("title")
+    user.formatters_reformat_selection("CAPITALIZE_ALL_WORDS")

It may be preferable to only select the current word if there isn't already a selection.

Checking for an existing selection seems useful and is what a user would expect, I also thought about it.
What comes to my mind is to try and copy to see if we get text in the clipboard, but too many editors have some convenience feature that will copy the whole line if nothing is selected - so this method does not seem too reliable.
So far I myself never really ran into that case during my day-to-day usage, so I just left it as it was.
Do you have an idea for a reliable way?


Add preset subtitle property

Closes #6131.
This adds an optional subtitle property for presets that displays below the name. It also switches name suggestion presets to use it, removing some hacky code.
I didn't merge this directly since it has some special implications for translations that need to be worked out. The usefulness of the subtitle depends on the language, and thus there is not a one-to-one mapping of what presets should get subtitles in English versus any other given language.
Update: I made it so subtitles don't default to English if there's no translation available.

The mechanism currently possible to deliberately not translate a terms field as a translator would be to simply enter <>. The import from Transifex removes this field in this case because it removes everything in between < and > while in Transifex itself I think it should turn up as "translated".
This method is not described or communicated anywhere to the translators yet, but it could, and the same method could be used for the subtitle descriptions.

Putting this feature on hold. See https://github.com/openstreetmap/iD/pull/6412#issuecomment-500976378.


WIP: loading certs with tls.crt improvements

Please provide a description of this PR:
This is WIP for fixing the tls.crt and adding more info about the chains - to get early feedback and
see if I'm missunderstanding something.

@costinm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
93aa1fa0f62d439846c188def5accdb7e5e7e8f4
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
93aa1fa0f62d439846c188def5accdb7e5e7e8f4
link
true
/test lint

release-notes_istio
93aa1fa0f62d439846c188def5accdb7e5e7e8f4
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
93aa1fa0f62d439846c188def5accdb7e5e7e8f4
link
true
/test lint

release-notes_istio
93aa1fa0f62d439846c188def5accdb7e5e7e8f4
link
true
/test release-notes

gencheck_istio
93aa1fa0f62d439846c188def5accdb7e5e7e8f4
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
93aa1fa0f62d439846c188def5accdb7e5e7e8f4
link
true
/test gencheck

release-notes_istio
3ac185ce64bb02fc0ca27b4b878a38121ebf34de
link
true
/test release-notes

lint_istio
3ac185ce64bb02fc0ca27b4b878a38121ebf34de
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
3ac185ce64bb02fc0ca27b4b878a38121ebf34de
link
true
/test release-notes

lint_istio
3ac185ce64bb02fc0ca27b4b878a38121ebf34de
link
true
/test lint

gencheck_istio
3ac185ce64bb02fc0ca27b4b878a38121ebf34de
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
3ac185ce64bb02fc0ca27b4b878a38121ebf34de
link
true
/test release-notes

lint_istio
3ac185ce64bb02fc0ca27b4b878a38121ebf34de
link
true
/test lint

gencheck_istio
3ac185ce64bb02fc0ca27b4b878a38121ebf34de
link
true
/test gencheck

integ-ambient_istio
3ac185ce64bb02fc0ca27b4b878a38121ebf34de
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
3ac185ce64bb02fc0ca27b4b878a38121ebf34de
link
true
/test release-notes

lint_istio
3ac185ce64bb02fc0ca27b4b878a38121ebf34de
link
true
/test lint

integ-ambient_istio
3ac185ce64bb02fc0ca27b4b878a38121ebf34de
link
true
/test integ-ambient

gencheck_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
3ac185ce64bb02fc0ca27b4b878a38121ebf34de
link
true
/test release-notes

integ-ambient_istio
3ac185ce64bb02fc0ca27b4b878a38121ebf34de
link
true
/test integ-ambient

gencheck_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test gencheck

lint_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
3ac185ce64bb02fc0ca27b4b878a38121ebf34de
link
true
/test integ-ambient

gencheck_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test gencheck

lint_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test lint

release-notes_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
3ac185ce64bb02fc0ca27b4b878a38121ebf34de
link
true
/test integ-ambient

gencheck_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test gencheck

lint_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test lint

release-notes_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test release-notes

unit-tests-arm64_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
3ac185ce64bb02fc0ca27b4b878a38121ebf34de
link
true
/test integ-ambient

gencheck_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test gencheck

lint_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test lint

release-notes_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test release-notes

unit-tests-arm64_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test unit-tests-arm64

unit-tests_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test gencheck

lint_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test lint

release-notes_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test release-notes

unit-tests-arm64_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test unit-tests-arm64

unit-tests_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test unit-tests

integ-security-istiodremote_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test gencheck

lint_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test lint

release-notes_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test release-notes

unit-tests-arm64_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test unit-tests-arm64

unit-tests_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test unit-tests

integ-security-istiodremote_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test integ-security-istiodremote

integ-security_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test gencheck

lint_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test lint

release-notes_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test release-notes

unit-tests-arm64_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test unit-tests-arm64

unit-tests_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test unit-tests

integ-security-istiodremote_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test integ-security-istiodremote

integ-security_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test integ-security

integ-security-multicluster_istio
e5f9d2054bc2b0ce305602848549158ffb278ef7
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


C# examples using OpenCV Image Decoder & SuperResolution CustomOps

We need c# customeOps examples using OpenCV Image Decoder & SuperResolution CustomOps

The Custom ops implementation is language independent, but the usage in each language is different. Feel free to contribute some demo code in C#.

:-)


Update REST-Protocol.md

Add a line showing the expected content-type for the request
It's possible this content-type is obvious if you do enough REST development, but it took me some googling to figure out how to solve the 415 error and I think this would be useful to have directly in the docs.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Error: unable to locate end-of-central-directory record

Hi
While extracting the zip file, I am getting the below error in some of the zip files
Archive::Zip::UnzipError (unable to locate end-of-central-directory record)
/usr/local/bundle/gems/archive-zip-0.12.0/lib/archive/zip.rb:705:in `rescue in find_central_directory'
/usr/local/bundle/gems/archive-zip-0.12.0/lib/archive/zip.rb:678:in `find_central_directory'
/usr/local/bundle/gems/archive-zip-0.12.0/lib/archive/zip.rb:660:in `parse'
/usr/local/bundle/gems/archive-zip-0.12.0/lib/archive/zip.rb:210:in `each'
/usr/local/bundle/gems/archive-zip-0.12.0/lib/archive/zip.rb:576:in `extract'
/usr/local/bundle/gems/archive-zip-0.12.0/lib/archive/zip.rb:100:in `block in extract'
/usr/local/bundle/gems/archive-zip-0.12.0/lib/archive/zip.rb:113:in `open'
/usr/local/bundle/gems/archive-zip-0.12.0/lib/archive/zip.rb:100:in `extract'

If I try to extract the same zip file on the machine, it is extracted properly without any issues.
Note: The error is raised with only a few files. It works fine in other zip files.

The library attempts to locate a structure located near the end of the zip file that contains the directory of all files in the archive.  It does this by starting at the end of the file and searching backwards for a signature that flags the start of the structure.  Without seeing the zip file in question, I only have a couple guesses as to the problem:

The file is corrupt or truncated and doesn't have this structure where expected or at all
The file is a newer zip format than supported by this library

Chances are good that the tool you use on your computer is more robust and is able to support extracting the archive even without this central directory structure.  I've wanted to add the ability to do that to this library but have never found the time.
Are you able to share the problematic zip file?  I can look over the structure if so.

Thanks for the reply.
I can confirm that the file is not corrupt. I am able to unzip the file manually and as also with other zip libaray. I can not share the original file with you but I will try to share the similar file to look into.


Clarify empty_buffer function

The empty_buffer() function returns true when the buffer is not empty, this PR makes the purpose of the function clearer.
What I did: :%s/empty_buffer/buffer_not_empty/g in example/spaceline.lua

Pretty good.


fix every cmd response is followed by %

The % symbol at the end of every response is not actually part of the output . It's a feature of some terminal emulators, including the default terminal in macOS, which display a % or other symbol when the output from the last command does not end with a newline (\n).
Here is the output attached

Closes: https://github.com/gofr-dev/gofr/issues/696

This just fixes the example and not the underlying problem.

okk i will look into it

please reivew it @vikash @srijan-27

@aditya028 - Did you verified the changes by running the example? If yes, please attach the fixed terminal output.
Also, since now format is changed so some tests are failing, would need to fix them as well.

I have checked the examples and it works fine . Also, in the codebase it is mentioned there is some issue that needs to be resolved
TODO - provide proper exit codes here. Using os.Exit directly is a problem for tests.

@aditya028 - Yes, that needs to be done someway. If you want you can dive deep and take a look on that, if not, then you can just fix the current tests.

@aditya028 - Forgot to mention previously, if you look into the TODO task, then create a separate issue and PR for that. As it has separate context than this PR.

ok sure @srijan-27 , for now i will fix the test case for this .

@srijan-27 can you check this

@srijan-27 can you check this

@aditya028 - Couple of tests are still failing.. you can check them from the workflows.


Bootstrapping script has no meaningful --help

$ curl https://sh.rustup.rs -sSf > rustup.sh
$ chmod +x rustup.sh
$ ./rustup.sh --help
info: downloading installer
curl: (56) SSL read: error:00000000:lib(0):func(0):reason(0), errno 110
rustup: command failed: curl -sSfL https://static.rust-lang.org/rustup/dist/armv7-unknown-linux-gnueabihf/rustup-init -o /tmp/tmp.BHBSSN9DAL/rustup-init

I expected to get list of options for this script, not just beginning of the installation itself.

This is because the script delegates all argument handling to rustup-init, including --help. It would probably be more usable to duplicate the --help message in the script.

Options regarding to how (curl? wget? verbose mode?) and which (platform detection) rustup-init to download are obviously need to be interpreted by this script.

The bootstrapping script can print usage information now.


Revert "webots_ros2: 2023.1.1-1 in 'humble/distribution.yaml' [bloom]"

Reverts ros/rosdistro#37906
This fails on the buildfarm:
https://build.ros2.org/view/Hbin_uJ64/job/Hbin_uJ64__webots_ros2_driver__ubuntu_jammy_amd64__binary/41/console
I think we're missing a build dependency on yaml-cpp in the package.xml of webots_ros2_driver.
https://github.com/ros/rosdistro/blob/1cc4db2579b370519728a4a4ebe771de51719d8f/rosdep/base.yaml#L8351
FYI @ygoumaz.

The tests pass for all distributions in the industrial-CI. Is it possible for you to install this dependency in your Jenkins builds?

I would think yaml-cpp should be included as a build dependency in the package.xml. I think then it will be included in the build job.
It is possible that some other package being built in the industrial-CI has an explicit dependency on yaml-cpp which let's this package find yaml-cpp implicitly. I think the buildfarm is probably a more isolated environment, so you need to declare all dependencies explicitly.


Jinja2 / Django support?

Filters for templates with this functionality?

Would be cool. I'm not currently using this package in a web application, though, so it could be a while before I get around to it. Happy to accept pull requests too.


docs: Grammar fix "will not" -> "doesn't"

Just a quick grammar fixup in the quickstart guide!

@CianLR, while you're there, change directory then it to directory, it.  Thanks

Sure. Done and squashed :+1:

Hello @CianLR,
thank you for submitting this addition. I've merged your contribution as fe2b22fe6f8add81a750c2c6d300d674b608a9b8 (master) and 90b8b2fa864a7aa21f8c370e12a6fe828f046888 (v0.15.docs).
Cheers,
Digitalcraftsman


Question: "Select" not supporting Jquery Selectmenu widget

Hey there,
first of all thank you for this amazing plugin.
Is there any possibility to use the jquery selectmenu widget together with yadcf? The plugin doesnt read the values and put it into the server request. Anything I have to set up different for this plugin?
Regards

Please read about select_type  and initSelectPluginCustomTriggers
(all in the js file docs) you could also take a look at the related issues
on github
https://github.com/search?l=JavaScript&q=initSelectPluginCustomTriggers(&type=Issues
p.s
next time ask questions on stack overflow
On Wed, Nov 7, 2018 at 11:37 AM tpreussFN<EMAIL_ADDRESS>wrote:

Hey there,
first of all thank you for this amazing plugin.
Is there any possibility to use the jquery selectmenu widget together with
yadcf? The plugin doesnt read the values and put it into the server
request. Anything I have to set up different for this plugin?
Regards
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/vedmack/yadcf/issues/514, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABmiX_7Sm7k0qQuXyibLWNKDXRkz1mR7ks5usqnggaJpZM4YSFH4
.


[HOW-TO] Autofocus

Hello,
I am trying to use AfWindows to focus the camera on different parts of the window. I need a bit of help translating the regions of interest displayed on my preview, to the ScalarCropMaximum size. The ScalarCropMaximum is used to set the focus area in AfWindows according to the picamera2 docs. Based on this I assume that I need to scale the preview size to the active window in the ScalarCropMaximum and then translate it by the ScalarCropMaximum x and y offset.  I have attempted to do this in the function AccountForScalerCrop in my script. This doesn't seem to be working, am I translating or scaling the image in the wrong way?
I have tried writing an example script
import time
sys.path.append('/usr/lib/python3/dist-packages/')
from picamera2 import Picamera2, Preview, MappedArray
from libcamera import controls
picam2 = Picamera2()
import cv2
import numpy as np

# Set display size and create variables for later
lores = (1280, 800)
width, height = lores

# start cam
picam2.start_preview(Preview.DRM, x=100, y=100, width=1280, height=800)
preview_config = picam2.create_preview_configuration(main={"size": lores})
picam2.configure(preview_config)
picam2.start()

# print properties - including scalar crop max
properties = picam2.camera_properties
print(properties)

# print metadata
metadata = picam2.capture_metadata()
print(metadata)

# set afmetering to windows so it can be called
picam2.controls.set_controls( { "AfMetering" : controls.AfMeteringEnum.Windows} )

# turn scalercropmax into a variable
scaler_crop_maximum = picam2.camera_properties['ScalerCropMaximum']

# set some example ROI
coord1 = (0,0, width // 2, height)
coord2 = (width // 2, height // 4, width // 2, height // 2)
coord3 = (0, height // 4, width // 2, height // 2)
coord4 = (100, 100, width, height)
coord5 = (1000,100, 500, 200)

# function for printing variables consistently
def print_coordinates(coordinates, name):
    print(name.upper())
    print(f"x_offset = {coordinates[0]}")
    print(f"y_offset = {coordinates[1]}")
    print(f"width = {coordinates[2]}")
    print(f"height = {coordinates[3]}")

# function to attempt to scale variables designed for preview into scalercropmax size for AfWindows
def AccountForScalerCrop(coord, scaler_crop_maximum, lores):
    x_offset, y_offset, width, height = coord
    print_coordinates(coord, "coord")

    # scaler_crop_maximum represents a larger image than the image we use so we need to account
    x_offset_scm, y_offset_scm, width_scm, height_scm = scaler_crop_maximum
    print_coordinates(scaler_crop_maximum, "SCM")

    # create a scale so that you can scale the preview to the SCM
    yscale = int(scaler_crop_maximum[3]) / int(lores[1])
    xscale = int(scaler_crop_maximum[2]) / int(lores[0])
    print("yscale, xscale",yscale, xscale)

    # scale coords to SCM
    y_offset_scaled = int(y_offset * yscale)
    height_scaled = int(height * yscale)
    x_offset_scaled = int(x_offset * xscale)
    width_scaled = int(width * xscale)

    coordscaled = (x_offset_scaled, y_offset_scaled, width_scaled, height_scaled)
    print_coordinates(coordscaled, "coordscaled")

    adjustedcoord = (x_offset_scm + x_offset_scaled, y_offset_scm + y_offset_scaled, width_scaled, height_scaled)
    print_coordinates(adjustedcoord, "adjustedcoord")

    return adjustedcoord

# function to focus cam based on scaled coords and draw overlays for coords
def focusarea(coord, scaler_crop_maximum, lores):
    adjustedcoord = AccountForScalerCrop(coord, scaler_crop_maximum, lores)
    picam2.set_controls({"AfWindows": [adjustedcoord]})
    print("focusing cam")
    job = picam2.autofocus_cycle(wait=False)
    # Now do some other things, and when you finally want to be sure the autofocus cycle is finished:
    success = picam2.wait(job)
    # query lens position after completion
    LensPosition = picam2.capture_metadata().get("LensPosition")
    print("LENS POSITION:", LensPosition)

    x_offset, y_offset, width, height = coord

    # create overlay the size of the preview
    overlay = np.zeros((lores[1], lores[0], 4), dtype=np.uint8)
    overlay[y_offset:height+y_offset,x_offset:width+x_offset] = (0, 255, 0, 64)

    picam2.set_overlay(overlay)
    time.sleep(5)

# create list of coordinates
coordinates = [coord1, coord2, coord3, coord4, coord5]
# loop through coordinates
for i, coord in enumerate(coordinates, start=1):
    print(f">>>>>>>>FOCUSING COORD{i}")
    focusarea(coord, scaler_crop_maximum, lores)

print("script finished")```

@njhollinghurst Nick, could you maybe comment on this question? Thanks!

The libcamera controls spec is a little ambiguous here, but I've always interpreted it to mean "raw" coordinates in the sensor's active pixel array. That is to say, the crop X,Y starting position should be added (not subtracted).
If that's the case then this code looks correct (at first sight), except that yscale and xscale are generally not integers.
@tennisparty How is it going wrong?

Hi Nick and David,
Thanks for this, I have had another look this morning. It turns out I hadn't set the AfMode before calling the autofocus. I have setup a FoV for the camera with multiple focal distances and whenever the display overlay changes the focus now matches that area, success!
Thanks again for your help,
Sam


GPA Calculator: padding

Name of Tester: Seth
Feature: GPA Calculator
How to produce error:
I'm not certain if this is within our control at all but the padding on GPA calculator seems really bad
Expected Result:
There should be more padding on the sides of the text

This is a webview, so the only option would be to add padding to the whole webview, which would look weird I think. @romrell4 do you agree?

Yes


[Home Page] Card Block Variants: events and news

[Home Page] Card Block Variants: events and news

https://github.com/hlxsites/zemax/pull/50

https://github.com/hlxsites/zemax/pull/71


License choice motivation

Nice project, wish you luck!
Just wondering why the license is Apache 2.0 - instead of something that prevents the real possibility of a fork to closed source when things get interesting.

I never thought about that. What would you recommend I use?

Thanks for the interest. I'm no expert and no lawyer so don't believe a word I say.

TLDR:

If you don't care too much about making money - but you do want to protect your project from being usurped by commercial entities go AGPLv3
If you want to go commercial use Apache 2.0
If you don't care at all then go Public domain or MIT
Don't choose some obscure license no one understands ; it's too much friction

I all depends on your personal goals for the project. Together with others, Adam Jacob has done some nice work reflecting on this.
Why do you want it to be open source?
Everything starts as proprietary (your creation) - and you choose to 'let go of your rights' - for whatever motivation - on a triangle surface between:

Oblige freedom ; GPL or AGPL (if you want to protect your OS from being streamed from behind a network - similar to the Microsoft plans for moving Windows OS fully to the cloud)
Oblige freedom - but with commercial interests/compatibility protected ; Apache 2.0 or source available which doesn't actually qualify as open source
No obligations - do whatever you like ; public domain / MIT

Once you 'let go of your right' and others start contributing under the new license you can't change licenses anymore - unless they all agree.
If you're the only one contributing - you can change your mind any time - it's still all your 'property' to decide upon.
Here's a map to get you started from a broader article on open data and code :

Hope this helps!


Dockerfile is invalid

The Dockerfile is no longer valid and has references to servers that are inaccessible.
 => ERROR [build_stage 2/8] RUN wget<EMAIL_ADDRESS>-O /etc/apk/keys/julien@porta  5.6s
------
 > [build_stage 2/8] RUN wget<EMAIL_ADDRESS>-O<EMAIL_ADDRESS>#9 5.501 wget: bad address 'public.portalier.com'

Further, installing using Crystal crystal build envoy-ui.cr fails with an exception as well
In envoy-ui.cr:57:17

 57 | rescue ex : Errno
                  ^----
Error: Errno is not a subclass of Exception

Yes, but I somehow missed this. Your PR has been merged @isopropylcyanide

Thanks @relistan


Mapillary: Add new geo positioned object classes

Mapillary recently announced new object classes that are geo positioned like the traffic since we already have.
Announcement: https://twitter.com/mapillary/status/1088010250878361601
What would be a good UI to add those to iD?

Nice!  Yes I've chatted with @cbeddow about this.  We'd like to improve iD's custom data capabilities and connect to these new sources like other vector data sources.

We had the idea of having the Mapillary data layer instead of traffic sign layer, where you could select a layer: traffic signs, points, lines then subfilter like by stop signs only, or trash bins only, or sidewalks only. Still open to UI ideas, though @bhousel and I had discussed using the modal window similar to what adding custom tiles brings up.


update composer to use php 8 and phpunit 9

What?

add php ^8.0 to composer
add phpunit ^9.0 to composer
move phpunit to require-dev
add prefer-stable: true
update composer.lock with new dependencies

Tests/Proof
I ran test under php8 and phpunit9

Just deprecated warnings. Everything works.
ping @precariouspanther @serroba @filakhtov

Will do CircleCi in separate PR


Fix array_use_braces for body params

Previously this is what was generated:
"attr":{"type":"array","items":{"type":"object","properties":{"":{"type":"string"}}}}
instead of
"attr":{"type":"array","items":{"type":"string"}}
in case this attribute was nested in a Hash attribute with "body" in param_type
Definition:
requires :param_1, type: Hash, documentation: { param_type: 'body' } do
  optional :param_2, type: Integer
  optional :param_3, type: Array[String]
end

Here is how it looked like it Swagger UI:

instead of

Coverage increased (+0.0007%) to 99.331% when pulling 277831b921d879a4080424fe3f40cbc87c0aeee3 on bikolya:fix-array-use-braces-for-body-params into 445d2d471d70183e96b0f0e539c7bf2ba3e10278 on ruby-grape:master.

thanks @bikolya …


Move JavaScript back to

It was moved away from <head> to the bottom of the page in #78.
This is a compressed version of #545 by @Blendify, which fixes #328.
Closes #545.

Committed in a different patch


Fix Docker Compose setup

The problem
Tried self-hosting with docker compose, following the documentation and tinkering, but there are some issues with the .env.example file and docker-compose.yml.

When I tried the v3.9.0 tag the backend would not start up because of the OIDC environment variables

OIDC_CLIENT_ID=
OIDC_CLIENT_SECRET=
OIDC_DISCOVERY_URL=http://oidc.localhost:5556/dex/.well-known/openid-configuration

I tried clearing out the OIDC_DISCOVERY_URL variable but the backend would still try to connect to an OIDC server and not start up. In the end I had to comment out these variables in the docker-compose.yaml file itself so it would start up properly.

I'm trying this on the master branch now, and all these variables are commented out by default in docker-compose.yml, so even if someone was to follow the documentation and fill out these variables in the .env file it wouldn't do anything.

Another issue that I experience on the master is that the backend cannot find Postgres. The connection url is baked into docker-compose.yml as
SCRUMLR_SERVER_DATABASE_URL: "postgres://scrumlr:${POSTGRES_PASSWORD}@postgres:5432/scrumlr?sslmode=disable"

Which assumes the postgres container's name will be postgres, but in the compose file the postgres service does not have a container_name set, which will make the name dependent upon docker compose version. For me with the newest compose it is docker-postgres-1 where docker is the folder (stack) name, postrges is the service and it appends -1 because it is the first instance of this container. So I think container_name should be added to all the services in docker-compose.yml to simplify connection strings for this setup.
Browser
Browser independent
Steps to reproduce the behavior

Checkout master branch (214177481e3e97cb4706f53d8659680aa217e1c9)
In deployment/docker follow steps from documentation
docker compose up -d
Check logs of backend container with docker logs -f (backend container name

Screenshots
No response
Additional context
No response

Hi @Avalancs, thanks for taking the time to write up an issue.
I've created issues for both points and we'll hopefully get to them soon :)

Generally I would expect the application to check if Client ID and Client secret (or the other params) would be empty string and disable the feature or print a warning in the backend logs, that would make it easier to find the problem in the future :)
I might give these a go in the following weeks when I have some more time, thank you for creating the specific issues!


If statement return type with union inferred incorrectly

🔎 Search Terms
union, spread, return, inferrence
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about union, spread return type

⏯ Playground Link
https://www.typescriptlang.org/play/?ts=5.5.0-dev.20240522&ssl=16&ssc=1&pln=1&pc=1#code/PTAEBUAsEsGdQGYFcB2BjALtA9ig5PAE4CmGShKoGAngA7GiyTZIA2AJqAEbEBQIoAN60AXKBRIAtj0IBfUAB8hoidOKEANKEljYGQtBQBzWfzBckGUNCtxlY1TNNpcexKlABeUAAoXKdjEubGxWYgBDFABKLwA+IV5QUH83AA8vIVBRUABGUFkAbkTrBF9-dhjBYqSUqxdpQ2JOb0FQADoO1K0dUAAiSGJWVmxe-KKkpJIyCmTsBpQm8fzQQdgGKonQARJaVnC0BgB3G0hQAAMp8kpeoxD2XrPEbEJZwhJMUEuZmnpqz9IrqBUktTEkBFA7IdngBreAIRrFbYAmblUAAfkyHTaXW0Yn6g2Go3kYmBvEKvAp4Jg8ChhFhiAR7GIaD2JFmKDc5SCITCkSKtSBGWEIhy5IF1AyqIxrSxOJ6+KGI2WJIKQA
💻 Code
// This function's return type should be
// {p: number} | {p:number, m: string}
// but it is {p: number}
const fun = (cond: boolean) => {
  const x = { p: 1 };
  if (cond) {
    const combined = { ...x, m: "hello" };
    return combined;
  } else {
    // replace with `return "good"` for correct return type
    return x;
  }
  // This works fine
  // return cond ? { ...x, m: "hello" } : x;
};

🙁 Actual behavior
The inferred function return type doesn't include both branches of the if statement.
🙂 Expected behavior
The inferred function return type should include both branches of the if statement, as if ternary was used.
Additional information about the issue
No response

This is expected subtype reduction behavior.  Typescript can only infer your desired type in specific scenarios with fresh objects; see https://github.com/microsoft/TypeScript/pull/19513.

@nmain can you elaborate? TS correctly infers the type in each branch, and correctly infers the return type when a ternary is used.

when a ternary is used

Because they're fresh object literals in that case.  Search "subtype reduction" and you'll find various previous issues about this; for instance, https://github.com/microsoft/TypeScript/issues/52893.

@RyanCavanaugh why not infer unknown if undefined cannot be inferred? Why not keep the union? From reading the original PR that's still not clear to me. For my original example, return type of fun could be either be:

{p: number} | {p:number, m: string} - m cannot be used without type narrowing
or {p: number, m: unknown} | {p:number, m: string}, m is unknown without type narrowing.

I would also add to @RyanCavanaugh's comment:

When the complaint is that the behavior is "inconsistent", it seems counterproductive to introduce a new set of rules that make predicting the output much harder than before.
Immediately-returned object? Yes. Anything else? No
Immediately-returned object? Yes. Intermediate const? Maybe, depends on the initializer. Function calls? Method calls? Passing the object somewhere else? What if the object goes into a  generic call? Epicycles.

There will be confusion somewhere. But "you have a function call here, passing in the object, so we can't tell whether there are extra properties on it afterwards" is less confusing than the current behavior imo (this was a common issue in Flow, but people working with it learned it). So tracking object literals / "closeness" would be preferable.


bad plot using other series apart from LineSeries with Real time live data

I have tried LineSeries it worked fine with real time data, but me using Bar,Area,Histogram, CandleSticks i get weird output like below screenshots.
please can anyone suggest what am ding wrong here?
@timocov

Please check your data, I guess the problem is there. Values must be numbers (not strings), open/high/low/close values should be filled according the bar's data, every bar should be different object (not the same ref).

Please check your data, I guess the problem is there. Values must be numbers (not strings), open/high/low/close values should be filled according the bar's data, every bar should be different object (not the same ref).

Did you see candle Stick too? all are not going well i don't know see below i set TIME then OHLC and yet @timocov  check below

Yes, I've took a look at all your screenshots, but I can't tell you for sure what's going on here because I can't guess by screenshots. Can you show here the data you've provided to setData method? Do you have jsfiddle-like example with that problem? If you want to get help, you need to provide as much as possible information.

@timocov
i guess it was just the way i handled my code, now i get it worked here https://codepen.io/highbreedtech/pen/qBdmRNy
thanks for your help


onStepProgress - Janky callbacks

Hi Russel,
First of all, thank you for your work on this library. It is great to use and very flexible.
After building a simple prototype, I noticed that onStepProgress unfortunately becomes very janky on Safari (and iOS). If you would look at the demo given on https://russellgoldenberg.github.io/scrollama/progress/ , you will notice that it will use much larger incremental steps than on Chrome or Firefox. I have tried playing around with the threshold option but this doesn't seem to impact this much.
At first I thought I was doing something wrong but as it is also available in your demo is most likely a bug. I was hoping that the library would function the same cross-browser.
Thank you in advance for any help.

Yep, looks like the frequency of callback is far fewer in iOS and macOS. They both rely on the polyfill, so it is likely due to that. So I'm not sure there is a bug technically (at least not in scrollama), but a limitation to the polyfill's ability to produce the same results for this feature cross-browser. I'll do some more testing though, and make a note of it in the documentation.

After doing some extra research in the mean time I did get to the same conclusion that it must be the Polyfill not giving the same results unfortunately.
Would you be able to share which functions from the IntersectionObserver API you are using to create the progress callbacks? I can then create an issue on the IntersectionObserver repo to see if they can fix this in the Polyfill right here; https://github.com/w3c/IntersectionObserver/tree/master/polyfill
Thank you in advance and for your help so far. I really want to fix this so I can use this API in my current work instead of relying on performance heavy alternatives.

Yup you want the threshold property.
Here is the scrollama code
Here is property in Moz Docs with another example


Allow options to be passed to MarkerClusterGroup when not using overlays

Problem: when using marker clustering there is no way to pass options to the markerGroup if the markerGroup isn't being used as a Overlay Layer. When defining the Marker it is expecting the group property to be a string.
Hack: I've hacked a solution to allow the group property on the marker to also be an Obj:
{
    name: 'groupName',
    options: {
        // L.MarkerClusterGroup options go here.
    {
}

Here's the entire solution in leafletMarkersHelpers factory:
addMarkerToGroup: function(marker, groupName, groupOptions, map) {
            if (!isString(groupName)) {
                if (Object.prototype.toString.call(groupName) === "[object Object]") {
                    if (groupName.hasOwnProperty('name')) {
                        groupOptions = (groupName.options) ? groupName.options : null;
                        groupName = groupName.name;
                    }
                    else {
                        $log.error('[AngularJS - Leaflet] The marker group you have specified is invalid.');
                        return;
                    }
                }
                else {
                    $log.error('[AngularJS - Leaflet] The marker group you have specified is invalid.');
                    return;
                }
            }
    ...

Does this look like a good solution?

Hi @cleversprocket, I'm sorry for the late response.
Your solution looks good, but I can't imagine the case of use you are trying to solve. Lot of things have changed in the markers and layers funcitonality, so please, if you are interested in adding this to the main code, take a look at the actual source code and generate a Pull Request, it will be revised and accepted shortly.
Thanks, I'm closing this issue.


fix: forbid pinning uninitialized entities when unassigned not allowed

Interestingly, plenty of tests were actually intentionally testing the situation where allowsUnassigned=false and yet value pinned to null, making sure the solver didn't fail in that case.
That was probably an oversight; if I had thought about it more at the time, I would've convinced myself that failing in this situation is the correct behavior. But it raises questions of backwards compatibility.
In my opinion, changing this is not a problem, because before this fix it would result in negative init score, and that would've made local search fail anyway.

In my opinion, changing this is not a problem, because before this fix it would result in negative init score, and that would've made local search fail anyway.

Local search did not fail when it started with a negative init score; it continued normally.

@Christopher-Chianelli You're right, the code used to be there, but it must have been removed during some of the earlier work. I still believe the reported behavior is a bug and shouldn't have been allowed; I'll merge this.


Use "output" to pass the pr number as a string

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.


Integration Failed to setup error

My integration has stopped working.
Core 2024.12.2
Supervisor 2024.11.4
Operating System 14.0
Frontend 20241127.7
Logger: custom_components.polestar_api
Source: custom_components/polestar_api/init.py:34
integration: Polestar API (documentation, issues)
First occurred: 11:36:32 (2 occurrences)
Last logged: 13:45:21
Unexpected Error on update data cannot access local variable 'resumePath' where it is not associated with a value
Traceback (most recent call last):
File "/config/custom_components/polestar_api/init.py", line 34, in async_setup_entry
await coordinator.async_init()
File "/config/custom_components/polestar_api/polestar.py", line 143, in async_init
await self.polestar_api.async_init()
File "/config/custom_components/polestar_api/pypolestar/polestar.py", line 61, in async_init
await self.auth.get_token()
File "/config/custom_components/polestar_api/pypolestar/auth.py", line 85, in get_token
if (code := await self._get_code()) is None:
^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/polestar_api/pypolestar/auth.py", line 140, in _get_code
if resumePath is None:
^^^^^^^^^^
UnboundLocalError: cannot access local variable 'resumePath' where it is not associated with a value

See https://github.com/pypolestar/polestar_api/issues/265

Please test the current version and open a new issue if the problem persists.


App in Background disconnect device by closing socket

Hello.
My name is @Filip
Thanks for your helpful source.
I'm using this to integrate and expand our project for casting media.
But i'm getting trouble with some issues.

First, When the app goes into background, the google cast sdk close the socket, so my iphone disconnected from cast device.

I need to keep the session and not disconnect.

Second, when i disconnected from device, i retry to connect manually, but i'm getting the following errors.

[GCKDeviceAuthChannel timerDidFire:] authentication timed out
[GCKCastDeviceConnector deviceAuthChannel:didFailToAuthenticateWithError:] Not an authentic device, disconnecting.
Error Domain=com.google.GCKError Code=3 "Device authentication failure" UserInfo={NSLocalizedDescription=Device authentication failure}

I don't understand why is that. When i try to connect first, there is no authentication error, but i retry to connect secondly, i'm getting authentication error.
Please help me.
This is urgen issue for our project.
Thanks.
Regards.

The SDK should reconnect automatically when the app goes into the foreground. If you are seeing different, then you can file a bug: https://issuetracker.google.com/issues?q=componentid:190205 status:open&s=modified_time:desc

Hello @entertailion
Thanks for your quick response.
But what about the following problem?

[GCKDeviceAuthChannel timerDidFire:] authentication timed out
[GCKCastDeviceConnector deviceAuthChannel:didFailToAuthenticateWithError:] Not an authentic device, disconnecting.
Error Domain=com.google.GCKError Code=3 "Device authentication failure" UserInfo={NSLocalizedDescription=Device authentication failure}

It happend when i try to reconnect device.
Thanks.
Regards.

Please file that as a bug.


Reduce console.log message size and move padding to css

Superseded by #79
Thank you for your PR, still!


Implement SPDY Push

This changeset introduces support for SPDY Push by utilizing a new delegate on SPDYSession. Closes #1
This is a focused subset of the larger changes that we have been maintaining in the @layerhq branch. This isolates the changes necessary to support SPDY Push.
Utilizing push requires registering a delegate for the SPDYSessionManager so that you can attach a delegate to each SPDYSession as it is dispatched by CocoaSPDY. You must also issue a hanging GET request so that the server has a SPDY stream that it can push responses back against. We’re using it successfully with an Erlang server utilizing the Cowboy server.

@kgoodier did this work get abandoned? I’m looking at brings my fork inline with the develop branch and it looks like there’s still no push support

Hi @blakewatters, nope, this is still in progress, just got de-prioritized for a bit. I ran into some subtle issues about how to expose request/response metadata, and that led to some changes to the push API presented here. It got simplified a lot so the app doesn't have to do much at all or implement any new interfaces.
For your use case of a long pull followed by notifications of new pushed streams, it should work like:

register for an NSURLNotification for incoming push streams
issue long pull
server sends back push streams associated with the long pull
spdy stores these in a temporary "in-progress" cache and issues a notification
when app gets notification, issue a new NSURLRequest using the url for the pushed stream. this will get hooked up to the already-in-progress push stream, and proceeds like any other standard NSURL-based http request.

I'm working on the final integration tests to make sure everything actually works, but the bulk of the coding is done except for the NSNotification stuff. I won't get much done next week, but expect to focus 100% on finishing this up the week after.
We're also intending to get the current develop branched merged into master and make another release. It's been a while and a lot of good things have gone in. That will happen prior to push getting integrated.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


⚠ Roblox Devforum has degraded performance

In fa112d7, Roblox Devforum (https://devforum.roblox.com) experienced degraded performance:

HTTP code: 500
Response time: 1233 ms

Resolved: Roblox Devforum performance has improved in 4ce9f25 after 5 minutes.


Fail to add song to new playlist

Please help check due to it was freeze when i add new song to new playlist and it was not auto play like before.

Unable to add in playlist

Will not add songs to playlist. Just gets stuck on adding. Plus it will not let me name any playlist by name. Please help.


Feedback: name the configuration files based on the project title initially provided.

Feedback from Garrett: https://positpbc.slack.com/archives/C06B0UZKT34/p1722620392603039

We can use the title:

We need to shorten it since the title can be very long
We can put a very short hash on it at the end to add some uniqueness


CiaB: Do not rebuild Traffic Server when the ATS RPM spec changes

This PR makes the ATS RPM no longer rebuild when Make detects that the files in $(TC_DIR)/cache-config/testing/docker/trafficserver/ have changed, which saves 6-8 minutes of local build time for CDN in a Box.
The ATS RPM will still rebuild whenever a new commit is pushed to apache/trafficserver:8.1.x

Which Traffic Control components are affected by this PR?

CDN in a Box

What is the best way to verify this PR?

In the CDN in a Box directory, build the targets using makemake -j$(nproc)

Update a file in the cd cache-config/testing/docker/trafficserver directoryecho echo An update >> ../../cache-config/testing/docker/trafficserver/run.sh

Run make again, verify that no targets are rebuiltmake

Expected output:make: Nothing to be done for 'all'.

PR submission checklist

[ ] This PR has tests
[ ] This PR has documentation
[ ] This PR has a CHANGELOG.md entry
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

But... doesn't this mean that if the process for generating an ATS RPM for CiaB changes, it won't correctly detect that it needs to rebuild the RPM and those changes won't be propagated to CiaB?

But... doesn't this mean that if the process for generating an ATS RPM for CiaB changes, it won't correctly detect that it needs to rebuild the RPM and those changes won't be propagated to CiaB?

That is an unlikely edge case that can be fixed if the user runs make very-clean, which should be early on in their process for troubleshooting ATS not working.
90% of CDN in a Box (including t3c) works without ATS functioning properly, but if it does ever break (e.g., if we ever change to a /-prefixed RPM instead of /opt/trafficserver/-prefixed), the ATS RPM  gets rebuilt whenever<EMAIL_ADDRESS>is updated (about once a month), so that issue would go away with time anyway.
IMO not having to rebuild the ATS RPM when switching Git branches is well worth having this edge case. But if you uhave another idea to avoid unnecessarily rebuilding the ATS RPM, I'm all ears

not having to rebuild the ATS RPM when switching Git branches is well worth having this edge case.

Why do you have to rebuild the ATS RPM when you switch git branches? You should only have to rebuild if the sources in that directory change. The specfile you reference in the title has only changed seven times this year.
I just verified that switching git branches doesn't make you rebuild that:
$ time make cache/trafficserver.rpm
make: 'cache/trafficserver.rpm' is up to date.
make cache/trafficserver.rpm  0.02s user 0.04s system 141% cpu 0.046 total
$ git checkout 1f264bf1624246616a62ffe93c6ddb7d7a095ff0
Note: switching to '1f264bf1624246616a62ffe93c6ddb7d7a095ff0'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 1f264bf16 Fixes the cache-config integration tests. (#6755)
$ time make cache/trafficserver.rpm
make: 'cache/trafficserver.rpm' is up to date.
make cache/trafficserver.rpm  0.02s user 0.04s system 137% cpu 0.044 total

Why do you have to rebuild the ATS RPM when you switch git branches? You should only have to rebuild if the sources in that directory change.

It's not only about the sources, it's also about the age of the Traffic Server RPM in the dist/ directory. If make detects that the sources are newer than the already-build Traffic Server RPM, it will try to build the RPM again. For example, if dist/trafficserver-8.1.5-1.c16631ab0.el8.x86_64.rpm already exists, but you touch the sources to make them newer:
[zrhoffman@computer cdn-in-a-box]$ touch ../../cache-config/testing/docker/trafficserver/*
[zrhoffman@computer cdn-in-a-box]$ make --debug cache/trafficserver.rpm
GNU Make 4.3
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Reading makefiles...
Updating makefiles....
Updating goal targets....
   Prerequisite '../../cache-config/testing/docker/trafficserver/cjose.pic.patch' is newer than target '../../dist/trafficserver-8.1.5-1.c16631ab0.el8.x86_64.rpm'.
   Prerequisite '../../cache-config/testing/docker/trafficserver/Dockerfile' is newer than target '../../dist/trafficserver-8.1.5-1.c16631ab0.el8.x86_64.rpm'.
   Prerequisite '../../cache-config/testing/docker/trafficserver/jansson.pic.patch' is newer than target '../../dist/trafficserver-8.1.5-1.c16631ab0.el8.x86_64.rpm'.
   Prerequisite '../../cache-config/testing/docker/trafficserver/run.sh' is newer than target '../../dist/trafficserver-8.1.5-1.c16631ab0.el8.x86_64.rpm'.
   Prerequisite '../../cache-config/testing/docker/trafficserver/traffic_server_jemalloc' is newer than target '../../dist/trafficserver-8.1.5-1.c16631ab0.el8.x86_64.rpm'.
   Prerequisite '../../cache-config/testing/docker/trafficserver/trafficserver.spec' is newer than target '../../dist/trafficserver-8.1.5-1.c16631ab0.el8.x86_64.rpm'.
  Must remake target '../../dist/trafficserver-8.1.5-1.c16631ab0.el8.x86_64.rpm'.
docker-compose -f ./../../cache-config/testing/docker/docker-compose-ats-build.yml build --parallel trafficserver_build && docker-compose -f ./../../cache-config/testing/docker/docker-compose-ats-build.yml run --rm trafficserver_build
[+] Building 0.9s (5/10)
 => [internal] load build definition from Dockerfile                                                              0.4s
[and so on]

but if you cancel that, then touch the RPM to make it newer:
[zrhoffman@computer cdn-in-a-box]$ touch ../../dist/trafficserver-8.1.5-1.c16631ab0.el8.x86_64.rpm
[zrhoffman@computer cdn-in-a-box]$ make --debug cache/trafficserver.rpm
GNU Make 4.3
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Reading makefiles...
Updating makefiles....
Updating goal targets....
 Prerequisite '../../dist/trafficserver-8.1.5-1.c16631ab0.el8.x86_64.rpm' is newer than target 'cache/trafficserver.rpm'.
Must remake target 'cache/trafficserver.rpm'.
cp -f "../../dist/trafficserver-8.1.5-1.c16631ab0.el8.x86_64.rpm" "cache/trafficserver.rpm" || (rm ".//cache/ATS_VERSION"; false)
Successfully remade target file 'cache/trafficserver.rpm'.

#6525 fixes this problem

Oh, so you mean like you switch to a branch where the source is changed and then switch back it still thinks the source is newer?
That's true, but it seems extremely rare since that hardly ever changes.

It happens frequently to me. Just running this triggers an ATS RPM rebuild for me the next time I run make cache/trafficserver.rpm.
git checkout 1f264bf162~ && git checkout apache/master

I just verified that switching git branches doesn't make you rebuild that:

That is a different result than I got. You used 1f264bf162, which is most recent time the ATS RPM directory was changed. How about 1f264bf162~?

I didn't check for a commit where any specific file was modified I just did ~HEAD, because I thought you meant it would happen any time you switch branches.

This still feels like a step backwards, though. Make is doing its level-best to tell if something needs to be rebuilt, but it's just not quite smart enough to do it - so instead we just give up any kind of change detection?

@ocket8888 Yes, because that RPM is not being used for ATS development, it uses ATS release branches. ATS_SOURCES does not refer to the source code of ATS, just the sources for this particular build environment, which is pretty mundane.
If a developer wanted to test their own ATS dev work in CDN in a Box, they would supply their own RPM, in which case they wouldn't want to use the makefile for the ATS RPM anyway.
That's an edge case, though. Most people using CDN in a Box just wand an ATS RPM, any ATS RPM. Recall that, until #5920, we used an ancient ATS RPM from ATS's CI server, it wasn't a make goal at all.
https://github.com/apache/trafficcontrol/blob/eff8f8fffed29675f6e0c4a2795d0d83efd983ad/infrastructure/cdn-in-a-box/cache/Dockerfile#L76-L77


App not showing interstitial ad after closing

I only use interstitial in the app. An interstitial ad appears on the first click on app launch, and it takes 15 clicks for the ad to appear again.
The problem is that when I exit the app and re-enter after a while, it doesn't show ads on the first click. In fact, sometimes the problem of not showing ads on the first click takes a few days. But after 15 clicks it shows ads.
What I want to do is show an ad on the first click of users every time they enter the app. I'm not sure if this is a bug or something with the code.
PS: I am using getx state management - The ad impression limit is limited to 5 times a day per user.
Interstitial ad controller:
class AdController extends GetxController {
  InterstitialAd? interstitialAd;
  int adCounter = 0;

  int interstitialLoadAttempts = 0;
  int maxAttempts = 3;

  void onAdLoaded(InterstitialAd ad) {
    interstitialAd = ad;
    interstitialLoadAttempts = 0;

    interstitialAd?.fullScreenContentCallback = FullScreenContentCallback(
      onAdDismissedFullScreenContent: (ad) {
        interstitialAd?.dispose();
        initAd();
      },
      onAdFailedToShowFullScreenContent: (ad, error) {
        interstitialAd?.dispose();
        initAd();
      },
    );
  }

  void initAd() {
    InterstitialAd.load(
      adUnitId: AdHelper.interstitialAdUnitId,
      request: const AdRequest(),
      adLoadCallback: InterstitialAdLoadCallback(
        onAdLoaded: onAdLoaded,
        onAdFailedToLoad: (error) {
          interstitialLoadAttempts++;
          interstitialAd = null;

          if (interstitialLoadAttempts <= maxAttempts) {
            initAd();
          }
        },
      ),
    );
  }

  void getAd() {
    if (adCounter % 15 == 0 && interstitialAd != null) {
      interstitialAd?.show();
      interstitialAd = null;
    }
    adCounter++;
  }

  @override
  void onInit() {
    initAd();
    super.onInit();
  }

  @override
  void dispose() {
    interstitialAd?.dispose();
    super.dispose();
  }
}

Ad display:
AdController AdController = Get.put(AdController());
return Padding(
 padding: EdgeInsets.symmetric(
   horizontal: 7.w,
   vertical: 8.h, ),
      child: GestureDetector(
         onTap: () {
            AdController.getAd();
             Get.to( const ContentIndex(),
              transition: Transition.native,
              duration: const Duration(milliseconds: 250),
              arguments: contentDex,  );

This seems like an issue with the ads plugin you're using and should be reported on their repo.
Closing from here.
Thank you


Suggestion about SR dataset

Hi,
Thank you for you amazing project!
When I use your mmedit for SR work, I think a pre-process script is needed.
DIV2K website only provide HR(training and validation), so we still need to use matlab to post-process data.
So, I think providing a link to download processed dataset is a better choice (since some process error may bring bad performance).

After pre-process dataset, how to get 'data/DIV2K/meta_info_DIV2K800sub_GT.txt'?

for set5 and set14, why only add LR image in data folder? Why don't we need HR images of set5 and set14?
The instruction is strange to follow

ValueError: You may use too small dataset and our distributed sampler cannot pad your dataset correctly. We highly recommend you to use fewer GPUs to finish your work
This question maybe the problem of dataset, I think there is no need for such cumbersome dataset processing.
The instruction of mmsr is hard to understand.


Migrate KorpheFunction.IterableConcat to a KorypheBinaryOperator.IterableConcat

Migrate KorpheFunction.IterableConcat to a KorypheBinaryOperator.IterableConcat

@GCHQDev404 Is this a breaking change that needs to go in Gaffer 2.0?