Analyzer gives bogus messages on a clean Flutter dev channel checkout. (re: stale .dart_tool)

I'm seeing a problem in the analyzer in the HEAD on flutter (flutter analyze --flutter-repo). It gives incorrect errors:
  error • The argument type 'BuildContext (where BuildContext is defined in
         /Users/gspencer/code/flutter/packages/flutter/lib/src/widgets/framework
         .dart)' can't be assigned to the parameter type 'BuildContext (where
         BuildContext is defined in
         /Users/gspencer/code/flutter/packages/flutter/lib/src/widgets/framework
         .dart)' • packages/flutter/lib/src/cupertino/theme.dart:450:51 •
         argument_type_not_assignable

When a) the code hasn't changed, and b) it's saying that it can't assign between types, but references the same location twice.  There are a lot of these errors, but it's also not just that type.  It has a bunch of errors about The argument type 'DiagnosticsProperty' can't be assigned to the parameter type 'DiagnosticsNode', when DiagnosticsProperty directly extends DiagnosticsNode.
Here's a Gist with some (>800) example errors on a "clean" flutter repo on master:
https://gist.github.com/gspencergoog/5d21b7fa6594e8086e15c0bd9b001b14
Originally they went away when I sync'ed back to a flutter (2eed59c1d) that was older than the most recent Dart roll (https://github.com/flutter/engine/pull/14453), but now it happens even at that revision.
I have tried the following:

nuking my flutter cache dir
nuking ~/.dartServer
nuking ~/.pub-cache
rebooting my machine, deleting the above again, running git clean -f; git reset --hard.
Downloading the latest Flutter dev channel package and unpacking it into a fresh directory.  Running a flutter analyze --flutter-repo there resulted in 329,508 errors.
had someone else run the analyzer on their repo, and it worked fine for them, and
it also works fine on the CI systems, so it's something local with my machine/config.

Between the time it worked, and when it stopped working, I didn't change my config, I just synced to the latest master revision.
I'm kind of running out of things to try...
This is on macOS.
Flutter 1.13.3-pre.23 • channel unknown • unknown source
Framework • revision c06bf6503a (8 hours ago) • 2019-12-13 17:42:35 -0500
Engine • revision e0e0ac0a68
Tools • Dart 2.8.0 (build 2.8.0-dev.0.0 45db297095)

@scheglov

OK, I tried the following:

nuking my flutter cache dir
nuking ~/.dartServer
nuking ~/.pub-cache

All of which I had done before.  Then I did this:

deleted ~/Library/Caches/flutter_engine
ran git clean -d -x -f

And lo and behold!  No analyzer issues now. Yay!
I did save a tar file of my flutter directory before I did the git clean (but after removing the cache).  I restored that directory, and now it shows 106 issues.
I then tried removing all of the build directories, and that seemed to fix it too, so I started alternately removing them and running the analyzer, and eventually narrowed down the problem to the directory packages/flutter/.dart_tool/build.
I started narrowing down files in that dir, and if I remove packages/flutter/.dart_tool/build/ec9b995a9d0b4aafe92e2a32b59a3f3c/asset_graph.json, the analyzer errors disappear.  I've attached a tarball with just that asset graph.
broken_build.tar.gz

The curious thing to me is that when I downloaded a fresh zip file from our website (e.g. this dev channel 1.13.2), I got 300K errors, and that asset_graph.json file doesn't exist in that zip file (or one similar).
I tried unpacking the zip file and removing all the temporary things to reduce it back to a "base" repo, but no matter what I removed, it still gave me the 300K errors. Here's what I tried:

nuking  flutter/bin/cache
nuking ~/.dartServer
nuking ~/.pub-cache
ran git clean -d -x -f
ran git clean -d -X -f

So I downloaded https://storage.googleapis.com/flutter_infra/releases/dev/macos/flutter_macos_v1.13.2-dev.zip, unzipped it, and then executed ./bin/flutter analyze --flutter-repo and got 365K errors. I captured the full log but it was too big for a GitHub comment or even a gist.
[✓] Flutter (Channel dev, v1.13.2, on Mac OS X 10.14.6 18G87, locale en-US)
    • Flutter version 1.13.2 at /Users/fujino/Downloads/flutter 2
    • Framework revision 4944622b5d (4 days ago), 2019-12-12 18:43:58 +0000
    • Engine revision 12bf95fd49
    • Dart version 2.7.0 (build 2.7.0-dev.2.1 8b8894648f)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/fujino/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.2)
    • Xcode at /Users/fujino/Downloads/Xcode-beta.app/Contents/Developer
    • Xcode 11.2, Build version 11B44
    • CocoaPods version 1.7.5

[✓] Android Studio (version 3.4)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 37.0.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[!] Connected device
    ! No devices available

! Doctor found issues in 1 category.

Does it work if you run flutter update-packages before flutter analyze --flutter-repo?

Yes, it appears to work when I do that...

Seeing the same problem after doing a flutter upgrade on the dev branch.

git clean -xffd (which deletes the .dart_tool directories) seems to fix it.

Related: #52375

It looks like this issue has since been resolved. Please re-open if it happens again.

It looks like this issue has since been resolved. Please re-open if it happens again.

It looks like this issue has since been resolved. Please re-open if it happens again.

@srawlins how was it resolved?

It looks like this issue has since been resolved. Please re-open if it happens again.

@srawlins how was it resolved?

I'm not sure how it was resolved. It just appears that people have been able to analyze with a clean Flutter dev checkout.

I'm not sure how it was resolved. It just appears that people have been able to analyze with a clean Flutter dev checkout.

No, it surely is not resolved. Happens to me on a lot of checkouts.

Re-opening as this recently started blocking the Flutter tree: https://github.com/flutter/flutter/issues/108982
Locally on commit: https://github.com/flutter/flutter/commit/74aef9ff8786951fe0c4bd4c96dcb7b80caec219
I ran the same command twice, with different results:
~/git/flutter/packages/flutter_tools$ rm -rf /home/fujino/.dartServer/ && flutter analyze .
Analyzing flutter_tools...
No issues found! (ran in 18.3s)
~/git/flutter/packages/flutter_tools$ rm -rf /home/fujino/.dartServer/ && flutter analyze --flutter-repo
Analyzing 3 items...

  error • The named parameter 'breakpoints' is required, but there's no corresponding argument •
         ../flutter_driver/test/src/real_tests/flutter_driver_test.dart:1231:36 • missing_required_argument
  error • The named parameter 'exceptionPauseMode' is required, but there's no corresponding argument •
         ../flutter_driver/test/src/real_tests/flutter_driver_test.dart:1231:36 • missing_required_argument
  error • The named parameter 'isSystemIsolate' is required, but there's no corresponding argument •
         ../flutter_driver/test/src/real_tests/flutter_driver_test.dart:1231:36 • missing_required_argument
  error • The named parameter 'isolateFlags' is required, but there's no corresponding argument •
         ../flutter_driver/test/src/real_tests/flutter_driver_test.dart:1231:36 • missing_required_argument
  error • The named parameter 'libraries' is required, but there's no corresponding argument •
         ../flutter_driver/test/src/real_tests/flutter_driver_test.dart:1231:36 • missing_required_argument
  error • The named parameter 'livePorts' is required, but there's no corresponding argument •
         ../flutter_driver/test/src/real_tests/flutter_driver_test.dart:1231:36 • missing_required_argument
  error • The named parameter 'name' is required, but there's no corresponding argument •
         ../flutter_driver/test/src/real_tests/flutter_driver_test.dart:1231:36 • missing_required_argument
  error • The named parameter 'pauseEvent' is required, but there's no corresponding argument •
         ../flutter_driver/test/src/real_tests/flutter_driver_test.dart:1231:36 • missing_required_argument
  error • The named parameter 'pauseOnExit' is required, but there's no corresponding argument •
         ../flutter_driver/test/src/real_tests/flutter_driver_test.dart:1231:36 • missing_required_argument
  error • The named parameter 'runnable' is required, but there's no corresponding argument •
         ../flutter_driver/test/src/real_tests/flutter_driver_test.dart:1231:36 • missing_required_argument
  error • The named parameter 'startTime' is required, but there's no corresponding argument •
         ../flutter_driver/test/src/real_tests/flutter_driver_test.dart:1231:36 • missing_required_argument

11 issues found. (ran in 111.5s)

Closing in favor of https://github.com/dart-lang/sdk/issues/49596


fix Scan() to output the correct IP and Port

Scan(): pass copies of ip and port into the goroutine
fixes #4

Had the same issue, I can confirm this fixes the issue :)


failed to resolve file: "/contracts/IGelatoVRFConsumer.sol": No such file or directory

Hello! I'm using forge foundry and I'm getting this issue after installing this dependency. I'm changing it from:
import {IGelatoVRFConsumer} from "/contracts/IGelatoVRFConsumer.sol";
to
import {IGelatoVRFConsumer} from "./IGelatoVRFConsumer.sol";

Thanks for the report @charlenenicer
We've fixed the issue here: https://github.com/gelatodigital/vrf-contracts/pull/101


[CARBONDATA-2256] Adding sdv Testcases for SET_Parameter_Dynamically_…

…Feature
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[x] Testing done
sdv testcase added

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3105/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4339/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3898/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3143/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4377/

Retest this please

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3192/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4426/

Retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4438/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3205/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4445/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3212/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3967/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3230/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3980/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4463/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3236/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3239/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3240/

retes this please

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3985/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3987/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3988/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3249/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4479/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3995/

can you add a test scenario where the same property is added to set command and load command and the load command should have higher priority!!

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4596/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3370/

Retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4602/

Retest SDV please

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3382/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4607/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4107/

Retest sdv please

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4108/

Retest sdv please

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4114/

Retest this please

Retest sdv please

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3389/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4614/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4116/

Retest sdv please

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4131/

@kunal642 added a test scenario where the same property is added to set command and load command and the load command should have higher priority!!


IndentationError: unexpected indent

Expected Behavior
Bot should start up as usual
Actual Behavior
After running the bot earlier today I tested some of the PRs, but reverted back to the original master branch. Now I keep getting the same error and can't fix it myself, since I'm only slowly getting the hang of python.
After doing
python pokecli.py

I get the following message:
Traceback (most recent call last):
  File "pokecli.py", line 39, in <module>
    from pokemongo_bot import logger
  File "/Users/***/Desktop/PokemonGo-Bot/pokemongo_bot/__init__.py", line 89
    forts.sort(key=lambda x: distance(self.position[
    ^
IndentationError: unexpected indent

I hope you guys can help me.
Steps to Reproduce
$ git clone -b master https://github.com/PokemonGoF/PokemonGo-Bot
$ cd PokemonGo-Bot
$ virtualenv .
$ source bin/activate
$ pip install -r requirements.txt
$ git submodule init
$ git submodule update

Other Information
OS: OS X El Capitan 10.11.6
Git Commit: 32cefeed4760d6b5d2b3eb76d783d0f13d068e83

Delete the space in line 90. Line 89 should look like this:
89: forts.sort(key=lambda x: distance([0], self.position[1], x['latitude'], x['longitude']))

Please upgrade to the latest dev branch by running this command:
git reset --hard
git pull -f

Then run this command:
pip install --upgrade -r requirements.txt
If issue persists, open a new issue.
/closed


Not supported when appending bone is enabled

When check "Append Leg IK bones"、"Append eye pose", it'll always show this error

Hmm it's not possible to use MLTD (and convert) motions with bones modified (appending IK, eyes, and semi-standard bones), at least for now. The UI should reflect this. I'll fix the UI guidance so you'll not choose impossible combinations again. It's also time to think about writing a manual...

I think the impossible combinations are excluded by control states (enabled or not) now. Please check the latest auto build.
Related commits

This bug does not occur in later builds.


Multiple Patched Versions Allowed?

Still struggling with back-porting some security fixes. I have version 2.0.0, 2.1.0, 2.2.0, 2.2.1 (patched) and 2.2.2 (patched). My security advisory currently states affected version is >= 2.0.0, < 2.2.1 and patch version specifies 2.2.1. However, some (not all) users of 2.1.0 cannot yet meet the prerequisites to migrate to 2.2.1. So I am planning to create a version 2.1.1. I could split this up into multiple conditions on the Security Advisory, but I am not sure what to specify. Can I specify affected version as >= 2.0.0, < 2.1.1 with a patched version of 2.1.1, 2.2.1, and then another condition with affected version 2.2.0 with a patched version 2.2.1?

Hi @oleibman, it is possible for an advisory to have more than one patched version as long as there is at least one vulnerable version separating the patched versions. In the example you describe, it is possible to have two vulnerable version ranges, >= 2.0.0, < 2.1.1 and >= 2.2.0, < 2.2.1 (with = 2.2.0 also being acceptable if 2.2.0 is the only vulnerable version on the 2.2 branch), and two patched versions, 2.1.1 and 2.2.1. As you correctly noted, if there are two adjacent patched versions with no vulnerable versions between them, such as 2.2.1 and 2.2.2, the lower/older of the two patched versions would be listed as the patched version.
Hope this information helps! 🙂 If and when you release a patch in 2.1.1, you are welcome to tell us to add it to the advisory by making a PR at https://github.com/github/advisory-database/pulls.


React App Compilation failing due to missing eslint cache file

Can you reproduce the problem with latest npm?
Yes
Description
React app compilation is periodically / intermittently failing with the error due to a change in eslint-caching as per #1578. A cache file is missing in the node_modules directory
Expected behavior
App should compile with no errors
Actual behavior
The create-react-scripts throw the following error when compiling on file change:
Module build failed: Error: ENOENT: no such file or directory, open '/app/client/node_modules/.cache/eslint-loader/data.json'

On closer inspection this seems to happen when I rename / add a new file. However it happens so randomly it has been difficult to pin down.
Environment
Run these commands in the project folder and fill in their results:

npm ls react-scripts (if you haven’t ejected):

npm info it worked if it ends with ok
npm info using<EMAIL_ADDRESS>npm info using<EMAIL_ADDRESS><EMAIL_ADDRESS>/app/client
`--<EMAIL_ADDRESS>
npm info ok

node -v:

v7.6.0

npm -v:

4.1.2

Operating system: OSX running Docker Image: https://hub.docker.com/r/dylanrhysscott/docker-react-dev/ which is based off of official node images

Browser and version: Chrome 56.0.2924.87 (64-bit)

Ping @Timer - Here's the issue. I can't provide my project as its on a private Git server internally but will do all I can to help troubleshoot. Hope this helps!

One other thing I forgot to mention is - I'm using YARN rather than NPM directly. Could this also have an effect? My version of YARN is: 0.20.3

hmm, is the process running in a container that reads host filesystem?

@viankakrisna It's using a shared volume which mounts my source code yeah. I've been using this custom image for a while with a few other projects and not had issues. It downloads the latest version of the create-react-scripts at runtime. Is it worth doing a quick copy into the container avoiding the volume mount?

Yup, can you try that? also, does setting the env CHOKIDAR_USEPOLLING=true helps? I think there are some delays between the filesystem and the watcher process

@viankakrisna Hmmm just inspected my node_modules directory and the required json file is there. I did run an automated build which grabbed a fresh copy of the node base image just to rule that out. Looking at the last update to the node base image I was up to date anyway. The eslint-loader directory is there where it was missing before. Reinstalling the node_modules and it is still there. Possible my usage of YARN didn't actually install all the required folders? Or the watcher wasn't creating it due to volume delays? I will keep messing until I can get a definitive cause for you if there is one

I appreciate the docker usage is probably outside your remit :)

yup, can you also try the CHOKIDAR_USEPOLLING? need to rule out all option before fire up a docker image to dig on that. Here's the link to do that https://github.com/facebookincubator/create-react-app/blob/5155797983476260a6e6e8d93ca38b43233d82de/packages/react-scripts/template/README.md#npm-start-doesnt-detect-changes

Looking at the eslint-loader implementation of caching, it seems to miss error handling in a few crucial places. For example, when writing the file, or when potentially creating a directory.
If babel-loader can't create a directory in node_modules, it will fall back to OS directory. However, eslint-loader will fail here, and the fallback will never kick in.
If babel-loader's cache gets deleted while the server is running, it will still attempt to create a directory before writing a file. eslint-loader will only do this once and not for subsequent writes even though the cache might have been deleted. And failing to write the file on subsequent writes will crash it instead of trying to fall back to OS directory like babel-loader does.
It seems like eslint-loader implementation of caching could use some error handling work. It would be awesome if someone could fix it up in a few days, but if not, we’ll likely revert the option because it’s just not as reliable as the Babel option.

@gaearon Hi Dan, Thanks for the breakdown. I currently can't replicate this issue as the eslint-loader directory is being created with data.json seems to be an edge case. Will keep an eye on this issue and will update my images when a fix is available.

Bumped into this issue. Super frustrating 😞

From what I noticed: this issues consistently appears after yarn-installing new module.

confirmed that this is consistently happening after yarn installing new module. I'm digging on it right now

Going to revert this in the next version: https://github.com/facebookincubator/create-react-app/pull/1665.
Unless you can figure out a patch to eslint-loader to fix this 😉

here's the patch for the unwritable cache file
https://gist.github.com/viankakrisna/76ee7702e3592ab743cea63787e47295
@dylanrhysscott @rogovdm can you confirm that replacing index.js of eslint-loader with this file solve your problems?
@gaearon need your feedback on this too 😄

@viankakrisna Hey I've tested this and it appears to work. I tested by running yarn add randomstring then compiling files. I also tried the inverse yarn remove randomstring and compiling files. Didn't get any compilation errors. Something that does concern me however is after I applied the fix and during the startup of my app (running YARN) my Macbook bombed out on a fatal exception (looked like a memory issue). Probably a specific of me using Docker on my setup. Never happened to me before. Just thought I'd mention it. Apart from that looks good! Nice work

@dylanrhysscott Great! Glad that it helps. Not sure what causes the bomb though 😭
If anybody wants to try a reimplementation of eslint-loader cache with babel-loader's fs-cache, you can try it here https://github.com/MoOx/eslint-loader/pull/159 Feedbacks are gladly appreciated

@viankakrisna  Not sure if helpful, but I had the same issue after using yarn to add purecss. I tried your patch, and in my case it did not fix the issue. I don't have a great deal of dev experience, so please take that into consideration.  I'm on Windows. I had to resort to deleting node_modules and reinstalling. Thanks to everyone for their contributions here.

I tried your patch, and in my case it did not fix the issue.

Which of two patches in this thread did you try? Have you restated the server after applying it?

@gaearon I used the patch located at: https://gist.github.com/viankakrisna/76ee7702e3592ab743cea63787e47295
I'm trying to remember, but I think it's possible that I overlooked restarting the server, as I recall spending  some of my time trying to decipher the error message provided by create-react-app in the original browser window. In retrospect that should have been obvious. My apologies, you can most likely disregard my input.

@viankakrisna Hi just ran into this error again after YARN adding a package. Still had the fix applied and it threw the same error. Looks like an issue with larger more complete YARN packages being added that the one I initially tested. After adding a package my .cache directory appears to be missing again :(. Any ideas?

I've updated the gist after the last time i publish it, can you try it?
Also, do you check that the patched file is intact inside the node_modules? I'm beginning to think that every time you run yarn it will overwrite the folders inside node_modules with its own cached version.
I've published another fix in here https://github.com/viankakrisna/eslint-loader/tree/port_babel_loader_fs_cache which uses loader-fs-cache ported from babel-loader's fs-cache and need some testing. Would you try it? You need to manually clone it to react-scripts node_modules and run yarn / npm install though because of the added dependencies.
The pr is here https://github.com/MoOx/eslint-loader/pull/159. Need to port the test from babel-loader to let the CI passes
@gaearon I'm beginning to think that it's wiser to do revert and wait until eslint-loader cache implementation tested and tried for a while before enabling it. It's too frustrating for the user to experience this...
And i'm sorry for the silly pull request that started it all...

@viankakrisna Confirmed looks like YARN is overwriting the patch file....I've cloned your fixes into my create-react-scripts/node_modules and done an npm i. I had to also install eslint due to an unmet deps warning for your fix. For good measure I've also started with a clean copy of my node_modules for my project. With the watch task running I've added and removed the package that triggered the original eslint-loader error. The error has triggered when I modify one of my react components as part of my project. Looking in my node_modules the cache directory is missing. Not sure if I'm missing anything here? Cheers for the help on this!

Hang on! Looks like my project is using a different directory from where I applied the fix... let me test :)

@viankakrisna OK so I've successfully applied the fix now in the .cache directory I had a babel-loader related directory. Everything was working on initial install, compiling fine. I've removed a package with YARN and the .cache directory is now gone and the error is back with a vengeance. I think a revert might be in order?

The only fix I want somebody to try is https://github.com/viankakrisna/eslint-loader/tree/port_babel_loader_fs_cache. Did anyone try it yet?

@dylanrhysscott you need to clone it in your react-scripts/node_modules folder inside your application node_modules folder, overwriting eslint-loader folder there.
so the path is like this YOURAPP/node_modules/react-scripts/node_modules/eslint-loader and do npm i there.
I don't think it will persist while yarn is always overwriting the folders though.
Need to find another way to patch it.
And yes, revert should be in order, currently i'm stuck with tests on the pr of porting fs-cache.

@viankakrisna Cheers I figured that after I did it :) Yeah YARN is overwriting it still @gaearon I think that was the one I tried once I got it in the correct directory. Let me know if there is any more tests you'd like me to run!

I've setup a repo of react-scripts with eslint-loader-fs-cache (a published package for the current pr ). Just replace your devDependencies from
"devDependencies": {
    "react-scripts": "0.9.2"
  }

To
"devDependencies": {
    "react-scripts": "viankakrisna/react-scripts-eslint-loader-fs-cache"
  },

and do yarn or npm install.

I’m going to move ahead with the revert for now, but happy to take another PR for 0.9.4 when this is sorted out.

@viankakrisna Sweet! Swapping out those devDeps to your repo seems to have fixed it! I have added a few packages and can still compile. Same in reverse 👍

Yea, need to be careful with that 😛 Master branch is very unstable.

@gaearon @viankakrisna Thanks for your help guys. Much appreciated!

I landed a revert of this in 0.9.3.
Please update to it while we're fixing the underlying issue.

deleted react-scripts patch repo and gists so we can focus on https://github.com/viankakrisna/eslint-loader/tree/port_babel_loader_fs_cache
@dylanrhysscott please update to 0.9.3!

@viankakrisna Just bumped the version on my project - all resolved!


Fix ogg.def file

Empty LIBRARY statement is valid for MSVC, but MinGW fails with syntax
error.

I went with the LIBRARY ogg solution in 42597febc81afd9cff783e1a06b0f3f4f98eebe2. Thanks!


Not working in AWS Lambda (0.16.2 - 0.17.4) OSError: Generic S3 error

Environment
Delta-rs version: 0.16.2 - 0.17.4
Binding: Python
Environment:

Cloud provider: AWS Lambda
OS: Python3.12
Other: Python3.12 + AWS SDK for Pandas Layer + Custom layer with Deltalake 0.17.4 and pyarrow_hotfix 0.6

Bug
What happened: Code is working in version 0.15.3
code snippet:
table_path = f's3://{BUCKET_NAME}/bronze/test'

def insert():
    print('writting')
    data = {"id": [1,2], "b": [2, 2]}
    df = pd.DataFrame(data)
    print(df)
    write_deltalake(table_path, df, mode='overwrite', overwrite_schema=True)
    print('written')

insert()

What you expected to happen:
Attempting to write_deltalake or any other operation will throw this error:
[ERROR] OSError: Generic S3 error: Error after 10 retries in 2.612435942s, max_retries:10, retry_timeout:180s, source:error sending request for url (https://s3.us-east-1.amazonaws.com/bucketname-bmdcgdma/bronze/test/_delta_log/_last_checkpoint): error trying to connect: invalid peer certificate: BadSignature
Traceback (most recent call last):
  File "/var/task/events/s3-update-nfts.py", line 127, in handler
    insert()
  File "/var/task/events/s3-update-nfts.py", line 35, in insert
    write_deltalake(table_path, df, mode='overwrite', overwrite_schema=True, storage_options=storage_options)
  File "/opt/python/deltalake/writer.py", line 265, in write_deltalake
    table, table_uri = try_get_table_and_table_uri(table_or_uri, storage_options)
  File "/opt/python/deltalake/writer.py", line 688, in try_get_table_and_table_uri
    table = try_get_deltatable(table_or_uri, storage_options)
  File "/opt/python/deltalake/writer.py", line 701, in try_get_deltatable
    return DeltaTable(table_uri, storage_options=storage_options)
  File "/opt/python/deltalake/table.py", line 405, in __init__
    self._table = RawDeltaTable(

How to reproduce it:

Use the AWS SDK for pandas managed layer for dependencies (pyarrow, numpy ect):
https://aws-sdk-pandas.readthedocs.io/en/stable/layers.html

Create a custom deltalake lambda layer:
requirements.txt

deltalake==0.17.4
pyarrow_hotfix==0.6

build.sh
mkdir -p ./dist/python
pip install -r requirements.txt -t ./dist/python --no-deps --platform manylinux2014_aarch64

following this article https://delta.io/blog/2023-04-06-deltalake-aws-lambda-wrangler-pandas/
added pyarrow_hotfix as its a required dependency not available in aws sdk for pandas layer

Add all s3 permissions to the aws lambda execution layer
set env var AWS_S3_ALLOW_UNSAFE_RENAME: 'true'
Use the layer to write delta table in aws lambda throw errors

More details:
Last working version 0.15.3 but not working from 0.16.2 - 0.17.4
Edit: 0.16.1 is working too, bug introduced int 0.16.2

I checked against 0.18.2 and it solved my problem


Update security-center-powershell-onboarding.md

@OrenPG : Thanks for your contribution! The author, @rkarlin, has been notified to review your proposed change.

#sign-off


AutoComplete suggestions

Looks great. Can you add autocomplete suggestions? That would both speed up the input and moreover, prevent duplicate tags.
Of course I can handle the ValidateTag event like this:
var existingTags = ... //(from database)

private Task<bool> ValidateTagAsync(string tag)
{
    bool result = !existingTags.Any(x => x.Equals(tag, StringComparison.OrdinalIgnoreCase));
    return Task.FromResult(result);
}

..but this would still result in duplicates if there's a different spelling, for example (or a typo).
If we can pre-populate the component with the suggestions, that would be helpful. Example:
<InputTags Value="Tags" Suggestions="autoCompleteSuggestions" MinChars="3" />

@code {
    public List<string> Tags { get; set; } = new();
    private IEnumerable<string> autoCompleteSuggestions; // Populate from database
}

Where MinChars would be the minimum number of characters for the user to type before suggestions start showing

Come to think of it, it would be better for the suggestions to be dynamic.. especially as new ones can be added at any time. So maybe this:
<InputTags Value="Tags" GetSuggestions="GetAutoCompleteSuggestionsAsync" MinChars="3" />

@code {
    public List<string> Tags { get; set; } = new();
    private async IEnumerable<string> GetAutoCompleteSuggestionsAsync(string userInput)
	{
	    // Populate from database. Example:
            return await context.Tags.Where(x => x.Name.Contains(userInput)).ToListAsync();
	}
}

Hi! Thanks for your suggestion!
The easy part is to get suggestions to the component. The harder part will be proper keyboard support.


Ybd

Hi @yizhihenpidehou, please add the .idea folder to your .gitignore file and use an descriptive PR title. Thanks. :)

Hi @yizhihenpidehou, please add the .idea folder to your .gitignore file and use an descriptive PR title. Thanks. :)

I have seen your commit message is descriptive, you can just name your PR title same as your commit message, which is easy to read. Refer to: https://www.ruanyifeng.com/blog/2016/01/commit_message_change_log.html
Btw, you can use the "git rebase" to merge your two commits into one. Refer to: https://cloud.tencent.com/developer/article/1690638
Overall, work is pretty good, solve these comments and push the code again~


Update ADOT Blog Posts

This PR is to update the ADOT blog to reflect all published posts for ADOT on the AWS Open Source blog - https://aws.amazon.com/blogs/opensource/category/management-tools/aws-distro-for-opentelemetry/
Issue # 203

closing, merged upstream.


nodeinfo support

nodeinfo some of clients requires nodeinfo message.
Ref(ja): https://github.com/pantasystem/Milktea/issues/1755

Should be implemented as of 185db88, please let me know if there are any issues!


chore(fw): add docstrings to all opcodes in opcodes enum

🗒 Description

Added docstrings to most of the opcodes in the Opcodes Enum.
Left TSTORE,TLOAD,SENDALL,RJUMPI,RJUMPV incomplete due to confusion
🔗 Related Issues
#383
✅ Checklist

[x] All: Set appropriate labels for the changes.
[X] All: Considered squashing commits to improve commit history.
[x] All: Added an entry to CHANGELOG.md.
[x] All: Considered updating the online docs in the ./docs/ directory.
[x] Tests: Included the type and version of evm t8n tool used to locally execute test cases:  e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
[X] Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Thanks for reviewing!
Implemented the suggested changes.
Please lmk if there's anything that needs to be modified :)

Thanks a lot for pointing out the problems @danceratopz !! :heart:
I'll try to get the VS Code setup done,handle the whitespaces & fix the issue with PUSH
will definitely let you know if I get stuck somewhere :)

Thanks !
and sorry for making so many mistakes in the PR :sweat_smile:

Hey @danceratopz I think we are unable to merge unless you approve the requested changes, if you'd like to give this another look :+1:

Hey @danceratopz I think we are unable to merge unless you approve the requested changes, if you'd like to give this another look 👍

Hey @marioevz, @spencer-tb's doing a last pass :sweat_smile: and will give some more input sooon, but I've approved the requested changes to avoid blocking!

I added some additional tweaks in: 035821f

General clean-up, removing .'s and newlines etc,
Fixed forkname mismatches,
Clean up of swap and push opcodes,
Gas formatting clean up (the markdown wasn't rendering nicely in vscode),
Ordered the opcodes,
Removed SENDALL as we don't use it anywhere,
Tox fixes.

Amazing. The most commented PR in the history of execution-spec-tests! Thanks again @ThreeHrSleep!


fix: loading OpenDyslexic font in React

Closes #7
Not the most elegant solution, but this seems to work. If anyone else has a better solution, feel free to make another PR.

File an issue to upgrade to webpack 5 whenever we can - for now this will do


Avoid referring to ".NET Framework" in release notes

Provide a description of requested docs changes
This is completely a nit, and not intended as ungratefulness for all of your efforts - but there is no such thing as .NET Framework 6(.x) as referred to in the 0.58 release notes. The current/latest version of .NET Framework is 4.8. .NET 6 is the successor to .NET 5 and .NET Core 3.x (as I'm sure you know) and use of "Framework" adds confusion imo.
TLDR - please considering saying ".NET 6" not "framework" going forward :)

This should be fixed now


migrate ROC program from test instance to prod

Once the ROC instance is launched in production, we need to "copy over" the carefully-designed program questions and forms from an internal dev server to the real production system.  Presumably we'd just do a SQL dump & load of some sort.

Seems like we already have some scripts that kind of do this -- dumping SQL data out of production AWS and into a dev instance.  We'd need to create new scripts that (1) aren't specific to AWS/GCP/Azure, just SQL in general, (2) go from any instance to any other instance.

wrote the pg_restore command to set this up and if we need to delete the tables do the connect to database and run the following commands in this order to delete the data from the database  DELETE FROM applications; DELETE FROM applicants; DELETE FROM accounts; DELETE FROM programs; DELETE FROM questions; DELETE FROM ti_organizations; DELETE FROM versions; DELETE FROM versions_programs; DELETE FROM versions_questions;


No DnsEndpoint created

What happened:
After creation of a Service Domain and a ServiceDNSRecord for the federated service，there's no DNSEndpoint result.
Any help will be appreciated！
root@master1:~# kubectl get dnsendpoint -A
No resources found

What you expected to happen:
A DnsEndpoint created
Environment:

Kubernetes version (use kubectl version)
v1.18.8
KubeFed version
v0.5.1
Scope of installation (namespaced or cluster)
Others

root@master1:~/kubefed# kubectl get  svc -n namespace-fed --context=cluster.ggz
NAME            TYPE           CLUSTER-IP      EXTERNAL-IP     PORT(S)          AGE
nginx-fed-svc   LoadBalancer   <IP_ADDRESS>   <IP_ADDRESS>   8000:31557/TCP   2d8h
root@master1:~/kubefed# kubectl get svc -n namespace-fed
NAME            TYPE           CLUSTER-IP       EXTERNAL-IP     PORT(S)          AGE
nginx-fed-svc   LoadBalancer   <IP_ADDRESS>   <IP_ADDRESS>   8000:32152/TCP   2d8h
root@master1:~/kubefed# kubectl get domain -A
NAMESPACE                NAME          AGE
kube-federation-system   test-domain   20m
root@master1:~/kubefed# kubectl get servicednsrecord -A
NAMESPACE       NAME            AGE
namespace-fed   nginx-fed-svc   20m

/kind bug

See there.

See there.

I got the same error. And All nodes have region/zone labels. As follow:

error log:

@conquerorAlex That functionality would be removed within the next release. I would try to have a look and test it with v0.5.1 to check if I can reproduce it.


hyperx PR broke automatic window resize to fit video

Not sure why this happened, but I bisected and found that that's the root cause.

cc @ngoldman

weird, I'll try to fix

easy fix! PR --> #18


Easy to find Module list

Description
To ease the search for Modules, a Modules list needs to be developed in https://github.com/Azure/Modules/tree/main/arm to have an overview of all current Modules with direct links to their respective folders they're sitting in. It would be also nice to have an overview like this: https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/azure-services-resource-providers

Resolved with attached PR


Detect dcos_acs_token expiry and prompt to refresh credentials before performing intended operation

Currently, if the dcos_acs_token has expired, we are required to perform a dcos config unset dcos_acs_token and re-attempt the original DCOS CLI operation.
Please detect and notify if the token has expired and gracefully recover by prompting for the credentials to make for a better user experience.

@jgehrcke What error are we expected to get if we request with an expired auth token?

The corresponding HTTP status code will be a 401, and there is no indication for the precise reason in the response, for security reasons (it could be an invalid token signature, the token could be expired, and there could be various other subtle reasons -- all of this is purposely normalized into a 401).
The CLI can however inspect the token inspiration time on its own and act on it at will. Token inspection is easy. However, it involves a special flavor of base64-decoding which is provided by e.g. PyJWT (https://pypi.python.org/pypi/PyJWT/1.4.0).
The JWT has three sections, separated by a .. The second section is the payload section, which is a base64-encoded JSON-encoded structure which is required to contain the key exp, which encodes the expiration time as a string, representing the seconds since epoch (UTC). It's better to clarify this via code.
This is commented example code I have tested on Python 2.7 as well as 3.4:

import json
import time

# https://pypi.python.org/pypi/PyJWT/1.4.0
from jwt.utils import base64url_decode
import requests

r = requests.post(
    "https://hostname/acs/api/v1/auth/login",
    json={"uid":"admin", "password":"foobar"}
    )

# Extract auth token from response body.
token = r.json()["token"]

# Obtain token's payload section.
payload_base64 = token.split(".")[1]

# Obtain payload dictionary:
# The payload section comes as a sequence of unicode code points,
# representing a base64-encoded JSON string. Reverse the operation:
# 1. Encode token into binary string via ASCII.
# 2. Decode into another binary string via base64.
# 3. Decode binary string into unicode string, assuming UTF-8 (the
#    default encoding for JSON).
# 4. Treat as JSON, decode into a dictionary.
payload = json.loads(base64url_decode(
    payload_base64.encode('ascii')).decode('utf-8'))

# Get current time and expiration time (UTC), in seconds since epoch.
expiration_time_utc = int(payload["exp"])
current_time_utc = time.time()

seconds_until_expiration = expiration_time_utc - current_time_utc

# Will the token expire within the next 5 minutes?
if seconds_until_expiration < 300:
    print("Will expire soon")
else:
    print("Valid for another %i s" % seconds_until_expiration)

Hope that helps!

This is being handled in #560

The corresponding HTTP status code will be a 401, and there is no indication for the precise reason in the response, for security reasons (it could be an invalid token signature, the token could be expired, and there could be various other subtle reasons -- all of this is purposely normalized into a 401).

The CLI can however inspect the token inspiration time on its own and act on it at will. Token inspection is easy. However, it involves a special flavor of base64-decoding which is provided by e.g. PyJWT (https://pypi.python.org/pypi/PyJWT/1.4.0).

This is not clear to me why are there security concerns in adding this code to the server but not to the CLI?

@jsancio I am not sure if I understand your question. Let me try to elaborate.

This is not clear to me. Why are there security concerns in adding this code to the server

How the server validates the token: a JWT has three sections: header, payload, signature. The server rightfully expects that the token has been signed using a secret that only it (the server) is aware of. The server cryptographically validates an incoming JWT by building a signature from the data-carrying part (header and payload section) and a secret key. It then matches the resulting signature with the signature presented in the token. If they do not match, the token has been tampered with. If they match, the server verifies that the token has not expired (by looking into its header, using about the approach I've shown above). I hope this explains that such code actually is executed server-side.
Now, with the argument of least information exposure, only a fully valid token leads to the request being authenticated. If no authentication token is presented in the request or if there is one but it is invalid in any way, it is responded to with a 401. This is predictable and correct behavior.

but not to the CLI?

In contrast, the client has no way to cryptographically verify that the token has actually been issued by the server. Still, the client can voluntarily trust the information it finds in the token and can act on it. This does not present a security hole.


Generators to SDK 4.22.1

#minor

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.124%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
20332

Relevant Lines:
22880

💛  - Coveralls


Added support for binary_to_term/1 and term_to_binary/1

These changes are made under the terms of the LGPL v2.1 (or any later version)
and Apache 2.0 licenses.

It looks good, but some minor changes are needed.

You'll notice we also don't have support for floats (yet).  I figured we could do that in a separate PR.

Fixes in place.


Error for simple component conversion

Property value expected type of string but got null

TS 3.1.6
VS Code 1.30.2
Extension version 4.2.3
import React, { Component } from 'react';

class App extends Component<{}> {
  render() {
    return (

    );
  }
}

@borislit I also got this error when doing a simple conversion, although for me it was the other way around. It was in a .tsx file, so not sure if Typescript is causing an issue here. Here's some code to try to reproduce the issue, via converting from a stateless to a stateful component (with all code from export default function Test to the end of the file highlighted):
import React from "react"

type Props = {
  foo: string
}

export default function Test({ foo = "bar" }: Props) {
  return
Foo = {foo}

}

My workspace:

VSCode 1.31.1
vscode-glean 4.6.0
MacOS 10.14.3

Hey @ecbrodie ! Ill give it another go later today and keep you posted! Thanks for reporting!

@ecbrodie i found the issue. It has to do with incorrect handling of default prop values. Im working on a fix. meanwhile, if u remove the = "bar" it'll work

@ecbrodie https://github.com/wix/vscode-glean/commit/3cf1c6589359902988566ac2fa8cc74dc6fd3881 should fix the issue. It also adds support for defaultProps. Tell me how it goes. Thanks

@borislit I just checked the latest version of Glean and it now works without error when there are default prop values. Thank you for the quick turnaround.
Also, I checked the example from the OP (@OliverJAsh) and that conversion also works without error. Thus, with default props, I have confirmed that stateful-to-stateless and stateless-to-stateful conversions are working just fine. I think this issue can be closed.

Thanks @ecbrodie ! Glad to help!

I'm still running into this error, using 5.0.1.

I also get the same error when I try "wrap with useMemo":

And "wrap with useEffect" produces a lot of weird code. Input:
import * as React from 'react';

const App = () => {
    Math.random();
    return
;
};

Output:
import * as React from 'react';

const App = () => {
    var __signature__ = typeof reactHotLoaderGlobal !== 'undefined' ? reactHotLoaderGlobal.default.signature : function (a) {
  return a;
};

React.useEffect(() => {
  () => {
    Math.random();
  };
});
    return
;
};

Hey @OliverJAsh ! Thanks for the report. Will have a look ASAP

Also it shows up in non react code everywhere.


[Map view] "Search" field in mobile version is moved to wrong position

Environment: macOS Big Sur 11.5.1; Chrome version 99.0.4844.51.
Reproducible: always.
Build found:
gcp-0.0.116
gcp-0.0.55
Preconditions

Follow link https://oos.dmytrominochkin.cloud/#/**
Select "Київ" location
Click on Search button
Click on Map view

Steps to reproduce

Switch to mobile version via f12 button

Choose dimension as Samsung Galaxy S8+ (360x740)
Take a look to the Search field

Actual result
Search field is moved beyond the map.

Expected result
The search field is adapted to the size of the user's phone.
Steps to reproduce

Rotate to landscape view
Take a look to the Search field

Actual result
Search field and filter buttons are moved on the right side of the map.

Expected result
The search field and filter buttons are adapted to the size of the user's phone.
User story and test case links
US https://github.com/ita-social-projects/OoS-Backend/issues/92
TC https://jira.softserve.academy/browse/OS-349
Labels to be added
"Bug", Priority ("pri: low"), Severity ("severity:minor"), Type ("UI")

fixed


Experiment with embedding Streamtext.net captions in the Theatre

I'm imagining we'd embed an iframe below the Twitch iframe. I'm not sure if this will look good / be acceptable, but it's worth trying!
https://www.streamtext.net/player/transcript?event=IHaveADream is a sample URL you can use for testing.

I did a bit of experimenting and the embedding it in an iframe is very easy - the problem is that as the text continues to grow, it won't auto-scroll to see the new text. I messed around with some CSS hacks but wasn't able to find a way to get it to keep the latest text in view, especially since really it's not text, it's just viewing a webpage.
My hacky brain is going to 'create a function on a timer that forces a scroll to the bottom' but that's awfully messy - any other ideas?

Hmmm, weird! Bangbangcon embedded a StreamText site onto their viewing page, so I'll ask them if they had a trick.
Worst case scenario, I suspect it's fine to either bake open captions directly into the video feed (although this may be tough with StreamYard) and/or only provide a separate link for people to keep captions open I'm a separate tab.

Aha! It looks like there's a configurable scrolling option: https://streamtext.zendesk.com/hc/en-us/articles/210923103-Controlling-the-streaming-text-page-display


ambiguous error in unique validator

What steps will reproduce the problem?
Hi,
I've department and college table with this structure :
$this->createTable('department', [
            'id' => $this->primaryKey(),
            'code' => $this->string()->notNull(),
            'collegeId' => $this->integer()->notNull(),
            'createdAt' => $this->integer(),
            'updatedAt' => $this->integer(),
        ]);

$this->createTable('department_info', [
       'id' => $this->primaryKey(),
       'name' => $this->string(),
       'languageId' => $this->string(),
       'description' => $this->text(),
      'departmentId' => $this->integer()->notNull(),
 ]);

$this->createTable('college', [
            'id' => $this->primaryKey(),
            'code' => $this->string()->notNull(),
            'createdAt' => $this->integer(),
            'updatedAt' => $this->integer(),
        ]);

$this->createTable('college_info', [
            'id' => $this->primaryKey(),
            'name' => $this->string(),
            'languageId' => $this->string(),
            'description' => $this->text(),
            'collegeId' => $this->integer()->notNull(),
            'websiteId' => $this->integer(),
            'url' => $this->text(),
]);

in rules of Department model code attribute is unique :
 public function rules()
    {
        return [
            [['code', 'collegeId'], 'required'],
            [['code'], 'unique'],
            [['code'], 'integer'],
        ];
    }

then this model use uniqueValidator.
In special condition in Department::find() method i'm trying to join that tables :
public static function find()
    {
        $query = new ActiveQuery(get_called_class());
        if(Yii::$app->user->isSuperuser()){
            return $query;
        }
        $query->joinWith('college');
        return $query;
    }

while update one record of department this error was occured :
SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'id' in field list is ambiguous
The SQL being executed was:
 SELECT `id` FROM `department` LEFT JOIN `college` ON `department`.`collegeId` = `college`.`id` WHERE (`code`='1') LIMIT 2

3 month ago i wrote #13704 issue and some changes in master branch was occured but seems uniqueValidator already has some problems.
in UniqueValidator::modelExists($targetClass, $conditions, $model)
in this part :
if ($query instanceof \yii\db\ActiveQuery) {
                // only select primary key to optimize query
                $query->select($targetClass::primaryKey());
    }

when die($query->createCommand()->getSql()) return this :
'SELECT idFROMdepartmentLEFT JOINcollegeONdepartment.collegeId=college.id WHERE (code=:qp0)'
but while commented  $query->select($targetClass::primaryKey()); line return this:
SELECT `department`.* FROM `department` LEFT JOIN `college` ON `department`.`collegeId` = `college`.`id` WHERE (`code`=:qp0)

and i need this.
it seems with commented that line problem will solved.
other solution is adding tableName as prefix to id column.

Duplicate of #13842

this issue is different from #13842 : |
please pay attention this.
thanks.

right, it is different. Thanks for pointing that out.

@sepidemahmoodi have you tried it with code from master branch?

have changes been merged to master?

yes, if you check out current master it should work. Please check and report back if your problem is solved.


Add support for UWP5661 SoC and IVY5661 board

Hello,
This is the second attempt on adding UNISOC UWP5661 SoC and 96Boards IVY5661 board support to zephyr. The first attempt was made by UNISOC (#10626) but the PR was closed and discontinued. Now, UNISOC has no intention to do the upstream by themselves but they are open for community contributions. Hence with their approval, I'm posting this PR and taken over the codebase from their previous PR. I've added my copyright for files I modified/created.
About SoC:
Unisoc UWP5661 is a highly integrated connectivity single chip which offers the lowest BOM in the industry for smart phone, PC, STB, OTT, IoT and automotive applications. This chip includes 2.4GHz and 5GHz WLAN IEEE 802.11 a/b/g/n/ac, Bluetooth 5.0 with supporting high power mode, Direction Finding and Long Range.
About Board:
96Boards IVY5661 is one of the IoT boards of the 96Boards family manufactured by UCRobotics. This board features UWP5661 SoC in 96Boards IoT form factor. More information about this board can be found in 96Boards website: https://www.96boards.org/product/ivy5661
The corresponding PR to add HAL is here: https://github.com/zephyrproject-rtos/hal_unisoc/pull/1

I haven't looked closely at the port, but in preparation for doing so I have a couple questions:

The sole source for this processor appears to be 96Boards via Seeed, where it's out of stock.  Is there reason to believe it will be possible for people to get their hands on this hardware?
#10626 does not include a reason for its being closed, but one blocker was absence of public documentation on the hardware.  I don't see detailed information on the product page.  Is hardware reference documentation going to become available?

Having recently spent time dealing with in-tree drivers for sensors that are so past end-of-life that the vendor doesn't even provide documentation for them anymore, I'm concerned about spending effort moving something into Zephyr---and taking on the upstream responsibility for basic maintenance---if no member companies have the hardware and are willing to devote resources to supporting it.
I personally would not want to approve a new platform without being able to verify for myself that it passes basic tests, but if the concerns above are mistaken and I can get hardware I'm happy to take a more in-depth look.

I haven't looked closely at the port, but in preparation for doing so I have a couple questions:

The sole source for this processor appears to be 96Boards via Seeed, where it's out of stock.

I believe that this board is also available on Toabao. I'm not sure if it will be available on Seed studio, but I can check with board vendor.

Is there reason to believe it will be possible for people to get their hands on this hardware?

Please see below comment.

#10626 does not include a reason for its being closed, but one blocker was absence of public documentation on the hardware.  I don't see detailed information on the product page.  Is hardware reference documentation going to become available?

Yes, Unisoc is working on public documentation for this SoC and it will be available soon. The reason for closing #10626 is that Unisoc has no interest in doing the upstreaming by themselves. But they are happy if someone from the community does it.

Having recently spent time dealing with in-tree drivers for sensors that are so past end-of-life that the vendor doesn't even provide documentation for them anymore, I'm concerned about spending effort moving something into Zephyr---and taking on the upstream responsibility for basic maintenance---if no member companies have the hardware and are willing to devote resources to supporting it.

This statement doesn't make sense to me. Is Zephyr going to host only the SoC/boards of the member companies? If that's the case, it needs to be written somewhere so that people don't spend time on upstreaming the non-member platforms. And where does the community contribution comes here? This is purely a community contribution and even if the board is not going to be available in future, we should support the existing users. This is what Linux kernel is doing. The developer who submits the SoC/board/driver support takes the sole responsibility of testing regularly with releases and making sure that there is no regression present. Or even if someone reports some regression, then the developer is responsible for fixing it. If he fails to do so for a long time, then the platform can be considered stale and can be removed with notice. And for basic upstreaming maintenance, we only care about build check, didn't we?

I personally would not want to approve a new platform without being able to verify for myself that it passes basic tests, but if the concerns above are mistaken and I can get hardware I'm happy to take a more in-depth look.

Again, this is not going to work well. Is it a requirement now that the platform support has to be verified by you in order to be upstreamed?

I'm just a contributor, so please don't take anything I say as being anything more than my opinion.

This statement doesn't make sense to me. Is Zephyr going to host only the SoC/boards of the member companies?

I didn't intend to imply that.  I'm unaware of any clearly defined Zephyr policy and process for determining whether a new platform /device is acceptable or when an old platform/device can be removed.

And for basic upstreaming maintenance, we only care about build check, didn't we?

In practice as Zephyr evolves keeping something building means maintainers making source code changes to code in other areas when API or tooling changes, which is risky when the changes can't be verified because nobody has the hardware.  I've been spending a lot of time recently doing this for sensors that use GPIO, so I'm possibly a little too sensitive to the costs and risks of untested code.

I personally would not want to approve a new platform without being able to verify for myself that it passes basic tests, but if the concerns above are mistaken and I can get hardware I'm happy to take a more in-depth look.

Again, this is not going to work well. Is it a requirement now that the platform support has to be verified by you in order to be upstreamed?

Somebody has to approve it; it certainly doesn't have to be me.
I was asked to give my review, and I believe that involves more than a cursory "looks like it might work", which is all I could say without hardware and documentation to evaluate it.
I have no problem with buying an interesting and inexpensive board like this in order to support Zephyr's capabilities, so I wanted to know whether it was going to be available so I could give this contribution the careful attention it deserves.

@galak ping!

Needs rebase @Mani-Sadhasivam

@ioannisg Rebased on top of master!

@galak @ioannisg ping!

@Mani-Sadhasivam there seems to be an issue with Kconfig. I will check shippable once it’s done to merge the the unisoc hal PR

@Mani-Sadhasivam there seems to be an issue with Kconfig. I will check shippable once it’s done to merge the the unisoc hal PR

@carlescufi Let me fix the Kconfig issue as well.

@carlescufi @galak Is there any plan to merge this PR? I just kept on rebasing this for close to 8 months and if we decide not to merge this, I'll just close this.
Thanks
PS: There is a CI failure that I'll address if I hear anything about merging.

Yes, I don't see why not. I have now merged https://github.com/zephyrproject-rtos/hal_unisoc/pull/3, please update the revision to 4fdb87c6861a88f2ddf6c9609f7bf7278ddc22e1.
@ioannisg @galak any objections to moving forward with this PR?

@Mani-Sadhasivam could you please send an email to the devel@ mailing list asking for reviewers for this PR?


Support overlapping constant-named resources

Addresses https://github.com/Azure/autorest.azureresourceschema/issues/45 and https://github.com/Azure/autorest.azureresourceschema/issues/43


Workflows to build docker images for bitcoin

In this PR we define a GH Actions workflow to validate the build of bitcoin images we use for the local environment.
Depends on https://github.com/keep-network/local-setup/pull/88

This is brilliant! So now if someone makes a change to one of the docker files, we'll pick up that the build breaks and be able to fail the PR. 😍

I purposefully messed up the docker file in https://github.com/keep-network/local-setup/pull/93 but it appears to be working regardless. I think this is probably cache related. Can you take a look?

Alrighty - the test in the #93 is properly failing, so we're good to go!


Schema utilities to mirror TypeScript's utility types

What version of Ajv you are you using?
8.11
What problem do you want to solve?
I'm using Ajv as a runtime companion for TypeScript / to generate type guards for my types.
TypeScript has a series of utility types which make it easy to perform certain modifications to existing types without having to re-define the base type.  For example I might Omit an id attribute in the context of a create method.
Currently I need to re-define the entire corresponding Ajv schema in these instances if I want a type guard for the new "utilitied" type.  This is an issue because it violates DRY in ways that TypeScript has prevented -- if I were to modify the base type / schema I now need to remember to update the contextual schema manually.
It would be wonderful to have a mirrored set of utility functions within the ajv ecosystem which would take a schema and return a modified schema.  For example:
interface Foo {
  id: number;
  bar: string;
}

const fooSchema: JSONSchemaType<Foo> = {
  type: 'object',
  properties: {
    id: { type: 'integer' },
    bar: { type: 'string' },
  },
  required: [ 'id', 'bar' ],
};

// This next schema might be used in the context of a POST /foo endpoint
const modifiedFooSchema: JSONSchemaType<Omit <Foo, 'id'>> = ajv.utilities.omit(
  fooSchema,
  [ 'id' ]
);

What do you think is the correct solution to problem?
I imagine this would NOT make sense to be built into core ajv, but maybe this would be appropriate as an ajv plugin.
Will you be able to implement it?
If this fits into the vision of the Ajv team and I have some high level guidance about the best way to implement it (e.g. "this should be a plugin!"), I could create an implementation.

The problem with this approach is it obscures the fact that the validation logic deals with the immutable serializable concrete structures, not a subset of abstract javascript/typescript types. Basically for every new schema object a completely new validation function has to be compiled. This process becomes more expensive with more functions and the size of the schema, requiring an async logic for this whole process past certain threshold.
So you have two ways about it:

Create a separate schema for each permutation you need and compile validation function for it. Yes it is annoying, but this is how json schema works and you shouldn't obscure this fact in the repo code. $defs keyword might help structuring the ever increasing amount of schema files, but can hurt readability if not used properly.
Create an abstract class which implements the interface for the resulting schema and add methods which transform into needed permutations. This way typescript will error on any type mismatch or missing implementations on a concrete class.

In general avoid creating schemas for the structures which aren't going to be serialized. It is tempting to do because the simple JSON schemas map neatly into simple typescript interfaces, but the more complex logic on either of those gets increasingly hard to maintain and down the line makes validation logic incomprehensible.


UnoCSS Preset (port)

Super beautiful library. Thank you. An UnoCSS preset would be awesome to see too

Hey Nick, thanks for the suggestion here! It's probably not a big priority for us now, neither @KevinGrajeda nor I have really built with UnoCSS before so we're probably not in the best place to build it.
But we'll keep it on our radar as Uno grows 🚀

Totally. I might take a poke at it and let you know

Do it! 🚀 drop us a line for any guidance :)On 8 Oct 2024, at 18:33, Nicholas Cerminara @.***> wrote:
Totally. I might take a poke at it and let you know
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

So I ended up finishing this with full support.
Just want to say seriously beautiful library after the deep dive. Super clever/creative use of the variables.
I'll make a cool page and drop the link next week here.

Boom! https://github.com/whatnickcodes/unocss-preset-tailwindcss-motion
I'm not sure if there's spot for this anywhere for reference. I'll bug the UnoCSS community preset folks about adding it to their site too


Fuzzy search

As a user, I can easily search within the system even if I mistype a few words, so that I can more easily locate relevant information.

Bumped to priority.High as only allowing keyword search may count as a FeatureFlaw.


Error while creating a service fabric cluster using bash

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az sf cluster create
Errors:
'NoneType' object has no attribute 'get'
Traceback (most recent call last):
python3.6/site-packages/knack/cli.py, ln 206, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 608, in execute
    raise ex
cli/core/commands/__init__.py, ln 666, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
...
cli/command_modules/servicefabric/custom.py, ln 1158, in _create_certificate
    cmd, cli_ctx, vault_resource_group_name, vault_name, location, enabled_for_deployment=True).result()
cli/command_modules/servicefabric/custom.py, ln 1667, in _create_keyvault
    permissions = Permissions(keys=[KeyPermissions.get,
AttributeError: 'NoneType' object has no attribute 'get'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az sf cluster create --resource-group {} --location {} --certificate-output-folder {} --certificate-password {} --certificate-subject-name {} --cluster-name {} --cluster-size {} --os {} --vault-name {} --vault-resource-group {} --vm-password {} --vm-user-name {}

Expected Behavior
Environment Summary
Linux-4.15.0-1075-azure-x86_64-with-debian-stretch-sid
Python 3.6.5

azure-cli 2.2.0 *

Additional Context

sf

Hi ,
Didnt understand your comment?
First I stored the value in the variables and then i passed using the following commands
az group create --name $ResourceGroupName --location $Location
az sf cluster create --resource-group $ResourceGroupName --location $Location --certificate-output-folder . --certificate-password $Password --certificate-subject-name $Subject  --cluster-name $ClusterName --cluster-size 3 --os UbuntuServer1604 --vault-name $VaultName  --vault-resource-group $ResourceGroupName --vm-password $VmPassword --vm-user-name $VmUserName
I am getting the error below
'NoneType' object has no attribute 'get'
Traceback (most recent call last):
python3.6/site-packages/knack/cli.py, ln 206, in invoke
cmd_result = self.invocation.execute(args)
cli/core/commands/init.py, ln 608, in execute
raise ex
cli/core/commands/init.py, ln 666, in _run_jobs_serially
results.append(self._run_job(expanded_arg, cmd_copy))
...
cli/command_modules/servicefabric/custom.py, ln 1158, in _create_certificate
cmd, cli_ctx, vault_resource_group_name, vault_name, location, enabled_for_deployment=True).result()
cli/command_modules/servicefabric/custom.py, ln 1667, in _create_keyvault
permissions = Permissions(keys=[KeyPermissions.get,
AttributeError: 'NoneType' object has no attribute 'get'

Service Fabric service team should take a look at above.

@Tijinm Apologies for the late reply. Could you please use the most recent version of Python libraries and Azure CLI and test the behavior again ? Also this github thread has been inactive for quite sometime. Could you please let us know if you still need assistance on this? Awaiting your reply.

@Tijinm Please let us know if you are still facing this issue. If no further assistance is required on this, can we proceed with closure of this issue? Awaiting your reply.

@Tijinm We will now proceed with closure of this github issue. If you need any further assistance on this issue in future, please feel free to reopen this thread. We would be happy to help.