Localization cooldown/remaining string in alerts

About the PR

Localization cooldown/remaining string in alerts
Resolves #31362
Why / Balance

Technical details

Media

Requirements

[x] I have read and am following the Pull Request and Changelog Guidelines.
[x] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl: to4no_fix

Where exactly is that string even used in-game?

Where exactly is that string even used in-game?

for example in alert after drinking glue, it gives you mute


spa found but wont connect

fairly new to home assistant but have installed HACS and the bestway script and found my hottub but after logging in I cant control anything what am I doing wrong
![Screenshot ha issue](https://github.com/cdpuk/ha-bestway/assets/171022724/d3ee9c32-33ae-4d34-b323-30b20a1e9f18)
![Screenshot ha issue](https://github.com/cdpuk/ha-bestway/assets/171022724/38c56534-f619-468d-9871-5b08badcaead)

This sounds a lot like #57, but sadly no further information was received on that issue.
Can you grab some debug logs from the integration to help work out what's happening? This looks like it thinks the device is offline.

I should also add that newly published v1.5.1 adds an additional log entry that will be useful for this issue.

I had the same issue. Deleting and readding the spa via the bestway app fixed it for me.

I am also having the same issue, getting the following errors in the logs:
Error fetching Bestway API data: Error communicating with API: 502, message='Bad Gateway', url=URL('https://euapi.gizwits.com/app/bindings')
Error fetching Bestway API data: Error communicating with API:
Error fetching Bestway API data: Error communicating with API: 500, message='INTERNAL SERVER ERROR', url=URL('https://euapi.gizwits.com/app/devdata/xxxxxxxxxxxxxxxxxxxxxx/latest')
Error fetching Bestway API data: Error communicating with API: Cannot connect to host euapi.gizwits.com:443 ssl:default [Connect call failed ('<IP_ADDRESS>', 443)]
Error fetching Bestway API data: Error communicating with API: 502, message='Bad Gateway', url=URL('https://euapi.gizwits.com/app/devdata/xxxxxxxxxxxxxxxxxxxxxx/latest')

Closing due to inactivity. The 5xx errors are probably unrelated - there seemed to be a patch of these errors from the Bestway servers a few weeks ago.


Update link

Use Notification Hubs to push notifications to users link needs to be updated. New destination should be https://docs.microsoft.com/en-us/azure/notification-hubs/notification-hubs-aspnet-backend-windows-dotnet-wns-notification

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2a03ab5f-3dda-f469-33e0-9504c90d468c
Version Independent ID: 4f8e4309-cd06-f09f-00f0-d978b3d16777
Content: Get started with Notification Hubs for Xamarin.Android apps
Content Source: articles/notification-hubs/xamarin-notification-hubs-push-notifications-android-gcm.md
Service: notification-hubs
GitHub Login: @jwhiteDev
Microsoft Alias: jawh

Please assign to @dimazaid

@martore Thanks for reporting! We will get this updated ASAP.

WindowsAzure.Messaging  package in nuget is out update, last update in 2013????
So, this code above not found to install in pcl project, problem in android api 8.1

This link is still out of date a month later, would be good to update it


Update Rotate3DTransition.cs to fix flickering on backwards navigation

What does the pull request do?
Before I've already fixed flickering on the new rotate 3d transition, now I've recognised that is missed fixing it for navigating backwards.
What is the current behavior?
Rotating "backwards" does still flicker.
What is the updated/expected behavior with this PR?
Rotating backwards will no longer flicker.

You can test this PR using the following package version. 11.0.999-cibuild0038844-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]


Improvement of image plugin. Transport is selected automatically for compressed images

Hi,
as a newbie a spent quite a lot of time understanding how to use correctly the image plugin when my image is compressed.
In my case for, instance,I have a /zed/right/image_raw/compressed.
I have to first select transport "compressed" in the combo box and then type manually /zed/right/image_raw because the topic selector doesn't work.
With this PR the topics of types sensor_msgs/CompressedImage is visible in the topic selector.
If one of those topics is selected, the suffic of the topic name is used to automatically select the proper combo box ("compressed", "theora", "compressedDepth").
Cheers

By the way, I also found some minor issues when the visibility of the config_item change and the image is compression (resubscription didn't work).

Hi,
I see your point, especially for theora_image_transport, but I still believe that there must be a better way to simplify usage.
For sure the PR I am proposing need improvements.
Nevertheless, is disagree with this sentence:

f you have a publisher that is only publishing a CompressedImage and not using the image_transport mechanism, I think it would be preferable to fix that so that it also publishes the raw topic

I might have my reasons to avoid that (WIFI connection).
Apparently, ImagePlugin can use the local_node_ to deal with this automatically and locally.
https://github.com/swri-robotics/mapviz/blob/kinetic-devel/mapviz_plugins/src/image_plugin.cpp#L263
What bother me most is that the Topic Selector is useless in these cases, because it will remain empty.
I will keep thinking about it...

I will close this for the time being...


Importing CTF data on machine with different locale.

I'm trying to import a CTF data set that has been recorded with locale en_US on my local machine which has de_DE. This fails because a date string can't be parsed:
>>> locale.setlocale(locale.LC_ALL, 'de_DE')
>>> mne.io.read_raw_ctf('20151208_01.ds')
ds directory : /Volumes/dump/conf_meg/raw/s01-01_Confidence_20151208_01.ds
    res4 data read.
    hc data read.
    Separate EEG position data file read.
    Quaternion matching (desired vs. transformed):
       2.12   82.38    0.00 mm <->    2.12   82.38    0.00 mm (orig :  -49.12   66.08 -256.99 mm) diff =    0.000 mm
      -2.12  -82.38    0.00 mm <->   -2.12  -82.38    0.00 mm (orig :   52.98  -63.28 -255.14 mm) diff =    0.000 mm
      98.83    0.00    0.00 mm <->   98.83   -0.00   -0.00 mm (orig :   77.27   64.28 -244.34 mm) diff =    0.000 mm
    Coordinate transformations established.

---------------------------------------------------------------------------
UnboundLocalError                         Traceback (most recent call last)
<ipython-input-6-e495908c73ec> in <module>()
      1 locale.setlocale(locale.LC_ALL, 'de_DE')
----> 2 mne.io.read_raw_ctf('20151208_01.ds')

/Users/nwilming/src/mne/mne/io/ctf/ctf.pyc in read_raw_ctf(directory, system_clock, preload, verbose)
     60     .. versionadded:: 0.11
     61     """
---> 62     return RawCTF(directory, system_clock, preload=preload, verbose=verbose)
     63
     64

/Users/nwilming/src/mne/mne/io/ctf/ctf.pyc in __init__(self, directory, system_clock, preload, verbose)

/Users/nwilming/src/mne/mne/utils.pyc in verbose(function, *args, **kwargs)
    549         with use_log_level(verbose_level):
    550             return function(*args, **kwargs)
--> 551     return function(*args, **kwargs)
    552
    553

/Users/nwilming/src/mne/mne/io/ctf/ctf.pyc in __init__(self, directory, system_clock, preload, verbose)
    109         coord_trans = _make_ctf_coord_trans_set(res4, coils)
    110         # Compose a structure which makes fiff writing a piece of cake
--> 111         info = _compose_meas_info(res4, coils, coord_trans, eeg)
    112         # Determine how our data is distributed across files
    113         fnames = list()

/Users/nwilming/src/mne/mne/io/ctf/info.pyc in _compose_meas_info(res4, coils, trans, eeg)
    370     info['meas_id']['usecs'] = 0
    371     info['meas_id']['secs'] = _convert_time(res4['data_date'],
--> 372                                             res4['data_time'])
    373     info['experimenter'] = res4['nf_operator']
    374     info['subject_info'] = dict(his_id=res4['nf_subject_id'])

/Users/nwilming/src/mne/mne/io/ctf/info.pyc in _convert_time(date_str, time_str)
     69             break
     70     else:
---> 71         raise RuntimeError("Illegal date: %s" % date)
     72     for fmt in ('%H:%M:%S', '%H:%M'):
     73         try:

UnboundLocalError: local variable 'date' referenced before assignment

Setting the locale to en_US (locale.setlocale(locale.LC_ALL, 'de_DE')) fixes this.
Maybe _convert_time in mne.io.ctf.info could spit out an appropriate error message that points out that the locale needs to be set correctly? I assume that the locale of the data will usually be en_US, so a helpful error message could be:
"Illegal date %s.  If the language of the data does not correspond to your local machine's language try to set the locale to the language of the date string: locale.setlocale(locale.LC_ALL, 'en_US')"
I also think that the line 71 in info.py should be: raise RuntimeError("Illegal date: %s" % date_str) and not reference the variable date as it does not exist yet.
I'm running mne version 0.12.dev0.

+1 and PR welcome

PR welcome or share a file so we can replicate.


getResetPageDeps not working

Hello, I am trying to create editing table, but getResetPageDeps set to false seems not to be working for me, please check https://codesandbox.io/s/sharp-paper-iljn7-iljn7
Go to page 2, click edit button, change any data and click outside of input > page goes back to 1.
btw I know i should not set getResetPageDeps: false directly, but use some kind of state instead - but this is just for a simplification here.
thanks Ales

Closing, found myself I am reini table function on every component render...

This discussion happening right now is relevant to this issue: https://github.com/tannerlinsley/react-table/issues/1729


Turn off sync of generated RSS files to AWS S3

Once IA confirms they're pulling generated RSS files from B2, and all indexer usage changed, disable sync to S3

IA has confirmed that they've successfully pulled today's data from B2- so I think this is ready

Depends on https://github.com/mediacloud/story-indexer/issues/326

Done.


Allow protojson to decode legacy maps into messages with shortcut map notation

Is your feature request related to a problem? Please describe.
We're dealing with a service architecture that describes maps in different ways in different service (for legacy reasons). Some old services emit messages with the "legacy" structure for encoding maps inside of protobuf messages. Other services use modern protobuf definitions with the "shortcut" notation for maps (see: https://developers.google.com/protocol-buffers/docs/proto3#maps).
As mentioned in the documentation the map<T,T> notation is sugar for what is in effect a list of entry messages as it is encoded on the wire. This is good, and works for us so we don't have to care about which service uses what notation. But this breaks when sent it in the canonical json format.
To explain this further, let's consider the following proto file (in reality, for our use case this would be in two different files but the explanation stays the same)
syntax = "proto3";
package examples.v1;

// ShortcutMap message use the map shortcut for our map field
message ShortcutMap {
    map<string, string> map_field = 1;
}

// LegacyMap uses the legacy setup to describe a map
message LegacyMap {
    // We repeat entries to make a map
    message MapFieldEntry {
        string key = 1;
        string value = 2;
    }
    repeated MapFieldEntry map_field = 1;
}

Now let's consider the scenarios that one service is sending the legacy LegacyMap message to a service
that is only aware of the new ShortcutMap definition. Both in JSON and in the proto wire format:
package main

import (
	"fmt"

	examplesv1 "github.com/crewlinker/some-internal-protobuf-go-dir/v1"
	"google.golang.org/protobuf/encoding/protojson"
	"google.golang.org/protobuf/proto"
)

func main() {

	// send messages from our legacy code
	send1 := &examplesv1.LegacyMap{MapField: []*examplesv1.LegacyMap_MapFieldEntry{{Key: "foo", Value: "bar"}}}
	json1, _ := protojson.Marshal(send1)
	fmt.Printf("legacy json: %s\n", json1)
	proto1, _ := proto.Marshal(send1)
	fmt.Printf("legacy wire: %x\n", proto1)

	// receive messages in our new code
	var rcv1, rcv2 examplesv1.ShortcutMap
	proto.Unmarshal(proto1, &rcv1)
	fmt.Println("receive 1:", rcv1.MapField) // prints the map as expected
	protojson.Unmarshal(json1, &rcv2) // proto: syntax error (line 1:13): unexpected token [
	fmt.Println("receive 2:", rcv2.MapField) // prints an empty map (because it couldn't parse)
}

The inconsistency is that the legacy notation for maps can be decoded transparently into a message with
the shortcut notation for the protowire format. But not when the json format is used.
Describe the solution you'd like
I would like it to be possible that the protojson unmarshal logic allows for decoding maps from the legacy format
into a message with the shortcut notation. For my use case it would be ok if this is an option in the https://pkg.go.dev/google.golang.org/protobuf/encoding/protojson#UnmarshalOptions struct but I do believe it
can also be implemented transparently (without breaking any backwards compatibility)
Describe alternatives you've considered
Some alternatives:

Modify the  json message before it hits protojson.Unmarshal, but this requires parsing the whole message once, in a lossy format, then encoding it again into the json format that protojson accepts for our map. This is very ugly, and has big performance implications.
Implement a custom unmarshal method for protojson to just handle the map type (like https://pkg.go.dev/encoding/json#Unmarshaler). But this is impossible for protojson as far as I'm aware
Other options seems to require us mandating that the whole code base follows either one or the other way to define maps. This requires a big development undertaking
Disallow protojson encoding for messages that have a map, this defeats the purpose of protojson being a reliable message format.

Additional context
To hopefully give this improvement a bit more weight I just want to emphasise:

That the official docs https://developers.google.com/protocol-buffers/docs/proto#maps mentions a lot that the map<T,T> notation is sugar for what is actually happening on the wire. The json representation doesn't follow that same rigor
It is pretty common for protojson to parse certain types in multiple ways (https://developers.google.com/protocol-buffers/docs/proto3#json), e.g floats can be send as 1.1 or "1.1". It seems OK if for maps it says that it would accept both {"foo": "bar"} as well as [{"key":"foo","value":"bar"}]
I would be able to contribute this improvement, if accepted

This seems to be a request relevant to the protobuf standard itself. This module has been bitten before by going beyond the standards as they are defined, and thus is shy to implement something unilaterally that is not already standardized.
Namely: even if we make this change, will C++/Java/python support the same features? Having the Go implementation alone able to parse [{"key":"foo","value":"bar"}] into a map<string, string> means that the Go implementation will be unexpectedly different from other implementations.

Right, that makes sense. But it do  think it is fair (and valuable) to raise this with the standard itself. What would be the right place to create an issue for that?

As @puellanivis mentioned, the Go implementation will only adopt this if the wider protobuf project deems this as standard behavior.
The issue tracker for the wider protobuf project is https://github.com/protocolbuffers/protobuf/issues.

@dsnet I understand. I've opened the following issue over here: https://github.com/protocolbuffers/protobuf/issues/11505


conformance to RemovableChannelHandler

Expected behavior
Commonly used types conform to RemovableChannelHandler.
Actual behavior
Need to add conformance myself.
extension HTTPResponseDecoder: RemovableChannelHandler { }
extension HTTPRequestEncoder: RemovableChannelHandler { }
extension HTTPResponseCompressor: RemovableChannelHandler { }

SwiftNIO version/commit hash
master @<PHONE_NUMBER>12113a4e1e5bc6c11b576791f7cebc
Swift & OS version (output of swift --version && uname -a)
Apple Swift version 5.0 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin18.2.0
ABI version: 0.7
Darwin iMac.home 18.2.0 Darwin Kernel Version 18.2.0: Mon Nov 12 20:24:46 PST 2018; root:xnu-4903.231.4~2/RELEASE_X86_64 x86_64

oops, sorry I missed this. This definitely needs fixing

done in #814

and https://github.com/apple/swift-nio-extras/pull/33


Access Request headers set by library before or after sending request

I'm writing a library that uses Reqwest and serializes the Request and Response structs to WARC files.
It works great for the Responses, but with Requests it only shows me the headers I've set myself, because I'm using the Request struct before it is passed into the library.
Thus, it doesn't show any library-set headers like User-Agent, I'd guess Accept when the user doesn't set it, and Content-Length (see #1030).
It would be great if we could get access to the Request object as it looks after any library modifications. For my situation, I'm fine getting the Request headers before or after sending request, but I can imagine some folks who would access to it before sending.
I'm not sure if Hyper also sets default headers, in which case this would be more complicated.
Let me know what you think!

I ran into the same issue for essentially the same use case, trying to instrument reqwest calls into HAR files to make my code easier to debug/troubleshoot. It would be nice if Request::headers() could return a more accurate representation of the actual headers that will be sent in the request, including the user agent.

I've run into this same problem, I need to log request headers for debugging purposes and I'm only able to see the headers I set manually with a RequestBuilder. The headers added by the Client are opaque to my application: is there any way to access them?

This appears to be a duplicate of https://github.com/seanmonstar/reqwest/issues/788


User-defined Set simplification rule not applied

On K master commit (72d33ae0e0), the following very simple spec does not work. This affects some KEVM proofs which are being ported.
requires "domains.md"

module TEST
    imports INT
    imports SET

    configuration <k> $PGM:Step </k>

    syntax Step ::= run ( Set ) | done ( Set )

    rule <k> run(S) => done(S) ... </k>

    syntax Bool ::= pred ( Int ) [function, no-evaluators]

    rule .Set -Set _ => .Set [simplification]
    rule (SetItem(X) REST) -Set SetItem(Y) => SetItem(X) (REST -Set SetItem(Y)) requires pred(X) andBool notBool pred(Y) [simplification]

    rule pred(X) => false requires 1 <=Int X andBool X <=Int 9 [simplification]
endmodule

module TEST-SPEC
    imports TEST

    claim <k> run(SetItem(1) -Set SetItem(X)) => done(SetItem(1)) ... </k> requires pred(X)

endmodule

To reproduce the failure:
kompile --backend haskell test.k --main-module TEST --syntax-module TEST
kprove test.k --def-module TEST --spec-module TEST-SPEC

I modified introduced names for all rules in the example:
requires "domains.md"

module TEST
    imports INT
    imports SET

    configuration <k> $PGM:Step </k>

    syntax Step ::= run ( Set ) | done ( Set )

    rule [step]: <k> run(S) => done(S) ... </k>

    syntax Bool ::= pred ( Int ) [function, no-evaluators]

    rule [set.diff.empty]: .Set -Set _ => .Set [simplification]
    rule [set.diff.concat]: (SetItem(X) REST) -Set SetItem(Y) => SetItem(X) (REST -Set SetItem(Y)) requires pred(X) andBool notBool pred(Y) [simplification]

    rule [pred.false]: pred(X) => false requires 1 <=Int X andBool X <=Int 9 [simplification]
endmodule

module TEST-SPEC
    imports TEST

    claim <k> run(SetItem(1) -Set SetItem(X)) => done(SetItem(1)) ... </k> requires pred(X)

endmodule

To see which equations are applied by kore-exec, I set the KORE_EXEC_OPTS environmental variable:
export KORE_EXEC_OPTS="--log ${LOG_FILE} --debug-equation TEST.step --debug-equation TEST.set.diff.empty --debug-equation TEST.set.diff.concat --debug-equation TEST.pred.false

After running kprove, the first entry in the log file reports an attempt to apply rule pred.false (line 18):
    (DebugAttemptEquation) while applying equation at /home/geo2a/Workspace/RV/kore/georgy/test.k:18:24-18:77:
    equation is not applicable:
    could not infer the equation requirement:
        /* Spa */
        \equals{SortBool{}, _PREDICATE{}}(
            /* Fl Fn D Spa */
            Lbl'Unds'andBool'Unds'{}(
                /* Fl Fn D Spa */
                Lbl'Unds-LT-Eqls'Int'Unds'{}(
                    /* Fl Fn D Sfa Cl */ \dv{SortInt{}}("1"),
                    /* Fl Fn D Sfa */ RuleVarX:SortInt{}
                ),
                /* Fl Fn D Spa */
                Lbl'Unds-LT-Eqls'Int'Unds'{}(
                    /* Fl Fn D Sfa */ RuleVarX:SortInt{},
                    /* Fl Fn D Sfa Cl */ \dv{SortInt{}}("9")
                )
            ),
            /* Fl Fn D Sfa Cl */ \dv{SortBool{}}("true")
        )
    and the matching requirement:
        /* D Sfa */ \top{_PREDICATE{}}()
    from the side condition:
        Assumed true condition:
            /* D Sfa */ \top{_PREDICATE{}}()
        Term replacements:
        Assumed to be defined:

I looks like the kore-exec is saying that it can't infer the requirement  1 <=Int X andBool X <=Int 9 from #Top? I tried both kore-exec-v0.48 and kore-exec-v0.47 --- both return the same result.
Interestingly, kore-exec only logs attempts of applying this equation, i.e. there is no log entries for the other ones I asked to debug. I tried giving only one --debug-equation option, but it did not help.

This problem is most likely related to simplification rules that operate over sort Set. Here is a working example that is similar in structure, but does not use Set:
requires "domains.md"

module TEST
    imports INT

    configuration <k> $PGM:Step </k>

    syntax Step ::= run ( Int ) | done ( Int )
    rule [step]: <k> run(S) => done(S) ... </k>

    syntax Bool ::= pred ( Int ) [function, no-evaluators]
    syntax Int ::= f (Int, Int) [function, no-evaluators]

    rule [pred.false]: pred(X) => false requires 1 <=Int X andBool X <=Int 9 [simplification]
    rule [f.rule]: f(X, Y) => 4 requires pred(X) andBool notBool pred(Y) [simplification]
endmodule

module TEST-SPEC
    imports TEST

    claim <k> run(f(X, 7)) => done(4) ... </k> requires pred(X)
endmodule

@ehildenb Do you know when this issue started appearing? I think I know what's going on, but I'm confused about why this is recent (or maybe it isn't?).

It never worked as far as I know.

Experiment: remove https://github.com/kframework/kore/blob/25c91ec03dcac3e8ded17cdad505f2e2554038c5/kore/src/Kore/Builtin/Set.hs#L369 and give this test another try.

I forgot to add during our debugging meeting, @geo2a , but I think this issue actually describes two separate issues:

Find a way to make user-defined Set simplification rules get attempted, here we should focus on removing the symbolic case from the backend and see what support we need from the frontend
Figure out why the concat rule doesn't apply when it's marked [simplification]; you noticed that it has something to do with matching, and we need to debug it further

We've found multiple issues with our AC matching algorithm (see https://github.com/kframework/kore/pull/2737). More discussion on how to proceed is needed.

Blocked on #2739

Small update: After making some progress with set simplification, the given example still does not simplify to the desired output.
One problem preventing this is the program itself, though:
pred(X) => false requires 1 <Int X andBool X <=Int 9 actually applies to X == 1, therefore SetItem(1) -Set SetItem(X cannot be simplified with the rule SetItem(A) REST) -Set SetItem(B) => SetItem(A) requires pred(A) andBool notBool pred(B).
Also, the claim has requires pred(X) but probably the intention was requires notBool pred(X).
With a modified requires in the claim, as previously found, the prover is unable to establish pred(1) and therefore does not apply the simplification. If I add requires notBool pred(X) andBool pred(1), the simplification is applied.
The problem is that even a rule pred(1) => true does not help, since there is no constraint pred(1) to rewrite.


Error in set format command

Tanaka-san,
I have a question regarding the usage of set command. What is the proper way to use "set format"? I got the error in the code below with the debug mode enabled.
Numo.gnuplot do
 ...
 set format: {x: "%Y-%m-%d"}
 ...
end

>gnuplot> set
>             ^
>         line 0: unrecognized option - see 'help set'.

It seems to be OK with the code below.
 ...
 set datafile: {separator: "','"}
 set xtics: "rotate by -45"
 ...

I found the keyword "format_x" in the library. It is, however, not the valid command for gnuplot so I got another error like this.
>gnuplot> set format_x "%Y-%m-%d"
>             ^
>         line 0: unrecognized option - see 'help set'.

I'd appreciate it if you have any advice.
Thanks.

Secure way is
  set 'format x "%Y-%m-%d"'

Recent commit (https://github.com/ruby-numo/gnuplot/commit/9b8f0d796c0e17bbda47e321024dd93b3f90bff0) allows two patterns you suggested:
  set format_x: "%Y-%m-%d"
  set format: {x: "%Y-%m-%d"}

Thank you for the quick fix. It works fine for me.


When a world is loaded during server uptime, the multiverse portal to that specific world does not work.

Information

Server version: 1.16.5

Full output of /mv version -p: https://paste.gg/p/anonymous/e2166431b71e4a2c9e3eca7cb45505da

Server log: https://gist.github.com/RyanHoOo/e4a943f16cc2d419fa945fd6ac9a84ac *

Details
I was able to reproduce my issue on a freshly setup and up-to-date server with the latest version of Multiverse plugins with no other plugins and with no kinds of other server or client mods.
Description
When a world is loaded during server uptime, the multiverse portal to that specific world does not work.
Steps to reproduce

Load a world using commands in-game
Try to enter a Multiverse portal connected to that world

Expected behavior
The player isn't teleported to the world.

I think this is more of a multiverse portal issue.


feat(auction): show history

TODO:

Styling
Where should the "click" be triggered? Maybe we could display a "history" button?

@AndreasGassmann added 2 todos


REST endpoint failing

Summary of Bug
We keep running into a problem where we get an error Message too long. It reconnects to the websocket after this error and keeps relaying but every time this happens the REST endpoint dies and wont stand back up until we restart hermes. Since we use the /state endpoint for some monitoring, our system alerts on this happening frequently.
2023-03-26T17:26:10.764153Z ERROR ThreadId(129) event_monitor{chain=osmosis-1}: failed to collect events: WebSocket driver failed: web socket error: failed to read from WebSocket connection: Space limit exceeded: Message too long: 203625165 > 16777216
2023-03-26T17:26:11.910211Z  INFO ThreadId(129) event_monitor{chain=osmosis-1}:event_monitor.reconnect{chain=osmosis-1}: successfully reconnected to WebSocket endpoint ws://re.dac.te.d:12345/websocket

Version
running: hermes version 1.3.0
Acceptance Criteria
REST endpoint survives any websocket disconnection, or specifically this event.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

REST endpoint dies and wont stand back up...

What does this mean exactly? For which chains do you see that? And how frequently?

Also, could you provide the node config.toml, in particular have you tried with the parameters mentioned here?
We had similar issue a while back for which I thought the workaround above worked.

@sryps I unfortunately haven't been able to reproduce the issue with the REST endpoint even after killing the WebSocket.
If you have the bandwidth, would you will to build and deploy Hermes from this branch: romac/poll-block-results and see if Hermes and its REST endpoint survives the Osmosis epoch block?
That bypasses the WebSocket and relies on pulling data from the chain every block.
We've also upgrade the built-in REST and telemetry server to use more modern libraries which may also alleviate the issue, so if you'd rather not run an experimental branch, you can also try building Hermes from master and see if you notice any improvements.

@romac  so far so good. We can close for now and if it resurfaces I'll let you know! Thanks!


relicense as BSD 3 clause

Will there be a similar PR for the LLVM backend?

Good point. I will do that next.


trident-operator v23.04.0 still creates PodSecurityPolicy even when disabled

I've installed trident via helm chart with values.yml
excludePodSecurityPolicy: true

But the trident-operator pod is still creating them
level=info msg="A Trident pod security policy was found by label." podSecurityPolicy=trident-node-linux
level=debug msg="Patching Trident Pod security policy." podSecurityPolicy=trident-node-linux
W0706 14:02:52.097195 1 warnings.go:70] policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+
W0706 14:02:52.103742 1 warnings.go:70] policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+
level=debug msg="Patched Kubernetes pod security policy." deployment=trident-node-linux label="app=node.csi.trident.netapp.io"
level=debug msg="Patched Trident Pod security policy."

That prevents OKD upgrade path, because deprecated API features are still in use.
The TridentOrchestrator CRD:
spec:
  logLevel: info
  windows: false
  logLayers: null
  IPv6: false
  tridentImage: 'docker.io/netapp/trident:23.04.0'
  autosupportProxy: null
  logWorkflows: null
  probePort: 17546
  disableAuditLog: true
  imagePullPolicy: IfNotPresent
  httpRequestTimeout: 90s
  logFormat: text
  enableForceDetach: false
  namespace: trident
  k8sTimeout: 0
  autosupportImage: 'docker.io/netapp/trident-autosupport:23.04'
  kubeletDir: null
  silenceAutosupport: false

Environment

Trident version: v23.04.0
Kubernetes version: 1.24
Kubernetes orchestrator: OKD 4.11.x

There are 3 PSP for Trident. The one for the operator ("tridentoperatorpods") is created by the Helm chart. When you give helm the excludePodSecurityPolicy=true, this PSP will be removed as its existence would cause issues with Helm after upgrading to 1.25+.
The other two PSP ("trident-controller" and "trident-node-linux") are created and managed by the operator. These are not removed by the helm value as they are not managed via helm. Instead the operator handles them, detects cluster upgrade to 1.25+ and acts accordingly. They stay in place until you actually upgrade to 1.25+ as they are valid until then and might still be needed/desired. The operator handles this for you. This should not block the OKD upgrade? (Though you might need to acknowledge that you want to upgrade with these PSP in place).

Hi @wonderland.
I'm not sure If I unterstand your answer correctly. But yes, I still have 3 PSP present, even with excludePodSecurityPolicy: true.
oc get psp
NAME                  PRIV    CAPS   SELINUX    RUNASUSER   FSGROUP    SUPGROUP   READONLYROOTFS   VOLUMES
trident-controller    false          RunAsAny   RunAsAny    RunAsAny   RunAsAny   false            hostPath,projected,emptyDir
trident-node-linux    true           RunAsAny   RunAsAny    RunAsAny   RunAsAny   false            hostPath,projected,emptyDir
tridentoperatorpods   false          RunAsAny   RunAsAny    RunAsAny   RunAsAny   false            projected

OKD prevents upgrades as long as deprecated APIs are in use.
oc get apirequestcount | grep podsecurity

NAME                                                                       REMOVEDINRELEASE   REQUESTSINCURRENTHOUR   REQUESTSINLAST24H
podsecuritypolicies.v1beta1.policy                                         1.25               68                      1885

 oc get apirequestcounts podsecuritypolicies.v1beta1.policy \
  -o jsonpath='{range .status.last24h..byUser[*]}{..byVerb[*].verb}{","}{.username}{","}{.userAgent}{"\n"}{end}' \
  | sort -k 2 -t, -u | column -t -s -NVERBS,USERNAME,USERAGENT

NAME                  PRIV    CAPS   SELINUX    RUNASUSER   FSGROUP    SUPGROUP   READONLYROOTFS   VOLUMES
watch       system:kube                            controller      manager  kube             controller  manager/v1.24.0
delete get  system:serviceaccount:kube             system:generic  garbage  collector        kube        controller       manager/v1.24.0
list patch  system:serviceaccount:trident:trident  operator        trident  operator/v0.0.0

I think, that the TridentOrchestrator CRD is not updated by Helm deployment and it's missing a flag for excludePodSecurityPolicy.

Hi, we currently have the same issue, we use RKE in our case which does not accept any psp in cluster to be able to upgrade to 1.25, if we manually delete psp, both of them are automatically recreated by trident-operator, so an option according to what @wonderland says is to disable operator (scale 0), manually delete the psp, upgrade, and finally re-enable the trident operator.
We were able to validate this on a preproduction cluster, we still need to validate on production clusters, but it makes sense, of course, an improvement could be appreciated to be able to manage this through the deployment.: https://github.com/NetApp/trident/issues/819
It seems to be well managed by the operator's code :
https://github.com/NetApp/trident/blob/62f1f8045ccd19a4c7bcf3b58c8b6ac020e58bf0/operator/controllers/orchestrator/installer/installer.go#L1835
before upgrade :
kubectl scale deploy trident-operator --replicas=0
kubectl delete psp trident-controller
kubectl delete psp trident-node-linux

after upgrade :
kubectl scale deploy trident-operator --replicas=0

No log raise about psp on trident-operator


Can't download from Twitter. Error code 215 'Bad authentication data'

Can't download from Twitter, no results are displayed no matter what username or keyword is entered in the search field.
When I click on the Twitter link to visit the site, I get the error 215 "Bad authentication data". It seems the api can't be accessed without authentication even if it's public.
I also tried entering my username and password in the login tab within grabber but it fails. Also tried manually adding my internet browser's cookie data and values but nothing works.
OS Windows 10
Grabber 7.1.1 (x64)
main.txt

How do you use Twitter on Grabber?


License?

What's the license for the project? Even if it's all rights reserved, please make that clear.

Sorry, the open source code was rushed out. It’s MIT, will get to it soon

Sounds good, thanks!


Add docs for player reloot time

What’s the unit?

What’s the unit?

The duration, supports s,m,h,d.

Should it maybe say that? From a quick look at paper it seems like only one unit is permitted rather than 2h3m30s which is how I would use this.

Probably yea :+1:


feat: handle priority for golden records from the orchestrator

Description

This PR implements priority handling (High, Low) based on thresholds within the orchestrator. It also adds new endpoints for registering gate components with priorities. The orchestrator will generate the OriginId automatically and that will be used by the gate component.
Issue: https://github.com/eclipse-tractusx/sig-release/issues/856

Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[X] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[X] Copyright and license header are present on all affected files

@nicoprow @SujitMBRDI Raise the PR just for the feedback purpose. I am still working on it.


rancher server side validation throwing errors when spinning up duplicate stack with a different stack name

Rancher versions:
rancher/server: 1.6.10
rancher/agent: 1.2.6
spinning up a duplicate stack under a different stack name emits ire from the rancher server.
someboxR:test1176 ahmad$ rancher  up -s ahmad-8
INFO[0000] Creating stack ahmad-8
INFO[0000] Creating volume template yoyo-storage-volume
INFO[0000] [yoyo-client]: Creating
INFO[0000] [yoyo-data]: Creating
INFO[0000] [yoyo-primary]: Creating
INFO[0000] Creating service yoyo-client
INFO[0000] Creating service yoyo-primary
INFO[0000] Creating service yoyo-data
ERRO[0001] Failed Creating yoyo-data : Bad response statusCode [422]. Status [422 status code 422]. Body: [fieldName=name, baseType=error, code=NotUnique] from [https://my-server.yay/v2-beta/projects/1a5/services]
INFO[0001] [yoyo-primary]: Created
INFO[0001] [yoyo-client]: Created
INFO[0001] [yoyo-sysctl]: Creating
INFO[0001] [yoyo-storage]: Creating
INFO[0001] [yoyo-sysctl]: Created
INFO[0001] [yoyo-storage]: Created
ERRO[0001] Failed to start: yoyo-data : Bad response statusCode [422]. Status [422 status code 422]. Body: [fieldName=name, baseType=error, code=NotUnique] from [https://my-server.yay/v2-beta/projects/1a5/services]
FATA[0001] Bad response statusCode [422]. Status [422 status code 422]. Body: [fieldName=name, baseType=error, code=NotUnique] from [https://my-server.yay/v2-beta/projects/1a5/services]```

I believe the real issue here is that one cant have more than one service reference the same sidekick. The stack that was attempted had this characteristic, its easy to reproduce with a basic example:
version: '2'
services:
  thesidekick:
    image: busybox
    stdin_open: true
    tty: true
  thesvc:
    image: busybox
    stdin_open: true
    tty: true
    labels:
      io.rancher.sidekicks: thesidekick

  somesvc:
    image: busybox
    stdin_open: true
    tty: true
    labels:
      io.rancher.sidekicks: thesidekick

If this isnt supported we should call out the relationship characteristics of services to a sidekick.

The sidekick by definition cannot provide the same scale and placement as two separate services that can be created, scheduled, scaled, and removed separately.

@aemneina what do you want it to be fix? by giving user specific error that they can't have two service pointing to a same sidekick?

When you use catalog service, the example of the compose file goes through and creates a sidekick for each service. It should error out the same as with CLI.

You can either test using a catalog or "Add Stack" in the UI.
I'd also like to test what happens if you have a catalog in 1.6.14 that has this type of yaml and you try to upgrade to the same yaml to see what happens.

I was able to verify that new version is giving the following message with using the same sidekick in both services:
Error (can't have more than one primary service [somesvc thesvc] referencing the same sidekick [thesidekick])

but when i tried the same yaml on the 1.16.14 and upgraded to the latest i could still see the stack up and running


Develop-A-TM-4-TEAM-A-Premium-Section-UI : Added Join Premium UI.

Good job bro , Congratulations.


extra null check before extracting access_token

possible nullpointerexception

Can you please re-submit the PR ? I can't see any changes in the PR.
It's showing 'Showing  0 changed files  with 0 additions and 0 deletions.

will submit new pull request


Not working with android devices

is there an API to make it work with touch events?
since it's not working on most android devices

It absolutely does work with Android devices. Feel free to re-open if you have a more targeted bug report.

@STRML No it doesn't work...this library has at least 5 issues opened about it....no one can uses touch events if the element is wrapped in Draggable...it simple doesn't trigger the children touch events or somehow cancel those

@Gherciu The original bug report told me next to nothing about what the actual problem is - and neither have you. This is open source, if you'd like to spend some time investigating it and come up with a thorough report and/or fix, that would be very helpful.


Close over free variables in lambdas and object literals

Previously, using a variable from the surrounding lexical scope in an object literal or a lambda produced a compiler error. This was surprising to the programmer.
This change allows both lambdas and object literals to use variables in the surrounding lexical scope, as the programmer would expect. In both cases, the closure is expressed under the hood as adding a field that is initialised by passing an alias of the variable to the constructor. For example:
let x = "hi"
let f = {(): String => x}

Here, when f rewrites to an object literal, it becomes:
let f =
  object
    var x: String = x
    fun apply(): String => x
  end

I didn't create an RFC for this, as I think it is a "principle of least surprise" bug.

Yes, squash before merge, definitely. I'm afraid those commits are a bit "stream of work".

Looks good to me if CI passes and the squashing happens. But @jemc is far more qualified than I in all matters compiler.

@sylvanc Does anything in the tutorial need to be updated to reflect this new feature?

I agree that additional tests would be good, probably in parse_expr.cc. If you're up for chipping in, that would be awesome! Feel free to push changes to this branch, or you make a PR to do after this, or whatever suits you.
For the tutorial:
https://tutorial.ponylang.org/expressions/object-literals.html
That page could use a bit of editing to show closing over free variables. I don't think it needs a big explanation or anything, just showing how we can capture from the lexical scope anywhere, not just in field initialisers.

I added a few test cases.

Add a tutorial PR as well:
https://github.com/ponylang/pony-tutorial/pull/172


feat: DP-91907 add leftbar contact centers recipe

:hammer_and_wrench: Type Of Change
These types will increment the version number on release:

[ ] Fix
[x] Feature
[ ] Performance Improvement
[ ] Refactor

These types will not increment the version number, but will still deploy to documentation site on release:

[ ] Documentation
[ ] Build system
[ ] CI
[ ] Style (code style changes, not css changes)
[ ] Test
[ ] Other (chore)

:book: Jira Ticket
DP-91907
:book: Description
Adding a new recipe for the new section Ai Contact Centers in the leftbar.
:bulb: Context
This new component is highly inspired on the DtGeneralRow recipe. The reason behind creating a new component instead of extending the existing DtGeneralRow, is that this component is planned to add more functionality specific for Ai Contact Centers.
Here is an example of what it might look like on the leftbar for an specific use case:

:pencil: Checklist
For all PRs:

[x] I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
[x] I have reviewed my changes.
[x] I have added all relevant documentation.
[x] I have considered the performance impact of my change.

For all Vue changes:

[x] I have added / updated unit tests.
[x] I have made my changes in Vue 2 and Vue 3. Note: you may sync your changes from Vue 2 to Vue 3 (or vice versa) using the ./scripts/dialtone-vue-sync.sh script.
[ ] I have validated components with a screen reader.
[ ] I have validated components keyboard navigation.

For all CSS changes:

[ ] I have used design tokens whenever possible.
[x] I have considered how this change will behave on different screen sizes.
[x] I have visually validated my change in light and dark mode.
[x] I have used gap or flexbox properties for layout instead of margin whenever possible.

If new component:

I am exporting any new components or constants:

[x] from the index.js in the component directory.
[x] from the index.js in the root (either packages/dialtone-vue2 or packages/dialtone-vue3).

[ ] I have added the styles for the new component to the packages/dialtone-css package.
[ ] I have created a page for the new component on the documentation site in apps/dialtone-documentation.
[ ] I have added the new component to common/components_list.cjs
[x] I have created a component story in storybook
[x] I have created story / stories for any relevant component variants in storybook
[x] I have created a docs page for the component in storybook.
[ ] I have checked that changing all props/slots via the UI in storybook works as expected.

:link: Sources
Figma designs for the new Ai Contact Centers leftbar item.
https://www.figma.com/file/pBHnsczKRLyZhx5TgR0N6g/[DP-72221]-Redesign-How-Contact-Centers-Appear-In-Dialpad?type=design&node-id=1490-13251&mode=design&t=BPH1BoPJCfsWwjfD-4
Figma link to a preliminary version of the Ai Contact Centers leftbar item variants (future work, not included in this PR).
https://www.figma.com/file/oV7c9s0EHj6QCLKFm1Jl4i/[DP-88690]-Display-time-in-status-to-agent?type=design&t=U5AybOGzRvd6GMuB-6

@juliodialpad most of the check are failing on installing dependencies, suggestion is to update the lockfile, should I commit that?

@juliodialpad most of the checks are failing on installing dependencies, suggestion is to update the lockfile, should I commit that?

just pushed an updated pnpm-lock file, just merge staging to your branch and should be ok

This row has three actionable targets, but two of them are nested within the overall row item target. Placing an actionable element within another (e.g. <a> or <button>) is basic no-no. This also confuses the interaction's visual response, such that the :active (mousedown) state of a nested action triggers the parent's :active state.
https://github.com/dialpad/dialtone/assets/1165933/66cc7e33-bb6e-4b66-b6c3-573da5cfed42
As a reference, consider the Contact Row. The Call action on hover is a appear of the entire row's actionable item.
https://github.com/dialpad/dialtone/assets/1165933/e4195957-8135-4ba5-a553-14f86caf0e08

Thanks for the feedback @francisrupert!
I've been trying to avoid this nesting but I keep hitting some walls on every direction I take.
I've based my component on General Row which is used as links in the app leftbar. Most of the leftbar components have just 2 sections or just 1 "actionable" region other than the link itself.
Now I need to place another actionable element in the row. I've moved the scope of the a element, so the other buttons are out of it.

Here unread/action is placed with position:absolute as we have on components like the Contact Row. And the anchor an the right slot are using a flex layout.
Also, I need to have some showing/hiding elements on row hover, which is not easily doable with CSS, as the HTML elements are after my change. Also, when I try to use events on a div I get:
ESLint: Visible, non-interactive elements should not have an interactive handler.(vuejs-accessibility/no-static-element-interactions)

Is there any suggestion you could share so I can follow the no-nesting actionable elements?
The only path I haven't tried yet was to calculate the with of the a using JS and attaching this to a resize observer, which I would preferably avoid.
Thanks in advanced!

Also, I need to have some showing/hiding elements on row hover, which is not easily doable with CSS, as the HTML elements are after my change. Also, when I try to use events on a div I get:

It should be on the  instead of the div if that's your interactive element. The  is the entire "pill" right?

I can check this out if you can push the partial fix.

It should be on the <a> instead of the div if that's your interactive element. The <a> is the entire "pill" right?

Thanks @braddialpad, right, the thing is that I have a couple of constraints that end up interlocking me.

Text of the pill should be ellipsed.
We have one slot that will contain a button and also the "menu" button/unread count.
If there're unreads elements, and the user hover anywhere in the pill it should be hidden and the "menu" button should be clickable.

I've just pushed a new commit with my parcial change to fix the nesting issue. Any guidance would be appreciated 🙏

I've just pushed a new commit with my parcial change to fix the nesting issue. Any guidance would be appreciated 🙏

Hey Santiago, I think you will have a much easier time if you use the existing general row component and make some changes to it than creating a whole new component. There is a lot of logic and CSS in the general row related to layout and positioning that I think we can reuse here with a few small additions.
I'm working on an addition to general row for a secondary slot that would show up beside the unreads / call button within the "omega" element. Looking promising so far. I'll make a PR into this one shortly

do you also need a "bottom" slot to do this sort of thing? What is the function of the button with the "down arrow" on the right?

Created a PR to fix your mentioned issues here: https://github.com/dialpad/dialtone/pull/309

Thanks @francisrupert for the feedback!
Thanks @braddialpad for the code example and the guidance!
I've put everything together and the PR is ready for a second round of review.
Update: this now includes the addition of the timer slot.

One small contrast issue @francisrupert any suggestions? This doesn't need to block this PR.


Add redis cache ci tests

Will fix #892

Codecov Report

Merging #1112 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1112      +/-   ##
==========================================
- Coverage   54.61%   54.45%   -0.16%
==========================================
  Files          42       42
  Lines        7601     7601
==========================================
- Hits         4151     4139      -12
- Misses       2929     2940      +11
- Partials      521      522       +1

Impacted Files
Coverage Δ

cache_lru.go
53.45% <0%> (-8.18%)
:arrow_down:

session_get.go
73.46% <0%> (-3.41%)
:arrow_down:

engine.go
61.81% <0%> (+0.22%)
:arrow_up:

logger.go
66.66% <0%> (+5.79%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e8290c...824e444. Read the comment docs.


BUG

Here is an error I get after running the basic rtdb , any guide on this please?
Thanks.
In file included from C:\Users\Dev. Ben Salcie\Documents\Arduino\libraries\Firebase-ESP-Client-
main\src/common.h:45:0,
             from C:\Users\Dev. Ben Salcie\Documents\Arduino\libraries\Firebase-ESP-Client-main\src/Utils.h:37,

             from C:\Users\Dev. Ben Salcie\Documents\Arduino\libraries\Firebase-ESP-Client-main\src/signer/Signer.h:37,

             from C:\Users\Dev. Ben Salcie\Documents\Arduino\libraries\Firebase-ESP-Client-main\src/Firebase_ESP_Client.h:37,

             from C:\Users\Dev. Ben Salcie\Documents\Arduino\libraries\Firebase-ESP-Client-
            main\examples\RTDB\Basic\Basic.ino:18:

              C:\Users\Dev. Ben Salcie\Documents\Arduino\libraries\Firebase-ESP-Client-
               main\src/wcs/esp8266/FB_HTTPClient.h:50:30: fatal error: CertStoreBearSSL.h: No such file or directory

              #include <CertStoreBearSSL.h>

                          ^

You should update ESSP8266  Arduino Core SDK to the latest version.

Here is an error I get after running the basic rtdb , any guide on this please?
Thanks.
In file included from C:\Users\Dev. Ben Salcie\Documents\Arduino\libraries\Firebase-ESP-Client-
main\src/common.h:45:0,
             from C:\Users\Dev. Ben Salcie\Documents\Arduino\libraries\Firebase-ESP-Client-main\src/Utils.h:37,

             from C:\Users\Dev. Ben Salcie\Documents\Arduino\libraries\Firebase-ESP-Client-main\src/signer/Signer.h:37,

             from C:\Users\Dev. Ben Salcie\Documents\Arduino\libraries\Firebase-ESP-Client-main\src/Firebase_ESP_Client.h:37,

             from C:\Users\Dev. Ben Salcie\Documents\Arduino\libraries\Firebase-ESP-Client-
            main\examples\RTDB\Basic\Basic.ino:18:

              C:\Users\Dev. Ben Salcie\Documents\Arduino\libraries\Firebase-ESP-Client-
               main\src/wcs/esp8266/FB_HTTPClient.h:50:30: fatal error: CertStoreBearSSL.h: No such file or directory

              #include <CertStoreBearSSL.h>

                          ^

You should update ESSP8266 Arduino Core SDK to the latest version.

Thanks a lot Bro for the fast response and the time. Next time you could consider stating this in the documentation. Thanks a lot

The ESP8266 SDK you're using is almost 2-3 years released as it used axTLS as SSL engine instead of the later version that has bot axTLS and BearSSL.

This library is the unified and upgrade version of FirebaseESP8266 and FirebaseESP32 libraries which relied on BearSSL and mbedTLS libraries which required for token signing.
The doc of FirebaseESP8266 library also state the supported ESP8266 SDK version. Everyone that migrates from that library is already known.


[MM-232]: Fixed the issue of same message being received while creating and deleting tags

Summary
Fixed the issue of the same message being received while creating and deleting tags
Screenshots
Existing

Updated

How to test

Setup GitLab plugin, connect to the user, and create a subscription for a repo
Create/Delete a tag on the repo

Created a PR with all these changes on Mattermost remote hence closing this one.


sdformat_urdf parser demo

🎉 New demo
Summary
Demonstrating SDFormat XML as a robot description format instead of URDF XML using sdformat_urdf plugin. The parser takes the SDF file published on /robot_description topic by robot_state_publisher and converts it to URDF C++ DOM structures. Joint states and TFs are bridged using ros_ign_bridge enabling RViz to visualize the RobotModel and odometry simulated by a Gazebo world.
Also demonstrates a use-case of #259.
Changes made

Parser compatible SDF model
Gazebo world with required plugins (JointStatePublisher, PosePublisher, OdometryPublisher)
Launch file bringing up launch arguments, Gazebo, ros_ign_bridge, robot_state_publisher and RViz
RViz config
Installation framework for the new model and world

Snapshots

https://user-images.githubusercontent.com/24695820/176565497-80414260-f958-44cc-8323-673077fad3d8.mp4
Test it
In a colcon workspace, install ros_gz and sdformat_urdf from source. Make sure you have the latest Gazebo fortress release.
Run the demo launch file with the rviz launch argument set.
ros2 launch ros_ign_gazebo_demos sdf_parser.launch.py rviz:=True

Start the simulation in Gazebo and wait a second for TFs to be published.
Send commands for the vehicle to move in circles, matching its trajectory in Gazebo and RViz.
ign topic -t "/model/vehicle/cmd_vel" -m ignition.msgs.Twist -p "linear: {x: 1.0}, angular: {z: -0.1}"

Checklist

[x] Signed all commits for DCO
[x] Added tests
[x] Added example and/or tutorial
[ ] Updated documentation (as needed)
[x] Updated migration guide (as needed)
[x] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

I'm pretty sure CI is consistently broken on the ros2 branch.

test_launch_test_ros_subscriber.launch.py is failing for fortress+humble


Support 64-bit

https://discuss.grapheneos.org/d/1968-32bit-apps-on-google-pixel-7

Dang, yeah right now we're limited in that we don't have a build server anymore. If folks could donate a VM or compiling the app I could take a shot at adding it.

Would some money help?

Probably yes, but I'm aiming for at least 60k USD so we can get a decent chunk of work done at once.

I can't afford that much lol

Yeah I don't expect individuals to do so. If you come across any grant funds then it'd be more likely. I'm on the lookout as well./ In the meantime if you have a beefy computer you couuld try cloning the repo and doing a build yourself. You may need to leave it running overnight

You'd also need to compile a 64bit version of this repo: https://github.com/AgregoreWeb/agregore-ipfs-daemon


-d parameter means debug not daemonize

You should not use -d but -S to run the process in foreground.
Using -d will mean slower performance and a lot of logs (really a lot of logs).

Fixed. Thanks😊


Add link-checker-api

This also adds the link checker api worker as a dependency of the backend app which seems to work
pretty well.
running:
curl -s http://link-checker-api.dev.gov.uk/check\?uri\=https%3A%2F%2Fwww.gov.uk%2F
gives an initial response of:

{"uri":"https://www.gov.uk/","status":"pending","checked":null,"problem_summary":null,"errors":[],"warnings":[],"suggested_fix":null}%

once the worker has run, repeating the request gives the response:

{"uri":"https://www.gov.uk/","status":"ok","checked":"2019-07-02T10:04:44Z","problem_summary":null,"errors":[],"warnings":[],"suggested_fix":null}%

We don't think we need an e2e option right now.
https://trello.com/c/CrqFTwwu/35-set-up-link-checker-api

We've updated the makefile format and tweaked the dependencies. 👍


Text poistion in lv_ta

I have a question. If I would like to adjust the position of text in lv_ta, which vpad and hpad should I take?

Style of lv_ta
Style of scrollbar style_sb from lv_page_get_style_sb(ta)

I made some try. I use ptask to change vpad periodically.
I set vpad on style of lv_ta, it worked on the first time call lv_obj_set_style(ta, &ta_style), but it didn't work on the second time or set style to the other new lv_style_t.
About style_sb, It's no effect by changing its vpad.
Thanks!

It really doesn't work properly. I will fix it on Monday. Until that please try this: lv_obj_set_style(lv_page_get_scrl(ta), &style) it will set the style of the transparent scrollable part of text area. Use LV_STYLE_TRANSP_TIGHT as starting point.
vpad and hpad now do not affect the scrollbar position but it is a good idea to fo that!

Now the label's position should be affected by hpad and vpad.
Can you test it?
I will add the scrollbar part soon.

Now the label's position should be affected by hpad and vpad.
Can you test it?

No problem.
After testing, It works now, thank you!

How do you imagine the scrollbar and hpad/vpad relationship?
Sorry, I'm not familiar with them. I guess it can change hpad/vpad to adjust the position of scrollbar.

I'm happy that it's working! :)
I will figure out something for scrollbar.

In beta scrollbar positions are affected by style.body.padding.hor and style.body.padding.hor.
(Please update you misc_conf.h and lv_conf.h from misc_conf_templ.h and lv_conf_templ.h)
Like this:
    static lv_style_t sb_style;
    lv_style_copy(&sb_style, &lv_style_plain_color);
    sb_style.body.padding.hor = -15;
    sb_style.body.padding.ver = 15;

    lv_obj_t *page = lv_page_create(lv_scr_act(), NULL);
    lv_page_set_style(page, LV_PAGE_STYLE_SB, &sb_style);
    lv_page_set_sb_mode(page, LV_SB_MODE_ON);
    lv_page_set_scrl_fit(page, true, true);
    lv_obj_set_size_scale(page, 100, 200);
    lv_obj_set_pos_scale(page, 10, 10);

    lv_obj_t *label = lv_label_create(page, NULL);
    lv_label_set_text(label, "long long lines\n\n"
                             "to shows the\n\n"
                             "scrollbars'\n\n"
                             "position.\n\n"
                             "Some dummy text\n\n"
                             "Some dummy text\n\n"
                             "Some dummy text\n\n");

Added in v5.0.0


Docs do not build with latest sphinx 1.6.x

Self explanatory. Looks like default_sidebars was removed in sphinx-doc/sphinx#3590
$ npm run build:docs

><EMAIL_ADDRESS>build:docs /home/ubuntu/dev/neon-js
> cd source && sphinx-versioning -g ../ -l ./conf.py build source ../docs

=> Reading config from ./conf.py...
Running Sphinx v1.6.5
WARNING: The config value `scv_whitelist_tags' has type `str', defaults to `tuple'.
loading pickled environment... not yet created

Exception occurred:
  File "/usr/local/lib/python2.7/dist-packages/sphinxcontrib/versioning/sphinx_.py", line 60, in builder_inited
    app.config.html_sidebars['**'] = StandaloneHTMLBuilder.default_sidebars + ['versions.html']
AttributeError: type object 'StandaloneHTMLBuilder' has no attribute 'default_sidebars'

Full trace:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/sphinx/cmdline.py", line 305, in main
    opts.warningiserror, opts.tags, opts.verbosity, opts.jobs)
  File "/usr/local/lib/python2.7/dist-packages/sphinx/application.py", line 234, in __init__
    self._init_builder()
  File "/usr/local/lib/python2.7/dist-packages/sphinx/application.py", line 312, in _init_builder
    self.emit('builder-inited')
  File "/usr/local/lib/python2.7/dist-packages/sphinx/application.py", line 489, in emit
    return self.events.emit(event, self, *args)
  File "/usr/local/lib/python2.7/dist-packages/sphinx/events.py", line 79, in emit
    results.append(callback(*args))
  File "/usr/local/lib/python2.7/dist-packages/sphinxcontrib/versioning/sphinx_.py", line 60, in builder_inited
    app.config.html_sidebars['**'] = StandaloneHTMLBuilder.default_sidebars + ['versions.html']
AttributeError: type object 'StandaloneHTMLBuilder' has no attribute 'default_sidebars'

This is an issue with sphinxcontrib-versioning. We can move to 1.6x once they update. If they update... the repo looks dead, the fix is already in a PR but i doubt it will get pushed in.


8-bit weight compression

Introduced data-free weight compression to 8 bits.
It is lossless for LLMs and reduces the footprint significantly
Runtime optimization will be available in the next release of OV
Reworked quantization

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Submit patch for .bz

Support for .bz (belize) can be obtained by configuring the host:
BZ_HOST = "whois.afilias-grs.info"
And the parser:
elif domain.endswith('.bz'):
return WhoisJobs(domain, text)
Tried to push into a new branch but don't have the access rights

pull request welcome!


Getting crash when progress increment is lesser than 1 percent

Here https://github.com/mrackwitz/MRProgress/blob/master/src/Components/MRCircularProgressView.m#L233
timerInterval is NaN
because
po self.progress - progress
-0.00379740447

I set download task by doing this
[self.progressBar setProgressWithDownloadProgressOfTask:downloadTask animated:YES];

self.progressBar is an instance of MRCircularProgressView.

It started working somehow. Sorry for disturbing.


Issue completions don't appear in monorepo mode

Found verifying https://github.com/microsoft/vscode-pull-request-github/issues/2087
Open the vscode/src folder in code, checkout a pull request that modifies files in src. Open one of those files. Comments have user completions but not issues completions.

Issue completions in comments is fixed in the nightly build.


[CLI]: Gymnasium v1.0.0 incompatible with monitor_gym

Describe the bug
Gymnasium has just released v1.0.0a1 which removes gymnasium.wrappers.monitoring.video_recorder in favour of gymnasium.wrappers.RecordVideo.
Therefore, wandb.init(monitor_gym=True) fails

> pip install gymnasium==1.0.0a1

import wandb

wandb.init(
    project="project_name",
    entity="entity",
    monitor_gym=True,
)

Error importing optional module gymnasium.wrappers.monitoring.video_recorder
Traceback (most recent call last):
  File ".../.venv/lib/python3.11/site-packages/wandb/util.py", line 233, in import_module_lazy
    return sys.modules[name]
           ~~~~~~~~~~~^^^^^^
KeyError: 'gymnasium.wrappers.monitoring.video_recorder'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File ".../.venv/lib/python3.11/site-packages/wandb/util.py", line 262, in get_module
    return import_module_lazy(name)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../.venv/lib/python3.11/site-packages/wandb/util.py", line 235, in import_module_lazy
    spec = importlib.util.find_spec(name)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib.util>", line 94, in find_spec
ModuleNotFoundError: No module named 'gymnasium.wrappers.monitoring'
wandb: ERROR Couldn't import the gymnasium python package, install with `pip install gymnasium`
Traceback (most recent call last):
  File ".../scratch_wandb_monitor_gym.py", line 3, in <module>
    wandb.init(
  File ".../.venv/lib/python3.11/site-packages/wandb/sdk/wandb_init.py", line 1195, in init
    raise e
  File ".../.venv/lib/python3.11/site-packages/wandb/sdk/wandb_init.py", line 1172, in init
    wi.setup(kwargs)
  File ".../.venv/lib/python3.11/site-packages/wandb/sdk/wandb_init.py", line 279, in setup
    wandb.gym.monitor()
  File ".../.venv/lib/python3.11/site-packages/wandb/integration/gym/__init__.py", line 38, in monitor
    vcr = wandb.util.get_module(
          ^^^^^^^^^^^^^^^^^^^^^^
  File ".../.venv/lib/python3.11/site-packages/wandb/util.py", line 269, in get_module
    raise wandb.Error(required)
wandb.errors.Error: Couldn't import the gymnasium python package, install with `pip install gymnasium`

Additional Files
No response
Environment
WandB version: 0.16.3
OS: MacOS
Python version: 3.11
Versions of relevant libraries: Gymnasium 1.0.0a1
Additional Context
No response

@pseudo-rnd-thoughts thanks for reporting this issue, we usually don't test with pre-releases of our integrations.
However this looks like something we could patch quite easily,  so we will try to include it in the upcoming march release.

Thanks @kptkin, let me know if there are any issues that I can help fix

Thanks @kptkin, let me know if there are any issues that I can help fix

@pseudo-rnd-thoughts we accept contributions so if you are in the mood, we are happy to accept a patch here 😄
otherwise we will try to squeeze it to the march release

Hi @kptkin and @pseudo-rnd-thoughts,
I went ahead had a crack at adding Gymnasium v1.0.0 support to monitor_gym.
Please have a look at the PR for a full description of changes.
Also please note that full functionality for post-v1.0.0 versions of Gymnasium will depend on updates from other projects that use Gymnasium. These updates are being tracked in the related Gymnasium issue: Farama-Foundation/Gymnasium#944. So perhaps the PR should remain in draft form until that support is added to the other projects.
I look forward to hearing your thoughts and feedback.
I am currently interviewing for the Senior Data Platform Engineer on the Data Science team at Weights & Biases. If you find my PR to be helpful, please do let the Taylor Holland the hiring manager know. I want to show that I can come in, take initiative, and immediately contribute :)
Best regards,
Drew Meyers


update to use lable selector for test cases

Signed-off-by: hchenxa<EMAIL_ADDRESS>https://github.com/open-cluster-management/backlog/issues/14099

/test test-e2e

/assign @morvencao


State migration improvements

### Tasks
- [ ] #108
- [ ] #109

Turning #108 and #109 into epics and closing this to remove one level of tracks.


up should not build by default

Is your feature request related to a problem? Please describe.
 There is no need to implicitely build when using up.
Describe the solution you'd like
Remove the --no-build flag and make it implicit to not do anything in case the image is not present. Add a --build flag to ease building.
Describe alternatives you've considered
I believe today it does not work in the intended way, see https://github.com/docker/compose/commit/3056ae4be329333e0f63568fc7d20a1d379b4172 which talks about "to save time when services were already freshly built".
Additional context
I'll add a UML in the second post, maybe.

invalid

get docker-compose.yml
docker-compose up

valid
build and up

docker-compose build
docker-compose up

or

docker-compose up --build

pull and up

docker-compose pull
docker-compose up

or

docker-compose up --pull

or

docker-compose pull-up

docker-compose.yml with:

build but not image: explicitely build (or implicitely build and keep --no-build)
image and build: implicitely pull once / explicitely pull always / explicitely build
image but not build: implicitely pull once / explicitely pull always
neither: invalid


[enhancement] UI discount modal

Se aplica el diseño de UI al modal de descuento.

Codecov Report

:exclamation: No coverage uploaded for pull request base (feature/discountv2-r1@fe48c0b). Click here to learn what that means.
The diff coverage is 19.23%.

@@                   Coverage Diff                    @@
##             feature/discountv2-r1    #1046   +/-   ##
========================================================
  Coverage                         ?   28.06%
========================================================
  Files                            ?      300
  Lines                            ?    14450
  Branches                         ?     1327
========================================================
  Hits                             ?     4056
  Misses                           ?     9884
  Partials                         ?      510

Impacted Files
Coverage Δ

...rc/main/java/com/mercadopago/CheckoutActivity.java
0% <0%> (ø)

...rc/main/java/com/mercadopago/views/AmountView.java
0% <0%> (ø)

...java/com/mercadopago/core/MercadoPagoCheckout.java
0% <0%> (ø)

...va/com/mercadopago/core/MercadoPagoComponents.java
29.18% <0%> (ø)

...ain/java/com/mercadopago/PaymentVaultActivity.java
0% <0%> (ø)

...va/com/mercadopago/views/DiscountDetailDialog.java
0% <0%> (ø)

...c/main/java/com/mercadopago/model/PaymentData.java
100% <100%> (ø)

.../mercadopago/presenters/PaymentVaultPresenter.java
60.26% <50.98%> (ø)

.../com/mercadopago/presenters/CheckoutPresenter.java
59.55% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe48c0b...b0d172c. Read the comment docs.


Fix bug in view and improve documentation

View documentation might still needs improvements, but this can be done in a separate merge. However, comments of what can be improved will be useful.

Current coverage is 100.00%

Merging #128 into master will not affect coverage as of e88d7a2

@@            master    #128   diff @@
======================================
  Files           30      30
  Stmts          988     990     +2
  Branches         0       0
  Methods
======================================
+ Hit            988     990     +2
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of e88d7a2

Powered by Codecov. Updated on successful CI builds.


Resolves internal issue #440

Bugfix: Makes the new wrapRawVector work even if the Coordinates class of the output vector does not match the default one of the reference implementation. This is needed for the backends that degelate some functionalities to reference or reference_omp.

All targets (including tests) build, all smoke tests pass, internal CI is happy, and code review OK.


Add Image Upload Project

This project has the feature of image upload in a very animated way. And this feature is most needed in the profile section of the websites.
Its working video,
https://user-images.githubusercontent.com/75881393/118395501-5d1d7e00-b668-11eb-9ff6-c2d23065a590.mp4

Please @ridsuteri @991rajat @urvashi-code1255 review this issue.


Publish 7.2-20210816012935+0000

Publish 7.2-20210816012935+0000

@bot-gradle test and merge

OK, I've already triggered a build for you.


Fix MTECorpusReader test error

Test is now skipped: doctest is only used for documentational purposes. This solution has been chosen following examples provided in reader/tagged.py and reader/aligned.py.

Thanks @fievelk


Get AMR Profile in a better state

It's fairly messy right now. It needs to be refactored.
Unfortunately AMR Profile works with master_blastr.R. So... yeah..
But we need it!

New input calling via CL has AMR profile working now. Code refactoring is lower priority than getting MVP out the door.


Pass combined producer to Broadcaster

Currently, the broadcaster state-getter calls getState on every producer in the map. This is prone to bugs since the combined producer does not update the state of the individual producers!
Pass the root producer to Broadcaster, and filter out non-shared state when a player retrieves state.
Write tests to make sure this bug doesn't come back.

The same needs to be done on the client.

Update combineProducers docs to reflect this pitfall


Challenges implementing Multi-Value Control

I am struggling to get the Multi-Value control to display in the Web Page. I have done all that I have thought is needed, but it does not work.
I have attached an XML with what I have done but it does not work. I am attempting to set the Target Version Fields as a Multi-value Field.
Product Backlog Item.xml.txt

A few questions for you

Are you on VSTS or TFS?
If TFS, which version are you on?
Do you have the New work item form enabled? (These extensions are only for the new work item form)

Matthew,
Item number three was the correct answer. I was not aware of this setting. I have activated the new forms and now it works.
Thank you for your reply. This helped tremendously.
Joe Phy

From: Matthew Manela<EMAIL_ADDRESS>Sent: Tuesday, January 3, 2017 1:44 PM
To: Microsoft/vsts-extension-multivalue-control
Cc: jprettyman; Author
Subject: Re: [Microsoft/vsts-extension-multivalue-control] Challenges implementing Multi-Value Control (#10)
A few questions for you

Are you on VSTS or TFS?
If TFS, which version are you on?
Do you have the New work item form enabled? (These extensions are only for the new work item form)

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/vsts-extension-multivalue-control/issues/10#issuecomment-270205176, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXttobrjHG5OVL2Ub23FkzL0Bcbt2K2Vks5rOqUogaJpZM4LYxHZ.


does Image props capInset has no any effect?

I have use image with capInset like this:
style
var style = StyleSheet.create({
 bubble:{
  width:200
}
});

bubble component
<Image capInsets={{top:30,left:15,bottom:20,right:20}} style={styles.bubble} source={imgUrl}>
    <Text>{message}</Text>
</Image>

and the image size is :
height:108,
width:130
the source image:

but I can not get the expected result .
Could anyone tell how to resolve this ?
Or is the capInset has no any effect when using react native?
Or is that a bug with capInset in react-native

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/does-image-props-capinset-has-no-any-effect
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.

@facebook-github-bot stack-overflow

This may actually be a bug as of 0.33 of RN. Digging deeper now, but it looks like setCapInsets calls reloadImage and in certain cases may never call updateImage (which looks like what actually calls resizableImageWithCapInsets).
I'll follow up with more info as I dig in.


Add option to automatically update requirements.txt file

Maybe look for a comment in the file (# visual studio auto update or something) and then automatically refresh the contents whenever a package is added or removed.

We're closing old issues with no recent activity. If this is still important, please open a new issue.


Sanu

added one more pet

WOW !! You have so many pets ||

Ok || Please tell others to contribute here as well || Give a star to the repo if u like || 😊


map points on conics are removed when new entry is graphed.

map points disappear when new entries are graphable.  This behavior does not happen for regular graphs.

reRenderLines() was the culprit!!  What was this for?  is it needed?

Ok, I see... it was to regraph things when points are closed and remade.  When fixed the map points on conics issue need to be resolved.

This issue appears to be resolved???  closing this.


[Scenario] SmugglerspointID

What kind of mission do you want to add (mark with an X, e.g. [X] Descent)?

[ X] Mansions of Madness
[ ] Descent

What expansions does the scenario require?

[ ] Conversion Kit (CK)
[X ] First Edition (MoM1E) - Also Recurring Nightmares
[ ] Fatal Alchemy (FA) - Also Suppressed Memories
[ ] Call of the Wild (CotW) - Also Suppressed Memories
[ ] Beyond the Threshold (BtT)
[ ] Streets of Arkham (SoA)
[ ] Sunctum of Twilight (SoT)
[ ] Horrific Journeys (HJ)
[ ] Path of the Serpent (PotS)

What expansions can the scenario optionally use?

[ ] Conversion Kit (CK)
[ X] First Edition (MoM1E) - Also Recurring Nightmares
[ ] Fatal Alchemy (FA) - Also Suppressed Memories
[ ] Call of the Wild (CotW) - Also Suppressed Memories
[ ] Beyond the Threshold (BtT)
[ ] Streets of Arkham (SoA)
[ ] Sunctum of Twilight (SoT)
[ ] Horrific Journeys (HJ)
[ ] Path of the Serpent (PotS)

Please enter the GitHub Url to your scenario here
https://github.com/jariterbang/Smuggler-s-Point-ID

credit to the original, I was just localized it to bahasa indonesia, but i'm still working on the voice over so not replaced yet. and the reason I uplad new scenario (not a translation) is because there's no Bahasa Indonesia option yet, I hope someday. Thank you.

@jariterbang thank you for choosing my scenario as the first translated scenario into Bahasa Indonesia. I feel honored.
Although, this is not exactly how that works. Usually, I add the localization files and the sound files to the original scenario. If you add it like this, you won't be able to select it due to the language filter in the application.
If this issue gets solved (https://github.com/NPBruce/valkyrie/issues/1572) then you can select your language, and translate any scenario you like into your language by simply asking the scenario owner to add your translated localization.txt file to the scenario (and possibly sound files).

@jariterbang Meanwhile you can share the file on any RRSS or any suitable places with instructions to play it offline. It's a good way to play a scenario that it's not on the Valkyrie list. A short tutorial might be useful.

@antontimmermans thank you, you are awesome, yours is a great intro scenario for the platform it really helps me learn how the software works.
Yes I am aware, I translated the text in the original (english) localization file so by default it'll be in Indonesian. I hope this doesn't violate any rules, really sorry if it does, not my intention.
@vidimus thank you, I still don't know how to transfer the scenario to be able to play it offline, but I'll figure it out

Hello, @jariterbang
Share the .valkyrie file with the potential players.
They need to install the file on the Valkyrie download folder. On Windows, it's a hidden folder, so first you need to grant permission on the file browser to see files with that attribute.
Folder path is:
C:\Users\NAMEl\AppData\Roaming\Valkyrie\Download (NAME is your user name on Windows and C is the hard disk where Valkyrie is installed).
Just copy paste the .valkyrie file.
Access to the offline mode is quite easy, just click on the button on the right top corner on the scenario list.
On Android, download folder is
/device/valkyrie/download
(Device is the corresponding to the tablet or mobile phone)


Feature: Additional type to LinkOpenType

Need:

Handle clicked url without opening Safari

Possible Solution:

Can be added a new type as custom and a parameter as closure which gets URL in order to execute when url selected.

Thank you for raising the issue and also for submitting the PR  that adds the feature.
I have released version 2.3.1,  which includes this new functionality.


FileLocator fixes for Windows

See commit messages

I ran into this issue with file path length.

Thanksi for taking care of us poor Windows developers :wink:


Evaluate Profile-Guided Optimization (PGO) and LLVM BOLT

Hi!
Recently I did many Profile-Guided Optimization (PGO) benchmarks on multiple projects (including interpreters and compilers like CPython, Rustc, Clang, GCC, and many others) - the results are available here. So that's why I think it's worth trying to apply PGO to Berry tooling.
I can suggest the following things to do:

Evaluate PGO's applicability to Berry tooling with benchmarks.
If PGO helps to achieve better performance - add a note to Berry's documentation about that. In this case, users and maintainers will be aware of another optimization opportunity for Berry.
Provide PGO integration into the build scripts. It can help users and maintainers easily apply PGO for their own workloads.

Here are some examples of how PGO is already integrated into other projects' build scripts:

Python:

CPython: README
Pyston: README

Rustc: a CI script for the multi-stage build
GCC:

Official docs, section "Building with profile feedback" (even AutoFDO build is supported)
A part in a "wonderful" configure script

Clang: Docs
Go: Bash script
V8: Bazel flag
ChakraCore: Scripts
Chromium: Script
Firefox: Docs

Thunderbird has PGO support too

PHP - Makefile command and old Centminmod scripts
MySQL: CMake script
YugabyteDB: GitHub commit
FoundationDB: Script
Zstd: Makefile
Foot: Scripts
Windows Terminal: GitHub PR
Pydantic-core: GitHub PR

After PGO, I can suggest evaluating LLVM BOLT as an additional optimization step after PGO.

This should be able to be added once CMake build scripts #370 are supported? I'm not going to do this in Makefile because CMake is better.

This should be able to be added once CMake build scripts https://github.com/berry-lang/berry/issues/370 are supported? I'm not going to do this in Makefile because CMake is better.

If you are talking about integrating PGO build mode directly to the build scripts - yeah, it could be integrated directly into the CMake scripts. As an example, you can look at the following projects:

Clang: CMake cache
MySQL: CMake script

However, you can add PGO support even without CMake (e.g. via a dedicated Makefile command) - it's all up to you.

I want to do it in CMake because it's cross-platform and it can generate Makefiles.


small query

Hi,
Thanks for providing the code and making it so user-friendly! I had a small query regarding the name of the pretrained weight file shared. e121_NN_0.480_NNT_0.655_NNDR_0.813_MeanMS_0.649.pth.tar Am I right in assuming they're the accuracies using those evaluation metrics? If so, this is on which data exactly? (HPatches? Validation? Test? V/I?) Also what is MeanMS?

Also, could you share the split of train (&val) and test scenes on HPatches?

@skrish13
of course, but recently I am busy with DL, so can you wait a few more weeks?

@skrish13
The file name e121_NN_0.480_NNT_0.655_NNDR_0.813_MeanMS_0.649.pth.tar comes from the code in evaluate() function:
https://github.com/Xylon-Sean/rfnet/blob/f6b54087f27caf84103806393c166c4d78d14613/train.py#L408
You could see, we call this evaluate() function on Line 451 and send a parameter called val_data
https://github.com/Xylon-Sean/rfnet/blob/f6b54087f27caf84103806393c166c4d78d14613/train.py#L423
The val_data defined on Line 214.
https://github.com/Xylon-Sean/rfnet/blob/f6b54087f27caf84103806393c166c4d78d14613/train.py#L214
Therefore, the first question is

If so, this is on which data exactly?

The answer of this question is

The evaluation data comes from line 236 to 265 in hpatch_view.csv

The second question is

what is MeanMS?

The answer is

meanms = (PreNN + PreNNT + PreNNDR) / 3
on
https://github.com/Xylon-Sean/rfnet/blob/f6b54087f27caf84103806393c166c4d78d14613/train.py#L406

This is great! Thanks for the detailed response :)


Release notes for 2022-03-22 release (3.5.59)

CI Errors unrelated to the release announcement (although they should be fixed). Off-line reivew


Added changes for sending targeted meeting notifications

@Prithvi-MSFT
Make sure that you have verified below points in your PR:

Add build pipeline for C#/NodeJS samples.
Add deployment pipeline for every new sample like for C#, if sample exist otherwise create it for NodeJS sample.
Deploy the sample manually, test it and add the deployed manifest in your sample folder.
Make sure that you have added the deployed manifest link in your Readme file.
Make sure to link your sample with main/root readme.
Make sure that you have linked the proper Microsoft Documentation with your sample's readme file in "Further reading" section.
Once sample is pushed, make sure to raise a doc bug on Microsoft documentation to link your sample on that page.
Make sure that you have added sample.json with proper links of .gif and metadata.
Make sure to run build pipeline every time you push the new changes in PR, including PR comments fixes and add the screenshot/link with your PR.
Verify that your readme file is visible properly in preview section.

Code related guidelines:

Remove all extra spaces and lines from your code.
Make sure that you have added proper summary for each and every methods.
Don't push credentials in your PR.
Verify alignments and correct those.
Don't put any hardcoded value and push those in PR.
Remove unwanted commented code
Use latest framework and tools for your code implementation

Build Status - All builds passed

https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/4015214232

Executed build pipeline: https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/4027088862

Executed build pipeline
status - all builds passed
https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/4030946197

Build status - All builds passed.
https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/4046829542


feat(component): new builder paging control component

@tnadkarni2 can you also update the README table to include this new component please, and you are missing adding your custom labels to the labels folder

@tnadkarni2 Have you also verified that pushing the custom code to an org as well as using the component in Experience Builder works?

@seckardt @ashmc I have create a new PR for builder component https://github.com/forcedotcom/commerce-on-lightning-components/pull/22
Tested the component in experience bundle and its working as expected


Make start and stop program optional.

These params are optional in monit config

Signed-off-by: Wojciech Dec<EMAIL_ADDRESS>

Agree that start and stop are optional, but the implementation to achieve that must focus in the defined type, and include the whole construct (start|stop program as uid, as gid,...) in the template.

Closing this in favor of a new PR.
Rel #34.


Tutorials

Notebook tutorial docs need to be written.
There should be something like the following:

quickstart/overview
components
frameworks
parameter constraints?
extensibility
FAQ?

Tutorials have been written for quickstart and extensibility, and I think components/frameworks docs should be in hmf.
Would be good to have an FAQ in the future.


Order email notification cannot be sent

Expected behavior:
Customer should get an email when an order has been placed, or order status has been updated (notify option is on), or resetting password. Restaurant should also get email notification of new orders (when the setting is on).
Actual behavior:
After updating to beta.22.1, no email can be sent to customers or restaurant.
Reproduce steps:
Place an order or update order status.
Version:
3.0.4.beta.22.1
Additional Information:
Test emails can be received.

Oh found the reason.
config/queue.php was set from sync to the database, jobs were added to the database but not executed, even though cron job was added.


readOnly lazy attributes are not respected

Testing #143572

Create a variable with only a getter, so that it contains readOnly in its presentationHint.attributes
Notice double clicking still allows setting it

Most likely this is not a specific problem of "lazy" variables...

Looks like that's correct. I fixed this a short while ago in https://github.com/microsoft/vscode/commit/989bb81 but it seems like it regressed.

It seems like js-debug might not be sending a presentationHint on the resolved lazy property. I see 'readonly' and 'lazy' there before it's resolved but not after.

Yes, a "lazy" without a setter does not react on double click, so its value cannot be set.
However, if a setter is added, it still does not react on double click.
@connor @roblourens is this a problem of js-debug or VS Code?

yep, will fix in js-debug


RunTest button does not show up for test classes in vscode

Summary
When I navigate to a test class, I am not able to see the 'RunTest' button or 'Run All Test' button .
WHEN
Steps To Reproduce:
Repository to reproduce: dreamhouse-lwc
NOTE: If your issue is not reproducable by dreamhouse-lwc, i.e. requires specific metadata or files, we require a link to a simple Salesforce project repository with a script to setup a scratch org that reproduces your problem.

This is step 1.
This is step 2. All steps should start with '1.'

Expected result
Describe what should have happened.
Actual result
Describe what actually happened.
System Information

If you are using sfdx

Run sfdx version --verbose --json

{
"cliVersion": "sfdx-cli/7.136.2",
"architecture": "darwin-x64",
"nodeVersion": "node-v16.13.2",
"pluginVersions": [
"@oclif/plugin-autocomplete 0.3.0 (core)",
"@oclif/plugin-commands 1.3.0 (core)",
"@oclif/plugin-help 3.3.1 (core)",
"@oclif/plugin-not-found 1.2.6 (core)",
"@oclif/plugin-plugins 1.10.11 (core)",
"@oclif/plugin-update 1.5.0 (core)",
"@oclif/plugin-warn-if-update-available 1.7.3 (core)",
"@oclif/plugin-which 1.0.4 (core)",
"@salesforce/sfdx-plugin-lwc-test 0.1.7 (core)",
"alias 1.2.0 (core)",
"apex 0.8.0 (core)",
"auth 1.8.1 (core)",
"config 1.3.15 (core)",
"custom-metadata 1.0.12 (core)",
"data 0.6.8 (core)",
"generator 1.2.1 (core)",
"info 1.2.0 (core)",
"limits 1.3.0 (core)",
"org 1.11.1 (core)",
"salesforce-alm 53.7.6 (core)",
"schema 1.1.0 (core)",
"sfdx-cli 7.136.2 (core)",
"source 1.8.9 (core)",
"telemetry 1.4.0 (core)",
"templates 53.3.0 (core)",
"trust 1.1.0 (core)",
"user 1.7.0 (core)"
],
"osVersion": "Darwin 21.3.0"
}
Additional information
Feel free to attach a screenshot.

Hi @mbajwa2, I think you are talking about this feature: https://developer.salesforce.com/tools/vscode/en/apex/testing#explore-your-apex-tests
This repo is for CLI issues only, I'm going to transfer this issue to the vscode-extensions repo


Add project badges for meshery-octarine

Akin to the other repos, show project badges for meshery-octarine adapter.

Closed by #13


Explicitly show that only 'yes' is accepted to create third-party dir…

…ectory, not 'y' or 'Y'.
Description
This simply gives more informative instructions in the build_visit script. Every time I previously built VisIt, I had to search through the scripts directory to see what token it would accept.
Type of change
Please select one below (Please click check boxes AFTER submitting ticket)
Bug fix/New Documentation
How Has This Been Tested?
Ran on Ubuntu 16.04.
Checklist:
This change is very low risk.

@brugger1 : How does this look to you? Is it something you guys might want?

@brugger1 : In terms of the .gitignore, diff'ing the tarballs is inefficient. This change makes my git status go down by 50%--though I can't reproduce the really long git status calls that induced me to make this change.

If you have the third party tar files that build_visit downloads in your git clone, then you probably ran build_visit from within a git clone, which isn't normally what we do. Typically build_visit downloads all the third party libraries in the current directory as well as doing a git clone in the current directory, then you wouldn't have copies of those files in your git clone.

@ brugger1 : Ok, I did a git clone first, and then ran build_visit from within the src/tools/dev/scripts directory. This is not the recommended way?

I followed the instructions for doing a source build from here and here, but it didn't work, because:
Download attempt failed: https://portal.nersc.gov/project/visit/releases/3.1.0/third_party/visit3.1.0.tar.gz
Unable to build VisIt. Can't find source code: visit3.1.0.tar.gz.
Stopping build because necessary files aren't available.

We moved the distributions to GitHub since the previous location was down more than we liked. Here is the link to the location on GitHub for 3.1.0.
https://github.com/visit-dav/visit/releases/tag/v3.1.0
The pages you mentioned need updating. Sorry about that.

@brugger1: Can this be merged?

I merged your pull request. Thanks a lot for your contribution!

@brugger1 : Hopefully the first of many! Thanks for the merge.