Poker Planning

I am done with making the Poker Planning  App. Please have a look

@saurabh2209 Thanks for PR. I will start reviewing it soon.

@saurabh2209 I was able to run your project, but was looking for a server component. How do you synchronize between players?

I am using Count.jsx component to synchronize . The Count.jsx component is rendered for each player and it will update its state saying 'player has played' once a player has either checked or fold .
Table.jsx component maintains the state of the number of players that have played . When all players have played it will reveal the choices of all players.

@saurabh2209 I understand.  I apologize for not being as clear as I should have. The point of poker is that two players are not a allowed to see the others cards.
In the real world how planning poker works because multiple people play without knowing each-others choice. The selection is only revealed when all choices are locked in. If we were to do this on the web, each player would have there own view allowing them to chose, but unable to see any other players cards until all players have chosen. I am going to close this PR given it does not synchronize across web pages, but you are free to try and PR again. So far it looks good and I am a fan of React.

I will give my best to work on it and I will message you when it is done.


porting guts from pyrocko

@emolch I assigned authorship to you for that commit. Not finished though.

@emolch I think it's reasonable do drop python2 support. What do you think?

Ready. We should have a CI first, though (https://github.com/emolch/guts/pull/7)

ping @emolch

E.g. this project would benefit:
https://git.gfz-potsdam.de/nooshiri/pyquakeml/-/issues/1


Components should be able to wrap html elements in the html! macro

Description
The html! macro should allow components to enclose other elements and have that be set as the children property in the component's props. This is allowed in JSX as seen here: https://reactjs.org/docs/composition-vs-inheritance.html
Expected Results
This should compile (children prop will be a Vec)
html! {
  <Dialog>

 ...

 ...

  </Dialog>
}

Does this issue also cover nested components? For eg.
<Dialog>
    <DatePicker></DatePicker>

...

</Dialog>

@krankur it will handle nested components as well 👍

Will there be a way to access the state of the nested components, or will we be given just plain VNodes as properties?
I'd like to create a routing solution for Yew (akin to something like React Router) and would like to express it like so:
<Router>
    <Route<MyComponent>: path="/path/to/my/component" />
</Router>

Skimming the source for vcomp, I don't see an easy way to allow access to child component's internal state from a parent (needed for getting routing info).

@hgzimmerman great point, I will play around with the code and see what will work well for children access

@hgzimmerman and @krankur would you mind playing with this wip branch: https://github.com/jstarry/yew/tree/component-children and let me know any issues you may have with it? Check out the nested_components example for usage

Just going by what I can see in the provided example right now, I won't have a chance to play with it for a few hours.
It's great that you already have support for nesting this quickly.
What I can't tell without playing with it, is if you can specify multiple children at once and hand them to the props as a Vec<Box>.
I also need to experiment and see if the aforementioned Trait can be something other than Renderable, because if that is allowed, then arbitrary access to child component state would be possible, which is what I would need to create a Router without extraneous syntax quirks for end-users. Without looking at the implementation yet, I have to imagine a whole bunch of unsafe nonsense would have to be used to cast/filter arbitrary vnode items into a user-specified Vec of trait objects.
I'll take a closer look later.

Ok, looking at the source for current approach, I can see that you collect all the children into a Vec and then create a Boxed Fn returning a VList of these children. This with the blanket impl for Renderable<T> over Fn() -> Html<T> is what allows the children to be presented as a Box<dyn Renderable<T>> in props.
Now that I have a slightly better understanding of what is going on, do you think instead of encapsulating the children in a Box<dyn Fn() -> Html<T>>, you could present the children using something like Vec<Box<dyn Any + Renderable<T>> and implement Renderable for that? That might allow people like me to dynamically downcast_ref() children to a trait object they define themselves to allow inspection of the child objects?
As a disclaimer, I've never used any of this dynamic typing stuff within Rust, so I can't comment on if it is feasible or not, just that it might be an interesting option to explore.
Thanks for your work on this thusfar!

Dumb workaround I made.
First need an intermediate trait, to help implement Clone on property types. Can't do Box<Fn() -> HTML<COMP> + Clone> since a) Clone isn't an auto trait and b) the return value of Clone for a dynamic trait would be unknown sized. This trait adds a dynamic method to clone into a box. (Could also just wrap the Fn in an Rc probably)
pub trait HtmlClosure<COMP: yew::Component>: Fn() -> Html<COMP> {
	fn boxed_clone(&self) -> Box<dyn HtmlClosure<COMP>>;
}
impl<COMP: yew::Component, T: Fn() -> Html<COMP> + Clone + 'static> HtmlClosure<COMP> for T {
	fn boxed_clone(&self) -> Box<dyn HtmlClosure<COMP>> {
		Box::new(self.clone()) as Box<dyn HtmlClosure<COMP>>
	}
}

Usage in a properties element (need to manually implement traits for stuff):
pub struct LinkProps {
	pub path: String,
	pub inner_html:  Box<dyn HtmlClosure<Link>>,
}
impl Clone for LinkProps {
	fn clone(&self) -> Self {
		Self {
			path: self.path.clone(),
			inner_html: self.inner_html.boxed_clone(),
		}
	}
}
impl PartialEq for LinkProps {
	fn eq(&self, other: &Self) -> bool {
		return self.path == other.path &&
			&*self.inner_html as *const _ == &*other.inner_html as *const _;
	}
}
impl Default for LinkProps {
	fn default() -> Self {
		Self {
			path: "".into(),
			inner_html: Box::new(|| html!{<></>}),
		}
	}
}

In render, just call the function and splice in the result. Ex: html!{{(self.props.inner_html)()}
Tag usage:
<router::Link path="/1" inner_html=Box::new(|| html!{ <>{"Link 1"}</> })/>

@ColonelThirtyTwo nice workaround! Funnily enough I finished my implementation the same time you posted yours 😉 I was running into similar issues with needing to have custom implementations for Clone and other traits but after much head scratching found a simpler approach 😅Check out https://github.com/yewstack/yew/pull/589 if you're curious!
@hgzimmerman can you take a look again at the PR? You can now access children props and can filter out children when rendering.
Relevant example code:
https://github.com/yewstack/yew/pull/589/files#diff-cc4e82debe36efce98c787323a482cadR24
https://github.com/yewstack/yew/pull/589/files#diff-bcced8558d547228999cca79a521fa7bR49

Wow, this looks great. I've been working on a macro that will create a route matcher from a provided string and then using the result of the matcher to construct props for a component, and something like this is the final piece of the puzzle to get it looking really similar to ReactRouter. I'll hopefully be using this within a couple of days (and providing more detailed feedback), and soon after that adding a core piece of Yew infrastructure to the stack.
Thanks!

Hi everybody,
I am completely new in yew / rust. How can I join this branch tests? I'm trying to implement the bootstrap library as the first project, highly inspired by reactstrap (I didn't see any solution on crates.io) - It would be really nice to have feature in container/row/column implementation. I was really worried if nesting components will be adapted (read README and docs twice).
Greets

Hey @gmorus, you can tryout the PR by changing your Cargo.toml from:
yew = "0.8"

to:
yew = { git = "https://github.com/jstarry/yew", branch = "component-children" }

@jstarry Thank you so much :)

@jstarry
I apologize in advance for dummy questions :innocent:
Is there any possibility for typing children as any proper yew/html component?
I mean sth like React/TS:
interface Props {
  children?: React.ReactNode
}

I followed your examples and wrote sth like this:
// ...
use crate::navbar::Navbar;

type Children<T> = Box<dyn Fn() -> Vec<VChild<T, Container>>>;

#[derive(Properties)]
pub struct Props {
    pub fluid: bool,
    pub class: String,
    #[props(required)]
    pub children: Children<Navbar>,
}

pub struct Container {
    props: Props,
}
// ...
impl Renderable<Container> for Container {
    fn view(&self) -> Html<Self> {
        html! {

            { for (self.props.children)().into_iter() }

        }
    }
}
// ...

and
// ...
impl Renderable<App> for App {
    fn view(&self) -> Html<Self> {
        html! {
            <>
                <Navbar value="App" />
                <Container>
                    <Navbar />
                    <Navbar />
                </Container>
            </>
        }
    }
}
// ...

but trying to figure out reusable solution.
I think that the case is typing but not so fluent to change it properly.
Thanks for any tips.

@gmorus yeah I plan to have nicer types before merging that PR, thanks for your feedback! If you have any suggestions, please share, thanks!

@jstarry my pleasure. My repository is available here. I wanna create new group and new repo for this project on github and publish as a crate on crates.io but i dont feel so confident at rust/yew yet. Any CR or tips will be appreciated.
So now I will try to implement my internal library components reusable typing and then I will merge them with yew build-in typings.

@jstarry Hi, I'm still trying to develop some components based on your component-children feature branch. As I said, I am really baby rust dev so many concepts are very new for me, but its a list of my main problems while writing code (i can't figure out how to achieve this functionality - I think its mainly caused by typing problems):

pure HTML nesting
HTML elements typings
any component nesting (i mean component/html)
optional children prop pass - after removing #[props(required)] i got following compiler errors:

   Compiling yewstrap v0.1.0 (/home/dobrykurs/Projects/yewstrap)
error[E0277]: the trait bound `dyn std::ops::Fn() -> std::vec::Vec<yew::virtual_dom::vcomp::VChild<components::row::Row, components::container::Container>>: std::default::Default` is not satisfied
  --> src/components/container.rs:10:10
   |
10 | #[derive(Properties)]
   |          ^^^^^^^^^^ the trait `std::default::Default` is not implemented for `dyn std::ops::Fn() -> std::vec::Vec<yew::virtual_dom::vcomp::VChild<components::row::Row, components::container::Container>>`
   |
   = note: required because of the requirements on the impl of `std::default::Default` for `std::boxed::Box<dyn std::ops::Fn() -> std::vec::Vec<yew::virtual_dom::vcomp::VChild<components::row::Row, components::container::Container>>>`
   = note: required by `std::default::Default::default`

error: aborting due to previous error
For more information about this error, try `rustc --explain E0277`.
error: Could not compile `yewstrap`.

To learn more, run the command again with --verbose.
error: build failed

If u know how to workaround any of these issues i will be glad to know ;)
I also created repo for this project (first dev stage functionality on develop branch): Yewstrap (example usage here
Thanks for support

@gmorus When you fail to pass a prop in a component, and it isn't annotated as required, it calls Default::default() to get a value to stick there. Under typical situations this is resolved by either implementing Default for your type (which you probably shouldn't do for a boxed Fn, or wrapping it in an Option (which I haven't tried in the context of getting component children yet, and very well may not have support).

@jstarry I'd like to report that I've ran into a problem. The following (simplified) code fails to compile:
let path = path!("/a/{}");
html!{
    <Router>
        <RouteChild path=path target=Box::new(<<AModel as Component>::Properties> as FromMatches::from_matches) />
    </Router>
}

with error:
no method named `build` found for type `yew_router::router::RouteChildPropsBuilder<yew_router::router::RouteChildPropsBuilderStep_missing_required_prop_path>

This strikes me as unusual, as I am providing a path in the RouteChild.
Relevant code is available here:
https://github.com/hgzimmerman/YewRouter/blob/nested_router_stuck/YewRouter/examples/routing_component/src/main.rs#L75
https://github.com/hgzimmerman/YewRouter/blob/nested_router_stuck/YewRouter/src/component_router/router.rs#L202

Unrelated, but I couldn't seem to get this version of Yew's html!{} macro to handle components with type parameters (eg <Router<()>>). I don't recall this being a problem in the past, but I've had to remove type parameters from my router to avoid expected valid html element errors.

@hgzimmerman Thank you for your reply. Unfortunately, most of the concepts you mentioned are so new to me that trying to improve them in the context of your frameworks is like a wandering in the fog. Of course, I'll look at your tips, but I'm afraid I'm not yet qualified  :cry:
For now, I can only improve my skills and wait for some new examples :rofl:

@gmorus Sorry for any ambiguity. What I meant to communicate is that the following might work:
//! container.rs
type Children<T> = Box<dyn Fn() -> Vec<VChild<T, Container>>>;

#[derive(Properties)]
pub struct Props {
    pub fluid: bool,
    pub class: String,
    #[props(required)]
    pub children: Option<Children<Row>>, // An Option<> was added here
}

Because this feature is still in development, and I haven't taken the time to look at jstarry's macro magic, I don't know if what I suggest will work, but is probably your best bet for now until further developments.

@hgzimmerman I tried this solution but still cannot figure out how to make it working. I changed Props typing like in an example above but that causes following error:
   Compiling yewstrap v0.1.0 (/home/dobrykurs/Projects/yewstrap)
error[E0618]: expected function, found enum variant `self.props.children`
  --> src/components/container.rs:62:23
   |
62 |                 { for (self.props.children)().into_iter() }
   |                       ^^^^^^^^^^^^^^^^^^^^^--
   |                       |
   |                       call expression requires function
help: `self.props.children` is a unit variant, you need to write it without the parenthesis
   |
62 |                 { for self.props.children.into_iter() }
   |                       ^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error
For more information about this error, try `rustc --explain E0618`.
error: Could not compile `yewstrap`.

To learn more, run the command again with --verbose.
error: build failed

I tried to follow rust docs examples and rewrote returned value to:
html! {

        // { for (self.props.children)().into_iter() }
        {
            match self.props.children {
                Some(ref children) => for (children)().into_iter() ,
                None => {},
            }
        }

}

but got new ones:
   Compiling yewstrap v0.1.0 (/home/dobrykurs/Projects/yewstrap)
error: missing `in` in `for` loop
  --> src/components/container.rs:58:61
   |
58 |                         Some(ref children) => for (children)().into_iter() ,
   |                                                             ^ help: try adding `in` here

error: expected one of `.`, `?`, `{`, or an operator, found `,`
  --> src/components/container.rs:58:76
   |
58 |                         Some(ref children) => for (children)().into_iter() ,
   |                                            --                              ^ expected one of `.`, `?`, `{`, or an operator here
   |                                            |
   |                                            while parsing the `match` arm starting here

warning: unreachable expression
  --> src/components/container.rs:53:9
   |
53 | /         html! {
54 | |

55 | |                 // { for (self.props.children)().into_iter() }
56 | |                 {
...  |
62 | |

63 | |         }
   | |_________^
   |
   = note: #[warn(unreachable_code)] on by default
   = note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

error[E0277]: `()` doesn't implement `std::fmt::Display`
  --> src/components/container.rs:53:9
   |
53 | /         html! {
54 | |

55 | |                 // { for (self.props.children)().into_iter() }
56 | |                 {
...  |
62 | |

63 | |         }
   | |_________^ `()` cannot be formatted with the default formatter
   |
   = help: the trait `std::fmt::Display` is not implemented for `()`
   = note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
   = note: required because of the requirements on the impl of `std::string::ToString` for `()`
   = note: required because of the requirements on the impl of `std::convert::From<()>` for `yew::virtual_dom::vnode::VNode<components::container::Container>`
   = note: required by `std::convert::From::from`
   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

error: aborting due to 3 previous errors
For more information about this error, try `rustc --explain E0277`.
error: Could not compile `yewstrap`.

To learn more, run the command again with --verbose.
error: build failed

Lets say optional children props is not my highest priority now and it exceeds my knowledge so Ill try to implement some more basic stuff now and improve my skills meanwhile ;) Thank you for tips.

@gmorus children can now be optional 👍 Run cargo update -p yew to get the latest changes. Also take a look at this commit to see how the example changed: https://github.com/yewstack/yew/pull/589/commits/a6c88a139e99d949816ae75372920054fe02e304#diff-11b3515847558c7863f5aff2c0a9fc05

@hgzimmerman working on a fix for generic components, sorry about that!

Thanks a ton! The turnaround time on that was quick.
While what I had still confused the html! macro, removing the target prop allowed it to parse correctly again. Maybe the multiple casting to traits I had created a string of tokens the macro couldn't adequately deal with. Its such a niche problem that it probably isn't worth dealing with right now. It doesn't bother me at all because I was already planing on moving the creation of the "target" boxed Fn into the PathMatcher returned by the route!() macro instead of passing it directly via props.
Maybe keep in the absolute back of your mind that something (probably the < characters ) present in:
target=Box::new(<<AModel as Component>::Properties> as FromMatches::from_matches)

can cause the parser to fail to parse any props and report a misleading error message.

@jstarry I did the first tests of the new component-children feature version. Optional children props works fine, required children pros still working as expected. Nesting components and plain HTML works properly. I really appreciate your work, good job!
I was able to achieve following <App /> shape:
impl Renderable<App> for App {
    fn view(&self) -> Html<Self> {
        html! {

                <Navbar title="Yewstrap app" />
                <Container fluid=true>
                    <Row class="xxx">
                    </Row>
                </Container>
                <Container fluid=false>
                    <Row class="xxx">
                    </Row>
                    <Row class="vvv">
                        <Col class="ttt"/>
                    </Row>
                </Container>
                <Container class="container-main">
                    <Row>
                        <Col>

{"Test header"}

{"Second header test"}

                                {"Test paragraph"}
                                <Container />

                        </Col>
                    </Row>
                </Container>

        }
    }
}

However I wonder about pure HTML children prop typing. Now it looks like below:
use yew::html::Children;

// ...

pub struct Col {
    props: Props,
}

#[derive(Properties)]
pub struct Props {
    pub class: String,
    pub children: Children<Col>,
}

pub enum Msg {}

impl Component for Col {
    type Message = Msg;
    type Properties = Props;

    // ...
}

impl Renderable<Col> for Col {
    fn view(&self) -> Html<Self> {
        // ...

        html! {

            { for (*self.props.children)().into_iter() }

        }
    }
}

...what means that we have to pass our component as a Children<> argument. What about when we want children to be the same type as the parent? I mean that it doesn't allow us to force on children components to be the same type as parent component. e.g.:
impl Renderable<App> for App {
    fn view(&self) -> Html<Self> {
        html! {
            <Col>
                <Col></Col>
                // Every other component or pure HTML can be placed here

                <Row></Row>
            </Col>
        }
    }
}

Other nice-to-have feature would be possibility of declaring multiple allowed children component types and mixing it with HTML elements types.
Thanks again for your work!

@hgzimmerman I pushed a new change on that branch which fixes generics parsing, I'll look into that parser bug too, thanks!
@gmorus I pushed a new syntax for working with children, can you try it out and let me know what you think? https://github.com/yewstack/yew/pull/589/commits/da506e2343cac6a0105bb0c817a33e36a617958f#diff-11b3515847558c7863f5aff2c0a9fc05

I realised the Children<T> type will be most useful in most cases in my library, and it works fine. I also tried new syntax for ChildrenWithProps<C,P> children prop type and found some strange behaviour (I don't know what expected functionality exactly is) - while trying:
// ...
impl Renderable<Row> for Row {
    fn view(&self) -> Html<Self> {
        let classes = merge_classes("row", &self.props.class);

        html! {

            { for self.props.children.iter().map(|mut c| {
                // Every statement below adds new class after extra space instead of overwriting
                // c.props.class = String::from("col-12");
                // c.props.class = format!("{}-12", c.props.class);
                // c.props.class seems to be empty
                c.props.class = format!{"xxx-{}-xxx", c.props.class};
                c
            }) }

        }
    }
}

Instead of overwriting I got the following:

or

and...

Unfortunately your example doesn't show this difference ;) I didn't check the behavior with other props types than String. Despite this, I really love React-like elements mapping. It would be also so much useful in future to implement similar solution with Children<T> children prop type.

I realised the Children<T> type will be most useful in most cases in my library, and it works fine. I also tried new syntax for ChildrenWithProps<C,P> - also looks fine. I really love React-like elements mapping. It would be also so much useful in future to implement similar solution with Children<T> children prop type.

@jstarry I also suggest add ChildrenWithProps<C,P> to yew::prelude; - it may be useful there.

I'd just like to let you know that thanks to this branch, I've been able to get a working prototype of the router completed. Its not entirely done, as there are likely syntax changes coming to the route! macro I've made, error reporting needs to be improved, and possibly some orphaning bugs in yew to work out, but the external interface is more or less stable.
Here's a sample of what it looks like for the moment:
html!{
    <Router>
        <Route path=route!("/a/{}" => AModel) />
        <Route path=route!("/c" => CModel) />
        <Route path=route!("/b/{sub_path}" => BModel) />
    </Router>
}

Thanks a bunch for enabling this @jstarry

@hgzimmerman woot! That's awesome! Can't wait to try this out. Will it be possible to pass in props to the components in the routes? Something like this?
html!{
    <Router>
        <Route path="/a/{}" >
            <AModel prop=value />
        </Route>
    </Router>
}

I hadn't planned on supporting something like that. I rely on a pair of macros to create a path matcher that can capture sections of a path and turn them into props for the target component. It relies on the consumer of the library to make sure that the names in the capture groups match those of the props's fields for the component that will be rendered, and that the field's types can be converted to from &str. There sadly isn't a way to validate that at compile-time (at least using my current approach), but it is possible to run a derived verification function that will panic immediately at runtime, which is better than nothing.
The problem I see with supporting having arbitrary children inside of <Route>...</Route is that there isn't a way to pass the contents of the matched section of the url to the component.
I would like to support nested route targets, but I think doing so requires giving up the direct capturing of prop values from the URL.
I'm open to feedback and discussion, and would appreciate your input, but I don't think this thread is the most appropriate place for it. I've opened a issue in case you want to continue discussion there.


Chore/updates

Tested locally, site looks good.
This should help a little bit with maintainability.
Next step would be to ditch the toJSON call from raml and use their actual calls which should make things 99% less annoying.

@SimonSchick,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@SimonSchick Noticed you're not on OOO From tommorrow(Tuesday). When/if you get this building we can merge it.
I'd suggest rebasing a bit as i've made some changes to the developer site as indicated by the conflicts

Closing due to lack of interest @SimonSchick If you're interested please re-open.


Docker for Win acme.json permissions problem.

Traefik v1.3.1
Docker CE for Windows: 17.06.0-ce-win18 (12627)
I have the /acme folder routed to a host volume which contains the file acme.json.  With the Traefik 1.3.1 update, I noticed that Traefik gets stuck in an infinite loop complaining that the "permissions 755 for /etc/traefik/acme/acme.json are too open, please use 600".  The only solution I've found is to remove acme.json and let Traefik re-negotiate the certs.  Unfortunately, if I need to restart the container, I have to remove acme.json again or I'm stuck with the same issue again!
My guess is that the issue lies with the Windows volume mapped to Docker but I was wondering what the recommended workaround would even be for this?

Thanks for your interest in Traefik !
Every question in the issues means features less 😉.
The issue tracker is for reporting bugs and feature requests only.
For end-user related support questions, refer to one of the following:

Stack Overflow using the "traefik" tag
the Traefik community Slack channel

This Github issue comes up on Google before the currently-unanswered StackOverflow version. I'll answer both, since this may count as a bug. Similar questions are asked in #1459.
@JaronrH

Can I change permissions on shared volumes for container-specific deployment requirements?
No, at this point, Docker for Windows does not enable you to control (chmod) the Unix-style permissions on shared volumes for deployed containers, but rather sets permissions to a default value of 0755 (read, write, execute permissions for user, read and execute for group) which is not configurable.

Traefik is not compatible with regular Windows due to the POSIX permissions check in #1009 (A bug? A feature?). It may work in the Windows Subsystem for Linux since that has a Unix-style permission system.
An additional cause/solution for the same error message: A Docker volume mount will create a 755 directory if the file does not exist. Create the empty file first.

Stumbled across this issue when trying to get traefik running on Docker for Windows... ended up getting it working by adding a few lines to a dockerfile to create the acme.json and set permissions. I then built the image and despite throwing the "Docker image from Windows against a non-Windows Docker host security warning" when I checked permissions on the acme.json file it worked!

I setup a repo up and have it auto building to the dockerhub here for further testing.
https://hub.docker.com/r/guerillamos/traefik/
Once I got that built I switched the image out in my docker-compose file and my DNS challenge to Cloudflare worked like a charm according to the logs.
I hope this helps someone!


bugfix(rename): Update network on rename container

Fixes #15727

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "bugfix/container-rename-network" git@github.com:majidgolshadi/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

this is related to #15727
ping @mavenugo

@majidgolshadi thanks for the patch. but i dont think this is going to work as intended.
this fix must address both the single-host --link functionality and the upcoming multi-host networking.
long story short, endpoint names are by default associated with container names and hence any rename must also be handled at the endpoint level. That means, we have to retain the endpoint ip-address, mac-address and just update the DNS records of other containers in that network.
the experimental network UX is undergoing some changes and this issue will be address as part of that.

I'll close this per @mavenugo comment above https://github.com/docker/docker/pull/16438#issuecomment-141793540


implement delete run mutations and delete button on dashboard

Implement graphql mutations for

deleteRun
deleteRuns
deleteRunsInDateRange

Implement delete button on dashboard

invoke deleteRun mutation on delete button click
clear queries from cache on delete success

@agoldis
I have finished implementing the mutations and also added a delete button on the UI.
I was not sure where to place the deleteRun.graphql file and hence I have created it along side other .graphql files.
Please review.

Will review later today

Nice job @xtroncode!
I have added confirmation dialog for the deletion on top of your changes, in addition to some configuration updates.
While testing it I have discovered that better approach would be just marking runs as deleted, without actually deleting them.
That would prevent the whole bunch of issues - e.g. deleting an ongoing run causes exceptions on director.
I won't request the change now, but if you feel like refactoring the implementation, please do.

@agoldis Thanks for the review. I had thought about having a confirmation dialog, thanks for implementing it.
I agree with you that it will cause an issue, when deleting runs that are in progess.
Is there a flag to determine whether a run is in progress or completed ? We can hide the button based on that.
If not, then the approach you have suggested works fine, we can then clean data periodically.
Thanks.

There's no explicit running / not running state for a run - there's a list of specs, some of the might be claimed and some not.
However, a run with non-claimed spec might just a stuck run i.e. it is not necessarily still running.
The original cypress dashboard implements "timeout" for each run - if not specs were claimed within specific time window since the last claim, the run is considered "done".
We can apply similar logic, but I am not sure it worth the effort.


improvement/addFormatting: add formatting via prettier

Adds formatting-capabilities via prettier.
To format:

Run yarn format  / npm run format after installing packages
Open repository in vscode and accept the poputs

I noticed that the obsidian-sample-plugin doesn't use a .prettierrc, so I think we can just use it like this for now and add a .prettierrc whenever we notice formatting that we aren't happy with.
I'll also happily add ## Development section to the README if you find that helpful.

Prettier works perfectly fine with me, their default settings are pretty good after all.
Also, thank you for pushing the .vscode directory and settings. I would say we cover a good majority of devs at the moment if we also provide the default settings.


Add more tests for plots and window

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+3.0%) to 86.552%

Totals

Change from base Build<PHONE_NUMBER>:
3.0%

Covered Lines:
1403

Relevant Lines:
1621

💛  - Coveralls


oneOf discriminator not required in MergePatch

MergePatch has discriminators as not required. they need to be required.

We'll roll this into #18.


Forecast Code

Current Behavior:
No five day forecast
Expected Behavior:
Create code to pull data from openweathermap to show next 5 days weather forecast, including similar information that is shown for current weather, perhaps not humidity but something else

done!


Can't show the Client real ip

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?

Yes

Are you sure you're not using someone else's docker image?

Yes

Have you searched for similar issues (both open and closed)?

Yes

Describe the bug
No matter what I did can't see the client real IP, I can see only the docker IP.
LOGS:
web-address is the webpage I'm accessing
[31/Jan/2023:08:51:36 +0000] - 200 200 - GET http web-address "/openapi.json" [Client <IP_ADDRESS>] [Length 1384] [Gzip -] [Sent-to <IP_ADDRESS>] "Mozilla/5.0 (Linux; Android 12; SM-S901B) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Mobile Safari/537.36" "http://web-address/docs"
[31/Jan/2023:08:51:39 +0000] - 200 200 - GET http web-address "/X-Real-IP" [Client <IP_ADDRESS>] [Length 27] [Gzip -] [Sent-to <IP_ADDRESS>] "Mozilla/5.0 (Linux; Android 12; SM-S901B) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Mobile Safari/537.36" "http://web-address/docs"
[31/Jan/2023:08:51:46 +0000] - 200 200 - GET http web-address "/X-Forwarded-For" [Client <IP_ADDRESS>] [Length 27] [Gzip -] [Sent-to <IP_ADDRESS>] "Mozilla/5.0 (Linux; Android 12; SM-S901B) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Mobile Safari/537.36" "http://web-address/docs"

Nginx Proxy Manager Version
jc21/nginx-proxy-manager:latest
version: '3'
services:
  app:
    image: 'jc21/nginx-proxy-manager:latest'
    restart: unless-stopped
    ports:
      - '80:80'
      - '443:443'
      - '81:81'
    volumes:
      - ./data:/data
      - ./letsencrypt:/etc/letsencrypt

Operating System
Docker Desktop
Additional context
FastApi
from typing import Union
from fastapi import FastAPI, Header, Request

app = FastAPI()

@app.get("/X-Forwarded-For")
async def root(request: Request):
    my_header = request.headers.get('X-Forwarded-For')
    return {"message": my_header}

@app.get("/X-Real-IP")
async def root(request: Request):
    my_header = request.headers.get('X-Real-IP')
    return {"message": my_header}

Hi. Had the same issue and just fin out next solution.
Try to use
    ports:
      - target: 443
        published: 4443 # Outside port
        mode: host
        protocol: tcp
      - target: 80
        published: 480 # Outside port
        mode: host
        protocol: tcp
      - target: 81
        published: 481 # Outside port
        mode: host
        protocol: tcp

For me it works.

Hi navhawk80, this doesn't fix the problem.
After a few hours of tests, I finally find the problem. The problem is the Windows 🥇, it's not only nginx, traefik has the same issue ... When I switch to my ubuntu server everything was working well.

Hi,
Please disregard info I mentioned above.
Real fix was the script from here https://gist.github.com/pedrolamas/db809a2b9112166da4a2dbf8e3a72ae9
I put it into startup on my synology and now in LOGs external IPs are beaing reconnized correctly.


Minimal working example of safetensors support for hezar

Pull Request
Description
The save and load methods for the hezar.models.Model class have been altered to accommodate for safetensors support.
Changes

Loading safetensors exposed through the keyword argument load_safetensors under Model.load().
Saving safetensors exposed through the keyword argument safe_serialization under Model.save().
SAFETENSORS added to the enumlist of Backends in constants.py.
A minimal working example unittest is available at test_safetensors.py. This serves just to demonstrate the changes and is by no means a comprehensive test ready for production.

Related Issues
Resolves #153
Additional Comments
Please keep in mind that this is meant to serve as a draft PR and is by no means production-ready. The changes made to the code base are very crude and the aim was only to show how it may be possible to incorporate safetensors support in hezar. After the architectural details and design decisions regarding how and where this change should be introduced within the codebase are approved, I can happily edit this PR (or submit a new one) with a cleaner code that adheres to this library's standards.
Notes

Model.push_to_hub() also requires changes but for the purposes of this quick prototype it was left unchanged for the time being.

@Adversarian Thanks Arian jan, I tested your code and it works perfectly. As a next step, I will go through the code and apply necessary changes if needed. In the meanwhile, can you please test this on other models too? (Note that you can create models from configs on the hub instead of downloading the weights from there OR you can use google colab which downloads models in seconds).
Overall, I think your changes adheres perfectly with the standards of this library. The most important thing here is to design and implement a flawless migration pipeline.
As a bonus, this change will also enable model downloads count on the Hub! :))) (see #56)

@arxyzan My pleasure! Sure, I can try it on other models, I'll add them to test_safetensors.py and update the PR. I'm also psyched about seeing counters go up on HF now! Let me know if there's anything else I can do to help with this.

@arxyzan I added a more comprehensive test suite for safetensors and tried to test it out on Colab since I don't have access to premium internet at the moment. It looks like we're failing on mask-filling and text-generation tasks on RoBERTa and GPT-2 respectively while the remaining two tasks are passing with their respective models.
I'll try to investigate myself soon but in the meantime, here's the notebook with the tests performed if you'd like to take a look yourself.

@Adversarian Thanks Arian, I think that's exactly the case that failed for me too. Back then I didn't test other models since I thought my conversion code was buggy.
Can you please open an issue on this if you can?

@arxyzan No problem at all Aryan jan. I don't think this is an issue regarding safetensors or huggingface unless you meant for me to open an issue on this here, on hezar. I've been swamped again so I haven't had time to investigate this fully but looking at HF's save_pretrained method, it looks like saving a model in safetensors format shouldn't be as trivial as I have made it out to be in my draft PR. I may have skipped a ton of preprocessing which we would have to add back into the save method.
I will try to take a look at this again as soon as I'm able to but is there really no way to subclass HF's models for hezar.models.Model so that we can just directly use save_pretrained? Is there something that's holding you back from doing this? I'm only asking because that seems to be the cleanest solution if at all possible and the burden of any further development on this specific matter would be offloaded to HF with their multitude of smart (and paid!) developers.
Again, sorry for the late response and looking forward to hearing your thoughts on the subject.

@arxyzan I understand, thanks for your explanation. We can make it happen. As I mentioned before I'm a tiny bit swamped at the moment but I'll get back on this first thing after.


[Feature Request] Option to edit Keyboard Shortcuts

As of now, the application uses the right and left arrow key to move a frame. Unfortunately these keys are used by most video-players to skip around in the video. So it would be nice to be able to change the keyboard shortcuts.
I would also suggest adding an option to define a second key like CTRL, to be able to keep using the arrow keys.

It would be convenient to not skip around the video as I'm trying to move a frame.

https://github.com/code4charity/YouTube-Extension/issues/516

welcome @mapelpapel  & Jared
https://github.com/code4charity/YouTube-Extension/issues/516

1.7.0 - soon

also when i keep pressing on arrow keys its like slowed down and adding 1 frame that isn't there like its on 60fps
would be cool if u add 60fps and 30fps settings and option for adding other keys instead of arrows


dragging a large directory ignores validation.itemLimit

Type of issue

[*] Bug report

If you drag a large directory into FIneUploader (say, the fine-uploader root, after installing node_modules) Fine Uploader adds them all to qq.UploadData as "submitting", even if the number of files is larger than itemLimit

I've monkey-patched this in my application code:
    const _addFiles = this.uploader.addFiles.bind(this.uploader);
        this.uploader.addFiles = function(data, params, endpoint) {
            let uploads = self.uploader.getUploads(),
                remove = self.itemLimit - (uploads.length + data.length);
            if (remove) {
                data = data.slice(0, remove);
            }
            return _addFiles(data, params, endpoint);
        };

Have you looked into upstreaming this change into FineUploader?

How in depth would an appropriate pull request to fix this issue be?
For writing accompanying unit tests, test/unit/uploader.basic.api.js seems to use the Mocha unit test framework to ensure api functions set values correctly. It looks like tests have been implemented to either mock or use actual file uploads. What would be the preferred way to test limiting dropped files with these tools?


Angular Material Chips appearing as rectangle instead of being Rounded  inside a sidenav

Reproduction
https://stackblitz.com/edit/angular-i1v6xt?file=app/sidenav-responsive-example.html
Steps to reproduce:

Go to above Stackblitz
Open sidenav

Stackover flow --> https://stackoverflow.com/q/56707626/5724889
Expected Behavior
Chip should be Round as it is everywhere
Actual Behavior
Chip is rectangular
Environment

Angular: 8.0.1
CDK/Material: 8.0.1
Browser(s): Chrome Version 74.0.3729.169 (Official Build) (64-bit)
Operating System (e.g. Windows, macOS, Ubuntu):  Windows

It would be helpful if it is mentioned in  documentation that
<mat-chip> should always be in a <mat-chip-list>

@dota2Pro Also see https://github.com/angular/components/issues/9964


[AutoPR storage/resource-manager] [Storage] Set the SignedResource as optional in ListServiceSAS

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3463

(message created by the CI based on PR content)

Codecov Report

Merging #2967 into restapi_auto_storage/resource-manager will not change coverage.
The diff coverage is 100%.

@@                          Coverage Diff                           @@
##           restapi_auto_storage/resource-manager    #2967   +/-   ##
======================================================================
  Coverage                                  56.97%   56.97%
======================================================================
  Files                                       7805     7805
  Lines                                     160285   160285
======================================================================
  Hits                                       91325    91325
  Misses                                     68960    68960

Impacted Files
Coverage Δ

...orage/v2018_02_01/models/service_sas_parameters.py
20.83% <ø> (ø)
:arrow_up:

...ure/mgmt/storage/v2018_02_01/models/restriction.py
55.55% <ø> (ø)
:arrow_up:

...mgmt/storage/v2018_02_01/models/restriction_py3.py
55.55% <ø> (ø)
:arrow_up:

...e/v2018_02_01/models/service_sas_parameters_py3.py
20.83% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0684ed4...35956ea. Read the comment docs.

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/3052


Switch to http/proto and add auth stuff

This is a combination of two upstream PRs:

https://github.com/prometheus/prometheus/pull/1987 (switch away from grpc)
https://github.com/prometheus/prometheus/pull/1957 (add auth stuff)

I'd like to review/merge them into tomwilkie/prometheus:master so we can deploy them to our cluster.

:+1:

This is now running in dev.

This has been superseded by the 1934-basic-auth branch.


Details of a user is not properly displayed in its respective section

Describe the bug
In organizations section @ is coming and it is displaying organizations in the different section same with the twitter handle instead if user is not have twitter handle and organizations that section should not be displayed
To Reproduce
Steps to reproduce the behavior:

Go to 'DisplayCard.js on line 86 instead of twitter username organizations should display'

Expected behavior
Details should display in its respective section
Screenshots

@garimasingh128 @mrinal41298 I wanted to work on this issue.

I would like to work on this issue

@ankitaggarwal23 i have already make the pr regarding this issue

@ankitaggarwal23 i have already make the pr regarding this issue

okay


Enable SSL by default for TCP connections

tls and tlsverify should be on by default, with auto-generated keys if none provided, for TCP connections, and only allow non-tls with --insecure-but-i-know-what-im-doing

i think this has been handled right @cpuguy83

@jfrazelle Not really.

If this has not already been address, I'd like to take a shot at this.

Is this still open?

Still open.

#dibs

I don't think we should do this. People still need to distribute and manage whatever certificate we generate. There is no difference with them generating the certificates manually. I'm going to close it.


Migrated to Yarn 3

Signed-off-by: Andre Wanlin<EMAIL_ADDRESS>This was one of the items on my todo list. Would be good for someone else to take a look at this. I'm mostly worried about the Dockerfile as I have no way to test this myself.

Closing as there's been lot of changes and I think I have this working from a new branch with latest


[Things] Menu Bar Settings: Hide Text, Show Count, Monochrome Icon

Extension
https://www.raycast.com/loris/things
Description
I'd like to suggest adding some optional settings to enhance the Menu Bar entry offered by the extension. These settings would offer users more flexibility and customization:

Hide Text: Allow to hide the Today list's topmost to-do title being shown in the Menu Bar to avoid cluttering it.
Show Count: Display a number of remaining to-dos.
Monochrome Icon: Uses a monochrome Things icon to blend in better with other native Menu Bar icons.

Thanks a bunch 👍
Who will benefit from this feature?
Anybody already suffering from the scarce space in the Menu Bar.
Anything else?
No response

We could maybe reopen this issue ?


Create a model for issues' version history

As a data modeler, I would like a model of version history where each row describes when a version field was added to or updated for an issue, so that I could match match issues to version history.
At a minimum, a lookup table of issue id, version id, and updated_at fields would be super helpful.  At a maximum, these three fields plus the remaining fields on the version table could be added.

Are you a Fivetran customer?
We are a very happy Fivetran customer 😁
Is your feature request related to a problem? Please describe.
This feature request would help create version history of issues.
Please indicate the level of urgency and business impact of this request
This feature request would be a nice-to-have for us.
Are you interested in contributing to this package?

[X] No, I'd prefer if someone else did this.  I don't have the time and/or don't know how to incorporate the changes necessary.

hey @curious-bryan -- just realized the "minimum" solution here already somewhat exists. the intermediate model int_jira__issue_multiselect_history contains the issue_id, field_id (which is the version_id), and updated_at. you could limit this to just version history with the following query
 select *
 from {{ ref('int_jira__issue_multiselect_history') }}
 where field_id = 'versions'
        or field_id = 'fixVersions'

which you could then join with the version table to get those extra columns, similar to how we do here
is this sufficient/does this work for you? i will note that int_jira__issue_multiselect_history is materialized as ephemeral by default, so you may want to materialize that (or perhaps just the above query ^) as a table or view

Yep.  You're right @fivetran-jamie!

great! so i'll close this since that works for ya 😄


[question] WithStorage && ConnectionValidator

MQTTnet.AspNetCore 3.0.5
I am trying to use MQTT Net in NetCore 2.2,  and I am having some problems while I am learning.
WithStorage:
public Task SaveRetainedMessagesAsync(IList<MqttApplicationMessage> messages)
        {
            //var last = messages.LastOrDefault();
            //Logger.Info($"Last: {last.Topic } >> { Encoding.Default.GetString(last.Payload) }");
            foreach (var item in messages)
            {
                Logger.Info($"{item.Topic } >> { Encoding.Default.GetString(item.Payload) }");
            }
            return Task.CompletedTask;
        }

When publish the retained message from client. It will get all the messages, including the history of the message. How can I get the latest news from the current client?
ConnectionValidator:
How to know client disconnection?

I assume that this is cleared by the wiki? https://github.com/chkr1011/MQTTnet/wiki


How to know the original resolution of  the video?

I am trying to transcode the video in 144p, 240p, 360p, 480p, 720p resolutions.
Now if the original video is in 144p, then it makes no sense to encode the video in higher resolutions.
So is there any way to know in which resolution the original video is in?

@pks9862728888 check https://github.com/aminyazdanpanah/python-ffmpeg-video-streaming#metadata

Using this I can get the bit-rate. But I don't know how to know in which resolution the video is in?
The thing which I want to achieve is: suppose the original video quality is bad, then re-encoding it in 1080p format won't  do any significant improvement. So for that I want to encode it in lower resolution like 144p, 240p and 360p. But for that I need to know the base resolution of the video.

check te example link on that Readme. There you have one that get dimensions:  print("dimensions: {}x{}".format(...

Try this:
from ffmpeg_streaming import FFProbe

ffprobe = FFProbe('/path/to/video')
print(f"Dimension: {ffprobe.video_size}")

@aminyazdanpanah how to get the size if the file is in cloud storage (eg: s3)


Default Symbol does not work

Setting the Default Symbol for a category to Device:R does not work for me. This was probably broken by #39.

@30350n I created a fix for that.
Please update to version 1.3.2 and let me know if that resolves your issue.

Will check once I'm done investigating the cause for the other issue I openend :)

It does if you run an earlier version but the latest should definitely support it.
It is working on my end

Yep, works, thanks for the quick fix! :smiley:


Release v2.13.3 introduced strange image/render batching issues

The latest release improved performance with https://github.com/photonstorm/phaser-ce/pull/641 but also introduced strange image batching behavior, see screenshot below.

Phaser version(s): 2.13.3

Live example:

(https://tarutarolegends.com/ but I had to roll it back to version 2.13.2)

What steps produce the bug: use game.renderer.setTexturePriority (+ picture atlas) with newest release gives strange batching behaviors

What should happen: pictures should not get mangled up

What happens instead: mangling of pictures

Please, have a look, I am also gonna investigate further asap. THX

I kept analyzing it and I assume that the whole issue is connected with the pixi warning, expl.: "pixi.js:3804 setTexturePriority: Image "demo(nov2018)_tileset_levelmap(expanded4)" was given textureIndex=0 because there is no available texture space (-3072)."
but its funny that this did not have those strange effects before. Now some textures get batched wrongly and mixed up and some texture just don't even bother to appear.

@photonstorm , do you need anything else?


Clear out messy content

Empty paragraphs and classes on paragraphs are being sent through from the API.
These need to be removed.

hey @jamesgorrie has this one been resolved? ok to close?

💥

We can raise specific issues when they arise.


Fix for inline link-to with dynamic text param

Adds fix and failing test for https://github.com/rajasegar/ember-angle-brackets-codemod/issues/67

Fix here: https://github.com/rajasegar/ember-angle-brackets-codemod/pull/69

snap @GavinJoyce. I'd also just pushed a fix 😄

Nice one @patocallaghan, I missed that. Let's use your PR

Perhaps update the title before we merge?

Updated


Fix System.IO.IOException: 'Unable to remove the file to be replaced.…

… ' #10
Based on: https://github.com/gitextensions/gitextensions/pull/4252/commits/00416bc92f642c4aff81b6cbcc5a1df38bf4990a and https://stackoverflow.com/questions/46824487/unable-to-remove-the-file-to-be-replaced-error-during-file-replace-if-filesys

merged with 62dad83370d6922bdaa5349f7248a66edd6657d0

In the end, this fix wasn't good enough, because if you kill the app in the middle of the Delete/Move, you end up with a session file named *.tmp, and not found on the next session run.
I now remember I experienced that issue before and that's why I used File.Replace.
I changed it to Copy(overwrite)/Delete, but that isn't satisfactory.


App restarts after manually removing corrupted preset

The app restarts itself after manually removing a corrupted preset.

This problem does not persist if the preset is not corrupted.

Hmm this needs fix

@jaxinator555 Please specify how to replicate this error. Tried to do so, it didn't crash.

The problem does not persist. It is gone in the latest alpha I think.


Support for Non-English Characters in Option Descriptions within command.go

I'm working with the serpent library, particularly focusing on handling command-line options as defined within the command.go file of your project. I've encountered an issue that arises from the enforcement of rules concerning the format of option descriptions:
if opt.Description != "" {
    // Enforce that description uses sentence form.
    if unicode.IsLower(rune(opt.Description[0])) {
        merr = errors.Join(merr, xerrors.Errorf("option %q description should start with a capital letter", opt.Name))
    }
    if !strings.HasSuffix(opt.Description, ".") {
        merr = errors.Join(merr, xerrors.Errorf("option %q description should end with a period", opt.Name))
    }
}
Located in command.go, this code enforces that each option description starts with a capital letter and ends with a period. This rule aligns well with descriptions written in English. However, it becomes problematic for descriptions in non-English languages, especially for those that utilize non-Latin scripts (such as Chinese, Japanese, Arabic, etc.).

The validation errors occur because the current implementation assumes the use of English sentence structure and punctuation, which does not universally apply to all languages.

Hey, this is a valid problem and a vestige of the library's past presence within coder/coder. We should move this linting logic over there and be unopinionated here.


O11Y-2150 : Opentelemetry-dart lacks assets helpful to contributors

Problem
Repo lacks assets helpful to contributors
This repo lacks templates for new issues and a codeowners file

Security Insights
No security relevant content was detected by automated scans.
Action Items

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Public API Changes
No changes to the public API found for commit 4ec9d9a735babb3196495fd634add35e66052309
Showing results for 4ec9d9a735babb3196495fd634add35e66052309

Powered by semver-audit-service. Please report any problems by filing an issue.
Reported by the dart semver audit client 2.2.2
Browse public API.

QA+1

@Workiva/release-management-p


feat: add support for argument aliases in markdown output

Currently it adds the alias after the current options before the help doc. Open to other suggestions.

In favor of https://github.com/AhaLabs/clap-markdown/pull/1, which is dependent on the clippy PR.


Fix and document BIO_FLAGS_NONCLEAR_RST behavior on memory BIO

The BIO_FLAGS_NONCLEAR_RST flag behavior was not properly documented
and it also caused the length to be incorrectly set after the reset
operation.
Checklist

[x] documentation is added or updated
[x] tests are added or updated

@openssl/omc Please review

[master 8b7b32921] Fix and document BIO_FLAGS_NONCLEAR_RST behavior on memory BIO
[OpenSSL_1_1_1-stable c6991655c4] Fix and document BIO_FLAGS_NONCLEAR_RST behavior on memory BIO


UI improvement in About us Section

The UI of about Us Page is very basic ,it should be appealing and attractive making users to read and know about the website.
I will work on this issue ,Kindly assign this issue to me under hactoberfest, gssoc-ext and relevant tags.

@Bhum-ika it is done checkout local code


[Event Request] Report 1095 "Update Job Item Cost" - OnBeforePostTotalCostAdjustment

Hi, would it be possible to modify the OnBeforePostTotalCostAdjustment event in report 1095 (Update Job Item Cost) by adding the var keyword to the JobLedgerEntryCostValue, JobLedgerEntryCostValueACY parameters, like this:
    [IntegrationEvent(false, false)]
    local procedure OnBeforePostTotalCostAdjustment(var JobLedgEntry: Record "Job Ledger Entry"; ItemLedgerEntry: Record "Item Ledger Entry"; var JobLedgerEntryCostValue: Decimal; var JobLedgerEntryCostValueACY: Decimal; var AdjustJobCost: Decimal; var AdjustJobCostLCY: Decimal; var NoOfJobLedgEntry: Integer; var IsHandled: Boolean)
    begin
    end;

Thanks!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Documentation to include new config transform for OutputCache Provider

Pulled from web.config.transform from the Microsoft.Web.RedisOutputCacheProvider v1.7.6
Some new properties, notably:
            connectionString = "<Valid StackExchange.Redis connection string>" [String]
            settingsClassName = "<Assembly qualified class name that contains settings method specified below. Which basically return 'connectionString' value>" [String]
            settingsMethodName = "<Settings method should be defined in settingsClass. It should be public, static, does not take any parameters and should have a return type of 'String', which is basically 'connectionString' value.>" [String]
            loggingClassName = "<Assembly qualified class name that contains logging method specified below>" [String]
            loggingMethodName = "<Logging method should be defined in loggingClass. It should be public, static, does not take any parameters and should have a return type of System.IO.TextWriter.>" [String]
            redisSerializerType = "<Assembly qualified class name that implements Microsoft.Web.Redis.ISerializer>" [String]

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: felickz sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@felickz : Thanks for your contribution! The author, @wesmc7777, has been notified to review your proposed change.

Verified. @felickz Thank you.


feat: allow the HTTP gateway server to be enabled/disabled

Description
This adds support to enable/disable the HTTP gateway server of OpenFGA. If you wish to only run the grpc server then this will allow you to disable the HTTP server altogether. If you disable the HTTP server then you cannot run the Playground. The server will log.Fatal if you try to run it with HTTP disabled and Playground enabled.
References
Closes #81
Documentation: https://github.com/openfga/openfga.dev/pull/128
Review Checklist

[X] I have added documentation for new/changed functionality in this PR or in openfga.dev
[X] The correct base branch is being used, if not main

Codecov Report

Merging #84 (1bd63e7) into main (226299f) will decrease coverage by 0.01%.
The diff coverage is 68.75%.

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   75.83%   75.81%   -0.02%
==========================================
  Files          73       73
  Lines        8164     8171       +7
==========================================
+ Hits         6191     6195       +4
- Misses       1548     1551       +3
  Partials      425      425

Impacted Files
Coverage Δ

pkg/cmd/run.go
0.00% <0.00%> (ø)

server/server.go
34.75% <75.00%> (+0.52%)
:arrow_up:

pkg/cmd/service/service.go
82.75% <100.00%> (+0.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 226299f...1bd63e7. Read the comment docs.

[ ] todo(jon-whit): add a test for the new config value

Please ensure the docs are updated. TY!

See https://github.com/openfga/openfga.dev/pull/128


Don't overwrite user input on fields not present in initialValues when  overwriteOnInitialValuesChange: false

Fixes #1112

[Current coverage][cc-pull] is 96.87%

Merging [#1345][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.23%

@@             master      #1345   diff @@
==========================================
  Files            73         73
  Lines          4121       4159    +38
  Methods         769        769
  Messages          0          0
  Branches        315        315
==========================================
+ Hits           4002       4029    +27
- Misses          119        130    +11
  Partials          0          0

Powered by Codecov. Last updated by [6865892...be2be59][cc-compare]
[cc-base-branch]: https://codecov.io/gh/erikras/redux-form/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/erikras/redux-form/compare/6865892b35fa0055337ad4e1bd69279b47d11081...be2be59169a438867fc1e19bc2d4ea471d37b03e?src=pr
[cc-pull]: https://codecov.io/gh/erikras/redux-form/pull/1345?src=pr

Published as v5.3.2. Cheers! 🍺


Add PHP 7.2-rc

Package libmysqlclient-dev is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

Package libpng12-dev is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

Package libmysqlclient18 is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'libmysqlclient18' has no installation candidate
E: Package 'libmysqlclient-dev' has no installation candidate
E: Package 'libpng12-dev' has no installation candidate
The command '/bin/sh -c set -xe;     buildDeps="       gcc       autoconf       libcurl4-openssl-dev       libedit-dev       libssl-dev" &&     phpDeps="       gettext       libicu-dev       libxml2-dev       zlib1g-dev       libpq5       libpq-dev       libmysqlclient18       libmysqlclient-dev       libmemcached-dev       libsqlite3-dev       libmcrypt-dev       libfreetype6       libfreetype6-dev       libjpeg62-turbo       libjpeg62-turbo-dev       libpng12-dev       libjpeg-dev       libpng++-dev       libgd-dev       libltdl-dev       unzip" &&     apt-get update && apt-get install -yq apache2 $phpDeps $buildDeps --no-install-recommends &&     rm -rf /var/lib/apt/lists/* &&     docker-php-ext-install -j$(nproc)       bcmath       ctype       dom       fileinfo       gd       gettext       intl       json       mbstring       mcrypt       mysqli       opcache       pcntl       pdo       pgsql       pdo_sqlite       pdo_mysql       pdo_pgsql       phar       simplexml       soap       xml       zip &&     docker-php-ext-configure gd         --enable-gd-native-ttf         --with-freetype-dir=/usr/include/         --with-jpeg-dir=/usr/include/         --with-png-dir=/usr/include &&     docker-php-ext-install -j$(nproc) gd &&     apt-get purge -y --auto-remove -o APT::AutoRemove::RecommendsImportant=false $buildDeps' returned a non-zero code: 100

Conditional phpDeps will need to be updated for the new stretch packages eg. libpng-dev


Stock map reporting

We aren't supposed to have these in the archive, so I'll be leaving here anything I can find:

Unreal - DmAriza: https://unrealarchive.org/maps/unreal/deathmatch/A/dm-ariza_13a52d77.html

Unreal - DmDeathFan: https://unrealarchive.org/maps/unreal/deathmatch/D/dmdeathfan_f9fd3f24.html

Dubious example in need to check: https://unrealarchive.org/maps/unreal-tournament/deathmatch/D/dm-deathfan_4bfbab79.html

Unreal - DmDeck16: https://unrealarchive.org/maps/unreal/deathmatch/D/dmdeck16_e414ab75.html

Dubious example in need to check: https://unrealarchive.org/maps/unreal/deathmatch/U/dm-unreal_deck16_e7ec847d.html

Unreal - DmElSinore: https://unrealarchive.org/maps/unreal/deathmatch/E/dmelsinore_2aaa522e.html

Dubious example in need to check: https://unrealarchive.org/maps/unreal-tournament/deathmatch/E/dm-elsinore_d9f539a1.html

Unreal - DMfith: https://unrealarchive.org/maps/unreal/deathmatch/F/dmfith_b7112d0b.html

Unreal - DmHealPod: https://unrealarchive.org/maps/unreal/deathmatch/H/dmhealpod_2d519898.html

Unreal (OEM Version) - DmBayC: https://unrealarchive.org/maps/unreal/deathmatch/B/dmbayc_66363923.html

Unreal (OEM Version) - DmCreek: https://unrealarchive.org/maps/unreal/deathmatch/C/dmcreek_ec67efca.html

Unreal Return to Na Pali - DmAthena: https://unrealarchive.org/maps/unreal/deathmatch/A/dmathena_543da8b6.html

Unreal (Fusion Map Pack) - DM-Cybrosis: https://unrealarchive.org/maps/unreal/deathmatch/C/dm-cybrosis_69f61491.html

Unreal Tournament - DM-Curse][: https://unrealarchive.org/maps/unreal-tournament/deathmatch/C/dm-curse_2bdbcdac.html

Unreal Tournament - DM-Deck16][: https://unrealarchive.org/maps/unreal-tournament/deathmatch/D/dm-deck16_6ab22d76.html

Unreal Tournament (Epic Bonus Pack) - CTF-Cybrosis][: https://unrealarchive.org/maps/unreal-tournament/capture-the-flag/C/ctf-cybrosis_991b593f.html

Unreal Tournament (Epic Bonus Pack) - DM-HealPod][: https://unrealarchive.org/maps/unreal-tournament/deathmatch/H/dm-healpod_b229d247.html

Dubious example in need to check: https://unrealarchive.org/maps/unreal/deathmatch/S/dmsphealpod2000_5f1d41b6.html

From https://unrealarchive.org/authors/alan-talisman-willard.html:

DM-Cybrosis (Unreal FMP): https://unrealarchive.org/maps/unreal/deathmatch/C/dm-cybrosis_69f61491.html
DM-Stalwart (UT99): https://unrealarchive.org/maps/unreal-tournament/deathmatch/S/dm-stalwart_156f0277.html
DM-Zeto (UT99): https://unrealarchive.org/maps/unreal-tournament/deathmatch/Z/dm-zeto_edbb1c58.html
CTF-Coret (UT99): https://unrealarchive.org/maps/unreal-tournament/capture-the-flag/C/ctf-coret_c0412e07.html
CTF-Darji16 (UT99 Epic Bonus Pack): https://unrealarchive.org/maps/unreal-tournament/capture-the-flag/D/ctf-darji16_b7aa985e.html
CTF-Niven (UT99): https://unrealarchive.org/maps/unreal-tournament/capture-the-flag/N/ctf-niven_dee49cb4.html

Took a while, but whacked these, thanks!


Access data flow

Context
Registers has changed the way data is accessed, removing the need for the API key. This new data flow should mirror Conor's design and Mark's content, as found on the ticket
Changes proposed in this pull request

On a register's page, the 'Access the data' no longer an accordion. It now links to the access the data flow.
Access the data is now a 3 step process:

API or download
Help us improve
API details or Download page.

Once a user has gone through the access the data process once, they won't see step 2 for two weeks.
The 'Help us improve' form is optional, and can be skipped by clicking the 'Skip this step' or 'Prefer not to say' links
A user can then choose to sign up for updates on the signup page; successful submission leads to a thank you page
The email address in the 'signup for updates' form gets added to a list in MailChimp.
Both of the forms have event tracking on them

The 'access the data' form fires events into GA rather than into a backend. The government departments input can only select from a predefined list.
The 'signup for updates' form only fires an event on submission; we only look at the domain of the email address.

This uses the new GOV.UK design system, which requires NPM to pull it in. (This meant changes to the Travis build, CloudFoundry ignore, gitignore, Dockerfile,assets.rb; and inclusion of package.json and package-lock.json).

Guidance to review

Cliff has reviewed the Analytics events.

Can you squash together the WIP commits into a smaller number of changes? Love the ascii art though 😄

would be good to add a feature spec for access the data, as we are deleting the previous one.


[（live．free™！）] Real Madrid vs Osasuna Live Streams Free On TV Channel 9 NOV 2024

How to watch today's Real Madrid vs Osasuna La Liga game: Live stream, TV channel, and start time
How to watch La Liga match between Real Madrid and Osasuna, as well as kick-off time and team news.
Real Madrid will be aiming to recover from back-to-back home losses as they welcome Osasuna to the Santiago Bernabéu in La Liga action on Saturday afternoon.
Carlo Ancelotti's side suffered a heavy 4-0 defeat to Barcelona in El Clásico on October 26, followed by a tough 3-1 loss to AC Milan in Tuesday’s Champions League clash, marking a rough patch for the defending Spanish and European champions.
Currently, Los Blancos sit second in La Liga, nine points adrift of league leaders Barcelona but with a game in hand. Meanwhile, Osasuna have enjoyed a strong start to the 2024-25 season, accumulating 21 points from 12 games. They hold fifth place, just three points behind Real Madrid heading into this weekend’s encounter.
Here, GOAL brings you everything you need to know about how to watch, including TV channel, streaming details and more.
How to watch Real Madrid vs Osasuna online - TV channels & live streams
Premier Sports 1	Watch here
LaLigaTV	Watch here
In the United Kingdom (UK), La Liga match between Real Madrid and Osasuna will be available to watch and stream online live through Premier Sports and La Liga TV.
Check out GOAL's Live Match Centre for updates.
How to watch anywhere with VPN
If you are abroad, you may need to use a virtual private network (VPN) in order to watch games using your usual streaming service. A VPN, such as NordVPN, allows you to establish a secure connection online when streaming. If you are not sure which VPN to use, check out GOAL's guide to the best VPNs for streaming sport.
logo
Stream live anywhere in the world with Nord VPN
Get NordVPN
Real Madrid vs Osasuna kick-off time
Date:	Saturday, November 9, 2024
Kick-off time:	1:00 am GMT
Venue:	Estadio Santiago Bernabeu
La Liga match between Real Madrid and Osasuna will be played at Estadio Santiago Bernabeu in Madrid, Spain.
It will kick off at 1:00 pm GMT on Saturday, November 9, in the UK.
Team news & squads
Real Madrid team news
In a fresh setback for Carlo Ancelotti's side, Aurelien Tchouameni has been ruled out for up to a month due to an ankle injury sustained against Milan. He joins Thibaut Courtois, Dani Carvajal, and David Alaba on the injury list for Real Madrid.
Federico Valverde, who left the Milan game with a back issue, is expected to be fit and should take his place in central midfield. Rodrygo is also likely to return to the starting lineup after a substitute appearance in the previous match, while Eduardo Camavinga is anticipated to step into Tchouameni's role for this clash.
Real Madrid possible XI: Lunin; Vazquez, Militao, Rudiger, Mendy; Valverde, Camavinga, Bellingham; Rodrygo, Mbappe, Vinicius
Position	Players
Goalkeepers:	Lunin
Defenders:	Militao, Vasquez, Vallejo, Garcia, Rudiger, Mendy
Midfielders:	Bellingham, Camavinga, Valverde, Modric, Tchouameni, Guler, Ceballos
Forwards:	Vinicius Jr, Mbappe, Endrick, Brahim
Osasuna team news
Osasuna head into the match with a clean bill of health, as no new injury concerns emerged this week. This means head coach Vicente Moreno will likely field his preferred starting XI for what promises to be an engaging contest.
Moreno may stick with the same lineup that started in the recent clash against Real Valladolid, with Ante Budimir expected to lead the attack. Budimir, who scored 17 goals in La Liga last season, has already netted six times this campaign and will likely be flanked by Bryan Zaragoza and Ruben Pena in the forward line.
While Raul Garcia found the back of the net twice in Osasuna's recent Copa del Rey win over Chiclana, it's unlikely that performance will be enough to secure him a starting spot here.
Osasuna possible XI: Herrera; Areso, Catena, Boyomo, Cruz; Moncayola, Torro, Oroz; Pena, Budimir, Zaragoza
Position	Players
Goalkeepers:	Herrera, Fernandez
Defenders:	Vidal, Cruz, U. Garcia, Herrando, Areso, Pena, Boyomo, Bretones, Catena
Midfielders:	Torro, Moncayola, Ibanez, Oroz, Gomez, Ru.


Create AutowareBase Class

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I've agreed with the maintainers that I can plan this task.

Description
We have created a discussion around having a base class for all Autoware nodes for better monitoring of the system.
Purpose
Implement a base class for Autoware
Possible approaches
Inherit either rclcpp::LifeCycleNode or rclcpp::Node class and implement Autoware base class features.
Definition of done

[ ] Implement a base class that inherits rclcpp::Node.
[ ] Implement registration service

[ ]  Define the interface
[ ]  Create the client
[ ]  Create the service
[ ]  Make them communicate

[ ]  Generate UUID
[ ]  Send UUID
[ ]  Implement control service
[ ]  Implement reporting service
[ ]  Implement watchdog - heartbeat

Related PRs:

https://github.com/autowarefoundation/autoware.core/pull/73
https://github.com/autowarefoundation/autoware.core/pull/84

These PRs took long time to be merged. We can break them up and merge by smaller pieces.


Update Azure consumption management get estimates method to filter dates for modern channel usage

CONTEXT
For the consumption management usage details list API, $filter is only supported for legacy Azure channels (Enterprise Agreement, Web Direct) - NOT for modern channels.
Any modern channel usage does is not captured within the filtered date range (ie, if you only request data for a specific week, the api with fetch data for that entire month regardless)
Using TDD, we should filter the usageRows in the getEstimates method before mapping over them. The filter applied to the usageRows array should be for the same data range.

So this look good, but I question whether the endDate filtering should be exclusive -- I'm currently of the opinion it should be inclusive :) But that doesn't need to block this ticket - we can handle that after aligning on the behavior of the API.

QA tested as well. Closing this one off!


[UX Improvement/Feature Request] Express Association type Form entry (single/multi) select vs "addon_multiple_express_entry_selector", presenting options UX improvements

A while ago @hissy pointed me to an addon they wrote that granted me functionality that appeared to be absent ( addon_multiple_express_entry_selector ). Namely, the ability to multi-select Express Entries "through" associations. For example, I have an Event, and I want to pick what Games are going to be played at that event.
In a forum support thread @aembler pointed me to an alternate method. Instead of using the Attribute type Express Multi-Select, to use the Form entry type Express Association, and select the appropriate one.
I can see that using this alternate method has some up-sides to it. However, there's a UX aspect to it that is worse than @hissy 's addon. Namely, when you are wanting to select what Express Entities to choose.
When I use the Addon, I click on the field where I can type text, and it immediately, already, starts presenting options. So for example, already shows what Games I can pick, and updates as I type in realtime. This UX experience continues as I select more things. This works quite well.
When I use the Express Association Form entry type, nothing at all happens when I click on it. I have to start typing to even realise that it's searching, and it takes a good number of seconds to show anything up, and sometimes it shows nothing until you have enough characters typed.
The request is that we have the UX and performance of the Addon, used for the Experss Association Form entry type.
First, the way it is now does not suggest to the user that it is a field that has any search capabilities. So it needs to immediately present options.
Second, the delay before you start seeing any change in results is way too slow vs @hissy 's Addon. This needs to be effectively instantaneous, in similar vein to the Addon. Waiting seconds for a search like that to update is painful, and in 2021 just stinks of slow website.
So, for the v8.5.x branch (and onward + v9), can we please have a release include these improvements? Thanks! :D

I don't think we can get rid of the delay on this; the whole purpose of this template is that it communicates with the server, rather than pulling in the entire list of entries.
That being said, updating this to the latest select picker library we're using will a) help it work again in version 9 and b) improve its display and performance. This is what it looks like with https://github.com/concrete5/concrete5/pull/10538 applied:

This will be a part of 9.1.0 and should improve using this template.

@aembler I want to clarify that the original request was using "multi express entry" as an ATTRIBUTE in a Form, instead of the ASSOCIATION (many to one/many to many) in a Form.
It was pointing out (forget where) that using the ATTRIBUTE method (based on Hissy's submission) is not the way to go, and since I've learned that, I see the ASSOCIATION method in the Form is the better method.
However, I am unsure how that lines-up with the UX of the form in its current state. But I am glad to see it looks like a solution is in the works! Thanks!


Unsupported IM tags

Issue reported by @hansbkk
Wow this is a big one! Every one of the IM handles from Google's export gets just silently dropped!
X-AIM:AIM
X-GTALK:gTalk
X-ICQ:ICQ
X-JABBER:Jabber
X-MSN:MSN
X-QQ:QQ
X-SKYPE:Skype
X-YAHOO:Yahoo
Workaround would be to enter these in notes only.
Cozy exports them (Twitter & Skype only) as:
X-;TYPE=TWITTER:@AAAFirst
X-;TYPE=SKYPE:AAFirstAAALast
and in fact Cozy uses the 'blank' "X-" label for company, all relationships, custom dates
rather than the more useful labels allowing grouping:
item10.X-ABDATE:2019-12-31
item10.X-ABLabel:Arbitrary Date
and
item12.X-ABRELATEDNAMES:Big Brother
item12.X-ABLabel:$!!$

Thanks Frank
FFR More general issue here: https://github.com/cozy/cozy-sync/issues/26

Note about this @jacquarg
We need to figure out the more client-compatible way to export IM handles : I am affraid most client will silently drop the X-SKYPE and co.
The X-;TYPE=TWITTER:@AAAFirst is a bug.
For datapoint with name="other", we should put directly the type after the X- and handle specially the types we "know" (aka all of the OP)

Test this - take google's export, transform to your choice of structure, then see if Google will re-import it correctly. If so, done & profit!

It should be fixed by latest changes. Let's @hansbkk review the fixes :)


Add support for certificate renewal to scion-pki

Certificate renewal workflow needs to be defined and implemented in scion-pki.

The scion-pki tool now has support for requesting certificate renewal.
See scion-pki certs renew --help for more details


Documentation: what's the difference between uiFreeControl and uiControlDestroy

Hello and thank you for this awesome library!
In order to have proper memory management, what's the difference between uiFreeControl and uiControlDestroy? When to use the first and when the second?
To my understanding, it's confusing if we should use both, or only one, and under which conditions.

what's the difference between uiFreeControl and uiControlDestroy? When to use the first and when the second?

uiControlDestroy() calls the platform specific APIs that actually destroy a control (and its children), uiFreeControl() just frees the memory associated with the control reference. uiFreeControl() is only public for writing custom controls.
Most of the time, you should only need to use uiControlDestroy() directly, and only on your main top level window.

Thank you for the clarification. If you don't mind I'll prepare a PR stating what you said, for future documentation.


Bug fixes

when allowances do not load up in the dapp show a blocking error modal prompting the user to refresh
fix false display of Apy when the backend returns 0

This is what the error modal looks like. Not super polished but should be okayish to that couple (hopefully not more) of users who will see it

@micahalcorn added you to the PR to give you the opportunity to disagree with the solution.
One user had a problem where for some reason the allowances have not yet loaded up when he was trying to mint. It could be that he was super fast clicking on the mint button, or there has been some other error.

@micahalcorn @shahthepro merging this in happy to address stuff if needed later.


⚠ Roblox has degraded performance

In be68610, Roblox (https://www.roblox.com) experienced degraded performance:

HTTP code: 503
Response time: 1868 ms

Resolved: Roblox performance has improved in 17e6e72.


PipTest: Upgrade the expected Werkzeug version to 0.15.2

This change is

@mnonnenmacher, there's still one more occurrence of "PyPI::Werkzeug:0.15.1" in example-python-flask-expected-output.yml.

Fixed on behalf of @mnonnenmacher.


Support for detail above list in API

Describe the feature and the current behavior/state.

Support for a detail section above the list like that used in the my schedule built in command
Currently the list UI option has no ability to add this in the API
Will this change the current API? How?
will add a new feature to the list functionality
Who will benefit from this feature?
Anyone using the list functionality in the API that wants to display important information at the top
Any Other info.

Hey! Yes, the idea supporting it in the API fly in the air for a while already. First idea was about extending this item with a text inputs to make possible to create Translator with it or something.
We added this to the our backlog, so it's planned but cannot give you specific dates on that.


add a variable "timer_process" in inputoutput.f90

So far, many files for elapsed times are generated in a real-time calculation in the GCEED part. But I think most people were annoying. In addition, a filename like cputime** is confusing because that name is similar to the time displayed by linux command "time". So I add a variable "timer_process" in inputoutput.f90.
By this modification, the master process write elapsed times in standard output in the real-time calculation. If user specify "y" for "timer_process", files named timer_proc** are generated. A default value is "n".
Is it possible to mergy this PR?

I forgot to say one thing. I checked that it runs successfully both for the ARTED part and the GCEED part.

@mn2007 san, Thank you for development. I think this is a bit complicated and require a bit time for consideration. I will review this PR later...

Thank you for reviewing, @uemoto1 san. I wait.

Thank you for development.
I understood this modification outputs the elapsed time analysis to the stdout, and add a new (optional) input parameter to enables to export the same information onto a file timer_proc???.
I confirmed this modification does not affect to the functionality of ARTED part, and it is available to merge.

I think it's good idea to implement such function in the ARTED part. But I guess it's not urgent task.  By the way, I think other people would not merge this PR. So could you merge, @uemoto1 san? Thanks in avdance.

I agree that one is not a major problem to solve immediately, this PR is okay to merge.
(Since I was not a suggested reviewer, I have pending to merge this.)  If it is allowed, I will merge this one.
Thank you for contribution.


[-Wdeprecated-copy-with-dtor] Fix deprecated copy with dtor

attempt to fix #2062

Request review from @atamazov

@averinevg 👍

@averinevg have you tested using the rocm/miopen:debug_2063 docker? The current issue will not be shown in current CI docker.

@averinevg have you tested using the rocm/miopen:debug_2063 docker? The current issue will not be shown in current CI docker.

@junliume I have tested on my PC with clang 15.0.7

@averinevg You have to use the same docker image (rocm/miopen:debug_2063 in this case) to reproduce and fix tidy issues.

@averinevg Indeed please pull docker rocm/miopen:debug_2063 and try to build MIOpen inside. I added your changes but now it is failing with multiple errors, for example:
In file included from /root/MIOpen/src/include/miopen/pooling/solvers.hpp:33:
/root/MIOpen/src/include/miopen/utility/transposing_solver.hpp:166:38: error: only virtual member functions can be marked 'override'
    std::string GetTranspose() const override { return "*-*"; }
                                     ^~~~~~~~~
/root/MIOpen/src/include/miopen/utility/transposing

Ping @averinevg @DrizztDoUrden @atamazov @JehandadKhan  for review since without it the build will fail in mainline soon.

@averinevg You have to use the same docker image (rocm/miopen:debug_2063 in this case) to reproduce and fix tidy issues.

@averinevg Indeed please pull docker rocm/miopen:debug_2063 and try to build MIOpen inside

@junliume @atamazov These warnings are reproducible using clang 15.0.7 as well


python3

Do you plan to support python3?

@lukasheinrich this issue can be closed now

thanks @shantanu-gontia for the PR and @wiso for opening the issue. I'm happy people are using this package. If there is interest we could try to develop this into something more generally useful. @iamholger @cpollard

@lukasheinrich I actually started outlining such a project. But due to other commitments couldn't really ossify it. Although, I'm very welcome to making this into a more general API for accessing LHE files.


Added background color attribute

@predatorx7 let me know if anything needs to be fixed

Thank you for contributing. I'll add tests for it and release an update this weekend.


Add Github PR template

What
Adding a Github PR template.
Why
To assist in writing meaningful PR messages and serve as a checklist for reviewers.
Screenshots
If applicable add screenshots otherwise remove this section.
Before
After

Review Checklist

[x] Changes in scope.
[x] Added/updated unit tests.
[x] Added/updated feature tests.
[x] Added/updated relevant documentation.
[ ] Added to trello card.

Should we add these points to the review checklist?

[ ] View branch in integration
[ ] Meets trello card acceptance critera

We have a trello thing going on whereby if you paste the trello card url in here it automatically makes a checklist item on the trello card. Also, in the PR if you have the link it's very easy to go back and view the card itself, so I think instead of a checklist item, you should add a trello "field" to the template. Maybe specifically Trello, but maybe just something like "documentation of need" or something so we could put links to other things that generate PRs in the same "slot"?

I am merging this PR. If anyone want to make changes, please raise a PR


modifying zero plane displacement height

[Short description explaining the high-level reason for the pull request]

Corrected pet_params.heat_transfer_roughness_length_m in "PEtPenmanMonteithMethod.h";
Added a necessary condition for calculate_aerodynamic_resistance in "pet_tools.h".

Additions

Removals

Changes

Testing

Screenshots
Notes

Todos

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Target Environment support

[ ] Windows
[ ] Linux
[ ] Browser

Accessibility

[ ] Keyboard friendly
[ ] Screen reader friendly

Other

[ ] Is useable without CSS
[ ] Is useable without JS
[ ] Flexible from small to large screens
[ ] No linting errors or warnings
[ ] JavaScript tests are passing

As expected this PR resolves the NaN issue, but not the magnitude issue. Attached figures that support that.
![NOAH-OWP-PET](https://user-images.githubusercontent.com/8662550/180503549-381ad940-41d6-4594-8

887-04711b224a9f.png)

Read to be merged.

Thanks Luciana for the review and testing runs. Good to see the NaNs issue was fixed, and the results also look more reasonable compared to the initial runs for case 1. I am not sure about the case 2 at the moment - was it the same basin at different time period or a different basin?  I'm thinking of duplicating the two runs first and testing the parameters with them for comparison. I was wondering if Luciana could send me the basin data and realization files? Thanks.
See the initial results below:

I know we have talked about it, but just for the records, since the way github is showing the figures do not include the file number, which became very confusing. The first figure in my response correspond to PET Option 1 run for catchment 0801300, and values for PET are reasonable. The second figure shows results with PET Option 5 for the same basin, with values ~100 higher.


Barrel index options

Hi there! Thanks for the awesome utils.
I am wondering if barrel options was excluded intentionally, I am trying to find out the best practices in using these in a monorepo settings.

Wow thanks!! Appreciate for the new update!


[BUG]  shell completions not showing skip-ci option

Hey @xmlking, are you sure you're on the latest version(s) (run cog --version) ? Works fine on 6.0.1 and 6.0.0, just tested on Windows and Linux binaries.

Just tested on WSL with cog 6.0.1 with bash. Can you give me your shell + OS and check if you're using the latest version ?

Just tested on WSL with cog 6.0.1 with bash. Can you give me your shell + OS and check if you're using the latest version ?

MacOS
Ksh shell
Installed with brew which automatically add command compression

Thanks ! I'll have access to a Mac tomorrow, I'll try to reproduce :)

looks like I manual create _cog auto completions file in 2022  in the same directory where brew generally keep completions.
Before:

I have re-run generate command  to update it and make it work again.
cog generate-completions zsh > $(brew --prefix)/share/zsh-completions/_cog

Many uses may forgot to re-run Shell completions command when they upgrade cog and miss the new flags.
would be nice if we also implement adding auto completions automatically with brew install.

Closing since this is a package maintainer issue.
Maybe an issue or a PR should be opened to fix this on homebrew.
I don't have access to a mac myself.


BUGFIX: Manipulation ENV

Increase to 10 seconds (1000 timesteps).
Bug fix for trajectory evaluation
Bug fix for ENV contact evaluation

lgtm! I wonder whether we want to comment on the step function or better to create a separate notebook on how to use the hardcoded baseline?

lgtm


correction for bug #78 : now the pointer always remains valid.

syslog only keeps a pointer to the "identity" buffer, and doesn't copy the data. That means that the pointer has to remain valid (pointing to a valid memory location containing a valid string) until the pointer is changed. See:
https://www.gnu.org/software/libc/manual/html_node/openlog.html
The solution proposed here:
We prepare a new string while the old string is still alive, then we call openlog() again with the new pointer (ref link), and finally the old string is deleted.

This looks 100% fine. Ideally it would come with unit tests but unfortunately (due to OS dependency issues I believe) there was no unit tests added - only a fatal example for syslog.
https://github.com/KjellKod/g3sinks/blob/master/scripts/buildAndRunTests.sh#L68
I love the use of the list. It makes perfect sense.
If you are bored at some point this article I wrote a long time ago will give you a lauch:
https://www.codeproject.com/articles/340797/number-crunching-why-you-should-never-ever-ever-us

@JoelStienlet : there's a nonsense merge conflict that has to be taken care of. I don't have permissions to push it to your branch otherwise I could have done it.
Once that is done this will likely be fine to be merged.


Fixes #4255 - Media details activity shows depictions in random languages, rather than in the user's locale

Description (required)
Fixes #4255
What changes did you make and why?
Since App fetches a list of a depiction in different languages but I have noticed that depiction is only shown in the first language given in list, which is causing this issue. I have added the conditions Now it will first check if the depiction caption is available in the user's locale and if not then it will also check for English as it is the default language, else show in any available language.
Tests performed (required)
Tested prodDebug on Pixel 3 with API level 29.
https://commons.m.wikimedia.org/wiki/File%3ADülmen%2C_Merfeld%2C_Feldweg_am_Mühlenbach_--_2021_--_4278-80.jpg
default language: English
Latest Master 3.0.0-debug

Updated

@Pratham2305 could you post a screenshot of the fixed media details view, please? Thanks!

@misaochan Yes, Posted!

Codecov Report

Merging #4275 (23e2784) into master (d6dcd43) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6dcd43...23e2784. Read the comment docs.

Wonderful, thank you @Pratham2305 ! Merging since @neslihanturan 's review has been addressed. :)


Add Cloud Vision Sample with Spring Framework

This adds a sample of using Cloud Vision APIs from a Spring Boot application by leveraging Spring Cloud GCP libraries.
This is a parallel effort with the effort to add a Spanner + Spring sample here: https://github.com/GoogleCloudPlatform/java-docs-samples/pull/1474
We are also working with Cloud Vision doc writers; this sample will be used as code samples within that documentation.

@lesv - Hi Les, I wasn't sure if you were the correct point of contact on this; was just going off of the previous PR. If not, could you point us in the right direction as to how we could contribute this code sample for the Cloud Vision docs?

@dzlier-gcp - Friendly ping - Could you help us take a look at this PR? Or point us in the right direction with who is the correct point of contact on adding a code sample for Cloud Vision? Many thanks.

Is anyone with Spring familiarity available to TAL at this? /cc @kurtisvg @lesv

will do, but I think @meltsufin knows spring fairly well.

will do, but I think @meltsufin knows spring fairly well.

I already approved it :smile:  and Dan is on my team.


limit per ip?

Hi,
Is this really work? does it need logging in to Instagram? and do you know if there is any limit on the number of requests per day?
Thanks

Yes, it really works.
You need to log in once (with a browser). After that, you can use the bot as long as the session cookie is valid.
I don't know about any limits. And I don't think they are public either. But as soon as you make too many requests you will look suspicious which could lead to a ban of the Instagram account in use (or worse). Instagram's terms of use forbid to automatically collect data of it's platform.
Therefore I encourage to read the terms of use and the corresponding laws of your country for you to know what you can and cannot do.


Falsely detects unicode with FULL STOP as valid domain (eg ⒈com)

The following tech spec says "all characters (other than the 4 label separators) that contained a FULL STOP in their compatibility decompositions" are forbidden. This makes sense, for example ⒈com is definitely not a valid domain.

Conflicting https://github.com/python-validators/validators/issues/74


Added getLength decimal precision for non geodesic map

When we use the line measurement tools on a non-geodesic map with cm detail, the precision is truncated by the rounding at the getLength method level.
As a result, the lengths displayed are rounded to the decimetre.
In this pull request, I propose a stronger quoeficient to get a more accurate result.
I've based on the quotient used in the area calculation, which I think is relevant.
Best regards

If we use 6 as default, this is IMO a breaking change, semver-wise.


update docs for refactor command

This PR:

Updates docs for refactor command

PR: https://github.com/dendronhq/dendron/pull/1796
related: dendronhq/dendron#116 dendronhq/dendron#1609