sosa:resultTime datatype limitations relative to data

Data that we have been investigating for the BDR in fields equivalent to dwc:eventDate, dwc:dateIdentified are not as precise to have a recorded time (just date). To fulfil the validation requirements on sosa:resultTime we need xsd:dateTime. Is there a particular default time we should implement to fulfil the requirement or can the datatype options be expanded to reflect the data precision more accurately?

When designing the ontology, we chose xsd:dateTimeStamp because union datatypes are underspecified in OWL, so we had to choose just one. I would suggest the TERN Ontology SHACL could quite reasonably relax that to xsd:date which is a very common (probably the most common) precision in eco surveys.

@dr-shorthair SOSA specifies sosa:resultTime with rdfs:range as xsd:dateTime. See https://prefix.zazuko.com/sosa:resultTime.
I am not sure if there is any implications with rdfs:range if used with an RDFS reasoner. Would the reasoner see an xsd:date value and produce an additional literal value as xsd:dateTime? @nicholascar do you know?

Sorry no: no reasoner could go from xsd:date to xsd:dateTime or xsd:dateTimeStamp.
SPARQL, or at least some triplestores, contains casts the other way around but not in that direction, given the lower to higher precision.
You might have to implement a special TERN property here and it can't be a sub property of sosa:resultTime either as that would require the same, or more restrictive, range.

@nicholascar thanks.
I think we have a few options here.

Create a new property tern:resultDate which requires the value to be an xsd:date
Continue using sosa:resultTime but set the time portion to T00:00:00Z (midnight UTC)
Create a new super property tern:resultDateTime which allows for both xsd:date and xsd:dateTime values.

Thoughts?

Please don't do # 2.! Always misleading to make up times.
I think 3. - superproperty - is the way to go. Make sure to allow xsd:dateTimeStamp for it too!

I also like option 3. Thanks all.

Continue to use sosa:resultTime but with a xsd:date value

Then submit a CR to W3C to relax the range of sosa:resultTime

@dr-shorthair - is creating a change request just a matter of creating an issue in https://github.com/w3c/sdw/issues?
I am thinking we should move forward for now with tern:resultDateTime until sosa:resultTime is changed upstream. The reasoning for this is because systems need to load in SOSA for the validators to work correctly, and loading SOSA will load in the problematic statement sosa:resultTime rdfs:range xsd:dateTime. Once W3C agrees and relaxes the range, we can go back to using sosa:resultTime.
Does this sound good? @dr-shorthair @nicholascar @miekeGR

Do the validators use the rdfs:range constraints from the W3C ontology?

Oh yeah, good point @dr-shorthair, I don't think the validators need to import it.
Then are we happy with the continue use of sosa:resultTime?
I can update the property shapes for sosa:resultTime to allow for xsd:date, xsd:dateTime and xsd:dateTimeStamp.

The validators don't directly import it but we do apply SOSA expansion to data during validation and, since we use the strict TopBraid expanders, they might throw errors. So please do implement your option 3. above Edmond and don't just overload sosa:resultTime

@edmondchuc we are still happy to use option 3.

@edmondchuc should I close this issue now or when you have implemented tern:resultDateTime?

I tend to be guided more by what the queries are going to look like.
In order to make queries portable, it is best to stick with the standard predicates ...

don't just overload sosa:resultTime

Like I said, the reason the SOSA rdfs:range is what it is is because OWL doesn't allow union datatypes. It was not because we thought that precision was always needed. I now think it was a mistake, and should have been left blank. I think it would be a bigger mistake to invent a new predicate.

SOSA rdfs:range is what it is is

Yeah but indeed it is what it is and unless I knock it out of out copy of SOSA, thereby making a non-standard SOSA, we have to live by it for not.
You know I'd prefer a standard property but not if it causes us reasoning issues.
So I don't think we have a better option than 3. for now.

not if it causes us reasoning issues

What reasoning are you doing? I thought we were using SHACL for the design & validation, and SPARQL for query. No reasoning required.

I thought the 'TERN Ontology' was defined in SHACL

No, it's an OWL ontology, with a separate SHACL validator.

Can you turn-off data-type checking?

I don't think I can, not easily, in TQ EDG.
I don't want to alter decade+ standard ways of working or implement much cutting edge stuff here, just make a 'normal' RDF system work. There is already enough innovation in the use of a graph data model, SHACL etc.
Please just implement a new property!

I don't want to alter decade+ standard ways of working or implement much cutting edge stuff here

I understand. But we should resist altering the data in order to compensate for tooling limitations. Tools come and go (including schemas). Data is forever.
And since queries go through chains of properties, we should be the most conservative about renaming those.

And if validation is all using SHACL, then just don't load the OWL ontology.
We are not doing any reasoning here - we are just using RDF as a convenient data format.
SHACL is really the closed-world complement to OWL/RDFS.

I understand. But we should resist altering the data in order to compensate for tooling limitations. Tools come and go (including schemas). Data is forever.

We must be talking (typing?) at cross purposes. I am not suggesting altering any data, only providing properties that allow for the data, as Gaia have it, to be recorded without breaking any ontology rules.

And since queries go through chains of properties, we should be the most conservative about renaming those.

You don't need to tell me: I advocate most strongly for property reuse. But the limit is here: if a property forces something you can't live with, we need a new property. Not a renamed one, a new one. Just as TERN already implements tern:FeatureOfInterest not sosa:FeatureOfInterest but we just can't relate the new property to the old with the subPropertyOf in this case for the RDFS reasoning issues mentioned.

And if validation is all using SHACL, then just don't load the OWL ontology.

It's not and I can't as I already said. Within TopBraid EDG, the SOSA ontology is loaded and its reasoning will be applied. Not much I can do about it. Other than to create a hack SOSA...

We are not doing any reasoning here - we are just using RDF as a convenient data format.

You might not be, but the BDR system will be. Also, other users of BDR data might, given that OWL ontologies allow for it.

SHACL is really the closed-world complement to OWL/RDFS.

Sure, but we are inheriting a tricky rule from SOSA here, not arguing about what we can do with SHACL.

Hi all, an update on my side.

I've created a change request in SOSA to remove sosa:resultTime rdfs:range xsd:dateTime. https://github.com/w3c/sdw/issues/1338.
I've created a PR for a fix with option 3. https://github.com/ternaustralia/ontology_tern/pull/137

Please @dr-shorthair @nicholascar have a review and if we are all happy with it, we can merge it in.
I will create a new issue with links to all the relevant issues and pull requests to ensure things are not lost. Once SOSA has provided the upstream fix, we will revert back to using sosa:resultTime with deprecation messages for tern:resultDateTime in the form of property shapes.
@dr-shorthair out of curiosity, what is the process for change requests and how long does the process take?

what is the process for change requests and how long does the process take?

Haha. There is currently no revision working group. So that request will just sit there (thanks for submitting it, though).
Would be even better if it was a PR though - also on the spec document ...

Looks good to me, as I've stated in the PR.

And then RDF inherited this mess when they agreed to use the XML Schema datatypes, which was a political compromise in W3C.

Data is forever.
We must be talking (typing?) at cross purposes. I am not suggesting altering any data

Here I was thinking of data-files, including the markup.


fix: add missing getProtocolVersion() in MessageInterface

Description

add missing getProtocolVersion()

PSR-7 has the method

Checklist:

[x] Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
[x] User guide updated
[x] Conforms to style guide

Added changelog.


Fix method to update disease

The option Edit Disease Attributes does not work when we try to add a omim id to a disease without omim id.

Merged into release/112 and master


Failed to download the dataset

I tried to download the dataset and registered the information(I am a college student) but I haven't heard back yet.
Could you please provide me with the dataset?
Thank for your answer.

Maybe you can contact ORR dataset maintainers via their email. I did so and it worked.

Thank you for your answer


fix: always send application/json as content-type

Always send the Content-Type: application/json header for all HTTP verbs instead of performing a traditional form post for POST requests.

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Refactor
[ ] Performance
[ ] Tests
[ ] Build
[ ] Documentation
[ ] Code style update
[ ] Continuous Integration
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Does this PR release a new version?

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[ ] It's submitted to the develop branch, not the master branch
[x] All tests are passing
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Codecov Report

Merging #101 into master will decrease coverage by 72.95%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           master     #101       +/-   ##
===========================================
- Coverage     100%   27.04%   -72.96%
===========================================
  Files          14       14
  Lines         245      244        -1
===========================================
- Hits          245       66      -179
- Misses          0      178      +178

Impacted Files
Coverage Δ

src/http/os/http.cpp
52.27% <0%> (-47.73%)
:arrow_down:

src/api/paths.cpp
0% <0%> (-100%)
:arrow_down:

src/include/cpp-client/http/http.h
60% <0%> (-40%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcea4db...15dbb6a. Read the comment docs.

These changes look good, we'll just need to rebase after #102 & #100, @faustbrian


add froc metrics

Add FROC curve drawing and read its performance metrics
Motivation
In a scenario with many outliers, the AP index and ROC curve do not play a large role. The R(false positive per image) indicator and FROC curve play important roles in this scenario.
Modification
Added the FROC metrics file and the corresponding registration component
Use cases (Optional)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @svipvm,
We'd like to express our appreciation for your valuable contributions to the mmdetection. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: https://discord.gg/UjgXkPWNqA.
If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".
Thanks again for your awesome contribution, and we're excited to have you as part of our community!


[Enhancement]: Update to LocalStack 2.x

Module
LocalStack
Proposal
The current version of LocalStack is 1.4. The next release will be 2.0, due next week:
https://github.com/localstack/localstack/issues/7882
This release contains changes that will break Testcontainers integration at some point in the future. In particular, the HOSTNAME_EXTERNAL environment variable that Testcontainers uses will be deprecated, to be replaced by LOCALSTACK_HOST.
In 2.0, the old HOSTNAME_EXTERNAL variable will continue working, so this will likely not start causing issues right away. But once this backwards-compatibility support is removed, the localstack/localstack:latest Docker tag (effectively their nightly build) will immediately be updated.
Therefore, people using Testcontainers with LocalStack using the localstack:latest will have their tests start failing at some point in the future. Even though using that tag is a bad idea, this likely applies to a non-trivial number of people, because the current default version is the ancient 0.11.2, and many fixes have been added to LocalStack since. That in itself is a good reason to update.
The solution might be as simple as updating this constant (and checking all places that reference it):
https://github.com/testcontainers/testcontainers-java/blob/3b0c1cbbf798f69ff18c22fdb9c2ce7fb0390d2a/modules/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java#L33

maybe this is the wrong place to point this out but would it be possible to make the configuration of the duration of the localstack startup configurable? I get a lot of problems when running it with the default timeout of 1 minute (maybe an issue in my infrastructure but I still would like to be able to configure it)
$ docker ps
CONTAINER ID        IMAGE                                                       COMMAND                  CREATED             STATUS                             PORTS                                                NAMES
0fc422fc2ead        localstack/localstack:1.1                                   "docker-entrypoint.sh"   33 seconds ago      Up 33 seconds (health: starting)   4510-4559/tcp, 5678/tcp, <IP_ADDRESS>:51660->4566/tcp     blissful_hellman

Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '.*Ready\.

@laszlovandenhoek Thanks for sharing! I just started working on this and contacted the LocalStack team because found an issue. So, this will be take into account for next release.


Fix for issue #235

Fix for issue #235
Removed "You can install a gateway only in the default environment." because it's not the case anymore.

@MSFTMan : Thanks for your contribution! The author(s) have been notified to review your proposed change. @msftman


redux reducers and actions?

I may be missing something huge, but I'm unable to locate where you are using redux reducers and actions.

For tasks, the state and actions are connected to the Task component here.
Thunked actions like createTask submit requests to Firebase.
Firebase listeners are setup to dispatch responses to the tasks reducer.


Update picozero.py: LED() documentation has pin rather than pwm for s…

…econd parameter
:param int pin: is in two places. The second place should be :param bool pwm:

I don't need the pull request on my repo.


Fixed onToggle to return false upon keyboard close

Previously it always returned true regardless of state.

Just tested, this causes jumping when the keyboard closes on iOS.

@Andr3wHur5t What do you mean? It seems to work normally for me except now toggleState is returning a different value.

I'm looking into a fix, probably need to check if the height is 0.

@DVassilev this fix seems to be causing an issue with the hide animation. On master its smooth, on this branch it jumps down after the keyboard finishes its transition.

@Andr3wHur5t Odd, it remains a smooth transition for me.

@DVassilev my bad, seems the simulator was sending multiple events. Restarting the simulator fixed it.
Looks good :+1:


Add onvif mapper based kubeedge v1.17.0

Add onvif mapper based mapper-framework in v1.17.0 of kubeedge

@fisherxu

The code has been modified according to the comments @fisherxu. At the same time, since part of the code is generated by mapper-framework, I think mapper-framework still needs to be modified. I will submit a PR to the main repo later.

/lgtm


Request: Upload to cdnjs

Hi, I use this here and there for prototyping via jsfiddle and other one off tests. Would love to have it available via http://cdnjs.com
Can you add it?  https://github.com/cdnjs/cdnjs

Will you be able to start using tags in github for releases? I cant add it to CDNs because the auto update feature is based on tags. Its also quite difficult to track version history without them, you should be using them anyway!! :)

Ok, going to have to learn how to use tags!

I can help set you up on http://www.jsdelivr.com if you'd like.  3 times better than cdnjs, because it IS cdnjs multiplexed together with MaxCDN and a third CDN with a few additional POPs.
Only issue I see now is that your have minified code which we require.  Automated uploads are possible with our bot when you push to /releases.

On Feb 24, 2015, at 8:16 AM, joshuagatcke<EMAIL_ADDRESS>wrote:
Ok, going to have to learn how to use tags!
—
Reply to this email directly or view it on GitHub.

Cool, this sint my project, but sounds great to me. I will look into using your CDN in the future. Hopefully its easier to add/update libs than CDNjs but this isnt the place for that discussion. Let me know if I can do something here to help HTML Kickstart get onto a CDN, as that will be quite useful to me, and I hope others as well...

Sorry, you = @joshuagatcke  :)


After-Party Feature

As a WoW Classic Player, far too often we group with people we like but don't make an effort to connect with them.

Notes & Acceptance Criteria

Windows shows as soon as you leave a group that killed a dungeon boss or raid boss.

Shows on party or raid.

If you hit "Add to Friends" and have "Send Message..." enabled:

"{rt4} Groupie : I added you as a friend! Cheers!”

Needs to use class color for the names.

Also needs the option to "Enable After Party" in the Character-specific settings.

Any friend added should be added to the "Groupie Global Friends List" not the in-game Friend List. #20

Also need a "Delete" button on the Global Friends List, for "Groupie Friends" -- can't delete character friends or guildies since we import those on load.

Design File

After Party || https://whimsical.com/after-party-RjjpoEr7oRxig6f8uR2myR

Any friend added should be added to the "Groupie LFG Global Friends List" not the in-game Friend List. #20

@TannerShmoog I would really like to get this in too, I don't think it's that much work.

For Tooltips... see notes.
https://discord.com/channels/@me/1012495654687342633/1048694544742486186


prql-compiler name?

I remember this was discussed a while ago, around possibly renaming to prqlc. I don't have a view but wanted to ensure I wasn't dropping something others were expecting.
The others I'm familiar with are rustc and ocamlc (but also ocamlopt), though go is just go IIUC. Any others?
I can understand not just calling it prql given it is more "core" and probably not going to be called directly by many people.
We should ensure the brew references reflect the correct name, whether that's prqlc or prql-compiler. https://github.com/prql/prql/issues/866

I think we need a distinction between:

prql-compiler, which is a library that can be used directly from Rust or via bindings for other languages, and
prqlc which is the CLI that you can invoke to compile .prql files to .sql. This is the thing that needs a short name.

prql-compiler will probably be split into it's own sub-dependencies (prql-ast for example) so future projects (such as LSP server, database plugins or query execution engine) can utilize only parts that they need.

Great suggestion @aljazerzen . I agree with that.

Where do we currently use prql-compiler name? cargo crate that is the cli?

Where do we currently use prql-compiler name? cargo crate that is the cli?

Yes, and the brew recipe

I see. So to do this, we'd have to

publish a new crate prqlc,
rename brew recipe,
and possibly remove Cli structs from prql-compiler library crate.

@max-sixty can you do this? It involves GH actions and cargo organization that I don't fully understand. I'm not saying now, just in general.

For sure! Definitely my area

I'm not sure if I'm understanding correctly but I don't think that you have to publish a new crate. You can just rename the binary target in the crate. The prql-query crate is called prql-query but the binary it produces is called pq.

and possibly remove Cli structs from prql-compiler library crate.
publish a new crate prqlc,

Why split the crates up though? Isn't it simpler to have a single crate? (no strong specific view though)

How does this work then? There is a single crate published and it contains both library you can call from your code and the binary with some other name?

Yes, I think you can do this: https://stackoverflow.com/questions/26946646/package-with-both-a-library-and-a-binary

We currently publish both the library and binary as a single crate — the change would be to the binary name. pq is a good example!


Add audio sample rate

[X] I've verified and I assure that I'm running youtube-dl 2016.08.28

Before submitting an issue make sure you have:

[X] At least skimmed through README and most notably FAQ and BUGS sections
[X] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[X] Feature request (request for a new functionality)

Description of your issue, suggested solution and other information
Audio bitrate (--audio-quality 128K) can be set but not audio sample rate.
It should be possible to select both audio bitrate and audio sample rate at the same time.
sox require identical audio sample rates to merge files with

sox track1.ogg track2.ogg merged.ogg

or I it give this error message

sox FAIL sox: Input files must have the same sample-rate

Please paste an example URL and the command you use to download these files.

@yan12125

youtube-dl --extract-audio --audio-format vorbis --audio-quality 128K Y6ihmqRahKg

Use format selection: -f 'bestaudio[asr=44100]'. Here "asr" is abbreviation of audio sample rate.
By the way, --audio-quality is used in re-encoding, not for selection.

@yan12125 Thank you.


I'm having this problem

ADD ISSUE DESCRIPTION HERE
Version: 1.80.0
Commit: 660393deaaa6d1996740ff4880f1bad43768c814
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/114.0.1823.79
Embedder: codespaces

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Detect the tag of the current commit

This PR adds a tag key to the returned object, that unsurprisingly contains the tag of the current commit, if any.
It will be used to solve https://github.com/embersherpa/ember-cli-app-version/issues/5#issuecomment-71463566

Published as 1.0.3.


Added appendix to mkdocs and added some internal links

Added appendix to mkdocs
Added several internal links (https://github.com/bids-standard/bids-specification/issues/8)
Edited CHANGE for further automation (no linter errors) and added internal links

looks like this needs to be rebase as there are redundant commits in the history

what are the redundant commits you are referencing? rebasing my old_contrib?

I think it includes the commits from https://github.com/bids-standard/bids-specification/pull/44, which may not be ideal, instead of having the master branch as base.


DANE TA priority (vs. cross certs)

This is a bug fix for a DANE corner case where TLSA records publish a "DANE-TA(2) 0 0" full trust anchor certificate, but the remote peer's untrusted chain has instead a cross-cert.
This is the case with Let's Encrypt and the ISRG X1 root, which is also available as a cross cert signed by DST.

[x ] tests are added or updated

LGTM for 1.1.1. This shows that at least some cleanup of the chain building code in 3.0 was beneficial as the 3.0 change is fairly cleaner.

Yes, the new utility functions are helpful.  Reduce open coding and code clutter.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged. Thanks!


"m is not defined" External unpkg modules not working in latest Firefox

Steps to reproduce

Open Firefox (latest version 93.0 as of writing this)
Navigate to https://flems.io/mithril
Attempt to use m in the .js tab.
See error in console: m is not defined

I tested this with https://flems.io/preact as well, but no luck. preact is not defined.
System information
OS: Ubuntu 21.04
Browser: Firefox 93.0
EDIT: This actually may be related to #103
EDIT2: For the record, these still work in Chromium 94

Fix also pushed to flems.io 🙂


Update Creating-Tenants-from-Companies.md

This pull request covers defect 362975. It adds a note that the  Windows PowerShell Script to Create Tenants from Companies approach doesn't work when db is on Azure SQL Database.

Docs Build status updates of commit 8ce212f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-nav/Creating-Tenants-from-Companies.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 60e58fd:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed]

Cannot sync git repo to specified commit because branch bug362976-movecompany has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/bug362976-movecompany

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Update bind.go

UA changes
Pull Request Template
Prerequisites

If there is no issue related to your pull request - open one and assign yourself to it. If you're proposing a solution to an already opened issue - simply assign yourself to it.

Motivation
Describe the problem you're trying to solve or the feature you're proposing in addition to a link to the related issue.
Approach
How does this change address the problem?
Pull Request status
Use checklists as a means to represent the status of your Pull Request.
For example:

[x] Initial implementation
[ ] Refactoring
[ ] Unit tests
[ ] Integration tests

Feel free to construct the checklist with whatever items seem most reasonable for your change. You could disassemble the Implementation part to even smaller separate checklist items if you're working on something big for example. But do make the effort to provide a checklist of some sort so that the core team as well as the community can have an idea about the progress of your Pull Request.
Third-party code
If you use third party code with your contribution such as, components, libraries, or snippets make sure to mention that.
Make sure that your contribution complies with our Contribution guidelines.
Work in Progress label
For as long as development of your Pull Request is still ongoing you MUST label it with a wip label as well as prefix the name of the PR with [WIP].
For example: [WIP] Aggregated Catalog API

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


add option for station model display

as a user who would like to maximize their available space, i would like to have an option for station model plot as the display as it is compact and (after a little learning) easy to read in a single glance.

@ClariNerd617 Henry, it is an interesting feature.
Do you mean that it should be just printed in the console like that?
Something like a new additional output format or view?
Do we have all necessary unicode symbols for that?

If we don't have the unicode symbols, I'm sure it can be accomplished with ascii art or something similar. An optional output for those of us who like/prefer minimalism.

That is in interesting idea; do you maybe have some drafts? If we do it in ASCII, what do you think,
how this should look like? What width and height should it have?


Several UX quirks and potential improvements

First of all, congrats for launching this awesome project! Here's some UX issues I've met during testing:
Dragging the canvas causes undesired text selection
https://github.com/user-attachments/assets/8e3c4732-f756-47bb-99c5-7c86cf799337

Some elements overlap on others

Potentially improvable zooming Currently, the zooming functionality is anchored at the top-left corner. To enhance the user experience, this behavior may be updated to center around the user's cursor instead.

Thanks @hsfzxjy I will making some tests

@hsfzxjy the text selection was fixed, I was not able to replicate the overlapping issue, is there a way you can share the JSON you are testing? We are not storing any data and it's not posible to replicate if something is broken. Thanks.

The JSON samples are as follows
{
    "catalog": {
        "version": "1.2",
        "lastUpdated": "2024-11-25",
        "products": [
            {
                "id": "P12345",
                "name": "SuperWidget",
                "category": "widgets",
                "price": 299.99,
                "currency": "USD",
                "stock": {
                    "available": 150,
                    "reserved": 25,
                    "warehouse": {
                        "location": "Warehouse A",
                        "address": "123 Industrial Rd, Tech City, USA"
                    }
                },
                "description": "An advanced widget for professionals.",
                "tags": [
                    "technology",
                    "gadgets",
                    "tools"
                ],
                "reviews": {
                    "averageRating": 4.7,
                    "totalReviews": 1325,
                    "reviewDetails": [
                        {
                            "userId": "user_001",
                            "rating": 5,
                            "comment": "This widget is amazing!",
                            "date": "2024-11-10",
                            "helpfulVotes": 35
                        },
                        {
                            "userId": "user_002",
                            "rating": 4,
                            "comment": "Great, but could be a bit cheaper.",
                            "date": "2024-11-15",
                            "helpfulVotes": 20
                        }
                    ]
                },
                "variants": [
                    {
                        "color": "black",
                        "size": "large",
                        "sku": "P12345-BL-L",
                        "price": 299.99
                    },
                    {
                        "color": "white",
                        "size": "small",
                        "sku": "P12345-WH-S",
                        "price": 279.99
                    }
                ],
                "shipping": {
                    "dimensions": {
                        "length": 12.5,
                        "width": 8.5,
                        "height": 3.5,
                        "unit": "inches"
                    },
                    "weight": {
                        "value": 2.5,
                        "unit": "lbs"
                    },
                    "freeShipping": true,
                    "internationalShipping": {
                        "available": true,
                        "regions": [
                            "Europe",
                            "Asia",
                            "North America"
                        ],
                        "shippingCosts": {
                            "Europe": 25.0,
                            "Asia": 30.0,
                            "North America": 20.0
                        }
                    }
                },
                "supplier": {
                    "id": "S1234",
                    "name": "Widget Co.",
                    "contact": {
                        "name": "John Doe",
                        "email"<EMAIL_ADDRESS>                        "phone": "+1-800-555-1234"
                    },
                    "address": {
                        "street": "456 Commerce St",
                        "city": "Tech City",
                        "country": "USA",
                        "postalCode": "12345"
                    }
                }
            },
            {
                "id": "P67890",
                "name": "MegaGizmo",
                "category": "gizmos",
                "price": 499.99,
                "currency": "USD",
                "stock": {
                    "available": 85,
                    "reserved": 10,
                    "warehouse": {
                        "location": "Warehouse B",
                        "address": "789 Commerce Rd, Tech City, USA"
                    }
                },
                "description": "A powerful gizmo for creative professionals.",
                "tags": [
                    "electronics",
                    "tools",
                    "creative"
                ],
                "reviews": {
                    "averageRating": 4.2,
                    "totalReviews": 987,
                    "reviewDetails": [
                        {
                            "userId": "user_003",
                            "rating": 4,
                            "comment": "Great performance, but a bit bulky.",
                            "date": "2024-10-20",
                            "helpfulVotes": 45
                        },
                        {
                            "userId": "user_004",
                            "rating": 3,
                            "comment": "Not as portable as I expected.",
                            "date": "2024-10-25",
                            "helpfulVotes": 12
                        }
                    ]
                },
                "variants": [
                    {
                        "color": "red",
                        "size": "medium",
                        "sku": "P67890-RD-M",
                        "price": 499.99
                    },
                    {
                        "color": "blue",
                        "size": "large",
                        "sku": "P67890-BL-L",
                        "price": 479.99
                    }
                ],
                "shipping": {
                    "dimensions": {
                        "length": 15.0,
                        "width": 10.0,
                        "height": 5.0,
                        "unit": "inches"
                    },
                    "weight": {
                        "value": 4.0,
                        "unit": "lbs"
                    },
                    "freeShipping": false,
                    "internationalShipping": {
                        "available": true,
                        "regions": [
                            "North America",
                            "Europe"
                        ],
                        "shippingCosts": {
                            "Europe": 30.0,
                            "North America": 25.0
                        }
                    }
                },
                "supplier": {
                    "id": "S5678",
                    "name": "Gizmo Tech Ltd.",
                    "contact": {
                        "name": "Alice Smith",
                        "email"<EMAIL_ADDRESS>                        "phone": "+1-800-555-5678"
                    },
                    "address": {
                        "street": "123 Innovation Blvd",
                        "city": "Tech City",
                        "country": "USA",
                        "postalCode": "67890"
                    }
                }
            }
        ],
        "meta": {
            "totalProducts": 2,
            "totalCategories": 2,
            "categories": [
                {
                    "name": "widgets",
                    "id": "cat_wg_001",
                    "totalProducts": 1
                },
                {
                    "name": "gizmos",
                    "id": "cat_gz_001",
                    "totalProducts": 1
                }
            ]
        }
    }
}


Fix for CSS selector op

CSS selector operation now works in a web worker. Fixes #218
Using the nwmatcher library along with xmldom because xmldom does not support querySelectorAll. The nwmatcher library contains a method called select which is roughly functionally equivalent.

I've also added tests for the 'CSS selector' and 'XPath expression' operations so that we spot if they stop working.


e2e: retry when a pod does not have a host assigned (yet)

Errors like "pod nfs-820 does not have a host assigned" seem to get
reported when a Pod is not completely started yet, or was restarted
while trying to access it.
Reported: https://github.com/ceph/ceph-csi/pull/4656#issuecomment-2151794926

@mergifyio rebase

@mergifyio queue


gotrue-supabase: 2.44.0 -> 2.47.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/supabase/gotrue/releases.
meta.description for gotrue-supabase is: A JWT based API for managing users and issuing JWT tokens
meta.homepage for gotrue-supabase is: https://github.com/supabase/gotrue
meta.changelog for gotrue-supabase is: https://github.com/supabase/gotrue/releases/tag/v2.45.0
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.45.0 in filename of file in /nix/store/x5cvnsbs7pswbxmq9hd7csaf4hs64n4m-gotrue-2.45.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
gotrue-supabase

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/x5cvnsbs7pswbxmq9hd7csaf4hs64n4m-gotrue-2.45.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gotrue-supabase https://github.com/r-ryantm/nixpkgs/archive/68bba870ffc52ddc78b79cc348a46b391573fa72.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/x5cvnsbs7pswbxmq9hd7csaf4hs64n4m-gotrue-2.45.0
ls -la /nix/store/x5cvnsbs7pswbxmq9hd7csaf4hs64n4m-gotrue-2.45.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

gotrue-supabase

Maintainer pings
cc @urandom2 for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/supabase/gotrue/releases.
meta.description for gotrue-supabase is: A JWT based API for managing users and issuing JWT tokens
meta.homepage for gotrue-supabase is: https://github.com/supabase/gotrue
meta.changelog for gotrue-supabase is: https://github.com/supabase/gotrue/releases/tag/v2.47.0
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.47.0 in filename of file in /nix/store/snammkwddvh6ara13gfhwpbhcks4vlxk-gotrue-2.47.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
gotrue-supabase

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/snammkwddvh6ara13gfhwpbhcks4vlxk-gotrue-2.47.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gotrue-supabase https://github.com/r-ryantm/nixpkgs/archive/04d6a0d7be798149ebe1292fc0f39b324c635ddc.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/snammkwddvh6ara13gfhwpbhcks4vlxk-gotrue-2.47.0
ls -la /nix/store/snammkwddvh6ara13gfhwpbhcks4vlxk-gotrue-2.47.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

gotrue-supabase

Maintainer pings
cc @urandom2 for testing.

Closed by #215646.


fix: on-demand release

Coverage remained the same at 100.0% when pulling fa650d7aeb213ed6ccb748d7f54c52129fa87654 on fix-on-demand-release into 9f89fe06eb1126125b408ce08dc1d7067db4e16a on main.

:tada: This PR is included in version 1.2.31 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Allow retrieving progress in write_bin_to_flash()

Currently write_bin_to_flash() does all its own printing and the progress is internal. I use espflash as a library with my own flashing application on top of it and it's currently impossible to retrieve the current flash progress from it. Could you perhaps change the function to take a FnMut that could be used to set the progress if desired?

Thanks for opening this issue, this was actually a pretty major oversight on my behalf and should be dealt with prior to the v2.0.0 release. Really indicatif should be gated behind the cli feature, and shouldn't be pulled in at all if being used as a library.
I'm happy to do the leg work to get this done, but if you don't mind how would you like to see the API looking for this exactly? I'm not entirely sure how to go about this, as while I can thread through a callback to set the progress, don't know how to get the total size out as well, unless the callback just takes both values each invocation. The total number of chunks is calculated in the same function as the segment is written in (write_segment).

I don't really see an issue with giving the callback the total size as well.

Okay I'll do that then, just wanted to make sure that would work on your end. Thanks!


[CI] Improve Maven repository caching in Pulsar CI / GitHub Actions

Motivation
Maven repository caching has several issues in Pulsar CI:

caching doesn't work for dependencies of a build that builds all modules if a cache entry has been published
from a build that was built for core-modules

the GitHub Actions cache restores the complete ~/m2/repository directory for a cache key at once
and doesn't do lookups for individual files.

cache step is run for document only changes. This might lead to an empty cache entry when the document build updates the cache entry.

Pulsar build artifacts in ~/.m2/repository/org/apache/pulsar get cached. This consumes unnecessary bandwidth and could lead to surprises unless every build rebuilds all Pulsar libraries. It's better to exclude the files from the Maven dependency cache entries since they aren't needed there.

A pull request build cannot update the cache of the upstream repository. Pull requests have a cache in the context of the fork of the upstream repository.  A pull request build will lookup cache entries from the cache of the upstream repository in the case that a cache entry is missing in the pull request source repository's cache. To reduce cache misses for pull request builds, it is necessary that the  caches in the upstream repository are up-to-date. This pull request adds a scheduled workflow to keep the maven dependency caches up-to-date.
When the cache is up-to-date, it will reduce the build times significantly.
This is the duration of downloading dependencies in an experiment running on GitHub Actions:

8 minutes 23 seconds for downloading dependencies for all modules
13 minutes 6 seconds  for downloading dependencies for all modules on MacOS
2 minutes 57 seconds for downloading dependencies for core-modules profile
Restoring the dependencies from the cache is fast. 24 seconds for all modules, 31 seconds for all modules on MacOS and 7 seconds for core-modules (durations are from an experiment where caches are restored).

Modifications

exclude ~/.m2/repository/org/apache/pulsar from caching since

exclude syntax needs special care. The exclusion pattern must  be defined at the same sub-directory level as the inclusion pattern. this is explained as a workaround in actions/cache issue 364

use separate caches for builds that build only the core-modules and other builds that build all modules

skip cache steps when there are document-only changes

remove the unnecessary build container used for running some unit tests.

add ci-maven-cache-update.yaml workflow that gets triggered for every push to master branch and also runs every 12 hours to keep dependencies up-to-date.

for pushes to master branch, the job will only run if there's a change to a pom.xml file
scheduled job will update the cache unless the cache entry for maven dependencies already exists.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@sijie @aahmed-se @merlimat please review

/pulsarbot run-failure-checks

@zymap @codelipenghui please review, thanks!

I checked a few builds to see the impact of this change. it indeed reduces the build time of integration test builds by about 8 minutes. The build time was around 23 minutes without this change and about 15 minutes after the cache was in place.
For core-modules builds (unit test builds), I'm expecting a reduction less than 3 minutes.


HHH-18461 Fix native query doesn't respect query.setFirstResult(0)

Align to JPQL query, generated sql should contain offset ? rows and pass 0 as parameter.

[Please describe here what your change is about]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

https://hibernate.atlassian.net/browse/HHH-18461

https://hibernate.atlassian.net/browse/HHH-18461

Comment from @beikov :

We don't want to treat the 0 value specially, since the presence of the offset clause regardless of the value that is bound for that parameter potentially does have an effect on query planning. So it's up to the user to call or not call setFirstResult() to control whether the offset clause should be rendered or not.

Fine, then I'll let Christian make the call on this. To me it seems weird to change the SQL that was handwritten by the user if we don't absolutely need to, but whatever, it's fine.

@beikov Please make the call.


Real world usage of omit is now awkward

I think the types of omit have been strengthened recently as (since minor upgrades to v0.29) I have a number of type errors that are flagged, especially for omit.
If you have a function signature, you may omit certain object keys in the sense, "I'm only interested in a subtype". This allows, say, unit tests to be more minimal and aligns with the principle of least knowledge. But in usage, the omitted keys may be present and you may want to acknowledge this in the implementation.
I'm not sure this is the most minimal example, but I hope shows what I mean:
import R from "ramda";

export interface Params {
    foo: string;
    bar?: string;
}

export function fn1(f: typeof fn2) {
    return (params: Omit<Params, "bar">) => {
        // imagine this omission is an important use case
        return f(R.omit(["bar"] as const, params)); // TS2322
    };
}

function fn2({ foo, bar }: Params): boolean {
    return false;
}

const a: Params = {foo: "foo", bar: "bar"};

fn1(fn2)(a);

See also TS Playground link
In other words, I would expect seemingly unrelated keys not to be a type error. I can probably work around this by creating my own omit implementation, but this goes against the spirit of ramda being a useful multi-tool library when I can't actually use it in a multitude of cases.
I can already hear gnashing of teeth, because probably someone has worked hard to add the new types. Of course, I can see the opposite argument that the strong typing will flag up potential typos.

There is also a confusing type error generated which suggests that both foo and bar are missing from the f() argument. I can see how this might happen but it may confuse anyone trying to debug the omit call. "params clearly has foo, wtf?"

Reviewing your TS Playground, the types for Omit<> seem to be working as intended
Let's examine it:
import R from "ramda";

export interface Params {
    foo: string;
    bar: string;
}

export function fn1(f: typeof fn2) {
    return (params: Omit<Params, "bar">) => {
        return f(R.omit(["bar"] as const, params));
    };
}

function fn2({ foo, bar }: Params): boolean {
    return false;
}

const a: Params = {foo: "foo", bar: "bar"};

fn1(fn2)(a);

The error you're getting is in fn1
export function fn1(f: typeof fn2) {
    return (params: Omit<Params, "bar">) => {
        return f(R.omit(["bar"] as const, params)); // Error: see below
    };
}

The error:
Argument of type 'Omit<Omit<Params, "bar">, "foo">' is not assignable to parameter of type 'Params'.
   Why is complaining about Omit<~, "foo">? "foo" is not in the type or the const array. And that it's missing prop foo' at all? I don't think that issue is Ramda, I think the problem is that because you have params: Omit<Params, "bar">types that way, trying to thenomit(["bar"] as const, params` from a variable that doesn't have prop "bar" is confusing typescript
This segways me into part 2 here. The typings for fn1 don't match the intention of the function body
export function fn1(f: typeof fn2) {
    return (params: Omit<Params, "bar">) => {
        return f(R.omit(["bar"] as const, params));
    };
}

params: Omit<Params, "bar"> is saying "params is typeof Params, with prop bar removed. But in  the body you're R.omit(["bar"] as const, params). So whouldn't it just be params: Params?
export function fn1(f: typeof fn2) {
    return (params: Params) => {
        return f(R.omit(["bar"] as const, params)); // still Error, but better
    };
}

The error:
Argument of type 'Omit<Params, "bar">' is not assignable to parameter of type 'Params'.
  Property 'bar' is missing in type 'Omit<Params, "bar">' but required in type 'Params'.

Now we get the error that I'm expecting, with no mention of foo.
Why are we getting this error? That's simple. f is typeof f2. And f2 is defined as
function fn2({ foo, bar }: Params): boolean {
    return false;
}

fn2 is expecting an argument of type Params, but fn1 is passing it a type Omit<Params, "bar">. This is type safety YOU WANT! It's type guarding exactly like it should be. And is no different from if you did this:
fn2({ foo: '' });
// ^^ Error:
Argument of type '{ foo: string; }' is not assignable to parameter of type 'Params'.
  Property 'bar' is missing in type '{ foo: string; }' but required in type 'Params'.

Without this error, you may get a runtime error when trying to access a method on bar, or anything else with it, because it's undefined and not string
You mentioned unit tests. If your goal is to test how the runtime behavior deals with missing props, then casting the type in your test is the appropriate solution to get around this type guard error
export function fn1(f: typeof fn2) {
    return (params: Params) => {
       // test `f` is it unexpectedly receives `Omit<Params, 'bar'>` instead of `Params`
        return f(R.omit(["bar"] as const, params) as Params);
    };
}

If at runtime the prop bar is generally expected to be possibly undefined, then the typeof Params should reflect that
type Params {
  foo: string;
  bar?: string // now optional
};

I'm making a lot of assumption based solely off that simple playground example, as well as how you mentioned Unit tests. So I'm hoping I'm not way off base with my assertions against your issues. Please let me know if I am and we can work on making some better examples in the TS Playground to see where the changes to the types for omit break down for you

For me, the argument on why omit should accept any key is pretty simple: it should align with TypeScript's Omit. Omit doesn't care about keys, why should Ramda's types? In this case, I think R.omit should mirror TypeScript's own Omit:
type Foo = {x: string, y: string}
type WithoutZ = Omit<Foo, 'z'> // this works just fine

const foo = {x: "this is X", y: "this is Y"}

R.omit('z', {foo: 'value'}) // this should work too and the return value should be equivalent to WithoutZ

TypeScript types are loose, so the objects that match a type with keys x, and y could also contain key z. I think it's fair that some code might want to make sure that a certain key is absent from an object:
type Foo = {x: string, y: string}

const fooInstance = // data fetched from somewhere else, parsed using zod, manipulated along a tranformation pipeline, you name it

function sendFooToExternalService(foo: Foo) {
  send(R.omit('someKeyThatMightHaveBeenAddedAlongTheWay', foo))
}

The argument for not accepting unknown keys is to avoid typos. Maybe I really meant to omit y in the above code, but made a typo and omitted z instead. It's a tradeoff and I understand that different people may take different sides. My personal take is:

I think ramda's omit should align with TypeScript's Omit
I get more value from being able to manipulate data freely than from checking for typos.

The argument for not accepting unknown keys is to avoid typos. Maybe I really meant to omit y in the above code, but made a typo and omitted z instead. It's a tradeoff and I understand that different people may take different sides.

IMHO It's better to be strict and allow you to opt-out of that strictness, than remove it altogether. You can always get around this by // @ts-expect-error or by casting to Record<string, Whatever>

It did occur to me that ValueOfUnion<> is needed to correctly support all available keys of union types. I'll try and get that in soon

Also, while Omit<> doesn't care about the keys, Pick<> does
And you look at the implementation of Pick, ten look at how Omit is implemented as a function of Pick, the fact that it doesn't care about the keys is a bug. It likely should care.


Sample flow broken for image-v3

In the image-v3 sample, the flow looks to be broken because of a missing step to add an IAM role.
Prior to the step "Deploy filter service" it looks like a role needs to be added to the service account. This command seemed to fix it for me:

gcloud projects add-iam-policy-binding $PROJECT_ID
--member=serviceAccount:[service account id]
--role=roles/artifactregistry.reader

Thanks for reporting @russellpwirtz. I tried to deploy on a new project under no organizatoin and as the owner of the project and it worked for me without adding that role:
gcloud functions deploy $SERVICE_NAME \
  --gen2 \
  --allow-unauthenticated \
  --runtime dotnet3 \
  --trigger-http \
  --region=$REGION \
  --entry-point Filter.Function \
  --set-build-env-vars GOOGLE_BUILDABLE=image-v3/filter/csharp
Preparing function...done.
X Deploying function...
    [Build] Logs are available at [https://console.cloud.google.com/cloud-build
  /builds;region=us-central1/8bc52402-3424-465a-8cb9-9adb2c94b4a1?project=84249
  832105]
  ✓ [Service]
  . [ArtifactRegistry]
  . [Healthcheck]
  . [Triggercheck]
Completed with warnings:
  [WARNING] Not deleting folder: /workspace/bin
You can view your function in the Cloud Console here: https://console.cloud.google.com/functions/details/us-central1/filter?project=image-processing-wed

buildConfig:
  build: projects/84249832105/locations/us-central1/builds/8bc52402-3424-465a-8cb9-9adb2c94b4a1
  entryPoint: Filter.Function
  environmentVariables:
    GOOGLE_BUILDABLE: image-v3/filter/csharp
  runtime: dotnet3
  source:
    storageSource:
      bucket: gcf-v2-sources-84249832105-us-central1
      object: filter/function-source.zip
  sourceProvenance:
    resolvedStorageSource:
      bucket: gcf-v2-sources-84249832105-us-central1
      generation: '1668599683669204'
      object: filter/function-source.zip
environment: GEN_2
labels:
  deployment-tool: cli-gcloud
name: projects/image-processing-wed/locations/us-central1/functions/filter
serviceConfig:
  allTrafficOnLatestRevision: true
  availableMemory: 256M
  ingressSettings: ALLOW_ALL
  maxInstanceCount: 100
  revision: filter-00001-loh
  service: projects/image-processing-wed/locations/us-central1/services/filter
  serviceAccountEmail<EMAIL_ADDRESS>  timeoutSeconds: 60
  uri: https://filter-tibqghsvsq-uc.a.run.app
state: ACTIVE
updateTime: '2022-11-16T11:56:35.319285198Z'

Please let me know which might be different in your case?

@meteatamel Ah it's possible my existing setup caused this if you're seeing no issues on a fresh deploy.
Here are the logs FWIW:
(base) russ@Russs-MacBook-Pro processing-pipelines % SERVICE_NAME=filter
% gcloud functions deploy $SERVICE_NAME
--gen2
--allow-unauthenticated
--runtime dotnet3
--trigger-http
--region=$REGION
--entry-point Filter.Function
--set-build-env-vars GOOGLE_BUILDABLE=image-v3/filter/csharp
Preparing function...done.
X Deploying function...
. [Build]
✓ [Service]
. [ArtifactRegistry]
. [Healthcheck]
. [Triggercheck]
Failed.
ERROR: (gcloud.functions.deploy) OperationError: code=7, message=Unable to retrieve the repository metadata for projects/eventarc-samples-01/locations/us-central1/repositories/gcf-artifacts. Ensure that the Cloud Functions service account has 'artifactregistry.repositories.list' and 'artifactregistry.repositories.get' permissions. You can add the permissions by granting the role 'roles/artifactregistry.reader'.
% gcloud projects add-iam-policy-binding eventarc-samples-01
<EMAIL_ADDRESS>--role=roles/artifactregistry.reader
Updated IAM policy for project [eventarc-samples-01].
% SERVICE_NAME=filter
gcloud functions deploy $SERVICE_NAME
--gen2
--allow-unauthenticated
--runtime dotnet3
--trigger-http
--region=$REGION
--entry-point Filter.Function
--set-build-env-vars GOOGLE_BUILDABLE=image-v3/filter/csharp
Preparing function...done.
X Updating function (may take a while)...
[Build] Logs are available at [https://console.cloud.google.com/cloud-build/builds;region=us-central1/[redacted]
[Service]
. [ArtifactRegistry]
. [Healthcheck]
. [Triggercheck]
Completed with warnings:
[WARNING] Not deleting folder: /workspace/bin


update(database.js) prevent mutation of referenced object during password hashing

Changed password hashing to assign the hashed value to a scoped variable instead of mutating the original user object (which is passed by reference). In JavaScript, objects are passed by reference, meaning any modifications to the object inside a function affect the original object. In the previous implementation, the user.password field was being replaced with the hashed version, which could cause issues in subsequent calls. For example, if you used the same user object in both addUser and getUser, getUser would receive the already hashed password, leading to incorrect behavior or errors, especially if user.password was declared as const. This change prevents such unintended side effects.

I also fixed the docs as suggest.


⚠ Processors has degraded performance

In d9c2f6f, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 67 ms

Resolved: Processors performance has improved in da1531c.


Add comments to the resolv.conf file.

It can be confusing when you use the --dns x.x.x.x option on a container, to find it has not been added to resolv.conf
This is true for example, when you use the Macvlan network driver.  --dns is added to the Docker DNS server, and not resolv.conf.
I would suggest we see something like:
# --dns x.x.x.x has been added to Dockers internal DNS server
namserver <IP_ADDRESS>
options ndots:0

or where no override setting made.
# File set by Docker for the internal DNS server
namserver <IP_ADDRESS>
options ndots:0

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:logicethos/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

I agree this is confusing, however I'm not sure this is the right approach, particularly because this is just a library that could be consumed by anyone, as well as the --dns flag is specific to the docker CLI.
Maybe more generic like "if a custom dns setting was requested, it will be used by the internal DNS server" (or something to that affect).

You can do so by simply doing git commit -s --amend --no-edit on your branch and re-push.

This patch adds a comment field.  It's up to the calling code to set it or leave it empty.
Given golang doesn't support optional parameters, it's a breaking change.
A generic message would work, especially if it points to documentation.  It's a misunderstanding that  comes up a lot in the forums/issues.  AFAIK And there is no way to "inspect" the docker dns server from the command line to see what it's doing on a per-container bases.

Will be carried by https://github.com/moby/moby/pull/47041


Effective Engineer

https://gist.github.com/rondy/af1dee1d28c02e9a225ae55da2674a6f
http://www.theeffectiveengineer.com/

This made my day


Adding new images for conformance tests

What type of PR is this?
/kind cleanup
/area conformance
What this PR does / why we need it:
This is the follow up from #2447 and should unblock https://github.com/kubernetes-sigs/gateway-api/pull/2254.
Does this PR introduce a user-facing change?:
NONE

/cc @frankbu @SRodi

/lgtm
/approve


Correct versionFromGit for builds

Set SOURCE_GIT_TAG to cause builds to get the proper versionFromGit
tag corresponding to what would show up in OperatorHub.
For "normal" bulids (OSD, OperatorHub) this results in the first log line for hive-operator and hive-controllers looking like:
time="2022-04-29T19:59:37Z" level=info msg="Version: openshift/hive v1.2.3606-aca223c"

For local builds on commits not tracking master you might see something like:
time="2022-04-29T19:51:08Z" level=info msg="Version: openshift/hive vUnknownBranch.3509-13b0fbf"

i.e. UnknownBranch instead of a {major}.{minor}. However, the commit count and sha should still be accurate.
HIVE-1717

/assign @abutcher

Copied hack/version.py to the master branch to test version matches current operator hub (v1.2.3606-2544e8a).
/lgtm

So yeah, this didn't work for OSD. On hives02ue1:
[efried@efried hive]$ oc logs -n hive deploy/hive-operator | head -1
time="2022-05-03T21:15:42Z" level=info msg="Version: openshift/hive v"

Need to look into the appsre build logs first to figure out what went wrong.

FUP to fix: #1759.


Mat1356 measure bundle used resources

https://jira.cms.gov/browse/MAT-1356
Required for https://github.com/projecttacoma/cqm-parsers/pull/96
Adds instance method to FHIR::Library that contains the logic for extracting data from that library's dataRequirement associated FHIR::ValueSet to build CQM::DataElements

 Here is an overview of what got changed by this pull request:

Clones added
============
- spec/fhir/mongoid/library_spec.rb  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 12

Clones added
============
- spec/fhir/mongoid/library_spec.rb  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 6

Clones added
============
- spec/fhir/mongoid/library_spec.rb  2

See the complete overview on Codacy


Spark version matrix

Review how to publish doric according to the spark version.
Check dependencies for all versions.

[x] Sbt change to allow multiple versions (#184)
[x] Github actions matrix (#187)
[x] ~Dependabot for multiple versions?~ (should not affect)

Sadly spark 2.4 won't be built against due to problems with dependencies in scala 2.11

Hi @alfonsorr, I'm working in a project where we're tied to Scala 2.11 and Spark 2.4.7 (Cloudera 😵💫).
Doric could be a great match for a use-case and I might get some time to invest in backporting.
Do you still remember what the dependency problems you mentioned were and where you got stuck?
I have some experience with Spark plugin building and packaging (I'm one of the maintainers of https://github.com/crealytics/spark-excel/) so I might be able to pick this up.

Hi @nightscape . You are one of the first postings in our repo. We are so happy 😄 Any help is welcome.
Yeah, we wanted to do a fast cross spark version of doric and didn't want to change first a lot of code, we wanted to migrate also to 2.4 but required a little more work than expected.
There are 3 dependencies that give some problems, and I suggest that what we should do with them are:

Newtype doesn't have a version for 2.11, but we can get rid of it and change it to a case class where it is used.
spark daria we can check if the versions published for 2.11 have all the logic we need, if not we should replace with something custom-made.
cats was the main reason that I didn't make in this first iteration of the porting to spark 2.4, I've changed the dependency to 2.0.0 (last 2.11 published) and started to pop a lot of import errors and didn't want to change it so much. But I think that for what we are using it should be achievable.

We are currently trying to release the 0.0.3 this week that will be the one with cross-version from 3.0 to 3.2, but then we can check it with more time to try to port it to 2.4 at least. For the moment the changes are only in the CI files.
Feel free to create an issue if you start to do any code and we will get into also when we finish the release.


Remove Large File Copies in Notebook Aux Files

This update removes several MBs from the aux directory for notebooks by removing redundant files.

@luccareinehr Can you please review this. It sounds like your last PR broke the notebook. We need to find a way to avoid that in the future.

@msaligane It looks to be working now, I missed a file in my PR but Ali fixed it here.
Just a note: if you try running the fork's notebook right now (https://colab.research.google.com/github/alibillalhammoud/OpenFASOC/blob/main/docs/source/notebooks/temp_sense_genCollab.ipynb), it won't work because the code clones the original OpenFASOC repo, which doesn't have the change I commented above yet. But once it's merged, it should work without errors.

Also, I'm sorry because I misunderstood the notebooks concept. I thought they were intended to be run locally, but running it in Colab is just so much better. That's why I suggested some of the changes in #103.
Maybe we could add a description in examples.rst saying that the notebooks are supposed to be opened in Google Colab? Though they can be run locally, it creates loads of files in the user's already cloned repo

@luccareinehr I added a note to examples.rst as you suggested.

@luccareinehr @alibillalhammoud Guys try not changing the link of the main notebook since it is been shared with others. Also, if anything such thing is updated, make sure that it is updated inside the notebook too (the colab link). Looks good as of now but something to remember for the future.


sorry, i ues the wrong model

Which model did you use? The model for vot should be siamrpn_r50_l234_dwxcorr.

Which model did you use? The model for vot should be siamrpn_r50_l234_dwxcorr.
@StrangerZhang
this model :siamrpn_alex_dwxcorr,

Which config.yaml did you use?

@StrangerZhang
in folder pysot/experiments/siamrpn_alex_dwxcorr
I use python3.6 and pytorch1.1.0,
in VOT2018 the gap between the result i got and published in model zoo is so big

Maybe. We haven't tested 1.1 right now. But I think it's more likely you are using the wrong model. (eg. are you using otb model?).
And may I ask what GPU devices you are using? Different generation of GPU may affect the tracking results since the error is cummulated after long frames. And we are testing on 10th generation of GPU (eg. 1080TI, TITAN XP).

@lb1100 1080TI
@StrangerZhang
very very sorry to you , i used the wrong model (OTB model)    very sorry

@lb1100
the number of GPU and the batchsize will influence the result?
what is the result of  TITAN 12 G with 3 GPU  of VOT2018?

@lb1100
the number of GPU and the batchsize will influence the result?
what is the result of TITAN 12 G with 3 GPU of VOT2018 of resnet?

@lb1100
the number of GPU and the batchsize will influence the result?
what is the result of TITAN 12 G with 3 GPU of VOT2018?(old is 0.414)

You need to test on your own. We can't provide configs for every combinations. Our experiments will be conducted mainly on 8/16 1080TIs.


[Admin] Update hrefs to local repo relative links

Docs Build status updates of commit 2b6cf64:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/overview/office-add-in-availability.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Fixes map refreshing when plain color basemaps are selected

Fixes #4618.

Frontend tests were OK :+1: (details)


Generalize Gate.on_each to make it work for multi-qubit gates

Ref #4034

I'd already started this in #4236, unless you specifically wanted to take this one?

Assigning myself since this seems to collide with https://github.com/quantumlib/Cirq/pull/4236 where I'm assigned

Closing in favor of #4236.


Improve the FlushPolicyFactory to make the client can specify flush policy

As the discussions in https://github.com/facebookincubator/velox/issues/8684, Spark and Presto have different behaviors for FlushPolicy. In order to allow different clients to configure their own FlushPolicy, we have added a flushPolicy parameter in HiveInsertTableHandle. This allows different clients to set their own flushPolicy when creating a HiveInsertTableHandle.

@majetideepak @mbasmanova Can you help to review? Thanks.

@majetideepak Thanks for your review. I have resolved all your comments. Can you help to review again? Thanks.

@majetideepak @jinchengchenghh Sorry for the delay response. Resolved all your comments. Can you help to review again? Thanks for your help.

@majetideepak I apologize for the delayed response. I have resolved all your comments. Can you help to review again? Thanks.

@majetideepak Can you help to review again? Thanks.

@JkSelf This fell through. I will review this tomorrow.

@majetideepak I apologize for the late response as I was on vacation recently. I have fixed the last two comments you mentioned. Can you help to review again?

@xiaoxmeng can you take another look at this change? Thanks!

@HuamengJiang Can you help to review? Thanks.

@xiaoxmeng can you help to take a look? The PR can add the rowgroup config for parquet writter. Otherwise each file has single rowgroup.

@mbasmanova The failed CI seems not related with this PR. Can you help to review again? Thanks.

The failed CI seems not related with this PR.

@JkSelf What are the failures? Would you create GitHub issues for these?

@mbasmanova I will make another pass.

@majetideepak Resolved all your comments. Can you help to review again? Thanks.

@majetideepak @xiaoxmeng @HuamengJiang Can you help to review this PR again? Thanks for your help.

@mbasmanova @majetideepak @xiaoxmeng @HuamengJiang @rui-mo Resolved all your comments. Can you help to review again? Thanks.

@rui-mo Thanks for your review. I have resolved all your comments. Can you help to review again? Thanks.

@xiaoxmeng I have updated this PR based on your suggestions. Can you help to review again? Thanks.


Finish implementing TLB shootdown

The previous TLB shootdown implementation was not fully hooked up and was using the generic IPI mechanism to signal other cores. This is, in general, not safe, nor is it particularly efficient. This PR does the following things:
Spin-wait
Implements a spin-wait primitive for the kernel to use that allows a general "wait until condition callback returns Some, pause with a different callback" mechanism. The purpose is to allow spin-waiting (e.g. in spinlock implementation) while not blocking certain "critical" work, such as TLB invalidations. Essentially, the design of the interrupt system and TLB invalidation mechanism requires that we always try to handle invalidations even when spin waiting. There's not much getting around something like this, because in principle a shootdown could be triggered by any memory allocation, thus possibly causing a deadlock of the form:
CPU A holds the lock for the allocator
CPU B is waiting on the lock for the allocator
CPU A triggers a TLB shootdown
If the allocator lock is a spinlock, this is deadlock unless CPU B polls for TLB invalidations while waiting for the lock. If the lock is a mutex, there's no problem! But, in general, without a deep audit to ensure that a TLB shootdown will never be triggered by a CPU that holds a spinlock, we have to have a mechanism like this to prevent deadlock. And, honestly, even if we did that audit, I'd still lean towards this as it's cleaner and safer.
TLB invalidation command distribution
The code now distributes invalidation commands to other CPUs via an arch-specific mechanism. Each CPU maintains a fixed, small array of pending invalidations. When a CPU wants to enqueue an invalidation on another CPU's queue, it tries to place it in the queue using three strategies:

Try to put it in an empty slot
If no empty slots, try to merge it with an existing command that has the same target root page tables
Otherwise, merge it into the first slot (why first? see the code!)

Merge? Yes -- there's a least upper bound merge between any two invalidation commands (see the code). Consider that in the worst case, we can always just promote the existing invalidation to a full, global invalidation.
TLB invalidation command processing
When a shootdown IPI is received, or we are polling for TLB invalidations, we iterate over the pending commands in our CPU's queue, executing them. For x86, this could mean executing a global, full invalidation, in which case any future invalidations don't matter, so we just flush them. When we are done with a command, the slot in the array is cleared to None, so the sender of the shootdown can know that the command has been handled.
Waiting for ~Godot~ shootdown ack
We do have to wait for invalidations to complete, while holding the mappings lock. This is somewhat dubious as it could race with other IPIs, but we do poll for other shootdown commands while waiting. We also delay doing local invalidation command processing until after we have submitted the IPIs, as an optimization.
What about live-lock?
This is for a future PR.

Oh -- @PandaZ3D let me know if (well, if this makes sense, first) you want me to take a stab at porting this to the arm code or if you'd like to take care of it.

Oh, and I should mention, before I merge this I will complete an audit of the code for any existing spin-loops and switch them to use the new spin-wait mechanism, unless there's a good reason not to (which will be given a comment).

Oh -- @PandaZ3D let me know if (well, if this makes sense, first) you want me to take a stab at porting this to the arm code or if you'd like to take care of it.

You can take a stab at it, however, the ARM version of the kernel is lacking IPI (SGI in ARM-speak) support, or SMP boot for that matter. I think we should implement IPI/SMP support in a later PR since this requires writing some driver code.

Oh -- @PandaZ3D let me know if (well, if this makes sense, first) you want me to take a stab at porting this to the arm code or if you'd like to take care of it.

You can take a stab at it, however, the ARM version of the kernel is lacking IPI (SGI in ARM-speak) support, or SMP boot for that matter. I think we should implement IPI/SMP support in a later PR since this requires writing some driver code.

Okay! Can you open an issue to track the tasks we'll need for smp on arm? I'll leave off arm support from this for now.


Possibility to use h tags instead of role="heading" and aria-level

"When possible, use native heading mark-up directly. For example, it is preferable to use
 rather than using
"

It would be great to use semantically correct markup instead of relying on aria attributes.
Likewise,
" could just be <button>.
This is how the accordion example on w3.org is set up.

I believe this was done intentionally to avoid inheriting any styles, but I see your point.

Duplicate of #322


Doesn't search and gives error

is there anyway to fix this?

Looks like the error is happening because the script for fetching the servers hit the Roblox API rate limit (429 Too Many Requests).

I think Roblox might've updated their games API and reduced the limit. This is becoming a bigger issue with Roblox Player Server Searcher that need to retrieve all servers—like for Murder Mystery 2, which currently has around 20k servers.
I tested the current code, and it can only pull around 200-300 servers before hitting the limit. 💀
I'll fix the issue as soon as possible, but if anyone can help out in the meantime, I'd be really grateful since I'm pretty busy IRL.

I think I found the solution, but I'm tied up with other stuff right now.
I'll try to fix it when I get some free time.
Hopefully, I can finish it by the end of the week, but I'll do my best to fix it sooner.

has it been figured out?

has it been figured out?

Yes, I've figured out the solution and already fixed it since my last reply. I'll release a beta version later to test if it works for other users too before officially releasing it.

There may be some workaround with it. When it hits the API limit, try waiting for a certain time then let it fetch servers again until the user is found. Won't be as fast as before, but hey at least it works.

There may be some workaround with it. When it hits the API limit, try waiting for a certain time then let it fetch servers again until the user is found. Won't be as fast as before, but hey at least it works.

It's hard to implement because Roblox doesn't include the 'x-ratelimit-reset' in the response header, so we don't know when we can make a new request.
After some tests, it looks like Roblox sets a limit of 3 requests (300 servers) per minute, any more than that will result in a rate limit.
It takes over 30 minutes to fetch all Murder Mystery 2 servers (if the user isn't found yet).

But does it still work?

Yes, it will work if I move the fetch function to background.js and only send 3 requests per minute.
For games with a max of 5 players per server, the old method works and is much faster (I don't think there's a limit).
However, for games with more than 5 players per server, it can only fetch 300 servers per minute. So I don't think it's worth the effort to implement.

I think that may still be worth implementing, no other extension other than this works. Most people I've known with are looking for this as well, just that it doesn't work with games like you said, with many servers. But yeah, we could wait. ❤

Can someone try this v3.0.0-beta1 version , please?
In this version, if the server size is more than 5, it will fetch the Servers API every 20 seconds until it's done.
However, there's a weird bug where sometimes Roblox doesn't return all the servers when fetching, so it might not find the user's server even though the user is in the game. But most of the time, it works.

Seems like it works, raihann22. Just tested that version.
Thank you for making a useful plugin man! :)

Seems like it works, raihann22. Just tested that version.
Thank you for making a useful plugin man! :)

Thank you for letting me know it works on your PC too!
I'll close this issue. If anyone wants to request a feature, report an issue, or has questions about the 3.0.0-beta version, feel free to comment on v3.0.0-beta Thread.

Seems like it works, raihann22. Just tested that version.
Thank you for making a useful plugin man! :)

Thank you for letting me know it works on your PC too!
I'll close this issue. If anyone wants to request a feature, report an issue, or has questions about the 3.0.0-beta version, feel free to comment on v3.0.0-beta Thread.

Does it work now? I hope so, thank you for your amazing plugin


Moderator & label triggers for new labels

cc @Trenly @stephengillie
PR adds moderator triggers for:

Last-Version-Remaining
License-Blocks-Install
Scripted-Application
DriverInstall
Network-Blocker

Label trigger is added for

Last-Version-Remaining
License-Blocks-Install

Microsoft Reviewers: Open in CodeFlow

Could I also make a request for mod triggers on https://github.com/microsoft/winget-pkgs/labels/License-Blocks-Install , https://github.com/microsoft/winget-pkgs/labels/Scripted-Application , https://github.com/microsoft/winget-pkgs/labels/DriverInstall , and https://github.com/microsoft/winget-pkgs/labels/Network-Blocker
I think these are new ones @stephengillie added recently

@Trenly -
I've added the moderator triggers for the new labels. Also added a label trigger for the License-Blocks-Install. Could add for the others, but I'm not 100% sure on what triggers them and the context around those labels.
Last-Version-Remaining is removed when new commits are pushed. Didn't add for the other new ones as pipelines don't have a way to automatically re-apply them, but added option for removing them through [Policy] reset feedback


adding a stable way to define ISISROOT

The line:
ISIS_ROOT = os.environ.setdefault('ISISROOT', '/usgs/pkgs/isis3/isis')

in pysis.env is all what controls where to find ISISROOT.
I have found this very fickle in trying to make things work across several conda environments (which is now the default install for ISIS3), so I propose to add functionality to pysis.env.py to get the paths from a config file in the users' home.
Currently, this file on my side simply looks like this:
$ cat .isisroot.toml                                                                        (isis3)
ISISROOT = '/Users/klay6683/miniconda3/envs/isis3'
ISIS3DATA = '/isis3/data'

and I'm using the toml format (https://github.com/toml-lang/toml).
I'm thinking about a few approaches how this fluently could be combined with an existing os.enviroment variable, but let's discuss these details in my PR I gonna start later this week after my current meeting is over (where, of course, I needed pysis to work and it didn't ;) ).
We could also have this config file to be created after the current ISIS3 install, it's simple enough. But much more stable against environment variable manipulations caused by switching conda envs (admittedly, that's the whole idea of conda, obviously).

Should be simple enough to prefer a config over an env var (config doesn't exist, back up to use an env var). But what do you mean by "We could also have this config file to be created after the current ISIS3 install"? As in make ISIS generate a pysis config file? That is how I am understanding it which I don't think would be ideal.


Text variants for email and clipboard unicodes

Unicode has a text-selector feature where you could use the text-variant or emoji.
Twemoji does seem to respect this (for example black right triangle) but not for all characters like email and clipboard.
Demo:
https://codepen.io/anon/pen/QVLQLG

This isn't specific to the font afaik. Can you verify that both glyphs for the text and colour/emoji versions are from the same font Twemoji? What you're likely experiencing is one font is applied and falls back to alternative fonts to display the variants.
This is not always respected and seems to vary by not only browser but by platform/OS too. For example, on Linux, Chrome doesn't seem to properly support Variation Selectors all that well, whereas the support with Firefox is better, but not as good as on Android(where Chrome still seems to have trouble). It's not entirely up to the browsers either, the OS usually manages fonts and fallbacks with the browser having another abstraction over that(see Chrome's font preferences, or Firefox "about:config").
For some examples and more details, see this issue.
If you'd like to verify what fonts are being used with Firefox(which you presumably using to see some variants), you can go into the browser dev tools. For Firefox, look at the Fonts tab, near the Computed styles tab. You can roll over the fonts listed there and it should highlight where they are used in the viewport(the list might be affected by what element in the HTML inspector is currently selected).


I see a notification to upgrade to ghost 1.9.0 while running Ghost 1.9.0.

Issue Summary
I see a notification to upgrade to ghost 1.9.0 while running Ghost 1.9.0.
It's good to know that I follow Ghost update via Docker images so I don't use Ghost update.
Steps to Reproduce
click on about ghost
Any other info e.g. Why do you consider this to be a bug? What did you expect to happen instead?
Technical details:

Ghost Version: 1.9.0
Node Version: 6.2
Browser/OS: Version 61.0.3163.100 (Official Build) (64-bit)
Database: Sqlite
via the official docker container

Cheers!
Pascal

Closing as a duplicate of #9040.
This is a known issue and is being worked on as part of a larger overhaul of upgrade checks and notifications.

thanks!


Markdown documentation for tasks/projects

Motivation and context

Resolved #287
Resolved #3680
Resolved #5580
How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have added a description of my changes into the CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] I have linked related issues (see GitHub docs)
[ ] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

When I'm trying to open markdown setup guide page, an error occurs:

Do you use the latest version? There was such errors, but I fixed it

When I'm trying to open markdown setup guide page, an error occurs:

@klakhov Do you use the latest version? There was such error, but I fixed it

Yes, updating branch helped to fix that

Should edit button be on the right? Maybe use

icon instead. It would look with issue tracker.
And Task description on project page seems a bit strange. Maybe its better to be named Description for tasks or Tasks description

Should edit button be on the right? Maybe use

This is the latest design from Breeze

Task description on project page seems a bit strange

I will fix it


Small fixes

This PR backports small fixes from me and freem. The "fix missing headers" commit is especially useful as I needed it to be able to compile Daemon.

LGTM


Fixed  tag in header

There is a  tag visible in the header section aside Hello there,removed it.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes:  #(issue no.)

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have made this from my own
[ ] I have taken help from some online resourses
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@ansharora28 its not bug we have used it as design please make sure to create a issue before making a PR


Upgrade Metro dependencies to 0.76.2

Summary:
Metro release notes:  https://github.com/facebook/metro/releases/tag/v0.76.2
Changelog: [Internal]
Differential Revision: D45040347

Merged in https://github.com/facebook/react-native/pull/36948


Skip update notifier possible?

Hi, just asking, it works great with the latest 1.x version with auto connect to my xbox, but it always tells me to update. i have testet the 2.x version but want to stay at the older one as long autoconnect isnt working there.
so i ask if its possible to skip this notification maybe through commandline parameter?
thanks for the good work, great app!

Do you have the latest stable version of 1.2.0? The stable version should not notify on new beta releases. Maybe try to reinstall it again: https://github.com/unknownskl/xbox-xcloud-client/releases/tag/v1.2.0

Closing issue due inactivity


sbt: add scalastyle

Closes #60
Will do a followup PR when #73 is merged to remove all warnings and set that warnings are to be considered errors for CI purposes.

If we found some scalastyle warnings we should stop the travis job, what do you think?

Yep, when the scaladoc pr is merged i will fix all warnings and add the setting to consider warnings as errors.

Fixed all warnings and moved warnings to errors, ready to review @ajnavarro


Positioned the quotation marks correctly

Fixes:  #1717
Description
Positioned the Quotation marks correctly inside the flip card
Type of PR

[x ] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
before:

after:

Checklist:

[ x] I have made this change from my own.
[ ] I have taken help from some online resources.
[ x] My code follows the style guidelines of this project.
[x ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x ] My changes generate no new warnings.
[x ] I have tested the changes thoroughly before submitting this pull request.
[x ] I have provided relevant issue numbers and screenshots after making the changes.

Conflicting files
assets/css/style.css
assets/css/test-style.css
Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


Fix the Warning: Each child in a list should have a unique "key" prop. issue in the report package

I made this issue by accident - I clicked "Convert to Issue" in the checklist in #950


How do I add multiple animations to keyframes?

I have this spinner:
const rotate = radium.keyframes({
  '100%': {
    transform: 'rotate(360deg)'
  },
}, 'rotate');
const dash = radium.keyframes({
  '0%': {
    strokeDasharray: '1,200',
    strokeDashoffset: '0'
  },
  '50%': {
    strokeDasharray: '89,200',
    strokeDashoffset: '-35'
  },
  '100%': {
    strokeDasharray: '89,200',
    strokeDashoffset: '-124'
  },
}, 'dash');
const color = radium.keyframes({
  '100%, 0%': {
    stroke: 'red'
  },
  '40%': {
    stroke: 'blue'
  },
  '60%': {
    stroke: 'green'
  },
  '80%, 90%': {
    stroke: 'yellow'
  }
}, 'color');

  loader: {
    position: 'absolute',
    width: '100px',
    height: '100px',
    left: '50%',
    top: '20%'
  },
  circular: {
    animation: 'q 2s linear infinite',
    animationName: rotate,
    height: '100px',
    position: 'relative',
    width: '100px'
  },
  path: {
    strokeDasharray: '1,200',
    strokeDashoffset: '0',
    animation: 'dash 1.5s ease-in-out infinite, color 6s ease-in-out infinite',
    animationName: dash,
    strokeLinecap: 'round'
  }

On the path class I have two animations, one for dash and another one for color
How can I handle this with radium?

I'm also interested in how (if possible) to accomplish this.

It is currently not possible to add multiple animations.
On Fri, May 6, 2016 at 7:04 PM Sean Lynch<EMAIL_ADDRESS>wrote:

I'm also interested in how (if possible) to accomplish this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/FormidableLabs/radium/issues/675#issuecomment-217598765

And what would a quick fix be for this issue?

I'm interested too.

@Dindaleon @sassanh - I ultimately switched to styled-components, which supports multiple animations as well as passing in props when creating keyframes.  You can see an example I created here

@ianobermiller hi there, will this be ever implemented? I love radium and I like it better over others alternatives. I checked styled-components but it is not that good for my own needs.

I've made a PR to handle this, #909. Handles multiple animations by passing an array of Keyframes objects.


Unify header style for SR

Two row header looks better

Please check this issue. @Z-Fran

Closing due to inactivity, please reopen if there are any further problems.