Fix trace! args overflow

Fixes #5987

@samtay thanks for jumping in and working on this one! I don't think we can move forward with the PR as is given that this would constitute a breaking formatting change for how we handle trace!. We'd need to add a version gate for this fix.
from what I can tell we can grab a reference to the config via the overflow::Contexts context field, which is a RewriteContext.
We'd need to pass the &Config to maybe_get_args_offset so it can pass the config to special_cases.

I ran our Diff-Check Job and it failed indicating that we need to version gate these changes.

@ytmimi makes sense! Done in af4929cd3e7381dc6c1e2bba781d2787ea0a1c65. I just did the simple thing which was to return the special cases as a Vec, now that the cases are dynamic. If that is undesirable here, another option would be to have an additional static slice for v2 and chain the iterators - something like this.

@samtay thanks! I was going to suggest using chain. Could you make that change when you get a chance. Also, I think a doc comment on special_cases_v2 explaining that these are special cases that would cause breaking formatting changes for v1 would be helpful. Maybe we should define a  SPECIAL_CASE_MACROS_V2 list so in the future we don't need to modify special_cases_v2 and can instead just add to that list.

@samtay thanks for updating the code! Just running an additional job to verify that the version gated code doesn't produce the same breaking formatting changes.

Huh.. I see the diff check job failed :thinking:  Can you help me understand why that is? Don't the tests that I added demonstrate that the new trace! formatting only occurs when using version 2?

@samtay that's because I forgot to pass Version=One to your version of rustfmt. That should show that the current master and your feature branch produce the same diff for the stable version of rustfmt. Here's the link to the new job

hmmm 🤔 thinking about it a little more, passing version=One is going to potentially lead to diffs in other places outside of trace! formatting.
I guess our Diff-Check job isn't well suited for checking against changes for unstable formatting, which seems reasonable that unstable formatting might break.

I think the second Diff-Check job failing is a false alarm. After re reviewing it. All the diffs only affect how trace! is formatted, and they only affect rust-lang/rust, and miri, both of which are setting Version=Two.
Reviewing the formatting for rust-bindgen, which doesn't set a rustfmt version so it automatically defaults to Version=One shows that the version gate is working as expected.
Here's the first Diff-Check Job
running rustfmt (master) on rust-bindgen
running rustfmt (feature) on rust-bindgen
checking diff
Diff in /tmp/rust-bindgen-ZkDOAXGv/bindgen/codegen/struct_layout.rs at line 299:

         trace!(
             "need a tail padding field for {}: offset {} -> size {}",
-            comp_name,
-            self.latest_offset,
-            comp_layout.size
+            comp_name, self.latest_offset, comp_layout.size
         );
         let size = comp_layout.size - self.latest_offset;
         Some(self.padding_field(Layout::new(size, 0)))
Diff in /tmp/rust-bindgen-ZkDOAXGv/bindgen/ir/analysis/template_params.rs at line 293:
             trace!(
                 "      instantiation's argument {:?} is used if definition's \
                  parameter {:?} is used",
-                arg,
-                param
+                arg, param
             );

             if used_by_def.contains(&param.into()) {
Diff in /tmp/rust-bindgen-ZkDOAXGv/bindgen/ir/analysis/derive.rs at line 113:
         let id = id.into();
         trace!(
             "inserting {:?} can_derive<{}>={:?}",
-            id,
-            self.derive_trait,
-            can_derive
+            id, self.derive_trait, can_derive
         );

         if let CanDerive::Yes = can_derive {
Diff in /tmp/rust-bindgen-ZkDOAXGv/bindgen/ir/analysis/derive.rs at line 241:
                     trace!(
                         "    arrays of T for which we cannot derive {} \
                          also cannot derive {}",
-                        self.derive_trait,
-                        self.derive_trait
+                        self.derive_trait, self.derive_trait
                     );
                     return CanDerive::No;
                 }
Diff in /tmp/rust-bindgen-ZkDOAXGv/bindgen/ir/analysis/derive.rs at line [280](https://github.com/rust-lang/rustfmt/actions/runs/7305152074/job/19908359632#step:4:281):
                     trace!(
                         "    vectors of T for which we cannot derive {} \
                          also cannot derive {}",
-                        self.derive_trait,
-                        self.derive_trait
+                        self.derive_trait, self.derive_trait
                     );
                     return CanDerive::No;
                 }

vs the second Diff-Check job
running rustfmt (master) on rust-bindgen
running rustfmt (feature) on rust-bindgen
checking diff
no diff detected between rustfmt and the feture branch
removing tmp_dir /tmp/rust-bindgen-5v0FDg9s

Huh.. I see the diff check job failed 🤔 Can you help me understand why that is? Don't the tests that I added demonstrate that the new trace! formatting only occurs when using version 2?

Oh and to more directly answer your question, yes your tests were sufficient in showing that the version gate logic was working. We've semi-recently introduced this Diff-Check job into our PR workflow as an extra precautionary step to test the code changes out on real projects before merging. Anyway, like I said the failure was a false alarm and mostly a shortcoming of the current Diff-Check job.

@ytmimi gotcha, makes sense. Happy to help out and thanks for the guidance on this one!


tap-new: fix invalid tap name message

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Fixes #11121.

Review period will end on 2021-04-13 at 21:15:04 UTC.

Thanks again @nandahkrishna!

Review period skipped due to critical label.


Proxy support

Can't find in documentation the parameters regarding the traffic forwarding through the specified proxy server. Is it possible in current implementation?

It re-uses the variable from copilot.vim.
https://github.com/zbirenbaum/copilot.lua/blob/f7612f5af4a7d7615babf43ab1e67a2d790c13a6/lua/copilot/util.lua#L227
Here is an example config:
{
	"zbirenbaum/copilot.lua",
	cmd = "Copilot",
	event = "InsertEnter",
	config = function()
		vim.g.copilot_proxy = "http://<IP_ADDRESS>:3128"
		require("copilot").setup({})
	end,
},

Note: you have to put protocol, i.e. http into the variable. It will not work if you put <IP_ADDRESS>:3128.

The solution above didn't work for me for some reason. But I found in the copilot documentation that it respects

HTTPS_PROXY
https_proxy
HTTP_PROXY
http_proxy

So I added this alias to my .zshrc and now everything works
alias nvim='HTTP_PROXY=http://<IP_ADDRESS>:2080 nvim'


New version: hoppscotch.Hoppscotch version 24.7.0-0

Pull request has been created with WinGet Updater :rocket:
Microsoft Reviewers: Open in CodeFlow

/azp run


More tokens to strip

Hi. I'm a search engine guy, and I'm very interested in a well-tested list of strippable CGI args to reduce the work my crawler has to do. I tried to algorithmicly build a list by taking the top 1000 websites from an old Alexa list, plus a few hosts I care about, and took a sample of their URLs crawled by CommonCrawl, and then counting which cgi args appeared in many of the hosts.
The biggest was &utm_source appearing on 474 of the 1,000 hosts. I dropped everything fewer than 5 hosts. So, in theory, this is somewhat of a representative sample of the most popular ones... although CommonCrawl isn't totally representative of the web, of course.
Here is a list with examples of the ones that aren't currently in your configuration:
# more utm_ -- I think people use utm_ as a prefix for their own purposes and/or Google doesn't document all of them

# https://www.mozilla.org/en-US/firefox/new/?f=30&ref=producthunt&utm_expid=71153379-28.SNKFJ4VqRziIW1TLqjhpAw.1&utm_referrer=https%3A%2F%2Fwww.google.com%2F

utm_expid (15 hosts)
utm_referrer (12 hosts)

# https://www.etsy.com/?utm_source=google&utm_medium=cpc&utm_term=etsy&utm_campaign=search_fr_fr-fr-src-pure-brand-exact-st_exact_etsy&gclid=EAIaIQobChMIk6Duvp6\
n1QIVjantCh1f-whGEAAYASAAEgLsx_D_BwE&gclsrc=aw.ds

gclsrc 22 hosts

# https://www.google.fr/chrome/browser/features.html?brand=CHBD&gclid=CN6B2tjusdECFVAQ0wodfmcISw&dclid=CM6vjtnusdECFcSjUQodyg4B2Q

dclid 21 hosts {similar to gclid?}

normally cookies

# Adobe ColdFusion
# https://techcrunch.com/?CFID=8494701&CFTOKEN=56974155

&CFID= 25 hosts, 70 total instances
&CFTOKEN= 25 hosts, 70 total instances

# PHP
# http://instagram.com/p/BUPpEcIDFjT/?PHPSESSID=dbj4v5fl2c6sd8f8986aprqpf3

&PHPSESSID= 5 hosts, 89 total instances

and here are the popular ones that you don't have at all:

# Web Trends

# http://www.nature.com/collections/dtfkmdgglg?WT.mc_id=SFB_NA_1017_FattyLiverGraphic
# https://www.microsoft.com/en-us/store/b/accessories?tid=vpOCJmmq&cid=5250&pcrid=3050714533&pkw=makerbot%20replicator%202%20desktop%203d%20printer&pmt=e&WT.srch=1&WT.mc_id=pointitsem_Microsoft+US_bing_5+-+Accessories&WT.term=make
# https://www.chase.com/ccp/index.jsp?pg_name=ccpmapp/shared/assets/page/repayment_examples&WT.ac=st_ctr_student&jp_aid=st_ctr_student&WT.mc_id=st_ctr_student_repayment&jp_mep=st_ctr_student_repayment&WT.pn_sku=repayment_plans&memberid=studentcenter
# https://www.intuit.com/company/press-room/press-releases/2013/QuickenPullsBacktheCoversonLoveandMoney/?WT.qs_osrc=TST-164886110

&WT.mc_id= 24 hosts, 2530 total instances
&WT.srch= 14 hosts, 422 total instances
&WT.ac= 8 hosts, 4094 total instances
&WT.qs_osrc= 5 hosts, 20 total instances
&WT.pn_sku

# Oracle Eloqua

# http://www.cray.com/company/policies-and-practices/privacy-policy?elqTrackId=2e97d2d4f56e41eb9498379bab9753db&elqaid=584&elqat=2
# http://www.blackboard.com/Platforms/Collaborate/Resources/Webinars-and-Demos.aspx?elq=a318adfc3e7e40de83e0883a1d6760ba&elqCampaignId=329

&elqTrackId= 12 hosts, 191 total instances
&elqaid= 12 hosts, 189 total instances
&elqat= 12 hosts, 189 total instances
&elqCampaignId= 7 hosts, 138 total instances
&elq= 7 hosts, 111 total instances

# comScore Digital Analytix:

# http://www.dailymail.co.uk/sport/rugbyunion/article-5082539/France-23-28-New-Zealand-Blacks-French.html?ITO=1490&ns_mchannel=rss&ns_campaign=1490
# http://www.hotstar.com/tv/cineplay/13080?ns_mchannel=Article&ns_source=Scroll&ns_campaign=Cineplay&ns_linkname=CineplayShowPage&ns_fee=0

&ns_campaign= 6 hosts, 97 total instances
&ns_mchannel= 5 hosts, 92 total instances
&ns_source=
&ns_linkname=
&ns_fee=

# suspicious but probably too generic

# https://www.cray.com/?leadsource=website&srcdes=seagate&campaign=7010b0000018kLW
&campaign= 15 hosts, 9072 total instances

# https://wordpress.com/create/?utm_source=bing&utm_campaign=WordPress-Generic-Exact-US-GP&utm_medium=cpc&keyword=wordpress&creative=9925335912&campaignid=12806\
5278&adgroupid=3099786316&matchtype=e&device=c&network=o
&campaignid= 6 hosts, 74 total instances

Hi @wumpus and thanks for the issue and excellent supporting data!
Some of these look for sure like no-brainers to add to the core set of trackers to block, while others look a little more dangerous.
I'm in the midst of working on a system to allow users to add/remove their own trackers, in which case I'd be far more willing to put many of these into the defaults. If I get stalled out on that update, I'll probably just add them to a minor update when I get an hour or so to play with and test them.
If you don't see any motion on this in a week or so, please prod me. Thanks again!

Just noticed this one, a little googling says it's been around for a while, and that it's common enough that some reddit subs have banned using it:
https://www.youtube.com/attribution_link?a=dRBqlLWtf5U&u=%2Fwatch%3Fv%3Dpogq2tZFKKo%26feature%3Dshare
It's not just a token to strip, though. Normally only Amazon designs urls this poorly!


wiki: CodeReviewComments change - Standardize indentation

Some code examples are not indented properly (use spaces instead of tabs). I think we should fix them:
https://github.com/golang/go/wiki/CodeReviewComments#imports
https://github.com/golang/go/wiki/CodeReviewComments#crypto-rand
https://github.com/golang/go/wiki/CodeReviewComments#in-band-errors

Do you mean use tabs instead of spaces?  Sure, that sounds fine if it displays correctly.

Yes, we should use tabs instead of spaces

@ianlancetaylor do you want me to make the change? I can make it later today

Sure, go ahead.  Thanks.

Done. Closing this


Number of training object instances

Table 1 in the paper reports that there are 25 objects and 49 drawers in the training set of the OpenCabinetDrawer task. However, the Google Drive link only seems to contain 42 files, and not 49 -- why is this the case?
Thanks!

Sorry for not clear in the paper. For these 25 objects, we can solve at least one link on the object. We release all links over these 25 objects, so you see 49 drawers in total.
But for some links on the objects, it is not easy to get demo by state-based SAC with limited time. So we only provide partial of them. In the challenge, we only test the object link with demo for training part.

Got it, thanks!


Fix robots.txt

Unfortunately trying to comply with the robots.txt standard to the letter runs afoul of two problems, the first being that Google places a 500KB limit on the file and secondly Google seems to be thinking that the show page is also excluded from the index as well.
Switch back to using a static robots.txt and use the Google extension for wildcard matching URLs - we'll have to live with any other search engines that don't support wildcards indexing pages that we don't want them to.

Simple it is then


Follow up to #1241

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


[DOCKER] add apt update to test fixture krb5kdc

This PR adds an apt update to the krb5kdc test fixture docker file.

start gradle check

start gradle check

Hi @nknize,
Recommend using apt-get than apt due to:
WARNING: apt does not have a stable CLI interface yet. Use with caution in scripts.

apt is for terminal with beautiful outputs.
apt-get is for scripts and give stable, parsable outputs.


Building .Net Standard 2.0 Application with Hosted VS2017 Agent

When trying to use an alternative .netstandard sdk version, the dotnet restore uses the sdk version you have installed but it fails at a later point when it tries to use the Nuget.Targets file.
@bryanmacfarlane asked me to raise the issue here after creating an issue under the vsts-agent repo https://github.com/Microsoft/vsts-agent/issues/1146
2017-08-16T10:39:25.6434014Z Successfully installed .NET Core runtime version 2.0.0.

2017-08-16T10:40:40.9796157Z [command]d:\a\_tool\dncr\2.0.0\x64\dotnet.exe restore d:\a\1\s\Draycir.Tenants.WebApi\Draycir.Tenants.WebApi.csproj --configfile d:\a\1\Nuget\tempNuGet_6367.config --verbosity Detailed

2017-08-16T10:41:20.0170050Z C:\Program Files\dotnet\sdk\1.0.4\NuGet.targets(97,5): error : Project Draycir.Tenants.Domain is not compatible with netcoreapp2.0 (.NETCoreApp,Version=v2.0). Project Draycir.Tenants.Domain supports: netstandard2.0 (.NETStandard,Version=v2.0) [d:\a\1\s\Draycir.Tenants.WebApi\Draycir.Tenants.WebApi.csproj]

This is a log output from flightlevel (also in the above issue)
******************************************************************************
Starting: Restore
******************************************************************************
==============================================================================
Task         : .NET Core
Description  : Build, test, package, or publish a dotnet application, or run a custom dotnet command. For package commands, supports NuGet.org and authenticated feeds like Package Management and MyGet.
Version      : 2.0.5
Author       : Microsoft Corporation
Help         : [More Information](https://go.microsoft.com/fwlink/?linkid=832194)
==============================================================================
SYSTEMVSSCONNECTION exists true
Downloading: https://dist.nuget.org/win-x86-commandline/v4.0.0/nuget.exe
Caching tool: NuGet 4.0.0 x64
Using version: 4.0.0
Found tool in cache: NuGet 4.0.0 x64
Saving NuGet.config to a temporary config file.
Can\'t find loc string for key: NGCommon_NoSourcesFoundInConfig
NGCommon_NoSourcesFoundInConfig d:\a\1\Nuget\tempNuGet_144.config
"C:\Program Files\dotnet\dotnet.exe" restore d:\a\1\s\src\MyProject.Tests\MyProject.Tests.csproj --configfile d:\a\1\Nuget\tempNuGet_144.config --verbosity Detailed
  Restoring packages for d:\a\1\s\src\MyProject\MyProject.csproj...
  Restoring packages for d:\a\1\s\src\MyProject.Tests\MyProject.Tests.csproj...
C:\Program Files\dotnet\sdk\1.0.4\NuGet.targets(97,5): error : Unable to resolve 'Microsoft.NETCore.App (>= 2.0.0)' for '.NETCoreApp,Version=v2.0'. [d:\a\1\s\src\MyProject.Tests\MyProject.Tests.csproj]

same issue here, stucked deploying my updated website

@rmarinho - just to be clear, were you capable of deploying your 2.0 website previously?  Or was it 1.0 using vsts2017 hosted and you updated it to 2.0?  Just trying to understand your scenario.

Yap, everything was working with 1.0 the VSTS build was setup automactly from azure portal CI integration, it does a dotnet restore, dotnet build and dotnet publish .. i updated locally on my OSX to 2.0 everything works, i commit my code and the build started breaking and so then i can't deploy

Log : https://gist.github.com/rmarinho/ad9eee136a1538a0343aab1f067530c1

@rmarinho - OK, thanks.  Confirmed my suspicion, you're moving faster than the images are :)

Ah. Same here with me??
NOTE: This csproj should be targetting NETSTANDARD2_0
2017-08-16T13:55:06.5468374Z ##[section]Starting: Restore
2017-08-16T13:55:06.5634696Z ==============================================================================
2017-08-16T13:55:06.5634696Z Task         : .NET Core
2017-08-16T13:55:06.5634696Z Description  : Build, test, package, or publish a dotnet application, or run a custom dotnet command. For package commands, supports NuGet.org and authenticated feeds like Package Management and MyGet.
2017-08-16T13:55:06.5634696Z Version      : 2.0.5
2017-08-16T13:55:06.5634696Z Author       : Microsoft Corporation
2017-08-16T13:55:06.5634696Z Help         : [More Information](https://go.microsoft.com/fwlink/?linkid=832194)
2017-08-16T13:55:06.5634696Z ==============================================================================
2017-08-16T13:55:09.2068874Z SYSTEMVSSCONNECTION exists true
2017-08-16T13:55:09.5608318Z Downloading: https://dist.nuget.org/win-x86-commandline/v4.0.0/nuget.exe
2017-08-16T13:55:09.7597187Z Caching tool: NuGet 4.0.0 x64
2017-08-16T13:55:09.7877201Z Using version: 4.0.0
2017-08-16T13:55:09.7887189Z Found tool in cache: NuGet 4.0.0 x64
2017-08-16T13:55:09.7907194Z Saving NuGet.config to a temporary config file.
2017-08-16T13:55:09.8017197Z ##[warning]Can\'t find loc string for key: NGCommon_NoSourcesFoundInConfig
2017-08-16T13:55:09.8017197Z ##[warning]NGCommon_NoSourcesFoundInConfig d:\a\1\Nuget\tempNuGet_52.config
2017-08-16T13:55:09.8447208Z [command]"C:\Program Files\dotnet\dotnet.exe" restore d:\a\1\s\src\Hornet.Core\Hornet.Core.csproj --configfile d:\a\1\Nuget\tempNuGet_52.config --verbosity Detailed
2017-08-16T13:55:13.8522632Z   Restoring packages for d:\a\1\s\src\Hornet.Core\Hornet.Core.csproj...
2017-08-16T13:55:13.9280652Z C:\Program Files\dotnet\sdk\1.0.4\NuGet.targets(97,5): error : Unable to resolve 'NETStandard.Library (>= 1.6.1)' for '.NETStandard,Version=v2.0'. [d:\a\1\s\src\Hornet.Core\Hornet.Core.csproj]

Does it help if you add NuGet tool installer task up front and select version 4.1.0?

@bryanmacfarlane Hi Bryan,
We have the similar issue with our build
2017-08-17T12:41:58.0450965Z ##[section]Starting: Restore
2017-08-17T12:41:58.0450965Z ==============================================================================
2017-08-17T12:41:58.0450965Z Task         : .NET Core
2017-08-17T12:41:58.0450965Z Description  : Build, test, package, or publish a dotnet application, or run a custom dotnet command. For package commands, supports NuGet.org and authenticated feeds like Package Management and MyGet.
2017-08-17T12:41:58.0450965Z Version      : 2.0.5
2017-08-17T12:41:58.0450965Z Author       : Microsoft Corporation
2017-08-17T12:41:58.0450965Z Help         : [More Information](https://go.microsoft.com/fwlink/?linkid=832194)
2017-08-17T12:41:58.0450965Z ==============================================================================
2017-08-17T12:41:59.0281251Z SYSTEMVSSCONNECTION exists true
2017-08-17T12:41:59.0301257Z Saving NuGet.config to a temporary config file.
2017-08-17T12:41:59.0361254Z [command]d:\a\_tool\NuGet\4.1.0\x64\nuget.exe sources Add -NonInteractive -Name NuGetOrg -Source https://api.nuget.org/v3/index.json -ConfigFile d:\a\3\Nuget\tempNuGet_3735.config
2017-08-17T12:41:59.9570375Z Package Source with Name: NuGetOrg added successfully.

2017-08-17T12:42:38.4875131Z C:\Program Files\dotnet\sdk\1.0.4\NuGet.targets(97,5): error : Package Microsoft.AspNetCore 2.0.0 is not compatible with netcoreapp2.0 (.NETCoreApp,Version=v2.0). Package Microsoft.AspNetCore 2.0.0 supports: netstandard2.0 (.NETStandard,Version=v2.0) [d:\a\3\s\ESB.MiddleWare\MiddleWare.External.Platform\MiddleWare.External.Platform.csproj]
2017-08-17T12:42:38.4885106Z C:\Program Files\dotnet\sdk\1.0.4\NuGet.targets(97,5): error : Package Microsoft.Extensions.Logging 2.0.0 is not compatible with netcoreapp2.0 (.NETCoreApp,Version=v2.0). Package Microsoft.Extensions.Logging 2.0.0 supports: netstandard2.0 (.NETStandard,Version=v2.0) [d:\a\3\s\ESB.MiddleWare\MiddleWare.External.Platform\MiddleWare.External.Platform.csproj]
2017-08-17T12:42:38.4885106Z C:\Program Files\dotnet\sdk\1.0.4\NuGet.targets(97,5): error : One or more packages are incompatible with .NETCoreApp,Version=v2.0. [d:\a\3\s\ESB.MiddleWare\MiddleWare.External.Platform\MiddleWare.External.Platform.csproj]
2017-08-17T12:42:38.5415101Z   Generating MSBuild file d:\a\3\s\ESB.MiddleWare\MiddleWare.External.Platform\obj\MiddleWare.External.Platform.csproj.nuget.g.props.
2017-08-17T12:42:38.5425105Z   Generating MSBuild file d:\a\3\s\ESB.MiddleWare\MiddleWare.External.Platform\obj\MiddleWare.External.Platform.csproj.nuget.g.targets.
2017-08-17T12:42:38.5435105Z   Writing lock file to disk. Path: d:\a\3\s\ESB.MiddleWare\MiddleWare.External.Platform\obj\project.assets.json
2017-08-17T12:42:38.5665099Z   Restore failed in 7.81 sec for d:\a\3\s\ESB.MiddleWare\MiddleWare.External.Platform\MiddleWare.External.Platform.csproj.
2017-08-17T12:42:38.5677221Z
2017-08-17T12:42:38.5677221Z   Errors in d:\a\3\s\ESB.MiddleWare\MiddleWare.External.Platform\MiddleWare.External.Platform.csproj
2017-08-17T12:42:38.5677221Z       Package Microsoft.AspNetCore 2.0.0 is not compatible with netcoreapp2.0 (.NETCoreApp,Version=v2.0). Package Microsoft.AspNetCore 2.0.0 supports: netstandard2.0 (.NETStandard,Version=v2.0)
2017-08-17T12:42:38.5677221Z       Package Microsoft.Extensions.Logging 2.0.0 is not compatible with netcoreapp2.0 (.NETCoreApp,Version=v2.0). Package Microsoft.Extensions.Logging 2.0.0 supports: netstandard2.0 (.NETStandard,Version=v2.0)
2017-08-17T12:42:38.5677221Z       One or more packages are incompatible with .NETCoreApp,Version=v2.0.
2017-08-17T12:42:38.5705100Z
2017-08-17T12:42:38.5705100Z   NuGet Config files used:
2017-08-17T12:42:38.5705100Z       d:\a\3\Nuget\tempNuGet_3735.config
2017-08-17T12:42:38.5705100Z
2017-08-17T12:42:38.5705100Z   Feeds used:
2017-08-17T12:42:38.5705100Z       https://api.nuget.org/v3/index.json
2017-08-17T12:42:38.5805112Z
2017-08-17T12:42:38.5805112Z   Installed:
2017-08-17T12:42:38.5815106Z       11 package(s) to d:\a\3\s\ESB.MiddleWare\MiddleWare.External.Platform\MiddleWare.External.Platform.csproj
2017-08-17T12:42:38.6115102Z ##[error]Error: d:\a\_tool\dncr\2.0.0\x64\dotnet.exe failed with return code: 1
2017-08-17T12:42:38.6115102Z ##[error]Packages failed to restore
2017-08-17T12:42:38.6145100Z ##[section]Finishing: Restore

@bryanmacfarlane Just tried it and it didn't work https://gist.github.com/chris31389/85f1abfa5d2c8802c6274b32fa9f6095

Had this issue after upgrading a project from 1.1 to 2.0.
Fixed it by adding a ".NET Core Tool Installer" task at the beginning of the build and specifying "2.0.0" as the version.

Looks like 2.0 is not installed on all the build images yet.

@chrispoulter That worked! I didn't realise there was a dropdown where I had to select the SDK.  All this time I had been running the tool installer installing just the runtime.
Thanks for your help @bryanmacfarlane

NP!  We will get that fixed where SDK is the default.  This is the "tool" installer :)

@bryanmacfarlane, @chrispoulter Thanks for your help!  That worked for us too

Above advice allowed me to get further along thank you, but was still getting weird (to me) NuGet issues
Found this which got me going! Might help someone else https://stackoverflow.com/questions/45717283/vsts-build-packages-failed-to-restore-unable-to-resolve-netstandard-library

i thought this was going to be fixed last week with new image of Hosted 2017 ?!

We started rolling late last week.  By EOD it will be in 3 of 4 rings.


TMLE prediction models with ML

To allows for sklearn ML to generate predictions (or whatever the user would like, i.e. SuPyLearner), the model statement should allow fitted ML models. Due to how sklearn runs predictions (NumPy arrays), I might need to learn patsy to pull out the correct variables from a pandas dataframe

Alright one issue is that sklearn uses the following format; model.fit(X, y) while statsmodels uses model.predict(y, X). Since I want users to be able to use whatever model in TMLE (like homebrew SuPyLearner), this causes an issue.
Some potential solutions:

have the user feed in a fitted model, with the prediction function, like fitted.predict(...). This avoids any issues on my end. Essentially all models are run outside of TMLE in this case. Which might be preferable, since it allows users to run diagnostics and independently fit the models. If they are all inside TMLE class, the fit might be ignored (at least more likely)
Haven't thought of an alternative yet

Going back to change this for v0.4.0. I need to use another way to operationalize this. The necessity is because I want LTMLE to match TMLE. For LTMLE and sequential regression, a model has to be fit EACH time point. Therefore, I need to have LTMLE do the fitting each time. The user needs to pass an unfitted model.
Users should pass some class object containing their predictive function of choice. That class should have a function with fit() and predict(). I will need to have a background process that looks to see what variable specifications exist in fit(). For sklearn and supylearner, X and y are used. statsmodels uses endog and exog. Those libraries should be a sufficient start. I can eventually add more possibilities as requested


Assume AWS Role in PrestoS3FileSystem

Users could use AWS role to do per-session access.
eg. use AWS role to query some limit-access tables:
./presto --server coordinator:8080 --catalog hive --debug --session hive.aws_iam_role="arn:aws:iam::example:role/access"

@electrum can you please take a look?

@electrum would you please take a look?

@electrum rebased with the current master

@electrum comments addressed

This will cause the creation of many instances of AmazonS3Client. Will this cause socket leaks or performance problems due to lack of connection pooling, throttling on Amazon's side, etc.?
Do we need our own cache (based on role?) to share clients between FS instances?

@electrum yes, exactly, did see many instances of AmazonS3Client, and a large number of timeout or connection reset. We did cache of AmazonS3Client, based on the provider name, suffixed by role name. Was planning to submit as a separate PR. Now appended here. Your comments are appreciated.

@electrum kindly ping

This is a very useful feature for us too, it would be great this can be merged to trunk, would you please take a look @electrum? Thank you, guys.

Does AWS support Kerberos SSO?  If so, a better approach will be to use the Kerberos authentication that @martint just checked in.  Currently this is not passed down to connectors for authorization, but that this being worked on next.
Generally, I don't think we should be passing credentials as generic session properties and instead attach the Principal to the session.

@dain @martint @electrum
thanks for the comment. we are using AWS IAM roles to delegate access to users:
http://docs.aws.amazon.com/IAM/latest/UserGuide/roles-toplevel.html
Whenever a user assume that role, it could access special data.
The session property we pass is not credentials, it is an IAM role. What do you think of passing this IAM role in the session property?

I think this does not conflict with Kerberos, it is just a AWS S3 feature support. What do you think?

@dain @martint @electrum Just chatted our Amazon EMR operations team, Amazon does not have Kerberos support, so we use this Amazon role based access to special sensitive buckets. What do you think of passing AWS role as a session property?

kindly ping

I'm still a bit lost on how this works.  This seems to be similar to Hive's storage-based security where instead of checking the Metastore for grants, you interrogate the storage (directory) permissions.  In this case the user "principal" would be the IAM credentials and instead of an explicit authorization check, we would let the S3 client throw exceptions.  It that how this is intended to work (at a high level)?

@dain yes, as you said, instead of checking Metastore, we have all permission settings at S3 storage, and users need to specify their aws iam role to access the specified files. If permission denied, S3 client will throw exceptions for unauthorized access.
Our use case is, all files storing at S3, and have corresponding permission settings. There are some sensitive data have specific permission settings, that only specific aws iam role could access. AWS does not have Kerberos support, and passing the aws iam role as a session parameter seems a good match for our use case.

I get it.  I'm sure this is something we can support but I have a bunch of follow up questions.  Hopefully, the AWS folks will jump in with their opinion on how this should work.
How do we assure the IAM string is valid?  How do we authenticate it?
How do we validate the IAM string is allowed to run queries as the specified Presto username? Presto username is used for queue management and for functions, so it is important to restrict a person to only use one Presto username string.  For example, can we verify that the IAM string ends with /<username>?
How should CREATE TABLE or INSERT work?  Do we need to set file permissions?
How will views work?  A SQL view executes as the person that created the view.  Where should we store the IAM string from the view owner?  Or do we simply disallow view creation?
Does this mean that when we add GRANT to Presto that this will be disabled for S3?  Or would we set permissions in S3?
How do you envision this working for people using a mixed S3 and HDFS installation on AWS?  For HDFS we do not support storage-based security.  This would be confusing to users and maybe impossible in the code.

We may want to model this as another authentication scheme, where the AWS IAM credentials are captured in a Principal and passed to the connector to do as it wants, instead of using a session property.

Thank you @dain @martint for the comments. Yes, this seems more like a hacking, did not consider the scenario to work with CREATE/INSERT, GRANT, or working with HDFS.
For the IAM string, the AWS credential provider will check whether it is valid, and throw exception if not. For working with CREATE/INSERT, GRANT, and working with HDFS, I did not have a picture.
Let me think about doing this in a Principal, as @martint suggested.

@dain @martint
Let me elaborate more on our usage, and answer @dain 's questions one by one:
For S3 files, there are a few permissions, including List, Put, Get, and Delete.
We create a few Roles, and set their permission, say, IamReadRole has permission to List and Get, IamWriteRole has permission to List, Get, and Put, IamAllRole has permission ot List, Get, Put, and Delete.
Users are assuming the same IamRole when accessing files. If username1 and username2 are trying to read a sensitive database, they have to assume IamReadRole each. If they are trying to write to the sensitive database, they have to assume IamWriteRole each.

How do we assure the IAM string is valid? How do we authenticate it?

The AWS Credential Provider will throw exception if the IAM string is invalid, and will deny access if the role does not have permission to do so. Say, if a user assuming IamReadRole trying to write files(CreateTable), it will fail, and get permission denied exception.

How do we validate the IAM string is allowed to run queries as the specified Presto username? Presto username is used for queue management and for functions, so it is important to restrict a person to only use one Presto username string. For example, can we verify that the IAM string ends with /?

If I understand the question correctly, different users could assume the same IAM role, and the same users could assume different IAM roles in his different sessions. The username is not part of IAM role. It is the role that user is accessing S3.

How should CREATE TABLE or INSERT work? Do we need to set file permissions?

Create Table and Insert definitely needs to assume IamWriteRole, if not they will fail and get permission denied exceptions.

How will views work? A SQL view executes as the person that created the view. Where should we store the IAM string from the view owner? Or do we simply disallow view creation?

Our current usage is, if a view is created by a user assuming valid IamWriteRole in the sensitive database, then all users assuming IamReadRole could read from the view.

Does this mean that when we add GRANT to Presto that this will be disabled for S3? Or would we set permissions in S3?

I am thinking, when Presto has GRANT, maybe could just have this S3 IAM role continue working with the GRANT, say, if the data warehouse is on S3, then GRANT does not guarantee permission to access the warehouse, also need to assume appropriate IAM roles to accessing it.

How do you envision this working for people using a mixed S3 and HDFS installation on AWS? For HDFS we do not support storage-based security. This would be confusing to users and maybe impossible in the code

Yes, this is confusing. Seems like these are two models, the metastore GRANT model, which HDFS follows, and the storage based model, which S3 IAM role follows. I am thinking, maybe make HDFS follow the storage based model, or make S3 follow the metastore GRANT model, are confusing and difficult. Making the S3 IAM role a session property is kind of assuming metastore GRANT model is the  ideal model to Presto, but just make it OK to work with S3 IAM role.
Your comments and suggestions are appreciated.

@zhenxiao any plans to finalize this PR?

@martint @dain @zhenxiao Just want to check with you guys whether it's OK to build this feature with the following steps as another authentication scheme:

Get the IAM role from the presto-cli. Either as a session property or with another command line argument. We should be able to specify an IAM role per client session, it can't be a static config.
Add a new servlet filter that checks for a specific header (that the cli sets when it sees the IAM role passed to it) and create a principal that wraps the role. After the filter is executed we should have the principal in the current http request and then in the current session.
We can implement ConnectorAccessControl and use aws IAM sdk to get info about the policies (resources + actions allowed on those resources etc.) and do access control checks.
Pass the session (which has a principal set) all the way down to the s3 filesystem initialization and assume that role before executing the filesystem operations. We also need to disable filesystem caching as different roles will require different STSAssumeRoleSessionCredentialsProvider instances.

thanks for the update @nezihyigitbasi
@dain @martint let me pass this AWS role support to @nezihyigitbasi
I might not be able to debug AWS in the short term. Will join the discussion as well

@nezihyigitbasi  is this one still needed?

Nope, one can get this functionality with a custom credentials provider (#5667), so closing.


Swap excludeRoutes for @SkipThrottle() decorator

This PR swaps the excludeRoutes option for a simple and convenient @SkipThrottle() decorator.

@jmcdo29 Can you update the test/app.e2e-spec.ts? Thanks.


File format not allowed

using revision 118cb7a159894651dd0397439c06d183c64f65a4
and S3 as storage.
when trying to upload normal media files like jpgs we now consistently get the error "File format not allowed ()":

Hi @momolog
I will review this weekend, I am waiting for a new aws test account.
Regards,

fixed!
I forget to add .present? in a sentence.

Thanks a lot.


feat(KONFLUX-2457): add e2e test for integration tests on environment

Description
This PR is to add a e2e suite covering the environment solution was made
to run integration test scenarios pipelineRun on environment
more details can be found in Jira linked in below ,
Note: this PR should be open after the examples PR  be merged .
KONFLUX-2457
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

was tested locally :
[ReportAfterSuite] Autogenerated ReportAfterSuite for --junit-report
autogenerated by Ginkgo
  > Enter [ReportAfterSuite] TOP-LEVEL - autogenerated by Ginkgo @ 06/26/24 14:38:56.634
  < Exit [ReportAfterSuite] TOP-LEVEL - autogenerated by Ginkgo @ 06/26/24 14:38:56.665 (31ms)
[ReportAfterSuite] PASSED [0.031 seconds]
------------------------------

Ran 13 of 455 Specs in 307.383 seconds
SUCCESS! -- 13 Passed | 0 Failed | 31 Pending | 411 Skipped

/lgtm


Question about cursor placement in vi mode

When in vi mode, is there a way to place the cursor at the end of the line rather Than the beginning when scrolling through your command history using the up and down arrow keys?

@srdubya?
IIRC, that's why I added Set-PSReadlineOption -HistorySearchCursorMovesToEnd in the first place, but it doesn't work in vi mode.

I don't recall noticing that option.  I'll take a look at it this weekend.

Just submitted a pull request with this addressed.  Setting HistorySearchCursorMovesToEnd will always position the cursor at the end while leaving it off will keep the cursor at the beginning.  Keeping the cursor at the beginning is consistent with how my bash operates.


Weird highlighting on Results #h2

When you complete the child benefit tax calculator, you end up at a URL like this one
There is weird highlighting around the Results tag, which disappears when it goes out of focus.  (ie click on another part of the page)

@erikse, @ikennaokpala, @pmanrubia, @chrisroos: Do you know which team is currently responsible for this app? If it's us, then I'd suggest turning this into a Trello card on the Content Development board. If not then we should make sure the relevant team (Custom Formats?) is aware of it. /cc @jennyd

Yep, it's custom. I will write a card when I'm back in, but just wanted to
keep a track of it.
On 23 Mar 2016 12:41, "James Mead"<EMAIL_ADDRESS>wrote:

@erikse https://github.com/erikse, @ikennaokpala
https://github.com/ikennaokpala, @pmanrubia
https://github.com/pmanrubia, @chrisroos https://github.com/chrisroos:
Do you know which team is currently responsible for this app? If it's us,
then I'd suggest turning this into a Trello card on the Content
Development board https://trello.com/b/bVfnXnEc/content-development. If
not then we should make sure the relevant team (Custom Formats?) is aware
of it. /cc @jennyd https://github.com/jennyd
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/alphagov/calculators/issues/132#issuecomment-200330633

Thanks :+1:

Fixed by https://github.com/alphagov/calculators/pull/171


Use A, B in the right order according to protocols, ex icmp echo/request or tcp syn/sync-ack

Implemented for ICMP and TCP


VectorDrawable needs a ConstantState

The below class overwrites the getConstantState method and adds an internal constructor to give an impression of a possible implementation. It is wrong, though, in that it doesn't allow for a changed density. (How the density can change eludes me, but it is what the contract requires.)
package carbon.drawable;

import android.content.Context;
import android.content.res.Resources;
import android.graphics.Bitmap;
import android.graphics.Canvas;
import android.graphics.Color;
import android.graphics.ColorFilter;
import android.graphics.Paint;
import android.graphics.PixelFormat;
import android.graphics.drawable.Drawable;

import com.caverock.androidsvg.SVG;
import com.caverock.androidsvg.SVGParseException;

/**
 * Created by Marcin on 2015-06-25.
 */
public class VectorDrawable extends Drawable {
    SVG svg;
    Bitmap bitmap;
    private Paint paint = new Paint(Paint.FILTER_BITMAP_FLAG | Paint.ANTI_ALIAS_FLAG);
    int density, intWidth, intHeight;

    public VectorDrawable(Resources res, int resId) {
        if (resId == 0)
            return;
        try {
            svg = SVG.getFromResource(res, resId);
            density = res.getDisplayMetrics().densityDpi;
            intWidth = (int) (svg.getDocumentWidth() * res.getDisplayMetrics().density);
            intHeight = (int) (svg.getDocumentHeight() * res.getDisplayMetrics().density);
            setBounds(0, 0, intWidth, intHeight);
        } catch (SVGParseException e) {

        }
    }

    private VectorDrawable(SVG svg, Bitmap bitmap, int density, int intWidth, int intHeight) {
        this.svg = svg;
        this.bitmap = bitmap;
        this.density = density;
        this.intWidth = intWidth;
        this.intHeight = intHeight;
    }

    @Override
    public void setBounds(int left, int top, int right, int bottom) {
        int width = right - left;
        int height = bottom - top;
        if (svg == null || width == 0 || height == 0 || (bitmap != null && bitmap.getWidth() == width && bitmap.getHeight() == height))
            return;
        svg.setDocumentWidth(width);
        svg.setDocumentHeight(height);
        bitmap = Bitmap.createBitmap(width, height, Bitmap.Config.ARGB_8888);
        bitmap.setDensity(density);
        svg.renderToCanvas(new Canvas(bitmap));
        super.setBounds(left, top, right, bottom);
    }

    @Override
    public void draw(Canvas canvas) {
        if (bitmap != null)
            canvas.drawBitmap(bitmap, getBounds().left, getBounds().top, paint);
    }

    @Override
    public void setAlpha(int alpha) {
        paint.setAlpha(alpha);
    }

    @Override
    public void setColorFilter(ColorFilter cf) {
        paint.setColorFilter(cf);
    }

    @Override
    public int getOpacity() {
        return PixelFormat.TRANSLUCENT;
    }

    @Override
    public int getIntrinsicWidth() {
        return intWidth;
    }

    @Override
    public int getIntrinsicHeight() {
        return intHeight;
    }

    @Override
    public ConstantState getConstantState() {
        return new VectorConstantState(svg, bitmap, density, intWidth, intHeight);
    }

    private static class VectorConstantState extends ConstantState {
        private final SVG svg;
        private final Bitmap bitmap;
        private final int density, intWidth, intHeight;

        public VectorConstantState(SVG svg, Bitmap bitmap, int density, int intWidth, int intHeight) {
            this.svg = svg;
            this.bitmap = bitmap;
            this.density = density;
            this.intWidth = intWidth;
            this.intHeight = intHeight;
        }

        @Override
        public Drawable newDrawable() {
            return new VectorDrawable(svg, bitmap, density, intWidth, intHeight);
        }

        @Override
        public int getChangingConfigurations() {
            return 0;
        }
    }
}```

Basically I'm experimenting with wrap_content, ImageView and SVGs. It's hard to tell how it should behave to be useful. Seems like setting bitmap's density to anything other than DENSITY_NONE has no point. The density field can be dropped.

You do need to use density to calculate the bitmap size from the svg's intrinsic size, right? So even if you drop the density field, the bitmap's size intrinsically holds the density, thus making it a variable, which should not be part of ConstantState.
Two things:
a) creating the bitmap and rendering the svg is expensive. I think BitmapDrawable considers the bitmap (not just the resId) as part of the constant state. How that works with changing densities I don't know though.
b) would it be faster or slower to just set intrinsic size on setBounds(), mark the bitmap invalid and create the bitmap and render the svg on draw only?

I'm converting my floating action buttons to your implementation -- and to using SVGs in the process. Your idea of considering the pixel size of the SVG as the device independent size of the drawable turned out to be a stroke of genius. it makes handling SVGs so simple and straight forward!

Thanks!
I think it's ready. Bitmap is not a part of VectorState, because it's used only for buffering and may have different sizes for different uses.


Fix minor typo

Codecov Report

Merging #38 (19d5583) into master (0afdf87) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              master       #38   +/-   ##
===========================================
  Coverage     100.00%   100.00%
  Complexity       853       853
===========================================
  Files             34        34
  Lines           1599      1599
  Branches         256       256
===========================================
  Hits            1599      1599

Impacted Files
Coverage Δ

...ons/statistics/distribution/ExtendedPrecision.java
100.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Enhancement] when use desc statement, return the keyType and valueType of MapType

Signed-off-by: zombee0<EMAIL_ADDRESS>What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #13118
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[FE PR Coverage Check]
:disappointed: fail : 0 / 2 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/MapType.java
0
2
00.00%
[105, 106]


Handle inconsistencies in command response event indexes

This PR fixes an issue in Copycat's ClientSequencer that can prevent the client from progressing when inconsistencies exist in server-side session sequences.
This is not so much an issue in the client sequencer as it is an issue with non-deterministic event sequences in state machines. This problem can occur when a client switches from a server with one set of events to a server with a different set of events. Once an event sequence is sent to the client from the first server, if the client switches servers and expects an event that doesn't exist on the new server, that can result in a live lock in the ClientSequencer.
Ideally, state machines will ensure that events are published deterministically. While Copycat's replication protocol allows commands to be excluded from replication once they've been released, Copycat already ensures that all commands that create events that have not yet been acknowledged by all clients will be replicated. That is, when a command publishes events, the command that created the events will be live and continue to be replicated until the events have been acknowledged by all sessions. That should ensure that any server to which a client is connected will have a consistent sequence of events. But in the event a state machine does not publish events deterministically, consistency checks on the client can result in the client waiting for events that will never come. During that time, the client cannot complete either events or responses.
So, this has been a known issue in the past, and 2b6f47fc4afae77d00d35e6089e8ea0ce1479a09 actually prevented this live lock from occurring with respect to PublishRequest. If a client switched servers and received a PublishRequest from a server that didn't have the client's last event, the server can set previousIndex to the client's last indicated received event to ensure that events can be sequenced on the client. However, this only fixed part of the issue. eventIndex is also sent in responses to the client. So, if a client receives an eventIndex in a response and then switches to a server that doesn't have an event at that index, the client will not be able to sequence events.
The fix for this is to simply check events in the sequencer's queue to detect gaps in expected events during sequencing. When the client is sequencing a response, if the client doesn't have the event prior to the response, it checks the events it has received to determine whether a PublishRequest has a previousIndex that matches the sequencer's current eventIndex. This allows the Math.max call to reset the state inside the sequencer and allow it to sequence operation responses that have a missing eventIndex.

Changes Unknown when pulling e20f7321fdc461b47223c999cbb8ad1478ae7833 on client-sequencer-missing-response-event into ** on master**.


how can i change the detector to other algorithm

hello ZQPei, i want to change the detector yolov3 to other algotithm, can u tell me where I should change? thank u very much!!

This is simple.
See the code in detector? Just add your detector beside the YOLOfolder and remember to wrap your detector by defining a new class as I did indetector/YOLOv3/detector.py`.
Hope this reply is not too late.

@ZQPei thanks a lot!!!

hello ZQPei, i want to change the detector yolov3 to other algotithm, can u tell me where I should change? thank u very much!!

do you successed？


Usage of dynamic import in router config results with error upon build

Router configuration like this:
export default {
  boot: () => {
    return Promise.resolve()
  },
  bootComponent: Splash,
  root: 'home',
  routes: [
    {
      path: 'home',
      component: () => import('@/screens/Home'),
      widgets: ['menu']
    },
   ]
}

will trigger the next error after lng build is called:
(!) Circular dependencies
<EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>-><EMAIL_ADDRESS>...and 11 more
[!] Error: UMD and IIFE output formats are not supported for code-splitting builds.
Error: UMD and IIFE output formats are not supported for code-splitting builds.
    at error (C:\Users\dev\AppData\Roaming\npm\node_modules\@lightningjs\cli\node_modules\rollup\dist\shared\rollup.js:5265:30)
    at validateOptionsForMultiChunkOutput (C:\Users\dev\AppData\Roaming\npm\node_modules\@lightningjs\cli\node_modules\rollup\dist\shared\rollup.js:12549:16)
    at Bundle$1.generate (C:\Users\dev\AppData\Roaming\npm\node_modules\@lightningjs\cli\node_modules\rollup\dist\shared\rollup.js:12399:17)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at handleGenerateWrite (C:\Users\dev\AppData\Roaming\npm\node_modules\@lightningjs\cli\node_modules\rollup\dist\shared\rollup.js:20028:23)
    at async Promise.all (index 0)
    at build (C:\Users\dev\AppData\Roaming\npm\node_modules\@lightningjs\cli\node_modules\rollup\dist\bin\rollup:1494:5)
    at runRollup (C:\Users\dev\AppData\Roaming\npm\node_modules\@lightningjs\cli\node_modules\rollup\dist\bin\rollup:1646:21)

(node:12672) UnhandledPromiseRejectionWarning: Error: Error: Command failed with exit code 1<EMAIL_ADDRESS>-c<EMAIL_ADDRESS>--input C:\Users\dev\Work\app\app-lng\src\index.js --file C:\Users\dev\Work\app\app-lng\build\appBundle.js --name APP_app

Hi, sorry for the delay in reply, this should work out of the box without throwing an error. Is this still and issue? And is it possible to provide a bit more context or a way that we can reproduce it?

Hi, sorry for the delay in reply, this should work out of the box without throwing an error. Is this still and issue? And is it possible to provide a bit more context or a way that we can reproduce it?

@erikhaandrikman sorry for a delay as well :) This issue is tied to lng-cli, it makes a iife build, which is not compatible with dynamic imports:
https://github.com/rdkcentral/Lightning-CLI/blob/0385006cc28fb53d491dcbcf9ec61c6d7c92063f/src/configs/rollup.es6.config.js#L82
We managed to mitigate the issue with our own Webpack-based bundling pipeline...alas, we are not sure if the pipeline output will be compatible with ML app store, since we have multiple chunks(which are dynamically loaded) instead of a one big js file(like the lng-cli outputs).

Are you still facing this issue? I'm not able to reproduce this anymore with rollup or esbuild please let us know if any help is required

Hi @erikhaandrikman . Today I also attempted to use a dynamic import on my boot function in my routes.js, but just as @Serhii-the-Dev I got the same error. I'm using a Promise.all() to load various external scripts before the app fully loads but there's this one script that I need to load dynamically (because I have it in a .js file locally and auto executes as soon as it gets imported) to then load my other scripts which depend on it.
boot: () => {
     // Other functions that return promises and load scripts go here

    function wrapperMessagingSDKPromise() {
      return import('../../lib/navigation.js').then(() => {
        return new Promise((resolve, reject) => {
           const wrapperMessagingSDKScript = document.createElement('script');
           wrapperMessagingSDKScript.src =
              'https://xxx.xxx.com/someScript.js';
           wrapperMessagingSDKScript.addEventListener('load', () => resolve(true));
           wrapperMessagingSDKScript.addEventListener('error', () =>
             reject(false),
           );
          document.body.appendChild(wrapperMessagingSDKScript);
        })
      });
    }

    return Promise.all([
      imaSDKPromise(),
      imaDAISDKPromise(),
      externalGtagPromise(),
      embedGtagPromise(),
      wrapperMessagingSDKPromise(),
    ]);

Are you using esbuild or rollup?


use direct imports instead of generic helpers import

as preparation for tree shaking use direct imports and avoid using the helpers. internally

We had done this originally and then I think @kurkle introduced the index to make things easier to import because we thought the extras would tree shake out. I think that tree shaking would eliminate the extras with WebPack if we set sideEffects: false which is what we had mostly tested. The Rollup docs are kind of unclear on the point, but it does sound like we might need this PR for Rollup. And your test was with Rollup and it seems like the extras didn't get shaken out there, which would seem to confirm it

It looks like

It looks like there was some issue. Maybe callback is a reserved work and you need to alias it? You can run gulp lint locally to check

src/scales/scale.radialLinear.js#L355
Expected return with your callback function

as far as I know the helper index file would work if it only re exports elements but not introduces some object containing them.
e.g., (tho not sure whether rollup supports the export * as  syntax.
``js
export * from './helpers.core';
export * as dom from 'helpers.dom';

as far as I know the helper index file would work if it only re exports elements but not introduces some object containing them.

Yeah, export default { ... } is challenging for tree-shaking, since any consumer imports a reference to this object, which opens it up for side-effect. Its quite different to export { ... }, where the curly braces do not denote an object, but are only export syntax.
For files like /src/controllers/index.js, it would be sufficient to change export default to export and adjust the consumers accordingly.

I'd prefer having the index in each folder be just that and directly export the things that are available in various files. So when you move a helper function to another location, all you have to do is update the index (in case its a new file).
This has already the major work in it though and changing the indices is going to need some more work. We'd probably want to try preserving the helper namespaces in the bundle, if possible.
Not sure, but maybe we can have it both ways, a export default for the bundle and named exports for module in each index.

I would suggest to merge this PR and then in another one create index file that reexports nested files
anyone an idea how to fix the build? I just merged the master
one might consider renaming some helper function, e.g. canvas.clear would be just clear which gives no hint about what it does and which arguments it requires.

2 / 3 CI are passing, so the build is probably fine. We've had random failures for a long time now, it has to do with the order the tests are run. (I triggered a rebuild)

We'd probably want to try preserving the helper namespaces in the bundle, if possible.

I am not sure if sub-namespaces are currently supported in JS.
Using export default { ... } for this can work, but actually extending the function identifier (like a namespace) instead of creating a data structure/object to mimic it could be more useful.
One important feature would be tree-shaking, but an even more important one could be linting.
ESLint can easily validate (here as well as in user land) if a named export exists, but it won't be able to look into an object if the keys are actually set at runtime prior to its usage.
This would also help a runtime (a little bit), as it only require a function identifier lookup, instead two lockups (one to identify the object variable and another to access the key).

To keep it similar to canvas.clear one could name it canvasClear (either in the re-export/index or the original module).

I ment Chart.helpers.canvas.clear for example, in the umd build. Esm build should be plain functions and I agree some names need to be extended.


[Question] - Blazor - How to auto recompile on save to .razor file

For a Blazor client project (served up to the browser from an asp.net core host) opened in Visual Studio 2019 Preview, how do I make it so that when I save changes to a razor file in the client project, it automatically builds an updated dll - so that all I have to do is then reload the page to see the change?
Thank you.

I do it using "dotnet watch build" for this and I added razor extension to the watch list like here :
https://github.com/RemiBou/Toss.Blazor/blob/master/Toss.Client/Toss.Client.csproj

  <ItemGroup>
    <!-- extends watching group to include *.razor files -->
    <Watch Include="**\*.razor" />
  </ItemGroup>

Thanks for answering, @RemiBou!
Also, I think .razor might be in the default list of watched extensions these days.

Thanks - this may work, but it completely bypasses VS in terms of how one would typically launch a project. So coming back to VS 2019 - how would one launch a solution, containing 2 projects (one for the asp.net core host, and the other for the blazor client), where the host is the startup project, but as you make changes to the client .razor files the client project is rebuilding?

I agree it would be a good feature.
However, it's not a feature that currently exists when launching from VS. It's something we're considering for the future.

Ok thanks.
I've created a sample that you can run in VS here which has hot reload of a hosted blazor client application.
It reloads almost instantly when changes to static files are made (i.e in the client projects wwwroot folder). If you change .razor files though, it takes a bit longer for the page to reload as it must wait for a dotnet build to complete.
This sample will be useful for anyone that just wants to run from VS (with or without debugger attached) and have things reloading without having to have a seperate terminal do dotnet watch.

One thing I have noticed - which can be seen with dotnet watch build - if you change a .razor file, the subsequent build takes approx 10 seconds to complete. This seems a long time to wait to see some categories of changes- for example a purely static html tweak.

I do it using "dotnet watch build" for this and I added razor extension to the watch list like here :
https://github.com/RemiBou/Toss.Blazor/blob/master/Toss.Client/Toss.Client.csproj
  <ItemGroup>
    <!-- extends watching group to include *.razor files -->
    <Watch Include="**\*.razor" />
  </ItemGroup>

this approach dont work for blazorhosted template.

@SPWwj what do you think about the "wait time" it takes to rebuild after making a minor html change? Is blazor productive for you in that regard?

@SPWwj what do you think about the "wait time" it takes to rebuild after making a minor html change? Is blazor productive for you in that regard?

thanks for response
I have try 'wait time' but waited for few minutes see nothing happen. Watcher reponses to normal blazor and blazorserverside template instantaneously by default.(not need to add include to csproj file).
blazor definitely a great thing for .net developer as it elimated the need for us to learn new spa framework.


Hugepage perf warning: Hugepage allocation is not on NumaNode matching TT Device

UMD warns us if hugepage is not allocated on the same NumaNode as the TT device (results in decreased Device->Host perf)
See relevant Gitlab issue: https://yyz-gitlab.local.tenstorrent.com/devops/devops/-/issues/209
FYI @DrJessop @TT-billteng @davorchap @tt-rkim @pgkeller

@TT-billteng this is VM perf warning

fyi previous cloud hugepage issue: https://github.com/tenstorrent/cloud/issues/1725

yes, I hope we get rid of huge altogether in the refactor

Should we close this on our side? Or leave open

is the fix to install tenstorrent tools? Until we remove hugepages altogether (if we ever get there)

I guess so ie. encourage syseng to actually release that as a public pacakge

it's not a public package yet?

You mean https://github.com/tenstorrent/tt-system-tools that has a debian package?

@ttmchiou We should look into whether this debian package can fit all our use cases, including for galaxy. When it first came out, that was my initial concern.
cc: @abhullar-tt   - we may have a better way to bring up HPs, but hugepages settings concern you

I've tested it running locally on some GS VMs and TGG machines and it has resolved hugepage installation issues.
I haven't seen this perf printout in the TGG workflows yet but I also haven't been looking in detail for those.
We have a MIW issue to integrate into provisioning too
https://github.com/tenstorrent-metal/metal-internal-workflows/issues/278

is there further action needed to close this at this point?

No, we can close. This is a UMD thing.
We likely will continue seeing this on CI as we OOM error with the amount of RAM we have in CI, but we can't allocate enough per NUMANode on the CI machines.


Dts x86 move ioapic

Changes to fix and slightly improve the ioapic device tree nodes.

Cc: @SavinayDharmappa (who can't be added as a reviewer, I guess because he's not a "collaborator", just a "contributor")


Label all tracer events with a severity that the Consensus Team decided

Current plan:

Create a type class that labels an event with severity. For at least some events, Consensus Team is best positioned to decide this label.

To avoid confusion/ambiguity -- ie for consistency -- we'll assign a severity to every event, not just the ones that we're best positioned to do so.

Add a wrapper type to our tracers at the boundary (ie in StdRunNodeArgs) by invoking the class method.

If an event's severity depends on dynamic information, that event must carry enough info to decide it.

The clients can opt-out of these, or incrementally incorporate the new severity level, by discarding the wrapper type at any stage. Ultimately it's their call what to do with this label. Ideally we'd reach mutual agreement on what it should be.

Something like:
class HasSeverity event where
  getSeverity :: event -> Severity

-- levels sketched during our Consensus Sync
--
-- TODO cross reference with existing severity levels already in-use by other Teams
data Severity
  = TraceSeverity       -- everything
  | DebugSeverity       -- usually revealing things
  | InfoSeverity        -- things some people want to know
  | WarningSeverity     -- unexpected but not directly harmful
  | ErrorSeverity       -- something went wrong but the code can recover and keep trying
  | CriticalSeverity    -- a fatal error is imminent

---- how is there still no standard Haskell/Hackage type for "annotate x with y"?
traceLabelSeverity :: HasSeverity event => event -> TraceLabelSeverity event
traceLabelSeverity e = TraceLabelSeverity (getSeverity e) e

-- cf TraceLabelPeer
data TraceLabelSeverity event = TraceLabelSeverity Severity event

If we temporarily add another Severity constructor, we can rely on it to break the work of assigning all these severity levels up into multiple PRs.
... | PendingSeverity     -- we haven't yet decided what this event's severity should be

In particular, we'll probably need help from Network to decide on the severity of some events. PendingSeverity will help us mitigate the scheduling of that work.


xdebug 3x and base\ErrorException.php

What steps will reproduce the problem?
Install latest xdebug, 3x.
Enable xdebug debugging in php.ini with:
xdebug.mode=debug
What is the expected result?
Error trace, output info.
What do you get instead?
The error msg in vendor\yiisoft\yii2\base\ErrorException.php:50.
Line 50 is:  $xDebugTrace = array_slice(array_reverse(xdebug_get_function_stack()), 1, -1);
Function must be enabled in php.ini by setting 'xdebug.mode' to 'develop'
   /*
     * @param \Throwable|\Exception $previous [optional]
     */
    public function __construct($message = '', $code = 0, $severity = 1, $filename = __FILE__, $lineno = __LINE__, $previous = null)
    {
        parent::__construct($message, $code, $severity, $filename, $lineno, $previous);

        if (function_exists('xdebug_get_function_stack')) {
            // XDebug trace can't be modified and used directly with PHP 7
            // @see https://github.com/yiisoft/yii2/pull/11723
            $xDebugTrace = array_slice(array_reverse(xdebug_get_function_stack()), 1, -1);
            $trace = [];
            foreach ($xDebugTrace as $frame) {
                if (!isset($frame['function'])) {
                    $frame['function'] = 'unknown';
                }

                // XDebug < 2.1.1: http://bugs.xdebug.org/view.php?id=695
                if (!isset($frame['type']) || $frame['type'] === 'static') {
                    $frame['type'] = '::';

Additional info

Q
A

Yii version
2.0.40

PHP version
7.4.3

Operating system
win 10

I haven't checked it before - is it possible to detect the selected mode?

I haven't checked it before - is it possible to detect the selected mode?

Same problem here.
xdebug 3.0.1
Yii 2.0.40

Same problem here.
xdebug 3.0.1
Yii 2.0.40

Some solution in the wild: https://github.com/rollbar/rollbar-php/blob/de772a73b87ff5abbe18d54e40a6e1f41c701d35/src/DataBuilder.php#L1110

Some solution in the wild: https://github.com/rollbar/rollbar-php/blob/de772a73b87ff5abbe18d54e40a6e1f41c701d35/src/DataBuilder.php#L1110

The fix pointed by @My6UoT9 should be alright.

The fix pointed by @My6UoT9 should be alright.


write unit tests for OrganizationDetailQueryHandler

@tonysurma please label with "jump-in". Part of Issue #620

Please code review.
Thanks

@ankurMalhotra my Dev machine is out of commission until Tuesday at the earliest. I'll try to get to it sometime this week.

@tonysurma this Issue can be closed.


Support ,  and

For a list like this now:

foo

bar

baz

The text would become
foobarbaz

But I would at least want it to become
foo
bar
baz

But even better:
1. foo
2. bar
3. baz

Similar for
.
Maybe someone already has implemented this?

Some support here: https://github.com/utrotzek/html2text/commit/44664ea2ab9aca409e0d92db792638afc8202c4c

Yes this has been implemented basically in PR #19: https://github.com/soundasleep/html2text/pull/19
(Actually doing numbering is a much more complex issue)


Any way to get quiz name?

Any way to get quiz name? ima make a kahoot hack lmfao

o wait, u alr made it, kahoot-win.herokuapp.com

kinda wanna buy the source code lmfao

Great news! A source of Kahoot Winner is open. (Check my repositories)
Anyway, there is no way to get the quiz name automatically. You have to ask the user for it.

wow, tysm!


How can I start esp8266 machine using arm_now

I noticed that arm_now is able to start xtensa processor family. How could I start esp8266 machine using arm_now?

arm_now start xtensa

For more information please read the Wiki.
Thx.

Thanks for the information 👍


How to extract styles from vue components?

It is obvious that styles written in .vue components should be extracted to separate files. Is there a built-in support or this? In pevious version I've edited config like this:
rules: [
        {
            test: /\.vue$/,
            loader: 'vue-loader',
            options: {
                loaders: {
                    js: 'babel-loader' + Mix.babelConfig(),
                    css: plugins.ExtractTextPlugin.extract({
                        loader: 'css-loader',
                        fallbackLoader: 'vue-style-loader'
                    }),
//

but now this fails with error

I've added support for this on master. It'll be tagged at some point this week, likely.
Once tagged, you can turn on Vue style extraction with:
mix.options({ extractVueStyles: true });

@JeffreyWay thank you!

@JeffreyWay I'v added your commit to my config and I want to aware you: this makes impossible to use multiple stylesheets.

You can see that styles, extracted from two js files (app.js and ui.js) are extracted to both app.css and home.css. And they are similar at the end


When two points are written with the same timestamp one should update the other

TODO: Check if this is not finished


[SDK] Add chunking, retries, and exponential backoff for querying events

/release-pr

/release-pr

/release-pr


Kelinahat Archon Empyreal Lord

Describe the solution you'd like
A clear and concise description of what you want to happen.
Add Kelinaha, I found a symbol for her.
Additional context
Add any other context or screenshots about the feature request here.
I found a symbol for Kelinahat on the page linked below. I have also added it directly here.
https://hellsvengeance-12.obsidianportal.com/wikis/archon-empyreal-lords

The reason I added this one is that as far I can tell she is the last Empyreal Lord that has a symbol that has not been added. I just thought that it would be a good idea to add her as that would be all the Empyreal Lords with symbols added.


fixed digits.py sample to work with opencv 3

digits.py python sample contained opencv 2 code, refactored to work with 3.0.0-rc1 API

changed the setting of SVM params and used the correct predict signature

thanks! :+1:


[WIP] Persistent audit logging

What type of PR is this?
/kind feature

What this PR does / why we need it:
This change adds the option to enable persistent logging for the auditor by passing the --verbose flag. If enabled a concurrent gorutine will count the number of requests to GCR every 10min. Each period the nuber of requests are logged, in Debugger mode. If the auditor exceeds GCR's quota limit of 50,000 requests per 10min, a logging message will warn of this behavior.
Capturing the number of GCR requests gives us visibility in the volume of queries needed when auditing. Such information is crutial to understanding how close to the quota limit the auditor may get.
This aids the investigation in GCR querying (#353) and improving auditor scalability (#259)
Which issue(s) this PR fixes:
None

Special notes for your reviewer:
The actual "persistence" of these records are only as long lived as the auditor program. Recording begins on startup and ends on termination. No information persists between audit invocations. However, since the auditor is made to run continuously in Cloud Run, we really only need to know the network performance of the auditor, when running. Therefore, saving this information to file, or any other persistent storage, is unnecessary.
Additionally, let it be known that the --verbose flag is now enabled in the Dockerfile. This way, future deployments can gain visibility in the network costs of the auditor. After the resolution of #259 should this flag be removed.
Does this PR introduce a user-facing change?
None

Adds the option to enable persistent logs with the --verbose flag.
Reports the number of GCR requests every 10min window, when persistent logging is enabled.
Add the --verbose flag to Dockerfile for future auditor deployments.

cc: @listx @amwat @justaugustus @kubernetes-sigs/release-engineering

/hold
Holding for #357 to merge first (I expect to finish this today).

Re-adding WIP label due to offline conversation with @listx. We agreed to break this feature into smaller PRs with an accompanying issue.

Closing, as this PR is superseded by #359
Progress on additional audit logging is tracked in this issue: #358


Publish frozen CLI binaries from azure pipelines to github releases

Once CLI is done, have azure pipelines build it then publish frozen binaries to github releases.

Done.


Load balanced endpoints ops

Grant Application
This application is (select one):

[x] Speculative (use this by default)
[ ] an RFP response

This application is (select one):

[ ] Public (fully)
[x] Public with private finances

Abstract
This project serves as an extension to the previously completed load balanced endpoints proposal where we provided the ecosystem with a multi-cloud reference architecture to deploy globally distributed sets of load balanced API endpoints configurable with a custom CLI.  This proposal now aims to operate these endpoints publicly and offer them to the community.  Usage data will be gathered and analyzed to inform which queries and optimizations need to be done to improve and extend the endpoints.  We also plan on building and operating sync points to improve sync / scale times.  Infrastructure will be operated for one year from the date of approval.
Checklist

[x] The grants document has been read and understood.
[x] The Google Form will be completed accurately. Note that the Google Form requires the pull request URL.
[x] Abstract (above) is succinct and complete.
[x] The application is being included into the correct directory: either 'targeted' or 'speculative'.
[x] The application includes a project description.
[x] The application includes all names of team members.
[x] The application includes a description of the team's experience.
[x] The application includes all necessary links (e.g. GitHub and LinkedIn)
[x] The "Development Roadmap" section in the application has a timeline of development ("milestones").
[x] The "Development Roadmap" section in the application has an estimate of funds required.
[x] The "Development Roadmap" section gives an indication of the team's long term plans.
[x] The "Development Roadmap" section includes documentation as a deliverable for at least one milestone.

Thanks for the application. Could you also fill out the google form?

@Noc2
Just submitted with updated costs breakdown in the google sheet link.  Let me know if there is any other information you would like us to provide.


Merge Abstraction module into Dionysos

The Abstraction module, a.k.a. SCOTS.jl is still a separate module that should be merged to Dionysos.
https://github.com/dionysos-dev/Dionysos.jl/blob/0e3645d5dab08589413c952a154fe93fb66e1ce6/src/abstraction.jl#L1

Abstraction module don't exist anymore


Be aware of...

Logger: homeassistant.components.climate.const
Källa: helpers/deprecation.py:197
integration: Klimat (dokumentation, ärenden)
Inträffade först: 21:06:37 (12 händelser)
Senast loggade: 21:06:46
HVAC_MODE_OFF was used from panasonic_cc, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.OFF instead, please report it to the author of the 'panasonic_cc' custom integration
SUPPORT_TARGET_TEMPERATURE was used from panasonic_cc, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.TARGET_TEMPERATURE instead, please report it to the author of the 'panasonic_cc' custom integration
SUPPORT_FAN_MODE was used from panasonic_cc, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.FAN_MODE instead, please report it to the author of the 'panasonic_cc' custom integration
SUPPORT_SWING_MODE was used from panasonic_cc, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.SWING_MODE instead, please report it to the author of the 'panasonic_cc' custom integration
SUPPORT_PRESET_MODE was used from panasonic_cc, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.PRESET_MODE instead, please report it to the author of the 'panasonic_cc' custom integration

I believe this is resolved in the latest update.

Yes it was

Fixed


remove n_loc from dict in order to reset it

If n_loc is not removed from the dictionary it won't be reset if a new cell file will be touched (I just had this problem)

A minimal test has been added to check if n_loc has been reset/cleaned for the next cell

Thanks, merged


Minor UI fixes

Summary
ICU-704 - Space between label and value version
ICU-700 - Thumbnail css improvements
Ticket Link
https://mattermost.atlassian.net/browse/ICU-704
https://mattermost.atlassian.net/browse/ICU-700
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Ran make check-style to check for style errors (required for all pull requests)
[ ] Ran make test to ensure unit and component tests passed
[ ] Added or updated unit tests (required for all new features)
[ ] Has server changes (please link)
[ ] Has redux changes (please link)
[x] Has UI changes
[ ] Includes text changes and localization file (.../i18n/en.json) updates
[ ] Touches critical sections of the codebase (auth, posting, etc.)

@asaadmahmood Looks like there's a build failure

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-0a71220b7ca80fa16.spinmint.com
Test Admin Account: Email<EMAIL_ADDRESS>| Password: user-0
Test User Account: Email<EMAIL_ADDRESS>| Password: user-1
Instance ID: i-0a71220b7ca80fa16

Spinmint test server destroyed

@asaadmahmood I did fix merge conflicts.

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-0dcb68465ca1b9e77.spinmint.com
Test Admin Account: Email<EMAIL_ADDRESS>| Password: user-0
Test User Account: Email<EMAIL_ADDRESS>| Password: user-1
Instance ID: i-0dcb68465ca1b9e77

Spinmint test server destroyed


Not working properly inside a Listview

This is my structure ,
                                     ListView.builder(
                                        cacheExtent: 50.0,
                                        reverse: true,
                                        padding:
                                            const EdgeInsets.all(15),
                                        controller:
                                            _listScrollController,
                                        itemCount: Chats.length,
                                        itemBuilder: (ctx, i) {
                                          print(firebaseUID);
                                          if (Chats[i].data()['IsFile'] !=null && Chats[i].data()['IsFile'] &&
                                              Chats[i].data()['FileType'] !=null && Chats[i].data()['FileType'] ==
                                                  'audio') {
                                            return AudioSentChat(i: i);

                                          } else
                                            return Container();
                                        },
                                      );

And Audio Sent Chat is a Stateless widget like this ,
                                   child: Container(
                                      padding: EdgeInsets.only(top: 15),
                                      height: 75,
                                      child: PlayerWidget(
                                          url: Chats[i]
                                              .data()['FileUrl'],
                                          mode: PlayerMode
                                              .MEDIA_PLAYER),
                                    ),

And the PlayerWidget is a Statefull widget with all the play/pause interactions , here https://github.com/luanpotter/audioplayers/blob/master/packages/audioplayers/example/lib/player_widget.dart
Now the issue is ,

when a new audiofile is recorded and added to the listview (added to firebase) , the ui gets updated but when you play it all the files are duplicates , I checked the data , which is perfect and not duplicates.
Now when the screen is scrolled a little the and then files are played it works perfectly without any duplicates.

Observations , the intiState() inside the player_widget is not fired on Listview update .
How can this be handled , also is it a bad idea to put a statefull widget inside a listview.

As commented, I don't think it's a problem with audioplayers package.


Fixed code generation when using arrays in Value Type types.

Fixed all the changed in one commit and a mergeable PR...

Due to latest Merges this PR has now conflict merges and is incompilable on my machine too since i pulled the changes. So I am closing it and opening a new one with all the required changes.


Node succ and pred optimisations

The new CFG nodes store four sets - the predecessors and successors that are intra-procedural and inter-procedural (predIntra, predInter, succIntra, succInter). There are a couple points of redundancy here:

For nodes which are non-jumps (i.e. statements in a block), all incoming and outgoing edges are going to be of type RegularEdge. Currently regular edges are stored in both the intra- and inter- procedural edge sets - we are thus storing the same edge in two different sets, when we only ever expect to have one edge for this type of node. This choice to store regular edges in both sets was done to simplify the process of differentiating between the intra-/inter-procedural CFG, and is particularly useful for jumps. However, given the majority of nodes are statements which will not require this distinction, we can reduce the amount of storage required by optimising them away. The exception to this would be the statement at the start of a block, and the statement immediately preceding the jump(s) in a block, as they may have different types of incoming / outgoing edges, thus requiring the distinction to be made. There are a couple ways to optimise - we could switch to having a single set for edges and filtering upon call to succ and pred (for reasons detailed in the comment on CfgNode this was decided against in the original design). We could also introduce a separate set for storing regular edges specifically, though this similarly comes at a computation cost of having to union two sets at each call of succ/pred. It would also be possible to refactor the CfgNode hierarchy to introduce new types and such, though this was decided against in the CFG restructure to maintain alignment with TIP.
There are currently three accessors - succ, succConds and succEdges (and the equivalent for pred). This was done so that the original API (succ returning a set of nodes) would be maintained such that the analyses had to be modified minimally to compile. However, it is likely to be simpler and more complete if these were reduced to a single succ / pred which returns the relevant edges, as edges store all the information encapsulated by the three accessors (destination/originating nodes and associated edge condition). Analyses can then choose to discard what they wish in their transfer functions. This would require a small refactor of all analyses/solvers, and the CFG.

Done.


Flexget: 2.10.40 -> 2.10.83

Motivation for this change
Fixes the build, for progress on #28643.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

:) https://github.com/NixOS/nixpkgs/pull/28615

Oh, neat. I should have looked before duplicating the work! Will look at 28615 instead.

I think the pull request updated should go into staging first, as it creates quite a lot of rebuilds.


No device found

Describe the bug
It's probably not a bug, I think the problem should be located between my screen and my chair.
When I run any command, I get a No device found error, "because the target machine actively refused it (10061)"
Hope I'ts not explained somewhere and I missed it.
Steps to reproduce
No response
Additional context
No response
Validations

[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

Which emulator are you using? This problem is probably related to the emulator. We suggest utilizing Bluestacks and enabling Android Debug Bridge through Settings > Advanced.

Im using Bluestacks and I did enable ADB in the settings

Which emulator are you using? This problem is probably related to the emulator. We suggest utilizing Bluestacks and enabling Android Debug Bridge through Settings > Advanced.

https://github.com/brunocordioli072/epic7_bot/issues/35#issue-1898183116 the same issue as this, I posted a possible way to fix? or an option to input ip:port manually

I tried turning the file to read only and edit the port for the one that seems to be searched (on the error log) but didnt seem to fix the issue

I tried turning the file to read only and edit the port for the one that seems to be searched (on the error log) but didnt seem to fix the issue

Yeah it doesn't work for me too, maybe the dev can add manual ip:port instead of defined


[camel-main] JTA & Spring-rabbitmq & Sql native fails after upgrade of spring to 6.1.1

Bug description
Camel bumped spring to v6.1.1. (PR)
Upgrade brings following change in sprinframework https://github.com/spring-projects/spring-framework/commit/a20a74817e04e615df4f1f66f4e2f0bd73123ec7#diff-fae118ea93706db8c850a6e31d21c4ff9c6edc5c84ef04cc871176c8a18ff846R177
As you can see, the class kotlin.text.Regex is used in the code.
Its presence causes native build to fail with
Caused by: org.graalvm.compiler.java.BytecodeParser$BytecodeParserError: com.oracle.graal.pointsto.constraints.UnresolvedElementException: Discovered unresolved type during parsing: kotlin.text.Regex. This error is reported at image build time because class org.springframework.core.convert.support.DefaultConversionService is registered for linking at image build time by command line

Native profile is disabled for spring-rabbitmq test, please enable it after solving.

The same issues blocks JTA

Should hopefully be fixed by https://github.com/apache/camel-quarkus/commit/72ff45d11edc96c7eadee188c6da858be8731cb8.

CI verified that https://github.com/apache/camel-quarkus/commit/72ff45d11edc96c7eadee188c6da858be8731cb8 has fixed this.


In 1.5.10, scrolling up a little bit in a chat causes YakYak to load message history and scroll up further

Steps to replicate:

Upgrade to 1.5.10.
Open a chat with some history.
Scroll up at all.

Expected result:
When you stop scrolling, the window stays put.
Actual result:
When you stop scrolling up, after a couple of seconds (presumably network delay) the scroll position changes. Scrolling further causes more unpredictable jumps around. It's sometimes hard to get it to scroll to a particular position and stop. It' sometimes hard to get it to scroll back down to the bottom.
Note:
If I disconnect from the internet before scrolling up, this doesn't happen, so I think it's probably related to message history loading. History loading has always been a little janky but at least in previous versions it didn't get triggered until I had scrolled all the way up.

can confirm that this occurs on macOS Big Sur

In Linux (Mint 19.3) and for me it seems to scroll up randomly and then stays there so I have to scroll back down again. Seems to happen while I'm typing. Otherwise looks to be a similar issue as well.

Happens for me in windows 10 LTSC as well

second confirm that this occurs on macOS Big Sur

Before this gets out of hand: please, folks, don't add "+1"/"ditto" comments on this issue. You can react 👍 to the original comment and/or subscribe to the issue instead. Thanks!

Windows 10 user here. May be related to images in the chat. Seems to jump around those a ton, but plain text isn't so bad.
I thought this issue was present in past releases, but it may have gotten worse with this release or something.

This appears to be fixed in the rolling beta as of December 17, 2020.


[smi] fix sdk bug with TCP Informer

https://github.com/deislabs/smi-sdk-go/issues/33

resolved by community member