SCM autosuggest input does not properly fetch results when re-triggered

Issue Type: Bug
Using GHPR nightly, trigger an autosuggest popup in SCM viewlet using # trigger char. Type some things to fileter. Esc. Trigger again with ctrl+space. No results. In Extension Search and Settings Editor Search, you can escape and retrigger to get the previous suggestions.
VS Code version: Code - Insiders 1.43.0-insider (5996fb81591e92fd0c547dc45e3f0350026d5962, 2020-03-06T23:58:52.927Z)
OS version: Darwin x64 18.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
32.00GB (14.28GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (33)

Extension
Author (truncated)
Version

vscode-track-build-errors
aes
0.0.2

markdown-preview-github-styles
bie
0.1.6

multi-cursor-case-preserve
Car
1.0.5

vscode-svgviewer
css
2.0.0

vscode-eslint
dba
2.1.1

gitlens
eam
10.2.1

tsl-problem-matcher
eam
0.1.1

EditorConfig
Edi
0.14.4

vscode-npm-script
eg2
0.3.11

vscode-firefox-debug
fir
2.7.0

vscode-pull-request-github-insiders
Git
2020.3.8167

search-editor-apply-changes
jak
0.1.1

graphql-for-vscode
kum
1.15.3

find-jump
mks
1.2.4

vscode-selection-flip
mle
1.0.0

python
ms-
2020.2.64397

remote-containers
ms-
0.106.0

remote-ssh
ms-
0.49.0

remote-ssh-edit
ms-
0.49.0

js-debug-nightly
ms-
2020.3.617

vscode-typescript-tslint-plugin
ms-
1.2.3

debugger-for-chrome
msj
4.12.6

toggle
reb
0.0.1

bash-debug
rog
0.3.7

code-settings-sync
Sha
3.4.3

mdx
sil
0.1.0

vscode-multiclip
sle
0.1.5

ayu
tea
0.18.0

polacode-fork
Tox
0.6.0

errorlens
use
3.0.0

vscodeintellicode
Vis
1.2.6

vscode-todo-highlight
way
1.0.4

markdown-all-in-one
yzh
2.7.0

(2 theme extensions excluded)

CC @RMacfarlane not sure if this is core or the extension so I filed here.

I got a ton of feedback that the suggest was too eager and that people don't want issues and users in their suggest when they trigger the suggest manually. So now when you trigger suggest I only provide the users or issues when you trigger it and the previous character is a @ or # respectively.
I suspect in the SCM view it's ok to provide users and issues no matter where the suggest is triggered, whereas in the editor that is not the case.


Subprojects

Awesome, thanks! I added the Core team to this project so that you have push rights now (didn't realize those weren't enabled)

I probably did have push rights. But I wanted to start the habit of moving things into master via pull request.

Ah, good call. Precedent set.


QuantumPlugin - Possibility to bundle shims into app bundle

Actual state:

Shims.js is always bundled using QuantumPlugin into the separate file.

Required state:

To have possibility to bundle shims into one main bundle using QuantumPlugin.

For gulp-like projects is must-have:
https://github.com/jezikk/fuse-box-foundation-starter

@nchanged added to v3 milestone as its a new feature request - pls remove if it's not within scope.

@jezikk it should be easy to implement, maybe you could try submitting a PR? I am very busy ATM

After updating to the latest version shims are bundled into one file using Quantum plugin too. Therefore this issue isn't needed anymore.

My mistake, this issue is still valid.

FuseBox v4 Major Upgrade
As of today, the latest major version of FuseBox v4 is available in fuse-box@next. FuseBox has undergone a full re-write from scratch, learning from its mistakes in the previous versions.
There are a lot of improvements, speed and config wise.
Get started here
We are still working on the documentation and polishing before the major release. We are getting very close. And we need help testing.
npm install fuse-box@next

Most of the issues that I am closing have been resolved, however, if you find that your issue is still relevant in v4 don't hesitate to re-open or (better) create a new one with v4 configuration.


accept gzip encoding

📝 Summary
From a discussion with @zeroecco on how to lower bandwidth on the blocknative relay we came to the idea that we could utilize well known compression like gzip, but only if requests coming from mev-boost specified that.
Minimum transmittable unit is 1500 Bytes total w/ 1250 Bytes realistically usable and a block is around ~12KB, gzip will compress ~60% to ~6Kb which would be a packet reduction from 10 to 5 for the total packet train. This also reduces time to last packet and bandwidth, which could be 1 - 5ms based on response time at this size.
If a system doesn't have this enabled the content-encoding will simply be ignored.
On top of that, this improvement will really only be visible for GetPayload response.
To benefit from this in your relay or other components make sure you configure your reverse proxy [HA Proxy, NGINX, etc] to support gzip!
⛱ Motivation and Context
I want to go fast
📚 References
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding
https://www.rfc-editor.org/rfc/rfc2616#section-3.5
✅ I have run these commands

[x] make lint
[x] make test-race
[x] go mod tidy

Codecov Report

Merging #365 (1939207) into main (496bf59) will increase coverage by 0.47%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   80.94%   81.41%   +0.47%
==========================================
  Files           5        5
  Lines         677      678       +1
==========================================
+ Hits          548      552       +4
+ Misses         99       97       -2
+ Partials       30       29       -1

Flag
Coverage Δ

unittests
81.41% <100.00%> (+0.47%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

server/utils.go
72.85% <100.00%> (+0.39%)
:arrow_up:

server/service.go
79.15% <0.00%> (+0.74%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Could you add a little bit of context please?

Internally our testing did show a time to last packet reduction in deliveries of blocks of roughly 1-5ms depending on the block size and the resources of the validator.
Additionally this change can lead to more time for validators to propose on chain and thereby potentially lead fewer missing proposals though more efficient packet transport over the wider internet.

added some more context @metachris , didn't realize drafts showed up in public repos whoops!

Thanks. I suppose you'd still need to add gzip decoding into the request processing? Like outlined here: https://stackoverflow.com/a/13131806

Awesome good fix! I added a note to the PR as well that for relays and others to enable this make sure you configure your reverse proxy [HA Proxy, NGINX, etc] to support gzip!

The test that lint is tripping up on works for me locally 🤔

I think the test is because of an older staticcheck version, will push a PR

https://github.com/flashbots/mev-boost/pull/374

@dmarzzz could you add a test where the mockserver returns a gzipped response?

Added a test for the gzip response: https://github.com/dmarzzz/mev-boost/pull/1 (needs to be merged by @dmarzzz into his repo to update this PR)

@metachris thanks appreciate it, wasn't able to get to it till this weekend. When I merged it auto dismissed @jtraglia review


Error at "Save tf lite models for best and last checkpoint"

I cant seem to get further than this command, and I have had no luck fixing it myself.
best_index = np.argmax(np.array(history.history['val_angle_metric']) \                      + np.array(history.history['val_direction_metric'])) best_checkpoint = str("cp-%04d.ckpt" % (best_index+1)) best_model = utils.load_model(os.path.join(checkpoint_path,best_checkpoint),loss_fn,metric_list) best_tflite = utils.generate_tflite(checkpoint_path, best_checkpoint) utils.save_tflite (best_tflite, checkpoint_path, "best") print("Best Checkpoint (val_angle: %s, val_direction: %s): %s" \       %(history.history['val_angle_metric'][best_index],\         history.history['val_direction_metric'][best_index],\         best_checkpoint))
It returns the error
`---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
 in
2                      + np.array(history.history['val_direction_metric']))
3 best_checkpoint = str("cp-%04d.ckpt" % (best_index+1))
----> 4 best_model = utils.load_model(os.path.join(checkpoint_path,best_checkpoint),loss_fn,metric_list)
5 best_tflite = utils.generate_tflite(checkpoint_path, best_checkpoint)
6 utils.save_tflite (best_tflite, checkpoint_path, "best")
~/git/OpenBot/policy/utils.py in load_model(model_path, loss_fn, metric_list)
72
73 def load_model(model_path,loss_fn,metric_list):
---> 74     model = tf.keras.models.load_model(model_path,
75     custom_objects=None,
76     compile=False
~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/keras/saving/save.py in load_model(filepath, custom_objects, compile)
188     if isinstance(filepath, six.string_types):
189       loader_impl.parse_saved_model(filepath)
--> 190       return saved_model_load.load(filepath, compile)
191
192   raise IOError(
~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/keras/saving/saved_model/load.py in load(path, compile)
114   # TODO(kathywu): Add saving/loading of optimizer, compiled losses and metrics.
115   # TODO(kathywu): Add code to load from objects that contain all endpoints
--> 116   model = tf_load.load_internal(path, loader_cls=KerasObjectLoader)
117
118   # pylint: disable=protected-access
~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/saved_model/load.py in load_internal(export_dir, tags, loader_cls)
600     object_graph_proto = meta_graph_def.object_graph_def
601     with ops.init_scope():
--> 602       loader = loader_cls(object_graph_proto,
603                           saved_model_proto,
604                           export_dir)
~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/keras/saving/saved_model/load.py in init(self, *args, **kwargs)
186     self._models_to_reconstruct = []
187
--> 188     super(KerasObjectLoader, self).init(*args, **kwargs)
189
190     # Now that the node object has been fully loaded, and the checkpoint has
~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/saved_model/load.py in init(self, object_graph_proto, saved_model_proto, export_dir)
121       self._concrete_functions[name] = _WrapperFunction(concrete_function)
122
--> 123     self._load_all()
124     self._restore_checkpoint()
125
~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/keras/saving/saved_model/load.py in _load_all(self)
207     # loaded from config may create variables / other objects during
208     # initialization. These are recorded in _nodes_recreated_from_config.
--> 209     self._layer_nodes = self._load_layers()
210
211     # Load all other nodes and functions.
~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/keras/saving/saved_model/load.py in _load_layers(self)
310
311     for node_id, proto in metric_list:
--> 312       layers[node_id] = self._load_layer(proto.user_object, node_id)
313     return layers
314
~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/keras/saving/saved_model/load.py in _load_layer(self, proto, node_id)
335     obj, setter = self._revive_from_config(proto.identifier, metadata, node_id)
336     if obj is None:
--> 337       obj, setter = revive_custom_object(proto.identifier, metadata)
338
339     # Add an attribute that stores the extra functions/objects saved in the
~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/keras/saving/saved_model/load.py in revive_custom_object(identifier, metadata)
776     return revived_cls._init_from_metadata(metadata)  # pylint: disable=protected-access
777   else:
--> 778     raise ValueError('Unable to restore custom object of type {} currently. '
779                      'Please make sure that the layer implements get_config'
780                      'and from_config when saving. In addition, please use '
ValueError: Unable to restore custom object of type _tf_keras_metric currently. Please make sure that the layer implements get_configand from_config when saving. In addition, please use the custom_objects arg when calling load_model().
`
Every thing else runs smoothly.

Can you show the output of the model.fit? Did you change any of the metrics?
Please put code or error output between "```" at the beginning and end, so it is formated for easier reading. You can also use the <> button the comment field.

Haven't changed anything.
My bad!
Epoch 1/10 664/666 [============================>.] - ETA: 0s - loss: 0.0354 - mean_absolute_error: 0.3235 - direction_metric: 0.7452 - angle_metric: 0.2609WARNING:tensorflow:From /home/bso/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/ops/resource_variable_ops.py:1813: calling BaseResourceVariable.__init__ (from tensorflow.python.ops.resource_variable_ops) with constraint is deprecated and will be removed in a future version. Instructions for updating: If using Keras pass *_constraint arguments to layers. INFO:tensorflow:Assets written to: models/my_openbot_pilot_net_lr0.0001_bz16_bn/checkpoints/cp-0001.ckpt/assets 666/666 [==============================] - 36s 54ms/step - loss: 0.0354 - mean_absolute_error: 0.3231 - direction_metric: 0.7456 - angle_metric: 0.2614 - val_loss: 0.0378 - val_mean_absolute_error: 0.2368 - val_direction_metric: 0.6941 - val_angle_metric: 0.2679 Epoch 2/10 665/666 [============================>.] - ETA: 0s - loss: 0.0141 - mean_absolute_error: 0.2061 - direction_metric: 0.7992 - angle_metric: 0.3699INFO:tensorflow:Assets written to: models/my_openbot_pilot_net_lr0.0001_bz16_bn/checkpoints/cp-0002.ckpt/assets 666/666 [==============================] - 13s 20ms/step - loss: 0.0141 - mean_absolute_error: 0.2061 - direction_metric: 0.7993 - angle_metric: 0.3698 - val_loss: 0.0323 - val_mean_absolute_error: 0.2250 - val_direction_metric: 0.7267 - val_angle_metric: 0.3096 Epoch 3/10 665/666 [============================>.] - ETA: 0s - loss: 0.0120 - mean_absolute_error: 0.1963 - direction_metric: 0.8053 - angle_metric: 0.3964INFO:tensorflow:Assets written to: models/my_openbot_pilot_net_lr0.0001_bz16_bn/checkpoints/cp-0003.ckpt/assets 666/666 [==============================] - 13s 20ms/step - loss: 0.0120 - mean_absolute_error: 0.1963 - direction_metric: 0.8052 - angle_metric: 0.3964 - val_loss: 0.0313 - val_mean_absolute_error: 0.2178 - val_direction_metric: 0.7225 - val_angle_metric: 0.3053 Epoch 4/10 664/666 [============================>.] - ETA: 0s - loss: 0.0100 - mean_absolute_error: 0.1848 - direction_metric: 0.8147 - angle_metric: 0.4127INFO:tensorflow:Assets written to: models/my_openbot_pilot_net_lr0.0001_bz16_bn/checkpoints/cp-0004.ckpt/assets 666/666 [==============================] - 13s 20ms/step - loss: 0.0100 - mean_absolute_error: 0.1848 - direction_metric: 0.8142 - angle_metric: 0.4124 - val_loss: 0.0347 - val_mean_absolute_error: 0.2267 - val_direction_metric: 0.7118 - val_angle_metric: 0.3225 Epoch 5/10 665/666 [============================>.] - ETA: 0s - loss: 0.0093 - mean_absolute_error: 0.1814 - direction_metric: 0.8133 - angle_metric: 0.4215INFO:tensorflow:Assets written to: models/my_openbot_pilot_net_lr0.0001_bz16_bn/checkpoints/cp-0005.ckpt/assets 666/666 [==============================] - 14s 20ms/step - loss: 0.0093 - mean_absolute_error: 0.1814 - direction_metric: 0.8133 - angle_metric: 0.4215 - val_loss: 0.0327 - val_mean_absolute_error: 0.2061 - val_direction_metric: 0.7230 - val_angle_metric: 0.3262 Epoch 6/10 665/666 [============================>.] - ETA: 0s - loss: 0.0085 - mean_absolute_error: 0.1778 - direction_metric: 0.8185 - angle_metric: 0.4393INFO:tensorflow:Assets written to: models/my_openbot_pilot_net_lr0.0001_bz16_bn/checkpoints/cp-0006.ckpt/assets 666/666 [==============================] - 14s 21ms/step - loss: 0.0085 - mean_absolute_error: 0.1777 - direction_metric: 0.8187 - angle_metric: 0.4393 - val_loss: 0.0330 - val_mean_absolute_error: 0.2147 - val_direction_metric: 0.7070 - val_angle_metric: 0.3209 Epoch 7/10 665/666 [============================>.] - ETA: 0s - loss: 0.0083 - mean_absolute_error: 0.1772 - direction_metric: 0.8145 - angle_metric: 0.4416INFO:tensorflow:Assets written to: models/my_openbot_pilot_net_lr0.0001_bz16_bn/checkpoints/cp-0007.ckpt/assets 666/666 [==============================] - 13s 20ms/step - loss: 0.0083 - mean_absolute_error: 0.1771 - direction_metric: 0.8147 - angle_metric: 0.4415 - val_loss: 0.0314 - val_mean_absolute_error: 0.2252 - val_direction_metric: 0.7139 - val_angle_metric: 0.3278 Epoch 8/10 665/666 [============================>.] - ETA: 0s - loss: 0.0074 - mean_absolute_error: 0.1719 - direction_metric: 0.8180 - angle_metric: 0.4595INFO:tensorflow:Assets written to: models/my_openbot_pilot_net_lr0.0001_bz16_bn/checkpoints/cp-0008.ckpt/assets 666/666 [==============================] - 13s 20ms/step - loss: 0.0074 - mean_absolute_error: 0.1720 - direction_metric: 0.8181 - angle_metric: 0.4594 - val_loss: 0.0338 - val_mean_absolute_error: 0.2041 - val_direction_metric: 0.7160 - val_angle_metric: 0.3064 Epoch 9/10 665/666 [============================>.] - ETA: 0s - loss: 0.0070 - mean_absolute_error: 0.1680 - direction_metric: 0.8154 - angle_metric: 0.4677INFO:tensorflow:Assets written to: models/my_openbot_pilot_net_lr0.0001_bz16_bn/checkpoints/cp-0009.ckpt/assets 666/666 [==============================] - 13s 20ms/step - loss: 0.0070 - mean_absolute_error: 0.1680 - direction_metric: 0.8153 - angle_metric: 0.4677 - val_loss: 0.0316 - val_mean_absolute_error: 0.1991 - val_direction_metric: 0.7112 - val_angle_metric: 0.3112 Epoch 10/10 665/666 [============================>.] - ETA: 0s - loss: 0.0066 - mean_absolute_error: 0.1646 - direction_metric: 0.8239 - angle_metric: 0.4740INFO:tensorflow:Assets written to: models/my_openbot_pilot_net_lr0.0001_bz16_bn/checkpoints/cp-0010.ckpt/assets 666/666 [==============================] - 13s 20ms/step - loss: 0.0066 - mean_absolute_error: 0.1646 - direction_metric: 0.8238 - angle_metric: 0.4740 - val_loss: 0.0315 - val_mean_absolute_error: 0.2098 - val_direction_metric: 0.7321 - val_angle_metric: 0.3198

What's your tensorflow and conda version?

conda is 4.8.3 and tensorflow is 2.2.0

Try removing the custom metrics in the first cell of the training section.
metric_list = ['MeanAbsoluteError', metrics.direction_metric, metrics.angle_metric]
to
metric_list = ['MeanAbsoluteError']
In the meantime I'll see if I can reproduce your error somehow.

Hmmm... tried doing as you suggested and now i run into a new error (even if I set the custom metrics back).
When plotting the metrics, it gives a key error.
plt.plot(history.history['MeanAbsoluteError'], label='mean_absolute_error') plt.plot(history.history['val_MeanAbsoluteError'], label = 'val_mean_absolute_error') plt.xlabel('Epoch') plt.ylabel('Mean Absolute Error') plt.legend(loc='lower right') plt.savefig(os.path.join(log_path,'error.png'))
KeyError                                  Traceback (most recent call last) <ipython-input-37-1e2ff90cb985> in <module> ----> 1 plt.plot(history.history['MeanAbsoluteError'], label='mean_absolute_error')       2 plt.plot(history.history['val_MeanAbsoluteError'], label = 'val_mean_absolute_error')       3 plt.xlabel('Epoch')       4 plt.ylabel('Mean Absolute Error')       5 plt.legend(loc='lower right')
KeyError: 'MeanAbsoluteError'

You need to restart the kernel and run the notebook again. The plots with the custom metrics won't work.

Okay when running with just
 metric_list = ['MeanAbsoluteError']
I receive the error
KeyError                                  Traceback (most recent call last) <ipython-input-37-62c19ef5d999> in <module> ----> 1 best_index = np.argmax(np.array(history.history['val_angle_metric']) \       2                      + np.array(history.history['val_direction_metric']))       3 best_checkpoint = str("cp-%04d.ckpt" % (best_index+1))       4 best_model = utils.load_model(os.path.join(checkpoint_path,best_checkpoint),loss_fn,metric_list)       5 best_tflite = utils.generate_tflite(checkpoint_path, best_checkpoint)
KeyError: 'val_angle_metric'
When doing the best_index part.

Yes. Because you don't have the angle metric now. You need to replace it with val_mean_absolute_error

Can you try adding import metrics to the utils.py file?

Added import metrics to the utils.py file.
The error doesn't appear at best_index now, but has moved down to best_model.
<ipython-input-41-164fa3b8c5aa> in <module>
----> 1 best_model = utils.load_model(os.path.join(checkpoint_path,best_checkpoint),loss_fn,metric_list)
      2 test_loss, test_acc, test_dir, test_ang = best_model.evaluate(test_ds, steps=image_count_test/TEST_BATCH_SIZE, verbose=2)

~/git/OpenBot/policy/utils.py in load_model(model_path, loss_fn, metric_list)
     73
     74 def load_model(model_path,loss_fn,metric_list):
---> 75     model = tf.keras.models.load_model(model_path,
     76     custom_objects=None,
     77     compile=False

~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/keras/saving/save.py in load_model(filepath, custom_objects, compile)
    188     if isinstance(filepath, six.string_types):
    189       loader_impl.parse_saved_model(filepath)
--> 190       return saved_model_load.load(filepath, compile)
    191
    192   raise IOError(

~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/keras/saving/saved_model/load.py in load(path, compile)
    114   # TODO(kathywu): Add saving/loading of optimizer, compiled losses and metrics.
    115   # TODO(kathywu): Add code to load from objects that contain all endpoints
--> 116   model = tf_load.load_internal(path, loader_cls=KerasObjectLoader)
    117
    118   # pylint: disable=protected-access

~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/saved_model/load.py in load_internal(export_dir, tags, loader_cls)
    600     object_graph_proto = meta_graph_def.object_graph_def
    601     with ops.init_scope():
--> 602       loader = loader_cls(object_graph_proto,
    603                           saved_model_proto,
    604                           export_dir)

~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/keras/saving/saved_model/load.py in __init__(self, *args, **kwargs)
    186     self._models_to_reconstruct = []
    187
--> 188     super(KerasObjectLoader, self).__init__(*args, **kwargs)
    189
    190     # Now that the node object has been fully loaded, and the checkpoint has

~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/saved_model/load.py in __init__(self, object_graph_proto, saved_model_proto, export_dir)
    121       self._concrete_functions[name] = _WrapperFunction(concrete_function)
    122
--> 123     self._load_all()
    124     self._restore_checkpoint()
    125

~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/keras/saving/saved_model/load.py in _load_all(self)
    207     # loaded from config may create variables / other objects during
    208     # initialization. These are recorded in `_nodes_recreated_from_config`.
--> 209     self._layer_nodes = self._load_layers()
    210
    211     # Load all other nodes and functions.

~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/keras/saving/saved_model/load.py in _load_layers(self)
    310
    311     for node_id, proto in metric_list:
--> 312       layers[node_id] = self._load_layer(proto.user_object, node_id)
    313     return layers
    314

~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/keras/saving/saved_model/load.py in _load_layer(self, proto, node_id)
    335     obj, setter = self._revive_from_config(proto.identifier, metadata, node_id)
    336     if obj is None:
--> 337       obj, setter = revive_custom_object(proto.identifier, metadata)
    338
    339     # Add an attribute that stores the extra functions/objects saved in the

~/anaconda3/envs/openbot/lib/python3.8/site-packages/tensorflow/python/keras/saving/saved_model/load.py in revive_custom_object(identifier, metadata)
    776     return revived_cls._init_from_metadata(metadata)  # pylint: disable=protected-access
    777   else:
--> 778     raise ValueError('Unable to restore custom object of type {} currently. '
    779                      'Please make sure that the layer implements `get_config`'
    780                      'and `from_config` when saving. In addition, please use '

ValueError: Unable to restore custom object of type _tf_keras_metric currently. Please make sure that the layer implements `get_config`and `from_config` when saving. In addition, please use the `custom_objects` arg when calling `load_model()`.`````

Can you pass the two custom metrics with the custom_objects arg?
If this does not work, you can also try the following workaround.
Above the cell that throws the error, define this function.
def load_model(model_path):
    model = tf.keras.models.load_model(model_path,
    custom_objects=None,
    compile=False
    )
    model.compile(loss=loss_fn,
                  metrics=metric_list)
    return model

In the cell that throws the error, replace
best_model = utils.load_model(os.path.join(checkpoint_path,best_checkpoint),loss_fn,metric_list)

with
best_model = load_model(os.path.join(checkpoint_path,best_checkpoint))

Okay now things are cooking op nicely.
Redefined the function as you said, however i added custom_object as parameter.
def load_model(model_path, custom_object):     model = tf.keras.models.load_model(model_path,     custom_objects=custom_object,     compile=False     )     model.compile(loss=loss_fn,                    metrics=metric_list)     return model
Then i could pass the custom metrics as a dict.
best_model = load_model(os.path.join(checkpoint_path,best_checkpoint),{'direction_metric':metrics.direction_metric, 'angle_metric':metrics.angle_metric},)
Guess I could have changed the load_model in utils.py the same way and have gotten the same result.
Thank you for the help! I will get started on teaching my robot some policies.

Did the function inside the notebook work without passing custom objects? This would indicate it's an issue with the scope. Yes, passing the dictionary of custom objects and leaving the code in util should also work.
Trying to figure out why you were facing the issue since other including myself don't. If we understand why, we can fix it for others that may come across this issue. Main reason why I prefer not to pass is in case people change the metric dictionary. But maybe it makes sense to just pass all custom metrics, just in case.

Nope it didn't work without passing. Still getting the same error as before.
Ah yes makes sense. So far I've tried running the code on my laptop and my workstation, both result in the same error. Both running on Ubuntu 18.04.

Strange, I have been able to run it without problems on Ubuntu 18.04, also on Mac and Windows. Are you using a conda environment? If yes, what is the version of conda, tensorflow and jupyter notebook?

Okay so i messed up my ubuntu partition yesterday and had to do a fresh install. Thought i would test out this one, before installing anything else. The error still occurred with a fresh install and fresh git clone.
I am running conda version 4.8.3
Tensorflow 2.2
jupyter notebook 6.0.3

I see. I'm using tf 2.0.0. Maybe this is a 'new feature'.

Could you do me a favour and try to install this environment:
conda create -n openbot_test python=3.7 tensorflow=2.0.0 notebook=6.1.1 matplotlib=3.3.1 pillow=7.2.0

Yup it seems to work now. So it looks lige a "new feature"...
How ever it didn't use the gpu for the calculations as default, as it did with 2.2.
Is there a way to force it to use gpu?

If you want to use the GPU, you need to install tensorflow-gpu.

Yup it seems to work now. So it looks lige a "new feature"...

Great, I will add a note then for people that want to use newer versions of tensorflow.
It's not high priority, but if I get a chance, I may update the code and port it to tf2.2.
However, on Mac for example tf2.0 still gets installed by default.


Cannot open some of the aggregated groups after stratification

Release number or git hash: latest local
Web browser version and OS: chrome

Steps to reproduce
I don't really know how to reproduce it. However, this behavior was also observed by @dfuchs1702 in the TourGuide instance.

Observed behavior

Aggregated groups cannot be opened by clicking on arrow.

invalid, since the underlying issue #485  was solved


Add Support for Jenkins

Feature request to add support for tracking time on Jenkins.
Will definitely help those who want to track time Editing Jenkins Job.

Thank you for the suggestion.
We are not currently actively developing new integrations ourselves but I've added your request to the most wanted list https://github.com/toggl/toggl-button/wiki/User-requested-buttons


Add Mutating & Validating webhook for SampleSource

Fixes #52 .
basically, a shameless copy of GithubSource, partially from sample-controller and several comments to describe the behavior.

/assign

/ok-to-test

Can you pull in the latest pkg (./hack/update-deps.sh --upgrade) and add the block of yaml from: https://github.com/knative/pkg/pull/1318 to the process running the webhook.

/lgtm
/approve
Thanks!


Add example to add a recommended VS Code extensions across all repos

Closes sourcegraph/sourcegraph#40199
It looks like I have worked on this at the same time as @malomarrec 😐. The main difference is that my script is written in JavaScript instead of python, lol. Thread with more context on how that happened here.
It took me a while to find a library that can modify the jsonc spec files VS Code is using (JSON + comments) which keeps the comments up and does not reformat everything. I am not sure if the python script by @malomarrec handles this case so I post mine as well.
I also put it into the js/ts examples folder since this is useful for other VS Code extensions as well, not only ours 😉
Test Plan
I ran it on S2. The diffs it created seem reasonable. I also found that sourcegraph/sourcegraph and sourcegraph/devx-scratch already have the extension added to the recommendation list.

@malomarrec @sourcegraph/batchers I can't tag you for review (I don't have merge rights to this repo?) so pinging you here instead. Can you take a look at this PR?

Someone also has to merge this on my behalf I’m afraid 😞


Config file not found?

Config file could not be found, and is required for starting the bot
Please read the instructions and try again
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.

[Process completed]

This is the result of running the CommandCenter executable. The BotConfig.txt is located in the bin folder with the executable. The only change I made to it was the map to be played on. I believe I've followed all the instructions for the Mac install. I had to edit a file in the the s2client-api code, comment out line 17867 in civetweb.c, to stop warnings from being treated as errors. The only part I wasn't sure about was downloading the maps from  https://github.com/Blizzard/s2client-proto#downloads. I downloaded one map pack and extracted the map files in to a folder that I created in my starcraft2 application called maps. I had to create maps folder because there wasn't a folder with that name already.
Does anyone have a suggestion for what I may have done wrong?

Are you running the executable with the bin folder as the cwd?

Its the same result whether I'm working in commandcenter and run bin/CommandCenter or if I'm in bin and run CommandCenter.

I was also having this problem- changing the line
 std::string config = JSONTools::ReadFile("BotConfig.txt");
in main.cpp to the full file address fixed the problem for me.

It's definitely a problem with your working directory then
On Tue, May 15, 2018, 11:51 PM wfawwer<EMAIL_ADDRESS>wrote:

I was also having this problem- changing the line
std::string config = JSONTools::ReadFile("BotConfig.txt");
in main.cpp to the full file address fixed the problem for me.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/davechurchill/commandcenter/issues/72#issuecomment-389373905,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIkqOzx7xtH4nEhbblHGU4IQiaix-Liks5ty40pgaJpZM4T-OdO
.

Thanks @wfawwer! That fixed my issues. If someone else has this issue in the future there are two spots in the main.cpp to fix the path.


SwaggerDefaultValues doesn't set the default value for boolean properties correctly

Hi.
.\samples\aspnetcore\SwaggerODataSample\SwaggerDefaultValues.cs assumes properties are strings and this causes some issues.
For example:

Run the samples\aspnetcore\SwaggerODataSample project
Select definition V3
Expand GET /api/Acme/Products
Click Try it out
Click Execute
Notice the $count parameter is required to be manually set to true or false.

I found a solution to this problem here:
https://github.com/microsoft/aspnet-api-versioning/issues/429#issuecomment-605402330

I found a solution to this problem here:
https://github.com/microsoft/aspnet-api-versioning/issues/429#issuecomment-605402330

I'm sure why this issue didn't auto-close, but I believe you PR fixes this issue. If I'm mistaken, please re-open. Thanks


problem with CONFIG_STACK_SENTINEL

After pulling the latest zephyr commit my firmware breaks when a task switch/isr is done - somehow reliably
[00:00:05.859,000] <dbg> BATTERY.battery_thread: start battery sensing
[00:00:05.8[00:00:05.867,000] <err> os: r0/a1:  0x00000002  r1/a2:  0x20004a80  r2/a3:  0xf0f0f0f0
[00:00:05.875,000] <err> os: r3/a4:  0x20004c80 r12/ip:  0x00000020 r14/lr:  0x08019f73
[00:00:05.884,000] <err> os:  xpsr:  0x41000000
[00:00:05.889,000] <err> os: s[ 0]:  0x00000000  s[ 1]:  0x00000000  s[ 2]:  0x00000000  s[ 3]:  0x00000000
[00:00:05.900,000] <err> os: s[ 4]:  0x00000000  s[ 5]:  0x00000000  s[ 6]:  0x00000000  s[ 7]:  0x00000000
[00:00:05.910,000] <err> os: s[ 8]:  0x00000000  s[ 9]:  0x00000000  s[10]:  0x00000000  s[11]:  0x00000000
[00:00:05.920,000] <err> os: s[12]:  0x00000000  s[13]:  0x00000000  s[14]:  0x00000000  s[15]:  0x00000000
[00:00:05.931,000] <err> os: fpscr:  0x00000000
[00:00:05.936,000] <err> os: EXC_RETURN: 0x0
[00:00:05.941,000] <err> os: Faulting instruction address (r15/pc): 0x0801a38a
[00:00:05.949,000] <err> os: >>> ZEPHYR FATAL ERROR 2: Stack overflow on CPU 0
[00:00:05.957,000] <err> os: Current thread: 0x20001678 (batteryThread_id)

checking the map file:
.text.z_impl_k_thread_name_set
                0x000000000801a33c       0x24 kernel/libkernel.a(thread.c.obj)
                0x000000000801a33c                z_impl_k_thread_name_set
 .text.z_check_stack_sentinel
                0x000000000801a360       0x30 kernel/libkernel.a(thread.c.obj)
                0x000000000801a360                z_check_stack_sentinel
 .text.schedule_new_thread
                0x000000000801a390       0x1c kernel/libkernel.a(thread.c.obj)```

reveals that the z_check_stack_sentinel function fails.
Inside the battery thread an ADC(DMA driven) conversion is triggered.
// adc dma isr handler
ISR_DIRECT_DECLARE(DMA2_Stream0_IRQHandler) {
	ISR_DIRECT_HEADER();
	// Check transfer-complete interrupt
	if (LL_DMA_IsEnabledIT_TC(ADC1_DMA, ADC1_DMA_STREAM) && LL_DMA_IsActiveFlag_TC0(ADC1_DMA)) {
		LL_DMA_ClearFlag_TC0(ADC1_DMA);             // Clear half-transfer complete flag
		LL_ADC_Disable(ADC1); // disable adc
		// indicate that we are done
		k_sem_give(&adc1_dma.adcDone);
	}
	ISR_DIRECT_FOOTER(1);
	ISR_DIRECT_PM(); // PM done after servicing interrupt for best latency
	return 1; // We should check if scheduling decision should be made
}

A semaphore is set at the isr. The battery thread is waiting for that semaphore. Guess that mechanism breaks the sentinel.
When disabling CONFIG_STACK_SENTINEL my firmware works perfectly.
Anyone that has the same problem?
My arch STM32F412 + custom board + custom shield

@StefJar I'd rather move this to question since this rather looks like a question on STACK_SENTINEL behavior for now.
@nashif I let you check how can have a check on this as it rather looks like a kernel question (STM32 code extract is not upstream code)

@StefJar isn’t this just a stack overflow? Have you tried increasing stack sizes?

@StefJar isn’t this just a stack overflow? Have you tried increasing stack sizes? In particular the battery_thread stack

That is what the error is saying. So I increased the stack for the thread from 1024B to 2048B.
Is this might related to logging (I have synchronous logging enabled)?

hey ho
looks like threads have different functions
I am a bit confused
there are thread samples with no parameters (https://github.com/zephyrproject-rtos/zephyr/tree/master/samples/basic/threads)
and
there is the API telling about 3 parameters (https://docs.zephyrproject.org/latest/reference/kernel/threads/index.html#c.k_thread_create)
my code works like this
#define MAIN_THREADS_STACK_SIZE (1024)
#define MAIN_THREADS_OPTIONS (K_FP_REGS )
#define THREAD_PRIO_BATTERY 6

void battery_thread(void *dummy1, void *dummy2, void *dummy3);

K_THREAD_DEFINE(batteryThread_id, MAIN_THREADS_STACK_SIZE, battery_thread, NULL, NULL, NULL, THREAD_PRIO_BATTERY, MAIN_THREADS_OPTIONS, 0);

Guess something gets messed up at the thread creation

Looks like this is related to ISRs and thread switching.
in this case
the main thread runs while "BC127" thread starts. The battery voltage is measured so the ADC1 streams the data via DMA2 to the memory.
 The thread function now takes 3 arguments and the adc isr is coded like the Zephyr documentation says:
// adc dma isr handler
ISR_DIRECT_DECLARE(DMA2_Stream0_IRQHandler) {
	// Check transfer-complete interrupt
	if (LL_DMA_IsEnabledIT_TC(ADC1_DMA, ADC1_DMA_STREAM) && LL_DMA_IsActiveFlag_TC0(ADC1_DMA)) {
		LL_DMA_ClearFlag_TC0(ADC1_DMA);             // Clear half-transfer complete flag
		LL_ADC_Disable(ADC1); // disable adc
		// indicate that we are done
		k_sem_give(&adc1_dma.adcDone);
	}
	LOG_DBG("adc dma isr");
	ISR_DIRECT_PM(); // PM done after servicing interrupt for best latency
	return 1; // We should check if scheduling decision should be made
}

I removed all own driver related ISRs and replaced them with the current Zephyr APIs.
I am getting now a "HARD FAULT". This happens when the main thread switches to an other thread.  When starting the debugger and reseting the MCU this breakpoint is not hit. Means that the kernel somehow starts but when changing to the main thread it fails with an stack overflow exception.

I got the nucleo_f429zi board but I have not been able to reproduce it with the following apps and CONFIG_STACK_SENTINEL=y:

samples/hello_world
tests/kernel/sched/schedule_api
tests/kernel/threads/thread_apis
tests/kernel/workq/work_queue
tests/kernel/fatal/exception

Is this issue reproducible with any samples or tests apps?

didn't expected any fails with the CI tests
Maybe the combination of
CONFIG_STACK_USAGE=y
CONFIG_STACK_SENTINEL=y
CONFIG_INIT_STACKS=y
CONFIG_SCHED_MULTIQ=y
CONFIG_WAITQ_SCALABLE=y

causes the problems.
Just in case I am quickly attaching my board defconfig file
# arch
CONFIG_SOC_STM32F412ZG=y
CONFIG_SOC_SERIES_STM32F4X=y
CONFIG_BOARD_KRHD1_V1_4A=y

# fp support
CONFIG_FPU=y
CONFIG_FPU_SHARING=y

# MMU
CONFIG_ARM_MPU=y
# MMU for threads
CONFIG_MPU_STACK_GUARD=y
# thread stack protection done by hw
CONFIG_HW_STACK_PROTECTION=y
CONFIG_MPU_ALLOW_FLASH_WRITE=y

# interrupts
CONFIG_DYNAMIC_INTERRUPTS=y
CONFIG_ZERO_LATENCY_IRQS=y
CONFIG_SW_VECTOR_RELAY=y
CONFIG_CORTEX_M_DWT=y
# CONFIG_MULTI_LEVEL_INTERRUPTS=y
CONFIG_EXTRA_EXCEPTION_INFO=y

# reset stm32f412 regs at startup
CONFIG_INIT_ARCH_HW_AT_BOOT=y

# code offset defined inside the dts
# CONFIG_USE_DT_CODE_PARTITION=y

# kernel
CONFIG_STACK_USAGE=y
CONFIG_STACK_SENTINEL=y
CONFIG_INIT_STACKS=y
CONFIG_BOOT_BANNER=n
CONFIG_SCHED_MULTIQ=y
CONFIG_WAITQ_SCALABLE=y
# CONFIG_KERNEL_LOG_LEVEL_DBG=y

# enable pinmux
CONFIG_PINMUX=y

# DMA
CONFIG_DMA=y

# uart
CONFIG_UART_STM32=y
CONFIG_UART_INTERRUPT_DRIVEN=y
CONFIG_UART_DRV_CMD=y
CONFIG_UART_ASYNC_API=y
CONFIG_UART_LINE_CTRL=y

# rtc
CONFIG_COUNTER=y
CONFIG_COUNTER_RTC_STM32_CLOCK_LSE=y
CONFIG_COUNTER_RTC_STM32_BACKUP_DOMAIN_RESET=n

# pwm
CONFIG_PWM=y
CONFIG_PWM_STM32=y

# GPIO
CONFIG_GPIO=y

# I2C
CONFIG_I2C=y
CONFIG_I2C_STM32=y
CONFIG_I2C_1=y
CONFIG_I2C_STM32_INTERRUPT=y

# SPI
CONFIG_SPI=y
#CONFIG_SPI_1=y
#CONFIG_SPI_1_OP_MODES=1
#CONFIG_SPI_3=y
#CONFIG_SPI_3_OP_MODES=1
CONFIG_SPI_STM32_INTERRUPT=y

# adc
# use own driver
CONFIG_ADC=y

# watchdog
# CONFIG_WATCHDOG=y
# CONFIG_WDT_DISABLE_AT_BOOT=y
# CONFIG_WWDG_STM32=y
# CONFIG_IWDG_STM32_TIMEOUT=1000

# usb
CONFIG_USB=y
CONFIG_USB_DC_STM32=y
CONFIG_USB_DEVICE_STACK=y
CONFIG_USB_DEVICE_VID=0x2FE4
CONFIG_USB_DEVICE_PID=0x1
CONFIG_USB_DEVICE_MANUFACTURER="Kokoon Technology Limited"
CONFIG_USB_DEVICE_PRODUCT="Kokoon Relax2"
CONFIG_USB_DEVICE_SN="KR-HD1-00001"
CONFIG_USB_MAX_POWER=250
CONFIG_USB_CDC_ACM=y
# no vbus signaling - we us it as input
# CONFIG_USB_VBUS_GPIO=y
# CONFIG_USB_VBUS_GPIO_DEV_NAME="GPIOA"
# CONFIG_USB_VBUS_GPIO_PIN_NUM=9
CONFIG_USB_CDC_ACM_LOG_LEVEL_ERR=y
CONFIG_USB_DEVICE_LOG_LEVEL_ERR=y

# led
CONFIG_LED=y

# power saving
# CONFIG_SYS_POWER_MANAGEMENT=y
# save power when idleing
# CONFIG_TICKLESS_IDLE=y
# sleep states
# CONFIG_SYS_POWER_SLEEP_STATES=y
# CONFIG_SYS_POWER_DEEP_SLEEP_STATES=y
# device sleep policy
# CONFIG_DEVICE_POWER_MANAGEMENT=y

#flash
CONFIG_FLASH=y
CONFIG_SOC_FLASH_STM32=y
# CONFIG_SPI_NOR=y
# CONFIG_SPI_NOR_PAGE_SIZE=256
# CONFIG_SPI_NOR_SECTOR_SIZE=4096

# clock configuration
CONFIG_CLOCK_CONTROL=y
CONFIG_CLOCK_CONTROL_LOG_LEVEL_DBG=y

# Clock configuration for Cube Clock control driver
CONFIG_CLOCK_STM32_HSE_CLOCK=24000000
CONFIG_CLOCK_STM32_SYSCLK_SRC_PLL=y

# use HSE as PLL input
CONFIG_CLOCK_STM32_PLL_SRC_HSE=y

# the board have an external oscillator
CONFIG_CLOCK_STM32_HSE_BYPASS=n

# produce 96MHz clock at PLL output
CONFIG_CLOCK_STM32_PLL_M_DIVISOR=24
CONFIG_CLOCK_STM32_PLL_N_MULTIPLIER=144
CONFIG_CLOCK_STM32_PLL_P_DIVISOR=6
# 48MHz for usb
CONFIG_CLOCK_STM32_PLL_Q_DIVISOR=3

CONFIG_CLOCK_STM32_AHB_PRESCALER=1
CONFIG_CLOCK_STM32_APB1_PRESCALER=2
CONFIG_CLOCK_STM32_APB2_PRESCALER=1

# take care that we enable coretex clk as sysclk
CONFIG_CORTEX_M_SYSTICK=y
CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC=24000000

# serial
CONFIG_SERIAL=y

# console
CONFIG_CONSOLE=y
CONFIG_UART_CONSOLE=y
CONFIG_STDOUT_CONSOLE=y
# CONFIG_UART_CONSOLE_DEBUG_SERVER_HOOKS=y

# log
CONFIG_LOG=y
CONFIG_LOG_BACKEND_SHOW_COLOR=n
# CONFIG_LOG_PROCESS_THREAD=y
# CONFIG_LOG_INPLACE_PROCESS=y
CONFIG_LOG_MODE_IMMEDIATE=y

# CONFIG_LOG_BUFFER_SIZE=4096
# CONFIG_LOG_PROCESS_TRIGGER_THRESHOLD=1

CONFIG_MAIN_STACK_SIZE=2048
# CONFIG_MAIN_STACK_SIZE=4096

CONFIG_RING_BUFFER=y

# enable system reboot functions
CONFIG_REBOOT=y

# CONFIG_REQUIRES_FULL_LIBC=y
CONFIG_NEWLIB_LIBC=y

Building with west build -p -b nucleo_f429zi tests/kernel/threads/thread_apis/ -- -DCONFIG_INIT_STACKS=y -DCONFIG_INIT_ARCH_HW_AT_BOOT=y -DCONFIG_STACK_SENTINEL=y -DCONFIG_STACK_USAGE=y -DCONFIG_FPU=y -DCONFIG_FPU_SHARING=y -DCONFIG_SCHED_MULTIQ=y -DCONFIG_WAITQ_SCALABLE=y and it's not crashing on my board.
One thing I can think of is that, there are enabled interrupts on your board and they are firing before the switch to main thread is completed, thus corrupting the interrupt stack. However, without a way to reproduce it using the available apps in the tree, it is impossible to figure out what is wrong.

Thx @dcpleung for testing.
I am currently on parental leave. I will try to recheck at the beginning of April.

@StefJar any updates on this.

not yet
I just started to rebuild my project from the scratch to figure out what config crashes. Means I take the 2.5.xx API + rebuild my board dts + proj conf + minimal main.c
From my debugging so far, I can say that the stack sentinel kicks in before the main thread is executed. So I guess it must be some driver ?ISR? that breaks the stack at kernel init.
I keep you posted

update:
I rebuild my project set up with the latest zephyr drivers. Didn't managed to break that.
BUT I managed to get that stack overflow when using a constant string at a LOG_xxx without log_strdup.
Rechecked my code for forgotten log_strdup but didn't found some.
My intension is now shifting towards the logger. In my project I have an own  logging back end.
Looks like the logging backend has changed 4 months ago (https://github.com/zephyrproject-rtos/zephyr/commit/f1bb20f6b43b8b241e45f3f132f0e7bbfc65401b)
Therefore was no "process" function. So I might need to init that function.
I will check and report back

Looks like it's not logger related. I can now trigger a reliable stack overflow by just setting
CONFIG_INIT_STACKS=y
Looks like the initial stack set up gets corrupted.
My current test set up is custom board (STM32F412) + dts + simple main that logs something. The stack overflow is detected by the sentinel before the main function is entered.

@dcpleung any updates on this?

Tried again but still cannot reproduce the issue:

./scripts/twister -p nucleo_f429zi -T tests/subsys/logging/ --device-testing --device-serial /dev/ttyACM0 -x=CONFIG_INIT_STACKS=y -x=CONFIG_STACK_SENTINEL=y
./scripts/twister -p nucleo_f429zi -T tests/kernel/ --device-testing --device-serial /dev/ttyACM0 -x=CONFIG_INIT_STACKS=y -x=CONFIG_STACK_SENTINEL=y

lowering priority given that it can't be reproduced

I like to give a short update on that issue
I done some work on my project. So I am currently using for everything the Zephyr drivers. So no own ISRs etc. If I am doing a hard reset VDD off -> on, my firmware runs 2x through a reset because of the stack sentinel. After it goes smooth. As well as a reset from my programmer usually does not triggers this error.
I have problems resolving that message.
[00:00:00.000,266] <err> os: r0/a1:  0x00000002  r1/a2:  0x00000001  r2/a3:  0xf0f0f0f0
[00:00:00.008,789] <err> os: r3/a4:  0x2000e700 r12/ip:  0x00000003 r14/lr:  0x0802229f
[00:00:00.017,454] <err> os:  xpsr:  0x41000000
[00:00:00.022,658] <err> os: s[ 0]:  0x00000000  s[ 1]:  0x00000000  s[ 2]:  0x00000000  s[ 3]:  0x00000000
[00:00:00.033,058] <err> os: s[ 4]:  0x00000000  s[ 5]:  0x00000000  s[ 6]:  0x00000000  s[ 7]:  0x00000000
[00:00:00.043,457] <err> os: s[ 8]:  0x00000000  s[ 9]:  0x00000000  s[10]:  0x00000000  s[11]:  0x00000000
[00:00:00.053,858] <err> os: s[12]:  0x00000000  s[13]:  0x00000000  s[14]:  0x00000000  s[15]:  0x00000000
[00:00:00.064,254] <err> os: fpscr:  0x00000000
[00:00:00.069,454] <err> os: Faulting instruction address (r15/pc): 0x08021b54
[00:00:00.077,404] <err> os: >>> ZEPHYR FATAL ERROR 2: Stack overflow on CPU 0
[00:00:00.085,272] <err> os: Current thread: 0x200035f8 (unknown)

This happens before my main function is called. Any idea how I can more informations on who is crashing the stack sentinel?

zephyr.lst can usually point you to the instruction that's causing the fault with the program counter address (in your case, (r15/pc): 0x08021b54.
If the toolchain emits symbol for a particular thread, you can find it through zephyr.map to see which thread is causing issue. (in your case, Current thread: 0x200035f8).

In theory, stack sentinel should not be used together with HW_STACK_PROTECTION on Cortex-M. It's not needed. I've not checked, though, if these can co-exist smoothly.

Yeap, the line  of code could help here.

Btw, I could not reproduce this either, using the same twister call as @dcpleung on nRF52840.
Running this, I noticed that sentinel cannot work with single-threading so I opened #35764
I noticed @StefJar that you're using FPU - that might bring additional stack requirements. I wonder if what you see is an expected stack overflow.

@ioannisg thx for testing and explaining.
My exception are pointing to the stack sentinel code. That is why I ended up open this issue.
For me its good to know that HW_STACK_PROTECTION and CONFIG_STACK_SENTINEL are conflicting. Maybe it would be beneficial to disable CONFIG_STACK_SENTINEL if HW_STACK_PROTECTION is enabled.
the FPU stuff is super confusing. On app level you can give the K_FP_REGS to the thread creation. This macro becomes alive only if CONFIG_FPU_SHARING is set. Detecting a stack overflow at the thread switch is now tricky. Because the sentinel/HW stack protection needs to know the thread config. Currently I am going with the std. setup on that.
When disabling CONFIG_STACK_SENTINEL my code runs my long run test(12h with permanent sensor i/o and bt data streaming).
With the comment from @ioannisg I got a good explanation . I will leave this issue open for comments for 2 days and close it afterwards.

I am closing that issue, because it can not reproduced.
Important lesson learned is that
HW_STACK_PROTECTION
and
STACK_SENTINEL
are not necessary compatible.
Thx to @dcpleung  and @ioannisg

I am closing that issue, because it can not reproduced. Important lesson learned is that HW_STACK_PROTECTION and STACK_SENTINEL are not necessary compatible. Thx to @dcpleung and @ioannisg

I'm able to pretty consistenly reproduce it with one of the Zephyr Bluetooths samples on an NRF52840 dk. See https://devzone.nordicsemi.com/f/nordic-q-a/97002/enabling-config_fpu-causes-stack-overflow
Would have been nice is KConfig disallowed CONFIG_STACK_SENTINEL=y and CONFIG_FPU=y in the presense of hardware stack protection.


Jc/nav links

@Dakuan I've added anchors and a small snippet to update the active link when the hash changes.

awesome - I promise not to make you write anymore js like that!

:shipit:


Support Generating Policy Document

Is there a way to generate the whole policy document (not the statement), like this:
{
  "Version": "2012-10-17",
  "Statement": [
    ...
  ]
}

If not, is it possible to add the support? It can have a few helpful APIs as well (.e.g. addStatement).
Thanks.

It's currently not possible but I would like to have this.
What is your use case?
My use case is to validate the policy size which is different for each policy type, see https://github.com/udondan/iam-floyd/issues/24


Fails to run on Cuda 9.2

All modules compile correctly, all steps go smoothly.  When running the web.lua, it crashes saying the cuda version is insufficient.  Now this could be a Torch issue not supporting 9.2 which I'll create a thread there if one doesn't already exist.
user@Nagisa:~/waifu2x$ th web.lua
THCudaCheck FAIL file=/home/user/torch/extra/cutorch/lib/THC/THCGeneral.c line=70 error=35 : CUDA driver version is insufficient for CUDA runtime version
/home/user/torch/install/bin/luajit: /home/user/torch/install/share/lua/5.1/trepl/init.lua:389: lib/w2nn.lua:18: Failed to load CUDA modules. Please check the CUDA Settings.
/home/user/torch/install/share/lua/5.1/trepl/init.lua:389: cuda runtime error (35) : CUDA driver version is insufficient for CUDA runtime version at /home/user/torch/extra/cutorch/lib/THC/THCGeneral.c:70
stack traceback:
[C]: in function 'error'
/home/user/torch/install/share/lua/5.1/trepl/init.lua:389: in function 'require'
web.lua:7: in main chunk
[C]: in function 'dofile'
...user/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:150: in main chunk
[C]: at 0x00405d50

I have not tried CUDA 9.2 yet.

CUDA driver version is insufficient for CUDA runtime version

This error may appear when the driver version is old or the installation has failed.
Have you installed GPU driver compatible with CUDA 9.2 and reboot?

I am running version 396 of the nvidia driver.  A reboot has also happened prior to creating this ticket.  I have purged and reinstalled Cuda, the Nvidia driver, torch, and waifu2x twice just to make sure.
Everything builds fine without error.

I have installed CUDA 9.2. It worked with the same steps as #222. I think your issue is caused by the driver installation.

I'll have to look back into it.  The machine it was on has run into issues from all the changes happening trying to get it to work.

On another machine it seems to be working fine.  The original machine installation may be broken.


Array types

As you tell me @divyenduz I create an issue for a follow up on this one https://github.com/prisma/photonjs/issues/256
Why array types are  | null and not simple empty array?

@yovanoc Can you please provide an example?

I just sent you an email

I checked this out and arrays are not | null
Also, the schema doesn't allow nullable array by design for the same reasons as you have posted.
Can you please send in the query or the screenshot where arrays are nullable?
I tested using<EMAIL_ADDRESS>binary version: 237b46b97773f5018e336550e4285e2a78c38483

Ok now with latest alpha array are not nullable anymore, but an optional field in my schema in nested select is not marked as nullable.

I can't reproduce. It is nullable. Also, as a side note please don't confuse ? operator with nullability. ? makes a property optional not nullable

You'are right I said nullability when a field is optional in the prisma schema and should be  | null in the generated typescript no? I make a little reproduction tested with<EMAIL_ADDRESS>binary version: 998508a3ac0132b0b211dec85419e0a27f3d1813.
Schema:

Query:
const userTest = await photon.userTests.findOne({
    where: {
      id: "Example"
    },
    select: {
      id: true,
      globalConfig: {
        select: {
          accounts: {
            select: {
              username: true,
              password: true,
              config: {
                select: {
                  data: true,
                  list: true
                }
              }
            }
          }
        }
      }
    }
  });

Result:

Here I don't get why accounts are marked as  | null and the list of Random model too.
Thanks

Oh yes, you are right. account and config.list should not be marked a nullable field.

I can confirm this as a bug now. Here is the reproduction for internal use: https://github.com/harshit-test-org/prisma-photon-259

Fixed in latest alpha.
You can try it out with npm i -g prisma2@alpha.

Still happening to me on

Please try again with alpha.278, sometimes the CI/npm takes a bit longer.
I just manually test it with 278 and it works for me.


UI: Create Connector Wizard - Target / Broker details page

Develop component for the final page of the Create Connector wizard.  This page displays the target and final properties for the connector, similar to the mockup below:

@gunnarmorling I thought Kafka Connect URI is a config of the backend application. WDYT?

@rk3rn3r WDYM by that -- that the URI shouldn't be configurable via the UI (as shown in the screenshot) but rather is a hard-coded property? If so, no, I don't think I'd agree. A single config/API server could work with multiple Connect clusters. But an implication of that is that it'd have to have its own store of known broker ids once it should expose a view to list the existing connectors and their state, metrics etc.

Hard coded? No! I said a backend config, like in a properties file / env var on the backend application. imo the backend is always linked to a specific Kafka Connect cluster. Especially when you want to list and manage running connectors that info needs to be placed somewhere else than in the last page of the wizard!

To close the loop for future reference: we agreed to make the list of addressable KC cluster(s) a Quarkus configuration property in the UI backend, which will expose the list via a new API method to the UI (#49), which will facilitate the use case of displaying all configured connector instances.

#64 added the RuntimeOptions step to the UI.  The Kafka connect cluster dropdown selector will be added to the Connector List page - essentially setting the 'context' for addition of new connector via the wizard.


Select the supported Power States for x86 and ARC

soc: x86: quark_se: Select the supported Power States
soc: arc: quark_se_c1000_ss: Select the supported Power States

Codecov Report

Merging #10254 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10254   +/-   ##
=======================================
  Coverage   53.06%   53.06%
=======================================
  Files         214      214
  Lines       26198    26198
  Branches     5645     5645
=======================================
  Hits        13901    13901
  Misses      10025    10025
  Partials     2272     2272

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d3fb8b...51725f3. Read the comment docs.


fix(bundler/nsis): an error message appears when the uninstallation is successful. closes #7317

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[x] No

Checklist

[x] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

Other information

Thank you

@luoffei Oh looks like you didn't sign your commits and I can't merge the PR unless they are signed.


[BEAM-90] TestCountingSource can throw on checkpointing

R=klk
Urgent: blocking customer impacting bugfix.

PTAL


Possibility to specify start and end date

Right now we can only use a "rolling window history" by specifying days. As an additional option, it would be nice if we could specify a specific start and end date as well.

Closed with latest version - you can override the value for "today" and the history parameter (if using relative history in days) is taking this into account.


HomeAssistantType was used from yandex_station, this is a deprecated alias which will be removed in HA Core 2025.5

HomeAssistantType was used from yandex_station, this is a deprecated alias which will be removed in HA Core 2025.5. Use homeassistant.core.HomeAssistant instead, please report it to the author of the 'yandex_station' custom integration

#502


Database.SqlQuery Missing

In Entity Framework, there is a method to execute a query against the database and return a specified object type.  Entity Framework Core does not have this and the only alternative is 4 times the amount of code.  Example below.
Database.SqlQuery (Entity Framework 6.0)
This is the SqlQuery method found in Entity Framework 6.0
var integerList = db.Database.SqlQuery<int>("SELECT [MyIntegerColumn] FROM [MyTable]").ToList();

foreach (int id in integerList)
{
    // do something with each in the list or just return the list
}

SqlCommand (Entity Framework Core 2.0)
This is the DbDataReader method found in Entity Framework Core 2.0
using (var command = context.Database.GetDbConnection().CreateCommand())
{
    command.CommandText = "SELECT [MyIntegerColumn] FROM [MyTable]";
    DbDataReader reader = await command.ExecuteReaderAsync();

    if (reader.HasRows)
    {
        while (await reader.ReadAsync())
        {
            // do something with each in the list or just return the list
        }
    }
}

Honestly, quadrupling the amount of code required to perform the same action and expecting the same result is not "more efficient" in my opinion.  I have literally dozens of "quick calls" as I call them in my code that will now require me to convert a single line of code over to 4 (or more).

Raw SQL queries that return arbitrary types is being tracked by #9290.

Meanwhile you can try netcore-ef-util and a code like follow
using SearchAThing.EFUtil;
using System.Linq;

...
var integerList = db.ExecSQL<comptype1>("SELECT [MyIntegerColumn] FROM [MyTable]")
.Select(w=>w.MyIntegerColumn);
foreach (int id in integerList)
{
    // do something with each in the list or just return the list
}

having defined a composite structure to hold data result with
public class comptype1
{
  public int MyIntegerColumn;
};

More complex example here with composite type

This is the exact reason why people is moving to NodeJS


Add the entire Navy Seals copypasta in Russian

For whatever reason I rate all online translator apps based on how well they can translate Navy Seals into Russian, and LibreTranslate/Argos was the worst one. This PR will probably solve this. I don't know why I decided to do this.

Interesting choice thanks!

By the way, @PJ-Finlay, is the data from this repository currently used somewhere or at least is planned to be used in the near future?

Not currently. Gathering user data is still a work in progress: https://github.com/LibreTranslate/LibreTranslate/pull/151

@PJ-Finlay got it. Also, AFAIK current models are trained on WikiMatrix from OPUS. Maybe you can consider also adding XL models which are trained om CCMatrix? It's like 15 times bigger then WIkiMatrix is

I generally used CCMatrix too, for most models I used top few largest datasets on OPUS.


disable gravity not working

Minecraft Version: 1.16.4
Forge Version: 35.0.14
Mod Version: 1.02
Single Player or Server: Single player
Describe problem (what you were doing; what happened; what should have happened): Disable blocks falling from gravity - on does not stop gravel and sand from falling from block update
Log file link: no log (does log file report block falling triggered? if so I can try to locate it)
Video/images/gifs (direct upload or link):  none
If your bug is related to anything causing LAG you need to measure the lag by taking a sample https://minecraft.curseforge.com/projects/sampler

Fixed in new version, please report if it breaks again https://www.curseforge.com/minecraft/mc-mods/custom-game-rules/files/3151504


Override config with msg

Hi!
Great node and it would be awesome if you could override some settings with message properties, in particular, serialOrName, command, value and target.

Thank you!
You can currently set each settings field to use a msg, flow or global property by clicking on the dropdown on the left side of the input field. Is this what you were asking for?

I just noticed that setting the target/Command/Request this way does not work. I will fix that.
#2

I'm not sure of what you mean, there is no selector on the left side of the input fields on the sequence node, for instance. There are two in the configuration node, but they are not functional.

Oh that's wierd, it looks different on my end:

Do you see the dropdown in native nodes like change?
What browser are you using and what versions are you running?
It works for me on the most recent Chrome and Firefox and with
Node-RED version 0.19.4 and Node.js version 8.12.0/10.13.0.


Add includes for tests and package to a new file

Description of changes made
Implemented automatic inresting includes for tests and a package line for a new file for tests
Why is merge request needed
To make test file correct
Other notes
Closes #ICTL-316
What is missing?

There are some unused imports in the saved test file: 1- class under test (we don't need it anymore as we are using the same package as the class under test) 2- RunWith

thaks, fixed


Provide API support to get users list whose password will expire within a given time period

Description
IS organization administrator needs to send notifications to organization users periodically to reminders to users whose passwords will expire soon (like 1 week before).
We had capability of sending email reminders for users whose passwords will expire in IS 5.6.0 (with DAS based analytics solution) and removed it thereafter. So we need to recommend a way for the customers to implement this capability again in newer product versions.
Need to provide an API support for IS server organization admins to get users list whose password will expire within a given time period. Admins can integrate external tool to retrieve the user list and send notifications.

PRs:

https://github.com/wso2-extensions/identity-governance/pull/746
https://github.com/wso2/identity-api-server/pull/475
https://github.com/wso2/carbon-identity-framework/pull/4867
https://github.com/wso2/product-is/pull/16503

Doc issue:

https://github.com/wso2/product-is/issues/16611


Loop={true} + initialIndex leads to brief off by one error flicker

Which OS ?
iOS
Version
1.6

react-native-swiper v1.6
react-native v0.59.8

Expected behaviour
I was debugging an issue where setting the index param briefly showed the wrong data (off by one earlier) for a brief second before a redraw happened.
In debugging, this seems to be related to the loop={true} behavior (the default), since eliminating looping causes the offset to be calculated correctly and no flicker.
I'm guessing the implementation has some kind of 'extra' item at the front to handle the left-swipe when looping, and the initialOffset is not accounting for this?
Actual behaviour
Setting index causes it to start drawing on the correct position without a flicker.
Steps to reproduce

Create a Swiper with multiple items, and loop={true}
Set the initial index.
Observe that it is briefly off by one before correcting itself.

@zzorba  Can you reproduce it on<EMAIL_ADDRESS>?
IOS bug may be related to ScrollView, https://github.com/facebook/react-native/issues/24826#issuecomment-495570736

I rebuilt with RN 0.59.4 and it seems to still happen on simulator.
Unlike the gif, the 'flash' of the wrong content only happens on initial draw -- once you start interacting with it is correct and there's no issues.
Removing the loop={false} from my Swiper props causes it to work as expected (initial draw at the correct position).
My guess is it's the following code in onLayout that is the cause.
    if (this.state.total > 1) {
      let setup = this.state.index
      if (this.props.loop) {
        setup++
      }
      offset[this.state.dir] =
        this.state.dir === 'y' ? height * setup : width * setup
    }

The code in initState doesn't seem to account for the looping.  The render method for android does seem to adjust based on loop, initialPage={this.props.loop ? this.state.index + 1 : this.state.index}?  I think this would explain the issue, initially being off by one and then fixing itself when onLayout fires.

Can you provide the minimal example code and the environment ? I can reproduce it on my ios simulator
react-native info

my App.js
import React, { useState } from 'react'
import Swiper from 'react-native-swiper'

import { View, StyleSheet, Text, TouchableWithoutFeedback } from 'react-native'
const styles = StyleSheet.create({
  // wrapper: { flex: 1 },
  wrapper: {},
  slide1: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
    backgroundColor: '#9DD6EB'
  },
  slide2: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
    backgroundColor: '#97CAE5'
  },
  slide3: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
    backgroundColor: '#92BBD9'
  },
  text: {
    color: '#fff',
    fontSize: 30,
    fontWeight: 'bold'
  }
})

const SwiperComponent = () => {
  const [autoPlay, setAutoPlay] = useState(true)
  const stop = () => setAutoPlay(false)
  const start = () => setAutoPlay(true)
  return (
    <Swiper
      style={styles.wrapper}
      autoplay={autoPlay}
      loop={true}
      autoplayTimeout={4}
      // index={0}
      index={3}
      // bounces={false}
    >
      <View style={styles.slide1}>
        <TouchableWithoutFeedback onPress={() => {}}>
          <Text style={styles.text}>1</Text>
        </TouchableWithoutFeedback>
      </View>
      <View style={styles.slide2}>
        {/* <TouchableWithoutFeedback onPress={() => this.props.navigation.pop()}> */}
        <Text style={styles.text}>2</Text>
        {/* </TouchableWithoutFeedback> */}
      </View>
      <View style={styles.slide3}>
        <TouchableWithoutFeedback onPress={() => {}}>
          <Text style={styles.text}>3</Text>
        </TouchableWithoutFeedback>
      </View>
      <View style={styles.slide3}>
        <TouchableWithoutFeedback onPress={() => {}}>
          <Text style={styles.text}>4</Text>
        </TouchableWithoutFeedback>
      </View>
    </Swiper>
  )
}

export default SwiperComponent

Yep, I think I have a repro here.  My project has a very large number of items, when I moved from the 10 static ones to a couple hundred invoked with a key, it shows up with the wrong number, and then quickly corrects itself.
import React, { useState } from 'react'
import Swiper from 'react-native-swiper'
import { map, range } from 'lodash';

import { View, StyleSheet, Text, TouchableWithoutFeedback } from 'react-native'
const styles = StyleSheet.create({
  // wrapper: { flex: 1 },
  wrapper: {},
  slide1: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
    backgroundColor: '#9DD6EB'
  },
  slide2: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
    backgroundColor: '#97CAE5'
  },
  slide3: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
    backgroundColor: '#92BBD9'
  },
  text: {
    color: '#fff',
    fontSize: 30,
    fontWeight: 'bold'
  }
})

const SwiperComponent = () => {
  const [autoPlay, setAutoPlay] = useState(true)
  const stop = () => setAutoPlay(false)
  const start = () => setAutoPlay(true)
  return (
    <Swiper
      style={styles.wrapper}
      loop={true}
      loadMinimal
      loadMinimalSize={3}
      index={1}
      // bounces={false}
    >
    { map(range(0, 200), id => (
      <View style={styles.slide1} key={id}>
        <TouchableWithoutFeedback onPress={() => {}}>
          <Text style={styles.text}>{id}</Text>
        </TouchableWithoutFeedback>
      </View>
    ))}
    </Swiper>
  )
}

export default SwiperComponent

Can you provide a gif and more detail info? I still cannot reproduce the fliker (；′⌒`)

Same as you.
https://github.com/leecade/react-native-swiper/issues/570#issuecomment-514948736
You can try to delete line 329?

Like you, I solved the problem by deleting "load Minimal"
react-native v0.59.8
"react-native-swiper": "^1.5.14",

Removing the additions on this fixes it for me. https://github.com/leecade/react-native-swiper/commit/1fb7ff24cf2adb3bbe2feb487e9ac88c97c603a6


Convert 'VM" to uppercase when adding new VM condition

Add consistency with uppercase for 'VM' when adding new VM condition in Control/Explorer central toolbar
https://bugzilla.redhat.com/show_bug.cgi?id=1110656

@h-kataria @dclarizio Harpreet, please check the code fix.

@dclarizio there is a dictionary entry for a model "Vm" which returns "VM and Instance", there is no entry for "vm" so in this case it's titleizing the string and returns "Vm". If we use "VM and Instance" in the toolbar button title it will not match the tree node text on the left. Please suggest.


Adds socket timeout and validate file size

Adds socket timeout of 5 seconds and validates file size.
Recent network issues between the Actions runner and cache storage have caused flakiness in download speeds.  While debugging, we observed periods where no traffic was received over the socket.  In some cases, no traffic is received but the socket remains open for many minutes.  Furthermore, if the socket closes before all content is received, the cache action incorrectly proceeds to untar the file, causing an "unexpected end of file" error.
This PR sets a socket timeout of 5 seconds.  As a result, if there is a period were no traffic is received for 5 seconds, the download will abort and will be treated as a cache miss.  Additionally, the downloaded file size is compared against the expected content length, if provided.

Nice work! Hope that this will be merged.

Ty!

Validation is work #271. So to finally fix this problem we need to wrap warning: exit code 2 and try to download cache again, as it was done in https://github.com/actions/setup-node/issues/116


Update setup.py

added print step to help diagnose issues

Heya,
print version is not going to do much in python3 (which this module was developed for). It's print(version).
If you're having any issue, feel free to create a new issue.
Cheers
Rico


module 'ot.gromov' has no attribute 'cg'

I followed the tutorial and ran into the above error when I got to this step:
pi12 = pst.pairwise_align(slice1, slice2, backend = ot.backend.TorchBackend(), use_gpu = True)
This happened using GPU or CPU.
Which version of pot should we use?
Thanks,

"pip install pot=<IP_ADDRESS>" resolved the issue.


vite

Description
Project proposal
Why
Vite (French word for "fast", pronounced /vit/) is a new breed of frontend build tool that significantly improves the frontend development experience.
Code of Conduct
By submitting this pull request, I confirm I've read and complied with the CoC 🖖

The CI flow could not re-run for PRs that are more than a month ago. Therefore, I ask for comments from those who haven't voted yet.
@defi-er @bibryam Do you agree to this? Please react by 👍 or reply to this comment.

The CI flow could not re-run for PRs that are more than a month ago. However, I will merge this proposal because all the committee members have approved this.


Fix no-unknown-property: check attributes with any input case

I think this is ready now. I checked my project with this rule and it didn't break anything :-)
I wasn't sure if this rule should also check completely unknown attributes. My view is that it should, but I didn't do it in this patch.
With this patch the rule will probably find new errors in existing code, so it should probably be versioned in a new minor or major version.
Tell me what you think!
(pretest fails but this seems to happen on master too?)

Thanks for the review @ljharb, I think I fixed all your comments!
One question: I think this property should also check completely unknown attributes on the html tags (eg <div foo="bar">). Maybe this could be an option though... What do you think?

@julienw yes, ideally it should, but we'd need to ensure we can use the same mappings React itself uses, and i don't think they're exposed anywhere. I think we can do that in another PR :-)


Schedule constraints UI improvements

Closes #43
As per design v2: new Constraints UI: Move schedule and budget constraints to top of planning page, add new copy, add confirmation button.
To create the Confirm button UX - I refactored the DndProvider by moving it to wrap the top-level Chooser component to resolve rendering / HTML5 Backend error.
There's a new field in Constraints for max distance - while it appears in the UI, it's disabled until the distance calculation functionality build out.

Fixed positioning perpetually assigns some of the viewport to the menu, but the menu may not be relevant during most of a working session. This seems suboptimal for an application where so much information has to be displayed concurrently.

There are various issues with how it's built today in terms of viewport - we've gotten feedback on this from various chapters and we want to prioritize it, as it creates a bad experience

When a hospital schedule slot shows up, that means a user has to select a restaurant to match with the hospital on the right side. Right now, the left side height of the restaurant is determined by the how many hospitals appear on the right side, which is unreasonably short. All of our chapters have a large list of restaurants they need to scroll/sort through to match the hospitals. The goal for chapters is to find a restaurant, and we need to optimize for the discoverability of a restaurant. When there is only one or two restaurants, it becomes very difficult for chapters to find restaurants. The viewport should be large enough for them to scroll through the restaurants.
We should never surprise users with inconsistency. Just because there is only one or two hospitals on the right side, doesn't mean that we should change the heights of the viewports for depending on the number of hospitals. This kind of inconsistency causes a negative experience and surprises users when they try to set up a schedule.

That all sounds good to me, @susanpark! You may be interested in the changes in gh-22.
My question to Jesar was specifically about the way they intended the "schedule constraints" form to interact with the scroll bar. I'm seeking clarification because the design specification doesn't describe what's intended.
Currently, the patch affixes the form to the top of the Block's viewport such that it is present while the user scrolls through the shifts. An alternate interpretation would be to include the form as scrollable content (this would mean it would no longer be visible as the user moved through the shifts).
Here's a screen recording to demonstrate the two interpretations of the design specification:

Hello! Apologies for the delay in my response - based on how people were using it during the few test rounds, I think giving them as much space on the screen to plan is valuable. So after they set the constraints, they spend time dragging restaurants to hospitals. So I think we should allow the constraints and top of the page content to scroll away with the scrollbar. Thanks!

Thanks @jesarshah! Thanks @arebe!

also -- it looks like you all are using merge --squash strategy, yeah?

Preferably, unless circumstances call for a merge commit


feat(:git): do not decline valid<EMAIL_ADDRESS>source

Now it will be possible to also pass the source_type(source_string) call
with a terraform valid<EMAIL_ADDRESS>source property being set.
The function git_source_details_from(source_string) is already prepared
to handle this type.

This looks good to me, cc @Nishnha wdyt?

😎
The reason I initial did not want to reuse an existing test module, is that there is also an extra catch just for direct github.com sources. So I decided for now I don't want to touch that piece and instead extend the :git catch.

Yep, that makes sense to me @sebbrandt87
Can I request that you change the test folder name, then? 💟
We originally used the git_tags_0xx folder naming scheme to test changes between Terraform 0.11 and 0.12 😅
Maybe a more appropriate folder name would be git_protocol? What do you think?

I am doing it right now @Nishnha 👍

Btw @Nishnha I force pushed to keep a clean history. Hope this was okay in this case here.


Edits

Can you change:
Block Explorers:

0xBitchain 0xBTC Monitor
Epirus

=> Under "Related Projects"
0xBitchain - Level 2 0xBitcoin themed Quorum Ethereum sidechain

0xBitchain Monitor by ConsenSys
0xBitchain Block Explorer by Epirus

This is also "as official on 0xBitchain as it gets" https://discord.gg/9aTgeWN
An occasional reader may not understand the "sidechain" nature of current entries amongst mainnet explorers. Thanks!

Sorry for the delay. I did it! Please let me know if I missed anything. Thanks!

Looks perfect!


Typus without UI styles

Hi guys, I have the master version installed in a development app, magically the admin no longer has the UI styles (and I don't see any error in the console), am I missing something?
Thanks
typus (4.0.0.beta1)
rails (~> 4.2.1)

It is working after remove the gem and install the latest version. Thanks.


Never connects to Discord

When I run  winediscordipcbridge in the same WINEPREFIX as my game (it's a 32-bit WINARCH), I get this message:
Pipe Server: Main thread awaiting client connection on \\.\pipe\discord-ipc-0

And... it never connects at all.
My Discord IPC socket file is in /run/user/1000/discord-ipc-0
I'm not running this in Steam, just a custom WINEPREFIX. Does the WINEPREFIX need a Z: drive set up pointing to /
because I removed that. Adding it back doesn't seem to help.
Running strace on the wine winediscordipcbridge shows it reads in the bit about finding it from XDG_RUNTIME_DIR and /tmp but I guess it never finds the file. Is there something I need to pass to winediscordipcbridge so it can find it or is this a file access problem?

Is that the only message you get? Or are there more logs?

Does the WINEPREFIX need a Z: drive set up pointing to /
because I removed that.

No

Is there something I need to pass to winediscordipcbridge so it can find it or is this a file access problem?

Is the XDG_RUNTIME_DIR env var set? In your case it should be set to /run/user/1000.

Yes, that is the only message I get. No other logs.
$ echo $XDG_RUNTIME_DIR
/run/user/1000

Running on WINE 9.17.

So it's the game that's not connecting to the pipe, are you sure the game supports rich presence?
Rich presence

Not rich presence


Hide files from view

I'd like to have the ability to hide some files from view as I can totally ignore them.
I propose to create a list via CLI as made for ignoreFiles and a new option.
While rendering the view, it's possible to add a CSS class to the element that hides it. To achieve this, the code for wildcard matching in ignoreFiles in #282 is reusable, so I can do it quickly.

I tried it and it works with matching I added.
I'll add this to the PR #282.

The aim of what I'm proposing is like: I want to serve html and js files, but I want to browse only between html files.

I apologize, I was doing something wrong and I made a mistake. The ignore option is what I was implementing.
So, I close this.


How can I generate navigation breadcrumbs?

Dir tree:
src/pages
├── posts
│   └── list
│       ├── index.vue
│       └── new
│           └── index.vue

The currently generated routes is:
{path: '/posts'},
{path: '/posts/new'}

So when I am on the /posts/new page, the $route.matched doesn't includes /posts route.

like this

For reference, this is a demo
https://github.com/zhuhaobam/vtdd

This would be beyond the scope of this project.


ExpectedConditions or method does not seem to short circuit a true condition

@juliemr, I'm running the latest 2.0 with the fix for #1907 and #1903  mentioned by @hankduan. I have the following piece of logic to make sure an element is not visible or does not exist:
var cssSelector = '.my-class';
browser.wait(ExpectedConditions.or(
                  ExpectedConditions.stalenessOf($(cssSelector)),
                  ExpectedConditions.invisibilityOf($(cssSelector))),
      5000);

I intermittently get a NoSuchElementError: No element found using locator: By.cssSelector('.my-class')
It seems like the or is not short circuiting if the first condition is true since the first condition should check if the elements are even there. Is the promised of each condition being resolved before moving on to the same condition? Am I missing how multi condition should be used?

As mentioned in the referencing issue, can you provide a reproducible case? I just made a sample test, but cannot reproduce this.
spec:
  var EC = protractor.ExpectedConditions;
  it('should get each', function() {
    browser.get('http://localhost:8081');
    var disappearingContent = $('#content');
    var toggleButton = $('#toggleButton');
    toggleButton.click(); // disappears after 1 second.
    expect(disappearingContent.isPresent()).toBeTruthy();
    browser.wait(EC.or(
                EC.stalenessOf(disappearingContent),
                EC.invisibilityOf(disappearingContent)),
                5000);
    expect(disappearingContent.isPresent()).toBeFalsy();
  });

app:

Toggleable element

  <button id="toggleButton" ng-click="toggleContent()">Toggle content after 1 seconds</button>

    This is removed on click.

js:
function FormCtrl($scope, $window) {
  $scope.shouldAppear = true;
  $scope.toggleContent = function() {
    // $window.setTimeout(function() {
    //   $scope.shouldAppear = !$scope.shouldAppear;
    // }, 1000)
    $scope.shouldAppear = !$scope.shouldAppear;
  };
}
FormCtrl.$inject = ['$scope', '$window'];

Closing as stale.


Add caching for filters

Here's an execution profile from an MVC app rendering a significant Razor View:

Retrieving filters (just the default filters) is costing 2.5% of execution time. This is a lot for the default configuration.

70cee90186099daa66f32954a91c6f57ad92812b


Update request: QGIS 3.32 -> QGIS 3.34

Package name: QGIS
Latest released version: 3.32

Hi @imincik
QGIS 3.34 was released on friday. It adds a new dependency for draco . I also added some tweaks to remove unneeded build steps (QGIS Server and tests) and explicitly set build to release mode.
My .nix file is attached.
unwrapped.zip
Notify maintainers
@imincik
@sikmir
@nh2
@willcohen

Maybe update the title to include the name of the application

Maybe update the title to include the name of the application

Apologies, fixed now, thanks!

Thank you @timlinux , I'll try to update ASAP.

Building right now. Thanks heaps for patch.

Build went fine, but during the start QGIS is showing "Release candidate" logo

It looks like proper release according About window

There was not even a release candidate, at least judging by their Github page.
But they dont seem to have any officially at all, and there is still this banner.

QGIS website is showing
3.32.3
3.28.11 LTR
as current releases. Maybe it is not updated yet.

Draft PR created - https://github.com/NixOS/nixpkgs/pull/264871 .
I'll add more changes suggested by @timlinux in next commits.

@imincik that banner is correct - .0 releases will always have that banner

Seems counterintuitive - since the release page declares it as final.

I think this usually happens with the .0 release — it goes away with .1, if
I recall correctly.
On Sat, Nov 4, 2023 at 8:03 AM ShalokShalom @.***>
wrote:

Seems counterintuitive - since the release page declares it as final.
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/issues/264482#issuecomment-1793424764,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHR6POFOISZUNC5W6FPVI3YCYVHLAVCNFSM6AAAAAA6W3DKCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGQZDINZWGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@willcohen there is a logic to it. The 3.34.x series is special as it is the 'feeder' release series till the next LTR. I am checking with our PSC that my statement above is correct, I think that badge should be carried through until the actual ltr too...

Yep that sounds more right, and that it goes beyond the 0.1. Sorry for speaking off the cuff! I remember this now and what you said sounds right — my coworkers would always ask me why it said RC and it went on till the next minor release.

Ok I stand corrected by Juergen (QGIS Release Manager) - only the .0 release gets that badge:

@timlinux , thank you very much for explanation. https://github.com/NixOS/nixpkgs/pull/264871 is now ready to be reviewed.


Does not generate correct map(string) from module

Module contains:
variable "tags" {
  type        = map(string)
  description = "List of tags to be included as \"name\":\"value\" pairs (default = {})"
  default     = {}
}

iascable converts this to:
variable "cluster_tags" {
  type = string
  description = "List of tags to be included as \"name\":\"value\" pairs (default = {})"
  default = "[object Object]"
}

This is with iascable version 2.25.5


[Feature] Select-apps interface redesign feedback

Feedback desired

[ ] Navigation

[ ] Is the navigation intuitive?  Does it make sense without reading documentation?
[ ] Is there anything frustrating about trying to navigate?

[ ] Could the text coloring be modified in any way that would make it easier to read?
[ ] Operating system testing

[ ] Windows - Default console
[ ] Windows - Windows Terminal
[ ] Linux x86
[ ] Linux ARM
[ ] OSX

SteamPrefill-1.2.2-win-x64.zip
SteamPrefill-1.2.2-linux-x64.zip

Version : Linux v1.3.1
Games with Chinese/Japanese title has a weird year/type formatting

@dlrudie

Released in v1.6.0


Don't crash when mysqlnd is not present

Pretty self explanatory - see #35 for more info.

I believe this is now resolved by #31..


Dark mode support.

In case you're talking about REI's dark mode (which I will assume you are), it is now supported in our development builds. It might take a while however before we release this, as it is not a critical bugfix and we usually don't do releases for such small features
Cheers


Write Readme

It has to have:

A description of the project.
An installation guide.
A how to use guide.
A how to extend with Lua guide.


Meteor integration not compatible with crypto package

We are creating an accounts-blockstack Meteor module to integrate Blockstack login with Meteor's account system. Unfortunately, the usage of the crypto module (which is now present in vanilla Node) is incompatible and causes an error.
I deleted it from npm_modules manually, and it works properly. Please migrate away from this package.
Error:
Uncaught Error: Cannot find module 'crypto'
    at makeMissingError (modules-runtime.js?hash=5e485d3e2a49d2506f7ca0df72fcd6a3216a83a5:241)
    at require (modules-runtime.js?hash=5e485d3e2a49d2506f7ca0df72fcd6a3216a83a5:251)
    at secp256k1.js (modules.js?hash=dc5b20b05aad051d7248e15645099d47399039ba:5289)
    at fileEvaluate (modules-runtime.js?hash=5e485d3e2a49d2506f7ca0df72fcd6a3216a83a5:353)
    at require (modules-runtime.js?hash=5e485d3e2a49d2506f7ca0df72fcd6a3216a83a5:248)
    at index.js (modules.js?hash=dc5b20b05aad051d7248e15645099d47399039ba:5260)
    at fileEvaluate (modules-runtime.js?hash=5e485d3e2a49d2506f7ca0df72fcd6a3216a83a5:353)
    at require (modules-runtime.js?hash=5e485d3e2a49d2506f7ca0df72fcd6a3216a83a5:248)
    at signer.js (modules.js?hash=dc5b20b05aad051d7248e15645099d47399039ba:5169)
    at fileEvaluate (modules-runtime.js?hash=5e485d3e2a49d2506f7ca0df72fcd6a3216a83a5:353)

Usages of crypto are:
.../blockstack.js/src/encryption.js:
    7:   const cipher = crypto.createCipheriv('aes-256-cbc', key, iv)
   12:   const cipher = crypto.createDecipheriv('aes-256-cbc', key, iv)
   17:   return crypto.createHmac('sha256', key).update(content).digest()
   33:   const hashedSecret = crypto.createHash('sha512').update(sharedSecret).digest()
   71:   const initializationVector = crypto.randomBytes(16)

All these functions are present in the standard Node crypto package: https://nodejs.org/api/crypto.html

Are you perhaps keeping it around for the browser distribution?

Hi @raulk, thanks for raising this issue -- closing this and moving some discussion over to #305


The Travel Forecast stopped loading

The travel forecast recently stopped working.

The issue is related to the fact that weather.gov is starting to phase out the old weather API. For now I patched the script to display "NO TRAVEL DATA AVAILABLE" for the affected cities.


multiple primary keys

In CreateTable, replace the code creating the string given to the Execute method by
        var sbQuery = new StringBuilder("create table if not exists \"").Append(map.TableName).Append("\"(\n");
        map.Columns.Aggregate(sbQuery, (sb, column) => sb.Append(Orm.SqlDecl(column, StoreDateTimeAsTicks)).Append(",\n"));

        var pks = (from c in map.Columns where c.IsPK select c).ToList();
        if (pks.Count != 0)
        {
            //, PRIMARY KEY (A_ID, B_ID)
            sbQuery.Append("primary key (");
            pks.Aggregate(sbQuery, (sb, c) => sb.Append(c.Name).Append(','));
            sbQuery.Remove(sbQuery.Length - 1, 1).Append(')');
        }
        else
        {
            sbQuery.Remove(sbQuery.Length - 3, 3);
        }

        sbQuery.Append(")");
        var count = Execute(sbQuery.ToString());

And in the SqlDecl method, remove the line
decl += "primary key ";

Also in MigrateTable add a not supported exception:
        foreach (var p in toBeAdded)
        {
            if (p.IsPK)
                throw new Exception("New columns can not be primary keys (unsupported migration)");

            var addCol = "alter table \"" + map.TableName + "\" add column " + Orm.SqlDecl(p, StoreDateTimeAsTicks);
            Execute(addCol);
        }

What is the latest state of affairs on this? Does anyone have code known to work with the latest https://github.com/oysteinkrog/SQLite.Net-PCL fork? Øystein et al has done some nice work but lacking support for compound natural primary keys really cripples a relational database.

Look at my fork, it is fixed in it. Works perfectly.
https://github.com/softlion/SQLite.Net-PCL

how can I get this version from nuget???

Working on this in #280


Extracted AsyncWorker we can use for multiple consumers in code base.

Is there a way we could implement an await feature? Some threads needs to complete their network requests before shutting down.

I submitted a PR - let me know what you think. I am tempted to just use a
single threaded executor inside AsyncProcessor. Much cleaner that managing
our own threads.
On Sun, Apr 19, 2020 at 2:56 PM devgianlu<EMAIL_ADDRESS>wrote:

Is there a way we could implement an await feature? Some threads need to
complete their network requests before shutting down.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/librespot-org/librespot-java/pull/206#issuecomment-616207145,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEL7CQFROQ6SBBTO2QVECTRNNCPDANCNFSM4MGUN77A
.


Parallelizing Individual Evaluate() calls?

Hi! Thanks for writing gago - it is very useful. I was in the middle of writing my own GA loop, when I realized I shouldn't be reinventing the wheel and stumbled accross your library.
per the docs:

Talking about parallelism, there is a reason why the populations are run in parallel and not the individuals. First of all for parallelism at an individual level each individual would have to be assigned a new random number generator, which isn't very efficient.  It's simply not worth using a routine for each individual because operations at an individual level are often not time consuming enough.

This makes sense for GA operations, specifically those that require an RNG - mutate, crossover, et al. Those generally are fairly fast too, so the argument against overhead is totally valid.
With that said, my Evaluate() function is relatively expensive (upwards to 1 second for each call) and already does not have access to the population's RNG. Would it make sense then to parallelize Evaluate() calls on individuals within a population? We could make this default to off for use cases where the Evaluate() function is fast and doing this would just cause overhead.
Let me know what you think. If this sounds good, I'll be glad to work on it when I get a chance and submit a PR. If you have any implementation suggestions / preferences, let me know too

Hey!
Glad you like the library.
I think it makes a lot of sense to add an option to parallelise stuff on the individual level if you have expensive Evaluate calls, so you have a definitive 👍  on this from me.
As for implementation details, my intuition would be to add a parameter to the Evaluate method of the Individuals class (note the s). The parameter could be a number of workers to use. Then inside the Evaluate method you can check if the parameter is higher than 1 or not and apply the same logic that is done at the population level (use the g.Go method).
Feel free to give a shot! I think it makes sense you do the first implementation as you have a real use case when you can measure the speed-up. Don't hesitate to ask me questions :)

Hey @andrewortman, I have some time today so I'm going to implement this. I hope you haven't started so our work won't overlap!

Hey again, I implemented it. You can now use the ParallelEval field in the GA to choose to evaluate individuals in parallel. Tell me how it goes!

Awesome, thanks Max!
On Fri, Nov 10, 2017 at 3:18 AM, Max Halford<EMAIL_ADDRESS>wrote:

Hey again, I implemented it. You can now use the ParallelEval field in
the GA to choose to evaluate individuals in parallel. Tell me how it goes!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MaxHalford/gago/issues/21#issuecomment-343420192, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABlXbbbSK1kglUgkv0hBV7Lp6jOQ3lwrks5s1BTXgaJpZM4QSSAw
.

No problem! I'll let you try it out and if you're successful I'll let you close the issue yourself.

@andrewortman is it okay if I close the issue?

Aweome! Thanks! I will close this issue now


new / delete[] mismatch

Hello,
running LimeUtil --make through valgrind found a few issues.
ConnectionNovenaRF7::StreamChannel::Write() needs to delete[] samplesShort (it uses delete) instead.
Same in ConnectionSTREAM::Write() for wbuffer, ILimeSDRStreaming::StreamChannel::Write() for samplesShort and LMS64CProtocol::TransferPacket() for outBuffer, because they are all allocated with new[] and not new.
Related question: would you consider pull requests that replace such manual buffer management by std::vector<uint8_t>? (As long as it's internal and doesn't impact the API)

Hello,
Thanks for spotting this. I have fixed it with d94e2b8d04c8a3acf0eee4a2df74a7fb8b8a9f76
As for replacement with std::vector, I personally would prefer that it stays as it is.

Thank you.
Ok for keeping the buffer management manual.


[GLUTEN-7778][CH] Make aggregation output schema same as CH native

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Fixes: #7778
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
unit tests
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Run Gluten Clickhouse CI on x86


Move to Minikube 1.20 image of Katacoda for Hello Minikube Tutorial

Signed-off-by: Ben Hall<EMAIL_ADDRESS>Replaces #29615 with now signed commit. Sorry.
Fixes #29204
Upgrades the tutorial to use Minikube 1.20 which is the latest version available on Katacoda.

Did I somehow break the Netlify integration with my force push?

@tylerauerbeck Good point. Yes the version tag is Kubernetes, not Minikube itself.

/label team/katacoda


Add multiclusterhub-repo WIP

Signed-off-by: Zachary Kayyali<EMAIL_ADDRESS>https://github.com/open-cluster-management/backlog/issues/9785

/retest

/approve
/lgttm

merge conflicts fixed

/lgtm