Tendermint upgrade

BigchainDB has been running with Tendermint 0.22.8 for a while. It is important to keep pace with the Tendermint evolution. Therefore, upgrading the Tendermint version is crucial.
**Problem: Tendermint had some breaking changes, therefore, the adaption wasn't straight. **
Solution
The ABCI module of py-abci got updated and a push request got raised to get this into the official repository. In addition, the ABCI driver got integrated in a way to be compliant and adaptable for the future. This pull request upgrades to Tendermint 0.31.5 (ABCI 16.0).
Issues Resolved
This pull request successfully upgrades the Tendermint version of BigchainDB.

Codecov Report

Merging #2666 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #2666   +/-   ##
=======================================
  Coverage   93.46%   93.46%
=======================================
  Files          46       46
  Lines        2709     2709
=======================================
  Hits         2532     2532
  Misses        177      177

what is an upgrade path for an existing installation? please advise how to upgrade from 2.0.0b9 to 2.0.0

@dolphinsd See "election new chain-migration" in docs. And also BEP-42


Connect React and Redux

In this milestone, the following was done:

changed the default state in my books reducer from an empty array to an array with a few books.
Imported Redux Provider and wrapped my store in the main component of my React app.
Connected my app to the Redux store.
displays books from Redux store by consuming use selector API
added functionality for "Remove" button click
added functionality for the "Add book" button click;
added a functionality for "Check status" button click

@KanoCode Keep up the good work 😄


Support custom subject text

Close #230

The feature works nicely in the general case. I did notice that there are no constraints to the subject content in terms of length and characters. Considering that any client can request these on the spot, it might be for the best that we add some safeguards (e.g. 100 maximum length).

What do you think we should do when the length exceeds the limit? Should we treat it as if there is no subject parameter?

Also, subject is ignored if style is given an unsupported value.

As for this issue, it seems to be an existing bug. Consider the following two requests:

https://deps.rs/crate/syn/2.0.66/status.svg?style=for-the-badge&compact=invalid
https://deps.rs/crate/syn/2.0.66/status.svg?style=invalid&compact=true

They each have one parameter that is invalid, but neither of them responds to the other valid parameter.
The root of this problem seems to be that we can't simply get the extra_config through: serde_urlencoded::from_str::<ExtraConfigPartial>(qs).
We need to think about how to fix this.

@Enet4
All the bugs have been gracefully fixed! The relevant rationales are written in the code comments.
The fix was a bit trickier than expected, but eventually I managed to find a graceful solution.
Looking forward to your review!

@Enet4 Hello, two months have passed, can we merge this PR?

the same concept as label in shields.io,

is there any reason not to match the naming ?

@robjtede Thanks for the review! I will make changes and reply tomorrow!

the same concept as label in shields.io,

is there any reason not to match the naming ?

This is because we have been using the term subject instead of label for this concept in our internal code before. If we switch to label, it means overturning all the variable names in the previous code. I'm not sure if this is a good idea. Of course, exposing previous naming to the public can also cause confusion for users, so this is a trade-off, and I am not sure which option is better.

@robjtede All modifications have been completed, waiting for your final decision on whether to use subject or label, and looking forward to your review!

thanks for your work on this 👍🏻


TikTokPy gets stuck after start-up.

Hi @sudoguy,
How it's going?
I've tried to play around with the library for a little bit today. However, it does not seem to function properly for me.
I have copied the code you've written in the README file and it just seems to get stuck at "Getting Trending Items..":
2020-09-06 18:03:25 | INFO | 🥳 TikTokPy initialized. Version: 0.8.6
2020-09-06 18:03:26 | INFO | 🔧 Settings successfully loaded
2020-09-06 18:03:26 | INFO | 🛑 Cookies not found, anonymous mode
2020-09-06 18:03:26 | INFO | 📈 Getting trending items
Am I doing anything wrong?
I've tried using other functions as well but they all freeze after the program starts-up.
Thank you very much,
RoyIL

@RoyIL  i didnt even get this far :(
Any help is warmly welcome

Hi @sudoguy,
How it's going?
I've tried to play around with the library for a little bit today. However, it does not seem to function properly for me.
I have copied the code you've written in the README file and it just seems to get stuck at "Getting Trending Items..":
2020-09-06 18:03:25 | INFO | 🥳 TikTokPy initialized. Version: 0.8.6
2020-09-06 18:03:26 | INFO | 🔧 Settings successfully loaded
2020-09-06 18:03:26 | INFO | 🛑 Cookies not found, anonymous mode
2020-09-06 18:03:26 | INFO | 📈 Getting trending items
Am I doing anything wrong?
I've tried using other functions as well but they all freeze after the program starts-up.
Thank you very much,
RoyIL

Do you solve this problem sir?

Same here :
2020-10-23 23:25:24 | INFO | 📈 Getting trending items
📈 Getting trending EN: 100%|███████████████████████████████████████████████████| 5/5 [00:00<00:00, 1022.20it/s]
2020-10-23 23:25:33 | INFO | 📹 Found 5 videos
2020-10-23 23:25:33 | INFO | 🧭 Going to @xxxx._'s video<PHONE_NUMBER>562883329 page for like

And nothing else


Improvement idea

It would be nice to increase the delay for the returned {msg}, sometimes Midjourney can take time to start the generation, and msg is returned undefined before the generation ended.
I'm thinking about doing it manually meanwhile, can you help me by giving me the line of code (if possible) my knowledge are limited ?
Thank you

const msg = await client.Imagine("A little pink elephant", (uri: string) => {
  console.log("loading", uri);
});


[CodeSynthesis] Improve synthesized Decodable.init(from:) for enums

Don't use unsafelyUnwrapped which is usually not recommended
Don't access container.allKeys multiple times as it's a computed property

Before:
  guard container.allKeys.count == 1 else { throw ... }
  switch container.allKeys.first.unsafelyUnwrapped { ... }

After:
  var allKeys = ArraySlice(container.allKeys)
  guard let theKey = allKeys.popFirst(), allKeys.isEmpty else { throw ... }
  switch theKey { ... }

rdar://89150202

@swift-ci Please test

@swift-ci Please test

@swift-ci Please smoke test


Add featured blog post cards to forum homepage

It would be nice to show featured blog posts in the form of cards on the forum home page.
https://ibb.co/hFgfBXq

This would be cool! I guess it would be like a blog widget.

This would be cool! I guess it would be like a blog widget.


a code line seems wrong in the guide of "SpawnObject"

The likely wrong is in "Mirror/doc/Guides/GameObjects/SpawnObject.md". Should it be "NetworkManager"?

I don't know for sure because I am new here to learn Mirror.

Its possible to make custom NetworkManager's that dont inherit from the one that is included, I assume it is showing an example of that.

Thanks.


Using in another python script?

Checklist

[X] I'm asking a question
[X] I've looked through the README and FAQ for similar questions
[X] I've searched the bugtracker for similar questions including closed ones

Question

YTDL is written in Python. I was wondering if I could somehow call this (like a function) from another Python script and return the result. If this is possible, how would I do that? Thank you in advance.

Read embedding section of FAQ.


Regression against 1.0.3: "error[E0583]: file not found for module"

With a 2015-edition crate, "cargo fmt" fails on both current beta and nightly, whereas stable works:
% cargo fmt --version && cargo fmt -- --check
rustfmt 1.0.3-stable (d6829d6 2019-02-14)
% cargo +nightly fmt --version && cargo +nightly fmt -- --check
rustfmt 1.2.2-nightly (5274b49 2019-04-24)
error[E0583]: file not found for module `common`
  --> /home/rotty/src/crates/zmq/tests/connection.rs:13:5
...
% cargo +beta fmt --version && cargo +beta fmt -- --check
error[E0583]: file not found for module `common`
...

Note that for beta, the --version flag seems to be broken as well; it yields no output, although rustfmt --version works:
% rustup run beta rustfmt --version
rustfmt 1.2.0-beta (09940a7 2019-03-27)

Anyway, to reproduce, you can run the following:
% git clone -b rustfmt-issue/file-not-found https://github.com/rotty/rust-zmq.git
% cd rust-zmq
% cargo +nightly fmt -- --check
error[E0583]: file not found for module `common`
...
% cargo fmt -- --check

Note that changing to the 2018 edition for the rust-zmq crate did not help, the same error message is produced by cargo +beta fmt.

A minimal working example
Create a rust file with a submodule declaration and a directory whose name is the same as the rust filename.
src
├── common
│   └── mod.rs
├── connection
└── connection.rs

src/connection.rs
mod common;

I think I found a similar, likely related, error but it only fails on tests. Running cargo fmt on the following files result in the following error
error[E0583]: file not found for module `thing`
 --> /rustfmt_test/tests/functional.rs:2:9
  |
2 |     mod thing;
  |         ^^^^^
  |
  = help: name the file either thing.rs or thing/mod.rs inside the directory "/rustfmt_test/tests/functional/functional"

The files.
// /tests/functional.rs
mod functional {
    mod thing;
}

// /tests/functional/thing.rs
#[test]
fn some_test() { assert!(true); }

As the error suggests it uses the functional directory twice. Calling cargo test works just fine.

We're hitting this error in Mio (https://github.com/tokio-rs/mio/pull/1030), is there any work around for this?

On the original example in the OP, does adding an explicit path attribute help?
I.e. in tests/connection.rs something like:
#[macro_use]
#[path = "common/mod.rs"]
mod common;

@calebcartwright The following doesn't work (this is actual code as in https://github.com/tokio-rs/mio/pull/1030). I get Error writing files: io error: Failed to find module poll in "functional" None as error.
#[path = "functional"]
mod functional {
    mod poll;
}

A found a possible workaround in the following.
#[path = "functional/poll.rs"]
mod poll;

Thanks @Thomasdezeeuw. I tested adding the path with the sample repo linked in the original note, but didn't get a chance to look at the Mio codebase.
Are you saying that the snippet you posted using path provides a work around for you in Mio?
#[path = "functional/poll.rs"]
mod poll;

I ended up needing to write a way to complicate macro as can be seen here: https://github.com/tokio-rs/mio/blob/8abd613656c7438fc8b783f1630a9f61532b5444/tests/functional.rs. But yes that should work.
I'm not familiar with the rustfmt code base, but to me it seems that rustc and rustfmt handle module paths differently when the module is not in its own directory, i.e. functional.rs instead of functional/mod.rs. I think this because we've hit another (similar bug) that doesn't use path, where the mod util (in the previously linked file) is also not found by rustfmt, but it's fine for rustc. See https://dev.azure.com/tokio-rs/Tokio/_build/results?buildId=1511&view=logs&jobId=f14073de-e1a4-5ba6-5dc1-4c667fb92951 for the error.

I wrote a crappy bash script that will simulate one example of this failure, just cd /tmp/foodir or something before you run it.
set -v -o pipefail

# Some diagnostics
cargo --version
cargo fmt --version
# Create a repo
cargo new --lib --vcs git --edition 2018 demo
cd demo
# Minimal working structure
echo "mod foo;" > src/lib.rs
touch src/foo.rs
cargo build
cargo fmt

# Cleanup target dir juuust in case
rm -r target

# Break the build
mkdir src/lib

# Cargo is still fine
cargo build

# But rustfmt ... yeah nah
cargo fmt

So still failing with
cargo 1.39.0-nightly (22f7dd049 2019-08-27)
rustfmt 1.4.6-nightly (f800ce4 2019-08-28)

The crappy part really is how an empty directory can even mess this up, which is annoying, because you don't see empty directories in git status >_>

Possibly fixed by #4194


rework dimension

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-1 of 33 (96.97%)  changed or added relevant lines in 12 files are covered.
12 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.02%) to 95.018%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Hamiltonians/abstract.jl
16
17
94.12%

Files with Coverage Reduction
New Missed Lines
%

src/BitStringAddresses/sortedparticlelist.jl
1
89.03%

src/Hamiltonians/abstract.jl
11
93.18%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
5969

Relevant Lines:
6282

💛  - Coveralls


Not able to create PrivateLink access for AWS account

Problem statement: Trying to create a private link access from the different VPC but from the AWS account, but it's failing with the error.
╷
│ Error: error creating Private Link Access "": 409 Conflict: There are privatelinks with same realm and network, cannot create another private link with same attributes.
│
│   with confluent_private_link_access.aws,
│   on [main.tf](http://main.tf/) line 12, in resource "confluent_private_link_access" "aws":
│   12: resource "confluent_private_link_access" "aws" {
│
╵
╷
│ Error: creating Route53 Hosted Zone (**.us-west-2.aws.confluent.cloud): operation error Route 53: CreateHostedZone, https response error StatusCode: 400, RequestID: ****, ConflictingDomainExists: The VPC ** in region us-west-2 has already been associated with the hosted zone XYZ with the same domain name.
│
│   with aws_route53_zone.privatelink,
│   on [main.tf](http://main.tf/) line 84, in resource "aws_route53_zone" "privatelink":
│   84: resource "aws_route53_zone" "privatelink" {
│

Please help me with the same. Just to give some context: the dedicated cluster in my case has already a private link connectivity from one of the VPCs in the same AWS account and working properly, but while creating the AWS private link access from the different VPC under the same AWS account it's failing with this error.
Other piece of code that's used for creating private link.
data "confluent_environment" "env_id" {
  id = var.kafka_env_id
}

data "confluent_network" "private_link" {
  id = var.network_id
  environment {
    id = var.kafka_env_id
  }
}

resource "confluent_private_link_access" "aws" {
  display_name = "AWS-Private-Link-Access"
  aws {
    account = var.account_id
  }
  environment {
    id = data.confluent_environment.env_id.id
  }
  network {
    id = data.confluent_network.private_link.id
  }
}

# https://docs.confluent.io/cloud/current/networking/private-links/aws-privatelink.html
# Set up the VPC Endpoint for AWS PrivateLink in your AWS account
# Set up DNS records to use AWS VPC endpoints

data "aws_vpc" "privatelink" {
  id = var.vpc_id
}

data "aws_availability_zone" "privatelink" {
  for_each = var.subnets_to_privatelink
  zone_id  = each.key
}

resource "aws_security_group" "privatelink" {
  # Ensure that SG is unique, so that this module can be used multiple times within a single VPC
  name        = "cloud-privatelink_${var.env_name}_${var.vpc_id}"
  description = "Confluent Cloud Private Link minimal security group for ${var.account_id} in ${var.vpc_id}"
  vpc_id      = data.aws_vpc.privatelink.id

  ingress {
    description = "Allow all traffic"
    from_port   = 0
    to_port     = 0
    protocol    = -1
    cidr_blocks = ["[<IP_ADDRESS>/0](http://<IP_ADDRESS>/0)"]
  }

  egress {
    from_port   = 0
    to_port     = 0
    protocol    = "-1"
    cidr_blocks = ["[<IP_ADDRESS>/0](http://<IP_ADDRESS>/0)"]
  }

  lifecycle {
    create_before_destroy = true
  }
}

resource "aws_vpc_endpoint" "privatelink" {
  vpc_id            = data.aws_vpc.privatelink.id
  service_name      = data.confluent_network.private_link.aws[0].private_link_endpoint_service
  vpc_endpoint_type = "Interface"

  security_group_ids = [
    aws_security_group.privatelink.id,
  ]

  subnet_ids          = [for zone, subnet_id in var.subnets_to_privatelink : subnet_id]
  private_dns_enabled = false

  depends_on = [
    confluent_private_link_access.aws,
  ]
}

resource "aws_route53_zone" "privatelink" {
  name = var.hosted_zone

  vpc {
    vpc_id = data.aws_vpc.privatelink.id
  }
}

resource "aws_route53_record" "privatelink" {
  count   = length(var.subnets_to_privatelink) == 1 ? 0 : 1
  zone_id = aws_route53_zone.privatelink.zone_id
  name    = "*.${[aws_route53_zone.privatelink.name](http://aws_route53_zone.privatelink.name/)}"
  type    = "CNAME"
  ttl     = "60"
  records = [
    aws_vpc_endpoint.privatelink.dns_entry[0]["dns_name"]
  ]
}

locals {
  endpoint_prefix = split(".", aws_vpc_endpoint.privatelink.dns_entry[0]["dns_name"])[0]
}

resource "aws_route53_record" "privatelink_zonal" {
  for_each = var.subnets_to_privatelink

  zone_id = aws_route53_zone.privatelink.zone_id
  name    = length(var.subnets_to_privatelink) == 1 ? "*" : "*.${each.key}"
  type    = "CNAME"
  ttl     = "60"
  records = [
    format("%s-%s%s",
      local.endpoint_prefix,
      data.aws_availability_zone.privatelink[each.key].name,
      replace(aws_vpc_endpoint.privatelink.dns_entry[0]["dns_name"], local.endpoint_prefix, "")
    )
  ]
}

terraform {
  backend "s3" {}
}

resource "aws_instance" "ec2_instance" {
  count                = var.create_ec2 ? 1 : 0
  ami                  = var.ami
  instance_type        = "t2.micro"
  monitoring           = true
  iam_instance_profile = var.iam_role

  root_block_device {
    volume_type           = "gp2"
    volume_size           = 30
    delete_on_termination = false
    encrypted             = false
  }

  vpc_security_group_ids = [aws_security_group.privatelink.id]
  subnet_id              = lookup(var.subnets_to_privatelink, "usw2-az1", "")

  lifecycle {
    create_before_destroy = true
  }

  user_data = file("${path.module}/userdata.sh")

  tags = {
    Name = "PROD_Confluent_Script_Runner"
  }
}

All the vars are passed via terragrunt as inputs and used in this module to run this terraform.
@linouk23 please help me with the same.

@confluent-alec-kendall @ConfluentSpencer ^

👋 @VipulSharma1999 did you get a chance to look at dedicated-privatelink-aws-kafka-acls already?

@VipulSharma1999 any thoughts about @linouk23 's question?


Reddit Refactor

Hey, I saw your post on Reddit today and decided to contribute a bit to your project. I hope these refactors make sense, but if you would like further clarification on anything comment on my PR.
Otherwise, mergey merge!
Cheers,
Imjohsep

I am a hobbyist/beginner with Python and am interested in using this to learn a bit more.
Using git I have cloned the repoitry and successfully run the code (incl. Twilio). Im not sure though how to checkout the specific commit above from @imjohsep as Id like to test that too?

@revren You can clone my forked version of this repo to get a version of the pull request (PR) on this thread. Just go here and clone/download. Then, if you want to improve my PR you can fork my repo, make changes, push your changes to your fork, and  make a PR request against my repo. Good luck!

Thanks for the PR @imjohsep! I'm happy to see that you've found this project interesting. I'll take a look at the code soon.

Thanks very much for the guidance @imjohsep
I have had a dig on my own fork, using the original branch. I have started to test a similar this approach for easyjet.com (European provider). @wcrasta obviously credit will be due for your approach - what are your thoughts on how I should share/use my code? Perhaps we could even combine efforts and have a config file for each flight provider?

 Since this project is advertised as a Southwest scraper, for now, I'd prefer it to leave it just for Southwest. However, once your project is up and running, I'd be open to linking to it from this repository's README!

Hi @imjohsep, great work on the additions.  I was just wondering if there was any particular reason to use optparse? It has been deprecated since Python 3.2 and replaced with argparse.

@imjohsep, just had some time to review your PR and it was fantastic. Thanks for your contribution. Being new to Python myself, I learned a lot in terms of best practices from your refactoring. The code looks very neat/clean now.
I did make a few changes, but like @cjmarvin, I too am wondering about argparse vs. optparse. Thanks.

Good catch @cjmarvin. I work at a 2.7 shop, so didn't see that deprecation notice on 3.2. Luckily the syntax is relatively similar to optparse, so the switch was ezpz. see #6
@wcrasta Thanks for merging! I like your usage of the ini file and configparser.

@revren I don't see any of your changes on your fork/repo.  I recommend pulling in @wcrasta's master branch into your fork to keep your fork up-to-date. You will likely have some merge conflicts if you have done a lot of work on your local version.

No problemo @imjohsep, I also haven't fully bit the 3.x bullet (mostly work in science, so slowly migrating from 2.7 to 3.5+), so I know what you mean.


Include Pundit module in controller examples

In order for the verify_authorized and verify_policy_scoped methods to be defined in your controllers, you must include Pundit. This is stated early in the documentation, but it's not clear in these particular examples that it's needed.

ugh, sorry for the typo in there... fixing it up now...

Thanks.

:heart:


[da-vinci] Added a speedup throttler when DaVinci is bootstrapping current versions

Summary, imperative, start upper case, don't end with a period
When working with DaVinci customers, we often tune the ingestion params to speed up the bootstrapping, but we don't want to use the same setup at the steady state since the high ingestion throughput would affect the performance of the read path. This PR introduces a way to dynamically switch ingestion throttlers based on the ingestion status.
Essentially, this new feature would switch to the speedup throttler when it detects any current version bootstrapping and otherwise, it will continue to use the regular throttler.
To optimize the bootstrapping perf, we can bump up the following pools together with this feature:

Consumer pool.
Drainer/writer pool. As the GC issue is mainly triggered by the ingestion speed, we can safely increase the pool size.

New configs:
da.vinci.current.version.bootstrapping.speedup.enabled : default false da.vinci.current.version.bootstrapping.quota.records.per.second : default -1 da.vinci.current.version.bootstrapping.quota.bytes.per.second : default -1

How was this PR tested?
CI

Does this PR introduce any user-facing changes?

[x] No. You can skip the rest of this section.
[ ] Yes. Make sure to explain your proposed changes and call out the behavior change.

To optimize the bootstrapping perf, we can bump up the following pools together with this feature:
Consumer pool.
Drainer/writer pool. As the GC issue is mainly triggered by the ingestion speed, we can safely increase the pool size.

Just to confirm, this PR only address 1, is that right?

To optimize the bootstrapping perf, we can bump up the following pools together with this feature:
Consumer pool.
Drainer/writer pool. As the GC issue is mainly triggered by the ingestion speed, we can safely increase the pool size.

Just to confirm, this PR only address 1, is that right?

The consumer pool/drainer pool tuning can be done without this change, and this PR is mainly to offer a dynamic throttler.

To optimize the bootstrapping perf, we can bump up the following pools together with this feature:
Consumer pool.
Drainer/writer pool. As the GC issue is mainly triggered by the ingestion speed, we can safely increase the pool size.

Just to confirm, this PR only address 1, is that right?

The consumer pool/drainer pool tuning can be done without this change, and this PR is mainly to offer a dynamic throttler.

Oh you mean just adjusting the pool count in the config. I see..


Release 0.1.0-beta.2

There are a few fixes in ember and sails lookups which would be good to have in the beta.

Yep, on it now.

Had a bizarre error message, but should be published now. Give it a try.

I've heard from others that it's working well.


Request for Documentation: Align recommendations on file descriptor limits across all docs

Mattermost user stu.doherty from https://community.mattermost.com has requested the following be documented:
Admins can manage the limits on "number of file descriptors" allowed for the Mattermost server in 2 different ways:

Setting those limits in the mattermost.service systemd unit file.  This shows up in "Installing Mattermost Server" guide for at least ubuntu, but not sure we are specific in RHEL or others., E,g, Step 10b here
Modifying limits.conf as described here on steps 2 and 3

We need to somehow rationalize this guidance.  I suspect option 1 above would be our standard recommendation, and 2 would be a side link or call-out box that simply describes something like "If not using systemd to manage the Mattermost service, you can also modify file descriptor limits using the following approach" then show the information on modifying limits.conf in this way:
* soft nofile 65536
* hard nofile 65536
* soft nproc 8192
* hard nproc 8192

While we're here, we may need to do some cross-linking to make sure this information is easily discoverable.  For example, these guides should somehow bring me to this important consideration for large scale setups (i.e., file limit settings):
https://docs.mattermost.com/deployment/cluster.html
https://docs.mattermost.com/deployment/enterprise-deployment-guide.html
ORIGINAL CONVERSATION in a Incident Channel
https://docs.mattermost.com/install/install-ubuntu-2004.html#installing-mattermost-server
See the original post here.
This issue was generated from Mattermost using the Doc Up plugin.

@sadohert - Would you or a member of your team be open to creating a PR for this documentation request?

can you assign me this issue
?


Bugfix: LANDGRIF-780 solve gadm boundary issues

General description
This PR adds a fix to solve GADM accuracy issues.
To validate determine and validate an admin region given address or coordinates, it creates a 1KM buffer given this geometry to intersect with all admin regions.
This 1KM buffer should be enough to solve this lack of accuracy. If the country provided by the user is within the intersecting countries of this buffer, we consider that the location is accurate
It also brings back this validation for interventions
Plus adds a test for when the geocoder returns multiple results and we save the most accurate interpretation
Designs
Link to the related design prototypes (if applicable)
Testing instructions
There are 2 new files in the repo that you can use for testing.

The one named 'multiple results' should create 4 sourcing locations, with 2 of them having a location warning value in sourcingLocations.locationWarning, as these sourcing location geolocation data returns multiple results (A region and a city withing that region could be named equaly for example)

The 'address outside country' file has a location with a spanish address, but Japan as a country. This should raise and exception, letting the user know this info. Remember you can't have this info in a sync manner if you run this by Postman.
You can check the logs, and you can also check the error in the Task tracking this async import

Apart from the added feature / bug fix, check overall performance, styling...

Checklist before merging

[x] Branch name / PR includes the related Jira ticket Id.
[ ] Tests to check core implementation / bug fix added.
[x] All checks in Continuous Integration workflow pass.
[ ] Feature functionally tested by reviewer(s).
[ ] Code reviewed by reviewer(s).
[ ] Documentation updated (README, CHANGELOG...) (if required)

Testing in local done - all as expected


[Bug] after kv int8 quantization, qwen and baichuan chat model return meaningless and repetitive words.

Checklist

[ ] 1. I have searched related issues but cannot get the expected help.
[ ] 2. The bug has not been fixed in the latest version.

Describe the bug
after kv int8 quantization, qwen and baichuan chat model return meaningless and repetitive words. It seems qwen doesn't support kv int8 quantization
Reproduction
1. cp -r $path-to-Qwen-14B-Chat /nvme/qa_test_models/Qwen-14B-Chat-inner-kvint8
2. lmdeploy lite calibrate /nvme/qa_test_models/Qwen-14B-Chat --work-dir /nvme/qa_test_models/Qwen-14B-Chat-inner-kvint8
3. lmdeploy chat turbomind /nvme/qa_test_models/Qwen-14B-Chat-inner-kvint8 --tp 2 --model-format hf --quant-policy 4

Environment
/home/zhulin1/miniconda3/envs/lmdeployv23/lib/python3.10/site-packages/fuzzywuzzy/fuzz.py:11: UserWarning: Using slow pure-python SequenceMatcher. Install python-Levenshtein to remove this warning
  warnings.warn('Using slow pure-python SequenceMatcher. Install python-Levenshtein to remove this warning')
sys.platform: linux
Python: 3.10.0 (default, Mar  3 2022, 09:58:08) [GCC 7.5.0]
CUDA available: True
MUSA available: False
numpy_random_seed:<PHONE_NUMBER>
GPU 0,1,2,3,4,5,6,7: NVIDIA A100-SXM4-80GB
CUDA_HOME: /usr/local/cuda-11.7
NVCC: Cuda compilation tools, release 11.7, V11.7.64
GCC: gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)
PyTorch: 2.1.0+cu118
PyTorch compiling details: PyTorch built with:
  - GCC 9.3
  - C++ Version: 201703
  - Intel(R) oneAPI Math Kernel Library Version 2022.2-Product Build 20220804 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v3.1.1 (Git Hash 64f6bcbcbab628e96f33a62c3e975f8535a7bde4)
  - OpenMP 201511 (a.k.a. OpenMP 4.5)
  - LAPACK is enabled (usually provided by MKL)
  - NNPACK is enabled
  - CPU capability usage: AVX512
  - CUDA Runtime 11.8
  - NVCC architecture flags: -gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_80,code=sm_80;-gencode;arch=compute_86,code=sm_86;-gencode;arch=compute_37,code=sm_37;-gencode;arch=compute_90,code=sm_90
  - CuDNN 8.7
  - Magma 2.6.1
  - Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=11.8, CUDNN_VERSION=8.7.0, CXX_COMPILER=/opt/rh/devtoolset-9/root/usr/bin/c++, CXX_FLAGS= -D_GLIBCXX_USE_CXX11_ABI=0 -fabi-version=11 -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -DNDEBUG -DUSE_KINETO -DLIBKINETO_NOROCTRACER -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -O2 -fPIC -Wall -Wextra -Werror=return-type -Werror=non-virtual-dtor -Werror=bool-operation -Wnarrowing -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-unused-parameter -Wno-unused-function -Wno-unused-result -Wno-strict-overflow -Wno-strict-aliasing -Wno-stringop-overflow -Wno-psabi -Wno-error=pedantic -Wno-error=old-style-cast -Wno-invalid-partial-specialization -Wno-unused-private-field -Wno-aligned-allocation-unavailable -Wno-missing-braces -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Werror=cast-function-type -Wno-stringop-overflow, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_DISABLE_GPU_ASSERTS=ON, TORCH_VERSION=2.1.0, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=1, USE_NNPACK=ON, USE_OPENMP=ON, USE_ROCM=OFF,

TorchVision: 0.16.0+cu118
LMDeploy: 0.2.3+
transformers: 4.37.0
gradio: 3.50.2
fastapi: 0.109.2
pydantic: 2.6.1

Error traceback
[llama]
model_name = qwen-14b
tensor_para_size = 2
head_num = 40
kv_head_num = 40
vocab_size = 152064
num_layer = 40
inter_size = 13696
norm_eps = 1e-06
attn_bias = 1
start_id = 0
end_id = 151643
session_len = 8200
weight_type = bf16
rotary_embedding = 128
rope_theta = 10000.0
size_per_head = 128
group_size = 0
max_batch_size = 128
max_context_token_num = 1
step_length = 1
cache_max_entry_count = 0.8
cache_block_seq_len = 128
cache_chunk_size = -1
num_tokens_per_iter = 0
max_prefill_iters = 1
extra_tokens_per_iter = 0
use_context_fmha = 1
quant_policy = 4
max_position_embeddings = 2048
rope_scaling_factor = 0.0
use_logn_attn = 1

2024-02-19 13:24:03,807 - lmdeploy - WARNING - get 723 model params
2024-02-19 13:24:14,554 - lmdeploy - WARNING - loading kv_cache quant scale
2024-02-19 13:24:14,584 - lmdeploy - WARNING - Input chat template with model_name is None. Forcing to use qwen-14b
[WARNING] gemm_config.in is not found; using default GEMM algo
[WARNING] gemm_config.in is not found; using default GEMM algo
session 1

double enter to end input >>> hello

<|im_start|>system
You are a helpful assistant.<|im_end|>
<|im_start|>user
hello<|im_end|>
<|im_start|>assistant
 2024-02-19 13:24:28,113 - lmdeploy - WARNING - kwargs top_p is deprecated for inference, use GenerationConfig instead.
2024-02-19 13:24:28,113 - lmdeploy - WARNING - kwargs top_k is deprecated for inference, use GenerationConfig instead.
2024-02-19 13:24:28,113 - lmdeploy - WARNING - kwargs temperature is deprecated for inference, use GenerationConfig instead.
2024-02-19 13:24:28,113 - lmdeploy - WARNING - kwargs repetition_penalty is deprecated for inference, use GenerationConfig instead.
2024-02-19 13:24:28,113 - lmdeploy - WARNING - kwargs ignore_eos is deprecated for inference, use GenerationConfig instead.
2024-02-19 13:24:28,113 - lmdeploy - WARNING - kwargs random_seed is deprecated for inference, use GenerationConfig instead.
2024-02-19 13:24:28,113 - lmdeploy - WARNING - kwargs request_output_len is deprecated for inference, use GenerationConfig instead.
HelloHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMAHEMA

double enter to end input >>>

May try our latest main which supports online kv int8 and kv int4.
No more offline calibration is needed.

fixed in version 0.4.0


TresCanvas doesn't render in Dynamicly loaded components or deeply nested components

Describe the bug
I am trying to use a TresCanvas that is known to work when using in a staticly declared way
but if I use it in a component that is dynamicly loaded using
defineAsyncComponent(() => import('@/components/pageBuilder/component.vue'))
it doesn't render the canvas the most I can get is the following

<canvas style=""></canvas>

Recent findings
just having the TresCanvas in a component that is nested 2 levels deep doesn't work.
no idea why or what is causing this.
I've provided a reproduction of this
Reproduction
https://stackblitz.com/edit/tresjs-basic-z2g8yk?file=src%2Fcomponents%2FTheExperience.vue
Steps to reproduce
No response
System Info
No response
Used Package Manager
npm
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

why using Vite in teh reproduction? this repo is about Nuxt

that was the default setup that was provided to me. when creating a ticket

Hi @RGaskinLtd your reproduction wasn't working because you missed the import import { defineAsyncComponent } from 'vue'; (The console log warned about it)
Here is working https://stackblitz.com/edit/tresjs-basic-ffcbq9?file=src%2Fcomponents%2FTheExperience.vue
Next time please open the ticket on the correspondent repo since this has nothing to do with Nuxt. Thanks!


Unable to set XAML properties through x:Uid in WinUI 3 preview 1 (desktop)

Describe the bug

Defining a resource in resw as below
SettingsPage_General.Content	General

and referencing it in the XAML is not working
            <NavigationViewItem x:Uid="SettingsPage_General" Icon="MusicInfo" />

Steps to reproduce the bug

Steps to reproduce the behavior:

See above

Expected behavior

Text in NavigationViewItem should be set from the resw file
Screenshots

Version Info
WinUI 3 preview 1

Duplicate of #2602


PKCE flow?

Hi,
I was just wondering if PKCE flow belongs to the scope of this library? If so, is pull request welcomed? (might do it when I have free time)
ref: https://oauth.net/2/pkce/

If this library doesn't support it, does https://github.com/ueberauth/ueberauth support it?


[WIP] Shapella bodies

What was wrong?
How was it fixed?
To-Do

[ ] Add entry to the release notes (may forgo for trivial changes)
[ ] Clean up commit history

closing in favor of #706


Implements Swift Example

Hi there, I just found two small bugs.
One is about UIlongPressGestureRecognizer could be added multiple times because the condition check in - (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath.
And another is about UIAlertController that could be presenting multiple times because of it's a continuous event recognizer.
Also, I implement Swift Example as well since I'm working on a Swift project.
Thanks all the great efforts of SlackTextViewController!! It's really really really COOL and AWESOME!!!
Cheers,
Allen

Cool! That's AWESOME :smile:


Update packaged golang version to 1.19.1

This change updates the packaged golang version from 1.16 to 1.19.1. 1.16 has multiple known vulnerabilities which trips up vulnerability scanners. Updating to the latest golang version that is available at https://hub.docker.com/_/golang.
Once this is merged, I intend to upgrade the durable-task plugin with the new version.

[ ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Looks like I didn't follow the branch naming rule. I'll get a new one going.

Closed in favor of https://github.com/jenkinsci/lib-durable-task/pull/60


Rewrite Powershell Script to Simplify  Bread Decode Step

Rewrite the Powershell encoding and Ruby decoding for the bread method of miq_hyperv_disk.

Change the buffer size from 32K to 128K.
Increase number of buffer cache entires from 300 to 1200.
Change the Powershell encoding step from ToBase64String to ToBase64CharArray and use [string]::join to create a non-space delimited string.
Simplify the Ruby decoding step by using the above join.

Tests on about a dozen VMs show dramatic improvement in performance due to the above changes.
@roliveri @chessbyte @Fryguy please review.  Merge when ready.  Thanks.

Fixed rubucop warning and re-pushed.

@roliveri @chessbyte @Fryguy any chance of a review on this PR?


How to train MCUNet from Scratch (and perform search with TinyNAS)

As commented in the title, I'm having trouble running the TinyNAS search code, and training the searched network. I think all I see in the TinyNAS folder are code for the model structure but not the NAS code (presumably it is in a similar fashion to ProxylessNAS). Any help would be appreciated

@zyzkevin I am having a similar issue. Were you ever able to make some headway in this?

@zyzkevin I am having a similar issue. Were you ever able to make some headway in this?

I think I ended up using AlphaNAS's training code to train the Supernet, and then adapted the code base to MCUNet's search settings to set up the search space.


needsclick can be applied to a tree of dom nodes, not just a single node

The change makes .needsclick's effect to be applied to a whole container.
I needed this as some libraries implement a similar behavior like fastclick and it causes double clicks. e.g: reveal.js, highcharts
fixes #302

:+1: could use this too

I wish your PR had been accepted.  Would have saved me a days worth of debugging.  I made a slightly related PR https://github.com/ftlabs/fastclick/pull/448 to see if preserving the existing functionality will make it easier to merge.


Alert Pop up box feature in contact form successfully imported

Description
Added alert box feature on submission of a contact form as when user fills all the detail and clicks on submit button then site takes user page not found page, I added an alert which will pops up and will tell the user that message was delivered successfully with a green tick along with the form is submitted successfully.
Checklist

[ ] I am making a proper pull request, not a spam.
[ ] I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests
issue #271
Add relevant screenshot or video (if any)
https://user-images.githubusercontent.com/61961107/122036464-3aaa8c00-cdf1-11eb-9e40-97e186eaa235.mp4

Great work!! Thank you :)


Update api.rst, fixed spelling

Ah, thanks!

I see now that this was against the maintenance branch: You'd think this would make it into the online docs, but it won't... the docs build from tags.

Yeaa I noticed that.  Just curious, I'm still learning, what does it mean
that the docs build from tags?
On Sun, Feb 1, 2015 at 4:18 PM, Markus Unterwaditzer <
<EMAIL_ADDRESS>wrote:

I see now that this was against the maintenance branch: You'd think this
would make it into the online docs, but it won't... the docs build from
tags.
—
Reply to this email directly or view it on GitHub
https://github.com/mitsuhiko/flask/pull/1335#issuecomment-72387637.

Master and the maintenance branches are modifyable... they point to a particular commit, their HEAD, but branches are "designed to be updated". Tags are really similar to branches, except that they're immutable (unless you force git to behave otherwise), so you can't just submit a PR against a tag.
We use branches to track minor/major versions (0.10.X, 1.0, etc, see semver), where master is the latest one, and do releases from each of them. Each release has its own tag.

Ahh, I see.  So if I understand correctly, although the branch we just
pushed to is the .10 maintenance one, since the docs build from the the .10
maintenance tag, this won't be visible online?
On Sun, Feb 1, 2015 at 4:18 PM, Markus Unterwaditzer <
<EMAIL_ADDRESS>wrote:

I see now that this was against the maintenance branch: You'd think this
would make it into the online docs, but it won't... the docs build from
tags.
—
Reply to this email directly or view it on GitHub
https://github.com/mitsuhiko/flask/pull/1335#issuecomment-72387637.


Element is not defined

Element is not defined
ReferenceError: Element is not defined
at Object. (/media/psf/wetravel-in-docker/ssr-next/node_modules/infinite-react-carousel/lib/carousel/types.js:142:80)
at Module._compile (internal/modules/cjs/loader.js:707:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:718:10)
at Module.load (internal/modules/cjs/loader.js:605:32)
at tryModuleLoad (internal/modules/cjs/loader.js:544:12)
at Function.Module._load (internal/modules/cjs/loader.js:536:3)
at Module.require (internal/modules/cjs/loader.js:643:17)
at require (internal/modules/cjs/helpers.js:22:18)
at Object. (/media/psf/wetravel-in-docker/ssr-next/node_modules/infinite-react-carousel/lib/carousel/slider.js:24:14)
at Module._compile (internal/modules/cjs/loader.js:707:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:718:10)
at Module.load (internal/modules/cjs/loader.js:605:32)
at tryModuleLoad (internal/modules/cjs/loader.js:544:12)
at Function.Module._load (internal/modules/cjs/loader.js:536:3)
at Module.require (internal/modules/cjs/loader.js:643:17)
at require (internal/modules/cjs/helpers.js:22:18)
Didn't work the previous solution suggestion.
https://github.com/g787543/infinite-react-carousel/issues/5

Hi @Turalmehdiyev
Can you give me your code or implement this issue with codesandbox?
I don't know how you got this error.

Hi,
The software that I want use it is really huge, in total 2GB of codebase,
even cause of the privacy concern can't share it. But as I see many people
see this issue on their project.
I have worked with many many libraries in life, As I see There could be a
conflict with different library, Somehow "Element" becomes null. (You used
it for prevArrow, nextArrow functions.)
It would be great if you can fix this issue, and let me know, cause it's
one of the best libraries that fits my project. Thanks. Regards
On Sat, Feb 15, 2020 at 3:51 PM Hans<EMAIL_ADDRESS>wrote:

Hi @Turalmehdiyev https://github.com/Turalmehdiyev
Can you give me your code or implement this issue with codesandbox
https://codesandbox.io/s/infinite-react-carousel-hwghe?
I don't know how you got this error.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/g787543/infinite-react-carousel/issues/10?email_source=notifications&email_token=AB5GXX4SXXFJ4N7NCAMOKALRC76QTA5CNFSM4KT4LJLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL3MJWQ#issuecomment-586597594,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB5GXX64G3B3LSLJ4KIIUXTRC76QTANCNFSM4KT4LJLA
.

Hi, Are you use SSR to render?

Hi,
Yes, I use SSR.
On Sun, Feb 16, 2020 at 4:15 AM Hans<EMAIL_ADDRESS>wrote:

Hi, Are you use SSR to render?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/g787543/infinite-react-carousel/issues/10?email_source=notifications&email_token=AB5GXX7BRAPNTFQ6XETOFX3RDCVU7A5CNFSM4KT4LJLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL34QOY#issuecomment-586663995,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB5GXX3TMNPETQZ3AZHHKATRDCVU7ANCNFSM4KT4LJLA
.

Got it, I will try to fix it.

Thanks in advance. Good luck!
On Sun, Feb 16, 2020 at 2:13 PM Hans<EMAIL_ADDRESS>wrote:

Got it, I will try to fix it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/g787543/infinite-react-carousel/issues/10?email_source=notifications&email_token=AB5GXX5H2SXHK5XL45QZ2MDRDE3ZHA5CNFSM4KT4LJLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL4GQCI#issuecomment-586704905,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB5GXX4IGZSHMWZX3UNBFPDRDE3ZHANCNFSM4KT4LJLA
.


🐛 internalError/io when unknown files are passed as CLI arguments

Environment information
CLI:
  Version:                      main branch
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           unset
  JS_RUNTIME_NAME:              unset
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Workspace:
  Open Documents:               0

What happened?
❯ cat biome.json
{}

❯ ls src/
file1.js
file2.unknown

❯ ./biome format src/*
src/file2.unknown files/missingHandler ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ⚠ Biome doesn't know how to process this file

Compared 1 file(s) in 3ms
Skipped 1 file(s)
internalError/io ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ✖ No files were processed in the specified paths.

Expected result
No internal error should be emitted.
Code of Conduct

[X] I agree to follow Biome's Code of Conduct

What's the bug? Biome doesn't support globs via command line

The glob is not passed to Biome. ./biome.fix format src/* is expanded to ./biome.fix format src/file1.js src/file2.js by the shell.
Thus, you get the same error without the glob:
❯ ./biome.fix format src/*
src/file2.unknown files/missingHandler ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ⚠ Biome doesn't know how to process this file

Compared 1 file(s) in 3ms
Skipped 1 file(s)
internalError/io ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ✖ No files were processed in the specified paths.

The issue is the error.

Thank you, I suspected so, but not every shell does glob expansion and we require a deterministic way to reproduce the issue.

Faced this problem, but in a situation where we have svg files in the directory we are checking (I suppose this could be a fairly common case)

Your use case @e965 should be fixed in v1.5.1

@ematipico Yeah, problem solved. Thank you!


frontend: Fix unnecessary positive tabindex assignments.

Resolves #5003.
I didn't modify The Stream, Topic, recipient, and message content fields and submit button in the new message form: wondering whether the positive tabindex should be kept, so users can focus on this content right away?

Automated message from Dropbox CLA bot
@vaidap, it looks like you've already signed the Dropbox CLA. Thanks!

Codecov Report

Merging #5479 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5479      +/-   ##
==========================================
- Coverage   86.59%   86.57%   -0.02%
==========================================
  Files         430      430
  Lines       53179    53219      +40
  Branches     2069     2070       +1
==========================================
+ Hits        46050    46077      +27
- Misses       7129     7142      +13

Impacted Files
Coverage Δ

zerver/tornado/descriptors.py
83.33% <0%> (-6.67%)
:arrow_down:

zerver/lib/avatar_hash.py
94.11% <0%> (-5.89%)
:arrow_down:

zerver/lib/avatar.py
96.96% <0%> (-3.04%)
:arrow_down:

zproject/jinja2/backends.py
91.83% <0%> (-1.79%)
:arrow_down:

zerver/tests/test_logging_handlers.py
99.26% <0%> (-0.74%)
:arrow_down:

zerver/lib/cache.py
87.12% <0%> (-0.33%)
:arrow_down:

zerver/templatetags/minified_js.py
53.12% <0%> (-0.21%)
:arrow_down:

zerver/lib/actions.py
95.19% <0%> (-0.06%)
:arrow_down:

zproject/settings.py
84.81% <0%> (ø)
:arrow_up:

frontend_tests/node_tests/settings_bots.js
100% <0%> (ø)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bccd2ca...e57f418. Read the comment docs.

You can fix the compose box stuff, too, and just do a good amount of manual testing.  I believe that most of the tabbing should just work naturally, and we have logic in place to auto-focus fields that should work directly off of HTML attributes, not tabindex, so that shouldn't break.  But, again, give it some good testing.

@showell , could you help me out with some use cases i should be testing for/what the expected results should be?
right now i've only got two:
ENTER while focused on a PM/thread so the compose box pops up

in both cases, focus jumps to compose box -> good
tabindex: going back (SHIFT+TAB) focuses on URL of website -> bad?
no tabindex: going back focuses on the stream's threads -> good

ESC pressed when focused on composed box, attempt to navigate with SHIFT+TAB

tabindex: focuses on URL -> bad
focuses on stream threads -> good

there's some (what i suppose) are hidden elements being focused on (chrome just doesn't show me any element data?) inbetween the correct elements stated here but that's going to be fixed in #5024.

Haha, yeah, I don't think the current behavior makes any sense.

I think it's generally safe to assume that most tab/shift-tab behavior is currently broken, except for very local things that do the sensible thing now--for example, inside the compose box, you can assume there was some thought, but as soon as shift-tab takes you into the message pane, that's almost certainly accidental and probably confusing to users.

agreed! what would be the best course of action here, in terms of specifying a logical TAB flow?

  We should have a discussion on chat about an overall strategy.

makes sense -- will start a topic on chat. thanks!

I'm merging the first change here, which will effectively close this PR.  I think you can proceed on some of the other stuff before big decisions are made.


Since version 3.1 getCroppedCanvas doesn't resize the image

I noticed now that since version 3.1 the cropper doesn't resize the image to the desired width. This is my code that worked perfectly with previous versions.
uploadSubmit.click(function() {

            croppedImg.cropper('getCroppedCanvas',{
                width: 600,
                fillColor: '#fff'
            }).toBlob(function (blob) {
                var formData = new FormData();

                formData.append('croppedImage', blob);
                formData.append('type', uploadPhpType);

                $.ajax('media-upload.php', {
                    method: "POST",
                    data: formData,
                    processData: false,
                    contentType: false,
                    dataType: "json", //the return type data is jsonn
                    success: function ( data ) {
                        [....]
                    },
                    error: function () {
                            [....]
                    }
                });
            }, 'image/jpeg', 0.80);
        });

Any demo or screenshots?

It's for me difficult to provide you a demo because I integrated it in a CMS in italian language.
There are no errors in the console and image is correctly cropped but the size remains the same as the uploaded image.
Would be happy to provide you additional info if you need.

Pehaps I have understood: using getCroppedCanvas you have to specify width and hight values. With older versions width value was sufficient. So returning to my code, this works:
croppedImg.cropper('getCroppedCanvas',{
                width: 600,
                height: 600 / 1.6,
                fillColor: '#fff'
            }).toBlob {[...]},
'image/jpeg', 0.80);
        });

Cannot reproduce. Please try on the latest version again.

Problem still remains, previously it was possible to use getCroppedCanvas without specifing the image height (just width) and now without the height property the file remains with the original resolution.

Original image

Uploaded image (imageSmoothingQuality=low)

Uploaded image (imageSmoothingQuality=medium)

If you cannot provide a minimal example for reproduce, I will close this soon.


2.0 Road Map

To make managing this project simpler and safer I want to do a few things:

[x] Change build process to webpack.
[x] make dist UMD.
[x] Use es6 transpiled code.
[x] Seperate into modules that are compiled through webpack.
[ ] Use something like eslint to force some styleguides.
[ ] Create Good Test Coverage (drop jest, use karma)
[ ] Drop domLoaded code. Move selector usage responsible to user.

New API will be more along the lines of:
shortcut('mod a', document.querySelector('#input'))

What if we changed bindsTo to then and made it pseudo-Promisified. Any benefits to that? Better naming scheme. But confusion that it's not really a promise.

I'm going to say we should not do the then. it gets confusing when you want to remove a binding.. unthen doesn't make sense... So I think the 2.0 road map is done! I'm going to pre-release it now


improve wording on EN actions.notifications.description

The original sentence feels a bit weird.

Agreed, thanks 👍


update to java-faker 0.8

the 0.8 release supports many more locales, but it also uses different data-files, so some tests had to be changed

Thx for the update


Enhancement: Bump docker 20.10 variants to 20.10.26

Signed-off-by: The Oh Brothers Bot<EMAIL_ADDRESS>

See #114


Submit test coverage info to code climate and codecov

Description
This PR adds a new job to our CircleCI config that runs the Go unit tests and submits the coverage information to CodeClimate and codecov.
I'd like to merge this in a let it run for a little while to see if any of the tools on these services prove to be useful.
Reviewer Notes
The cc-test-reporter program is a little picky about where it expects things to be, and in order to get everything working some commands need to be run from a directory above the main repo. I think this is harmless as it only affects this job. codecov was a lot easier to configure, FWIW.
I haven't gotten into client-side test coverage, but I will look into that next.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@703dbd2). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1705   +/-   ##
=========================================
  Coverage          ?   56.44%
=========================================
  Files             ?      170
  Lines             ?    10106
  Branches          ?        0
=========================================
  Hits              ?     5704
  Misses            ?     3693
  Partials          ?      709

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703dbd2...33460c8. Read the comment docs.


Build failure with a gRPC + Go + Python project

What version of gRPC and what language are you using?

Bazel build with rules_proto_grpc-4.2.0
Golang on the server
Python on the client

What operating system (Linux, Windows,...) and version?

Ubuntu Linux 18.04

What runtime / compiler are you using (e.g. python version or version of gcc)

Go 1.19.1
Bazel 5.3.0

What did you do?
I followed the instructions at https://rules-proto-grpc.com/en/latest/lang/python.html#python-grpc-library for Python, and similar guidelines for setting up a project with a Bazel build, protocol buffers, gRPC, Go and Python support.
In particular, note the dependency on the Go 1.19.1 toolchain. This bug still reproduces with any other version number, including the one in bazel/grpc_extra_deps.bzl#L56
Consider the following Bazel WORKSPACE file:
workspace(name = "project-foo")

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

# https://github.com/bazelbuild/rules_proto

http_archive(
    name = "rules_proto",
    sha256 = "e017528fd1c91c5a33f15493e3a398181a9e821a804eb7ff5acdd1d2d6c2b18d",
    strip_prefix = "rules_proto-4.0.0-3.20.0",
    urls = [
        "https://github.com/bazelbuild/rules_proto/archive/refs/tags/4.0.0-3.20.0.tar.gz",
    ],
)

load("@rules_proto//proto:repositories.bzl", "rules_proto_dependencies", "rules_proto_toolchains")

rules_proto_dependencies()

rules_proto_toolchains()

# https://github.com/bazelbuild/rules_go

http_archive(
    name = "io_bazel_rules_go",
    sha256 = "16e9fca53ed6bd4ff4ad76facc9b7b651a89db1689a2877d6fd7b82aa824e366",
    urls = [
        "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.34.0/rules_go-v0.34.0.zip",
        "https://github.com/bazelbuild/rules_go/releases/download/v0.34.0/rules_go-v0.34.0.zip",
    ],
)

load("@io_bazel_rules_go//go:deps.bzl", "go_download_sdk", "go_register_toolchains", "go_rules_dependencies")

go_download_sdk(
    name = "go_sdk",
    version = "1.19.1",
)

go_rules_dependencies()

go_register_toolchains()

# https://github.com/rules-proto-grpc/rules_proto_grpc

http_archive(
    name = "rules_proto_grpc",
    sha256 = "bbe4db93499f5c9414926e46f9e35016999a4e9f6e3522482d3760dc61011070",
    strip_prefix = "rules_proto_grpc-4.2.0",
    urls = ["https://github.com/rules-proto-grpc/rules_proto_grpc/archive/4.2.0.tar.gz"],
)

# https://rules-proto-grpc.com/en/latest/#installation

load("@rules_proto_grpc//:repositories.bzl", "bazel_gazelle", "rules_proto_grpc_repos", "rules_proto_grpc_toolchains")

rules_proto_grpc_toolchains()

rules_proto_grpc_repos()

# https://rules-proto-grpc.com/en/latest/lang/go.html

bazel_gazelle()

load("@rules_proto_grpc//go:repositories.bzl", rules_proto_grpc_go_repos = "go_repos")

rules_proto_grpc_go_repos()

load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies")

gazelle_dependencies()

# https://rules-proto-grpc.com/en/latest/lang/python.html#python-grpc-library

load("@rules_proto_grpc//python:repositories.bzl", rules_proto_grpc_python_repos = "python_repos")

rules_proto_grpc_python_repos()

load("@com_github_grpc_grpc//bazel:grpc_deps.bzl", rules_proto_grpc_python_deps = "grpc_deps")

rules_proto_grpc_python_deps()

load("@com_github_grpc_grpc//bazel:grpc_extra_deps.bzl", rules_proto_grpc_python_extra_deps = "grpc_extra_deps")

rules_proto_grpc_python_extra_deps()

Add a BUILD file with the following contents:
load("@rules_proto//proto:defs.bzl", "proto_library")
load("@rules_proto_grpc//go:defs.bzl", "go_grpc_library")
load("@rules_proto_grpc//python:defs.bzl", "python_grpc_library")

proto_library(
    name = "project_foo_proto",
    srcs = ["project_foo.proto"],
    visibility = ["//visibility:public"],
)

go_grpc_library(
    name = "project_foo_go_proto",
    importpath = "github.com/company/project-foo",
    protos = [":project_foo_proto"],
    visibility = ["//visibility:public"],
)

python_grpc_library(
    name = "project_foo_py_proto",
    protos = [":project_foo_proto"],
    visibility = ["//visibility:public"],
)

Create a minimal project_foo.proto with a request message, a response message and a service definition with one method using the two messages.
Run bazel build :all (or bazelisk build :all).
What did you expect to see?
Successful build.
What did you see instead?
ERROR: Traceback (most recent call last):
        File "/home/ovidiu.platon/src/admission-control/WORKSPACE", line 85, column 35, in <toplevel>
                rules_proto_grpc_python_extra_deps()
        File "/home/ovidiu.platon/.cache/bazel/_bazel_ovidiu.platon/499be9f2b6984f13f37570e2aac3fba9/external/com_github_grpc_grpc/bazel/grpc_extra_deps.bzl", line 56, column 27, in grpc_extra_deps
                go_register_toolchains(version = "1.18")
        File "/home/ovidiu.platon/.cache/bazel/_bazel_ovidiu.platon/499be9f2b6984f13f37570e2aac3fba9/external/io_bazel_rules_go/go/private/sdk.bzl", line 419, column 13, in go_register_toolchains
                fail("go_register_toolchains: version set after go sdk rule declared ({})".format(", ".join([r["name"] for r in sdk_rules])))
Error in fail: go_register_toolchains: version set after go sdk rule declared (go_sdk)

Anything else we should know about your project / environment?
The error happens regardless of whether the WORKSPACE file uses go_sdk or go_register_toolchains. The grpc_extra_deps function must not provide its Go toolchain version number. Not only it removes control from the WORKSPACE writer, but it conflicts with any other badly written helpers (it fails the "what if everyone else did this" test). It is order dependent and introduces fragility.

I also filed https://github.com/bazelbuild/rules_go/issues/3292 with bazelbuild/rules_go. I think both projects have their part in this situation - the Go Bazel rules should figure out a different strategy for toolchain version unification (or for multiple toolchain versions, whatever is more appropriate), and other Bazel rules that depend on Go internally should not choose on the WORKSPACE user's behalf.


Implement predicate pushdown

Right now most of the tables in the github connector don't allow to be read directly. Instead, there's a set of functions that use the same return types, but they take arguments to limit the data size to something sane.
If the connector would allow to push down predicates, it could use some of them in the same way as those functions use their arguments. In other cases, it could keep throwing the same exception, with a more detailed message, saying which columns can be filtered on.
Example, instead of:
SELECT * FROM unnest(issues(:token, :org, :repo, 1)) a

allow:
SELECT * FROM issues WHERE owner_name = :owner AND repo_name = :repo AND status = 'open'

This also requires adding owner_name and repo_name columns (denormalize the relation). There's no page number since it would fetch all pages for every query.
A query like:
SELECT * FROM issues

would throw an exception, mentioning that conditions on owner_name and repo_name are required.

Done in #29


ATA create transaction race

Problem
Dapps that submit frequent consecutive transactions referencing the same ATA race when the account needs to be created.  This leads to subsequent transactions failing
Proposed Solution
Allow ATA create to succeed without effects if the account already exists in the expected state, perhaps via an explicit instruction

We suffered from this using a reward distribution back-end (for community stuff) and ended up implementing that on-chain:
https://github.com/mercurial-finance/create-ata-if-missing-program


Create Open PR

Please merge this PR
PA not responding and issue was fixed.
https://github.com/Rakesh9100/Beautiify/pull/1374
@sanjay-kv

PR is getting reviewed one by one and merged, remove the point label from here
@sanjay-kv


Request: local Half implementation in Compressonator

I'm very excited to discover Compressonator, and am eager to integrate it into several of my own projects. I was curious if you would consider a change that would make the core Compressonator library a bit more self-contained, to simplify integration with projects that don't require the CLI or GUI tools (or their dependencies).
As far as I can tell, the only actual build dependency in the CompressonatorLib project is the Half library at Common\Lib\Ext\OpenEXR\ilmbase-2.2.0\Half. To get this ~1MB of code, users may naively clone over 1GB of submodules (OpenEXR alone is 125MB). Would it be possible to reimplement the necessary functionality "in-tree" in Compressonator, to break that dependency on OpenEXR and allow building the library without any external dependencies?

That's great to hear, thanks!


session-desktop: 1.11.3 -> 1.11.4

Description of changes
https://github.com/oxen-io/session-desktop/releases/tag/v1.11.4

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

I'm getting hash mismatched version
         specified: sha256-XORbHO5HIm7eJhJuw22AopiZNdieC4Nd3Mm4/6wW6UQ=
            got:    sha256-fSa113BYpTZ4jvxroQsoslAkWfQr4/ROkgVOFyiVsKQ=

closes #261907


Animation depending on state

Is it possible to have different animations depending on the state (tabs / accordion).
It seems to make sense to have fade on tabs view and slide on accordion view
I can put through a PR for this if required?

Was also wanting this, makes sense to have slide animation on accordion and fade or no animation on tabs.

I have no plans on adding this myself, but a PR is always welcome

+1 to this, It make sense to activate slide animation for accordion, but not for tabs (strange). It would be great to be able to define different animation depending on state.

This mostly works for me. Animation works if you load no mobile but not if you load and desktop and resize down. Not sure why.
LINE 438
    if(_this.getState() === 'accordion') {
      switch(method) {
          case 'slide':
              effect = (state === 'open') ? 'slideDown' : 'slideUp';
              break;
          case 'fade':
              effect = (state === 'open') ? 'fadeIn' : 'fadeOut';
              break;
          default:
              effect = (state === 'open') ? 'show' : 'hide';
              // When default is used, set the duration to 0
              _this.options.duration = 0;
              break;
      }
    } else {
      effect = (state === 'open') ? 'show' : 'hide';
      // When default is used, set the duration to 0
      _this.options.duration = 0;
    }

Good job!
Then I implemented when click the tabs scroll to Tabs Top with Callbacks.
$('#tabs').responsiveTabs({ 	startCollapsed: 'accordion', 	scrollToAccordion: true, 	animation: 'slide', 	duration: 300, 	click: function(e, tab) { 		$('html, body').animate({ 			scrollTop: $(this).offset().top 		}, 300) 	}, });

Good job!
Then I implemented when click the tabs scroll to Tabs Top with Callbacks.
$('#detail-tabs').responsiveTabs({
	startCollapsed: 'accordion',
	scrollToAccordion: true,
	animation: 'slide',
	duration: 300,
	click: function(e, tab) {
		$('html, body').animate({
			scrollTop: $(this).offset().top
		}, 300)
	},
});


chore: sync prod->main

Syncing Prod->Main.

I'm gonna merge this...  The build error appears to have happened by coincidence and is potentially related to a new version of R?  Slack discussion here: https://delphi-org.slack.com/archives/C04RGRB3K19/p1713977660847249


NgMap.getMap()

Hi, I'm trying to use NgMap.getMap().then(function(map) {}); but I it end up breaking my controller, and I get this message in the console: "Cannot read property 'getMap' of undefined". In the html page I have a simple ng-map. Am I doing something wrong, or is there a problem with the version ?
I'm using Yeoman with the Mean.JS generator.
Thanks !

did you inject NgMap into your controller?

Yes I did
`(function () {
'use strict';
// Spots controller
angular
.module('spots')
.controller('SpotsController', SpotsController);
SpotsController.$inject = ['$scope', '$state', '$timeout', '$location', 'Authentication', 'spotResolve', 'Upload', 'NgMap'];
function SpotsController ($scope, $state, $timeout, $location, Authentication, spot, geolocation, Upload, NgMap, Spot) {
var vm = this;

vm.authentication = Authentication;
vm.spot = spot;
vm.error = null;
vm.form = {};
vm.remove = remove;
vm.save = save;
vm.zoom = 3;

NgMap.getMap().then(function(map) {
  vm.map = map;
});
`

Nevermind I just find out that it was because of the order of the injection....


Adding definition.json files

Fixes #3

JSON files are added

[x] JSON files are added

Could you squash all the commits together and use git push --force to update this pull request? I will then merge it.

Squashed all commits into single one.


RUMM-1611: Track clicks in Jetpack Compose

What does this PR do?
This change add a small utility function which may simplify click tracking with Jetpack Compose.
Unfortunately, it seems there is no good way to do auto-instrumentation by using public Compose API, so this change is about the manual instrumentation: user has to use it explicitly on the element.
It is worth mentioning that there is very small added value, because it can be just written as:
Button(onClick = {
  GloralRum.get().addUserAction(...)
  ...rest of onClick logic...
})

But because we proxying original () -> Unit type with the help of class with fun operator invoke() overload and we have to capture the variables, to avoid new objects creation during the re-composition event, we have to add a bunch of remember calls.
Another pitfall is RumActionType usage. If we use TAP and this action had no side-effects, it will be dropped. This is probably fine in the auto-instrumentation approach (because we can indeed have false-positive events which shouldn't be sent and not meaningful), but in case of manual instrumentation I guess user would expect this action to be sent. If we use CUSTOM type, then action is sent (we allow CUSTOM types to fly even if there is no side-effects), but then in the dashboard it would be just %action_name% instead of tap on %target_name% as in case of TAP usage.
Maybe we can leverage attributes parameter with some internal attribute to allow TAP action to be sent even if there is no side-effects in case of manual instrumentation?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #757 (5326677) into master (326d1b2) will decrease coverage by 0.23%.
The diff coverage is 73.33%.

@@             Coverage Diff              @@
##             master     #757      +/-   ##
============================================
- Coverage     90.10%   89.87%   -0.23%
+ Complexity     1773     1770       -3
============================================
  Files           193      194       +1
  Lines          5989     6004      +15
  Branches        690      690
============================================
  Hits           5396     5396
- Misses          374      388      +14
- Partials        219      220       +1

Impacted Files
Coverage Δ

...n/kotlin/com/datadog/android/compose/Navigation.kt
62.50% <ø> (ø)

...com/datadog/android/compose/InteractionTracking.kt
73.33% <73.33%> (ø)

...m/internal/domain/scope/ExternalResourceTimings.kt
73.53% <0.00%> (-5.88%)
:arrow_down:

...android/rum/internal/ndk/DatadogNdkCrashHandler.kt
75.62% <0.00%> (-5.62%)
:arrow_down:

...nal/tracking/AndroidXFragmentLifecycleCallbacks.kt
91.11% <0.00%> (-4.44%)
:arrow_down:

...g/internal/domain/event/DdSpanToSpanEventMapper.kt
90.38% <0.00%> (-3.85%)
:arrow_down:

.../android/rum/internal/monitor/DatadogRumMonitor.kt
91.73% <0.00%> (-3.01%)
:arrow_down:

...oid/src/main/kotlin/com/datadog/android/Datadog.kt
77.27% <0.00%> (ø)

...atadog/android/core/configuration/Configuration.kt
97.79% <0.00%> (ø)

...l/net/info/BroadcastReceiverNetworkInfoProvider.kt
78.35% <0.00%> (ø)

... and 5 more


Adding controller.value to Text crashes app

Using the code from the appbrewery flash-chat-flutter app, added an animation controller per steps in lesson "F12.5 Custom Animations - Tickers, Animation Controllers, Animation values.mp4".

Here's the setup:
void initState() {
super.initState();
controller = AnimationController(
duration: Duration(seconds: 1),
vsync: this,
upperBound: 100,
);
controller.forward();
controller.addListener(() {
setState(() {});
print(controller.value);
});
}
And here's the code that results in the crash.
            Text(
              '${controller.value.toInt()}%',
              style: TextStyle(
                fontSize: 45.0,
                fontWeight: FontWeight.w900,
              ),

The code appears to exactly match what's in the lesson, and there's no problem there.
Logs

Performing hot restart...
Syncing files to device Pixel 2 XL...
Restarted application in 4,981ms.
I/flutter ( 9966): 0.0
I/flutter ( 9966): 0.0
I/flutter ( 9966): 3.3333000000000004
I/flutter ( 9966): ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
I/flutter ( 9966): The following assertion was thrown building WelcomeScreen(dirty, state:
I/flutter ( 9966): _WelcomeScreenState#8022f(ticker active)):
I/flutter ( 9966): 'dart:ui/painting.dart': Failed assertion: line 187: '<optimized out>': is not true.
I/flutter ( 9966):
I/flutter ( 9966): Either the assertion indicates an error in the framework itself, or we should provide substantially
I/flutter ( 9966): more information in this error message to help you determine and fix the underlying cause.
I/flutter ( 9966): In either case, please report this assertion by filing a bug on GitHub:
I/flutter ( 9966):   https://github.com/flutter/flutter/issues/new?template=BUG.md
I/flutter ( 9966):
I/flutter ( 9966): When the exception was thrown, this was the stack:
I/flutter ( 9966): #2      Color.withOpacity (dart:ui/painting.dart:187:12)
I/flutter ( 9966): #3      _WelcomeScreenState.build (package:flash_chat/screens/welcome_screen.dart:32:35)
I/flutter ( 9966): #4      StatefulElement.build (package:flutter/src/widgets/framework.dart:3825:27)
I/flutter ( 9966): #5      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3739:15)
I/flutter ( 9966): #6      Element.rebuild (package:flutter/src/widgets/framework.dart:3565:5)
I/flutter ( 9966): #7      BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2278:33)
I/flutter ( 9966): #8      _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding&WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:700:20)
I/flutter ( 9966): #9      _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:286:5)
I/flutter ( 9966): #10     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1012:15)
I/flutter ( 9966): #11     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:952:9)
I/flutter ( 9966): #12     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:864:5)
I/flutter ( 9966): #16     _invoke (dart:ui/hooks.dart:219:10)
I/flutter ( 9966): #17     _drawFrame (dart:ui/hooks.dart:178:3)
I/flutter ( 9966): (elided 5 frames from class _AssertionError and package dart:async)
I/flutter ( 9966): ════════════════════════════════════════════════════════════════════════════════════════════════════
I/flutter ( 9966): 11.6249
I/flutter ( 9966): Another exception was thrown: 'dart:ui/painting.dart': Failed assertion: line 187: '<optimized out>': is not true.
I/flutter ( 9966): 13.286100000000001
(repeats many times)

Also, on the screen of the device, it shows:

'dart:ui/painting.dart': Failed assertion: line 187: '<optimized out>': is not true.

Analyzing flash-chat-flutter...
No issues found! (ran in 7.5s)

flutter

[√] Flutter (Channel stable, v1.5.4-hotfix.2, on Microsoft Windows [Version 6.1.7601], locale en-US)
    • Flutter version 1.5.4-hotfix.2 at F:\src\Flutter\flutter
    • Framework revision 7a4c33425d (9 weeks ago), 2019-04-29 11:05:24 -0700
    • Engine revision 52c7a1e849
    • Dart version 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)

Found the problem.  I missed the part in the lesson where, after changing the upperBound to 100, the red.withOpacity(controller.value) is changed back to white.  So the problem appears to be that if you give the opacity as > 1, the app crashes with no useful indication of the source of the problem.  Shouldn't the method check for a value within bounds and flag an error message that notes an out-of-bounds condition?  Or force any value >1 to 1?  While an erroneous value is definitely the cause of the problem, erroneous values happen, and can also be security issues.  So not checking bounds is a problem.

hi @skaterdude
I'm glad that you found a solution.
I think it's safe to close this issue,
if you disagree please write in the comments and I will reopen it.


Add Docker Hub service account for meshery-cpx repo pushes

Description
Add the service account credentials for pushing meshery-cpx images to its respective Docker Hub repo.

@girishranganathan it looks like these have been added. Close when confirmed.

@girishranganathan please confirm when you have a moment.

this is all done


chore(dependencies): move underscore to dev dependencies

I'm not sure this is exactly what you want (not sure what step underscore is being used for), but it seems needless to bring in underscore as a dependency, at least in node. Looks like its only being used in the browser tests, and at that could be easily replaced. Figured I'd start the conversation with a PR :smile:

As you said, we could probably just remove underscore altogether but this seems like a step in the right direction. Thanks!


Transformer model may be ignoring general entity types

Amazing project, thank you so much for presidio and all of the work here.
I am noticing with a few different Hugging Face transformer models, that some of the listed entities associated with the engine, are not being picked up even with mapping.
I am using the following on macOS:
presidio_analyzer==2.2.355
presidio_anonymizer==2.2.355

For example, here is my code to set up the engine:
# Transformer model config
tf_model_config = [
    {"lang_code": "en",
     "model_name": {
         "spacy": "en_core_web_sm",
         "transformers": "StanfordAIMI/stanford-deidentifier-base"
    }
}]

# Entity mappings
mapping = dict(
    PER="PERSON",
    LOC="LOCATION",
    ORG="ORGANIZATION",
    AGE="AGE",
    ID="ID",
    EMAIL="EMAIL",
    DATE="DATE_TIME",
    PHONE="PHONE_NUMBER",
    PERSON="PERSON",
    LOCATION="LOCATION",
    GPE="LOCATION",
    ORGANIZATION="ORGANIZATION",
    NORP="NRP",
    PATIENT="PERSON",
    STAFF="PERSON",
    HOSP="ORGANIZATION",
    PATORG="ORGANIZATION",
    TIME="DATE_TIME",
    HCW="PERSON",
    HOSPITAL="ORGANIZATION",
    FACILITY="LOCATION"
)

tf_model_configuration = NerModelConfiguration(
    model_to_presidio_entity_mapping=mapping,
    alignment_mode="expand", # "strict", "contract", "expand"
    aggregation_strategy="max") # "simple", "first", "average", "max"

tf_engine = TransformersNlpEngine(
    models=tf_model_config,
    ner_model_configuration=tf_model_configuration)

# Transformer-based analyzer
analyzer_tf = AnalyzerEngine(
    nlp_engine=tf_engine,
    supported_languages=["en"]
)

# Default anonymizer
anonymizer_default = AnonymizerEngine()

When I list the entities for the transformer engine with this code:
print(f'Entities for transformer engine:  {analyzer_tf.nlp_engine.get_supported_entities()}')

I get Entities for transformer engine:  ['DATE_TIME', 'NRP', 'EMAIL', 'PHONE_NUMBER', 'ORGANIZATION', 'AGE', 'LOCATION', 'PERSON', 'ID'] Selection deleted
Then, I do the following to call the engine/analyzer+anonymizer:
for text in text_gens[:5]:

    analyzer_tf_results = analyzer_tf.analyze(text=text, language="en")
    anonymized_tf_results = anonymizer_default.anonymize(
        text=text, analyzer_results=analyzer_tf_results
    )

    print(f"Transformer anonymized text    : {anonymized_tf_results.text}\n")

And even though I have many instances of a typical US address, I never get LOCATION as one of my entities.  For example (btw, this is completely made up / synthetic text and does not reflect any real people or businesses!):
One example output from above (including the default spacy as well since I did that, but did not show setup above, just adding for completion):
Some synthetic/made-up data:
Original text: Jasmine Rivers, with social security number 987-65-4321, can be reached at<PHONE_NUMBER>. Her driver's license number is<PHONE_NUMBER>. She lives at 1234 Maple Street, Anytown, USA. Jasmine works for Stellar Solutions, located at 5678 Oak Avenue, Suite 100, with 50 employees. The organization's financial health is strong, with a stock price of $100 per share and a positive forecast for the upcoming year.
SpaCy anonymized text (default, including in case helpful here): <PERSON>, with social security number <US_ITIN>, can be reached at <PHONE_NUMBER>. Her driver's license number is <PHONE_NUMBER>. She lives at <LOCATION>, <LOCATION>, <LOCATION>. <PERSON> works for Stellar Solutions, located at <LOCATION>, Suite 100, with 50 employees. The organization's financial health is strong, with a stock price of $100 per share and a positive forecast for <DATE_TIME>.
Transformer anonymized text    : <PERSON>, with social security number <ID>, can be reached at <PHONE_NUMBER>. Her driver's license number is <ID>. She lives at 1234 Maple Street, Anytown, USA. <PERSON> works for Stellar Solutions, located at 5678 Oak Avenue, Suite 100, with 50 employees. The organization's financial health is strong, with a stock price of $100 per share and a positive forecast for the upcoming year.

Any thoughts on how to debug this?  Thanks again!!

Hi @michhar, when running the transformer model directly, I also never get locations. It does output HOSPITAL which is mapped to ORGANIZATION in the mapping, and VENDOR which isn't mapped. The issue though, is that ORGANIZATION is listed as an entity to ignore (see here and here). The reason for this is the high number of false positives for this entity with the default spaCy model. Having said that, I can understand why one would miss that. If you have any suggestions on how to improve this, please reach out!
So to get this working, I updated the labels_to_ignore param, and changed the mapping to include hospital-> location and vendor->organization
# Transformer model config
tf_model_config = [
    {"lang_code": "en",
     "model_name": {
         "spacy": "en_core_web_sm",
         "transformers": "StanfordAIMI/stanford-deidentifier-base"
    }
}]

# Entity mappings
mapping = dict(
    PER="PERSON",
    LOC="LOCATION",
    ORG="ORGANIZATION",
    AGE="AGE",
    ID="ID",
    EMAIL="EMAIL",
    DATE="DATE_TIME",
    PHONE="PHONE_NUMBER",
    PERSON="PERSON",
    LOCATION="LOCATION",
    GPE="LOCATION",
    ORGANIZATION="ORGANIZATION",
    NORP="NRP",
    PATIENT="PERSON",
    STAFF="PERSON",
    HOSP="LOCATION",
    PATORG="ORGANIZATION",
    TIME="DATE_TIME",
    HCW="PERSON",
    HOSPITAL="LOCATION",
    FACILITY="LOCATION",
    VENDOR="ORGANIZATION",
)

tf_model_configuration = NerModelConfiguration(
    model_to_presidio_entity_mapping=mapping,
    alignment_mode="expand", # "strict", "contract", "expand"
    aggregation_strategy="max", # "simple", "first", "average", "max"
    labels_to_ignore = ["O"])

tf_engine = TransformersNlpEngine(
    models=tf_model_config,
    ner_model_configuration=tf_model_configuration)

# Transformer-based analyzer
analyzer_tf = AnalyzerEngine(
    nlp_engine=tf_engine,
    supported_languages=["en"]
)

text = "Jasmine Rivers, with social security number 987-65-4321, can be reached at<PHONE_NUMBER>. Her driver's license number is<PHONE_NUMBER>. She lives at 1234 Maple Street, Anytown, USA. Jasmine works for Stellar Solutions, located at 5678 Oak Avenue, Suite 100, with 50 employees. The organization's financial health is strong, with a stock price of $100 per share and a positive forecast for the upcoming year."
res = analyzer_tf.analyze(text, language="en")

from presidio_anonymizer import AnonymizerEngine

anon = AnonymizerEngine()
anon.anonymize(text, res)

This returns:
text: <PERSON>, with social security number <ID>, can be reached at <PHONE_NUMBER>. Her driver's license number is <ID>. She lives at <LOCATION>. <PERSON> works for <ORGANIZATION>, located at <LOCATION>, with 50 employees. The organization's financial health is strong, with a stock price of $100 per share and a positive forecast for the upcoming year.
items:
[
    {'start': 186, 'end': 196, 'entity_type': 'LOCATION', 'text': '<LOCATION>', 'operator': 'replace'},
    {'start': 159, 'end': 173, 'entity_type': 'ORGANIZATION', 'text': '<ORGANIZATION>', 'operator': 'replace'},
    {'start': 140, 'end': 148, 'entity_type': 'PERSON', 'text': '<PERSON>', 'operator': 'replace'},
    {'start': 128, 'end': 138, 'entity_type': 'LOCATION', 'text': '<LOCATION>', 'operator': 'replace'},
    {'start': 109, 'end': 113, 'entity_type': 'ID', 'text': '<ID>', 'operator': 'replace'},
    {'start': 62, 'end': 76, 'entity_type': 'PHONE_NUMBER', 'text': '<PHONE_NUMBER>', 'operator': 'replace'},
    {'start': 38, 'end': 42, 'entity_type': 'ID', 'text': '<ID>', 'operator': 'replace'},
    {'start': 0, 'end': 8, 'entity_type': 'PERSON', 'text': '<PERSON>', 'operator': 'replace'}
]

It could also be somewhat related to this change which wasn't released yet: https://github.com/microsoft/presidio/pull/1454

@omri374 Thank you for your quick response!  How do I go about getting the info I need to make the mapping better?  Is there a good way to list out all entities supported by a model so I can make sure I map them correctly?
For improving the approach (avoiding the FPs with the SpaCy model pipeline), could I exclude SpaCy model altogether in my transformer-based analyzer?

The spacy part of the pipeline is not used for NER, but for all the other NLP tasks (tokenization, lemmatization etc.) We use spacy-huggingface-pipelines to integrate a huggingface NER model instead of the spaCy NER model.
Since presidio comes with spaCy's en_core_web_lg as a default option, and this model has low accuracy rates for ORG, the default setting is to ignore it. If a user wishes to use a different model, there is also a need to change this setting. As said previously, this isn't a good developer experience as it's kind of buried in the code. If you have any suggestions on how to improve this, I'd be happy to discuss!

More on this can be found here: https://microsoft.github.io/presidio/analyzer/nlp_engines/transformers/

see also #1472

We can further consider to add a scan the model's config, to extract the id2label and show a warning in case there's a class that's not mapped and not ignored, or allow the user to just use the classes as is (create an automated mapping e.g. {"PER": "PER", "LOC":"LOC"} etc.)


Bug 1548311 - Return success on depro extcred miss

Forward port of #790 to master

@jmrodri updated to use client.IsKeyNotFound.


Tentative date to publish the testing code?

Hi, thanks for the great PyTorch implementation. I was wondering how long it might take for you to make the testing code public? Thanks!

You may find helpful to refer to: https://github.com/OpenBanboo/translane/tree/main/scnn_sad_remaster

Thanks.


Rebase from old upstream 520cd9f to new upstream 1b206ee, incorporate cpplint fixes

Supersedes #6

[ ] Requires resolution of https://github.com/RobotLocomotion/drake/issues/8638 before proceeding for review
[x] Requires #8

\cc @m-chaturvedi I changes some of the rebase merge-conflict resolutions to try and stay closer to the upstream gh-pages - just a few paragraphs different than your rebase.

This change is

@EricCousineau-TRI Could we start by first repairing the history on master, without doing an intake of new styleguide stuff?  Maybe first setup up a no_prune branch, then prepare a PR with "Merge manually by overwriting" and have myself and/or other looks at that.  Then we can follow-up with the regular (new) review process for the upstream bump, separately.

Superseded by #9


Code Quality

Please remove exit action and handle the response with an internal exception handler on checkStatus method

Done !
removed exit action and add internal exception handler for checkStatus method


ffmpeg-full: enable libdrm

Motivation for this change
Enable libdrm in ffmpeg-full and match the ffmpeg package which already has it (#49389).
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 131260 at f1100e94 run on x86_64-linux 1

1 package failed to build:

python38Packages.rl-coach

6 packages skipped due to time constraints:

libsForQt5.kdenlive (libsForQt515.kdenlive ,plasma5Packages.kdenlive)
libsForQt512.kdenlive
libsForQt512.soundkonverter
libsForQt514.kdenlive
python39Packages.baselines
python39Packages.rl-coach

32 packages built successfully:

MIDIVisualizer
arcan.arcan
arcan.arcan-wrapped
arcan.durden-wrapped
arcan.everyone-wrapped
ffmpeg-full (arcan.ffmpeg)
arcan.pipeworld-wrapped
arcan.prio-wrapped
arcan.xarcan
handbrake
imagination
soundkonverter (libsForQt5.soundkonverter)
libsForQt514.soundkonverter
liquidsoap
manim
olive-editor
printrun
python38Packages.baselines
python38Packages.gym
python38Packages.moderngl-window
python38Packages.pydub
python38Packages.pyglet
python38Packages.pytmx
python38Packages.roboschool
python39Packages.gym
python39Packages.moderngl-window
python39Packages.pydub
python39Packages.pyglet
python39Packages.pytmx
python39Packages.roboschool
restream
webcamoid

2 suggestions:

error: no-flags-spaces
configureFlags cannot contain spaces, please use configureFlagsArray in Bash.
Near pkgs/development/libraries/ffmpeg-full/default.nix:261:3:
    |
261 |   configureFlags = [
    |   ^

warning: unclear-gpl
gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/development/libraries/ffmpeg-full/default.nix:474:5:
    |
474 |     license = (
    |     ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Looking at the single build failure, it doesn't seem like it was caused by my change. Please let me know if I'm wrong about that though.
ERROR: Could not find a version that satisfies the requirement gym==0.12.5 (from rl-coach)
ERROR: No matching distribution found for gym==0.12.5

rl-coach is marked as broken for me, wouldn't worry about it.
nixpkgs-review reveals no new failures for me, macos 10.15 & nixos x86_64.

Why is this not based on the lite one..


Add top level "prettier" config

This would change the config to be as close to prettier as possible.
I'm slightly concerned by adding this that people would expect it to act exactly like prettier in all edge cases, but I assume people will be reasonable...

I think a docstring comment that specifies it's not intended to be exact, only close, would solve that.
From my understanding it would just be an alias for
    .line_width(80)
    .indent_width(2)
    .next_control_flow_position(NextControlFlowPosition::SameLine)
    .binary_expression_operator_position(OperatorPosition::SameLine)
    .brace_position(BracePosition::SameLine)
    .comment_line_force_space_after_slashes(false)
    .construct_signature_space_after_new_keyword(true)