Question Regarding Opting Out

There were mentions regarding the setting to opt-out to some, if not all, privacy sandbox settings, such as opting out of 3rd party cookie deprecation in Enterprise Chrome. I was wondering if there will be a similar setting for users who do not have Enterprise Chrome. Please direct me to the correct forum if I am asking in the wrong forum.
Thank you!

I have similar question regarding opting out. My web app integrates with Microsoft SharePoint platform and would require the cookie for authentication, when enabling the test-third-party-cookie-phaseout flag, it breaks my app, it can be fixed by adding the necessary domains to the Allowed to use third-party cookies in Chrome settings. I'm not using Enterprise Chrome.
Is the Allowed to use third-party cookies settings will be still working after the 3rd party cookie phase out completed? Does this change affect all browser that were based on Chromium?

Hi @stephensaw — thanks for your question, and apologies for the very late response.

Is the Allowed to use third-party cookies settings will be still working after the 3rd party cookie phase out completed?

Correct: Chrome does not at this time have plans to remove this feature.

Does this change affect all browser that were based on Chromium?

Third-party cookie restrictions in Chrome (as experienced by the 1% Tracking Protection group) are controlled using Chrome Variations. This does not affect other Chromium-based browsers, and it's up to individual browser vendors how they handle third-party cookies.


Fixed comments edge case in C reader code generation

Fix was easy, but I still don't get how to properly test it. I've added repro case to cgen_test, but automatic tests still pass. I tried to feed output of cgen_test to gcc manually, and it doesn't compile until I apply my fix, so case is correct. It seems like automatic tests just don't check that it's actually compilable.

What if the documentation comment has the form?
/************ PRIMARY OBJECTIVE *************/

Regarding you comments to the cgen_test. It should check that it compiles. If it doesn't, something has gone wrong. Perhaps a return code in the transition from earler shell script driven testing towards CMake tests? It's actually important this works.
If one were to create solid comment testing, one would have to generate a very simple schema and match the generated output, similar to json tests, to ensure only doc comments, and all doc comments get through cleanly, using various styles that seem approapriate. I personally did not find this worthwhile doing, but did check things looked ok by manual inspection.

/************ PRIMARY OBJECTIVE *************/
This isn't recognized as doc, so it doesn't reach output.

To clarify, ideally
/************ PRIMARY OBJECTIVE *************/
should't become
/** ********** PRIMARY OBJECTIVE *************/
I'm sure there are other odd cases such as multi-line comments with "***" on each line that are not worthwhile handling, but the single line example is common enough so I suggest at least a test for that, something like
565: (untested)
fprintf(out->fp, "%s/**", indent);
/* Handles case where comment contains '////' or '****' */
if (doc->ident->len > 0 && doc->ident->text[0] != '*') {
    fprintf(out-fp, " ");
}

I don't recall the details for when doc is generated, and I trust you to do the sensible thing. The above was written before I read your answer.

It should check that it compiles. If it doesn't, something has gone wrong.

Double checked this, tests pass even with bug present. If it matters I'm on archlinux now, tomorrow I'll be able to check this on ubuntu 14.04 to see if it's system dependant.

It matters a lot. It would be great if you would have a look. This is the first line of defense for the parser and scope handling. I might look awfully messy, but for example, the island is used in different scopes and many odd edge cases are covered here.

I'll check this. It would be very helpful if you actually pointed me at where its output is actually fed to compiler.
As for handling //// and **** comments - your code looks sensible enough, the only problem is that it seems like not every input comment is regarded as doc token, I tried to trace this back to lexer and then stuck in luther internals. Any guidance would be helpful.

As to Lex Luthor, he generates an array of tokens and pointers into the original buffer. Comments have their own type, and I don't recall details, but I believe there are single comment and block comment styles, but other than that buffer content provides clues (e.g. # vs //). The doc pointer might point a little further into the token to skip the comment symbol itself, but I don't recall, it just makes sense. The primary criteria for doc comments is what Wouter writes in the schema doc, and my choice to only accept comments before a type name since anything else would be messy. I'm not sure how blank lines are handled, but multiple comments (block or single) are added to the doc list of the type it is associated with (initially doc lists are stored separately, but are then transferred to the type object, or dropped if some other token arrives - this happens by assigning null to the parsers doc list somewhere at the end of parser.c. But this is only a rough outline from memory, and me reading the parser.c code quickly.

Tried your code and bug is back. After adding some printfs to codegen
        fprintf(stderr, "linenum %ld, ln %ld, first %d, len %ld\n", doc->ident->linenum, ln, first, doc->ident->len );
        fprintf(stderr, "%.*s\n", (int)doc->ident->len, doc->ident->text);

I've got the following output:
...
linenum 9, ln 0, first 1, len 0

linenum 9, ln 9, first 0, len 55
///////////////////////////////////////////////////////
linenum 10, ln 9, first 0, len 0

linenum 10, ln 10, first 0, len 55
///////////////////////////////////////////////////////
...

The cgen test was originally placed here:
https://github.com/dvidelabs/flatcc/blob/master/test/cgen_test/cgen_test.sh
but is now placed here
https://github.com/dvidelabs/flatcc/blob/master/test/cgen_test/CMakeLists.txt
and I think it is obvious why it isn't working as intended.
A dependent build step is needed. I don't recall exactly what happened, this might not be just an oversight though it likely is.
Background: I couldn't get CMake to build dependencies of custom targets, so flatcc didn't build before custom targets that depended on it. This is why all the performance benchmarks are no in CMake (although they are in the experiment meson build on a separate branch).

On the Luthor thing, it could also be that comment token excludes the delimiter but that they are present in the buffer at offset -1 if one need to distinguish types. It seems to be the case from your output.

I couldn't get CMake to build dependencies of custom targets, so flatcc didn't build before custom targets that depended on it.

I also struggled a lot with this problem, but finally got this working through add_dependency. You may look at this quite dirty, but working example.

Luthor emits comments and event control codes, so a single comment may be quite fragmented. The parser interface to luthor is responsible for pushing the events onto the array and does some translation here.
https://github.com/dvidelabs/flatcc/blob/master/external/lex/tokens.h#L365
https://github.com/dvidelabs/flatcc/blob/master/src/compiler/parser.c#L1172-L1185

On the Luthor thing, it could also be that comment token excludes the delimiter but that they are present in the buffer at offset -1 if one need to distinguish types. It seems to be the case from your output.

Well, this happens with all comments in test case. Not sure if this is correct behavior and "first" check should be modified to be actually useful, or something should be done with parser itself.

I also struggled a lot with this problem, but finally got this working through add_dependency. You may look at this quite dirty, but working example.

I looked at all sorts of examples and tried lots of combinations, and eventually I just didn't want to spend more time on it.
In comparison meson dependencies are tight as a drum, especially with flatcc dependency file generation, despite the tool being a bit rough around custom builds. You can update a comment in a second level included schema and it will rebuild the whole project in a few milliseconds.

Well, this happens with all comments in test case. Not sure if this is correct behavior and "first" check should be modified to be actually useful, or something should be done with parser itself.

Don't go overboard in this - I think first is just the head of a collection of comments that weren't interrupted by something else. That something else is likely blank space that is learned by detecting holes in line number sequences. It seemed to work at the time, and likely still does. But if is a headache, just add the space and let it be until one day it annoys you enough to fix proper.

Just to be clear: the luthor comment begin event contains /* or //. This is followed by one or more (possibly empty) comment body tokens followed by a comment end token (on valid parse). Only the comment body is pushed onto the parsers token stack and this is why the lead symbols appear to be missing. But they are guaranteed present at negative offset if needed. Control characters may also be emitted, but mostly for error reporting and symmetry with string handling.
Also, luthor has an option to detect doc comments, i.e. /** style comments. But I don't recall how this works here, only that the is_doc flag is being forwarded from luthor to parser.c and that this does not necessarily directly relate the flatbuffer doc concept, but it might.

Okay, I'm starting to understand, but it's 4 AM, so I need to get some sleep ) Hope to fix this tomorrow.

Updated PR with changes to CMakeList.txt so that generated source is actually compiled during testing. Not ideal but working for me. I'm also going to look more closely into parser later.
UPD. Very strange, CI shows tests failing, I'll try to fix this.

Seems like tests working correctly with make, but always fail with ninja. Tried to make a quick fix but failed again. Any ideas?

Seems like tests working correctly with make, but always fail with ninja. Tried to make a quick fix but failed again. Any ideas?

Yes, dependencies doesn't work in CMake for custom targets.

Yes, dependencies doesn't work in CMake for custom targets.

Actually, they work when using make build system, but as far as I can see they don't work for anything else (msbuild & ninja)

The problem is also present in MSVC builds:
https://ci.appveyor.com/project/dvidelabs/flatcc/build/win%23292/job/4d2er9xouoq85df3
line 3114
 1/16 Test  #1: cgen_test ........................   Passed    0.02 sec
test 2
      Start  2: test_generated
2: Test command: "C:\Program Files (x86)\MSBuild\14.0\Bin\MSBuild.exe" "test_generated"
2: Test timeout computed to be: 1500
2: Microsoft (R) Build Engine version 14.0.25420.1
2: Copyright (C) Microsoft Corporation. All rights reserved.
2:
2: MSBUILD : error MSB1009: Project file does not exist.
2: Switch: test_generated
 2/16 Test  #2: test_generated ...................***Failed    0.08 sec
test 3
      Start  3: monster_test

Actually, they work when using make build system, but as far as I can see they don't work for anything else (msbuild & ninja)

No necessarily, it might also fail with concurrent make builds.

No necessarily, it might also fail with concurrent make builds.

Never seen this. And we are using concurrent make builds heavily on my primary job. I've made a quick hack so that test_generated is run only for make build system. Not good, but better than nothing.

Just add a comment along the lines:
Compilation of the generated code tests many import edge cases in the parser and code generator but due to CMake limitations, custom target dependencies only work for Make build targets.

BTW: upgrading CMake won't work because Ubuntu distributions don't have very recent CMake.

Just add a comment along the lines:

Done

Thanks, should we close it here, or do you wish to explore further?

I'm going to explore this further, but I'd prefer not to block this fix, since this bug was quite annoying. What about closing this and opening new low priority issue "Improve comments formatting"?

Or just close the issue, and then you can later create a PR if you feel like it.


Android project-wide requests headers substitution/rewritten by Giphy

Hello,
@giphy/react-native-sdk changes the headers and makes it impossible to request images with headers. The following code snippet
import React, {useEffect} from 'react';

import {Text, Image} from 'react-native';

import {GiphySDK} from '@giphy/react-native-sdk';

GiphySDK.configure({apiKey: '*******************'});

const App = () => {
  useEffect(() => {
    Image.getSize('https://image2.requestcatcher.com/test', () => {});
  }, []);

  return <Text>Test</Text>;
};

export default App;

Makes request with the following headers
GET /test HTTP/1.1
Host: image2.requestcatcher.com
Accept-Encoding: gzip,br
Cache-Control: no-store
Connection: Keep-Alive
User-Agent: okhttp/4.9.1
X-Giphy-Sdk-Name: CoreSDK,UISDK,RNSDK
X-Giphy-Sdk-Platform: Android
X-Giphy-Sdk-Version: 3.1.12,2.3.0,1.0
X-Giphy-Ui-Sdk-Is-Extension: false

So it's impossible to use Image.getSizeWithHeaders or FastImage with headers.
React native: 0.66.5
@giphy/react-native-sdk: 2.1.1
Android: 11

Hi @topheroes, thanks for reaching out!
We have found the root of the issue. This is because both RN and GIPHY SDK use Fresco with custom configs under the hood. But because the GIPHY SDK initializes after RN, we override the HTTP client in Fresco, which was installed by RN before.
We are exploring possible solutions and don't have more information now. We will let you know when there are more details.

Hi, @pshoniuk
Any updates? Can you suggest any temporary fix?

Hi @topheroes
Unfortunately, it isn't easy to make some temporary fix. But we plan to release a new version with a fix in the next two weeks.

Hi @topheroes
We have released a fix in v2.1.2. Please check it when you get a chance. If the problem still occurs, please reopen this issue or create a new one.


openfga: 1.6.2 -> 1.8.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/openfga/openfga/releases.
meta.description for openfga is: High performance and flexible authorization/permission engine built for developers and inspired by Google Zanzibar
meta.homepage for openfga is: https://openfga.dev/
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.8.0 with grep in /nix/store/h6n6pz4ld3ri1nrsypjp2l7yj2r7gvkd-openfga-1.8.0
found 1.8.0 in filename of file in /nix/store/h6n6pz4ld3ri1nrsypjp2l7yj2r7gvkd-openfga-1.8.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

openfga

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/h6n6pz4ld3ri1nrsypjp2l7yj2r7gvkd-openfga-1.8.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A openfga https://github.com/r-ryantm/nixpkgs/archive/efb38a84aefbb92c05146681842c44e9dea31313.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/efb38a84aefbb92c05146681842c44e9dea31313#openfga

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/h6n6pz4ld3ri1nrsypjp2l7yj2r7gvkd-openfga-1.8.0
ls -la /nix/store/h6n6pz4ld3ri1nrsypjp2l7yj2r7gvkd-openfga-1.8.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

openfga

Maintainer pings
cc @jlesquembre for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


autocompletion not working?

Hello!!
First of all, thank you very much for this tool, it's just awesome. I tried to install the auto-completion package (on Ubuntu) and it works perfectly autocompleting the command names, but not for the file names. Am I missing any configuration?
Thanks in advance

This can happen if $NOTES_DIRECTORY is not proper. does notes ls work for you? or see if
ls $NOTES_DIRECTORY shows all notes.

@luctus Any updates on this? I'd love to fix it if there is an underlying issue here. Do you get any output from notes ls?

I'm going to close this for now. @luctus (or anybody else) feel free to reopen this with more details if you're still having this issue.

Hi, just installed your tool today and it seems awesome!!!
I thought I had an issue with this, too, but actually I found what is working and what is not:

notes o my_ does not complete, while notes open my_ does.
notes ls my_ does not complete, but that would be very handy.


Merkle Proof computation not CPS

Merkle Proof computation is not written in CPS, is that a problem?

Fixed by #1624


Force updateHostsWindows.bat to be launched as Administrator

:gift:

@crazy-max @StevenBlack
For me (Windows 10 here) BAT file was launched as admin via UAC prompt without any data in window (only blink white space not seen here - sorry).

Yes there is an issue with the args, i will create a new PR to solve this


Communication: Add shortcut to navigate to all messages page

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] I chose a title conforming to the naming conventions for pull requests.

Client

[x] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
[x] I strictly followed the client coding and design guidelines.

Description
This pull request introduces a new keyboard shortcut feature that allows users to quickly navigate to the "All Messages" page.
Steps for Testing

Prerequisites:

1 Instructor / Student / Tutor
1 Course with Communication enabled

Log in to Artemis
Navigate to Communication
Navigate to a Channel
Press cmd + k (or ctrl + k) on windows
Make sure you get navigated to all messages page

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Summary by CodeRabbit

New Features

Implemented keyboard shortcuts for quick search functionality within the course conversations component.

Consistency nitpick: In other places we used @HostListener('document:keydown.control.shift.arrowRight', ['$event']) for such listeners. Do you know if document vs window makes a relevant difference here? And can you maybe also move the expected keys into the listener definition?


[IOTDB-1531] Check tsfile time when recovering

Check tsfile's time when recovering, make sure all tsfile time are less than System.currentTimeMillis(). If the tsfile's time is larger than System.currentTimeMillis(), the recover of corresponding virtual storage group will fail, users cannot read/write this virtual storage group until the time of the tsfile is correct.
Before fixing time：

After fixing time：

Coverage decreased (-0.007%) to 68.217% when pulling bccd936c0066acafde90c0fd9952dde99ff42165 on HeimingZ:IOTDB-1531(check_tsfile_time_when_recovering) into 0b2d0af48e00b6b72c5e4625e3a9613ac1c6204d on apache:master.

I have a little question. why all tsfile time are less than System.currentTimeMillis()?
if tsfile time are better than System.currentTimeMillis(), Does iotdb-server used?
The time of real data may change due to a fault in the collection device (data is later than the current time). In this case, the entire cluster cannot be used.

I have a little question. why all tsfile time are less than System.currentTimeMillis()?
if tsfile time are better than System.currentTimeMillis(), Does iotdb-server used?
The time of real data may change due to a fault in the collection device (data is later than the current time). In this case, the entire cluster cannot be used.

This pr aims to make sure server time zone is correct and all tsfiles' created time is less than system current time. It only compares the created time of tsfile, which is determined by the server, so data from devices won't affect the use of iotdb.


WeaveTagger and the Overlay topology

PTAL! No changes to the Weave /status-json yet, obviously.

1 comment, otherwise LGTM.  Hold off until post v0.3.0?

LGTM.  Pls rebase & squash.


Show previously added options recieved from server when using async options search

Show previously added options when using async options search
I`m using the select for async search options
      v-model="cities"
      mode="tags"
      :searchable="true"
      :options="async (query) => {
        return await fetchCities(query)
      }"
      :minChars="1"
      :resolveOnLoad="true"
      :delay="0"

I set resolveOnLoad="true", but how can I show tags, that asynchronously comes to v-model on form init, in the select field? Is there any way to set something like 'defaultOptions / initialOptions' when I`m "searching" for options and adding them as tags?

You can do that with object prop. The values will have to be objects in this case, but otherwise Multiselect wouldn't know all the information about an item (label + value).


Hide LineEdit placeholder if IME composition string is not empty.

Fixes part one of #34192
The second part of the issue seems to be not directly controlled by the engine. In the IME input mode, keys are handled by OS, and it doesn't send back any events when IME window is closed to the engine.
We can override it, If we assume any that any backspace press that doesn't cause composition string change triggers window close, and cancel composition manually, but I have no idea whether this is correct assumption.

Hi, I think the second part of the issue might not be related to the IME window.
The Japanese IME closes the IME window actively. But I still have to hit backspace twice to delete the last remaining hiragana.

Type "sekai" to get "世界", but don't hit enter, so that it's not committed
Hit backspace, the IME window closes, and the word becomes "せか" (deleting い from せかい, hiragana version of 世界)
Hit backspace, only "せ" is left
Hit backspace, nothing happens
Hit backspace, the "せ" is deleted

Thanks!

Hit backspace, nothing happens
Hit backspace, the "せ" is deleted

Sounds like backspace is deleting the romaji chars and updating the hiragana accordingly, instead of treating hiragana chars as individual units (so sekai -> seka -> sek -> se).


[QA-492]: Script added for testing in dev platform

QA-492
What?
Added a script to conduct load tests in dev-platform
Changes:

Added a script with different load profiles and target volume to call the demo node API in dev-platform-dev env.

Why?
To validate the fixes for generic performance issues (like FE scaling) in dev-platform-dev environment.

Use the existing deploy/scripts/examples/dev-platform.ts for this


SbPagination - wrong event name for next/prev page change in documentation example

Hi,
in the Storybook page for SbPagination component, the code shown for the examples has a wrong name for both events of page change with prev/next links. In the example there are:

v-on:previous-page
v-on:next-page

while the right event names are:

v-on:on-previous-page
v-on:on-next-page

Thank you @kesonno , we will proceed by removing the redundant on prefix so that the event names listeners will be:
v-on:previous-page
v-on:next-page

as currently shown in the doc.
Thanks for pointing this out! 🙌

@lorenaramonda can we close out this issue?

sure we can!


Evaluation code

Hi there, great work! Any update on the promised the evaluation code? Cheers

Great work! I have the same question, any update about the evaluation code? Thanks

Seems like this project has been abandoned :(


fixed styling of author link on category page

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #144
Test URLs:

Before: https://main--sling--aemsites.aem.page/whatson/movies
After: https://144-link-to-authorpage--sling--aemsites.aem.page/whatson/movies

home & food
Test URLs:

Before: https://main--sling--aemsites.aem.page/whatson/entertainment/home-and-food
After: https://144-link-to-authorpage--sling--aemsites.aem.page/whatson/entertainment/home-and-food

Hi Team, i saw previously it was showing some contrast warnign with the older link-color. So i have updated it to a nearby matching color to avoid contrast warning.

I have chosed below color:


Add ability to do math to columns

for example, I should be able to graph "assists + rebounds" or any arbitrary combination like that. Basically, allow the user to alter the SELECT portion of the query, which currently is all generated.

For example, important data such as Assist to Turnover ratio can be easily calculated without the need for ready-made data.


Test CI [Don't merge]

Test CI

Pull Request Test Coverage Report for Build 9965

1 of 11 (9.09%)  changed or added relevant lines in 9 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 58.364%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/AnalyzeTableStatement.java
0
1
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/CacheIndexStatement.java
0
1
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/CallStatement.java
0
1
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/rl/ChangeMasterStatement.java
0
1
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/rl/RLStatement.java
0
1
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDMLVisitor.java
0
1
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java
0
2
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLRLVisitor.java
0
2
0.0%

Totals

Change from base Build 9964:
-0.03%

Covered Lines:
10523

Relevant Lines:
18030

💛  - Coveralls


Only catch Exception subclasses

Do not use "except:" as this is unlikely to always behave as desired!
Fixes:

Catch "Exception"s and let things like SystemExit, KeyboardInterrupt bubble up

@cwild errr.... every exception inherits from Exception.

Not every exception inherits from Exception, you can see the inheritance hierarchy on this page:
https://docs.python.org/2/library/exceptions.html
This is why except: is bad:
https://docs.python.org/2.7/howto/doanddont.html#except
If you try to raise a SIGINT during the try... except:... then it will swallow the resulting KeyboardInterrupt and won't close as expected.

@cwild I see.

👍

:+1:


Adding daily "on this day" using channel pins

This will, once a day, find a pin that was posted on the same date in a previous year*, and repost it in the same channel.

lgtm


to_parallel does not distribute work to all workers

Is this a bug, feature request, or feedback?
This is a bug.
What is the current behavior?
In a cluster of N workers that have a parallel stateless computation, in the logical graph, not all N workers actually receive work to process.
See this branch for a demonstration.
cd examples/python/parallel-classifier
make parallel_classifier_py_test

What is the expected behavior?
In the example above, where each worker's output is the concatenation of the input and the worker's os-level PID, I expect the number of unique PIDs in the result log to be equal to the number of workers in the cluster (if there ever was enough work to reach them via round-robin, of course).
What OS and version of Wallaroo are you using? If you have a stacktrace and/or steps to reproduce the issue, that also helps a lot.
master

Closed by #2524


Split into crates and add Python interface

This PR starts the process of splitting ModelarDB into separate crates to allow components of the system to be used without requiring the entire system and to reduce compilation time. Initially, two new crates have been created: modelardb_common with shared functionality and modelardb_compression with the models.
The crates are stored in a crates folder like rust-analyzer instead of in the root of the repository like InfluxDB IOx. This makes it easy to locate the code, documentation, etc. Also, inspired by all of Apache Arrow DataFusion's crates being prefixed by datafusion-, the crates have been prefixed with modelardb_ to ensure each crates has a unique name for crates.io and to make it clear the crates are connected.
In addition to splitting ModelarDB into separate crates, a Python interface for modelardb_compression has been added. To simply lifetimes the time the GIL is held is currently not optimized. Also I was unable to document the cases were pymodule.add_function() and wrap_function!() return an error as it does not seem to be documented when it will occur.

One extra thing that might be worth doing now that the project is split into crates is adding a new section to the README that introduces the project structure, lists the internal crates and gives a small description for each.
This is not specific to this PR but it might also be needed to mention Clippy in the Development section and add any new utility crates to the Crates section, if necessary.

One extra thing that might be worth doing now that the project is split into crates is adding a new section to the README that introduces the project structure, lists the internal crates and gives a small description for each.
This is not specific to this PR but it might also be needed to mention Clippy in the Development section and add any new utility crates to the Crates section, if necessary.

@CGodiksen and @chrthomsen I have updated the README based on this comment.


[13pt] Off-channel inundation caused by mis-routed flowlines

We've observed some off-channel inundation in FIM v4. Based on Dami's analysis in #811, this may be caused by some branches that are being routed outside of the real channel. Another example is in HUC 11010013 in branch<PHONE_NUMBER>. FYI, I archived the flows in this screenshot here: /data/inundation_review/archived_flow_files/20230218T0211Z_rfc_5day_max_downstream_streamflow.csv.

Connected to #811

This may be unrelated, but I wanted to capture it here.

NWM Feature ID
2845771

Name
Sacramento River

Hydro ID
30930007

Stream Order
7

USGS HUC8
18020104

Reference Time
2023-03-07 18:00:00 UTC

Inherited RFC Forecast(s)
ORFC1 @ 2023-03-07 15:58:00 (action)

Max Status
Action

Max Streamflow (cfs)
73640.96

HAND Stage (ft)
43.34

FIM Version
4_0_13_1

FIM Branch ID
2858000001

Max Rating Curve Stage (ft)
83

Max Rating Curve Streamflow (cfs)
1273585.82

Update Time
2023-03-07 19:17:30 UTC

oid
667

Here's another HUC identified by @derekgiardino to add to you the testbed for this issue: 09020106

Can you add 08020302 to your testbed for this issue? That's the HUC that spurred the new levee algorithm that's still broken due to some mis-routed flows.


[Java] Upgrade adapter/ to Junit 5

Reporter: Andréi Ósipov / @andreoss
PRs and other links:

GitHub Pull Request #14164

Note: This issue was originally created as ARROW-17769. Please see the migration documentation for further details.

@lidavidm @vibhatha In my opinion, we can close this issue due to #41680.

Duplicate of https://github.com/apache/arrow/issues/42030


SVG rendering issue with specific files (upstream ThorVG bug)

Originally posted by @JonnyTech in https://github.com/godotengine/godot/issues/77044#issuecomment-1546750746

Also, please note that there is an issue with Godot's .svg import - the stars in the included flags images of eu.svg and us.svg are not rendered correctly.

Rendered with Godot:

Exported image:

Images from https://github.com/lipis/flag-icons

Thanks for checking, @clemens-tolboom - it is not clear if the linked issue is related so I shall open a separate ticket there

@JonnyTech as your https://github.com/thorvg/thorvg/issues/1451 lead to 2 PR (https://github.com/thorvg/thorvg/pull/1452 and https://github.com/thorvg/thorvg/pull/1453 are applied) fixing the EU maybe we should leave this open?

Yes we can leave this open until upstream fixes are made and backported.

Indeed, although it is fixed upstream, I shall wait for it to bubble down to Godot (hopefully v4.0.3) before confirming and closing.

Fixed in 4.2.dev


proxy.golang.org: weird 410 response body

$ curl -i<EMAIL_ADDRESS>HTTP/2 410
content-type: text/plain; charset=UTF-8
date: Fri, 06 Sep 2019 11:03:59 GMT
expires: Fri, 06 Sep 2019 11:33:59 GMT
x-content-type-options: nosniff
x-frame-options: SAMEORIGIN
x-xss-protection: 0
content-length: 11
cache-control: public, max-age=1800
age: 945
alt-svc: quic=":443"; ma=2592000; v="46,43,39"

not found: %

The response body above has only one not found:  prefix. It seems that the proxy.golang.org missed the specific error message.
@katiehockman @mvdan

Interesting, when I run
curl -i<EMAIL_ADDRESS>
I get the following:
HTTP/2 410
content-type: text/plain; charset=UTF-8
date: Fri, 06 Sep 2019 14:42:46 GMT
expires: Fri, 06 Sep 2019 15:12:46 GMT
x-content-type-options: nosniff
x-frame-options: SAMEORIGIN
x-xss-protection: 0
content-length: 61
cache-control: public, max-age=1800
age: 93
alt-svc: quic=":443"; ma=2592000; v="46,43,39"

not found: unknown revision Test/Modules1_darwin/modh2/v1.4.0%

I'm not sure why you are missing the error message when you run the command. Can you confirm that you see the same thing when you navigate to<EMAIL_ADDRESS>in the browser?

Alright, I'll use screenshots to make you believe me. 😂
Terminal:

Safari:

And since it's normal on your side, I think this may be a problem with CDN nodes. I don't know, just a guess.

Sorry that was my bad. I needed to remove the "!" when I put it in the browser :)
Will look into this.

It looks like the mirror had a cached copy of this particular module version which has since been removed from upstream. I can see that sum.golang.org has seen it in the past<EMAIL_ADDRESS>I added a FAQ entry on the https://proxy.golang.org docs to explain this case a little better, and I can look into improving the error message later on.
/cc @hyangah @heschik
(I'll be taking the next 2 weeks as vacation)

Closing this issue because it hasn't been reproduced since the last time.


In CC(Color Control Cluster) the ClusterRevision value is incorrect in SDK

According to the latest spec :

ClusterRevision value needs to be 5 , but its incorrect in the SDK

@raju-apple is this still an issue? Please close if not.

Dupe of #9772


paprprintr.finance Grant Participation

Perfecto

Developers who applied for the program should provide their KuCoin UID in their PR, and KCC will contact them via the email address linked with the UID.

Let's go !!

Developers who applied for the program should provide their KuCoin UID in their PR, and KCC will contact them via the email address linked with the UID.

added 👍

need @PaprPrintr to reply

@lingyun92 Updated


Update _redirects.htaccess

Description of the change: Updated source/_redirects.htaccess
Reason for the change: To fix broken redirects
Link to original source: https://github.com/sendgrid/docs/blob/develop/source/_redirects.htaccess
Closes #3215
@ksigler7

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Refactor default GameConfig and add consts for discord links

It seems like the actual default values were previously being set in Controller's constructor despite appearing several places throughout the codebase; this refactor unifies everything and makes sure there's only one place to change the default config.
initialResourceOverrides is deliberately left out of DEFAULT_CONFIG because I'm concerned that DEFAULT_CONFIG.initialResourceOverrides would share the same mutable array object. I don't think this will cause issues, but it's worth keeping in mind.

Ayyee thank you for cleaning up some ancient relics...


Windows: No GPU being used. Careful, inference might be very slow!

I installed torch 2.0.0 and CUDA 11.7 from PyTorch website. For example automatic's webui works perfectly and detects GPU without any problem. But Bark displays a Windows: No GPU being used. Careful, inference might be very slow! message.
I'm on Windows 10.
Is there any way to fix it?
Update: Fixed it by running pip install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cu117 --force-reinstall after main installation.

great!

I am on M1 Mac MacOS 13
I installed the torch packages
pip3 install torch torchvision torchaudio

The pytorch website says # MPS acceleration is available on MacOS 12.3+
It still shows NoGPU being used, message. Is there something I need to change on the script??

you have set the env var SUNO_ENABLE_MPS to True. Note though that mps support is still experimental


chore: release main

:robot: I have created a release beep boop
dev-dependencies-client: 1.1.0
1.1.0 (2023-11-10)
Features

adding npm-run-all and tsup (908aedb)

Bug Fixes

bump non-breaking dependencies (59bc4fd)

dev-dependencies-server: 1.1.0
1.1.0 (2023-11-10)
Features

adding npm-run-all and tsup (908aedb)

Bug Fixes

bump non-breaking dependencies (59bc4fd)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/aversini/dev-dependencies/releases/tag/dev-dependencies-client-v1.1.0 :sunflower:

:robot: Release is at https://github.com/aversini/dev-dependencies/releases/tag/dev-dependencies-server-v1.1.0 :sunflower:


Analytics and tracking with opt-out

We should add a tracking URL to the config file. Users should be able to opt-out the first time they run Buckaroo.

PR

The opt-out can be done via editting the config.json for the first release.


Featuer/multiplex

Client and server map a TCP connection to a stream on the QUIC connection.

(差分が汚い)


NO-ISSUE: [kn-workflow-plugin] Use new client-pkg for plugin inline

This PR add a dependency on knative.dev/client-pkg rather than directly client repository. The client-pkg was introduced to break potential cyclic deps etc. As an oversight on my end I haven't realized all other plugins are already on the package except workflow one.
Given that this's a monorepo of multiple tools. For the go depedency it's fine to consume it through commit sha. IMO there's no need to have a new patch tag.
/cc @ederign

Maybe we will need to go the other way around and revert other plugins. Please don't merge it yet.

There's no immediate need for this PR to land wrt/ next Serverless release. We got more elegant solution in place for now. But IMO it should revisit the client-pkg dependency for the next cycle probably. We can have a bit of structured conversation beforehand as well.
I'll close the PR to avoid any confusion. :)


Very clever, small issue

This is really neat, however if I try to load a itsybitsy url in Edge/IE it doesn't display. It does in Firefox/Opera. I dont have Chrome on my machine, obviously. Looking in the F12 console in edge, It says
" SEC7134: Resource ‘file:///E:/edit’ not allowed to load.
SCRIPT70: SCRIPT70: Permission denied"
I'm still examining the source, but initial thought is that IE/Edge are doing the right thing, and Firefox/opera are too permissive?

Works with Microsoft Edge 41.16299.492.0 and Internet Explorer 11.492.16299.0 like a charm

After some more investigation (Edge 42.17134.1.0 IE 11.112.17134.0)
I found this from The Verge, at https://www.theverge.com/2018/7/5/17538474/itty-bitty-site-self-contained-websites-urls-open-web
The URL provided on that page, https://itty.bitty.site/#How_it_works/XQAAAAIwDAAAAAAAAAAeHMqHyTY4PyKmqfkwr6ooCXSIMxPQ7ojYR153HqZD3W+keVdvwyoyd+luwncAksxo8PWJs+831jtAVty8rDpGXmyebtxMTP3PSa4g8/593sWue8WaPjJZKXPqJ+G6ffUrBFhdclCfPRZ1gVobusxdd5g4xI5328XhoOoeADUFQZMeRzfBVzcSlEdUqLcxhD5c7kYCBo79g1FR9+rRyw0U3Jyc+5Axt5HWUqKPcEBfQpO35dwvNhCOOZQ/83PRzl51VrpqJ+zwl7UT1JUUK24g/b9zCUO6EIGg1bcZW0VBL53SSK4LE+UkJNv3WKY04UQnISAISa4WghBZjXT5ID0S61leAohaQ9Kqkv6fGfZKI+RFa0bqnsYAHjZZQce8enN9zmfqYR/KIuNnoHmpY9M0W0okWY00CsBUYMdGh1tuE9dypij8nGhJnV61wgkafLJGNsg71mZFmumJRFRdjhuoORlUot67GJomf2ALTGFOYl2JMwf5iLTc4GkKMReT8AeUmDZdt2fEYQDQb81wYhR058quMKXaEv6VOdixspVu8yICITPl+FrCk6qDwJ6z6XY9rHqELHOpSnjLI61/HRwyomwnMb1rsqA4TT5/hlkiajl4m8nDaIUTQFrficA2C7YMLhawZhFHrXtAmRgNH8HmObwlWuTCQ2XnHWvW+uEIlw0ktwxI3S/ZSDlc0t1azaW7YTpOomZtnYAFFzu619Zog3NgnhdH2NBzTiXhO/qCNrE6BzEFqhas0n0i+c2uAxyVbu3wga6i4D6W/Zeu+ozS7MxTVTe7aZT7EmaWm6suNbejNlXATuyGbY5vty5SaI2p8woOr5n3rdw8fO2xklod+r6Ffdatw+3BIviCWzKqBQvtNhCZN7M+2yTkZe0CkngOyxlY2mHcJMgQ4wHSpsVXKpH1MnnCd3TIPQUQwmrrU53vWEEHoFSdoGV6Zcmpx1+wsZeL541iHfhymXGm0hHL2DA/t8JaCnG8Mef7Fs/EWKe2isgdifXJQHicJgLiPxt5blDruW9CbFVrvOZUOECn1Elsn+g0jCsPc+9pj0PmCtfckRw+Istd2AA5kwyMBYp827sOxkX7LO8zluOWqyArCdN99sPugKufd7RTd6zj81EFWkHK3ycu2THLhvTjvmDQgSg9Q27XP8+/d6VmOutAKnJkkgb3mOnR0xVqOMURt9g+2qSt/czpkfPWd+WLcesEn28NJc80yR1DyAxVJ1rUfc3s8TMDo471OY4OjVPnJeP5JcIBkPSKMiit0K0p9ybA4RYVMcifcdjxuzEHVjLyZ37m+hR8cjh927uJrYgZ+bnVgIIG/nyP54ktOZ5pksTD2Yb5X6LnCeoWE40ZkzyWZgjekKotADLi+sk7Uz4cIOdKeUsR9lbhaQsT5XjvDgDYSIewecBb9Z/STIuWQf0Rlj9fGP4YfRNQytqbceSs9QdW8SoQuDrDVHMSgYh50a5p8o1KZw2+ltJ3jZVUQBZyzh+zb/pz/RYmpRxCyo57vL+GRuG+p9xav73ARLtCOTI20aC7wS3M2phWvzr+EEx9D2QRAmk3fQlYSy3suVWhVnkcMSvXDqmuOzSYxMYbOYRZ4moTA0NaC6c0oXBF+aYZlTP9KBEZ8/j59mA8qcpDSIkq4zNqSuQzGuu1qqjnhqBj0G2WOFTOqvy0CiSVDQ98egMCvZGkADyDy6MWLNIqpFfg+A6yr+sBPJqU1V42g+cEwz+QrCtqyanVDh4BXOODH1/SGg9G3zSWQ3J7Y0QZ7szs06sAdRac1dQv+1BLSr1ZvQp+mVReOxsGreTNXAk4ivOu6aAKVykq8Q3EPDKLxQJJF/RFS8YFta+08cs/ufqp/+9lsjK+cdFWSMLmE9JBao1mfXOKqnlMadRnrjyf1w2Nuuf/HXWhhhI+0rmGb6Q23nWAVVx+xSFkchLCVMlSd+ArazIT9amN0PsAouNbzrbujtOD+0i+LcpRJ1g1SylyjkVPOXL31oOKvNAGDEW+XbWNsasN9vPTLf4uQK3qNU0Qv3uM/YnIuyd6WQa93Hc6d91gyC7ABkdSOAyRsKENDzMhOa/XDaEVkLfJdb0Afl7hKu0N2tzm2uQWzHRuQURZdEVifxYs//q/2Gw=
renders blank in IE and Edge, which is why I posted the comment.
I can navigate to https://itty.bitty.site, it redirects to https://itty.bitty.site/edit
and I see "itty bitty things etc".
I entered some text, and it created this url https://itty.bitty.site/#/?XQAAAAI4AAAAAAAAAAApnAimJKOmSm6jy3/XeWtx4CaGOWxUW1O9w/9CmHJfncLB2r8ZYjovJBb/hM51unPn9vOqrf//6DwYAA==
I paste that into a new IE11 window, and I see "Speak the speech, I pray you, as I pronounced it to you"
I click on Edit, the text disappears.
In Edge, it does display even when I click on Edit.
Notwithstanding the above, I think this is really cool, I'm not a javascript guru, but I'm going to see if I can make a standalone read-only url (no edit facility), rendered as a QR code - my wife would find that useful.


Is it very time-consuming to evaluate the model?

I tried to evaluate the model on a remote sensing image dataset and found that testing 1300 512 by 512 sized images would take approximately 7 hours. Is this normal?

It seems abnormal, but could you provide more context about your evaluation settings?

Which model did you use? ViT-H, ViT-L, or ViT-B?
Did you evaluate on CPU or GPU?
How many objects are in each image? The speed is proportional to the total objects, not the images.
Were there any other programs running on the machine during the evaluation?
According to my experience, it took ~30mins to evaluate SBD (2857 images, 6671 instances) on an NVIDIA RTX A6000 GPU.

Thank you so much for taking the time to reply to my message. I truly appreciate your help and expertise.
After reading your response, I think I understand why the speed is so slow. It seems that each of my images contains around 20-40 instances, and labeling them accurately requires labeling 11+ points, which can be quite challenging due to the small, scattered, and complex edges, as well as the blurred nature of remote sensing images. I understand that this can significantly affect the evaluation speed.
Once again, thank you for your valuable insights and assistance.

Yes, that makes a lot of sense. Thanks for the question!


gce: show stdout/stderr when gcloud fails

Many of the nightlies failed last night because gcloud list exited
with status 1, but roachprod swallowed the error.
https://teamcity.cockroachdb.com/repository/download/Cockroach_Nightlies_WorkloadNightly/550402:id/20180307-550402/import/tpch/nodes%3D8/test.log

This change is

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

vm/gce/gcloud.go, line 43 at r1 (raw file):

		if exitErr, ok := err.(*exec.ExitError); ok {
			stderr = exitErr.Stderr
		}

Would using cmd.CombinedOutput() have been easier? Or does gcloud print stuff to stderr on success?

Comments from Reviewable

Would using cmd.CombinedOutput() have been easier? Or does gcloud print stuff to stderr on success?

I'm not sure if prints to stderr in JSON mode, but I didn't want to take the chance.


add isInitialized() to PermissionProvider

When PermissionProvider self-initialization is disabled, PermissionProvider.init(context) must be called to manually initialize the PermissionProvider instance. Depending on where in the app's flow this init() is called, it is possible it may be triggered more than once, whether its multiple times in the app OR in app + test. Calling init() if the instance is already initialized throws IllegalStateException.
One workaround (not the prettiest) to ensure PermissionProvider.init(context) is called only once while handling the exception :
try {
    PermissionProvider.init(context)
} catch (e: IllegalStateException) {
    Timber.e("PermissionProvider instance is already initialized")
}

This PR provides a cleaner approach of making sure to only call init() if the PermissionProvider instance isn't already initialized.
if (!PermissionProvider.isInitialized()) {
    PermissionProvider.init(context)
}

Thanks for creating this. It makes sense to expose the state for manual-init


Ubuntu2004 image support on libvirt and aws

What does this PR change?
Issue: https://github.com/SUSE/spacewalk/issues/11489
Draft PR to add ubuntu 20.04 image support for libvirt and aws.
After clients tools get published on Uyuni, we need to update the repositories in use on cloud-init user data.

@juliogonzalez updated. I didn't test it yet. Is running now on my machine

@juliogonzalez When trying to use teh ibs devel repo I'm getting this error:
module.ubuntu_2004_official.module.minion.module.host.null_resource.provisioning[0] (remote-exec):      Comment: Failed to configure repo 'deb http://download.suse.de/ibs/Devel:/Galaxy:/Manager:/Head:/Ubuntu20.04-SUSE-Manager-Tools/xUbuntu_20.04 /': Error: [Errno -2] Name or service not known reading http://download.suse.de/ibs/Devel:/Galaxy:/Manager:/Head:/Ubuntu20.04-SUSE-Manager-Tools/xUbuntu_20.04/Release.key

Do you have a clue about what could go wrong?

Do you have a clue about what could go wrong?

Either you are not connected to the VPN (as IBS is internal), either you have DNS problems. If it's the second case, how to fix it will depend on your setup. If the VPN DNS are configured at /etc/resolv.conf after connecting, make sure libvirt is using it, as well as the instances.

Thanks @juliogonzalez I re-run the test locally and it now worked. In the previous run I temember I had the VPN on, but maybe I have done something else wrong. I will merge now

adding @Bischoff so he can be aware of this PR.


[RFC, WIP] luci-theme-bootstrap4: add new theme

As discussed in #3644. I'm making a new Bootstrap 4 theme.
This theme contains two parts, one is in luci, another is in my fork of bootstrap.
The part in luci is based on current bootstrap theme. In order to show changes in git diff, I modify original code directly, and I will make a copy after it's done.
The part in my fork of bootstrap is based on bootstrap v4.4.1, you can see changes here.
I'm not familiar with Web front-end development. In order to simplify the work, I mainly use Sass' @extend to make it works with luci. However this will increase the size of final css. If you have any idea please tell me.
Currently it looks like this:

Ping @jow- and @aparcar

Hi, thank you very much for looking into this! I think even the early stage looks already pretty good!
From my understanding Bootstrap changed the names of various classes which you map with the scss files, right? Wouldn't a treewide replace of such classes also do the trick?
I think part of the legacy nature of the current cascade.css its differ so much from upstream....

Wouldn't a treewide replace of such classes also do the trick?

Not really, it would just push the burden of matching the markup to other themes. Keep in mind that there is not only bootstrap based themes.

Wouldn't a treewide replace of such classes also do the trick?
No, for example, cbi-tabmenu class maps to navs with tab nav nav-tabs in bootstrap.

Not really, it would just push the burden of matching the markup to other themes. Keep in mind that there is not only bootstrap based themes.

Right, but if we also change their CSS files? I understand this is a bit of a mess once done future migration should be much simpler. I'd even claim that much more themes appear because boostrap CSS is so much more common.

No, for example, cbi-tabmenu class maps to navs with tab nav nav-tabs in bootstrap.

If you provide a map of such replacements I'll do the boring work of replace it within the code :)

@aparcar I think you are talking about replace in bootstrap source.

@aparcar I think you are talking about replace in bootstrap source.

No, replacing the LuCI bootstrap theme CSS and the other 3s. Keep the boostrap.min.css untouched.

I don't want to peg LuCI markup to bootstrap though, it should remain agnostic. Besides bootstrap lacks a lot of component markup which we need so custom CSS is required anyway.

No, replacing the LuCI bootstrap theme CSS and the other 3s. Keep the boostrap.min.css untouched.

But other theme may use a different class name, this will result in modifying

But other theme may use a different class name, this will result in modifying

Yes, so edit these other themes but not the original bootstrap file.

Besides bootstrap lacks a lot of component markup which we need so custom CSS is required anyway.

Can you please elaborate a bit on this. What compontents are missing in bootstrap?

Yes, so edit these other themes but not the original bootstrap file.

It's unfair to maintainers of other theme.

Can you please elaborate a bit on this. What compontents are missing in bootstrap?

Comboboxes
Rich dropdowns
Combo buttons
Rich tooltips

Another problem is bootstrap's reliance on JavaScript to implement more complex controls.

One further thought about unmodified bootstrap: it contains extreme amounts of whitespace, we would need to modify that as well.

It's unfair to maintainers of other theme.

I think this is an misunderstanding, I would replace things like cbi-button treewide to btn so no extra workload appear for the maintainers. As the class would be changed in their CSS files too, it'd still work.

Another problem is bootstrap's reliance on JavaScript to implement more complex controls.

Thanks for the quick response. I wonder if these elements are trivial to implement in JavaScript and could be an additional layer of CSS/JS on top of Bootstrap. Also if using Bootstrap JavaScript code would safe LuCis JS at other points.
Please don't misunderstand my comments as Bootstrap fandom, I barely used it before. I'm just fan of lowering the obstacles for new people to join in. Maybe it's a dead end.
After all Bootstrap seems to break compatibility between versions anyway 3 & 4

One further thought about unmodified bootstrap: it contains extreme amounts of whitespace, we would need to modify that as well.

The bootstrap.min.css file is minimized

I would replace things like cbi-button treewide to btn so no extra workload appear for the maintainers.

But maybe there are some complex components.

Also if using Bootstrap JavaScript code would safe LuCis JS at other points.

From a quick glance, there is little overlap.

The bootstrap.min.css file is minimized

I am talking about visual space as in margins and paddings, not white space in the CSS file.

@jow- We need a luci app which contains all luci components. It can be used for theme development and testing, and demonstrate what components are available and how to use them.

It's difficult for me to make the "Save & Apply" behave normal, maybe I have to change it's structure to make it work.
Current screenshot:

Moved #tabmenu to top and use a new style:

Added border shadow to .cbi-section:

Finished #topmenu and cbi section.

@jow- Can we use standard table tags instead of div with .table class? Because doing this I don't need to write css for table classes.

One further thought about unmodified bootstrap: it contains extreme amounts of whitespace, we would need to modify that as well.

Just to chime in on this. I just updated 17.x → 20.x and find the denser UI harder to parse and navigate. The more generous amounts of white space in previous releases helped to easily discern visual elements and aided intelligibility and navigation.

17.x on the left, 20.x on the right.  While the individual differences seem negligible, they do add up. Thus white space can be considered an accessibility feature, especially for users that do not know every nook and cranny of the UI.

@messismore This should be possible later on. I think for now it is mostly about making the current JavaScript framework work together with Bootstrap 4.
@ysc3839 Can you please share your modified bootstrap.css and add it to the current PR?

@jow- Can we use standard table tags instead of div with .table class?

That is not doable and would require tree-wide changes to a lot of components. For now just add the following lines to your CSS:
.table { display: table; }
.tr { display: table-row; }
.th, .td { display: table-cell; }

@aparcar Updated.

Close this pr since it requires a lot of work, and I have no time doing this.
I'm looking for a CSS utility framework to build our own theme, instead of out-of-box CSS framework like bootstrap.
Recently I found Tailwind CSS which may suit for making a theme.


Create a landing page for the reference section

Fixed with https://github.com/reactjs/react.dev/pull/6378


extensions: package full paths

Extension shall use full package path:

key := ext.KeyBuilder("sys.View", "github.com/untillpro/airs-bp3/packages/air.TestView")

depends on #1547

completed with #1594


installation: decide on restriction policy

Let's try to decide what would be the recommended restriction system fitting most service use cases, and let's plug it into Invenio 3 demo site records.

using collections?
using ACLs in records?

See also https://github.com/inveniosoftware/invenio-access/issues/70

:+1: for restricted collections.

+1 for ACL in records. Restricted collections can be built on top of this.

+1 for ACL in records. Restricted collections can be built on top of this.

:+1: also for ACLs then :smile:

+1 for ACL in records

While this is for records, one should probably think about handling for files attached to records as well.

@aw-bib https://github.com/inveniosoftware/invenio/issues/3680 😉

It may be better to discuss in https://github.com/inveniosoftware/invenio-access/issues/70 where @egabancho nicely summarised all the pros and cons...


Purple bar under text input

I'm not sure if it's due to a Discord update, but since a couple days there's a purple bar when focusing the text input.

if you'd like to disable this bar, go into the root file (located in ./src/_root.scss/) and change the --display-height variable to 0 or none (if you have OCD and the rounding on the bottom not being matched with the top annoys you, you can set the --border-radius variable to 6px)


Bump deCONZ version to latest stable release

The problem
deCONZ add-on was not updated (bumped) for a long time now. Would it be possible to update to the latest version that was released today? https://github.com/dresden-elektronik/deconz-rest-plugin/releases/tag/V2_05_81_stable
Thanks!

2.05.81 is the stable version of 2.05.80 rc/beta version.
We won't be upgrading to this version. See: https://github.com/home-assistant/hassio-addons/pull/1541#issuecomment-675330382

I don't get it to be honest. What is the reason to not upgrade it?
From what I can see 2.05.81 re-enables firmware update in Phoscon (and there was one released yesterday) and fixes a lot of issues. Even LQI issue that was there for a long long time.

From what I can see 2.05.81 re-enables firmware update in Phoscon

I'm not seeing that one listed, furthermore, the release explicitly mentions a manual upgrade is needed.

From what I can see 2.05.81 re-enables firmware update in Phoscon

I'm not seeing that one listed, furthermore, the release explicitly mentions a manual upgrade is needed.

That is said in PR mentioned in release notes:

Improved firmware update #3256
Heres the link to PR: https://github.com/dresden-elektronik/deconz-rest-plugin/pull/3256

I'm not sure why the release notes states the opposite in firmware section. Maybe that's just a firmware thing.

@frenck
That's cleared out in this issue that I've created in DE repository: https://github.com/dresden-elektronik/deconz-rest-plugin/issues/3266
So the manual update requirement isn't the case with the latest deCONZ.


NSX Manager Super User Principal Identify Certificate

Regarding the step for "NSX Manager Super User Principal Identify Certificate" under Networking:
The referenced step for creating this Cert, Step 6: Generate and Register Certificates is empty.
What would be the procedure for this?

Thanks @kroberts7! This section has been updated: https://github.com/pivotal-cf/docs-pks/blob/0139f5fb65df4562607ad2a46631118f98f930a5/installing-nsx-t.html.md.erb#L335-L519


RDKit failures if molgrid is imported first

I encountered an odd incompatibility between molgrid and rdkit which seems to depend on the order of import statements. I installed molgrid using pip in a conda environment where rdkit has been installed from the conda-forge channel.

The following snippet works as expected:
from rdkit import Chem
from rdkit.Chem import AllChem

m = Chem.MolFromSmiles('C1CCC1OC')
m2 = Chem.AddHs(m)
cids = AllChem.EmbedMultipleConfs(m2, numConfs=2)

If molgrid is imported before rdkit
import molgrid
from rdkit import Chem
from rdkit.Chem import AllChem

m = Chem.MolFromSmiles('C1CCC1OC')
m2 = Chem.AddHs(m)
cids = AllChem.EmbedMultipleConfs(m2, numConfs=2)

I get the following failure on the last line (EmbedMultipleConfs call):
TypeError: No to_python (by-value) converter found for C++ type: std::vector<int, std::allocator<int> >

The error does not appear if molgrid is imported after rdkit:
from rdkit import Chem
from rdkit.Chem import AllChem
import molgrid

m = Chem.MolFromSmiles('C1CCC1OC')
m2 = Chem.AddHs(m)
cids = AllChem.EmbedMultipleConfs(m2, numConfs=2)

conda environment to reproduce the issue:
name: rdkit-molgrid
channels:
  - conda-forge
  - pytorch
dependencies:
  - python=3.7
  - ipython
  - pip

  - rdkit=2021.03.3
  - cudatoolkit=11.1
  - pytorch

  - pip:
    - molgrid==0.2.1

Can you check to see if this is still a problem with 0.5.1?

By upgrading molgrid with python -m pip install -U molgrid the problem seems to persist. I'll try to re-build the whole conda environment.
I tried to run the same script within a Singularity container where molgrid==0.2.1 and rdkit==2021_03_1 are compiled from source and there is no such problem.

It may depend on what version of boost-python rdkit was built with.

Yes, probably a similar problem to #62.

Not really.  #62 is a problem because I am relying on bit-for-bit compatibility with openbabel data structures.  The issue here is the way rdkit/boost-python are adding symbols to the python environment.  I'm 80% sure the correct fix involves changed rdkit, not molgrid.


Compatibility with Laravel 9

I know, I know. Laravel 9 was just released today, it would be great if this package would support it!

I've just release a new version for L9, let me know if you encounter any issues (ping me on this thread).
Have a nice day!

@kolaente I've released 1.1.1.

That works great. Thank you!


python311Packages.jupyterhub: 4.0.2 -> 4.1.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.jupyterhub is: Serves multiple Jupyter notebook instances
meta.homepage for python311Packages.jupyterhub is: https://jupyter.org/
meta.changelog for python311Packages.jupyterhub is: https://github.com/jupyterhub/jupyterhub/blob/4.1.0/docs/source/reference/changelog.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.1.0 with grep in /nix/store/50zwwg4m2cz94ksrh0byv3b1c2kix37f-python3.11-jupyterhub-4.1.0
found 4.1.0 in filename of file in /nix/store/50zwwg4m2cz94ksrh0byv3b1c2kix37f-python3.11-jupyterhub-4.1.0

Rebuild report (if merged into master) (click to expand)

7 total rebuild path(s)

7 package rebuild(s)

First fifty rebuilds by attrpath
python311Packages.batchspawner
python311Packages.dockerspawner
python311Packages.jupyterhub
python311Packages.jupyterhub-ldapauthenticator
python311Packages.jupyterhub-systemdspawner
python311Packages.jupyterhub-tmpauthenticator
python311Packages.oauthenticator

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/50zwwg4m2cz94ksrh0byv3b1c2kix37f-python3.11-jupyterhub-4.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.jupyterhub https://github.com/r-ryantm/nixpkgs/archive/5fa11de865477a3a16e0c10a62adbe3d043b35c6.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/5fa11de865477a3a16e0c10a62adbe3d043b35c6#python311Packages.jupyterhub

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/50zwwg4m2cz94ksrh0byv3b1c2kix37f-python3.11-jupyterhub-4.1.0
ls -la /nix/store/50zwwg4m2cz94ksrh0byv3b1c2kix37f-python3.11-jupyterhub-4.1.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

14 packages built:

python311Packages.batchspawner
python311Packages.batchspawner.dist
python311Packages.dockerspawner
python311Packages.dockerspawner.dist
python311Packages.jupyterhub
python311Packages.jupyterhub-ldapauthenticator
python311Packages.jupyterhub-ldapauthenticator.dist
python311Packages.jupyterhub-systemdspawner
python311Packages.jupyterhub-systemdspawner.dist
python311Packages.jupyterhub-tmpauthenticator
python311Packages.jupyterhub-tmpauthenticator.dist
python311Packages.jupyterhub.dist
python311Packages.oauthenticator
python311Packages.oauthenticator.dist

Maintainer pings
cc @GaetanLepage @natsukium @thomasjm for testing.

duplicate of #297752


High priority best practices

Per #90,
This refactors various sites where flow could be updated according to more modernized practices; completing the checklist for high priority best practices (#90), and one of the medium priority tasks. More specifically, this closes the following tasks:

High priority:

[x] Replace all occurrences of type(<obj>).__name__ == "<Class>" with isinstance(<Class>, <obj>).
This will allow custom subclasses to be made and used with the project in the future
[X]  When checking for None obj is [not] None should be used instead of type (as above) or ==
[X] Default arguments in should never be mutable (e.g. a list or dictionary) as they are not reset between function calls and this can lead to bugs. Instead, set default to None and replace None with the required value in the function.
[X] When checking if a value is True or "Truthy" use if value and never if value == True.
if value is True should be avoided unless checking for exactly True (will be false if compared to numpy's value of True)

Medium Priority:

[X]  Use f-strings instead using .format on strings, this makes reading and writing much clearer
e.g. replace "pet-{}".format(name) with f"pet-{name}"

Any idea how to resolve the missing libcublas.so.11 file? Looks issue with environment setup with CI?

Any idea how to resolve the missing libcublas.so.11 file? Looks issue with environment setup with CI?

Yeah, it seems to stem from CUDA links not matching up between torch and NVIDIA, see pytorch/issues/88882
To work around this, we can migrate to pip and specify the index url in CI. I've updated the workflow to do such :)

Friendly ping @manny405

Thanks, I'll review it sometime over the long weekend.


normalize religion value for Robert Wittman

to match other legislators of the same religious affiliation (Episcopal -> Episcopalian)

Merged. But we only have this data in for legislators who were serving the small time window when I cared about this field (2004-2008ish), so we should consider deleting the field entirely...


Handling put_assoc with on_conflict: nothing

Note: this issue is not like #1912 even though it deals with the same functions.
Environment

Elixir version (elixir -v): 1.6.0
Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.): MySQL 5.6
Ecto version (mix deps): 2.2.7
Database adapter and version (mix deps): mariaex 0.8.3
Operating system: MacOS Sierra / Ubuntu 16.04

Current behavior
When you do
changeset
|> put_assoc(SomeOtherRecord.changeset())
|> Repo.insert(on_conflict: :nothing)

and you do have a conflict, you will get an Ecto.ConstraintError on the foreign key constraint. That's because Ecto will attempt to insert the associated record despite having not inserted the parent.
Expected behavior
In an ideal world this code would act the same way as when there is no put_assoc, simply return the in-memory schema. However, I'm not sure if it's possible. Would love to hear thoughts.

Thanks for the report!
Unfortunately there isn't much we can do because the database does not give us much information about what happened. We know the ID is null, if it is was supposed to be generated in the database, but this is not a consistent behaviour and we don't know the reason why either.
I will make sure to document this behaviour, thank you!

You can use Ecto.Multi in this case.


[$500] Chat - Entire multiline message with line break not displayed in composer while editing comment

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.12-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:

Launch Expensify app
Sign in with gmail account
Navigate to any 1:1 conversation
Send a multiline message with line break
Tap & hold on message to view the action menu

Expected Result:
Complete multiline message with line break should be displayed in edit compose box while editing comment
Actual Result:
Entire multiline message with line break not displayed in composer while editing comment
Note : Issue happens with device in both online & offline mode (Please check the videos attached)
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/ab0c07d3-5c2a-417e-b5c2-395ae00618c3

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0165c8cce495cfeb70
Upwork Job ID:<PHONE_NUMBER>421496832
Last Price Increase: 2023-12-14

Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat - Entire multiline message with line break not displayed in composer while editing comment
What is the root cause of that problem?
Using flex prop in the style of the composer is causing multiline messages with line breaks not displayed (IPhone only), this seems to be an IOS bug when using flexbox in an input text.
What changes do you think we should make to solve the problem?
We should remove the styles.flex1 prop from the next line when the user is using IPhone:
https://github.com/Expensify/App/blob/9d2ea87f057f843a822f770aeafc7e10a00c13f9/src/pages/home/report/ReportActionItemMessageEdit.js#L420
Tests:
Before changes:
https://github.com/Expensify/App/assets/5216036/9606fda7-7630-4276-82a4-6fca5a6a1848
After changes:
https://github.com/Expensify/App/assets/5216036/a2e70c97-374a-4746-b233-e2d3e3edf0a0

Matt A and I can both repro this. Tagged DB in #vip-vsb

Reviewing

Hi @alitoshmatov how did your review go?

Sorry I think I forgot to update here.
Currently I am not able to reproduce this issue:
https://github.com/Expensify/App/assets/59907218/f8792db0-19ef-4e79-afa5-12090bb9421e

Hmm, this was like 8 versions ago haha. I can't seem to repro either. Going to close this!


Incorrect/non-existent release notes page

Operating System
Windows Server 2022
AMP Version and Build Date
<IP_ADDRESS> - 20241120.1
AMP Release Stream
Mainline
I confirm that

[X] I have searched for an existing bug report for this issue.
[X] I am using the latest available version of AMP.
[X] my operating system is up-to-date.

Intended Action
Clicking the "View Release notes" should open the correct forum topic of the changelog.
Expected Behaviour
New tab should open the correct URL, which is currently https://discourse.cubecoders.com/t/amp-phobos-2-6-release-notes/18255
Actual Behaviour

Wrong page is opened, with a "Oops! That page doesn’t exist or is private." error
Reproduction
Go to AMP's Support and Updates page
Click View Release Notes
Notice the broken page

This is resolved. Was an issue with the topic's title missing the third 0 in the version number. Thank you!


[R24.12] [BPN Finder] Release Checks

Release Info
Please provide information on what you want to be included in the Eclipse Tractus-X release.
If you are not owner of this issue, please provide the information as comment to the issue.
Make sure to assign this issue to expert(s) for their approval, as soon as you have finished preparation. Multiple assignees allowed; they will un-assign themselves once review completed.
Responsible contacts:

Committer: @agg3fe , @tunacicek
ExpertGroup: @thomas-henn , @agg3fe , @tunacicek
Contributor contact: @agg3fe , @tunacicek

Version to be included in Eclipse Tractus-X release:

helm: bpndiscovery-0.4.2
Image version: 0.5.2
Leading product repository: repository link
Compliance

[x] Possible changes (through the new features) on related Catena-X standards are considered and addressed
[x] Tractus-X Release Guidelines(TRGs) fulfilled https://github.com/eclipse-tractusx/sldt-bpn-discovery/issues/171

Make sure to open and fill in a separate documentation issue in your product repository using the Quality Gate Checklist issue template

[!NOTE]
Note: most criteria for documentation and security are now covered in TRGs

Functionality

Hint: No features -> This release includes only Bugfix (CVEs)

[x] Feature works as expected and described
[x] Backward compatibility maintained (depending Major/ Minor)

Performance

[x] Memory and CPU usage is within acceptable limits oriented with goldilocks

Testing

[x] Unit tests cover all new features
[x] Integration tests are updated
[x] E2E/Integration test passed
[x] Regressions tests passed

Feature summary
Hint: No features implemented in this release. Only Bugfixes (CVEs)
Release Documentation

[x] Release notes/Changelogs are updated (https://github.com/eclipse-tractusx/sldt-bpn-discovery/blob/v0.5.1/CHANGELOG.md)
[x] Migration scripts/documentation are included if necessary (Ensure that any database or infrastructure migrations are included).

Summary
Hint: No features implemented in this release. Only Bugfixes (CVEs)
Helpful Links

OpenAPI file: https://github.com/eclipse-tractusx/sldt-bpn-discovery/blob/v0.5.1/backend/src/main/resources/static/bpn-discovery-service-openapi.yaml
Eclipse Tractus-X openAPI specs on SwaggerHub

Ee2 Tests:
No E2E Test is needed. Instead of, we tested our APIs on INT ENV successfully with our automated tests
See result: https://github.com/eclipse-tractusx/sldt-bpn-discovery/actions/runs/11775322176

QG Review

Hi @tunacicek @agg3fe ,
I have a few questions regarding the current status:

Could you give me an update on the checkbox performance?
For clarity and documentation purposes, could you strike through the e2e test section since no e2e tests are required?
Could you give me an update about the TRG 1.05 architecture documentation because this TRG hasn’t been checked yet
Lastly, I was wondering if there are no 'Known Knowns' for this issue?

Thank you for your help!

Hi @ther3sa,
we released a new version which includes the new architecture structure.
i updated release checks.

Congrats
Quality Gate fully approved with all necessary pre-requisites fulfilled!

Thanks for all your efforts :)


Add "sync now" button

Is your feature request related to a problem? Please describe.
It's frustrating when you want to organize some little thing real quick, and then have to wait until auto-sync fetches the images from your server. Sometimes I want to force my images to be synced right now, not sometime in the next six hours.
Describe the solution you'd like
A simple button that forces immediate synchronisation would be great. Doesn't matter where it is, it can even be in the settings menu. I just want to be able to use it every now and then.

The easy way to do this, if not the obvious way, is to select the photo and share it to Les Pas again, then you can choose another album to host it.

Each time you open Les Pas app, it actually sync with server once.

Ah, I was not aware of that, thank you.
I would argue that the feature request is still valid though, because it is not intuitively clear that the workaround "close the app and reopen it" works.

Thank you. My intention is to make the sync process as robust as possible so that users will actually forget it at all. It's a feeling of it just works, don't worry too much about it.
Actually, if you make any changes in the app, it will sync immediately with server. The only major shortcoming now is I don't have adequate skills to implement sync function on server side. If you make any changes on server, you will have to wait at most 6 hours to see those changes on your phone. That's all the periodic sync function is all about.
After I finish the facial recognition part, this is one of the major features to implement besides sharing albums among nextcloud users.

Also, it would be very nice to have an indicator, that the sync is running, so that the user can see when everything is up-to-date. This is extremely useful when backing up the phone on some restaurant wifi in middle of nowhere. In such situations, a simple progressbar is just amazing (while in daily life with a good connection nobody cares).

I hope, I do not hjijack this ticket: I tried  the "sync camera roll" feature but with limited success: it seems, I even have to restart lespas, so that the pictures get uploaded... not even a 6 hours wait helps...
I would love to use this feature instead of the quite unreliable nextcloud upload sync...

release 2.5.20 has a re-sync button


pyproj 2.1.3 transform() fails with errcheck=True

https://github.com/pyproj4/pyproj/pull/228 introduced a check for the return value of proj_trans_generic which is saved as err_count although it is described as "Number of transformations completed" in PROJ:
https://github.com/OSGeo/proj.4/blob/e87b3744350baca2b7fe35070e621a6b45bcbf67/src/4D_api.cpp#L353
(proj_trans_array returns 0 if all coordinates are transformed without error, otherwise returns an error number:
https://github.com/OSGeo/proj.4/blob/e87b3744350baca2b7fe35070e621a6b45bcbf67/src/4D_api.cpp#L282)
This code:
from pyproj import Proj, transform

p1 = Proj(init="epsg:4326")
p2 = Proj(init="epsg:27700")

print(transform(p1, p2, 1.716073972, 52.658007833, errcheck=True))

now fails with:
  File "/usr/lib/python3.7/site-packages/pyproj/transformer.py", line 367, in transform
    xx=x, yy=y, zz=z, tt=tt, radians=radians, errcheck=errcheck
  File "/usr/lib/python3.7/site-packages/pyproj/transformer.py", line 180, in transform
    inx, iny, inz=inz, intime=intime, radians=radians, errcheck=errcheck
  File "pyproj/_transformer.pyx", line 144, in pyproj._transformer._Transformer._transform
pyproj.exceptions.ProjError: 1 proj_trans_generic error(s)

As per this comment https://github.com/pyproj4/pyproj/issues/208#issuecomment-477136179, a return value of 0 may be an error (or just there was nothing to transform).
But you would expect a positive integer result on a successful transformation as above?

@kbevers, can you clarify this?

Nevermind, this is correct. I misinterpreted this and is a bug.


Fixing schema compare checkbox column functions

This PR fixes #20992

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 10 (0.0%)  changed or added relevant lines in 1 file are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.01%) to 41.928%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/base/browser/ui/table/plugins/checkboxSelectColumn.plugin.ts
0
10
0.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/sql-bindings/src/common/azureFunctionsUtils.ts
1
80.65%

extensions/notebook/src/jupyter/serverInstance.ts
4
75.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
28867

Relevant Lines:
63944

💛  - Coveralls

I validated that the column header turning into a checkbox bug is fixed in this branch. Thanks for the quick fix!


[stable/kube2iam] add podsecuritypolicy object to the chart

Signed-off-by: Yannick Kint<EMAIL_ADDRESS>What this PR does / why we need it:
Add the possibility to configure podSecurityPolicies for kube2iam. podsecuritypolicies are an important security feature of k8s, policies are needed to let kube2iam function properly when the default psp is restricted.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @davidkarlsen

/ok-to-test

/lgtm


add help cmd and timeout

i havent finished the help command yet (option part) so yea, this is the help command, you don't have to put category inside the command files anymore but you have to put the cmd in the right category

lgtm!

Some suggestions, use choices or autocomplete for the category in the help command.
Make it so that the moderator can provide any amount of duration rather than choosing from a limited choices

Closed due to lack of updates


Update http4s-circe, http4s-dsl to 0.23.28

About this PR
📦 Updates

org.http4s:http4s-circe
org.http4s:http4s-dsl

from 0.23.11 to 0.23.28
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.http4s" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, version-scheme:early-semver, commit-count:1

Superseded by #555.


Update go module path for major version 2

Component
other
Describe the bug
Getting versiogo.woodpecker-ci.org/woodpecker/v2n 2.0.0 of the go library results in an error
runephilosof@fedora:~/code/platform-woodpecker/woodpecker-repo-configurator (master)$ go get<EMAIL_ADDRESS>go<EMAIL_ADDRESS>invalid version: module contains a go.mod file, so module path must match major version ("go.woodpecker-ci.org/woodpecker/v2")

System Info
go version go1.20.11 linux/amd64

Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
[X] Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

That's pretty annoying that we have to update the import paths of the whole codebase each time we release a major version 🙈 However I guess we need to change it then and release 2.1.0 to fix it.

I guess the versioning of the go library and other go code can be separated somehow.
That would lower the amount of files that need to change.
The server go code is not a library, so it should not need to be versioned this way.
Avoiding "go.woodpecker-ci.org/woodpecker/v2/server" would be nice.


Only let Dependabot update weekly

daily updates are a bit too spammy, only allow weekly updates.

:+1:


Flutter : Stateless Widget Documentation

Description 📜
I had done documentation  on stateless widget
Fixes #1008

Type of change 📝

[x] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] Android Dev (Flutter, Java, Kotlin)

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x I'm GWOC'21 contributor

@msramesh2k1 you have some plagiarised content from geeksforgeeks, please make your content unique, using online tools.

Okie will do

@ViAsmit can you please now

@msramesh2k1 Thanks for the PR


[sysrst_ctrl] Update covergroups to include precondition settings

remove redundant covergroup entry in hjson
Add sysrst_ctrl_combo_precondition_det_cg to cover combo detection block precondition timer values
Update sysrst_ctrl_combo_detect_action_cg sample function to include precondition key selections
Add entries for newly added cpovergroups in hjson and index.md

Signed-off-by: Raviteja Chatta<EMAIL_ADDRESS>

I do not think the CI is related to this PR, but somehow OTBN failed:
* `Job returned non-zero exit code` has 1 failures:
    * Test otbn_smoke has 1 failures.
        * 0.otbn_smoke.1\
         Log /azp/agent/_work/1/s/scratch/HEAD/otbn-sim-xcelium/0.otbn_smoke/latest/run.log

                		rctx.download_and_extract(
                Error in download_and_extract: java.io.IOException: Error downloading [https://github.com/indygreg/python-build-standalone/releases/download/20220227/cpython-3.9.10+20220227-x86_64-unknown-linux-gnu-install_only.tar.gz] to /root/.cache/bazel/_bazel_root/5e4f8c833cf3a422fdf6ca333dd151d7/external/python3_x86_64-unknown-linux-gnu/temp9683317823752616132/cpython-3.9.10+20220227-x86_64-unknown-linux-gnu-install_only.tar.gz: Bytes read 4194304 but wanted 51624807
                ERROR: /azp/agent/_work/1/s/WORKSPACE:17:9: fetching python_repository rule //external:python3_x86_64-unknown-linux-gnu: Traceback (most recent call last):
                	File "/root/.cache/bazel/_bazel_root/5e4f8c833cf3a422fdf6ca333dd151d7/external/rules_python/python/repositories.bzl", line 82, column 34, in _python_repository_impl
                		rctx.download_and_extract(
                Error in download_and_extract: java.io.IOException: Error downloading [https://github.com/indygreg/python-build-standalone/releases/download/20220227/cpython-3.9.10+20220227-x86_64-unknown-linux-gnu-install_only.tar.gz] to /root/.cache/bazel/_bazel_root/5e4f8c833cf3a422fdf6ca333dd151d7/external/python3_x86_64-unknown-linux-gnu/temp9683317823752616132/cpython-3.9.10+20220227-x86_64-unknown-linux-gnu-install_only.tar.gz: Bytes read 4194304 but wanted 51624807
                ERROR: error loading package '': at /azp/agent/_work/1/s/rules/bitstreams.bzl:5:6: Encountered error while reading extension file 'requirements.bzl': no such package '@ot_python_deps//': no such package '@ot_python_wheels//': no such package '@python3_x86_64-unknown-linux-gnu//': java.io.IOException: Error downloading [https://github.com/indygreg/python-build-standalone/releases/download/20220227/cpython-3.9.10+20220227-x86_64-unknown-linux-gnu-install_only.tar.gz] to /root/.cache/bazel/_bazel_root/5e4f8c833cf3a422fdf6ca333dd151d7/external/python3_x86_64-unknown-linux-gnu/temp9683317823752616132/cpython-3.9.10+20220227-x86_64-unknown-linux-gnu-install_only.tar.gz: Bytes read 4194304 but wanted 51624807
                Loading: 0 packages loaded
                Loading: 0 packages loaded
                make: *** [/azp/agent/_work/1/s/hw/dv/tools/dvsim/sim.mk:52: pre_run] Error 2

I do not think the CI is related to this PR, but somehow OTBN failed:
* `Job returned non-zero exit code` has 1 failures:
    * Test otbn_smoke has 1 failures.
        * 0.otbn_smoke.1\
         Log /azp/agent/_work/1/s/scratch/HEAD/otbn-sim-xcelium/0.otbn_smoke/latest/run.log

                		rctx.download_and_extract(
                Error in download_and_extract: java.io.IOException: Error downloading [https://github.com/indygreg/python-build-standalone/releases/download/20220227/cpython-3.9.10+20220227-x86_64-unknown-linux-gnu-install_only.tar.gz] to /root/.cache/bazel/_bazel_root/5e4f8c833cf3a422fdf6ca333dd151d7/external/python3_x86_64-unknown-linux-gnu/temp9683317823752616132/cpython-3.9.10+20220227-x86_64-unknown-linux-gnu-install_only.tar.gz: Bytes read 4194304 but wanted 51624807
                ERROR: /azp/agent/_work/1/s/WORKSPACE:17:9: fetching python_repository rule //external:python3_x86_64-unknown-linux-gnu: Traceback (most recent call last):
                	File "/root/.cache/bazel/_bazel_root/5e4f8c833cf3a422fdf6ca333dd151d7/external/rules_python/python/repositories.bzl", line 82, column 34, in _python_repository_impl
                		rctx.download_and_extract(
                Error in download_and_extract: java.io.IOException: Error downloading [https://github.com/indygreg/python-build-standalone/releases/download/20220227/cpython-3.9.10+20220227-x86_64-unknown-linux-gnu-install_only.tar.gz] to /root/.cache/bazel/_bazel_root/5e4f8c833cf3a422fdf6ca333dd151d7/external/python3_x86_64-unknown-linux-gnu/temp9683317823752616132/cpython-3.9.10+20220227-x86_64-unknown-linux-gnu-install_only.tar.gz: Bytes read 4194304 but wanted 51624807
                ERROR: error loading package '': at /azp/agent/_work/1/s/rules/bitstreams.bzl:5:6: Encountered error while reading extension file 'requirements.bzl': no such package '@ot_python_deps//': no such package '@ot_python_wheels//': no such package '@python3_x86_64-unknown-linux-gnu//': java.io.IOException: Error downloading [https://github.com/indygreg/python-build-standalone/releases/download/20220227/cpython-3.9.10+20220227-x86_64-unknown-linux-gnu-install_only.tar.gz] to /root/.cache/bazel/_bazel_root/5e4f8c833cf3a422fdf6ca333dd151d7/external/python3_x86_64-unknown-linux-gnu/temp9683317823752616132/cpython-3.9.10+20220227-x86_64-unknown-linux-gnu-install_only.tar.gz: Bytes read 4194304 but wanted 51624807
                Loading: 0 packages loaded
                Loading: 0 packages loaded
                make: *** [/azp/agent/_work/1/s/hw/dv/tools/dvsim/sim.mk:52: pre_run] Error 2

Shall we rerun the CI in case it is flaky, or it is a known issue on OTBN?

Yeah rerun is useful in this case. It looks like an error in downloading the cpython dependency to me.

@crteja do you mind rebasing the PR and see if it passes the CI? Sometimes it is kinda flaky.

rebased the change to the latest master branch


SSL certificate problem: self signed certificate in certificate chain

Hi! I am facing the following error:
SSL certificate problem: self signed certificate in certificate chain when reading metadata of gs://scenic-bucket/owl_vit/checkpoints/clip_vit_b32_b0203fc

Are there any ways to fix it?

This looks like a configuration issue on your side. You can try to download the checkpoints manually using the links provided here: https://github.com/google-research/scenic/tree/main/scenic/projects/owl_vit#pretrained-checkpoints


Relative path from a working directory

Is there an existing issue for this?

[X] I have searched the existing issues

Does this issue exist in the latest version?

[X] I'm using the latest release

Describe the bug?
Hello!
diff_relative this directive is not returning the relative path from the folder I'm in.
    with:
      diff_relative: "true"
      files: |
        web/**

returns paths with web prefixed. Is this expected?
Apologies if I misunderstood the functionality of diff_relative. I've also tried using a boolean, non-string like value. (true) I couldn't find the example to get the relative path within a specific folder.
Thank you!
To Reproduce
Running this part within a GH action
    with:
      diff_relative: "true"
      files: |
        web/**

What OS are you seeing the problem on?
macos-11
Expected behavior?
To return paths only relative to the working folder.
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thank you so much @jackton1 🙏 Much appreciation for your work!


Encountering RequiredNodeFeatureMissing routing error in pathfinding is not gracefully handled

Background
When pathfinding, LND should handle RequiredNodeFeatureMissing errors by ignoring the problematic channel, instead it causes a failure to find future paths
Your environment

lnd v0.11.1-beta

Steps to reproduce

Query routes for a route that will result in a RequiredNodeFeatureMissing error
Send to the route and get the error
Query routes again

Expected behavior
Query routes should skip over the edge that had the error
Actual behavior
Query routes stops returning routes
Workaround
Run lncli resetmc and ignore the edge that caused the issue

I am facing this issue now with one of my rebalance routes.
lncli resetmc will just reset everything and the problem will arise again when lncli payinvoice will inevitably tries the same path again.
If only there is a way to 'exclude' certain (problematic) nodes from the pathfinding.

A first look (checked in a unit test) indicates that routing.interpretResult() interpretes this failure as a node-wide failure and reports all previously tried channels associated with that node as a failed (in- and outward directions), which is why this should not happen. Will try to reproduce in a more realistic environment.

I set up a test scenario, where a graph of the following nodes is involved:
L sending node
A 028f5efb8b4b67b4bc9584c12efcfec3917cf9b759bc2e57ae3780a7c0e73f82c4
B 026c584374b3a8bd87e56bb15cc1e6c4684562354515005f47e756dc49ae0fe454
C 026fcbc477870d95970778154628a3974e2f2c61a5aac6af86ea6c9a8899dcbf17
D 03cd1e1f6df1893fde301c6ef4ec91b3e68530c75377bcbd5a6e74019254b8f8c1

graph with channels:
L - A, A - B, B - C, A - C, C - D
selected route: L - A - C - D
I set up C in such a way that it fails back with RequiredNodeFeatureMissing
Logs from the sending node:
Attempt 1 for payment f50ab69f3bc2723aa4a782fad61cb88bd6f5f03cd09b4c5b721c32f99428c1e2 failed: RequiredNodeFeatureMissing@3
Reporting node failure to Mission Control: node=026fcbc477870d95970778154628a3974e2f2c61a5aac6af86ea6c9a8899dcbf17
Reporting pair failure to Mission Control: pair=028f5efb8b4b67b4bc9584c12efcfec3917cf9b759bc2e57ae3780a7c0e73f82c4 -> 026fcbc477870d95970778154628a3974e2f2c61a5aac6af86ea6c9a8899dcbf17, amt=0 mSAT
Setting 028f5efb8b4b67b4bc9584c12efcfec3917cf9b759bc2e57ae3780a7c0e73f82c4->026fcbc477870d95970778154628a3974e2f2c61a5aac6af86ea6c9a8899dcbf17 range to [0 mSAT-0 mSAT]
Reporting pair failure to Mission Control: pair=026fcbc477870d95970778154628a3974e2f2c61a5aac6af86ea6c9a8899dcbf17 -> 028f5efb8b4b67b4bc9584c12efcfec3917cf9b759bc2e57ae3780a7c0e73f82c4, amt=0 mSAT
Setting 026fcbc477870d95970778154628a3974e2f2c61a5aac6af86ea6c9a8899dcbf17->028f5efb8b4b67b4bc9584c12efcfec3917cf9b759bc2e57ae3780a7c0e73f82c4 range to [0 mSAT-0 mSAT]
Reporting pair failure to Mission Control: pair=026fcbc477870d95970778154628a3974e2f2c61a5aac6af86ea6c9a8899dcbf17 -> 03cd1e1f6df1893fde301c6ef4ec91b3e68530c75377bcbd5a6e74019254b8f8c1, amt=0 mSAT
Setting 026fcbc477870d95970778154628a3974e2f2c61a5aac6af86ea6c9a8899dcbf17->03cd1e1f6df1893fde301c6ef4ec91b3e68530c75377bcbd5a6e74019254b8f8c1 range to [0 mSAT-0 mSAT]
Reporting pair failure to Mission Control: pair=03cd1e1f6df1893fde301c6ef4ec91b3e68530c75377bcbd5a6e74019254b8f8c1 -> 026fcbc477870d95970778154628a3974e2f2c61a5aac6af86ea6c9a8899dcbf17, amt=0 mSAT
Setting 03cd1e1f6df1893fde301c6ef4ec91b3e68530c75377bcbd5a6e74019254b8f8c1->026fcbc477870d95970778154628a3974e2f2c61a5aac6af86ea6c9a8899dcbf17 range to [0 mSAT-0 mSAT]

Mission control state after:
028f5efb8b4b67b4bc9584c12efcfec3917cf9b759bc2e57ae3780a7c0e73f82c4 026fcbc477870d95970778154628a3974e2f2c61a5aac6af86ea6c9a8899dcbf17 fail_time:1662380360
026fcbc477870d95970778154628a3974e2f2c61a5aac6af86ea6c9a8899dcbf17 028f5efb8b4b67b4bc9584c12efcfec3917cf9b759bc2e57ae3780a7c0e73f82c4 fail_time:1662380360
026fcbc477870d95970778154628a3974e2f2c61a5aac6af86ea6c9a8899dcbf17 03cd1e1f6df1893fde301c6ef4ec91b3e68530c75377bcbd5a6e74019254b8f8c1 fail_time:1662380360
03cd1e1f6df1893fde301c6ef4ec91b3e68530c75377bcbd5a6e74019254b8f8c1 026fcbc477870d95970778154628a3974e2f2c61a5aac6af86ea6c9a8899dcbf17 fail_time:1662380360

This test confirms that a node gets blacklisted with RequiredNodeFeatureMissing, removing channels A-C, C-D, but not B-C. Will try to send repeated payments into a bigger network.


[Bug] Rerunning /describe after adding new changes does not always update the "PR Main Files Walkthrough" section

I've been noticing that re-running the /describe operation through Github issue comments is not updating the "PR Main Files Walkthrough" section whereas it seems to update the description each time if there are new changes. I didn't try to trace the root cause yet but this is particularly noticeable if you commit a change to a file that is entirely removed in a subsequent commit on the same branch.

Thanks for the feedback.
I Think this happens because we (@zmeir  :-) ) are adding the previous description to the prompt, and it can confuse the model.
I think I will add an option to fully ignore the previous description, and it will help this kind of scenario

Interesting find. I think we can address this by only using the original user description for the describe prompt instead of using the whole PR-Agent generated description.
@mrT23 if you think that's a good approach I can try working on it. I don't think it should be too complicated.

@mrT23 --> #260


Word Press Plugin issue with MCW

Screenshot or description
Unable to disable [Users must be registered and logged for access wallet.]
Steps to reproduce

steps
to
reproduce

Environment

Domain: doecoins.com
Mainnet or Testnet: Main
Browser: Brave
OS: Mac

Your version

[X ] latest
[ ] not latest (please try to upgrade first)
[ ] not sure

Does this affect atomic swap flow?

[X ] yes
[ ] no

Are real funds at risk?

[ ] yes
[X ] no

@geopayme please, check this issue...


"autometrics": executable file not found

Hello, and thanks for the interesting project. I actually heard about it from Evan at Berline.rs meetup.
I'm trying to add this to my project, but it looks like i need the 'autometrics' binary, but neither readme  specify how to actually install it, nor releases contain any binaries.
Can you please explain/link - how to get the binary the go generate command runs?
❯ go generate ./...
server/api/v1/server_api_v1.go:3: running "autometrics": exec: "autometrics": executable file not found in $PATH

❯ go version
go version go1.19.2 linux/amd64

yeah, thanks Gerry!
I've actually cloned the repo, built the binary and put it to PATH, then it worked.
your suggested go install method is a bit easier, indeed :-D