[Android] compileSdkVersion=33 prevents build

Environment
Library version: 2.4.6
OS version: Android 12
Affected platforms

[X] Android
[ ] iOS

Current behavior
Does not build on android
Error messages :

Task :react-native-avoid-softinput:compileDebugKotlin FAILED

node_modules/react-native-avoid-softinput/android/src/main/java/com/reactnativeavoidsoftinput/AvoidSoftInputManager.kt: (310, 11): 'onAnimationEnd' overrides nothing
Type mismatch: inferred type is Animator? but Animator was expected
Expected behavior
should build on android with compileSdkVersion=33
Reproduction
https://github.com/oliviermtl/avoid-softinput

Hi @oliviermtl, this issue is fixed from v2.4.7 🚀

This issue still crops up on React Native 0.70.2 and Plugin version 3.0.1 with compileSdkVersion=33.
I am getting the error while trying to build a release bundle.
`> Task :react-native-avoid-softinput:compileReleaseKotlin FAILED
e: /Users/inocentum/Developer/ReactNativeProjects/event_gravity_hybrid_app/node_modules/react-native-avoid-softinput/android/src/main/java/com/reactnativeavoidsoftinput/animations/AnimationHandlerImpl.kt: (86, 11): 'onAnimationEnd' overrides nothing
e: /Users/inocentum/Developer/ReactNativeProjects/event_gravity_hybrid_app/node_modules/react-native-avoid-softinput/android/src/main/java/com/reactnativeavoidsoftinput/animations/AnimationHandlerImpl.kt: (87, 34): Type mismatch: inferred type is Animator? but Animator was expected
FAILURE: Build completed with 2 failures.`

Hi @arnabJ , would you be able to make a PR with the fix for v3?

I have made a PR with the fix: #117

Hi @arnabJ , would you be able to make a PR with the fix for v3?

Hi, @mateusz1913 I have made a PR with the fix.

Thanks @arnabJ for your contribution! The fix is available in v3.0.2 🎉

@hadnet check out how to modify kotlin version - https://mateusz1913.github.io/react-native-avoid-softinput/docs/guides#troubleshooting


Kubernetes 0.25.6

Changes
Bump Kubernetes version to 0.25.6
Bump onsi/gomega and google/go-containerregistry packages
Submitter Checklist

[x] Includes tests if functionality changed/was added
[x] Includes docs if changes are user-facing
[ ] Set a kind label on this PR
[x] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
Bump Kubernetes version to 0.25.6
Bump onsi/gomega and google/go-containerregistry packages

/kind dependency-update

/kind /dependency-change


Remove VWO and add Optimize cookies to list

VWO no longer used and Google optimize will be used instead. Allow-list updated accordingly.

Missed a cookie...


Potential column issues

When opening a file (and at other moments), the width of the columns (or sometimes of 1 column) gradually narrows.
The last header name is sometimes not visible

This was fixed in #46 and the recent commit. I will close this issue


Renamed swift::types to swift::file_types.

Per @jrose-apple suggestion, renamed swift::types to swift::file_types, because it is now in the Frontend, not just the Driver.

@swift-ci please smoke test

@swift-ci please smoke test linux platform

@swift-ci please test compatibility

@swift-ci please test source compatibility

@swift-ci please smoke test

@swift-ci please smoke test linux platform


refactor/ledger key agent upgrade

Context
The existing implementation had quite a lot of technical debt due to the mapping back and forth through CML to be compatible, and this complexity has hidden bugs due to the large function that does not have adequate unit test coverage. It is also obscuring the fact we are lacking support for some more recent features of Cardano.
Proposed Solution
We should extract the vendor-specific implementation to their own SDK packages. The benefits are:

updates from one vendor do not impact the others, particularly useful for breaking change isolation.
applications that are not implementing tree shaking get the benefit of cleaner separation
Cleaner approach to rolling out specific vendor support in products.

Important Changes Introduced

A new package with a new implementation of the ledger hardware wallet mappings was added.

@iadmytro is going to review and also take a look at the issue of needing to run both Ledger and Trezor tests together, as that's the main issue I have now they're separated. I edited my above comment  with a correction


RqPrint.java:41-43: This class should implement Text in...

The puzzle 984-b6700210 from #984 has to be resolved:
https://github.com/yegor256/takes/blob/ef29898cc602dcffc7a52498b59cce7dbdea3917/src/main/java/org/takes/rq/RqPrint.java#L41-L43
The puzzle was created by andreoss on 23-Jun-20.
Estimate: 30 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@paulodamaso/z please, pay attention to this issue

The puzzle 984-b6700210 has disappeared from the source code, that's why I closed this issue.

Job gh:yegor256/takes#1055 is not assigned, can't get performer


Update stable version in repo from 1.16.0 to 2.0.1

Think about update stable version to 2.0.1
Version: stable=1.16.0 (132 days old) => latest=2.0.1 (15 days old)
Installs: stable=12434 (63.35%), latest=1489 (7.59%), total=19626
Click to use developer portal
Click to edit
Note: This is an automatically generated message and not personally authored by bluefox!

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 2.0.1 but the current stable version is already 2.0.1.
So this issue should be closed.


How to use MTIAsyncVideoCompositionRequestHandler to set duration for filters?

Checklist

[x] I've read the README
[x] I've searched for existing GitHub issues

To the developers, team(s) and contributors to this awesome framework thanks for putting this together!
To do post processing on video files I noticed that the following class MTIAsyncVideoCompositionRequestHandler among others was used in this demo project file "VideoProcessorViewController.swift".
Question
What is the most efficient way to specify a specific duration for a filter?
The hack below does work but it's not in-sync with video file.
I'm opened to other approaches or suggestions.
Thanks in advance!
Without FilterGraph
...
//Some Asset
let someAsset: AVAsset = ...

//Declare filter
let blendFilter = MTIBlendFilter(blendMode: .normal)

//Overlay caption Image
let overlayCaptionImage = MTIImage(cgImage: someImageText!.cgImage!, options: [.SRGB: false], isOpaque: true)

//End duration
let endDuration: Double = 5.0

//Video composition handler
let handler = MTIAsyncVideoCompositionRequestHandler(context: context, tracks: asset.tracks(withMediaType: .video)) { [weak self] request in
      guard let `self` = self else { return request.anySourceImage }

      //Set background image
      blendFilter.inputBackgroundImage = request.anySourceImage

      //Get current frame timestamp
      let currentFrameTimestamp = Double(request.compositionTime.seconds)

      //Apply overlay caption
      if (currentFrameTimestamp >= 1.8) {
         self.blendFilter.inputImage = overlayCaptionImage
      }

      //Remove overlay caption
      if (currentFrameTimestamp == endDuration) {
         self.blendFilter.inputImage = MTIImage.transparent
      }
}

let composition = VideoComposition(propertiesOf: someAsset, compositionRequestHandler: handler.handle(request:))
...

Yes, use the request.compositionTime. However it's better to use >= & <= with times. For example:
if request.compositionTime.seconds > 1.8 && request.compositionTime.seconds < 5.0 {
    self.blendFilter.inputImage = overlayCaptionImage
    self.blendFilter.inputBackgroundImage = request.anySourceImage
    return self.blendFilter.outputImage
} else {
    return request.anySourceImage
}

Another approach would be using the concept of FilmStrip from https://github.com/IFTTT/RazzleDazzle/blob/830956a4d292018dd146af2bf3a4afcc230f13ad/Source/Filmstrip.swift#L30
For example, you can use it to fade in the caption at 1.5s and fade out the caption at 5.0s:

Create a filmstrip and add key frames (time: 0, value: 0), (time: 1.5, value: 0), (time: 1.8, value: 1), (time: 5.0, value: 1), (time: 5.3, value: 0)
Use valueAtTime(request.compositionTime.seconds) to get the value and use it as the intensity of the blend filter.

@YuAo thanks for immediate response.
The conditional approach suggested would certainly work.
I'll check out the other approach suggested and let you know with a code update, so that this post can help someone else.
Thanks again.

@YuAo Thanks again for the suggestion. In keeping with the principle of self containment, I opted do it without additional classes or framework.
For people requiring a way to add captions/subtitles/images to video file using the MetalPetal framework.
This is one approach:
With only one image asset to blend
...
//Assuming you have your assets ready and available

//Some video file
let someVideoFile: AVAsset = ...

//Declare filter
let blendFilter = MTIBlendFilter(blendMode: .normal)

//Overlay caption Image
let overlayCaptionImage = MTIImage(cgImage: someImageText!.cgImage!, options: [.SRGB: false], isOpaque: true)

//Caption timestamp
//This value is dependent on the timescale used from CMTime
//Be sure to round timestamp value to your needs see below for
//simple rounding function
let captionTimestamp: Double = 1.8

//End duration
//This value is dependent on the timescale used from CMTime
let endDuration: Double = 5.0

//Video composition handler
let handler = MTIAsyncVideoCompositionRequestHandler(context: context, tracks: someVideoFile.tracks(withMediaType: .video)) { [weak self] request in
      guard let `self` = self else { return request.anySourceImage }

      //Get current frame timestamp
      let currentFrameTimestamp = roundedTimestamp(timestamp: Double(request.compositionTime.seconds), nodp: 1.0)

      //Applying equality guarantees filter starting at the exact timestamp preferred
      if (currentFrameTimestamp == captionTimestamp && currentFrameTimestamp < endDuration) {

         //Set background image
         blendFilter.inputBackgroundImage = request.anySourceImage

         //Apply overlay caption
         self.blendFilter.inputImage = overlayCaptionImage
         return self.blendFilter.outputImage
      } else {
         return request.anySourceImage
      }

}

let composition = VideoComposition(propertiesOf: someVideoFile, compositionRequestHandler: handler.handle(request:))

With multiple images asset to blend
To use the code below simply create a new file in your project directory and make changes where necessary in the code
Though, it's not thoroughly tested but it's a starting point.
import Foundation
import UIKit
import MetalPetal
import Photos

///////////////////////////////////
//MARK: Class: LineDebugger
//Use: Tracking down error location in file
///////////////////////////////////
class LineDebugger{

    class func line(_ message: String,
                   function: String = #function,
                   file: String = #file,
                   line: Int = #line) {
        var filename = file
        if let match = filename.range(of: "[^/]*$", options: .regularExpression) {
            filename = String(filename[match])
        }
        print("\(Date().timeIntervalSince1970):\(filename):L\(line):\(function) \"\(message)\"")
    }

}

///////////////////////////////////
//MARK: FILE: OverlayImageViewController
//Use:
//Overlay image(s) over some video file.
//Though, not thoroughly tested for completeness
//but its a start for anyone looking to implement this feature
///////////////////////////////////
class OverlayImageViewController: UIViewController {

    //MARK: Class: ImageObject
    class ImageObject {
        var id: Int? // If required
        var used: Bool? = false
        var endAt: Double?
        var image: MTIImage?
        var size: CGSize?
        var xy: CGPoint?
        var positionInComposite: Int?
    }

    //MARK: Class: UsedImageObject
    class UsedImageObject {
        var id: Int? // If required
        var used: Bool? = false
        var positionInComposite: Int?
    }

    //MARK: Dictionary: imagesArray
    var imagesArray = [Double: ImageObject]()

    //MARK: Dictionary: useImagesArray
    var useImagesArray = [Double: UsedImageObject]()

    //MARK: weak variables
    private var bundle: Bundle? = nil
    private var asset: AVAsset?
    private var videoComposition: VideoComposition<BlockBasedVideoCompositor>?
    private var context: MTIContext!
    private var compositeLayerFilter: MTIMultilayerCompositingFilter!
    private var exporter: AssetExportSession?

    //MARK: ui-container: bundle
    let containerView: UIView = {
        let v = UIView(frame: screenSize)
        return v
    }()

    //MARK: Function: generateImageFromUIView
    //Use: Generate image from uiview
    fileprivate func generateImageFromUIView(_ view: UIView) -> UIImage {

        let opaque = false

        UIGraphicsBeginImageContextWithOptions(view.bounds.size, opaque, 0.0)
        view.layer.render(in: UIGraphicsGetCurrentContext()!)
        let img: UIImage = UIGraphicsGetImageFromCurrentImageContext()!
        UIGraphicsEndImageContext()
        return img
    }

    //MARK: Function: roundedTimestamp
    //Use: Return a given number of decimal places (nodp)
    fileprivate func roundedTimestamp(timestamp: Double, nodp: Double) -> Double {

        let multiplier = pow(10.0, nodp)
        let num = timestamp
        let rounded = round(Double(num) * multiplier) / multiplier
        return rounded
    }

    //MARK: Function: createNewLayer
    //Use: Create and add MTILayer to MTIMultilayerCompositingFilter
    fileprivate func createNewLayer(image: String, xy: CGPoint, sz: CGFloat, beginAt: Double, endAt: Double) {
        let v = UIImageView(frame: CGRect(x: xy.x, y: xy.y, width: sz, height: sz))
        v.image = UIImage(named: image)

        self.containerView.addSubview(v)

        let imageOverlay = self.generateImageFromUIView(self.containerView)
        let ciImageOverlay = CIImage(cgImage: imageOverlay.cgImage!)
        let mtiImageOverlay = MTIImage(ciImage: ciImageOverlay, isOpaque: true)

        let clayer = MTILayer(content: mtiImageOverlay, layoutUnit: .pixel, position: CGPoint(x: 720/2, y: 1280/2), size: CGSize(width: 720, height: 1280), rotation: 0, opacity: 0, blendMode: .normal)

        self.compositeLayerFilter.layers.append(clayer)

        //Get position for layer composite
        let pos = self.compositeLayerFilter.layers.count-1

        let oi = ImageObject()
        oi.id = 1
        oi.used = true
        oi.endAt = endAt
        oi.image = mtiImageOverlay
        oi.size = CGSize(width: 720, height: 1280)
        oi.xy = CGPoint(x: 720/2, y: 1280/2)
        oi.positionInComposite = pos

        self.imagesArray[beginAt] = oi

        self.containerView.subviews.forEach { $0.removeFromSuperview() }
    }

    //MARK: Function: createNewLayer
    //Use: Turn-on opacity for previously added MTILayer
    //Though, we have to create a new MTILayer given that
    //the opacity variable in the MTILayer class is readonly
    fileprivate func showLayerFilter(f: ImageObject) {
          let cl = MTILayer(content: f.image!, layoutUnit: .pixel, position: f.xy!, size: f.size!, rotation: 0, opacity: 1, blendMode: .normal)
          self.compositeLayerFilter.layers[f.positionInComposite!] = cl
        let count = self.compositeLayerFilter.layers.count
        LineDebugger.line("count: \(count) - ok")

    }

    //MARK: Function: hideLayerFilter
    //Use: Turn-off opacity for previously added MTILayer
    //Again, we have to create a new MTILayer given that
    //the opacity variable in the MTILayer class is readonly
    fileprivate func hideLayerFilter(positionInComposite: Int) {

        let cl = MTILayer(content: MTIImage.transparent, layoutUnit: .pixel, position: CGPoint(x:0, y:0), size: CGSize(width:0, height:0), rotation: 0, opacity: 0, blendMode: .normal)
        self.compositeLayerFilter.layers[positionInComposite] = cl
        let count = self.compositeLayerFilter.layers.count
        LineDebugger.line("count: \(count) - ok")

    }

    //MARK: Function: processAVAsset
    //Use: Converts individual video frames to metal textures,
    //and apply given filter(s)
    fileprivate func processAVAsset(asset: AVAsset) {

        self.context = try! MTIContext(device: MTLCreateSystemDefaultDevice()!)

        let handler = MTIAsyncVideoCompositionRequestHandler(context: context, tracks: asset.tracks(withMediaType: .video)) { [weak self] request in
            guard let `self` = self else {
                return request.anySourceImage
            }

            self.compositeLayerFilter.inputBackgroundImage = request.anySourceImage
            let sec = CMTimeGetSeconds(request.compositionTime)
            let beginAt = self.roundedTimestamp(timestamp: Double(sec), nodp: 1.0)
            let endAt = beginAt

            if self.imagesArray.count > 0 {
                //Overlay Image
                let oi = self.imagesArray[beginAt]
                if oi != nil {
                    if oi!.used! {
                        LineDebugger.line("beginAt: \(beginAt) - count: \(self.imagesArray.count)")
                        let ue = UsedImageObject(); ue.id = oi!.id!; ue.used = true;
                        ue.positionInComposite = oi!.positionInComposite!
                        let endAt = oi!.endAt!
                        self.useImagesArray[endAt] = ue

                        self.showLayerFilter(f: oi!)
                        self.imagesArray[beginAt]!.used = false
                    }
                }
            }

            if self.useImagesArray.count > 0 {
                //Used overlay Image
                let uoi = self.useImagesArray[endAt]

                 if uoi != nil {
                    if uoi!.used! {
                        LineDebugger.line("endAt: \(endAt) - count: \(self.useImagesArray.count)")
                        self.hideLayerFilter(positionInComposite: uoi!.positionInComposite!)
                        self.useImagesArray[endAt]!.used = false
                    }
                 }
            }

            return self.compositeLayerFilter.outputImage!
        }
        let composition = VideoComposition(propertiesOf: asset, compositionRequestHandler: handler.handle(request:))

        self.asset = asset
        self.videoComposition = composition
        self.processVideoComposite()
    }

    //MARK: Function: processVideoComposite
    //Use: Processed video composite
    fileprivate func processVideoComposite() {
        guard let asset = self.asset, let videoComposition = self.videoComposition else {
            return
        }

        let fileManager = FileManager()
        let outputURL = URL(fileURLWithPath: NSTemporaryDirectory()).appendingPathComponent("temp.mp4")
        try? fileManager.removeItem(at: outputURL)

        var configuration = AssetExportSession.Configuration(fileType: AssetExportSession.fileType(for: outputURL)!, videoSettings: .h264(videoSize: videoComposition.renderSize), audioSettings: .aac(channels: 2, sampleRate: 44100, bitRate: 128 * 1000))
        configuration.videoComposition = videoComposition.makeAVVideoComposition()
        let exporter = try! AssetExportSession(asset: asset, outputURL: outputURL, configuration: configuration)
        exporter.export(progress: { p in
            //Progress checker
            //Uncomment this to get pecentile progress
            //print("progress: \(p.localizedDescription!)")
        }, completion: { error in
            self.saveToDeviceLibrary(url: outputURL)
        })
        self.exporter = exporter
    }

    //MARK: Function: processVideoComposite
    //Use: Save processed video file to device library
    fileprivate func saveToDeviceLibrary(url: URL) {

        PHPhotoLibrary.shared().performChanges({
            PHAssetChangeRequest.creationRequestForAssetFromVideo(atFileURL: url)
        }, completionHandler: { success, error in
            if success {
                LineDebugger.line("processed video saved")
                self.exporter = nil
            }
            else {
                LineDebugger.line("erroring saving...!")
            }
        })
    }

    //MARK: Function: processVideoComposite
    //Use: Append to MTILayer to compositeLayerFilter
    fileprivate func addCompositeLayers() {
        //1
        let beginAt1: Double = 2.5
        let duration1: Double = 3.0
        //Replace image string with your desired image
        self.createNewLayer(image: "chicken_drumstick", xy: CGPoint(x: 10, y: 100), sz: 190, beginAt: beginAt1, endAt: beginAt1+duration1)

        //2
        let beginAt2: Double = 4.0
        let duration2: Double = 3.8
        //Replace image string with your desired image
        self.createNewLayer(image: "chicken_bucket", xy: CGPoint(x: 40, y: 120), sz: 150, beginAt: 4.0, endAt: beginAt2+duration2)
    }

    //MARK: PRESENTATION: viewDidLoad
    //Use: Present ui
    override func viewDidLoad() {
        super.viewDidLoad()
        print("Loaded!")
        view.backgroundColor = .white

        self.compositeLayerFilter = MTIMultilayerCompositingFilter()

        self.addCompositeLayers()

        self.bundle = Bundle(for: type(of: self))
        let url = self.bundle?.url(forResource: "video_22", withExtension: "mp4")

        let asset = AVURLAsset(url: url!)
        self.processAVAsset(asset: asset)

    }
}

Hey, @rainc   Please can you explain me how to use this class.

@akshpreet-singh I'm not sure I understand what you are asking?
If you are looking for an example of how to set duration of a filter? An example has already been provided (here).
If that is not clear, create a project that gives an idea of what you are trying to do. This way, the help provided should hopefully clear things up for you.


Support for HmIP-MOD-HO (Hoermann Module)

This pull request:

adds support for HomeMatic IP device: HmIP-MOD-HO

Existing class: IPGarage

The device documentations for HmIP-MOD-TM and HmIP-MOD-HO are identical.

Thanks. 👍


[Feature Request] provide an option to get the build artifacts and download them to the local machine

I’m trying to get the build artifacts and download them using the Azure DevOps CLI.  I can get my specific build result using a command similar to this one:
az pipelines build show --id 171nnn --organization https://myteam.visualstudio.com --project myproject --detect off
Even though there are two artifacts in the azure devops UI for this build I can’t find any command that seems to help me discover and download them.  I tried “az artifacts” but it didn’t seem to have the right set of options to list these 2 artifacts. None of the “az pipelines” options seemed to show it either.  Can someone point me to the correct command?

https://github.com/Microsoft/azure-devops-cli-extension/issues/81

Thanks for the pointer.  I'd prefer a solution that uses the devops extension instead of relying on the rest APIs.  It's  a lot easier to authenticate using the Azure CLI vs. having to keep track of a PAT.  Hoping this feature can be added to this extension.

@geverghe : Should this be closed as a dupe?

Yes. Closing it as duplicate to #81

The request is to be able to use Azure DevOps CLI vs. the REST interfaces.  I don't believe this is a duplicate.  Otherwise all of the Azure DevOps CLI is a duplicate too since there's already an equivalent set of REST APIs.

The request is to be able to use Azure DevOps CLI vs. the REST interfaces. I don't believe this is a duplicate. Otherwise all of the Azure DevOps CLI is a duplicate too since there's already an equivalent set of REST APIs.

@DonFrazier : https://github.com/Microsoft/azure-devops-cli-extension/issues/81 is tracking the same feature request, i.e. provide support in CLI to list and download build artifacts and that is why this is closed as dupe.
we did not closed this issue as dupe because build artifacts can be downloaded via REST API.
I would request you to follow/ collaborate at https://github.com/Microsoft/azure-devops-cli-extension/issues/81 for this feature request.

Ok.  I thought the suggestion at #81 was "use the REST APIs" but I see that was just a workaround to get the requested info.  My bad.  Looking forward to this feature shipping.


Update PHP 5.5 repository URL

Current PHP 5.5 repository URL does not exist, It is now being updated to a new URL.
Old URL : http://windows.php.net/downloads/releases/php-5.5.30-Win32-VC11-x86.zip
New URL : http://windows.php.net/downloads/releases/php-5.5.31-Win32-VC11-x86.zip

@lukesampson What do you think about moving this (and others) to the versions bucket?

I think that's a good idea, @deevus.

@sasindu555 Can you reopen this PR here: https://github.com/scoopinstaller/versions ?
I'm going to remove these suffixed versions from the main bucket

@deevus I created a PR in https://github.com/scoopinstaller/versions


Provide option to view Secret Key from index

If the user navigates to the Blockstack App's homepage / index, we can show an option to "View Secret Key" that displays it again for them, since currently we have no way for the user to review it should they have failed to persist it during onboarding but maintain a session.
And add option to choose account screen to get here.

Design: https://www.figma.com/file/aXnNi8MOmN3CDrVwaDXXuqX3/Product?node-id=7265%3A146

Broken image icon in the top left corner

Good catch @timstackblock - I've pushed a fix to prod, please confirm on your end :+1:

Works for me :-)


Fix armv7 bug in Xcode 12 by dropping iOS 10

There is an bug in Xcode 12 (at least until b2) that removes some needed symbols in the armv7 slice while building for release (e.g. with Carthage). The easiest workaround ist to drop armv7 (i.e. 32 bit support) by increasing the deployment target to iOS 11.
This bug is hopefully fixed in a later (beta) release of Xcode 12. I only recommend it as a temporary workaround unless you don't support any iOS version lower than iOS 11.
Thus I don't recommend merging this. I just push it here for visibility.
See https://developer.apple.com/forums/thread/649918
If you want to use this in Carthage use:
github "fossil12/PunycodeSwift" "xcode12-armv7-fix"

This is resolved with beta 4


Support OpenSUSE Tumbleweed

https://tailscale.com/kb/1047/install-opensuse-tumbleweed/

Initial support in #256 , container in https://github.com/artis3n/docker-opensuse-ansible/pkgs/container/docker-opensuse-tumbleweed-ansible


"Tichilești" is listed in the drop-down menu

Description:
"Tichilești" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Șuțești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Tichilești, Brăila (Tichilești)".

Nu e duplicat, unul este comuna iar celalalt este satul resedinta de comuna cf. legii.


[Autocomplete] onChange has wrong type signature with freeSolo and multiple

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
As for now, type signature for onChange event handler says that newValue property should be of type T[]:
https://github.com/mui-org/material-ui/blob/a0ab3dfe280bca88758b8e9bac26fec4847793e6/packages/material-ui-lab/src/useAutocomplete/useAutocomplete.d.ts#L190
while we can have a mixed array of T and string when we add a new value via 'freeSolo' capability.

Expected Behavior 🤔
Proper newValue type signature. Plus I suspect there can be other type collisions in other places.

Your Environment 🌎

Tech
Version

Material-UI
v4.9.4

React
v16.12.0

Browser
Chrome

TypeScript
v3.8.2

Please include the code that is currently rejected by TypeScript.

This sounds like a duplicate of #19484.

https://codesandbox.io/s/eager-blackwell-1vfve?fontsize=14&hidenavigation=1&theme=dark

@oliviertassinari the cause of both issues are definitely the same.
@eps1lon I encounter no TypeScript errors, but the typing of method is misleading, because the actual value provided by component in onChange handler is not compatible with it's type signature. @akharkhonov's example properly illustrates this issue.

I had similar problem with types for autocomplete.

for some reason the null after T appears. but why if we always get the new value?

@OlegBrony The input can be cleared.

@gmltA Actually, I think that this issue and #19484 are different.
@OlegBrony comment is also accurate. While the freeSolo prop means the new value can be a string, disableClearable={true} + multiple={false} prevents the presence of null in
https://github.com/mui-org/material-ui/blob/a0ab3dfe280bca88758b8e9bac26fec4847793e6/packages/material-ui-lab/src/useAutocomplete/useAutocomplete.d.ts#L215
I have no idea how this should be best accounted for.

It is possible to address this using the same type mapping approach from https://github.com/mui-org/material-ui/pull/20949 to exclude null from value type when disableClearable is true.
@oliviertassinari I can work on that as a next step if you think the approach from PR makes sense.


docs(content/en/docs/releases/feature_lifecycle.md): add API deprecat…

…ion details
Signed-off-by: Zach Rhoads<EMAIL_ADDRESS>Add policy details around how and when APIs may be deprecated or removed.
fixes #360

@trstringer let me know what you think

@steeling you probably have some thoughts on this


No aks version specified so example fails on deployment.yml

When following the example documentation for azure environments deployments the Deploy to Kubernetes cluster step will fail on the error

no matches for kind "Deployment" in version "apps/v1beta1"

which is due to the default aks version as of time of writing using kubernetes 1.16 which takes Deployment out of version apps/v1beta1 and into apps/v1
kubernetes versions have been updated making the ./manifests/deployment.yml out of date. it currently
Workaround
update the ./manifests/deployment.yml to reference apps/v1 instead of apps/v1beta1 adn add a selector field that matches the template metatdata label. example:
#./manifests/deployment.yml
apiVersion : apps/v1
kind: Deployment
metadata:
  name: raboleypipelinesjavascriptdocker
spec:
  replicas: 1
  selector:
    matchLabels:
      app: raboleypipelinesjavascriptdocker
  template:
    metadata:
      labels:
        app: raboleypipelinesjavascriptdocker
    spec:
      containers:
        - name: raboleypipelinesjavascriptdocker
          image: rabenvcr.azurecr.io/raboleypipelinesjavascriptdocker
          ports:
          - containerPort: 8080

Fix
Pin the version the kubernetes cluster will use, and then update the Deployment version to whatever works in that version. and update the deployment.yml example manifest generated to use the correct syntax.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cbceb1f5-05c3-487d-6e21-dc1b4936a55c
Version Independent ID: 35355737-9ad9-9df5-b612-806d9df2462b
Content: Deploy to Azure Kubernetes Service - Azure Pipelines
Content Source: docs/pipelines/ecosystems/kubernetes/aks-template.md
Product: devops
Technology: devops-cicd-ecosystems
GitHub Login: @azooinmyluggage
Microsoft Alias: atulmal

I have raised a fix to the azure devops template so that the starter template creates an updated apps/v1 deployment. It will take a around two weeks to rollout to all regions. I have also a raised a fix on the docs page itself. @msebolt can we close this issue?


Alternative link for missing courses

The two courses Software Testing and Software Debugging are not present in Udacity.
Although the link works, the courses can't be accessed in the classroom.
Hence to fix this issue, I suggest we pick this course from Georgia Tech to replace the missing courses.

Hi, this is a substantive change to the curriculum. As such, there should be an RFC for it. Please open such an issue. There is a template to help structure RFCs.

It looks like they changed the URL from classroom to learn so it redirects the classroom URLs to a more generic front page kind of thing, where you have to click on "Free Courses" and then browse to find the course.
The courses are still there:

Although I'm not sure if someone who isn't already logged-in to Udacity and enrolled in the course can directly access it with the links https://learn.udacity.com/courses/cs258 and https://learn.udacity.com/courses/cs259 or if it still redirects.
Could someone other than myself try those links?

I tied both links not logged in. Just took me to a login screen. Tried again after logging in and took me to a explore page but not to the specific course.
Hope this helps.
On Jun 11, 2022, at 3:16 PM, spamegg @.***> wrote:

It looks like they changed the URL from classroom to learn so it redirects the classroom URLs to a more generic front page kind of thing, where you have to click on "Free Courses" and then browse to find the course.
The courses are still there:
Although I'm not sure if someone who isn't already logged-in to Udacity and enrolled in the course can directly access it with the links https://learn.udacity.com/courses/cs258 and https://learn.udacity.com/courses/cs259 or if it still redirects.
Could someone other than myself try those links?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Right, I was afraid that's the case. So it's not possible to give a direct link, but we'd have to describe the steps how to get there instead. Not sure what's the best solution.


Bug when Internet Down during session

Issue Type: Bug
When my inernet connection down, I can't re-connect to the same session and the host can't call-me back again
Extension version: 1.0.2274
VS Code version: Code 1.45.1 (5763d909d5f12fe19f215cbfdd29a91c0fa9208a, 2020-05-14T08:27:22.494Z)
OS version: Linux x64 4.19.125-1-MANJARO

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz (4 x 3099)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: disabled_off_okvideo_decode: unavailable_offviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
6, 4, 3

Memory (System)
15.55GB (0.58GB free)

Process Argv
--no-sandbox --unity-launch

Screen Reader
no

VM
0%

DESKTOP_SESSION
deepin

XDG_CURRENT_DESKTOP
Deepin

XDG_SESSION_DESKTOP
deepin

XDG_SESSION_TYPE
x11

Does the issue reproduce when the host starts a new session? Or you only cannot re-connect to the existing session after the network re-connected?

Does the issue reproduce when the host starts a new session? Or you only cannot re-connect to the existing session after the network re-connected?

No @IlyaBiryukov , I only can't re-connect to the existing session after the network re-connected. My host needs to stop the current session and start a new session to call-me back again.

We cannot reproduce the issue. Your logs may provide us with helpful information. If you reproduce the issue again, you can find your logs in the $TEMP/VSFeedbackVSRTCLogs directory. You can email them to<EMAIL_ADDRESS>or attach to this issue.

Closing due to age. Please feel free to reactivate with more details so we can repro the problem!


[stable/nginx-ingress] support for custom headers as a Configmap

I Added support for a custom header for Nginx-Ingress per this example: https://github.com/kubernetes/ingress-nginx/tree/master/docs/examples/customization/custom-headers
The Chart will create a custom header Configmap if controller header is present and reference to it in the controller ConfigMap

/assign @scottrigby

/ok-to-test

/lgtm


Remove "server" feature(s)

The server features should be split off into a separate crate before releasing version 1.0. This might require to extract shared code into a separate crate.

I am actively investigating using this library in projects as both a client and a server.
I agree that extracting the TCP server stuff into a separate crate would be cleaner.  I would be interested in perhaps writing some examples/documentation or other ways of contributing to help the project.

This might require to extract shared code into a separate crate.

how about tokio-modbus-server?

... or probably we even create a new "namespace" and split it like this:

core: nostd compatible like modbus-core
tokio: general foundation for tokio based usage
client: convenient implementations & utilities for clients
server: convenient implementations & utilities for servers

When trying to implement a server library, it seems it would be useful to describe some concrete use cases for the server.
This would direct the design of the API and consequently the implementation of the server as well.
Kind of like in test-driven development, or having a real user as a customer, some simple example applications would both help direct the development of an API, and also would give library users an example of how to use the library.
Some things I'm thinking about:

What kind of applications are people going to use the Modbus server library for?
How will users handle concurrent requests from multiple clients?

Are you discussing splitting the current crate into multiple smaller ones in the existing repository or create multiple smaller repos, one for each crate?

I find the server feature helpful for integration testing, personally, which is how I put it to use.

I find the server feature helpful for integration testing, personally, which is how I put it to use.

Agreed, it is useful in many contexts.  I think the change is to create a new tokio-modbus-server crate, which uses the core tokio-modbus crate but adds the server-specific stuff.
It makes more sense than shoving into a single crate with a feature flag... the server itself might evolve at a different pace from the core Modbus functionality that a client would need, so decoupling them makes sense.


Add progress bar to the application

Add a progress bar in the application. This progress bar has been added to the MiningPipeline.
The progress bar wraps the iterable and every time an iteration is done the progress of the progressbar is updated.
A progress bar has also been added to the TestGenerator class. I'm a bit on the fence as to whether this is necessary as EvoSuite does have its own progress bar. However, a problem is that we buffer the ouput, meaning that EvoSuite's own progress bar is not displayed properly.

Codecov Report

Merging #301 into master will decrease coverage by 0.5%.
The diff coverage is 57.69%.

@@             Coverage Diff              @@
##             master     #301      +/-   ##
============================================
- Coverage     80.46%   79.95%   -0.51%
- Complexity      536      636     +100
============================================
  Files            69       82      +13
  Lines          1602     1946     +344
  Branches        254      306      +52
============================================
+ Hits           1289     1556     +267
- Misses          213      271      +58
- Partials        100      119      +19

Impacted Files
Coverage Δ
Complexity Δ

...line/testgenerator/jimpleevosuite/TestGenerator.kt
100% <100%> (ø)
3 <0> (ø)
:arrow_down:

.../cafejojo/schaapi/miningpipeline/MiningPipeline.kt
62.06% <37.5%> (-12.29%)
6 <2> (+1)

...otlin/org/cafejojo/schaapi/CommandLineInterface.kt
79.34% <50%> (-1.34%)
0 <0> (ø)

...dationpipeline/githubtestreporter/CheckReporter.kt
81.81% <0%> (ø)
5% <0%> (?)

...e/githubtestreporter/githubapi/CustomHttpClient.kt
18% <0%> (ø)
3% <0%> (?)

...tionpipeline/githubtestreporter/AppKeyGenerator.kt
93.75% <0%> (ø)
3% <0%> (?)

.../githubtestreporter/githubapi/JsonObjectBuilder.kt
100% <0%> (ø)
3% <0%> (?)

...e/githubtestreporter/GitHubCIJobProjectMetadata.kt
100% <0%> (ø)
2% <0%> (?)

.../githubtestreporter/githubapi/FuelConfiguration.kt
100% <0%> (ø)
1% <0%> (?)

...hubtestreporter/webhookevents/InstallationEvent.kt
83.33% <0%> (ø)
5% <0%> (?)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50164f4...3b15419. Read the comment docs.

 Create a progressbar


npm install -> gulp install error

I used the command npm install --save semantic-ui but after some download I receive this error in the file error.png. I've attached npm-debug.txt. How can I resolve the problem?
npm-debug.txt

Hi.
I've tried to track down your problem. No problems with Windows 10, Windows 7 with node v4.6.1 and Gulp CLI version 1.2.2 and Gulp Local version 3.9.1.
Which Gulp and Node version do you use?
Best regards, Micha

I'm on Ubuntu 14.04, node 6.6.0, Gulp CLI version 1.2.2 and Gulp Local version 3.9.1.
Could it be an issue with accord? I noticed that is the module that's throwing the error and on their github page their current build is failing.

Also of note, this issue doesn't occur with bower.

Gulp CLI global, version 3.9.1
Npm global, version 3.10.9
I should ever install a local version of gulp? When I've tried to install gulp locally (same version 3.9.1) I've got the same error..

This are step for semantic-ui installation on my windows 10:

md sui
npm init (with all default)
npm install --save-dev gulp
npm install --save semantic-ui

and this is the error:

No resolution??

+1 exact same issue

Liams-MBP:project liamcameron$ npm install semantic-ui
npm WARN excluding symbolic link tests/withsymlinks/.hidden -> ../shown/.hidden
npm WARN excluding symbolic link tests/withsymlinks/bar.txt -> ../shown/bar.txt
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to<EMAIL_ADDRESS>as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained. Upgrade to<EMAIL_ADDRESS>npm WARN excluding symbolic link tests/withsymlinks/.hidden -> ../shown/.hidden
npm WARN excluding symbolic link tests/withsymlinks/bar.txt -> ../shown/bar.txt
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g

<EMAIL_ADDRESS>install /Users/liamcameron/project/node_modules/semantic-ui
gulp install

[13:31:48] Using gulpfile ~/project/node_modules/semantic-ui/gulpfile.js
[13:31:48] Starting 'install'...
[13:31:51] 'install' errored after 2.69 s
[13:31:51] TypeError: gulp.hasTask is not a function
at /Users/liamcameron/project/node_modules/run-sequence/index.js:19:22
at Array.forEach (native)
at verifyTaskSets (/Users/liamcameron/project/node_modules/run-sequence/index.js:13:11)
at runSequence (/Users/liamcameron/project/node_modules/run-sequence/index.js:92:2)
at Gulp.module.exports (/Users/liamcameron/project/node_modules/semantic-ui/tasks/install.js:450:1)
at module.exports (/Users/liamcameron/project/node_modules/orchestrator/lib/runTask.js:34:7)
at Gulp.Orchestrator._runTask (/Users/liamcameron/project/node_modules/orchestrator/index.js:273:3)
at Gulp.Orchestrator._runStep (/Users/liamcameron/project /node_modules/orchestrator/index.js:214:10)
at Gulp.Orchestrator.start (/Users/liamcameron/project/node_modules/orchestrator/index.js:134:8)
at /Users/liamcameron/project/node_modules/semantic-ui/node_modules/gulp/bin/gulp.js:129:20
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN project No description
npm WARN project No repository field.
npm WARN project No license field.
npm ERR! Darwin 15.4.0
npm ERR! argv "/usr/local/bin/node" "/Users/liamcameron/.npm-packages/bin/npm" "install" "semantic-ui"
npm ERR! node v6.7.0
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: gulp install
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'gulp install'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the semantic-ui package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp install
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs semantic-ui
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls semantic-ui
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/liamcameron/project/npm-debug.log
Liams-MBP:project liamcameron$ npm -v
3.10.8
Liams-MBP:project liamcameron$ node -v
v6.7.0
Liams-MBP:project liamcameron$ gulp -v
[13:58:58] CLI version 1.2.2
[13:58:58] Local version 4.0.0-alpha.2

Upgraded gulp version, still receive error.
Liams-MBP:project liamcameron$ gulp -v
[14:01:41] CLI version 3.9.1
[14:01:42] Local version 4.0.0-alpha.2

Cool, i'm not alone.. No one have a solution?

I've the same issue
Node -v v7.1.0
Npm -v  3.10.9
Gulp -v
CLI version 3.9.1
Local version 3.9.1

Same problem. Haven't found a solution so far.

works with 7.2

works with 7.2

If anyone encounters this problem while using GIT BASH, just use widows terminal.
I was able to install semantic on

Windows 8.1, node 6.9.5, npm 3.10.10
WIndows 7, node 7.9.0, npm 4.2.0

In both cases, when using GIT BASH, I got errors similar to liam-cameron and abbiento

im still having this issue

I got it working by running all dependent packages under version specific gulp install:
npm install<EMAIL_ADDRESS>sparkles duplexify ansi-colors path-dirname semantic-ui --save

You might need to add more packages in a sequence if npm complains.

npm install<EMAIL_ADDRESS>semantic-ui --save worked for me for semantic-ui installation.
However, my Aurelia build required gulp 4. So I had to install version 4 again.

I have the same problem :

TypeError: gulp.hasTask is not a function
at C:\wamp64\www\blog\node_modules\run-sequence\index.js:23:22
...
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: gulp install
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

I use :

windows 7
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Problem solved !
Dont let the default directory (project folder) simply specify the node_modules folder and it will be okay nevermore the configuration.

Prroblem persists Arch Linux
><EMAIL_ADDRESS>install /home/neel/Projects/byakaran/web/packed/node_modules/semantic-ui
> gulp install

[16:57:30] Using gulpfile ~/Projects/byakaran/web/packed/node_modules/semantic-ui/gulpfile.js
[16:57:30] Starting 'install'...
[16:57:30] 'install' errored after 34 ms
[16:57:30] TypeError: gulp.hasTask is not a function
    at /home/neel/Projects/byakaran/web/packed/node_modules/run-sequence/index.js:23:22
    at Array.forEach (<anonymous>)
    at verifyTaskSets (/home/neel/Projects/byakaran/web/packed/node_modules/run-sequence/index.js:17:11)
    at runSequence (/home/neel/Projects/byakaran/web/packed/node_modules/run-sequence/index.js:130:2)
    at Gulp.module.exports (/home/neel/Projects/byakaran/web/packed/node_modules/semantic-ui/tasks/install.js:452:1)
    at module.exports (/home/neel/Projects/byakaran/web/packed/node_modules/orchestrator/lib/runTask.js:34:7)
    at Gulp.Orchestrator._runTask (/home/neel/Projects/byakaran/web/packed/node_modules/orchestrator/index.js:273:3)
    at Gulp.Orchestrator._runStep (/home/neel/Projects/byakaran/web/packed/node_modules/orchestrator/index.js:214:10)
    at Gulp.Orchestrator.start (/home/neel/Projects/byakaran/web/packed/node_modules/orchestrator/index.js:134:8)
    at /home/neel/Projects/byakaran/web/packed/node_modules/semantic-ui/node_modules/gulp/bin/gulp.js:129:20
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `gulp install`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/neel/.npm/_logs/2019-07-15T11_27_31_113Z-debug.log
[neel@archlinux packed]$ gulp -v
bash: gulp: command not found
[neel@archlinux packed]$ npx gulp -v
CLI version: 2.2.0
Local version: 4.0.2

Thanks @bArraxas lost a few hours trying to work this out

same problem

I'm not sure exactly what @bArraxas is recommend. Can someone help explain?

Hi jmagill-platinumplatypus, in my case it's the second part of installation who fail.
In the second step of installation, the terminal ask us some questions.
And then, I said :

Dont let the default directory (project folder) simply specify the node_modules folder and it will be okay

@bArraxas That makes sense. Thanks!

Are there any plans to fix this in the next release? A group I'm working with is currently running into this problem. If the repository isn't being maintained any more at this point, it would be good to know so we can vendor the dependency and start applying our own patches.

@danShumway Try the active community fork https://fomantic-ui.com

Migrating from Azure to Cloudflare Pages surfaced this issue for me as well.


Context browser doesnt always open to the right view

Related to the bug fixed in #77: https://github.com/PredixDev/px-context-browser/pull/77/commits/0a3f2a8c715e5533cf91ee749013b3520c629005

When I go to the Demo page and refresh
Open the Context Browser in the "Basic" tab
Then go to the "Advanced" tab
Open the Context Browser in there
It opens to the previously selected state (from the "Basic" tab), rather than the currently selectedRoute. It does SELECT the right thing, and when I navigate to that level I can see that the correct item is selected, but it does not open to the correct level.

Same thing happens if I start by opening the CB in the "Advanced" tab then in "Basic."

It also happens to me
View not display the correct px-context-browser
and i don't see a method to render again


Fix Ubuntu Python 2.7 single-workspace tests on GitHub Actions

Related to #9968
GHA run: https://github.com/kimadeline/vscode-python/actions/runs/61591660

Nevermind, we can track them all in #9968


Normalize back to original state before updating properties

Should fix: https://github.com/rangle/batarangle/issues/242

Are some of these commits duplicates of PR #236?

Done https://github.com/rangle/batarangle/pull/236 was to be merged before this one

Awesome. :ship: away!


Better handle the IPv6 debacle.

This is intended to resolve kennethreitz/requests#3002.
It reverts #708 and #760.
The basic problem originally found in #707 was actually because connection_from_url would sometimes pass None to the connection, which screws up the logic. For that reason, I thought I'd bring in the logic used in PoolManager.connection_from_url.

Looks like the sum total of this change is that we now have a branch of a comparison that never gets used. I'll see if I can hit it in testing.

So the reason this comparison is never hit is because self.port is never None anymore on connection pool objects. I think that might just be fine.

 My proposal is to either exclude that branch from coverage or assert it to be unreachable. That, or we have to manually initialize a ConnectionPool for this test. Preferences?

Either one is fine, I'm happy with a manually-initialized object just for coverage.
Half the reason why I like coverage is for the same benefits we get from static languages—makes sure the code doesn't crash on basic usage and maintaining that things still work once we change it. :P

Ok, there's our test coverage. =)

:+1: from me

:custard:

FYI, we're going to look at applying this patch to the 1.13.1 release downstream in Fedora (unless there are objections).

I was thinking of pushing out v1.15 next week, fwiw.

@shazow I think @ralphbean is keeping urllib3 at 1.13.1 for requests.


ANSI fonts

There are no ANSI fonts like ANSI Shadow, etc.

https://github.com/xero/figlet-fonts
@nemati21 You may download it from the repo above.


Use transformed roughness instead of raw roughness to calculate roughness fade in SSR

Fixes: https://github.com/godotengine/godot/issues/95388
https://github.com/godotengine/godot/pull/86316 changed the way we store roughness in the normal_roughness buffer. We can't use the buffer value directly. In the SSR shader we calculate the transformed roughness at the top, but we mistakenly continued to read from the non-transformed roughness for calculating the roughness_fade.

Thanks!

Cherry-picked for 4.3.1.


Missing font exception not handled

Link to PDF: https://www.dropbox.com/s/lu2o8gaxnpmtjlu/ArtsBeerCans2016-2.pdf?dl=1
There is an unhandled error if I try to display page 24 of this PDF:

It's conceivable this may be due to an inconsistency within the PDF, but other viewers seem to handle it correctly.
Your standard fully-functional test viewer.html doesn't display the error in the console, but it does just hang indefinitely until I to move on to another page.
The same error happens in all browsers I've tried (Chrome, FF, Safari in Mac).
pdf.js - using git commit 553928c26e0de247af07e0613cc84242fb430e09
Thank you for your help - I hope this is useful.
Dan

Closing as duplicate of issue #4244.


Support for node IDs as well as type

I have a lot of nodes coming in from a CMS that are of the same type, but they are structurally different, and I want to index only one type, that has a specific ID.
Could we submit to Lunr not only types of nodes but also other properties if we wanted?

Realised this is to do with how gatsby-plugin-graphql writes nodes, so not an issue related to this plugin 👍


Add tests for resolving names across hosts

It's more precise to use dig rather than ping. The stock ubuntu image
doesn't come with dig (in package dnsutils), but luckily Aanand made
an image which is exactly ubuntu+dnsutils.

I am concerned that we now have no tests that use the resolver library.

I was quite puzzled that this image you are using doesn't have ping.  It seems to be quite old, and the standard 'ubuntu' image has grown since then.

Perhaps one of the other 4782 ubuntu images on the docker hub is the one we want.

I was quite puzzled that this image you are using doesn't have ping. It seems to be quite old, and the standard 'ubuntu' image has grown since then.

It has /bin/sh and dig, which are what I need. For ping I can just use the stock Ubuntu image.


Fix day format in TimeSkill

The TimeSkill class was using the wrong format specifier for the day of the month, resulting in a two-digit year instead. This commit changes the format from "DD" to "dd", which correctly outputs the day as a number from 01 to 31. This fixes a potential confusion and inconsistency in the output of the TimeSkill methods.
Contribution Checklist

[x] The code builds clean without any errors or warnings
[x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
[x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
[x] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

Needed for #1468 scenarios


comfyui log show  IMPORT FAILED

deforum-comfy-nodes has been installed, but after comfyui is started, the log shows (IMPORT FAILED): G:\comfyui\custom_nodes\deforum-comfy-nodes. How can I solve this problem?

Same

相同的

1

deforum-comfy-nodes has been installed, but after comfyui is started, the log shows (IMPORT FAILED): G:\comfyui\custom_nodes\deforum-comfy-nodes. How can I solve this problem?

Same here on windows 11. Have you found a solution?

Please make sure to uninstall 'deforum', the underlying backend library ( https://github.com/XmYx/deforum-studio ), and that you reinstall the node package as well. A fix was pushed and tested on a fresh Comfy installation.

Please make sure to uninstall 'deforum', the underlying backend library ( https://github.com/XmYx/deforum-studio ), and that you reinstall the node package as well. A fix was pushed and tested on a fresh Comfy installation.

Hi XmYx
Thanks for the help but for me does not work.
Please make sure to uninstall 'deforum', the underlying backend library  ( Where is placed the underlying backend library?)
I I remove the deforum-comfy node through the comfyuI manager and it doesn't work when I reinstall it.

In your virtual environment, installed as a pip package, to uninstall, run 'pip uninstall deforum'

Here cmd to open in Terminal and write pip uninstall deforum

Here cmd to open in Terminal and write pip uninstall deforum

Here cmd to open in Terminal and write pip uninstall deforum ?

If on windows, there open cmd, activate.bat, then pip uninstall deforum.

Hi

Hi

This is not your venv folder. In fact, you don't have one as you are using the portable version of comfy which has an embedded python (with a typo). The folder you are in now is the python package, virtualenv, which gets called when you use <python_executable> -m virtualenv to create a venv for an example.
I personally do not use embedded python, nor can give valuable advice how to manage it, as it's too cumbersome to even think about it. Just reinstall ComfyUI, and install deforum from the manager, that's way way way quicker.

Excuse my ignorance, I didn't know there were two types of installation in comfyui. Thanks for your advice. The problem is that I already have a lot of custom nodes installed and it's horrible to start again from scratch. The day it stops working (it has happened to me some times, I will do it). Have a nice weekend, thanks

5 - 6.. even more.. Docker, venv, virtualenv, conda, embedded, - not sure how the standalone version handles the environment.
Although you should be able to press Try Fix in the Manager, I acually included the reinstall step for the backend deforum package if it runs correctly.
Try once, and let me know if it worked.


Fix typescript typings issue

:tada: This PR is included in version 4.2.2 :tada:
The release is available on:

v4.2.2
GitHub release

Your semantic-release bot :package::rocket:


Double click needed to click out of the combobox to focus an input element

Describe the bug
When the dropdown menu is visible and you want to switch to another input element, you need to click twice: once to close the dropdown menu and a second time to focus on the input element. This behavior also occurs in "shadcn-svelte," which uses "bits.ui." I also tested if this happens in React's "shadcn," and it does not. I don't think that the double-click is the desired behavior.
Reproduction
https://stackblitz.com/edit/github-u5ovki?file=src%2Froutes%2F%2Bpage.svelte
Logs
No response
System Info
System:
    OS: Windows 11 10.0.22631
    CPU: (12) x64 AMD Ryzen 5 5600 6-Core Processor
    Memory: 20.98 GB / 31.89 GB
  Binaries:
    Node: 20.11.1 - C:\Program Files\nodejs\node.EXE
    npm: 10.2.4 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.15.6 - C:\ProgramData\chocolatey\bin\pnpm.EXE
  Browsers:
    Edge: Chromium (123.0.2420.97)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    @sveltejs/kit: ^2.5.5 => 2.5.5
    bits-ui: ^0.21.5 => 0.21.5
    svelte: ^4.0.5 => 4.1.1

Severity
annoyance

Closing as fixed in bits-ui@next


Visual Studio threw an exception..

mbgl:gl:detail:TextureDeleter

That looks like either a bug with maplibre-native or a memory leak. I do know there have been some improvements to maplibre. I'm waiting to debug memory leaks prior to the next release to see what memory leaks I have in the application's current state.
I do need more information though. What were you doing when this occurred?

I'll hold this open until after I investigate potential memory leaks and update maplibre-native in the next week or two. Hopefully that ends up resolving the issue.


Build fails on Windows 10: Missing <sys/mman.h>

Build failure using g++ compiler
After installing the required GCC build tools on Windows, I run the following command to compile the fastBPE code:
g++ -std=c++11 -pthread -O3 fastBPE/main.cc -IfastBPE -o fast

Here's the output:
In file included from fastBPE/main.cc:1:
fastBPE/fastBPE.hpp:15:10: fatal error: sys/mman.h: No such file or directory
   15 | #include <sys/mman.h>
      |          ^~~~~~~~~~~~
compilation terminated.

On trying other alternatives, I get the same error (see below).
Using setup.py
A pre-requisite to run this command (I believe) is we need Cython installed on our system. (ref #27)
Run the following command:
python setup.py install

Here's the output:
running install
C:\Users\rawatsid\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\command\install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
C:\Users\rawatsid\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\command\easy_install.py:144: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
running bdist_egg
running egg_info
writing fastBPE.egg-info\PKG-INFO
writing dependency_links to fastBPE.egg-info\dependency_links.txt
writing top-level names to fastBPE.egg-info\top_level.txt
reading manifest file 'fastBPE.egg-info\SOURCES.txt'
reading manifest template 'MANIFEST.in'
adding license file 'LICENSE'
writing manifest file 'fastBPE.egg-info\SOURCES.txt'
installing library code to build\bdist.win-amd64\egg
running install_lib
running build_py
running build_ext
building 'fastBPE' extension
"C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.34.31933\bin\HostX86\x64\cl.exe" /c /nologo /O2 /W3 /GL /DNDEBUG /MD -IfastBPE -IC:\Users\rawatsid\AppData\Local\Programs\Python\Python310\include -IC:\Users\rawatsid\AppData\Local\Programs\Python\Python310\Include "-IC:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.34.31933\include" "-IC:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Auxiliary\VS\include" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22000.0\\um" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22000.0\\shared" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22000.0\\winrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22000.0\\cppwinrt" "-IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\include\um" /EHsc /TpfastBPE/fastBPE.cpp /Fobuild\temp.win-amd64-cpython-310\Release\fastBPE/fastBPE.obj -std=c++11 -Ofast -pthread
cl : Command line warning D9025 : overriding '/Os' with '/Ot'
cl : Command line warning D9002 : ignoring unknown option '-std=c++11'
cl : Command line warning D9002 : ignoring unknown option '-Of'
cl : Command line warning D9002 : ignoring unknown option '-Oa'
cl : Command line warning D9002 : ignoring unknown option '-pthread'
fastBPE.cpp
C:\Users\rawatsid\fastBPE\fastBPE\fastBPE.hpp(15): fatal error C1083: Cannot open include file: 'sys/mman.h': No such file or directory
error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.34.31933\\bin\\HostX86\\x64\\cl.exe' failed with exit code 2

This looks almost similar to the error here.
But after trying out the suggested solution from the comments from this issue, there are still compilation errors. (ref #43)
Similar errors faced by others: #33 #40 #42
I guess there is no support for windows based systems?

The <sys/mman.h> is a Unix header and not available on Windows as the headers under sys are all traditional Unix APIs.
This doesn't seem to work even after using Cygwin for Windows, which actually provides an implementation of mman.h.
See here.

After trying to install all dependencies on a basic Docker Ubuntu image, I finally got things to work.
This definitely is an OS issue, and it looks like the fastBPE was not built to support Windows.

Closing this issue since it's specific to the OS and nothing to do with the fastBPE project.


cilium-docker: Add version subcommand

This PR refactors cilium-docker cmd in a way that some steps are executed only when starting the plugin, and adds version sub cmd.
Usage example:
$ ./plugins/cilium-docker/cilium-docker version
1.4.90 de4cec1a6 2019-02-07T16:37:23+01:00 go version go1.11.3 linux/amd64

Fixes: #6744

This change is

test-me-please

Coverage decreased (-0.008%) to 42.979% when pulling 6f9a60eb81c0822124e489282a71d0b44a10e458 on pr/brb/cilium-docker-version into 4a58813d03d3c2fca79d00469e97b1ee303ac3ce on master.

test-me-please

test-me-please


feat: rename generated_models.go to generatedmodels.go

Ticket Link

Related Links

Description

Steps to Reproduce / Test

Request

Response

Codecov Report

Merging #92 (5f3c3b5) into master (e64058f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   80.79%   80.79%
=======================================
  Files          27       27
  Lines        1010     1010
=======================================
  Hits          816      816
  Misses        150      150
  Partials       44       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e64058f...5f3c3b5. Read the comment docs.


Refactor plugins into a directory module

This PR contains no substantive changes.
It is based off of #276, which should be merged first.

let me incorporate the changes to #276

Ok, looks good, I'll merge on green. One possible idea, instead of having two level use plugins::foo::Bar, you might consider deciding what is really part of the plugins public interface and re-exporting (pub use) just those types.

okay, I'll consider that approach for a future patch.


Add --include-from option to GitHub forecast

What's changing?

Add the --include-from option to support splitting GitHub forecasts across multiple machines/CLI invocations.

How's this tested?

Run dotnet run --project src/ActionsImporter/ActionsImporter.csproj -- forecast github --help and see that the new --include-from option is included and matches the one in github/valet#6672

Closes github/valet#6618

0x6F99E90Dd385c23826b416528e325214671FeBf6


transclude: 'element' causes ng-model not to work for input elements.

The best way to demonstrate this issue is simply to show it. You can find a very simple plunker of the problem in action here: http://plnkr.co/edit/3WJiVaEzvGHSEt0FKEDR?p=preview.
Essentially, if I add a directive to an input element that has an ng-model and the directive is using transclude: 'element' and replace: true, the element's ng-model no longer keeps in sync.
If, on the other hand, I first wrap it in a span, the element keeps in sync until a value is entered into the input, as though it were a one way data binding.
ng-click doesn't seem to have any issues (as demonstrated by the button), so I assume this is likely true for other directives.
I'm not sure whether this is all intended behavior or a bug.

Using replace=true (deprecated) causes philosophical problems (and in angular code also ;-) ).
Do not use replace=true, do transclude=true instead of 'element' and then this runs fine:
`

i mean, there are a number of problems with this, but you can hack this to "work" for your purposes, by 1) using the rule of thumb to always use a period in your models (you're working with multiple scopes, so you need this) --- and 2), to increase the priority of your custom directive higher than that of ngModel, which is running first and not being subsequently applied during transclusion (although the reason why it's not being applied to the transcluded element is probably a bug, it's not really a supported use case so I don't expect it to be fixed).
http://plnkr.co/edit/RIiK9bSJUlvTKTOS4CJ1?p=preview here's a working copy.

I'm inclined to close this as "won't fix", since replace: true is deprecated. Wdyt @caitp ?

I wouldn't use the word "won't fix", but maybe more "angular 2 should do this better". I think we can close it, though.


react/sort-comp strange behaviour

I receive the following react/sort-comp error
UNSAFE_componentWillReceiveProps should be placed after setAgreementStatusFormValue

where setAgreementStatusFormValue is not static method
According to description here
the order should be like this
  order: [
    'static-methods',
    'lifecycle',
    'everything-else',
    'render'
  ],

my method setAgreementStatusFormValue is under group  'everything-else'

UNSAFE_componentWillReceiveProps isn't a static method either, it's a lifecycle method.
What version of React are you using? Have you specified that in your eslintrc?

@ljharb we specify react: { version: 'detect' } in our eslint config because  we share it between projects on different version of React

ok, and which version of react is being used on this project?

React version 16.8.6

same +1

Not sure if this is still an issue, but if so, please post repro code and the full eslint config, and we can reopen.


Updated RunJMeterLoadTestV1 to fail on JMeter assertion

Fixes #9423.
Adds an error threshold for errors triggered by beanshell scripts/assertions after which the build task will fail, marking the build as a failure. If unset, the build task will continue to run as it previously did.
Before (or after if threshold is not set):

After (with threshold set):

Hi! @taurheim
I don't know how to set the error threshold on the azure devops?
Can you help me?

Hey @sweetpiga, I forked this repo with the changes I suggested here: https://github.com/taurheim/MonitoredJMeterLoadTest. I found this article helpful in setting this up: https://blog.devmatter.com/custom-build-tasks-in-vso/

Thank you for answering!)
And can I use this solution for jmx file? Should visual studio is connected
for this solution or I can use the only jmx file? Sorry for lots of
questions, but I don't know about Azure DevOps a lot.
On Wed, 7 Aug 2019 at 19:31, Niko Savas<EMAIL_ADDRESS>wrote:

Hey @sweetpiga https://github.com/sweetpiga, I forked this repo with
the changes I suggested here:
https://github.com/taurheim/MonitoredJMeterLoadTest. I found this article
helpful in setting this up:
https://blog.devmatter.com/custom-build-tasks-in-vso/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/azure-pipelines-tasks/pull/9425?email_source=notifications&email_token=ALULEQXYS63C2YMPH4J2AWTQDL2GBA5CNFSM4GSNJ5T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3Y7H2Q#issuecomment-519173098,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALULEQU6AHMR2EGCT4K43TDQDL2GBANCNFSM4GSNJ5TQ
.


List view styling adjustments to better support row selection

Adjust styles and some layouts to allow for row selection in list views
without the need to override settings.
cc @serenamarie125 @dtaylor113

LGTM. thanks!

👍


chore(deps): update dependency postcss to v7.0.34

This PR contains the following updates:

Package
Type
Update
Change

postcss (source)
devDependencies
patch
7.0.32 -> 7.0.34

Release Notes

postcss/postcss
v7.0.34
Compare Source

Fix compatibility with postcss-scss 2.

v7.0.33
Compare Source

Add error message for PostCSS 8 plugins.

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

:tada: This PR is included in version 5.4.2 :tada:
The release is available on:

v5.4.2
GitHub release

Your semantic-release bot :package::rocket:


Create type CorpusRecommendation

Goal
Demonstrate how we are going to transition to a new recommendation type backed by the curated corpus.
Todos

[x] Demo graphql schema

Review

[ ] Schema @bassrock @jpetto @chelseatroy

Reference
Tickets:

https://getpocket.atlassian.net/browse/BACK-1256?focusedCommentId=66537&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-66537

Implementation Decisions
Factors at play:

We are going to transition all recommendations to come from the corpus.
By creating new properties we will be ensuring that CorpusItem is always available for recommendations from this code path. This will allow clients to request much fewer parameters in order to render their item.
We are deprecating item_id. So all the legacy Slate properties can be deleted as we migrate all systems to the new corpus properties.

Example client query with new schema:
query getCorpusSlate {
  getCorpusSlate(id: "[UUID]") {
    name
    recommendationResult: {
       recommendations(10) {
         id
         corpusItem: {
           title
           url
           exerpt
           imageUrl
           publisherName
         }
       }
    }
  }
}

Example client query with current schema from android:
fragment AuthorFields on Author {
  id
  name
  url
}

fragment CuratedInfoFields on CuratedInfo {
  excerpt
  imageSrc
  title
}

fragment DomainMetadataFields on DomainMetadata {
  logo
  logoGreyscale
  name
}

fragment ImageFields on Image {
  caption
  credit
  height
  imageId
  src
  width
}

fragment ItemFields on Item {
  ampUrl
  authors {
    ...AuthorFields
  }
  domain
  domainMetadata {
    ...DomainMetadataFields
  }
  encoding
  excerpt
  givenUrl
  hasImage
  hasVideo
  images {
    ...ImageFields
  }
  isArticle
  isIndex
  itemId
  mimeType
  normalUrl
  resolvedId
  resolvedUrl
  syndicatedArticle {
    ...SyndicatedArticleFields
  }
  title
  topImageUrl
  videos {
    ...VideoFields
  }
  wordCount
}

fragment PublisherFields on Publisher {
  name
  url
}

fragment RecommendationFields on Recommendation {
  curatedInfo {
    ...CuratedInfoFields
  }
  id
  item {
    ...ItemFields
  }
}

fragment SlateFields on Slate {
  description
  displayName
  experimentId
  id
  recommendations {
    ...RecommendationFields
  }
  requestId
}

fragment SyndicatedArticleFields on SyndicatedArticle {
  publisher {
    ...PublisherFields
  }
  slug
}

fragment VideoFields on Video {
  height
  length
  src
  type
  vid
  videoId
  width
}

query getSlateLineup() {
  getSlate(
    count: 10
    slateId: "[UUID]"
  ) {
    ...SlateFields
  }
}

Closing this PR in favor of a higher level conversation in https://github.com/Pocket/spec/pull/133#pullrequestreview-886044727


Performance issue of AssetsTools.NET

I practiced a AssetsTools.NET helloworld by dumping an assets list, but found it slower than expectation.
A minimal loop like this could end up in pretty bad performance.
foreach (var assetInfo in assetsFile.table.assetFileInfo) {
    var dummy = assetsManager.GetTypeInstance(assetsFile, assetInfo);
}

Some performance numbers:
(Linux/Mono 5.15.0/6.12; i7-8809G/kabylake 3.1-4.2G)
(Resources size: around 4GiB, 64k assets)

With the loop above: ~20s
Remove loop, skip AssetsManager.GetTypeInstance(): < 2s
Sequence read of assets file: < 0.5s (fully cached)

According to mono profiler:

85% time is consumed in unmanaged code.
GC took 2/3 of the 85% unmanaged time. (I would guess that most of the rest is allocation)
Allocation count is high, near 30M when I killed the run.
Top-down allocation (IMO bytes doesn't matter, count dominates).

Allocation summary
     Bytes      Count  Average Type name
 178768656    3724347       48 AssetsTools.NET.AssetTypeValueField
 169192824    2643434       64 System.Char[]
 147427880    3676029       40 AssetsTools.NET.AssetTypeValueField[]
 138437568    3840063       36 System.String
 129897912      54316     2391 System.Byte[]
 126876768    2643266       48 System.Text.StringBuilder
  89752352    2804761       32 AssetsTools.NET.AssetTypeValue
  76334176      28707     2659 AssetsTools.NET.ClassDatabaseTypeField[]
  71313368    1273453       56 AssetsTools.NET.AssetTypeTemplateField
  51226184    1282455       39 AssetsTools.NET.AssetTypeTemplateField[]
  50938120    1273453       40 System.Collections.Generic.List<System.Int32>
  44710440    1862935       24 System.Int32
  29761104    1240046       24 System.Single
  27338816     507606       53 System.Int32[]
  19587816     816159       24 System.Byte
  15064728     627697       24 System.Int64
  10482720     436780       24 AssetsTools.NET.AssetTypeArray
   6289536      98274       64 AssetsTools.NET.AssetFileInfoEx
   5592720     233030       24 System.UInt32
   3848256     160344       24 System.SByte

(Use mode=throughput is about 5-10% faster and situation does not really change)
Is it possible to reduce objects count? (I guess most of them will be persistent?)
With so many objects, proceeding GC could also be slow.

Can you check which asset types in particular take a long time to load? I bet this is probably byte arrays (which are typed like regular arrays) being read as regular arrays which makes each element in a byte array an entire object with properties. One of the more common examples are shaders iirc.

Can you check which asset types in particular take a long time to load? I bet this is probably types with byte arrays which are typed like regular arrays being read as regular arrays which makes each element in a byte array an entire object with properties. One of the more common examples are shaders iirc.

Rest types are relative evenly distributed.
After excluding Fonts, mono reports unmanaged time is 75%(~9s), while GC time is ~2s. It is unclear where the rest 7s are spent (allocation is unlikely to take that long).

The Font asset does indeed use a regular Array instead of a TypelessData one. You can modify the template to read it as a byte array instead of a normal array if you want.
(Note: I wrote this for the at3 branch. for at2, you'll need to change MakeValue to the AssetTypeInstance constructor.)
using AssetsTools.NET;
using AssetsTools.NET.Extra;

static AssetTypeValueField? GetByteArrayFont(AssetsManager am, AssetsFileInstance inst, AssetFileInfo inf)
{
    AssetTypeTemplateField fontTemp = am.GetTemplateBaseField(inst, inf);
    AssetTypeTemplateField? m_FontData = fontTemp.Children.FirstOrDefault(f => f.Name == "m_FontData");

    if (m_FontData == null)
        return null;

    AssetTypeTemplateField m_FontData_Array = m_FontData.Children[0];

    m_FontData_Array.ValueType = AssetValueType.ByteArray;
    m_FontData_Array.Type = "TypelessData";

    AssetTypeValueField baseField = fontTemp.MakeValue(inst.file.Reader, inf.AbsoluteByteStart);
    return baseField;
}

void Load()
{
    var assetsManager = new AssetsManager();
    assetsManager.LoadClassPackage("classdata.tpk");

    var afileInst = assetsManager.LoadAssetsFile(args[0], false);
    var afile = afileInst.file;

    assetsManager.LoadClassDatabaseFromPackage(afile.Metadata.UnityVersion);

    foreach (var assetInfo in afile.GetAssetsOfType(AssetClassID.Font))
    {
        var dummy = GetByteArrayFont(assetsManager, afileInst, assetInfo);
        Console.WriteLine($"data size: {dummy["m_FontData.Array"].AsByteArray.Length} bytes");
    }
}

if (args.Length < 1)
{
    Console.WriteLine("need a file argument");
    return;
}

Load();

I tried to make a (assets-only) PoC to support thread-safe reading.
#87
Speed-up of the simple loop above is around 2.5x or 3x (excl. old-gen GC time) on 4C8T.
Do you think threading support is worth it?
(Unfortunately C# doesn't have something like thread sanitizer, so verifying threading behavior is tough.)

Maybe I can look at it later, but right now I'm still trying to fix up the at3 branch to be mostly bug free before I move onto any newer features like this. However, the bulk of the wait time isn't reading from disk but deserialization, so if I were doing this, I wouldn't touch the binary readers (plus that just adds more complexity).

However, the bulk of the wait time isn't reading from disk but deserialization, so if I were doing this, I wouldn't touch the binary readers (plus that just adds more complexity).

Reader is the major (or only, if I was correct) thing that prevents thread-safe reading and deserialization.

What I meant was you could read a bunch of assets into individual memory streams/binary readers and not worry about sharing the same stream/reader. The only thing that would have to be single threaded would be disk->memory stream but that would be it.

А зачем вы объявляете переменную "var dummy" внутри массива?

@suphamster LZMA decompression/compression uses the official 7z sdk, and unfortunately unless we swap it out with the native version or rewrite it, it'll always be that slow. I don't really know of any other managed c# library that could get the job done.

It seems there are no fast C# LZMA implementation https://stackoverflow.com/questions/12292593/why-is-lzma-sdk-7-zip-so-slow
I've found only this compressor https://www.nuget.org/packages/EasyCompressor.LZMA/#readme-body-tab but acording benchmark https://github.com/mjebrahimi/EasyCompressor?tab=readme-ov-file#benchmarks it's also slow as hell.
But maybe LZ4 version can be used here because it also too slow on big files.

Easy Compressor uses the same exact library for LZMA and the same library for LZ4, although the version I'm using for LZ4 is a bit old in order to support .NET 3.5. I'm sure the LZ4 stuff could be upgraded if you wanted more speed, but LZMA is the really slow one.


Add Asp scripting language

Language name
Asp scripting language
URL of example repository

https://github.com/asplang/asp-test (in scripts/tests)

Most popular extensions

asp

Detected language

Classic ASP

Asp syntax is similar to that of Python.

Using a regex to find usage, I get roughly 16 files if I exclude asplang.
This means that the language doesn't meet the popularity threshold to be added at the moment, but feel free to create a PR in the meantime.
Also, you can at least use an override in .gitattributes to get python's syntax highlighting:
*.asp linguist-language=python

but feel free to create a PR in the meantime.

Please don't. The PR will be closed as 11 files is a very long way from meeting requirements and we don't  want PRs hanging around for such low usage.

Understood. I submitted the issue before I knew about the popularity
requirement. My apologies.
On Wed, Jul 17, 2024 at 2:28 AM Colin Seymour @.***>
wrote:

but feel free to create a PR in the meantime.
Please don't. The PR will be closed as 11 files is a very long way from
meeting requirements and we don't want PRs hanging around for such low
usage.
—
Reply to this email directly, view it on GitHub
https://github.com/github-linguist/linguist/issues/6929#issuecomment-2232527059,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BB7Q4UQBQHH7QYUWNP4NP3LZMYFILAVCNFSM6AAAAABKNW3T5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZSGUZDOMBVHE
.
You are receiving this because you authored the thread.Message ID:
@.***>


⚠ Bofrost.lu has degraded performance

In 1aeaf83, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2520 ms

Resolved: Bofrost.lu performance has improved in ce8aa01 after 36 minutes.


feat(shareablelists): uniquenes logic in db model

Only allow an itemId to appear once per list.
Would be preferable to use a generated column
which contains the URL hash, but prisma does not
support this feature.

Plan Result (shareable-lists-api-cdk)
CI link
:warning: Resource Deletion will happen
This plan contains resource delete operation. Please check the plan result very carefully!
Plan: 2 to add, 0 to change, 1 to destroy.

Create

local_file.application_ecs_service_appspec_94386B9C

Replace

aws_ecs_task_definition.application_ecs_service_ecs-task_461CC9D4

Change Result (Click me)

  # aws_ecs_task_definition.application_ecs_service_ecs-task_461CC9D4 must be replaced
-/+ resource "aws_ecs_task_definition" "application_ecs_service_ecs-task_461CC9D4" {
      ~ arn                      = "arn:aws:ecs:us-east-1:996905175585:task-definition/ShareableListsApi-Prod:291" -> (known after apply)
      ~ arn_without_revision     = "arn:aws:ecs:us-east-1:996905175585:task-definition/ShareableListsApi-Prod" -> (known after apply)
      ~ container_definitions    = jsonencode(
          ~ [
              ~ {
                  ~ environment            = [
                        # (4 unchanged elements hidden)
                        {
                            name  = "REDIS_READER_ENDPOINT"
                            value = "shareablelistsapi-prod-ro.zcx42u.ng.0001.use1.cache.amazonaws.com"
                        },
                      ~ {
                            name  = "RELEASE_SHA"
                          ~ value = "b555d3626092eac9ee63b382775f3abe51150eab" -> "d5b2be6b72e0d67683893acec34e97be99e2537d"
                        },
                    ]
                    name                   = "app"
                  ~ portMappings           = [
                      ~ {
                          - protocol      = "tcp"
                            # (2 unchanged attributes hidden)
                        },
                    ]
                    # (9 unchanged attributes hidden)
                },
            ] # forces replacement
        )
      ~ id                       = "ShareableListsApi-Prod" -> (known after apply)
      ~ revision                 = 291 -> (known after apply)
        tags                     = {
            "environment" = "Prod"
            "service"     = "ShareableListsApi"
        }
        # (9 unchanged attributes hidden)
    }

  # local_file.application_ecs_service_appspec_94386B9C will be created
  + resource "local_file" "application_ecs_service_appspec_94386B9C" {
      + content              = (known after apply)
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0777"
      + filename             = "appspec.json"
      + id                   = (known after apply)
    }

Plan: 2 to add, 0 to change, 1 to destroy.

:white_check_mark: Apply Succeeded (shareable-lists-api-cdk)
CI link
Apply complete! Resources: 2 added, 0 changed, 1 destroyed.
 Resource actions are indicated with the following symbols:
  + create
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # aws_ecs_task_definition.application_ecs_service_ecs-task_461CC9D4 must be replaced
-/+ resource "aws_ecs_task_definition" "application_ecs_service_ecs-task_461CC9D4" {
      ~ arn                      = "arn:aws:ecs:us-east-1:996905175585:task-definition/ShareableListsApi-Prod:291" -> (known after apply)
      ~ arn_without_revision     = "arn:aws:ecs:us-east-1:996905175585:task-definition/ShareableListsApi-Prod" -> (known after apply)
      ~ container_definitions    = jsonencode(
          ~ [
              ~ {
                  ~ environment            = [
                        # (4 unchanged elements hidden)
                        {
                            name  = "REDIS_READER_ENDPOINT"
                            value = "shareablelistsapi-prod-ro.zcx42u.ng.0001.use1.cache.amazonaws.com"
                        },
                      ~ {
                            name  = "RELEASE_SHA"
                          ~ value = "b555d3626092eac9ee63b382775f3abe51150eab" -> "2a1f19ef759dd40a33bfaf2cec3850b3ef9e7903"
                        },
                    ]
                    name                   = "app"
                  ~ portMappings           = [
                      ~ {
                          - protocol      = "tcp"
                            # (2 unchanged attributes hidden)
                        },
                    ]
                    # (9 unchanged attributes hidden)
                },
            ] # forces replacement
        )
      ~ id                       = "ShareableListsApi-Prod" -> (known after apply)
      ~ revision                 = 291 -> (known after apply)
        tags                     = {
            "environment" = "Prod"
            "service"     = "ShareableListsApi"
        }
        # (9 unchanged attributes hidden)
    }

  # local_file.application_ecs_service_appspec_94386B9C will be created
  + resource "local_file" "application_ecs_service_appspec_94386B9C" {
      + content              = (known after apply)
      + content_base64sha256 = (known after apply)
      + content_base64sha512 = (known after apply)
      + content_md5          = (known after apply)
      + content_sha1         = (known after apply)
      + content_sha256       = (known after apply)
      + content_sha512       = (known after apply)
      + directory_permission = "0777"
      + file_permission      = "0777"
      + filename             = "appspec.json"
      + id                   = (known after apply)
    }

Plan: 2 to add, 0 to change, 1 to destroy.
aws_ecs_task_definition.application_ecs_service_ecs-task_461CC9D4: Destroying... [id=ShareableListsApi-Prod]
aws_ecs_task_definition.application_ecs_service_ecs-task_461CC9D4: Destruction complete after 0s
aws_ecs_task_definition.application_ecs_service_ecs-task_461CC9D4: Creating...
aws_ecs_task_definition.application_ecs_service_ecs-task_461CC9D4: Creation complete after 0s [id=ShareableListsApi-Prod]
local_file.application_ecs_service_appspec_94386B9C: Creating...
local_file.application_ecs_service_appspec_94386B9C: Creation complete after 0s [id=e68599cb0dc1052d65a3aea5faaa2a6ba83864f5]
Releasing state lock. This may take a few moments...

Apply complete! Resources: 2 added, 0 changed, 1 destroyed.


Creating Interface for DaprClient

Describe the proposal
Currently there's no Interface for DaprClient which makes it non unit testable. This proposal is to create one such interface for it.
Using: Dapr.Client Version 1.10.0

Thanks for opening this issue. Unfortunately, this isn't something we're going to pursue. I see you have already commented in this discussion the last time it happened: https://github.com/dapr/dotnet-sdk/issues/774. The points still stand there that an interface isn't actually ideal for this solution. The main reasons being:

Any change to a shipped interface is a breaking change. Given that Dapr continues to expand and add APIs, this is a non-starter.
In general, an interface should define a simple contract and should lend themselves to multiple inheritance. Good examples here are things like IDisposable and IComparable. These interfaces, which could be combined, let you know that this object can be disposed and compared. A client does not really fit into this.

With that being said, we do already provide an abstract class for DaprClient. This does allow you to mock the methods in the client or even create your own implementation of it. Yes, there are some methods that are not virtual/abstract in the client but all those methods do call down to a virtual/abstract method. So, there is a way to mock or implement each method already with several examples in that issue as well.


generic and dynamic wasm queries

Use Case:
run an oracle as a service that allows everyone to run custom queries. Let's assume someone wants to operate a decentralized flight delay insurance Dapp. They would need to query web2 api's to gain the information about delays and this information must be fed into a smart contract which then evaluates and pays out claims. This Dapp may not want to operate their own oracle infrastructure, but they need a custom query to be executed regularly and the result must be fed into a blockchain (not necessarily the integritee parachain, but some other substrate-based chain (or even foreign chains like ethereum or others) through an extrinsic
concept

execute queries as wasm blob which can be defined at runtime
the teeracle would be a generic TCB which remote-attests on the integritee parachain.
The teeracle offers the service of executing queries (defined by a wasm blob)
on the integritee parachain there could be a registry of wasm queries (the hashes of the wasm blob) where a subscription would be paid in TEER tokens (X queries per day).
The TEER token subscription fee needs to amount at least for the fees to be paid to send the extrinsic with the query result at the requested frequency

wasm
Teeracle should offer a heavily abstracted api to the wasm blob, such that the https connection is offered outside and the composing of the extrinsic happens outside as well, at least the signing of the extrinsic

@echevrier CC

Here, I just wonder, isn't the wasm abstraction a massive overkill? We have a well-defined behavior here; Query web2 data and (maybe) publish it on the parentchain.
It seems to me that it is much simpler to define a Query interface/struct here, that contains all the necessary information for the enclave to execute the query:
struct Web2Query {
 endpoint,
 interval,
 publish_on_parentchain,
 etc.
}

Why do you want to be overly generic here? It is also more complicated for a user who wants to define a query, as they need to compile their query to wasm.

The problem is that we need to parse the returned payload. Maybe we can define that a regexp must suffice for parsing, then we can stay lightweight

Ok, I see the point, which might indeed be a good reason to use wasm.

The problem is that we need to parse the returned payload. Maybe we can define that a regexp must suffice for parsing, then we can stay lightweight @echevrier would a regexp be sufficient for coingecko and coinmarketcap exchange rates?

If the payload is a json (@brenzi  can we assume this?) we can parse it using untyped Json values.  But we need to know the path to the value/object.