ntfy notification is the actual json string

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
I'm using ntfy to send alerts from uptime-kuma.
The notification received in the ntfy android app is the actual JSON string ie.
{"topic":"Alert", "title": "Alert [Uptime-Kuma]", "message": "Ntfy alert Testing", "priority":3, "tags":["test_tube"]}
👟 Reproduction steps
eg. setup notification > test
or
actual notification from service down, etc.
👀 Expected behavior
proper ntfy notification with title, priority, etc.
😓 Actual Behavior
seeing JSON string of the notification
🐻 Uptime-Kuma Version
1.22.1
💻 Operating System and Arch
Ubuntu 22.04
🌐 Browser
Not applicable
🐋 Docker Version
No response
🟩 NodeJS Version
No response
📝 Relevant log output
No response

As far as I am reading https://docs.ntfy.sh/publish/#publish-as-json we are using it correctly.
Here is the code we use:
https://github.com/louislam/uptime-kuma/blob/a0203372ce26b5d7aafd0af53a5c45a183eceecf/server/notification-providers/ntfy.js#L22-L67
Could you give further detais on your deployment method? Are you self-hosting? If yes, what version are you running?

running self hosted docker, docker-compose.yaml is:
services:

  uptime-kuma:
    image: louislam/uptime-kuma:1
    container_name: uptime-kuma
    volumes:
      - "/projects/uptime-kuma/data:/app/data"
    ports:
      - "3001:3001"
    restart: unless-stopped
    security_opt:
      - "no-new-privileges:true"

command to start is:
docker-compose up --detach --force-recreate

uptime kuma version is 1.22.1 (from settings>about)
android app receiving is ntfy (version is ntfy 1.16.0 (play)
android is stock, non rooted
ntfy channel is a public channel (ntfy.sh/...)
The android ntfy app is receiving other notifications formatted correctly from other apps.
Everything is out of the box, as far as I can tell. Thanks!

Cannot reproduce:

Also tested If maybe there is some weirdness with more than just the testing => Nope

Currently, I could not replicate this issue.
Can you provide us a Minimal, Reproducible Example?

As above:
docker-compose.yaml
services:

  uptime-kuma:
    image: louislam/uptime-kuma:1
    container_name: uptime-kuma
    volumes:
      - "/projects/uptime-kuma/data:/app/data"
    ports:
      - "3001:3001"
    restart: unless-stopped
    security_opt:
      - "no-new-privileges:true"

docker-compose up --detach --force-recreate

If you specify a topic twice, the one from the url takes precedence over the one we set in the json part
=> please remove this part from the url

We should probably add a help text making the usage of the url more clear, PRs welcome

Oh I see, that's really confusing.
Thanks!


Adding search algos in python

Thank you for contributing to Algorithms/Python, your pr got merged! ✨


Alex postee add jira ticket url

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 4 committers have signed the CLA.:white_check_mark: AndreyLevchenko:white_check_mark: elad-da:white_check_mark: tomyweiss:x: Alex ZipnikAlex Zipnik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix bad i64->usize cast in do_scroll

Fixes #556

This rings a bell, somehow I thought I ran across something like it. In any case, this looks like the right fix, in general we should be protecting against panic from nonsensical inputs.


[Gui] Add Permissions in Firmware

For add Permissions in firmware update (doesn't show button, for example)
Roles:

viewer just for GET
modifier GET, POST, PUT and DELETE

Imports:
import ability from 'Components/permissions/ability';
import Can from '../../components/permissions/Can';
How use:
const cannotEdit = !ability.can('modifier', 'fw-image');
const cannotEdit = !ability.can('viewer', 'fw-image');
or
<Can do="modifier" on="fw-image"> </Can>
 <Can do="viewer" on="fw-image"> </Can>

Waiting for discussion about firmware permission (dojot/dojot#947).

This permission is associated with the endpoint. Since the user does not have permission to access such an endpoint, he will not be able to work with firmware even if he can manage the template.
The GUI would only display the firmware button or not.

Everything has been set up for a while, you just need to use 'fw-image'.

Specific permissions to access FW were added:


Added TrappingRainwater.cpp

Added solution to the famous Trapping rainwater problem using 2 pointers.

@amritansh22 Please do review the pull request and let me know if something needs to be changed. Thanks!


chore: folder structure changes

Description
The web-sdk alpha release branch is getting really out of sync with main, getting the change in folder structure in will reduce the overhead of changes made that are independent of anything related to web.
Work Done

Included folder structure changes found in alpha-release branch

How to test

Review any recent changes and confirm they are included in this

@stevensJourney I have not updated alpha-release branch yet as I wanted to do this in steps to avoid overwriting things unintentionally. I collated the changes though between the two so all of Ralf's changes should be in here with the folder structure changes you made in alpha-release.


Test docsgen

This PR is just a test of a change to the Docsgen reusable workflow.  (See https://github.com/arcalot/arcaflow-docsgen/pull/45.)

By contributing to this repository, I agree to the contribution guidelines.

Testing complete.  And successful!


refactor: isolate attribute package

Regenerate mixer files. Move finder and expression interfaces to attribute package.
Signed-off-by: Kuat Yessenov<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kyessenov
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: douglas-reid
If they are not already assigned, you can assign the PR to them by writing /assign @douglas-reid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

bin/OWNERS
mixer/OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: douglas-reid, kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

bin/OWNERS [douglas-reid]
mixer/OWNERS [douglas-reid,kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Copy Result Table not working

Issue Type: Bug
why do you release versions that completely break any working feature? this time am unable to copy results table! this was fixed 6 months ago.
Azure Data Studio version: Azure Data Studio 1.3.9 (cacf0777c747046af6839de3688d709b10ef9fca, 2019-01-14T23:17:16.459Z)
OS version: Darwin x64 18.2.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-5650U CPU @ 2.20GHz (4 x 2200)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
43, 12, 6

Memory (System)
8.00GB (2.06GB free)

Process Argv
/Applications/CCApps/Azure Data Studio.app/Contents/MacOS/Electron -psn_0_9283802

Screen Reader
no

VM
0%

Extensions: none

I am having the same issue where if I try and right click to copy the results with headers or without header. the box don't not appear no matter what I do. I tried closing and reopening the application. It did not solve the issue.  The only way to copy results now is to select all and control + C and control V. Or to export to excel directly.  This is a regression and should be priority.

@JASM2007 are you also using 1.3.9 on macOS?

I’m always on the latest and greatest software released version. I use the
program nearly everyday and check for updates. I am on the January hotfix
version.
On Fri, Feb 1, 2019 at 3:55 PM Karl Burtram<EMAIL_ADDRESS>wrote:

@JASM2007 https://github.com/JASM2007 are you also using 1.3.9 on macOS?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/azuredatastudio/issues/3823#issuecomment-459864591,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AmwJtgshg4H6QfWHn1shkQvgAI4d1OZZks5vJKm_gaJpZM4aSLC1
.

--
Best Regards,
Jason L. McKay

The only other context I can give. When it was working the last time to
right click and copy header I clicked off or clicked another part of the
program. Then when I went back to right click it never allowed it again.
Even still right now I can’t right click to copy headers and I was using
the program all day. I might try restarting the computer to see if that
does anything.
On Fri, Feb 1, 2019 at 6:27 PM Karl Burtram<EMAIL_ADDRESS>wrote:

@JASM2007 https://github.com/JASM2007 thanks for helping us improve the
product! I haven't been able to repro this issue on Windows (and left my
mac at home today).
@anthonydresser https://github.com/anthonydresser any ideas what's
happening here? If there's a regression in this area we'll need to fix for
Feb.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/azuredatastudio/issues/3823#issuecomment-459903119,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AmwJtrPTr4tUIf_9daHj5VEPjV3LEkWHks5vJM1kgaJpZM4aSLC1
.

--
Best Regards,
Jason L. McKay

So the context menu just stops working? I've never heard of this before. I'm not sure what the problem would be.

Some additional Observations:
Copying small result table (upto 500 rows) in a new Azure Studio session works.
Copying small result table works sometimes in an open Azure Studio session.
Copying large results never works.
Dumping large results to file is very slow.
As a workaround I'm now using Jupyter notebook to query and dump results on excel. Seems so much faster than Azure studio can display.

Thanks for reporting this issue!  We're tracking this bug with https://github.com/microsoft/azuredatastudio/issues/1388.  We plan to have a fix in an upcoming release.


Upgrade off of deprecated geometry library; refactor/repackage files

[x] Repackage on a per-service basis.
[ ] Pull in documentation from OSRM docs.
[x] Upgrade from legacy geo libraries (go.geo and go.geojson) to the newer orb library.
[ ] Fix broken unit tests.

The unit tests for unmarshalling are failing due to a precision error, and the marshalling tests are failing due to a double-quoting error.


push should have method that takes in Installation

Current push methods take in two forms:
register(token)
register(token, templates)
We need an additional:
register(Installation)
that reflects https://msdn.microsoft.com/en-us/library/azure/microsoft.azure.notificationhubs.notificationhubclient.createorupdateinstallation.aspx.
There's no way for customers to pass tags in from the client side currently, hence they won't be able to take advantage of the app service push endpoint tags feature.

I saw in release 3.4.0 the method register with installation was added to MSPush.
Is there an update on the expected completion on this issue?
Thanx

@antitheos Thanks for using Azure Mobile Apps and your interest in adding this feature in the SDK. Please refer to the section on the ReadMe that highlights the future of Azure Mobile Apps. At this time, we are not adding any new features in the SDK but your interest will help us in the future.
Hope this helps. I'll close this issue but feel free to reach out if you have any other questions.


win: Do not call GetSystemTimePreciseAsFileTime on Windows 7

Modify uv_clock_gettime so that GetSystemTimePreciseAsFileTime is only used if OS supports it, otherwise GetSystemTimeAsFileTime is used. GetSystemTimePreciseAsFileTime is supported on Windows 8 or newer.
Without this change, any program using libuv that runs on Windows 7 will not start but get a dialog 'Entry Point Not Found' with text 'The procedure entry point GetSystemTimePreciseAsFileTime could not be located in the dynamic link library KERNEL32.dll.'
For reference, see https://stackoverflow.com/questions/54933940/what-clock-does-the-visual-studio-2017-crt-implementation-of-stdchronosystem.

Windows 7 is no longer supported: https://github.com/libuv/libuv/blob/v1.x/SUPPORTED_PLATFORMS.md

Would support for Windows 7 fall under the 'Other' system that has 'Tier 3' support then? Tier 3 is community maintained. Our company is interested in having libuv function on Windows 7. Without this minor change any programs run on Windows 7 using libuv won't run at all.

Windows 7 is EOL years ago and even Node dropped support for it: https://github.com/nodejs/node/pull/31954
Reviving support for Windows 7 is not something the project is open to I'd say.
Ping @libuv/collaborators

Windows 7 is EOL years ago and even Node dropped support for it: nodejs/node#31954
Reviving support for Windows 7 is not something the project is open to I'd say.
Ping @libuv/collaborators

+1. win7 is deprecated, also python and electronjs dropped support.
If you still want to make win7 compatible, you can make a fork. Thx for the idea.


Hand Mesh doesn't appear in HandTracking scene

I am attempting to see the Hand Mesh visualization in the Hand Tracking scene using Holographic Remoting for Play Mode. The hand joints are tracking like they should, but toggling "Hand Mesh" on and off does nothing. In HandMesh.cs, the method on line 35,  handMeshTracker.TryGetHandMesh(FrameTime.OnUpdate, mesh), always returns false.

This is expected because the hand mesh API unfortunately isn't supported by the remoting runtime. You can see which features are unsupported at https://docs.microsoft.com/windows/mixed-reality/develop/native/holographic-remoting-troubleshooting#limitations

I see. Thanks!


Cannot use --tmpfs options on mac client

Output of docker version:
docker version
Client:
 Version:      1.10.3
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   20f81dd
 Built:        Thu Mar 10 21:49:11 2016
 OS/Arch:      darwin/amd64

Server:
 Version:      1.10.3
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   20f81dd
 Built:        Thu Mar 10 21:49:11 2016
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 21
 Running: 5
 Paused: 0
 Stopped: 16
Images: 251
Server Version: 1.10.3
Storage Driver: aufs
 Root Dir: /mnt/sda1/var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 350
 Dirperm1 Supported: true
Execution Driver: native-0.2
Logging Driver: json-file
Plugins:
 Volume: local
 Network: bridge null host
Kernel Version: 4.1.19-boot2docker
Operating System: Boot2Docker 1.10.3 (TCL 6.4.1); master : 625117e - Thu Mar 10 22:09:02 UTC 2016
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 1.955 GiB
Name: docker10
ID: 4FOA:7EK3:JYC4:UNXI:AAGA:T7CQ:SSUC:NT3G:ZU5N:7EE7:DZ6H:JIR4
Debug mode (server): true
 File Descriptors: 127
 Goroutines: 162
 System Time: 2016-04-20T19:22:58.127725296Z
 EventsListeners: 0
 Init SHA1:
 Init Path: /usr/local/bin/docker
 Docker Root Dir: /mnt/sda1/var/lib/docker
Username: cjellick
Registry: https://index.docker.io/v1/
Labels:
 provider=virtualbox

Additional environment details (AWS, VirtualBox, physical, etc.):

Reproduced on vmware b2d and vmware rancherOS
Requires running docker commands from Mac

Steps to reproduce the issue:

From Mac, run this: docker run --tmpfs /tmp:exec -it ubuntu and you get

docker: Invalid tmpfs option ["exec"].
See 'docker run --help'.

SSH into you docker VM and run the exact same command and it works just fine. Container is created with a tmpfs filesystem mounted at /tmp.

Describe the results you received:
I can't use tmpfs options because it is not supported on Mac.
Describe the results you expected:
The OS from which the docker CLI is used should not impact which tmpfs options are allowed.
Additional information you deem important (e.g. issue happens only occasionally):
It looks like the problem is that os specific validation is being called on the client side:
https://github.com/docker/docker/blob/3d13fddd2bc4d679f0eaa68b0be877e5a816ad53/pkg/mount/flags.go#L73

Ping @gdevillele @aduermael!

oh, actually, I think this is a duplicate of https://github.com/docker/docker/issues/20740, but looks like it was not looked into yet

Ah yes, definitely a dupe @thaJeztah. I swear I searched before submitting! :-P
Closing.

Haha, no problem, I just remembered it came up before, but forgot about it.


feat: Host Helm Chart

Would be great to host helm charts (e.g. Github Pages)

@sp71 hi, can you make a PR?


[ARVIR] After placing an artwork, don't update the positions of walls

With this merged ARVIR does not update the wall positioning after an Artwork has been placed, see slack for full context.

Seems legit!


Add Bitters to Gemfile

When following the excellent tutorial hosted on the thoughtbot blog, I realized that bitters is not included in the provided gemfile. Thought I would pull to add it.
This is my first pull request so let me know if anything needs fixing!

Hi @Maxfield-Chen!
Welcome! And thanks for the PR!
Bitters is actually already included in the template, just not as a gem. That’s because Bitters is a scaffold—a set of basic Sass variables, default element style and project structure—and not a library like Bourbon and Neat. Therefore, it’s added as raw files right to the project, and we encourage you to modify and extend them to meet your design and brand requirements.
You’ll find the Bitters files in source/assets/stylesheets/base.

Ah, sorry! Still very new to ruby dev and particularly to all the dependencies in this project. Really enjoying learning though, thank you for the kind response!


[AutoRelease] t2-oep-2022-11-15-77764(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/3412
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=3931

issue link:https://github.com/Azure/sdk-release-request/issues/3412


dyn Display primitive value

In some cases, it may be desirable for types implementing Valuable to record themselves as a pre-formatted human-readable text representation. Currently, this is only possible with the Value::String variant, which takes a &'a str.
For types that want to record themselves using a Display (or Debug) implementation, though, Value::String isn't really sufficient. Because it takes a borrowed string slice, those types would have to allocate ahead of time and store their own formatted representation, so that the borrowed string slice can be handed out in their Valuable impls. This is not ideal.
Therefore, we should probably add &dyn fmt::Display as a primitive Value variant.

I would also like this or a similar solution.
The workaround I use is to return a single-value tuple that is a String. This works well enough, but does add a layer of noise in the output I would prefer to avoid.
Here's an example:
struct MyStruct;

impl Valuable for MyStruct {
    fn as_value(&self) -> Value<'_> {
        // We don't store a String of the value, so can't return an &str
        // and use `Value<'a>::String(&'a str)`, encode as a tuple instead.
        Value::Tuplable(self)
    }

    fn visit(&self, visit: &mut dyn valuable::Visit) {
        let s: String = foo();
        let val = Value::String(s.as_str());
        visit.visit_unnamed_fields(&[val]);
    }
}

impl Tuplable for MyStruct {
    fn definition(&self) -> TupleDef {
        TupleDef::new_static(1)
    }
}


Feature request for ADLS...

Extend functionality to data lake store and allow to connect to Data Lake Store with DLS Name like adding Storage account with Key

@atefyaziz Can you clarify what you're asking?

Extend functionality to data lake store...
What functionality are you referring to that you want extended?
...allow to connect to Data Lake Store with DLS Name like adding Storage account with Key
Are you asking for one or two different ways to connect to ADLS here?

Point 2: Yes, I mean a sort of login screen like the one used to connect to Storage account, where user input {user name & Password & DLS_name } or {APP_Id & key & DLS name }
sometimes users get lost when they are connecting to environment with tons of data lake store account (like we already have) and a need to get focused to one Data lake store is important thing for them
thanks

@atefyaziz
For get lost in tons of data lake store accounts, could you try Add to quick access?
You can right click a data lake store account and choose the Add to Quick Access action.

And you can also link the data lake store via URL.

Right click the Data Lake Store(Preview) node under (Local and Attached).

Click Connect to Data Lake Store.

Input the URL of ADL, format is adl://accountname.azuredatalakestore.net/your/folder. Make sure you have login and have the access to the URL.

The retirement of ADLS Gen1 is now less than three months away. As previously announced the service will be retired on 29 February 2024. With this date now close approaching we are going to close this issue as "won't fix". Documentation on how to migrate your data to ADLS Gen2/blob storage can be found here: https://learn.microsoft.com/en-us/azure/storage/blobs/data-lake-storage-migrate-gen1-to-gen2-azure-portal
If you have any non ADLS Gen1 feedback for Storage Explorer, please feel free to open a new issue: https://github.com/microsoft/AzureStorageExplorer/issues/new/choose
This issue will now no longer be monitored.


chore(main): release 0.2.0

:robot: I have created a release beep boop
0.2.0 (2024-04-09)
Features

map parent_id to iCal's RELATED-TO (#15) (6780cbe)

Bug Fixes

accept negative timestamp on all platform (#23) (f2bf2f7)
Discard TimeTree's Birthday Event (#17) (aa407ba)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/eoleedi/TimeTree-exporter/releases/tag/v0.2.0 :sunflower:


Update build instructions to make use of Bundler

Hi, thanks for sharing this great project.
I found a minor issue while building the project.
Even though the project contains a Gemfile listing the dependencies, the current build instructions do not really make use of it.
I am just updating the instructions so that Cocoapods is ran on the expected version defined by Gemfile.
Pull Request Checklist

[ ] UI change has been tested on both light and dark themes
[x] Pull request is based on the develop branch
[ ] Pull request updates CHANGES.rst
[ ] Pull request includes screenshots or videos of UI changes
[x] Pull request includes a sign off

Hi @dcordero,
Could you add your sign off, please ?
(You can find at example at https://github.com/vector-im/riot-ios/pull/2390#issue-274351355)

Hi @manuroe, thanks for checking my PR. I have edited the description of this PR to include my sign off


go.mod update to containerd v2

Similar to #2902 - with the difference that it uses personal forks for pending PRs against important dependencies (updated against containerd v2).
Currently:

[x] fully updated to containerd v2 without any indirect to v1.7
[x] does build and run
[x] all dependencies have been updated to containerd v2
[x] unit test pass
[x] rootless tests pass
[x] rootful tests pass - some timeout failures currently
[x] windows is working

Upsteam dependencies to merge:

[x] https://github.com/data-accelerator/zdfs/pull/3
[x] (blocked, depends on zdfs ^) https://github.com/containerd/accelerated-container-image/pull/290
[x] https://github.com/containerd/stargz-snapshotter/pull/1722
[x] (blocked, depends on stargz) TBD nydus
[x] https://github.com/awslabs/soci-snapshotter/pull/1305/files

Upstream dependencies that do not have a proper PR (only our fork):

[x] Moby sysinfo package - folder has been copied under here for now - there is a couple of PRs hanging around but they look very stale (Derek' six months+ https://github.com/moby/moby/pull/47255 )
[x] hcsshim: has to be patched against their latest released version, and not main - main is breaking API, which would mean updating containerd against that (and it is probably unstable / untested anyhow). Our fork has a v2-backport branch that does that.
[x] nydus: current fork is bare minimum and there is definitely some more work needed on their CI tooling needed - it is based off main, which might not be the right choice - finally, nydus depends on stargz and hcsshim, which means these two have to get in first

@AkihiroSuda
See initial comment up there ^.
That was quite a trek, but CI is finally mostly green - and nothing depends on containerd v1.
I am a bit concerned over the failing ones though, timeouts feel like maybe something is deadlocked somewhere.
Anyhow, obviously this cannot be merged, since it depends on my forks - upstream PRs have to be merged first.
I opened a bunch of them already, and have more to come from my forks.
I can use some help there to move them along - I am not sure why they are blocked - I guess people are busy.
Specifically, moving these two that have been there for a couple of weeks now would get us started:

https://github.com/data-accelerator/zdfs/pull/3
https://github.com/containerd/stargz-snapshotter/pull/1722

Then we can look into the best approach for hcsshim and the rest.
Cheers.

Will rebase soon now that the stargz PR is in.

Latest state of affairs:

see top level comment for dependencies status updated list
CI is green EXCEPT test-integration-20.04-v1.6.33 which seems to hang on something and timeout
next important focus will be hcsshim - see discussion at: https://github.com/microsoft/hcsshim/pull/1958#issuecomment-2220991735

Status update:
Work is going on for nydus: https://github.com/containerd/nydus-snapshotter/pull/604
Nydus may be the last dep we need (as we may be able to ignore hcsshim for now).

@AkihiroSuda we are getting closer.
nydus was a lot more work than I thought and I had to send multiple PRs for a variety of issues that are pending.
At this point, we need nydus to come through, and then the soci PR to get in (maybe we can convince them to have it on an ad-hoc branch meanwhile, as they want to wait post-v2-release).
As far as nerdctl CI here is concerned, we get consistently green, with two exceptions:

#3228 which is racy, and possibly unrelated to containerdv2, but still failing a lot
ubuntu 20.04 + containerd 1.6 seems to always hit the timeout - either it is slower than before, or it is deadlocking for whatever reason

Question for you: when ctd v2 is out, should we still care about that (u 20.04 + containerd 1.6)? I can go and debug this, but only want to spend time on this if we actually care about it :-)
LMK your thoughts.
Thanks.

Thank you @apostasie for this hard work!

nydus was a lot more work than I thought and I had to send multiple PRs for a variety of issues that are pending.

If it takes time, we can temporarily remove the support for nydus in nerdctl v2.0 and then put it back in v2.1+.
I think this is acceptable, as we are bumping up the major version.
Same applies to SOCI too.

Question for you: when ctd v2 is out, should we still care about that (u 20.04 + containerd 1.6)?

Yes, as they haven't reached EOL yet.

Thanks Akihiro. You welcome :)
ack for u20+ctd1.6 - I will investigate.
For hcsshim, it seems now that we do NOT need them to upgrade, as the parts we are pulling in from them do not transitively require containerd, so, that is good news.
For soci, I gave them a ping to see if they would merge on a branch.
For nydus, let's give them a few days and see if at least we can get their CI fixed:

https://github.com/containerd/nydus-snapshotter/pull/606
https://github.com/containerd/nydus-snapshotter/pull/607
and then we can push to get https://github.com/containerd/nydus-snapshotter/pull/604 merged

Otherwise yeah, we can remove them temporarily.

@AkihiroSuda
We are (almost) there:

nydus and soci have been resolved - all dependencies we needed have been migrated and we are now using them instead of my forks
the ONE exception to above is moby/pkg/sysinfo - I did fork it out into ./pkg/sysinfo - I do not see another good solution (some discussion with Sebastiaan over here: https://github.com/containerd/nydus-snapshotter/pull/604#issuecomment-2270518210) - also see note in go.mod and in pkg/sysinfo/README.md - let me know if this OK
CI is green, EXCEPT Ubuntu 20.04 + containerd 1.6 - I am quite flabbergasted by this - it looks like it just hangs-up on after TestRunAttach - maybe inside TestStats? - and sits there forever - I'll see if I can dichotomy this to at least figure out which test is hanging, and try to reproduce locally

Beside this, I think this is ready for review.

Rebased.

@AkihiroSuda PTAL at your convenience.
No rush of course.
I'll keep rebasing this when it drifts.

lgtm, thanks

Thanks a lot for your time and review @djdongjin
Appreciated.

@AkihiroSuda: comments addressed.


Cover the "no-tests" or "tests after exercise end" case

Describe the bug
If there are no tests executed during the exam/not shown to the student, the students get shown "0%, 0 out of 0".
To Reproduce

Create exam with programming exercise without tests / create a programming exercise
Participate
Click on the exercise
See issue

Expected behavior
Either show 100% or allow a switch to replace this with "Compiled" and "Not compiled"

Fixed via #3293


Add Search in all disks

Description of the new feature / enhancement
pls give search in all disks like in macOS,
Scenario when this would be used?
so that we can use the power run to access folder and files fast and easily
Supporting information
No response

PowerToys Run should use the same settings as Windows Search. What are your search/indexing settings? Classic or full?

Switch to "enhanced search" in Windows Search from settings.


Support for python 3.9 & 3.10

Fixes #41

This change is

@liorgold2 is it possible to merge this small change? gives opportunity for toolchains to use latest Python releases

Is the extend instead of += also required for python3.9/3.10? Why?

I prefer extend(), but I don't think it matters.
Reasons for my preference:

More readable
Faster (https://gist.github.com/mekarpeles/3408081)
You can chain expressions
Consistency (have to pick one and try to be consistent, thus pick extend for first several reasons)

It really does not matter though in this context.

Hey - can this please get merged soon? Really hoping to use the newer python versions without having this issue: #41

Please see my comment above.

Hey - can this please get merged soon? Really hoping to use the newer python versions without having this issue: #41

Please see my comment above.

There is still incompatibility with frozendict standing in the way of supporting 3.10.x: https://github.com/Shard-Labs/starknet-devnet/pull/108

Please see my previous comment.
On Sat, May 21, 2022, 04:08 Dhrumil Shah @.***> wrote:

Hey - can this please get merged soon? Really hoping to use the newer
python versions without having this issue: #41
https://github.com/starkware-libs/cairo-lang/issues/41
—
Reply to this email directly, view it on GitHub
https://github.com/starkware-libs/cairo-lang/pull/43#issuecomment-1133490247,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJDO2JIE4A7NN4ODKKFNG3DVLAZSNANCNFSM5R6YSCYQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Rails 4, have to re-register handler after changing default extension name.

I have in my application.rb configuration changes to use an alternative file extension like hbs. However it seems like the renderer is registered before this change is made. Maybe I am doing things in the wrong order, however my workaround is to re-register the handlebars renderer after I've updated the extension.
ShtRails.template_extension = 'hbs'
ShtRails.action_view_key = 'hbs'
ShtRails.template_namespace = 'HighlyHBS'
ShtRails.template_base_path = Rails.root.join("app", "views")

# need to re-register the handler
ActiveSupport.on_load(:action_view) do
  ActionView::Template.register_template_handler(::ShtRails.template_extension.to_sym, ::ShtRails::Handlebars)
end

That last bit is just copied from the sht source:
https://github.com/railsware/sht_rails/blob/e52ab72b3e5eef0794787485edcac188a4812a49/lib/sht_rails/handlebars.rb#L39

Hello. Try to set this settings after Bundler.require(:default, Rails.env) in config/application.rb


Compiling as static library

Hi Paulo!
Is there a way to compile the API as a static library?
Or, at less, compiling using KLUSolver as a static library?
I've tried to do this, but I'm not familiar with fpc or any related to Pascal, actually.
I'm trying to create a version of this API (without COM compatible needs) in Rust for thread-safe operations, but the dynamic library is causing some memory issues, especially with the API KLUSolver dependency (I've been using your version).
I'm trying to avoid using a mutex. But if the static library is not possible, maybe it is the only solution...

I'm assuming you're using the 0.12.x branch, right? The 0.10.x branch is not suited for that and should happily segfault.
Pretty sure to get a static library, you just need to adjust the compiler and linker flags (for FPC, the src/*.cfg files), maybe change something in https://github.com/dss-extensions/dss_capi/blob/0.12.x/src/Common/KLUSolve.pas
For the KLUSolveX part, most can be adjusted at https://github.com/dss-extensions/klusolve/blob/master/CMakeLists.txt
Some of the aux build scripts (.sh, .bat) assume dynamic libs too.
Pascal is a dead-end and I rather not complicate the build process any further (also considering freezing some new/untested features from the offcial repo), so I personally won't look into this now. Feel free to send PRs though -- as long as nothing in the usual build breaks, I'm fine with changes.
Note that KLU and KLUSolve(X) are LGPL and OpenDSS is BSD-3. By linking them together, the whole blob is basically LGPL. We'll probably merge KLUSolveX into DSS C-API anyway soon, changing it to LGPL, but it's worth mentioning.

Ok, thanks! I've been testing in 0.10.x branch, but I will test in 0.12.x.
But probably I will use mutex anyway. I could

@felipemarkson Part of the issues was that 0.10.x used the default memory allocator for FPC. In 0.12.x, cmem is used. This one already uses thread sync objs, and it's a bit slower on Linux.
Also in 0.12.x we're fully using KLUSolveX, which rewrites and extends the upstream KLUSolve project, which is moribund.

But probably I will use mutex anyway

I'm still not sure why that would be required, but you might be able to just recompile KLUSolveX by tweaking the CMake file to use a different allocator, or remove some of the current build flags (like using the static runtime). A lot would depend on the rest of your system/libs.

Yeah, building the KLUSolveX as static I think is not the problem.
But I need to investigate how to link this to the API. On my last try, for some reason, the API doesn't recognize the KLUSolveX but compiled with no problem.

Do you prefer that I keep this issue open? If I make it, I can create a PR.

On my last try, for some reason, the API doesn't recognize the KLUSolveX but compiled with no problem.

You may need to edit KLUSolve.pas and adjust the linker flags (see https://www.freepascal.org/docs-html/user/userap1.html ). For experimenting, maybe using a custom link step like we used to on Linux for 0.10.x may help. See https://github.com/dss-extensions/dss_capi/commit/031a9b203cd49cd2af2781f452fcb17f9d74d386 for the commit that removed it.
Basically:

we used -sh to generate a link script instead of letting the compiler run everything by itself
then our custom_link.sh was used to adjust a few things, like adding aliases, and producing the final library

After 1, you could inspect the resulting objs/libs/scripts, and see better what failed and maybe why.
Nowadays, FPC 3.2.2 adds the process PID to the link script file name, but otherwise the approach should work.

Do you prefer that I keep this issue open? If I make it, I can create a PR.

Up to you, feel free to reopen whenever.

@felipemarkson I looked into this and my conclusion is that it's not worth the trouble with the Pascal version, FPC does not support generating static libs in the current version anymore, and linking the objects manually is cumbersome.
We should have a full C++ port soon and that will be trivial to build statically -- effectively we will merge the klusolvex into this repo and the build process will be nearly the same with CMake, including the static lib option added by your PR.
Also of note, I've ran a bunch of multi-threaded tests this past month, including multiple different memory allocators (currently I recommend jemalloc or mimalloc). Through those tests, I found some minor issues and restructured some of the Pascal code. Notably, it is a good idea to force the Pascal side to create a single thread to initialize the thread local stuff of the memory allocator (this seems required on Linux, on Windows it doesn't seem so). So, running a DSS_Start(0); will now do that if required. After that, you can create new OpenDSS instances with ctx_New() and use the ctx_* functions with different contexts in different threads without issue.

I'm trying to create a version of this API (without COM compatible needs) in Rust for thread-safe operations, but the dynamic library is causing some memory issues, especially with the API KLUSolver dependency (I've been using your version).
I'm trying to avoid using a mutex. But if the static library is not possible, maybe it is the only solution...

If you still find issues, please try to provide some minimal sample code so I could try to check it. Note that using a single OpenDSS instance across threads would not work since it's not thread-safe -- the whole point of creating the new ctx_*/DSSContext API was to sidestep this limitation.
(pinging @keegit since he mentioned Rust too)

I looked into this and my conclusion is that it's not worth the trouble with the Pascal version, FPC does not support generating static libs in the current version anymore, and linking the objects manually is cumbersome.

What version do you refer to? The lasted commits made this impossible? Because I already have to compile it as a static library, I do not have time to create a PR yet.

We should have a full C++ port soon and that will be trivial to build statically -- effectively we will merge the klusolvex into this repo and the build process will be nearly the same with CMake, including the static lib option added by your PR.

When this merge occurs, will you guys change the license? I thought that it's possible to use another solver than klusolvex to avoid the GPL, like Eigen's Sparse LU that uses a more permissive license (MPL V2) which can allow a fully static compilation without the GPL issues.
Maybe, it could be done by creating an interface between the OpenDSS and KLU that other solvers can use to replace KLU. I could implement that, but my knowledge of Pascal don't help me a lot when I tried to change this file src/Common/KLUSolve.pas.

What version do you refer to? The lasted commits made this impossible? Because I already have to compile it as a static library, I do not have time to create a PR yet.

I mean linking the objects (.o) from DSS C-API (+ the dependencies from FreePascal) + the objects/static lib from KLUSolve into a new static lib (let's say "libdss_capi.a"). That doesn't seem feasible for all platforms, and would require the final binary to call some FPC functions that are called automatically when loading a .dll/.so.
Just linking KLUSolve into DSS C-API is simpler but doesn't add much value right now, but doesn't hurt either. For the official releases, KLUSolve was kept as a separate DLL for a few reasons:

Different licenses
OpenDSS and KLUSolve use different programming languages, it's easier to compile each one and was easier to setup on CI etc.
It's a good idea to rebuild KLUSolve itself with custom flags (e.g. -march=native) for large scale clusters to gain a few percent points of performance. The Pascal part is not affected and doesn't need to be recompiled.

When this merge occurs, will you guys change the license?

Maybe not, but the final DLL will probably be inherently LGPL'd if we link KLU itself statically. If that has performance advantages (think link-time or profile-guided optimization), we will default to that. I think LGPL is fine, the GPL is the one that presents more issues.
On KLUSolve, it's mostly a wrapper to KLU. It becomes unnecessary, since most of the code is trivial things to interface C++ with C, or redundant implementations (dfs used in FindIslands) since Eigen already contains that. The rest of the original KLUSolve was removed in our fork in 2020 or earlier.
KLU itself is very important for good numerical compatibility with the official OpenDSS. We can and will add other solvers, but not remove KLU for the general version for a while. If we can show that other solvers are acceptable, maybe even publish a paper about that to list as a reference, we can finally mark KLU as optional.


Challenge DF nmse values are too low

Background / motivation
For a given submission, if I look at plots of predicted vs actual, it can qualitatively look way off. But nmse values are still on the order of 1e-6 to 10e-6. Whereas they should probably be around 0.1 - 0.5.
It's scaling the values too much.
But do note it still computes the winners correctly, because scaling doesn't affect the rank-order of winners.
We've known this for a while. It hasn't been a priority to fix, because we still compute winners correctly.
However the DF frontend does report nmses, it's gonna be confusing. So the priority is higher than before.
Related: slack discussion
TODOs
To fix: scale the values more properly
Note: I [@trentmc] know exactly what's needed, so I can take this. But it's lower-priority compared to other things

There is big difference in computing averages and financial trade.
With the current formula, it only takes into account the difference.
Example:
User1:    1800,1804
User2:    1798 , 1800
Cex prices:  1799,1802
both users will have the same nmse , but if you trade with user1's data, you will have some profit. With user2, you have a loss.
Proposal for formula:

for each candle, try to compute the actual profit.

If price is > than previous candle, then simulate a buy and calculate profit

If price is < than previous candle, then simulate a sell and calculate profit

Use accumulated profit(or loss) as a baseline for judge

@alexcos20 thank you, I will take this into consideration when I work on it.
And I will increase the priority, given your comments here and in slack.

[Alex] There is big difference in computing averages and financial trade.
With the current formula, it only takes into account the difference.
...
Proposal: .... Use accumulated profit(or loss) as a baseline for judge

I thought more about this.
The description has been updated to have , we have two options:

fix both "(a) nmse measure is too low" and "(b) concern that not profit-oriented"
fix just "(a) measure is too low"

Datapoints:

The goal is of Challenge DF is to onboard people into being Predictoors.
If Challenge DF is too much friction to get going with, they simply won't start
AI/ML people are used to minimizing error (nmse or similar). Most of their training algorithms are around this. If we ask them to optimize for something else, it greatly shrinks their toolbox, in many cases needing 10x more effort just to get going
Predictoor itself rewards predictoors for accuracy, not accumulated profit or loss
If we did ship this, we'd have to communicate this and explain. Not huge effort, but not negligible either. Predictoor needs to be our focus
Because Challenge DF is just a path to Predictoor, we shouldn't spend too much of S3 time on it (or Ocean DF rewards budget). Currently 5000 OCEAN, perhaps even lower in the future
Not doing (b) means more time on Predictoor, including helping people build better predictoors and traders

Therefore I recommend: option 2: fix just "(a) measure is too low", at least for now

Plots for (a), with status quo measure of nmse
    # values taken from Predict-ETH round 7, see https://rb.gy/2bzw9
    # rank1 is first place, rank2 is second-place, rank3 third-place.
    # rank83 is 83rd place, the lowest-ranked for nmses < 1.0 (in round 7)

Plots for (a), with new measure of nmse
New measure of nmse scales CEX values and predicted values such that:

CEX values are in range [0.0, 1.0]
predicted values follow the same scaling factors

Setup:

Like before
Except with new measure of mnmse

Results:

See images below

Analysis:

Now, all four nmses look sane. The first ones are 10% - 20%, which is about right. And the rank-83 one is super-high (about 900%) which makes sense too.

Conclusion:

Ship it:)


Explicit configuration of environment via Configuration

I was able to explicitly set the environment like this (at least a few beta's back) ...
var configurationBuilder = new ConfigurationBuilder().AddEnvironmentVariables();
Configuration = configurationBuilder.Build();
Configuration["ASPNET_ENV"] = EnvironmentName.Development;
if (env.IsDevelopment())
{
    // do this
}
else
{
    // do something different
}

... but that no longer works (at least in IIS Express) and nor does setting it this way ...
Environment.SetEnvironmentVariable("ASPNET_ENV", EnvironmentName.Development);

How is it currently done (in RC1)?

Answered here: https://github.com/aspnet/dnx/issues/3214#issuecomment-160432649


Add test files for several btwn 22354 and 22919

The following tests in this range were not added: 22354, 22387,
22465, 22713, 22781, 22872, 22874. Where possible, the tests come
from the shortest possible code samples to reproduce the ICE.

Thank you so much!

It looks like the ones that got checked off on the tracking issue were the ones listed here as not added, and vice versa?

Happy to! I definitely want to take a look at some of the trickier ones (e.x. rust-lang/rust#22354) that will take some more time to understand what's going on from the submitted code sample.
@steveklabnik: this PR added tests for 22565, 22566, 22603, 22789, 22894, and 22919. Sorry for the confusion.

Oh! I mis-read, darn. Thanks @wheals , I'll fix it.


Update sbt-scalafix to 0.9.8

Updates ch.epfl.scala:sbt-scalafix from 0.9.7 to 0.9.8.
Release Notes/Changelog
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.epfl.scala", artifactId = "sbt-scalafix" } ]

labels: semver-patch

Codecov Report

Merging #738 into develop will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #738      +/-   ##
===========================================
+ Coverage    89.29%   89.33%   +0.04%
===========================================
  Files          114      114
  Lines         8955     8955
  Branches       330      330
===========================================
+ Hits          7996     8000       +4
+ Misses         959      955       -4

Impacted Files
Coverage Δ

...ala/com/twitter/algebird/ApproximateProperty.scala
72% <0%> (-10%)
:arrow_down:

...main/scala/com/twitter/algebird/monad/Reader.scala
50% <0%> (-5.56%)
:arrow_down:

.../main/scala/com/twitter/algebird/Successible.scala
87.5% <0%> (-4.17%)
:arrow_down:

.../src/main/scala/com/twitter/algebird/ExpHist.scala
96.66% <0%> (+1.11%)
:arrow_up:

.../main/scala/com/twitter/algebird/Applicative.scala
61.76% <0%> (+2.94%)
:arrow_up:

...src/main/scala/com/twitter/algebird/Interval.scala
82.6% <0%> (+4.34%)
:arrow_up:

...in/scala/com/twitter/algebird/scalacheck/Gen.scala
100% <0%> (+9.09%)
:arrow_up:

...scala/com/twitter/algebird/PredecessibleLaws.scala
86.66% <0%> (+13.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 935f4bb...1d6f534. Read the comment docs.


Compare the benchmarking between the Heun scheme function in Fortran and Python.

In this way, we are going to find which of these gives us the best performance.

I think that we already find which version of the Heun Scheme works better. Thus, we can choose Fortran as the main language and delete some code that we are not going to use.


Pride flag loading delay

Describe the bug
When a pride flag is set and the page is reloaded the logo is briefly flashed before the pride flag is loaded
Expected behavior
The pride flag is instantly loaded similar to how themes are instantly loaded
Affects all devices but is especially noticeable on iOS

https://user-images.githubusercontent.com/44071655/113814460-b0ceaa80-973f-11eb-967d-bc2af31c51d8.mp4


golang/tutorial failed unless I installed kubebuilder

Bug Report
This is exactly the same as closed issue https://github.com/operator-framework/operator-sdk/issues/3461
What did you do?
I followed this tutorial today:
https://sdk.operatorframework.io/docs/building-operators/golang/tutorial/
I run it until got to this command:
make docker-build docker-push IMG=<some-registry>/<project-name>:<tag>

What did you expect to see?
Should pass
What did you see instead? Under which circumstances?
Got error:
failed to start the controlplane. retried 5 times: fork/exec /usr/local/kubebuilder/bin/etcd: no such file or directory

Then I installed kubebuilder following this guide: https://book.kubebuilder.io/quick-start.html#installation
The ran again and this time is passed.
Environment
Operator type:

/language go

Kubernetes cluster type:
not sure

$ operator-sdk version
operator-sdk version: "v1.3.0", commit: "1abf57985b43bf6a59dcd18147b3c574fa57d3f6", kubernetes version: "1.19.4", go version: "go1.15.5", GOOS: "linux", GOARCH: "amd64"

$ go version (if language is Go)
go version go1.15.7 linux/amd64

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-16T11:56:40Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.5", GitCommit:"e6503f8d8f769ace2f338794c914a96fc335df0f", GitTreeState:"clean", BuildDate:"2020-06-26T03:39:24Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

Possible Solution
Either add kubebuilder to the list of prerequisite or remove the dependency.

Additional context

The following info will be in the FAQ section for the next releases:
Note: If using an OS which does not point sh to the bash shell (Ubuntu for example) then you should add the following line to the Makefile:
SHELL := /bin/bash
This will fix potential issues when the docker-build target runs the controller test suite. Issues maybe similar to following error: failed to start the controlplane. retried 5 times: fork/exec /usr/local/kubebuilder/bin/etcd: no such file or directory occurred
Could you please let me know if it solves your scenario?
Also, @estroz @jmrodri could we not find a solution that is valid for all envs and apply that in upstream?

The following info will be in the FAQ section for the next releases:
Note: If using an OS which does not point sh to the bash shell (Ubuntu for example) then you should add the following line to the Makefile:
SHELL := /bin/bash
This will fix potential issues when the docker-build target runs the controller test suite. Issues maybe similar to following error: failed to start the controlplane. retried 5 times: fork/exec /usr/local/kubebuilder/bin/etcd: no such file or directory occurred
Could you please let me know if it solves your scenario?
Also, @estroz @jmrodri could we not find a solution that is valid for all envs and apply that in upstream?

The root cause of this issue is make test failing (a dependency of docker-build) because of the shell issue. There are two upstream issues related to this problem (https://github.com/kubernetes-sigs/controller-runtime/issues/1234, https://github.com/kubernetes-sigs/controller-runtime/issues/1300), and the workaround suggested above is documented in the FAQ (will be updated next week), so I'm going to close this.

The root cause of this issue is make test failing (a dependency of docker-build) because of the shell issue. There are two upstream issues related to this problem (https://github.com/kubernetes-sigs/controller-runtime/issues/1234, https://github.com/kubernetes-sigs/controller-runtime/issues/1300), and the workaround suggested above is documented in the FAQ (will be updated next week), so I'm going to close this.


FEATURE REQUEST: change token image

I could manually change the image, but would be nice if there were a field to automate the change.
Example: Griffon with wings tucked to Flying Griffon with wings spread.
Great mod. Thanks!

Nice idea! would you mind to lend these 2 tokens for a test?

Added in the new version
https://github.com/LeafWulf/flying-tokens

Was just about to send you 2 tokens to test, but you've done it already.
Works well. Thank you!!!
On Fri, Oct 21, 2022 at 12:36 PM paulo-roger @.***>
wrote:

Closed #6 https://github.com/paulo-roger/flying-tokens/issues/6 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/paulo-roger/flying-tokens/issues/6#event-7642184048,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADUSBVZEB4X3KZ242ZX5IDWELBANANCNFSM6AAAAAAREZLPMU
.
You are receiving this because you authored the thread.Message ID:
@.***>

please do, I would like to add some screenshots of the feature

The attached tokens are from Forgotten Adventures creature tokens 35
https://www.forgotten-adventures.net/product/tokens/creatures/creature-tokens-pack-35/.
It's a free pack, but you probably should credit them. Thanks for the great
mod!
On Fri, Oct 21, 2022 at 4:36 PM paulo-roger @.***>
wrote:

please do, I would like to add some screenshots of the feature
—
Reply to this email directly, view it on GitHub
https://github.com/paulo-roger/flying-tokens/issues/6#issuecomment-1287413054,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADUSBS2XBOCNMH5IAJMNW3WEL5ENANCNFSM6AAAAAAREZLPMU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thanks! :)


Enable webchannel, websockets

@conda-forge-admin please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Nuget package restore failed for version 1.0.0

I am unable to to compile the bookstore project as it does restore the nuget package successfully.
Could you please advise how to get it work?

Regards,
Mostafa

In Visual Studio's Output Window can you select the Package Manager Log and see if there's anything there about what the error might be?
BTW what's the "bookstore" project? Do you mean Music Store?

This looks like NuGet v2, not ASP.NET 5

Hi Eilon,
Yes it is musicstore project. I will send the error log later. A lot of compile errors due to the nuget restore failure.
Regards,
Mostafa

The following errors are shown in the output window while restoring the packages.

Can you show the Nuget feed enabled for your project something like below ?

@mostafaasad  Closing for now. Please provide the requested info and we will take another look. Thanks.


Fix PHP 5.3 functional test suite on Travis

This issue is imported from pivotal - Originaly created at Feb 4, 2016 by Daan van Renterghem
Currently all suites pass except the functional-tests on PHP 5.3. This seems to be an issue that is Travis only, as the steps that fail on travis pass succesfully (albeit with a DOMDocument warning about an issue fixed in PHP 5.3.6) in the development vm which runs PHP 5.3.3.
Debugging this issue in order to fix it requires a lot of effort and time since the only workable instance is Travis itself, meaning changes need to be pushed to Github in order to have Travis start a build so that we can check the output (no access to the logs) we generate.
PHP 5.3 code compatibility is verified with the code-quality suite which passes. The functional tests pass in the development env which runs PHP 5.3.3 as well as on all other PHP versions.
With the above in mind, for now PHP 5.3+Functional-tests will be an allowed failure. This should be resolved however.
Est.: ??????

It has been decided that EB5 will only be deployed on the new stack that runs php5.6. Because of this, the PHP version requirement for EB5 can also be bumped to 5.6. This means that this issue is no longer relevant and can be closed. (Daan van Renterghem - Mar 11, 2016)


Enable to load parameters & convert fit_a_line model

Resolve #4
Resolve #3
The correctness has been verified in #11.

Do you know what the opset_import version is suppose to be? In either case I have version 2 and it will probably be best if we have the same one, so help me understand this

Shall we update README and the status after this pull request merged?
opset_import should stand for the version of published operators set. I guess it is because I used ONNX built from source, so I have higher ops version than yours.
https://github.com/onnx/onnx/blob/25747520f78c44b4f58c9ef65663c2de44470520/onnx/onnx-operators.proto3#L120


CMake 3.10 (Ubuntu 18.04 LTS) vs add_compile_definitions()

This statement is introduced in CMake 3.12, while Ubuntu 18.04 LTS (bionic) still has only CMake 3.10 in its repositories.
https://github.com/NXPmicro/mfgtools/blob/63b1d3cf473369d13a778fc32d46ee5d398128b4/uuu/CMakeLists.txt#L76
Something along these lines allows to compile from source on bionic.
-add_compile_definitions(TARGET_PATH="${CMAKE_INSTALL_PREFIX}/bin/uuu")
+if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.12.0)
+    add_compile_definitions(TARGET_PATH="${CMAKE_INSTALL_PREFIX}/bin/uuu")
+else()
+    add_definitions(-DTARGET_PATH="${CMAKE_INSTALL_PREFIX}/bin/uuu")
+endif()

Now we could even lower the cmake_minimum_required to VERSION 3.10, unless CMake 3.12 treats your C++14 sources significantly differently and is absolutely required.
Originally encountered errors for SEO:
CMake 3.12 or higher is required.  You are running version 3.10.2
Unknown CMake command "add_compile_definitions".

Apparently CMake version requirement has been bumped recently (30Oct) from 3.4 straight to 3.12 in 0a57288edd20b2f90e4a4d209d0104782a299302
The only other CMakeLists-related change in that commit is CMAKE_SKIP_RPATH which is supported even since CMake 3.0 or so.
I see no reason to depend on 3.12 for this project even though latest release is 3.19.1. You may argue otherwise.
For everyone else buliding on Ubuntu bionic, feel free to test for yourselves. I am not an expert in CMake or C++.  We don't use mfgtools/uuu to flash our targets (yet).

I am no idea. Can check with origin patch owner?


fix(ui): show short-lived access banner only in list

Description
After introducing the banner about additional information of short-lived access in the access control page when auth providers selected, the banner always showed (i.e. when listing providers as well sa creating them).
During creation the banner is more confusing instead of helpful, so changed the logic to only show when we're listing the providers.

Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change

see CI

Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

ocp-4-15-ui-e2e-tests failure is known and has fix in progress. We apologize for the noise.


[Bug]: Proxy changed to DIRECT when running Chromium through Puppeteer

Bug description
I call puppeteer.launch with the following options:
        launch: {
            executablePath: process.env.PUPPETEER_EXECUTABLE_PATH,
            headless: headless,
            args: [
                `--window-size=${width},${height}`,
                `--log-net-log=my_logfile`,
                `--proxy-pac-url=my_corporate_proxy.pac`,
            ],
            defaultViewport: null,
            slowMo: 0,
            devtools: true,
            env: {},
        },
        browserContext: 'incognito'

I expect my tests to run fine, however I observe that trying to fetch any URLs other than localhost does not work. Requests hang until timeout. I also get the same behavior if I open a new tab on the puppeteer chromium instance and try to navigate to google.com.
When capturing net logs, I initially see a PROXY_CONFIG_CHANGED event with the information I expect:
11: NONE
PROXY_CONFIG_CHANGED
Start Time: 2022-06-30 16:36:09.876

t=1645 [st=0]  PROXY_CONFIG_CHANGED
               --> new_config =
                      PAC script: my_corporate_proxy.pac

However after this, I see another event where proxy config is changed to use DIRECT connections:
23: NONE
PROXY_CONFIG_CHANGED
Start Time: 2022-06-30 12:54:40.226

t=1720 [st=0]  PROXY_CONFIG_CHANGED
               --> new_config =
                      Use DIRECT connections.

The launch command from the net log is:
...my_project_path/node_modules/puppeteer/.local-chromium/mac-950341/chrome-mac/Chromium.app/Contents/MacOS/Chromium
--disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess
--disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad
--disable-client-side-phishing-detection
--disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage
--disable-extensions --disable-features=Translate --disable-hang-monitor --disable-ipc-flooding-protection
--disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync
--force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic
--use-mock-keychain --enable-blink-features=IdleDetection --export-tagged-pdf --auto-open-devtools-for-tabs
--window-size=1200,1000 --log-net-log=my_net_log.json --proxy-pac-url=my_corporate_proxy.pac
--remote-debugging-port=0
--user-data-dir=/var/folders/3t/w37y325d5g9b4h2bgn399cph0000gn/T/puppeteer_dev_chrome_profile-kE0o7C
--flag-switches-begin --flag-switches-end
--file-url-path-alias=/gen=...my_project_path/node_modules/puppeteer/.local-chromium/mac-950341/chrome-mac/gen
--flag-switches-begin --flag-switches-end about:blank

If I copy/paste this same command into a terminal and run it, I have no issues connecting to proxy. Instead of getting configured to use DIRECT connections, I see this from the net logs in my non-puppeteer session, and it does not get reconfigured to DIRECT:
11: NONE
PROXY_CONFIG_CHANGED
Start Time: 2022-06-30 11:38:20.931

t=643 [st=0]  PROXY_CONFIG_CHANGED
              --> new_config =
                     PAC script: my_corporate_proxy.pac

Puppeteer version
13.1.1
Node.js version
14.18.2
npm version
6.14.15
What operating system are you seeing the problem on?
macOS
Relevant log output
No response

Do you have the same issue if you just run Chromium with those flags? I don't think Puppeteer is doing anything w.r.t. to proxy configuration and it looks like a chromium issue.

The strange thing is I do not encounter the same issue if I run Chromium (from the same binary) with those flags.
As an additional data point, I also tried running the Chromium directly with all of the aforementioned flags except for --proxy-pac-url, and this also did not encounter the same issue. To reiterate, in this experiment I deleted my proxy argument and Chromium was still able to connect, with net logs showing it successfully using my_corporate_proxy.pac, which is configured in my Mac system settings.
Is it possible that Chromium is pulling in some additional system settings that it can't access when run via Puppeteer?

Is it possible that when I run Chromium directly, it is pulling in some additional system settings that it can't access when run via Puppeteer?

Hm, it's possible although I am not an expert on proxy settings configuration in Chromium. One thing that might be affecting this is if you are running with a fresh profile or not (the --user-data-dir param): when you run manually make sure that an empty folder is provided via --user-data-dir.
Also, is the behaviour any different in the latest Puppeteer (with Chromium 104.0.5109.0)? Is there any difference between the headless/headful/chrome-headless?

I updated to Puppeteer to 15.2.0 and now it works as expected. Unclear what root cause was, but I'm glad it's working now. Thanks for your help!


Update Conda package name

Explicitly set Conda package name as h2o-wave

Addressed with https://github.com/h2oai/wave/pull/491

Addressed with https://github.com/h2oai/wave/pull/491


Feature/epam builder fix

Update pipeline-builder to latest dev.
Also adds a simple test to check if the library (not our code) is broken.
See failed first commit to confirm that it's broken.
See last two commit for passing tests

Does the upgrade have any bearing on dockstore/dockstore#2461?

Doesn't look like it.  Seems like the Angular 8 update may have fixed it though.


Make the IPython dependency optional

This modification replaces the IPython import with a try-except block. If IPython is not available, it sets ipython_display to the built-in print function.
Related: https://github.com/stanfordnlp/dspy/pull/269

Thanks so much! I had actually thought this was there already. It clearly wasn’t, not sure what I was misremembering.


The module file format is too new to be used by this version of the debugger.

In my SPM's Package.swift, I add Files package:
.package(url: "https://github.com/JohnSundell/Files", from: "4.0.0"),

For the following code where the loop begins I get the error shown later.
do {
    let datasetName = "img_align_celeba"
    let datasetFolderPath = "Downloads/\(datasetName)/\(datasetName)/\(datasetName)"
    let datasetFolder = try Folder.home.subfolder(at: datasetFolderPath)
    print(datasetFolder)
    // var label = 0
    datasetFolder.subfolders.forEach { (folder: Folder) in
        folder.files.forEach { (file: File) in
            if file.name.hasSuffix(".jpg") {
                let imageURL = URL(fileURLWithPath: file.path)
                let image = Image(jpeg: imageURL)
                //        let resizedImage = image.resized(to: (imageHeight, imageWidth))
                let resizedImageTensor = Tensor(copying: image.tensor, to: device)
                images.append(resizedImageTensor)
            }
        }
    }
} catch {
    print(error)
}

Error:
/Users/rahulbhalley/Library/Developer/Xcode/DerivedData/MyLibrary2-bjaqnypxfdzmordbplehccxduzlz/Build/Products/Debug/MyLibrary2: Cannot load Swift type information; AST validation error in "MyLibrary2": The module file format is too new to be used by this version of the debugger.AST validation error in "Files": The module file format is too new to be used by this version of the debugger.AST validation error in "Files": The module file format is too new to be used by this version of the debugger.
Folder(name: img_align_celeba, path: /Users/rahulbhalley/Downloads/img_align_celeba/img_align_celeba/img_align_celeba/)
warning: could not execute support code to read Objective-C class data in the process. This may reduce the quality of type information available.
Program ended with exit code: 9

What am I doing wrong? 🤔 It was working earlier (although I don't remember the version of Files). I created a new SPM too but in vain.

This seems like a potential duplicate of https://github.com/tensorflow/swift/issues/382. Though I'm not sure why your previously working workflow is now broken.

This issue is tracked at SR-12127. It's actually an issue in Xcode: Xcode uses system lldb instead of lldb from the active toolchain. The occurs even for swift.org/download toolchains and isn't specific to Swift for TensorFlow.
Unfortunately, our team can't help fix this issue since Xcode is closed source.

You could try reporting the issue to Apple via Apple Bug Reporter. This blog post has more info on how to do that.


Fix parse_named_params() when there's special chrs in the query

I wasn't able to use mysql-async with queries that have params since I have accentuated characters in some tables.
Params still can't have accentuated characters but it's less critical since I can name the params how I want but I can't rename (easily) the tables.
I may do a second PR for the params.

That's great. Thanks!
Could you please remove call to enumerate on line 29 since now it is redundant, and i will merge it.

I updated the commit.

Thanks again. I will try to publish this today (but not before 5 PM MSK).


Message signer implementation

This provides interfaces for signing HTTP requests as per the HTTP Message Signing RFC.
The initial implementation provides:

HTTP Request signing using rsa-sha256 or rsa-sha512
Digest header generation using SHA-256 or SHA-512
Signature population on either Authorization or Signature header
Support for the (request-target) special case signature string header

Approved.


chore: include index.ts in src

Summary
This PR should solve #22
index.js was not included in files to be type-checked, and index.d.ts was not created.
I've also added a yarn prepare script so this package will be built before publish.

Compatibility

OS
Implemented

iOS
✅❌

Android
✅❌

Checklist

[x] I updated the typed files (TS and Flow)

@xcarpentier The package is now available as @react-native-community/hooks :tada:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


image operating system "windows" cannot be used on this platform

Expected behavior
I want to Winodws APP download
Actual behavior
image operating system "windows" cannot be used on this platform
Information about the Issue
I am test docker
OS: windows 10
I installed docker and Kitematic
In kitematic download Active directory,
But image operating system "windows" cannot be used on this platform
Do not Windows APP support in the docker?
thanks

This is a Windows Container image only - Please see the documentation for this image and the requirements.
To learn more about Windows Containers, please see this post:
https://blog.docker.com/2016/09/build-your-first-docker-windows-server-container/
Additionally, if you're running Docker for Windows, you can switch to using windows containers:
https://docs.docker.com/docker-for-windows/#switch-between-windows-and-linux-containers


Fuzz Testing Firestore using CMake

Added cc_binary rule to allow executables.
Added libFuzzer as an external project that Firestore depends on.

LibFuzzer is checked out from its SVN repository.
LibFuzzer is built using its build.sh script to produce the library libFuzzer.a.
Added a FindLibFuzzer.cmake script that looks for libFuzzer.a.

Added a new cmake option FUZZING to enable fuzzing and adding  the appropriate compiler flags.

Added fuzzing_options.cmake rules to check for compiler
type and add the fuzzing flags accordingly.

Added a firebase_firestore_fuzzing_serializer target that depends on libFuzzer and firebase_firestore_remote to fuzz test the serializer.

Supporting CMake
Supporting fuzzing in cmake allows us to run the fuzzing on platforms other than macOS (specifically Linux and maybe Windows). This support is crucial for OSS-Fuzz (see below) as our code will be fuzzed on an Ubuntu 16 docker image. Using CMake implies that we are limited to fuzzing the C++ SDK that is under development.
Compiler Versions
LibFuzzer is already included in CLANG >= 5.0 (specifically versions > April 20 2017). It can be used by adding -fsanitize=fuzzer as both compile and linking flags. For all other compiler versions (e.g., GNU or older CLang 4), we have to manually link its library.
OSS-Fuzz
With the goal of integrating cmake fuzzing in oss-fuzz, oss-fuzz provides its own fuzzing engine library and should be linked via -lFuzzingEngine.
We have a green light to start integrating Firestore in OSS-Fuzz once we have an initial fuzzing target.
Travis CI fuzzing
Our current travis environment uses a macOS image. The choice of the macOS image determines the CLang version that is provided with it. Therefore, we may or may not be able to rely on having libFuzzer in the travis-provided environment (needs more investigation).
Local fuzzing
On Linux desktops, building LibFuzzer is needed if the default compiler is not CLang with a version > 5.0.


release rust client 5.0.0

change the version of rust client from 5.0.0-rc1 to 5.0.0

Codecov Report

Merging #583 (1ccb9a5) into master (01deef8) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #583      +/-   ##
============================================
+ Coverage     46.25%   46.28%   +0.02%
  Complexity      650      650
============================================
  Files           207      207
  Lines         11990    11990
  Branches       3405     3405
============================================
+ Hits           5546     5549       +3
+ Misses         6200     6198       -2
+ Partials        244      243       -1

Flag
Coverage Δ

rust
80.72% <ø> (+0.09%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix the documentation to reflect the code

Thanks for the pull request.
The change looks good to me, but I'm away from home at the moment. I'll merge this in as soon as I can.

Thanks!


Typo for Example B

Should be:
SELECT SalesOrderID, OrderDate,
OrderDate AT TIME ZONE 'Pacific Standard Time' AS OrderDate_TimeZonePST,
OrderDate AT TIME ZONE 'Central European Standard Time' AS OrderDate_TimeZoneCET
FROM Sales.SalesOrderHeader;

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fc8b3b24-5a50-6b88-277a-e8ce528b49b2
Version Independent ID: ed560876-5e84-cb31-1bd4-65b3b0e5da8b
Content: AT TIME ZONE (Transact-SQL) - SQL Server
Content Source: docs/t-sql/queries/at-time-zone-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @VanMSFT
Microsoft Alias: vanto

@ByronBarton - thanks for the feedback! I've assigned this to the author @VanMSFT
Thanks!

Hi @ByronBarton! Thank you so much for catching this! We really appreciate your feedback, and helping us with the documentation. I have made the changes to fix the typo, and they will appear live soon. I'll go ahead and close this request now, but if you have any concerns, please let us know. Thanks again!
https://github.com/MicrosoftDocs/sql-docs-pr/pull/10605


deprecate EC_POINT_make_affine and EC_POINTs_make_affine

Related to what's going on in #8332.

Deprecate EC_POINTs_make_affine. I have only ever seen one caller to this -- internally in ec_mult.c.
Deprecate EC_POINT_make_affine. Since there is no longer any visibility inside an EC_POINT -- there is no noticeable state change for linking applications. Applications no longer reach in like P->X to get at the BIGNUM, but use the API like EC_POINT_get_affine_coordinates to fetch them -- where this conversion happens internally by the EC_METHOD automatically.

Apologies -- I fat fingered the CHANGES.md in the last PR. My glasses have been in my work office since quarantine started and the alignment was a little off :nerd_face:

Travis failures are unrelated: some timeout on Xenial builds when fetching required packages with apt

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged to master. Thank you for the patch!


Revert "Add a steam import service"

Reverts connorshea/VideoGameList#1174
Since it apparently broke production 🤷

Figured out the fix, so no need to have this anymore.


Putting undefined as store name doesn't throw an exception

Contrary to my expectations, attempting to create an instance with the name of undefined works perfectly. The primitive value undefined is somehow converted to string "undefined" and then a perfectly working key store by that name is created. Could we perhaps add input validation and throw an exception when the user attempts to access a keystore by the name of primitive value undefined?
IndexedDB is being chosen as the driver, and I'm on Chrome, if that makes any difference.
The image should be self-explanatory:

This would be a breaking change but I'm definitely happy to see more input validation for things like database names, versions, etc. 👍


Meaning of split train test val gobot

Hello
I have a problem with undestanding how to create my own set for gobot because i cant see any difference between trn tst val files in dtsc2.
Am i missing something?

Hi
trn, tst and val files have the same format but serve different purporses. trn is used to train (update weights of the gobot network), val is used for calculating performance during training (the scores are then used to decide when to stop training), tst is used for calculating final score of the trained model.
Does it answer your question?

Partly.
In this case should I provide absolutely different set for train valid and test?

That’s right. There must be no shared samples in train, valid and test.

Do you have per_item_dialog_accuracy on train too? Then it can’t be caused by wrong train/valid/test. The problem is somewhere else

I have per_item_dialog_accuracy  just as metric. As I can see , I'm getting zero accuracy because not working slot_filling.
Instead of slot value I see in y predicted only #slotname.
Is there problem with dstc_slot_vals.json?

Yes, the case seems to be in slot_filling component.
Did you retrain slot_filler component for your set of slots?

Just in progress
Is that notebook 2 from tutorial?

Notebook 2 is ok.
The documentation page might be more useful.

In Go Bot, training takes lot of time and even in terminal it is not getting completed even after 6 hours, can we have any other solution to this

Hi @skbalahere,
go_bot trains ok on DSTC-2 for all configs.
What dataset do you use to train the go_bot and which config file?


fix: preview build on PRs must ignore roadmap build

Long story here.
Once upon a time, something new showed up on the website, a roadmap view. It is a view that is built dynamically using GH GraphQL API and ZenHub API.
Tokens are needed, tokens are secrets, tokens should not be available for anyone. True story.

Another side of this story is that we provide PR preview builds. Cool huh? But we work on forks, everybody works on forks. Preview builds need to build a website with your changes so run in the scope of the fork. This basically means that someone can console.log the environment variables with secrets and 😨 yup, we are doomed.

Netlify is a good angel here. Then noticed we have secrets and immediately reconfigured our builds in the way that we need to manually approve PR preview builds after reviewing the code and checking if someone console.logs secrets.
All good, but long term, well, who wants to click Admit over and over. Especially that changes to roadmap view are super rare, while other changes are done ofter, like new blog posts etc.

I changes settings that we would always build without a need to Admit the build, but we just need to run those builds without secrets.

All good, right? no, because now preview builds always fail as we have a bug. Every build fails as roadmap.json file is not available because it was not created due to fail in communication with the API. You know, because we do not pass secrets.

This PR makes sure that PR preview build runs without problem on a fork. When there is no token, empty roadmap.json file is created and empty roadmap view rendered. I think it is acceptable looking on the amount of PR related to roadmap vs amound of PRs related to !roadmap

side story, when I write roadmap and !roadmap I immediately remind myself about this 🤣

@jonaslagoni please tell me you took the time to read my touching story? It doesn't have to be true, you can lie 😄

Of course I did :D


When ghprb version is new enough, emit configVersion 3

Earlier versions of the ghprb did not have regex matching for trigger phrases.  When this was introduced, the config upgrade process quoted the trigger phrase strings.  Because the DSL does not emit configVersion 3, a regex trigger phrase will get quoted when it doesn't need to even to.

/cc @tannergooding

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

There may be some users who rely on this (mis)behavior. This change will break compatibility for them and the problem will probably be hard to spot.
Making the configVersion explicitly configurable would solve that. Everyone who needs the new behavior can set the version to 3 or whatever.

@daspilker What about changing it to add a "regexTriggerPhrase" element?  If regexTriggerPhrase is used (mutually exclusive with triggerPhrase), then the output triggerPhrase is left unquoted. If triggerPhrase is used, the output triggerPhrase is wrapped with \Q \E (as the plugin would do on the upgrade path).  In both cases configVersion is set to 3 if the version is 1.27 or higher.

Updated and rebased.

But what if someone is using triggerPhrase with 1.26 or older? Then configVersion will not be set, but the triggerPhrase will be wrapped with \Q \E. That will break compatibility.

I will contact the ghprb-plugin maintainer to see if we can move the DSL to the ghprb-plugin using the extension point. Then the DSL will always match the plugin's implementation and we don't have to track subtle changes.

See JENKINS-31214.

Ahh right sorry, should have a check there.
Sent from my Windows Phone

From: Daniel<EMAIL_ADDRESS>Sent: 10/28/2015 1:31 AM
To<EMAIL_ADDRESS>Cc: Matt<EMAIL_ADDRESS>Subject: Re: [job-dsl-plugin] When ghprb version is new enough, emit configVersion 3 (#646)
But what if someone is using triggerPhrase with 1.26 or older? Then configVersion will not be set, but the triggerPhrase will be wrapped with \Q \E. That will break compatibility.
—
Reply to this email directly or view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjob-dsl-plugin%2Fpull%2F646%23issuecomment-151763714&data=01|01|mmitche%40microsoft.com|fc35da46fdf04c7c2c1908d2df722ce5|72f988bf86f141af91ab2d7cd011db47|1&sdata=0u%2BjI%2Bl83cf9amP9ek1%2FJxs%2B7GkK1VBLcZmqv9ADUtE%3D.

I got some positive feedback on JENKINS-31214. I will move the GitHub Pull Request Builder DSL to the ghprb plugin and deprecate pullRequest DSL method in the Job DSL plugin after the ghprb plugin has been released with DSL support.
This means that I will no longer accept changes for the pull request builder DSL. The DSL within ghprb plugin will then generate the latest config with version 3. I hope to get the changes done within the next two weeks. The ghprb plugin is released quite often, so this will be resolved soon.

@daspilker That's great to know.  There are a couple other missing features (buildStatus comments) that I can help out implementing when the code moves to the plugin.

Replaced by https://github.com/jenkinsci/job-dsl-plugin/pull/658.


Project delete fails in mysterious ways

? Are you sure you want to delete project backend? Yes
✔ Cleaning up deployment resources.
✘ Error deleting project resources.
Error: delete project resources: Waiting for stackset backend-infrastructure to be deleted: project operation 0802D5E5-E60F-4B95-AD2C-DCB4EA443D66 in stack set backend-infrastructure failed

This may have had something to do with the fact that the project was initiated on an older version of the cli and had traces left behind?
Checking the CFN console shows no particularly helpful information about the stackset or the stack instance.

Noting that this is likely to do with the fact that there was a vestigial pipeline (and pipeline CFN stack) left over from previous commands. running pipeline delete fails because the pipeline manifest has already been deleted, but we should probably check CodePipeline itself?


Undefined symbol: Swift._ArrayBuffer._copyContents(initializing: Swift.UnsafeMutableBufferPointer) -> (Swift.IndexingIterator<Swift._ArrayBuffer>, Swift.Int)

This error occurs when building in Xcode 14.5
The same issue already exists but is closed at #68

@kaiherrman did you manage to get anywhere with this?