Fix "space has ink"

issue #610
felipe@guarana:~/devel/github_google/fonts$ fontbakery-fix-nbsp.py ofl/voces/Voces-Regular.ttf
ER: Voces-Regular.ttf: Glyph "uni00A0" has ink. Delete any contours or components
ER: Voces-Regular.ttf space 290 nbsp 614: Change space advanceWidth to 614

felipe@guarana:~/devel/github_google/fonts$ fontbakery-fix-nbsp.py ofl/voces/Voces-Regular.ttf --autofix
ER: Voces-Regular.ttf: Glyph "uni00A0" has ink. Fixed: Overwritten by an empty glyph
ER: Voces-Regular.ttf space 290 nbsp 614: Fixed space advanceWidth to 614

felipe@guarana:~/devel/github_google/fonts$ fontbakery-fix-nbsp.py ofl/atomicage/AtomicAge-Regular.ttf
ER: AtomicAge-Regular.ttf: Glyph 0x00A0 is called "dagger": Change to "nbsp" or "uni00A0"
ER: AtomicAge-Regular.ttf: Glyph "dagger" has ink. Delete any contours or components

felipe@guarana:~/devel/github_google/fonts$ fontbakery-fix-nbsp.py ofl/atomicage/AtomicAge-Regular.ttf --autofix
ER: AtomicAge-Regular.ttf: Glyph 0x00A0 is called "dagger": Change to "nbsp" or "uni00A0"
ER: AtomicAge-Regular.ttf: Glyph "dagger" has ink. Fixed: Overwritten by an empty glyph

Winner!


IndexError: list index out of range

when device is set to cpu in colab and hardware accelerator is none
No CUDA runtime is found, using CUDA_HOME='/usr/local/cuda'
IndexError                                Traceback (most recent call last)
 in ()
24 from tqdm import tqdm
25 import lpips
---> 26 from model import *
27 from e4e_projection import projection as e4e_projection
28 from restyle_projection import projection as restyle_projection
7 frames
/usr/local/lib/python3.7/dist-packages/torch/utils/cpp_extension.py in _get_cuda_arch_flags(cflags)
1604                 arch_list.append(arch)
1605         arch_list = sorted(arch_list)
-> 1606         arch_list[-1] += '+PTX'
1607     else:
1608         # Deal with lists that are ' ' separated (only deal with ';' after)
IndexError: list index out of range

Should be fixed now!

@mchong6 thanks!


Workspace does not support full-text search in Chinese

Docker-CommunityServer Version: v12.0.1
git clone https://github.com/ONLYOFFICE/Docker-CommunityServer.git
cd Docker-CommunityServer
docker-compose -f docker-compose.workspace.yml up

Hello @aisuhua
Please do not post the same question to different communication channels. As far as I see, you posted this issue on https://forum.onlyoffice.com/ and we confirmed that this is a known bug. We are working on it already.
If you have other questions which are related to this situation, please continue discission on the forum.

Duplicate of https://github.com/ONLYOFFICE/CommunityServer/issues/271


Update Redis to >=15.6.10

I experience an issue with Redis, that has been discussed and resolved in the Redis Issues, but has been released 15.6.10. Can you please update the subchart version?

Yes, this will be part of the upcoming release which I now plan to complete in the next couple of days.

This is included in chart version 4.1.0.


Add promisify snippet

This PR adds the snipped talked in #57. Resolve #57.

You welcome @Chalarangelo ! :tada:


More correct query parameter name

This is for

Clarity: it is S3 Select

Slightly more future friendliness for other query languages. Specifically, another SQL-based one

There is argument that we should abstract away the internal query language. At the moment, we're not doing that, so it's even slightly misleading to have the more abstract "query_sql". We can always add query_sql later in a backwards-compatible way.
Also using hyphens rather than underscores for consistency with path components

That crossed my mind as well. I’m torn, but somehow one query parameter determining how another query parameter is used feels a tiny bit more of a complex interface.
I think also I’m probably keen on not using the “query” parameter right now, so we can add it later if we want after feedback from real use.


Use PULSAR_PREFIX_ for appending new keys

Motivation
Currently integration tests are broken due to #3827
PULSAR_ is used almost everywhere in our scripts. If we are using
PULSAR_ for appending new keys, then we are potentially appending
a wrong key into the config file.
Currently this happens on presto. We are appending PULSAR_ROOT_LOGGER
into presto's config file and cause presto fail to load the config.
Modifications
Use PULSAR_PREFIX_ instead of PULSAR_

jerry seems found the issue in #3827 https://github.com/apache/pulsar/pull/3827#issuecomment-473171200
but I am not sure how #3827 can pass presto test :(

@sijie @srkukarni does this problem not happen every time.  How did #3827 pass the integration tests?

How #3827 passed integration tests is a m

Not sure how it passed the integration test

@sijie @srkukarni still fails presto integration test:
org.apache.pulsar.tests.integration.docker.ContainerExecException: /bin/bash -c /pulsar/bin/pulsar sql --execute 'show catalogs;' failed on 55ad74426931322a2faf3f573fa51a6f613adb84f75170331a62cd3f4f381353 with error code 1

this is the error in the presto server FYI:
2019-03-18T19:34:42.802Z        ERROR   main    com.facebook.presto.server.PrestoServer Unable to create injector, see the following errors:

1) Configuration property 'ROOT_LOGGER' was not used
  at io.airlift.bootstrap.Bootstrap.lambda$initialize$2(Bootstrap.java:234)

1 error
com.google.inject.CreationException: Unable to create injector, see the following errors:

1) Configuration property 'ROOT_LOGGER' was not used
  at io.airlift.bootstrap.Bootstrap.lambda$initialize$2(Bootstrap.java:234)

1 error
        at com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:543)
        at com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:159)
        at com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:106)
        at com.google.inject.Guice.createInjector(Guice.java:87)
        at io.airlift.bootstrap.Bootstrap.initialize(Bootstrap.java:241)
        at org.apache.pulsar.sql.presto.PulsarConnectorFactory.create(PulsarConnectorFactory.java:64)
        at com.facebook.presto.connector.ConnectorManager.createConnector(ConnectorManager.java:318)
        at com.facebook.presto.connector.ConnectorManager.addCatalogConnector(ConnectorManager.java:195)
        at com.facebook.presto.connector.ConnectorManager.createConnection(ConnectorManager.java:187)
        at com.facebook.presto.connector.ConnectorManager.createConnection(ConnectorManager.java:173)
        at com.facebook.presto.metadata.StaticCatalogStore.loadCatalog(StaticCatalogStore.java:96)
        at com.facebook.presto.metadata.StaticCatalogStore.loadCatalogs(StaticCatalogStore.java:74)
        at com.facebook.presto.server.PrestoServer.run(PrestoServer.java:119)
        at com.facebook.presto.server.PrestoServer.main(PrestoServer.java:67)

@sijie @srkukarni we should probably revert  #3827 because I can reproduce the error every single time. And this will be blocking everything from being merged

rerun java8 tests

it also seems to failing all function integration tests as well

Configuration property 'ROOT_LOGGER' was not used

hmm interesting? with my change or without my change? I have verified that my change fix the presto test.

run integration tests

in the recent jenkins CI, presto is passing.

Merged in 2.3.1 at
780ba31


Manylinux images are broken

Linux builds are blocked currently by this error:
warning: protocol restrictions not applied to curl redirects because
your curl version is too old (>= 7.19.4)
error: error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version while accessing https://github.com/opencv/opencv.git/info/refs?service=git-upload-pack

Might be related to this: https://githubengineering.com/crypto-removal-notice/
The extended manylinux images used by opencv-python need at least a full rebuild on top of a fresh manylinux image. Also it would be good to create Dockerfiles for them to this repo for reproducible builds. If this doesn't help, then the issue must be fixed at manylinux side.

Found the problem. Wget and curl need a full rebuild with latest OpenSSL. I'll rebuild the manylinux images and corresponding Dockerfiles will be added to this repo.

Status: i686 is now working, and x86_64 should be too soon. The Docker recipes need still some adjustments so it takes a couple of iterations before I get the Travis builds working properly again.


Add King's School Grantham

Main website: https://kings.lincs.sch.uk/
TKSG is not only a secondary school, higher courses in Computer Science are provided: https://kings.lincs.sch.uk/computingalevel

@mounderfod First stage of verification passed, official domain is kings.lincs.sch.uk as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.


Function calls are not supported in decorators but 'IntercomModule' was called. - Regression in beta.6

Originally posted by @chrishawn in https://github.com/CaliStyle/ng-intercom/issue_comments#issuecomment-430313444

@scott-wyatt the issue could be related to treating IntercomConfig as an interface. It doesn't get compiled to JS, so it would make sense that it can't be injected. https://github.com/CaliStyle/ng-intercom/blob/9957d161280bf48d2305caee657fd282ddaf55cb/src/app/ng-intercom/types/intercom-config.ts#L1

I'm also having the same issue.
Any workaround for now ?

I'm also having the same issue.
Any workaround for now ?

I disabled AoT for now which is really not ideal. You can do so in the angular.json configuration file.
"configurations": {
            "production": {
              "optimization": true,
              "outputHashing": "all",
              "sourceMap": false,
              "extractCss": true,
              "namedChunks": false,
              "aot": false,
              "extractLicenses": true,
              "vendorChunk": false,
              "buildOptimizer": false,

Sorry about the delay, folks. I'll test this on my end and let you know if this is the issue or if, as mentioned in the previous issue, it's ngpackagr.

We're running this internally on Angular v7. Have you tried upgrading? I can't reproduce this issue.

Thanks for the response. I'm unable to upgrade to Angular 7 at the moment and a manual install would be a bit painful for the pipeline. Just want to confirm that the issue was not reproducible with Angular 7 though?
Is there anything else possible? Will the 7.0-beta.0 release be backwards compatible with Angular 6? If so, will it possibly be released before the 6th of November (I have a major release around then)?
Sorry for the question bombardment.

Hi again, I've managed to upgrade to Angular 7. I'm still getting the error when building with AoT. I will try to build from your branch directly and let you know.

If this is still an issue for you, we're open to PRs. At this point, CS can't throw a lot more resources at development, especially since we can't reproduce the issue. We will definitely continue to maintain by merging PRs, though

Just wanted to note this issue is not present in 6.0.0-beta.3 (npm install --save ng-intercom@6.0.0-beta.3). It is present in all the more recent versions.

I'm having this issue as well, with Angular 7 and ng-intercom 6.0.0-beta.7

I am using a Universal app.
tsconfig.json:
{   "compileOnSave": false,   "compilerOptions": {     "outDir": "./dist/out-tsc",     "sourceMap": true,     "declaration": false,     "moduleResolution": "node",     "emitDecoratorMetadata": true,     "experimentalDecorators": true,     "noUnusedLocals": true,     "noUnusedParameters": true,     "target": "es5",     "downlevelIteration": true,     "importHelpers": true,     "typeRoots": [       "node_modules/@types"     ],     "lib": [       "es2017",       "dom",       "es2015.collection",       "es2015.iterable"     ]   } }
tsconfig.app.json:
{   "extends": "../tsconfig.json",   "compilerOptions": {     "outDir": "../out-tsc/app",     "baseUrl": "./",     "module": "es2015",     "types": []   },   "exclude": [     "test.ts",     "**/*.spec.ts"   ] }

@wbhob you mean, doesn't work right? aka causing the bug.

Yes.

I am experiencing the bug as well, and have a similar config:
{
    "compileOnSave": false,
    "compilerOptions": {
        "allowSyntheticDefaultImports": true,
        "baseUrl": "./",
        "declaration": false,
        "emitDecoratorMetadata": true,
        "experimentalDecorators": true,
        "lib": [
            "dom",
            "esnext"
        ],
        "moduleResolution": "node",
        "noUnusedLocals": true,
        "outDir": "./dist",
        "sourceMap": true,
        "target": "es5"
    }
}

app:
{
    "extends": "../tsconfig.json",
    "compilerOptions": {
        "forceConsistentCasingInFileNames": false,
        "module": "es2015",
        "newLine": "lf",
        "noImplicitAny": true,
        "removeComments": true
    },
    "exclude": [
        "src/test.ts",
        "**/*.spec.ts"
    ]
}

If you change the config, does it work @eyalhakim

@wbhob what is the configuration that you are using that does not produce the bug?

Most importantly, it has commonjs as the module format which could be the issue. If that doesn't work, see what happens when the target is es6

@scott-wyatt issue still persists, previous commit did not help.

Same here. Especially with the ng xi18n builder.

People. We need a PR. We don't have the resources within the company  to fix this now. We're looking for contributions from the community to fix this issue. We will review your PR if you submit one.

Also still seeing the same error as described as above when compiling with AOT. Using version 7.0.0-beta.0 with Angular 7. Using Angular CLI to build the project and using this TSConfig:
{
  "compileOnSave": false,
  "compilerOptions": {
    "outDir": "./dist/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "moduleResolution": "node",
    "noUnusedLocals": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "strictPropertyInitialization": false,
    "target": "es5",
    "typeRoots": ["node_modules/@types"],
    "paths": { "stream": [ "../node_modules/readable-stream" ] },
    "lib": ["es2017", "dom"]
  }
}

The line "paths": { "stream": [ "../node_modules/readable-stream" ] }, is used to solve a specific issue with papaparse when compiling with Angular CLI.
This is currently blocking our upgrade to Angular 7 so will at least try to get a quick-fix to get it work with Angular 7, even if that means using a lower version.

Looking at the code and comparing it to @angular/flex-layout, which has an optional static method, the only clear difference I notice is that the value provided in this library is IntercomConfig which is an @Injectable provided later while in flex-layout there is a clearer distinction with the Injected token being created from the interface, see here. This injection token is further the only thing changed in the module file.
So if it's due to a change in the module itself I figure the type of the injection token is the issue. Otherwise I think it's the build.

@Koslun if you run npm run build:dist, then cd into dist and run npm package, you can install the output .tgz file as an npm package to test! Hope this helps.

@wbhob thanks will try this then.

Hi folks,
Is there any temporary hack or workaround for this?

You could use a lower version @hassaanp

I am going ahead with JiT for now.
Thanks @wbhob

Hello, thank you very much for creating this.
Just installed this:
npm install ng-intercom@latest --save -> "ng-intercom": "^7.0.0-beta.0",
It works perfectly locally, but when creating --prod --aot build, getting the error also.
I'm using Angular 7.1

Before you leave a comment:
We know this is an issue with AoT. @Koslun is working on a fix.
Also, my previous comment:

People. We need a PR. We don't have the resources within the company to fix this now. We're looking for contributions from the community to fix this issue. We will review your PR if you submit one.
We can't reproduce this issue internally, either, and since that's the case, we don't need a fix for our own projects. If you want a fix, please contribute one.

@Koslun sorry to disturb you, but do you have any eta when the fix might be available? 🙏

@Koslun @wbhob I made a PR fixing the issue : https://github.com/CaliStyle/ng-intercom/pull/83
Also, as it was said before, npm install --save<EMAIL_ADDRESS>does fix the issue until this is merged


S3 Provider: Environment variables for AWS Credentials

A while ago I was able to use AWS environment variables for credentials but now they don't work like they used to. Here is what I found on AWS docs (https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/loading-node-credentials-environment.html):
The SDK automatically detects AWS credentials set as variables in your environment and uses them for SDK requests, eliminating the need to manage credentials in your application. The environment variables that you set to provide your credentials are:

AWS_ACCESS_KEY_ID

AWS_SECRET_ACCESS_KEY

AWS_SESSION_TOKEN (optional)

At some point, however, inside of the S3 provider package these were hardcoded to ACCESS_KEY_ID and SECRET_ACCESS_KEY with no mention of the session token. See lines 13 and 14 here: https://github.com/inlife/nexrender/blob/master/packages/nexrender-provider-s3/src/index.js#L13
I'd propose we remove those lines and go back to the AWS defaults which would also work for session tokens. Is this doable?

Hey @byumark
I think you are right. I found myself using existing aws credentials setup much more often than actually manually providing access keys. So I did a small change, that should keep old code working fine for other people, as well as respecting the values from configured credentials/env vars by default. You can check the commit: https://github.com/inlife/nexrender/commit/f991c9e5927eb0cccf8623fdc7f94eb223c85f52

Awesome. Looks good! Thanks for doing that.


redesign login UI interface

Title: [Persona name] should (not) be able to [overarching action]
Business/User Value: As [persona] I want to [action by user] so that [value or need met]
Acceptance Criteria
GIVEN [necessary context and preconditions for story]
WHEN [action]
THEN [reaction]
DEV NOTES
https://github.com/chainmakers/dicoapp/blob/glxt/.desktop/modules/marketmaker/index.js#L706
DESIGN Notes
None
---other items that you may add to a story---
NEEDS PM
None
NEEDS DESIGN
None
/label ~"story"

Related to #2


Running chrome headless not actually headless

Are you requesting a feature or reporting a bug?
Reporting a Bug
What is the current behavior?
When I run chrome in headless mode chrome:headless it's not, well, headless. When run, it still displays a browser window.
What is the expected behavior?
Running chrome in headless mode will not display a browser window.
How would you reproduce the current behavior (if this is a bug)?
It happens everytime for me. Can provide enviromnent details if necessary
Provide the test code and the tested page URL (if applicable)
I use the following npm run script:
"test:headless": "testcafe \"chrome:headless\" src/**/*.spec.* --app \"npm run web\" --app-init-delay 20000 -q -S -s build_output/tests/screenshots"
Specify your

operating system: Windows 10 (Fall Creators Update Insider Build 16215)
testcafe version: 0.16
node.js version: 8.0.0
chrome version: 59

Hi @RichiCoder1,
Please take a look at the note in the Running Tests in Headless Mode topic:

Note that headless mode is available for Mac and Linux in Chrome 59. You need a Canary build to enable headless mode on Windows.

So, to use headless mode in Chrome on Windows it necessary to install a Canary build and run the command like: testcafe "chrome:C:\Users\YourUserName\AppData\Local\Google\Chrome SxS\Application\chrome.exe:headless" test.js
When the feature will be available in the stable version of Chrome on Windows you can use just testcafe chrome:headless test.js.

Ahh, I completely missed that. Just heard all the fuss about headless and both the docs and the official blog had support in little text haha.


componentWillTransition not working

Hi, I'm using react-automata with react-native. I can't for the life of me get componentWillTransition() to fire. I've added it to the same compoent that his wrapped in withStateMachine the view is def transitioning between states. Are there any examples showing how to implement `componentWillTransition/componentDidTransition' in case I'm doing something silly? thanks

Hey @pdkn, I'm sorry to hear componentWillTransition is not working for you.
Would you be able to provide some code so that I can help?
An example of willTransition/didTransition is https://codesandbox.io/s/30x3r5vj6p.

`export interface AuthScreenProps extends NavigationScreenProps<{}> {
appInfoStore?: AppInfoStore
authStore?: AuthStore
profileCollection?: ProfileCollection
machineState?: string
transition?: (event: string, updater?: any) => void
}
export interface AuthScreenState {
currentState?: States
transitionInComplete?: boolean
transitionOutComplete?: boolean
}
@inject("appInfoStore", "authStore", "profileCollection")
@observer
class AuthScreenBase extends React.Component<AuthScreenProps, AuthScreenState> {
constructor(props) {
super(props)
this.state = {
currentState: States.INTRO,
transitionInComplete: false,
}
}
unsubscriber = null
player: Video = null
componentWillTransition(event) {
console.log("EVENT", event)
if (event === "CHECK_AUTH") {
}
}
componentDidTransition(prevMachineState, event) {
console.log("EVENT", event)
}
render() {
return (

<Video
source={require("../../looping-bg-video.mp4")}
ref={ref => {
this.player = ref
}}
style={styles.backgroundVideo}
rate={1}
volume={1}
muted={true}
resizeMode="cover"
repeat={true}
key="videoBg"
/>
<View
style={{
...appStyles.full,
backgroundColor: color.transparent,
}}
>
<Screen style={{ ...appStyles.screen }} preset="fixedStack">

<AppRevealView onTransitionInComplete={() => this.props.transition("CHECK_AUTH")} />

        <State is="checkingAuth">
          <CheckAuthStateView />
        </State>

        <State is="signinCTA">
          <SigninCTAView onTransitionInComplete={() => this.props.transition("CHECK_AUTH")} />
        </State>
      </Screen>
    </View>
  </View>
)

}
}
export const AuthScreen = withStateMachine(statechart)(AuthScreenBase)`

Thanks for providing additional information, @pdkn.
I assume @inject and @observer come from mobx-react, where the documentation says:

When using both @inject and @observer, make sure to apply them in the correct order: observer should be the inner decorator, inject the outer. There might be additional decorators in between.

So, it seems you should put withStateMachine in between them:
@inject("appInfoStore", "authStore", "profileCollection")
@withStateMachine(statechart)
@observer
class AuthScreenBase extends React.Component<AuthScreenProps, AuthScreenState> { ... }

I tried locally and it worked.
I hope this helps.

Aha, wonderful. Thanks so much for quick response!

@MicheleBertoli Alas might have to re-open this ;( Although above code now calls componentWillTransition and componentDidTransition successfully. The Mobx observable stores are now not updating the component. I've got 2 fixes. in dis/react-automata.es.js' point the the mobx-react wrappedInstance.  i.e _this.instance.current.wrappedInstance.componentWillTransition(event);` or make subcomponents of the main component @inject the stores, listen for changes and then call update methods on the main component.  Obv the patch in the dist code isn't a long-term fix but I mention it in case you can think of a clever way to make react-automata more compatible with mobx-react. Any thoughts?

Hey @pdkn, thanks for adding more information.
I'm not familiar with mobx-react and I'm not 100% sure this issue belongs here as withStateChart is a regular higher-order component. I'm also not 100% sure withStateChart should be modified to be "compatible" with MobX, or any other state management library (i.e. it should work out of the box).
Anyway, I was curious and I built a demo (which seems to work as expected):
https://codesandbox.io/s/y7pmlv6n9v

Would you mind changing the code of this demo to repro your scenario where the stores are not updating the component?
I'll be happy to look into it.


Compile Error on vergen-7.1.0

I get the following error when compiling vergen-7.1.0. Please let me know if you need more details.
error[E0308]: mismatched types
--> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/vergen-7.1.0/src/feature/si.rs:265:20
|
265 |     *user.uid() == process.uid
|                    ^^^^^^^^^^^ expected u32, found enum Option
|
= note: expected type u32
found enum Option<u32>
For more information about this error, try rustc --explain E0308.
error: could not compile vergen due to previous error

I had to pin the sysinfo version as breaking changes were made.   There are newer versions of vergen that shouldn't exhibit this compile error.    If you can upgrade to those, that would be idea.  I may pull some of this older versions if this continues to be an issue.

Feel free to re-open this is you haven't found a suitable solution.


ATA: Only download typings for dependencies in top-level package.json

When I was verifying ATA in VSCode, I found it downloaded typings for non-top-level deps.
I only added ~20 packages to my package.json, but in my cache I found:

IMO only typings for dependencies in package.json should be downloaded. This is also one of the factor that caused npm overload.

This is arguably correct behavior. See related discussions like #11917

This is also one of the factor that caused npm overload.

I do not believe this accurate. The npm issue was not caused by valid package installation, but rather by checks for non existing packages. this is based on the information the npm team has shared with us.
We have added a fix for this in TypeScript 2.0.7 release to address the non-existing package issue.

I only added ~20 packages to my package.json, but in my cache I found:

Please note that this is a machine-wide cache. so all projects will contribute to the cache and will use files from the cache if they exist.

The npm issue was not caused by valid package installation, but rather by checks for non existing packages.

Say you have a project that has 10 deps, each of them depends on 10 other deps.
For the 100 indirect deps, wouldn't TS need to check which of them have typings?

@mhegazy I'll just follow #11917 and maybe you can close this as a duplicate. Thanks!

I do not think this is covered by #11917. the automatic type acquisition happens before there are @types packages. it is what acquires these @types packages. so there is a relationship but they are not the same.
Let me ask why you feel this behavior is not correct? do you see typing lags? or it is just concern about disk space?

Because it downloads unnecessary typings, that might take very long to finish, depending on internet connection.
For example, for https://github.com/kriasoft/react-starter-kit
react-starter-kit > ls -la node_modules | wc -l
     927

As its package.json has only ~30 packages. Downloading 30 typings should be enough to drive intelliSense.
One concern I have is, although I don't know for sure, my guess is all typings are downloaded with same priority. I'd prefer if typings for deps in package.json can be downloaded first so we can light up intelliSense faster.
On the VSCode side, we are also interested in adding visual indication to the progress of ATA. Instead of showing progress for downloading ~900 typings, showing progress for the ~30 required typings makes more sense.

This isn't desirable (typings with unresolved dependencies will have errors and other problems), let alone possible given how npm works (there isn't a way to install a package without its dependencies).


TextWidthCache refactoring & tests

Type of PR:
PR checklist:

[ ] Addresses an existing issue: fixes #
[x] Includes tests
[x] Documentation update (not required)

Overview of change:
No signature changes.
Added some tests.
Changed the cache from Record<string, { tick: number, width: number}> to just Record<string, number>
Fixed __proto__ and prototype were read from cache object proto
Changed a ticks2indices record with even growing indices into a cyclic array structure,
-10 bytes .min.gz :grin:
Is there anything you'd like reviewers to focus on?

The private _cache can be a Map<string, number> as well. It's an easy change and I can apply it if you wish.

Thanks!


Update description

Update metadata description

@clementprdhomme I can't find the updated change. What should I update?

@Bluesmile82 The sentence should be: « Understand the impact of climate change, land use change, and land management practices on soil carbon based on a comprehensive global analysis of over 25 thousand peer-reviewed scientific papers from trusted sources, such as the Web of Science or Scopus. ».


Add 'range' & 'class-level properties' columns to class csv

Add columns for 'range' & domain/'class-level-properties' to the classes list / ltc_category.csv

closed with pr #393


Unexpected behavior: numeric type refs get converted to strings once indexed.

Hi there!
Love the library, but ran into unexpected behavior recently when updating from the ancient 0.6 release to the new-and-shiny 2.1.5 release.
Notably, I was formerly passing in an id ref with a numeric value, and the older lunr.js codebase seemingly left my ref types alone.
Now, refs get coerced into strings once more!
Is this the desired / expected behavior of the library?
Is there a new technical/performance reason behind this change related to the introduction of the immutable index?
The Changelog indicates this is a regression from 0.6 where the problem was originally resolved: #117
Simple repro notebook on RunKit just for fun:
https://runkit.com/sherbondy/lunr-js-2-1-5-converts-ref-values-to-strings-unexpectedly
Thanks for making lunr!

I remember the issue you are talking about. I honestly can't remember the reasons why this change in  2.x of Lunr, but looking at the docs it seems I did call it out specifically!
I'm not against 'fixing' this regression and would welcome pull requests with such changes ;)
I'll take a look into it myself also, but its not super high on my list of things to work on in Lunr.

Going to close this now as this is documented behaviour (though it has changed during the major version bump from 0/1 to 2).
As mentioned before, I am open to pull requests that support numeric refs, but I don't see myself getting to this anytime soon.


File path in twig

How will I get the file path in twig? I previously used viichuploader, and it had a twig function to generate the file url! I don't want to save the file path in the database, to save database size.

As easy as it can get! :)
You don't have to store the whole path.
Just configure your upload directory:
oneup_uploader:
    mappings:
        gallery:
            storage:
                filesystem: %kernel.root_dir%/../web/uploads/gallery

and in twig you can use it like this:
<img src="/uploads/gallery{{ image.path }}" />

I wanted a more dynamic way, like maybe a twig function, but then I realized I will be using LiipImagineBundle so, ill be using its function. Thanks anyway.

I thought about it again, i want to make this as a feature request. The way you suggested is easy, but it isn't much helpful if i were to change the directory. I would have to edit everywhere else, one by one. A function that can do this procedure you suggested without anyone having to do it. It would be nice, I guess.

And suppose you say no to this, here is a gist I created that you can refer to people at least who would want it. This shows how to create a helper function for controller and twig. I hope you don't mind,
https://gist.github.com/deviprsd21/5bd4bc827ee7991640c4

I'd also be interested in this, I'dl like to crop the image after it's been uploaded, and the cropper I use needs the filer URL, so I'd like to have it in the response object.
It would be neat to have a helper that can generate the asset URL directly from the file

@jstoeffler Try the gist I suggested for the time being if you want to, https://gist.github.com/deviprsd21/5bd4bc827ee7991640c4


Support proxy protocol

There is no way to specify trusted proxy address in the configuration, which means that the client address won't be logged on access log even if proxy protocol is specified as a supported protocol. It should be able to be configured when building a server with a ServerBuilder.

Fixed in 0.40.0 via #404


WIP: plumb dns01 nameservers around more places

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

none

I'm not convinced about this approach, but putting up a wip anyway

I don't think this is necessary now that #793 is added


'form.posted_successfully?' Doesn't work for address forms

According to these docs:
https://docs.shopify.com/themes/liquid-documentation/objects/form#form-posted_successfully
form.posted_successfully? should work within the {% form %} tag.
However this does not work:
{% form 'customer_address', address %}
{% if form.posted_successfully? %}
Success
{% else %}
{{ form.errors | default_errors }}
{% endif %}
{% endform %}
—————— And nor does this: ——————
{% form 'customer_address', address %}
{% if form.posted_successfully? %}
Success
{% else %}
{{ form.errors | default_errors }}
{% endif %}
{% endform %}

Neither the add, edit or delete functions seem to be able to return a success/failure which can be output on the front end.

Check you don't have the form.posted_successfully tag in your header too. If there are 2, it won't work.

@fredryk any ideas on this?

@Thibaut knows most about this issue. I'm looping him in for some insight.

@Cam No, there are no other instances. Ty.

This issue is being tracked inside Shopify. It's not a straightforward fix because the address object passed to the form comes from a loop over the customer's addresses, which might be paginated over in different ways. We haven't given up on the bug though.

Closing as this isn't Timber-related


net/http: TestServerKeepAlivesEnabled_h2 test flake

linux-amd64-race at 789e14c1aa487f83d6e99f369b22c4fa60bf6f4c
https://storage.googleapis.com/go-build-log/789e14c1/linux-amd64-race_7fc53188.log
2016/11/28 20:31:42 http: TLS handshake error from <IP_ADDRESS>:42614: read tcp <IP_ADDRESS>:35582-><IP_ADDRESS>:42614: use of closed network connection
--- FAIL: TestServerKeepAlivesEnabled_h2 (0.09s)
	clientserver_test.go:50: Get https://<IP_ADDRESS>:34653: http2: server sent GOAWAY and closed the connection; LastStreamID=1, ErrCode=NO_ERROR, debug=""
FAIL
FAIL	net/http	4.922s
```

/cc @tombergan (if you're bored)

Wild guess:
The server becomes "idle" before it sends the GOAWAY:
https://github.com/golang/net/blob/1c5acb2c2d1df0409de556978dd628d90aee5cb3/http2/server.go#L1275
The test sends the second request after the server has transitioned to "idle":
https://github.com/golang/go/blob/409a667f35f66b2b5fa219ee93f1a3ddc6e07b03/src/net/http/serve_test.go#L5030
The test can make the second getURL call before receiving the GOAWAY. However, the h2 transport doesn't retry a request when the following code executes before GOAWAY is actually received:
https://github.com/golang/net/blob/1c5acb2c2d1df0409de556978dd628d90aee5cb3/http2/transport.go#L679
There is a race: if the client sends a new request on stream n+2, then shortly afterwards receives GOAWAY(lastStream=n), the client won't auto-retry that request on a new connection. Auto-retry happens only if RoundTrip gets to line 679 after the GOAWAY is received.
There is arguably a second bug, though this isn't the root cause of the test flake: the server transitions to idle at the line below even though there may still be response frames queued in the write scheduler. (Is it really correct to consider the server "idle" at this point?)
https://github.com/golang/net/blob/1c5acb2c2d1df0409de556978dd628d90aee5cb3/http2/server.go#L1275
Finally, I noticed a third bug: the following code should check curClientStreams+curPushedStreams==0 rather than curClientStreams==0:
https://github.com/golang/net/blob/1c5acb2c2d1df0409de556978dd628d90aee5cb3/http2/server.go#L756

There is arguably a second bug, though this isn't the root cause of the test flake: the server transitions to idle at the line below even though there may still be response frames queued in the write scheduler. (Is it really correct to consider the server "idle" at this point?)
https://github.com/golang/net/blob/1c5acb2c2d1df0409de556978dd628d90aee5cb3/http2/server.go#L1275

This is not a problem. At the end of sc.closeStream, the call to writeSched.CloseStream will discard any frames queued for that stream.

Finally, I noticed a third bug: the following code should check curClientStreams+curPushedStreams==0 rather than curClientStreams==0:
https://github.com/golang/net/blob/1c5acb2c2d1df0409de556978dd628d90aee5cb3/http2/server.go#L756

This is a bug. Sending a CL.


added information on path when installing dependencies

For those who haven't done this before, adding information about the fact that one needs to run pip and other commands in the root directory of the local working copy of the repository might be useful.

Apologies @volker-krey,  I took the liberty to commit to your branch to move this forward.
Thank you for this PR!


Error when trying to apply

Python path configuration:
PYTHONHOME = '/tmp/.mount_InkscaCWB7VM/usr/'
PYTHONPATH = '/home/user/.config/inkscape/extensions:/tmp/.mount_InkscaCWB7VM/usr/lib/share/../../share/inkscape/extensions:/tmp/.mount_InkscaCWB7VM/usr/lib/share/../../share/inkscape/extensions/inkex/deprecated-simple'
program name = '/usr/bin/python3'
isolated = 0
environment = 1
user site = 1
import site = 1
sys._base_executable = '/usr/bin/python3'
sys.base_prefix = '/tmp/.mount_InkscaCWB7VM/usr'
sys.base_exec_prefix = '/tmp/.mount_InkscaCWB7VM/usr'
sys.executable = '/usr/bin/python3'
sys.prefix = '/tmp/.mount_InkscaCWB7VM/usr'
sys.exec_prefix = '/tmp/.mount_InkscaCWB7VM/usr'
sys.path = [
'/home/user/.config/inkscape/extensions',
'/tmp/.mount_InkscaCWB7VM/usr/lib/share/../../share/inkscape/extensions',
'/tmp/.mount_InkscaCWB7VM/usr/lib/share/../../share/inkscape/extensions/inkex/deprecated-simple',
'/tmp/.mount_InkscaCWB7VM/usr/lib/python38.zip',
'/tmp/.mount_InkscaCWB7VM/usr/lib/python3.8',
'/tmp/.mount_InkscaCWB7VM/usr/lib/python3.8/lib-dynload',
]
Fatal Python error: init_fs_encoding: failed to get the Python codec of the filesystem encoding
Python runtime state: core initialized
ModuleNotFoundError: No module named 'encodings'
Current thread 0x00007fd6fe424740 (most recent call first):

I'm on linux debian

Take a look at this discussion. It seems like your python path is miss configured.

Another useful resource. Regardless, it doesn't seem like it has anything to do with the extension. So if you don't object I'll close the issue.


mypy_nightly failing due to missing ignore

Did a merge from a PR, and mypy_nightly failed:
https://github.com/pandas-dev/pandas-stubs/actions/runs/4394778938/jobs/7696025817
I think this is a correct fix for mypy.
If we add a # type: ignore[override] for that line, then our regular tests fail.
@twoertwein Any ideas on how to handle this, or do we just have to ignore the failures in mypy_nightly until a new mypy release is done?

I think we have the following options:

We might get away by changing the mypy config file for the nightly run (I'll look into that later today)
Ignore it
Ignore it but run nightly only on main and not for PRs (I think there is an option for that)
Remove the nightly run

I wouldn't mind running the mypy nightly (and pandas nightly) workflow only on main. In case they error, there is no immediate need for action. This might be a better trade-off compared to annoying contributors with failing workflows.

I wouldn't mind running the mypy nightly (and pandas nightly) workflow only on main. In case they error, there is no immediate need for action. This might be a better trade-off compared to annoying contributors with failing workflows.

That sounds like a good idea.  Then I just get the noise when I do merges of PR's.

Closing via #569


feat: new home page made

#77
I hope u like it.I have change the styling.Looking forward for ur response.
Type of PR

[X] Feature enhancement

Checklist:

[X] I have performed a self-review of my code
[X] I have read and followed the Contribution Guidelines.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

@jaibhedia Will u plzz label it here also as u have labeled it in issues ,but un leader board my name is not showing will u plzz label it here also so It counts.


Add label to skip Pumba eyes

Need to add a Docker LABEL to skip Pumba. Usefull for different monitoring and log grabber services running as Docker container and that user is not interested to test.

--label com.gaiaadm.pumba.skip


Update formatters.ts

Replace the length implementation since the user could be copy / pasting a shorter value (which should be formatted as well).

Thanks for the PR @fabcall.
I'm afraid this is breaking the formatter though: Try typing 5555 to the card number input. It won't be formatted to 5555 . You may also check the tests are failing by running yarn test.
I think we should cover the case you mentioned though. Can you try fixing it without breaking tests? Also, could you create a test for your case in formatters.test.ts?

Thanks for the PR @fabcall.
I'm afraid this is breaking the formatter though: Try typing 5555 to the card number input. It won't be formatted to 5555 . You may also check the tests are failing by running yarn test.
I think we should cover the case you mentioned though. Can you try fixing it without breaking tests? Also, could you create a test for your case in formatters.test.ts?

Hey @halilb , for sure, I'll take a look at this later today!

Hey @halilb , for sure, I'll take a look at this later today!


Feat: Adding upcoming and past contest details in codeforces

Describe the feature
Adding methods that retrieve contest details both upcoming and past in code forces
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC 23 contributor
[X] I want to work on this issue

I just noticed that similar issue already exists and hence closing this one


Banned.

I got banned.  needs update. :

Maybe more will chime in, but people have been reporting bans for a few weeks now, although very infrequently.  Presently I don't know what's causing them.
Realistically, if Gleam really wanted to detect this script, there's nothing stopping them.  I've personally switched over to Gleam.helper, and I'm not sure if I'm going to be supporting this script for much longer.

are the people getting banned using multiple accounts?

I have been using this script with my alternative accounts and I haven't been banned for ages. It's sad that this script isn't being maintained anymore.

Of course. I did so many things to avoid it: attached to each account Gleam, personal Facebook, Twitter, Twitch, and certainly Steam. All this worked as long until he became interested in such scripts 3 months ago. Now I'm working 3/8 of accounts, but recently has blocked Twitter and others, and then I wrote sms recovery exceeded the amount of use or something similar. So I completely fucked.
Of course. I did so many things to avoid it: attached to each account Gleam, personal Facebook, Twitter, Twitch, and certainly Steam. All this worked as long until he became interested in such scripts 3 months ago. Now I'm working 3/8 of accounts, but recently has blocked Twitter and others, and then I wrote sms recovery exceeded the amount of use or something similar. So I completely fucked.

And yes, Twitter ban I received after the first day Gleam.helper use.  I even been preserved accounts as follows, in order not to switch to other accounts as I perform other tasks. Just as it was when I had just started the on first multi-client Gleam. I think because of that I have for a long time can not farm keys as before. Do not use anything like that. Successful development, goodbye

I had only one account and got banned when using your script version 1.5.3. I've got tens of gifts by using the script before it happened though.

I use this and banned with ONE new account in 4 days.
I think Gleam detect this script already.
i still thanks author for this, it save many my time.
thanks :)


remove flow control mutexes for the sending data

Receiving MAX_{STREAM}_DATA frames and sending data is all done sequentially, so we don't need a mutex there.
In my benchmark (downloading and uploading on 100 streams concurrently), this reduces the CPU time consumed by flowcontroller.SendWindowSize() from 16% to 1.7%.

Codecov Report

Merging #1037 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1037      +/-   ##
==========================================
- Coverage   90.73%   90.72%   -0.01%
==========================================
  Files         104      104
  Lines        7152     7143       -9
==========================================
- Hits         6489     6480       -9
  Misses        430      430
  Partials      233      233

Impacted Files
Coverage Δ

internal/flowcontrol/connection_flow_controller.go
100% <ø> (ø)
:arrow_up:

internal/flowcontrol/stream_flow_controller.go
100% <ø> (ø)
:arrow_up:

internal/flowcontrol/base_flow_controller.go
100% <ø> (ø)
:arrow_up:

internal/wire/stop_sending_frame.go
100% <0%> (ø)
:arrow_up:

internal/wire/rst_stream_frame.go
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075e6f2...bfdeeae. Read the comment docs.


Release vs. Prerelease

https://github.com/JNOSQL/artemis/releases/tag/0.0.1 says it's the "Latest Release" but by the version number it feels more like a pre-release. Shouldn't that checkbox be clicked until a later release or Graduation from Eclipse Incubator?

We already have this discussion on email


Broken Altair docs

Describe the bug

Altair doc image is broken at https://docs.marimo.io/api/plotting.html
Environment
{
"marimo": "0.3.3",
"OS": "Darwin",
"OS Version": "23.3.0",
"Processor": "arm",
"Python Version": "3.11.5",
"Binaries": {
"Chrome": "123.0.6312.58",
"Node": "v20.11.1"
},
"Requirements": {
"black": "24.3.0",
"click": "8.1.7",
"importlib_resources": "6.4.0",
"jedi": "0.19.1",
"pymdown-extensions": "10.7.1",
"starlette": "0.37.2",
"tomlkit": "0.12.4",
"typing_extensions": "4.10.0",
"uvicorn": "0.29.0"
}
}
Code to reproduce
The documentation is broken online, this is not in my local environment.
https://docs.marimo.io/api/plotting.html

Thanks for pointing this out - I just released and there is a slight race condition. It should be back now

Sick! :)
Best,
Anastasios Angelopoulos
https://people.eecs.berkeley.edu/~angelopoulos/
On Fri, Mar 22, 2024 at 1:38 PM Myles Scolnick @.***>
wrote:

Thanks for pointing this out - I just released and there is a slight race
condition. It should be back now
—
Reply to this email directly, view it on GitHub
https://github.com/marimo-team/marimo/issues/993#issuecomment-2015872612,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGBYOUXJBMBEZEPRM55JFZDYZSJFXAVCNFSM6AAAAABFD6QWXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVHA3TENRRGI
.
You are receiving this because you authored the thread.Message ID:
@.***>


How to keep BLE Mesh from loosing provisioning data after power reset (IDFGH-7361)

Hi there! I'm using a Sensor Client - Sensor Server configuration, but making the provisioning through through the nRF Mesh Android App, I've noticed that if there is a power reset (for example when starting a monitor on the IDF or simply pulling the power plug), all of the provisioning data is lost. I've checked a similar Issue and the recommendation was to enable an option on the menuconfig:
Component config -> BLE Mesh Support -> Store BLE Mesh Node configuration persistently
I've done this, but the problem persists, curious thing is the app seems to retain the App Key and Provisioning but if I monitor the device it has the provisioning open:
SENSOR_SERVER: ESP_BLE_MESH_NODE_PROV_ENABLE_COMP_EVT, err_code 0
And it's not running my program until I re-provision the node.
I'm attaching my sdkconfig file, does anyone know what I'm missing?
Thank you and best regards
sdkconfig.txt

Bump

CONFIG_BLE_MESH_SPECIFIC_PARTITION=y
CONFIG_BLE_MESH_PARTITION_NAME="ble_mesh"

Did the project's partition table has "ble_mesh" nvs data partition?

@gsapinto I have the same issue where the esp seems to have the data but doesn't run the application code until being re-provisioned. Did you find a resolution to this?

having the same issue, any updates or workarounds?


Option to show Logo attribution

Type of PR: enhancement
PR checklist:

[x] Includes tests
[x] Documentation update

Overview of change:
Adds an option to show the small TradingView logo as a form of attribution.

LGTM


xargs -i was removed

$ xargs -i
xargs: illegal option -- i

According to this:

Also, -i for xargs was deprecated around version 4.2.9. You should use -I {}.

:+1:


Out of memory error when calculating PAWN sensitivity for 8192 scenarios

When calculating the PAWN sensitvity index for 4096 scenarios with the Moore domain, the output in calculated without error. However, for 8192 scenarios, a memory-error out of gc handles error message is produced.
This occurs both on the remote desktop and personal laptop.
MWE for issue:

here = @__DIR__
dom = ADRIA.load_domain(joinpath(here, "Domain path"), "45")
k = 13
N = 2^k
scens = ADRIA.sample_guided(dom, N)
foi = [:guided]
rs = ADRIA.load_results("Results path")

mean_abs_cc = ADRIA.mean(sum(ADRIA.total_absolute_cover(rs)[:, :, :], dims=:sites), dims=:timesteps)[timesteps=1, sites=1]

infil> ADRIA.sensitivity.pawn(scens[:, string.(foi)], NamedDims.unname(AxisKeys.keyless(mean_abs_cc)))
ERROR: syntax: invalid syntax (memory-error out of gc handles)
Stacktrace:
 [1] top-level scope
   @ none:1

mean_abs_cc = ADRIA.mean(sum(ADRIA.total_absolute_cover(rs)[:, :, :], dims=:sites), dims=:timesteps)[timesteps=1, sites=1]

This gets the mean tac across all scenarios for the first year at site 1, is that correct?
Is there a reason why you're doing this manually yourself? (i.e., do you suspect an issue with the ADRIA methods?)

@Rosejoycrocker please contact me when you can tomorrow, we need a quick 5min chat

mean_abs_cc = ADRIA.mean(sum(ADRIA.total_absolute_cover(rs)[:, :, :], dims=:sites), dims=:timesteps)[timesteps=1, sites=1]

This gets the mean tac across all scenarios for the first year at site 1, is that correct? Is there a reason why you're doing this manually yourself? (i.e., do you suspect an issue with the ADRIA methods?)

Sorry I missed this, no reason. I think I copied parts of an older script but I'll change it to scenario_total_cover


[macOS] Accept all kind of spaces in regexes (fixes #47)

There were two issues with the macOS regexes:

The regexex accepted only spaces separator. But non-breakable spaces are also used from time to time. Replacing spaces by \s fixed the issue (other product regexes were also updated - never know).
The first regex, the one that accepted major releases with no minor version, were not useful (covered by the second regex) and partly catched valid versions (such as 13.1), who was then ignored. I removed it.

@captn3m0, I did not find 10, 11, 12 versions on the parsed pages, so I think their removal is OK. The Sierra and beyond regex is working though because it is correctly matching against the version 13.

Give me a few hours. I remember explicitly fixing the .0 versions somehow, want to double check that before merging.

OK. I had the impression, for the 11/12 versions that they were called 11.0/12.0 on the Apple page. But you may have done that for the macOS 10 version, which disappeared. Something must be done for that before merging the PR.

But you may have done that for the macOS 10 version, which disappeared. Something must be done for that before merging the PR.

Think it's OK : there is still macOS 10.12 (released on 2016-09-20) and macOS 10 is not a release cycle (on https://endoflife.date/macos).

Looked into it, the dates match the x.0.1 release because the x.0 announcements are marked as Preinstalled.


Reg\Register an Operation\Page "Operation Representative" - External user can register the operation

Description:
As an industry user, given that the operation has been added to my operator, I can register the operation for IRC approval.
Acceptance Criteria:
Given that I am on the preceding page (either new entrant, opt in, or facility information), When I click on the save and continue button,
Then I am brought to the Operation Representative page of the form
https://www.figma.com/design/LsDmLDCdnJqI8UahyqvOD8/BCIERS-Designs?node-id=10222-77&t=5omgZedIN5xnnFFl-4
Given that I am on the Operation Representative page,
When I click on the Operation Representative dropdown,
Then I see a list of operation representatives
Given that a contact is selected,
display the Contact form of the selected contact for review.
Given that a new contact is added,
display the empty Contact form to be filled out.
Development Checklist:

[x] edit Operation db model to have a many-to-many relationship on Contact model (django auto-generates new table operation_contacts)
[x] the operation_contacts table must have FKs to operation_id and contact_id (django will handle this for us), and our standard audit colums (created by/at, updated by/at, archived by/at), and another column for contact_business_role, which contains a FK to our existing BusinessRole model
[x] each step of the Registration workflow form should hit a different API endpoint
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:
Dependencies

Blocked - new tickets about multi-step forms
Blocking

@andrea-williams Currently, the Contacts data grid displays all contacts associated with the user's operator. However, in this ticket we are now adding contacts to the operation as well, and I believe there may be a conflict. When we add a new operation representative, should we also add them to the operator contacts? Or should we undo our recent changes and only display contacts associated with all operations of an operator?

@zoeyli-46 I have a couple of questions:

What should happen when a user selects an Operation Representative from the dropdown? Should we fill the first Operation Representative form with its data?
What is the function of the "Add them below" link?
When a user selects an existing user from the "Is this contact a user in BCIERS?" dropdown, should we only fill in the user's first name and last name? In the contact form, we also fill in the email, phone number, and position title.

When a user opens the dropdown, it should display the contacts that the operator already has in their contacts grid, so the user can select from existing added contacts
Add them below function will open the “add contact” form. If the drop down doesn’t have the contact I want to use for this operation, then i will add them. The add contact form should only appear if the user click “add then below”
If the contact is a user in BCIERS then it should prepopukate with whatever information the system has about the contact so the user doesn’t have the enter the same information twice

When a user opens the dropdown, it should display the contacts that the operator already has in their contacts grid, so the user can select from existing added contacts

Sep: Does anything happen to the Operation Representative form below the dropdown?

Add them below function will open the “add contact” form. If the drop down doesn’t have the contact I want to use for this operation, then i will add them. The add contact form should only appear if the user click “add then below”

Sep: Will the contact form pop up under the dropdown like a nested form?

The form only appears if the user clicked “add below”, by default the page does not show the form
Yes the form should pop up below the dropdown..not sure about a nested form :O

By default the page only has the dropdown. Then the user can pick a contact from the dropdown. Or if they click add below then the form appears :)

@patriciarussellCAS
Reachable at:
https://cas-bciers-frontend-dev.apps.silver.devops.gov.bc.ca/registration/register-an-operation

Was able to review this step using the New Entrant flow. I'll close this ticket for now but will need to review/confirm this works for each registration type/purpose.


Providers Mixin

what
Added providers.tf to mixins folder
why
This file is the same across many components. When referring to it in documentation, we want to link a common location
references

https://github.com/cloudposse/refarch-scaffold/pull/107/

duplicate of #613


Node 20 support

Because node 20 is LTS, would it be possible to set the engine in package.json to 20?
Not sure if there's any other dependency that prevents from upgrading node version.
Thanks for this create plugin and the support :-)

+1

+1

+1

+1

+1


ClasspathIndex should expose ability to lookup Classdir

After #1723 it became impossible to debug ClasspathIndex.dirs. The fact it was public before made it possible to track down critical bugs like #1696. I propose to revert the change in #1723 to make the field public again so that it's possible to drill into the Map to investigate problems.
Alternatively, we can replace
def isClassdir(path: String): Boolean

with
def getClassdir(path: String): Option[Classdir]

instead.
For stable public APIs I agree that private fields are a good default. However, ClasspathIndex is an unstable and internal API so I think it's fine to default to public even if the data structure is mutable.

I don't mind either way. Will do a PR.

I prefer to have val dirs: mutable.Map in that case so it's possible to pprint.log(index.dirs)


start v1.4 development

Starting v1.4 development cycle.
See patches.

ah no, it's in the "Prepare for v1.3 release" PR, ignore me :)


⚠ Bofrost.es has degraded performance

In d50950f, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1630 ms

Resolved: Bofrost.es performance has improved in dc9523e after 7 minutes.


Hikari does not handle SQLFeatureNotSupportedException in PoolBase.setupConnection when setting autoCommit

While fixing issue 1116, calls to connection.getAutoCommit() and connection.isReadOnly() were added to gate calls to the associated setters in PoolBase.  However, this breaks integration with the mongo-jdbc-driver as getAutoCommit() throws a SQLFeatureNotSupportedException because the driver acts as though autoCommit is always false.
As per the Connection documentation, "if setAutoCommit is called, and the auto-commit mode is not changed, the call is a no-op", so I believe the correct way to handle this would be to remove the gates, but I believe the following would work as well:
try {
  if (connection.getAutoCommit() ~= isAutoCommit) {
    connection.setAutoCommit(isAutocommit);
  }
} catch (SQLFeatureNotSupportedException {
  // pass;
}

The same problem occurs with Pinot's JDBC driver.

Any news here?
Is there any way how to workaround this issue? Override some methods? How exactly?

It looks like the fix was released in v1.1.0 of the mongo-jdbc-driver.

We fixed it in Pinot driver.
It was merged but not yet released.
https://github.com/apache/pinot/pull/12480


Only show the new onboarding view if the opt in feature is enabled

#3441  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Added support for zsh completions

Closes #3035
Docs issue: https://github.com/pachyderm/pachyderm/issues/4495

@Tryneus could you give this a shot? I don't anticipate any issues with MinGW-based bash, but want to double-check just in case.

In bash, the convention is that the completion script name is the same as the executable name. Similarly, in zsh the completion script name is supposed to be the same as the executable name, with an underscore prefix.

Removed setting the filename


Image slider with multiple controls and mobile swipe control (Javascript)

Issue Type:

[ ] Bug Report
[X] Feature Request
[X] Documentaion

Description

Image slider with multiple controls and mobile swipe control (Javascript) is created by  using HTML, CSS, Javascript . Image slider with multiple controls and mobile swipe control (Javascript).  Image slider with multiple controls and mobile swipe control (Javascript) example is best for Bootstrap responsive. It is very easy to add snippets to your project and easy to modify.

Screenshots
https://user-images.githubusercontent.com/93794214/156314935-688bc2bb-f91c-45fd-a3fc-8805a050b5d2.mp4

If applicable, add screenshots to help explain your problem.

@SayedTabish72 raise this issue in the amazing js projects repo. I will assign it to you.


fix: Correct header deletion behavior when rule.SetOnResponse is true

That is a wierd typo to be left ot of a test, could you add unit tests to make sure it does not happen again ?

That is a wierd typo to be left ot of a test, could you add unit tests to make sure it does not happen again ?

The commit contains the test has been pushed.


Missing declaration file on v0.3.3 ?

Hi.
It seems that<EMAIL_ADDRESS>has no declaration file (.d.ts). 😓
Reproduction
// index.ts
import { debounce } from "ts-debounce";

debounce();

$ npx tsc index.ts --strict
index.ts:1:26 - error TS7016: Could not find a declaration file for module 'ts-debounce'. '/Users/koba/tmp/aaaaa/node_modules/ts-debounce/dist/src/index.js' implicitly has an 'any' type.
  Try `npm install @types/ts-debounce` if it exists or add a new declaration (.d.ts) file containing `declare module 'ts-debounce';`

1 import { debounce } from "ts-debounce";
                           ~~~~~~~~~~~~~

I would be glad if you would check this problem.

Hey @ybiquitous ! Yes, sorry, 0.3.3 was missing that file. I still need to figure out why it gets lost during some deploys. I've released 0.3.5 which has this file.
https://www.npmjs.com/package/ts-debounce/v/0.3.5

@chodorowicz Thanks! I confirmed TypeScript compiler succeeds for my code! 😄


Fix/#196

Description
I have added a fixed height to the header in the chat view. I have changed too the way to center elements at the navbar, since we are using flex, is better continue using flex to center vertically the elements
fixes #196
Screenshots
Before: (Please note how the arrow is so down)

Now: (Please note how now all is more centered)

Type of change

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How to test it
If applicable, describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Go to deploy link
Please check all views that contain the back button to know if all is good. On another hand, please go to /chat/1 to see the chat changes

Checklist:

[ ] The header have min height and look goods
[ ] The back button and the avatar at small vertical screens looks good
[ ] Checked if max height is needed and added if is needed

@angelik0828 please check responsive

Please rebase


ChangeBackupType folder structure

I current make use of the ability to configure Directory Structure because we use and rotate between multiple CIF shares to maintain our retention.
I am currently using these parameters:
,@Directory = '\\xxxx.xxx\DBA\BKP-DC0-DEV-DIFF\'
,@DirectoryStructure = '{ServerName}_{InstanceName}{DirectorySeparator}'
,@FileName = '{DatabaseName}_{Year}{Month}{Day}_{Hour}{Minute}{Second}_{FileNumber}.{FileExtension}'
,@BackupType = 'DIFF'
,@FileExtensionDiff = 'diff'
,@ChangeBackupType='Y'

My question (and I may be missing this) when I use the parameters this way and a new database is created and never been backed up, it places the backups in this DIFF network share.
is there anyway to change the @Directory parameter (or any of them) to another share when @ChangeBackupType is used ?  example:   \xxxx.xxx\DBA\BKP-DC0-DEV-FULL\
because right now the first BAK file is being stored in my DIFF directory structure

@SQLPadre, as it currently works, the only way would be to add the token {BackupType} to the @DirectoryStructure parameter and remove the hard coded backup type from the @Directory parameter.

would @Directory = '\xxx.xx\DBA\BKP-DC0-{BackupType}' work?
if my 3 folder structures use the toke {BackupType}?

Nevermind Ola, I think I figured it out by bring the @Directory parameter down one level
@Databases = 'USER_DATABASES' 	,@Directory = '\\xxxx.xxx\DBA\' 	,@DirectoryStructure = 'BKP-DC0-DEV-{BackupType}{DirectorySeparator}{ServerName}_{InstanceName}{DirectorySeparator}' 	,@FileName = '{DatabaseName}_{Year}{Month}{Day}_{Hour}{Minute}{Second}_{FileNumber}.{FileExtension}'

@SQLPadre, yes, that is the way to do it.


[enhancement]: Use the CoreML version of realESRGAN on Mac

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
No response
What should this feature add?
On the Mac, Real-ESRGAN upscaling in Invoke currently runs on the CPU. This project uses a version of it that runs on Apple's CoreML framework, allowing it to run faster and more efficiently on the GPU/Neural engine. It would be nice if Invoke could be updated to use this version.
Alternatives
No response
Aditional Content
No response

Model on huggingface here: https://huggingface.co/TheMurusTeam/CoreML-realesrgan512


Could not start celery

After installing and running, the API endpoints work, but the Web-UI does not. It loads, but if you try to upload a file it hangs and on refresh shows no file was uploaded.
I tried running the tests through Snake Charmer and it fails when starting celery.
Starting mongodb... Done!   Starting redis... Done!     Starting Celery...Could not start celery
I've verified that celery is installed, so I'm not sure why it can't start
I've tried reinstalling which did not work
I'm running this on Ubuntu:
Distributor ID: Ubuntu   Description:    Ubuntu 18.04.1 LTS   Release:        18.04   Codename:       bionic
The log files I checked didn't seem to helpful, is there anything else I can try to get this working?

Right so before we start digging through logs, have you by chance upgraded to Python 3.7? Currently celery does not support this version of python. This lack of support is currently preventing me from publishing Snake 1.1!
If this is not the case, please could you attempt to upload a file to Snake and provide the snake.log. Depending on the install type it will be in '~/.snake/log/snake' (Basic) or '/var/log/snake' (Prod)

I currently have both Python 2.7.15rc1 installed and Python 3.6.6 installed.
Here is the result and log of uploading from the API and Web-UI respectively:
API Upload:
curl 'http://localhost:5000/upload/file' -F<EMAIL_ADDRESS>-F 'name=test-upload' -F 'description=the is a test' -XPOST
{
"data": {
"sample": {
"children": {},
"description": "the is a test",
"file_type": "file",
"magic": "ASCII text",
"mime": "text/plain",
"name": "test-upload",
"parents": {},
"sha256_digest": "d2a84f4b8b650937ec8f73cd8be2c74add5a911ba64df27458ed8229da804a26",
"size": 12,
"submission_type": "upload:file",
"timestamp": "2018-10-11T14:03:47.915878"
}
},
"status": "success"
Log:
[I 181011 10:03:47 web:2106] 200 POST /upload/file (<IP_ADDRESS>) 99.01ms
Web-UI Upload:
Hangs on upload

No update in the log, refreshing the page shows no items in the files tab. Making an API request to list files also shows nothing is there.
snake.log

Hmm that log file is very odd there should be much more than that. I have just spun up a clean install of Ubuntu 18.04 and done a production install and get the following output in my snake log.

What confuses me further is that when you talk to the API directly you are getting a success response, so I assume curl http://localhost:5000/store is not returning the file that you just uploaded?

If this is working then it could be a problem with the web browser and thus output of its console and network tabs will help to debug.
To me, based on the emptiness of your snake.log it looks like Snake-Skin is failing to talk to the API.

When I upload through API I am able to also view through the API:
curl http://localhost:5000/store
{
"data": {
"samples": [
{
"children": {},
"description": "",
"file_type": "file",
"magic": "ASCII text",
"mime": "text/plain",
"name": "test.txt",
"parents": {},
"sha256_digest": "d2a84f4b8b650937ec8f73cd8be2c74add5a911ba64df27458ed8229da804a26",
"size": 12,
"submission_type": "upload:file",
"tags": "",
"timestamp": "2018-10-12T01:40:01.958800"
}
]
},
"status": "success"
I forgot to mention that I was trying to access the web interface through the network, instead of on the localhost. When I try accessing it from localhost, it will work:

It's when I try accessing through say http://<IP_ADDRESS>:8000/#/upload that I am getting the issues.  So there are a couple of ways, each have their own pros and cons.
Solution 1:

Change snake to serve on <IP_ADDRESS> (as you have done)
Update the API url in snake-skin ( snake-skin/src/config/config.js) and rebuild snake-skin

Solution 2:

Serve snake through an nginx reverse proxy
Update the API url in snake-skin ( snake-skin/src/config/config.js) and rebuild snake-skin

All this issues stem from the fact the the API URL has to be hardcoded into the snake-skin build. What I will do is update the README and improve the install script so that you can pass it the doman/ip that the api will run on.

Thanks it's working now. I set the ip in snake-skin/src/config/config.js to the devices ip, the nginx reverse proxy wasn't working for me.
I'm not sure if there was an easier way, but I had to reset the VM to before running the npm install / npm build commands, run the first few lines of the install.sh script to get the snake-skin files, then alter the config.js file. If I tried to alter the config.js file after the full install.sh run, and then try to rebuild with npm install / npm build / npm rebuild, the web interface would not change to the modified ip.

Yes, this issue has brought to light limitations in the current install script. I will try to update it in the next few days along with the readme. Basically the install script should be able to update/upgrade a current installation but it seems to fail at that. I will leave this issue open until I get round to improving these. Thanks for bringing it to light :)

Far less important now that we have docker support, will remove the user.sh script and update the install.sh script as user.sh has effectively been replaced with docker IMO.


Tooltips missing on file search

Issue Type: Bug
Hover on the buttons in the file search bar. The "Toggle Replace" button shows a tooltip, but the other buttons (Match Case, Match Whole Word, Use Regular Expressions, Previous/Next result, Close, etc.) do not show the title tooltip. I suspect this is a recent regression.

 I don't know what is different about Toggle Replace. Can you reload the window and check again? Or try in our Insiders build?

TBH, I'm not interested in downloading the insiders build 🙂. But I've restarted VS Code several times, and it's still an issue for me today. Other tooltips are working. I only noticed because I was trying to figure out what this button does, and without a tooltip its not very clear.

Ok, I figured it out. I don't think it is a VS Code issue, but a Windows issue. I have the window maximized, and the tooltips are showing on a different monitor. If I reduce the window size, they show up in the correct location. It's the same for any tooltips on the edge of the screen there.
This is happening to me with other apps besides VS Code, so it is not your issue. Thanks!

That's interesting... thanks for checking that


Load_in_8bit causing issues: Out of memory error with 44Gb VRAM in my GPU or device_map error

I'm able to get the generate.py script working. However, with the finetune.py script I'm facing the following error:

It seems to be because the load_in_8bit parameter is set to True and it's looking for a quantisation_config,json but if I set it to False then even a GPU with vRAM of 44Gb is not enough to train the model.
How do I create the quantisation_config,json? I'm using huggyllama/llama-7b as the base model since the given link for the base model is down. I face the same error when I use baffo32/decapoda-research-llama-7B-hf as the base model.
Any help would be appreciated, thank you!

I think is run out off memory, maybe you should try colab or clean up memory for space to load model.


ES2015 export

Hi,
today I got this working @pcdummy/angular-aot-es2015-rollup, its Angular 4.x with Tree-shaking (remove unneeded deps from the output).
This needs an ES2015 export in package.json (and ofc. the build of the files in releases) which is very good documented here.
Is there any interest in getting ES2015 exports into this library? If so i would make this happen with a PR.

A note: with tree-shaking Angular 4 compiles down to 355KiB

I'd be happy to get a PR.
Thanks!

That's something I've already done on my side see @ui-auth/core which follow Angular Package Format

I'll try to provide a PR once I have time but not soon :), https://github.com/dherges/ng-packagr may help

@aitboudad thanks for the tip on ng-packagr its great!
@ronzeidman Pull request is there.

Thanks, didn't know about ng-packager!

Note: npm publish should be executed inside dist folder

travis will do that.


Cleanup and house keeping

This is an umbrella issue for Palindrom cleanup:
The things I propose to do are:
Step 1:

Clean up as many callbacks as possible from the codebase in palindrom.js, now it's quite convoluted, most of the time needlessly. Like connectToRemote, reconnectionFn, bootstrap. makeInitialConnection, makeReconnection most of these can be promisified to become cleaner or entirely removed.
Move PalindromNetworkChannel, Reconnector, Heartbeat to separate files since we're using Webpack anyways.
Merge establish and reestablish.
Remove deprecated changeState.
Move closeWsIfNeeded from a function to a _method.
Remove deprecated options.callback.
Remove deprecated ignoreAdd.
Remove never used showWarning.
Move sendPatches from a function to a _method.

I'll commit for every one of those for easier review.
Step 2:
Now that we cleaned up with the same tests and we know we have a working, clean codebase, we move to step 2:

Implement #175 and update the tests accordingly.

Please only implement step 1, I think that we will not have time for step 2 now.

All of the steps are done. Just some final polishing and conflict resolving is needed. All pushed here https://github.com/Palindrom/Palindrom/pull/227

@tomalec can you please finish this issue? The PR https://github.com/Palindrom/Palindrom/pull/227 is close to finishing.


Preconfigured container to use adminMongo with zenbot_mongod…

…b database. Visit http://:1234 do use it
It's commented out so users can decide to use the adminMongo GUI when needed.

Port 1234 is the mongodb web ui port that is used to access the ui in a browser http://yourip:1234.
I removed the exposed mongodb port.


Should HLA typing remain a part of FRED?

I wonder whether HLA typing is really something you would just want to call as a function from Python code. It's a lengthy analysis and Pipelines exist in Nextflow (https://github.com/nf-core/hlatyping) and Snakemake (https://github.com/lkuchenb/MultiHLA).
Any opinions on this?

Would it be a lot of effort to keep the existing interfaces for HLA typing? I guess there might still be cases in which someone would like to build "pure Python" pipelines/scripts. However, personally I'm fine with not keeping it as part of FRED.

Decision postponed due to missing feedback.

We will keep it in there for now.


Some offerings

useless part of code
    public byte[] ServerKey1 = Utils.Random128Key();
    public byte[] ServerKey2 = Utils.Random128Key();

replace on
    public byte[] ServerKey1 = new byte[128];
    public byte[] ServerKey2 = new byte[128];

because ServerKey1 and ServerKey2 filled anyway from
    public bool ProcessServerData()

Can you add loading servers list from xml config? Like this http://pastebin.com/U8cf34Lm

to 1) Yep, it's pretty useless in our Case. It just from the historical funtion of the code. It was a encryption class for a emulator, so it pregenerated the serverkey.
to 2) Yep, it's possible to add that optinally. Can you provide a xml file I can work with?

Yeah sure.. Here example http://pastebin.com/5PtcZbbF
Thanks advance :)

Included


support for other names for tags and develop branch

I do like this tool, so version info is keep in git, but on this project has a other naming conv. for tags and develop branch, so we fail back to githubflow and gitflow(what are are runnign with some diff.).
so we will be lovy that you can define what prefix version tags has e.g. version-{x.y.z}
and or what the name for main develop branch is called.
i don't knwon if config or passing it into task/command is the best way.

This is fully supported in 3.0.
Phew.. that was a lot of work...

Great work! Exactly how is this supported? Via .yml configuration?

Yep, via the config. You can use 'GitVersion init' to generate a sample config file or 'gitversion /showConfig' to see the effective config and just override what you want to.
Sent from my Windows Phone

From: Asbjørn<EMAIL_ADDRESS>Sent: 26/02/2015 04:07
To<EMAIL_ADDRESS>Cc: Jake<EMAIL_ADDRESS>Subject: Re: [GitVersion] support for other names for tags and develop branch (#292)
Great work! Exactly how is this supported? Via .yml configuration?
—
Reply to this email directly or view it on GitHubhttps://github.com/ParticularLabs/GitVersion/issues/292#issuecomment-76144232.


Make the Web Version work with the Kobo Browser

I can easily download .epubs with the Kobo Browser. Only for converting them to Kepub I have to gab either a PC or mobile phone. Is there a way or any plan to make the Web Version of Kepubify compatible with the Kobo Browser, so that one need 0 extra devices to get a book? Currently, you get an error message that the browser is not supported.

That's not happening for multiple reasons, unfortunately. For one, the open file dialog causes the Kobo to hang since event handling for it isn't implemented. Most importantly, though, webkit on it is so hopelessly out of date, and some devices barely have enough RAM for anything, that I'm not even sure I could make it run slowly.


Intermittent failures in IndentationRule causing 'Stack should be empty' errors

Behavior
When running detekt with the ktlint formatter set enabled (see attached reproducer project), the IndentationRule which is called in ktlint intermittently sees a failure during parsing.
Config:
  # full detekt.yml in attached project
formatting:
  Indentation:
    active: true
    autoCorrect: true
    indentSize: 4

Stacktrace:
Location: com.pinterest.ktlint.ruleset.standard.rules.IndentationRule.afterLastNode(IndentationRule.kt:965)
The original exception message was: Stack should be empty:
  IndentContext(fromASTNode=Element(kotlin.FILE), toASTNode=PsiWhiteSpace, nodeIndent=, firstChildIndent=, childIndent=, lastChildIndent=, activated=true)
  IndentContext(fromASTNode=Element(CLASS), toASTNode=PsiElement(RBRACE), nodeIndent=, firstChildIndent=, childIndent=, lastChildIndent=, activated=false)
  IndentContext(fromASTNode=Element(CLASS_BODY), toASTNode=PsiElement(RBRACE), nodeIndent=, firstChildIndent=    , childIndent=    , lastChildIndent=, activated=false)
  IndentContext(fromASTNode=PsiElement(LBRACE), toASTNode=PsiElement(RBRACE), nodeIndent=, firstChildIndent=, childIndent=    , lastChildIndent=, activated=true)
  IndentContext(fromASTNode=BLOCK, toASTNode=PsiElement(RBRACE), nodeIndent=    , firstChildIndent=    , childIndent=    , lastChildIndent=    , activated=false)
  IndentContext(fromASTNode=Element(FUN), toASTNode=PsiElement(RPAR), nodeIndent=    , firstChildIndent=, childIndent=, lastChildIndent=, activated=true)

This occurs in a file that looks like the following, note the incorrect spacing here: (){
class XYZA {
    fun tearDown(){
    }
}

There was a similar issue reported a while back, #6357, but they could not provide reproduction steps.
Is this a bug in ktlint? What's the actual potential issue/root cause?
I don't think it's a bug in ktlint, and I tried to reproduce it in the ktlint project, checking out the tag that detekt uses, and then adding the following test runs successfully
> ktlint-ruleset-standard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/rules/IndentationRuleTest.kt
 @Test
 fun `improperly spaced brackets should not crash`() {
     val code =
         """
         class XYZA {
             fun tearDown(){
             }
         }
         """.trimIndent()
     indentationRuleAssertThat(code)
         .hasNoLintViolations()
 }

I also tried to test using the command line, but could not reproduce it.
Looking at both the source of the detekt/FormatterRule and the ktlint/IndentationRule, it looks like detekt is doing some pre-processing of the ASTNodes being sent to ktlint, so perhaps that could be the issue? In any case, the following code from ktlint seems to be ineffectively removing the nodes from the stack, causing an eventual validation error at the end of the rule.
    override fun afterVisitChildNodes(node: ASTNode
        ...
        while (indentContextStack.peekLast()?.toASTNode == node) {
        indentContextStack.removeLast()

Which later causes the exception to be thrown in override fun afterLastNode() ... require(indentContextStack.isEmpty()).
Your Environment

Version of detekt used: 1.23.5 (but also reproduces on 1.23.3)
Version of Gradle used: 8.0, 8.2
Operating System and Java version: Java 17.0.2+8-LTS Mac OS X as well as Java 17.0.3+6-LTS Mac OS X

Steps to Reproduce

Given the following project
repro.zip

Run ./gradlew app:detekt .
Now, the interesting bit, it might fail the first time, but generally fails on the second invocation
Run git reset --hard HEAD to dismiss autofixes (if present)
Run ./gradlew app:detekt again. You might have to repeat this process with or without the git reset to see the error, but I confirmed with a colleauge that they could repro on the third attempt on the sample project before sending this bug report

Thanks in advance!

This issue is stale because it has been open 90 days with no activity. Please comment or this will be closed in 7 days.

Still an issue, not stale <3

still an issue :p


How do I use argTypes including controls?

Are they provided as attributes to Meta? How are they formatted? Forgive me if there was an example somewhere, I didn't see it. Also forgive me if this shouldn't be asked in an issue. Not sure where to ask it.

@ericmand if i understand you correctly you're looking for this: https://github.com/storybookjs/addon-svelte-csf/pull/1#issuecomment-788099560

Sure does. Thank you!


Integration with autocompletion is confusing

In the recommended configuration for using nvim-cmp with nvim-lspconfig, capabilities are manually passed to language servers:
-- Add additional capabilities supported by nvim-cmp
local capabilities = vim.lsp.protocol.make_client_capabilities()
capabilities = require('cmp_nvim_lsp').update_capabilities(capabilities)

local lspconfig = require('lspconfig')

-- Enable some language servers with the additional completion capabilities offered by nvim-cmp
local servers = { 'clangd', 'rust_analyzer', 'pyright', 'tsserver' }
for _, lsp in ipairs(servers) do
  lspconfig[lsp].setup {
    -- on_attach = my_custom_on_attach,
    capabilities = capabilities,
  }
end

Since rust-tools automatically sets up rust-analyzer for the user, it's a bit confusing how these capabilities should be passed in. Should they be specified in the server section of rust-tools's setup options?

I did some experimenting and passing the capabilities in the server options works perfectly, as I should have inferred from the README. Closing.


per-page convention to disable ssr?

Something like ssr = false https://kit.svelte.dev/docs/page-options#ssr
It might help, for example, for complete client only loader.
Essentially it needs to the following based on such flag

when such page is requested directly

(server) just skip entirely handleReactRouterServer
(client) just createRoot/render instead of hydrateRoot

for client navigation

just do same as now

which sounds too simple?

Closing vite-glob-routes issues since we focus react-server


Type error when sending Readable to reply.send

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched existing issues to ensure the bug has not already been reported

Fastify version
5
Plugin version
4.0.1
Node.js version
20
Operating system
Linux
Operating system version (i.e. 20.04, 11.3, 10)
n/a
Description
The following schema
{
  schema: {
    // ...
    response: {
      200: {
        type: 'string',
        headers: {
          'Content-Type': { type: 'application/octet-stream', default: 'text/csv' },
        },
      },
    },
  },
}

Leads to reply.send being typed as (payload: string | undefined) => ....
This is problematic because sending streams leads to a type error

Argument of type Readable is not assignable to parameter of type string.

Link to code that reproduces the bug
No response
Expected Behavior
reply.send(someReadable) does not lead to a type error

How would you expect to represent this with json-schema-to-ts?


0.10.0 release

Published!

hey, could you please push a tag to github? :) Thanks!

Woops, thought I did that, but I guess I didn't. Tagged!


Update to latest certs from Mozilla

This was required in order for an install to proceed.
Looks like some certificate authorities that are valid (like StartCom) and now in Mozilla were being rejected by z_fetch_url at install time.

Didn't hear back from you so I went ahead and pulled in the latest from curl.haxx.se

Thanks, the problem was a misconfigured apache2 intermediate cert, so there was no need to update cert.pem in hubzilla after all.


Program update proposal

Add a proposal on how program updates can work and an example token update example.
Fixes #482

@mvines fyi


Change horizon backend to memcached.

Change horizon backend to use memchaced instead of file caching.

Solved.


drop-down list in Nodes

Some nodes need a dropdown menu, taking trigonometric functions as an example. There is a node called 'Trigonometric Functions,' and when the user right-clicks on this node, a list will appear with six options: sin, cos, tan, sec, csc, cot. When the user selects a mathematical operation, the node's name should change from 'Trigonometric Functions' to the selected function (e.g., 'sin'), and it should perform the corresponding mathematical operation inside the node.
For example :
trigonometric functions
|- sin
|- cos
|- tan
|- cot
|- sec
|- csc
There are two main advantages of this approach.
First, it simplify the complexity of the left-side "node list".
Secondly, It allows users to quickly switch between functions without the need to reprocess input and output, enhancing efficiency.

Done. From now on (on dev branch), you can add an option control in your node with Node.add_option_control() method. For example:
class OptionControlExampleNode(Node):
    category = 'function'

    def build_node(self):
        self.label.set('Select a fruit')
        self.option_control = self.add_option_control(
            options=['apple','banana','orange'],
            value='apple',
            label='Fruit'
        )
        self.out_port = self.add_out_port('out')

    def init_node(self):
        self.option_control.on_set += self.option_changed

    def option_changed(self,value:str):
        self.out_port.push_data(value)


starting to implement cubical subtypes (#28)

(my current problems caused by the fact that I don't fully understand the binding structure of systems vis-a-vis cofibration proofs.)


avahidbus: refactor to better handle unicast DNS

Refactors the avahidbus mDNS engine, adding a better mechanism to add/remove watchers to DBus, allowing more control over unicast DNS browses.

Suggest leaving this here unmerged for now. The addition/removal of signal watchers isn't having quite the expected effect. Only when a new ServiceBrowser is created do you get a snapshot of the current cache, but there's no way to clean up these ServiceBrowser instances when you're done with them.

Have a version locally which uses an extra DBus connection for unicast purposes, which ought to work but unfortunately crashes out shortly after the DBus connection is closed.

Can one of the admins verify this patch?

Current thinking is a switch to using python-zeroconf (as it avoids Avahi) along with python-dnspython for unicast. This needs prototyping first.


WebView cookies are empty after being sent through custom header

Bug description:
I am using expo.
After sending a custom cookie through the WebView as described in the guide, the webview's cookies are empty when sent to the React Native code.
To Reproduce:
npx create-expo-app react-native-webview-custom-header
cd react-native-webview-custom-header
yarn add react-native-webview

Then replace code in App.js with this code:
import React from 'react';
import { Button, SafeAreaView } from 'react-native';
import { WebView } from 'react-native-webview';

const POST_COOKIES = `
window.ReactNativeWebView.postMessage(document.cookie);
true;
`

function App() {
  let webview = null;

  const onMessage = async (event) => {
    const { data } = event.nativeEvent;
    console.log('data: ', data)
  }

  const postCookies = () => {
    if(webview){
      webview.injectJavaScript(POST_COOKIES);
    } else {
      console.log('no webview')
    }
  }

  return (
    <SafeAreaView style={{ flex: 1 }}>
      <WebView
        ref={(ref) => (webview = ref)}
        source={{ uri: 'http://example.com/',
          headers: {
            Cookie: 'cookie1=asdf;cookie2=dfasdfdas',
          },
        }}
        originWhitelist={['*']}
        onMessage={onMessage}
        sharedCookiesEnabled={true}
        thirdPartyCookiesEnabled={true}
        javascriptEnabled={true}
      />
      <Button
        title="post cookies"
        onPress={() => postCookies()}/>
    </SafeAreaView>
  );
}

export default App;

Then
yarn ios

Once the emulator is loaded, click on "post cookies" button.
Expected behavior:
The server logs show: data: cookie1=asdf;cookie2=dfasdfdas
Observed behavior:
The server logs show that the cookies are empty: data:
Screenshots/Videos:

Environment:

OS: macOS
OS version: 12.0.1
react-native version: 0.68.2
react-native-webview version: 11.22.7

I observe the same problem when running the app from a react-native project (without expo) with Simulator, on iPhone 13 (iOs 15.5)

I am facing issues when sending headers while making a POST request. My webpage is not authenticated and I receive a warning in the logs saying WebView: source.headers is not supported when using POST.
Any solutions here?
@PaulFlatlooker

I am facing issues when sending headers while making a POST request. My webpage is not authenticated and I receive a warning in the logs saying WebView: source.headers is not supported when using POST.
Any solutions here?

You can first fetch the webpage outside WebView and then pass the content to WebView via source.html.

When I add more than one cookie, only the first appears in the webview cookies (using safari and iOS simulator). Is this normal?
 headers: {
            Cookie: 'cookie1=asdf;cookie2=dfasdfdas',
          },

I can add a lot more using this:
webViewRef?.current?.injectJavaScript(`
    (function() {
        document.cookie = "cookie1=C;"
        document.cookie = "cookie2=B"
        document.cookie = "cookie3=A"
    })();true;
  `);

When I add more than one cookie, only the first appears in the webview cookies (using safari and iOS simulator). Is this normal?

Recently I found out that, using the latest lib version, it's possible to have the cookies on the header by doing the following (only iOS):
          source={{
            uri: currentURL,
            headers: {
              cookie:
                'cookie1 = value1; Expires=Wed, 13 Mar 2024 17:16:14 GMT;, cookie2 = utl;, cookie3 = aaaa',
            },
          }}
          sharedCookiesEnabled

So, I guess the documentation may be wrong? Also, for android does not work, but i still need to investigate more...

@tfreitas90 did you ever find an android solution for this?


Create handlers for http and apikey auth

Handlers and middleware for JWT authentication has been created. Check #2


Load proxy setup from sysconfig and allow elemental specific env variables

I am not 100% sure about reading /etc/sysconfig/proxy for two reasons, it is SUSE specific thing and it is use case specific.
On the other side this makes the SUSE proxy setup transparent to elemental. Then the downstream clusters would require rancher specific setup which can be easily done from the UI as part of the cluster creation. I think this makes the proxy story pretty smooth.

Otherwise we could have put proxy settings in /etc/sysconfig/elemental but it does not make a lot of sense because that means user will have to define the proxy elsewhere if he needs it...
I'm in favor of using /etc/sysconfig/proxy in a first time and check later if someone comes with a different base image.

A testing ISO including the changes can be found here
https://download.opensuse.org/repositories/home:/dcassany:/Elemental:/Dev:/Teal53/media/iso/elemental-teal.x86_64.iso

And the helm chart at:
oci://registry.opensuse.org/home/dcassany/elemental/dev/charts/rancher/elemental-operator-chart

For some reason the static link points to an old ISO... 🤔 That makes me wonder if ISO publishing is really functional. I think @kkaempf saw something similar a while ago, probably this is caused by some cache around 🤷🏽♂ If I download from the link including the build number it just works fine and the ISO is at a different version, this was not supposed to happen, gonna check tomorrow morning if this is still happen, if so we should investigate it, otherwise probably this is just a transitory OBS glitch.

All good this morning!
elemental-register went through the proxy and this is the elemental-system-agent file:

Nothing in /etc/sysconfig/proxy but that was expected because we only configured it for seed-image and I think we do not need it because Rancher will be able to reach the host and send the config with proxy settings.
Last thing, I was able to create a cluster.

All good this morning!

Yes, I'd say we were hitting some cache somewhere... 🤷🏽♂ Probably because the filename does not change we are causing some files update delay as there is no 404 on HEAD requests...

Nothing in /etc/sysconfig/proxy but that was expected because we only configured it for seed-image and I think we do not need it because Rancher will be able to reach the host and send the config with proxy settings.

I am not sure I follow that... anyway, my understanding of the situation is that setting the  /etc/sysconfig/proxy is required within the live system to make sure elemental-register is capable to reach rancher manager. Also the /etc/sysconfig/proxy I believe is required in the installed system to make sure the elemental-system-rancher is actually capable to reach rancher manager and kick start rancher provisioning.  Then, on rancher side, the proxy needs to be configured so that rancher-system-agent is also capable to see rancher manager. So, up to my understanding the configuration needs to be in three different points:

Set /etc/sysconfig/proxy in registration yaml:

cloud-config:
  write_files:
    - path: /etc/sysconfig/proxy
      owner: root:root
      permissions: '0644'
      content: |
        PROXY_ENABLED="yes"
        HTTP_PROXY="http://<IP_ADDRESS>:3128/"
        HTTPS_PROXY="http://<IP_ADDRESS>:3128/"
        FTP_PROXY="http://<IP_ADDRESS>:3128/"
        NO_PROXY="localhost, <IP_ADDRESS>"

Set the same exact /etc/sysconfig/proxy in seed-image yaml.
Set the proxy variables in cluster setup on Rancher side

Set /etc/sysconfig/proxy in registration yaml:

cloud-config:
  write_files:
    - path: /etc/sysconfig/proxy
      owner: root:root
      permissions: '0644'
      content: |
        PROXY_ENABLED="yes"
        HTTP_PROXY="http://<IP_ADDRESS>:3128/"
        HTTPS_PROXY="http://<IP_ADDRESS>:3128/"
        FTP_PROXY="http://<IP_ADDRESS>:3128/"
        NO_PROXY="localhost, <IP_ADDRESS>"

Set the same exact /etc/sysconfig/proxy in seed-image yaml.
Set the proxy variables in cluster setup on Rancher side

yes, three places to configure the proxy settings but I don't think we can do simpler...

How do we get that to rancher-system-agent ?

How do we get that to rancher-system-agent ?

From the UI, with this:


Removing a collaborator deletes a repo

I tried it twice to make sure I could replicate the problem: I created a repo and added a collaborator. Then I removed the collaborator and the repository is gone. Not only that, it is not possible to create a new repository with the same name, so probably only part of the repo's data is deleted from the database.

I could not reproduce such behaviour.
Are you using the dev branch?

@da-kid The issue is from 6 days ago, I believe it wasn't fixed then.

@dentmaged I tried it out with the newest release (master branch) and could not reproduce it.

This wrong behaviour has been fixed in latest version master and release v0.6.3, please upgrade to avoid it! :flushed:

Close for now but open for continuing discussion.