MVP implementation

Connects to https://github.com/vaadin/vaadin-core/issues/136

This change is

Review status: 0 of 12 files reviewed at latest revision, 2 unresolved discussions.

vaadin-dropdown-menu.html, line 202 at r4 (raw file):
Previously, abdonrd (Abdón Rodríguez Davila) wrote…
As other vaadin elements, I think you should change VaadinDropdownMenuElement  to DropdownMenuElement.

In all our elements, we use the full VaadinDropdownMenuElement for the variable in the element definition scoped block (note that the variable is not visible out of the block), but we remove the Vaadin prefix  when making the class public in window.Vaadin  namespace

Comments from Reviewable

Review status: 0 of 12 files reviewed at latest revision, 3 unresolved discussions.

bower.json, line 41 at r5 (raw file):

  },
  "resolutions": {
    "vaadin-list-mixin": "^1.1.1"

Use 1.2.0

Comments from Reviewable

Review status: 0 of 12 files reviewed at latest revision, 3 unresolved discussions.

bower.json, line 41 at r5 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
Use 1.2.0

Done.

vaadin-dropdown-menu.html, line 12 at r3 (raw file):
Previously, abdonrd (Abdón Rodríguez Davila) wrote…
Extra indent.

Removed.

vaadin-dropdown-menu.html, line 202 at r4 (raw file):
Previously, abdonrd (Abdón Rodríguez Davila) wrote…
@manolo check:
vaadin-tabs & vaadin-tab:
https://github.com/vaadin/vaadin-tabs/blob/12bd28a6cd924a3caf3f9f4c97f4bc89bf878368/vaadin-tabs.html#L235-L236
https://github.com/vaadin/vaadin-tabs/blob/12bd28a6cd924a3caf3f9f4c97f4bc89bf878368/vaadin-tab.html#L102-L103
vaadin-button:
https://github.com/vaadin/vaadin-button/blob/a4972d26c8934fcfbf99b56ede420d76cc03a86a/vaadin-button.html#L108-L109
vaadin-radio-button:
https://github.com/vaadin/vaadin-radio-button/blob/4a250e6b8b2cada6e2338be1d143669860a8d7f6/vaadin-radio-button.html#L201-L202

Changed.

Comments from Reviewable

Review status: 0 of 12 files reviewed at latest revision, 3 unresolved discussions.

vaadin-dropdown-menu.html, line 202 at r4 (raw file):
Previously, YuriyVaadin (Yuriy Yevstihnyeyev) wrote…
Changed.

Good point Abdón.
I was confused because of the skeleton, so there are still two recent components that I defined wrong: item and listbox, I will change soon.
Thanks

Comments from Reviewable

vaadin-dropdown-menu.html, line 80 at r6 (raw file):

        * ```
        * <vaadin-dropdown-menu>
        *  <template>

Add listbox to this example

Comments from Reviewable

Review status: 0 of 12 files reviewed at latest revision, 17 unresolved discussions.

vaadin-dropdown-menu.html, line 46 at r6 (raw file):

        *
        * See [`<vaadin-overlay>` documentation](https://github.com/vaadin/vaadin-overlay/blob/master/vaadin-overlay.html)
        * for `<vaadin-dropdown-menu-overlay>` parts.

I think we need to define here the parts that Vaadin.OverlayElement has

vaadin-dropdown-menu.html, line 68 at r6 (raw file):

    </style>

    <vaadin-text-field readonly value="[[value]]" id="input"></vaadin-text-field>

If we want to be iron-form compatible we need to forward at least name and validate, but also disabled ...

vaadin-dropdown-menu.html, line 69 at r6 (raw file):

    <vaadin-text-field readonly value="[[value]]" id="input"></vaadin-text-field>
    <vaadin-dropdown-menu-overlay opened="{{opened}}" id="overlay">

Nit: if there is no content, I prefer in one line like the line above. Or anyways align both with either one or two lines

vaadin-dropdown-menu.html, line 101 at r6 (raw file):

            },

            _contentTemplate: Object,

Why do we need this property?. It's used once in the same block

vaadin-dropdown-menu.html, line 124 at r6 (raw file):

        _onKeyDown(e) {
          if (!this.opened && /^(ArrowDown|Down|ArrowUp|Up|Enter|Space)$/.test(e.code)) {

Native select does not open with enter, but paper-drop-down does. I feel that we should fill native behavior but not sure @limonte @platosha  ?

vaadin-dropdown-menu.html, line 131 at r6 (raw file):

        _onKeyDownInside(e) {
          const menu = this.$.overlay.$.content.lastElementChild;

we are avoiding to use ids because of avoiding conflicting id in shady mode, @tomivirkki  wdyt, should we remove the id here as well?
I don't think lastElementChild is the safest way to get the menu element, I would check for elements that has the mixin, or the localName
btw there is a overlayElement getter in this class, use it.

vaadin-dropdown-menu.html, line 143 at r6 (raw file):

          };

          if ((e.type === 'keydown' && /^(Enter|Space)$/.test(e.code) || e.type === 'click') && eventFromSelected) {

should use e.key instead
move boolean evenFromSelected at the beginning of the condition, checking booleans first make the condition perform better.

vaadin-dropdown-menu.html, line 146 at r6 (raw file):

            if (this.value === '') {
              this.value = e.composedPath()[0].textContent;
            }

more concise this.value === '' && this.value = e. ...  or this.value = this.value || ...

vaadin-dropdown-menu.html, line 148 at r6 (raw file):

            }
            this.opened = false;
          } else if (e.type === 'keydown' && /^(Tab)$/.test(e.code)) {

e.key

vaadin-dropdown-menu.html, line 156 at r6 (raw file):

        _openedChanged(opened) {
          if (opened && !this._instance) {
            this._contentTemplate = this.querySelector('template');

Seems that it should be a const _contentTemplate instead of an instance property. It's not used anywhere else

vaadin-dropdown-menu.html, line 174 at r6 (raw file):

          this.overlayElement.opened = opened;

          const menu = this.$.overlay.$.content.lastElementChild;

The same here. I guess menu could be computed once and leave it in a instance variable

vaadin-dropdown-menu.html, line 187 at r6 (raw file):

            }

            menu.addEventListener('selected-changed', selectedChangedListener);

what's the reason of adding/removing

vaadin-dropdown-menu.html, line 199 at r6 (raw file):

              menu.removeEventListener('selected-changed', selectedChangedListener);
              menu.removeEventListener('keydown', this._onKeyDownInside.bind(this));
              menu.removeEventListener('click', this._onKeyDownInside.bind(this));

I feel like we should compute the menu element once when the light dom is available and add the events, I dont see the need of adding/removing events each time it's opened/closed

vaadin-dropdown-menu.html, line 215 at r6 (raw file):

        get overlayElement() {
          return this.$.overlay;

@tomivirkki shouldn't we avoid ids ?

Comments from Reviewable

Review status: 0 of 12 files reviewed at latest revision, 19 unresolved discussions.

demo/dropdown-menu-basic-demos.html, line 11 at r6 (raw file):

Sample example with vaadin-list-box

Don't we only support list-boxes as content? hence title should be just Basic Usage or Usage

test/dropdown-menu-test.html, line 35 at r6 (raw file):

      it('should have a valid localName', function() {
        expect(dropdown.localName).to.be.equal('vaadin-dropdown-menu');
      });

we need more tests here, like testing selecting, focus code, etc

Comments from Reviewable

Review status: 0 of 12 files reviewed at latest revision, 19 unresolved discussions.

vaadin-dropdown-menu.html, line 46 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
I think we need to define here the parts that Vaadin.OverlayElement has

Added.

vaadin-dropdown-menu.html, line 68 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
If we want to be iron-form compatible we need to forward at least name and validate, but also disabled ...

name and disabled were added. Should validate method be the same as in radio-button-group for example? https://github.com/vaadin/vaadin-radio-button/blob/master/vaadin-radio-button-group.html#L221

vaadin-dropdown-menu.html, line 69 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
Nit: if there is no content, I prefer in one line like the line above. Or anyways align both with either one or two lines

Changed.

vaadin-dropdown-menu.html, line 80 at r6 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
Add listbox to this example

Added.

vaadin-dropdown-menu.html, line 101 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
Why do we need this property?. It's used once in the same block

Removed.

vaadin-dropdown-menu.html, line 131 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…

we are avoiding to use ids because of avoiding conflicting id in shady mode, @tomivirkki  wdyt, should we remove the id here as well?
I don't think lastElementChild is the safest way to get the menu element, I would check for elements that has the mixin, or the localName
btw there is a overlayElement getter in this class, use it.

Should we add a property to ListMixin like _hasVaadinListMixin?
Using now

vaadin-dropdown-menu.html, line 143 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
should use e.key instead
move boolean evenFromSelected at the beginning of the condition, checking booleans first make the condition perform better.

Changed.

vaadin-dropdown-menu.html, line 146 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
more concise this.value === '' && this.value = e. ...  or this.value = this.value || ...

Changed.

vaadin-dropdown-menu.html, line 148 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
e.key

Changed.

vaadin-dropdown-menu.html, line 156 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
Seems that it should be a const _contentTemplate instead of an instance property. It's not used anywhere else

Done.

vaadin-dropdown-menu.html, line 174 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
The same here. I guess menu could be computed once and leave it in a instance variable

It is now used only in one block, I am not sure that we can compute it at any other point other than when overlay opens.

vaadin-dropdown-menu.html, line 187 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
what's the reason of adding/removing

I am adding it when menu exists and removing when it is not present.

vaadin-dropdown-menu.html, line 199 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
I feel like we should compute the menu element once when the light dom is available and add the events, I dont see the need of adding/removing events each time it's opened/closed

I cannot find a proper moment when it should be computed, but I am free for suggestions and can change at any moment.

demo/dropdown-menu-basic-demos.html, line 11 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
Don't we only support list-boxes as content? hence title should be just Basic Usage or Usage

Changed.

Comments from Reviewable

vaadin-dropdown-menu.html, line 215 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
@tomivirkki shouldn't we avoid ids ?

We sure should.

Comments from Reviewable

Review status: 0 of 13 files reviewed at latest revision, 18 unresolved discussions.

vaadin-dropdown-menu.html, line 215 at r6 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
We sure should.

Avoided.

test/dropdown-menu-test.html, line 35 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
we need more tests here, like testing selecting, focus code, etc

Basic tests added.

Comments from Reviewable

vaadin-dropdown-menu.html, line 115 at r8 (raw file):

            /**
             * The value of the control, which is submitted with the form data.

Align API naming with https://vaadin.com/elements/vaadin-combo-box/html-api/elements/Vaadin.ComboBoxElement
Also, analysis.json needs an update

Comments from Reviewable

Reviewed 10 of 15 files at r3, 1 of 2 files at r7, 3 of 3 files at r8, 2 of 2 files at r9.
Review status: all files reviewed at latest revision, 19 unresolved discussions.

Comments from Reviewable

Reviewed 10 of 15 files at r3, 1 of 2 files at r7, 3 of 3 files at r8, 2 of 2 files at r10.
Review status: all files reviewed at latest revision, 10 unresolved discussions.

vaadin-dropdown-menu.html, line 68 at r6 (raw file):
Previously, YuriyVaadin (Yuriy Yevstihnyeyev) wrote…
name and disabled were added. Should validate method be the same as in radio-button-group for example? https://github.com/vaadin/vaadin-radio-button/blob/master/vaadin-radio-button-group.html#L221

yes it works to me

vaadin-dropdown-menu.html, line 174 at r6 (raw file):
Previously, YuriyVaadin (Yuriy Yevstihnyeyev) wrote…
It is now used only in one block, I am not sure that we can compute it at any other point other than when overlay opens.

ok

Comments from Reviewable

Review status: 10 of 13 files reviewed at latest revision, 9 unresolved discussions.

vaadin-dropdown-menu.html, line 68 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
yes it works to me

Added.

vaadin-dropdown-menu.html, line 115 at r8 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
Align API naming with https://vaadin.com/elements/vaadin-combo-box/html-api/elements/Vaadin.ComboBoxElement
Also, analysis.json needs an update

Done.

Comments from Reviewable

Review status: 10 of 13 files reviewed at latest revision, 9 unresolved discussions.

vaadin-dropdown-menu.html, line 124 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
Native select does not open with enter, but paper-drop-down does. I feel that we should fill native behavior but not sure @limonte @platosha  ?

Can be changed in later PRs

vaadin-dropdown-menu.html, line 131 at r6 (raw file):
Previously, YuriyVaadin (Yuriy Yevstihnyeyev) wrote…

Should we add a property to ListMixin like _hasVaadinListMixin?
Using now

ids are avoid.
lastElementChild replaced with querySelector

Comments from Reviewable

Review status: 10 of 13 files reviewed at latest revision, 12 unresolved discussions.

bower.json, line 38 at r11 (raw file):

    "vaadin-demo-helpers": "vaadin/vaadin-demo-helpers",
    "vaadin-text-field": "^1.1.0",
    "vaadin-overlay": "^1.4.1",

text-field and vaadin-overlay shouldn't not be dev dependencies.
vaadin-list-box should be unless we support other implementations.

vaadin-dropdown-menu.html, line 233 at r11 (raw file):

          overlayElement.opened = opened;

          const menu = overlayElement.$.content.querySelector('vaadin-list-box');

This needs a rethinking, probably we could just get the firs element implementing the list-mixin

vaadin-dropdown-menu.html, line 235 at r11 (raw file):

          const menu = overlayElement.$.content.querySelector('vaadin-list-box');
          const selectedChangedListener = (e) => {
            const selectedItem = menu._navItems[e.detail.value];

This is a private API, needs at least to be marked as protected in the mixin

Comments from Reviewable

Reviewed 11 of 15 files at r3, 2 of 3 files at r6, 2 of 2 files at r7.
Review status: 10 of 13 files reviewed at latest revision, 12 unresolved discussions.

vaadin-dropdown-menu.html, line 124 at r6 (raw file):
Previously, YuriyVaadin (Yuriy Yevstihnyeyev) wrote…
Can be changed in later PRs

I don't have any strong opinion on this.

Comments from Reviewable

Review status: 9 of 13 files reviewed at latest revision, 12 unresolved discussions.

bower.json, line 38 at r11 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
text-field and vaadin-overlay shouldn't not be dev dependencies.
vaadin-list-box should be unless we support other implementations.

Done.

vaadin-dropdown-menu.html, line 233 at r11 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
This needs a rethinking, probably we could just get the firs element implementing the list-mixin

Will be replaced with Array.from(overlayElement.$.content.childNodes).filter(node => node._hasVaadinListMixin)[0] once the new version of the vaadin-list-mixin will be released.

vaadin-dropdown-menu.html, line 235 at r11 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
This is a private API, needs at least to be marked as protected in the mixin

Should any changes be done to these part in vaadin-dropdown-menu?

Comments from Reviewable

Reviewed 1 of 15 files at r3, 3 of 3 files at r11, 1 of 1 files at r12.
Review status: all files reviewed at latest revision, 11 unresolved discussions.

Comments from Reviewable

Review status: all files reviewed at latest revision, 8 unresolved discussions, some commit checks broke.

vaadin-dropdown-menu.html, line 187 at r6 (raw file):
Previously, YuriyVaadin (Yuriy Yevstihnyeyev) wrote…
I am adding it when menu exists and removing when it is not present.

I meant that we can just add the listeners once and it's not necessary to remove continously, that simplifies the code.

vaadin-dropdown-menu.html, line 199 at r6 (raw file):
Previously, YuriyVaadin (Yuriy Yevstihnyeyev) wrote…
I cannot find a proper moment when it should be computed, but I am free for suggestions and can change at any moment.

so we can do in a separated refactor, not a blocker

vaadin-dropdown-menu.html, line 233 at r11 (raw file):
Previously, YuriyVaadin (Yuriy Yevstihnyeyev) wrote…
Will be replaced with Array.from(overlayElement.$.content.childNodes).filter(node => node._hasVaadinListMixin)[0] once the new version of the vaadin-list-mixin will be released.

Leave this with the query selector, since we are going to change the vaadin-item so it should be used instanceof, but you can also look for element that has _navItems since you are using that api below

vaadin-dropdown-menu.html, line 235 at r11 (raw file):
Previously, YuriyVaadin (Yuriy Yevstihnyeyev) wrote…
Should any changes be done to these part in vaadin-dropdown-menu?

we need to mark _navItems as protected so as it is not renamed or removed in the future

vaadin-dropdown-menu.html, line 168 at r12 (raw file):

          this._inputElement = this.shadowRoot.querySelector('vaadin-text-field');

          this._inputElement.addEventListener('click', e => this._toggleOverlay());

Apart from toggling the overlay it needs to focus the listbox

vaadin-dropdown-menu.html, line 254 at r12 (raw file):

            if (itemToFocus) {
              itemToFocus.focus();
            }

Replace this block with menu.focus() already supported in list-mixin 1.3.0

Comments from Reviewable

Review status: 11 of 13 files reviewed at latest revision, 4 unresolved discussions.

vaadin-dropdown-menu.html, line 168 at r12 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
Apart from toggling the overlay it needs to focus the listbox

Done

vaadin-dropdown-menu.html, line 254 at r12 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
Replace this block with menu.focus() already supported in list-mixin 1.3.0

Done

Comments from Reviewable

Review status: 11 of 13 files reviewed at latest revision, 4 unresolved discussions.

vaadin-dropdown-menu.html, line 187 at r6 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
I meant that we can just add the listeners once and it's not necessary to remove continously, that simplifies the code.

Done

vaadin-dropdown-menu.html, line 235 at r11 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
we need to mark _navItems as protected so as it is not renamed or removed in the future

We would do later, not a blocker for this PR

Comments from Reviewable

Review status: 11 of 13 files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable


Questing: Playing same song multiple times

Hello,
i'm making something like "playlist" functionality, but when 2 song in row are the same the second song will not be played automaticaly. Maybe because nothing changed in state? Is there way to start it playing?
Thanks
Boris

You are correct that if you try to "play" the currently playing URL, the props don't change and so nothing happens. This is an unfortunate downside in the declarative nature of how ReactPlayer listens to changes in props.
One thing you could do is, at the point where you load a song, check if it is the same as the previous URL and run seekTo(0) if so.


[feat] Allow disabling build types

Describe the problem
Appimage is far from perfect. Some applications don't work with it - so it would be nice if a project could disable building appimages. Some apps might not work on Debian-based systems, etc. Having to spend that extra time waiting for the thing you know won't work to build just so another thing can build is kinda dumb, in my opinion.
Describe the solution you'd like
In tauri.conf.json, I would like there to be an option that allows for the enabling/disabled of building these things. Disabling both would essentially disable building on Linux, at least until potentially more formats (like flatpak or snap) get supported.
Alternatives considered
No response
Additional context
I know this is a minor thing, but as a Linux dev, this would be a nice QOL feature that shouldn't be too hard to implement as it's just adding a switch. I might be interested in looking into adding it myself, but I'm only semi-familiar with using Tauri and the Tauri CLI, not so much with how it works under the hood. Much love :heart: to all the devs that might read this.

did you configure the targets in your tauri.conf.json ? https://tauri.studio/v1/api/config#bundleconfig.targets

That's embarrassing, but thanks lol


model: new type of manifest that doesn't have YAML

Unified in the appropriate places with the new WatchableManifest
interface, that both model.Manifest and model.GlobalYAMLManifest
implement.

One cleanup task I want to do is make private all the fields on model.Manifest that are now exposed via functions.


SSA Refactor: Implement array cloning

Problem
In Noir, arrays are cloned when moved into another variable:
let mut a = [1, 2, 3];
let b = a;

a[0] = 5;
assert(a[0] == 5);
assert(b[0] == 1);

However the SSA refactor currently does not clone them, instead arrays function more as references:
let mut a = [1, 2, 3];
let b = a;

a[0] = 5;
// Assuming this was compiled with the new ssa refactor this would hold currently
assert(a[0] == 5);
assert(b[0] == 5);

Proposed solution
Add a check when creating new variables to clone arrays.
Alternatives considered
Alternatively, change arrays to have some immutable representation that does not need to be cloned manually. An example representation would be im::Vector which would also allow us to grow these arrays.
Additional context
No response
Submission Checklist

[ ] Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.

@jfecher is this still relevant?

Alternatively, change arrays to have some immutable representation that does not need to be cloned manually. An example representation would be im::Vector which would also allow us to grow these arrays.

This is done now, we use im::Vector for all arrays in SSA.


[GJ Unity API v2.5.4] Recieving a variety of errors on build in unity 2019.1.6f1

just go to "Plugins/Editor/ GameJolt/GameJolt/GameJoltEditor.asmdef" make sure that in the inspector under the "Platforms" area the "Any Platform" is not checked and directly below it (under "Include Platforms") only "Editor" is checked. Afterwards click on apply.
I'll fix this in package and upload it soon.

just go to "Plugins/Editor/ GameJolt/GameJolt/GameJoltEditor.asmdef" make sure that in the inspector under the "Platforms" area the "Any Platform" is not checked and directly below it (under "Include Platforms") only "Editor" is checked. Afterwards click on apply.
I'll fix this in package and upload it soon.

thank you so much! it seems to be working now, it built without the errors too!


fix issue/5

display warnings
x     if exist non-discrete notes
o    if exist too long lines in score file


Can not authenticate, This app is blocked error

When i try to connect my account, after select the account in Chrome it says:
This app is blocked
This app tried to access sensitive info in your Google Account. To keep your account safe, Google blocked this access.
I have tried "less secure app" settings (in https://myaccount.google.com/lesssecureapps), it required Two factor authentication should be off for turn this on, I have turn off the TFA, but now it says:
This setting is not available for your account.
I can authenticate from gcloud cli, but can not authenticate the Google cloud tools for Visual Studio 2022 plugin.
Please help!

Same issue here! Have you solved it?

Same issue, Any progress?

Hi, Same issue, is there any progres?

Unfortunately, not as of yet. I've just been using the chrome extension download for GCP in the meantime. Admittedly I haven't been able to commit much time to finding a solution due to work commitments.

From: Kamil Akarsu @.>
Sent: Friday, January 5, 2024 14:41
To: GoogleCloudPlatform/google-cloud-visualstudio @.>
Cc: Westkoast @.>; Comment @.>
Subject: Re: [GoogleCloudPlatform/google-cloud-visualstudio] Can not authenticate, This app is blocked error (Issue #1153)
Hi, Same issue, is there any progres?
—
Reply to this email directly, view it on GitHubhttps://github.com/GoogleCloudPlatform/google-cloud-visualstudio/issues/1153#issuecomment-1879174217, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6IZYBLWSB3S4M3POZ4XEFTYNBJOJAVCNFSM6AAAAABAHLSMRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZGE3TIMRRG4.
You are receiving this because you commented.Message ID: @.***>

Same Issue with Visual Studio 2022, i try with extension in Visual Studio Code without problems. But i need it in Visual Studio 2022.
Regards!

getting this as well

still the same issue i see, shame this is not getting fixed as i really need it working right now

same issue

Same issue here. The extension authentication flow is broken. Extension uninstalled.

Facing same issue

Still an issue!
on a fresh install of everything - i've run into this issue
Windows 11 10.0.22631
Visual Studio Community 2022 17.9.5

Any solution

same issue

Same issue here.

Same issue here.

Same issue here

Same issue here, any idea or workaround?

same issue here

Same issue, using 2 factor auth.

Same issue

same issue

same thing for me, anyone?

Same issue

Same issue


Catherine Weresow's avatar is broken on README

In the README file, there is a broken image for Catherine Weresow.

Fixed in https://github.com/codecombat/codecombat/commit/038b9a3a4a16f18cfeb1f688c031279c1b97b1c3


Deprecation notice for the Data Viewer in Jupyter

We are currently evaluating the deprecation of the current Data Viewer within Jupyter in favor of alternative solutions that are actively maintained by other teams or the community. Our primary considerations include accessibility, feature richness, and performance, aiming to provide users with the best possible experience for viewing data.
By deprecating the existing Data Viewer, we aim to streamline the focus of the Jupyter extension on its core functionalities. Simultaneously, we intend to provide a robust set of APIs, empowering the community to develop and integrate advanced data viewers seamlessly.

Hi Folks,
Hopefully this is the correct platform to ask this question, if not please re-direct me to a more appropriate forum. I use the open source code-server and just learned that the Data Viewer would be deprecated out of the Jupyter extension.
I rely on the Data Viewer to inspect pandas data frames in memory when debugging .py files such as pipeline scripts or Shiny apps (not .ipynb), and am not aware of any other mechanism to do this in code-server. There is a Data Wrangler extension for but isn't doesn't appear to be available for code-server (only VS Code Server?).

Can someone please let me know what other extensions can still do this in code-server after Data Viewer is deprecated?
Thanks!

Hi @DaveGuenther - that was one entry point we forgot about, but that one should also delegate to any extension that provides the appropriate data viewer (including Data Wrangler) by the next release.
Thanks for reaching out.

Thanks @amunger.  When Data Wrangler is enhanced to include the capability to view data frames in memory during debug of a .py file, will the entry point be similar to the above screenshot?  Essentially a menu option to Open/View in Data Wrangler when right-clicking or hovering on a data frame variable?

Hi Folks,
I should probably clarify that I'm running coder-server 4.89.1 (code 1.89.1), and connecting to it via web browser - not using VS Code Desktop App for this.  Will the new version of Data Wrangler be able to work with the new Data Wrangler to get the "View Value in Data Viewer" functionality in web mode or will I need to update code-server to a newer version for the web functionality?
Thanks!

ah, sorry, didn't realize you were using a different product. Data Wrangler is only available the official vscode, The API's are available for another extension to cover this functionality though.
I'm also not sure what code-server gets you over just using remote development with vscode.dev.

Right, so as far as I can tell, by "alternative solutions that are actively maintained by other teams or the community" you just mean Microsoft's closed source "Data Wrangler Extension for Visual Studio Code". Correct me if I'm wrong, but there doesn't seem to be any other solution available, let alone an open source one.
I don't particularly care about "accessibility, feature richness, and performance", I just want to get a basic idea of what's in a data frame.
I feel like deprecating the simple, built-in, open source solution without making sure there is similar alternative, effectively forcing people to use Data Wrangler, is really shitty. Could you at least split the built-in data viewer out into a separate extension, before obliterating it completely?

Agree with @DRKV333 . I have switched to Data Wrangler for a while, it is really hard to use for inspecting matrix with following pain point:

Can't select index for multi-dimensional array!!! I have to write the code my self to down scale a N-D matrix to a 2-D matrix in order to get a better view of it!!!
The layout is bad, column width is too large, while I have a large matrix with many columns, it is hard to scroll to the column I want.
Can't freeze index!!! For example I have a 100x100 matrix, I want to check the value for column 70, and I can't see the row number!

Really wish there could be a better substitute before deprecate the Data Viewer. And after install Data Wrangler, the old Data Viewer disappeared, does anyone know how to switch back to the old Data Viewer?

I am still failing to see how the Data Viewer and the Data Wrangler serves the same purpose. The Wrangler is a data visualisation tool, the other was a data debugging tool.
While DataFrames are indeed targeted for Data Science, and a data visualiser can be nice, NumPy array are not, they are for Signal Processing and more general purposes. We look into the data to know what is inside it, but for each array we would look at something different. A tool that tries to offer everything we may need in those fields is impossible (or a UI catastrophe and a waste of computing power).
I don't understand the reasoning behind taking the Data Viewer out - I know it was extremely poor in terms of performances, but it's utterly needed to take people out of Spyder or other IDEs.


Contribution Request

MAX+plus II 9.23 Student Edition with Digital Library
https://eeisti.fr/grug/ING-1/Info%20/ADO/Electronique%28Maintenant%20ADO%29/Electronique-secos/electronique0809/VHDL/VHDL%20Altera%20Max%2BPlus%209.23%20Compiler/
MAX+plus II 9.3 Full Edition
Quartus II 5.0 with SP1
Quartus II 8.0

Thanks!  I see the link for MAX+plus II.  I don't see Quartus II 5.0 or 8.0.


[LIGHTNODE] Update fund_amount field in db to solve the activate problem before user raise the support ticket as we moved to the new slot

Closing as fixed.


Client portal returning Access Denied page after 2 months of using IBeam

Hi,
I'd like to say thank you first for making this extremely useful tool, it's become irreplaceable in the last few months. I am not sure if what I'm reporting is a bug, but I've been trying to understand the problem for the past 3 days with no luck. I hope you have time to take a look and offer some advice.
Describe the bug
I've deployed the IBeam Docker image on a Kubernetes pod in my cluster and I have been using it normally in this capacity to place orders for around 2 months. However, this pod was restarted around 3 days ago, and it has not been able to log in to Interactive Brokers since then because the login process keeps resulting in a timeout.
The logs are saying that the timeout is caused by "http://localhost:5000/sso/Login?forwardTo=22&RL=1&ip2loc=on" returning a page saying Access Denied and the response code 403 Forbidden instead of loading the login form. I've tried to run the Docker container locally with the same credentials and conf.yaml to see if it's account/configuration related but it returned the login form without problems. I've also tried to ping "http://api.ibkr.com/sso/Login?forwardTo=22&RL=1&ip2loc=on" directly using curl which worked in the local Docker container but returned the Access Denied page when I did it from the pod.
Environment
IBeam version: Happening on both latest (based on 0.5.1?) and 0.5.2-rc3
Docker image or standalone: Docker image used inside a Kubernetes pod
Python version (standalone users only): /
OS: /
Additional context
I've had a look at the Troubleshooting section but the IPs in my conf.yaml already covered that problem (and I added 10.* to make it work in the internal network).
I changed the IBEAM_GATEWAY_BASE_URL to point to http://localhost:5000/ and I am using a custom conf.yaml to disable listen ssl since I am using Kubernetes to handle HTTPS. The logs do say "Custom conf.yaml found and will be used by the Gateway" and it is correctly targeting the URL I specified in IBEAM_GATEWAY_BASE_URL when trying to authenticate so the configuration is being loaded properly. I've also tried it without the custom configuration anyway and that did not fix it.
Here are the configuration and log files. Added as .txt since that's allowed by GitHub.
conf.txt
env.txt
logs.txt
I've had a look at other issues related to this. There was an issue that mentioned setting {number between 1 and 8}.api.ibkr.com as the proxy remote host would help but I've tried with 1 and 6 and it didn't work. My conf.yaml is still using 1.api.ibkr.com since that was my last attempt.
I also found someone who had a similar problem but they posted in this issue after it was closed.
Suggest a Fix
I think Interactive Brokers might've blacklisted my Kubernetes node's IP, but I've not seen their documentation mention this can happen at any point. I have seen rate limits in their documentation but none of them are related to the authentication endpoint. If it's an undocumented rate limit on the authentication endpoint, then I guess a backoff mechanism would help. But I have no idea if this is the issue.
Thank you for maintaining this tool, it has really come in handy for testing the Interactive Brokers API.

Hey @Androoideka thanks for trying out IBeam and for your kind words 😊 Also thank you for getting into detail regarding your issue and passing over the logs and configs 👍
Looking at the log file I'm seeing some unusual behaviour:

2024-04-17 14:55:56,510|I| Gateway running but not serving yet. Consider increasing IBEAM_GATEWAY_STARTUP timeout. Error: <urlopen error [Errno 111] Connection refused>

2024-04-17 14:57:41,658|W| Cannot determine the version of IBKR website, assuming version 1

These could indicate that something is not going well with the Gateway. Maybe not enough CPU/RAM? You could try to ssh into your k8 node and do some diagnostics to see if the Gateway is started correctly. The best way would be to connect to a display from which you could open a browser and access the login page manually to verify if it loads correctly, though I'm not sure how possible this would be on k8.

I think Interactive Brokers might've blacklisted my Kubernetes node's IP

It's best to talk to IBKR support directly about this. They do mention some rate limiting and banning in their docs, so possibly this is their way of indicating it. I wish I could be of more help here, but I don't know what could be causing this error - other than that your IP is not listed in the conf.yaml, which is always worth double checking.

I'm going to close this issue due to inactivity. Thanks for your contribution and please feel free to request a reopen if you'd like to continue the discussion 👍


ParseError: 'import' and 'export' may appear only with 'sourceType: module'

npm install vidage --save
Inside of app.js:
import Vidage from 'vidage'
Upon compile, leads to following message:
ParseError: 'import' and 'export' may appear only with 'sourceType: module'
Seems like my main entry point in package.json should be changed...
main: "src/scripts/Vidage.js" → main: "dest/scripts/Vidage.min.js"
If anyone else has explanation and solution to this, other than what I think it might be, let me know in here...

I did it the way I mentioned in this issue. I think it should be working now, I will publish new version on NPM in a minute. When I get time to test it, I will update this issue and hopefully close it up!

Everything is working fine now...
Examples of my manual testing:

app.js

import Vidage from 'vidage';
new Vidage('#VidageVideo');

app.js

const Vidage = require('vidage');
new Vidage('#VidageVideo');

Closing it up now! 😋


add material composition to some salv treasure

About the PR
iron made of steel
silver and gold coins have a steel core and silver/gold coating because no zinc
diamond and adamantine coins have less than 1 diamond so recycler doesn't give you anything :trollface:
Why / Balance
if you are low on specific mats you can choose to recycle valuable treasure, essentially buying them at a steep price.
Changelog
:cl:

tweak: Coins and Supercharged CPUs can now be recycled for rarer materials.

test fail is real


Console.error: undefined is not an object(evaluating 'this.drawer.open')

I update the latest version v1.16.7.
and change the way to open the drawer from
this.refs.draw.open()

to
this.drawer.open()

and it makes error.
and some code in my component:
<Drawer ref="drawer"
  type="static"
  openDrawerOffset={DRAWER_OFFSET}
  panOpenMash={.8}
  content={<DrawerScene closeDrawer={this.closeDrawer} />}>

  <MainView
    drawerStatus={this.state.isDrawerOpened}
    closeDrawer={this.closeDrawer}
    openDrawer={this.openDrawer}/>
</Drawer>

the correct syntax is this.refs.drawer.open(). Since you have a string ref, the ref gets added to the ref object. Can you try again and report back if that is working for you?

@rt2zz But in the README.md is this.drawer.open(). Is it something wrong?

good call, I just updated the readme.
I am working on a new stripped down example. There is probably a conflict with the latest version of react-native.

well, when you finish work on the example, @ me please.
To keep my project on, I go back to the version v1.8.0...

@futurefeeling sorry for the delay. There is a new example at ./examples/RNDrawerExample that is a lot easier to tinker with (albeit ugly!). There have also been a lot of bug fixes in the last 2 weeks, I recommend you try npm install --save react-native-drawer@next

@rt2zz thanks, I'm running your example - RNDrawerExample , some trouble in package.json file like:
"dependencies": {
    "react-native": "^0.21.0",
    "react-native-drawer": "github:rt2zz/react-native-drawer"
}

maybe the reason of problem made is that I use a npm mirror named taobao, so I modified the dependencies and fixed that.
Thanks a lot

Glad you got that working. When things start to stabilize I will change that dep to reference npm but for now it sounds like everything is working :+1:

same issues, its not good if we need changes version, right


feat: add create repo page

Description
This PR brings UI updates for /<space_id>/repos/create page
Previous UI versions of this page remain accessible at /v1/spaces/<space_id>/repos/create.
Components relocation:

transfer Root, Label, ControlGroup, Caption, Message, Option and Spacer from packages/views/components/form-field-set to packages/ui/components
transfer Toast components to packages/ui/components

Design

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@knagurski This PR is still a work in progress and is not ready for review yet

lgtm @iatopilskii


Mixed packages issue

Hi Marten,
Our tooling for bazel is complaining about two package names in the same directory. The impact here is that we are seeing an additional warning message when building.
gazelle: found packages qtls (auth.go) and main (generate_cert.go)

Although the file is tagged "build:ignore" our tooling still reads all go files to see what needs to be provided to the go toolchain.
Could this generate_cert.go file be moved or removed entirely?

This seems to be a problem in your tooling, not in this repo.
The file (generate_cert.go) was copied from the standard library: https://github.com/golang/go/blob/master/src/crypto/tls/generate_cert.go.

Sure, I understand the problem can be solved in the tooling. The tooling should read build tags. However, it would be much faster to solve it here (I hope).
The problem could also be solved by deleting it from this repository.
Is it used at all or serve any value?
Why copy it from that repo instead of using that repo?

The problem could also be solved by deleting it from this repository.
Is it used at all or serve any value?
Why copy it from that repo instead of using that repo?

For the qtls repos, we just copy whatever is in crypto/tls, and then do the QUIC-specific modifications. We have to do the same thing for every Go version (and every time crypto/tls is updated).
I'm surprised your tooling only chokes on the file in Go 1.18, this file also in the Go 1.17 version.

Ah OK, I understand. This may be a greater issue with the tooling in that case. I'll try to find the root cause and solve it there. Thanks!

@prestonvanloon, I'm experiencing the same error with bazel. Were you able to figure out why this is happening specifically with 1.18 and not earlier versions?

@arashpayan I set a gazelle exclusion directive like this
    go_repository(
        name = "com_github_marten_seemann_qtls_go1_18",
        build_directives = [
            "gazelle:exclude generate_cert.go",
        ],
        importpath = "github.com/marten-seemann/qtls-go1-18",
        sum = "h1:qp7p7XXUFL7fpBvSS1sWD+uSqPvzNQK43DH+/qEkj0Y=",
        version = "v0.1.1",
    )

https://github.com/prysmaticlabs/prysm/pull/10423

Thanks @prestonvanloon! The exclusion fixed it.
I think it has to do with the new style build constraints not being parsed or propagated. I'll open up an issue with rules_go next week or so.


Reshape output tensor in Tensorflow lite.

System information

TensorFlow version (you are using): master branch
Are you willing to contribute it (Yes/No): YEs

Describe the feature and the current behavior/state.
I'm currently working on this pull request. I want to resize both the input and output tensor of an interpreter. The current API supports only ResizeInputTensor() for some reason. Any leads?
Will this change the current api? How?
This is an internal API, there won't be any visible change.
Who will benefit with this feature?
Those working with core TFLite C++ API.
Any Other info.

The output tensors will be determined by the input tensor's shape and the model graph structure by programmatically.
Could you share why this feature is needed to understand the context of your problem?

@abattery For image-to-image task, it's desirable to have the output shape being determined by the input image shape.
For ex: If input is input dims: [1, 1, 1, 3] and output dims: [1, 1, 1, 16]. But height and width have dim_signature as -1. So, based on the input (height, width), input dim should be [1, height, width, 3] and [1, height, width, 16]. You can find more information in the PR I've linked.
Could you please guide me on how to resize output tensor? Thanks.

Hi @ymodak ,Could you please look into this feature request .

After invoking with the inputs, you can get the correct output shapes automatically.

Resizing output tensor won't beb

@abattery Thanks a lot, Invoking() worked!


Replication policy for new E3SM data

Argonne's E3SM modeling team will be publishing new E3SM data between now and the start of CMIP7.
This data will definitely be stored and available on Argonne's data node and indexed in Argonne's ESGF-1.5 index.
Q: Do either ORNL or LLNL want to replicate this data? (It's ~75 TB.)
Q: If the answer to the first question is "no," should the metadata appear in LLNL's or ORNL's ESGF-1.5 indices (with links to Argonne, presumably)?

Will these data be from CMIP6 simulations and full CMORized?

(1) E3SM needs to stop publishing to CMIP6.  They should migrate their publishing to CMIP6Plus for their CMORized data.  its not reasonable for us to not end the project so we can migrate it read-only.
(2) LLNL will not be replicating E3SM-native data (unCMORized)

Looks like E3SM will be able to continue to publish to CMIP6 for existing registrations but new registrations would be CMIP6.  the question remains of what they still need to publish for their v2.x registration.  I think this is just DECK and Scenario data.


'numpy/arrayobject.h' file not found

I have installed both piqs and qutip via source compilation in MacOS 10.13.6. I am using Qutip 4.3.1 and piqs 1.2. If I run the following
 from qutip import *
 from qutip.piqs import *
I get an error message:

fatal error: 'numpy/arrayobject.h' file not found
#include "numpy/arrayobject.h"

Could someone please help me fix this?

Hi, this seems to be mostly related to incorrect numpy installation or a
mismatch. Could you remove qutip, update your numpy and try again?
Alternatively, the best way to manage packages would be using anaconda. You
could install Miniconda and reinstall qutip with conda install -c conda-forge qutip. This way all your packages will be kept updated and in
sync. Since numpy as well as qutip rely on some C/C++ bindings, sometimes
installing the incorrect binaries can lead to this type of errors.
On Sun, Jul 22, 2018, 12:12 PM yosefrajwulf<EMAIL_ADDRESS>wrote:

I have installed both piqs and qutip via source compilation in MacOS
10.13.6. I am using Qutip 4.3.1 and piqs 1.2. If I run the following
from qutip import *
from qutip.piqs import *
I get an error message:
fatal error: 'numpy/arrayobject.h' file not found
#include "numpy/arrayobject.h"
Could someone please help me fix this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nathanshammah/piqs/issues/59, or mute the thread
https://github.com/notifications/unsubscribe-auth/AGpUBG4ewh8l4GXF0HUV5Mc3W3yTzqSIks5uI-2tgaJpZM4VZ1-g
.

Reinstalling did not work for me. However,  a workaround that did work (a vile hack one might say) is the following:

cd /usr/local/include
ln -s /usr/local/lib/python2.7/site-packages/numpy/core/include/numpy numpy

Thanks for the help @sahmed95 ! I will close the issue now.

Great. In future, conda might be helpful. Let us know if you face any more
issues.
On Sun, Jul 22, 2018, 2:21 PM yosefrajwulf<EMAIL_ADDRESS>wrote:

Closed #59 https://github.com/nathanshammah/piqs/issues/59.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nathanshammah/piqs/issues/59#event-1746307755, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGpUBM1Cwf1z8o9lnCnpyMAYcUq405yMks5uJAvxgaJpZM4VZ1-g
.

Thank you @sahmed95 and thanks for getting in touch here @yosefrajwulf.


Can this work on IOS (Iphone/iPad)

Can this work on IPad or iPhone?

If you compile it for it, yes.
But considering the costs involved in doing development for iOS, I'm not planning to add support myself.

What cost do you mean?

Yes, cost of my time is probably the largest. But I don't even own any Apple hardware, so that would add up also.
In short, I'm not interested in doing that.

Apple people and IOS users are the ones doing the most photography.


Add WidgetId design doc

Rendered: LINK
Scope: widget identifiers (paths)
Status: implemented; some alternatives and tweaks considered

Done: rename WidgetId → Id: https://github.com/kas-gui/kas/pull/413
Investigated: using split OwnedId / Id (incomplete: no GC strategy for lookup table). It's possible, but likely makes user code more complex due to having two identity types and requiring explicit conversion between them.
Investigated: replaces uses of &Id with Id in theme/draw.rs. Result: negligible (hard to measure) perf. impact; too many instances of .clone().


added artifacs to archive for kie-wb-common

Jenkins retest this

@jomarko this change was done "online" by @Ginxo .
When  https://github.com/kiegroup/kie-wb-common/pull/3405 finishes to build (the normal pull request) the screenshot should be there.


git checkout fails due to some really long filenames on Windows

I decided to take a look at making changes to support D this morning but couldn't even work on the repo on Windows due to insanely long spec filenames in common:
Cloning into 'dependabot-core'...
remote: Enumerating objects: 108774, done.
remote: Counting objects: 100% (1807/1807), done.
remote: Compressing objects: 100% (896/896), done.
remote: Total 108774 (delta 959), reused 1579 (delta 773), pack-reused 106967
Receiving objects: 100% (108774/108774), 80.01 MiB | 3.00 MiB/s, done.
Resolving deltas: 100% (73984/73984), done.
error: unable to create file common/spec/fixtures/vcr_cassettes/Dependabot_MetadataFinders_Base_ChangelogFinder/_changelog_text/with_a_github_repo/with_a_changelog/for_a_git_dependency_with_multiple_sources/when_the_ref_has_changed/1_2_1_1_6_1_1.yml: Filename too long
warning: unable to access 'common/spec/fixtures/vcr_cassettes/Dependabot_MetadataFinders_Base_ReleaseFinder/_releases_text/with_a_github_repo/with_releases/when_the_release_is_present/updating_from_no_previous_release_to_new_release/.gitattributes': Filename too long
error: unable to create file common/spec/fixtures/vcr_cassettes/Dependabot_MetadataFinders_Base_ReleaseFinder/_releases_text/with_a_github_repo/with_releases/when_the_release_is_present/updating_from_no_previous_release_to_new_release/1_2_1_1_1_4_1.yml: Filename too long
fatal: cannot create directory at 'common/spec/fixtures/vcr_cassettes/Dependabot_MetadataFinders_Base_ReleaseFinder/_releases_text/with_a_github_repo/with_releases/when_the_release_is_present/updating_from_uknown_previous_release_to_new_release': Filename too long
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'

Windows can be set to allow long paths by setting LongPathsEnabled in the registry but I'd still go with perhaps shortening those paths a bit.
edit:
Interestingly I went to Computer\HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem to set LongPathsEnabled but it's already set. It turns out Git for Windows cannot go beyond the old 260 char limit by default, see Stackoverflow. So I ended up working around it by doing git config --system core.longpaths true as Administrator.

@SingingBush that's a bummer, those file paths a generated so won't be easy for us to change unfortunately 😞
We're also not accepting support for new ecosystems to dependabot-core at the moment as we're focusing on improving and supporting the ones we have already and want to do a bunch of re-architecting to make it easier to support community contributions to new ecosystems. Our current recommendation is to build the new ecosystem as a separate gem that depends on dependabot-common.
We've got some more notes on this in our contributions guidelines: https://github.com/dependabot/dependabot-core/blob/main/CONTRIBUTING.md#why-have-we-paused-accepting-new-ecosystems

Changing the file paths is not something we're planning on doing for the reasons mentioned ☝. And @Marcono1234 very nicely documented the git settings required to workaround this on Windows in #4198. Closing, as there's nothing more to do here.


How to plot train, test and validation line to evaluate your model whether overfit or underfit

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
TensorFlow installed from (source or binary):
TensorFlow version (or github SHA if from source):

Provide the text output from tflite_convert
# Copy and paste here

Also, please include a link to a GraphDef or the model if possible.
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.
If you think we've misinterpreted a bug, please comment again with a clear explanation, as well as all of the information requested in the issue template. Thanks!


Guide to Integrate with LINBIT's LINSTORE

Is your feature request related to a problem? Please describe.
I would like K3S to cluster storage resources with the current commands.

curl -sfL https://get.k3s.io | K3S_URL=https://myserver:6443 K3S_TOKEN=XXX sh -

Distributed Kubernetes storage is difficult. K3S can exceed the storage of a single system. Streamlined instructions are lacking. Many alternatives are slow and technically complicated.

Situations where a PhD in k8s clusterology is infeasible

The above quote about infeasiblity of k8s clusterology is related to the above goals.
Describe the solution you'd like
Would like a guide to setup K3S with LINBIT's LINSTORE.
Can contribute time on documentation.
Describe alternatives you've considered
K3S with local path provisioner. - Limited to single node. No migration.
K3S with ROOK / CEPH. - Many moving parts. Performance is slower.
K3S with OPENEBS - Performance is slower.
Additional context
This is not entirely a K3S feature request, but I don't know where to put this request.
https://www.linbit.com/drbd-user-guide/users-guide-linstor/
https://vitobotta.com/2020/01/04/linstor-storage-the-kubernetes-way/

No movement, I switched to openebs.

you can still let this issue open even if you moved to another storage solution


IndexError: index 1 is out of bounds for axis 1 with size 1

[x] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/fchollet/keras.git --upgrade --no-deps

[x] If running on TensorFlow, check that you are up-to-date with the latest version. The installation instructions can be found here.

[x] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

Dear all,
The problem arises at the line 220 in the sklearn wrapper.
Here is a minimal example that reproduces the error (I also attached sample data).
The sample data is composed by a matrix (X) of 50 observations and 50 features, and the corresponding target variable (y), composed by 50 observations. The data type of the matrix is floating point, while the target variable is an integer in [0, 2).
Thanks,
Francesco
from keras.models import Sequential
from keras.layers import BatchNormalization, Dense
from keras.wrappers.scikit_learn import KerasClassifier
import numpy as np
import pandas as pd
from sklearn.model_selection import GridSearchCV

def _fit(X, y):

  nn = KerasClassifier(build_fn=_arch, verbose=1, epochs=1)
  clf = GridSearchCV(
    nn,
    param_grid={
      'input_shape': [(X.shape[1],)],
      'dense_nodes': [np.linspace(X.shape[1], 2, nlayers, dtype=int)
        for nlayers in range(3, 4)]},
    scoring='f1_macro',
    n_jobs=1)
  clf.fit(X.values, y.values)

def _arch(input_shape, dense_nodes):

  arch = Sequential()
  arch.add(BatchNormalization(input_shape=input_shape))
  for nodes in dense_nodes[:-1]:
    arch.add(Dense(nodes, activation='relu'))
  arch.add(Dense(dense_nodes[-1], activation='sigmoid'))
  arch.compile(
    optimizer='sgd',
    loss='sparse_categorical_crossentropy',
    metrics=['accuracy'])

  return arch

X = pd.read_table('X_50_50.txt', sep='\t', index_col=0)
y = pd.read_table('y_50.txt', sep='\t', index_col=0)

_fit(X, y)

X_50_50.txt
y_50.txt

Trying to prefix the target variable with 'cls' string (e.g. 'cls1', 'cls0') gives me another error:
ValueError: could not convert string to float: 'cls1'

The problem arises at line 196
y = np.array(y)
if len(y.shape) != 1:
    self.classes_ = np.arange(y.shape[1])
else:
    self.classes_ = np.unique(y)
    y = np.searchsorted(self.classes_, y)
self.n_classes_ = len(self.classes_)
return super(KerasClassifier, self).fit(x, y, **kwargs)

Line 196 is
if len(y.shape) != 1:
    self.classes_ = np.arange(y.shape[1])

However, it doesn't check whether the y array has shape (nsamples, 1), because it assumes that with a one-dimensional array, the y array has shape (nsamples,). Following this, the statement collapses to
self.classes_ = np.arange(1)

I'm working on an update and if it works on a PR.
Thanks,
Francesco


Interaction between services

While developing state service, there was a need for services to interact among themselves. As of now, there is nothing in api which allows this. But it can be done by passing the ServiceRegistry reference at the entity level to the services using the ServiceConfiguration. As of now this works, since the api is not explicit about the interaction, will trying to get service using the service registry passed on to the entities be a problem. Or do we need an explicit boundaries defined about service registry usage.

This is an interesting approach and it should probably be safe since it isn't creating a new consumerID for the service to use another service, as it is using the same ServiceRegistry.  In that sense, this is little different from making the service requests, in the entity level, and passing specific offerings of one service into another (via either its ServiceConfiguration or its public interface).
We probably just need to formally document some of the things that must be kept in mind when approaching it this way (I will write them here in case someone realizes that this list is invalid/incomplete before we find somewhere to put the doc):

services are still going to be loaded in their own class loaders.  This shouldn't be a big concern so long as one service is only using another the same way an entity does (since entities would see the same isolation)
while each call to getService() returns a unique instance, they still share the same backing state (subject to how the backing ServiceProvider implements this).  While an entity must be aware of this when asking for the same service multiple times, a service must also not assume that it has any kind of isolated access to what the service provides
while it is probably still preferable for the entity to carve up the provisions of one service between itself and various service(s) (so that it can impose its own sense of namespacing or isolation), passing the registry through the config is safe so long as the backing ServiceProvider doesn't leak these between different consumerIDs (which arguably would apply to anything externally pulled from one service and passed into another, anyway)
the main concern we need to keep in mind is that the services are expected to act per-consumerID (effectively equivalent to per-ServiceRegistry) and that the entity must realize this when exposing its own ServiceRegistry


PMDK:x64-windows installation failed in windows server 2019

Host Environment

OS: Windows Server 2019
Compiler: revision

To Reproduce
Steps to reproduce the behavior:
`./vcpkg install pmdk:x64-windows
Dependencies Installed:
Visual Studio 2019
Perl
Latest Windows SDK
Failure logs
-C:\Users\Administrator\vcpkg>.\vcpkg install pmdk:x64-windows
The following packages will be built and installed:
pmdk[core]:x64-windows
Starting package 1/1: pmdk:x64-windows
Building package pmdk[core]:x64-windows...
-- Downloading https://github.com/pmem/pmdk/archive/d2f6f5b0032eb5678ec6c5c3dff03509caa4b817.tar.gz...
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:99 (message):
File does not have expected hash:
      File path: [ C:/Users/Administrator/vcpkg/downloads/temp/pmem-pmdk-d2f6f5b0032eb5678ec6c5c3dff03509caa4b817.tar.gz ]
  Expected hash: [ 8ac50f9ea03e140eeb5fcd25ea34591b38cb76cfaa2a8622155d54b90c1cadb9fe046deeaa422163e2cd82a993a9b736523e932d66cb458ff1d2111649587e8a ]
    Actual hash: [ e93b9168eb99c5fb942ff622d6995e71e18055415a327345279cd30db5a65e8b1fc63bea3b3275e3f12935bb93e66082b1cc7c23b8331eef82349ef5f0387468 ]

The file may have been corrupted in transit.  This can be caused by
proxies.  If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY
environment variables to
"https://user:password@your-proxy-ip-address:port/".
Call Stack (most recent call first):
scripts/cmake/vcpkg_download_distfile.cmake:182 (test_hash)
scripts/cmake/vcpkg_from_github.cmake:108 (vcpkg_download_distfile)
ports/pmdk/portfile.cmake:13 (vcpkg_from_github)
scripts/ports.cmake:94 (include)
Error: Building package pmdk:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: pmdk:x64-windows
Vcpkg version: 2019.09.12-nohash

Just an update:
Proxy has been set before using git config --global http.proxy <>

@abhilashuk, thanks for report this issue!
PR https://github.com/microsoft/vcpkg/pull/8586 should address this issue as well. As a workaround, you can open\ports\pmdk\portfile.cmake, and update the SHA512 to e93b9168eb99c5fb942ff622d6995e71e18055415a327345279cd30db5a65e8b1fc63bea3b3275e3f12935bb93e66082b1cc7c23b8331eef82349ef5f0387468. and try to build again, it should not block you.

Can I bypass this download from https://github.com/pmem/pmdk/archive/d2f6f5b0032eb5678ec6c5c3dff03509caa4b817.tar.gz by downloading separately and copy into some location.
$ ./vcpkg install pmdk:x64-windows
The following packages will be built and installed:
pmdk[core]:x64-windows
Starting package 1/1: pmdk:x64-windows
Building package pmdk[core]:x64-windows...
A suitable version of cmake was not found (required v3.14.0). Downloading portable cmake v3.14.0...
Downloading cmake...
https://github.com/Kitware/CMake/releases/download/v3.14.0/cmake-3.14.0-win32-x86.zip -> C:\Users\Administrator\abhilash\vcpkg\downloads\cmake-3.14.0-win32-x86.zip
Extracting cmake...
A suitable version of 7zip was not found (required v18.1.0). Downloading portable 7zip v18.1.0...
Downloading 7zip...
https://www.nuget.org/api/v2/package/7-Zip.CommandLine/18.1.0 -> C:\Users\Administrator\abhilash\vcpkg\downloads\7-zip.commandline.18.1.0.nupkg
Extracting 7zip...
A suitable version of nuget was not found (required v4.6.2). Downloading portable nuget v4.6.2...
Downloading nuget...
https://dist.nuget.org/win-x86-commandline/v4.6.2/nuget.exe -> C:\Users\Administrator\abhilash\vcpkg\downloads\nuget.exe
A suitable version of powershell-core was not found (required v6.2.1). Downloading portable powershell-core v6.2.1...
Downloading powershell-core...
https://github.com/PowerShell/PowerShell/releases/download/v6.2.1/PowerShell-6.2.1-win-x86.zip -> C:\Users\Administrator\abhilash\vcpkg\downloads\PowerShell-6.2.1-win-x86.zip
Extracting powershell-core...
-- Downloading https://github.com/pmem/pmdk/archive/d2f6f5b0032eb5678ec6c5c3dff03509caa4b817.tar.gz...
-- Downloading https://github.com/pmem/pmdk/archive/d2f6f5b0032eb5678ec6c5c3dff03509caa4b817.tar.gz... Failed. Status: 7;"Couldn't connect to server"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:175 (message):
  Failed to download file.
  If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
  variables to "https://user:password@your-proxy-ip-address:port/".
  Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Call Stack (most recent call first):
scripts/cmake/vcpkg_from_github.cmake:108 (vcpkg_download_distfile)
ports/pmdk/portfile.cmake:13 (vcpkg_from_github)
scripts/ports.cmake:94 (include)
Error: Building package pmdk:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: pmdk:x64-windows
Vcpkg version: 2019.09.12-nohash
Additionally, attach any relevant sections from the log files above.

I could do wget and git clone of other repo, so again this might not be related to proxy, any help would be much appreciated.

@abhilashuk, the PR merged, could you get latest VCPKG, and try to build again?

I am still seeing the below issue
C:\Users\Administrator\vcpkg>.\vcpkg install pmdk:x64-windows
The following packages will be built and installed:
pmdk[core]:x64-windows
Starting package 1/1: pmdk:x64-windows
Building package pmdk[core]:x64-windows...
A suitable version of cmake was not found (required v3.14.0). Downloading portable cmake v3.14.0...
Downloading cmake...
https://github.com/Kitware/CMake/releases/download/v3.14.0/cmake-3.14.0-win32-x86.zip -> C:\Users\Administrator\vcpkg\downloads\cmake-3.14.0-win32-x86.zip
Extracting cmake...
A suitable version of 7zip was not found (required v18.1.0). Downloading portable 7zip v18.1.0...
Downloading 7zip...
https://www.nuget.org/api/v2/package/7-Zip.CommandLine/18.1.0 -> C:\Users\Administrator\vcpkg\downloads\7-zip.commandline.18.1.0.nupkg
Extracting 7zip...
A suitable version of nuget was not found (required v4.6.2). Downloading portable nuget v4.6.2...
Downloading nuget...
https://dist.nuget.org/win-x86-commandline/v4.6.2/nuget.exe -> C:\Users\Administrator\vcpkg\downloads\nuget.exe
A suitable version of powershell-core was not found (required v6.2.1). Downloading portable powershell-core v6.2.1...
Downloading powershell-core...
https://github.com/PowerShell/PowerShell/releases/download/v6.2.1/PowerShell-6.2.1-win-x86.zip -> C:\Users\Administrator\vcpkg\downloads\PowerShell-6.2.1-win-x86.zip
Extracting powershell-core...
-- Downloading https://github.com/pmem/pmdk/archive/bc5e309485df61c452d08367e4b13ba9dfed5071.tar.gz...
-- Downloading https://github.com/pmem/pmdk/archive/bc5e309485df61c452d08367e4b13ba9dfed5071.tar.gz... Failed. Status: 7;"Couldn't connect to server"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:175 (message):
  Failed to download file.
  If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
  variables to "https://user:password@your-proxy-ip-address:port/".
  Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Call Stack (most recent call first):
scripts/cmake/vcpkg_from_github.cmake:108 (vcpkg_download_distfile)
ports/pmdk/portfile.cmake:13 (vcpkg_from_github)
scripts/ports.cmake:94 (include)
I have set proxy and proxy seems to be working as I could clone vcpkg and rest of the packages. Still I am not sure why I am seeing the above failure.

@abhilashuk, I can't repro your issue with latest vcpkg, It might related to proxy.
As a workaround, you can follow:

Download it from https://github.com/pmem/pmdk/archive/bc5e309485df61c452d08367e4b13ba9dfed5071.tar.gz manually.
Rename it to pmem-pmdk-bc5e309485df61c452d08367e4b13ba9dfed5071.tar.gz
Put it to .\downloads folder
./vcpkg install pmdk:x64-windows

Excellent, it worked.
Thanks for the workaround.

Great!


Ensure navigation to definitons follows imports and is transparent to decoration

Fixes #1638
It turns out that there are three mechanisms for getting definitions of a symbol from jedi:

goto_definitions: follows all imports and considers the actual value of the target symbol (so returns the wrapped version of a decorated function)
goto_assignments: considers the original assignments of a symbol, meaning that it ignores decoration, but doesn't follow import by default
goto_assignments(follow_imports=True): behaves like goto_assignments, but doesn't consider an import to be an assignment and so follows to the original assignment

It's the latter behaviour that is what I'd find most useful from an IDE.
This pull request:

[x] Has a title summarizes what is changing
[x] Includes a news entry file (remember to thank yourself!)
[x] Has unit tests & code coverage is not adversely affected (within reason)
[x] Works on all actively maintained versions of Python (only tested under Python 2.7, but there's no reason it should be different elsewhere)
[x] Works on Windows 10, macOS, and Linux (only tested on Linux, but there's no reason it shouldn't work elsewhere)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: PeterJCLaw sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Some deabbreviations

Some abbreviations in x509 manual page are hard to either understand or to google.
Checklist

[x] documentation is added or updated

Hmmm, do we need a glossary?

I do not think we need a glossary, but these abbreviations were unclear.

Merged to master.  I took the liberty of removing an end of line space character in the process.


Temperature monitoring

macOS: iStats terminal solution [ ▂▃▅ ]
Ubuntu: Psensors gnome panel solution [ http://wpitchoune.net/psensor/ ]

iStats added via commit 0aa2b70bc25d4e8b43ba680d4ebe0b531d1f38aa


Cant Mock HttpHeaderValueCollection in IHttpRequestHeaders

When unit of work sets accept headers with a call like _httpClient.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json")); the DefaultRequestHeaders.Accept is null and cannot be mocked since HttpHeaderValueCollection<T> is a sealed class which does not inherit from an interface (excluding enumables like ICollection) and does not expose a public constructor.
As soon as I get time I'll try to add some abstractions and put together a PR, but might take a few days.

Had a chance to start looking at it this afternoon but can't finish tonight, I'm working it out as I go and trying to follow the same patters you've been using. It's only half done, but if you start looking into this before I finish theres no point double handling things. This is what I've got so far (for better or worst).
https://github.com/JoeDM09/Thinktecture.Abstractions/commit/86c6f5ed4b2ac91516e28533242775b6b9ce50f1

Pull Request is live: https://github.com/PawelGerr/Thinktecture.Abstractions/pull/3/files

Thank you for the PR, I will review it as soon as I have some free time.
This PR is a breaking change that means I would have to increase the major version to 2.0.0. I'm planing to do that when .NET Standard 2.0 is released but not now. What I can do now is to create a pre-release package -2.0.0-beta1.

@PawelGerr  If it's a breaking change that would go into a new major version, Then should the same be done for any other similar areas?
I'll try to have a look if I get some time, but if you can think of anywhere else that might need a similar change then it's probably worth doing it all at once.

@JoeDM09 I don't think there is a solution without introducing a breaking change.
If there are further enhancements with breaking changes then they should be done all at one. That's why I want to do a pre-release so I have time to collect another PRs.

Merged PR and created 2.0.0-beta1: https://www.nuget.org/packages/Thinktecture.Abstractions/2.0.0-beta1


Verify status of JBS issues in ProblemList_openjdk8-openj9.txt file

We would like to verify whether we still need exclude statements that relate to issues tracked in the JBS (Java Bug System) issues.  What this involves is to look up the JBS issues (the URLs containing https://bugs.openjdk.java.net), see if their Status indicates the issue is resolved.

If the Status is resolved, then we need to check if we can run the test on the platforms it is excluded on and pass.  This will be done by running a Jenkins test job called a Grinder.  If you are assigned to this issue, you will be given access to run Grinder jobs.  If the testcase passes consistently, we can remove the exclude line from the ProblemList file.  Information regarding running a Grinder can be found here: https://github.com/adoptium/aqa-tests/wiki/How-to-Run-a-Grinder-Build-on-Jenkins#common-scenario-rerun-an-openjdk-regression-test-that-was-failing
ProblemList files are typically in the following format:
path/of/test/class/to/exclude URLtoIssueReportingFailure platformsExcludedOn
For example:
gc/metaspace/TestCapacityUntilGCWrapAround.java https://bugs.openjdk.java.net/browse/JDK-8226236 windows-x86
Grinder job will take parameters:
BUILD_LIST=openjdk
TARGET=jdk_custom
CUSTOM_TARGET=gc/metaspace/TestCapacityUntilGCWrapAround.java
PLATFORM=platformThatMapsToTheOnesFromTheExcludeLine
JDK_VERSION=8
JDK_IMPL=openj9

Hi @smlambert , I am from Outreachy. Will be glad to work on this issue. Can I ?

Hi @smlambert, you havn't responded. Can I proceed to create a pull request for the exclusion of line 314 since all the test passed with none failed?

Hi @smlambert, you havn't responded. Can I proceed to create a pull request for the exclusion of line 314 since all the test passed with none failed?


What about a colab so we can test this?

Yes, someone please provide a colab notebook if you were successful in simulating the MusicLM results.


Update the migration docs

This obsoletes #42

@lunny & @bkcsoft Fixed

@Bwko you complete left this part out though...

If you have custom content migrated from gogs/custom/ folder, like templates or localization files, you should manually merge these because these files changed on Gitea.

@tboerger & @bkcsoft Done (I hope :wink:)

LGTM

LGTM


Fail to load models with custom layers

In legacy keras, I can load .h5 files and override some layers with my custom ones. It seems I can not do it in keras 3.
TF_USE_LEGACY_KERAS=1 python test.py is ok, but for keras 3 with python test.py, I get the error: Layer 'optimized_dense' expected 2 variables, but received 0 variables during loading. Expected: ['kernel', 'bias']
I'm using tf 2.16.1 with keras 3.1.1 and tf_keras 2.16.0
import os
import tempfile
if os.environ.get("TF_USE_LEGACY_KERAS", None) in ("true", "True", "1"):
    import tf_keras as keras
else:
    import keras

class OptimizedDense(keras.layers.Dense):
    def __init__(
        self,
        units,
        kernel_initializer="glorot_uniform",
        bias_initializer="zeros",
        kernel_regularizer=None,
        bias_regularizer=None,
        activity_regularizer=None,
        kernel_constraint=None,
        bias_constraint=None,
        lora_rank=None,
        **kwargs,
    ):
        super(OptimizedDense, self).__init__(
            units,
            activation="relu",
            use_bias=True,
            kernel_initializer=kernel_initializer,
            bias_initializer=bias_initializer,
            kernel_regularizer=kernel_regularizer,
            bias_regularizer=bias_regularizer,
            kernel_constraint=kernel_constraint,
            bias_constraint=bias_constraint,
            activity_regularizer=activity_regularizer,
            **kwargs
        )

    def call(self, inputs, training=None):
        return super(OptimizedDense, self).call(inputs)

    def build(self, input_shape):
        super(OptimizedDense, self).build(input_shape)

m = 128
k = 128
units = 128

input_shape = (m, k)

layers = (keras.layers.InputLayer(input_shape), keras.layers.Dense(units))
model = keras.models.Sequential(layers)
model.build((None,)+input_shape)
layers_opt = (keras.layers.InputLayer(input_shape), OptimizedDense(units))
model_opt = keras.models.Sequential(layers_opt)
model_opt.build((None,)+input_shape)

name = None
if os.environ.get("TF_USE_LEGACY_KERAS", None) in ("true", "True", "1"):
    name = ".h5"
else:
    name = ".weights.h5"
_, fname = tempfile.mkstemp(name)
model.save_weights(fname)
model_opt.load_weights(fname)

print((model_opt.weights[0] == model.weights[0]))

@divyashreepathihalli I added the build method in the issue description, still the same error.

The V3 Keras weights saving format does indeed rely on object class names in order to load weights correctly. So here's what you can do:

Rename your custom layer class Dense, the same as the original layer class.
Transfer weights without relying on the .weights.h5 format, for instance by doing model.set_weights(other_model.get_weights()). You can use npz to store the output of get_weights() to disk (it's a list of numpy arrays).
Edit the .weights.h5 file to rename the target "Dense" layer to "OptimizedDense" before loading.


Fix some minor clippy lints

In particular, the len() != 0 => !is_empty() change and the #[allow(dead_code)] prevent clippy (or even just check in the second case) from flagging warnings on the macro generated code which are not terribly helpful.
Removing the extraneous to_string() and into() calls just make clippy clean on the macro crate itself.

oops no bors here


Deploy December 2021 publish

Docs Build status updates of commit f8541e4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sysinternals/downloads/adexplorer.md
:white_check_mark:Succeeded
View

sysinternals/downloads/autoruns.md
:white_check_mark:Succeeded
View

sysinternals/downloads/cacheset.md
:white_check_mark:Succeeded
View

sysinternals/downloads/desktops.md
:white_check_mark:Succeeded
View

sysinternals/downloads/index.md
:white_check_mark:Succeeded
View

sysinternals/downloads/procmon.md
:white_check_mark:Succeeded
View

sysinternals/downloads/sysinternals-suite.md
:white_check_mark:Succeeded
View

sysinternals/downloads/sysmon.md
:white_check_mark:Succeeded
View

sysinternals/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Remove core-js dependency

The core-js dependency collides with a more recent core-js 3 version, if present.
In addition, it looks like the dependency was not needed any more. I can't find any usage in the whole project except in the package file

As a package, we have no control what dependencies a user may or may not install.
The dep is being used here.

I think a library should not include any polyfills. Because you don't know which devices are targeted.

We target the same that NextJs does out of the box, because this is a NextJs plugin.

NextJs has "@babel/runtime-corejs2" as dependency which is not a problem.

@bitworking If you can put forth a PR that removes polyfills but retains IE11 support, it will be merged immediately.

I want to put a PR but the Pre-commit-hook doesn't let me commit since the latest update. I get following errors:
node_modules/i18next-express-middleware/index.d.ts(9,7): error TS2687: All declarations of 'i18n' must have identical modifiers.
node_modules/i18next-express-middleware/index.d.ts(9,7): error TS2717: Subsequent property declarations must have the same type.  Property 'i18n' must be of type 'i18n & { options: Config; }', but here has type 'i18n'.
types.d.ts(65,7): error TS2687: All declarations of 'i18n' must have identical modifiers.
Can it be that you don't run those checks by yourself?

@bitworking If I clone this repository, pull latest master, and do yarn && yarn lint && yarn test, everything passes.
No, I do not commit or push with --no-verify. Moreover, we have CI that runs on each commit/PR.
Please provide more details.

@isaachinman ok thanks. I'll try again. Perhaps I have another TypeScript version locally..


Generate low level client code for 7.12

@Mpdreamz Oops! I had a couple of issues generating originally and committed the one without that fixed type name. I've fixed it again and re-generated.

Will investigate the Linux failure on Jenkins before merging.


Add Roadmap

a roadmap resp. pending features would be great. Some things that do come into my mind:

Reloading
Consul, etc.
Java 8 defines a configuration API. Would be great to have compatibility with that.
default methods
cascading like in netflix archaius (zone, data center, location specific configuration)

and to some degree it would be good to compare this feature set to other configurations out there (to be sure this one is the one worthwhile to use...)

@remmeier thanks for this. I agree with you, both a roadmap and a comparison matrix are in order.
Regarding your list of items:

Reloading

I've spent some time in the past thinking about an API for this but then I had to lower the priority. But I agree with you that it should be part of yacl4j. I'll open a task for this to make sure it gets tracked.

Consul, etc.

I guess all extensions will be added on a per-request basis. I've noticed that the Consul one is pretty popular and I don't think it will be hard to implement.

Java 8 defines a configuration API. Would be great to have compatibility with that.

Sounds interesting! I'm not aware of this new API, could you please provide a link?

default methods

Are you referring to Java 8 default methods for providing default values of configuration defined through interfaces? If that's the case, see this Jackson issue for an update on the subject.

cascading like in netflix archaius (zone, data center, location specific configuration)

As with the reloading API, also this one is on my "mental" roadmap by quite some time. I didn't look specifically at Archaius before but I did look at Spring Boot's profiles and Cfg4j's environments as good examples. But I'll open a task for this too.

Regarding JEE8, seems that I was mistaken. It was planned but did not make it. It is however in the competing/complementing/... MicroProfile standard. e.g. https://www.ibm.com/support/knowledgecenter/en/was_beta_liberty/com.ibm.websphere.wlp.nd.multiplatform.doc/ae/cwlp_microprofile_overview.html.
resp. https://github.com/eclipse/microprofile-config
I do have an implementation for cascading for cfg4j, that could be ported if it is a match. Archius seems quite a bit more advanced compared to Spring Boot. Altough the implementation is a bit of a mess with that v1/v2 version. cfg4j is fairly broken in this area.
Consul could be ported from cfg4j as it makes use of the same license.

resp. https://github.com/eclipse/microprofile-config

It looks interesting, even though there are a couple of API design choices I don't particularly agree with. Ultimately, I think an extension supporting this API is feasible.

I do have an implementation for cascading for cfg4j, that could be ported if it is a match.

Is it public? I could have a look to have a better idea.

Consul could be ported from cfg4j as it makes use of the same license.

I agree, it seems the easiest way to go.

As an extension would be great. I guess would also give a bit of traction by support a standard (if one considers micro-profile being a standard).
No, not public so far. But it looks like:
ConfigFilesProvider filePaths = () -> cascadingStrategy.generate(FILE_PREFIX, environment).stream()
	.map(it -> it + FILE_SUFFIX).map(Paths::get).collect(Collectors.toList());
SystemPropertiesConfigurationSource systemPropertiesSource = new SystemPropertiesConfigurationSource();
EnvironmentVariablesConfigurationSource envVariablesSource = new EnvironmentVariablesConfigurationSource();
FilesConfigurationSource filesSource = new FilesConfigurationSource(filePaths);
ClasspathConfigurationSource classPathSource = new ClasspathConfigurationSource(filePaths);

and
/**
 * Strategy for determining a set of cascading resource names.  The strategy will resolve
 * a single resource name into an ordered list of alternative names.
 *
 * For example, a strategy may specify that additional configuration files may be loaded
 * based on environment and datacenter.  The strategy will return the list,
 *
 * basename
 * basename-${environment}
 * basename-${datacenter}
 * basename-$[environment}-${datacenter}
 */
@FunctionalInterface
public interface CascadeStrategy {

	/**
	 * Resolve a resource name to multiple alternative names.
	 *
	 * @param baseName base name that gets suffixed
	 * @param environment to cascade.
	 *
	 * @return List of all names including the original name
	 */
	List<String> generate(String baseName, Environment environment);
}

Setup can obviously be simplified, mainly limited by cfg4j.

An environment may include zone, region, name, component and allow config file with a permutation thereof.


Module not found error after upgrading plugin from 3.0.2 to 4.0.1

After bumping the plugin version from 3.0.2 to 4.0.1, when I run semantic release, the following error is produced. I also tried setting the new envDir parameter to false, since I am creating my own virtual env.
Here is my releaserc file
{   "plugins": [   [       "semantic-release-pypi",       {           "envDir": false       }   ],     "@semantic-release/commit-analyzer",     "@semantic-release/release-notes-generator",     "@semantic-release/gitlab" ],   "branches": [     "pypi-package"   ] }
[8:47:46 PM] [semantic-release] › ℹ  Running semantic-release version 24.1.2 [8:47:46 PM] [semantic-release] › ✘  An error occurred while running semantic-release: Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/usr/local/lib/node_modules/semantic-release-pypi/dist/prepare' imported from /usr/local/lib/node_modules/semantic-release-pypi/dist/index.js     at finalizeResolution (node:internal/modules/esm/resolve:265:11)     at moduleResolve (node:internal/modules/esm/resolve:933:10)     at defaultResolve (node:internal/modules/esm/resolve:1169:11)     at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:540:12)     at ModuleLoader.resolve (node:internal/modules/esm/loader:509:25)     at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:239:38)     at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:96:40)     at link (node:internal/modules/esm/module_job:95:36) {   code: 'ERR_MODULE_NOT_FOUND',   url: 'file:///usr/local/lib/node_modules/semantic-release-pypi/dist/prepare' } Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/usr/local/lib/node_modules/semantic-release-pypi/dist/prepare' imported from /usr/local/lib/node_modules/semantic-release-pypi/dist/index.js     at finalizeResolution (node:internal/modules/esm/resolve:265:11)     at moduleResolve (node:internal/modules/esm/resolve:933:10)     at defaultResolve (node:internal/modules/esm/resolve:1169:11)     at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:540:12)     at ModuleLoader.resolve (node:internal/modules/esm/loader:509:25)     at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:239:38)     at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:96:40)     at link (node:internal/modules/esm/module_job:95:36) {   code: 'ERR_MODULE_NOT_FOUND',   url: 'file:///usr/local/lib/node_modules/semantic-release-pypi/dist/prepare' }

Hi, thank you for bringing this to my attention.
Should be fixed by c37e49f6ccf608a638fb5bd883bac161b2bde753


Remove MeasurementGate.is_measurement and add replacements

If we add gate to Operation, every Operation will autocomplete with a gate which often isn't anything.  Making it "optional" just annoys people who are looking for the gate for an Operation.  Maybe I'm just too java-y, but having an optional interface feels very much like a violation of the interface segregation principle.  op_has_gate_type isn't too discoverable, but the method on GateOperation is, and we could use it to call out that method.  Anyway must people will just convert to GateOperation and then proceed, this is mostly an unimportant helper, not something should be central to an interface change.

The utility method cirq.op_gate_of_type is sufficient for me. Takes a type, returns None if the operation isn't a gate operation or the gate is not an instance of that type.

I can't tell what it should return from that name if it is an GateOperation with a GateType.

PTAL


match MasterSlaveReplication

Fix return type.

Coverage: 87.452%. Remained the same when pulling c0d55b869e935a1f9d34a60020aacc903cd69431 on fix-return-type into 8ef75ba6b22442561481f8f6d83b85279f99f118 on v2.x.


Unable to set initial Value

Hi, I have to manage a classic list of countries.
The country is an information that I have to manage in a Customer Profile component...
The code I have implemented is this:
In typescript for fill the options:
this.dataServiceCountry = this.completerService.local(this.listCountry, 'nameLong', 'nameLong');
In typescript to get the id of the country:
  onCountrySelected(item: CompleterItem) {
    this.customer.idCountry = item ? item.originalObject.idCountry : null;
  }

Then in component:
<ng2-completer id="idCountry" inputClass="form-control input-sm" [ngModelOptions]="{standalone: true}" textNoResults="Not Found"
                    [datasource]="dataServiceCountry" [minSearchLength]="0" (selected)="onCountrySelected($event)"></ng2-completer>

I can properly get the value and use it to save the record in database.
Now I want that when I load the customer profile, the ng2-completer is set to the properly value...
How to do it ?
Thanks to support

Hi, were you able to figure this out? I am having same problem, not sure how to populate the value for existing value coming from DB.


DRAFT: Linux platform to extend process objects on Linux

Add a Linux extension to demonstrate what the Linux platform would contain, once platform support is added.
Makes the following changes:

Adds the container object, which provides details about a container
Updates the default process object to include

container and namespace_pid fields, which are necessary for when processes are run in a container
Linux process user/group fields (auid, euid, egid, gid)

Changes existing group object to require name or uid, like the user object does

Splitting into multiple PRs


Make initial rendering synchronous, fixes #41

This PR makes processing of initial data synchronous, so for example ko.applyBindings will be synchronous too, and therefore the bound nodes will be ready after calling it.
Fixes #41

That looks to be it.
The case where this is a downside is when there's a large bit of data to be initialized and the DOM has reflows queued.  I think that case is marginal, so I'd be ok with this PR.  If this becomes an issue we can add an option "delayInitialFrame" or some such.
To avoid regressions in future patches, do you have time to add one or two tests:

ensure that it's synchronous on the initial;
it's asynchronous otherwise (if this test isn't already there -- cannot recall offhand).

I was also thinking about really large data sets, but that case could be addressed by my other branch which implements partitioned processing.
When possibly merging this two, I could image that the initial partition would be synchronous, and the others asynchronous. It would be a quite special case and of course after applyBindings one would not have a ready DOM again, but I think this all is an acceptable limitation (if we call it limitation at all).
By the way, if you have time, could you have a look at that mentioned branch too?

@brianmhunt Please check out the changes

Awesome.  Looks good to me.  Are you ok merging, adding to the change log, and bumping the version?  I can push update to npm.

I can merge I guess. I have still quite little git experience.
However, I would wait a bit with a new release, as this is not a huge issue I think, and there are some more things I'm working on, like the parentNode issue or the partitioning thing.

Fair enough.  Thanks & keep me posted! :)


Colors in logs

Fixes #123
This adds basic virtual terminal font attribute parsing logic to the FormattedLogMessage component.
See in Storybook:

And in the app:

This is amazing! Does it already work with programs (e.g. the npm case we discussed yesterday) or do we still need to convince them to send the logs with color because we aren't a TTY?

do we still need to convince them to send the logs with color because we aren't a TTY?

Depends on the program, but often - yes - programs won't show colors if not in a TTY.

merging as there is test coverage, so feeling confident in it - but @BenElgar please do review when you get some time


nf-raredisease crashing on filter_vep

Description of the bug
--vep_filters is not marked as required, but the absence of this file will crash the FILTER_VEP_SNV step which runs by default.
Command used and terminal output
Standard execution, without --vep_filters.

Relevant files
No response
System information
No response

Thanks for reporting this, @lfearnley. Will fix this bug soon 👍🏻

Fixed in #416


cpptools hogs the CPU on Mac

cpptools (version 0.27.1) won't stop running 25 threads at 100% CPU time on Mac OS. It keeps going forever.

About Code:
Version: 1.44.2
Commit: ff915844119ce9485abfe8aa9076ec76b5300ddd
Date: 2020-04-16T17:07:18.473Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.4.0

/extC++


PLEASE how do I use this?

what is the project[myproject]? How do I use something like the children tag to create a folder?
Example: tag is content/
Main folder is Content
I want to move to a folder inside Content based on what is after the / in the tag and make the first letter capitalized

How do I add children tags in general? In the normal plugin I used #tag/* for getting all children tags, but it doesn't work here

use auto move plugin bud


Error building flash attention

I have cuda 11.5 on an ubuntu machine. When I do MAX_JOBS=8 pip install flash-attn --no-build-isolation, I get error
RuntimeError: Error compiling objects for extension
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for flash-attn
  Running setup.py clean for flash-attn
Failed to build flash-attn
ERROR: Could not build wheels for flash-attn, which is required to install pyproject.toml-based projects

I made sure g++ is installed

How much RAM do you have? I tested MAX_JOBS=8 with 85 GB of RAM (A100 40GB variant).

I went through this issue and figured that g++ and CUDA got dependence. If your g++ is not compatible, flash attention might fail. For CUDA 11.5 I think max supported GCC (equivalent to g++ imo) for 11.5 CUDA is 11. You might find this useful.

Built cuda toolkit 11.8 inside the conda environment. That at least solves the flash attention installation problem
conda install -c "nvidia/label/cuda-11.8.0" cuda-toolkit


Hover effect added isuue #222

I added a cool hover effect on the "Wildguard" on the top left of the navbar which looks appropriate to the websites theme

This is after hover effect
https://github.com/user-attachments/assets/4c174364-c255-4049-a908-28741541371c

Is there something not good as the code is not merged yet? feel free to tell me so that I can work on it

Is there any issue in the code as it has not been merged yet? please feel free to tell me so that I can work on it

Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review. And also mention issue number.
Thank you!


[Deprecated] keyboardShouldPersistTaps

keyboardShouldPersistTaps={true} is deprecated. It needs to used as keyboardShouldPersistTaps="always".
A warning appears in React 15.5.3

Thx @beaudry. Merged your PR