Question about connecting backend to ONTAP Simulator

Describe the solution you'd like
I want to know the port number list to connect ONTAP Simulator,
because I am running ONTAP Simulator on VM. (VMware Player vmnet8 (NAT))
Describe alternatives you've considered
How to connect Trident Backend to Storage(ontap  etc)?
Or Other mode (not vmnet8) should be use?
(Currently K8s cluster and ONTAP Simulator is running on physically separated machine)
Additional context

Is the port number of dataLIF and managementLIF documented?

Connecting to the ONTAP simulator is just the same as connecting to ONTAP.  You connect to the IP address of either a cluster management LIF or a SVM management LIF over HTTPS, port 443.

@sakaia Trident communicates over HTTPS by default (443). Your ONTAP login being used in your Trident backend definition must support making ontapi calls. In your setup, you must make sure you are able to reach the managementLIF and dataLIF from your k8s cluster node.

@sakaia,
Can this issue be closed?

Thanks for your information it is helpful
For my case, ONTAP simulator running on other physical host.  Is there any way to connect ONTAP Simulator  from other physical host? only one https port forwarding is minimum requirement?

Thanks, my primary issue is solved (I run the simulator on the same physical machine). I close this issue.

Thanks, my primary issue is solved (I run the simulator on the same physical machine). I close this issue.


Istio fails resolving wild-card IngressGateway with SSL Termination

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
I have an issue equal to #28849. When not stating * as host, I get an SSL error and connection does not work. If I add an *, traffic works fine.
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: application-gw
  namespace: istio-system
spec:
  selector:
    istio: ingressgateway
  servers:
    - hosts:
        - '*.example.de'
        - '*.example2.de'
      port:
        number: 80
        name: http
        protocol: HTTP
      tls:
        httpsRedirect: true
    - hosts:
        - '*.example.de'
        - '*.example2.de'
        - '*'                                                               << Mandatory setting for being working
      port:
        number: 15002
        name: https-applications
        protocol: HTTPS
      tls:
        mode: SIMPLE
        credentialName: istio-ingressgateway-certs
    - hosts:
        - '*.tls.example.de'
        - '*.tls.example2.de'
      port:
        number: 10443
        name: tls-passthrough
        protocol: HTTPS
      tls:
        mode: PASSTHROUGH

# Please edit the object below. Lines beginning with a '#' will be ignored,
# and an empty file will abort the edit. If an error occurs while saving this file will be
# reopened with the relevant failures.
#
apiVersion: v1
kind: Service
metadata:
  annotations:
  creationTimestamp: "2020-12-23T14:33:08Z"
  labels:
    app: istio-ingressgateway
    install.operator.istio.io/owning-resource: istio-controlplane
    install.operator.istio.io/owning-resource-namespace: istio-system
    istio: ingressgateway
    istio.io/rev: default
    operator.istio.io/component: IngressGateways
    operator.istio.io/managed: Reconcile
    operator.istio.io/version: 1.7.5
    release: istio
  name: istio-ingressgateway
  namespace: istio-system
spec:
  clusterIP: <IP_ADDRESS>
  externalTrafficPolicy: Cluster
  ports:
  - name: status-port
    nodePort: 32656
    port: 15021
    protocol: TCP
    targetPort: 15021
  - name: http2
    nodePort: 32215
    port: 80
    protocol: TCP
    targetPort: 8080
  - name: https
    nodePort: 31398
    port: 443
    protocol: TCP
    targetPort: 8443
  - name: tcp-istiod
    nodePort: 30917
    port: 15012
    protocol: TCP
    targetPort: 15012
  - name: tls
    nodePort: 31523
    port: 15443
    protocol: TCP
    targetPort: 15443
  - name: https-applications                                          <<< Here for termination
    nodePort: 30000
    port: 15002
    protocol: TCP
    targetPort: 15002
  - name: tls-passthrough                                            <<< Here for passthroug
     nodePort: 10443
     port: 10443
     targetPort: 8443
     protocol: TCP
  selector:
    app: istio-ingressgateway
    istio: ingressgateway
  sessionAffinity: None
  type: LoadBalancer

SSL is via cert-manager, which sets certificate for wildcard:
apiVersion: cert-manager.io/v1
kind: ClusterIssuer
metadata:
  name: letsencrypt-prod
spec:
  acme:
    email: ****
    server: 'https://acme-v02.api.letsencrypt.org/directory'
    privateKeySecretRef:
      name: ****
    solvers:
      - dns01:
          cloudflare:
            apiKeySecretRef:
              key: api-key
              name: ***
            email: ****
        selector:
          dnsNames:
            - example.de
            - '*.example.de'

The Service is addressed via a VirtualService:
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: app-vs
  namespace: app
spec:
  hosts:
  - app.example.de
  gateways:
  - istio-system/application-gw
  http:
  - match:
    - uri:
        prefix: "/"
    route:
    - destination:
        port:
          number: 8080
        host: app-svc.app.svc.cluster.local

Version
./istioctl version
client version: 1.17.5
control plane version: 1.17.5
data plane version: 1.17.1 (64 proxies), 1.17.5 (1 proxies)

./istioctl version --short
client version: 1.17.5
control plane version: 1.17.5
data plane version: 1.17.1 (64 proxies), 1.17.5 (1 proxies)

Additional Information
When upgrading from Istio 1.17.5 to Istio 1.18.0/1/2 the same SSL error occurs, even when setting '*' as host.
Please note that I replaced the domain with example.de and example2.de and removed mail-addresses etc.
Connection is:
Browser > Nginx Proxy_Pass > K8s Nodeport > Ingressgateway > Gateway > K8s Workload
NGinx Logs
When * is configured as host:
<IP_ADDRESS> - - [23/Aug/2023:09:16:13 +0000] "GET /K8s/APP-Istio/blob/master/iac/application-gateway.yaml HTTP/2.0" 502 552 "https://app.example.de/K8s/APP-Istio/tree/master/iac" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/116.0.1938.54"

When * is removed as host (only *.example.de)
2023/08/23 09:16:13 [error] 44#44: *32062 peer closed connection in SSL handshake (104: Connection reset by peer) while SSL handshaking to upstream, client: <IP_ADDRESS>, server: example.de, request: "GET /favicon.ico HTTP/2.0", upstream: "https://<node>:<port>/favicon.ico", host: "app.example.de", referrer: "https://app.example.de/K8s/APP-Istio/blob/master/iac/application-gateway.yaml"
<IP_ADDRESS> - - [23/Aug/2023:09:16:13 +0000] "GET /favicon.ico HTTP/2.0" 502 552 "https://app.example.de/K8s/APP-Istio/blob/master/iac/application-gateway.yaml" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/116.0.1938.54"

Affected product area

[ ] Ambient
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

Thanks for submitting this bug; which port are you using to access the gateway?

Not sure about nginx or your config but this is almost always from https://istio.io/latest/docs/ops/common-problems/network-issues/#configuring-sni-routing-when-not-sending-sni

Thanks for submitting this bug; which port are you using to access the gateway?

Hi @keithmattix,
Ports are (see additional info):

Public Internet Browser to myFritz-DYNDNS:443
myFritz:443 to <IP_ADDRESS>**:443** (Nginx Proxy_Pass)
192.168.64**:443** to <IP_ADDRESS>**:30000** (K8s Nodeport of istio-ingressgateway)
<IP_ADDRESS>**:3000** to Istio Gateway:15002 (application-gw)
Istio VirtualService to app-svc.app.svc.cluster.local:8080
app-svc.app.svc.cluster.local:8080 to pod/app:8080

Ingressgateway > Gateway > Virtual Service
<IP_ADDRESS>:30000 to 15002 > 15002

Not sure about nginx or your config but this is almost always from https://istio.io/latest/docs/ops/common-problems/network-issues/#configuring-sni-routing-when-not-sending-sni

Hi @howardjohn,
therefore, I could forward SNI via nginx. As it is my central gateway, I need some time for testing it out.
Is there a different way for distinguishing between TLS-offload and TLS-passthrough other than stating Gateways spec.servers.hosts? See application-gw in my initial post.
I noticed more and more images do not support HTTP, but HTTPS, only. HTTPS requires TLS-passthrough as those images HTTPS-services notice HTTP over their HTTPS-Endpoint and cancelles the connection (which seems to be very valid to me). That's where I am coming from to this config issue.


warn if TV weight is large

This PR addresses #80.

We need to merge #82 first.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@624fd28). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage        ?   95.56%
=======================================
  Files           ?       15
  Lines           ?      925
  Branches        ?        0
=======================================
  Hits            ?      884
  Misses          ?       41
  Partials        ?        0

Flag
Coverage Δ

unittests
95.56% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cannot access "cases" and "mnt" folder in Windows

Hi,
First time using SIFT. I tried to access the shared folder "cases" and "mnt" in Win7. I can see the folder in Windows Explorer, upon clicking on it, it said "\siftworkstation\cases is not accessible", Any advice?

Found out fail to to initiate "SMB/CIFE File and Active Directory Server". Restart the smb service solved the issue


Cannot view/delete item if its _id is not an ObjectId

Right now view/delete require the _id to contain a full ObjectId.  It would be nice to provide support for scenarios that do not use an ObjectId, such as when using connect-mongo for sessions in a project.  connect-mongo uses a 24-digit string, but not a full ObjectId.

If you have an auto-incremented field error occurs because the id is a string
Find in /app.js:
 if (id.length == 24) {
    //Convert id string to mongodb object ID
    try {
      id = new mongodb.ObjectID.createFromHexString(id);
    } catch (err) {
    }
  }

Add after: else condition
else{
    id = /^[1-9]+[0-9]*$/.test(id) ? +id : id
  }

https://github.com/andzdroid/mongo-express/commit/a35c26ab8852344dfc15b2dc5db5924259ddd861


replace deprecated FunctionDefine in chat_test.go

Hello,
I have made modifications to chat_test.go as it was using deprecated FunctionDefine.

@ryomak Thanks for your contribution to the tests!


Create Marathon 1.4.0-RC2

Cherry pick D277
Cherry pick D195
Cherry pick D281

Cherry pick D276

Cherry pick D254

Cherry pick D265

cherry-pick https://phabricator.mesosphere.com/D288

https://phabricator.mesosphere.com/D289

https://phabricator.mesosphere.com/D296

#4808 : https://phabricator.mesosphere.com/D297

https://phabricator.mesosphere.com/D195

https://phabricator.mesosphere.com/D307
https://phabricator.mesosphere.com/D306

https://phabricator.mesosphere.com/D304 (Unreachable Strategy from Tim)

https://phabricator.mesosphere.com/D302 (leader properly aborts on abdication)

This list supersedes the various entries from above
D273 - Mute ResidentTaskIntegrationTest.
D280 - Fix test failures in MigrationTest.
D279 - Log plan id instead of plan.
D276 - Fix issues with Entrypoint/Cmd in Docker images.
D263 - clarify relationship between Condition and MesosTaskState
D286 - Fixes 4784 - Differ between AppNotFoundException and PodNotFoundException
D288 - Fixes a bug I found while testing default_network_name
D290 - Allow Marathon devs to annotate API fields/types as deprecated.
D289 - Fixes 4790 - POD instances should not be killable via /v2/tasks
D277 - MarathonSchedulerActor now respects launch queue tasks when scaling app
1dfd99e355dc894e5dc4dde30bc6714e160381ec - added version 1.3 information
D281 - When Launching lots of tasks Journald is pegged.
D293 - Mute unstable tests - according to jenkins loop test.
D292 - Protect against garbage mesos versions
D295 - Mark ResidentTaskInterationTest.persistent volume will be re-attached and keep state as unstable
D296 - Rename unreachable strategy parameters to avoid API stutter.
D297 - fixes #4808, relocate pod unreachbleStrategy to PodSchedulingPolicy type
D195 - Rework DeploymentManager logic
D297 - changelog for Marathon 1.4.0
D294 - Move InstanceUpdateOpResolver to own file
efb38b944b33ea36f18966fdcc1b2f5495db9d76 - Parse JSON event only once before broadcast (#4771)
D300 - Turn off debug for jetty
D299 - use patienceConfig for ZK timeouts
D301 - Increase default expunge timeout tasks
D304 - add Unreachablestrategy to AppUpdate and apply
cc4cf6661cb17b17d1ffa44208edbde288524a55 - Ss/pods docs
0cc19fc47de59614e0fcd1e7be95d2e8a1d325b7 - pods typo
e354da0b258ff2cd21c53fab55d6d0c8b2e022b6 - Change host port type to ephemeral port number (#4820)
a0d2b9f53a8c61d1fd7185a76ce85afcd985dc72 - Properly mark health check props as optional
D313 - Fix incorrect conversion from TaskStatus.timestamp to Timestamp
D308 - Removed unreachableInstances from QueuedInstanceInfo and QueuedInstanceInfoWithStatistics
D314 - Remove additional condition from InstanceChangedEventsGenerator.events
D309 - Handle OfferMatching timeouts as well as some performance improvements
D315 - Moved InstanceUpdateOpResolver to correct package

Known issue (behavior was broken in 1.3.x, also #4137

Known issues draft here: https://gist.github.com/timcharper/1c6c2010b3feef3e3bcbef1f41e9bdfa

https://phabricator.mesosphere.com/D317

I tweaked the consolidated list that MV posted earlier today.
NO ONE ELSE SHOULD UPDATE IT, THANKS!


PesterGroupResource

Summary of the new feature / enhancement
For audit scenarios, enable execution of Pester tests.  A property of this resource would provide a path to the tests and recursively all *.test.ps1 would get executed.  Need to consider what the output object looks like so that not only is it easy to tell if all the tests pass, but which individual tests failed with failure information.
Proposed technical implementation details (optional)
This might be a test only resource which currently isn't supported, but we can add a new property in the resource manifest or have this resource like the AssertionGroup and always execute "test" even if called by get and set.

I think, if we standardize on some munged representation of the Pester.Test object as the resource surface, we could use the Pester configuration to run the tests in discovery mode for get and actually invoke the tests in set:
$PesterConfig = New-PesterConfiguration -Hashtable @{
    Run = @{
        TestExtension = '.dsc.tests.ps1'
        PassThru      = $true
        SkipRun       = $true
    }
}

$GetSuite = Invoke-Pester -Configuration $PesterConfig

Starting discovery in 1 files.
Discovery found 2 tests in 55ms.

Test run was skipped.
Tests completed in 54ms
Tests Passed: 0, Failed: 0, Skipped: 0 NotRun: 2

$GetSuite.Tests[0]

Name              : automatic_update_is_enabled
Path              : {tstoy, Config, Machine, automatic_update_is_enabled}
Data              :
ExpandedName      : automatic_update_is_enabled
ExpandedPath      : tstoy.Config.Machine.automatic_update_is_enabled
Result            : NotRun
ErrorRecord       : {}
StandardOutput    :
Duration          : 00:00:00
ItemType          : Test
Id                :
ScriptBlock       :
                                    $Config.Updates.Automatic | Should -BeTrue

Tag               :
Focus             : False
Skip              : False
Block             : [ ] Machine
First             : True
Last              : False
Include           : False
Exclude           : False
Explicit          : False
ShouldRun         : True
StartLine         : 7
Executed          : False
ExecutedAt        :
Passed            : False
Skipped           : False
UserDuration      : 00:00:00
FrameworkDuration : 00:00:00
PluginData        :
FrameworkData     :

The trick is going to be figuring out what makes sense to return as the representation for a test - Probably some munged object including ExpandedPath, Result, ErrorRecord, Duration, Data, ScriptBlock, StartLine, and Tag?
Then Get could show you the tests that will run and Test shows you the result of running them. I think for the best UX, users should only control where/how Pester runs with the top-level resource (in iteration one, no support for filtering tests or providing override data). The resource itself generates the array of dynamic resource representations to return for get and test.
I think we can get away with that, as long as we have a way for dsc to understand dynamic resource declarations for provider/group resources, or we make the Pester resource fully map to the normative output for get and test. If there was a way for a resource provider to define dynamic resources as part of the configuration processing step before an operation, that would be ideal.
So that would look something like defining this configuration:
# Authored example.dsc.config.yaml before processing
$schema: https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/2023/10/config/document.json
resources:
- name: Pester Validation
  type: DSC/PesterSuite
  properties:
    testsFolderPath: /data/tests

Becoming this data model after the dynamic resource hook / config processing, before any further operations:
# Processed config
$schema: https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/2023/10/config/document.json
resources:
- name: Pester Validation
  type: DSC.Pester/Suite
  properties:
    testsFolderPath: /data/tests
    # Representing the desired state
    resources:
      - type: DSC.Pester/Test
        name: tstoy.config.machine.automatic_update_is_enabled
        properties:
          # Technically, nearly all of these properties should be read-only from a schema
          # perspective - the only ones the resource should actually check are the errorRecord
          # and result. I'm not sure whether/how the provider could cache these during config
          # processing, but that's a future-iteration problem.
          filePath:    /data/tests/tstoy.dsc.tests.ps1
          startLine:   7
          scriptBlock: |
              $Config.Updates.Automatic | Should -BeTrue
          errorRecord: null
          result:      Passed
      - type: DSC.Pester/Test
        name: tstoy.config.machine.checks_updates_daily
        properties:
          filePath:    /data/tests/tstoy.dsc.tests.ps1
          startLine:   10
          scriptBlock: |
              $Config.Updates.CheckFrequency | Should -Be 1
          errorRecord: null
          result:      Passed

The Dsc.Pester/Suite provider should be able to very quickly return results for get, since it's just passing the dynamically created resource instances back to DSC.
For test, it would invoke the entire suite up front (or each file separately, whatever, there's a lot of options) and then populate the individual resources to return them.
Example output for `test`
$schema: https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/2023/10/config/document.json
resources:
- name: Pester Validation
  type: DSC.Pester/Suite
  properties:
    testsFolderPath: /data/tests
    # Representing the desired state
    resources:
      - type: DSC.Pester/Test
        name: tstoy.config.machine.automatic_update_is_enabled
        desiredState:
          filePath:    /data/tests/tstoy.dsc.tests.ps1
          startLine:   7
          scriptBlock: |
              $Config.Updates.Automatic | Should -BeTrue
          errorRecord: null
          result:      Passed
        actualState:
          filePath:    /data/tests/tstoy.dsc.tests.ps1
          startLine:   7
          scriptBlock: |
              $Config.Updates.Automatic | Should -BeTrue
          errorRecord: Expected $true, but got $false.
          result:      Failed
        inDesiredState: false
        differingProperties:
          - errorRecord
          - result
      - type: DSC.Pester/Test
        name: tstoy.config.machine.checks_updates_daily
        desiredState:
          filePath:    /data/tests/tstoy.dsc.tests.ps1
          startLine:   10
          scriptBlock: |
              $Config.Updates.CheckFrequency | Should -Be 1
          errorRecord: null
          result:      Passed
        actualState:
          filePath:    /data/tests/tstoy.dsc.tests.ps1
          startLine:   10
          scriptBlock: |
              $Config.Updates.CheckFrequency | Should -Be 1
          errorRecord: null
          result:      Passed
        inDesiredState: true
        differingProperties: []

If we can't dynamically define the resources (or as a first iteration), we could instead have users define a configuration document like:
# Authored example.dsc.config.yaml without pre-processing implemented
$schema: https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/2023/10/config/document.json
resources:
- name: Pester Validation
  type: DSC.Pester/Suite
  properties:
    testsFolderPath: /data/tests
    # Representing the desired state
    resources:
      - type: DSC.Pester/Test
        name: tstoy.config.machine.automatic_update_is_enabled
        properties:
          filePath:    /data/tests/tstoy.dsc.tests.ps1
      - type: DSC.Pester/Test
        name: tstoy.config.machine.checks_updates_daily
        properties:
          filePath:    /data/tests/tstoy.dsc.tests.ps1

On dynamic resources from discovery
I think that one way to do this would be to mark a provider as supporting dynamic resource definitions in the manifest. This could actually be convenient for author providers of this kind, like inspec tests, or terraform files, etc. From an implementation perspective, DSC could always call these providers to dynamically populate their resources if that property isn't defined, and otherwise use the provider like any other if resources is explicitly defined.
$schema: https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/2023/10/config/document.json
resources:
- name: Pester Validation with dynamic resources
  type: DSC.Pester/Suite
  properties:
    testsFolderPath: /data/tests
- name: Pester Validation with specified resources
  type: DSC.Pester/Suite
  properties:
    testsFolderPath: /data/website/tests
    resources:
      - type: DSC.Pester/Test
        name: frontend.home.serves_200
        properties:
          filePath: /data/website/tests/frontend.dsc.tests.ps1

Keep in mind that we want to define a pattern here that could apply to other similar sources like Chef InSpec, etc... which also means that we can have a specific property in the resource manifest to identify these class of providers if DSC needs to handle them slightly differently (output at least).


Remove old sample recipes

Sample recipes were moved over to the Snowfakery-Recipe-Templates repository created (over a year ago) for this purpose
Critical Changes
Changes
Removed the folder of legacy recipes from this project, to avoid confusion.
Issues Closed
125

Thanks for putting this together.

This was merged on Oct-31, see PR #143.
@acrosman , how do we get this issue closed out?


Direction of prompt-toolkit

The README says "prompt_toolkit could be a replacement for GNU readline, but it can be much more than that.". It seems to me that it is now also a replacement for curses.
I was wondering, what direction you want to go. I have written up the background here:
https://github.com/inducer/pudb/issues/181
Do you think that prompt-toolkit would be a good foundation to get a full featured text UI, like I mention in the pudb issue above (see the screenshots there etc.)? Such a full featured set of widget would probably be written on top of a prompt-toolkit, as a separate library.

Hi @certik,
Excuse me for the late reply. Prompt_toolkit 2.0 has been released now, and as you can see it is possible to build full screen applications now. It took some time to get here, and I'm sure we need to implement more widgets. My ptterm project could be useful too for embedding a vt100 emulator as a widget in a prompt_toolkit application. It will gradually improve, but it's hard to decide whether everything you need is possible right now.


Add External Events

___REQUIRES_AERIE_PR___="1513"
A new construct in AERIE is that of External Events. In this PR, we will introduce External Events, their containing entities (External Sources), their grouping mechanisms (Derivation Groups), as well as how they manifest in the UI and in the backend. Extensive documentation on this will be added to aerie-docs, but a general introduction can be provided in this PR description.
External Events
An External Event is a construct that represents the occurrence of something outside of what is modeled in the mission model. They could be events that are close to the spacecraft and directly affect behavior on it, like a DSN visibility event that might affect when communications happen, or they could be much more remote, like a constellation event. Functionally, these are at the interstice between external datasets and activities, in that they manifest on the timeline as activities (discrete blocks of time), but they themselves do not affect the mission model or invoke any actions much like external datasets.

The need for these became apparent after an exploration of External Events implemented as activities and as resources. To mimic the same construct as a resource, we would need to parse the external data, and then place it on the timeline as a discrete resource, which given the fact that there are gaps between events and there can also be simultaneous events, proved extremely unwieldy and awkward. While activities were a more natural representation, we still required an intermediary of a resource to schedule these activities based off of an ingested file, as it isn't possible to schedule activities exclusively following information in a file.

As such, a new construct became envisioned, and that is what is introduced in this PR.
How?
External Events are bundled in files called External Sources. External Sources additionally contain some metadata about the collection of External Events (i.e. what period of time this External Source applies over). These can be uploaded to AERIE and managed in a newly added External Source Manager:

It is in this view that External Sources can be inspected, uploaded, and deleted. Both the metadata as well as the component External Events (via a Timeline or Table view) can be inspected:

External Events as a Table
External Events as a Timeline

Furthermore, grouped within another new construct (and operation) known as Derivation Groups, these External Sources and their External Events can be viewed on a timeline:

For the sake of brevity, we will not discuss these details further. Furthermore, details on the derivation operation can be found in the AERIE PR, as it is there that the majority of derivation-related logic is handled.
Discussion Items and TODOS:
Discussion Items

[x] Squash tables for source type, event type, and derivation group?
[x] Discuss valid_at - should it be called valid_after, created_at, published_at, etc.
[x] Parsing can/should be merged to Aerie Gateway to use ‘common’ parsing code?
[x] Ideal branching behavior?
[x] Cherrypicking of events/individual replacement of events outside of window?

TODOS:

Bugs:

[x] UpdateCard in plan persists very unnecessary extra data somehow.
[x] Tooltip becomes permanently sticky for some reason on the timeline (seen on ExternalSourceManager.svelte)
[x] Verify that during file parsing/upload, it is just one transaction? It seems fine to create an external event type and then fail on creation of a source, so the ONLY thing we should worry about here is verifying that orphaned events (events without a source) are impossible
[ ] ~Sometimes nothing appears in the external sources panel - rare timing issue.~

Features/Other:

[x] Remove cleanup - we can let source types and event types linger. Simply verify that empty derivation groups/types can still be readded to and that we don't create a new one. Should have a way to delete these if they are empty?
[x] make valid_at adhere to 8061. actually all dates if possible
[x] Tests for 0 duration events
[x] Just parse and then discard the files!!!
[ ] ~(MAYBE) change derivation group in the UI itself? (not yet?)~
[ ] ~(MAYBE) Add handling in ExternalSourceManager if can't reach hasura, don't show toasts saying it worked and switch panels, instead fail out, give a message, cancel the outgoing request?~
[x] (MAYBE) add handling about views refreshing for user change in plan
[x] (MAYBE) make sure filters select correctly in ExternalSourceManger.svelte on user change, add tests
[x] Change spacing in timeline for ee's if not grouping, to not justify to bottom but just to add height+5 space between rows
[x] fix name of query GetExternalEvents in gql.ts, update docs
[x] make view for external_source_event_type just a graphql query instead as this is faster

Do you mind reverting all the changes made to the port and github workflows, please?

To be specific, do you mean all changes in .github/workflows? Or are there additional places too?
Also, I believe that in test.yml we needed the parts about caching; is that okay to leave in?

Do you mind reverting all the changes made to the port and github workflows, please?

To be specific, do you mean all changes in .github/workflows? Or are there additional places too? Also, I believe that in test.yml we needed the parts about caching; is that okay to leave in?

I'd say just the added caching test step in the test.yml file is fine to keep, but all the other changes in that folder in general do not seem necessary to support the feature. I'm open to discussing more about it if you feel otherwise. The only changes outside that folder that should be reverted are the port changes from 3000 -> 3005.

I'd say just the added caching test step in the test.yml file is fine to keep, but all the other changes in that folder in general do not seem necessary to support the feature. I'm open to discussing more about it if you feel otherwise. The only changes outside that folder that should be reverted are the port changes from 3000 -> 3005.

Taken care of!

All, this pull-request (and the sister PR to aerie) are ready for an in-depth review!
Note that some E2E + unittests are still being worked here, but should not have a major impact on the rest of the pull-request's code.

E2E & unittests are now stable and should be complete. The one caveat is that due to them all relying on the changes to aerie, the tests will fail underneath the GitHub action - but should pass when ran locally with the database changes!

Can you provide some sample external events for testing purposes?

@JosephVolosin @pranav-super Can you provide some sample external events for testing purposes?

There's a few example files in e2e-tests/data - especially the derivation ones. We have some other examples that I didn't upload here as there not used for the e2e tests, but could be useful in general - maybe as assets in aerie-docs?

Some notes from the design tag up with @JosephVolosin and @pranav-super
Manage derivation groups and types modal

Remove create new input from top. Replace that with segmented controls that hit the same functionality as the current dropdown for changing between derivation groups, source types, and external events
Add button for "create new" next to the manage derivation groups. This will be a single text input and some short helper text
We should probably include a way for a user to access details about a derivation group from the main table. This could be a v2 item.

Manage derivation groups (within single plan)

Remove label to the left of the filter.

Icons

@lklyne to try out some icons for external events and sources to replace the truck and balloon

Seeing e2e tests pass on my local machine, but seems like they're having trouble in the GH check - see screenshots below

Might be related to timing? I know I mentioned the other day that some of the plan-related external event tests can be pretty long, let me know if you think we need to scale back or rework any of them. It's a little complicated b/c some tests like the card test require Playwright to go back and forth between the plan view + External Source Manager view, and then also wait for toasts to appear/disappear (I tried pulling out all the waits that I reasonably could in one of the last commits)

@JosephVolosin @pranav-super do you guys mind removing the commits that I think were accidentally merged into this branch and rebasing off of latest develop? It's bloating the PR a bit with irrelevant changes.

Could you construct a sample events file that contains several thousand (or more) events so that we can ensure that the timeline and other UI elements render acceptably under that load?

Could you construct a sample events file that contains several thousand (or more) events so that we can ensure that the timeline and other UI elements render acceptably under that load?

Sure! Attached is an example source with 7200 events, one each minute from 2024 Jan 1st -> 2024 Jan 5th.
example_external_source.json
FWIW, I also did a little bit of stress testing earlier with an actual example file we got from a mission at GSFC that contained ~100k events (file size was ~35MB). I noticed a bit of lag on the timeline especially with that many events, but it was still generally operable. I believe this file should be no problem for the UI to handle but let me know if you see anything unexpected!

Could you construct a sample events file that contains several thousand (or more) events so that we can ensure that the timeline and other UI elements render acceptably under that load?

Sure! Attached is an example source with 7200 events, one each minute from 2024 Jan 1st -> 2024 Jan 5th. example_external_source.json
FWIW, I also did a little bit of stress testing earlier with an actual example file we got from a mission at GSFC that contained ~100k events (file size was ~35MB). I noticed a bit of lag on the timeline especially with that many events, but it was still generally operable. I believe this file should be no problem for the UI to handle but let me know if you see anything unexpected!

Performance generally looks good with that dataset. Seeing a little bit of lag when flattenItems is being called, like 400ms on my machine to expand the top folder. Wonder if this could be optimized or if we're stuck with it for now? Not a big deal to punt on it.

FYI, created https://github.com/NASA-AMMOS/aerie-ui/issues/1486 to track the future improvement of styling for the tab list in TimelineItemsPanel.svelte.


Apply material design 3 to MaterialRating

Mark the old one as obsolete.
Create the new version on the new M3 folder.
Apply default styles.
Rename control from MaterialRatingControl to MaterialRating (only M3 control).

Keep in mind the following issue to see if we can fix it:
#89

We are excited to announce that we are working on a new generation of controls based on Material Design V3, which we will be releasing soon.
This ticket has been included/fixed in the upcoming version of this NuGet package, which will include both current and new generations of controls.


Rules 913100 and 913102 have ecairn-grabber switched?

Describe the bug
While testing 913100-7 in blocking mode, it got my attention because it is blocking on rule 913102:
11:20PM DBG ftw/http: sending data:
GET / HTTP/1.1
Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
Connection: close
Host: localhost
User-Agent: mozilla/5.0 ecairn-grabber/1.0 (+http://ecairn.com/grabber)

Looking at logs, this is the match:
Message: Warning. Matched phrase "ecairn-grabber" at REQUEST_HEADERS:User-Agent. [file "/etc/modsecurity.d/owasp-crs/rules/REQUEST-913-SCANNER-DETECTION.conf"] [line "182"] [id "913102"] [msg "Found User-Agent associated with web crawler/bot"] [data "Matched Data: ecairn-grabber found within REQUEST_HEADERS:User-Agent: mozilla/5.0 ecairn-grabber/1.0 (+http://ecairn.com/grabber)"] [severity "CRITICAL"] [ver "OWASP_CRS/3.4.0-dev"] [tag "modsecurity"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-reputation-crawler"] [tag "OWASP_CRS"] [tag "capec/1000/118/116/150"] [tag "PCI/6.5.10"] [tag "paranoia-level/2"]

Steps to reproduce
Run test 913100-7.
Expected behaviour
Rule 913102 should not match, as there is an exception for ecairn-grabber user-agent in 913100.
Actual behaviour
Rule 913102 is matching.
Additional context
Looks like we partially (or totally) moved the scanners-user-agents.data, but kept stuff in there that should be from crawlers-user-agents.data?
In any case, rule 913100 checks for ecairn-grabber in file crawlers-user-agents.data, but that pattern is in scanners-user-agents.data.
Your Environment

CRS version (e.g., v3.2.0): v3.4/dev
Paranoia level setting: PL4
ModSecurity version (e.g., 2.9.3): ModSecurity 2.9.5
Web Server and version (e.g., apache 2.4.41): apache 2.4.45
Operating System and version: owasp/modsecurity-crs:apache docker image

If anyone can check the related PR before our meeting, one less thing to check!


The country and farm name filter should have auto complete

this should be applied on all pages

this issue is blocked on #1877, need to be merged first to apply this feature

Work completed:
Applied for node finder
Investigation and Solution:
will add those fields to farm finder page

Work Completed:
we decided that the current logic will not scale as wanted, we drafted the old pr and now we are enhancing the filters, almost done.
Investigation and solution:

will apply the new filters to the dedicated machine page
add query route to the filter component

verified on devnet
version : 7b55dd4
farm names are auto completed and you can not insert unrecognized farm name
for the nodes the countries now are in a drop down menu
Screencast from 23 ينا, 2024 EET 08:31:08 م.webm
Screencast from 23 ينا, 2024 EET 08:37:54 م.webm

Verified:

Devnet
7b55dd4


Adding Websites to learn Cyber Security

Cybrary (https://www.cybrary.it/)
SecurityTube (http://www.securitytube.net/)
Harvard/EDX (https://www.edx.org/course/subject/computer-science)
SANS Cyber Aces (http://www.cyberaces.org/courses/)
Digitokawn (https://digitokawn.com/trainings/)

6.Tryhackme(https://tryhackme.com/)
7.Hackthebox(https://www.hackthebox.com/)
8.letsdefend(https://letsdefend.io/)


Unable to complete a login flow with magic link over API based authentication in a web applicaiton

Describe the issue:
How to reproduce:
1 - configure username & password and magic link as 1st step sign-in options of an application
2 - Try to do magic link-based authentication from a web app perspective
3 - After selecting the magic link step and submitting the username, the user receives an email with a magic link-related call
4 - As step 2 and 3 can happen in two browsers, unable to proceed with step 3 as it doesn't have all the information to complete the login flow.
Expected behaviour:
The flow after receiving the magic link in the email should be self-contained. For that, the flow should be available in the email.
Note: Also check the possible security risks associated with sending the callbacks in the email link with the other information.

A state parameter has been added to the magic link with https://github.com/wso2-extensions/identity-local-auth-magiclink/pull/47 which allows the client app to correlate the received magic link token with the authentication flow. This still requires the user to click the magic link in the same device/browser.
Currently, one way to work around the limitation of same device/browser requirement is for the implementer to create a central service to receive the magic link and to poll this service from the client app with the state until a time out or the result is received.
The overall mentioned problem is due to a limitation of the current way the magic link authenticator is implemented. As there is a workaround and due to this not being a API based auth specific problem the severity of the issue is reduced.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


test result failed

when test why I encounter this error ?how can I slove this problem.I can not get the result of fid

Hi @wxzzu ,
It seems there might be a conflict between the argparse.ArgumentParser() in main.py and fid_score.py.
Could you please share the input command you're using? This will help me figure out a way to resolve the issue.

Thank  for your help 。 I use ‘Python main.py --is_test =True  --save_dir=resnet  --images_root =resnet  --label_path=imagenet-compatible/labels.txt’ to test on the model of  resnet.Save_dir and images_root  are the locations of the adversarial samples I generated with the Resent model.
------------------ 原始邮件 ------------------
发件人:                                                                                "WindVChen/DiffAttack"                                                                                @.>;
发送时间: 2024年9月4日(星期三) 凌晨4:58
@.>;
<EMAIL_ADDRESS>主题: Re: [WindVChen/DiffAttack] test result failed (Issue #25)
Hi @wxzzu ,
It seems there might be a conflict between the argparse.ArgumentParser() in main.py and fid_score.py.
Could you please share the input command you're using? This will help me figure out a way to resolve the issue.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Thank  for your help 。 I use ‘Python main.py --is_test =True  --save_dir=resnet  --images_root =resnet  --label_path=imagenet-compatible/labels.txt’ to test on the model of  resnet.Save_dir and images_root  are the locations of the adversarial samples I generated with the Resent model.

Hi, it should be working now. You can update your code to the latest version of the repo, or check out the modifications here.


chore: cleanup

can it still be merged?

Yes, we should merge this. Anyway, the concern is still valid


services/horizon/internal: Only use repeatable read transactions on state endpoints

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.
[ ] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[ ] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ ] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

What
In https://github.com/stellar/go/pull/2416 we extended the Last-Ledger header to cover additional endpoints which were not immutable.
@2opremio raised the following point before working on the PR:

After giving this quite a bit of thought, isn't it overkill to set that header (and in turn access the DB for all endpoints) to make horizon-cmp happy?

After testing the 1.1.0 release candidate on staging we found evidence to confirm this hypothesis. The overhead of wrapping each request in a repeatable read transaction proved to significantly hinder performance.
We should remove this change from the 1.1.0 release. We can always reintroduce this change later on but at this point it would be better to explore other solutions to the underlying problem we are trying to solve (verifying correctness of a horizon release) that have less of a negative impact on performance.
Here are some graphs which display the performance hit:

The first half of the graph covers a period where the Last-Ledger header was enabled and the second half of the graph covers a period where the header was disabled.

wouldn't it be better to fully revert #2416 ?

wouldn't it be better to fully revert #2416 ?

there are parts of the PR that I would like to keep. for example, the comments in the orderbook and path finding endpoints,  and the fixes to the test scenarios. Also, if we decide to enable the middleware in the future it will be easy to do so.

Fair enough.

Also, if we decide to enable the middleware in the future it will be easy to do so

There is always git for that.

Geez, those graphs make the point so clearly. Totally agree with this.


Documentation mismatch between ruff and docs for f-string-in-exception

This is a documentation issue, not related to the logic.
This issue is relevant for the current version: 0.5.4.
In https://docs.astral.sh/ruff/rules/f-string-in-exception/ there's a section that shows the traceback before and after, in the after one it does not include the first line of the traceback.
I wanted to open a PR to add the missing line, but when opening the code docstrings it seemed to already include that line:
https://github.com/astral-sh/ruff/blob/2ce3e3ae60ba44700b5e98a61adc96d80b0e4bd3/crates/ruff_linter/src/rules/flake8_errmsg/rules/string_in_exception.rs#L43-L48
I went to the docs repo, and there the first line was missing:
https://github.com/astral-sh/docs/blob/main/site/ruff/rules/f-string-in-exception/index.html#L827-L830
I don't know what the source of this mismatch is, but seemed that just opening a manual change to the generated docs is not the way to go. So here I am opening an issue.

Sigh... my bad, I'll open a PR soon.
Thanks.

Closed by https://github.com/astral-sh/ruff/pull/12508.


Azure DevOps - Azcopy task inside Template

Which version of the AzCopy was used?
I'm not explicitly calling AzCopy, just via the Azure DevOps task version 4 defined as:
- task: AzureFileCopy@4
What command did you run?
File copy task is defined inside a YAML file called template_webcontent.yml that is used as a job template in another YAML Pipeline. Here is the parameter and task definition inside  template_webcontent.yml:
parameters:
  artifactName: ''
  artifactDownloadPath: ''
  azureSubscription: ''
  storageAccount: ''
  webContainter: ''
  blobPrefixApp: ''
  blobPrefixStatic: ''

        - task: AzureFileCopy@4
          displayName: "Copy App files"
          inputs:
            SourcePath: "${{ parameters.artifactDownloadPath }}/*"
            azureSubscription: ${{ parameters.azureSubscription }}
            Destination: 'AzureBlob'
            storage: ${{ parameters.storageAccount }}
            ContainerName: ${{ parameters.webContainter }}
            BlobPrefix: ${{ parameters.blobPrefixApp }}
            AdditionalArgumentsForBlobCopy: '--exclude-pattern=static'

It is then referenced in the primary pipeline as:
- stage: "blobdeploydev"
  dependsOn: build
  displayName: "Deployment: Dev"

  pool:
    vmImage: 'windows-2019'

  jobs:
  - template: template_webcontent.yml@templates
    parameters:
      artifactName: 'site_content'
      artifactDownloadPath: '$(System.ArtifactsDirectory)/site_content'
      azureSubscription: 'something-nonproduction'
      storageAccount: 'storageaccount001'
      webContainer: '$web'
      blobPrefixApp: 'people'

In this case, "something-nonproduction" is a service connection in Azure Devops.
What problem was encountered?
When the task runs from inside the template, it seems the login stage is skipped. Here is some output with the Sub ID removed. You'll see it imports the modules and then immediately disconnects without performing any of the login/copy steps. It throws a 409 too - which from the API documentation doesn't seem to be correct either?
Starting: Copy App files
==============================================================================
Task         : Azure file copy
Description  : Copy files to Azure Blob Storage or virtual machines
Version      : 4.171.3
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-file-copy
==============================================================================
Import-Module -Name C:\Modules\az_3.1.0\Az.Accounts\1.9.3\Az.Accounts.psd1 -Global
Clear-AzContext -Scope Process
Clear-AzContext -Scope CurrentUser -Force -ErrorAction SilentlyContinue
Connect-AzAccount -ServicePrincipal -Tenant *** -Credential System.Management.Automation.PSCredential -Environment AzureCloud @processScope
 Set-AzContext -SubscriptionId XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXX -TenantId ***
Import-Module -Name C:\Modules\az_3.1.0\Az.Resources\1.8.0\Az.Resources.psd1 -Global
Import-Module -Name C:\Modules\az_3.1.0\Az.Storage\1.9.0\Az.Storage.psd1 -Global
Import-Module -Name C:\Modules\az_3.1.0\Az.Compute\3.1.0\Az.Compute.psd1 -Global
Import-Module -Name C:\Modules\az_3.1.0\Az.Network\2.1.0\Az.Network.psd1 -Global
Disconnect-AzAccount -Scope Process -ErrorAction Stop
Clear-AzContext -Scope Process -ErrorAction Stop
##[error]Public access is not permitted on this storage account. HTTP Status Code: 409 - HTTP Error Message: Public access is not permitted on this storage account.
ErrorCode: PublicAccessNotPermitted
ErrorMessage: Public access is not permitted on this storage account.
RequestId:ad8c3b26-001e-001a-1421-81b467000000
Time:2020-09-02T12:06:31.7446470Z
Finishing: Copy App files

How can we reproduce the problem in the simplest way?
As above.
Have you found a mitigation/solution?
Task works perfectly outside of a template. I assume this is something to do with how the parameters are expanded and runtime vs compile time? I have some other tasks (Terraform for example) that pass the service connection and user details as parameters in almost exactly the same way and these appear to work fine.
Thanks

@DAL3001
If this is for Azure Powershell cmdlet, the normal way is to file a issue in https://github.com/Azure/azure-powershell/issues
If you following the issue teamplate, normally we can get the information necessary to investigate this.
And please provide the detail script that can repro it.
For the above 409 error, it might caused "AllowBlobPublicAccess" is disabled on the storage account. You can enable it on portal like following:


Tutorial for Problem LOJ-1266

I am writing editorial for this problem.

@Abhishekohm any update on this?

Closed due to inactivity. Issue (Problem 1266) is up for grab.


Allow building out-of-source

To test different build setups it is useful to have one source tree and 3 build dirs. So you can type 'make' in each without interfering between them.
I use it to have a qt4/qt5 and a no-wallet build-dirs. So any changes in the Qt code can easily be tested to work in any setup.
This merge request makes it so that most of bitcoin can be build out of source.
Seems that levelDB is not able to, so that one will be build still in the sourcetree. But
levelDB development would not happen inside of bitcoin anyway, so thats fine.

Gavin's deletion of the 0.12 branch auto-closed this PR. For now we're building on top of 0.11.2

Sorry about that, Chief...
Concept ACK on out-of-tree builds.


Write unit tests for team2.go

Unit tests added, last commit for unit tests is 9371a7a48bbda5e1bf9c867ea4ee37fd730d6a01.


Feat: Expand User type

This PR contains commits from https://github.com/freeCodeCamp/open-api/pull/48, by mistake.
This PR expands the User type, adjusts the user query's to return a single user and adds a challengeMap Mutation type.

I'll need a little more time to review this, I can do that on my Monday, your Sunday.

Waiting on #58

#58 went in (nice work!), what's the status of this one at the moment?

Almost a rewrite, but it is nearly there.
One issue I am having that ibmeant to ping you for is, if I use mongo in a different test suit in the same way that the users integration test does, I get a race condition between the the afterAll disconnects. If onebsuit is still running then the tests fail because  MongoError: Topology was destroyed or something to that effect.
I have tried managing a connection in the global setup/teardown, but the tests would timeout. Any ideas?

@Bouncey interesting! Does this happen when you run jest with --runInBand too?

@ojongerius yes it does, I think it is due to the async nature of the setup and teardown, where at times, they overlap. I will push what I have so far so you can see.
I think I'm in a place where I shouldn't be adding any further commits to this PR, else the scope will slip too far.

@ojongerius I might have fixed the race condition be returning the promise in teardown?

I worte all of those test before rebasing, so glad that I did because I made a unholy mess and lost two days with of work with a clumsy git stash pop.
Yay for tests! :tada:

Sounds good! Sounds like it's review time? Are you keeping the WiP label while finish writing the code to talk to auth0?

Please review. None of this code should change, all I need to add is an API call to auth0

👍 will have a look today.

Finished another pass 😅 This is turned into quite an epic. Awesome work but please don't add more complexity! 😄

This is the reason for the --silent flag. 😁

Would it not be neater to expect and handle those errors. Could we use tothrowerror and or  tothrowerrormatchingsnapshot?

I have no other concerns than that it looks messy to have uncaught errors in tests.

Outstanding tasks AFAICS

[ ] remove or improve deleteGDPRUser
[ ] agree if tests should have uncaught errors

After that we should be good to merge, let's get this today or latest, tomorrow.

Yes, I agree.. I am going ahead and giving this a merge, to keep things moving! Thanks a lot @Bouncey this is some incredible work!
/cc @freeCodeCamp/open-api


Add visual indicator that user can copy the address by tapping on it in the side menu

Expected Behavior
There is a visual indication that user can copy the account key from the side menu. Should be a copy icon or just say in plain text "Tap to copy"
Current Behavior
Users are not aware that they can copy the account key by tapping over it. As a result, they type it in manually and do mistakes > send the funds to non-existing addresses. More context here: https://celo-org.slack.com/archives/C0134SBQTQR/p1619797847006600

[ ] Add visual indicator according to the design specs created here: https://app.zenhub.com/workspaces/wallet-backlog-board-60092d006a84e3001d0d5936/issues/celo-org/wallet/302

[ ] Add analytics event when users tap over account number: account_number_copied

https://valora.testquality.com requirement R39.

Hi @MuckT We have verified this issue on Latest android build V1.16.0 & Testflight build V1.16.0(66) and updated the status in testqulaity tool.
Testquality tool link:
Android:

https://valora.testquality.com/project/12128/plan/20854/run/148956/result/2432161

iOS:

https://valora.testquality.com/project/12128/plan/20854/run/148956/result/2432189

CC: @isabellewei

Hi @MuckT, We have verified this issue on Latest android build V1.16.0 in Android 11.0 and everything is working as expected.
Device Details: Google Pixel 4a(11.0)


Relatively slow performance limiting deployment

We're keen to deploy JXL and have been testing it in production. Historically, we have used WebP but we are now serving images encoded in JXL to clients which advertise support in their accept headers, on the order of ~10k images a day. In terms of file size and quality (as checked by SSIM) things look good, however the challenge we are facing is that encoding JXL takes ~5x longer than the same operation using WebP (we test encode each image, so we can observe the compared encoding times.) It's a naive example, but you can see this performance discrepancy comparing cwebp vs cjxl on most test images. Because of the performance gap we are limited to deploying JXL only up to a certain size of image, e.g. https://cdn.shopify.com/s/files/1/0647/7081/files/japan_street.jpg?v=1656964576&width=400 otherwise we exceed our encoding time budget (we cache all the encoded images at the CDN layer, but we have a cache miss budget as well.)
As mentioned, we're excited to help drive JXL adoption but are interested to understand if there are performance improvements in the works which will help pave the way for more widespread deployment? Are there specific areas which could be improved but are waiting for contributions? Thanks!

What encode effort are you currently using? According to my testing, effort 6 is just as good as effort 7 on photographic images (on certain kinds of non-photo effort 7 does better though). It's a bit faster. Effort 5 is a bit worse but should be quite a bit faster too. Effort 4 should be about as fast or faster than default speed webp and still quite a bit better, but it's obviously not using the full potential of jxl anymore at such a low effort. Effort 3 is basically a glorified jpeg encoder, it's better not to use it. I'd recommend effort 5 or 6.
Also make sure you're using a libjxl that has been compiled with a recent version of clang. It might be worthwhile to compile it yourself, I'm seeing worse performance when using the precompiled ones of e.g. the 0.7.0 release than when I'm compiling it from source (something we should probably investigate).
For checking quality, it's best not to use SSIM — it has quite poor correlation with subjective experiments, almost as bad as PSNR. I can recommend DSSIM, Butteraugli 3-norm or SSIMULACRA 2 as more useful objective metrics.
In terms of what's in the works: one thing is https://github.com/libjxl/libjxl-tiny, which is a simplified jxl encoder, mostly aimed at eventually being converted to a hardware implementation, but it's possible that this will also lead to a faster software encoder.
I'm a bit surprised that you have a fixed time budget per image, regardless of image dimensions, rather than, say, a minimum speed target in megapixels / second. If this is the case though, then perhaps you could consider to adjust the effort setting depending on the image dimensions (say effort 4 for big images, 5 for medium, 6 for small and 7 for very small).


Fixing cases for fields that contains space

currently we split fields using space separator. But this failed in case program has space in name. For example "tmux: server". This refactor the current decoders into simple index-based decoders to let them have greater flexibility in parsing its required data.
Before:
Error getting table "counts" values for metric "dcache_ops_total" of program "dcstat": key "{ 0x1 \"tmux: server\" }" has 3 elements, but we expect 2

After:
ebpf_exporter_dcache_ops_total{command="tmux: server",op="refs"} 2517

Would it be better to split entry.Key into elements outside of decoders? Keeping decoders simple and only letting them read the exact string they are supposed to read seems like a cleaner cut of responsibilities.
Keys as byte slices are coming as well: https://github.com/iovisor/gobpf/pull/102.

Going with #24 and byte slice decoding instead.


Version 2

Problem

Description of why you made this PR

Solution

And how do you fix that problem

PR Status

[ ] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

!testme


Several improvements for the "create_runtime_policy.sh" script

In addition to introducing parametrization for all paths, there is now the possibility for the user to supply an exclude list (-e/--exclude_list), which will be automatically incorporated into the policy
Usage: /KL/keylime/scripts/create_runtime_policy.sh -o/output_file FILENAME [-a/--algo ALGO] [-x/--ramdisk-location PATH] [-y/--boot_aggregate-location PATH] [-z/--rootfs-location PATH] [-e/--exclude_list FILENAME] [-s/--skip-path PATH]" optional arguments:
-a/--algo (default sha1sum)
-x/--ramdisk-location (default /boot/, set to "none" to skip)
-y/--boot_aggregate-location (default
/sys/kernel/security/ima/ascii_runtime_measurements, set to "none" to skip)
-z/--rootfs-location (default /, cannot be skipped)
-e/--exclude_list (default none)
-s/--skip-path (default none)
Not extensively tested (and AFAIK, not part of the testing CI)

@Koncpa @kkaarreell I believe there is a problem with fedora-rawhide. This is the second PR where this particular test keeps failing consistently with  Failure during Ansible playbook execution

I was under the impression that this should now be consolidated as part of create_policy.py.  In fact, it is there where I added the code to create the policy based on the remote repo information (and avoid the analysis of the local system)

@aplanas This is a very good question. The documentation still refers to scripts/create_runtime_policy.sh and as it was the issue which motivated this PR, first-time users, researchers and students (among others) still derive some value from the ability to create an allowlist from the analysis of the local filesystem. What I did here was to make sure, given that the script exists and is documented, it operates correctly.
I am not opposed to remove it altogether, although in my experience, having a tool that produces a list of checksums by analyzing the filesystem has been proven useful (including in production environments).

@aplanas  yes, ideally we should re-implement the features of create_runtime_policy.sh in create_policy.py, so that we only have one tool. For now the fixes I think are fine, but we should not start extending the shell script.

I am not opposed to remove it altogether, although in my experience, having a tool that produces a list of checksums by analyzing the filesystem has been proven useful (including in production environments).

I agree with you that the local analysis is very important to bootstrap the tool, so the feature should not removed.

/packit retest-failed


Support for alternative indentation styles

Would you be interested in supporting alternative indentation styles in this crate? Specifically tabs and potentially alternative width spaces? Trying to understand if this is in scope for the project since it's being used in downstream formatting crates which are not able to fully support tabs or alternate width spaces due to this feature being unsupported.

I would prefer not to support this in this crate.
The algorithm would be compatible with hard tab or alternate number of spaces, so someone should feel free to maintain a fork with that functionality.


.NET Errors

Describe the bug
I've downloaded and installed all forms of .NET and it still keeps telling me I need it installed in order to launch it.
To Reproduce
Steps to reproduce the behavior:

Download from here
Try to launch it
Be given pop-up stating .NET is needed and go to download/install it
Post-download/installation, it still says I need it

System Information
Attached Dxdiag below
Additional context
I downloaded it first from Nexus Mods, but felt that one may have been out of date so I redownloaded it from the repository here and it's still giving me the same issue
DxDiag.txt

You need .net version 5 x64 desktop for windows.
An eventual update will change the runtime to .net 6 desktop

Apologies for the late response, I was temporarily hospitalized for a matter that has thankfully resolved positively. I'll try that when I get out of work today and report here on my success or lack thereof; thank you for the response!

I have the same issue. Tried to install .NET 5 x64 and x86 neither resolves the issue. Also the version that gets installed is 5.0.17 not 5.0 but there is no other download of .NET 5. Don't know if that may be the problem.

And you're positive you installed the windows x64 desktop runtimes?
I will eventually do a release for .net 6, but it's a low priority

Well, I tried installing both the x64 and the x86 version, but the x64 first.

I updated the release to .net 6 x64 desktop::
https://dotnet.microsoft.com/en-us/download/dotnet/thank-you/runtime-desktop-6.0.6-windows-x64-installer

Thank you very much. It works now.


Thanks page refresh

What
ThanksPage refresh.
Why
https://trello.com/c/Wn2Faoo6/299-more-refresh-thanks-page

Is the final string Share this project?

@dannyalright Yes,  but I have another PR in the kickstarter repo with the See all [category_name] projects string waiting for approval. After that I will update the screenshot.

@Scollaco you taking a look into the failing screenshots?

@justinswart Yes, but I was waiting for a new string to be deployed so I could change a button title and update the snapshots. that's why I didn't try to fix it immediately .

 More refresh: thanks page


Does clearing the cache or all data cause irretrievable tracing data loss?

Was requested to be opened as a separate issue by @jakobmoellersap:
Does clearing the cache or all data cause irretrievable tracing data loss?
This is what @MikeJayDee originally wrote about this:

Clearing the cache or even all data should not be a problem in my view; the received rolling proximity identifiers, and the daily tracing keys used to calculate the sent rolling proximity identifiers are not stored by the app, but by the API.

Would be good if someone could confirm.

The only disadvantage might be that the app would then incorrectly state that it has only been active for a day, but that's just a minor inconvenience (I had the Latvian app installed for two weeks or so, so in principle the CWA should show "14 of 14 days active" for me, but as the app does not have this information, it only shows "1 of 14 days active").

Originally posted by @MikeJayDee in https://github.com/corona-warn-app/cwa-app-android/issues/574#issuecomment-645235187

We now have added this question to the FAQs and the answer is, in short, that only deletion via the system settings will delete the collected RPIs:
https://www.coronawarn.app/en/faq/#delete_random_ids


Clarified automatic upgrade behavior

@michaelrm97 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@michaelrm97 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@jborsecnik : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@jborsecnik : Thanks for your contribution! The author(s) have been notified to review your proposed change.


ReaScript: BR_Win32_WritePrivateProfileString(): support deletion of a key by passing __delete as value

:white_check_mark: Build sws 602-master completed (commit https://github.com/reaper-oss/sws/commit/72f4e3119e by @nofishonfriday)

Windows 64-bit

build/BuildUtils/SWS_Template.ReaperLangPack
build/BuildUtils/whatsnew.html
build/reaper_sws-x64.pdb
build/sws-<IP_ADDRESS>-Windows-x64-write-private-profile-string-allow-delete-key-72f4e311.exe

Windows 32-bit

build/BuildUtils/SWS_Template.ReaperLangPack
build/BuildUtils/whatsnew.html
build/reaper_sws-x86.pdb
build/sws-<IP_ADDRESS>-Windows-x86-write-private-profile-string-allow-delete-key-72f4e311.exe

macOS x86 64-bit

build/sws-<IP_ADDRESS>-Darwin-x86_64-write-private-profile-string-allow-delete-key-72f4e311.dmg

macOS x86 32-bit

build/sws-<IP_ADDRESS>-Darwin-i386-write-private-profile-string-allow-delete-key-72f4e311.dmg

macOS ARM 64-bit

build/sws-<IP_ADDRESS>-Darwin-arm64-write-private-profile-string-allow-delete-key-72f4e311.dmg

Linux x86 64-bit

build/sws-<IP_ADDRESS>-Linux-x86_64-write-private-profile-string-allow-delete-key-72f4e311.tar.xz

Linux x86 32-bit

build/sws-<IP_ADDRESS>-Linux-i686-write-private-profile-string-allow-delete-key-72f4e311.tar.xz

Linux ARM 64-bit

build/sws-<IP_ADDRESS>-Linux-aarch64-write-private-profile-string-allow-delete-key-72f4e311.tar.xz

Linux ARM 32-bit

build/sws-<IP_ADDRESS>-Linux-armv7l-write-private-profile-string-allow-delete-key-72f4e311.tar.xz

:white_check_mark: Build sws 603-master completed (commit https://github.com/reaper-oss/sws/commit/6e058b5040 by @nofishonfriday)

Windows 64-bit

build/BuildUtils/SWS_Template.ReaperLangPack
build/BuildUtils/whatsnew.html
build/reaper_sws-x64.pdb
build/sws-<IP_ADDRESS>-Windows-x64-write-private-profile-string-allow-delete-key-6e058b50.exe

Windows 32-bit

build/BuildUtils/SWS_Template.ReaperLangPack
build/BuildUtils/whatsnew.html
build/reaper_sws-x86.pdb
build/sws-<IP_ADDRESS>-Windows-x86-write-private-profile-string-allow-delete-key-6e058b50.exe

macOS x86 64-bit

build/sws-<IP_ADDRESS>-Darwin-x86_64-write-private-profile-string-allow-delete-key-6e058b50.dmg

macOS x86 32-bit

build/sws-<IP_ADDRESS>-Darwin-i386-write-private-profile-string-allow-delete-key-6e058b50.dmg

macOS ARM 64-bit

build/sws-<IP_ADDRESS>-Darwin-arm64-write-private-profile-string-allow-delete-key-6e058b50.dmg

Linux x86 64-bit

build/sws-<IP_ADDRESS>-Linux-x86_64-write-private-profile-string-allow-delete-key-6e058b50.tar.xz

Linux x86 32-bit

build/sws-<IP_ADDRESS>-Linux-i686-write-private-profile-string-allow-delete-key-6e058b50.tar.xz

Linux ARM 64-bit

build/sws-<IP_ADDRESS>-Linux-aarch64-write-private-profile-string-allow-delete-key-6e058b50.tar.xz

Linux ARM 32-bit

build/sws-<IP_ADDRESS>-Linux-armv7l-write-private-profile-string-allow-delete-key-6e058b50.tar.xz


bug/logger-not-logging

All calls to logger files are not being displayed when running the CLI... why?

I think the logs are supposed to write to a file, so this might be okay. Check with @bwalsh

Yes the log file setup is in the cli.py package.  A recent change was the "log to file" feature only happens in the 'annotate' command. ie the 'ps' command does not create a log file

@quinnwai close if appropriate


[CMake] Split out libinfo.cc into a separate target.

Every *.o file in the cmake-generated makefiles have a dependency on the target's flags.make file.  The flags.make file contains the compiler flags for all objects in a target, not just the *.o file currently being compiled.  As a result, even though libinfo.cc is the only file that has the TVM_GIT_COMMIT_TIME and TVM_GIT_COMMIT_HASH definitions, every file in the tvm_objs target was recompiled whenever the commit id was changed.
By splitting libinfo.cc out into a separate target, no other files need to be recompiled when committing or changing branches, unless there are actual changes to a file.

@junrushao1994 Could I get a review from you, since you originally implemented the libinfo.cc functionality?  From testing with tvm.support.libinfo(), I don't see any changes or breaking of functionality.

CC @comaniac who added the TVM_GIT_COMMIT_TIME :-)

Not in the scope of this PR, I am thinking if we should add a cmake target for each subfolder like src/runtime, src/tir, src/relay and each target could have their own precompiled header, unit build, etc.

Not in the scope of this PR, I am thinking if we should add a cmake target for each subfolder like src/runtime, src/tir, src/relay and each target could have their own precompiled header, unity build, etc.

I think that would make a lot of sense.  I could also imagine having a debug option for each target to generate a separate shared library.  At least one my computer, linking the final libtvm.so is what takes the majority of the total time if I've only changed a few files.  Having a single distributable file is good for deployment, but having a debug libtvm.so that itself points to a dozen smaller libraries would be much faster for incremental testing.


Task creation fails with CANCELLED error when using API key authentication

Expected Behavior

Task creation should succeed when authenticated with API key and using a smart wallet address
Should return a successful response with a task ID

Current Behavior

The API call is being cancelled with error: "1 CANCELLED: Call cancelled"
Test fails due to unexpected RPC cancellation

Test Details
test("should create a task when authenticated with API key", async () => {
  const result = await client.createTask({
    address: smartWallet,
    tokenContract: TOKEN_CONTRACT,
    oracleContract: ORACLE_CONTRACT,
  });
  expect(result).toBeDefined();
  expect(result).toHaveProperty("id");
});

Test Trace
 FAIL  tests/createTask.test.ts
  listTasks Tests
    Auth with API key
      ✕ should create a task when authenticated with API key (199 ms)

  ● listTasks Tests › Auth with API key › should create a task when authenticated with API key

    1 CANCELLED: Call cancelled

      4576 |   _callRPC(method, request) {
      4577 |     return new Promise((resolve, reject) => {
    > 4578 |       this.rpcClient[method].bind(this.rpcClient)(
           |                                                  ^
      4579 |         request,
      4580 |         this.metadata,
      4581 |         (error, response) => {

Reproduction Steps

Run npx jest tests/createTask.test.ts -t "should create a task when authenticated with API key"
Observe that the gRPC call is cancelled unexpectedly

Additional Context

The error occurs in the gRPC client layer
This might indicate an issue with the API key authentication or connection handling
The test passes when using signature authentication, suggesting this is specific to API key auth

Fixed in https://github.com/AvaProtocol/ava-sdk-js/pull/30


UI for data editing

As a user I want to enter/edit my own data to make it accessible for other users, these changes should be reflected in the database (Team APMW).
@

user model and login given


Indentation with continued lines

The following code does not parse:
extension := compileOptions.extension ??
  if compileOptions.js
    ".civet.jsx"
  else
    ".civet.tsx"

But this does:
extension := compileOptions.extension ??
  if compileOptions.js
    ".civet.jsx"
else
    ".civet.tsx"

I assume the issue is that the newline after ?? doesn't trigger a PushIndent, so else doesn't know the correct indentation level.  I wonder if if should be responsible for pushing an indent? I'm not sure.

We may be able to refine BinaryOpRHS to check for nested expressions first before expanding to arbitrary whitespace.

I can't believe I came up with almost the same example in #598 without remembering this issue.  #600 fixed this.


Add a page to enumerate issues arising from Jira permissions

Feel free to make any edits of course.

https://github.com/released-software/released-app/compare/warn-about-permissions-when-generating?expand=1 needs this


Avoid assuming utf-8 encoding when calling external process.

In my system (win 7 x64 PL) when invoking:
for line in execute(['hg', 'showconfig'], split_lines=True):
I was getting:
CRITICAL: 'utf8' codec can't decode byte 0xb3 in position 22: invalid start byte

Hi,
We don't use pull requests. Can you put this on https://reviews.reviewboard.org? Thanks!


Passing an alias as an option to a macro results in an error

Versions

Elixir: use elixir --version
Erlang/OTP 26 [erts-14.2.3] [source] [64-bit] [smp:20:20] [ds:20:20:10] [async-threads:1] [jit:ns]
Elixir 1.14.4 (compiled with Erlang/OTP 23)

Styler: use mix deps | grep locked | grep styler
locked at 0.11.9 (styler) 8b7806ba

Example Input
defmodule Foo.Bar.TestModule do
  alias Foo.Module

  use Foo.Operation,
    type: :db_write,
    input: [
      module: %Module{},
      name: String.t()
    ],
    ok_return: %Module{},
    error_return: %Ecto.Changeset{}
...

Stacktrace / Current Behaviour
Gets re-written where the alias is below the use, and causes a compiler error

hey there, this is covered in the readme here
there's also an open issue on a possible perma fix in #137, so i'll close this as a dupe of that =)


Fixed: Adopt Me button Toggle Dark/Light Mode

Fixes #1224
Before-

After-

@akshitagupta15june
Please review and merge this PR
Also please add the labels of hacktoberfest-accepted and hacksquad

Someone is working on it


Module 2 exercises [George Owusu]

Please "drag & drop" exercise 1 pdf file below.
Module2_Ex1.pdf

Please "drag & drop" exercise 2 pdf file below.
Module2_Ex2.pdf

Please "drag & drop" exercise 3 pdf file below.
Module2_Ex3.pdf

Please "drag & drop" exercise 4 pdf file below.
Module2_Ex4.pdf

Please UPDATE THE TITLE of this "Issue" in the title bar above with your name.

If you haven't done so, please go back to Module 2 and make sure to take
the post-training survey. Participating in surveys is required for receiving
the "GALUP Certificate" by the University of Florida.

Well done, George. You clearly grasped the material outlined in Module 2 and successfully applied it to these exercises. Thank you for your participation! Please be sure to fill out the post-Module survey.


break not work well when exists more than one break point.

See following example:
require 'pry'
require 'break'

  puts 100
  binding.pry
  puts 200
  binding.pry
  puts 300

Following is debug process:
╰─ $ RUBYOPT='-I./lib -rpryx' ruby 1.rb
100

From: /home/common/Project/pryx/1.rb:5 :

    1: require 'pry'
    2: require 'break'
    3:
    4:   puts 100
 => 5:   binding.pry
    6:   puts 200
    7:   binding.pry
    8:   puts 300

[1] pry(main)> next

From: /home/common/Project/pryx/1.rb:6 :

    1: require 'pry'
    2: require 'break'
    3:
    4:   puts 100
    5:   binding.pry
 => 6:   puts 200
    7:   binding.pry
    8:   puts 300

[1] pry(main)> next
200

From: /home/common/Project/pryx/1.rb:7 :

    2: require 'break'
    3:
    4:   puts 100
    5:   binding.pry
    6:   puts 200
 => 7:   binding.pry                  # <= when break point reach here, will cause many times next to goto next line.
    8:   puts 300

[1] pry(main)> next
[1] pry(main)> next
[1] pry(main)> next
[1] pry(main)> next

From: /home/common/Project/pryx/1.rb:7 :

    2: require 'break'
    3:
    4:   puts 100
    5:   binding.pry
    6:   puts 200
 => 7:   binding.pry
    8:   puts 300

[1] pry(main)> next
[1] pry(main)> next
[1] pry(main)> next
[1] pry(main)> next
[1] pry(main)> next

From: /home/common/Project/pryx/1.rb:8 :

    3:
    4:   puts 100
    5:   binding.pry
    6:   puts 200
    7:   binding.pry
 => 8:   puts 300

[1] pry(main)> next                            # <= same above here.
[1] pry(main)> next
300

Following is same things when run with irb
╰─ $ RUBYOPT='-I./lib -rpryx_irb' ruby 1.rb
100

From: 1.rb @ line 5 :
    4:   puts 100
    6:   puts 200
    7:   binding.irb
    8:   puts 300

3.1.0 :001 > next

From: 1.rb @ line 6 :

    5:   binding.irb
    7:   binding.irb
    8:   puts 300

3.1.0 :001 > next
200

From: 1.rb @ line 7 :

    2: require 'break'
 => 7:   binding.irb
    8:   puts 300

3.1.0 :001 > next

From: /home/zw963/.rvm/rubies/ruby-3.1.0/.irbrc @ line 8 :

     3: # It also loads your custom ~/.irbrc if it exists.
     4: # If you want to customize the irbrc for ONLY this version of
     5: # ruby then edit this file. It will only be deleted if you do
     6: # an "rvm install" over this ruby version.
     7:
 =>  8: if ENV["rvm_path"].nil?
     9:   require File.join(ENV["HOME"], "irbrc")
    10: else
    11:   require File.join(ENV["rvm_path"], "scripts", "irbrc")
    12: end
    13:

irb(main):001:0> next

From: /home/zw963/.rvm/rubies/ruby-3.1.0/.irbrc @ line 11 :

     6: # an "rvm install" over this ruby version.
     7:
     8: if ENV["rvm_path"].nil?
     9:   require File.join(ENV["HOME"], "irbrc")
    10: else
 => 11:   require File.join(ENV["rvm_path"], "scripts", "irbrc")
    12: end
    13:

irb(main):001:0> next

irb(main):001:0> next

From: 1.rb @ line 7 :

    2: require 'break'
    3:
    4:   puts 100
    5:   binding.irb
    6:   puts 200
 => 7:   binding.irb
    8:   puts 300

irb(main):001:0> next

irb(main):001:0> next

From: 1.rb @ line 8 :

    3:
    4:   puts 100
    5:   binding.irb
    6:   puts 200
    7:   binding.irb
 => 8:   puts 300

irb(main):001:0>
irb(main):002:0> next
300

I know about this issue but I haven't been able to solve it so far.

There is another issue maybe related to this issue.
When use step into a method, the next next command is not move. following is a screenshot.


update

Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

!verified

Fix !bug

not a !bug

not a !un-bug

!verified

!verified


[WIP] CI Services

This is a work in progress PR which integrates CI services into building (and distributing) ITK, VTK, VMTK.
As the travis build currently timeout, this will likely go through a major refactor.

I'm merging this as all further development needs to have the secure tokens for the anaconda api enabled (which the ci services are blocking until this is part of the vmtk organization).


Refactor openssl.FIPS to support third-party FIPS providers

Our current openssl.FIPS implementation only works with the built-in FIPS provider, as it checks whether it is available or not to determine if FIPS is enabled, which precludes using other FIPS providers.
This PR removes the OSSL_PROVIDER_available(nil, "fips") check from openssl.FIPS so it is not tied to the built-in provider.
The new implementation should be as good as the previous: if EVP_default_properties_is_fips_enabled returns 1, we can be sure that only providers matching the fips=1 property will be used, so we can say that FIPS mode is enabled. To avoid breacking backwards compatibility, I've added an additional check that tried to fetch a SHA256 digets using the default properties (which should contain fips=1 at that point). If it succeeds, then it means that there is a provider that matches the fips=1 query.

@dagood I made up my mind a bit with this this PR. I was too much of a breaking change. I've added a provider-agnostic check so the new behavior is less disruptive. Please take another look.

@derekparker could someone from your team review this PR? Thanks!

@derekparker could someone from your team review this PR? Thanks!

Friendly ping. @ueno @derekparker

@ueno I will defer to you on this one, but from my perspective it LGTM.

@derekparker I'm merging this PR, as this is blocking some other work I have to do. Feel free to open an issue with any concern you have once your team have time to review it.


version 9.0.0 dependce @serialport/bindings 9.2.8

SerialPort Version
9.0.0
Node Version
16
Electron Version
8.5.5
Platform
Mac
Architecture
x86
Hardware or chipset of serialport
No response
What steps will reproduce the bug?
yarn add<EMAIL_ADDRESS>What happens?
dependencey
@serialport/bindings 9.2.8
it should be dependence @serialport.bindings 9.0.0
What should have happened?
integrated serialport 9.0.0
Additional information
No response

I think we addressed this in https://github.com/serialport/node-serialport/pull/2276
Unfortunately that wasn't in place for 9.0.0 but it should work for recent version numbers


Prepare cargo publish

Codecov Report

Merging #461 (65edd11) into main (5562501) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
- Coverage   91.07%   90.83%   -0.24%
==========================================
  Files         158      158
  Lines        9245     9244       -1
==========================================
- Hits         8420     8397      -23
- Misses        825      847      +22

Impacted Files
Coverage Δ

storages/memory-storage/tests/memory_storage.rs
100.00% <ø> (ø)

storages/sled-storage/tests/sled_storage.rs
100.00% <ø> (ø)

tests/glue.rs
73.07% <ø> (ø)

storages/sled-storage/tests/sled_transaction.rs
99.54% <100.00%> (ø)

utils/src/indexmap.rs
0.00% <0.00%> (-76.48%)
:arrow_down:

utils/src/vector.rs
51.72% <0.00%> (-31.61%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5562501...65edd11. Read the comment docs.


[Ubuntu 16.04] Already put encrypt.so but error not found.

I already put encrypt.so compiled for linux x64 in the project folder alongside with pokecli.py but still got errors

where did you get the encrypt.so?

Same for me. I downloaded encrypt.so from https://slack-files.com/T1U6G9ZEW-F1YV50RGQ-cc979942b7

@DragoonZ same as @MarianoCordoba. from pinned slac item

I think you have to compile it by yourself, do you know where to find encrypt.c?

Same for me.
Where to find it ?

got it from here
http://pgoapi.com/

.__. have no idea how to compile it

how to compile pgoencrypt.tar.gz?

@eatchie : make

Install gcc, and then run "sudo make" in the src directory

but i have download & compile it... but not work !

I'm getting when try run " Exception while downloading map: Odd-length string" @Happyrain67
You?

ok compiled. but still not work. same error

Shouldn't do sudo make. make should be sufficent.
@Happyrain67 Pull this fermuch's master and use it until his PR ( #2643 ) is approved.
https://github.com/fermuch/PokemonGo-Bot

If you downloaded encrypt.so from one of the links in these comments, verify that it's actually executable with "ldd encrypt.so".  I discovered I had a bad file this way, and once I got the correct file, everything started working.

@LHagood

@louisgv : yeah i'm in Root ;) Thank you for this link, i see & try it !
I have same "ldd" of @earthchie ..  ;)

@LHagood I get not a dynamic executable. What link did you use to pull in encrypt.so?

I got the link from the slack discussion.  There are several links to various versions of the file for different OSs

Try this link:  https://files.slack.com/files-pri/T1U6G9ZEW-F1YVDQB39/download/encrypt.so  I think this is the one that worked for me Ubuntu 64bit

@LHagood doesn't seem to work for me still. I will spin up an Ubuntu machine and see if that helps.

in pokemongo_bot/init.py
change self.api.activate_signature("encrypt.so") to
self.api.activate_signature("./encrypt.so")

thank you all!

same here

Compiled the files. Renamed libencrypt.so to encrypt.so
Kept it in home directory of bot. Got the following error.
Traceback (most recent call last):
File "pokecli.py", line 493, in
main()
File "pokecli.py", line 127, in main
report_summary(bot)
File "pokecli.py", line 136, in report_summary
metrics.capture_stats()
File "/mnt/c/Users/prana/Desktop/Bot/Updated/pokemongo_bot/metrics.py", line 76, in capture_stats
response_dict = request.call()
File "/mnt/c/Users/prana/Desktop/Bot/Updated/pokemongo_bot/api_wrapper.py", line 106, in call
result = self.call()
File "/mnt/c/Users/prana/Desktop/Bot/Updated/pokemongo_bot/api_wrapper.py", line 63, in call
return PGoApiRequest.call(self)
File "/mnt/c/Users/prana/Desktop/Bot/Updated/src/pgoapi/pgoapi/pgoapi.py", line 209, in call
request.activate_signature(lib_path)
File "/mnt/c/Users/prana/Desktop/Bot/Updated/src/pgoapi/pgoapi/rpc_api.py", line 82, in activate_signature
ctypes.cdll.LoadLibrary(lib_path)
File "/usr/lib/python2.7/ctypes/__init.py", line 443, in LoadLibrary
return self.dlltype(name)
File "/usr/lib/python2.7/ctypes/_init.py", line 365, in init
self._handle = _dlopen(self._name, mode)
OSError: encrypt.so: cannot open shared object file: No such file or directory

Oh my god ! It's Working !!
@louisgv : Fermuch's master work !
@DragoonZ : Switch this string work !
For encrypt.so i have compile source file of pgoapi.com
But... Where is the coloring in the console ?? =D =D =D
it's soo evil =)

thx its working for me :)

Thanks, all. Got it working.
To get the program to load the encrypt.so, either use fermuch's build or manually change the line in pokemongo_bot/init.py as follows:
self.api.activate_signature("encrypt.so")
to
self.api.activate_signature("./encrypt.so")
To install encrypt file (Linux version):

Visit the Official API site to pull the tarball
Extract tarball (tar -xf )
Enter directory /src
Run 'make' (requires gcc and make)
Copy libencrypt.so to target directory
Rename libencrypt.so as encrypt.so
Run the bot as normal

Appears to be working on Ubuntu 16.04. Spinning pokestops, catching pokemon, the works.

change self.api.activate_signature("encrypt.so")  =>
self.api.activate_signature(os.path.abspath("encrypt.so"))
work for me
os: ubuntu 16.04


Ephemeral materialization not working as expected

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Running sql query with ephemeral materialization returns nested WITH clauses.
WITH  dbt__cte__name__ as (
WITH
source AS (
SELECT * FROM foo_schema.foo_table
),
Expected Behavior
The expected behavior is a linear, not nested, list of CTE clauses.
Steps To Reproduce
No response
Relevant log output using --debug flag enabled
No response
Environment
- OS:
- Python: 3.10
- dbt: 1.3.2rc1

What Oracle database version are you using dbt with?
No response
Additional Context
No response

@nadialloppi
dbt's ephemeral materialization is meant to be nested
With Oracle, typically, nested WITH statements raise  ORA-32034: unsupported use of WITH clause You can read more about the error here
To make ephemeral materialization work, one option is to remove the WITH keyword in the model definition. Please refer an example epehermal model  which is also used in a second model  both included in this repository
This is the reason why ephemeral models is not yet a supported feature of dbt-oracle

@nadialloppi
Did you get a chance to try the work around as shown in the example ?
Let me know if you have any questions
Thanks


Search Returns Results Listing Books

Search Returns Results Listing Books
User Story
AS AN avid reader
I WANT to search for new books to read
SO THAT I can keep a list of books to purchase
Acceptance Criteria
GIVEN a book search engine
WHEN I am logged in and enter a search term in the input field and click the submit button
THEN I am presented with several search results, each featuring a book’s title, author, description, image, and a link to that book on the Google Books site and a button to save a book to my account

Searching for books while logged provides the option to save a book through the use of the save button.


Clean up metadata info for timeout requests in NetworkClient

We have two time out for a request. One at the networkClient layer where in we timeout incase we couldnt get a connection. Another one is at the OperationManager layer where in we timeout if we dont get a response after sometime(in other words, we haven't got the response in time even though the request was sent out). In later cases, the operationManager don't inform the NetworkClient regarding the timed outones. NetworkClient might be holding some unnecessary data for those requests even though its a no op. So, creating this ticket to do those cleanups.

Not sure what this is about. NetworkClient does not hold on to any information regarding a request forever. Requests are either handed over to the selector (if there is a connection available) or timed out (if they remain in the queue for too long). When they time out, a ResponseInfo is constructed and returned to the caller.
I don't see an issue here.

@nsivabalan could you either close this or provide a concrete reason to keep this?

@nsivabalan ping.

I haven't went into all the details. But to my knowledge, connectionIdToRequestInFlight will contain in flight requests. Lets say the Manager times-out for this operation(which has sent out this request) and closes the operation, how will the NetworkClient know that this(connectionIdToRequestInFlight) needs to be cleaned up.

See my earlier comment.
This is not how the NetworkClient works. It takes in requests. Once it get them it does not allow for "canceling" requests. As for the callers, a request given to the NetworkClient is as good as sent.
Similarly, if the selector is provided a NetworkSend, the selector does not care if the caller later changes its mind. Anything handed over to the selector is as good as sent out over the network.
Basically, once you hand over a request or response to the Network layer it is as good as sent out over the network. You can't change your mind. This is true in general for any system where the network layer is cleanly separated from operation layers, not only for Ambry.

If I understand this issue correctly, the problem as stated might be a non-problem. The NonBlockingRouter (which is what I assume you mean by "managers") should not have to tell the NetworkClient anything.
Also, I'm not sure why the question of "cleaning" up arises at all considering that for the NetworkClient, the request is actually still in flight. The actual problem here, I think, is to decide whether we want a request timeout at the NetworkClient. For now, I don't see the utility of doing so because the connection is useless anyway - we can't send any more requests using the connection unless we receive a response for the previous one.
To find out if this is a problem, we can track the size of the connectionIdToRequestInFlight map using a Gauge and also record how long each request spends in the map ("age"). In addition to removals in the happy path, we remove everything from the map even on close() and record the age of each entry. The 99th percentile will then tell us if something has been stuck in the map forever.
What do you guys think?

The NetworkClient either times out trying to checkout a connection to send the request, or simply hands over the request to the Selector. In addition, today it has to make sure that the connection does not get reused until a response is received for that request. We could add metrics to see how long a connection remains "in-use", sure. Siva probably has that already in #331.
The NetworkClient is just a liaison between the router and the selector. The Selector is the one that should ensure, if at all, that the request gets sent out or times out, as it is the one that should "disconnect" a connection.

Agreed.

yep, I agree as well.
On Wed, May 25, 2016 at 2:59 PM, Gopalakrishna Holla <
<EMAIL_ADDRESS>wrote:

Agreed.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/linkedin/ambry/issues/325#issuecomment-221720877

--
-Sivabalan
Data Infrastructure Engineer

Will close this - as discussed any requests that need to be timed out should be done at the Selector if we decide to go that route.
A helpful [link] (http://stackoverflow.com/a/17341089/5501399) on SO.
One of the comments on the answer

Sure but you can't do that directly in case 1. You would have to keep track of the last read time for each channel and manipulate the select timeout so that the least recently read channel's timeout will expire if nothing happens, check all channels for timeouts, etc.


Ears' wings don't hide vanilla elytra

Skins with wings and wing animations enabled don't hide vanilla elytra on forge
Versions

Minecraft: 1.18.2
Forge: 40.1.47
Ears: 1.4.5

Example Skin

Old topic but I also want to confirm that this bug exists on Fabric, Minecraft version 1.20.1, mod version 1.4.6.
I see that a fix has been added to the 1.5.0 milestones so I don't know how helpful it is to know that this bug exists on both modloaders but thought I would make a note of it just in case.

Bumping to confirm still an issue on Forge 1.20.1, mod version 1.4.6.


The template is for some other application type

The template is for some backend rest application and seems to be referencing a non-existent git repo.
Would be very nice to have a template for webapp.

We moved all our starter applications into a new GH org, and it looks like we missed an update.
There is a web app template/application here:  https://github.com/nodeshift-starters/react-web-app
i'll also update that file


no 'etag'

@road2stat in your test, is the upload return a 'etag' in the headers?

find a solution, in branch easy_api, File$upload

fixed in master, but probably need to export the helper function as well.


Why is docstring font so huge in scipy?

A huge chunk of the docstring is missing, and what shows up in vscode is mostly the useless part.

When I peek the docstring, I get this:

Duplicate of #1127.


Mochie Uber is missing smoothness and packed detail workflow compared to Mochie Standard

After switching one of my materials from Mochie Standard to Mochie Uber hoping for more granular control I found that its not possible to get 1-1 conversion.
Features missing from Uber that are present in Standard:

No option to swap roughness/smoothness.
No option to use a packed map in the detail section ("workflow" dropdown is missing)

These shaders aren't meant to be a 1-1 conversion of each other. One is for avatars and one is for worlds. I do plan to add a smoothness toggle to uber, but the detail workflow options is too many extra keywords for an already keyword-heavy shader.


[resolvers] use proper %-encoding of authority by default

Change the ResolverFactory::GetDefaultAuthority() method to %-encode the authority by default, so individual resolver impls don't need to remember to do this.
Remove the hack in the xds resolver for setting the authority to everything after the last / character.
Change the unix, unix-abstract, and vsock resolvers to use a real authority instead of hard-coding to "localhost".

@markdroth Is there a spec for why we're making this change? Looks like this change is not expected from Kestrel server.

@XuanWang-Amos We had a cross-language discussion about this, and the argument was that because of the way that browsers encode URIs, the authority would never wind up having certain characters, and there is some existing library code out in the wild that doesn't handle this well.  @ejona86 @dfawley
What is the exact case that is causing a problem here?  What resolver is being used, what character is being %-encoded, and what server is unhappy with that?

Oh, looks like the issue is #34305.
If the C# server is not liking the %-encoded character, then the client can override the authority by setting the GRPC_ARG_DEFAULT_AUTHORITY channel arg when creating the channel.

I see, thanks for the info, looks like this is expected then.

I don't know of any reason why using a % there is illegal.  I suspect the C# server is just being too picky.  But feel free to follow up on that in #34305.

I thought this was a gRPC-C# server, but it looks like it's a third party server implementation that we can't do anything about directly.