Getters and Setters with ECMAScript

Hi
We have a issue when trying to run the compression with getters and setters
get isMobile() {             //return true or false             },
I see there's a fix for this problem in the yui compressor version 2.4.8
https://github.com/yui/yuicompressor/releases
Is there any plan to upgrade this?

Can you provide an exact link, please. As in, a link to any commits or patches. Or submit a PR?

I'm also affected by this. the following code produces a "missing : after property id" error:
var test = {
    get testProperty() {
        return 42;
    }
}

I don't know how this is fixed in 2.4.8, as I have YUICompressor.NET 2.7.0 and still get this.

Hello
The original poster is referring to the java yuicompressor, not to this port.
I suspect the ecmascript parser isn't handling it rather than the compressor per-se.
Would you like to submit a PR to fix this?

I'm not familiar with your code, so I wouldn't know how to fix it.

Hi Apologies for the late reply, we had other pressing matters to attend to and work seemingly blocked my email from receiving response.
I've relooked at this issue it's as what Tshai said and yes it is the ECMAScript parser does not recoginise Getters and Setters.

This is also impacting our code as well.  Unable to utilize getters and setters as described here:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Working_with_Objects#Defining_getters_and_setters

It is an issue with the ECMAScript parser so you need to raise it there: https://github.com/PureKrome/EcmaScript.NET
Also, feel free to familiarise yourself with that code and submit a PR to that repo to fix it

@PureKrome I think this issue should be closed here since it is not a YUICompressor issue - thoughts?

Hmm ... maybe lets keep this open because i'll probably need to update the dependency version and then push out a new version here.
Urgh...... Don't even know if I can fix the EcmaScript code unless I have some pretty good links to the fix in the original source :/

@freeranger I will try and take a look at the code over there but it will be a week or so before I'm able.  For now I've used the Object.defineProperty syntax and it's happy with it.  Thanks for the quick replies and hopefully we can work towards an update to support getters and setters!

Maybe I can also update the package to .NETStandardBannana or whatever is the recommendation these days.

If the graph you posted here still stands: https://github.com/YUICompressor-NET/YUICompressor.NET/issues/22 then you would be cutting out a wide section of the potential audience since .NETStandard doesn't seem to be available on Windows 7: https://github.com/dotnet/standard/blob/master/docs/versions.md
If you made it target multiple frameworks then we could support .net 2/4/core/standard/whatever is next.

Fixed in #33 - I feel like the issue might be related to the other ECMAScript repo. If so, ping that repo or we can reopen this issue.


Proposing we not reload when the dev mode websocket is unavailable

Is your feature request related to a problem? Please describe.
There are a number ways the dev mode websocket on port 24678 can get broken. When you're running through various layers of proxy for SSL termination and authentication, and dealing with machines on different network fabrics, it's quite possible to just not have that working for whatever reason. In my case, our dev workstations are only reachable from our laptops via this crazy proxy and Chrome extension, and I was able to get the websocket working with the right SSH tunnel setup but I can certainly imagine others not being able to.
If you can't get the socket, falling back to just manual reload seems a lot better and more graceful then an infinite reload loop as we currently do.
I thought I could simply disable HMR with kit.vite.server.hmr = false in svelte.config.js but that didn't seem to do anything. But ideally you could leave it enabled, then if it can find its socket you get HMR otherwise you get Ctrl-R.
Describe the solution you'd like
I'd just like to disable the reload feature upon websocket failure. If it didn't work the first time, it's not going to work the second time. The auto reload isn't helping anybody.
Describe alternatives you've considered
If I knew the right way to disable HMR that would be helpful, but I'd still be in favor of this proposal.
How important is this feature to you?
Medium.

I'd be happy to send a pull request of course.

The retry logic is within Vite's client code, which incessantly tries to connect to the server's web socket when there's a connection failure.  SvelteKit doesn't have control over this behavior.
There isn't any code in the Vite client code that accesses the server.hmr.false flag.
There's an existing open issue: https://github.com/sveltejs/kit/issues/844, which addresses the constant reloading when using a self-signed certificate.

I'm not a maintainer, but, yes, I think you should close this issue.  #844 addresses the SvelteKit side of this issue.  And, it's been classified as a "Milestone 1.0", so the issue should be resolved once the official 1.0 version is released.

Duplicate of #844


0.3.0 h69481f

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[X] Reset the build number to 0 (if the version changed)
[X] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

Supersedes #3

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@chrisjsewell @anirrudh Can you please take a look at this PR? Thanks 😄

@chrisjsewell @anirrudh This PR is blocking two downstream PRs, can you take a look? 😄

@conda-forge-admin, please rerender


Question: Aeron between data centres

Hi, thanks for Aeron.
I want to use Aeron for service requests between processes that may be deployed in different data centres in different countries. There are restrictions that limit communications to TCP rather than UDP and ports are tightly firewalled. In the Aeron overview TCP is mentioned as a possible transport for Aeron. Is this feature ready? Or can you make an alternative suggestion for inter-process service requests via Aeron?

We do not have plans to support TCP for Aeron streams. TCP in many ways goes against the spirit of Aeron. I'm not sure how we gave the impression that was going to be supported? Is there some source we need to correct?
For sending between data centres then a gateway and tunnelling solution would be best, if UDP cannot be routed. We have discussed building such a gateway with some clients that would tunnel Aeron streams down a TCP connection. So far these have only been discussions. If you would be interested in sponsoring such a feature then we can discuss it. The buffering and connect requirements are different for such situations compared to UDP on a LAN.

I may have misinterpreted the information on https://github.com/real-logic/Aeron/wiki/Protocol-Specification where it says:
"The Aeron protocol is designed to be run directly over many different types of transmission media, including shared memory/IPC, InfiniBand/RDMA, UDP, TCP, Raw IP, HTTP, WebSocket, BLE, etc. This means that the following assumptions are made:
Transmission Media may be a stream media, such as TCP or RDMA without inherent frame boundaries.
........."
I will talk to my employer about the gateway tunnelling possibility although it is a longshot.
Thanks nevertheless for the innovations the team has achieved with Aeron. It will be big!

Probably should tighten up the language in the spec. The intent was to define media very broadly. Should narrow it down now.


Need a method to set serializer for JobRepository and JobExplorer

There's a bug described here with databases like postgres and sql server that requires setting the serializer on the JobRepositoryFactoryBean and JobExplorerFactoryBean to Jackson2ExecutionContextStringSerializer.  I don't see a way to do this via TaskExecutorBatchConfigurer other than overriding much of it.

@brunnels Due to cleaning up issues list: Is this custom serializer needed any more?

I need this feature. Our jobs are not restartable and we pass large objects between steps. Some of them are job scope and behind GCLIB proxies (obviously they cannot be recreated by Jackson deserializer).
This piece does great job to disable "enterprisy" feature of Spring Batch:
public class FakeSerializer implements ExecutionContextSerializer {
    @Override
    public Map<String, Object> deserialize(InputStream inputStream) throws IOException {
        return new HashMap<>();
    }
    @Override
    public void serialize(Map<String, Object> object, OutputStream outputStream) throws IOException {
        outputStream.write("fake".getBytes(StandardCharsets.US_ASCII));
    }
}

As @brunnels has written it is impossible to inject FakeSerializer without coping entire implementation of BasicBatchConfigurer or similar.
All implementations of BatchConfigurer don't share any code except rudimentary JpaBatchConfigurer ((

Implemented with 65ce01a0a99a0abefad2b7e44bf7c719d95cdfef
Just add bean of type ExecutionContextSerializer in your Spring application context.


Added web server support via gulp

Added gulp support as an option so easy to get started

sorry bug, resubmitting


Adding data-parallel window graph aggregation

@vasia I added a windowAssigner-agnostic slice method to GraphStream / SimpleEdgeStream, hoping to generalize slice for both use cases (see here), but much of the existing logic revolves around neighborhoods, and is apparently spread across a couple classes. I'll open another issue to discuss refactoring it.
I started over and hacked together a non-reducing connected components sliding window example in a unit test, using only the DisjointSet implementation from gelly-streaming (see here). This essentially reproduces most of WindowGraphAggregation with a No-Op reduce step.
I now (again) think PR #25 is the best way forward for these sorts of non-reducing window folds. What do you think?
As an aside, I think there's probably a more powerful abstraction underneath WindowGraphAggregation (other than GraphAggregation), but I'm not sure what to call it. EdgeStream -> distribute edges uniformly -> apply an arbitrary window -> local fold on each graph partition-window. For global connected components aggregation, add a reduce step at the end.

Hey @drfloob!

The sliding window aggregation addition is pretty fine! Note that we deliberately restricted graph slicing to tumbling windows in the beginning as a means of "snapshotting" distinct graphs in all its simplicity and due to the fact that there is no sophisticated sliding window aggregation implementation yet on flink (apart from typical time window pane slicing).

Regarding  window aggregations, their purpose is to produce a global metric, thus, we have to reduce the synopses/local computation results in one place and produce this metric. What you have in mind, seems like a data parallel window aggregation, correct? In that case, you propose to remove the final merge/reduce. Sounds cool, performance wise, but what is the usage that you have in mind?

Keep in mind that we are planning to apply big changes to the core GraphStream API soon, thus there is high chance that we will remove some existing functionality there.  Maybe it makes sense to keep core API things in a separate branch and we will try merge once GraphStream v.2 is in. Algorithm implementations on the other hand are definitely more in need right now and they will surely stay in the library even after the remake no matter what (so they are more of a certain bet). Can you think of any missing graph algorithms? If yes please open a discussion and we will dive in :)

Big thumbs up for the interest btw!

Hey @senorcarbone! Excellent explanations, I appreciate it. You're right, what I have in mind is essentially a "data parallel window graph aggregation". My use case is finding clusters of collaborators and their indirect networks from GitHub event data as it's happening, for live community metrics and collaborator recommendations. My slides aren't finalized, these may help you get a feel for the idea: drfloob.com/pulse/slides. The big picture is that "whole-world" computations can be run in batch offline, and that low-latency graph snapshot analysis of recent activity can provide an interesting context in which to interpret those batch results.
I wasn't aware of the v2 changes, I'll have to take a look at that branch. Sounds exciting!
I totally get the original intention for window graph aggregations, that they were meant to produce a global metric, hence the tight coupling to tumbling windows. It's also fairly straightforward to modify it a bit to support both global and window-local use cases (hence this PR), which makes it a much more powerful abstraction IMHO, and doesn't hurt otherwise :-). To implement this feature in gelly-streaming, outside of WindowGraphAggregation right now, I think would either duplicate a bunch of code or require refactoring out a new base to both classes.
I'd love to see a distributed min-cut / max-flow algorithm. I found a few papers for potential implementations, but it'll be a while before I have a chance to work on it.
P.S. I'm interested in what you think a sophisticated sliding window aggregation implementation would look like. Would it involve retractions (from the Dataflow paper)?

Very interesting slides @drfloob and cool use case! I like the way you think :)
Regarding your use case, you might not really need a window aggregation after all, you could simply do a continuous keyed aggregation on the github events (i am assuming that you already partition your stream by some attribute otherwise you have to stick to the global aggregation solution). For example, you keyBy the github event type (fork, PR, etc) and then you create a CC summary per key which is defacto parallel.
Now for implementing the parallel window aggregation I would suggest you create a new ParallelWindowGraphAggregation and simply wrap the WindowGraphAggregation (without changing the existing implementation) and simply pass a NoOp Reduce in the end. That, I think we can easily merge and there will be no conflicts with the changes we are going to add.
Teaser: Gelly-Stream v2 will allow you to run BSP iterative algorithms on graph streams. So probably anything related to windows among others will be changed. This is of course part of our research so we cannot share yet all the internals (we got to take a phd at some point :P )
Please create a new Issue on the Min-Cut/Max-Flow Algorithms (with citations) that you have in mind and we discuss it there. Sounds promising 👍
On sophisticated sliding window aggregation: it means that you do not aggregate too many times the same thing (>log(numOfBuckets)). There has been extensive work on this, unfortunately in sequential stream processing and not so much in out-of-order processing. Currently, most systems apply panes but there is also pairs and higher-order sliding window trees for efficient aggregation sharing. Here is some recent work from side. That is just to give you an idea of what I mean. There are some groups that are already working hard on applying some of these ideas to out-of-order processing so we will probably see a Flink-compatible efficient aggregation soon.

@senorcarbone The same "BSP" as is in Google Pregel, yes? Very neat! Please send me a link to your dissertation when it's finished, I'd like to read it. And thank you for the links! I had no idea there was so much more potential for sophistication in sliding windows, I look forward to digging in.
In my project, I've simplified the problem to assuming that any kind of github event is as good as any other for the purpose of suggesting collaborators, so the type of event is stripped away. And I really am interested in just the graph formed over the past  , with an N/5 slide to show change over time. The global aggregation hasn't been a bottleneck, actually. I'm pushing 15,000 records / second, of which about 2000 on average make it to Flink due to filtering, and gelly-streaming chugs along nicely. It's been great.
I'll be glad to give you a patch that's easier to merge. From an engineering perspective, deep nesting is a code smell that should most likely be solved with composition, and it's especially bad when there's no intention of utilizing the inheritance in a "ParallelWindowGraphAggregation is a WindowGraphAggregation" context (see The Liskov Substitution Principle).
My current PR essentially adds 2 very thin constructors to an existing class, which solves the problem well with very little code, and is fully backwards compatible. I can clean up the PR a bit to make that more clear if you'd like. If this is difficult to merge due to future plans, I think the lesser of two evils (code duplication vs deep inheritance) is code duplication, so I'd opt to create a new class parallel to WindowGraphAggregation that is essentially identical. But I hope the more elegant solution will be accepted :-). Do please let me know.
I'd also be happy to brainstorm around the challenges these changes present, if you'd like. Regardless, I think this is a powerful addition; I'd like to see this feature merged in whichever form it needs to be in.

@drfloob thanks for the clarification, even though...I got a bit confused now.
I thought your initial PR is unrelated to what we are discussing here but I guess I am wrong, sorry about that. I simply skimmed through it (we really need to find some free time to review it properly) but I think that was only about adding general window assigners instead of restricting to time windows. For that case, simply putting additional constructors is ok I guess.
Let's limit this to the parallel aggregation to avoid confusion. In your example you seem to produce connected components per partition. Talking in Map Reduce terms it is similar to skipping the shuffle+reduce in a map/combine-reduce job and simply writing down the results of the mappers/combiners. That means that when a window triggers, a seperate DisjointSet is being written to a file, per partition. How do you use exactly the result of that partial computation?

@senorcarbone  Sorry, I fundamentally misunderstood what was going on. it hadn't dawned on me that these windows were emitted per partition. I thought the windows ended up being global despite the partitioning, due to the flatmap that joins the streams at the end. These results are not so useful. Thank you for helping me understand, I closed the PR. This issue should probably close as well, since it's based on the same misunderstanding.
For what it's worth, after realizing my mistake, I found ParallelMerge for ConnectedStreams which seems like it performs the sort of window merge I need, but I haven't been able to determine if it's applicable to keyed/partitioned window streams yet.

No worries! The Flink API still has a lot of improvements to go and can be confusing at times.
Don't hesitate to start new discussions for contributions, especially on adding new algorithms. I think that are lots of cool things to do there.


how to add custom marker add when cluster expanted

how to set custom marker using cluster..instead of default marker..
thanks in adavance...

This is an open source project. Please feel free to add appropriate extensions to the codebase to enable this capability.


Add more IA tag support

@mparent61 @spra85 @benghaziboy @collin

@spra85 adding in subhead stuff now

👍

LGTM

Coverage remained the same at 85.784% when pulling<PHONE_NUMBER>b29f6519d1e1aa82c07ccfc72b9fb9 on new-ia-tags into 88cf2eb71fe338d2aae48cb11b548bd96c64f063 on master.

👍

Coverage remained the same at 85.784% when pulling<PHONE_NUMBER>b29f6519d1e1aa82c07ccfc72b9fb9 on new-ia-tags into 88cf2eb71fe338d2aae48cb11b548bd96c64f063 on master.

Coverage remained the same at 85.784% when pulling<PHONE_NUMBER>b29f6519d1e1aa82c07ccfc72b9fb9 on new-ia-tags into 88cf2eb71fe338d2aae48cb11b548bd96c64f063 on master.


Generate interfaces for structs alongside existing struct types

PR https://github.com/dethcrypto/TypeChain/pull/700 changed how struct types are generated. I've been importing these structs (before the properties were wrapped by PromiseOrValue<T>) to help me type check inputs in hardhat tests.
Perhaps alongside the existing struct types you could provide an interface type also:
export interface Foo {
  a: BigNumberish;
  b: BigNumberish;
};

export type FooStruct = {
  a: PromiseOrValue<BigNumberish>;
  b: PromiseOrValue<BigNumberish>;
};

export type FooStructOutput = [BigNumber, BigNumber] & {
  a: BigNumber;
  b: BigNumber;
};

maybe generating PromiseOrValue<T> vs T should be done behind a flag? If PromiseOrValue<T> is possible in ethers it does not mean that it's good(like it is possible to write {} + [] in javascript but it does not mean that it's good code).

PromiseOrValue seems to have caused inconvenience for a lot of people. I'd incline towards getting rid of it if we can't have it behind a flag.

@zemse is getting rid of PromiseOrValue still the plan? I've been hoping for that to happen given how wide the impact is, but if not, I guess I better get to fixing those 127 type errors this change introduced 😓


RuntimeError: The size of tensor a (4) must match the size of tensor b (18) at non-singleton dimension 1

I have 18 classes using the cityscapes dataset, and I used to train my own images but I get this error from the Dice loss function at this point:
tp = torch.sum(targets*preds, dim=(2, 3))
RuntimeError: The size of tensor a (4) must match the size of tensor b (18) at non-singleton dimension 1

To use the dice loss, your label shape should be in shape [B, C, H, W].
check here https://github.com/sithu31296/semantic-segmentation/blob/main/utils/losses.py#L62.
So, you have to prepare the label image in a color coded channel instead of the individual pixel being a class number.

My label shape is in [B,C,H,W]. However, my label shape is [B,4,H,W] and the prediction gives [B,18,H,W]. How do I approach this?

You need to convert the label image to one-hot channel [B, num_classes, H, W] to get the same shape as in model prediction.
See the code below:
label = torch.randint(0, 255, (224, 224, 3))
out = torch.zeros(19, 224, 224)
colors = torch.tensor([[random.randint(0, 255) for _ in range(3)] for _ in range(19)])
for i, color in enumerate(colors):
mask = torch.eq(label, color)
cls_map = torch.all(mask, dim=-1)
out[i] = cls_map


Improve the feel of the toy demos

The demos currently feel slow. Do a quick pass to improve the feel and look of the demos, using simple visuals.

@razcore-art for the UI widgets you could make some reusable container or bit of interface that's shared between all demos. Also use sliders for values instead of LineEdit. Or something easier to tweak and control at least.


Option for Default Speed

Although Youtube persists a speed setting per session, it always gets reset to 1.00 if the tab is ever closed.  And if the playback speed is ever changed on a video, that becomes the new default for subsequent videos (and then has to be changed back).
Similar to Default Resolution, this setting would define the starting speed of videos.

Thanks, that's perfect!  I overlooked that setting.


Adding the possibility to group on an object

Thanks for a great lib.
With this PR it is possible to take objects as input for groupBy.
It simply uses Object.values in case the input list is not an array.
e.g:
"posts": {
    "4acad4c5-d853-43ce-ad2e-bb9990062dd5": {
      "guid": "4acad4c5-d853-43ce-ad2e-bb9990062dd5",
      "title": "Foo",
      "body": "....",
      "date": {
        "year": 2014
      }
    },
    "cdce485a-7f85-4f8a-8193-b7feda65c423": {
      "guid": "cdce485a-7f85-4f8a-8193-b7feda65c423",
      "title": "Bar",
      "body": "...",
      "date": {
        "year": 2014
      }
    },

EDIT: I replaced Object.values to match old node version.

Coverage decreased (-0.5%) to 89.474% when pulling 524fd1e61445b1278f7da5fd6b53d595a9525dbb on jonasalfthan:master into bd3e48f787ea253b8beaec6145b9151b326bcb32 on shannonmoeller:master.

Thanks for the PR! Feature makes sense. Will review soon.

@shannonmoeller Any update on this? :) It would be very helpful to have support for grouping on Object as well as arrays.

@shannonmoeller: any updates?

@shannonmoeller also interested, thank you for the awesome helper by the way!


USA parts list: power supply warnings

Raspberry pi 3b+ running fine with warnings Argon ONE power supply isn’t good enough.
Can someone recommend a more stable PSU?

I am not from the US, so I was never able to test the Agron ONE. This power supply promises a good performance for the RP3: https://www.amazon.com/Raspberry-Micro-USB-Charger-Raspberry-Pi-Adapter/dp/B00L88M8TE
If you can test it and let us know that would be great. If its not giving warinings on the stress test REPAIR->HARDWARE I will use it for future shopping lists. Thx.

Thanks I will purchase and provide feedback.

That looks nice... Looking forward to jarheadius' feedback.
The one I bought works most of the time, but can't really keep the juice up over long periods of time: https://www.amazon.com/gp/product/B07FY9G348/ref=ppx_yo_dt_b_asin_title_o00_s00?ie=UTF8&psc=1
After it's been running a couple of days I always get the "Weak power supply detected" message, and the hardware test shows it's erring on the weak side. It only had to power off once, and I didn't lose my channels so it's not the worst problem to have. I do love the in-line power switch on this model though.

New PSU is being used. It’s taken a week to resync with lightning so I hope to have update soon. Is this normal to wait so long to sync after only unplugging for 15 minutes?

Is it the sync where the blockchain is 100% but the LND % is actually counting backwards slowly? Try unplugging it and restarting the sync once or twice more. It usually take me two reboots, and one time a 3rd reboot to get past that problem. (Other tickets here talk about it.)

That’s exactly what it doing.
Thanks I will check the other thread.
From: Luke Parker<EMAIL_ADDRESS>Sent: Friday, September 20, 2019 10:42 PM
To: rootzoll/raspiblitz<EMAIL_ADDRESS>Cc: Jared Wilkins<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [rootzoll/raspiblitz] USA parts list: power supply warnings (#744)
Is it the sync where the blockchain is 100% but the LND % is actually counting backwards slowly? Try unplugging it and restarting the sync once or twice more. It usually take me two reboots, and one time a 3rd reboot to get past that problem. (Other tickets here talk about it.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/rootzoll/raspiblitz/issues/744?email_source=notifications&email_token=ANBXRYG2HTKCXMCDYO2FIWLQKWCXNA5CNFSM4ISUZSNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7IIZLA#issuecomment-533761196, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANBXRYHCOLBPHLDP2GNFRELQKWCXNANCNFSM4ISUZSNA.

New PSU tested and works perfectly. Thanks for the help.


The correct character width for titles, subtitles and footnotes is now hard to determine due to the fixed width/aspect ratio of graphical outputs

The fixed aspect ratio of plots, combined with the fixed height/width of outputs produced by save_e61() means that when a long footnote is included in a graph, the plot area shrinks, making the default title/subtitle/footnote character-based widths too large.
This is a trade-off between maintaining the figure's dimensions, the plot's dimensions, and the positioning of the text elements around the plot, because it is likely impossible to have all three. Are we happy with the current trade-off where the user is more likely to have to make use of the manual character width adjustments?

@elyse-22 Bugging you with this since you wanted to aspect ratio fix.


[bootstrap] Fedora 27 stable and git install tests failing

This is the exact same issue as #122, but for the Fedora 27 release.
Support for Fedora 27 is new to the test run I did today, so to create the job I just copied the Fedora 26 builds and then updated the cloud profile in the jenkins configuration.
I would start with the Fedora 26 builds first, then whatever fixes that issue will likely fix this one as well.

[ ] stable
[ ] git

Note that the script passes just fine when run manually, so it's something in the test setup that is causing problems.

bootstrap tests are no longer handled in this repo


Make builder tests tar commands compatible with mac in addition to linux

With bsdtar the '-O" option has to appear before paths to extract

bsdtar doesn't support --wildcards, but no wildcards were used with the --list command, so we removed it.

Signed-off-by: Eric Promislow<EMAIL_ADDRESS>

I just publicized my membership to CloudFoundry per the bot comment above.

Slack context: https://cloudfoundry.slack.com/archives/C02HWMDUQ/p1500936496108126
Not sure if it makes sense for these tests to run on mac. We don't CI against mac. I leave it up to @dgodd, assuming --wildcards is not important.

@lisamcho Is there a reason you wouldn't just run this inside a docker container? We have had several problems with this repo and the incompatibilities of mac vs linux and so I'm tempted to make the requirement of running on linux/windows more clear, rather than fix for mac.
If using docker doesn't fit your flow, I'm a happy to reconsider. If it does fit your flow, we should improve the README to make it clear that mac users should use docker (and how)

Closing with context: https://cloudfoundry.slack.com/archives/C02HWMDUQ/p1501002674108330


Better error handling in case the config is bad.

Should we have some sort of check when the web app starts?
i.e. look for this and this key, and if they don't exist, warn the user. do not forcefully close down the app though.

No, just read the installation instructions instead. They're actually good now.


Fixes weird serialisation problem we were having with an obsolete

Apparently, this happens when a non-obsolete has an obsolete as an alt_id.

Apparently, this happens when a non-obsolete has an obsolete as an alt_id.

what a weird bug!
Should we report it to Protege?

Not a protege bug.. Its just not legal "obo format" -> same happens when you use say ROBOT.


What is a race condition?

A race condition occurs when a program depends on the  timing of one or more events to function correctly. A race condition typically occurs when multiple threads access a shared variable (or state) at the same time.

Thanks for the new sample


[SPARK-38091][SQL] fix bugs in AvroSerializer

What changes were proposed in this pull request?
This PR aims to fix some runtime exceptions related to the Avro serializer.
SPARK-38091 includes information on reproducing the runtime exceptions that this PR would remove.
Why are the changes needed?
AvroSerializer's implementation, at least in newConverter, was not 100% based on the InternalRow and SpecializedGetters interface. It assumes many implementation details of the interface.
For example, in
      case (TimestampType, LONG) => avroType.getLogicalType match {
          // For backward compatibility, if the Avro type is Long and it is not logical type
          // (the `null` case), output the timestamp value as with millisecond precision.
          case null | _: TimestampMillis => (getter, ordinal) =>
            DateTimeUtils.microsToMillis(timestampRebaseFunc(getter.getLong(ordinal)))
          case _: TimestampMicros => (getter, ordinal) =>
            timestampRebaseFunc(getter.getLong(ordinal))
          case other => throw new IncompatibleSchemaException(errorPrefix +
            s"SQL type ${TimestampType.sql} cannot be converted to Avro logical type $other")
        }

it assumes the InternalRow instance encodes TimestampType as java.lang.Long. That's true for Unsaferow but not for GenericInternalRow.
Hence the above code will end up with runtime exceptions when used on an instance of GenericInternalRow, which is most of the case for Python UDF.
Does this PR introduce any user-facing change?
No. This PR is internal to Spark.
How was this patch tested?
There are newly added unit tests in this PR.

Can one of the admins verify this patch?

Hi @Zhen-hao. Thanks for your proposal.
Could you please open a JIRA ticket on our issue tracker (a reproducible examples will be welcomed) and edit the title of this PR accordingly (i.e. [SPARK-xxxxx][SQL] Here goes description).
Also, please enable GitHub actions on your fork (you can follow the instructions on the failed run).
Thanks in advance.

thanks, guys. I'll find some time this week, if not today.

cc @gengliangwang too FYI

@Zhen-hao , this PR contains many whitespace/formatting changes, making it very hard to tell where your actual changes are. Can you please revert such changes to make it more clear what logic you are changing?

Sorry for that. I run ./dev/scalafmt hoping to fix the linting errors. (I was surprised that it didn't fix all linting errors.)
Is it possible that we make formatting an automatic step in compiling and make sure the linting rules are consistent with the formatting rules?
Anyways, that should be a separate PR.

Left a few inline comments about specific implementation details, but I have a higher-level concern. I'm not confident that this is the right direction to be moving in. It seems that the problem is whoever created the GenericInternalRow put the wrong data type into the field. GenericInternalRow implements the SpecializedGetters interface, so getDecimal should work properly on it, right? If the Python UDF logic is putting a BigDecimal there, that seems wrong to me, because the implementation of BaseGenericInternalRow#getDecimal (which is used by GenericInternalRow) assumes that the field contains a BigDecimal. The Python UDF logic should either wrap the BigDecimal inside of a Decimal when storing the object, or use a subclass of GenericInternalRow which overrides getDecimal to wrap it on an as-needed in the getter.
LMK what you think.

I totally agree that this may not be the right direction.
But any fix should pass my added unit tests or produce compiling errors instead of runtime errors.
This is just my "easy" fix for some issue that we had with a client. We'd like to contribute back and/or make others aware of the issue.
If I were to have unlimited free time, I would remove all the OO designs and rewrite the whole Spark with typeclasses as it has been painful to work with type casts and interfaces containing Any, AnyRef, or Object.
I'll address your inline comments later.

Sorry for that. I run ./dev/scalafmt hoping to fix the linting errors. (I was surprised that it didn't fix all linting errors.)
Is it possible that we make formatting an automatic step in compiling and make sure the linting rules are consistent with the formatting rules?

No problem ... Totally agreed that the formatter and linting rules should be in sync. I'm the one who wrote most of the code that had the whitespace updated here and I usually assume that the linter will catch any issues :) I can put up a PR addressing the formatting issues.

Actually I'm not sure how we typically treat formatting-only PRs .. @HyukjinKwon or @dongjoon-hyun, do you know if we encourage/discourage formatting-only PRs to make code format match the expectation from ./dev/scalafmt? I vaguely remember something like that being shot down in the past, in favor of making Git history more readable.

@Zhen-hao Thanks for the first-time contribution. I find this PR contains a lot of unnecessary code changes. Can you clean them up?
Also, please follow the PR template
What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

hi @gengliangwang,
Thank you for reviewing this PR.
Those unnecessary code changes you mentioned were resutls of running ./dev/scalafmt.
That means the existing code on master was merged without running that command.
One way to fix it is to first merge a PR for formatting only, as hinted by @xkrogen

do you know if we encourage/discourage formatting-only PRs to make code format match the expectation from ./dev/scalafmt

@xkrogen @Zhen-hao In general we don't do that.
Instead, people follow https://github.com/databricks/scala-style-guide and create clean patches.

./dev/scalafmt is sort of a tool for easier dev ... but I don't think that 100% follow our style. We will have to manually add some changes to follow https://github.com/databricks/scala-style-guide for the time being.

intersting.
sounds like something that @lihaoyi can easily fix.
Meanwhile, I will do my best to revert the formatting changes.

lol @lihaoyi WDYT?

Just rebased on master and reverted the formatting changes.
It should be much easier to review now.

@Zhen-hao LGTM except two minor comments. Thanks for the fix!

I totally agree that this may not be the right direction.
But any fix should pass my added unit tests or produce compiling errors instead of runtime errors.
This is just my "easy" fix for some issue that we had with a client. We'd like to contribute back and/or make others aware of the issue.
If I were to have unlimited free time, I would remove all the OO designs and rewrite the whole Spark with typeclasses as it has been painful to work with type casts and interfaces containing Any, AnyRef, or Object.
I'll address your inline comments later.

Actually, could you provide an end-to-end Python UDF case?  It can be in the PR description instead of code changes.

I totally agree that this may not be the right direction.
But any fix should pass my added unit tests or produce compiling errors instead of runtime errors.
This is just my "easy" fix for some issue that we had with a client. We'd like to contribute back and/or make others aware of the issue.
If I were to have unlimited free time, I would remove all the OO designs and rewrite the whole Spark with typeclasses as it has been painful to work with type casts and interfaces containing Any, AnyRef, or Object.
I'll address your inline comments later.

Actually, could you provide an end-to-end Python UDF example? It can be in the PR description instead of code changes.

Good question. We didn't find the issue with the public Spark API.
We had a copy the org.apache.spark.sql.avro package in our code base becuse it is private to Spark and we wanted to build a layer on top of it to make a serialization/deserialization library. We didn't see the problem until we offered our Python users an Avro serialization UDF. We solved the issue first by letting Python users to use not the UDF but scala API via sc._jvm.
I don't know how to repduce the issue with the public API...
Again, the nature of the change in this PR is more about making the Scala code hermetic (or mitigate some leaky abstractions).
This PR doesn't need to be merged if there are better ways to improve.

I don't know how to repduce the issue with the public API...

At first, I thought there is such a case with the public API. It's my fault that providing code suggestions without confirming this.
Now, after second thought, I doubt whether there is a good reason to merge this one...

I don't know how to repduce the issue with the public API...

At first, I thought there is such a case with the public API. It's my fault that providing code suggestions without confirming this. Now, after second thought, I doubt whether there is a good reason to merge this one...

I would say it is up to the reviewers.
I don't want to spend more time to see if it is an issue for the public API, and it is fine with me if the reviewers decide to close this PR.
I'll be happy as long as there is a fix to this in the future.


BUG: Update _svds.py: orthogonalize eigenvectors from arpack to eliminate edge case failures with clustered eigenvalues and update docstring examples

Reference issue
Closes gh-11406, gh-16741.
What does this implement/fix?
As proposed in https://github.com/scipy/scipy/pull/16693#issuecomment-1193369299, copying line 297
eigvec, _ = np.linalg.qr(eigvec)
to before line 337, so that the postprocessing gets orthonormal vectors for arpack as well
This fixes all known issues with non-orthogonal output from ARPACK, including now giving correct both left and right vectors in gh-11406, so this check is added to the unit test.
As a free bonus, also updated and significantly extended the docsrting example, along the way fixing the bug gh-16741 as a part of it, which has affected every PR test in scipy.scipy (Main refguide_asv_check), e.g., see https://github.com/scipy/scipy/pull/14563#issuecomment-1200290619
Additional information
https://github.com/scipy/scipy/pull/16690#issuecomment-1193365725 observes three failures in the Azure jobs for https://github.com/scipy/scipy/pull/16693 prerelease_deps_coverage_64bit_blas, refguide_asv_check and source_distribution. The failure occurs when the test checks that vh @ vh.conj().T is approximately the identity matrix. It turns out that the ARPACK-based SVD solver does not guarantee that this condition is true when the inputs are complex and there is a repeated singular value.

The failures appear unrelated to this PR, so ready for review. @WarrenWeckesser ?

Ready for review. @WarrenWeckesser ?
May be I should add docsting examples to fully address https://github.com/scipy/scipy/issues/16741?

Reade for review and merge, IMHO.

While waiting for review, I have significantly extended the docsrting example. Hopefully, this PR gets attention, reviewed and merged...
There is still another significant issue to fix in svds: https://github.com/scipy/scipy/issues/16330 and one more https://github.com/scipy/scipy/issues/9284 on my potential 2do list but having to wait months for reviews of simple PRs makes it difficult for me to make progress...

Merging main in https://github.com/scipy/scipy/pull/16712/commits/6c0ce33c407745fb24c3626234105cec3f5281cf for unknown reasons broke the unit test  just for Linux Meson tests / Meson build (3.9, false) and Linux Tests / Python 3.8-dbg with similar assertion errors, e.g.,
__________________ Test_SVDS_LOBPCG.test_small_sigma2[float] ___________________
[gw1] linux -- Python 3.9.13 /opt/hostedtoolcache/Python/3.9.13/x64/bin/python
scipy/sparse/linalg/_eigen/tests/test_svds.py:832: in test_small_sigma2
assert_allclose(sp_mat.transpose() @ su, 0, atol=1e-5, rtol=1e0)
E   AssertionError:
E   Not equal to tolerance rtol=1, atol=1e-05
E
E   Mismatched elements: 40 / 40 (100%)
E   Max absolute difference: 1.86599573
E   Max relative difference: inf
E    x: array([[ 0.203688, -1.720899,  0.80937 ,  0.181332],
E          [ 0.65108 , -1.229791,  1.091333, -0.491714],
E          [ 0.662922, -1.068644,  0.857987,  0.083971],...
E    y: array(0)
dim        = 4
dtype      = <class 'float'>
m          = 10
mat        = array([[0.75358919, 0.99565464, 0.41765909, 0.84314278, 0.20050386,
0.2610654 , 0.20873058, 0.16266047, 0.0432..., 0.39618705, 0.43422147, 0.94440681, 0.11885702,
0.94011348, 0.26331356, 0.06472523, 0.04491724, 0.40666401]])
n          = 10
nz         = array([[ 1.57559235e-01, -2.12402361e-01,  1.86718224e-02,
3.10523488e-02],
[ 5.70754309e-02,  3.62896...15e-01,
-9.49710421e-01],
[ 6.57066007e-01,  5.12042595e-01,  3.81989377e-01,
-6.11934156e-02]])
rng        = Generator(PCG64) at 0x7FC7F0F13AC0
s          = array([4.54984232e+00, 1.21645441e+00, 1.05037971e+00, 9.20361726e-01,
5.73972786e-01, 4.00007789e-01, 9.63337173e-17, 5.98327270e-17,
1.76884573e-17, 1.62735323e-18])
self       = <scipy.sparse.linalg._eigen.tests.test_svds.Test_SVDS_LOBPCG object at 0x7fc81023d220>
size       = 10
sp_mat     = <10x10 sparse matrix of type '<class 'numpy.float64'>'
with 100 stored elements in Compressed Sparse Column format>
ss         = array([1.17874869e-16, 1.75986366e-16, 4.61036397e-16, 1.99557031e-15])
su         = array([[ 0.54511892, -0.39371098, -0.0042301 , -0.48374194],
[-0.07369829,  0.01159275,  0.07205716, -0.3645317...    [ 0.23624745, -0.326349  , -0.05023194,  0.01401531],
[-0.42795445, -0.73092631,  0.04194756,  0.17688141]])
svh        = array([[-1.22886897e-01, -1.21334938e-01, -4.68895602e-02,
4.69108778e-02, -1.59353418e-17, -4.04233737e-17,
...-3.64019701e-16, -7.33805901e-16,
7.50998294e-01, -5.83555870e-01,  1.51733636e-01,
-1.29358556e-01]])
u          = array([[-0.33397412,  0.30407154, -0.47230311, -0.21496766, -0.14088015,
0.34489264, -0.57462286, -0.07330383...5883,  0.3167347 , -0.32862208,  0.04004026,
-0.17628979,  0.23883564,  0.45700088,  0.0643964 , -0.03100367]])
vh         = array([[-4.40366605e-01, -3.85441693e-01, -3.82074718e-01,
-4.51394369e-01, -4.15320299e-01, -2.77665105e-01,
... 4.74886893e-18, -3.43984034e-17,
-1.12109659e-01, -2.61908770e-01, -9.49710421e-01,
-6.11934156e-02]])
x          = array([[0.75358919, 0.99565464, 0.41765909, 0.84314278, 0.20050386,
0.2610654 ],
[0.14709222, 0.2662157...6076074,
0.78560949],
[0.9506525 , 0.39618705, 0.43422147, 0.94440681, 0.11885702,
0.94011348]])
y          = array([[0.20873058, 0.16266047, 0.04320398, 0.36305945],
[0.04074189, 0.04349176, 0.03306512, 0.12853487],
...36],
[0.1786513 , 0.07866283, 0.09082089, 0.38187172],
[0.26331356, 0.06472523, 0.04491724, 0.40666401]])

Could someone please help resolving https://github.com/scipy/scipy/pull/16712#issuecomment-1237401746 ?
Merging main in https://github.com/scipy/scipy/commit/6c0ce33c407745fb24c3626234105cec3f5281cf gave completely wrong results in the unit test test_small_sigma2 just for Linux Meson tests / Meson build (3.9, false) and Linux Tests / Python 3.8-dbg I have no idea why and how to fix it.

I've seen that test_small_sigma2 a few more times recently I believe, I think it's a flaky test. A little unclear where it is coming from indeed. Looking at the failures in https://github.com/scipy/scipy/actions/workflows/linux_meson.yml, the first two from other PRs show one test_small_sigma2 failure as well.
I'll have a closer look at the history here.

I have added a condition, line 831, to test_svds.py for condition at line 832 to pass in all tests:
if n < m:  # else the assert fails with some libraries unclear why
assert_allclose(sp_mat.transpose() @ su, 0, atol=1e-5, rtol=1e0)
I suggest merging it that way and make a new issue on why it fails for future generations to handle.

This PR is ready for review & merge, please.

This is looking quite good to me now. The extensive set of docs added are great - maybe the one thing to change is make the links into proper references with a title, it's not clear where they are pointing to now. The few tweaks look like a nice generalization that make things more robust.
I think we should indeed get this in before the 1.10.x branch point. I don't have much time right now, but will circle back to this if no one else does by the end of next week.

one thing to change is make the links into proper references with a title, it's not clear where they are pointing to now.

@rgommers - Done.


For p_init_process should any of the following be modular? Also what about current time with clock time?

In
new_process = Process(
            uuid=uuid4(),
            phase=SelectionPhase.pending_proposals,
            leading_sequencer=None,
            uncle_sequencers=None,
            current_phase_init_time=state["time_l1"],
            duration_in_current_phase=0,
            proofs_are_public=False,
            block_content_is_revealed=False,
            commit_bond_is_put_down=False,
            rollup_proof_is_commited=False,
            process_aborted=False,
        )

Should proofs_are_public be modular? Nothing else probably needs to be.
Also should there be the current clock time, i.e. 5/13/24 5:00 so that both can be tracked?

proofs_are_public=False,
block_content_is_revealed=False,
commit_bond_is_put_down=False,
rollup_proof_is_commited=False

A new process should always be init with these as false. The function that sets them to True should likely be modularized.
What do you see as benefit from clock time?

@jackhack00 Only benefit for clock time would be making sure we can have a way to do things like use daily returns of prices. But one can probably get close to real world time with using l1 blocks * average time duration.
So maybe this issue can be scrapped?


Add a way to inform users why a command is disabled

While declaring our extensions support for virtual workspaces as "limited", we have disabled some commands via the "enablement" property. The issue is that users may not know why the commands and buttons have been disabled (because of virtual workspaces). It would be great to have a way to inform them.
Ideas:

Tooltip that says " (disabled in virtual workspaces)"
Notification when they click it explaining that the command is disabled in virtual workspaces

I'd suggest that you update the title information to inform the user of this, we do this in parts of the UI:


fix HAML conversion - layouts/_item

this was introduced in a82effc,  the cols.each needs to happen for both types, only the outer else should be separate

@skateman ping :)


Bug: JS WrongFilePathLinter triggering in string templates

Describe the bug
The JS WrongFilePathLinter may trip up when trying to find the file of a class path generated dynamically using string literals.
In my case, I have the following function:
loadFragmentRelative(fragmentName) {
  return this.loadFragment({ name: `com.mycompany.myapp.view.${fragmentName}` });
}

To Reproduce
Steps to reproduce the behavior:

Type the following in a Controller:

`com.mycompany.myapp.${someValue}`

Run the linter
WrongFilePathLinter error is triggered saying it cannot find a file under "com.mycompany.myapp.${someValue"

Expected behavior
I'd rather WrongFilePathLinter skip this error.
Screenshots
N/A
Desktop (please complete the following information):

OS: macOS
UI5 version: SAPUI5 1.118.0
ui5plugin-linter version: 1.11.1 (latest in VSCodeUI5Plugin at the time of writing)

Additional context
This may also happen with normal string concatenation. E.g.:
"com.mycompany.myapp." + someValue

Project attachment
N/A. I don't think it is needed.

Fixed, please check

Solved. Thank you!


Krishna/2225/remove timestamp from block header

Motivation

Closes #2225

Changes
Remove Timestamp field from the BlockHeader struct
Test Plan

TODO

[ ] Explain motivation or link existing issue(s)(https://github.com/spacemeshos/go-spacemesh/issues/2225)
[ ] Test changes and document test plan
[ ] Update documentation as needed

LGTM

Thank you for the review.

@noamnelke hows do the merge process looks like? Will you or one of maintainers merge it, because I don't see I have permission to merge?

Will you or one of the maintainers merge it

Yes, we'll merge it. We currently have some stability issues with our system tests, which are a requirement for a merge, so I was considering waiting for those to be resolved before merging, but I'll just try now (it may take several attempts until the issue is solved).

bors merge

bors merge

Will you or one of the maintainers merge it

Yes, we'll merge it. We currently have some stability issues with our system tests, which are a requirement for a merge, so I was considering waiting for those to be resolved before merging, but I'll just try now (it may take several attempts until the issue is solved).

not a problem. Just wanted to know. Appreciate for all the help.

bors merge

bors merge

bors merge

bors merge

bors merge

bors merge

bors merge

bors merge

@krishnaindani I found an issue in the last failed test run. There's a test that was only passing because of the Timestamp field. The test is incorrect and needs to be patched.
Can you apply the following patch?
diff --git a/miner/builder_test.go b/miner/builder_test.go
index 2fa37242..65a1a414 100644
--- a/miner/builder_test.go
+++ b/miner/builder_test.go
@@ -183,12 +183,14 @@ func TestBlockBuilder_BlockIdGeneration(t *testing.T) {
 	builder2.AtxDb = atxDbMock{}
 	builder1.AtxDb = atxDbMock{}

-	b1, err := builder1.createBlock(types.GetEffectiveGenesis()+2, types.ATXID{}, types.BlockEligibilityProof{}, nil)
+	atxId1 := types.ATXID(types.HexToHash32("dead"))
+	atxId2 := types.ATXID(types.HexToHash32("beef"))
+	b1, err := builder1.createBlock(types.GetEffectiveGenesis()+2, atxId1, types.BlockEligibilityProof{}, nil)
 	assert.NoError(t, err)
-	b2, err := builder2.createBlock(types.GetEffectiveGenesis()+2, types.ATXID{}, types.BlockEligibilityProof{}, nil)
+	b2, err := builder2.createBlock(types.GetEffectiveGenesis()+2, atxId2, types.BlockEligibilityProof{}, nil)
 	assert.NoError(t, err)

-	assert.True(t, b1.ID() != b2.ID(), "ids are identical")
+	assert.NotEqual(t, b1.ID(), b2.ID(), "ids are identical")
 }

 var (

@krishnaindani I found an issue in the last failed test run. There's a test that was only passing because of the Timestamp field. The test is incorrect and needs to be patched.
Can you apply the following patch?
diff --git a/miner/builder_test.go b/miner/builder_test.go
index 2fa37242..65a1a414 100644
--- a/miner/builder_test.go
+++ b/miner/builder_test.go
@@ -183,12 +183,14 @@ func TestBlockBuilder_BlockIdGeneration(t *testing.T) {
 	builder2.AtxDb = atxDbMock{}
 	builder1.AtxDb = atxDbMock{}

-	b1, err := builder1.createBlock(types.GetEffectiveGenesis()+2, types.ATXID{}, types.BlockEligibilityProof{}, nil)
+	atxId1 := types.ATXID(types.HexToHash32("dead"))
+	atxId2 := types.ATXID(types.HexToHash32("beef"))
+	b1, err := builder1.createBlock(types.GetEffectiveGenesis()+2, atxId1, types.BlockEligibilityProof{}, nil)
 	assert.NoError(t, err)
-	b2, err := builder2.createBlock(types.GetEffectiveGenesis()+2, types.ATXID{}, types.BlockEligibilityProof{}, nil)
+	b2, err := builder2.createBlock(types.GetEffectiveGenesis()+2, atxId2, types.BlockEligibilityProof{}, nil)
 	assert.NoError(t, err)

-	assert.True(t, b1.ID() != b2.ID(), "ids are identical")
+	assert.NotEqual(t, b1.ID(), b2.ID(), "ids are identical")
 }

 var (

@krishnaindani I found an issue in the last failed test run. There's a test that was only passing because of the Timestamp field. The test is incorrect and needs to be patched.
Can you apply the following patch?
diff --git a/miner/builder_test.go b/miner/builder_test.go
index 2fa37242..65a1a414 100644
--- a/miner/builder_test.go
+++ b/miner/builder_test.go
@@ -183,12 +183,14 @@ func TestBlockBuilder_BlockIdGeneration(t *testing.T) {
 	builder2.AtxDb = atxDbMock{}
 	builder1.AtxDb = atxDbMock{}

-	b1, err := builder1.createBlock(types.GetEffectiveGenesis()+2, types.ATXID{}, types.BlockEligibilityProof{}, nil)
+	atxId1 := types.ATXID(types.HexToHash32("dead"))
+	atxId2 := types.ATXID(types.HexToHash32("beef"))
+	b1, err := builder1.createBlock(types.GetEffectiveGenesis()+2, atxId1, types.BlockEligibilityProof{}, nil)
 	assert.NoError(t, err)
-	b2, err := builder2.createBlock(types.GetEffectiveGenesis()+2, types.ATXID{}, types.BlockEligibilityProof{}, nil)
+	b2, err := builder2.createBlock(types.GetEffectiveGenesis()+2, atxId2, types.BlockEligibilityProof{}, nil)
 	assert.NoError(t, err)

-	assert.True(t, b1.ID() != b2.ID(), "ids are identical")
+	assert.NotEqual(t, b1.ID(), b2.ID(), "ids are identical")
 }

 var (

sure. Let me take a look.

@krishnaindani I found an issue in the last failed test run. There's a test that was only passing because of the Timestamp field. The test is incorrect and needs to be patched.
Can you apply the following patch?
diff --git a/miner/builder_test.go b/miner/builder_test.go
index 2fa37242..65a1a414 100644
--- a/miner/builder_test.go
+++ b/miner/builder_test.go
@@ -183,12 +183,14 @@ func TestBlockBuilder_BlockIdGeneration(t *testing.T) {
 	builder2.AtxDb = atxDbMock{}
 	builder1.AtxDb = atxDbMock{}

-	b1, err := builder1.createBlock(types.GetEffectiveGenesis()+2, types.ATXID{}, types.BlockEligibilityProof{}, nil)
+	atxId1 := types.ATXID(types.HexToHash32("dead"))
+	atxId2 := types.ATXID(types.HexToHash32("beef"))
+	b1, err := builder1.createBlock(types.GetEffectiveGenesis()+2, atxId1, types.BlockEligibilityProof{}, nil)
 	assert.NoError(t, err)
-	b2, err := builder2.createBlock(types.GetEffectiveGenesis()+2, types.ATXID{}, types.BlockEligibilityProof{}, nil)
+	b2, err := builder2.createBlock(types.GetEffectiveGenesis()+2, atxId2, types.BlockEligibilityProof{}, nil)
 	assert.NoError(t, err)

-	assert.True(t, b1.ID() != b2.ID(), "ids are identical")
+	assert.NotEqual(t, b1.ID(), b2.ID(), "ids are identical")
 }

 var (

sure. Let me take a look.

closed due to inactivity


Regression: Removal of USER vscode from Ruby Dockerfile is breaking other projects

This was discovered as a result of rails/rails#53581.
Currently, devcontainers are failing for both rails and rails-contributors. The root cause for each appears to be the changes introduced in #51. Reverting those changes allows the devcontainers to be built without error.
See this PR comment for the steps to reproduce the error. To summarize, though: reverting #51 fixes the problems in building the devcontainers for both projects.
The question is whether #51 should be reverted, or whether dependent projects should be updated.

I replied in https://github.com/rails/rails/issues/53581. I believe updating Rails' dev container is the correct move. I don't want to revert https://github.com/rails/devcontainer/pull/51


gmsync: Scanning for missing songs: list index out of range

When calling gmsync like this:
./gmsync.py up -a -U 'B8:27:EB:FF:FF:FF' -d ~/sc_music/
it crashes as follows:
Scanning for missing songs...
Traceback (most recent call last):
  File "./gmsync.py", line 202, in <module>
    main()
  File "./gmsync.py", line 164, in main
    upload_songs = compare_song_collections(local_songs, google_songs)
  File "/home/syncer/gmusicapi-scripts/gmwrapper.py", line 49, in compare_song_collections
    src_key = create_song_key(src_song)
  File "/home/syncer/gmusicapi-scripts/gmwrapper.py", line 68, in create_song_key
    song = song if isinstance(song, dict) else _mutagen_fields_to_single_value(song)
  File "/home/syncer/gmusicapi-scripts/gmwrapper.py", line 35, in _mutagen_fields_to_single_value
    return {k: v[0] for k, v in mutagen.File(file, easy=True).iteritems()}
  File "/home/syncer/gmusicapi-scripts/gmwrapper.py", line 35, in <dictcomp>
    return {k: v[0] for k, v in mutagen.File(file, easy=True).iteritems()}
IndexError: list index out of range

Previously, I would have had to tell you to use the devel version, but I finally released it to PyPI. So just use the installation instructions to install the new stable release where this problem is solved.

After having reinstalled pip and


Lock all versions down, don't use latest

Over time, latest versions of repos and packages change dependencies, names, features etc.  Instead, lock all versions down and bump the manually in each version of maverick.

ardupilot and px4 are both set to pull master and build.  Probably best strategy for now, so leave on master.

Think this will actually add more work in the long term that it will save problems.


getting textarea instead of text in form view

while using  php artisan crud:view posts --fields="name#text" I am getting textarea as input field instead of text. Why is this happening?? I am referring this link in documentation https://github.com/appzcoder/crud-generator/blob/master/doc/fields.md

Use string instead.
Docs need to be updated.

@sohelamin Thanks. It worked!!!


Add to docstring of advance_watermark_to_infinity

Minor change to docstring of TestStream.advance_watermark_to_infinity.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @pabloem


Add support for Major and Major.Minor Docker tags

Request details
Problem Statement
Currently, the Docker images published for Reposilite are tagged only with latest and the full version (e.g., 3.5.19). While this works for many use cases, it can make managing updates more challenging for users who want to:

Restrict updates to a specific major version (e.g., 3.x) to avoid breaking changes.
Apply updates only within a specific minor version (e.g., 3.5.x) for added stability.

This lack of additional tags can lead to either using the full version tag (requiring frequent manual updates) or relying on latest, which carries the risk of breaking changes.
Proposed Solution
Enhance the tagging process for Docker images by adding the following additional tags:

Major (e.g., 3)
Major.Minor (e.g., 3.5)

These tags would complement the existing latest and full release tags, giving users more flexibility to manage updates in their environments.
Benefits

Users can opt-in to update strategies that better suit their requirements:

Use the Major tag to stay on the latest version within a major release.
Use the Major.Minor tag for stability within a minor release series.

Reduced risk of unexpected breaking changes when relying on the latest tag.

Implementation Details
In the docker job of the GitHub Actions workflow, the additional tags can be generated by extracting the Major and Minor parts of the version (e.g., from a variable or computed from the full version). These tags would then be passed to the docker/build-push-action step alongside the existing tags.
Additional Context
I am happy to open a PR to implement this feature, as I already have a working solution. Please let me know if this aligns with the goals of the project or if any adjustments are needed before proceeding.

I think it'd be a great improvement, feel free to submit the PR then :shipit:


[BUG] Unexpected Result When fsqrt.s Processes Negative Floating-Point Numbers

Bug Description
When the fsqrt.s instruction is executed on a negative double-precision floating-point number, the resulting output differs from that of Spike. Spike returns 0x7fc00000, which represents a NaN value.
How to reproduce and the logs are as follows:
Example:
Initialize ft0 with 0xC08140003F800000 (a negative double-precision floating-point value) and execute fsqrt.s ft2, ft0 .
Spike results are: ft2= 0x7fc00000
CVA6 results are: ft2= 0x3f800000
See:https://github.com/openhwgroup/cva6/issues/2100

Thanks for your Issue @fly-1011.  Just FYI, the CVA6 is using a rather out-dated version of CVFPU and is not actively verifying the floating point ISA beyond running the Architectural Compliance Tests.  The first full release of the CVA6 (known as the CV32A65X) does not support floating point.
@pascalgouedo, does this issue impact the CV32E40P v2.0.0?

Hi,
What looks strange to me in the bug description is that is it mentioning fqrst.s (single precision computation using single-precision values) together with negative double-precision floating-point number.
As explained by RISC-V spec, when D extension is used, f registers are widened to 64 bits and can hold either 32-bit or 64-bit floating point values.
When f registers are used with single-precision instructions (*.s), only 32 LSBs are used.
With double-precision instructions (*.d), all 64 bits are used.
So CVA6 and CVFPU behavior described in cva4#2102 looks good to me.
And by the way CV32E40P is not supporting D extension.

Hi, What looks strange to me in the bug description is that is it mentioning fqrst.s (single precision computation using single-precision values) together with negative double-precision floating-point number. As explained by RISC-V spec, when D extension is used, f registers are widened to 64 bits and can hold either 32-bit or 64-bit floating point values. When f registers are used with single-precision instructions (.s), only 32 LSBs are used. With double-precision instructions (.d), all 64 bits are used.
So CVA6 and CVFPU behavior described in cva4#2102 looks good to me.
And by the way CV32E40P is not supporting D extension.

Thank you for your response. I haven't found explicit documentation in the RISC-V specifications regarding single-precision instructions using only the lower 32 bits when handling double-precision floating-point numbers. It appears that in its operations, the CVA6 only utilizes the lower 32 bits. I will be closing this issue.


feat: add tooltip to the Home.Autopilot section describing its function

Description:
Add a tooltip to the Autopilot section heading in the Home screen explaining the function of enabling autopilot.
Motivation and Context:
As a new lnd/Lightning/Zap user I was unsure what Autopilot actually did. Definitely had some ideas based on the name "autopilot", but it's still nice to know for sure what it will do.
How Has This Been Tested?
Locally (see screenshot).
Screenshots (if appropriate):

Types of changes:
Feature/Enhancement
Checklist:

[x] My code follows the code style of this project.
[ ] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[x] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage remained the same at 22.596% when pulling 7342a607c2f384768212be40164de162bc04aba7 on MitchellCash:autopilot_tooltip into 961de4e7d6bbeef28d51c24f44a05bf1660a4c56 on LN-Zap:next.

Looks good.


Converting AWS ECS resources to Terraform

Converting AWS ECS resources to Terraform
What user problem are we solving?
We are making sure that our AWS Resources are backed up through Terraform.
What solution does this PR provide?
Allows us to redeploy the resource easily
Testing Methodology
Tested by deploying resources into AWS and checking configurations with actual resource

The TF code looks good, I'd approve it but I have less experience in this compared to @karkir0003

did u test it out @thomaschin35

Yes it has been tested

plz delete the excess test train service on ecs? @thomaschin35
did you do a real deploy tho? if not do that before merging this pr in

plz delete the excess test train service on ecs? @thomaschin35
did you do a real deploy tho? if not do that before merging this pr in

I did a real deploy and I deleted the test services and test clusters already. I checked using the test clusters and services first, but I didn't completely replace the one we have, cause right now it has all the right settings. I can replace the cluster and service that we have right now if that's what you are asking.

that's what i was asking @thomaschin35


bug: CUDA fix in decipher

@justjhong  I already fixed one of the tests (but you should review it)
close https://github.com/scverse/scvi-tools/issues/3109

@justjhong no the other test is failing, I wasnt sure what will be the way to go, please see if you can fix it.
yes it is basically on device handling (cpu and gpu calculation at the same time, but in the trajectory part, which is all cpu)

@ori-kron-wis @canergen remaining test should be fixed now


Create listing: Save buttons

Yo dawg... I heard you like 'Save' buttons, so I put a save button in your save button, so you can save while you save.

Only one save button is necessary, I suggest the bottom-right makes the most sense.

The reason for that is because if you Edit the listing from the Listing Detail page, the design called for a top bar with 2 buttons:

For consistency, when opening the Edit modal from other areas, I left the top bar in and just omit the unneeded button. I could though omit the bar altogether. @morebrownies Is that what you would like?

I could though omit the bar altogether. @morebrownies Is that what you would like?

We need to switch the design of the modal all together @rmisio, so I wouldn't worry about removing the top bar right now.  If we removed it, we'd also lose the Return to Listing button, which I find very useful.

Only one save button is necessary, I suggest the bottom-right makes the most sense.

@drwasho once we switch to the new modal design, the save button will no longer be fixed at the bottom of the viewport. Instead, it will require the user to scroll down to the very bottom of the overlay and hit Save.  See the prototype.
Keep in mind that prototype doesn't have many shipping options filled in so the vertical scroll isn't too bad. For a listing with 5 shipping options filled in, having to always scroll to the very bottom of the screen in order to save could be annoying, especially in the case of making a quick change to the Title or Description field.
I don't see any harm in having 2 buttons.

@morebrownies Is there a design anywhere for the top bar in the new modal style? I remember there was a prototype for that, but I don't have that link anymore.

@rmisio I probably need to rethink this a bit to account for #194. I'll post something a bit later today.

@drwasho @morebrownies is this still considered an issue? We still have two save buttons, at the top and bottom, but they seem useful and look fine to me, considering the height of the form.

I find myself using both buttons pretty often. I would like to keep them as well.

I think we're in agreement, I'll close this issue.


CI: Add a workflow to automatically create an issue on the docs repo from a PR in this repo

This is a workflow enhancement suggestion to help us write and maintain better docs.
Whenever someone issues a PR to add a new feature that requires documentation, they can mark it with the label "needs-documentation". Then the CI bot would kick in and create a new issue on our docs repo, where it links back to the PR in this repo that adds the feature. This will help on two counts:

We can link the docs issue directly back to the feature PR that implemented it on our main repo
We can reduce the chances of forgetting to document new features

See this workflow on the DuckDB main repo as an example. I think having a workflow like this would work great for our purposes, too!

cc @semihsalihoglu-uw for comments, as he's made use of the documentation label numerous times to point out things that need to be documented.
I also propose that we replace the documentation label in this repo with the more useful needs-documentation label, and color it orange so that it stands out from the other labels on an issue/PR.


Unable to create multiple overlay window.

Hello, how can I make numerous overlay windows with this package? I should also be able to close each window separately.

Please try to add minimal example of the code that you're using. As it says in the docs and sample example creating a new overlay should be as simple as simply calling showOverlay

import 'dart:async';
import 'dart:developer';
import 'package:flutter/material.dart';
import 'package:flutter_overlay_window/flutter_overlay_window.dart';
import 'news_data.dart';
class MyHomePage extends StatefulWidget {
const MyHomePage({super.key});
@override
State createState() => _MyHomePageState();
}
class _MyHomePageState extends State {
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: const Text('Top Stories'),
centerTitle: false,
titleTextStyle: const TextStyle(
fontSize: 30,
color: Colors.black)),
body: ListView.separated(
shrinkWrap: true,
separatorBuilder: (context, idx) {
return const Divider();
},
itemCount: getNewsStories().length,
itemBuilder: (context, idx) {
final article = getNewsStories()[idx];
return ListTile(
onLongPress: (){
_closeOverlayWindow();
},
key: Key('$idx ${article.hashCode}'),
title: Text(article.title),
subtitle: Text(article.description),
onTap: () {
_showOverlayWindow();
},
);
},
));
}
_showOverlayWindow() async {
bool status = await FlutterOverlayWindow.isPermissionGranted();
if(!status){
status = await FlutterOverlayWindow.requestPermission() ?? false;
setState(() {
});
}else{
await FlutterOverlayWindow.showOverlay(alignment: OverlayAlignment.centerLeft,height: 200,width: 300,enableDrag:  true,flag: OverlayFlag.defaultFlag,positionGravity: PositionGravity.auto);
}
}
_closeOverlayWindow() async {
await FlutterOverlayWindow.closeOverlay();
}
} This is the example code that I'm attempting to run. I want to launch an overlay window as I press each article, not replace the one that's already open.

@jijormathew  Could you put it in a code block?
By the way, is there any example of using & communicating between multiple of windows?

For the moment this package works only on displaying single overlay


Add APIKeyID field name to the ListAll function

APIKeyID field name was introduced in PR https://github.com/1Password/shell-plugins/pull/95/ (Lacework plugin) but it seems that it wasn't added to the ListAll function in the field names SDK. This PR fixes it.

Thanks for this addition!


fix: gh actions ENV name

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


No mute option

Is it possible to make audio mute on middle click or clicking the icon?

I actually have a MR for Gnome itself open, but I have been ignored: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1426.


Add Pyodide apps

It will be cool to have (some of) our apps deployed and ready to try out.
This PR adds pyodide apps for the apps that works in Pyodide.
Looks like below. I anticipate will will have other app links like Anaconda Notebooks or Hugging Face one day.

This one fails on codecov upload. I don't think this is related to this PR.
I think this is ready @ahuang11 . Let me know if there is something I should do. Thanks.


Upgrade daemon to 0.19.0rc35 [Don't merge]

@liamcardenas adding my comments from Slack:

my channels are showing up in Published area, they shouldn't be.

Clicking on items in Downloads/Published area go to an "undefined" claim name, but has correct claim_id

clicking on claims from the transaction screen also goes to undefined claims as #2

Still waiting to hear back from Jack about some file_list changes, but it may be worth looking at https://github.com/lbryio/lbry/issues/1127 to see how it currently works. My main concern will be the editing of already edited claims - I think we use the file_list outpoint when trying to edit, which may not be up to date on the file_list side but should be on claim_list_mine.


Allowing for custom trained VQGAN during DALLE training

It would be nice to allow for custom trained VQGAN models when training DALLE.
Right now the library hard-codes usage to the pretrained imagenet model, allowing a user input for the model to be used (along with params) for train_dalle.py would be great.
p.s. The download scripts seem to bring the model to .cache which, in my tests, bypasses the custom model one can pass in the VQGAN1024 class. They would also probably need to be included in the option.
I have this running on my own tests, if it's difficult to find time for it, I could try a PR but my approach is very hacky.

@afiaka87 yup, should be doable! let me think about the interface - perhaps something like --vqvae-path and --vqvae-config-path
or perhaps, to stay simple, i should just default the VQVAE config to be the one with 1024 tokens

Ive been working on this a bit - kobiso and others are fond of using hugging_faces tokenizers library. I think drop in support for the parameter --vocab="<vocab-file.json>" would be nice as well.

@afiaka87 yup I can work on that too!

@afiaka87 yup I can work on that too!

Not to push a wip up actually

@lucidrains https://github.com/lucidrains/DALLE-pytorch/pull/193
If you can work from this then go for it - if you have a better implementation in mind let me know.

Here's a sample tokenizer to work with - perhaps include if you think it's a good idea wget https://www.dropbox.com/s/uie7is0dyuxqmk0/hg_bpe_cc12m.json
Not a permanent host fyi.

Here's a sample tokenizer to work with - perhaps include if you think it's a good idea
wget https://www.dropbox.com/s/uie7is0dyuxqmk0/hg_bpe_cc12m.json
Not a permanent host fyi.
@lucidrains

seems to work in the latest! but for some reason, when i decode, it isn't concatenating the subwords

Here's a sample tokenizer to work with - perhaps include if you think it's a good idea
wget https://www.dropbox.com/s/uie7is0dyuxqmk0/hg_bpe_cc12m.json
Not a permanent host fyi.
@lucidrains

seems to work in the latest! but for some reason, when i decode, it isn't concatenating the subwords

Yep having that issue as well - did you figure it out?

In my case, the pretrained VQGAN model is significantly worse than a custom trained VQGAN model. So I guess many people may have such requirement. For now, I simply replace the name of the custom trained model.

@afiaka87 yup, should be doable! let me think about the interface - perhaps something like --vqvae-path and --vqvae-config-path
or perhaps, to stay simple, i should just default the VQVAE config to be the one with 1024 tokens

I would say for my purposes, and anyone who has been actively using this code, a VQVAE with the existing VAE configuration already provided would be extremely useful.

For people who successfully train VQGAN, do you experience increasing quantized loss over time?

this is now done


Modal markup no longer moved to the document body. This ensures modals w...

...hich contain inputs from a form are posted correctly.

Thanks for the contribution, but we're not merging into master anymore with stuff like this. All efforts are on the 2.0-wip branch.


Page.setContent() fails when content includes \x7F but is valid UTF-8

Steps to reproduce
Tell us about your environment:

Puppeteer version: 1.15.0
Platform / OS version: Mac OS X
URLs (if applicable): N/A
Node.js version: v11.14.0

What steps will reproduce the problem?
const puppeteer = require('puppeteer');

(async () => {
    const browser = await puppeteer.launch();
    const page = await browser.newPage();
    await page.setContent('hello world' + '\x7F');
    await page.screenshot({ path: 'example.png' });
    await browser.close();
})();

Does not render a screenshot errors with:
puppeteer:protocol SEND ► {"sessionId":"01FFD0FBFAF9615CF23C56EE225D4C57","method":"Runtime.callFunctionOn","params":{"functionDeclaration":"html => {\n      document.open();\n      document.write(html);\n      document.close();\n    }\n//# sourceURL=__puppeteer_evaluation_script__\n","executionContextId":2,"arguments":[{"value":"hello world"}],"returnByValue":false,"awaitPromise":true,"userGesture":true},"id":16} +1ms
puppeteer:protocol ◀ RECV {"error":{"code":-32700,"message":"Message must be a valid JSON"}} +1ms

What is the expected result?
The page content is set.
When a browser loads the content from a server everything works perfectly.
What happens instead?
The puppeteer.setContent() method does not return and the the program does not terminate as the error is not detected by Puppeteer.

Hi @aslushnikov,
I tried your fix but it seems to double escape proper UTF-8 content leading to strange characters appearing in the screenshots produced.
See:
https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64/Base64_encoding_and_decoding#The_Unicode_Problem
A good test case would be attempting to pass in an Emoji via setContent().
Thanks,
Rusty


Installation crashes Octopi on RPi

I ran  "/home/pi/oprint/bin/pip install matplotlib numpy " successfully on my RPi 3.
When I tried to install plugin it still tries to get matplotlib-2.2.4.tar.gz and at this point Octoprint server crashes...
Here's what I see in the log:
2019-03-09 20:07:00,106   /home/pi/OctoPrint/venv/bin/python -m pip install https://github.com/PrusaOwners/OctoPrint-PrusaMeshMap/archive/master.zip --no-cache-dir
2019-03-09 20:07:06,141 > Collecting https://github.com/PrusaOwners/OctoPrint-PrusaMeshMap/archive/master.zip
2019-03-09 20:07:07,144 > Downloading https://github.com/PrusaOwners/OctoPrint-PrusaMeshMap/archive/master.zip
2019-03-09 20:07:10,362 > Requirement already satisfied: OctoPrint in /home/pi/OctoPrint/venv/lib/python2.7/site-packages (from OctoPrint-PrusaMeshMap==0.3.0)
2019-03-09 20:07:11,365 > Collecting matplotlib>=2.2.0 (from OctoPrint-PrusaMeshMap==0.3.0)
2019-03-09 20:07:15,370 > Downloading https://files.pythonhosted.org/packages/1e/20/2032ad99f0dfe0f60970941af36e8d0942d3713f442bb3df37ac35d67358/matplotlib-2.2.4.tar.gz (37.0MB)
I'm running OctoPrint 1.3.10
It looks like I already have matplotlib installed:

matplotlib.version
'2.2.4'

Actually it eventually finished installing... So "Pre-installing" didn't seem to help, however plugin got installed after about an hour.


Change "HTTP over QUIC" to "HTTP/3"

I think you should change HTTP over QUIC to HTTP/3 in the documents.
HTTP/3 | daniel.haxx.se

It is referred to as "HTTP/3" in most places already. Are there any specific places where you think we should update the current text?

It is on purpose as I speak of HTTP over QUIC in the generic sense there.

Okay, I understand.
Thank you very much.
And I'll reflect this issue to the document of Japanese.


Psr7 stream and response

Hi, I’v added the ability to generate [PSR-7] (http://www.php-fig.org/psr/psr-7/) compatible Stream and Response using image encoded data (methods stream() and psrReponse() accordingly). PSR7 support seems to be much more universal than laravel compatible "response" method.
I'm using [Guzzle implementation] (https://packagist.org/packages/guzzlehttp/psr7) as the easiest available option, howewer there is no PSR7 implementation exist with PHP 5.3 support.
Minimal requirements start with 5.4 so I had to change the required php version. Since 5.3 has not been supported for almost a year, it doesn't seem to be big loss for me, but it's up to author to decide.

Thank you. One question before I pull this in. Why is guzzlehttp/psr7 in require-dev, I should not use stream() when I installed with --no-dev?

Oh, i just copied from my repo composer.json and inserter into wrong place. :/ Fixed in latest commit.
Sorry about that.

Thanks again.


bot wont start

I populated my .env files with openai key, discord bot token, and assistant ID. And when I run nodemon bot, I get the following:
discordbot/openai-assistants-discord-bot/node_modules/discord.js/src/client/BaseClient.js:45
userAgentAppendix: options.rest?.userAgentAppendix
^
SyntaxError: Unexpected token '.'
at wrapSafe (internal/modules/cjs/loader.js:915:16)
at Module._compile (internal/modules/cjs/loader.js:963:27)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
at Module.load (internal/modules/cjs/loader.js:863:32)
at Function.Module._load (internal/modules/cjs/loader.js:708:14)
at Module.require (internal/modules/cjs/loader.js:887:19)
at require (internal/modules/cjs/helpers.js:74:18)
at Object. (/home/j/discordbot/openai-assistants-discord-bot/node_modules/discord.js/src/index.js:6:22)
at Module._compile (internal/modules/cjs/loader.js:999:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
[nodemon] app crashed - waiting for file changes before starting...
^Cj@pop-os:~/discordbot/openai-assistants-discord-bot$ nano node_modules/di
digest-fetch/      discord-api-types/ discord.js/

Huh, that's a strange error - haven't seen that one before. Something to do with the Discord library. Maybe try deleting node_modules and reinstalling dependencies? Maybe local node version is old/out of date?

It works in Windows!

Oh interesting! I am developing on a Windows but it looks like @ShivamB25 was able to get it working on an alpine-based node image to get it working in Docker, so it seems like maybe some issue between Pop OS and Discord? That would be sort of outside the scope of this repo, so I'm inclined to close. What do you think @AIPowerGrid ?

Oh interesting! I am developing on a Windows but it looks like @ShivamB25 was able to get it working on an alpine-based node image to get it working in Docker, so it seems like maybe some issue between Pop OS and Discord? That would be sort of outside the scope of this repo, so I'm inclined to close. What do you think @AIPowerGrid ?

the other way would be for him to try using docker-compose instead while changing the default runtime on docker. maybe try podman too


Move Listers to pkg/client/cache.

I would like to use these in kubelet and kube-proxy.
This is the minimal change to get them moved.
I will follow up with changes to make interfaces consistent
and add Listers for other resources.

LGTM


Removing unsupported GraphQL Mesh features

Revanth provided several features within the GraphQL Mesh reference that we currently do not support.
This PR comments out those features in order to preserve them for future use.
Some sections could not be commented out as their code sections would break the build.

Closing, please see https://github.com/AdobeDocs/graphql-mesh-gateway/pull/32


Vagrant installs with wrong permissions in /opt.

[X] ran brew update and can still reproduce the problem?
[X] ran brew doctor, fixed all issues and can still reproduce the problem?
[X] ran brew config and brew doctor and included their output with your issue?

What you were trying to do (and why)
I installed vagrant and wanted to do "vagrant up" after this.
What happened (include command output)
"vagrant up" gave me an error.

Command output

No usable default provider could be found for your system.
Vagrant relies on interactions with 3rd party systems, known as
"providers", to provide Vagrant with resources to run development
environments. Examples are VirtualBox, VMware, Hyper-V.
The easiest solution to this message is to install VirtualBox, which
is available for free on all major platforms.
If you believe you already have a provider available, make sure it
is properly installed and configured. You can see more details about
why a particular provider isn't working by forcing usage with
vagrant up --provider=PROVIDER, which should give you a more specific
error message for that particular provider.

What you expected to happen
Vagrant up should just run. Everything is installed as needed.
Upon investigation, it seems that vagrant installs in the /opt directory with root:wheel permissions. Running chown -R user:group /opt/vagrant resolves the issue.
After this, there is no error and vagrant works as expected.
Step-by-step reproduction instructions (by running brew commands)

$ brew cask install vagrant
$ vagrant up

Output of brew config and brew doctor commands
brew config:

Clang: 11.0 build 1100
Git: 2.24.1 => /usr/local/bin/git
Curl: 7.64.1 => /usr/bin/curl
macOS: 10.15.2-x86_64
CLT: <IP_ADDRESS>.1.1567737322
Xcode: N/A
samcrauwels@LinuxBook-Pro /opt % brew config
HOMEBREW_VERSION: 2.2.2-34-g7aacca3
ORIGIN: https://github.com/Homebrew/brew
HEAD: 7aacca366ab3798249927132907b03848af38748
Last commit: 6 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 57443e9285b521de15c498b6dce1fd519eb785c3
Core tap last commit: 4 hours ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_BREW_GIT_REMOTE: https://github.com/Homebrew/brew
HOMEBREW_CORE_GIT_REMOTE: https://github.com/Homebrew/homebrew-core
CPU: octa-core 64-bit kabylake
Homebrew Ruby: 2.6.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
Clang: 11.0 build 1100
Git: 2.24.1 => /usr/local/bin/git
Curl: 7.64.1 => /usr/bin/curl
macOS: 10.15.2-x86_64
CLT: <IP_ADDRESS>.1.1567737322
Xcode: N/A

brew doctor:

Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: A newer Command Line Tools release is available.
Update them from Software Update in System Preferences or
https://developer.apple.com/download/more/.

Sorry, this Issue is no longer an issue. Can be closed,

For future reference this was the wrong repository for this.


93 - adding parametrized queries

Describe your changes
1. Disable the default IPython var_expand for {a}, $a case
We disable the default variable substitution by adding @no_var_expand to the line_magic, since we still need to support the default variable substitution + new parametrized fashion in recent versions, we move that parsing part in the SQLCommand class
2. Add _var_expand in SQLCommand class
The logic for supporting {a}, $a (IPython) + {{a}} (new param feature) variable substitution is:

Handle the line & cell original string by jinja2 (new param feature)
Handle the line & cell original string by IPython var_expand native function to support the IPython way

This execution order matters, since {a} is the subset of {{a}}, we need to handle the {{a}} case before being handled by {a}
P.S. After those string are parsed, the :a part will still be kept, since it's handled by SQLAlchemy engine
Conclusion
This PR fulfill three requirements:

Add @no_var_expand to the execute line magic. We handle the var_expand by ourself
When there is variable substitution in {a}, $a, :a. We display message (can be discussed)

Please aware the variable substition as {a}, $a, and :a format has been deprecated.
Use {{a}} instead.

Support variable substitution in {{a}} fashion, the values will fetch from user name space now

Preview
:a - with deprecated message

{a} - with deprecated message

$a - with deprecated message

{{a}} - new parameter - consumed value from existing scope

Follow up
We need to support the arg --param & --use-global with {{a}} format in next PR
Issue ticket number and link
Closes #93
Checklist before requesting a review

[ ] I have performed a self-review of my code
[ ] I have added thorough tests (when necessary).
[ ] I have added the right documentation in the docstring and changelog (when needed)

:books: Documentation preview :books:: https://jupysql--137.org.readthedocs.build/en/137/

Looks like the CI is failing on broken links

Looks like the CI is failing on broken links

Yes. this is expected, https://github.com/ploomber/jupysql/pull/137#discussion_r1120707722
Since we added the new page user-guide/template.md, and also referred it in another page (vs.md), but the template page haven't deployed to jupysql.ploomber.io, so it failed on broken-link
The second newest commit 6c4d9cb is a success build, since it it's without referring the template page. The latest commit is with that

The see more link wouldn't pass the broken-link, revert for now

looks like the docs are failing, my guess is that this is due to the new jupyter book version: https://github.com/executablebooks/jupyter-book/releases
let's pin to <0.14.0 and see if that fixes it

@edublancas
Sync with latest master, you can review again!


Hide elements tab behind flag

Feature Description
Let's put this behind a flag until it's implemented.
Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

This tab was definitely hidden:

This is from the branch fix/blobs I happened to have checked out from a review of #2574.
I'm not sure why it is now unhidden? Maybe a bad merge somewhere?

Maybe the media3p tab merge from this week?

Yeah looks like #2553 caused this


Use Check-summed Addresses

In Ganache-Core 2.1.0, if you generate accounts with the default mnemonic of candy maple cake sugar pudding cream honey rich smooth crumble sweet treat, you get these ethereum accounts:
(0) 0x627306090abab3a6e1400e9345bc60c78a8bef57
(1) 0xf17f52151ebef6c7334fad080c5704d77216b732
(2) 0xc5fdf4076b8f3a5357c5e395ab970b5b54098fef
If EIP-55 is followed, I would expect these ethereum accounts to be:
(0) 0x627306090abaB3A6e1400e9345bC60c78a8BEf57
(1) 0xf17f52151EbEF6C7334FAD080c5704D77216b732
(2) 0xC5fdf4076b8F3A5357c5E395ab970B5B54098Fef
The EIP-55 reference includes a javascript implementation.
Is there a reason we shouldn't follow EIP-55?

Currently looking into this issue and hopefully will have a pull request soon. Had a brief discussion with @kevinbluer about this problem and wanted to test the code changes locally before create a pull request. Looking forward to have a deeper discussion with the Ganache team.

@kevinwucodes This has been fixed. Closing this issue, feel free to reopen if you still experience issues.


xAxis when using Timeseries inconsistent behavior

I've been using ApexCharts with timeseries and Line charts. I encountered three weird behaviors regarding the way the xAxis is drawn:

The first and last data point are often cropped on the chart:

When only two days are in the series the xAxis has hours and days.

https://codepen.io/Carniatto/pen/LJzbOx

Sometimes the format for month gets mixed up with year

https://codepen.io/Carniatto/pen/EewNLy

Hi @Carniatto
Actually, this is the way I have kept the x-axis tick generation to differentiate the days and hours when the difference is more than 1 day.
In certain cases, a user may not like this and would just prefer a single format - in your case: just the hours.
So, as suggested by you in another thread, I am going to provide the raw date-time value in the formatter function as a parameter where the user can use whatever suits them - no default behaviors.
Thanks for reporting @Carniatto

Thank you @junedchhipa. Can I suggest the option to add padding in the beginning and the end so all the points are contained inside the Chart? avoiding the first problem

@Carniatto Ah! I didn't see the edited comment.
So, the cropped dataPoints issue was fixed in the<EMAIL_ADDRESS>May I ask which version of ApexCharts you are testing on?

@junedchhipa I'm using version: 1.3.12.

Yes, you are right - Currently, you have no control over the number of ticks when type = datetime

@junedchhipa thanks for the quick response,  let me know when you shipp the raw datetime.  I'd like to contribute to the repo like add download as png or something like this. Let me know if I can open a PR.

@Carniatto I appreciate your willingness to make the library better.
I will soon create a simple contributing guideline.
For now, just create a PR with "feature/featureName" branch.
Thanks


Failed importing with row paremeters

When I try to read in the first row of data, with the following code, no issue
$DataSourcePath = "G:\Transfer\VMware.xlsx" # Path to Excel Worksheet as the data sources
$OSSpecParameters = Import-Excel -Path $DataSourcePath -WorksheetName 'OSCustomSpec' -StartRow 1 -EndRow 2

But why when I switch it over to next row like this later on in my code
$OSSpecParameters = Import-Excel -Path $DataSourcePath -WorksheetName 'OSCustomSpec' -StartRow 2 -EndRow 3
I get the following error?
Failed importing the Excel workbook 'G:\Transfer\VMware.xlsx' with worksheet 'OSCustomSpec': Duplicate column headers found
on row '2' in columns '3 4 5 8'. Column headers must be unique, if this is not a requirement please use the '-NoHeader' or
'-HeaderName' parameter.
At C:\Program Files\WindowsPowerShell\Modules\ImportExcel\7.1.1\Public\Import-Excel.ps1:216 char:21

...     catch { throw "Failed importing the Excel workbook '$Path' with w ...

            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : OperationStopped: (Failed importin...ame' parameter.:String) [], RuntimeException
FullyQualifiedErrorId : Failed importing the Excel workbook 'G:\Transfer\VMware.xlsx' with worksheet 'OSCustomSpec': Du
plicate column headers found on row '2' in columns '3 4 5 8'. Column headers must be unique, if this is not a requirement
please use the '-NoHeader' or '-HeaderName' parameter.

Read the error message carefully: it tries to interpret the first row (row 2 of the file) as a header row.
You have the same value in more than one column (Tataoui in colum3 and 4 and blank in 5 and 8), which isn't allowed in a header row.
So the solution might be to use the -NoHeader parameter or the -HeaderName parameter. Depends on your code...
In your first import, you're importing the header row, so no surprise that worked.

I did saw the error but didn't understand the context.  Given your feedback, how do I explicitly call out row 1 as the header row?  not sure if it is possible.  I updated my code to where I initially read in one column (treating it as if it was the primary key for the table)  I put it in a loop to determine the position to which row of data I would need, than I would go back to retrieve the entire row, but only a single row , and this is when I ran into the error
$OSSpecName = Import-Excel -Path $DataSourcePath -WorksheetName 'OSCustomSpec' -HeaderName Name
$targetSpec = $VMParameters.VM_Spec
#$targetSpec = 'Win2019 Spec'
$EndRow = 1
do {
$compare = $OSSpecName.Item($EndRow).name
Write-Host $compare
$EndRow++
write-host $compare, $EndRow
} until ($targetSpec -eq $compare)
write-host 'End count is' $EndRow
$StartRow = $EndRow - 1
write-host 'start count is' $StartRow

Also, I left column 5 and 8 blank for here as It contains password info.  Just don't understand why this works
$OSSpecParameters = Import-Excel -Path $DataSourcePath -WorksheetName 'OSCustomSpec'
while this does not
$OSSpecParameters = Import-Excel -Path $DataSourcePath -WorksheetName 'OSCustomSpec' -StartRow $StartRow -EndRow $EndRow
perhaps I misunderstood the purpose for the startrow and endrow switches


gps_umd: 1.0.0-1 in 'dashing/distribution.yaml' [bloom]

Increasing version of package(s) in repository gps_umd to 1.0.0-1:

upstream repository: https://github.com/swri-robotics/gps_umd.git
release repository: https://github.com/swri-robotics-gbp/gps_umd-release.git
distro file: dashing/distribution.yaml
bloom version: 0.8.0
previous version for package: null

gps_msgs
* Support ROS2 (#24 <https://github.com/pjreed/gps_umd/issues/24>)
* Contributors: P. J. Reed

gps_tools
* Support ROS2 (#24 <https://github.com/pjreed/gps_umd/issues/24>)
* Contributors: P. J. Reed

gps_umd
* Support ROS2 (#24 <https://github.com/pjreed/gps_umd/issues/24>)
* Contributors: P. J. Reed

gpsd_client
* Support ROS2 (#24 <https://github.com/pjreed/gps_umd/issues/24>)
* Contributors: P. J. Reed

Holding for sync

Holding for sync

Actually I was just waiting until the eloquent sync. We've got time to get this one in.


Subfolders of a symbolically linked folder are not included when deploying

Repro steps:

Create a function project
Add a symbolic link to a directory with subfolders
Deploy

Expected:
Linked directory and sub folders are deployed
Actual:
Only top level files of linked directory are deployed

Moved over from https://github.com/microsoft/vscode-azurefunctions/issues/1115#issuecomment-492493351 by @kobyl

I'm experiencing the same issue. Is there a work around for this problem?

Only workaround at the moment is to manually copy the folders before deploying instead of using a sym link.

FYI - @kobyl @armanio123 we just released v0.19.0 of the extension which includes a fix for this