Error when building in .NET Core 3.0 Preview 2 (CS0531, Interface Members Cannot Have A Definition)

Issue Title
Features listed in the .NET Core 3 Preview blog posts do not appear to work.
General
dotnet --version returns 3.0.100-preview-010184.  I'm running on MacOS Mojave (10.14.3).
I'm just trying to play around with some of the new features in .NET Core 3 (in this case, default interface implementations), but when I go to build, I get compiler errors.
Here is the code I'm attempting to compile:
using System;

namespace netcore3test
{
  interface ITest
  {
    bool DefaultMethod() => true;
  }

  class Test : ITest
  {
  }

  class Program
  {
    static void Main(string[] args)
    {
      Console.WriteLine(new Test().DefaultMethod());
    }
  }
}

And here is the csproj file:
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp3.0</TargetFramework>
  </PropertyGroup>

</Project>

Running dotnet build gives the following output:
TMA-1:netcore3test home  λ dotnet build
Microsoft (R) Build Engine version 16.0.385-preview+g966cdf2ac6 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Restore completed in 24.28 ms for /Users/home/Projects/netcore3test/netcore3test.csproj.
/usr/local/share/dotnet/sdk/3.0.100-preview-010184/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(151,5): message NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview [/Users/home/Projects/netcore3test/netcore3test.csproj]
Program.cs(7,10): error CS0531: 'ITest.DefaultMethod()': interface members cannot have a definition [/Users/home/Projects/netcore3test/netcore3test.csproj]
Program.cs(10,16): error CS0535: 'Test' does not implement interface member 'ITest.DefaultMethod()' [/Users/home/Projects/netcore3test/netcore3test.csproj]

Build FAILED.

Program.cs(7,10): error CS0531: 'ITest.DefaultMethod()': interface members cannot have a definition [/Users/home/Projects/netcore3test/netcore3test.csproj]
Program.cs(10,16): error CS0535: 'Test' does not implement interface member 'ITest.DefaultMethod()' [/Users/home/Projects/netcore3test/netcore3test.csproj]
    0 Warning(s)
    2 Error(s)

Time Elapsed 00:00:01.57

I installed the .NET Core 3 Preview 2 SDK.  Should I have also installed something else?

I firmly believe the issue is that the default interface member feature is just not implemented yet (see GitHub note about this C#8.0 proposal).

That's really frustrating, because the blog posts have made it appear that all of the proposed C# 8.0 features are present to some degree in the previews.

According to the preview 1 release notes, support for the default implementation of interface members is added.

@jaredpar should the C# feature be part of Preview 2?

@AlexAtNet

According to the preview 1 release notes, default implementation of interface members should be implemented.

Yes but that's referring to the runtime support for the feature. That must necessarily come first. The C# compiler support is still in progress. The target for completion is .NET Core Preview 4 at the moment. But based on scheduling it may be in Preview 5.

@jaredpar Thank you for clarification.


the globus canvas rendering freeze during window resize

Hi,
the globus canvas rendering freeze during window resize when its dimensions , width or height, drop to 0 for a while.
at the moment I used a simple workaround to solve it, I've include this piece of code to the page
window.addEventListener('resize', () => {
globus.renderer.start()
});
(I used Firefox)

Alessandro

Resizing is a heavy operation. if the size (or display none, or invisible) is zero it stops working, it's fine. When resizing, canvas decreases its resolution, but it's fine. All mechanics inside the renderer resize see ONCANVASRESIZE in renderer, and drawFrame in Handler.

It's easy to check. Set breakpoint into _toggleVisibilityChange in the Handler.js, and start and stop methods. Check https://github.com/openglobus/openglobus/pull/648 MR please.

...or better way is using System Monitor, htop or similar

MR https://github.com/openglobus/openglobus/pull/648

@Zemledelec I confirm this issue.  I'll try to reproduce and fix it

Merged! @busatoa could you check, please:)

Fine, it works!
Thank you.


Increase code coverage of Get-ChildItem on file system.

Addresses part of #4148.
Using the -Name parameter on Get-ChildItem exercises a part of the file system provider code not previously covered by tests.

You're better off comparing the returned value against the name property since, I believe, that's the intent.

Well, the intent was to check that I got the item I asked for, which is why I was comparing against $testFile. But I'll go ahead with your recommendation.

Sorry jeffbi; I should have been clearer.  When I said the intent of -Name, I mean the intent is to return the Name property of the FileInfo object.
The current implementation of FileInfo 'does' preserve the file name as it was passed in; however, since it's not documented explicitly, I avoid depending on it.
Additionally, I would expect the test to succeed with other values, such as .\filename.txt, ./filename.txt, and /etc/filename.txt
I hope that clarifies my feedback.


sqltool does not exist when using versioned migration

Refer to this doc: https://entgo.io/docs/versioned-migrations/
// Chose one of the below.
      schema.WithFormatter(sqltool.GolangMigrateFormatter),
      schema.WithFormatter(sqltool.GooseFormatter),
      schema.WithFormatter(sqltool.FlywayFormatter),
      schema.WithFormatter(sqltool.LiquibaseFormatter),

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
sqltool does not exist.
go get ariga.io/atlas/sql/sqltool
go: module ariga.io/atlas@upgrade found (v0.3.7), but does not contain package ariga.io/atlas/sql/sqltool

Expected Behavior 🤔
sqltool should exist
Steps to Reproduce 🕹

Steps:

Follow the above doc and try to use sqltool

Your Environment 🌎

Tech
Version

Go
1.18

Ent
v0.10.1

Database
MySQL

Driver
https://github.com/go-sql-driver/mysql

Hey @Meowzz95. The package sqltool was introduced post Atlas version 0.3.7. This means you need to have the current master to have that available. If you update Ent to the latest master, it will update Atlas as well and then the package will be available.
With both Ent and Atlas the master is well tested and can be considered stable. With the release of Ent v0.11.0 soon, this will be fixed as well (I have no ETA though).

I added a note to the docs in #2537.
@Meowzz95 If you have other issues / questions, do not hesitate to ask or re-open this :-)


Splitting generated code in a monorepo

It'd be great if there was a way to reference generated code between workspace packages in a monorepo instead of having them re-generated in each individual package.
For instance, I have a setup like this:
./apps/my-frontend/
./apps/my-frontend/proto
./apps/my-backend/
./apps/my-backend/proto
./packages/shared-package/
./packages/shared-package/proto/
./buf.work.yaml

All these packages & apps also rely on protos from external dependencies.
Ideally, I'd want to external dependency to be generated into shared-package and then imported from the others. However, currently there seems to be no way to achieve that and the same code for that external package is generated into each app and package over and over again.
Am I missing sth.? :-)

Maybe sth. like this could be accomplished with a custom google.protobuf.FileOptions that lets you specify a mapping of proto import path to es module import path and if a record exists for an import then protoc-gen-es would use import ... from "other module" in the generated  code instead of generating that part itself?

Hi @fubhy. We actually do something similar with the BSR. Would it be possible for you to generate your code into its own workspace package and use the rewrite_imports option to change the imports to this generated package?
For example, the usage is an option to the plugin:
opt: rewrite_imports=@bufbuild/protobuf:my/custom/path/protobuf.ts

Hi @smaye81 . I'm afraid that's not sufficient because it'd result in imports like:
import { Foo } from<EMAIL_ADDRESS>
But what I'd like to get is:
import { Foo } from "@myscope/mypackage";

Maybe we can allow regex with substitutions in the patterns in the opts?

I can make it work with glob exports. Not sure how well they are supported across the ecosystem though ...

  "exports": {
    ".": {
      "types": "./dist/types/index.d.ts",
      "import": "./dist/esm/index.js",
      "default": "./dist/cjs/index.js"
    },
    "./proto/*.js": {
      "types": "./dist/types/generated/*.d.ts",
      "import": "./dist/esm/generated/*.js",
      "default": "./dist/cjs/generated/*.js"
    },
    "./package.json": "./package.json"
  },
  "typesVersions": {
    "*": {
      "proto/*": ["./dist/types/generated/*.d.ts"]
    }
  },

This works so far but I'd still prefer to be able to control the full path substitution.

Can you provide a more reproducible example of what you're trying to accomplish. I'm pretty sure we do something quite similar in the BSR so off the top of my head, I feel like this should work, but it's hard to say for sure.

Can you provide a more reproducible example of what you're trying to accomplish. I'm pretty sure we do something quite similar in the BSR so off the top of my head, I feel like this should work, but it's hard to say for sure.

Sure. Does this work for you? https://github.com/fubhy/substreams-es/blob/main/packages/substreams-proxy/buf.gen.yaml#L6-L12
That's the codebase in question.
I'm exporting the generated code from here: https://github.com/fubhy/substreams-es/blob/main/packages/substreams/package.json#L42-L46
This is my workaround because ideally I'd like to just export them from the default entrypoint (@fubhy/substreams) and have the import paths subsituted in @fubhy/substreams-proxy to import straight from that default entrypoint. But unless I'm missing sth. with rewrite_imports, it only rewrites the prefix but does not in fact let you rewrite in a way that the trailing path is dropped entirely.

Sorry yeah I migrated the repo to an org and renamed the packages.

It does indeed do that replacement for relative paths, but if you don't use a relative path, it should replace the entire thing.
For example:
const Bar = f.import("Bar", "foo/bar_pb.js")

with the rewrite_import option of "rewrite_imports=foo/**/*_pb.js:@scope/pkg"
should result in an import of:
import { Bar } from "@scope/pkg";

Ah, good to know. But what about alternative exports entrypoints? :-P

It could be more flexible, yeah, but this is actually an undocumented secret menu item. It was created to assist us with something in the BSR and isn't 'officially' supported as an option. I think it was made about as flexible as we needed it to be, but Hyrum's Law took over and the rest is history.
Hopefully you can get the full replacement working though using non-relative imports. If not, let me know what you're trying and I'll see if I can help.

Hyrum's Law took over and the rest is history.

Heh ;-)

Hopefully you can get the full replacement working though using non-relative imports. If not, let me know what you're trying and I'll see if I can help.

I'm fine for now. Don't want you to waste time on that ;-). I'm going with the wildcard export solution that I posted earlier for now. If you are open to making this a full feature & more versatile in the future (e.g. with some basic regex capture group replacement or sth.), I'm happy to work on that.

Thanks @fubhy.  We will definitely keep you posted if anything changes with this option.
Going to close this now, but appreciate the understanding.


Capitalize search string 'Ghost' in URL segment

Since the searching method in SQLite is case-sensative, the example should pass the search string in the correct case.

@wooleyra  Thanks. Case not needed but it looks nicer.


AttributeError: 'NoneType' object has no attribute 'base_model_name_or_path'

May I ask what happened to this error

Please provide more details

Traceback (most recent call last):
File "/home/lias/OpenFedLLM-main/main_dpo.py", line 61, in
model = get_peft_model(model, peft_config)
File "/home/lias/yes/envs/opfl/lib/python3.9/site-packages/peft/mapping.py", line 90, in get_peft_model
peft_config.base_model_name_or_path = model.dict.get("name_or_path", None)
AttributeError: 'NoneType' object has no attribute 'base_model_name_or_path'

请提供更多详细信息

Traceback (most recent call last):
File "/home/lias/OpenFedLLM-main/main_dpo.py", line 61, in
model = get_peft_model(model, peft_config)
File "/home/lias/yes/envs/opfl/lib/python3.9/site-packages/peft/mapping.py", line 90, in get_peft_model
peft_config.base_model_name_or_path = model.dict.get("name_or_path", None)
AttributeError: 'NoneType' object has no attribute 'base_model_name_or_path'

Please provide more details
Traceback (most recent call last):
File "/home/lias/OpenFedLLM-main/main_dpo.py", line 61, in
model = get_peft_model(model, peft_config)
File "/home/lias/yes/envs/opfl/lib/python3.9/site-packages/peft/mapping.py", line 90, in get_peft_model
peft_config.base_model_name_or_path = model.dict.get("name_or_path", None)
AttributeError: 'NoneType' object has no attribute 'base_model_name_or_path'

Have you downloaded the base model (e.g., llama2-7b) and correctly put its path into the config?

The model is automatically downloaded from HuggingFace and downloaded to the default path of HuggingFace. Do I need to change it in the code?

Hello! I tried running the model separately and it was able to display the configuration of the model, but every time I executed the code model=get_peft_model (model, pekt_config), it couldn't load correctly. Still the same error file "/home/lias/OpenFedLLM main/main_depo. py", line 61, in
model = get_peft_model(model, peft_config)
File "/home/lias/yes/envs/opfl/lib/python3.9/site-packages/peft/mapping.py", line 90, in get_peft_model
peft_config.base_model_name_or_path = model.dict.get("name_or_path", None)
AttributeError: 'NoneType' object has no attribute 'base_model_name_or_path'

PEF==0.4.0 is also correctly installed

Hello! I tried running the model separately and it was able to display the configuration of the model, but every time I executed the code model=get_peft_model (model, pekt_config), it couldn't load correctly. Still the same error file "/home/lias/OpenFedLLM main/main_depo. py", line 61, in model = get_peft_model(model, peft_config) File "/home/lias/yes/envs/opfl/lib/python3.9/site-packages/peft/mapping.py", line 90, in get_peft_model peft_config.base_model_name_or_path = model.dict.get("name_or_path", None) AttributeError: 'NoneType' object has no attribute 'base_model_name_or_path'

It seems like your left_config is None. Could you check for that? We did not get such error before.


Nimbus uses incorrect storage location

Problem details

Nimbus does not store data in the location that is shown in the UI.
The issue is occurring on all platforms.

https://nimbus.guide/docker.html#docker-images

fixed in commit 2926e6b03615301d6494fac9c99e1a12495ee24b


Securepasswords.info

Secure passwords in several languages/frameworks, I think this might be useful to some people.
Maybe there's a place for it here somewhere!
https://securepasswords.info/

:+1: This looks great. Thank you!
Barring any catastrophes, I'll be pushing an update tonight.


ImageryProvider.loadImage bug about KTX/CRN image

I think found a bug:
Recently I tested ktx and crn image Imagery using UrlTemplateImageryProvider.
I reviewed cesium source code and I thought it's no problem to service.
But at runtime, It's not working. So I review cesium source especially about Imagery.
And found one! at ImageryProvider.js
https://github.com/AnalyticalGraphicsInc/cesium/blob/32fc04d9e7e3b26e78ca1ca4b607091846a68c1e/Source/Scene/ImageryProvider.js#L336
    ImageryProvider.loadImage = function(imageryProvider, url) {

        var resource = Resource.createIfNeeded(url);

        if (ktxRegex.test(resource)) {  //=> it should be "resource.url"
            return loadKTX(resource);
        } else if (crnRegex.test(resource)) {    //=> it should be "resource.url"
            return loadCRN(resource);
        } else if (defined(imageryProvider.tileDiscardPolicy)) {
            return resource.fetchImage({
                preferBlob : true,
                preferImageBitmap : true,
                flipY : true
            });
        }

        return resource.fetchImage({
            preferImageBitmap : true,
            flipY : true
        });
    };

I hope it can help someone.
thanks.

Thanks for reporting this @progsung - it does look like a bug to me. Were you able to get it to load the KTX image by changing that line? If you want to open a pull request to fix this, that would be awesome! The contributing guide is a good place to start here: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#opening-a-pull-request

@OmarShehata This seems to be working as intended.
KTX takes in a resource, url or buffer and then loads it through our Resource API.
function loadKTX(resourceOrUrlOrBuffer) {
        //>>includeStart('debug', pragmas.debug);
        Check.defined('resourceOrUrlOrBuffer', resourceOrUrlOrBuffer);
        //>>includeEnd('debug');

        var loadPromise;
        if (resourceOrUrlOrBuffer instanceof ArrayBuffer || ArrayBuffer.isView(resourceOrUrlOrBuffer)) {
            loadPromise = when.resolve(resourceOrUrlOrBuffer);
        } else {
            var resource = Resource.createIfNeeded(resourceOrUrlOrBuffer);
            loadPromise = resource.fetchArrayBuffer();
        }

        if (!defined(loadPromise)) {
            return undefined;
        }

        return loadPromise.then(function(data) {
            if (defined(data)) {
                return parseKTX(data);
            }
        });
    }

Same goes for LoadCRN
    function loadCRN(resourceOrUrlOrBuffer) {
        //>>includeStart('debug', pragmas.debug);
        if (!defined(resourceOrUrlOrBuffer)) {
            throw new DeveloperError('resourceOrUrlOrBuffer is required.');
        }
        //>>includeEnd('debug');

        var loadPromise;
        if (resourceOrUrlOrBuffer instanceof ArrayBuffer || ArrayBuffer.isView(resourceOrUrlOrBuffer)) {
            loadPromise = when.resolve(resourceOrUrlOrBuffer);
        } else {
            var resource = Resource.createIfNeeded(resourceOrUrlOrBuffer);
            loadPromise = resource.fetchArrayBuffer();
        }

        if (!defined(loadPromise)) {
            return undefined;
        }

        return loadPromise.then(function(data) {
            if (!defined(data)) {
                return;
            }
            var transferrableObjects = [];
            if (data instanceof ArrayBuffer) {
                transferrableObjects.push(data);
            } else if (data.byteOffset === 0 && data.byteLength === data.buffer.byteLength) {
                transferrableObjects.push(data.buffer);
            } else {
                // data is a view of an array buffer. need to copy so it is transferrable to web worker
                data = data.slice(0, data.length);
                transferrableObjects.push(data.buffer);
            }

            return transcodeTaskProcessor.scheduleTask(data, transferrableObjects);
        }).then(function(compressedTextureBuffer) {
            return CompressedTextureBuffer.clone(compressedTextureBuffer);
        });
    }

So while passing a URL should work it is no different than what we are doing currently. Let me know if I missed anything; otherwise, we can probably close this issue.

@ProjectBarks take another look at the issue original  description and sample code.  The issue here is that we are passing Resource objects to the ktxRegex and crnRegex regular expression to determine the file type, not that we are passing resources   This is happening in both ImageryProvider and Material

@mramato ahh totally missed it! Fix coming soon.

Fixed in https://github.com/AnalyticalGraphicsInc/cesium/pull/8064


Make vclusterops the default deployment for v1 API

This PR makes the change so that default deployments of the v1 API use vclusterops and continue defaulting to admintools-based deployments for v1beta1. Additionally, it sets the vertica.com/vcluster-ops to false for the v1beta1 webhook.

After adding CR v1 API to use vclusterops by default and adding v1beta1 to use AT, I observed numerous e2e failures but passed UT tests. @spilchen , one thing I am concerned about is that I remember you mentioning that we might have a lot of failures in UTs. I just want to reproduce the problem to identify UT failures

After I add CR v1 api  to use vclusterops by default,  and add v1beta1 to use AT. I see a lot e2e failure, and pass UT tests. @spilchen ,one thing I concern I remember you mentioned that we will have a lot failures in UTs. I just want to reproduce the problem to see UT Failures

A few additional changes that we need:

the setting of the annotation should be done in verticadb_conversion.go, in the the function ConvertTo. This gets called each time we from v1beta1 -> v1. We only set the annotation if it isn't already set.
the default value in pkg/meta/annotations should change the default value for vcluster-ops. This will ensure that all v1 APIs will default to vclusterops. This likely will break a bunch of UTs though.

For second bullet point, I would like to confirm when you refer to the default value, are you suggesting that we need to change the default value for vcluster-ops so that all v1 APIs will default to it? Are you suggesting something like this:
VClusterOpsAnnotation = "vertica.com/v1"

I saw that only two unit tests were failed.

A few additional changes that we need:

the setting of the annotation should be done in verticadb_conversion.go, in the the function ConvertTo. This gets called each time we from v1beta1 -> v1. We only set the annotation if it isn't already set.
the default value in pkg/meta/annotations should change the default value for vcluster-ops. This will ensure that all v1 APIs will default to vclusterops. This likely will break a bunch of UTs though.

For second bullet point, I would like to confirm when you refer to the default value, are you suggesting that we need to change the default value for vcluster-ops so that all v1 APIs will default to it? Are you suggesting something like this:
VClusterOpsAnnotation = "vertica.com/v1"

I saw that only two unit tests were failed.

No. We have to change UseVClusterOps so that it returns true if the annotation isn't set. This will ensure that all v1 APIs default to true. v1beta1 should go through the conversion and have the annotation set for them to false.

With this change, we are facing an error from Scrutinize that cannot find a database to target in the vdb-gen test in e2e-s3. I'm trying to fix it
Warning: No databses are defined! Please create a database to scrutinize.
Error: Scrutinize could not find a db to target. Cannot collect diagnostics


RefRemoteSpec fails on Travis

No issues when run locally.

I think I found why the exception was not displayed. I will publish a new specs2 version and create a PR with that which should give us more information.

There haven't been any issues recently, so I'm closing this.


Available trained model weights (ckpt files) and processed data (bigwig files)?

Thank you for your amazing work!
I want to try this model as soon as possible, but I find that some files in the tutorial are missing.
Have the trained model weights (ckpt files) been released? If so, users as me can use this model without training.
checkpoint = 'results/bigmodel_h512_l12_lr1e-5_epoch=38-step=746889.ckpt'
model = TrainModule.load_from_checkpoint(checkpoint).to(device)
model = model.eval()
If the processed data (bigwig files) of 40 paired datasets is available, it's even better. It also means that other researchers can train or even refine the model without time-consuming pre-processing of raw FASTQ data.
rna_bw_file = 'data/hg38/K562/GSE153597/input_features/rnaseq.bw'
ribo_bw_file = 'data/hg38/K562/GSE153597/input_features/riboseq.bw'

Sorry for my carelessness... Now I have located the Example ckpt and bw files in Example data and pretrained Translatomer model (zenodo.org). Besides, I would like to ask if it is appropriate to publicly release the processed data (bigwig files) of all 40 paired datasets?

Just to add to this, would it be possible to also request the sequence only model? Thank you!


Fix HdfsLocatedFileStatus and FileStatusWithmetadata class type conve…

…rsion errors
:mag: Description
Issue References 🔗

This pull request fixes #
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes :bookmark:

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklist 📝

[ ] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

Mind filling in the PR description about which issue you have faced?

When I connect to HIVE to read data, an error message will appear as follows:
Caused by: java.lang.ClassCastException: org.apache.hadoop.hdfs.protocol.HdfsLocatedFileStatus cannot be cast to org.apache.spark.sql.execution.datasources.FileStatusWithMetadata 	at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:286) 	at scala.collection.IndexedSeqOptimized.foreach(IndexedSeqOptimized.scala:36) 	at scala.collection.IndexedSeqOptimized.foreach$(IndexedSeqOptimized.scala:33) 	at scala.collection.mutable.WrappedArray.foreach(WrappedArray.scala:38) 	at scala.collection.TraversableLike.map(TraversableLike.scala:286) 	at scala.collection.TraversableLike.map$(TraversableLike.scala:279) 	at scala.collection.AbstractTraversable.map(Traversable.scala:108) 	at org.apache.spark.sql.execution.datasources.FilePartition$.$anonfun$maxSplitBytes$2(FilePartition.scala:116) 	at scala.collection.immutable.Stream.flatMap(Stream.scala:489) 	at org.apache.spark.sql.execution.datasources.FilePartition$.maxSplitBytes(FilePartition.scala:116) 	at org.apache.kyuubi.spark.connector.hive.read.HiveScan.partitions(HiveScan.scala:89) 	at org.apache.spark.sql.execution.datasources.v2.FileScan.planInputPartitions(FileScan.scala:177) 	at org.apache.spark.sql.execution.datasources.v2.FileScan.planInputPartitions$(FileScan.scala:176) 	at org.apache.kyuubi.spark.connector.hive.read.HiveScan.planInputPartitions(HiveScan.scala:41)
compared org.apache.spark.sql.execution.datasources.PartitioningAwareFileIndex#listFiles method,  found that the calling method for the PartitionDirectory class has changed in [SPARK-43039] https://github.com/apache/spark/pull/40677
So is this modification correct?

Mind filling in the PR description about which issue you have faced?

pls refer to the comments above

Please provide the component versions and reproducible use cases, this helps the reviewer to evaluate the patch

Please provide the component versions and reproducible use cases, this helps the reviewer to evaluate the patch

I found that this bug has been fixed in the v1.9.0, just last month

Please provide the component versions(for self complied version, compiling command should be provided too) and reproducible use cases, this helps the reviewer to evaluate the patch

ty for your help


Can not copy and paste image into Word

Not sure why PNG image generated can not be directly copy and pasted into Microsoft Word - what gets pasted is a small blank square.
I have to either paste into MS Paint and then copy and paste from that into Word, or save the PNG first and go from there.
When I test a PNG file from a regular website, it doesn't have this problem, what gives?

This sounds quite peculiar, but other applications can do quirky things. Sorry for the late response, but did you also try just dragging it to your desktop, then to MS Word?


Introduce the 'Sort by' filter in tutorials

Hey @carlosgauci - we are ready to introduce the 'sorting' into the tutorials page.
We now have the following frontmatters being added to the tutorials:
e.g.:
created_at: 2023-11-01
last_updated: 2023-02-15

Could we have a sort by that the user can select to see the 'latest-oldest' tutorials (E.g. Sort by 'date created')
and also one to sort by latest updated - oldest updated (E.g. Sort by 'date updated)
And we could use these frontmatters above to do that. Wdyt?

Fixed with #94


apt repository

Hello,
Why Deno isn't installable with apt? It would be simpler for the users.
Thank you!

ref https://github.com/denoland/deno/issues/1583


Search is not working

https://bower-component-list.herokuapp.com/ GET returns 418 I'm a teapot

https://gitter.im/bower/bower


Initial stab at future Ajax support

Proposed changes
Add a callback hook just before data is consulted, leveraging
the logic that is already there (irrelevant keys, minlength, etc).
This needs more work to deal with requests that typically take longer
than the time it takes for a user to type multiple keys, but the API
for the callback is very unlikely to change as all that logic can
be encapsulated in the callback itself.
I'm not well-versed in JS unit tests, but will add them if the proposed
implementation is accepted.
Contributes to #4086 .
Screenshots (if appropriate) or codepen:
A (working) AJAX implementation is in this branch.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

The API looks good but I have a question: should we trigger this instantly or should we defer like 100ms to give the user a chance to type another character before firing the event ?


add summation_block + implicit signal interconnection

This PR addresses the enhancement describe in issue #516 where signals with the same name are automatically interconnected by the interconnect function.  It also defines a new function summation_block that addresses the request in issue #493.  Together, these capabilities allow the following code to work for setting up a simple feedback system:
P = ct.ss2io(
    ct.rss(2, 1, 1, strictly_proper=True),
    inputs='u', outputs='y', name='P')
kp = ct.tf(random.uniform(1, 10), [1])
ki = ct.tf(random.uniform(1, 10), [1, 0])
C = ct.tf2io(kp + ki, inputs='e', outputs='u', name='C')
sumblk = ct.summation_block(inputs=['r', '-y'], output='e', name="sum")
Tio_sum = ct.interconnect(
    (C, P, sumblk), inplist=['r'], outlist=['y'])

Other minor changes:

Added code to allow the iosys.feedback function to accept a float_like for the feedback system (so that feedback(P * C, 1) now works.

Coverage increased (+0.2%) to 87.812% when pulling 012d1d0d4b1c7451ec039e85c5c48132224b34db on murrayrm:sumblk_implicit_interconnect into 1502d38c4a78cbc4f49bbd758d892fd1d2b48071 on python-control:master.

Coverage increased (+0.2%) to 87.812% when pulling 012d1d0d4b1c7451ec039e85c5c48132224b34db on murrayrm:sumblk_implicit_interconnect into 1502d38c4a78cbc4f49bbd758d892fd1d2b48071 on python-control:master.

Very cool!
I particularly like that it appears possible with this to leave out the ‘name’ keyword for simple systems like this. That keyword is somewhat redundant and prone to errors when code gets modified.
If you give the sumblock more input names (eg 3 instead of 2), does it sum those three signals?

Very cool!
I particularly like that it appears possible with this to leave out the ‘name’ keyword for simple systems like this. That keyword is somewhat redundant and prone to errors when code gets modified.
If you give the sumblock more input names (eg 3 instead of 2), does it sum those three signals?

it appears possible with this to leave out the ‘name’ keyword for the constitutive systems for simple interconnections like this. Am I correct in that?

Correct.  The following works just fine (from #516):
P = ct.tf2io(ct.tf(1, [1, 0]), inputs='u', outputs='y')
C = ct.tf2io(ct.tf(10, [1, 1]), inputs='e', outputs='u')
sumblk = ct.summation_block(inputs=['r', '-y'], output='e')
T = ct.interconnect((P, C, sumblk), inplist='r', outlist='y')

(P, C, and sumblk all have names automatically assigned, but not needed here).

If you give the sumblock more input names (eg 3 instead of 2), does it sum those three signals?

Yup.  Any number of inputs can be summed together.  The summation_block function does not require named signals, so you can also do ct.summation_block(7) if you want a LinearIOSystem that has 7 inputs and 1 output (sum of the inputs), for example).
Some possible tweaks:

I think I may use the term summing_junction (instead of summation_block) to line up with the term we use in FBS.
I will add a bit more documentation, both in docstrings and in the manual
I want to switch all examples using InterconnectedSystem to use interconnect since using the class constructor since the function provides a slightly higher level interface (eg, the class constructor still requires the explicit signal name).

it appears possible with this to leave out the ‘name’ keyword for the constitutive systems for simple interconnections like this. Am I correct in that?

Correct.  The following works just fine (from #516):
P = ct.tf2io(ct.tf(1, [1, 0]), inputs='u', outputs='y')
C = ct.tf2io(ct.tf(10, [1, 1]), inputs='e', outputs='u')
sumblk = ct.summation_block(inputs=['r', '-y'], output='e')
T = ct.interconnect((P, C, sumblk), inplist='r', outlist='y')

(P, C, and sumblk all have names automatically assigned, but not needed here).

If you give the sumblock more input names (eg 3 instead of 2), does it sum those three signals?

Yup.  Any number of inputs can be summed together.  The summation_block function does not require named signals, so you can also do ct.summation_block(7) if you want a LinearIOSystem that has 7 inputs and 1 output (sum of the inputs), for example).
Some possible tweaks:

I think I may use the term summing_junction (instead of summation_block) to line up with the term we use in FBS.
I will add a bit more documentation, both in docstrings and in the manual
I want to switch all examples using InterconnectedSystem to use interconnect since using the class constructor since the function provides a slightly higher level interface (eg, the class constructor still requires the explicit signal name).

Awesome.
New name for summer sounds better.
Hoping this will make creating simulink-like interconnected system simulations much easier. I will let you know how it goes once it’s been merged in.

Awesome.
New name for summer sounds better.
Hoping this will make creating simulink-like interconnected system simulations much easier. I will let you know how it goes once it’s been merged in.

Very nice!
(Now we will have users demanding a graphical editor next :grin:. Implemented as jupyter notebook widget or the like.)

Very nice!
(Now we will have users demanding a graphical editor next :grin:. Implemented as jupyter notebook widget or the like.)

I think the first step in that direction might be to add an option in
interconnect to draw a block diagram. This could be done using matplotlibs
pretty good capabilities  for this.
--
Sawyer Fuller
Assistant Professor of Mechanical Engineering
Adjunct, Paul G Allen School of Computer Science
University of Washington
http://faculty.washington.edu/~minster/
(Typed with my thumbs)

I think the first step in that direction might be to add an option in
interconnect to draw a block diagram. This could be done using matplotlibs
pretty good capabilities  for this.
--
Sawyer Fuller
Assistant Professor of Mechanical Engineering
Adjunct, Paul G Allen School of Computer Science
University of Washington
http://faculty.washington.edu/~minster/
(Typed with my thumbs)


Docs Website Down

The docs website is down just now, can someone fix it?
https://docs.nodeactyl.xyz/

Hello, use this link please.

ok


Revert recent repo refactor

These changes broke my workflow as I've mentioned on https://github.com/FuelLabs/fuels-ts/pull/238#issuecomment-1118749157.
It also seems to have broken our publishing CI flow: https://github.com/FuelLabs/fuels-ts/pull/242
We should revert these changes and introduce them again when we are sure we won't have these regressions.

I think we should wait and push #242 to be merged.

It already has been 3 days :D

We merged #242 @AlicanC, CI is fixed and now you can use pnpm build:watch to build packages.

I'm on that branch and I'm not 100% sure we are done with regressions. I'll LYK.

The current issue I'm having is:
On fuels-ts:
- Run `pnpm i`
- Run `pnpm -r exec yarn link`
- Run `pnpm build:watch`

On swayswap:
- Run `yarn link fuels typechain-target-fuels`
- Run `yarn start`

On fuels-ts:
- Make a change and save

On swayswap:
- CRA doesn't see the changes, I need to stop and run `yarn start` again

Anyways, I've spent hours on #238 this week and I need to get back to work. It's just not working for me and I'll be working on my reverted branch.

The current issue I'm having is:
On fuels-ts:
- Run `pnpm i`
- Run `pnpm -r exec yarn link`
- Run `pnpm build:watch`

On swayswap:
- Run `yarn link fuels typechain-target-fuels`
- Run `yarn start`

On fuels-ts:
- Make a change and save

On swayswap:
- CRA doesn't see the changes, I need to stop and run `yarn start` again

Anyways, I've spent hours on #238 this week and I need to get back to work. It's just not working for me and I'll be working on my reverted branch.

I think this is what you are looking for, I also had the same problem, and we fix it here;
To link the packages you need to;
On fuesl-ts root directory;

Run pnpm -r exec pnpm link --global --dir ./
If you want to have live reload on the project to automatically sync changes on the packages run also;
-pnpm pnpm build:watch

On the swayswap root folder;

pnpm link --global <linked package name>
Ex.:
Make sure yarn start is not running
pnpm link --global fuels
pnpm link --global @fuel-ts/wallet
Run yarn start

Maybe we should add something like this to the docs.
Ref.: https://github.com/FuelLabs/fuels-ts#build-and-watch-all-packages

Just open a PR to improve the docs also; https://github.com/FuelLabs/fuels-ts/pull/254

@AlicanC we can close this?

Run pnpm build:watch
Go to packages/providers/src/script.ts
Rename class Script to class ScriptFoo
You will see a build error as expected
Revert the change and fix the error
Rename getArgOffset to getArgOffsetFoo
You see no errors

It's probably because unlike Script, getArgOffset is not used in the providers package itself. If you go to packages/contract/src/scripts.ts you see the error in the editor though. (You don't get this error even if you run pnpm build.)
How can I see all TS errors over all packages while developing?

Also, have you tried linking typechain-target-fuels? (pnpm link --global fuels typechain-target-fuels)
I tried to run yarn build-contracts on SwaySwap client and it said js-sha3 not found or something like that. Turning on this feature fixed it: https://pnpm.io/npmrc#shamefully-hoist
Seems like PNPM is trying to do some tricks like Yarn 2 does with Plug'n'Play and breaking things.

@AlicanC should we merge master and move with this?

Even though we wanted to revert this PR isn't the way.


Finding potential problems with JSHint

I added JSHint to the project and checked for errors. If you don't like certain commits, I can exclude them from the PR :smile:

Thanks! :smile:


Fix gws memo import msg

Coverage increased (+0.01%) to 84.866% when pulling 5a07025a61eaee9420d7943cb5527c7594f6b61d on fix-gws_memo_import_msg into 00dbd81da2e13237f7e3f557c696df952d0b1cce on master.

https://github.com/shirasagi/shirasagi/pull/4448


Fold Toggle

Feature description
Add a :foldtoggle which opens the fold if closed and close the fold if opened.
Describe the solution you'd like
Toggle fold to the opposite state.
Additional context
No response

:h za


[Fieldgroup Request] table 5955 "Skill Code"

Hi,
please add a dropdown fieldgroup to the table 5955 "Skill Code". We want to extend the DropDown fieldgroup, but before we can do this, there has to be one.
fieldgroups
{
fieldgroup(DropDown; Code, Description)
{}
}

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 42571.


Cannot download the data and model zip files. Links are not working

When i click on the data and model links, they are not getting downloaded. Help me to download them. Thanks :)

Hi, could you try now?

It's still not working. Is it possible to provide a google drive link for the zip files?

Sorry about this - do these links work?
http://tomho.sk/models/separator/data_paralex.zip
http://tomho.sk/models/separator/data_qqp.zip
http://tomho.sk/models/separator/separator_paralex.zip
http://tomho.sk/models/separator/separator_qqp.zip

No, even these also not working. When i click the link, it is not getting redirected to any page.

GitHub is doing something weird to the links - if you copy the url into a new tab, does the download start then?

Yes now its working, if I copy and do it. It is getting downloaded. Thank you so much Tom.

OK great - please let me know if you have any other problems :)


kopia: 0.17.0 -> 0.18.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 357832

x86_64-linux

:white_check_mark: 1 package built:

kopia

x86_64-darwin

:x: 12 packages failed to build:

python311Packages.cirq
python311Packages.cirq-rigetti
python311Packages.cirq-rigetti.dist
python311Packages.cirq.dist
python311Packages.pyquil
python311Packages.pyquil.dist
python312Packages.cirq
python312Packages.cirq-rigetti
python312Packages.cirq-rigetti.dist
python312Packages.cirq.dist
python312Packages.pyquil
python312Packages.pyquil.dist

:white_check_mark: 9 packages built:

kopia
python311Packages.tololib
python311Packages.tololib.dist
python311Packages.types-deprecated
python311Packages.types-deprecated.dist
python312Packages.tololib
python312Packages.tololib.dist
python312Packages.types-deprecated
python312Packages.types-deprecated.dist

aarch64-darwin

:white_check_mark: 5 packages built:

kopia
python311Packages.tololib
python311Packages.tololib.dist
python312Packages.tololib
python312Packages.tololib.dist

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 357832

x86_64-linux

:white_check_mark: 1 package built:

kopia

x86_64-darwin

:white_check_mark: 1 package built:

kopia

aarch64-darwin

:white_check_mark: 1 package built:

kopia


Don't load PasswordInfos when using DB

 Issue by bobbyrullo
Friday Jun 12, 2015 at 16:46 GMT
Originally opened as https://github.com/coreos-inc/auth/issues/253

@bobbyrullo could you elaborate a little more on this one?

closing as dup of #286 (since it has more details)


removeHotSpot does nothing when hotspot is not in current scene

Possible bug.  Pannellum: viewer.removeHotSpot() does nothing if the hotspot is not in the current scene.
The user invokes my javascript which uses viewer.addHotSpot() to create a hotspot.  If the user invokes my javascript which uses viewer.removeHotSpot() then the hotspot is removed ok.
On the other hand, this other scenario has a problem.  The user is in Scene A and invokes my javascript which uses viewer.addHotSpot() to create a hotspot (let's call it Hotspot A).  The user follows a scene-type hotspot (Hotspot B) defined in pannellum.viewer('panorama', {"scenes": {}}) and is now viewing Scene B.  The user then invokes my javascript to do a viewer.removeHotSpot() on Hotspot A.  When the user follows other scene-type hotspots to return to Scene A, they find Hotspot A still there!
I am sending hotspot ids to console.log() when creating and removing them, and my javascript for removing the hotspot is the same function in both scenarios.
I'm using Pannellum v2.4.0, which I downloaded today, running Chrome on a Windows7 computer and an Android mobile phone.  This behaviour also occurred in Pannellum v2.3.2.

Calling removeHotSpot() on these hotspots in a scene other than the current scene returns false

The removeHotSpot method only supported the current scene. When the user switched to a different scene, no hot spot with the specified ID existed, so the method returned false.
I added an optional second argument to the removeHotSpot method in c94815ee317f926c97f4bb9544d1853e1f200ffe to allow the scene to be specified, which will allow you to remove hot spots from non-active scenes.


page methods (waitFor, goto, etc.) should reject when page closed

Steps to reproduce
Tell us about your environment:

Puppeteer version: 1.3.0
Platform / OS version: macOS
Node.js version: 10.0.0

What steps will reproduce the problem?
Please include code that reproduces the issue.
var puppeteer = require('puppeteer')
;(async ()=>{
  var browser = await puppeteer.launch({headless:false})
  var page = await browser.newPage()
  var closed = new Promise(r=>page.on('close', r))
  page.goto('https://github.com', {timeout: 0})
  var pending = page.waitFor(60e3) // anything like '#selector'
  await Promise.race([ closed, pending ])
  await browser.close()
  console.log('end')
})()

When chromium opened, close the page within 10s

What is the expected result?
Node process should be terminated, console should print 'end'
The pending page promises should be rejected after page closed.
What happens instead?
console print 'end', but process never end until 1min elapsed.
After page closed, the pending page promises still waiting for events/selectors, etc.

Dupe of #1454.


Documentation update related module deactivation in Helmchart

Description
about module deactivation in Helmchart the documentation saids that we need to disable module with
module: {}
but  must be
module: false
Related Issues
List related issues.
Testing
I deployed in my infrastructure
module: {}
but this did not work
Checklist

[ ] Does my change need to be backported to a previous release?

What backport versions were discussed with the Maintainers in the Issue?

[ ] I made sure to update CHANGELOG.md.
Remember, the CHANGELOG needs to mention:

Any new features
Any changes to our included version of Envoy
Any non-backward-compatible changes
Any deprecations

[ ] This is unlikely to impact how Ambassador performs at scale.
Remember, things that might have an impact at scale include:

Any significant changes in memory use that might require adjusting the memory limits
Any significant changes in CPU use that might require adjusting the CPU limits
Anything that might change how many replicas users should use
Changes that impact data-plane latency/scalability

[x] My change is adequately tested.
Remember when considering testing:

Your change needs to be specifically covered by tests.

Tests need to cover all the states where your change is relevant: for example, if you add a behavior that can be enabled or disabled, you'll need tests that cover the enabled case and tests that cover the disabled case. It's not sufficient just to test with the behavior enabled.

You also need to make sure that the entire area being changed has adequate test coverage.

If existing tests don't actually cover the entire area being changed, add tests.
This applies even for aspects of the area that you're not changing – check the test coverage, and improve it if needed!

We should lean on the bulk of code being covered by unit tests, but...
... an end-to-end test should cover the integration points

[ ] I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.

[ ] The changes in this PR have been reviewed for security concerns and adherence to security best practices.

Hi @alexgervais or @AliceProxy, I noticed that you are listed as project maintainers.
Could we please merge this README update? It is a basic change in the code comments nothing else
The documentation has been somewhat confusing as it suggests using module: {} for module deactivation using the Helmchart. However, after conducting personal tests, I found that deactivating the module is achieved with module: false.
To prevent further confusion, I have updated the README accordingly.
Thank you.


Stop importing everything everywhere

🚀 Feature
Ease of Programming vs Deployment is here.
Using from mantisshrimp.imports import * this causes deployment issue. It would lead to the import of unnecessary libraries and immediately give errors.
E.g. when the user needs only inference, he starts importing the model. We have mantisshrimp.imports import * which will try importing fastai and lightning. Which will throw an error.
Same thing for utils mantisshrimp.utils import *.
This is a painful refactor but this causes the biggest issue while deploying. It would be hard to program with this but if we can limit the imports it will be easy and consume less memory footprint too. We cannot create PyPI packages.
pip install mantisshrimp # This is not bare for ease of new users. It downloads all
pip install mantisshrimp[bare]
pip install mantisshrimp[lightning]
pip install mantisshrimp[fatai]

This is not happening anymore, soft dependencies are already in play
Closing this =)


istio remote template: add ability to deploy the ingressgateway

Describe the feature request
the istio remote chart should have the ability to deploy the ingressgateway.
If you have multiple clusters, potentially in different geographies, it should be possible to have a way to enter the mesh in each of the cluster, so it makes sense to deploy at least one ingress gateway.
Describe alternatives you've considered
my current alternative is to deploy the gateway manually
Additional context
probably a similar reasoning can be applied to the egressgatway

Yes, we can close this.
On Fri, Dec 28, 2018, 3:25 AM Yongli Chen<EMAIL_ADDRESS>wrote:

@raffaelespazzoli https://github.com/raffaelespazzoli Is #9986
https://github.com/istio/istio/pull/9986 what you are looking for?
Also, How are you deploying the gateway manually?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/9888#issuecomment-450274721, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AF5I3NCdESQivB8XbYlz3qPqW4MjPqvFks5u9YEogaJpZM4YYp23
.


watch checked changes

checked property is passed from parent to child (Switch);
value property is passed to parent;

Thanks :) I've a better switch on Buefy btw, used this one as base but changed a lot.


counters component could use internal routing

Describe the bug
The counters component on the explore/site pages impacts general user experience because it's performance is poor to the non-usage of internal routing.
To Reproduce
Visit the demo page. https://dspacecris7.4science.cloud/home
Go to counters bar/row.
Click any counter

site is reloaded because no internal route is set.
Expected behavior
no reload of page when switching to the explore pages.
Related work
Might open some PR in future to this issue with our working solution to this issue if i have time.
Conclusion:
https://github.com/4Science/dspace-angular/blob/dspace-cris-7/src/app/shared/explore/section-component/counters-section/counters-section.component.ts goToLink(...) might be replaced with router.navigateByUrl() or some [routingLink] might be added to the links considering the url and additional considering possible queryParams.

meanwhile superseded by similar commit https://github.com/4Science/dspace-angular/commit/c1c5a6639703d3502dd3c1fe85d4d6ef0ef5f24c#diff-fa2b04cc8f2b5b8a618883582c9320466bdc4c36f1f14506164744cefe370f1f


fix(contrib): urlopen call hangs

The urllib.urlopen(url) call consistently hangs while wget and
curl succeed to the same URL for retrieving the AMIs. Tested use
of urllib2 on Ubuntu Trusty (py 2.7.6) and CentOS 7 (py 2.7.5).

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.
Your Pull Request can earn you credit at DigitalOcean! See http://docs.deis.io/en/latest/contributing/hacking/#digitalocean-credit for details.

Jenkins, add to whitelist.
The code probably should have been using urllib2 anyway, but I'm curious if you have any more insight into why it hangs. We use Ubuntu Trusty (Python 2.7.6) on all CI nodes, and they hit this code path and haven't seen problems.

No real further insights, at the moment, @mboersma. The stacktrace is below, but might be misleading. I feel it is a urllib bug in combination with configuration of certain private/work networks. I now have had better luck from other networks, but cannot narrow it down to proxy, IPv6 (6to4), etc....
$ time ./gen-json.py
^CTraceback (most recent call last):
  File "./gen-json.py", line 15, in <module>
    amis = json.load(urllib.urlopen(url))
  File "/usr/lib64/python2.7/urllib.py", line 87, in urlopen
    return opener.open(url)
  File "/usr/lib64/python2.7/urllib.py", line 208, in open
    return getattr(self, name)(url)
  File "/usr/lib64/python2.7/urllib.py", line 346, in open_http
    errcode, errmsg, headers = h.getreply()
  File "/usr/lib64/python2.7/httplib.py", line 1117, in getreply
    response = self._conn.getresponse()
  File "/usr/lib64/python2.7/httplib.py", line 1045, in getresponse
    response.begin()
  File "/usr/lib64/python2.7/httplib.py", line 409, in begin
    version, status, reason = self._read_status()
  File "/usr/lib64/python2.7/httplib.py", line 365, in _read_status
    line = self.fp.readline(_MAXLINE + 1)
  File "/usr/lib64/python2.7/socket.py", line 476, in readline
    data = self._sock.recv(self._rbufsize)
KeyboardInterrupt

real    17m37.699s
user    0m0.079s
sys     0m0.016s

Thanks @dustinrc!

Congratulations @dustinrc! You've earned $75 of DigitalOcean credit, enough to run a Deis cluster for over a month.
Please email<EMAIL_ADDRESS>to confirm, and we will reply with your DigitalOcean voucher codes.
Thanks again for contributing to Deis!


Implement check-implication in booster

Algorithm sketch:

First unify the two terms.

Result: a substitution
Failure: implication is false
Indeterminate: need to fall back to legacy kore

Apply substitution to constraints in antecedent and consequent.
Goal is to prove subst(antecedent) => subst(consequent)

First simplify the conditions one at a time (optional)
Result: actual antecedents, consequents (the ones not trivially true)

If anything is false in antecedent: implication is trivially true
If anything is false in the consequent: implication is false (we already checked that the antecedent is not false)
Otherwise, check with the SMT solver
The Booster.SMT.checkPredicates function provides most of the tooling required for the last point (but needs to change slightly to identify the special cases.

First match the two terms with the tri-state matching algorithm on the configurations.

If we get does not unify: return false.
If we get indeterminate: consult old backend.

With the matching substitution from the tri-state matching algorithm, instantiate the constraints of the consequent. Then build subst(consequent_constraints) #Implies antecedent_constraints.

First remove all clauses from the consequent that also show up exactly the same in the antecedent. If the consequent is now empty, return true.
Next, call the simplify endpoint in the booster on the result. If it gives back Top, return true.
Next, call the simplify endpoint in the old backend. If it gives back Top, return true.
Otherwise, give up and pass the entire problem back to the old backend.


Add Voice-to-Text Notepad Feature

🌟 Feature Overview
Enable voice-to-text in Notepad for hands-free note-taking.
🤔 Why this feature?
Helps users take notes faster, improves accessibility, and allows multitasking.
📋 Expected Behavior
Voice Activation: Start voice input with a button or shortcut.
Accurate Transcription: Transcribe spoken words accurately with basic editing commands.
Auto-Save: Save text automatically as users speak.

This is not related with Python Voice Assistant Project  Our Project is like a siri, Google Assistant


Change ConnorGBrewster to cbrewster

I recently changed my github username to cbrewster to match up with IRC.

This change is

Thanks for the pull request, and welcome!  Thanks for the r+s


Freetts: fix build

Motivation for this change
#18282 - freetts build is broken
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

All I've verified is that it does build now.

Updated.


Can onResponse use isolate ?

Request Statement
On debug mode, Dio use onResponse to print data when flutter receive some network response. When network response are HEAVY and as onResponse print synchronously, app got some time stuck or slowed hard.
Is it possible to have a feature like this ?
Solution Brainstorm
Isolate, compute or async debug print.
On my app I did that :
class IsolateLogger {
  void Function(Object object) logPrint = print;

  static void logResponse(Response<dynamic> response) =>
      IsolateLogger()._printResponse(response);

  void _printResponse(Response<dynamic> response) {
    logPrint('*** Response ***');
    _printKV('uri', response.requestOptions.uri);

    _printKV('statusCode', response.statusCode);
    if (response.isRedirect == true) {
      _printKV('redirect', response.realUri);
    }

    logPrint('headers:');
    response.headers.forEach(
      (String key, List<String> v) => _printKV(' $key', v.join('\r\n\t')),
    );

    logPrint('Response Text:');
    _printAll(response.toString());

    logPrint('');
  }

  void _printKV(String key, Object? v) {
    logPrint('$key: $v');
  }

  void _printAll(dynamic msg) {
    msg.toString().split('\n').forEach(logPrint);
  }
}

class CustomInterceptors extends Interceptor {
  @override
  void onResponse(
    Response<dynamic> response,
    ResponseInterceptorHandler handler,
  ) {
    compute(IsolateLogger.logResponse, response);
    return handler.next(response);
  }
}

 final Dio dio = Dio();
 dio.interceptors.add(CustomInterceptors());

We don't print things generally until you explicitly add an interceptor AFAIK. Can you identify which part of the source code is affecting your performance?

We don't print things generally until you explicitly add an interceptor AFAIK. Can you identify which part of the source code is affecting your performance?

Performance drop when app receive a big body response when add this interceptor from Dio : LogInterceptor.

Performance drop when app receive a big body response when add this interceptor from Dio : LogInterceptor.

This is more accurate. :) Please do the same indication next time.

As it turns out using the compute didn't gain too much performance improvement as this point. Also we're unlikely to take more care about the debug mode. Closing as won't fix.


investigate swapping atomic_write in favour of dependency

atomicwrites is simple, pure python and more robust cross platform than ours (which we weren't testing).
The only complexity is our code tried to support atomic write to a zip archive. Investigate whether we can simply drop this zip based support (which is not truly atomic because of how those archives work) and integrate this third party library otherwise.
If we do the latter, then it means:

add it into the tox.ini as a dependency
add it to the setup.py install_requires variable
change the usages.

Adapting our existing class to windows requires we actually write a test and then handle the windows case be renaming the original file, moving the new one into it's place, unlink the original. Come to think of it, that might be simplest...

fixed in 1f89f0a43a02ff6e9d62c9bab8f63ccb13b5f599


chore(fedimintd): fix discription of Cargo.toml

Replace fedimint to fedimintd in it

but I have a doubt ->
fedimint-server , fedimint-build& this one -> all have same description :
Is it because,  they work together to perform a specific functionality
or is it  is mistyped??

No, someone just copy+pasted the Cargo.toml file and nobody noticed it.

No, someone just copy+pasted the Cargo.toml file and nobody noticed it.

Should I fix it or not required?

Yea, just call it "Fedimint build script utilities for including git version information in builds" :)

sry, but not getting what you mean?

I thought you asked if it would make sense to change the description of fedimint-builds and I gave a fitting description.


control plane message framework support for raft

Send a yaml / json file to the ut-control module

If the device is vDevice, then send the message onto a an http port as defined by the configuration

if the device is a real device, then control the module as specified would have to be controlled in a specific way.

Rack configuration will be defined and fixed and will likely use the pulse 8 device -> https://www.pulse-eight.com/p/104/usb-hdmi-cec-adapter

Expectation is the the ut-control module, will have multiple devices that it supports, and that the rack configuration will be setup to define the devices per module that are controllable.

Messages sent to ut-control are defined by the testing suites

Messages will direct either to the vDevice to be processed, or to the external hardware which will mimic the physical control.

Example message for the HDMICEC Commands:-
User Commands
HdmiCec

ImageViewOn - User Selects by power on, TV should become active.
Active Source - Change the active source, re-assert the active command
Standby - Put a device on the HDMI Network in standby
Hotplug - Unplug a cable from a device

Internal Messages (maybe rejected from the module).

Give  - Give Physical Address ( External Message )

Attached picture of the framework proposal

Control Plane Overview > https://github.com/rdkcentral/ut-core/wiki/5.1:-Standards:-Control-Plane-Overview


UTF-8 properties files

Properties files are typically encoded in a "simple" ASCII format and unicode characters are escaped.
However, I have a custom plugin to use properties files with Unity3D. Thereby the properties files are encoded as UTF-8 for simplicity (it is simpler for me when working with other text editors, when searching, etc.).
I noticed that Easy-i18n is changing the UTF-8 encoded characters in my files to the escaped version. Example: ü becomes \u00FC
Is there an option to use UTF-8 instead?

I also noticed that some \n newlines were removed from my files. This should not happen.
Could be related to the UTF-8 issue.

Should have been fixed now with latest release v1.1.0


High CPU consumption

High CPU consumption
https://i.vgy.me/2IxV2k.png

+1 this, I noticed the same in Linux, docker stats reports over 150% CPU consumption, I'm unsure what seems to be the issue. I've tried earlier versions as well, to no avail.


The sha256t_hash_newtype! call in the taproot module is unclear

Raising an issue instead of a PR in case I'm just being overly sensitive. The macro call in the taproot module declares six types in a single go, as such (and because of the rustdocs layout) its not obvious which goes with which and I find myself having to remember to pair them. It doesn't help that the hash for TapBranchTag is called TapNodeHash instead of being uniform and using TapBranchHash like the other two.
Should we:

Remove the repetition in the macro and call it three times so the grouping is obvious?
Rename the TapNodeHash?

I'm not sure what you mean by "remove the repitition" though.

The repetition in the macro, what allows for the current call with multiple hash/tags in a single call.

Oh, yeah. Agreed, we should remove that ability. Probably worth adding a doccomment clarifying that you can do multiple definitions in the normal newtype macro, but in the sha256t one, because there are two types per hash to define, we found it became confusing to allow multiple hashes.


Fix typo in readme

Sorry for this minimal PR. I tried to resist creating it, but this typo was to hard to ignore.

Don't worry about it, you did great!


Remove clearfix from forms, add media mixin back

woo!

@incuna/frontend please review, this is quite urgent. @wytrych I'm not sure if this is a breaking change, as the old one was broken but we didn't realise... if in doubt should I label it one?

@pandalion do you need to change anything in the project when you upadate to this version? If not I'd say it's a bugfix.

Hm I would say no unless you're using @include hidpi-image but as that depended on compass it would be broken already anyway. And the other stuff would be broken already too. So I agree, bugfix 👍


Gradle 5.3

Gradle 5.3 is available.
This is sent by @gradleupdate. See https://gradleupdate.appspot.com/reflectoring/coderadar/status for more.

Newer version in #243.


Improve URL file importing

Fix bugs regarding headers and body tabs state
Add the ability to disable the headers
Add a "delete all headers" functionality

As the "delete all" button will introduce too much clutter inside the popup, and the most of the time there won't be as many header that will impact the user experience, this point will not be implemented.


[bug]: Sratchpad appends "left" "(or right") to filename despite specifying filename and setting setName to false

Description

Hi! Sorry for bothering you again, but I'm wondering if it would be possible to get rid of -left,-right suffix for scratchpads?
I was already using a file named .scratchpad.md and I wanted no-neck-pain sidebuffer to open this file rather than creating new one, but I can't seem to get it working, since it's applying this suffix despite setting setNames to false and specifying the file name :/
Thank you once again
Neovim version
0.10.x
Steps to reproduce

Apply this config

return {
  'shortcuts/no-neck-pain.nvim',
  version = '*',
  opts = {
    -- The width of the focused window that will be centered. When the terminal width is less than the `width` option, the side buffers won't be created.
    --- @type integer|"textwidth"|"colorcolumn"
    width = 150,
    -- Adds autocmd (@see `:h autocmd`) which aims at automatically enabling the plugin.
    --- @type table
    autocmds = {
      -- When `true`, enables the plugin when you start Neovim.
      -- If the main window is  a side tree (e.g. NvimTree) or a dashboard, the command is delayed until it finds a valid window.
      -- The command is cleaned once it has successfuly ran once.
      --- @type boolean
      enableOnVimEnter = true,
      -- When `true`, enables the plugin when you enter a new Tab.
      -- note: it does not trigger if you come back to an existing tab, to prevent unwanted interfer with user's decisions.
      --- @type boolean
      enableOnTabEnter = true,
      -- When `true`, reloads the plugin configuration after a colorscheme change.
      --- @type boolean
      reloadOnColorSchemeChange = false,
      -- When `true`, entering one of no-neck-pain side buffer will automatically skip it and go to the next available buffer.
      --- @type boolean
      skipEnteringNoNeckPainBuffer = false,
    },
    buffers = {
      setNames = false,
      colors = {
        blend = -0.2,
      },
      scratchPad = {
        -- set to `false` to
        -- disable auto-saving
        enabled = true,
        -- set to `nil` to default
        -- to current working directory
        location = nil,
        fileName = '.scratchpad',
      },
      bo = { filetype = 'md' },
      wo = {
        fillchars = 'eob: ',
      },
      left = {
        setNames = false,
      },
      right = {
        setNames = false,
        enabled = false,
      },
    },
    -- Supported integrations that might clash with `no-neck-pain.nvim`'s behavior.
    --- @type table
    integrations = {
      -- By default, if NeoTree is open, we will close it and reopen it when enabling the plugin,
      -- this prevents having the side buffers wrongly positioned.
      -- @link https://github.com/nvim-neo-tree/neo-tree.nvim
      NeoTree = {
        position = 'left',
        -- When `true`, if the tree was opened before enabling the plugin, we will reopen it.
        reopen = true,
      },
    },
  },
}

Reload
and open the file

Relevant log output
No response
Self-service

[X] I'd be willing to fix this bug myself.

Hey! You don't bother me no worries, I'm glad to see those reports :) thanks for using the plugin
I think the reason for this is here: https://github.com/shortcuts/no-neck-pain.nvim/blob/main/lua/no-neck-pain/config.lua#L349
Since fileName and location are deprecated options, I've added this default to prevent file clash name
Could you try with pathFoFile instead to see if this is still appended? (I'm on my phone and can't recall)

Yeah, pathToFile alone works. Thank you!


How to refresh the accesstoken in Moya

I'm using CocoaPod Moya 11.0 which is the latest version
Here, I need to refresh my accesstoken like doing in Alamofire's RequestRetrier and RequestAdapter. After the token got refreshed I need to restart the request. Can anyone explain how should we achieve this in Moya.
Language: Swift 4.3

Hi @sathishvgs
This is a pretty common issue here, so please, take a look at this answer.
Let us know if this solves your problem or if you need more help.


Recurring tasks

https://github.com/jakubroztocil/rrule https://www.npmjs.com/package/@breejs/later


Is this a fake open source project？

Is this a fake open source project？

Thank you for your suggestion.
First, we never claim that it is an open source project, there is a plan to make it open source gradually. Please read the note.
Second, the S3MDataSource is open source, which provides the base function to apply S3M in the Cesium
Thired, S3MTilesLayer is still closed source, which provides the advanced functions about S3M.
Finally, we can have the meaningful discussion only if you provide the specific  issue.

Hi @pasu, THX for your answer, it's clear.
I just wanna know the difference between S3MDataSource and S3MTilesLayer. That's it, very Cool.
So. I wonder if we can put these more detailed information in the README or other document?
This project is under Apache 2.0 License, it's easy to misunderstand the whole project is open source and business friendly, more detailed info would be very helpful.


Save some bytes in the object header by inlining set.

This was in my working directory, although I don't remember doing it. Saves 8 bytes per object instance if I counted right (but I also didn't try that hard to count).

Sorry I meant 2 bytes. At least 2 bytes.

Sick


Removed deprecated -show-cursor option from qemu command

This fixes issue https://github.com/elisa-tech/meta-elisa/issues/23 It was confirmed with QEMU emulator version 6.2.0 (Debian 1:6.2+dfsg-2ubuntu6.5)
With qemu version 6.0 and newer the option "-show-cursor" was removed. Accordingly the command line call is corrected by deleting this option.
Signed-off-by: Philipp Ahmann<EMAIL_ADDRESS>

Discussed this PR during the weekly meeting on Nov 16th. Agreed by Chris Temple and @gabpaoloni
There was an additional comment from @OpenJohnMacGregor in the issue asking about "The log entry says to use -display sdl,show-cursor=on instead, but do we really need to show the cursor?" We wanted to use the cursor actually to hover over the rendered tell tale to show that the change is detected and an error is displayed. This is not yet a feature of the current demo state.


New command: enable SPFx package for deployment in Teams

Usage
spfx package teams enable
Description
Checks if the SPFx package is enabled for deployment in Teams. Optionally, changes the package to enable it for deployment in Teams
Options

Option
Description

-f, --filePath <filePath>
Absolute or relative path to the .sppkg file to analyze

--fix
Specify, to update all web parts in the package to be exposed in Teams

Additional Information
The idea of this command is to help admins analyze if the particular SPFx package can be deployed in Teams and enable it if needed without having to manually change the package.
The command has the following steps:

unzips the specified .sppkg file
discovers all web parts
for each web part checks its manifest and verifies if Teams is listed in supported hosts
the command prints in console all discovered web parts and whether they're enabled for deployment in Teams or not
when you use the --fix option, the command will unzip the .sppkg file, update all web part manifests so that all web parts are enabled in Teams, increase the package minor version number and create a new zip

This command could also be used in a script that downloads all .sppkg files from the app catalog, analyzes them and provides report or downloads all .sppkg files from the app catalog and updates all .sppkg files to be deployable in Teams.

Hey @pnp/cli-for-microsoft-365-maintainers, what do you think?

Do we want to allow for exclusion of certain WebParts? I can imagine that there are scenario's where you do not want all webparts but just a subset?

I'm on the fence if this wouldn't complicate the command too much. For this to work, we'd need to offer a way for you to see which web parts are in the solution so that you can select them by their alias. So either the command would need to be interactive, or we'd need to introduce another command that you can use to list web parts in the package.

Do we want to provide the option to switch between Personal and Teams Tab?

If we offered this option, wouldn't it be necessary for you to be able to specify this per web part, which would again complicate this command's usage? Considering the usage (easily enable SPFx web parts for teams) and the target audience (admins) of this command, is there something against a quick default to expose web parts both as personal and configurable tabs?

Agree Let's start with the command version that adds it to both personal for all webparts in package. We can always iterate on that if usage indicates it's worth it.

Could give this a go!

Awesome, all yours @MathijsVerbeeck !

@waldekmastykarz @appieschot Just a minor question, as I'm able to define which webparts are defined as a Teams app or which ones aren't (see screenshot below):

However, I currently check whether the webpart is either

TeamsPersonalApp
TeamsMeetingApp
TeamsTab

If we would use --fix, how would we define which value that we should add to the supportedHosts value? Would we prompt the user to define which ones he would like to add?

I suggest we go with Personal can configurable tab. Meeting apps are typically more specific and exposing existing web parts as meetings apps without any changes might not be as valuable.

Happy to skip the teamsmeetingapp but I also see some value in the TeamsTab option. We could add add an extra parameter (--suportedHost) where we ask the user to specify what they want when using --fix right? We could have a default value for TeamsPersonalApp

Happy to skip the teamsmeetingapp but I also see some value in the TeamsTab option. We could add add an extra parameter (--suportedHost) where we ask the user to specify what they want when using --fix right? We could have a default value for TeamsPersonalApp

Nice idea, we can certainly expose the --supportedHost option. I suggest that its default value is personal and configurable tab, and optionally, folks can override by specifying their comma-separated values.

@pnp/cli-for-microsoft-365-maintainers so coming back from a small discussion that started when reviewing the PR I was wondering if this is the best place for this option supportedHosts.
I mean the first comment is the way we have the command now is that it will not allow to change the supportedHosts if the app on which we are running the command is already enabled to Teams. This seems to be ok but I thing it would be more helpful to add more freedom to it and even if an app is already exposed to teams we could overwrite the supportedHosts when they are specified and fix option is passed as well. Hat do you think? That way we could give the user the possibility to adjust the hosts even on an enabled app 🤔.
Other idea I have (maybe also a stupid one 😅) is to create a separate dedicated command which would allow the user to modify the SPFx project supported hosts, and I mean all of them, so not only teams but also SharePoint and office.com and outlook.com.
What do you think?

I think there's place for both commands: an easy (this) one that just enables web parts for use in Teams, and another, that gives you more granular control and which is more of an API projection.

Reopening due to lack of activity.


fix: gallerie => gallery in schema

I guess in principle this should have been caught by a CI workflow (at least as long as they require the branches to be up to date with main before merging; perhaps that is not the case).

We don't have this yet, but for configuration file update, now that we have a schema this can be automated


Refactoring Dockerfile

Migrate to latest Ubuntu LTS (22.04)
Build inside docker (buildx support)

@foxdalas Thanks for your contribution. No worry about the failure of CI tests, will find the root cause and fix it later.

@git-hulk Thanks. Maybe do you need ci for docker with many platforms?

@git-hulk I built current head on my laptop. You can pull image foxdalas/kvrocks:latest amd64/arm64. Everything works in AWS EKS.

Thanks @foxdalas, are you using this Dockerfile, I got the below error when compiling.
include/jemalloc/internal/rtree.h:109:33: error: variably modified 'root' at file scope
  109 |         rtree_leaf_elm_t        root[1U << (RTREE_NSB/RTREE_HEIGHT)];

@git-hulk I built current head on my laptop. You can pull image foxdalas/kvrocks:latest amd64/arm64. Everything works in AWS EKS.

Thanks @foxdalas, are you using this Dockerfile, I got the below error when compiling.
include/jemalloc/internal/rtree.h:109:33: error: variably modified 'root' at file scope
  109 |         rtree_leaf_elm_t        root[1U << (RTREE_NSB/RTREE_HEIGHT)];

It's strange. I will check it tomorrow. Thanks.

@git-hulk please approve buildx actions.

Sorry that I also don't have the permission now. Maybe @tisonkun @Hexiaoqiao can help to approve it.

Sorry that I also don't have the permission now. Maybe @tisonkun @Hexiaoqiao can help to approve it.

Thanks for support.

@tisonkun @Hexiaoqiao approve action please

@tisonkun @Hexiaoqiao one more run please

@git-hulk app checks have passed. Please check your environment everything forks on ubuntu 22.04 in docker.

Cool, thanks. Will have a try later.

@foxdalas @git-hulk please note that docker workflow takes about 197 minutes to complete. We may not run such workflow for every PR every activities.

@foxdalas @git-hulk please note that docker workflow takes about 197 minutes to complete. We may not run such workflow for every PR every activities.

It's qemu 😢 I think i will find workaround

@tisonkun I can add cross-compiling to project or we can build docker image on tag push.
What do you think about release action with docker build and push ?

@foxdalas We have built and pushed the docker image when releasing the new tag.
Can see: https://github.com/apache/incubator-kvrocks/blob/unstable/.github/workflows/release.yaml#L80

@foxdalas We have built and pushed the docker image: release.yaml#L80. I think we can add the cross compiling on the daily CI instead of every PR, HDYT?

@foxdalas We have built and pushed the docker image: release.yaml#L80. I think we can add the cross compiling on the daily CI instead of every PR, HDYT?

Do you mean docker buildx cross compiling? It's easy

Yes, as @tisonkun mentioned, the new docker job need 197 minutes to complete, it's too slowly and unnecessary for most PR, so it would be better to add to Daily CI.

@git-hulk @tisonkun review please

did you run daily CR? works well? how long did it take? since currently we only run  kvrocks.yaml CI when submitting a PR.

@foxdalas Can you rollback the cross compile in release.yaml? For Daily CI, 197 minutes was ok to me, but it's too slowly to release.

@foxdalas Can you rollback the cross compile in release.yaml? For Daily CI, 197 minutes was ok to me, but it's too slowly to release. My point was we want to guarantee the code can compile on different platforms first.

Yes,sure.
Do you have another way for arm64 release?

@git-hulk Maybe i didn't describe clearly. I think release.yaml is OK since it runs in the background.  But daily Ci takes much time.
Let's keep current solution. We can optimize if there is a real problem.

OK, I'm ok to go head with the current way. We can improve this before GitHub Actions supporting the arm64 runner.


Support for SVN

It would be nice to have support for SVN, where you would go to the parent directory as long as the project's root directory and/or UUID of the project do not change.
The extra check is required so that the root of ~/project-foo/bar(/.svn) becomes ~/project-foo(/.svn) and not ~ in case ~/.svn exists, too.

Starting from version 1.7.0 (release a few months ago) Subversion uses a new working directory structure that keeps only silgnle .svn folder at the root of the working copy.

@hiredgunhouse Thanks for the info!


Add workspaces + example

It would be useful to switch to yarn workspaces, and implement an example folder.
https://github.com/notrab/gatsby-source-transistorfm is a simple example of the setup required here.

I'm happy to take this and submit a PR.


feat(aws-codepipeline): Pipeline now accepts existing IAM role

Originally submitted as #2573, only this time without a horrible git history 😄
Fixes #2572.
Pull Request Checklist

[N/A] Testing

As this feature is very similar to the existing pattern of artifacts bucket, which isn't unit tested as far as I can see, I didn't add, modify or remove any existing unit tests.

[X] Docs

jsdocs: All public APIs documented
README: README and/or documentation topic updated
Design: For significant features, design document added to design folder

[X] Title and Description

Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
Title: use lower-case and doesn't end with a period
Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"

[N/A] Sensitive Modules (requires 2 PR approvers)

IAM Policy Document (in @aws-cdk/aws-iam)
EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Please add a test as well.
@rix0rrr sure 😄 - anything in particular that you'd want to be covered by this test? I'd copy from something like artifactBucket but that doesn't appear to be tested currently

@rix0rrr sure smile - anything in particular that you'd want to be covered by this test

Yes, that if a role is passed in, it is referenced by the pipeline.

@rix0rrr cool, I'll get on that - thanks!

@rix0rrr I've added a test, mind having a look over and seeing what you think? I didn't think it fit into any of the existing test files so I created a new one


How to access RS depth output without rendering to screen?

Required Info

Camera Model
D435

Firmware Version
<IP_ADDRESS>

Operating System & Version
Win 10

Platform
PC

SDK Version
<IP_ADDRESS>23

Language
unity

Issue Description
Hi - How can I output the texture/buffer of depth points from the rs camera without rendering an image to the screen? I'd like to use the points as a data source to inform an interactive response from the visualization I've built. I have successfully managed to use the stream of data from the RawImages in the TexturesDepthAndColor Scene in the Unity examples, but in the end, I don't want the depth images to render to the screen as a UI - I'd rather simply have a buffer or RenderTexture or similar that I can simply use as a data source. Is there a way you'd recommend doing this? - perhaps using the Depth or ColorizedDepth children of the RSDevice? Thanks!

Hi @nataliesettles  One way to clear the pointcloud from the screen would be to set the Culling Mask on the Main Camera to Nothing so that the pointcloud data is still being processed but it is not visually rendered.

This approach could cause problems though if you need other visual elements to be rendered on the screen, as the Nothing cull removes everything.
A more precise approach would be to create a new layer name using Add Layer.

You could then go to the Pointcloud object that is a child of RsDevice in the PointCloudDepthAndColor scene and use the Layer drop-down in the top corner of the Unity window to change the Pointcloud object's layer to the new one that you just created.

Then go to the Main Camera's culling layers list and untick the name of the new layer.  This will cause the pointcloud to disappear whilst all other layer types can still be rendered.

Yes - thanks. That wasn't quite where I was stuck, however, I just solved it moments ago.
I was having trouble accessing the texture data stream without using the RawImages to pass the texture stream between scripts. It turns out I simply needed to initialize a connection to the texture stream by binding a public setter method to a texture field in my own script to the textureBinding event in the RsStreamTextureRenderer script, and then referencing that newly bound field in the update method of my script in order to continue to get the updates to the stream.

It's great to hear that you achieved a solution.  Thanks very much for sharing the details for the benefit of other RealSense Unity users who may be in a similar situation in future!

Thanks for this alternate approach with culling - I hadn't thought of that.
I guess I'd assumed that if the content was culled it might not continue to
render in the background - but I hadn't tested to see. Cheers!
Natalie Settles
A Pilgrim in Art and Science:
Part memoir, part travelogue, part philosophical reflection
nataliesettles.com/pilgrim
On Fri, May 5, 2023 at 12:11 PM MartyG-RealSense @.***>
wrote:

It's great to hear that you achieved a solution. Thanks very much for
sharing the details for the benefit of other RealSense Unity users who may
be in a similar situation in future!
—
Reply to this email directly, view it on GitHub
https://github.com/IntelRealSense/librealsense/issues/11767#issuecomment-1536477740,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7EJHNNJ64FPYIETASWKZ3XEURCHANCNFSM6AAAAAAXWAVO6Q
.
You are receiving this because you were mentioned.Message ID:
@.***>


rename tasks field from pipeline and move it to higher level

Description
Currently, we can customize what subtasks to run for a particular plugin:
[
  [
    {
      "plugin": "github",
      "options": {
        "repo": "lake",
        "owner": "merico-dev",
        "tasks": ["convertCommits"]
      }
    }
  ]
]

and since we had move subtasks execution from plugin  to framework, this schema doesn't make sense anymore
Describe the solution you'd like
rename tasks to subtasks and move it to outer level
[
  [
    {
      "plugin": "github",
      "subtasks":  ["convertCommits"]
      "options": {
        "repo": "lake",
        "owner": "merico-dev"
      }
    }
  ]
]

Has the Feature been Requested Before?
No

document is also needed

assign to me. thanks

@e2corporation Solved by https://github.com/apache/incubator-devlake/pull/2057, but configure-ui needs to be adapted.
the subtasks is missing.

Here you can see the execution parameters

into advanced mode, you can see:


[Fabric Bot] Updating IoT Owners

Summary
The focus of these changes is to add entries for the IoT-related service contacts, based on recent updates to CODEOWNERS.

/check-enforcer override


[incubator/istio] Added nodeSelector for istio.

Fixed part of https://github.com/kubernetes/charts/issues/1899
/cc @lachie83 @prydonius @unguiculus

/cc @kubernetes/charts-admins can anyone help review?

@gyliu513 Would be happy to rebase this onto master?

@lachie83 done in https://github.com/kubernetes/charts/pull/2436


Deserialization of multiplier_formula_raw

multiplier_formula_raw is expressed as "multiplier_formula_raw": "[["ATK", "*", 3.6, "+", 20]]" for skill id 162 using api v2. Initially I thought this should be considered a string. C# doesn't seem to know what to do with it off-hand. I was hoping to use it instead of implementing my own tokenization of multiplier_formula. Any hints you can give me on how this is expected to be deserialized would be great. Unfortunately, I can't seem to grasp the organization of python/django to really get a grip on what the code here is doing.

That's basically a list of tokens in stringified JSON.  The absence of quotes around the numbers cause them to be decoded as integer/float.  The only non-standard feature is the double brackets where you'd expect single bracket in JSON.
Decoding is only half the battle as you also need to process the tokens.  In theory something like antlr is the right way to process tokens, but you'd be building a full math engine to decode some simple strings (unless you can find an example that already does most of what you need).  In this case, you'd actually define ATK in the grammar.  When you process the AST, you have a function that knows how to interpret that value.
The other direction is to collapse it into a string and find an existing package (maybe this) that will re-parse and interpret the string.  Before you collapse the string, you walk the list and replace values like ATK.

multiplier_formula_raw is taken verbatim from the game files (hence the raw bit), and is not in a usable format for any math parsing library. The particularly annoying detail is that it is evaluated left-to-right and does not respect the usual order of operations. However, nested [ ] act as parenthesis would in normal math.
In the multiplier_formula field I've parsed the formula into a valid mathematical statement and have marked tokens with curly brackets and more straightforward attribute names. I'd recommend using that instead.


[AMBARI-24229] Prevent Configuration Changes During Keytab Regeneration in an Upgrade

What changes were proposed in this pull request?
Certain configuration changes should be avoided when regenerating keytab files during different scenarios.
For example, existing non-Kerberos configurations should not be changed during the regenerate keytabs operation performed during an upgrade. However it is necessary for Kerberos identity-related configurations (such as keytab file paths and principal names) to be added and updated; as well as allow for new Kerberos-related configurations to be added.
To allow for this, a new update configuration policy value has been added to the set of directives (config_update_policy) allowed when issuing a call to regenerate keytab files. This directive replaces the less flexible ignore_config_updates directive which only allows a user to enable or disable the ability for the operation to change configurations. The values allowed for config_update_policy are as follows:

none - No configurations will be updated
identities_only - New and updated configurations related to Kerberos identity information - principal, keytab file, and auth-to-local rule properties
new_and_identities - Only new configurations declared by the Kerberos descriptor and stack advisor as well as the identity-related changes
all - All configuration changes

During an upgrade, the update configuration policy is set to new_and_identities.
How was this patch tested?
Manually testing in several upgrade and non-upgrade scenarios.
Updated unit tests, all tests passed.
Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2977/
Test PASSed.

@jonathan-hurley  I added your suggestions to org.apache.ambari.server.controller.internal.UpgradeResourceProviderTest#testCreateRegenerateKeytabStages

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2981/
Test FAILed.
Test FAILured.

retest this please

The error is not related to my patch, but giving it another change to pass.
2897138 [INFO] Ambari Web ......................................... FAILURE [03:34 min]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2982/
Test FAILed.
Test FAILured.

2150835 [INFO] Ambari Web ......................................... FAILURE [02:24 min]


i have a questions for you

Hello, I want to use the Kohya Trainer V4
but I don't know how is the command to do a training with preservation of the original model

Thanks for the info and your time,
Person like you, that helping with a good explanation I like to study about models


Allow writing startup_info.json to somewhere other than the build dir

Related to https://github.com/flutter/flutter/pull/79329, https://github.com/flutter/flutter/pull/79322
This will help us to upload more detailed logs to CI
@jmagman @jonahwilliams
Part of https://github.com/flutter/flutter/issues/79097

The build directory is already configurable though, is this trying to avoid the rest of the build artifacts?

I guess my main concern is that we have a bunch of timeline related data that we default to dumping in the build dir, but for CI we want to dump it all into the logs directory that the recipes upload and attach to the LUCI UI.
If there's a better or more consistent mechanism for doing this I'm good with that - but I'd like to avoid larger reworkings of every invocation of this command to achieve it. The FLUTTER_TEST_OUTPUTS_DIR environment variable is being used for this purpose in driver/integration_test related places, and it seems to make sense here, but It does seem unfortunate to have it as this undocumented thing.
At the end of the day, I want to make sure we're just pumping every bit of log/timeline data we get to CI and not putting some of it in folders that become inaccessible after the build is cleaned up.

Can we make this configured via a documented flag instead of using secret environment variables?

(Alternatively, you could move it to a subdir of the build directory, if that is easier to upload)

Landing this on red so we can help get the tree green/more logs.