config.json: add info for bank-account

See #345

Sorry @tleen, I pressed the resolve conflicts button :grimacing:, I've never used that feature before and I couldn't help myself finding out what it did.
You'll probably want to pull my commit down and rebase the changes onto your commit, sorry for the extra work, still learning!! :grinning:
Also, watch the indentation on the topics, a minor thing perhaps but good to stay consistent :smile:

Np, I haven't used that button either.

I thought I was going to have to redo this one but the resolve conflicts fixed it. yay!

Hm, after rebase I see your changes but not in the file compare. Would merging this as is screw things up?

I think it would. The changes aren't showing up in the Files changed tab and we don't want to include this commit, https://github.com/exercism/go/pull/709/commits/13a1aaf1e2539d50154e6e35de9bb0a6ed37c38c, either.
I'm afraid it might be easier to redo on these changes. Sorry, I should've waited for these to be merged before merging #720

NP its an easy redo. :smile:


Improve documentation in element.py

Related to issue #236

Codecov Report

Merging #301 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #301   +/-   ##
=======================================
  Coverage   80.23%   80.23%
=======================================
  Files          11       11
  Lines        3167     3167
=======================================
  Hits         2541     2541
  Misses        626      626

Impacted Files
Coverage Δ

ross/element.py
80.35% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c2f3a0...de67f43. Read the comment docs.


Fixes accessibility dialog box with class w-dialog has z-index of 130 and hides behind other elements on the page

This changes the zIndex to be compatible with bootstrap's sidebar while allowing the userbar to show above the accessibility menu. Thank you @fourfridays for the issue!
Fixes #10471
Please check the following:

[ Probably ] Do the tests still pass?[^1]
[ Yes ] Does the code comply with the style guide?

[ Skipped ] Run make lint from the Wagtail root.

[ N/A ] For Python changes: Have you added tests to cover the new/fixed behaviour?
[ Skipped ] For front-end changes: Did you test on all of Wagtail’s supported environments?[^2]

[ N/A ] Please list the exact browser and operating system versions you tested:
[ N/A ] Please list which assistive technologies [^3] you tested:

[ N/A ] For new features: Has the documentation been updated accordingly?

Please describe additional details for testing this change.
[^1]: Development Testing
[^2]: Browser and device support
[^3]: Accessibility Target

Not sure on this change, maybe it's best to try to ensure the userbar modal usage styles are different from the Wagtail admin ones.
This global change constrains us in the admin and could cause other cascading z-index issues.
Maybe we can either override the z-index for dialog in the userbar or use a different approach to ensure that the dialog html sits inside the userbar z-index and/or revisit another way to adjust the stacking context.
Finally, there is no way for us to know what z-index is used in the styles of websites that use Wagtail, so we could look at the documentation and advise that the Dom location consider this.

Hey folks,
@lb-  and @laymonage  I'm not a tailwind expert and so won't stand by my changes :). That said, I do believe that Wagtail has an error in that the accessibility tooltips are in the hundreds z range and the userbar is 9999. The userbar works well with bootstrap out of the box while the accessibility tooltips categorically do not. While my exact change might not be the precise change that is needed, something to address https://github.com/wagtail/wagtail/issues/10471 is needed to round out this functionality.
I'm closing this issue and we're working around this issue in our css overrides for now. I hope https://github.com/wagtail/wagtail/issues/10471 can get taken up in 5.1 so that we can pull out our workaround css.

@rgs258 thanks, sorry for the confusing description, the main goal is to avoid a change to all the main admin styles for fixing something that's only needed in the userbar scope. Within the admin we intentionally try to avoid very high z-index ranges as there is usually a better way to solve those problems.
I have submitted a PR here and if you don't mind checking this and hopefully this approach will solve the problem https://github.com/wagtail/wagtail/pull/10514


Explorer open containing folder opens the parent of the containing folder

VSCode Version: Code - Insiders 1.4.0-insider (01a3f868552dc8011adf4e79bee8cfb09babfe31, 2016-07-22T05:13:17.693Z)
OS Version: Linux x64 4.4.0-28-generic, Ubuntu 16.04

Steps to Reproduce:

Open a folder that contains a folder
Say foo is the open folder which contains bar, right clicking bar in the explorer and selecting open containing folder will open foo not bar.

It does not open the currently opened vscode folder but the parent of the selected folder.

@Tyriar and I discussed that a bit more. The current behavior is in principle the same on all platforms. The chosen name on Linux is less appealing than on Windows or Mac but since there is no standard explorer or finder it's hard to come up with a different name.
The real problem on Linux is that the file/folder when being shown within its container folder is not selected as it is on Windows and Mac.

@Tyriar nothing we control, please file against Electron and link to here.

Found to TODO https://github.com/electron/electron/blob/107d759ea265a6f8733bd7adfd21b2aebbebb6ad/atom/common/platform_util_linux.cc#L59


Make package CommonJS friendly

It's weird to me that the package does export default and the examples use ES2015 import syntax when that is not actually supported by Node. I think most Node users would be using require(), so in my mind it makes sense to export in such a way that users don't have to var gulpStylelint = require('gulp-stylelint').default; but can just require('gulp-stylelint'); and to write examples with CommonJS. Do you disagree?

This has been released in 1.0.0. Feel free to re-open the issue if necessary. Thank you for your advice and contribution!

Fantastic! Looks really good. I hope people use this as a model for grunt etc. plugins.


set USE_INSECURE_CURL=true if you want curl to use -k/--insecure option

While it is relatively easy to setup the docker daemon outside the migrator container to connect to a registry secured with an internal or private CA, the curl commands within migrator.sh remain stubbornly ignorant.
This PR lets a user set USE_INSECURE_CURL to pass the -k option to the curl commands within migrator.sh.  Passing -k skips certificate validation and lets the curl commands succeed.  Otherwise, they fail silently because curl fails certificate validation on a TLS server secured with an internal or private CA.

Awesome!  LGTM!


Playing some osu!mania charts will bring up a persistent "Song offset" warning.

Describe the bug
Title should say it all. Even after being presented with the offset dialog after exiting the song and hitting Yes, the Song offset text reappears on next play.
To Reproduce
I don't have a great list of osu!mania charts that can cause this bug, but this should be one of them.
Open the chart, exit (either by finishing the song or quitting), press Yes on the dialog, and re-open the song to find the text is still there.
Expected behavior
The Song offset text to disappear after the first time through, or better yet not appear at all.
Screenshots

Desktop (please complete the following information):

OS: Windows 10 Home, version 19041
Etterna Version: v0.70.4
64-bit.

Additional context
Shouldn't be any more context, really.
EDIT: Didn't occur to me to put in the Etterna version, sorry.

resolved by various osu loader changes probably, particularly the change which fixes the fact that offsets dont exist for osu files and when you attempted to change them it didnt save anything
eb1585cb424ef322b350e067f0764179d8ad76f4


Legalizer assert messages details

Use more specific assert message for legalization for better bug grouping.

This change is

@Microsoft/chakra-jit Can someone review this please ?

@dotnet-bot test OSX static_osx_osx_release


About Proper Donations

Hi, I noticed there were some people selling dpt-tools for 499 yuan by remote-control.
Have they ever donated to this project I wonder?
It seems most of them will spend more than 30mins to an hour to finish ROOT process. Some of them sold more than 100 units of dpt-tools at high price. Strongly doubt whether it's a violation of Open Source protocols.

Wow.. I didn't know that.. Even a single charge would be way beyond all donations I got.. so nope I guess not.
Regarding your question: selling is permitted under MIT license. It should be okay to sell/modify my tool, except they should include the copyright notice. I can't control this much, as MIT is a permissive license. I do hope they will acknowledge our efforts here.
Thanks a lot for the notice. The original idea is for study purpose, and that no one needs to pay for the hack. (In a sense, we did lower the cost among all sellers). But as I said, you can't control it.
(fyi the root process should take literally <5minutes..)
Regarding your title question, PayPal is the method I provide. I don't know how to set up WeChat donations :)

It's need to download and register WeChat or Alipay on mobile phone, bind a bank card, generate the QR code, and then put the picture here.

that's cool.. I never tried that
I added it to the wiki page :)

You better add it to the README.md, and put it at the top of the page.


adding new chatbubbles based on user-interaction

Dear Alastair!
First of all thanks for all the great code you produced during the gdnm!
Currently I am checking out the  podmod player in order to see whether listeners of the german public radio, NDR like it. Being relatively new to React (and somehow coding in general, 2 1/2 years of experience) it is challenging for me to implement an additional features and would I kindly would ask you for a word of advice. How would start to implement the following feature:
For Prototypetesting I want to implement a backchannel, That lets users answer yes/no-question via button click (done - by adding a new renderPoll Function to the ChatBubble Component) and then (if the user answered) shows a new ChatBubble with answer data.
My best guess so far is to pass down a function that sets the State of from the frame component all the way down to the chatBubble and call it once the user has clicked.
It would be great if you could give me a short feedback, if that would fit in the logic or not at all :)
All the best
Malte

Hello!
My apologies for taking so long to reply to this. And my apologies for the state of the code!
You're definitely on the right path. You will want to insert a new ChatBubbleProperties into the items array of the Script. The best way to do that will probably be a function in Frame, as it contains the script in its state. If you want to avoid having to add the function to the entire chain of components, you might want to look into React context:
https://reactjs.org/docs/context.html
That would allow you to send the function into a context in <Frame/>, then extract it back out again inside <ChatBubble/>.
Is that any help?

Hey Alastair!
Thank you very much for your response! Yes, your mail is immensely helpful.
Nice to hear, that I was on the right path :) For now I worked around the
task by making the Chatbubble itself transform after the user made a choice
(clicking a button). But if we stick to the idea to play around with podmod

and I hope we will, at least for a bit, the topic will come up again.
Maybe it is nice to hear for you that your work had quite some influence
here, after a workshop week during which we explored new storytelling
formats for mobile, I came across the guardian lab and ended up reading all
your great posts and talks now we try to implement your learnings here.
Very very helpful and inspiring, thank You!

Playing around with podmod is lots of fun and triggered some ideas, we
really would love to keep working on, to test the concepts we would love to
stick to podmod and tweak it here and there, but right now I guess I
reached a point where I am no more sure, if it makes sense to stick to the
code. The issue I faced, first seemed to be a small thing, adding a
textarea into a chat bubble to gather userFeedback.  Now I think it could
quite a big challenge - it would be great if you could prove me wrong!
What is the problem? The Dummy-Scroller covers the text-area and makes it
impossible to enter Text.  I read your text about the
performance-scroll-view and get one thing: It is beyond my skills to change
the performance-scroll-view. :)  Do you think there is an easy way to solve
the textarea issue - even it is quite a really dirty hack, it is only to
get the prototype working and test the concept. If it is the only way out,
I thought about implementing something like the image behaviour, which
opens div outside of the scrollview.
Do you think that would be the best way? Or is there an easy alternative I
didn't see?
In case you don't find the time to think about it, that is of cause
completely understandable!
Thank you very much and all the best from Hamburg!
Malte
On Tue, 24 Jul 2018 at 00:14, Alastair Coote<EMAIL_ADDRESS>wrote:

Hello!
My apologies for taking so long to reply to this. And my apologies for the
state of the code!
You're definitely on the right path. You will want to insert a new
ChatBubbleProperties into the items array
https://github.com/gdnmobilelab/podmod/blob/master/src/interfaces/script.tsx#L34
of the Script. The best way to do that will probably be a function in
Frame, as it contains the script in its state. If you want to avoid
having to add the function to the entire chain of components, you might
want to look into React context:
https://reactjs.org/docs/context.html
That would allow you to send the function into a context in ,
then extract it back out again inside .
Is that any help?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gdnmobilelab/podmod/issues/1#issuecomment-407218700,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKsaSEECBEJetH_e-KXzY4UzsfqsIZVrks5uJkrZgaJpZM4VQ96E
.

--
Mobil: +49 (0)<PHONE_NUMBER>4
Mail: malte.hildebrand@g <EMAIL_ADDRESS>Malte Hildebrand
Bilserstr. 53
22335 Hamburg

I am not surprised the performance-scroll-view is causing problems there, unfortunately! It does all sorts of tricks that make it a lot less flexible. My best suggestion for an alternative is what you've already mentioned - including a button in the chat bubble that opens the textarea in a separate div, on top of all the other elements. It wouldn't be anywhere near as nice a UI presentation, but it would get around all of the scrolling issues.
Depending in what direction you go with your ideas it might make sense to abandon the podmod code eventually. Although I tried to make it as flexible as I could, we were also approaching the end of the mobile lab, so parts of it were more rushed than I would have liked. If it served as a good place to test out some ideas before starting something new then I will consider that a win!
It's really great to hear that the mobile lab's work has continued to make an impact, a lot of the time we were working on these things without knowing if anyone was paying attention! I can't promise I will be able to give in-depth answers, but if there are any other things you'd like to know about then let me know!

Hey Alastair!
it is super kind of you to answer! Thank You!!
For now, I did some really really bad thing to your code :) But however,
for testing it might be sufficient. Somehow if I change the z-index of the
div that is rendered by the scroll-item-component it works. And here comes
that dirty, very rulebook reactish move  ;)
[image: image.png]
magic.
Thanks again for your very kind offer! Have a great day!
Malte
On Wed, 25 Jul 2018 at 17:09, Alastair Coote<EMAIL_ADDRESS>wrote:

I am not surprised the performance-scroll-view is causing problems there,
unfortunately! It does all sorts of tricks that make it a lot less
flexible. My best suggestion for an alternative is what you've already
mentioned - including a button in the chat bubble that opens the textarea
in a separate div, on top of all the other elements. It wouldn't be
anywhere near as nice a UI presentation, but it would get around all of the
scrolling issues.
Depending in what direction you go with your ideas it might make sense to
abandon the podmod code eventually. Although I tried to make it as flexible
as I could, we were also approaching the end of the mobile lab, so parts of
it were more rushed than I would have liked. If it served as a good place
to test out some ideas before starting something new then I will consider
that a win!
It's really great to hear that the mobile lab's work has continued to make
an impact, a lot of the time we were working on these things without
knowing if anyone was paying attention! I can't promise I will be able to
give in-depth answers, but if there are any other things you'd like to know
about then let me know!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gdnmobilelab/podmod/issues/1#issuecomment-407788746,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKsaSC0k0kQzQzF04aWW_ABcjxUHdrS9ks5uKIo4gaJpZM4VQ96E
.

--
Mobil: +49 (0)<PHONE_NUMBER>4
Mail: malte.hildebrand@g <EMAIL_ADDRESS>Malte Hildebrand
Bilserstr. 53
22335 Hamburg

Hey Alastair!
I am making progress here, and even though you are not so happy with the
code, it seems, for me it is an awesome way to learn something by looking
at your stuff :)
Right now I would like to get another stone out of the way and would like
to ask you for a word of advise:
depending on user input the size of a chat bubble changes  - but however
the next bubble doesn't realise the change and hence it covers the bubble
that has changed in size.
Is there a "of cause..."-thought poppin into your head right now? So far I
am not sure, which function to call in order to update the positions of the
bubbles.
I hope this mail finds you well.
All the best
Malte
On Wed, 25 Jul 2018 at 18:15, Malte Hildebrand<EMAIL_ADDRESS>wrote:

Hey Alastair!
it is super kind of you to answer! Thank You!!
For now, I did some really really bad thing to your code :) But however,
for testing it might be sufficient. Somehow if I change the z-index of the
div that is rendered by the scroll-item-component it works. And here comes
that dirty, very rulebook reactish move  ;)
[image: image.png]
magic.
Thanks again for your very kind offer! Have a great day!
Malte
On Wed, 25 Jul 2018 at 17:09, Alastair Coote<EMAIL_ADDRESS>wrote:

I am not surprised the performance-scroll-view is causing problems there,
unfortunately! It does all sorts of tricks that make it a lot less
flexible. My best suggestion for an alternative is what you've already
mentioned - including a button in the chat bubble that opens the textarea
in a separate div, on top of all the other elements. It wouldn't be
anywhere near as nice a UI presentation, but it would get around all of the
scrolling issues.
Depending in what direction you go with your ideas it might make sense to
abandon the podmod code eventually. Although I tried to make it as flexible
as I could, we were also approaching the end of the mobile lab, so parts of
it were more rushed than I would have liked. If it served as a good place
to test out some ideas before starting something new then I will consider
that a win!
It's really great to hear that the mobile lab's work has continued to
make an impact, a lot of the time we were working on these things without
knowing if anyone was paying attention! I can't promise I will be able to
give in-depth answers, but if there are any other things you'd like to know
about then let me know!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gdnmobilelab/podmod/issues/1#issuecomment-407788746,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKsaSC0k0kQzQzF04aWW_ABcjxUHdrS9ks5uKIo4gaJpZM4VQ96E
.

--
Mobil: +49 (0)<PHONE_NUMBER>4
Mail: malte.hildebrand@g <EMAIL_ADDRESS>Malte Hildebrand
Bilserstr. 53
22335 Hamburg

--
Mobil: +49 (0)<PHONE_NUMBER>4
Mail: malte.hildebrand@g <EMAIL_ADDRESS>Malte Hildebrand
Bilserstr. 53
22335 Hamburg


Initial 4th shot commit

Yes, it is still necessary to add reports to have the visibility for 4th shot + we have to discuss how to work with "posilujici davka"


Add AddressOwnership utility and cleanup OSSA rauw

AddressOwnership OSSA utility replaces the recent BorrowedAddress utility (the address may not be borrowed!)
This is my best effort at extracting NFC changes from an ongoing OSSA utility rewrite. However, it does improve optimization in some cases, so could expose latent OSSA bugs. I may have also fixed those bugs already during the rewrite, but checking in all 100 commits at once would be too shocking.
APIs:
AddressOwnership::hasLocalOwnershipLifetime() - convenience on top of
AccessBase::hasLocalOwnershipLifetime().

AddressOwnership::getOwnershipReferenceRoot() - convenience on top of
AccessBase::getOwnershipReferenceRoot().

AddressOwnership::findTransitiveUses() - wrapper API over the internal
helper findTransitiveUsesForAddress()

AddressOwnership::areUsesWithinLifetime() - wrapper adds a quick check
on top of BorrowedValue::areUsesWithinLifetime()

@swift-ci test

@swift-ci test windows


Issues importing plugins and TS module augmentation

Expected behavior
I'm expecting that importing the plugins, registering them and then configure them in chart options, the project is compiled and working
Current behavior
I see some issues TS module augmentation used to define the plugins.
The first issue was related to PR https://github.com/chartjs/Chart.js/pull/11244 which is forcing the plugins to add the default type to avoid issues on TS compiling.
interface PluginOptionsByType<TType extends ChartType = ChartType>

This update has been applied to annotation plugin but there is some open points about this change: https://github.com/chartjs/chartjs-plugin-datalabels/pull/376
This issue has been introduced by version 4.1.0, probably by PR https://github.com/chartjs/Chart.js/pull/10963
Anyway, adding the default type, the compiler is complaining about the plugin options:
Object literal may only specify known properties, and 'annotation' does not exist in type '_DeepPartialObject<PluginOptionsByType<keyof ChartTypeRegistry, keyof ChartTypeRegistry>>'.

See issue in annotation plugin: https://github.com/chartjs/chartjs-plugin-annotation/issues/886
The issue is not related to annotation itself because testing only zoom and datalabels, the issue remains.
It seems that the module augmentation is ignoring the update to the types after the first one, therefore it depends on the order of the imports.
Reproducible sample
Project published here: https://github.com/chartjs/chartjs-plugin-annotation/issues/854#issuecomment-1514910268
Optional extra steps/info to reproduce
I changed chart.js version, using 4.3.0 and annotation 3.0.0. Furthermore I have changed index.d.ts of chartjs-zoom-plugin setting the default type.
Furthermore add annotation and zoom (as empty object) to plugins chart options.
Possible solution
No response
Context
No response
chart.js version
v4.3.0
Browser name and version
No response
Link to your project
No response

I experience the same issue. I tried to update from 4.0.1 to 4.3.0 and it failed with the same typing issue. But the error starts to occur from version 4.1.0. I'm using zoom, annotations and custom made plugins.

I have created a simple repo which can reproduce this issue.
https://github.com/stockiNail/chartjs-11288
Commands:
npm i
npm test

Console and issue:
> test
> node node_modules/typescript/bin/tsc index.ts

index.ts:21:7 - error TS2322: Type '{ annotation: {}; zoom: {}; }' is not assignable to type '_DeepPartialObject<PluginOptionsByType<"bar", keyof ChartTypeRegistry>>'.
  Object literal may only specify known properties, and 'annotation' does not exist in type '_DeepPartialObject<PluginOptionsByType<"bar", keyof ChartTypeRegistry>>'.

21       annotation: { },
         ~~~~~~~~~~~~~~~

  node_modules/chart.js/dist/types/index.d.ts:2915:3
    2915   plugins: PluginOptionsByType<TType>;
           ~~~~~~~
    The expected type comes from property 'plugins' which is declared here on type '_DeepPartialObject<CoreChartOptions<"bar"> & ElementChartOptions<"bar"> & PluginChartOptions<"bar"> & DatasetChartOptions<"bar"> & ScaleChartOptions<...> & BarControllerChartOptions>'

Found 1 error in index.ts:21

I have spent time to find out the solution for this issue.
It seems (but not being a TS expert, not sure) if the augmentation is on a object which consists of re-export , module augmentation doesn't work.
Adding PluginOptionsByType to src/types.ts explicit export (row 10), sounds working.
I will do additional tests to be sure.

Let me recap.
From version 4.0.1 (where the module augmentation was working) to 4.1.0, the rollup config was changed removing rollup-plugin-dts.
Having a look to the output files, I saw that the d.ts produced by rollup plugin exported the plugin definitions by an explicit export (no by re-export).
From 4.1.0, the definition are re-exported by export * from (in types.ts which exports export * from './index.js';) and this is breaking the module augmentation.
Therefore adding adding PluginOptionsByType to src/types.ts explicit export (row 10), the issue is SOLVED.
This issue was also causing the other TS definition problem (@simonbrunel this is related to the PR https://github.com/chartjs/chartjs-plugin-datalabels/pull/376 that I have submitted in datalabels and where you correctly shared your doubts):
Error: node_modules/chartjs-plugin-annotation/types/index.d.ts:6:13 - error TS2428:
  All declarations of 'PluginOptionsByType' must have identical type parameters.6
  interface PluginOptionsByType<TType extends ChartType> {

which was fixed (as workaround) adding the default type (see https://github.com/chartjs/Chart.js/pull/11244, which should be reverted I think).
But now, I think there is another decision to take. I can submit a PR to fix this issue but there are other definitions that plugins/controller could augment and are not in a explicit export.
For instance, the zoom plugin is augmenting UpdateMode which is not explicitly exported. That means if other plugin will augment as well, adding another update mode, this issue will occur again for  UpdateMode (I have tested it, failing, in the repo that I created for this issue). Another example is ElementOptionsByType (augmented by annotation plugin).
@etimberg @kurkle @simonbrunel @dangreen what do you think? I think the best thing is to solve this issue as proposed above, and the other defintions which can be augment, we can take time for a solution. Make sense?

Great work on solving this!

@etimberg, @kurkle Is there a release planned soon? I have been stuck with v3.8.1 for over a year now. This fix and #877 finally lets me migrate to 4.x :-).

@liondog  4.3.1 Should be available in +- 30 minutes

Sorry, I'm not sure if this is related, but after updating to 4.3.1 I'm still getting type errors related to the typings:
chart.handler.ts:110:68 - error TS2339: Property 'labels' does not exist on type 'false | _DeepPartialObject<LegendOptions<keyof ChartTypeRegistry>>'.
  Property 'labels' does not exist on type 'false'.

110       renderLegendItems(chartElement, chart.options.plugins.legend.labels.generateLabels(chart));
                                                                       ~~~~~~

This happens for all plugin configurations, even build-ins like tooltip and legend:

I'm using this versions right now:

Also to mention that ng2-charts is also involved in version 3.1.2.
When I'm downgrading chartjs to 3.9.1 I don't have any issues.
Does anyone has an idea?

@maxhellwig no, the issue is related to #11420 and PR #11403. We are going to revert the PR soon.

@maxhellwig FYI, PR to fix it is submitted. #11422


Please add ninja-build in your installation instructions

I was constantly getting an error about "Ninja" which took me 2 hours to figure out what was going on. Please add this line in your README.md:
sudo apt-get install -y ninja-build

Thanks for the report, I updated the readme with a note about python binding build dependencies.


community[patch]: add size for message histories

Description:
Currently some ChatMessageHistory (neo4j, zep_cloud) support limit the size of message history, others are not. So this patch add history_size parameter to other ChatMessageHistory.
I have tried to use native database sort&limit capability to do this, but some databases seem not easy to handle it, then python list slice used.
NOTE: for deprecated ChatMessageHistory like AstraDB, I will try make PR to correspending repo.
Issue: N/A
Dependencies: N/A

What should happen with the system message? It's usually the first message? @baskaryan do you want to take lead -- I think it's relevant in context of trim_messages functionality.
Some nits (pending @baskaryan 's opinion on this)

Could you add * operator prior to any new named argument added to a function signature?
In places, where history size is interpolated into the SQL query could you do a run time check on it to be more defensive?

What should happen with the system message? It's usually the first message? @baskaryan do you want to take lead -- I think it's relevant in context of trim_messages functionality.
Some nits (pending @baskaryan 's opinion on this)

Could you add * operator prior to any new named argument added to a function signature?
In places, where history size is interpolated into the SQL query could you do a run time check on it to be more defensive?

@eyurtsev

* operator and runtime check fixed.
Now, system message is not added as history message. just input messages and output messages is processed. See
https://github.com/langchain-ai/langchain/blob/6b46b5e9ce6aa1bdc61a76e7778ec79afeb5691e/libs/core/langchain_core/runnables/history.py#L484

@baskaryan yes, history size in this PR is about reducing storage load, and can be combined with trim_messages to handle token-level limitations further.

@baskaryan yes, history size in this PR is about reducing storage load, and can be combined with trim_messages to handle token-level limitations further.

if its about storage then shouldn't we be using it in add_message, not load_message? ie when we add a new message, we check if our history is at capacity and delete the oldest message if so

@baskaryan yes, history size in this PR is about reducing storage load, and can be combined with trim_messages to handle token-level limitations further.

if its about storage then shouldn't we be using it in add_message, not load_message? ie when we add a new message, we check if our history is at capacity and delete the oldest message if so

Here, what I have in mind is that in an LLM application, we may need to retain complete user session data. Therefore, no restriction is applied in the add_message operation.
On the other hand, when constructing a prompt to be given to the LLM, we usually only require a limited number of the latest history records. Therefore, we can utilize the database's limit & sort mechanism to reduce the amount of data to be read, thereby improving the performance of loading historical data. Thus, the restriction is applied in the load_message operation.

On the other hand, when constructing a prompt to be given to the LLM, we usually only require a limited number of the latest history records.

My concern is that constructing the prompt is often more complex than getting the last n messages; e.g., the most common issue is failing to include the system message (which is the first message)

@eyurtsev @baskaryan based on the disscussion before, add history_size parameter seems not a good idea, I close the PR now.


Add Code Transformer Node

This is a feature request from Sean, who contacted us via email. I'm posting it here verbatim:

Obligatory feature request:
Javascript transformation node: Sometimes it's necessary to do some transformation of an LLM's output before feeding it into the next note (for example, in Chain of Thought prompting). A Javascript Transformation Node would helpful for that!

I'd suggest making this Python too, for parity with the code evaluators.

Moving this to high priority as another user has requested it.

Addressed by https://github.com/ianarawjo/ChainForge/pull/180


Set language to Italian

Hello, Is it possible to set the language of alexa in Italian?

https://github.com/alexa-pi/AlexaPi/wiki/Q&A-(FAQ)#can-i-switch-the-language-to-german-etc


This editor cannot detect the game process

After the update upon July, the editor cannot detect the game process, the error dialogue box notes that "the game is not running"

everything seems to be working fine for me, so I'm not sure what the issue is
do you mind telling me what OS you are using?

It turns out that I didn't run it with administrator rights. Everything is fine now. Thanks for your reply.


Development: Fix LTI authentication

Checklist
General

[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[x] I strictly followed the server coding and design guidelines.

Motivation and Context

Currently, users need to login to Artemis when they do a LTI launch from an external system even in the case they are already logged in. This issue is caused by the fact that the LTILaunchFilter is placed before the JWTFilter. As the authentication is checked within the JWTFilter, this information is just not yet present in the LTILaunchFilter, requiring a user login every time.
Description

Add LTI Filter after JWTFilter so authentication info is available at launch again

Remove code that sets a logout cookie for authenticated users
Adapts the tests to the changes

Steps for Testing

Prerequisites:

Access to Moodle
Testserver 1

Make sure you are logged in to Artemis with a test user (artemis_test_user_{1-5})
Navigate to Moodle and login with the same test user (artemis_test_user_{1-5}, same PW as for the Artemis Test Server)
Go to My Courses and open the course TS1 - Artemis Feature Demo Course
Click on one of the exercise
Artemis should be opened in an iFrame and you should still be logged in with the same test user

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Performance Review

[ ] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
[ ] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Screenshots

Summary by CodeRabbit

New Features

Enhanced security architecture by integrating JWT-based authentication for LTI 1.3 handling.
Streamlined user activation logic for JWT cookie management, improving clarity and maintainability.

Bug Fixes

Removed redundant checks related to user activation and LTI login requirements, simplifying session management.

Tests

Updated test methods to reflect changes in LTI query parameter handling for new and existing users.

I am going to steal the lock for TS1, hope that's okay :)

does not work on TS1 for me aswell and trying to log in artemis trough the iframe does not work for me aswell

I tested it on TS1 with 2 different devices and was logged in without problems, although Artemis is not displayed with an iFrame on the moodle site, but the user is directly forwarded to the Artemis page.

does not work on TS1 for me aswell and trying to log in artemis trough the iframe does not work for me aswell

I tested it on TS1 with 2 different devices and was logged in without problems, although Artemis is not displayed within an iFrame on the moodle site, but the user is directly forwarded to the Artemis page.

This is what I meant with:

Also, the multitude of testCourses on moodle that are all named the same but with only one having the correct links makes the review process quite uncomfortable.
The testing steps are quite confusing and the expected result does not occur no matter what course is used. Either the user is not logged in, or the course is not opened in an iFrame. I think that either something in the code still needs to be adjusted, or the testing steps need to be modified to match the expected outcome (if the way it is currently working is the intended way).

does not work on TS1 for me aswell, no iframe is displayed and in the moodle course with iframes it does not work

As far as I can see this issue is still not solved. To what setting is the "Default launch container" option in the LTI configuration of the moodle test course "TS1 - Artemis Feature Demo Course" set?

iFrame issue should be fixed now, pr can be tested and reviewed again


How to log more details about requests?

The folks at Google Ads API Support have asked for more details in order to handle my issue. The problem is I can't get the Ads library to log everything, this is all I have:

INFO   | jvm 1    | 2024/05/08 10:14:20 | INFO: May 8, 2024 10:14:20 AM com.google.ads.googleads.lib.logging.RequestLogger logAtLevel
INFO   | jvm 1    | 2024/05/08 10:14:20 | SUCCESS REQUEST SUMMARY. Method: google.ads.googleads.v15.services.KeywordPlanIdeaService/GenerateKeywordHistoricalMetrics, Endpoint: googleads.googleapis.com:443, CustomerID: xxxxxx, RequestID: yyyyy, ResponseCode: OK, Fault: null.

I followed the steps from Java Util Logging, so I start java with -Djava.util.logging.config.file=/xxx/jdk-logger.properties
The jdk-logger.properties contains:

handlers=java.util.logging.ConsoleHandler
com.google.ads.googleads.lib.logging.request.level=FINE
com.google.ads.googleads.lib.logging.request.level=FINE
java.util.logging.ConsoleHandler.level=FINE
java.util.logging.ConsoleHandler.formatter=java.util.logging.SimpleFormatter

How can I log the complete details about requests?

Hi,
The loggers need to match the Log name from the guide you mentioned.
Could you try changing the 2nd and 3rd lines to the following?
com.google.ads.googleads.lib.request.summary.level=INFO
com.google.ads.googleads.lib.request.detail.level=FINE

Thanks,
Josh, Google Ads API Team

Hi,
I'm closing this under the assumption that my last suggestion fixed the issue, but feel free to reopen the issue if you're still having trouble with the logging config.
Thanks,
Josh

Hi Josh,
Thanks for your suggestion. It didn't work, the culprit being a service wrapper (tanuki) that I couldn't get to play nice and had to bypass.
I eventually fixed the issue by using log4j with this log4j.properties file:
logDir=/usr/local/service

log4j.rootLogger=DEBUG, log1

log4j.appender.log1=org.apache.log4j.DailyRollingFileAppender
log4j.appender.log1.layout=org.apache.log4j.PatternLayout
log4j.appender.log1.layout.ConversionPattern=%d{MM/dd/yyyy hh:mm:ss a}|%-5p|%-30c{1}| %m%n
log4j.appender.log1.DatePattern='.'yyyy-MM-dd
log4j.appender.log1.File=${logDir}/ads_api.log
log4j.appender.log1.append=true

log4j.appender.log1.filter.1=org.apache.log4j.varia.StringMatchFilter
log4j.appender.log1.filter.1.StringToMatch=REQUEST
log4j.appender.log1.filter.1.AcceptOnMatch=true
log4j.appender.log1.filter.2=org.apache.log4j.varia.DenyAllFilter

log4j.logger.com.google.ads.googleads.lib.request.summary=ALL
log4j.logger.com.google.ads.googleads.lib.request.detail=ALL

And of course using this property:
-Dlog4j.configuration=log4j.properties
Disabling log truncation worked using -Dapi.googleads.maxLogMessageLength=-1:
    monthly_search_volumes {
      month: JANUARY
      year: 2024
      monthly_searches: 10
    }
    monthly_search_volumes {
      month: FEB
... TRUNCATED. See README.md to configure/disable log truncation.

Thank you again.


[SourceKit] Add a new request to translate markup text to its XML equivalence. rdar://30587403

@swift-ci please smoke test

@bitjammer mind taking a look at this patch?

@swift-ci please smoke test

This failed ASAN testing. I'm reverting in #8088. Please do not commit again without running ASAN first.

Build log here: https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/177/testReport/junit/Swift(macosx-x86_64)/SourceKit_ExtractComment/extract_comments_swift/

@nkcsgexi, LineList only has an ArrayRef of Lines, and Line only has a StringRef. You might want to pass an MC & into getLineListFromComment perhaps and hold onto it in the stack frame above.

oh, that makes sense.


2000 stars

:tada:
Are you going to give away more Ramda schwag, @buzzdecafe?

:birthday:

:balloon: :tulip: :balloon:

So, we need to organize a giveaway whenever we pass a 1000 * (2 ^ n) marker?  Sounds good to me.

C'mon, can't you wait for a proper power of 2? 211 is only 44 stars away :-)

C'mon, can't you wait for a proper power of 2? 211 is only 44 stars away :-)

sounds good to me

But we did our first at 1000.  Perhaps we were just jumping the gun.
nothing personal, of course

ok, I'm convinced.  (10) ^ 3, then (2) ^ 11.  Next one should logically be at (-6) ^ 19.  When we get below -609 trillion stars, somebody start paying attention.  :smile:
"Waldo, the question is what are you doing out there?"

+1 @davidchambers
I like μ.swag

μ sticker

base^exp -> (exp-1)^(base+1)
so:
10^3 -> 2^11 -> 10^3 -> 2^11 -> etc

Jesus - how does that sticker have so many reviews

Are you going to give away more Ramda schwag, @buzzdecafe?

you are pretty free with my :dollar: @davidchambers
Nonetheless, let's do this @ 2048 :star: , which is coming up pretty fast. I'll compile a list of contributors since 1000 and hold another random drawing.

@megawac
Ramda rox?

superseded by https://github.com/ramda/ramda/issues/1086


Rely on the build command and pre-command provided by Exec

This should give access to options such as :shell, :precommand, etc. to the docker backend.
I had to give multiple goes at it.
The idea is build_command works fine already, no need to recreate it. There is no need to force /bin/sh as the shell either. The command shellsplit will take the command we have and execute it as expected.
Regarding the pre_command, we unfortunately can't simply do && in docker (because docker runs executables, not shell, the command itself will start the shell); so instead we do two docker_run, one with the pre_command, one with the actual command.
This gives access to :interactive_shell, :login_shell, :shell and :precommand.
I haven't played with :path, it might be worth having something that sets an env variable in docker, but still it makes docker testing much easier.

Thanks!

Released as v2.67.1.


[Single sign-on / Federated authentication for applications][RC Based][SAML]

Single Sign-On / Federated authentication for a web application with SAML |
SP-Init
IdP-Init
SAML POST Binding
SAML Redirect Binding
SAML 2.0 Artifact binding support
End-user consent and claim mapping

Single Sign-On / Federated authentication for a web application with SAML |
SP-Init
IdP-Init
SAML POST Binding
SAML Redirect Binding
SAML 2.0 Artifact binding support
End-user consent and claim mapping

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Update TextFormatEncodingVisitor.swift

Fixing issue with exclusive memory access raised in Xcode 9.0-beta 3

Note: This is the issue mentioned in this proposal 0176-enforce-exclusive-access-to-memory

I believe that #612 (which I just merged) fixes this.

Checking out #612 to see if that catches it… in our local copy we changed the signature of _visitPacked to (value: [T], fieldNumber: Int, encode: (inout TextFormatEncoder, T) -> ()) throws and that took care of it.

Yep, #612 caught it. I think this can be closed. @tbkka are we expecting a tag soon, or still powering through to 1.0?

@zwaldowski:  Thanks for verifying.  Closing.
(I'll push a new tag soon.)


avx512/load_pd: initial implementation

The implementation is similar to #944

Thank you @operasfantom ; this was merged as https://github.com/simd-everywhere/simde/commit/844568401a0a50506960f4e7b4ca1f173fa96a93


murmur service: log to journald by default

Save an option to log to file with new logFile option.
As a side effect deprecate pidfile option and instead use systemd's
RuntimeDirectory.
Motivation for this change
Simple logs when the application in question doesn't do anything fancy (custom rotation or stuff) are more convenient being in journald.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval

@abbradar poke ;)

Tested it; still works and useful. Merging.


Added support for beta and rc version tags to BuildToolkit

I restructured the whole version definition within the build toolkit. For now it will be split up in three sections:

Release tags
Pre release tags
CI branches

The versioning is following striclty the SemVer versioning scheme. And therefore best practices for applying it to .NET assemblies: https://stackoverflow.com/questions/64602/what-are-differences-between-assemblyversion-assemblyfileversion-and-assemblyin
Legend

MA = Major
MI = Minor
P = Patch
B = Build Number
N = Any number

Release tags:

Ref
Version
FileVersion
InformationalVersion
Package Version

refs/tags/vMA.MI.P
MA.0.0.0
MA.MI.P.B
MA.MI.P+commitHash
MA.MI.P

refs/tags/v3.1.2
<IP_ADDRESS>
<IP_ADDRESS>
3.1.2+d95a996
3.1.2

Pre-release tags:

Ref
Version
FileVersion
InformationalVersion
Package Version

refs/tags/vMA.MI.P-beta.N
MA.0.0.0
MA.MI.P.B
MA.MI.P-beta.N+commitHash
M.M.P-beta.N

refs/tags/v3.1.2-beta.1
<IP_ADDRESS>
<IP_ADDRESS>
3.1.2-beta.1+d95a996
3.1.2-beta.1

refs/tags/vMA.MI.P-rc.N
MA.0.0.0
MA.MI.P.B
MA.MI.P-rc.N+commitHash
M.M.P-rc.N

refs/tags/v3.1.2-rc.1
<IP_ADDRESS>
<IP_ADDRESS>
3.1.2-rc.1+d95a996
3.1.2-rc.1

CI branches:

Ref
Version
FileVersion
InformationalVersion
Package Version

refs/heads/some/name
MA.0.0.0
MA.MI.P.B
MA.MI.P-somename.B+commitHash
M.M.P-somename.B

refs/heads/dev
<IP_ADDRESS>
<IP_ADDRESS>
3.1.2-dev.42+d95a996
3.1.2-dev.42

If this is merged, it is possible to push tags with the described versioning scheme and create packages from it.

I haven't looked at the changes, but I really like the solution. ;-)

Should we use only MA.0 as Version?


Unboxing CGRects from custom format

I have JSON files that encode CGRects as arrays, for example r = CGRect(x: 10, y: 10, width: 100, height: 200) is represented as { "r":[10,10,100,200] }.
Writing a wrapper for Wrap is easy:
extension CGRect: WrapCustomizable {
  public func wrap() -> AnyObject? {
    return [self.origin.x, self.origin.y, self.size.width, self.size.height]
  }
}

But now I'm trying to implement the inverse. Is it possible to add support for this format to Unbox by writing the right extensions for CGRect? As far as I understand, all solutions using UnboxableRawType, UnboxableByTransform or UnboxableWithFormatter require custom String parsing, which I don't want to do.
My current solution is to write an extension for Unboxer like this:
extension Unboxer {
  func unbox(key:String) -> CGRect {
    let a:[CGFloat] = self.unbox(key)
    if a.count == 4 {
      return CGRect(x: a[0], y: a[1], width: a[2], height: a[3])
    }
    return CGRectZero
  }
}

Is there a better way, using the designated customization points, that works together with the other features like getting failure info?

Hey @Theome, you're right - using UnboxableByTransform is currently restricted to UnboxRawTypes (like Int, String, etc) - but that should definetly be fixed! Will work on a fix right now :)

This commit fixes the problem: https://github.com/JohnSundell/Unbox/commit/94f20e380334d0ab35778521f250123c81ffca1b
Now any type can be used as a raw value for a type conforming to UnboxableByTransform, so you can implement an extension for CGRect like this:
extension CGRect: UnboxableByTransform {
    public typealias UnboxRawValueType = [CGFloat]

    public static func transformUnboxedValue(unboxedValue: [CGFloat]) -> CGRect? {
        if unboxedValue.count < 4 {
            return nil
        }

        return CGRect(
            x: unboxedValue[0],
            y: unboxedValue[1],
            width: unboxedValue[2],
            height: unboxedValue[3]
        )
    }

    public static func unboxFallbackValue() -> CGRect {
        return CGRect()
    }
}

Will make a new release with the change tonight :)

The release has now been 🚢ed! Update Unbox to 1.6 to get the fix :)

Great! Thank you very much :)


Use esbuild for the Vite production build

Describe the solution you'd like
Use esbuild for the Vite production build
What does your solution aim to solve?
Slow compilation when building the container images.

Tracking: https://vitejs.dev/guide/why.html#why-not-bundle-with-esbuild


warning: File for type 'com.raizlabs.android.dbflow.config.GeneratedDatabaseHolder' created in the last round will not be subject to annotation processing.

I'm receiving the following warning when building my project using DBFlow.
warning: File for type 'com.raizlabs.android.dbflow.config.GeneratedDatabaseHolder' created in the last round will not be subject to annotation processing.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 warning

Should this be a concern?

I'm getting this as well, and then all of my methods that access the DB get this error
Error:(341, 34) error: incompatible types: Object cannot be converted to Membership
Membership in this case just being one example

Ok so here's an update on my issue, in Android Studio I moved some of my object models (not DBFlow) to a different package and when that happened all of my List<SpecificObject> values for those moved models were turned into java.util.List for some reason.
Long story short I had to fix those auto-generated regressions from Android studio, and ultimately my issues we're not related to DBFlow.

removed processingOver execution and just execute write.


Support --project together with --project-id

cpdctl dsjob support {--project PROJECT | --project-id PROJID}, which is very obvious and convenient and not easy to make mistakes
Can we quickly enable this as well for all cpdctl command? It will be consistent as well.
Thanks very much!

With PROJECT, you mean a project name instead of the project ID?
Project names are not unique. And they require at least one extra backend call to resolve them into an ID.


Metrics on overall behavior

It's ok that we somehow estimate effectiveness of this controller, but having some test scenarios with metrics, would help alot with estimating this more precisely

I think this would be quite challenging for macro-behaviors. Smaller things like smoothness and exact path following can be more exactly quantified, but system level behavior I think is very much qualitative (depending on the application and desired properties).

But in general:

Smooth non-jerky motion
Away from obstacles to a "reasonable" degree, don't skirt right up to them
"fluid" in some cases, rigid-exact-path-following in others

I don't see a way to do it fast in nearest perspective


Improve mission_control quality

Description
This patch improves and augments mission_control test suite, fixing most issues that popped up as result.
Type of change
Please mark options that are relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] The code builds clean without any errors or warnings
[x] Unit tests are passing
[x] Linter tests are passing

How To Test
Run mission_control unit tests sequentially:
catkin_make -j1 run_tests_mission_control

If ran in parallel, some tests flake (see below).

About flakes and #166. While I wasn't able to reproduce the hangs, I can reproduce these flakes which are caused by mission_control interface messages being serviced out of order. There's no guarantee that e.g. execute and abort messages, sent in quick succession, will be processed in that order.
This, coupled with the mission not being reset (see fix in https://github.com/ChrisScianna/ROS-Underwater-RnD/pull/173/commits/c5756266942a39f75e07ea947e89cf697ca15595), makes me think that, in the situation pictured in #166, a mission hard-stop was processed before execute and abort, which would've left a mission stuck in an abort state. It's just a hypothesis though.

Thanks for the review @patapufate ! Going in.


HistogramTimers should be #[must_use]

HistogramTimers should be either kept in a variable (so that it will not be immediately dropped), or manually call its observe_duration() interface. In this way, it should be marked as #[must_use].
Resolve #145

@overvenus PTAL

Ping @breeswish

@overvenus @Hoverbear PTAL again, thanks!


CLIMATE-773 - Add Continuous Integration (Travis-CI)

Do you have evidence of this running and it being stable @jarifibrahim ?

@lewismc Yes. The Travis build fails because of the bad tests but Travis works as expected. I've created a Travis-test branch which works fine after fixing the tests.

Thanks

Thanks @jarifibrahim


[Improve] [Doc] add apache license

What do these changes do?

add apahce license on README
Related issue number

Closes #xxxx
Check code requirements

[ ] tests added / passed (if needed)
[ ] Ensure all linting tests pass, see here for how to run them

Maybe we can check the license in the CLI check, I don't know if there is such a measure at the moment

cc @chaokunyang

@caicancai We've already has the license header check in CI.

@caicancai We've already has the license header check in CI.

thank your reply . This is a good idea


Introduce "Running the Airy Core Plaform in production" guide

We introduce a new section in the docs called "guides" (so that we can add more guides in the context of this milestone)
Proposed structure (we can discuss this further in the PR directly):
## Requirements

## Configuration

### AWS

### Gcloud

### Azure

### Digital ocean

The cloud providers part can be left as TODO in the first pr. It's enough to cover all the requirements (size of a kubernetes cluster, how to get the code up and running in the cluster, how to run the services (redis, postgres, kafka, zookeeper) both in the same kubernets cluster or how to configure the apps so that the system works)

this was done in #338


Add Ruby / Ruby on Rails config to docs.

Pull Request Test Coverage Report for Build 805

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 17.126%

Totals

Change from base Build 802:
0.2%

Covered Lines:
466

Relevant Lines:
2721

💛  - Coveralls

Thanks for your contribution. I believe source.ruby and a Syntax entries with just "Ruby" and "Rails" should work as well - that feature should be documented!


v7.3.0 tracking issue

Main additions to this release are:
Support for Wasm clients
Support for light clients written in any language that has a compilation target to Wasm. The first Wasm client developed with ibc-go/v7 02-client refactor and stored as Wasm bytecode will be the GRANDPA light client used for Cosmos <> Substrate IBC connections. This feature will be used also for a NEAR light client in the future. Shout-out to to Composable Finance and Strangelove for the development of this feature.
JSON encoding of ICA transactions
See this issue for more information. Including this feature in the release depends on whether the implementation can be back ported to the release branch of v7.3.x.
Support for ADR 8 middleware
Adding an optional interface that IBC applications can implement for their packet data, such that, when implemented, middleware can target this interface in order to get the desired callback addresses on the source and destination chains.
Milestones
v7.3.0 milestone
IBC spec compatibility
v1.0
QA
Backwards compatibility

[ ] Compatibility tests pass for the release branch.
[ ] Upgrade tests pass.

Other testing
TBD integration testing with third parties.
Migration
v7.1 to v7.3 migration docs (add link when available).
Checklist

[x] Branch off release/v7.2.x to create release branch in the form  of release/v7.3.x and make sure branch protection rules apply.
[x] Add backport task to mergify.yml
[ ] Upgrade ibc-go version in ibctest.
[ ] Check Swagger is up-to-date.

Post-release checklist

[ ] Update CHANGELOG.md
[ ] Update the table of supported release lines (and End of Life dates) in RELEASES.md:

Add the new release line.
Remove any release lines that might have become discontinued.

[ ] Update version matrix in RELEASES.md:

Add the new release.
Remove any tags that might not be recommended anymore.

[ ] Update the list of supported release lines in README.md, if necessary.
[ ] Update docs site:

[ ] Add new release branch to docs/versions file.
[ ] Add label and key to versions array in config.js.

[ ] Update the compatibility test matrices:

Add the new release.
Remove any tags that might not be recommended anymore.

[ ] Update the manual e2e simd test workflow and remove any tags that might not be recommended anymore.
[ ] After changes to docs site are deployed, check ibc.cosmos.network is updated.
[ ] Open issue in SDK tutorials repo to update tutorials to the released version of ibc-go.

For Admin Use

[x] Not duplicate issue
[x] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

Green compatibility tests before final release.


Long Input Entries Cause Potential Performance and UI Issues

Description:
While testing the related pull request locally, an issue was observed with the "Registration" page when users enter an excessively long input in the Affiliation and Position fields. The long inputs could potentially cause performance issues, as well as degrade the user experience.
Steps to Reproduce:
Follow the test steps in the pull request.
Navigate to the Registration page using the test account credentials:
Email<EMAIL_ADDRESS>Password: curator
In the Affiliation field, enter a very long entry (e.g., "Harvard University") and repeat/paste it multiple times to create a string of 1,000+ characters.
In the Position field, enter a very long entry (e.g., "Affiliate") and repeat/paste it multiple times to create a string of 1,000+ characters.
Click on Create Account.
Observed Behavior:
The form processes the inputs, but there is no restriction on the character length for these fields.
This may lead to performance bottlenecks or unexpected UI behavior.
Expected Behavior:
The input fields should have a sensible character limit to prevent performance and usability issues.
Questions for Discussion:
Should we impose a maximum character limit on the Affiliation and Position fields?
If so, what should the limit be (e.g., 255 characters)?
Suggested Fix:
Add input validation to both Affiliation and Position fields to enforce a character limit.
Implement server-side validation to ensure data integrity in case of API misuse.

I'm just adding the nice screenshot from https://github.com/IQSS/dataverse-frontend/pull/558#issuecomment-2557483432


Paypal is in Mail App Picker (Android)

Hi, I copied the code from here: https://pub.dev/packages/open_mail_app
and it works fine, but among the 3 mail apps that I have installed on my Xiaomi Mi 9T (Android 9 Pie) it also shows me the PayPal app. Do you know why the standard filter could fail?
   `RaisedButton(
      child: Text("Open Mail App"),
      onPressed: () async {
        // Android: Will open mail app or show native picker.
        // iOS: Will open mail app if single mail app found.
        // OpenMailApp.setFilterList(List.of({'paypal'})); // it shows me paypal with or without this line
        OpenMailAppResult result = await OpenMailApp.openMailApp();

        // If no mail apps found, show error
        if (!result.didOpen && !result.canOpen) {
          showNoMailAppsDialog(context);

          // iOS: if multiple mail apps found, show dialog to select.
          // There is no native intent/default app system in iOS so
          // you have to do it yourself.
        } else if (!result.didOpen && result.canOpen) {
          showDialog(
            context: context,
            builder: (_) {
              return MailAppPickerDialog(
                mailApps: result.options,
              );
            },
          );
        }
      },
    ),`

Thank you and best regards :)

It's been a while since I worked on this (and I am no longer a contributor), but I also noticed this when using and building the library.
PayPal unfortunately registers itself as capable of sending an email.
To filter you can use getMailApps, filter the result yourself, and then use openSpecificMailApp. You would also need to build your own dialog in this case.


Puppetry Kinectv2 plug-in first commit

This is the first code for experimental Puppetry plug-in using the Kinectv2 device.

Hey, @simon-linden, You will want to take a look at how the puppetry and opencv modules define their dependencies using optional requirements. It would be best to keep any dependency installation consistent and idiomatic to users' expectations of python packaging. Rather pursuing README instructions and manually installing dependencies, it'd be simpler if we can provide a simple pip install ... command.
Additionally, I see that the kinect dependency requires a diff be manually applied to a deprecated upstream. This seems particularly onerous. I'd suggest that, if the deprecated module must be used and there are no alternatives, that you consider forking the upstream, making the necessary updates, and specifying it as a dependency using pip's git repo syntax. This way all users would have to do is pip install leap[kinect] or similar and get everything they need to run your demos.


[KARAF-5792] Add support of add/rename/remove of properties in all collectors

Can you rebase please to resolved the conficts ?

Done

Thanks


Tracked videos

https://github.com/mautic/mautic/pull/4480

Made change with last instruction  merged to 2.9.1  https://github.com/mautic/mautic/pull/4480


test: synchronizing gherkin spec

What
APM agent specs automatic sync
Why
Changeset

https://github.com/elastic/apm/commit/0346953 fix typo in messaging otel spec (https://github.com/elastic/apm/pull/617)

:broken_heart: Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-03-28T10:02:10.300+0000

Duration: 25 min 15 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
4716

Skipped
2985

Total
7701

Steps errors
Expand to view the steps failures

Shell Script

Took 0 min 18 sec . View more details here
Description: ./tests/scripts/docker/run_tests.sh python-3.10 celery-4-flask-1.0

Shell Script

Took 0 min 16 sec . View more details here
Description: ./tests/scripts/docker/run_tests.sh python-3.10 celery-4-flask-1.0

Restore files previously stashed

Took 0 min 0 sec . View more details here
Description: coverage-python-3.10-pymongo-newest

Restore files previously stashed

Took 0 min 0 sec . View more details here
Description: coverage-python-3.10-pylibmc-newest

Restore files previously stashed

Took 0 min 0 sec . View more details here
Description: coverage-python-3.10-psutil-newest

Restore files previously stashed

Took 0 min 0 sec . View more details here
Description: coverage-python-3.10-aiohttp-newest

Restore files previously stashed

Took 0 min 0 sec . View more details here
Description: coverage-python-3.10-httpx-newest

Archive the artifacts

Took 0 min 0 sec . View more details here
Description: [2022-03-28T10:27:22.437Z] Archiving artifacts
Python-python-3.10-celery-4-flask-1.0 tests failed :

Error signal

Took 0 min 0 sec . View more details here
Description: Python-python-3.10-celery-4-flask-1.0 tests failed : hudson.AbortException: script returned exit code 2

:green_heart: Flaky test report
Tests succeeded.
:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

/test linters : Run the Python linters only.

/test full : Run the full matrix of tests.

/test benchmark : Run the APM Agent Python benchmarks tests.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)


Unsupported Erlang version (erl 20)

i've got this error using rustler crate:
--- stdout
Unsupported Erlang version.

my erlang version:
Erlang/OTP 20 [RELEASE CANDIDATE 2] [erts-9.0] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:10] [hipe] [kernel-poll:false]

Eshell V9.0  (abort with ^G)

erlang_nif-sys version from Cargo.lock
[[package]]
name = "erlang_nif-sys"
version = "0.6.1"

I do have an otp20 branch in progress.  I also know that the NIF API is going to change before the final otp-20 release lands, so the intention is to not release a new crate until otp-20 is formally released.

thank you for clarifying this
i will mark this issue as resolved then

Reopening to track progress of otp20 branch.
otp20 branch is committed.  It needs enif_select testing and backwards compatibility work, but it should be suitable if you are keen on using otp20 with Rust right now.

Thank you! My apologies for the duplicate issue

Getting same error with erlang 20.2

I plan on doing some maintenance on this project during my Christmas holiday.

Fixed in 447e4ac70cfe1becc20a7bd02d4c21b0cfc22763.
I'm having some issues with crates.io.  Will publish as soon as I can.

Thanks!


Hex focus color codes

Issue
It should be possible to also use HTML hex color codes with the focus command:
focus Jane = #c1a657

Notes
In addition to the hex colors, the help focus section should be updated with examples.

Resolved in PR #150


Fix #2717, Driver vmwarefusion fail because of soft link

Fix #2717

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:rediceli/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:rediceli/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Thanks a lot @rediceli. I'd rather you don't ignore the error returned by filepath.EvalSymlinks. Can you fix the code?

LGTM

@rediceli can you change the return state and we should be good to go.
thanks

@rediceli It looks like you pushed after @jeanlaurent's commit but with the initial code. Is it what you wanted?

It seems like I made a mistake.  :）

LGTM (for real now!)

LGTM


freeze and defrost for saving and resuming a big crawl? enhancement

Would be awesome to have the already visited urls saveable so that you can restart a crawl later and not revisit links, to start where you left off.

Thanks, sounds like a good idea. We can probably just save the state and then read is back when the crawler is restarted. Something that can be added to a future version

I'm having an issue with a large crawl stalling, and having to restart. Perhaps due to a flaky internet connection? Not certain, but something along these lines would be hugely helpful!

Yes, this would be very useful!

Would be awesome to have the already visited urls saveable so that you can restart a crawl later and not revisit links, to start where you left off.

To save a whole url is very wasteful, you can consider doing it by calculate a murmur-hash for each url, and when any conflict happens, you need to make a further comparison with original urls (can be save to a permanent storage) to avoid wrong-matching

I'm having an issue with a large crawl stalling, and having to restart. Perhaps due to a flaky internet connection? Not certain, but something along these lines would be hugely helpful!

Add a timeout option to request is a workaround for bad internet connection.


ENYO-2834: Adjust checkbox size

Enyo-DCO-1.1-Signed-off-by: Stephen Choi<EMAIL_ADDRESS>

closing out - issue fixed with another PR.


sanitize option

allow users to specify whether or not they should sanitize input.
https://github.com/nashwaan/xml-js#options-for-converting-xml--js-object--json
should solve this issue in the comments:
https://github.com/PathwayCommons/sbgn-renderer/issues/45

xml-js sanitize only works on text after it has converted.  It does not sanitize before conversion


tests: switch to minitest 5

Ruby 1.9+ uses Minitest as the backend for Test::Unit, so we might as well update to the Minitest 5 API.
It would be a good idea to merge #47 before merging this PR. This PR will need a small rebase to account for the rake-compiler addition in rinku.gemspec.

@vmg Thanks for merging #47 - I've rebased this branch today, so this PR is ready to merge as well

:ok_hand:

Thanks!


Applied fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Coverage remained the same at 100.0% when pulling 731d33be21a2b878d256312d1810d2363d8b6c12 on analysis-XWoG1E into 2b8eb24e21209fc72ebf1d48d85336c3cf8ab37d on quick-reply.


Reenable incremental compilation

This doesn't seem to reproduce in 1.58

Should we introduce the rust-toolchain.toml so that developers always pick the right Rust toolchain?

Interesting, didn't know that was a thing. Generally we support building on the latest stable, I don't think we need to require something more specific in a toolchain file.

But if incremental is now active, devs not upgrading to 1.58 will likely face ICE on incremental build, hence why I suggested we introduced the toolchain file.

@lutter Thanks for checking! I've changed this to just update the comment.


FIX: provide correct did:web resolver configuration

Hello,
SSI Wallet fails verify credentials when issuer uses did:web method.
Wallet throws unsupportedDIDMethod error that originates from the instance of the Resolver when mapping is not found.
web-did-resolver resolver is not provided correctly.

Hi @linasi, we have a few delays with a new release of the app. We are working on getting one asap :)


xdg-user-dirs: 0.16 -> 0.17

Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:

built on NixOS
ran /nix/store/2isrxm5fr9kgxkh0pbzb5d77jpip1vvd-xdg-user-dirs-0.17/bin/xdg-user-dirs-update --help got 0 exit code
ran /nix/store/2isrxm5fr9kgxkh0pbzb5d77jpip1vvd-xdg-user-dirs-0.17/bin/.xdg-user-dirs-update-wrapped --help got 0 exit code
ran /nix/store/2isrxm5fr9kgxkh0pbzb5d77jpip1vvd-xdg-user-dirs-0.17/bin/xdg-user-dir -h got 0 exit code
ran /nix/store/2isrxm5fr9kgxkh0pbzb5d77jpip1vvd-xdg-user-dirs-0.17/bin/xdg-user-dir --help got 0 exit code
ran /nix/store/2isrxm5fr9kgxkh0pbzb5d77jpip1vvd-xdg-user-dirs-0.17/bin/xdg-user-dir help got 0 exit code
found 0.17 with grep in /nix/store/2isrxm5fr9kgxkh0pbzb5d77jpip1vvd-xdg-user-dirs-0.17
directory tree listing: https://gist.github.com/e8c151156e7a65f9f958a9a64e1e5a86

cc @lethalman for review

Success on aarch64-linux (full log)
Attempted: xdg-user-dirs
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/v0wm6k6ypwqfz0qhzcia41m55mp98cf8-xdg-user-dirs-0.17
shrinking /nix/store/v0wm6k6ypwqfz0qhzcia41m55mp98cf8-xdg-user-dirs-0.17/bin/.xdg-user-dirs-update-wrapped
gzipping man pages under /nix/store/v0wm6k6ypwqfz0qhzcia41m55mp98cf8-xdg-user-dirs-0.17/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/v0wm6k6ypwqfz0qhzcia41m55mp98cf8-xdg-user-dirs-0.17/bin
patching script interpreter paths in /nix/store/v0wm6k6ypwqfz0qhzcia41m55mp98cf8-xdg-user-dirs-0.17
/nix/store/v0wm6k6ypwqfz0qhzcia41m55mp98cf8-xdg-user-dirs-0.17/bin/xdg-user-dir: interpreter directive changed from "/bin/sh" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/v0wm6k6ypwqfz0qhzcia41m55mp98cf8-xdg-user-dirs-0.17...
/nix/store/v0wm6k6ypwqfz0qhzcia41m55mp98cf8-xdg-user-dirs-0.17

Success on x86_64-linux (full log)
Attempted: xdg-user-dirs
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2isrxm5fr9kgxkh0pbzb5d77jpip1vvd-xdg-user-dirs-0.17
shrinking /nix/store/2isrxm5fr9kgxkh0pbzb5d77jpip1vvd-xdg-user-dirs-0.17/bin/.xdg-user-dirs-update-wrapped
gzipping man pages under /nix/store/2isrxm5fr9kgxkh0pbzb5d77jpip1vvd-xdg-user-dirs-0.17/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/2isrxm5fr9kgxkh0pbzb5d77jpip1vvd-xdg-user-dirs-0.17/bin
patching script interpreter paths in /nix/store/2isrxm5fr9kgxkh0pbzb5d77jpip1vvd-xdg-user-dirs-0.17
/nix/store/2isrxm5fr9kgxkh0pbzb5d77jpip1vvd-xdg-user-dirs-0.17/bin/xdg-user-dir: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/2isrxm5fr9kgxkh0pbzb5d77jpip1vvd-xdg-user-dirs-0.17...
/nix/store/2isrxm5fr9kgxkh0pbzb5d77jpip1vvd-xdg-user-dirs-0.17


A different approach for ng-if

So a lot of people have commented about the lack of a ng-if type of behavior, this is a basic feature that almost everyone expect from a module that manages roles and permissions.
Yes, I read the docs and I know about the PermPermissionStrategies, but this is just going to make us duplicate the behavior of ng-if and we are probably going to get it wrong, I tried and couldn't make it work like ng-if.
What we can do is use the ng-if directive from angular and pass values from the permissions module so ng-if evaluates them an acts accordingly.

I did some research and it seems some people have done it.
https://stackoverflow.com/questions/26907440/enable-angulars-built-in-directives-like-ng-if-to-have-access-to-a-variable-f

1 I see this useful

I personally created a component to handle this quite some time ago.
has-permission.component.js
(function() {
  'use strict';

  angular
    .module('app')
    .component('hasPermission', {
      bindings: {
        permission: '<'
      },
      templateUrl: 'app/common/permissions/has-permission/has-permission.html',
      transclude: true,
      controller: Controller
    });

  /** @ngInject */
  function Controller(PermPermissionMap, PermAuthorization) {
    let ctrl = this;

    ctrl.$onInit = function() {
      let PermissionMap = new PermPermissionMap({
        only: ctrl.permission
      });

      let authorizationResult = PermAuthorization.authorizeByPermissionMap(PermissionMap);

      authorizationResult
        .then(function() {
          ctrl.hasPermission = true;
        })
        .catch(function(rejectedPermission) {
          ctrl.hasPermission = false;
        });
    }

  }

})();

has-permission.html

Thanks for your help, I also created a similar solution but I managed to do it using ng if in a more "direct" way.
Example

    Only users with the permssion "admin" see this
</div

angular.module('app').directive('hasPermission', function(ngIfDirective, PermAuthorization, PermPermissionMap, PermPermissionStore, $rootScope) {
    var ngIf = ngIfDirective[0];

    return {
        transclude: ngIf.transclude,
        priority: ngIf.priority - 1,
        terminal: ngIf.terminal,
        restrict: ngIf.restrict,
        scope:{
            hasPermission: '@'
        },
        link: function(scope, element, attributes) {

            scope.initialNgIf = attributes.ngIf, scope.ifEvaluator;

            scope.checkAuth = function() {
                // Check if the user has the permission defined on scope.hasPermission
                var checkAuthPromise = PermAuthorization.authorizeByPermissionMap(new PermPermissionMap({only: scope.hasPermission}));
                checkAuthPromise.then(function () {
                    scope.isPermitted = true
                }).catch(function () {
                    scope.isPermitted = false
                })
            }

            // Check on every StateChange fired by ui-permission in case the user has gained / lost his previous permissions
            $rootScope.$on('$stateChangePermissionStart', function(event, toState, toParams, options) {
                scope.checkAuth()
            });

            // The value evaluated by ng-if
            attributes.ngIf = function() {
                return scope.isPermitted
            };

            ngIf.link.apply(ngIf, arguments);
        }
    };
});

I dont like that the directive depends on a promise to check the permission, this is the only way I could find to make it work with ng-if but Im sure someone can make it cleaner (or event better, provide a function and not a promise to check the permissions).

Thanks for your help, I also created a similar solution but I managed to do it using ng if in a more "direct" way.
Example

    Only users with the permssion "admin" see this
</div

angular.module('app').directive('hasPermission', function(ngIfDirective, PermAuthorization, PermPermissionMap, PermPermissionStore, $rootScope) {
    var ngIf = ngIfDirective[0];

    return {
        transclude: ngIf.transclude,
        priority: ngIf.priority - 1,
        terminal: ngIf.terminal,
        restrict: ngIf.restrict,
        scope:{
            hasPermission: '@'
        },
        link: function(scope, element, attributes) {

            scope.initialNgIf = attributes.ngIf, scope.ifEvaluator;

            scope.checkAuth = function() {
                // Check if the user has the permission defined on scope.hasPermission
                var checkAuthPromise = PermAuthorization.authorizeByPermissionMap(new PermPermissionMap({only: scope.hasPermission}));
                checkAuthPromise.then(function () {
                    scope.isPermitted = true
                }).catch(function () {
                    scope.isPermitted = false
                })
            }

            // Check on every StateChange fired by ui-permission in case the user has gained / lost his previous permissions
            $rootScope.$on('$stateChangePermissionStart', function(event, toState, toParams, options) {
                scope.checkAuth()
            });

            // The value evaluated by ng-if
            attributes.ngIf = function() {
                return scope.isPermitted
            };

            ngIf.link.apply(ngIf, arguments);
        }
    };
});

I dont like that the directive depends on a promise to check the permission, this is the only way I could find to make it work with ng-if but Im sure someone can make it cleaner (or event better, provide a function and not a promise to check the permissions).

This is a nagularjs service ↓
globalService.checkHasItem = (mainArray, array) => {

      // mainArray: all roles will be in this array, you get these from server, for example → ['role1', 'role2', 'role3', 'role4', 'role5', 'role6', ...]
      // array: some roles, for example → ['role3', 'role4']

      let hasItem = false;

      // with this ↓ I check if user has role
      array.map((item) => {
         // use this for filters → https://github.com/a8m/angular-filter#contains
         if ($filter('contains')(mainArray, item)) {
            hasItem = true;
         }
      });

      return hasItem;
};

in generlCtrl.js ↓
$rootScope.checkPerms = (perms) {
      return globalService.checkHasItem(userPerms, perms);
 };

Now in view
<button ng-if="checkPerms(['role4'])">just user with 'role4' can click this button</button>


Redirect directly to config page when sync comples

Currently you end up on this page

Instead you should be redirected directly to /{user}/{config-slug}

I would like to work on this issue. Please guide me, how can I resolve this.

Follow https://github.com/codicocodes/dotfyle/blob/main/CONTRIBUTING.md to get started,
After setup, authenticate with GitHub and navigate to http://localhost:5173/add to go through the feature which adds a new config.
Let me know if you have more questions after completing the setup and syncing your first config!


Popular links delete

Create delete mechanism for 'edit' page

Added a 'Delete draft' link to the sidebar.
Added a confirmation page for deleting the draft.
Added Delete and Cancel buttons on the confirmation page.
Ensured that a Published edition cannot be deleted, either from the GUI or from entering the URL.
Delete from database hooked up to the final Delete button.

Trello
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
Follow these steps if you are doing a Rails upgrade.

My first PR! Happy for any feedback at this point.


Php 5.5

any way to get this running on 5.5. Or suggestions on what else to use?
Thanks!
Kim

I just added PHP 5.5 support https://github.com/Bukashk0zzz/LiipImagineSerializationBundle/releases/tag/v1.0.5
Waiting for one more star on this project)


Create ~Malay.txt for Malay translation

Malay language is from Malaysia country

Malay language is from Malaysia country


[Trait] Add simple-rollout trait

Description of your changes

Add Simple-rollout trait;
Currently, support workloads:

ContainerizedWorkload
Deployment

PS: Waiting for oam-kubernetes-runtime#35
How has this code been tested?

Test and REAMD.md remain to complete.
Checklist

I have:

[x] Title of the PR starts with OAM type (e.g. [Workload] or [Trait] or [Scope]).

[ ] Updated/Added any relevant [documentation] and [examples].
[ ] Unit/E2E Tests added.

Merging, we can finish it after this PR merged https://github.com/crossplane/oam-kubernetes-runtime/pull/35


Installing RIO to an existing cluster isn't working as expected

I wanted to add rancher rio to an existing productive k8s cluster which has already linkerd, cert-manager installed. I want to use rio with linkerd/cert-manager but don't actually want rio to install those.
After installing rancher rio with rio install --disable-features "linkerd, rdns, letsencrypt"

I noticed that there was a RDNS on-rio.io  domain assigned even that in config RDNS is false.
Starting the rio dashboard from the cli didn't work. (stuck in Waiting for dashboard service to be ready) The pod was up and running but there was no access to it (http/https)
I was able to create a service and bind it to my custom domain, like explained in the tutorial however I wasn't able to create a cert for that domain with the stock cert-manager.

I am experiencing the same issue, I had to create wildcard certs by hand, and copy to rio-system namespace, In 0.7 version everything was working as expected.
I am using this clusterDomain.yaml
apiVersion: admin.rio.cattle.io/v1 kind: ClusterDomain metadata:   name: service.metacore.io spec:   secretName: service-metacore-tls   httpPort: 80   httpsPort: 443


Update @zeit/ncc to v0.20.4

Minor changes
This PR focused on update of @zeit/ncc

patches

Treat uglify-es like uglify-js
Fix TypeScript builtin without workaround
Update to<EMAIL_ADDRESS>Update to<EMAIL_ADDRESS>

@MAPESO Seems like the integration tests are failing again similar to #2490.

Closing this for now. Please re-open when tests are working.


Sequence operations on objects that we will std::move

Review: @HowardHinnant

There is no "we" in commit message... lol

Done.


BT Classic GAP bond list corrupt or invalid after removing bond (IDFGH-3432)

Environment

Module or chip used:  ESP32-WROOM-32
IDF version: v4.0.1 Release
Build System: CMake
Compiler version SysGcc 8.2.0
Operating System:    Windows
(Windows only) environment type: IDE below for build process
IDE: VisualStudio and VisualGDB
Power Supply:  external 3.3V

Problem Description
After a device bond has been removed the bond list is ether corrupt or invalid. This is most evident within 1 second of a disconnect.
Expected Behavior
Bond to be removed and API to access bond list
Actual Behavior
Either the bond list is not updated despite esp_bt_gap_remove_bond_device() returning error free or the bond count returned by esp_bt_gap_get_bond_device_num() is updated and the last pairing provided by esp_bt_gap_get_bond_device_list() is zero'd
Steps to reproduce

Pair multiple devices using BT Classic legacy PIN SPP communication
Connect to a device then disconnect (data doesn't have to be transferred and this step isn't always necessary)
Remove one of the bonds with esp_bt_gap_remove_bond_device()
Read back the bond list using esp_bt_gap_get_bond_device_num() and esp_bt_gap_get_bond_device_list()

Debug Logs
The ESP has been wiritten with an emulation of the iWRAP 3 interface.

Debug log from the bond not being removed:
I (40261) SPP_CB: event 27
I (40261) SPP_CB: ESP_SPP_CLOSE_EVT
SET CONTROL AUTOCALL
I (40371) Autocall: Stopping Autocall
I (40372) CL_GAP_CB: event 1
AT
OK
SET BT PAIR 00:07:80:FF:D9:CF
I (40518) BT Pairing: Pair Removed OK : 00 07 80 ff d9 cf
I (40518) BT Pairing:  2 devices paired
AT
OK
SET CONTROL AUTOCALL 7101 1500 RFCOMM
I (40593) Autocall: Module has 2 pairings
I (40593) Autocall: Module has 2 pairings
I (40593) Paired device mac: 00 07 80 ff d9 cf
I (40596) Paired device mac: 9c b6 d0 c6 bc aa
I (40601) Autocall: Try link to a previous connection
I (40607) Autocall: Start looking for previous paired BDA to connect to
I (40615) Autocall: calling : 00 07 80 ff d9 cf
I (40624) CL_GAP_CB: event 1
AT
OK
W (41011) BT_APPL: bta_jv_rfc_port_to_cb(port_handle:0x3):jv handle:0x0 not FOUND
W (41011) BT_RFCOMM: port_rfc_closed RFCOMM connection in state 3 closed: Closed (res: 19)
I (41079) SPP_CB: event 8
I (42115) Autocall: calling : 9c b6 d0 c6 bc aa
I (42136) CL_GAP_CB: event 1
I (42833) SPP_CB: event 8
I (43615) Autocall: calling : 00 07 80 ff d9 cf
I (43618) CL_GAP_CB: event 1

Debug log from the Zero'd case:
I (144098) SPP_CB: event 27
I (144098) SPP_CB: ESP_SPP_CLOSE_EVT
W (144994) BT_APPL: bta_jv_rfc_port_to_cb(port_handle:0x3):jv handle:0x0 not FOUND
W (144994) BT_RFCOMM: port_rfc_closed RFCOMM connection in state 3 closed: Closed (res: 19)
SET CONTROL AUTOCALL
I (145679) Autocall: Stopping Autocall
I (145680) CL_GAP_CB: event 1
AT
OK
SET BT PAIR 00:07:80:FF:D9:CF
I (147327) BT Pairing: Pair Removed OK : 00 07 80 ff d9 cf
I (147327) BT Pairing:  2 devices paired
E (147330) BT_APPL: bta_gattc_mark_bg_conn unable to find the bg connection mask for: 00:07:80:ff:d9:cf
AT
OK
SET CONTROL AUTOCALL 7101 1500 RFCOMM
I (147400) Autocall: Module has 1 pairings
I (147401) Autocall: Module has 1 pairings
I (147401) Paired device mac: 00 00 00 00 00 00
I (147404) Autocall: Try link to a previous connection
I (147410) Autocall: Start looking for previous paired BDA to connect to
I (147418) Autocall: calling : 00 00 00 00 00 00
I (147429) CL_GAP_CB: event 1

@JHedgesBartec Thanks for reporting, we will look into.

I have confirmed the failure to remove bond behaviour through two different ways. Attached are two C files which are based upon the SPP Acceptor demo.
Included in Source.zip are two different files, case_1.c is where all bonds are removed on boot of the module, case_2.c is where a bond is removed as soon as the SPP connection is closed.
Note both cases are when more than one bond is present at the time of removing them.
Source.zip

Hi @JHedgesBartec
We have optimized SPP disconnection procedure inside via an MR.
Please wait for sometime and pull the lastest master, if this issue still exist, we will look into it as soon as possible.
Thanks
Weitianhua


Using TextButton instead of FlatButton

This pull request solves the issue #185

Hey @MayurSMahajan, Thanks for your fixes.

Happy to Help!


Remove infinite scroll, or change the way scroll position is handled

Platform
This feature request concerns: (select all that apply)

[x] Client
[ ] Server

Details
Please describe the requested feature in as much detail as possible:
Whenever you click on a link in a list of maps, it takes you to the details page for that map. When you then go back to the list, it returns you to the top of the list instead of your scroll position.
No matter if you are viewing the "Latest" list, looking at a particular users' uploads, or looking at search results, as soon as you click on a link you have completely lost your scroll position and have to scroll back to it if you want to pick up where you left off.
There are no download buttons when you are viewing a list, so you have to view the details to download a map, or read the description.
Middle click also does not open the link in a new window, so there is no way to get around this.
Preferred Solution
Pagination seems like the best solution here. You can simply return to the previous page you were looking at, similar to how BeatSaver used to work.
Also, being able to middle click and open a window in a new tab is always helpful.

Middle click was added by #9

+1 for removing:

it's bad UX, there should always be an option to disable it
you're not changing the hashes, there's no way to share the link to current page (unless you open dev console and copy XHR link)
website footer is inaccessible
separate extensions exist for those who like infinite scroll everywhere

@n3tman why would you want a permalink to an arbitrary point in a constantly changing list?

@lolPants
Some lists aren't constantly changing (e.g. sorted by Downloads/Plays, or maybe Oldest - would be great to have it).
Also even though links to Latest maps are changing, they are valid for a certain period of time, so still can be shared.
Another problem is you're making a drastic change to user experience which is generally a bad idea (I'm creating a separate issue for this).

Yes please remove infinite scroll, or make a way to jump to a particular entry.

The rest of infinite scroll handling is being tracked on #24


Chat: Support custom attachments for participants

Right now, in Insiders, the currently-opened editor is included as an attachment in chat requests. The user can easily disable it by clicking.
Certain participants (thinking about @azure particularly) would benefit from being able to default-attach their own items in this list. For example, for @azure, attaching azure.yaml by default (if present) would help with a multitude of user questions. We can attach it automatically today, but we cannot make it show up in the attachments list and allow the user to detach it easily for queries where it is unhelpful.

Implementation-wise, perhaps if, after typing @azure, a method can be called to resolve additional attachments?
/cc @isidorn

This sounds reasonable to me. What do you think @roblourens

That's something that I don't like about the current implicit context, it doesn't really capture all the implicit context. Not sure whether I want to try to spell everything out or just rely on participants to report references but I'll keep thinking about it.
Do you currently return a reference for the files you use?

Right now we're only using attached files, we're not auto-attaching anything. Auto-attaching felt like it introduced wrong answers but with no way to detach the file causing the wrong answers. For example, when we auto-attached azure.yaml, and asked what ports the app listens on, it would try (and fail) to find the answer in azure.yaml. Instead, we wanted it to query our workspace context plugin (which essentially just calls the copilot_codebase lmTool underneath)

Any updates on this?

You might be able to make some progress on

it would try (and fail) to find the answer in azure.yaml

with some creative prompt crafting rather than relying on the user managing it. I know that we went that direction for the open file, but just telling the LLM something like "this piece of context might be relevant to the user's query, if not, try doing xyz" can help a lot sometimes. Or you might consider using tool calling to let it decide whether it needs that context or other context.
I'd still consider this, I think we are developing some precedent with the "file suggestions" in the edits view. But some API with a new feature like this wouldn't happen quickly.