add a CircleCI badge to the README

Codecov Report

Merging #1386 into master will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1386      +/-   ##
==========================================
+ Coverage   89.98%   90.15%   +0.17%
==========================================
  Files         120      120
  Lines        8381     8485     +104
==========================================
+ Hits         7541     7649     +108
+ Misses        550      546       -4
  Partials      290      290

Impacted Files
Coverage Δ

send_stream.go
97.65% <0%> (+0.48%)
:arrow_up:

stream.go
94.74% <0%> (+1.63%)
:arrow_up:

receive_stream.go
99% <0%> (+3%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba0bf6b...f1b49c2. Read the comment docs.


Support for E-521

As E-521 seems to be the curve with the biggest keysize of the safecurves it would be nice to have this included in openssl, to have a curve with large keysize, that's not a NIST one (which are possibly not safe according to safecurves)

Ed448-Goldilocks is the one that got standardized from that list, and which is now supported. You would need to publish a standard before we can use it.

As safecurves has parameters, I assume that there are parameters. Safecurves cites that: https://eprint.iacr.org/2013/647

I think you misunderstand my comment. If you want to use this for a key exchange, we need at least an assigned number to indicate it's that curve, but it's really more involved than that. If you want to use it in a certificate, we need a format and oid how to do this. It all seems unlikely to happen since E-521 was one of the candidates when the CFRG decided to recommend curve 25519 and curve 448. I suggest you go for curve 448.

Well, I'm not an expert on this topic so I think you will know more than I


metoffice sensor component exception

Home Assistant release with the issue:
0.102.3 (I know this is not the latest, but I'm using the rpi docker version and this is the latest I've been able to get)
Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):
Docker running on Raspbian
Integration:
 metoffice sensor
Description of problem:
The Home Assistant log is reporting:
1:15 AM components/metoffice/sensor.py (ERROR) - message first occurred at 12:05 AM and shows up 1507 times.

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
- platform: metoffice
  api_key: !secret metoffice_api_key
  monitored_conditions:
    - weather
    - temperature
    - feels_like_temperature
    - wind_speed
    - wind_direction
    - wind_gust
    - visibility
    - visibility_distance
    - uv
    - precipitation
    - humidity

Traceback (if applicable):
2019-12-21 01:15:14 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 275, in async_update_ha_state
    self._async_write_ha_state()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 317, in _async_write_ha_state
    attr.update(self.device_state_attributes or {})
  File "/usr/src/homeassistant/homeassistant/components/metoffice/sensor.py", line 172, in device_state_attributes
    attr[ATTR_LAST_UPDATE] = self.data.data.date
AttributeError: 'bool' object has no attribute 'date'

Additional information:
I'm a newbie to Home Assistant, but have 30+ years programming experience.
The metoffice website (https://www.metoffice.gov.uk/services/data/datapoint/uk-observations-detailed-documentation#UK observations capabilities feed) talks about the
dataDate: This describes the date and time at which the observation was run, expressed according to the ISO 8601 combined date and time convention

I'm only speculating, but I was wondering if the dataDate has been mistranslated as data.date in the Python?
I couldn't follow the code well enough to track this backwards - sorry.  Also, this is the first time I've been using docker, so I don't know how to get inside the contain to tweak the code and add some tracing - sorry again.

In case it helps, I pulled a recent observation from the metoffice website, and it returned the following JSON
{"SiteRep":{"Wx":{"Param":[{"name":"G","units":"mph","$":"Wind Gust"},{"name":"T","units":"C","$":"Temperature"},{"name":"V","units":"m","$":"Visibility"},{"name":"D","units":"compass","$":"Wind Direction"},{"name":"S","units":"mph","$":"Wind Speed"},{"name":"W","units":"","$":"Weather Type"},{"name":"P","units":"hpa","$":"Pressure"},{"name":"Pt","units":"Pa\/s","$":"Pressure Tendency"},{"name":"Dp","units":"C","$":"Dew Point"},{"name":"H","units":"%","$":"Screen Relative Humidity"}]},"DV":{"dataDate":"2019-12-21T10:00:00Z","type":"Obs"}}}

@steverpalmer I am sorry but I cannot duplicate this issue. All sensors are created successfully and they display the correct state. Furthermore, I do not have any errors in my home-assistant.log file that correlate to this integration.

@springstan Thanks for trying to reproduce.  Fortunately or Unfortunately (depending on your perspective), the same problem has repeated on my system starting at 12:31AM and repeating 759 times.  This probably rules out some glitch at the MetOffice end of the link. I've now found out how to connect Emacs to a running docker instance, so I can try and dig deeper to get more information on the fault.

This issue with the datapoint may be a factor ...
https://github.com/EJEP/datapoint-python/issues/19 "Error experienced when requesting data at midnight". The comment by Nigel Rook states "It appears for ~30-40 minutes after midnight, forecast.days[0] is dated for the previous day. This causes forecast.now() to return False, and possibly other issues."  This would match my error 'bool' object has no attribute 'date'.
If I'm reading github correctly, the code was fixed in release 0.50, but the HA MetOffice component manifest requires 0.4.3.  It maybe that this problem can be resolved by changing the HA manifest to require 0.50 or later version of datapoint.

If I'm reading github correctly, the code was fixed in release 0.50, but the HA MetOffice component manifest requires 0.4.3. It maybe that this problem can be resolved by changing the HA manifest to require 0.50 or later version of datapoint.

You are reading it correctly, I will test the component with 0.50 and see if any changes need to be made. Could you try to do the same to make sure that nothing breaks when we update the version?

@steverpalmer I have tested version 0.9.5 with success! Therefore opened a PR to update the version accordingly. Would really appreciate if you tested this in your setup as well to make sure that the issue has been solved with this change :)

@springstan Yesterday I patched my metoffice component sensor.py file, on the line attr[ATTR_LAST_UPDATE] = self.data.data.date with the code:
try:     attr[ATTR_LAST_UPDATE] = self.data.data.date except AttributeError as exc:     _LOGGER.error(f"Exception raised ... {self.data.data!r} ...")
and this morning I found the  the log files 2019-12-24 00:55:06 ERROR (MainThread) [homeassistant.component.metoffice.sensor] Exception raised ... False ...
The False in the error report doesn't further the theory that my problem relates to datapoint issues 19, but it is at least consistent.
This morning I've patched the container to use v0.9.5 of datapoint. I don't know that I'm guaranteed to reproduce the problem, but I will keep watch over the next week and report back.  (Oh, the joy of problems that only may occur at midnight!)

This morning I've patched the container to use v0.9.5 of datapoint. I don't know that I'm guaranteed to reproduce the problem, but I will keep watch over the next week and report back. (Oh, the joy of problems that only may occur at midnight!)

Looking forward to hear your report over the next week :)


Do not continue with fetch if we do not get a valid IID.

Fixes #4622

Since code freeze is tomorrow and RC is a dependent pod, please try to resolve the open issues and merge today.

Still seeing an Xcode 11 build warning:
- WARN  | xcodebuild:  /Users/travis/build/firebase/firebase-ios-sdk/FirebaseRemoteConfig/Sources/RCNFetch.m:250:63: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
- NOTE  | xcodebuild:  /Users/travis/build/firebase/firebase-ios-sdk/FirebaseRemoteConfig/Sources/RCNFetch.m:250:63: note: treat the string as an argument to avoid this

Hi! im coming here from https://github.com/firebase/firebase-ios-sdk/issues/4622
Wondering if you can help me out understand perhaps what was causing the crash and how did the update fix it?


fix(module:date-picker): make keyboard navigation possible

Tabbing away from date-picker overlay was not possible: It wrapped
around and usually ended up in browser's address bar. Also, once you
selected date-picker wrapper span, there was no way to open the overlay
via keyboard.
This fixes this. Tabbing away from overlay now focuses on date-picker
wrapper span. Pressing enter on the wrapper span opens the overlay.
Please also see a similar PR for the time-picker module #3145 .
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Tabbing away from date-picker overlay was not possible: It wrapped
around and usually ended up in browser's address bar. Also, once you
selected date-picker wrapper span, there was no way to open the overlay
via keyboard.
Issue Number: N/A
What is the new behavior?
This fixes this. Tabbing away from overlay now focuses on date-picker
wrapper span. Pressing enter on the wrapper span opens the overlay.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information
The behavior (both current and new) can be observed on the main demo page (npm run site:start).

Any news about this? I think this is a really great improve on UX.

@wilsoncook What about the review?

@jimmytheneutrino Thank you for your PR. The features of autofocus and keyup enter are sync to ant-design, also can resolve #3530. The TAB feature is not proper for a11y in my view, can you remove this part?

@jimmytheneutrino Thank you for your PR. The features of autofocus and keyup enter are sync to ant-design, also can resolve #3530. The TAB feature is not proper for a11y in my view, can you remove this part?

I extracted these features into a new PR #3804 (please check if it suits you).
So that the current PR remains for the TAB feature only. (I hope I can still convince you that the current TAB behaviour is very weird and unintuitive.)

As there is no update for a long time, the PR will be closed.
If you have any questions, feel free to open another PR, thanks a lot.


[feature] Set the personal access token model

This is related to: https://laravel.com/docs/5.8/passport#overriding-default-models

This is merged not sure why it's not closing.

@rennokki, was commit 9842dd66f974def24c6e8b5c47a8e9f51ba82712 required (with an updated PHPDoc return type)?
Also, that might be why this didn't get closed on merge.


Configurable debugging information refresh rate

Currently, the debugging information (like FPS) updates every second, both in debugger and game. This can make the FPS reporting less accurate.
The refresh rate of debugging information could be configurable in the project settings.

@Calinou If you're still interested in this change, I think you could have a go at implementing it, shouldn't be hard :)

Done by https://github.com/godotengine/godot/pull/18998

Note that this was reverted in https://github.com/godotengine/godot/pull/18998#issuecomment-392506052, which means this feature is still not implemented as of today.


Feature Request: Validations Rules Array

It would be awesome if model validation rules array is added to package because then we won't need to use separate package (like Ardent) just for that.
Any thoughts about this ?
Thanks

Well, I've few opinions here:

Personally I don't like the concept of validating or caching data on the model level.
For the validation process I think it's fair enough to use Laravel's default Form Requests as it filters & validate submited data before even reaching the controller itself, from the very early beginning.

Don't you agree, Or have different thoughts..?

I agree with you, having $rules array in model is especially inspired by Ruby on Rails apps, their models have validation rules as well as relationships as simple arrays which makes it easy to manage just at "one place". May be that's why Ardent is so popular. Secondly creating Form Requests, etc makes things more complex and time-consuming. Although it is different topic whether to put them in the model itself or not.
If we are to use this package, we have to go back and forth in writing repositories and also update laravel models for validations, relationships, etc, it would have been great if this was one place. I just felt the need of defining validation rules in repositry class which extends EloquentRepository something like:
protected $repositoryId = 'rinvex.repository.users';
protected $model = User::class;
protected $rules = [];

Having said that, I agree with you may be purpose of package is just focused on Repository Pattern (in which case it should also be framework-agnostic).
Thanks

To be honest, I've thought about including validation features in this package before. I just still don't have a solid opinion on that yet. On a side note, I agree that maintaining form requests adds a more complexity to the project.

May be, let's keep this issue open and see what other users have to say ?
BTW thanks for awesome package :-)

My +1 for this feature :)

Sounds great, and here's my thoughts as well, maybe someone will have vision of the ultimate validation solution 😄
Pros of including validation in this package

Repositories are being used from anywhere, controllers, console commands, and other places, so it's not limited to the Http layer, accordingly I see it more logical to have validation rules on repository layer actually
Placing validation rules in the repository layer will make thinks easier, simpler, more intuitive, and most importantly: centralized
Centralizing validation rules, means omitting duplicate validation rules existing at Http layer, and Console layer, and anywhere else. It's good for logic & data consistency

Cons of including validation in this package

I don't like the fact of re-inventing the wheel if not highly needed, and Laravel already have multiple awesome ways for validation, so I'd like to stick to the default features
I still think that validating input data before touching the controller is much better than delegating it to the repository layer at a later stage of request lifecycle
Adding such new features forces this package to have a diverged focus, adds overhead of more maintainability requirements, and most importantly leads to overloaded classes with too many aspects to take care of, and maybe violating SRP

These points IMHO weights each other, maybe someone have a better description & could convince us or reads things differently? Hopefully yes 😃 👍

@ionut-tanasa @rsdev000 @evsign As heavy users of this package, what do you think of this proposal?

Hi. I don't have a opinion about performing validation inside the repo too. I've seen validation within the model, within controller and form requests.
For medium (almost large) / large apps I prefer form request. It's centralized too. For small/medium (almost small) apps with less than half-dozen forms I would validate the data within the model.
The only con I see is giving this package too many responsabilities.
Cheers

Hmm makes sense, cons seem to over-weigh the pros and you guys have raised valid points and package should not have too many responsibilities at the cost of possible technical debts.

In a "clean" way, respecting SRP and so on, the data needs to be validated before hitting the repository layer. The repository has to be dumb. It just takes the data and shoves it into a database.
Talking from my experience I prefer to use FormRequests. But not always are enough. I still use the good old Validator class. It depends on the use case.
And I think that the rules are useless on the repository if you use another package/or laravel itself to validate. At this point we could add the entire validation process inside the repository.

Agree with @ionut-tanasa, @rsdev000  and @Omranic )
I think form requests and maybe models are the best place to perform data validation.

I'm glad we had this fruitful conversation, and the output we concluded 😄 Thanks everybody 👍
We keep this package focused on what it can do best, repositories & caching layer 😉


Angular 4 Dynamically import different independent projects in CORE SPA as modules

Bug Report or Feature Request (mark with an x)
Hi Team, I am doing one POC where in I have one CORE SPA project in Angular 4. I also have different independent angular projects which should serve as module to CORE SPA. So, let's say when my CORE SPA bootstraps in that case, I will get some metdata like URL of those hosted modules to load from and then I load like shown below.
import { Component, OnInit } from '@angular/core';

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.css']
})
export class AppComponent implements OnInit {
  ngOnInit() {
    //And, this iterates over to see the location dynamically and load the same.
    this.files.forEach(element => {
      return import (element).then((comp:any)=>{
        return comp.default;
      });
    });

  }
  title = 'app';

  //For instance, this is the files collection
  files =['./module1/main-bundle']
}

So, currently what I have done is I have copied the build output from module1 project into my CORE-SPA's dist project like shown below.

One point to note that, I am here trying to use dynamic import, hence I am using "module":"esnext" in my tsconfig.apps.json. This is just to enable dynamic import. Point is at compile time, I should not be knowing anything about this dependent module. When application runs, then only it should load my required module.
Versions. Angular 4/5
Windows (10).
Repro steps. Mentioned Below
Hi Team, I am doing one POC where in I have one CORE SPA project in Angular 4. I also have different independent angular projects which should serve as module to CORE SPA. So, let's say when my CORE SPA bootstraps in that case, I will get some metdata like URL of those hosted modules to load from and then I load like shown below.
The log given by the failure.

Desired functionality. Not sure, if it already exists, otherwise its a feature request.
Not sure, whether this feature is supported or not so far. If not, then I definitely want to have as ocLazyLoad does the same in AngularJS.
Mention any other details that might be useful.

https://github.com/rahulsahay19/CORE-SPA-Dynamic-Test

Note that this is a better question for StackOverflow, as it's neither a bug or feature request.
We don't support import statements where the module is dynamic. We have a vague plan to allow something like what you're doing, but in the meantime instead you could use import statements where the module is static, like this:
export class AppComponent implements OnInit {
  ngOnInit() {
    //And, this iterates over to see the location dynamically and load the same.
    this.files.forEach(module => {
      return module.then((comp: any)=>{
        return comp.default;
      });
    });

  }
  title = 'app';

  //For instance, this is the files collection
  files = [
    import('./module1/main-bundle'),
  ]
}

Be careful, your usage of promises is not totally safe here, but I just suppose this is a PoC and would be tightened up later.
Closing this as answered.


Guides > Generate a Complete Service Worker > Webpack link goes to 404 page because of typo in URL

This "Webpack" link right here

goes to a 404 page because its href is https://developers.google.com/web/tools/workbox/guides/generate-service-workers/webpack, whereas the correct link is https://developers.google.com/web/tools/workbox/guides/generate-service-worker/webpack - there is an extra 's' in generate-service-workers
Here's one of the affected pages: https://developers.google.com/web/tools/workbox/guides/generate-service-worker/

This will be fixed in https://github.com/google/WebFundamentals/pull/5941
Thanks for pointing it out!


step5: add frontend and tests

Note, commit https://github.com/sdzhong/codecov-demo/pull/8/commits/6ab2ad473d35ce55ec6380e3d261bc9a1d188d18 was necessary because git add . didn't include those files.

Note, https://docs.codecov.com/docs/github-4a-merging-reports steps did not say to merge the PR, but I went ahead with doing it.


Allow responses to be created based on data from the request

I'm trying to mock a sequence of jsonrpc api calls, and I'd like to be able to pass through the ids from the requests to the responses in an integration style test.  I can't find a way to do this with wiremock, am I missing something? For my lower level tests (testing individual methods/api calls) I provide a way to specify the id for the request manually, but doing so throughout all my higher level code with multiple calls would probably be a big change at this stage.

This is indeed not possible at the moment, but it is a usecase I have had in mind for a while.
I'll do some exploration API-wise and get back to you when I have something usable :)

Did you have some ideas for how to implement this? I'd be happy to look into it too, as it's something I need

Nothing formalised yet - I'll try to carve out some time to work on it this weekend :)

I merged a first draft in #33 - let me know if it matches your needs @kellpossible!

@LukeMathWalker Great, thanks a lot!  I'll make sure to have a look at this soon, I've got a personal tracking issue for it


Dynamic Depedencies spec: Update w/previous feedback, typo corrections and apicontracts

Update spec w/previous API Review feedback, typo corrections and apicontracts (added in WinAppSDK 1.1)

/azp run

Update Dynamic Dependencies spec w/previous API Review feedback, typo corrections and apicontracts (added in WinAppSDK 1.1)


IIIF scaling problem in 4.1.0 that is not present in 4.0.0

The following boiled-down reproducer displays a badly distorted image with OpenSeadragon 4.1.0, but works fine with 4.0.0. Basically the aspect ratio appears to get lost and the image gets squashed vertically, although I've also seen cases where it gets squashed horizontally.  It's easy to reproduce but I'm afraid I don't know how to debug it.  Any help appreciated.

    <title>OpenSeadragon 4.1.0 Problem with Ransom Center IIIF Images</title>

Ransom Center IIIF problem

Change 4.1.0 to 4.0.0 for distortion to go away

I've done a manual bisect that shows the problem was introduced by 0c358c140dae8bcd5cbc568ef6236a840af84efe.

Thanks for digging into it and finding that info, @craigberry. @ruven it looks like this was caused by a PR you made to fix another issue; would you be able to take a look at this as well?

I think this is linked to this issue: https://github.com/openseadragon/openseadragon/issues/2415.
If you take a look in the info.json in your example: https://hrc.contentdm.oclc.org/digital/iiif/p15878coll17/8057/info.json, you'll see that the sizes are ordered in descending rather than ascending order. The extra sort() added to resolve the previous issue (https://github.com/openseadragon/openseadragon/commit/b92a428e88730546058bf9890aa44061ca370eb5) should fix this.

Thanks.  I can confirm that the sort changes in b92a428e8873 fixed the scaling problem in my reproducer.

Fixed by https://github.com/openseadragon/openseadragon/pull/2416. @craigberry Thank you for testing it!


Add Mute Button Functionality

PR Description 📜
This pull request addresses issue #17. I have implemented the mute button functionality as per the requirements outlined in the issue. Users can now easily mute audio within the application with the click of a button, enhancing their control over their audio experience. I have followed the project's contributing guidelines and performed a self-review of the code to ensure its quality.

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x ] I have performed a self-review of my own code or work.
[ x] I have commented my code, particularly in hard-to-understand areas.
[x ] My changes generates no new warnings.
[ x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[ x] I have added screenshot for review.

Thank you soo much for contributing to our repository 💗

there are 2 conflicts in the index.html and style.css, please review them once more
use the PR template properly with the tick marks.

@ayush-t02 Conflict has been solved

good work, what about the tick marks in the PR?

Done

@ayush-t02 you didn't assign any level label.


efivar: 35 -> 36

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/efivar/versions.
These checks were done:

built on NixOS
/nix/store/9id78fkv7cf4bd6rwv06a0pz2dnr5ip3-efivar-36-bin/bin/efivar passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 36 with grep in /nix/store/9id78fkv7cf4bd6rwv06a0pz2dnr5ip3-efivar-36-bin
directory tree listing: https://gist.github.com/f6b2229b6bfb146aa1c4be22eae3162b
du listing: https://gist.github.com/e6239ef936ac1f133d5f4ccc6bc653f4

meta.description for efivar is: '"Tools and library to manipulate EFI variables"'.
Experimental: this build is cached with Cachix. To use the cache follow these experimental instructions:
One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 7083c8fb46e1d46c0895a2333bcf5ae5dc41e4e3 && nix-shell --pure -I nixpkgs=. -p efivar

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: efivar
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: efivar
Partial log (click to expand)
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h1lyfw1w8jy466jqsmigi8yi9sn11gky-efivar-36-dev/lib
patching script interpreter paths in /nix/store/h1lyfw1w8jy466jqsmigi8yi9sn11gky-efivar-36-dev
checking for references to /build in /nix/store/h1lyfw1w8jy466jqsmigi8yi9sn11gky-efivar-36-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/0wbn9gv7vbl4ipq7011jahz4snwsxm6k-efivar-36-man
gzipping man pages under /nix/store/0wbn9gv7vbl4ipq7011jahz4snwsxm6k-efivar-36-man/share/man/
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/0wbn9gv7vbl4ipq7011jahz4snwsxm6k-efivar-36-man
checking for references to /build in /nix/store/0wbn9gv7vbl4ipq7011jahz4snwsxm6k-efivar-36-man...
/nix/store/9id78fkv7cf4bd6rwv06a0pz2dnr5ip3-efivar-36-bin

Success on aarch64-linux (full log)
Attempted: efivar
Partial log (click to expand)
strip is /nix/store/min150lkigznaayzpwvf8d4jdl1dqvx6-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gpcbnqb4nfd6bfrnll6a4yq27k9vzpnj-efivar-36-dev/lib
patching script interpreter paths in /nix/store/gpcbnqb4nfd6bfrnll6a4yq27k9vzpnj-efivar-36-dev
checking for references to /build in /nix/store/gpcbnqb4nfd6bfrnll6a4yq27k9vzpnj-efivar-36-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/csvwf6i2gimsm53gjqcd2v59g9y9yf3j-efivar-36-man
gzipping man pages under /nix/store/csvwf6i2gimsm53gjqcd2v59g9y9yf3j-efivar-36-man/share/man/
strip is /nix/store/min150lkigznaayzpwvf8d4jdl1dqvx6-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/csvwf6i2gimsm53gjqcd2v59g9y9yf3j-efivar-36-man
checking for references to /build in /nix/store/csvwf6i2gimsm53gjqcd2v59g9y9yf3j-efivar-36-man...
/nix/store/zjlqkarp3dxsiqf63n91l7lapkrgkbj7-efivar-36-bin


onExpand index starts from 1

Hello,
Thank you for your plugin, it works great within angular-material.
The content if my accordion uses a ng-repeat and I use the index to retrieve the selected element.  I had to understand that the index starts from 1 instead of 0. It could be mentioned in the documentation, or it could start from 0 :-)
 $scope.expandCallback = function(index) {
     var selectedDataset = $scope.datasets[index-1];
     ...
};

My bad, the problem was from mixing a ng-repeat v-pane and a static v-pane.


Added avro schema example

@munir131 Can you please also update the Readme and include instructions on where the schema example is and how to run it? Thanks.

@deltasquare4 I updated doc. Let me know if you have any other feedback/suggestions.


Screenshot managers opens with media keys if no keybind is set

I'm currently playing the TMP Limitless 6 Pack for Forge 1.19.2.
When I use the media keys on my keyboard, the screenshot manager opens, event tho no keybinds are set to open the screenshot manager. When I set a keybind the screenshot manager does not open with the media keys.
I'm using the Logitech G815. This could also be a bug in the Logitech G HUB software.

Hello, thank you for opening an issue.
Regarding this one it probably comes from the Logitech G HUB software as you implied or something else. By default, the screenshot manager keybinding is mapped as every undefined keybinding to an "Unknown Keybinding" with code -1.
When you're using media keys, GLFW (library that interprets inputs) probably doesn't recognize the key you pressed and just assumes you pressed a key with code -1, leading to the screenshot manager opening. However, I don't know why exactly the screenshot manager opens and not something else (as multiple controls are assigned to an "Unknown Keybinding", especially on modpacks).
I'm closing this issue, I'll try to fix it for the next Minecraft versions, and I might also try for Minecraft on Forge 1.19x.


Critical vulnerabilities in 3.3.3

There are a number of critical CVEs in v3.3.3 of this image which prevents us from being able to use it. The vulnerabilities are:
ALAS2-2022-1759: CVE-2022-25315:In Expat (aka libexpat) before 2.4.5, there is an integer overflow in storeRawNames
ALAS2-2022-1736: CVE-2021-33574:The mq_notify function in the GNU C Library (aka glibc) versions 2.32 and 2.33 has a use-after-free.
ALAS2-2022-1754: CVE-2022-23852:Expat (aka libexpat) before 2.4.4 has a signed integer overflow in XML_GetBuffer, for configurations with a nonzero XML_CONTEXT_BYTES
ALAS2-2021-1724: CVE-2021-22945:When sending data to an MQTT server, libcurl <= 7.73.0 and 7.78.0 could in some circumstances erroneously keep a pointer to an already freed memory area and both use that again in a subsequent call to send data and also free it again.
CVE-2021-22946:A user can tell curl >= 7.20.0 and <= 7.78.0 to require a successful upgrade to TLS when speaking to an IMAP, POP3 or FTP server
CVE-2021-22947:When curl >= 7.20.0 and <= 7.78.0 connects to an IMAP or POP3 server to retrieve data using STARTTLS to upgrade to TLS security, the server can respond and send back multiple responses at once that curl caches.
Is it possible to have these vulnerabilities remediated and an updated image produced.

Hi @dgr237,
These vulnerabilities all lie in the amazonlinux base image that the daemon image uses, so they should not impact the daemon itself. We will re-release the daemon to dockerhub with the latest base image version to mitigate these CVEs regardless, and update this issue when it is done.
In the meantime, I recommend to use the Public ECR daemon image: https://gallery.ecr.aws/xray/aws-xray-daemon
It does not have a base image, so it will not have these vulnerabilities.

Thanks for letting me know I will try to get the ecr image onboarded to our in house repo.

Hi @dgr237,
The Daemon should now be republished to Dockerhub with the latest AL2 image, let us know if these vulnerabilities are resolved.


unable to access Microsoft Graph Assignment API

I am having issues accessing Assignment under Education using Microsoft Graphs API giving access denied even though we have gave all the required permissions. noticed that Under Application permission it requires one of the these permissions

. But under API Permission >  Application Permission  we actually have (EduAssignments.ReadBasic.All, EduAssignments.ReadWriteBasic.All, EduAssignments.Read.All, EduAssignments.ReadWrite.All)

. I am not sure whether this the issue here. Please advise . Thanks
AB#9183

Hello @hemanthseshasai is this when you try to access using Graph Explorer or another application? Please confirm whether in the case of another application, that it uses Application permissions and not delegated permissions.
This is a link that describes the differences: https://docs.microsoft.com/en-us/graph/api/user-list-messages?view=graph-rest-1.0&tabs=http

hello @thewahome  i am trying to use these api in a different application. i have given all the required permissions under application permissions it still says Access denied.

Hello @hemanthseshasai is this when you try to access using Graph Explorer or another application? Please confirm whether in the case of another application, that it uses Application permissions and not delegated permissions.
This is a link that describes the differences: https://docs.microsoft.com/en-us/graph/api/user-list-messages?view=graph-rest-1.0&tabs=http

Documentation states following permissions required; EduAssignments.ReadBasic, EduAssignments.ReadWriteBasic, EduAssignments.Read, EduAssignments.ReadWrite
But Azure Application - API Permissions under Application Consent, only provides permissions which ends with .All
EduAssignments.ReadBasic.All, EduAssignments.ReadWriteBasic.All, EduAssignments.Read.All, EduAssignments.ReadWrite.All
So there is some sort of discrepancy, but not sure who to contact or talk to to resolve.

Hey @hemanthseshasai. From Azure portal, it seems the permissions were updated.

Are you still experiencing this issue?

Hey @hemanthseshasai. Can you confirm that your application is using application permissions and not delegated permissions?
From Azure portal, the application permissions are the ones ending with the .All suffix. Delegated permissions on the other hand do not have this suffix.
For context, when an application is using application permissions, it does not require you to sign in to access resources in your tenant. (The app has to be registered in your tenant and you need to ensure that the application id you are using on application is the same one on Azure portal).


Licensing

When I following the download instructions in install.sh what gets downloaded is nothing like the files I see here, and it does not have an MIT License.

the install.sh is just used in vercel, not use for install local, when in local, just flutter pub get  and then flutter run , MIT License I saw there exists,please confirm.


std::promise use

Change Description

Get future before promise use to avoid race on set_value & get_future

Change Type
Select ONE

[ ] Documentation

[x] Stability bug fix

[ ] Other

[ ] Other - special case

Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

https://cplusplus.github.io/LWG/issue2412

https://cplusplus.github.io/LWG/issue2412

Thanks for finding that. I was going off of stack overflow and looking at the implementation. It sure looked like a data race to me.


a combination of both voice and chat

@gunthercox is it possible to having both voice and response in a Django chatterbot? If so could you provide an example scenario here?

I think it's definitely possible, but because it's a web app the audio will have to be processed on the client's side. This might make things easier because there is likely several javascript libraries available that handle speech recognition and speech synthesis. It looks like Google Chrome has built in support for both speech recognition and speech synthesis: https://developers.google.com/web/updates/2014/01/Web-apps-that-talk-Introduction-to-the-Speech-Synthesis-API

Hi @vkosuri, I'm going to close this ticket off. I believe your question was answered, feel free to reopen the ticket if I missed something or you still have questions.

@gunthercox thank you


Bug: docker webserver does not work

Describe the bug
build in webserver does not work for me from the docker image:
direct connection with ip: ERR_CONNECTION_REFUSED)
with via cloudflare and ssl I get a 502 bad gateway
Steps to reproduce
pull image
setup enviorment variables
setup mount for /data
publishing port 8098 on random port for now and placed it behind a reverse proxy (caddy 2)
command is set to init
after first run I changed to command to server
while it was running a ran archivebox manage changesuperuser and restarted the container
Screenshots or log output
No error in the logs:
[i] [2020-07-30 20:03:02] ArchiveBox v0.4.9: archivebox server
,    > /data
,[i] The admin username is: <snip>
,[+] Starting ArchiveBox webserver...
,Performing system checks...
,System check identified no issues (0 silenced).
,July 30, 2020 - 20:03:03
,Django version 3.0.8, using settings 'core.settings'
,Starting development server at http://<IP_ADDRESS>:8000/
,Quit the server with CONTROL-C.

Software versions

OS: Linux server 20.04 LTS
ArchiveBox version: while using the docker image (v0.4.9)
Python version: docker image reports 3.8.5
Chrome version: command not found in docker image

ooh can you share your caddy config? I'd love to add that to the docs.
I think the issue is here Starting development server at http://<IP_ADDRESS>:8000/
I'm not sure why it's starting on <IP_ADDRESS> by default, but that needs to be <IP_ADDRESS> inside docker.
You can fix it by running:
docker run -v $PWD:/data archivebox server <IP_ADDRESS>:8000

Where did you see this? Chrome version: command not found in docker image

forcing the ip seems to work, I'm now able to access the server 🥳
the command not found was when I tried to follow the instructions in the bug report template:

but using your archivebox version command works and it told me I got v84.0.4147.105
caddy2 itself is a magic box, my current config for archivebox and seems to work fine: ```
archive.example.com {
reverse_proxy :
}

I'm using portainer as interface and that might have screwed over the settings (?), but other then that it works


[aom] Build error

Package: aom[core]:x64-windows-static -> 3.5.0#1
Host Environment

Host: x64-windows
Compiler: MSVC 19.0.24215.1
vcpkg-tool version: 2023-04-07-bedcba5172f5e4b91caac660ab7afe92c27a9895
vcpkg-scripts version: 78b61582c 2023-08-04 (5 days ago)

To Reproduce
vcpkg install libvpx:x64-windows-static libyuv:x64-windows-static opus:x64-windows-static aom:x64-windows-static
Failure logs
-- Fetching https://aomedia.googlesource.com/aom 9a83c6a5a55c176adbce740e47d3512edfc9ae71...
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: "C:/Program Files/Git/cmd/git.exe" fetch https://aomedia.googlesource.com/aom 9a83c6a5a55c176adbce740e47d3512edfc9ae71 --depth 1 -n
    Working Directory: D:/runoob-greeting/rustdesk/vcpkg/downloads/git-tmp
    Error code: 128
    See logs for more information:
      D:\runoob-greeting\rustdesk\vcpkg\buildtrees\aom\git-fetch-x64-windows-static-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_from_git.cmake:86 (vcpkg_execute_required_process)
  ports/aom/portfile.cmake:11 (vcpkg_from_git)
  scripts/ports.cmake:147 (include)

D:\runoob-greeting\rustdesk\vcpkg\buildtrees\aom\git-fetch-x64-windows-static-err.log
fatal: unable to access 'https://aomedia.googlesource.com/aom/': Failed to connect to aomedia.googlesource.com port 443: Timed out

Additional context

duplicate of https://github.com/microsoft/vcpkg/issues/33061


Support large (>4G) DCC transfers.

I'm not really familiar with the DCC protocol. You're sure that this will work with real irc clients (irssi, etc.) ? I'm just wondering how the client will know how to unpack the data.

Good point, I checked Irssi's source code, and in contrast to the stuff I'm interfacing with locally, it does seem to comply with the referenced specification.

Feel free to provide a PR to make this configurable if you want/need it. Just let the default respect the specs.


Feature Request: Support attaching to remote targets (VM's etc)

Since I'm a linux user but need to debug edge from time to time it would be awesome to have my edge running inside a VM (e.g. virtualbox) and attach from my host (linux) into the edge browser.

Great idea. Hereby added to the backlog.

Hey guys.
Is it still in the backlog? I have no idea how difficult it is but always ready to contribute :)
Thanks.


[Feature/Identity] Basic permissions REST api

Description
This PR introduces three REST APIs for permission adding, checking, and deleting. These APIs are contained as part of the Identity library. These APIs are not yet connected to the permission object in anyway. This is just a framework for sending instructions with REST.
There are basic unit tests for parsing the requests but integration tests will need to be added to actually test everything once the code is connected to other Permission logic.
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] New functionality includes testing.

[ ] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-project/security can I get your thoughts on this? Thank you.

@scrawfor99 Could you please link to an issue describing the design of the API? What does a request look like and what are some different scenarios with responses?

Please change how these files are organized by the action as seen by the user eg. AddPermission* where the transport*/rest*/action/request/response etc, are all next to one another.

Will do.

@scrawfor99 Could you please link to an issue describing the design of the API? What does a request look like and what are some different scenarios with responses?

Sure, here you go

Closing in favor of #6119 and then an additional PR.


docs: Update trg-8-03.md

Description
This PR introduces TruffleHog as a new open source tool for secret scanning to be used alongside native Github Secret scanning. This is being enforced as a replacement to the existing GitGuardian (commercial) tool.
Example workflow:

https://github.com/eclipse-tractusx/bpdm/blob/main/.github/workflows/trufflehog.yml
https://github.com/eclipse-tractusx/demand-capacity-mgmt/blob/main/.github/workflows/trufflehog.yml

Please note: The TRG checks continues for 24.08 under GitGuardian for secret scanning.
The teams who have already implemented TruffleHog, can also be considered for the TRG checks.
NOTE: Please do not merge this PR until the August release

Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

NOTE: Please do not merge this PR until the August release

@RoKrish14 you could have placed it as a draft then

@eclipse-tractusx/automotive-tractusx-committers please review

@RoKrish14 are you still integrating review comments?

@RoKrish14 Are you still working on this issue? I think we have a consensus on how we want to proceed here. Please get back by the end of next week, otherwise we would create a new PR for this topics. Thank you!

@evegufy and @danielmiehle : Apologies for the delay as I was on vacation.
Making the necessary changes right away :)


refactor(cli): refactor to esm

Replaces #397
From my testing this is the best solution for table autogeneration, and should be neutral for current use-cases.
Latest main should be merged into v2 before this PR (network's createFaucetService is duplicated in both)
There're no significant logic changes here, but I remove some seemingly deprecated commands to do less refactoring (deploy, diamond-abi, sync-art).
Added reuseComponents to deploy-contracts since it was only in deploy.
I've started going from no bundler+ts-node-esm+moduleResolution nodenext (which doesn't work well yet) to eventually tsup with some inlining+node+moduleResolution node. The changes that make the 1st more extreme version work could be removed, but they are a strict improvement and could simplify things in the future.
Notably:

.js suffixes for files
services changes
tsc --moduleResolution nodenext
execLog refactor was just me testing stuff, but it should be a strict improvement worth keeping

@holic create-mud was working without @latticexyz/utils seemingly because it was cli's dependency, even though cli didn't (and couldn't) use it. And since it's std-client's peerDep it's best to add it anyways.
@authcall importSuffix=.js helps with future compatibility with es module resolution. (It'd be even better if ts-proto and protobufjs would replace long with bigint entirely https://github.com/protobufjs/protobuf.js/pull/1557).

(or maybe sync-art could be a standalone script outside the mud cli)

Yeah this would be my preference, since sync-art feels very Phaser specific (if not Sky Strife specific)

@alvrs rebased; test some commands again just to make sure it still works.
There were quite a lot of conflicts, some rather indirect. I think to avoid dealing with those often it'd be best to avoid cli changes in main. Or merge v2 into main, if we're ok with a few breaking cli changes and a bunch of unfinished packages there.

(or maybe sync-art could be a standalone script outside the mud cli)

Yeah this would be my preference, since sync-art feels very Phaser specific (if not Sky Strife specific)

It makes sense to put that script into sky strife repo. It's small, self-contained and very project-specific. Leaving sync-art removed for now, unless you disagree

There were quite a lot of conflicts, some rather indirect. I think to avoid dealing with those often it'd be best to avoid cli changes in main. Or merge v2 into main, if we're ok with a few breaking cli changes and a bunch of unfinished packages there.

Yes, I think that makes sense, I'm all for merging v2 into main as soon as possible.

It makes sense to put that script into sky strife repo. It's small, self-contained and very project-specific. Leaving sync-art removed for now, unless you disagree

Agreed

The gas-report cli is failing because the gasreport script in store still refers to cli/dist/index.js instead of cli/dist/mud.js - we could probably change that now to use the released @latticexyz/cli gas-report command

The gas-report cli is failing because the gasreport script in store still refers to cli/dist/index.js instead of cli/dist/mud.js - we could probably change that now to use the released @latticexyz/cli gas-report command

Right, missed that one


How to stop blinking placeholder?

How to stop blinking placeholder?

Set CaretState.

I can't see anything useful there

I'm trying to get a blinking caret and a non-blinking placeholder.

I think a partial revert of https://github.com/verybadcat/CSharpMath/pull/167 is needed.

PR here: https://github.com/verybadcat/CSharpMath/pull/176

You can make the appearance of the placholder's 2 states equal via Atom.LaTeXSettings by customizing the so called "active" and "passive" placeholder nuclues. (Assuming you use the default color black, you don't need to do anything with the color.)

Resolved by https://github.com/verybadcat/CSharpMath/pull/177


我马上整合到进来

这个接口现在好像不可以用了

@polandeme 接口正常, 只是貌似上面的ssid和sid不可用了


Database is not cleaning up after missing 3 heartbeats

I am not sure if we want to clean the database upon every hydra initiation. Since the database is persistent, the hydra picks up whatever was previously there.
Please correct this if not so: @susmit85 @GportDev

@GportDev Could you please provide a sequence to steps to reproduce the issue? Thanks.

If we did not listen from the node in 3 heartbeat then we should clean the database of this particular node

I've verified that the node expiration is indeed executed, and the node is marked as expired in the database, the heartbeats seem like they are working properly.
@susmit85 @GportDev

When the nodes do not hear from another node for 3 heartbeats, it marks that node expired. Expired nodes are not currently deleted from the database.


Kernel updates for 2024-09-18

Description of changes
https://cdn.kernel.org/pub/linux/kernel/v6.x/ChangeLog-6.10.11
Can't really test because all of my stuff is on 6.11 now.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg test simple

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/no-more-sound-on-laptop-after-upgrade-tuxedo-infinitybook-pro-16-gen7/52296/12


[CI]

Current Behavior

Desired Behavior

Implementation

Acceptance Tests

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@daibaq0 please stop creating empty issues. This will be the 10th or 11th that I will have closed from you.


Use --env=super by default for Linuxbrew

Codecov Report

Merging #319 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   70.59%   70.58%   -0.01%
==========================================
  Files         341      341
  Lines       17698    17693       -5
==========================================
- Hits        12494    12489       -5
  Misses       5204     5204

Impacted Files
Coverage Δ

extend/io.rb
71.42% <0%> (-28.58%)
:arrow_down:

build_environment.rb
96.96% <0%> (-0.18%)
:arrow_down:

formula_installer.rb
60.59% <0%> (+0.1%)
:arrow_up:

extend/ENV.rb
95% <0%> (+4.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aac4b5...ca39505. Read the comment docs.

Codecov Report

Merging #319 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   70.57%   70.57%   +<.01%
==========================================
  Files         341      341
  Lines       17705    17700       -5
==========================================
- Hits        12495    12492       -3
+ Misses       5210     5208       -2

Impacted Files
Coverage Δ

build_environment.rb
96.96% <0%> (-0.18%)
:arrow_down:

formula_installer.rb
60.59% <0%> (+0.1%)
:arrow_up:

extend/ENV.rb
95% <0%> (+4.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 609d5e7...59c9ddb. Read the comment docs.


How to understand the function cavity_distribution_tied in file basemodels.py ?

Just as the title said, how can I understand cavity_distribution_tied in file basemodels.py? Is there any reference I should follow up? And I note that this code is similar to equation (64) in the BayesNewton paper. How does it come from?

This is the cavity distribution for Stochastic PEP, where all the sites are assumed equal, and therefore all the cavities are equal too (so you only have to compute and store it once rather than for every data point). This is mentioned in the paper in the last paragraph of Section 8.2 (before 8.2.1).


validate env based on clowder config

Description
change gpg set based on clowder env
FIXES:  THEEDGE-3051
Type of change
What is it?

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I run make pre-commit to check fmt/vet/lint/test-no-fdo

@mgold1234 you can check the ticket related

@omaciel i'm looking into the params on image creation/update to identify the reason of not being always true.

Codecov Report
Patch coverage: 66.66% and project coverage change: +0.03 :tada:

Comparison is base (566c7a4) 57.29% compared to head (9ca76cc) 57.32%.

:exclamation: Current head 9ca76cc differs from pull request most recent head 408e5ff. Consider uploading reports for the commit 408e5ff to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1917      +/-   ##
==========================================
+ Coverage   57.29%   57.32%   +0.03%
==========================================
  Files          70       70
  Lines        9962     9967       +5
==========================================
+ Hits         5708     5714       +6
+ Misses       3740     3739       -1
  Partials      514      514

Impacted Files
Coverage Δ

config/config.go
59.35% <25.00%> (-0.44%)
:arrow_down:

pkg/services/updates.go
69.39% <100.00%> (+0.13%)
:arrow_up:

pkg/services/devices.go
51.11% <0.00%> (+0.31%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add ScalingGizmo

Description
Implemented a scaling gizmo with the following behaviours:

Dragging the axis handles scales the object in the direction of the corresponding axis.
Dragging the centred cube scales the object uniformly in all directions.

Please refer to the code comments for a detailed explanation.
Test plan
To test the scaling gizmo, use the src/tests/gfx-gizmos-scaling.edn file.

There's some gaps between the capped handles and the center cube hitbox

Could you make them connect (at least the ones on the side), the one facing the camera can have a gap & be smaller (use the existing angleFactor)

@guusw
Thank you for your suggestions! I have addressed the following requested changes in the latest commit b5f857ea.

Modified the variable names to follow the camelCase convention.
Moved the code related to the centred cube outside of the loops. The loops now solely focus on the axis handles.
Utilised float3's index operators to reduce code duplication.

Note: This branch uses the original implementations of Handle in TranslationGizmo and the ScalingGizmo. The location of the raycasting code and how handles are used have been refactored in the RotationGizmo branch. Should merge this branch into the RotationGizmo one, resolve the merge conflicts there then merge into devel.


[C++][Parquet] Reading corrupted encrypted Parquet files can cause a segfault

Describe the bug, including details regarding any error messages, version, and platform.
We experienced a segfault reading an encrypted Parquet file and traced this down to EVP_DecryptUpdate being called here with a negative value for the last parameter, which is the ciphertext length.
By debugging the problem I found that the length was being read from the file as zero, which became negative after subtracting length_buffer_length_, kNonceLength and kGcmTagLength.
This file was written with PyArrow but we suspect it may have become corrupted somehow. I would expect that this should result in a catchable exception rather than a segfault though.
Component(s)
C++, Parquet

Wow, this is horrid. Thanks for noticing this @adamreeve .

Issue resolved by pull request 43071
https://github.com/apache/arrow/pull/43071


feat(option): Negative prompt

Reference: https://www.github.com/ggerganov/llama.cpp/pull/2135

Implement as any number of prompts with different weights.
Different prompts associated with different chat prefixes.
Different context lengths, so the tokens can be steered more effectively.
Different histories, potentially making room for private "inner monologue".

I have to think carefully about this one. It seems very tricky to balance multiple contexts.

We could call this an agent. The general outline could be as follows (but needs some work):
(rolling_prompt (())
 (file "rolling.txt")
 (loop (())
  (turn (prefix "{{user}}: ") (user_input +true))
  (turn
   (prefix "least_unhinged_twitch_chatter:")
   (guidance (agent polite_speech) (scale -1.0)))
 )
)
(agents (())
 (polite_speech
  (priming_prompt (())
   (text "You are a kind person named least_unhinged_twitch_chatter who uses speech compatible with a polite society.\n")
   (main_rolling_prompt)  ; Do we need the whole thing?
 ))
)

The sampling customization in https://github.com/rendezqueue/rendezllama/issues/36 may affect this, so it's blocked on the same thing.


CARDS-1715: As a user landing on the PROMs login page, I can choose whether I wish to authenticate as a Patient or a Healthcare Provider

This PR implements CARDS-1715 by providing the <PromsLandingPage> component and attaching it to the loginPageStart UI ExtensionPoint. Therefore, when CARDS is first accessed, a landing page is presented asking the user if they are a Patient or a Healthcare Provider. If the user selects Patient, they are directed to /Proms. If the user selects Healthcare Provider, they are shown the standard Cards4Proms login page.
To test:

Build this CARDS-1715 branch with mvn clean install.
Start CARDS in Cards4Proms mode with ./start_cards.sh -P cards4proms --dev.
Visit http://localhost:8080.
You should be shown a screen asking if you are a Patient or a Healthcare Provider.
Clicking I am a Patient should redirect the browser to /Proms. At this point it is expected to see an Invalid access message as CARDS-1716 has not yet been implemented.
Back at the landing page (http://localhost:8080/), clicking I am a Healthcare Provider should reveal the normal DATA PRO login page.

tested - works as expected

I have some minor cosmetic suggestions:

change "I AM A" to "I am a"
or have "I am a", then PATIENT below, and below it HEATHCARSEPROVIDER button

Made some UI adjustments, @sashaandjic please retest.
There remains the issue that the default login page flashes on the screen briefly before the proms landing page is displayed, but I guess that can be solved in the next iteration.

Is this behaviour expected? Clicking on the Back button behaves differently for patients
https://user-images.githubusercontent.com/23243244/164247160-469c1d78-9789-4e05-abfa-b7d5db0861de.mp4
Do we need our own BACK button in case the wrong one was clicked on?
.

I also noticed that in test mode I no longer get the proper logo. Here is the screenshot of an instance running in lfs and test mode:

Is this behaviour expected? Clicking on the Back button behaves differently for patients:

Fixed the behavior of the back button on the HCP login page, ready for retest @sashaandjic .

The latest push is for rebasing only, no visible changes. @sdumitriu I recommend squash and merge, I made too many tiny changes in this PR.


replace httpclient with httpx

in order to fix random connection timeouts with threads, see https://github.com/nahi/httpclient/issues/232

sorry didn't mean to open a PR here (yet)


Captura.Console ProcessExit

When I run console app like "captura start" and then just close console window the output video file is broken.
It would be nice to stop video recording when user terminate process, like this:
AppDomain.CurrentDomain.ProcessExit +=
    new EventHandler(CurrentDomain_ProcessExit);

ProcessExit is triggered only when App exits normally.
Console.CancelKeyPress can be used for Ctrl + C.
I'm not sure what can be used for the Console Window closing.

See solution here

I think you mean to say that using CreateNoWindow solved your problem. Is it?


scrollers

Browser scrollers are active on an empty board, i'd call that a visual bug (osx firefox and safari).

I'm using OS X with Safari/Chrome/Firefox and I don't see any scrollbar, can you make a screenshot?

sure:
http://shrani.si/f/1B/fS/1tR6Xto6/1/kanboard.png

I have same issues but with IE only. I can't collapse swimlines and scroll-bar are shown even if not needed. But everything works on Firefox or Chrome.

This issue is now fixed in the development version.
Thanks.


Use systemd cgroup manager for e2e tests

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Systemd is the recommended cgroup manager. This should fix the fedora 34 issues with the OCI seccomp BPF hook.
Which issue(s) this PR fixes:

Refers to https://github.com/kubernetes-sigs/security-profiles-operator/pull/431
Does this PR have test?
None

Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

None

Codecov Report

Merging #438 (5652f5e) into master (7584d39) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #438   +/-   ##
=======================================
  Coverage   38.78%   38.78%
=======================================
  Files          22       22
  Lines         985      985
=======================================
  Hits          382      382
  Misses        588      588
  Partials       15       15

/lgtm
Nice!


update README, add keys / configs to fix issues for other devs on Mac

This is all brand new to me, so please review and let me know if these changes are ok.

@leesalminen @bityogi - not sure if you want to merge this , change it, or close it. let me know.

These changes are not specific to our project but upstream as well IMO. If that is the case, I would suggest making this PR against the upstream repo and then we can bring it to our repo from there.


Capture build scans on ge.apache.org to benefit from deep build insights

Description
This change will generate and publish Gradle Build Scans to https://ge.apache.org for increased ability to troubleshoot build failures. The changes in this PR do not affect the outcome of the build, but rather produce deeper insights into what is happening in the build itself.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[x] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[x] Create/update unit or integration tests for verifying the changes made.

[x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

[x] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Yes, still interested in this PR 🙂.
I missed that there were spotless issues with the formatting. Those should be fixed now.

Hi, is anything else needed from me on this PR?


Engine fuel items - add/remove

I'm using Eureka with other mods and I have fuel items that I can make that are equivalent to coal.
Is there a place in the configs I can edit what counts as fuel? I've been looking and can't find it.

Every Fuel value should work.
// We check if something is fuel like this:
net.minecraft.world.level.block.entity.BaseContainerBlockEntity.AbstractFurnaceBlockEntity.isFuel(ItemStack)

// We get the fuel value like this:
net.minecraft.world.level.block.entity.FurnaceBlockEntity.getFuel()[ItemStack]

Unsure how I can check/edit those values but, for example, Ars Nouveau Fire Essence can smelt 20 items in a furnace and does not work on the engine

what version are you using?

1.3.0 beta 4

Seconded, biofuel pellets from Create Crafts and Addons do not work, despite working in a vanilla furnace and the aircraft from Immersive Aircraft. Which is unfortunate, because biofuel pellets are an excellent fuel source otherwise.
Minecraft Version: 1.19.2
Eureka Version: 1.5.1 Beta 2
Forge Version: 43.3.5

Just looking into it on the surface, the implementation for Immersive Aircraft checks whether the item being placed into the fuel slot is burnable, instead of checking whether it is fuel:
public boolean mayPlace(ItemStack stack) {
    return Utils.getFuelTime(stack) > 0;
}

Link
public static int getFuelTime(ItemStack fuel) {
    if (fuel.isEmpty()) {
        return 0;
    }

    // Custom fuel
    Map<String, Integer> fuelList = Config.getInstance().fuelList;
    String identifier = BuiltInRegistries.ITEM.getKey(fuel.getItem()).toString();
    if (fuelList.containsKey(identifier)) {
        return fuelList.get(identifier);
    }

    // Vanilla fuel
    if (Config.getInstance().acceptVanillaFuel) {
        int fuelTime = CobaltFuelRegistry.INSTANCE.get(fuel);
        if (fuelTime > 0) {
            return fuelTime;
        }
    }

    return 0;
}

Link


The "bin" folder doesn't exists, neither terraria.exe and when running fast_start, the process stops after this:

Hello, I only made an account here to post my problem, which I noticed many of us are having:

I literally pinned this website to my markers, so I can check very often if someone answers, I've heard the issue has something to do with the "net" program but I'm not sure at all (I have 0 idea about coding).
Please I need help fixing this, 100% aware for possible answers and I can provide any further information if needed.

This project is abandoned and does not work.


Impossible to differentiate between resources / courses / categories locally at the minute

Could be solved by querying Moodle location until a math to the current file is found. When a match is found we can check the location and path of match to differentiate


fix: update documentation to use correct package naming convention fo…

This commit updates the documentation to ensure the correct package naming convention for drf_simple_apikey is used. The previous documentation was misleading because it used drf-simple-apikey instead of drf_simple_apikey. It is a simple mistake but caused me some trouble ahhaha. This change addresses the issue by correcting the package docs.

This PR addresses this issue #76


Functions wrapped with functools.lru_cache are missing full prototypes and doc-strings

First of all, I am not sure that this is an issue in vscode-python and not in some other part of VSCode but I don't know how to understand which component is responsible - please point me in the right direction.
Consider this example
def is_even(x: int) -> bool:
    '''Returns True if x is even, False otherwise'''
    return x % 2 == 0

print(is_even(2))

Pointing to is_even(2) call shows a tooltip with function prototype and documentation

Now we add lru_cache
import functools

@functools.cache
def is_even(x: int) -> bool:
    '''Returns True if x is even, False otherwise'''
    return x % 2 == 0

print(is_even(2))

and it still shows that is_even is a function but prototype changes to _lru_cache_wrapper[bool] and doc-string is gone

Python 3.12 help() output is
Help on function is_even in module __main__:

is_even(x: int) -> bool
    Returns True if x is even, False otherwise

without lru_cache and
Help on _lru_cache_wrapper in module __main__:

is_even(x: int) -> bool
    Returns True if x is even, False otherwise

with it.
So, while it is helpful to see that the function is wrapped in lru_cache, it would also be nice to see proper argument list and documentation.

See this issue for information about why pyright (the static type analysis engine upon which pylance is based) behaves as it does in this case. It's due to the way that functools.cache and functools.lru_cache are defined in the typeshed stubs. A change in behavior here would require a modification to the typeshed stubs. There are some tradeoffs for this change, however. Because of this, the maintainers of typeshed have been reluctant to accept a change. If you have an opinion on the matter, I recommend posting in the typeshed thread.


Adding Database Freedom and .NET CDK-based infra-as-code for AWS

Adds Database Freedom via multiple DB engine support(MySQL, Postgres, SQL Server) and .NET CDK-based infra-as-code for AWS.
Note: Containerization lab markdown is unchanged and is out of sync with updated sample code. Containerization lab guide content will need to be updated to bring it in sync.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The decision is to postpone this until a few more changes to the Secret Management lab markdown are done.


[FR] Duplicate part modal: clear IPN field if PART_ALLOW_DUPLICATE_IPN = False

Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find a similar feature request

Problem statement
When PART_ALLOW_DUPLICATE_IPN = False option is set for the server, the Duplicate Part modal form should open with an empty IPN field instead of copying the original over.
Suggested solution
Check for PART_ALLOW_DUPLICATE_IPN = False when generating the form data.
This should only need an additional API call to /api/settings/global/PART_ALLOW_DUPLICATE_IPN/ in /InvenTree/templates/js/translated/part.js to get the configuration value and issue a fields.ipn = '' if needed, right?
Describe alternatives you've considered

Examples of other systems
No response
Do you want to develop this?

[X] I want to develop this.

@simonkuehling sounds fine. There is the array global_settings in settings.js with all settings values,

Yep all the settings are already loaded statically into a javascript file as @matmair says :)

sweet, a quick fix is in via PR https://github.com/inventree/InvenTree/pull/4365


D.L4 Maze Solver with Stack

Long-Term Plan:

Complete this week's work
Week of 3/10:

Atul: Issue #820


feat(home-manager): init fzf module

Adds support for fzf.
I took the same approach that the console module uses and used the palette to manually add the colors from catppuccin/fzf.

this needs a rebase

Rebased


Memory usage of Dataset

We have to build and load the dataset in memory every time, which seems to occupy a lot of memory if data is really huge. Is there any way of improving this?

No, for now tablib is not intended to large datasets.
I agree it is an issue. I'd like to support it for a subset of tablib API, mostly format conversions.
#207 is somewhat related to this issue.

With the respect for tablib, the streaming feature is pending. For now, I would suggest giving it a go with pyexcel. Here is the tutorial on streaming data and the information on the choice of plugins.


Cannot install without git

Despite the changelog saying that the dependencies had moved to npm packages instead of git, I'm unable to install this package without git on my build server. We use svn at my place of business, and do not typically have git installed on build servers.
We're including this via "grunt-jsdoc": "~0.5.7", and it doesn't look like 0.5.8 has any change to this issue from the changelog. npm install fails with:
error	23-Mar-2015 08:53:59	npm ERR! git clone https://github.com/dominictarr/crypto-browserify.git undefined
error	23-Mar-2015 08:53:59	npm ERR! git clone https://github.com/dominictarr/crypto-browserify.git undefined
error	23-Mar-2015 08:53:59	npm ERR! git clone https://github.com/hegemonic/taffydb.git undefined
error	23-Mar-2015 08:53:59	npm ERR! git clone https://github.com/hegemonic/taffydb.git undefined
error	23-Mar-2015 08:54:08	npm ERR! Linux 2.6.32-220.23.1.el6.x86_64
error	23-Mar-2015 08:54:08	npm ERR! argv "node" "/usr/bin/npm" "install"
error	23-Mar-2015 08:54:08	npm ERR! node v0.10.33
error	23-Mar-2015 08:54:08	npm ERR! npm  v2.7.0
error	23-Mar-2015 08:54:08	npm ERR! code ENOGIT
error	23-Mar-2015 08:54:08
error	23-Mar-2015 08:54:08	npm ERR! not found: git
error	23-Mar-2015 08:54:08	npm ERR!
error	23-Mar-2015 08:54:08	npm ERR! Failed using git.
error	23-Mar-2015 08:54:08	npm ERR! This is most likely not a problem with npm itself.
error	23-Mar-2015 08:54:08	npm ERR! Please check if you have git installed and in your PATH.

Nevermind, it's not this repo that's causing it, but jsdoc itself

Reopening because the version number is pegged at 3.2.X, while the version of jsdoc that fixes this issue for me is 3.3. If you could change your ~ to a >, I could explicitly require jsdoc >3.3 and therefore fix this issue.

Hi, this is intentional.
You can use the plugin in beta version if you want jsdoc 3.3.x. :
npm install grunt-jsdoc@beta
3.2.x is their current stable.


Allow null props for Grapher

This will accept non existing to be also null:
<Grapher
  minGridX={null}
  ...
/>

This is the same as omitting the minGridX props.
There is already a fallback for null/undefined/non-existing props.

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

src/grapher.js, line 26 at r1 (raw file):

const getGraphSetting = function(grapherProps: GrapherProps): GraphSettingsT {
  const minGridX = fromMaybe(defaultMinGridX, grapherProps.minGridX)

I thought we wanted to distinguish between null and undefined here?
Both of these mean "use the default"
<Grapher
  ...
/>

<Grapher
  minGridX={undefined}
/>

This means "Do not set minGridX at all"
<Grapher
  minGridX={null}
  ...
/>

Do we not want the latter interpretation? Is the latter interpretation ever valid for any of these?

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

src/grapher.js, line 26 at r1 (raw file):
Previously, cdparks (Chris Parks) wrote…
> I thought we wanted to distinguish between `null` and `undefined` here?
>
> Both of these mean "use the default"
> ```jsx
>    ...
> />
>
>    minGridX={undefined}
> />
> ```
>
> This means "Do not set `minGridX` at all"
>
> ```jsx
>    minGridX={null}
>   ...
> />
> ```
>
> Do we not want the latter interpretation? Is the latter interpretation ever valid for any of these?
>

There is no distinction between the 2. `null` or `undefined` should fallback in the same default value. For this lib we don't have an infinite grid for now, it will always have border (`minGrid`, `maxGrid`).

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

src/grapher.js, line 26 at r1 (raw file):
Previously, joris974 (Joris Buchou) wrote…
> There is no distinction between the 2. `null` or `undefined` should fallback in the same default value. For this lib we don't have an infinite grid for now, it will always have border (`minGrid`, `maxGrid`).

Ok

Comments from Reviewable


Don't let people connect to {file}

OK. I figured out how I got into such a bad state (#47). Here's my thought process that led me to the bad state.

Server -> Add Server... "Hmmm... It's not really a server. But I think I know what qstudio means."
Sever Ty... "Hmmm... I don't know what a 'KDB' is, but look! There's SQLite. I'll choose that."
Connect By:  "I dunno...

"It's not a host on the network: it's just a SQLite file. So I won't click Host"
"I guess it must be a URL. But that seems like it would have to be on the network as well. Well, the default is usually safe.
jdbc:sqlite:{file} "I don't know what that means, either. I'll leave it alone"

Name: "I guess I need to type the name of the file to open"
"I'll just leave all the rest empty/as-is"
Blammo! qstudio creates the blank {file} file, and life stinks.

To refresh my memory of how this looks on my Mac, I posted a video. It's at: https://youtu.be/sw9nZXIRzZo
Suggestions:

SQLite databases are odd: they wrap everything into a single file. If I select "SQLite", maybe qstudio could display a file picker for the "Connect By" section?
If someone leaves the choice as jdbc:sqlite:{file}, it would be good to give an error, saying to enter a file name not "{file}"

Hi Rich,
THanks for reporting these and the video, is really helps.. I've reworked the "File->Open" mene and toolbar option.
Now if you either:

Double-Click a file in windows.
Drag a drop a file onto qStudio
Go File-Open

It will

Check for .duckdb/parquet/db/sqlite file extension and open it as a database.
Otherwise open it as a text editor.

I'm not confident of safely making your other suggested changes, The file picker or {file} check right now as given the 30+ database possibilities it's very hard to add logic in that area for 1-2 databases without breaking some of the others. I would like to first see if "File->Open" works for most users. Any remaining users that go to add server will hopefully be small in number and for very advanced cases.

Example: https://youtu.be/tAqVW67PWRk

Cool! Let me know when I can play with the updated version

Excellent! It looks as if you have implemented drag and drop in 3.05. Two observations:

Dragging a ".sqlite" file to the Server Tree opened/connected to the SQLite as desired.
Dragging that file to the Documents pane seemed to open the database as a text file. (I saw "SQLite" in the first line).

Perhaps you could special case ".sqlite" and always treat it as a SQLite database, no matter where it was dragged into the qStudio window? (That interpretation would also work well if the file were dragged to the qStudio icon in the dock...) Thanks as always

Hmmm... I dragged the .sqlite file to the top half of the "Server Tree" pane, but nothing happened. I dragged the file to the bottom half, and the database opened as expected.
I'll push my luck, and ask that a drop of a database file (such as ".sqlite") anywhere in the qStudio window be treated as a request to connect to that database file.
I will quickly admit that I have no idea how other DBMS systems handle their files, so I can't give any further guidance to you. Thanks again.


Inconsistent failure due to javax.net.ssl.SSLException

The download task generally works great for me, but I occasionally get a failure that looks like this:
* What went wrong:
Execution failed for task ':downloadSwiftCompiler'.
> javax.net.ssl.SSLException: java.lang.RuntimeException: Unexpected error: java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty

I've looked into this a bit but am a bit stuck because most sources point to a legitimate configuration issue but I only see this issue every now and again, it's not consistent. One other useful data point is that I have two download tasks that run in parallel, could they negatively interact with each other some how?

One other useful data point is that I have two download tasks that run in parallel, could they negatively interact with each other some how?

Well, everything is possible, but the classes in gradle-download-task don't have static fields or anything else that could potentially cause problems in a multi-threaded scenario.
This is going to be very hard to debug. Are you able to provide a reproducer (a small example demonstrating the problem)?

Sorry, I haven't been able to create a reliable repro. I did notice a similar problem in Gradle recently and it looks like a fix was put up here:
https://github.com/gradle/gradle/pull/6721
Maybe we could try to obtain the SSLContext here similarly? I'm not very familiar with how this all works though.


Filter World Names

I have heard people talking about world names with offensive text in it.
I was wondering if we can have something where we can enter in world names that we don't want to have show up.
(Might also be good for streaming to hide things like AD worlds)

The problem with this is that it's not going to be very reliable, because world names (session names) can be changed very easily. It could also end up hiding sessions that you don't want it to. For AD sessions specifically those usually are hosted by a certain user which you can filter out by their user ID or session ID if they use a custom one.
I have thought about allowing specific worlds to be hidden by their world ID but this would require the world to be published or be publicly accessible as a world orb.


Fix translations for tooltips in simple list and monaco

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

/retest


Operation: Convert to NATO alphabet

Add an operation to convert text to the phonetic NATO alphabet.

@n1474335, should I resolve the conflicts?

Good contribution, thanks. I made some changes to improve performance and scalability. Take a look here: https://github.com/gchq/CyberChef/commit/022ef71d2c586b9e2bb78b97422cd0c233515bb7
It would now be quite easy to add other phonetic alphabets to this operation.


Exclude node_modules using tsconfig.json

Hi,
I'm trying to configure codelyzer so that I can run tslint over all the source files in my project, but obviously excluding node_modules.
I configured my script in package.json like this
"lint": "tslint --type-check --project tsconfig.json"

So if I understand tslint should use tsconfig.json to check which files should lint.
When I run npm run lint I get an error in my app.component.ts, which is fine, but I also get a few errors from files within node_modules, something like this
Error: Error encountered resolving symbol values statically. Calling function 'ɵmakeDecorator', function calls are not supported. Consider replacing the function or lambda with a reference to an exported function
    at simplify (/Users/david/Documents/work/my-angular-seed/node_modules/@angular/compiler/bundles/compiler.umd.js:21818:58)
    at simplifyCall (/Users/david/Documents/work/my-angular-seed/node_modules/@angular/compiler/bundles/compiler.umd.js:21624:28)
    at simplify (/Users/david/Documents/work/my-angular-seed/node_modules/@angular/compiler/bundles/compiler.umd.js:21806:52)
    at simplifyInContext (/Users/david/Documents/work/my-angular-seed/node_modules/@angular/compiler/bundles/compiler.umd.js:21831:28)
    at simplify (/Users/david/Documents/work/my-angular-seed/node_modules/@angular/compiler/bundles/compiler.umd.js:21667:40)
    at simplifyInContext (/Users/david/Documents/work/my-angular-seed/node_modules/@angular/compiler/bundles/compiler.umd.js:21831:28)
    at simplify (/Users/david/Documents/work/my-angular-seed/node_modules/@angular/compiler/bundles/compiler.umd.js:21789:52)
    at simplify (/Users/david/Documents/work/my-angular-seed/node_modules/@angular/compiler/bundles/compiler.umd.js:21649:60)
    at simplifyInContext (/Users/david/Documents/work/my-angular-seed/node_modules/@angular/compiler/bundles/compiler.umd.js:21831:28)
    at recordedSimplifyInContext (/Users/david/Documents/work/my-angular-seed/node_modules/@angular/compiler/bundles/compiler.umd.js:21844:28<EMAIL_ADDRESS>
My tsconfig.json looks like this
{
  "compilerOptions": {
    "target": "es5",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "noEmitHelpers": false,
    "pretty": true,
    "sourceMap": true,
    "lib": ["es5", "dom"],
    "strictNullChecks": false
  },
  "include": [
    "src/**/*"
  ],
  "exclude": [
    "node_modules"
  ],
  "awesomeTypescriptLoaderOptions": {
    "useWebpackText": true,
    "forkChecker": true,
    "useCache": true
  },
  "compileOnSave": false,
  "buildOnSave": false
}

and my tslint.json is the standard version as in the npm site
Does anyone know what I'm doing wrong?
Thanks

Hey @davidanaya! You must be using<EMAIL_ADDRESS>If so, the problem comes from the deep metadata collection which is performed by ngast. This is required in order to be able to parse component templates in the appropriate context.
Usually the problem occurs when the basePath and genDir properties are not presented in tsconfig.json. Once<EMAIL_ADDRESS>is released, most such issues should have be already fixed. By then, you can use<EMAIL_ADDRESS>I'll close this issue since it's related to ngast, not codelyzer.

I have had the same problem. I could solve it with removing the.
"exclude": [
    "node_modules"
  ],

from the config. But no idea why this helps...

Just to clarify. I was having the same issue and the exclude should be on your angular-cli.json, inside {lint: []}
https://github.com/angular/angular-cli/issues/4350#issuecomment-277501678

The only working solution for me was to add files against all linting files
.angular-cli.json
"lint": [{
      "files": "src/**/*.ts",
      "project": "src/tsconfig.app.json"
    },
    {
      "files": "src/**/*.ts",
      "project": "src/tsconfig.spec.json"
    },
    {
      "files": "src/**/*.ts",
      "project": "e2e/tsconfig.e2e.json"
    }
  ]


aria-describedby with angular material with custom error messages

I'm submitting a ... (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[x] support request
Current behavior
I use material fields and custom error messages.
I want to use the attribute aria-describedby but it doesn't seem to work.
Please tell us about your environment:
Angular 7, Material
You can see a reproduction example here : https://stackblitz.com/edit/angular-ztgoco
Thanks

use attributes:
templateOptions: {
  attributes: {
    'labelledby': 'label-mail'
  }
},

the problem is not for labelledby but for describedby.
It does not work nether with attributes

the problem is not for labelledby but for describedby

Thanks. But it does not work with the atribute aria-describedby

Well there is no way to set a custom describedby for material input: https://github.com/angular/components/blob/master/src/material/input/input.ts#L83
it all controlled by MatFormFieldControl.


[docs] Fix useMediaQuery ssr implementation example

Hello! 👋
A colleague (@marlonbs) and me we've been struggling our heads a few days on the useMediaQuery SSR implementation for a Next.js project that we're building on.
After reading css-mediaquery docs and examples we figured it out that our SSR useMediaQuery implementation was not working because the px string was not included into the match. 🙈
I'm making a PR to update the docs just in case it could help anyone ❤
Related issues: #15187 and #16132
Demo
When you use breakpoint helpers with useMediaQuery
import { useTheme } from '@material-ui/core/styles';
import useMediaQuery from '@material-ui/core/useMediaQuery';

function MyComponent() {
  const theme = useTheme();
  const matches = useMediaQuery(theme.breakpoints.up('sm'));

  return <span>{`theme.breakpoints.up('sm') matches: ${matches}`}</span>;
}

This statement theme.breakpoints.down('xs') returns something like this:
'(max-width:767.95px)'

Then the css-mediaquery won't match the value if the px string is not present:

[x] I have followed (at least) the PR section of the contributing guide.

That must've been a frustrating debugging session. The fix is much appreciated!


added type hint for phpdoc in get and set method  fixes 985

Added type hint in set method and replaced the type hint in the get
method with the type hint short notation. Fixes #985

Mhm local tests are green. Looks like a general problem with the CI Tool?

yeah, after the PR from travis everything broke although the PR showed that everything is green.

@marcj since the CI tool is fixed again could you restart the ci test or do I have to add another commit?


about resnet12-pth

I'm a student from Nanjing University. I'm trying to reproduce your paper. Can you send me the pre-training parameters of resnet12 used in training?
^_^

Hi, thanks for being interested in this work. I am sorry that I currently, don't have the pretrained model at hands. However, the pretrained resnet-12 can be easily obtained by using the pretrained code from FEAT.

Could you tell us the accuracy of INSTA-ProtoNet model and ResNet12 backbone without pre-train parameters?


[CWS] Allow k8s-e2e-cws tests to fail

What does this PR do?
These tests can sometimes be flaky.
As we are currently in the process of removing these in favor of #25218, let's allow these to fail so that these do not impact the main branch.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


unbound host override update fails when fields are not changing

First thanks for this ! pfsense need this for ages.
I'm using this inside ansible to keep internal dns overrides up to date for a bunch of hosts. I added logic to determine if it's an update or a new override (personally I would have loved to simply set the override and let the backend decide if it's new or update) but I still get failures when there are no actual updates.
I would expect it to work even if nothing changes. I run it like this:
      - name: update unbound override for {{ inventory_hostname }}
        uri:
          url: "https://<IP_ADDRESS>/api/v1/services/unbound/host_override"
          method: PUT
          body:
            client-id: "{{ client_id }}"
            client-token: "{{ client_token }}"
            id: "{{ item_index }}"
            domain: example.com
            ip: "{{ base_vlan_net_ifaces[0].ip }}"
          body_format: json

Unless there's a change in the domain name it fails. Funily enough PUTing only the ip works even if there are no changes...
fatal: [localhost]: FAILED! => changed=false
  connection: close
  content_type: application/json
  date: Fri, 30 Oct 2020 15:35:36 GMT
  elapsed: 0
  json:
    code: 400
    data: []
    message: Unbound host override already exists
    return: 2010
    status: bad request
  msg: 'Status code was 400 and not [200]: HTTP Error 400: Bad Request'
  redirected: false
  referer: no-referrer
  server: nginx
  status: 400
  transfer_encoding: chunked
  url: https://<IP_ADDRESS>/api/v1/services/unbound/host_override

Edit: please ignore the now removed comment, I was calling the api with a missing parameter.

Also apparently updating an existing entry when the only change is a new alias is not possible.
Trying with only the id and the alias in the payload fails with:
Unbound host override alias hostname required
If I add the hostname to the payload I get:
Unbound host override already exists
and the aliases are not added.

Hey there,
Thanks for opening this issue. To briefly explain the error you're receiving: the hostname and domain fields must be unique together, meaning no other host override can have the same hostname and domain. When you make a PUT request and have specified either of these fields in your payload, this triggers the unique constraint check to ensure that the updated hostname and domain name do not already exist in another host override entry. Other fields such as the ip field do not have this constraint which explains why you do not encounter this issue when updating the IP only.
That being said, this does demonstrate the need for the unique constraint to accept non-unique values when the hostname and domain specified in your payload match the existing hostname and domain in the host override entry you are updating. I will work on a fix for this and roll it into the next release.
Thanks again

Thank you for explaining it to me. It makes sense. Also for the fix - it will simplify my workflow a lot. Cheers!


[Event Request] - Purchase Header - OnUpdateAllLineDimOnBeforePurchLineModify

Describe the request
    procedure UpdateAllLineDim(NewParentDimSetID: Integer; OldParentDimSetID: Integer)
    var
        xPurchaseLine:Record "Purchase Line";
        ConfirmManagement: Codeunit "Confirm Management";
        NewDimSetID: Integer;
        ReceivedShippedItemLineDimChangeConfirmed: Boolean;
        IsHandled: Boolean;
        DefaultAnswer: Boolean;
    begin
        IsHandled := false;
        OnBeforeUpdateAllLineDim(Rec, NewParentDimSetID, OldParentDimSetID, IsHandled, xRec);
        if IsHandled then
            exit;

        if NewParentDimSetID = OldParentDimSetID then
            exit;
        if not GetHideValidationDialog() then begin
            DefaultAnswer := true;
            OnUpdateAllLineDimOnBeforeConfirmUpdateAllLineDim(Rec, DefaultAnswer);
            if not ConfirmManagement.GetResponseOrDefault(Text051, true) then
                exit;
        end;

        PurchLine.Reset();
        PurchLine.SetRange("Document Type", "Document Type");
        PurchLine.SetRange("Document No.", "No.");
        OnUpdateAllLineDimOnAfterPurchLineSetFilters(PurchLine);
        PurchLine.LockTable();
        if PurchLine.Find('-') then
            repeat
                xPurchaseLine := PurchaseLine; //New line
                OnUpdateAllLineDimOnBeforeGetPurchLineNewDimsetID(PurchLine, NewParentDimSetID, OldParentDimSetID);
                NewDimSetID := DimMgt.GetDeltaDimSetID(PurchLine."Dimension Set ID", NewParentDimSetID, OldParentDimSetID);
                OnUpdateAllLineDimOnAfterGetPurchLineNewDimsetID(Rec, xRec, PurchLine, NewDimSetID, NewParentDimSetID, OldParentDimSetID);
                if PurchLine."Dimension Set ID" <> NewDimSetID then begin
                    PurchLine."Dimension Set ID" := NewDimSetID;

                    if not GetHideValidationDialog() and GuiAllowed then
                        VerifyReceivedShippedItemLineDimChange(ReceivedShippedItemLineDimChangeConfirmed);

                    DimMgt.UpdateGlobalDimFromDimSetID(
                      PurchLine."Dimension Set ID", PurchLine."Shortcut Dimension 1 Code", PurchLine."Shortcut Dimension 2 Code");

                    OnUpdateAllLineDimOnBeforePurchLineModify(PurchLine,xPurchaseLine); //New variable added here
                    PurchLine.Modify();
                end;
            until PurchLine.Next() = 0;
    end;

Additional context
I need to check xPurchaseLine value in this event, could that be added?
xPurchaseLine as a variable also needs to be made.
Internal work item: AB#561114

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 28338.


Why don't we stop unix_server from listening in shutdown stage as well?

https://github.com/EOSIO/eos/blob/59626f1e6361df3b715e926ee13a9a8e84d177af/plugins/http_plugin/http_plugin.cpp#L550
add

      if(my->unix_server.is_listening())
         my->unix_server.stop_listening();

Which should also unlink the socket file.  Pull requests gratefully accepted.  Please branch from the develop branch.

We should also unlink the socket file

Already does that

https://github.com/EOSIO/eos/blob/59626f1e6361df3b715e926ee13a9a8e84d177af/plugins/http_plugin/include/eosio/http_plugin/local_endpoint.hpp#L205

oh and here too, so it looks like stop_listenting() should remove it
https://github.com/EOSIO/eos/blob/59626f1e6361df3b715e926ee13a9a8e84d177af/plugins/http_plugin/include/eosio/http_plugin/local_endpoint.hpp#L435

I think the destructor is not enough.  The shutdown stage need explicit call.

Fix merged


Fix ps release

@TravisEz13,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@daxian-dbw FYI