Some documentation files have an incorrect "Last change" value

In some files from $VIMRUNTIME/doc the "Last change" value specified in the first line is incorrect, specifically:
filetype.txt: 2020 Sep 28,
options.txt: 2021 Jan 08,
popup.txt: 2020 Nov 07,
syntax.txt: 2020 Dec 17,
version6.txt: 2020 Aug 17,
vi_diff.txt: 2020 Aug 15.
The list may be incomplete because I got it just by comparing the "doc" folders of Vim versions 8.2.2377 and 8.2.2332  (the listed files from the two versions differ, but their respective "Last change" values are the same).

I suspect this happened because of including a patch, instead of editing the file manually.
I have an autocommand that updates the date, but it only triggers on write.
You'll have to report any you think are wrong.
Alternatively, perhaps a script can detect this.

I suspect this happened because of including a patch, instead of editing the file manually.
I have an autocommand that updates the date, but it only triggers on write.
You'll have to report any you think are wrong.
Alternatively, perhaps a script can detect this.

The latest update of the runtime files has fixed some dates but not all.
Here is a patch fixing the remaining files:
diff --git a/runtime/doc/cmdline.txt b/runtime/doc/cmdline.txt
index efb1400f1..d74fc88c7 100644
--- a/runtime/doc/cmdline.txt
+++ b/runtime/doc/cmdline.txt
@@ -1,4 +1,4 @@
-*cmdline.txt*   For Vim version 8.2.  Last change: 2020 Dec 26
+*cmdline.txt*   For Vim version 8.2.  Last change: 2021 Jan 27

 		  VIM REFERENCE MANUAL    by Bram Moolenaar
diff --git a/runtime/doc/options.txt b/runtime/doc/options.txt
index 8b655dc60..e0b107813 100644
--- a/runtime/doc/options.txt
+++ b/runtime/doc/options.txt
@@ -1,4 +1,4 @@
-*options.txt*	For Vim version 8.2.  Last change: 2021 Jan 08
+*options.txt*	For Vim version 8.2.  Last change: 2021 Jan 17

 		  VIM REFERENCE MANUAL	  by Bram Moolenaar
diff --git a/runtime/doc/version6.txt b/runtime/doc/version6.txt
index 6b9f1d934..ca1800fe3 100644
--- a/runtime/doc/version6.txt
+++ b/runtime/doc/version6.txt
@@ -1,4 +1,4 @@
-*version6.txt*  For Vim version 8.2.  Last change: 2020 Aug 17
+*version6.txt*  For Vim version 8.2.  Last change: 2021 Jan 17

 		  VIM REFERENCE MANUAL    by Bram Moolenaar

I'm not sure about the new date for cmdline.txt.  Github says that 8.2.2415 is 4 days old, and on my machine $ date outputs Sun Jan 31 2021, so I wrote 2021 Jan 27.

I found the list of files which needed an update with this bash script:
#!/bin/bash

if [[ $# -eq 0 ]]; then
  cat <<EOF >&2
The purpose of this script is to find files whose contents has been changed,
but whose "Last change" date has not been correctly updated.

You need to provide the number of last commits you want the script to test.

usage: $(basename "$0") <number>
example: $(basename "$0") 123
EOF
  exit 64
fi

cd "${HOME}/Vcs/vim/" || exit

git checkout master >/dev/null 2>&1

# Let's build an array which maps help files to their "Last change" dates.
# We'll need this info later to suppress possible false warnings.
declare -A last_changes_on_master
for file in "${PWD}/runtime/doc"/*.txt; do
  last_changes_on_master+=(["$file"]="$(head -n1 "$file")")
done

# iterate over pairs  of consecutive commits starting from  "master~n" where "n"
# is a number supplied as argument to the script
for n in $(seq "$1" -1 1); do
  commit1="master~$n"
  commit2="master~$((n - 1))"

  rm /tmp/changes_commit1 /tmp/changes_commit2 2>/dev/null

  # get the list of "Last change" lines for all help files on a commit
  git checkout "$commit1" >/dev/null 2>&1
  for file in "${PWD}/runtime/doc"/*.txt; do
    head -n1 "$file" >>/tmp/changes_commit2
  done

  # same thing, but on the next commit
  git checkout "$commit2" >/dev/null 2>&1
  for file in "${PWD}/runtime/doc"/*.txt; do
    head -n1 "$file" >>/tmp/changes_commit1
  done

  # print list of files which haven't changed according to the "Last change" lines
  IFS='
  '
  for line in $(comm -1 -2 /tmp/changes_commit1 /tmp/changes_commit2); do
    if [[ "$line" =~ ^\*([^*]*)\* ]]; then
      file="${BASH_REMATCH[1]}"
      # Make sure that "$file" was not changed in commit2 (i.e. it's absent from "$ git diff").
      # But the "Last change" date of "$file" might have been changed (i.e. fixed) in a later commit.
      # Suppress a warning in such a case; that's the purpose of "&& [[ ... == ... ]]".
      if grep -Fxq runtime/doc/"$file" <(git diff --name-only "$commit1" "$commit2") \
        && [[ "$(head -n1 runtime/doc/"$file")" == "${last_changes_on_master[${PWD}/runtime/doc/${file}]}" ]] \
        ; then
        printf -- '%s was changed in %s, but its "Last change" date was not updated\n' \
          "$file" "$(git describe --tags)"
      fi
    fi
  done
  IFS=$' \t\n'
done

git checkout master >/dev/null 2>&1

It assumes that Vim has been cloned in $HOME/Vcs/vim.
I ran the script like this:
check_last_change.sh 100
^------------------^
name of the script

The 100 means that the script only looked back up to 100 commits (which took about 2 minutes on my machine).
This is what the command reports:
options.txt was changed in v8.2.2374-1-g98a29d00a, but its "Last change" date was not updated
version6.txt was changed in v8.2.2374-1-g98a29d00a, but its "Last change" date was not updated
cmdline.txt was changed in v8.2.2415, but its "Last change" date was not updated

The latest update of the runtime files has fixed some dates but not all.
Here is a patch fixing the remaining files:
diff --git a/runtime/doc/cmdline.txt b/runtime/doc/cmdline.txt
index efb1400f1..d74fc88c7 100644
--- a/runtime/doc/cmdline.txt
+++ b/runtime/doc/cmdline.txt
@@ -1,4 +1,4 @@
-*cmdline.txt*   For Vim version 8.2.  Last change: 2020 Dec 26
+*cmdline.txt*   For Vim version 8.2.  Last change: 2021 Jan 27

 		  VIM REFERENCE MANUAL    by Bram Moolenaar
diff --git a/runtime/doc/options.txt b/runtime/doc/options.txt
index 8b655dc60..e0b107813 100644
--- a/runtime/doc/options.txt
+++ b/runtime/doc/options.txt
@@ -1,4 +1,4 @@
-*options.txt*	For Vim version 8.2.  Last change: 2021 Jan 08
+*options.txt*	For Vim version 8.2.  Last change: 2021 Jan 17

 		  VIM REFERENCE MANUAL	  by Bram Moolenaar
diff --git a/runtime/doc/version6.txt b/runtime/doc/version6.txt
index 6b9f1d934..ca1800fe3 100644
--- a/runtime/doc/version6.txt
+++ b/runtime/doc/version6.txt
@@ -1,4 +1,4 @@
-*version6.txt*  For Vim version 8.2.  Last change: 2020 Aug 17
+*version6.txt*  For Vim version 8.2.  Last change: 2021 Jan 17

 		  VIM REFERENCE MANUAL    by Bram Moolenaar

I'm not sure about the new date for cmdline.txt.  Github says that 8.2.2415 is 4 days old, and on my machine $ date outputs Sun Jan 31 2021, so I wrote 2021 Jan 27.

I found the list of files which needed an update with this bash script:
#!/bin/bash

if [[ $# -eq 0 ]]; then
  cat <<EOF >&2
The purpose of this script is to find files whose contents has been changed,
but whose "Last change" date has not been correctly updated.

You need to provide the number of last commits you want the script to test.

usage: $(basename "$0") <number>
example: $(basename "$0") 123
EOF
  exit 64
fi

cd "${HOME}/Vcs/vim/" || exit

git checkout master >/dev/null 2>&1

# Let's build an array which maps help files to their "Last change" dates.
# We'll need this info later to suppress possible false warnings.
declare -A last_changes_on_master
for file in "${PWD}/runtime/doc"/*.txt; do
  last_changes_on_master+=(["$file"]="$(head -n1 "$file")")
done

# iterate over pairs  of consecutive commits starting from  "master~n" where "n"
# is a number supplied as argument to the script
for n in $(seq "$1" -1 1); do
  commit1="master~$n"
  commit2="master~$((n - 1))"

  rm /tmp/changes_commit1 /tmp/changes_commit2 2>/dev/null

  # get the list of "Last change" lines for all help files on a commit
  git checkout "$commit1" >/dev/null 2>&1
  for file in "${PWD}/runtime/doc"/*.txt; do
    head -n1 "$file" >>/tmp/changes_commit2
  done

  # same thing, but on the next commit
  git checkout "$commit2" >/dev/null 2>&1
  for file in "${PWD}/runtime/doc"/*.txt; do
    head -n1 "$file" >>/tmp/changes_commit1
  done

  # print list of files which haven't changed according to the "Last change" lines
  IFS='
  '
  for line in $(comm -1 -2 /tmp/changes_commit1 /tmp/changes_commit2); do
    if [[ "$line" =~ ^\*([^*]*)\* ]]; then
      file="${BASH_REMATCH[1]}"
      # Make sure that "$file" was not changed in commit2 (i.e. it's absent from "$ git diff").
      # But the "Last change" date of "$file" might have been changed (i.e. fixed) in a later commit.
      # Suppress a warning in such a case; that's the purpose of "&& [[ ... == ... ]]".
      if grep -Fxq runtime/doc/"$file" <(git diff --name-only "$commit1" "$commit2") \
        && [[ "$(head -n1 runtime/doc/"$file")" == "${last_changes_on_master[${PWD}/runtime/doc/${file}]}" ]] \
        ; then
        printf -- '%s was changed in %s, but its "Last change" date was not updated\n' \
          "$file" "$(git describe --tags)"
      fi
    fi
  done
  IFS=$' \t\n'
done

git checkout master >/dev/null 2>&1

It assumes that Vim has been cloned in $HOME/Vcs/vim.
I ran the script like this:
check_last_change.sh 100
^------------------^
name of the script

The 100 means that the script only looked back up to 100 commits (which took about 2 minutes on my machine).
This is what the command reports:
options.txt was changed in v8.2.2374-1-g98a29d00a, but its "Last change" date was not updated
version6.txt was changed in v8.2.2374-1-g98a29d00a, but its "Last change" date was not updated
cmdline.txt was changed in v8.2.2415, but its "Last change" date was not updated

I found the list of files which needed an update with this bash script:

A comment was wrong in the script, and there were a few other things to change.  New version:
#!/bin/bash

if [[ $# -eq 0 ]]; then
  cat <<EOF >&2
The purpose of this script is to find files whose contents has been changed,
but whose "Last change" date has not been correctly updated.

You need to provide the number of last commits you want the script to test.

usage: $(basename "$0") <number>
example: $(basename "$0") 123
EOF
  exit 64
fi

cd "${HOME}/Vcs/vim/" || exit

git checkout master >/dev/null 2>&1

# Let's build an array which maps help files to their "Last change" dates.
# We'll need this info later to suppress possible false warnings.
declare -A last_changes_on_master
for file in "${PWD}/runtime/doc"/*.txt; do
  last_changes_on_master+=(["$file"]="$(head -n1 "$file")")
done

# iterate over pairs  of consecutive commits starting from  "master~n" where "n"
# is a number supplied as argument to the script
for n in $(seq "$1" -1 1); do
  commit1="master~$n"
  commit2="master~$((n - 1))"

  rm /tmp/changes_commit1 /tmp/changes_commit2 2>/dev/null

  # get the list of "Last change" lines for all help files on a commit
  git checkout "$commit1" >/dev/null 2>&1
  for file in "${PWD}/runtime/doc"/*.txt; do
    head -n1 "$file" >>/tmp/changes_commit2
  done

  # same thing, but on the next commit
  git checkout "$commit2" >/dev/null 2>&1
  for file in "${PWD}/runtime/doc"/*.txt; do
    head -n1 "$file" >>/tmp/changes_commit1
  done

  # iterate over the list of files which haven't changed according to the "Last change" lines
  for line in $(comm -1 -2 /tmp/changes_commit1 /tmp/changes_commit2); do
    # extract filename
    if [[ "$line" =~ ^\*([^*]*)\* ]]; then
      file="${BASH_REMATCH[1]}"
      # Check  whether the  file  was  actually changed  in  commit2 (i.e.  it's
      # present in the output of "$  git diff"), contradicting the "Last change"
      # line.
      # But the  "Last change" line  might have been  changed (i.e. fixed)  in a
      # later commit.  Suppress a warning in  such a case; that's the purpose of
      # "&& [[ ... == ... ]]".
      if grep -Fxq runtime/doc/"$file" <(git diff --name-only "$commit1" "$commit2") \
        && [[ "$(head -n1 runtime/doc/"$file")" == "${last_changes_on_master[${PWD}/runtime/doc/${file}]}" ]] \
        ; then
        # finally give a warning
        printf -- '%s was changed in %s, but its "Last change" date was not updated\n' \
          "$file" "$(git describe --tags)"
      fi
    fi
  done
done

git checkout master >/dev/null 2>&1

I found the list of files which needed an update with this bash script:

A comment was wrong in the script, and there were a few other things to change.  New version:
#!/bin/bash

if [[ $# -eq 0 ]]; then
  cat <<EOF >&2
The purpose of this script is to find files whose contents has been changed,
but whose "Last change" date has not been correctly updated.

You need to provide the number of last commits you want the script to test.

usage: $(basename "$0") <number>
example: $(basename "$0") 123
EOF
  exit 64
fi

cd "${HOME}/Vcs/vim/" || exit

git checkout master >/dev/null 2>&1

# Let's build an array which maps help files to their "Last change" dates.
# We'll need this info later to suppress possible false warnings.
declare -A last_changes_on_master
for file in "${PWD}/runtime/doc"/*.txt; do
  last_changes_on_master+=(["$file"]="$(head -n1 "$file")")
done

# iterate over pairs  of consecutive commits starting from  "master~n" where "n"
# is a number supplied as argument to the script
for n in $(seq "$1" -1 1); do
  commit1="master~$n"
  commit2="master~$((n - 1))"

  rm /tmp/changes_commit1 /tmp/changes_commit2 2>/dev/null

  # get the list of "Last change" lines for all help files on a commit
  git checkout "$commit1" >/dev/null 2>&1
  for file in "${PWD}/runtime/doc"/*.txt; do
    head -n1 "$file" >>/tmp/changes_commit2
  done

  # same thing, but on the next commit
  git checkout "$commit2" >/dev/null 2>&1
  for file in "${PWD}/runtime/doc"/*.txt; do
    head -n1 "$file" >>/tmp/changes_commit1
  done

  # iterate over the list of files which haven't changed according to the "Last change" lines
  for line in $(comm -1 -2 /tmp/changes_commit1 /tmp/changes_commit2); do
    # extract filename
    if [[ "$line" =~ ^\*([^*]*)\* ]]; then
      file="${BASH_REMATCH[1]}"
      # Check  whether the  file  was  actually changed  in  commit2 (i.e.  it's
      # present in the output of "$  git diff"), contradicting the "Last change"
      # line.
      # But the  "Last change" line  might have been  changed (i.e. fixed)  in a
      # later commit.  Suppress a warning in  such a case; that's the purpose of
      # "&& [[ ... == ... ]]".
      if grep -Fxq runtime/doc/"$file" <(git diff --name-only "$commit1" "$commit2") \
        && [[ "$(head -n1 runtime/doc/"$file")" == "${last_changes_on_master[${PWD}/runtime/doc/${file}]}" ]] \
        ; then
        # finally give a warning
        printf -- '%s was changed in %s, but its "Last change" date was not updated\n' \
          "$file" "$(git describe --tags)"
      fi
    fi
  done
done

git checkout master >/dev/null 2>&1

I found more files with the same issue as those listed in post 1, this time Vim versions 8.2.2417 and 8.2.2377 were compared. (The first three should, perhaps, be fixed (if should at all) by their maintainers?)

$VIMRUNTIME/ftplugin/ada.vim: $Date: 2008-07-08 16:29:01 +0200 (Di, 08 Jul 2008) $
$VIMRUNTIME/ftplugin/framescript.vim: Latest Revision:      2008-07-19
$VIMRUNTIME/ftplugin/ocaml.vim: Last Change:  2013 Oct 27 - Added commentstring (MM)
$VIMRUNTIME/scripts.vim: Last change:	2020 Aug 15

I found more files with the same issue as those listed in post 1, this time Vim versions 8.2.2417 and 8.2.2377 were compared. (The first three should, perhaps, be fixed (if should at all) by their maintainers?)

$VIMRUNTIME/ftplugin/ada.vim: $Date: 2008-07-08 16:29:01 +0200 (Di, 08 Jul 2008) $
$VIMRUNTIME/ftplugin/framescript.vim: Latest Revision:      2008-07-19
$VIMRUNTIME/ftplugin/ocaml.vim: Last Change:  2013 Oct 27 - Added commentstring (MM)
$VIMRUNTIME/scripts.vim: Last change:	2020 Aug 15

New patch:
diff --git a/runtime/doc/cmdline.txt b/runtime/doc/cmdline.txt
index efb1400f1..d74fc88c7 100644
--- a/runtime/doc/cmdline.txt
+++ b/runtime/doc/cmdline.txt
@@ -1,4 +1,4 @@
-*cmdline.txt*   For Vim version 8.2.  Last change: 2020 Dec 26
+*cmdline.txt*   For Vim version 8.2.  Last change: 2021 Jan 27

 		  VIM REFERENCE MANUAL    by Bram Moolenaar
diff --git a/runtime/doc/options.txt b/runtime/doc/options.txt
index 8b655dc60..e0b107813 100644
--- a/runtime/doc/options.txt
+++ b/runtime/doc/options.txt
@@ -1,4 +1,4 @@
-*options.txt*	For Vim version 8.2.  Last change: 2021 Jan 08
+*options.txt*	For Vim version 8.2.  Last change: 2021 Jan 17

 		  VIM REFERENCE MANUAL	  by Bram Moolenaar
diff --git a/runtime/doc/version6.txt b/runtime/doc/version6.txt
index 6b9f1d934..ca1800fe3 100644
--- a/runtime/doc/version6.txt
+++ b/runtime/doc/version6.txt
@@ -1,4 +1,4 @@
-*version6.txt*  For Vim version 8.2.  Last change: 2020 Aug 17
+*version6.txt*  For Vim version 8.2.  Last change: 2021 Jan 17

 		  VIM REFERENCE MANUAL    by Bram Moolenaar
diff --git a/runtime/scripts.vim b/runtime/scripts.vim
index 6448c542c..122b0453c 100644
--- a/runtime/scripts.vim
+++ b/runtime/scripts.vim
@@ -1,7 +1,7 @@
 " Vim support file to detect file types in scripts
 "
 " Maintainer:	Bram Moolenaar<EMAIL_ADDRESS>-" Last change:	2020 Aug 15
+" Last change:	2021 Jan 23

 " This file is called by an autocommand for every file that has just been
 " loaded into a buffer.  It checks if the type of file can be recognized by

It doesn't fix the filetype plugins.  That's the job of their respective maintainers.

New patch:
diff --git a/runtime/doc/cmdline.txt b/runtime/doc/cmdline.txt
index efb1400f1..d74fc88c7 100644
--- a/runtime/doc/cmdline.txt
+++ b/runtime/doc/cmdline.txt
@@ -1,4 +1,4 @@
-*cmdline.txt*   For Vim version 8.2.  Last change: 2020 Dec 26
+*cmdline.txt*   For Vim version 8.2.  Last change: 2021 Jan 27

 		  VIM REFERENCE MANUAL    by Bram Moolenaar
diff --git a/runtime/doc/options.txt b/runtime/doc/options.txt
index 8b655dc60..e0b107813 100644
--- a/runtime/doc/options.txt
+++ b/runtime/doc/options.txt
@@ -1,4 +1,4 @@
-*options.txt*	For Vim version 8.2.  Last change: 2021 Jan 08
+*options.txt*	For Vim version 8.2.  Last change: 2021 Jan 17

 		  VIM REFERENCE MANUAL	  by Bram Moolenaar
diff --git a/runtime/doc/version6.txt b/runtime/doc/version6.txt
index 6b9f1d934..ca1800fe3 100644
--- a/runtime/doc/version6.txt
+++ b/runtime/doc/version6.txt
@@ -1,4 +1,4 @@
-*version6.txt*  For Vim version 8.2.  Last change: 2020 Aug 17
+*version6.txt*  For Vim version 8.2.  Last change: 2021 Jan 17

 		  VIM REFERENCE MANUAL    by Bram Moolenaar
diff --git a/runtime/scripts.vim b/runtime/scripts.vim
index 6448c542c..122b0453c 100644
--- a/runtime/scripts.vim
+++ b/runtime/scripts.vim
@@ -1,7 +1,7 @@
 " Vim support file to detect file types in scripts
 "
 " Maintainer:	Bram Moolenaar<EMAIL_ADDRESS>-" Last change:	2020 Aug 15
+" Last change:	2021 Jan 23

 " This file is called by an autocommand for every file that has just been
 " loaded into a buffer.  It checks if the type of file can be recognized by

It doesn't fix the filetype plugins.  That's the job of their respective maintainers.

I'll adjust the files.  I don't think it's that important, I believe most changes where the date wasn't updated were typo fixes.

I'll adjust the files.  I don't think it's that important, I believe most changes where the date wasn't updated were typo fixes.


UK risky venues

Not sure you want to expand this way, but pretty self-explanatory:
https://distribution-te-prod.prod.svc-test-trace.nhs.uk/distribution/risky-venues

On 11/10/2020 10:57, pdehaye wrote:

Not sure you want to expand this way, but pretty self-explanatory:
https://distribution-te-prod.prod.svc-test-trace.nhs.uk/distribution/risky-venues

Yeah, probably too much a special case.
Interestingly short and stale list though.
S.


Interactive tour - suspension of the 3rd page

Description
What steps will reproduce the problem?

Opened Spyder from Anaconda Navigation set. My system is Manjaro on 64 Dell studio  notbook.
from pull-down menu "Help" choosen "Interactive Tour"
First page was ok went to second page
Second page was ok. went to the third
3rd page haden't developed - only one part with "IPython console" was active, the small window with the pages numbers (activ available with links to the next pages window) was in ie. on and off (apearing and vanishing on and off)
I had to close all active applications and reboot system  to get rid of the page (and the low information folder at the bar)

Versions

Spyder version: 3.3.6
Python version: 3.7.4
Qt version: 5.9.6
PyQt5 version: 5.9.2
Operating System: Linux 4.14.30-1-MANJARO

Dependencies
pyflakes >=0.6.0  :  2.1.1 (OK)
pycodestyle >=2.3 :  2.5.0 (OK)
pygments >=2.0    :  2.4.2 (OK)
sphinx >=0.6.6    :  2.2.0 (OK)
rope >=0.9.4      :  0.14.0 (OK)
jedi >=0.9.0      :  0.15.1 (OK)
psutil >=0.3      :  5.6.3 (OK)
nbconvert >=4.0   :  5.6.0 (OK)
pandas >=0.13.1   :  0.25.1 (OK)
numpy >=1.7       :  1.17.2 (OK)
sympy >=0.7.3     :  1.4 (OK)
cython >=0.21     :  0.29.13 (OK)
qtconsole >=4.2.0 :  4.5.5 (OK)
IPython >=4.0     :  7.8.0 (OK)
matplotlib >=2.0.0:  3.1.1 (OK)
pylint >=0.25     :  2.4.2 (OK)

Are you using Wayland in your system?

Hi,
I don't use Wayland (as far as I know).
niedz., 22 mar 2020 o 19:21 Carlos Cordoba<EMAIL_ADDRESS>napisał(a):

Are you using Wayland in your system?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder/issues/11913#issuecomment-602250636,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM3QWMUY2NEP4NZ65JJB5KLRIZJKRANCNFSM4LRJERXQ
.

Sorry but this seems very specific to your Linux distro. I'm a Linux user myself (Kubuntu 19.04 at the moment) and everything works fine for me.
Although I understand this is a valid bug, we really don't have time create a virtual machine with your specs and try to understand what's happening there, sorry,

This is ok. I will use Spider any way as it seems to be user friendly. In case of any other problems I will let you know about it. Regards
Piotr


Add options for adding notification badges

Hey team, I was wondering if you could please add an option to add notification badges to the expo plugin since doing that currently is not very straightforward.

Hi @Nikit-Singh
Thank you for creating the issue, it sound more like a feature request. I have a few questions before moving forward with it:

Some of our customers manage notification badges by sending specific values in the payload for iOS. For example, you can set the badge count using a notification payload like this:

{
  "aps": {
    "alert": {
      "title": "New Message",
      "body": "You have a new message."
    },
    "badge": 5
  }
}

On Expo plugin, is this request for iOS, Android, or both platforms?

Additionally, is there any specific use case or further details you'd like to share with us so we can have a clearer understanding of your requirements?

What specific behaviour are you expecting from the feature ? Are you looking to control the badge counts programmatically or do you need flexibility in how badges are updated or displayed ?

Are you implementing the badges currently in your app ? If yes, how do you manage that ?

On Expo plugin, is this request for iOS, Android, or both platforms?

It's for iOS

Additionally, is there any specific use case or further details you'd like to share with us so we can have a clearer understanding of your requirements?

Is there a way to clear the notification received using the payload above when opening the app?

What specific behaviour are you expecting from the feature ? Are you looking to control the badge counts programmatically or do you need flexibility in how badges are updated or displayed ?

Only a way to clear notification is required as of now by us when opening the app from a killed state or the background state.

Are you implementing the badges currently in your app ? If yes, how do you manage that ?

No

Hi @Nikit-Singh ,
Thanks for the clarification.
Based on your use case, I would recommend setting the badge value to 0 directly in the push payload. For example:
{
  "aps": {
    "alert": {
      "title": "New Message",
      "body": "You have a new message."
    },
    "badge": 0
  }
}

This will reset or remove the badge when the app is opened, whether from a killed state or background state. Including "badge": 0 in the push notification payload will help you achieve this, and the badge count will be cleared automatically.
Let me know if you have any further questions or need additional assistance with this!

I don't want to hide the badge by sending a new notification. I want to do it when the user opens the app. This doesn't seems to be the proper way to do that.


fix: Temporarily dropping shadow dom support as it breaks with anchor elements

Fixes #74

:tada: This PR is included in version 1.0.8 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add wireguard-rs ngipkgs ref

Added everything we have from WireGuard. Depends on #439 because for some reason Cryptpad tests could never have worked but CI didn't catch it. @wegank any idea how that's even possible?


incus-unwrapped: 0.4.0 -> 0.5.1

Description of changes
Changelog: https://github.com/lxc/incus/releases/tag/v0.5.0
Changelog: https://github.com/lxc/incus/releases/tag/v0.5.1
I have not bumped lxd-to-incus, since upstream merged this separate package into the main go.mod file. I have a refactor in the works that will collapse all the incus stuff into one package, but instead of waiting on that I will instead suggest we bump incus first.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I'm blocking this until I can finish fixing lxc on aarch64.

@ofborg build incus-unwrapped incus-unwrapped.passthru.tests


Redirect tech code of practise

This is a one off task. At the moment we don't plan to redirect to pages outside the service manual on a regular basis.

Should you update the respective slug migrations so that we know they're 'done'?

Yes - thanks.

Yarp.


⚠ Bofrost.at has degraded performance

In 05d64a2, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2617 ms

Resolved: Bofrost.at performance has improved in cb5fdbf after 20 minutes.


NPM dependency warning message

When installing postcss-uncss, npm installs the latest version of uncss 0.17.0. There's a warning message asking for 0.16.1.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
One could manually install 0.16.1, but this pluging works well with 0.17.0, so there's no need for that.
Easy fix is to update the package.json file to requeste version 0.17.0 of uncss.
I'll submit a PR.

Fixed in #13.


web search

hi i need a addon for making web seach
you can contact me at<EMAIL_ADDRESS>

Issue is a duplicate
Thank you for your issue! We've linked your report against another issue #3245
Thanks for helping us to make PowerToys a better piece of software.

Duplicate of #3245


add(ConstellationApi): Implement constellation for uploading the photo

Description
The current constellation is still not persist, which means after user close the app, the previous uploaded photos will disappear. @dariusc93 is working on it to make it persist in the future.
This PR is to implement the current constellation for uploading the photo, check the photo list and preview the photo. Other features like favorite, rename, remove will be implemented in the PRs later.

Implement constellation for uploading the photo, check the photo list and preview the photo.

https://user-images.githubusercontent.com/14248245/197580117-49e8436b-8187-475c-af72-60c0deb60e31.mov
2.Add ConstellationApi initial event in WarpBloc

Change the properties in Item since they can be null when uploading the photo.
preview is for PhotoDetailPage to preview the photo.

Add covertUTCStringToDateTime function in DateFormatUtils
From constellation, we get a string like this from getItemTimestamp()and getItemDateModification()
'2022-10-24 13:47:53.997047236 UTC'
By using

DateFormatUtils.covertUTCStringToDateTime(
      getItemTimestamp(),
    );

we will get a DateTime value used in Item class.

More detail about constellation and how I struct the code
https://satellite.wiki/s/e2f1d3d2-6067-448c-8d6e-b6c264bb9acb

Type of Change

[x] ✨ New feature (non-breaking change which adds functionality)
[x] 🧹 Code refactor

Hi Yijing! I tried testing and was having some issues so I asked Sara to test as well and she experienced same problem, when you would take photo or select photo to upload you would get this message

if the user exits the app then returns back this message would appear and file still would not upload

@phillsatellite
I changed the error text here. The upload feature should be fine now since Darius updated the warp-dart. Let me know if you got some error again.

For the second issue, currently the constellation is not persist(so the file will disappear after closing the app) @dariusc93 is still working on it.

@phillsatellite
I just noticed Darius updated the code to make constellation persist, I am gonna update it.

Hi Yijing! Thanks for the update and this is working a lot better! 🎉  The only minor thing I thought I had mentioned but totally forgot to include it was the error message here should be in English, but other than that PR is great!!! 😄

The text in the NoItemPage will be changed in the next PR


Visualize delta between servertime and rawLocationTime

rawLocationTime is the time at which the GPS measurement was recorded (on device).   A large delta could indicate connectivity issues or app bugs.

IIRC we also track client timestamp at time of log entry creation/emission right?  Might be more reliable to use the delta between client log ts & rawLocationTime rather than derive a value from two values measured from server & client.

Hmm.  Agree that a delta between two client times would be more consistent.  But which field is the client time?  We have 'timestamp', 'receiveTimestamp' and rawLocationTime in the logs.   I'm not actually sure of the source of each.   Is this correct:

timestamp = device timestamp (or is it the time our backend got the request?)
receiveTimestamp = server timestamp (or is it the cloud logging timestamp)
rawLocationTime = device time at which a location measurement was taken

I might've misremembered.  Looks like timestamp is measured from FE perspective.  receiveTimestamp tracks when it was ingested by centralized logging.  I'll follow up on whether there's any emit timestamp measured from client.


resolve "receiver don't need to get itself when healthCheck #6515 "

[ ] Closes #6515.
1、Add variable private static string role in OAPNodeChecker, and set it in CoreModuleProvider#start stage
2、check private static string role before CoreModuleProvider#isHealth check itself
[ ] Update the CHANGES log.
Fix receiver don't need to get itself when healthCheck

need i solve the problem

the codecov result seems not right


fix rules formatting

CI YAML linter differs one that installed locally on laptop.
We have to update the formatting

Thanks!


[Modal] Double scroll

Hello,
The css fix that you gave me worked for Chrome, but the problem is still present in Internet Explorer : when I open a modal, I can still scroll down the form "under" the modal.

same issue as #43


Support async_mode in ext_proc filter

Description:
I am asking a feature of ext_proc filter to do pipeline processing headers/data/trailers like native filter, which I guess it is controlled by  unimplemented async_mode. Today, it is synced only so without receiving/processing the header resp, the filter won't send the body to the ext_proc server. Ideally, the ext_proc filter can still send the data to ext_proc server while blocking headers propagation in filter chain.
In my case, I need to parse some info from body and add that as a header. IMHO,  if async_mode=true is supported, on the ext_proc filter, we can do sendHeaders(buffer header), sendData(buffer data), receiveHeaderResp(header modification, forward header), receiveDataResp（forward data). You can easily do this in a  filter locally today.

/cc stevenzzzz


Sugar Cane Glitch

So, for some reason, when I restart my server, the payment for breaking and placing sugar cane is not working. I've searched through some forums for a bit, and found something that the option PlaceAndBreakProtection could cause this, but even after I turned it off, payment wouldn't come, doesn't matter where or how the sugar cane got broken, nothing happened.

Most likely incorrect block id, check with /josb blockinfo command


NotFoundError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child o...

Describe the bug
To Reproduce
Expected behavior
Screenshots
Applicable Versions:

Decap CMS version<EMAIL_ADDRESS>Git provider: git-gateway
Browser version: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36

CMS configuration
backend:
  name: git-gateway
  branch: main
media_folder: public/uploads
public_folder: /uploads
collections:
  - name: posts
    label: Posts
    folder: src/posts
    create: true
    fields:
      - name: title
        label: Title
        widget: string
      - name: body
        label: Body
        widget: markdown
    publish: true
    type: folder_based_collection
    sortable_fields:
      - commit_date
      - title
      - commit_author
    view_filters: []
    view_groups: []
publish_mode: simple
slug:
  encoding: unicode
  clean_accents: false
  sanitize_replacement: "-"
isFetching: false
error: null

Additional context

Hi @KartikUlai, please fill out all the fields in the issue template. The information you provided is not enough to debug the problem.
I'm closing the issue for now. Once you add the missing information, I can open it again.


Suggestion: language icons

I just ran into a funny little moment where VSC thought my ZS code was Java, so it was showing up in the EXPLORER panel with a nice red "J" icon. Figured I'd look up some reference on how to do that for this extension, and here's my finding: https://stackoverflow.com/questions/44598888/adding-a-language-specific-icon-in-vscode
Admittedly I'm not sure what a good ACS icon would be, but for Decorate and ZS you could just use the ZDoom and GZDoom icons respectively.
I'm sure I can just slap an icon together in Inkscape myself if you're interested.

Very cool idea! I completely forgot about icons!
It's also really easy to add them!
I think I'll put GZDoom's logo on all file types, not just because of lazyness, but also because they don't have official ones!


Feature cp<PHONE_NUMBER>869 option 1

Please disregard this PR, it is posted to help compare ways forward for CP-100, and to confirm CI would pass.


Retrieve "consider" key of the obsolete GO terms AttributeERROR

Hello,
I am parsing the go.obo file by:

obodag = GODag("go.obo")

I am having problems trying to capture the "consider" key of the GO terms that are obsoletes in the go.obo file.
For example this term:

[Term]
id: GO:0000067
name: obsolete DNA replication and chromosome cycle
namespace: biological_process
def: "OBSOLETE. (Was not defined before being made obsolete)." [GOC:ai]
comment: This term was made obsolete because it has been superseded by more accurate terms to represent the biological processes occurring, and it is not clear that this term represents a useful entity.
synonym: "DNA replication and chromosome cycle" EXACT []
is_obsolete: true
consider: GO:0006260
consider: GO:0007059
consider: GO:0051276

So I try:

obodag["GO:0000067"].is_obsolete
True

That is ok, so I try this and I get an error:

obodag["GO:0000067"].consider
AttributeError: 'GOTerm' object has no attribute 'consider'

How could I get the "consider" information of the terms?
Regards

Thank for taking the time to open this issue. The optional attributes consider and replaced_by were not supported by GOATOOLS, so I have added support as well as adding some speed improvements when loading optional attributes.
Thank you for requesting this new feature, it will surely be useful to other researchers. As soon as the regression tests pass, I will ask @tanghaibao to release a new version of GOATOOLS which contains this new functionality. The new functionality is also available immediately using git clone.

I added a Jupyter notebook showing how to load and work with obsolete GO terms, including accessing the optional attributes, consider and replaced_by.
https://github.com/tanghaibao/goatools/blob/master/notebooks/godag_obsolete_terms.ipynb
Thank you so much for the great questions.

@dvklopfenstein
New release at v1.0.2.

Wonderful! I appreciate the great commitment.


[#155269] Platform adaptive showAboutDialog and AboutDialog feature c…

This PR introduces a new showAdaptiveAboutDialog function, ensuring that the About dialog matches the platform’s design (Material for Android, Fuchsia, Linux, Windows, and, Cupertino for iOS & macOS), providing a more consistent user experience across platforms.
Fixes #155269
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

It looks like there might have been an improper merge or rebase here, since I see 57 commits (many of them being engine rolls).

It looks like there might have been an improper merge or rebase here, since I see 57 commits (many of them being engine rolls).

Yeah, it's my mistake. Shall I raise a new PR or?

It looks like there might have been an improper merge or rebase here, since I see 57 commits (many of them being engine rolls).

Yeah, it's my mistake. Shall I raise a new PR or?

No worries. You should be able to fix/rewrite the git history on your local branch and then force-push it.

It looks like there might have been an improper merge or rebase here, since I see 57 commits (many of them being engine rolls).

Yeah, it's my mistake. Shall I raise a new PR or?

No worries. You should be able to fix/rewrite the git history on your local branch and then force-push it.

Hey @andrewkolos it's done. Thanks

Hi @MitchellGoodwin, Thank you for reviewing my PR! I appreciate the guidance. I've reverted the formatting changes as requested and ensure that the code follows the framework's style guide. This should resolve the failed check and make it easier to review.

IMO Cupertino should have its own CupertinoAboutDialog (https://github.com/flutter/flutter/issues/57638), which AboutDialog.adaptive can delegate to. This is so that there aren't independent iOS-styled dialogs like how it currently is in CupertinoSwitch (https://github.com/flutter/flutter/issues/152514). And will also reduce our maintenance burden.

IMO Cupertino should have its own CupertinoAboutDialog (#57638), which AboutDialog.adaptive can delegate to. This is so that there aren't independent iOS-styled dialogs like how it currently is in CupertinoSwitch (#152514). And will also reduce our maintenance burden.

Thank you for the feedback @victorsanni! If we look at the underlying functionality of showAboutDialog, it leverages AboutDialog, which by default utilizes AlertDialog. Since we already have CupertinoAlertDialog in place, when AlertDialog.adaptive is called, it automatically uses CupertinoAlertDialog for the iOS platform.
In this PR, I am making use of AlertDialog.adaptive, which in turn will invoke CupertinoAlertDialog when running on iOS. Given that the underlying functionality already adapts to the platform-specific dialog (i.e., CupertinoAlertDialog on iOS), do we really need to introduce a separate CupertinoAboutDialog? The current approach seems to already handle the adaptation without requiring an additional widget.
Would appreciate your thoughts on this!

@thejitenpatel I agree that it makes sense to use the simplest most straightforward solution. But I would imagine there are users who target iOS first (or Cupertino widgets decoupled from Material), and them of all people should be able to get this functionality.
One should be able to use a Cupertino-look about dialog without having to depend on the Material library.

@MitchellGoodwin, @victorsanni, Thank you for the LGTM and for taking the time to review my PR! I really appreciate the feedback and the style guidelines suggestions. I've resolved the nitpicks as per your recommendations. Looking forward to more contributions! <3


chore(guidelines): add pr review guidelines to the contribution guide

Closes #584

Deploy preview for pf-next ready!
Built with commit cd42de490b48cb53e9bc62da59b0d90166e2866e
https://deploy-preview-645--pf-next.netlify.com

This looks good to me. Let's talk as a group about how the designated reviewer comes to be.


[BUG] Unable to create VM from existing image volume

Describe the bug

To Reproduce
Steps to reproduce the behavior:

Install Harvester with any nodes
Create an image for VM creation
Create an image volume os-disk
Create VM with existing volume os-disk and bootOrder:1
VM should created and started successfully

Expected behavior
User should able to create VM from the existing Image volume
Environment:

Harvester ISO version: master-b49e264e-head
ui-source Option: Auto
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): qemu/KVM 3 nodes

Additional context
This bug appeared on UI only.

@WuJun2016, please help investigate the issue.

Verified this bug has been fixed.

Test Information

Environment: baremetal DL360G9 3 nodes
Harvester Version: v1.2.0-rc2
ui-source Option: External

Verify Steps

Follow Steps to reproduce in https://github.com/harvester/harvester/issues/3948#issue-1719811883


New networks requests

For now react-custom-share has built-in share scripts for six 'networks':

Facebook
Twitter
Google+
Linkedin
Pinterest
Email

If you think that we should add a built-in share script for a new network add a comment-request here.
But first, check if someone has not requested it already. Make sure that there is not a comment- request for the network you want to add already.
If there is already a comment-request for the network, just react with a thumb-up to the comment.
Please do not replicate comment-requests for the same network. Thank you.

Instagram network request

Whatsapp


MLHR-1859 #comment checkstyle execution phase is inherited from paren…

…t with an older version

@ilooner please review and merge


HUM-415 Better systemd support

Type=forking did not pan out. systemd is quite picky. If you use
Type=forking and PIDFile=x it does not expect a reload to cause a PID
change. I tried a few ways "suggested on the internet" such as ensuring
the PIDFile was fully updated before exiting whatever ExecReload called
to no avail. Also, I had no idea how to make a graceful stop work under
Type=forking, which made systemctl restarts pointless. So I gave up,
went back to to thinking board, put on my drawing cap, and...
...now we have this. Type=simple still, but systemd is now calling a new
systemd controller process of Hummingbird, which then translates what
systemd wants to happen with what we want to happen.
start: starts hummingbird up with the args given, then listens for
signals or process exit. If it gets a signal, it passes that on to the
real hummingbird process. If that signal was HUP, it then loops back
around relaunches the real hummingbird process (therefore leaving the
original PID running, which makes systemd happy).
reload: sends the HUP signal to our systemd helper process.
stop: sends the TERM signal to our systemd helper process, and waits up
to five seconds for that process to exit. systemd expects the main
process to have exited when stop returns or it will kill it. When our
helper receives TERM it ill forward the signal to the real hummingbird
process and immediately exit. This has the downside that a weird hung
real hummingbird process won't be detected by systemd; we may need to
improve this in the future to launch a "make sure it dies" process, but,
I guess wait until it becomes an issue.
I tested this in various ways I could think of, the main interesting one
being a slow upload that completely survived a reload of all processes.
If you want to do this yourself, I can recommend this for the slow
upload:
for i in {{1..100}} ; do sleep 1 ; echo . ; done | nectar put c/o
When all the services are reloaded while that upload is in progress, you
should see (on an haio) double proxy processes as well as 3 extra object
server processes. Once the upload completes, you should see these extra
processes go away and "graceful exit" log messages come through.

LGTM! It even works when you type the right thing. 👍


Upgraded DCA bot vyper contract - sqlite instead of view function

won't do as we'll proceed with https://github.com/VolumeFi/paloma/issues/201


[Event Request] Codeunit 365 Format Address for function SalesInvShipTo

We need an event publisher OnBeforeSalesInvShipTo(AddrArray,SalesInvHeader,Handled,Result) with handled pattern and result at the begining of the function SalesInvShipTo in codeunit 365 (Format Address).

Just like the one in function SalesHeaderShipTo:

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


fix dying consumer deadlock during rebalance

We have seamless deploy. When new service is deployed a rebalance begins (at that moment we have the old service and the new one). While rebalance is going on the old service is shutting down and deadlock occurs.

Thanks, nevertheless!


When textField autofill for verification messages, i get repeat code on iOS.  Language is Chinese. No problem in English.

Is what you're talking about the same as this issue? https://github.com/flutter/flutter/issues/31512
If not, can you provide a sample app that reproduces the problem?


Mixing RRv3 and v4

I have a large codebase which would take a while to update to v4.
Is it possible to incrementally upgrade to v4 from v3?
Can they be used in the same project simultaneously?

No. The history instances would interfere with each other. 4.0 isn't out yet, so I would wait until an upgrade path is available.

@timdorr Do you think an upgrade path would allow mixing?

Nope. Trying to get two histories at once isn't going to work.

@timdorr So what do you suppose an upgrade path would allow that isn't yet practical?


[WIP] Add opensds ansible installer

In this patch, I created a ansible package to install opensds and backend services through ansible  tool. Currently I have finished the test of opensds installation with lvm backend, for ceph backend I only finished the code but not testing work. I'll keep you informed my latest work.

Coverage remained the same at 60.323% when pulling 3bd1ea779f7a96ac714b2e3191edd24fe4aacfc5 on leonwanghui:ceph-ansible into 110529445af7f153b938257a6368f1ee586fd843 on opensds:development.

I will merge this patch now, and we can fix bugs by submitting other patches.


Update _reactSetup.mdx

🚀 Deployed on https://668459182e1a7c009f67632b--cozy-fox-0defec.netlify.app


Invalid certificate

When visiting https://csstriggers.com/ Firefox tells me, that the certificate is invalid.
The common name it is issued to is kitchenwallapp.com.
Please update the Let's Encrypt cert for it.

Thanks for issuing! We are already aware and are working with Firebase to fix this. I'll keep you posted here.

Got a new certificate and all is back up and running :)

That was fast! Thanks!


Auth docs are missing SignIn/SignOut part.

Describe the new topic
I had to look inside the source code to understand how SignIn and SignOut flows work, and which party needs to implement the logic. (Docs do not mention IAuthenticationSignInHandler). Describing what SignIn and SignOut are intended for would be useful.
Also, I could not find a place where docs talk about IAuthenticationRequestHandler and what role it plays in authentication. Especially for RemoteAuthenticationHandler implementations which expect callback from remote identity providers.
IMO, this is an important subject related to authentication which should be added to the documentation.

Also this should be a part of documentation:

Only the default auth scheme configured via AddAuthentication is used to set the HttpContext.User.


pretty log and option to disable log

Hi, great plugin. It helps me a lot generating sprites.
Here is a little request. I use this plugin with postcss-cli Could you please format the log so it looks pretty and useful? Now it just prints a few lines of useless logs. And provide an option to disable log?
Thanks.
postcss-sprites: 0 spritesheet generated.
postcss-sprites: 0 spritesheet generated.
postcss-sprites: 0 spritesheet generated.
postcss-sprites: 0 spritesheet generated.

@zyy7259 Can you give an example for logs that will be useful? :smile:

Maybe some key steps when generating the sprits, like initializing, checking (filtering), grouping, and etc. And maybe an option to disable logging.

I definitely second the ability to disable this. We run this plugin over dozens of stylesheets -- it's very noisy and not actually that useful.  Since result.warn is really meant to convey something actionable, if you're looking to provide general diagnostic information about how many spritesheets are being generated, maybe a tool like debug would be a way to do that and allow people to opt-in to the logging.

I think this "warning" is the reason I have to look at this unsightly banner on my dev server:


Update statement URLS

Details

Fixed Issues

URL configs have been updated, these are still on the old ones and need to be updated
Statements cannot be viewed currently
Tests

[x] Verify that no errors appear in the JS console

PR Review Checklist

Go to new.expensify.com/statements/202201
Make sure the statement shows up and you see more than a blank screen

Contributor (PR Author) Checklist

[x] I verified the PR has a small number of commits behind main
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I clearly indicated the environment tests should be run in (Staging vs Production)

[x] I wrote testing steps that cover success & fail scenarios (if applicable)
[ ] I included screenshots or videos for tests on all platforms
[x] I ran the tests & veryfy they passed on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[x] I verified there are no console errors related to changes in this PR
[x] I followed proper code patterns (see Reviewing the code)

[x] I added comments when the code was not self explanatory
[x] I put all copy / text shown in the product in all src/languages/* files (if applicable)
[x] I followed proper naming convention for platform-specific files (if applicable)
[x] I followed style guidelines (in Styling.md) for all style edits I made
[x] I followed the JSDocs style guidelines (in STYLE.md)

[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I corroborated the UI performance was not affected (the performance is the same than main branch)
[x] If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

[ ] I verified the PR has a small number of commits behind main
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the testing environment is mentioned in the test steps

[ ] I verified testing steps cover success & fail scenarios (if applicable)
[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors related to changes in this PR
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified comments were added when the code was not self explanatory
[ ] I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
[ ] I verified proper naming convention for platform-specific files was followed (if applicable)
[ ] I verified style guidelines were followed
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified the UI performance was not affected (the performance is the same than main branch)
[ ] If a new component is created I verified that a similar component doesn't exist in the codebase

QA Steps

Will need to be testing on production with

https://github.com/Expensify/App/pull/7873

https://github.com/Expensify/App/pull/7921

[ ] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Leaving out all platform SC since we're only doing a URL change here.  The old constant does not exist

Going to merge so we can get this fixed!

🚀 Deployed to staging by @nickmurray47 in version: 1.1.42-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@thienlnam Can I checkmark this as steps seem to refer to PROD QA?

Yup, this is good to check off @mvtglobally

🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


added support for *.sh files...

hi, i'm a total newbie about atom and github...
i just added a few lines  to block-comment.coffee so that it supports commenting blocks of shell scripts lines:
    ...
    else if extension is 'sh'
      commentStart = ''
      commentEnd = ''
    ...
    ...
    selectionText = selection.getText()

    if extension is 'sh'
      # add '# ' to the beginning of each line
      selectionText = selectionText.replace /^/, "# "
      selectionText = selectionText.replace /\n/g, "\n# "

nothing else, and works pretty good...

i've just sent my very first pull request...
hope you'll evaluate it!


Manage PowerTools on CentOS8 / Codeready on RHEL8

The package nagios-plugins-all depends on the mentioned repositories and you are also told to enable it in icinga docs, so it would be a nice feature to have this module to also manage them.

Will be implemented for powertools only for now.


Suggestion: Make the tool compatible with 5e.tools json bestiaries

Well, the title is self-explanatory. Just a suggestion ;)

That website is actively engaging in copyright fraud. We do not condone piracy.


fix ignore aux expr when do push agg op

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.48 seconds
stream load tsv:          478 seconds loaded<PHONE_NUMBER>9 Bytes, about 149 MB/s
stream load json:         40 seconds loaded<PHONE_NUMBER> Bytes, about 56 MB/s
stream load orc:          69 seconds loaded<PHONE_NUMBER> Bytes, about 15 MB/s
stream load parquet:          28 seconds loaded 861443392 Bytes, about 29 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230228115656_clickbench_pr_105688.html


Searching in Aptitude destroys the display

A brief description
The looks of the display is destroyed after: I start Aptitude using sudo aptitude and then search for small using /. I press n a couple of times.
Expected results
The display of characters should look clean. This worked in some earlier build.
Actual results (with terminal output if applicable)
Some parts of the screen contain old lines. Some characters are blanks.

Your Windows build number
Build 14931 & Build 14936 & Build 14942.1000.amd64fre.rs_prerelease.161003-1929
& Build 14955.1000.amd64fre.rs_prerelease.161020-1700.
Steps / All commands required to reproduce the error from a brand new installation
Uses built in commands.
sudo aptitude
/
small
n
n
n
n
...
Strace of the failing command
N/A
Required packages and commands to install
sudo apt update && sudo apt dist-upgrade
Set font DejaVu Sans Mono, size 16, or try other fonts with size 18. I have not discovered any bugs with Consolas 16.

I actually encountered something similar last night (not identical but possibly related), for what it's worth:  I was ssh'ed from WSL into an Ubuntu Linux machine to run do-release-upgrade on it; whenever an ncurses dialog popped up as part of the upgrade process, the dialog initially displayed correctly but it would redraw incorrectly.

I'm pretty sure this is a fonts issue. @mobluse what font are you using? I know if I use Menlo, dialogs and other separators appear misaligned constantly, while Consolas seems to work fine.

I normally use DejaVu Sans Mono, but now I've tested with Consolas and Ubuntu Mono, and I get similarly wrong display, when I do the test. I've also tested both size 18 and 16. Consolas 16 works, but I want to be able to use DejaVu Sans Mono since it supports more Unicode characters. Of course the console should work with any mono font and size, since this works in e.g. Ubuntu. This worked better in earlier builds.

Thanks for the info. We'll dig into this.

Filed: Bug 9133416

After investigating this for a while, I'm moving this from a bug to a feature request.
As it turns out, those horizontal lines are U+2500, which is technically an "ambiguous" width character. Conhost has a lot of work to do with non-single width characters, and although a lot of improvements are coming in the next update, there's still a lot more to do.
In the meantime, I'd just avoid whichever fonts give you problems with this. I compiled this list a while ago while investigating a similar bug, i'm not sure if it's still relevant but I figured I'd share:

Consolas - good?
Menlo - bad?
Dejavu sans mono - bad?
Iosevka - bad
Courier New - good
Consola Mono - Good, but lines are box characters (but they all appear)
Code New Roman - good
Bitstream Vera Sans Mono - same as consola mono
Anonymous Pro Mono - bad
Anka/Coder - bad
VT323 - good
Ubuntu Mono - Good, lines dont totally connect though
SimSun-ExtB - Bad, line is longer than half, but only first color
Share Tech Mono - good, boxes
Raster fonts - lol, bad
NSimSun - Bad, line not exactly half, closer to full length, but still only first half.
NovaMono - good, boxes
MS Gothic - same as NSimSun
Both Meslo varieties - bad

Looks like display scaling also an issue. On Surface 3 I have 150%, and aptitude breaks on default Consolas 16. However, it works good with Consolas 14.

Hey it turns out this is related to #1879, and already has a fix inbound. I just lost track of this issue, so I didn't close this one too.
Should be out to insiders soon :)


can not build in xcode7-beta4 swift2

hi, I cloned the repo and try to build it in xcode7-beta, and have encounted following build issues.

carthage update . error.
solved.
1). upgrade carthage to 0.8;
2). modify Cartfile to

github "Alamofire/Alamofire" "swift-2.0"
github "SwiftyJSON/SwiftyJSON" "xcode7"

Then in xcode, hit Cmd+B, It compliant several errors.
Swift Compiler Error.
Ditto Error.
PBXCp Error.
and so on.
then I stucked at this point. anyone helps?

Solved the issue. It seems that Alamofire swift-2.0 version has changed the api.

Thanks for reporting this issue. I am working on Xcode 7 version now. Will use iOS 9 only features like UIStackView


Dependencies can be added to each separate route (list of dependencies)

Hello,
So as discussed in #37
I think this might be how to make a pull request so I give it a try.
If this is not needed or too late, it's fine, I am glad to learn!
closes #59 #37

Hi @DorskFR. This looks great! For here all I guess all we would need to do is update the docs to document this feature.
And maybe write some tests for it (which I can do) 😄

Hi @awtkns,
Thank you for your reply!
I see you moved the test to check if its a bool or a dependency to the add_api_route.
It's way better indeed, it avoids many repetitions in every router.
Thanks for the opportunity to create this PR.
I will try to study how you wrote the existing tests next.

@DorskFR Thanks for the PR. The feature is now released with version 0.7.0


Review runbooks

Looks like we have some more commits that signing @jemnery - due to github doing a merge itself


SDK log injection and uniform logging in operator-sdk binary

Description of the change:

Switch the operator-sdk binary's logger from a mix of std log and logrus to only logrus.
Add package pkg/logutil, which provides a parent logger and log levels to SDK users. Users can use controller-runtime/pkg/runtime/log.SetLogger() to inject their own logr.Logger into their operator.

The SDK injects zap by default in this PR.
pkg/sdk/*metrics* and pkg/ansible are used by generated operators, which is why these packages don't use logrus. Note that I've rewritten some metrics functions to return errors rather than log output.

Motivation for the change: Operators generated by the SDK did not have a uniform logging interface pre-v0.1.0. Now that controller-runtime is the main source of logs in a generated operator, the decision was made to expose a log injection mechanism so users can choose what logger to use and operators emit uniform, structured logs. See #503 for our detailed discussion. The operator-sdk binary similarly did not have uniform logging. logrus is a reasonable choice for the binary's logger because warnings are used frequently.
Closes: #503

Note: I'm removing package-level logging in favor of a more configurable setup.

@estroz Can you please share a sample output of what the logs look like now? e.g for the memcached-operator.

@hasbro17 logs look like this:
2018-11-08T00:00:25.700Z	WARN	operator-sdk.logging_event_handler	events/log_events.go:73	[playbook debug]	{"name": "example-memcached", "namespace": "default", "gvk": "ansible.example.com/v1alpha1, Kind=Memcached", "event_type": "runner_on_ok", "job": "5164212467572124800", "EventData.TaskArgs": "msg=this is a finalizer"}

As per your comment on formatting the log message, I don't think its necessary because there's enough structured information here to get the meaning of a log message.


async new

More a code style question: Does it make sense to rename FooBar::find_by_id(...) to FooBar::new(...) instead? Or is there a more idiomatic way to handle "async constructors"?

Result from the discussion: don't use new for that.

Result from the discussion: don't use new for that.


Tagging release 2.7.1?

Hi
Would it be possible to tag release 2.7.1? There are some bugfixes in git that it would be useful to have in a release :)
Thanks!

would be nice on Mac OS...

@grundlerchromium @teknoraver any plans for a release?

I'm not the repo owner

On Mon, Sep 14, 2020 at 4:01 PM Debjeet Biswas<EMAIL_ADDRESS>wrote:

@grundlerchromium https://github.com/grundlerchromium @teknoraver
https://github.com/teknoraver any plans for a release?

I don't have commit rights to this repo. I've requested them and it's been
ignored.
I haven't contributed to this project recently since it feels like it has
been orphaned. If someone wants to actively maintain a fork, I'm interested
in helping since the statistics provided by netperf are quite useful.
cheers,
grant

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/HewlettPackard/netperf/issues/12#issuecomment-692153200,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIUROSGWI3VC3TAS22S53MDSFY44BANCNFSM4EWHPTVA
.

@kirbychris are you the repo owner?


Provide stable ids for indexing of logs

Indexers need a stable id for log receipts to continue working through contract updates. We need to provide a mechanism for the user to generate such stable ids.
At the minimum we should provide an annotation the user can add to a logged type that populates the ABI spec, but more likely it should be a trait that has to be implemented for any logged type.

Fixed in #5980


Making SingleFieldAppendingMarker#getFieldValue() package-private broke log assertions

Description
I am maintaining https://github.com/dm-drogeriemarkt/log-capture/ which we use to test our logging.
I also allows to assert logging of keyValue, see https://github.com/dm-drogeriemarkt/log-capture/#key-value-from-logstash
Making SingleFieldAppendingMarker#getFieldValue() package-private broke that for me, because I used it for those assertions. I don't see a viable replacement, although I might be overlooking something.
Expected behavior
I am aware that is kind of a https://xkcd.com/1172/ situation ;-), but I would like a way to be still able to use those assertions. If everything else fails, I can mis-use toStringSelf() and filter out the key, but I'd rather not do that.

logstash-logback-encoder 7.1

Hi @elefeint
The visibility of getFieldValue() has indeed been reduced - it wasn't meant to be part of the API and should ideally remain internal to the class hierarchy.
As far as I can see, you are using this method in LogstashLoggingEventEnhancer. Could you please tell me a bot more about it?
As you know, we also have more complex markers like MapEntriesAppendingMarker and ObjectFieldAppendingMarker in addition to the SingleFieldAppendingMarker... If you tell me more about your usage scenario may be we could find a more powerful approach that would give you access to the information contained in the other markers as well..

Does spring-cloud-gcp logging allow appending arbitrary "raw" JSON to their JSON event output?   If so, it could:

create a JsonGenerator that writes to a string,
call LogstashMarker.writeTo(JsonGenerator)
append the string as "raw" JSON to their JSON event output

This approach would support every type of LogstashMarker (not just the implementations of SingleFieldAppendingMarker)

spring-cloud-gcp glues together Logback and GCP abilities -- in this case, logback's JsonLayout. JsonLayout accepts a map of keys and values, but not raw JSON.

That's unfortunate.   The limitations of JsonLayout are one of the reasons logstash-logback-encoder exists ;)
The LogstashMarkers weren't really designed to be consumed by anything other than the encoders within logstash-logback-encoder.  This issue is the first case I've heard about where LogstashMarkers are being consumed by something other than the encoders within logstash-logback-encoder.  As such, the current implementation in spring-cloud-gcp that consumes the markers directly is going to be extremely fragile.
Will need to think about this some to come up with a good approach.

Thank you! For now, we'll hold off on upgrading.

Fwiw, we also need the actual value and not JSON for our assertions @philsttr, since the whole point of those assertions is that they are based on content and should work regardless of log formatting/encoding.

Not an issue for me anymore. I've removed the assertion from my log testing library.

@waschmittel Thanks for the feedback.
@elefeint Are you still impacted by this issue?

Yes, but because it's an optional add-on feature, we could remove it in a major release in early 2023.
It's an understandable mismatch in targeted use-cases. Your readme does say that markers are only supported "if using LogstashEncoder/Layout"!
Ultimately, end users can create custom GCP logger enhancers with the data that they use for logstash markers.


Database struture example when using Sql persistance

What does the table need to be like to work properly?
Is this valid: https://github.com/elmah/Elmah/blob/v1.2-sp2/src/Elmah/SQLServer.sql ? Is the SP also needed?
The "CreateTablesIfNotExist" option does not seem to work with custom schema & table name

You can see the structure of the table required here.
I don't see why the CreateTablesIfNotExist wouldn't work. Is it possible the db user doesn't have permission to create schema?


Document Proper Unity Settings

https://blackflux.com/forums/viewtopic.php?f=9&t=43&start=20#p223

https://blackflux.com/forums/viewtopic.php?f=9&t=43&start=20#p224

The unique thing to change is how texture is imported to Unity (removing filters, basically)
Model exported as collada works well


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-24-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1962

Questions ?
Please refer to the Backport tool documentation


added embed kernels support for App project

This need to get standalone Baikal render integration to Volga viewer

This pull request is failing the Linux build. Could you fix?
==== Building App (release_x64) ====
Creating obj/x64/Release
aorenderer.cpp
AO/aorenderer.cpp: In constructor ‘Baikal::AoRenderer::AoRenderer(CLWContext, int)’:
AO/aorenderer.cpp:110:63: error: ‘cl_app’ was not declared in this scope
m_render_data->program = CLWProgram::CreateFromSource(cl_app, std::strlen(cl_integrator_ao), context);
^
AO/aorenderer.cpp:110:83: error: ‘cl_integrator_ao’ was not declared in this scope
m_render_data->program = CLWProgram::CreateFromSource(cl_app, std::strlen(cl_integrator_ao), context);
^
Makefile:192: recipe for target 'obj/x64/Release/aorenderer.o' failed
make[1]: *** [obj/x64/Release/aorenderer.o] Error 1
Makefile:72: recipe for target 'App' failed
make: *** [App] Error 2

The paths in integrators like:
m_render_data->program = CLWProgram::CreateFromFile("App/CL/integrator_ao.cl", m_context);
break App on all platforms if not using --embed_kernels option. Please fix paths to be ../App/..
Also, could you please update from the upstream since CreateFrom... signatures have changed to account for compiler build options.

Closing not to trigger builds on build server


[HOLD] Restricted workspace create button click while workspace is created.

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/5573
Tests & QA Steps

Click  ➕  new button
Select the New workspace option
No quickly try to repeat the step 1 & 2
 New workspace option will be hidden now

Tested On

[x] Web
[x] Desktop
[x] iOS
[x] Android
[x] Mobile Web

Screenshots

Web
https://user-images.githubusercontent.com/85645967/141357915-55d663c5-ff50-4b67-ab64-67de6049aeb5.mov
Desktop
https://user-images.githubusercontent.com/85645967/141357940-c5611ecb-4439-46b2-a12a-e96171ab2054.mov
iOS
https://user-images.githubusercontent.com/85645967/141357955-4057e282-0fe1-4796-959d-fea3dbb9ba28.mp4
Android
https://user-images.githubusercontent.com/85645967/141357949-b8947c2c-0ed1-468c-be35-80c3f1d844e7.mov
Mobile Web
https://user-images.githubusercontent.com/85645967/141359310-830c4e65-baad-4616-95c8-079306273d32.mp4

Removed Company Offsite HOLD, feel free to merge @Julesssss

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @Julesssss in version: 1.1.15-18 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add support for three display modes of the path in the prompt: short, medium and long

This patch adds support for three display modes of the path in the prompt via the BULLETTRAIN_DIR_EXTENDED variable:

0: short path - just the current directory name
1: medium path - the current directory path with up to three elements after which the path gets short with an ellipsis (default)
2: long path - the full path is shown, $HOME is abbreviated with ~

Also see pull-request https://github.com/caiogondim/bullet-train-oh-my-zsh-theme/pull/54 for reference where I screwed up a little ;)

This is amazing. Thanks for the PR.


SMTP server setup requires an email as the username

The SMTP server that I would like to use with Stello needs a username that is not an emailaddress. Stello does not allow for this.

I noticed in the log output that the SMTP host name I had filled in contained a space at the end, and therefore was not found, so it didn't go on to the next page in the config where the option for the username was.
Suggestion: strip spaces from user input! But my setup is working now, closing.


manifests: add name for container port

Issue #, if available:
Description of changes:
So that tooling that only works with named container ports is usable with this operator's chart and kustomizations.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hi @twz123 , Thank you for your PR.
These controllers are auto-generated from code-generator library. So, I will request you for making a change in these template files and then next release will have this feature included.
Closing this PR. We appreciate your contribution. :)


Fix Issue 15379 - "final" attribute on function parameter

final is not allowed here in D2.
void foo(final int a){} // error!

finalpar.d(1): Error: variable `finalpar.foo.a` cannot be `final`, perhaps you meant `const`?

It's not a parse error though, this compiles:
version(none) void foo(final int a) {}

So the grammar should allow it.

It's not a parse error though, this compiles:
version(none) void foo(final int a) {}

So the grammar should allow it.

Why we should allow something that apparently doesn't have a useful meaning? I think moving the error to the parser, if we can have the same kind of error message, and fixing the grammar is a good path. Otherwise, if this has some meaning for templates, we should perhaps update the spec?

Why we should allow something that apparently doesn't have a useful meaning?

I meant to say "the grammar should allow it or the implementation should be updated to match the new grammar".

I think moving the error to the parser, if we can have the same kind of error message, and fixing the grammar is a good path.

There are plenty of errors that could be caught by the parser but are currently caught during semantic analysis, keeping the grammar simpler.
version(none)
void f() scope {
    break;
    default:
    switch (0) {}
    "useless";
}

I'm not against changing the parser here per se, but moving errors to parse time isn't a "good path" by default.

There are plenty of errors that could be caught by the parser but are currently caught during semantic analysis, keeping the grammar simpler.

In this case the grammar is not simpler. I think the reason it parses was for the error advising to use const. That error is probably not needed anymore, or could perhaps be done in the parser. If not, the spec should note that final is not valid here.

I think the reason it parses was for the error advising to use const

Perhaps it was so D1 and D2 code can co-exist in the same module? So perhaps it should still parse if this is still a goal.

As this seems intentional to not error on parsing, I have added a note to the docs instead of removing final.
@dkorpel Can you remove the waiting for dmd label now please?


Weex 项目 30个页面编译 巨慢 几乎停止不动

This PR/issue doesn't received response since Weex migrated to Apache two years ago and this repository is no longer active yet.
Feel free to ask question in new repository and thanks for your contribution.

This issue is outdated for a long time and will be closed now. You can create a new one if you still have questions.


Paging URLs returned when there is a single page

We return paging URLs even if there's only one page of results.  For instance:
$ curl localhost:8080/dev/crud
{
  "results": []
}
$ curl -d '{"a":342}' localhost:8080/dev/crud
{
  "id": "316f47d1-e104-49c3-8f4e-14ba3098713c",
  "a": 342
}
$ curl localhost:8080/dev/crud
{
  "next_page": "/dev/crud?cursor=eyJheGVzIjpbeyJrZXkiOnsiZmllbGROYW1lIjoiaWQiLCJhc2NlbmRpbmciOnRydWV9LCJ2YWx1ZSI6IjMxNmY0N2QxLWUxMDQtNDljMy04ZjRlLTE0YmEzMDk4NzEzYyJ9XSwiZm9yd2FyZCI6dHJ1ZSwiaW5jbHVzaXZlIjpmYWxzZX0%3D",
  "prev_page": "/dev/crud?cursor=eyJheGVzIjpbeyJrZXkiOnsiZmllbGROYW1lIjoiaWQiLCJhc2NlbmRpbmciOnRydWV9LCJ2YWx1ZSI6IjMxNmY0N2QxLWUxMDQtNDljMy04ZjRlLTE0YmEzMDk4NzEzYyJ9XSwiZm9yd2FyZCI6ZmFsc2UsImluY2x1c2l2ZSI6ZmFsc2V9",
  "results": [
    {
      "id": "316f47d1-e104-49c3-8f4e-14ba3098713c",
      "a": 342
    }
  ]
}

The second GET should have no paging URLs, just like the first.

Maybe it would be less surprising if we always returned the paging URLs? If we don't include them in small responses, then devs may not realize that the results are paged and will not handle paging when consuming the CRUD.


Documentation for python secret manager v2

A couple functions we were using from v1 were deprecated in v2.
Please let me know when the docs for v2 are out.

Hi @aaryamannchallani,
I just triggered the docs build so the new documentation should be available in the next hour.

Awesome. Thanks @busunkim96

You might want to update the quickstart available at this link too, doesn't work with v2

2.0 docs are now published: https://googleapis.dev/python/secretmanager/latest/index.html
I think the cloud.google.com docs are still pulling samples from the old repository. Updated samples can be found at https://github.com/googleapis/python-secret-manager/tree/master/samples/snippets.

Cool, thanks a lot.


⚠ Account Information API has degraded performance

In 2674da3, Account Information API (https://accountinformation.roblox.com) experienced degraded performance:

HTTP code: 200
Response time: 5620 ms

Resolved: Account Information API performance has improved in 1abc9ca.


Removed all nibs from Eatery

Nibs are gone from Eatery 🥳

For MenuButtonsDelegate, it's standard to pass in the object to a delegate method. Apple uses this throughout their protocols.

For MenuButtonsDelegate, it's standard to pass in the object to a delegate method. Apple uses this throughout their protocols.

That I understand, what I'm wondering is why the the requirement for favoriteButtonPressed was changed from optional to fully required. For example, in EateriesViewController:
func favoriteButtonPressed(on view: MenuHeaderView) { 	        processEateries() 	        collectionView.reloadData() 	    }
this function does not make use of the view parameter. Removing the optional requirement makes it such that this parameter is required unnecessarily. In the end it's your call, but just out of curiosity, why was the optional tag removed?

For one method protocols, the function does not need to be optional, since the implementing class can just not inherit from the protocol; it wasn't going to use any other methods otherwise.
For protocols with more than one method, having the protocol be @objc might have some merit, but generally feels unswifty. For Eatery in particular, since all the view controllers that implement the delegate already implement all the methods of that delegate, there's no reason to have them be optional. So, in general, what's the solution here? Closures or some sort of observer framework would be better, although @objc optional methods may have some merit for swift code interfacing with Objective-C (which we have none of in Eatery)
Another solution would be to provide an empty default implementation of the protocol methods, but since all these delegates have one or two requirements, I think it just adds clutter.

Thanks for explaining your reasoning; makes sense why you chose to remove the optional modified then! Looks good.


Additional parameter to change Demo Folder on the Host?

I think it would be useful to have an additional parameter to change the Folder on the Host. At the moment the $demofolder c:\demo is hardcoded at some places.

Correct it is totally hardcoded - I have it on my list to change it do c:\programdata\navcontainerhelper - I just need to investigate the consequences:-)

Will be changed in next version

folder is c:\programdata\navcontainerhelper in <IP_ADDRESS>


StepUp & Crouch animation interact poorly

While stepping up an obsticle, the character enters into its crouching animation very suddenly causing a jarring transition from standing to partially crouching. Very noticeable on stairs, looks like headbanging.

Used raycasts to smooth things.


Youngblood/store param strings

adds vectorization to CLI
changed project run_model default to lda
changed the datatype of the individual weight values in the lda matrices from numpy.float64 to float in order to match plsa and more importantly successfully decode from file using jsonpickle.
minor documentation updates

LGTM.  Nice work.


Partial Occlusion of input element in checkbox.cy.js

While writing the integration test for #134, Cypress was complaining that it cannot find the checkbox to click as it was partially covered by a parent element. This was remedied by explicitly setting the viewport in the test.

The problem seem to has appeared in component tests as well namely ResultCard.cy.js and ResultsContainer.cy.js so ideally we'd want to have centrally configured viewport size.

This has been addressed in the new query tool.


HWY-105: Avoid unnecessarily recomputing unit hashes.

https://casperlabs.atlassian.net/browse/HWY-105

bors merge

bors merge


Get downloaded file path

Hello, here's my code :
                let destination = Alamofire.Request.suggestedDownloadDestination(
                    directory: .CachesDirectory,
                    domain: .UserDomainMask
                )
        Alamofire.download(.GET, "http://www.adobe.com/devnet/acrobat/pdfs/pdf_open_parameters.pdf", destination: destination)
            .progress { bytesRead, totalBytesRead, totalBytesExpectedToRead in
                print(totalBytesRead)
            }
            .response { request, response, _, error in
                print(response)

        }

I need to know how to convert the destination path (destination) to filePath or how to get the download file in the response call back ?

It's a bit tricky if you use the suggestedDownloadDestination method.
If you use the suggestedDownloadDestination method to retrieve the destination closure, you'll need to pass the response to the destination closure in your response closure to figure out where the file was moved.
let destination = Alamofire.Request.suggestedDownloadDestination(
    directory: .CachesDirectory,
    domain: .UserDomainMask
)

Alamofire.download(.GET, "http://www.adobe.com/devnet/acrobat/pdfs/pdf_open_parameters.pdf", destination: destination)
    .progress { bytesRead, totalBytesRead, totalBytesExpectedToRead in
        print(totalBytesRead)
    }
    .response { request, response, _, error in
        print(response)
        print("fileURL: \(destination(NSURL(string: "")!, response))")
}

This should always give you the right value, as long as your directory and domain are valid on iOS. If not, you'll get the temporary location which is actually accurate as well. If you truly want full control over where the file is moved to, don't use the suggestedDownloadDestination method and use your own custom destination closure that returns the fileURL you want.

I 've tried this :
    func generatefilePath(url:String)->(success: Bool, path: NSURL){
...
        if (fileManager.fileExistsAtPath(filePath)) {
            return (true, NSURL(string: filePath)!);
        } else {
            return (false,  NSURL(string: filePath)!)
        }
    }

and this how I call my download function :
        let filePath = generatefilePath("...");
let destination = filePath.path;

                Alamofire.download(.GET, "...", destination: destination) ...

But I get this error at Alamofire.download line :

Type of expression is ambiguous without more context

I' resolved this problem it was caused by (fileUrl?.path)! not by destination function as I thought first time

@cnoon after downloading finished when I check if file exist at the given path I can't find it.
Header when finishing download :
Optional(<NSHTTPURLResponse: 0x7fca1b230910> { URL: https://dl.dropboxusercontent.com/u/70441529/NWADER%20-%2023.pdf } { status code: 200, headers {
    "Accept-Ranges" = bytes;
    "Cache-Control" = "max-age=0";
    "Content-Disposition" = "inline; filename=\"NWADER - 23.pdf\"; filename*=UTF-8''NWADER%20-%2023.pdf";
    "Content-Length" = 75449827;
    "Content-Type" = "application/pdf";
    Date = "Sat, 07 Nov 2015 12:27:46 GMT";
    Etag = 2894n;
    Pragma = public;
    Server = nginx;
    "Set-Cookie" = "uc_session=frshBchxeZ34Ln9tiirQoBO4kq9zIkqvaHq9jaaO9EL0e4jJmkDtltTKx6oPj3XL; Domain=dropboxusercontent.com; httponly; Path=/; secure";
    "content-security-policy" = "; referrer no-referrer;";
    "x-content-security-policy" = "; referrer no-referrer;";
    "x-dropbox-request-id" = c24b832d5e45aab36abaaf5e809670b8;
    "x-robots-tag" = "noindex, nofollow, noimageindex";
    "x-server-response-time" = 516;
    "x-webkit-csp" = "; referrer no-referrer;";
} })

do you have an idea why I can't find the downloaded file ?

The downloaded file path isn't going to be in the header. You need to load the data using the NSData initializer to load the contents of fileURL. Then you'll be in business.

@cnoon Thanks!

you'll need to pass the response to the destination closure in your response closure to figure out where the file was moved.
Say again??? pass response to destination? How?

Nevermind, I finally wrapped my head around these closures.
var localPath: NSURL?
Alamofire.download(.GET,
    "http://jplayer.org/video/m4v/Big_Buck_Bunny_Trailer.m4v",
    destination: { (temporaryURL, response) in
        let directoryURL = NSFileManager.defaultManager().URLsForDirectory(.DocumentDirectory, inDomains: .UserDomainMask)[0]
        let pathComponent = response.suggestedFilename

        localPath = directoryURL.URLByAppendingPathComponent(pathComponent!)
        return localPath!

})
    .response { (request, response, _, error) in
        print(response)
        print("Downloaded file to \(localPath!)")
}

However, I can't understand why you are working with closures to set a download url. Seems like overkill.

The issue for me was that the file is downloaded but then moved to temp location,  not the one I passed, and that due to the path is not valid a folder missing so I had to create that folder before

The file isn't moved into the temp location @chlebta, that's where the data is written while the download is in progress. Once completed, it will attempt to move the new file to the location provided in the destination closure. You need to make sure your folder structure is in place before attempting to move the temp file to it's final location.


Double clicking a table cannot make its temporary opened tab permanent

Storage Explorer Version: 1.25.0-dev
Build Number: 20220608.1
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Monterey 12.4 (Apple M1 Pro)
Architecture ia32\x64
How Found: From running test cases
Regression From: Previous release (1.24.2)
Steps to Reproduce

Expand one storage account -> Tables.
Select one table -> Click it to open a temporary tab.
Double click the table -> Check whether the temporary tab becomes permanent.

Expected Experience
The temporary tab becomes permanent.
Actual Experience
The temporary tab doesn't become permanent.
Additional Context

Click 'Open' can't make temporary tab becomes permanent.
Click 'OLD Open' can make temporary tab becomes permanent.

This issue is not specific to table nodes. Marking as duplicate of #5747.


support for tokens contracts taking fee on transferFrom

Issue Type

[ ] bug report
[x] feature request

Current Behavior

Depositing DGX into the chain credits user with amount on plasma chain, while root contract balance is increased only by amount - fee. This causes chain to be insolvent for DGX token.
Expected Behavior

Account for the fact that token may extract such a fee and rely not on declared amount, but on actual change of balance of root chain contract.

Apparently, this behavior might be against ERC20 standard (or at least against its idea). It would be nice if we could ignore the misbehaving token.

Attempting to confirm whether or not this is against spec. Either way, we would still need to execute a balance check before and after the transfer to watch for this behavior. We could ignore this entirely, but that seems like it could lead to poor UX.


Add authz and feegrant messages to default types

authz and feegrant were added to the code generator already. They add the new message types:

cosmos.authz.v1beta1.MsgGrant
cosmos.authz.v1beta1.MsgExec
cosmos.authz.v1beta1.MsgRevoke
cosmos.feegrant.v1beta1.MsgGrantAllowance
cosmos.feegrant.v1beta1.MsgRevokeAllowance

They should be added to the Stargate registry.
For the AminoTypes it seems like no Amino JSON signing is implemented on-chain. So we should create a specific error message for that, explaining why it does not work.

This should make https://github.com/cosmos/composer/blob/master/react/src/redux/action-creator/wallet.ts#L59-L60 unnecessary.

Reopening because this part is missing:

we should create a specific error message for that, explaining why it does not work.

We should add an implementation to https://github.com/cosmos/cosmjs/blob/main/packages/stargate/src/aminotypes.ts#L67-L511 for the new message types where both toAmino and fromAmino are implemented by throwing this error: "This message type cannot be signed using the Amino JSON sign mode because this is not implemented on-chain."

I added the error in #1039 , but wonder how I should do the fromAmino() , what's the aminoType of those new added protobuf urls? @webmaster128

I have a question around the not implemented aminoTypes. That also means, that signing those kind of messages won't work with a ledger device, since it seems that when using a ledger it requires the amino signer?

All right, I've tested some things and it seems possible to do it, as long as CosmJS allows for truly custom encoding/decoding when using Amino.
Context
Currently x/authz messages do support Amino encoding, but in a very custom way. They don't have the classic JSON message structure (with the type and value field), and instead they put the value as the entire JSON object.
Instead of having something like this:
{
  "type": "cosmos/MsgGrant",
  "value": {
    "grant":{
      "authorization":{},
      "expiration":"2023-02-17T15:37:29Z"
    },
    "grantee":"desmos1gedewhj0qpm55yc359e6qd36wkl9jvnp3zk90h",
    "granter":"desmos1vxe0qadrgpg52zk03k5r29wd9jt59ej664t2yl"
  }
}

We have something like this:
{
  "grant":{
    "authorization":{},
    "expiration":"2023-02-17T15:37:29Z"
  },
  "grantee":"desmos1gedewhj0qpm55yc359e6qd36wkl9jvnp3zk90h",
  "granter":"desmos1vxe0qadrgpg52zk03k5r29wd9jt59ej664t2yl"
}

Possible solution
Once possible solution is to define the following converter:
export const cosmosTypes: Record<string, AminoConverter> = {
  // Authz types
  "/cosmos.authz.v1beta1.MsgGrant": {
    aminoType: "",
    toAmino: (value: MsgGrant): AminoMsgGrant => {
      return {
        grant: value.grant ? convertGrant(value.grant) : undefined,
        granter: value.granter,
        grantee: value.grantee,
      };
    },
    fromAmino: (msg: AminoMsgGrant): MsgGrant => {
      return MsgGrant.fromPartial({
        grant: msg.grant ? convertAminoGrant(msg.grant) : undefined,
        granter: msg.granter,
        grantee: msg.grantee,
      });
    },
  },
};

The problem with this is that (after testing it), I've found out that CosmJS automatically puts everything that is returned here inside the value object, and then uses the specified aminoType as the type field value.
I think that by applying the following changes to CosmJS everything could be implemented properly:

allow aminoType to be undefined (or a custom type explicitly telling that this is a custom encoding - maybe something like Exclude or else)
during the encoding, if the aminoType value is saying the encoding should be custom, do not build the default { "type": "", "value: {} } object. Instead, use the value returned by the toAmino as the entire JSON object to be used.

If I'm not mistaken, the reason we have weird amino encoding for authz/feegrant is because we forgot to add the RegisterLegacyAminoCodec function.
We can definitely add RegisterLegacyAminoCodec for authz/feegrant in v0.46. But CosmJS must detect the SDK version, and throw an error for <0.46.

Ah, there you go. Great timing. Are you okay to create an issue on the SDK @amaurym ?

I would appreciate a solution that is consistent with the current Amino JSON framework. The lack of a type identifier makes it impossibe to do the reverse conversion (Amino JSON -> proto) and would requires us to change a lot of architecture and probably break caller code.

We can track this issue on the SDK here: https://github.com/cosmos/cosmos-sdk/issues/11190. There's also a draft PR https://github.com/cosmos/cosmos-sdk/pull/11214.

Note that this will be only available starting on v0.46.

That's fine with me. CosmJS users can change the configuration of the AminoTypes class in their application to adapt it to their backend. And then at some point the authz messages just get integrated by default assuming a 0.46+ backend. Then they can still be overriden by 0.45 projects.
For now we'll just change the term "not implemented on chain" to "not supported on chain" in #1039 and consider a non-compliant implementation "not supported".

By the way, @amaurym, thank you for implementing Amino JSON sign mode for the new types. I have the impression this will make many people very happy and help the adotion of the new functionality.

This discussion has been summarized in https://medium.com/confio/authz-and-ledger-signing-an-executive-summary-8754a0dc2a88 in order to educate the various stakeholder. The follow-up ticket is https://github.com/cosmos/cosmjs/issues/1092.


fix: correlation between columns w/o non-null row

Fixes an error when calculating the correlation between columns where there is no nonnull simultaneously for both columns, i.e.
when column A is non-null column B is null and vice versa.

Codecov Report
Base: 90.33% // Head: 90.32% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (906cf4b) compared to base (caf884b).
Patch coverage: 50.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1265      +/-   ##
===========================================
- Coverage    90.33%   90.32%   -0.02%
===========================================
  Files          185      185
  Lines         5693     5695       +2
===========================================
+ Hits          5143     5144       +1
- Misses         550      551       +1

Flag
Coverage Δ

py3.8-ubuntu-latest-pandas
90.32% <50.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...data_profiling/model/pandas/correlations_pandas.py
95.34% <50.00%> (-1.08%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Release latest tag as optional

Add the release tag latest as optional.
It gives the flexibility to release or re-release new container images without adding them as a latest tag.

Codecov Report
Patch and project coverage have no change.

Comparison is base (b26e067) 93.77% compared to head (58cb9b3) 93.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   93.77%   93.77%
=======================================
  Files          16       16
  Lines         610      610
=======================================
  Hits          572      572
  Misses         38       38

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.