[WIP] Better gemm support for cublas and cpu

Opening this up for review immediately.
These test pass on cpu and cuda for float32 and float64 datatypes:
https://github.com/tech-ascent/tech.compute/blob/master/src/tech/compute/verify/tensor.clj#L275

Please request reviews from the reviewers and other contributors

@tqchen:  I cannot request reviews via the normal gear next to the reviewers menu heading; I think this is an issue with project settings and my github handle's relationship with the project.
I am still working on this, step today is to handle transposed (i.e. strides are reversed from normal) and make sure the smaller of the 2 strides is 1.
@liangfu Sounds good, all good suggestions.

@liangfu:  ready for next review.

@cnuernber you can just request reviewers by at them, Thanks!

@masahi: Here is the PR from the thread if you would like to review.

@tqchen:  I modified the code.

Proper camel case and braces - done.
Moving utility functions out of main header - done with caveats:

I moved the utility functions into a details header similar to what boost does.  Moving them to a cc file would involve adding the file and modifying the cmake system to include 1 cc file.  This seems like a more heavyweight change especially for essentially 1 liners that someone who was auditing the gemm code would want to read; thus in a header near the gemm code makes the system, in my opinion, more discoverable.
I am trying to make the result as readable as possible and avoid modifying the build system for those short one liners.  Is there a more appropriate place to put these sort of helper functions than a separate cc file?
Please consider that the CallGemm function itself is a private utility function for each gemm implementation that has to be described in a header file as it is a template operator-based function.
In any case, I am happy to make more changes and ready for next review step.

@cnuernber What I mean by the private header is not about moving them to cc file, but instead put it under src/contrib/cblas/gemm_common.h, then you can include the header by using a relative path to the file.
There are other examples of private headers, e.g. https://github.com/dmlc/tvm/blob/master/src/lang/attr_functor.h
The general idea is that these headers can be used by TVM internally, but we do not intend to expose it to the users of TVM

@tqchen:  Got it, sorry for the misunderstanding.  Updated with your recommentation.
Anything else you would like I am happy to do :-).

@liangfu can you take another look and https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly

@liangfu: Addressed :-).  Ready for next round.

Thanks, @cnuernber for contributing and @liangfu for the reviews, this is now merged


When a work is withdrawn or deleted in ScholarSphere, remove the Open Access Link in RMD

Edited to include ScholarSphere's options for "withdrawn" and "deleted" works:
When a work is withdrawn or deleted in ScholarSphere, remove the Open Access Link in RMD. We'd like to remove Open Access Links with the source "ScholarSphere" if the work is withdrawn or deleted in ScholarSphere. This should apply to works deposited using the RMD OA workflow as well as works deposited directly in ScholarSphere.
There are also Open Access Links pointing to ScholarSphere that have OA Button or Unpaywall as the source. I don't think we don't need to remove these. OAB and Unpaywall should be removing them from their databases automatically, and the regular imports should pick that up. Right?

Probably the ideal way to achieve this would be to implement webhooks for these events in ScholarSphere. They wouldn't necessarily need to be able to handle really generalized use cases (unless we foresee other potential use cases for webhooks). So the implementation could be fairly simple and tailored to our one specific use case here.
Thoughts?

WDDLL

[ ] Endpoint for deleting open access locations.  This should accept a single ScholarSphere url to identify which OAL to delete.  We already have an APIToken model set up with a write_access attribute to fine-tune access controls, so we should be able to use this for authentication.  We don't need Swagger docs for this since we'll be using it internally.
[ ] https://github.com/psu-libraries/scholarsphere/issues/1656


Updates GoogleConsts.cs adding the new OpenIDConnect compliant  endPoints

This is in reference to issue #916
I did a quick test using the google plus API.   I was able to authenticate.
Waiting to hear from @jtattermusch  about any possible issues this may cause.

Google bot is confused   signed date Apr 24, 2014 20:43 PDT

It looks like you've already signed this CLA. If you'd like to edit your contact information, you may do so below.

The commits were authored by<EMAIL_ADDRESS>which I suspect is not the email address you signed the CLA with (or your github email address) - which looks like it's a gmail address, based on previous commits. Possibly amend these recent commits and repush?

Really didn't want my real gmail account public to spam.    Guess i can go sign it from that email

Well, I don't know which email address is your "real" one, but there's already an email address in the commit logs for the project. You might want to check https://help.github.com/articles/keeping-your-email-address-private/ and sign the CLA with that address...

I signed it now from<EMAIL_ADDRESS>see what it says to that :)

If the test worked, I think it should be fine (but I am not really knowledgeable about this).

I asked Naveen Agarwal about the end point difference a few months ago.   He would be a good person to double check with.

To me, this change looks reasonable but I'd like to hear other opinions as well as this change has the potential to break authentication with all google APIs. @jskeet  or @chrisdunelm?

@LindaLawton, for cleaner history, can you please rebase (git rebase -i) against the latest master so that there's just one commit in this PR?

Btw, it looks like Google auth library for Java is using the "old" URLs as well.
https://github.com/google/google-auth-library-java/blob/1993157c4699f4cb0c40ef227dd6d7c4bea7cea2/oauth2_http/java/com/google/auth/oauth2/OAuth2Utils.java
If we want to change that (does it actually have any real impact?), it would probably make sense to update Java and all other auth libraries too.

I am actually looking into adding the functionality to read directly from the discovery doc then we won't need the hard coded constants. (I did that in my own library)   Yes I also consider adding it to the Java library. I was going to check php as well that is the extent of the languages I feel comfortable with sending patch requests to.
I may contact naveen see if he can see any issues with updating the libraries. If this is the way forward it makes sense to me that we contact the contributors of the libraries and work with them on updating everything.
I will run that command on the request soon.

@jtattermusch as far as that command goes I am not exactly sure i understand what its supposed to do.   I ran it on my machine it says

Successfully rebased and updated refs/heads/master.

Then i tried to push it to my origin (which is my fork)  but it says that's up to date.     I think i need a little more direction from you as what i need to do beyond that.      Also can you tell me how you are seeing that there is more then one commit in a PR?
Most of my experience is with SVN using a Visual studio plugin so i am a Git novice.    Feel free to email me if you have time.

Looks like PHP lib is using the new endpoints they have them also hard coded in a file.
Python Library is also using the old endpoints.

Have we decided not to merge this?

Thanks for the reminder, Linda - nope, we certainly haven't decided that :)
Chris is going to write an integration test so that we can just double check that it won't break things, then hopefully we can merge before the imminent build.

Ok,  I am still learning Git here.    Its saying that master is behind me.   I don't want to over write the pull request while refreshing it.

This branch is 3 commits ahead, 2 commits behind google:master.

I suspect you should be able to do git rebase upstream/master (if upstream is the name of your upstream remote). Then you'll want to verify (with git log) that your branch is just "what's on upstream master, plus this one commit" and force push back to your master (git push -f origin master).
My personal preference is to do feature work in branches in my fork - then I can keep my local "master" branch in line with upstream/master, and rebase off that.

I think i may be getting better at this i understand most of what you just said.

$ git remote -v
origin  https://github.com/LindaLawton/google-api-dotnet-client (fetch)
origin  https://github.com/LindaLawton/google-api-dotnet-client (push)
upstream        https://github.com/google/google-api-dotnet-client.git (fetch)
upstream        https://github.com/google/google-api-dotnet-client.git (push)

I am sure that i made the change originally in a branch but I may have merged the branch to master before posting the pull request here.   If i understand you correctly that was my mistake.

Hooray - that output looks good. Now if you push to origin (with -f because you're "rewriting history") we should be able to see just one commit, which is the one we want, with a parent which is the current commit.

LOL I have no idea what any of this is doing but that was fun that it popped up here.

$ git push -f origin master
Counting objects: 7, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 628 bytes | 0 bytes/s, done.
Total 7 (delta 6), reused 0 (delta 0)
remote: Resolving deltas: 100% (6/6), completed with 6 local objects.
To https://github.com/LindaLawton/google-api-dotnet-client

291c086...10baefe master -> master (forced update)

Bingo - observe how it's now showing "1 commit" at the top of the page :)

Yeah and before there was two, kind of wonder what that was.
So now i am safe to make a new branch on my fork?  I have weekend plans for 888

You can make a new branch, but it would be best to then reset it to upstream/master so that when you push it the changes will be based off that rather than off this PR.

But then I am working on a branch on the actually project right?    Am even I allowed to do that?

Nope, you'd still push to your fork - but the parent commit of your change would be the commit from upstream, which is what you want.

OK wait...  I fork my repo which contains this pull request.    Then i do
git rebase upstream/master
Which rolls it back to what is currently in this repo. There by removing this pull request change.   Then assuming i change something i create a pull request on the branch this time and not merge it to my forks master.
Am I close?

No, you don't do another rebase - no need for that. (Nor are you creating a new fork - you're creating a new branch within the same repo.)
You run:
git checkout upstream/master -b other-feature

That will create a new branch on your local machine, with an initial HEAD of the current HEAD of this fork.
You do work, commit it, and then push it to origin (your fork). You can then create a new pull request with that branch.

You are a genius that worked.  Dummy test here  So now I have a branch on my fork that is actually a copy of what we currently have in this repo.
You know that's easier then the last time i tried to remember how to update my forks master to the HEAD of this repo.
Google is your friend:

What is HEAD?  You can think of the HEAD as the "current branch". When you switch branches with git checkout, the HEAD revision changes to point to the tip of the new branch.

Hi @LindaLawton, when I was learning about git, I found this video very helpful to give me a good mental model of what was going on with branches, HEAD, cloned repos, etc.

"Git For Ages 4 And Up"    OK might be just what i need.   I have been though quite a number of tutorials.   I haven't found "Git for old developers who used source safe for to long. "

Back to the code change...
I've just downloaded a fresh client credential from the developer console, and noticed that the auth and token URIs in the downloaded JSON are the URIs we currently have in this repo (ie without this PR).
Does anyone know why this would be? Why are the new URIs not being used here?
The credential JSON is:
{
  "installed":{
    "client_id":"...",
    "project_id":"...",
    "auth_uri":"https://accounts.google.com/o/oauth2/auth",
    "token_uri":"https://accounts.google.com/o/oauth2/token",
    "auth_provider_x509_cert_url":"https://www.googleapis.com/oauth2/v1/certs",
    "client_secret":"...",
    "redirect_uris":["urn:ietf:wg:oauth:2.0:oob","http://localhost"]
  }
}

@chrisdunelm: No idea I'm afraid. I suspect you'll need to ask internally for that...

@chrisdunelm   I say you ping Naveen Agarwal on that one it seams off.

@LindaLawton OK, thanks, I've asked Naveen

Can you guys internally spread the word around to the other libraries to see if they don't want to update their endpoints as well.      I am assuming you Googlie people have some kind of internal spam forum :)

Naveen has confirmed that https://accounts.google.com/.well-known/openid-configuration is the definitive source, and the developer console needs to be updated to return the correct URIs.
I'll create an integration test for this, then this PR can be merged.

Is it worth considering reading directly from the discovery doc rather than having hard coded consents.  This is what I have done in my own application.
I doubt that they will be changing often but it's worth considering.

@LindaLawton Sorry, just realised I changed the GoogleConsts.cs filename, so this PR can't merge. Would you be able to resolve the conflict and re-push, then I'll merge?

Yes, I take your point about reading from the discovery doc; but as you say, it's not urgent so not something to do now.

Tell me what you need me to do I will boot my laptop

@LindaLawton Just seen this, and noticed you've close it. Are you going to create a new PR? That will probably be simplest.

idea was to use the one Jon helped me make earlier.     Think i may need to update it to what ou have been changing today.

Ah, no reason to create a new one - this is already fine. I helped you create a new branch for what I thought would be a different PR to solve a different problem!

If i am going to help you guys i need to learn how to do this the right way :)


Signup fixes

[] After Login, update the progress bar to go to the 3rd step immediately after login,
[] There is a splash screen after login that should not show.
[] Show the welcome screen on signup.

I'm leaving the There is a splash screen after login that should not show  for later, as there are more critical errors  at the moment.

@TomasGonzalez please take a look:
https://app.birdeatsbug.com/sessions/RXO--ROV40qWUcqg3Rhc1?

@vldkh I fixed that already

You sure it is still happening?

@TomasGonzalez need to raise buttons up on this screen

@vldkh I don't think the buttons are wrong
in the design, the screen is too short to be able to see the behavior, @patpedrosa


Update Swagger Specification and Add Model Catalog

Overview
This pull request updates the swagger specification to be more in line with where the API has migrated to and updates it in anticipation of starting work on the model catalog.
A few API endpoints have been edited since the swagger spec was
written. The goal of this commit is to get the spec more in line with
how the API has been implemented and also eliminated some
inconsistencies.
Summary of endpoints updated:

Added Authentication tag and removed Organization
Removed boundaries model
Changed references to boundary to scene
Added band model
Added endpoints for tokens
Updated buckets endpoints to reflect bulk API implementation

Endpoints added to support model catalog

model endpoint for geoprocessing models
model tags endpoint to store tags
model category endpoints to store categories

Price has been omitted from the model and query parameters because we
be treating this as a catalog for a while before we add pricing information.
Testing Instructions

Inspect wireframes for model catalog search and detail pages
Load up swagger ui at localhost:9999 and review it

Closes #600 and #550

Cursory scan looks like you covered everything I mentioned, and I didn't find anything else.


I am always getting invalid credentials when trying to connect to https://chainfury.nbox.ai/ui/login

Steps:
Open https://chainfury.nbox.ai/ui/login with firefox/chrome/brave and fill with admin/admin

Hey Bill,
Regarding the issue with the admin credentials on https://chainfury.nbox.ai/ui/login, please note that they will not work since it is a demo app. Instead, you can try creating a new account and login using those credentials.
Alternatively, if you prefer, you can run the project on your local machine by following the steps outlined in the Readme.
I hope this information is helpful.

@vgulerianb I tried to create an acount then use it for aconnection adn i got the same issue

What error are you getting, can you share steps to reproduce the issue.
Also try to login using username(not email) and password

Oh this was the issue. Thanks @vgulerianb


Add default options when defining job_type

Currently there is no way to define job_type with optional options, we will have to define exact every option in template, this cause some issues: https://github.com/javan/whenever/commit/61275d7e076f1a488e74fb588cf226f84eb5ba76#commitcomment-3677817
For example:
job_type :foo, "script :arguments"

every 1.minute do
  foo "bar"
  foo "baz" arguments: ""
end

This generates cronlines as below:
* * * * * bash -l -c 'script bar :arguments' # BAD
* * * * * bash -l -c 'script baz' # What we want

This PR aims to provide extra feature to define default options that can help us preset options that are optional, to avoid wrong cronline generation.
job_type :foo, "script :arguments", arguments: ""
...

I'd love to know why this was closed, seems more intuitive to em


Add Apply

coverage: 95.337% (-0.5%) from 95.865% when pulling c1e8ba631931d8108c54e52e0f7fece491d656c8 on feature/apply into d30b8b561b98707033dda9a89d92e19186c8ba43 on main.


Integrate FedX into rdf4j

Move fedx codebase into rdf4j as a module org.eclipse.rdf4j.federated, under tools/.
CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20667

@jeenbroekstra in PR https://github.com/eclipse/rdf4j/pull/1622 I have succesfully tested to create a FedX federation in the RDF4J workbench. Currently however this is a bit cumbersome as the integration is not very tight (i.e. the federation binary is not bundled with the rdf4j-server war and moreover there does not exist a template).
In my manual test I basically added a binary jar to the server webapp, and created a federation repository in the file system. This example test was successful.
For the release and for our users I would however like to pursue a more tight integration, i.e. make the federation feature more out-of-box usable. What would be the steps from your perspective to make the federation available also in the rdf4j-server webapp? Do you think we can aim for this in the release?

Off the cuff I'd say that it's simply a matter of adding the dependency to the rdf4j-server's pom. Now that I think about it, we'll probably also need to add it to the bill of materials and to the rdf4j-runtime pom. I think we should deifnitely try and include that in the next release (we have some time anyway, at least another 4-6weeks before we can do a release as we'll need to finalize legal review for FedX as well as go through our own release review).

CQ has been approved! :tada:


image creation error

Hi,
I'm trying to install EYE through install.sh and getting the error:
--image eye.pvm
eye --image eye.pvm
ERROR: -g main: */2: Arithmetic: evaluation error: `int_overflow'

I have installed SWI-Prolog version 7.5.1

Hi Carsten,
Thanks for the observation and the error message is indeed not very clear.
The latest EYE is now showing
** ERROR ** EYE requires swipl with the GMP library installed e.g sudo apt
install libgmp-dev
Hope that helps.
-- https://josd.github.io/ http://josd.github.io/
On Tue, Mar 7, 2017 at 4:26 PM, Carsten Klee<EMAIL_ADDRESS>wrote:

Hi,
I'm trying to install EYE through install.sh and getting the error:
--image eye.pvm
eye --image eye.pvm
ERROR: -g main: */2: Arithmetic: evaluation error: `int_overflow'
I have installed SWI-Prolog version 7.5.1
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/josd/eye/issues/2, or mute the thread
https://github.com/notifications/unsubscribe-auth/AALzpFuN7E84AaFIuM42WU5MQuC4KjpBks5rjXc6gaJpZM4MVn7f
.

Thanks!


OracleSoa

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

No information provided - Closing


Full node WOFF2 support

@sapegin  In case you missed it: https://github.com/nfroidure/ttf2woff2
I'm going to add it to gulp-iconfont, thought you'd like to do it on grunt-webfont as well.

I’ll do it if I ever have time ;-)

I finally set it as an optionnal output and disabled per default since windows users seems to have some troubles with it.

As always ;-)


Puppet workflows have been validated in a realistic environment with DAP

Given:

an existing DAP deployment with at least one secret loaded
a Linux Puppet 6 server
a Windows Server 2012 R2 Puppet 6 agent

We will run through the following test flows with our Conjur Puppet module:

Create a host identity in Conjur with no annotations, and configure the Puppet module to connect directly to the follower (not through the follower LB) using Windows Registry / WinCred. Verify that the node can retrieve a secret. Record the server and agent IPs and the DAP audit log entries that are recorded for the authentication and secret retrieval actions.
Create a host identity in Conjur with restricted_to set to allow authentication requests from the agent IP, and configure the Puppet module to connect directly to the follower (not through the follower LB) using Windows Registry / WinCred. Verify that the node can retrieve a secret. Record the server and agent IPs and the DAP audit log entries that are recorded for the authentication and secret retrieval actions.
Create a host identity in Conjur with restricted_to set to allow authentication requests from an IP that is different from the agent IP, and configure the Puppet module to connect directly to the follower (not through the follower LB) using Windows Registry / WinCred. Verify that the node cannot retrieve a secret, and that the server gets a 401 from Conjur on the secret retrieval request. Record the server and agent IPs and the DAP audit log entries that are recorded for the authentication and secret retrieval actions.
Create a host identity in Conjur with empty CIDR restrictions, e.g. restricted_to: [], and configure the Puppet module to connect directly to the follower (not through the follower LB) using Windows Registry / WinCred. Verify that the node cannot retrieve a secret, and that the server gets a 401 from Conjur on the secret retrieval request. Record the server and agent IPs and the DAP audit log entries that are recorded for the authentication and secret retrieval actions.
Create a host identity in Conjur with restricted_to set to allow authentication requests from the agent IP and the follower LB IP, and configure the Puppet module to connect to the follower LB using Windows Registry / WinCred. Verify that the node can retrieve a secret. Record the server and agent IPs and the DAP audit log entries that are recorded for the authentication and secret retrieval actions.
Create a host identity in Conjur with no annotations, and configure the Puppet module to connect to the follower LB using Windows Registry / WinCred. Verify that the node can retrieve a secret. Record the server and agent IPs and the DAP audit log entries that are recorded for the authentication and secret retrieval actions.
Create a host identity in Conjur with restricted_to set to allow authentication requests from the agent IP only, and configure the Puppet module to connect to the follower LB using Windows Registry / WinCred. Verify that the node can retrieve a secret. Record the server and agent IPs and the DAP audit log entries that are recorded for the authentication and secret retrieval actions.
Create a host identity in Conjur with restricted_to set to allow authentication requests from the follower LB IP only, and configure the Puppet module to connect to the follower LB using Windows Registry / WinCred.  Verify that the node cannot retrieve a secret, and that the server gets a 401 from Conjur on the secret retrieval request. Record the server and agent IPs and the DAP audit log entries that are recorded for the authentication and secret retrieval actions.
Test case 9 is meant to test if it's possible to "try to fetch secret from node B with access token from node A", but I don't see how to set this up - so I've left it out for the moment.

We'll be provided with the DAP deployment environment to kick off this effort. So before you get started, you'll need the DAP admin creds and configuration info so that you can load policy to configure the Puppet hosts, etc.
Useful resources:

Conjur docs on setting restricted_to on hosts

Info required to run these tests:

Credentials and master cluster info for the admin Conjur user (so that you can load policy)
Conjur account
URL of DAP follower
URL of DAP follower LB, and its IP address
x509 CA certificate chain for the DAP follower (adding this bc I'm not sure if the cert we configure with varies based on going through LB or direct to follower)

To try to put this in a format that is easier to read than a wall of text, below is a tabular version of the test cases that assumes a policy similar to the following has been loaded (where {agent_ip}, {follower_lb_ip}, {invalid_ip} are replaced with valid values):
- !host
   id: host-with-no-restrictions

- !host
   id: host-restricted-to-agent-ip
   restricted_to: [ {agent_ip} ]

- !host
   id: host-restricted-to-invalid-ip
   restricted_to: [ {invalid_ip} ]

- !host
   id: host-restricted-to-follower-lb-ip
   restricted_to: [ {follower_lb_ip} ]

- !host
   id: host-restricted-to-agent-and-follower-lb-ips
   restricted_to: [ {agent_ip}, {follower_lb_ip} ]

- !host
   id: host-with-empty-restrictions
   restricted_to: []

In all of the test cases below, the Conjur configuration should be added to Windows Registry / WinCred on the Puppet agent.
In all of the test cases below, we should record the server and agent IPs and the DAP audit log entries that are recorded for the authentication and secret retrieval actions.

Test case
Host
Agent Connects
Expected result

1
host-with-no-restrictions
directly to follower
success

2
host-restricted-to-agent-ip
directly to follower
success

3
host-restricted-to-invalid-ip
directly to follower
401 on secret retrieval

4
host-with-empty-restrictions
directly to follower
401 on secret retrieval

5
host-restricted-to-agent-and-follower-lb-ips
through the follower LB
success

6
host-with-no-restrictions
through the follower LB
success

7
host-restricted-to-agent-ip
through the follower LB
success

8
host-restricted-to-follower-lb-ip
through the follower LB
401 on secret retrieval

Closing in favor of #207


About the input data shape and the data shape before network

Thanks for your working.
I see the dataset(Synapse) shape is slice×512×512, and with the process of load data, the shape is change to slice×457×457, I can understand this change which is adjust the spacing of 'X' and 'Y'. But before the data send to the network, I see the shape is changed to (2, 1, 64, 128, 128), I can understand some dim mean--(Batch, modality, slice, H, W), maybe I didn't understand it correctly, my question is:
① How to change the shape from slice×457×457 to 64, 128, 128, is it automatic?
② Is the shape accepted by the network must be (2, 1, 64, 128, 128)?
③ If I have other data whice shape is also slice×512×512 but not the abdomen CT(for example, the lungs), is it automatic change to the shape of (2, 1, 64, 128, 128) with the process of training?
④ If I have other data whice shape is not slice×512×512 (for example, 24×320×320), is it automatic change to the shape of (2, 1, 64, 128, 128) before send to the network? And, If not, how to change the shape(such 24×320×320) to fit the network?
Thanks.

1.64, 128, 128 is the crop sizes, which are random cropped from the complete data size（slice×457×457） each time the data is loaded.
You can set the set the data here, and you can set the shape as you want, for every time you load the single data, If the size of the data is not large enough to be cropped, it will pad the data.(for example the crop size is 64,128,128, but the image shape is 50,457,457, we will pad the size of 50),
https://github.com/282857341/nnFormer/blob/e69edc83c79a6a8ccbf634e0ffbdfc82077c277e/nnformer/run/default_configuration.py#L60
https://github.com/282857341/nnFormer/blob/e69edc83c79a6a8ccbf634e0ffbdfc82077c277e/nnformer/network_architecture/Swin_Unet_l_gelunorm.py#L922-L923


python 3 items

If being run on Python 3 then iteritems needs to be replaced with items in es_hyperneat.py and visualize.py (and probably others).
Is it possible to add a version checker and run the appropriate line of code based on that result?

You are more than welcome to change it to Python 3 compatible code or use a version checker -  I'm not sure if anybody is running Python 2 anymore for these kind of tasks.
Anyway, I'll approve the PR quickly if you make one :)


fix: Move getuserdetail function to initstate

closes #138
Signed-off-by: Talwinder kaur<EMAIL_ADDRESS>

Codecov Report
Base: 91.10% // Head: 91.10% // No change to project coverage :thumbsup:

Coverage data is based on head (3ad5d05) compared to base (5fdfe17).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   91.10%   91.10%
=======================================
  Files          38       38
  Lines        1270     1270
=======================================
  Hits         1157     1157
  Misses         67       67
  Partials       46       46

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Send controller: Remember the state of coin-dollar or dollar-coin between discoveries

in the latest build(157) it doesn't work


Node.js 0.12 Support

This is a tracking issue for when "official" 0.12 support comes to Express 4.x and 3.x. As of now, both 4.x and 3.x should not have issues on Node.js 0.12, but if they do, please open a new issue and they will be fixed, even before "official" support.
Official support arrives with 4.12.0 and 3.20.0

Not exactly sure what is happening here but express.js is failing on io.js and v0.12 when used within Ghost: https://travis-ci.org/halfdan/Ghost/builds/50824137
TypeError: Cannot set property 'cache-control' of undefined
      at ServerResponse.OutgoingMessage.setHeader (_http_outgoing.js:341:22)
      at ServerResponse.header (/home/travis/build/halfdan/Ghost/node_modules/express/lib/response.js:695:10)
      at ServerResponse.header (/home/travis/build/halfdan/Ghost/node_modules/express/lib/response.js:698:12)
      at Object.errors.error404 (/home/travis/build/halfdan/Ghost/core/server/errors/index.js:290:13)
      at Context.<anonymous> (/home/travis/build/halfdan/Ghost/core/test/unit/error_handling_spec.js:342:20)

The same code works with v0.10.
Also ref #2539

Here's a piece of code that shows the issue:
var express = require('express');
var res = express.response;
res.set({'cache-header': 'foo'});

Above code works in v0.10 but not in v0.12. Express version is latest 4.11.2.


Development v1.0.3

Creating pull request to test deployment of v1.0.3.

Ready to test next deployment.


Add possibility to override the method of cleaning a JpaTicketRegistry?

Hello,
I'm upgrading a CAS 4.0 setup to CAS 4.2 (RC2). I noticed that the RegistryCleaner is deprecated in favor for having an implementation directly in JpaTicketRegistry. However there isn't really a clean way to override that implementation. I would like to override
public void execute(final JobExecutionContext jobExecutionContext) throws JobExecutionException {
 ...
}

but the class JpaTicketRegistry is final.
 We have a RememberMePolicy of about 90 days. That is: people pretty much stay logged in even though they only log in once in a while. This means we have about 350.000 tickets in our database (with a lot of serialized Java objects). The call this.getTickets() in JpaTicketRegistry#execute():
final Collection<Ticket> ticketsToRemove = Collections2.filter(this.getTickets(), new Predicate<Ticket>() {
    @Override
    public boolean apply(@Nullable final Ticket ticket) {
       ...
    }
});

is assuming that all tickets will fit into memory. This is a bit presumptuous IMHO.

As a side question: why are most classes final in the CAS codebase? There have been quite a few times where I saw a certain protected method which I wanted to override, but I couldn't do that because the class was final.

No problem with me. Feel free to submit a patch.
As for why final, 2 reasons:

legacy
keeping something locked allows the project to make fair mods to the codebase knowing that it will not affect extensions for upgrades. It does have limiting factors, but ideally, it's best to know why something needs opening up rather than leaving everything open to begin with. I personally would want to know why you would want to extend xyz because that somewhat indicates that the project isn't delivering what u want to a certain extent.

I'd much rather see those extensions end up in CAS where appropriate. So, what do u plan tondonwuth your extension? And might it make sense to become part of CAS?

the ticket cleaning process has been moving around a good bit in 4.2 and 4.3. I know our intention is to make the ticket cleaner more efficient for JPA (see #1199 ) and not need to load all the tickets in memory.
For 4.2 currently it should be possible to disable the built-in JPA ticket cleaner by setting the startDelay to  zero or a negative value. https://github.com/Jasig/cas/blob/4.2.x/cas-server-support-jpa-ticket-registry/src/main/java/org/jasig/cas/ticket/registry/JpaTicketRegistry.java#L313 I would actually consider this currently to be a bug, but we should provide a flag to disable the built-in cleaner process for this use-case and other use cases needing to disable the cleaner process completely.

Speaking from memory, but I think the flag is built into 4.3. Gotta check.

Closing this for now.


Bug: Using RunWithContext leaks go routines in Wait/WaitWithJobs

Output of helm version: v3.15.2 (should be independent of the version)
Output of kubectl version:
Independent of kubectl version
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
Independent of cloud provider.
When using the RunWithContext method for Upgrade/Install while having wait/atomic/waitwithjobs set, a context cancellation does not lead to polling on the ready checks in Wait/WaitWithJobs.
This will not be an issue while using the helm binary, but surfaces when using the packages.
Below is an example of how I extended the kubeclient to handle the issue.
Link -> https://github.com/saisrikark/helm/pull/1
I am propagating the context to have PollUntilContextCancel cancel it on the next poll.

@saisrikark by looking at the PR this looks like a valid issue. Could you please

Create a PR into the upstream main
Drop a simple reproducer code snippet that can be used to test this out

@banjoh thank you for replying
Do take a look at the details requested in https://github.com/helm/helm/pull/13135

From memory, I think this is a dup (but I don't have time to try and find right now)

I have seen few PRs a long time back saying that they fix leaking go routine.
But go routines leaking due to the kubeclient has not been solved.
This issue is not visible to those using the binary. But reproducible by importing the package and calling the install and run methods.
Context has to be propagated to the kubeclient methods to enable stopping functionality.
Without that we cannot expect an exit from kubeclient methods when cancelled.


Feature request -> goto Feature.

Hi!
Another feature request. As far as I understand xiaomis hooks this should be possible…
Could you implement the "goto" feature?
Scenario; scheduled journey to the trash bin to empty the waste tank.
 This way all you have to do is stand there and lift the bin out? You haven't figured out a way to automate emptying it have you?
This is the next level of lazy but I like it. :)

I'm wondering if I could make it do this automatically when full, but it will just run out of battery waiting for you to come empty it and become stuck. But what you could do is set it up when your home to go to bin when full, maybe even make it keep saying the bin is full till you empty it.

…as far as I understand your plugin you´re using "https://github.com/aholstenson/miio" as
a underlying library. The "goto"-Feature must first be implemented into the "miio" Framework, correct? – (i wrote a feature request to the repo)

Shouldn't be an issue, just fork it and implement it myself. That way I'm not waiting on them. Should be a good little project

Interesting feature :-)
Add a camera to the robot and ask it go to the room where the alarm is triggered

I've add the go to feature, going to leave this ticket open. As it's not been tested so feedback would be great. Just add a 'target' parameter as described in Readme.
I also want to expand on this to include an option to make it speak. Need to figure out the API for that one.

tested it yesterday eve. Works!
kudos.
desq42


Any way to disable svgo by default?

LIke the title says. I would like to have the option to import svgs but without a svgo config (I like to tweak my svg's by hand)

No way now. Working on it.

@Antimated You can use ?raw to ignore this plugin. Like import svg from 'example.svg?raw'


[BUG] - NEXTUI CLI init fails on fresh install using Vite template

NextUI Version
0.5.1
Describe the bug

nextui init nextui-app -t vite

NextUI CLI v0.5.1
✔ Components data updated successfully!
┌  Create a new project
│
◇  Select a template (Enter to select)
│  Vite
│
◇  New project name (Enter to skip with default name)
│  nextui-app
│
◇  Select a package manager (Enter to select)
│  bun
│
◇  Template created successfully!
└  rename Error: Error: ENOENT: no such file or directory, rename 'D:\vite-template-main' -> 'D:\nextui-app'
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Tried with npx and npm install -g and with different package managers (bun/yarn)
Expected behavior
Expected the template to be created
Screenshots or Videos
No response
Operating System Version
Windows using Bash shell
Browser
Chrome

Sorry, wrong repo - created bug report here: https://github.com/nextui-org/nextui-cli/issues/128


Error creating uuu file using ObjParser

I'm trying to create a uuu file in objectron (object_detection_3d) using ObjParser. I tried to follow the documentation by writing the command:
bazel run -c opt mediapipe/graphs/object_detection_3d/obj_parser:ObjParser -- input_dir=[INTERMEDIATE_OUTPUT_DIR] output_dir=[OUTPUT_DIR]
But I get an error:
Error: Must provide input directory with --input_dir=
And if I change the command to something like this (removing the space between -- and input_dir=),
bazel run -c opt mediapipe/graphs/object_detection_3d/obj_parser:ObjParser --input_dir=[INTERMEDIATE_OUTPUT_DIR] output_dir=[OUTPUT_DIR]
I get an error message like this:
ERROR: --input_dir=/Users/bagus/mediapipe/output :: Unrecognized option: --input_dir=/Users/bagus/mediapipe/output

Hi @miftahulbagusp, Have you followed the steps mentioned over here

here

Yes, I followed the documentation that was there.

I tried to build from Java successfully, only error when build from bazel.

I tried to build from Java successfully, only error when build from bazel.
@miftahulbagusp
Can you list the command used for building directly via Java.

I tried to build from Java successfully, only error when build from bazel.
@miftahulbagusp
Can you list the command used for building directly via Java.

javac ObjParserMain.java
java ObjParserMain --input_dir=[INTERMEDIATE_OUTPUT_DIR] --output_dir=[OUTPUT_DIR]

If you use bazel run, which compiles then runs the app, you can pass the flags to the actual binary (not bazel) with --.
So it would look like bazel run  -- --input_dir=...

If you use bazel run, which compiles then runs the app, you can pass the flags to the actual binary (not bazel) with --.
So it would look like bazel run -- --input_dir=...

Thanks. It's worked well!


Network Security Assessment: Know Your Network by Chris McNab

https://github.com/nixawk/pentest-wiki/issues/13


Deep link stop working on device-resume.

phonegap-nfc conflict with branch-cordova-sdk plugin. Deep link on device-resume stop working if the app integrates with phonegap-nfc. Any solution will much appreciate.

¯_(ツ)_/¯ closing old issue


Introduce RVC TopK retrieval feature

I am planning to add TopK retrieval in this project.
@MaxMax2016 please suggest me, you already planned in Todo or shall I merge the change?
Thank you so much this wonderful project ☺

This project only fixes fatal errors, will not upgrade algorithms.


faild in Android Pie

i am using universal imageloader i.e working fine till oreo but now it is faild to load image in Pie
it is updated
implementation 'com.nostra13.universalimageloader:universal-image-loader:1.9.5'
right

Probably because of permissions. Will check.

@DineshBalayan @nostra13 Is this open? Can I work on this?

@MonikaJethani Sure. BTW I have no any issues on Pie :thinking:

Hi,
I also have a problem with Android P when I activate the StricMode policy to detect "non sdk api usage" and target sdk = 28.
			StrictMode.setVmPolicy(new StrictMode.VmPolicy.Builder() 					.detectNonSdkApiUsage() 					.penaltyLog() 					.build());
This will become a problem in some months, as Google will kill the apps using this.
Problem seems on this line in  ImageViewAware getImageViewFieldValue :
           Field field = ImageView.class.getDeclaredField(fieldName);


fix: correctly handle UI outline scale

Objective

The UI outline in the new dev tools does not handle scale correctly when the scale is not 1. It looks like the GlobalTransform already handles scale. Fix #12566
To reproduce make sure your screen scale is not 1 and run cargo run --example ui --features bevy/bevy_dev_tools
I'm not really familiar with Bevy UI internal so please review this carefully.

Solution

Dont apply window_scale when calculating LayoutRect scale

Question about UI Node with custom scale:

How do we expect the outline when the UI Node is spawn with custom transform
Eg: Transform::from_scale(Vec3::splat(1.5)). Related discussion in Discord https://discord.com/channels/691052431525675048/743663673393938453/1219575406986788864

Before

After

@pablo-lua I got the solution for Node that has custom transform like Transform::from_scale(Vec3::splat(2)). Should I include it in this PR or the follow up?

Include it in this PR or the follow up?

I'm not sure I understand the problem here. Maybe you can open a issue about it first? The problem is: When using ui nodes, we aren't expecting transforms to work: The transform is updated here, outside of user range of manipulation, So if you found some problem here, that can be a strange issue.
But, for sure, out of scope in this PR as we are fixing another problem.

I created the issue here https://github.com/bevyengine/bevy/issues/12576


babel-plugin-minify-simplify breaks logical order

I illustrated it here with a comparison of the beautified outputs with and without simplify.

I guess this is related to #305 . Can you try babili with passPerPreset: true.
From next version of babili, this option will be enabled by default for babili plugins.

Looks like that works.  What if I still wanted to pick and choose individual babili plugins?  Does this mean that I would need to package my selection up into a preset so that I could make use of the passPerPreset option?

Next version will have options with which you can enable/disable specific plugins - https://github.com/babel/babili/tree/master/packages/babel-preset-babili#options

Turns out it didn't work.  I noticed the same problem return this morning, so I think I made some sort of mistake when testing the fix, such that it was still using an older configuration with the simplify plugin removed.

@mavericken could you please paste an actual code (preferably as minimal as possible) that still has an issue with passPerPreset: true. Otherwise, we can't test it and figure out what exactly is wrong, or even confirm it in the first place.

I included babel-plugin-minify-simplify back into my project, but I can't replicate anymore.  I guess I'll close for now and reopen if I see it again.


[fix] address SBP fixes - part 2

Summary of changes
Changes introduced in this pull request:

Remove transactional macro
Handle all unsafe arithmetic and unwrap()

Reference issue to close (if applicable)
Closes https://github.com/webb-tools/protocol-substrate/pull/283

CI failing here @1xstj


Question: Can Facades be composed to allow for construction of more generic facades from more specified ones?

I want to define interfaces in terms of facades using them like requirements for injected classes. I'm wondering if I have a facade that implements a superset of the expected facade can use the bigger interface to construct the more generic one and if so is there a performance hit?

@spectre-ns

I'm wondering if I have a facade that implements a superset of the expected facade can use the bigger interface to construct the more generic one

Yes. You can use std::tuple to organize hierarchies of dispatch types (duplications allowed). See Highlight 4 in the blog post of this library:
struct D1;
struct D2;
struct D3;
struct FA : pro::facade<D1, D2, D3> {};
struct FB : pro::facade<D1, std::tuple<D3, D2>> {};
struct FC : pro::facade<std::tuple<D1, D2, D3>, D1, std::tuple<D2, D3>> {};

pro::proxy<FA>, pro::proxy<FB>, pro::proxy<FC> are equivalent in terms of functionality and runtime performance.

if so is there a performance hit?

No. Because flattening a hierarchy of dispatch types happens at compile-time, per the implementation in proxy.h.
Thank you for you comments! Please let us know if you have any further questions or suggestions!

I guess I'm not completely following the concept of the tuple in the facade. Is the tuple for FA saying that I have to have D1 in my interface but I can have either D2 or D3?

Also if I try to construct a proxy with another proxy does that work?

I'm trying to understand 4.2.2 Abstraction of "facade" from the paper. Do you have a working example?

@spectre-ns

Is the tuple for FA saying that I have to have D1 in my interface but I can have either D2 or D3?

No. All FA, FB and FC requires D1, D2 and D3 to apply. The semantics of FA, FB and FC is similar (but not equivalent) to:
struct BaseOfD1 {
  virtual XXX = 0;
  virtual ~BaseOfD1() {}
};
struct BaseOfD2 {
  virtual XXX = 0;
  virtual ~BaseOfD2() {}
};
struct BaseOfD3 {
  virtual XXX = 0;
  virtual ~BaseOfD3() {}
};
struct DerivedOfFA : BaseOfD1, BaseOfD2, BaseOfD3 {};
struct DerivedOfD2AndD3 : BaseOfD2, BaseOfD3 {};
struct DerivedOfFB : BaseOfD1, DerivedOfD2AndD3 {};
struct DerivedOfFC : DerivedOfFA, DerivedOfD2AndD3 {};

Also if I try to construct a proxy with another proxy does that work?

No. Because we found implementing this feature will increase binary size of client code, no matter upcast is actually being used or not, this violates the zero-overhead principle. For example, in the code above, the size of VTABLE of DerivedOfFC and DerivedOfFB is expected to be larger than DerivedOfFA, regardless of the vendor of the compiler, which does not apply to proxy. In fact, we found upcasting is important in inheritance-based polymorphism mostly because it is "intrusive". With the non-intrusive approach of proxy, we believe the motivation becomes trivial comparing to the impact on performance.

I'm trying to understand 4.2.2 Abstraction of "facade" from the paper. Do you have a working example?

We do have an example in our tests proxy_invocation_tests.cpp, but maybe we should consider adding a sample for this feature in samples.

Thanks, just to summarize.

This library implemented single level inheritance primarily?
Upcasting (converting derived to it's base) is actually intrusive and not good design?

I would be interested to hear more about number 2. I would never have guessed that. Closing as you've answered my original question.

@spectre-ns

This library implemented single level inheritance primarily?

That is true from usability perspective. Technically, this proxy implemented duck typing rather than inheritance. They represent different paradigms.

Upcasting (converting derived to it's base) is actually intrusive and not good design?

Yes. This is one of the motivations of this library. As per Sean Parent's summary: "The requirements of a polymorphic type, by definition, comes from its use, and there are no polymorphic types, only polymorphic use of similar types. Inheritance is the base class of evil." If we use upcasting for abstraction, it is required to define the base types before we actually use the types polymorphically. Using proxy will escape this limitation.


fix: reset prompt state upon exiting watch mode (issue #15)

This PR aims to fix issue #15 , where we need to enter one more time after exiting from watch mode to reset dicedb cli.

@arpitbbhayani Please review and let me know if there is a better way.

@vpsinghg can you please rebase the changes with master?

@arpitbbhayani I have rebased with master

@arpitbbhayani Can you please review the changes?

@vpsinghg please rebase once with master.


Can't create webpack module with dependOn for import

Hello. I would like to create three entry points with, on of them is shared.
I'm trying to use dependOn entry option. When i will have been added dependOn into entry, entry format changed.
Run code like this in my frontend application:
import * as X from 'module'; console.log(X);

And see for module with dependOn: :

Also for module without dependOn: :

I don't understand, how to right use dependOn for share some code between entris, because when i use it, i will see the import problem described above. Anyone could help, and explain how do it right? I can contribute into examples.
My reproducible example - https://github.com/lavcraft/react-hooks-composition-in-webpack-entry-problem-example
PS: I'm tried differente entry.library.type - all produce different kind of errors. Screenshots above made with entry.library.type: 'this' for debug purposes.

@vankop could it be a bug?
I think, in additional to webpackChunk_company_sdk this import should contain exports from this module (useDevices, withDevices in my example)

dependOn means that parent entry is loaded already, so in case:
entry A depends on entry B

when executing entry A all modules from entry B already loaded and presented in modules cache.
but I'm afraid this option does not work well with libraries, only for bundling application code.

@vankop thanks. It's interesting, may be somebody can explain this and prove - this  a bug or not.
@sokra could you help me with this question?

@lavcraft Why you need dependOn for libraries, I don't see any reasons for that

@alexander-akait thanks for question.
In a nutshell i demonstrate problem in this example.
Some details and history

I have a project with sdk and subprojects who use this sdk and shared project (shared between sdk, ui and backend).
1.1. shared project included to ui project as builded dependency as a npm package. (For test purpose. Dogfood this package before distribute to external project)
1.2 shared project included to backend and sdk projects as typescript project reference

That's mean i need to build my sdk with tool, which support typescript and project references.
At first, i built this via rollup with some hacks and separated tsc process. But it's not reliable way and depended on build call order. Also it's not simply development process
In this configuration i have problem with typescript paths and aliases.
My next step - try other build systems for packaging sdk. I chose webpack , because ts-loader is good integrated with typescript and working good with project reference.
After build sdk with webpack, new problem will appear. This problem have a good explanation by @gaearon in react issues.
In short:

SDK must have a two different endpoints for avoiding load code, which not support SSR (external WebRTC sdk).
1.1 First endpoint contain useCall() hook with references to files which import external WebRTC packages.
1.2 Second endpoint contain useDevices() hook, which can be used in a lot of pages without full WebRTC call
But useDevices also required in useCall() for obtain current devices. And it's problem, because

withCall(withDevices(component)):
  useDevices() <-- return devices
   useCall()
     useDevices()  <-- return undefined, because React.useContext(DevicesContext) check references via equals, and in isolated webpack modules contain independent instance of this.

From this point i start trying to resolve this problem via dependOn and share logic between two endpoints. May there is a more suitable way to solve this, but i couldn't find it now :(

Usually what you should do is extract the shared part into a separate bundle, and then use externals to prevent it from being copied into other bundles.

@gaearon right, i understand it. Thanks for this workaround. I prefer to see things through :) And i believe, if some tool have ability - it should works unless in docs not specified that it doesn't work :)
In this case, in my opinion, webpack should work with dependOn for library mode. It can simplify projects and provide ability to share code between entrypoints. Believe that webpack can be a best tool for build libraries and ready to try fix some problems with it

@gaearon @alexander-akait tried this way. But nothing changed.
Push reproducible results into branch depends-on-experiments
Also comment in this thread - https://github.com/facebook/react/issues/24230#issuecomment-1086978269


Add Levenshtein distance ranking

https://en.wikipedia.org/wiki/Levenshtein_distance
https://en.wikibooks.org/wiki/Algorithm_Implementation/Strings/Levenshtein_distance#C

https://github.com/renstrom/fuzzysearch/commit/b23ef2673aeac23acd1a65786743a4a26696cdfc


By how does ioredis support zlexcount？

As my project meet the demand of using zlexcount, a very old yet not so frequently used feature of redis, I noticed that seems like ioredis does not have it as a well packed method, which forcing me to use eval() to call it in an ugly way (it works, just you know):
const Z_LEX_COUNT = return redis.call('zlexcount', KEYS[1], ARGV[1], '+');;
redis.eval(Z_LEX_COUNT, 1, key, [${id});
However zlexcount is a feature added to redis in 2.8.9, so it would by very suprising to me if ioredis does not have it by far. I'm wondering did I missed anything?
Any help or discussion will be appreciated (No better redis support can be found elsewhere anyway).

try redis.zlexcount(key, '-', '+');

try redis.zlexcount(key, '-', '+');

Of course this would be my first choice as what I tried in the beginning. However it told me zlexcount does not exist on type Redis

This is a typescript types issue see #1053
For now, you can use any of the blow

(redis as any).zlexcount(key, '-', '+');
const redis = new Redis() as any;
// @ts-ignore

This is a typescript types issue see #1053
For now, you can use any of the blow

(redis as any).zlexcount(key, '-', '+');
const redis = new Redis() as any;
// @ts-ignore

I see, thank you for the information. Have a nice day~


Add support for Windows OVS Containerisation in Install-OVS script

For #4952

I am a bit confused on the parameter "ContaineriseOVS", it looks when the flag is set as $true, no usespace processes is installed. Instead, when it is set as "$false", the OVS usespace service are installed. If this is your idea, I would prefer to modify this parameter with something like "InstallUserspace", and the default value is $true. The steps to install OVS userspace processes are ignored only when its value is set as $false.

I used the parameter name containeriseOVS so that user can decide whether they want to run ovs processes inside Container or on the host , hence the default value is false.When true it does not install the processes and user can then apply the updated antrea-windows-containerd.yaml to run these processes inside the container.I have updated relevant information in the windows.md doc file and in the comments section in Install OVS script.

I used the parameter name containeriseOVS so that user can decide whether they want to run ovs processes inside Container or on the host , hence the default value is false.When true it does not install the processes and user can then apply the updated antrea-windows-containerd.yaml to run these processes inside the container.I have updated relevant information in the windows.md doc file and in the comments section in Install OVS script.

I got your idea, but my point is a parameter should always tell what to do but not "what not to do". The parameter "ContaineriseOVS" is telling the script not to install OVS Services. That is strange. So I suggested to use paramter to tell the script to install service with a default value $true.

I got your idea, but my point is a parameter should always tell what to do but not "what not to do". The parameter "ContaineriseOVS" is telling the script not to install OVS Services. That is strange. So I suggested to use paramter to tell the script to install service with a default value $true.

Okay  I got your point. I have made the changes. Can you check whether anything else needs to be changed

@XinShuYang  in last sync meeting,  you mentioned that there are three PRs need to be merged into one to pass CI tests, could you point out the PR numbers? thanks.

@luolanzone
https://github.com/antrea-io/antrea/pull/5055
https://github.com/antrea-io/antrea/pull/5052
https://github.com/antrea-io/antrea/pull/4936
All these PRs are for the issue https://github.com/antrea-io/antrea/issues/4952
cc @rajnkamr

LGTM, but this PR should be combined with #5052 and #4936 before merging since the doc change involves ovs support in container, which is not supported by this single PR. cc @rajnkamr

@wenyingd Anything else that needs to be changed in this patch?

@jianjuns This PR ha been merged with the PR here and changes according to your comments have been made here itself.


TriggersExit not firing again after "stop()"ped

the titles sums it up - I'm unable to have my triggersExit function fire again, after it has been stopped.
this is my code
FlowRouter.route('/lobby/:id', {
	name:'lobby',
	action() {
		BlazeLayout.render('default_layout', {content:'lobby'})
	},
	triggersExit:[(context, redirect, stop) => {
		if(context.params.id
		&& Lobbies.findOne({_id:context.params.id, state:{$ne:2}}))
			if(!confirm(`The lobby isn't over.\n\n Are you sure you want to leave this page?`))
				stop()
	}]
})

The trigger is fired the first time I try to leave the route, but won't trigger again before I navigate away from the route or refresh.
I'm not sure if this is a bug, or if I'm approaching this the wrong way :)

I had a previous solution before running into this problem:
Lobby.onCreated(function() {
...
    FlowRouter.triggers.exit([(context, redirect, stop) => {
        if(this.lobbyId && Lobbies.findOne({_id:this.lobbyId, state:{$ne:2}}))
            if(!confirm(`The veto isn't over.\n\nAre you sure you want to leave this page?`))
		stop()
    }], {only:['lobby']})
...
})

however, this solution threw an exception because stop was undefined sometimes... Which is why I refactored in the first place.

triggersExit only runs once before you exit your page. It's not reactive.

I click on something, it triggers, but I stop() it. now I'm still on the same route, but if I click to navigate away, it doesn't trigger again.
Isn't this a bug?

I hope this can either be accepted as a bug or dismissed as a misunderstanding on my part :)
I find it quite logical that triggersExit should run a 2nd time, if I stop() it the first time, and don't navigate away

@arunoda: so the problem is that after stop is called, flow-router thinks that we are on the new route. This aspect is not properly handled by the commit which introduces stop: https://github.com/kadirahq/flow-router/commit/cc8b8811a2f44f65c3c91dee839d40b5fe7ac67c

So I have a partial fix which is rather hackish and leaves repeated history entries. I can make a PR but. @arunoda will probably need to fix it up given my experience with flow-router's source is just a few hours.

Fix here: https://github.com/kadirahq/flow-router/pull/679

Fixed relatively comprehensively here: https://github.com/kadirahq/flow-router/pull/681


Heighliner should have compatiblity with Ignite client builds.

There should be an additional language: ignite

Closing as stale


Fix set text can not update error

Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Codecov Report

Merging #1040 (dd0ce99) into main (3e1428c) will decrease coverage by 0.04%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##             main    #1040      +/-   ##
==========================================
- Coverage   33.67%   33.63%   -0.05%
==========================================
  Files         334      334
  Lines       14454    14454
  Branches     2215     2215
==========================================
- Hits         4868     4862       -6
- Misses       9060     9061       +1
- Partials      526      531       +5

Impacted Files
Coverage Δ

packages/core/src/2d/text/TextRenderer.ts
10.04% <37.50%> (ø)

packages/core/src/DisorderedArray.ts
15.00% <0.00%> (-10.00%)
:arrow_down:

packages/math/src/Color.ts
85.71% <0.00%> (-7.15%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[VL][UT] Fix scalar-subquery-select.sql in spark35

What changes were proposed in this pull request?
Currently in the gluten-ut of spark35, scalar-subquery-select.sql and scalar-subquery-select.sql.out were directly copied from spark34. However, these two files have changed in spark 3.5 version and cannot be used as-is from spark34. They need to be modified to match the spark 3.5 version.
How was this patch tested?
N/A

cc @yma11, thanks.

related: https://github.com/apache/incubator-gluten/issues/5341

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_5425_time.csv
log/native_master_04_16_2024_33d183203_time.csv
difference
percentage

q1
38.25
38.05
-0.199
99.48%

q2
23.88
24.39
0.514
102.15%

q3
39.15
37.50
-1.646
95.80%

q4
39.49
38.79
-0.694
98.24%

q5
69.80
70.62
0.821
101.18%

q6
7.23
9.68
2.452
133.93%

q7
81.87
83.76
1.890
102.31%

q8
87.03
86.47
-0.558
99.36%

q9
122.69
124.25
1.563
101.27%

q10
43.17
47.10
3.938
109.12%

q11
19.49
20.01
0.521
102.67%

q12
30.95
30.02
-0.928
97.00%

q13
55.66
53.95
-1.707
96.93%

q14
18.14
17.11
-1.031
94.32%

q15
30.24
29.43
-0.816
97.30%

q16
13.79
13.85
0.055
100.40%

q17
100.23
101.18
0.946
100.94%

q18
142.44
144.50
2.052
101.44%

q19
15.09
16.75
1.658
110.99%

q20
26.36
26.88
0.522
101.98%

q21
284.84
287.81
2.964
101.04%

q22
14.37
16.10
1.724
111.99%

total
1304.15
1318.19
14.040
101.08%

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_master_04_17_2024_time.csv
log/native_master_04_16_2024_33d183203_time.csv
difference
percentage

q1
36.61
38.05
1.440
103.93%

q2
24.12
24.39
0.272
101.13%

q3
37.01
37.50
0.490
101.32%

q4
38.03
38.79
0.762
102.00%

q5
70.92
70.62
-0.298
99.58%

q6
5.81
9.68
3.867
166.53%

q7
86.12
83.76
-2.356
97.26%

q8
82.86
86.47
3.614
104.36%

q9
123.45
124.25
0.800
100.65%

q10
45.70
47.10
1.405
103.07%

q11
20.35
20.01
-0.338
98.34%

q12
28.15
30.02
1.874
106.66%

q13
54.46
53.95
-0.507
99.07%

q14
17.88
17.11
-0.768
95.70%

q15
30.69
29.43
-1.263
95.88%

q16
14.00
13.85
-0.152
98.91%

q17
101.27
101.18
-0.095
99.91%

q18
143.83
144.50
0.670
100.47%

q19
13.61
16.75
3.130
122.99%

q20
27.86
26.88
-0.983
96.47%

q21
285.86
287.81
1.943
100.68%

q22
14.42
16.10
1.674
111.61%

total
1303.01
1318.19
15.179
101.16%

@liujiayi771 thanks for taking care of this, did you check other files? Is this the only change in SQLQuerySuite?
thanks,
-yuan

@zhouyuan For the overwrite sql, this file is the only change.


Improve winget upgrade --all with installer mismatch

Description of the new feature / enhancement
When I run winget upgrade --all and one of the packages can't be upgraded due to the installer type being different from what is currently on the system I don't get informed.
The scenario is described in the Ed Tittel's blog.
Proposed technical implementation details
The upgrade flow should inform me about the installer type change as displayed by winget upgrade <package> when this situation occurs.

[Policy] Area-Output
[Policy] Command-Upgrade


Add documentation on HOST_key=value labels

Not stale, but updating title since we don't use HOST_ as the prefix anymore

Documented in two places now, yay:

https://wasmcloud.com/docs/deployment/hosts/labels
https://wasmcloud.com/docs/reference/host-config


[Question] running total

Is it possible in AQL to write a query with a running total?
Let's say I have 4 documents with a price field.
{ price: 1 },
{ price: 3 },
{ price: 5 },
{ price: 7 }

I want the result set to show me the running total
{ price: 1, runningTotal: 1 },
{ price: 3, runningTotal: 4 },  /* 1 + 3 */
{ price: 5, runningTotal: 9 },  /* 1 + 3 + 5 */
{ price: 7, runningTotal: 16 }  /* 1 + 3 + 5 + 7 */

I also need to filter on that running total, so for example - I want to fetch products that add up to $10

Please have a look here: [Google Groups] How to design a query that needs to limit at a value of a sum

Hi @gamedev8,
did you already have a look at the listed Google Groups post? Does it help you or do you have any further questions?

Is the order of the records of any importance? If there's no ORDER / SORT clause, aren't the results unpredictable and may change between any two runs of the query against the same data? At least it's not guaranteed.
What is the purpose of selecting an unknown number of records more or less arbitrarily like this for your use case?

Sorry - Yes the order is very important.

I see. While there is a way to add up prices on the fly (non-holistic) with COLLECT AGGREGATE x = SUM(s.price), there is no support for stopping dynamically once a condition is no longer met at present. LIMIT accepts number literals and numeric bind parameters only at present. 3.4 also allows expressions, as long as they can be resolved to constant values at query compile time. This does not help your use case however.
It seems similar to #3979 which is about pruning/purging paths in graph traversal, in the sense that one wants a way to express conditions which should always be evaluated on-the-fly instead of being applied as post-filter. In my understanding, we currently have the FILTER keyword with two meanings depending on the query at hand and the available optimizations (at least in graph traversal).
With your use case in mind, a dynamic version of LIMIT would work hypothetically. But I can imagine that it's difficult to implement, and especially to make this work fast and also in clusters.

Retrieving the top n products and returning them "flat" should already be possible with a query like this:
FOR c IN ["A", "B", "C"]
  FOR topTwo IN ( FOR doc IN coll FILTER doc.category == c SORT doc.rank LIMIT 2 RETURN doc )
    RETURN topTwo

The rank field is actually not part of the data it would be dynamic. Based on some user criteria like lowest price, or highest user rating, etc.


Update file permissions for "{{ gitea_home }}"

The file permissions for {{ gitea_home }} especially in conjunction with the recurse: true flag are on closer inspection very open to all and also have a +x set on files.
This should be done better. And I have done here now.
By the way: To improve the -x on normal files in his gitea installation this shell command was useful for me
find . -type f -exec chmod a-x {} \+;
find . -type f -exec chmod u=rwX {} \+;
 find repositories/ -type f -path '*/hooks/*' -exec chmod u+x {} \+

Right well spotted ! Thank you :)


custom component

Hi,
You have here an example on how to create a custom component.
I've done this in angularjs and it works (using the example), but how can you register the component in angular2?
Basically I can register the new type in the builder, build a form, but I need to be able to render it in an  angular2 app. Otherwise I'd have the Unknown component: message
I've see the Render Resource example, but can I do the same with a custom component?
Thanks!

@gavieritei Wondering if you have found a way since to have a custom component?  I just came to realize ng2-formio does not have the file component (nor does formio.js), so it seems ngFormio is the way to go if you want file upload behaviors.

I've managed only to lookup the problem but not solve it itself (due to other priorities in my projects).
The problem is with the way the components are registered here and the check in the create function.
But this is in js code not in angular2 code, and I don't know of an easy solution to extend that. (I'm not that experienced in js at this time).

@gavieritei @rmckeel  I'm also facing the same problem.Anyone have solution for this

@gowthaman-i2i Is your issue specific to a file upload component, or some other custom component you want to build?
I didn't get very far on custom NG2 components (we decided to stick to AngularJS version).  However, I do remember a Formio message that they released a file component for NG2.

I just created some examples of a custom component in Angular. You can see it in the Angular Demo application @ https://github.com/formio/angular-demo.
Here is the custom component.
https://github.com/formio/angular-demo/blob/master/src/app/components/CheckMatrix.js
And here is how you register it within your application.
https://github.com/formio/angular-demo/blob/master/src/app/app.module.ts#L19
Hope this helps.


Maki update 8.0

Following the instructions on the page Maki Icon Generation, I pulled in the latest release of maki icons from https://github.com/mapbox/maki/archive/refs/tags/v8.0.0.tar.gz . I generated the related png files as per the instructions on above cited page, and uploaded the results.
Fixes issue #11261.

Thank you so much for the pull request @JohnRDOrazio! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!
The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

:x: Missing CONTRIBUTORS.md entry.

Please add yourself to the contributors file!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

It seems that some icons have been renamed, I've kept both the old and the new naming to make sure nothing breaks. Perhaps it should be considered whether the new naming should be announced at some point? Or should both naming schemes be kept viable?
Here are the icons with new names, and sometimes with an updated look ( N/A means it has been removed as far as I can tell, you can visually compare against https://labs.mapbox.com/maki-icons/ ):

- old name -
- new name -

america-football.png
american-football.png

camera.png
attraction.png

chemist.png
N/A

disability.png
wheelchair.png

emergency-telephone.png
emergency-phone.png

industrial.png
industry.png

land-use.png
landuse.png

london-underground.png
N/A

minefield.png
N/A

mobilephone.png
mobile-phone.png

oil-well.png
N/A

park.png
park-alt1.png

park2.png
park.png

polling-place.png
N/A

rail-underground.png
N/A

rail-above.png
N/A

toilets.png
toilet.png

Thanks for the PR @JohnRDOrazio!
Since its been almost 10 years since the maki update process was established, there may now be a better solution today. Many of the problem described in https://github.com/CesiumGS/cesium/pull/2161 will likely no longer be issues: We no longer support IE11, and the layout of the icons themsleves appears to have been updated. Perhaps we can consider making https://github.com/mapbox/maki an npm dependency.
Regarding the renaming, I think maintaining backwards compatibility is a good idea. Ideally, we could remap the old names to a new name rather than including two images.
We'll also need to update our Maki attribution accordingly.

In fact the npm package https://www.npmjs.com/package/@mapbox/maki still uses only the source svg files. There is certainly better support for svg in canvas now, so perhaps it could be an idea to try to implement the SVGs directly. But perhaps in the meantime a quick update of the PNGs would be an intermediate and more immediate solution?

@JohnRDOrazio I'm closing this issue due to inactivity. If you'd like to discuss further, please feel free to re-open. Thanks!


test/unit/math/prim/mat/functor/num_threads_test.cpp

All tests in test/unit/math/prim/mat/functor/num_threads_test.cpp fail when STAN_THREADS is not defined.
For example, the first test goes as follows:
set_n_threads("10");
EXPECT_EQ(stan::math::internal::get_num_threads(100), 10);

The expected value is 10. The actual value is 1.
By default, get_num_threads returns 1 when STAN_THREADS is undefined. A similar argument applies to the rest of the assertions in this file.
Current Version:
v2.20.0

This is a little out of scope for this bugfix issue, but it would be helpful if all tests that need special compilation flags were isolated in their own directory. Like OpenCL is moving to. IMO, unit tests which are testing some functionality of Stan should be located close together in the file system.
The alternative, which is what I'm currently doing in CMake, is to go through and mark each test by hand in the build script if it should be conditionally compiled.

I see. I am right now changing the function to work under any circumstance the same way... and we actually do test sunsets under specific conditions. Have a look at the windows threading tests in Jenkins, for example. Often we do test indeed the full combinatorics though and that does not scale well....yes.

Should this issue be closed with the TBB merge?

Yes, this test no longer exits. Thanks for the reminder. Closing.


test: added tests fo multiTreeSelect Regression tests

/ci-test-limit

/ci-test-limit

/ci-test-limit

/ci-test-limit

/ok-to-test

/ok-to-test


feat: Enhance design of more view at monthly

Version

v1.0.2
Current Behavior

Expected Behavior

Need to customize it by theme.


Optional match return null and crash on Result class

Im trying to return from the database nodes that some of them have the match and dome not.
because is return null its crash on Result class here :
public function addRelationshipToIdentifier($relationshipId, $identifier)
{
if (isset($this->identifiers[$identifier])) {
foreach ($this->identifiers[$identifier] as $rel) {
if ($rel->getId() === $relationshipId) {
                    return;
                }
        }
    }
    $this->identifiers[$identifier][] = $this->getRelationship($relationshipId);
}

it can be fix by adding check if $rel is not null.
i dont want to do that by myself (because  future update)
there is a way to fix it ? or update it in next version

Thanks for the report, I'll check this and push a fix

@liran89b Can you provide the query you are executing ? I have created a test in the branch issue73 containing these assertions, until now I have no errors :
/**
     * https://github.com/neoxygen/neo4j-neoclient/issues/73
     */
    public function testReportedIssue()
    {
        $this->prepareDB();
        $query1 = 'MATCH (n:Node {id:1}) OPTIONAL MATCH (n)-[r]->(o) RETURN n,r,o';
        $result = $this->getConnection()->sendCypherQuery($query1)->getResult();
        $this->assertInstanceOf(Node::class, $result->get('n', true));
        $this->assertInstanceOf(Node::class, $result->get('o', true));
        $this->assertInstanceOf(Relationship::class, $result->get('r', true));

        $query2 = 'MATCH (n:Node {id:3}) OPTIONAL MATCH (n)-[r]->(o) RETURN n,r,o';
        $result2 = $this->getConnection()->sendCypherQuery($query2)->getResult();
        $this->assertInstanceOf(Node::class, $result2->get('n', true));
        $this->assertEquals(null, $result2->get('r'));

    }

@liran89b Thanks, I have pushed a fix and released 3.3.13, please report if it fixes completely your use case.
Cheers! and Happy new year.


Matching molecules to topology atoms results in peculiar behavior for symmetric molecules

The current approach, wherein we identify molecules in our Topology by using a graph to match reference molecules onto the Topology, results in slightly odd behavior in the case of symmetric molecules. For example, for cyclohexane, the charge on one carbon ends up just slightly different than on other carbons, and our current "molecule to Topology" matching results in this carbon sometimes being the first one in a molecule, other times second, etc. (since there are multiple equivalent ways to map cyclohexane onto itself). While this is not a huge problem per se, it does result in some complexities when translating into formats for other simulation packages such as GROMACS. For example, cyclohexane would normally be represented as a single "molecule" in a GROMACS topology file, but if the carbon atoms have non-equivalent charges in different instances of the molecule, this can't be done (see https://github.com/ParmEd/ParmEd/issues/791).
@jchodera , any thoughts?
One approach would be to change how molecules are matched to the Topology to default to attempting to preserve atom order (relative to the first instance) unless this doesn't result in successful matches.

Let me make sure I understand all the issues listed here:

When MCSS returns degenerate matches, we choose the first match, which may result in a random relative ordering of atoms in the molecule mapped onto the OEMol reference molecule. This causes weirdness when ParmEd tries to "compress" these into unique molecules, because the same molecule type is now represented by multiple distinct (nearly) equivalent molecules. This doesn't actually cause problems, but is unexpected.
There is an issue with the charge assignment in that equivalent molecules are not receiving equivalent charges.

Instead, we would like to:

Somehow pick a unique mapping of relative atom order within each molecule to the OEMol reference molecule
Have chemically equivalent atoms be assigned identical charges

Is that right?

@jchodera :

When MCSS returns degenerate matches, we choose the first match, which may result in a random relative ordering of atoms in the molecule mapped onto the OEMol reference molecule. This causes weirdness when ParmEd tries to "compress" these into unique molecules, because the same molecule type is now represented by multiple distinct (nearly) equivalent molecules. This doesn't actually cause problems, but is unexpected.

Yes. It doesn't cause problems unless you expect that an OpenMM system written to/read from AMBER format will yield the same energies as an OpenMM system written to/read from GROMACS format.

There is an issue with the charge assignment in that equivalent molecules are not receiving equivalent charges.

This depends slightly on what you mean. Each molecule gets the same charges. It's just that they might be assigned to different atoms (i.e. carbon 1 of cyclohexane in the first instance gets the largest magnitude charge, whereas it is carbon 2 of cyclohexane in the second instance).
Or, maybe you mean that the problem is that symmetry-equivalent atoms are not receiving exactly equivalent charges. That's an issue, perhaps, though likely one with OpenEye's tools rather than with anything here. (I'll investigate it.)

Instead, we would like to:

Somehow pick a unique mapping of relative atom order within each molecule to the OEMol reference molecule

Yes, that's the main thing I'm concerned about.

Have chemically equivalent atoms be assigned identical charges

I think this is outside our scope. I'm mainly concerned here with ensuring that, if we have multiple instances of the same molecule, the charges are applied to each molecule in the same order. I don't think we can be responsible for ensuring that chemically equivalent atoms get equivalent charges unless we want to implement a chemistry toolkit of some sort to figure out which atoms are chemically equivalent.

I don't think this is a problem in terms of internal functionality at all, but definitely it results in weird/unexpected issues when going into other formats.

Yes. It doesn't cause problems unless you expect that an OpenMM system written to/read from AMBER format will yield the same energies as an OpenMM system written to/read from GROMACS format.

Unless I'm misunderstanding, that means one of those converters is broken. If the charges on atoms are inequivalent, for example, the GROMACS converter is making an error if it is assuming they are equivalent.

Or, maybe you mean that the problem is that symmetry-equivalent atoms are not receiving exactly equivalent charges. That's an issue, perhaps, though likely one with OpenEye's tools rather than with anything here. (I'll investigate it.)

That's certainly one problem!

Yes, that's the main thing I'm concerned about.

There are really no guarantees about what relative order the atoms will be in within a residue of a Topology. We can try to preserve relative atom ordering if possible if there are really degenerate matches---I think this would just involve selecting the MCSS match that matches the same relative atom mapping to the reference OEMol if one has already been observed---but this should be purely an act of selecting one of many totally equivalent behaviors.

I think this is outside our scope.

But isn't this just like the inequivalent improper issue? Should we perhaps be averaging charges over all the equivalent MCSS matches?

I'm mainly concerned here with ensuring that, if we have multiple instances of the same molecule, the charges are applied to each molecule in the same order.

This is just to allow gromacs compression, right?
The gromacs converter should not be compressing inequivalent molecules (in terms of atom ordering) into the same reference molecule---we should get that fixed too.

I don't think we can be responsible for ensuring that chemically equivalent atoms get equivalent charges unless we want to implement a chemistry toolkit of some sort to figure out which atoms are chemically equivalent.

The MCSS match already does exactly this, though! It has all of the chemically equivalent mappings identified.

The gromacs converter should not be compressing inequivalent molecules (in terms of atom ordering) into the same reference molecule---we should get that fixed too.

Yes, working on that.

The MCSS match already does exactly this, though! It has all of the chemically equivalent mappings identified.

Ah, that's a good point. BUT -- is having all of the chemically equivalent mappings the same as identifying all of the atoms which should be chemically equivalent to one another? It's not immediately obvious to me that you can use the mappings (of one molecule onto another) to always identify which atoms (within the same molecule) should be symmetry-equivalent to one another, though it certainly seems like in many cases this can be done. My (very limited) brain seems to be trying to tell me these are slightly different problems.

We can try to preserve relative atom ordering if possible if there are really degenerate matches---I think this would just involve selecting the MCSS match that matches the same relative atom mapping to the reference OEMol if one has already been observed---but this should be purely an act of selecting one of many totally equivalent behaviors.

Yes, I think that's the "right" answer, unless there is a straightforward way to deal with the symmetry equivalence issue.
I wrote:

Or, maybe you mean that the problem is that symmetry-equivalent atoms are not receiving exactly equivalent charges. That's an issue, perhaps, though likely one with OpenEye's tools rather than with anything here. (I'll investigate it.)

I checked this and it seems the issue in this particular test case was that I was using a mol2 file charged prior to a fix to the precision OpenEye was using for charges in .mol2 files, so the symmetry was slightly broken. If I re-charge, the issue goes away. However, unless we enforce an "always charge the input molecules" scheme, I think we have to deal with this, as someone will presumably sooner or later feed in molecules which don't have symmetrized charges.

Ah, that's a good point. BUT -- is having all of the chemically equivalent mappings the same as identifying all of the atoms which should be chemically equivalent to one another? It's not immediately obvious to me that you can use the mappings (of one molecule onto another) to always identify which atoms (within the same molecule) should be symmetry-equivalent to one another, though it certainly seems like in many cases this can be done. My (very limited) brain seems to be trying to tell me these are slightly different problems.

For our purposes, simply averaging charges over all symmetry-equivalent mappings should just do the right thing.

Yes, I think that's the "right" answer, unless there is a straightforward way to deal with the symmetry equivalence issue.

It's an equivalent approach that should not affect anything except for the ability of your gromacs writer to compress topology files.

I checked this and it seems the issue in this particular test case was that I was using a mol2 file charged prior to a fix to the precision OpenEye was using for charges in .mol2 files, so the symmetry was slightly broken. If I re-charge, the issue goes away. However, unless we enforce an "always charge the input molecules" scheme, I think we have to deal with this, as someone will presumably sooner or later feed in molecules which don't have symmetrized charges.

We could easily add an option to symmetrize charges, but I'm not sure if we would want it on or off by default.

This was partly resolved by ParmEd, which no longer does peculiar things if charges aren't equivalent across topologically identical molecules. However, we should still try and produce symmetric matchings.

However, we should still try and produce symmetric matchings.

Do you mean we should (1) average charges over degenerate matches to ensure chemically equivalent atoms are identical, or (2) use some sort of scheme to uniquely identify atom orders?

Averaging over degenerate matches to ensure chemically equivalent atoms are identical.


Bridge: refactor TransactionPayload

After working more on the bridge today I discovered that aptos_types::transaction::TransactionPayload and aptos_api_types::transaction::TransactionPayload are very different types with different fields. I think both have remained in the codebase even though one is legacy.
In my bridge implementation, I had written a fair amount of utility logic that would convert the native rust / bridge types into a payload of aptos_api_types::transaction::TransactionPayload but I actually need the other kind in order to properly send the transaction and handle the various states.

Refactor the code to use the new type, and update the conversion logic.

Implemented as part of this PR
https://github.com/movementlabsxyz/movement/pull/153


Why there are no tests?

I was expecting some useful tests for this important library.
npm test is set to standard. We can use different script to do standard, test script should be doing tests.

I'm not sure how one would write tests for this type of library.
Anyone who can point us in the right the direction?

@gillesdemey Easiest way would probably be to use spectron to do some basic e2e tests on the example app.

I saw Spectron when it was announced a few weeks earlier and it made me think of this issue, I might take a look at it when I have some spare time.

@gillesdemey I have wrote some basic test using spectron in one my desktop app. See here. @maxogden I could send a PR if you want.

@akashnimare I know this is super late, but would you still like to send a PR?


Uncaught TypeError: Cannot read property 'addStateChangeListener' of undefined

I get the above issue when including the avatar in a package. I'm building the package using create-react-library.
React version: 16.8.6

Remove the {} around Avatar when you import it
so just do => import Avatar from 'avataaars'

If anyone wants to use an upgraded version where this is solved, here is the fork.


.size option not supported on res.body

It's not mentioned in the README that when using res.body and not res.json() etc, that the .size option will not trigger any response size limiting errors.

I'm not sure whether I quite understand what you mean - could you please provide more details? Example code would be very useful.

If you use res.json() for example, an error will be thrown once the internal stream has reached opts.size bytes.
If you use res.body, for example like this:
res.body.pipe(fs.createWriteStream('./out.txt'))

...then no error will be emitted, even if the response will be larger than opts.size.

I'm solving this internally by replacing res.body with a stream that emits an error once opts.size bytes have been reached.

I would say that this is obvious - when you utilize a function like json(), the stream is processed by node-fetch. We have a function to consume the body, which respects the size:
https://github.com/node-fetch/node-fetch/blob/ffef5e3c2322e8493dd75120b1123b01b106ab23/src/body.js#L200
However, response.body is not a function, but rather just a ReadableStream. You must process it yourself and make sure that you respect options.size - Stream.pipe() function doesn't know it.

We can mention this fact in the README, but I'm not sure whether that's necessary - would like to hear what @node-fetch/reviewers think.

I would say that this is obvious

It wasn't obvious to me. I expected res.body to emit an "error" once opts.size bytes had been written. The default way of writing the response to disk is to use the res.body stream (assuming you don't want to buffer the whole response in memory), and for this use-case opts.size doesn't work.
As an alternative to adjusting the documentation, It would be possible for this library to make the stream emit an error too.

If it helps, here is my basic implementation:
class LimitStream extends Transform {
  constructor (limit) {
    super()
    this._bytesLimit = limit
    this._bytesWritten = 0
  }

  _transform (chunk, _, cb) {
    this._bytesWritten += chunk.length
    if (this._bytesWritten > this._bytesLimit) {
      this.emit('limit')
    }
    this.push(chunk)
    cb()
  }
}

const res = await fetch(url, opts)

const { body } = res
const limitStream = new LimitStream(opts.size)
limitStream.on('limit', () => {
  limitStream.removeAllListeners('limit')
  body.emit('error', new FetchError(`content size at ${url} over limit: ${opts.size}`, 'max-size'))
})
body.pipe(limitStream)
body.on('error', limitStream.emit.bind(limitStream, 'error'))
Object.defineProperty(res, 'body', { get: () => limitStream })

size is a node-fetch extension to the spec, and as such, has a very little description for edge case behaviours.
In my personal opinion, it should be removed, as (even per @juliangruber  example) streaming response allows to implement size limit for any particular needs. But if we want to keep it then we certainly must respect it in all types of responses.

Here is my take on looking at the size limit in a cross platform way-ish and looking at download progress at the same time
const ctrl = new AbortController()
const limit = 1024
const res = await fetch(url, { signal: ctrl.signal })
const knownLength = Number(res.headers.get('content-length') || 0)
const notEncoded = !res.headers.get('content-encoding')
let bytesWritten = 0

if (knownLength > limit) ctrl.abort()

for (const chunk of res.body) {
  bytesWritten += chunk.byteLength
  if (bytesWritten > limit) {
    ctrl.abort()
    throw new Error(`content size at ${res.url} over limit`)
  }
  if (notEncoded && knownLength) {
    console.log(`progress = ${bytesWritten / knownLength}`)
  }

  // Do something else with chunk
}

Nice, thanks for sharing, this is a lot simpler using async iteration

As an attempt to implement nodes new stream-consumers then this became more apparent to me.
Right now i feel like removing size option all together. it's not part of the spec and it is not implemented in any other fetch implementation.


Fix encoding of IN instruction with bit_count == 32

Thanks to @xeniarose for finding and reporting this bug
Fixes #57

maybe add a test?

how about 3 tests?
instr_test!(r#in(InSource::Y, 10), 0b010_00000_010_01010);
instr_test!(r#in(InSource::Y, 32), 0b010_00000_010_00000);

instr_test!(out(OutDestination::Y, 10), 0b011_00000_010_01010);
instr_test!(out(OutDestination::Y, 32), 0b011_00000_010_00000);

#[test]
#[should_panic]
fn test_invalid_in_bit_width_should_panic() {
    let mut a = Assembler::<32>::new();
    a.r#in(InSource::Y, 33);
    a.assemble_program();
}

#[test]
#[should_panic]
fn test_invalid_out_bit_width_should_panic() {
    let mut a = Assembler::<32>::new();
    a.r#in(InSource::X, 33);
    a.assemble_program();
}


[DOCS]  adding a road map

Description
how to add a roadmap in a efficient manner?
Screenshots
No response
Additional information
No response

Good question @AshirMehmood
Check out Javascript-roadmap.md file to understand how you have to create roadmap, create files and folders according to the requirement
Before adding new roadmap, create such kind of file and open issue  so that we can review it and suggest you changes, and then you can raise PR


window.nativeTabs dosen't work

VSCode Version: 1.12.1
OS Version: macOS 10.12.4

I set up "window.nativeTabs": true, but new windows open not in tabs.

See #25919


Typo in write up for Phase-Locked Loop tutorial

In the final paragraph, there is text that reads:
Notice also that the difference in phase of the last several samples (i.e. the difference between the phase at steps 38 and 39 ) is approximately 0.1 which is the initial frequency offset that was given in the beginning.
0.1 should be 0.01

Good catch! Fixed.


[Suggestion] Add claim UUID support to /trust and /untrust

Would it be possible for /trust, /untrust, /gd cleantrust, etc to support claim UUIDs? Like /trust (ign) (UUID), or even some sort of secondary command, /admintrust? /atrust?
And allow console to run that aswell, cause atm, you can trust people to other claims by using LP, but you can't untrust them if they got trusted with /trust, or any sort of command.
Thank you!

This was implemented in GD 2.x. Just pass the claim identifier at end of command. To set a claim id for a claim, stand in claim and use /claimid <identifier>


IGNITE-8869: Exclude daemon's nodes from ExchangeLatch.

The ticket is resolved, closing PR.
Please close PRs for your resolved tickets and other non-needed PRs.
Alternatively, ask a committer

to use GitHub UI (committer can associate accounts here: https://gitbox.apache.org/setup/ )
or /scripts/apply_pull_request.sh from Apache Ignite source.
or mention in commit message 'Fixes #(a number of PR)'.

These methods will automatically close PR.
Feel free to reopen this PR if it is actual.


Add some framework and security tools

You should have a look at the contributing rules.
A XSS filter writed by PHP -> A XSS filter written in PHP (write is irregular + in a language, not by)
Also, with the phpfetcher entry, you deleted a newline, before the Middlewares section.
Seems like nice libs though!

@tleb Surely it should be 'An XSS filter written in PHP', just nitpicking.

@nic-d Wait, is x a vowel?

@tleb oh,sorry! it should be "An XSS filter written in PHP",and x is a vower when it is the first letter of  the sentense ,it's so funny,haha~

Sorry to doubt, but I haven't find a proof of this, could you back this up with a source?

@tleb stackexchange

Thanks!

Please resubmit this as separate PRs. Thanks!


Right Click Menu, shows file/group options.

Originally raised in #599

I think that these are issues of selection. When you open an image you get a File Node as well as an Image node (which IMO is correct - without the File node you cannot reload the image) and the File Node is what is selected so you get the Group element right click choices.
There is also an issue of selection in the scene being reflected correctly in the tree. For example, click on the outside of the elements in the scene and the tree selections are not cleared. If I load the Heather image, Control click in tree to clear selection(s), then click the image in the scene, I get both file node and image node shown in grey (emphasised?), but image opnode is not highlighted, right-click in scene doesn't include Remove and right-click in tree turns both element nodes blue (selected?) but still doesn't show remove. If I clear the selections with Control-click in tree and then reselect both of them in the same way, then I do get Remove in the right click menu.
There are lots of such inconsistencies. In short, I think we need to make the right-click menus reflect:
The node/node type that is right clicked.
The nodes / node types that are selected.
The nodes / node types that are emphasised.

Fixed.