feat(metrics): metrics for PFD transactions, sampling, and broadcasts

Closes #1040
First time playing with metrics, so unsure if this is the right approach

Metric Name
Light node
Full Node
Bridge node
Implemented

Total PayForData messages sent (count)
x
x
x
✅

Last PayForData message sent (timestamp)
x
x
x
✅

Last sample requested (timestamp)
x
x

✅

Last block served (timestamp)

x
❌

Last full sampling request (timestamp)

x
❌

Last full sampling req is not implemented because it is the same as Last sample requested
Last block served is not possible until we have implemented the networking of the new BlockSync
All metrics reporters are now identifiable through their peer.ID
Tested on grafana cloud

I am marking as out of draft for reviews but this PR should not be merged until #997 is merged, because rebasing on this would take more time than this being rebased.

Codecov Report

Merging #1083 (de76374) into main (1803ca0) will decrease coverage by 0.29%.
The diff coverage is 2.52%.

@@            Coverage Diff             @@
##             main    #1083      +/-   ##
==========================================
- Coverage   56.11%   55.81%   -0.30%
==========================================
  Files         136      139       +3
  Lines        9169     9255      +86
==========================================
+ Hits         5145     5166      +21
- Misses       3484     3551      +67
+ Partials      540      538       -2

Impacted Files
Coverage Δ

cmd/flags_misc.go
50.00% <0.00%> (+7.40%)
:arrow_up:

das/metrics.go
0.00% <0.00%> (ø)

das/state.go
100.00% <ø> (ø)

header/core/metrics.go
0.00% <0.00%> (ø)

node/services/service.go
83.33% <ø> (+2.49%)
:arrow_up:

node/settings.go
14.67% <0.00%> (-16.70%)
:arrow_down:

service/state/metrics.go
0.00% <0.00%> (ø)

service/state/service.go
28.20% <0.00%> (-1.53%)
:arrow_down:

das/daser.go
81.90% <100.00%> (+0.08%)
:arrow_up:

header/core/listener.go
53.70% <100.00%> (+0.87%)
:arrow_up:

... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Started rebasing, but realized that it will be easier once #1125 is merged first - let's just make sure that the "Last sampled timestamp" makes it in there

Wanted to review this, but will wait for the #1125 to land first


the OOMKilled status is not always in the lastState field of the cont…

…ainer status, but is sometimes in the state field (as in the case of job-related pods). We therefore try to look for OOMKilled in both fields
w

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


"Chiselet" is listed in the drop-down menu

Description:
"Chiselet" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Chiselet" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Chiselet, CĂLĂRAȘI (Chiselet)".


Duplicated URLs with i18n

I have a NUXT project with the i18n module with strategy: 'prefix_and_default' . The default locale is defaultLocale: 'en' and I have the alternative locales ca and es.
Reproduction
The module Simple Sitemap is detecting all the link with all the locales. The problem is that the generated sitemap.xml shows duplicated links for every locale:
    <url>
        <xhtml:link rel="alternate" hreflang="es" href="https://example.co/es/dashboard" />
        <xhtml:link rel="alternate" hreflang="ca" href="https://example.co/ca/dashboard" />
        <loc>https://example.co/dashboard</loc>
        <lastmod>2023-07-28T09:28:15+00:00</lastmod>
    </url>
    <url>
        <lastmod>2023-07-28T09:28:15+00:00</lastmod>
        <loc>https://example.co/ca/dashboard</loc>
    </url>
    <url>
        <lastmod>2023-07-28T09:28:15+00:00</lastmod>
        <loc>https://example.co/en/dashboard</loc>
    </url>
    <url>
        <lastmod>2023-07-28T09:38:12+00:00</lastmod>
        <loc>https://example.co/es/dashboard</loc>
    </url>

As you can see, the module generates a correct URL set for the /dashboard/ page with the correct alternate for every locale alternative. But also generates three more URL sets for every locale in the i18n module.
I have also tested changing the i18n strategy to strategy: 'prefix_exept_default' and the sitemap.xml looks like:
    <url>
        <xhtml:link rel="alternate" hreflang="es" href="https://example.co/es/dashboard" />
        <xhtml:link rel="alternate" hreflang="ca" href="https://example.co/ca/dashboard" />
        <loc>https://example.co/dashboard</loc>
        <lastmod>2023-07-28T09:28:15+00:00</lastmod>
    </url>
    <url>
        <lastmod>2023-07-28T09:28:15+00:00</lastmod>
        <loc>https://example.co/ca/dashboard</loc>
    </url>
    <url>
        <lastmod>2023-07-28T09:38:12+00:00</lastmod>
        <loc>https://example.co/es/dashboard</loc>
    </url>

This time the module generates only two wrong URL sets, one for each locale that is not the default.
I have also tested what happens when you add a routeRules to avoid rendering the /dashboard/ page, so: if I add:     routeRules: { '/dashboard/**': { index: false }, } the result is the following:
    <url>
        <lastmod>2023-07-28T09:28:15+00:00</lastmod>
        <loc>https://example.co/ca/dashboard</loc>
    </url>
    <url>
        <lastmod>2023-07-28T09:28:15+00:00</lastmod>
        <loc>https://example.co/en/dashboard</loc>
    </url>
    <url>
        <lastmod>2023-07-28T09:38:12+00:00</lastmod>
        <loc>https://example.co/es/dashboard</loc>
    </url>

It avoids generating the correct URL set with the correct alternates, but still generates the wrong URL sets for every locale.
System / Nuxt Info
No response

Hey, happy to investigate this further but I'll need some more reproduction details.
Maybe you can try to replicate it here: https://stackblitz.com/edit/nuxt-starter-jwuie4?file=app.vue

Some i18n logic was updated with v3.1.3, maybe worth trying this version before making a reproduction.

Closing due to inactivity, FYI 3.2.2 has improved support.


Generated Nextjs starter out of date.

Bug description
I was having issues getting the Nextjs starter running, it turns out the code generated was out of date.
import {
    AuthProviders,
    useLiveQuery,
    useWunderGraph,
    withWunderGraph,
} from '../components/generated/wundergraph.nextjs.integration';

Should be
import {
    AuthProviders,
    useLiveQuery,
    useWunderGraph,
    withWunderGraph,
} from '../components/generated/nextjs';

But when looking at the source, this is looking up to date, so I'm not sure where the issue lies.
https://github.com/wundergraph/wundergraph/blob/main/packages/nextjs-testapp/pages/authentication.tsx
How to reproduce

Install wunderctl with npm

npm i -g wunderctl

Run

wunderctl init --template nextjs-starter -o /some/path

Expected behavior
The app should run without errors.
WunderGraph information

All default
Environment & setup
MacOS m1
Node 14
WunderCtl Version
Version: 0.90.32
Commit: 386a3d4b66204411dc89da6919aad0bebe524657
Date: 2022-06-06T12:25:36Z
BuiltBy: ci

Hi @Pagebakers thank you for opening an issue. I fixed the places in https://github.com/wundergraph/wundergraph/commit/08493955ce6a3d96c23b7bb07ccf788ca8911752


Adjust MASTER_URL to be just the hostname

In preparation of supporting status updates, I want to clarify
the meaning of the MASTER_URL env var on the worker.
Up until now the only URL of importance was the results URL so
that is what the MASTER_URL was set to. Soon, we will have results
and status updates, so it makes sense to have the MASTER_URL simply
be the hostname and add the path on the fly depending on which
endpoint we are trying to hit.
ref #735
Release note:
MASTER_URL set on the Sonobuoy worker container now refers to just `https://<hostname>` instead of the full results URL in order to more easily support manipulating the path used. This should have no impact on users since this is just a value used internally.

Codecov Report

Merging #867 into master will increase coverage by 0.12%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           master   #867      +/-   ##
========================================
+ Coverage   46.88%    47%   +0.12%
========================================
  Files          75     75
  Lines        4865   4863       -2
========================================
+ Hits         2281   2286       +5
+ Misses       2452   2447       -5
+ Partials      132    130       -2

Impacted Files
Coverage Δ

pkg/plugin/driver/base.go
59.61% <ø> (ø)
:arrow_up:

cmd/sonobuoy/app/worker.go
9.47% <0%> (-0.21%)
:arrow_down:

pkg/plugin/driver/job/job.go
75% <0%> (+1.22%)
:arrow_up:

pkg/plugin/driver/daemonset/daemonset.go
66.66% <0%> (+0.84%)
:arrow_up:

pkg/plugin/aggregation/aggregator.go
83.2% <0%> (+4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a603fdb...a24c1ba. Read the comment docs.


Problem adding a KVM host

Hi,
There is a problem with adding a KVM host with the dashboard. Allways says that credentials are incorrect. The KVM host its the localhost, im testing, and the user VDI can login without password in this own host. I think the rsa keys are ok in all directories and need to copy.
I use Ubuntu 16, MariaDB and PHP7, and the Apache error log says:
[Sun Sep 18 10:26:12.176531 2016] [:error] [pid 3185] [client <IP_ADDRESS>:51892] PHP Warning:  ssh2_auth_pubkey_file(): Authentication failed for VDI using public key: Unable to open public key file in /var/www/html/kvm-vdi/functions/functions.php on line 48, referer: http://XXXXXXX/kvm-vdi/dashboard.php
I red about the PHP key problem but i cant solve the problem. Can you help us?
Thanks

Hi again
I could find the problem. The rsa keys in hypervisors folder can be read by user www-data.
Thanks


Fix the behaviour of combining @data and @singleton

Describe the bug

When combining @singleton with @data, @singleton should come before @data. Combining them the other way around will work in most cases but is not thoroughly tested and relies on assumptions that might not hold.

Expected behavior
There should be a single correct way of emulating this behaviour. We should raise an immediately actionable error when they are combined in a way that isn't guaranteed to function.

why this has been reopened? any issue persisting?


Added Winbond W25X20

Tested on JMS 579 (WD MY BOOK).
It worked perfectly.
I added WINBOND W25X20.. according to the datasheet these are the commands:
Write Enable (06h)
Write Disable (04h)
Read Status Register (05h)
Write Status Register (01h)
Read Data (03h)
Fast Read (0Bh)
Fast Read Dual Output (3Bh)
Page Program (02h)
Sector Erase (20h)
Block Erase (D8h)
Chip Erase (C7h)
Power-down (B9h)
Release Power-down / Device ID (ABh)
Read Manufacturer / Device ID (90h)
JEDEC ID (9Fh)

The datasheet also says:
The W25X10/20/40/80 array is organized into 512/1024/2048/4096 programmable pages of 256-bytes each. Up to 256 bytes can be programmed at a time using the Page Program instruction. Pages can be erased in groups of 16 (sector erase), groups of 256 (block erase) or the entire chip (chip erase). The W25X10/20/40/80 has 32/64/128/256 erasable sectors and 2/4/8/16 erasable blocks respectively. The  small  4KB  sectors  allow  for  greater  flexibility  in  applications  that  require  data  and  parameter  storage.
– Sector Erase (4K-bytes) – Block Erase (64K-byte) – Page program up to 256 bytes <2ms
for more informations, the datasheet is here: https://pdf1.alldatasheet.com/datasheet-pdf/view/178188/WINBOND/W25X20.html

Thank you very much!

Thank you very much!

Thank you for the program!
A question: would it be possible to make it buildable on windows too?
Another question:
why does the original flasher just upload the rom to the device and your flasher does 2 steps?
I noticed it first uploads the rom, then another long "sort of" reflash.
Do you want me to reverse engineer the windows flasher?

Also: a note: the W25X25 id is 3012... but for some reason your flasher identifies it as EF3012...
I modified the id in types to reflect that, but it seems a bug to me... please check that out.

Also: a note: the W25X25 id is 3012... but for some reason your flasher identifies it as EF3012... I modified the id in types to reflect that, but it seems a bug to me... please check that out.

EF is the manufaturer:
#define _SPI_NAND_MANUFACTURER_ID_WINBOND		0xEF

Hello,

Also: a note: the W25X25 id is 3012... but for some reason your flasher identifies it as EF3012...
Normally the 'Read JEDEC ID' (0x9F) command returns three bytes. The first one is the manufacturer and the next two bytes are the device ID. This first byte is why you see the EF in front of it.

A question: would it be possible to make it buildable on windows too?
The only code needed for that would be porting https://github.com/BertoldVdb/jms578flash/tree/master/scsi to windows. You can send raw SCSI commands using the DeviceIO call on Windows:
https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntddscsi/ni-ntddscsi-ioctl_scsi_pass_through_direct
My application has the JMS578 chip directly connected on the PCB to a CPU so its not so easy to plug it into a Windows PC for testing.

why does the original flasher just upload the rom to the device and your flasher does 2 steps?
I noticed it first uploads the rom, then another long "sort of" reflash.
I don't understand what you mean exactly. The program does the following actions:
*) Upload stub to access SPI with DMA (if bootrom argument is given, and current firmware does not have SPI command support)
*) Write firmware to flash and verify it
*) Reboot device and check if it comes online
I assume that is more or less the same as what the windows tool does.

Note that you only need to download the bootrom once, this file is the same for all chips, so as soon as you downloaded it from one device you can use it to flash as many as you want.

EF is the manufaturer:
Sorry, only see this now and already replied.


Filtering locations does not work for MyBusiness API

E.g. trying to filter out locations using:
// @TODO filter does not work:
$filter = ['filter' => 'locationName:' . urlencode($location_name) . '*'];

I have also tried without URL encoding, but this does not work either. All locations are returned.
See: https://developers.google.com/my-business/content/location-data#filter_results_when_listing_locations

Confused as to why this is in my Account....

To confirm, your API looks something like this?
$locations = $mybusiness->accounts_locations->listAccountsLocations($parent, [
	'filter' => ['filter' => 'locationName:' . urlencode($location_name) . '*']
]);

If so, then it appears correct. I checked that the field is available, and it is. If you are unable to get it working, I believe it is not an issue in the client library. I suggest trying some of the support resources available for the My Business API. They will be more equipped to assist further.


Implement NaN aggregation functions from NumPy

Extracted from #70:

[x] np.nansum
[x] np.nanprod
[x] np.nancumsum
[x] np.nancumprod
[x] np.nanmean
[ ] np.nanmedian
[ ] np.nanpercentile
[ ] np.nanquantile
[ ] np.nanvar
[ ] np.nanstd
[ ] np.nanargmin
[ ] np.nanargmax
[x] np.nanmin
[x] np.nanmax

Hi again, I'm thinking of seeing how many of the remaining ones on the list I can knock off. I've got nanargmin and nanargmax done, but for nanmedian and similar it looks like I need a reducer. Is there anything that works in a similar way to the one used in numpy (located below) that you could point me towards?:
https://github.com/numpy/numpy/blob/dae4f67c797176c66281101be8f3b4d6c424735c/numpy/lib/function_base.py#L3333
I've had a bit of a dig through the code base but am not as confident as I'd like to be that I'm looking at the right thing for the job. Hope this isn't a bother.

I don't think we have any direct equivalent of that utility function. I would guess nanmedian could be implemented in a similar way to median (i.e., in terms of lax.sort).

I will take np.nanvar and  np.nanstd.

It looks like someone actually tried that out: https://github.com/google/jax/pull/2310
but we dropped the ball on reviewing it.

oh, I just found the pr. seems all functions in this issue have been added or PRed :). I can go to find some other issues.

These are now all implemented.


Lifeissuck patch 1

Hi,
this repo should only contain a small set of filter lists that I think are relevant to most people. I will close this PR without merging, but of course feel free to keep your repo up to date :)
Also I think the URL https://xngqoc.com^ will not work with the list generator (the file should only contain links to filter lists, not filters themselves).


[Patch] Update embedded java download dir for local repo

Using java: 'embedded' with a custom repo_base_url jdk download fails.
This PR update embedded java download url with repo_base_url

Just wondering why you don't use a recent openjdk (>v8) (not that I'ld disagree to make this more configurable 👍 )

The embedded version (oracle jdk 1.8.0_112) is working well for me..
Do you have some perfs improvement using a more recent version ?
Some jdk also have incompatibilities (https://cwiki.apache.org/confluence/display/HADOOP/Hadoop+Java+Versions)

Yes, I'd recommend the same @agriffaut, to use the latest Oracle 1.8 JDK or even openjdk given the recent Oracle "friendly" announcements...
The incompatibilities you saw come from improvements in security in the new versions, which should be desirable and any individual issue treated separately.
But as @lhoss said,  👍  for making it configurable.


As a data developer, I want to remove the data-roadmap directory that is no longer used very often.

Description
data/data-roadmap is a legacy item that is badly out of date. Should we just remove the whole directory so as to reduce confusion for new developers?
I think deleting that folder will have no impacts on any other part of the codebase.

I agree.

I can take care of that.

Thanks @saran-ahluwalia !


Simplistic check if FPU is defined in CPU-block

Working with a LPC1347 board, compilation fails with
 pub use cortex_m::peripheral::{CBP, CPUID, DCB, DWT, FPB, FPU, ITM, MPU, NVIC, SCB, SYST, TPIU};
                                                           ^^^ no `FPU` in `peripheral`. Did you mean to use `MPU`?

The SVD file provides the information that no FPU (nor MPU) is present.

Looks reasonable to me!
bors try

@AfoHT Looks like something went wrong here. Can you please rebase against the current master?

Hope that solved that unfortunate push to master

bors retry

bors r+

Build Passed, merging manually


Re-design Front-End

Review the current front-end design:

Personalize it further to make it stand out
Come up with a unique name

The objective has been met.


bin2hex.py should have option to save in the existing or newer file

Sorry for not working on your issue. I'm looking for a new maintainer for Python IntelHex project. I hope someone will help.


Merge pull request #1 from sharding-sphere/master

Master
Fixes #ISSUSE_ID.
Changes proposed in this pull request:

Codecov Report

Merging #977 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #977   +/-   ##
=======================================
  Coverage   63.68%   63.68%
=======================================
  Files         498      498
  Lines        9792     9792
  Branches     1609     1609
=======================================
  Hits         6236     6236
+ Misses       3207     3206    -1
- Partials      349      350    +1

Impacted Files
Coverage Δ

...spring/datasource/SpringMasterSlaveDataSource.java
83.33% <0%> (-16.67%)
:arrow_down:

...OrchestrationMasterSlaveDataSourceFactoryBean.java
77.77% <0%> (+11.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff221e6...5b6115d. Read the comment docs.

please stop to do it, it will let us confuse.


[BUG] Loader issue at Create Post

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When create post is clicked a loader appears which is too small and it reduces the overall page height.
Expected Behavior
The loader should be full length as page (including the footer size).
Reproduction steps
1. Go to 'Landing Page'
2. Click on 'Create Post'
3. See small loader

Screenshots
Current loader:-

Want to add this Loader that i had in one of my projects.
If color combination is not suitable you can give me suggestion regarding that.

it works like this:-

Logs
No response
Browsers
Firefox, Chrome, Safari, Microsoft Edge, Opera
OS
Windows, Linux

We have have skeleton for this, like for the main page, we don't want to break the UI/UX consistency by adding these loaders


Entire player freezes on listening to one specific song

OS: Windows 10
GPMDP Version: 4.6.1
Issue Descriptions: Entire player freezes on listening to one specific song. Probably something to do with the weird periods on the song name.
Steps to Reproduce: Listen to the specific song: Virtual Self - a.i.ngel (Become God)

Duplicate of #3483


Seven Theme - Users

Looks good. I may adjust the placement of the pagination, but we'll see with a full list of users what it does and if we're going to adjust it.


add "release events" to calendar selection

📚 Documentation
As mentioned by @sofroniewn in https://github.com/napari/napari/discussions/4126, the napari community is now tracking release events in the community calendar.
It would be beneficial to let users filter these events in the community calendar: https://napari.org/community/meeting_schedule.html

Do we still want to do this? I haven't seen release events on the calendar, so just want to be sure.

We hadn't had a release in like almost a  year so... 👀
I think the idea of releases every month or something regular is still far off, so releases will be touch and go, but I do think we should aim to put RC release on the calendar--manually--when we know it's going to happen.
So maybe we close this and play it by ear. If we get to a really regular cadence we put it on the calendar?


Unable to resolve module ./index

Hey guys, love what you've done with this monorepo setup and the t3 stack :)
I've been running into this issue on my project:

this happens when i try to run the bundled ios app using npx expo run:ios as well expo run:ios
this is happening on a clean clone of the repo as well as my personal project repo :(
would love if you could point me in the right direction.

I need to run it using expo run:ios as I am using a datepicker library that has native code which will not work on expo go

i think its similar to this issue https://github.com/expo/expo-cli/issues/4509

Maybe @byCedric has some idea?

please let me know if you need more info

just to confirm i cloned the branch again and ran the steps in the repo README

pnpm i
changed the db provider in schema.prisma to sqlite
3.echo DATABASE_URL=file:./db.sqlite >> packages/db/.env
pnpm db-push
cd /apps/expo
npx expo run:ios

i get the following error
 Config synced
✔ Installed pods and initialized Xcode workspace.
 To resolve this, select a development team in the expo editor. (in target 'expo' from project 'expo')
› Compiling Pods/Pods-expo » Pods-expo-dummy.m
› Packaging Pods/Pods-expo » libPods-expo.a
› Executing expo » [CP] Check Pods Manifest.lock
› Executing expo » Start Packager on http://localhost:8081
› Compiling expo » ExpoModulesProvider.swift
› Compiling expo » noop-file.swift
› Compiling expo » main.m
› Compiling expo » expo_vers.c
› Compiling expo » AppDelegate.mm
› Linking   expo » expo
⚠  ld: duplicate method '+moduleName' in
┌─[category]: ExpoBridgeModule-29f0c1a27a7bd5530b831d82e9038ac3.o ExpoModulesCore/libExpoModulesCore.a
└─[class]: ExpoBridgeModule-84674e26e826db07ace0cbde5ca591d6.o ExpoModulesCore/libExpoModulesCore.a

› Compiling expo » SplashScreen.storyboard
› Preparing expo » Info.plist
› Copying   ios/expo/Supporting/Expo.plist ➜ ./Expo.plist
› Generating debug expo » expo.app.dSYM
› Executing expo » Bundle React Native code and images
› Executing expo » [CP] Copy Pods Resources
› Signing   expo » expo.app
› Build Succeeded

› 0 error(s), and 2 warning(s)

Starting Metro Bundler
▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
█ ▄▄▄▄▄ ██▄▄ ▀▄▄ █ ██ █▄██▄██▀█ ▄▄▄▄▄ █
█ █   █ █▀▄  ██ ▀▄▀ ██ █▀█▀█▀ █ █   █ █
█ █▄▄▄█ █▄▀ █▄  ▄▀▄▀▄█▄ ▄ ▄▀█▄█ █▄▄▄█ █
█▄▄▄▄▄▄▄█▄▀▄█ ▀▄█▄█ ▀ █▄█▄█ █ █▄▄▄▄▄▄▄█
█▄ ▀▀█▄▄▄█▄ █▄█ ▄█   ▀█▄ ▄▄ ▀█▀██  ████
█▄ ▀▀▀█▄█▄▀▀ ▄█▀▀▀▄▀▀█▄▄▀ █ ▄ ██   ▄  █
█▄▀▀▄▀▄▄▀▄▀▀█▀  █▄█▄ ██▀ █▀█  ▄▄ █ ▀▄▄█
█▄▄▀▄▀█▄▄█  █▀  ▄ █▄█ ▄▀██▄  █ ██▀▀ ▄▄█
█ ██  ▄▄  ███▄█▄ ▄   ▄██▀█▄   █▄ ▄  ▄██
█▀▀█ ▄▄▄█ ▄ ▀▄▄ ▄▄█▀▄█▄▀ █▄█▄▀▀█▄  █  █
█▀███▀▄▄▀▀▄▀▄▀▀█▀ ▄▄▀ ██ ▀ ▀ █▄▄  █▄▄██
█ ██ █▄▄ ▄▄ █▀ ▄▄██▄▀▀█▀▀██ ▄▀   █▀█ ▄█
█▀  █ ▄▄▄██ ▄▄▄█ ██▄▄ ▄█▀ ██  ▀▄ █ ▀███
█ █████▄█▄▄▄ ▄██▄▀█▄▀▀▄██▄▄█▄▄█▀▀▄▀▀ ▄█
█▄█▄█▄█▄▄▀▄▄▄▀▀▀▀▄ ▄▀▄██▀█ ▄█ ▄▄▄   █▄█
█ ▄▄▄▄▄ █ ▄▄▄▀▀█▄█▄ ▄▀▄▀ ▄▄██ █▄█ ▀█▀▄█
█ █   █ ██▀██▄█ ▄█▄ ▀▀██ ▄   ▄  ▄▄▀ ▀ █
█ █▄▄▄█ █▀█▄ ▄█▀ ▄██▀▀█████▀█ ▄▀▀▀▀█▄ █
█▄▄▄▄▄▄▄█▄▄▄██▄▄▄██▄▄▄▄█▄▄███▄▄▄▄▄███▄█

› Metro waiting on
com.anonymous.expo://expo-development-client/?url=http%3A%2F%2F<IP_ADDRESS>%3A8081
› Scan the QR code above with Expo Go (Android) or the Camera app (iOS)

› Press a │ open Android
› Press i │ open iOS simulator
› Press w │ open web

› Press r │ reload app
› Press m │ toggle menu

› Press ? │ show all commands

› Installing on iPhone 13 Pro Max
› Opening on iPhone 13 Pro Max (com.anonymous.expo)
› Opening com.anonymous.expo://expo-development-client/?url=http%3A%2F%2F<IP_ADDRESS>%3A8081 on iPhone 13 Pro Max

› Logs for your project will appear below. Press Ctrl+C to exit.
Error: Unable to resolve module ./index from /Users/nelson/test/apps/expo/.:

None of these files exist:
  * index(.native|.ios.ts|.native.ts|.ts|.ios.tsx|.native.tsx|.tsx|.ios.js|.native.js|.js|.ios.jsx|.native.jsx|.jsx|.ios.json|.native.json|.json|.ios.cjs|.native.cjs|.cjs)
  * index/index(.native|.ios.ts|.native.ts|.ts|.ios.tsx|.native.tsx|.tsx|.ios.js|.native.js|.js|.ios.jsx|.native.jsx|.jsx|.ios.json|.native.json|.json|.ios.cjs|.native.cjs|.cjs)
    at ModuleResolver.resolveDependency (/Users/nelson/test/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:136:15)
    at DependencyGraph.resolveDependency (/Users/nelson/test/node_modules/metro/src/node-haste/DependencyGraph.js:231:43)
    at /Users/nelson/test/node_modules/metro/src/lib/transformHelpers.js:129:24
    at Server._resolveRelativePath (/Users/nelson/test/node_modules/metro/src/Server.js:1137:12)
    at async Server.requestProcessor [as _processBundleRequest] (/Users/nelson/test/node_modules/metro/src/Server.js:464:37)
    at async Server._processRequest (/Users/nelson/test/node_modules/metro/src/Server.js:420:9)

is this a metro config error?

i've created a pr for this #32

resolved https://github.com/t3-oss/create-t3-turbo/pull/32

This is still happening with a fresh clone and running "expo start"


there is a question

macdeMacBook-Pro:h264-live-player-master mac$ node server-static.js
New guy
Incomming action 'REQUESTSTREAM'
fs.js:0
(function (exports, require, module, __filename, __dirname) { // Copyright Joy
Error: ENOENT, no such file or directory 'samples/test.h264'
at Error (native)
at Object.fs.statSync (fs.js:797:18)
at Class.get_feed (/Users/mac/Downloads/h264-live-player-master/lib/static.js:22:44)
at Class.start_feed (/Users/mac/Downloads/h264-live-player-master/lib/_server.js:28:27)
at WebSocket. (/Users/mac/Downloads/h264-live-player-master/lib/_server.js:71:14)
at WebSocket.emit (events.js:110:17)
at Receiver.ontext (/Users/mac/Downloads/h264-live-player-master/node_modules/ws/lib/WebSocket.js:816:10)
at /Users/mac/Downloads/h264-live-player-master/node_modules/ws/lib/Receiver.js:477:18
at /Users/mac/Downloads/h264-live-player-master/node_modules/ws/lib/Receiver.js:361:7
at /Users/mac/Downloads/h264-live-player-master/node_modules/ws/lib/PerMessageDeflate.js:238:5
macdeMacBook-Pro:h264-live-player-master mac$

thanks  I got it.

source = {
width     : 960,
height    : 540,
video_path     : "samples/out.h264",  //  no such file or directory 'samples/test.h264'
video_duration : 58,
};

how to set the size of video?  it is too large for page.  thanks

how to get h.264 and out.h264 file?  thanks

h264 are just elementary streams (the raw output of rpicam)


VS not responding

Type: Bug
It takes for ever to open, sometimes It won't open at all and i get a window saying it isn't responding
VS Code version: Code 1.89.0 (b58957e67ee1e712cebf466b995adf4c5307b2bd, 2024-05-01T02:08:25.066Z)
OS version: Linux x64 6.8.0-31-generic snap
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-10300H CPU @ 2.50GHz (8 x 4199)

GPU Status
2d_canvas: unavailable_softwarecanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onopengl: disabled_offrasterization: disabled_softwareraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_softwarewebgpu: disabled_off

Load (avg)
1, 1, 2

Memory (System)
7.62GB (4.87GB free)

Process Argv
--no-sandbox --force-user-env --crash-reporter-id f8e58724-b5c9-4722-86d6-a911ecf71e46

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

Extensions (1)

Extension
Author (truncated)
Version

LiveServer
rit
5.7.9

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscorecescf:30445987
vscod805cf:30301675
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
vscrp:30673768
2i9eh265:30646982
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:31000450
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
ccp2r3:30993541
dsvsc020:30976470
pythonait:31006305
chatpanelt:31018789
dsvsc021:30996838
9c06g630:31013171
pythoncenvpt:31022790
dwnewjupytercf:31035177

Does the problem also happen if you launch with all extensions disabled (--disable-extensions)?

i can't launch it at all

i cant launch it at all

so this is what happened; aparently something got broken when i configured my git repository, i'm assuming this was because the folder of my repository was the same one i access from Windows. Yesterday after some long waiting and re-opening Code several times i was able to actually open it and change the directory, Everything working fine since then.


[SUPPORT] Archive operation always release lock on the timeline when try lock failed

Dear community,
I have discovered an issue when using Hudi.If multiple archive tasks run on COW table and set "hoodie.archive.automatic=false", it may cause data problems. If set hoodie.archive.automatic=true, then this issue will not occur.
And then I find that if the archive operation try lock failed, it will always release lock(if exist).

I suspect that this lock release operation may have affected other normal operations.
Perhaps the problem could be avoided by doing it this way?

Looking forward to your valuable suggestions.
Hudi version :0.14.0

archive itself holds an transaction lock, so we need to release it in any case, what is the wrong case you have ecountered?

@danny0405 Sorry, I don't remember the details of the problem (I will confirm with my colleagues and provide the results later), but based on the logic here, wouldn't it be better to attempt to release the lock only when acquiring it, otherwise is there a chance of mistakenly releasing the lock of other operations and causing problems?

otherwise is there a chance of mistakenly releasing the lock of other operations and causing problems?

That's reasonable, we should ensure the lock been acquired in the first place.

@danny0405 @Ytimetravel The behavior of method TransactionManager#endTransaction itself is correct, it would check whether the current lock is hold by itself before it unlock. However, there is a bug in HoodieTimelineArchiver  because archiving itself is not a transaction and does not correspond to any instant in timeline. When an exception occurs, it might mistakenly deletes locks held by others.

@Ytimetravel Would you like to fix this issue?

@beyond1920 Yes, I am very willing to fix this issue.

This fix has already been tested and verified~

What is the general reason that the trasanction start of archival is failing?

@danny0405 Failed to acquire lock.

Okay, it would be great if you can fire a fix for it.

@Ytimetravel Do we have a fix or JIRA on this?
cc @danny0405

@ad1happy2go The issue is fixed in pr#11160 and merged.


added txid to object page

Transaction ID added to Object page.

LGTM! Feel free to address the tooltip in a separate PR if we don't have that yet


Feature/fix_inability_to_publish

modified:   README.md
modified:   action.yml

Whoops, made a mistake there, sorry!


bug(autocomplete): scroll locking

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
autocomplete does not behave like other material compnents like menu or select - those lock the scrolling of the underlying div/html/body.

Reproduction
Steps to reproduce:

https://material.angular.io/components/select/overview
open autocomplete and scroll on body

Expected Behavior
scroll is locked
Actual Behavior
scrolling is enabled - inconvenient behavior between material components, resulting in multiple issues e.g. z-index or if a container for scrolling is used the autocomplete panel does not scroll.
Environment

Angular: 15.1.1
CDK/Material: 15.1.1
Browser(s): all
Operating System (e.g. Windows, macOS, Ubuntu): all

Is this under any considerations for fixing? This is also not working when having more than one autocompletes per page and using scroll blocking strategy. Focusing first autocomplete will work as expected, but if you focus first, and then focus second, the second one scroll strategy is broken.

Is it really hard to add a transparent backdrop?

Solution for 16.0.2
@Directive({
  selector: '[matAutocomplete][autocompleteBackdrop]',
})
export class MatAutocompleteBackdropDirective implements OnInit {
  constructor(private readonly matAutocompleteTrigger: MatAutocompleteTrigger) {}

  ngOnInit(): void {
    this.matAutocompleteTrigger['_getOverlayConfig'] = (): OverlayConfig => {
      return new OverlayConfig({
        positionStrategy: this.matAutocompleteTrigger['_getOverlayPosition'](),
        scrollStrategy: this.matAutocompleteTrigger['_scrollStrategy'](),
        width: this.matAutocompleteTrigger['_getPanelWidth'](),
        direction: this.matAutocompleteTrigger['_dir'] ?? undefined,
        panelClass: this.matAutocompleteTrigger['_defaults']?.overlayPanelClass,
        hasBackdrop: true,
        backdropClass: 'cdk-overlay-transparent-backdrop',
      });
    };
  }
}

I have the same issue in angular 18 in a dialog:
Repro Steps

Create a dialog with content that requires scrolling to see the full content
Add inputs with autocomplete
Scroll down/up in the dialog.

Actual Result
The autocomplete suggestions are not sticking to its corresponding input (just like the video above)
Expected Result
Autocomplete suggestions sticks to the input, also while scrolling.
Debugging
I am quite new to angular and web-development in general.
Some of these concepts are still a bit hard to grasp.
However, I have tried several suggestions online:

Adding a div with cdkScrollable around mat-dialog-content: Same behavior
Adding cdkScrollable to mat-dialog-content: The dialog disappears

Environment

Angular: 18.0.0
Angular Material: 18.0.0
OS: Ubuntu 20.04
Browsers: Firefox, Chrome

Hi team,
any news on this?
i saw this ticket was created in 2023...


Legend customization small fixes

[ ] When not having a by size style we should disable the link to 'size' instead of showing just none.
[ ] Change 'COLOR' and 'SIZE' to  'POINTS COLOR' - 'POINTS SIZE'. Note that it could be points/polygons/lines

S/B 10521471 - different "size" question: can we expose code that clients can modify to increase legend width?
Looks like containing div is not available in custom legend HTML to add inline width (min-width or max-width) style to, right?
Or is there another way we want clients to do this anyway if they're using custom HTML view, instead of inline style hack?


May I know application.properties

I want to try to build one but don't know what should I prepare about  application.properties
Thanks for help

Maybe this?
# application.properties
line.bot.channelSecret = XXXXX
line.bot.channelToken = XXXXX
line.bot.handler.path = /callback

https://qiita.com/aytdm/items/7b8692662a0b161c555c

Please refer to this:
# ButtonMessage API
line.channel.id=<YOUR LINE CHATBOT CHANNEL ID>
line.channel.secret=<YOUR LINE CHATBOT CHANNEL SECRET>
line.id=<YOUR LINE CHATBOT ID>
line.api.url=https://api.line.me/v2/
line.api.message.reply.url=bot/message/reply
line.api.message.push.url=bot/message/push
line.access.token=<YOUR LINE ACCESS TOKEN>

# LINE Pay API
line.pay.channel.id=<YOUR LINE PAY CHANNEL ID>
line.pay.channel.secret=<YOUR LINE PAY CHANNEL SECRET>
line.pay.api.url=https://api-pay.line.me
line.pay.api.reserve.url=/v2/payments/request
line.pay.confirm.url=<YOUR LINE PAY CONFIRM URL>
line.pay.cancel.url=<YOUR LINE PAY CANCEL URL>

# Google DialogFlow API
google.dialogflow.api.key=<NOT USE NOW>

# Server configuration
server.port=<YOUR HTTPS PORT>
security.require-ssl=true
server.ssl.key-store=<YOUR KEYSTORE PATH>
server.ssl.key-store-password=<YOUR KEYSTORE PASSWORD>
server.ssl.keyStoreType=PKCS12
server.ssl.keyAlias=<YOUR KEYSTOERE ALIAS>

Thank you!


Create 0000-01-02-GrabAl.md

Now its commented

Merging pull request

created a branch, created a file and made a commit, and opened a pull request

created a branch, created a file and made a commit, and opened a pull request

The first comment on your pull request will have the default text of No description provided. Click on the ... icon located at the top right corner of the comment box, then click on Edit to make an edit
Add a description of the changes you've made in the comment box. Feel free to add a description of what you’ve accomplished so far. As a reminder, you have: created a branch, created a file and made a commit, and opened a pull request
Click the green Update comment button at the bottom right of the comment box when done
If you would like assistance troubleshooting the issue you are encountering, create a post on the GitHub Community board. You might also want to search for your issue to see if other people have resolved it in the past.


Revert "Addition an automaticallyVerticalDirection var and logic for it."

Reverts escamoteur/super_tooltip#34

Why is that reverted?

After this merge, i get a compiling error
if (automaticallyVerticalDirection) { if (_targetCenter!.dy > overlay!.size.center(Offset.zero).dy) {. <<<<<------- error in this line popupDirection = TooltipDirection.up; } else { popupDirection = TooltipDirection.down; } }

what sort of error?


assorted fixes to get the current master branch to build on Windows

linked a few missing libraries that caused undefined references with MSVC
changed a few and (that MSVC does not understand) into &&
allocated a double[] as a double * on heap as MSVC does not accept non-const static arrays, and a couple others as std::vector<double>
adjusted some indentation (purely cosmetic)

Interesting that this is required for you. I have done Windows builds recently without problems. At least I think I have.

I have been using MSVC2015. Maybe the most recent version is smarter than that.

On 18 Jul 2017, at 02:04, Greg Landrum<EMAIL_ADDRESS>wrote:
Interesting that this is required for you. I have done Windows builds recently without problems. At least I think I have.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Removed traces of 3D Curve/Profile

Current coverage is 68.22% (diff: 100%)

Merging #123 into master will not change coverage

@@             master       #123   diff @@
==========================================
  Files             7          7
  Lines           768        768
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            524        524
  Misses          244        244
  Partials          0          0

Powered by Codecov. Last update 57357ef...21b934d

According to Landscape: 12 problems were fixed. - fixes #124
@grzanka ready for re-review :)

I deleted my ant6:branch by accident -.- Reopening PR


Jump + dodge causes animation tree to break

When you land after jumping and dodging at the same time you are in a perpetual running state, even when standing still the run animation will keep playing.

This sounds like the bug from day 1 release that was patched. I can't seem to recreate the issue. Are you using the current build? Check the date of your download against the current branch.

If you can't confirm you're still having this issue on the latest build, I'm going to assume it's a duplicate from the v1.0.0 release day that was already patched and close this out.
Let me know, I'll give it a few more days.

I'll post a PR soon fixing this.

If you really don't believe this bug exists, start running and without releasing the run button, leave the control stick in neutral, you will start running in place

I agree, i was quick to assume you had a repeat issue. I apologize for that but your initial post of how to create the issue is unclear. You were talking about actions taken when jumping and dodging and so i was doing a lot of meddling with jumping and dodging and simply coudln't find what you were referring to.
Thanks for your later comment though about keeping the run button held and simply releasing the directional control. That very quickly confirmed the issue and led to a speedy fix.
I strongly apologize for assuming it was a former bug, and i greatly appreciate your persistence in troubleshooting it with me. You've called me out on it, and the call out is warranted. I'll keep a more open mind moving forward for sure.


Hierarchy

Proposition to answer issue #31

Broke the hierarchy in devices.

The same can be done later for other modules more easily because generate_api and plot_images are automatized (no dependence on modules names).

Broke geometries in geometries (hyp tap etc...) and tests (alignment, resolution etc...), and design in design (classes) and cells (pre-built cells).

Updated documentation accordingly (check qnngds documentation for user and for dev).

Created a __default_param.py file to store the default values in functions over the entire module.

Okay I created separate issues and replied to all the comments I originally left referencing those issues so that way only a few things need to be addressed here before merging.


[Feature Request] Reverse Lookup of Teams/Users in Repositories under Collaborators

Gitea version (or commit ref):
Git version:
Operating system:
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[x] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
Provide a solution to view collaborators/teams from the repository collaborator page or elsewhere in the repository pages.
...
Screenshots

it is frontend enhancement which should be implemented to give an overview who has access to what.

Version 1.10.0 supports reverse lookup for teams but currently not for users themselves. I think reverse lookup of teams is fine so I close the issue.
Reverse lookup of users is confusing if you have a large organization with many teams and users.


Feature: "in" query clause functionality

Would be great if an "in" filter could be applied to a query like so:
data.and("first_name").in(["Larry", "Curly", "Moe"]);
...vs using a loop/map/whatever:
names.forEach(name => {
    data.or("first_name").eq(name);
});

This is a duplicate of #44 so I'm gonna go ahead and close it.


Terminates during load testing

When running on a Digital Ocean 512MB VPC, if I load test it with hey -m GET -c 5000 -n 10000 <host> (5000 concurrent, 10000 connections), pocketbase will terminate. my expectation is that it would be resilient enough to stay running

What's the recommended way to make this more durable? One person could take down my server quite easily

@lukepighetti Looks like it was terminated by the OS? Need more information on which limit has been reached that lead to termination

Without clear reproducible steps, how the environment was configured and what are those TLS errors, there is nothing much I can help with.
If the process was terminated it was most likely due to OOM but again without details what is even the above screenshot supposed to show I can't help.
For benchmarks you can check https://github.com/pocketbase/benchmarks.
If you need further assistance, please provide more details in a Q&A discussion as the threaded format is more suitable for this.

Is there any way to convert this into a discussion? That would have been a better place to post it


Sorting is broken when cell data is undefined

Hey,
thank you for this amazing package!
I get an error when a cell contains undefined data:
[Vue warn]: Error in render: "TypeError: d is undefined"
full backtrace:
TypeError: d is undefined
Stack trace:
cook@webpack-internal:///167:928:7
compare@webpack-internal:///167:931:9
processedRows/computedRows<@webpack-internal:///167:6531:18
mutator@webpack-internal:///1:829:18
processedRows@webpack-internal:///167:6519:24
get@webpack-internal:///1:3114:13
evaluate@webpack-internal:///1:3221:16
computedGetter@webpack-internal:///1:3473:9
paginated@webpack-internal:///167:6542:11
get@webpack-internal:///1:3114:13
evaluate@webpack-internal:///1:3221:16
computedGetter@webpack-internal:///1:3473:9
get@webpack-internal:///1:1919:7
render@webpack-internal:///167:14898:51
renderMixin/Vue.prototype._render@webpack-internal:///1:4473:15
updateComponent@webpack-internal:///1:2764:18
get@webpack-internal:///1:3114:13
run@webpack-internal:///1:3191:17
flushSchedulerQueue@webpack-internal:///1:2953:5
nextTick/<@webpack-internal:///1:1812:9
flushCallbacks@webpack-internal:///1:1733:5

I guess this error comes from:
https://github.com/xaksis/vue-good-table/blob/5f9eb92ef79297c5a40184c7b9266256920a531e/src/components/types/default.js#L15
Is there a workaround for this, like setting a default value to a null cell. Or is it a bug?
Cheers,
Jannis

@jannishuebl You're very welcome! Thank you for bringing this up. looks like a bug, will take a look at it shortly. An interim workaround would be to replace undefined with empty text.

@xaksis You can check an undefined value in your default compare function. There is a cook function that assumes that the value passed to it will be text. You can check it there and set the text to be an empty string.That will solve this issue
compare: function compare (x, y) {
function cook (d) {
return d.toLowerCase()
}
x = cook(x)
y = cook(y)
return (x < y ? -1 : (x > y ? 1 : 0))
}

@jannishuebl @bcrowe306 this should now be fixed in v1.19.3


populate_sdk does not generate include folder

I have an existing OpenEmbedded Project, and an image called core-image-production.
I followed the instructions below, added layer meta-ros to conf/bblayers.conf and built the image.
https://github.com/ros/meta-ros/wiki/OpenEmbedded-Build-Instructions
I also added the following line to core-image-production.bb
require path/to/image/ros1-image-roslaunch.bb
It builds without problems. However, it does not generate include folder at opt/ros/melodic/
What should I do for it to generate an include folder ?
Thanks,

With a yocto SDK build, you do not get the /opt/ros/<distro> folder, the ros libraries and headers are stored in the sysroot folder for the target under /usr/local/oecore-x86_64/sysroots/.

@windelbouwman I know, it should be at here: /usr/local/oecore-x86_64/sysroots/aarch64-poky-linux/opt/ros/melodic
These are the folders inside melodic folder: bin, etc, lib, share, .catkin. There should also be an include folder but there isn't.

In my case I have to use this include path: /usr/local/oecore-x86_64/sysroots/corei7-64-oe-linux/usr/include/, which includes both linux generic headers, as well as the ros package headers. Btw, I'm using ROS2, maybe this is different with ROS1.


"gamemode (spectator|survival)": "allow" not working

Title says it all, when I give a role this permission, it doesn't work in game, they can only type /gamemode
roles.zip

I'm using v1.6.6+1.20

hello?

I don't think this is a duplicate. I've been using Player Roles to allow certain players access to creative for architectural/design/lore purposes for over a year now and it suddenly stopped working when we updated to 1.20.


specify geopandas version

bcdata bc2pg does not work with geopandas v0.13: https://github.com/smnorris/bcdata/issues/129

fixed in access_model working branch


Provide the ability to instantiate the model using the config file generated with LightningCLI

🚀 Feature
Provide to the user some new interface, or modify the existing LightningCLI so that a model can be instantiated for testing/deployment/demos/notebooks/etc using a config.yaml (e.g., the same one generated during training).
Perhaps LightningCLI can have an extra command (besides fit, etc) that only returns the instantiated model, and perhaps the dataloaders.
Motivation
Currently, pytorch lightning lacks this feature (or it's well hidden!). What's the purpose of having modular training setups if you can't instantiate the trained model (for applications mentioned above) using the configs files you trained with. LightningCLI is rather limiting in that sense.
cc @borda @carmocca @mauvilsa

Instead of using config.yaml (which is only intended for reproducibility) it might be better to extend save_hyperparameters and load_from_checkpoint so that they are compatible with LightningCLI. I think it wouldn't be complex. To avoid the save_hyperparameters logic to import from pytorch_lightning.cli, it could have a custom hyper-parameter provider (maybe context var?) so that the CLI can provide the hyper-parameters dict. Something similar could be done for load_from_checkpoint which would use a custom hyper-parameter loader.

@mauvilsa Wouldn't that hyper-parameter provider load the hyper-parameters from a YAML file anyways?

It wouldn't be loaded from a yaml file. This would happen on instantiation of the LightningModule class. The CLI would take it from self.config.model and that is what save_hyperparameters would get as a dict. At this point no config has been saved to disk. This will also mean that hparams.yaml would have the model's config.

You can parse your config using e.g. cfg=Omegaconf.load(..) and then do ModelClass(**cfg.model)

I created pull request #18105 with an initial implementation for what I proposed in https://github.com/Lightning-AI/lightning/issues/15427#issuecomment-1298869338. Note that this loads from a checkpoint, not from a config. @mouroutzoglou you had in mind instantiating from a config. Does loading from a checkpoint resolve your needs? or is it really necessary to only instantiate without loading any weights?

Just ran into this issue today. Expected the pl_module to take in hyper_parameters from the checkpoint to initialize, but it instead used my default config values which were different and resulted in a different architecture and failure of loading of state dict. Would love to see this feature added!


feat: Display active table filter count #1689

The PR fulfills these requirements: (check all the apply)

[x] It's submitted to the main branch.
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
[x] When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
[x] If changes were made to ui folder, unit tests (make test) still pass.
[x] New/updated tests are included

Closes #1689
As requested in the ticket, I have updated the table component so that it will display a count of selected options just to the top right of the chevron down icon. As suggested, I used onRenderHeader to accomplish this - this means the custom renderer for the column now displays the name, sort icon, chevron icon and count. The code changes are in ui/src/table.tsx and here is a screen shot of what it looks like:

And here is a short video demonstrating the filtering after this change:
https://github.com/user-attachments/assets/fa6f7b85-4a62-40cc-bb08-834b366f4339
Question for you: The count is being rendered in red with a red border to match how the requirement is defined in the ticket. I wasn't sure if that was done in red make it stand-out in the screen shot or if this is how it was supposed to be implemented. Can you confirm if red text with red border is what you expect?
I added 3 new unit tests to ui/src/table.test.tsx that check for the new filter counts. These pass along with all the other unit tests. Here is a screen shot of the results from running all the regression tests:

I also ran the visual regression tool at tools/showcase. This was fine except for 3 mismatches found with time_picker-2.png, time_picker-3.png, and time_picker-4.png. I looked at the before and after images and they looked identical to me, so I could not figure out why these were flagged. I suspect these were just false positives?
Let me know how this looks and if you have any questions or suggested changes. Thanks!

Thanks @dbranley! You are doing a superb job lately :)

The count is being rendered in red with a red border to match how the requirement is defined in the ticket. I wasn't sure if that was done in red make it stand-out in the screen shot or if this is how it was supposed to be implemented. Can you confirm if red text with red border is what you expect?

The red was just for illustration. The implementation needs to respect theme colors like the rest of the Wave components. As for the UI design, I would go for badge/chip design, something along the lines of

But more subtle. You can give it a a first go if you want and I can adjust afterwards.

@mturoci - Thanks for all the great feedback! I'll get to all this after I'm done with the background image issue. Thanks!

@mturoci - Thanks for clarifying the requirement for the UI design of the filter count. I removed the border and the red. I also tried to make it have more of a badge design, using a slightly darker background than what is used for the header. Here's a screen shot of what this looks like now:

Let me know if this is what you had in mind.
I also re-ran all the unit tests and everything still passes:

I think I've addressed all the review comments. If there's something else you need, let me know. Thanks!

Thanks @dbranley! Will try to look into this by the end of the week as I am pretty busy.

@mturoci Thanks for catching this! FYI that it does not appear to be a regression, since I was able to replicate the bug even with the original version table.tsx, before changes in this PR. But I can still try to fix the bug as part of this PR.
From the debugging I've done so far, I can see that the menuFilters state variable within the ContextualMenu component is getting updated correctly when selectAll is clicked and I have confirmed that the list of <Fluent.Checkbox> components contained in ContextualMenu are created correctly with the right state for checked. But for some reason that I haven't figured out yet, the component is not getting re-rendered consistently, even though the props are getting updated correctly. So far the code in table.tsx seems to be doing all the right things, which might mean there is an underlying bug in Fluent. But I've really just started debugging, so it's possible the bug is there in table.tsx - I will continue debugging.
Note that since this seems unrelated to this PR, would it make sense to open a new bug for this issue so we can let the PR go through? If so, then I can focus on the bug without holding this PR up. Regardless, I'll keep plugging away at this! Thanks!

If it's not a regression, this PR is good to be merged, thanks!


Fix typo and add for Databases

Edited for both English and Chinese.

Renamed robomongo to Robo 3T
Fixed a few typo
Add DBeaver for Database

Thanks!


Group imports and use prelude

Waiting for https://github.com/gtk-rs/gir/pull/1416 and also need to cover the other crates manual code.


Code block text is different structure depending on newline kind used

Given the following escaped text using line feeds:
let code_to_parse = "```\ntest\n\ntest\n```\n";

...the output is...
0..18 Start(CodeBlock(Fenced(Borrowed(""))))
4..15 Text(Borrowed("test\n\ntest\n"))
0..18 End(CodeBlock(Fenced(Borrowed(""))))

However, if carriage return line feeds are used...
let code_to_parse = "```\r\ntest\r\n\r\ntest\r\n```\r\n";

...the output is...
0..22 Start(CodeBlock(Fenced(Borrowed(""))))
5..9 Text(Borrowed("test"))
12..17 Text(Borrowed("\ntest"))
0..22 End(CodeBlock(Fenced(Borrowed(""))))

Shouldn't they be the same? Or is this some weird markdown thing I don't know about?

That does look like a bug. Besides the normalization of line endings which the spec doesn't mandate, it seems to strip one empty line altogether. That's definitely not right.
I'll have a look. Thanks for reporting this.

@marcusklaas yeah, I noticed it because blank lines were being stripped. It will also remove multiple consecutive blank lines.

Hmm, weird. I tested your string locally, and my version of pulldown (0.7.2) produces "
test\n\ntest\n
\n" for both inputs, which doesn't strip the newlines.
What version of pulldown and platform are you running?

@marcusklaas I'm using 0.7.2 on Windows 10. I didn't check the output of it, but I've just been looking at the Events when using into_offset_iter() with these options:
let mut options = Options::empty();
options.insert(Options::ENABLE_TABLES);
options.insert(Options::ENABLE_FOOTNOTES);
options.insert(Options::ENABLE_STRIKETHROUGH);
options.insert(Options::ENABLE_TASKLISTS);

let markdown_text = "```\r\ntest\r\n\r\ntest\r\n```\r\n";
for (range, event) in Parser::new_ext(markdown_text, options).into_offset_iter() {
    println!("{:?} {:?}", range, event);
}

Wow, very strange. I'm running the same platform and version and that code produces this on my machine:
Start(CodeBlock(Fenced(Borrowed("")))) 0..22
Text(Borrowed("test")) 5..9
Text(Borrowed("\n")) 10..11
Text(Borrowed("\ntest")) 12..17
Text(Borrowed("\n")) 18..19
End(CodeBlock(Fenced(Borrowed("")))) 0..22

A headscratcher, this one.

@marcusklaas wait it's doing that for me too once I created that more simpler example. Sorry, there is a bug deeper down in my code that was striping the empty blank lines. Sorry to waste your time on this one!

I'm going to close this as that seems like reasonable output. Sorry again!! I have a custom iterator that does a few extra things and striping "empty" text events was one of them...

No worries, it happens. Please don't hesitate to open other issues when you run into problems. These things make pulldown better :-)


refactor: change the signal setter type to show clearer type errors

The effects of this change are viewable here: https://tsplay.dev/WkMnDN

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.253%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1206

Relevant Lines:
1289

💛  - Coveralls


Reuse existing notifications tab, if available

Fixes issues #50 and incidentally, #43
Complete JS newb, so inspect thoroughly. :)

Thanks for the guidance. Like I said, JS newb. :)

Landed. Thank you :)

Hah, sorry. Forgot about this. Read the notification, didn't act on it immediately, then forgot. Glad it is sorted!

Apparently with this change, clicking on the notifier would turn my left-most tab to GitHub notification page regardless whether that tab is originally on the notification page.


Selectable bbb version

Fixed #200
Some product like fairblue works not for the newest BigBlueButton release anytimes.
The copy task is needed to overwrite content. (see ansible Issue #58386)

Nice, test deploying right now.
I guess running bbb_version: 2.3.3 with bbb_state: "latest" will be no problem since the apt repo will always be the latest version since its a fixed version.

First error:
TASK [ansible-role-bigbluebutton : add bigbluebutton.org repo key] **************************************************************************
fatal: [meet.bbb.ansibletest.safeserver-support.de]: FAILED! => {"changed": false, "msg": "Failed to download key at https://ubuntu.bigbluebutton.org/repo/bigbluebutton.asc: Request failed: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:852)>"}

OK now I ignored the SSL cert validity to test this and got this error:
TASK [ansible-role-bigbluebutton : add Bionic dependency apt repositories] ******************************************************************
failed: [meet.bbb.ansibletest.safeserver-support.de] (item=ppa:bigbluebutton/support) => {"ansible_loop_var": "item", "changed": false, "item": "ppa:bigbluebutton/support", "msg": "Failed to update apt cache: E:The repository 'https://ubuntu.bigbluebutton.org/bionic-230-2.3.3 bigbluebutton-bionic Release' does not have a Release file."}
failed: [meet.bbb.ansibletest.safeserver-support.de] (item=ppa:rmescandon/yq) => {"ansible_loop_var": "item", "changed": false, "item": "ppa:rmescandon/yq", "msg": "Failed to update apt cache: E:The repository 'https://ubuntu.bigbluebutton.org/bionic-230-2.3.3 bigbluebutton-bionic Release' does not have a Release file."}
failed: [meet.bbb.ansibletest.safeserver-support.de] (item=ppa:certbot/certbot) => {"ansible_loop_var": "item", "changed": false, "item": "ppa:certbot/certbot", "msg": "Failed to update apt cache: E:The repository 'https://ubuntu.bigbluebutton.org/bionic-230-2.3.3 bigbluebutton-bionic Release' does not have a Release file."}

First error:
TASK [ansible-role-bigbluebutton : add bigbluebutton.org repo key] **************************************************************************
fatal: [meet.bbb.ansibletest.safeserver-support.de]: FAILED! => {"changed": false, "msg": "Failed to download key at https://ubuntu.bigbluebutton.org/repo/bigbluebutton.asc: Request failed: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:852)>"}

Common Name (CN)	ubuntu.bigbluebutton.org
Organization (O)	<Not Part Of Certificate>
Organizational Unit (OU)	<Not Part Of Certificate>
Common Name (CN)	R3
Organization (O)	Let's Encrypt
Organizational Unit (OU)	<Not Part Of Certificate>
Issued On	Saturday, April 17, 2021 at 4:22:50 AM
Expires On	Friday, July 16, 2021 at 4:22:50 AM
SHA-256 Fingerprint	77 FE 69 7A F3 11 94 73 22 D1 16 43 5E 85 02 36
54 DC 1C AE 9C 02 55 37 57 C0 F1 C0 77 08 DF 15
SHA-1 Fingerprint	E2 6B 92 07 8D 9F 48 3B C0 F8 68 10 5F 37 25 09
2A CF 0E 3F

Hmmmm it's expired...
https://crt.sh/?q=ubuntu.bigbluebutton.org
https://crt.sh/?id=4387940468

May you steped in a no valid TLS certificat time slot. Can you try it again?

This is a nice addition we should get this merged @Davka @crosscodr

Hi @wilkis3,
please consider doing a rebase instead of merging bbb/2.3 branch.
Its much easier to see the actual changes then.

Hi @wilkis3,
please consider doing a rebase instead of merging bbb/2.3 branch.
Its much easier to see the actual changes then.

Okay, I will do it the next time. There was a merge conflict in the README.md.

Hi @wilkis3,
please consider doing a rebase instead of merging bbb/2.3 branch.
Its much easier to see the actual changes then.

Okay, I will do it the next time. There was a merge conflict in the README.md.

@crosscodr looks the pull request good?

Moved this PR to #266 due to inactivity


Nameserver limits were exceeded

Every pod in k8s has these warnings in the events log, but the pod runs okay. Is this a kube-ovn problem?
  Warning  MissingClusterDNS  10m (x1131 over 23h)  kubelet, THE.NODE.IP.HERE  pod: "metrics-server-697746ff48-krmpt_kube-system(43584748-5bba-439f-ad38-f3fa5277cfa6)". kubelet does not have ClusterDNS IP configured and cannot create Pod using "ClusterFirst" policy. Falling back to "Default" policy.
  Warning  DNSConfigForming   83s (x1138 over 23h)  kubelet, THE.NODE.IP.HERE  Nameserver limits were exceeded, some nameservers have been omitted, the applied nameserver line is: <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>

ovn pinger pod
 k describe pod kube-ovn-pinger-kf7xw
Name:         kube-ovn-pinger-kf7xw
Namespace:    kube-ovn
Priority:     0
Node:          THE.NODE.IP.HERE/ THE.NODE.IP.HERE
Start Time:   Wed, 30 Sep 2020 17:44:11 +0200
Labels:       app=kube-ovn-pinger
              component=network
              controller-revision-hash=85c5d4fd85
              pod-template-generation=1
              type=infra
Annotations:  ovn.kubernetes.io/allocated: true
              ovn.kubernetes.io/cidr: <IP_ADDRESS>/16
              ovn.kubernetes.io/gateway: <IP_ADDRESS>
              ovn.kubernetes.io/ip_address: <IP_ADDRESS>
              ovn.kubernetes.io/logical_switch: ovn-default
              ovn.kubernetes.io/mac_address: 00:00:00:72:BD:05
              ovn.kubernetes.io/network_types: geneve
              ovn.kubernetes.io/routed: true
Status:       Running
IP:           <IP_ADDRESS>
IPs:
  IP:           <IP_ADDRESS>
Controlled By:  DaemonSet/kube-ovn-pinger
Containers:
  pinger:
    Container ID:  docker://3287f43814753350dd798bac8bba0329a5d7596c0dde41dc4092db76e06348e1
    Image:         kubeovn/kube-ovn:v1.5.0
    Image ID:      docker-pullable://kubeovn/kube-ovn@sha256:f7945ae1104ae631d56c5acb7158b023e6e36a723b9556ee5bd0a6ccfa21fd42
    Port:          <none>
    Host Port:     <none>
    Command:
      /kube-ovn/kube-ovn-pinger
      --external-address=<IP_ADDRESS>
      --external-dns=alauda.cn
    State:          Running
      Started:      Wed, 30 Sep 2020 17:56:24 +0200
    Ready:          True
    Restart Count:  0
    Limits:
      cpu:     200m
      memory:  400Mi
    Requests:
      cpu:     100m
      memory:  300Mi
    Environment:
      ENABLE_SSL:  true
      POD_IP:       (v1:status.podIP)
      HOST_IP:      (v1:status.hostIP)
      POD_NAME:    kube-ovn-pinger-kf7xw (v1:metadata.name)
      NODE_NAME:    (v1:spec.nodeName)
    Mounts:
      /etc/openvswitch from host-config-openvswitch (rw)
      /lib/modules from host-modules (ro)
      /run/openvswitch from host-run-ovs (rw)
      /sys from host-sys (ro)
      /var/log/openvswitch from host-log-ovs (rw)
      /var/log/ovn from host-log-ovn (rw)
      /var/run/openvswitch from host-run-ovs (rw)
      /var/run/ovn from host-run-ovn (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from ovn-token-tgv9d (ro)
      /var/run/tls from kube-ovn-tls (rw)
Conditions:
  Type              Status
  Initialized       True
  Ready             True
  ContainersReady   True
  PodScheduled      True
Volumes:
  host-modules:
    Type:          HostPath (bare host directory volume)
    Path:          /lib/modules
    HostPathType:
  host-run-ovs:
    Type:          HostPath (bare host directory volume)
    Path:          /run/openvswitch
    HostPathType:
  host-run-ovn:
    Type:          HostPath (bare host directory volume)
    Path:          /run/ovn
    HostPathType:
  host-sys:
    Type:          HostPath (bare host directory volume)
    Path:          /sys
    HostPathType:
  host-config-openvswitch:
    Type:          HostPath (bare host directory volume)
    Path:          /etc/origin/openvswitch
    HostPathType:
  host-log-ovs:
    Type:          HostPath (bare host directory volume)
    Path:          /var/log/openvswitch
    HostPathType:
  host-log-ovn:
    Type:          HostPath (bare host directory volume)
    Path:          /var/log/ovn
    HostPathType:
  kube-ovn-tls:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  kube-ovn-tls
    Optional:    true
  ovn-token-tgv9d:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  ovn-token-tgv9d
    Optional:    false
QoS Class:       Burstable
Node-Selectors:  kubernetes.io/os=linux
Tolerations:     :NoSchedule
                 node.kubernetes.io/disk-pressure:NoSchedule
                 node.kubernetes.io/memory-pressure:NoSchedule
                 node.kubernetes.io/not-ready:NoExecute
                 node.kubernetes.io/pid-pressure:NoSchedule
                 node.kubernetes.io/unreachable:NoExecute
                 node.kubernetes.io/unschedulable:NoSchedule
Events:
  Type     Reason             Age                     From                     Message
  ----     ------             ----                    ----                     -------
  Warning  MissingClusterDNS  8m15s (x1133 over 23h)  kubelet,  THE.NODE.IP.HERE  pod: "kube-ovn-pinger-kf7xw_kube-ovn(2b4eab0b-53c9-4e91-bde1-8630600beb09)". kubelet does not have ClusterDNS IP configured and cannot create Pod using "ClusterFirst" policy. Falling back to "Default" policy.
  Warning  DNSConfigForming   3m12s (x1137 over 23h)  kubelet,  THE.NODE.IP.HERE  Nameserver limits were exceeded, some nameservers have been omitted, the applied nameserver line is: <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>

You have too many entries in /etc/resolve.conf.  K8s coredns and flannel nameserver limit exceeded might be helpful


When no username is specified - display account ID

It's needed for situations when username field is optional in account registration form

Further related improvements in Sign-up form:

[ ] Make "Account name" optional in Forms builder.
[ ] Make "Receive news" optional
[ ] Make "Agreement" optional
[ ] Move social login buttons to their own separate block.

Only email and password should be required at this stage. Later, we can add "generated password" email that works as a confirmation email as well. Then, only email would be a required field.
"Account name" is largely redundant, since it's not unique and may be confused as a login-username. UNA doesn't accept account name at login, so it only makes things more confusing. Operators can add extra identification fields via Forms builder if required at account-stage registration.
"Agreement" notice may also not be needed in many cases, or may be better positioned outside of the signup form. For example, as a pop-over along with "cookies" agreement, or as a separate custom underneath the signup form.
"Receive news" is often not needed when newsletters are handled by separate subscription service subscribe form (Mailchimp) or not used at all. Site notifications are not newsletters and don't need opt-in.
Social login buttons work both as sign-up and sign in, so it's also best to have them in a separate block, which can be positioned anywhere as needed, or used a sole form of authentication.


Reading a gist in anonymonous mode causes error

When I run
GitHub github = GitHub.connectAnonymously();
GHGist gist = github.getGist(currentGist);
I get the following exception:
java.lang.NullPointerException
at java.util.Hashtable.put(Hashtable.java:464)
at org.kohsuke.github.GitHub.getUser(GitHub.java:293)
at org.kohsuke.github.GHGist.wrapUp(GHGist.java:106)
at org.kohsuke.github.GitHub.getGist(GitHub.java:370)
at ...
SInce i connected anynomously, why is it asking for the user? Is there something i can set to get it to ignore this?

Fixed.

Can you let me know what Maven version to use to get this fix, or do i need to pull the source and build?

You should wait until release + 1-2 days for mirroring on maven repos.

Thank you!
Can you post the link here when it is posted? (As a historical record thing, when I  search posts about how to fix something I hate coming to dead ends where the fix happened off camera)

@madhephaestus i'm just monitoring commits on master to get new version ;)

is there a link to the build instructions? or at least what the mvn params its expecting are?

Confirmed 1.64 does not have this issue.


Streamline ClassLoader and improve plugin imports

differentiate when a plugin is missing vs. when it has a code error and log warnings
fix redundant code and incorrect method documentation
add unit tests to class loader

Codecov Report

Merging #261 into master will increase coverage by 0.05%.
The diff coverage is 84%.

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   74.79%   74.85%   +0.05%
==========================================
  Files         231      231
  Lines       10523    10540      +17
==========================================
+ Hits         7871     7890      +19
+ Misses       2652     2650       -2


fix(cli): Correctly re-establish watch

if err is EOF  , this event is nil

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Looks good. To fix CI run make lint.

I'll be fixing this, and another related issue, in #2944.


Remove webpacker, upgrade bootstrap and fontawesome

Build fail. We need to drink more.

Build fail. We need to drink more.

Haha, relax 🍺


Merge master branch to prTesting1_201901030843 branch

OPS Build status updates of commit 82442c3:
:clock10: Preparing: average preparing time is 51 sec(s)

OPS Build status updates of commit 82442c3:
:clock10: Incremental building: average incremental building time is 16 sec(s)

OPS Build status updates of commit 82442c3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Expose raw MINIDUMP_MEMORY_INFO in MinidumpMemoryInfo

Hello - we are interested in fields such as allocation_base which have not been mapped to the MinidumpMemoryInfo struct, for compat, probably the easiest way is to expose the raw field.  Would it be possible to expose the raw MINIDUMP_MEMORY_INFO field as pub in the MinidumpMemoryInfo struct as seen here?  Thanks! https://github.com/rust-minidump/rust-minidump/blob/469f95c8feb0715ffb514f48945d33ab0038cfb3/minidump/src/minidump.rs#L251

Works for me! Send a PR and I'll merge it

Thanks, just did. https://github.com/rust-minidump/rust-minidump/pull/866

@gabrielesvelto - we were curious when a next release may occur, saw that the last was in May.

I'll cut a new release this week if time permits, or next week at the latest.

I'll cut a new release this week if time permits, or next week at the latest.

Hi, just following up on next release date. Thanks!

Working on it, sorry, some things got in the way

The 0.18.0 is available on crates.io and the release flow on GH is running as I write this.


StormLib 9.30 fumbles on saving version 3 archives (at least on Linux)

I don't know why, but StormLib doesn't save version 3 archives properly (e.g. your MPQ Editor can't open it and SC2's editor would open it, but with a lot of files missing in the archive), but can save version 2 & 4 ones without problems.
There are code source & test archives done by my program.
I'm currently using Linux Mint 21.3 (derived from Ubuntu 22.X) & program is built using clang 14.0.
I can reproduce this problem with or without compiler optimizations enabled.
If you need anything more, please ask me to.
POC:
https://github.com/MadProbe/MPQArchiver
archives.zip
The error image:

MPQs version > 4.0 are not accepted as Starcraft II maps (here):
    // Don't accept format 3 for Starcraft II maps
    if((MapType == MapTypeStarcraft2) && (pHeader->wFormatVersion > MPQ_FORMAT_VERSION_2))
        wFormatVersion = MPQ_FORMAT_VERSION_4;

The MPQ you sent me is OK, just change extension to something else (such as MPQ) and you will be able to open it just fine.

Hmm, thanks!
I think this would still need a mention in the docs as this behavior is not obvious at all.
Also SC2 Editor for some reasons can't load the converted-to-archive-v2/4 map/mod folder as it just refuses to load stuff from Base.SC2Data, but it can still perfectly see map's files well in Imports tab (even 'reserved' files), but that's outside of the scope of StormLib & this issue


How to specify inheritZoom in FixAllBookmarks(PDDoc doc, PDBookmark b, int acc)

Hello, I'm using your Acrobat-Actions plugin. Thank you for the code.
I'm trying to figure out how to to make all of my bookmark actions inherit zoom.
In FixAllBookmarks(PDDoc doc, PDBookmark b, int acc),
you set targetFitType = ASAtomFromString("XYZ"), and zoomLevel = PDViewDestNULL
eg
PDViewDestCreate(doc,
page,                  /* := pageNum /
targetFitType,   / XYZ /
&destRect,
PDViewDestNULL,  / when FitType is XYZ /
0);                  / unused */
Is this equivalent to setting the action zoom level to Inherit Zoom?
Thanks for your help,

Hi,
Thanks for letting me know that my simple plugin has found users other than myself.
Yes, "XYZ" is the keyword for "inherit zoom", which is defined in PDF standard (I remember that I checked the standard or other books to actually know it. It's not from Acrobat SDK document.)
P. S. It's hard to find third-party Acrobat plugin source code on Internet (at least I didn't find anything when I'm writing this code).  If you have ideas (or code) on new features, I hope you can contribute some.
Chun

to fix your trouble check this solution click
maybe this will solve your problem.


GK does not create a new PR after re-enabling integration

Hi. I've enabled GK integration, it created a PR I merged it before travis support was enabled.
Now I have configurated travis then I removed GK integration, added it again but it doesn't create a new PR.
Any ideas?
Thanks in advance!
repo
first PR

It was matter of time. Thanks


Class "ProcessVariables" cannot be resolved

The class "ProcessVariables" cannot be resolved in the snippet from the README
@ZeebeWorker(type = "foo", autoComplete = true)
public ProcessVariables handleFoo(@ZeebeVariablesAsType ProcessVariables variables){
  // do whatever you need to do
  variables.getMyAttribueX();
  variables.setMyAttribueY(42);
  // return variables object if something has changed, so the changes are submitted to Zeebe
  return variables;
}

I used the following dependencies:
<dependency>
	<groupId>io.camunda</groupId>
	<artifactId>spring-zeebe-starter</artifactId>
	<version>8.0.4</version>
</dependency>
<dependency>
	<groupId>io.camunda</groupId>
	<artifactId>spring-zeebe-test</artifactId>
	<version>8.0.4</version>
	<scope>test</scope>
</dependency>

So where does the class "ProcessVariables" come from or is the documentation simply not up-to-date?

Hi @tobiasschaefer.
The class "ProcessVariables" is a class you define yourself - and spring-zeebe will map the process variables into this. But I agree that this can be easily misunderstood by the docs - and I will do quick improvements on the readme.
Hope that helps?
Best
Bernd

Hi @berndruecker ,
your renaming of the class name to MyProcessVariables made it much clearer. Thanks.
Cheers
Tobias


ordering="slug" does not work for tests.short_name

Extracted from https://github.com/Linaro/squad/issues/952
From my discussion with @chaws
build.tests(environment=e.id,suite=s.id,ordering="short_name")

does not appear to be working for the ordering component. it appears to be ordering by id.
Is this the issue? https://github.com/Linaro/squad/blob/9472d5e337a38488d1fb44c986deec7e8a54d6e7/squad/api/rest.py#L1161 only the id is there and thus can't be filtered on other things?

From squad:

I looked at the code and it won't be that easy to via api. Tests are complicated as they're are just too much and we need to order them by id so we can make cursor pagination.
I'll make a generic function in squad-client so you can call it on demand, does that sound good?

From squad:

I looked at the code and it won't be that easy to via api. Tests are complicated as they're are just too much and we need to order them by id so we can make cursor pagination.
I'll make a generic function in squad-client so you can call it on demand, does that sound good?

I gave @chaws some of my sorting snippets and he may include them in the library.

I gave @chaws some of my sorting snippets and he may include them in the library.


feat: add pretty print for dfget

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

lint issue


Migrate plansys2_bt_actions to BehaviorTree.ROS2 wrappers

Changelog
Added

Dependency on nlohmann_json in plansys2_bt_actions/CMakeLists.txt.
Include statements for behaviortree_ros2/ros_node_params.hpp, behaviortree_ros2/plugins.hpp, and <nlohmann/json.hpp> in plansys2_bt_actions/include/plansys2_bt_actions/BTAction.hpp.
New private member node_namespace_ and method createFullyQualifiedName in BTAction to handle namespace qualification in plansys2_bt_actions/src/plansys2_bt_actions/BTAction.cpp.
JSON parsing for plugins in BTAction::on_configure to handle plugin configurations dynamically.

You can now specify the server node names used by the wrappers (ast stands for action, service or topic). I also chose to drop the config/params.yaml for readability in my application (I will change the plansys2_bt_example later).
    move_cmd = Node(
        package='plansys2_bt_actions',
        executable='bt_action_node',
        name='move',
        namespace=namespace,
        output='screen',
        parameters=[
            {
                'action_name': 'move',
                'bt_xml_file': example_dir + '/behavior_trees_xml/move.xml',
                'plugins':  json.dumps([
                    {'name': 'plansys2_NODE_A_bt_node', 'ast': 'topic_a'},
                    {'name': 'plansys2_NODE_B_bt_node', 'ast': 'topic_b'},
                    {'name': 'plansys2_NODE_C_bt_node', 'ast': 'topic_c'}                ])
            }
        ])

Changed

Updated BTAction::BTAction constructor to use a single string for the plugins parameter instead of a vector of strings in plansys2_bt_actions/src/plansys2_bt_actions/BTAction.cpp.
Refactored plugin loading logic in BTAction::on_configure for enhanced flexibility and error handling, including support for both node and ROS node registrations from plugins.

Notes

These changes introduce a dependency on the nlohmann_json library for JSON handling, which requires including this library in the project dependencies.
The new plugin loading approach allows for a more flexible and error-tolerant system, accommodating different types of BehaviorTree.CPP plugins with better diagnostics.
The direct addition of the test directory in the CMakeLists conditional compilation block is now commented out. Tests should be changed to reflect the changes made in this PR.
The ros2_planning_system_examples/plansys2_bt_example has not been adapted for these changes yet. I have tested action, service and topic sub wrappers and they seem to work perfectly.
Please test it yourself before merging.

Failing. The workflow env seems to be missing behaviortree_cpp package

Yes, I opened #306 , but something strange is happening here...

CI seems to be fixed, but it is applying old pipeline. Can you rebase/merge?

I updated to current rolling. No conflicts. Let's see what happens.

Now, the errors are related to the library you included:
2024-04-01T09:36:35.3583120Z CMake Error at CMakeLists.txt:15 (find_package):
2024-04-01T09:36:35.3584039Z   By not providing "Findnlohmann_json.cmake" in CMAKE_MODULE_PATH this
2024-04-01T09:36:35.3585062Z   project has asked CMake to find a package configuration file provided by
2024-04-01T09:36:35.3585914Z   "nlohmann_json", but CMake did not find one.
2024-04-01T09:36:35.3586348Z
2024-04-01T09:36:35.3586754Z   Could not find a package configuration file provided by "nlohmann_json"
2024-04-01T09:36:35.3587552Z   with any of the following names:
2024-04-01T09:36:35.3587901Z
2024-04-01T09:36:35.3588062Z     nlohmann_jsonConfig.cmake
2024-04-01T09:36:35.3588610Z     nlohmann_json-config.cmake
2024-04-01T09:36:35.3588936Z
2024-04-01T09:36:35.3589375Z   Add the installation prefix of "nlohmann_json" to CMAKE_PREFIX_PATH or set
2024-04-01T09:36:35.3590475Z   "nlohmann_json_DIR" to a directory containing one of the above files.  If
2024-04-01T09:36:35.3591506Z   "nlohmann_json" provides a separate development package or SDK, be sure it
2024-04-01T09:36:35.3592280Z   has been installed.

I am not completely happy including a new dependency. I would rather prefer to use parameters and avoiding nlohmann_json.
I also need a better explanation of the utility of this PR :-/

I will have to do that later. I will be on a long vacation soon.
I used json to parse argument pairs. Because i wanted to be able to specify the action name. Like this:
    move_cmd = Node(
        package='plansys2_bt_actions',
        executable='bt_action_node',
        name='move',
        namespace=namespace,
        output='screen',
        parameters=[
            {
                'action_name': 'move',
                'bt_xml_file': example_dir + '/behavior_trees_xml/move.xml',
                'plugins':  json.dumps([
                    {'name': 'plansys2_get_poi_bt_node', 'ast': 'pgrouting_server/get_poi'},
                    {'name': 'plansys2_get_current_location_bt_node', 'ast': 'fix'},
                    {'name': 'plansys2_get_route_queue_bt_node', 'ast': 'pgrouting_server/get_route'},
                    {'name': 'plansys2_follow_route_bt_node', 'ast': 'waypoint'}
                ])
            }
        ])
    ```

   Do you have a preference on how to achieve this?

It is still failing:
-- Build files have been written to: /home/runner/work/ros2_planning_system/ros2_planning_system/ros_ws/build/plansys2_bt_actions
  [ 25%] Building CXX object CMakeFiles/plansys2_bt_actions.dir/src/plansys2_bt_actions/BTAction.cpp.o
  In file included from /home/runner/work/ros2_planning_system/ros2_planning_system/ros_ws/src/b9q00w3heb6/ros2_planning_system/plansys2_bt_actions/src/plansys2_bt_actions/BTAction.cpp:26:
  /home/runner/work/ros2_planning_system/ros2_planning_system/ros_ws/src/b9q00w3heb6/ros2_planning_system/plansys2_bt_actions/include/plansys2_bt_actions/BTAction.hpp:31:10: fatal error: behaviortree_ros2/ros_node_params.hpp: No such file or directory
     31 | #include "behaviortree_ros2/ros_node_params.hpp"
        |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I think BehaviorTree.ROS2 should be added to the workflow environment, correct?

If you did a marge with `rolling,' BT.CPP 4 should be in the CI workflow. May you check it?


Foundation ZURB?

Description

...
Possible Solution

...
Checklist

[ ] I have read and follow the CONTRIBUTING.md document.
[ ] There are no other issues similar to this one.
[ ] The issue title and template are correctly filled.

Get lost.


Loading of adata object

Since we rely on the Lineage class, which cannot be reconstructed when loading the adata
object using sc.read, I think we should have our own wrapper that will also optionally create dummy names, such as Lineage 1 if not present, as well as colors

Can we still use sc.write, or would we also have to replace that?

We can still use that, there's no issue, since Lineage is just a subclass of numpy.ndarray.

@michalk8 alternatively you could also store it as rec.array.

Doesn't recarray support only fixed sized strings for record names? I think this was the main reason why I haven't looked more into them.

It's almost like a dataframe with a string name stored for each column.

Implemented via #97


rbd support

Currently, I have to build a custom version of the kube-controler-manager to add the correct version of ceph rbd tools to support dynamic rbd provisioning.
Ideally the code would be moved out to function like the external cephfs provisioner so that a prebacked kube-rbd-jewel container can be added too.

Initial move has completed: at https://github.com/kubernetes-incubator/external-storage/tree/master/ceph/rbd and the initial version has been pushed to "quay.io/external_storage/rbd-provisioner:v0.1.0"


Error attempting to add Microsoft.Bot.Components.Teams to Bot Composer project

Full message:
If this problem persists, please file an issue on GitHub
Details
Command failed: dotnet add RPIOpsBot.csproj package "Microsoft.Bot.Components.Teams" --version="1.2.0-rc0" --source="https://api.nuget.org/v3/index.json"
Environment:
Running on Windows 10 pro
Version:  2.1.1
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0

@stevkan any update on this?

@mkredpoint, unfortunately, I am unable to repro the issue you are encountering. Is this still occurring for you? A few questions, if so:

Does it occur across different projects or in just the one bot?
Are you running on a corporate network, behind a firewall / proxy?
Are you able to install other packages? Do others fail or is it just this one?
Can you try building/running the bot in Visual Studio (outside of Composer)? Does it work there?
Have you tried uninstalling / re-installing Composer?

Closing due to inactivity.


updating to rc3

Should fix: https://github.com/rangle/augury/issues/450

@sumitarora so there are no breaking changes between rc2 and rc3? Only the package version needed an update?
LGTM :shipit:

yes didn't saw any apart from forms being deprecated warnings


TODO

[x] write to mbtiles
[x] use proper argument parsing lib
[x] increase max zoom level to 14 or maybe 15 (and make it configurable)
[ ] review update mechanism, it likely doesn't really work as is, and maybe should be removed completely

[ ] add a flag that forces an abort if ways are missing nodes (or better the other way around, a flag that would allow it)


Allow receive to close if blocked on channel send

Changes forwarding of received messages to not block if a close is received. This allows the receiver to shut down correctly even in the case of some AMQP link credit bug or protocol violation on the part of a server. It has been tested in an application actively having issues with hanging close calls and this change fixes the problem without other ill effects.
Fixes #38

Sorry for the delay.
I suspect the problem here is that we don't close(l.messages) when the receiver is closed so we end up blocked writing to the channel since nobody is reading from it any more.  Thoughts?

Closed in favor of https://github.com/Azure/go-amqp/pull/115


add system requirements section for linux to tools readme

put insights of #1006 into tools readme
@zth

Perfect, thanks!


Fix "Loss-only modifications may not be explicit." error

Now that users are able to add neutral loss modifications to their peptides using the "Modify Peptide" dialog, the error "Loss-only modifications may not be explicit" no longer applies.
(user "jmr" reported this error with a crosslink modification which had zero mass and some neutral losses, but this error can be reproduced with simple neutral loss modifications)
Also, fix an error "Protein sequence may not be empty" that can happen in the Edit Linked Peptides dialog if the focus is in the new row of the peptide sequences grid when you press "OK" on the Edit Linked Peptides dialog when the focus is in an uncommitted new row in the DataGridView.
(also reported by jmr)

Maybe better to revert all the extra changes to Resources.Designer.cs. Most of them are white space, and two depend on where a string gets truncated in the header comment. Not so sure that the next developer won't just end up setting these back. I have seen other changes recently that were limited to just the strings being changed in that file. Otherwise, it looks good.

Maybe better to revert all the extra changes to Resources.Designer.cs. Most of them are white space, and two depend on where a string gets truncated in the header comment. Not so sure that the next developer won't just end up setting these back. I have seen other changes recently that were limited to just the strings being changed in that file. Otherwise, it looks good.

I suspect that might be happening because I recently used the "Help > Check for Updates" menu item in Visual Studio. I am running Visual Studio version 15.9.34.
What version are other people running?
The dates of each patch release can be found on this page:
https://docs.microsoft.com/en-us/visualstudio/releasenotes/vs2017-relnotes

Looks like I haven't done that in a while. I am using 15.9.23. Maybe we can have everyone do that after we release 21.1 and until then just try avoid unexpected changes to RESX files, i.e. revert the parts you did not intend.

I have reverted the lines where the text of the comments changed.
The remaining changes are cases where the file in master has LF instead of CRLF.
It looks like those incorrectly terminated lines were introduced with the DIA-Umpire checkin earlier this week. (It was complicated to track down, since git blame does not tell you who changed a line ending: only who changed a line)


update the default type for Elasticsearch docs from 'event' to '_doc'…

… + print message body for http error 400
Signed-off-by: Issif<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:
The Elasticsearch has been created years ago, the Elasticsearch engine changed since, and the type is now deprecated for a while, the value to use is _doc. This PR sets _doc as the default type for the ES docs.
The issues we got from community noticed http 400 errors without details, so the PR introduces a print of the body message for this error code to help debug (in case of ES, it prints the wrong mapping for eg).
Which issue(s) this PR fixes:
#348

Fixes #
Special notes for your reviewer:

@Issif: There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/area outputs

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fjogeleit, Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif,fjogeleit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 9a9dfd5be530e8512fadcd097b3c8d91bd427155


All hyperlinks change colour together

When hovering within any area of the text, all hyperlinks change into the hover colour together, instead of the one that is hovered over. Not sure if it is intentional.

can you make a video? seems ok on my end :)

@hypha ah! fixed in #522 😊
thanks!


itemPopularity endpoint fails for some heroes

e.g. https://api.opendota.com/api/heroes/5/itemPopularity

Checked the logs and this parseInt is crashing:
/usr/src/store/queries.js:318
        const time = parseInt(item.time, 10);
                                   ^

TypeError: Cannot read properties of null (reading 'time')
    at /usr/src/store/queries.js:318:36
    at Array.map (<anonymous>)
    at /usr/src/store/queries.js:317:8
    at processTicksAndRejections (node:internal/process/task_queues:83:21)
    ```

@ff137

#2664


update input border color in light theme #5551

Fixes
Issue Number: #5551

What is the current behavior?
Inputs have no borders on light mode:

What is the new behavior?

Other information

PR Checklist

Toggle...
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[ ] I added a line describing my change to CHANGELOG.md
[x] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

Thanks! I merged it, then added a few more commits for card spacing to make it less crowded.

Awesome! thanks! and happy new year 🥳


Bug: __REACT_PIXI_REQUEST_RENDER__ event is not emitted when expected

Current Behavior
I have a project that includes a toggle behavior to render a container component. When I initially render the component, it renders as expected. When I toggle off rendering the container, the __REACT_PIXI_REQUEST_RENDER__ event is emitted and it does not render the container as expected. However, when I attempt to toggle the container to render back on __REACT_PIXI_REQUEST_RENDER__ is not emitted despite running through the code path as expected.
As a work around, I have a useEffect on the parent component set up to run app.stage.emit('__REACT_PIXI_REQUEST_RENDER__') when toggle is turned back on.
Expected Behavior
I expect __REACT_PIXI_REQUEST_RENDER__ event to emit whenever a component changes, including toggling back on the rendering of the container.
Steps to Reproduce
Haven't been able to reproduce on a minimal reproduction of the issue but does seem to be a bug with pixi/react. Will continue to see if I can get a codesandbox reproduction. raf should be set as false on the app.stage options and renderOnComponentChange should be set to true.
Environment

@pixi/react version: 7.1.1
pixi.js version: 7.3.3

Possible Solution
No response
Additional Information
No response

Maybe related to  #408