Feature: Add bazel logo

Bazel is a popular open source build system by Google. It has some pretty compelling adoption. This PR adds a Bazel option for the logo parameter. The SVG in question is extracted directly from Bazel's logo artwork.
Inspired by bazel-contrib/bcr-ui#29. This work may continue, if appropriate, to add a Bazel Central Registry version badge.
cc / @alexeagle @hobofan

preview of this same SVG in use as a data URL, on this project:

Hello @sgammon 👋🏻
Thanks for the contribution. As per our logo guidelines:

Our preferred way to consume icons is via the SimpleIcons logo. As a first port of call, we encourage you to contribute logos to the SimpleIcons project.

Could you please contribute the logo upstream? It looks like they would be open to adding such  a logo there(see https://github.com/simple-icons/simple-icons/pull/5573 and https://github.com/badges/shields/pull/9474).

@PyvesB I contributed this logo here because it follows the other requirements in the guidelines:
In some cases we may also accept logo submissions directly. In general, we do this only when:

We have a corresponding badge on the homepage, (e.g. the Eclipse logo because we support service badges for the Eclipse Marketplace). We may also approve logos for other tools widely used by developers.
The logo provided in SimpleIcons is unclear when displayed at small size on a badge.
There is substantial benefit in using a multi-colored icon over a monochrome icon.
The logo doesn't meet the requirements to be included in the SimpleIcons set.

Particularly:

We may also approve logos for other tools widely used by developers.
There is substantial benefit in using a multi-colored icon over a monochrome icon.

Bazel's icon doesn't work in monochrome, because the shades of green denote the different leaves in the graphic. When expressed in pure green or gray, the logo blends together enough to be unrecognizable.
Bazel is a build tool by Google used by millions of developers, including such companies as both Uber and Lyft, so we thought it was best to contribute directly. I'm sorry, but I really don't want to contribute to another project in order to use them here. I worry that SimpleIcons would reject such a contribution and the risk of that rejection makes me feel like I just shouldn't try to improve Shields at all. Cheers

I understood the guideline you cited is a "preference," being that the language says

In general

In some cases

We may also

If this guidance should be followed in all circumstances, maybe the docs need an update.

@sgammon - I acknowledge it can often be pretty tricky trying to interpret written text, and that I might have gotten the wrong impression. However, the combination of immediately closing the PR and the below quote give me the impression that you might have had a pretty strong reaction, and I felt a need to respond.
:point_down:

the risk of that rejection makes me feel like I just shouldn't try to improve Shields at all. Cheers

In response to a PR like this without any prior issue or discussion, I think it's quite reasonable for one of this project's maintainers to make note of our general procedures and documentation around logos.
If your initial PR description had mentioned that you'd already read our logo docs and included some of the additional context shared in some of your subsequent comments (e.g. concerns with monochrome, your reservations about SI, etc.), then we could've short circuited that standard, initial commentary about general approach to logos.
However, in the absence of such context, we're always going to first note our standard operating procedures, and where relevant, point to docs. If contributing to/improving Shields is something of interest to you, I hope that would still be the case, as I confess I don't personally understand why anything in this thread would have changed that.

If this guidance should be followed in all circumstances, maybe the docs need an update.

I actually agree an update to these docs could be helpful, as I think that subsequent to the last time they were updated we'd taken a stronger position against taking on the maintenance support of new logos and have been contemplating dropping all our native/non-SI logos altogether in favor of SI and our custom logos feature (more discussion in #7684 and issues linked within, if curious for more detail).

This work may continue, if appropriate, to add a Bazel Central Registry version badge.

This seems like it would be a reasonable badge addition, though also seems orthogonal to the custom logo. Would suggest opening a separate issue for this using our issue template if that's a badge that you think would be valuable to the community of users in the Bazel ecosystem.

@calebcartwright you are welcome to respond.

However, the combination of immediately closing the PR and the below quote give me the impression that you might have had a pretty strong reaction, and I felt a need to respond.

It's not a strong reaction, it's just a firm one.

If your initial PR description had mentioned that you'd already read our logo docs and included some of the additional context shared in some of your subsequent comments (e.g. concerns with monochrome, your reservations about SI, etc.), then we could've short circuited that standard, initial commentary about general approach to logos.

From my PR:

Bazel is a popular open source build system by Google. It has some pretty compelling adoption.

On the adoption page

Adobe
Asana
Braintree
Canva
Databricks
Dataform
Dropbox
Etsy
Flexport
Google
Huawei
Line
LinkedIn
Lucid
Lyft
Meetup
Nvidia
Pinterest
Redfin
Snap
Spotify
Stripe
Tinder
Twitter
Two Sigma
Uber
VMware
Wix

Open Source adoption
- Abseil
- Angular
- Dagger
- Envoy
- gRPC
- gVisor
- Jsonnet
- Kubernetes
- Selenium

Why would I have included this context, if not driven by the contribution guidelines? Respectfully, did you click the link I included in the PR? I felt that including the list above would be rude because it is so extensive and polluting to the discussion.

If contributing to/improving Shields is something of interest to you, I hope that would still be the case, as I confess I don't personally understand why anything in this thread would have changed that.

If maintainers aren't even going to ask before declining, and are in general not going to click links or read PRs or evaluate them against the contribution guidelines without being asked to, I don't know why I would want to contribute to Shields.
I can just create a shield with a static logo, which is what I already did. I wanted to contribute this upstream so other users could use it; but it is not my job to do that, and so raising the cost of such a contribution, with extensive discussion about whether Bazel meets your standard, immediately caused me to re-evaluate and come to the conclusion that this was no longer worth pursuing. I don't know what your standard is and I have other things to do.
I'm an open-source maintainer myself, so I offer this clarification in the hope that it illuminates how a consumer of your project felt during this process. I have been using Shields for years and never stopped to contribute.

I actually agree an update to these docs could be helpful, as I think that subsequent to the last time they were updated we'd taken a stronger position against taking on the maintenance support of new logos and have been contemplating dropping all our native/non-SI logos altogether

Understandable, and I suppose that could be why this PR got the reaction it did even though it made every attempt to follow the written guidelines for contributing logos.

This seems like it would be a reasonable badge addition, though also seems orthogonal to the custom logo. Would suggest opening a separate issue for this using our issue template if that's a badge that you think would be valuable to the community of users in the Bazel ecosystem

Look, I was just saying that, should a Bazel logo exist, it could be used easily to create a new BCR badge. I intentionally left that work to a future PR so I could ask for maintainer advice first.
If you think filing an issue to that effect would be a good idea, go ahead and do so. I'm not the world's biggest Bazel user and I don't work for Google. I was just trying to get a quick logo in which meets the guidelines and that other projects might want to use; as linked in my PR, our logos are already working fine thanks to the custom logos feature. Following this discussion, and knowing that a JSON endpoint for BCR would be substantially more complex than a SVG logo, I think I will have to pass but will wait with patience if somebody else would like to take it on.
If at any time you feel like this is a contribution you would like to merge, feel free to tag me and I will happily re-open the PR. It seems like you are hinting at that but I don't really want to try and parse what you are saying. You can also just grab my branch and file it yourself too if you would rather not interact with me.
I hope this clarifies, have a great day-

Alrighty then. I am genuinely sorry that this hasn't been a pleasant experience for you, but I feel this is has rapidly become much ado about nothing, and you're being unnecessarily flippant in your commentary so I'm not sure it's worth pursuing this PR as the vector for potentially adding a new logo
FWIW:

there's nothing in the PR description that obviously conveyed "I read the docs, I see you prefer to start with SimpleIcons but I don't want to go the SI route, and here's why". Regardless of whether you think your mental context carried through in the description, it didn't land with your target audience and a simple follow up/clarification would've sufficed
you were the one that closed the PR, not the maintainers, and no maintainer has yet said "no" to the logo proposed here
I'm personally hesitant to take on any more custom logos, but I do think there might be sufficiently compelling reasons to do so in this case provided there's an interest amongst our user base.

I'd be open to shifting such consideration (both for this specific logo and more generally) to a separate issue/discussion and/or a future team meeting

Could you please contribute the logo upstream?

@calebcartwright how is this not a no?

I closed the PR after leaving a respectful comment. Then, you replied and asked for clarification. I clarified. I really don't see what is "flippant" about my commentary. I don't know why you would ask for my commentary if you don't want it.

I feel this [has] rapidly become much ado about nothing

It's not nothing to the millions of Bazel users who would like to use Shields, or to me, as I went to the trouble of filing a PR to contribute it. Then again, it's a logo badge. It really doesn't demand an intense level of discussion. You are either open to merging my change or you are not. At this time, my best understanding is that you are not, so I closed the PR. If you are, you can always tag me.

This came to a natural conclusion some time back, so I'm going to lock this as part of issuing a final set of responses.
To any future readers interested in the logo, at this point more discussion is needed but the door is still potentially open. Probably worth waiting to see if SI decide to incorporate it in some shape or form because if they don't it's then more a consideration for us around the project tradeoffs of a native logo vs. the consumer tradeoffs of the custom logo in the url.

Could you please contribute the logo upstream?

@calebcartwright how is this not a no?

Because it doesn't say "no". If we were giving you a firm "no", we would've said so and closed the PR ourselves.
Again, in the context of P-Y's comment, it was not yet clear you'd already considered the SI route. This was a "hey let's start here" because that's our process.

I really don't see what is "flippant" about my commentary. I don't know why you would ask for my commentary if you don't want it.

I'd say it's generally in bad taste to do things like informing a project maintainer that they are allowed to comment in the project they maintain and that they can open an issue themselves. Furthermore, phrases that start with the various variants of "respectfully", "with all do respect", "no offense", etc. are typically anything but, especially in digital communication forums between strangers.
Overall I feel there's a marked difference in the tone and choice of words between your comments on this thread and those of the maintainers, but I'm sure we have different perceptions on that front.
I followed up because I got the impression that you'd taken some level of umbrage at P-Y's comment, likely based on an incorrect interpretation of that comment, and that you in turn closed the PR prematurely.
I still feel that way, but we're all busy and I think it'd be futile to keep going back and forth here.


Code coverage option only available in VStudio Enterprise

It should be noted that Code Coverage is only availabe in VStudio Enterprise 2019 and not in the SKU i have, Professional.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4305ee45-a84a-aa05-5b94-4f9d77dadc40
Version Independent ID: 47acca13-0363-7ea3-08e3-4f2039705223
Content: Code coverage testing - Visual Studio (Windows)
Content Source: docs/test/using-code-coverage-to-determine-how-much-code-is-being-tested.md
Product: visual-studio-windows
Technology: vs-ide-test
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

Sorry just noticed this in Requirements... but I feel like it should be in the paragraph as well.

@ericnewton76 -- Eric, thank you for your suggestion.  I've reviewed this article, and the subsequent paragraphs already rely on the Requirements statement.
I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.


chore: Create Rust toolchain file

There is no evidence pointing towards this package requiring the nightly toolchain without running a build and being greeted with errors, this solves that.

Thank you very much @fuwn ! I'll merge this immediately


cdk.out potentially not containing correct files

Describe the bug
I would expect to have a single cdk.out directory in my CDK directories, but in the build tree I can see they're nested:
$ find . -name cdk.out
...
<EMAIL_ADDRESS><EMAIL_ADDRESS>...

Don't know which one is used when, and maybe everything works out correctly, but this sets my spidey senses tingling that something is wrong.

The second cdk.out is not a directory... it’s the name of the legacy manifest file, and we emit it for backwards compatibility with  pre 0.33.0 toolkit


[T2A4][W15-A3]Zachary Lim Wei Ling

Refractor to make code messy

not as messy as I would have liked! accepting this because you have another PR that is messier :-P


DialogsList in reverse mode

Using the dialogs list I saw that dialogs were added at the bottom and reversed. So I looked for the issue and I found that in the setAdapter() method from the DialogsList class you are setting the layoutManager with the "reverseLayout" flag as true. Is that ok?

Same thing here. How I set the dialogs to the top-bottom?

Anyone was able to set Messages to the top-bottom?

Hi there!
In version 0.2.1 we've added overloaded setAdapter method in DialogsList and MessagesList, with which you can set reverse mode to false.
Best regards, Alexander.

Oddly this introduces a bizarre bug in my application where sometimes it would reverse and other times it wouldn't. Setting reverse mode false just solved it all the time.


feat(Twitter): Consolidated Twitter feeds

Opt-in, live stream of consolidation of members' twitters.

So this would be going off a list of twitter handles or a #newhavenio hashtag?

I was thinking the former (more controllable) but it's up in the air,
whatever people think is the best option. This is definitely not MVP IMO.
On Tue, Dec 10, 2019 at 7:42 AM Alex Trost<EMAIL_ADDRESS>wrote:

So this would be going off a list of twitter handles or a #newhavenio
hashtag?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/a-trost/newhavenio/issues/51?email_source=notifications&email_token=ABMPWCRX6MLXSZ3DFHFKLWDQX6FFFA5CNFSM4JVARR22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGPDFKA#issuecomment-564015784,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABMPWCSPBV7CYMW4LTBVD5DQX6FFFANCNFSM4JVARR2Q
.

Agreed.


clean up dead teams test projects

Pull Request Test Coverage Report for Build 84679

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 77.411%

Totals

Change from base Build 84637:
0.2%

Covered Lines:
5658

Relevant Lines:
7309

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3


Windows 10 Dark Theme Alignment Issue

After the 4.1.0 release the Dark theme has resulted in the Database Navigator having alignment issues.  I have both  a Windows 7 and 10 computer, and I only see this on my Windows 10 machine.
Obviously this is a very minor issue, I just thought I'd call it out if no one else did.

I can't reproduce that.
Please try to reset workspace  (https://github.com/serge-rider/dbeaver/wiki/Reset-workspace) - maybe it is a glitch after upgrade.


Okina fallback kernels [okina-fallback-kernels]

This is a proposal for a simple solution to support fallback (run-time sized) kernels, up for discussion.
I didn't run any performance tests but I suspect the newly added const int D1D = T_D1D ? ... will actually be treated as compile-time constants, because the code happily compiles with the temporary buffers double gradXY[Q1D][Q1D][4];, if instantiated with nonzero T_Q1D and T_D1D.
The buffers fail to compile if Q1D and D1D are run-time sized, of course, which is why I added MAX_Q1D and MAX_D1D, then it works (albeit with larger buffers than necessary).

That looks pretty neat! Thank you @jakubcerveny !


Files missing in folder ‘opencood/data_utils’

Hi,
Thanks for your amazing work!
I  encountered a problem when I was trying to use the codebase and I have double-checked the codebase to ensure that this is indeed the case.
Some files were lost in the folder "opencood/data_utils", I not sure if these files are essential to the codebase.
eg.
/opencood/data_utils/post_processor/bev_postprocessor
/opencood/data_utils/post_processor/ciassd_postprocessor
/opencood/data_utils/post_processor/fpvrcnn_postprocessor
/opencood.data_utils/pre_processor/bev_preprocessor
and a Class BaseDatasetv2 lost in /opencood/datasets/basedataset.py
This problem will raise a import error in init.py and a inherit error in inter_mediate_dataset.py
Hope for your reply!

Thanks for your attention and feedback, I have fixed the import error bug. At the same time, my code will not use other post-processors and pre-processors. Therefore, I removed them from "opencood/data_utils"

Hi, Tianyou
Thanks for your quick reply.
After I change the inheritance of the Class IntermediateFusionDataset to basedataset.BaseDataset.
A new error occurred:

The dict ''selected_cav_base" don't have correct and enough content.

Sorry, this error was because I used the wrong IntermediateFusionDataset, I have updated it now

It worked! Thanks for your help.


angular-gettext seems not to be working in templates

I am trying to use angular-gettext for my project and I stumbled upon the following issue:  the "translate" attribute seems to be ignored within html templates that are loaded by ui-router, for example:
$stateProvider.state("demo", {
templateUrl: "../app/demo/templates/form.html",
controller: "DemoController"
});
so if I have connected gettext and put translation in place, the tags in form.html are not translated (for example "Contact details"), whereas the same tag being placed into the main HTML file (the one containing ), the translation works perfectly!
So my question, is angular-gettext ever supposed to work with ui-router and templates?

Sorry, it appears that the default language was overriden in the controlled. My bad.


Updated istio version

*Issue: hardcoded version in the bash script now fails due to new releases
*Description of changes: The current version that's grabbed is 1.0.4, so I've quickly updated the command to make it easier in the interim.

Thanks for the PR! we actually just fixed this with a wildcard in a different PR...


fix: warn user when using unencrypted non-local urls

Adds a log warning whenever unencrypted non-local urls are used in flags. Since it uses url.Parse, it should also give an error if unable to parse the url.
Closes : #178

@adamewozniak let's backport this :)

Also, we're missing a changelog entry for this. I'm doing a poor job catching this in PRs, but we need to make sure we keep a tidy and useful changelog.

@Mergifyio backport release/v0.2.x


feat: Package as derivative-calculator library

:wave: @nikosarcevic Here's a drive-by PR that packages things up. My feelings won't be hurt at all if you didn't have any interest in this and aren't interested at the moment! :)

Package up as derivative-calculator library using hatch and dynamically version with hatch-vcs.

Expose derivative_calculator.DerivativeCalculator API on import of derivative_calculator.

import derivative_calculator
derivative_calculator.DerivativeCalculator  # <class 'derivative_calculator.derivative_calculator.DerivativeCalculator'>

Add GitHub's standard Python project .gitignore.
Add barebones GitHub Actions based CI that at the moment just verifies that the package can be installed.
Update README to reflect that the tool can be installed with pip.

👋 @nikosarcevic Here's a drive-by PR that packages things up. My feelings won't be hurt at all if you didn't have any interest in this and aren't interested at the moment! :)

Package up as derivative-calculator library using hatch and dynamically version with hatch-vcs.

Expose derivative_calculator.DerivativeCalculator API on import of derivative_calculator.

import derivative_calculator
derivative_calculator.DerivativeCalculator  # <class 'derivative_calculator.derivative_calculator.DerivativeCalculator'>

Add GitHub's standard Python project .gitignore.
Add barebones GitHub Actions based CI that at the moment just verifies that the package can be installed.
Update README to reflect that the tool can be installed with pip.

oh this is grand.
I was thinking if it would be necessary to first see if it can be:

optimized
made more general. so far is very simplistic and some people might have to modify the code in order to deal with different data structures. for example my derivatives for one parameter will be a matrix as my data vector is an angular power spectrum Cl. so my data vector is Cls X ells.
add some unit tests?

anything else?

what do you think @matthewfeickert

I was thinking if it would be necessary to first see if it can be:

optimized
made more general. so far is very simplistic and some people might have to modify the code in order to deal with different data structures. for example my derivatives for one parameter will be a matrix as my data vector is an angular power spectrum Cl. so my data vector is Cls X ells.
add some unit tests?

All of this is easier to do IMO if you start with a package and then move forward. You, and anyone else, can hack at it all you want but still keep the package format by installing in editable mode
python -m pip install -e .

where changes to the source files under src/ will be reflected (due to pip doing fancy symlinking behind the scenes).
Testing should be added, but testing with pytest as a package is way easier to make sure you're doing what you think you're doing then a collection of scritps.

I was thinking if it would be necessary to first see if it can be:

optimized
made more general. so far is very simplistic and some people might have to modify the code in order to deal with different data structures. for example my derivatives for one parameter will be a matrix as my data vector is an angular power spectrum Cl. so my data vector is Cls X ells.
add some unit tests?

All of this is easier to do IMO if you start with a package and then move forward. You, and anyone else, can hack at it all you want but still keep the package format by installing in editable mode
python -m pip install -e .

where changes to the source files under src/ will be reflected as you make them (due to pip doing fancy symlinking behind the scenes).
Testing should be added, but testing with pytest as a package is way easier to make sure you're doing what you think you're doing then a collection of scritps.

ok so -- I never did this before! do you have some time to chat? like quick zoom? also I would call the package differently as it is not my method but it is my implementation. lmk if u are free for like 20 min

also I would call the package differently as it is not my method but it is my implementation. lmk if u are free for like 20 min

Probably not this week as I'm traveling at the moment and have nearly dawn to dusk meetings on Friday. :grimacing: Whatever naming you'd like is totally fine. :+1: Just suggest it in a PR reveiew comment.

also I would call the package differently as it is not my method but it is my implementation. lmk if u are free for like 20 min

Probably not this week as I'm traveling at the moment and have nearly dawn to dusk meetings on Friday. 😬 Whatever naming you'd like is totally fine. 👍 Just suggest it in a PR reveiew comment.

grand. no worries, we can do this on gh. I will be reviewing it over the next few days as I need to do something else urgently. thanks so much for this, it is great!!

@matthewfeickert do you maybe have a nice reference for writing python packages (basically something that goes over most of what you did in this PR)? I've never tried to make a package pip installable, and although there is a lot of information out there I find it a bit difficult to get a comprehensive overview.


Added Transfer_encoding methods

Hello there ,
In this PR I have added code for transfer-encoding method to work.
It work's with    -te for arguments .
python3 hexhttp.py -u https://evil.com -te chunked
python3 hexhttp.py -u https://evil.com -te gzip
python3 hexhttp.py -u https://evil.com -te compress

Output look's like this:

I am looking help to adjust code such that python3 hexhttp.py -u https://evil.com -te   when -te  is used it should check for all method's i.e. chunked , gzip,compress, deflate

Hello,
Thank you for your interest in this tool !
I think you put this in relation to my TODO and I admit that it was not clear ahah it was just the transfer-encoding in CPDoS and I have already added I will update the TODO :)

do update TODO


Have the iOS hasvalidCredentials() match the behavior of the Android one

Description
The manual testing of the Credentials Manager implementations unveiled that there is a difference in behavior in the hasValidCredentials() method of the Auth0.swift Credentials Manager and the Auth0.Android one.
The Auth0.swift one will not take into account the presence of the refresh token, as having a refresh token does not mean that there are valid credentials stored. The Auth0.Android one does.
This PR modifies CredentialsManagerHasValidMethodHandler to have it behave like the Android hasValidCredentials(), to provide a consistent behavior in both platforms.
Testing
Besides adding a unit test, the implementation was tested manually using an iPhone 13 simulator running iOS 15.5 with Xcode 13.4.1 (13F100).

[ ] This change adds test coverage for new/changed/fixed functionality

Checklist

[ ] I have added documentation for new/changed functionality in this PR or in auth0.com/docs
[ ] All active GitHub checks for tests, formatting, and security are passing
[ ] The correct base branch is being used, if not master

Codecov Report

Merging #125 (5464cbf) into first-availability (b5fe40a) will not change coverage.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##             first-availability     #125   +/-   ##
=====================================================
  Coverage                 93.17%   93.17%
  Complexity                   69       69
=====================================================
  Files                        51       51
  Lines                       791      791
  Branches                     43       43
=====================================================
  Hits                        737      737
  Misses                       47       47
  Partials                      7        7

Flag
Coverage Δ

auth0_flutter
98.27% <ø> (ø)

auth0_flutter_android
90.49% <ø> (ø)

auth0_flutter_platform_interface
96.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5fe40a...5464cbf. Read the comment docs.


Building from a project (for iOS) doesn't appear to use compiler directives from child projects

We are building using AppCenter an iOS project (.csproj) and it uses other projects as references. We select the correct build "Configuration" but it's not obeying the compiler directives in child projects.
We had recently been building using a solution (.sln) file instead (this did obey directives) but this has recently (three days ago) stopped working with no changes from us, so we're now trying to build from a project instead.

@mondagoar Could you provide more details on what stopped working for building with solution? We may need you to reach out to support to take a deeper look at your build

Thanks for the reply. I reported the problem with the "solution" separately, but you closed it. See here: https://github.com/microsoft/appcenter/issues/576
I raised this issue because we're having problems building from a project now (which we're using instead). We have one master project (Xamarin / iOS) and it references another library project. The library project has compilation directives but the build doesn't seem to recognize them, despite us using the correct "Configuration".

I closed the issue in error.

Ah got it. Thanks for the clarification. Please follow up with support as I suggested regarding the "solution" problem. As for the issue with building the "project", could you mention it in the same support ticket? I'd like to have better idea about specifics. Or feel free to describe here if that works for you.

Please could you guide me a little more about what specifics you need. I don't really know what information is relevant (and don't really want to inadvertently post private data).

Let's go through Support in this case then. If we find something that will be helpful to others, we can post an update here to share the findings.

Ok. Thanks. Should I give you access to our build? Or how else can I help provide information?

Once you reach out to Support (from the portal), in the conversation, you can provide the link to the failed build, and probably the link to the last successful build for comparison

Moved to CSS


[Compute] az vm/vmss create: --enable-vtpm is set to True by default when the --security-type used by the VM/VMSS creation is TrustedLaunch

Related command

az vm cerate
az vmss create
Description

Enabling vTPM by default https://github.com/Azure/azure-cli/issues/23144#issuecomment-1196923552
Testing Guide

History Notes

[Compute] az vm/vmss create: --enable-vtpm is set to True by default when the --security-type used by the VM/VMSS creation is TrustedLaunch

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Compute


[Feature] API Tokens

first of all thanks for this awesome work!
I am really like this extension, I have started using it about year ago and it's really helpful.
I suggest if you can make a something like build server that other developers can use to build and test the extension on it without having to get the API token keys required from font awesome token, Dark Sky, Unsplash, and Google Maps.
I think this will also help people make their own customized version of the extension, I have many edits I need to do to the extension that will make my life easier.
Or if there is away to get these tokens for free (especially font awesome token) please let me know.
Thanks!

@MustafaAmer-1
Thanks for the suggestions.
It has always bothered me that the "free" font-awesome still needs an API key to use their packages. I think I can replace those with a different icon solution and will try to make some time to do that soon. This would remove the need for a font-awesome API key.
Regarding the others....
Dark Sky will be shutting down at the end of this year and that will service need to be replaced. Not sure if I will replace it or just remove the weather as there are very few solutions that offer the same amount of data and such a generous free tier. Feel free to offer any suggestions but if I do use another weather service, I would anticipate still needing API keys for myself and any other devs else using it. Again, open to suggestions and/or pull requests using other weather services(s).
Unsplash and Google Maps could each ban me if I proxied their APIs to others (even just for dev purposes). However, they each offer API keys for free so the only real headache there is the time to sign up for and create your own.
I'll leave this open until I remove font-awesome.

On the off chance this is still of interest to you...
I made some significant changes (that break the currently published extension until Google approves my updated submission) but that mostly address the previous issues:

there is no longer a need for a FontAwesome API key
Dark Sky has been converted to OpenWeatherMap (which have free API keys that support 1 million requests per day, links to sign up in README)
there is still also a need for Unsplash API key and secret but those also remain free (and now have sign up links in README)

Unrelated to your asks about API keys, the build system has been refactored from Webpack to Vite and the hosting has been moved from Vercel to CloudFlare Pages (using Wrangler CLI along with Vite for local dev).
As previously mentioned, there's no viable way for me to provide any proxied API keys without putting my accounts at risk of breaking Terms of Services and losing access.
I think streamlining things to only need the above keys, and using providers that let you sign up for free (and without asking for any payment info), should eliminate most barriers to development.


Bug: Missing LoadBalancer SSH key in the Claudie Secret

Current Behaviour

Using the command below you will get the information about dynamic/static nodepools and one SSH key (cluster_private_key). I don't know if one should be able to use this SSH key to connect to the LoadBalancer created by Claudie, but it doesn't work. Eventually, we needed to obtain a different SSH private key directly from MongoDB to be able to connect to the LB.
kubectl get secrets -n claudie -l claudie.io/output=metadata -ojsonpath='{.items[0].data.metadata}' | base64 -d | jq

Expected Behaviour

LoadBalancer SSH key should be included in the Claudie metadata secret or one should be able to use the cluster_private_key to connect to the LoadBalancer through SSH.
Steps To Reproduce

Create K8s cluster with LoadBalancer
Get cluster_private_key from the Claudie metadata secret
Try to SSH into LB using cluster_private_key

Anything else to note

Where can one get the public IP address of the LoadBalancer? The Claudie metadata secret contains only public IPs for dynamic and static nodepools.

The Control plane and Worker plane nodes use the same SSH keys. Any reason why not using the same SSH key-pair for LBs as well?

No, LB can use the same SSH key-pair, but it isn't currently.

If you agree, instead of adding current LB key into the secret, I'd recommend using the same key, which is already present in the secret and used for control plane and compute plane connections.

I definitely agree 👍


after upgrade to  ^3.0.0-rc.32", i got compilation error using CallAnApi.using(axiosInstance),

test:consent:stage] TSError: ⨯ Unable to compile TypeScript:
[test:consent:stage] src/Actors.ts(18,29): error TS2345: Argument of type 'import("/Users/xxxxx/dev/sh-common-services-serenityjs/node_modules/axios/index").AxiosInstance' is not assignable to parameter of type 'import("/Users/xxxxxxx/dev/sh-common-services-serenityjs/node_modules/@serenity-js/rest/node_modules/axios/index").AxiosInstance'.
[test:consent:stage]   The types of 'defaults.headers.common' are incompatible between these types.
[test:consent:stage]     Type 'Partial<RawAxiosHeaders & MethodsHeaders & CommonHeaders>' is not assignable to type 'AxiosRequestHeaders'.
[test:consent:stage]       'string' index signatures are incompatible.
[test:consent:stage]         Type 'AxiosHeaderValue' is not assignable to type 'string | number | boolean'.
[test:consent:stage]           Type 'AxiosHeaders' is not assignable to type 'string | number | boolean'.
[tes
Actors.ts:
    baseURL: process.env.WEATHER_SERVICE_BASE_URL,
    timeout: 5000,
    headers: { Accept: 'application/json' },
});
export class Actors implements Cast {
    constructor(private readonly baseApiUrl: string) {
        ensure('apiUrl', baseApiUrl, isNotBlank());
    }

    prepare(actor: Actor): Actor {
        return actor.whoCan(
            CallAnApi.using(axiosInstance),
            TakeNotes.usingAnEmptyNotepad(),
        );
    }
}

package.json
  "@cucumber/cucumber": "^8.3.1",
    "@serenity-js/assertions": "^3.0.0-rc.32",
    "@serenity-js/console-reporter": "^3.0.0-rc.32",
    "@serenity-js/core": "^3.0.0-rc.32",
    "@serenity-js/cucumber": "^3.0.0-rc.32",
    "@serenity-js/rest": "^3.0.0-rc.32",
    "@serenity-js/serenity-bdd": "^3.0.0-rc.32",
    "@types/node": "^18.0.0",
    "@typescript-eslint/eslint-plugin": "^5.29.0",
    "@typescript-eslint/parser": "^5.29.0",
    "axios": "^1.1.3",
    "axios-debug-log": "^0.8.4",
    "axios-mock-adapter": "^1.20.0",

Hi @LayMui , looks like you use axios version 1.1.3, could you try to downgrade to the version serenity-js/rest is using (^0.27.2).
https://github.com/serenity-js/serenity-js/blob/3480ba44d83ff663a6a7c3e51ab1f977776cc9d0/packages/rest/package.json#L49
@jan-molak , we already had this issue, see #1223 , looks as it‘s back in axios 1.x

yes. I fixed the axios version to 0.27.2
however when I upgrade the serenityjs version from  "^3.0.0-rc.19", to "^3.0.0-rc.32",
I got the following error
[test:weather:stage] TSError: ⨯ Unable to compile TypeScript:
[test:weather:stage] src/task/consent/VerifyBundleDetails.ts(154,81): error TS2445: Property 'description' is protected and only accessible within class 'Activity' and its subclasses.

here is the code snippet:
Ensure.that(
                LastResponse.body<Bundle<BundleData>>().data.confirmationDialog.description.answeredBy(actor), matches(/\w+/)
            ),

BundleData.ts
import Document from "./Document";

interface BundleData {
    id: string,
    title: string,
    subtitle: string,
    acceptLabel:string,
    declineLabel: string,
    confirmationDialog: {
        title: string,
        description: string,
        confirmLabel: string,
        cancelLabel: string
    },
    description: string,
    product: string,
    type: string,
    lang: string,
    country: string[],
    documents: Document
}

export default BundleData;

Well, looks like at least the axios error has gone, right?
Now you've got a new error: Is this error related to the upgrade to the latest Serenity/JS version? Has this code worked with version 3.0.0-rc.19 which you've used before?
I assume the snippet you've pasted is line 154 from src/task/consent/VerifyBundleDetails.ts: I think, you do not need the answeredBy(actor) part when using Ensure in combination with LastResponse.
Something like
Ensure.that(
  LastResponse.body<Bundle<BundleData>>().data.confirmationDialog.description, matches(/\w+/)
 )

should do the trick. See this example: https://github.com/serenity-js/serenity-js/blob/3480ba44d83ff663a6a7c3e51ab1f977776cc9d0/packages/rest/spec/screenplay/questions/LastResponse.spec.ts#L93
In case this does not help: You expect a response of type <Bundle<<BundleData>>. You provided just the BundleData interface, can you please provide the Bundle interface as well?

Bundle.ts
import BundleData from "./BundleData";

interface Bundle<T>{
    status: string,
    errors:  {
        msg: string[],
        errorCode: number
    },
    data: T,
}

export default Bundle;

yes the axios issue is resolved.
this is another issue due to the upgrade from ^3.0.0-rc.19 to ^3.0.0-rc.32

Did you try to remove the answeredBy(actor), as well?
I wonder if you would do a downgrade to 3.0.0-rc.19 , if your test is working again?

Okay, think I found something. You try to access the property called description. But this get’s resolved to https://github.com/serenity-js/serenity-js/blob/3480ba44d83ff663a6a7c3e51ab1f977776cc9d0/packages/core/src/screenplay/Activity.ts#L23
Have to have a deeper look.

I see.
I found that is another outer field called description
interface BundleData {
id: string,
title: string,
subtitle: string,
acceptLabel:string,
declineLabel: string,
confirmationDialog: {
title: string,
//description: string,
confirmLabel: string,
cancelLabel: string
},
description: string, <------
product: string,
type: string,
lang: string,
country: string[],
documents: Document
}
export default BundleData;
anyway, I get rid of the compilation error by not checking that field that I commented out.
i guess i can leave the .answeredBy(actor) there, right? it does not make any difference without it
 Ensure.that(
                LastResponse.body<Bundle<BundleData>>().data[0].id.answeredBy(actor), matches(/\w+/)
            ),

i got another same issue with another that use the field called description

| TypeError: rest_1.LastResponse.body(...).data.forecast[0].description.answeredBy is not a function

how can I overcome this ?

  | TypeError: rest_1.LastResponse.body(...).data.forecast[0].description.answeredBy is not a function
-- | --

Can you post the code snippet that produces this error and the interface containing the  forecast array your're accessing here.
It's hard to tell what could be the issue, without seeing the code.
Here are some possible reasons for this error.

@LayMui : I copied and pasted your answer in issue #1344 to this issue #1342 as it was requested here. The other issue is a very special situation that I was able to reproduce and like to follow up with Jan Molak separately. I'll delete the comments in the other issue.
I'll follow up your ongoing issues here:

Copy from other issue
interface Forecast<T> {
    status: string,
    errors:  {
        msg: string[],
        errorCode: number
    },
    data: {
        geocode: string
        days: number,
        language: string,
        units: string,
        response: string,
        forecast: T
    }
}

export default Forecast;

interface HourlyForecast {
    cloudCover: number,
    temperature: number,
    qpf: number,
    relativeHumidity: number,
    iconCode: number,
    windDirection: number,
    windSpeed: number,
    qualifierSet: string,
    description: string,
    validTimeUtc: number,
    validTimeLocal: Date,
    expirationTimeUtc: number,
    precipType: string,
    precipChance: number
}

export default HourlyForecast;

the error comes from this line

  Ensure.that(
                LastResponse.body<Forecast<HourlyForecast>>().data.forecast[0].description.answeredBy(actor), matches(/(.*)/)
            ),

Okay, I drilled it down a bit, and you're right, it's the same issue, just a bit covered. I was confused as you access forecast[0] as an array and I'm not sure, if it is one.
But if I we'd access it like this:
Ensure.that(
                    LastResponse.body<Forecast<HourlyForecast>>().data.forecast.location.answeredBy(actor), matches(/(.*)/)
                ),

than we're back at the initial error message: error TS2341: Property 'location' is private and only accessible within class 'Activity'.
I can confirm as well, that is was running in 3.0.0-rc.19. This regression was introduced most likely with this change
So summing up a bit:

Initially you raised this issue because there is trouble with the latest axios version
This was solved by using the axios version supported by Serenity/JS (0.27.2)
Then you ran into a migration error when using LastResponse
This is caused by a regression in Serenity/JS between version 3.0.0-rc.19 and 3.0.0-rc.32

Do you agree to use this issue to follow up the issue with the lates axios version and to use #1344 to follow up the issue with LastResponse as this are two separate issues from my perspective?

yes @viper3400 , i agree this is a separate issue. so I will close this as resolved after change the axios version


Remove the requirement to submit trace.json

Generating the trace can bottleneck loadgen, The log can be gigabytes - or when compressed, hundreds of megabytes - for a single benchmark/scenario combination.
We suggest it be removed from the required results data for inference submissions.

WG approved.


Is it possible to use which-key with nvim-cmp mappings

I am quite new to neovim and wonder how I would setup nvim-cmp mappings with which-key.
Maybe its out of scope for your plugin I don't know or I am just lost :)
nvim-cmp setup
local cmp = require('cmp')
cmp.setup({
   ...
  mapping = {
    ['<Tab>'] = cmp.mapping(cmp.mapping.select_next_item(), {'i', 'c'}),
    ['<S-Tab>'] = cmp.mapping(cmp.mapping.select_prev_item(), {'i', 'c'}),
    ['<C-b>'] = cmp.mapping(cmp.mapping.scroll_docs(-4), {'i', 'c'}),
    ['<C-f>'] = cmp.mapping(cmp.mapping.scroll_docs(4), {'i', 'c'}),
  }
})

My starting thought's how I wish to register it with which-key
but I don't know how I should use it with the mapping table because they should only be valid when nvim-cmp is in use.
local wk = require('which-key')
local cmpKeys = {
           ['<TAB>'] = {  cmp.mapping(cmp.mapping.select_next_item(), 'Next Item (Cmp)' },
           ['<S-TAB>'] = {  cmp.mapping(cmp.mapping.select_prev_item(), 'Prev Item (Cmp)' },
           ['<C-b>'] = {  cmp.mapping(cmp.mapping.scroll_docs(-4), 'Scroll Up (Cmp)' },
           ['<C-f>'] = {  cmp.mapping(cmp.mapping.scroll_docs(4), 'Scroll Down (Cmp)' },
      }
wk.register(cmpKeys },  {mode='i'})
wk.register(cmpKeys },  {mode='c'})

I am quite new to neovim and wonder how I would setup nvim-cmp mappings with which-key. Maybe its out of scope for your plugin I don't know or I am just lost :)
nvim-cmp setup
local cmp = require('cmp')
cmp.setup({
   ...
  mapping = {
    ['<Tab>'] = cmp.mapping(cmp.mapping.select_next_item(), {'i', 'c'}),
    ['<S-Tab>'] = cmp.mapping(cmp.mapping.select_prev_item(), {'i', 'c'}),
    ['<C-b>'] = cmp.mapping(cmp.mapping.scroll_docs(-4), {'i', 'c'}),
    ['<C-f>'] = cmp.mapping(cmp.mapping.scroll_docs(4), {'i', 'c'}),
  }
})

My starting thought's how I wish to register it with which-key but I don't know how I should use it with the mapping table because they should only be valid when nvim-cmp is in use.
local wk = require('which-key')
local cmpKeys = {
           ['<TAB>'] = {  cmp.mapping(cmp.mapping.select_next_item(), 'Next Item (Cmp)' },
           ['<S-TAB>'] = {  cmp.mapping(cmp.mapping.select_prev_item(), 'Prev Item (Cmp)' },
           ['<C-b>'] = {  cmp.mapping(cmp.mapping.scroll_docs(-4), 'Scroll Up (Cmp)' },
           ['<C-f>'] = {  cmp.mapping(cmp.mapping.scroll_docs(4), 'Scroll Down (Cmp)' },
      }
wk.register(cmpKeys },  {mode='i'})
wk.register(cmpKeys },  {mode='c'})

i think it is. i never tried it but try:
local cmpKeys = {
           ['<TAB>'] = {  ":lua require('nvim-cmp').mapping(cmp.mapping.select_next_item()<CR>", 'Next Item (Cmp)' },
 ...

I am quite new to neovim and wonder how I would setup nvim-cmp mappings with which-key. Maybe its out of scope for your plugin I don't know or I am just lost :)
nvim-cmp setup
local cmp = require('cmp')
cmp.setup({
   ...
  mapping = {
    ['<Tab>'] = cmp.mapping(cmp.mapping.select_next_item(), {'i', 'c'}),
    ['<S-Tab>'] = cmp.mapping(cmp.mapping.select_prev_item(), {'i', 'c'}),
    ['<C-b>'] = cmp.mapping(cmp.mapping.scroll_docs(-4), {'i', 'c'}),
    ['<C-f>'] = cmp.mapping(cmp.mapping.scroll_docs(4), {'i', 'c'}),
  }
})

My starting thought's how I wish to register it with which-key but I don't know how I should use it with the mapping table because they should only be valid when nvim-cmp is in use.
local wk = require('which-key')
local cmpKeys = {
           ['<TAB>'] = {  cmp.mapping(cmp.mapping.select_next_item(), 'Next Item (Cmp)' },
           ['<S-TAB>'] = {  cmp.mapping(cmp.mapping.select_prev_item(), 'Prev Item (Cmp)' },
           ['<C-b>'] = {  cmp.mapping(cmp.mapping.scroll_docs(-4), 'Scroll Up (Cmp)' },
           ['<C-f>'] = {  cmp.mapping(cmp.mapping.scroll_docs(4), 'Scroll Down (Cmp)' },
      }
wk.register(cmpKeys },  {mode='i'})
wk.register(cmpKeys },  {mode='c'})

i think it is. i never tried it but try:
local cmpKeys = {
           ['<TAB>'] = {  ":lua require('nvim-cmp').mapping(cmp.mapping.select_next_item()<CR>", 'Next Item (Cmp)' },
 ...

then just add <TAB> to the triggers list
EDIT: nvm im not sure if that works zzzz

To me it looks the same but you are thinking of putting it into a vimscript :lua is to execute from a vimscript if I am not totally wrong.
I already have placed my config in a LUA file that executes so that would not do a difference.


#@overlay/insert inserts out of order

What steps did you take:
Ran the following files through ytt:
template.yaml
non-empty: doc
---
array:
- seeded

overlay.yaml
#@ load("@ytt:overlay", "overlay")
#@overlay/match by=overlay.all, expects="1+"
---
#@overlay/match missing_ok=True
array:
#@overlay/append
- appended
#@overlay/match by=overlay.index(0)
#@overlay/insert before=True
- inserted before 0

What happened:
The command executed successfully, and output this yaml:
non-empty: doc
array:
- appended
- inserted before 0
---
array:
- inserted before 0
- seeded
- appended

Note the order of the items in the array.  The "inserted before 0" item is added after the "appended" item in the first document, but (properly) before in the second.
Anything else you would like to add:
This doesn't occur if we insert an array key to the first doc
non-empty: doc
array: []

which gets properly templated as:
non-empty: doc
array:
- inserted before 0
- appended

Environment:

ytt version (use ytt --version): This occurs on the playground at 0.30.0 as well as local dev at 0.31.0
OS (e.g. from /etc/os-release): MacOS

I was able to reproduce the issue with
$ cat tmp/template.yml
non-empty: doc
---
array:
  - seeded
---
other: doc
array: []

$ cat tmp/overlay.yml
#@ load("@ytt:overlay", "overlay")
#@overlay/match by=overlay.all, expects="1+"
---
#@overlay/match missing_ok=True
array:
  #@overlay/append
  - appended
  #@overlay/match by=overlay.index(0)
  #@overlay/insert before=True
  - inserted before 0

$ ytt -f tmp/template.yml -f tmp/overlay.yml
non-empty: doc
array:
- appended
- inserted before 0
---
array:
- inserted before 0
- seeded
- appended
---
other: doc
array:
- inserted before 0
- appended

Also inverted the order that we do the overlay and looks like the ordering of the operations is correct.
$ cat tmp/overlay.yml
#@ load("@ytt:overlay", "overlay")
#@overlay/match by=overlay.all, expects="1+"
---
#@overlay/match missing_ok=True
array:
  #@overlay/match by=overlay.index(0), expects="0+"
  #@overlay/insert before=True
  - inserted before 0
  #@overlay/append
  - appended

$ ytt -f tmp/template.yml -f tmp/overlay.yml
non-empty: doc
array:
- inserted before 0
- appended
---
array:
- inserted before 0
- seeded
- appended
---
other: doc
array:
- appended

Not sure if this will be relevant but I also tried to add an expectation in the match overlay of 1+ and it didn't fail in any case:
$ cat tmp/overlay.yml
#@ load("@ytt:overlay", "overlay")
#@overlay/match by=overlay.all, expects="1+"
---
#@overlay/match missing_ok=True
array:
  #@overlay/append
  - appended
  #@overlay/match by=overlay.index(0), expects="1+"
  #@overlay/insert before=True
  - inserted before 0

$ ytt -f tmp/template.yml -f tmp/overlay.yml
non-empty: doc
array:
- appended
- inserted before 0
---
array:
- inserted before 0
- seeded
- appended
---
other: doc
array:
- inserted before 0
- appended

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this bug fixed as soon as possible"
👎 "There are more important bugs to focus on right now"
We are also happy to receive and review Pull Requests if you want to help fix this issue.

this is related to task in https://github.com/vmware-tanzu/carvel-ytt/issues/112

traverse value for merge/replace/append/insert (since they may include overlay directives) when short circuiting

this ~related~ is task in #112

Which has been broken out into it's own issue: #371


INI version used (1.3.0) has a vulnerability

INI dependency needs to be upgraded. CircleCI does not like this version of INI because it has a vulnerability.
https://www.npmjs.com/advisories/1589
INI needs to be 1.3.6 or later -

1.3.7 will be pulled in by default, and there is no lockfile.  What is CircleCI complaining about?


HIVE-25610: Handle partition field comments for Iceberg tables ADDENDUM

What changes were proposed in this pull request?
Add the following constants to serde/if/serde.thrift
const string LIST_COLUMN_COMMENTS = "columns.comments";
const string LIST_PARTITION_COLUMN_COMMENTS = "partition.columns.comments";

Why are the changes needed?
Constants are introduced in #2715 but not added to serde.thrift.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
mvn clean install -Pthriftif -DskipTests -Dthrift.home=/usr/local -Drat.skip

Thanks for finding this @kasakrisz!

Thanks for review @pvary !


Fix "generate random whole numbers with javascript" challenge

Pre-Submission Checklist

[x] Your pull request targets the staging branch of FreeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes https://github.com/FreeCodeCamp/FreeCodeCamp/issues/11110

Description
The regex now accounts for the error encountered by user where Math.random() * 100 was considered a valid entry.
This is my first PR into FreeCodeCamp's repo, so would appreciate any feedback. I've also got a question/suggestion and a comment:
Question/suggestion:
I've looked through the code and couldn't find where this is being tested with a negative expectation. E.g. 100 should not pass. The lack of such tests are the reason this bug occurred, imo, and it would be great to have some safe guards against it.
So, something like this could be possible:
"solutions": [
  "var randomNumberBetween0and19 = Math.floor(Math.random() * 20);\nfunction randomWholeNum() {\n  return Math.floor(Math.random() * 10);\n}"
],
"failingExamples": [
  "var randomNumberBetween0and19 = Math.floor(Math.random() * 20);\nfunction randomWholeNum() {\n  return Math.floor(Math.random() * 100);\n}"
]

If I have not noticed where it is already implemented, my apologies in advance!
Comment
I just wanted to say that the setup instructions that you provided and ease of setup are really awesome. Maybe I was lucky this time, but I literally spent just 15 minutes setting the whole project up locally, and I'm not even a node pro! 👏

Thanks for the PR and I'm glad to hear setup went so smoothly!
I can see where you're coming from on the negative solutions, but doing something like that is problematic since there is a potentially infinite number of wrong answers from any given question, and if there's one thing I've learning in helping many people learn how to code it's that there's no way to anticipate all the creative ways people will solve problems and answer questions!
Congrats and thanks again on your first Free Code Camp contribution!


rbenv: 1.2.0 -> 1.3.0 and migrate to pkgs/by-name and format using nixfmt

Release: https://github.com/rbenv/rbenv/releases/tag/v1.3.0
Diff: https://github.com/rbenv/rbenv/compare/v1.2.0...v1.3.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/2088

suggestion: Maybe remove with lib too.


How to find out what groups "gemspec" creates

Does anybody know how to find out exactly what is the name of the group that "gemspec" in the Gemfile defines? I looked in my Gemfile.lock but don't see anything like ":default" or ":test" or ":development".
You'd think that "bundle list" might have some option to show you which groups your app can require, but no such luck.
Should this be a new feature?

The gemspec command does not create a group. If you need groups, put them in your Gemfile.
On Jan 2, 2012, at 11:41 AM, Larry<EMAIL_ADDRESS>wrote:

Does anybody know how to find out exactly what is the name of the group that "gemspec" in the Gemfile defines? I looked in my Gemfile.lock but don't see anything like ":default" or ":test" or ":development".
You'd think that "bundle list" might have some option to show you which groups your app can require, but no such luck.
Should this be a new feature?

Reply to this email directly or view it on GitHub:
https://github.com/carlhuda/bundler/issues/1607

It should actually create a :development group for the gemspec's development dependencies (see https://github.com/carlhuda/bundler/blob/master/lib/bundler/dsl.rb#L37-41).

Ah, that is true, and the docs for the gemspec method do say that. :)

WRT to the initial question: all gems with no explicit :group option get the :default group -- this includes the gemspec and its runtime dependencies (see https://github.com/carlhuda/bundler/blob/master/lib/bundler/dsl.rb#L203).
I'm only guessing when it comes to why groups aren't included in the lockfile, but I think the groups simply don't matter that much for resolving dependencies (unless you use the CLI's --with/--without options, of course).

It's all in https://github.com/lsiden/accounts

https://github.com/lsiden/accounts/blob/master/accounts.gemspec
https://github.com/lsiden/accounts/blob/master/Gemfile
https://github.com/lsiden/accounts/blob/master/demo/web_app.rb#L6

#add_runtime_dependency doesn't add the gem to any group, as it's a part of Rubygems and Bundler's gem groups are out of its scope

You are right.  My mistake.

The gemspec's development dependencies are handled a little different. The are implicitly added to the bundle when calling #gemspec because the resolver only cares about runtime dependencies and would otherwise ignore development dependencies.

Then Gemfile: gemspec is supposed to throw both the default and dev-only-required gems into the :default group?  That's not what I would have expected.
I found this: http://www.automatthew.com/2008/07/developer-dependencies-in-rubygems-120.html, and this: http://numbers.brighterplanet.com/2010/07/28/bundler-to-the-max/.  Curiously, neither of these posts mention using both Gemfile: gemspec and Bundler.require(...) to just suck all the gem requirements from the .gemspec file and require them all in one line!
Have I just discovered a new use-case?  Doesn't seem likely but you never know.  Anyway, to paraphrase author James Dickey: "If that ain't the way it works, it's the way it oughtta."  :)

Gemfile: gemspec is supposed to throw both the default and dev-only-required gems into the :default group? That's not what I would have expected.

Nope, gemspec ignores the default (== "runtime") dependencies as only the resolver cares about them. The development dependencies will be added to the :development group.
You can change this group by passing the :development_group option to gemspec.

Curiously, neither of these posts mention using both Gemfile: gemspec and Bundler.require(...) to just suck all the gem requirements from the .gemspec file and require them all in one line!

If you want to use Bundler.require, just pass :default for your runtime code and both :default and :development for your Rake/test code. This makes only sense though, if your fine with tying your gem/app closely to Bundler. Most of the time bundle's exec command combined with a simple require "foobar" is the more elegant and simple way.

Thank you Lars.  Could you point me to some examples?

Thanks.  That's helpful.
Why does hatetepe's Gemfile include gems that aren't in the gemspec?  Is that by intent?

I consider development dependencies to be the gems really neccessary for doing development. awesome_print is just my personal choice for simple debugging, so I like it to not be part of hatetepe's "official" development dependencies. yard and rdiscount should actually be defined in the gemspec as they are neccessary for building the API docs, thanks for the hint :)
Rake is in the Gemfile and not in the gemspec because it isn't a real dependency. The specs can be run just with bundle exec rspec spec/ and rake test is just kind of an alias -- I hardly ever invoke it, but it's the standard and people expect it to run the test suite.

I tried to verify #groups' behavior like this:
❤ bundle console
1.9.3-p0 :001 > Gem.loaded_specs["hatetepe"]
 => #<Gem::Specification name=hatetepe version=0.4.0>
1.9.3-p0 :002 > Gem.loaded_specs["hatetepe"].groups
 => []
1.9.3-p0 :003 > Gem.loaded_specs["rspec"].groups
 => []

#groups should IMO really not be empty in both cases. What do you thin, @indirect?


Issue in App Delegate with Compilation

Objective-C method 'application:didFinishLaunchingWithOptions:' provided by method 'application(:didFinishLaunchingWithOptions:)' conflicts with optional requirement method 'application(:didFinishLaunchingWithOptions:)' in protocol 'UIApplicationDelegate'

English: Replace the function 'application' in AppDelegate.swift by the one followed, and the build would succeed.
Chinese: 用下面这一段替换 AppDelegate.swift 中的函数 'application'，编译就会成功。
func application(application: UIApplication, didFinishLaunchingWithOptions launchOptions: [NSObject: AnyObject]?) -> Bool {
// Override point for customization after application launch.
return true
}


Start adding tests to the project

cc @mkouba

@gsmet any idea why the snapshots are not working?
This looks fine for example, but CI doesn't seem to find it...


Add Antrea based traffic redirection in Istio CNI plugin when using Ambient mode

The new Istio Ambient mode redirects L4 traffic to the ztunnel pods on the nodes using

iptables and Geneve tunnels or
eBPF programs and maps

The ztunnel pod handles mTLS connections to ztunnel pods on other nodes. You can also configure simple firewall rules
using Istio AuhorizationPolicies. The traffic redirection is using the Istio CNI plugin  in CNI chaining mode.
The traffic redirection should be possible and more efficient with the Antrea TrafficControl CRD (instead of iptables and Geneve tunnels) but needs further analysis from the Antrea team.
The suggestion is to contribute a new Antrea redirection mode in the Istio CNI plugin or to work with the Istio Ambient team to have a mode which does not need the Istio CNI plugin at all in an Antrea context (which would then not support the (legacy) sidecar based approach which the Istio CNI plugin also handles but only the new Ambient mode).
One should also keep in mind that before the traffic reaches the ztunnel pod it might have to be analyzed by the Suricata engine on the node if this feature is used together with Antrea (pod -> Suricata -> ztunnel -> ...).
The Istio L4 AuthorizationPolicies might also be enhanced using Antrea (Cluster ) Network Policies or the new AdminNetworkPolicies, but this needs further analysis.
Last but not least one has to consider some overlap with the Antrea Multi-Cluster implementation which is using a very similar architecture with the Multi-Cluster Gateway Pods (but without mTLS). This looks more like an upstream discussion about which specification/project handles which layer in the networking stack.

Given that the ztunnel Pod runs as a regular Pod (not hostNetwork), it should be pretty easy for us to redirect mesh traffic to it directly in OVS.
It would be great if we could use TrafficControl for this, with a single CR for all the Pods which are part of the mesh. However, at the moment with TrafficControl, you need to define a destination (target port), which can be 1) a device name, or 2) a VTEP IP. For the Ambient mesh case, both the Pod's device name and the Pod's IP will vary for each ztunnel Pod (i.e., for each Node). So if we want to be able to use the TrafficControl CRD, and define a single resource for the service mesh, we may need a more flexible way of selecting the target and return ports (which I assume would be the same here).

We could do a quick validation where we encap packets in OVS with Geneve, and send them directly to the ztunnel Pod, instead of having the packets go through the host network and iptables on the host. We also need to intercept and decap packets in the other direction. This would require no change in Istio AFAIK.

We should also be able to send the packets to the ztunnel Pod directly, without modification or encapsulation. Inside the ztunnel Pod, we would keep using TPROXY (either with iptables or eBPF?), which is what Istio does today. This would probably require some changes on the Istio side (ztunnel network configuration).

Adding @tnqn who is the TrafficControl expert.
Some useful links:

https://tetrate.io/blog/using-geneve-tunnels-to-implement-istio-ambient-mesh-traffic-interception/
https://tetrate.io/blog/transparent-traffic-intercepting-and-routing-in-the-l4-network-of-istio-ambient-mesh/
https://www.solo.io/blog/traffic-ambient-mesh-ztunnel-ebpf-waypoint/

@tschwaller @antoninbas I have tried Istio Ambient mode with Antrea and managed to make them work together, with a number of workarounds. Here are my findings:
For initialization, I found the current implementation of Ambient mode has an assumption on Pod network's implementation: It assumes the Pod is connected to host network via veth and there is a route entry for the Pod IP, which will be used to identify the ztunnel's veth and then the network namespace of ztunnel Pod. As Antrea doesn't have such per Pod route in host network, the istio-cni-node Pod failed to initialize some network resources. I worked around it by changing istio-cni-node to look for interface by veth name. This shouldn't be a problem as it's not hard to figure out a more generic way to identify Pod's interface.
Then I tried to use TrafficControl to redirect some Pods' traffic to ztunnel Pod via geneve tunnel. However, it can't work automatically because of the assumption on Pod network's implementation. After I resolved some rp_filter, policy routing, tunnel source IP mismatching issues, the encapsulated request was finally delivered to client side ztunnel Pod and triggered a response (SYN+ACK). However, the response didn't go symmetric path and didn't get encapsulated like the request, it seems assuming the response could be delivered to client automatically. But it would be dropped by Antrea's SpoofGuard flow. I didn't go this route further considering it looks more complicated.
The second attemp is to use TrafficControl to redirect Pod traffic to ztunnel Pod's port without encapsulation. As Antonin mentioned, the current API doesn't support specifying different receivers on different Nodes. I worked around it by creating two TrafficControl resources, one for client and one for server. The traffic is redirected to ztunnel Pod expectedly without encapsulation. Then to make ztunnel accept the traffic, I made a little change to TrafficControl flows to overwrite the destination MAC to the receiver Pod's MAC address so it won't be dropped when checking MAC. The last problem is, currently ztunnel differentiates redirected traffic by device name (redirected traffic is expected to be received on the geneve port pistioout), I made a little change to make it accept traffic by source IP (we could also use pkt_mark). After resolving these problems on both client and server Nodes side, the access succeeded:
# kubectl exec deploy/notsleep -- curl -s http://<IP_ADDRESS>:9080/ | grep -o "<title>.*</title>"
<title>Simple Bookstore App</title>

ztunnel on client side:
2023-11-09T11:03:35.965904Z  INFO outbound{id=3439f9fd7b82f709128abe6e98b3af54}: ztunnel::proxy::outbound: Proxying to <IP_ADDRESS>:9080 using TCP via <IP_ADDRESS>:9080 type Direct
2023-11-09T11:03:35.976537Z  INFO outbound{id=3439f9fd7b82f709128abe6e98b3af54}: ztunnel::proxy::outbound: complete dur=10.837747ms

ztunnel on server side:
2023-11-09T11:03:35.969110Z  INFO ztunnel::proxy::inbound_passthrough: accepted connection source=<IP_ADDRESS>:38493 destination=<IP_ADDRESS>:9080 component="inbound plaintext"
2023-11-09T11:03:35.976494Z  INFO ztunnel::proxy::inbound_passthrough: connection complete source=<IP_ADDRESS>:38493 destination=<IP_ADDRESS>:9080 component="inbound plaintext"

So I think redirecting traffic to ztunnel without encapsulation is promising. It should be simpler and more efficient. To make the whole workflow work automatically, changes are needed on both Istio and Antrea side, but there should be generic ways to make these changes.


What is this response error?

Hey Guys,
I use SwooleHttp to add order to KuCoin Futures but i receive this error in response:
"Swoole\Coroutine\Http\Client::execute(): Missing a compression package, 'Accept-Encoding' is ignored"

Which API did you use? Please provide the code. Thanks


Self Assessment: DRY, KISS, and YAGNI principles

I have reviewed my code and appears to be following the DRY, KISS, and YAGNI principles. I used functions to break down the code into smaller, reusable parts, and there is no unnecessary or redundant code.

This issue is successfully closed!

This issue is successfully closed!


Merge ttcli and Spring Initializr

I'm trying to integrate your book section <IP_ADDRESS> with an existing project that was created on Spring Initializr.  It was quite tedious to merge the two.  Not sure the best way to make this easier, perhaps a set of guidelines about what is created, what needs to be moved and what needs to be merged would be of assistance.
Nirvana would be the ttcli tool can be run in a directory with an existing Spring Boot project and "it just works"!

I agree that having the ttcli tool work on an existing project would be very nice, but I believe it would be quite hard to achieve given the many possible states the project might be in.

Hi Wim
Thank you for your books and ttcli
I found that I needed to add a proxy to be able to use ttcli in my environment
Currently, I have the proxy hardcoded in the springBootInitializrClient Bean (and hardcoded "isReachable" to be true)
I suppose I will work towards getting it from environment variables
Please give suggestions and/or comments
Thanks!


Use JsonSerializable, update score logic

@isoos – I wanted to pull the scores out into a JSON file so it's easy to update them from a script. While I was at it, I converted the rest of the JSON logic to JsonSerializable.

@isoos – thoughts?

lgtm pending the instructions in readme.md

README work coming...


Cannot go through setup with Jellyfin Account

Description
While I am using the OIDC preview build the setup also does not work with the :latest tag.
I cannot use my Jellyfin account to go through the setup steps.
I'd like to give more info but I am lacking more info myself
Version
<IP_ADDRESS> (preview-OIDC)
Steps to Reproduce

Open Setup page
Try to sign in?

Screenshots

Logs
[error][Auth]: Cannot read properties of undefined (reading 'Id')

Platform
desktop
Device
Desktop
Operating System
Windows 11
Browser
Firefox
Additional Context
Two seperate Docker nets.
They can reach each other through reverse proxy
Code of Conduct

[X] I agree to follow Jellyseerr's Code of Conduct

If you're not using oidc can you hop on discord. That's where we provide support.

PEBCAC: Had to allow external access


example_text_end_to_end_recognition can't find tesseract

The example_text_end_to_end_recognition example cannot find my tesseract installation. Here is the output:

IMG_W=800
IMG_H=600
TIME_REGION_DETECTION = 528.845
TIME_GROUPING = 31.0119
OCRTesseract(33): Tesseract not found.
TIME_OCR_INITIALIZATION = 0.018044
OCRTesseract(00): Tesseract not found.
OCRTesseract(00): Tesseract not found.
OCRTesseract(00): Tesseract not found.
OCRTesseract(00): Tesseract not found.
OCRTesseract(00): Tesseract not found.
TIME_OCR = 1.31494

This is the result of  tesseract --version

tesseract 3.03
leptonica-1.70
libgif 4.1.6(?) : libjpeg 8d : libpng 1.2.50 : libtiff 4.0.3 : zlib 1.2.8 : webp 0.4.0

Any ideas as to why this happens?  I have installed tesseract after compiling OpenCV, but that is not a problem, is it?

I have installed tesseract after compiling OpenCV, but that is not a problem, is it? - it is. the text module has to get linked ahgainst tesseract at build time.
re-run cmake, make sure it find tesseract, make, make install.

That fixed it

@berak , This worked, but how do I check if tesseract was found after cmake is done generating?

I was installing on another computer and the same thing happened. I think there is an issue with FindTesseract.cmake
I had to manually set liblept path in this file both times.

What is your system configuration?

Both are 64-bit linux machines. Ubuntu 14.04.

Doesn't cmake find the libraries (check for -- Tesseract:   YES in the output)? Where are tesseract and leptonica libraries located?

No, I had set the paths in FindTesseract.cmake manually both times. Only then did it find the libs. They are in /usr/local/lib/


Blank wallet

Created my wallet 2 years ago on mobile it didn't show me phrase now the whole wallet is blank whenever i open it

Dome

Revolved


how to upload file using php in this library?

how can i add f file as parameter to rest client? i create a question in this https://stackoverflow.com/questions/37089181/how-to-upload-file-using-php-restclient-library-by-php-code please help me.

This repository is for the rest-client Ruby library. You must be using some other library if you are using PHP.


Update broken docs/abstractions.py for changed ops, and add to CI

After https://github.com/geohot/tinygrad/pull/920, the docs were broken, by still using the FROMCPU LoadOp, updated and added to ci

Can you update the readme and https://github.com/geohot/tinygrad/blob/master/docs/adding_new_accelerators.md as well?


Question: Disable Youtube-DL from downloading playlists

Love the project.
I've been running the script for the past few days and noticed that Youtbe-dl is set to download the whole playlist in the link. Is there a supported way to disable this? I have many links in the same playlist.
It seems like it downloaded the entire playlist for each link so I end up with the same video many times.
I've commented line 493 here but I'm hoping for a supported method?
Thank you!

https://github.com/pirate/ArchiveBox/issues/503 Will allow you to do this, probably.

@degan6 https://github.com/pirate/ArchiveBox/pull/506/files this was merged already. You can play with the config for YOUTUBE_DL and control it however you want. Please reopen if this is not enough for your needs.


Create a multi stage dockerfile to build for multiple architectures

fixed in https://github.com/Guidewire/fern-reporter/pull/7/


全景深度

Very brilliant work. I would like to use your 360 degree depth estimator. But after reading the Docs I still dont know how to only run the depth estimator.  Input: A panoramic image; Output: A depth map for this panoramic depth

A single-panoramic image cannot be taken as the input of method. because the 360-degree MVSNet needs at least two image inputs and their poses.

If you want to estimate the depth of single-image, 360 monocular depth network is much better, such as UniFuse, BiFuse, HRDFuse.
Hrdfuse: Monocular 360deg depth estimation by collaboratively learning holistic-with-regional depth distributions


Code folding collapse

Remove empty characters after end when collapsed.

This is actually ok.
Small issue with indent guide

Also when word wrapped only "begin." is shown. Fixed.

Fixed.


UseCase: Delete QuestionSet API

Create an endpoint that will follow CRUD definitions for deletion of question set by ID.

Done


Stopped checking if destroyed cgroup is empty.

Linux patch 9c974c77246460fa6a92c18554c3311c8c83c160 makes exiting processes that are still attached to a cgroup visible in cgroup.procs. It is a fix/workaround for the issue where the cgroup cannot be removed even though it appears empty.
We already have a workaround for the removal problem in place: cgroup destroyer retries rmdir until it is successful.
With this change we add a workaround for the new cgroup.procs behavior. We can no longer expect a cgroup to look empty after TasksKiller reaps all processes that used to run inside it. So, instead, we rely on the original workaround to ensure that the cgroup is successfuly removed and keep process listing only for debugging purposes.
Alternatively, we could await for the cgroup to become empty before successfuly returning from TasksKiller. But it appears unnecessary with the remove workaround in place.

Fixed commit message. @bmahler


No indication save was successful when saving a new candidate in an election

When I attempt to add a candidate to an election I hit save but have no indication that it was successful except that the candidate remains if I nav away and back from the page.

I updated the Save button so that it will say when it is saving and deleting candidates, and will also be disabled when it is done. I'm still thinking of other possibilities (on candidate save and generally) about how to consistently provide feedback when communicating with the server, but this I think makes it quite a bit better than it was before.


Set a default value for project name when installing a project.

If I download a template named KewlGame, we should not force the user to have to type that name in order to complete the installation process.  The user can still rename it if they wish to but we should be providing a default value.  This quality of life enhancement will improve the workflow for newcomers to Godot who typically attempt to install a template as their first action within the program.

Thanks!


Add default_expr and default_fn

A proposal to resolve #368, this adds default_fn =  as an alias for default =  and also adds default_expr =  to allow providing any valid expression (e.g, a single literal, or a custom function call, or even a block) which will be used as the generator for the default value when deserialising.
If proc_macro_diagnostic were stabilised, serde could emit a deprecated warning for use of default = , but, as it's not, I've just left both available.

@dtolnay any news on this? I (and many others) would love to have the feature!

@dtolnay Any plans to merge this? It's a much desired feature.

@dtolnay Is there sense for @bossmc to rebase this? As in: do you intend to merge this PR one day? What would you think about a fork of serde_derive having extensions like this one?

I'll close this for now, but anyone should feel free to make follow-up PRs as outlined in https://github.com/serde-rs/serde/pull/1490#pullrequestreview-288464564.


chore: Fury header add language field

What does this PR do?
Add serialization language field for Fury Header in xlang_spec.
Related issues
https://github.com/apache/incubator-fury/issues/1607
Does this PR introduce any user-facing change?

[ ] Does this PR introduce any public API change?
[x] Does this PR introduce any binary protocol compatibility change?

Benchmark

PTAL @chaokunyang @theweipeng


By default, though mixer.policy.enabled=false istio deployment is creating pods related to policy

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities/
To ask questions about how to use Istio, please visit https://discuss.istio.io
)
Bug description
while installing Istio with helm, though the mixer.policy.enabled=false and mixer.telemetry.enabled=true, I'm able to see the deployments/pods related to policy and telemetry.
To eradicate this, I'm explicitly mentioning the parameters using --set
helm install istio.io/istio --name istio --version 1.1.9 --namespace istio-system  \
  --set mixer.policy.enabled=false \
  --set mixer.telemetry.enabled=true

And what If I need to add podAntiAffinity to these deployments?
I see this policy/telemetry are managed by istio-mixer, and all the labels are same for policy and telemetry, I could not able to add podAntiAffinity to both of the deployments.
Any solution for this, to add podAntiAffinity for policy and telemetry deployments.
Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version)
How was Istio installed?
Environment where bug was observed (cloud vendor, OS, etc)
Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

@mandarjog has said this is intended but I don't understand why. I am interested in this was well - I think we should remove it.

It is/was intended for two primary reasons, iirc:

ease adoption of policy use cases
upgrade / update situations. if you were using istio-policy and upgraded, it would be harmful if all of a sudden that workload wasn't available.

I want to enable policy and telemetry, as they are managed by istio-mixer, we have same labels defined for both, but we have diff deployment files, my question is can we differentiate both policy and telemetry so that we can add podAntiAffinity for the both deployment files (coz PDB is enabled for both policy and telemetry).

yes, the podspec use istio-mixer-type: policy and istio-mixer-type: telemetry labels.
If this is not enough, please reopen the issue.


chore(main): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2024-07-05)
Features

init (d66e55e)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.0.0
:sunflower:


As a user I would like to see that it is unable to overwrite an existing tag

I do not know whether this should be included in a bash script or that another repo should be created, but sometimes tags will be overwritten when docker push is executed. If it is possible to include a function that is able to check whether a tag exists and exists 1 then this could be prevented.
https://devops.stackexchange.com/q/1549/210

@jessfraz Added documentation as well. What is your opinion about this feature?

I think this is out of scope since it is a docker feature and can be implemented in bash


FPET-1046 removed list of notice notifications for DA cases

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/FPET-1046
Change description
FPET-1046 removed list of notice notifications for DA cases
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[X ] No

Closing this PR as no longer required

Closing this PR as no longer required


Fix helm lint fails when global values are used in subcharts

Signed-off-by: wawa0210<EMAIL_ADDRESS>Fix #8489
Introduced by #7288
What this PR does / why we need it:
When using helm lint --with-subcharts, the values.yaml data of the parent directory is not transferred to the subdirectory, resulting in missing global values, and helm lint failure
Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

@bacongobbler
Can you help, take some time to help reivew this pr? Looking forward to your comments

@bacongobbler
Can you help, take some time to help reivew this pr? Looking forward to your comments

Is this being merged in and released soon? Having the exact same issue: my helm lint commands all fail since I have a subchart being called even though i have a values.yaml file in my base chart folder setting that subchart to false by default.
dependencies:
  - name: external-ingress-template
    repository: "file://../charts/external-ingress-template"
    condition: global.externalIngress.enabled

~/git/ql-helm-charts$ helm lint charts/app-template/ --values charts/app-template/values.yaml --values helmatest/internal-api/values.yaml
[INFO] Chart.yaml: icon is recommended
[ERROR] templates/: template: app-template/charts/external-ingress-template/templates/ingress-gateway.yaml:15:22: executing "app-template/charts/external-ingress-template/templates/ingress-gateway.yaml" at <.Values.global.externalIngress.externalUrl>: wrong type for value; expected string; got interface {}

It shouldnt even be trying to do that since the values.yaml file in my base chart has this:
externalIngress:
    enabled: false

Is there any help needed to get this PR over the finish line?
I'd love to see this being resolved, as helm lint is only of limited use for our use case right now.

What's the current status of this?

Any update on this? Would love see this past the finish line.

The community has not responded for too long, if you think this PR is meaningful, I can try to follow up again

@wawa0210 In my eyes this i still meaningful

Any news on this?

If you're still interested in this, it'll need a rebase.


Added text color animation

Maybe the IFTTTColorAnimation could be renamed to IFTTTBackgroundColorAnimation to clear the confusion.

@revolter It looks like you might need to run pod update 'JazzHands' from the Example folder of JazzHands to make sure that your new files are included in the project- it's currently not building because of this.

Done

Ok, I don't understand why it fails and what should I do. I'm not so used with Github.

It looks like that fixed the build issue, but now one of our super strict automatic code checkers is complaining that in the header comments of your file IFTTTTextColorAnimation you are calling it IFTTTColorAnimation. If you fix that (in both the .m and .h files) it should be good to go!

Wow, awesome. Is this check included in something open source or is it custom made? And, how comes it's not checking for trailing whitespace?

That one is a linter that specifically checks the header style and makes sure the class names match. This is looking great, thanks for fixing it!

And thanks for merging it!


FromField ShortByteString instance

ShortByteStrings are often desirable for short fields instead of ByteStrings, so something along the following instance might be desirable:
import qualified Data.ByteString.Short as SBS

instance FromField ShortByteString where
    parseField = fmap SBS.toShort . parseField

/cc @dcoutts

@hvr this is fixed is it not?

indeed... was part of the cassava-<IP_ADDRESS> release afaics


deployment delete fails against cloud.elastic.co

Readiness Checklist

[x] I am running the latest version
[ ] I checked the documentation and found no answer
[x] I checked to make sure that this issue has not already been filed
[ ] I am reporting the issue to the correct repository (for multi-repository projects)

Expected Behavior
ecctl deployment delete my-deployment-id should delete a specified deployment.

Attempt to delete the deployment with ecctl deployment delete {id}

Context
I am trying to delete a deployment.
Your Environment

Version used: 1.0.1 (public binary)
Environment name and version (e.g. Go 1.9): N/A
Operating System and version: Linux x86-64

Hi @rhass ! The ecctl deployment delete command is an ECE only command. There are some endpoints in the API which are not public and this is one of them.
A good way to find out if a command is only available for ECE is to use the --help flag after the command. It will show you a text that says (Available for ECE only).
If you want to terminate deployments in ESS you should use the ecctl deployment shutdown command. Which will downscale a deployment and hide it.

Ah! Thanks!

@karencfv
I was just thinking, perhaps a better user experience would be to make the delete a flag option of shutdown which is only applicable to ece. Eg: ecctl shutdown --delete ece-deployment-id and ecctl shutdown ess-deployment-id.
Assuming shutdown works on ECE right now, this could improve the UX by making the same base command work for both ESS and ECE, while providing ECE users the option to delete the deployment.  However, I realize this is proposes a breaking change to the command line API since any scripts using ecctl deployment delete would have to be updated to ecctl deployment shutdown --delete.

Thanks for the suggestion! Unfortunately we are out of beta now so we can't make breaking changes like that. Your idea would have definitely made it clearer though 🤔


Using InputActionAsset instead of PlayerInput?

This project looks really great!
My only thought is that I wish it used the InputActionAsset instead of the PlayerInput.
Is this something you might consider adding? I was thinking I may have some time to contribute.
Thanks in advance!

Hey, this project is awesome, the only problem happens when using "Invoke Unity Events" in "Events Activation Mode", it always changes the Player Input's Events Activation Mode to "Invoke C# Events".
Basically, it prevents my Player Input from using "Invoke Unity Events".


Add usage descriptions

Sometimes when creating a CLI utility we want to add some extra text before or after the usage. This PR adds usage_description which allows setting a Usage header and footer with before and after. I know naming is not perfect, I'm super-open to suggestions!
Our case: we have a semi-mandatory (you can set a default in configuration) --country argument for almost every command in our toolkit but to know that you need to run foo command --help.

The failing CI seems to be misconfigured Travis...? I could use a second pair of eyes / project wisdom :)

Hi @d4rky-pl, I like the idea but I think we can't add @usage_description using an instance variable for a class because it won't be thread-safe, as you can see @commands  is thread-safe because we use concurrent-ruby for that. Can you experiment adding that option here? https://github.com/hanami/cli/pull/36/files#diff-04c6e90faac2675aa89e2176d2eec7d8R319
cc @jodosha what do you think about that?

@AlfonsoUceda hey, could you please check if this is enough? :)

I believe that latest CI fail is actually due to Travis bug this time

@katafrakt hey, could you please take a look at Travis so we can merge this? :)

It looks quite random to me. Probably related to https://github.com/travis-ci/travis-ci/issues/8978 Maybe someone with write right can just trigger a rebuild on Travis?

I've triggered the rebuild manually with --amend, would it be possible to merge and release this? We're kind of waiting for this feature :)

Hi @d4rky-pl, @jodosha and I have spoken about this, we like the idea and we understand it but we think this is not the place where to put that DSL, let us think about this meanwhile we'll keep this PR opened.
Thanks!

@AlfonsoUceda any chance you'll come up with something any time soon ("less than 3 months") or should I just fork hanami/cli for now?

@d4rky-pl Hi and thanks for this proposal. We think that this feature increases the internal complexity of the CLI, so we're skeptical to merge it. Thanks for understanding.

For anyone looking for how to implement this feature without modifying the hanami/cli itself, it turns out it's ridiculously easy and I should've thought of it sooner 😅
class App < Hanami::CLI
  def usage(result, out)
    # if you need to run this only for main command and not for foo subcommand use
    # if result.names.none?
    out.puts "Before usage"
    Usage.call(result, out) # can't use super because it calls exit(1)
    out.puts "After usage"
    exit(1)
  end
end

# then, replace Hanami::CLI.new(commands).call with App.new(commands).call

@d4rky-pl unfortunately this doesn't work anymore. Any idea how to fix this nicely?

nvm, reading code helps ;) This works for me:
class App < Dry::CLI
  def usage(result)
      err.puts "Before usage"
      err.puts Usage.call(result)
      err.puts "After usage"
      exit(1)
    end
end

# then, replace Dry::CLI.new(commands).call with App.new(commands).call


ARTEMIS-1766 - Persist LastValue queue config in bindings.

Added Integration tests for the issue.
Add lastvalue to the queue bindings that get persisted.

@michaelandrepearce the failure on compatibility test seems real

hmmmm... I'm not so sure... hang on

@clebertsuconic I think it’s unrelated. And simply pr build issue.
I ran tests all locally fine.

@michaelandrepearce yeah. unrelated.. I fixed the intermittent failure... will merge it soon.
if you're curious to see if it fixed.. rebase this PR and push -f.
I will merge this soon.


Add documentation and log information for enabling YJIT in LSP

This PR adds documentation on enabling YJIT for LSP client to the LSP documentation. It also includes an update to display whether YJIT is enabled or not during LSP startup.
Although it has not been measured, due to its nature as a server, there is a potential for improved execution efficiency with YJIT.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Nice addition!


MudStepper - No way to Uncomplete a step

I'm sure that I'm missing something here, but I can't see any way to uncomplete a step after calling CompleteStep(stepIndex).
When going back in steps, I want to uncomplete all steps that come after.

There is a Reset method in MudStepper to set all step status to continued. With the latest release 6.9.2 we also added SetStepStatus method that now you can set step status with step index programmatically.

Thanks, using SetStepStatus is sufficient.


BOM CSV no longer generated as of v2.0.0

README.md says:

After running it ./YOUR_SCHEMATIC.xml will be updated. You'll also get DESTINATION/YOUR_SCHEMATIC.csv contain a very basic BoM generated using KiCad's bom2grouped_csv.xsl template.

However, the CSV file appears to no longer be generated. I tested v2.1.1 and v2.0.0 and both are missing the CSV. Version 1.6.15 does still generate the CSV.
I don't see any commit messages specifically referencing its removal, so I'm hoping this is just a bug?
Thanks.

Hi @0xabe1 !
Thanks for pointing this out.
Is not a bug, the CSV was side effect of generating the XML.
To generate a BoM use KiBot, you'll have much more control on what is generated.

Ok, thanks!


Update Twiiter card to X card in Community section of webpage.

Update this:

To this:

I'm working on this, should be a quick fix!