status: CRD updates lead to excessive logs (and, possibly, perf impacts)

Anytime CRDs in the cluster change, Istiod outputs ~200 lines of logs:
2021-01-15T22:15:04.489377Z     info    source  Detected a CRD change while processing configuration events. Sending Reset event.
2021-01-15T22:15:04.489434Z     info    processing      session[170] "processing" => "terminating"
2021-01-15T22:15:04.651633Z     info    processing      session[170] "terminating" => "inactive"
2021-01-15T22:15:04.651704Z     info    processing      Runtime.run: Completing session: id:170
2021-01-15T22:15:04.651720Z     info    processing      Runtime.run: Starting new session id:171
2021-01-15T22:15:04.651731Z     info    processing      session[171] "inactive" => "starting"
2021-01-15T22:15:04.651848Z     info    processing      session.handleMeshEvent: Received initial mesh event, applying it: [Event](Added: istio/mesh/v1alpha1/MeshConfig/istio-system/meshconfig)
2021-01-15T22:15:04.651869Z     info    processing      session.handleMeshEvent: received an add/update mesh config event: [Event](Added: istio/mesh/v1alpha1/MeshConfig/istio-system/meshconfig)
2021-01-15T22:15:04.651897Z     info    processing      session.handleMeshEvent: Received initial mesh event, applying it: [Event](FullSync: istio/mesh/v1alpha1/MeshConfig)
2021-01-15T22:15:04.651904Z     info    processing      session.applyMeshEvent meshSynced: false => true
2021-01-15T22:15:04.651936Z     info    source  Beginning CRD Discovery, to figure out resources that are available...
2021-01-15T22:15:04.845605Z     info    ads     Push debounce stable[3048] 1: 100.908784ms since last change, 100.908598ms since last push, full=false
2021-01-15T22:15:04.845689Z     info    ads     XDS: Incremental Pushing:2021-01-15T22:14:13Z/547 ConnectedEndpoints:635
2021-01-15T22:15:05.026616Z     info    processing      session[171] "starting" => "terminating"
2021-01-15T22:15:05.052833Z     info    processing      session[171] "terminating" => "inactive"
2021-01-15T22:15:05.052877Z     info    processing      Runtime.run: Completing session: id:171
2021-01-15T22:15:05.052883Z     info    processing      Runtime.run: Starting new session id:172
2021-01-15T22:15:05.052898Z     info    processing      session[172] "inactive" => "starting"
2021-01-15T22:15:05.053044Z     info    processing      session.handleMeshEvent: Received initial mesh event, applying it: [Event](Added: istio/mesh/v1alpha1/MeshConfig/istio-system/meshconfig)
2021-01-15T22:15:05.053055Z     info    processing      session.handleMeshEvent: received an add/update mesh config event: [Event](Added: istio/mesh/v1alpha1/MeshConfig/istio-system/meshconfig)
2021-01-15T22:15:05.053080Z     info    processing      session.handleMeshEvent: Received initial mesh event, applying it: [Event](FullSync: istio/mesh/v1alpha1/MeshConfig)
2021-01-15T22:15:05.053085Z     info    processing      session.applyMeshEvent meshSynced: false => true
2021-01-15T22:15:05.053144Z     info    source  Beginning CRD Discovery, to figure out resources that are available...
2021-01-15T22:15:05.353600Z     info    processing      session[172] "starting" => "buffering"
2021-01-15T22:15:05.353656Z     info    source  CRD Discovery complete, starting listening to resources...
2021-01-15T22:15:05.353731Z     info    source  Creating watchers for Kubernetes CRDs
2021-01-15T22:15:05.353749Z     info    source  [0]
2021-01-15T22:15:05.353758Z     info    source    Source:       apiextensions.k8s.io/v1beta1/CustomResourceDefinition
2021-01-15T22:15:05.353763Z     info    source    Name:                  k8s/apiextensions.k8s.io/v1beta1/customresourcedefinitions
2021-01-15T22:15:05.353767Z     info    source    Built-in:     true
2021-01-15T22:15:05.353770Z     info    source    Disabled:     true
2021-01-15T22:15:05.353778Z     info    source  [1]
2021-01-15T22:15:05.353781Z     info    source    Source:       apps/v1/Deployment
2021-01-15T22:15:05.353784Z     info    source    Name:                  k8s/apps/v1/deployments
2021-01-15T22:15:05.353787Z     info    source    Built-in:     true
2021-01-15T22:15:05.353790Z     info    source    Disabled:     true
2021-01-15T22:15:05.353794Z     info    source  [2]
2021-01-15T22:15:05.353797Z     info    source    Source:       core/v1/ConfigMap
2021-01-15T22:15:05.353800Z     info    source    Name:                  k8s/core/v1/configmaps
2021-01-15T22:15:05.353803Z     info    source    Built-in:     true
2021-01-15T22:15:05.353806Z     info    source    Disabled:     true
2021-01-15T22:15:05.353809Z     info    source  [3]
2021-01-15T22:15:05.353812Z     info    source    Source:       core/v1/Endpoints
2021-01-15T22:15:05.353820Z     info    source    Name:                  k8s/core/v1/endpoints
2021-01-15T22:15:05.353823Z     info    source    Built-in:     true
2021-01-15T22:15:05.353826Z     info    source    Disabled:     true
2021-01-15T22:15:05.353829Z     info    source  [4]
2021-01-15T22:15:05.353833Z     info    source    Source:       core/v1/Namespace
2021-01-15T22:15:05.353837Z     info    source    Name:                  k8s/core/v1/namespaces
2021-01-15T22:15:05.353840Z     info    source    Built-in:     true
2021-01-15T22:15:05.353834Z     info    processing      session[172] "buffering" => "processing"
2021-01-15T22:15:05.353843Z     info    source    Disabled:     true
2021-01-15T22:15:05.353856Z     info    source  [5]
2021-01-15T22:15:05.353860Z     info    source    Source:       core/v1/Node
2021-01-15T22:15:05.353863Z     info    source    Name:                  k8s/core/v1/nodes
2021-01-15T22:15:05.353866Z     info    source    Built-in:     true
2021-01-15T22:15:05.353869Z     info    source    Disabled:     true
2021-01-15T22:15:05.353872Z     info    source  [6]
2021-01-15T22:15:05.353876Z     info    source    Source:       core/v1/Pod
2021-01-15T22:15:05.353879Z     info    source    Name:                  k8s/core/v1/pods
2021-01-15T22:15:05.353882Z     info    source    Built-in:     true
2021-01-15T22:15:05.353884Z     info    source    Disabled:     true
2021-01-15T22:15:05.353888Z     info    source  [7]
2021-01-15T22:15:05.353891Z     info    source    Source:       core/v1/Secret
2021-01-15T22:15:05.353894Z     info    source    Name:                  k8s/core/v1/secrets
2021-01-15T22:15:05.353897Z     info    source    Built-in:     true
2021-01-15T22:15:05.353900Z     info    source    Disabled:     true
2021-01-15T22:15:05.353903Z     info    source  [8]
2021-01-15T22:15:05.353906Z     info    source    Source:       core/v1/Service
2021-01-15T22:15:05.353909Z     info    source    Name:                  k8s/core/v1/services
2021-01-15T22:15:05.353912Z     info    source    Built-in:     true
2021-01-15T22:15:05.353914Z     info    source    Disabled:     true
2021-01-15T22:15:05.353918Z     info    source  [9]
2021-01-15T22:15:05.353922Z     info    source    Source:       extensions/v1beta1/Ingress
2021-01-15T22:15:05.353925Z     info    source    Name:                  k8s/extensions/v1beta1/ingresses
2021-01-15T22:15:05.353928Z     info    source    Built-in:     true
2021-01-15T22:15:05.353930Z     info    source    Disabled:     true
2021-01-15T22:15:05.353935Z     info    source  [10]
2021-01-15T22:15:05.353940Z     info    source    Source:       networking.istio.io/v1alpha3/DestinationRule
2021-01-15T22:15:05.353944Z     info    source    Name:                  k8s/networking.istio.io/v1alpha3/destinationrules
2021-01-15T22:15:05.353948Z     info    source    Built-in:     false
2021-01-15T22:15:05.353951Z     info    source    Disabled:     false
2021-01-15T22:15:05.353954Z     info    source    Found:  true
2021-01-15T22:15:05.353960Z     info    source  [11]
2021-01-15T22:15:05.353966Z     info    source    Source:       networking.istio.io/v1alpha3/EnvoyFilter
2021-01-15T22:15:05.353969Z     info    source    Name:                  k8s/networking.istio.io/v1alpha3/envoyfilters
2021-01-15T22:15:05.353973Z     info    source    Built-in:     false
2021-01-15T22:15:05.353976Z     info    source    Disabled:     false
2021-01-15T22:15:05.353978Z     info    source    Found:  true
2021-01-15T22:15:05.353982Z     info    source  [12]
2021-01-15T22:15:05.353986Z     info    source    Source:       networking.istio.io/v1alpha3/Gateway
2021-01-15T22:15:05.353989Z     info    source    Name:                  k8s/networking.istio.io/v1alpha3/gateways
2021-01-15T22:15:05.353992Z     info    source    Built-in:     false
2021-01-15T22:15:05.353994Z     info    source    Disabled:     false
2021-01-15T22:15:05.353997Z     info    source    Found:  true
2021-01-15T22:15:05.354001Z     info    source  [13]
2021-01-15T22:15:05.354004Z     info    source    Source:       networking.istio.io/v1alpha3/ServiceEntry
2021-01-15T22:15:05.354007Z     info    source    Name:                  k8s/networking.istio.io/v1alpha3/serviceentries
2021-01-15T22:15:05.353921Z     warn    processing      Router.Handle: No handler for event, dropping: [Event](FullSync: k8s/core/v1/endpoints)
2021-01-15T22:15:05.354053Z     warn    processing      Router.Handle: No handler for event, dropping: [Event](FullSync: k8s/core/v1/nodes)
2021-01-15T22:15:05.354072Z     warn    processing      Router.Handle: No handler for event, dropping: [Event](FullSync: k8s/extensions/v1beta1/ingresses)
2021-01-15T22:15:05.354010Z     info    source    Built-in:     false
2021-01-15T22:15:05.354091Z     info    source    Disabled:     false
2021-01-15T22:15:05.354095Z     info    source    Found:  true
2021-01-15T22:15:05.354103Z     info    source  [14]
2021-01-15T22:15:05.354108Z     info    source    Source:       networking.istio.io/v1alpha3/Sidecar
2021-01-15T22:15:05.354112Z     info    source    Name:                  k8s/networking.istio.io/v1alpha3/sidecars
2021-01-15T22:15:05.354115Z     info    source    Built-in:     false
2021-01-15T22:15:05.354119Z     info    source    Disabled:     false
2021-01-15T22:15:05.354123Z     info    source    Found:  true
2021-01-15T22:15:05.354169Z     info    source  [15]
2021-01-15T22:15:05.354174Z     info    source    Source:       networking.istio.io/v1alpha3/VirtualService
2021-01-15T22:15:05.354177Z     info    source    Name:                  k8s/networking.istio.io/v1alpha3/virtualservices
2021-01-15T22:15:05.354180Z     info    source    Built-in:     false
2021-01-15T22:15:05.354183Z     info    source    Disabled:     false
2021-01-15T22:15:05.354186Z     info    source    Found:  true
2021-01-15T22:15:05.354190Z     info    source  [16]
2021-01-15T22:15:05.354195Z     info    source    Source:       networking.istio.io/v1alpha3/WorkloadEntry
2021-01-15T22:15:05.354198Z     info    source    Name:                  k8s/networking.istio.io/v1alpha3/workloadentries
2021-01-15T22:15:05.354201Z     info    source    Built-in:     false
2021-01-15T22:15:05.354204Z     info    source    Disabled:     false
2021-01-15T22:15:05.354207Z     info    source    Found:  true
2021-01-15T22:15:05.354211Z     info    source  [17]
2021-01-15T22:15:05.354214Z     info    source    Source:       networking.istio.io/v1alpha3/WorkloadGroup
2021-01-15T22:15:05.354218Z     info    source    Name:                  k8s/networking.istio.io/v1alpha3/workloadgroups
2021-01-15T22:15:05.354220Z     info    source    Built-in:     false
2021-01-15T22:15:05.354223Z     info    source    Disabled:     false
2021-01-15T22:15:05.354226Z     info    source    Found:  true
2021-01-15T22:15:05.354230Z     info    source  [18]
2021-01-15T22:15:05.354235Z     info    source    Source:       networking.x-k8s.io/v1alpha1/BackendPolicy
2021-01-15T22:15:05.354240Z     info    source    Name:                  k8s/service_apis/v1alpha1/backendpolicies
2021-01-15T22:15:05.354243Z     info    source    Built-in:     false
2021-01-15T22:15:05.354246Z     info    source    Disabled:     true
2021-01-15T22:15:05.354248Z     info    source    Found:  false
2021-01-15T22:15:05.354254Z     info    source  [19]
2021-01-15T22:15:05.354258Z     info    source    Source:       networking.x-k8s.io/v1alpha1/Gateway
2021-01-15T22:15:05.354261Z     info    source    Name:                  k8s/service_apis/v1alpha1/gateways
2021-01-15T22:15:05.354264Z     info    source    Built-in:     false
2021-01-15T22:15:05.354267Z     info    source    Disabled:     true
2021-01-15T22:15:05.354269Z     info    source    Found:  false
2021-01-15T22:15:05.354292Z     info    source  [20]
2021-01-15T22:15:05.354299Z     info    source    Source:       networking.x-k8s.io/v1alpha1/GatewayClass
2021-01-15T22:15:05.354304Z     info    source    Name:                  k8s/service_apis/v1alpha1/gatewayclasses
2021-01-15T22:15:05.354307Z     info    source    Built-in:     false
2021-01-15T22:15:05.354310Z     info    source    Disabled:     true
2021-01-15T22:15:05.354313Z     info    source    Found:  false
2021-01-15T22:15:05.354324Z     info    source  [21]
2021-01-15T22:15:05.354328Z     info    source    Source:       networking.x-k8s.io/v1alpha1/HTTPRoute
2021-01-15T22:15:05.354332Z     info    source    Name:                  k8s/service_apis/v1alpha1/httproutes
2021-01-15T22:15:05.354335Z     info    source    Built-in:     false
2021-01-15T22:15:05.354338Z     info    source    Disabled:     true
2021-01-15T22:15:05.354340Z     info    source    Found:  false
2021-01-15T22:15:05.354344Z     info    source  [22]
2021-01-15T22:15:05.354348Z     info    source    Source:       networking.x-k8s.io/v1alpha1/TCPRoute
2021-01-15T22:15:05.354351Z     info    source    Name:                  k8s/service_apis/v1alpha1/tcproutes
2021-01-15T22:15:05.354354Z     info    source    Built-in:     false
2021-01-15T22:15:05.354357Z     info    source    Disabled:     true
2021-01-15T22:15:05.354359Z     info    source    Found:  false
2021-01-15T22:15:05.354363Z     info    source  [23]
2021-01-15T22:15:05.354366Z     info    source    Source:       networking.x-k8s.io/v1alpha1/TLSRoute
2021-01-15T22:15:05.354369Z     info    source    Name:                  k8s/service_apis/v1alpha1/tlsroutes
2021-01-15T22:15:05.354372Z     info    source    Built-in:     false
2021-01-15T22:15:05.354375Z     info    source    Disabled:     true
2021-01-15T22:15:05.354377Z     info    source    Found:  false
2021-01-15T22:15:05.354382Z     info    source  [24]
2021-01-15T22:15:05.354385Z     info    source    Source:       security.istio.io/v1beta1/AuthorizationPolicy
2021-01-15T22:15:05.354388Z     info    source    Name:                  k8s/security.istio.io/v1beta1/authorizationpolicies
2021-01-15T22:15:05.354391Z     info    source    Built-in:     false
2021-01-15T22:15:05.354393Z     info    source    Disabled:     false
2021-01-15T22:15:05.354401Z     info    source    Found:  true
2021-01-15T22:15:05.354408Z     info    source  [25]
2021-01-15T22:15:05.354411Z     info    source    Source:       security.istio.io/v1beta1/PeerAuthentication
2021-01-15T22:15:05.354414Z     info    source    Name:                  k8s/security.istio.io/v1beta1/peerauthentications
2021-01-15T22:15:05.354417Z     info    source    Built-in:     false
2021-01-15T22:15:05.354420Z     info    source    Disabled:     false
2021-01-15T22:15:05.354422Z     info    source    Found:  true
2021-01-15T22:15:05.354427Z     info    source  [26]
2021-01-15T22:15:05.354430Z     info    source    Source:       security.istio.io/v1beta1/RequestAuthentication
2021-01-15T22:15:05.354436Z     info    source    Name:                  k8s/security.istio.io/v1beta1/requestauthentications
2021-01-15T22:15:05.354439Z     info    source    Built-in:     false
2021-01-15T22:15:05.354442Z     info    source    Disabled:     false
2021-01-15T22:15:05.354445Z     info    source    Found:  true
2021-01-15T22:15:05.354449Z     info    source  Starting status controller...
2021-01-15T22:15:05.354577Z     warn    processing      Router.Handle: No handler for event, dropping: [Event](FullSync: k8s/service_apis/v1alpha1/backendpolicies)
2021-01-15T22:15:05.354595Z     warn    processing      Router.Handle: No handler for event, dropping: [Event](FullSync: k8s/service_apis/v1alpha1/gateways)
2021-01-15T22:15:05.354600Z     warn    processing      Router.Handle: No handler for event, dropping: [Event](FullSync: k8s/service_apis/v1alpha1/gatewayclasses)
2021-01-15T22:15:05.354605Z     warn    processing      Router.Handle: No handler for event, dropping: [Event](FullSync: k8s/service_apis/v1alpha1/httproutes)
2021-01-15T22:15:05.354609Z     warn    processing      Router.Handle: No handler for event, dropping: [Event](FullSync: k8s/service_apis/v1alpha1/tcproutes)
2021-01-15T22:15:05.354614Z     warn    processing      Router.Handle: No handler for event, dropping: [Event](FullSync: k8s/service_apis/v1alpha1/tlsroutes)

In my cluster, for various reasons, CRDs are updated many times per minute, absolutely spammingthe logs. This may also have a real impact on the status distribution/perf - I am not sure.
Aside from the logging load, the CRD writes have nothing to do with Istio at all, so it seems excessive - the CRDs are for another project.

Seems like we could just turn down the verbosity for the logs from the 'source' scope?

Seems like we could just turn down the verbosity for the logs from the 'source' scope?

istiod spews lots of logs like the following. This should also be fixed, though I am not sure if it is due to status.
2021-01-16T01:12:58.754354Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:12:58.758653Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:12:58.759040Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:12:58.829841Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:12:58.834118Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:12:58.834456Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:12:59.758968Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:12:59.763447Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:12:59.763961Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:12:59.834426Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:12:59.839235Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:12:59.839652Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:00.763753Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:00.768481Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:00.768902Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:00.839462Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:00.844016Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:00.844448Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:01.768681Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:01.773283Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:01.773795Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:01.844260Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:01.848513Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:01.849203Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:02.637274Z	info	ads	Push debounce stable[101958] 1: 100.129928ms since last change, 100.129727ms since last push, full=false
2021-01-16T01:13:02.637462Z	info	ads	XDS:EDSInc Pushing:2021-01-16T01:12:54Z/18794 Services:map[svc10-0-4-0.service-graph10.svc.cluster.local:{}] ConnectedEndpoints:12
2021-01-16T01:13:02.773591Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:02.778481Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:02.778852Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:02.848815Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:02.853052Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:02.853452Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:03.747146Z	info	ads	Push debounce stable[101959] 2: 100.160708ms since last change, 129.591985ms since last push, full=false
2021-01-16T01:13:03.747230Z	info	ads	XDS:EDSInc Pushing:2021-01-16T01:12:54Z/18794 Services:map[svc01-0-5.service-graph01.svc.cluster.local:{}] ConnectedEndpoints:12
2021-01-16T01:13:03.778847Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:03.783554Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:03.784038Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:03.853394Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:03.857150Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:03.857708Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No

istiod spews lots of logs like the following. This should also be fixed, though I am not sure if it is due to status.
2021-01-16T01:12:58.754354Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:12:58.758653Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:12:58.759040Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:12:58.829841Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:12:58.834118Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:12:58.834456Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:12:59.758968Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:12:59.763447Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:12:59.763961Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:12:59.834426Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:12:59.839235Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:12:59.839652Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:00.763753Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:00.768481Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:00.768902Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:00.839462Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:00.844016Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:00.844448Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:01.768681Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:01.773283Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:01.773795Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:01.844260Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:01.848513Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:01.849203Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:02.637274Z	info	ads	Push debounce stable[101958] 1: 100.129928ms since last change, 100.129727ms since last push, full=false
2021-01-16T01:13:02.637462Z	info	ads	XDS:EDSInc Pushing:2021-01-16T01:12:54Z/18794 Services:map[svc10-0-4-0.service-graph10.svc.cluster.local:{}] ConnectedEndpoints:12
2021-01-16T01:13:02.773591Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:02.778481Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:02.778852Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:02.848815Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:02.853052Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:02.853452Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:03.747146Z	info	ads	Push debounce stable[101959] 2: 100.160708ms since last change, 129.591985ms since last push, full=false
2021-01-16T01:13:03.747230Z	info	ads	XDS:EDSInc Pushing:2021-01-16T01:12:54Z/18794 Services:map[svc01-0-5.service-graph01.svc.cluster.local:{}] ConnectedEndpoints:12
2021-01-16T01:13:03.778847Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:03.783554Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:03.784038Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:03.853394Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:03.857150Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:03.857708Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No

That is not due to status. It's also a real issue, not just logging.
However, the logs are still excessive, even when it does work.
On Fri, Jan 15, 2021, 5:15 PM mandarjog<EMAIL_ADDRESS>wrote:

istiod spews lots of logs like the following. This should also be fixed,
though I am not sure if it is due to status.
2021-01-16T01:12:58.754354Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:12:58.758653Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:12:58.759040Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:12:58.829841Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:12:58.834118Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:12:58.834456Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:12:59.758968Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:12:59.763447Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:12:59.763961Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:12:59.834426Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:12:59.839235Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:12:59.839652Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:00.763753Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:00.768481Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:00.768902Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:00.839462Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:00.844016Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:00.844448Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:01.768681Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:01.773283Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:01.773795Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:01.844260Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:01.848513Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:01.849203Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:02.637274Z	info	ads	Push debounce stable[101958] 1: 100.129928ms since last change, 100.129727ms since last push, full=false
2021-01-16T01:13:02.637462Z	info	ads	XDS:EDSInc Pushing:2021-01-16T01:12:54Z/18794 Services:map[svc10-0-4-0.service-graph10.svc.cluster.local:{}] ConnectedEndpoints:12
2021-01-16T01:13:02.773591Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:02.778481Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:02.778852Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:02.848815Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:02.853052Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:02.853452Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:03.747146Z	info	ads	Push debounce stable[101959] 2: 100.160708ms since last change, 129.591985ms since last push, full=false
2021-01-16T01:13:03.747230Z	info	ads	XDS:EDSInc Pushing:2021-01-16T01:12:54Z/18794 Services:map[svc01-0-5.service-graph01.svc.cluster.local:{}] ConnectedEndpoints:12
2021-01-16T01:13:03.778847Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:03.783554Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:03.784038Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:03.853394Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:03.857150Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:03.857708Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/30130#issuecomment-761282434, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXIML56JIYOUZTOFXELS2DSDBANCNFSM4WEVZITA
.

That is not due to status. It's also a real issue, not just logging.
However, the logs are still excessive, even when it does work.
On Fri, Jan 15, 2021, 5:15 PM mandarjog<EMAIL_ADDRESS>wrote:

istiod spews lots of logs like the following. This should also be fixed,
though I am not sure if it is due to status.
2021-01-16T01:12:58.754354Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:12:58.758653Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:12:58.759040Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:12:58.829841Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:12:58.834118Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:12:58.834456Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:12:59.758968Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:12:59.763447Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:12:59.763961Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:12:59.834426Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:12:59.839235Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:12:59.839652Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:00.763753Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:00.768481Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:00.768902Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:00.839462Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:00.844016Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:00.844448Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:01.768681Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:01.773283Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:01.773795Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:01.844260Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:01.848513Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:01.849203Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:02.637274Z	info	ads	Push debounce stable[101958] 1: 100.129928ms since last change, 100.129727ms since last push, full=false
2021-01-16T01:13:02.637462Z	info	ads	XDS:EDSInc Pushing:2021-01-16T01:12:54Z/18794 Services:map[svc10-0-4-0.service-graph10.svc.cluster.local:{}] ConnectedEndpoints:12
2021-01-16T01:13:02.773591Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:02.778481Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:02.778852Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:02.848815Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:02.853052Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:02.853452Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:03.747146Z	info	ads	Push debounce stable[101959] 2: 100.160708ms since last change, 129.591985ms since last push, full=false
2021-01-16T01:13:03.747230Z	info	ads	XDS:EDSInc Pushing:2021-01-16T01:12:54Z/18794 Services:map[svc01-0-5.service-graph01.svc.cluster.local:{}] ConnectedEndpoints:12
2021-01-16T01:13:03.778847Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:03.783554Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:03.784038Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No change required.
2021-01-16T01:13:03.853394Z	info	validationController	Reconcile(enter): retry dry-run creation of invalid config
2021-01-16T01:13:03.857150Z	info	validationController	Not ready to switch validation to fail-closed: dummy invalid config not rejected
2021-01-16T01:13:03.857708Z	info	validationController	validatingwebhookconfiguration istiod-istio-system (failurePolicy=Ignore, resourceVersion=137136112) is up-to-date. No
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/30130#issuecomment-761282434, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXIML56JIYOUZTOFXELS2DSDBANCNFSM4WEVZITA
.

not stale
On Thu, Apr 15, 2021 at 10:05 PM Istio Policy Bot @.***>
wrote:

🧭 This issue or pull request has been automatically marked as stale
because it has not had activity from an Istio team member since 2021-01-16.
It will be closed on 2021-05-01 unless an Istio team member takes action.
Please see this wiki page
https://github.com/istio/istio/wiki/Issue-and-Pull-Request-Lifecycle-Manager
for more information. Thank you for your contributions.
Created by the issue and PR lifecycle manager.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/30130#issuecomment-820908061, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXIJJCT67YAVUSFY2K3TI7AQRANCNFSM4WEVZITA
.


Add hostname placeholder. Headers use replacer

Issue #738
On matched header rules, replacer is used to replace any placeholders
defined in header rules iex. X-Backend {hostname} where {hostname} will
be replaced by the hostname key present in the replacer
hostname key added to replacer. The value is determined by the output of
os.Hostname()

 You should sign our Contributor License Agreement in order to get your pull request merged.

Thanks @Burmudar! This looks fantastic.
I know there is some more discussion about how to handle headers in #666. Perhaps if you wanted to take a look, that'd be another good one to jump into! Perhaps you could help @p4tin...

Glad I could help @mholt!
What about the documentation for the header directive ? I haven't looked yet, but is there a place where I can update the documentation for it ?
Thanks for pointing me to #666. I'll go take a look soon and see if I can be of use :smile:

@Burmudar Sure -- see https://github.com/caddyserver/caddyserver.com. I was going to do it but I'd be even happier if you submitted a PR, shouldn't be more than a line or two I guess!


The Xcode build system has crashed

MAC: 10.12.6
Xcode 9 beta 5
When I dragged "R.generated.swift" into the project, "XCBBuildService" crashed. Reopening "Xcode" still crashes

That's not so nice! Did you use the latest R.swift version? If so this sounds to me like an Xcode beta issue that you should report to Apple. Xcode should never crash on whatever file you drag into it.

Hope that "Xcode 9 beta 6" can solve this problem ...


Add CSS styling to forc doc

This PR adds styling and some updates to the structure of the docs produced by forc doc.  It also makes the sidebar visible but the items aren't added yet so #3170 will remain open until then.

[x] Figure out where to host CSS, icon & logo files

Closes #3169

There are some TODOs in here that I wouldn't mind some input on, and in general I always welcome the keen eyes of @kayagokalp

not sure why the markdown lint is failing, anyone?

Looking great @eureka-cpu !

Not sure why the markdown lint is failing, anyone? These are directly from cargo doc

Here are the errors the markdown linter are showing in CI:
forc-plugins/forc-doc/src/assets/SourceSerif4-LICENSE.md:1:28 MD034/no-bare-urls Bare URL used [Context: "http://www.adobe.com/"]
forc-plugins/forc-doc/src/assets/SourceSerif4-LICENSE.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "Copyright 2014-2021 Adobe (htt..."]
forc-plugins/forc-doc/src/assets/SourceSerif4-LICENSE.md:5:68 MD034/no-bare-urls Bare URL used [Context: "http://scripts.sil.org/OFL"]
forc-plugins/forc-doc/src/assets/SourceSerif4-LICENSE.md:7 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
forc-plugins/forc-doc/src/assets/SourceSerif4-LICENSE.md:9 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007"]

It looks like the SourceSerif4 license is a markdown file and it's not satisfying the linter. I think we should either work out how to ignore it or address the lints.
Also, using include_dir! on assets means that we're including these licenses in the compiled binary. Is there any chance we can separate the license files themselves into a forc-doc/licenses directory or similar? Including it in the same directory might be a condition of one of the licenses, so we should be careful here.
This PR also adds the MIT and APACHE licenses to assets, but it's not clear which assets these are for - should we include the asset name in the license name like the font licenses?
Are the added SVGs public domain? Or do they have a license we should be including?

Looking great @eureka-cpu !

Not sure why the markdown lint is failing, anyone? These are directly from cargo doc

Here are the errors the markdown linter are showing in CI:
forc-plugins/forc-doc/src/assets/SourceSerif4-LICENSE.md:1:28 MD034/no-bare-urls Bare URL used [Context: "http://www.adobe.com/"]
forc-plugins/forc-doc/src/assets/SourceSerif4-LICENSE.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "Copyright 2014-2021 Adobe (htt..."]
forc-plugins/forc-doc/src/assets/SourceSerif4-LICENSE.md:5:68 MD034/no-bare-urls Bare URL used [Context: "http://scripts.sil.org/OFL"]
forc-plugins/forc-doc/src/assets/SourceSerif4-LICENSE.md:7 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
forc-plugins/forc-doc/src/assets/SourceSerif4-LICENSE.md:9 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007"]

It looks like the SourceSerif4 license is a markdown file and it's not satisfying the linter. I think we should either work out how to ignore it or address the lints.
Also, using include_dir! on assets means that we're including these licenses in the compiled binary. Is there any chance we can separate the license files themselves into a forc-doc/licenses directory or similar? Including it in the same directory might be a condition of one of the licenses, so we should be careful here.
This PR also adds the MIT and APACHE licenses to assets, but it's not clear which assets these are for - should we include the asset name in the license name like the font licenses?
Are the added SVGs public domain? Or do they have a license we should be including?

So here I'm just including all of the licenses that were generated with cargo doc, and it does not necessarily specify what they are for. They were included in the same directory as the assets themselves though, so I included them just to be careful. I'll do a bit more digging on this tomorrow morning!

https://github.com/igorshubovych/markdownlint-cli supports ignoring with --ignore-path

markdownlint-cli supports ignoring with --ignore-path: https://github.com/igorshubovych/markdownlint-cli#usage

Even easier, you can include a .markdownlintignore


WIP: Client auth tests and Custom acceptor CA

This has some client auth tests. It also adds custom association for CAs on the server side.

@sfackler since you're looking at this: I've got a problem in getting this to pass. Two issues really:

on macOS: I can not get the server side of the connection to accept the client cert. I'm not sure what I'm doing wrong there.

on Linux and OpenSSL: there is a hang on client auth. I noticed this in my TRust-DNS work, and started trying to narrow down the cause. I need to throw it into a debugger...

There's a test for client auth in the security-framework repo: https://github.com/sfackler/rust-security-framework/blob/master/security-framework/src/os/macos/secure_transport.rs#L462

Hm, can you explain:
https://github.com/sfackler/rust-security-framework/blob/master/security-framework/src/os/macos/secure_transport.rs#L478
            let stream = p!(listener.accept()).0;

            match ctx.handshake(stream) {
                Ok(_) => panic!("unexpected success"),
                Err(HandshakeError::Failure(_)) => {}
                Err(err) => panic!("unexpected error {:?}", err),
            }

Shouldn't that Failure be Interrupted?

Hmm, looking back at that test that does seem strange... I'm not really sure why that would be expected to fail.

The error I'm getting on the server side test on macOS is
'Failure(Error { code: -9807, message: "invalid certificate chain" })'
So I was going to start investigating the server side registration of the cert to see if there's an issue there, as the same cert construction works in all other contexts.

I wonder if the configured anchor certs aren't taken into account? It may require breaking on peer certs and doing it manually?

I think we might be missing errSSLServerAuthCompleted in this block:
https://github.com/sfackler/rust-security-framework/blob/master/security-framework/src/secure_transport.rs#L929
based on this doc: https://developer.apple.com/reference/security/1400161-sslhandshake?language=objc
I'll see if I can find that code.

@sfackler , see recent change, this doesn't validate the cert chain... we'll need to figure that out, but it does properly pause on the client and then resume to complete the connection.

What do you think of providing a single function abstraction over the three different implementations to handle this case?
It would be something like:
fn handle_client_auth(cert: X509Type) -> Result<()>;

The X509Type would need to be a wrapper type of the specific implementation across the underlying libraries. The complexity here, is that we'll need to establish custom certificate chains for validating the client. I think the cert chain and how it is validated will be somewhat domain specific, but it's probably hairy enough that there should be some standard interfaces for certificate validation. Do you have any thoughts in this area? I imagine these would be custom SslContexts...

@anowell this is the PR I mentioned at RustConf I was working on a while back for some mTLS stuff. Do you think it's out of date/unnecessary at this point?

Thanks, @bluejekyll. I haven't had a chance to dig deep enough into this change yet, but before I crash for the night I thought I'd point you at how I'm currently reading client key/cert from a kubernetes config and then turning that into a Pkcs12 that I plumb through [a fork of reqwest] to native-tls. Of course issue #27 has some discussion around proposed changes to that API.


Reading serial ERROR_OPERATION_ABORTED (995)

Reading bytes from the serial unexpected terminated with the error
error(syscall.Errno) golang.org/x/sys/windows.ERROR_OPERATION_ABORTED (995)

Sample code
The sample code below
serialMode := &serial.Config{Name: "COM4", Baud: baudRate, Size: 8, Parity: serial.ParityNone, StopBits: 1}
port, err := serial.OpenPort(serialMode)
for {
	reader := bufio.NewReader(port)
	reply, err := reader.ReadBytes('\x0a')
	if err != nil {
		panic(err)
	}
	fmt.Println(reply)
}

Other info
Platform: Windows 10
Golang: go version go1.21.3 windows/amd64
Serial interface: USB to Serial

Another interesting behavior happens when the Reader replaced by Scanner (example before)
Lets assume to call the next code in the infinitive loop, and the serial port gets infinitive stream of bytes. Then the line 8 will never be executed because the scanner returns empty lines. But if break the app in the line 1 or 2 and then continue execution, then the line 8 will print a valid data as minimum once.
Looks like "calling the reader with hi rate does not allow to get a data"
1	scanner := bufio.NewScanner(port)
2	scanner.Scan()
3	text := scanner.Text()
4
5	fmt.Println(text)
6	n := len(text)
7	if n > 0 {
8		fmt.Println(n)
9	}


(language?) Messed up syntax highlighting involving macros

See https://chromium-review.googlesource.com/c/chromium/src/+/669484/4/ios/chrome/browser/ui/ui_util.mm and https://bugs.chromium.org/p/gerrit/issues/detail?id=7248

I can't make any sense of this or these links.  If there is a bug with a specific language syntax please tell us which and if you could provide a jsfiddle reproducing the issue that'd be great:
Template you can use:
https://jsfiddle.net/ajoshguy/nagkqytv/

@yyyc514 really sorry for the late reply.
If you do:
#include "ios/chrome/browser/ui/ui_util.h"

#import <UIKit/UIKit.h>

#include "base/logging.h"
#import "ios/chrome/browser/ui/uikit_ui_util.h"
#include "ui/base/device_form_factor.h"
#include "ui/gfx/ios/uikit_util.h"

#if !defined(__has_feature) || !__has_feature(objc_arc)
#error "This file requires ARC support."
#endif

bool IsIPadIdiom() {
  return ui::GetDeviceFormFactor() == ui::DEVICE_FORM_FACTOR_TABLET;
}

const CGFloat kPortraitWidth[INTERFACE_IDIOM_COUNT] = {
    320,  // IPHONE_IDIOM
    768   // IPAD_IDIOM
};

bool IsHighResScreen() {
  return [[UIScreen mainScreen] scale] > 1.0;
}

bool IsPortrait() {
  UIInterfaceOrientation orient = GetInterfaceOrientation();
// If building with an SDK prior to iOS 8 don't worry about
// UIInterfaceOrientationUnknown because it wasn't defined.
#if !defined(__IPHONE_8_0) || __IPHONE_OS_VERSION_MAX_ALLOWED < __IPHONE_8_0
  return UIInterfaceOrientationIsPortrait(orient);
#else
  return UIInterfaceOrientationIsPortrait(orient) ||
         orient == UIInterfaceOrientationUnknown;
#endif  // SDK
}

bool IsLandscape() {
  return UIInterfaceOrientationIsLandscape(GetInterfaceOrientation());
}

For example, everything from "#if !defined(__IPHONE_8_0) || __IPHONE_OS_VERSION_MAX_ALLOWED < __IPHONE_8_0" and below is coloured in red (even IsLandscape() and any other function or what not after).

Are you specifying the language?  If so which language?

@yyyc514 It's objectivec.

Can you make a fiddle that shows the issue?  I gave you a template above?

@yyyc514 ah, sorry here's the fiddle: https://jsfiddle.net/8bvgu065/

Thanks so much.  It's the <.  We likely think it's the start of a string and then can't ever find the end of the string, so comment goes on forever.
The grammar needs to be fixed to look-ahead and make sure there is actually an end > and if not to not consider it a string.  Also figuring out what is and isn't allowed inside a path string might help also... ie #include <   some file> probably isn't allowed... so just figuring out what is valid might be one quick fix for this.

This probably has connections to the other C-like grammars also. (for someone wanting to work on a fix)

Looks like this is specific to objectivec. The objectivec syntax definition is separate from the cpp one, with a much simpler preprocessor definition. https://github.com/highlightjs/highlight.js/pull/2265 syncs this part up.


Readme typo

Bug Report
Readme Typo
Issue Description
2. Or you can install Bagisto from your console.
Execute these commands below, in order
1. composer create-project bagisto/bagisto

2. PHP artisan bagisto: install

As the code parts can be copy pasted it's better to separate the numbers and the original code,
Also in the second command in the front of "bagisto:" there a space which can make problems
I think this is better:
2. Or you can install Bagisto from your console.
Execute these commands below, in order:
composer create-project bagisto/bagisto

PHP artisan bagisto:install

Bagisto Version

[X] master branch
[ ] 1.3.3
[ ] 1.3.2
[ ] 1.3.1
[ ] 1.3.0

Hi @amiria703,
I am not getting what you are trying to say.

Okay, I checked thanks for reporting this, I will fix it as soon as possible.

@devansh-webkul  Sorry for my bad English,
The second part fixed but still the first part remains
Look here:

By clicking the button I mentioned you can easily copy the code and then paste it in the terminal
But, the first part of code ("1. " I mean) that is number doesn't let you use this functionality
And the numbers will also be copied


Develop FractionBounce

This issue will be used to discuss the delevopment of FractionBounce for Sugarizer.

I have started setting up the toolbar for the activity. It now contains the same basic elements as the original activity, including the settings palette contents.
There is still some work to do on the layout of the palette. Also the "choose ball" and "choose background" buttons respectively don't expand to a list of balls and backgrounds yet.
The buttons don't do anything at the moment.
These changes have been pushed to a new branch.

Currently taking a look at our available documentation and I'll list out our feature mvp

MVP:

A ball that translates downwards. Can be controlled by the left and right arrow keys.

Text denoting a fraction appears on top of the ball.

Three sections on the bottom of the screen that is divided from 0 to 1.
A scoreboard that keeps track of correct answers (at first just track correct and wrong answers)
A simple game state machine that controls the flow of the game and generates the fraction numbers. How it would look like:

Has the player clicked on the ball? Yes -> start the gameplay loop + generate a fraction on the ball + allow the ball to start translating + allow for the bounds check to detect if the ball hit the bottom of the screen
Has the ball reached the bottom of the screen? Yes -> check if the location of the screen is correct according to the fraction and add / remove points accordingly.

I want to note the corresponding activity description issue
https://github.com/ritjoe/sugarizer-lite/issues/13
as participants in each issue can earn credit working across the lines with their counterparts in the other, corresponding issue (developers seeking or offering feedback from/to describers and vice versa).

I thought it would not be trivial to render text in canvas but it seems fairly goddamn easy lol:
https://www.w3schools.com/graphics/canvas_text.asp

The main gameplay loop has been finished on my branch.
What I believe we are missing for the final deliverable are cosmetics, some sound effects and the display of the results. At the moment the only feedback the user gets for guessing right is a console log

Finished the cosmetics part.
The only part we left out was the tedious ones where you pick out how the ball looks and the background change.
It's very easy to do, but it's repetitive and doesn't affect the final gameplay experience

We'll now go through the process of merging into master


Failed to replace object: PersistentVolumeClaim when upgrading from helm v3.1.1 to v3.9.4

I want to upgrade from helm v3.1.1 to v3.9.4, but helm upgrade fails on a PVC with the new version. Target platform is Azure AKS.
client.go:261: [debug] error updating the resource "loki-claim": failed to replace object: PersistentVolumeClaim "loki-claim" is invalid: spec: Forbidden: spec is immutable after creation except resources.requests for bound claims
  core.PersistentVolumeClaimSpec{
      AccessModes:      {"ReadWriteOnce"},
      Selector:         nil,
      Resources:        {Requests: {s"storage": {i: {...}, s: "64G", Format: "DecimalSI"}}},
-     VolumeName:       "pvc-55f471bc-8587-43c9-b4f7-d558510a85e5",
+     VolumeName:       "",
      StorageClassName: &"default",
      VolumeMode:       &"Filesystem",
      ... // 2 identical fields
  }

The template looks like this:
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  labels:
    component: loki
    component: "loki"
    release: monitoring
  name: loki-claim
  namespace: management
spec:
  accessModes:
    - "ReadWriteOnce"
  resources:
    requests:
      storage: "64G"
  storageClassName: default

Output of helm version:
We are upgrading from v3.1.1
version.BuildInfo{Version:"v3.1.1", GitCommit:"afe70585407b420d0097d07b21c47dc511525ac8", GitTreeState:"clean", GoVersion:"go1.13.8"}
to v.3.9.4:
version.BuildInfo{Version:"v3.9.4", GitCommit:"dbc6d8e20fe1d58d50e6ed30f09a04a77e4c68db", GitTreeState:"clean", GoVersion:"go1.17.13"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
Azure AKS
I found similar issues but they were mostly related to the storageClassName. It seems this is only related to the VolumeName. Any ideas?

This seems to be an issue with your template. "Forbidden: spec is immutable after creation except resources.requests for bound claims" is a Kubernetes restriction. Your template is trying to replace the configured VolumeName with an empty string. Maybe delete that key from your template.

This seems to be an issue with your template. "Forbidden: spec is immutable after creation except resources.requests for bound claims" is a Kubernetes restriction. Your template is trying to replace the configured VolumeName with an empty string. Maybe delete that key from your template.

Thanks for the reply. But the key "volumeName" is not specified in my template.

Well then there's not enough information to support this question. Please provide a minimal repro.

While setting up a minimal repro (see https://github.com/cretzel/helm-11729) we found out that the issue is somehow related to the --force flag. We are deploying the chart like this
helm upgrade example example/ --install --force

This works with helm v3.1.1. But with helm v3.9.4 we get the error mentioned above. Without the --force flag it also works with v3.9.4.

Ah, yes. The force flag uses the cli-runtime to do a server-side replace. The api server ensures that the replacement doesn't break the resource and, replacing a pvc spec that has a volumeName with one without it would break the pvc.
Helm is working as intended, as is the api server.
I'm not sure you need --force. Have you tried --reset-values? I think this will get the behavior you're looking for.

btw... the reason it worked with 3.1 is it deleted the PVC and created a new one. I wonder how many times someone asked, "why do we have so many unbound PVs?"

Okay, thanks a lot @joejulian. We will try to remove the --force flag to fix this.

btw... the reason it worked with 3.1 is it deleted the PVC and created a new one. I wonder how many times someone asked, "why do we have so many unbound PVs?"

With 3.1 we don't see any PVCs recreated or any unbound PVs.

Hello! Tell me how is this problem solved at the moment? Is it possible to somehow pass the --force flag to the old names Volume Name and Storage Name so that it is recreated to exactly the same or the same.


Adding custom scrollbar in firefox

Describe the bug
A clear and concise description of what the bug is.
the scrollbar of chrome has been customized but it hasn't effected firefox cuz it uses different syntax for it
To Reproduce
Steps to reproduce the behavior:

Go to 'firefox'
Click on 'website link'
Scroll down to 'and you can see the default scrollbar in it'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.

Are you willing to contribute to this issue? [Yes/No]
Yes
Desktop (please complete the following information):

OS: [Windows 10]
Browser [Firefox]
Version [unknown]

Additional context
Add any other context about the problem here.
i'm a gssoc participate and if you could assign me i'll resolve the issue, there isn't enough resources for firefox, but i'll try my best

@Praful932 what you say about this?

@Praful932 what you say about this?

Sounds as a resonable issue

i know u asked me to do exactly as seen from chrome, but there are some limitation for Firefox. Then only syntax that it has to make it thin and change color. I'll be putting two images you tell you which ones better. @Praful932

@Alenjojo Alright the one with the same width in chrome and same color works for us

Thats what i'm trying to say, there isn't enough syntax in firefox to make in look exactly as of chrome. I can only make it thin and change color

Alright the first one works then


[Help]

Ban Appleas
I was banned because I was using an alt account while I wasn't using it.
I forgot to turn off warp (<IP_ADDRESS>) and i got banned because the double counter detects that thought I was an alt acc
my discord id :<PHONE_NUMBER>39703562

proof that you not using alt account then

proof that you not using alt account then

what do i have to prove?

proof that you not using alt account then

what do I have to do?

you can see it in my profile https://discord.com/users/819362961239703562, this is enough information if im not using alt acc. I have connection to my github acc and other third party connection

im not good at english, sorry if there is some mistake😄


LMTP Support

rfc: https://www.rfc-editor.org/rfc/rfc2033
Expand https://docs.kumomta.com/reference/kumo/make_queue_config/protocol/ to allow specifying that lmtp should be used.
Add an LHLO method similar to https://github.com/KumoCorp/kumomta/blob/2037371793df4b6b615af224e3ad22c6a622524a/crates/rfc5321/src/client.rs#L415
Teach https://github.com/KumoCorp/kumomta/blob/2037371793df4b6b615af224e3ad22c6a622524a/crates/kumod/src/smtp_dispatcher.rs#L337-L341 to use it when lmtp is enabled


release/14.10.0

fixes #1132
New Feature

Updated all nuget dependencies to their latest version except for ServiceFabric
Replaced Pivotal.Discovery.ClientCore with Steeltoe.Discovery.ClientCore as the Pivotal version is deprecated.
Changed the port number in a test from 8001 to 86 as 8001 is a port that is often in used on many dev machines.
Updated the docs to reflect the change to only support .netcoreapp3.1

@pedramrezaei thanks for the PR, please merge master into your Fork and the build process should now work.

@TomPallister thanks for fixing the issue. This PR is ready for your review. Thanks

@pedramrezaei sorry I have been away for a while and have not merged this. It is the holidays in the UK now so I will do it this weekend.
Thanks for your help with Ocelot.


Fix time_date sensor to update at predictable intervals

Description:
Change the time_date sensor to update when the time or date actually changes. Previous behavior asserts no control over when updates occur so they happen randomly/sporadically.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): No docs impact
Checklist:
If the code does not interact with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] Tests have been added to verify that the new code works.

Thanks! 🐬  🍺  🎉  🌮


Terragrunt fails authentication to AWS where as Terraform authenticates well

Hi Team,
We use okta cli to authenticate to AWS (local development and ci/cd we use ec2 assume role) and it generates an aws credentials file under ~/.aws
By enabling $env:AWS_PROFILE="dev", terraform is able to pick the appropriate access key and secret.
However Terragrunt fails with the following error:
error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: operation error STS: GetCallerIdentity, exceeded maximum number of attempts, 25, https response error StatusCode: 0, RequestID: , request send failed, Post "https://sts.us-east-1.amazonaws.com/": dial tcp <IP_ADDRESS>:443: connectex: An attempt was made to access a socket in a way forbidden by its access permissions.
Any help on this will be of great help

One thing i observed trying to debug this issue:
Probably the .terragrunt-cache folder is the issue because if i run explicit terraform inside the subfolders in .terragrunt-cache, even terraform throws error. However if i move the subfolder created with random id to the parent level terraform runs fine.


file descriptors not released by object Node

I became aware that Mininet is not closing all file descriptors when net.stop() is called. You can check this by using a tool like "lsof". The cause for this is that the object Node in mininet\node.py does not close the stdin and stdout pipe of its member shell.
In order to solve this problem, I modified Node's function cleanup as follows:
    def cleanup( self ):
        "Help python collect its garbage."
        # Intfs may end up in root NS
        for intfName in self.intfNames():
            if self.name in intfName:
                quietRun( 'ip link del ' + intfName )
        self.shell = None
       # close pipes of shell
        self.stdin.close()
        self.stdout.close()

I added just the last two lines which are closing the pipes.

i think this is implemented already, at least there are no open stdin/outs for me


Note changed HTML test program

Related: https://github.com/cockroachdb/docs/pull/2700

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/404963880906fef7efdf1756ccc25710172688fb/


HADOOP-18493: upgrade jackson-databind to <IP_ADDRESS>

Description of PR
CVE fixes in jackson-databind <IP_ADDRESS> - other jackson jars remain at 2.12.7 (no <IP_ADDRESS> releases for them)
How was this patch tested?
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

We're already on 2.12.7. The upgrade to <IP_ADDRESS> just adds the CVE fixes - doesn't change anything else.

Should be good then, can you have a PR for 3.3 branch as well, feels good enough to include in the upcoming 3.3.x release

@ayushtkn I created #5018

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m  5s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 53s

trunk passed

+1 :green_heart:
compile
23m 20s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
21m 39s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
mvnsite
20m 12s

trunk passed

+1 :green_heart:
javadoc
8m 16s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
7m 47s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
shadedclient
36m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 35s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
23m  6s

the patch passed

+1 :green_heart:
compile
22m 42s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
22m 42s

the patch passed

+1 :green_heart:
compile
20m 43s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 43s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
18m 54s

the patch passed

+1 :green_heart:
shellcheck
0m  1s

No new issues.

+1 :green_heart:
javadoc
8m  0s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
7m 25s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
shadedclient
37m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
800m 51s

root in the patch passed.

+1 :green_heart:
asflicense
2m 28s

The patch does not generate ASF License warnings.

1073m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5011/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5011

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux 2ad674a64f81 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f86a7cb991f46a6d78db8edac381fe8d1466e412

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5011/2/testReport/

Max. process+thread count
3695 (vs. ulimit of 5500)

modules
C: hadoop-project . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5011/2/console

versions
git=2.25.1 maven=3.6.3 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


lua failures on Travis CI

Three things have happened since my last build, in order:

Travis has accepted my PR for tolua: https://github.com/travis-ci/apt-package-whitelist/pull/3390
I tried to get around the "warning: unable to rmdir tolua: Directory not empty" message by removing that directory in s/build and s/cmake-init, which I hastily committed to develop
The next Travis build failed.

accidental report in the wrong project.


[Question] Is it possible to assert a UI5 control is invisible

Hi Experts,
I'm new to WDI5, I was trying to assert a UI5 control is not visible on UI, but it didn't work.
var input= browser.asControl({
            selector: {
                id: "myInput",
                viewName: "myView",
                visible: false
            }
        });

        expect(input.getVisible()).toBe(false);

It seems that I can only assert visible controls, but not invisible ones?
Thank you and best regards.

interesting observation. AFAIK, we don't have a testcase for you invisible elements yet.
is your input actually in the DOM, hidden by css? or not rendered yet? can you provide more code-context as to what control etc pp
please?

Thank you @vobu !
We just used the standard UI5 function myInput.setVisible(false) to hide it. This means:

UI5 adds a hidden DOM element for this control:

But the DOM element is not an input. UI5 does not just add an input DOM and hide it. A visible input DOM should look like:

Since WDI5's selector is very similar to OPA5's, I also tried visible: false, which means "I want to locate the control no matter if it's visible or not" in OPA5. But it didn't work.

The test scenario is, I want to assert the input is successfully hidden with myInput.setVisible(false). I know this should be done with OPA5 test. But I just want to see if WDI5 can achieve it.
Thank you!

thanks for providing the details!
I got curious and validated your use case
→ result: doesn't work, meaning wdi5 currently doesn't support the visible: false property of sap.ui.test.Opa5#waitFor 😒
But I've added this as a feature request 😸: #106
FWIW, you can still locate the DOM equivalent of the (unrendered) UI5 control by utilizing wdio's native feature (that wdi5 is built on):
UI5 control:
<!-- sap.m namespace -->
<Input id="visibleInputField"
value="bla"
visible="false" />

const id = 'visibleInputField';
// wdio-native selector
const wdioInput = browser.$(`[id$="${id}"]`); // ID ends with "visibleInputField"
expect(wdioInput.getProperty('id')).toContain('sap-ui-invisible');

Thank you @vobu ! It's really great to see improvements in wdi5!


Try to import tomllib for Python 3.11 or greater

Describe your changes
As of Python 3.11, the standard library includes a library for reading TOML files. This allows for new enough versions of Python to fall back on the stdlib version if toml is not installed.
Issue number
Closes #X
Checklist before requesting a review

[x] Performed a self-review of my code
[ ] Formatted my code with pkgmt format
[ ] Added tests (when necessary).
[ ] Added docstring documentation and update the changelog (when needed)

📚 Documentation preview 📚: https://jupysql--1004.org.readthedocs.build/en/1004/

please check the CI, you're missing an entry in the changelog


Unpickling error

Not a coder by trade, I had it working for a while with great results but now it won't run.
Getting this error every time I run Official Code:
UnpicklingError                           Traceback (most recent call last)
 in ()
13
14 torch.nn.Module.dump_patches = True
---> 15 model = create_model(opt)
16 model.eval()
17
3 frames
/content/SimSwap/models/models.py in create_model(opt)
16         model = UIModel()
17
---> 18     model.initialize(opt)
19     if opt.verbose:
20         print("model [%s] was created" % (model.name()))
/content/SimSwap/models/fs_model.py in initialize(self, opt)
62         # Id network
63         netArc_checkpoint = opt.Arc_path
---> 64         netArc_checkpoint = torch.load(netArc_checkpoint)
65         self.netArc = netArc_checkpoint['model'].module
66         self.netArc = self.netArc.to(device)
/usr/local/lib/python3.7/dist-packages/torch/serialization.py in load(f, map_location, pickle_module, **pickle_load_args)
606                     return torch.jit.load(opened_file)
607                 return _load(opened_zipfile, map_location, pickle_module, **pickle_load_args)
--> 608         return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
609
610
/usr/local/lib/python3.7/dist-packages/torch/serialization.py in _legacy_load(f, map_location, pickle_module, **pickle_load_args)
775             "functionality.")
776
--> 777     magic_number = pickle_module.load(f, **pickle_load_args)
778     if magic_number != MAGIC_NUMBER:
779         raise RuntimeError("Invalid magic number; corrupt file?")
UnpicklingError: invalid load key, '<'.

There must be an issue with the model file (google drive on cool-down, corrupt download, etc.). Same issue as in:

https://github.com/neuralchen/SimSwap/issues/35

I have similar error when I run Official Code every time, i can't find solution anywhere
/content/SimSwap
Traceback (most recent call last):
File "test_wholeimage_swapsingle.py", line 35, in
model = create_model(opt)
File "/content/SimSwap/models/models.py", line 18, in create_model
model.initialize(opt)
File "/content/SimSwap/models/fs_model.py", line 64, in initialize
netArc_checkpoint = torch.load(netArc_checkpoint)
File "/usr/local/lib/python3.7/dist-packages/torch/serialization.py", line 608, in load
return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
File "/usr/local/lib/python3.7/dist-packages/torch/serialization.py", line 777, in _legacy_load
magic_number = pickle_module.load(f, **pickle_load_args)
_pickle.UnpicklingError: invalid load key, '<'.

Fixed with new download locations.


feature request: enabling build for Windows

Is there a plan to enable a build for Windows?

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

I will try to take a look, but I cannot promise to do it very soon..

@pharshalp working on it here: https://github.com/conda-forge/cairocffi-feedstock/pull/11
would be happy to have your feedback/contributions since I'm not a cairo user myself... thanks!

Thanks! I will try it out and give feedback. I wish I could help in the build process but I do not believe I have the necessary expertise.

@pharshalp no worries, also testing helps a lot! Let me know if it works for you.

@pharshalp could you please give me a feedback if the current windows build works?

@carlodri v2.3 wasn't working properly. I will try the latest version tomorrow and post the error I was getting (if I still face the same issue as for v2.3).

@carlodri  I can confirm that v2.3.1 seems to be working fine!
v2.3 had some issues [it was raising URLError(exp) from the requests library)]
File "C:\Users\USERNAME\AppData\Local\Continuum\miniconda3\envs\svgutils\lib\urllib\request.py", line 1490, in open_local_file
    raise URLError(exp)
urllib.error.URLError: <urlopen error [WinError 2] The system cannot find the file specified: 'C:\\Users\\USERNAME\\MYPROJECTPATH\\%23glyph0-1'>

@pharshalp thanks for the feedback! Can you show me which commands/scripts you use for testing? It might be useful to put them in the package test suite. For instance, which is the command that fails in v2.3?
Thanks!

@carlodri  a bit busy right now... in a week or two I will turn my use-case into a test and post it here. Thanks!

@pharshalp great thanks!


Removing functions zero3 and one3.

Description
Removed zero3,one3,zero4,one4. Julia already provides the zero and ones functions that have equivalent functionality.
Simplified some of the Transform functions.
Fixes # (157)
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
wrote tests to verify that the new Transform functions generated the correct matrices and added these tests to our unit test set.
Test Configuration(s):

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

Codecov Report

Merging #159 (4675a4c) into main (e14c997) will decrease coverage by 0.78%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   50.71%   49.92%   -0.79%
==========================================
  Files          66       64       -2
  Lines        6470     6414      -56
==========================================
- Hits         3281     3202      -79
- Misses       3189     3212      +23

Impacted Files
Coverage Δ

src/Geometry/Transform.jl
40.71% <100.00%> (+2.68%)
:arrow_up:

src/Optical/Emitters/Emitters.jl
0.00% <0.00%> (-20.00%)
:arrow_down:

src/Geometry/Primitives/Qtype.jl
75.00% <0.00%> (-8.34%)
:arrow_down:

src/Optical/LensAssembly.jl
48.22% <0.00%> (-7.33%)
:arrow_down:

src/Optical/OpticalInterface.jl
63.23% <0.00%> (-4.30%)
:arrow_down:

src/Geometry/CSG/Intersection.jl
48.57% <0.00%> (-2.14%)
:arrow_down:

src/Geometry/Geometry.jl
0.00% <0.00%> (-1.86%)
:arrow_down:

src/Geometry/Primitives/Curves/BSpline.jl
66.15% <0.00%> (-0.52%)
:arrow_down:

src/Geometry/CSG/Interval.jl
83.20% <0.00%> (-0.37%)
:arrow_down:

src/Optical/OpticalSystem.jl
35.25% <0.00%> (-0.33%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14c997...4675a4c. Read the comment docs.


Mirror release commit count issue

Gitea version (or commit ref): Gitea version 1.14.0+dev-132-g8176ba657 built with GNU Make 4.3, go1.15.3 : bindata, sqlite, sqlite_unlock_notify
Git version: git version <IP_ADDRESS>.g5d2a92d10f
Operating system: Arch Linux
Database:

[x] SQLite

Build from source:

[x] Yes

Run with:

[x] systemd

Can you reproduce the bug at https://try.gitea.io:

[x] Yes --> https://try.gitea.io/nuone/gitea/releases

Description
I believe the commit count in the release area of a mirror is off.
For instance while the release page of a go-gitea/gitea mirror shows there have been 0 commits to master since v1.14.0-dev, the Gitea version string (1.14.0+dev-132-g8176ba657) says there in fact have been 132 commits to master.
I think the latter is correct.
Screenshots
my instance:

try.gitea.io

this still holds btw, even with great improvements to the UI such as #13428 ("Tags cleanup").
The count is still off.

Has anyone else noticed negative commit count? The tag is also on a different branch to master in my case.

Version: 1.15.0+dev-189-gcc7d118b1

Currently running Gitea Version: 1.15.0+dev-188-gf31443d6a I can't reproduce the original issue anymore, probably because the tags/releases pages there have undergone some changes and the "$X commits to $branch since this release" isn't even displayed for mirrors.
Note that initially the issue was only pertaining mirrored repositories.
I haven't come across your issue yet (looks like this is a regular repository, not a mirror), although that'd probably presume me reproducing the commit count etc. @conor-byrne
Just out of curiosity, what happens when you tag a commit that's 256 commits behind current HEAD? How will Gitea display that?
Smaller number (37<256<272) gets shown just fine

Close as outdated. Please open a new issue if this happen again.


feat: add way to make raw req and get url for BlockingClient

Also add method for getting from /tx/:txid endpoint.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

8 of 11 (72.73%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 84.345%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/blocking.rs
8
11
72.73%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
959

Relevant Lines:
1137

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

8 of 11 (72.73%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 84.345%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/blocking.rs
8
11
72.73%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
959

Relevant Lines:
1137

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

74 of 79 (93.67%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+3.0%) to 87.531%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/async.rs
12
14
85.71%

src/blocking.rs
4
7
57.14%

Totals

Change from base Build<PHONE_NUMBER>:
3.0%

Covered Lines:
1060

Relevant Lines:
1211

💛  - Coveralls

Oh ya CI is broken, same issue as on the BDK branch. I'll make a new PR to fix it.

Oh ya CI is broken, same issue as on the BDK branch. I'll make a new PR to fix it.

Thanks! I didn't notice that it was the same problem as https://github.com/bitcoindevkit/bdk/pull/1470


Fix tree param feature type.

Changed from int to uint32_t.

The issue was found when I was optimizing https://github.com/dmlc/xgboost/pull/7556 .


Updated MDH subrepo to v2.12.0

Also updated the icon to match the new one in MDH 2.12

You can download (to test) a built version of this extension (using my Safari Developer ID) from markdown-here.safariextz.zip
(Github won't let me upload a .safariextz file - even though it is a .zip file - so it's also zipped.)

Hi, @toonetown, I was using your distribution of markdown-here, and today it said it became invalid. Do you know why?

@ickc - Looks like my cert expired...I will get a new one built and uploaded. You may need to uninstall and reinstall. I will post back here when I have a new one. Sorry about that.

@toonetown, no problem! It's just that Apple is making this so difficult.

OK - I've built another one and am hosting it at http://www.toonetown.com/nathan/projects/markdown-here/markdown-here.safariextz
You will likely need to uninstall and reinstall...since I decided to actually change the identifier that I was building as, and I had to generate a new Safari Developer certificate.  Sorry for any inconvenience.  It's actually good to know that someone is using what I'm building 😄

It isn't working on Safari 12 anymore, which classified this extension as "unsafe". Any plan to update this for the latest Safari? Many thanks.

Nope - I no longer use it, and do not plan to update the build.  You might be able to build your own and load it as a developer extension.


Appstudio update test-custom-default-branch-mmxs

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-lqle-on-pull-request-
creating pipelinerun test-simple-build-lqle-on-pull-request- in namespace build-e2e-jzwn-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-mcmm-on-pull-request-
creating pipelinerun test-simple-build-mcmm-on-pull-request- in namespace build-e2e-jzwn-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-annotations-mijr-on-pull-request-
creating pipelinerun test-annotations-mijr-on-pull-request- in namespace build-e2e-jzwn-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-wadk-on-pull-request-
creating pipelinerun test-simple-build-wadk-on-pull-request- in namespace build-e2e-jzwn-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-imul-on-pull-request-
creating pipelinerun test-simple-build-imul-on-pull-request- in namespace build-e2e-jzwn-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request


Add license

Would be possible to get a license for this repo? 😊

sorry I totally missed this! https://github.com/tazz4843/whisper-rs/blob/master/LICENSE


ModuleNotFoundError: how to import Package mvIMPACT in python

ModuleNotFoundError: No module named 'mvIMPACT'

It’s not a python module. This is a stand alone software that you have to download separately. After that, use add_file()


Add WACZ info to the resource object

This adds to the resource object a wacz_dict akin to the pdf_dict. The pdf dict is used in creating a pdf download link on the aubrey ark about page. For items with WACZ files, it will allow a link to the manifestation containing the WACZ. Theoretically at some point we could have more than one WACZ for an item, though it should be in the same manifestation according to @vphill , and we mainly want to easily know at the object level if there is a WACZ and the manifestation number it is part of, so this may be suitable for the long run.
This is ready for review @somexpert. Let me know if you have any concerns about the way this was implemented @vphill .

The code looks good to me and the tests pass :thumbsup:


Add CATS, State Facility, and Title V models to ceqr_survey

Related to #575.
What:
Create air-quality intermediate tables aka "models" for:

cats permits
state facility permits
title V facility permits

All three models have the following resulting columns: variable, id, and geom (which is buffered geometry). The three tables have the same logic (except different distance buffer).
Commits:

Add sources of these datasets to dbt project, specifying required columns and tests. <--- 🚨 NEED FEEDBACK on validation tests here.

Create staging models of these datasets: select needed columns, add custom variable column, transform geometry to 2263 projection, and filter if needed (applicable to cats permits).

Create intermediate tables with buffered geometry in 2 steps:

spatially join with pluto to add tax lot geometry
create geom buffered column by applying buffer to tax lot geom column or to the original point geom column. The latter happens if original point wasn't mapped to a tax lot.

<--- 🚨 NEED FEEDBACK on the spatial queries.
Successful run:

here

it fails a test for dcm_arterial_highways source model which is outside of this PR.

Notes:

All 3 source datasets have same column "geom" and it's in hex-encoded WKB format (ex:<PHONE_NUMBER>E6100000BE1589096A7852C0657094BC3A534440). Casting to geometry sql data type converts the column to Point.

Sample cats permits with 400-feet buffer (including tax lots & point geoms):

@sf-dcp I fixed the highway bug in #606 if it'd be nice to see a full build on this branch