Generate consistent metadata view assembly names

Investigating diffs in assembly loads and JIT time is difficult between builds of VS because the proxy assembly that contains the metadata views gets a new name every launch.
Consistently generate the names - so that the as long as the same assemblies are involved, the same name is generated.
This is an identical change I've made to ServiceBroker RPC proxies.
~(I've not actually tested this - as I cannot get MEF building at the moment on my box)~

Codecov Report

Merging #333 (593fbb8) into main (296a635) will increase coverage by 21.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #333       +/-   ##
===========================================
+ Coverage   76.14%   97.22%   +21.07%
===========================================
  Files         110        2      -108
  Lines        7185       36     -7149
===========================================
- Hits         5471       35     -5436
+ Misses       1714        1     -1713

Impacted Files
Coverage Δ

...Composition/Configuration/MetadataViewGenerator.cs

...osoft.VisualStudio.Composition/ImportDefinition.cs

....Composition.VSMefx/Commands/ExpectedRejections.cs

...rtThatLazyImportsExportWithMetadataOfCustomType.cs

...Composition/ExportMetadataValueImportConstraint.cs

...VisualStudio.Composition/Reflection/PropertyRef.cs

...osoft.VisualStudio.Composition/DelegateServices.cs

...isualStudio.Composition/ExportDefinitionBinding.cs

...atLazyImportsExportWithTypeMetadataViaTMetadata.cs

...TestFiles/BasicScripts/MefCalculator/ExportTest.cs

... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 296a635...593fbb8. Read the comment docs.

@AArnott Can I have another review on this?

@AArnott  thanks!

This should show up in VS day on Thursday (since it missed the cut-off for tonight's build and insertion).


fix: effective-hpa-with-prometheus-adapter docs error

What type of PR is this?
fix: effective-hpa-with-prometheus-adapter docs error

/LGTM


Add "home" tab

As discussed in #503, we could make a "home" tab which will initially be blank, so that when we close a channel that we are currently on, we would go back to the "home" tab so we don't mark any other channel as read. This is how slack does it, fwiw.
This also has a future advantage of having some other possibilities for viewing things (highlights, stats, etc) further down the line, but initially it should probably just be blank.

Similar to #650

Yeah, it's not exactly the same, but that could definitely tie in. I assume
that they are influenced by slack having one where its just basically a pm
to yourself, but the idea is that it wouldn't go over irc, I guess?
On Mon, 12 Dec 2016, 17:08 Max Leiter<EMAIL_ADDRESS>wrote:

Similar to #650 https://github.com/thelounge/lounge/issues/650
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thelounge/lounge/issues/791#issuecomment-266489000,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACD_4dqC31Iv4e9iQBQwOY9liOue7_AHks5rHX9_gaJpZM4LKgNZ
.

This could be a server tab, which most IRC clients already have.

This could be a server tab, which most IRC clients already have.

@teamcoltra We already have a server tab, which is slightly different from this. The server tab is for server notices, motd, etc.


Updated readme and dependencies.

Description
Issue when setting up conda in docs environment solved, dependencies in docs environment were updated and added a short description of the project to readme file.
Status

[ ] Ready to go

Codecov Report

Merging #64 (2c6041b) into main (ed6e97e) will not change coverage.
The diff coverage is n/a.


Correctly locate dependencies with media restrictions.

Correctly match dependencies that have media restrictions in CSS/Less/Scss files.
Refs #23

Current coverage is 84.94%

Merging #24 into master will increase coverage by +0.08% as of 522b76f

@@            master     #24   diff @@
======================================
  Files           32      32
  Stmts          945     943     -2
  Branches         0       0
  Methods        158     158
======================================
- Hit            802     801     -1
  Partial          0       0
+ Missed         143     142     -1

Review entire Coverage Diff as of 522b76f

Powered by Codecov. Updated on successful CI builds.


[WIP] preview3 update

netcorecli-fsc implemented in F#
converted projects from json to fsproj
posh build script -> to FAKE

when I clone my fork onto my machine and build from scratch everything runs without a hitch, but I haven't been able to get the CI configurations setup so it works on travis and appveyor yet.

@enricosada Have you had a chance to review this?

I'm not clear on what you want to do with this PR at this point -

should we scuttle it?
should I make a new PR with just the updates to the fsproj files or should I keep working on this one?
if I make a new PR should I switch the xproj to project.json?
should I update everything to use preview4 since it's been released?

should we scuttle it?
should I make a new PR with just the updates to the fsproj files or should I keep working on this one?
you can update this one, np

if I make a new PR should I switch the xproj to project.json?
I think we can continue to use preview2 project.json, we can move to preview3 (now is released) with another pr later.

should I update everything to use preview4 since it's been released?
we should work on preview3 for a bit, because is stable and similar to preview4 for some weeks.
Using preview4 directly mean be more unstable.

closing because old.
thx anyway @cloudRoutine about that


Retrieve data

i have the below models
public partial class TreatmentDescriptions
{
       public int TreatmentDescriptionId { get; set; }
       public int? DoctorId { get; set; }
       public Doctors Doctor { get; set; }
}
public partial class Doctors
    {
        public Doctors()
        {
            TreatmentDescriptions = new HashSet<TreatmentDescriptions>();
        }

        public int DoctorId { get; set; }
        public ICollection<TreatmentDescriptions> TreatmentDescriptions { get; set; }
    }

when i use the below lambda expression

DentistDbContext.TreatmentDescriptions
 .Include(td=> td.Doctor)
 .Where(td => td.TreatmentId == treatmentId)
 .ToList();

i'm getting the correct data as below however each doctor has retrieved all its treatment descriptions  as below
[
    {
        "treatmentDescriptionId": 1,
        "commonTreatmentId": 1,
        "treatmentDescriptionPrice": 200,
        "toothId": 2,
        "treatmentId": 87,
        "treatmentDescriptionDone": false,
        "doctorId": 1,
        "companyId": null,
        "commonTreatment": null,
        "company": null,
        "doctor": {
            "doctorId": 1,
            "doctorName": "Dr. Ghassan",
            "doctorEmail"<EMAIL_ADDRESS>            "appointments": [],
            "dailyTreatments": [],
            "doctorsPayment": [],
            "paymentShares": [],
            "treatmentDescriptions": [
                {
                    "treatmentDescriptionId": 19,
                    "commonTreatmentId": 1,
                    "treatmentDescriptionPrice": 200,
                    "toothId": 2,
                    "treatmentId": 87,
                    "treatmentDescriptionDone": false,
                    "doctorId": 1,
                    "companyId": null,
                    "commonTreatment": null,
                    "company": null,
                    "tooth": null,
                    "treatment": null
                },
                {
                    "treatmentDescriptionId": 20,
                    "commonTreatmentId": 1,
                    "treatmentDescriptionPrice": 200,
                    "toothId": 2,
                    "treatmentId": 87,
                    "treatmentDescriptionDone": false,
                    "doctorId": 1,
                    "companyId": null,
                    "commonTreatment": null,
                    "company": null,
                    "tooth": null,
                    "treatment": null
                }
            ]
        },
        "tooth": null,
        "treatment": null
    },
    {
        "treatmentDescriptionId": 19,
        "commonTreatmentId": 1,
        "treatmentDescriptionPrice": 200,
        "toothId": 2,
        "treatmentId": 87,
        "treatmentDescriptionDone": false,
        "doctorId": 1,
        "companyId": null,
        "commonTreatment": null,
        "company": null,
        "doctor": {
            "doctorId": 1,
            "doctorName": "Dr. Ghassan",
            "doctorEmail"<EMAIL_ADDRESS>            "appointments": [],
            "dailyTreatments": [],
            "doctorsPayment": [],
            "paymentShares": [],
            "treatmentDescriptions": [
                {
                    "treatmentDescriptionId": 1,
                    "commonTreatmentId": 1,
                    "treatmentDescriptionPrice": 200,
                    "toothId": 2,
                    "treatmentId": 87,
                    "treatmentDescriptionDone": false,
                    "doctorId": 1,
                    "companyId": null,
                    "commonTreatment": null,
                    "company": null,
                    "tooth": null,
                    "treatment": null
                },
                {
                    "treatmentDescriptionId": 20,
                    "commonTreatmentId": 1,
                    "treatmentDescriptionPrice": 200,
                    "toothId": 2,
                    "treatmentId": 87,
                    "treatmentDescriptionDone": false,
                    "doctorId": 1,
                    "companyId": null,
                    "commonTreatment": null,
                    "company": null,
                    "tooth": null,
                    "treatment": null
                }
            ]
        },
        "tooth": null,
        "treatment": null
    },
    {
        "treatmentDescriptionId": 20,
        "commonTreatmentId": 1,
        "treatmentDescriptionPrice": 200,
        "toothId": 2,
        "treatmentId": 87,
        "treatmentDescriptionDone": false,
        "doctorId": 1,
        "companyId": null,
        "commonTreatment": null,
        "company": null,
        "doctor": {
            "doctorId": 1,
            "doctorName": "Dr. Ghassan",
            "doctorEmail"<EMAIL_ADDRESS>            "appointments": [],
            "dailyTreatments": [],
            "doctorsPayment": [],
            "paymentShares": [],
            "treatmentDescriptions": [
                {
                    "treatmentDescriptionId": 1,
                    "commonTreatmentId": 1,
                    "treatmentDescriptionPrice": 200,
                    "toothId": 2,
                    "treatmentId": 87,
                    "treatmentDescriptionDone": false,
                    "doctorId": 1,
                    "companyId": null,
                    "commonTreatment": null,
                    "company": null,
                    "tooth": null,
                    "treatment": null
                },
                {
                    "treatmentDescriptionId": 19,
                    "commonTreatmentId": 1,
                    "treatmentDescriptionPrice": 200,
                    "toothId": 2,
                    "treatmentId": 87,
                    "treatmentDescriptionDone": false,
                    "doctorId": 1,
                    "companyId": null,
                    "commonTreatment": null,
                    "company": null,
                    "tooth": null,
                    "treatment": null
                }
            ]
        },
        "tooth": null,
        "treatment": null
    }
]

note that i didn't add all the model properties for you above

Since you are querying TreatmentDescriptions while loading related Doctor data, EF will fix up relationship both sides. i.e. for each TreatmentDescriptions where Doctor is assigned, the Doctor.TreatmentDescriptions collection will contain the TreatmentDescriptions object. EF is not retrieving any additional data.

Is there a way to fix it to retrieve just the treatmentdescription with doctors only without retrieving the treatment description in doctors entities

You mean to set themas null no ?

@mutasemhidmi The entity types in the posted code have one relationship between them, represented in the database by the DoctorId foreign key. This foreign key is backing two navigation properties--one to navigate the relationship from Doctor to TreatmentDescriptions and one to represent the inverse from TreatmentDescriptions to Doctor. Note that these two navigations properties do not represent different relationships. This means, that if a TreatmentDescription has a related Doctor in the database (i.e. it's FK is set) then both the TreatmentDescriptions navigation will contain that Doctor and the Doctor will have it's TreatmentDescription navigation set to point to the TreatmentDescription.


invalid api key

Hi, with request
https://api.deflex.fi/api/fetchQuote?chain=mainnet&algodUri=https%3A%2F%2Fmainnet-api.algonode.cloud&algodToken=&algodPort=443&fromASAID=0&toASAID=452399768&atomicOnly=true&amount=100000000&type=fixed-input&disabledProtocols=&referrerAddress=AWALLETCPHQPJGCZ6AHLIFPHWBHUEHQ7VBYJVVGQRRY4MEIGWUBKCQYP4Y

i am getting now response invalid api key
has something changed? it was working before

Hey - we no longer accept requests anonymously, since some people were hammering the server and incurring a ton of expenses. Please tell me about your use case and how many requests you'll be sending. If it is a trading bot, we won't be able to help you unless you pay a monthly fee.

I have implemented it it in AWallet - https://www.a-wallet.net/
https://forum.algorand.org/t/algorand-wallet-open-source/3497
https://github.com/scholtz/wallet/blob/9aeb06a3f1b1924c8b807b0725ef8402032a4443/src/pages/Swap.vue#L356
https://www.reddit.com/r/AlgorandOfficial/comments/16zp1yh/ama_awallet_open_source_community_wallet/

Hi Philip,
I am facing same issue. Can you help me to fix this issue? Thank you

Hey - we no longer accept requests anonymously, since some people were hammering the server and incurring a ton of expenses. Please tell me about your use case and how many requests you'll be sending. If it is a trading bot, we won't be able to help you unless you pay a monthly fee.

Hi, I used the api_key received from you. but I faced the error when calling this function.
deflex.DeflexOrderRouterClient.fetchTestnetClient(
uri,
'',
'' /* sender.addr */,
undefined, // referrerAddress
undefined, // feeBps
ALGOD_API_KEY
);

can you help me to fix this issue?


🔨 Clean up e2e testing framework

What do these changes do?
Clean up e2e testing framework
The corresponding MR on the e2e portal repo is here: https://git.speag.com/oSparc/e2e-portal-testing/-/merge_requests/19

Related issue/s

https://github.com/ITISFoundation/osparc-simcore-clients/issues/56

How to test

looking good. please check my comments. Also how do you use pytest-html output? does it render nicely then in Github somehow?

Displaying it in Gitlab is a great point. I just made a small change to achieve this, so now there are two types of test reports generated. The one using pytest-html which is just an html file located in the artifacts. So to see this one has to check the log to see which (client, server) pair failed, located that folder in the artifacts and open the file. This file is nice because it supports filtering out passed and skipped tests. Second I now also generate junit reports which are rendered directly in gitlab. So going to the pipeline one can see these under the "Test" section.

tests are getting more complex than the client :-)

I regret that this has become a little over complicated. Perhaps I should have done every single test run in a different gitlab job. That would have resulted in less code here... Así es la vida


Lock Output Canvas in place

A user setting to avoid moving and scaling the Output canvas

A better solution has been already pushed


window._buildUrl is not a function

Summary of problem or feature request
When implementing the laravel-datatables-export button I'm presented with an error when clicking on the export button that states window._buildUrl is not a function. I have all the javascripts implemented along with the https://github.com/yajra/laravel-datatables-buttons/blob/master/src/resources/assets/buttons.server-side.js being in the vendor folder.
Code snippet of problem
Following along with the Usage guide. Nothing really complex as the buttons.server-side.js contains the _buildUrl function but its not scoped to window.
System details

Chrome Version 105.0.5195.125 (Official Build) (x86_64)
Operating System MacOS 12.6
PHP Version 8.1.1
Laravel Version 9.31.0
Laravel-DataTables Version 10.1.3
Laravel-DataTables-Export Version 0.14.0

Thank you for reporting, I was using https://github.com/yajra/laravel-datatables-assets/blob/master/js/buttons/helper.js and overlook this. I will review the implementation or maybe update the docs when I got the chance.

Thank you I'll try that.

@github-actions please keep open

Hi @yajra I was working with @uchajk and he implemented the helper and it seems to work now. I think maybe including the buildurl function in the package maybe helpful.


Remove SB parent from master

Although I have updated all boosters, I am only opening a PR for this one to start with.

There seems to be an error with parent  pom. I will fix it shortly

Some fixes have been made, should be in better shape now

retest this please

@Ladicek Could you please take a look and see if the Openshift cluster that runs the tests is OK?
The error messages from the tests are not making much sense so I wonder if there is something wrong

@gytis I addressed your comments

retest this please

retest this please

We're missing several things: developers section (though I'm not sure how important that is, up to the team), java.version and related maven.compiler properties.

I didn't add the developers section because I thought that it's not really relevant in this case.
As for the versions, I thought that the things defined in the booster-parent would be enough:
https://github.com/openshiftio/booster-parent/blob/210dedc37f87ffb99aa105254c5e2382d62e3176/pom.xml#L33
https://github.com/openshiftio/booster-parent/blob/210dedc37f87ffb99aa105254c5e2382d62e3176/pom.xml#L39

Ah yes, missed the java.version from the parent… so we're all good there.

I don't think we should add developers section to the boosters as they are used as a basis to generate a client application. Client for whom this application is generated should be in developers section.

/retest this please


Statistics aggregation

It may be interesting to have a main dashboard with statistics from all repositories. Contributors overall activities, projects stats, etc.

I agree, the issue is that crunching commits is a quite heavy operation (especially on large repositories). With a good caching mechanic and perhaps synchronous parsing of repositories it could be achieved.

Yes. A possible solution could be to use git hooks to trigger statistics update. But it would be quite intrusive.


replace git.io links with their actual URLs

All links on git.io will stop redirecting after April 29, 2022: https://github.blog/changelog/2022-04-25-git-io-deprecation/
Replace git.io links with their actual URL.

Thanks for catching this!

@joshspicer if this change sounds alright with you, I'll merge as the links stop redirecting after today.

@bamurtaugh GitHub describes in a way that only git.io links in print documentation and research papers will retain services. Even if they have changed their mind, it is not guaranteed that the git.io will not stop providing service in the future.
IMHO, it is better to use the original URL.

Looks good to me! Thanks @eitsupi / @SukkaW !


Fix sensiolabs insights errors to get platinum medal

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Tests pass?
yes

Fixed tickets
/

License
MIT

Doc PR
/

Thanks for your work :)


ENYO-5352: Change Divider's marqueeOn default value to render

Issue Resolved / Feature Added
Following up on #1271, change Divider's marqueeOn default value to render
Enact-DCO-1.0-Signed-off-by: Stephen Choi<EMAIL_ADDRESS>

Thanks for pointing it out. Yeah, it's weird that casing isn't warned. I made a change so that the decorator sets the default props by returning a kind. It's an extra layer so there is a performance concern with the change. I'm okay to revert and change MarqueeDecorator and Uppercase HOC applied to the base component, but it seemed nice to me. Let me know what you think.

:mindblown:

I like it! Not sure what the proper way to document this though. Any thoughts?

I think the simplest solution right now would be to document them as properties on Divider even though they're really on DividerDecorator. Check out DayPicker for a couple examples of documenting props on the wrapped default export for an illustration on what I mean.

:+1: Added @memberof to the "floating" prop docs to connect them to the class and adopted the smartSelect knob instead of the default storybook knob.

@ryanjduffy fyi, we will be using select from enact-knob #1693
https://github.com/enactjs/enact/pull/1693/files#diff-c6074a69c68e116026a86f248de1d709R6


luajit: do not override INSTALL_INC

Overriding INSTALL_INC caused luajit to be installed directly into the
include/ directory instead of include/luajit-${version} as normally
expected. Previously the path indicated in the pkg-config file also did
not match the actual header file location.
Since luajit is expected to work as a drop-in replacement for standard lua the include files in include/ are retained via symlinks to the sub-directory.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
This changes tries to recompile everything that could possible be bundled with luajit. Many of those packages already failed before this change so I am not able to guarantee that everything does still compile/execute.
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

This changes tries to recompile everything that could possible be bundled with luajit. Many of those packages already failed before this change so I am not able to guarantee that everything does still compile/execute.

The lua packages that do not currently work with luajit are luaexpat, luazip, cjson and mpack. All the rest work last time I checked.

I only saw a large list of rebuilds and cjson did fail (with and without my change) so I assumed there will be others too. It probably is just the list of packages you mentioned.

PSA I'll test this with the rest of the luajit packages hopefully either tomorrow or the day after if no one else does. :+1:

@vyp any news? :-)

@andir Sorry forgot to update, time escaped me actually, been really busy. I don't have time to test this until Sunday unfortunately. Of course, if anyone else wants to test before that, they're free to go ahead and not be dependent on me! (I just thought I could help.)

@thoughtpolice @smironov @vcunat any of you guys (since you are the current maintainers) able to verify this?

You forgot to symlink lua.hpp and this broke solarus (at least). Fixed in b00c65103d84ee5218290b14b0b0757f92c23891.


Update GetGlobalContext-ClientGlobalContext.js.aspx.md

Removing reference to deprecation of the aspx page support.

Addressed vis internal repo. Closing it without merging


ref: Remove action-release and try auto-associate-commits-to-release feature

In https://github.com/getsentry/sentry/pull/36491 a new feature was landed to associate commits to releases via the SDK.
I've also set up code mappings because I believe this is needed.

We're not going to change it atm.


Pruning improvements

Note: best if you review each commit individually.

/test istio-operator_gen-check


invalid JSON

for some reason it says that.
here is the code
[
{
"nickname": "GhostIRC",
"server": "irc.libera.chat",
"discordToken": "XXX",
"channelMapping": {
"#irc-general": "#ircchannelname"
}
},
]
I used discord-irc —config config.json .
even if I make a new discord token, still the same error. Even with discord.js

Any help?

I fixed the issue never mind!


No network connection on Hi3516CV100

I have flashed my IPG5020A-H-V1.0 board from stock firmware to OpenIPC master+e4d73334, 2022-08-30 but can't access the network after flashing.
The network works in U-BOOT, but not when I have booted in to Linux.
I looked at issue #156 and have tried this without success:

Boot to U-BOOT, ping and run run bootcmd
Run devmem 120100ec 32 9f

The Ethernet transceiver chip is an IP101GR.
The chip marking is HI3516 CRBCV100 CD6191716 1716-CHINA
Here are some logs:
2022-08-30_dmsg.log
2022-08-30_serial_boot_log.log
2022-08-30_proc_cpuinfo.txt

There is some chance to try the "extras" options for your board to write into the U-Boot ENV.

Thank you for the suggestion!
I got it working with these extras that I found here:
setenv extras hieth.mdioifu=0 hieth.mdioifd=0 hieth.phyaddru=1 hieth.phyaddrd=2


Add a feature to config mods via text files

Moved to https://github.com/javisar/ONI-Modloader/issues/15


Refactor HAL response of dynamic workflowgroup links to simplify client code (UI; need is TBD)

Note from release plan -- TBD. Unclear of impact on UI code at this time.

Fixed by #829


test(ticdc): update the default value of ttl_job_interval

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tidb/pull/57758
What is changed and how it works?
When TiDB updates ttl_job_interval, we have to follow up.
Check List
Tests

Integration test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
 `None`

/retest

/retest


pyodbc 4.0.{29,30} unavailable for Mac OS X

When installing pyodbc into a fresh virtualenv, pip downloads v4.0.28 - wheels for later versions are not available

Thanks.  I built them and forgot to upload.  They are there now.  Actually only 4.0.30 is there now.  Version 29 was not officially released.

Just FYI @mkleehammer , I don't know if it takes a while for new files to appear at https://pypi.org/project/pyodbc/#files, but I'm looking at that page now, and I don't see any Mac OSX files there.

Ah, I see the Mac OSX files have been published to PyPi, just under a different version number (4.0.30b1 as opposed to 4.0.30):
https://pypi.org/project/pyodbc/4.0.30b1/#files


add image as ref and replace validate with terratest job

Tracker story
Changes proposed in this pull request:

Alters CircleCI config to run terratest job

Related PR (status: merged):
https://github.com/trussworks/legendary-waddle-dev/pull/37

welp

This looks like terraform failed to delete in the right order, because maybe the test is flaky.

This looks like terraform failed to delete in the right order, because maybe the test is flaky.

so it's no cardinal sin to just re-run in this case?


Support for bookmarks

As seen here:
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/bookmarks/create
Thank you!

Browser extension functionality is not currently tracked on caniuse. You may want to add your vote to #2271 though.


Integration with log analytics systems

Describe the improvement
Integration with log analytics systems

ELK
Splunk
Prometheus

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Bring back synced_checksum reset for nonpublished sites after a url change

… url is changed
Pre-Flight checklist

[ ] Screenshots and design review for any changes that affect layout or styling
[ ] Migrations

[ ] Migration is backwards-compatible with current production code

[ ] Testing

[ ] Code is tested
[ ] Changes have been manually tested

[ ] Settings

[ ] New settings are documented and present in app.json
[ ] New settings have reasonable development defaults, if applicable
[ ] Opened issue for DevOps regarding necessary configuration changes to deployed environments

What are the relevant tickets?
(Required)
What's this PR do?
(Required)
How should this be manually tested?
(Required)
Where should the reviewer start?
(Optional)
Any background context you want to provide?
(Optional)
Screenshots (if appropriate)
(Optional)
What GIF best describes this PR or how it makes you feel?
(Optional)

Codecov Report

Merging #1496 (5d0a7cb) into master (68d0765) will increase coverage by 5.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
+ Coverage   89.29%   94.46%   +5.17%
==========================================
  Files         235      113     -122
  Lines        9972     3379    -6593
  Branches     1876      807    -1069
==========================================
- Hits         8904     3192    -5712
+ Misses        932      179     -753
+ Partials      136        8     -128

Impacted Files
Coverage Δ

content_sync/factories.py

websites/serializers.py

websites/messages.py

gdrive_sync/__init__.py

...agement/commands/markdown_cleaning/cleanup_rule.py

repl.py

main/middleware.py

...ement/commands/markdown_cleaning/rules/__init__.py

main/admin.py

websites/constants.py

... and 113 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


the struct error in chinese readme

I found an error in the structural field in Chinese readme

I also have a question about whether clover is thread-safe. I have a requirement for multiple goroutine to store data.

Yes, it is thread-safe

ok,thanks


Test using IBInspectable / IBDesignable to design Loaders inside Stor…

Don't merge this branch in you repo
It's just an example of using IBInspectable / IBDesignable. I think it will be superb to have the option of designing Loaders just right into IB.
Have a look at changing_loaders_in_storyboard.png

See https://github.com/poolqf/PQFCustomLoaders/releases/tag/1.1.0 😄
THANKS Diego!


feat: support for using docker for Octez

Context
This PR adds support for using Docker to run the octez-client, octez-node and octez-smart-rollup-node.
Manually Testing
With:
{
  "octez_setup": {
    "Docker": "v20.0-rc1"
  }
 ...
}

Run
jstz sandbox start

This mostly looks good to me, but it would be good to add a more detailed description of changes so that it is a bit easier to review and polish it a bit(removing comments). I need to test it locally before approving.


⚠ ClamAV has degraded performance

In 9c435dd, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 149 ms

Resolved: ClamAV performance has improved in 7a71622.


Display latest posts on homepage instead of on a diff page

...maybe 6 latest posts?

Yeah but let's not worry now
On Thu, Jun 18, 2020, 1:26 PM Sophy<EMAIL_ADDRESS>wrote:

...maybe 6 latest posts?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sparcopen/infrastructure/issues/75, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABFZMZ3LAV4Q3UEEF4H5CJ3RXIBW3ANCNFSM4OBRCESA
.

closed in #54


Restrained utest dependency to test scope

The utest dependency doesn't get pulled when out of tests, this way.

Yay thanks


Not compatible with phpunit 9

www-data@9609a44bb026:/var/www/html$ composer require --dev zalas/phpunit-injector
Using version ^1.4 for zalas/phpunit-injector
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.
Problem 1
- zalas/phpunit-injector v1.4.1 requires phpunit/phpunit ^8.0 -> satisfiable by phpunit/phpunit[8.0.0, 8.0.1, 8.0.2, 8.0.3, 8.0.4, 8.0.5, 8.0.6, 8.1.0, 8.1.1, 8.1.2, 8.1.3, 8.1.4, 8.1.5, 8.1.6, 8.2.0, 8.2.1, 8.2.2, 8.2.3, 8.2.4, 8.2.5, 8.3.0, 8.3.1, 8.3.2, 8.3.3, 8.3.4, 8.3.5, 8.4.0, 8.4.1, 8.4.2, 8.4.3, 8.5.0, 8.5.1, 8.5.10, 8.5.11, 8.5.12, 8.5.2, 8.5.3, 8.5.4, 8.5.5, 8.5.6, 8.5.7, 8.5.8, 8.5.9, 8.5.x-dev] but these conflict with your requirements or minimum-stability.
- zalas/phpunit-injector v1.4.0 requires phpunit/phpunit ^8.0 -> satisfiable by phpunit/phpunit[8.0.0, 8.0.1, 8.0.2, 8.0.3, 8.0.4, 8.0.5, 8.0.6, 8.1.0, 8.1.1, 8.1.2, 8.1.3, 8.1.4, 8.1.5, 8.1.6, 8.2.0, 8.2.1, 8.2.2, 8.2.3, 8.2.4, 8.2.5, 8.3.0, 8.3.1, 8.3.2, 8.3.3, 8.3.4, 8.3.5, 8.4.0, 8.4.1, 8.4.2, 8.4.3, 8.5.0, 8.5.1, 8.5.10, 8.5.11, 8.5.12, 8.5.2, 8.5.3, 8.5.4, 8.5.5, 8.5.6, 8.5.7, 8.5.8, 8.5.9, 8.5.x-dev] but these conflict with your requirements or minimum-stability.
- Conclusion: remove phpdocumentor/reflection-common 2.2.0
- Conclusion: don't install phpdocumentor/reflection-common 2.2.0
- phpdocumentor/reflection-docblock 4.0.1 requires phpdocumentor/reflection-common ^1.0@dev -> satisfiable by phpdocumentor/reflection-common[1.0, 1.0.1].
- phpdocumentor/reflection-docblock 4.1.0 requires phpdocumentor/reflection-common ^1.0@dev -> satisfiable by phpdocumentor/reflection-common[1.0, 1.0.1].
- phpdocumentor/reflection-docblock 4.1.1 requires phpdocumentor/reflection-common ^1.0@dev -> satisfiable by phpdocumentor/reflection-common[1.0, 1.0.1].
- phpdocumentor/reflection-docblock 4.2.0 requires phpdocumentor/reflection-common ^1.0.0 -> satisfiable by phpdocumentor/reflection-common[1.0, 1.0.1].
- phpdocumentor/reflection-docblock 4.3.0 requires phpdocumentor/reflection-common ^1.0.0 -> satisfiable by phpdocumentor/reflection-common[1.0, 1.0.1].
- phpdocumentor/reflection-docblock 4.3.1 requires phpdocumentor/reflection-common ^1.0.0 -> satisfiable by phpdocumentor/reflection-common[1.0, 1.0.1].
- Can only install one of: phpdocumentor/reflection-common[1.0, 2.2.0].
- Can only install one of: phpdocumentor/reflection-common[1.0.1, 2.2.0].
- Installation request for phpdocumentor/reflection-common (locked at 2.2.0) -> satisfiable by phpdocumentor/reflection-common[2.2.0].
- Installation request for zalas/phpunit-injector ^1.4 -> satisfiable by zalas/phpunit-injector[v1.4.0, v1.4.1, v1.4.2].
- Conclusion: don't install phpdocumentor/reflection-docblock 5.2.2|install phpdocumentor/reflection-docblock 4.0.1|install phpdocumentor/reflection-docblock 4.1.0|install phpdocumentor/reflection-docblock 4.1.1|install phpdocumentor/reflection-docblock 4.2.0|install phpdocumentor/reflection-docblock 4.3.0|install phpdocumentor/reflection-docblock 4.3.1
- Conclusion: remove phpdocumentor/reflection-docblock 5.2.2|install phpdocumentor/reflection-docblock 4.0.1|install phpdocumentor/reflection-docblock 4.1.0|install phpdocumentor/reflection-docblock 4.1.1|install phpdocumentor/reflection-docblock 4.2.0|install phpdocumentor/reflection-docblock 4.3.0|install phpdocumentor/reflection-docblock 4.3.1
- zalas/phpunit-injector v1.4.2 requires zalas/injector ^1.3 -> satisfiable by zalas/injector[v1.3.0, v1.3.1].
- zalas/injector v1.3.1 requires phpdocumentor/reflection-docblock ^4.0.1 -> satisfiable by phpdocumentor/reflection-docblock[4.0.1, 4.1.0, 4.1.1, 4.2.0, 4.3.0, 4.3.1, 4.3.2, 4.3.3, 4.3.4].
- zalas/injector v1.3.0 requires phpdocumentor/reflection-docblock ^4.0.1 -> satisfiable by phpdocumentor/reflection-docblock[4.0.1, 4.1.0, 4.1.1, 4.2.0, 4.3.0, 4.3.1, 4.3.2, 4.3.3, 4.3.4].
- Can only install one of: phpdocumentor/reflection-docblock[4.3.2, 5.2.2].
- Can only install one of: phpdocumentor/reflection-docblock[4.3.3, 5.2.2].
- Can only install one of: phpdocumentor/reflection-docblock[4.3.4, 5.2.2].
- Installation request for phpdocumentor/reflection-docblock (locked at 5.2.2) -> satisfiable by phpdocumentor/reflection-docblock[5.2.2].
Installation failed, reverting ./composer.json to its original content.

PHP7.3, after update to PHP7.4 working well.


fix(List): focus behavior

TODO

[x] update CHANGELOG

This PR aims to address List focus issues, as well as simplify generic logic used for collection's focus behavior. The problems that were mentioned in the following post (https://github.com/stardust-ui/react/issues/370#issuecomment-432874011) are addressed, specifically:

Anytime the list updates it's going to try to focus an item. - well, not anymore 👍
findDOMNode should be avoided at all costs. - avoided 👍
The List Item has an instance member this.focusableItem() which is created by passing this to a constructor.  Passing instances around is code smell - this smell has been eliminated, only safe immutable data is passed to constructor now 👍
There is now a prop called focusableItemProps that doesn't make sense to consumers and should probably be removed. - removed, and, generally speaking, provided focus behavior introduces no changes to public component's API now 👍
The behavior of focusing an item is only required when the list is a selection list, but the this.focusableItem() is applied to every instance of the list - this differentiation is made 👍
There probably shouldn't be any componentDidUpdate code in the List, especially since it is stateless. - there is no any now 👍

@mnajdova

I reviewed this locally and make sense, although I was expecting to be able to circularly navigate throughout the list, but not sure if we want to support this (not saying that we should).

Yes, we should, but this wasn't supported yet. The main goal of this PR was to address the problem of the existing functionality (https://github.com/stardust-ui/react/issues/370#issuecomment-432874011), and this circular traversing behavior wasn't supported there as well. See this functionality as something that will be introduced by means of a dedicated PR.

@kuzhelov I did not investigate further, but with this PR you can use TAB to go throgh the selectable list item. That should not be the case, you should only be able to use the arrow keys.

going to merge these changes, as original ones haven't introduced any keyboard handling capabilities (have checked for master branch). As we are not making things any worse in this aspect, as well as fixing the problems outlined here, it seems to be reasonable to introduce fix as a first step. For TAB support - will file an issue, open to have a discussion in regards to approach that is better to be taken for that.


Failed download

Installing<EMAIL_ADDRESS>failed.Hide output…

<EMAIL_ADDRESS>install /private/var/folders/f0/z3y5cpxs5691zcpwxtmszwdh0000gn/T/apm-install-dir-119623-12886-1wzuwpx.6bmz/node_modules/julia-client/node_modules/node-pty-prebuilt
prebuild-install || node scripts/install.js

npm WARN deprecated<EMAIL_ADDRESS>CoffeeScript on NPM has moved to "coffeescript" (no hyphen)
prebuild-install WARN install No prebuilt binaries found (target=3.1.10 runtime=electron arch=x64 libc= platform=darwin)
gyp ERR! configure error
gyp ERR! stack Error: Python executable "/Users/joshuapurtell/Desktop/Atom.app/Contents/Resources/app/apm/bin/python-interceptor.sh" is v3.7.3, which is not supported by gyp.
gyp ERR! stack You can pass the --python switch to point to Python >= v2.5.0 & < 3.0.0.
gyp ERR! stack     at PythonFinder.failPythonVersion (/Users/joshuapurtell/Desktop/Atom.app/Contents/Resources/app/apm/node_modules/npm/node_modules/node-gyp/lib/configure.js:501:19)
gyp ERR! stack     at PythonFinder.  System Darwin 17.7.0
gyp ERR! command "/Users/joshuapurtell/Desktop/Atom.app/Contents/Resources/app/apm/bin/node" "/Users/joshuapurtell/Desktop/Atom.app/Contents/Resources/app/apm/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--build_v8_with_gn=false"
gyp ERR! cwd /private/var/folders/f0/z3y5cpxs5691zcpwxtmszwdh0000gn/T/apm-install-dir-119623-12886-1wzuwpx.6bmz/node_modules/julia-client/node_modules/node-pty-prebuilt
gyp ERR! node -v v8.9.3
gyp ERR! node-gyp -v v3.7.0
gyp ERR! not ok
npm WARN enoent ENOENT: no such file or directory, open '/private/var/folders/f0/z3y5cpxs5691zcpwxtmszwdh0000gn/T/apm-install-dir-119623-12886-1wzuwpx.6bmz/package.json'
npm WARN apm-install-dir-119623-12886-1wzuwpx.6bmz No description
npm WARN apm-install-dir-119623-12886-1wzuwpx.6bmz No repository field.
npm WARN apm-install-dir-119623-12886-1wzuwpx.6bmz No README data
npm WARN apm-install-dir-119623-12886-1wzuwpx.6bmz No license field.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: prebuild-install || node scripts/install.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      /Users/joshuapurtell/.atom/.apm/_logs/2019-07-23T20_01_26_099Z-debug.log

Same error here. It looks like update to Atom version 1.39.0 broke julia-client. I reverted to v. 1.38.2 and re-installed julia-client and it is now working.


Update ActiveVmGroups.java

Documentation added to two methods

Closing due to not hearing from requestor in a while. Feel free to open it if you see the need again.


Only add GitHub.com package in nightly

https://github.com/SwiftPackageIndex/PackageList/pull/6081/files#r1441579276

We should run a package dump for new packages to avoid this and other subsequent validation errors. (Ideally, we'd run a full validation by moving validation into the validator and making it available for normal package checks somehow.)


List all apps to which user has connected / authenticated

For easy reference in one place and the ability to return and disconnect from each
https://twitter.com/0ZeroAuthority/status/1632090919439839232

Thanks for creating this issue @markmhx
The ability to see all applications a wallet is connected to and able to disconnect in one place is good security hygiene.
Being connected perpetually is not the best practice, & if there were an attack everyone would scramble to check browser history &/or explorer history.
This is important.
Thanks again.

This is a great idea. As the ecosystem grows andmore apps are developed this issue will only become increasingly important.

reading between the lines here: https://leather.canny.io/feature-requests/p/disconnecting-from-approved-apps
Should the wallet also keep track of PSBT's that have been signed, the inputs that are used and offer options to use those same inputs to invalidate past PSBT's? For the user it would look like a list of PSBT's (incomplete and completed ones) and an option to "invalidate a PSBT" for incomplete ones.

@314159265359879 filed here: https://github.com/leather-wallet/extension/issues/4076


Put all generated code in the build/ directory.

DON'T MERGE INTO SURELOG YET

Re-submitting as per https://github.com/chipsalliance/UHDM/pull/485#issuecomment-915795807


Run in Thread not working

Please answer these questions as part of your new issue.
Which version of Python are you using?
Python 2.7 and Python 3.5
Which OS and version are you running?
Raspbian GNU/Linux 9 (stretch)
Is SPI enabled?
Yes
Are you trying to read/write a Mifare Classic card?  (This is currently unsupported)
No
When I try to run the example in a Thread the python program gets terminated and nothing happens. I don't get any output at all. The process just stops.
Example code
class NfcTagMonitor(Thread):
    '''The tag monitor class definition.
    '''

    def __init__(self, nfc_tag_hold=True):
        """
        Constructor.
        """
        Thread.__init__(self)
        self._stop_event = Event()

        self.lastTag = None
        self.mifare = nxppy.Mifare()

    def run(self):
        """
        The method to run in an additional thread.
        """
        logger.info("NfcTagMonitor: Run the cycle ...")
        while True:
            # reading the card id
            try:
                uid = self.mifare.select()
                if uid != self.lastTag:
                    logger.debug("Selected the following id: %s", uid)
                    self.lastTag = uid
                    # do something ...
            except nxppy.SelectError as se:
                # SelectError is raised if no card is in the field.
                logger.debug(
                    "Had an issue selecting the id. Probably the NFC tag has been removed: %s"
                    , se)
            time.sleep(0.5)

# outer class
self.nfc_monitor = NfcTagMonitor()
self.nfcTagMonitor.daemon = True
self.nfcTagMonitor.start()

Figured it out myself.


SpotifyServiceBase.IsPlaying always returns false

Hi, I'm trying to detect when Spotify is playing, and at first glance this was just what I needed. However, it always seems to be returning false. Doesn't this need to be a function with a network request in order to get the proper state (e.g. if Spotify is playing on a different machine)?
Perhaps I just don't understand this enough, but by no means is this a dealbreaker, so don't worry if there's no functionality for it!

Hmm, that IS a strange one. Can you try logging the output every frame and see if it's still false? Then, try changing the song to another one and see if it's still changing to false?

Yep still false every frame. Tried changing/playing/pausing via the Spotify4Unity API and also the Spotify app on my phone, and also the Spotify app on my computer. The Unity app was running on my phone. I'm stumped!

Okay, I think it must have been fixed in between your version and v1.4 (I'm on that now, developing). I thought it could be a Free vs Premium account thing but I tested it and it works 🤔
I took the Android scene and added some text that shows the state and it's showing correctly. (Excuse the broken Android screen)

I'm actually finished with v1.4 and adding iOS support so I'll finish up the documentation as fast as possible and get it out for you. By the way, which version are you using right now?

I'm on v1.3.1, also using a Premium account.
No rush on getting it out, this is a very low priority item for my application 😄

v1.4 just got updated on the Asset store. Could you try updating and letting me know if you're still getting the same error?
FYI: "Android Spotify Service" has changed to "Mobile Spotify Service" so you will have to readd that script after updating

Unfortunately it's still false after the update

Wow, okay. So a couple questions and things...

What version of Unity are you using?
What's your build target? Android/iOS/PC?
Have you set your Scripting Runtime Version to .NET 4.x? (This is important in Unity 2018.2.x)
When you update the asset, are you definitely overriding the old .dll's?
Try calling SpotifyServiceBase.GetSongInfo(), and check songInfo.IsPlaying. Does that also show false? (This one makes an additional web request to Spotify on top of the update loop)
Inside a script that inherits from SpotifyUIBase, do the following code and see if that result is correct. (This is a hidden event I made that I use but I'm exposing it soon)

private void Start()
{
    m_eventManager.AddListener<PlayStatusChanged>(OnPlayChanged);
}

protected virtual void OnPlayChanged(PlayStatusChanged e)
{
    Debug.Log("OnPlayChanged = " + e.IsPlaying);
}

Apart from those, I'm struggling to see what could be causing it. Unless SpotifyServiceBase.UpdateInternal() method is throwing exceptions like "Aborted SpotifyService internal update - {threadException}" or "SpotifyService internal Update loop exception - '{exception}'" and you're not seeing them?
I know you say it's a low priority but if something's now working properly, I should get it fixed ASAP so I'm a little concerned 😬


Remove Scalafix?

Contentious, but in this particular project (unlike all the others) Scalafix's helpfulness is dubious, and it plays havoc with the sandbox project.

I've removed the scalafix on compiler settings, which were the real problem, and added scalafix checks to CI.


feat(config): Semaphore configmap updates should enqueue the pending workflows

…
Checklist:

[ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
[ ] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
[ ] My organization is added to USERS.md.
[ ] I've signed the CLA.
[ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
[ ] My builds are green. Try syncing with master if they are not.
Fixes #4327

Replaced by #4421


Ceph v0.2 plus Ceph Dashboard 0.1

according to
https://github.com/mesosphere/universe/pull/885
and
https://github.com/mesosphere/universe/pull/884
CC: @ryadav88
Tested and working. Will correct any erratas following feedback.

@mhausenblas this is ready for review.


[ADP-2495] Get artifacts from buildkite for e2e tests

[x] Getting windows and linux, windows, macos artifacts from Buildkite for e2e tests

Comments
Seems to work OK.
For master:
$ rake get_latest_bins
[2022-12-13 14:23:11 +0100] >> Getting latest node and wallet binaries from Buildkite into /home/piotr/wb/cardano-wallet/test/e2e/bins
[2022-12-13 14:23:14 +0100] Latest passing buildkite 'cardano-wallet' pipeline for branch 'master' is 22711
[2022-12-13 14:23:14 +0100] Getting 'Build cardano-wallet package for Linux' artifact 👇
[2022-12-13 14:23:29 +0100] https://s3.amazonaws.com/buildkiteartifacts.com/1cc....1e294c5ac753 -> 200

For other branch:
$ rake get_latest_bins[yura/ADP-2495/buildkite-artifacts]
[2022-12-13 14:26:04 +0100] >> Getting latest node and wallet binaries from Buildkite into /home/piotr/wb/cardano-wallet/test/e2e/bins
[2022-12-13 14:26:05 +0100] Latest passing buildkite 'cardano-wallet' pipeline for branch 'yura/ADP-2495/buildkite-artifacts' is 22709
[2022-12-13 14:26:06 +0100] Getting 'Build cardano-wallet package for Linux' artifact 👇
[2022-12-13 14:26:22 +0100] https://s3.amazonaws.com/buildkiteartifacts.com/1cc...8d074a66fd -> 200

GH Actions works fine too:

E2E Linux :heavy_check_mark:
E2E Windows :heavy_check_mark: (one failure == known issue ADP-2298)
E2E Docker :heavy_check_mark: (one failure == known issue ADP-2298)
Mac OS should work fine as well, once buildkite is fixed.

Issue Number
ADP-2495

@Unisay please have another look.


Update startup_overlay.jsx

By making a contribution to this project, I certify that the contributions I make to this project are created in whole by me and I have the right to submit it under the BSD-3-Clause license; OR the contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the BSD-3-Clause license. I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.
Made a few fixes to typos, grammar and cleaned up the text.

Coverage remained the same at 0.054% when pulling 3ae20e4f5168530be57b5ef2a2980fe42b790180 on bt:develop into 0ba1d95c491d390caad9fd23a8336c0c99ddb5db on spectrum:develop.


schema fixes for self-service

fixes #345
@cubismod i wonder how this wasn't caught in pr-check following #269

fixes #345
@cubismod i wonder how this wasn't caught in pr-check following #269

Taking a look

Created APPSRE-6676 to investigate.


Go module instead of dep

Hi,
Wouldn't make more sense to use go-module instead of dep?

Could you elaborate why that would make more sense? Someone contributed the dep changes. As this is my first golang project,I still haven't gotten time to analyze all aspects. If there are good reasons and someone can submit a PR, I would accept it.

Sure, go-module has direct support from Go command, also you are no longer depended to GOPATH directory, means you can work in any workplace you want 💃 ! but also some other reasons which maybe you can find it with better explanations here  https://github.com/golang/dep/issues/1959 (go-module vs dep) and https://golang.org/doc/go1.11#modules
I feel since it is officially a language feature, it will be more and more popular in the future.
go module is introduced with go1.11, it can be kind of downside if you are strong to support 1.10!
BTW, I can create a PR if you agree with this.

@radu-matei You added dep support initially. Would you be ok if we move to go modules? Do you see any downsides?
@koushki I am fine with the change and agree with your assessment. Let's wait for 2 days for Radu to reply if he has any concerns, and then move forward. I assume travis integration etc. would work seamlessly with it, right?

Hi, all!
There are a few thing I'd like to note around this change:

it forces people to upgrade the Go version
there are still subtle issues with modules which are continuously fixed through patch upgrades to Go
dep is stable

That being said, modules are going to be the standard going forward, and it would make sense to add support.
If we test everything, make sure nothing breaks, and have clear instructions on how to contribute, I'm all for it, and I'd be glad to review a PR with the changes.


Clarification on marking duplicates

Hello,
I was wondering if the duplicate marking picard was at cell resolution? I didn't realize until yesterday with the release of cellranger-atac 2.0 that CR duplicate marking was at bulk resolution. I'm assuming mgatk it is at cell resolution?
Thanks,
Chang

Hi Chang,
Yes we are operating at the cell resolution— I didn’t agree with how CR was previously operating, and I’m glad that the new version addresses this.
Caleb
On May 5, 2021, at 4:04 PM, Chang Kim<EMAIL_ADDRESS>wrote:
Hello,
I was wondering if the duplicate marking picard was at cell resolution? I didn't realize until yesterday with the release of cellranger-atac 2.0 that CR duplicate marking was at bulk resolution. I'm assuming mgatk it is at cell resolution?
Thanks,
Chang
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/caleblareau/mgatk/issues/34, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD32FYNERCDEK3DU72VWBUTTMHFHLANCNFSM44F5BFDQ.

Ah that's great, I didn't want to rerun it. I guess in the future you might not need to run mark duplicates within mgatk or maybe add a parameter to use the existing marked duplicates?

Well, the CellRanger v2 update only applies to how they process/produce the fragments file but the bam is the same
On May 5, 2021, at 4:30 PM, Chang Kim<EMAIL_ADDRESS>wrote:
Ah that's great, I didn't want to rerun it. I guess in the future you might not need to run mark duplicates within mgatk or maybe add a parameter to use the existing marked duplicates?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/caleblareau/mgatk/issues/34#issuecomment-833113538, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD32FYIYT6UVQ2I7R25XUMTTMHIKPANCNFSM44F5BFDQ.

Hmm, the 10X bioinformatician was saying the read pairs are marked duplicates. I'll follow up with them for further clarification, thanks!

Ah, well, mgatk ignore thes the mark duplicate tags in the bam existing and computes it de novo.
On May 5, 2021, at 5:30 PM, Chang Kim<EMAIL_ADDRESS>wrote:
Hmm, the 10X bioinformatician was saying the read pairs are marked duplicates. I'll follow up with them for further clarification, thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/caleblareau/mgatk/issues/34#issuecomment-833139953, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD32FYIQJ6TVRJ5M6UDSTLTTMHPLNANCNFSM44F5BFDQ.

One more thing, I have a custom library that has overlapping reads with the same UMI, would UMI deduplication setting work here? Ideally the overlapping regions would be picked for the highest quality.

When you specify a UMI tag in mgatk, the software deduplicates reads using PIcard Tools MarkDuplicates, which retains the read with the highest mean base quality.


Class Problems

>>> class MyClass(TinyObj):
...     __init__(self):
...         self.val = 123
...
>>> x = MyClass()
>>> x.val
NameError: name 'x.val' is not defined
 -> REF x.val           (#1)

:(
>>> x.val = 456
>>> x.val
NameError: name 'x.val' is not defined
 -> REF x.val           (#1)

Seems classes can't support arbitrary attributes?

class define is only supported in main.py

Should we leave this issue open as ToDo for the shell?

Should we leave this issue open as ToDo for the shell?

#88

Confirmed solved.


is it depreacated?

is it depreacated?

I guess it is, if you want I created a sample app that runs ARCore with Three.js on the web: https://github.com/boehm-e/webxr_threejs_AR

@boehm-e Thanks!


Add PR build workflows to stage-slbeta2

$subject

This should be added to the stage-slbeta2 not to master


Set a license

Hey there. Would you mind please set a license  for this? GNU AGPL would be an awesome license to use.

Done!


Roth Touchline component: Permission denied and "Unknown" label

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.61.0
Python release (python3 --version):
3.5
Component/platform:
Roth Touchline
Description of problem:
Component doesn't work at all in a virtual environment. Please see Traceback log for more information. When it comes to the "Unknown" label issue, please see this post in the forum:
https://community.home-assistant.io/t/new-request-roth-touchline-underfloor-heating-system/30736/16
Expected:
Problem-relevant configuration.yaml entries and steps to reproduce:
climate:
  - platform: touchline
    host: YOUR_IPADDRESS

Traceback (if applicable):
2018-01-15 21:22:24 ERROR (MainThread) [homeassistant.components.climate] Error while setting up platform touchline
Traceback (most recent call last):
  File "/srv/homeassistant/homeassistant_venv/lib/python3.5/site-packages/homeassistant/helpers/entity_component.py", line 171, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=self.hass.loop)
  File "/usr/lib/python3.5/asyncio/tasks.py", line 400, in wait_for
    return fut.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/srv/homeassistant/homeassistant_venv/lib/python3.5/site-packages/homeassistant/components/climate/touchline.py", line 32, in setup_platform
    number_of_devices = int(py_touchline.get_number_of_devices(host))
  File "/srv/homeassistant/homeassistant_venv/lib/python3.5/site-packages/pytouchline/__init__.py", line 47, in get_number_of_devices
    response = self._request_and_receive_xml(request)
  File "/srv/homeassistant/homeassistant_venv/lib/python3.5/site-packages/pytouchline/__init__.py", line 115, in _request_and_receive_xml
    h = httplib2.Http(".cache")
  File "/srv/homeassistant/homeassistant_venv/lib/python3.5/site-packages/httplib2/__init__.py", line 915, in __init__
    self.cache = FileCache(cache)
  File "/srv/homeassistant/homeassistant_venv/lib/python3.5/site-packages/httplib2/__init__.py", line 675, in __init__
    os.makedirs(self.cache)
  File "/srv/homeassistant/homeassistant_venv/lib/python3.5/os.py", line 241, in makedirs
    mkdir(name, mode)
PermissionError: [Errno 13] Permission denied: '.cache'

Additional info:

The permission denied issue in virtualenv should be solved by upgrade to pytouchline 0.7

Pull request made for updating pytouchline to 0.7 #12179


wiki: Minor typo on "Writing Web Applications"

On https://golang.org/doc/articles/wiki/:

With this web server running, a visit to http://localhost:8080/view/test should show a page titled "test" containing the words "Hello world".

This should be http://localhost:8080/view/TestPage and "TestPage" instead of test

Huh, I'm re-reading this and the wiki seems fine. I might posted this one in a hurry, my bad! Closing.


[API] Remove the usage of System.Drawing.Rectangle from the public API

The namespace System.Drawing is only fully supported on windows, and for all graphics programming related is now recomended to use System.Numerics.  So I think it would be an improvement to remove completely the use of System.Drawing.Rectangle from the interface IFontStashRenderer and replace the nullable Rectangle? src by two non nullable arguments Vector2 uv, Vector2 deltaUV.  (or uvTopLeft and uvTopRight, it's the same)
namespace FontStashSharp.Interfaces
{
    public interface IFontStashRenderer
    {
        void Draw(
            object texture,
            Vector2 position,
            Vector2 size,
            Vector2 uv,
            Vector2 deltaUV,
            Color color,
            float rotation,
            Vector2 origin,
            Vector2 scale,
            float depth);
    }
}

It would benefit a lot those like us who use FontStashSharp in a custom renderer and it will have no impact for people who use another well known renderer (since you can easily convert those two System.Numerics.Vector2 to a System.Drawing.Rectangle.)

Unsure about this. As I am pretty sure that micro subet of System.Drawing that is used by FontStashSharp is supported by all platforms. So why change well-established API that was already implemented by some people?
Moreover FontStashSharp uses System.Drawing.Color, how will we replace it?

Yes. You are right. I thing I thought it would be a good idea but since Color is on the same package I think it should be referenced anyway.


Do not stop on download errors if the video does not exist.

Summary
If the video does not exist ignore error and continue downloading the subtitles.
Sample output below:
INFO:root:trying to download subtitle for UjU0tpulIQ8
[youtube] UjU0tpulIQ8: Downloading webpage
[youtube] UjU0tpulIQ8: Downloading video info webpage
ERROR: UjU0tpulIQ8: YouTube said: This video does not exist.
INFO:root:No available subtitle for (UjU0tpulIQ8)
INFO:root:trying to download subtitle for Xcrco59p40o
[youtube] Xcrco59p40o: Downloading webpage
[youtube] Xcrco59p40o: Downloading video info webpage
[youtube] Xcrco59p40o: Extracting video information
[youtube] Xcrco59p40o: Downloading MPD manifest
[info] Writing video subtitles to: /Users/mrpau-eduard/content-pack-maker/contentpacks/build/subtitles/en/Xcrco59p40o.en.vtt
INFO:root:Rename /Users/mrpau-eduard/content-pack-maker/contentpacks/build/subtitles/en/Xcrco59p40o.en.vtt -> /Users/mrpau-eduard/content-pack-maker/contentpacks/build/subtitles/en/Xcrco59p40o.vtt

Issues addressed
#66

Its a small fix I will merge this one and rebuild the language pack.


Add regression test to ensure all nodes are reached

By storing both the current_node and next_node in the responses-and-expected-results YAML file, we can compare the nodes that have been exercised with all the nodes in the Flow. I'd added a test that fails if the two sets of nodes don't match.
This is the test that @floehopper mentioned in 53e67d850500421fc26c226a004c13d02429cee8.

Did all the existing regression tests just pass once you'd regenerated their responses-and-expected-results? I assume they did.
LGTM :+1:

Did all the existing regression tests just pass once you'd regenerated their responses-and-expected-results? I assume they did.

They did indeed!

I've updated this branch to include the updated responses-and-expected-outputs and checksum data for the regression tests that have been added since last week. I'm going to get this merged to master.


How to train the upstream model?

Hi, if I would like to train the upstream model from scratch, which commands should be used? Many thanks.

Hi,
there is a link in README,
please check the instructions there.
Currently, we only support a limited type of upstream training.
Andy

Hi,
there is a link in README,
please check the instructions there.
Currently, we only support a limited type of upstream training.
Andy


feat: rename ChainAdapterName -> ChainAdapterDisplayName

Current dependencies on/for this PR:

main

PR #1126

PR #1127   👈

This comment was auto-generated by Graphite.


Syntax error converting model to 2.0

I have searched related issues but cannot get the expected help.
using latest

Describe the bug
When running the upgrade_model_version I'm getting a syntax error:
Traceback (most recent call last):
  File "/Users/robertwashboourne/Documents/tables/env/lib/python3.7/site-packages/mmcv/utils/config.py", line 89, in _validate_py_syntax
    ast.parse(content)
  File "/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/lib/python3.7/ast.py", line 35, in parse
    return compile(source, filename, mode, PyCF_ONLY_AST)
  File "<unknown>", line 1
    /content/drive/My Drive/chunk cascade_mask_rcnn_hrnetv2p_w32_20e.py
    ^
SyntaxError: invalid syntax

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "tools/upgrade_model_version.py", line 193, in <module>
    main()
  File "tools/upgrade_model_version.py", line 189, in main
    convert(args.in_file, args.out_file, args.num_classes)
  File "tools/upgrade_model_version.py", line 126, in convert
    meta_info['config'])
  File "tools/upgrade_model_version.py", line 24, in parse_config
    config = Config.fromfile(config_path)
  File "/Users/robertwashboourne/Documents/tables/env/lib/python3.7/site-packages/mmcv/utils/config.py", line 178, in fromfile
    cfg_dict, cfg_text = Config._file2dict(filename)
  File "/Users/robertwashboourne/Documents/tables/env/lib/python3.7/site-packages/mmcv/utils/config.py", line 107, in _file2dict
    Config._validate_py_syntax(filename)
  File "/Users/robertwashboourne/Documents/tables/env/lib/python3.7/site-packages/mmcv/utils/config.py", line 91, in _validate_py_syntax
    raise SyntaxError('There are syntax errors in config '
SyntaxError: There are syntax errors in config file /var/folders/88/zdrrnbg14td2pf67pb4_2nf00000gn/T/tmpz98nf4lx.py
Exception ignored in: <function _TemporaryFileCloser.__del__ at 0x107a735f0>
Traceback (most recent call last):
  File "/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/lib/python3.7/tempfile.py", line 448, in __del__
    self.close()
  File "/usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/lib/python3.7/tempfile.py", line 444, in close
    unlink(self.name)
FileNotFoundError: [Errno 2] No such file or directory: '/var/folders/88/zdrrnbg14td2pf67pb4_2nf00000gn/T/tmpltt4irkb/tmpbq5m84wy.py'

I ran a grep and "/content/drive/My Drive/chunk cascade_mask_rcnn_hrnetv2p_w32_20e.py" is in the pth file but I'm not sure why the script is failing. I'm on mmdetection master, latest pytorch
Environment
Configured with: --prefix=/Library/Developer/CommandLineTools/usr --with-gxx-include-dir=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/4.2.1
sys.platform: darwin
Python: 3.7.7 (default, Mar 10 2020, 15:43:33) [Clang 11.0.0 (clang-1<IP_ADDRESS>)]
CUDA available: False
GCC: Apple clang version 11.0.3 (clang-1<IP_ADDRESS>)
PyTorch: 1.5.1
PyTorch compiling details: PyTorch built with:
  - GCC 4.2
  - C++ Version: 201402
  - clang 9.1.0
  - Intel(R) Math Kernel Library Version 2019.0.5 Product Build 20190808 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v0.21.1 (Git Hash 7d2fd500bc78936d1d648ca713b901012f470dbc)
  - NNPACK is enabled
  - CPU capability usage: AVX2
  - Build settings: BLAS=MKL, BUILD_TYPE=Release, CXX_FLAGS= -Wno-deprecated -fvisibility-inlines-hidden -Wno-deprecated-declarations -DNDEBUG -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DUSE_INTERNAL_THREADPOOL_IMPL -O2 -fPIC -Wno-narrowing -Wall -Wextra -Werror=return-type -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wno-unused-function -Wno-unused-result -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -Wno-invalid-partial-specialization -Wno-typedef-redefinition -Wno-unknown-warning-option -Wno-unused-private-field -Wno-inconsistent-missing-override -Wno-aligned-allocation-unavailable -Wno-c++14-extensions -Wno-constexpr-not-const -Wno-missing-braces -Qunused-arguments -fcolor-diagnostics -faligned-new -fno-math-errno -fno-trapping-math -Werror=format -Wno-unused-private-field -Wno-missing-braces -Wno-c++14-extensions -Wno-constexpr-not-const, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, USE_CUDA=OFF, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=OFF, USE_NNPACK=ON, USE_OPENMP=OFF, USE_STATIC_DISPATCH=OFF,

TorchVision: 0.6.1
OpenCV: 4.2.0
MMCV: 0.6.1
MMDetection: 2.1.0+184e793
MMDetection Compiler: clang 11.0.3
MMDetection CUDA Compiler: not available

This is the file I'm trying to convert: https://drive.google.com/file/d/1vfUr4pmmI4GICZubAnBeFU8pviMUW_c9/view

There is a syntax error in your config file. Please have a check.

@rawsh-bt I met similar issue when trying to upgrade old trained model to 2.x, how did you solve this error?

There is a syntax error in your config file. Please have a check.

I met the same situation, and I'm pretty sure it's a bug. The program writes the value of checkpoint['meta']['config'] in the Model file directly to the tmp.py file, but the first line is the path, so the first line of the generated py file is the path not commented out.
I solved the problem as following   @hiyyg @rawsh-bt :
import torch
checkpoint = torch.load('model.pth')
checkpoint['meta']['config'] = '#' + checkpoint['meta']['config']
torch.save(checkpoint, 'new_model.pth')

@CescMessi that did it! thank you for posting the fix.

@CescMessi Thanks for posting solution, I had the same problem and I solved it following your fix.

@CescMessi Where do we need to update this snippet of code?

@CescMessi Where do we need to update this snippet of code?

The above code is a standalone py file to change pth file. The bug has been fixed in 4584 , so if you use the lastest version, you don't need to do that operation.


Publishing TADA via CRAN and ROpenSci

Is your feature request related to a problem? Please describe.
Let's work on getting TADA published via CRAN. Then we can also publish it via ROpenSci.
Note from Justin B: "pyOpenSci is actually modeled after ROpenSci, I think Jeff Holiister and Laura DeCicco are both editors for it. CRAN will make it more visible/accessible, ROpenSci will help with code standards and infrastructure that make it more maintainable. You’re already using a lot of that infrastructure but a worthwhile review after CRAN. Let me know if I can be helpful on either front".
https://ropensci.org/software-review/
Describe the solution you'd like
Let's use this issue to plan next steps and track progress on a CRAN submission.

To start, we must address all issues, including notes produced by this more robust CRAN check:
devtools::check(manual = TRUE, remote = TRUE, incoming = TRUE)

We must pick a new name for the TADA package, because tada is already a taken/published package on CRAN:

I suggest you consider using EPATADA as the package name in CRAN. See an example - https://cran.r-project.org/web/packages/epanet2toolkit/index.html

I agree and have implemented this change in the cm-release-review-2 branch for both the package and shiny app. Plan to merge in next week after team review.


[SPARK-46239][CORE] Hide Jetty info

What changes were proposed in this pull request?
The PR sets parameters to hide the version of  jetty in spark.
Why are the changes needed?
It can avoid obtaining remote WWW service information through HTTP.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manual review
Was this patch authored or co-authored using generative AI tooling?
No

I merged this master/3.5/3.4/3.3 as a release manager of Apache Spark 3.3.4 EOL release.
Thank you again, @chenyu-opensource .

Oops. Sorry, @chenyu-opensource . The commit log seems be screwed due to https://github.com/apache/spark/pull/44158/commits/33df20947ec3b7e06aa423c658cae299220d364d, https://github.com/apache/spark/pull/44158/commits/74a61ebd8fd34ae0796cd417a1cc626bdf4b3d6a, https://github.com/apache/spark/pull/44158/commits/7693bfdf058312e90337e8dfa351c037cd1255a7 .

The JIRA issue, SPARK-46239, is correctly assigned to you.

Thank you so much for your review.


wrong IATA airport code location

Use 3-letter airport codes in order to get the weather information at a certain airport:
$ curl wttr.in/muc      # Weather for IATA: muc, Munich International Airport, Germany
$ curl wttr.in/ham      # Weather for IATA: ham, Hamburg Airport, Germany

Which doesn't work for Ronald Reagan Washington National Airport ( IATA: DCA, ICAO: KDCA, FAA LID: DCA ), referred to colloquially as National Airport, Reagan, Reagan National, or simply DCA, is an international airport in Arlington County, Virginia, across the Potomac River from Washington, D.C.

$ curl wttr.in/dca
Weather report: dca
  <.. snip ..>
Location: DCA, 1620, South Disneyland Drive, Anaheim Resort District, Anaheim, Orange County, California, 92802, United States of America [33.80639835,-117.919951333359]

but the 4-letter ICAO airport code does work:

$ curl wttr.in/kdca
Weather report: kdca
  <.. snip ..>
Location: Ronald Reagan Washington National Airport, Thomas Avenue, Fort Barnard Heights, Arlington, Arlington County, Virginia, 22202, United States of America [38.8512154,-77.0396930556152]

I have also been having this issue, where ASH does not return Boire Field, but the icao code does. At this point I may as well just use the NWS API and read a metar.


Set mints to peg-out only

Allow a toggle for mints to be in peg-out only mode to sunset mints.

There is also a good use case for setting a mint to peg-in only.
Imagine you are serving your content via Proxnut and offer a Cashu mint for your users. However, you do not want to allow pegging out, because you don't want to become payment facilitator for whatever reason.


SQL in Queries are DB specific

Hi @kgrzybek
First thanks for publishing this repo. I appreciate your work.
When I check part about Queries I see that you are using raw SQL to get data from database what is OK but you are using square bracket what leads you to use MS database.
Problem is that when you want to migrate one module or all app to different DB you will need to rewrite all SQL's 👎
Second thing is that I think all that raw SQL should be moved to a repository class per each module to have it all in one place, so when you will switch to other DB this could be kind of trade-off if you want to stay with square bracket
Please let me know what do you think

#126 @kgrzybek Replied to similar concerns (especially the first one) in this issue.

Hi @JacekSmi ,
As @AymanSharaf noticed, I answered some time ago to a similar question (second part). TLDR; I advise to not abstract from database on application layer on query side because it does not give you a value. If you want to change db you still need to rewrite SQL statements at some level.
About brackets - imo it is not a big deal because you can remove them easily using find and replace tool. I like to have it, but maybe I think it is matter of choice.


Grammar in Error Message for Unsupported Enum Types

Thoth.Json.Net 8.0.0
Message reads "Thoth.Json.Net only support the folluwing enum types:"
Suggested message: "Thoth.Json.Net only supports the following enum types:"

Will be fixed in the next release


Error parsing TRNAMT (should also accept commas)

Hello,
I have an OFX file generated by a Brazilian bank (Santander) - here we use "," as the decimal separator and the OFX have mixed "," and "." as decimal separators on the TRNAMT values (probably this difference occurs based on which integration they have, like the debit card or ATM systems).
Here is a sample:
<STMTTRN>
    <TRNTYPE>OTHER
    <DTPOSTED>20150706000000[-3:GMT]
    <TRNAMT>            -12.80
    <FITID>00451065
    <CHECKNUM>00451065
    <PAYEEID>0
    <MEMO>DEBITO VISA ELECTRON BRASIL        05/07 CAFE ALBRECHT L
</STMTTRN>
<STMTTRN>
    <TRNTYPE>OTHER
    <DTPOSTED>20150706000000[-3:GMT]
    <TRNAMT>           -200,00
    <FITID>00239183
    <CHECKNUM>00239183
    <PAYEEID>0
    <MEMO>SAQUE NO BANCO 24 HORAS
</STMTTRN>

I thought it was an error on the file (so Santander should fix it), but looking into the OFX specification I found that it's actually supported:
3.2.5 Transaction Amount <TRNAMT>
Format: Amount
Open Financial Exchange uses <TRNAMT> in any request or response that reports the total amount of an individual transaction.
Usage: Bank statement download, investment statement download, payments

And:
Amount: Amounts that do not represent whole numbers (for example, 540.32), must include a decimal point or comma to indicate the start of the fractional amount. Amounts should not include any punctuation separating thousands, millions, and so forth. The maximum value accepted depends on the client.

The fix needed is pretty simple -- just change the function that tries to parse the transaction amount on https://github.com/jseutter/ofxparse/blob/master/ofxparse/ofxparse.py#L824

Note: I had the same error on the ofxtools library.

I'm having the same issue with an OFX File from BNP Paribas Enterprises. I was extremely surprised to see that the spec says that you can use either dot or coma as decimal separator in OFX ! But the specs quotes of @turicas are right... so we have to also support coma as decimal separator :(

Thanks for solving the problem! :)


test issue

Was testing a feature of GitHub projects. If you have the same label in multiple projects, you can filter by that label on the project, and if that label exists in multiple repos, the filter will work as you want - i.e., you can see work from all repos with that label.


Creating a new 'forking' section on the readme

Closes: https://github.com/oceanprotocol/market/issues/599
Changes proposed in this PR:

Updating the readme to inform users which aspects of the market they are required to change when forking and publishing their own data marketplace.

Nice, it's clear enough fo me


Stop using the interrobang in unrelated Sub traits example ‽

The problem
Interrobang is an rare character that does display in some fonts and looks like a potentially syntactic element
Suggestions
Replace the example.
 Or did you mean something else?

The commit does exactly as requested. If there is anything else, it's
better to edit the title
El lun., 9 jul. 2018 19:36, Aleks-Daniel Jakimenko-Aleksejev <
<EMAIL_ADDRESS>escribió:

Reopened #2163 https://github.com/perl6/doc/issues/2163.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/perl6/doc/issues/2163#event-1723714135, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAAB9LyD7TEhJddmwPoC4INA9qqAxEz_ks5uE5SMgaJpZM4VH382
.

@AlexDaniel The commits solves the issue ;)


Is there a way to get file url by FileAdmin

I used FileAdmin to serv file upload service.
So is there a way to get the file real url (like: http://xxx/static/xxx.png)  not download link?
I have configured base_url param, but seems not working.

It solved. It depends on nginx configure.

how to config?


Reland "Unpoison thread_local variables for MSAN (#228)"

This is a reland of e2d3d0bf24884e948e7e3e14888d921d4ad7e808. The issue with the original change was unpoisoning the pointee when really the pointer needs to be unpoisoned. Verified that a sample Chromium web test [1] fails with the original change and passes with the new change.
[1] external/wpt/accessibility/crashtests/aria-owns-fallback-content.html
Delta from original change:
diff --git a/include/marl/scheduler.h b/include/marl/scheduler.h index 54b5732..48acf02 100644
--- a/include/marl/scheduler.h
+++ b/include/marl/scheduler.h
@@ -574,7 +574,7 @@ bool Scheduler::Fiber::wait(
}
Scheduler::Worker* Scheduler::Worker::getCurrent() {

MSAN_UNPOISON(current, sizeof(Worker));

MSAN_UNPOISON(&current, sizeof(Worker*)); return Worker::current; }

diff --git a/src/scheduler.cpp b/src/scheduler.cpp index e91ac5d..43c2c1c 100644
--- a/src/scheduler.cpp
+++ b/src/scheduler.cpp
@@ -87,7 +87,7 @@ namespace marl {
thread_local Scheduler* Scheduler::bound = nullptr;
Scheduler* Scheduler::get() {

MSAN_UNPOISON(bound, sizeof(Scheduler));

MSAN_UNPOISON(&bound, sizeof(Scheduler*)); return bound; }

Original change description:

The current method of working around MSAN errors for thread-local
variables by annotating getters and setters with
CLANG_NO_SANITIZE_MEMORY was insufficient because the getters
don't actually dereference the memory.  Rather, all functions
that dereference the pointers must be annotated with
CLANG_NO_SANITIZE_MEMORY, which is error-prone.  This PR switches
to an alternative workaround that unpoisons the memory in the
getter.
This false-positive MSAN issue is seen when trying to upgrade
Chromium MSAN bots from Ubuntu 18.04 to 20.04, and should be fixed
by this PR.

Thank you again, @tanderson-google! Landing


TinyDTLS library as PSK encrypt layer doesn't work with 32 byte keys.

I've builded client on ci40 / linux with enabled tinyDTLS as a security layer. Then I tried to run awa_clientd with PSK identity/key generated on Device Server platform. But as a result I'm getting errors about wrong key sizes. Here is log from console:

[INFO] Awa LWM2M Client, version 0.2.4
[INFO]   Process ID     : 22396
[INFO]   Endpoint name  : 'Awa Client'
[INFO]   DTLS library   : TinyDTLS
[INFO]   CoAP library   : Erbium
[INFO]   CoAP port      : 6000
[INFO]   IPC port       : 12345
[INFO]   Address family : IPv4
[INFO] Bind port: 6000
[INFO] Try existing server entries
[INFO] No servers are defined
[INFO] Hold Off expired - attempt client-initiated bootstrap
[INFO] Bootstrap with coaps://ds-mono.flowcloud.systems:15684/bs?ep=Awa Client
[INFO] Coap request: coaps://ds-mono.flowcloud.systems:15684/bs?ep=Awa Client
[WARN] cannot set psk -- buffer too small
Nov 17 14:43:59 CRIT no psk key for session available
Nov 17 14:43:59 WARN error in check_server_hellodone err: -592
Nov 17 14:43:59 WARN error while handling handshake packet

Is this now resolved by #320  ?


Incorrect Epoch Labelling

am processing an EEG signal acquired by showing 10 image of each of 40 different classes. I want to label the signals converted to epochs to their corresponding class labels.
raw = mne.io.read_raw_bdf(raw_file, preload =True)
events=mne.find_events(raw, stim_channel = None, initial_event = True, consecutive=‘increasing’, output=‘step’,uint_cast=True, verbose=None)
The events return
array([[ 0, 0, 65280],
[ 3085, 65280, 65533],
[ 44751, 65280, 65281],
…,
[4962462, 65280, 65281],
[4974818, 65280, 65281],
[5021696, 65280, 0]], dtype=int64)
The third column from events is the event code, that are the same for all events 65281, except for initial event.
I made an event dict, by combining the events[2], and the class labels which were shown:
event_dictt =
for event, class_label in zip(events, class_labels):
event_dictt.append((class_label,event[2]))
print(event_dictt)
The event_dictt is a list that contains data
[('initial event', 65280), ('initial event', 65533), ('airliner', 65281), ('watch', 65281), ('folding chair', 65281), ('radio telescope', 65281), ('jack-o-lantern', 65281),
As i plot the epochs to view the class labelling
epochs.plot(n_channels=10, events=events, event_id=event_dictt)
I gives the error
event_id[0] must be an int, got <class ‘tuple’>
if i convert the event_dictt to a dictionary, the epochs.plot works but the epoch labelling is incorrect,The epochs are plotted but the label from the second last class label ‘Pool table’ is used only:
All initial class labels are ignored., as i am converting the event id to a dictionionary, which uses unique events only, and i have same code events
The epochs are not correctly labelled

Hello, this is a usage question we're addressing on the forum:
https://mne.discourse.group/t/incorrect-epoch-labelling/7472


Where the hell do output audios go?

Sorry, it's not really an issue, but the documentation and community for this is not huge so googling i didnt find the solution...
I wouldn't wanna accidentally fill my computer with audios and stuff, at least unknowingly.
Anyone care to pinpoint the output path, or how to set it up manually?

found it. No documentation about this whatsoever... although these being on the temp folder is fine
C:\Users"USERNAME"\AppData\Local\Temp\gradio


update this guide once Spring Framework 4.2 + Boot 1.3 are released

See SPR-9278 for comprehensive CORS support in Spring MVC.
cc @sdeleuze

See this article and this Spring Boot CORS support issue https://github.com/spring-projects/spring-boot/issues/3052 for more details ...

@sdeleuze Do you mind coming back and doing this modification when Spring Boot 1.3 hits GA? We have decided to keep the guides on stable releases.

@gregturn Sure, thanks for the info. In any case that was my intention, that's why I have not merged PR https://github.com/spring-guides/gs-rest-service-cors/pull/7 yet.

Oh may be mention Spring Data REST ... https://jira.spring.io/browse/DATAREST-573


Feature/add iam bindings

Description of your changes
Added IAM binding resources for folders, projects, and service accounts.
Fixes #13
I have:

[X] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Created resources in existing GCP org. Also ran make local-deploy.

/test-examples="examples/cloudplatform/serviceaccountiambinding.yaml"

Could you please add the screenshots under the How has this code been tested title? Please see: https://github.com/upbound/provider-gcp/pull/198

/test-examples="examples/cloudplatform/projectiammember.yaml"

Hi @bradkwadsworth-mw,
I discussed this PR with the team and as I mentioned above there is an issue with adding *_iam_binding resources. As mentioned in the issue, there is an incompatibility with using *_iam_member, *_iam_binding, and *_iam_policy resources together. The *_iam_member resources have been tested and added to the v1beta1 version, if you cannot do with *_iam_member what you can do with *_iam_binding, please leave a comment to the issue. That's why I'm closing this PR for now.
Related issue, feel free to comment, thank you!


Crash when a mob dies on server due to attributes (?)

something about a spider, ai.attributes and death/ticking.
https://pastebin.com/gKPP1YFA

One of forge updates must have broken this one but I will release a fix later today.

Roger. thanks


Document e2e testing and supported providers

Documentation changes:

add the supported Git provider APIs to the main readme
move the test suite spec to the development doc
mention Weaveworks as the sponsor of the Bitbucket e2e infra

Codecov Report

Merging #142 (72513d7) into main (ddea418) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   59.79%   59.87%   +0.07%
==========================================
  Files          77       77
  Lines        4052     4052
==========================================
+ Hits         2423     2426       +3
+ Misses       1117     1114       -3
  Partials      512      512

Impacted Files
Coverage Δ

github/resource_repository.go
84.11% <0.00%> (+1.86%)
:arrow_up:

github/client_repositories_org.go
65.30% <0.00%> (+2.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddea418...72513d7. Read the comment docs.


Support for tsconfig.json Paths

Description:
I'm using the borp package with a TypeScript project, and I noticed that borp doesn’t currently support paths defined in the tsconfig.json file. This feature would be highly beneficial for maintaining cleaner import paths and improving code organization.
Suggested Solution:
Add support for resolving module paths based on tsconfig.json configurations. This would allow for seamless integration of custom import paths, enabling shorter and more manageable imports across projects.
Example:
Here’s an example of the tsconfig.json paths section that borp would ideally support:
{
  "compilerOptions": {
    "incremental": true,
    "baseUrl": "./",
    "paths": {
      "@components/*": ["src/components/*"],
      "@utils/*": ["src/utils/*"]
    }
  }
}

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

Yes, I'm working on it. I'll prepare a Pull Request addressing this issue and include unit tests.


Discarded Storage Location and Inactive Item

Resolves #4526
Description

Added a Storage Location that is discarded in the seed
Made atleast one item of an organization inactive

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Testing Inactive Item:

Login as<EMAIL_ADDRESS>Go to Inventory > Items and Inventory
Go to Items Tab
Filter for Item that was marked inactive (in my case Adult Briefs (Large/X-Large))
Check if it appears on the list (it doesnt) (first screenshot)
Click the Also include inactive items checkbox
Check if it appears on the list(second screenshot), it does!

Testing Discarded Storage Location

Login as<EMAIL_ADDRESS>Go to Inventory > storage locations
At first only 2 storage location appears (third screenshot)
Click the include inactive storage locations checkbox
Check if it appears on the list(fourth screenshot), it does!

Screenshots

hi @cielf , i made the changes regarding inventory they are 0 for both now. I hope it is what you are looking for.
let me know if there are any issues. cheers

Hi @cielf,
found the leak, it was from Donations. should be all fixed now. please check. tested it on my end as well.


datepicker position in angular6

in angular 6 this datepicker dosent have correct position

Hi,
I think its not related to this component but if you sure about it please make a demo in stackblitz so I can see the problem and fix it.


feat: change methods from arrow functions to allow for mocking

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@4d25ea3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #119   +/-   ##
==========================================
  Coverage           ?   88.56%
==========================================
  Files              ?       82
  Lines              ?     1312
  Branches           ?      129
==========================================
  Hits               ?     1162
  Misses             ?      148
  Partials           ?        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d25ea3...7aed5c0. Read the comment docs.


feat: port FieldTheory.Finite.GaloisField

This PR should wait until the discussion here is resolved

[ ] depends on: #5284

We are waiting for !4#5284, but I think you can already use the new mathport output (don't forget to update the hash!)

This PR/issue depends on:

leanprover-community/mathlib4#5284
By Dependent Issues (🤖). Happy coding!

This PR/issue depends on:

leanprover-community/mathlib4#5284
By Dependent Issues (🤖). Happy coding!

bors merge


Update the image repo to ghcr.io

Fixes https://github.com/dependabot/dependabot-core/issues/7457

🤔 But that's an old image prior to the per-ecosystem image refactoring I think? That development image, even if it builds, it's unlikely to be useful.
I think it'd make more sense to remove the default and make the FROM_IMAGE build arg required?

It does work as it is just bringing in the environment necessary to run Dependabot, i.e. Ruby and a few other tools.  That said, if it is no longer maintained, then yes, I think it should be a ARG without a default value or possibly to the updater-core image.
I will have to familiarize myself with this new per ecosystem image and how it is intended to be run with a script, as that is how the devcontainer launches and debugs via vscode.  It may be that the updater core image is a better fit for this, but that is something I will need to explore.
In the meantime, I am actually addressing another issue and just noticed this and a few other issues with the devcontainer that I wanted to address.

Makes sense, let us know what you find. I guess defaulting to https://github.com/dependabot/dependabot-core/pkgs/container/dependabot-updater-core would be another option if that works.

I tested the updater core image last week and had no issues, updated the change requested to that just now :)

As a result of testing, I noticed that rubocp and solargraph were not working correctly, added the proper configuration to get them evaluating properly.

Actually, there is an issue.  There is no terraform in this image.

Working on converting to a FROM_ARG

@jeffwidman  @deivid-rodriguez deivid-rodriguez
Is there a list of to ecosystem app version to package tags?
For example: I want to use my FROM_IMAGE to be an image that has terraform version 1.4.5 or npm version 5.0.1 etc etc
What is the best way to determine this?
I want to create instructions on how to use the ARG but also want to add instructions on how to find the image tag they want to reference as well.  If there isn't a version available that matches their need then reference them to the developer build section.
Thanks

There's some bigger questions on this PR, and they're good ones. But in the meantime, we're still referencing an old/outdated docker image on main, so I extracted a subset of these commits into:

https://github.com/dependabot/dependabot-core/pull/7565

This way having the broader discussion doesn't block removing old references from main.

I added comments too late to the other PR but since we are moving forward on this one.  I need some guidance on preferred implementation.
Options:

As this current PR does, add a ARG that accepts an ecosystem image and tag and make devs figure out which one supports a version of the helpers they are addressing.
Use updater-core as base image and then update Dockerfile.development to install all helper tools
Create a new updater-core-dev image that uses the updater-core image and installs all the helper tools and users can derive from it.

Once a preference is made, if 1 or 2 I can address, if 3 then that will be on the dependabot team.
If 1. is selected I need to know if there is a manifest for tool versions or is it a hunt through the commits to find what version it supports.  I think this would be good info to know for anybody hosting their own dependabot as many people are not running the latest version of helper tools.


Create initial snakemake workflow for dnadiff method

As previously mentioned in #9, different methods exist for ANI calculations. One of many goals for pyani_plus is to replicate the ANI values provided by dnadiff.
To integrate dnadiff, we need to:

Write Initial Workflow to Generate Appropriate Files: Develop the initial workflow to produce the required files. Specifically, we need to use nucmer to generate .delta files, delta-filter to create .filter files, and show-diff to generate .rdiff files.

Create Test Set of Target Outputs: Generate a test set comprising target output files produced by all nucmer wrappers (e.g., nucmer, delta-filter, and show-diff). These target outputs will serve as benchmarks to validate that the workflow produces all expected outputs and that the content of the generated files is as expected.

Test the Workflow with pytest: Test the entire snakemake workflow using pytest to ensure it runs without errors and that all expected outputs are generated.

NOTE: There is no need to update Make file to install any dependencies. This is because all dependencies required  for the dnadiff method are the same as those needed for the ANIm method.

I have been working on this under branch issue_9, where I written an initial workflow for fastANI method (#9).


Autogenerate sysadmin linux walkthrough, admin ports, db script

Note requires CI changes due to changes to omero/autogen_docs, in particular the addition of ome/omero-install
Use omero/autogen to:

Copy some of the ome/omero-install Linux walkthrough files
Generate omero admin ports -h text
Guess the current and previous DB versions
Generate the example omero db script output

Note this changes the CLi invocation to use the --password flag instead of prompting for the root password (makes it easier to autogenerate the example)

Remove mentions of plpgsql (applied to postgres 8.4)

--depends-on https://github.com/ome/omero-install/pull/21
--no-rebase

It looks like you can't reopen a closed PR if the branch has been force-pushed in the meantime. Reopened as https://github.com/openmicroscopy/ome-documentation/pull/1158

It looks like you can't reopen a closed PR if the branch has been force-pushed in the meantime.

Very good to know. ("Reopen" is grayed out for me as well)