Drupal 7

Issue Type

Bug Report / Support Request

Your Environment

Your OS

macOS (version)

Summary
Cannot get Drupal 7 to load.
Following the directions for custom drupal configuration using a drupal.make.yml
does not create a Drupal 7 instance. Drupal 8 is still installed

@dev-dev00 please include your config file, environment info would be useful too so we can try to replicate the issue.

vagrant_box can also be set to geerlingguy/centos6, geerlingguy/centos7,
geerlingguy/debian8, geerlingguy/ubuntu1404, geerlingguy/ubuntu1204, etc.
vagrant_box: geerlingguy/ubuntu1604
vagrant_user: vagrant
vagrant_synced_folder_default_type: nfs
vagrant_gui: false
If you need to run multiple instances of Drupal VM, set a unique hostname,
machine name, and IP address for each instance.
vagrant_hostname: drupalvm.dev
vagrant_machine_name: drupalvm
vagrant_ip: <IP_ADDRESS>
Allow Drupal VM to be accessed via a public network interface on your host.
Vagrant boxes are insecure by default, so be careful. You've been warned!
See: https://docs.vagrantup.com/v2/networking/public_network.html
vagrant_public_ip: ""
A list of synced folders, with the keys 'local_path', 'destination', and
a 'type' of [nfs|rsync|smb] (leave empty for slow native shares). See
http://docs.drupalvm.com/en/latest/getting-started/syncing-folders/ for more.
vagrant_synced_folders:
The first synced folder will be used for the default Drupal installation, if
any of the build_* settings are 'true'. By default the folder is set to
the drupal-vm folder.

local_path: .
destination: /var/www/drupalvm
type: nfs
create: true

Memory and CPU to use for this VM.
vagrant_memory: 2048
vagrant_cpus: 1
Minimum required versions.
drupalvm_vagrant_version_min: '1.8.6'
drupalvm_ansible_version_min: '2.2'
Force use of ansible_local provisioner, even if Ansible is installed on host.
force_ansible_local: false
The web server software to use. Can be either 'apache' or 'nginx'.
drupalvm_webserver: apache
The database system to use. Can be either 'mysql' or 'pgsql'.
drupal_db_backend: mysql
Set this to 'false' if you are using a different site deployment strategy and
would like to configure 'vagrant_synced_folders' and 'apache_vhosts' manually.
drupal_build_makefile: true
drush_makefile_path: "drupal.make.yml"
drush_make_options: "--no-gitinfofile"
Set 'build_makefile' to 'false' and this to 'true' if you are using a
composer based site deployment strategy.
drupal_build_composer: false
drupal_composer_path: "drupal.composer.json"
drupal_composer_install_dir: "/var/www/drupalvm/drupal"
drupal_composer_dependencies:

"drupal/devel:1.x-dev"

Set this to 'true' and 'build_makefile', 'build_composer' to 'false' if you
are using Composer's create-project as a site deployment strategy.
drupal_build_composer_project: false
drupal_composer_project_package: "drupal-composer/drupal-project:7.x-dev"
drupal_composer_project_options: "--prefer-dist --stability dev --no-interaction"
Set this to 'false' if you don't need to install drupal (using the drupal_*
settings below), but instead copy down a database (e.g. using drush sql-sync).
drupal_install_site: true
Required Drupal settings.
drupal_core_path: "{{ drupal_composer_install_dir }}/web"
drupal_core_owner: "{{ drupalvm_user }}"
drupal_db_user: drupal
drupal_db_password: drupal
drupal_db_name: drupal
Settings for installing a Drupal site if 'install_site:' is 'true'.
drupal_major_version: 7
drupal_domain: "{{ vagrant_hostname }}"
drupal_site_name: "Drupal"
drupal_install_profile: standard
drupal_enable_modules: [ 'devel' ]
drupal_account_name: admin
drupal_account_pass: admin
Additional arguments or options to pass to drush site-install.
drupal_site_install_extra_args: []
Cron jobs are added to the vagrant user's crontab. Keys include name
(required), minute, hour, day, weekday, month, job (required), and state.
drupalvm_cron_jobs: []
Drupal VM automatically creates a drush alias file in your ~/.drush folder if
this variable is 'true'.
configure_drush_aliases: true
Helper variable to configure the PHP-FPM connection for each Apache
VirtualHost in the apache_vhosts list.
apache_vhost_php_fpm_parameters: |
<FilesMatch .php$>
SetHandler "proxy:fcgi://{{ php_fpm_listen }}"

Apache VirtualHosts. Add one for each site you are running inside the VM. For
multisite deployments, you can point multiple servernames at one documentroot.
View the geerlingguy.apache Ansible Role README for more options.
apache_vhosts:

servername: "{{ drupal_domain }}"
serveralias: "www.{{ drupal_domain }}"
documentroot: "{{ drupal_core_path }}"
extra_parameters: "{{ apache_vhost_php_fpm_parameters }}"

servername: "adminer.{{ vagrant_hostname }}"
documentroot: "{{ adminer_install_dir }}"
extra_parameters: "{{ apache_vhost_php_fpm_parameters }}"

servername: "xhprof.{{ vagrant_hostname }}"
documentroot: "{{ php_xhprof_html_dir }}"
extra_parameters: "{{ apache_vhost_php_fpm_parameters }}"

servername: "pimpmylog.{{ vagrant_hostname }}"
documentroot: "{{ pimpmylog_install_dir }}"
extra_parameters: "{{ apache_vhost_php_fpm_parameters }}"

servername: "{{ vagrant_ip }}"
serveralias: "dashboard.{{ vagrant_hostname }}"
documentroot: "{{ dashboard_install_dir }}"
extra_parameters: "{{ apache_vhost_php_fpm_parameters }}"

apache_packages_state: latest
apache_remove_default_vhost: true
apache_mods_enabled:

expires.load
ssl.load
rewrite.load
proxy.load
proxy_fcgi.load

Nginx hosts. Each site will get a server entry using the configuration defined
here. Set the 'is_php' property for document roots that contain PHP apps like
Drupal.
nginx_hosts:

server_name: "{{ drupal_domain }} www.{{ drupal_domain }}"
root: "{{ drupal_core_path }}"
is_php: true

server_name: "adminer.{{ vagrant_hostname }}"
root: "{{ adminer_install_dir }}"
is_php: true

server_name: "xhprof.{{ vagrant_hostname }}"
root: "{{ php_xhprof_html_dir }}"
is_php: true

server_name: "pimpmylog.{{ vagrant_hostname }}"
root: "{{ pimpmylog_install_dir }}"
is_php: true

server_name: "{{ vagrant_ip }} dashboard.{{ vagrant_hostname }}"
root: "{{ dashboard_install_dir }}"
is_php: true

nginx_remove_default_vhost: true
nginx_ppa_use: true
MySQL databases and users.
mysql_databases:

name: "{{ drupal_db_name }}"
encoding: utf8mb4
collation: utf8mb4_general_ci

mysql_users:

name: "{{ drupal_db_user }}"
host: "%"
password: "{{ drupal_db_password }}"
priv: "{{ drupal_db_name }}.*:ALL"

PostgreSQL databases and users.
postgresql_databases:

name: "{{ drupal_db_name }}"

postgresql_users:

name: "{{ drupal_db_user }}"
password: "{{ drupal_db_password }}"
db: "{{ drupal_db_name }}"
priv: "ALL"

Comment out any extra utilities you don't want to install. If you don't want
to install any extras, set this value to an empty set, e.g. [].
installed_extras:

adminer

- blackfire
- drupalconsole

drush

- elasticsearch
- java

mailhog

- memcached
- newrelic
- nodejs

pimpmylog

- redis
- ruby
- selenium
- solr
- tideways
- upload-progress

varnish

- xdebug
- xhprof
Add any extra apt or yum packages you would like installed.
extra_packages:

sqlite

You can configure almost anything else on the server in the rest of this file.
extra_security_enabled: false
drush_version: "8.1.10"
firewall_allowed_tcp_ports:

"22"
"25"
"80"
"81"
"443"
"4444"
"8025"
"8080"
"8443"
"8983"
"9200"
firewall_log_dropped_packets: false
firewall_disable_firewalld: true
firewall_disable_ufw: true

PHP Configuration. Currently-supported versions: 5.6, 7.0, 7.1.
See version-specific notes: http://docs.drupalvm.com/en/latest/configurations/php/
php_version: "5.6"
php_install_recommends: no
php_memory_limit: "192M"
php_display_errors: "On"
php_display_startup_errors: "On"
php_realpath_cache_size: "1024K"
php_sendmail_path: "/opt/mailhog/mhsendmail"
php_opcache_enabled_in_ini: true
php_opcache_memory_consumption: "192"
php_opcache_max_accelerated_files: 4096
php_max_input_vars: "4000"
Drupal VM defaults to using PHP-FPM with either Apache or Nginx. If you wish
to instead use Apache + mod_php with an Ubuntu base box, make sure you add
libapache2-mod-php7.0 to extra_packages elsewhere in this config file.
php_enable_php_fpm: true
php_fpm_listen: "<IP_ADDRESS>:9000"
composer_path: /usr/bin/composer
composer_home_path: "/home/{{ drupalvm_user }}/.composer"
composer_home_owner: "{{ drupalvm_user }}"
composer_home_group: "{{ drupalvm_user }}"
composer_global_packages:

{ name: hirak/prestissimo, release: '^0.3' }

Run specified scripts before or after VM is provisioned. Path is relative to
the provisioning/playbook.yml file.
pre_provision_scripts: []
post_provision_scripts: []
- "../examples/scripts/configure-solr.sh"
MySQL Configuration.
mysql_root_password: root
mysql_slow_query_log_enabled: true
mysql_slow_query_time: 2
mysql_wait_timeout: 300
adminer_install_filename: index.php
Node.js configuration (if enabled above).
Valid examples: "0.10", "0.12", "4.x", "5.x".
nodejs_version: "0.12"
nodejs_npm_global_packages: []
nodejs_install_npm_user: "{{ drupalvm_user }}"
npm_config_prefix: "/home/{{ drupalvm_user }}/.npm-global"
Ruby Configuration (if enabled above).
ruby_install_gems_user: "{{ drupalvm_user }}"
ruby_install_gems: []
Varnish Configuration (if enabled above).
varnish_listen_port: "81"
varnish_default_vcl_template_path: templates/drupalvm.vcl.j2
varnish_default_backend_host: "<IP_ADDRESS>"
varnish_default_backend_port: "80"
Pimp my Log settings.
pimpmylog_install_dir: /usr/share/php/pimpmylog
pimpmylog_grant_all_privs: true
XDebug configuration. XDebug is disabled by default for better performance.
php_xdebug_default_enable: 0
php_xdebug_coverage_enable: 0
php_xdebug_cli_enable: 1
php_xdebug_remote_enable: 1
php_xdebug_remote_connect_back: 1
Use PHPSTORM for PHPStorm, sublime.xdebug for Sublime Text.
php_xdebug_idekey: PHPSTORM
php_xdebug_max_nesting_level: 256
Solr Configuration (if enabled above).
solr_version: "5.5.3"
solr_xms: "64M"
solr_xmx: "128M"
Selenium configuration.
selenium_version: 2.53.0
Other configuration.
dashboard_install_dir: /var/www/dashboard
known_hosts_path: ~/.ssh/known_hosts
hostname_fqdn: "{{ vagrant_hostname }}"
ssh_home: "{{ drupal_core_path }}"

Vagrant 1.9.4
VirtualBox 5.1.20r114629
ansible <IP_ADDRESS>
config file =
configured module search path = Default w/o overrides
python version = 2.7.10 (default, Oct 23 2015, 19:19:21) [GCC 4.2.1 Compatible Apple LLVM 7.0.0 (clang-7<IP_ADDRESS>)]

thx also the drupal.make.yml

make.pdf

and this file is called drupal.make.yml in the root directory or where your config.yml file is?

In my root directory it is call drupal.make.yml. Yes, in the same directory as the default.config.yml file.

Ahh I think you need the {{ config_dir }} prefix as below
# Set this to 'false' if you are using a different site deployment
strategy and
# would like to configure 'vagrant_synced_folders' and 'apache_vhosts'
manually.
drupal_build_makefile: true
drush_makefile_path: "{{ config_dir }}/drupal.make.yml"
drush_make_options: "--no-gitinfofile"

see default -- https://github.com/geerlingguy/drupal-vm/blob/master/default.config.yml#L52

let me try that.
I'm pretty sure those files weren't being found with: drush_makefile_path: "{{ config_dir }}/drupal.make.yml". But I will verify.

@dev-dev00 you might be onto something - not sure where playbook_dir is set, but would assume config_dir defaults to /..
https://github.com/geerlingguy/drupal-vm/blob/bd6ba6924dc0b2d783de839e548b032d32021d59/provisioning/tasks/config.yml#L7

This is the error when setting drush_makefile_path: "{{ config_dir }}/drupal.make.yml".

can you try vagrant destroy -f && vagrant up -- also do you have any extra vagrant plugins?
vagrant plugin list

plugin list: vagrant-share (1.1.7, system)

It appears the same error is occurring after vagrant destroy -f && vagrant up.

I'm a bit stuck then sorry, only thing I could suggest is trying -- https://github.com/thom8/drupal8-vagrant#drupal-7 to check it the issue is related to DrupalVM or your Vagrant config.

I will double check that.
Attached is the complete terminal output from the last vagrant up.
error complete.pdf

not sure where playbook_dir is set, but would assume config_dir defaults to /..

Correct, it's set by ansible to the playbook base directory. http://docs.ansible.com/ansible/playbooks_variables.html
Wonder if it's something with your host python environment.
Could you try updating your python version? At least you're using 2.7.10 (2015) while I have 2.7.13 (2016). This is my version for reference
ansible <IP_ADDRESS>
  config file =
  configured module search path = Default w/o overrides
  python version = 2.7.13 (default, Dec 18 2016, 07:03:39) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-8<IP_ADDRESS>)]

Can confirm that I updated python.
It did fix the error message received previously when utilizing the default code of:
drush_makefile_path: "{{ config_dir }}/drupal.make.yml"
But, it still loads D8

Did you delete the previously generated drupal codebase from your host machine? vagrant destroy will not delete the drupal/ directory, you have to do it manually. https://github.com/geerlingguy/drupal-vm/issues/1046#issuecomment-266335495

@oxyc Good call.  That did it. Drupal 7 works now!

Drupal 7 and PHP 5.6 configuration instructions:
Mac OS X El Capitan, Version 10.11.6
Requirements: Python 2.7.13
DrupalVM Ubuntu 16_04 Instructions.pdf

@dev-dev00 did you manage to get it all sorted?

Yes,
Thank you all again for the help.
Seems like the python upgrade and clearing the Drupal folder between builds did the trick.

Great! Closing the issue in that case.


[Backport] v2.5: Update error

Original PR:
https://github.com/rancher/rancher/pull/34939

https://github.com/rancher/rancher/issues/35045


Error and suggest

Keep getting this error after a while. Can you add an option to resume at a selected page to avoid wasting time running from the beginning?
Traceback (most recent call last):
File "buff2steam_main_.py", line 85, in
File "asyncio\runners.py", line 44, in run
File "asyncio\base_events.py", line 649, in run_until_complete
File "buff2steam_main_.py", line 79, in main
File "buff2steam_main_.py", line 14, in main_loop
File "buff2steam\provider\buff.py", line 68, in get_items
File "buff2steam\provider\buff.py", line 55, in request
buff2steam.exceptions.BuffError: {'error': '访问频率过高, 请稍后重试……', 'code': 'System Error'}
[14428] Failed to execute script 'main' due to unhandled exception!
And can you add a feature like sort by quantity, to compare the high quantity item first?

The error you are getting is related to the buff API rate limit. You should increase the request_interval value in buff portion of config.json. Alternatively, you can set up a try catch in the __main__.py file.
As far as I know buff API does not provide a way to sort goods by quantity, or other metrics, so it would probably be difficult to implement your proposed feature

As far as I know buff API does not provide a way to sort goods by quantity, or other metrics, so it would probably be difficult to implement your proposed feature

The API does indeed support such parameters, as we are utilizing the same API as their website. Therefore, our scripts can perform the same functions as their website.
For years, I believed this project was dead, but it's surprising to see everyone's enthusiasm. Perhaps I should consider recommitting my energy to this project.


Change main file for npm

Ah sorry, got a wrong module (name conflict, there's already a buzz in npm)

Ok Grabbou :)
Yes, unfortunately, there is another buzz library on npm.


[Feature] Add a way in the settings to disable the "load" notifications of plugins

Before Requesting

[X] I found no existing issue matching my feature request

Describe the feature you'd like!
This notification (see image at the end)
A way to eliminate/disable the load notification of plugins every time i open discord or when i update a plugin in the settings.
Why? Aesthetically speaking i don't like it. The more plugins one has, the more "loads" appear as a notification and i don't like it
Make it appear ONLY if the load of the plugin fails for some reason, that would be useful.
Anything else?

Try toggling the disable toasts setting.

i don't want to disable toasts, just plugin notifications of that kind

That is not a toast by BD, but by your BDFDB plugin.

Yes but can't BD control the flux of toast that aplear inside itself?

This can already be disabled inside BDFDB settings.

What about other plugins not made by devil bro?

nvm i got it


Wrong X509IssuerName,X509SerialNumber error while using pcsid certificate from simulation API

Hello sir,
I got a production certificate(through simulation API not from Core API)-->https://gw-fatoora.zatca.gov.sa/e-invoicing/simulation/production/csids . I signed an xml through zatca sdk using that certificate. Then i tried to validate the signed xml in zatca developer portal website (Web Based Validator for Non-Technical Users). at that time i got two errors -->

category : SIGNATURE_ERROR; code :X509IssuerName; message : wrong X509IssuerName
category : SIGNATURE_ERROR; code :X509SerialNumber; message : wrong X509SerialNumber

Can you pleasse explain why this is happenning. Does this problem will be solved when i use certificate from the core API(https://gw-fatoora.zatca.gov.sa/e-invoicing/core/production/csids) ? . The IssuerName, SerialNumber i got is given below:

ds:X509IssuerNameCN=PEZEINVOICESCA2-CA, DC=extgazt, DC=gov, DC=local</ds:X509IssuerName>
ds:X509SerialNumber523714212568733975663820536758723156753584848</ds:X509SerialNumber>

Please help me to solve this issue.

I get same error message but I don't know if you can resolve it ?

I get same error message but I don't know if you can resolve it ?

No it's not solved. Still this error is there. Do you solved it?

any solution?
same issue when try to validate xml

I am facing same issue, if you guys solved then just let me know please

if you are facing the issue while validating the "INDIVIDUAL" customer(private customer/ B2C) invoice then its not error.
Because according to the guidelines provided by ZATCA (available on their website) we are not requiored to validate the xml of individual customers(B2C customers).
It is only required for company users(B2B).

Hi Nihal ,
Appreciate your reply , I know it's not required while are going with the b2c , but what if is the thing that will be the output in any form for the invoice will it be pdf or just qr .
i mean i want to know that don't we need to send invoice pdf while in B2C ?

From: nihal-infiniarc @.>
Sent: Tuesday, May 14, 2024 12:52 AM
To: Saleh7/php-zatca-xml @.>
Cc: huzaifausmannebras @.>; Comment @.>
Subject: Re: [Saleh7/php-zatca-xml] Wrong X509IssuerName,X509SerialNumber error while using pcsid certificate from simulation API (Issue #2)
if you are facing the issue while validating the "INDIVIDUAL" customer(private customer/ B2C) invoice then its not error.
Because according to the guidelines provided by ZATCA (available on their website) we are not required to validate the xml of individual customers(B2C customers).
It is only required for company users(B2B).
—
Reply to this email directly, view it on GitHubhttps://github.com/Saleh7/php-zatca-xml/issues/2#issuecomment-2109515515, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BDA42WS6QKHPJ46QWQ6IM2TZCG7EZAVCNFSM6AAAAABAFNMMYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZGUYTKNJRGU.
You are receiving this because you commented.Message ID: @.***>

Hi [huzaifausmannebras]
Can you provide where the  errors in details  you meen ?
cac:AccountingSupplierParty
cac:Party
cac:PartyIdentification
<cbc:ID schemeID="CRN">5855056077</cbc:ID>
</cac:PartyIdentification>
cac:PostalAddress
cbc:StreetNameEastern Ring Branch Road</cbc:StreetName>
cbc:BuildingNumber3609</cbc:BuildingNumber>
cbc:PlotIdentification3609</cbc:PlotIdentification>
cbc:CitySubdivisionNameRefrigerator market</cbc:CitySubdivisionName>
cbc:CityNameKhamis Mushait</cbc:CityName>
cbc:PostalZone62461</cbc:PostalZone>
cac:Country
cbc:IdentificationCodeSA</cbc:IdentificationCode>
</cac:Country>
</cac:PostalAddress>
cac:PartyTaxScheme
cbc:CompanyID310823755500003</cbc:CompanyID>
cac:TaxScheme
cbc:IDVAT</cbc:ID>
</cac:TaxScheme>
</cac:PartyTaxScheme>
cac:PartyLegalEntity
cbc:RegistrationNameFakeeh  company</cbc:RegistrationName>
</cac:PartyLegalEntity>
</cac:Party>
</cac:AccountingSupplierParty>
which part you found error  ?

I got the solution , the error was because my CSR was not same for the details that i mentioned in my invoice as me . so when i add the real details of mine that was associated with the CSR the error goes resolve

Hi [huzaifausmannebras]
Can you provide where the errors in details you meen ?
cac:AccountingSupplierParty
cac:Party
cac:PartyIdentification
<cbc:ID schemeID="CRN">5855056077</cbc:ID>
</cac:PartyIdentification>
cac:PostalAddress
cbc:StreetNameEastern Ring Branch Road</cbc:StreetName>
cbc:BuildingNumber3609</cbc:BuildingNumber>
cbc:PlotIdentification3609</cbc:PlotIdentification>
cbc:CitySubdivisionNameRefrigerator market</cbc:CitySubdivisionName>
cbc:CityNameKhamis Mushait</cbc:CityName>
cbc:PostalZone62461</cbc:PostalZone>
cac:Country
cbc:IdentificationCodeSA</cbc:IdentificationCode>
</cac:Country>
</cac:PostalAddress>
cac:PartyTaxScheme
cbc:CompanyID310823755500003</cbc:CompanyID>
cac:TaxScheme
cbc:IDVAT</cbc:ID>
</cac:TaxScheme>
</cac:PartyTaxScheme>
cac:PartyLegalEntity
cbc:RegistrationNameFakeeh company</cbc:RegistrationName>
</cac:PartyLegalEntity>
</cac:Party>
</cac:AccountingSupplierParty>
which part you found error ?


In the Crafting Grid of Refined Storage, the amount of items consumed when Shift+Click is wrong.

See #652


Remove all obsolete terms from all slims

See discussion here: #16147

Terms impacted:
GO:0009370 signal transducer activity
subset: goslim_aspergillus
subset: goslim_candida
subset: goslim_chembl
subset: goslim_generic
subset: goslim_metagenomics
subset: goslim_plant
subset: goslim_yeast

GO:0005624 obsolete membrane fraction
subset: goslim_aspergillus
subset: goslim_candida
subset: goslim_yeast

GO:0070271 obsolete protein complex biogenesis
subset: goslim_yeast

GO:0030528 obsolete transcription regulator activity
REPLACED BY GO:0140110 transcription regulator activity
subset: goslim_plant

GO:0044460 obsolete flagellum part
subset: gocheck_do_not_annotate

GO:0097285 obsolete cell-type specific apoptotic process
subset: gocheck_do_not_annotate
@srengel  @tberardini  	@marekskrzypek @PruMM
Please create a new ticket if you would like further changes to your slim.
Thanks, Pascale


⚠ ClamAV has degraded performance

In 2df19ac, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 181 ms

Resolved: ClamAV performance has improved in 5a8a7b5.


Automator: update<EMAIL_ADDRESS>in<EMAIL_ADDRESS>

Generated by Automator - 2023-03-22T18:21:47+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio_release-1.17
777a2d959ff0238ee5cc213cbff45f463fff8305
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Unable to provision nodes in other zone types

I have a requirement to schedule some nodes in a local zone (In this case eu-north-1-cph-1a). I currently have the 1 self managed EKS node running in that zone, and Karpenter successfully starts up. However it cannot provision any new nodes through Karpenter.
Is there something with my config below that is preventing Karpenter from creating these nodes?
snippet of logs with the error and other startup info:
2023-12-05T20:07:33.976Z	DEBUG	controller.nodeclass	discovered subnets	{"commit": "56aaec1", "ec2nodeclass": "company-cluster", "subnets": ["subnet-id (eu-north-1-cph-1a)"]}
2023-12-05T20:07:34.025Z	DEBUG	controller.pricing	updated spot pricing with instance types and offerings	{"commit": "56aaec1", "instance-type-count": 730, "offering-count": 1013}
2023-12-05T20:07:34.135Z	DEBUG	controller.nodeclass	discovered security groups	{"commit": "56aaec1", "ec2nodeclass": "company-cluster", "security-groups": ["sg-id"]}
2023-12-05T20:07:34.189Z	DEBUG	controller.nodeclass	discovered kubernetes version	{"commit": "56aaec1", "ec2nodeclass": "company-cluster", "version": "1.28"}
2023-12-05T20:07:34.625Z	DEBUG	controller.nodeclass	discovered amis	{"commit": "56aaec1", "ec2nodeclass": "company-cluster", "ids": "ami-0bf75e19885e443e6, ami-09389d7cecdb39fba, ami-09389d7cecdb39fba, ami-0f6a90c148c8a59fd", "count": 4}
2023-12-05T20:07:34.730Z	INFO	controller.provisioner	pod kube-system/coredns-d9694c9bb-5758f has a preferred Anti-Affinity which can prevent consolidation	{"commit": "56aaec1"}
2023-12-05T20:07:35.199Z	DEBUG	controller.pricing	updated on-demand pricing	{"commit": "56aaec1", "instance-type-count": 361}
2023-12-05T20:07:35.281Z	DEBUG	controller.disruption	discovered instance types	{"commit": "56aaec1", "count": 361}
2023-12-05T20:07:35.403Z	DEBUG	controller.disruption	discovered offerings for instance types	{"commit": "56aaec1", "instance-type-count": 362}
2023-12-05T20:07:35.451Z	DEBUG	controller.provisioner	discovered availability zones	{"commit": "56aaec1", "zones": ["eu-north-1a", "eu-north-1b", "eu-north-1c"]}
2023-12-05T20:07:35.497Z	DEBUG	controller.provisioner	relaxing soft constraints for pod since it previously failed to schedule, removing: spec.affinity.podAntiAffinity.preferredDuringSchedulingIgnoredDuringExecution[0]={"weight":100,"podAffinityTerm":{"labelSelector":{"matchExpressions":[{"key":"k8s-app","operator":"In","values":["kube-dns"]}]},"topologyKey":"kubernetes.io/hostname"}}	{"commit": "56aaec1", "pod": "kube-system/coredns-d9694c9bb-5758f"}
2023-12-05T20:07:35.515Z	ERROR	controller.provisioner	Could not schedule pod, incompatible with nodepool "company-cluster-default", daemonset overhead={"cpu":"150m","pods":"2"}, no instance type satisfied resources {"cpu":"250m","memory":"70Mi","pods":"3"} and requirements karpenter.sh/capacity-type In [on-demand], karpenter.sh/nodepool In [company-cluster-default], kubernetes.io/arch In [amd64 arm64], kubernetes.io/os In [linux], node.kubernetes.io/instance-type In [m5.2xlarge t3.medium t3.xlarge], topology.kubernetes.io/zone In [eu-north-1-cph-1a], worker/type In [worker] (no instance type met the scheduling requirements or had a required offering)	{"commit": "56aaec1", "pod": "kube-system/coredns-d9694c9bb-5758f"}

The current EC2NodeClass I'm using:
apiVersion: karpenter.k8s.aws/v1beta1
kind: EC2NodeClass
metadata:
  annotations:
    karpenter.k8s.aws/ec2nodeclass-hash: "16078622133522205464"
  creationTimestamp: "2023-12-05T18:21:13Z"
  finalizers:
  - karpenter.k8s.aws/termination
  generation: 1
  name: company-cluster
  resourceVersion: "206265"
  uid: cfcc70f3-c41c-4b6b-a907-5002f92a5aae
spec:
  amiFamily: AL2
  blockDeviceMappings:
  - deviceName: /dev/xvda
    ebs:
      deleteOnTermination: true
      encrypted: true
      volumeSize: 80Gi
      volumeType: gp2
  instanceProfile: karpenter_node
  metadataOptions:
    httpEndpoint: enabled
    httpProtocolIPv6: disabled
    httpPutResponseHopLimit: 2
    httpTokens: required
  securityGroupSelectorTerms:
  - tags:
      karpenter.sh/discovery: company-cluster
  subnetSelectorTerms:
  - tags:
      karpenter.sh/discovery: company-cluster
status:
  amis:
  - id: ami-0bf75e19885e443e6
    name: amazon-eks-arm64-node-1.28-v20231116
    requirements:
    - key: kubernetes.io/arch
      operator: In
      values:
      - arm64
    - key: karpenter.k8s.aws/instance-gpu-count
      operator: DoesNotExist
    - key: karpenter.k8s.aws/instance-accelerator-count
      operator: DoesNotExist
  - id: ami-09389d7cecdb39fba
    name: amazon-eks-gpu-node-1.28-v20231116
    requirements:
    - key: kubernetes.io/arch
      operator: In
      values:
      - amd64
    - key: karpenter.k8s.aws/instance-gpu-count
      operator: Exists
  - id: ami-09389d7cecdb39fba
    name: amazon-eks-gpu-node-1.28-v20231116
    requirements:
    - key: kubernetes.io/arch
      operator: In
      values:
      - amd64
    - key: karpenter.k8s.aws/instance-accelerator-count
      operator: Exists
  - id: ami-0f6a90c148c8a59fd
    name: amazon-eks-node-1.28-v20231116
    requirements:
    - key: kubernetes.io/arch
      operator: In
      values:
      - amd64
    - key: karpenter.k8s.aws/instance-gpu-count
      operator: DoesNotExist
    - key: karpenter.k8s.aws/instance-accelerator-count
      operator: DoesNotExist
  instanceProfile: karpenter_node
  securityGroups:
  - id: sg-id
    name: company-cluster-node20231204200246985500000001
  subnets:
  - id: subnet-id
    zone: eu-north-1-cph-1a

The NodePool
apiVersion: karpenter.sh/v1beta1
kind: NodePool
metadata:
  annotations:
    karpenter.sh/nodepool-hash: "3030939166201481529"
  creationTimestamp: "2023-12-05T18:21:14Z"
  generation: 7
  name: company-cluster-default
  resourceVersion: "213646"
  uid: 136e5f9c-9a1e-4626-8954-97f296404582
spec:
  disruption:
    consolidationPolicy: WhenUnderutilized
    expireAfter: 720h
  template:
    metadata:
      labels:
        worker/type: worker
    spec:
      kubelet:
        evictionHard:
          memory.available: 200Mi
      nodeClassRef:
        name: company-cluster
      requirements:
      - key: node.kubernetes.io/instance-type
        operator: In
        values:
        - t3.medium
        - t3.xlarge
        - m5.2xlarge
      - key: karpenter.sh/capacity-type
        operator: In
        values:
        - on-demand
      - key: topology.kubernetes.io/zone
        operator: In
        values:
        - eu-north-1-cph-1a

Looks like no offerings are available for these requirements:
      requirements:
      - key: node.kubernetes.io/instance-type
        operator: In
        values:
        - t3.medium
        - t3.xlarge
        - m5.2xlarge
      - key: karpenter.sh/capacity-type
        operator: In
        values:
        - on-demand
      - key: topology.kubernetes.io/zone
        operator: In
        values:
        - eu-north-1-cph-1a

2023-12-05T20:07:35.515Z	ERROR	controller.provisioner	Could not schedule pod, incompatible with nodepool "company-cluster-default", daemonset overhead={"cpu":"150m","pods":"2"}, no instance type satisfied resources {"cpu":"250m","memory":"70Mi","pods":"3"} and requirements karpenter.sh/capacity-type In [on-demand], karpenter.sh/nodepool In [company-cluster-default], kubernetes.io/arch In [amd64 arm64], kubernetes.io/os In [linux], node.kubernetes.io/instance-type In [m5.2xlarge t3.medium t3.xlarge], topology.kubernetes.io/zone In [eu-north-1-cph-1a], worker/type In [worker] (no instance type met the scheduling requirements or had a required offering)	{"commit": "56aaec1", "pod": "kube-system/coredns-d9694c9bb-5758f"}

How did you create this issue without the standard template?

I wasn't sure if this should've been a bug report or not. I intended to ask a question to see if I did something wrong.

Looks like no offerings are available for these requirements:
      requirements:
      - key: node.kubernetes.io/instance-type
        operator: In
        values:
        - t3.medium
        - t3.xlarge
        - m5.2xlarge
      - key: karpenter.sh/capacity-type
        operator: In
        values:
        - on-demand
      - key: topology.kubernetes.io/zone
        operator: In
        values:
        - eu-north-1-cph-1a

2023-12-05T20:07:35.515Z	ERROR	controller.provisioner	Could not schedule pod, incompatible with nodepool "company-cluster-default", daemonset overhead={"cpu":"150m","pods":"2"}, no instance type satisfied resources {"cpu":"250m","memory":"70Mi","pods":"3"} and requirements
karpenter.sh/capacity-type In [on-demand],
karpenter.sh/nodepool In [company-cluster-default],
kubernetes.io/arch In [amd64 arm64],
kubernetes.io/os In [linux],
node.kubernetes.io/instance-type In [m5.2xlarge t3.medium t3.xlarge],
topology.kubernetes.io/zone In [eu-north-1-cph-1a],
worker/type In [worker]

(no instance type met the scheduling requirements or had a required offering)	{"commit": "56aaec1", "pod": "kube-system/coredns-d9694c9bb-5758f"}

I have played around with that node.kubernetes.io/instance-type label. by also setting it to karpenter.k8s.aws/instance-family and having the values be t3, m5. Going from the https://aws.amazon.com/ec2/pricing/on-demand/ listing the types I specified are available (The one node currently running is the t3.medium).
I tried going through the Karpenter code and around this part https://github.com/aws/karpenter/blob/f291dbab565d88f8ae9b207835b7637e90fccd5e/pkg/providers/instancetype/instancetype.go#L197 . it specifically filters out non-availability-zone values, as well as the input values before is just the standard blank https://github.com/aws/karpenter/blob/f291dbab565d88f8ae9b207835b7637e90fccd5e/pkg/providers/instancetype/instancetype.go#L191C61-L191C61, which would only take the actual availability zones (not the special ones). Not sure if this is intended

which would only take the actual availability zones (not the special ones). Not sure if this is intended

Yep, you're right. This wasn't intended and this will definitely filter out local zones.

Amazing. Thanks the quick turn around with this issue


Toggle Features Panel updates - using toggle button, examples hub button update, Examples Hub config update

Overview
Bugfix for #7872 Toggle Features Panel is missing toggle state.
ToggleFeaturesPanel.prefab has been updated
Bugfix for #7890 Input Recording button not working in MRTK Examples Hub
ToggleFeaturesPanelExamplesHub.prefab has been updated. Now ToggleFeaturesPanelExamplesHub.prefab only has 'Home' button to avoid duplicated overlapping with existing ToggleFeaturesPanel.prefab in each scene. When the user enters a scene from the Examples Hub menu, existing ToggleFeaturesPanel will be displayed along with Examples Hub's home button. Verified that Input Recording works properly using the ToggleFeaturesPanel's button in each scene.

Added a red color material for the Input Recording toggle state.
No GUID changes.
Build Settings for the MRTKExamplesHub scene has been updated since it was missing MRTKExamplesHub.unity scene in the list
Turned on Diagnostics since it is needed for the 'Profile' toggle button.
Turned on Spatial Awareness with occlusion only, added to MRTKExamplesHub config.

Changes

Fixes: #7872, fixes #7890, and fixes #7884

Screenshots
Updated ToggleFeaturesPanel.prefab

Displaying proper toggle state visual

Updated ToggleFeaturesPanelExamplesHub.prefab

When a scene loaded in MRTK Examples Hub

Adjusted the position of the ToggleFeaturesPanel in some example scenes to make it align with Examples Hub's Home button.

Started device testing.

Here is the app package for HoloLens 2, if you want to try:
https://1drv.ms/u/s!AndZlnlQdqyNo7Q2tsaOrzxcn5x5fw?e=6rzFWM

/azp run


内存溢出

for _, ch := range d.chans {
ch := ch
go func() {
defer func() {
recover()
}()
select {
case ch <- pairs:
case <-time.After(time.Minute):
log.Warn("chan is full and new change has been dropped")
}
}()
}

fixed


Make the site responsive.

Is your feature request related to a problem? Please describe.
The site is working properly on the desktop however breaks on a smaller screen.

Describe the solution you'd like

Improve the responsiveness of the site.
Design can be discussed if required.
Try to work with the given components while using flex-box or grid for mobile screen.

Can you please tell your approach to the solution? This is to reduce spam and encourage meaningful contributions.

Closing due to inactivity.


How to use ReactiveTextField / obscureText property with an icon to change the visibility?

Hello,
Before using "reactive_forms" I used "TextFormField" and I could manage "osbcureText" property like this:
...
  bool _isSecret = false;
  ...
            child: TextFormField(
              ...
              obscureText: this._isSecret,
              ...
              decoration: InputDecoration(
                  suffixIcon: InkWell(
                    onTap: () => setState(() => _isSecret = !_isSecret),
                    child: Icon(
                      !_isSecret ? Icons.visibility : Icons.visibility_off,
                    ),
                  ),
                  ...
              ),

When I clicked on the InkWell icon I could see the content of the field and the "icon" changed.
But now with "ReactiveTextField" I did not work anymore.
I think there is something to do similarly to this issue:
https://github.com/joanpablo/reactive_forms/issues/111
But I don't find the good way.
I tried:
              obscureText: MaterialStateProperty.resolveWith((state) {
                  return this._isSecret;
              }),

And I also tried this (according to this issue: https://github.com/flutter/flutter/issues/63089):
              obscureText: MaterialStateProperty.resolveWith<bool>((Set<MaterialState> state) {
                return this._isSecret;
              }),

But it does not work.
For thses codes I get this error:
The argument type 'MaterialStateProperty<bool>' can't be assigned to the parameter type 'bool'.dart(argument_type_not_assignable)

I continue to search but if someone thinks about a solution it would be nice :-)

Following this link https://api.flutter.dev/flutter/material/MaterialStateProperty-class.html I have just tried this:
...
  @override
  Widget build(BuildContext context) {
    ...
    bool getIsSecretValue(Set<MaterialState> state) {
      return _isSecret;
    }
    ...
    return Container(
      child: Row(
        children: [
          Expanded(
            child: ReactiveTextField(
              ...
              obscureText: MaterialStateProperty.resolveWith(getIsSecretValue),
              decoration: InputDecoration(
                suffixIcon: InkWell(
			onTap: () => setState(() {
			  _isSecret = _isSecret ? false : true;
			  return _isSecret;
			}),
			child: Icon(
			  _isSecret == false ? Icons.visibility : Icons.visibility_off,
			),
                ),
              ...

I still have this error:
The argument type 'MaterialStateProperty<bool>' can't be assigned to the parameter type 'bool'.dart(argument_type_not_assignable)

Why are you trying to use a MaterialStateProperty? obscureText is a bool, of course you get a type error.
This should work in the same way it did with the normal form field.

I don't really know why but with "ReactiveTextField" the method I explained did not work anymore.
obscureText does not take into account the new value of my variable "_isSecret" when I click on the "Icon" of the "InkWell" widget.

Then this is could be a bug in ReactiveFormField.

But yea, I am doing the same with 9.1.0 and it works. So it is probably a state problem on your end.

I use  the "ReactiveTextField" inside a StatefulWidget.
i added some logs to try to understand.
This is the current version of code:
...

class MyClassInputText extends StatefulWidget {
  final Function(int, String) onChangedStep;
  ...
  String _fieldType = "";
  final bool isSecret;
  ...

  const MyClassInputText({
    Key key,
    ...
    this.fieldType,
    this.isSecret,
    ...
    this.onChangedStep,
  }) : super(key: key);

  @override
  _MyClassInputTextState createState() {
    return _MyClassInputTextState();
  }
}

class _MyClassInputTextState extends State<MyClassInputText> {
  ...
  this._fieldTitle = widget.fieldTitle;
  bool _isSecret = false;
  ...

  @override
  Widget build(BuildContext context) {
    ...
    this._isSecret = widget.isSecret != null
        ? widget.isSecret
        : (this._fieldType == "password")
            ? true
            : this._isSecret;
    ...
    bool getIsSecretValue() {
      log("getIsSecretValue: _isSecret=$_isSecret");
      return this._isSecret;
    }

    return Container(
      ...
      child: Row(
        children: [
          Expanded(
            child: ReactiveTextField(
              ...
              obscureText: getIsSecretValue(),
              ...
              decoration: InputDecoration(
                contentPadding: EdgeInsets.all(this._padding),
                suffixIcon: (this._fieldType.toString().toLowerCase() == "password")
                    ? InkWell(
                        onTap: () => setState(() {
                          log("Secret - change - before='$_isSecret'");
                          // _isSecret = _isSecret ? false : true;
                          this._isSecret = !this._isSecret;
                          log("Secret - change - now='$_isSecret'");
                          return this._isSecret;
                        }),
                        child: Icon(
                          _isSecret == false ? Icons.visibility : Icons.visibility_off,
                        ),
                      )
                    : null,
                ...
              ),
            ),
          ),
        ],
      ),
    );
  }
}

When I click 2 times on the "InkWell" icon I get these logs:
[log] Secret - change - before='true'
[log] Secret - change - now='false'
[log] getIsSecretValue: _isSecret=true
[log] Secret - change - before='true'
[log] Secret - change - now='false'
[log] getIsSecretValue: _isSecret=true

So I see that:

the click change the value of the private variable _isSecret
the function getIsSecretValue() is called during the click
but the value returned by getIsSecretValue() is always "true" => so the "obscureText" property stay defined to "true"

I don't understand why the new value of "_isSecret" is not taken into account.

Can you please use  ```dart for code block so there is code highlighting.

You are basically always using widget.isSecret since you are checking that in the build function. You should move that to initState and didUpdateWidget.

yes I was thinking the rebuild of the widget make the value of "_isSecret" always to "true".
I'm going to see how to use "initState" or "didUpdateWidget".
I change my previous adding "```dart" :-)

Yes it works now!
I change my code like this:
  ...
  @override
  void initState() {
    super.initState();
    ...
    this._fieldType = widget.fieldType;
    ...
    if (widget.isSecret != null) {
      this._isSecret = widget.isSecret;
    } else {
      if ((this._fieldType == "password")) {
        this._isSecret = true;
      } else {
        this._isSecret = this._isSecret;
      }
    }
    ...
  }

  @override
  void didUpdateWidget(CiiFormInputText oldWidget) {
    super.didUpdateWidget(oldWidget);
  }

  @override
  void dispose() {
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {

    bool getIsSecretValue() {
      log("getIsSecretValue: _isSecret=$_isSecret");
      return this._isSecret;
    }
    ...

Many thanks!

This looks much better.
Depending on your use-case you may also check for changes on the Widget.
Maybe something like this:
  @override
  void didUpdateWidget(MyClassInputText oldWidget) {
    super.didUpdateWidget(oldWidget);
    if (widget.isSecret != oldWidget.isSecret && widget. isSecret != null) {
      this._isSecret = widget.isSecret;
    }
  }

This would happen if you change the isSecret flag from the outside.
Or you may also check for changes to fieldType, also depending on your use-case.

In your solution should I continue to implement "_isSecret" with the value of "widget.isSecret" in "build" function?
In my case that doesn't work, I've just tried this:
  ...

  @override
  void initState() {
    super.initState();
  }

  @override
  void didUpdateWidget(CiiFormInputText oldWidget) {
    super.didUpdateWidget(oldWidget);
    if (widget.isSecret != oldWidget.isSecret && widget.isSecret != null) {
      this._isSecret = widget.isSecret;
    }
  }

  @override
  void dispose() {
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    ...
    this._isSecret = widget.isSecret != null
        ? widget.isSecret
        : (this._fieldType == "password")
            ? true
            : this._isSecret;
    ...
    bool getIsSecretValue() {
      log("getIsSecretValue: _isSecret=$_isSecret");
      return this._isSecret;
    }
   ...

The function "getIsSecretValue" called during "onTap" action always returns "true".

OK I understand.
I'm self-training in Flutter so I'm still missing some basics I think :)
Thanks for your explanation that will help me I think!


datatypes.JSON not being interpreted correctly

Describe the bug
the representation of dataTypes.JSON from gorm for swagger json is not being handled correctly. dataTypes.JSON is basically json.RawMessage. I think since json.RawMessage is a byte-slice, the swagger doc generated defaults to an array of integers.
If I wanted it to be a map, or an array of strings, or any other valid JSON, what should I do?
To Reproduce
Steps to reproduce the behavior:
if you have a model like:
package model

import "gorm.io/datatypes"

type Model struct {
	MetaData
	SomeField     string         `json:"someField" gorm:"primaryKey"`
	JsonField        datatypes.JSON `json:"jsonField" gorm:"not null"`
	Approved      bool           `json:"-" gorm:"not null"`
}

swag generates a configuration for JsonField with default value is array of integers
Here JSONField is equivalent to fields which can be seen in the screenshot:

Expected behavior
I dont think array of integers should be a default. Don't know what should be the correct one... In my case I wanted it to be array of strings, so I edited the generated code.
Screenshots
If applicable, add screenshots to help explain your problem.
Your swag version
swag version v1.8.0

Your go version
1.17
Desktop (please complete the following information):

OS: macOS
Browser: edge
Version: Version 98.0.1108.62 (Official build) (arm64)

Additional context

I think it does not make sense to use any default-value like []string or []int anyways...
The closest swagger-conform value for datatypes.JSON would be
oneOf:

type: array
type: object

@BRO3886 you can use swaggertype to override the definition.


Add survey-per-participant stage

Fixes #314

LGTM; let's add some details and update the wiki about the new "Per-participant stage" also!

Btw, I removed the mute button and corresponding logic in this PR (obsolete now) but have noticed that it's reintroduced in this CL: https://github.com/PAIR-code/deliberate-lab/pull/324/files#diff-f37ad74fa77b8bc5fd11562a50df6e659bf43afcac385296c79ba77d9aa3c82dL63


Fix AUTO port expansion in module header

Before this patch, AUTO port expansion in module headers generates incorrect syntax, as port declarations are being separated by ;, which is only correct in module body. This change fixes that by choosing the correct delimiter based on the context.

Codecov Report
Base: 93.00% // Head: 93.00% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (58c1c01) compared to base (28d898d).
Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1728   +/-   ##
=======================================
  Coverage   93.00%   93.00%
=======================================
  Files         352      352
  Lines       25480    25488    +8
=======================================
+ Hits        23697    23705    +8
  Misses       1783     1783

Impacted Files
Coverage Δ

verilog/tools/ls/autoexpand.cc
96.77% <100.00%> (+0.04%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

If we do the repeat in the TestTextEditsWithProject() - shoudn't this catch invalid syntax as it builds a VerilogProject, which internally does a parse of the file ?

It does, but AUTO ports in module headers weren't tested.

I pushed an assert to check if the file was actually parsed.

Ha, LOL, so you already added some extra verification while I was writing my last message :)


Add support for tcp check type

These change build on @tzz's patch in #204, and adds full support for the tcp check type. I've updated both the check.pp manifest and the consul_validate_checks() parser function to properly support the type, as well as added tests that emulate the testing done for the other check types. If you need any changes made, or I missed something, let me know and I can update the branch.

Similar provided as well via #206, I'll merge these 2 together as you have some additional checks and docs.

@dbeckham I've merged your changes into #206 and we'll review and approve from that one.  I've preserved your commits so you will still get credit for the associated changes.

Awesome! Thanks for accepting my changes.


samples: Bluetooth: hci_uart: Add vendor specific HCI event generation for system fatal error

While using the hci_uart sample for Bluetooth conformance tests
it may happen that there is a system fault error.
Such errors are not visible in results of conformance tests.
Debugging of these errors is difficult and requires access to
testing hardware.
To enhance handling of such errors there is added a k_sys_fatal-
_error_handler that will log information about CPU state by use
of vendor specific HCI event.
Signed-off-by: Piotr Pryga<EMAIL_ADDRESS>

@ppryga will this PR be updated?

@cvinayak I plan to update it.

@Thalley  thanks for reminding me about it. I'll find a spot to finish it in coming weeks.


OS#17529874 - Skipping a nested deferred function containing a with statement can trigger load from invalid scope slot

When we use deferred stubs in the parser to skip past nested deferred functions, we need to be careful about nested functions containing with statements. Names referenced inside the with can't be pushed as ordinary references - we need to know that the symbols are referenced inside the with statement or not. This isn't possible with stubs currently so, instead, avoid skipping such nested functions.
Fixes:
https://microsoft.visualstudio.com/_workitems/edit/17529874

Does this mean that we'll need to take extra care when redeferring again, since not everything can be safely deferred? Or does the initial parse gather all the necessary information so these functions can be redeferred without issue?

@MSLaguana no, such functions can be deferred and redeferred normally. We just can't use the stub information to skip scanning them when undeferring their parent function.

Hm. This sounds suspicious to me. Captured names should be pushed as normal references regardless of the presence of with statements. We can discuss offline if you like.

We'll try to take a more holistic approach to a fix here which allows to skip nested functions containing with statements. Closing this PR for now.


Cannot compile Vc: make not working

I am trying to compile the master branch of Vc on my system but make is not working and not giving any erorrs.
cmake ran fine with the only missing things being Intel SDE not found and MIC SDK was not found!.
if I run:

$ ls
cmake  CMakeCache.txt  CMakeFiles  cmake_install.cmake  CTestCustom.cmake  Makefile
$ make
$

Then the prompt just returns nothing and no action is performed by make. Is the Makefile broken?

Thanks, I already confirmed that was the case.

For everything but releases, the all target includes building all unit tests. So, actually you should have gotten an hour long build... Note that master is going to change significantly soon. Stick with the 1.3 branch unless you're interested in contributing.
PS: Sorry for the late answer, vacation time...

I believe this issue can be closed, or did you expect any further action?


[Snyk] Upgrade cryptr from 6.0.2 to 6.2.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade cryptr from 6.0.2 to 6.2.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 3 versions ahead of your current version.
The recommended version was released 4 months ago, on 2023-03-06.

Release notes

Package name: cryptr

6.2.0 - 2023-03-06FEAT: Add TypeScript support (@ apstanisic #46)

6.1.0 - 2023-01-03
FEAT: added options object to allow custom saltLength (#32) and pbkdf2Iterations (@ GusRuss89 #42)

6.0.3 - 2022-04-18
CHORE: Fix spelling in readme #38 (@ LeoBadeaux)
FIX: Bump minimist from 1.2.5 to 1.2.6 #39

6.0.2 - 2020-04-026.0.2

    from cryptr GitHub release notes

Commit messages

Package name: cryptr

f250258 6.2.0
ab38020 Merge pull request #46 from apstanisic/add-types
2bf96f0 Add types
a8d22ba updated dev deps
a7bf7d5 6.1.0
0caae05 implement options object
b8a72b5 Merge pull request #42 from GusRuss89/make-key-iterations-configurable
4912dd4 Make key iterations configurable
b3e1310 6.0.3
4a6b889 Merge pull request #39 from MauriceButler/dependabot/npm_and_yarn/minimist-1.2.6
7671e39 Merge pull request #38 from LeoBadeaux/patch-1
22c5eb3 Bump minimist from 1.2.5 to 1.2.6
651ec4d Fix secret spelling
d35df1c Merge pull request #35 from MauriceButler/dependabot/npm_and_yarn/path-parse-1.0.7
2284a35 Bump path-parse from 1.0.6 to 1.0.7

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closed in favour of https://github.com/snyk/snyk-apps-demo/pull/82


Can't see the state

Hi there I really like ray with laravel and want to use it also for Vue and specially Vuex. I am using multiple stores as modules. In Ray, I can track the mutations but not the state. In ray Vuex state in an empty object.
Like:
VuexState {
"state": Object {},
}
Strange is that I can see the mutations and actions.
Help is highly appreciated.
Cheers,
Eric
This my vuex file:
import Vue from "vue";
import Vuex from "vuex";
import { RayVuexPlugin } from "vue-ray";
import * as auth from "@/store/modules/Auth";
import * as user from "@/store/modules/User/User";
import * as message from "@/store/modules/Message";
import * as usersingle from "@/store/modules/User/UserSingle";
import * as team from "@/store/modules/Team/Team";
Vue.use(Vuex);
export default new Vuex.Store({
strict: true,
modules: {
auth,
user,
message,
usersingle,
team,
},
plugins: [
RayVuexPlugin({
trackState: true,
logMutations: true,
trackingOptions: {
propNames: ["on*"],
},
}),
],
});
One off the modules
import { getError } from "@/utils/helpers";
import TeamService from "@/services/TeamService";
export const namespaced = true;
export const state = {
teams: [],
loading: false,
error: null,
status: null,
};
export const mutations = {
SET_TEAMS(state, teams) {
state.teams = teams;
},
SET_LOADING(state, loading) {
state.loading = loading;
},
SET_ERROR(state, error) {
state.error = error;
},
};
export const actions = {
getTeams({ commit }) {
commit("SET_LOADING", true);
TeamService.getTeams()
.then((response) => {
commit("SET_TEAMS", response.data.data);
})
.catch((error) => {
commit("SET_LOADING", false);
commit("SET_ERROR", getError(error));
})
.finally(() => {
commit("SET_LOADING", false);
});
},
setDefault({ commit }) {
commit("SET_LOADING", false);
commit("SET_ERROR", null);
commit("SET_TEAMS", []);
},
};
export const getters = {
teams: (state) => {
return state.teams;
},
loading: (state) => {
return state.loading;
},
error: (state) => {
return state.error;
},
};

Closed due to inactivity. Please open a new issue if you're still experiencing an issue. Thanks!


Recommending that people disable their firewall

I was reading the webserver tutorial on the website and was quite surprised to read that you "recommend this in 99% of the cases.". I personally find it dangerous to propose to people who have little experience in this sector of IT to "recommend to just disable the firewall, because it is easier.". This is just very bad practice in my opinion and I am curious to know why you would recommend this.

In "99% of the cases" it will only cause user frustration for an illusion of security. This is a site for tutorials about setting up web services and I don't want to have to nag people all the time and in every article about enabling this or that port that they need for whatever service they're going to be installing.
Vultr is pretty irregular in having a preinstalled firewall nowadays (this is new within the past month or so). I can tell from the emails I get that this is a huge confusion to people. I plan on having an article on firewalls, but I would rather this not be something of constant issue in every other article. If you take issue with my categoricalness of dismissing firewalls in the text, that's fine, I might remove it since I don't want extra security to sound "uncool."

Right, I can get into that. But I would just advise wording it differently. Ie. "Generally it is not recommended to disable your firewall, but for the purpose of this tutorial, it is easier to disable it. In the feature, we'll have a dedicated article on how to correctly set up a firewall."


DELIA-52693 : xcast reconnection improvements

Reason for change:
xcast reconnection improvements
Test Procedure: None
Risks: Low
Change-Id: I6115859ac2889a4fde43f6d3a618544df08b2588
Signed-off-by: Anooj Cheriyan<EMAIL_ADDRESS>

Closing older PRs. Please rebase and submit on latest sprint branch.


Implement mmd

Changes
Fix https://github.com/Qiskit/platypus/issues/978

This should be merged to make the tests work again: https://github.com/Qiskit/web-components/pull/118


Current limit throttling on i5 8250U

I have a Matebook X pro with i5 8250U, and under load lenovo-fix.py --monitor almost always shows current limit throttling. The only exceptions I found so far were stressing only a single core, or setting the power limit so low that the CPU is throttled by power instead of current limit. Both are not really useful...
In Windows (with help of throttlestop) I can reach full speed (3.4 GHz) on all cores without any throttling, package power can go up to 40 W. Core, cache and graphics current limits are set to default.
So the hardware is definitely capable of going without throttling
In Linux (Manjaro, Mint and Kubuntu) there always is this current limit throttling. There is definitely no power or thermal throttling.
While throttled the package power is between ~10 and 22 W, and temperatures are between 50 and 70 C.
Setting the HWP hint to performance instead of balance_performance makes throttling (subjectively) worse, increasing ICCMAX from default values does not help.
When poking around in the registers using msr-tools I noticed that "Electrical Design Point Status" is set to 1 while throttling occurs. This is in registers 6B0 (MSR_GRAPHICS_PERF_LIMIT_REASONS) and 6B1 (MSR_RING_PERF_LIMIT_REASONS), but not in 690 (MSR_CORE_PERF_LIMIT_REASONS).
Can I change this electrical design point limit somewhere? Or might this not be the actual cause for throttling?
Interestingly in one try I was able to reach the full 3.4 GHz on all cores without throttling in Kubuntu 18.04 (live), but since subsequent tries showed the "usual" current limit, it is probably really useful information...

Have you updated the BIOS since trying with Kubuntu? Sometimes manufacturers implement limits after releasing the product to avoid damage (due to insufficient design).
But assuming this is not the case, shat settings do you have for ICCMAX?

I did not update the BIOS since then, and using Windows 10 and throttlestop I can still get the package power up to 40 W.
ICCMAX is the default (64 A), setting all 3 available current limits to higher values does not help.
I noticed that if there is higher graphics power consumption reported using the --monitor option, trhottling starts at lower package power (using Intel GPU; nvidia available but switched off).
So e.g. if I run stress-ng, package power is at 22 W and I am limited by current. Now some transparent popup notification comes up and graphics power goes from 0.0 to around 2 W and package power decreases to 15 W (and CPU frequencies decrease). When the popup is gone, package power goes back to 22 W.
This is not reproducible using Windows 10, so it should be possible to somehow remove the limit.

It is possible there is a hard limit being imposed by the embedded controller. The "Electrical Design Point Status" is probably related to the design of the VRMs and other motherboard constraints, right?
Do you have the DPTF drivers installed on Windows?

Yes, as far as I understood you're right about the Electrical Design Point. But it is probably not really a hard limit, as that would also limit in Windows.
I have DPTF drivers installed on Windows.
When I install DPTF on Linux (using AUR) and enable the service, I see no change.

At least in Thinkpads, it seems the EC is reading from a "lap detector" and since Linux doesn't implement it, the EC limits the temperature to 75C or 80C. It is possible that something similar is happening (EC can't see VRM mosfet sensors, limits current forcefully, or something).
A recent merge on master added the option to disable the BD_PROCHOT flag, this might help.
I actually don't know exactly how well does the DPTF work on Linux. Apparently you'd need to extract the tables using dptfxtract first, but I used it without and it did set my temp limit to 97C.
Another think you could try is set your power UUID. I have modified a script that has been floating around here: set-power-uuid.sh
If none of these work, your best bet would be Huawei's support forums, but I doubt they'll provide any support for Linux (even Lenovo has been very slow/reluctant to solve the problem in Thinkpads). Sorry, I wish I could help more.

The script reports success, but does not change anything regarding the throttling
Disabling BD_PROICHOT also does not help.
After installing thermald and dptfextract I have 2 files in /etc/thermald
thermal-conf.xml.auto
<?xml version="1.0"?>
 <!-- BEGIN -->
 <ThermalConfiguration>
 <Platform>
	<Name> Auto generated </Name>
	<ProductName>MACH-WX9</ProductName>
	<Preference>QUIET</Preference>
	<ThermalZones>
	</ThermalZones>
</Platform>
</ThermalConfiguration>
<!-- END -->

thermal-cpu-cdev-order.xml
<!--

Specifies the order of compensation to cool CPU only.
There is a default already implemented in the code, but
this file can be used to change order

The Following cooling device can present
-->
<CoolingDeviceOrder>
<!--  Specify Cooling device order  -->
<CoolingDevice>rapl_controller</CoolingDevice>
<CoolingDevice>intel_pstate</CoolingDevice>
<CoolingDevice>intel_powerclamp</CoolingDevice>
<CoolingDevice>cpufreq</CoolingDevice>
<CoolingDevice>Processor</CoolingDevice>
</CoolingDeviceOrder>

The QUIET preference from the 1st file could be the problem... I have no idea about thermald, can I just change this to something like POWER or PERFORMANCE and then (re)start the thermald service?

I think the right one is "PERFORMANCE", but thermald seems to interfere with throttled. No clue what would be the best way to address this. ):

I tried changing it to PERFORMANCE and also renaming the file from thermal-conf.xml.auto to thermal-conf.xml (restarting thermald after every change), but it did not help...

Small update: with a recent BIOS update the package power is limited to ca 25 W instead of 22.
So some small improvement, but still not enough to allow the full 3.4 GHz (and still much reduced package power when the GPU is active, e.g. for transparency effects). Still there actual limit is current and
So it looks like BIOS has some influence, maybe this can be used...
I tried adding add acpi_osi="Windows 2015" acpi_osi=! to GRUB_CMDLINE_LINUX_DEFAULT (from http://arter97.blogspot.com/2018/08/saving-power-consumption-on-laptops.html ) to make the BIOS think I'm using Windows, but unfortunately there is no improvement.


Pielou's Evenness can produce nan, causing downstream exceptions

Bug Description
Pielou's Evenness returns nan when a sample vector composed of a single feature is presented. At present, this gets represented as the empty string in the resulting output, and is re-represented as a nan in QIIME.
Downstream consumers of these data (e.g., alpha-group-significance) raise a divide by zero error when presented with these data (not show in the example below).
Steps to reproduce the behavior
In [13]: import qiime2

In [14]: import pandas as pd

In [15]: import skbio

In [16]: adiv = pd.Series([skbio.diversity.alpha._base.pielou_e(v) for v in ([0,1,2,3], [0,1,0,0], [1,2,3,0])],
    ...:                  index=['foo', 'bar', 'baz'])
    ...:

In [17]: adiv
Out[17]:
foo    0.92062
bar        NaN
baz    0.92062
dtype: float64

In [18]: ar = qiime2.Artifact.import_data('SampleData[AlphaDiversity]', adiv)

In [19]: reloaded = ar.view(pd.Series)

In [20]: reloaded
Out[20]:
foo    0.92062
bar        NaN
baz    0.92062
Name: 0, dtype: float64

Expected behavior
It's not clear yet whether this is the correct behavior.
Comments
After internal discussion, we thought it made sense to first open an issue here with q2-diversity as it is an open question whether we should allow nan in the output, whether consumers should be expected to gracefully handle these data, or whether this represents a bug in scikit-bio's Pielou's Evenness implementation.
This is an unusual pathological case, as it is unusual for a sample to contain only a single feature. However, this scenario arose on two independent executions of the C. diff FMT QIIME2 tutorial so it does appear to possible to occur with real data.

BTW, a Qiita user hit this issue yesterday while using core diversity analysis.

q2-diversity-lib offers a _drop_undefined_samples utility, and this behavior is already wired up in the pielou_evenness implementation there. Undefined samples are not dropped by default, preferring to let users make that choice actively.
IIRC, our original decision not to expose this parameter in alpha and core-metrics was just about API simplicity. I suspect wiring it up would be pretty easy if we decide there's value in doing so.

Good to know. IMOO it will be better to have that flag default to True (drop) as I'm not aware of any direct utility of keeping the Nones in the results but I might be missing something ... thoughts?


[AutoPR] imagebuilder/resource-manager

Created to accumulate context: imagebuilder/resource-manager

(message created by the CI based on PR content)

@lmazuel, is the python sdk link automatically updated when commits are added to the repo?


Fix async for Flask 2.0

Add ensure_sync wapper in dispatch_requeset.
Checklist:

[x] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[x] Add an entry in CHANGES.md summarizing the change and linking to the issue and your username.
[ ] Run pytest and tox, no tests failed.

Codecov Report

Merging #50 (94f3678) into master (ce81270) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           14        14
  Lines          807       807
  Branches       147       147
=========================================
  Hits           807       807

Impacted Files
Coverage Δ

apiflask/app.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce81270...94f3678. Read the comment docs.


create_two_resistor_network_block bug

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
create_two_resistor_network_block function fails
Steps To Reproduce
N/A
Which Operating System are you using?
Windows
Which Python version are you using?
3.9
Installed packages
N/A

@wilove997  What is the scenario where the function fails?


test: Use crawler's assert methods

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 77.941%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
106

Relevant Lines:
136

💛  - Coveralls


Merge current v2.6 into master

What does this PR do?
Merge current v2.6 into master.
Motivation
Be synced.

Declined


Support TLS 1.2

PowerShell by default uses TLS 1.0 for all Rest API requests, which is vulnerable to POODLE and other crypto vulnerabilities. Applying this change will force supporting TLS 1.2 and prevent having the following error:
The request was aborted: Could not create SSL/TLS secure channel.

This update also (permanently) fixes #358, which worked on Azure portal since TLS 1.2 is already supported there.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.build.ps1
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks for reporting @zshehri! This is a build script used by our docs platform, so I'm going to refer this to them. I'm hesitant to accept an PR's to the script itself until we know it doesn't break the docs build :).

Sure, makes sense!
I wanted to create some sanity checks around this change to avoid heck-ups, but didn't want to mess up with your neat syntax 😄.
Maybe something like this would be more appropriate (this will make TLS 1.2 supported for older versions, but won't enforce it):
    # Adding TLS 1.2 support
    # https://docs.microsoft.com/en-us/dotnet/api/system.net.securityprotocoltype?view=netcore-2.0#System_Net_SecurityProtocolType_SystemDefault
    try {
        if ($PSVersionTable.PSVersion.Major -lt 6 -and [Net.ServicePointManager]::SecurityProtocol -notmatch 'Tls12') {
            Write-Verbose -Message 'Adding TLS 1.2 support'
            [Net.ServicePointManager]::SecurityProtocol += [Net.SecurityProtocolType]::Tls12
        }
    }
    catch {
        Write-Warning -Message 'Adding TLS 1.2 to supported security protocols was unsuccessful.'
    }

Feel free to modify it as you like. 😉

As an update, I reported this to our docs platform engineering folks. They confirmed that the script they use on their build servers already has a similar change to use TLS 1.2, so our CI build processes at least are doing the right thing. Essentially the script that's in this repo is only used if someone clones the repo and then does a local build for some reason :)
Thank you for bringing this up and contributing!


Migrate extra DSpace-CRIS "Live Import" sources to DSpace core

DSpace-CRIS (built/maintained by 4Science) has a number of Live Import sources which are not yet available in DSpace core.
These may include:

Scopus
CrossRef
CiNii
NASA/ADS
Web of Science
VuFind
OpenAIRE (by Author and Title)

If possible, we should work with the 4Science team to contribute these back to core code, so that they can be available to and maintained by the entire DSpace community.
This can also benefit upcoming features which also build on Live Import / External Sources, like https://github.com/DSpace/DSpace/issues/2834 and https://github.com/DSpace/DSpace/issues/2833

All, I talked with @abollini and @atarix83 today about this task.
@abollini noted that anyone is welcome to port code from DSpace-CRIS to DSpace at any time.   DSpace-CRIS is open source and follows the same license as DSpace.  4Science only asks that they be credited with the initial development of any  feature ported from DSpace-CRIS.
At this time, the 4Science team noted this task is unfortunately lower priority for them right now, as they are worried it'd distract from their ability to help build & review other important 7.1 features.  This is why they wanted to make it clear this task doesn't need to rely on 4Science, but that anyone is welcome to port over code as they see fit.  These "Live Import" sources likely can be ported over rather easily as they are mostly "standalone" and likely don't need 4Science support in doing so.
Therefore, I'm un-assigning this from @atarix83 for now.  I'll leave it on our 7.1 board as a task that we may still want to try to fit into 7.1

I don't know if it will help, but I've made a contribution to OpenAIRE model library (PR: https://github.com/openaire/openaire-funders-jaxb-model/pull/2):
https://search.maven.org/artifact/eu.openaire/funders-model
I only test it for funding, but this library supports full OpenAIRE model (even results, organizations). I don't know what 4Science it's using as a library to support OpenAIRE model on DSpace-CRIS, but I suggest the usage of openaire library.

We have reviewed which connectors are currently available in DSpace-CRIS but not in DSpace, below the list

ADSImportMetadataSourceServiceImpl
ArXivImportMetadataSourceServiceImpl
CiniiImportMetadataSourceServiceImpl
CrossRefImportMetadataSourceServiceImpl
EpoImportMetadataSourceServiceImpl
PubmedEuropeMetadataSourceServiceImpl
PubmedImportMetadataSourceServiceImpl
ScieloImportMetadataSourceServiceImpl
ScopusImportMetadataSourceServiceImpl
VuFindImportMetadataSourceServiceImpl
WOSImportMetadataSourceServiceImpl
**- OpenAireImportMetadataSourceServiceImpl
OpenAireProjectImportMetadataSourceServiceImpl
OrcidPublicationDataProvider**

The OpenAIRE connectors will be excluded by this activity as they would require discussion about which approach should be used, in DSpace-CRIS they are based on the Live Import Framework but in DSpace 7.1 the Project import was included according to a different custom implementation based on the openaire data model library see https://github.com/DSpace/DSpace/pull/3365#pullrequestreview-778824482
The ORCID Publication import will be excluded as it can be better addressed in the scope of a porting of the DSpace-CRIS ORCID features.
The estimation to port the resulting 11 connectors is about 48 hours.
Please note that this estimation include

porting of the feature/code as is applying code cleanup if required but without major redesign work that can happen in a subsequent PR
adding javadoc where missing as required by our community policies
integration test for WOS, Scopus, EPO will interact with the live service requiring real apikey to be executed. Without api key the test will be skipped. We can provide test based on mock service but license rights to include such mock data should be obtained/verified by Lyrasis
adding integration test based on mocking the external service for the other open providers

@tdonohue we were almost ready to open the PR for this issue but we have decided to rebase it on top of your PR https://github.com/DSpace/DSpace/pull/8222 as most of the connector were based on AXIOM.
I can anticipated a little extra effort on this task about 12-16 hour

@abollini : That makes sense. I'll add it to the existing estimate.  PR #8222 has now been merged, so it should be easier to rebase against latest main.


[stress testing] Create bash and pwsh exportable env files

Currently we only generate a dotenv format env file with all the relevant stress secrets. In some cases, it would be useful for higher level scripts to have access to these variables (e.g. loading the app insights java agent). For example, a /mnt/outputs/.bashenv file that has export statements.

Closing.  @benbp says it's not worth the complexity. :)


refactor generating uuid4 to not using boost lib

Codecov Report
Patch coverage: 100.00% and project coverage change: +1.60 :tada:

Comparison is base (e30f8f5) 97.83% compared to head (2856380) 99.43%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   97.83%   99.43%   +1.60%
==========================================
  Files          15       15
  Lines         507      533      +26
==========================================
+ Hits          496      530      +34
+ Misses         11        3       -8

Impacted Files
Coverage Δ

src/String.cpp
100.00% <100.00%> (ø)

src/StringTest.cpp
100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


What is the difference from http-problem-details

What is the actual difference with https://github.com/PDMLab/http-problem-details and should I use it instead?

http-problem was the first approach to implement RFC7807. It is still there because it is used in several projects. http-problem-details is a more recent implementation with extensibility in mind. Most efforts will be put in this one but if somebody sends a PR for the old implementation it is likely it’ll be merged as well.
So if you’re not using an RFC7807 library right now, I would recommend http-problem-details and its downstream libraries.

Thank you Alex, would you consider adding this note to the description as well?

@ackvf Done, see #26


Update python Getting Started docs to include metrics

Tracking in https://github.com/open-telemetry/opentelemetry-python/issues/2732
This updates the Getting Started documentation for python with metrics instrumentation and the output of commands with metrics added.

I'll be OOO for the next few weeks. Feel free to push any suggested changes to my branch and get this merged 🙂

@cartermp - any comments?

@aabmass - could you rebase (resolve the conflict) and resubmit?

All done!


maps sometimes out of order

https://www.mustad.io/tournament_1582335058217/red/blue
tourney map listing sometimes gets out of order.
2nd and 3rd fight maps are swapped.
4th and 5th fight maps are swapped.

actual map order should be

I think I know the fix for this and it should be pretty straightforward. I'm not ordering the maps query so I'm just counting on the natural order from the db being correct.

I've pushed a fix for this to master and it should get deployed to staging soon. I don't think it'll be a destructive change so I'll push it to prod soon. Let me know if you observe any other tournaments that load maps improperly.


support passing context as None

For convenience reasons one may pass an empty (e.g. test) context of value None instead of {}

I made some small improvements.
Are you fine with that?


Add Templating Options for Playbooks

I was recently recommended by @lritter to consider using this tool for some adhoc queries we need to run regularly and I ended up really liking it. Simple, clean, functional, we're already snowplow users and a perfect match.
But I wasn't happy with the idea of all of my hosts and password being hosted along with the playbooks, so to fix this I changed it so that the -var flag will pass into a playbook similar to the way it does for sql templates, then we can get our passwords out of local config without worrying the tool.
I also found out that based on:
https://github.com/snowplow/sql-runner/blob/master/sql_runner/options.go#L28-L36
there's a limit of only a single key=value pair in the -var flag, I extended this so that it will load any number of vars via comma separation (key=value,key2=value2)
Pretty new to go, please do pick it apart.

Coverage increased (+0.7%) to 33.247% when pulling 6bfca22cb3482139ba2c2ff26b219233dd922b75 on dannymc129:master into 0ae72da4357bd7627eda99602d0139faaf437d06 on snowplow:master.

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

Coverage increased (+0.7%) to 33.247% when pulling bd704b2dfd987bfa2a59bba13ed575ce89d7b77e on dannymc129:master into 0ae72da4357bd7627eda99602d0139faaf437d06 on snowplow:master.

Coverage increased (+0.7%) to 33.247% when pulling bd704b2dfd987bfa2a59bba13ed575ce89d7b77e on dannymc129:master into 0ae72da4357bd7627eda99602d0139faaf437d06 on snowplow:master.

I signed it!

Coverage increased (+0.6%) to 33.161% when pulling e00c7179cb441b6dd9a26e0f208409f5a07e4029 on dannymc129:master into 0ae72da4357bd7627eda99602d0139faaf437d06 on snowplow:master.

Confirmed! @dannymc129 has signed the Individual Contributor License Agreement. Thanks so much


Abort on missing required GL extension, fix #348

Abort on missing required GL extension, fix #348
I would appreciate comments on error message wording.

travis failure is a travis issue


Add precompilation

These changes introduce precompilation to YT.jl.
It is also now no longer necessary to depend on SymPy.jl.
Tests on Julia 0.6 will fail due to a PyCall.jl bug (Issue https://github.com/JuliaPy/PyCall.jl/issues/332, which will hopefully be fixed by https://github.com/JuliaPy/PyCall.jl/pull/333).

Coverage decreased (-0.9%) to 93.784% when pulling cc78487c770cbdc5d576a544fe300d244ca31b13 on precompile into d49b05f058ae2c09cb2a9719829ec424590f39fe on master.

Coverage decreased (-0.9%) to 93.784% when pulling fe316f65d3f4507b2797f20909545fe1a62ce1bd on precompile into d49b05f058ae2c09cb2a9719829ec424590f39fe on master.

Coverage decreased (-0.8%) to 93.829% when pulling 7e6e66b169038aad8e6e3486e7ea9672106e9ff3 on precompile into d49b05f058ae2c09cb2a9719829ec424590f39fe on master.

Coverage decreased (-1.02%) to 93.659% when pulling 4275254aaaa8536dc716483f8305acaa301483f7 on precompile into d49b05f058ae2c09cb2a9719829ec424590f39fe on master.

Coverage decreased (-1.7%) to 92.986% when pulling c31ec63be370d8cea3fe4ce531848d3cdeeb5b86 on precompile into d49b05f058ae2c09cb2a9719829ec424590f39fe on master.

Coverage decreased (-1.7%) to 92.986% when pulling 64a371b7becaabfe580d2600f620e6b246cb7b4a on precompile into d49b05f058ae2c09cb2a9719829ec424590f39fe on master.

Coverage decreased (-1.7%) to 92.986% when pulling ce36dce8052251de0d05cde066e6561f1faaa770 on precompile into d49b05f058ae2c09cb2a9719829ec424590f39fe on master.

Coverage decreased (-1.7%) to 92.986% when pulling c5475c6dce75cc9670625ee56a6f7456816b820f on precompile into d49b05f058ae2c09cb2a9719829ec424590f39fe on master.

Coverage decreased (-1.7%) to 92.986% when pulling c5475c6dce75cc9670625ee56a6f7456816b820f on precompile into d49b05f058ae2c09cb2a9719829ec424590f39fe on master.

Coverage decreased (-1.4%) to 93.321% when pulling beb00a9867cb4cf44404c5773ee2f18ef2a1022d on precompile into d49b05f058ae2c09cb2a9719829ec424590f39fe on master.

Coverage decreased (-0.7%) to 94.0% when pulling f3680c40b9c8ec9e9422eaaf64bdb18bfa5e5e15 on precompile into d49b05f058ae2c09cb2a9719829ec424590f39fe on master.

Coverage decreased (-0.7%) to 93.989% when pulling f3680c40b9c8ec9e9422eaaf64bdb18bfa5e5e15 on precompile into d49b05f058ae2c09cb2a9719829ec424590f39fe on master.


Treat index id as auto-generated field

Let's fix #25 and #28 in this PR as well since they're all related to File Index.

fix #28


V4 diagrams

New updates.  (Also made a change so that the client gets the latest loaded snapshot not the latest snapshot)
`from aioipfabric.mixins.diagramsV4 import IPFDiagramPathMixin
ipf = IPFDiagramPathMixin()
ipf.svg = True # For SVG instead of JSON
loop.run_until_complete(ipf.login())
path = loop.run_until_complete(ipf.path_unicast_lookup('<IP_ADDRESS>', '<IP_ADDRESS>', 'tcp'))
path = loop.run_until_complete(ipf.path_host_to_gateway('<IP_ADDRESS>'))
path = loop.run_until_complete(ipf.path_multicast_lookup('<IP_ADDRESS>', '<IP_ADDRESS>', 'tcp'))
loop.run_until_complete(ipf.logout())`

Will add examples if you think this looks better.

@justinjeffery-ipf - thank you for your contribution!

merged and published on pypi.


v.3.3.1 does not install at loginwindow

Installation of Crypt 3.3.1 via Munki fails if the machine is at the loginwindow. This has been tested on a 10.12.6 VM and a 10.13.3 MacBook Air.
If installation starts at the loginwindow (for example, as part of a Munki bootstrap workflow), the MSC GUI is displayed as normal. After installation begins, there is a brief flash of black, and the MSC run restarts. The MSC GUI displays "Starting...", while ManagedSoftwareUpdate.log loops with the message Another instance of managedsoftwareupdate is running as pid.... Clicking "Stop" has no effect.
I've successfully tested installing Crypt v.3.1.0 at the loginwindow.

I was able to replicate this on a 10.12.6 MBA. Worked fine when installing in the GUI, but got the black screen flash when installing at the loginwindow. I logged back into the machine and ran managedsoftwareupdate to see the Another instance of managedsoftwareupdate is running message. v3.1.0 worked fine for me on the loginwindow as well.

@andrewvalentine I'm assuming you mean you're having trouble with v3.1.1, not 3.3.1, as that version doesn't exist.

@weswhet Ha...yes. Apologies. Numbers are hard.

Fixed by #74. New release should be out soon. Please re-open if not fixed.


arch: imxrt: Fix ethernet configuration in Kconfig

Summary

Fix typo in Kconfig so that we can configure IMXRT_ENET_NRXBUFFERS.

Impact

imxrt family with ethernet configuration

Testing

imxrt1060-evk:netnsh

Hmmm,
There are build errors in esp32-core:netnsh which is not affected by this PR.

Cleaning...
Configuring...
Building NuttX...
Normalize esp32-core/netnsh
30d29
< CONFIG_MAX_WDOGPARMS=2
Saving the new configuration file
HEAD detached at pull/1527/merge
Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git checkout -- ..." to discard changes in working directory)
modified:   boards/xtensa/esp32/esp32-core/configs/netnsh/defconfig

Hmmm,
There are build errors in esp32-core:netnsh which is not affected by this PR.
Cleaning...
Configuring...
Building NuttX...
Normalize esp32-core/netnsh
30d29
< CONFIG_MAX_WDOGPARMS=2
Saving the new configuration file
HEAD detached at pull/1527/merge
Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git checkout -- ..." to discard changes in working directory)
modified:   boards/xtensa/esp32/esp32-core/configs/netnsh/defconfig

I've just sent a new PR to fix.
https://github.com/apache/incubator-nuttx/pull/1528

Hmmm,
There are build errors in esp32-core:netnsh which is not affected by this PR.
Cleaning...
Configuring...
Building NuttX...
Normalize esp32-core/netnsh
30d29
< CONFIG_MAX_WDOGPARMS=2
Saving the new configuration file
HEAD detached at pull/1527/merge
Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git checkout -- ..." to discard changes in working directory)
modified:   boards/xtensa/esp32/esp32-core/configs/netnsh/defconfig

I've just sent a new PR to fix.
https://github.com/apache/incubator-nuttx/pull/1528

It's merged now. Feel free to rebase this one and it should pass.

@btashton
Thanks, the check build passed.


Initial implementation for #5360.  Enhances the CREATE Property syntax.

Unit tests seem to be passing for #5360

This is failing due to what appears to be a JVM crash during the JDBC driver build.  The build works fine locally for me.  I can't imaging how this would have affected the JDBC driver.  There are several other PRs that are failing due to the same error, so I am confident this PR is actually clean.

@luigidellaquila Please check the PR ;-)

I noticed that there was a lot of stuff merged into develop, so I re-merged this branch so it can be merged.

Hi @mmacfadden
The PR seems to be ok.
One of the test cases is for LiveQuery (not related at all with your commit), I'm fixing it and then I'll rebuild you PR on Travis.
Thanks

@luigidellaquila Thanks. Let me know if there are any issues, and I will address immediately.

I just merged the latest code.  It seems like there is still an issue with the JDBC driver tests.

Any updates on this pul request?

Hi @mmacfadden
I merged it, thank you very much!
The CI keeps failing for reasons that are completely unrelated to your PR
Thanks a lot!
Luigi


Add some additional text for API Key

Adds some additional text:

Direct the user to the OpenAI website to get an API Key
Placeholder text on the API Key input itself

great for UX


Add a passthrough for the ref prop

I need access to the DOM element to manage scroll position in a chat-style application. This PR adds a simple passthrough for ref

Turns out my need for a ref passthrough was based on a misunderstanding. I thought InfiniteScroll's node had the overflow.
Nevertheless, this could be useful for someone.

Had the same thing come in to question the other day but with the className prop. All props that aren't on the list on L43 are passed through to the rendered div. ref should be no different.

ref is different, since you override it explicitly. Either way, I don't need it anymore.

Published in 1.0.15. Didn't merge this PR as it's got some weird changes in dist and whitespace in src.


Update Arbitrum upgradeability risk factor

Arbitrum One and Arbitrum Nova are now both owned by the Arbitrum DAO, which has a 13 day delay on upgrades going through after approval. However, there is a 9/12 security council multisig that can make instant upgrades, as noted here.

Thanks for the PR! As it is a significant update, we'll handle it in https://github.com/l2beat/l2beat/pull/1300


Great Work Stanley

The animation slides up as I scroll.

Thank you for spotting this issue, I have fixed it.

Thank you for spotting this issue, I have fixed it.


Bug report - user not able to comment, "Not a valid email address"

Sharing a bug report from GZ Talk.
https://www.zooniverse.org/projects/zookeeper/galaxy-zoo/talk/1268/1689709?comment=2743474&page=1

I can classify the galaxy but when it comes to putting a comment on I get this: You must have a valid email address in order to contribute to Conversation. Nothing has changed I still have the same email etc.

User reports as signed in and with same email address as always. Seems like a Talk bug so raising an issue here.

Looks like the specific invalid email attribute for the user was fixed manually by the team see, https://www.zooniverse.org/projects/zookeeper/galaxy-zoo/talk/1268/1689709?comment=2744755
I think the issue here is the following:

user has an invalid email for their account
system attempts to send an email
email bounces or is complained about by a user
bounce / complaints handler123 marks the user email as invalid
user updates email to a valid address
system still thinks the user has an invalid email

I believe the solution to this above is reset the valid_email user attribute to true when the user email attribute is changed and allow the email bounce/complaint handler to handle any issues, https://github.com/zooniverse/email-verify.
1https://github.com/zooniverse/email-verify/blob/e81cb257e5f9cbb0946bf71ca5838395a0fe6a6f/server.coffee#L31
2https://aws.amazon.com/blogs/messaging-and-targeting/handling-bounces-and-complaints/
3https://docs.aws.amazon.com/ses/latest/DeveloperGuide/notification-examples.html

Looks like the specific invalid email attribute for the user was fixed manually by the team see, https://www.zooniverse.org/projects/zookeeper/galaxy-zoo/talk/1268/1689709?comment=2744755
I think the issue here is the following:

user has an invalid email for their account
system attempts to send an email
email bounces or is complained about by a user
bounce / complaints handler123 marks the user email as invalid
user updates email to a valid address
system still thinks the user has an invalid email

I believe the solution to this above is reset the valid_email user attribute to true when the user email attribute is changed and allow the email bounce/complaint handler to handle any issues, https://github.com/zooniverse/email-verify.
1https://github.com/zooniverse/email-verify/blob/e81cb257e5f9cbb0946bf71ca5838395a0fe6a6f/server.coffee#L31
2https://aws.amazon.com/blogs/messaging-and-targeting/handling-bounces-and-complaints/
3https://docs.aws.amazon.com/ses/latest/DeveloperGuide/notification-examples.html

Closing -- specific issue was due to https://github.com/zooniverse/Panoptes-Front-End/pull/5799, which was reverted in https://github.com/zooniverse/Panoptes-Front-End/pull/5833. Note that while valid_email check is not used anymore, email confirmation check is now executed -- see https://github.com/zooniverse/talk-api/pull/313.


Validation of the download links: recommendation

Hi guys,
Is there a way how to validate (check) the download links on the page using Seleno?
After a click on the download link there will be a Download window open (in case if the url is valid).
How to test it in a simple way? I Don't need to download the files in terms of automation, just need to be sure that link is valid and user can download any file.
I'm using Seleno + BDDfy, c#.
Thank you for the suggestions!

You could pull out the value of the href attribute and do a HEAD request to that URL and check for a 200 response using HttpClient?

robdmoore, yes, it makes sense.
I've found some solution for that, but it is not working as expected and I cannot understand what Im doing wrong.
Here a piece of code inside my page object:
        public bool DoesTheFileExistRemotely()
        {
            var request = (HttpWebRequest)WebRequest.Create(UriToImage);
            request.Method = "HEAD";

            try
            {
                using (var response = (HttpWebResponse)request.GetResponse())
                {
                    if (response.StatusCode == HttpStatusCode.OK)
                    {
                        return true;
                    }
                    return false;
                }
            }
            catch (WebException) { return false; }
            catch
            {
                return false;
            }
        }

        public string UriToImage
        {
            get
            {
                return Find.Element(By.XPath(DownloadLinkXpath)).GetAttribute("href");
            }
        }

        private const string DownloadLinkXpath = "(//*[@class='media-download'])[1]";

Here my test:
....
       public void Then_I_will_be_able_to_download_the_file()
        {
            _varOfMyPage.DoesTheFileExistRemotely();
        }

The problem is that a test is passed no matter what I'm putting inside the DoesTheFileExistRemotely() method, and I need to check not only the HttpStatusCode.OK, but also that the URL will not be http://my.site/system/notfound404 (because if the url in my case is not correct the response will be with StatusCode = OK, but I'll get the page notfound404)
How I can write it correctly?

The doesTheFileExistRemotely method returns a Boolean. If you want the test to fail you need to assert it returns true.
Presumably your 404 page either has a return code of 404 in which case your code will already work, or it will have a redirect to your 404 page in which case you can check the Location header on the response.

Ohh, you are definitely right, it's my fault, I just called the method instead of having Assert :)
Assert.That(_varOfMyPag.DoesTheFileExistRemotely().Equals(true));

I'm a bit stuck, because I don't know what exactly I can use in case of redirecting to the 404 page (it returns response.StatusCode == HttpStatusCode.OK).
Do you know how to check the Location header on the response in my DoesTheFileExistRemotely() method?

try looking for response.Headers["Location"]

Unfortunately, it returns in both cases (for a valid link and link that redirects to the 404 notfound page) false:
public bool DoesTheFileExistRemotely()
        {
            var request = (HttpWebRequest)WebRequest.Create(UriToImage);
            request.Method = "HEAD";

            try
            {
                using (var response = (HttpWebResponse)request.GetResponse())
                {
                    if (response.StatusCode == HttpStatusCode.OK)
                    {
                        if (response.Headers["Location"].Contains("not found"))
                        {
                            return false;
                        }
                        return true;
                    }
                    return false;
                }
            }
            catch (WebException) { return false; }
            catch
            {
                return false;
            }
        }

Did I do something wrong in my code?

If you set a breakpoint and manually inspect what's in response.Headers["Location"] is there a difference for 404 vs not 404?

I've inspected it and, as I understood right, there is no difference for 404 and not 404 (in both cases a parameter Location = null under Headers, see screenshot). I've also picked out the difference in some retrieved parameters for a response. I assume that can create a condition with a check on ContentLenghth (or ContentType) to have a test failed in case of redirection to the 404 not found page?

Right, so in that case your logic to return a 404 page might need to be changed to return a 404 rather than a 200. That's the most semantic way of telling if it's a Not Found page.
If you can't for some reason then maybe in this instance you can look for the text/html Content Type, although that's a bit of a hack.

Yep, thanks for your support :+1:
I've tried and it seems that's good for me so far, I just checked with this condition:
if (response.ContentType.Contains("html")) {
return false; }
return true;

Because, if the url is not correct and redirects to the 404 not found page, the value of ContentType is "text/html" in my case