Migrate Forms into NewContactMethodPage

Details

We are adding validation to the new Contact page for checking if the user has inputted the contact method which is already an existing contact then we are displaying the error

Fixed Issues

$ https://github.com/Expensify/App/issues/17997
PROPOSAL: https://github.com/Expensify/App/issues/17997#issuecomment-1522963870
Tests

Go to Settings > Profile > Contact Method
Click on the New contact method button
Enter your current email address in the email field
Click on Add
Verify that the error display The Entered Contact Method already exists.

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Go to Settings > Profile > Contact Method
Click on the New contact method button
Enter your current email address in the email field
Click on Add
Verify that the error display The Entered Contact Method already exists.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@cristipaval @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hm, do you suggest adding shouldSaveDraft to newContact form?

Yes!

@dhairyasenjaliya Could you check if the old input value is not cleared after the form submit success? Also, could you resolve that conflict? Thanks!

@dhairyasenjaliya Thanks!
Another conflict need to solved 😅

@dhairyasenjaliya I don't know too 😅 @cristipaval can add the label Waiting for Copy, and someone will be pulled to confirm the copy.

@dhairyasenjaliya Great find! Yes we should clear the draft then.

@dhairyasenjaliya which function did you mention?

@dhairyasenjaliya That's a great find but it's happening because of these changes, so I'm suggesting we shouldn't do anything.

@dhairyasenjaliya That's interesting.
We have another path to go, like discarding the shouldSaveDraft here because this form only consists of 2 inputs and no other follow-up flow after that.

@dhairyasenjaliya Let's do it then! Sorry for the back and forth 😅

@dhairyasenjaliya Could you please merge the latest main?

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Sorry for the delay @dhairyasenjaliya! The code looks good to me, I just need a record for the Android.
Could you update the test to include the expected is? Like add one more point Verify that the error display The Entered Contact Method already exists.

Completed the checklist! All yours @cristipaval

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.14-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.14-14 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


404 at /reference/commandline/build/

I found a broken link : https://docs.docker.com/reference/commandline/build/

Hey @AnasEliawat,
Thanks for reporting the broken link issue. Could you let us know how you arrived at the broken link?

Closing as stale.


Attempt to detect and discard misbehaving devices

Try to detect failing ISO compatible devices by sending a SELECT
command
If failing, discard the tag rather than dispatching it

@slomo What do you think? It is helping on the S6, maybe not as well as the foregroundDispatch NDEF check made by Android, but it filters out some false positives when I use it with the Yubikey.

One option would be to add more conversation here, but it's hard to know what more we could do that will be supported on all ISO devices.

Well you could check for Ndef of course ;)

@slomo But I guess that would on most devices that don't have an NDEF applet just involve the select that fails.

But yeah, it would be as good as the google NDEF check.

:+1:


Handover document

Bring everything to a resolution, that can be resolved
Handover of things that need to be resolved

Tech Ed (except Syllabus)
Partnership handover

List of things we won't do

Here is the handover doc: https://docs.google.com/document/d/1bvm9WCfnfWXXz2ShJTk5ATjaQfwq7_Tw3JJhnOYJ6Eg/edit


Minor bug in documentation

Describe the bug

A clear and concise description of what the bug is.

Possible solution

Describe the solution you thought of.
**

**

i would like to work on this issue

Go ahead
Deadline 10 May,2021


Add LLM-Based Recommendations for Broken Pipeline Runs

Summary
This pull request integrates with the DAG-visualization feature to allow users to request an LLM to suggest fixes for a broken step in one of their pipelines, including suggesting inline code changes to the step’s code, if local.
UI Changes
Adds a context-menu to the DAG-visualization webview that supports already-extant functionality, as well as a “Suggest Fix” option and one to select a default LLM for suggestions.

Suggest Fix opens the model’s response in a markdown preview document in the adjacent View Column, whether or not the source code can be found locally.
If the LLM has suggested code changes, it will search the open workspace for any files which contain the step’s cached code to suggest changes in.

If it finds multiple, it will open no files and display the reason to the user.
If it finds none, it will search the nearest git repo for a file whose most-recently committed version has the step code in it, in case the user has made local changes to the file in an attempt to fix it before asking for a suggestion. The user will be notified if it fetches this file, and it will display changes to the latest version, not the cached one.
If there’s no git repo or none are found in the git repo, it will not open a file and will tell the user the source file cannot be found locally.

If the source code is found and the LLM suggests multiple different options for code changes, they can be cycled between through a “Next Recommendation” button in the file header.
Additionally, suggested code changes are opened in an editable virtual document and compared to the source file via the vscode.diff interface. The intention is that it should look to the user as if they are live-editing the source file, but the changes are quarantined so as to not accidentally autosave over the user’s original code. Manually saving or clicking “Accept Changes” in the file header will overwrite the source code.
If at any point the user selects an option without the requisite preparatory step (ie, storing an API key or selecting a model), the UI for completing that step automatically opens.

Backend Changes

Creates an AIService singleton that supports Anthropic, Gemini, and OpenAI models
Provides a public fixMyPipelineRequest method which creates the LLM chat completion and returns a formatted response along with any python code snippets generated by the LLM
Adds VSCode extension configuration options to allow the user their choice of supported model
Adds support for API keys provided through environment variables or the VSCode secretStorage API. Environment variables take precedence over secretStorage
Adds type definitions for SupportedLLMModels and SupportedLLMProviders

Summary by CodeRabbit

New Features

Introduced a context menu in the DAG visualization for enhanced user interaction, including options for AI model selection and step inspection.
Added AI-driven code recommendation commands to streamline user workflows.
Implemented a multi-step input process for selecting AI models and managing user interactions.
Enabled registration of API keys for various large language models (LLMs) within the extension.
Enhanced utility functions for searching file contents in both workspace and Git repositories.
Expanded configuration capabilities with a new "ZenML AI" section for model selection.
Added new commands for improved AI interactions and recommendations.

Bug Fixes

Improved type safety in data handling within the DAG rendering context.

Documentation

Updated configuration structure for better organization and clarity regarding AI features.

@sklarfox @Morgan-Summer-Davis some feedback. Happy to discuss more on Slack as needed.


Command for getting metadata of an object only, without downloading

For instance, to check for an object's existence on s3 before uploading.

Something similar to the info subcommand of s3cmd the python tool.

I'm currently working on adding this functionality, @rlmcpherson I'm wondering if you have any thoughts as to what the output should look like? Should we just dump the http.Header? Exit with an error if we get a non-2XX code?


Add Github authentication

Add github authentication for the following :

[ ] 1. let users update their details through the app rather than sending a PR
[ ] 2. let users receive push notifications about what rank they stand.
[ ] 3. Have badges that a user receives on completion of specific tasks or goals
[ ] 4. you can think of more features

How about sending a weekly report to mail about their activity last week to mail?

Can't nextjs itself handle it?
How about this?
We'll make an API endpoint in nextjs that'll dispatch an email with sendgrid or anything.
And invoke that endpoint every week by a github workflow? 😎

sounds good, can you make it run from a dummy email for now? Il help

Can't nextjs itself handle it? How about this? We'll make an API endpoint in nextjs that'll dispatch an email with sendgrid or anything. And invoke that endpoint every week by a github workflow? 😎

@rithviknishad As this NextJS project only uses SSG. The choice is only to go for GH workflow


Distribute all files except git and github specific data

Another patch that needs to be in 0.9.1. I don't know in the 0.9.1 release will be made using make dist. If yes, it would be missing a lot of files that were included in older releases. Even the sources of X11rdp would not be included.
I believe that it would be better to err on the side of distributing files. If some files are truly useless, we should remove them from git first.

+1


These Links seems to break in Perlite, showing empty pages.
Note: This feature is competing with outline view of documents.

Can confirm this issue. Any links with a tag reference breaks.

Yes, this comes from the #tag  implementation, need to check if I can fix this.

Good news, this will be fixed in 1.5.2

fixed in https://github.com/secure-77/Perlite/releases/tag/1.5.2


pr pr

this is a new pr fornew pr  preview pr

SonarQube analysis reported 10 issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 sample: Add a 'package-info.java' file to document the 'sample' package
 CustomerProfiles: Add a 'package-info.java' file to document the 'CustomerProfiles' package
 FraudManagement: Add a 'package-info.java' file to document the 'FraudManagement' package
 MobileInappTransactions: Add a 'package-info.java' file to document the 'MobileInappTransactions' package
 PaymentTransactions: Add a 'package-info.java' file to document the 'PaymentTransactions' package
 PaypalExpressCheckout: Add a 'package-info.java' file to document the 'PaypalExpressCheckout' package
 RecurringBilling: Add a 'package-info.java' file to document the 'RecurringBilling' package
 TransactionReporting: Add a 'package-info.java' file to document the 'TransactionReporting' package
 VisaCheckout: Add a 'package-info.java' file to document the 'VisaCheckout' package
 SampleCodeTest: Add a 'package-info.java' file to document the 'SampleCodeTest' package


Fast Fix for asp.net core 2.2

Fix for asp.net core 2.2 (UrlHelper will throw ArgumentOutOfRangeException)

This fix is preventing me from upgrading to 2.2. Would be nice if it could be approved and put in NuGet soon.

Thank you for the quick fix and sorry for the huge delay..


ORTTrainer doesn't work with distributed training and/or DeepSpeed

ORTTrainer.train fails with distributed training and/or deepspeed.
The line inference_manager = model._torch_module._execution_manager._inference_manager assumes that model is of type ORTModule. However, when deepspeed is enabled, it is of type DeepSpeedEngine. Its type is DistributedDataParallel during distributed training.
This leads to an AttributeError for such cases.

Thanks for reporting it ! Pinging @JingyaHuang

Hi @jambayk,
Thanks for reporting!
The error comes from the fact that the case of double wrappers DeepSpeedEngine and ORTModule is not yet considered in ORTTrainer. We are actively working on enabling distributed features in ORTTrainer and you can track the progress from PR #148 .

Hi @jambayk,
The compatibility with DeepSpeed is fixed in PR #148. There are some features currently not compatible(ZeRO stage 3/ BF16, etc.) with ORTModule, you can find the details about what is working and what is not in the PR. We are working on enabling more features!
Will leave this issue open until the next release of Optimum with the fix included, please feel free to reach out if there is any question.

Hi @JingyaHuang, thanks for your work on this!

Closing this, as DeepSpeed is enabled with the release of transformers 4.19.3. Feel free to reach out if there is any further question.


OpTestSystem: Recover lost sys_pty

When we are unable to properly search the pty buffer for expected
strings, we perform a recovery path.  When this recovery path
is performed we need to get a new console object to properly
continue operations.
Signed-off-by: Deb McLemore<EMAIL_ADDRESS>

Seems its timing out from when petitboot is at # prompt, issues "exit", then 10 second timeout pops and we try to recover.  Investigating further why its now taking greater than 10 seconds, etc.

The traces attached look a bit more serious than what Hostboot were seeing with the Petitboot transitions, eg:
# ^MRequesting system reboot
[   23.840915] reboot: Restarting system
[   29.341506] watchdog: CPU 0 self-detected hard LOCKUP @ _raw_spin_lock_irqsave+0x64/0x90
[   29.341508] watchdog: CPU 0 TB:485127462941, last heartbeat TB:479894826312 (10219ms ago)

[31451.479800] ------------[ cut here ]------------
[31451.479878] WARNING: CPU: 0 PID: 31640 at /usr/src/kernel/drivers/gpu/drm/drm_atomic_helper.c:1362 drm_atomic_helper_wait_for_vblanks.part.2+0x28c/0x2a0
[31451.479891] [CRTC:30:crtc-0] vblank wait timed out
[31451.479913] CPU: 0 PID: 31640 Comm: fbterm Tainted: G        W         4.18.12-b953727d56c4de63eb0fad1f079f41004e61d713

But that aside I wonder if op-test is getting lost trying to move back into the Petitboot state after a series of other tests; dealing with the Petitboot state isn't particularly reliable at the moment (https://github.com/open-power/op-test-framework/pull/362)

op-test is getting lost

I've observed this even from fresh boot going directly from capturing the "Petitboot" string and trying to drop first time to the petitboot shell, so to me its looking like linux/device first time setup getting the buffers flowing where python pexpect pty buffer can even get any data, no amount of logic can work on an empty buffer (my observations so far on this).

I can't seem to replicate the failures that Hostboot were seeing yet (EOFs, etc), but as @debmc says the change here should probably go in regardless. We should probably guard those extra log.debug() calls so that it only prints them out on an error though, could get very noisy.

Of course I soon as I pressed Comment I hit the issue.
Interestingly if I connected to the console I could see that typing exit did not immediately do anything. I wonder if this may have something to do with Petitboot calling sudo -i when dropping to the shell. It's interesting that the skiroot suite fails only on the Petitbooti18n test, perhaps we spend a lot of time running commands and that's the first time we try to exit the shell? :thinking:

[console-expect]#which sudo && sudo -s
Aha, I bet now that sudo is available op-test is running it and spawning more shells with sudo -s. Which is why it takes several exits to get back to the menu. I'll work on a fix.

exit the shell

Interesting ... when petitboot transitions from shell to UI, the prompt states get cleared (since we lose the prompt and have to reset it back up) ... but if that were the case, it would happen regularly and it does not seem to.  It would be interesting to put more traces around the clearing and setup to see if that is where the delay hits, but I still saw the empty buffer and the timeout.
Also, the additional logging should only occur on transitions from petitboot shell to UI or when a recover happens, and that is seldom.

work on a fix

Yes good find.

Sam Mendoza-Jonas<EMAIL_ADDRESS>writes:

[console-expect]#which sudo && sudo -s
Aha, I bet now that sudo is available op-test is running it and
spawning more shells with sudo -s. Which is why it takes several
exits to get back to the menu. I'll work on a fix.

Ahh yep, we probably aren't testing uid before trying to get root, and
it's all falling into the generic logic for "get a root prompt"
--
Stewart Smith
OPAL Architect, IBM.

get a root prompt

During op-test, we only do the sudo when we don't know what we are trying to set the prompt for so we can proceed with doing interrogations.  During normal operations after DETECT, we know we are in Petitboot and only do the set PS1.  Unless we're talking about some other flow here.

I'll work on avoiding getting into the bonus sudo state at all separately; however this PR does resolve the issue and in general makes the transition more resilient. Tested locally with a patched Skiboot to pass the qemu suite.


Hide the token of the Inactive chain

Describe the task
Hide the token of the Inactive chain
Actual: The network is inactive (do not show on UI) but the token of these network still show

Expect: Hide the token of the Inactive chain

Version test: https://590ac676.subwallet-webapp.pages.dev/
Validation passed


How to support image from remote-service?

How to support image from remote-service?
<img src="http://h.hiphotos.baidu.com/image/h%3D200/sign=e72c850a09f3d7ca13f63876c21fbe3c/a2cc7cd98d1001e9460fd63bbd0e7bec54e797d7.jpg" />

Hi,
There is currently no way to load remote images.
I was working on a feature allowing to display images, but only local one will be supported.
Regards

@nicolasgoutaland any ETA for local images? looking forward to it :)


Rework Python packaging lecture

Description

Major overhaul of the Python packaging lecture slides. More information regarding setup.cfg and pyproject.toml is provided and the approaches are also incorporated in the in-class examples.
Checklist

[x] I made sure that the markdown files are formatted properly.
[x] I made sure that all hyperlinks are working.

@uekerman in this PR I have expanded the content regarding the structuring of different files used for packaging code. I have also added a bit more about using pip. With more content here I am inclined to remove the Conda part as it seems only like a sneak peek at the end and not really deep content. Thoughts?


Escaping fix broke a number of things (#14145)

Port fix for escape problems

Codecov Report

Merging #14154 into release-2020.09 will decrease coverage by 0.02%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-2020.09   #14154      +/-   ##
===================================================
- Coverage            59.87%   59.85%   -0.03%
===================================================
  Files                  692      692
  Lines                38341    38341
  Branches              5514     5514
===================================================
- Hits                 22957    22948       -9
- Misses               14201    14207       +6
- Partials              1183     1186       +3

Impacted Files
Coverage Δ

src/client/datascience/crossProcessLock.ts
79.41% <0.00%> (-11.77%)
:arrow_down:

src/client/common/utils/platform.ts
60.00% <0.00%> (-8.00%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0.00%> (-0.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5065d31...a520fb7. Read the comment docs.


filter manager: fix 200 on no_healthy_upstream

Commit Message: A gRPC request which was routed to a cluster with no healthy upstreams would receive a response code of 200. The access logs showed the 200 alongside the response code details of no_healthy_upstream
Additional Description:
Risk Level: low
Testing:
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue] #29052
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Failed on this test for matching http extensions. Specifically failing the check on L629 where we expect a 200 response code for a request that has a match header but the value is not in the map. I may misunderstand how/what this matching is doing, but it seems to me that since we are not skipping the 403 injection filter (not-match != match), then we would expect the value to be 403, not 200.
I think the test should actually expect a 403 there and that the bug this PR is fixing might have masked that issue. Although I'm not sure why the check in the first case where there was no match-header header didn't exhibit the same behavior.
cc @snowp as the author of this test (albeit a long while ago)
cc @tyxia for recent work in the matching extensions space

I think this isn't a bug? The :status header of grpc response always should be 200.

/wait

I think that :status of 200 only applies to successful gRPC requests (whether they result in error statuses or not). In this case, the HTTP/2 request fails before any gRPC processing occurs, so I think per this doc the client should expect a non-200 response to a no_healthy_upstream situation.

Implementations should expect broken deployments to send non-200 HTTP status codes in responses

I don't think this sentence is clear enough to tell envoy should return non-200 for no healthy upstream.
And Envoy have set the grpc-status correctly to unvailable. At least for me, unvailable is an appropriate response in this case.
/wait-any


Fixed "session -> new" not compatible with Fish shell (and others)

Creating new sessions didn't work for fish shell (and potentially for others), so I wrapped the command with bash -c to keep it compatible.

Thanks, but this unfortunately doesn't work on my machine (macOS zsh). I did a little fix https://github.com/sainnhe/tmux-fzf/commit/ce27ae458ce071ee41e80fcb9b2e79ee2dd151cc and hope this would work for you.

Oh, sorry for that! Your change works perfectly fine for me.
Btw I've noticed multi-word not working for session names, so I've made a new PR for this https://github.com/sainnhe/tmux-fzf/pull/74


News page sidebar overlaps with articles

This is what's happening:

http://owncloud.org/news/ in Firefox 31.0

Still an issue thanks to @MorrisJobke and his big pictures ;-)

Guys. I fixed the images back then.

Hmm there is something up with the css rules here. I've fixed this at least twice now with the same css.

This time it's
.masonry-brick {
    max-width: 100%;
}

This is still broken:

The .masonry-brick setting @MorrisJobke mentions would fix it...

Ok, let me see if I can fix it.

Looks like that worked - https://staging.owncloud.org to verify.

Looks good here as well :+1:

Looks good :+1:

Ok, going to ask to deploy the site soon. Just hoping to get #557 merged today, too... Input welcome!

will close as we dealt with it... for now ;-)


fix: readme links

changelog / migration guide was linking to a 404 in the docs

Coverage remained the same at 97.076% when pulling<PHONE_NUMBER>52b9d27496cdbe03f596e50ce6abb2 on DRoet:patch-1 into 9a7f89c4ed7922af087bbfc94ccde4eb983dff4b on Vincit:master.

Thanks


JUnitXmlReporter report not produced when errors are found

Steps to reproduce

angular 2
angular-cli
protractor
framework: jasmine2
protractor configured as per instructions

Observed Behavior

folder and report not created when tests do not pass

Expected behavior

folder and report created when tests do not pass.
NOTE: folder and report are created when tests pass.

protractor
// Protractor configuration file, see link for more information
// https://github.com/angular/protractor/blob/master/lib/config.ts

/*global jasmine */
var SpecReporter = require('jasmine-spec-reporter').SpecReporter;

exports.config = {
  allScriptsTimeout: 11000,
  specs: [
    './e2e/**/*.e2e-spec.ts'
  ],
  capabilities: {
    'browserName': 'chrome'
  },
  directConnect: true,
  baseUrl: 'http://localhost:4200/',
  framework: 'jasmine2',
  jasmineNodeOpts: {
    showColors: true,
    defaultTimeoutInterval: 30000,
    print: function() {}
  },
  useAllAngular2AppRoots: true,
  beforeLaunch: function() {
    require('ts-node').register({
      project: 'e2e'
    });
  },
  onPrepare() {
        let specReporter = require('jasmine-spec-reporter').SpecReporter;
        jasmine.getEnv().addReporter(new SpecReporter({
            spec: { displayStacktrace: true }
        }));

        let jasmineReporters = require('jasmine-reporters');
        jasmine.getEnv().addReporter(new jasmineReporters.JUnitXmlReporter({
            consolidateAll: true,
            savePath: 'test_results_integration',
            filePrefix: 'xmloutput'
        }));
  }
};

Output
$ ng e2e
** NG Live Development Server is running on http://localhost:49153 **
Hash: f625d81f6b1139d09307
Time: 15617ms
chunk    {0} main.bundle.js, main.bundle.js.map (main) 98.7 kB {3} [initial] [rendered]
chunk    {1} styles.bundle.js, styles.bundle.js.map (styles) 434 kB {4} [initial] [rendered]
chunk    {2} scripts.bundle.js, scripts.bundle.js.map (scripts) 669 kB {4} [initial] [rendered]
chunk    {3} vendor.bundle.js, vendor.bundle.js.map (vendor) 4.01 MB [initial] [rendered]
chunk    {4} inline.bundle.js, inline.bundle.js.map (inline) 0 bytes [entry] [rendered]
webpack: Compiled successfully.
[13:03:30] I/update - chromedriver: file exists /Users/silveir/Projects/dlabs/ng2-client/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_2.28.zip
[13:03:30] I/update - chromedriver: unzipping chromedriver_2.28.zip
[13:03:30] I/update - chromedriver: setting permissions to 0755 for /Users/silveir/Projects/dlabs/ng2-client/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_2.28
[13:03:30] I/update - chromedriver: chromedriver_2.28 up to date
[13:03:30] I/launcher - Running 1 instances of WebDriver
[13:03:30] I/direct - Using ChromeDriver directly...
[13:03:33] E/launcher - No element found using locator: By(css selector, *[id="TenantAdminLink"])
[13:03:33] E/launcher - NoSuchElementError: No element found using locator: By(css selector, *[id="TenantAdminLink"])
at WebDriverError (/Users/silveir/Projects/dlabs/ng2-client/node_modules/selenium-webdriver/lib/error.js:27:5)
at NoSuchElementError (/Users/silveir/Projects/dlabs/ng2-client/node_modules/selenium-webdriver/lib/error.js:168:5)
at elementArrayFinder.getWebElements.then (/Users/silveir/Projects/dlabs/ng2-client/node_modules/protractor/lib/element.ts:851:17)
at ManagedPromise.invokeCallback_ (/Users/silveir/Projects/dlabs/ng2-client/node_modules/selenium-webdriver/lib/promise.js:1366:14)
at TaskQueue.execute_ (/Users/silveir/Projects/dlabs/ng2-client/node_modules/selenium-webdriver/lib/promise.js:2970:14)
at TaskQueue.executeNext_ (/Users/silveir/Projects/dlabs/ng2-client/node_modules/selenium-webdriver/lib/promise.js:2953:27)
at asyncRun (/Users/silveir/Projects/dlabs/ng2-client/node_modules/selenium-webdriver/lib/promise.js:2813:27)
at /Users/silveir/Projects/dlabs/ng2-client/node_modules/selenium-webdriver/lib/promise.js:676:7
at process.tickCallback (internal/process/next_tick.js:103:7)Error
at ElementArrayFinder.applyAction (/Users/silveir/Projects/dlabs/ng2-client/node_modules/protractor/lib/element.ts:482:23)
at ElementArrayFinder.(anonymous function) [as click] (/Users/silveir/Projects/dlabs/ng2-client/node_modules/protractor/lib/element.ts:96:21)
at ElementFinder.(anonymous function) [as click] (/Users/silveir/Projects/dlabs/ng2-client/node_modules/protractor/lib/element.ts:873:14)
at Function.TenantPage.navigateToTenantView (/Users/silveir/Projects/dlabs/ng2-client/e2e/tenant.po.ts:89:42)
at Suite. (/Users/silveir/Projects/dlabs/ng2-client/e2e/tenant.e2e-spec.ts:19:16)
at addSpecsToSuite (/Users/silveir/Projects/dlabs/ng2-client/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:867:25)
at Env.describe (/Users/silveir/Projects/dlabs/ng2-client/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:836:7)
at describe (/Users/silveir/Projects/dlabs/ng2-client/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:3576:18)
at Suite. (/Users/silveir/Projects/dlabs/ng2-client/e2e/tenant.e2e-spec.ts:17:3)
at addSpecsToSuite (/Users/silveir/Projects/dlabs/ng2-client/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:867:25)
at Env.describe (/Users/silveir/Projects/dlabs/ng2-client/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:836:7)
at describe (/Users/silveir/Projects/dlabs/ng2-client/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:3576:18)
at Object. (/Users/silveir/Projects/dlabs/ng2-client/e2e/tenant.e2e-spec.ts:5:1)
at Module._compile (module.js:570:32)
at Module.m._compile (/Users/silveir/Projects/dlabs/ng2-client/node_modules/ts-node/src/index.ts:406:23)
at Module._extensions..js (module.js:579:10)

Getting this massively. Has anyone found any sort of workaround or alternatives?


discourse: handle trailing slash on url

Just remove it or treat it as optional
This works https://discourse.haskell.org/t/an-opportunity-that-i-couldnt-pass-up/7485
This doesn't https://discourse.haskell.org/t/an-opportunity-that-i-couldnt-pass-up/7485/

Also handle trailing number for the comment.
I guess just drop it since this thing doesn't have comment to comment navigation :/
Example: https://discourse.haskell.org/t/haskell-ci-group-meeting-notes/7315/3


The problem of Liquid's for loop.

When I use Liquid's for loop in the Event Formatting Agents, it outputs nothing. I don't know where's the fault.
  "instructions": {
    "team-a": [
      "abcd",
      "fgggggffghuuhhh"
    ],
    "enc_uin": "abcd",
    "team": "{% assign a = team-a %}{% assign b = enc_uin %}{% for b in a %}{{ b }}{% endfor %}"
  },
  "matchers": [],
  "mode": "clean"

Output:
[
  {
    "team-a": [
      "abcd",
      "fgggggffghuuhhh"
    ],
    "enc_uin": "abcd",
    "team": ""
  }
]

What I want to output is team:"abcd".

The field enc_uin is from the Website Agent which scraps  the page for example as you saw in the past😹, and field team-a is from another Website Agent which scraps the txt file from my dropbox. My thought is after I typing a list of enc_uin in the txt file the content will be fetched by another Website Agent and formatted by Liquid as an object and then inserted into  the Event Formatting Agent by a Commander Agent. It is the field team-a  and the data is updated by live. How can I merge the two events or search enc_uin in team-a which are from two different events?

We don't have a good way to merge Events.

My thought is after I typing a list of enc_uin in the txt file the content will be fetched by another Website Agent and formatted by Liquid as an object and then inserted into the Event Formatting Agent by a Commander Agent

That should work by using a second Formatting Agent.
CommanderAgent -> sets options of FormattingAgent1
WebsiteAgent -> sends Events to FormattingAgent1 which includes the data in it's Event
FormattingAgent1 -> FormattingAgent2 here you can work on the combined data

@dsander Sorry I'm late to confirm that after setting another FormattingAgent the for loop works! But the result is that more than 10 agents should be set for me and it's soooo long. 😟


 IF YOU DO NOT FOLLOW THE FORMAT OR MAKE A GENERIC TOKEN REQUEST YOUR ISSUE WILL BE DELETED WITHOUT COMMENT
YOUR JUSTLIST MUST FOLLOW THE JSON SPECIFICATION
https://github.com/justswaporg/justlists/example.justlists.ts
Checklist

[x] I understand that this is not the place to request a token listing.
[x] I have tested that my JustList is compatible by pasting the URL into the add a list UI at justswap.org.
[x] I understand that filing an issue or adding liquidity does not guarantee addition to the justlists website.

Please provide the following information for your token.
JustList URL must be HTTPS.
JustList URL: TQnn52uzP474CVg3R2bsicYwe9aC4X4RkW
JustList Name: CHC
Link to the official homepage of the JustList manager:www.chikotiken.com

Sorry, your issue will be closed as you did not submit your information in the correct format.


Tighten NTTP creation: require to_nttp(...)

This backpedals on the very low friction pathway to pass Quantity instances as template parameters.  This causes problems with C++20's spaceship operator <=>.  We could fix this with a special C++20 compatibility layer, and we might still do exactly that.  However, this is just one instance of a broader class of vulnerability.
It turns out that giving the very safe Quantity an implicit conversion to a raw numeric type may simply be inviting trouble.  This gives the compiler a pathway to generate all kinds of operations that we probably don't want to generate.
We could just make the conversion explicit... but then, how would we trigger it?  I can't think of a way that would be at all comparably concise to to_nttp.
So let's just use to_nttp for now.  It will be a lot easier to loosen this later if we're confident that's correct, than to tighten it after we've cut an official release.
Helps #353: it gives a more sensible error.

I created this pull request to show, for posterity, how we would have migrated to a forced to_nttp interface.  I'm closing it now because I'm leaning towards keeping the current interface, but if that decision ever changes, we can reopen it.


Add npm badge to readme

https://nodei.co/#markpress

Done in https://github.com/gamell/markpress/releases/tag/v3.0.1


Fix: icon error of cascader and select

Please make sure these boxes are checked before submitting your PR, thank you!

[ ] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
[ ] Make sure you are merging your commits to dev branch.
[ ] Add some descriptions and refer relative issues for you PR.

等待对组件的重构吧。彻底解决该问题。

是必须升版本来解决问题吗？从2.7.0升级到2.8.2影响大吗


Clarify public and private wiki permission levels

Why:
Closes #10075

What's being changed:

Change the current line to "Edit wikis in public repos"
Add a second entry for "Edit wikis in private repos" that only has Xs in write, maintain and admin.

Check off the following:

[x] I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Question: Do we need another {% ifversion fpt %} on the private wiki line???

@HonkingGoose
Thanks so much for opening a PR! I'll get this triaged for review :zap:


Extend Quota to support both Size and Object Count

Explain the changes

Refactor the quota structure to be a class. Then we have a single place with all related quota object methods.
Extended the quota object to support a "quantity" config.
Fix ui

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

@igorpick before merging we need to add an upgrade script to convert from older quota format


AddJsonOptions setting SerializerSettings.DateTimeZoneHandling to Local Causes Problems in Alaskan Timezones

MVC's Json Parser Assigning Old Dates to Incorrect Timezone in Alaska
Prior to 1983 Alaska was primarily in -10, currently it is -8.  MVC does not take this into account but Javascript's Date object does.  This only comes into play when DateTimeZoneHandling is set to local.
services.AddMvc().AddJsonOptions(options =>
{
    options.SerializerSettings.DateTimeZoneHandling = DateTimeZoneHandling.Local;
})

The problem is a date stored in the database as 1981-04-23 00:00:00 will be serialized into this:

If I parse this into a Date object though, Javascript knows that dates before 1983 should be -10 and parses it to:

So everything is two hours off.

Is it ASP.NET Core deserialization or .NET Core deserialization? cc @tarekgh

This is Json.NET deserialization but I'm not sure where the DateTime / timezone issue comes in. In other words, is this an issue with time zone data, or how Json.NET is using that info?
cc @JamesNK as well

The logic Json.NET uses when converting an existing DateTime to local:
        private static DateTime SwitchToLocalTime(DateTime value)
        {
            switch (value.Kind)
            {
                case DateTimeKind.Unspecified:
                    return new DateTime(value.Ticks, DateTimeKind.Local);

                case DateTimeKind.Utc:
                    return value.ToLocalTime();

                case DateTimeKind.Local:
                    return value;
            }
            return value;
        }

This is Windows TZ data problem.
Alaskan Standard Time * **-09:00:00**
----------------------------------------------
1/1/0001 12:00:00 AM (Unspecified) - 12/31/2006 12:00:00 AM (Unspecified)
    DaylightDelta: **01:00:00**
    DaylightTransitionStart: 4/1
        DayOfWeek: Sunday
        TimeOfDay: 1/1/0001 2:00:00 AM
        Week: 1
        IsFixedDateRule: False
    DaylightTransitionEnd: 10/1
        DayOfWeek: Sunday
        TimeOfDay: 1/1/0001 2:00:00 AM
        Week: 5
        IsFixedDateRule: False
    baseUtcOffsetDelta: 00:00:00

Looks the data is not matching whatever JavaScript is using for time zone (I guess on Linux the data more accurate for Alalska). I would say send this issue to Windows team.

@tarekgh do you know how to send/report the bug to Windows?

I have reported the issue to Windows team.
@yanbu0 if you want to track the issue with Windows team, please report it through Windows 10, you can just click the search on the task bar and then type "Feedback Hub" and then open it and report the issue.
per that, I am going to close this issue here as there is no action from .NET side.


add: Useful link of CN version

Useful link: Click here to go to the Chinese supported version.

Thanks, I did it in other way in the latest commit.


Populate read_replica_source when reading the replica

When we getService on a read replica, we need to populate the read_replica_source to properly reflect that information in terraform state
closes https://github.com/timescale/Support-Dev-Collab/issues/2063

Did some local tests and works as expected
# setup ###########################
terraform {
  required_providers {
    timescale = {
      source  = "registry.terraform.io/providers/timescale"
      version = "~> 1.0"
    }
  }
}

provider "timescale" {
  project_id = var.ts_project_id
  access_key = var.ts_access_key
  secret_key = var.ts_secret_key
}

variable "ts_project_id" {
  type    = string
  default = "xo62e6nobm"
}

variable "ts_access_key" {
  type = string
}

variable "ts_secret_key" {
  type = string
}

# resources ################################
## main service
resource "timescale_service" "tf-test" {
  name                      = "tf-test"
  milli_cpu                 = 500
  memory_gb                 = 2
  region_code               = "us-west-2"
  connection_pooler_enabled = true
  enable_ha_replica         = true
  vpc_id                    = timescale_vpcs.vpc-diff-network.id
}

## imported read replica
resource "timescale_service" "replica-tf-test" {
  read_replica_source = timescale_service.tf-test.id
  name                = "replica-tf-test"
  milli_cpu           = 500
  memory_gb           = 2
  region_code         = "us-west-2"

  lifecycle {
    prevent_destroy = true
  }
}

resource "timescale_vpcs" "vpc-diff-network" {
  name        = "vpc-diff-network"
  cidr        = "<IP_ADDRESS>/24"
  region_code = "us-west-2"

  lifecycle {
    prevent_destroy = true
  }
}

# outputs ##################
## host connection info
output "host_addr" {
  value       = timescale_service.tf-test.hostname
  description = "Service Host Address"
}

output "host_port" {
  value       = timescale_service.tf-test.port
  description = "Service Host port"
}

## ha-replica connection info
output "replica_addr" {
  value       = timescale_service.tf-test.replica_hostname
  description = "Service Replica Host Address"
}

output "replica_port" {
  value       = timescale_service.tf-test.replica_port
  description = "Service Replica Host port"
}

## pooler connection info
output "pooler_addr" {
  value       = timescale_service.tf-test.pooler_hostname
  description = "Service Pooler Host Address"
}

output "pooler_port" {
  value       = timescale_service.tf-test.pooler_port
  description = "Service Pooler Host port"
}

## read replica endpoint
output "read_replica_addr" {
  value       = timescale_service.replica-tf-test.hostname
  description = "Service Replica Host Address"
}

output "read_replica_port" {
  value       = timescale_service.replica-tf-test.port
  description = "Service Replica Host port"
}

The import output:
❯ terraform import --var-file=secrets.tfvars 'timescale_service.replica-tf-test' qxem4ftdpj
timescale_service.replica-tf-test: Importing from ID "qxem4ftdpj"...
timescale_service.replica-tf-test: Import prepared!
  Prepared timescale_service for import
timescale_service.replica-tf-test: Refreshing state... [id=qxem4ftdpj]

Import successful!

The resources that were imported are shown above. These resources are now in
your Terraform state and will henceforth be managed by Terraform.

With the refresh we can see the outputs updated:
❯ terraform refresh --var-file=secrets.tfvars
timescale_vpcs.vpc-diff-network: Refreshing state... [name=vpc-diff-network]
timescale_service.tf-test: Refreshing state... [id=prd2y48ymp]
timescale_service.replica-tf-test: Refreshing state... [id=qxem4ftdpj]

Outputs:

host_addr = "prd2y48ymp.xo62e6nobm.vpc.tsdb.forge.timescale.com"
host_port = 5432
pooler_addr = "prd2y48ymp-pooler.xo62e6nobm.vpc.tsdb.forge.timescale.com"
pooler_port = 5432
read_replica_addr = "qxem4ftdpj.xo62e6nobm.tsdb.cloud.timescale.com"
read_replica_port = 31230
replica_addr = "prd2y48ymp-repl.xo62e6nobm.vpc.tsdb.forge.timescale.com"
replica_port = 5432

merging this pr to move forward with the dependabots

updating the integration tests timeout to 30min

Weird. First CI run worked in this branch and local tests work too. But now different tests fail in the CI with this crazy long stack traces.


Clean up or notify about various warnings

This removes various warnings, and informs users about the case where warnings ARE displayed during testing.

I would rather keep those Rubocop cops. They're not triggering based on our current code base, are they?
I'm fine with merging the warnings, though I'm hoping to come up with a better alternative here: http://stackoverflow.com/questions/37201795/how-to-reload-fixtures-in-a-test

The Rubocop warnings are triggering on a lot of lines.

Are you running rubocop from the command line?

I run "rake" from the command line, which then runs RoboCop. I normally run checking from the command line and watch the results, because that sometimes alerts me of problems that remote execution does not.

Could you please paste in the Rubocop errors you're seeing. I just ran rake and didn't see anything. Moreover, we want to set up CircleCI as the canonical source of truth, so that we don't need to argue about different configs. If you've configured Rubocop to be more strict than I have (somehow), I'd like to replicate that on CircleCI.

I'll need to post the warnings later.
However, I updated gems and ended up with rubocop 0.40.0, not 0.39.0.  I believe that is the cause of the difference.

That's all I needed to know. I'll update and then make fix the warnings rather than ignoring them.
--
Dan Kohn<EMAIL_ADDRESS>tel:+1-415-233-1000

On May 13, 2016, at 11:12, David A. Wheeler<EMAIL_ADDRESS>wrote:
I'll need to post the warnings later.
However, I updated gems and ended up with rubocop 0.40.0, not 0.39.0. I believe that is the cause of the difference.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub

Ok, but look after results first. I wouldn't be surprised if the code looks better when it violates this new style rule. I want to have clean code, and I am skeptical that this rule will help us get there.

I recommend closing this PR without merging. It is instead resolved in #359 and #361.

Agreed.


Default Checkout Comment

My organisation requires that we provide a checkout comment - we would like the ability to specify a default check out comment in the settings, and this to then be shown in the check out dialog box. From the command line it's just the -c option, so hopefully something similar is possible via the UI.

The current implementation rely on the cleardiag tool that does indeed have a /comment option.
Unfortunately using that option as a side effect; if there is a current activity and you supply the /comment parameter then the checkout is performed without showing the dialog.
This is nice and all but it changes the whole workflow (what if you wanted to change the activity?).

Would be possible to expose this as a configurable property? I mean src/clearcase.ts
exec("cleardlg /checkout \"" + path + "\"", (error, stdout, stderr) => { this.m_updateEvent.fire();}
If "cleardlg /checkout" would be configurable I could have workaround.

036361a8b46f008b144891da69b2ade30f62b910 should've fixed this. Can anyone confirm?


Run pre-commit autoupdate

Committed via https://github.com/asottile/all-repos

hmmm, python2 and python3.5 🤔


fix(backup): fix DBRetentionAndShardFromPath parsing error between different OS

Closes #25361
Describe your proposed changes here.

[x] I've read the contributing section of the project README.
[x] Signed CLA (if not already signed).

Use separatorRegexp = regexp.MustCompile(`[/\\]`) to Split instead of strings.Split(path, string(filepath.Separator))
@davidby-influx @gwossum

@bnpfeife @jdstrand @devanbenz


Text field cursor position in RTL goes to the penultimate character

When the user writes then taps at the end of a text field in RTL app the cursor position is set to the penultimate character instead of the last one. This issue occurs on both Android (tested on multiple devices from different vendors and emulator) and iOS.
Steps to Reproduce

Execute flutter run on the code sample
Write Arabic or any other RTL language in the text field.
Tap on any place to change the cursor position then tap again at the end of the text field, the cursor position will change to the penultimate character.

Expected results:
The cursor position should be after the last character.
Actual results:
The cursor position moves to the penultimate character.

Code sample

import 'package:flutter/material.dart';
import 'package:flutter_localizations/flutter_localizations.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      locale: const Locale("ar"),
      localizationsDelegates: const [
        GlobalMaterialLocalizations.delegate,
        GlobalWidgetsLocalizations.delegate,
        GlobalCupertinoLocalizations.delegate,
      ],
      supportedLocales: const [Locale("ar")],
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key, required this.title}) : super(key: key);

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: const Center(
        child: Padding(
          padding: EdgeInsets.all(16),
          child: TextField(),
        ),
      ),
    );
  }
}

Logs

Performing hot restart...
Syncing files to device Android SDK built for x86...
Restarted application in 4,352ms.
D/InputConnectionAdaptor( 3905): The input method toggled cursor monitoring on
D/EGL_emulation( 3905): eglMakeCurrent: 0xb1529440: ver 2 0 (tinfo 0x96884cd0)
W/IInputConnectionWrapper( 3905): reportFullscreenMode on inexistent InputConnection
W/IInputConnectionWrapper( 3905): finishComposingText on inactive InputConnection
D/EGL_emulation( 3905): eglMakeCurrent: 0xa5d2dc40: ver 2 0 (tinfo 0x96884430)
D/EGL_emulation( 3905): eglMakeCurrent: 0xa5d2dc40: ver 2 0 (tinfo 0x96884430)
D/EGL_emulation( 3905): eglMakeCurrent: 0xb1529440: ver 2 0 (tinfo 0x96884cd0)
D/InputConnectionAdaptor( 3905): The input method toggled cursor monitoring on
I/TextInputPlugin( 3905): Composing region changed by the framework. Restarting the input method.
W/IInputConnectionWrapper( 3905): getTextBeforeCursor on inactive InputConnection
W/IInputConnectionWrapper( 3905): getTextBeforeCursor on inactive InputConnection
D/InputConnectionAdaptor( 3905): The input method toggled cursor monitoring on

Analyzing test_app...
No issues found! (ran in 8.6s)

[✓] Flutter (Channel stable, 3.0.3, on Microsoft Windows [Version 10.0.19044.1766], locale en-US)
    • Flutter version 3.0.3 at E:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 676cefaaff (10 days ago), 2022-06-22 11:34:49 -0700
    • Engine revision ffe7b86a1e
    • Dart version 2.17.5
    • DevTools version 2.12.2

Checking Android licenses is taking an unexpectedly long time...[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at E:\Android_SDK\android-sdk-windows
    • Platform android-33, build-tools 33.0.0
    • ANDROID_HOME = E:\Android_SDK\android-sdk-windows
    • ANDROID_SDK_ROOT = E:\Android_SDK\android-sdk-windows
    • Java binary at: E:\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Users\MyPc\AppData\Local\Google\Chrome\Application\chrome.exe

[!] Visual Studio - develop for Windows (Visual Studio Community 2022 17.3.0 Preview 1.0)
    • Visual Studio at E:\Program Files\Microsoft Visual Studio\2022\Preview
    • Visual Studio Community 2022 version 17.3.32505.426
    • The current Visual Studio installation is a pre-release version. It may not be supported by Flutter yet.
    • Windows 10 SDK version 10.0.18362.0
    ✗ Visual Studio is missing necessary components. Please re-run the Visual Studio installer for the "Desktop development with C++" workload, and
      include these components:
        MSVC v142 - VS 2019 C++ x64/x86 build tools
         - If there are multiple build tool versions available, install the latest
        C++ CMake tools for Windows
        Windows 10 SDK

[✓] Android Studio (version 2021.2)
    • Android Studio at E:\android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[✓] VS Code (version 1.68.1)
    • VS Code at C:\Users\MyPc\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.42.0

[✓] Connected device (4 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86    • Android 7.0 (API 24) (emulator)
    • Windows (desktop)                  • windows       • windows-x64    • Microsoft Windows [Version 10.0.19044.1766]
    • Chrome (web)                       • chrome        • web-javascript • Google Chrome 102.0.5005.115
    • Edge (web)                         • edge          • web-javascript • Microsoft Edge 101.0.1210.53

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Temporary Fix
TextField(
onTap: (){
if(controller.selection == TextSelection.fromPosition(TextPosition(offset: controller.text.length -1))){
setState(() {
controller.selection = TextSelection.fromPosition(TextPosition(offset: controller.text.length));
});
}
},
controller: controller,
...
);

Hi @M144-Coder, Thanks for filing the issue. I am able to reproduce the issue on the latest stable channel but not on the master channel. So I believe this issue is fixed and it should land on the stable channel in the future releases.

stable
master

flutter doctor -v (mac)
[✓] Flutter (Channel stable, 3.0.4, on macOS 12.4 21F79 darwin-arm, locale en-IN)
    • Flutter version 3.0.4 at /Users/mahesh/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 85684f9300 (4 days ago), 2022-06-30 13:22:47 -0700
    • Engine revision 6ba2af10bb
    • Dart version 2.17.5
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-32, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.67.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.44.0

[✓] Connected device (3 available)
    • sdk gphone arm64 (mobile) • emulator-5554 • android-arm64  • Android 11 (API 30) (emulator)
    • macOS (desktop)           • macos         • darwin-arm64   • macOS 12.4 21F79 darwin-arm
    • Chrome (web)              • chrome        • web-javascript • Google Chrome 103.0.5060.53

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 3.1.0-0.0.pre.1494, on macOS 12.4 21F79 darwin-arm, locale en-IN)
    • Flutter version 3.1.0-0.0.pre.1494 on channel master at /Users/mahesh/Documents/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 829bddf616 (3 hours ago), 2022-07-04 03:49:08 -0400
    • Engine revision e78ed7f1c9
    • Dart version 2.18.0 (build 2.18.0-251.0.dev)
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-32, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.67.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.44.0

[✓] Connected device (3 available)
    • sdk gphone arm64 (mobile) • emulator-5554 • android-arm64  • Android 11 (API 30) (emulator)
    • macOS (desktop)           • macos         • darwin-arm64   • macOS 12.4 21F79 darwin-arm
    • Chrome (web)              • chrome        • web-javascript • Google Chrome 103.0.5060.53

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Closing as fixed on master.


Update Chart.js to version 2.0.2

Update to the most recent version https://github.com/chartjs/Chart.js/releases/tag/2.0.2

@coderbydesign Would love to use your gem! Can you update the library to the newest release?

You bet, thanks for the PR!


The mAP of VOC2007 drops to 73.76 when I replace nms with nms src code existing in https://github.com/amdegroot/ssd.pytorch

Hello,
I have a question that bothers me a lot T_T...
The nms cannot be compiled successfully in my environment (win10), so I exchange the nms src file with nms existing in https://github.com/amdegroot/ssd.pytorch. The interface, parameters and all other src code stay the same. When I make this change, the mAP of VOC2007 drops to 73.76% even I have tried to retrain the net.
I wonder whether this phenomenon is caused by the difference between torch_extension.nms and nms existing in amdegroot/ssd.pytorch.
Thank you so much!

I'm not sure it's caused by NMS. I have not read https://github.com/amdegroot/ssd.pytorch 's nms code, but this repo's nms only supports absolute coordinates. You can tell me the details about your test, or the error msg when you build the nms.

The error msg is as follows:
tmpxft_000212dc_00000000-1.cpp
nvcc fatal   : Host compiler targets unsupported OS.
error: command 'C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v8.0\bin\nvcc.exe' failed with exit status 1.
It seems that this error is caused by OS (windows10) and cuda's version.
It would be nice if you can provide python-like nms src code so that I don't have to compile or read (c/c++)-like nms src code or translate it to python-like.
Thank you so much again!

Thanks. Python-like nms may slower than C++, but I will provide a python-like nms for convenience when I'm free.

It is so kind of you. Thanks!

I've added python-like nms. Please update you code and test again, Thanks.


[KYUUBI-128]add ldap authenticate support

@yaooqinn This pr solved my problem, it works fine in my ldap environment. Thanks again.

@yaooqinn  Could you merge all changes to master？

thanks @dockerzhang, pending on travis


Windows: Builder case insensitive env

Signed-off-by: John Howard<EMAIL_ADDRESS>@duglin - Addresses your comment https://github.com/docker/docker/pull/28667#issuecomment-262026383. Specifically the builder piece of the whole puzzle. I'll look at -e for docker run in a follow-up PR to keep things a little more succinct and by area.
This PR ensures that on Windows, environment variables in the builder (both as an ENV command and for variable substitution) are treated case-insensitive.
@thaJeztah @vieux As for https://github.com/docker/docker/pull/28667, this probably also should make it into 1.13.

@jhowardmsft one question; is there a reason for picking lowercase as the canonical? Is it more common on Windows to have env vars in lowercase (Linux is overall uppercase)?

No reason at all. If I used upper, someone would question it the other way 😇

Just wondered what most "natural" was, I.e., least chance of it changing case, and least surprising to users if they specified a var

I honestly don't know. I've seen both

@thaJeztah Quick survey looks like most of the built-in vars are caps based on hangover days from DOS. Some mixed case and a handful of lowercase. I'll update to upper, and also address the comment from @duglin about the addition check to make sure W/A/U is valid shortly.

Updated to address comments.

still LGTM once janky is done

Thanks for checking @jhowardmsft, 👍 for changing to uppercase. Guess we need to do the same for docker run?

@thaJeztah Yes, I have another PR to deal with deduping on docker run and uppercasing. Will be submitting that today, I'm just finishing up the integration test for it. There's various pieces of the whole puzzle here as I mentioned in the description of this PR.

@thaJeztah docker run (and docker create or anything that populates config.Env in the runconfig) PR submitted - #28770.

LGTM
nit: could probably save some lines and cpu cycles by doing
var equalEnv = func(s1, s2 string)bool {return s1 == s2}
func init() {
  if windows {
   equalEnv = strings.EqualFold
  }
}

but not needed if you prefer converting.

ping @duglin PTAL

@duglin - Hey Doug - just think @vieux wants another quick review after the latest revision so we can get this into 1.13. Any chance you have time to review/LGTM? Thanks :smile:

yep - still LGTM


Adding ZFModalTransitonDirectionTop & ability to specify multiple values

This PR allows you to be able to specify the modal should be able to come in from the top and it also allows you to specify two values such that you can drag to dismiss the modal from the top & bottom.
demo:
https://www.dropbox.com/s/99765qqwagwdrfe/screencast 2015-01-17 15-59-59_0_edited.mp4?dl=0

@MikeSilvis Thanks!! I will look at it and merge by this week :)

@zoonooz hey i resolved the merge conflicts. Did you get a chance to look at this yet?

Hi @MikeSilvis ,
I think we should not put close directions to the same property as open direction because it confuse dev that which direction is for open or close. My suggestion is we leave the direction for open and close (which is opposite to open) and have another property as bitwise to specify which directions that allow user to drag to close.


Set up the rust folder

Setup the rust folder for the new tockloader. This implies using cargo for a default rust project structure.

Hello! What should we do with the python version when porting to rust? Do we leave it as-is in the repository, or should we separate the rust and python versions into two different folders, keeping at the root of the repository only the project-specific files (README, LICENSE, etc.)

I suggest separating them into different folders.

Closed by #8.


mobile: Fixes the StatFlushIntegrationTest test

This commit makes sure the CountDownLatch is set up before flushStats(), but await() is called after flushStats(), so that we don't miss any updates from the TestStatsdServer and we don't block on a condition that never gets triggered.
Fixes #24657
Testing: bazelisk test --config=test-android --define=signal_trace=disabled --test_output=streamed --cache_test_results=no --test_arg="-l info" test/kotlin/integration:stat_flush_integration_test --runs_per_test=100

/retest

/retest


WIP: Triptych app changes

Asana task: [Timebox] Investigate babel config to possibly transpile from react to plain JS
Working on some webpack changes for getting the packaged triptych app compiled down to something the hardware can handle. Will update PR as OFM gives app feedback.
App has been running well on OFM lab screens so this may be the best we can do at the moment. Some key changes:

A new webpack entry has been created for Triptych packaging. This eliminates the need to change webpack when we are packaging up the app. The babel config for the new entry targets the oldest browsers possible (this is done by default when no targets are provided).

All images in Triptych widgets are imported by default so that webpack preloads them in specific folders. We then only zip those folders up in the OFM package. This helps keep package size down.

Any changes made to the existing webpack entry are there to allow backwards compatibility. This should only be a file-loader config for images. I found that if one entry configured file-loader for images, others needed to as well. Regardless, it seemed like a good idea to explicitly configure them.

[ ] Tests added?

Oh, it looks like this has some conflicts, since unfortunately it branched off before my linting changes 😓 Sorry for the extra work!

ah... "WIP" commit on main 😅

ah... "WIP" commit on main 😅

Dangit. I even looked right at those letters and thought "Yeah looks good"...


removeLeadingBoolean does not remove upper case AND/OR

Using the following code:
    $builder->where('tim', '=', 'bob', 'AND');
    $statement = $builder->toSql();

$statement will build something similar to:
  select * where AND `tim` = ?

expected:
 select * where `tim` = ?

A simple fix might just be to add a case insensitive flag to removeLeadingBoolean in Illuminate\Database\Query\Grammars\Grammar

Ping @taylorotwell.

@timgws is there any scenario in which you would need to distinguish between case? Just thinking if it needs to be a flag or if we could just rewrite it with a strtolower

@phroggyy not that I know of. I don't think there is any database that is case sensitive for the conditions. Changing all of the operators/booleans with strtolower was my first thought, but there are so many functions that would need to be changed. This is why I thought changing the regular expression in removeLeadingBoolean might be better, as less code would need to be updated.

@timgws I just solved this using a simple strtolower in removeLeadingBoolean, do you see any flaws in this?


Addition

See https://github.com/seek-for-android/allow-all-ara/blob/master/com/gieseckedevrient/javacard/allowall/AllowAll.java and https://github.com/martinpaljak/GlobalPlatformPro/pull/82

Thank you, added into Applet build, upload and management part of the list - although I need to investigate further what this means. Is this relevant for JavaCard applets on SIM for Android, or elsewhere as well?


Add option toggle autoAddInvalidUnusual = false

If the bot accepts an Unusual item that is not on the price list it will not put it back up for sale unless autoAddInvalidUnusual is set to true. The option is set to false by default to protect users who use the generic price SKU and unaware that autoAddInvalidItems would sell off anything purchased via that generic sku.
Based off conversation in #400

Not at the moment. That could be considered a secondary part to this safety net. An option like notifyAcceptedInvalidUnusual or something?

yeah, something like that. I might add that while you're focusing on your medical work.

The latest commit should do the notifying job.

this looks good now I guess. merging...


TextInput's secureTextEnry={true} not working with keyboardType="email-address" on Android

Is this a bug report?
Yes

Have you read the Bugs section of the How to Contribute guide?
Yes

Environment

react-native -v: 0.45.1
node -v: v8.2.1
npm -v: 4.6.1
yarn --version:

Then, specify:

Target Platform: Android, iOS

Development Operating System: macOS Sierra

Build tools:

Steps to Reproduce

(Write your steps here:)

Use secureTextEntry={true} with  keyboardType="email-address"
secureText will not work on Android. (work well on iOS)
without keyboardType="email-address", secureText works well on Android.
(I used my Samsung Galaxy S6 device.)

Expected Behavior

Just add secureText={true} with keyboardType="email-address"  on TextInput.
I expected everything just go well.
Actual Behavior

I wanted to use email-address keyboard for password and make TextInput safe with secureText={true}.
I wrote secureTextEntry={true} with  keyboardType="email-address",
and something went awkward.
Only on iOS, it worked well not on Android.
[iOS]

[Android]

=> nothing happen. There are no circle characters.
Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

Why email should be secured?

@henrikra First I'm sorry for my nonfluent English. I thought the layout of email address keyboard would be appropriate for my password input, because I validate this password with alpha-numeric characters. There would be no problem when using 'Default' type keyboard, but I thought there are some possibilities some services would force users to use some layouts like email, numeric and etc.

I think poongnewga is saying the password field is not hiding the password on Android


Feature request: add the original line numbers on the left hand side so that its user for the receiver to find the same spot on this setup

Must be an option but definitely need to be enabled only if needed


Add UML diagram about AWS Getting started using Elastic Beanstalk

https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/GettingStarted.html

https://aws.amazon.com/elasticbeanstalk/


fixing github var naming.

BOSH is trying to interpolate the fields as actual canoncial paths
within the YAML syntax. by replacing github.x with github_x, the
variables can be interpolated and deployed properly.
fixes #79
Signed-off-by: Mike Lloyd<EMAIL_ADDRESS>

Following on from the conversation in #79 just adding a note to say that the CF SAPI team would also like this merged as its stopping us upgrading to 4.0.0 tracker story. Thanks!

thanks!


[google_maps_flutter][android] Small polyline/polygon is jaggy (LatLng loses precision at toPoints() in Convert.java)

I have a flutter GNSS RTK project. It needs to draw accurate polylines/polygons, but now they are jaggy.
Steps to Reproduce
Modify _createPoints() in example/lib/place_polyline.dart to draw a small straight line.
  List<LatLng> _createPoints() {
    final List<LatLng> points = <LatLng>[];
    for (int i = 0; i < 1000; i++) {
      points.add(_createLatLng(
          53.1721000 + 0.0000001 * i.toDouble(),
          -3.5402000 + 0.0000001 * i.toDouble()
      ));
    }
    return points;
  }

Run the example and zoom up. You can see a jaggy polyline.

When I change toFloat() to toDouble() in toPoints() of Convert.java, it gets straight line.
  private static List<LatLng> toPoints(Object o) {
    final List<?> data = toList(o);
    final List<LatLng> points = new ArrayList<>(data.size());

    for (Object rawPoint : data) {
      final List<?> point = toList(rawPoint);
      //points.add(new LatLng(toFloat(point.get(0)), toFloat(point.get(1))));
      points.add(new LatLng(toDouble(point.get(0)), toDouble(point.get(1))));
    }
    return points;
  }

Hello exaby73-san. Thank you for putting up with me.
The "example" I used is https://pub.dev/packages/google_maps_flutter/example.
But anyway, I prepared a repo https://github.com/dojunmasaki/example115056. This is a minimized version, so that you don't need any operation to reproduce the issue. Just only build and run it. Please try.
flutter doctor -v
[✓] Flutter (Channel stable, 3.3.8, on Microsoft Windows [Version 10.0.19044.2006], locale ja-JP)
• Flutter version 3.3.8 on channel stable at C:\Users***\fvm\versions\3.3.8
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 52b3dc25f6 (2 days ago), 2022-11-09 12:09:26 +0800
• Engine revision 857bd6b74c
• Dart version 2.18.4
• DevTools version 2.15.0
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at C:\Android\SDK
• Platform android-33, build-tools 31.0.0
• ANDROID_HOME = C:\Android\SDK
• Java binary at: C:\Android\AndroidStudio\jre\bin\java
• Java version openjdk version "11.0.13" 2021-10-19
• All Android licenses accepted.
[✓] Chrome - develop for the web
• CHROME_EXECUTABLE = C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe
[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.3.3)
• Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
• Visual Studio Community 2019 version 16.3.29403.142
• Windows 10 SDK version 10.0.18362.0
[✓] Android Studio (version 2021.3)
• Android Studio at C:\Android\AndroidStudio
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version openjdk version "11.0.13" 2021-10-19
[✓] VS Code (version 1.63.2)
• VS Code at C:\Users***\AppData\Local\Programs\Microsoft VS Code
• Flutter extension can be installed from:
🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[✓] Connected device (4 available)
• M2010J19SG (mobile) • 50c5f72f0820 • android-arm64  • Android 11 (API 30)
• Windows (desktop)   • windows      • windows-x64    • Microsoft Windows [Version 10.0.19044.2006]
• Chrome (web)        • chrome       • web-javascript • unknown
• Edge (web)          • edge         • web-javascript • Microsoft Edge 107.0.1418.35
[✓] HTTP Host Availability
• All required HTTP hosts are available
• No issues found!

Triage report
I can reproduce this issue on the latest plugin version (2.2.1).
To reproduce, add your API key in the AndroidManifest.xml file as per https://pub.dev/packages/google_maps_flutter#android and run the code sample below as is.

Simplified Code Sample
import 'package:flutter/material.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: Scaffold(
        appBar: AppBar(title: const Text('Place polyline (Issue #115056)')),
        body: const PlacePolylineBody(),
      ),
    );
  }
}

class PlacePolylineBody extends StatefulWidget {
  const PlacePolylineBody({Key? key}) : super(key: key);

  @override
  State<StatefulWidget> createState() => PlacePolylineBodyState();
}

class PlacePolylineBodyState extends State<PlacePolylineBody> {
  PlacePolylineBodyState();

  GoogleMapController? controller;
  late final Polyline _polyline;

  // ignore: use_setters_to_change_properties
  void _onMapCreated(GoogleMapController controller) {
    this.controller = controller;
  }

  @override
  void initState() {
    super.initState();
    _add();
  }

  @override
  void dispose() {
    super.dispose();
  }

  void _add() {
    final Polyline polyline = Polyline(
      polylineId: const PolylineId('id'),
      consumeTapEvents: true,
      color: Colors.orange,
      width: 5,
      points: _createPoints(),
    );

    setState(() {
      _polyline = polyline;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Column(
      mainAxisAlignment: MainAxisAlignment.spaceEvenly,
      crossAxisAlignment: CrossAxisAlignment.stretch,
      children: <Widget>[
        Center(
          child: SizedBox(
            width: 350.0,
            height: 300.0,
            child: GoogleMap(
              initialCameraPosition: const CameraPosition(
                target: LatLng(53.1721, -3.5402),
                zoom: 25.0,
              ),
              polylines: {_polyline},
              onMapCreated: _onMapCreated,
            ),
          ),
        ),
      ],
    );
  }

  List<LatLng> _createPoints() {
    final List<LatLng> points = <LatLng>[];
    for (int i = 0; i < 1000; i++) {
      points.add(
        _createLatLng(
          53.1721000 + 0.0000001 * i.toDouble(),
          -3.5402000 + 0.0000001 * i.toDouble(),
        ),
      );
    }
    return points;
  }

  LatLng _createLatLng(double lat, double lng) {
    return LatLng(lat, lng);
  }
}

Screenshot

@stuartmorgan Can you double check the android teams assessment of priority? Gut says this is a p4 but could be higher since precision is being lost.

Yes, p4 looks right.


Move more autofill classes out of api and into autofill-impl

Task/Issue URL: https://app.asana.com/0/488551667048375/1205284527878905/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #3468   👈

This comment was auto-generated by Graphite.


gofumpt removes choice:"..." tags, only first is left

I have a problem in a project, where we use auto formatting with gofumpt.
The auto format removes all additional tags with the same tag-name from a field.
Expect:
var FlagLogLevel string `short:"L" long:"log-level" default:"info" choice:"debug" choice:"info" choice:"warn" choice:"error" description:"Set the log level of the output messages"`

Actual:
var FlagLogLevel string `short:"L" long:"log-level" default:"info" choice:"debug" description:"Set the log level of the output messages"`

Maybe someone has an idea what is the cause of this, and how to prevent this.

Maybe someone has an idea what is the cause of this, and how to prevent this.

Isn't this a problem with gofumpt ?
Why code formatter touching anything that surrounded by `` at all ?
IMHO any data shouldn't be touched by any pre-processors


How can i add Button in my SCM view

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

I need to add button in my SCM viewlet
I am adding this in package.json

But its getting overide by content like once file get load

You can see both images
i need to add that button under that file section or above
How can i do that.

I don't think it's possible to do that. The closest you can get would be to contribute to the scm/title menu. See https://code.visualstudio.com/api/extension-guides/scm-provider#menus
the viewsWelcome contribution point only allows addition of text and buttons to an empty view. As soon as the view gets populated (in this case by the Git SourceControlProvider) the contributed content no longer shows.

@inchara-1998, while there is no way to currently add a button to the Source Control view, I would suggest that you subscribe to the following issue as it describes the extension api proposal for the action button - https://github.com/microsoft/vscode/issues/133935. This is the api that is currently being used by the vscode.git extension to contribute the "Publish Branch", "Sync Changes", "Commit" action buttons.


Propagate maven_coordinates tag to generated scala_import so pom generation includes the dependency

Description

Add a maven_coordinates= tag to the generated scala maven dependency targets.

Motivation

rules_jvm_external pom generation uses the maven_coordinates=x:y:z tag to determine the formatting of a dependency in the pom. Because this tag is missing, the scala dependencies are excluded from the generated pom.
I need for example @io_bazel_rules_scala_scala_library//jar to appear in my generated pom as
<dependency>
    <groupId>org.scala-lang</groupId>
    <artifactId>scala-library</artifactId>
    <version>2.13.12</version>
</dependency>

@liucijus CLA was signed and submitted yesterday. It was a corporate CLA, so according to opensource.google/documentation/reference/cla#cla-accepted , it might take a couple days for it to process.

CLA is approved


Testing Only: Utility Nav Links throwing a 404 Error

The options available under the utility navigation are throwing a 404 error
When a user clicks on any of the options available under the utility navigation (Help/Support, Resources etc), system throws a 404 error. Looks like the URL needs to be fixed to include 'ecmps' in it

Bug has been resolved


Enable UART support for this addon

This PR is intended to fix evcc-io/evcc#3233
RS485-to-USB-Adapters connected to the Home Assistant OS Raspberry should be visible to evcc afterwards
Setting uart:true adds the following in the Docker config:
"DeviceCgroupRules": [
  "c 188:* rwm",
  "c 204:* rwm",
  "c 166:* rwm"
],

this enables access to the following devices:
 166 char	ACM USB modems
		  0 = /dev/ttyACM0	First ACM modem
		  1 = /dev/ttyACM1	Second ACM modem
		    ...

 188 char	USB serial converters
		  0 = /dev/ttyUSB0	First USB serial converter
		  1 = /dev/ttyUSB1	Second USB serial converter
		    ...

 204 char	Low-density serial ports
		  0 = /dev/ttyLU0		LinkUp Systems L72xx UART - port 0
		  1 = /dev/ttyLU1		LinkUp Systems L72xx UART - port 1
		  2 = /dev/ttyLU2		LinkUp Systems L72xx UART - port 2
		  3 = /dev/ttyLU3		LinkUp Systems L72xx UART - port 3
		  4 = /dev/ttyFB0		Intel Footbridge (ARM)
		  5 = /dev/ttySA0		StrongARM builtin serial port 0
		  6 = /dev/ttySA1		StrongARM builtin serial port 1
		  7 = /dev/ttySA2		StrongARM builtin serial port 2
		  8 = /dev/ttySC0		SCI serial port (SuperH) - port 0
		  9 = /dev/ttySC1		SCI serial port (SuperH) - port 1
		 10 = /dev/ttySC2		SCI serial port (SuperH) - port 2
		 11 = /dev/ttySC3		SCI serial port (SuperH) - port 3
		 12 = /dev/ttyFW0		Firmware console - port 0
		 13 = /dev/ttyFW1		Firmware console - port 1
		 14 = /dev/ttyFW2		Firmware console - port 2
		 15 = /dev/ttyFW3		Firmware console - port 3
		 16 = /dev/ttyAM0		ARM "AMBA" serial port 0
		    ...
		 31 = /dev/ttyAM15		ARM "AMBA" serial port 15
		 32 = /dev/ttyDB0		DataBooster serial port 0
		    ...
		 39 = /dev/ttyDB7		DataBooster serial port 7
		 40 = /dev/ttySG0		SGI Altix console port
		 41 = /dev/ttySMX0		Motorola i.MX - port 0
		 42 = /dev/ttySMX1		Motorola i.MX - port 1
		 43 = /dev/ttySMX2		Motorola i.MX - port 2
		 44 = /dev/ttyMM0		Marvell MPSC - port 0 (obsolete unused)
		 45 = /dev/ttyMM1		Marvell MPSC - port 1 (obsolete unused)
		 46 = /dev/ttyCPM0		PPC CPM (SCC or SMC) - port 0
		    ...
		 47 = /dev/ttyCPM5		PPC CPM (SCC or SMC) - port 5
		 50 = /dev/ttyIOC0		Altix serial card
		    ...
		 81 = /dev/ttyIOC31		Altix serial card
		 82 = /dev/ttyVR0		NEC VR4100 series SIU
		 83 = /dev/ttyVR1		NEC VR4100 series DSIU
		 84 = /dev/ttyIOC84		Altix ioc4 serial card
		    ...
		 115 = /dev/ttyIOC115		Altix ioc4 serial card
		 116 = /dev/ttySIOC0		Altix ioc3 serial card
		    ...
		 147 = /dev/ttySIOC31		Altix ioc3 serial card
		 148 = /dev/ttyPSC0		PPC PSC - port 0
		    ...
		 153 = /dev/ttyPSC5		PPC PSC - port 5
		 154 = /dev/ttyAT0		ATMEL serial port 0
		    ...
		 169 = /dev/ttyAT15		ATMEL serial port 15
		 170 = /dev/ttyNX0		Hilscher netX serial port 0
		    ...
		 185 = /dev/ttyNX15		Hilscher netX serial port 15
		 186 = /dev/ttyJ0		JTAG1 DCC protocol based serial port emulation
		 187 = /dev/ttyUL0		Xilinx uartlite - port 0
		    ...
		 190 = /dev/ttyUL3		Xilinx uartlite - port 3
		 191 = /dev/xvc0		Xen virtual console - port 0
		 192 = /dev/ttyPZ0		pmac_zilog - port 0
		    ...
		 195 = /dev/ttyPZ3		pmac_zilog - port 3
		 196 = /dev/ttyTX0		TX39/49 serial port 0
		    ...
		 204 = /dev/ttyTX7		TX39/49 serial port 7
		 205 = /dev/ttySC0		SC26xx serial port 0
		 206 = /dev/ttySC1		SC26xx serial port 1
		 207 = /dev/ttySC2		SC26xx serial port 2
		 208 = /dev/ttySC3		SC26xx serial port 3
		 209 = /dev/ttyMAX0		MAX3100 serial port 0
		 210 = /dev/ttyMAX1		MAX3100 serial port 1
		 211 = /dev/ttyMAX2		MAX3100 serial port 2
		 212 = /dev/ttyMAX3		MAX3100 serial port 3

Just in case anyone is wondering, the option uart: true also allows to access USB devices via their ID and not just /dev/ttyACM0. This will enable you to set a persistent path for the USB device (in my case: USB-Modbus adapter) in the config. You can go to Settings > System > Hardware > All Hardware in Home Assistant and search for "usb" which should show something like /dev/serial/by-id/usb-dresden_elektronik_ingenieurtechnik_GmbH_ConBee_II_DE1231231-if00 which you can use.
The addon docker container should be able to access it this way too, I've tried the following to verify:
➜  ~ docker exec -it addon_49686a9f_evcc /bin/sh
/app # ls -lah /dev/serial/by-id/
total 0
drwxr-xr-x    2 root     root          60 Jun 16 12:35 .
drwxr-xr-x    4 root     root          80 Jun 16 12:35 ..
lrwxrwxrwx    1 root     root          13 Jun 16 12:35 usb-dresden_elektronik_ingenieurtechnik_GmbH_ConBee_II_DE1231231-if00 -> ../../ttyACM0
/app #

A Modbus Adapter from Dresden Elektronik with the Name ConBee II ?

Sure it does, because it's relying on device types, not on filesystem names. From my point of view this is just an informational notice, right?

A Modbus Adapter from Dresden Elektronik with the Name ConBee II ?

No, that was just a ZigBee stick that I had plugged in anyway. A cheap 2€ modbus adapter will have a different name.

Sure it does, because it's relying on device types, not on filesystem names. From my point of view this is just an informational notice, right?

Yes indeed, purely informational if someone else is trying to get a Modbus USB Stick running within the HomeAssistant evcc plugin


README: Install from Github clone

The Install from Github clone instructions appear to be out of date. The library/rpi-ws281x directory no longer exists in the repository.
And on a more minor level, I would suggest changing the header to capitalize it as GitHub.

Good spot, the rpi-ws281x library was never really part of Unicorn HAT so I've been disentangling the two and haven't updated the docs yet.
Its new home is: https://github.com/pimoroni/rpi_ws281x-python


Delete StreamStateMachineBase::Parameters

It's just two parameters, pass them manually without all the hassle.
Gets rid of some unneeded "Base" typedefs along the way, kills commented out
code, removes some unused headers, and of course runs clang-format.

Following up on this, I'm gonna try to remove the uses of std::shared_ptr<StreamsWriter>, and see if it makes sense to replace them with StreamsWriter&, as the individual state machine objects should not persist past RSocketStateMachine (at least I hope they don't have to).