error after running fish_prompt

I launched fish_prompt and chose a different prompt. THen immediately after I get these errors. (note, for below, i ran fisher -v which is how first line came up.
any suggestions for what to do? uninstall fisher? fisherman? i tried reinstalling but still got stuck.
fisherman version 2.12.0 ~/.config/fish/functions/fisher.fish
fish: Unknown command 'git_branch_name'
~/.config/fish/functions/fish_prompt.fish (line 1): git_branch_name
                                                    ^
in command substitution
	called on line 0 of file ~/.config/fish/functions/fish_prompt.fish

in function 'fish_prompt'
	called on standard input

in command substitution
	called on standard input

fish: Unknown command 'segment'
~/.config/fish/functions/fish_prompt.fish (line 66):     segment "$root" $root_color
                                                         ^
in function 'fish_prompt'
	called on standard input

in command substitution
	called on standard input

fish: Unknown command 'segment_close'
~/.config/fish/functions/fish_prompt.fish (line 68):     segment_close
                                                         ^
in function 'fish_prompt'
	called on standard input

in command substitution
	called on standard input

if i remove fish_prompt.fish from my functions then instead i get the following error:
source: Error encountered while sourcing file '/Users/2sman/.local/share/fisherman/config.fish':
source: No such file or directory

@lee2sman Try uninstalling all plugins fisher ls | fisher rm, but if you could make a step by step sequence that would help repro this, it would be helpful.
I was just able to install a theme, use fish_prompt to switch to another theme, then install another theme on top, uninstall it, and it was okay.

Thanks for getting back to me so fast.
running fisher ls | fisher rm unfortunately doesn't solve the issue. I still get the following error message:
fish: Unknown command 'git_branch_name'
~/.config/fish/functions/fish_prompt.fish (line 1): git_branch_name
                                                    ^
in command substitution
	called on line 0 of file ~/.config/fish/functions/fish_prompt.fish

in function 'fish_prompt'
	called on standard input

in command substitution
	called on standard input

fish: Unknown command 'segment'
~/.config/fish/functions/fish_prompt.fish (line 66):     segment "$root" $root_color
                                                         ^
in function 'fish_prompt'
	called on standard input

in command substitution
	called on standard input

fish: Unknown command 'segment_close'
~/.config/fish/functions/fish_prompt.fish (line 68):     segment_close
                                                         ^
in function 'fish_prompt'
	called on standard input

in command substitution
	called on standard input

This whole thing started after i launched fish_prompt. After I had selected a prompt, that's when the errors started.

step by step to reproduce this (sorry i can't be more detailed)

already have been using fisherman for a year or two. so far so good!
today i ran fish_prompt, chose a prompt in the gui/browser, and saved, and quit. then got the following error.

you should know that i keep my fish functions in a dotfiles, which i'm wondering if that's related to getting these errors.

@lee2sman It seems fish_prompt is "corrupted" or fisherman can't get at it for some reason. After you run fisher ls | fisher rm all plugins should have been uninstalled, but it seems that didn't happen.
What's inside your fishfile?

Hmmm.
Here's what's in my fishfile.
spin
debug
segment
git-branch-name
git-is-repo
git-is-dirty
git-is-staged
git-is-touched
git-is-stashed
git-is-empty
git_util

@lee2sman Wow, it seems you're being hit by the rename from git-function-name to git_function_name that happened more than a year ago! 😲
Let's remove:
git-branch-name
git-is-repo
git-is-dirty
git-is-staged
git-is-touched
git-is-stashed
git-is-empty

from your fishfile first.

you're right. my fish_prompt is wiped out. i just checked, empty file.

i removed the git-* things from fishfile

@lee2sman BTW, if your fish_prompt is empty, then previous fish_prompt function must be loaded in the session, so try opening a new session.

relaunching doesn't help.
how do i totally remove fisherman? and then reinstall?

oh i see, relaunching does work. it loads the following in my fish_prompt.fish
function fish_prompt
	set -l status_copy $status
    set -l cwd
    set -l root_color ffc magenta
    set -l root (set_color -o)"  ̸ "(set_color normal)

    switch "$PWD"
        case "$HOME"\*
            set root_color ffc green
            set root (set_color -o)" ~ "(set_color normal)
    end

    set cwd (echo "$PWD" | sed -E "s|$HOME/?||")

    set -l base (basename $cwd)

    switch "$cwd"
        case "" /
        case \*
            segment " $base " black fc0
    end

    set branch_name

    if set branch_name (git_branch_name)
        set -l color black ffc
        set -l repo_status
        set -l padding
        set -l branch_ref ➦

        if git symbolic-ref HEAD ^ /dev/null > /dev/null
            set padding " "
            set color ffc magenta
            set branch_ref 
        end

        if git_is_touched
            set color black ffc
            set padding

            if git_is_staged
                set repo_status "✚ "
            end

            if git_is_dirty
                set repo_status "✦ "
            end

        else if git_is_empty
            set repo_status "● "

        else if git_is_stashed
            set repo_status "•• "
        end

        segment "$padding$branch_ref $branch_name $repo_status" $color
    end

    set -l dir (dirname $cwd | sed -E 's|(^/)?([^/.])[^/]*|\2|g')

    switch "$dir"
        case "" / .
        case \*
            segment " $dir " black ffc
    end

    segment "$root" $root_color

    segment_close
end

If you want to completely remove fisherman, try fisher self-uninstall, it's fun!
But don't think that will solve the problem.

haha, it is fun. but you're right, i still get the exact same errors.

for fun, i also uninstalled fish and reinstalled. at startup i get these errors:
source: Error encountered while sourcing file '/Users/2sman/.local/share/fisherman/config.fish':
source: No such file or directory

and then the whole error message above that starts with fish: Unknown command 'git_branch_name'

You said in https://github.com/fisherman/fisherman/issues/379#issuecomment-294382714 that the contents of your fish_prompt is that, so the problem is obviously fish is running the wrong fish_prompt.
What's the contents inside ~/.config/fish/functions?

@lee2sman What's in /Users/2sman/.local/share/fisherman/config.fish?

very ineresting, there is no config.fish there. a guess, maybe i was symlinking from dotfiles and that got removed?
for previous question, all my functions are there in the ~/.config/fish/functions directory.
thanks for sticking with me! :)

here's my dotfiles' config.fish

@lee2sman
Are you completely sure this is good?
set fisher_home ~/.local/share/fisherman
set fisher_config ~/.config/fisherman

I ask because fisherman requires no configuration, but it used to (like 2 years ago) so if you are an old-timer you may have never heard about it.

i've been using fish maybe 2 years or more.
hmmm.
i just commented out those two lines and now my terminal hangs on launch.

BTW there's a Slack room, which you are welcome to join for real-time support! :P

haha, that would be great. where is that?

https://fisherman-wharf.herokuapp.com/


Text is blurry

I'm on macOS 13.2.1, with M1. When I run the editor-libcosmic example, the text looks blurry compared to native text. Some time ago I head this issue with nuklear. It was related to antialiasing. (Notice also on the screenshot some symbols aren't rendered, but I'm not sure whether it's related to cosmic-text.)

I believe this is an issue with the image renderer in iced, try the editor-orbclient example.

It's blurry too:

I'm going to try making a softbuffer example. I believe this is HiDPI scaling on macOS causing the issue and orbclient is not handling that correctly.

This also happens on Linux with Gnome on Wayland, with a 2560x1600 display.
Like the image below show, the editor-libcosmic (left side) window's fonts are much blurry than those in firefox (left side).

@VitalyAnkh please see if the orbclient example has the same problem on Linux. I believe there are two different issues here:

editor-libcosmic rendering in an image that is 1x scale on HiDPI systems
editor-orbclient not telling macOS it is HiDPI capable

Fixed in the latest commit, for editor-libcosmic. Not fixed for editor-orbclient on macOS, but I recommend the libcosmic example since it uses native macOS rendering.

@jackpot51 Confirmed it's also fixed for editor-libcosmic on Linux with gnome wayland with HiDPI display.

And editor-orbclient is still blurry as you said.

Can confirm it's fixed on macOS.

I seem to still have a problem with some of the text being blurry when running the editor-libcosmic example.
The interesting thing is that it seems to only be the text in the editor that is blurry and the rest of the UI is crisp.

I experienced the same issue as @HolgerGottChristensen

After bisecting I found the blur issue of editor-libcosmic originates from https://github.com/pop-os/cosmic-text/commit/f6f56a93be8500fe3b43558730c171f08e5ce5d7. This commit just updated the revision of libcosmic, so the real problem in libcosmic is to be investigated :rocket:

@ltrook21 Chrome doesn't use cosmic-text


Virtual Node

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
This PR refers issues #1766.
How Has This Been Tested?

/build

/build

/build

/build

/build

/build

/build

/build

/build

/rebase test=true

/test

/rebase test=true

/rebase test=true

/rebase test=true

/test

/rebase test=true

/rebase test=true

/rebase test=true

/rebase test=true

/merge


Check for loop or uv for lazypath

Fixes #1073
This is the suggested way from https://lazy.folke.io/installation and should also work on older nvim versions.

@mike-jl this LGTM.
I'd suggest you remove the NOTE block in the PR description, as it makes it look like it's a PR opened by mistake.

Done! Thanks for the heads up!

Hi, sorry for noticing this so late, but I think this is just clutter, because our other config stuff like type hints or even plugins like conform don't support older nvim versions and require 0.10, where vim.loop is deprecated

Should I publish a revert?


Error creating VM: 596 tls_process_server_certificate: certificate verify failed

It appears to be failing with a TLS cert error. However, my Linux machine fully trusts the self-signed CA certs on my ProxmoxVE cluster. And I've set what I think is supposed to negate TLS verification in the main.tf file like so:
What I think should prevent the TLS error but is NOT doing so:

provider "proxmox" {

pm_api_url      = "https://server.domain.home:8006/api2/json"
pm_user         = "terraform@pve"
pm_tls_insecure = true
pm_parallel     = 4
}

Here's the error:
tf apply main-plan.tfplan

proxmox_vm_qemu.terraform_test1: Creating...
Error: Error creating VM: 596 tls_process_server_certificate: certificate verify failed, error status:  (params: map[agent:1 bios:seabios boot:cdn cores:4 cpu:kvm64 description:testing terraform deployment hotplug:network,disk,usb ide2:ISOs1/terraform-ubuntu-16.04.6-server-amd64.iso,media=cdrom memory:4096 name:terraform_test1 net0:virtIO=AE:05:4A:A4:2F:B5,bridge=vmbr1,tag=110 numa:false onboot:true ostype:l26 sockets:1 vmid:108])
on main.tf line 10, in resource "proxmox_vm_qemu" "terraform_test1":
10: resource "proxmox_vm_qemu" "terraform_test1" {

Anyone have any experience with the above?
I'm all for fixing the code myself, but I'm new to Terraform and to the Proxmox TF provider. Not sure where to start at, yet.

For some reason the provider {} entry wasn't getting parsed correctly, and I was getting prompted for credentials and warned about missing pm_api_url which I made sure wasn't actually missing. I rewrote the provider section, included all of the options even if just set to blank "", and it worked. Here's my working provider section block:
provider "proxmox" {   pm_tls_insecure = true   pm_api_url = "https://server.domain.home:8006/api2/json"   pm_password = "secret"   pm_user = "terraform@pve"   pm_otp = "" }

Seem to be running into this issue as well. The error I see is:
proxmox_vm_qemu.vms["tungsten_ic-001"]: Creating...

Error: Error creating VM: 596 tls_process_server_certificate: certificate verify failed, error status:  (params: map[agent:0 bios:seabios boot:cdn cores:2 cpu:host description: hotplug:network,disk,usb ide2:local:ic-os 08062020.iso,media=cdrom memory:16384 name:tungsten_ic-001 numa:false onboot:true ostype:l26 sockets:1 vmid:100])

  on main.tf line 65, in resource "proxmox_vm_qemu" "vms":
  65: resource "proxmox_vm_qemu" "vms" {

pm_tls_insecure = true has been set on the provider and tested when set and unset. When unset, it fails to even get to the the plan. When set, it fails when applying.
Tried changing the order of the declarations as specified above, but no luck.
Tried blank options as well. No luck with those either.
Running the latest master from Telmate/terraform-provider-proxmox

I'd love to dig myself out of this, but after a day of debugging, I got nowhere with this. Any suggestions?

Not sure if this will help but here's my full main.tf minus the password and real server name...
provider "proxmox" {
  pm_tls_insecure = true
  pm_api_url = "https://server:8006/api2/json"
  pm_password = ""
  pm_user = "terraform@pve"
  pm_otp = ""
  pm_parallel = 4
}

resource "proxmox_vm_qemu" "terraform-test3" {
  name        = "terraform-test3"
  target_node = "server"
  iso        = "ISOs1:iso/terraform-ubuntu-16.04.6-server-amd64.iso"
  desc       = "testing terraform deployment"
  agent      = 1
  memory     = 4096
  cores      = 4
  sockets    = 1
  cpu        = "kvm64"
  os_type    = "ubuntu"
  disk {
    id = "0"
    type = "virtio"
    storage = "virt-farm1"
    storage_type = "nfs"
    size = "16384M"
    format = "qcow2"
    cache = "writeback"
  }
  full_clone = false
  network {
    id       = "0"
    model    = "virtio"
    bridge   = "vmbr1"
    tag      = 110
    firewall = false
  }

  #ssh_forward_ip = "<IP_ADDRESS>"
  ssh_user = "terraform"
  ssh_private_key = file("./terraform")

  os_network_config = <<EOF
    auto eth0
    iface eth0 inet dhcp
  EOF

  connection {
    certificate_verify = false
    type        = "ssh"
    user        = self.ssh_user
    private_key = self.ssh_private_key
    host = self.ssh_host
    port = self.ssh_port
  }
}

Obviously you'll want to adjust your ISO, or template that you're deploying. Let me know if this helps.

FWIW: I got this error when using an incorrect target_node (in this example X.X.X.X) with the corresponding error in /var/log/daemon.log:
Mar 11 16:43:48 pve-lab-01 pveproxy[65990]: '/etc/pve/nodes/X.X.X.X/pve-ssl.pem' does not exist!#012

FWIW: I got this error when using an incorrect target_node (in this example X.X.X.X) with the corresponding error in /var/log/daemon.log:
Mar 11 16:43:48 pve-lab-01 pveproxy[65990]: '/etc/pve/nodes/X.X.X.X/pve-ssl.pem' does not exist!#012

So you're suggesting it was an incorrect IP address for the PVE node that caused the issue?

In my case I used an IP address as target_node which did not work as the nodes have  names, so if you use the same name as used in the /etc/pve/nodes directory it should not be a problem (for me it worked).
E.g. if you have 3 nodes in the cluster: node-1, node-2, node-3, then in /etc/pve/nodes you should have 3 directories called the same, use one of them (e.g. node-2) as target_node and that fixed it for me.

I was also getting the 596 tls_process_server_certificate: certificate verify failed, error status: message when cloning an LXC template. Several Google searches for that error suggested running:
pvecm updatecerts -force
systemctl restart pvedaemon pveproxy

but running it that did not make the problem go away.
Thanks to @Magentron's pointers I realized that I was incorrectly setting target_node to my node's FQDN (ie: pve1.lan) instead of its actual node name as it appears in the WebUI / Datacenter tree (ie: pve1). After fixing that it worked.
PS: After re-reading the target_node documentation, it actually never mentions host or hostname but node name


Incorrect selection Name

[Enter feedback here]
Step 4 on this page is:
4. Select the user's name to go to their properties pane, and on the Account tab, select Initiate sign-out.
Please change "select Initiate sign-out" to "Sign out of all sessions".  This is what is actually displayed on the Accounts section.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4ecd4f58-0a50-05f2-426d-6bc8ca8f5940
Version Independent ID: b3344450-204e-3bb4-54ad-5fa4f85a2695
Content: Step 1 - Stop an employee from logging in to Microsoft 365 - Microsoft 365 admin
Content Source: microsoft-365/admin/add-users/remove-former-employee-step-1.md
Service: o365-administration
GitHub Login: @KwekuA
Microsoft Alias: kwekua

@haydanbarry Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/5379
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @haydanbarry Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


🧮 Implements fabs from math module

Adds fabs from the math module
PR Checklist:

[x] All new features have been tested
[x] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

Lines 8-19 are present in the other libraries in the code, we believe it's good to have them because in normal python you can type for example math.__name__. If you believe that's outside the scope of the PR we can remove them.
Line 33 matches how python behaves, print(type(math.fabs(int(1)))), but we agree it's not obvious so we added a comment to explain it better.
Good catch on the snake_case


6.0.x mergeup to master

@rbrw / @Zak-Kent we've merged these changes up through 6.0.x... and this is the final PR up to master to get some of the changes necessary to build Docker containers on Windows.
There was one merge conflict in project.clj, but I took what was on master - (def pdb-version "6.1.0-SNAPSHOT") from https://github.com/puppetlabs/puppetdb/blob/master/project.clj#L1

Test FAILed

Test PASSed

CLA signed by all contributors.

@Iristyle that was the right one to keep, thanks


Update dependency on Microsoft.IdentityModel.Clients.ActiveDirectory

This library builds with Microsoft.IdentityModel.Clients.ActiveDirectory >= 3.19.4. This version of the library has an additional DLL named 'Microsoft.IdentityModel.Clients.ActiveDirectory.Platform' which has been removed in version of Microsoft.IdentityModel.Clients.ActiveDirectory >= 4.
I have other dependencies which require Microsoft.IdentityModel.Clients.ActiveDirectory >= 4.5.0 which forces this library to use 4.5.0 and fail with a FileNotFoundException when trying to load 'Microsoft.IdentityModel.Clients.ActiveDirectory.Platform'

Can one of the admins verify this patch?

We are planning to release a new version with dependency on ADAL 4.X soon. @nonik0 , please see if you can use this PR for that. thanks!

New pull request: https://github.com/Azure/azure-sdk-for-net/pull/6734


GET /callsets/{id} fails when passed ID returned from POST /callsets/search

This is from `CallsetsSearchResponseCheckIT.getCallSetWithValidIDShouldSucceed'.  The rough outline is this:

Search VariantSets (POST /variantsets/search)
Store the first VariantSet returned in a local variable
Search for all CallSets (POST /callsets/search) with that variant set ID
Store the first CallSet returned in a local variable - theCallSet and ID in theId
Call GET /callsets/{theId}

Expected result: a CallSet object.
Actual result:  HTTP status 500: Internal Server Error.
The ref server reports the cause is KeyError.

Stack trace:
ERROR in app [/Users/hjellinek/Library/Python/2.7/lib/python/site-packages/flask/app.py:1423]:
Exception on /callsets/YnJjYTE6MWtnUGhhc2UzOkhHMDAwOTY= [GET]

 Traceback (most recent call last):
  File "/Users/hjellinek/Library/Python/2.7/lib/python/site-packages/flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "/Users/hjellinek/Library/Python/2.7/lib/python/site-packages/flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/Users/hjellinek/Work/server/ga4gh/frontend.py", line 535, in getCallset
    id, flask.request, app.backend.runGetCallset)
  File "/Users/hjellinek/Work/server/ga4gh/frontend.py", line 369, in handleFlaskGetRequest
    return handleHttpGet(id_, endpoint)
  File "/Users/hjellinek/Work/server/ga4gh/frontend.py", line 285, in handleHttpGet
    responseStr = endpoint(id_)
  File "/Users/hjellinek/Work/server/ga4gh/backend.py", line 558, in runGetCallset
    callSet = variantSet.getCallSet(id_)
  File "/Users/hjellinek/Work/server/ga4gh/datamodel/variants.py", line 346, in getCallSet
    return self._callSetIdMap[callSetId]
 KeyError: 'YnJjYTE6MWtnUGhhc2UzOlluSmpZVEU2TVd0blVHaGhjMlV6T2toSE1EQXdPVFk9'
 <IP_ADDRESS> - - [01/Sep/2015 10:04:32] "GET /callsets/YnJjYTE6MWtnUGhhc2UzOkhHMDAwOTY= HTTP/1.1" 500 -

Nice bug report @hjellinek --- these compliance tests are really giving me a warm fuzzy feeling!

Yes, I agree.  These bug reports are really easy to diagnose with all of this data, @hjellinek ... fix coming shortly...

Fixed in #602


The data directory was initialized by PostgreSQL version 11, which is not compatible with this version 12.2.

Hello,
The following Dockerfile example works well in PostgreSQL 11 and the database is initialized with SQL files copied from the host init folder to the container /docker-entrypoint-initdb.d
FROM postgres:11.0-alpine
COPY ./init/ /docker-entrypoint-initdb.d/

But a similar Dockerfile for PostgreSQL 12 fails with the error below.
FROM postgres:alpine
COPY ./init/ /docker-entrypoint-initdb.d/

The data directory was initialized by PostgreSQL version 11, which is not compatible with this version 12.2.

What would be the best way to reproduce the behavior from v11 to v12?
Thank you

Are you running them with the same volume? You cannot use the same database volume from 11 to 12.  You must do an upgrade to move between major versions. https://github.com/tianon/docker-postgres-upgrade is a good docker example of how to move from one to the next.
Here is upstream's documentation: https://www.postgresql.org/docs/current/upgrading.html
Duplicate of #37, #618.

Thanks for hint about the volume! I think I was running them on different volume but I am not able to reproduce the issue today so maybe I just got confused and forgot to remove the v11 volume before running v12.
Note I let Docker create the volume automatically with Docker Compose like this. Would there be a better way to do that?
version: "3.1"
services:
    db:
        container_name: mobydq-db
        restart: always
        image: mobydq-db
        build:
            context: ./db
        volumes:
            - db:/var/lib/postgresql/data
        env_file:
            - ./.env
        networks:
            - network

networks:
    network:

volumes:
    db:

Note I let Docker create the volume automatically with Docker Compose like this. Would there be a better way to do that?

A named volume is fine. Docker will keep it around; use docker volume ls to see them. docker compose will reuse the volume by name (so you don't lose data). You have to migrate the data to a new volume (with something like tianon/docker-postgres-upgrade) when you move major postgres versions or delete the old volume if you don't have any useful data there.


Fix ModMenu Version for 1.19 (update to 4.0.0)

The referenced Mod Menu version was wrong and doesn't even exist for 1.19. 4.0.0 is the correct version of mod menu for 1.19.

So it was the version after all, that aside, thanks for the contribution! :D


Publish a new version on npm

Kindly publish the latest to npm.
This: https://github.com/speakeasyjs/speakeasy/pull/72 among others are not present in the current package.

You can install package via git: npm i speakeasyjs/speakeasy -S.

You can install package via git: npm i speakeasyjs/speakeasy -S.

You just saved a day :)


Request: Add TaskbarX to winget source.

Is it possible to add TaskbarX to Winget source to be able to easily manage installation and update process?
https://docs.microsoft.com/en-us/windows/package-manager/package/

Can you package it as msix and add it to winget?

https://github.com/ChrisAnd1998/TaskbarX/issues/403#issuecomment-879041604

@shayvt, that's probably best filed as a separate issue, though I support it. If you file it, tag me and link it here for me, would you?


benchmarking cli runs with single request

Describe the bug
The current default of the benchmarking cli is none-sensical.
Expected behavior
Up the default repeats to 10 by default. Remove the example's overrides afterwards.

done with the new binary


feat(plugins): session replay plugin

Summary
This PR adds a new plugin to support session replay functionality. We will be adding additional configuration options in future revisions, this is the base functionality.
Checklist

[x] Does your PR title have the correct title format?
Does your PR have a breaking change?:  No

@justin-fiedler we have this new plugin package getting published soon. what are your thoughts on which branch we should merge this to and publish from? i think it's compatible with v1 and v2 (but need to confirm)

we have this new plugin package getting published soon. what are your thoughts on which branch we should merge this to and publish from? i think it's compatible with v1 and v2 (but need to confirm)

Can we only create it in main so it can be maintained in a single location? Would be nice if new features are only in a single branch.

@justin-fiedler @kevinpagtakhan where did we land with which branch I should merge this to? main or v1.x?


Fix perf-test input data and refactor two tests

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):

Build/Testing/Packaging Improvement

Short description (up to few sentences):

Add ability to send queries INSERT INTO tbl VALUES (.... to server without splitting on 'query' and 'data' parts.
Fix ipv4 and ipv6 performance tests.

Unfortunately I had to modify ASTInsertQuery outside of parser https://github.com/yandex/ClickHouse/pull/4301/files#diff-387f58c9305eb5dcc6cdb110eaf1382fR172. Is it OK, or it should be avoided?

It's Ok.

Performance test failure is expected.


middleware is broken with Sentry SDK 0.20

Sentry released a new SDK version 0.20.0 with breaking changes affecting this middleware, most notably removing hub.Scope().SetTransaction.
https://github.com/getsentry/sentry-go/releases/tag/v0.20.0
# github.com/johnbellone/grpc-middleware-sentry
/Users/johann/go/pkg/mod/github.com/johnbellone/grpc-middleware-sentry@v0.2.0/client_interceptors.go:33:15: hub.Scope().SetTransaction undefined (type *sentry.Scope has no field or method SetTransaction)
/Users/johann/go/pkg/mod/github.com/johnbellone/grpc-middleware-sentry@v0.2.0/client_interceptors.go:66:15: hub.Scope().SetTransaction undefined (type *sentry.Scope has no field or method SetTransaction)
/Users/johann/go/pkg/mod/github.com/johnbellone/grpc-middleware-sentry@v0.2.0/server_interceptors.go:48:15: hub.Scope().SetTransaction undefined (type *sentry.Scope has no field or method SetTransaction)
/Users/johann/go/pkg/mod/github.com/johnbellone/grpc-middleware-sentry@v0.2.0/server_interceptors.go:87:15: hub.Scope().SetTransaction undefined (type *sentry.Scope has no field or method SetTransaction)

Thanks! I saw that you forked, do you have a patch?


@conda-forge-admin, please add bot automerge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/aiochclient-feedstock#10.


Updated Bio From Template refs/heads/bio-template-2562906538

Automatically Generated by GitHub Action

Opened due to known bug, currently being resolved


The whole Core model is retrained even if only the templates section is changed

Description of Problem:
Having to retrain the Core ML model every time templates are changed is unnecessary and can be very expensive for a large project with lots of stories.
Overview of the Solution:
Create a separate, more granular fingerprint for the templates section in the domain and if only that has changed, simply replace that section in the new model and not retrain Core.
Examples (if relevant):

Blockers (if relevant):

Definition of Done:

[ ] Tests are added
[ ] Features described in the docs
[ ] Feature mentioned in the changelog
[ ] Any updates in Rasa X?

This is the default behavior;  the way to avoid retraining with template changes is to use an External CMS.
If there are no changes to the domain or the training data Rasa already prevents redundant training.

This is the default behavior; the way to avoid retraining with template changes is to use an External CMS.
I don't think the choice of using an external CMS or not should penalize you with unnecessary training time. A change in the text or triggers of the template does not change the outcome of the core model training and is therefore unnecessary, don't you think?

@msamogh this should be in progress, shouldn't it?

Yes. Thanks for noticing!

@btotharye additionally to what it says in the issue description here, someone mentioned recently that sometimes NLU retrains if some parts of the domain are changed as well. So we should look into what's going on there

So @btotharye is gonna finish up https://github.com/RasaHQ/rasa/pull/4251 ?

So @btotharye is gonna finish up #4251 ?

Hrm didn't know that was already out there, should I start with that PR code?

Why isn't @msamogh finishing this up and you @btotharye tackle the NLU part from @akelad 's comment?

I'm good with that if everyone agrees

haha my bad - i assumed this wasn't being tackled since @msamogh had unassigned himself

@btotharye have you looked into the other part yet?

I close this issue now since the nlu part is covered in #4691


Date data type

Get/Set/Add/Remove methods for date data type
Fixes #1076.
Checklist

[x] All acceptance criteria are met.
[] Relevant documentation, if any, has been written/updated.
[x] The changelog has been updated, if applicable.
[x] New functions/types have been exported in index.ts, if applicable.
[x] New modules (i.e. new .ts files) are listed in the exports field in package.json, if applicable.
[x] New modules (i.e. new .ts files) are listed in the typedocOptions.entryPoints field in tsconfig.json, if applicable.
[x] Commits in this PR are minimal and have descriptive commit messages.

Ah, and of course there were parallel changes in main that this has to align with too: abeda783.


Added GOPATH vars and godep to generator script

hack/update-generated-conversions.sh does not understand my project's GOPATH.  Adding GOPATH to the generator script fixes the issue.
This is the output before and after the change:
$ hack/update-generated-conversions.sh
Generating for version v1beta3
pkg/util/uuid.go:23:2: cannot find package "code.google.com/p/go-uuid/uuid" in any of:
	/Users/markturansky/Applications/go1.4.2/src/code.google.com/p/go-uuid/uuid (from $GOROOT)
	/Users/markturansky/Projects/src/code.google.com/p/go-uuid/uuid (from $GOPATH)
pkg/util/diff.go:26:2: cannot find package "github.com/davecgh/go-spew/spew" in any of:
	/Users/markturansky/Applications/go1.4.2/src/github.com/davecgh/go-spew/spew (from $GOROOT)
	/Users/markturansky/Projects/src/github.com/davecgh/go-spew/spew (from $GOPATH)
pkg/util/yaml/decoder.go:26:2: cannot find package "github.com/ghodss/yaml" in any of:
	/Users/markturansky/Applications/go1.4.2/src/github.com/ghodss/yaml (from $GOROOT)
	/Users/markturansky/Projects/src/github.com/ghodss/yaml (from $GOPATH)
pkg/util/yaml/decoder.go:27:2: cannot find package "github.com/golang/glog" in any of:
	/Users/markturansky/Applications/go1.4.2/src/github.com/golang/glog (from $GOROOT)
	/Users/markturansky/Projects/src/github.com/golang/glog (from $GOPATH)
pkg/util/time.go:23:2: cannot find package "github.com/google/gofuzz" in any of:
	/Users/markturansky/Applications/go1.4.2/src/github.com/google/gofuzz (from $GOROOT)
	/Users/markturansky/Projects/src/github.com/google/gofuzz (from $GOPATH)
pkg/api/resource/quantity.go:26:2: cannot find package "github.com/spf13/pflag" in any of:
	/Users/markturansky/Applications/go1.4.2/src/github.com/spf13/pflag (from $GOROOT)
	/Users/markturansky/Projects/src/github.com/spf13/pflag (from $GOPATH)
pkg/api/context.go:23:2: cannot find package "golang.org/x/net/context" in any of:
	/Users/markturansky/Applications/go1.4.2/src/golang.org/x/net/context (from $GOROOT)
	/Users/markturansky/Projects/src/golang.org/x/net/context (from $GOPATH)
pkg/api/resource/quantity.go:27:2: cannot find package "speter.net/go/exp/math/dec/inf" in any of:
	/Users/markturansky/Applications/go1.4.2/src/speter.net/go/exp/math/dec/inf (from $GOROOT)
	/Users/markturansky/Projects/src/speter.net/go/exp/math/dec/inf (from $GOPATH)

$ hack/update-generated-conversions.sh
Generating for version v1beta3
Generating for version v1

See #8443
@wojtek-t

LGTM, pending unfreeze #8534


Script the creation of our nginx containers

What is this PR trying to achieve?
Adds a script for creating our nginx images and pushing them to ECR.
Who is this change for?
Me, because I am literally too lazy to do anything that involves running more than one command, and I was looking at writing a new variant for the IIIF images.

Nice. Step on the way to automating builds too.


Syncing contract transaction results into grpc stream error.

If there is syncing of smart contract transaction after state sync (i.e. node restarted) there is rpc stream error which is never recovered.

There are two problems here:

Actual rpc error is because provider of syncing transactions assumes that requester got all of the transactions and returns nil response, so next header send has no receiver and results into EOF error. Logging message was incorrect due to copy paste error.
But this issue occurs in the first place because contract transaction is considered invalid and just skipped so it cannot be synced at all. And there was no logging message to that because only signature validation error was logged for some reason. And contract transaction was considered invalid because validation for contracts check whether such contract exists in the memory and since we sync state before transaction its getting download and thus far exists.

Resolution is to skip this particular error, since this transaction needs to be added to buffer anyway. Now there will be another error - application error, since this contract was already applied, but thats fine for now, since this issue will be resolved in corresponding PR about double spending.

@ryanswart @iwasaki-kenta fyi

Awesome work, merged in the PR - thanks :smile:.


Sample projects: remove trailing whitespace on non-blank lines, fix arrow

remove trailing whitespace on non-blank lines
fix an arrow: < to >
remove the blank line just before </p>

See #10920, comments 2–3

The HTML spec says > "SHOULD" be escaped as >, but since it also says the motivation for that is buggy older browsers, I think we can ignore that advice -- that change here is ok.


Import statements not generated when using struct-like enums

Import statements are working for most of my components, but some reason not for this one:

use serde::Serialize;
use ts_rs::TS;

/// A single attribute belonging to a particular component.
#[derive(Serialize, TS)]
#[ts(export)]
pub struct Attribute {
    /// The attribute name, e.g. 'position' or 'mass'.
    name: String,
    /// The width in number of f32 values.
    width: usize,
}

/// The descriptor of a game component's memory information.
#[derive(Serialize, TS)]
#[ts(export)]
#[ts(rename_all="lowercase")]
#[serde(tag="type")]
pub enum Component {
    Point {
        attributes: Vec<Attribute>
    },
    Source {
        attributes: Vec<Attribute>
    },
}

// bindings/Attribute.ts
export interface Attribute {
  name: string;
  width: number;
}

// bindings/Component.ts
export type Component = { type: "point"; attributes: Array<Attribute> } | {
  type: "source";
  attributes: Array<Attribute>;
};

Attempts at fixing
Module splitting
Splitting them into separate modules so that they are run as separate tests does not make a difference:
test memory::comps::attr::export_bindings_attribute ... ok
test memory::comps::comp::export_bindings_component ... ok

Adding bare variant
Adding a non-struct-type enum variant does do the trick:
/// The descriptor of a game component's memory information.
#[derive(Serialize, TS)]
#[ts(export)]
#[ts(rename_all="lowercase")]
#[serde(tag="type")]
pub enum Component {
    Foo(Vec<Attribute>),
    Point {
        attributes: Vec<Attribute>
    },
    Source {
        attributes: Vec<Attribute>
    },
}

import type { Attribute } from "./Attribute";

export type Component = { type: "foo" } & Array<Attribute> | {
  type: "point";
  attributes: Array<Attribute>;
} | { type: "source"; attributes: Array<Attribute> };

Skipping bare variant
Skipping this variant does not work:
// ...
    #[ts(skip)]
    Foo(Vec<Attribute>),

export type Component = { type: "point"; attributes: Array<Attribute> } | {
  type: "source";
  attributes: Array<Attribute>;
};

Removing other modifiers
Removing #[ts(rename_all="lowercase")] and #[serde(tag="type")] also makes no difference.
Adding non-vec field
Adding a non-vecetor field (i.e foo: Attribute) does not work.
New-type + inline
Creating a newtype and then inlining that does not do the trick:
#[derive(Serialize, TS)]
pub struct Attributes(Vec<Attributes>);

// ...
        #[ts(inline)]
        attributes: Attributes,

Separate struct + inline
Creating a separate struct with the named field does work:
#[derive(Serialize, TS)]
#[ts(export)]
pub struct Attributes {
    attributes: Vec<Attribute>,
}

/// The descriptor of a game component's memory information.
#[derive(Serialize, TS)]
#[ts(export)]
#[ts(rename_all="lowercase")]
#[serde(tag="type")]
pub enum Component {
    #[ts(inline)]
    Point(Attributes),
    Source(Attributes),
}

// bindings/Component.ts
import type { Attributes } from "./Attributes";

export type Component =
  | { type: "point" } & Attributes
  | { type: "source" } & Attributes;

//bindings/Attributes.ts
import type { Attribute } from "./Attribute";

export interface Attributes {
  attributes: Array<Attribute>;
}

And it technically works because the type is equivalent… but it's ugly.

Thanks for the report! I will look into this.

This should be fixed in the latest release. If not, feel free to reopen this.


LLM - Use naas completion api route

@Dr0p42, as we discussed in Slack, we need to get long lived token from jupyter token

I analyzed the credit consumption and here are the averages per person on a sample of 200:

AI Model Completion: 0.40 credit (1005 tokens)
- Seniority prompt: 208 tokens
- Department prompt: 720 tokens
- Company prompt: 87 tokens
Execution time: 0.32 credit (20 seconds)

This corresponds to a consumption of 0.72 credit per person.


Documentation links depending on the spec version

We currently have a link for aggregation docs pointing to 6.4, see #63.
When we'll add datasets with different Elasticsearch versions (for example GtR is ES7) we could think of a slightly more complex UI that would:

show the version we point to ([icon] 6.4, or [icon] 7.6, etc)
point to:

the latest doc when no dataset is selected
a specific doc version when we select a dataset

See #75

ES7 seems to be retro-compatible with ES6 and we will probably ugrade all datasets to ES7 anyway, marking as triagne: on hold and closing


VsTest task fails fairly frequently with System.NullReferenceException during PublishTestResultPhase

Last couple of days we seem to have to re-run our build pipelines quite often due to the VsTest task failing during publish test results step.
Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?  Bug
Enter Task Name: VsTest
Environment

Azure Pipelines

alsdevelopmentna.visualstudio.com/AngleNextGen Core Product Pipeline

Build 20200416.1

Agent - Hosted

Pool: Azure Pipelines
Image: windows-2019
Agent: Hosted Agent

Issue Description
Below is error that we've had +3 times this week - have to re-run the pipeline to resolve
Occurs after tests pass and during MS.VS.TestService.VstestConsoleAdapter.PublishTestResultPhase step with  System.NullReferenceException
Task logs
vsTestFail.txt
Error logs
##[debug]Current Phase: MS.VS.TestService.VstestConsoleAdapter.PublishTestResultPhase Phase Result: MS.VS.TestService.VstestConsoleAdapter.PublishTestResultPhaseResults
2020-04-16T03:32:57.0902652Z ##[error]Error occurred while publishing test results : System.AggregateException: One or more errors occurred. ---> System.NullReferenceException: Object reference not set to an instance of an object.
2020-04-16T03:32:57.0905340Z ##[debug]Processed: ##vso[task.logissue type=error;]Error occurred while publishing test results : System.AggregateException: One or more errors occurred. ---> System.NullReferenceException: Object reference not set to an instance of an object.

We've fixed this and the fix should be available in task version 2.168.0 or higher, the deployment should reach all accounts in a few working days.

Thanks - haven't noticed this error anymore.
You can probably close this issue - although bit disappointed as, since yesterday, getting new error popping up (#12808)


Create a Model For People to Select Editor Code Styles

can u please elaborate on what you want in this task? what does the modal do after choose an editor code style?

Ya! @sleman-safiah please share abit more on this.

sorry guys , it was rough week for me being sick , so i am gonna back soon
about this task from my opinion is about having a model for the Editor , that means color scheme for example , font , font size , maybe in some cases we can change the icon for the race car or any other vehicle @vignesh-gupta @Abizrh
check this website to get more info about customization https://monkeytype.com/

so from what I understood from the reference website is - we should be able to select the size of snippet or type?
Is that what you are trying to convey?

Yeah this is one thing of the whole customization stuff

maybe let's wait on doing this until the app is actually functional


Add complex portal

...as a choice in the database selection drop down menu for complex annotations in PathVisio.
https://www.ebi.ac.uk/complexportal/home

This should be integrated, when the new BridgeDb libraries are included (given that the complex portal database has been added to datasources.txt ;) ). @mkutmon @egonw : any updates on including latest bridgedb libraries in PV?

See https://github.com/PathVisio/pathvisio/pulls

yes, I need to test the new libraries - there were some issues with merging


python312Packages.aiovodafone: 0.5.4 -> 0.6.0

Diff: https://github.com/chemelli74/aiovodafone/compare/refs/tags/v0.5.4...v0.6.0
Changelog: https://github.com/chemelli74/aiovodafone/blob/v0.6.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 307422 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.vodafone_station
python311Packages.aiovodafone
python311Packages.aiovodafone.dist
python312Packages.aiovodafone
python312Packages.aiovodafone.dist


Add configuration to allow --quiet-deps to be passed to Dart Sass

🚀 Feature request
Dart Sass is throwing lots of deprecation warnings for 3rd party packages. The Dart Scss team has added a flag to silence them.
https://github.com/sass/dart-sass/issues/672
Is it possible to have a configuration flag in the ng cli to pass through flags to Dart Sass?
Command (mark with an x)

[ ] new
[x] build
[x] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Description
(see above)
Describe the solution you'd like
(see above)
Describe alternatives you've considered
Not sure of any other options.

This feature is not available in the Node API. See https://github.com/sass/dart-sass/issues/672#issuecomment-846311746. That said, there is a similar feature which in the Node API https://github.com/sass/sass/issues/3065.
It very unlikely that we want to increase the API and provide this feature to turn on/off this behaviour.
Possibly we can turn on quietDeps, although I feel like this would cause other issues down the line, since warnings will not be displayed, consumers of the libraries will be unable to report these warnings to the library author. Eventually these warnings will turn to fatal errors and there would be no way to suppress them.
Will bring up this issue during our next team meeting and see what the other team members think.

@alan-agius4 Perhaps instead of setting this particular option only, might you consider a mechanism where the consuming project could supply the core of a Sass rendering options object that could enhanced by the builder for use when invoking Sass?  That would help with temporary suppression of the deprecation warnings that are the immediate problem in this issue, as well as providing potential future extensibility that might be difficult to predict today.

Following a discussion during today team meeting we decided that we should move forward and turn on quietDeps.

@alan-agius4 can you please share the rationale of this decision? Personally, I'd rather see warnings and be aware of them (so I can take action) rather than have them muted and later discover deprecations when upgrading.
I mean, if these are muted, then at least allow overriding that setting, so people can opt in to see them.

@elektronik2k5,
The main reasons why we decided to go with this approach is

Such warnings are not directory actionable by the consumer of the library.
It should be the responsibility of the library to have integration tests to validate that their Sass is not producing warnings/errors.
These warnings can be pretty noisy when having a lot of components which can result in missing actionable deprecations which are caused by your code.
I can see that we can allow these to be unmuted, via the --verbose flag.

Thank you for the fast turnaround. I'm looking forward to seeing the issues in my code again instead of them being hidden amongst others that I can't control.


AdaptiveImageServlet uses web rendition in case of a fileReference - it should (at least in some cases) use the original

https://github.com/Adobe-Marketing-Cloud/aem-core-wcm-components/blob/da012e690e33d33051df268233eb92f5d0e11423/bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/servlets/AdaptiveImageServlet.java
This servlet uses the web rendition (usually 1280x1280) as the source for the resized image.
This is not correct, as it can happen that we need an image wider than 1280px.
This was also a very annoying problem with the ootb adaptive image component in foundation.
Solution:
Use the original image
The original image can be very large in size though.
A consideration could be to use the original only if an image with a width larger than 1280 is requested. However, you will notice the quality of the 1280 image requested through this servlet is a lot worse than the 1281 image.

A web rendition is only used to determine the crop rectangle, if one was defined, or if the requested width corresponds to an already DAM-processed web rendition. Otherwise we always use the original asset to process the image.
The DAM workflow that provides web renditions is configurable, so that a user can provide whatever width they require. I really don't see a need here to always process the original assert, since sometimes this can be a very CPU-intensive process.

@raducotescu, that means cropping of images wider 1280px (web rendition) is broken when default workflows are active, right? That is at least what I've seen so far.

Why would the cropping be broken?

The values (coordinates, width and height) for cropping are calculated based on web rendition and written to imageCrop. When original rendition is used in publish (and it's wider than 1280px) these values are not functional of course. A (much) smaller area of the image is rendered. Or is there any setting I'm missing? Can you try with a large image (e.g. QFHD 3840x2160) yourself?


callback parameter is missing from 'write' and 'end' methods

The methods 'write' and 'end' don't accept a 'callback' parameter - the underlaying http response stream does. Therefore there is a different runtime behaviour when sending off the data in chunks (waiting for the response to be written) when using compression (callback will not be called and the program hangs)

Hi! What version of Node.js are you using? It doesn't seem to exist in 0.10, at least.

Hi!
I'm using 0.12 (https://nodejs.org/api/stream.html#stream_writable_write_chunk_encoding_callback)
But I guess this parameter was there all along. That's the node way :-)  (https://nodejs.org/docs/v0.10.0/api/stream.html#stream_writable_write_chunk_encoding_callback_1)

This module is only for HTTP streams, which in Node.js are not actually the normal streams at all. For example, this is the actual source for the write method we are overwriting in 0.10: https://github.com/joyent/node/blob/v0.10.24/lib/http.js#L841 and as you can see, it takes no callback argument.

It looks like the callback argument was added in Node.js 0.12 sometime: https://github.com/joyent/node/blob/v0.12.0/lib/_http_outgoing.js#L409

Looks like the callback argument to .write was added in Node.js 0.11.6: https://github.com/joyent/node/commit/da93d6adfb0abfcaac26e1509748edca0db8c003

{noob} Can this module be used for compression of files?

I'm using Node 0.10.40. I supply the callback on second argument in res.write() and It's work but when compression middleware it throws an error:
TypeError: Unknown encoding: function (err){
            if(err){
            return console.log(err);
            }
            res.flush();
            stream.resume();
        }

which is my callback function. I try to fix it by change second arguments to "utf-8" and move callback to third argument. The error was gone but callback never get call.

I just ran into this problem as well and it took me a long time to figure out what was going on as it unexpectedly breaks res.write in all middleware after this middleware is loaded. This bug prevents this middleware from being node 11+ compliant. If you ever add the compression middleware, all future calls to res.write no longer call the callback.
var express = require('express');
var compression = require('compression')
var app = express();

app.use(compression())

app.get('/', function (req, res) {
  res.write('Hello World!', 'utf-8', function() {
    console.log('will never be called since compression overrode res.write without the callback parameter');
  });
  res.end();
});

app.listen(3000);

This is worse if you put the res.end inside of the res.write callback as your server will hang indefinitely.
Is there any update as to when this will be fixed? It seems simple enough of a fix if you just used _write.apply(res, arguments) in your res.write override so that all arguments will be preserved to the previous write function.

There is the PR #80 that is actively being worked on that would resolve this.

There seems to be a lot going on in that PR discussion wise. From what I can gather you seem to want two different PRs made: one that fixes this bug specifically and the other that fixes the flush() bug. If I create a PR to fix this bug, do you see any problem with changing the res.write and res.end calls to use apply to pass through the arguments properly?

Hi @straker, yes there is a lot of discussion. The reference PR is specific to add the callbacks; the second PR to fix the flush bug was never made.

If I create a PR to fix this bug, do you see any problem with changing the  res.write  and  res.end  calls to use  apply  to pass through the arguments properly?

So there is more to fixing it than that, and there has been a lot of discussion around that very point in the PR :) The main point is that you cannot just pass the callbacks through, because otherwise, it will make the callbacks even more unpredictable on Node.js 0.8 and 0.10, which changes this module from "if you use this, you cannot use callbacks" to "if you use this, you can use callbacks, except on Node.js 0.8 and 0.10, where normally you cannot use callbacks, but now you can, but not if the client sends headers to not compress the output".

Ah, I thought that PR was to fix the flush bug.
I'm not sure if I understand what you mean. How does passing through the arguments from compressions res.write to nodes res.write now allow callbacks in Node 0.8 and 0.10 if the res.write node function doesn't accept a 3rd parameter in those version? All that would mean is that it receives an additional parameter that it ignores.
I thought that's what the two different PRs were suppose to separate because the PR you referenced looks(ed) at the argument list to compression's res.write and then manually calls the callback if it exists. Changing compressions override of res.write to call _write.apply(res, arguments) instead of _write.call(this, chunk, encoding) at the end still does not allow Node 0.8 and 0.10 to use callbacks (since the _write does not accept them), but does allow Node 0.11+ to use them as per the spec. No functionality would be changed in those 2 versions of Node.

How does passing through the arguments from compressions  res.write  to nodes  res.write  now allow callbacks in Node 0.8 and 0.10 if the  res.write  node function doesn't accept a 3rd parameter in those version?

Because the zlib stream in 0.8 and 0.10 does support the callbacks. You're welcome to also make a pull request if you have a different approach, but every time you keep talking about calling _write, that would only apply to non-compressed responses, as compressed responses write to the zlib stream.

I see, I misunderstood how that all worked together. I can see how that complicates maters significantly. I'll investigate further to see if I can come up with something else that will work taking into account zlib. Thanks for the responses.

No problem, @straker! I would love to get this fixed, where it doesn't introduce even more head-aches for debugging :S I just have had so many more higher-priority issues to work around, and besides from this initial issue, I never even heard from anyone besides two just suddenly that it was even a big issue (probably because, when surveying npm yesterday, almost every single module that overwrites res.write/res.end does not even pass through the callbacks, either, so it seems to be a fairly low-used API (at least among the users of those modules).
The Express.js TC has spoken about Node.js support recently, and we are wiling to start bumping majors to drop Node.js 0.8 support, but with Node.js 0.10 still supported by the Node.js foundation (which we are a part of) and still demand for Node.js 0.10 support among corporate, dropping 0.10 is still a bit iffy. I bring that up because dropping those versions would make this a non-issue...


upload versioned distributions to s3

Versioning the compiled binaries makes it a lot faster to deploy, as the call to S3 is only necessary when the requested version is not installed.
I'll hold off on this until I see how this fits in with the new makefiles.

No longer relevant.


Precompiled binaries and packages should be signed as part of release

In order for users to have a valid chain of trust all the way to the pre-compiled packages/binaries, the build scripts should sign all build artifacts which are normally consumed by the public.
Ideally, these artifacts may be independently verified with gpg  --verify (or similar).
As of 2.3.1, the RELEASES file seems to contain a checksum of the nupkg artifact but nothing further. It is noted that the release tag itself is signed via git, but unless someone builds the package themselves, there is no signature or proof that the produced artifacts for that release have not been tampered with.

I think this is a related issue https://github.com/OpenBazaar/openbazaar-desktop/issues/1789


Video restarts when calling seek(0) in onEnd callback

Hi,
I'm playing a video in my app and I'm using the onEnd callback with the following code:
this.setState({playing: false, currentTime: 0, percent: 0});  this.player.seek(0);.
The seeker and the controls reset to the initial state, but the video starts playing event if the repeat option is set to false.
Can anyone help me?

Repeat will automatically seek to the beginning when the video ends. However, since you are manually seeking, you're overriding the repeat behavior. You will need to change your logic in onEnd to not seek to the beginning.

I am being bit by this as well.
repeat={false}
paused={this.state.paused}

When video stops playing I want to be able to click on play button and for it to start playing again from the beginning. So, standard behavior.
This onEnd function:
onEnd = () => {
        this.video.seek(0);
        this.setState({paused: true});
    };

Will have the effect of the video repeating itself from the beginning again.
If I don't include this.video.seek(0); then video will not play again when pressing play button as it's at the end of the video.
So how to achieve proper behavior? Thanks in advance for your help.

This solved it:
onEnd = () =>  this.setState({ paused: true }, () => this.video.seek(0))

Same here with the possibility of replay once video finished.

If I don't include this.video.seek(0); then video will not play again when pressing play button as it's at the end of the video.

It would be great have a "this.video.stop()" to player reset and allow us play video again.
I solved it with setTimeout but seem it a botched job

Hope this solution helps
function onEnd(e) {
       console.log('Audio ended', e);
       setAudioState({ ...audioState, play: false, currentTime: 0 });
       setTimeout(() => {
         audioRef.current.seek(0);
       }, 500);
  }


Pulumi redeploys all cluster resources if not touched for a while

Have seen this happen more than once. After not having updated the cluster for a few weeks I go to run pulumi up and the nodes are redeployed and all deployments on them are also redeployed.
If I re-run on the same day it doesn't repeat.
The only thing I can see here is that the last-applied-configuration appears to be timestamped and that is applied as an annotation to the namespace, which could trigger all resources in the namespace to be redeployed if it is older than some period. The kafka change appears to do nothing but always shows as needing to be deployed.
This is what is being updated:
aws:cloudformation:Stack     folio-node-group-nodes                    updated      [diff: ~templateBody]

This is the update:
    folioDbHost         : "[secret]-<snip>"
    folioDbPort         : 5432
    folioNamespace      : {
        apiVersion: "v1"
        id        : "[secret]-8rvomw1v"
        kind      : "Namespace"
        metadata  : {
            annotations      : {
                kubectl.kubernetes.io/last-applied-configuration: "{\"apiVersion\":\"v1\",\"kind\":\"Namespace\",\"metadata\":{\"annotations\":{\"pulumi.com/autonamed\":\"true\"},\"labels\":{\"app.kubernetes.io/managed-by\":\"pulumi\"},\"name\":\"[secret]-8rvomw1v\"}}\n"
                pulumi.com/autonamed                            : "true"
            }
            creationTimestamp: "2022-01-27T16:06:21Z"
            labels           : {
                app.kubernetes.io/managed-by: "pulumi"
                kubernetes.io/metadata.name : "[secret]-8rvomw1v"
            }
            managedFields    : [
                [0]: {
                    apiVersion: "v1"
                    fieldsType: "FieldsV1"
                    fieldsV1  : {
                        f:metadata: {
                            f:annotations: {
                            }
                            f:labels     : {
                            }
                        }
                    }
                    manager   : "pulumi-resource-kubernetes"
                    operation : "Update"
                    time      : "2022-01-27T16:06:21Z"
                }
            ]
            name             : "[secret]-8rvomw1v"
            resourceVersion  : "919"
            uid              : "c7e42910-2f32-4c6a-9cac-84fb22a17d0d"
        }
        spec      : {
            finalizers: [
                [0]: "kubernetes"
            ]
        }
        status    : {
            phase: "Active"
        }
        urn       : "urn:pulumi:dev::[secret]::kubernetes:core/v1:Namespace::[secret]"
    }
    folioNamespaceName  : "[secret]-8rvomw1v"
    folioSecurityGroupId: "sg-0f2b06a484cf80842"
    folioVpcId          : "vpc-0adcd2575de466866"
    kafkaInstance       : {
        atomic                  : false
        chart                   : "kafka"
        cleanupOnFail           : false
        compat                  : "true"
        createNamespace         : false
        dependencyUpdate        : false
        description             : "Install complete"
        devel                   : false
        disableCRDHooks         : false
        disableOpenapiValidation: false
        disableWebhooks         : false
        forceUpdate             : false
        id                      : "[secret]-8rvomw1v/kafka"
        keyring                 : "/Users/Steve/.gnupg/pubring.gpg"
        lint                    : false
        name                    : "kafka"
        namespace               : "[secret]-8rvomw1v"
        recreatePods            : false
        renderSubchartNotes     : false
        replace                 : false
        repositoryOpts          : {
            repo    : "https://charts.bitnami.com/bitnami"
        }
        resetValues             : false
        resourceNames           : {
            ConfigMap/v1            : [
                [0]: "kafka-scripts"
            ]
            Service/v1              : [
                [0]: "[secret]-8rvomw1v/kafka-zookeeper"
                [1]: "[secret]-8rvomw1v/kafka-zookeeper-headless"
                [2]: "kafka"
                [3]: "kafka-headless"
            ]
            ServiceAccount/v1       : [
                [0]: "kafka"
            ]
            StatefulSet.apps/apps/v1: [
                [0]: "[secret]-8rvomw1v/kafka-zookeeper"
                [1]: "kafka"
            ]
        }
        reuseValues             : false
        skipAwait               : false
        skipCrds                : false
        status                  : {
            appVersion: "2.8.1"
            chart     : "kafka"
            name      : "kafka"
            namespace : "[secret]-8rvomw1v"
            revision  : 1
            status    : "deployed"
            version   : "14.4.3"
        }
        timeout                 : 300
        urn                     : "urn:pulumi:dev::[secret]::kubernetes:helm.sh/v3:Release::kafka"
        values                  : {
            replicaCount: 3
        }
        verify                  : false
        version                 : "14.4.3"
        waitForJobs             : false
    }
    kubeconfig          : {
        apiVersion     : "v1"
        clusters       : [
            [0]: {
                cluster: {
                    certificate-authority-data: <snip>
                    server                    : <snip>
                }
                name   : "kubernetes"
            }
        ]
        contexts       : [
            [0]: {
                context: {
                    cluster: "kubernetes"
                    user   : "aws"
                }
                name   : "aws"
            }
        ]
        current-context: "aws"
        kind           : "Config"
        users          : [
            [0]: {
                name: "aws"
                user: {
                    exec: {
                        apiVersion: "client.authentication.k8s.io/v1alpha1"
                        args      : [
                            [0]: "eks"
                            [1]: "get-token"
                            [2]: "--cluster-name"
                            [3]: "[secret]-cluster-eksCluster-e0f936f"
                        ]
                        command   : "aws"
                    }
                }
            }
        ]
    }
    pgClusterId         : "[secret]-pg-cluster"
    pgFinalSnapshotId   : "[secret]-pg-cluster-final-snapshot-0"
    vpcId               : "vpc-0adcd2575de466866"
    vpcPrivateSubnetIds : [
        [0]: "subnet-09027a61bf5a3dd7c"
        [1]: "subnet-096bb5cac0327c041"
        [2]: "subnet-0fb8b174ba73e79cb"
    ]
    vpcPublicSubnetIds  : [
        [0]: "subnet-030b995748c447ede"
        [1]: "subnet-0748e39600ff64253"
        [2]: "subnet-0b8be2b61056324eb"
    ]

Resources:
    ~ 1 updated
    +-1 replaced
    2 changes. 139 unchanged

I would be interested in seeing the entire output in a single block from pulumi up to the end.
I also saw that the chart version is pinned, (which I think is a good idea) so that also makes it unlikely that it is the intended replacement

I feel like the Kafka update might be noise. The resource being updated is named folio-node-group-nodes. That name is being generated somewhere and is in scope for all the resources. A WAG: a property somewhere which says "update this namespace annotation with date updated if last update time > n". Bc it only seems to come up if not updated for a while.

To get better information about updates it is possible to use --diff when running pulumi up however this hasn't yet made it clear what is behind this mysterious behavior.


etcdserver: align 64-bit atomics on 8-byte boundary

I read through the whole source code today, and came across this and #4733 that didn't obey the rules.
@xiang90 @heyitsanthony

Code in Godeps that uses atomic:

Godeps/_workspace/src/github.com/cheggaaa/pb/pb.go

has aligned the int64 field and commented why

Godeps/_workspace/src/github.com/golang/glog/glog.go

has aligned the fields. common package

Godeps/_workspace/src/github.com/prometheus/client_golang/prometheus/histogram.go

has aligned the fields and commented why

Godeps/_workspace/src/github.com/prometheus/client_golang/prometheus/value.go

has aligned the fields and commented why

Godeps/_workspace/src/github.com/spacejam/loghisto/metrics.go

has only maps with int64, haven't tested if they need to be aligned as well

Godeps/_workspace/src/golang.org/x/net/trace/events.go, Godeps/_workspace/src/golang.org/x/net/trace/trace.go

hasn't aligned eventLog.refs int32 and trace.refs int32 but I don't know if it's necessary. The net package should be stable as well, so it shouldn't be a problem.

Godeps/_workspace/src/google.golang.org/grpc/transport/http_util.go

aligned int32 but no comment.

That was all usage of atomic in Godeps. With this PR and #4733 all etcd code is aligned too, and #4715 fixes compilation of 32-bit

gofmt, change commit title to etcdserver: align 64-bit atomics on 8-byte boundary, and it's lgtm. Thanks!

Yep, saw that

commit message still looks off-- git commit --amend...? Thanks!

lgtm

Ah, you meant commit message too. Fixed

@xiang90 This has been lgtm'd, so maybe you could merge?

@luxas @heyitsanthony Is there any tool we can run to test for this? It is super annoying that we have no way to detect a regression here.

@philips unaware of any tool to check this. A test case using unsafe.Offsetof on EtcdServer would be feasible but incomplete; it won't catch misuse like type s struct { x int32; s EtcdServer }...

Sorry, but I do not understand why this hasn't been merged yet.
@xiang90 @hongchaodeng @heyitsanthony

@luxas It is just really annoying for us to merge this and then have no way of knowing if we break it again. I am going to email go-nuts for help.

Posted: https://groups.google.com/forum/#!topic/golang-nuts/l5mzkGVmNp0

@philips OK, but this fixes the atomic alignment, not breaking it.
#4733 and this one was uploaded less than an hour after each other and this PR initially had the changes that #4733 have.
What's left is what #4733 didn't catch. The thing is, #4733 was merged less than twenty minutes after upload and this PR has been pending a month now. I just don't understand why, given it has been lgtm'd already
Do not get me wrong, I want to contribute to multiarch etcd, but with this treatment I'm not sure what you want.
Of course, +1 for a integration test that checks all structs for this, if we get one from the thread.

@heyitsanthony see here too. This has lgtm but isn't merged.

@luxas OK, I will let @heyitsanthony make the merge but I filed a bug here to remind us to find a static analysis tool: https://github.com/coreos/etcd/issues/5027
LGTM


Update docker file/image

It needs to integrate Java so that the GFS plugin can work out-of-the-box.

Docker image v0.3 pushed


community discussion

Community is a hot topic in the past few years,  each open source project  has their own community, but it is a challenge that how to make the community grow well and how to avoid some stupid action during the community activity. lfapac  evangelist team will has a discussion about community, the key words will be

how to name community in China
how to operate a community
some stupid action for community operation

Any input idea will be welcomed.

Benoît Demil & Xavier Lecocq，"Neither Market nor Hierarchy nor Network: The Emergence of Bazaar Governance.Organization Studies (01708406); 2006, Vol. 27 Issue 10, p1447-1466, 20p
recommend this paper～


Build failure: python311Packages.claripy

Steps To Reproduce
Steps to reproduce the behavior:
nix build nixpkgs#python311Packages.claripy
Build log
The relevant portion seems to be:
Successfully built claripy-9.2.84-py3-none-any.whl
Finished creating a wheel...
Finished executing pypaBuildPhase
@nix { "action": "setPhase", "phase": "pythonRuntimeDepsCheckHook" }
Running phase: pythonRuntimeDepsCheckHook
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for claripy-9.2.84-py3-none-any.whl
  - z3-solver not installed

Additional context
There seems to have been some change to nixpkgs that adds more runtime dependency checks to python packages - some other projects I've been building required changes too.
Notify maintainers
@fabaff
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 6.5.0-14-generic, Ubuntu, 22.04.3 LTS (Jammy Jellyfish), nobuild`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.0`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

Add a :+1: reaction to issues you find important.

Will be fixed with https://github.com/NixOS/nixpkgs/pull/281429


refactor(code): Codename: Happy Linter

I removed some whitespaces and refactored the code.
I didn't change any line of code

@danielsogl What linter/style guide are you using?

You find it here: https://github.com/vvakame/typescript-formatter/blob/master/tsconfig.json
And actually I also use atom-beautify. The plugin also uses this tsconfig file

Looks like the linter fails this time lol

You linked me to a tsconfig file--what does it have to do with linting?
Whatever formatter you used kinda had disastrous changes. Did you look at the code output? I looked through just a couple files and found so many things wrong.
We're using tslint at the moment with minimal options (npm run lint). I would prefer to expand upon the tooling we already have than use a formatter in a text editor (I don't use atom)


⚠ Bofrost.es has degraded performance

In 8ec8990, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1478 ms

Resolved: Bofrost.es performance has improved in d2e703e after 39 minutes.


[vx.dev] implements #49

[vx.dev] This PR implements #49, created by vx.dev.

[vx.dev]: Based on the wireframe provided, here's a JSX code for a mobile chat application prototype using React and Tailwind CSS. This code includes a static chat interface with a header, message bubbles, an input area, and a send button.
This code snippet creates a chat application layout with a header that includes an avatar and user information, a main content area with a series of message bubbles, and a footer with an input field and a send button. The avatar uses a fallback image in case the main image doesn't load. The message bubbles are styled to differentiate between incoming and outgoing messages. The input field and send button are placed at the bottom for the user to type and send new messages.

容器最大宽度不超过 600px

[vx.dev]: Based on the provided code and the image, I will enhance the chat application to meet the new requirements. The enhancements will include a more interactive and responsive design, with a maximum container width of 600px for mobile devices.
This updated code includes additional buttons for attachments and emojis, and ensures that the chat application container does not exceed 600px in width, making it suitable for mobile devices. The layout and functionality are designed to provide a user-friendly mobile chat experience.


vkquake 1.20.3  -> 1.30.1

Description of changes

https://github.com/Novum/vkQuake/releases/tag/1.30.1
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@daemonspudguy Did you intend to leave this marked as a draft? Are you still interested in seeing it merged?
If so, the package has been updated in the meantime, most recently in #206176. You'll either need to rebase and fix the conflict, or just sync with master and re-make the change.

I totally forgot about this. I have long since switched to MX Linux.


Karpenter does not delete nodes when the cluster is deleted

We've been experimenting with karpenter, which has involved putting up and removing clusters, which we do with terraform. We noticed that we have a bunch of 'orphaned' nodes we've been paying for after the clusters have been removed. With the cluster-autoscaler, when we delete the cluster the ASGs and the nodes are all removed, so it was an unwelcome monetary surprise to find we had nodes created by karpenter and tagged for deleted clusters still operating. I understand that removing karpenter should not delete the nodes it was controlling, but it seems like deleting the EKS cluster definitely should.

We just made a change where deleting a provisioner will clean up nodes to catch this exact use case. This catches many cases, but if you just delete the cluster, it's possible that karpenter will be uninstalled and won't be able to execute the cleanup. In that case, you could include a cleanup script in your cluster deletion logic to delete instances tagged by karpenter.

Thank you. Does that change, 'just made' have an associated version number?

Hey @zenbones .  Try out v0.12.1 to test the change: https://github.com/aws/karpenter/releases/tag/v0.12.0

Thank you! I'll add that as Karpenter is an AWS product, and the nodes are tagged, that deleting those nodes when the cluster is deleted seems like something AWS could do. That said, we install with terraform via helm, and therefore uninstall with terraform and helm as well, so Karpenter should get a chance to properly clean up.


Wave Generation APIs

This PR adds the following on Windows and Linux:
Wave Types
0 = sine
1 = square
2 = triangle
3 = sawtooth
loadWave(amplitude, frequency, waveType)
setWaveAmplitude(amplitude)
setWaveFrequency(frequency)
setWaveSampleRate(sampleRate)
I edited the example to allow loading of a wave and a few controls. Happy to rework if you see something that could be improved with this implementation. I'll likely add the buffer API at some point as well.

Seems nice.
I just have a request can we stop making "code style" related changes like placement of body brackets etc.
Thankyou.

Ah, the style changes would be from the auto formatter. I can try to revert, but it seems more like conventional C++ now versus dart style on C++ code.

@alexmercerind can you go ahead and merge this or would you like me to restore the original formatting first? Have other improvements I want to land, but cannot until this is merged due to branching issues.


New Blogpost on the Project for Measuring and Visualizing Soil Moisture in the Teutoburg Forest/Bielefeld

@okfde/codeforde-devs Ready for review and publishing. Thanks :-)

Shrinked the images with https://squoosh.app using MozJPEG at 75% quality to save some bandwidth, fixed the file extension and changed some markdown syntax :)

Thank you @ubergesundheit for taking care of my blog post. I really appreciate it.


Detect dependency cycles in package dependencies and modules within a package

Description:
$subject.

At the moment having cycles between two modules produces incorrect diagnostic cannot resolve module for one of the
modules.
Actual Output
Compiling source
	asmaj/proj1:0.1.0
ERROR [main.bal:(2:1,2:30)] cannot resolve module 'asmaj/proj1.mod1 as _'
error: compilation contains errors

Expected Output
Compiling source
	asmaj/proj1:0.1.0
ERROR [main.bal:(1:1,1:25)] cyclic module imports detected 'asmaj/proj1 -> asmaj/proj1.mod1'
error: compilation contains errors

The above output can be produced by making a module import its own self. A similar diagnostic should be reported for cycles between different modules as well.
Steps to reproduce:

Create a new ballerina package and add another module using bal new and bal add:

proj1
├── Ballerina.toml
├── main.bal
└── modules
    └── mod1
        └── mod1.bal

Update main.bal content and add an import to mod1 module:

import asmaj/proj1.mod1 as _;

public function main() {
}

Update mod1.bal content and add an import to the default module:

import asmaj/proj1 as _;

public function hello() {
}

Build the package using $ bal build

Need to enable org.ballerinalang.test.imports.ImportsTest#testCyclicImports when fixing this.


Remote kernels

It seems impossible to have two remote kernels (on the same jupyter gateway) connected simultaneously for different python files opened in Atom.
I'm using the last version of hydrogen (0.15).

This is actually by design. Sometimes you want multiple files to be associated with the same kernel. To allow for this use-case, hydrogen only uses one kernel per language (regardless of how many files you have open).
You can still open a new atom window, which will have a separate set of kernels. Alternatively, remote kernels allow you to disconnect from one and then reconnect to it later.
Both the single-kernel-multi-file and multi-kernel use cases are important, and I can't come up with a better compromise between the two workstyles.

I'm quite new to Hydrogen and didn't noticed that kernels are per window.
This behaviour is fine! :-)


Save before executing git command doesn't work anymore in VS2022

Since updating from VS2019 to VS2022, any changed file isn't saved automatically anymore with accessing a TGIT command, like commit, or diff.
So I need to save it manually, before e.g. starting to commit.
No big deal, only a convenience issue, but a regression.

Dear @sboulema,
You just released 5.2.5.
What's with this issue?

Sorry, forgot to elaborate, why I would like to have this issue fixed, why it is now a bigger issue, then in the time of reporting.
I need explicitly to save all documents/files before triggering a git command in TGIT, like "Show changes", "Show Diff", since the files are not saved before executing the commands.
This caused already some mistakes by forgetting to save the desired file or all files.
Any chance for a fix, @sboulema?

Related to #68

Grab the new release! 🚀
It has a new option to enable saving before any Git operation :)


Make "pose" available on the IMixedRealityController interface and make it more readily accessible

Reality Collective - Reality Toolkit Feature Request
Is your feature request related to a problem? Please describe

It is frustrating to be able to discover the location of a controller or any other inputsource device when an event occurs.  Currently position is only reported by the MixedRealityPose events.
How would you classify your suggestion

Usability / Configuration

Describe the solution you'd like

The solution solution should be updated in two parts:

The IMixedRealityController interface needs to be extended to expose a controllers position and rotation, ideally in a Pose struct
The MixedRealityInputSystem should have the ability to query for connected controllers and return the current state of any controller as a IMixedRealityController.

Describe alternatives you've considered

The current solution is horrible, requires to many nested queries and is not really workable.
Additional context

@FejZa agrees :D

Branches up for Core / Meta / Pico for an updated IMixedRealityController interface to expose the current "Pose" of the controller.
Next step is to revisit the Input System for controller query.
I'm sad to report, that is also seems I was partly responsible in the code for hiding the pose, although for the life of me I can't think why :D

Scratch Part-2, it already exists :D
        public bool TryGetController(IMixedRealityInputSource inputSource, out IMixedRealityController controller)
        {
            foreach (var mixedRealityController in detectedControllers)
            {
                if (inputSource.SourceId == mixedRealityController.InputSource.SourceId)
                {
                    controller = mixedRealityController;
                    return true;
                }
            }

            controller = null;
            return false;
        }


Exporting WebRTC related errors into rtcerr to allow other packages to use it.

Pull Request Test Coverage Report for Build 572

39 of 70 (55.71%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 38.426%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

media.go
0
2
0.0%

rtcpeerconnection.go
7
11
63.64%

rtccertificate.go
0
6
0.0%

rtcdatachannel.go
0
7
0.0%

pkg/rtcerr/errors.go
18
30
60.0%

Totals

Change from base Build 566:
0.02%

Covered Lines:
2143

Relevant Lines:
5577

💛  - Coveralls


The prop offsetMin is marked as required in RangeSelectorButton, but its value is undefined.

Bug or Feature Request?
Bug
Description
<RangeSelector selected={1}>
    <RangeSelector.Button count={7} type="day">1w</RangeSelector.Button>
    <RangeSelector.Button count={1} type="month">1m</RangeSelector.Button>
    <RangeSelector.Button count={6} type="month">6m</RangeSelector.Button>
    <RangeSelector.Button count={12} type="month">1y</RangeSelector.Button>
    <RangeSelector.Button count={36} type="month">3yrs</RangeSelector.Button>
    <RangeSelector.Button count={120} type="month">10yrs</RangeSelector.Button>
    <RangeSelector.Button type="all">All</RangeSelector.Button>
    {/* <RangeSelector.Input boxBorderColor="#7cb5ec" /> */}
</RangeSelector>

What did I missed here? and I'm gonna load the data from CSV

It has a default value of zero

actually what does it do?

is there any complete documentation for this?

HighStock documentation


remove kubelet metrics from doc

removed by commit 505a6a4e8e971c6cb3dac643015f946c309ac9ae

@husky-parul CI failed on merging, mkdocs command is missing, can you help? thanks


Log available country rules

We already log if we are using custom areas. This makes it a bit easier for library users to tell if their own rules are getting properly applied.

Thanks


Document default value of InstanceCredentialProvider

Which issue does this PR close?

Closes #5187
Rationale for this change

Couldn't find this info out and wasted an hour or two
What changes are included in this PR?

docs changes
Are there any user-facing changes?
just docs.

I took the liberty of getting this over the line


How can I access the readyState of the video?

@binarykitchen Closing old issues. If you'd like to reopen this, let us know. Thanks!


Ambiguous resolution

Hello,
after upgrading react-native to the latest RC, bundling fails together with react-native-svg:
Bundling `index.android.js`  [development, non-minified, hmr disabled]  0.0% (0/1), failed.
error: bundling failed: ambiguous resolution: module `/Users/so/Documents/workspace/my-app/index.android.js` tries to require `react-native`, but there are several files providing this module. You can delete or fix them:

  * `/Users/so/Documents/workspace/my-app/node_modules/react-native-svg/node_modules/react-native/package.json`
  * `/Users/so/Documents/workspace/my-app/node_modules/react-native/package.json`

Versions:
react-native-cli: 1.0.0
react-native: 0.48.4
react-native-svg: 6.0.0-rc1

Any idea?

Getting the same error using react-native-svg: 5.2.0 and react-native: 0.48.2

Try yarn start --reset-cache

Yep, that works. Thanks!

Just a small correction: to pass --reset-cache via yarn, you need to pass the a separator first, otherwise node will be called without the argument.
yarn start -- --reset-cache
...
node node_modules/react-native/local-cli/cli.js start --reset-cache

@endel That's no longer necessary in the latest version of yarn.

I´m getting a similar error:
Bundling index.js  [development, non-minified]  0.0% (0/1), failed.
error: bundling failed: ambiguous resolution: module D:\PORTAL.MOBILE\PortalMobile\index.js tries to require react-native, but there are several files providing this module. You can delete or fix them:

D:\PORTAL.MOBILE\PortalMobile\node_modules\react-native-view-more-text\node_modules\react-native\package.json
D:\PORTAL.MOBILE\PortalMobile\node_modules\react-native\package.json

I've already tried this comands:
'yarn start --reset-cache'
'node node_modules/react-native/local-cli/cli.js start --reset-cache'
'rm -rf node_modules && npm install'
Any idea?

@RuiDamiao ,restart your mac will resolve this problem.Works for me.

I've restarted my Mac, and I have tried with yarn start -- --reset-cache. Any other idea? This hapened when I added Podfile and started using Pods.

@perzect I've already tried. The problem is that this path 'D:\PORTAL.MOBILE\PortalMobile\node_modules\react-native-view-more-text\node_modules\react-native\package.json' doesn't exist. I don't know what to do.
I cloned the project again and the first time worked well, I've installed another module and I got this error again and now even when I clone the project (again) I get this error.

@RuiDamiao Yep! Delete node_modules will not resolve this Pro. Maybe the key is 'npm uninstall '.I'll try this next time.

I had the same problem. Any solution did not help but cloning project in new folder solve this.

if these doesn't work
yarn start -- --reset-cache
check manually if there is another node_module inside the project.I had the same issue bcoz I duplicated the same project inside the project.

I fixed this by removing all Pod stuff and reinstall them

@allanjsx  Its throwing algorithm' file not found

@allanjsx you can find the issue (currently opened) for the algorithm error here, in one of the solution/comments I found this gist to fix many issues coming from cocoapods

I had to delete the node_module and Pods folder. and npm i and then pod update pod install .
This is because initially I started the project and in the podfile there was no React mentioned.
It was working, then I added another library ( fast-image) and that needed the React to be inside the podfile and then after that it got confused.

@allanjsx 's solution worked for me, except I also had to delete the existing React pod in the ios dir.
Strange that React Native will let this problem occur by default. Lots of packages end up creating a duplicate React pod if you don't force it to use the one from node_modules; I encountered it with the react-native-camera package.

@allanjsx 's solution worked

there are two different versions of react-native in your package.json files.

Most likely you have react native being provided as a variable from the ios pods/React/package.json file, as well as from the base package.json file. Please confirm if this is the case.

Similar to @xe4me solution, this worked for me:
rm -rf node_modules && yarn
pod deintegrate
pod install

Unfortunately, l encountered this annoying problem too. l have resolved this problem by cloning this project in a new dir.

l have resolved this problem in two ways. one is you clone your project in a new dir and another is execute
yarn start -- --reset-cache

l have resolved this problem in two ways. one is you clone your project in a new dir and another is execute
yarn start -- --reset-cache

I have the same problem  but  yarn start -- --reset-cache  can't solve my problem

Also wasn't resolvable for me with a cache reset, FWIW.

I had react-native-cookies and @react-native-community/cookies in my package.json, so it would be a good idea to check for duplicate packages.


 can not display on ios9

Ionic version:  (check one with "x")
ionic 3.7.0
I'm submitting a ...  (check one with "x")
bug report
Current behavior:
the <ion-datetime> can not display on ios9. but on ios10, it works well.

Hello! Thank you for opening an issue with us! Would you be able to provide a sample application via GitHub that demonstrates the issue you are having?
I added an <ion-datetime> to a sample app I had laying around and it worked just fine in iOS9 and iOS10 (both times on the simulator as I do not have an actual iOS 9 device to run this on).
Thanks for using Ionic!

Thank you.
I have found the reason. On iOS9, I must use the ISO datetime format. like "2017-09-04T10:11:00Z". So it can work well.

Glad to hear you found the solution. I will close this then.


Refactor publishing to Maven Central

Use plugin: https://github.com/vanniktech/gradle-maven-publish-plugin
It's a wrapper around Gradle Maven Publish plugin that makes publishing to Maven Central easier. Many open-source libraries have moved to it, for example Accompanist, OkHttp and others.
Why do we need this?
For this library it mainly brings ability to publish to Maven Central from command line without having to go to the Sonatype website.
./gradlew publish --no-daemon --no-parallel
./gradlew closeAndReleaseRepository

This is a step towards automated releases via Github Actions.
There are 2 ways to configure it. I currently do it dynamically via base plugin config in publish-setup.gradle and then in each published module build.gradle.
I think we might rewrite it into using Gradle properties (there are more examples of it in other OSS projects). But for now it should already work.

Thanks a lot!


chore: release v2.0.0

chore: release v2.0.0

closed in favor of https://github.com/facebook/docusaurus/pull/7919


How to import  slider in react component?

after "npm install slider-pro"  I  imported slider-pro in my react component then I got  this error.
".sliderPro is not function "
any solution?

I'm not sure unless I can take a look at the page.
Best,
David


Make it more difficult to accidentally log sensitive headers

Failing job looks like it's just circleci being woefully under provisioned recently https://app.circleci.com/pipelines/github/square/okhttp/4508/workflows/b41ede5e-98f7-4d2d-9dd4-79e655f4838f/jobs/20469


Modify to check if alpha is in host memory.

Summary
In this PR, we modified the runtime verifications to check if Alpha is in host memory.
Due to a modification from PR#956, the CPU may try to access device memory through Alpha, which violates the BIOS restrictions.
Assigned Ticket: https://ontrack-internal.amd.com/browse/SWDEV-496511
Caused Ticket: https://ontrack-internal.amd.com/browse/SWDEV-482839
Caused PR: https://github.com/ROCm/hipBLASLt/pull/956/
Modifications
In hipBLASLt API
HIPBLASLT_MATMUL_DESC_POINTER_MODE has three modes as the following:
typedef enum {
    HIPBLASLT_POINTER_MODE_HOST = 0,                          /** targets host memory */
    HIPBLASLT_POINTER_MODE_DEVICE = 1,                        /** targets device memory */
    HIPBLASLT_POINTER_MODE_ALPHA_DEVICE_VECTOR_BETA_HOST = 4, /** alpha pointer targets a device memory vector of length equal to the number of rows of matrix D, and beta is a single value in host memory. */
} hipblasLtPointerMode_t;

Only the HIPBLASLT_POINTER_MODE_HOST will ensure alpha is in host memory, so we modified validateMatmulArgs to check pointermode.
In hipBLASLtExt API
Since this ScaleAlphaVec is passed as a parameter through the API, we can simply push a nullptr as pointermode.

All the CI local tests are passed for PR#1326
[0;32m[----------] Global test environment tear-down
[==========] 48760 tests from 13 test suites ran. (1755940 ms total)
[  PASSED  ] 48760 tests.
hipBLASLt version: 1100
command line: ./build/release/clients/staging/hipblaslt-test --gtest_output=xml --gtest_color=yes --gtest_repeat=1

This PR has been verified correctness in CQE machine.
[----------] Global test environment tear-down
[==========] 12397 tests from 13 test suites ran. (1879985 ms total)
[  PASSED  ] 12397 tests.
hipBLASLt version: 1100
command line: ./hipblaslt-test
INFO - [CMD OUTPUT ENDS]
INFO - ********************************************************************************
INFO -
+----------------------+
|   Execution Result   |
+----------------------+
| total execution time |
+----------------------+
|  1883.0161821842194  |
+----------------------+
INFO - max previous execution time (For timeout)=0.8999569416046143 , Taken from DB with hostname=cqe-nv31-1-ub-hy-stg-nv31-04
INFO -
+------------------------------------------------------------------+
|                        System Information                        |
+-----------------------+------------------------------------------+
|       Component       |               Information                |
+-----------------------+------------------------------------------+
|      rocm version     |                   2144                   |
|           OS          |                  Ubuntu                  |
|       OS Version      |                  22.04                   |
|     OS Pretty Name    |            Ubuntu 22.04.3 LTS            |
|     vbios version     |             113-D7070100-100             |
|                       |                                          |
|     sbios version     |                   4001                   |
|   GPU marketing name  |           AMD Radeon PRO W7900           |
|        GPU arch       |                 gfx1100                  |
|     Number of GPUs    |                    1                     |
|     GPU partition     |          Compute: N/A, Mem: N/A          |
|     CPU model name    | Intel(R) Core(TM) i7-6800K CPU @ 3.40GHz |
|        hostname       |       cqe-nv31-1-ub-hy-stg-nv31-04       |
|  SMC Firmware version |               <IP_ADDRESS>               |
|                       |                                          |
| SDMA Firmware version |                    24                    |
|                       |                                          |
|      XGMI setup?      |                    No                    |
+-----------------------+------------------------------------------+
INFO -
+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
|                                                                                Summary Table                                                                                |
+------------------+-----------------+----------------------------+----------------------------+-----------------------------+-------------------------------------+--------------+
| No of TestSuites | No of TestCases | Number of Passed testcases | Number of Failed testcases | Number of Errored testcases | Number of Skipped/Not run testcases | Final Result |
+------------------+-----------------+----------------------------+----------------------------+-----------------------------+-------------------------------------+--------------+
|        13        |      12397      |           12397            |             0              |              0              |                  0                  |     PASS     |
+------------------+-----------------+----------------------------+----------------------------+-----------------------------+-------------------------------------+--------------+
2144_nv31_hipblaslt.txt