Enable chroot in AWS again

This is a temporary change to verify if changing the chroot syslog address fixes the current issue.

I have tested that this works after I manually changed the internal-logger-address. For more information view: https://github.com/kubernetes/ingress-nginx/issues/8839
We need a upstream PR to add the possibility of setting internal-logger-address through the helm chart.
Will see if I have time for that next week.
When that get's merged we can continue to work on this PR again.

Realized that we don't have to do any upstream changes since extraArgs is there. I have verified that this works and it's ready for review.

Further down the rabbit hole, it turns out that ingress-nginx is in fact not using chroot directly, but rather unshare -R, see https://github.com/kubernetes/ingress-nginx/blob/18ee046b432502aedfed9321f0a9b50bfc009a67/rootfs/nginx-chroot-wrapper.sh#L18 and https://github.com/util-linux/util-linux/blob/60803291acc7f431fd7750de7b2a2f1d45db1f4d/sys-utils/unshare.c#L1071 . This means that before calling chroot(2) it calls unshare(2). Unfortunately, the Ingress controller does not in fact pass any unshare flags, meaning that it does not disassociate any namespaces (such as mount, user or ipc namespaces). Still, it makes the setup a bit less hacky. Hopefully, the controller will over time unshare more of its execution context so that less sensitive information is exposed.
This has no immediate bearing on this PR, but the use of unshare indicates that the complexity of Dockerfile-chroot will retain the maintainers' attention and will hopefully remain secure and the the ingress nginx will eventually get a reduced surface area.


Maintain indenting level

NPM respects the indentation level of package.json; if you use 4 spaces for indenting, npm will maintain that, rather than reverting it back to 2 spaces everytime it makes a change to the package.json.
Currently it seems sort-package-json doesn't respect indentation level, and just instead reverts the package.json to 2 spaces.

PRs very welcome 😃


Add a possibility to translate References View addon

Add possibility to translate References View addon.
Currently context menu looks weird because of the mix of translated (from vscode itself and etc) and non-translated entries (from that addon).
Thank you.

This is now done


Add pointer-events:none to Tooltips (and probably popovers)

The reason why it is matters to do something like pointer-events: none for tooltips and popovers is: when you have many objects with tooltips and they are located close to each other, when you are moving mouse from one object to another you have a chance to "hit" the tooltip while it is disappearing (with fade animation). In this case the new tooltip will not be shown for sure, even if you will drag a mouse over the new object.

pointer-events doesn't work in IE<11, sadly.
Also, popovers often contain buttons or links, which pointer-events: none would render unclickable.

Exactly. I have faced this problem previously, and solved it using about 15 lines of ugly javascript. Don't think that it is worth to find them for anyone. But this problem is definitely has nice cross-browser fix.

For some reason there are no description in my first post, I will edit it and also post it here:
The reason why it is matters to do something like pointer-events: none for tooltips and popovers is: when you have many objects with tooltips and they are located close to each other, when you are moving mouse from one object to another you have a chance to "hit" the tooltip while it is disappearing (with fade animation). In this case the new tooltip will not be shown for sure, even if you will drag a mouse over the new object.

So, since pointer-events: none doesn't seem like a workable approach, what's the alternative that you're suggesting?

Just checked, it was pointer-events: none exactly, or disabled animations. So I really don`t know how to fix it now.

Punting as a won't fix here—not a clear bug for us to fix. Only thing I could recommend is caution at implementing some of these components in such close proximity to one another. Perhaps another solution could be better? <3

I think you are right. Looks like now there are no fine solution for this problem. The best one for tooltips without interactive elements it to user poiner-events: none, to make more cross-browser fix one need to write huge crutch in JS, I assume. There are no sence in doing it in core this way for sure.

you can use like this below

Tooltip on top


Custom mapping when reading data

The design of Mapper could be improved if executing a DB query was separated from mapping, as these are different concerns.  Having a separate mapping extension method for a DbDataReader makes sense as it would give a natural place to customise the mapping,
e.g. connection.Query(sql, args).ToList<Customer>(rs => Custom(rs));
or connection.Query(sql, args).Map<Customer>(rs => Custom(rs)).ToList(); ?

Added Read<T>() method that has an optional extra action.


hosted/pub.dartlang.org/mobile_scanner-1.1.2/lib/src/mobile_scanner.dart:134:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.

../../../.pub-cache/hosted/pub.dartlang.org/mobile_scanner-1.1.2/lib/src/mobile_scanner.dart:134:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Library/Android/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance?.removeObserver(this);

Please use version 2.0.0


Can we add customMapStyle for MapView?

I want to change theme of MapView, but I don't find anything in this document.
Can we change default style of this map?

+1

My component passed all props to original <MapView/> component from https://github.com/react-native-community/react-native-maps .
Just pass your styles like normally would ;)


Remove Swift code.

I'd like to move all Swift code to a separate repo (probably to be named gnostic-swift), with its own CI so that all Swift work can stay tested without burdening contributions to the gnostic core.

Do we have another repo set up? I'm happy to approve it, but we might want to wait on merging until the new home is up and can replace this. WDYT?

swift code is in timburks/gnostic-swift


sonartest not merge

Proposed changes
Issue Number: close #xxx
Problem Summary:
Describe the overview of changes.
Checklist(Required)

Does it affect the original behavior: (Yes/No/I Don't know)
Has unit tests been added: (Yes/No/No Need)
Has document been added or modified: (Yes/No/No Need)
Does it need to update dependencies: (Yes/No)
Are there any changes that cannot be rolled back: (Yes/No)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

please add some explainations in issue to help the reviewer know why add the test.


Argh2

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: abayer
If they are not already assigned, you can assign the PR to them by writing /assign @abayer in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

:star: PR built and available in a preview environment abayer-jx-demo-qs-pr-2 here


[CMake] Unbreak unified builds

This broke after #1799

@swift-ci please test platform and merge

@swift-ci please test platform


[possible bug] "include" glob-like patterns are excluding definition files if there are regular files with the same name

TypeScript Versions:  apparently, 2.0.x and later, because I checked manually 2.0.10, 2.1.5, 2.2.0-dev.20170129 and both had this issue.
Code
See the repo: https://github.com/noomorph/typescript-include-bug and its README.
Expected behavior:
Should compile OK using both configuration files.
Actual behavior:
In case of tsconfig.include.bug.json it skips index.d.ts and afterwards is unable to find Greetings class.
Question
@rbuckton, @andy-ms, Is this behavior absolutely intended?
If yes, what are the official recommendations for such cases? It is obviously not a documented behavior (examine http://www.typescriptlang.org/docs/handbook/tsconfig-json.html ). Could you explain why does this behavior exist, please?
If that is not something intended, do you think it is a bug or lack of configuration possibilities? I think I can work on a pull request, but I need more details for that.
Thanks in advance.

@rbuckton, @andy-ms, any comments?

The compiler does not include files that can be possible outputs. e.g. if the input includes index.ts, then index.d.ts and index.js is excluded.
We do not recommend having files that differ only in extension next to each other, that breaks assumptions the compiler makes about module resolution.

@mhegazy, thanks! Does it make sense if I add this information to the handbook in a PR ?

sure. PRs welcomed.


Update ENV syntax

https://github.com/docker/cli/pull/2743

I really don't see a compelling reason for the churn (as I noted on that PR). :confused:

The only reason is to avoid deprecation warnings

Closing since this isn't a change we intend to make (and as I commented on that upstream PR, I don't understand the deprecation to begin with :confused:).


BEEFY: optimize voter event loop for fewer 'active' wakeups

Issue
Doing a bit of profiling showed BeefyWorker::run() async task being "active" more than it should, waking up many times even when there haven't been any external events relevant to the voter logic.
Investigating this showed the "culprit" to be listening for network-gossip events in the main async loop. Even if the "interesting" events are only NetEvent::SyncConnected and NetEvent::SyncDisconnected, the BEEFY voter actually wakes up and (uselessly) tries to vote for all network events (which are many!)
Proposed fix
Move network peers tracking to the much lighter BeefyJustifsRequestHandler::run() task (which is also the user of the connected peer set); thus massively decreasing wake-up rate of the heavier BEEFY voter task.

Actually GossipValidator has callbacks for peers connecting and disconnecting so just use that instead and avoid the extra async task.


Correct the links to Perlito

The links in the page were not accurate:

http://www.perlito.org/ => Server not found error
http://perlcabal.org/~fglock/perlito6.html => redirected to http://perl6.org/

There also issues with the Pugs links but I don't know what those should be :)

Thanks!


Test | Add test to validate microsoft.sql.DateTimeOffset interchangeable behavior

Open for more use-cases to capture any wrong computations done by driver when sending data to SQL Server's DateTimeOffset column.

Codecov Report

Merging #1005 into dev will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##                dev   #1005      +/-   ##
===========================================
+ Coverage     50.09%   50.1%   +0.01%
  Complexity     2879    2879
===========================================
  Files           120     120
  Lines         27989   27989
  Branches       4677    4677
===========================================
+ Hits          14020   14024       +4
- Misses        11709   11710       +1
+ Partials       2260    2255       -5

Flag
Coverage Δ
Complexity Δ

#JDBC42
49.68% <ø> (ø)
2841 <ø> (ø)
:arrow_down:

#JDBC43
49.98% <ø> (ø)
2871 <ø> (+1)
:arrow_up:

Impacted Files
Coverage Δ
Complexity Δ

...om/microsoft/sqlserver/jdbc/SimpleInputStream.java
52.23% <0%> (-1.5%)
11% <0%> (-1%)

...m/microsoft/sqlserver/jdbc/SQLServerException.java
76.64% <0%> (-1.46%)
32% <0%> (-1%)

...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
46.22% <0%> (-1.08%)
110% <0%> (-2%)

...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java
68.12% <0%> (-0.24%)
0% <0%> (ø)

...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java
43.86% <0%> (+0.19%)
318% <0%> (+1%)
:arrow_up:

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
55.55% <0%> (+0.19%)
0% <0%> (ø)
:arrow_down:

...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java
39% <0%> (+0.64%)
43% <0%> (+1%)
:arrow_up:

...om/microsoft/sqlserver/jdbc/ReaderInputStream.java
43.95% <0%> (+3.29%)
15% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84484ed...2cc8dbc. Read the comment docs.


How to get a reference to the container of a SwinjectStoryboard

I've encountered such a situation that I've got a network service as a view controller's dependency. And a token is required for the network service. The token is fetched after initializing the container. So the network service registered in the container is not correct.
Is there a way to solve such a problem in Swinject?

Maybe this???
https://github.com/Swinject/Swinject/blob/v1/Documentation/DIContainer.md#registration-with-arguments-in-a-di-container

@yoichitgy All of my component registrations are in the setup method  of SwinjectStoryboard. Is that possible to use the container outside the method?

#27 might be helpful for you.

@yoichitgy I was wondering how to get the reference to the container outside the setup method such as the c in last statement of the code snippets you provided in #27 :
// Inside setup()
let c = Container()
c.register(ViewModel.self) { r, foo in ViewModel(foo: foo) }
c.registerForStoryboard(ViewController.self) { r, vc in vc.vm = r.resolve(ViewModel.self, arg1: ???) }
c.register(ViewController.self) { r, sb, a1 in
    let vc = sb.instantiateViewControllerWithIdentifier("ViewController")
    vc.vm = r.resolve(ViewModel.self, arg1: a1)
    return vc
}

// Instantiate ViewController
let resolvedVC = c.resolve(ViewController.self, arguments: (sb, arg1))

It seems out of scope =.=

You can use create(name:bundle:container:) method of SwinjectStorybard.
http://cocoadocs.org/docsets/Swinject/1.1.2/Classes/SwinjectStoryboard.html#/s:ZFC8Swinject18SwinjectStoryboard6createFT4nameSS6bundleGSqCSo8NSBundle_9containerPS_19PropertyRetrievableS_10Resolvable__S0_

Feel free to reopen this issue if you have more questions about this topic.

Hello!
@yoichitgy I don't see the solution of OP's problem (I have the same request).
For example, if I'm using VC'c with dependencies, then I have to use SwinjectStoryboard.
If I'm using SwinjectStoryboard, then I'm probably want to create my own Container and pass it to SwinjectStoryboard (either way I don't know how to pass another dependencies in unit tests where I can simply create another Container with mocks).
So I have to register all the stuff (ViewController, ViewModels, my various Services such as "Rest Api Controller Service", etc.) in this container which im passing to SwincjectStoryboard.
And my problem is: when I wan't to resolve one of my dependency (such as some service) in some place of code which is NOT ViewController created in SB, how can I get Resolver instance to resolve some dependency? Now I can only type SwinjectStoryboard.defaultContainer but what to do if I'm using my own container?
I can create container, save ref to it im my app (in some singleton class) and then pass this container to SwinjectStoryboard. But it seems to strange for me if I can't get current container from SwinjectStoryboard class.
I hope my message it's not too messy :) Thanks.


Flow progress reporter with frequency

How to categorize this PR?

/area scalability cost
/kind enhancement
/priority normal
What this PR does / why we need it:
With this PR we enhance the flow's progress reporter in a way that it can delay the progress reporting. This might helpful in large landscape where a lot of shoots exist to limit the number of updates to the Shoots' status sections.
Special notes for your reviewer:
Any opinions on whether we should default the progressReportFrequency field in the gardenlet config, or should we rather keep it to the Gardener operator to configure it properly?
Release note:

It is now possible to delay the progress reporting for shoot operations by setting the `.controllers.shoot.progressReportFrequency` field in the gardenlet component config. This might helpful in large landscape where a lot of shoots exist to limit the number of updates to the `Shoot`s' `status` sections.

The `flow` package's progress reporter option has been changed to return the new `ProgressReporter` interface. You can call `flow.NewImmediateProgressReporter` with your reporter function as a replacement.

/hold

/unhold

Renamed progressReporterFrequency to progressReporterPeriod
Fixed a deadlock which was caused by https://github.com/gardener/gardener/pull/2908#discussion_r495991280


convert type hints to type comments

This PR converts type hints to type comments.

Of course tests are failing for python2.7. Can we drop the tests or do we need an extra branch, to develop things meant for poetry 1.2?


Added event.stopPropagation to the confirm/alert onclick

When opened on a dialog the default confirm/alert cause its closure because of https://github.com/shlomiassaf/angular2-modal/issues/111
This avoids the issue.

@CaselIT Can you explain the issue?
When you open a dialog from a dialog?

It's connected to the issue
https://github.com/shlomiassaf/angular2-modal/issues/111 : if on a parent
dialog you use another dialog to ask for the confirmation of some action,
clicking a button on the child dialog will close also the parent dialog,
since the target element of the event is not in the the parent dialog, so
the click outside handler will execute. Calling stopPropagation will avoid
click outside execution.
I hope this explanation is clearer, if not tomorrow I'll add an example
Il 17/giu/2016 23:58, "Shlomi Assaf"<EMAIL_ADDRESS>ha scritto:

@CaselIT https://github.com/CaselIT Can you explain the issue?
When you open a dialog from a dialog?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/shlomiassaf/angular2-modal/pull/114#issuecomment-226891327,
or mute the thread
https://github.com/notifications/unsubscribe/APbQyI2ri-XrIRDKXEkbVnoSYKBAbIQBks5qMxhogaJpZM4I3T3j
.


[version] vbump to v0.10.45post1

Hi Andrei,
Does llama-index-core version need to be bumped again, rebuilt and published too?
I clone the repo to local, install locally, it works.
However, when installing using pypi, it still cannot pick up the latest files from
https://github.com/run-llama/llama_index/blob/main/llama-index-core/llama_index/core/utilities/gemini_utils.py
TL;DR
MessageRole.TOOL has been added to the file. it still shows the error below:
~/miniconda3/lib/python3.11/site-packages/llama_index/core/utilities/gemini_utils.py:37, in merge_neighboring_same_role_messages(messages)
32 merged_content = [current_message.content]
34 # Check if the next message exists and has the same role
35 while (
36     i + 1 < len(messages)
---> 37     and ROLES_TO_GEMINI[messages[i + 1].role]
38     == ROLES_TO_GEMINI[current_message.role]
39 ):
40     i += 1
41     next_message = messages[i]
KeyError: <MessageRole.TOOL: 'tool'>

Oh strange. I just tried on a fresh virtualenv using pyenv and it seems to have install v0.10.45 of llama-index-core:
pyenv virtualenv llama-test
pyenv activate llama-test
pip install llama-index

Checking what versions of packages installed:
pip freeze | grep llama-index

llama-index==0.10.45.post1
llama-index-agent-openai==0.2.7
llama-index-cli==0.1.12
llama-index-core==0.10.45
llama-index-embeddings-openai==0.1.10
llama-index-indices-managed-llama-cloud==0.1.6
llama-index-legacy==0.9.48
llama-index-llms-openai==0.1.22
llama-index-multi-modal-llms-openai==0.1.6
llama-index-program-openai==0.1.6
llama-index-question-gen-openai==0.1.3
llama-index-readers-file==0.1.25
llama-index-readers-llama-parse==0.1.4

/llama-index-core/pyproject.toml needs to be bumped and rebuilt. I guess
On Mon, Jun 17, 2024 at 9:43 AM Andrei Fajardo @.***>
wrote:

Oh strange. I just tried on a fresh virtualenv using pyenv and it seems to
have install v0.10.45 of llama-index-core:
pyenv virtualenv llama-test
pyenv activate llama-test
pip install llama-index
Checking what versions of packages installed:
pip freeze | grep llama-index
llama-index==0.10.45.post1
llama-index-agent-openai==0.2.7
llama-index-cli==0.1.12
llama-index-core==0.10.45
llama-index-embeddings-openai==0.1.10
llama-index-indices-managed-llama-cloud==0.1.6
llama-index-legacy==0.9.48
llama-index-llms-openai==0.1.22
llama-index-multi-modal-llms-openai==0.1.6
llama-index-program-openai==0.1.6
llama-index-question-gen-openai==0.1.3
llama-index-readers-file==0.1.25
llama-index-readers-llama-parse==0.1.4
—
Reply to this email directly, view it on GitHub
https://github.com/run-llama/llama_index/pull/14198#issuecomment-2173872393,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOC4M4HOABXL3P27CW4IH63ZH4GZZAVCNFSM6AAAAABJOJADRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTHA3TEMZZGM
.
 For me, it did install v0.10.45 of llama-index-core which is what we want right?

llama-index==0.10.45.post1
llama-index-agent-openai==0.2.7
llama-index-cli==0.1.12
llama-index-core==0.10.45
llama-index-embeddings-openai==0.1.10
llama-index-embeddings-vertex==0.1.0
llama-index-indices-managed-llama-cloud==0.1.6
llama-index-legacy==0.9.48
llama-index-llms-openai==0.1.22
llama-index-llms-vertex==0.2.0
llama-index-multi-modal-llms-openai==0.1.6
llama-index-program-openai==0.1.6
llama-index-question-gen-openai==0.1.3
llama-index-readers-file==0.1.25
llama-index-readers-llama-parse==0.1.4
llama-index-vector-stores-vertexaivectorsearch==0.0.1

It shows 10.45 for llama-index-core, but it does not include the latest python files.
https://pypi.org/project/llama-index-core/ is not updated!
I guess when the version was miss-matched on June 14, 10.45 for llama-index-core build picked up 10.44 version of files.
Could you rebuild 10.45 for llama-index-core? or have to bump this version to be published to pypi

llama-index==0.10.45.post1
llama-index-agent-openai==0.2.7
llama-index-cli==0.1.12
llama-index-core==0.10.45
llama-index-embeddings-openai==0.1.10
llama-index-embeddings-vertex==0.1.0
llama-index-indices-managed-llama-cloud==0.1.6
llama-index-legacy==0.9.48
llama-index-llms-openai==0.1.22
llama-index-llms-vertex==0.2.0
llama-index-multi-modal-llms-openai==0.1.6
llama-index-program-openai==0.1.6
llama-index-question-gen-openai==0.1.3
llama-index-readers-file==0.1.25
llama-index-readers-llama-parse==0.1.4
llama-index-vector-stores-vertexaivectorsearch==0.0.1

https://pypi.org/project/llama-index-core/ is  not updated.
On June 14, when the version miss-match, llama-index-core seems to install the old files (44 version). I guess.

I download and check the https://pypi.org/project/llama-index-core file.
It does include the OLD files, not the latest from https://github.com/run-llama/llama_index/blob/main/llama-index-core/llama_index/core/utilities/gemini_utils.py

Ah okay, sorry for the confusion here but it seems we've conflated two things:

The version dependency misalignment of llama-index-core in the "umbrella" package of llama-index

The need for a new version of llama-index-core to be released

Fixing 1. does not fix your need with 2. That is because, the changes to llama-index-core/llama_index/core/utilities/gemini_utils.py came after I published v0.10.45 of llama-index-core (see image below).

I'm just going to cut a new release of llama-index-core and llama-index v0.10.46 very soon. Just waiting for another PR that my colleague is working on so that its also included in this latest release.

(Or maybe it was just me conflating things here and misunderstanding you to begin with!)

awesome! thanks for the explanation. I think your solution will work.


docs: Add badges to readme

Add relevant badges to readme

Codecov Report

Merging #44 (84d0a8d) into main (a792bd6) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   41.05%   40.99%   -0.06%
==========================================
  Files          21       21
  Lines        9081     9081
==========================================
- Hits         3728     3723       -5
- Misses       4180     4183       +3
- Partials     1173     1175       +2

Impacted Files
Coverage Δ

internal/llrp/reader.go
40.13% <0.00%> (-1.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a792bd6...84d0a8d. Read the comment docs.


Add more buttons

hi, i need add more buttons on bottom, where display an button default.

I think the most flexible way to do this is to allow overriding the button container (e.g. to provide a custom div container with multiple buttons).
@max10rogerio Do you want to give it a try and submit a PR?

I close this for now. PR is still welcome though :)


Sample code needs change in azure/batch/tutorial-run-python-batch-azure-data-factory.md

Change the Python code in the last line from
blobService.create_blob_from_text(containerName, "iris_setosa.csv", "iris_setosa.csv")
to
blobService.create_blob_from_path(containerName,"iris_setosa.csv","iris_setosa.csv")
As the existing code doesn't produce the correct output in the container
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 894562e1-2c07-2f75-b420-d843262a7f07
Version Independent ID: 1b1fa915-19f0-653c-04d5-218ed4335398
Content: Run Python scripts through Data Factory - Azure Batch Python - Azure Batch
Content Source: articles/batch/tutorial-run-python-batch-azure-data-factory.md
Service: batch
GitHub Login: @mammask
Microsoft Alias: komammas

@binduchinnasamy
Thanks for the feedback! We are currently investigating and will get back on this.

@mammask
Can you please check and add your comments on this doc update request as applicable.


No TextEditingController parameter

Is there a way to pass TextEditingController into InternationalPhoneInput?
I would like to be able to change the text inside.

I am facing same issue, this was not getting fixed so I made my own phone field. You can use it from here until this is fixed.
https://pub.dev/packages/intl_phone_field


Getting can't modify frozen #<Class:#Rake::Task:0x007f88ab1af578> While running cap dev shell

I am trying to setup Capistrano for a project and getting the below error while running cap dev shell. I am getting the same error on cap dev deploy:check.
deploy.rb
set :application, "fex"
set :repo_url, "git@bitbucket.org:faasos/fex.git"

set :ec2_access_key_id,"AAAAAAAAAAA"
set :ec2_secret_access_key,"AAAAAAAAAAAAAAAAAAAAAA"
set :ec2_project_tag, 'Projects'
set :ec2_roles_tag, 'Roles'
set :ec2_stages_tag, 'Stages'
set :default_shell, "/usr/bin/bash"
set :shell, "bash"

set :keep_releases, 20

namespace :deploy do

  desc "run the frontend"
  task :seed do
    run "cd #{fetch(:deploy_to)}/current/code/fex/frontend; nohup puma RAILS_ENV=#{rails_env} &"
  end

  desc 'Restart application'
  task :restart do
    on roles(:fex), in: :sequence, wait: 5 do
      within "#{fetch(:deploy_to)}/current/" do
        # Your restart mechanism here
        begin
          #execute "fuser -k 3000/tcp"
        rescue =>e
          puts "[Error] e.to_s"
        end
       #execute "cd /home/ubuntu/code/fex/frontend && RAILS_ENV="development" nohup puma &"
        end
    end
  end
after :publishing, :restart

  after :restart, :clear_cache do
    on roles(:foodex), in: :groups, limit: 3, wait: 10 do
      # Here we can do anything such as:
      # within release_path do
      #   execute :rake, 'cache:clear'
      # end
    end
  end
end

dev.rb
require "cap-ec2/capistrano"

set :rails_env, :dev
set :branch, "master"
set :deploy_user, "ubuntu"
set :full_app_name, "fex"
set :deploy_to, "/home/#{fetch(:deploy_user)}/code/#{fetch(:full_app_name)}"

ec2_role :frontend,user: 'ubuntu'
ec2_role :samachar,user: 'ubuntu'

imohit:prod$ cap dev shell
WARNING: load:defaults has already been invoked and can no longer be modified.
Check that you haven't loaded a Capistrano plugin in deploy.rb by mistake.
Plugins must be loaded in the Capfile to initialize properly.
(Backtrace restricted to imported tasks)
cap aborted!
can't modify frozen #<Class:#<Rake::Task:0x007f88ab1af578>>

Tasks: TOP => dev
(See full trace by running task with --trace)

cap dev deploy:check
WARNING: load:defaults has already been invoked and can no longer be modified.
Check that you haven't loaded a Capistrano plugin in deploy.rb by mistake.
Plugins must be loaded in the Capfile to initialize properly.
(Backtrace restricted to imported tasks)
cap aborted!
can't modify frozen #<Class:#<Rake::Task:0x007f98992971b8>>

Tasks: TOP => dev
(See full trace by running task with --trace)

This has been fixed by calling the required modules in the "Capfile".
require 'capistrano/bundler'
  require "cap-ec2/capistrano"
  require 'capistrano/rails/assets'
  require 'capistrano/rails/migrations'

Glad to hear you solved the issue. Could we improve the error messaging or behavior for other people that may encounter this in the future? If you have any suggestions let us know. Thanks!

Yes, It would be good if It can display the clear message instead of ambiguous (can't modify frozen #<Class:#Rake::Task:0x007f98992971b8>) that these packages are required. As Its displaying When I tried to enable the "set :scm, :git" And it says that this does not supported anymore. You have to use the below lines in CapFile.
require "capistrano/scm/git"
install_plugin Capistrano::SCM::Git

Yes, It would be good if It can display the clear message instead of ambiguous (can't modify frozen #Class:#Rake::Task:0x007f98992971b8)

The error includes this text:
WARNING: load:defaults has already been invoked and can no longer be modified.
Check that you haven't loaded a Capistrano plugin in deploy.rb by mistake.
Plugins must be loaded in the Capfile to initialize properly.

Could that be improved somehow? Is the problem that it is hard to see this message amongst the other output?

When I tried to enable the "set :scm, :git" And it says that this does not supported anymore.

Are you referring to this message?
[Deprecation Notice] `set :scm, :git` is deprecated.
To ensure your project is compatible with future versions of Capistrano,
remove the :scm setting and instead add these lines to your Capfile after
`require "capistrano/deploy"`:

require "capistrano/scm/git"
install_plugin Capistrano::SCM::Git

That seems pretty good to me. How would you suggest improving it?

Yes, the below message is awesome as its displaying the specific part which needed to be targeted.
[Deprecation Notice] `set :scm, :git` is deprecated.
To ensure your project is compatible with future versions of Capistrano,
remove the :scm setting and instead add these lines to your Capfile after
`require "capistrano/deploy"`:

require "capistrano/scm/git"
install_plugin Capistrano::SCM::Git

I was confused with the below message, As which plugin it is taking about and Was ignoring it almost because it says its just a warning. It says that the problem is with deploy.rb, I was looking into it. Later on, I tried adding another thing which required many other plugins to be included in Capfile and it works. It seems to be the convention than a rule.
WARNING: load:defaults has already been invoked and can no longer be modified.
Check that you haven't loaded a Capistrano plugin in deploy.rb by mistake.
Plugins must be loaded in the Capfile to initialize properly.

Good feedback. I'll open a separate issue. Thanks!

@mattbrictson I would be more than happy to assist you and to contribute to the project. Thanks for the great tool. :)

@ethicalmohit thanks for the offer to assist the project! We have several issues that are tagged "you can help". If any of those catch your eye, leave a comment to let us know you're interested in submitting a PR. We might be able to offer implementation or testing tips. There are also some documentation issues that don't require any coding.


register_buf_ring and unregister_buf_ring

Add support for the buffer ring, available since 5.19.
Add functions register_buf_ring and unregister_buf_ring
and make public the sys::io_uring_buf struct as cqueue::io_uring_buf.

would you like to add a test?

would you like to add a test?

Would a trivial register test like one I added earlier be sufficient? Actually testing buf rings means implementing a buf ring mechanism which comes with all sorts of opinions and I like that io_uring is trying to keep opinions out of its bindings.

It is better to have a complete test, but at least a simple test.

I'm trying to build a test that actually uses a buf_ring entry so is taking me a little longer.

Once the reviews are passed, confirming you will squash the commits into one? Can I offer a patch version bump here too or do you like to keep those separate commits?

I have a full unit test, but I haven't found a good way to make the file compile when unstable is not specified so its not ready for review yet.

@quininer I have a more full blown unit test for the buf_ring registration and the buf_ring struct that is made public.
Do you know of a way to exclude an entire file from the build when the unstable feature is not given? I may end up putting cfg(not(feature = "unstable")) on many lines of a test file.

@FrankReh You can put a #![cfg(..)] at the head of file. or #[cfg(..)] mod your_mod;

Full test has been added too.

If and when this is accepted, another version bump will be needed.


View Mode Cursor wrong position in Playground, Xcode 6.1

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/5526452-view-mode-cursor-wrong-position-in-playground-xcode-6-1?utm_campaign=plugin&utm_content=tracker%2F252770&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F252770&utm_medium=issues&utm_source=github).

This is still a bug with rich markdown playgrounds in Xcode 7

Nobody would fix this issue ?

This should also be closed as a duplicate of https://github.com/XVimProject/XVim/issues/622 (even though it's older)


Update LR Trie to work with owned byte vectors instead of byte slices

…tead of slices

This fails compilation on tx_trie. Can we just merge it and I'll fix this?

@Rakowskiii this PR is not done yet, I'm addressing compilation issues on both state and tx_trie


some packages require 6.8.3@query-string and failed to build , Is there any problem

Failed to minify the code from this file:
    ./node_modules/_query-string@6.8.3@query-string/index.js:9

Duplicate of #135


docs: include rocky linux in compatibility matrix

Signed-off-by: Waleed Malik<EMAIL_ADDRESS>What this PR does / why we need it:
Add Rocky Linux to the compatibility matrix.
Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Optional Release Note:

NONE

/retest

/retest

/retest

/retest


How to handle filesystem errors?

Currently when uploading a file and a filesystem error occurs the request stream will be simply closed without the data being properly sent, which makes the receiving server think everything is good and it can save the file.
Somehow the request should be aborted on a filesystem error...
Any advice?

I think the errors should be (re)emitted on the stream. I've filed a related issue: #373


testing/log: Use lib/bats/helper-function

Applying the lib/bats/helper-function functions throughout makes the log and log assertion tests substantially faster. On my MacBook Pro before the change:
  ./go test testing/log/assertions log

  92 tests, 0 failures, 2 skipped

  real    1m22.348s
  user    0m36.324s
  sys     0m42.763s

and after the change:
  92 tests, 0 failures, 2 skipped

  real    0m34.204s
  user    0m17.075s
  sys     0m15.461s

Coverage increased (+0.01%) to 95.308% when pulling 609f05614d0db5abbee809f84c03f37f6e2926bf on bats-function into 0391bc92a551aa0bf6e16b2432c2fab74964b906 on master.


Fix hashtag

Fixes #498
Not bothering with CHANGELOG.md since this fixes an unreleased regression.

Oops - sorry @isc-pbarton didn't mean to tag you here.


BUG - Growatt MOD 5000 TL3-X 3-fase doesnt show invertor values

Describe the bug

The Integration shows correct totals and does seem to recognise the inverter however individual measurements are not captured.
To Reproduce

See screenshots.
Growatt Device Type

Device(s): MAX/MID/MAC
Home Assistant information

Home Assistant version: 2023.2.0b7
Growatt Server API Integration version: V1.0.1 (HACS)

Additional context

Growatt Screenshot

Total sensors (working):

Invertor sensors:

Hi @horstefan - Thanks for logging this, especially since you're the first person to log a bug using the template correctly!!!! Gold Star for you!
We do not yet have support for MAX/MID/MAC systems.
This is stated on the info page here: https://github.com/muppet3000/homeassistant-growatt_server_api/blob/dev/info.md
It is also outlined in this ticket: https://github.com/muppet3000/homeassistant-growatt_server_api/issues/11
I'm going to mark this as a duplicate of the other ticket and close it. I recommend following the status of the other ticket as I'm planning on adding that support very soon.

Thanks @muppet3000 . if providing my credentials or testing help you in the development; please reach out!

I already have some sets of credentials. However, if you're happy to share credentials so I have more to test with that would be great.
There's details here on how to share them in a more secure manner than just passing me your own credentials.


function &get_instance(){}

return CI_Controller::get_instance();
or
return &CI_Controller::get_instance();

Or at least try to be clear.

As the doc described at http://www.codeigniter.com/user_guide/general/creating_libraries.html

However, in my opinion,  to reference the original CodeIgniter object, the function get_instance
should be defined as
return &CI_Controller::get_instance();

instead of
return CI_Controller::get_instance();

And, I notice that in CI3.0 it doesn't use & as it declared, e.g. in line 69 , system/database/DB.php
foreach (get_instance()->load->get_package_paths() as $path)

I'm really ashamed with my poor English,  I hope  I have described my question clearly. Thanks!

If you tried to declare a function that way, you'd see that this would be a syntax error: https://3v4l.org/eLAu4
Please don't ask such questions here ... it's a bug tracker, not a forum board. And if you want to improve something, test and verify it first.

ah, I see. And thank you for your guidance.


Post with included attribute

I have an endpoint with a has_many relationship. For this case let's say Object Foo needs many Bars. The way the backend is structured I need to create the Foo and multiple Bars all at once and link them together via a transaction. If the Foo or any bar fails to be created then it should roll back and send an error back. Would I accomplish this by Posting to /foo with the attributes for Foo and then in that body also post "included" with the attributes for each Bar? The only documents I can find only mention "included" in the Get response and not the POST. Thanks!

Unfortunately, there's no standard way of including related object attributes in a request, and no standard way of wrapping multiple dependent operations in a single "transaction." The recommended solution is to create the Foo, then create the Bars, and either associate the Bars to the Foo when you create them or do so in a third step (i.e. PATCH or POST /foos/:foo_id/relationships/bars). If any step of this fails, you'll need to manually "roll back" the other steps by deleting resources and/or dissociating (disassociating?) them. It's admittedly painful.
There are several proposals/work-arounds out there to either include related object attributes in a request or encapsulate multiple operations in a single request, but to the best of my knowledge, none of them have been accepted as a new standard, and all of them are very much implementation-specific.

Ref #1089.

You could model the construction of the target object as requiring a construction process (factory pattern). So you create a resource for the construction process itself, patch it with all the data needed and finally trigger the construction with a final patch.
example
so you start by
POST /foo-constructions

and add the details as PATCHes on the returned foo-construction
PATCH /foo-construction
foo-data
bar-data[1]
....

and finally
PATCH /foo-construction/{id}
constructed = true

by setting constructed to true the transaction starts, and you can return from the construction a document with relationships to all the constructed things.
This is not perfect, too :/

Without violating the standard you may use UUID and send body this relationships and data in included, with ids, that contains generated UUIDs.
If you work with JavaScript, it may be conveniently to use jsona for create correct json from data, that you want to send.

Closing in favor of #1197


Bug: not detecting SIM105 when loop is present

With ruff==0.3.3, I think SIM105 should be triggered here, but it's not:
try:
    for _ in range(1):
        pass
except (NotImplementedError, ValueError):
    pass

In other words, I think the above code snippet should be autofixed to:
import contextlib

with contextlib.suppress(NotImplementedError, ValueError):
    for _ in range(1):
        pass

I think this can be merged into https://github.com/astral-sh/ruff/issues/8593.


Draft_75 long messages (+suggested patch)

Hi,
I'm using this library on Android to communicate with an (old?) Draft_75 server.
I found that long messages from the server were not assembled correctly on the client side.
I'm not a big expert on web sockets, so I'm not even sure Draft_75 is supposed to handle this on the client or how.
Could be a crude hack, but what I ended up doing to get it working was:
// Changes to Draft_75 class

add a boolean field:
private boolean appending = false;

inside if (readingState) { ... }
curframe.setOptcode ( Opcode.CONTINIOUS  ); // instead of TEXT
this.appending = true;

when closing the read on END_OF_FRAME:
curframe.setOptcode ( this.appending ? Opcode.CONTINIOUS : Opcode.TEXT );
this.appending = false;

This makes WebSocket enter the Opcode.CONTINIOUS state when reading such frames,
and when the fin is marked on the last frame part, the message is emitted.
Sorry if this is way off or something, hopefully it will help somehow.

Thanks you very much for finding that bug!
Draft_75 is old and most (all?) current browsers do not support it (any more).

Happy to contribute, thanks for the code and effort on this lib, it seems like one of the better choices for Android currently. :)
I'm actually using this in a non-browser client right now (browsers will join later), and will probably update the server when I can (what's the current popular draft btw?)

The drafts are named after http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-17.
Succeeding drafts are often "binary compatible" so the our implemented drafts should cover the most important features of all specified drafts. Currently there are a lot of small gaps like the handling of damaged UTF8 text messages and some ping and pong edge cases. Also not yet supported are wss and protocol extensions capabilities.
But Draft10 and 17 should have full framing support.
BTW: If you do not specify any draft in the constructor of the server it will auto detect the clients draft.
@lassic Could you take a look at #60?

Thanks for the detailed explanation.
For now I don't require wss so it's fine (I read on another project that supporting wss with NIO can be a bit of a pain, but I haven't looked into it).
Also, I'm only using the client side for now, but I'll keep updating my experience on the client for Android on the issue you asked.


Updates grpc-web-client

Updates grpc-web-client to @improbable-eng/grpc-web.
Also fixes webpack entry file. Should be "dist/grpc-web-client.js" instead of "dist/index.js".
Updates #41

Yeah so the tests are failing because of a behaviour change in newer versions of grpc-web-client. While I'd ideally see these tests fixed, I'd be OK with just removing some of the checks. Could you go ahead and do that? The tests should be runnable locally with make integration.
If you find yourself trying to get stuff running and not getting anywhere, I'm afraid to say that's basically the state of this library at the moment. I don't have the will or energy to maintain it when GopherJS is falling behind the main distribution already.

tests fixed.

Thanks for your contribution!


Cannot activate Marketable service if in technical service are links with https for wsdl

[Version] OSCM 17.4.0 2017/10/12
Docker image with TomEE
[How to reproduce]

In technical service I have https links to WSDL:
https://oscm-app:8881/oscm-app/webservices/(...)
creating new marketable service based on the technical service
define publishing option
define price model
trying to activate the marketable service

[Expected result]
Service is activated
[Observed result]

Red message "The operation failed"
Logs of oscm-core:

Caused by: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
at sun.security.validator.PKIXValidator.doBuild(PKIXValidator.java:387)
at sun.security.validator.PKIXValidator.engineValidate(PKIXValidator.java:292)
at sun.security.validator.Validator.validate(Validator.java:260)
at sun.security.ssl.X509TrustManagerImpl.validate(X509TrustManagerImpl.java:324)
at sun.security.ssl.X509TrustManagerImpl.checkTrusted(X509TrustManagerImpl.java:229)
at sun.security.ssl.X509TrustManagerImpl.checkServerTrusted(X509TrustManagerImpl.java:124)
at sun.security.ssl.ClientHandshaker.serverCertificate(ClientHandshaker.java:1496)
... 161 more
Caused by: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
at sun.security.provider.certpath.SunCertPathBuilder.build(SunCertPathBuilder.java:141)
at sun.security.provider.certpath.SunCertPathBuilder.engineBuild(SunCertPathBuilder.java:126)
at java.security.cert.CertPathBuilder.build(CertPathBuilder.java:280)
at sun.security.validator.PKIXValidator.doBuild(PKIXValidator.java:382)
... 167 more
[Details]
It seems like problem with certificates.
It works properly if in technical service are links with http.

According to what was agreed, internal comunication beetween containers will be over http not https.


Add lab5 main and test

Fixes #
Review of colleague's PR #
Changes proposed in this PR:
-
Add lab5 main and test

The go-course is now closed. Thank you very much for participating.


Fix issue with out of stock

When you filter color/pattern attributes, the module doesn't show results of combinations out of stock.
Fix: https://github.com/PrestaShop/PrestaShop/issues/12143

This change is

I just ran in to this issue as well, but this PR does not seem correct either. I think it would be better if the JOIN to the stock_available table is left as is, but NOT added to the query if stock management is disabled. If stock management is enabled, then it would be better to hide results.

@mwijngaard Yes, I agree with you. When stock management is disabled stock_available should be left.

Thanks for your answer @dineshbadrukhiya
I close this PR in favor of #51


Add the resourceType field to Avro records

This is a follow-up of #1003 and in particular this comment. Instead of trying to record the resource-type in the id field, we should add a resourceType field to the Avro representation of FHIR resources. Although this field is present in the JSON representation of all FHIR resources, but it seems to be missing from the StructureDefinition files and also the documentation.

This is not high priority for now (hence P3) because conversion to HAPI objects and then JSON encoding, adds the resourceType field.


12 convert the starting code to use classes

@AlexBradley0 Before I review, I made some changes to remove some conflicts since you worked of the main tdse-solver.py, could you have a look to review it before I commit?

Looks fine to me, you're good to commit


Type errors for map.d.ts when importing typedoc with TypeScript 5.6.3

Search terms
TypeScript, Map, 5.6
Expected Behavior
import * as typedoc from 'typedoc' (or const typedoc = require('typedoc')) for accessing Typedoc's default options in order to add to them should not cause compilation errors with TypeScript 5.6.x
Actual Behavior
TypeScript raises the following errors:
node_modules/typedoc/dist/lib/utils/map.d.ts:19:5 - error TS2416: Property 'entries' in type 'StableKeyMap<K, V>' is not assignable to the same property in base type 'Map<K, V>'.
  Type '() => IterableIterator<[K, V]>' is not assignable to type '() => MapIterator<[K, V]>'.
    Type 'IterableIterator<[K, V]>' is missing the following properties from type 'MapIterator<[K, V]>': map, filter, take, drop, and 9 more.

19     entries(): IterableIterator<[K, V]>;
       ~~~~~~~

node_modules/typedoc/dist/lib/utils/map.d.ts:20:5 - error TS2416: Property 'keys' in type 'StableKeyMap<K, V>' is not assignable to the same property in base type 'Map<K, V>'.
  Type '() => IterableIterator<K>' is not assignable to type '() => MapIterator<K>'.
    Type 'IterableIterator<K>' is missing the following properties from type 'MapIterator<K>': map, filter, take, drop, and 9 more.

20     keys(): IterableIterator<K>;
       ~~~~

node_modules/typedoc/dist/lib/utils/map.d.ts:21:5 - error TS2416: Property 'values' in type 'StableKeyMap<K, V>' is not assignable to the same property in base type 'Map<K, V>'.
  Type '() => IterableIterator<V>' is not assignable to type '() => MapIterator<V>'.
    Type 'IterableIterator<V>' is missing the following properties from type 'MapIterator<V>': map, filter, take, drop, and 9 more.

21     values(): IterableIterator<V>;
       ~~~~~~

node_modules/typedoc/dist/lib/utils/map.d.ts:22:5 - error TS2416: Property '[Symbol.iterator]' in type 'StableKeyMap<K, V>' is not assignable to the same property in base type 'Map<K, V>'.
  Type '() => IterableIterator<[K, V]>' is not assignable to type '() => MapIterator<[K, V]>'.
    Type 'IterableIterator<[K, V]>' is missing the following properties from type 'MapIterator<[K, V]>': map, filter, take, drop, and 9 more.

22     [Symbol.iterator](): IterableIterator<[K, V]>;
       ~~~~~~~~~~~~~~~~~

Found 4 errors in the same file, starting at: node_modules/typedoc/dist/lib/utils/map.d.ts:19

This could be linked to this change from TypeScript ?
Steps to reproduce the bug

In a new folder, run npm install -D typescript typedoc
Create an index.ts file with import * as typedoc from 'typedoc';
Run npx tsc index.ts -target esnext --moduleResolution node --allowSyntheticDefaultImports (these are the minimal options to get only the errors in map.d.ts)

Environment

Typedoc version: ^0.26.9
TypeScript version: 5.6
Node.js version: v20.18.0
OS: macOS

https://devblogs.microsoft.com/typescript/announcing-typescript-5-6/#iterator-helper-methods is the cause of this one. Unfortunately switching that return type will cause type errors for anyone using an older version of TS than 5.6, which is still new enough that I don't love making that change, at least without a 0.x release...
I recommend TypeScript's skipLibCheck option for now.

Quoting my comment from https://github.com/microsoft/TypeScript/issues/60145:

It's generally a bad idea to use implements Map in user code unless you are writing a polyfill for Map. As evidenced by the recent additions to Set (https://github.com/tc39/proposal-set-methods) and the upcoming additions to Map (https://github.com/tc39/proposal-upsert), as well as the changes to built-in iterators (https://github.com/tc39/proposal-iterator-helpers), these types can change as ECMAScript evolves.

I would recommend removing implements Map from the definition of StableKeyMap.

I hadn't even considered dropping the implements, that's obviously the right solution in hindsight.


Add CI badges

Thanks! @bors r+

:pushpin: Commit 12c90c9 has been approved by BurntSushi

:hourglass: Testing commit 12c90c9d5e6fe5602ad36b8f23feef99df6e0c5d with merge 32eb9643b45bebd2ce5169e75daed6e8579e74b2...

:sunny: Test successful - status-appveyor, status-travis
Approved by: BurntSushi
Pushing 32eb9643b45bebd2ce5169e75daed6e8579e74b2 to master...


Upgrade Bitcanna to v2.0.2 wakeandbake

Prop 12
Height 9209420
https://www.mintscan.io/bitcanna/proposals/12
Estimated Target Date:
Thu Jun 29 2023 09:15:24 GMT-0400 (Eastern Daylight Time)
This PR also fixes upgrade names, adds props and heights, and next_versions for the previous two versions.
Sources for name fix:
https://www.mintscan.io/bitcanna/proposals/11
https://www.mintscan.io/bitcanna/proposals/10

Thanks a lot @reversesigh (from BitCanna Core).
Upgrade will be performed on Thursday 29th at 15:15h UTC
https://www.mintscan.io/bitcanna/proposals/12
I hope you could hold until that date to perform the Chain Registry update @JeremyParish69 🙏

@reversesigh @JeremyParish69 Upgrade successfully passed! You can merge it peacefully


Fix volume cannot be attached when one of the replicas has error IM and the node of IM is still running

The temporary solution is: don't attempt to start replica if the corresponding default IM is error, unknown, or stopped
I think in the long run, we should consider refactor the replica's reconciliation logic in replica controller so that it correctly marked the state of the replica
longhorn/longhorn#2475

Running E2E test

Yes, failed replica will loop in reusing

The E2E core tests passes @innobead


测评很慢，测了一晚上都没出结果...

Hi, @SihengLi99 ,
That may due to a temporary run out of API quota. We will notify you once we have enough quota for the evaluation.

Hi, @SihengLi99 , the evaluation service is OK now. Besides, we have supported a mechanism to return the accuracy under exact matching when we ran out of API quota (a message will also be returned in the log).


Package Dropwizard metrics-servlets as a Bootique module

Once we start supporting HealthCheckRegistry per #2, let's add an extra optional module metrics for drag-and-drop inclusion of Dropwizard metrics-servlets. Also see https://groups.google.com/d/msg/bootique-user/BHghm2IsAC4/VCL4yiCCBAAJ
TODO: perhaps this belongs in bootique-jetty-instrumented instead? Or not ... after all people may want to include their own healtcheck/metrics dashboards.

Won't fix. We are implementing our own HealthCheckServlet per #8 .


Sign NuGet package

Please sign the package before releasing on nuget.org

Should be signed now in latest release.


MM-50282 : Create FocusTrap common component

Summary

Updates mui components
Adds mui base package for focustrap component
Creates FocusTrap wrapper component

Ticket Link
https://mattermost.atlassian.net/browse/MM-50282
Related Pull Requests
n/a
Screenshots
n/a
Release Note

Added new FocusTrap in @mattermost / component.

/update-branch

/cherry-pick cloud

Cherry pick is scheduled.

There were some CI failures in the cloud branch, this PR was cherry-picked to fix that.


[GPII-3865]: Add missing billing user role to common SA

This role is required to link projects to billing account.

LGTM


Expiry date format as MM/YY

Hi,
I want to have MM/YY , but i get only MM/YYYY below is my code
<label for="cc-exp-date">Expiry Date</label>
          <input  formControlName="cardDate" class="form-control"
                  id="cc-exp-date" type="tel" ccExp/>
<span *ngIf="!purchaseForm.get('cardDate').valid && purchaseForm.get('cardDate').touched">
      Please enter expiry date
        </span>

'cardDate': new FormControl(null, [CreditCardValidator.validateExpDate,Validators.required])

@mtina007 not sure I understand the problem - Date validator supports both MM/YY or MM/YYYY and can switch between the two formats automatically

When I used the date validator; if I put MM/YY the form will be invalid, but not for MM/YYYY.
it seems it does not switch automatically

Ended up watching for the keyup event and resetting input value from there.


[vault-webhook-eks]-Unable to mutate pod

I have install vault webhook 1.12.0 on eks and when i tried to mutate pod with the help of annotation it wo t work.
No i it container spin up.
How to solve this?

any update?

Hi @tvarade,
It's been quite sometime since you posted this issue, and sorry for the delay.
Next time when you open an issue, please provide the following details to help us address it more efficiently: a clear and concise description of the problem, step-by-step instructions on how to reproduce the issue, what you expected to happen versus what actually happened, details about the environment in which the issue occurred (such as software version, and any relevant configurations), and any screenshots or log files that might help us understand the issue better.
Since then, we've already added an issue template so it will be easier and more structured to provide these details.
I'm going to close this issue, if you need any further assistance please open another issue under the relevant project.


Use new pinned and constraints flag returned by the REST API

This allows the UI to work out which parameters need to be displayed on the app wizard, following this convention:

if a parameter if marked as pinned, it is always displayed
if a parameter has a required constraint and empty defaultValue, it is displayed

Everything is sorted by the priority
This is based on https://github.com/apache/brooklyn-server/pull/358 (to be merged first)

Needs fixing the priority=0 case, the rest is nitpicks.

@neykov Comments addressed

Thanks for the updates @tbouron, merging.


Multi line comments are deleted from empty functions

[x] I have tested with the master version of typstfmt and not just typst-lsp

Tested on commit 792f08f41d3c081bcc04675100e8a5f615567b3a
Describe the bug
Formatting a function with nothing inside it's body except a multi line comment causes the comment to be deleted. This behavior does not affect single line comments, and goes away as soon as there is anything else in the function body.
To Reproduce
Steps to reproduce the behavior:

Start with this code:

#let test_func() = {
/*
test
*/
}

Format the document
Watch as your comment disappears

#let test_func() = {}

Thanks for the report! Needs investigation ASAP ......


Switch to "forge fmt"

See Georgios' announcement.

Implemented in https://github.com/paulrberg/foundry-template/commit/6d027d098bea3d6f49d37191bd5718e4d5e1b490.


Add the support for perl runtime.

Added the core implementation to support perl
runtime for the kubeless.

Added few examples for using new perl runtime support.

Added detailed instructions/documentation in README.

Issue Ref:  936
Description:
Support for deploying perl functions is not present in Kubeless.

I submitted a pull request but one check failed. https://circleci.com/gh/kubeless/kubeless/2418?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
I don't know how my patch will be causing that failure. Can I get any help?


Install of a wheel from URL with pipenv

Hello, I am attempting to install PyTorch into an environment with pipenv.
See: http://pytorch.org/
System:

macOS
Python 3.6 (installed via Brew)
CUDA: none

pipenv --three
pipenv install numpy
pipenv install http://download.pytorch.org/whl/torch-0.2.0.post3-cp36-cp36m-macosx_10_7_x86_64.whl

Issue:
Installing http://download.pytorch.org/whl/torch-0.2.0.post3-cp36-cp36m-macosx_10_7_x86_64.whl...
Collecting torch==0.2.0.post3 from http://download.pytorch.org/whl/torch-0.2.0.post3-cp36-cp36m-macosx_10_7_x86_64.whl
  Downloading http://download.pytorch.org/whl/torch-0.2.0.post3-cp36-cp36m-macosx_10_7_x86_64.whl (5.7MB)
Collecting pyyaml (from torch==0.2.0.post3)
Requirement already satisfied: numpy in /Users/nwh/.local/share/virtualenvs/proj2-d5yuf5ok/lib/python3.6/site-packages (from torch==0.2.0.post3)
Installing collected packages: pyyaml, torch
Successfully installed pyyaml-3.12 torch-0.2.0.post3

Adding http://download.pytorch.org/whl/torch-0.2.0.post3-cp36-cp36m-macosx_10_7_x86_64.whl to Pipfile's [packages]...
Locking [dev-packages] dependencies...
Locking [packages] dependencies...
Traceback (most recent call last):
  File "/usr/local/bin/pipenv", line 11, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/pipenv/cli.py", line 936, in install
    do_lock(no_hashes=no_hashes)
  File "/usr/local/lib/python3.6/site-packages/pipenv/cli.py", line 491, in do_lock
    results = resolve_deps(deps, sources=project.sources)
  File "/usr/local/lib/python3.6/site-packages/pipenv/utils.py", line 49, in resolve_deps
    for result in r.resolve():
  File "/usr/local/lib/python3.6/site-packages/piptools/resolver.py", line 94, in resolve
    self.their_constraints))
  File "/usr/local/lib/python3.6/site-packages/piptools/resolver.py", line 131, in check_constraints
    raise UnsupportedConstraint(msg, constraint)
piptools.exceptions.UnsupportedConstraint: pip-compile does not support URLs as packages, unless they are editable. Perhaps add -e option? (constraint was: torch==0.2.0.post3 from http://download.pytorch.org/whl/torch-0.2.0.post3-cp36-cp36m-macosx-10-7-x86-64.whl)

Question: Does pipenv support wheel installs given a URL?
This alternative appears to work:
pipenv shell
pip install http://download.pytorch.org/whl/torch-0.2.0.post3-cp36-cp36m-macosx_10_7_x86_64.whl

try -e

Here's what I get:
$ pipenv install -e http://download.pytorch.org/whl/torch-0.2.0.post3-cp36-cp36m-macosx_10_7_x86_64.whl
Installing -e http://download.pytorch.org/whl/torch-0.2.0.post3-cp36-cp36m-macosx_10_7_x86_64.whl...
⠴
Error:  An error occurred while installing -e http://download.pytorch.org/whl/torch-0.2.0.post3-cp36-cp36m-macosx_10_7_x86_64.whl!
http://download.pytorch.org/whl/torch-0.2.0.post3-cp36-cp36m-macosx_10_7_x86_64.whl should either be a path to a local project or a VCS url beginning with svn+, git+, hg+, or bzr+

thank you

we do not currently support this behavior

this was just added in master!

Wasn't easy, but it works!

this is now released.

Hello, using pipenv-7.3.0, I have the following error when trying to install that package with -e
$ pipenv install -e http://download.pytorch.org/whl/torch-0.2.0.post3-cp35-cp35m-macosx_10_7_x86_64.whl
Installing -e https://download.pytorch.org/whl/torch-0.2.0.post3-cp35-cp35m-macosx_10_7_x86_64.whl…
⠇
Error:  An error occurred while installing -e https://download.pytorch.org/whl/torch-0.2.0.post3-cp35-cp35m-macosx_10_7_x86_64.whl!
https://download.pytorch.org/whl/torch-0.2.0.post3-cp35-cp35m-macosx_10_7_x86_64.whl should either be a path to a local project or a VCS url beginning with svn+, git+, hg+, or bzr+

Thanks!

I wouldn't do -e with a wheel.

$ pipenv install https://download.pytorch.org/whl/torch-0.2.0.post3-cp35-cp35m-macosx_10_7_x86_64.whl

I'm using this but sooner or later, running lock, pipenv is going to call egg_info on torch and that's going to fail. I still can't use pipenv (or pip-compile for that matter) with torch.

@remram44 2 questions:

Are you experiencing an issue currently if you pipenv install <some torch wheel>?
If pipenv were directly calling setup.py egg_info, why would it be problematic?

As a sidenote, there is a reason why we distinguish between editable and non-editable installs. Non-editable URLs are not deeply resolved, which means egg_info won't get called by running pipenv lock.  These are explicitly excluded from being passed to the resolver.

pipenv install http://... works, but then when I install a package that depends on it (from a git+https:// source), apparently python setup.py egg_info is called and fails. Why it fails I'm not sure, but it still prevents me from using pipenv.
The package I install from a URL is pytorch, from a binary wheel (http://download.pytorch.org/whl/torch-0.3.0.post4-cp36-cp36m-macosx_10_7_x86_64.whl). I'm not sure which setup.py it's trying to call btw, since the binary wheel doesn't have any.

@remram44 if you install a package that has a dependency which is unsatisfied, it will try to get it from PyPI,  For most ML packages they are then built from sdists which means calling setup.py install.  You already encountered this problem which is why you are using a wheel in the first place.
This is not a pipenv problem, it's a packaging problem in general.  If you try to install something that has a dependency you can't build, it's going to fail no matter which of the various pip-related installers you try. The simple fact is if your system requires prebuilt wheels, you will need to install those.

The dependency is satisfied, installing the wheel with pip then the other thing works just fine. This is not an sdist but a wheel. I am using a wheel because it is the only way this is distributed (no sdist on http://pytorch.org/).
I do believe there is a pipenv bug here, because I see a traceback, and it looks like pipenv tried to execute some setup.py that might not exist at all.

@remram44 whatever bug you are encountering is not related to this issue. Please open another issue and include the traceback and all other relevant information.

Are you experiencing an issue currently if you pipenv install <some torch wheel>?

I am! 🙋🏼♂ Running the install itself works with an HTTPS URL: the package and its dependencies are installed. But, the dependencies never show up in Pipenv.lock, which means that any subsequent install of the application fails.
Is this related?

@TotempaaltJ it is! We have some issues installing remote wheels. Question: when it lands in your pipfile, what does it say?

Here's the relevant line in [packages]:
"eb83410" = {file = "https://github.com/l1ndanl/flask-restplus/releases/download/v0.10.1-l1n-1/flask_restplus-0.10.1.l1n1-py2.py3-none-any.whl"}

$ pipenv install https://download.pytorch.org/whl/torch-0.2.0.post3-cp35-cp35m-macosx_10_7_x86_64.whl
try this
pipenv run pip install torch==1.4.0+cu100 torchvision==0.5.0+cu100 -f https://download.pytorch.org/whl/torch_stable.html

$ pipenv install https://download.pytorch.org/whl/torch-0.2.0.post3-cp35-cp35m-macosx_10_7_x86_64.whl

$ pipenv run pip install torch==1.4.0+cu100 torchvision==0.5.0+cu100 -f https://download.pytorch.org/whl/torch_stable.html


az apim api import: api-id and name are confusing

Is your feature request related to a problem? Please describe.

-> Yes
Target command
az apim api import
docs: https://docs.microsoft.com/en-us/cli/azure/apim/api?view=azure-cli-latest#az_apim_api_import
Problem Overview
One apim resource property has two names; api-id and name.
Here's the example:
# What I did
$ az apim api import
    --api-id MyTestAPI \ # <- here I specify api-id as "MyTestAPI"
    --specification-path ./MyTestAPI.yaml \
    --subscription ${my-subscription-name} \
    --service-name ${apim-service-name} \
    --resource-group ${my-resource-group} \
    --specification-format OpenApi \
    --path my-test-api

# What I get (Generated API information)
Command group 'apim api' is in preview. It may be changed/removed in a future release.
{
  ...
  "name": "MyTestAPI", # <- The value I specified as `api-id` is recognized as `name` in backend.
  "path": "my-test-api",
  ...
}

Describe the solution you'd like

To improve the clarity of the behavior of the API, I prefer property name api-id and name become same name.

apim

sorry, we can't make api-id and name the same name, api-id is the resource ID, name is the Resource name, they are used in different scenarios in the backend

Really, from the documentation is is not clear what is what. Please describe this more elaborate in the documentation


Update shareLinkCreator

add check whether username but no password set and then only ask for password (this is my first github interaction ever, please forgive any terrible mistakes ;))

@aslmx thanks for your contribution. I just merged some older pull requests. Can you please rebase it? Thanks!

i hope i did the rebase right, not sure if i understood everything correctly ;-) will pull request again


Userstore Management feature in Console Application needs integration tests.

Is your feature request related to a problem? Please describe.
Userstore management feature in Console application does not have any integration tests.
Describe the solution you would prefer
Implement the tests for the necessary integration scenarios.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Fix delay in displaying TF frames

This fixes ros2/ros1_bridge#133 . Displayed tf data was delayed because rviz wasn't able to call callbacks fast enough to service the transform listener subscription. This resulted in tf2 always having out of date transforms (see ros2/geometry2#71), and gave the mistaken impression that rviz2 was receiving data slower than rviz over the bridge.
To fix this executors now have a parameter max_duration on spin_some(). This prevents spin_some() from blocking the gui update while allowing callbacks to be executed faster than the gui updates.
rviz left, rviz2 right
Before this PR

With this PR

To reproduce the gifs see https://github.com/ros2/ros1_bridge/issues/133#issuecomment-421444534

CI for this plus ros2/rclcpp#558 and ros2/system_tests#299

Linux
Linux-aarch64
macOS
Windows

Wow, nice!

I continue to have the same issue even using the last patched version.
You can replicate it running the dummy robot example:
Run the example:
$ ros2 launch dummy_robot_bringup dummy_robot_bringup.launch.py
Open $ rviz2
Set the fixed frame to world
Add a TF plugin viewer. You will see the robot link moving
Add a LaserScan plugin and subscribe to /scan
At this point you will see the simulated laser scan on the oscillating link of the robot and you will notice how it is rendered in late respect to its reference frame.
Furthermore you will notice a lot of errors
Could not transform from [single_rrbot_hokuyo_link] to [world] in the LaserScan plugin
and
[ERROR] [rviz2]: Lookup would require extrapolation into the future. Requested time<PHONE_NUMBER>.01342 but the latest data is at time<PHONE_NUMBER>.98954, when looking up transform from frame [single_rrbot_hokuyo_link] to frame [world]
in the console where RVIZ2 has been executed
image

@Myzhar would you mind making your comment a new issue on this repo? Once a pull request is merged it no longer appears on our waffle board, so comments on merged PRs tend to be forgotten.

@sloretz sure :+1:


ine

Sorry, somehow I've accidentally created this issue and can't find a way to undo it?

Don't worry about it. :)


Implement inteface communication in MP

Implementing interface calls in all phases.
** will need to change base to main once refactor PR is merged. Currently showing differences between refactor PR so only changed files are shown.

I'll be back around 9pm to address the lint and write down the comments for a later PR. Then I will ask for reapproval and merge


[SWARM-1951] Making the use of roles properties file optional

@Ladicek Is this the thing you wanted in ENTSWM too?

There's an ENTSWM for this, yes.

test this please

@Ladicek Approved?

@heiko-braun Sort of, but I'd really like if we could get @starksm64 to review all our MP JWT JIRAs and approve on our intended course of action.

I'll take a look at this today.

The implementation looks fine to me and I'd just like an approval on the entire idea :-)

@starksm64 Do you need more time for the review or are we good to go?

Hi All, I can try to add a test confirming that both not referencing the properties file or making it empty works as long as the JWT groups property contains the expected roles, once #890 goes in :-)
IMHO, letting the users drop the properties from the SWARM config is completely safe from the spec compliance point of view, it is all about making it easier for the users when possible, as Ladislav noticed...

I agree with @sberyozkin. I'm just extra-cautious, because security :-)


Steven

Description
Work from @fearlesssteven
Additional information

Not ready to merge - I'll review this, thanks @fearlesssteven
Relates to #202 & #121

Definition of Done

[ ] Acceptance testing (for code changes - TBD)
[ ] Draft reviewed by other Content Designer
[ ] Update to Updates page
[ ] PR approved by Libby
[ ] Related GitHub issues closed

https://github.com/govau/content-guide/issues/23