HBASE-28811 Use region server configuration for evicting the cache wh…

…ile unassigning a region

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  3s

master passed

+1 :green_heart:
compile
3m  0s

master passed

+1 :green_heart:
checkstyle
0m 38s

master passed

+1 :green_heart:
spotbugs
1m 37s

master passed

+1 :green_heart:
spotless
0m 46s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 53s

the patch passed

+1 :green_heart:
compile
3m  2s

the patch passed

+1 :green_heart:
javac
3m  2s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 36s
/results-checkstyle-hbase-server.txt
hbase-server: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

+1 :green_heart:
spotbugs
1m 39s

the patch passed

+1 :green_heart:
hadoopcheck
10m 36s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

-1 :x:
spotless
0m 38s

patch has 63 errors when running spotless:check, run spotless:apply to fix.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 55s

the patch passed

+1 :green_heart:
compile
0m 58s

the patch passed

+1 :green_heart:
javac
0m 58s

the patch passed

+1 :green_heart:
javadoc
0m 29s

the patch passed

+1 :green_heart:
shadedjars
5m 19s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
226m 23s

hbase-server in the patch passed.

251m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6197

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 0c330eb4e6ca 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c28816109e975b5140ec700249529ad245774648

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/1/testReport/

Max. process+thread count
5956 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 32s

master passed

+1 :green_heart:
compile
4m  1s

master passed

+1 :green_heart:
checkstyle
0m 45s

master passed

+1 :green_heart:
spotbugs
1m 51s

master passed

+1 :green_heart:
spotless
0m 49s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 37s

the patch passed

+1 :green_heart:
compile
3m 57s

the patch passed

+1 :green_heart:
javac
3m 57s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 47s

the patch passed

+1 :green_heart:
spotbugs
1m 58s

the patch passed

+1 :green_heart:
hadoopcheck
11m 41s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 45s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 10s

The patch does not generate ASF License warnings.

42m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6197

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux e3bcc601def3 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 016ed6562e9b313d94ac15c984a01cf535227394

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/2/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 25s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 15s

master passed

+1 :green_heart:
compile
3m  6s

master passed

+1 :green_heart:
checkstyle
0m 35s

master passed

+1 :green_heart:
spotbugs
1m 35s

master passed

+1 :green_heart:
spotless
0m 46s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  2s

the patch passed

+1 :green_heart:
compile
3m  6s

the patch passed

+1 :green_heart:
javac
3m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 36s

the patch passed

+1 :green_heart:
spotbugs
1m 40s

the patch passed

+1 :green_heart:
hadoopcheck
11m 43s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 43s

patch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 59s

the patch passed

+1 :green_heart:
compile
1m  0s

the patch passed

+1 :green_heart:
javac
1m  0s

the patch passed

+1 :green_heart:
javadoc
0m 31s

the patch passed

+1 :green_heart:
shadedjars
5m 23s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
231m 10s

hbase-server in the patch passed.

256m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6197

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux fa5d4ce7a853 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 578ca4da02e09b5c21d2d2b6a9235b1f99c8589f

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/3/testReport/

Max. process+thread count
4906 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Can we add UT for the changed behaviour? Something similar to TestSplitWithCache, but start with a given value for evictOnClose, change it for RSes only, trigger a region close, check the cache:

Set evictOnClose to false:
UTIL.getConfiguration().setBoolean(EVICT_BLOCKS_ON_CLOSE_KEY, false);
Start cluster:
UTIL.startMiniCluster(1);
Change the config for the RS only:
UTIL.getMiniHBaseCluster().getRegionServer(0).getConfiguration().setBoolean(EVICT_BLOCKS_ON_CLOSE_KEY, true);
Disable table:
UTIL.getAdmin().disableTable();
Check blocks got evicted:

Added the unit test TestUseRSCacheConfigWhileClosingRegion.java

The UT seems correct, but let's refrain from duplicating code whenever possible. Please move these new tests to TestSplitWithCache, and reuse as much of the code from there.

Refactored the unit test and renamed TestSplitWithCache to TestCacheEviction. The new test can be used to test other eviction scenarios in the future.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 52s

master passed

+1 :green_heart:
compile
3m  0s

master passed

+1 :green_heart:
checkstyle
0m 39s

master passed

+1 :green_heart:
spotbugs
1m 34s

master passed

+1 :green_heart:
spotless
0m 46s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

-1 :x:
mvninstall
1m 42s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
compile
1m 41s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

-0 :warning:
javac
1m 41s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 35s

the patch passed

-1 :x:
spotbugs
0m 49s
/patch-spotbugs-hbase-server.txt
hbase-server in the patch failed.

-1 :x:
hadoopcheck
2m  1s

The patch causes 16 errors with Hadoop v3.3.6.

-1 :x:
hadoopcheck
4m  3s

The patch causes 16 errors with Hadoop v3.4.0.

+1 :green_heart:
spotless
0m 42s

patch has no errors when running spotless:check.

_ Patch Compile Tests _

-1 :x:
mvninstall
2m 11s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
compile
1m 10s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

-0 :warning:
javac
1m 10s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

+1 :green_heart:
javadoc
0m 34s

the patch passed

-1 :x:
shadedjars
5m 20s

patch has 16 errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
1m 19s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

24m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6197

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux adde2e4b6722 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 87759d04208ab98e649607fb81008775e2653f7f

Default Java
Eclipse Adoptium-17.0.11+9

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/testReport/

Max. process+thread count
83 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  0s

master passed

+1 :green_heart:
compile
2m 58s

master passed

+1 :green_heart:
checkstyle
0m 38s

master passed

+1 :green_heart:
spotbugs
1m 34s

master passed

+1 :green_heart:
spotless
0m 44s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 53s

the patch passed

+1 :green_heart:
compile
2m 58s

the patch passed

+1 :green_heart:
javac
2m 58s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 38s

the patch passed

+1 :green_heart:
spotbugs
1m 41s

the patch passed

+1 :green_heart:
hadoopcheck
10m 21s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 44s

patch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 56s

the patch passed

+1 :green_heart:
compile
1m  0s

the patch passed

+1 :green_heart:
javac
1m  0s

the patch passed

+1 :green_heart:
javadoc
0m 28s

the patch passed

+1 :green_heart:
shadedjars
5m 15s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
236m 11s

hbase-server in the patch passed.

260m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6197

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 9ffbb5282671 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8955e45f1b290ac2970380f7054a1415634cf2eb

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/5/testReport/

Max. process+thread count
5388 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/5/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


download_blob does not work when dockerized (urllib3.connection.HTTPSConnection Errno -2)

Package Name: azure.storage.blob
Package Version: 12.4.0
Operating System: Alpine Linux
Python Version: 3.8

Describe the bug
Running the command download_stream = blobClient.download_blob() does not work when the application is dockerized (works fine when debugging from VS Code).
The raised error is
azure.core.exceptions.ServiceRequestError: <urllib3.connection.HTTPSConnection object at 0x7f8c179660d0>: Failed to establish a new connection: [Errno -2] Name or service not known

Looking at the logs I spotted a difference between the 2 environments: the azure library is logging some info, and one of those is the request URL. When the application is dockerized, the url is (1), while (2) when debugging from VS Code (note that there is an extra " in (1))

Request URL: 'https://datalake.blob.core.windows.net"/giorgio/projectgiorgio/web_upload/natural_language_processing%20%281%29%20%281%29%20%281%29.pdf/4'
Request URL: 'https://datalake.blob.core.windows.net/giorgio/projectgiorgio/web_upload/natural_language_processing (1) (1) (1).pdf/4'

Here is the log produced during the error
To Reproduce
Run the following Python code

import os
from azure.storage.blob import BlobServiceClient

container_name = "container_name"
blob_name = "blob_name"
blobServiceClient = BlobServiceClient.from_connection_string(os.getenv('STORAGE_CONNECTION_STRING'))
blobClient = blobServiceClient.get_blob_client(
    container_name,
    blob_name,
    snapshot=None
)
download_stream = blobClient.download_blob() # <- error thrown here
content = download_stream.readall()

inside a docker container using the image tiangolo/uvicorn-gunicorn:python3.8
Expected behavior
The file is downloaded correctly

Hi @zorzigio,
That's a very interesting issue that you came across. I'll have a look and will update you.
Thank you :)

Hi @tasherif-msft,
Thank you for looking into it. Do you have any update on the issue?
I realised I am now having the same problem in another repository as well which uses the image python:3.9.0b3-alpine3.12

Hey @zorzigio, I've tried reproducing the issue with no luck unfortunately :disappointed:
Would you be able to provide me with the Dockerfile you used?
Thank you.

@zorzigio any updates?

I am facing the exact same issue!

I am facing the exact same issue!

Did anyone find a solution to this issue?

I was able to run download_blob_from_url() from azure.storage.blob package in Docker container by installing ca-certificates. I added the below line in my Dockerfile
RUN apt-get -y --no-install-recommends install ca-certificates
Its successfully running now.

I have identical occurring: an additional " in the request URL when running inside a docker container.
Adding RUN apt-get -y --no-install-recommends install ca-certificates in my Dockerfile and rebuilding made no difference.
Any solutions found recently?

Hello, I was also getting same error but after adding certificate, I am now getting following error:
WARNING Unable to upload: Retry: 0 FileName: abc.zip Exception: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:997)
In Dockerfile, I added certificate like this:
RUN apt-get update && apt-get -y install ca-certificates
ADD our.cer /usr/local/share/ca-certificates/our.crt
RUN chmod 644 /usr/local/share/ca-certificates/our.crt && update-ca-certificates

Our connection string is like this:
DefaultEndpointsProtocol=https;AccountName=our-account;AccountKey=our-secret;EndpointSuffix=core.windows.net
Any idea how to resolve this?

Update:
I was able to make it working after adding "connection_verify=False" parameter to the end of  BlobServiceClient.from_connection_string() and blob_client.upload_blob() methods!


Binding TextBox to String Property with null value does not clear the TextBox

When binding a TextBox to String property,
<TextBox Text="{Binding Text}"/>
public class ViewModel { public string Text{ get; set; } } (inlcuding INotifyPropertyChanged)
when setting the Text to 'null', the TextBox is not cleared
viewModel.Text = null;
Only when setting to String.Empty, then the TextBox clears

@grokys: I think this can be closed. I've tried to reproduce this in Avalonia 0.9.3 and the Textbox text gets cleared as expected:

Thanks @Symbai !


Android crashes after 'java.io.FileNotFoundException'

We have customers on Android 13 experiencing a fatal crash due to what seems like an internal error in the SDK.
SDK version: 2.0.1
Environment: Production
Are logs available?
Not currently

Describe the bug
Error in the dependency causes a fatal error crashing our application. We haven't identified the circumstances under which this happens. It concerns clients on Android 13 but doesn't happen every time.
File
---/io.customer/7ed642e4fb8cad095e58/queue/tasks/fe24ce7d-c198-41dc-9898-9a17633058b7.json: open failed: ENOENT (No such file or directory)
Exception java.io.FileNotFoundException:
  at libcore.io.IoBridge.open (IoBridge.java:574)
  at java.io.FileInputStream.<init> (FileInputStream.java:160)
  at kotlin.io.FilesKt__FileReadWriteKt.readText (FileReadWrite.kt:125)
  at kotlin.io.FilesKt__FileReadWriteKt.readText$default (FileReadWrite.kt:125)
  at io.customer.sdk.data.store.FileStorage.get (FileStorage.kt:62)
  at io.customer.sdk.queue.QueueStorageImpl.get (QueueStorage.kt:103)
  at io.customer.sdk.queue.QueueRunRequestImpl.runTasks (QueueRunRequest.kt:37)
  at io.customer.sdk.queue.QueueRunRequestImpl.goToNextTask (QueueRunRequest.kt:84)
  at io.customer.sdk.queue.QueueRunRequestImpl.runTasks (QueueRunRequest.kt:57)
  at io.customer.sdk.queue.QueueRunRequestImpl.access$runTasks (QueueRunRequest.kt:12)
  at io.customer.sdk.queue.QueueRunRequestImpl$runTasks$1.invokeSuspend
  at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (ContinuationImpl.kt:33)
  at kotlinx.coroutines.DispatchedTask.run (DispatchedTask.kt:106)
  at kotlinx.coroutines.internal.LimitedDispatcher.run (LimitedDispatcher.kt:42)
  at kotlinx.coroutines.scheduling.TaskImpl.run (Tasks.kt:95)
  at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely (CoroutineScheduler.kt:570)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask (CoroutineScheduler.kt:749)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker (CoroutineScheduler.kt:677)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run (CoroutineScheduler.kt:664)
Caused by android.system.ErrnoException: open failed: ENOENT (No such file or directory)
  at libcore.io.Linux.open
  at libcore.io.ForwardingOs.open (ForwardingOs.java:563)
  at libcore.io.BlockGuardOs.open (BlockGuardOs.java:274)
  at libcore.io.ForwardingOs.open (ForwardingOs.java:563)
  at android.app.ActivityThread$AndroidOs.open (ActivityThread.java:8619)
  at libcore.io.IoBridge.open (IoBridge.java:560)

To Reproduce
We haven't been able to reproduce the bug
Expected behavior
Additional context

Happens both foreground and background. Doesn't seem to affect IOS users.

Hey @nnevalainen, thank you for reporting this. We will be looking into this.

@Shahroz16 hey there, any progress on this? what information can we provide to make the resolution faster?
seems to be specific to Android x Samsung Galaxy (multiple versions) from our crash reports.
It is quite hard to prevent this in our code, and causes a straight crash of the whole app.

Hey @Zajozor and @nnevalainen the fix is out. Please make sure you clean the build and refresh the dependencies so that you have the latest version.
React native is using the Android native SDK underneath.

ty @Shahroz16 appreciated!
the part with

NOTE: This method doesn't fix the root cause for files being not found. We're not yet able to reproduce this, but the code change helps preventing customer apps from crashing

does not sound very promising though tbh 😅

@Zajozor this is a very edge case, where file isn't found. That is yet to be figured out but it's in our pipeline rest assured 😊. But the fix make sure that app doesn't crash till then.

All clear, thanks for the elaboration, much appreciated 🙏🏻


Error displayed on Apple computer

Apple M1 Pro

on Macbook  display is jagged and there is shaking
correct on Windwos:

incorrect on Mac:

code:
 viewer.entities.add({
                polygon: {
                    hierarchy: new Cesium.PolygonHierarchy(
                        Cesium.Cartesian3.fromDegreesArray(feature.geometry.coordinates[0].flatMap(m => m))
                    ),
                    outline: false,
                    fill: true,
                    material: Cesium.Color.fromCssColorString("#839bc1"),
                }
            });

Thanks for the report @q2434006. I believe this is a manifestation of precision issues we've been seeing on M1 and M2 Macs.
I'm going to close this issue in favor of https://github.com/CesiumGS/cesium/issues/9417 to keep discussion in one place, and I will note your report there.


Match on header

Currently, we only support matching on path, query (and domain / Host header via domains). There are usecases which would benefit from header matching.

This is dependent on multi-dimensional collision detection as described here: https://github.com/SVT/orm/issues/12

We probably want to consider how domains works when implementing header matching (because domains actually does header matching but specifically for the field host)

My general idea is to

[ ] Update schema to support header matching (and deprecate domain?)
[ ] Update schema to support specifying headers for ORM tests
[ ] Deployment tests
[ ] Implement changes in parser, validator, and varnish render
[ ] Support setting headers in runtests.py
[ ] Collision check header matches in validator
[ ] Unit tests
[ ] Update docs

Just a note to self. We need to make domains optional if we want to have sane support for matching on host headers with the new header matching.

Will this provide functionality to route to precompressed files depending on
"accept-encoding: gzip, deflate, br" header?

It will be possible to match headers with the following syntax:
header:
  field: accept-encoding
  exact: "gzip, deflate, br"

It will also be possible to use regex, begins_with, etc instead of exact, like other matching methods.


[WIP] Tests/aea configurations

Proposed changes
Working towards full coverage of aea/configurations
----------------------------------------------------------------
aea/configurations/__init__.py         1      0   100%
aea/configurations/base.py           666      0   100%
aea/configurations/constants.py       77      0   100%
aea/configurations/data_types.py     344      0   100%
aea/configurations/loader.py         166     18    89%   323-334, 352-355, 504-509
aea/configurations/manager.py        209      0   100%
aea/configurations/pypi.py            94      0   100%
aea/configurations/utils.py           61      0   100%
aea/configurations/validation.py     156      0   100%
----------------------------------------------------------------
TOTAL                               1774     18    99%

We will need to move autonomy/configurations/schemas/service_schema.json to open-aea and create a dummy service.yaml file to attain full coverage of this module
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply.

[ ] I have read the CONTRIBUTING doc
[ ] I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
[ ] Lint and unit tests pass locally with my changes and CI passes too
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that code coverage does not decrease.
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

We will need to move autonomy/configurations/schemas/service_schema.json to open-aea and create a dummy service.yaml file to attain full coverage of this module

Just create a dummy file. Service is just a dummy here, no assumption should be made that it matches the definition in open autonomy.


ReSwift crashes on device (but not simulator)

Help!  I have been chugging along using ReSwift (on 3.0, Swift3, XCode 8.3) and now for some reason upon initialization ReSwift is crashing (when I run it on my 10.3.1/iPhone7+ thru XCode). I hate these esoteric errors and am hoping beyond hope that someone has experienced anything remotely similar.
AppDelegate has the usual declaration
let store = Store<State>(reducer: AppReducer(), state: nil)

Then my first ViewController subscribes:
override func viewWillAppear(_ animated: Bool) {
        super.viewWillAppear(animated)

        store.subscribe(self) { state in
            state.authenticationState
        }
 }

ReSwift goes through the initialization process until it gets to my AppReducer, and BAM !

Thanks everyone,
--Bill

I am noticing this device crash happens in Debug, but not Release. Are there optimizations or other build/compiler settings that would cause problems with ReSwift?

Well for posterity -- I am further noticing that in Debug with No Optimization I crash. Flipped the Swift/LLVM optimization levels to -O and no crash.

I'm also seeing this. I think it's related to this compiler bug:
https://bugs.swift.org/browse/SR-4432
Seems to happen when assigning or passing big structs as arguments. This is a big problem for ReSwift based applications, because with this architecture it's unavoidable having a big state. We have this issue in one of our apps (but not on others). This app is the biggest where we have used this architecture, so probably that's why we are hitting it.
Please reopen this issue. I think it's important that people that use ReSwift are aware of this problem. For now the bug is still open in Apple's Jira; let's hope it gets fixed for Swift 4 release.

Reopened.
Also still an issue for me on the latest stable tooling (Swift 3.1, XCode 8.3.3).
Note @buscarini that my initial AuthenticationState struct is small, it does have a few simple child structs. Nesting is not deeper than that though.

I thought that optimization wasn't fixing it for us, but it turned out that we didn't have optimization enabled. So this is not that terrible, but it's still bad if you need to debug something on the device.
Also, good news: the bug has been resolved (though it probably won't be available until Xcode 9 is officialy released)

@buscarini @snydersaurus Did it go away with Xcode 9?

It's been working for me lately, but I'm not using it as heavily as before. Maybe it's solved, maybe it's just that I'm not hitting the issue.

Strange...

Issue still there with xcode 10.1

DispatchQueue.main.async {}

Can you please elaborate, where exactly you used it.
We are facing problem with bigger and nested struct even in xcode 10.1 when isung device.

I am only working on macOS apps, and I wonder if that has anything to do with it, since my large-ish app states memory-wise (up to multiple 100 MB) don't cause any problems so far.
@gkmrakesh Can you try to isolate the problem e.g. by removing Middleware from the store?

@DivineDominion,
I am trying for almost 6 days on this. I have also tried removing middleware. nothing working in my case and app still crashing.
When I change my appstate from struct to class everything works fine.

@DivineDominion ,
I am also encountered on this issue for 5 days, and have no clue :(
My app crashed immediately during ReSwift init.
Crashed on device iOS 10.3.3, and seems working fine on simulator & devices with newer iOS.
My appState have 11 substates. It already stable during 5 months of development, however the problem starting appears 5 days ago.

Can you check if you do any store.state access in your middleware/reducers ? That what was triggering the problem for me at some point, as you should not do it anyway.
Also, passing big struct around have been fixed some release of Swift ago. I have an appState with 20+ substates (and very very heavy) in production with no issue at all.

We are not doing store.state access in reducer/middleware.
We have appState with 80+ substates and considerably big. Working as expected till xcode 9+ versions, along with 800 plus test cases running.
Now, All of sudden it stopped working with xcode 10. We are in a very bad situation to go to production with class as appState.

There are no store.state access in middlewares/reducers.
working fine until many new attributes added to substates.

@gkmrakesh, do you convert all states to class? Or only in single root appState?

Converted single root appState, and everything works fine.

Now that it's a class, can you interact with the app up to the point where it previously crashed, then run the Xcode memory debugger and see who has a reference to the AppState object? Memory debugger sadly doesn't show struct instances, but it does show class objects. Maybe you can find a weird reference this way.

I've just changed to class.
However the app still crashed with exc_bad_access in a view controller when trying to access substate properties.

@ngeplurk @gkmrakesh Do you work on the same project? Send me an email so we can schedule a 30min or so Skype call some day. Maybe I have an idea when I see how you really use the framework.

@DivineDominion,
I work for a different project. I have sent you a mail, please propose time so that we can have a skype call.
@ngeplurk
You can also join this call to know more.

@DivineDominion , no, it's a different project.
Basically, in my side, the problem seems occurs in old device iOS 10.3.3 only.
Is it related with 32 bit platform? Do you think there are Swift compiler bug in Xcode 10.1?

Hi Guys, finally I have a clue related with this issue.
The problem occurs after memory corrupted in 32 bit devices when the struct size (substate struct size) is > ~2100 bytes.
I've split my substates into smaller structs, so each structs byte size in main reducer < 2000 bytes.
i.e inspecting using this command in main reducer.
po MemoryLayout.size(ofValue: initialSubState)

So far with this approach, the app working fine.

I'm experiencing the same issue, EXC_BAD_ACCES, first line of the appReducer. Only happens on device in debug and works fine in simulator.
Xcode 10.2.1
ReSwift 4.1.1
iOS 12.3.1
iPhone 6
Swift 4.2
No debug optimization set for Clang or Swift code generation. Tried changing these to -O and did not make any difference.
Roughly 36 substates. If I remove a few substates then the problem goes away.

I was able to work around the issue by putting a guard in for the state, but it makes absolutely no sense to me.
guard let state = state else {
    return AppState(
        userState: userReducer(action: action, state: nil),
        profileState: profileReducer(action: action, state: nil),
        ...
    )
}

return AppState(
    userState: userReducer(action: action, state: state.userState),
    profileState: profileReducer(action: action, state: state.profileState),
    ...
)

I did not have the guard before and simply used the optional (ex: state?.userState). Again, no idea why this works. When ReSwift initializes the state is nil, which should just pass nil into the reducer.
If anyone can help me figure this out it would be greatly appreciated.

This is a mystery to me. Please make sure to file a radar / send a Feedback ticket to Apple. This might all be a weird Swift memory thing in the end.
36 parallel substates, or are there 36 levels of object nesting?

On 4. Jul 2019, at 21:28, Brian<EMAIL_ADDRESS>wrote:
I'm experiencing the same issue, EXC_BAD_ACCES, first line of the appReducer. Only happens on device in debug and works fine in simulator.
Xcode 10.2.1
ReSwift 4.1.1
iOS 12.3.1
iPhone 6
Swift 4.2
No debug optimization set for Clang or Swift code generation. Tried changing these to -O and did not make any difference.
Roughly 36 substates. If I remove a few substates then the problem goes away.
I was able to work around the issue by putting a guard in for the state, but it makes absolutely no sense to me.
guard let state = state else {
return AppState(
userState: userReducer(action: action, state: nil),
profileState: profileReducer(action: action, state: nil),
...
)
}
return AppState(
userState: userReducer(action: action, state: state.userState),
profileState: profileReducer(action: action, state: state.profileState),
...
)
I did not have the guard before and simply used the optional (ex: state?.userState). Again, no idea why this works. When ReSwift initializes the state is nil, which should just pass nil into the reducer.
If anyone can help me figure this out it would be greatly appreciated.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Yes most of my models in the state have object nesting. I am using ObjectMapper for my models. Someone in a similar issue had an issue with EXC_BAD_ACCESS and was using ObjectMapper. Not sure if that has any relevance or not.
An example of nesting in state would be a User.
User -> Address -> StateProvince

Gotcha, but is your deepest level of nesting 36?
Foo -> Bar -> 3 -> 4 -> .. -> 36 ?

If so, that and ObjectMapper might be a trail to follow.

I have some deep nesting, but not 36, unless you count some one-to-many relationships that I use in my models.
Ex:
Event -> [Category]
Category -> Event
Can't see why this would be an issue, since when ReSwift inits the state is nil, so every model in my state will be nil as well.

I have created a project with 50 substates that replicates the issue on my device.
https://github.com/brianmclachlin/exc-bad-access

That's cool, thank you a lot! Did you send this to Apple already? We should be duping the report once you have!

Nope, I haven't posted in the swift bug JIRA yet. I wanted to make sure it wasn't a bug with ReSwift before submitting a bug report.
Store.swift
public var state: State!

public required init(
    reducer: @escaping Reducer<State>,
    state: State?,
    middleware: [Middleware<State>] = [],
    automaticallySkipsRepeats: Bool = true
) {
    ...

    if let state = state {
        self.state = state
    } else {
        dispatch(ReSwiftInit()) // This is called when it inits because I'm not providing state
    }
}

open func _defaultDispatch(action: Action) {
   ...

    isDispatching = true
    let newState = reducer(action, state) // state is nil with less substates, but EXC_BAD_ACCESS with lots of substates
    isDispatching = false

    state = newState
}

It makes sense to me that we get an EXC_BAD_ACCESS since state is not an optional and it is never initialized in the init. I'm more confused why it doesn't break with less substates. Why can public var state: State! ever be nil?

Nope, I haven't posted in the swift bug JIRA yet. I wanted to make sure it wasn't a bug with ReSwift before submitting a bug report.
Store.swift
public var state: State!

public required init(
    reducer: @escaping Reducer<State>,
    state: State?,
    middleware: [Middleware<State>] = [],
    automaticallySkipsRepeats: Bool = true
) {
    ...

    if let state = state {
        self.state = state
    } else {
        dispatch(ReSwiftInit()) // This is called when it inits because I'm not providing state
    }
}

open func _defaultDispatch(action: Action) {
   ...

    isDispatching = true
    let newState = reducer(action, state) // state is nil with less substates, but EXC_BAD_ACCESS with lots of substates
    isDispatching = false

    state = newState
}

Tried replicating this without ReSwift and could not get the error. Wonder if it has something to do with generics or the dispatch function.

I've created a bug in the swift JIRA. https://bugs.swift.org/browse/SR-11093

They've commented on the issue saying that they've had problems with large structs, but they're fixed in swift 5.0. If you update to 5.0 I will see if I can still replicate the issue.

@brianmclachlin Thanks for bringing up the project isn't set to Swift 5! I opened #414 for this. Check out the master branch once it's merged!

I'm not sure I understand. ReSwift is already written with Swift 5.0 compatibility, and the example project linked uses Swift 5.0.
The version in ReSwift's pbxproj is irrelevant to a Cocoapods installation. You can confirm this by inspecting the Pods project in the example, and check swift language version on the ReSwift target.
It looks like they're saying they thought it was resolved with Swift 5.0 but that this appears to be a new issue.

Thanks for clearing this up @mjarvis, it was a misunderstanding on my part.

Erik left a comment on the swift ticket:

The crash is a stack overflow.
The AppState struct is 40KB large. That is not good, but would not cause a stack overflow by its own. But in the appReducer function, the compiler has to allocate a lot of such large temporary objects on the function stack frame for this large constructor call. This just exceeds the maximum available stack space.

Is it possible that you rewrite your code, e.g. use classes or copy-on-write data structures (implemented with classes) instead of plain structs?

So if I understand correctly each time we do state?.oneState, state?.twoState etc. and state is nil this creates a temporary object. This makes sense why we only notice it when it initializes and the state is nil. Also, why when I put a guard to unwrap the state it no longer produced the issue.
Also makes sense that other people were not noticing the issue when they converted their AppState to a class.

What should be the approach to deal with this in ReSwift? I'm currently using a guard, so that the appReducer does not create a ton of temporary AppState objects. However, every time I create a new substate I have to add it in two spots.
guard let state = state else {
    return AppState(
        userState: userReducer(action: action, state: nil),
        profileState: profileReducer(action: action, state: nil),
        ...
    )
}

return AppState(
    userState: userReducer(action: action, state: state.userState),
    profileState: profileReducer(action: action, state: state.profileState),
    ...
)

I can deal with this for now, but I think the documentation should be updated with an approach that is less gross. Instead of a struct could the AppState be a dictionary, so we gain that copy-on-write benefit?

I wonder if it would help if you had a non-nil initial state. Like var state = state ?? AppState.initial and then call all reducers on that. But that only makes sense if it is, indeed, non-nil, right?

Closed due to inactivity/no up-to-date info


Refactor code.

Coverage remained the same at 100.0% when pulling 82ca15de97c9ad55cd2da803a00439f363569ec5 on refactor-code into 8ba9198455e7d49eefb0efc49ada011b09e7b707 on master.


chalk.stripColor is undocumented

I think it should be 😉

Intentional. We intend to remove it in the next major release. It's not used by Chalk itself, so better that people just use the module directly.


Can't setup min-size attribute

Hello! I'am trying to setup min-size for logging level, using this format:
{{level}:|min-size=8}: {message}
But, I got this:
INFO:|min-size=8: Started @4678ms
I took this format from docs (scroll to second example in the section): https://tinylog.org/v2/configuration/#format-pattern

Amazing! You're awesome!


Fix removeLastPoint when removing last point

This pull request fixes an issue with the Draw interaction's removeLastPoint method. Previously, when no vertex of a polygon or linestring was left to undo, it took two more calls of removeLastPoint() to abort the drawing. Now it only takes one more, which I think is the expected behavior.
This issue can be seen in the draw-features.html example, when drawing a polygon or linestring and repeatedly clicking undo to get rid of the entire geometry.

I see now why the removeLastPoint() function behaved like it did: to make it work with the appendCoordinates() method like in the tracing.html example. To not break any tests, I had to improve the appendCoordinates() method to also work when no drawing is active.
This is now ready for review.

Working on that fix revealed several issues with the appendCoordinates() method, which I also fixed now. That can be seen in the tracing.html example: On a touch device, the trace is now immediately visible. [Previously](https://openlayers.org/en/latest/examples/tracing.html] it was only visible after another click.

Thanks for the review @jahow. I was able to fix the sketch position problem you noticed post-review.


feat(explorer): asset details

Related issues 🔗
Closes #2535
Description ℹ

removed default JSON views from /assets
added a table that consists of all available assets with View details and View JSON buttons
removed redundant queries

Demo 📺
https://user-images.githubusercontent.com/1980305/217580514-4e7ec76f-59ac-4b22-b69c-32cc100ee703.mov

nitpick (non-blocking): Not a failing of this PR, but while using it I noticed two views that probably should have asset links that don't currently:

The Order Submit Details card doesn't link to the asset modal
The Order Submit table-at-the-top thing doesn't list the asset either.
Node Vote > Internal Asset Deposit does not list the asset id


perf: Use spread notation in ring transfer definitions

Make sure that Function.Injective.somethingRing looks like
def ...
This should hopefully give a performance boost in applications.
Incidentally, there were a few missing transfer definitions, so I added them as I needed them.

[ ] depends on: #9938

I mean here

!bench

Seems to be slightly better overall, but nothing crazy.

What happens if you also change the instances in RingTheory.Subring.Basic?

What do you mean exactly? There's no such instances in RingTheory.Subring.Basic. There's a few uses of transfer instances for ordered rings, so I changed those as well, but I'm not sure that's what you meant.

!bench

I think that was a good interpretation. What I had in mind is probably out of scope here. It looks like #8386 will get in later today so let's wait until we can bench against that also. As both PRs have slowdowns around instances subX's, just want to be safe. (Who knows they might cancel each other out.)
In the meantime, are there any other transfer lemmas hiding in the repo?

!bench

Let's just do it all together here.
bors merge

For the record, yes there's plenty more: Field, Module, Lattice...

Do you want to pull those in or just merge?

I will do them when I have time, which will be in about a week, so let's just merge now.

bors merge

bors r-

bors d+

@mattrobball, do you understand what's going on here?

Yes

Ok, found it. FractionalIdeal.commSemiring. We can hackily fix the timeouts with
attribute [-instance] FractionalIdeal.commSemiring in
 theorem exists_ne_zero_mem_ringOfIntegers_of_norm_le_mul_sqrt_discr :

and
attribute [-instance] FractionalIdeal.commSemiring
 variable (w₁ : InfinitePlace K) {B : ℕ} (hB : minkowskiBound K 1 < (convexBodyLTFactor K) * B)

But this doesn't particularly make me happy

I guess it's better than not merging this PR?

I will add some notes and then retry.

!bench

bors merge


Problem to install on Laravel 11

Hi @arm092!
I'm facing a issue when try to install this package on Laravel 11, can you help me?
➜  composer require arm092/livewire-datatables
./composer.json has been updated
Running composer update arm092/livewire-datatables
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - arm092/livewire-datatables 2.1.0 requires reedware/laravel-relation-joins ^4.0.1 -> satisfiable by reedware/laravel-relation-joins[v4.0.1, v4.0.2].
    - arm092/livewire-datatables[1.0.0, ..., 1.0.7] require illuminate/support ^7.0|^8.0|^9.0|^10.0 -> found illuminate/support[v7.0.0, ..., v7.30.6, v8.0.0, ..., v8.83.27, v9.0.0, ..., v9.52.16, v10.0.0, ..., v10.48.8] but these were not loaded, likely because it conflicts with another require.
    - arm092/livewire-datatables[2.0.0, ..., 2.0.6] require illuminate/support ^9.0|^10.0 -> found illuminate/support[v9.0.0, ..., v9.52.16, v10.0.0, ..., v10.48.8] but these were not loaded, likely because it conflicts with another require.
    - reedware/laravel-relation-joins[v4.0.0, ..., v4.0.2] require illuminate/contracts ^8.83|^9.52|^10.0 -> found illuminate/contracts[v8.83.0, ..., v8.83.27, v9.52.0, ..., v9.52.16, v10.0.0, ..., v10.48.8] but these were not loaded, likely because it conflicts with another require.
    - Root composer.json requires arm092/livewire-datatables * -> satisfiable by arm092/livewire-datatables[1.0.0, ..., 1.0.7, 2.0.0, ..., 2.1.0].

You can also try re-running composer require with an explicit version constraint, e.g. "composer require arm092/livewire-datatables:*" to figure out if any version is installable, or "composer require arm092/livewire-datatables:^2.1" if you know which you need.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

I open a pull request at #18

hello, thanks.... merged


WIP: Add automatic code formatting with Prettier

- Summary

- Test plan

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Deploy preview ready!
Built with commit 9795c9242e33ff283e88aeb1a994c3d4373e003c
https://deploy-preview-952--cms-demo.netlify.com

Deploy preview ready!
Built with commit 9795c9242e33ff283e88aeb1a994c3d4373e003c
https://deploy-preview-952--netlify-cms-www.netlify.com

@tech4him1 I pushed updated commits and changed the config a bit - Prettier produces a lot of stacked args lists, and Babel gets rid of them in the output, so we should just use them everywhere.
Let me know what you think.

@erquhart What Prettier options did you change?

Prettier produces a lot of stacked args lists, and Babel gets rid of them in the output, so we should just use them everywhere.

I don't particular like stacked args lists everywhere, but it's not horrible.

That was the only difference, changing trailing commas to "all" instead of "es5".

Great, if @Benaiah's good with it, let's merge.

@Benaiah had a few suggestions in https://github.com/netlify/netlify-cms/issues/1013:

[x] --trailing-commas all
[ ] --print-width <something wider than 80>
[ ] Integrate prettier with eslint:

[ ] Make prettier run through eslint --fix
[ ] Use prettier-compatible eslint config
[ ] Make eslint check for proper code formatting in test suite.

Updated PR to use single quotes -- we will need to re-run Prettier before merge.

Just holding off on this until we're ready to break every PR. We'll get it in soon.

@erquhart @Benaiah @talves Do we want to add the precommit hook back in once we get the existing linting issues resolved?

Updated ESLint/StyleLint to use only code (not style) checks.

@jeddy3 Should we be running stylelint --fix along with Prettier and eslint --fix?

Should we be running stylelint --fix along with Prettier and eslint --fix

I don't believe any of the rules in the recommended config are autofixable. It's mainly the stylistic rules that can be autofixed in stylelint, which aren't included in the recommended config.
So, I don't think there's any harm in using stylelint --fix, but at it won't (at this time) do anything for you.

We should pull the trigger on this right before the v2 release.

Why did you remove .editorconfig? Yes, Prettier uses, and so do IDEs. That's the point. All the tools use the same config. Why remove it?

@thorn0 I removed .editorconfig because it was conflicting with Prettier's defaults. I'm fine with re-adding it as long as we make sure to avoid conflicts.

@tech4him1 blocking PR's merged 👍

Awesome, just a few left to create!

Lint errors left:
C:\Users\Family\programming\netlify-cms\packages\netlify-cms-backend-bitbucket\src\API.js
   48:20  error  'user' is defined but never used             no-unused-vars
  134:28  error  'commitMessage' is defined but never used    no-unused-vars
  134:43  error  'newEntry' is defined but never used         no-unused-vars
  139:11  error  'branch' is assigned a value but never used  no-unused-vars

C:\Users\Family\programming\netlify-cms\packages\netlify-cms-backend-gitlab\src\API.js
  192:19  error  'author_name' is assigned a value but never used   no-unused-vars
  192:39  error  'author_email' is assigned a value but never used  no-unused-vars

C:\Users\Family\programming\netlify-cms\packages\netlify-cms-backend-test\src\implementation.js
  136:37  error  'mediaFiles' is assigned a value but never used  no-unused-vars

Two blocking PRs left, then we're good to go!

All blockers merged 🎉 🎉
Last call for anyone that wants to opine on this one - I'll review soon @tech4him1.

Awesome, I'll work on rebasing!


Show tracker based on flag from daemon

@keybase/react-hackers please checkout out and make sure the trackers you expect do show show (not just a code check)

works for me: :+1:


Add telem ingress config

LGTM

@skubakdj this PR is still a draft, but it looks good to go. What will trigger it being ready?

@StephenFluin kept it as a draft because the new functionality hasn't made its way into a release yet, but otherwise it's good to go. Happy to merge it up now if we want

@skubakdj where does this stand? Are we ready for review and merge on this PR?

@dwightjl thanks for the ping! yep, this is ready for review


Support to MMLab models

Hi~Have you test the support for models of MMLabs? I just used mqBench to quantize a simple cls_models and errors occurs like that:
[MQBENCH] INFO: Quantize model Scheme: BackendType.Tensorrt Mode: Eval
[MQBENCH] INFO: Weight Qconfig:
    FakeQuantize: LearnableFakeQuantize Params: {}
    Oberver:      MinMaxObserver Params: Symmetric: True / Bitwidth: 8 / Per channel: True / Pot scale: False / Extra kwargs: {}
[MQBENCH] INFO: Activation Qconfig:
    FakeQuantize: LearnableFakeQuantize Params: {}
    Oberver:      EMAMinMaxObserver Params: Symmetric: True / Bitwidth: 8 / Per channel: False / Pot scale: False / Extra kwargs: {}
Traceback (most recent call last):
  File "my_python_path/lib/python3.7/site-packages/torch/fx/_symbolic_trace.py", line 615, in trace
    self.create_node('output', 'output', (self.create_arg(fn(*args)),), {},
  File "my_python_path/lib/python3.7/site-packages/mmcv/runner/fp16_utils.py", line 94, in new_func
    if not isinstance(args[0], torch.nn.Module):
TypeError: 'ImageClassifier' object is not subscriptable
python-BaseException

Are there some unfittness between MMLab and MQbench, or problems of my envs version? Hope for your help

We find it is slightly difficult to support MMLab, you have to modify the model very carefully.

We find it is slightly difficult to support MMLab, you have to modify the model very carefully.
Do you have any experience to share?


Initial load delay

I have a Wordpress that I run on 2 different domains.
First one is running on NGINX, with WP Super Cache, and the second one is running on a EE installation of NGINX with FastCGI Cache.
The first one has no delay at all when loading the page, while the EE-configured one, with FastCGI Cache, has a 0.3 delay that is very very perceptible to the user.
Also, killing PHP makes the website unavailable, while I thought the "fastcgi_cache_use_stale" was supposed to serve a cached copy of the page?
Any way to find what's causing this and fix these errors?

Also, killing PHP makes the website unavailable, while I thought the "fastcgi_cache_use_stale" was supposed to serve a cached copy of the page?

Page will be served from cache only if its cached before PHP was killed.
To test:

Start PHP
Open Page (so it gets cached)
Stop PHP
Open page again. At this point if cache is working properly, you will get page from cache even if PHP is down.

** fastcgi_cache_use_stale is slightly different. **
Check following scenario:

Nginx check if requested page is cached.
If cached, check if cache is "still" fresh. Refers to inactive value from line like fastcgi_cache_path ... inactive=60m;
If fresh, server from cache
If not fresh, i.e. if stale, request fresh copy from backend PHP
At this point, if backend PHP is available, fresh copy of page will be returned by PHP to Nginx. Nginx will return this copy to visitor and update fastcgi-cache for subsequent requests.
But, if backend PHP is not available, fastcgi_cache_use_stale is checked.
If backend is down and fastcgi_cache_use_stale is false, 500 HTTP server error will be returned.
If backend is down but fastcgi_cache_use_stale is true, page will be returned from cache.

I hope above clears your doubt.

Hello,
I tried exactly what you describe on a brand new WP created using "ee site create domain.com --wpfc", and yet, when I "service php5-fpm stop", I get a Bad Gateway error from NGINX.

Do you have any wordpress plugin installed?
Some plugins can prevent caching of wordpress pages.

By the way apart from PHP start/stop, with --wpfc you can simply run curl -I domain.com.
You should see HIT there. You may send you site URL here, so I can have a look at it.

@frederichoule Are you sure you are logged out of your website after you have stopped PHP? You might also want to check whether 'disable cache for loggedin users' is disabled.


Get a vector of systems

Hi.
I am working with multiple vehicles. In the docs, it's mentioned how to access a system by
DronecodeSDK dc;
//...
//Use UUID named uuid to get the associated System
System &system = dc.system(uuid);

What is a correct way to create a variable number of multiple systems?
Thanks.

You should be able to get all system like described here:
https://sdk.dronecode.org/en/guide/connections.html#iterating-all-systems
However, for now you need to make sure yourself that all vehicles have different system IDs.

@julianoes so, I am looking into how to get system_id instead of uuid. I found this: https://github.com/Dronecode/DronecodeSDK/blob/develop/core/system_impl.cpp#L518
Would do that do the job?
but it is not exposed in system.cpp

@mzahana is it not possible to use the UUIDs?

@julianoes Of course it is possible. It is not about possibility, it's about convenience.
Assume there is a set of 50 drones (maybe more!), which are labeled from 1 to 50. How you would you tell the user that drone 19 and 47 have some issues and require some checking?
I guess it's harder for the user to look for drones that have UUID<PHONE_NUMBER> and<PHONE_NUMBER> than just 19 and 47, no?

If something is automated in software UUID is more "convenient" because you it's unique.
I suggest you implement the method to get all system IDs yourself since you're already changed the API to work with system IDs instead of UUIDs.

@julianoes Would exposing get_syste_id in system.cpp do any harm?

@julianoes Would exposing get_system_id in system.cpp do any harm?

I guess it doesn't :smile:, so we might as well add it.

Work in progress here: #694.

This has been added, see: https://mavsdk.mavlink.io/develop/en/cpp/api_changes.html#v0330


T673: Tychonoff P-spaces are cozero complemented

New T673: P-space + Tychonoff => cozero complemented.
See issue #1048.
Implies that S22 (Fortissimo space on the real numbers) is cozero complemented.
Note: I used "zero set" and "cozero set" without hyphen, as that seems to be more common terminology.

Everything looks fine to me, so I approved. Though, as you already requested a review from @Moniker1998, I'll refrain from merging.

Perfect.  I'll merge.


Solution to fix compiler errors (DIP25)

Problem with returning ref T foo() {return this.X}
change to ref T foo() return {return this.X}
example:
	ref Vector3 opIndex(int axis) 	{ 		return this.elements[axis]; 	}
to
	ref Vector3 opIndex(int axis) 	return { 		return this.elements[axis]; 	}
and this compiles with no errors

Thanks, this is (finally) fixed in d554c00 and v0.1.10.

Thanks, this is (finally) fixed in d554c00 and v0.1.10.


improve Japanese

Hi @44uk Thanks mate for contributing, could you please have a look at the conflict?

Hi @44uk Thanks mate for contributing, could you please have a look at the conflict?

I'v done and pushed commit.


NET7 System.Runtime.InteropServices.SEHException: 'External component has thrown an exception.'

Steps to reproduce:

Create a solution with: C# console, C++ DLL, C# dll (for exports). All attached in zip
Test the C++ export OK
The C# dll export following guidance here https://github.com/3F/DllExport/issues/130  fails with SEH exception. Even a manual config of the testExport.csproj to x86 didn't help and produced the same problem.
Disassembly suggests the export entry doesn't point to function body

DllExport -version:  1.7.4
Used Visual Studio / MSBuild / ...: VS Community 2022 (64-bit) Version 17.6.2

testDll.zip

Hi @3F
I am also facing the same issue, i have recently upgraded the projects to .net core <TargetFramework>net8.0-windows</TargetFramework>
May i get some help on fixing the issue?

Hello. Thanks for the report!
.NET 8 & .NET 7 (@northstarvn's testDll.zip) are not supported at the moment and it was already discussed in previous issues.
My implantation is planned according to the new priorities described in my last article
Closed as duplicate #219


fix(markdown-preview/copy-image): invalid error with blob when download image.

When you copied an image with an external link, it gave a CORS error.

Since it wasn't possible to fix the CORS issue directly to resolve this problem, instead of copying an image from an external source, it now copies the link to your clipboard so you can access the image. For local images, it still copies normally like before.
issue: https://github.com/microsoft/vscode/issues/205624

@Felipeex please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree


[Fix-16475][UI] Can't SET Timing successful in Workflow Definition grid

Purpose of the pull request
close #16475

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Frontend build failed. Please check it. @topsli

I've made the updates, please review them again.
 variables.timingState = 'OFFLINE'


日本語訳の修正 売上認識→収益認識

[フィードバックをこちらに入力してください]
売上認識ではなく、収益認識が正しいと思います。

ドキュメントの詳細
⚠ このセクションを編集しないでください。 docs.microsoft.com で必須です ➟ GitHub の問題のリンク。

ID: 49ee1703-51fa-03cb-cb6c-d13c59ec0dc3
Version Independent ID: be390b47-7972-c0d5-aa66-ac74ad24473f
Content: 売上認識の設定 - Finance | Dynamics 365
Content Source: articles/finance/accounts-receivable/revenue-recognition-setup.md
Service: dynamics-365-finance
Product: ****
Technology: ****
GitHub Login: @kweekley
Microsoft Alias: kweekley

@hiromichif, thank you for providing this feedback.
@kweekley, please review and update the content, as needed.  I believe the feedback says, "I think the revenue recognition is correct, not the sales recognition."

Bug 647692 has been logged to track this issue.

Submitted Translation Feedback to partner LSP. Waiting for evaluation from the linguists.

The ja-JP linguists evaluated this issue and categorized it as a stylistic preference. They have suggested keeping the term as updating means extensive changes to the localized material.


Property:recordSource

Label
Record Source

Definition
Source of the record if not created by the author named in Author.

Usage
Source of the collection description record if not created by the entity/person/group named as "Author" or "Creator".

Existing property
dc:source

Existing class

Existing property identifier
http://purl.org/dc/terms/source

Format
Text

Required
No

Repeatable
No

Constraints

Examples
Index Herbariorum, Diment, J. A., & Wheeler, A. (1984). Catalogue of the natural history manuscripts and letters by Daniel Solander (1733–1782), or attributed to him, in British collections. Archives of Natural History, 11(3), 457-488.

Notes
The system from which the record was generated. Use the Person class instead of this property to record the name of the entity/person/group who had the role of "Creator" or "Author" for the metadata for the record.

recordSource Property was deprecated in Working Group Notes 24 March 2022
but there was no alternative solution proposed for the use case where you need to acknowledge that a particular LtC record was created/minted by another person or entity, for example an IH record harvested by GRSciColl?
For version 1 therefore the proposed solution is:
“In order to credit the source of a record you would attach an identifier to the RecordLevel Class with source = ‘record derived from’ and identifier = ‘the id/doi/etc. Of the person or organisation that minted/wrote/created it’.  “


NA12878-exome-eval example: Error in "work/gatk-haplotype/dbsnp.conf"

Version info

bcbio version (bcbio_nextgen.py --version): 1.2.1
OS name and version: Ubuntu 18.04.4 LTS

To Reproduce

cd /work/manager/NA12878-exome-eval/work
bcbio_nextgen.py ../config/NA12878-exome-methodcmp.yaml -n 8
NA12878-exome-methodcmp.yaml

# Configuration comparing alignment methods, preparation approaches
# and variant callers for an NA12878 exome dataset from EdgeBio.
#
# See the bcbio-nextgen documentation for full instructions to
# run this analysis:
# https://bcbio-nextgen.readthedocs.org/en/latest/contents/testing.html#example-pipelines
---
upload:
  dir: ../final
details:
  - files: [../input/NA12878-NGv3-LAB1360-A_1.fastq.gz, ../input/NA12878-NGv3-LAB1360-A_2.fastq.gz]
    description: NA12878
    metadata:
      sex: female
    analysis: variant2
    genome_build: hg38
    algorithm:
      aligner: bwa
      variantcaller: gatk-haplotype
      validate: giab-NA12878/truth_small_variants.vcf.gz
      validate_regions: giab-NA12878/truth_regions.bed
      variant_regions: capture_regions/Exome-NGv3

Observed behavior
[2020-03-31T22:21Z] System YAML configuration: /usr/local/bcbio/galaxy/bcbio_system.yaml.
[2020-03-31T22:21Z] Locale set to C.UTF-8.
[2020-03-31T22:21Z] Resource requests: bwa, sambamba, samtools; memory: 3.00, 3.00, 3.00; cores: 16, 16, 16
[2020-03-31T22:21Z] Configuring 1 jobs to run, using 8 cores each with 24.1g of memory reserved for each job
[2020-03-31T22:21Z] Timing: organize samples
[2020-03-31T22:21Z] multiprocessing: organize_samples
[2020-03-31T22:21Z] Using input YAML configuration: /work/manager/NA12878-exome-eval/config/NA12878-exome-methodcmp.yaml
[2020-03-31T22:21Z] Checking sample YAML configuration: /work/manager/NA12878-exome-eval/config/NA12878-exome-methodcmp.yaml
[2020-03-31T22:21Z] Retreiving program versions from /usr/local/bcbio/manifest/python-packages.yaml.
[2020-03-31T22:21Z] Retreiving program versions from /usr/local/bcbio/manifest/r-packages.yaml.
...
[2020-04-01T01:28Z] Annotate VCF file: NA12878, gatk-haplotype
[2020-04-01T01:28Z] Annotate with dbSNP
[2020-04-01T01:28Z] =============================================
[2020-04-01T01:28Z] vcfanno version 0.3.2 [built with go1.12.1]
[2020-04-01T01:28Z] see: https://github.com/brentp/vcfanno
[2020-04-01T01:28Z] =============================================
[2020-04-01T01:28Z] vcfanno.go:112: [Flatten] unable to open file: //work/manager/NA12878-exome-eval/variation/dbsnp-151.vcf.gz in
[2020-04-01T01:28Z] Uncaught exception occurred
Traceback (most recent call last):
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/bcbio/provenance/do.py", line 26, in run
    _do_run(cmd, checks, log_stdout, env=env)
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/bcbio/provenance/do.py", line 106, in _do_run
    raise subprocess.CalledProcessError(exitcode, error_msg)
subprocess.CalledProcessError: Command 'set -o pipefail; vcfanno -p 8 /work/manager/NA12878-exome-eval/work/gatk-haplotype/dbsnp.conf /work/manager/NA12878-exome-eval/work/gatk-haplotype/NA12878-effects.vcf.gz |  bgzip -c > /work/manager/NA12878-exome-eval/work/bcbiotx/tmpwllhz4ka/NA12878-effects-annotated.vcf.gz
=============================================
vcfanno version 0.3.2 [built with go1.12.1]
see: https://github.com/brentp/vcfanno
=============================================
vcfanno.go:112: [Flatten] unable to open file: //work/manager/NA12878-exome-eval/variation/dbsnp-151.vcf.gz in
' returned non-zero exit status 1.
Traceback (most recent call last):
  File "/usr/local/bcbio/bin/bcbio_nextgen.py", line 245, in <module>
    main(**kwargs)
  File "/usr/local/bcbio/bin/bcbio_nextgen.py", line 46, in main
    run_main(**kwargs)
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/bcbio/pipeline/main.py", line 50, in run_main
    fc_dir, run_info_yaml)
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/bcbio/pipeline/main.py", line 91, in _run_toplevel
    for xs in pipeline(config, run_info_yaml, parallel, dirs, samples):
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/bcbio/pipeline/main.py", line 165, in variant2pipeline
    samples = run_parallel("postprocess_variants", samples)
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/bcbio/distributed/multi.py", line 28, in run_parallel
    return run_multicore(fn, items, config, parallel=parallel)
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/bcbio/distributed/multi.py", line 86, in run_multicore
    for data in joblib.Parallel(parallel["num_jobs"], batch_size=1, backend="multiprocessing")(joblib.delayed(fn)(*x) for x in items):
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/joblib/parallel.py", line 1004, in __call__
    if self.dispatch_one_batch(iterator):
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/joblib/parallel.py", line 835, in dispatch_one_batch
    self._dispatch(tasks)
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/joblib/parallel.py", line 754, in _dispatch
    job = self._backend.apply_async(batch, callback=cb)
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/joblib/_parallel_backends.py", line 209, in apply_async
    result = ImmediateResult(func)
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/joblib/_parallel_backends.py", line 590, in __init__
    self.results = batch()
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/joblib/parallel.py", line 256, in __call__
    for func, args, kwargs in self.items]
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/joblib/parallel.py", line 256, in <listcomp>
    for func, args, kwargs in self.items]
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/bcbio/utils.py", line 55, in wrapper
    return f(*args, **kwargs)
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/bcbio/distributed/multitasks.py", line 235, in postprocess_variants
    return variation.postprocess_variants(*args)
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/bcbio/pipeline/variation.py", line 105, in postprocess_variants
    orig_items)
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/bcbio/variation/annotation.py", line 65, in finalize_vcf
    out_file = _add_dbsnp(in_file, dbsnp_file, items[0], out_file, post_cl)
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/bcbio/variation/annotation.py", line 172, in _add_dbsnp
    do.run(cmd.format(**locals()), "Annotate with dbSNP")
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/bcbio/provenance/do.py", line 26, in run
    _do_run(cmd, checks, log_stdout, env=env)
  File "/usr/local/bcbio/anaconda/lib/python3.6/site-packages/bcbio/provenance/do.py", line 106, in _do_run
    raise subprocess.CalledProcessError(exitcode, error_msg)
subprocess.CalledProcessError: Command 'set -o pipefail; vcfanno -p 8 /work/manager/NA12878-exome-eval/work/gatk-haplotype/dbsnp.conf /work/manager/NA12878-exome-eval/work/gatk-haplotype/NA12878-effects.vcf.gz |  bgzip -c > /work/manager/NA12878-exome-eval/work/bcbiotx/tmpwllhz4ka/NA12878-effects-annotated.vcf.gz
=============================================
vcfanno version 0.3.2 [built with go1.12.1]
see: https://github.com/brentp/vcfanno
=============================================
vcfanno.go:112: [Flatten] unable to open file: //work/manager/NA12878-exome-eval/variation/dbsnp-151.vcf.gz in
' returned non-zero exit status 1.

Expected behavior
Annotation of output .vcf files
Log files
Please attach (10MB max): bcbio-nextgen.log, bcbio-nextgen-commands.log, and bcbio-nextgen-debug.log.
Additional context
The file "work/gatk-haplotype/dbsnp.conf" refers to:

/work/manager/NA12878-exome-eval/variation/dbsnp-151.vcf.gz
I think it should refer to the installed file:
/usr/local/bcbio/genomes/Hsapiens/hg38/variation/dbsnp-153.vcf.gz
Install directory = /usr/local/bcbio
log.zip

Hi Tony @tony-travis !
Thanks for the report!
I thinks itis  because
https://github.com/chapmanb/cloudbiolinux/blob/master/ggd-recipes/hg38/dbsnp.yaml
installed dbsnp153  and
https://github.com/bcbio/bcbio-nextgen/blob/master/config/genomes/hg38-resources.yaml
had dbsnp151 the older dbsnp (I have fixed it).
We missed because we had previous versions of dbsnp installed as well.
Please try
bcbio_nextgen.py upgrade -u skip --genomes hg38
and let us know if that fixes the issue for you.
SN

Hi, Sergey.
OK, that's fixed the problem - Thanks!
Tony.


Investigate duplicate track notification emails

They seem to send twice, at least for me:

I need to just check if I'm subscribed twice with 2 different accounts or if this is a real issue.

You are in fact subscribed from two different accounts. Closing this issue unless there have been other reports of duplicates.


Board Review: Authentication Events Trigger Binding for Azure Functions

Thank you for submitting this review request. Thorough review of your client library ensures that your APIs are consistent with the guidelines and the consumers of your client library have a consistently good experience when using Azure.
The Architecture Board reviews Track 2 libraries only. If your library does not meet this requirement, please reach out to Architecture Board before creating the issue.
Please reference our review process guidelines to understand what is being asked for in the issue template.
To ensure consistency, all Tier-1 languages (C#, TypeScript, Java, Python) will generally be reviewed together.  In expansive libraries, we will pair dynamic languages (Python, TypeScript) together, and strongly typed languages (C#, Java) together in separate meetings.
For Tier-2 languages (C, C++, Go, Android, iOS), the review will be on an as-needed basis.
Before submitting, ensure you adjust the title of the issue appropriately.
Note that the required material must be included before a meeting can be scheduled.
Contacts and Timeline

Responsible service team: B2C Dublin
Main contacts: Shane Pennicott<EMAIL_ADDRESS>Expected code complete date: Completed.
Expected release date: 31 June 2022

About the Service

Link to documentation introducing/describing the service: https://github.com/Azure/microsoft-azure-webJobs-extensions-authentication-events (Will need required reviewers github accounts to give access)
Link to the service REST APIs: N/A
Link to GitHub issue for previous review sessions, if applicable:  N/A

About the client library

Name of the client library: Microsoft-azure-webJobs-extensions-authentication-events
Languages for this review: C#

Artifacts required (per language)
Please read through “API Review” section here to understand how these artifacts are generated. It is critical that these artifacts are present and are in the right format. If not, the language architects cannot review them with the SDK Team’s API review tool.
.NET

APIView Link: https://apiview.dev/Assemblies/Review/53af8de6e6694fa49f6cb6cc0a0f2c98
Link to Champion Scenarios/Quickstart samples: https://github.com/Azure/microsoft-azure-webJobs-extensions-authentication-events/tree/main/samples

For all other languages, send a request to the Architecture Board to discuss the best format on individual basis.
Thank you!

Scheduled for 6/7

The samples and doc links all 404?  Can you make sure those work or move them somewhere visible?

Recording (MS INTERNAL ONLY)


openai_base

Hi, I think this is a very great job and I would like to try to follow it.,but, due to my weak engineering skills, I don't know how to set  api-key and api_base in the eval. Could you please help me, Thank you very much!!
looking forword to your reply~~

Please enter the third party transfer URL (ending in /v1, please skip here if you use the official OpenAI API) e.g. (https://api.openai.com/v1)
The api key is configured in the get_api_key function of the eval_utils.py

ok~thanks!!

If there is no problem, we will close this issue


[release-1.13] Revert #36697 auto allocate ip while getting services from the store

Please provide a description of this PR:
cherry-pick #37539
fix https://github.com/istio/istio/issues/37557

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio_release-1.13
ba1b98fbc0b4870f45b09736335d176a09b8921c
link
unknown
/test integ-cni_istio_release-1.13

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/retest


Add AVX512-IFMA intrinsics.

Progress on #310, adding all the (unmasked) versions of the IFMA intrinsics.
Because AVX512VL extends the AVX512 intrinsics to ymm and xmm operands, there's a question about where the 256-bit and 128-bit variants of the instructions should live.  My feeling (mentioned in discussion in #310) is that the cleanest thing to do is to keep the length-extended intrinsics with their "parents", which is what I did here.
I don't know what the CI situation is, but I can confirm that these tests do pass on my Cannonlake machine (and don't pass when the numbers are changed).

Not sure if the appveyor failures are related to these changes; the avx512ifma tests seem like they passed there...

It appears that a vpmadd52luq is being generated for some intrinsics instead of vpmadd52huq.
It appears to be a bug in the assert_instr() tests of the new intrinsics. E.g. the test for _mm512_madd52lo_epu64 requires vpmadd52huq but the Intel Intrinsics Guide says that the intrinsic generates a vpmadd52luq (https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_mm512_madd52lo_epu64&expand=3497), so the failures appear to be right.
@hdevalence note that for the assert_instr test to run, you need to run the tests in --release mode. These tests do not run in debug mode.

@hdevalence note that for the assert_instr test to run, you need to run the tests in --release mode. These tests do not run in debug mode.

Ooops, thanks for pointing this out, I'll fix it!

Fixed; tested locally with --release. Thanks for pointing that out!

Progress! It seems that the build is mostly green now :)
The verification of the intrinsics is failing:
--- verify_all_signatures stdout ----
failed to verify `_mm512_madd52hi_epu64`
  * intel cpuid `avx512ifma52` not in `avx512ifma` for _mm512_madd52hi_epu64
failed to verify `_mm512_madd52lo_epu64`
  * intel cpuid `avx512ifma52` not in `avx512ifma` for _mm512_madd52lo_epu64
failed to verify `_mm256_madd52hi_epu64`
  * intel cpuid `avx512ifma52` not in `avx512ifma,avx512vl` for _mm256_madd52hi_epu64
failed to verify `_mm256_madd52lo_epu64`
  * intel cpuid `avx512ifma52` not in `avx512ifma,avx512vl` for _mm256_madd52lo_epu64
failed to verify `_mm_madd52hi_epu64`
  * intel cpuid `avx512ifma52` not in `avx512ifma,avx512vl` for _mm_madd52hi_epu64
failed to verify `_mm_madd52lo_epu64`
  * intel cpuid `avx512ifma52` not in `avx512ifma,avx512vl` for _mm_madd52lo_epu64
failed to verify `_mm512_set1_epi64`
  * intrinsic `_mm512_set1_epi64` uses a 64-bit bare type but may be available on 32-bit platforms

It seems that in the intel-x86.xml file states that these intrinsics require the avx512ifma52 CPUID feature flag, but we name this feature avx512ifma, so this condition is returning false, hence the error. Wanna give fixing this a try? The best would be to just add a function that maps the Intel CPUID name to the Rust target feature name. It should just return the CPUID name unless the name is avx512ifma52 in which case it should return avx512ifma. Once you have this function, just use it inside the contains in the code above to translate the feature names.

I added a fixup pass for the CPUID names, hopefully it's OK; I'm not sure what to do about the remaining failure re: _mm512_set1_epi64... I don't understand why AVX512 would be available on 32-bit platforms anyways.

@hdevalence wow nice work, only one failure to go !

I don't understand why AVX512 would be available on 32-bit platforms anyways.

You can compile for an x86 target with 32-bit wide pointers and still use SIMD intrinsics. Basically, 32-bit platform refers to the target_pointer_with. If you know that your application doesn't need to address more than 4Gb of memory, you can save some space by just making your pointers 32-bit wide instead of 64-bit wide, even if your binary is running on a 64-bit system.
I'm not 100% sure, but I think that error message is trying to tell us that _mm512_set1_epi64 belongs in the x86_64 module instead of the x86 module. Would you mind trying if moving the function makes the test pass ?

Hmm, I don't think I really understand what's going on.  stdsimd has a distinction between x86 / x86_64 modules. Previously I had no idea what the distinction was, so I stuck the avx512ifma.rs in the same place as avx512f.rs.
From your comment I gather that the reason that AVX512, AVX2 etc. are in x86 rather than x86_64 is that they can be used in 32-bit mode (? like the x32 ABI?).  But my understanding was that x32 is a Linux-specific ABI that just changes the pointer width to 32 bits, and all of the instructions are otherwise identical to normal x86-64 code. So I don't think I even understand what the criteria would be for it to be "correct" to put it in one place or another.
I noticed that there's a hardcoded check here: https://github.com/rust-lang-nursery/stdsimd/blob/master/crates/stdsimd-verify/tests/x86-intel.rs#L362 which includes _mm256_set1_epi64x, which is the ymm analogue of the desired zmm instruction, but I also don't really understand what that whitelist is doing. Would it be correct to add _mm512_set1_epi64 to that list instead of moving the intrinsics?
Sorry for all of the confusion on this; I'm happy to do whatever works or is correct.

So I don't think I even understand what the criteria would be for it to be "correct" to put it in one place or another.

The main criteria here has always been empirical. When compiling for 32-bit x86, LLVM fails to generate working machine code for some SIMD intrinsics, so we just put those in the x86_64 module and called it a day.

I noticed that there's a hardcoded check here: https://github.com/rust-lang-nursery/stdsimd/blob/master/crates/stdsimd-verify/tests/x86-intel.rs#L362 which includes _mm256_set1_epi64x, which is the ymm analogue of the desired zmm instruction, but I also don't really understand what that whitelist is doing. Would it be correct to add _mm512_set1_epi64 to that list instead of moving the intrinsics?

Ah yes, since the test pass on x86 targets (and only verify fails), that would be correct (LLVM is able to generate code that works for these targets).

For x86/x86_64 the intention was that if you'd be able to compile code for i686-unknown-linux-gnu and run that with intrinsics and whatnot. It looks like avx/avx2/etc all work on i686-unknown-linux-gnu so long as the CPU does
For intrinsics that take 64-bit types, though, they can't map to an instruction on i686-unknown-linux-gnu because there's no 64-bit registers, so they're moved into the x86_64 mod. It should be fine to define most avx-512 things in x86, but anything taking a u64/i64 argument should go into x86_64

For intrinsics that take 64-bit types, though, they can't map to an instruction on i686-unknown-linux-gnu because there's no 64-bit registers, so they're moved into the x86_64 mod.

@alexcrichton the weird thing here is that the i686-unknown-linux-gnu build jobs for this intrinsic are passing, so LLVM appears to be able to generate working code for these (there is no assert_instr though, so the machine code might be horrible..).

Oh sure yeah LLVM "does the right thing" in that it gets the code to work on i686-unknown-linux-gnu, but it's sort of a lie and it exposes how LLVM has tons of polyfills for all sorts of SIMD operations. There's no native implementation of taking a 64-bit integer and broadcasting it to 512 bits on i686-unknown-linux-gnu, but LLVM can still codegen one.
(we only want to stabilize official things, though, not things that LLVM happens to be able to do)

So @hdevalence the safest thing is to just move that intrinsic to the x86_64 module.

Hmm, wouldn't the safest thing be to move all the AVX-512 intrinsics into the x86_64 module?

There's no native implementation of taking a 64-bit integer and broadcasting it to 512 bits on i686-unknown-linux-gnu,

I don't really understand what this means; the "native" implementation according to https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_mm512_set1_epi64&expand=4927 is vpbroadcastq zmm, r64, which is possible on any CPU that has AVX-512 registers -- there are no processors that can parse EVEX but not REX.

@hdevalence
With stdsimd you can write a binary that targets very old 32-bit targets without SIMD support, and the same binary can use run-time feature detection to use SIMD registers when it runs on a 64-bit modern CPU.
We've had problems in the past with the code generated for functions using 64-bit integers in those targets, even though functions using SIMD registers are lowered just fine.
My recommendation is to stick to the policy of moving functions using 64-bit integers to the x86_64 module. If you care about using these functions when generating 32-bit binaries, please open an issue about it. We can always move the function to the x86 module later in a backwards compatible way.

Updated so that _mm512_set1_epi64 matches its AVX2 analogue _mm256_set1_epi64x.

Thank you so much!

Awesome! I can try adding the mask variants later.  Do you know what the average latency on "merged into stdsimd" -> "appears in nightly" is?

Once this PR lands (https://github.com/rust-lang/rust/pull/58373) the nightly afterwards should contain these changes.

Cool, thanks for the information and the help with this PR!

@hdevalence is any library using these already? We probably can start thinking about stabilizing these if that would help.

I'm using them in curve25519-dalek, but I'm not sure if there's a rush to stabilize them, because they only run on one CPU, which is only available in a single laptop only sold in mainland China or in a single NUC.

I see, well let us know if that changes!


dot/streams -- make default streams safe for concurrent access

Codecov Report

Merging #295 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 951c3cf...ad7d273. Read the comment docs.


Rules order

Hey @chriskjaer,
I changed the order of the rules in the css because the media queries should be at the end of the file.
Before (the width in the class wins):
@media (max-width: 480px) {
    ._1protfs {
        width: 160px;
    }
}
._1protfs {
    width: 320px;
}

After (the width in the media query wins):
._57kv2x {
    width: 320px;
}
@media (max-width: 480px) {
    ._57kv2x {
        width: 160px;
    }
}

Tests are green :)

Thanks!
I added some test, so we ensure the order is correct in the future as well.


kamelets: support for kamelet local beans

Route Template local beans  is approaching and we need to define how we can leverage such functionality in camel-k and in the kamelets definition.
The current layout for kamelets is:
apiVersion: camel.apache.org/v1alpha1
kind: Kamelet
metadata:
  name: telegram-text-source e"
spec:
  ...
  flow:
    from:
      uri: direct:start
      steps:
         ...

I'd propose to replaces flow with template so it would looks like:
apiVersion: camel.apache.org/v1alpha1
kind: Kamelet
metadata:
  name: telegram-text-source e"
spec:
  ...
  template:
    beans:
      - name: myBean
        type: com.acme.MyBean
        properties:
         foo: "bar"
    from:
      uri: direct:start
      steps:
        - process: "myBean"

NOTE:

we should keep flow for backward compatibility but to create template local beans one has to use template keyword.
the new template keyword can be provided by the Camel YAML DSL so we can reduce the custom code we have to maintain for camel-k.

The code generated by the camel-k operator should then be:
- template:
    beans:
      - name: myBean
        type: com.acme.MyBean
        properties:
         foo: "bar"
    from:
      uri: direct:start
      steps:
        - process: "myBean"

/cc @nicolaferraro

Relates to https://issues.apache.org/jira/browse/CAMEL-16584

Yeah then the beans part of the template can then use the new local bean bind in camel-core (Camel 3.10 - CAMEL-16584). Then that bean myBean is local and only available while the template is creating routes. And each route will have its own instance that bean created.
The route template DSL in camel-core-model, does not however have beans, but its a novel idea, we could consider adding that, which allow this to be done in a more general and vanilla fashion with camel-core for all runtimes (not a special syntax in camel-k).

The route template DSL in camel-core-model, does not however have beans, but its a novel idea, we could consider adding that, which allow this to be done in a more general and vanilla fashion with camel-core for all runtimes (not a special syntax in camel-k).

yep absolutely true, the goal is to have it also in the XML DSL at some point.


sealos desktop oauth2 login

https://github.com/labring/fist/tree/master/auth
desktop -> github login -> create jwt token -> generate kubeconfig and save it

@fanux

Is it better to use dex docking?

@cuisongliu Could you provide a link to its repo or official page? thx! ❤

https://github.com/dexidp/dex
docking oidc

https://kubernetes.io/docs/reference/access-authn-authz/authentication/#configuring-the-api-server

dex is too complicated, we have already implemented the most core capabilities, so there is no need to use dex I think

https://dexidp.io/docs/using-dex/  Writing Apps That Use Dex  ,using dex sdk can dicking it.
dex support (LDAP, GitHub, SAML2.0, GitLab,OpenID Connect,OAuth 2.0, OpenStack and so on ) https://dexidp.io/docs/connectors/

We only need to integrate dex, and we don't need to care whether it is LDAP or OAuth2.

https://github.com/cuisongliu/dex-login  dex login code

using  fist+casbin It's also a better plan. We can all think about it together.

Casdoor or other SSO platforms already provides JWT token as a certification for user successful login. Maybe we can combine token generated by fist with this one?

Yes, it can be like this. The main ability of fist is the docking of oidc and k8s, and SSO can use other better solutions.

TODO:

[ ] Not delete PVC when deleting cluster image
[ ] Update MySQL when service-auth is restarting
[ ] Fix Casdoor redirect url
[ ] Use errors.Wrap
[ ] Fix getOauthToken error


Category and init data

Added just some basic category CRUD, guestion here: why there is a reference to Transactions in Category?
Also need to change IconPath input when creating categories, any ideas?


Problem with markdown

environment

vim: Neovim 0.5.1
vim-airline:
OS: Arch linux
Have you reproduced with a minimal vimrc: yes
What is your airline configuration: i just set the theme to nord
if you are using terminal:
terminal: alacritty
$TERM variable: xterm-256color
color configuration (:set t_Co?): set t_Co=256
if you are using Neovim:
does it happen in Vim: idk

actual behavior
Whenever i open a markdown file (.md) airline gives an error while vim is opening and crashes. If i run :AirlineToggle two times it doesnt do anything the first time and then enables it but without theming
I use Vim Plug and this is a list of the plugins i have installed on my system

expected behavior
Open vim normally and keep airline enabled
screen shot (if possible)
This is how it happens
https://user-images.githubusercontent.com/84200346/135915932-4dcead4c-a897-4d0b-b431-1f754e9eb1ad.mp4
This is the error

can you provide a minimal vimrc?
Does it happen in Vim?

I can but i have to go to sleep now gonna keep updating the issue tomorrow afternoon (after school)

I fixed it by removing this bad plugin and installing lightline.vim

thanks for the compliment...

It looks like your neovim did not find the default formatter plugin. I think this is an outcome one from one of those neovim regressions: https://github.com/neovim/neovim/pull/15632 and https://github.com/neovim/neovim/issues/15837
So not by this bad plugin


Wizard example: report of pristine state seems to be wrong

I am using a similar approach to the wizard example. The problem is that the pristine state of a form is calculated globally (for the specific form) and not for the fields that are currently registered. So if you look at the given example the "Submit" button in the last step will never be disabled (except when submitting). It actually should be disabled if the part of the wizard form that is being shown is actually pristine.
I'd be happy to try to provide a PR (if this is actually considered an issue and not the expected behavior).

Currently it's an expected behavior.
pristine/dirty are calculated by comparing the state of initial values, and the current form values in the store, regardless of what fields are currently registered.
The good news is that the handleSubmit function will not execute if there are validation errors in the form (which will prevent the submit, even though the button is enabled.)
I wonder if there is a solution that could be implemented without modifying the current expected behavior of pristine/dirty

Related to #2149 and #2502

Because this issue saw almost no activity for a few months, I'm closing it.


Lots of Timers created

For every channel push a new timer (and thus a new thread) is created.  This is quite expensive compared to using a ScheduledThreadPoolExecutor which would be re-using threads.
I plan on trying to convert all usages of Timers to using a shared ScheduledThreadPoolExecutor later in the week if this seems like a good change.

done in #42

Implemented in #43


Feature Request: Add multi-gpu support please

Add multi-gpu support please

yes - apple silicon too, I can't run it on a m2 max with 64gb unified ram

Seconded. M2 Pro chip with 32gb shared (regularly uses up to 25gb vram). I know there's a pytorch for apple silicon, are m-series versions of the the other dependancies for this?


Stevenxl sessions

Added the methods logged_in? and current_user to our Application Controller. These will also be available in views.

Looks good!


Allow Integration operations in batch

Allow to start/stop/restart/test Integrations in batch

When doing this:

Click on the Select all checkbox when there are more than 10 integrations (1 page).
After selecting the first 10 integrations, go to the second page.
Go back to the first page.

Then it shows like this:

It behaves oposite to the checkbox selection.
I'm thinking that it could keep the previously selected integrations and be able to select more as we go through pages, so the user can do batch operations with more than 10 integrations at a time.

Instead of showing this when trying to perform batch operations without any integrations selected, I think it would be better to dislpay a message indicating that one or more integrations must be selected.

Allowing selection during pagination
Showing number of rows selected
Disabled dropdown if no rows are selected

Tested and working fine.