password strength checker

Is your feature request related to a problem? Please describe.
this features includes a password strength checker tool
Describe the solution you'd like
this tool evaluates passwords based on length, complexity, and character variety. It provides feedback on password strength, indicating whether it's weak, moderate, or strong. Users can generate and test passwords to ensure they meet security standards.
What problem is this feature trying to solve?
"Password Strength Checker" assesses passwords, ensuring robust security. Users receive instant feedback on their password's strength, aiding in creating stronger and more secure passwords.
How do we know when the feature is complete?
the user will be able to use this tool.

@Sulagna-Dutta-Roy please assign this to me i am GSSOC'24 contributor with 2+ years of experience in development

Already added to my repository #197 @Nihita123


example.csv was broken when downloading repo as zip file.

when downloading repo as zip file,
the content of example.csv would be replace as this:
version https://git-lfs.github.com/spec/v1
oid sha256:c30db8ce360aa13fe7bcf943d0c3213f2b492a38c9ef897158b0dafe068e5be9
size 58446

Thanks for spotting this!
The csv files are stored using git lfs so you probably need to install this: https://docs.github.com/en/repositories/working-with-files/managing-large-files/installing-git-large-file-storage.
I also updated the README.


run_oltpbench.py: Add Debug Log Timestamps

Fix #868.

Be sure to update the junit directory too.
The error messages seem to be missing timestamps too: http://jenkins.db.cs.cmu.edu:8080/blue/organizations/jenkins/terrier/detail/PR-1010/2/pipeline#step-283-log-3

Added LOG to the junit directory. PTAL.
Besides, I changed the format of logging so that it will also show the full path of the source file. For example:

We will merge this after #993 gets in.


Have award overlay on project thumbnails too?

Maybe this puts too much focus on award projects... but I'd like to try this. Essentially, we would take the same approach as publications (except not trophy sign; just want the red 'Award' overlay on the project thumbnail).

Perhaps this would only show up on mouseover on project gallery?

Done. Though I still question whether this puts too much emphasis on projects with awards (all projects have merit!!!).


feat: scaffold the initial cli program with huh

Use huh and lipgloss to create a simple client program that build a commit message and displays it at the end.

Task linked: CU-862krh13f create first iteration of 'goodcommit'


Support 1.6.0+

Fix #699

@moxiegirl can you please take a look at the doc change ?

@aluzzardi I decided to keep 1.6.0 for now.

LGTM

We should put a compatibility matrix somewhere
@moxiegirl, WDYT ?

:+1:

@moxiegirl should we merge it as is and add the compatibility matrix  afterwards


[non-admin] Allow test cases to run with non-admin user in specific namespaces

I do not have much info to share at this point. This is just a reminder issue.
We need to think about adding test cases for non-admin flows. I will share details here soon.

Base test case to add after konveyor/mig-agnosticd#123:

login as user1, run oc new-project user1-workload on source cluster
run oc whoami -t, grab the token value
login as admin
Install operator and controller
grant user1 "use" verb on mig-controllers, https://gist.github.com/alaypatel07/9e06cbb074eb7fcd2157aa65478761f5
install operators via OLM on operator-hub. Need to make sure non-admin tags are installed
login as user1 on destination
create secret source-user1-token-secret, with token value from step 2.
run oc whoami -t, create secret destination-user1-token-secret with the token value
As admin create MigClusters, source and destination
As user1 create MigTokens with source-user1-token-secret and destination-user1-token-secret
wait for migtokens to get ready
create MigPlan with user1-workload namespace, wait for it to get ready
wait for MigPlan to go ready
create MigMigration
wait for migmigration to succeed


chore(deps): update common-dev-assets digest to ddd4511

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
a95caad -> ddd4511

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 2.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


chore(FDS-509): [Cascara] - bump postcss to v8.4.8

This bumps postcss to v8.4.8.
Dependencies
package.json file updated due to postcss bumping to v8.4.8
PR Author Checklist

[x] PR title adheres to Conventional Commits
[x] I have finished reviewing the contents of this PR for accuracy
[x] If needed, I have included a Changeset and it follows Semantic Versioning principles
[x] I have completed all of the above and have enabled auto-merge for this PR

Messages

:book:
Dangerfile.js does not run when the current branch is chore/FDS-509-bump-postcss

  Generated by :no_entry_sign: dangerJS against c9aea1ecb34358a64a78b129839ad109558e876a


Autocloaking won't turn off

Basically the title.
After the install the values were cloaked, but when I want to toggle it - with the button in the file, the command palette or disabling the feature in the settings - it won't turn off and I can't change the values around.

I am also facing the same issue !

Same. I had to disable it in both User & Workspace settings.

Yes, toggle not works in the last version. Thanks @gudbrandtandberg works fine :D

FYI https://github.com/dotenv-org/dotenv-vscode/issues/29
Adding these lines to settings.json works for me:
{
  // ...
  "editor.tokenColorCustomizations": {
     "textMateRules": []
  }
}

Bump issue

Thank you for raising this. We'll fix up soon.

For anyone using v0.23.0 downgrade to v.0.22.0 to fix the toggle issue and update until v != 0.23.0

We just published v0.24.1, which should fix this problem. Let me know how it goes for you.

@motdotla doesn't seem to be working, at least with version v0.24.2 in vscode-insiders. I get Cannot set properties of undefined (setting 'textMateRules')

This should be patched in the just released 0.24.3. Please install that and reload and try again. Sorry about this!


Add File Size to Download Dialog

[ ] From single dataset page download dialog, add File Size info

UPDATE: Eng clarified we cannot get the file size due to zarr file format

[ ] From single run page download dialog, add File Size info when user selects Download All Annotations Option (note the file size is already added for download tomogram)

need more clarity on how to show file size when it's MRC vs Zarr. pending design

Depends on https://github.com/chanzuckerberg/cryoet-data-portal/issues/444

similar to the location found in this design:


Build error on stereo_inertial_publisher.cpp

Pulled latest main branch and tried to build, got these errors:
stereo_inertial_publisher.cpp:185:15: error: ‘ImuSyncMethod’ is not a member of ‘dai::ros’
  185 |     dai::ros::ImuSyncMethod imuMode = static_cast<dai::ros::ImuSyncMethod>(imuModeParam);

stereo_inertial_publisher.cpp:216:72: error: ‘imuMode’ was not declared in this scope; did you mean ‘mode’?
  216 |     dai::rosBridge::ImuConverter imuConverter(tfPrefix + "_imu_frame", imuMode, linearAccelCovariance, angularVelCovariance);

Tried installing latest depthai-core build but had the same issue.

Pull the latest depthai-ros too. Will add a min version check while building.

Yep, that was the issue. Thanks.


Chore/fix prepublish

tldr: dont run prepublish on npm/yarn install

I was looking for something like this for a long time!!! Need to add it everywhere.

merged

im glad to help


Less vulnerable

The moment dependency defined in package-lock.json has a known moderate severity security vulnerability in version range < 2.19.3 and should be updated.

Very nice!


IgnoreTypeNameDeclaration option

Hi,
First off, thanks for this helpful lib.
While using it I realized I didn't need the extra __typename  field added to interfaces when using the generateNamespace function.
To get rid of It I added an optional, option to Ignore adding the typename field with logic that defaults to adding it.
Let me know if this is useful.

Coverage decreased (-0.2%) to 96.263% when pulling 0f513c3f181f267205c6a119b3768604a4049259 on epicallan:master into 42250cdee7e7402a425724f6030fce0aebfecd3a on avantcredit:master.

Coverage increased (+0.02%) to 96.441% when pulling cb89cb32eeda4513e5e02cc7442b6aebdc07bb76 on epicallan:master into 42250cdee7e7402a425724f6030fce0aebfecd3a on avantcredit:master.

lgtm @epicallan this ready for merge?

@brettjurgens I believe its ready for a merge. Let me know if there is anything else you would want me to do to get it ready. Otherwise i am looking forward to it being merged.

How does one use this through the CLI?

@Anahkiasen doesn't look like it's available through the CLI. I can add it as an option later today

@Anahkiasen released in 1.1.2


Handle Gtk.*Expression

Needs something similar to
quoting slomo

Actually nevermind, it shouldn't have a new() function but basically work like https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/blob/master/gstreamer/src/param_spec.rs#L13 . That way it will work well with the subclass property API.

Using Expressions from source code has been super weird so far, but thankfully you can use those from the UI file as well.

Maybe we can provide a manual API on top of the plain bindings that makes it more convenient. Maybe something macro based


Add field/line delimiter property in create hive table

There is an closed but not PRed  issue prestodb issue 6387, and a related issue 572. Hope this feature would be enhanced.

@aeoles do you have any needs beyond what's described in https://github.com/prestosql/presto/issues/572 ?

@aeoles do you have any needs beyond what's described in #572 ?

Currently No


Add more labels

Can we have stage, stage2, cross(or crosscompiler, which is quite long), win, linux, OS X as labels, to better separate the issues?

Good idea. Done! If any other labels are needed, just shout.

Also adding way-specific labels: profiling, dynamic, threaded, debug.


TODO: Compress every endpoint

Add optional (default enabled) compression to every endpoint to reduce total page request payload size

Now implemented :)


Make the value of delayAutoHide adjustable

Describe the proposed feature.
The value of delayAutoHide (related to the control bar) does not have to hardcoded to 3s, but can be set as an option value.

Hi @kbahchevanov, thanks for the report.
This has been added and merged in main.
Release 4.0.5 is available ! 🎉


Eliminate pushed down filters above JDBC TableScan

Fixes https://github.com/prestosql/presto/issues/4111

CI failed -- https://github.com/prestosql/presto/issues/4568

cc @martint @kokosing

How this will work with statistics?

The changes to QueryAssert look good. I haven't looked at the rest

The changes to QueryAssert look good. I haven't looked at the rest

rebased. @martint i can separate some commits into a separate PR. Which ones would you see there?

CI failed -- https://github.com/prestosql/presto/issues/4568


App not allowing Work Credit Entries

Due to the 2024 badge year change over, Work Credits cannot be entered for folks with active 2023 badges.

issue is in model -> badge ->isExpired

This seems to be working


Failed to create PVC from snapshot

error getting handle for DataSource Type VolumeSnapshot by Name test001: requested volume size 107374183 is less than the size 113246208 for the source snapshot test001

Increasing the capacity of PVC can solve the problem

When the stored size is 1 Gi, the restoration can be successful.


zim: fix missing app name and icon on Wayland

Motivation for this change
Since zim is wrapped the appid changes to .zim-wrapped. Renaming the
desktop file to match means that the app icon is displayed properly on
Wayland.
Tested on Gnome/Wayland.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Notify maintainers
cc @pSub

This seems kind of awkward. Ideally we could figure out how to set the appid to zim via wrapper configs.

I agree that it's awkward. Other package where this has been a problem generally use QT, which provides a function to set the app ID. It looks like the GTK equivalent might be this.
Let me tinker with it.

The preFixup looks suspicious. Is it still problem when manual --argv0 override is removed? IIRC GTK 3 sets the desktop id from the program name and makeWrapper sets unwrapped argv0 by default.


fix(timeline_links): dont create if contact link and ref is not the same

Asana: https://app.asana.com/0/1203283251131831/1207895033520677/f
Issue:
NEXT Master contacts are used to link email to particular Customer/Supplier. With this, if it is linked to multiple customers, any notification made from user will populate to the timeline of the linked customer or supplier which it should not because it is not relevant.
Fix:
Except the NEXT Master contact in adding timeline links whenever a notification to the customer/supplier is made.

Noted on this, Dominik. Thank you for the review.

Removed the next master keyword validation
Add a condition to don't create a timeline links if the Reference Doctype and Contact link is not the same

According to the documention, emailing linking to Customer or Supplier and as well as Contact is used for Email Aggregation. But as per the submitted issue, it should not display to Timeline because some information are unrelated.

Pushed a new code that will just comment the function that creates a TImeline Links base from the Contact's dynamic links.

As per discussion, there are other information that should be shown Customer/Supplier timeline logs. E.g. made an email from Sales Invoice, since Sales Invoice has connection to Customer, then a timeline should be created in both Sales Invoice, Customer. As well as Contact.
In this PR, this will not create a link to every connected dynamic link. Thus, closing this for rework.


feat(RatingThumbs): add new component for rating positive negative with thumbs

FX-2468
Description
Following the descriptions in figma and examples in abstract 1 2, we are adding a new component for positive and negative ratings. Following the decision on either create a new component or extend the current one, I created a new component called RatingThumbs that has a boolean state (true for a positive rating and false for a negative rating), an undefined state means unselected.
The storybook examples were added to the Rating page, as requested
How to test

Check new component and examples on storybook (at the end of the page for the Rating component)

Screenshots
New component:

Default state with hover effect on the right:

Review

[ ] Read CONTRIBUTING.md and Component API principles
[ ] Annotate all props in component with documentation
[ ] Create examples for component
[ ] Ensure that deployed demo has expected results and good examples
[ ] Ensure that tests pass by running yarn test
[ ] Ensure that visuals tests pass by running yarn test:visual. If not - check the documentation how to fix visual tests
[ ] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.

PR commands

List of available commands:

@toptal-bot run all - Run whole pipeline
@toptal-bot run build - Check build
@toptal-bot run visual - Run visual tests
@toptal-bot run deploy:documentation - Deploy documentation
@toptal-bot run package:alpha-release - Release alpha version

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

Following the descriptions in figma and examples in abstract 1 2, we are adding a new component for positive and negative ratings. Following the decision on either create a new component or extend the current one, I created a new component called RatingThumbs that has a boolean state (true for a positive rating and false for a negative rating), an undefined state means unselected.

I think we can write it a lil bit laconic. This info is great but we should also write it in changeset. So, I would wrap it up here and have thorough description in changeset.

We can write it in a lil bit laconic way wdyt? This info is great but we have to also write it in changeset. So, we should wrap it up here and have thorough description in changeset instead.

I think it's ok to have the same information in both the PR and the changeset description. I structured this description to quickly access the reference links and clarify some design decisions that I took for the component

@toptal-bot run package:alpha-release

Also please do not forget to add changeset by running yarn changeset 👉 https://github.com/toptal/picasso/blob/master/CONTRIBUTING.md#release


Updated bad docs in README.md

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #73   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          15     15
  Lines         442    442
=====================================
  Hits          442    442

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb77eeb...2dc9f4b. Read the comment docs.


Missing line of code to enable sample to work

Type of issue
Code doesn't work
Description
[Enter feedback here]
Under dependency Registation, the MainPage is not registered and the user will get the error message
"System.MissingMethodException: 'No parameterless constructor defined for type 'appname.MainPage'.'"
The correct dependency registration will look like this:
`        public static MauiApp CreateMauiApp()
{
var builder = MauiApp.CreateBuilder();
builder
.UseMauiApp()
.UseMauiCommunityToolkit()
.ConfigureFonts(fonts =>
{
fonts.AddFont("OpenSans-Regular.ttf", "OpenSansRegular");
fonts.AddFont("OpenSans-Semibold.ttf", "OpenSansSemibold");
});
builder.Services.AddSingleton(SpeechToText.Default);
builder.Services.AddTransient();
#if DEBUG
builder.Logging.AddDebug();
#endif
        return builder.Build();
    }
}`

Note the additional line:             builder.Services.AddTransient();
Page URL
https://learn.microsoft.com/en-us/dotnet/communitytoolkit/maui/essentials/speech-to-text?tabs=ios
Content source URL
https://github.com/MicrosoftDocs/CommunityToolkit/blob/main/docs/maui/essentials/speech-to-text.md
Document Version Independent Id
bd555d8e-ea79-876f-5108-fd6bb19d0d8a
Article author
@VladislavAntonyuk
Metadata

ID: bd555d8e-ea79-876f-5108-fd6bb19d0d8a
Service: dotnet-communitytoolkit
Sub-service: dotnet-maui-community-toolkit

No response for a long time so assuming this issue has been resolved, thank you!


Azure authentication : ability to choose authorize endpoint

Hi,
This is a feature request for the Azure AD provider :
Step to reproduce :
Create a key in the Azure portal.
Use the following option  :"signInAudience": "AzureADMyOrg"
(which means only users in my AD are able to authenticate)
Bug

Sign in failed ServerError: AADSTS50194: Application 'app_id 'is not configured as a multi-tenant application. Usage of the /common endpoint is not supported for such applications created after '10/15/2018'. Use a tenant-specific endpoint or configure the application to be multi-tenant.

Request
Could we consider adding an option for the Azure provider  :
If @Input() azureTenantId is not empty then use the following endpoint :
https://login.microsoftonline.com/MY_TENANT_NAME
( instead of https://login.microsoftonline.com/common)
Thanks

sorry, wrong github url :)


add: angular three logo

Checklist for logo submission

[x] Logo file added to the logos folder
[x] Created a new entry in metadata.json (only name is mandatory)
[x] Logo is an SVG with vector paths (no embedded pixel image)
[x] The logo fills the image and there is no white margin (please remove the white margin if there is any 🙂 )

Hi Chau, can you please remove the margin around the logo? Thank you! 🙂

@fmalcher Used the wrong logo 🤦♂. Pushed the update, can you please double check?

Cool thanks, LGTM 😇

Thanks @nartc 🙏


Adding automated documentation for PyCPD

Updated docstrings of files so they are complete
Added Makefile to root directory that allows easy running of pre-specified commands (build, doc, test, etc.)
Updated README to explain optional usage of make for multiple use cases
Added command to Makefile to automatically build docs to /docs subfolder

The docs are built using pdoc3 which is extremely straightforward:

https://pdoc3.github.io/pdoc/

Added github action script to ./github/workflows/docs.yml that should auto compile docs on new push to master.

The github action should then publish these docs on the repositories github pages.
Details about the workflow are at these two links:

https://pdoc.dev/docs/pdoc.html#deploying-to-github-pages
https://github.com/mitmproxy/pdoc/blob/main/.github/workflows/docs.yml

@siavashk can you please go to the settings tab on the repository & enable GitHub Actions and GitHub Pages. This should enable the setup GitHub Actions to automatically compile the docs & publish on push to master. There might be some bugs in doing that, if there are I am happy to look into them.
Once this is complete, then we have all requirements for the manuscript submission to JOSS and I will make that submission.
If you pull this branch to your local computer you should be able to open  .../pycpd/docs/pycpd/index.html in your browser to preview the documentation.

Should be done. Let me know if you need anything else on my end.


GEODE-6762: First part - check is there proxy to notify

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[*] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[*] Is your initial contribution a single, squashed commit?

[*] Does gradlew build run cleanly?

[*] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

@nabarunnag would you be able to review in case I missed anything else?

Changes look good with initial testing. Merging the PR and monitoring if there are unknown effects.


Error while cmd execution

I am having issues with downloading the iso file. Some files are downloading normally and some are failing.
Here is my download log:
https://pastebin.com/517pH2j5

Just keep trying, this is not an issue of this installer.


⚠ Cioos Pacific CKAN Sitemap has degraded performance

In 90c2309, Cioos Pacific CKAN Sitemap (https://catalogue.cioospacific.ca/sitemap/sitemap-1.xml) experienced degraded performance:

HTTP code: 200
Response time: 6928 ms

Resolved: Cioos Pacific CKAN Sitemap performance has improved in af69ed9 after 8 minutes.


bump jedi compatibility: compare to Path-like object

See https://github.com/palantir/python-language-server/pull/901

The CI failures are unrelated, I will send a fix in a subsequent PR. Thanks @bnavigator!


[core-lro] Check for string type before calling toLowerCase()

Currently, we are trying to call toLowerCase() on a response body.status. However, it is possible that the body has a status property that is not a string, and we crash.
This problem was surfaced when adding tests in the CodeGen

Perhaps add a changelog entry and increment the patch version?


Error on cold start firestore-send-email

[READ] Step 1: Are you in the right place?
Issues filed here should be about bugs for a specific extension in this repository.
If you have a general question, need help debugging, or fall into some
other category use one of these other channels:

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general Firebase discussion, use the firebase-talk
google group.
To file a bug against the Firebase Extensions platform, or for an issue affecting multiple extensions, please reach out to
Firebase support directly.

[REQUIRED] Step 2: Describe your configuration

Extension name: firestore-send-email
Configuration values (redact info where appropriate):

all config require (extension is working, except after a cold start)

[REQUIRED] Step 3: Describe the problem
Steps to reproduce:
firestore-send-email throw an unhandled error at cold start :
Unhandled error occurred during processing: { Error
    at Http2CallStream.call.on (/srv/node_modules/@grpc/grpc-js/build/src/client.js:96:45)
    at emitOne (events.js:121:20)
    at Http2CallStream.emit (events.js:211:7)
    at process.nextTick (/srv/node_modules/@grpc/grpc-js/build/src/call-stream.js:71:22)
    at _combinedTickCallback (internal/process/next_tick.js:132:7)
    at process._tickDomainCallback (internal/process/next_tick.js:219:9)
  code: 13,
  details: '',
  metadata: Metadata { options: undefined, internalRepr: Map {} },
  note: 'Exception occurred in retry method that was not classified as transient' }

Expected result
Mail send / or send retry
Actual result
Mail not sent and not retried

Thanks for the report! @laurenzlong would you be able to help take a look at this?

I think it'll be linked to https://github.com/firebase/firebase-functions/issues/536
A problem in the grpc implementation.
In my own functions I have the same problem and I rollback dependencies to  :
"firebase-admin": "7.4.0",
"firebase-functions": "2.3.1"

Thanks for the helpful issue link @rphlmr! The best course of action is to implement the suggestion in https://github.com/firebase/firebase-functions/issues/536#issuecomment-531923813. I confirmed with Sebastian, author of that comment, who works on Firestore, and he confirmed that was the most reliable thing to do at the moment. This bug also affects not just firestore-send-email, but other extensions that write to Firestore also. I'll make a PR for this.

Hi :)
Thanks for the PR.

Hi @rphlmr if you would like to be informed of new releases, you can click the "watch" button at the top right corner of this page, and then select "releases only".

Thanks everyone for the 0.1.1 ;)

You're welcome! Thanks for reporting!


Function argument named object is not escaped in function body

When a function parameter has an escaped name, like object, the generated code does not escape usages in the generated function body.
import io.mockative.*

interface DummyInterface {
  fun blah(`object`: String)
}

@Mock
val mockDummyInterface = mock(classOf<DummyInterface>())

e: file:///Users/x/projects/project/build/generated/ksp/test/kotlin/DummyInterfaceMock.Mockative.kt:12:26 Expecting a class body

Generated code
listOf<Any?>(object)) - object should be escaped
import io.mockative.Invocation
import io.mockative.Mockable
import kotlin.Any
import kotlin.String
import kotlin.Unit
import kotlin.collections.listOf

public class DummyInterfaceMock : Mockable(stubsUnitByDefault = false), DummyInterface {
  public override fun blah(`object`: String): Unit = invoke<Unit>(Invocation.Function("blah",
      listOf<Any?>(object)), true)
}

Hi @aSemy
Thank you for your patience. I have addressed this issue in v1.4.0 which I released this morning.


编译ARM64版本失败

一、编译环境
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.2 LTS
Release:        22.04
Codename:       jammy
Linux version 5.15.0-1030-oracle (buildd@bos02-arm64-061) (gcc (Ubuntu 11.3.0-1ubuntu1~22.04) 11.3.0, GNU ld (GNU Binutils for Ubuntu) 2.38) #36-Ubuntu SMP Wed Feb 15 05:57:14 UTC 2023
二、编译过程及错误信息
/tmp/TrojanRust# cargo build --release
Compiling serde_json v1.0.64
Compiling quinn v0.9.3
Compiling trojan-rust v0.7.2 (/tmp/TrojanRust)
Compiling constant_time_eq v0.2.4
error: failed to run custom build command for trojan-rust v0.7.2 (/tmp/TrojanRust)
Caused by:
process didn't exit successfully: /tmp/TrojanRust/target/release/build/trojan-rust-8bbe07b6d9abc75a/build-script-build (exit status: 101)
--- stdout
cargo:rerun-if-changed=proto/transport.proto
cargo:rerun-if-changed=proto
--- stderr
thread 'main' panicked at '
Could not find protoc installation and this build crate cannot proceed without
this knowledge. If protoc is installed and this crate had trouble finding
it, you can set the PROTOC environment variable with the specific path to your
installed protoc binary.
For more information: https://docs.rs/prost-build/#sourcing-protoc
', /root/.cargo/registry/src/github.com-1ecc6299db9ec823/prost-build-0.11.0/src/lib.rs:1227:10
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

 If protoc is installed and this crate had trouble finding
it, you can set the PROTOC environment variable with the specific path to your
installed protoc binary.
For more information: https://docs.rs/prost-build/#sourcing-protoc
', /root/.cargo/registry/src/github.com-1ecc6299db9ec823/prost-build-0.11.0/src/lib.rs:1227:10
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

 If protoc is installed and this crate had trouble finding
it, you can set the PROTOC environment variable with the specific path to your
installed protoc binary.
For more information: https://docs.rs/prost-build/#sourcing-protoc
', /Users/attorneyfan/.cargo/registry/src/github.com-1ecc6299db9ec823/prost-build-0.11.0/src/lib.rs:1227:10
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

搞定了

编译成功运行依然出现错误：
thread 'main' panicked at 'Mismatch between definition and access of config. Could not downcast to TypeId { t:<PHONE_NUMBER>752515272 }, need to downcast to TypeId { t:<PHONE_NUMBER>8916295734 }
', /Users/attorneyfan/.cargo/registry/src/github.com-1ecc6299db9ec823/clap-4.1.4/src/parser/error.rs:30:9
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

运行依然失败：
trojan-rust -c /tmp/config.json
thread 'main' panicked at 'Mismatch between definition and access of config. Could not downcast to TypeId { t:<PHONE_NUMBER>752515272 }, need to downcast to TypeId { t:<PHONE_NUMBER>818954440 }
', /root/.cargo/registry/src/github.com-1ecc6299db9ec823/clap-4.1.4/src/parser/error.rs:30:9
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

编译需要安装protoc编译器https://grpc.io/docs/protoc-installation/，本来是不用的，后来tonic包改成默认调用系统的protoc所以就需要了

错误显示的是config.json格式错误，我猜你是不是把trojan的密码当成了整数的形式？
另外参照repo里的文件，改了好几版，都不行，不清楚原因

Inbound没有mode

您说“Inbound没有mode”，您贴出来的示例却有

我的意思是你贴出来的配置文件里面inbound没有写，所以导致的报错，你给我的那个配置文件里面没有mode，所以会出问题。不过你贴出来的那个错误确实是一个bug，之前在更新clap的时候改的有问题，你重新拉取一下更新 git pull，然后再编译应该就好了。

重新编译了，不报错，但还是不能工作
运行trojan-rust --config ./config.json后，不产生任何日志，也不能翻墙

RUST_LOG=info ./trojan-rust ...

需要设置环境变量打开log，这个readme有写，默认没有log。至于为什么不能翻墙要看具体错误才能知道。

[2023-03-07T01:09:06Z INFO  trojan_rust] Starting TCP server to accept inbound traffic
[2023-03-07T01:09:07Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:49606
[2023-03-07T01:09:07Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T01:09:07Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:49606 has finished
[2023-03-07T01:09:09Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:49608
[2023-03-07T01:09:09Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T01:09:09Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:49608 has finished
[2023-03-07T01:09:10Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:49610
[2023-03-07T01:09:11Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T01:09:11Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:49610 has finished
[2023-03-07T01:09:11Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:49612
[2023-03-07T01:09:11Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T01:09:11Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:49612 has finished
[2023-03-07T01:09:14Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:49614
[2023-03-07T01:09:14Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T01:09:14Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:49614 has finished
[2023-03-07T01:09:18Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:49616
[2023-03-07T01:09:19Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T01:09:19Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:49616 has finished

产生日志了，但还是不能翻墙
确认服务端是正常的，使用trojan-r等trojan客户端都能连上

看起来没有什么错误，你看看你trojan服务器这边有没有收到连接请求。还有你是怎么用什么把流量转发到socks端的？好像你的inbound流量不是socks的

都是Firefox浏览器的流量

firefox里强制开启了dns over https

看着没问题，我自己也是用firefox代理的，我本地测试一下

[2023-03-07T01:09:06Z INFO trojan_rust] Starting TCP server to accept inbound traffic [2023-03-07T01:09:07Z INFO trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:49606 [2023-03-07T01:09:07Z INFO trojan_rust::proxy::tcp::handler] Connection finished [2023-03-07T01:09:07Z INFO trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:49606 has finished [2023-03-07T01:09:09Z INFO trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:49608 [2023-03-07T01:09:09Z INFO trojan_rust::proxy::tcp::handler] Connection finished [2023-03-07T01:09:09Z INFO trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:49608 has finished [2023-03-07T01:09:10Z INFO trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:49610 [2023-03-07T01:09:11Z INFO trojan_rust::proxy::tcp::handler] Connection finished [2023-03-07T01:09:11Z INFO trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:49610 has finished [2023-03-07T01:09:11Z INFO trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:49612 [2023-03-07T01:09:11Z INFO trojan_rust::proxy::tcp::handler] Connection finished [2023-03-07T01:09:11Z INFO trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:49612 has finished [2023-03-07T01:09:14Z INFO trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:49614 [2023-03-07T01:09:14Z INFO trojan_rust::proxy::tcp::handler] Connection finished [2023-03-07T01:09:14Z INFO trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:49614 has finished [2023-03-07T01:09:18Z INFO trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:49616 [2023-03-07T01:09:19Z INFO trojan_rust::proxy::tcp::handler] Connection finished [2023-03-07T01:09:19Z INFO trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:49616 has finished

从日志看，每一个connection的生命周期以微秒计，收到请求后立马就finish了

都是Firefox浏览器的流量

Firefox的配置一直都这样，配合其他代理工具一直都能正常工作

我试了一下，确实有bug，socks5协议从一开始时间就有个小bug会导致读不到domain name，另外写trojan request的时候也会丢掉这个domain name的长度信息。我之前一直没发现，因为我之前没打开doh, 所以所有请求都是先查dns然后再连，所以这个个问题一直没有发现。你再拉取一下最新的更新，应该就好了

重新拉取和编译了，貌似还是不行
[2023-03-07T06:01:56Z INFO  trojan_rust] Starting TCP server to accept inbound traffic
[2023-03-07T06:01:58Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53422
[2023-03-07T06:01:58Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:01:58Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53422 has finished
[2023-03-07T06:01:59Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53424
[2023-03-07T06:01:59Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:01:59Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53424 has finished
[2023-03-07T06:01:59Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53426
[2023-03-07T06:02:00Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:00Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53426 has finished
[2023-03-07T06:02:00Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53428
[2023-03-07T06:02:00Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53430
[2023-03-07T06:02:01Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:01Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53428 has finished
[2023-03-07T06:02:01Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:01Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53430 has finished
[2023-03-07T06:02:01Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53432
[2023-03-07T06:02:02Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:02Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53432 has finished
[2023-03-07T06:02:02Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53434
[2023-03-07T06:02:03Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:03Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53434 has finished
[2023-03-07T06:02:17Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53436
[2023-03-07T06:02:18Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:18Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53436 has finished
[2023-03-07T06:02:27Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53438
[2023-03-07T06:02:27Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53440
[2023-03-07T06:02:28Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:28Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53438 has finished
[2023-03-07T06:02:28Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:28Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53440 has finished
[2023-03-07T06:02:28Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53442
[2023-03-07T06:02:28Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:28Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53442 has finished
[2023-03-07T06:02:28Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53444
[2023-03-07T06:02:29Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:29Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53444 has finished
[2023-03-07T06:02:30Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53446
[2023-03-07T06:02:30Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:30Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53446 has finished
[2023-03-07T06:02:31Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53448
[2023-03-07T06:02:31Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:31Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53448 has finished
[2023-03-07T06:02:32Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53450
[2023-03-07T06:02:32Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:32Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53450 has finished
[2023-03-07T06:02:32Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53452
[2023-03-07T06:02:33Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:33Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53452 has finished
[2023-03-07T06:02:35Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53454
[2023-03-07T06:02:35Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:35Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53454 has finished
[2023-03-07T06:02:35Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53456
[2023-03-07T06:02:36Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:36Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53456 has finished
[2023-03-07T06:02:36Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53458
[2023-03-07T06:02:37Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:37Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53458 has finished
[2023-03-07T06:02:37Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53460
[2023-03-07T06:02:38Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:38Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53460 has finished
[2023-03-07T06:02:38Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53462
[2023-03-07T06:02:39Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:39Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53462 has finished
[2023-03-07T06:02:46Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53464
[2023-03-07T06:02:47Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:47Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53464 has finished
[2023-03-07T06:02:50Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53466
[2023-03-07T06:02:50Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:50Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53466 has finished
[2023-03-07T06:02:52Z INFO  trojan_rust::proxy::tcp::server] Received new connection from <IP_ADDRESS>:53468
[2023-03-07T06:02:52Z INFO  trojan_rust::proxy::tcp::handler] Connection finished
[2023-03-07T06:02:52Z INFO  trojan_rust::proxy::tcp::server] Connection from <IP_ADDRESS>:53468 has finished

彻底禁用doh也一样不行

我本地测试了没有任何问题，这是我客户端配置的文件，你看看你的服务端有没有收到请求
{
    "inbound": {
        "protocol": "SOCKS",
        "address": "<IP_ADDRESS>",
        "port": 10808,
        "mode": "TCP"
    },
    "outbound": {
        "protocol": "TROJAN",
        "address": "<IP_ADDRESS>",
        "port": 8081,
        "secret": "123123",
        "mode": "TCP",
        "tls": {
            "host_name": "example.com",
            "allow_insecure": false
        }
    }
}

服务端日志如下：
Mar 07 06:13:40 workstation[29822]: [2023-03-07 06:13:40] [ERROR] ip.ip.ip.ip:54977 SSL handshake failed: wrong version number
Mar 07 06:13:40 workstation[29822]: [2023-03-07 06:13:40] [INFO] ip.ip.ip.ip:54977 disconnected, 0 bytes received, 0 bytes sent, lasted for 0 seconds
Mar 07 06:13:41 workstation[29822]: [2023-03-07 06:13:41] [ERROR] ip.ip.ip.ip:54980 SSL handshake failed: wrong version number
Mar 07 06:13:41 workstation[29822]: [2023-03-07 06:13:41] [INFO] ip.ip.ip.ip:54980 disconnected, 0 bytes received, 0 bytes sent, lasted for 0 seconds
Mar 07 06:13:42 workstation[29822]: [2023-03-07 06:13:42] [ERROR] ip.ip.ip.ip:54985 SSL handshake failed: wrong version number
Mar 07 06:13:42 workstation[29822]: [2023-03-07 06:13:42] [INFO] ip.ip.ip.ip:54985 disconnected, 0 bytes received, 0 bytes sent, lasted for 0 seconds
Mar 07 06:13:42 workstation[29822]: [2023-03-07 06:13:42] [ERROR] ip.ip.ip.ip:54986 SSL handshake failed: wrong version number
Mar 07 06:13:42 workstation[29822]: [2023-03-07 06:13:42] [INFO] ip.ip.ip.ip:54986 disconnected, 0 bytes received, 0 bytes sent, lasted for 0 seconds
Mar 07 06:13:42 workstation[29822]: [2023-03-07 06:13:42] [ERROR] ip.ip.ip.ip:54984 SSL handshake failed: wrong version number
Mar 07 06:13:42 workstation[29822]: [2023-03-07 06:13:42] [INFO] ip.ip.ip.ip:54984 disconnected, 0 bytes received, 0 bytes sent, lasted for 0 seconds

应该是ssl版本号的问题，你服务端支持tls1.3吗？你用的是什么代理来处理tls？

服务端使用的是原版的trojan-gfw，并且指定了只能使用tls 1.3的cihper suite，不知道是不是这个原因导致上述错误
"cipher": "TLS_AES_128_GCM_SHA256:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_256_GCM_SHA384",
"prefer_server_cipher": true,

服务端使用的是原版的trojan-gfw，并且指定了只能使用tls 1.3的cihper suite，不知道是不是这个原因导致上述报错
"cipher": "TLS_AES_128_GCM_SHA256:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_256_GCM_SHA384", "prefer_server_cipher": true,

服务端删掉相关字段，一模一样的报错，提示ssl版本错误

你这个server可能不支持tls1.3，默认的话rustls只支持tls1.3, 如果要打开1.2的话，你要去项目目录下的Cargo.toml, 然后把
rustls = { version = "0.20", features = ["dangerous_configuration"] }

改成
rustls = { version = "0.20", features = ["dangerous_configuration", "tls12"] }

然后你重新编译一下试试，代码我就不提交了，自搭vps其实没必要用tls12

这个地方 https://github.com/cty123/TrojanRust/blob/main/Cargo.toml#L18

好的 谢谢大佬


Add support for internationalization (i18n)

Describe the feature request
Description of the feature request hereDescription: The taiko-mono application currently only supports English, but we want to make it accessible to users who speak other languages. We need to add support for internationalization (i18n) so that the application can be easily translated into other languages.
Describe alternatives you've considered
Description of the alternatives you've considered here. Implement the custom i18n solution throughout the application to enable language switching and translation of all text.
Additional context
Additional context hereSkills needed: Familiarity with web development, experience with i18n libraries/frameworks.
To work on this issue, you could:
Research i18n libraries/frameworks that are compatible with the taiko-mono application and choose the one that best fits our needs.
Add the chosen i18n library/framework to the taiko-mono application.
Create language files for each language that we want to support, containing translations for all of the text in the application.
Implement the i18n library/framework throughout the application to enable language switching and translation of all text.
Test the application thoroughly to ensure that all text is translated correctly and that the language switching functionality works as expected.
Create a pull request from your forked repository to the main taiko-mono repository.
Wait for feedback and iterate on your changes as necessary.

Localizing something too early is really a bad idea. I'd wait until Taiko core tech is ready for mess-addoption.


Screen Dependencies Better

Right now I purely just look for the dependency and do not verify that the version and/or components are present.  I also don't check to see if the cmake args are the same.

This has been fixed for a while.


feat: RND-112: Improve GroundingDINO

spliting GroundingDINO (object detection) and GroundingSAM (image segmentation) into 2 separate ML backends
remove hard requirement for <BrushLabels> to be present in labeling config for GroundingSAM
parametrize model checkpoints
fix bug with prompt mistakenly retrieved from the first result
make automatic bounding boxes editable
use threshold controls for boxes and texts (work in progress...)
make prompt persistent across different labeling task after submission

/git merge master

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.97%. Comparing base (f2ab2c8) to head (aaf69b5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
- Coverage   51.38%   46.97%   -4.42%
==========================================
  Files          38       11      -27
  Lines        2635      611    -2024
==========================================
- Hits         1354      287    -1067
+ Misses       1281      324     -957

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


improve add db and table name in create routine load job log

Proposed changes
Linking transaction id and table info can better troubleshoot bug.


Set default minimum borgmatic version to match config format

Potential fix for #126 @burned42

@m3nu thanks, we just tested this change by reverting one server back to the old borgmatic version incompatible with the config this role currently generates and applying the role from this branch works just as expected and updates borgmatic and makes it work again. We also verified with a server that had the current borgmatic version already and it didn't break by applying this role from this branch. So LGTM :+1:

Great! Thanks for testing. Merged.


:seedling: Adopt react-refesh in dev mode to allow hot component replacement

By adopting react-refresh in webpack dev configurations, via ReactRefreshWebpackPlugin and ReactRefreshTypeScript, developers can now live edit react components without loosing state.  This means components are replaced on change without forcing a page reload.
The webpack-dev.ts configuration is using mergeWithRules() to both merge the common configuration, and to replace the ts-loader options.  The dev options enable react-refresh.
Add ForkTsCheckerWebpackPlugin to dev configuration to do async typescript type checking.  It isn't needed on the prod config since the build runs full tsc before running webpack.  Any type errors will stop the build before progressing to webpack.
In all webpack configs, module/rules now come before plugins to maintain visual consistency.

An example of changing a component that does not force a page reload:
https://github.com/konveyor/tackle2-ui/assets/3985964/f86c9f8b-fe1f-484b-adfc-7d342502c394


WIFI:1669 TIP 1.0 Update SDK components  in release 1.0 branch

make sure wlan-ui github action works for both master and release 1.0 branch.
versioning tag on master unchanged until TIP decides on the versioning labeling.

make sure wlan-ui github action works for both master and release 1.0 branch.
versioning tag on master branch unchanged until TIP decides on the versioning labeling.


Evaluation metrics is only perplexity?

Hi!
Thanks for releasing the code. I have one question about the evaluation. It seems in the current version of the code, you only evaluate perplexity? For example, I think Table 1 of the paper, its metric should be Accuracy for most QA tasks? It seems current eval_harness.py only considers ppl.

never mind, I found its in the lm_eval


Generate spec for response with string content type

Problem statement
I need generate spec from server and I have response with content type: string .
Documentation have only example for  content type: object. Therefor may be I did something wrong.
I created following response object:
// swagger:route GET /status GetServiceStatus
//
// Service status.
//
// responses:
//  200: ServiceStatusResponse
func GetServiceStatus(w http.ResponseWriter, r *http.Request) {
	resp := ServiceStatusResponse{Status:"OK"}
	resp.Write(w)
}

// ServiceStatusResponse is an response with service status.
//
// swagger:response ServiceStatusResponse
type ServiceStatusResponse struct {
	// Status
	//
	// in: body
	Status string
}

generated specification doesn't have body
  "paths": {
    "/version": {
      "get": {
        "summary": "Service version number.",
        "operationId": "Version",
        "responses": {
          "200": {
            "$ref": "#/responses/VersionResponse"
          }
        }
      }
    }
  },
  "responses": {
    "ServiceStatusResponse": {
      "description": "ServiceStatusResponse is an response with service status."
    }
  }

Then I tried to create specification manually and generate server from it:
swagger: '2.0'
info:
  title: Service.
  version: 0.0.1
paths:
  /status:
    get:
      responses:
        '200':
          description: 'service status'
          schema:
            type: string

In result I have response:
/*GetStatusOK service status

swagger:response getStatusOK
*/
type GetStatusOK struct {

	/*
	  In: Body
	*/
	Payload string `json:"body,omitempty"`
}

As you can see comments of this response different from documentation
I tried generate spec from this code:
"paths": {
    "/status": {
      "get": {
        "description": "GetStatus get status API",
        "operationId": "getStatus"
      }
    }
  },
  "responses": {
    "getStatusOK": {
      "description": "GetStatusOK service status",
      "headers": {
        "body": {
          "type": "string",
          "description": "In: Body"
        }
      }
    }
  }

path doesn't have responses
response 'body' inside 'headers'

Environment
swagger version: 0.14.0
go version: 1.10.2
OS:   Windows 10

looks indeed like a bug in the scanner... I'm glad the spec=>code works well.

can you show a project with all the files?

secondly if this is a json api you should never return string.
There are only 2 valid types you can return in json: {} or [] nothing else is a json object.

It is just minimalist sample project where I have issue
// Package main AwesomeProject
//
// AwesomeProject service provide some functionality
//
// Schemes: http
// BasePath: /
// Version: 0.0.1
// Contact: John<EMAIL_ADDRESS>http://john.doe.com
//
// swagger:meta
package main

import (
	"log"
	"net/http"
)

func main() {
	http.HandleFunc("/status", GetServiceStatus)
	log.Fatal(http.ListenAndServe(":3000", nil))
}

// swagger:route GET /status GetServiceStatus
//
// Service status.
//
// responses:
//  200: ServiceStatusResponse
func GetServiceStatus(w http.ResponseWriter, r *http.Request) {
	resp := ServiceStatusResponse{Status: "OK"}
	resp.Write(w)
}

// ServiceStatusResponse is an response with service status.
//
// swagger:response ServiceStatusResponse
type ServiceStatusResponse struct {
	// Status
	//
	// in: body
	Status string
}

func (r *ServiceStatusResponse) Write(w http.ResponseWriter) {
	w.WriteHeader(200)
	w.Write([]byte(r.Status))
}

I assume you want {"Status":"OK"} to come out
In that case you need to do this:
// swagger:route GET /status GetServiceStatus
//
// Service status.
//
// responses:
//  200: body:ServiceStatusResponse
func GetServiceStatus(w http.ResponseWriter, r *http.Request) {
	resp := ServiceStatusResponse{Status: "OK"}
	resp.Write(w)
}

// ServiceStatusResponse is an response with service status.
type ServiceStatusResponse struct {
	Status string
}

I already have API and need just make specification for it, therefore I can't just change response type.
@casualjim is your sample works ?
for me it doesn't generate 'ServiceStatusResponse ' response
if add  swagger:response it still generate bad result:
{
  "swagger": "2.0",
  "info": {
    "description": "Package main AwesomeProject",
    "version": "0.0.1"
  },
  "paths": {
    "/status": {
      "get": {
        "summary": "Service status.",
        "operationId": "GetServiceStatus",
        "responses": {
          "200": {
            "description": "ServiceStatusResponse",
            "schema": {
              "$ref": "#/definitions/ServiceStatusResponse"
            }
          }
        }
      }
    }
  },
  "responses": {
    "ServiceStatusResponse": {
      "description": "ServiceStatusResponse is an response with service status.",
      "headers": {
        "Status": {
          "type": "string"
        }
      }
    }
  }
}

in any case I don't have issues to generate json response, but I need 'string' and OpenAPI specification allows define it.

@Radon22, one way to get this by defining a new type as below
// swagger:response stringResponse
//in: body
type _ string

and using in responses as below
//responses:
// 200: stringResponse

Hi @vinitkumar-coherent
Do you know how to add example value for this simple string?
I tried this but seems not work:
// swagger:response stringResponse
//in: body
//example: example_string
type _ string


No text being translated

Hey there! love this app, actually it used to work fine, after updating windows and coming back to it, seems it doesnt work now, ive set it up many different ways, but no results are showing, regardless of if i use overlay or text box etc, when choosing window i can see that the console is doing something but my NLLB api isnt recieving any requests, ive tried with deep l and google but both doing nothing
when trying to do image adjustment, i do noticed it pops up with an error, im not sure if this applies to it but maybe it does
See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.
************** Exception Text **************
System.ArgumentException: Parameter is not valid.
at System.Drawing.Bitmap..ctor(Int32 width, Int32 height)
at MORT.OcrAreaForm.ShowColorPicker(Boolean isShowResult, Boolean isUseRgb, Boolean isUseHSv, Boolean isUseThreshold, ColorGroup colorGroup, Int32 threshold) in D:\project\MORT\64bit\MORT\MORT\OcrAreaForm.cs:line 478
at MORT.FormManager.ShowColorPickResult(Boolean isUseRgb, Boolean isUseHSv, Boolean isUseThreshold, ColorGroup colorGroup, Int32 threshold) in D:\project\MORT\64bit\MORT\MORT\Manager\FormManager.cs:line 478
at MORT.Form1.OnClickShowImgResult(Object sender, EventArgs e) in D:\project\MORT\64bit\MORT\MORT\Form1Button.cs:line 70
at System.Windows.Forms.Button.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ButtonBase.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, WM msg, IntPtr wparam, IntPtr lparam)
************** Loaded Assemblies **************
System.Private.CoreLib
Assembly Version: <IP_ADDRESS>
Win32 Version: <IP_ADDRESS>605
CodeBase: file:///C:/Program%20Files/dotnet/shared/Microsoft.NETCore.App/7.0.2/System.Private.CoreLib.dll

hello! The cause of the problem has been determined.
This problem occurred because the OCR area was not set properly.
Try -> Search Button Click -> Default Click or MORT -> Additional Tab -> Reset Config then try again

hello!
The above issue has been resolved in the latest version
https://github.com/killkimno/MORT/releases/tag/1.270


Fixed #640


Starting the app shows a grey screen and freezes

Starting the BC Wallet app can result in a state where it just displays a grey screen and cannot proceed. This was reported by one users who has, up to this point, been using the wallet for months without issue.
Android 14, Pixel 6.
BC Wallet 1.0.16
https://github.com/bcgov/bc-wallet-mobile/assets/390891/41e2bdac-0d88-42c6-a567-7aa6921debbc

Fixed by @wadeking98 in PR #1914.


ci: merge staging to master

This is an automatic PR generated by the pipeline CI/CD. This will be automatically fast-forward merged if successful.

Pipeline Attempt on 552694135 for 1c285e5e52618c342042514272cb1caba4381d41
https://gitlab.com/MatrixAI/open-source/typescript-demo-lib/-/pipelines/552694135

Pipeline Succeeded on 552694135 for 1c285e5e52618c342042514272cb1caba4381d41
https://gitlab.com/MatrixAI/open-source/typescript-demo-lib/-/pipelines/552694135


sparse matrix times dense matrix

I'm wondering if OpenBlas support the multiplication between a sparse matrix and a dense matrix.
Thanks
Jiaen

OpenBLAS does not have specialized code for handling sparse matrix operations efficiently, use a higher level code like SuiteSparse for that

https://github.com/OpenMathLib/OpenBLAS/wiki/Faq#sparse

I will look into this. Thanks for the advice!
Best
Jiaen
From: Martin Kroeker @.>
Sent: Tuesday, April 30, 2024 04:57
To: OpenMathLib/OpenBLAS @.>
Cc: Jiaen Liu @.>; Author @.>
Subject: Re: [OpenMathLib/OpenBLAS] sparse matrix times dense matrix (Issue #4669)
EXTERNAL MAIL
https://github.com/OpenMathLib/OpenBLAS/wiki/Faq#sparsehttps://urldefense.com/v3/__https:/github.com/OpenMathLib/OpenBLAS/wiki/Faq*sparse__;Iw!!MznTZTSvDXGV0Co!FgcYWAfP9D7tS2vbM6UfWa4A66_uhVIrWcQfW_dCIernyFZB7g0F8j0AwDhX4FWBOBx9vU8Pal1lxhLJSMJpiAjBhZTnQytcAg$
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/OpenMathLib/OpenBLAS/issues/4669*issuecomment-2084871364__;Iw!!MznTZTSvDXGV0Co!FgcYWAfP9D7tS2vbM6UfWa4A66_uhVIrWcQfW_dCIernyFZB7g0F8j0AwDhX4FWBOBx9vU8Pal1lxhLJSMJpiAjBhZTTxSFXxQ$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AJ3W3QD5PGUMRKW535M2ACLY75TFJAVCNFSM6AAAAABG7H2VH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBUHA3TCMZWGQ__;!!MznTZTSvDXGV0Co!FgcYWAfP9D7tS2vbM6UfWa4A66_uhVIrWcQfW_dCIernyFZB7g0F8j0AwDhX4FWBOBx9vU8Pal1lxhLJSMJpiAjBhZQ997XWzQ$.
You are receiving this because you authored the thread.Message ID: @.***>
CAUTION: This email originated from outside UTSW. Please be cautious of links or attachments, and validate the sender's email address before replying.

UT Southwestern
Medical Center
The future of medicine, today.


Plugins bundled in jenkins.war not loaded

Using the following Dockerfile to install plugins the jenkins image with a patched install-plugins.sh to fix https://github.com/jenkinsci/docker/pull/309
FROM jenkins
...
RUN install-plugins.sh git

results in the following error when starting jenkins
SEVERE: Failed to install matrix-project: One or more dependencies could not be resolved for matrix-project : script-security (1.13), junit (1.2)
SEVERE: Failed to install git: One or more dependencies could not be resolved for git : matrix-project (1.6)

Looking at the output from install-plugins.sh you can see that script-security:1.13 and junit:1.2-beta-4 is bundled in jenkins.war, so the plugins should be available to jenkins.
 > matrix-project depends on script-security:1.13,junit:1.2
...
Skipping already bundled dependency script-security:1.13 (1.13 <= 1.13)
Skipping already bundled dependency junit:1.2 (1.2 <= 1.2-beta-4)

The 1.2 <= 1.2-beta-4 problem is probably fixed in https://github.com/jenkinsci/docker/pull/307, but the script-security version number is an exact match, so it should be possible to use the bundled version.

script-securit, matrix-project, junit are in the WEB-INF/detached-plugins/ dir and seems those are not loaded on startup

from http://jenkins-ci.361315.n4.nabble.com/Revisiting-bundled-plugins-td4763593i80.html

All the plugins that were bundled in the jenkins.war are still bundled (in WEB-INF/detached-plugins), but are only conditionally loaded on upgrade (not loaded at all on a new install - the wizard handles that).

so install-plugins needs to not count on them as installed

Thanks for the update. That was what I ended up doing to be able to move forward, basically just commenting out bundledPlugins="$(bundledPlugins)".


synastic rubocop returns "Command Terminated" on macvim

This may be my error but my vimrc file works on my linux machine and not on osx so it might not be. Thanks in advance for any help you can give me, and for synastic, it's fantastic.
I'd like syntastic to run the MRI checker and then the rubocop checker and it does that. But the rubocop checker fails and I don't know why. I'm gonna try to put as much of my setup as I can here.
I'm running macvim 7.4 installed through homebrew and run from the command line.
Rubocop from the command line is on version 0.31.0 and works. It's output is below.
SynasticInfo returns:
Syntastic version: 3.6.0-83 (Vim 704, Darwin)
Info for filetype: ruby
Global mode: active
Filetype ruby is active
The current file will be checked automatically
Available checkers: mri rubocop
Currently enabled checkers: mri rubocop
I extracted the command that it looks like syntactic is trying to run and ran it on the command line. That seems to work fine.
rubocop -R --format emacs spec/models/pdn_importer_spec.rb
/spec/models/foo_spec.rb:29:7: C: Use snake_case for variable names.
/spec/models/foo_spec.rb:29:17: C: Do not use semicolons to terminate expressions.
SynasticCheck though gives me something like:
# syntastic: 682.927458: &shell = '/usr/local/bin/zsh', &shellcmdflag = '-c', &shellpipe = '2>&1| tee', &shellquote = '', &shellredir = '>%s 2>&1', &shellslash = 0, &shelltemp = 1, &shellxquote = '', &shellxescape = ''
# syntastic: 682.927719: UpdateErrors: default checkers
# syntastic: 682.928045: CacheErrors: default checkers
# syntastic: 682.928861: g:syntastic_aggregate_errors = 1
# syntastic: 682.929100: getcwd() = '/rails/root/'
# syntastic: 682.929524: CacheErrors: Invoking checker: ruby/mri
# syntastic: 682.930200: SyntasticMake: called with options: {'errorformat': '%-G%\m%.%#warning: %\%%(possibly %\)%\?useless use of == in void context,%-G%\%.%\%.%\%.%.%#,%-GSyntax OK,%E%f:%l: syntax error\, %m,%Z%p^,%W%f:%l: warning: %m,%Z%p^,%W%f:%l: %m,%-C%.%#', 'makeprg': 'ruby -w -T1 -c spec/models/foo_spec.rb', 'env': {'RUBYOPT': ''}}
# error list 2 of 3; 0 errors
# syntastic: 682.975444: getLocList: checker ruby/mri returned 0
# syntastic: 682.975895: CacheErrors: Invoking checker: ruby/rubocop
# syntastic: 682.976458: SyntasticMake: called with options: {'subtype': 'Style', 'errorformat': '%f:%l:%c: %t: %m', 'makeprg': 'rubocop -R --format emacs spec/models/foo_spec.rb'}
# Command terminated

# error list 2 of 3; 0 errors
# syntastic: 683.683708: getLocList: checker ruby/rubocop returned -1

The syntastic portion of my vimrc file is below.
let g:syntastic_always_populate_loc_list = 1
let g:syntastic_auto_loc_list = 0
let g:syntastic_check_on_open = 1
let g:syntastic_check_on_wq = 0
let g:syntastic_scss_checkers = ['sass', 'scss_lint']
let g:syntastic_ruby_checkers = ['mri', 'rubocop']
let g:syntastic_ruby_rubocop_args = "-R"
"coffeelint needs to be installed through npm, the rest are ruby gems.
let g:syntastic_coffee_checkers = ['coffee', 'coffeelint']
let g:syntastic_haml_checkers = ['haml', 'haml_lint']
let g:syntastic_aggregate_errors = 1
let g:syntastic_html_tidy_ignore_errors=[" proprietary attribute \"ng-"]

Thanks for your help and let me know what I can do.
~Thomas

"Command terminated" means the checker has crashed.  This post might provide an answer.  If it doesn't, please open your test file, set g:syntastic_debug to 3, run :SyntasticCheck rubocop, run :mes, and post the output.

That did it!
Thanks.
I set rvm into my path in .zshenv instead of .zshrc and everything is happy.


[Spaces] Add webUrl to Spaces endpoint

Is your feature request related to a problem? Please describe.
Client users need an easy way to open the root of a Space in the web browser. Then they can perform management tasks, that are not available in the clients itself.
Describe the solution you'd like
Add webUrl to Spaces endpoint
Describe alternatives you've considered
I thought about QuickLink creation, but not every user has the permission to do so.
Additional context

@micbar @fmoc @TheOneRing

The drives Graph API endpoint already provides webUrl, but the strings are just empty. The server just needs to fill in the right URL to show them in the browser. Then, the client should be able to enable these buttons.


try and document scp and sftp usage using pam_weblogin and smartshell

https://github.com/SURFscz/pam-weblogin/commit/8e94676481711890263c234ddf1985ed3cd967f0

This is the topic guide, a general introduction: https://wiki.surfnet.nl/display/SRAM/PAM+web+login
This is the how to, explaining which steps to take to perform a specific task: https://wiki.surfnet.nl/display/SRAM/Connect+a+PAM+web+login+service
What is this, exactly? https://wiki.surfnet.nl/display/SRAM/PAM+weblogin
It seems like two how-tos. One explaining how to install PAM web login and another how to use it in combination with SCP and SFTP?

It seems to me we should split this page: https://wiki.surfnet.nl/display/SRAM/PAM+weblogin

Introduction / Ready to try are copied from the topic guide on the wiki
Installation is copied from the readme, linked on the how to on the wiki
SCP and SFTP can be summarized to 'this just works, but not with smart shell'

I propose to move the remarks about SCP and SFTP to the topic guide and then remove this page.


Describe the simple benefit of this service.

Overview

describe benefits for specific users.
adjust service to the user.

This will be done after
#281


Web - Pressing space key applies focus to composer & scrolls comments at the same time

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open a report that has multiple, scrollable comments
Scroll to the bottom of comments
Remove focus from the main composer
Press 'Space' key

Expected Result:
The composer should not be focused and the report page should be scrolled.
Actual Result:
Composer is focused & report is scrolled making the function of space key less predictable.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/96a8d17e-dc90-4e65-b9c0-02aa5642f85c
https://github.com/Expensify/App/assets/93399543/3d49a0a2-b7c2-40e5-a973-1bcfa0ee6631
Expensify/Expensify Issue URL:
Issue reported by: @Natnael-guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690196594809449
View all open jobs on GitHub

@mountiny @JmillsExpensify I found this somewhat similar issue when looking into this one. It's similar in that it's an issue with clicking the space bar. In terms of expected behaviour, I would think we scroll the chat page and don't focus the composer in this case here. Would you agree with that?

@trjExpensify I agree the expected behaviour should be no focus and just scroll down

Cool, updating the OP's expected behaviour to make that clear. 👍 Moving on!

@samh-nl could you update your proposal to be in line with the expected behaviour as was stated here. I see that you stated it inside the alternative solutions, but I want this to be more clear as it should be go-to solution

In terms of expected behaviour, I would think we scroll the chat page and don't focus the composer in this case here. Would you agree with that?

I agree with this as well.

Thank you @samh-nl . Your solution is straightforward and is in line with expected behaviour.
I would choose @samh-nl proposal
🎀 👀 🎀 C+ reviewed

Proposal
Problem Statement:
Pressing the space key applies focus to the composer and scrolls through comments simultaneously, leading to an undesirable user experience.
Root Cause:
The root cause of this issue is that the function focusComposerOnKeyPress(e), responsible for handling keypress events, lacks a specific condition to prevent focusing the composer and performing simultaneous comment scrolling when the space key is pressed.
Proposed Changes:
To address the problem, I propose updating the focusComposerOnKeyPress(e) function to include a proper handling mechanism for the space key. By incorporating the necessary condition, we can prevent focusing the composer and avoid triggering the comment scrolling action when users press the space key.
Alternative Solution:
NA
Please review and consider this proposal to resolve the issue.

Thanks, @saalimzafar, for your proposal, but the other one has already been selected (here). Your proposal suggests the same fix as the chosen one.
bumping @grgia to review and assign contributor

It's okay @robertKozik

@grgia can you give this a secondary review please so we can keep it moving?

Thanks for the bump, I got a chance to review and @samh-nls proposal looks good, thank you!

Hi @grgia
I want to report a bug which I'm unable to do via github issue, I've already sent the emails  to constributors but got no response. Can you help me if possible?

Hi @saalimzafar you can submit bug reports via #expensify-bugs channel on slack

It seems that my invitation is not getting accepted @robertKozik
I already send the emails but no response so far.

PR is still in review, @grgia is back this week.

Yeah, we take into account things like the weekend and a delay on our internal review.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[X]  [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/21583
[X]  [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/21583/files#r1302944466
[X]  [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A -  it was rather unconsidered case of the PR, so I don't think we should extend the checklist or anything
[X]  [@robertKozik] Determine if we should create a regression test for this bug. N/A - same as above
[X]  [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

Okay perfect, thanks for confirming!
I'm going to be out of pocket tomorrow, so settled up with @natnael-guchima & @samh-nl today. Closing this out, thanks everyone!


Update scala3-compiler to 3.5.1

About this PR
📦 Updates org.scala-lang:scala3-compiler from 3.5.0 to 3.5.1
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (3.5.0).
You might want to review and update them manually.
.github/workflows/pr-checks.yml

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala3-compiler" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang", artifactId = "scala3-compiler" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

@mccartney, would you please issue a new release?


Bugfix: Use investigator ID and PI number instead of site ID and site number.

Expected Behavior
Use investigator ID instead of site ID because the latter isn't necessarily unique in real study data.
Current Behavior
Referencing clindata::rawplus_dm$siteid and clindata::ctms_site$site_num instead of clindata::rawplus_dm$invid and clindata::ctms_site$pi_number.
Possible Solution

update column references in workflows and codebase

Steps to Reproduce

Context (Environment)

Possible Implementation

Additional Comments

Likely that we just need updates in the mapping.yaml.


_.join in _.flow

In regular lodash, you can use join when chaining. To remain consistent, it would be nice to have _.join (and other native array methods that are missing) added to lodash-fp.

It is consistent as _.join is not a method on lodash and only available when chaining.


Add support for redirect responses

There was a slight issue with how redirects were being handled, in particular in the case that the redirect was blocked by the client. If a client uses the actual original response instead of following a redirect, this allows them to test for it.

Looks good, much appreciated 👍


How to distribute inference using multi-nodes via MPI?

Hi! How do I need to set up the MPI commands and cluster environment configuration for distributed inference use among multiple nodes?
For example, I want to implement pipeline and/or tensor parallelism on two machines with only one gpu each.
Thanks!

It should be same to single node.

@byshiue for the multi node inference. could you explains whether TP or PP used? Is there a way to use TP and PP together?

It depends on your hardwares, network bandwidth, model size and problem size. So, I cannot give a simple answer.
The high level ideas are:

TP requires more communication. So, it requires higher network bandwidht.
PP requires larger batch size to separate into micro batches.

Some extreme case:

If you use nvlink and the batch size is 1, TP should be better than PP.
If you use pcie and the batch size is 1024, input length is 512, output length is 10, PP should be better than PP.

@byshiue Thanks for the reply. Let's say if I have a scenarios requires TP=2, PP=4, the model needs to be split into 8 GPUs.
I only have nodes with 4 * A100-40G GPUs. In that case, I see TensorRT-LLM uses MPI for communication. I am new to this solution now, just curious why the GPU on the same node (TP part) will communicate with nvLink. and GPUs cross node will fall back to MPI (PP part) cpu communication automatically?

It depends on your hardware. Across nodes, the data can go through infiniband, Roce or pcie. But they called by nccl directly, we don't go through mpi.
We don't want the dependency of torch.


Conflicting Dependencies with apache-airflow 2.3.2

Describe the bug
Getting the dependency conflict when installing acryl-datahub[datahub-rest,airflow,redshift]==<IP_ADDRESS> to use with apache-airflow==2.3.2. Please release compatible release to resolve this error.
To Reproduce
Steps to reproduce the behavior:

Install acryl-datahub[datahub-rest,airflow,redshift]==<IP_ADDRESS> package with Apache Airflow 2.3.2

Error:
ERROR: Cannot install acryl-datahub[airflow,datahub-rest,redshift]==<IP_ADDRESS> and apache-airflow==2.3.2+astro.2 because these package versions have conflicting dependencies.
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies

Expected behavior
Conflict should not happen and we should be able to Leverage DataHub Functionality with Apache Airflow 2.3.2
Screenshots

Additional context
Tried with several acryl-datahub versions as below, but still got the same issue.

acryl-datahub[datahub-rest,airflow,redshift]==<IP_ADDRESS>
acryl-datahub[datahub-rest,airflow,redshift]==<IP_ADDRESS>
acryl-datahub[datahub-rest,airflow,redshift]==0.8.38
acryl-datahub[datahub-rest,airflow,redshift]==0.8.36

@treff7es Giving this one to you as you are more aware of all airflow dependencies.

Still getting the dependency conflict when installing acryl-datahub[datahub-rest,airflow,redshift]==0.8.42 to use with apache-airflow==2.3.x So please don't mark it as stale.
Tried this with the latest version 0.8.42 released today 4th August. https://pypi.org/project/acryl-datahub/0.8.42/
Error:
ERROR: Cannot install acryl-datahub[airflow,datahub-rest,redshift]==0.8.42 and apache-airflow==2.3.3+astro.1 because these package versions have conflicting dependencies.
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies

Snapshot:

Thanks!

seems like dup #4809

Fixed by PR: https://github.com/datahub-project/datahub/issues/5593


Response output truncated [Bug]

🐛 Bug
Hello,
I am getting truncated responses (generation stops mid-sentence) while using the mlc-llm rest api.
To Reproduce
Steps to reproduce the behavior:
I am currently running llama 2 13b chat q8f16_1 on an A10G on huggingface and getting truncated responses when the prompt is about 2k tokens.
I am getting the following warning on the server side:
Warning: The prompt tokens are more than max_window_size, the input will be truncated.
I tried increasing the max_window_size in mlc-chat-config.json to 8k but I am still getting the issue.

Expected behavior
Have complete responses from the llm.
Environment

Platform (e.g. WebGPU/Vulkan/IOS/Android/CUDA): CUDA
Operating system (e.g. Ubuntu/Windows/MacOS/...): Ubuntu
Device (e.g. iPhone 12 Pro, PC+RTX 3090, ...): A10G
How you installed MLC-LLM (conda, source): source
How you installed TVM-Unity (pip, source):
Python version (e.g. 3.10): 3.9
GPU driver version (if applicable):
CUDA/cuDNN version (if applicable): 11.8
TVM Unity Hash Tag (python -c "import tvm; print('\n'.join(f'{k}: {v}' for k, v in tvm.support.libinfo().items()))", applicable if you compile models):

Right. When building the model lib, there’s an option “--max-seq-len” you may tweak, which by default, is 2048. You may refer to “Step 3” here to tweak this parameter: https://github.com/mlc-ai/llm-perf-bench#mlc-llm

@junrushao, I am getting an issue with the compiled model. The compilation is successful but when I try to get a completion I get the following error:
ERROR:    Exception in ASGI application Traceback (most recent call last):   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/uvicorn/protocols/http/h11_impl.py", line 408, in run_asgi     result = await app(  # type: ignore[func-returns-value]              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/uvicorn/middleware/proxy_headers.py", line 84, in __call__     return await self.app(scope, receive, send)            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/fastapi/applications.py", line 292, in __call__     await super().__call__(scope, receive, send)   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/starlette/applications.py", line 122, in __call__     await self.middleware_stack(scope, receive, send)   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/starlette/middleware/errors.py", line 184, in __call__     raise exc   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/starlette/middleware/errors.py", line 162, in __call__     await self.app(scope, receive, _send)   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/starlette/middleware/cors.py", line 83, in __call__     await self.app(scope, receive, send)   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 79, in __call__     raise exc   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 68, in __call__     await self.app(scope, receive, sender)   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 20, in __call__     raise e   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 17, in __call__     await self.app(scope, receive, send)   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/starlette/routing.py", line 718, in __call__     await route.handle(scope, receive, send)   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/starlette/routing.py", line 276, in handle     await self.app(scope, receive, send)   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/starlette/routing.py", line 66, in app     response = await func(request)                ^^^^^^^^^^^^^^^^^^^   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/fastapi/routing.py", line 273, in app     raw_response = await run_endpoint_function(                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/fastapi/routing.py", line 190, in run_endpoint_function     return await dependant.call(**values)            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/mnt/c/Users/medal/Desktop/workspace/workspace_wsl/vllm/rest.py", line 208, in generate     session["chat_mod"]._prefill(input=request.prompt)   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/mlc_chat/chat_module.py", line 980, in _prefill     self._prefill_func(input, decode_next_token, place_in_prompt.value, generation_config_str)   File "tvm/_ffi/_cython/./packed_func.pxi", line 332, in tvm._ffi._cy3.core.PackedFuncBase.__call__   File "tvm/_ffi/_cython/./packed_func.pxi", line 277, in tvm._ffi._cy3.core.FuncCall   File "tvm/_ffi/_cython/./base.pxi", line 182, in tvm._ffi._cy3.core.CHECK_CALL   File "/home/ali/anaconda3/envs/mlc/lib/python3.11/site-packages/tvm/_ffi/base.py", line 476, in raise_last_ffi_error     raise py_err   File "/workspace/mlc-llm/cpp/llm_chat.cc", line 1322, in mlc::llm::LLMChatModule::GetFunction(tvm::runtime::String const&, tvm::runtime::ObjectPtr<tvm::runtime::Object> const&)::{lambda(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)#5}::operator()(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*) const   File "/workspace/mlc-llm/cpp/llm_chat.cc", line 800, in mlc::llm::LLMChat::PrefillStep(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, bool, bool, mlc::llm::PlaceInPrompt, tvm::runtime::String)   File "/workspace/mlc-llm/cpp/llm_chat.cc", line 981, in mlc::llm::LLMChat::SampleTokenFromLogits(tvm::runtime::NDArray, std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, picojson::value, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, picojson::value> > >)   File "/workspace/mlc-llm/cpp/llm_chat.cc", line 1108, in mlc::llm::LLMChat::Softmax(tvm::runtime::NDArray, tvm::runtime::NDArray) ValueError: Traceback (most recent call last):   10: mlc::llm::LLMChatModule::GetFunction(tvm::runtime::String const&, tvm::runtime::ObjectPtr<tvm::runtime::Object> const&)::{lambda(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)#5}::operator()(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*) const         at /workspace/mlc-llm/cpp/llm_chat.cc:1322   9: mlc::llm::LLMChat::PrefillStep(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, bool, bool, mlc::llm::PlaceInPrompt, tvm::runtime::String)         at /workspace/mlc-llm/cpp/llm_chat.cc:800   8: mlc::llm::LLMChat::SampleTokenFromLogits(tvm::runtime::NDArray, std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, picojson::value, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, picojson::value> > >)         at /workspace/mlc-llm/cpp/llm_chat.cc:981   7: mlc::llm::LLMChat::Softmax(tvm::runtime::NDArray, tvm::runtime::NDArray)         at /workspace/mlc-llm/cpp/llm_chat.cc:1108   6: tvm::runtime::relax_vm::VirtualMachineImpl::InvokeClosurePacked(tvm::runtime::ObjectRef const&, tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)   5: tvm::runtime::PackedFuncObj::Extractor<tvm::runtime::PackedFuncSubObj<tvm::runtime::relax_vm::VirtualMachineImpl::GetClosureInternal(tvm::runtime::String const&, bool)::{lambda(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)#1}> >::Call(tvm::runtime::PackedFuncObj const*, tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)   4: tvm::runtime::relax_vm::VirtualMachineImpl::InvokeBytecode(long, std::vector<tvm::runtime::TVMRetValue, std::allocator<tvm::runtime::TVMRetValue> > const&)   3: tvm::runtime::relax_vm::VirtualMachineImpl::RunLoop()   2: tvm::runtime::relax_vm::VirtualMachineImpl::RunInstrCall(tvm::runtime::relax_vm::VMFrame*, tvm::runtime::relax_vm::Instruction)   1: tvm::runtime::relax_vm::CheckTensorInfo(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)   0: _ZN3tvm7runtime6deta   File "/workspace/tvm/src/runtime/relax_vm/builtin.cc", line 177 ValueError: Check failed: (ptr->dl_tensor.ndim == ndim) is false: ErrorContext(fn=softmax_with_temperature, loc=param[1], param=temperature, annotation=R.Tensor((nseq,), dtype="float32"))  expect Tensor with ndim 1 but get 0

I believe this particular issue has been fixed by this commit. See also bug report from last week

This is very strange because the prefill function indeed requires 4 inputs...

I am able to reproduce this issue. Digging

Fix #1120

I reverted this particular commit to temporarily unblock us from this issue, and now am rebuilding the nightly wheels. Will update here as soon as the wheels are updated (expect ~2h).
@Lunderberg I apologize for the temporary revert, please feel free to submit this commit again as long as it runs through the existing flow

Ok. Thanks!

The wheels have been updated. You may try again!

@junrushao I have a bugfix PR submitted here.  The root cause was an extra .without_attr("num_input") in ParamManager.transform_dequantize.  I was able to reproduce the bug with the earlier implementation, and to verify that it is resolved with the updated PR.

thanks everyone, glad it get fixed, closing for now. feel free to open  new issues


align-justify vs menu

These are almost exactly the same icon… Should one be removed?
If so, we should probably drop menu, since align-justify is part of the align-* subset… Then obviously add menu as a tag. Not sure about the aliases situation in this scenario…

hmm, not agree with this one. The menu icon is similar yes. But the width is a bit smaller and is commonly used in squares (for example menu buttons). We carefully changed this icon to look good in these squares. So I think we should keep it as it is.

We carefully changed this icon to look good in these squares. So I think we should keep it as it is.

Ok cool, if it wasn't just an oversight…


Please merge revision a30bcd7b97c5d4704b27c99ba9cf8d85b527bb83 into dev channel

@whesse @mit-mit @kasperl
<Fill in the labels for Milestone and Area to indicate what the merge applies to. E.g. if you're requesting a merge to fix an issue in Dart2JS, set the area to Area-Dart2JS. If this is a request to merge to stable please change the MergeToDev label to MergeToStable>
<Describe the problem this merge is fixing - include issue numbers if applicable>
This fixes https://github.com/dart-lang/sdk/issues/24599
<What revision(s) needs to be merged - please annotate revisions with reason if more than one>
a30bcd7b97c5d4704b27c99ba9cf8d85b527bb83

This merged cleanly

Received. This will be in the next build of dev.

This has been cherry picked to 1.13.0-dev.7.1.  The issue will be closed when the build is released.


Add on fail code action for check and fail expressions

Purpose
This code action changes following,

to this

And following (or any regular compound statement block),

to this

Fixes #29534
Fixes #31004
Approach
This PR

Adds on fail clause for a check or fail expressions within a regular compound statement
Adds on fail clause and a do statement block for a check or fail expressions which is not inside of a do statement

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

@IMS94 @nadeeshaan Can you guys please check and get this merged?


cleanup: destroy connections after .Copy() an other one

Everytime a connection is copied with the .Copy() function, it needs to
be destroyed once the object is not needed anymore. This was not done
consistently, a few more locations require the freeing of the connection
resources.

@mergifyio queue

/test ci/centos/mini-e2e/k8s-1.29

@mergifyio rebase

@mergifyio queue


Get to 100% test coverage of the back-end

Working on it on chore/tests-all-the-things. Will make a PR soon.

Merged a first batch of tests. Currently standing at 70% coverage.


Expose methods to alter cursor appearance via extensions API

I would like to be able to change the cursor appearance via the extensions API.  My particular use-case is to implement vim-like modal text editing, and would like to be able to style a block cursor for normal mode.

There is editor.selection which you can assign an empty selection to.

Oh, appearance..

Update: vscode now has an editor.cursorStyle setting that allows a block value.  (Implemented in PR #1586.) The issue as written is still valid, since (AFAICS) there's no way to control it from the extensions API.

@bgourlie @ghost
This is now done on master, three styles (line, block and underline) can be set via TextEditor.options. Please also see https://github.com/alexandrudima/vscode-vim if you are authoring a vim emulation for VS Code


[TFLite 16x8] Notebook for 16x8 post-training quantization.

This PR provides a notebook with tutorial on 16x8 post-training quantization.
It uses a simple MNIST example to demonstrate how this mode should be used.

The notebook LGTM. Can you also update these pages?

https://www.tensorflow.org/lite/performance/model_optimization
https://www.tensorflow.org/lite/performance/post_training_quantization

Hi @khanhlvg Thanks for the review! I have changes to update these pages, but I want to upstream them in a separate PR. Is it okay ?

SGTM. Thanks @wwwind !

@wwwind Can you please check @renjie-liu's comments and keep us posted ? Thanks!

Hi @renjie-liu Sorry, but all output cells are empty in this notebook as far as I can see.
Also, what do you mean by "enable python3 for the colab" ?
Thanks a lot for the review!

@renjie-liu Can you please assist on above comments from @wwwind. Thanks!

A drive-by comment as @renjie-liu clarifies. Given that the feature is experimental, it'd be good to also mark it in the navigation side bar, like below.

@wwwind  Can you please check @alanchiao's comments and keep us posted ? Thanks!

Hi @renjie-liu !
Could you please re-approve this PR?

i think i enabled python3 correctly now in this notebook by setting
"kernelspec": { "display_name": "Python 3", "name": "python3" }
i checked that all output cells are empty:
"outputs": [],
added 'experimental' status as well

Thanks for the review!

A drive-by comment as @renjie-liu clarifies. Given that the feature is experimental, it'd be good to also mark it in the navigation side bar, like below.

@alanchiao, how is that done, could you point at the source example please?

@alanchiao Can you please take a look on above comments from @akarmi. Thanks!

@gbaned : Elena figured out how to add the "experimental" status, so Anton's comment is resolved. @renjie-liu to finalize this.

Hi @khanhlvg Thanks for the review! I updated the notebook as suggested. Could you please re-approve ?


reone

reone - source
"reone is a free and open source game engine, capable of running Star Wars: Knights of the Old Republic and its sequel, The Sith Lords."

Added in f06d8bf.


Maybe change a little feature?

Use RClone to save to google drive and use playit.gg for port forward.

I'm actually rewriting whole stuff rn, so maybe I will add support to multiple variants how to expose ports to public.
Idk about rclone tbh, should I add it or not since you can just mount directory...


Proximity is time-consuming when the query contains a lot of common words

Describe the bug
Proximity is time-consuming when the query contains a lot of common words that have few chances to be near.
To Reproduce
Steps to reproduce the behavior:

Make a search query like 1 2 3 4 5 6 7 8 or the a en of t p org jpg and in
Hits ~ 1662 Time spent 9576 ms

Expected behavior
Give a faster response
Screenshots
If applicable, add screenshots to help explain your problem.
Meilisearch version: v0.26
Additional context
related to:
https://github.com/meilisearch/meilisearch/issues/2175

Fixed by https://github.com/meilisearch/meilisearch/pull/3542


Jobs run out of disk space when run on Singularity

On Singularity, many jobs fail somewhere in the middle because they exceed the amount of allocated scratch space.
This can probably be worked around by setting environment variable DATASET_MOUNT_CACHE_SIZE to<PHONE_NUMBER>00 (300GB)

Seems like this is solved. Can we close it? @ant0nsc

Yes, this can be closed - this is an issue only for amulet, and there we set env variables in the config file.