Replace ButtonSelect widgets with radio buttons or select

Issue Summary
Our filters use a ButtonSelect widget, which is a custom implementation of a form field that looks like a series of buttons but behaves like a radio button.
This was discussed during the last accessibility team meeting (Jan 2922) and also in Stimulus project discussions.
This JavaScript implementation creates the following problems;

The "on" state isn’t communicated to screen reader users
The "on" state is not visually indicated to WHCM users
This widget feels very superfluous, clocking in at 100+ lines of code to make a worse version of radio buttons

Steps to Reproduce
Go to the Reports views where the component is used in the filters.

Recommended solution
Replace this with vanilla input type="radio" or <select> elements to fix existing accessibility issues with this widget.

See the implementation of ButtonSelect - wagtail/admin/widgets/button_select.py
The styles can probably be deleted: https://github.com/wagtail/wagtail/blob/main/client/scss/components/_button-select.scss
The HTML templates can be deleted wagtail/admin/templates/wagtailadmin/widgets/button_select.html & wagtail/admin/templates/wagtailadmin/widgets/button_select_option.html
The JS can be deleted: client/src/includes/initButtonSelects.ts & client/src/includes/initButtonSelects.test.js
The ButtonSelect widget can probably be deleted, but other usage needs to be considered, possibly just replacing with the suitable forms.RadioSelect or forms.Select.
The BooleanButtonSelect can probably be renamed to BooleanFilterSelect - this widget override is still helpful as it causes 'nice' default values to show in the select options.
Add note to the release notes (can be done on merge) that this widget will no longer be available. It is not documented but still good to call out.

Example screenshots
Recommended: radio - it looks better
using class ButtonSelect(forms.RadioSelect): ... pass

using `class ButtonSelect(forms.Select): ... pass

Hi @thibaudcolas I am new to open source and excited to work on this issue. Can i go for it?

Hi @thibaudcolas I am new to open source and excited to work on this issue. Can i go for it?

@Nazi-pikachu if you're a beginner I would suggest you to
Start with issues labeled with good first issue, in this I would like to give this a try However if you feel that you can take this one up, then I can hold and you are much appreciated to have a try, thank you

There are probably multiple implementations of list filters in Wagtail (ModelAdmin, Snippets, Pages(?)). Just wanted to mention that the Wagtail ModelAdmin uses Django ModelAdmin List Filters.
Django ModelAdmin List Filters are cool:

They are well developed, and used in most Django projects.
They ship with Django
They are self contained (multiple filters can be used together, they don't need to be aware of each other).
They have good documentation, also on how to extend them.
There are third party packages that allow adding more advanced filters. https://pypi.org/project/django-admin-list-filters/

I'm not sure about the accessibility of Django ModelAdmin List Filters, but if they are accessible, we might consider them???
An alternative option can be  Django Filter package.

Reports and generic index views (including snippets) are using django-filter, so with the ongoing work to position snippets as the successor to ModelAdmin, that will most likely emerge as the standard approach across Wagtail.

Thanks @allcaps  / @gasman  - we may end up splitting the 'source' behaviour change out to a separate issue, hoping to keep this issue focused on the simplest change possible; remove the JS implementation and replace with a simple HTML radio or select box.

Opening this up as a good first issue, this will require some Django/Python knowledge but not too much, mostly this requires deleting a bunch of files and renaming some.
cc @Nazi-pikachu  / @salty-ivy

Please assign me this issue I want to solve this issue

@Pritimayasahoo feel free to give this a start. We don't assign issues outside of the core team.

Can I solve this issue for your organization

Heyy can I work on this issue. I have some knowledge on this and would like to work.

Can you tell me on which html file that html code exist, which you mention above in the screen short. Please help me I am a beginner, I want to solve this issue.

Can you tell me on which html file that html code exist, which you mention above in the screen short. Please help me I am a beginner, I want to solve this issue.

@Pritimayasahoo you can join slack and ping me there, would help you through out your PR, also there would be other community members/ contributors you can get help from too.
In general you can ask these doubts there and on you PR and leave this space for ideas/discussions based on solutions or the issue itself

@Pritimayasahoo  - have another read of the description and follow every link, you will note there is a link to the button_select.py file - that Django Widget will declare what templates are used.
Specifically this line
https://github.com/wagtail/wagtail/blob/main/wagtail/admin/widgets/button_select.py#L11
Here are some docs on Django widgets also that may help https://docs.djangoproject.com/en/4.1/ref/forms/widgets/

./assign

I'm trying to solve this issue and have created the radio button... but the problem I'm facing is where are those button clicks redirecting to? I'm trying to convert the radio button obtained into clickable links but don't know where to refer them?
A little help would be appreciated

I have opened a draft PR https://github.com/wagtail/wagtail/pull/10121 . Please review my work.

I've tried solving this issue in PR #10123.If any issues are there please lemme know I'll correct them.

Removing good first issue - two PRs already up


Consider using GLPK instead of CPLEX

CPLEX is free for academic use...i.e. teaching, not for research.
Universities can use it although strictly speaking if being used for research instead of teaching this is likely a contravention of the license. Any not-for profit research institute that is not a teaching institute will have to pay for the license.
It may be better to remove a dependency on a commercial piece of software. GLPK provides similar functionality to CPLEX and has python bindings but I appreciate that modifying the code to use this instead of CPLEX is a big ask.

I agree that if possible, this would be great


fix: subtitle translation

file: 01-responsive-web-design/applied-visual-design/animate-multiple-elements-at-variable-rates.portuguese.md

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

Thank you for your contribution. This is superseded by #34955, which will solve it for all challenges of all languages, so I'm closing this PR.


Stopping InProgress Test Cases when server shuts down

We need to update the status of InProgress to Stopped when server is shutdown while testCases are still running. Otherwise the Run button is disable due to following condition in tests.html ng-disabled="running().length > 0
mdw-function-test-results.json is the file which keeps the status of all test cases.
Possible statuses in TestCase.java
public enum Status {
Waiting,
InProgress,
Errored,
Failed,
Passed,
Stopped // terminated by user
}
TestingServicesImpl.processResultsFile(File, List) line: 202
May be we can update the result file before starting a new TestCase run.

This is a rare scenario where server is not cleanly shut down. Occurrence of this happening in prod is very less. But if we need to fix it then we do it during the server start.

A good approach for this would be to add a registered StartupService implementation in asset package com.centurylink.mdw.testing that would check the test results JSON file for InProgress or Waiting cases and update all these to Stopped.


Upgrade to shapeless 2.1.0 final

Trivial change. It would be good to have a new release to avoid SBT eviction warnings due to mismatched Shapeless release versions.

Ah thanks, I was in no hurry as there were no changes in shapeless core between RC2 and final.

Thanks. Indeed, no behaviour change apart from keeping SBT happy. :)

Just released 0.1.1 with shapeless 2.1.0 final as a dependency btw.

Great.


A11y_PowershellEditorServices_Terminal_ScreenReader: NVDAdoes not read the expanded/collapsed status of the Combo box.

Environment Details:
VSCode Version : 1.25.1
OS Version : Win10
Additional Details:
Screenreader MAS1.3.1
Repro Steps:
1.Launch Visual Studio code desktop application.
2.Navigate to "View" item of menu bar and select "Integrated Terminal"->Navigate to "Terminal" tab and select "PowerShell Integrated Console" from combo box.
3.Navigate "PowerShell Integrated Console" List item.
4.Start NVDA & observe whether narrator reads expanded/collapsed status of the Combo box or not.
Actual:
NVDA does not read the expanded/collapsed status of the Combo box (i.e."PowerShell Integrated Console")
Expected:
NVDA should read the expanded/collapsed status of the Combo box (i.e."PowerShell Integrated Console")
Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx
User Impact:
User will not able to know the state of the combo box.
MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}
Does this issue occur when all extensions are disabled?: Yes
A11y_PowershellEditorServices_Terminal_ScreenReader.pptx

@Tyriar
This is the ongoing battle with Electron/Chromium/ARIA quirks but some of which we can work around in 2.x versions. But I will look at it.

@AccessibilityTestingTeam-TCS
I just tested with Windows 10 and NVDA 2018.2.1
The reader reads "collapsed" for the terminal as well as other drop downs.

In the latest Version: 1.28.2 issue does not repro hence closing this bug.


GradleWrapperMain may get stuck if process is launched from another JVM

This is a very puzzling issue to me.
I'm using Gradle 6.6.1, and I noticed that under some circumstances launching a Gradle process from another Java process and waiting for termination results in an infinite wait. Terminating the Gradle wrapper process and analyzing its output, the build actually completed successfully, it's just the process that does not terminate.
I inspected what happens with a profiler. Here is the thread dump for main:

"main" #1 prio=5 os_prio=0 cpu=559,06ms elapsed=73,93s tid=0x00007f1b34016000 nid=0x1b37f7 waiting for monitor entry  [0x00007f1b3bb3f000]    java.lang.Thread.State: BLOCKED (on object monitor)         at org.gradle.internal.logging.console.ThrottlingOutputEventListener.onOutput(ThrottlingOutputEventListener.java:68)         - waiting to lock <0x00000000fe68adf0> (a java.lang.Object)         at jdk.internal.reflect.GeneratedMethodAccessor1.invoke(Unknown Source)         at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@11.0.8/DelegatingMethodAccessorImpl.java:43)         at java.lang.reflect.Method.invoke(java.base@11.0.8/Method.java:566)         at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)         at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)         at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:42)         at org.gradle.internal.event.BroadcastDispatch$SingletonDispatch.dispatch(BroadcastDispatch.java:245)         at org.gradle.internal.event.BroadcastDispatch$SingletonDispatch.dispatch(BroadcastDispatch.java:157)         at org.gradle.internal.event.ListenerBroadcast.dispatch(ListenerBroadcast.java:141)         at org.gradle.internal.event.ListenerBroadcast.dispatch(ListenerBroadcast.java:37)         at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)         at com.sun.proxy.$Proxy0.onOutput(Unknown Source)         at org.gradle.internal.logging.sink.OutputEventTransformer.onOutput(OutputEventTransformer.java:104)         at org.gradle.internal.logging.sink.OutputEventRenderer.onOutput(OutputEventRenderer.java:431)         - locked <0x00000000fe674e78> (a java.lang.Object)         at org.gradle.internal.logging.sink.OutputEventListenerManager$1.onOutput(OutputEventListenerManager.java:36)         at org.gradle.launcher.daemon.client.DaemonClient.monitorBuild(DaemonClient.java:225)         at org.gradle.launcher.daemon.client.DaemonClient.executeBuild(DaemonClient.java:185)         at org.gradle.launcher.daemon.client.DaemonClient.execute(DaemonClient.java:148)         at org.gradle.launcher.daemon.client.DaemonClient.execute(DaemonClient.java:99)         at org.gradle.launcher.cli.RunBuildAction.run(RunBuildAction.java:56)         at org.gradle.internal.Actions$RunnableActionAdapter.execute(Actions.java:212)         at org.gradle.launcher.cli.DefaultCommandLineActionFactory$ParseAndBuildAction.execute(DefaultCommandLineActionFactory.java:275)         at org.gradle.launcher.cli.DefaultCommandLineActionFactory$ParseAndBuildAction.execute(DefaultCommandLineActionFactory.java:247)         at org.gradle.launcher.cli.DebugLoggerWarningAction.execute(DebugLoggerWarningAction.java:82)         at org.gradle.launcher.cli.DebugLoggerWarningAction.execute(DebugLoggerWarningAction.java:30)         at org.gradle.launcher.cli.WelcomeMessageAction.execute(WelcomeMessageAction.java:92)         at org.gradle.launcher.cli.WelcomeMessageAction.execute(WelcomeMessageAction.java:38)         at org.gradle.launcher.cli.NativeServicesInitializingAction.execute(NativeServicesInitializingAction.java:44)         at org.gradle.launcher.cli.NativeServicesInitializingAction.execute(NativeServicesInitializingAction.java:26)         at org.gradle.launcher.cli.ExceptionReportingAction.execute(ExceptionReportingAction.java:41)         at org.gradle.launcher.cli.ExceptionReportingAction.execute(ExceptionReportingAction.java:26)         at org.gradle.launcher.cli.DefaultCommandLineActionFactory$WithLogging.execute(DefaultCommandLineActionFactory.java:240)         at org.gradle.launcher.Main.doAction(Main.java:35)         at org.gradle.launcher.bootstrap.EntryPoint.run(EntryPoint.java:50)         at<EMAIL_ADDRESS>Method)         at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.base@11.0.8/NativeMethodAccessorImpl.java:62)         at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@11.0.8/DelegatingMethodAccessorImpl.java:43)         at java.lang.reflect.Method.invoke(java.base@11.0.8/Method.java:566)         at org.gradle.launcher.bootstrap.ProcessBootstrap.runNoExit(ProcessBootstrap.java:60)         at org.gradle.launcher.bootstrap.ProcessBootstrap.run(ProcessBootstrap.java:37)         at org.gradle.launcher.GradleMain.main(GradleMain.java:31)         at<EMAIL_ADDRESS>Method)         at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.base@11.0.8/NativeMethodAccessorImpl.java:62)         at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@11.0.8/DelegatingMethodAccessorImpl.java:43)         at java.lang.reflect.Method.invoke(java.base@11.0.8/Method.java:566)         at org.gradle.wrapper.BootstrapMainStarter.start(BootstrapMainStarter.java:35)         at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:108)         at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:63)     Locked ownable synchronizers:         - None

It looks like it is waiting for output.
The bug is hard to reproduce:

it only seems to happen on big and complex projects;
it seems reproducible only if the process is launched from another JVM instance

The behaviour seems to be unrelated to the deamon, or, at least, I reproduced the bug with --no-daemon.
Expected Behavior
The process terminates once the build is finished.
Current Behavior
Under special circumstances, the process does not stop.
Context
I wrote a bot doing something similar to Dependabot, but working with Gradle kts scripts and supporting refreshVersions.
I need to launch the command ./gradlew refreshVersions on multiple repositories, and I do so by:
    private fun runRefresh(projectRoot: File): ProcessOutcome {
        val process = ProcessBuilder(listOf(gradleCommand, "--console=plain", taskName))
            .directory(projectRoot)
            .start()
        return try  {
            when (process.onExit().get(timeoutInMinutes, TimeUnit.MINUTES).exitValue()) {
                0 -> ProcessOutcome.Ok
                else -> ProcessOutcome.Error(process)
            }
        } catch (timeOut: TimeoutException) {
            logger.error("One process has timed out", timeOut)
            process.destroy()
            try {
                process.onExit().get(1L, TimeUnit.SECONDS)
            } catch (unkillableTimeOut: TimeoutException) {
                logger.error("One process refused to terminate after timeout, destroying forcibly", unkillableTimeOut)
                process.destroyForcibly()
            }
            ProcessOutcome.TimeOut(process)
        }
    }

Steps to Reproduce

fork this repository (you will need write access)
download upgradle
Create an upgradle.yml in the same folder of upgradle-0.2.2-dev1e+814f0d3-all.jar file with the following content:

includes:
  - owners: .*
    repos:
      - Alchemist
    branches:
      - develop
modules:
  - name: GradleWrapper
    options:
      strategy: next
      versionRegex: \d+(\.\d+)*
  - name: RefreshVersions
    options:
      strategy: next, latest
      versionRegex: \d+(\.\d+)*
labels:
  name: version-upgrade
  color: deffaa
author:
  email<EMAIL_ADDRESS>

run java -jar 'upgradle-0.2.2-dev1e+814f0d3-all.jar' upgradle.yml from the folder where you downloaded the jar

Your Environment
The bug can be reproduced in CI

Full thread dump
thread-dump.log
Full heap dump
heapdump-1598883726410.hprof.tar.gz

I suspect that this is happening because you're starting Gradle, but not reading stdout/stderr while the build is running. stdout/stderr need to be flushed to prevent the child process from hanging/waiting.
Have you considered using the Tooling API? https://docs.gradle.org/current/userguide/third_party_integration.html#embedding
This gives you programmatic access to the Gradle build you're running.

This can very likely be the reason, indeed. I'll try out the tooling API

It is working correctly with the Tooling API. @big-guy, you framed the issue correctly.


Adding some kind of 'matching' class?

I'm using the multifilter and pagination plugins.
I need to somehow keep track of which items relate to the current filtering regardless of whether they are visible on the current page or not so I was wondering if there was any way of adding an additional class or attribute to items regardless of whether they are currently display:none etc?

Hi @mattyd2478,
The MixItUp state object exposes a matching property exactly for this purpose. You can hook into it via the lifecycle callbacks, for example:
const mixer = mixitup(container, {
    callbacks: {
        onMixEnd: state => console.log(state.matching)
    }
});

This will give you an array of all matching target elements, which you can then iterate over.
So, if you wanted to add a class to these elements at the end of each operation, you could do something like this:
const mixer = mixitup(container, {
    callbacks: {
        onMixEnd: state => {
            const {targets, matching} = state;

            targets.forEach(el => {
                const isMatching = matching.indexOf(el) > -1;

                el.classList[isMatching ? 'add' : 'remove']('my-matching-class');
            }
        }
    }
});

Hope that helps

Thanks Patrick,
Great support as always.


optadd explanation why we always update col stats in StatsCalculator.

Proposed changes
For a group, there are multiple groupExpressions.
for each groupExpression, there is a corresponding table stats.
even the table stats is not choosed to represent the group, its column stats are still useful. we add explanation of this behavir as comments.
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Support for Logpush magic_ids_detections

Current Terraform and Cloudflare provider version
Terraform v1.4.5
on darwin_arm64
+ provider registry.terraform.io/cloudflare/cloudflare v4.7.1
+ provider registry.terraform.io/hashicorp/aws v4.39.0
+ provider registry.terraform.io/hashicorp/vault v3.11.0

Description
Update cloudflare_logpush_job to support dataset magic_ids_detections
Use cases
As an Magic IDS customer, I would like to set-up Log Push with Terraform, so I can codify and automate my infrastructure configuration
Potential Terraform configuration
resource "cloudflare_logpush_job" "network_analytics_logs" {
  dataset          = "magic_ids_detections"
...

References
https://registry.terraform.io/providers/cloudflare/cloudflare/latest/docs/resources/logpush_job#dataset
https://developers.cloudflare.com/logs/reference/log-fields/account/magic_ids_detections/

This issue has been closed as we are now tracking this internally with service teams directly. If you would like an update or to be notified when/if the product ships with this change, please reach out to Cloudflare Support or your account team who can watch the internal feature request for you.


High and Lows disappearing when CandleStick chart is zoomed out

Lightweight Charts Version: 3.1.5
Steps/code to reproduce:

Zoom out a CandleStick chart

Actual behavior: At a certain point the highs and the lows will just disappear.
Expected behavior: Highs and Lows shouldn't disappear.
Screenshots:

CodeSandbox/JSFiddle/etc link:
The issue also appears on the demo provided for CandleStick chart
https://www.tradingview.com/lightweight-charts/

the highs and the lows will just disappear.

What do you mean? Can you please provide screenshot and highlight there what's going wrong?

Sorry for the late reply, the wicks are disappearing.

@eugene-korobko can you please take a look?

Hello!
Could you please check your browser zoom settings? Is it 100%? Does the problem reproduce with 100% browser zoom?

Yes, the zoom is 100%

I just tried to reproduce the issue on https://jsfiddle.net/TradingView/eaod9Lq8/ and no luck. @Dwyte can you please record a video of the issue? Also, what devicePixelRatio you have?

devicePixelRatio is 1, here are some clips:
https://imgur.com/a/PwZG4ij
https://imgur.com/a/98HAQKC
Same behaviour on chromium based browsers.

Thanks! I can see the issue right now.

Actually it seems that the issue is already fixed in 3.2 version (see https://jsfiddle.net/uxp9Lkfs/). Unfortunately, examples on https://www.tradingview.com/lightweight-charts/ aren't updates to the latest version yet.
@Dwyte can you check the issue with the latest 3.2 version please?

Yep @timocov it's fixed now just checked on 3.2.


Implement SSL option for DB connections

Right now it is not possible to use the SSL flag after the init flow as it hasn't been implemented yet.

Related https://github.com/prisma/prisma2/issues/109

SSL flag has been implemented.
It is called sslmode and you can add it like so:

datasource default {
  provider = "postgresql"
  url = "postgresql://xxxx:xxxx@xxxxxx.xxx/xxxx?schema=xxxx&sslmode=preferred"
}

Three ssl modes are supported which are as following:

preferred
required
disabled


Use a different notification category for the "task completed" notification

Right now, the "Task completed" notification appears to use the same notification category as "Start and due dates".  It would be nice if it was a separate category.  My notification tone for Start and due dates is sort of obnoxious to make sure it gets my attention when something is coming due.  And then when I mark it completed I get that obnoxious noise again. If it were a separate category I could give that one a different noise (like silent).

This notification shouldn't make a sound at all and it should just replace the notification before (instead of showing up as a completely new notification). I didn't manage to do that yet but it should be possible.

That would work fine as well. :)  (probably make much more sense that way, too)

@dmfs If you like, I can try to provide a PR for this.


[SDK Optimization] Multiple SimpleDateFormat initialization in CarbonReader

I found that reading carbon files from CarbonReader takes long time in "SimpleDateFormat.", see attached file for output of
profiling.
https://github.com/apache/carbondata/blob/4b8846d1e6737e7db8a96014818c067c8c253d1f/sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java#L207
I wonder if it is OK if we add some lazy initialization to SimpleDateFormat in the class, and if so should it support multi-threading.
profile.zip

hey @zhangboren93 , Can you please assign to me and please explain the issue?


E2E: make 'selectOrCreateProject' helper more reliable

Do not rely on PF class name when getting the current project text element.

Needed by https://github.com/openshift/release/pull/45951

/assign @bipuladh @SanjalKatiyar @TimothyAsirJeyasing @GowthamShanmugam

LGTM

/approve
/lgtm


GEOMESA-990 Not creating catalog table until needed

Signed-off-by: Emilio Lahr-Vivaz<EMAIL_ADDRESS>

gonna test an ingest and merge this in unless someone else has comments

b8e4f4e8758622d3aaba2671f8557976a4c85396


Remove dist, use lib for build output

To avoid merge conflicts I've removed the dist folder (and ignored it) from the repo

You probably need to rebase this, now that the Forms API changes has been merged.

Rebased with latest master


1.9.0 port

Are there any bigger issues for a 1.9.0 port? Since 1.9 introduced spec it would be nice to have it. one issue I had is addressed by #364

I don't know. I'm shifting the bulk of my personal work to Elixir these days, though I do want to keep supporting Midje in the absence of anyone to take it over.
My feelings about clojure.spec is... conflicted, having been in this space for many years.

I have been keeping Midje up to date with the 1.9 releases.


re-enable some JWT e2e test cases

right now all jwt e2e test cases are disabled, the recent flaky happen in two test cases(https://github.com/istio/istio/issues/6288, https://github.com/istio/istio/issues/6545) when authN(mTLS) is enabled(seems regression), enable other passed test cases.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: quanjielin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: yutongz
Assign the PR to them by writing /assign @yutongz in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hklai, quanjielin
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS [hklai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@quanjielin: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
99d460d9531d90fd6bafbcbf3cdadf4db8152572
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[Issue]: Change applets to use Dennis's colors

What needs to change?
Problem
Currently we and Dennis are using the colors from the TU Delft design guide, which can be found here: https://www.tudelft.nl/en/tu-delft-corporate-design/components/colour.
Colors are saved in  utils/PrimeColors.ts
However, we use different subsets of the available colors. This leads to us changing some colors when creating applets, making the applets less consistent with the static images and book.
We have discussed what to do with this during the PGG meeting and have decided to adhere to Dennis's color scheme:

Note: officially (according to the tu style guide),  Dennis's red is called raspberry, green is dark green, dark blue is blue, and blue is cyan.
What is done

The new colors have been added to utils/PrimeColors.ts.
The colors have been renamed to match naming of TU color scheme

Required steps

[x] Replace red with raspberry
[ ] Change all applets that use pink and purple. Replace pink and purple with orange or cyan, adhering to colors of dennis's original image.
[ ] Check each changed applet, are they visually pleasing?
[ ] Remove pink and purple from PrimeColors.ts

Does this issue relate or depend on other issues?
No response

[ ] check consistency with andre's request? -> issue #194


[5.25] iVoox iframe totally breaks the PWA

When accessing this post https://thewing.es/the-wing-nba-podcast-2k19-rafatgr/ the PWA breaks, the screen becomes white an unusable.
Size: 0.01
Environment: 5
Range: 1
Behaviour: 5
Mass: 5
 Front conversations

iVoox iframes are working in dev branch. Posts with those iframes don't break the PWA anymore.


Add doc for azure file

Doc for azure file storage class.

This change is

/cc @brendandburns
/sig azure

/sig azure

tech LGTM


Fixed wrong Publish condition

Change
Fixed Publish condition to run only on main and master refs.
Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update (Wiki)

Checklist

[ ] I'm sure there are no other open Pull Requests for the same update/change
[x] My corresponding pipelines / checks run clean and green without any errors or warnings
[x] My code follows the style guidelines of this project
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (readme)
[ ] I did format my code

@segraef  Merge once no pipelines are running as it will trigger all - and there is no batch processing feature in GitHub


I need help with MultiAdmin error

Cannot figure out WHICH config file lets me change the contact_email value. Please help!

That's a game config

That's a game config

Too vauge, which file?

config_gameplay.txt, please refer to the game's documentation or Discord for support. Your question isn't relevant to ServerMod or MultiAdmin.


Error while setting temperature in a Home Assistant scene

Hi,
this  is the scene I created in Home Assistant:
- name: test_sonoff_temp22
    entities:
      climate.termostato_cameretta:
        state: 'heat'
        temperature: 22

When I activate the scene I get this error in the log:
Logger: custom_components.sonoff.core.ewelink.cloud
Source: custom_components/sonoff/core/ewelink/cloud.py:286
Integration: Sonoff ([documentation](https://github.com/AlexxIT/SonoffLAN), [issues](http://<IP_ADDRESS>:8123/api/sonoff/1bfcedf5-a307-4188-963a-b5efbfefc056))
First occurred: 10:07:31 AM (1 occurrences)
Last logged: 10:07:31 AM

Cloud ERROR: {'error': 400, 'deviceid': '100156adce', 'apikey': '647f9a26-a71f-4250-934c-e28e8f3d2c39', 'sequence': '1669367251000', 'uid': '647f9a26-a71f-4250-934c-e28e8f3d2c39'}

I have two other scenes perfectly running to turn on and off the NSPanel:
- name: test_sonoff_on
    entities:
      climate.termostato_cameretta:
        state: 'heat'
- name: test_sonoff_off
    entities:
      climate.termostato_cameretta:
        state: 'off'

I think the problem could be the "temperature" line in the scene.
Is there another syntax to set the temperature?
Thanks in advance.

Hi, this morning I have made some further test on Sonoff NS panel EU within Home Assistant (last version).
I give you my feedback and I hope this could be interesting for you.
 The operation's combobox has the value: HEAT (wrong).
Test 2: turn on the thermostat from HA using climate control
I click on the AUTO option from the combobox called Operation.
The thermostat turns on. It's in AUTO mode in Ewelink. The operation's combobox has the value: HEAT (wrong).
There isn't a way to set the thermostat in mode MANUAL using Home Assistant
Test 3: change desired temperature in thermostat
I click the up and down arrow but nothing happens on the thermostat.
Test 4: turn off the thermostat when it's heating
I click the OFF option as told before, the thermostat turns off, but it still continue heating. I mean the switch connected to the heat-valve is still in ON state. I don't know if it's correct or not, but in my mind when I turn-off the thermostat, I want to stop heating.
Colclusions:
The first problem is that it's not possible to set the desired temperature in the thermostat. I mean the attribute called: temperature.
The second problem is that there isn't an attribute for the status of the thermostat. For "status" I mean: heating or idle. This is very simple to calculate... if current_temperature(room) >= desired_temperature --> idle else heating.
The third problem is that when I change the mode of the thermostat within the three values: AUTO, MANUAL (better then HEAT)), OFF, the combocox still remain on HEAT value.
I'm at your disposal for any test or feedback you need. Don't esistate to contact me.
Many thanks in advance.

I can't fix this bug without device. You can collect more logs. We need to know exact command that generate error 400.


Fix sorting of players when rating not present.

Traceback:

File "/home/lichess4545/web/www.lichess4545.com/env/lib/python3.6/site-packages/django/core/handlers/exception.py" in inner
 41.             response = get_response(request)

File "/home/lichess4545/web/www.lichess4545.com/env/lib/python3.6/site-packages/django/core/handlers/base.py" in _legacy_get_response
 249.             response = self._get_response(request)

File "/home/lichess4545/web/www.lichess4545.com/env/lib/python3.6/site-packages/django/core/handlers/base.py" in _get_response
 187.                 response = self.process_exception_by_middleware(e, request)

File "/home/lichess4545/web/www.lichess4545.com/env/lib/python3.6/site-packages/django/core/handlers/base.py" in _get_response
 185.                 response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/home/lichess4545/web/www.lichess4545.com/env/lib/python3.6/site-packages/django/utils/decorators.py" in _wrapped_view
 149.                     response = view_func(request, *args, **kwargs)

File "/home/lichess4545/web/www.lichess4545.com/env/lib/python3.6/site-packages/django/views/decorators/cache.py" in _wrapped_view_func
 57.         response = view_func(request, *args, **kwargs)

File "/home/lichess4545/web/www.lichess4545.com/env/lib/python3.6/site-packages/django/contrib/admin/sites.py" in inner
 224.             return view(request, *args, **kwargs)

File "/home/lichess4545/web/www.lichess4545.com/current/heltour/tournament/admin.py" in manage_players_view
 813.             return self.team_manage_players_view(request, object_id)

File "/home/lichess4545/web/www.lichess4545.com/current/heltour/tournament/admin.py" in team_manage_players_view
 948.         unassigned_players = list(sorted(season_players - team_players - alternate_players, key=lambda p: p.rating_for(league), reverse=True))

Exception Type: TypeError at /admin/tournament/season/137/manage_players/
Exception Value: '<' not supported between instances of 'NoneType' and 'int'
Request information:

This was caused by manually added data.

this was fixed with #418 where it happened with data that was not manually added.


routing: cancelable payment loop

Fixes https://github.com/lightningnetwork/lnd/issues/8534.
While interrupting lncli estimateroutefee ends the client program, the route server is left behind with an abandoned payment loop.
To allow users to cancel payment requests properly, the payment loop in resumePayment has to be abandoned as well as soon as the user request it. https://github.com/lightningnetwork/lnd/blob/f523f52ab468915d9cf6e18632f17ba707906284/routing/payment_lifecycle.go#L170
This PR makes the SendPaymentV2 streaming context accessible from the payment loop and allows it to safely end if the context was cancelled.

That's also my understanding, we can't cancel the payment once the htlc is sent. Here, additionally to the existent timeout check that interrupts the payment loop on expiry, we pass in a context (from the rpc server client stream) that is checked for cancellation and interrupts the payment loop if the user cancelled the stream context(Ctrl+C'd the sendpayment from cli). This can only happen if a p.sendAttempt(attempt) completed.

Thanks to the reviewers so far. I think I addressed all your concerns, namely:

Add a cacelable flag to the SendPaymentRequest that preserves the current behavior of a long running payment loop even if the stream context is canceled, but cancels the payment loop if set to true.
Wrap the send payment context into a deadline context in case the a timeout is set in the SendPaymentRequest.
Remove the timeout channel in from the payment_lifecycle.go in favor of the new timeout context.

If tested different scenarios locally and didn't encounter an error, additionally to the added test.
Looking forward to another round of feedback.

Just merged the PR that fixed the itest, could you do a rebase and let it run again, thanks!

There still seems to be an unrelated error left: https://github.com/lightningnetwork/lnd/actions/runs/9501738226/job/26188011967?pr=8734#step:6:468


added more explicit make file commands and readme description for run…

…ning a local backend outside docker
also fixed some minor test issues.

Merge with admin privileges because its documentation (and small fixes)


Add gltfpack installation instructions to main readme

I wanted to update to the latest version of gltfpack but it took me a minute to remember that gltfpack is in the gltf folder and to figure out the correct options to compile it with CMake.
Then I read through recent issues and saw you posted a link to the the Actions page which contains binaries in the build artifacts
Probably a good number of people come to this repo to install gltfpack itself, so I figured it'd be helpful to mention on the main readme

Thanks! I slightly tweaked the wording and added links to referenced pages as well.


Add Print method

Clone of https://github.com/tebeka/selenium/pull/268

@marwan-at-work, since https://github.com/tebeka/selenium is dead, please consider using https://github.com/go-auxiliaries/selenium instead


fix for #2

This PR fixed #2

I would ask you to add the test that proves your fix.

I've added testWithMockMvc to your AutoconfigurationTest. It proves the my point without the need of adding a security layer. When making the call trough the mockMvc - the MultipartGraphQlHttpHandler.readMultipartFiles receives and instance of org.springframework.mock.web.MockMultipartHttpServletRequest which wraps the required MultipartHttpServletRequest.
Using the WebUtils.getNativeRequest(httpServletRequest, MultipartHttpServletRequest.class); is sufficient to obtain the wrapped instance of MultipartHttpServletRequest, if it's present.
Further the assertion is still valid.
MultipartHttpServletRequest multipartHttpServletRequest = WebUtils.getNativeRequest(httpServletRequest, MultipartHttpServletRequest.class);
Assert.notNull(httpServletRequest,  "Request should be of type MultipartHttpServletRequest");

Polished and added test with Spring Security, because code you provided still worked without your fix.
Just 've triggered release 1.2.1, it's going to be ready on Maven Central after some time.
Thanks!


Added Linux Wheels workflow

Added Linux Wheels workflow. The workflow will run in shadow mode without upload binaries.
Changes

Added Linux Wheels workflow
Added Linux Conda workflow

TODO

[ ] Add the BUILD_S3 env variable. Depend on the PR https://github.com/pytorch/test-infra/pull/1269

BTW, another comment regarding enabling BUILD_S3=1. I was only able to compile the AWSSDK plugin to support minimum manylinux_2_17 with all the following manual installation steps (AWSSDK doesn't work well with dynamic linking).
https://github.com/pytorch/data/blob/9e217f7154c2ed96d95e9d9eb9152178a4e0c6a2/.github/workflows/_build_test_upload.yml#L111-L137


fix rowing animation

needs to be double buffered or something to make it smooth
also needs to only stroke when the rower strokes


📎 Implement useConsistentNewErrorThrow - unicorn/throw-new-error

Description
Implement unicorn/throw-new-error
Naming:
So far I've come up with useConsistentNewErrorThrow, but maybe there is a better name.

Will try to work on it myself.

So far I've come up with useConsistentNewErrorThrow, but maybe there is a better name.

useThrowNewError?

Tried to mimic useConsistentNewBuiltin, but yeah shorter version is prob better.


Discard yh:WIDTH tags

As per recent talk-ja discussion, the yh:WIDTH tag from the Yahoo Import of Japan is ok to discard as it holds inconsistent values that are not usable.
This can be added to the list at https://github.com/openstreetmap/iD/blob/master/data/discarded.json and would greatly help in the Japan OSM data cleanup process

As per recent talk-ja discussion, the yh:WIDTH tag from the Yahoo Import of Japan is ok to discard as it holds inconsistent values that are not usable.

It's worth making sure that similar issues are opened up on JOSM and P2 to keep the lists in agreement

@pnorman filed in JOSM as well https://josm.openstreetmap.de/ticket/11969


Create more performance tests

Going to list here more tests that we should test. Feel free to add some :)

Daxpy
Vector multiply/add/etc.
Matrix multiply
Tree traversal, sum, etc.

Done the daxpy, vector mulitply, matrix multiply


Add further detection date filter values

Add further Detection date filter values:

This week
This month
This year

Closes #1437

@gyorb Done.


Typescript type generation with embedded fragments for queries

Hi,
We're using fragments in our queries.
For Example:
fragment<PostalAddress>(graphql`
  fragment PostalAddress on PostalAddressModel {
    id
    city
    country
  }`, null)

const { data } = query<GetPerson>(graphql`
	query GetPerson($id: Int!) {
		GetPerson(a0: $id) {
			name
                        email
                        postalAddress {
                          ...PostalAddress
                        }
		}
	}
`);

The problem that we are facing is that the following typescript file gets generated roughly:
export type GetPerson$result = {
    readonly GetPerson: {
        readonly postalAddress: {
            readonly $fragments: {
                PostalAddress: true
            }
        }
        readonly name: string,
        readonly email: string
    }
};

While we would expect
export type GetPerson$result = {
    readonly GetPerson: {
        readonly postalAddress: {
            readonly id: string,
            readonly city: string,
            readonly country: string
        }
        readonly name: string,
        readonly email: string
    }
};

How can we fix this? This breaks our auto completion within our IDE and makes typescript compilation complain that we are accessing attributes that don't exist.

Hey @Penait1!
Unforunately, this is working as intended. The idea is that a component or route should not depend on data they did not explicitly ask for. This seems like a big constraint but houdini is forcing you to build your app in a future-proof way.  For more information, check out the relay docs. On top of that, fragment definition should be tightly associated with a component and not used as a graphql-only abstraction (ie you shouldn't pass null) - if you are trying to use do something with the postal address, that logic should get moved to its own component with a fragment.


SRA Dev Board v2.4

Hello @dhairyashah1 !
I've made the suggested changes for SRA-Board 2023 please review.
Images

SRA - Board

LSA

MPU

@ChinmayLonkar for LSA :=

Shift the annotations on the back layer for R% R6 downwards
Add PCBpower logo in front
Can add this (new pin defs on silkscreen (front layer) below 0 -1-2-3-4-5 for better debugginh

@dhairyashah1
I have updated the new LSA as well as changed the stepper motor driver to a4988 stepper driver, please have a look

I have modified the relative path for the component libraries of LSA and now it's working
Regarding the Readme, I have assigned an SY

LGTM, merging this PR in master
Kindly Mention the name /tag the assigned SY(s) in comments of the concerned issue - #22


Implement RDKit RegistrationHash

Documentation:
https://rdkit.org/docs/source/rdkit.Chem.RegistrationHash.html

Closing this in favour of #158


Multiple Sidebar

Hi,
How can i have multiple sidebar .. in right and left side
any possibility with this ??

I'm looking into this as well. SPA. I may try setting up two instances of the component, testing if I can separate their states, and seeing how far that gets me.

I don't see how this could work with two instances since each instance with a component state would bleed into each other, i.e. "sidebarOpen: true" would open all the instances.

It's done... thanks for support

Uh, ok. I'd love to hear your solution if you got one.

constructor(props) {
    super(props);
	this.onSetSidebarOpen = open => {
		this.setState({ sidebarOpen: open });
	};
	this.onRightSidebarOpen = open => {
		this.setState({ rightSidebarOpen: open });
	};
	this.toggleSidebar      = this.toggleSidebar.bind(this);
	this.toggleRightSidebar = this.toggleRightSidebar.bind(this);
}

toggleSidebar() {
    this.setState({ sidebarOpen: true });
}
toggleRightSidebar() {
	this.setState({ rightSidebarOpen: true });
}

render:

					{navBar}
					{this.props.children}
			</div>
			</Sidebar>
			</Sidebar>

I used 2 component state and 2 methods and
called the component nested

I understand the separate states and methods.
What do you mean you "called the components nested?"
BTW, the author said the module wasn't made for this (see here), so kudos to you for figuring it out.

Not sure why it's out of the scope for this project. I haven't had time to look into it, but I'd like to fork this (or at least take touch support) and build my own.
I already have a working slidepanel component that supports multiple sidebars, but I have terrible touch support.

As I was making some changes I thought of an easier approach:
What if you just faked two sidebars by toggling the pullRight prop and then pass in a different component for the sidebar prop.


Allow for custom pin declarations?

It looks like this project uses hard coded pin definitions. The issue I'm facing is that the required pins are already occupied. I'm wondering if it would be possible to define custom pins via make flags?

You can use the make flags to change the DC and Reset pins. Since alternate pin functions for the Raspberry pi are fixed , it is not possible to change the SPI pins. Since Closing this issue .


Create data-lake-analytics-u-sql-python-extensions.md

Demonstrate how to use Python from within U-SQL

Hi @saveenr, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Saveen Reddy). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@saveenr Hi Saveen Please work in the private repo instead of the public repo.
After you move this content to the private repo, please close this pull request and use the new pull request in the private repo.
Here's help if you need to get started in the private repo.
Thanks.


Only require axis to be negative in vecdot and cross

Nonnegative axes and negative axes less than the smaller of the two arrays are unspecified.
This is because it is ambiguous in these cases whether the dimension should refer to the axis before or after broadcasting. Preciously, the spec stated it should refer to the dimension before broadcasting, but this deviates from NumPy gufunc behavior, and results in ambiguous and confusing situations, where, for instance, the result of a the function is different when the inputs are manually broadcasted together.
Also clean up some of the cross text a little bit since the computed dimension must be exactly size 3.
Fixes #724
Fixes #617
See the discussion in those issues for more details.
I don't think this should be backported, since my vecdot implementation in np.array_api and array-api-compat already followed the spec behavior here, and will need to be updated.

We could also allow nonnegative axis when the two input arrays have the same number of dimensions. In that case, there is no ambiguity for something like axix=0 because it would refer to the same dimensions both before and after broadcasting.

@kgryte could you remind me if this will be part of v2023?


[REMOVAL] Remove Brave and Librewolf from the browser list

State which point should be edited or removed. Put "Remove/ Edit ____" as Title
Remove Librewolf and Brave browser from the list.
Justification
Neither are truly privacy respecting. Please see: https://www.unixsheikh.com/articles/choose-your-browser-carefully.html

i perhaps should have mentioned for those that don't know, LibreWolf benefits from the arkenfox user.js project

Firefox has to tend to a large user-base. A user-base of frequent Google ecosystem users, some use Firefox for privacy. Not all though, the issue with making such a private/secure browser. Is that you have to tend to the entire user-base. Not just those who seek privacy and security features.

But even so, even if the user understand the AdTech business and technology deeply enough to give an informed consent, such consent should always be explicit and opt-in.

Explicit consent that requires opt-in would mean that at startup every new user would need to explicitly select their choices for about://config (Firefox) or brave://flags (brave) or chrome://flags (chrome) on setup and then also recheck it every time a browser is updated to make sure no unintended side effects have been brought in. Otherwise, one could argue that a new browser couldn't render HTML5 (since canvas elements can be used to fingerprint) all JS would be turned off, and we'd end up with an even more incompatible web platform compared to where we're at currently. I know that's not the argument you're making, but I point it out to show that the principle of explicit and opt-in can only be taken so far before it turns from a useful principle to a broken weapon. This is simply because of the complexity of trade offs that occur.
At some point, it's reasonable to accept that defaults will be set in order to accept tradeoffs between the extremes of usability (users can't configure anything and everything is handled for them by the developers) and consent (users have to configure everything and nothing is decided by the developer). Especially because it's a full time job to keep up with everything that browsers are changing. So to ask a user to do either one of those extremes seems unreasonable. This is why we have defaults in the first place, but also enable users to change them.
All in all, reasonable minds can differ on the same topic. Especially when it comes to incredibly nuanced topics such as privacy on the web and configuring a browser. However, I personally fall on the side that Librewolf and Brave should remain in this list because I think the net gains far outweigh the net losses to users. If others disagree with the outcome of this issue and @Lissy93 decision (whether these options stay or are removed) we always have the option to fork this repo and change it.
In any case, it was great to get other peoples take on this topic and I enjoyed hearing the differing perspectives of the values that motivates them as users, and presumably also developers since we're on GH, in choosing and building software.

back to basics...
@iio7 justification for wanting to ax LibreWolf and Brave is because "Neither are truly privacy respecting"
he/she is correct, if we assume default settings, and i don't think there's an argument there, but the same argument can be made for Firefox or any other modern browser, so the reason for wanting to eliminate LW and Brave specifically falls on its head right there (and i personally have serious concerns with Tor but that's another story)
no modern browser is truly privacy respecting out of the box, hence the need for projects like arkenfox ... and LibreWolf

There's been some good discussions here. For now, let's close this - as there aren't any serious privacy concerns regarding Brave (which are resolved in other browsers). But if anything changes, please do comment and I shall re-open.


--inspect-electron no output on Windows 10

Preflight Checklist

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

Electron Forge Version:

6.0.0-beta.53

Electron Version:

v10.1.3

Operating System:

Windows 10.0.18362 Build 18362

Last Known Working Electron Forge version::

not applicable

Expected Behavior

As stated in the docs https://www.electronforge.io/advanced/debugging I expect to be able to attach to the inspector and receive the console output after running electron-forge start --inspect-electron.
Actual Behavior

The connection is established. This worked for both chrome://inspect and WebStorm but the console just stays empty.
To Reproduce

Be on Windows 10
npx create-electron-app my-app
Replace the start script in package.json with electron-forge start --inspect-electron
Open chrome://inspect
Click Open dedicated DevTools for Node
Add localhost:9229
npm run start or electron-forge start --inspect-electron

Additional Information
I tested the same on Ubuntu and it is working as expected there. So this is probably an issue related to Windows 10. I've been able to attach and get the output for other projects just fine on Windows 10.
<!--

For example:
* Console output when you run your `electron-forge` command with the environment variable
  `DEBUG=electron-forge:*`. (Instructions on how to do so
  [here](https://www.npmjs.com/package/debug#usage)). Please include the stack trace if
  one exists.
* Command line arguments you are passing to `electron-forge` (e.g.,
  `electron-forge make --not-a-real-flag`)
* The `config.forge` data in `package.json` or `forge.config.js` in use
* A failing minimal testcase (with a link to the code) or detailed steps to reproduce the problem.
  Using `electron-forge init` is a good starting point, if that is not the source of your problem.

This seems to be working again in 6.0.0-beta.63.


Cookie storage fallback

Hi, I just saw this issue https://github.com/IdentityModel/oidc-client-js/issues/631 where they are trying to have some sort of persistence when local and session storage are not available (e.g. chrome incognito mode). Do you think we should provide this kind of fallback?

Interesting!
Supporting storing data in cookies would be really nice. The fallback on the otherhand is probably best handled by the library consumer, hard to make assumptions about the consumers intent.

Closing as out of scope


Add Boolean method to Python library for determining if there is a next page or not

We're pretty sure this was done a long time ago


For instance, settings path is now specified using --sp instead of -sp. We have a setting python.sortImports.args through which users pass arguments to the isort command we run. If we upgrade isort it'll break settings for all those users as many old flags are no longer valid.
I was wondering what's the reason for such changes and if it's possible to roll them back.

Hi @karrtikr!
Thanks for the work on VSCode! The reason is simply that single dash arguments with multiple letters can cause ambiguity:
Normally you can chain single dash arguments with one dash. So:
isort . -cv
Is the same as isort . -c -v or isort . --check --verbose. However, isorts previous inclusion of multi characters single dash arguments, breaks this expectation of CLI tools.
Let's say -r stands for remove all imports and -c stands for check, with -rc standing for --recursive.
It then becomes ambiguous to the user what will happen when isort -rc is called. It could either remove all imports and then check if that produces differences, or it could be recursive.

I was wondering what's the reason for such changes and if it's possible to roll them back.

I wouldn't want to roll back these changes at this point, as I think it's a necessary long term change. That said, like I have done for the other config changes I'm happy to reintroduce them for the rest of the 5.x.x cycle with a warning that they are deprecated and a link to the upgrade guide: https://timothycrosley.github.io/isort/docs/upgrade_guides/5.0.0/#-ac-wl-ws-tc-sp-sp-sl-sg-sd-rr-ot-nlb-nis-ls-le-lbt-lai-fss-fgw-ff-fass-fas-dt-ds-df-cs-ca-af-ac
If this would be helpful let me know.
Thanks!
~Timothy

Thanks, makes sense. I'll consult with the team and get back to you soon.

That said, like I have done for the other config changes I'm happy to reintroduce them for the rest of the 5.x.x cycle with a warning that they are deprecated and a link to the upgrade guide

I consulted with the team and this will do for now. We're thinking of showing a warning prompt to users passing all your warning messages. Are there any other warning messages you show regarding isort5?

Awesome! I've pushed out the improved isort warning reporting for these options in the 5.3.0 release.

Are there any other warning messages you show regarding isort5?

From CLI usage, the following other options don't do anything in isort 5 but do provide a warning linking to the 5.0.0 upgrade guide instead of failing: "--recursive", "-rc", "--dont-skip", "-ns", "--apply", "-k", "--keep-direct-and-as".
Similarly, from config file or API usage of isort ("not_skip", "keep_direct_and_as_imports") both don't have any impact, and do output a warning linking to the 5.0.0 upgrade guide.
And that should be the extend of it.
Thanks!
~Timothy

That's great. Couple of comments,

I just realized that users might be receiving multiple warnings messages at the same time - one for each CLI flag? + other warnings. Showing separate warning prompts for all these messages doesn't seem right, ideally we should only have one warning prompt pointing to the upgrade guide. Is it possible to include something like an Error code in all these deprecation messages, which will help us club all these warnings together and show just one single prompt?

If you have multiple configs, they will need to be merged into 1 single one.

We're not showing warnings for users with multiple configs, I guess we actually can't. Is it possible to warn users about this kind of scenario?

Thanks for the feedback! I've ensured a minimal number of warnings (one for each type) will be raised and that each will have a code associated with it for easy identification:
https://timothycrosley.github.io/isort/docs/warning_and_error_codes/W0500/
This is deployed to PyPI in the 5.3.1 release.
Thanks!
~Timothy

Thanks for including the codes, when will the release take place? We can start upgrading after that.
Should be W0503: https://github.com/timothycrosley/isort/commit/6ed0cd3edbc42b935de74554d995f9288391ac4c#r41272904
Any thoughts on the second question I had?

Thanks for the note! I've pushed out a hot fix release to fix the incorrect code (5.3.2).
Yes, sorry meant to answer it earlier! It is possible to identify the other config files that would have been merged, but it would come with a hefty performance penalty on some code bases as it isn't trivial: isort would have to look at every one of the "shared" config file formats it is able to read from, all the way up to root, to see if any of them contain an isort section that would have been merged. Just seeing that the config files isn't enough, since they are used for many tools.

Cool, that's understandable. The number of users who fall into that category and won't receive any other warning messages are pretty low anyway, so we need not worry 🙂
Thanks again for addressing all the concerns, closing this.


Allow uploading when  config_manifest is not specified in the google artifact registry

#112
The issue causing errors in Google Artifact Registry when no config_manifest was specified has been resolved.
I could not reproduce this problem with the test method shown in the Developer's Guide, but I have confirmed that it is resolved in my own environment.

Thanks!


CGImage to shaped array fix

The problem appears when accelerate uses padding for performance. We were lucky that it didn't happen for 512x512, but it does for 1024x0124. This is a problem for #227, but may also affect models with custom sizes.

Thank you for your interest in contributing to Core ML Stable Diffusion! Please review CONTRIBUTING.md first. If you would like to proceed with making a pull request, please indicate your agreement to the terms outlined in CONTRIBUTING.md by checking the box below. If not, please go ahead and fork this repo and make your updates.
We appreciate your interest in the project!
Do not erase the below when submitting your pull request:
#########

[x] I agree to the terms outlined in CONTRIBUTING.md

I was perplexed by this issue but your fix makes perfect sense, nice!


#1023 Updated implementation for ComponentPopulator

Type of Change

[x] Enhancement (non-breaking change that affects existing code)

Description
The current primary implementation of ComponentPopulator, the ContextualComponentPopulator, is a remnant of the old core implementation with all the associated drawbacks. The class is chaotic, has too many responsibilities at once, and is not easily extended.
These changes introduce several strategies for a common StrategyComponentPopulator. This consists of two primary elements:

ComponentPopulationStrategy
ComponentInjectionPointsResolver

Population Strategies
Population strategies allow us to define what information should be injected into given injection points (e.g. fields or method parameters). The StrategyComponentPopulator is able to track a collection of strategies, so it remains possible to customize which strategies are applied. As component population is a core component of the ComponentFinalizingPostProcessor, it has been made configurable with appropriate customizers.
There are two built-in strategies:

ContextPopulationStrategy: This strategy is responsible for supporting injection points annotated with @Context, and resolving the appropriate context on the application context.
InjectPopulationStrategy: This strategy is responsible for supporting injection points annotated with @Inject, and obtaining the appropriate instance from the application context. The annotation(s) supported by this strategy are configurable, so support for custom injection markers is possible.

Both strategies have appropriate customization support, and can be (un)installed from the populator if preferred.
Injection Points Resolvers
To inject content into injection points, you first need to know what the injection points are. Injection points resolvers take care of this step. The default implementation is the MethodsAndFieldsInjectionPointResolver, which is also configurable in the configurer for StrategyComponentPopulator. This resolver respects the existing @Populate annotation, and will only include injection points compatible with this marker if it is present. If @Populate is not present, both methods and fields will be included as injection points.
Checklist

[x] I have performed a self-review of my own code
[ ] I have added tests that prove it is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Related issue number is linked in pull request title
[ ] I have added documentation that describes my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have rebased my branch on top of the latest develop branch

Related Issue
Closes #1023

Following up on CVE-2023-6378 in #1029 (0.5.1) and #1030 (0.6.0)

Pending: hooks for processing the value into the injection point


Specify adjustment transform

Hi, is there a way to apply an adjustment transform? I need to adjust the position of the 3d tiles. This works on Cesium ion, it adds a transform array but I would like to be able to do this kind of thing with this library or is there a way to patch the generated tileset.json file?

Found that I can just do this via Cesium js API.


params block is required on action

I don't now if it should be considered as a bug or as a missing documentation, however is something that might be tricky for a new user (as me) to debug.
module V1
  module Resources
    class BusinessUnits
      include Praxis::ResourceDefinition
      ...
      action :index do
        routing { get '' }
        # no params block here
        response :ok, media_type: Praxis::Collection.of(V1::MediaTypes::BusinessUnit)
      end
    end
  end
end

In an action definition (on a resource), if you have no params, you cannot remove the params block at all, since otherwise you get this error when you try to poll the resource endpoint:
ERROR -- : #<NoMethodError: undefined method `attributes' for nil:NilClass>
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/extensions/field_expansion.rb:20:in `expanded_fields'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/extensions/field_expansion.rb:12:in `expanded_fields'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/extensions/rendering.rb:11:in `render'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/extensions/rendering.rb:24:in `display'

So - to avoid the error - you should keep the empty params block inside the action definition:
module V1
  module Resources
    class BusinessUnits
      include Praxis::ResourceDefinition
      ...
      action :index do
        routing { get '' }
        # empty params block to avoid error
        params {}
        response :ok, media_type: Praxis::Collection.of(V1::MediaTypes::BusinessUnit)
      end
    end
  end
end

This trick resolve the issue on the API server, but breaks the document generator task:
> bundle exec rake praxis:docs:preview --trace                                                                                [42/3326]
** Invoke praxis:docs:preview (first_time)
** Invoke praxis:docs:install (first_time)
** Execute praxis:docs:install
** Invoke praxis:docs:generate (first_time)
** Invoke praxis:environment (first_time)
** Execute praxis:environment
** Execute praxis:docs:generate
Generating Index file: ~/Development/epersonamapi2/docs/api/index-new.json
rake aborted!
NoMethodError: undefined method `keys' for nil:NilClass
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/action_definition.rb:273:in `params_description'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/action_definition.rb:229:in `block in describe'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/action_definition.rb:219:in `tap'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/action_definition.rb:219:in `describe'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/resource_definition.rb:282:in `block (2 levels) in describe'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/resource_definition.rb:282:in `collect'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/resource_definition.rb:282:in `block in describe'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/resource_definition.rb:279:in `tap'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/resource_definition.rb:279:in `describe'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/docs/generator.rb:155:in `block in dump_resources'
~/.rbenv/versions/2.3.0/lib/ruby/2.3.0/set.rb:306:in `each_key'
~/.rbenv/versions/2.3.0/lib/ruby/2.3.0/set.rb:306:in `each'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/docs/generator.rb:151:in `each_with_object'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/docs/generator.rb:151:in `dump_resources'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/docs/generator.rb:124:in `write_version_file'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/docs/generator.rb:44:in `block in save!'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/docs/generator.rb:43:in `each'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/docs/generator.rb:43:in `save!'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/praxis-0.20.1/lib/praxis/tasks/api_docs.rb:62:in `block (3 levels) in <top (required)>'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task.rb:248:in `block in execute'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task.rb:243:in `each'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task.rb:243:in `execute'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task.rb:187:in `block in invoke_with_call_chain'
~/.rbenv/versions/2.3.0/lib/ruby/2.3.0/monitor.rb:214:in `mon_synchronize'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task.rb:180:in `invoke_with_call_chain'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task.rb:209:in `block in invoke_prerequisites'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task.rb:207:in `each'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task.rb:207:in `invoke_prerequisites'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task.rb:186:in `block in invoke_with_call_chain'
~/.rbenv/versions/2.3.0/lib/ruby/2.3.0/monitor.rb:214:in `mon_synchronize'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task.rb:180:in `invoke_with_call_chain'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/task.rb:173:in `invoke'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/application.rb:150:in `invoke_task'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/application.rb:106:in `block (2 levels) in top_level'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/application.rb:106:in `each'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/application.rb:106:in `block in top_level'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/application.rb:115:in `run_with_threads'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/application.rb:100:in `top_level'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/application.rb:78:in `block in run'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/application.rb:176:in `standard_exception_handling'
~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rake-11.1.2/lib/rake/application.rb:75:in `run'

So, it's likely as you cannot have no params at all in your actions...

absolutely. That is a bug. I have a fix on the way.
Thank you! and keep the feedback coming!


release api-client v0.17.0

[x] update cargo.toml versions
[x] add new tag
[x] release new release text

Released: https://github.com/scs/substrate-api-client/releases/tag/v0.17.0


chore(gateway): Deprecate MessageSender in favour of MessageQueue

This Pull Request renames MessageSender to MessageQueue, and provides a deprecated typealias of MessageSender as MessageQueue; renames functions that returns MessageQueue from sender() to message_queue() and deprecates existing pre-renamed functions. An example has also been updated to reflect this change.
As of this discussion on Discord, it has been agreed upon that MessageQueue would be a better name that fits the use case of the structure.
The deprecated items, MessageSender, MessageChannel#sender and Shard#sender,  introduced in this Pull Request is scheduled for removal in the next major version, 0.16, in favour of MessageQueue, MessageChannel#message_queue and Shard#message_queue.

Hi there, would you mind rebasing this on next and making the breaking changes so we can get this merged for a new release? If not, please let us know so someone else could pick this up. Thanks in advance!

I've changed my mind on this change, I think it would be better to keep MessageSender as is, but remove command, add a warning to send (or rename it to send_immediately), and add a enqueue & enqueue_command method pair that queues things via MessageSender without first calling sender.
My thought process is that MessageSender is supposed to be used in a different task, so although adding "Queue" to its name would boost its visibility, it'd be a semantically incorrect name and we can instead add queue commands directly to Shard (mentioning MessageSender for use with cross-task access)

Alright, I’ll do that tonight.


Confirmation macro does not work

Documentation described the following syntax:
required(:attr).confirmation

But it doesn't work:
params = Dry::Validation.Params do
  required(:password).confirmation
end
NoMethodError: undefined method `confirmation' for #<Dry::Validation::Schema::Rule:0x00007fab5e41c4e8>

Try with required(:password).filled(min_size?: 6).confirmation

@jferrer it works

Closing because confirmation is going away in the 1.0.0 rewrite


CON-5301: fixed limits for Image Import over cron

B4A had performance problems with this one because one product had 750
variants we wanted to import all images from the variants in one cron run
now the limit takes the number of variants as the limit
also the main article images are just imported for the main variant

Coverage decreased (-0.08%) to 42.168% when pulling 26f185c674ed10c2cdc515a6e506c4180bdf6a15 on CON-5301 into 59386cf18b43a5966987fc84cc916497831050f5 on master.


Regionalization notebook

Notebook for regionalization. Works except for 2 things:
1-WPS hangs and will not exit infinite loop until you hit enter at the command line in the terminal that is running RAVEN.  The terminal will stop searching for "something" and return the response.
2- The plotting of the "ensemble" hydrographs is returning a bitmap image instead of a line graph.

Fixed. It was the version attribute. We launch raven with no parameters to get a string with the version. But I think there was a change with the latest version and now it expects a Return.
@julemai I've been able to fix this, but why would raven wait for return ?

For 2 you need to specify what kind of plot you want when it's not obvious (multiple dimensions).


BUG: Some macros require trailing semicolons for Numpy 1.7.

In Numpy 1.7 some macros have had their trailing semicolons removed
in the include file, hence require them in the source.

Pushed in 1eac7bf.


Please update for VS2017 and higher

This page could use an update to how to disable security warning for VS2017 and higher as the current page does not support newer releases of Visual Studio

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 13df8304-e6f6-6998-0378-65cb03bb81c4
Version Independent ID: 1acfc047-cf95-dc15-94b8-0f476dffead7
Content: Security Warning: Attaching to a process owned by an untrusted user can be dangerous. If the following information looks suspicious or you are unsure, do not attach to this process - Visual Studio
Content Source: docs/debugger/security-warning-attaching-to-a-process-owned-by-an-untrusted-user.md
Product: visual-studio-windows
Technology: vs-ide-debug
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

I'd just like to add that I encountered this problem when I assigned a custom application pool user in IIS. When I then debug an application that uses the service on that application pool, I get this warning because the custom application pool user is "untrusted".
The reason I assign custom application pool user is to simulate the production environment.


photivo: fix build with lensfun >= 0.3

Motivation for this change
To fix photivo build in master and 17.03.
Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] Linux

[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

For some reason the current commit is broken for me:
building path(s) ‘/nix/store/x0c2w5wzwn87vgfrzwxl9pz0v7riqhhc-photivo-2014-01-25’
unpacking sources
unpacking source archive /nix/store/my4wwhj7id1aqn0a95vqj7m70601qfl9-hg-archive
source root is hg-archive
patching sources
applying patch /nix/store/aswza9pn5mwxjj3w4jjygxa1ggyh3cvy-lensfun-0.3.patch
patching file Sources/ptConstants.h
Hunk #1 FAILED at 222 (different line endings).
1 out of 1 hunk FAILED -- saving rejects to file Sources/ptConstants.h.rej
patching file Sources/ptGuiOptions.cpp
Hunk #1 FAILED at 177 (different line endings).
1 out of 1 hunk FAILED -- saving rejects to file Sources/ptGuiOptions.cpp.rej
patching file Sources/ptMainWindow.cpp
Hunk #1 FAILED at 3067 (different line endings).
1 out of 1 hunk FAILED -- saving rejects to file Sources/ptMainWindow.cpp.rej
patching file Sources/ptProcessor.cpp
builder for ‘/nix/store/387vdx6yd47abkzr2d0x83w9di4cd0c2-photivo-2014-01-25.drv’ failed with exit code 1
error: build of ‘/nix/store/387vdx6yd47abkzr2d0x83w9di4cd0c2-photivo-2014-01-25.drv’ failedbuilding path(s) ‘/nix/store/x0c2w5wzwn87vgfrzwxl9pz0v7riqhhc-photivo-2014-01-25’
unpacking sources
unpacking source archive /nix/store/my4wwhj7id1aqn0a95vqj7m70601qfl9-hg-archive
source root is hg-archive
patching sources
applying patch /nix/store/aswza9pn5mwxjj3w4jjygxa1ggyh3cvy-lensfun-0.3.patch
patching file Sources/ptConstants.h
Hunk #1 FAILED at 222 (different line endings).
1 out of 1 hunk FAILED -- saving rejects to file Sources/ptConstants.h.rej
patching file Sources/ptGuiOptions.cpp
Hunk #1 FAILED at 177 (different line endings).
1 out of 1 hunk FAILED -- saving rejects to file Sources/ptGuiOptions.cpp.rej
patching file Sources/ptMainWindow.cpp
Hunk #1 FAILED at 3067 (different line endings).
1 out of 1 hunk FAILED -- saving rejects to file Sources/ptMainWindow.cpp.rej
patching file Sources/ptProcessor.cpp
builder for ‘/nix/store/387vdx6yd47abkzr2d0x83w9di4cd0c2-photivo-2014-01-25.drv’ failed with exit code 1
error: build of ‘/nix/store/387vdx6yd47abkzr2d0x83w9di4cd0c2-photivo-2014-01-25.drv’ failed

Note that this might be caused by git modifying the patche's line endings:
% curl 'https://www.linuxquestions.org/questions/attachment.php?attachmentid=17287&d=1420577220' > /tmp/foo
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2918  100  2918    0     0   4148      0 --:--:-- --:--:-- --:--:--  4144
moritz@moritz-x260 ~/dev/nixpkgs (git)-[master] % file /tmp/foo
/tmp/foo: unified diff output, ASCII text, with CRLF, LF line terminators

% file pkgs/applications/graphics/photivo/lensfun-0.3.patch
pkgs/applications/graphics/photivo/lensfun-0.3.patch: unified diff output, ASCII text
```

I'm not sure how to disable this behavior in git though.

Well, isn't that interesting… Seems like git will change the line ending unless you have a global configuration set or use a gitattributes file. I'm reluctant to add a gitattributes file just for this file.
So I'm inclined to just use the forum source. It's been a stable link for like two years so hopefully it will stick around for longer. Alternatively, can use https://github.com/driesz/photivo/ as upstream, it seems to include this fix and some other stuff. Don't know how official it is, though.

@rycee Agreed. Let's just use the forum source. Git should really have a global blacklist for things like patchfiles.

Yeah, keeping precise newlines on *.patch and *.diff might be a good idea. That's for another time and another PR though :-)
I switched back to downloading the patch from the forum.

Applied in 747b62f909, thank you!

Applied to 17.03 in 9279742eed

Cheers!


Support for 6 month + vaccine products

We're hoping to see approval for new vaccine products, "Modern 6 month - 5 year", and a "Pfizer 6 month - 4 year". Is the a code we should look for for these coming from univaf sites? I believe we have an unused pfizer_age_2_4 that may be repurposed.

We can also rename this to pfizer_age_0_4 real quick if that would be better.
Otherwise, we’re on it! For sources that use CVX codes (some SMART Scheduling Links sources, but not all) or NDC codes (the CDC), this should just work. For all the others (e.g. Albertsons chains, Rite Aid), we’ve got alerts for whenever we encounter a new vaccine name that should help us get these hooked up as soon as they start showing up in source data. 👍

Will also add a moderna_age_0_5 for the corresponding Moderna vaccine, which it looks like was also approved.

Just to clarify, @dhcole, I’d like to rename it to pfizer_age_0_4, but want to make sure you aren’t already expecting/depending on the old name first. So let me know if that’s ok, please!

Yes renaming is fine with us. Thanks @Mr0grog

Alright, I renamed pfizer_age_2_4 to pfizer_age_0_4 and did a bunch of other cleanup and screw-tightening on vaccine types over in #714.
So the vaccine products you should expect to see in UNIVAF in the future are:

astra_zeneca
jj
moderna
moderna_age_6_11
moderna_age_0_5
novavax
pfizer
pfizer_age_5_11
pfizer_age_0_4
sanofi (not actually approved for use in the US yet)

I think we’ve done everything that can reasonably done in advance here, so I’m going to close this issue. Thanks for raising it, @dhcole!


Only compile the regular expression once

There is more benefit to compiling a regular expression if you only have
to compile it once. Moving it from inside a function to the module
level reduces the number of times it's compiled from once per time
parse is called to once per interpreter instantiation. To achieve
this, the code inside _get_duration_re is being moved to the module
level and the function is being removed.
One implementation change of note: a list comprehension is being used to
build the list of expressions to compile so that its memory is allocated
only once.

:+1: I had it like this at one point but then thought it would be ugly to have all of the global variables... I'm ok with the change though and will bump the build version once this is merged and push out the latest build to pypi

latest version up on pypi: ```

python setup.py sdist upload
running sdist
running egg_info
writing delta.egg-info/PKG-INFO
writing top-level names to delta.egg-info/top_level.txt
writing dependency_links to delta.egg-info/dependency_links.txt
file delta.py (for module delta) not found
reading manifest file 'delta.egg-info/SOURCES.txt'
writing manifest file 'delta.egg-info/SOURCES.txt'
warning: sdist: standard file not found: should have one of README, README.rst, README.txt

running check
creating delta-0.4.1
creating delta-0.4.1/delta
creating delta-0.4.1/delta.egg-info
creating delta-0.4.1/test
making hard links in delta-0.4.1...
hard linking setup.cfg -> delta-0.4.1
hard linking setup.py -> delta-0.4.1
hard linking delta/init.py -> delta-0.4.1/delta
hard linking delta/parse.py -> delta-0.4.1/delta
hard linking delta.egg-info/PKG-INFO -> delta-0.4.1/delta.egg-info
hard linking delta.egg-info/SOURCES.txt -> delta-0.4.1/delta.egg-info
hard linking delta.egg-info/dependency_links.txt -> delta-0.4.1/delta.egg-info
hard linking delta.egg-info/top_level.txt -> delta-0.4.1/delta.egg-info
hard linking test/test_parse.py -> delta-0.4.1/test
copying setup.cfg -> delta-0.4.1
Writing delta-0.4.1/setup.cfg
Creating tar archive
removing 'delta-0.4.1' (and everything under it)
running upload
Submitting dist/delta-0.4.1.tar.gz to https://pypi.python.org/pypi
Server response (200): OK


45$

@Gusto813 https://github.com/valentinilk/compose-shimmer/assets/132805367/41a85a21-4457-47f2-9171-a8500d33a2c3

- [ ] - ~~````


Prevent watch stream from reconnecting after intentional pause or detach

What this PR does / why we need it?
I've addressed the issue where the watch stream reconnects after intentional pausing or detaching.
(Ref: https://connectrpc.com/docs/web/cancellation-and-timeouts/)
https://github.com/yorkie-team/yorkie-js-sdk/assets/81357083/610ce5f8-570c-45e2-b336-df5b00a0d784
Any background context you want to provide?
Although this patch works in browser examples, it fails in test cases.
I have a suspicion that the code(if (reason instanceof Error)) within connectrpc doesn't work correctly within the jsdom test environment. I need some help with this.
https://github.com/connectrpc/connect-es/blob/fd9a93127e1671cf614f14c7d410ec6b9b30b025/packages/connect/src/connect-error.ts#L115
What are the relevant tickets?

Fixes #771
Checklist

[ ] Added relevant tests or not required
[x] Didn't break anything

@blurfx Can we ask for help with reason instanceof Error issue?

@blurfx It is not urgent. It is not urgent. Please take a look when you have time.

The changes from this task have been merged into #789, so I'll close this PR now. If additional testing is required, I'll create a separate PR for it.


feat: improve api key usage

#73

:tada: This PR is included in version 1.29.0 :tada:
The release is available on:

GitHub release
v1.29.0

Your semantic-release bot :package::rocket:


Update manifest.json

Hide the status bar on iOS and Android (when added to home screen)

Thanks for submitting. I will work on getting this integrated shortly.

Currently on staging, sorry about the delay. It will part of the next major release.
Links for staging:
https://play-staging.webrcade.com/ (player)
https://editor-staging.webrcade.com/ (editor)


Yield farming on ALEX

A high LTV (even on a static collateral) can be offered between ayTokens of different maturities. For example, ayToken-1y as collateral may achieve 90% LTV to mint ayToken-O/N (similar to borrowing overnight to buy long-term asset).
This allows "yield farming" whereby you repeat the process of buying ayToken-1y, use it as collateral to mint and sell ayToken-O/N for Token (to buy ayToken-1y) to achieve a high APY (assuming ayToken-1y APY > ayToken-O/N APY).
For example,

Rachel has 100 BTC.
Rachel spends 100 BTC and buys ayBTC-1y. She uses it as collateral to borrow ayBTC-O/N at 90% LTV.
She sells the borrowed ayBTC-O/N (from (2)) and buys ayBTC-1y. She uses it as collateral to borrow ayBTC-O/N at 90% LTV.
She repeats (3).

If 1y APY is 10% and O/N APY is 5%, the above "yield farming" results in APY approaching 55%.
Mathematically,

An illustration is available here.

I wonder if there are any conditions on the limit of repeated collaterals, e.g. once per day?  Based on the illustration, if we can do an infinite number of loans within a day, the APY is exactly 55%  APY_1y/ (1-LTV) + APY_1d* LTV/(1-LTV).  Did I miss anything?

There are a lot of assumptions to be made to reach your conclusion. I think max 55% is right. but as you are exposed to almost 10x leverage, all the positions could be unwound, and you would lose the capital should margin falls below 90%

Yes, we will need to determine the max number of repeats a borrower can do and aggregate them as a single (atomic) transaction (so a single click allows this to happen). This will be an interesting alternative to liquidity miners (who look for high APY with principal at risk) and encourages liquidity build-up on the platform (10x exposure on dollar).
Thinking about offering this as a “pro” user option (given its risk).

From: Rredlion @.>
Sent: Wednesday, June 23, 2021 4:06:00 AM
To: alexgo-io/alex-v1 @.>
Cc: fiftyeightandeight @.>; Author @.>
Subject: Re: [alexgo-io/alex-v1] Yield farming on ALEX (#13)
There are a lot of assumptions to be made to reach your conclusion. I think max 55% is right. but as you are exposed to almost 10x leverage, all the positions could be unwound, and you would lose the capital should margin falls below 90%
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/alexgo-io/alex-v1/issues/13#issuecomment-866296177, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AADMGWPXC4AFM54RQI2POQTTUDUKRANCNFSM47D5BV3Q.


gh #82 Modified Audio l1 test cases as per latest audio.h

Modified Audio L1 test suite as per the latest audio.h interface file.

No comments

_ No description provided. _

Please add description

_ No description provided. _

Please add description

done


Add Zoom # to Friday

Similar to the way that Thursday schedule has Zoom # can we add these to Friday? The specific number to add to each is in the minute by minute spreadsheet.
@corcra, hoping you can take a look at this in the AM to take advantage of time difference.

I've done this (#75) but as per my comment on #72, I copied Marzyeh's convention on Thursday and gave the tutorials 7A and 7B (to make it clear they're simultaneous), so it doesn't entirely match what's in the spreadsheet.


Recommend pinning to commit SHA or release tag

To protect against latest version incompatibility and potential supply chain attack (e.g. codecov), please recommend pinning to a commit SHA, or at least a release tag.
Also, consider packaging this in a GitHub Action.
https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

Hi @joebowbeer, thanks for the issue report!
Could you expand on what value you'd like to gain with a GitHub Action over the existing bash approach? The workflow to run audit-ci is one line of bash: npx audit-ci@{version} --config ./audit-ci.jsonc.
I could also use some clarification on how you'd like to update the documentation. Notably, in the docs, I do recommend using npx audit-ci@^6 --config ./audit-ci.jsonc instead of npx<EMAIL_ADDRESS>--config ./audit-ci.jsonc. If that's what you're referring to, I've done that intentionally to try and find a good balance of not breaking pipelines and trying and help bring new updates to consumers conveniently. Yes, if this project went rogue and published malware, non-pinning consumers may be at risk. However, I am comfortable with that trade-off for this project as we have a small and trusted group of developers managing it (a total of two) with MFA on GitHub and NPM.
On the other hand, what does make sense is to strictly pin our dependencies. While I've personally vetted every line of code of the distributed JS of our dependencies for the versions that we depend on, they aren't pinned (they use ^), so my vetting may be moot by now since the dependencies may update. I may set our package.json's dependencies to use version pinning on versions that I've personally vetted. This kind of goes along with #124 where I was wondering if I can pin transitive dependencies by publishing the package-lock.json. I don't think that's how it works, but I am open to ideas to pinning transitive dependencies.

You are absolutely right about missing pinning. I've updated all documented references for npx/{yarn|pnpm} dlx to use audit-ci@^6 here: #273. I still do see the point and appreciate pinning to a specific version. I may follow up with a note about using a pinned version, but at least #273 starts to cover your suggestion.

but I didn't see any security-related justification

Fair! Open to improvements in this area.

npx is susceptible to typosquatting

Yeah, I can appreciate that as well. Typosquatting can only really be prevented with the usage of an SHA, as you mentioned. Reasonable to consider documenting that tbh, have to think about that a bit more and find a convenient way to provide that SHA as documentation. Open to ideas!

I used to trust repos, especially ones that were created to tighten security, but now I prefer trusting as little as possible (zero trust).

Agreed 👍🏻

Pinning all dependencies would be great.

I've already pinned the "less common" dependencies, but definitely am considering pinning all dependencies. I'd also consider finding a way to pin transitive dependencies. They were originally not pinned to support deduplication when performing --save-dev. However, I've since moved off suggesting --save-dev to ensure that we run an audit before the CI/user runs postinstall. Now that we suggest npx, deduplication is not as important.


Fix compile errors related to errno.h

Because errno.h is defined in terms of a syscall we can get into trouble
when one syscall/<FOO.h> ends up include another syscall/<BAR.h>.
Moving errno.h from kernel_includes.h to kernel.h breaks the possible
inclusion issue on some ARM platforms (which arm_mpu.h ends up include
soc.h which ends up include kernel_includes.h which would include
errno.h).
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

@andrewboie this is a bit of a stop gap to get some of CI building again

Codecov Report

Merging #9130 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9130   +/-   ##
=======================================
  Coverage   52.45%   52.45%
=======================================
  Files         200      200
  Lines       25121    25121
  Branches     5244     5244
=======================================
  Hits        13178    13178
  Misses       9822     9822
  Partials     2121     2121

Impacted Files
Coverage Δ

include/kernel.h
98.43% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97c06a7...d665ace. Read the comment docs.

pushing anyways to unbreak CI

Is this for #9054 or something else?

Is this for #9054 or something else?
Restore branch

it was for something else.


Other color for cancel button

Canceled workflows are displayed in a grey color very similar to the oscillating grey for running workflows. To make the two easier to distinguish between I'd suggest displaying it in a different color. Perhaps yellow to sync with what is displayed in the CLI? I can see if this is not high up on the priority list, but I just thought I'd mention it.
Keep up the good work!

Resolved in https://github.com/StackStorm/st2web/pull/316

Awesome!


Stress Test

Describe the feature you'd like supported
A stress test should be authored that would do the following in large scale:

program load / unload / run -- #2099
map create / delete + CRUD
link attach / detach -- #2099

Also for net ebpf extension the following should be tested:

large volume of packets (XDP)
large volume of connections (socket hooks)

Proposed solution
Take the performance test and create a stress test that focuses on scale instead of perf.
Dedicated traffic stress tests should be authored for netebpfext.
Additional context
No response

@gtrevi  please work with @Alan-Jowett  to see if we already have some tests for map create / delete + CRUD. If so, all you have to do is run it with multiple threads to test for concurrency issues. The challenge here is exhaustively testing the different map types, specially the map-in-map, array of maps, array of programs and ring-buffer maps.


Add global config

As a dev,
I want a way to easily override the default duration globally,
so that I don't have to override the duration on every call to minimumDuration.

Completed in 965a19f9741a5bc0b2ec644d58080f0ef43461d9


it's not "native", it's "vanilla"

"native" nowadays means "a system app" -- mobile or desktop, i.e. "does not depend on a web-browser"
what you wanted to say is "vanilla" -- b/c it dosnt need babel, webpack or a WASM compiler

Thanks, I'm gonna change it.

native for me would also include if it was a language feature, but it's not, more of a hack

In this spirit, are you specifically trying to align as closely as possible to https://github.com/tc39/proposal-pattern-matching?

@depoulo No. That proposal is not mature yet, there are a lot of caveats, besides not being able to be close anyway due the proposal features rely mostly on Javascript syntax changes.

Still says "native" on the front-page https://z-pattern-matching.github.io/
It's not native. It's vanilla.

It still says native

I don't know why this issue was closed, reopening right now, thanks for the warning @ForsakenHarmony and @naomik
Just to remember this project isn't "mine" and it's open to anyone send PRs, I'm currently assigned to update the whole website (including new features done past weeks) which is a higher priority, but after that, I can work on this also if still this description. Thanks.

it's on the website


sink/producer(ticdc): migrate test-infra to testify for kafka producer

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tiflow/issues/2164
What is changed and how it works?
migrate test-infra to testify for kafka producer.
Check List
Tests

Unit test

Code changes

Has exported function/method change

Side effects
None
Related changes
None
Release note
None

Codecov Report

Merging #4981 (d87a50f) into master (687e248) will decrease coverage by 0.3545%.
The diff coverage is 53.0038%.

Flag
Coverage Δ

cdc
60.9975% <41.9154%> (+0.3989%)
:arrow_up:

dm
51.5855% <70.4501%> (-0.8840%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #4981        +/-   ##
================================================
- Coverage   56.1240%   55.7694%   -0.3546%
================================================
  Files           522        522
  Lines         65325      66705      +1380
================================================
+ Hits          36663      37201       +538
- Misses        25094      25824       +730
- Partials       3568       3680       +112

/merge

/run-leak-test

/run-kafka-integration-test