Design for simple derived columns

This task is automatically imported from the old Task Issue Board and it was originally created by James Dunkerley.
Original issue is here.

Add a constant column
Add an index column (grouped or not, step, start control)
Duplicate a column
Simple operators on a column
Agree core set of functions

Should work for both in-memory and database.
Blockers:
#183631044 resolved
#183679097 resolved
#183679097 resolved
#183686167 resolved
#183679123 blocked
#183692164 blocked
#183692199 resolved
#183692217 blocked
#183692234 blocked
Comments:
James Dunkerley reports a new STANDUP for today (2022-10-10):
Progress: Started on tidying up Examples, Geo, Google, Test and Image libraries. Aiming to complete their tidying tomorrow. Started writing up the design for the derived columns. It should be finished by 2022-10-17.
Next Day: Next day I will be working on the #182653851 task. Continue working on design. (Enso Bot - Oct 10, 2022)

**James Dunkerley** reports a new **STANDUP** for today (2022-10-11):
Progress: Working over the performance of the Vector.Builder PR. Some design work on the expressions code. It should be finished by 2022-10-17.
Next Day: Next day I will be working on the #182653851 task. Continue working on design. (Enso Bot - Oct 11, 2022)

**James Dunkerley** reports a new **STANDUP** for today (2022-10-12):
Progress: Looking further at tuning Vector performance. Working on derived columns design. Review with Ned. It should be finished by 2022-10-17.
Next Day: Next day I will be working on the #182653851 task. Continue working on design. (Enso Bot - Oct 12, 2022)

**James Dunkerley** reports a new **STANDUP** for today (2022-10-13):
Progress: Completing the design document and tidying up all the mistakes. It should be finished by 2022-10-17.
Next Day: Next day I will be working on the #182653851 task. Finish the design and put out for PR. (Enso Bot - Oct 13, 2022)

**James Dunkerley** reports a new **STANDUP** for today (2022-10-14):
Progress: Small amount of work on design. PR for Radek. Finished tidying Image and Test libraries (PR raised). Improved Vector tuning - just Filter left to improve. It should be finished by 2022-10-17.
Next Day: Next day I will be working on the #182653851 task. Finish the design and put out for PR. (Enso Bot - Oct 14, 2022)

**James Dunkerley** reports a new **STANDUP** for today (2022-10-17):
Progress: Finished the tidying PR. PR raised on the design. Addresses a lot of Ned and Radek's comments. It should be finished by 2022-10-17.
Next Day: Next day I will be working on the #182653851 task. Something else... (Enso Bot - Oct 17, 2022)

Related:

[ ] #5265
[ ] #5333
[ ] #5227
[ ] #5261

Closing as have the design.


Unable to use world names including spaces

Hey,
My world name unfortunately contains a space.
Is there a way to still use this world in commands?
If you, can you implement one? Something like 'wor ld', for example?
Thanks

I had the same issue. The workaround we used was renaming to use _ instead of space. Not quite ideal but no form or '', "", etc worked.

World names with spaces are not supposed to exist. Mojang & Bukkit do not work properly with them. The correct naming scheme is lower_snake_case


Receiving messages on subscription as publish packets

I am getting some weird behavior where an incoming message on the subscribe topic seems to be handled as a publish packet, then instead of being handled by my callback function is reported as an unexpected message.
If it is relevant, I am using Sloeber (Eclipse), the board is an ESP12F and I am connecting using WiFiClientSecure. Publishing works perfectly.
The log displays the following when a message is published by the broker on the subscription topic.
MQTT - Process message, type: 3
MQTT - Publish received, qos: 0
MQTT - Unexpected message

I have wrapped the MQTT functionality in a separate class. Code is as follows.
in project.cpp
void setup () {
  wifiWrapper.connect("ssid", "password");
  mqttWrapper.setup();
  mqttWrapper.loadCertificate();
  yield();
  mqttWrapper.connect("mqtt-server.com", 8883, "username", "password");
  mqttWrapper.mqtt->subscribe("test/subscribe", MqttClient::QOS0, subCallback);
  yield();
}

void loop () {
  mqttWrapper.mqtt->yield(10000);
}

in project.h
void subCallback (MqttClient::MessageData& md) {
  const MqttClient::Message& msg = md.message;
  char payload[msg.payloadLen + 1];
  memcpy(payload, msg.payload, msg.payloadLen);
  payload[msg.payloadLen] = '\0';
  Serial.println(payload);
}

in mqttWrapper.cpp
void MqttWrapper::setup () {
  MqttClient::System *mqttSystem = new System;
  MqttClient::Logger *mqttLogger = new MqttClient::LoggerImpl<HardwareSerial>(Serial);
  MqttClient::Network * mqttNetwork = new MqttClient::NetworkClientImpl<WiFiClient>(wifiClientSecure, *mqttSystem);
  MqttClient::Buffer *mqttSendBuffer = new MqttClient::ArrayBuffer<MQTT_BUFFER_SIZE>();
  MqttClient::Buffer *mqttRecvBuffer = new MqttClient::ArrayBuffer<MQTT_BUFFER_SIZE>();
  MqttClient::MessageHandlers *mqttMessageHandlers = new MqttClient::MessageHandlersImpl<MQTT_SIMULTANEOUS_SUBS>();

  MqttClient::Options mqttOptions;
  mqttOptions.commandTimeoutMs = 10000;

  mqtt = new MqttClient(
    mqttOptions, *mqttLogger, *mqttSystem, *mqttNetwork, *mqttSendBuffer,
    *mqttRecvBuffer, *mqttMessageHandlers
  );
}

int8_t MqttWrapper::loadCertificate () {
  yield();
  int8_t status = 0;
  Serial.println("Loading CA certificate...");
  if (!SPIFFS.begin()) {
    Serial.println("Failed to mount SPIFFS");
    status = -1;
    return status;
  }
  Serial.println("SPIFFS mounted");
  Serial.println(caCertPath);
  File caCert = SPIFFS.open(caCertPath, "r");
  if (!caCert) {
    Serial.println("Failed to open CA certificate");
    status = -2;
    return status;
  }
  Serial.println("CA certificate opened");

  if (!wifiClientSecure.loadCACert(caCert)) {
    Serial.println("CA certificate failed to load into client");
    status = -3;
    return status;
  }
  Serial.println("CA certificate loaded into client");
  status = 1;
  return status;
}

int8_t MqttWrapper::connect (char server[STR_BUFFER_LENGTH], uint16_t port, char username[STR_BUFFER_LENGTH], char password[STR_BUFFER_LENGTH]) {
  int8_t status = 0;
  Serial.println("Attempting TCP/MQTT connection...");

  wifiClientSecure.connect(server, port);
  if (wifiClientSecure.connected()) {
    Serial.println("Secure TCP connection established");
  } else {
    Serial.println("Secure TCP connection failed");
    status = -1;
    return status;
  }

  Serial.println("Attempting MQTT connection");

  MqttClient::ConnectResult connectResult;
  MQTTPacket_connectData options = MQTTPacket_connectData_initializer;
  options.MQTTVersion = 4;
  options.clientID.cstring = deviceId;
  options.cleansession = true;
  options.keepAliveInterval = 15;
  options.username.cstring = username;
  options.password.cstring = password;

  MqttClient::Error::type returnCode = mqtt->connect(options, connectResult);

  if (returnCode == MqttClient::Error::SUCCESS) {
    Serial.println("MQTT connection successful");
    status = 1;
  } else {
    Serial.println("MQTT connection failed");
    status = 0;
  }

  return status;
}

Any glaring errors? Or any ideas where to start looking?

Hi @rapasal
What broker do you use?
Please provide a full debug log. See #define MQTT_LOG_ENABLED 1
I didn't notice anything very wrong from the first look. Need to debug.
Try to add more logs to void deliverMessage(MQTTString& topic, Message& message) {} method.
It looks like the client can't match the topic value with the value used on subscribe.
You use clean session, so the broker should not send messages until you subscribe and set the handler...
Verify the topic value is sent by the broker
Try to reproduce the same using public MQTT broker like Mosquitto and on x86 platform. See example
It could be easier to debug on PC.

I reformatted to bring the code listed above out of the MqttWrapper class and it works fine! For some reason wrapping it up introduces this behavior. I will do some experimenting today with some logic wrapped and some just in setup() and loop() to see if I can spot what breaks it. I'll add some extra logs like you suggest too.

OK, so I have been playing around and found that the problem is when calling mqtt->subscribe(...). In my example above I had a hard coded topic. I got myself in a muddle before posting and was actually calling this with a char array instead of a hard coded string when I got the error.
char subTopic[64];
functionToPopulateSubTopic(subTopic);
mqttWrapper.mqtt->subscribe(subTopic, MqttClient::QOS0, subCallback);

When I hard code as per my initial example it actually works! When I pass the char array in I get the error described. Having the code in a wrapper has no effect. I can confirm that running the ConnectEsp8266WiFiClient example in Arduino IDE also shows the same error when using a char array as the subscription topic.
When I pass a char array to mqtt->publish(...) it works fine. I noticed that the topic argument for both subscribe and publish are converted into a MQTTString differently, and tried to use the implementation from publish in the subscribe method but no luck.
I added the following line to deliverMessage(...) inside the for loop:
MQTT_LOG_PRINTFLN("Incoming topic: %s", (char*)(mMessageHandlers.get()[i].topic));

This threw up something strange... When I hard code the subscription address this prints the correct topic. When I pass the subscription address as a char array it prints the publish topic! I know that the char array I pass definitely contains the subscription topic as I print it right before calling subscribe(...).
I'm not sure what the solution here is. Hard coding isn't really an option as I want to be able to store the topics in arrays so that they can be edited at run time.

@rapasal
I think your problem with a string allocated on stack.
When you use this library or the original Paho library you have to assume that nothing is copied by default.
You have full memory control. That is good for embedded systems.
The topic is stored by reference in default implementation.
Look at

MqttClient::MessageHandlersStaticImpl
MqttClient::MessageHandlersDynamicImpl

I guess this is exactly what you need to avoid hardcoded topics.
If you know the maximum topic length I would suggest using MessageHandlersStaticImpl

Yes! That's just what I needed. Thanks for your help. Great library by the way!


⚠ Bofrost.lu has degraded performance

In d707994, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2280 ms

Resolved: Bofrost.lu performance has improved in 5fe3975 after 36 minutes.


Add a script to check edition consistency with the content-store

This PR adds a script to check for content consistency across the publishing-api and content-stores.
See alphagov/content-store#262 for the equivalent script in the content-store.

fyi i squashed all the little commits into one. such power!

Some example output from me running it locally on my own database (therefore errors might not reflect production).
❯ bundle exec rake check_content_consistency:all
5f9d4d8d-7631-11e4-a3cb-005056011aef 😱
Content is missing from the content store.
9406e5c5-a8fd-4205-9326-0a8a03456380 😱
Edition rendering_app (government-frontend) does not match content store ().
Edition schema_name (statistics_announcement) does not match content store (redirect).
Edition document_type (national_statistics_announcement) does not match content store (redirect).
4cd4d22f-5bfe-4547-a898-02a066642ba7 😱
Edition rendering_app (government-frontend) does not match content store ().
Edition schema_name (statistics_announcement) does not match content store (redirect).
Edition document_type (national_statistics_announcement) does not match content store (redirect).
5e2e1997-7631-11e4-a3cb-005056011aef 😱
Edition rendering_app (whitehall-frontend) does not match content store ().
Edition schema_name (publication) does not match content store (redirect).
Edition document_type (guidance) does not match content store (redirect).
836fd55a-3797-45b5-802d-c90a5f39e995 😱
Content is missing from the content store.
dd7c745d-bf8b-46f5-b202-b5acc5028947 😱
Edition rendering_app () does not match content store (frontend).
Edition publishing_app (whitehall) does not match content store (frontend).
Edition schema_name (contact) does not match content store (special_route).
Edition document_type (contact) does not match content store (special_route).
68a37f8a-3976-4e43-83a2-e0a76f4d7b04 😱
Edition rendering_app (government-frontend) does not match content store ().
Edition schema_name (statistics_announcement) does not match content store (redirect).
Edition document_type (national_statistics_announcement) does not match content store (redirect).
310c1b63-3aef-4f02-92f5-ed0949c1ec28 😱
Content is missing from the content store.


FMUv1 randomly erases params

Every now and then, it seems that all params are wiped from the FMUv1 EEPROM:
mtd: failed to initialize EEPROM driver
param: selected parameter default file /fs/microsd/params
[param] Loaded: /fs/microsd/params
[rgbled] on I2C bus 3 at 0x55 (bus: 100 KHz, max: 100 KHz)
 1:   SYS_USE_IO: match
 0:   SYS_AUTOSTART: match
[i] No autostart
[PX4IO_i2c] on I2C bus 2 at 0x1a (bus: 100 KHz, max: 400 KHz)
px4io: CRCs match
dataman: Unknown restart, data manager file '/fs/microsd/dataman' size is 101504 bytes
[MS5611_I2C] on I2C bus 2 at 0x76 (bus: 100 KHz, max: 400 KHz)
ms5611: no device on bus 2
<adc> init done
[MPU6000] on SPI bus 1 at 3 (1000 KHz)
[L3GD20] on SPI bus 1 at 1 (11000 KHz)
hmc5883: no device on bus 2
[HMC5883_I2C] on I2C bus 2 at 0x1e (bus: 100 KHz, max: 400 KHz)
meas_airspeed: no MS4525 airspeed sensor connected
ets_airspeed: no ETS airspeed sensor connected
ets_airspeed: no ETS airspeed sensor connected
nsh: px4flow: command not found
telem> PREFLIGHT FAIL: MAG #0 UNCALIBRATED
telem> PREFLIGHT FAIL: ACCEL #0 UNCALIBRATED
telem> PREFLIGHT FAIL: GYRO #0 UNCALIBRATED
telem> PREFLIGHT FAIL: GYRO #1 UNCALIBRATED
telem> PREFLIGHT FAIL: AIRSPEED SENSOR MISSING

Any ideas why this would happen?

I had this happen once just a few days ago too on a V1 board. Thought it
might just have been a one off but it looks like it isn't the case.
On Sun, 28 Jun 2015 16:53 Ban Siesta<EMAIL_ADDRESS>wrote:

Every now and then, it seems that all params are wiped from the FMUv1
EEPROM:
mtd: failed to initialize EEPROM driver
param: selected parameter default file /fs/microsd/params
[param] Loaded: /fs/microsd/params
[rgbled] on I2C bus 3 at 0x55 (bus: 100 KHz, max: 100 KHz)
1:   SYS_USE_IO: match
0:   SYS_AUTOSTART: match
[i] No autostart
[PX4IO_i2c] on I2C bus 2 at 0x1a (bus: 100 KHz, max: 400 KHz)
px4io: CRCs match
dataman: Unknown restart, data manager file '/fs/microsd/dataman' size is 101504 bytes
[MS5611_I2C] on I2C bus 2 at 0x76 (bus: 100 KHz, max: 400 KHz)
ms5611: no device on bus 2
 init done
[MPU6000] on SPI bus 1 at 3 (1000 KHz)
[L3GD20] on SPI bus 1 at 1 (11000 KHz)
hmc5883: no device on bus 2
[HMC5883_I2C] on I2C bus 2 at 0x1e (bus: 100 KHz, max: 400 KHz)
meas_airspeed: no MS4525 airspeed sensor connected
ets_airspeed: no ETS airspeed sensor connected
ets_airspeed: no ETS airspeed sensor connected
nsh: px4flow: command not found
telem> PREFLIGHT FAIL: MAG #0 UNCALIBRATED
telem> PREFLIGHT FAIL: ACCEL #0 UNCALIBRATED
telem> PREFLIGHT FAIL: GYRO #0 UNCALIBRATED
telem> PREFLIGHT FAIL: GYRO #1 UNCALIBRATED
telem> PREFLIGHT FAIL: AIRSPEED SENSOR MISSING
Any ideas why this would happen?
—
Reply to this email directly or view it on GitHub
https://github.com/PX4/Firmware/issues/2489.

I have seen this on FMU v2 as well 2-3 times. Just a reboot, no config changes, etc. yet the params are all reset. Initially dismissed as a one-off, but this keeps happening.
Couldn't find a way to reproduce it reliably.

I also confirm this issue on FMUv2. It sometimes happens when I load new firmware to the board. It's difficult to reproduce as it doesn't happen within a fixed pattern, so I'm not able to figure when it happens or not. But all sensor callibrations, for example, disappear.

All reports I've seen is when people reboot while params are written. There is nothing we can do about this other than telling people to use their system correctly (you also don't shut down your computer while Powerpoint is still saving your slide deck). Closing this.


Frontend basic test

Adding a basic stream test to the frontend e2e tests
Setting up a docker compose to run the frontend tests
Adding a gh action to run the frontend e2e tests

Seems like its having issues with the recent event emitter changes but I'm not getting them locally.
Will look into this tomorrow.


append: true for SourceMapDevToolPlugin make an error

webpack2:
{
plugins: [
		new webpack.SourceMapDevToolPlugin({
			columns: true,
			append: true,
			exclude: /node_modules/
		})
	]
}

if I set append to false,the error will not appear.

Is it relay to the mode name of devtool,which mode should I use?

It looks like you just deleted our lovely crafted issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template. I'm closing this. Please open a new issue with filled issue template. Also make sure your issue is not a question. Questions should be posted on Stack Overflow.


Escape dollar sign

As per #2, support $$.

LGTM
Thoughts @bradrydzewski ?

LGTM thanks!

note that I will need to update the vendored dependency in drone/drone for this to take effect. I plan on doing so tomorrow

Great!  Glad I could help 😄


Fix the duplicated metrics counting

What changes are proposed in this pull request?
Remove the duplicated metrics counting
Why are the changes needed?
We count CLIENT_CACHE_BYTES_READ_CACHE twice
Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including

change in user-facing APIs
addition or removal of property keys
webui

alluxio-bot, merge this please.

alluxio-bot, merge this please.


See that all links to resources appear on all versions of the site

script started, but doesn't work yet


Azure ML Quick Start Issue: TypeError: 'float' object cannot be interpreted as an integer

Hello,
I keep getting the following error whenever I submit the job in Quick Start documentation. I've done everything to change the input type of the data to float64 using credit_df.astype(np.float64).
Any suggestions?
/bin/bash: /azureml-envs/sklearn-1.0/lib/libtinfo.so.6: no version information available (required by /bin/bash)
2024/02/24 01:09:24 WARNING mlflow.sklearn: Failed to log training dataset information to MLflow Tracking. Reason: 'Series' object has no attribute 'flatten'
data=/mnt/azureml/cr/j/a59c05717619456082a56ba2a3548fe5/cap/data-capability/wd/INPUT_data/default_of_credit_card_clients.csv test_train_ratio=0.2 n_estimators=0.1 learning_rate=0.25 registered_model_name=credit_default_model
input data: /mnt/azureml/cr/j/a59c05717619456082a56ba2a3548fe5/cap/data-capability/wd/INPUT_data/default_of_credit_card_clients.csv
Training with data of shape (24000, 23)
Traceback (most recent call last):
File "main.py", line 103, in
main()
File "main.py", line 72, in main
clf.fit(X_train, y_train)
File "/azureml-envs/sklearn-1.0/lib/python3.8/site-packages/mlflow/utils/autologging_utils/safety.py", line 554, in safe_patch_function
patch_function(call_original, *args, **kwargs)
File "/azureml-envs/sklearn-1.0/lib/python3.8/site-packages/mlflow/utils/autologging_utils/safety.py", line 254, in patch_with_managed_run
result = patch_function(original, *args, **kwargs)
File "/azureml-envs/sklearn-1.0/lib/python3.8/site-packages/mlflow/sklearn/init.py", line 1612, in patched_fit
result = fit_impl(original, self, *args, **kwargs)
File "/azureml-envs/sklearn-1.0/lib/python3.8/site-packages/mlflow/sklearn/init.py", line 1385, in fit_mlflow
fit_output = original(self, *args, **kwargs)
File "/azureml-envs/sklearn-1.0/lib/python3.8/site-packages/mlflow/utils/autologging_utils/safety.py", line 535, in call_original
return call_original_fn_with_event_logging(_original_fn, og_args, og_kwargs)
File "/azureml-envs/sklearn-1.0/lib/python3.8/site-packages/mlflow/utils/autologging_utils/safety.py", line 470, in call_original_fn_with_event_logging
original_fn_result = original_fn(og_args, **og_kwargs)
File "/azureml-envs/sklearn-1.0/lib/python3.8/site-packages/mlflow/utils/autologging_utils/safety.py", line 532, in _original_fn
original_result = original(_og_args, **_og_kwargs)
File "/azureml-envs/sklearn-1.0/lib/python3.8/site-packages/sklearn/ensemble/_gb.py", line 529, in fit
self._init_state()
File "/azureml-envs/sklearn-1.0/lib/python3.8/site-packages/sklearn/ensemble/gb.py", line 374, in init_state
self.estimators = np.empty((self.n_estimators, self.loss.K), dtype=object)
TypeError: 'float' object cannot be interpreted as an integer

@JohnKHancock
Thanks for sharing the feedback. Since this channel is for driving improvements towards Docs, could you please provide the URL of the specific documentation that your feedback is applicable to? That way, we can make sure your feedback is addressed by the right team.

I figured it out. It was my error. I incorrectly defined one of the ML
algorithm's hyperparameters.
Thanks for reaching out.
On Fri, Feb 23, 2024 at 10:59 PM AjayBathini-MSFT @.***>
wrote:

@JohnKHancock https://github.com/JohnKHancock
Thanks for sharing the feedback. Since this channel is for driving
improvements towards Docs, could you please provide the URL of the specific
documentation that your feedback is applicable to? That way, we can make
sure your feedback is addressed by the right team.
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/120185#issuecomment-1962242254,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNZ2WCAFWRLR2WXQSEVPNLYVFQTFAVCNFSM6AAAAABDXSSUVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRSGI2DEMRVGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Compile-AppInNavContainer symbol files for Microsoft_Application are missing customization

I am using container with enabled symbol loading and imported Test Libraries.
The app.json does not include Test.
Compilation via Compile-AppInNavContainer is failing on the missing test libraries references.
I have checked it a bit further:
When manually downloading symbols via VS Code the Microsoft_Application includes the test libraries.
When using Compile-AppInNavContainer the downloaded Microsoft_Application is missing the test libraries.
Version of the Microsoft_Application also differs in those scenarios.
I assume this is caused by versionText parameter in Invoke-RestMethod which in VS Code is taken from app.json - as it is (<IP_ADDRESS>).
Whereas in Compile-AppInNavContainer the versionText for Application seems to be overriden by Version provided by Get-NavAppInfo -SymbolsOnly section (13.0.26556.0 in my case of CU2)

I am having a hard time reproing this - I might be doing something wrong???

This could be divided into two issues:

Compile-AppInNavContainer doesn't compile with the same symbols as VS Code does (my pull request)
The imported CSIDE objects are not included in the symbol files when choosing the same app version as the same one installed.

For number 2 i have filed a support request to Microsoft.

I just talked to the guys from the modern dev team.
The interesting thing is to find out how you got the two different versions of the symbols in there in the first place.
If you run Get-NavContainerAppInfo with -symbolsOnly what do you get?
I get:
ServerInstance : MicrosoftDynamicsNavServer$NAV
PSComputerName : a863168e31d2a77ade77af5a4ca3cd8bf9298de61eed88202a736cfef4a8da64
RunspaceId     : 37c8e6ae-9522-4f1b-967a-0171dd4ea0bb
AppId          : 0b15f250-c24a-416c-85c0-ec2f978d1fbb
Name           : Application
Publisher      : Microsoft
Version        : 13.3.27233.0
ExtensionType  : ModernDev
Scope          : Global

ServerInstance : MicrosoftDynamicsNavServer$NAV
PSComputerName : a863168e31d2a77ade77af5a4ca3cd8bf9298de61eed88202a736cfef4a8da64
RunspaceId     : 37c8e6ae-9522-4f1b-967a-0171dd4ea0bb
AppId          : c4b9245c-67fa-4256-94b8-6efd189d5e5e
Name           : Test
Publisher      : Microsoft
Version        : 13.3.27233.0
ExtensionType  : ModernDev
Scope          : Global

ServerInstance : MicrosoftDynamicsNavServer$NAV
PSComputerName : a863168e31d2a77ade77af5a4ca3cd8bf9298de61eed88202a736cfef4a8da64
RunspaceId     : 37c8e6ae-9522-4f1b-967a-0171dd4ea0bb
AppId          : 8874ed3a-0643-4247-9ced-7a7002f7135d
Name           : System
Publisher      : Microsoft
Version        : 13.0.12929.0
ExtensionType  : ModernDev
Scope          : Global

Which is one symbols app of each.

Same as you:
ServerInstance : MicrosoftDynamicsNavServer$NAV
PSComputerName : eaf3ac8ec6b731a72236ca9a5ddd0aa79423d302972129200d0d7268b83d9ff6
RunspaceId     : 736de200-8c2a-4d14-a961-e12e78aa1613
AppId          : c2416346-b0ef-43a0-a97f-0cbc72bbcf28
Name           : Application
Publisher      : Microsoft
Version        : 13.3.27233.0
ExtensionType  : ModernDev
Scope          : Global

ServerInstance : MicrosoftDynamicsNavServer$NAV
PSComputerName : eaf3ac8ec6b731a72236ca9a5ddd0aa79423d302972129200d0d7268b83d9ff6
RunspaceId     : 736de200-8c2a-4d14-a961-e12e78aa1613
AppId          : c4b9245c-67fa-4256-94b8-6efd189d5e5e
Name           : Test
Publisher      : Microsoft
Version        : 13.3.27233.0
ExtensionType  : ModernDev
Scope          : Global

ServerInstance : MicrosoftDynamicsNavServer$NAV
PSComputerName : eaf3ac8ec6b731a72236ca9a5ddd0aa79423d302972129200d0d7268b83d9ff6
RunspaceId     : 736de200-8c2a-4d14-a961-e12e78aa1613
AppId          : 8874ed3a-0643-4247-9ced-7a7002f7135d
Name           : System
Publisher      : Microsoft
Version        : 13.0.12929.0
ExtensionType  : ModernDev
Scope          : Global

But this doesn't matter, even though it only lists ONE application it obviously returns different symbols files depending on which version you add as a parameter.
If you do a manual build (CTRL +F5) you can see in the output window it adds <IP_ADDRESS> in the call
[2019-02-19 10:28:39.13] Using reference symbols cache path: c:\GIT\norrvidinge-base-app\App\.alpackages
[2019-02-19 10:28:39.21] Sending request to http://<ContainerName>:7049/NAV/dev/packages?publisher=Microsoft&appName=Application&versionText=<IP_ADDRESS>
[2019-02-19 10:28:39.22] Sending request to http://<ContainerName>:7049/NAV/dev/packages?publisher=Microsoft&appName=System&versionText=<IP_ADDRESS>
[2019-02-19 10:28:50.20] All reference symbols have been downloaded.

This is the problem with Compile-AppInNavContainer, it uses the version nr it gets from
Get-NAVAppInfo -ServerInstance NAV -SymbolsOnly
http://<ContainerName>:7049/NAV/dev/packages?publisher=Microsoft&appName=Application&versionText=13.3.27233.0
$url = "$devServerUrl/dev/packages?publisher=${publisher}&appName=${name}&versionText=${version}&tenant=$tenant"

So what we have is that it returns different symbol file depending on which paramater you use in the download symbols call. Is this right, I don't know thats for you (MS) to decide ;)
Until it is decided I did the workaround for Compile-AppInNavContainer that used the version in App.json instead of the ones the server says it has.

I can just confirm @NAVFreak observations, with the following additions:
I'd add that even though my SymbolsOnly references are the same as yours (Application has version = 13.3.27233.0),
the file retrieved by VS Code is Microsoft_Application_13.0.27183.0.app
In order to reproduce the above results I have just instatiated the following container:
New-NavContainer -containerName bclocal -imageName mcr.microsoft.com/businesscentral/onprem:cz -enableSymbolLoading -includeTestToolkit -includeTestLibrariesOnly -accept_eula -auth NavUserPassword
I also tested it without enabledSymbolLoading and the VS Code downloaded original Microsoft_Application_13.3.27233.0.app as expected.

I have been investigating this and now I know what goes wrong.
The Pull Request which fixes this, fixes the symptom, but it is the wrong fix.
The real problem is, that the application version is wrong in local Business Central On Prem builds.
the 13.0.27183.0 is actually the platform version number used as application version number.
W1 uses the correct application version number 13.3.27233.0.
The bre-built symbols.app which has been published during build also uses the correct version number 13.3.27233.0 (Get-NavAppInfo).
But when enabling symbolLoading and generating new symbols (or changes to symbols), it uses the applicationVersion from the database (13.0.27183.0). This means that if you download apps using <IP_ADDRESS> you get the lower number - which fortunately is the correct one.
The right fix is to ensure that the applicationVersion number in the database is correct.
That should be done in the build process.
If you want to do it after creating the container you need to do like this:
    Invoke-ScriptInNavContainer -containerName $containerName {
        $databaseName = Get-NAVServerConfiguration -ServerInstance NAV -KeyName DatabaseName
        $applicationVersion = (Get-NAVAppInfo -ServerInstance NAV -Name Application -SymbolsOnly).Version.ToString()
        Invoke-SqlCmd -Database $databaseName -Query "update [dbo].[$("$")ndo$("$")dbproperty] SET [applicationversion] = '$applicationVersion'"
        Invoke-SqlCmd -Database $databaseName -Query "update [dbo].[$("$")ndo$("$")tenantproperty] SET [applicationversion] = '$applicationVersion'"
        Sync-NavTenant -ServerInstance NAV -tenant default -mode ForceSync -Force
    }
    Generate-SymbolsInNavContainer -containerName $containerName

but this takes a lot of time during container creation.
Another fix, which might be fine (for now) is to simply unpublish the wrongly numbered app symbols after creating the container:
   UnPublish-NavContainerApp -containerName $containerName -appName Application
That is fast and will cause Compile-AppInNavContainer to use the app.json version number.
I suggest you do this for now - and I will file a bug on the build team

Thanks @freddydk for the suggested workaround. It works well for me ...

The workaround works, but we need to do something with Compile-AppInNavContainer.
I fixed this "bug" that it doesn't try the application version from app.json on my build agent but since it automatically fetches new newest version of navcontainerhelper I'll have to update it everytime at every release or turn off the automatic update. None of the options are really good.
What do we need in order to update Compile-AppInNavContainer so it uses the application version in app.json instead of the application version that is currently installed on the server?
I still think that it doesn't use the application version in app.json is a bug. Because that is what compiler in VS Code does.

Have been busy - I will fix this in the right way in the next version of NavContainerhelper

Shipped in <IP_ADDRESS>


Could you tell me where is the file "route_distances"? I can't find it.

the file "route_distances" is used as follow, path is  "analysis/route_clusters.py"
import route_distances.lstm.defaults as defaults
from route_distances.route_distances import route_distances_calculator
from route_distances.clustering import ClusteringHelper
from route_distances.utils.type_utils import RouteDistancesCalculator

The route_distances is a Python package that should have been installed with the setup instructions.


Consider using RFC3986 encode form-urlencoded

3.0.2 spec section Support for x-www-form-urlencoded Request Bodies:

To submit content using form url encoding via RFC1866, ...

And, RFC1866 section 8.2.1 The form-urlencoded Media Type:

The form field names and values are escaped: space characters are replaced by `+', and then reserved characters are escaped as per [URL]

Indicates that using encoding specified in RFC1738 and a special treatment on space character
While according to HTML 5.2 section <IP_ADDRESS> URL-encoded form data:

See the WHATWG URL specification for details on application/x-www-form-urlencoded. [URL] ...

Which says:

Note: URLs can be used in numerous different manners, in many differing contexts. For the purpose of producing strict URLs one may wish to consider [RFC3986] [RFC3987] ...

So, please consider using RFC3986 instead of RFC1738, RFC1738 is too old(December 1994).

text

I believe the only difference is that /, ?, and ';' are no longer reserved within the query string in RFC 3986, correct? (And I agree, it should reference RFC 3986).

Yes

Does anyone have a reference to the BNF/grammar for the "key=value" pairs? I wrote this:
query-params    = query-param *( "&" query-param )
query-param     = key [ "=" value ]
key             = *qpchar
value           = *( qpchar / "=" )

but is there an official IETF document (or addendum) that states this?

@vinniefalco there is no IETF document.  There was a draft, but it was abandoned.  WHATWG addresses it in their URL "living standard", although I assume like all of their specs it's defined in terms of browser implementation state machines as opposed to ABNF or anything like that.

Thanks! (I find the WHATWG "spec" exceptionally frustrating)

It's not clear to me whether we can change an RFC reference in a patch release, so for now I'm putting this in 3.2.

FWIW, RFC3986 is what JSON Schema's "format": "uri-reference" uses.

@karenetheridge yeah I think the chances that anyone else even realizes the difference, much less implements it, is pretty slim.  Arguably, since RFC3986 is formally listed as updating RFC 1738 (the URL encoding that RFC1866 references), it should be automatically understood that 3986 supersedes the outdated requirements.
I'm not sure whether we should do anything here- it's really getting into the weeds, and I think we can rely on the IETF's Update/Obsolete linkage.  Maybe.  I hope?

I noticed (with the discussion around urlencoding { and }) that our examples do not urlencode ~, which would be required by RFC 1738 but is not required by RFC 3986.  Of course, we weren't urlencoding that example correctly anyway, but... I don't think anyone at any time meant we should urlencode ~ just because RFC 1738 is very indirectly referenced.  We reference 3986 normatively elsewhere.

@OAI/tsc review request:  Is it worth doing anything here?  To summarize:

We cite RFC 1886 (HTML 2.0) for application/x-www-form-urlencoded, presumably as it was the last IETF document to even sort-of address it
RFC 1886 cites RFC 1738 (Uniform Resource Locators (URL)), the then-current URI/URL RFC, which has more restrictive rules for URL encoding
RFC 1738 has long since been superseded by RFC 3986 (among others), which has somewhat more relaxed encoding rules (which we take advantage of in some of our examples, such as by not encoding ~ which RFC 3986 specifically calls out as being allowed but previously forbidden)

Do we need to specifically note that our reference to RFC 1886 should incorporate RFC 3986 rules rather than RFC 1738 rules, or is that to be expected automatically because RFC 3986 formally obsoletes RFC 1738 already?
In terms of practical impact, I need to know for OASComply whether to validate using the RFC 1738 rules or the RFC 3986 rules.

I would be in favor of updating the RFC reference in the 3.2. My meager understanding of this topic is that the RFC switch is not simply a "clarification" so I don't think it could be done in a patch version on earlier versions.

@ralfhandl Ugh.  The previous line in the WHATWG spec is probably the better one to quote here:

The application/x-www-form-urlencoded percent-encode set is the component percent-encode set and U+0021 (!), U+0027 (') to U+0029 RIGHT PARENTHESIS, inclusive, and U+007E (~).

However, that is only relevant when running the WHATWG application/x-www-form-urlencoded serializing algorithm.  The WHATWG application/x-www-form-urlencoded parsing algorithm will, AFAICT, happily accept a literal ~, because their percent-decode algorithm copies bytes verbatim unless it sees a %.
My feeling is that if people want to use WHATWG's serialization rules, that's on them.  It's not our responsibility to keep up with their "living standard" or sort out the grammatical (in the ABNF sense) implications of their pseudocode.  They have, historically, been aggressively hostile to accommodating anyone else's use cases or concerns, for example refusing to support relative URI-references because there aren't "enough" _browser-related use cases.
As we are an API specification, I feel comfortable ignoring people who have made it clear that they have no interest in supporting APIs as used by non-browsers.  Not to mention people who think it's OK to refer to the work of past standards writers as "an aberrant monstrosity".  It's one thing to get snarky in GitHub comments- I'm in no position to throw stones.  That line alone tells me all I need to know about the URL spec's author.

@mikekistler if it's really a change, I agree with you.  My question is, "is this even a change?"  I can't find a clear explanation from the IETF as to whether an RFC that formally obsoletes another RFC automatically takes effect, or whether it requires an updated citation.
We don't even cite RFC 1738 directly, so there's no citation to replace.  We do normatively cite RFC 3986, but the way we get to 1738 is:

OAS 3.0 (7/17) and OAS 3.1 (2/21) cite RFC 1866 (HTML 2.0; 11/95), which cites RFC 1738 (URLs; 12/94)
RFC 1738 (12/94) is obsoleted by RFC 2396 (8/98), which moves ~ to unreserved, and is obsoleted by RFC 3986 (1/05)

All the OAS citations are many years after 3986, so it was already clear that those rules were doubly-obsolete when we cited 1866.
For that matter, it's not entirely clear to me that RFC 1866 really requires percent-encoding those extra characters.  §8.2.1  The form-urlencoded Media Type states:

The form field names and values are escaped: space
characters are replaced by '+', and then reserved characters
are escaped as per [URL]; that is, non-alphanumeric
characters are replaced by '%HH', a percent sign and two
hexadecimal digits representing the ASCII code of the
character.

Oddly enough, this mentions percent-encoding reserved characters, rather than unsafe characters.  There's no errata for this RFC, so this is the text in question.
§2.2 URL Character Encoding Issues includes this text in a paragraph with the sub-heading "Unsafe":

Other characters are unsafe because gateways and other transport agents are known to sometimes modify such characters. These characters are "{", "}", "|", "", "^", "~", "[", "]", and "`".

In that same section, under the sub-heading "Reserved":

Many URL schemes reserve certain characters for a special meaning:
their appearance in the scheme-specific part of the URL has a
designated semantics. If the character corresponding to an octet is
reserved in a scheme, the octet must be encoded.  The characters ";",
"/", "?", ":", "@", "=" and "&" are the characters which may be
reserved for special meaning within a scheme. No other characters may
be reserved within a scheme.

The BNF in §5 also does not place the characters in question in the reserved production:
safe           = "$" | "-" | "_" | "." | "+"
extra          = "!" | "*" | "'" | "(" | ")" | ","
national       = "{" | "}" | "|" | "\" | "^" | "~" | "[" | "]" | "`"
punctuation    = "<" | ">" | "#" | "%" | <">

reserved       = ";" | "/" | "?" | ":" | "@" | "&" | "="
hex            = digit | "A" | "B" | "C" | "D" | "E" | "F" |
                 "a" | "b" | "c" | "d" | "e" | "f"
escape         = "%" hex hex

unreserved     = alpha | digit | safe | extra
uchar          = unreserved | escape
xchar          = unreserved | reserved | escape

The term "national" is not used anywhere else in the RFC, nor do any other BNF rules depend on it.  Which means the national characters are not part of uchar or xchar (the relevant productions for what characters are legal).
But RFC 1866 only mentions "reserved" characters.  Not "unsafe" characters, or "characters outside of the legal set."

So... my feeling, after spending way too much time reading specs for this, is that anyone who is going to be legalistic enough to complain about RFC 1738 being cited by RFC 1866 can be countered by the fact that the most direct reading of RFC 1866 doesn't require encoding the national set of characters in the first place.

I'm now working on a PR describing the URL-encoding processes for query strings and request bodies in detail, and one way or another this will get addressed.  So I'm taking the review label off.


Fix potential NPE if code is executed concurrently

Backport of eb533b7 on release.

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test RFM

OK, I've already cancelled the old build and triggered a new ReadyForMerge build for you.

@bot-gradle test RFM

OK, I've already cancelled the old build and triggered a new ReadyForMerge build for you.

while (!happy) {
@bot-gradle test RFM
}

OK, I've already triggered ReadyForMerge build for you.


faulty regex in magic.mgc

There's a bug in one of the REGEXes:
regex error 11 for `\t\\*|([0-9]+[MIDNSHPX=])+)\t', (unbalanced () at offset 24    )

This issue has been noted before:

https://github.com/Alexpux/MSYS2-packages/commit/6326da8a38fff8297829e15571190de91391d0cc
https://bugs.gw.com/view.php?id=558

How can we fix the magic file? I'd do it if I knew how to.

Please try the master branch, I have merged in libmagic 5.32 now.
This is also a duplicate of https://github.com/mscdex/mmmagic/issues/114.


fix: Use copy_value for handling copied values in copy constructors

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

14 of 21 (66.67%)  changed or added relevant lines in 8 files are covered.
7 unchanged lines in 6 files lost coverage.
Overall coverage decreased (-0.4%) to 86.222%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/parsing/expr_types/typed_exprs.jl
1
2
50.0%

src/parsing/struct.jl
3
4
75.0%

src/parsing/expr_types/base.jl
0
2
0.0%

src/parsing/expr_types/composite.jl
1
4
25.0%

Files with Coverage Reduction
New Missed Lines
%

src/parse_kwargs/kv_expr_parser.jl
1
84.95%

src/parse_kwargs/parse_kwargs_macro.jl
1
91.94%

src/parsing/expr_types/block_exprs.jl
1
80.0%

src/parsing/funcs.jl
1
86.14%

src/transformations/map.jl
1
72.73%

src/parsing/struct.jl
2
86.96%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
1189

Relevant Lines:
1379

💛  - Coveralls


Broken if-then-else expression in JavaScript compilation

The following code, which perfectly works when compiling to JVM breaks in the JavaScript version of the program:
"Run the module `ifelse`."
shared void run() {
    Integer x = 1;
    Integer y = 2;

    String text = (if (x > 0) then x.string + "a " else "") + y.string + "b";

    assert (text == "1a 2b");
}

When extracting the expression (if (x > 0) then x.string + "a " else "") to a new local variable, everything is fine in JavaScript, too.

The result in JS seems to be "1a ".

Nasty!


size of videos not actual, only 70kb

I'm was sucessfullly to download videos series "Learn Vue 2: Step By Step".
> Download started: 33 - Scoped Slots . . . . Saving on series/learn-vue-2-step-by-step folder.
> Elapsed time: 465ms, Memory: 4.00Mb
> Current: 33 of 33 total. Left: 0
> Finished! Downloaded 0 new lessons and 33 new episodes. Failed: 0

but, size of video only 70,7 kb..

what's happen??

Do you have a valid account with an active subscription?

I have registered in laracast, my email n pass in .env is also true..

owh, must be paid subscribers .. :disappointed_relieved:

Yep 😄

thanks


corner plots with very large values displayed above the histogram look rubbish

This for example (ignore the awful fit) and look at the rightmost histogram, the very large value of that parameter should be formatted in scientific notation to make it look nice

This is not so much an XGA problem as it is a corner (the module) problem. They just stick with whatever string formatting is default, rather than dynamically altering it. They do allow a user to pass in a custom formatting expression, but it seems that this will be applied to all the quantiles rather than just the long ones.
What I will do (as a compromise) is to put in an if statement that changes the formatting string to one that displays in scientific notation (something like "{:.2E}" should do) if any parameter is over 10^5 or something

Okay so that now causes corner to throw an error 'ValueError: cannot switch from manual field specification to automatic field numbering'. So I guess I'm not going to be doing anything to fix this...
Closing this issue

I actually spoke too soon, once I removed the {} in the format string then it worked, however it really doesn't look that great. I will add this if statement in though, as its better than a really long number above the corner plots:


[Flux1] - Type parameter (T) of Optype (Einsum) bound to different types

Describe the bug
Unable to convert Flux1-schnell transformer model to onnx format
To Reproduce
Run basic convert/optimize pass
Olive logs
Error: Type parameter (T) of Optype (Einsum) bound to different types (tensor(float16) and tensor(double) in node (/pos_embed/Einsum_2).'
Other information

OS: Windows 10
Olive version:  main
ONNXRuntime: onnxruntime-gpu: 1.18.1

Additional context
3 Einsum nodes in the converted model have a tensor with data of float64 but an input of flaot16, seems like a cast should be inserted?
All other Flux sub-modules have converted ok, just the unet/transformer model

Hi, is the model a float16 model? If so, exporting float16 model is not well supported in torch export. Normally, we export in float32 and then run another pass to convert to fp16.
can you try these two passes instead?
      "c": {
          "type": "OnnxConversion",
          "target_opset": 17,
          "torch_dtype": "float32"
      },
      "o": {
          "type": "OrtTransformersOptimization",
          "model_type": "unet",
          "opt_level": 0,
          "keep_io_types": false,
          "float16": true
      }

Original model type is bfloat16
I have tried all combinations (bfloat16 and float16), all end with the same error on the Einsum nodes
Have tried both cuda and cpu(DirectML)
The model is 23GB with bfloat, so quite a challenge to fit on a device using float32
I have had pretty good success with other transformer models like SD3, they seem to convert without issue, however I realize flux is pretty new
Ill see if I can pickup some more RAM today and try from float32

Managed to upgrade to 64GB of RAM and try float32, came out to a hefty 46GB...
unfortunately I have encountered the same error on the Einsum nodes, this time failing to cast float32 to float64
Type Error: Type parameter (T) of Optype (Einsum) bound to different types (tensor(float) and tensor(double) in node (/pos_embed/Einsum_2).'
Conversion completed without error so did optimization, however error occurs on loading model, on CPU or GPU (W7900 48GB)
How would I inject a cast for these inputs? is there a known way to do that?

Managed to find a workaround by just updating the float64 tensors to bfloat after conversion, model seems to load now :)

updating the float64 tensors to bfloat

before convert to onnx? cast float64 to float16?

After conversion you will need to update 3 nodes, Einsum, Einsum_1, and Einsum_2 the weights for these nodes are float64 so you will need to insert casts before and after.

Do not set the weights to Float16, it will ruin the quality of the Flux output
Here are some of the ONNX conversions:
https://huggingface.co/saddam213/Flux_dev-f16-onnx
https://huggingface.co/TensorStack/Flux_schnell-f32-onnx
https://huggingface.co/TensorStack/Flux_schnell-f16-onnx


Falkon: add version 3.1.0

There will most likely be lots of https -> http redirection as majority of mirrors are http

do you want to change the downloads to http ?

I do not know if it will help

I guess it's best to leave the redirects do their work to avoid managing a link to a mirror

Anything I can do to finalize that pull request ?

What about fixing manifest?

seems fixed now, thanks for the help

now we just wait someone to merge ?

The 32bit exe file's hash is "3b82d1a4661192b3d98c155bffc6a29605748be9ee0b974a8632f383abc88ebd".

The 32bit exe file's hash is "3b82d1a4661192b3d98c155bffc6a29605748be9ee0b974a8632f383abc88ebd".

nope, if you look at https://download.kde.org/stable/falkon/3.1/Falkon.Installer.3.1.0.exe.sha256 you get 806dc30fd68edee4587e2f480054000f82d5d56df5047ee299547cb2247a3a88  Falkon.Installer.3.1.0.exe

@Ash258 Do you know if something is preventing the merge ?


Books and pages should have form fields for IIIF properties.

Follow on from #50.

Not done from #50:
Scanned Resources need:
Viewing Direction (sc:viewingDirection). The value/object must be one of:

left-to-right (sc:leftToRightDirection) (default)
right-to-left (sc:rightToLeftDirection)
top-to-bottom (sc:toToBottomDirection)
bottom-to-top (sc:bottomToTopDirection)

Viewing Hint (sc:viewingHint). The value/object must be one of:

individuals (sc:individualsHint) (default)
paged (sc:pagedHint)
continuous (sc:continuousHint)


Predict over text not present in the DB

It would be great to provide a functionality to predict a relation over some text without asking you to insert that text in to the database.
This could be really useful for applications where IEPY is mounted as a service and the corpora is not known in full a-priori.

+1

Has there been any progress on this @rafacarrascosa @jmansilla ?

@iScienceLuvr sorry, nothing on this yet

@rafacarrascosa what other research has been done on this?

@iScienceLuvr nothing at all... the issue with this issue is that there are many queries to the DB here and there that need to be 'tapped' somehow to work with something that is now in the DB. if you want the ticket it's all yours!

@rafacarrascosa so how can I do this project? Idk where to start

@iScienceLuvr  sorry for the absurd delay.
If I were to take this issue I would start here https://github.com/machinalis/iepy/blob/develop/iepy/extraction/active_learning_core.py trying to make the predict method to work without candidates in the database...

Actually, if I recall correctly, that method is already working under the assumption that evidences are not in the DB. The challenge would be to build in your scripts Evidences resembling those that are created from the DB.

@rafacarrascosa  @jmansilla  I do not undersrand how this code works... So predict() is the function that learns to classify? And what are the questions the are asked to the user?


Website navigation issue

When I provide website without https:// or http://  when clicking the website in resume it is navigating to rxresu.me address.

Closing this in favor of Reactive Resume v3 release.
If you continue to face this issue, please raise a new one and I'll have a look at it as soon as I can.
In the meantime, if you are able to, please consider donating to keep supporting the project: https://www.buymeacoffee.com/AmruthPillai :)
Thank you!


Menus, Settings, State: Create build step that transforms JSON schemas to TypeScript types

As an extension developer, I want to know and to be able to use the types for various kinds of data that the PAPI exposes so I can work effectively in the environment.

We need a build step that transforms the JSON schemas into TypeScript types for the extension contribution points we're defining.

Transforms state/settings schemas and menu schemas for use in core and extensions (should get picked up in papi.d.ts)
Should run before any TypeScript builds in core

Settings & State Design Doc

I found some things while trying to revise the Settings JSON schema that I will put here:
Seems json-schema-to-typescript - npm is the most widely used package to use for transforming json schema to TypeScript. A couple others are ts-json-schema-generator - npm and typescript-json-schema - npm.
Using json-schema-to-typescript's online converter, I discovered a couple things:
Regex string types are not supported, but you can use `tsType` to work around that.

Regex string types are baked out to string. As such, you can add tsType to the object schema, and it will simply use that instead of string.
{
  "$schema": "https://json-schema.org/draft-07/schema",
  "title": "User State Contribution Schema",
  "description": "The data an extension provides to inform Platform.Bible of the user state it provides",
  "type": "object",
  "properties": {
    "stateBase": {
      "$ref": "#/$defs/stateBase"
    },
  },
  "$defs": {
    "stateBase": {
      "description": "Base information needed to describe a state entry",
      "type": "object",
      "properties": {
        "default": {
          "description": "default value for the state/setting",
          "type": "any"
        },
        "derivesFrom": {
          "description": "a state/setting ID whose value to set to this state/setting's starting value the first time this state/setting is loaded",
          "$ref": "#/$defs/id"
        }
      },
      "required": [
        "default"
      ]
    },
    "id": {
      "description": "",
      "type": "string",
      "pattern": "^[\\w-]+\\.[\\w-]+$",
      "tsType": "Id"
    }
  }
}

You cannot add extra properties to `allOf` objects, but you can add them to a new object in the `allOf` array

In settingBase, I need to move properties into an object in allOf.
Before:
{
  "$schema": "https://json-schema.org/draft-07/schema",
  "title": "User State Contribution Schema",
  "description": "The data an extension provides to inform Platform.Bible of the user state it provides",
  "type": "object",
  "properties": {
    "extensionControlledSetting": {
      "$ref": "#/$defs/extensionControlledSetting"
    },
    "projectSettingBase": {
      "$ref": "#/$defs/projectSettingBase"
    }
  },
  "$defs": {
    "extensionControlledSetting": {
      "description": "Setting definition that is validated by the extension.",
      "allOf": [
        {
          "$ref": "#/$defs/settingBase"
        }
      ]
    },
    "projectSettingBase": {
      "description": "Base information needed to describe a project setting entry",
      "allOf": [
        {
          "$ref": "#/$defs/settingBase"
        }
      ]
    },
    "settingBase": {
      "description": "Base information needed to describe a setting entry",
      "allOf": [
        {
          "$ref": "#/$defs/stateBase"
        }
      ],
      "properties": {
        "label": {
          "description": "localizeKey that displays in the settings dialog as the setting name",
          "type": "string"
        },
        "description": {
          "description": "localizeKey that displays in the settings dialog to describe the setting",
          "type": "string"
        }
      },
      "required": [
        "label"
      ]
    },
    "stateBase": {
      "description": "Base information needed to describe a state entry",
      "type": "object",
      "properties": {
        "default": {
          "description": "default value for the state/setting",
          "type": "any"
        }
      },
      "required": [
        "default"
      ]
    }
  }
}

After:
{
  "$schema": "https://json-schema.org/draft-07/schema",
  "title": "User State Contribution Schema",
  "type": "object",
  "properties": {
    "extensionControlledSetting": {
      "$ref": "#/$defs/extensionControlledSetting"
    },
    "projectSettingBase": {
      "$ref": "#/$defs/projectSettingBase"
    }
  },
  "$defs": {
    "extensionControlledSetting": {
      "allOf": [
        {
          "$ref": "#/$defs/settingBase"
        }
      ]
    },
    "projectSettingBase": {
      "allOf": [
        {
          "$ref": "#/$defs/settingBase"
        },
        {
          "type": "object",
          "properties": {
            "label": {
              "type": "string"
            }
          }
        }
      ]
    },
    "settingBase": {
      "allOf": [
        {
          "$ref": "#/$defs/stateBase"
        },
        {
          "type": "object",
          "properties": {
            "label": {
              "type": "string"
            },
            "description": {
              "type": "string"
            }
          },
          "required": [
            "label"
          ]
        }
      ]
    },
    "stateBase": {
      "type": "object",
      "properties": {
        "default": {
          "type": "any"
        }
      },
      "required": [
        "default"
      ]
    }
  }
}

This build step is going to be manual instead of automatic because the automatic engine doesn't do a perfect job and would need hand editing anyway. It is also something that should only have to be done very rarely once we do the initial transformations. Matt already has started some of this work on another task so I am going to close this one as a won't fix/ no longer needed task.


add community example gallery?

Would be nice to put something together where users could submit examples of successful synthesis. would want to have some guidelines and minimal checks (to make sure that they run and contain enough info that people can tell what's going on), should probably live in a separate dedicated repo, and then maybe just host on readthedocs like our tutorials?

pynapple does this with pynacollada


Debug _tofile in Visual Studio

I am running Visual Studio 2022, and working with the latest .NET 6.0 build from the Swashbuckle Repo which was cloned today.  I am trying to step through the code of swashbuckle CLI _tofile, and I am not able to do so.  Adding Debugger.Launch() to that code path does not appear to do anything, and I can't figure out how to run that config with setting the equivalent of depspath and and runtimeconfig in such a way that it can be run that way inside of .Net.  Would I have to change a buildtarget?
How does the team step through this code?  Any help would be appreciated.
(Often I find the answer after finally asking for help, so I apologize in advance if that happens)
Thank you,
dmp

There are multiple ways to do that, for example you could just enable debugger to go to the system types by disabling "just my code" in visual studio and then just debug through. Or you could bring your project into the Swashbuckle repository or vice versa and debug it.


Shared github workflows and operator-sdk 1.31

This PR switches the operator to use shared build workflows for building operator, bundle, and catalog/index images.
Additionally operator-sdk is bumped to 1.31. (also includes bump to OPM and controller-gen)
Jira: OSP-29146
Jira: OSP-26858

recheck

/test openstack-baremetal-operator-build-deploy


Missing commands in /usr/bin

Windows Version
Microsoft Windows [Version 10.0.19045.3693]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[X] WSL 1

Kernel Version
Linux version 4.4.0-19041-Microsoft<EMAIL_ADDRESS>(gcc version 5.4.0 (GCC) ) #3636-Microsoft Thu Oct 19 17:41:00 PST 2023
Distro Version
Ubuntu-22.04
Other Software
###NA
Repro Steps
NA
Expected Behavior
ls -la getc*
-rwxr-xr-x 1 root root 35112 Sep 25 08:45 getconf
expected getcwd in /usr/bin folder
Actual Behavior
ls -la getc*
-rwxr-xr-x 1 root root 35112 Sep 25 08:45 getconf
Note clean reinstall of WSL yesterday due to missing command rm in /usr/bin
rm was restored but noted today a different command is missing from /usr/bin
Diagnostic Logs
###NA

WSL doesn't control what commands are available in /usr/bin. This is controlled by the distro.
Closing since this is not a WSL issue


Arguments to macro show as text in arXiv HTML version of article

Description
We use a macro to make bold text with the same spacing/kerning as regular text bold, for alignment in tables that mix bold and non-bold numbers. The macro is defined as \newcommand{\tablebf}[1]{\pdfliteral direct {2 Tr 0.5 w}#1\pdfliteral direct {0 Tr 0 w}}. Unfortunately, it does not work in the HTML version of arXiv. For example, invoking the macro as \tablebf{14.8M} incorrectly shows "2 Tr 0.5 w14.8M0 Tr 0 w" on the HTML page, whereas the PDF correctly shows only the text "14.8M" in bold.
(Optional:) Please add any files, screenshots, or other information here.
Screenshot from Overleaf of our exact macro code, for reference:

Screenshot from HTML version of article, showing the error:

Screenshot from rendered PDF, showing the expected result:

(Required) What is this issue most closely related to? Select one.
Other
Internal issue ID
Since this field was not set automatically, I am entering text so that "Submit new issue" can be clicked.
Paper URL
Since this field was not set automatically, I am entering text so that "Submit new issue" can be clicked.
Browser
Since this field was not set automatically, I am entering text so that "Submit new issue" can be clicked.
Device Type
Since this field was not set automatically, I am entering text so that "Submit new issue" can be clicked.

Currently latexml tries to simply ignore \pdfliteral directives.
We could enhance latexml to recognize this case, but you're dangerously close to being in PDF-only territory.
This kind of macro may benefit from the \iflatexml conditional when it becomes available, to use the simpler bold directives already supported by latexml in the HTML context, while still using the PDF-optimized variant for PDF.

a more portable and idiomatic latex way to get unextended bold would be \fontseries{b}\selectfont (rather than bx) see for example
https://tex.stackexchange.com/questions/410739/align-numbers-based-on-the-decimal-point-with-textbf-and-stars-in-the-table/410741#410741
that isn't to say latexml shouldn't try to handle the pdftex specific markup that already exists in existing documents but simply ignoring it would be acceptable here I think.

Thanks for these insightful and helpful responses! I will look into the method suggested by @davidcarlisle for the future.
Also, apologies if this was a known WONTFIX/duplicate; the arXiv HTML preview encouraged me to submit an error report if I spotted any issues, so that's what I did. :)
I am closing the issue, but you may reopen it if you deem it relevant.

up to the latexml team but I wouldn't have closed this. In general latexml (or any convertor) is going to have to handle all kinds of tex markup, so just because there may be better markup that could have been used doesn't mean that the system should do something reasonable with whatever markup is actually there.

I agree the issue should have staid open: this is just some friendly exploratory discussion on our part @ghenter .
I don't have sufficient permissions to reopen, but I know who to ask...

Thanks for the discussion. This project has an ambitious goal and we know it will be more of a marathon than a sprint. I really appreciate the feedback from authors and readers -- it helps us identify and prioritize issues.

You could use the pdfrender package instead of the  primitive. This has the benefit that it would support also lualatex (and perhaps later other engines) and would probably allow latexml to provide an alternative:
\documentclass{book}
\usepackage{pdfrender}
\newcommand\tablebf[1]{\textpdfrender{TextRenderingMode=FillStroke,LineWidth=0.5}{#1}}
\begin{document}
blub \tablebf{some text} more text
\end{document}

This inserts the same literals into the PDF:
2 Tr
0.5 w
 [-333(some)-334(text)]TJ
0 Tr
1 w

and gives this as output


Please add support for led cover (Feature request)

As title says support for Led Cover would be desired. I used this application for the longest time but support for this type of notifications makes it hard to be notified on price updates.
Here is a link: https://www.samsung.com/us/mobile/mobile-accessories/phones/galaxy-s10-led-wallet-cover-black-ef-ng973pbegus/

I don't know how this feature can be implemented. This is a very specific technology from Samsung and does not have a public API.
Can you give an example of which apps support this feature, while not created by Samsung?

Cannot be implemented


Refine language about private plan visibility

Edit the statements within the tool (screenshots below) about the private visibility setting to make it clear to users that admins at their institution will have access to all plans, including private plans, for the purpose of making business decisions. This is consistent with pre-existing CDL privacy policy; clarified in new privacy policy/terms of use (see related issue #188).
Change Tooltip below to read -
Three possible states:

Private (red lock): only owners and co-owners can view the plan. Administrators at your institution can view all plans for program development purposes. See Terms of Use [link].
...

Change Tooltip below to read -
Three visibility options:

...
...
Private: only owners and co-owners can view the plan. Admins can view all plans for program development purposes. See Terms of Use [link].

Change Tooltip below to read -
Share my DMP

Publicly on the web. Your DMP will appear on the Public DMPs page of this site.
With others from [your institution].
Private (owners, co-owners, and admins only). See Terms of Use.

Change auto-generated email message to read -
...
Visibility definitions:
Private - Visible to owners and co-owners only. Admins can view all plans for program development purposes. See Terms of Use [link]
...

Also update Quick Start Guide "Sharing your DMP publicly"
https://dmptool.org/quickstartguide/#sharing


Broken Link

At the bottom of the wiki home page there is a broken link back to the synthea repository. In the "Guide to Synthea Projects" section the link is currently:
https://github.com/synthethichealth/synthea
Note the typo: "synthethichealth".

Fixed. Next time, just fix it. No need to report the issue.


[Add] Add more linsk in security and system desgin

Site URL
https://www.ibm.com/topics/database-security
Description of the above provided site
this is an docs by IBM about database-security
Category
Backend
Sub Category
security
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[ ] I am a GSSoC'23 contributor

@Sahilll15
Are you still interested in working on this issue? If not, please let me know so that I can open it for others to contribute.


CSV Agent does not pass parameter to allow dangerous code (1.0.6)

CSV Agent does not pass parameter to allow dangerous code to langchain component, and throws an error.
Suggested change to CSV Component :
from langchain_experimental.agents.agent_toolkits.csv.base import create_csv_agent
from langflow.custom import CustomComponent
from langflow.field_typing import AgentExecutor, LanguageModel
class CSVAgentComponent(CustomComponent):
display_name = "CSVAgent"
description = "Construct a CSV agent from a CSV and tools - ADC."
documentation = "https://python.langchain.com/docs/modules/agents/toolkits/csv"
def build_config(self):
    return {
        "llm": {"display_name": "LLM", "type": LanguageModel},
        "path": {"display_name": "Path", "field_type": "file", "suffixes": [".csv"], "file_types": [".csv"]},
        "adc": {"display_name": "Allow Dangerous Code", "type": True,"advanced" : True},
        "handle_parsing_errors": {"display_name": "Handle Parse Errors", "advanced": True},
        "agent_type": {
            "display_name": "Agent Type",
            "options": ["zero-shot-react-description", "openai-functions", "openai-tools"],
            "advanced": True,
        },
    }

def build(
    self, llm: LanguageModel, path: str, handle_parsing_errors: bool = True, agent_type: str = "openai-tools", adc: bool=True
) -> AgentExecutor:
    # Instantiate and return the CSV agent class with the provided llm and path
    return create_csv_agent(
        llm=llm,
        path=path,
        agent_type=agent_type,
        verbose=True,
        allow_dangerous_code=adc,
        agent_executor_kwargs=dict(handle_parsing_errors=handle_parsing_errors),
    )

Hi @Arron-Clague  ,
Do you need any assistance with this case? If not, please let us know if this issue can be closed.

Hi there : great to ear from you !
Im good as fixed the issues in the component code as I described in my own flows : I would imagine it would be helpful though to update the component in the project code so others do not have the issue ?
Thanks,
Arron

On 18 Jul 2024, at 20:31, Carlos Coelho @.***> wrote:
Hi @Arron-Clague https://github.com/Arron-Clague ,
Do you need any assistance with this case? If not, please let us know if this issue can be closed.
—
Reply to this email directly, view it on GitHub https://github.com/langflow-ai/langflow/issues/2525#issuecomment-2237378185, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCELNPULXJZLLULOHBWNE3TZNAJY5AVCNFSM6AAAAABKLDQ6BWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZXGM3TQMJYGU.
You are receiving this because you were mentioned.

@Arron-Clague,
Awesome to hear you got it fixed!
We'll check out the changes you mentioned and update the component in the project code so others won't run into the same issue. Thanks a ton for pointing that out!
We'll close this issue for now, but don't hesitate to reach out if you have more suggestions or need anything else.
Thanks again for your help!


Fix SDL2_net.framework installation on Mac

When installing on a Mac, copy SDL2_net.framework into the Game.app/Contents/Frameworks directory.

Until I finally break and buy an M1 Mac of some sort, I'll have to take your word for this! Thank you.

Until I finally break and buy an M1 Mac of some sort, I'll have to take your word for this! Thank you.


[WIP] Supports load config from kustomize

What type of PR is this?

/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Supports load config from kustomize

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/retest


improve test coverage

/azp run

Codecov Report

Merging #616 into master will decrease coverage by 81.82%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #616       +/-   ##
=========================================
- Coverage   81.82%     0%   -81.83%
=========================================
  Files         157    157
  Lines        7566   7532       -34
  Branches      454    459        +5
=========================================
- Hits         6191      0     -6191
- Misses       1375   7532     +6157

Impacted Files
Coverage Δ

...scala/com/microsoft/ml/spark/io/http/Clients.scala
0% <ø> (-13.8%)
:arrow_down:

...a/com/microsoft/ml/spark/io/image/ImageUtils.scala
0% <ø> (-46.16%)
:arrow_down:

...ala/com/microsoft/ml/spark/image/UnrollImage.scala
0% <0%> (-77.42%)
:arrow_down:

...com/microsoft/ml/spark/cognitive/RESTHelpers.scala
0% <0%> (ø)
:arrow_up:

...rosoft/ml/spark/cognitive/SearchIndexSchemas.scala
0% <0%> (-100%)
:arrow_down:

...spark/core/serialize/params/TransformerParam.scala
0% <0%> (-100%)
:arrow_down:

...icrosoft/ml/spark/lightgbm/LightGBMConstants.scala
0% <0%> (-100%)
:arrow_down:

...la/com/microsoft/ml/spark/opencv/OpenCVUtils.scala
0% <0%> (-100%)
:arrow_down:

...rosoft/ml/spark/core/schema/ImageSchemaUtils.scala
0% <0%> (-100%)
:arrow_down:

...cala/org/apache/spark/ml/NamespaceInjections.scala
0% <0%> (-100%)
:arrow_down:

... and 147 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41da2b7...a45ab2d. Read the comment docs.

/azp run


TypeDescriptor gives all threads the same non-thread-safe ReflectPropertyDescriptor

Defect
The TypeDescriptor API causes race conditions by handing out the same instance of ReflectPropertyDescriptor to all threads, even though instances of ReflectPropertyDescriptor are not thread-safe:
ReflectPropertyDescriptor.AmbientValue
ReflectPropertyDescriptor.ChangedEventValue
ReflectPropertyDescriptor.IPropChangedEventValue
ReflectPropertyDescriptor.DefaultValue
ReflectPropertyDescriptor.GetMethodValue
ReflectPropertyDescriptor.ResetMethodValue
ReflectPropertyDescriptor.SetMethodValue
ReflectPropertyDescriptor.ShouldSerializeMethodValue
Since other threads receive the same instance from TypeDescriptor.GetProperties, they execute these methods concurrently. Often, after the state bit is set but before the corresponding field is initialized. This causes the PropertyDescriptor to transiently act as though the underlying member in question is missing.
Practical effect
This is causing our tests to fail. Even though it hasn't been seen in production yet, TypeDescriptor is used frequently on background threads. As far as I can tell, there's nothing to prevent this from happening at random in production.
I don't see any mitigation for this bug other than to use a shared lock before accessing any method of  any PropertyDescriptor in case it is a ReflectPropertyDescriptor, though a mitigation would be appreciated.
Needed while targeting .NET Framework 4.6.2. Repros against net45 and net471 as well.
Repro
Here is a repro I put together that fails 9 out of 10 runs. It doesn't test SetValue and GetValue, which are the other interesting methods for us; they fail too, but less often than ResetValue and ShouldSerializeValue.
ReflectPropertyDescriptor repro.csproj
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>net462</TargetFramework>
    <OutputType>Exe</OutputType>
  </PropertyGroup>

</Project>

Program.cs
using System;
using System.ComponentModel;
using System.Threading;

namespace ReflectPropertyDescriptor_repro
{
    public sealed class SomeType
    {
        public int SomeProperty { get; set; }

        private void ResetSomeProperty() => SomeProperty = 42;

        private bool ShouldSerializeSomeProperty() => false;
    }

    public static class Program
    {
        public static void ConcurrentTest()
        {
            var propertyDescriptor = TypeDescriptor.GetProperties(typeof(SomeType))[nameof(SomeType.SomeProperty)];
            var instance = new SomeType();

            propertyDescriptor.ResetValue(instance);
            if (instance.SomeProperty != 42)
            {
                throw new Exception("Race condition inside ReflectPropertyDescriptor: ResetSomeProperty cannot have been actually invoked.");
            }

            if (propertyDescriptor.ShouldSerializeValue(instance))
            {
                throw new Exception("Race condition inside ReflectPropertyDescriptor: ShouldSerializeSomeProperty cannot have been actually invoked.");
            }
        }

        public static void Main()
        {
            const int threadCount = 10;

            using (var finished = new CountdownEvent(threadCount))
            {
                for (var i = 0; i < threadCount; i++)
                {
                    new Thread(() =>
                    {
                        ConcurrentTest();
                        finished.Signal();
                    }).Start();
                }

                finished.Wait();
            }
        }
    }
}

Just tried this on .NET Core and discovered that it has been fixed.
Located the PR: Fix some race conditions in TypeConverter lib
Issue: TypeDescriptor.GetProperties full of race conditions
Please port these fixes to .NET Framework.

@jnm2 thanks for reporting this. I am glad to hear that this is addressed in .NET Core!
I have marked that PR as something we should consider porting back to .NET Framework.

@AlexGhiondea Thanks for marking that! Is there any chance this will be fixed over Windows Update for 4.6.2, or will we be forced to target 4.7.2?
We've been avoiding 4.7 and 4.7.1, and due to the ValueTuple issues each has had, this turned out to be a very good thing for us.

@jnm2 .NET Framework 4.7.2 has just released and it does not contain the fix you have mentioned. We are going to consider it for a future version of .NET Framework!
To consider this for servicing we would need to understand the business impact of the bug and balance it with the compatibility risk of the change.

Thanks for the info. Is there for a way for us to be updated when you know whether or not it will make it into the fall release?

@jnm2 we don't have that mechanism unfortunately. You can reach out to me offline and we can discuss this further if you want.

I appreciate it. What's a good way to contact you?

@jnm2 you can reach me at # ghiondea [d_o_t] alexandru [_a_t_] microsoft.com #

That's very gracious of you. Thanks!


build: updated animo bot token

@karimStekelenburg can you merge this once you have added the new bot token env var?

What's the difference between NPM_TOKEN and NPM_TOKEN_ANIMO_BOT? If we have an Animo bot now, would it make sense to publish all packages through the Animo bot?


France.tv website Support

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and am willing to share it if required

Region
France
Example URLs
https://www.france.tv/
https://www.france.tv/france-3/direct.html
Provide a description that is worded well enough to be understood
Please add france.tv support it would be very nice to download from there
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
yt-dlp https://www.france.tv/france-3/direct.html

Did you even try it? It already is supported.
If you open another issue without a proper log you'll be blocked

Did you even try it? It already is supported.
If you open another issue without a proper log you'll be blocked

How do you use it? do you use a vpn?


Add console levels

Add console levels specified in issue #2, but exclude deprecated level debug and also exclude exception as it is an alias for error.

Do all of these logging functions work with var args? Wasn't sure

You are correct, some of them doesn't work with arguments or just breaks the logging. I'll investigate further which of these levels can be used with arguments and push another commit.


[Suggestion] EmbedCreator | Embed Editmsg

Is embed editmsg like Sinbad has in his embed cog something you'd consider? I know changing an embed in a message is a great help when you have a bunch of embeds in an info/rule channel for a server. Reposting them all just to change one message would be quite the hassle.
Some extra info taken from the old cog.
Syntax: +embed editmsg <message> <embedname> [use_global=False]
Edits an existing message by channelID-messageID to have an embed (must be saved)

Added in a3ea724e884ff8a87d8f01d3a1f7f12a342a7b63


To try out

Can you simply make the images available in docker hub instead of asking people to build it?

Ok, I will push the image to docker hub this week.

Hi @lowzj


Autowall & Hit Chance/Damage

Would that be something you'd add in the future
Also anything about the skin changer?

I'm working on a nSkinz integration.Idk what will daniel say but i can send a pull request if he allow me so.

@edgarbarney looks like he's already working on it!

Up for skin on weapons but preset ones from CSGO ❤❤❤


Cannot set property 'intArrayToUtf16' of null

when I install the package and import the library with just the following:
import { RNSerialport, definitions, actions } from "react-native-usb-serialport";
it will show the following error:

It''s saying RNSerialport is null, so why your RNSerialport is null? Did you complile the android code?

Are you run on iOS then meat the issue? If so, maybe you can try the code in this commit https://github.com/Roga-life/react-native-serialport/commit/21fbfa0243f1b8647a02d3f6076248bca26829a3 , and tell me the result.

I am facing the same issue. I am running the project in expo android

I am facing the same issue. I am running the project in expo android @flyskywhy

Make a test: just delete intArrayToUtf16 and hexToUtf16 source code in node_modules/react-native-usb-serialport/index.js, then is your APP can use RNSerialport other method e.g. startUsbService() normally? Or still say RNSerialport is null?
Please tell me the test result.


ModuleInterface: Fix decl attribute corruption in private swiftinterfaces

Erroneous declaration attributes were sometimes being printed in the private swiftinterfaces of modules because the changes from https://github.com/apple/swift/pull/42276 were effectively corrupting the attribute list for any decl with sythesized conformances (e.g. Equatable, Hashable). It is necessary to clone the attributes before adding them to the synthesized conformance extension decls.
Resolves rdar://94009296

@swift-ci please test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test


samtools dependency hardcoding prevents out-of-source builds

technically out of source builds are the safer way to do things, but the hardcoded instructions in the makefile are telling it to issue this command: cd ./samtools-0.1.18 && make samtools_0.1.18 && cp libbam.a samtools_0.1.18 .. which causes it to fail to compile.

Could you please provide more info about this? How exactly does it fail to compile for you (what error message you're getting) ?

by out-of-source I am referring to the practice of accessing the configure script from a remote directory and compiling it there. The makefile then tries to cd into the samtools directory that is in the source tree and since it cannot find it, compilation fails.
since you are keeping the old samtools in-source, perhaps it wouldn't be too bad of an idea to include it in your autotools build system somehow so that it can do its compiling out-of-source as well.
for instance you have the tophat cloned directory in /home/user/repositories/tophat
and then you create a directory named /home/user/repositories/tophat-build and run ../tophat/configure [arguments] and use make in that location. It will complain that "cd ./samtools-0.1.18 && make samtools_0.1.18 && cp libbam.a samtools_0.1.18" command had a non-zero return value and fail to continue.

i've begun putting together an autotools setup for that version of samtools to see if that would fix it: https://github.com/kotoroshinoto/tophat
currently the samtools configure appears to work, though when i call the autogen bootstrapper it complains: aclocal: warning: couldn't open directory '': No such file or directory, and i'm not quite sure why it would think it was handed a blank directory.

https://github.com/infphilo/tophat/pull/6
this may create some minor additional work making sure my Makefile.am files are up to standard so it doesn't install extra headers/libraries/etc alongside tophat when using make install etc.
I do believe it rectifies the problem I pointed out though.

https://github.com/samtools/samtools/issues/403
perhaps think about switching to using htslib instead of libbam?

giving this a bump:
https://github.com/samtools/samtools/issues/531
they've switched their library entirely over to htslib. presumably all the functionality you require would be there. libbam.a or libbam.so no longer are produced when building samtools. Version locking and distributing an old version of a completely changed project preserves functionality, so at least you're not in the same boat cufflinks is at the moment.
would it be particularly difficult to upgrade at this point?


Init containers should be moved to a template in common/ utils

This would be very helpful when k8s would move init containers out of annotations.

I think this is completed with https://github.com/att-comdev/openstack-helm/pull/137

@ss7pro; I believe this work is done. can you verify that this targets what you were asking for?


Socket receive timeout

Hello, how can I set the socket receive timeout?
    Context context("abc");
    Socket socket(context,ZMQ_REQ);

    socket.connect(PROTOCOL_ADDRESS);
    socket.send(request);
    PrintFormat("sending request");

    // Get the reply.
    ZmqMsg msg;
    socket.recv(msg);

does anyone know? I really can't figure out how to use zmq_setsockopt()

SOCKOPT(int,ReceiveTimeout,ZMQ_RCVTIMEO) // milliseconds

thank you


sudo tc qdisc show | grep "netem"   It looks like the packet rules are already setup

Hello!
I am actually having several issues. I am currently running Ubuntu 20.04.4 LTS for context.

The go install github.com/tylertreat/comcast@latest installation command isn't working for me; I needed to git pull the comcast repository, and then go build comcast.go and go install in order for the comcast command to work in my terminal. I am having to build and install each time I restart my terminal.
I simply can't get the comcast command to work properly; for example running comcast --device=<device name> --latency=2000 prints sudo tc qdisc show | grep "netem" It looks like the packet rules are already setup
and then comcast --stop prints Failed to stop packet controls.

Any advice on fixing either of these things or getting comcast working would be greatly appreciated.

I have the same error. When running the stop it says that it fails.
How can i check by hand if something still configured.

I've faced the same issue, and I've fixed it. The fix is:

make sure the tc tool was installed on the setup (to install it run this command: sudo yum install -y iproute-tc)

make sure the NetEm was installed on the setup (to install it run this commmand: yum -y install kernel-modules-extra)


coq: init at 8.8+beta1

Tested on darwin.
Drops the -opt configure flag, which has been deprecated (and a no-op) since at least Coq 8.5.

Success on x86_64-linux (full log)
Attempted: coq
Partial log (click to expand)
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type

Success on aarch64-linux (full log)
Attempted: coq
Partial log (click to expand)
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/x3wnn3wm9fzl81gx4221cv7mlgd4prvf-coq-8.7.2

@GrahamcOfBorg build coq_8_8

Success on x86_64-linux (full log)
Attempted: coq_8_8
Partial log (click to expand)
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/mc59m6gl51haasqhavk1hxdhjn56hi7k-coq-8.8+beta1

Success on aarch64-linux (full log)
Attempted: coq_8_8
Partial log (click to expand)
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/852pyikysrpav41rikhcmxz98lhdkpsi-coq-8.8+beta1

LGTM, but I'm not an expert on this part of the codebase.  cc @jwiegley since appears he works on this often.

It all looks good to me. I'd made similar changes locally last week when it was just "pre" and not yet "beta".


requirements.txt

Should we have a requirements.txt:

In general so that we're all using the same packages.
Because warehouse seems to rely on an unreleased version of pyramid, so we probably need a requirements.txt that points pip at the pyramid git repo?

$ pip install -e .
Obtaining file:///Users/marca/dev/git-repos/warehouse
  Running setup.py (path:/Users/marca/dev/git-repos/warehouse/setup.py) egg_info for package from file:///Users/marca/dev/git-repos/warehouse
...
Downloading/unpacking pyramid>=1.6.dev0 (from warehouse==15.0.dev0)
  Could not find a version that satisfies the requirement pyramid>=1.6.dev0 (from warehouse==15.0.dev0) (from versions: 1.5.3, 1.5.2, 1.5.4, 1.0.1, 1.0.2, 1.0, 1.0a1, 1.0a10, 1.0a2, 1.0a3, 1.0a4, 1.0a5, 1.0a6, 1.0a7, 1.0a8, 1.0a9, 1.0b1, 1.0b2, 1.0b3, 1.1.1, 1.1.2, 1.1.3, 1.1, 1.1a1, 1.1a2, 1.1a3, 1.1a4, 1.1b1, 1.1b2, 1.1b3, 1.1b4, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6, 1.2.7, 1.2, 1.2a1, 1.2a2, 1.2a3, 1.2a4, 1.2a5, 1.2a6, 1.2b1, 1.2b2, 1.2b3, 1.3.1, 1.3.2, 1.3.3, 1.3.4, 1.3, 1.3a1, 1.3a2, 1.3a3, 1.3a4, 1.3a5, 1.3a6, 1.3a7, 1.3a8, 1.3a9, 1.3b1, 1.3b2, 1.3b3, 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4, 1.4a1, 1.4a2, 1.4a3, 1.4a4, 1.4b1, 1.4b2, 1.4b3, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.5, 1.5a1, 1.5a2, 1.5a3, 1.5a4, 1.5b1)
Cleaning up...
No distributions matching the version for pyramid>=1.6.dev0 (from warehouse==15.0.dev0)
Storing debug log for failure in /Users/marca/.pip/pip.log

This already exists at dev/requirements.txt.


render errors with more details and write errors log

This is a proposal to give more detail when server errors happen. It's hard to anticipate where in the error the most important info is, so this will display statusText, message, details and url. Additionally, the complete errors get written to a log. This is less pretty, but more helpful when trying to find out what actually went wrong. It will look like this:

What do we do about transform errors?

That'll be a separate PR but I'm thinking to log those into a file as well. This one is just about the server errors.

I'll open another PR that's for both server and runtime errors, addressing the change requests everyone made.


fix: hide nfts with zero balance

Try out this version of the Hiro Wallet - download extension builds.

This PR adds a conditional to only display nfts with a balance greater than zero so that sold/transferred nfts are not shown in a users balances list.
cc/ @kyranjamie @fbwoolf @beguene @He1DAr

The use case testing  passed:This PR adds a conditional to only display nfts with a balance greater than zero so that sold/transferred nfts are not shown in a users balances list.


Added property disabled on view to negate the enabled property

Added property disabled on view to negate the enabled property. Can be useful in some cases, instead of mapping enabled -> !enabled, just use disabled property.

Merging this would set a dangerous precedent. There's a ton of boolean-based APIs and surely others will want negated versions of properties beyond just this one.
I see two easy paths forward for this, neither of which involves changes to RxBinding :grinning:

Use an Action1 helper factory for inverting Boolean-based instances:
whatever.subscribe(BooleanAction1s.not(RxView.enabled(view));

(or maybe BooleanAction1s.invert)

Use a Func1 helper factory for inverting Boolean-based streams:
whatever.map(BooleanFunc1s.not())
    .subscribe(RxView.enabled(view));

This way it can be applied to any boolean-based consumer–RxBinding produced or not!
Sorry that this is the second time now that I've sent you away to create a library / utility class. This is one of the cruxes of functional programming: the composition of individual functions to form something larger than themselves!

Your PR is otherwise well formed, though. So thanks for that :+1:

Haha no problem, I agree totally, that would lead to doubling each function with little of difference. I think BooleanActions could be a good addition to RxActions. I will try to extend on this idea.


Fix CMSMenuItem CSS references for namespaced controllers

The controller class name including namespace is used to create CSS class names for CMSMenuItem (specifically for the icon).
Currently this is done without escaping the class name resulting in CSS classes with backslashes (\) which are invalid characters for CSS class names.
This PR simply uses the existing Convert::raw2htmlname() method to escape the class name before use in CMSMenuItem.

@tractorcow any chance this can be included in 3.1.14 please?

Please can you tell me what the before and after class names are?

Sure, so Convert::raw2htmlname() simply strips out the backslashes (\).
Example before:
Example\Namespace\Controllers\ExampleAdmin
Example after:
ExampleNamespaceControllersExampleAdmin

I've updated the PR to include the same stripping of backslashes (\) from the controller name when used to reference the ID and CSS class names when updating the menu. Aside from this I can find no other uses of the class name that need to be updated.

OK, I think that \ need to be replaced with some character, otherwise a controller named MyController would conflict with a controller named My\Controller.

Agreed, although I think a conflict is unlikely we should code defensively. What character is best to use? I would suggest underscore (_).

I think underscores do make sense... but then PSR0 named classes could ALSO conflict.. gosh.
I reckon we go with an _ and that'll be close enough

Good point, maybe we should use dash (-) instead? Might as well avoid all known conflicts. Can you think of any potential conflicts using dash (-)?

That seems sensible :) can't think of anything immediately

I've updated the PR to replace backslashes (\) with dashes (-). I've extracted it into a helper function called Convert::fqcn2htmlname() as it was needed in more than one class. The helper function replaces all backslashes with dashes then runs it through Convert::raw2htmlname() for good measure. I've added the same regex used in Convert::raw2htmlname() after replacing the backslashes with dashes in the javascript as well.
Is there anything else that I should include or anything I've missed?

If you're going to add new features then it can't make a patch release (so this PR will need to go against 3 (or 3.2)).
If you want it in a 3.1 release, keep this to the minimum required to fix the bug to get it into 3.1.x release

Ok I'll change it to exclude new features and add them in against 3 or 3.2 once this is merged.

Thanks :)

Thanks


Added ability to set a custom field separator.

A semicolon is used if no custom separator is specified.

I recently encountered a situation in another project I was working on where the "answer" sides of the deck I was trying to build legitimately included semicolons.  This caused problems when importing into Anki.
Anki supports custom field separators, so I added support for them.

Looks like CI has some build issues.  :(

Hey @dseevr, thanks for this pull request!
It seems the Travis CI issue is due to the anki repo using the older build environments (as specified in https://github.com/bundler/bundler/issues/3558#issuecomment-171347979). I made some updates in the master branch in my repo - can you pull in the latest changes to your branch? That should (hopefully) fix the issue. Once that's dealt with I'll merge this and release an update to the gem.

Rebased and force pushed... looks like it's all working!  Thanks!

:+1: Awesome, thanks again! I'll be releasing a new version of the gem later today.

@dseevr Just pushed Anki 0.0.4 to Rubygems!

Thank you very much, and thanks for the gem!  👍

Oh, thanks for updating the README, too... I didn't even think of that


05_Pytorch going Modular model_builder.py

When we create an instance of TinyVgg Model, in arguments we should mention output_shape as len(class_names), but got an error, class_names is not defined in model_builder.py

You have to define class_names before creating instance of TinyVGG
class_names = ['pizza', 'steak', 'sushi']


Add signals for various events

Should use std.signals probably. This would help prevent potential issues with calling functions which require a draw, in order to defer them to the point where they can safely be called. An example of this would be GluiScrollable.scrollEnd and GluiScrollable.scrollTo

Those signals should be primarily for bindings to events within the tree, eg. before/after resizing, drawing, taking input etc.


Why are validator balances no longer part of ValidatorRecord?

Validator_balances was separated into its own UInt64 array, rather than being part of ValidatorRecord. What was the thought process behind this decision?
'validator_registry': [ValidatorRecord],
'validator_balances': ['uint64']

It's an optimisation to minimise the amount of hashing when computing the beacon state root. The validator_registry (which contains most of the state) changes slowly and requires little hashing effort to maintain. The validator_balances is a smaller part of the state with much higher churn, hence why it is segregated.

Thank you!


[Color Picker] Crashes when trying to drag to change the order

ℹ Computer information

PowerToys version: 0.31.1 (since 0.29.3)
PowerToy Utility: Color Picker
Running PowerToys as Admin: Yes
Windows build number: 19042.782

📝 Provide detailed reproduction steps (if any)

Open Settings
Turn to "Editor" in Color Picker
Drag them

✔ Expected result
Actually, I tried it in the Windows Sandbox, and it works well.
I also tried to reinstall it on my computer, but the problem still exists.
❌ Actual result
The whole program crashes.
📷 Screenshots
Maybe it's because I'm using Chinese, but I'm not sure if others have the same problem.

Duplicate of https://github.com/microsoft/PowerToys/issues/8317


Is data used for the paper available?

I'm mainly interested in builds per language, if that data is available

The data is available here: http://doi.org/10.5281/zenodo.3601137

The data is available here: http://doi.org/10.5281/zenodo.3601137