pkgs.nixosTests doesn't make sense

Issue description
While convenient, pkgs.nixosTests has surprising behavior. For example, this should fail, but it doesn't:
(import ./. { overlays = [ (self: super: { nginxStable = null; }) ]; }).nixosTests.nginx

So what is wrong here, is that the NixOS tests do not use the pkgs that they are passed. The NixOS tests assume that they can call Nixpkgs however they want. Although not a requirement for all tests, this means that in general the tests must reinvoke Nixpkgs, thus ignoring the Nixpkgs where .nixosTest was defined.
The documentation doesn't explain this ("Push NixOS tests inside the fixed point", which is misleading at best) and the implementation of nixosTests looks just fine, passing pkgs along as one would expect when reusing Nixpkgs for some tests. However, that is not what happens. pkgs will only be used to get qemu, lib, probably perl and perhaps some other things.
Why this is a problem: someone will use it to test whether NixOS, as built with their company overlay, still works. They will get false positives.
Steps to reproduce
nix-build --expr '(import ./. { overlays = [ (self: super: { nginxStable = null; }) ]; }).nixosTests.nginx'

Watch it succeed. It shouldn't.
Solutions
Ideally, we would pass pkgs to the NixOS machines. This can be done for some tests, but not for all the NixOS tests, because many depend on config.nixpkgs.config, which is unsupported by config.nixpkgs.pkgs (which is how you inject an existing Nixpkgs invocation).
So I don't see a way to make this work as one might predict. I suggest deleting pkgs.nixosTests.
@Ekleog do we really need this? It seems like just a convenience attribute.

@roberth This, theoretically, should have been solved in the refactoring at https://github.com/NixOS/nixpkgs/pull/50233. It looks like it didn't actually.
The issue is that it is kind of required for usage in meta.tests (see this comment).
I must say I am not sure what config.nixpkgs.config exactly does, but there is at least a place where the nginx module still has an import to nixpkgs that I missed in the above refactoring. I'll try to have a look at how and why it's there!

This is where NixOS gets its Nixpkgs, unless config.nixpkgs.pkgs is set. That's the code path for how everyone has been building NixOS, although that can change (but probably hasn't) since about a month ago. So that doesn't seem to be something we can change.
I've had another look at the actual tests that would break if we set config.nixpkgs.pkgs. We seem to have the following situations:

config.nixpkgs.config.packageOverrides. These can be replaced by overlays since #49256.
config.nixpkgs.localSystem. This is needs to be taken from pkgs anyway. See #49765.
config.nixpkgs.allowUnfree and config.nixpkgs.allowUnfreePredicate. I'm not sure whether doing this on hydra.nixos.org is even ok with policy. This only applies to quake3.nix and virtualbox.nix.

(1) and (2) can be fixed easily. (3) is a bit trickier. What I'd like to do is make sure that config.nixpkgs.config is not set when config.nixpkgs.pkgs is set, by means of assertions. This will break the (3) tests, but only when invoked via Nixpkgs instead of via NixOS, so that seems ok to me. I don't suppose hydra will build somepkgs.tests through Nixpkgs, but only builds the tests when building NixOS. Is that correct? If not, we can make an exception for quake3 and virtualbox.
Regarding the implementation, we can:
a. Make meta.tests return only paths to tests. This puts the burden on the users, which solves the 'leaky abstraction' by removing the leakiness. Doesn't seem necessary anymore, but is an option.
b. Make meta.tests use pkgs.nixosTest. This should reduce some duplication. If meta.tests requirements turn out to differ from user-side nixosTest requirements, we should duplicate the function such that meta.tests uses the new variation.
c. Make meta.tests set config.nixpkgs.pkgs by itself, right away, not using pkgs.nixosTest.
I'm in favor of (b).

Appendix: grep 'nixpkgs\.' in nixos/tests
ceph.nix:      nixpkgs.config.packageOverrides = super: {
common/letsencrypt/common.nix:  nixpkgs.overlays = lib.singleton (self: super: {
containers-imperative.nix:          inherit (config.nixpkgs.localSystem) system;
hocker-fetchdocker/machine.nix:{ nixpkgs.config.packageOverrides = pkgs': {
quake3.nix:      nixpkgs.config.packageOverrides = overrides;
quake3.nix:      nixpkgs.config.allowUnfreePredicate = unfreePredicate;
quake3.nix:          nixpkgs.config.packageOverrides = overrides;
quake3.nix:          nixpkgs.config.allowUnfreePredicate = unfreePredicate;
radicale.nix:        nixpkgs.overlays = [
subversion.nix:          nixpkgs.config.packageOverrides = overrides;
subversion.nix:          nixpkgs.config.packageOverrides = overrides;
virtualbox.nix:      nixpkgs.config.allowUnfree = useExtensionPack;

Thank you for your investigation!
allowUnfree in tests
For (3), I'd think neither hydra nor ofborg should build them. Currently we're kind of OK given none of them defaults to building them, but it does mean that it's currently possible to trigger some ofborg builds for unfree stuff by relaying through NixOS tests (cc @LnL7 in the absence of Graham, even though I don't really think it's that urgent an issue as ofborg never redistributes build products anyway).
That said, this question raises the proper question of what license these tests should be considered as having. Maybe it'd make sense to have them set meta.license to unfree in this case? This would both allow them to stay in meta.tests for easy human test, and avoid that either ofborg or hydra build them.
Now, if we want to do that, it will mean having a way to override nixpkgs with a custom allowUnfreePredicate before passing it to the test. I would hope it wouldn't be that hard to do, but… nixpkgs always finds a way to surprise me in this domain.
Fixing tests
I must say I'm not sure exactly what your point (b) entails. If I understand correctly, it is basically a replacement for make-test.nix, right? As such, it would require fixing all tests. This sounds like the best path forward to me too.
Ideally it would even handle the allowUnfree case as proposed above by propagating a non-false allowUnfree to setting meta.license to unfree in the “test” derivation.
Now, do I read correctly that this proposal is mostly changes to the tests themselves, and that it would fix all-tests.nix by making it actually respect its expected interface, ie. use its pkgs argument as the package set to use instead of relying on re-importing it?
nixosTests
If my analysis above is correct, I think it's compatible with nixosTests, which is basically just importing said all-tests.nix with the outer pkgs so that packages could easily depend on it for setting their meta.tests. As you didn't mention nixosTests in your latest message I'm not sure what your ideas for it currently are, sorry if that's already what you meant :)

allowUnfree in tests

So we can disable the 'unfree' tests, with the method of disabling depending on the outcome of your question what license these tests should be considered as having.
To run those tests manually, the user can simply pass allowUnfree into the Nixpkgs invocation that produces the pkgs in pkgs.nixosTests.
So (3) seems can be solved.

Fixing tests

The solutions for fixing the actual machines in the tests are provided by (1), (2) and the paragraph above.

Now, do I read correctly that this proposal is mostly changes to the tests themselves, and that it would fix all-tests.nix by making it actually respect its expected interface, ie. use its pkgs argument as the package set to use instead of relying on re-importing it?

The test definitions themselves (such as tests/nginx.nix) need to be changed slightly to allow injecting the test runner instead of always calling make-test.nix. make-test.nix will be the default, so you can just nix-build these tests.
I don't expect any problems replacing make-test.nix by pkgs.nixosTest after fixing the machines, but I haven't tried it yet.

nixosTests

Your analysis seems correct and what you suggest is roughly what needs to be done in all-tests.nix and related files.
Plans
I'm a little busy, but I'll try to make a PR for this soon.
If you feel like improving the "top-level" Nixpkgs and NixOS interfaces, have a look at #49765 in the meantime ;)
Future use in NixOS jobs?
(Skip this for now)
In theory, NixOS could reuse pkgs in pkgs.nixosTest to achieve an evaluation speedup, but I'd rather try not to change the way NixOS calls all-tests.nix for now. I also think we should have some tests that exercise the 'normal' modules/misc/nixpkgs.nix functionality, so perhaps all-tests.nix should then have access to two runners: an efficient one and a 'standalone' one.

I didn't even know this was a thing, and I think nix-build nixos/tests/virtualbox.nix --arg enableUnfree true makes much more sense than passing an already imported package set. This way each test can define what parameters are available and what actually makes sense.
As for ofborg, we could provide builds and tests for unfree software since no caches are redistributed. However there are some ideas on doing that for debugging purposes so for now it's best not to diverge too much from hydra in terms of what we build and how we evaluate IMHO.

@roberth Sounds great, thank you!
About the way NixOS calls all-tests.nix, as I split all-tests.nix out of release.nix only a few days ago I think there's no better time than now to change it if it needs to :)
But I also think that if pkgs.nixosTest means that the tests will actually use their pkgs argument without re-importing nixpkgs, then the evaluation-time gains should come in immediately: the refactor of release.nix to all-tests.nix already included passing the same imported nixpkgs as the pkgs argument (see commit message https://github.com/NixOS/nixpkgs/commit/83b27f60ceff23967e477c90bef8e78cc96d50a2, though I was wrong in that it actually only went from including nixpkgs twice per test to including it once per test plus twice globally). So the gain should come for free! Leading to actually including nixpkgs twice globally, and not once more per test.
@LnL7
I think we totally agree that nix-build nixos/tests/virtualbox.nix --arg enableUnfree true makes the most sense for manually running the tests. The question is more for ofborg (which currently runs approx. nix-build nixos/release.nix -A tests.virtualbox), hydra (same thing but via release-{small,combined}.nix) and meta.tests, all of which “need to” take defaults and can't pass additional arguments.
For all these, re-using the already-existing nixpkgs would be a gain both in purity (nixpkgs importing does quite some impure stuff, and even though restrict-eval prevents most or all of it most users won't run local builds as restrict-eval, so it impacts meta.tests) and evaluation time (importing nixpkgs was ~3s on my computer last I checked, multiplied by the number of tests that need to be run).
But this doesn't prevent keeping the dual-interface all-tests.nix / direct nix-build, with tests taking in either a pkgs argument or fetching it themselves with the arguments they get provided :)

I'm not familiar with how it works now. But not having the module system import nixpkgs means what you're testing is not what actually happens, so what are you testing at that point? That said I do agree evaluation time is important, given how expensive this has become over time.

So the idea is: you need to test what actually happens, but with which nixpkgs?
The objective is:

When you invoke nix-build nixos/tests/foo.nix, then it'll default to importing ../...
When you invoke nix-build nixos/release.nix -A tests.foo, then it'll default to, in nixos/release.nix, importing ./.. and using it in tests.foo (and using the same import for all tests if you -A tests, even though that's likely to fail because lots of tests are broken).
When you invoke nix-build -E '(import <nixpkgs> { overlays = [ ./overlay.nix ]; }).foo.tests, it'll defer to nixosTests.foo (from the same nixpkgs), which will call the test with the same overlay'd nixpkgs.

Before https://github.com/NixOS/nixpkgs/commit/83b27f60ceff23967e477c90bef8e78cc96d50a2 there were two imports of nixpkgs per test, independently from how they were invoked: one for the tools used by make-test.nix and one for the test itself. After that commit, there's only the nixpkgs import used by the test itself remaining. Once this issue will be fixed, there should remain no nixpkgs import, except if no pkgs argument is passed to the test in which case it'll default to importing ../...
Does that sound good to you? :)

Why do we even have nixosTests to begin with? It seems like it violates the separation between nixos and nixpkgs. If you want to have a reference from nixpkgs to the nixos test, why not just use a string? So you could do:
meta.tests = [ "nixos/tests/acme.nix" ];

The current architecture is misguided IMO. Nixpkgs shouldn't import NixOS at all.

@matthewbauer I totally agree with you that Nixpkgs shouldn't need to import NixOS at all. But it's all we have until something like https://github.com/NixOS/nixpkgs/pull/36842 lands, to be able to have at least a way to link from packages to some tests that show they're non-broken.
The end-goal of passthru.tests is to have ofborg automatically run them, and using strings for doing that would be a complete non-starter: passthru.tests is defined as a set of derivations that have as semantics that the test passes iff the derivation builds. These semantics are unrelated to nixosTests and I'm pretty sure we definitely do not want these to be replaced by a list of strings that need to be imported instead, among other things because we may want to say “to test gcc, I want to build coreutils, firefox and emacs” (to check a wide range of hacks that may not be supported by more recent gcc). We wouldn't want to give string paths to these derivations, would we? Some derivations don't even have files for themselves but a file that only defines a function that's later called in all-packages.nix.
(Note: you can see an example of passthru.tests being used without nixosTests in pkgs/development/tools/build-managers/bazel/default.nix)
And then nixosTests comes into play, because we just don't have any better way of specifying integration tests for packages for the time being: we need a way to propagate the few tests we actually have to nixpkgs so that they're automatically run by the passthru.tests infrastructure.
Also, BTW, your example doesn't tie Nixpkgs less to NixOS: nix is a lazy language, and a string that refers to a path is not particularly less bad that an import of that path, so long as the import is not used… and if it's used, then the string would have been imported anyway, so it's just as much of an import.
TL;DR: I totally agree we shouldn't need to import nixos into nixpkgs, but it's the best we've got to be able to automatically run tests for the time being.

I definitely think passthru.tests is useful for purposes of OfBorg and users running tests.

Closing in favor of #55798

I forgot about nixosTests until just now. It's strikes me as layering violation, and I really don't like those. Can we map nixos tests to pkgs outside pkgs/ instead?

@Ericson2314 The relation "has integration test" is indeed the opposite of "tests" and "depends", regardless of which software we're discussing. As such, it seems fair to say that this complexity (lack of an architectural rule) is part of the domain ie intrinsic complexity.
So I don't think we have to give up on passthru.tests, which is a nice interface that's probably easier to use than its decoupled alternative. Specifically, if you override a package, how would you be able to test it? I can't imagine an easier way than getting its tests attribute.
Fixing this problem is just a matter of having nixpkgs inject itself into the nixos tests and the packages injecting themselves into the test config. The latter can be done after #119942. It seems that I've assumed wrongly before about config.nixpkgs usage in the tests.

not for all the NixOS tests, because many depend on config.nixpkgs.config,

This is clearly not the case (anymore?). This can be done.


InfluxDB Pandas example: client.delete_database(dbname) error

The pandas example has a bug in the following code around line 32:
print("Delete database: " + dbname)
    client.delete_database(dbname)

which returns
Traceback (most recent call last):
  File "/Users/drew/PycharmProjects/influxdb/influxdb_pandas.py", line 52, in <module>
    main(host=args.host, port=args.port)
  File "/Users/drew/PycharmProjects/influxdb/influxdb_pandas.py", line 36, in main
    client.delete_database(dbname)
AttributeError: 'DataFrameClient' object has no attribute 'delete_database'

and should be:
print("Delete database: " + dbname)
    client.drop_database(dbname)

Yes

Addressed in PR #386

Issue still exists in influxdb-python/examples/tutorial_pandas.py
line 32: client.delete_database(dbname)


feat:implement sql style 'find_in_set' string function

Which issue does this PR close?

https://dev.mysql.com/doc/refman/8.0/en/string-functions.html#function_find-in-set:~:text=FIND_IN_SET(str%2Cstrlist)
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Thanks again @Syleechan


Missing Sec-WebSocket-Key on Handshake

I'm trying to connect to a socket.io server using https://github.com/benkay/java-socket.io.client
Just trying a simple example and output on the server is:
$ node server.js
info  - socket.io started
debug - client authorized
info  - handshake authorized<PHONE_NUMBER>1464584565
debug - setting request GET /socket.io/1/websocket/11501859041464584565
debug - set heartbeat interval for client<PHONE_NUMBER>1464584565
warn  - websocket connection invalid: received no key
info  - transport end
debug - set close timeout for client<PHONE_NUMBER>1464584565
debug - cleared close timeout for client<PHONE_NUMBER>1464584565
debug - cleared heartbeat interval for client<PHONE_NUMBER>1464584565
debug - client authorized for
I did some debug on Java-WebSocket code and what I found:
WebSocketClient.java : private void sendHandshake() throws IOException
calls: conn.startHandshake ( handshake );
WebSocket.java : public void startHandshake( HandshakeBuilder handshakedata ) throws IOException
calls: channelWrite( draft.createHandshake( draft.postProcessHandshakeRequestAsClient( handshakedata ) , role ) );
There is no information on handshakedata about Sec-WebSocket-Key
createHandshake and postProcessHandshakeRequestAsClient doesnt look for key information either so there is no Sec-WebSocket-Key field on the handshake then the socket.io server raises "warn  - websocket connection invalid: received no key" and closes the connection.

Hey, thanks for the report. I'll accept a pull request that does the correct behavior.

Your server seems to only understand the "latest" websocket protocol
because:
Hixie 75 doses not specify a Sec-WebSocket-Key
Hixie 76 does specify Sec-WebSocket-Key1 and Sec-WebSocket-Key2
only Hybi 10 does specify Sec-WebSocket-Key
You seem to send an old handshake.
Try to use draft10!
src/net/tootallnate/websocket/drafts/Draft_10.java
public HandshakeBuilder postProcessHandshakeRequestAsClient( HandshakeBuilder request )
sends Sec-WebSocket-Key

Closing. Reopen if this is still an issue...


llvmPackages_{12,13,14,15,16,17,18,git}: use common llvm

Description of changes
Partial split from #299807

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Just need to fix the Darwin issue, idk why it happens.

No more merge conflict

Oh, this PR also targets staging, but I think master should be OK?

@wegank No, I tried master but I was getting those spooky binutils.override missing errors in pkgs/stdenv/adapters.nix. I was suggested to switch to staging and it fixed my issues.

And another merge conflict here.

Fixed the merge conflict


Update variables.tf

Storage does not allow /31 and /31 CIDR ranges, only smaller (/bigger). But the function app does not accept plain IP addresses, only CIDR records, so you have to append plain IP addresses with "/32" suffix.

The second commit is because of a bug: https://stackoverflow.com/a/56084447
So we can create a new variable for the location of the SA, or disable IP whitelisting.


The header content contains invalid characters

Hi,
We're using logdna-agent version 2.1.2-1 on our server.
It's stopped to sending logs to logdna server and giving this error massively:
2021-01-14 08:50:55 0000 [error] { Error: A connection-based error occurred that will not be retried. See meta data for details.
    at process.nextTick (/usr/bin/node_modules/@logdna/logger/lib/logger.js:771:25)
    at _combinedTickCallback (internal/process/next_tick.js:131:7)
    at process._tickCallback (internal/process/next_tick.js:180:9)
  meta:
   { actual: 'The header content contains invalid characters',
     code: undefined,
     firstLine: 'log line text',
     lastLine: '\t',
     retrying: false,
     attempts: 1 } }
2021-01-14 08:50:58 0000 [error] { Error: A connection-based error occurred that will not be retried. See meta data for details.
    at process.nextTick (/usr/bin/node_modules/@logdna/logger/lib/logger.js:771:25)
    at _combinedTickCallback (internal/process/next_tick.js:131:7)
    at process._tickCallback (internal/process/next_tick.js:180:9)
    ```

I tried to update the logdna agent version but nothing change.

How can I resolve this problem?

This error is typically accurate, meaning that the headers have invalid characters somewhere in them.

Can you make sure that your "logdna key" is set correctly (no newlines, etc)? The authorization header is created from this.
What is the hostname of the machine running the agent?
Have you modified any of the URLs the agent uses for ingestion, or is it just the default?  Sometimes, invalid URL characters can cause this error
Lastly, I'll ask if this problem appeared without changing anything, or had something changed or been upgraded prior to seeing the error?

Based on what you've sent, these version are stable and have not changed for some time which leads us to believe that the error truly is in the value of the headers somewhere.  Debugging this will be tricky since the logger is a dependency of the agent, but we can perhaps guide you on adding some debug statements to expose some of the values (if that's possible for you to do).

This error is typically accurate, meaning that the headers have invalid characters somewhere in them.

Can you make sure that your "logdna key" is set correctly (no newlines, etc)? The authorization header is created from this.
What is the hostname of the machine running the agent?
Have you modified any of the URLs the agent uses for ingestion, or is it just the default?  Sometimes, invalid URL characters can cause this error
Lastly, I'll ask if this problem appeared without changing anything, or had something changed or been upgraded prior to seeing the error?

Based on what you've sent, these version are stable and have not changed for some time which leads us to believe that the error truly is in the value of the headers somewhere.  Debugging this will be tricky since the logger is a dependency of the agent, but we can perhaps guide you on adding some debug statements to expose some of the values (if that's possible for you to do).

Hi @darinspivey
Thanks for your answer.
Nothing change on the configuration that was working before. All the configuration that is working on other servers only hostname different with few characters
I'm also an nodejs developer, so i would like to make debug with your guidelines

Hi @darinspivey
Thanks for your answer.
Nothing change on the configuration that was working before. All the configuration that is working on other servers only hostname different with few characters
I'm also an nodejs developer, so i would like to make debug with your guidelines

Ok, so no immediate changes—that's good.  The quickest way to gather some more information is just to see the headers themselves.  If you're able to modify your<EMAIL_ADDRESS>file, then let's dump the headers as part of the error message.  You should be on version 2.0.0 of the logger, so on this line:
https://github.com/logdna/logger-node/blob/21b07593a25bb9a686879fbbb29c7509ba772c6e/lib/logger.js#L733
Add this as part of the errorMeta object.
, headers: config.headers

If the error comes out too nested such that the values are not clearly visible, you can always JSON.stringify(config.headers).  We'll be looking at things like user-agent which can sometimes have a lot of information in it.
Obviously, if we can know what it's failing, we'll know how to proceed with a fix on either server side or consumer side.  Just please be careful not to post sensitive values like your authorization header on this post.  Sorry, I had to say it :)

Ok, so no immediate changes—that's good.  The quickest way to gather some more information is just to see the headers themselves.  If you're able to modify your<EMAIL_ADDRESS>file, then let's dump the headers as part of the error message.  You should be on version 2.0.0 of the logger, so on this line:
https://github.com/logdna/logger-node/blob/21b07593a25bb9a686879fbbb29c7509ba772c6e/lib/logger.js#L733
Add this as part of the errorMeta object.
, headers: config.headers

If the error comes out too nested such that the values are not clearly visible, you can always JSON.stringify(config.headers).  We'll be looking at things like user-agent which can sometimes have a lot of information in it.
Obviously, if we can know what it's failing, we'll know how to proceed with a fix on either server side or consumer side.  Just please be careful not to post sensitive values like your authorization header on this post.  Sorry, I had to say it :)

it seems like logdna is compiled binary in our server (Centos7) so I couldn't find any node_modules fodler neither logdna. Should I compile it from source with editing it?

it seems like logdna is compiled binary in our server (Centos7) so I couldn't find any node_modules fodler neither logdna. Should I compile it from source with editing it?

@darinspivey

@darinspivey

Ah, yes, that's important to clarify.  From here on out, I'll assume that you have access to start/stop services on the server and keep it up while you manually play with things.  If you have at least node 10 on the box, then you can just install the node package and run it directly as root.  The binary build just encapsulates the node runtime and includes some init.d scripts.  If you're able to run it directly, and keep it running while the server is up, then this should work.
/etc/init.d/logdna-agent stop
cd
mkdir agenttest && cd agenttest
npm install logdna@latest --no-save
node index.js

See if that yields the same results.  In the meantime, we need to bump @logdna/logger to be current.  Although I don't think your issue would be fixed by that bump, it's a golden rule to be current before debugging anything.  We will start that upgrade, and in the meantime, you can do the manual testing to not be blocked by our efforts.

Ah, yes, that's important to clarify.  From here on out, I'll assume that you have access to start/stop services on the server and keep it up while you manually play with things.  If you have at least node 10 on the box, then you can just install the node package and run it directly as root.  The binary build just encapsulates the node runtime and includes some init.d scripts.  If you're able to run it directly, and keep it running while the server is up, then this should work.
/etc/init.d/logdna-agent stop
cd
mkdir agenttest && cd agenttest
npm install logdna@latest --no-save
node index.js

See if that yields the same results.  In the meantime, we need to bump @logdna/logger to be current.  Although I don't think your issue would be fixed by that bump, it's a golden rule to be current before debugging anything.  We will start that upgrade, and in the meantime, you can do the manual testing to not be blocked by our efforts.

I have root user on server but node didn't installed on it and it's little bit dangrous to install because it's production database master server. is there any way to debug it?

I have root user on server but node didn't installed on it and it's little bit dangrous to install because it's production database master server. is there any way to debug it?

Hmm, ok.  We can get this fixed, it'll just require a few code changes, so bear with us.  Our agent needs to have its @logdna/logger bumped anyway.  I think now is the time to add some debugging features to the logger that can be activated from the agent.  We can accomplish that in 1 release, pending any logger changes.  At a minimum, the error message should contain more context like the headers.
There's plenty of things you might be able to do from the server, but none that I can walk you through (HTTP traffic interception to see headers, etc).  We will get right on these upgrades for you.  Sorry there isn't a quicker answer.

Hmm, ok.  We can get this fixed, it'll just require a few code changes, so bear with us.  Our agent needs to have its @logdna/logger bumped anyway.  I think now is the time to add some debugging features to the logger that can be activated from the agent.  We can accomplish that in 1 release, pending any logger changes.  At a minimum, the error message should contain more context like the headers.
There's plenty of things you might be able to do from the server, but none that I can walk you through (HTTP traffic interception to see headers, etc).  We will get right on these upgrades for you.  Sorry there isn't a quicker answer.

Keeping this open, as the new PR won't directly solve your issue.  Once we upgrade the agent, you can bump your version and we'll see if we can't get some more context for your error.

Keeping this open, as the new PR won't directly solve your issue.  Once we upgrade the agent, you can bump your version and we'll see if we can't get some more context for your error.

so can I upgrade the agent now to see more debug messages?

so can I upgrade the agent now to see more debug messages?

The agent release is still pending, we will keep you posted.

The agent release is still pending, we will keep you posted.

@ne0c0de a new version of the agent should be available for linux now (Windows probably tomorrow).  Assuming you're on linux, see if you can bump it and get some more context on what your error might be.  What are your headers?

@ne0c0de a new version of the agent should be available for linux now (Windows probably tomorrow).  Assuming you're on linux, see if you can bump it and get some more context on what your error might be.  What are your headers?

Hello @darinspivey here's the detail log:
{ Error: A connection-based error occurred that will not be retried. See meta data for details.
    at process.nextTick (/usr/bin/node_modules/@logdna/logger/lib/logger.js:777:25)
    at _combinedTickCallback (internal/process/next_tick.js:131:7)
    at process._tickCallback (internal/process/next_tick.js:180:9)
  meta:
   { actual: 'The header content contains invalid characters',
     code: undefined,
     firstLine: 'xxxxx',
     lastLine: 'zzzz',
     retrying: false,
     attempts: 1,
     headers:
      { 'Content-Type': 'application/json; charset=UTF-8',
        'Content-Encoding': 'gzip',
        'user-agent'<EMAIL_ADDRESS>(logdna-agent/2.2.0 CentOS/8.3.2011\n)' },
     url: 'https://logs.eu-de.logging.cloud.ibm.com:443/logs/agent?now=1611748044068&hostname=xxx-yyy.zzz.cloud&mac=00%3A00%3A00%3A00%3A00%3A00&ip=<IP_ADDRESS>&tags=mfa-db1' } }
     ```

hostname and ip values are changed here but there's a normal characters in real lines.

Hello @darinspivey here's the detail log:
{ Error: A connection-based error occurred that will not be retried. See meta data for details.
    at process.nextTick (/usr/bin/node_modules/@logdna/logger/lib/logger.js:777:25)
    at _combinedTickCallback (internal/process/next_tick.js:131:7)
    at process._tickCallback (internal/process/next_tick.js:180:9)
  meta:
   { actual: 'The header content contains invalid characters',
     code: undefined,
     firstLine: 'xxxxx',
     lastLine: 'zzzz',
     retrying: false,
     attempts: 1,
     headers:
      { 'Content-Type': 'application/json; charset=UTF-8',
        'Content-Encoding': 'gzip',
        'user-agent'<EMAIL_ADDRESS>(logdna-agent/2.2.0 CentOS/8.3.2011\n)' },
     url: 'https://logs.eu-de.logging.cloud.ibm.com:443/logs/agent?now=1611748044068&hostname=xxx-yyy.zzz.cloud&mac=00%3A00%3A00%3A00%3A00%3A00&ip=<IP_ADDRESS>&tags=mfa-db1' } }
     ```

hostname and ip values are changed here but there's a normal characters in real lines.

Ah there is a new line in the user-agent header @darinspivey

Ah there is a new line in the user-agent header @darinspivey

I guess it's reading that data from somewhere in the system. can I have a chance to manipulate it? @evanlucas ?

I guess it's reading that data from somewhere in the system. can I have a chance to manipulate it? @evanlucas ?

Ah, great!  That's the info we needed.  Yes, the newline is the problem.  This is being sent over from our agent, so we will take a look there.  The fix should be straight forward (hopefully I'm not jinxing it ;)
Thanks for your patience while we work through this.

Ah, great!  That's the info we needed.  Yes, the newline is the problem.  This is being sent over from our agent, so we will take a look there.  The fix should be straight forward (hopefully I'm not jinxing it ;)
Thanks for your patience while we work through this.

I see no reason why the fix can't be in the logger.  It should remove invalid characters no matter where they come from.  We will be able to fix it quicker this way.  Standby.

I see no reason why the fix can't be in the logger.  It should remove invalid characters no matter where they come from.  We will be able to fix it quicker this way.  Standby.

hello @darinspivey is that commit released officially or I should wait for some time for it?

hello @darinspivey is that commit released officially or I should wait for some time for it?

It's available in the npm registry, version 2.2.2: https://www.npmjs.com/package/@logdna/logger

It's available in the npm registry, version 2.2.2: https://www.npmjs.com/package/@logdna/logger

I think it's not ready yet in Centos Yum repo right? Because whenever I try to update it's saying that Package logdna-agent-2.2.0-1.x86_64 is already installed

I think it's not ready yet in Centos Yum repo right? Because whenever I try to update it's saying that Package logdna-agent-2.2.0-1.x86_64 is already installed

oh, I misunderstood the question, sorry.
Indeed, the agent hasn't been released yet.

oh, I misunderstood the question, sorry.
Indeed, the agent hasn't been released yet.

Regarding the release of the agent, the latest version is<EMAIL_ADDRESS>which has already been released for RedHat (yum), Debian (apt), and Windows early this week<EMAIL_ADDRESS>is using<EMAIL_ADDRESS>as seen here

Regarding the release of the agent, the latest version is<EMAIL_ADDRESS>which has already been released for RedHat (yum), Debian (apt), and Windows early this week<EMAIL_ADDRESS>is using<EMAIL_ADDRESS>as seen here

Sorry, @ne0c0de , the issue was auto-closed after merge.  The logger is a dependency of the agent, so we have to do another release of that before you'll see the true fix.  Sorry for the delay.

Sorry, @ne0c0de , the issue was auto-closed after merge.  The logger is a dependency of the agent, so we have to do another release of that before you'll see the true fix.  Sorry for the delay.

LogDNA Agent v2.2.1 which contains<EMAIL_ADDRESS>has just been released for Linux.

LogDNA Agent v2.2.1 which contains<EMAIL_ADDRESS>has just been released for Linux.

@ne0c0de Please confirm that your issue is resolved, thanks!

Yes, I just updated agent today and it working without any error.
Thank you for your help


Introduce GitHub action

Currently, this project doesn't have CI environments 🤕
I recommend introducing CI environment strongly.
So I added GitHub Action environment instead of Travis CI.
This action runs some situations to dump Pokémon DB.

Run locally using all supported Pythons
Run on Docker Container

You have to merge #113 and #116 before to pass these jobs.
Please review them all 🙏

Hi! thanks for the PR! It seems that there are some conflicts that cannot be resolved rising the UI. Could you have a look?

I fixed then it seems to pass all tests 🌸

By the way, Can I be a maintainer of this repo?
Recently, I’m developing a Pokémon-related product as a hobby and I use this library.
I’m looking forward to Scarlet/Violet. I wish this repo is maintained for the feature series.
I’m a Pokémon trainer since the first series and I played Sword/Shield for over 1000 hours.
I can develop Python and some other programming languages.
Thank you.

I understood. I use this library at my own risk. I wish for future developments.

Yeahh, thanks for the contributions but I really doubt there will be any code updates other than to the CSV files :), from us.
But feel free to open as many PR as you want, I'll try to review and merge everything. If you commit, we could invite you as an external collaborator for this project so at least you'll have write access.
Also, I see that you are interested in the upcoming gen9. Are you planning to extract data from the games? If you do, we and Veekun would be really interested in it.


Add option to only emit warnings (#51)

Fixes #51
Spec resembles eslint: https://github.com/webpack-contrib/eslint-loader#errors-and-warning

Hey, thanks for the typo hint. I've also added a test now.

Hey @ugrupp sorry for taking so long to publish, life got in the way, but it's live now :). I'll also invite you as a collaborator, thanks a lot for your initiative! :)

No problem, thanks a lot! :)


Dialog with input

Hello,
Would it be possible to display an input field inside this dialog?
Thank you.

@Unforgiven-wanda This library is based upon on https://github.com/javiersantos/MaterialStyledDialogs, I'm not sure if its possible to implement a custom view inside the modal.

Thank you. I will investigate further and comment here for posterity if I stumble upon anything worth noting.


fix: internal error when Prisma client runtime error occurs

We can't check Prisma's error type against PrismaClientKnownError class because we can't reference generated Prisma classes from the internal package. Use a weakly-typed checking instead.

#49


Add stronger typing to gradient accumulation scheduler callback

What does this PR do?

Add types for gradient accumulation scheduler callback
scheduling is a Dict[int, int]
add types for the on_epoch_start

Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[x] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@ananthsub it is failing because there are circular imports

@williamFalcon can this be merged?


Execution beyond the context of the fiber resume is required for some…

Hello. This PR is related to the following:
https://github.com/mruby/mruby/issues/6060
Originally, there was an issue in mruby where the stack would get corrupted when executing Fiber#resume in a C context, and as a workaround, there is the approach of wrapping Fiber execution in a Proc.
https://github.com/mruby/mruby/issues/3056
This workaround is used in h2o and ngx_mruby.
However, with the addition of this commit included in mruby 3.2 and later, this workaround will no longer function.
https://github.com/mruby/mruby/pull/5782
My request is that until the issue with Fiber is resolved, I would like to request permission to continue using this workaround.
I would appreciate it if you could consider this.

Is this still required after #6076?

The investigation is still in progress and the ngx_mruby test is not successful.

Yes, the following error continues to be output.
can't cross C function boundary(FiberError)

I was able to fix the remaining problem of switching to mrb_fiber_resume().
I don't know about in production, but at least nginx/test.sh succeeds on my local FreeBSD environment, and CI with GitHub Actions also succeeds.
Here is a summary of the results from my ngx_mruby experimental branch:.

The https://github.com/mruby/mruby/commit/9ee7edc1ac02f95aefe6b8e2bbbe7c76237d5e36 patch is required for mruby 3.2.0.
The https://github.com/mruby/mruby/commit/e7828bac4d93d8ef5243a4794e0648a20d41a747 patch is required when using conf.enable_debug.
The https://github.com/dearblue/mruby-json/commit/ac8bdd20feb53f0fdf2fb766464aed8f6d438376 patch is required for mruby-json.

I haven't put all my thoughts together yet, but I plan to do the following

Split my experimental branch and propose some PR to ngx_mruby.
https://github.com/dearblue/ngx_mruby/commit/412f0a1af5891a428766adcf8dba9f1117210112
Change mrb_proc_new() to mrb_vm_proc_new() and mrb_closure_new() to mrb_vm_closure_new().
Add a new mrb_proc_new() with MRB_API modifier.
Add mrb_fiber_new() function.

That's great! I will test it on my end and contribute as needed.
I am very happy that this will eliminate Fiber's Hack from ngx_mruby.

I noticed that ngx_mruby was calling Fiber#resume inside Fiber#resume.
I have since tried and found that the current mruby no longer reproduces #5781 even when this PR is applied. However, the error is not displayed, so additional investigation is needed.
I suspect that the reason why it is no longer reproduced is due to a commit https://github.com/mruby/mruby/commit/a96a9f2c2bc64fbf7a5cd1371632c7fe13f3eec4 that changed the behavior of Fiber to that of "CRuby 3.0".
So I have come to the conclusion that we can use mrb_funcall_id(mrb, fiber, MRB_SYM(resume), 0) from the main() function without any problems at this time. As long as the native call stack allows it.
However, I don't think it can be mixed with Fiber#transfer, so I don't think this PR can be applied as is.
I need to do some more research, but I think the following restrictions need to be added regarding Fiber#transfer.

If Fiber#trasnfer is called from a fiber other than the root fiber, trace the calling fiber to make sure there is no C function call frame.
If mrb_fiber_resume() is called, check that the caller is not inside a direct or indirect Fiber#transfer.
If Fiber#resume is called inside a direct or indirect Fiber#transfer, check that the caller is Ruby.

Thank you for the improvements including ngx_mruby.
It seems that my issue is likely to be resolved, so I will close the PR.

For Notice.
I have send the proposed improvements as #6106.


Uncaught TypeError: Cannot read property 'buffer' of undefined

[Enter steps to reproduce below:]

...
...

Atom Version: 1.3.2
System: Ubuntu 14.04.3
Thrown From: remote-sync package, v3.5.0
Stack Trace
Uncaught TypeError: Cannot read property 'buffer' of undefined
At /home/karuppayya/.atom/packages/remote-sync/node_modules/ssh2/lib/SFTP/SFTPv3.js:1151

TypeError: Cannot read property 'buffer' of undefined
    at SFTP._readString (/home/karuppayya/.atom/packages/remote-sync/node_modules/ssh2/lib/SFTP/SFTPv3.js:1151:61)
    at SFTP._parse (/home/karuppayya/.atom/packages/remote-sync/node_modules/ssh2/lib/SFTP/SFTPv3.js:1018:31)
    at ChannelStream.<anonymous> (/home/karuppayya/.atom/packages/remote-sync/node_modules/ssh2/lib/SFTP/SFTPv3.js:49:12)
    at emitOne (events.js:77:13)
    at ChannelStream.emit (events.js:169:7)
    at ChannelStream.emit (/home/karuppayya/.atom/packages/remote-sync/node_modules/ssh2/lib/Channel.js:640:12)
    at Parser.<anonymous> (/home/karuppayya/.atom/packages/remote-sync/node_modules/ssh2/lib/Channel.js:95:20)
    at emitOne (events.js:77:13)
    at Parser.emit (events.js:169:7)
    at Parser.parsePacket (/home/karuppayya/.atom/packages/remote-sync/node_modules/ssh2/lib/Parser.js:607:12)
    at Parser.execute (/home/karuppayya/.atom/packages/remote-sync/node_modules/ssh2/lib/Parser.js:249:14)
    at Socket.<anonymous> (/home/karuppayya/.atom/packages/remote-sync/node_modules/ssh2/lib/Connection.js:523:18)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at readableAddChunk (_stream_readable.js:146:16)
    at Socket.Readable.push (_stream_readable.js:110:10)
    at TCP.onread (net.js:523:20)

Commands
     -1:48.7.0 core:select-left (atom-text-editor.editor.is-focused)
     -1:45 core:save (atom-text-editor.editor.is-focused)
     -1:26.7.0 command-palette:toggle (atom-text-editor.editor.is-focused)
     -1:25.6.0 core:paste (atom-text-editor.editor.mini.is-focused)
     -1:24.9.0 core:confirm (atom-text-editor.editor.mini.is-focused)
  2x -1:20 command-palette:toggle (atom-text-editor.editor.is-focused)
     -1:06.5.0 core:paste (atom-text-editor.editor.mini.is-focused)
 14x -1:05.4.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -0:54.9.0 remote-sync:configure (atom-text-editor.editor)
  8x -0:45.9.0 core:move-left (atom-text-editor.editor.mini.is-focused)
     -0:34.5.0 command-palette:toggle (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
  2x -0:28.1.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -0:10.6.0 command-palette:toggle (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
     -0:02.9.0 core:move-down (atom-text-editor.editor.mini.is-focused)
     -0:02.5.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:02.5.0 remote-sync:download-folder (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)

Config
{
  "core": {},
  "remote-sync": {}
}

Installed Packages
# User
laravel, v0.7.0
remote-atom, v1.3.9
remote-sync, v3.5.0

# Dev
No dev packages

@lalitindoria Are you still having this issue?

@elistone Haven't tried this lately, will let you know if I get this again :)


revert: Revert 2 source refactor PRs

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
It seems that the two PRs cause a huge performance downgrade in NEXMark.

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Not the real cause.


updated Runecrafting plugin with additional logic and change location of text

I think @KronosDesign had some work on getting the inventory item bounding boxes more correct.. maybe this is related?


Pressing load more repeats stuff already there

Describe the bug
When clicking the "load more button", marketplace will just show the same extensions as before
To Reproduce
Steps to reproduce the behaviour:

Go to marketplace
Load more
Scroll down
See error

Expected behaviour
Extensions that have not been shown already to show up
Screenshots

Desktop (please complete the following information):

OS: Windows 11
Spicetify version: The latest one idk number
Spotify version: 1.1.70
Marketplace version: latest one, idk number

Additional context
Add any other context about the problem here.

@niruvibes Can you pull the latest from the main branch and see if this is resolved for you?

I had this happen. Saved the complete log. I'm guessing it has something to do with the "Parsed -171/29 extensions" and then "Parsed 29/29 extensions" bit.
https://pastebin.com/raw/bGEAQL9A


h5 labels

Hi! First of all, thank you for letting me play with this dataset.
I'm currently using the h5 files. Can you confirm me that the label-integer correspondence (in h5 splits) is the one from 'shape_names_ext.txt' in ascending order and starting from zero?
e.g.
{bag: 0, bin: 1, box: 2, cabinet: 3, chair: 4, desk: 5, display: 6, door: 7, shelf: 8, table: 9, bed:	10, pillow: 11, sink:	12, sofa:	13, toile:	14}

Hi,
Thank you for your interest in our work. Yes, that’s right.


gulp-clean-css makes css min file larger than source?

Hi,
I'm trying to add a minifier to the standard v2 gulpfile and the output when using gulp-clean-css is larger than the source.
Have you got a way to get around/fix this?
Is this maybe why it's not included in the default gulp js file with v2?
Thanks a lot.

Hi there, the default gulp file for v2 already minify the css using the outputStyle: 'compressed' option of the gulp-sass plugin. This is why we do not use gulp-clean-css for v2.
Are you using both the 'compressed' gulp-sass option and gulp-clean-css?

Hi there, I'm closing this issue as no additional info was provided. Feel free to reopen it if you are still experiencing the problem. Cheers!


【Suggestion】

Separation of "Empty-Hand Detection" and "Injury Anomaly Detection"

0.6.1 has resolved this issue


Process under shell_run_command hangs if it generates much stderr

Expectation / Proposal
The expectation is that shell_run_command should be able to run any reasonable process.
Traceback / Example
To reproduce, use shell_run_command to invoke a simple script like this
#!/usr/bin/env python3
import sys
for i in range(10000):
    print("*" * 40, i, file=sys.stderr)

At least in our experience, the command (and thus the shell_run_command function) blocks forever, which is unfortunate and undesired. I believe the reason is this logic in shell_run_command: https://github.com/PrefectHQ/prefect-shell/blob/1d89814710c35cf5f12832d9188f1d8d7c59b048/prefect_shell/commands.py#L97
In summary, the logic is

run the command in a subprocess (using anyio.open_process)
read the process's stdout output (and log it) until EOF
wait for the process to terminate
if the process had an error return, read the process's stderr for the error message

Since stdout and stderr flow through pipes of finite size, that's a real problem. In that main read loop, nothing is reading the process's stderr pipe, which means after a little bit of stderr writing the process will block waiting for the pipe. Then shell_run_command will block waiting for the process to close its stdout, which will never happen, and the whole thing deadlocks.
(One thing I don't understand: anyio.open_process is called without stdout or stderr specified, so I'd expect them not to be redirected at all, in which case .stdout and .stderr should be None and the whole thing should always fail, but clearly it doesn't, so I guess somehow they are set up to be pipes?? Certainly when running on the system they seem to be pipes.)
A workaround is to use ShellOperation instead, which reads and logs both stdout and stderr concurrently.

[x] I would like to help contribute a pull request to resolve this (but I am completely unfamiliar with this codebase, so probably wouldn't be very good at it)

Thanks for debugging and reporting this! I wanted to confirm whether ShellOperation works for you?
Also, I don't think I was able to reproduce using:
other.py
from prefect_shell import shell_run_command
from prefect import flow

@flow
def test_flow():
    shell_run_command("python test.py")

test_flow()

test.py
#!/usr/bin/env python3
import sys
for i in range(10000):
    print("*" * 40, i, file=sys.stderr)

python other.py

ShellOperation definitely works and so we moved to using it.
I'll see if I can make a contained repro case for you...! Might be some other key ingredient. (@sckott FYI)

Thanks! I think we may be able to refactor the internals of shell_run_command to use ShellOperation block eventually.

Might be some other key ingredient.

Nothing I can think of. Thx for opening the issue @egnor

I think we may be able to refactor the internals of shell_run_command to use ShellOperation block eventually

This seems like a good solution

I have had the same issue - however I am not sure if this has actually something to do with printing to stderr or if it is just because of printing or if it is a result of just a long running process itself.
I tried building a minimal example that also includes (the probably weird) way I set up the agent:
minimal-example-prefect.zip

Thanks for debugging and reporting this! I wanted to confirm whether ShellOperation works for you?
Also, I don't think I was able to reproduce using: ...

When I try your example @ahuang11, exactly as you write it, it does hang here:
% python3 other.py
21:56:18.489 | INFO    | prefect.engine - Created flow run 'valiant-cormorant' for flow 'test-flow'
21:56:18.493 | INFO    | Flow run 'valiant-cormorant' - View at https://app.prefect.cloud/account/33d360a7-efaa-46ce-98ac-22df4011d411/workspace/2edd22be-f53a-4d0e-93dc-66e772f636a1/flow-runs/flow-run/a51901a4-55a0-475d-ba79-3a41af44a22c
21:56:19.512 | INFO    | Flow run 'valiant-cormorant' - Created task run 'shell_run_command-0' for task 'shell_run_command'
21:56:19.515 | INFO    | Flow run 'valiant-cormorant' - Executing 'shell_run_command-0' immediately...

I'm not sure why it's not hanging for you @ahuang11 -- perhaps on your system, shell pipes have unbounded length? I'm running on linux (Ubuntu 22.04, Linux 5.19.0-43-generic).


test - siphash-internal

[x] tests are added or updated

Update the internal siphash tests to use the framework's output..

Merged.  a24c1e224338ccd3d2b831bd2e3ba52a1eb31f01


Replace Commander with Yargs

Commander hasn't been updated in 2 years, and yargs is much more active and current

duplicate of #32


suggestion : different behavior for responsive table

source : http://materializecss.com/table.html
Desktop mode :

Mobile mode (table is reversed and scroll horizontally)

+1

Or simply wrap the table in a horizontal scrollable div:
http://getuikit.com/docs/table.html#overflow-container

I like the idea about not adding an scrollbar, because then it is against the idea of responsivness and making mobile friendly. +1 for the side table

+1, current responsive tables of semantic-ui are horrible...

I actually do think this is probably a better solution

How can be achieve the horizontal scroll behavior right now?

Using with "overflow: scroll" div today it's a mess with attached table... How to?

This please no, bot.


History always show me "a few seconds ago"

* TX History:
	a few seconds ago: => sent 4,206 bit ["Que parece" by gustavo] (0 confirmations)
	a few seconds ago: <= received 1,000 bit (0 confirmations)
	a few seconds ago: <= received 10,000 bit (0 confirmations)

I just realized that some fields don’t exists in the json:
[ { createdOn:<PHONE_NUMBER>,
         type: 'accept',
         copayerId: 'acac80598de2e6c2ddbcfaafe827174e8431e2cf06986ec3c6c91bdcaa7c3c34',
         copayerName: 'gustavo',
         comment: null } ] },
  { txid: '49a0983402435483262dcf0272d977c9adab22d97e9fee39029310b79fd14f24',
    fees: 20000,
    action: 'received',
    amount: 100000 },
  { txid: '9d07f710af50907ff45b5ab6de09fd224c744099c1b174f04051572a538b9304',
    fees: 10000,
    action: 'received',
    amount: 1000000 } ]

Missing createTs and confirmations.

It works. When the transaction is confirmed, It shows the time. I will close it because it 's a insight-api issue.


Have pcntl compiled in, disabled opcache for cli by default

The test should fail now.

Packages uploaded to unstable repo, so restarted the test


the  memory is nearly twice that of swin transformer

Hi，Thanks for great jobs, I try to infer a image ， I tried to use the segmentation model by cswin transformer small to test some pictures, and found that the  memory is nearly twice that of swin transformer small. Is this normal?

Hi, you can try to set use_chk param of CSwin to True for reducing memory footprint. I suppose you are already using checkpointing in Swin model.


125 improve test speed

This increases test speed significantly.
Closes #125

Huge ❤  for this PR.


sql, function: add weekday and dayofweek

This should close an issue on gitbase.

Thanks for your contribution @BakeRolls ! @erizocosmico @kuba can you review so that I can take this PR into consideration for the Hacktoberfest challenge ?


NotWidgetException in example

I have this issue: when I try to run the example on Flutter 2.5.2.
Does somebody know what this means?
════════ Exception caught by widgets library ═══════════════════════════════════
The following NotWidgetException was thrown building XmlLayout(dirty, state: XmlLayoutState#e2833):
Instance of 'NotWidgetException'
The relevant error-causing widget was
XmlLayout
lib\main.dart:119
When the exception was thrown, this was the stack
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/internal/js_dev_runtime/private/ddc_runtime/errors.dart 251:49  throw
packages/xml_layout/xml_layout.dart 256:7                                                                                build
packages/flutter/src/widgets/framework.dart 4782:27                                                                        build
packages/flutter/src/widgets/framework.dart 4665:15                                                                        performRebuild

I'm facing the same issue in flutter 2.10.4.


Fix pyspark test

Description
Env vars necessary to use PySpark doesn't set properly when using AzureML for testing.
This PR sets the env vars. Additionally, increase the stack size in driver and executors to avoid StackOverflowError.
Related Issues
#1898
Checklist:

[x] I have followed the contribution guidelines and code style for this project.
[x] I have added tests covering my contributions.

@miguelgfierro This PR is merging into your branch. You'll need to revert the commented tests back from your branch before merging into Staging or Main.


function_call

Hello,
i try to take an function_call in bash but i got the error "api action is not defined" ...
i tried as curl call to but its the same error.
any idea?
thanks

i fixed it thanks for no responding ...
the issue was that the function was not exist on the data fauxapi_actions.inc

Thanks @furkan92 - good to hear you were able to resolve on your own - I missed your original issue-report - regards - N

I note that there was a typo in the documentation here, the correct location of the pfsense_function_calls.txt file is /etc/pfsense_function_calls.txt


"movable map" issue on firefox

On firefox 24, opening http://ol3js.org/en/master/examples/full-screen.html and pressing my keyboard down key I get this:

(notice the gray band under the map). It's like if I could move the map of maybe 5 pixels up in its containers.
Chrome does not seem to be affected by this bug.
All the maps where the complete page has a height under 100% seem to be affected.

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

can't reproduce the issue with a recent version of firefox


Add example config.json

Might be nice to add an example config.json file to the repo to make it easier for people to use. A section in the README that explains what each token is and how to obtain it would be a nice bonus as well.

I'm currently extremely busy, I'll do so when I have some time.


Make page titles more descriptive (accessibility fix)

Trello card URL:
https://trello.com/c/fEW99Kpc/184-make-page-titles-descriptive-1
Changes in this PR:

Add gov.uk to page titles of every page

I've just added this in the format 'gov.uk' but not sure if it should maybe be 'GOV.UK' instead? If so I can easily change it. Was debating between adding it directly or adding it by adding something to the yaml file so that it can be used that way instead e.g. t(app.service-domain) = 'GOV.UK' but added it directly. I can also change this if necessary

Amended to use localization to get GOV.UK into the title


Note on "keep existing conventions"

For example, it would make sense to turn <podcast:explicit> into a unary element, where it's existence is taken as a "yes" and it's absence as a "no". But, that has never been the standard.

That's not quite true. For Apple Podcasts (although they've flip-flopped a couple times), a show can me "explicit" (yes), "clean" (no), or unmarked (no tag). It seemed the way the community used these tags provided some good understanding of the maturity level of the content. For example, "clean" would be appropriate for children, "explicit" would be adults-only stuff (content or language), while unmarked would be PG or PG-13 level.
Along these lines, perhaps a <podcast:contentRating> tag would be better and it could follow general G, PG, PG-13, R, and X ratings. Or, you could follow the TV ratings style to specifically indicate what content is in the show/episode, like violence, language, sex, etc.

That’s a good idea. I’ll put the rating tag in there like you describe and then folks can comment further to refine.

Blubrry has something like this, too.
I much prefer a rating system than simply clean/explicit/unmarked. Think, for example, how podcasts like Sexy Marriage Radio or One Extraordinary Marriage should be rated. Both podcasts are about the sexual relationship within the biblical foundation of marriage. So they might get "explicit" in detail, but not profane. Marking it "explicit" would seem to imply that it's profane, but you also can't mark it "clean" because Apple's guidance is that "clean" means appropriate for children.


Yandex browser (Chrome-based) compatibility

Just installed the extension on a Chromium-based browser from Yandex (browser.yandex.ru). It doesn't seem to scrobble on any of listed sites or even ask for Last.fm auth even though it shows the address bar icon (aka the scrobble toggle) when visiting such sites.
It's certainly not a compatibility issue with some another Chrome extension (because I don't have any of them else enabled right now), so maybe it's because of some built-in stuff by Yandex. Please check on this.

Fun is that yandex use https://addons.opera.com/en/extensions/ as extension store. Looks like extension developing experience be like in Opera.


Fresh install, missing prebuild packages for http-parser

http-parser/2.8.1@includeos/stable: WARN: Can't find a 'http-parser/2.8.1@includeos/stable' package for the specified settings, options and dependencies:

Settings: arch=x86, build_type=Release, compiler=clang, compiler.version=6.0, os=Linux
Options:
Dependencies:
Package ID: 53bfe98e7c9ebae022aa252c74a10f09cc4898b0

ERROR: Missing prebuilt package for 'http-parser/2.8.1@includeos/stable'
Try to build it from sources with "--build http-parser"
Or read "http://docs.conan.io/en/latest/faq/troubleshooting.html#error-missing-prebuilt-package"
There's a bunch of missing packages like http-parser and if I try to run conan with --build missing, it spits out some rather opaque errors like this while building botan:
error: unknown target triple 'x86-pc-linux-gnu', please use -triple or -arch
error: unknown target triple 'x86-pc-linux-gnu', please use -triple or -arch

Hi i suggest trying x86_64 x86 is only supported for platform nano


Is it possible to set the lifetime of access/id token?

I would like to test token expiration and silent refresh.
Is it possible to set the lifetime of access/id token?

The lifetime is determined by your server, and included in the signed part. I typically test this by spinning up my own Identity Server with a 30 sec timeout on the token.
I do think though that the expiration time is extracted and persisted seperately in your OAuthStorage of choice. So you could do something like this (untested):
this.oAuthService.events
  .pipe(filter(e => ['token_received'].includes(e.type)))
  .subscribe(_ => {
    this.oAuthStorage.setItem('access_token_stored_at', yourValueHere);
    this.oAuthStorage.setItem('expires_at', yourValueHere);
  });

Same for the id_token storage items.
Easier however I think is to use timeoutFactor and set it to 0.05 or however small you need it. This way the refresh is initiated after 5% of the total token lifetime has passed, allowing for quicker testing.
Finally, for seperately testing if silent refreshes work am sich, you could also just call this.oAuthService.silentRefresh() which just triggers a silent refresh right away.
PS. To see what's going on, I suggest also doing this in debug mode:
this.oAuthService.events.subscribe(e => (e instanceof OAuthErrorEvent) ? console.error(e) : console.warn(e));

Hope that helps.

Woah, wait a second, I only just saw that this issue was posted on my sample repo, not on the library's repo :blush:
That means the:

logging part is already in there (that final tip)
the timeoutfactor already is somewhat lower, see this file, but you can lower it even further


Support requiring fingerprint to view codes

Since Android 6.0, you can require a fingerprint authentication, it'd be nice to use this when opening or switching to the app. https://developer.android.com/about/versions/marshmallow/android-6.0.html#fingerprint-authentication

It's for sure an awesome idea (as a fallback PIN would be enough) to simply protect against an attack when you left your phone unlocked and somebody wants to use your OTP codes to get access to your accounts.
+1 for fingerprint and PIN as a fallback

+1
This app could really be awesome if fingerprint/PIN support was added (as well as external backup).

This would be an awesome feature!

Used to have this on iOS, so it'd be nice to have this on Android.

Is this really fixed?
I cannot find any option to enable fingerprint or pin.
I'm using FreeOTP version 2.0.4

@michag86 No, the logic was partially implemented but the full functionality still needs to be reviewed and tested with UI changes for Biometrics. Apologies for the confusion.

@justin-stephenson can you please reopen this issue?

@justin-stephenson can you please reopen this issue?

Done


Moving records not working in the RideSheet Public Sample v1

One trip appears to move, but then the process is halted. Two possible issues here:

A bug that needs fixing
There's a user-solvable problem in the spreadsheet, but there's not enough explanation in the message the user gets to know how to fix.

Debugging steps:

Set LogLevel: verbose in Document Properties
Debug Log: Exception: The data you entered in cell S19 violates the data validation rules set on this cell.
Dropdown validation for "Service ID" had an invalid/incorrect Ref
Fixed!

This leaves a few steps in order to improve this process:

[ ] Document debugging steps in the README, and note common errors (such as incorrectly configured validation rules)
[ ] Think about whether there is a better UX for showing errors when moving data (other than just the vague toast)
[ ] Is there a way already within the "fix validation" and "repair sheets" functions to handle this? Check if that would have solved the issue.
[ ] Consider changing the behavior if there is an error with validation - e.g. do we just ignore and continue? Do we flag the row or something? What else can be done!

Kevin's fork includes fix: cell validation is no longer an error, just a warning.


[sw/silicon_creator] Should the keymgr go into disabled state as part of the shutdown sequence?

Closing this issue since shutdown_keymgr_kill() (called by shutdown_finalize()) advances keymgr to disabled state. Please feel free to reopen if we should consider additional changes for this.


running dart app issue

Analyzer Feedback from IntelliJ
Version information

IDEA AI-191.8<IP_ADDRESS>00203
2.5.0-edge.1ef83b86ae637ffe7359173804cbc6d3fa25e6db
AI-191.8<IP_ADDRESS>00203, JRE 1.8.0_202-release-1483-b03x64 JetBrains s.r.o, OS Windows 10(amd64) v10.0 , screens 1366x768

Exception
Dart analysis server, SDK version 2.5.0-edge.1ef83b86ae637ffe7359173804cbc6d3fa25e6db, server version 1.27.2, FATAL error: FileSystemException: writeFrom failed, path = '' (OS Error: Insufficient system resources exist to complete the requested service.
, errno = 1450)
#0      Driver._captureExceptions.errorFunction (package:analysis_server/src/server/driver.dart:677:7)
#1      _CustomZone.handleUncaughtError (dart:async/zone.dart:1003:19)
#2      _CustomZone.runGuarded (dart:async/zone.dart:925:7)
#3      _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:963:23)
#4      _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#5      _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#6      _Timer._runTimers (dart:isolate-patch/timer_impl.dart:391:30)
#7      _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:416:5)
#8      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)

For additional log information, please append the contents of
file://C:\Users\cosmic\AppData\Local\Temp\report.txt.

This has not been reported again since Dart 2.5; please re-open if you see this in a recent version of Dart/Flutter.

This has not been reported again since Dart 2.5; please re-open if you see this in a recent version of Dart/Flutter.


Add support for /*  */ comments under the comments rule

Presently, under the comments rule, I just have
  Comment:
    enabled: true

I'll like to Enforce the use of /* */ comments everywhere

Hey @najela,
I'd be open to a pull request adding support for a style option to allow you to choose which comment style to enforce, but can you give me some idea of why you want to enforce /* */? Those kinds of comments are actually rendered in your CSS, which increases the size of your assets (thus resulting in a slower page load).
In other words, I think this might be a Bad Idea™, but I'd love to hear about your use case so I can better understand. Thanks!

@sds Thats for the explanation. I'm just used to the habit of using /* */ comments when writing code so I wanted to use the same commenting habit in my scss files

Added a style option in 276668aa077d4f69fa1997ee2c54500a8c967048.

Thanks :+1:


14.2.1bluetoothd

Uploading bluetoothd14.2.1.zip…

Nothing in the link, seems like you sent it out before the file get uploaded.

Nothing in the link, seems like you sent it out before the file get uploaded.

bluetoothd14.2.1.zip

Closed as completed


Merging develop into master to create v1.2.1 release

This PR brings master up to date with develop for the v1.2.1 release.

Bumped the version to v1.2.1


build: add nx

closes #7895
Testing the water by orchestrating the "build -> test" workflow in two of the packages.

I'm going to spend the time else before wasting more time on this.


Revise Credits and Footer

Expected Behavior
Revise the footer to read:

ScratchJr is a collaboration between the DevTech Research Group at Tufts University, and the Scratch Foundation.

On the About...Info page. In the "Who created ScratchJr?" section
Change:

ScratchJr is a collaboration between the ... The Android version

to

ScratchJr was developed by the ... The first Android version

New "Who Helped to Translate ScratchJr?" section:
ScratchJr has been translated into more than a dozen languages with the generous help of volunteer translators from around the world. Special thanks go to the translators who helped with our first translation into Spanish: Teresa Martínez Pérez, childhood education student; Marta Bonet Garrosa, Manuela Lara Lara, and Lidia Piñeiro Cordero, of Editorial Santillana; Sergio Antolinez, CEO of Tecnoaprendo; and Luisa María Palacios Maroto.

 ScratchJr website updates

Fixed


[HOWTO] Speed up org-agenda

What are you trying to achieve?
The loading of the org-agenda is very slow compared to vanilla Emacs (and my previous config), what can I do to speed it up?
What have you tried?
Just measurements, since this is beyond my knowledge.
Additional information

I have almost 200 org files that are 6.8 MB in size.
My old, quite extensive Emacs config, loads my org-agenda in under 10 s initially, then in under 1 s subsequently.
Doom Emacs loads my org-agenda in about 20 s initially, then in about 2 s subsequently.

System information

emacs   version    26.3
        features   XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GLIB NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD LCMS2
        build      sep 20, 2019
        buildopts  (--prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=lucid --with-xft --without-gconf --without-gsettings --with-modules '--program-transform-name=s/^ctags$/ctags.emacs/' 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now)
        windowsys  x
        daemonp    daemon
doom    version    2.0.9
        build      HEAD -> develop, origin/develop, origin/HEAD ed2fb6836 2020-03-03 23:33:53 -0500
        dir        ~/.doom.d/
system  type       gnu/linux
        config     x86_64-pc-linux-gnu
        shell      /bin/bash
        uname      Linux 5.4.23-1-MANJARO #1 SMP PREEMPT Fri Feb 28 22:45:29 UTC 2020 x86_64
        path       (~/.local/bin ~/.emacs.d/bin ~/.local/bin /bin /usr/bin /usr/local/bin /usr/local/sbin /usr/lib/jvm/default/bin /usr/bin/site_perl /usr/bin/vendor_perl /usr/bin/core_perl /usr/lib/emacs/26.3/x86_64-pc-linux-gnu/)
config  envfile    envvar-file
        elc-files  0
        modules    (:completion company ivy :ui doom doom-dashboard doom-quit hl-todo indent-guides modeline nav-flash ophints (popup +defaults) vc-gutter vi-tilde-fringe window-select workspaces :editor (evil +everywhere) file-templates fold snippets :emacs dired electric vc :checkers syntax :tools (eval +overlay) lookup magit :lang data emacs-lisp markdown (org +dragndrop +present) sh :config (default +bindings +smartparens))
        packages   (n/a)
        unpin      (n/a)
        elpa       (n/a)

((emacs
  (version . "26.3")
  (features . "XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GLIB NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD LCMS2")
  (build . "sep 20, 2019")
  (buildopts "--prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=lucid --with-xft --without-gconf --without-gsettings --with-modules '--program-transform-name=s/^ctags$/ctags.emacs/' 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now")
  (windowsys . batch)
  (daemonp . server-running))
 (doom
  (version . "2.0.9")
  (build . "HEAD -> develop, origin/develop, origin/HEAD ed2fb6836 2020-03-03 23:33:53 -0500")
  (dir . "~/.doom.d/"))
 (system
  (type . gnu/linux)
  (config . "x86_64-pc-linux-gnu")
  (shell . "/bin/bash")
  (uname . "Linux 5.4.23-1-MANJARO #1 SMP PREEMPT Fri Feb 28 22:45:29 UTC 2020 x86_64")
  (path "~/.local/bin" "~/.emacs.d/bin" "~/.local/bin" "/bin" "/usr/bin" "/usr/local/bin" "/usr/local/sbin" "/usr/lib/jvm/default/bin" "/usr/bin/site_perl" "/usr/bin/vendor_perl" "/usr/bin/core_perl" "/usr/lib/emacs/26.3/x86_64-pc-linux-gnu"))
 (config
  (envfile . envvar-file)
  (elc-files . 0)
  (modules :completion company ivy :ui doom doom-dashboard doom-quit hl-todo indent-guides modeline nav-flash ophints (popup +defaults) vc-gutter vi-tilde-fringe window-select workspaces :editor (evil +everywhere) file-templates fold snippets :emacs dired electric vc :checkers syntax :tools (eval +overlay) lookup magit :lang data emacs-lisp markdown (org +dragndrop +present) sh :config (default +bindings +smartparens))
  (packages "n/a")
  (unpin "n/a")
  (elpa "n/a")))

Profiler output with the relevant calls expanded:
- command-execute                                                                             16526  95%
 - call-interactively                                                                         16526  95%
  - funcall-interactively                                                                     16526  95%
   - klorax/agenda                                                                            16249  94%
    - org-agenda                                                                              16249  94%
     - org-let                                                                                16249  94%
      - eval                                                                                16249  94%
       - let                                                                                16249  94%
        - org-agenda-list                                                                     16249  94%
         - org-agenda-prepare                                                                 15387  89%
          - org-agenda-prepare-buffers                                                        15290  88%
           - org-get-agenda-file-buffer                                                       15072  87%
            - apply                                                                           15072  87%
             - +org--exclude-agenda-buffers-from-recentf-a                                    15072  87%
              - let                                                                           15072  87%
               - funcall                                                                      15072  87%
                - #<compiled 0x2165595>                                                       15072  87%
                 - find-file-noselect                                                         14305  82%
                  - find-file-noselect-1                                                      13638  79%
                   - after-find-file                                                          13544  78%
                    - apply                                                                   13544  78%
                     - doom--optimize-for-large-files-a                                       13062  75%
                      - if                                                                    13062  75%
                       - apply                                                                12813  74%
                        - #<compiled 0x1b4687>                                                12813  74%
                         - normal-mode                                                         6536  37%
                          - set-auto-mode                                                      6104  35%
                           - apply                                                             6104  35%
                            - #<compiled 0x23be0bd>                                            6102  35%
                             - apply                                                           6102  35%
                              - so-long--set-auto-mode                                         6100  35%
                               - apply                                                         6088  35%
                                - #<compiled 0x1b4e63>                                         6088  35%
                                 - set-auto-mode-0                                             6057  35%
                                  - org-mode                                                   6057  35%
                                   - org-install-agenda-files-menu                             4316  25%
                                    - org-agenda-files                                         4270  24%
                                     - mapcar                                                  4270  24%
                                        #<compiled 0x2163681>                                  4135  23%
                                        #<compiled 0x2163691>                                   126   0%
                                    + easy-menu-change                                           46   0%
                                   + org-update-radio-target-regexp                            1069   6%
                                   + run-mode-hooks                                             487   2%
                                   + org-macro-initialize-templates                              84   0%
                                   + org-set-regexps-and-options                                 41   0%
                                   + outline-mode                                                41   0%
                                   + set-face-foreground                                          7   0%
                                   + org-find-invisible-foreground                                3   0%
                                 + hack-local-variables                                          13   0%
                                   assoc-default                                                 10   0%
                                   inhibit-local-variables-p                                      4   0%
                                   set-auto-mode-1                                                2   0%
                               + so-long--check-header-modes                                     10   0%
                            + auto-minor-mode-set                                                 2   0%
                          + run-hooks                                                           429   2%
                            kill-all-local-variables                                              3   0%
                         - run-hooks                                                           6264  36%
                          - save-place-find-file-hook                                          3861  22%
                           - apply                                                             3861  22%
                            - #<compiled 0x29698f5>                                            3861  22%
                             - apply                                                           3861  22%
                              - ad-Advice-save-place-find-file-hook                            3861  22%
                               - #<compiled 0x296b8f5>                                         3861  22%
                                - apply                                                        3861  22%
                                 - +nav-flash-blink-cursor-a                                   3861  22%
                                  - if                                                         3861  22%
                                   - +nav-flash-blink-cursor                                   3861  22%
                                    - if                                                       3861  22%
                                     - nav-flash-show                                          3861  22%
                                      - beginning-of-visual-line                               2923  16%
                                       - vertical-motion                                       2857  16%
                                        - jit-lock-function                                    2857  16%
                                         - jit-lock-fontify-now                                2853  16%
                                          - jit-lock--run-functions                            2853  16%
                                           - run-hook-wrapped                                  2853  16%
                                            - #<compiled 0x2583b29>                            2853  16%
                                             - highlight-indent-guides--guide-region           1523   8%
                                              - font-lock-fontify-region                       1435   8%
                                               - font-lock-default-fontify-region              1435   8%
                                                - font-lock-fontify-keywords-region            1425   8%
                                                   org-do-latex-and-related                     984   5%
                                                 + org-fontify-meta-lines-and-blocks            290   1%
                                                   org-font-lock-add-priority-faces              49   0%
                                                 + org-activate-links                            26   0%
                                                 + org-do-emphasis-faces                         13   0%
                                                   org-activate-dates                             3   0%
                                                 + org-activate-footnote-links                    3   0%
                                                + font-lock-unfontify-region                      4   0%
                                                syntax-ppss                                      36   0%
                                              + highlight-indent-guides--get-prev-guides         14   0%
                                                highlight-indent-guides--calc-guides              3   0%
                                             + font-lock-fontify-region                        1310   7%
                                             + goto-address-fontify-region                       20   0%
                                      + end-of-visual-line                                      932   5%
                                      + nav-flash-use-pulse-p                                     3   0%
                                      + run-at-time                                               3   0%
                          + projectile-find-file-hook-function                                 1201   6%
                          + doom-modeline-update-buffer-file-name                               468   2%
                          + vc-refresh-state                                                    339   1%
                          + +vc-gutter-init-maybe-h                                             279   1%
                          + undo-tree-load-history-from-hook                                     68   0%
                          + recentf-track-opened-file                                            32   0%
                          + whitespace-turn-on-if-enabled                                         3   0%
                          + global-undo-tree-mode-check-buffers                                   3   0%
                            global-flycheck-mode-check-buffers                                    2   0%
                            global-evil-surround-mode-check-buffers                               2   0%
                           make-auto-save-file-name                                               3   0%
                       + prog1                                                                  249   1%
                     + #<compiled 0x19b9911>                                                    482   2%
                   + insert-file-contents                                                        23   0%
                   + file-truename                                                               16   0%
                  + find-buffer-visiting                                                         53   0%
                  + file-truename                                                                18   0%
                    abbreviate-file-name                                                         10   0%
                  + create-file-buffer                                                            6   0%
                 + org-find-base-buffer-visiting                                                767   4%
             org-refresh-category-properties                                                     62   0%
           + org-refresh-effort-properties                                                       30   0%
             org-refresh-stats-properties                                                        30   0%
             org-refresh-properties                                                              24   0%
           + org-set-regexps-and-options                                                         24   0%
          + org-agenda-mode                                                                      77   0%
          + org-agenda-files                                                                     17   0%
         + apply                                                                                568   3%
         + org-agenda-finalize                                                                  167   0%
         + org-agenda-finalize-entries                                                           40   0%
         + org-agenda-files                                                                      20   0%
         + org-days-to-iso-week                                                                  10   0%
           org-check-agenda-file                                                                  3   0%
           org-agenda-add-time-grid-maybe                                                         3   0%
           ws-butler-after-change                                                                 3   0%
   + counsel-M-x                                                                                247   1%
   + handle-focus-in                                                                             30   0%
+ ...                                                                                537   3%
+ timer-event-handler                                                                           183   1%
+ redisplay_internal (C function)                                                                 6   0%

Where klorax/agenda is just:
  (defun klorax/agenda (&optional arg)
    (interactive "P")
    (org-agenda arg "A"))

Not sure whether this helps but in my case setting org-agenda-dim-blocked-tasks to nil gave me a few seconds (I think) and before I used doom I didn't use that option anyway. It seems to default to non-nil in doom, making stuff slow(er). See also https://orgmode.org/org.html#Speeding-Up-Your-Agendas .

Would (setq org-agenda-inhibit-startup t) help?

Hey, thank your for addressing this :slightly_smiling_face: At least for me,  #2672 does not improve the load time of the agenda noticeably, though.

@dpaetzel @klorax If you are still experiencing this slowness, could one of you try adding this to ~/.doom.d/config.el and let me know if it improves the situation?
(defadvice! fix-exclude-agenda-buffers-from-recentf-advice (orig-fn file)
  :override #'+org--exclude-agenda-buffers-from-recentf-a
  (let ((recentf-exclude (list (lambda (_file) t)))
        find-file-hook)
    (funcall orig-fn file)))

Thanks a lot! I performed two measurements (after upgrading doom to the latest version, each done with a freshly started Emacs, each with the options recommended earlier in this thread).

With the defadvice the agenda takes approximately 29 seconds to load. Subsequent calls (without restarting Emacs) take around 2-3 seconds.
Without the defadvice the agenda takes approximately 44 seconds to load. Subsequent calls (without restarting Emacs) take around 3 seconds.

It looks like the defadvice gives me a speed boost of around 30% which is great :slightly_smiling_face: Nevertheless there still seems something to be going on because I do not think that I had to wait for 30 seconds for the agenda to start before I used doom.

Unfortunately, the reported data above is not accurate.
It was run with the default init.el. When commenting out desired modules in init.el the agenda load time is close to 40 s. I haven't found out which modules that cause this. This is with default packages.el and config.el, except for adding the agenda files, i.e., (add-to-list 'org-agenda-files dir).
However, there also seems to be a regression with the default config. Now the subsequent agenda load times are over 5 s.
The size of my agenda files have not grown by any significant size since previous reports.


Migration to graphql-core-v3

Based on @Cito branch as stated at #20 and as part of the refactoring and merge steps discussed at the Slack channel plus #34, this PR aims to make graphql-server compatible with latest graphql-core version.
@jkimbo this one is ready for review!

Ummm, so weird, the re-added tests didn't passed although those did locally.

@jkimbo I have no idea what's going on but removing the @mark.asyncio on the asyncio test will make it pass 🤔


CIF-992 - Decouple searchbar from header component

Description

Created new dedicated searchbar component that displays the search input
Disabled baseline check to allow for extending the Header sling model
Preparation for moving the header component to the archetype

Also see https://github.com/adobe/aem-cif-project-archetype/pull/20.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[X] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[X] All unit tests pass on CircleCi.
[X] I ran all tests locally and they pass.

Codecov Report

Merging #95 into master will decrease coverage by 0.08%.
The diff coverage is 12.5%.

@@             Coverage Diff              @@
##             master      #95      +/-   ##
============================================
- Coverage     65.83%   65.75%   -0.09%
- Complexity      214      215       +1
============================================
  Files            34       35       +1
  Lines          1203     1206       +3
  Branches         84       84
============================================
+ Hits            792      793       +1
- Misses          366      368       +2
  Partials         45       45

Flag
Coverage Δ
Complexity Δ

#karma
93.61% <ø> (ø)
0 <ø> (ø)
:arrow_down:

#unittests
57.25% <12.5%> (-0.08%)
215 <1> (+1)

Impacted Files
Coverage Δ
Complexity Δ

...mponents/internal/models/v1/header/HeaderImpl.java
9.09% <0%> (+1.39%)
1 <0> (ø)
:arrow_down:

...ts/internal/models/v1/searchbar/SearchbarImpl.java
20% <20%> (ø)
1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f84a2...81393ff. Read the comment docs.

@cjelger I added the test.


I have my own custom gpt's in  open ai , and now I want to use it through langchain .I don't want to use gpt 3.5 or gpt 4. I want to use mt custom gpt

I think you mean I want to use my custom gp

You can setup the same by providing the custom instructions


Bugfix for empty MultiFilters with and equals true

Fixes #1032
@codeworrior Could you check this please as I have no way to do it?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Tristan Storch seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Someone should probably right some tests for this. I have currently no clue about tests in Javascript :(

This change has been merged with 753025bda5d76792ca7f7d98fe8b3924d86abe17 but the reference was missing.
Therefore I am now closing this PR.

There was indeed a reference in the commit message, but only a reference to the original issue, not to this pull request :-(

@codeworrior yes, that's what I meant.


A bug in CheckpointHook causes false negatives

I think the globals in self.state.globals.get('globals', None) should be sym_vars. This can make CheckpointHook discard some sym_vars and give false negatives. Could you have a check if there are similar problems?
class CheckpointHook(DefaultHook):
    def run(self, **kwargs):
        assert 'arg_num' in kwargs['kwargs']
        arg_num = kwargs['kwargs']['arg_num']
        if self.state.globals.get('globals', None) is None:
            self.state.globals['sym_vars'] = []
        if arg_num == 0:
            sym_var = claripy.BVS('ret', self.state.arch.bits)
            self.state.globals['sym_vars'].append(sym_var)
            return sym_var

This looks certainly like a typo. Great catch!
Could you create a PR ?