ses: Add ses upload subcommand (SCRD-8432)

The ses upload subcommand can be used to upload yaml file with SES configuration to crowbar.
NOTE there are couple of changes included in this PR which are not strictly related to SES but rather refactoring and/or pre-requisites for actual SES commands.

Backport was not really needed as crowbar-client doesn't have per-release branches. This https://github.com/crowbar/crowbar-client/pull/196 should be enough.


Clean up initialize, especially regarding code without a thread home

We built this with a Model-View-Controller design in mind. Can you write a short description / vision / manifesto that explains how MVC is represented in Elegit?
Some methods or code that initialize calls runs in the Application thread, and sometimes runs in worker threads. This is confusing, and cleaning this up to be more readable would be useful for maintainability going forward.
Perhaps use method naming to help make more clear where something should run?

Calling it good enough for now. Might look at it later, but window pops up quickly and Julia cleaned up code well


Add docstrings to pair_with, pair_right

I'd also suggest to rename pair_with to pair_left.

SG renaming the function, maybe add an alias pair_left (pair_left = pair_with) with a deprecation notice ? (to avoid changing the existing code)

@0xnurl consider closing / merging this


Add installed mods to diagnostics logs

Should be able to do something basic for this when #283 is merged


Wrong aspect

Required Info

Camera Model
{ D455 }

Firmware Version
(<IP_ADDRESS>.50)

Operating System & Version
{Ubuntu 20.04

Kernel Version (Linux Only)
(5.11.0-37-generic)

Platform
PC

SDK Version
master }

Language
{ }

Segment
{others }

Issue Description
Wrong aspect in realsense-viewer

you will see SQUARE as Non-SQUARE

It is realsense-viewer bug of window aspect, not librealsense


New version: GLPK_jll v4.64.0+0

UUID: e8aa6df9-e6ca-548a-97ff-1f85fc5b8b98
Repo: https://github.com/JuliaBinaryWrappers/GLPK_jll.jl.git
Tree: ccc855de74292e478d4278e3a6fdd8212f75e81e
Registrator tree SHA: 62db5e7577558bb878f89c5f5beccc50712c6687

Ref https://github.com/JuliaPackaging/Yggdrasil/pull/686#issuecomment-605754827. The branch was created, but the PR was not opened.  @ViralBShah could you please check that adding GLPK_jll#v4.64 on this branch works?

@giordano Not sure I understand what you want me to do.

The AutoMerge seems to be a permissions issue.

Not sure I understand what you want me to do.

I wanted to know whether
]add<EMAIL_ADDRESS>using GLPK_jll

would work, this is the test that automerge would try to do.  I just found some time to do it myself, I can confirm it works

The AutoMerge seems to be a permissions issue.

I think aumerge works only with pull requests opened by @jlbuild and @JuliaRegistrator

Thanks. I was trying add GLPK_jll#4.64 and that wasn't working, so I wasn't sure if I was missing something.

No, it was my fault :slightly_smiling_face:


no CNAMEs for reverse zones

Hi,
I want to create a CNAME in a reverse zone but I don't have this choice. the only choices I have is PTR,TXT,LOC,NS,SOA.
The reverse zones can have CNAMEs. Could you add this functionality plz?
thanx,
Spiros

Twa, you are roght. My bad.
Thanx


FR/Question: Complete on any key

As hinted in the subject, this might just be a question and something simple that I'm missing.  Since I have noselect enabled, I have to actively select a completion option and intuitively it feels like I should be able to accept a highlighted option with any key that isn't scroll related.
I must have had this expectation ingrained from prior editors, but using <CR> to accept is non-intuitive for me and occasionally leads to unwanted line breaks.  My expected behavior is that after I highlight an option something like space, period, comma, single/double quote, parentheses, brackets, etc. should accept the highlight and add the additional character.
Actually, typing this out makes me realize that maybe the set of next characters is small enough that I can add mappings for them explicitly.  I'll work on that for now but would love if someone slaps me and points me at a simpler solution.

It is hard to understand by long expectation.
I think it should be described by screeshot and examples.

You can use C-y to accept the highlight candidate.
Yes, you can map it to other key to save the accept key.
But it increases your typo easily
(Because I had mapped the key...

Thanks for the quick reply!  Actually C-y works great as it's a nice rhythm to C-n to highlight and C-y to accept then continue.  It feels more natural than CR to me and I'd rather that accept and return.
Thanks again!


Implement Suggestions from User Feedback (week 7)

Summary
From the feedback form made last week, this PR implements suggestions and also documents suggestions that need to be deferred (currently not feasible to implement). In this PR,

[x] Favicons for different devices are added to each existing page
[x] Font sizes are adjusted to be more readable on mobile.
[x] Tooltip to explain purpose of add location button in Trip Editor
[x] Improve trip editor layout (save button position)

(TODO in later PRs)

[ ] Better filters other than price when adding trips
[ ] Upvote/downvote and rank trips network posts
[ ] Demo/images of features of the app in the homepage

Screenshots
(only some easily visible changes shown)

Test Plan
Run a local server of the site and try navigating to different pages. See that the above marked checkboxes have been implemented.

How do I view the favicons?

How do I view the favicons?

Try running a local server on Cloud Shell

Sorry, just got out of a mentor meeting. I wasn't sure where to look for the favicon but now I see it, I like the look!


Add BARAs to CC spec Readme

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

A short explanation of the proposed change:

An explanation of the use cases your change solves

Links to any other associated PRs

[ ] I have reviewed the contributing guide

[ ] I have viewed, signed, and submitted the Contributor License Agreement

[ ] I have made this pull request to the master branch

[ ] I have run all the unit tests using bundle exec rake

[ ] I have run CF Acceptance Tests

Thank you for your valuable contribution. Baras are already in the readme, this is a duplicate.


No module named 'flash_attn_2_cuda'

Error occurred when executing DownloadAndLoadFlorence2Model:
No module named 'flash_attn_2_cuda'
the error happens with all precision settings and all attention settings
(The model is: Florence-2-base)

Never saw that before, but probably due to old transfomers version.

Of course I tried restarting and it didn't work.

I update it to the latest version and yeah, the same error.

Where are you man!

I can't reproduce the error so dunno how I can help.
Are you sure you updated transformers for the portable install specifically?
As in going to the ComfyUI_windows_portable\python_embeded -folder and running:
python.exe -m pip install -U transformers
You can check your current version with:
python.exe -m pip show transformers

Steps to Fix the Error

Uninstall Flash-Attention:

Open your terminal.
Run the following command to uninstall the existing flash-attn package:pip uninstall flash-attn -y

Clone the Flash-Attention Repository:

Use the following command to clone the Flash-Attention repository from GitHub:git clone https://github.com/Dao-AILab/flash-attention.git

Navigate to the Cloned Repository:

Change your current directory to the flash-attention directory using:cd flash-attention

Install Flash-Attention:

Run the following command to install the flash-attn package without build isolation:pip install flash-attn . --no-build-isolation

Following these steps should resolve the error. After completing them, your setup should work without issues.

ip uni

Is there any specific directory I need to run these commands?

Flash attention itself is not needed to run Florence2 as long as you use sdpa or esfwr as attention mode. Make sure everything else is up to date, especially torch and transformers. Never seen the error myself so that's all I have.

Flash attention itself is not needed to run Florence2 as long as you use sdpa or esfwr as attention mode. Make sure everything else is up to date, especially torch and transformers. Never seen the error myself so that's all I have.

Hey Kijai, thank you very much for all your work and for taking the time to reply.
I was wondering if running it in 'flash_attn_2' would improve my performance, but the node is running fine in 'sdpa'.

I didn't notice any real difference myself, it's already so fast.


Better explain AlphaZero (policy moves, P versus MCTS) in readme.md

A next suggestion would be to add additional text on github or in-game on the difference between P-values and evaluation function.

source

Added some more lines to the README.md but don't want to blow up the README with too much background info. Googleing "AlphaZero",  etc. should do the trick :-)


Test sign off for kruize release 0.7

Here are the test scenarios tested with kruize.

Test case
Cluster type
Test Automation Status
Test Status
Comments

Monitor new App using kruize
Docker
Complete
Failed
Test case failure, investigating

OpenShift
Complete
Passed

Minikube
Complete
Passed

ICP
Complete
Failed
#129

Remove an App and verify /recommendations and /listApplications
Docker
Complete
Failed
#114

OpenShift
Complete
Failed
#113, #114

Minikube
Complete
Failed
#113, #114

ICP
Complete
Failed
#129

Monitor multiple applications using kruize
Docker
In progress
Yet to test
Awaiting petclinic benchmark to be checked-in

OpenShift
Complete
Passed

Minikube
Complete
Passed

ICP
Complete
Failed
#129

Monitor multiple instances of an application using kruize
Docker
In progress
Yet to test
Awaiting petclinic benchmark to be checked-in

OpenShift
Complete
Passed

Minikube
Complete
Passed

ICP
Complete
Failed
#129

Multiple kruize instances (Not supported as of now)
Docker / ICP / minikube / openshift
NA
Failed
#118

Validate Kruize recommendations in Grafana Dashboard against values give by Rest APIs
Docker
NA (manual)
Failed
#115 (Fix available, need to verify)

Minikube
NA (manual)
Yet to test

ICP
NA (manual)
Failed
#115 (Fix available, need to verify)

Openshift
NA (manual)
Failed
#112

Stability test to validate kruize recommendations generated are within the acceptable ranges
Docker
Yet to start
Yet to test
Awaiting petclinic benchmark to be checked-in

OpenShift
Yet to start
Yet to test

Minikube
Yet to start
Yet to test

ICP
Yet to start
Yet to test

Validate Kruize API documentation

NA (manual)
Failed
#107 (Fix available, yet to verify

Validate Runtime parameters related doc updates

NA (manual)
Yet to test

@chandrams, the fix for the test case Remove an App and verify /recommendations and /listApplications is already out but not merged yet. Can you please check if that PR fixes the issue?


Fix secrets patch

The secrets code was just tarring and copying the contents of the secrets directory on host as is.
This meant it was not accounting for any symlinks inside the directory, leading up to the contents
not being copied over.
Signed-off-by: umohnani8<EMAIL_ADDRESS>

I had modified the secrets code from cri-o and had not thought about the fact that the contents of the secrets directory could be symlinks pointing to other directories. Huge bug on my part, sorry!
@rhatdan @nalind @TomSweeneyRedHat PTAL
Working up the same fix for podman.

@tchughesiv buildah secrets issue is being fixed here.

Changes LGTM, any tests that we can add/modify to validate the symlink traversal?

@TomSweeneyRedHat yup just modified the test to account for this situation.

LGTM
@rh-atomic-bot r+


Gh1379 change all spark operations to accept spark session

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@dce014a). Click here to learn what that means.
The diff coverage is 48.96%.

@@            Coverage Diff             @@
##             develop    #1385   +/-   ##
==========================================
  Coverage           ?   65.53%
  Complexity         ?     1644
==========================================
  Files              ?      705
  Lines              ?    22798
  Branches           ?     2867
==========================================
  Hits               ?    14941
  Misses             ?     6686
  Partials           ?     1171

Impacted Files
Coverage Δ
Complexity Δ

.../java/uk/gov/gchq/gaffer/spark/SparkConstants.java
50% <ø> (ø)
1 <0> (?)

...hq/gaffer/flink/operation/handler/GafferAdder.java
83.33% <ø> (ø)
0 <0> (?)

.../spark/operation/scalardd/ImportRDDOfElements.java
0% <ø> (ø)
0 <0> (?)

...ark/operation/javardd/ImportJavaRDDOfElements.java
0% <ø> (ø)
0 <0> (?)

.../uk/gov/gchq/gaffer/parquetstore/ParquetStore.java
78.12% <ø> (ø)
0 <0> (?)

...ark/operation/javardd/GetJavaRDDOfAllElements.java
0% <ø> (ø)
0 <0> (?)

.../spark/operation/scalardd/GetRDDOfAllElements.java
36.84% <ø> (ø)
3 <0> (?)

.../spark/operation/javardd/GetJavaRDDOfElements.java
0% <ø> (ø)
0 <0> (?)

...fer/spark/operation/scalardd/GetRDDOfElements.java
37.03% <ø> (ø)
5 <0> (?)

...eration/dataframe/FiltersToOperationConverter.java
68.12% <ø> (ø)
66 <0> (?)

... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dce014a...e5083c0. Read the comment docs.

Rather than always creating a SparkSession, if possible we should do it lazily. If you do a GetElements operation you might not need a spark session so it seems wasteful to add it.
I've refactored the code and pushed it to branch: gh-1379-Change-All-Spark-Operations-to-accept-Spark-Session-lazy. Instead the handlers now just ask the context for a spark session, if one doesn't exist it creates one and adds to back to the context so it can be retrieved again later.
I've raised a separate pull request - https://github.com/gchq/Gaffer/pull/1387
@james010101101 let me know what you think. I'll close this pull request for now, but please reopen it if you don't like my changes.


Class hierarchy mixins

First off, apologies for the radio silence. Things have been quite hectic and I anticipate the next week will be even more so. Hopefully things will clear up afterwards.
I will get around to adding some actual mixins when time permits, but I had an idea that it would be good to be able to add mixins at any level in the class hierarchy to reduce unnecessary duplication. So this PR makes the following changes:

Adds a class_hierarchy module to the library.
Mixins can now be defined for parent classes, with the usual rules applying regarding global mixins for a child class overriding those for a parent.
Also adds a utils module to the library for general (ie not Finale-specific) Lua utility functions (it's a bit sparse at the moment but I'd rather add to it as needed).
Added a couple of missing checks for nil

The class hierarchy can be determined programmatically, so I don't think it should be hard-coded here. You can also programmatically access all the method and property names, if that's needed. There is a slight difference between JW Lua and RGP Lua in how this works.
I've worked out how to do it as part of my work on RGP Lua. Here is sample code:
-- this function should only be called for classnames that start with "FC" or "__FC"
local get_parent_name = function(classname)
    local class = _G.finale[classname]
    if type(class) ~= "table" then return "" end
    if not finenv.IsRGPLua then -- old jw lua
        classt = class.__class
        if classt and classname ~= "__FCBase" then
            classtp = classt.__parent -- this line crashes Finale (in jw lua 0.54) if "__parent" doesn't exist, so we excluded "__FCBase" above, the only class without a parent
            if classtp and type(classtp) == "table" then
                for k, v in pairs(_G.finale) do
                    if type(v) == "table" then
                        if v.__class and v.__class == classtp then
                            return tostring(k)
                        end
                    end
                end
            end
        end
    else
        for k, _ in pairs(class.__parent) do
            return tostring(k)  -- in RGP Lua the v is just a dummy value, and the key is the classname of the parent
        end
    end
    return ""
end

This is not a comment specific to this pull request, but I think mixins would get more traction if they were better documented. A lengthy explanation in the documentation pages (perhaps copied from the original commit of mixins) would be extremely helpful.
Also, I would like to see a fully implemented example, and I think FCCustomWindow (and/or FCCustomLuaWindow) would be a great choice to add to the library. I would convert both of mine to it for sure.

Hmm, I agree that hardcoding is far from ideal but originally when I was testing it out, Finale would crash whenever I tried to access __class.  However, copy-pasting the function that you posted above seems to work fine so I'm not sure what the issue was there. In that case, is it alright if I just replace the hardcoded list with the function you posted?
And yes, I will be adding some proper documentation and examples.

Nice work!
Don't have any other comments than what @rpatters1 said.
Just FYI when it comes to documentation, everything is just a markdown file in the /docs folder. However, everything in the /docs/library folder is automatically generated from the code, so updates you do there will be overwritten. You might have figured all that out already, but letting you know just in case you didn't.

Sure, you are welcome to use my function.
It needs to be programmatic because there are 2 or 3 intentional discrepancies in the hierarchy between JW Lua and RGP Lua. Also, I expect that RGP Lua may be adding new classes in the future.
JW Lua crashes Finale if you try to index a finale class table with a non-existent key. The most likely culprit was __parent but maybe it was another. (There is a note in my routine about that.)
Both JW Lua and RGP Lua use LuaBridge to import classes into Lua, but LuaBridge underwent a lot of changes since JW Lua used it. One of them was removing the easy reflection of classes, methods, and properties. I recreated it with a home-grown version that is somewhat different but basically allows you to get the most of the same information.

I was imagining the documentation would be embedded in the mixin.lua source code itself so that it would automatically be exported to the doc site. I don't know how much control over formatting there is, though.

Just popping in to say I'm still alive. Life just got extraordinarily hectic. I'll be back for sure (with plenty of time to spare) in the 2nd week of February, maybe sooner if I'm lucky.

I've included the function from rpatters1 and changed a couple of other things, including some performance improvements.

This looks good to me. I hope at some point you will add a comment block to the $module section of mixin.lua that gives a detailed description of how to use the library and some use cases for why we might want to. I seem to recall that the original pull request that added it had a fairly good summary that could be used as starting point.
These comment blocks can use a subset of markdown to get formatting on the website. The configuration.lua library file as a fairly detailed comment block that gives an example of what I think would be helpful. The comment block is automatically added to the website when it is merged into master.
Finally, a really nice to have would be a mixin implementation of FCCustomLuaWindow. It is a mess now, and I would be very happy to use that as a starting point for working with mixins.

I do think @rpatters1's thoughts are valid and it would be great to have more documentation explaining why you want to use mix-ins.
However, I'm going to merge this since it looks good and we can add those comments later.


Implement upload file

What
This PR:

Implements the ability to copy file contents from locally to remote using SFTP

Misc
Related to https://github.com/Miyoshi-Ryota/async-ssh2-tokio/issues/14

@Miyoshi-Ryota how does this draft look to you?

@hwrdtm
Comment
Thanks for your work. It's been excellent. There are a few tasks we need to address before releasing. Some you might already be aware of.

Add unit tests.
Fix linter warnings.
Tidy up dependencies.

If possible, I think it's better to avoid using "beta" unless necessary.
Also, specifying just "1" for the Tokio version seems better. Alternatively, consider leaving Tokio as a dev-dependency for now.

If Tokio has been added to dependencies, it's better to use the asynchronous version provided by Tokio rather than std::fs::read.

If you don't have time to write unit tests, etc., I can merge this PR. And I'll take care of these tasks on this weekend.
Question

also use buffers

By the way, what does this sentence mean? Where are the areas for improvement assumed?

Question

also use buffers

By the way, what does this sentence mean? Where are the areas for improvement assumed?

right now we load the entirety of the local file into memory https://github.com/Miyoshi-Ryota/async-ssh2-tokio/pull/59/files#diff-7f93c4e263c4e9ec748f804c7fd04a3b2fde86ffd741fb5516d67e1097bae4c1R275
we should use buffers to avoid overloading the memory space and for a more "streaming" based approach

I completely understood, thanks.

@Miyoshi-Ryota how do I replicate the linter errors? When I run cargo clippy locally everything is fine.

@Miyoshi-Ryota how do I replicate the linter errors? When I run cargo clippy locally everything is fine.

Using rust version as 1.69, rust clippy throws this warnings. is_some_and is already stable after v1.70. So we should fix this CI's lint error by modifying CI environment instead of source code.
% rustup install 1.69
<-snip->
% rustup default 1.69.0-aarch64-apple-darwin
<-snip->
% cargo clippy
<-snip->
error[E0658]: use of unstable library feature 'is_some_and'
   --> /Users/miyoshi/.cargo/registry/src/github.com-1ecc6299db9ec823/russh-sftp-2.0.0-beta.4/src/client/rawsession.rs:242:14
    |
242 |             .is_some_and(|h| self.handles >= Wrapping(h))
    |              ^^^^^^^^^^^
    |
    = note: see issue #93050 <https://github.com/rust-lang/rust/issues/93050> for more information

Updating super-linter may lead new lint errors. I accept just disabling it for now.
        env:
          VALIDATE_SHELL_SHFMT: false
          VALIDATE_CHECKOV: false

If possible, I think it's better to avoid using "beta" unless necessary.

The russh_sftp::client mod seems to only be introduced in the recent beta versions though :/

Also, specifying just "1" for the Tokio version seems better.

Would you mind explaining why this is better?

@hwrdtm

The russh_sftp::client mod seems to only be introduced in the recent beta versions though :/

Ok, I understood.

Would you mind explaining why this is better?

specifying "tokio=1" provides a more flexible choice of tokio version for the library user.

specifying tokio="1" allows tokio version over v1.0.0
specifying tokio="1.14.0" allows the tokio version over v1.14.0.

...However, russh specifies tokio="1.17.0". So specifying tokio=1 and tokio=1.14.0 leads completely same result that 1.17.0 or higher tokio is only acceptable to build my crates. So, I leave the decision of tokio=1 or 1.14.0 to you.

@hwrdtm
I've released your work as version 0.8.9. I'm sorry to late release.

@hwrdtm
I've released your work as version 0.8.9. I'm sorry to late release.

Thank you!


Introduce System.Systemd.Daemon.Fd

This is the PR concerning #7.
This PR introduces a new module System.Systemd.Daemon.Fd which implements all Socket-related functionality purely using Fds from System.Posix.Types. This allows for low-level IO and usage of different socket libraries than network.
System.Systemd.Daemon now uses the Fd-module internally to minimize code duplication, all shared code is located in the new (hidden) System.Systemd.Internal module.
Excited to hear what you think about this change!
(Note that I have already bumped the version number to 2.1.0 in the commit)

Sorry to bother you, but any news on this?

Hello,
I completely forgot about it, thanks for the reminder.
I will check that this evening

Thanks :)


Remove sub-expressions from parsing error

This PR skips printing sub-expressions in the error message.
This should avoid situations where the error message contains an AST with unreadable characters, as shown here.

@BurntSushi This PR is a follow up to our recent discussion on regex-syntax error messages.
It is intended to be a temporary workaround until we can have a better regex parser/pretty printer.

I went through all the errors and didn't see other instances that try to print out sub-expressions.

The build is failing on beta and nightly for reasons unrelated to these changes.

@andrea-prearo Right, yeah, I'll submit a PR when I get a chance fixing that.

@BurntSushi Sounds good. Thanks!

@andrea-prearo Could you rebase this on master? That should hopefully get CI passing!

@BurntSushi I had some issues with the rebase, so I had to do some clean up. But tests are passing now!

@andrea-prearo Thanks! @bors r+

:pushpin: Commit ba5a3df has been approved by BurntSushi

:hourglass: Testing commit ba5a3df264a03d3a76b77faa7582e65d1069e808 with merge 72cee88cf46d3dc91d8dddd9dd1ca6a258c32e36...

:sunny: Test successful - status-appveyor, status-travis
Approved by: BurntSushi
Pushing 72cee88cf46d3dc91d8dddd9dd1ca6a258c32e36 to master...


When using FSCalendar through SwiftPM you get warning about version not supported

The following informations are requested in a bug report

When you use FSCalendar through sSwiftPM with latest xcode 12.2 or 12.3 you have warning saying:
The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.3.99.
Integration method.(SwiftPM)
Integrate FSCalendar through SwiftPM
Xcode version.  Xcode 12.x
FSCalendar version. FSCalendar 2.8.2

This is easy to fix, just update the Package.swift with
platforms: [.iOS(.v9)],

Can you submit a PR for your solution?

Can you submit a PR for your solution?

Sure, I make a PR 👍

Thank you @MapaX. I'm looking forward to this fix.

Thank you @MapaX. I'm looking forward to this fix.


Add welcome cog and many other fixes

Fixes #45
Fixes #69
Requires #65 to be merged first
Changes:

Adds the ability to set the member, guest, mute, and jail roles persistently.
!specroles/!sroles lists them. !setmember, !setguest, !setmute, !setjail for setting them.
Adds the !welcome (aliased to !wlm) command group, with commands for configuring agreement.
!wlm getchan for getting the welcome channel, !wlm setchan/!wlm unsetchan for removing it.
Adds !agree. Can only be called in the welcome channel.
Auto-applies guest role on join if configured. Removes on agree.
Applies member role on agree if configured.
Adds welcome, goodbye, and agree messages.
!wlm getmsg to list them. !wlm welcomemsg/goodbyemsg/agreemsg to set.
!wlm format to list available formatting options for custom messages. In python .format() style (e.g. Welcome {mention}!)
Fixes issue with member leaving events, tracker cog properly determining the cause
Adds moderation journal listener to handle those events
Determines message deletion cause and adds to journal event

Known issues:

Journal channel output outputs twice as many joined/left events. Because it might be related to pending PRs it is not going to be fixed for now.

@Ma-wa-re ready for review


Remove net.peer.port,net.peer.ip and net.peer.name from server metrics

Only add parseAddress attributes if the isClient flag is true.
If it is a Cllient interceptor then these will have relatively low cardinality: net.peer.port would be the port the server is listening on (8080 or 443 for example). net.peer.ip would be the ip address of the server (again, low cardinality). net.peer.name would also be the server name (api.buf.build).

That simplifies it a lot

This can be a follow-up PR, but we should note this in our README.

net.peer.ip seems reasonable to drop, I can't find that in the spec anywhere either.
net.peer.port is conditionally required (when not 80 or 443) so I suspect it's fine to include conditionally. It's effectively a constant.
net.peer.name seems like it should be stable, given it's usually a hostname and perhaps rarely a hard-coded IP address. Effectively a constant.
The spec makes some reasonable recommendations IMO: https://opentelemetry.io/docs/reference/specification/metrics/semantic_conventions/rpc-metrics/#attributes
I think perhaps there is some confusion around local IPs and ports, which don't seem like they would be relevant in most scenarios.

Yeah so I've been chatting with @doriable and I am going to:

Remove the server attributes for net.peer.port net.peer.ip and net.peer.name
Keep them in for Clients
This way it's lower cardinality but it still conforms to the spec 👍

I don't see any reason why net.peer.port and net.peer.name would have higher cardinality on the server -- they're effectively constant for the lifetime of the server, and likely constant across instances as well. If anything the client cardinality seems like it would be higher if a client interacted with many remotes.

I missed the part about net.peer.port being optional for the server, as "it describes the port the client is connecting from" -- reasonable to omit from the server indeed.

OK, here's my understanding of the situation.
OpenTelemetry Specification
First, the OpenTelemetry specification asks for the following (from the RPC metrics semantic conventions and the RPC span semantic conventions):

net.peer.name: RPC server host name (e.g., example.com). May contain server IP address, DNS name, or local socket name. If the host is an IP address, instrumentations should not do a reverse proxy lookup to obtain DNS name and should set net.peer.name to the IP address provided in the host component. Required.
net.peer.port: Logical remote port number (e.g., 80, 8080, 443). Required if different than net.peer.name and if net.sock.peer.addr is set.
net.sock.peer.addr: Remote socket peer address: IPv4 or IPv6 for internet protocols, path for local communication, etc.
net.peer.ip: doesn't appear at all. (I think I may have pulled this from the OpenTracing specification somehow?)
At least one of net.peer.name and net.sock.peer.addr is required.

To avoid high cardinality, implementations should prefer the most stable of net.peer.name or net.sock.peer.addr, depending on expected deployment profile. For many cloud applications, this is likely net.peer.name as names can be recycled even across re-instantiation of a server with a different ip.
For client-side metrics net.peer.port is required if the connection is IP-based and the port is available (it describes the server port they are connecting to). For server-side spans net.peer.port is optional (it describes the port the client is connecting from). Furthermore, setting net.transport is required for non-IP connection like named pipe bindings.

connect.Peer
Second, here's the information we actually have available from net/http, laundered through connect.Peer:

Handler: peer address in IP:port format.
Client: host and port portion of server URL, in host:port or IP:port format (depending on the baseURL the client used to configure the HTTP client).

Plan: Handlers
We should set net.peer.name and net.peer.port to the remote IP address and port.
This follows the specification, but seems likely to be very high cardinality. It would be somewhat better if we knew the client's hostname instead of using an IP, but I can't imagine how any server would get that information without a reverse DNS lookup. Maybe we could get it from the client certificate in an mTLS handshake? Internally, I expect that we'll want to drop these tags.
Since many users will probably also want to drop this information, we should expose an option to not emit these tags at all.
Plan: Clients
We should set net.peer.name and net.peer.port to the remote host/IP and port. In many use cases, this should be relatively low-cardinality, because I expect that most users will be using URLs like https://demo.connect.build:443/some.Service/Method.
Anyone using URLs with explicit IPs, or ports that change relatively often, is in for a lot of pain. For symmetry with handlers, I think it's probably fine to expose an option to suppress these tags.
What next?
If everyone agrees, I'll open a PR to implement this plan and update the docs. I'd like a thumbs-up from @joshcarp, @doriable, and @lrewega at least, though anyone else is welcome to chime in.

Wait for this PR. High cardinality is continously causing OOM

Closing because https://github.com/bufbuild/connect-opentelemetry-go/pull/41 allows the same thing to be acomplished


Update Arrays.md

Update

Hi, Please read the Important Announcement.
PR can only be made after the issue is assigned to you.


Add profile

Hackathon Git Labs Project PR 🎉🎉
👉 Please remove the below and replace with your own values, leaving the headers where they are. 👈
PR contains:
I added my profile
Breaking changes
None
Screenshots
None

Looks good!


extension API: select source control provider on the list

It would be useful to have more control over built-in source control providers list, because sometimes it is unclear, which repository will end up being selected :)
Source control providers list seems to remember last selected repository on the reload, unless the list is actually opened during the vscode initialization - in which case, for some reason there are two repositories selected (last selected and first one).
Allowing to select them through API would allow for more integration between extensions and built-in git functionalities.

We're trying to get away from the SCM Providers list and the notion of a single selected repository, so this would lock us in even more. Closing it as out of scope.


Memory & CPU Limits

It might be helpful to specify CPU/Memory requests for our rethink nodes.  If we do so, we should be sure to tell RethinkDB the amount of cache size it has to play with.
https://rethinkdb.com/docs/memory-usage/
--cache-size 2048

https://github.com/rethinkdb/rethinkdb/issues/5498

This would be good, The cache-size gave me a bit of an issue as it ate up my entire 60 gigs of ram.

Implemented in 6f996aa962a45e76d98d64e364e5867826b737a3


[Bug fix] @autobind and @mixin decorators should be able to handle ES6 Symbols

Greets,
Writing my own project I found, it is not possible to use autobind and mixin decorators with Symbols beside.
This should works out of the box, since whole logic is already done in core-decorators' internals, but due to not enumerable nature of Symbols, it is not possible to iterate over them using for in construction (Object.keys() also doesn't work for those). Both, mixin and autobindshouldn't really care if something is enumerable or not.
Cheers!

By they way. I found why build for node 0.10 doesn't work.
I know that it is easy to say, but for this particular case, it is internal bug of node.
As you can see this test doesn't pass, but check the message:
  1) @mixin correctly adds symbols:
     TypeError: Property 'Symbol(mixin)_k.208j4grh3bdtpgb9' of object [object Object] is not a function
      at Context.<anonymous> (test/unit/mixin.spec.js:75:20)

After some investigation I've found that node is going crazy when you try to use in operator to check, if some property is already somewhere in prototype chain of given object.
Here is an example:
const hash = Symbol('hash');
function A() {}
A.prototype = {};

console.log('Node goes crazy? ', hash in A.prototype ? 'YES' : 'NO'); // -> 'Node goes crazy? YES'

class B() {}

console.log('Node goes crazy? ', hash in B.prototype ? 'YES' : 'NO'); // -> 'Node goes crazy? YES'

Eventually, the final answer, why does it matter?
function handleClass(target, mixins) {
  ...
    for (const [key, desc] of descs) {
      if (!(key in target.prototype)) { // <-- viola, this is the case...
        defineProperty(target.prototype, key, desc);
      }
    }
  ...
}

Using this test case:
  it('correctly adds symbols', function () {
    const symbolHash = Symbol('mixin');
    const SymbolMixin = {
      [symbolHash]() {
        return 'symbolHash';
      }
    };
    class A {}
    class B extends A {}
    @mixin(SymbolMixin) class F extends B {} // extends are only to show the issue
    const foo = new F();

    foo[symbolHash]().should.equal('symbolHash');
  });

And this test code:
// src/mixin.js
function handleClass(target, mixins) {
  ...
    if (!(hasProperty(key, target.prototype))) {
  ...
}

const isNodeBuggy = function() {
  const foo = Symbol('foo');
  class Foo {}
  return foo in Foo.prototype
}();

const {getOwnPropertySymbols, getPrototypeOf} = Object;

function hasProperty(prop, obj) {
  // Node in version 0.10 treats type of Symbol as "object" instead of "symbol".
  const type = typeof(prop);
  if (isNodeBuggy && (type === 'symbol' || type === 'object')) {
    do {
      console.log('Constructor: ', obj.constructor.name);
      console.log('Own symbols: \n', getOwnPropertySymbols(obj));
      console.log('Needed symbol: ', prop);
      console.log('Has one: ', obj.hasOwnProperty(prop));
      console.log('Is this Object.prototype: ', obj === Object.prototype);
      console.log('Going down the chain...');
      console.log('\n');
      if (obj === Object.prototype) {
        return false; // If we arrived to the last prototype, we can be sure
                      // that there is no needed symbol in chain...
                      // Because due to the node.js bug, every symbol is stored
                      // in Object.prototype
      }
      if (obj.hasOwnProperty(prop)) {
        return true;
      }
    } while (obj = getPrototypeOf(obj));
    return false;
  } else {
    return prop in obj;
  }
}

We will receive such results:
Constructor:  F
Own symbols:
 []
Needed symbol:  { _k: 'Symbol(mixin)_l.z1hvj9oxhn34bo6r' }
Has one:  false
Is this Object.prototype:  false
Going down the chain...

Constructor:  B
Own symbols:
 []
Needed symbol:  { _k: 'Symbol(mixin)_l.z1hvj9oxhn34bo6r' }
Has one:  false
Is this Object.prototype:  false
Going down the chain...

Constructor:  A
Own symbols:
 []
Needed symbol:  { _k: 'Symbol(mixin)_l.z1hvj9oxhn34bo6r' }
Has one:  false
Is this Object.prototype:  false
Going down the chain...

Constructor:  Object
Own symbols:
 [ { _k: 'Symbol()_f.z1hvj9oxhn34bo6r' },
  { _k: 'Symbol(__core_decorators__)_i.z1hvj9oxhn34bo6r' },
  { _k: 'Symbol(foo)_j.z1hvj9oxhn34bo6r' },
  { _k: 'Symbol(park)_k.z1hvj9oxhn34bo6r' },
  { _k: 'Symbol(mixin)_l.z1hvj9oxhn34bo6r' } ]
Needed symbol:  { _k: 'Symbol(mixin)_l.z1hvj9oxhn34bo6r' }
Has one:  true
Is this Object.prototype:  true

So @jayphelps, the question is if we should add fallback support for node in version 0.10 as shown above?

I'm confused why we would hit this anymore since this PR moves away from for..in to for..of?

We don't really have to hit it anymore.
I've only noticed, that there is build check for node.js in version 0.10, so I thought that support for this particular version is somehow important.
Also, tests that fails every build check is not something to expect, and that's why I'm asking you:

If I should add exception in that test case when bug is available,
or just delete that test case,
or just add fallback support that makes it work on older node version,
or just remove build checks for node in version 0.10.

It's only testing 0.10 because I've haven't updated it in forever. It's never failed before because of this, so that's why I'm confused; if it started failing in this PR because of adding symbol support + for..in, but now you've switched to for..of, I'm not seeing why it should continue to fail/be an issue?

It's failing because I've added test case for mixing symbols. It wasn't tested before, thus it didn't fail.
And because of that test case failing I found, there is a bug in node.js version 0.10 which is responsible for that.
To be more specific about that node bug:

Node is treating Symbol type as "object" instead of "symbol" which is not met with documentation.
When you declare Symbol like const hash = Symbol('hash');, it will be added automatically (and magically) to Object's prototype (although it shouldn't).
Because every constructor/class in JavaScript inherits prototype of Object (see point 2) by default, then automatically every instance of object-derived construction like: class Foo {} will have access to Symbols in Object.prototype (see point 2).
Because of point 3, checks like key in target.prototype (which is for example here) will be always true, because in operator traverses prototype chain until it reaches Object.prototype.
Because of point 4, and in relation to this, mixin decorator will never ever mix in any Symbol to target prototype in node.js version 0.10.
Implication of point 5 is that test case is failing because it cannot find function under symbol hash property (undefined is returned instead of function), thus build check fails:

  1) @mixin correctly adds symbols:
     TypeError: Property 'Symbol(mixin)_k.7jz70naz5yfa8aor' of object [object Object] is not a function
      at Context.<anonymous> (test/unit/mixin.spec.js:75:20)

I made more detailed investigation, and it turned out node in version 0.10 does not support ES6 Symbols at all.
It means, described above bug is related to ES6 Symbol polyfill provided by Babel 5.
I've added support for such edge cases in latest commit. Now, decorators are working fine, also, build checks are not failing :+1:.

I've created an issue on babel's bug tracker about that symbol bug, and received an answer that they unfortunately will not fix it. So I think it's good idea to have support for it just in case.
Here is a link to that issue: https://phabricator.babeljs.io/T7357

Thanks for all your hard work!!

Feel welcome and thanks to you too for fast responses and involvement.

Do you have any idea when there will be release with this fix? Is there any release procedure?

@kkwiatkowski Yeah, the official procedure is to bug me if I forget haha whoops!
Published just now as v0.12.3.

on React Native android it causes a red screen related to Symbol. see https://github.com/yelouafi/redux-saga/issues/54


Icon Type

[ ] Folder
[X] File

Folder names
No response
File names
*.slx
Graphic ideas
Here's the basic idea!

Additional context
With the development of the MATLAB for VS Code extension, MATLAB development is increasingly moving towards VS code. Adding this icon anticipates when .slx files will be better supported.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Closed in #2678

Closed in #2678

Hint: use "Closes #XXXX" in the PR description, where "#XXXX" is the issue number that should be automatically closed after merging the PR


Fix logic for estimated action

https://microbit-global.monday.com/boards/1356069004/pulses/1356430253

Preview: https://estimated-action-bug.ml-trainer.pages.dev/


Add CommonAggregator tests to LogEventAggregator

The CommonAggregator tests are not yet included with the LogEventAggregator. Let's add them before GA.
Created a ticket for this because:

Our current team isn't familiar with this suite
When putting the below helper code into the LogEventAggregator tests, there were failures around priority sampling.

Possible helper code:
# tests/new_relic/agent/log_event_aggregator.rb
require File.expand_path(File.join(File.dirname(__FILE__), '..', 'common_aggregator_tests'))

#... rest of setup for tests

# Helpers for CommonAggregatorTests

def generate_event(name = 'A log message', options = {})
  @aggregator.record(name, "DEBUG")
end

def last_events
  aggregator.harvest![1]
end

def aggregator
  @aggregator
end

def name_for(event)
  event[1]["message"]
end

include NewRelic::CommonAggregatorTests

Please add your planning poker estimate with ZenHub @tannalynn

@fallwith - Please add your planning poker estimate! :)

Please add your planning poker estimate with ZenHub @fallwith


Combine and add expression tree restrictions

Contributes to #36356
One of the new compiler errors added for collection expressions is that collection expressions are not allowed in expression trees.
There are many features in the language that can't be used in expression trees. While adding this new error create a page to handle all the expression tree restrictions.

Internal previews

📄 File
🔗 Preview link

docs/csharp/language-reference/compiler-messages/expression-tree-restrictions.md
Resolve errors and warnings generated from expressions prohibited in expression trees

docs/csharp/language-reference/compiler-messages/lambda-expression-errors.md
Lambda expression warnings

docs/csharp/misc/sorry-we-don-t-have-specifics-on-this-csharp-error.md
Sorry, we don't have specifics on this C# error

ping @adegeo for review


Determine if G2_searchByAttributesV3() can be used

In
https://github.com/senzing-garage/sz-sdk-go-core/blob/01ca61a38728c66b48c059a06ec6a4e8d6cde05b/szengine/szengine.go#L1281-L1285
Determine if the call to searchByAttributesV2 can be replaced by searchByAttributesV3, thus removing the if/else contition

In researching,  a call to searchByAttributesV3 with a zero length searchProfile behaves the same as searchByAttributesV2,  so
https://github.com/senzing-garage/sz-sdk-go-core/blob/01ca61a38728c66b48c059a06ec6a4e8d6cde05b/szengine/szengine.go#L1281-L1285
can be simplified to
 	result, err = client.searchByAttributesV3(ctx, attributes, searchProfile, flags)

Fixed via https://github.com/senzing-garage/sz-sdk-go-core/issues/232


feat: day aspect ratio

Hi  @casvanluijtelaar  , thank you for this cool library. I took the chance to add a new aspect ratio parameter for each day, so that there is room to display more text if necessary.
Let me know if everything is ok. Thanks!

available in 1.1.9


Update CI Image To Ubuntu 20.04

According to this link, ubuntu 18.04 image will be deprecated at 12-1-22, so we should update our ci image before the day.

Closed by #621.


Consider using dotnet-bot for opening release/2.* merge PRs

It knows how to do it, let's use the feature.
Would be cool if it can also assign everyone involved (everyone who has PR unmerged).
The huge advantage is that it would make things visible and harder to forget to merge.
Example: https://github.com/dotnet/sdk/pull/2137
/cc @mkArtakMSFT @natemcmaster  @ryanbrandenburg

This is super useful for any time our workflow includes merging a release branch back into dev. The script we use to branch insists (rightly so) on release/2.1 not having any commits that dev doesn't. If we use this method then the person who made the commit, who already has context on this change, will do the merge before it becomes an issue rather than me, with no context, trying to throw it in while we branch.

This was done. See https://github.com/dotnet/arcade/pull/483.


fix datetime picker timestamps

datetime pickers currently take the local timestamp as a UTC one, which may results in a different time picked

useful links:
https://mui.com/x/react-date-pickers/getting-started/
https://codesandbox.io/s/jinjuh?file=/demo.tsx


Release 2.0.2

PR to propose releasing v2.0.2, with the new handwritten parser.
If there is any reason to think the new implementation might return different results than the old, generated parser, we should bump SemVer major instead, and perhaps do a 3.0.0-pre.1.

Since there were not many tests in spdx-expression-parse but other packages like spdx-correct contain a lot of tests, it is probably a good idea to test those with<EMAIL_ADDRESS>before publishing it (npm link?).

I have doubts about parentheses. I just opened #20.

I've just run the spdx-correct and validate-npm-package-license test suites with proposed 2.0.2. All tests pass.

@motet-a, would you like to register motet-a on npmjs.com? I will give you publish permissions on the package.

@kemitchell Done.

I've added you as a "contributor". You can publish with npm publish.
I'll continue to open pull requests for significant releases going forward. Do what you think best. If you have questions, don't be afraid to ask, publicly or privately.


[ML][Pipelines] fix: support data binding expression for limits.timeout

Description

handle the case that timeout is not provided
handle the case to load data-binding expression in timeout by removing redundant RestCommandJobLimits.from_dict, which will fail when trying to load data-binding expression as iso time

All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-ml


Feature request: Template Including

Thus front-end generated template layout/snippet can be integrated directly.

Any progress here? I need template components too.

Any progress here? I need template components too.


Misaligned editor cursor movement with Hangul Jamo characters

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.87.2
OS Version: Windows 11 23H2 22631.3296

[!note]
(updated 2024-03-18)
It turns out the majority of described problem below was not from VSCode's bug.
It was VSCodeVim to blame. Sorry for misinformation.
Korean with Hangul Jamo still has problem tho.

Steps to Reproduce:

Example text
Ｔｈｅ　ｑｕｉｃｋ　ｂｒｏｗｎ　ｆｏｘ　ｊｕｍｐｓ　ｏｖｅｒ　ａ　ｌａｚｙ　ｄｏｇ．　ｔｈｅ　ｑｕｉｃｋ　ｂｒｏｗｎ　ｆｏｘ
The quick brown fox jumps over a lazy dog. The quick brown fox jumps over a lazy dog. The quick brown fox jumps over a lazy dog.
とりなくこゑす / ゆめさませ / みよあけわたる / ひんがしを / そらいろはえて / おきつへに / ほふねむれゐぬ / もやのうち
Victor jagt zwölf Boxkämpfer quer über den großen Sylter Deich Victor jagt zwölf Boxkämpfer quer über den großen Sylter Deich
정 참판 양반댁 규수 큰 교자 타고 혼례 치른 날. 정 참판 양반댁 규수 큰 교자 타고 혼례 치른 날. 정 참판 양반댁 규수 큰 교자 타고 혼례 치른 날.
정 참판 양반댁 규수 큰 교자 타고 혼례 치른 날. 정 참판 양반댁 규수 큰 교자 타고 혼례 치른 날. 정 참판 양반댁 규수 큰 교자 타고 혼례 치른 날.
เป็นมนุษย์สุดประเสริฐเลิศคุณค่า กว่าบรรดาฝูงสัตว์เดรัจฉาน จงฝ่าฟันพัฒนาวิชาการ อย่าล้างผลาญฤๅเข่นฆ่าบีฑาใคร ไม่ถือโทษโกรธแช่งซัดฮึดฮัดด่า
鉴于对人类家庭所有成员的固有尊严及其平等的和不移的权利的承认，乃是世界自由、正义与和平的基础。鉴于对人类家庭所有成员的固有尊严及其平等的
鑑於人類社會個成員儕有個固有尊嚴脫仔平等個脫仔勿移個權利承認，是世界自由、正義脫仔和平個基礎。鑑於人類社會個成員儕有個固有尊嚴脫仔平等個

Each line of string is consist of characters used in

English, with full-width latin characters
English, with half-width latin characters
Japanese
German
Korean, with Hangul Syllables Unicode block characters
Korean, with Hangul Jamo Unicode block characters
Thai
Mandarin, simplified
Mandarin, traditional

respectively.
Note that for Thai and Hangul Jamo characters, some groups of Unicode characters can be combined to compose single displayed character.

Fonts used to create sample images
NeoDunggeunmo for latin and korean glyph
GNU Unifont for fallback.
Both are 8x16 grid bitmap based monospace font, so glyphs are perfectly aligned.
(I think this will be reproducible just with Unifont.)

Steps

Click left side of the first occuring of full-width character ａ to put cursor.
Press up and down arrow key to move cursor up and down respectively.

Expected behavior

Cursor moves vertically, without horizontal movement, follwing marked line on image.

Current behavior

Cursor bumps horizontally while moves vertically, ignoring character width and combination.

Sorry for huge misinformation.
VSCodeVim was not properly disabled during testing. Major fault for this problem was on VSCodeVim.
Everything works as intended EXCEPT for "Korean with Hangul Jamo", as of my reproduction.

Record of current behavior, with extensions properly disabled

You can see that the cursor clearly bumps on Hangul Jamo line.

The width of the glyphs is 100% controlled by the font. Have you tried a font like Inconsolata which is known for making all glyphs equallly wide?

The glyphs of fonts I used in that reproduction are "uniformly" wide.
More specifically, every "full-width" glyphs like CJK has exactly double the width of "half-width" glyph.
(It's monospaced by design, but not technically. CJK programming fonts are usually behave like that.)
And VSCode simply consider full-width characters as "double sized" while calculating vertical movement.
You can test that behavior with fonts like Last Resort, which is special purpose fallback font to indicate what Unicode block the "tofu"ed character is in, and has "equally" sized square box glyphs across every possible Unicode code point.

With the font, the example text looks like this. highlighted characters are in the same "VSCode vertical line".
And as you can see, unlike Hangul Syllables(5th line), Hangul Jamo(6th line) seems to be considered as "half-width", by the fact that it's in the same "Displayed vertical line" with "half-width" characters like English, German and Thai.

And VSCode simply consider full-width characters as "double sized" while calculating vertical movement

That is correct, that is the current implementation. With the current stack we have, we delegate font rendering in the editor to the browser, so we don't implement text layouting ourselves. To make true width based vertical movement we would need to basically render the line the cursor would land on and do an offset search to find out what would be the closest column to the current horizontal offset. The current implementation hard-codes a heuristic that wide characters are twice as wide as narrow ones. This is done at https://github.com/microsoft/vscode/blob/0a417782b1781d39803b8f1791cfb22f8835ddae/src/vs/editor/common/core/cursorColumns.ts#L37-L55 and at https://github.com/microsoft/vscode/blob/0a417782b1781d39803b8f1791cfb22f8835ddae/src/vs/editor/common/core/cursorColumns.ts#L27-L35
Because of this, the current implementation also does not work correctly for proportional fonts. I acknowledge this behavior but will mark this as a feature request because the code is working as it was built, allowing for quick vertical movement while sacrificing correctness for non-monospace fonts or mostly non-programming text content.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

I don't meant about "move cursor vertically according to actual glyph size of current font" thing.
It's that the Hangul Jamo block characters are not considered full width despite it is.

@ruby3141 This is defined here -- https://github.com/microsoft/vscode/blob/d8abddce40aee62b166cbdc279e5c60fd9ec4fbf/src/vs/base/common/strings.ts#L677-L721 . Would you be interested in improving that with a PR?


shift select in file tree

on macos, shift+click to select a range of files (compare to cmd+click to add files to selection one-by-one)

requested by @MehrotraRahul


Feature request: "automatic

I guess this is a "duplicate" of the next issue :D ... that's really odd


multiball won't kick out new ball

@jabdoa2 I saw this tonight, but I need to go to bed and didn't want to waste a day before checking with you. Attached is a log, and towards the end of it I started a mode called jukebox_two_ball that starts a multiball after the main jukebox mode is completed. The mode starts, shows run, everything seems normal, but the game doesn't launch another ball.
I believe the mode config is untouched since Expo (the "Multiball:" section looks right, anyway), and that this problem appeared around the time I switched to 0.33. I'm wondering if this doesn't have something to do with the ball controller stuff we saw a few weeks ago.
The log not verbose, but event_manager logging is set to full. I can turn verbose back on if you need it, but I was getting some serious lag while testing other things and turned it off.
jukebox multiball doesn't kick out new ball - MPF.log.zip
Mode config file is below:
#config_version=4
mode:
  priority: 600
  start_events: start_jukebox_two_ball
  stop_events: multiball_jukebox_two_ball_ended

event_player:
  mode_jukebox_two_ball_started:
    fade_out_base_music
  mode_jukebox_two_ball_stopping:
    fade_in_base_music

multiballs:
  jukebox_two_ball:
    ball_count: 2
    shoot_again: 5s
    start_events: mode_jukebox_two_ball_started

slide_player:
  mode_jukebox_two_ball_started:
    multiball:
      expire: 3s

slides:
  multiball:
    widgets:
      - type: text
        text: MULTIBALL
        expire: 2s
        style: dmd_huge
  ball_saved:
    widgets:
      - type: text
        text: BALL SAVED!
        expire: 2s
        style: dmd_huge

show_player:
  mode_jukebox_two_ball_started:
    jb_play_bnd_song:
      key: jb_active_video
    flash_jukebox:
      action: play

shows:
  jb_play_bnd_song:
    - duration: -1
      slides:
        jb_play_bnd_song:
          widgets:
          - type: video
            video: jb_hard_workin_man
            end_behavior: loop
            control_events:
              - event: stop_song
                action: stop
          target: stage

Regression from eba69f1edefea197d8a083997f5f1d61ebf27c93. We need explicit order for events here (see: https://github.com/missionpinball/mpf/issues/643). In your case we call start before enable and, therefore, the multiball does not start.

All set.


Upgrade to babel 6 and streamline 2.0

Travis test fails because of a bug in babel-preset-es2015 dependenc (typo in babel regenerator transform). Bug has been fixed but fix has not been released yet. Unit tests are ok with the fix. So I'm merging.


images capped to 1000 per one download, how to get the rest if there's more?

So I intended to grab 1800 pics from gelbooru but it only got 1000, and it doesnt download the rest. I tried changing the value under the column "images per page" to 2000 and clicked download but all it did is just verify that that thousand indeed has been successfully acquired, how do I get the rest? is there something in the settings i need to toggle? please help out

Have you waited until the end of the download?
Grabber downloads images by groups of 1000 to avoid using too much RAM, so in your case it might first download 1000 then the remaining 800.

Have you waited until the end of the download?
Grabber downloads images by groups of 1000 to avoid using too much RAM, so in your case it might first download 1000 then the remaining 800.

I did and it just stopped there that's it, is there a way to somehow manually select those remaining 800?

If there are only 1800 images for that specific search, you can click "get all" which should pull them all down.

If there are only 1800 images for that specific search, you can click "get all" which should pull them all down.

are you mentally handicapped or just don't care that much? My problem's exactly that doesn pull them all down

If there are only 1800 images for that specific search, you can click "get all" which should pull them all down.

are you mentally handicapped or just don't care that much? My problem's exactly that doesn pull them all down

Just trying to help. Do you have a screenshot of the downloads columns? What are you trying to search for? I can test it on my side to see if I get the same issue.

If there are only 1800 images for that specific search, you can click "get all" which should pull them all down.

are you mentally handicapped or just don't care that much? My problem's exactly that doesn pull them all down

Just trying to help. Do you have a screenshot of the downloads columns? What are you trying to search for? I can test it on my side to see if I get the same issue.

test away then, put on your download queue quantity of any images that exceed one thousand from gelboorudotcome and tell me if it got all of them or only a thousand, I assume that's it something with my settings or the program is in need of an update

If there are only 1800 images for that specific search, you can click "get all" which should pull them all down.

are you mentally handicapped or just don't care that much? My problem's exactly that doesn pull them all down

Just trying to help. Do you have a screenshot of the downloads columns? What are you trying to search for? I can test it on my side to see if I get the same issue.

test away then, put on your download queue quantity of any images that exceed one thousand from gelboorudotcome and tell me if it got all of them or only a thousand, I assume that's it something with my settings or the program is in need of an update

Just did a quick test and it downloaded the first 1000 images without an issue and then continued

Does your log get stuck at "Downloading/parsing page"?

I also haven't had any issues downloading >1,000 images on Gelbooru:

So it either comes from your settings or the particular download you're trying to do @Timurama. Maybe you can share your IGL and log as a starting point? 🙂
PS: please watch your language, everyone here is trying to help.

I tried clicking "get all" and nothing happens for me. The number of images a search I did was around 1.5k, yet nothing's popping up. It's the first time I tried with "get all", "get this page", and I don't know how to select to "get selected". Any help I can get?


Time Command

TODO:

[ ] Limit to staff channels.
[ ] Refine error handling.
[ ] Refine timezone disambiguation prompts.
[ ] Add common timezone command for seeing a set or current time for multiple members and yourself

Hello @scragly, what's the status of this feature?
Will you be continuing it?
Thanks!

Hello @scragly, what's the status of this feature?
Will you be continuing it?
Thanks!

Yes

Yes

Hey @scragly, I hope you're doing well.
Just checking up on this PR since it's been a couple months. How goes it?

With the new time formats and utilities, there may be some major rewriting needed for this PR.
If you do resume this, please feel free to re-open.


Flash programming errors out on a colorlight i5 development board

When I run various ecpdap flash commands, I always get an error. Sometimes the command still works, but flashing itself does not.
Results for different options:
id:
tom@thinkcenter:~/projects/spdif_pmod/fpga/colorlight_i5$ ~/Downloads/ecpdap_linux_x86_64 flash id
 2021-01-20T20:26:12.526Z ERROR spi_flash::sfdp > Did not read enough SFDP bytes: got 16, needed 24
Manufacturer 0xC8 (Apple Computer), Device 0x14/0x4015, Unique ID:<PHONE_NUMBER>17352D
Finished in 0.23s

scan:
tom@thinkcenter:~/projects/spdif_pmod/fpga/colorlight_i5$ ~/Downloads/ecpdap_linux_x86_64 flash scan
 2021-01-20T20:28:40.078Z ERROR spi_flash::sfdp > Did not read enough SFDP bytes: got 16, needed 24
Reading flash ID...
Manufacturer 0xC8 (Apple Computer), Device 0x14/0x4015, Unique ID:<PHONE_NUMBER>17352D

Reading flash parameters...
No SFDP header found. Check flash supports SFDP.
Reading status registers...
Status 1: 0x00, status 2: 0x00, status 3: 0x00
BP0: false, BP1: false, BP2: false, SEC: false, TB: false
Finished in 0.24s

erase: (seems to work)
tom@thinkcenter:~/projects/spdif_pmod/fpga/colorlight_i5$ ~/Downloads/ecpdap_linux_x86_64 flash erase
 2021-01-20T20:29:01.679Z ERROR spi_flash::sfdp > Did not read enough SFDP bytes: got 16, needed 24
  Erasing
Finished in 1.95s

write:
tom@thinkcenter:~/projects/spdif_pmod/fpga/colorlight_i5$ ~/Downloads/ecpdap_linux_x86_64 flash write spdif_test.bit
 2021-01-20T20:29:46.450Z ERROR spi_flash::sfdp > Did not read enough SFDP bytes: got 16, needed 24
Error: No erase instruction has been specified.

I'm pretty sure this is the same bug that by coincidence someone else reported a few hours ago on the same board in #9; are you able to try building from this repository (or just cargo install ecpdap if you have Rust installed)? If not I can also upload a prebuilt binary to check against.

I'm pretty sure this is the same bug that by coincidence someone else reported a few hours ago on the same board in #9; are you able to try building from this repository (or just cargo install ecpdap if you have Rust installed)? If not I can also upload a prebuilt binary to check against.

(Here's a pre-built Linux executable which hopefully will work for your flash, so long as your system has similar libc/libusb versions to me:  ecpdap_linux_x86_64_spi-flash_0_2_2.zip)

(Here's a pre-built Linux executable which hopefully will work for your flash, so long as your system has similar libc/libusb versions to me:  ecpdap_linux_x86_64_spi-flash_0_2_2.zip)

The issue is fixed with the new binary. Thanks!

The issue is fixed with the new binary. Thanks!


Python parsing does not work well with empty blocks

In the playground, if I type in
def foo():

I get
module [0, 0] - [1, 0])
  ERROR [0, 0] - [0, 10])
    identifier [0, 4] - [0, 7])
    parameters [0, 7] - [0, 9])

If I add a statement at indent level 0:
def foo():

print "hi"

I get
module [0, 0] - [3, 0])
  function_definition [0, 0] - [2, 10])
    name: identifier [0, 4] - [0, 7])
    parameters: parameters [0, 7] - [0, 9])
    body: block [2, 0] - [2, 10])
      print_statement [2, 0] - [2, 10])
        argument: string [2, 6] - [2, 10])

I believe this reveals a flaw in the indentation sensitivity of the python parser.  Ideally:

print "hi" should not get parsed as a child of the function_definition.

The empty block should be filled in with a MISSING recovery of insertion of pass

I don't know much about tree sitter grammar construction, so I am not sure if fixing this is feasible.  Similar issues occur with unterminated parenthesis at the end of the block, incomplete infix operators, etc.

Thanks for writing this up!

You're welcome, thanks for the quick fix!


Update documentation regarding usage in place of xdg-open

Hello.
First, thanks for the project, it's awesome! )
Second. I think documentation part that covers usage handlr instead of xdg-open on Arch should be altered little bit.
xdg-utils-handlr aur package is not actively maintained. Right now it depends on handlr-regex (this was not the case yesterday), but in forces removal of xdg-utils. So it can cause compatibility issues with other applications because of not having xdg-desktop-icon and other scripts on their system.
Maybe consider changing documentation so that it advertises "shadowing" xdg-open in a user-scoped location in a $PATH, such as ~/.local/bin? Last comment from a former xdg-utils-handlr maintener suggests doing the same.

Sorry for ignoring this issue for a few weeks. I want to let you know I have seen this and I intend to update the documentation about this eventually.


Merge master-qa

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.6 out of 7 committers have signed the CLA.:white_check_mark: ClaudeROSSI:white_check_mark: cabch:white_check_mark: Ninjeneer:white_check_mark: LucasBrazi06:white_check_mark: jerome-benoit:white_check_mark: WillyLellouch:x: Jakob8You have signed the CLA already but the status is still pending? Let us recheck it.


Is there no rule which fixes wrong namespaces?

Support question
composer.json autoload section:
...
    "autoload": {
        "psr-4": {
            "C33s\\Doctrine\\": "src/Doctrine"
        }
    },
...

class src/Doctrine/Types/AbstractValueObjectJsonType.php :
namespace App\Doctrine\Types;

use C33s\Doctrine\Types\Interfaces\ArrayInterface;
use Doctrine\DBAL\Platforms\AbstractPlatform;
use Doctrine\DBAL\Types\ConversionException;
use Doctrine\DBAL\Types\JsonType;
use Exception;

abstract class AbstractValueObjectJsonType extends JsonType
...

the namespace is wrong, according to composer.json and the path it should be C33s\Doctrine\Types but the rule @Symfony and psr4 doesn't fix it. is there no rule which can fix wrong namespaces?
also tried phpstan and php-codesniffer. for codesniffer if found https://github.com/suin/phpcs-psr4-sniff but it's not compativle with php7.4

ping @kubawerlos as I've not enough insight on the PSR4 fixer to say anything of value about this.

The psr0 fixer has a dir option, you can set it to src/Doctrine.
To find the wrong namespaces I find PHPStan doing great job, ii is reading from autoload from composer.json and throwing an error when a class cannot be found.


undefined response object in UrlResolver

info: Saving logs to ./test2010-03-01/quickscrape1.2016-09-11-19-16.log
info: quickscrape 0.4.7 launched with...
info: - URLs from file: undefined
info: - Scraperdir: /home/pm286/journal-scrapers/scrapers
info: - Rate limit: 10 per minute
info: - Log level: info
info: urls to scrape: 13110
info: processing URL: http://dx.doi.org/10.1088/0965-0393/18/2/025015
error: Error: ETIMEDOUT so moving on to next url in list
info: processing URL: http://dx.doi.org/10.1088/0965-0393/18/2/025016
error: Error: ETIMEDOUT so moving on to next url in list
info: processing URL: http://dx.doi.org/10.4304/jsw.5.3.304-311
error: page did not return a 200 instead returned 500 so moving on to next url in list
info: processing URL: http://dx.doi.org/10.1209/0295-5075/89/69002
error: Error: ETIMEDOUT so moving on to next url in list
info: processing URL: http://dx.doi.org/10.5373/jaram.223.092109
/home/pm286/.nvm/versions/node/v6.3.1/lib/node_modules/quickscrape/node_modules/thresher/lib/url.js:60
    callback(err, response.request.href);
                          ^

TypeError: Cannot read property 'request' of undefined
    at Request._callback (/home/pm286/.nvm/versions/node/v6.3.1/lib/node_modules/quickscrape/node_modules/thresher/lib/url.js:60:27)
    at self.callback (/home/pm286/.nvm/versions/node/v6.3.1/lib/node_modules/quickscrape/node_modules/request/request.js:368:22)
    at emitOne (events.js:96:13)
    at Request.emit (events.js:188:7)
    at Request.onRequestError (/home/pm286/.nvm/versions/node/v6.3.1/lib/node_modules/quickscrape/node_modules/request/request.js:1025:8)
    at emitOne (events.js:96:13)
    at ClientRequest.emit (events.js:188:7)
    at Socket.socketErrorListener (_http_client.js:308:9)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
finished

This is actually a bug in thresher. See contentmine/thresher#23


Cannot use sendRedirect within try block

When sendRedirect is used within try, an exception is caught in catch.

Closed as repo is deprecated.


Overriding the default parser without the ValueParser annotation

I've just noticed that I cant override the default validator parser when I dont provide an ValueParser annotation in my view model.
In that way I was unable to replace globally the default behavior.
In this PR I am providing a solution where when the annotation is not provided I try to fallback to the view model property type. So when I have a datetime without the annotation, I try to find a custom parser that matches the "datetime"  name.

Thank you for your contribution. I'll be able to review and test it within the next 2 weeks because I have no access to Visual Studio and all that stuff like computer right now. I you find some spare time try to present a code samples which help me to reproduce that issue. Otherwise it may be problematic. Thanks for understanding. Regards.

We have a system where we have 100+ datetime fields and we live in Brasil "dd/mm/yyyy". Instead of put the ValueParser in all of the fields we did this one line change where the javascript checks if exists in the system a custom parser for the input. =)
It`s working flawless =)
// Date parser
ea.addValueParser('datetime', function (value) {
  if (/\/Date\(.+\)\//.test(value)) {
    return moment(value).toDate();
  }

  var date = moment(value, gorilla.formats.dateTime.dateAndHoursSeconds);
  if (date.isValid()) {
    return date.toDate();
  }
  return Date.parse(value) || value;
});

// Money parser
ea.addValueParser('numeric', function (value) {
  return globalize.parseFloat(value);
});

Thanks, this solution is nice and simple.


public index page shows no graphics at my iphone chrome browser

I did clone the project and run the script as instructed. working fine at browser but not in my iphone , though when i resize my mac osx browser to a small one it did show graphics, attached are the screen cap on my iphone.
thanks!

the dashboard display on the mobile end has a bug, will fix it
home page style cannot show, you try on the PC what look at the request of the CSS address?


'observeCallback' is inaccessible due to 'internal' protection level

Description:
I want to use this library only to get the authorization code, but this is not possible (yet).
I saw the open functions so I want to override the authorize function, but when I do that, I'll get the following error: 'observeCallback' is inaccessible due to 'internal' protection level
I removed the following code from the override function, and used succes to return responseParameters (which contain authorization code)
class OAuth2SwiftAuthCode: OAuth2Swift {

   override func authorize(withCallbackURL callbackURL: URL?, scope: String, state: String, parameters: Parameters = [:], headers: OAuthSwift.Headers? = nil, success: @escaping TokenSuccessHandler, failure: FailureHandler?) -> OAuthSwiftRequestHandle? {

        self.observeCallback { [weak self] url in
            guard let this = self else {
                OAuthSwift.retainError(failure)
                return
            }
            var responseParameters = [String: String]()
            if let query = url.query {
                responseParameters += query.parametersFromQueryString
            }
            if let code = responseParameters["code"] {
                if !this.allowMissingStateCheck {
                    guard let responseState = responseParameters["state"] else {
                        failure?(OAuthSwiftError.missingState)
                        return
                    }
                    if responseState != state {
                        failure?(OAuthSwiftError.stateNotEqual(state: state, responseState: responseState))
                        return
                    }
                }
                let callbackURLEncoded: URL?
                if let callbackURL = callbackURL {
                    callbackURLEncoded = URL(string: callbackURL.absoluteString.urlEncoded)!
                } else {
                    callbackURLEncoded = nil
                }
                //**NOTE: Replaced this.postOAuthAccessTokenWithRequestToken with succes!**
                success(this.client.credential, nil, responseParameters)
            } else if let error = responseParameters["error"] {
                let description = responseParameters["error_description"] ?? ""
                let message = NSLocalizedString(error, comment: description)
                failure?(OAuthSwiftError.serverError(message: message))
            } else {
                let message = "No access_token, no code and no error provided by server"
                failure?(OAuthSwiftError.serverError(message: message))
            }
        }
    }
}

OAuth Version:

[ ] Version 1
[x] Version 2

OS (Please fill the version) :

[x] iOS :
[ ] OSX :
[ ] TVOS :
[ ] WatchOS  :

Installation method:

[ ] Carthage
[x] CocoaPods
[ ] Manually

Library version:

[ ] head
[ ] v1.2.1
[x] v1.2 (Swift 4.0)
[ ] v1.0.0
[ ] v0.6
[ ] other: (Please fill in the version you are using.)

Xcode version:

[x] 9.3 (Swift 4.1)

[ ] 9.0 (Swift 4.0)

[ ] 9.0 (Swift 3.2)

[ ] 8.x (Swift 3.x)

[ ] 8.0 (Swift 2.3)

[ ] 7.3.1

[ ] other:

[ ] objective c

why not override postOAuthAccessTokenWithRequestToken  to get the code?
and respond what you want


I get a problem when open the extension tab

When I open the extension, I got a error: connect ENOENT /var/folders/9f/yyj8mshd4m5ccwy1v_10hrj80000gn/T/Code-1.9.1-shared.sock

VSCode Version: 1.9.1
OS Version: 10.12.3

Steps to Reproduce:

open visual studio code
switch plugin tab or install a extension

Can you restart your machine?

Sorry it did not work.
Screen Shot
File Code-1.9.1-shared.sock not exist

Duplicate of #13561
Fixed in the latest Insiders release
Workaround: start from the command line code .


Multiple condition on Time field does not work.

Executing query
x.Time >= DateTime.Parse("2017-09-13T22:17:52.000Z") && x.Time <= DateTime.Parse("2017-09-14T02:17:52.000Z") seems like only second part of expression applies .

Duplicate of https://github.com/scale-tone/linq2dynamodb/issues/45 and a known issue.
Technically, the bug is in AWSSDK (it should throw in such scenario).
The workaround is to use a custom FilterExpression.


Maximum execution time

Reverb Version
1.0
Laravel Version
11.9
PHP Version
8.2
Description
While running the reverb in localhost
after same minitus i get this error and the reverb connection will be closed.
i also increased the execution time in AppServiceProvider
    // max execution time
    ini_set('max_execution_time', 300);

Maximum execution time of 300 seconds exceeded

 at vendor/react/event-loop/src/StreamSelectLoop.php:291
   287▕                 }
   288▕             }
   289▕
   290▕             /** @var ?callable $previous */
 ➜ 291▕             $previous = \set_error_handler(function ($errno, $errstr) use (&$previous) {
   292▕                 // suppress warnings that occur when `stream_select()` is interrupted by a signal
   293▕                 // PHP defines `EINTR` through `ext-sockets` or `ext-pcntl`, otherwise use common default (Linux & Mac)
   294▕                 $eintr = \defined('SOCKET_EINTR') ? \SOCKET_EINTR : (\defined('PCNTL_EINTR') ? \PCNTL_EINTR : 4);
   295▕                 if ($errno === \E_WARNING && \strpos($errstr, '[' . $eintr .']: ') !== false) {

Steps To Reproduce
while running this in the localhost
php artisan reverb:start

Can you try the following configuration for reverb.php:
    'servers' => [

        'reverb' => [
            'host' => env('REVERB_SERVER_HOST', '<IP_ADDRESS>'),
            'port' => env('REVERB_SERVER_PORT', 8080),
            'hostname' => env('REVERB_HOST'),
            'options' => [
                'tls' => [],
+.             'timeout' => false,
            ],

@crynobone
still same issue

Using ini_set('max_execution_time', 300); in your AppServiceProvider would set the max execution time to 300 seconds, so yes, the Reverb server will be stopped after 300 seconds.
Reverb is a long-running process, since it's ran through the CLI it would have a timeout of -1 by default, which allows it to run until stopped. Your PHP ini config probably has a max timeout set, so the script will stop after that time. In order for it to work properly you'd need to set the timeout to -1, ideally with different config files, one for the web server and one for the CLI scripts.

@RobertBoes
thanks 🙏

by moving the   ini_set('max_execution_time', 300); to production it solve the problem, and reverb is not stopped


Clarification of zuul routing behavior when using a default route ("/")

If I add a request mapping to the api-gateway server found here:
https://github.com/wgorder/api-gateway
    @RequestMapping(value ="Hello")
    String sayHello() {
        return "Hello World"
    }

I can see it is registered on startup:
2015-01-12 14:00:03.128  INFO 10972 --- [           main] s.w.s.m.m.a.RequestMappingHandlerMapping : Mapped "{[/Hello],methods=[],params=[],headers=[],consumes=[],produces=[],custom=[]}" onto public java.lang.String com.acme.demo.gateway.ApiGatewayApplication.sayHello()

However if I hit localhost:8080/hello (this is where the api-gateway runs) it attempts to proxy that request to the acme-ui application and returns a 404
The zuul routes in the api-gateway look like this
https://github.com/wgorder/api-gateway/blob/master/src/main/resources/application.yml
so you can see that the acme-ui is set as a catch all, however I expected it to match against its own @RequestMappings before attempting a zuul route.  Is this expected behavior?  How would I tell zuul to route to myself if so?

@wgorder The order of the handler mappings is what is important here.  It looks like the ZuulHandlerMapping is ahead of the RequestMappingHandlerMapping.
You could use something like:
zuul:
  routes:
    hello:
      url: http://localhost:${server.port}
      path: /Hello/**

Fair enough I guess. Can I provide multiple paths?

sibling entries to hello would work, but that seems a bit cumbersome.  Why do you need a default route of /**?  Couldn't you put it /somewhereelse and have a controller that does a forward from / to /somewhereelse?

Well I don't have the @ZuulProxy on my UI service.  I have it on the api gateway service.  So routing for any static resources css/js/fonts/images or in the case of local dev bower_comonents, /.tmp etc all need to be routed to acme-ui.  Also if  a user bookmarks a page like /#products/1  that also has to be routed.  So I don't think a simple / with a 'forward' would work.  Plus I don't think you can forward from one container to another.  It would have be a redirect or a framework like zuul to do the routing.. Or am I missing your point entirely?

You're missing it a little bit.  Instead of having /** forward (not redirect) to acme-ui have /ui/** forward to acme-ui and have a local controller forward /to/ui.  The downside to that is that your bookmarks would have /uiin the path.  Another option would be to put whatever functionality you are implementing in/Hello` into another service.  I also have seen what it would take to reorder the mappers.

After thinking a bit, I think you could have the forward of / to /ui work and not see /ui in the url.

I can play with this.  I think re-ordering the mappers might also be painful as spring auto maps /css /js etc for you and often times you may not want those matched before zuul routing kicks in (if your static resources are not on the zuul proxy app)


An Internal error occurred while attempting to perform this command /enchant /anvil

im using spidgot and portablecraftingInvs for 1.19 and im getting the error "An Internal error occurred while attempting to perform this command" whenever i try to run /enchant and /anvil

Do you happen to have a console log of this error happening? Should also be noted that I build 1.19 builds using the latest 1.19 version (in this case 1.19.3), if you're using an outdated version let me know.

Closing for now; cannot seem to replicate and console log has not been provided yet.
If you do encounter the issue again please reopen this.


Implement memories with sequential reads

Fixes https://github.com/cucapra/calyx/issues/165. We should make at least one frontend use these memories. Eventually, this will make it easier for us to use UltraRAM memories on FPGAs instead of BRAMs.
We can design a parameterized memory which takes read and write latencies as parameters. However, we don't currently have a way to specify the @static behavior of such memories because they are parameteric

About the comment re. frontend support… it occurs to me that we would in general like to make it as easy as possible for frontends to switch between different styles of memories

Right! I think that would be important especially if we want to expose the same interface for BRAMs and UltraRAMs. I think the simple read_en/read_done combo would be a straightforward way to start but we'd need some reasoning to think about the logical to physical mapping (i.e., turning a logical memory into a BRAM or URAM) and adding static annotations for them.
This might also be interesting to @andrewb1999

Added a test for these memories. Next step is updating the Dahlia frontend to generate non-combinational memories


categories and tags index.html not being generated?

Hi, I'm not sure what happened but categories and tags index.html not being generated?
$ hugo -v
INFO 2018/08/19 13:09:19 Using config file: /Users/hero/Development/computerbryan-hugo/config.toml
Building sites … INFO 2018/08/19 13:09:19 syncing static files to /Users/hero/Development/computerbryan-hugo/public/
INFO 2018/08/19 13:09:19 found taxonomies: map[string]string{"tag":"tags", "category":"categories"}
INFO 2018/08/19 13:09:19 Alias "/tags/electronics/page/1.html" translated to "tags/electronics/page/1.html"
INFO 2018/08/19 13:09:19 Alias "/page/1.html" translated to "page/1.html"
INFO 2018/08/19 13:09:19 Alias "/post/page/1.html" translated to "post/page/1.html"

                   | EN
+------------------+----+
  Pages            | 17
  Paginator pages  |  0
  Non-page files   |  6
  Static files     | 40
  Processed images |  0
  Aliases          |  3
  Sitemaps         |  1
  Cleaned          |  0

$ ls public/tags
electronics      electronics.html index.xml
$ ls public/categories
index.xml

Yes, I have uglyurls = true in config.toml
I need it because I'm hosting on S3/CloudFront with UglyUrls....
Thank you.

Maybe I was mistaken and it was never generated? I could have swore it was at one time?

It seems that the html file was generated, but the link is wrong... You can visit it by tags.html.


quarkus.camel.main.shutdown.timeout  doesn't work as intended

The property

quarkus.camel.main.shutdown.timeout

doesn't work when I tried to configure my application. Also I  tried with the following code to set graceful shutdown but It doesn't work, too.
camelContext
        .getShutdownStrategy()
        .setTimeout(66);

While I was debugging my Camel application I realized, that the default graceful shutdown strategy is

NoShutdownStrategy

In Apache Camel the default strategy  is https://camel.apache.org/manual/latest/graceful-shutdown.html#_implementing_custom_component_or_shutdownstrategy

DefaultShutdownStrategy

@iqnev It is possible to set graceful shudown via property
camel.main.shutdownTimeout = 15

or via camel context.
camelContext
        .getShutdownStrategy()
        .setTimeout(66);

In development mode NoShutdownStrategy is used.

@JiriOndrusek Thanks! I will try it.


Create Time_Conversion.cpp

Related Issue

Mention issue for which this pull request is a part of #1076

Proposed Changes

Added a cpp file in the 1-Level 1 in Problem Statement & Solution

Additional Info

Any additional information or context

Checklist

[x] ✅ My code follows the code style of this project.
[ ] 📝 My change requires a change to the README.
[ ] 🎀 I have updated the README accordingly.
[x] 👀 I have read the CONTRIBUTING document.
[ ] ✨ I have added tests to cover my changes.
[ ] 🚩 All new and existing tests passed.
[x] 🌟 ed the repo

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots

Screenshot #1
Screenshot #2

Output 1
Output 2

Add readme .

Add readme .
For contribution and more guidelines i would recommend you to go through this
tutorial video of the project here,

Add readme file
put TIcks all proper boxes
Follow guidelines
** Complete by today...either It will be closed**


Only prepend textureUrl with baseUrl if not a Data URI

When the JSONLoader loads an image, it should only prepend the baseUrl if the image url is not a Data URI.
This fixes #1509

Nice catch, I need to add this to the loader in v3 as well!


python3Packages.shapely: fix build with geos 3.9.0

Motivation for this change
While testing #111671, I noticed that python3Packages.shapely was failing on staging. This pulls in an upstream patch to add compatibility with geos 3.9.0, which is on staging right now, but not yet on master.
I'm not sure if this PR should be targeted at staging or master though.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

If it only fails on staging than targeting it with less rebuilds is fine.


Add organization fields as a resource type in app requirements

:v:
/cc @zendesk/vegemite
Description
Add organization fields as a resource type in app requirements
References

JIRA: Related to testing https://zendesk.atlassian.net/browse/AF-577

Risks

[low] breaks validations for app requirements

@fvzzy this needs to be tagged and released so we can start rolling it out


A11y_AzureDataStudioAAE_Sql Instance 1_Compute + Storage_Keyboard: Only color is used to identify between normal text of screen and "scaling computes vCores and memory" link

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHubTags: #A11yMAS;#A11yTCS;#A11ySev2;#SH_AzureDataStudio_AAE_Jun2021;#SQL Azure Data Studio;#Win10;#FTP;#DesktopApp;#Keyboard;#WCAG1.4.1;#AINotInScope;
Environment Details:
Application Name: Azure Data Studio-AAE
Windows Version: Win10
Repro Steps:

Launch the application-Azure Data Studio-Insiders and install extension Azure arc and Azure data ClI
Connect to Azure Arc Controller
Tab till Azure Arc Controller tree and tab to the node present under it
Tab to child node "Sqlinstance1" and open manage and tab to "Compute + Storage" and press enter
Tab to "scaling computes vCores and memory" link
Check the link if it has a tooltip or different font or bold text or underline.

Actual:
Only color is used to identify between normal text of screen and "scaling computes vCores and memory" link.
Similar issue is observed through out the application.
Expected:
Only color should not be used to identify between normal text of screen and "scaling computes vCores and memory" link. Link can have a tooltip or different font or bold text or underline.
User Impact:
Keyboard users will get confused to identify between normal text and link on screen.
https://user-images.githubusercontent.com/85863543/127598250-c22a2296-a24c-485b-b254-dd8969359f31.mp4

GitHub Tags: #Closed;


create filter module

If you start with a signal, take the FFT, edit the complex numbers, then take the iFFT, you result with a signal whose spectral components can be filtered. Create a module to make filtering easy. Something like:
double[] audio = ReadWav("test.wav");
double[] filtered1 = FftSharp.Filter.LowPass(audio, frequency: 500);
double[] filtered2 = FftSharp.Filter.HighPass(audio, frequency: 500);
double[] filtered3 = FftSharp.Filter.BandPass(audio, frequency1: 300, frequency2: 500);
double[] filtered4 = FftSharp.Filter.BandStop(audio, frequency1: 300, frequency2: 500);

oops, this issue belongs in the FftSharp project:
https://github.com/swharden/FftSharp/issues/23

Hi, sorry to open an old issue.
I'd like to know if there is a way to apply FftSharp's filters while generating a spectrogram image using this library. I don't see any exposed filter method from SpectrogramGenerator


Jaaf 31 7 a synchronize fr/runtime-*.md with EN version [skip ci]

Q
A

Is bugfix?
no

New feature?
no

Breaks BC?
no

Tests pass?

Fixed issues
comma-separated list of tickets # fixed by the PR, if any

Merged. Thank you!


Bump minitmatch to version that fixes DoS vulnerability

More info: https://snyk.io/test/npm/minimatch/3.0.0

Thanks :)

published :)


Write developer documentation.

How does it work? Why this way?
Find out and write down.

That's it. Time to close this.


feat(modular): add modular support for cdr/ciem

xref: https://sysdig.atlassian.net/browse/SSPROD-46143
This is a draft PR for now, it contains the refactor for GCP modular onboarding specifically for CDR and CIEM.
It is important to notice that this will be cleaned up until the Onboarding + CSPM terraform snippets are ready, for now ignore all the commented sections, the uncommented sections are the ones that will be part of the new snippets.

@jose-pablo-camacho We should rename the integrations & the example files as log-ingestion instead of webhook-datasource the internal component representation obviously will continue to be webhook-datasource

@jose-pablo-camacho We should rename the integration to integrations/pub-sub and the examples to pub-sub.tf. I think the pattern we have followed is the actual name of the event integration in the specific cloud.

I have changed the name from webhook-datasource to pub-sub.

Left a few comments, you will also need to rebase & address some merge conflicts based on latest master.
The foundational PR is now merged.


feat: adding stable name for all html pages

Details

[x] closes #158
[x] closes #148
[x] If RFC, it has been approved for implementation.

Code of Conduct

[x] I agree to follow this project's Code of Conduct
[x] I checked the current PR for duplication.

@louisgv how much have you tested this manually?

@louisgv how much have you tested this manually?

Just tested for with-src, with-devtools, and with-content-scripts-ui

Ok I am fine with that risk profile. LGTM


Support uniqueness constraints during introspection

When introspecting, expose whether a column is marked as unique.

Moving to prisma-engine.


Please publish to Maven Central

I am not comfortable using JitPack as it does not enforce author code signatures. Please publish to Maven Central with code signing.

Hi @johnmaguire. I totally understand your concerns. I am looking to getting it published on Maven Central soon.


Keyboard error

Steps to reproduce
I have one TextField whit this method implemented onChanged and when use the input the issue appears
Expected results
_AssertionError ('package:flutter/src/services/hardware_keyboard.dart': Failed assertion: line 471 pos 16: '_pressedKeys.containsKey(event.physicalKey)': A KeyUpEvent is dispatched, but the state shows that the physical key is not pressed. If this occurs in real application, please report this bug to Flutter. If this occurs in unit tests, please ensure that simulated events follow Flutter's event model as documented in HardwareKeyboard. This was the event: KeyUpEvent#f1a79(physicalKey: PhysicalKeyboardKey#80fe7(usbHidUsage: "0x00070006", debugName: "Key C"), logicalKey: LogicalKeyboardKey#18653(keyId: "0x00000063", keyLabel: "C", debugName: "Key C"), character: null, timeStamp: 6:54:33.412902))
Actual results
_AssertionError ('package:flutter/src/services/hardware_keyboard.dart': Failed assertion: line 471 pos 16: '_pressedKeys.containsKey(event.physicalKey)': A KeyUpEvent is dispatched, but the state shows that the physical key is not pressed. If this occurs in real application, please report this bug to Flutter. If this occurs in unit tests, please ensure that simulated events follow Flutter's event model as documented in HardwareKeyboard. This was the event: KeyUpEvent#f1a79(physicalKey: PhysicalKeyboardKey#80fe7(usbHidUsage: "0x00070006", debugName: "Key C"), logicalKey: LogicalKeyboardKey#18653(keyId: "0x00000063", keyLabel: "C", debugName: "Key C"), character: null, timeStamp: 6:54:33.412902))
Code sample
decoration: InputDecoration(
hintText: LocalizationService().getResource('workportal-widget-search') + "...",
filled: true,
fillColor: Colors.white,
contentPadding: const EdgeInsets.symmetric(vertical: 8.0, horizontal: 8.0),
border: OutlineInputBorder(
borderRadius: BorderRadius.circular(10),
borderSide: BorderSide.none,
),
suffixIcon: Visibility(
visible: isSearchEmpty == false,
child: GestureDetector(
onTap: () {
// Clear search in Bloc
context.read().add(const DoSerachInformation(inputValue: ""));
                      // UX clear info
                      _textSearchController.clear();
                    },
                    child: const Icon(Icons.cancel, color: AppTheme.silverColor, size: 20.0),
                  )
                ),
              ),
              onChanged: (value) {
                  // save info in Bloc
                  context.read<SearchBloc>().add(DoSerachInformation(inputValue: value));
              },
              inputFormatters: [
                FilteringTextInputFormatter.allow(
                  EnvironmentConfig.regexBySearchActivities
                ),
              ],
            ),
          ),

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[Paste your output here]

Hi @codebryanc
When opening an issue, please try to provide all information indicated in the template so that we can address this issue properly (See bug issue template here)
More specifically, please provide the following information:

A completed and minimal reproducible code sample
The output of flutter doctor -v
Reproduction steps in detail (which keys did you press?)
Which environment did this issue happen in? (Android/iOS/Web/MacOS/Windows/Linux)


Adding missing attributes in ContainerState message

@xcoulon Thanks for this PR. You should also add the new attributes to equals(), hashCode(), and toString() and include update the tests.

superseded by https://github.com/spotify/docker-client/pull/170


Update pom.xml

Fix #2

@rultor hello

@rultor hello

@kerelape Hi there! I understand a few simple commands: "merge", "deploy", etc. This page explains them briefly. Any questions or bug reports are welcome. Have fun :)


Contact form & finish mobile version pair programming

Pair Programming session:

Added Contact-form section in the index.html file.
Updated mobile_first.css styles for the new section and its elements.
Fixed submit-button position from contact-section.
Fixed Get-in-touch button position and its properties.
Fixed bottom-bar line position and its properties.

Coding partners [@Alejuda @enmanuelbayen]

On the last commit, I made the required changes.

Made the required changes from last review.
ºThe button interactions are working fine on the 3 states:

Made the required changes from last review.
ºThe button interactions are working fine on the 3 states:

@JuanDiegoGuerra, Great Job Guys. Keep it up.


⚠ Samsung has degraded performance

In 850b9d9, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2731 ms

Resolved: Samsung performance has improved in a3d581e.