HBASE-27153 Improvements to read-path tracing

Take another pass through tracing of the read path, make adjustments accordingly. One of the major concerns raised previously is that we create a span for every block access. Start by simplifying this to trace events and see what else comes up.
Block-level and stream-level interactions are represented as span events with attached attributes (that's otel terminology for "structured logs", attached to the spans). I made an effort to surface information that an operator might be interested in while diagnosing slow read performance, and details that the previous generation of dev had already seen fit to surface via trace-level logging. We no longer emit spans for HFileReaderImpl.readBlock. I hope this is a good compromise between visibility and performance.
Also added a span context for block-cache pre-fetching.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 50s
master passed

+1 :green_heart:
compile
1m 23s
master passed

+1 :green_heart:
shadedjars
3m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  1s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 28s
the patch passed

+1 :green_heart:
compile
1m 22s
the patch passed

+1 :green_heart:
javac
1m 22s
the patch passed

+1 :green_heart:
shadedjars
3m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 45s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 17s
hbase-client in the patch passed.

-1 :x:
unit
10m 30s
hbase-server in the patch failed.

34m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4572

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e20e9ad38046 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 50f11151fd

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/1/testReport/

Max. process+thread count
591 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 57s
master passed

+1 :green_heart:
compile
1m 23s
master passed

+1 :green_heart:
shadedjars
4m  6s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 53s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 55s
the patch passed

+1 :green_heart:
compile
1m 45s
the patch passed

+1 :green_heart:
javac
1m 45s
the patch passed

+1 :green_heart:
shadedjars
5m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 41s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 12s
hbase-client in the patch passed.

-1 :x:
unit
11m 29s
hbase-server in the patch failed.

37m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4572

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 59484e38e84f 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 50f11151fd

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/1/testReport/

Max. process+thread count
553 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 19s
Docker mode activated.

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 56s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 57s
master passed

+1 :green_heart:
compile
4m  6s
master passed

+1 :green_heart:
checkstyle
1m  8s
master passed

+1 :green_heart:
spotless
0m 58s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
3m 18s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 57s
the patch passed

+1 :green_heart:
compile
4m 12s
the patch passed

+1 :green_heart:
javac
4m 12s
the patch passed

+1 :green_heart:
checkstyle
1m  9s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 12s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 43s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

46m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4572

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 1ec1e608ba06 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b8558d30d0

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 45s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 57s
master passed

+1 :green_heart:
compile
1m 49s
master passed

+1 :green_heart:
shadedjars
4m 18s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 13s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 35s
the patch passed

+1 :green_heart:
compile
1m 46s
the patch passed

+1 :green_heart:
javac
1m 46s
the patch passed

+1 :green_heart:
shadedjars
4m 31s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 21s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 37s
hbase-common in the patch passed.

+1 :green_heart:
unit
2m 10s
hbase-client in the patch passed.

-1 :x:
unit
286m 39s
hbase-server in the patch failed.

317m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4572

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ac1a7f1c2e6c 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b8558d30d0

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/2/testReport/

Max. process+thread count
2586 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 47s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 25s
master passed

+1 :green_heart:
compile
1m 28s
master passed

+1 :green_heart:
shadedjars
4m 21s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  1s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 11s
the patch passed

+1 :green_heart:
compile
1m 31s
the patch passed

+1 :green_heart:
javac
1m 31s
the patch passed

+1 :green_heart:
shadedjars
4m 27s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 49s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 54s
hbase-client in the patch passed.

-1 :x:
unit
298m 58s
hbase-server in the patch failed.

327m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4572

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f9c92f39216e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b8558d30d0

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/2/testReport/

Max. process+thread count
2393 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell

I wish we didn't have to pass the scan attribute builder through as an extra parameter to methods that don't care about tracing per se, they simply exist on the traced path.

The reason that I have to pass this attributes object around is that I'm providing context that is eventually annotated to a span "event" -- essentially a log line. Otel API lets me stuff arbitrary attributes into a thread local for span attributes, not for span event attributes.

Is it possible to use threadlocals or some otel notion of thread context for these? Or is that an anti-pattern?

I am also not a fan of the current approach. Introducing a ThreadLocal for this purpose that is inspected at arbitrary code points seems ham-handed to me. At the very least, it should somehow be limited in scope to the current request, not the current thread. Let me see if I can find a better solution.

@apurtell I changed the implementation to use the otel Context for propagating the additional information I wanted, without changing the method signatures. I'm not sure if this is intended use of the otel api or not...

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 38s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 39s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 20s
master passed

+1 :green_heart:
compile
1m  4s
master passed

+1 :green_heart:
shadedjars
3m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
master passed

-0 :warning:
patch
5m  1s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  5s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

+1 :green_heart:
shadedjars
3m 54s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 22s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m  7s
hbase-client in the patch passed.

+1 :green_heart:
unit
201m 42s
hbase-server in the patch passed.

224m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4572

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5deaf502c8b0 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d7f6861e8d

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/3/testReport/

Max. process+thread count
2418 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 46s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 45s
master passed

+1 :green_heart:
compile
1m 23s
master passed

+1 :green_heart:
shadedjars
3m 45s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  1s
master passed

-0 :warning:
patch
5m 12s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s
the patch passed

+1 :green_heart:
compile
1m 24s
the patch passed

+1 :green_heart:
javac
1m 24s
the patch passed

+1 :green_heart:
shadedjars
3m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  0s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 52s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 24s
hbase-client in the patch passed.

+1 :green_heart:
unit
207m  5s
hbase-server in the patch passed.

232m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4572

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1c6955175370 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d7f6861e8d

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/3/testReport/

Max. process+thread count
2622 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Approved. I like the
 final AttributesBuilder attributesBuilder = builderFromContext(Context.current());

style way of building attributes along a method call chain without adding the builder as a method parameter.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 52s
master passed

+1 :green_heart:
compile
1m 20s
master passed

+1 :green_heart:
shadedjars
4m 38s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  1s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 40s
the patch passed

+1 :green_heart:
compile
1m 13s
the patch passed

+1 :green_heart:
javac
1m 13s
the patch passed

+1 :green_heart:
shadedjars
4m 19s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 56s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 36s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 27s
hbase-client in the patch passed.

-1 :x:
unit
231m 56s
hbase-server in the patch failed.

257m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4572

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3a2f1d160cdd 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6886d02a91

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/4/testReport/

Max. process+thread count
3026 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 46s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m  6s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 17s
master passed

+1 :green_heart:
compile
2m  9s
master passed

+1 :green_heart:
shadedjars
4m 55s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 31s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  9s
the patch passed

+1 :green_heart:
compile
2m 10s
the patch passed

+1 :green_heart:
javac
2m 10s
the patch passed

+1 :green_heart:
shadedjars
5m 50s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 19s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 51s
hbase-common in the patch passed.

+1 :green_heart:
unit
2m  4s
hbase-client in the patch passed.

-1 :x:
unit
272m 30s
hbase-server in the patch failed.

308m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4572

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b934934803c7 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6886d02a91

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/4/testReport/

Max. process+thread count
2567 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

TestAsyncTableScan.testReverseScanNoStopKey[1: scan=batch] failure seems relevant.

TestAsyncTableScan.testReverseScanNoStopKey[1: scan=batch] failure seems relevant.

This failure is baffling to me. The assertion failed because a span with the name TracedScanResultConsumer#onComplete was not found in the collection. However, you can see that a span of that name is printed in the DEBUG logging!

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 51s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 22s
master passed

+1 :green_heart:
compile
3m 24s
master passed

+1 :green_heart:
checkstyle
0m 51s
master passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 14s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 29s
the patch passed

+1 :green_heart:
compile
4m  6s
the patch passed

+1 :green_heart:
javac
4m  6s
the patch passed

+1 :green_heart:
checkstyle
1m  4s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 38s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 54s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
4m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 39s
The patch does not generate ASF License warnings.

48m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4572

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux a9ae449a9f06 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e8c14ee308

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
60 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/5/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 42s
master passed

+1 :green_heart:
compile
1m 26s
master passed

+1 :green_heart:
shadedjars
3m 44s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 41s
the patch passed

+1 :green_heart:
compile
1m 23s
the patch passed

+1 :green_heart:
javac
1m 23s
the patch passed

+1 :green_heart:
shadedjars
3m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 54s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 23s
hbase-client in the patch passed.

-1 :x:
unit
208m 39s
hbase-server in the patch failed.

233m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4572

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 868547b198ce 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e8c14ee308

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/5/testReport/

Max. process+thread count
2442 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 30s
master passed

+1 :green_heart:
compile
1m  3s
master passed

+1 :green_heart:
shadedjars
4m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 47s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 12s
the patch passed

+1 :green_heart:
compile
1m  3s
the patch passed

+1 :green_heart:
javac
1m  3s
the patch passed

+1 :green_heart:
shadedjars
4m  0s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 23s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m  7s
hbase-client in the patch passed.

-1 :x:
unit
228m  2s
hbase-server in the patch failed.

250m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4572

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 24056846fce9 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e8c14ee308

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/5/testReport/

Max. process+thread count
2629 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4572/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Fixing ExpressRoute BillingType order bug

Hi @nupurkot, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (nkothar). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


NLog 5.0 preview 1 with strong-version <IP_ADDRESS>

Guess release-notes should be published first: https://github.com/NLog/NLog.github.io/pull/158
So nuget-packages can link to the release-notes

(restarted AppVeyor)

Hrm not perfect:
https://github.com/snakefoot/NLog/blob/nlog5-rc1/CHANGELOG.md


TEST. DO NOT MERGE

Sanity tests for ['RPI4 GW BB Kirkstone'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/47792/

Sanity tests for ['RPI4 GW BB Kirkstone'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/47918/


Navigation from code to schema and vice versa doesn't show up with GraphQL Config file(s) present

Hi, I have multiple gradle projects in a single IntelliJ IDEA project, one is the main app and includes the master GraphQL schema files and uses DGS to implement the API, and another is a client library that uses Apollo to fetch the schema from the app to generate the source files to be used by the client lib.
I'd like to keep both of these inside a single IDEA project, but it seems that the GraphQL plugin the DGS plugin depends on only supports a single schema inside IDEA project, unless you add a GraphQL Config file (e.g., graphql.config.yml). Basically, unless I add these config files to all the GraphQL schema instances, the in-editor navigation tends to jump to the wrong GraphQL files.
Now, when I specify the different schemas via the GraphQL config files, the GraphQL plugin works correctly, but the DGS plugin stops working. Basically, the DGS icons you can normally click to navigate from the schema file to Java/Kotlin source code for a given query/mutation simply disappear from the editor. Once I remove the GraphQL config files, they appear again, but that leads to the issues described in the previous paragraph.
I'm not sure where exactly the problem lies, so I'm trying to report it here first. Thanks in advance!

Hey @mamuf thank you for sharing this issue. It sounds like the issue you are running into is happening when there are multiple modules in a project and a GraphQL config file is used, resulting in code navigation not working as expected.
We will look into this issue and return with what we find.

We believe the issue to have been due to how the DGS is recognized within multi-module projects. The fix was just released in the v1.3.0, please give that a try and let us know if there's any further trouble.


It doesn't work

I've been waiting for this mod for along time, but it doesn't work!
When I open the menu, pick the bench and the bin and click "Add" it just freezes for a second and nothing happens.

I'm using version 0.3.0-20-g8d141fa on develop.

Interesting. Works for me on the tagged v0.3.0 release made 5 days ago, maybe try that instead of a Git branch? Typically the develop branch is a moving target, and might contain code that breaks the JS APIs I'm using here in the plugin.

The plugin works on the macOS build of the latest commit, try using that build for your platform?

I'm using the launcher on Windows 10 64-bit.
I did further research and found out, that it doesn't work on RCT1 maps.
On RCT2 maps it just works with a specific choice of benches.
When I choose Bench rct2.bench1 it does not work with Litter Bin rct2.litter1, Litter Bin rct2.littermm,  Litter Bin rct2.litterww.
If I pick Bench rct2.benchlog, it works with every litter bin.

And I don't know if this is a bug of 0.3.0, but I can't remove benches and bins with the clear scenery tool.

Ah ok, that might have to do with the RCT data/scenario. I only have the data for RCT2 so I can't test it against RCT1 or anything, but I would imagine that if you pick the right components it will work. Unfortunately, the order these items appear in the list is non-deterministic so I'm kinda depending on the .index of the list of footpath additions being the same as the numerical value I have to set in order to place the bench/bin on the path. I'm not sure if I can know which benches/bins would be "correct" for RCT1.
I tried it on Amity Airfield from RCT2 and it seems to work with the space-themed ones:

@nepumax I just released v0.2.0 of this plugin which looked like it included some fixes that might have fixed things for you? It seems like non-English and some non-RCT2 scenarios suffered from bins/benches not getting built properly in their parks.

It works now! Tested it on Forest Frontiers. Thanks, mate!


Feature count mismatch

Measure-RvoObfuscation /Users/user/Desktop/bad.ps1
Measure-Vector : Feature count mismatch (0 -ne 4998)
At /Users/user/Downloads/Revoke-Obfuscation-master/Revoke-Obfuscation.psm1:370 char:89

... asurement = Measure-Vector -FeatureVector $scriptFeatures -Deep:$Deep ...

            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Measure-Vector

not sure what to do with this one here..

@dlimanov did you provide the -path or -literalpath parameter Measure-RvoObfuscation? Maybe provide a copy of the .ps1 you were trying to measure.


Feature: Fish Completion Profile

Fish Completion
This PR adds a tab completion profile to be used by the fish shell

Each command has a description provided during tab completion based on watson help
supports the autocompletion of existing projects
supports the autocompletion of existing tags once a project is specified
supports the autocompletion of frames (but lacks a description of which frame is which)
if backend.url is present in the config file, print it instead of a generic message when describing watson sync

Change Overview
docs

Adds a section detailing the installation of watson.fish and how to resource your shell

watson.fish

Adds the fish completion profile.

Test Cases

No test cases were performed (with the exception of me currently using the completions on two devices)
No changes were made to the core watson code

I realized that there are several more flags to add into this, I should be able to keep poking at this throughout the week to get parity between the auto completion and the command documentation section.  I'll remove the WIP flag and @ someone for a final review

@k4nar do you speak Fish?

@andrewmeyer If you think we are good here, can you squash your commits? Then I'll merge this.

@jmaupetit Thanks,  everything should be squashed now.  I've been using this for a week and I think I have worked out all of the features I commonly use.  If something comes up I can always open another PR with bug fixes.

Sounds perfect! Thanks.


DBFunctions.CreateDateTime

Hi, I'd like to be able to do queries like the following:
_context.Shifts
   .Include(w => w.ShiftDefinition)
   .Select(w => new
   {
       w,
       dt = DbFunctions.CreateDateTime(
           w.ShiftDay.Year,
           w.ShiftDay.Month,
           w.ShiftDay.Day,
           w.ShiftDefinition.StartTime.Hours,
           w.ShiftDefinition.StartTime.Minutes,
           w.ShiftDefinition.StartTime.Seconds)
       })
   .Where(w => currentDate < w.dt)
   .OrderBy(w => w.dt)
   .Select(q => q.w)
   .FirstOrDefault();

But it seems that DBFunctions.CreateDateTime  missing.
Is it planned to get that function back, or is there any equivalent?
Regards. PV

@paulovila Is there a reason you want to use DbFunctions.CreateDateTime instead of new DateTime(...)?

I was porting code from EF6 to EF core, then I supposed that that limitation was going to be the same in EF core. I can't try my the code at the moment, but my quick question would be: Is 'new DateTime' captured as an expression and translated into sql?

@smitpatel Is new DateTime translated yet, at least on SQL Server?

No.

@divega to investigate what we did in EF6

What's the state here? I a also port from EF 6 to EF Core and also want this translated into the query.
We have a .GroupBy() clause and then select the following with included null coalesce operations, and want that to be executed on the DB:
.Select(group => new
	{
		In = group.Sum(entry => entry.ContentBytesIn),
		Out = group.Sum(entry => entry.ContentBytesOut),
		Key = DbFunctions.CreateDateTime(group.Key.Year, group.Key.Month ?? 1, group.Key.Day ?? 1, 0, 0, 0).Value,
	})
	.OrderBy(entry => entry.Key)

@gingters per previous comment, we're waiting for @divega to investigate.

Almost forgot about this, needless to say it was like 10 months ago ;) . Is there any plan at all to make it work with "new Datetime(" or "CreatrDatetime" ?.


Getting error while deploying the latest Bosh harbor release and see below

21:24:43 | Updating instance harbor-app: harbor-app/54ef00a2-4f54-49e2-9e61-77bbd0940e44 (0) (canary) (00:05:07)
L Error: Action Failed get_task: Task 2b5c7659-8861-4f55-4fff-6886ae81fda6 result: 2 of 2 pre-start scripts failed. Failed Jobs: enable-bosh-dns, harbor.
21:29:50 | Error: Action Failed get_task: Task 2b5c7659-8861-4f55-4fff-6886ae81fda6 result: 2 of 2 pre-start scripts failed. Failed Jobs: enable-bosh-dns, harbor.
Started Tue Jul 24 21:15:24 UTC 2018
Finished Tue Jul 24 21:29:50 UTC 2018
Duration 00:14:26
Task 35 error
Updating deployment:
Expected task '35' to succeed but state is 'error'
Exit code 1

Please package the log under /var/vcap/logs/harbor and upload to the issue.

Appreciate your help in this regards and providing you the request info below.
@reasonerjt  @stonezdj
Stemcell version:
bosh-vsphere-esxi-ubuntu-trusty-go_agent  3468.54*  ubuntu-trusty
Release version:
harbor-container-registry  1.5.1-build.7*  non-git
logs:
logs are packaged from this folder '/var/vcap/sys/log' and attached the logs.tar.gz
manifest used:
harbor.yml.txt file attached
logs.tar.gz
harbor.yml.txt

Thanks @goprasad – we'll take a look at the logs and get back to you soon!

We're investigating.
Let's keep this issue open, we'll provide update in this one.

Original issue closed


Any planned release of the project in the near future?

A few months ago I had a plan to make the first release this summer and wrote about this.  Unfortunately I am busy with other projects.  So it will not happen.  Sorry.
Now I can only say that the release will be this year and I will seriously work to make it happen before the year end.
Sorry again.

Thanks. I have a possibly use case for MIR in an audio plugin that I'm contributing to right now: https://github.com/sletz/VCV-Prototype for the VCV Rack application, using the Faust audio DSP language in dynamic mode, that is with the compiler embedded and a JIT to produce executable code on the fly. Using LLVM will be complex in this context, so I can wondering if our (already written..) MIR backend could be used instead.
How stable is MIR now? I've tested successfully on OSX. Does is run also on Windows and Linux ? Thanks.

How stable is MIR now? I've tested successfully on OSX. Does it run also on Windows and Linux ? Thanks.

I think MIR is stable.  I know only one wrong code generation problem with loop invariant motion optimization (-O3).  I did not work on this problem yet.  On the other hand I am thinking about removing LICM because it does not give an improvement I expected and it is a lot of complicated code.
MIR (and its API) will be probably extended but I think compatibility will be kept.
C2MIR will be less stable as I am working to implement target ABI compatibility.  x86-64 ABI is particular hard to implement.
LLVM2MIR is not finished yet (.e.g. no LLVM IR aggregate translation was implemented).  I also know that SSA lost copy problem exists in this translator. It means in rare cases a wrong MIR code can generated from LLVM IR.
I don't know about Windows port.  This port was done by logzero for his own purposes.  I'd like to tackle Windows port for the release but never started this work yet by myself.
Linux/MacOSX x86-64, linux ppc64be/le, aarhc64, and s390x are tested after each push and nobody reported any wrong code generation problem with them which was not resolved.

Thanks for the summary.
@logzero can you possibly describe what is the situation on Windows? Thanks.

Mir gen works (for me). Interpreter should work too. Real long doubles and multiple return values are not supported (would be extensions to Windows ABI).
I've toyed around with cmir, mostly to get more tests to run, but haven't had much time for it lately.
One thing I haven't pushed yet are the changes to the Makefile to make it build under Windows/msys2.

And I haven't tested the llvm bits at all, don't use them.

Mir gen works (for me). Interpreter should work too. Real long doubles and multiple return values are not supported (would be extensions to Windows ABI).
I've toyed around with cmir, mostly to get more tests to run, but haven't had much time for it lately.

Interesting - I had assumed that your work was in incomplete.

One thing I haven't pushed yet are the changes to the Makefile to make it build under Windows/msys2.

I use CMake and if I build on Windows would it work? Is there anything special about msys2?
Thanks and Regards
Dibyendu

I use CMake/MSVC and if I build on Windows would it work? Is there anything special about msys2?

You'd have to write the cmake script. Msys2 (mingw/gcc) is a bit more linux/posix friendly. Mir is built with -std=gnu11. The worst that can happen is that msvc complains about unknown functions (variants). But that is easy to fix too.


[test] Mark _Differentiable tests as unsupported in Swift-in-the-OS configurations

The new _Differentiable module is not available in any shipping OS release, but its public API currently doesn’t have availability, either.
Temporarily disable tests that import it when we’re testing with OS-provided libraries.
The typecheck test test/AutoDiff/stdlib/differentiable_protocol.swift imports _Differentable but still somehow succeeds in these configs, so leave that one enabled.
rdar://57975086

@swift-ci smoke test

Hi @lorentey,
I have a few questions, if you don't mind.

Is the robust fix for this issue to add @available attributes to public APIs in the _Differentiation module? If yes, what arguments should we specify in the @available attributes?

In the meantime, should we add the following:

// We currently lack availability information (rdar://57975086)
// UNSUPPORTED: use_os_stdlib

To all test/AutoDiff tests that import the _Differentiation module?

Is there a @swift-ci command we can run to prevent breakages due to missing UNSUPPORTED: use_os_stdlib?

Thanks! cc @rxwei @marcrasi

Hey @dan-zheng! 👋
In general, we need to describe availability for anything that ships in ABI-stable OS releases. For in-development Swift versions, this is usually done by adding an @available(macOS 9999, iOS 9999, watchOS 9999, tvOS 9999, *) incantation to all ABI-affecting declarations.
However, _Differentiable is a special case since (1) it's a brand new, standalone module and (2) it's underscored which makes it non-public and potentially not ready for ABI stability. We'll need to figure out what's the right way to handle it; but for now I believe it is okay to keep things as they are!
This PR was just a quick emergency fix to unblock our CI. We're still investigating and we will likely need to adjust or (preferably) revert this soon. (Especially since the back-deployment tests aren't failing on ci.swift.org... 🤔)

Update: Yep, the issue was a misconfiguration entirely on our side; I'll revert this in a moment.


Support ffill and bfill along chunked dimensions

[x] Closes #2699
[x] Tests added
[x] Passes pre-commit run --all-files
[x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Looks good — though I don't know the dask interface that well. The tests look good though.

Hello @dcherian! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file xarray/tests/test_duck_array_ops.py:

Line 32:1: F401 '.raises_regex' imported but unused

Thanks for the reviews. I'll merge in a couple of days if there are no comments.

looks good to me, although I would probably move the dask implementation to dask_array_ops.

Good idea. Done!

failures look unrelated
FAILED xarray/tests/test_distributed.py::test_dask_distributed_netcdf_roundtrip[netcdf4-NETCDF3_CLASSIC]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_netcdf_roundtrip[netcdf4-NETCDF4_CLASSIC]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_netcdf_roundtrip[netcdf4-NETCDF4]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_netcdf_roundtrip[h5netcdf-NETCDF4]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_read_netcdf_integration_test[netcdf4-NETCDF3_CLASSIC]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_read_netcdf_integration_test[netcdf4-NETCDF4]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_read_netcdf_integration_test[h5netcdf-NETCDF4]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_read_netcdf_integration_test[scipy-NETCDF3_64BIT]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_zarr_integration_test[True-True]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_zarr_integration_test[True-False]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_zarr_integration_test[False-True]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_zarr_integration_test[False-False]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_rasterio_integration_test
FAILED xarray/tests/test_distributed.py::test_dask_distributed_cfgrib_integration_test
FAILED xarray/tests/test_distributed.py::test_async - ImportError: cannot imp...
FAILED xarray/tests/test_distributed.py::test_serializable_locks - ImportErro...

@dcherian could you try restarting CI to pull in the latest dask release? xref https://github.com/dask/community/issues/150#issuecomment-826025006

@jrbourbeau thanks! It looks like it is working. Very unfortunate timing!

Yeah, sorry about that. At least it was an easy fix : )


Conflicting browser consideration

Header says "Google Chrome (macOS only)" but descriptions specifies "For Google Chrome on Mac OS and other non-Windows platforms"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5d53fedc-b37d-9c37-fd71-32088e1e88d3
Version Independent ID: 1d67c426-39ff-8646-139d-51cd5e9fe44e
Content: Azure AD Connect: Seamless Single Sign-On - quick start
Content Source: articles/active-directory/hybrid/how-to-connect-sso-quick-start.md
Service: active-directory
GitHub Login: @billmath
Microsoft Alias: billmath

@mflduncan Thanks for your feedback! We will investigate and update as appropriate.

@mflduncan Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.


feat(dateFilter): add support for STANDALONEMONTH in format (LLLL)

Fixes #13999

LGTM

Backported to v1.5.x as 3e5b25b.


add timeout to miri job in CI

Objective

When Miri is failing, it can be very slow to do so

Solution

Set the timeout for Miri to 60 minutes (it's 6 hours by default). It runs in around 10 minutes when successful

I'd probably tune this to like 30 minutes, but I'm fine with this at 60.

bors r+


Ensure cache miss to fix ESM compiling

In this discussion: https://github.com/styled-components/babel-plugin-styled-components/pull/234 that introduced the change to cacheKey in localNameCache, the author referenced a comment you made here:
https://github.com/styled-components/babel-plugin-styled-components/pull/230#discussion_r298018008
in which, you indicated that the false value there was to ensure that the traversal would continue again until you either picked up the import or dynamically injected it (I think?)
When the code was changed to account for this it failed to maintain the same behavior in the case that localName was intentionally left false.
This change ensures that the previous behavior (allowing the intentionally set false to fall through the cache lookup) remains, while ensuring a false value in the cache does not ALSO fall through.
Pardon the lack of supporting test. The only way I was able to reproduce this issue was when I was using rollup / babel to compile. I am still investigating what this difference is specifically to hopefully introduce a failing test prior to this commit.

@probablyup welp, I am fully at a loss for how to test this. Do you have any guidance? I am also happy to cowboy it and say "It works with rollup, thanks"

Can confirm that this fixes the issue for me 👍


[Question About Docs] Translation workflow

Is there a guide for a proper way of translating the documentation into another language by directly using a fork of this repository? I want to translate the latest version of documentation on a fork and publish it on GitHub pages? Any suggestions, recommendation?
Note: I am aware of the unofficial translations are done separately and then the link is added to translation pages.

No formal guide or workflow recommendations from us, we've never done it ourselves.


Groups of users

Is there any plans to add more groups?
Not only admin/user but something between? Especially interesting in read-only users.

It can be useful when chat is open for everyone. I ask because recently was a case when new user start to write abusive messages. It was required to set access only by invitation for a while.

@FoggyFinder we have a few things in flight for that.
One is a "web-public archive" feature, which makes it possible to have certain streams readable by anyone on the Internet without creating an account.
The second is a "report spam" feature, which makes it easy to quarantine accounts of people who are sending abusive messages.
Would some combination of these solve the problem you're looking to solve?  In that case, we can close this issue (if you search our issues you'll find those two; I'm just mostly AFK right no so can't look up quickly).

Would some combination of these solve the problem you're looking to solve?

Sadly, no. Disabling the user does not solve the problem - a new account is created and the attack is repeated.

Well, the web-public archive will do what you need for people who are that persistent.  But the concept behind "report spam" is that the first 1-2 people who see the abuse click it and the user's abuse is stopped (and any message they has sent hidden) so that the impact is slow.  The hope is that will help with less persistent attackers of that form (we've had a few who've shown up harass people in the chat.zulip.org community as well).
The one other setting that might be useful for anti-spam is blacklisting most "disposable email" type domains -- see that setting in the "organization permissions UI".  That at least can increase the effort required to send abuse.

@timabbott how about semi-readonly streams? As in streams that only certain accounts (specific emails, user groups) can post in?
Also, how about user(-permission)-groups? Let a set group of users permissions to perform some kind of action?

@gioragutt in master (for 1.9.0) we've added a feature that limit sending to a give stream to organization admins.  The plan is to extend that to allow specifying a user group as well, though that won't be in 1.9.0.
We're trying to avoid building a completely generic "group permissions" system for now, since that entails a huge amount of subtle security model complexity, and it's not needed for most applications.


Change integration test to use declared variable

Followup to #20246, changes the test to use the variable that's
already declared.
ping @MHBauer
Signed-off-by: Christopher Jones<EMAIL_ADDRESS>

LGTM 🐰

Oh shucks, it's not a big deal. LGTM.

it was bothering me! thanks guys :beers:


chore: enable semi eslint rule

Description Of Changes
Part of https://sendbird.atlassian.net/browse/UIKIT-3837
Enabled semi rule off-ed by https://github.com/sendbird/sendbird-uikit-react/pull/490 previously.

Cherry-picked from https://github.com/sendbird/sendbird-uikit-react/pull/521


[CLI]: wandb sweep command not prefixing runs with "python [filename].py"

Describe the bug
I have the following sweep.yaml file
program: main_fl.py
command:
  - ${args_no_boolean_flags}
method: random
metric:
  goal: maximize
  name: rank_0/test_acc
parameters:
  optimizer_name:
    value: "SGD"
[MORE PARAMETERS HERE]

I have ${args_no_boolean_flags} because I have certain parameters that are boolean flags. Solution obtained from here. When executing the above yaml with the wandb agent command I get the following error:
FileNotFoundError: [Errno 2] No such file or directory: '--optimizer_name=SGD'
It attempts to run my python script without prepending /usr/bin/env python main_fl.py
I am able to run the sweep when I don't include - ${args_no_boolean_flags} - But I need this because of the boolean flag variables.
Expected behaviour is to have the sweep execute with the addition of ${args_no_boolean_flags}
Additional Files
No response
Environment
WandB version: 0.16.2
OS: MacOS 14.3.1
Python version: 3.9.6
Additional Context
No response

Fixed by including
program: main_fl.py
command:
  - ${interpreter}
  - ${program}
  - ${args_no_boolean_flags}
method: random


Gradle 6.5.1: 'Could not find any convention object of type JavaPluginConvention'

Environment:
macOS, openjdk@11, SpringBoot 2.2.2.RELEASE

Jib version:
2.4.0
Build tool:

$ gradle --version

------------------------------------------------------------
Gradle 6.5.1
------------------------------------------------------------

Build time:   2020-06-30 06:32:47 UTC
Revision:     66bc713f7169626a7f0134bf452abde51550ea0a

Kotlin:       1.3.72
Groovy:       2.5.11
Ant:          Apache Ant(TM) version 1.10.7 compiled on September 1 2019
JVM:          11.0.8 (Oracle Corporation 11.0.8+11)
OS:           Mac OS X 10.15.6 x86_64

OS:

$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.15.6
BuildVersion:	19G73

Description of the issue:
Thanks for making Jib, it's a nice improvement over the naive Dockerizing a JAR approach I was heretofore using.
I recently inherited a Gradle project and trying to deploy it using Jib.
The trouble is, adding the Jib plugin and running it seems to fail, and I'm not sure what's wrong.
As I understand it, installing Jib (and most Gradle plugins) should usually be a matter of adding jib to the plugins section of the root build.gradle, like so:
plugins {
    id "net.ltgt.apt" version "0.20"
    id "io.spring.dependency-management" version "1.0.8.RELEASE"
    id "com.google.cloud.tools.jib" version "2.4.0"
}

However when I do that, gradle jib fails, in fact gradle by itself fails too. I added another plugin as an experiment (id "org.ajoberstar.pipeline-test" version "0.2.0-rc.13") and gradle still worked OK, so something about Jib seems to be a factor.
$ gradle

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'MyApplication'.
> Could not find any convention object of type JavaPluginConvention.

Meanwhile I was able to get Jib 2.4.0 working in a separate SpringBoot/Maven project, also Java 11, same machine, etc. So I suspect something related to Gradle+Jib interaction. Feels like it's probably not a Jib bug but something related to Gradle or perhaps this project. Not enough of a Java or Gradle expert to know what to do next...any tips would be appreciated. Thanks!
Expected behavior:
gradle jib --image=example should work in the usual way.
Steps to reproduce:
These repro steps are a 'best guess' b/c I am awaiting permission to share the source. I can, however, share the build.gradle and that's included below.

Create a Gradle springboot project running 2.2.2.RELEASE
Add id "com.google.cloud.tools.jib" version "2.4.0" to build.gradle:plugins
Run gradle

build.gradle contents:
plugins {
    id "net.ltgt.apt" version "0.20"
    id "io.spring.dependency-management" version "1.0.8.RELEASE"
    id "com.google.cloud.tools.jib" version "2.4.0"
}

ext {
    springBootVersion = "2.2.2.RELEASE"
    testcontainers = "1.12.0"
}

subprojects {
    apply plugin: "java"
    apply plugin: "net.ltgt.apt-idea"
    apply plugin: "io.spring.dependency-management"

    dependencyManagement {
        imports { mavenBom("org.springframework.boot:spring-boot-dependencies:${springBootVersion}") }
    }

    group = "com.example.application"
    version = "2.1.0"
    sourceCompatibility = "11"
    targetCompatibility = "11"

    repositories {
        mavenCentral()
    }

    configurations {
        developmentOnly
    	runtimeClasspath {
    		extendsFrom developmentOnly
    	}
        compileOnly {
            extendsFrom annotationProcessor
        }
    }

    dependencies {
        compileOnly "org.projectlombok:lombok"
        testCompileOnly "org.projectlombok:lombok"
        annotationProcessor "org.projectlombok:lombok"
        testAnnotationProcessor "org.projectlombok:lombok"
    }
}

Log output:
If it's helpful please just ask, happy to provide.
Additional Information:
Convention object, JavaPluginConvention :thinking: not sure what that means...
https://docs.gradle.org/current/javadoc/org/gradle/api/plugins/JavaPluginConvention.html

It looks like you're applying the jib plugin on the root project (which as far as I can tell, you don't want).
You root build.gradle could do something like
plugins {
   ...
    id "com.google.cloud.tools.jib" version "2.4.0" apply "false"
   ...
}

subprojects {
   ...
   apply plugin "com.google.cloud.tools.jib"
   ...
}

The error is just saying that the project you are applying jib on doesn't have the java plugin applied (since that's only applied on subprojects).

@onpaws I see that you've put a :+1: on the answer. I will close this issue for now. Please reopen if this issues persists or create a new issue if you encounter something new.

@loosebazooka thank you.
The apply false is new to me, I tried it and it has improved things, kind of.
$gradle

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/paws/projects/MyApplication/build.gradle' line: 16

* What went wrong:
A problem occurred evaluating root project 'MyApplication'.
> Could not get unknown property 'plugin' for project ':api' of type org.gradle.api.Project.

Since I last wrote I learned this project is a so-called multi-project build, with two includes in settings.gradle
pluginManagement {
    repositories {
        gradlePluginPortal()
    }
}
rootProject.name = 'MyApplication'
include 'application'
include 'api'

application & api both have their own settings.gradle  and I'm now trying to figure out if I need to add jib in each of those.
It seems like there would be one entrypoint for Docker, so not too sure how to say which project 'wins'...

TIL evidently GitHub won't let me re-open my issue apparently b/c I'm not a member of this repo - I guess maybe I should open a new one? If you have a preference, please let me know @loosebazooka , thanks :)

so in my example I missed a :
- apply plugin "com.google.cloud.tools.jib"
+ apply plugin: "com.google.cloud.tools.jib"

which is causing your error.
There is only one settings.gradle per gradle execution (and per multimodule project). It's not clear to me why this project your inherited has multiple settings.gradle. Unfortunately this is not the right forum to explore generic gradle build issues.

so in my example I missed a :
- apply plugin "com.google.cloud.tools.jib"
+ apply plugin: "com.google.cloud.tools.jib"

which is causing your error.
Awesome, have corrected that.

There is only one settings.gradle per gradle execution (and per multimodule project). It's not clear to me why this project your inherited has multiple settings.gradle. Unfortunately this is not the right forum to explore generic gradle build issues.

Whoops my mistake, I meant to say build.gradle files.
I think the colon might sort me out nicely though - I'll post back! Thanks again :)

Yep, moving forward on this for sure. Now, gradle runs again, and gradle jib is getting somewhere. Thanks! 🥳
Now, I'm moving onto the next one
Main class was not found, perhaps you should add a mainClass configuration to jib
I would think SpringBoot has a conventional "entry point" and I'll have to teach Jib about it.
So far I tried this:
jib {
        to.image = 'example'
        container.mainClass = 'Application'
    }

Which jib happily compiles, so I think that's good? However actually running the docker image fails...
Error: Could not find or load main class Application
Caused by: java.lang.ClassNotFoundException: Application

Intending to research how Spring works. Thanks again @loosebazooka !

container.mainClass = 'Application'

Are you using the default Java package (unnamed package)? Otherwise, you should use a fully-qualified class name. For example, com.example.Application.

And make sure to apply the Jib plugin only in the application subproject that has a main class. We've seen people incorrectly setting up a multi-module project where they apply Jib to subprojects that create dependencies for the main application subproject.

Thanks @chanseokoh! That was indeed what I tried next.
In the end, things tentatively seem to be working when I follow the steps @loosebazooka  outlined in this issue.
https://github.com/GoogleContainerTools/jib/issues/1722
So I think this issue is safe to close.
One day, I'm not sure if it's possible, but I hope to learn how to properly extract node_modules dependencies the way you guys have cleverly handled here in the Java world. Here's to the time we save with fast image builds 🥳

And make sure to apply the Jib plugin only in the application subproject that has a main class. We've seen people incorrectly setting up a multi-module project where they apply Jib to subprojects that create dependencies for the main application subproject.


spell wrong

https://github.com/haorenW1025/completion-nvim/blob/ad3119580b70c7a006c09a130f2c5e0c98f49f59/plugin/completion.vim#L36-L38
I think this is spell wrong.

That's true! It's been fixed now, big thanks for pointing it out!

quick response ^


add sketch of attestation results format

CDDL sketch that tries to capture our conversation with JSON and CBOR
serialisations
framework for checking integrity of CDDL for both JSON and CBOR
framework for adding samples and checking them against the current
CDDL

rebased on tip to pull in Sergei's 3af2d65


Reduce Memory allocation using strings.Builder

As this library is currently using append which cost huge in terms of memory allocation. If we introduce strings.Builder instead of append, allocation will drastically reduce.

Thank you for your interest in making sjson better, and I'm always happy to explore ways to make any of my projects faster.
In my experience append is one of the more efficient ways to auto-grow and copy bytes in golang.
As I understand string.Builder is mostly a friendly wrapper for append, with also the addition of a zero-cost []bytes -> string using an unsafe cast.
func (b *Builder) WriteString(s string) (int, error) {
	b.copyCheck()
	b.buf = append(b.buf, s...)
	return len(s), nil
}

func (b *Builder) String() string {
	return *(*string)(unsafe.Pointer(&b.buf))
}

I must be missing something. Please elaborate further.


[Petition] Inventory Changer

What if you replaced skin changer with an inventory changer? That would be better (and pretty sick) in my opinion. If possible can you do it please?

I don't see any point in this, since skin changer and inventory changer work the same way.
But if anyone can, I wouldn't be angry in any way :)

techprimedev for me the main point of adding a inventory changer to the cheat is that it add's the functionality of having native ct or t sided weapons and allowing the weapons to show up in the buy menu. But you are right its not necessary.

Inventory Changer is way better than casual skin changer unless you want to use custom skins. For example Bayonet | Whiteout. You can fake open cases, add music kits, badges, etc. with Inventory changer

techprimedev para mim, o ponto principal de adicionar um trocador de inventário ao truque é que ele adiciona a funcionalidade de ter armas nativas de ct ou t e permitir que as armas apareçam no menu de compra. Mas você está certo, não é necessário.

if you see a skin in the inventory and purchase menu for you it is important, who am I to prevent this.
If anyone can do that, I would be grateful to see the code :)

Item Changer will make Skin Changer looks more legit so +1

Item Changer will make Skin Changer looks more legit so +1

legit? lmao


[BUG] HarvesterMachines resources are not cleaned up

Describe the bug
HarvesterMachine resources are not cleaned up after removing Harvester RKE2 clusters that contained machines which were not fully provisioned.
This causes Rancher logs to be spammed with errors and increases the load on local cluster control plane over time due to constant retries.
To Reproduce

Provision a Harvester RKE2 cluster in such way that provisioning of the VMs will not succeed, e.g. by attaching VMs to a VLAN w/o DHCP.
Delete the "failed" cluster
Check HarvesterMachine resources in the local Cluster
Check Rancher logs

022/01/05 12:17:01 [ERROR] error syncing 'fleet-default/thorenexttry-pool1-fb8e624e-zmmkt': handler machine-provision-remove: cannot delete machine thorenexttry-pool1-fb8e624e-zmmkt because c │
│ reate job has not finished, requeuing                                                                                │
│ 2022/01/05 12:17:01 [ERROR] error syncing 'fleet-default/ubuntucluster-pool2-dfa5c3cc-btjtx': handler machine-provision-remove: machines.cluster.x-k8s.io "ubuntucluster-pool2-dfc84888-5cqzx" n │
│ ot found, requeuing                                                                                │
│ 2022/01/05 12:17:01 [ERROR] error syncing 'fleet-default/ubuntucluster-pool2-dfa5c3cc-hl22q': handler machine-provision-remove: machines.cluster.x-k8s.io "ubuntucluster-pool2-dfc84888-zv2sc" n │
│ ot found, requeuing                                                                                │
│ 2022/01/05 12:17:01 [ERROR] error syncing 'fleet-default/ubuntucluster-pool2-dfa5c3cc-z6snq': handler machine-provision-remove: machines.cluster.x-k8s.io "ubuntucluster-pool2-dfc84888-rxbhx" n │
│ ot found, requeuing                                                                                │
│ 2022/01/05 12:17:01 [ERROR] error syncing 'fleet-default/cs2canal-pool1-a1661b5e-x9dwd': handler machine-provision-remove: cannot delete machine cs2canal-pool1-a1661b5e-x9dwd because create jo │
│ b has not finished, requeuing

HarvesterMachine CR:
cs2canal-pool1-a1661b5e-x9dwd.yaml.txt

Hi @joshmeranda , can you help to check on this one? You can check with @dweomer on details.

@yasker The rancher job, and the pod on the harvester cluster are both left without being cleaned up. Once rancher sees the unfinished complete job it looks like it ignores the related resources.
I think it depends on what approach makes the most sense. If we are going to handle how we handle unfinished create jobs when deleting clusters thats a rancher issue, but if we want to change how we handle the failed create job that would be a node driver issue.

It's probably a Rancher issue as I have seen this issue with other node drivers, e.g. vSphere.

@TachunLin @lanfon72 can we please re-validate this with Harvester v1.0.3 + Rancher v2.6.7 when it is released since this is more considered as an upstream issue? thanks.

@guangbochen is this has been fixed or we just need to re-validate the bug still here?

@lanfon72 There is a PR up for this issue but it has not been merged.

As this issue opened 8 months ago, It should happened in the combination: Rancher v2.6.3 with Harvester v1.0.0.
Able to be reproduced in:

Rancher v2.6.3 with Harvester v1.0.0
Rancher v2.6.6 with Harvester v1.0.0
Rancher v2.6.3 with Harvester v1.0.3
Rancher v2.6.6 with Harvester v1.0.3

Log message be reduced in:

Rancher v2.6.7-rc9 with Harvester v1.0.0
Rancher v2.6.7-rc9 with Harvester v1.0.3

@ttpcodes can u please help to check if this is resolved with new Rancher versions likev2.6.9 + Harvester v1.1.1 ? thanks.

@ttpcodes Could you help check https://github.com/harvester/harvester/issues/1774#issuecomment-1371821095, thank you!

Validate on Rancher v2.6-head + Harvester v1.1.2-rc1. If HarvesterMachine is not removed, Cluster will be kept in the Deleting phase. So this issue has been fixed.  Following are my testing steps:

Use vagrant-pxe-harvester to provision a Harvester cluster.
Import the Harvester cluster to Rancher v2.6-head.
Create a RKE2 cluster.
When the first VM is provisioned and before it gets an IP. Run sudo systemctl stop isc-dhcp-server.service in pxe server.
After the Harvester cluster get into NotReady. Remove the RKE2 cluster in Rancher.
Run sudo systemctl start isc-dhcp-server.service in pxe server.
RKE2 and HarvesterMachine will be removed in the Rancher server.

There have a similar case that if Rancher can NOT access Harvester (either cluster-registration-url changed or harvester cluster is not accessible), delete cluster will stuck then HarvesterMachines will not be cleaned up.


Support passing --cert and setting cert in uv.toml

With the merge of #6591 it is now possible to trust hosts to disable certificate verification, but compared to pip the "other way" around, providing  a valid cert, is still a bit a bit lacking. I know it's currently possible to set a path to a cert file using SSL_CERT_FILE, but I think it would be more in line with pip and more consistent if --cert CERTFILE could be passed on the command line, and uv.toml got an option to set the cert file as well.

Possible dupe of https://github.com/astral-sh/uv/issues/6572#issuecomment-2311249402


Modal dont work while debugging is active

Environment
System:
OS: Windows 10
CPU: (4) x64 Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz
Memory: 419.83 MB / 3.91 GB
Binaries:
Node: 10.16.3 - C:\Program Files\nodejs\node.EXE
Yarn: 1.17.3 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.9.0 - C:\Program Files\nodejs\npm.CMD
IDEs:
Android Studio: Version  <IP_ADDRESS> AI-191.8<IP_ADDRESS>91312
Platforms
Android
Versions

Android: 8.1.0

react-native-modal: 11.3.1

react-native: 0.60.5

react: 16.8.6

Description
All components that use react-native-modal work perfectly even with animations. The problem exists when remote debug mode is active. The modal does not open at all.
Reproducible Demo
Create any screen that has a modal and try to open it using any button with remote debug mode enabled.

Hey @Skynear2 , unfortunately IIRC this is a react-native's modal problem and with can't fix it from our side.

Hey @Skynear2 , unfortunately IIRC this is a react-native's modal problem and with can't fix it from our side.

Is that really your answer? I haven't encountered such problems in other libraries. I think you should handle this issue.


gnomeExtensions: rename extensionUuid to uuid

Motivation for this change
If you take a look at some manual packaged extensions they all have a variable called uuid, some examples:

https://github.com/NixOS/nixpkgs/blob/master/pkgs/desktops/gnome/extensions/EasyScreenCast/default.nix#L28
https://github.com/NixOS/nixpkgs/blob/master/pkgs/desktops/gnome/extensions/appindicator/default.nix#L19
https://github.com/NixOS/nixpkgs/blob/master/pkgs/desktops/gnome/extensions/arcmenu/default.nix#L27
https://github.com/NixOS/nixpkgs/blob/master/pkgs/desktops/gnome/extensions/caffeine/default.nix#L14

Current usage since all packages had a uuid:
let
  extensions = [
    pkgs.gnomeExtensions.appindicator
    pkgs.gnomeExtensions.caffeine
    pkgs.gnomeExtensions.clock-override
    pkgs.gnomeExtensions.dash-to-dock
    pkgs.gnomeExtensions.dynamic-panel-transparency
    pkgs.gnomeExtensions.fuzzy-app-search
    pkgs.gnomeExtensions.unite
    pkgs.gnomeExtensions.window-is-ready-remover
  ];
in {
  home-manager.users.rhoriguchi.dconf.settings."org/gnome/shell".enabled-extensions = map (extension: extension.uuid) extensions;
}

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Duplicate of https://github.com/NixOS/nixpkgs/pull/126921

Duplicate of #126921

Sorry, ma bad.


Whitesource SSO info

Whitesource info

WhiteSource has been replaced by Mend.io per https://www.whitesourcesoftware.com.
This PR can probably be closed.


HotBackup MySQL (mysqlbackup) is it possible? Which parameters?

Hello,
I am using your tool on a software and it works great for a daily backup, when there is no reading/writing.
My application is evolving and we are searching for a Hot Backup solution like "mysqlbackup" is mentioned on https://backup.ninja/news/hot-warm-and-cold-backups-mysql  that can make a hour by hour backup during normal reading/writing operation is happening parallelly on the database.
Is it possible?
What parameters or conditions or limitations I should look for?
Any help is welcome,
Congratulations for the current work on this tool,
Regards,
Miguel

MySqlBakup.net able to work without the need to take the application down or make it offline. It can runs without locking the tables. I can think of 2 downsides:

During the backup process running, the MySQL database might have slower response to user/app request. (Since the database is busy exporting data)
Lets say the backup process takes 10 minutes to complete (depending on your database size), any data changes during this time have a high change of not being included in the backup.

For the parameters, you can use the default settings.
My recommendation of workout is to use a MySQL replication that the hot backup can be run on.
So the main primary database serves for user request, and the replication serves for the hot backup. This configuration has lower impact on the primary database performance while the hot backup is running.

Here is the performance benchmark that I've done a couple of days ago. The benchmark result can serves as a reference to help you in designing the hot backup solution.


New Unsaved Records with Formulas

Describe the problem to be solved
When entering a new record, it can be helpful to enter multiple fields, and see the results of formulas associated with your entries, before saving the new record. This wish applies both to published forms and in-document card views.
Describe the solution you would like
This proposal introduces the concept of a “new unsaved record” (alternatively a “draft record”) in Grist, and describes how formulas may be made to work for unsaved records, with some differences and limitations compared to regular formulas.
Proposal: New Unsaved Records with Formulas

Great idea, indeed.
And the draft record concept would be a great way to solve the other issues regarding record validation as well:
#849, #161


Work with OptionSets

Hi @RafaelCavazza,
I just found your library and am liking the API. I'm trying to set an option set value for a lead and couldn't find any OptionSet class or example in the UnitTests. How do I set an optionset value?
Cheers
Michael

Hi Michael,
Sorry for the long delayed.
The API uses the numeric value to set and get the optionset values.
You can simple:
entity['my_optionset'] = 1;
I culdn't keep up with the project due to the lack of free time, but I'm back to working on it again!


Please support deerma.humidifier.jsq buzzer and child lock

Hi!
Thank you for your work, this is a wonderful integration. i use deerma.humidifier.jsq humidifier which i can also control. Whats missing:

Child lock
Buzzer
Please add these.

Thank you! :)

This device seems to only support beeping, not child lock, if the MIHome APP has it, please send me a screenshot.
Add a buzzer switch entity:
# configuration.yaml
xiaomi_miot:
  device_customizes:
    deerma.humidifier.jsq:
      switch_properties: alarm


Apply fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage     97.63%   97.63%
  Complexity       82       82
=========================================
  Files            14       14
  Lines           211      211
=========================================
  Hits            206      206
  Misses            5        5

Impacted Files
Coverage Δ
Complexity Δ

src/ListenerApplier.php
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

src/Hooks/EloquentHooks.php
100% <ø> (ø)
6 <0> (ø)
:arrow_down:

src/RouteConditionApplier.php
100% <ø> (ø)
10 <0> (ø)
:arrow_down:

src/Otherwise.php
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

src/Facades/HeyMan.php
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

src/HeyManServiceProvider.php
94.73% <ø> (ø)
4 <0> (ø)
:arrow_down:

src/Hooks/ViewHooks.php
100% <ø> (ø)
5 <0> (ø)
:arrow_down:

src/Hooks/EventHooks.php
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

src/Responder.php
92.5% <100%> (ø)
19 <1> (ø)
:arrow_down:

src/YouShouldHave.php
100% <100%> (ø)
12 <0> (ø)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 987e03a...31e983c. Read the comment docs.


Change Logger to use TraceSource and support for wildcard configuration

As discussed under https://datastax-oss.atlassian.net/browse/CSHARP-171

Looks really good, I will test it to see whats the behaviour that used the old pattern (Trace.Listeners.Add()) as soon as possible.

The TraceSource implementation is more straightforward than the one currently in the driver and its definitely an improvement. Also, the wildcard source is cool workaround to allow some extensibility without depending on an external package.
For current users attaching a listener to Trace, merging this patch will cause their apps to stop receiving log events.
There is more info in the ticket but I think we should provide more extensibility (via NLog) without breaking the current functionality.


Wrong Quickly URL

Seems like the Quickly URL has been changed to: https://github.com/quickly/quickly

Fixed, thanks


makefile fixes: setting DEPFLAGS_OS only if it hasn't been set by the user; adds O option to building Sundials

Summary
This fixes:

#1041. Currently, the makefile doesn't allow the user to set DEPFLAGS_OS, instead forcing it to be the default.
#1043. The makefile builds Sundials with the default optimization level. Changing this so it's set the optmization level set by the user.

Tests
There are no unit tests to check (it's make). There is an easy way to check, though.
From develop:
echo DEPFLAGS_OS=foo > make/local
make print-DEPFLAGS_OS

This should result in (on Mac or Linux):
DEPFLAGS_OS = -MM -E
```.

When the same thing is run with this branch, it will should print what we expect:

DEPFLAGS_OS = foo

## Checklist

- [x] Math issue #1041, #1043.

- [x] Copyright holder: Generable

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
      - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
      - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

- [x] the basic tests are passing

    - unit tests pass (to run, use: `./runTests.py test/unit`)
    - header checks pass, (`make test-headers`)
    - docs build, (`make doxygen`)
    - code passes the built in [C++ standards](https://github.com/stan-dev/stan/wiki/Code-Quality) checks (`make cpplint`)

- [x] the code is written in idiomatic C++ and changes are documented in the doxygen

- [x] the new changes are tested

Sorry, was playing bridge!
On Thu, Sep 27, 2018 at 20:26 Daniel Lee<EMAIL_ADDRESS>wrote:

That said, it'll go through testing, so it'll be a few hours before it
should be merged.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/1042#issuecomment-425282837, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAxJ7N-gQ-EAJVyFrYOtmTQD9Ba38Z3yks5ufWyhgaJpZM4W9qJK
.

--
📲

The failure looks like one due to failing to send to a “null” email address. The tests ran fine.

As it turns out, the new makefiles refactor has been generating tests in /tmp, which is not on a filesystem with gigabytes of free space in some of our Jenkins nodes. Any chance we can configure that?

Thanks. Sorry about that. I had looked at the log itself and I swore on my
phone last night, it showed as everything having run. I'll revert it now,
reopen the PR and try to fix it that way.
Sorry about that.
On Fri, Sep 28, 2018 at 8:28 AM seantalts<EMAIL_ADDRESS>wrote:

As it turns out, the new makefiles refactor has been generating tests in
/tmp, which is not on a filesystem with gigabytes of free space in some
of our Jenkins nodes. Any chance we can configure that?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/1042#issuecomment-425419866, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZ_F8meOiJr3g9qDRz1MYgwmwYWxqssks5ufhX4gaJpZM4W9qJK
.

No idea why it's writing to /tmp. I don't even know what process would do
that....
On Fri, Sep 28, 2018 at 8:35 AM Daniel Lee<EMAIL_ADDRESS>wrote:

Thanks. Sorry about that. I had looked at the log itself and I swore on my
phone last night, it showed as everything having run. I'll revert it now,
reopen the PR and try to fix it that way.
Sorry about that.
On Fri, Sep 28, 2018 at 8:28 AM seantalts<EMAIL_ADDRESS>wrote:

As it turns out, the new makefiles refactor has been generating tests in
/tmp, which is not on a filesystem with gigabytes of free space in some
of our Jenkins nodes. Any chance we can configure that?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/1042#issuecomment-425419866, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZ_F8meOiJr3g9qDRz1MYgwmwYWxqssks5ufhX4gaJpZM4W9qJK
.

@seantalts: this is what I saw to think that it built properly:
http://d1m1s1b1.stat.columbia.edu:8080/job/Stan/job/downstream_tests/176/console
Sorry -- I misinterpreted that result. Mind helping me find out where it failed? Searching for "failure" only shows up at the end. There are no "***" in there (that's when there's a make error). I don't see any failed tests either.

@seantalts, by any chance, is the ec2 instance configured with ccache? I've run into problems with that before.

Actually, /tmp is just be where clang puts all temporary files (and then clang was crashing on this box due from me trying to tune N_TESTS)... I'm trying to figure out how to change that because on the ec2 instance the tmp directory is very slow in addition to being very small :P No ccache, just normal clang behavior it seems.

I found a stackoverflow post that might help:
https://stackoverflow.com/questions/31493663/unable-to-compile-with-make-fatal-error-no-space-left-on-device
It says to export a variable called TMPDIR with a folder of choice. https://en.wikipedia.org/wiki/TMPDIR

Ok. Glad to confirm that ccache isn't on there.
So... the question is does this change actually change the build process enough where it'll continue to blow out /tmp? or was it due to the N_TESTS thing?

@syclik Re parsing test failures (this is important): The link you sent has the last two lines:
ERROR: CmdStan » downstream_tests #199 completed with status FAILURE (propagate: false to ignore)
Finished: FAILURE

Emailing (or not emailing) never hurt anybody; don't skip the bottom lines in favor of some email noise further up :P Also I just always start by looking at the blue ocean link (which is the one you get when you click on the test results on a PR) - there was a lot of work put into making that page highlight the most important errors.
You can get to the blue ocean page from the "Open Blue Ocean" link on the left of the console output link.
We need to change /tmp to make it faster and because tmp is too small to be reliably used for anything like this on this machine. The environment variables you linked to appear to be new in clang 8 (we're on 6). I'm looking at other options...

Thanks. What I couldn't find was how the downstream_tests failed. I assumed
the absence meanr it was ok.
And thanks for letting me know about the email not actually failing the
build. Btw, I've searched the whole log for any real failures. I'll look at
the blue ocean link next time.
So... do you think this failure was an error in this PR or something else?
It wasn't clear to me whether these changes just messed something up. If it
did... maybe we need to be compiling with -Os or -O2 on these boxes. We've
already had to do that with the few Windows tests we have (the compiler
can't be compiled with O3).
On Fri, Sep 28, 2018 at 8:51 AM seantalts<EMAIL_ADDRESS>wrote:

@syclik https://github.com/syclik Re parsing test failures (this is
important): The link you sent has the last two lines:
ERROR: CmdStan » downstream_tests #199 completed with status FAILURE (propagate: false to ignore)
Finished: FAILURE
Emailing (or not emailing) never hurt anybody; don't skip the bottom lines
in favor of some email noise further up :P Also I just always start by
looking at the blue ocean link (which is the one you get when you click on
the test results on a PR) - there was a lot of work put into making that
page highlight the most important errors.
You can get to the blue ocean page from the "Open Blue Ocean" link on the
left of the console output link.
We need to change /tmp to make it faster and because tmp is too small to
be reliably used for anything like this on this machine. The environment
variables you linked to appear to be new in clang 8 (we're on 6). I'm
looking at other options...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/1042#issuecomment-425425497, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZ_Fwt_YUZo0tXHQkovK6LZrvrU6Tg5ks5ufhsqgaJpZM4W9qJK
.

@seantalts, I'm guessing you took down the EC2 node?

(no worries if you did; just wanted to make sure it was you and I didn't completely tank an EC2 instance)

Yeah, sorry, it's not working and I'm trying to fix it.
On Fri, Sep 28, 2018 at 9:03 AM Daniel Lee<EMAIL_ADDRESS>wrote:

(no worries if you did; just wanted to make sure it was you and I didn't
completely tank an EC2 instance)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/1042#issuecomment-425428725, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAxJ7JaQ50TjEOSrb6SAvjKhn_S9cX-mks5ufh4KgaJpZM4W9qJK
.


Invalid configuration object. ... The provided value "<FULL_PATH>/dist" is not an absolute path!

After upgrading webpack to 2.3.0 I get this error (twice, while running "webpack --config webpack.config.vendor.js"):
Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.  - configuration[0].output.path: The provided value "c:/FULL_PATH/dist" is not an absolute path!
I think it has something to do with this config section:
	const clientBundleConfig = merge(sharedConfig, {
		output: { path: path.join(__dirname, 'wwwroot', 'dist') },
		module: {
			rules: [
                { test: /\.css(\?|$)/, use: extractCSS.extract({ use: 'css-loader' }) }
			]
		},
		plugins: [
            extractCSS,
            new webpack.DllPlugin({
            	path: path.join(__dirname, 'wwwroot', 'dist', '[name]-manifest.json'),
            	name: '[name]_[hash]'
            })
		].concat(isDevBuild ? [] : [
            new webpack.optimize.UglifyJsPlugin()
		])
	});

All work with webpack 2.2.1. Any idea what to change?

Here is the webpack 2.3.0 release log https://github.com/webpack/webpack/releases
See the Bug Fixes section an "Resolve output path if relative output path is given via CLI", is this the issue?

check the issue here
for now i simply replaced first letter to capital and all worked
const capitalizeFirstLetter = (string) => string.charAt(0).toUpperCase() + string.slice(1);
output: { path: capitalizeFirstLetter(path.join(__dirname, clientBundleOutputDir)) },
path: capitalizeFirstLetter(path.join(__dirname, './ClientApp/dist'))
but they will probably fix it soon

Solved, thank you.

@skorunka Glad you got a solution. Is there something you think we need to change in the default templates, or was the problem something specific to your project?

@SteveSandersonMS this is a breaking change in webpack 2.3.1 Issue:  https://github.com/webpack/webpack/issues/4530
Lowecase vs uppercase battle in windows agains alot of other tools as always. :)
I am having the same problem.

@SteveSandersonMS No, nothing to change, it is exactly as @asadsahi has written.
Actualy I think the following solution is a bit better then the above one:
__dirname = __dirname.charAt(0).toUpperCase() + __dirname.slice(1);
put the above line to both webconfig files right after the first set of constants definition

Agree with @skorunka . Tackling __dirname on a higher level works if there are some other webpack plugins you are using (in my case I was using webpack-dll-plugin) which was still breaking as we don't control its usage of __dirname.

Webpack 2.3.2 fixed the issue. So you no longer need to tweak the config files.

I'm having this problem with webpack 3.10.0 ...  I tried pinning to webpack 2.3.2 and that didn't help?

Hi everybody.
I'm simply trying to use webpack but i can't solve this error.
This is my webpack.config.js :
entry: './main.js',
output: {
path:'/js',
filename: './bundle.js',
},
and the output is:
Hash: d4ed964f3c24ef712293
Version: webpack 4.10.2
Time: 27081ms
Built at: 2018-05-31 16:56:46
Asset     Size  Chunks             Chunk Names
./bundle.js  108 KiB       0  [emitted]  main
Entrypoint main = ./bundle.js
[8] ./node_modules/css-loader!./app.css 259 bytes {0} [built]
[9] ./app.css 1.04 KiB {0} [built]
[10] ./App.jsx 2.44 KiB {0} [built]
[20] ./main.js 470 bytes {0} [built]
+ 17 hidden modules
but the bundle.js is not created on selected location.
any one please help me .


feat: support loading inline module code

Can provide module code as a string when creating a worker.
example,
const worker = createWorker({
....
maybeEntrypoint: "file:///src/index.ts",
maybeModuleCode: 'Deno.serve((req) => new Response("Hello from Module Code"));',
})

This PR seems to be the one that broke my Deno Edge Function Environment - it stopped working on the 4th of September. Not sure what it's doing, as I'm not fully understand the codebase, but: this is the only PR and the release of the day it broke, and it relates to module code / loading


pngquant is no longer needed

Tachyon uses pngquant to compress PNG files, but this hasn't been needed since Sharp 0.28 which includes built-in support for generating compressed palette PNGs.
Ref: https://github.com/lovell/sharp/issues/478#issuecomment-847150787
This means the separate pngquant processing in Tachyon could be replaced with the palette argument for Sharp.

Nice find @johnbillion !


Inconsistent behavior between shady and shadow dom with content parsing

Description
There is a different behavior under shadow and shady dom regarding the parsing and stamping of content inside dom-if. Shadow dom parses the content too early, while shady dom parses correctly.
Live Demo
https://jsbin.com/vegotujogu/1/edit?html,console,output
Steps to Reproduce

Open the JSbin
Observe that with window.Polymer.dom = 'shadow'; the console shows 2 messages after 1 second
Comment window.Polymer.dom = 'shadow';
Observe that the console shows 1 message after 1 second and 1 message after 2 seconds

Expected Results
In both shady and shadow dom, the second message x-bar dom-if stamped is shown after 2 seconds.
Actual Results
In shady dom, x-bar dom-if stamped is shown after 2 seconds, while in shadow dom it is shown after 1 second at the same time that x-foo dom-if stamped is shown
Browsers Affected

[x] Chrome
[ ] Firefox
[ ] Edge
[ ] Safari 9
[ ] Safari 8
[ ] IE 11

Versions

Polymer: v1.4.0
webcomponents: v0.7.21

Closing this as working as intended.


Zed configs don't work

Describe the bug
The Zed configs outlined in the different server Readmes don't work.
To Reproduce
Steps to reproduce the behavior:

Try adding the context_servers block to settings.json file for Zed:

  "context_servers": {
    "mcp-server-fetch": {
      "command": "uvx",
      "args": ["mcp-server-fetch"]
    }
  },

Get the error: expected struct

Expected behavior
Settings should work.

Fix merged.


Idea: Configurable message send/lookup per class (or object)

There is object-as-method, where the VM calls #run:with:in: on an object that claims to be a method (inside a class' method dictionary). Then there is #doesNotUnderstand:, where the VM handles missing keys in that dictionary.
Would be nice to have configurable message sending (and lookup) as a tangible, wholesome concept....
Getting rid of ProtoObject could be a motivating factor to move forward. Simple, fast proxies, ... without the need for extra design patterns like the thing you always have to do when implementing your own #doesNotUnderstand:...

Self-assigned. Caffeine currently implements my 2002 proxy design, in which instances of a class included in the special-objects array have different method dispatch behavior, via the VM. That design does not use >>doesNotUnderstand: at all; the proxy class can be anywhere in the class hierarchy, and there is no need for class ProtoObject at all (or class SystemDictionary, for that matter). It forwards absolutely all messages correctly, even those implemented with special bytecode or primitive support, without constraining the name of any class or method.
I never needed it to be configurable; I'll think about how that might be done.


0.17.17 Windows Installer

"This installation package could not be opened. Contact the application vendor to verify that this is a valid Windows Installer package."

Not alot of details here. Can you share how you downloaded the package (from the downloads page, omnitruck, etc). bitness (or file name), how you installed it (direct call to MSIEXEC or double clicked MSI file) and what windows version you are installing to? Thanks!

My mistake. Downloads page, chefdk-0.17.17-1-x86.msi, double clicked msi file, Windows 7.

ok thanks. I'm not able to reproduce on a windows VM here.