Front end mock

Front end mock built separately with Next.js and then merged in.
Current functionality includes:
Create, Remove, Update, and Describe functionality.
WIP: card structure to be changed to better conform with whimsical.

Netlify is now integrated as part of #23

@Behold3th per our discussion is it okay if we close this PR. We can work on my new branch instead now that i've merged in your changes with it?

@Behold3th per our discussion is it okay if we close this PR. We can work on my new branch instead now that i've merged in your changes with it?

yep, all good!


Method for creating wire-format dns.Header from *dns.Msg?

Hello,
I have access to a *dns.Msg, and another system wants me to give it the wire-format representation of the header flags (basically dns.Header.Bits). Looking around in the docs I have not been able to find a way to go from a *dns.Msg to a dns.Header or just the Bits fields or similar, however I have found some internal code that basically does this here:
https://github.com/miekg/dns/blob/b18c05cc13607aacb056a0f483e0f4c9229a1d67/msg.go#L752
Using that code and a copy of the unexported consts at https://github.com/miekg/dns/blob/b18c05cc13607aacb056a0f483e0f4c9229a1d67/types.go#L190... I could definitely create my own function for this but I thought I would ask if it would be in-scope for the library to supply something like that.

you'll need to Pack your msg https://pkg.go.dev/github.com/miekg/dns#Msg.Pack
and get the first 12 bytes and index further in there.

@miekg thanks for the response! In my case where I don't really need a full header, only the equivalent of the Bits field in https://pkg.go.dev/github.com/miekg/dns#Header, would it still be preferable to Pack the message and index into the resulting bytes, or should i just reproduce https://github.com/miekg/dns/blob/b18c05cc13607aacb056a0f483e0f4c9229a1d67/msg.go#L755-L779 using the existing parsed fields in my Msg?


Able to take screenshots after app is resumed fro background

I used this package to prevent screenshots in my flutter app .
In ios after the app is sent to background , a message pops in the debug console .
message =>
[iOS][Snapshotting] Snapshotting a view that has not been rendered at least once requires afterScreenUpdates:YES.
and when the app is resumed , I was able to take screenshots.
After restarting everything was normal again.

Faced the same issue. Did not find a better option than adding it in the didChangeAppLifecycleState
AppLifecycleState? _notification;    @override   void didChangeAppLifecycleState(AppLifecycleState state) {       case AppLifecycleState.resumed, :          _noScreenshot.screenshotOff();         break;       case AppLifecycleState.inactive:          _noScreenshot.screenshotOff();         break;       case AppLifecycleState.paused:         _noScreenshot.screenshotOff();         break;       case AppLifecycleState.detached:         print("app in detached");         break;     }   }

@Kronos-2701 What @oncleguigs  did is correct and how it should be used.


*: kv range to return current revision

This changes the behavior of KV's range and tx range to return
current revision rather than range revision. This makes populating
range response header easier.

The integration test that I just added passes, but this breaks every other test with range revision.
I can fix those, but will wait for Xiang's review on this change first.
Thanks,

LGTM. Thanks.

Thanks. Will merge if all tests pass.

@gyuho Ideally, we can document the API better. The returned rev is the current revision of the KV when the operation is executed.

@xiang90 Sure, just added // The returned rev is the current revision of the KV when the operation is executed. to kv interface godoc. Thanks.


Support for the not() function?

Is there any timeline for supporting the Xpath not() condition?
//node()[not(self::script)]

thanks,supported now.

Wow, thanks. I tried using count(self::script) == 0 as a work around but it doesn't work for all cases.


Replay pipeline using cli exec by downloading metadata

closes  #1155

Sponsored by Kithara Software GmbH

more debug things could be added here later ... like to halt an pipeline and let exermine the curent state (e.g. dont cleanup the workspace) etc ...

second screenshot is with tab klicked .. it crrently only contains an dropdown and an button.
If you know a beter UI/UX please tell :) thats the best i did come up with

Secret values should not be returned, could be replaced with something like <redacted>

there should not be any secrets in this metadata else we do have a problem

What about running multiple workflows. From a UX perspective I would actually prefer some kind of Debug locally button to download all workflows as one file opening that file and running it with cli exec. #3967 should allow us to correctly run multiple workflows with depends_on.

@anbraten added your pull as todo comment into the cli exec code ... 040b77348bfb561b04050def36fb5cc066a0f6a7

What about running multiple workflows. From a UX perspective I would actually prefer some kind of Debug locally button to download all workflows as one file opening that file and running it with cli exec. #3967 should allow us to correctly run multiple workflows with depends_on.

you only need a specific workflow if you wanna run a workflow localy 1:1 else the generic e.g. pipeline metadata is good enouth

you only need a specific workflow if you wanna run a workflow localy 1:1 else the generic e.g. pipeline metadata is good enouth

As we always run pipelines on the server we should allow the user to be able to do so on the cli as well. Should be quite simple to create a single json like { 'workflow-one': <metadata>, 'workflow-two': <metadata> } and load them in the cli accordingly to the workflows.

As we always run pipelines on the server

well technically we just orchestrate them and no there are cases witch we filter out some.
also the orchestration logic is currently within the queue implementation and we can not easily port or reuse that on the cli.
this pull does not try to touch that part this is out of scope ...
... beside the rest we differ between server and cli is in the server.stepBuilder witch you are currently refactoring...
I get that it distracts you have to choose what to downolad, in this case i would propose to just drop it and dont export the workflow metadata as it only contains name and number anyway ...

@anbraten removed the workflow param and dropdown

@anbraten applyed


Send WWW-Authenticate header

I'm using the Basic Auth OWIN middleware. Is there an option to send WWW-Authenticate or should I just create my own middleware component for this?

The issue was that the realm needs to be specified. Is this by design? If I pass null/empty as the realm it still gets appended on the WWW-Authenticate header which is why I was prompted for auth in my browser.

You should use the token endpoint on the oauth2 bearer MW to get a token (similar concept to session tokens).

We still want to support basic auth which is why we're using that middleware.
On the subject of the OAuth2 Bearer MW - Any idea why I might be getting unsupported_grant_type errors when sending my bearer token?
As usual the ASP.NET default templates are completely overwhelming. Here's what I'm doing:
    public partial class Startup
    {
        public void Configuration(IAppBuilder app)
        {
            GlobalConfiguration.Configure(WebApiConfig.Register);

            var basicAuthenticationOptions = new BasicAuthenticationOptions("api", (username, password) =>
            {
                IEnumerable<Claim> claims = null;

                if (username == password)
                {
                    claims = new[] {
                        new Claim(ClaimTypes.Name, username)
                    };
                }

                return Task.FromResult(claims);
            });

            app.UseBasicAuthentication(basicAuthenticationOptions);

            OAuthAuthorizationServerOptions OAuthServerOptions = new OAuthAuthorizationServerOptions()
            {
                AllowInsecureHttp = true,
                TokenEndpointPath = new PathString("/token"),
                AccessTokenExpireTimeSpan = TimeSpan.FromDays(1),
                Provider = new SimpleAuthServerProvider(),
            };

            app.UseOAuthAuthorizationServer(OAuthServerOptions);
            app.UseOAuthBearerAuthentication(new OAuthBearerAuthenticationOptions());
        }
    }

    public class SimpleAuthServerProvider : OAuthAuthorizationServerProvider
    {
        public override Task ValidateClientAuthentication(OAuthValidateClientAuthenticationContext context)
        {
            context.Validated();
            //return base.ValidateClientAuthentication(context);

            return Task.FromResult<object>(null);
        }

        public override Task GrantResourceOwnerCredentials(OAuthGrantResourceOwnerCredentialsContext context)
        {
            context.OwinContext.Response.Headers.Add("Access-Control-Allow-Origin", new[] { "*" });

            if (context.UserName != context.Password)
            {
                context.SetError("invalid_grant", "The user name or password is incorrect.");
            }

            var identity = new ClaimsIdentity(context.Options.AuthenticationType);
            identity.AddClaim(new Claim(ClaimTypes.Name, context.UserName));
            //identity.AddClaim(new Claim("role", "user"));

            context.Validated(identity);

            return Task.FromResult<object>(null);
        }

    }

I appreciate I should probably go to SO with this but you are one of the authorities on the subject in our community ;)

Fixed the issue, I found your sample on GitHub.


Any Webpack experts care to join Angular CLI planning hangout?

Hi folks,
I don't have a bug to report.  I'm just looking for an authority on Webpack.
I organize weekly Google Hangouts between some top open source thinkers, educators and Google team members in an effort to unify/improve approaches to single-page app development.  Towards the formation of an AngularJS command-line interface, this week we're considering build tool options including Webpack.
It would be great if someone who knows it well could join us.  We'll be meeting tomorrow at 7:30 pm gmt.  It usually lasts about an hour.  We'll do short overviews of each option followed by some Q & A.
If you're free then and interested in shaping the course of AngularJS app development, please write me and I'll send you the Hangout link.
Thanks,
Dan

One more thing... I made a questionnaire about tools to inform this big comparison spreadsheet about alternative web technologies. In case anyone has a few spare minutes, I would really appreciate if someone could complete the questionnaire for Webpack.
Just click here
Thanks!

I don't think it can answer these questions with a simple YES/NO form. Some questions doesn't apply, because webpack is not a package manager and many questions only apply for one of the tools.
My subjective optinion is that webpack does a pretty good job for optimized bundling of javascript and stuff that compiles to js or is referenced by js (css, images, etc.). It does the best job in splitting your modules into multiple on demand loaded parts (Code Splitting). It's pretty fast for incremental builds. Highly configurable, but difficult to getting started with.

That's fine.  If something doesn't apply, just ignore it.  I don't really pay much attention to tool labels - "package manager", "build tool", "module loader"  and so on because what matters is what the tool can do, not how people categorize it.
I know that putting things into black and white is not a very popular thing to do.  But at the end of the day, people have to make decisions and without booleanized characteristics (YESes and NOs to questions without adjectives of degree) comparing complex things is very very hard.  My goal is to make it easier for people to choose the best tools for their needs.
From your remarks, I've put YESes next to "Lets you break applications into discrete, lazy-loadable modules" and "Supports incremental builds" for Webpack.  I think that's what you meant.  Perhaps you could elaborate on what makes it highly configurable and difficult to get started with.

Perhaps you could elaborate on what makes it highly configurable and difficult to get started with.

webpack has a rich plugin system. Most features are plugins. There are (too) many config options regarding output and resolving. Maybe you know the angular-webpack-plugin, which parses angular.module, threads angluar dependency as module dependencies and resolve them with a custom resolver algorithmus.
Difficult to getting started: Mainly because of missing good getting started docs and bad "wrong configuration" error handling.

Filled the form. Hope everything is correct... ;)


feat(Dropdown) Add container prop to Dropdown, like what's already in PopperContent

[ ] Bug fix
[x] New feature
[ ] Chore
[ ] Breaking change
[ ] There is an open issue which this change addresses
[x] I have read the CONTRIBUTING document.
[x] My commits follow the Git Commit Guidelines
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.

[x] I have updated the documentation accordingly.

[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

When a Dropdown is inside a small element with overflow: hidden, it's useful to have the dropdown display directly inside of body or another container. I added the same menuContainer prop to Dropdown. Using a React Portal, this allows the dropdown to have body or any other tag as the parent.
Note that the prop needs to be on Dropdown instead of DropdownMenu since Dropdown needs to know about what the container is for some of its click handlers.
Old behaviour

New behaviour
Code:
<Dropdown menuContainer="body">
  <DropdownMenu modifiers={{ preventOverflow: { boundariesElement: 'viewport' }}}>...</DropdownMenu>
</Dropdown>

I see a warning when using the new prop

Also would it make more sense to use a container option on the DropdownMenu component instead of using the menuContainer option on the Dropdown component?

Note that I removed the container prop. The only prop that should be used is menuContainer on Dropdown.
This is because Dropdown needs to know what the container is to detect clicks outside of the dropdown to close the dropdown. As such, menuContainer is passed to Dropdown, which uses the context to pass it to any child DropdownMenu.
I also added a new positionFixed parameter to DropdownMenu

The new commit should also fix the console errors shown above

I updated the API again. Now, the API is:

DropdownMenu has new prop container. container can be used to move the Dropdown to have another parent like "body" or "#myCustomDiv"
DropdownMenu also has new prop positionFixed. This allows to keep it fixed on page instead of absolute
Dropdown has new prop menuClickTarget. Dropdown needs to know where the menu is so that when it detects any clicks outside of the menu, it closes the menu. menuClickTarget allows the developer to set a custom click target

All 3 have been tested and documented

Hi @hsource thanks for the PR and the updates. I tried your new changes and it seems that the onClick event on a MenuItem is not invoked when the container is body. It was working before your last update.

If you're setting container="body", then you must set some kind of ID or class on <DropdownMenu> and then set that in <Dropdown menuClickTarget>. For example, write:
<Dropdown menuClickTarget="myMenuId">
  <DropdownMenu id="myMenuId">...</DropdownMenu>
</Dropdown>

I'm not a huge fan of this API right now. Ideally, the Dropdown would know where the DropdownMenu is rendered, but there's no way to pass context up the chain. I think integrating DropdownMenu into Dropdown or moving the click handler that toggles the Dropdown into DropdownMenu may be a good solution, but I don't have the time to do that right now.

I agree, this is error prone. An alternative would be to pass the reference of Dropdown down to DropdownMenu using a context. However all those solutions would probably make the code more complicated than what it needs to be. Considering this I would be in favour for using the old menuContainer prop on Dropdown.

I made a new change (#2016) fixing the architecture issues! Take a look


q is not defined

I got this error on production (Heroku), I've been using Vue 2 with Meteor.

I would say I is working well on localhost.

There should be no difference on localhost vs a Heroku instance. Any reproduction steps? I don't personally use Meteor or Heroku.


Export more symbols for the shared_library build.

Some symbols in vaapi_wrapper.{cc,h} are used by the content/ layer, but
they were not being properly exported into libwayland.so:
CONTENT_IMPLEMENTATION was not defined so CONTENT_EXPORT was
evaluating to nothing, and the VASurface methods were not being
exported at all.

Conversely, CreateDesktopPlatformScreen() was declared in the 'views'
target but implemented by the 'wayland_toolkit' target. We thus need
to export the implementation, not the declaration, for the symbol to
be found by the run-time linker.

Merged


feat: allow empty header values for compatibility with STOMP 1.1 and 1.2

In STOMP 1.1 and 1.2, header values are defined as:

header-value        = *<any OCTET except CR or LF or ":">

Where previously they were defined as:

header-value        = 1*<any CHAR except LF>

Due to a quirk of the not_line_ending and terminated combinators, the parser was failing on empty header values, of the form correlation-id:\n, due to the not_line_ending combinator not having enough input.
This solution adds a single fallback tag to the terminated call, allowing it to gracefully parse empty values as "".

Also, I know you were looking for maintainers. I might be willing to help.


NOTICE: PHP message: PHP Fatal error:  Unparenthesized

Hi,
PicoCMS not working with highers PHP versions (in my case 8.0). Error which I reciving:
NOTICE: PHP message: PHP Fatal error:  Unparenthesized `a ? b : c ? d : e` is not supported. Use either `(a ? b : c) ? d : e` or `a ? b : (c ? d : e)` in /var/www/html/vendor/twig/twig/lib/Twig/Node.php on line 42

As far as I found, PHP 7.4+ changing this:
https://www.php.net/manual/en/migration74.deprecated.php
I think, this should be fixed because older versions are comming to end of life.

or maybe I missed something, and someone could help me.
Thanks for amaizing work!

Sorry for the late response, unfortunately I'm drowning in work lately. I guess we can make v3.0.0-alpha.2 stable v3.0.0 (it must be v3.0 due to breaking changes in our dependencies) and postpone #535 to Pico 4.0... Will try to find some time to actually do this.

@PhrozenByte - I've using 3.0.0 Alpha from last 2 weeks without problems, but its 'simple' usage and learning twig etc there only. I almost throw away Pico when this php not working, when I downloaded the latest version. I think this projects needs more influx of newcomers so 3.0.0 is needed.
From my side, I will try to update two themes which was already ported to be good example of Pico in real usage ;)

Sorry for the late response, unfortunately I'm drowning in work lately.

No worries from me on this.  Hang in there. ❤
Also, don't ever feel pressured to "address all the things" at once.  If you've only got time to look into one Issue or two, don't feel like you need to make time to tend to everything.
I try to hold down the fort in the meantime, after all. 😉

postpone #535 to Pico 4.0...

I mean, some of the minor things could possibly be labeled as 3.1, 3.2 if they're not breaking changes.  Maybe a staged rollout of smaller features would work better with your limited availability anyway.  I know working up toward a big release feels nice... but speaking from experience it also can get daunting quickly.
Suddenly you've got this huge todo list of things you don't have time to finish blocking your release. 😫
But, I mean, I'm one to talk.  I'm almost always in the bad habit of working on multiple things at once, then having to manually pick which lines I'm ready to commit. 😂

Will try to find some time to actually do this.

Sorry for the pressure. 😅
PHP 8 is popping up more and more though. 😔

There are mentions in this issue to a beta release of Pico 3. How do I get my hands on this?

Any news for an official release of this fix?
Currently, I've "downgraded" a site I manage to PHP 7.4 to avoid this problem, but my hosting provider only allows this for a limited time.
I know you've said that 3.0.0 alpha.2 is safe for production, but it just feels wrong with alpha in the name.

@bjarneds, the "alpha" version is perfectly safe to use in production.  The only changes in it are dependency versions and version number strings.  Unfortunately, no further work was ever done on that branch.  If you're feeling uneasy about it, you can compare the changes here on GitHub to see what I mean.

@PhrozenByte No worries, but it's time to tackle this problem.  This is my second time writing this comment because my browser ate the first one...
I guess that's an excuse to be concise for once. 😣
My recommendation is that we merge in only the dependency changes (or rather, just change them fresh and ignore the alpha branch), and package that as "Pico 2.2".
I know you don't like "breaking" changes in a minor version, but at this point, it's a bug fix.  Pico is no longer compatible with current PHP.  We can have an upgrade note highlighting the newer PHP requirement.
I don't think it warrants a "3.0" release, and I think labeling it as one feels disingenuous since there's literally no other changes.
I'm going to put a note in the readme about PHP 8.0 for now.
I can try to take care of the "2.2" version bump as well if you like that idea.  I don't know how any of your CI stuff is set up right now (can it automatically build new release packages? etc), but I could at least set up a pull request with the file changes for you, since it's all a bunch of string updates.
Let me know how you want to proceed with this.  Don't stress over it, but something has to be done soon.  I know it's not ideal, and not how you wanted to handle it... but it's also not the end of the world.
Just leave a quick "Yes, go ahead and do that", and I'll take care of what I can for you. ❤

Apologies in advance because I'm not quite sure that the cause of my problem is the php update to 8.
I had half a dozen blogs with picocms in apache on CentOS. All working perfectly.
Now I'm trying to move them to an ubuntu 22.04 server. After trying everything with apache, I installed lighthttpd... and also not. Then I downgraded php to 7.4, upgraded picocms to alpha 3.... and nothing.
As far as I can understand making all kind of tests, the problem is that twig doesn't work. If I don't upload the index.md pico shows the base of any template... except that parts of the template what uses twig variables to call a string or an image. If I upload an index.md to Content folder then.... blank screen of death.
PHP works fine and other sites that are not based on picocms are working just fine.
I decided to bother you after searching and searching and not finding any thread with a similar problem. could you please help me?

Hello 👋🏼

Hey all, Just adding in here that I've also ran into this problem since I had to upgrade from PHP 7.4 to PHP 8.2. (FreeBSD has dropped PHP 7.4 for security reasons). I've upgraded to Pico 3.0.0 Alpha 2 as instructed above and everything is working great.
I do agree that we'll need to make a compatibility release at the bare minimum, no other additional features are needed other than making it still run with modern PHP.
Thank you :).

I’m going through and addressing all the deprecation warnings: some of these are just trivial to fix. Others, not so much. I plan to move this to my private repository until Pico is finally released as not-alpha.
I’m HOPING to finish my changes  today. Pico Alpha-2 worked fine on my local machine, but the permissions were all wrong (for files and directories) so once I moved it to the real system, it tossed up the dreaded FORBIDDEN. That was annoying.
I don’t know about anyone else, but I tend to keep my system limited as much as possible and would REALLY PREFER if all user content were under a single directory (including plugins). That would simplify upgrades.
TBH I have had ZERO luck with Composer. It’s literally faster for me to download a release and move my content over. As such, what can I get rid of regarding Composeer?


error in the step of 5.4 and 6

I failed at 5.4 and did not install the package successfully....I have not mediapipe-0.8-cp36m....
and I cloned your library and found nothing，，would you help me？

i have not the file（mediapipe/dist/mediapipe-0.8-cp36-cp36m-linux_aarch64.whl），if  i have this file，can I install mediapipe？

What kind of error did you see on step 5.4? log?

i have same problem with this error,
Processing ./mediapipe/dist/mediapipe-0.8-cp36-cp36m-linux_aarch64.whl
ERROR: Could not install packages due to an OSError: [Errno 2] No such file or directory: '/home/poker/mediapipe/dist/mediapipe-0.8-cp36-cp36m-linux_aarch64.whl'


DBZ-6470 Signaling data collection document update

DBZ-6470 While creating signaling table we need to have privileges to create table in source database not target

Applied via https://github.com/debezium/debezium/pull/4547, thanks!


Adds 'tenant security alerts list' command. Closes #2635

Adds 'tenant security alerts list' command. Closes #2635
The scope SecurityEvents.Read.All needs to be consent for this command.

Awesome @nanddeepn! We'll review it shortly

@waldekmastykarz: have you added the scope SecurityEvents.Read.All to the PnP app?

I have now


Review changes

Changes made during code review. All commits should be atomic EXCEPT for the change to use no_run in rust-doc. That change relies on the added get_pin method.

Main thing I can see is removing get_value_from_file as it does not appear to be used.

I was wrong on get_value_from_file.  I added a commit to address my other comment (minor).  Good stuff.
I'll probably bump the version to 0.3.3 and release.  I don't think we have added any breaking changes, just new APIs.


Add more examples for JOSS review

[ ] Circuits basics
[ ] Built-in circuit library
[ ] Advanced analysis of AutoEIS output
[ ] Analyze batch data

These are good ideas @RunzeZhang123, I added them to the todo list in the first comment. I can do "Circuit basics" (work in progress) and "Analyze batch data", and you can take up "Built-in circuit library" and "Advanced analysis of AutoEIS output". Does that work for you?


(CL) Rename Fee to Spread Factor and Add Translations

@JoseRFelix FYI we may be adding additional translations for CL, in that case do you think it would be easiest to wait until we've added those to update translations?


[FEATURE REQUEST] Remove/Restructure HUGE banner at top of accounts page?

Is your feature request related to a problem? Please describe.
In a recent update the top area has been redesigned/restructured and takes up WAY too much space now.
Describe the solution you'd like
Go back to what it was or streamline the header somewhat.
Attaching a photo.

Totally agree! Please make it adjustable or just small. It's huge and takes up a ridiculous amount of screen space.

100 agree. Would love to reclaim this newly wasted space!

+1

How's this look?

Back on one line is certainly better!

Agreed.

Something like this wouldn't look bad... But put the Reconcile buttons on the right of the $?

I like that a lot. Agree that Reconcile should be at far right. Maybe revert to default double-stack when panel width gets too small.

@michaelcmelton Is there any chance your fix for this also suppresses the hover tips that keep popping up from those balances and blocking what I'm trying to see/do??

The change is just a intermediate state to make room for other changes which where just announced https://www.youneedabudget.com/release-note/november-21st-2022/. I would wait with any change in this area until its settled.

Those are release notes, not a road map... What might I be missing? I think they've just described the exact thing we're all complaining about.

+1
The worst is the pig picture when you reconciliate... damn these last UI/UX updates aren't great at all...

Just adding my voice to this change that has been foisted on us by YNAB. The change wastes way too much screen real estate and could have been arranged much better than what has been done. They seem to be making arbitrary changes that do not enhance the experience at all and just gets in the way. I've sent them feedback about it but I doubt they will consider it at all.

They seem to be making arbitrary changes that do not enhance the experience at all

I know YNAB has at least 1 or 2 product managers and user experience "experts" around the mobile app. I am sure they went through some testing with it. Features are never just released, most things do get approved at some point. To me, it is more consistent styling with the mobile app. I would probably agree with you that making the "working balance" calcuation the more prominent thing is a waste of space. I am kind of hoping they add more data to the right hand of the toolbar like they now have.
It could also just be a problem with their QA process. Many people have ultra wide monitors that makes that space even larger and more annoying. Perhaps some people that tested it weren't using ultra wide, the problem is less important to me on my laptop. I'm sure they had their reasons, but I encourage any tech company to go through the fast prototyping like YNAB seems to do. Hopefully it's resolved.

It could also just be a problem with their QA process. Many people have ultra wide monitors that makes that space even larger and more annoying. Perhaps some people that tested it weren't using ultra wide, the problem is less important to me on my laptop. I'm sure they had their reasons, but I encourage any tech company to go through the fast prototyping like YNAB seems to do. Hopefully it's resolved.

+1. While I do have a 34-inch desktop monitor, that's only used with my work laptop. I only use YNAB on my personal 13-inch MacBook Air, so screen real estate is at a premium. There are just so many configurations to consider, so I grant them that, but given they're a business selling a relatively expensive service, I would hope they are testing their changes on a wide variety of devices.

Yes, that's a good point about the monitors. Most if us have decent sized monitors nowadays - I use a 14" MacBook Pro, and even that has more than enough space to accommodate the header items on one line. However, I do appreciate that some people may not, so they have to consider them too. Hopefully there will be a solution to it that suits everyone.

I came here to request this as well -- the new header takes up a full 1/3 of the available vertical screen space on my laptop!

I think they just released or recently released the loan planner feature on the desktop and they seem to have moved the add activity buttons to the loan account. That's probably what the extra space is for. To be consistent, it's similar on all the account screens. Perhaps the feature in the toolkit could change it only for non loan accounts? If that makes sense and there is a way of saying if an account is a loan or not?

Bumping this because they just released an update that adds some stuff to the header and it feels a little cluttered and/or the layout could use a little fix.  Was happy with it thus far! :)

When you say bumping this you mean what exactly? That's the new focused views feature they were working on.
So you want more space or less space? The original implementation was to try to decrease the amount of space, but we want to reverse that?

From: WanderingRaven @.>
Sent: Monday, June 26, 2023 1:53 PM
To: toolkit-for-ynab/toolkit-for-ynab @.>
Cc: Joshua Saxton @.>; Comment @.>
Subject: Re: [toolkit-for-ynab/toolkit-for-ynab] [FEATURE REQUEST] Remove/Restructure HUGE banner at top of accounts page? (Issue #3008)
Bumping this because they just released an update that adds some stuff to the header and it feels a little cluttered and/or the layout could use a little fix. Was happy with it thus far! :)
—
Reply to this email directly, view it on GitHubhttps://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/3008#issuecomment-1607954548, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABCFY6JX4H5EDKTQURWKH63XNHEDHANCNFSM6AAAAAASDOG2ME.
You are receiving this because you commented.Message ID: @.***>

As far as I can see this issue was about the new double header at the top of the accounts screens (I could be wrong though - I can’t really remember now). TBH, this looks fine to me now.
I’m not sure if WanderingRaven is referring to the buttons for “All”, “Underfunded”, “Overfunded” and “Money Available” buttons below the header on the Budget screen. TBH, I could do without these as I can’t see any occasion when I would use them, but they’re not too intrusive so they don’t bother me too much.

It just looks janky.  There's a lot of space wasted, and the new "filter tabs" sort of cluster on the left and make the background look like it's pushed off by a few pixels.  I'm not sure what would happen if there are additional filter tabs added as I haven't had a chance to play around with them. I actually like the idea of the filter tabs/buttons but a show/hide feature or maybe moving them, not sure what would be best.


[ASTGen] Infrastructure for implementing ASTGen incrementally

ASTGenVisitor has a reference to a legacy C++ Parser configured for ASTGen.
When ASTGenVisitor encounters a AST node that hasn't been migrated, call the C++ Parser::parse(Decl|Stmt|Expr|Type) to parse the position using the legacy parser.
If the legacy parser is configured for ASTGen, it calls ASTGen's  swift_ASTGen_build(Decl|Stmt|Expr|Type) for each ASTNode parsing (unless the call is not directly from the ASTGen.)

rdar://117151886

@swift-ci Please smoke test

@swift-ci Please smoke test

preset=asan
@swift-ci Please test with preset macOS platform

@swift-ci Please smoke test

preset=asan
@swift-ci Please test with preset macOS platform

I like this approach of bouncing between the two parsers as needed, so we can opt in to ASTGen production-by-production.

@swift-ci Please smoke test

preset=asan
@swift-ci Please test with preset macOS platform


Workflow that deletes the PR dev space

Workflow that deletes the PR dev space when the PR closed

@s-tuli Can you please review this PR.

@greenie-msft, could you look at the error on closePR?
There is an error for pr_closed.yml: "No event triggers defined in on"

@s-tuli Addressed the issue that CTI reported. Should be good now?

Looks Good to me.
Did you test it?

Yep, I did!

@greenie-msft, please feel free to merge! Thanks!


[sqllab] Tableschemaview fails to load with presto using parquet format files

Summary
On Superset version 3.1.0 the table schema previews fail to load on sqllab/ and dataset/add/ paths when using presto datasources and parquet format files.
These were working for Superset version 1.5.3, but have not worked since version 2.0.1 and up to 3.1.0.
Error condition on Superset version 3.1.0 with presto table using format=PARQUET

Conditions

This only occurs when those tables are using Presto and a table format = 'PARQUET'
Other database types such as Druid and MySQL do not exhhibit this behaviour
This occurs when logged in as an Admin user, therefore I believe that it is likely unrelated to #25451
When the presto table is using format = 'TEXTFILE' this error does not occur

How to reproduce the bug

Go to Superset version 3.1.0 as an Admin user and navigate to either of:
a) /sqllab
b) /dataset/add
Select a database that uses the presto connector type
Select any schema
Select any table that uses a format = 'PARQUET'

Expected results
I would expect the left hand column to be populated with the column names from the selected schema.
Actual results
Several error messages appear stating that there were errors fetching table metadata and the left-hand column is not populated.
Error messages in the server log
There are no relevant error messages in the server log.
We can see the pyhive presto command going through:
INFO:pyhive.presto:SHOW COLUMNS FROM "wmf"."aqs_hourly"
INFO:pyhive.presto:SHOW COLUMNS FROM "wmf"."aqs_hourly"
INFO:pyhive.presto:SHOW COLUMNS FROM "wmf"."aqs_hourly"
INFO:pyhive.presto:SELECT * FROM wmf."aqs_hourly$partitions"
ORDER BY year DESC, month DESC, day DESC, hour DESC
LIMIT 1

We have a lot of DEBUG level messages from requests_kerberos.kerberos_ and urllib3.connectionpool and spnego._gss while the request is authenticated and processed, but these appear to show a 401 followed by a successful 200 response.
There are no stack traces shown.
Additional Screenshots
Error condition on Superset version 2.1.1 with presto table using format=PARQUET

No error on Superset version 1.5.3 for the same table

No error on Superset version 2.1.1 with presto table using format=TEXTFILE

Environment

browser type and version: Firefox 118.0.1 (64-bit) on Linux, but this affects other browsers.
superset version: 3.1.0
python version: 3.9.2
node.js version: 16
any feature flags active:

ENABLE_TEMPLATE_PROCESSING
DASHBOARD_NATIVE_FILTERS
ENABLE_FILTER_BOX_MIGRATION

metadata caching, memcached

Metadata database: MariaDB 10.4
Presto version 0.283
Optional components:
pyhive[kerberos,presto]==0.7.0
gunicorn[gevent]
apache-superset[hive,presto,mysql,druid,trino,spark,postgres]
pylibmc==1.6.1

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

I have updated this issue based on my testing against Superset version 3.1.0
The issue is still preset in this version and is preventing us from upgrading our production instance from 1.5.3 to 3.1.0.

Assuming this is also present in 4.0 then, but that might be worth confirming.
I also wonder if this has been addressed at all by @betodealmeida 's catalog work and/or @dpgaspar 's parquet refactoring, both of which have only recently been merged to master (i.e. not released) yet.

Re-opening because the fix was reverted in https://github.com/apache/superset/pull/28613.


fix: typo in README.md and add depends_on :macos to formula

I found a typo in README.md.
In addition, I've added depends_on :macos to Homebrew's Formula.
.gitignore was too simple, so I added some rules that I think are common.
I rewrote installer.sh in the same style as mac-cleanup.
I'd be happy if you could incorporate the proposed fixes.

Thank you!

Thank you for your quick capture.
I am honored to be a part of CONTRIBUTORS:)

Happy to have you on board!
If you like the project, please consider sponsor my work! :)


Bluetooth: Fix central from failing to start encryption

This fixes a regression introduced in commit 6af5d1cd1f81
("Bluetooth: Compress bt_keys struct").
Instead of passing a value zero as the random number, the
value at the RAM address zero was being used by the start
encryption function call. It is now fixed by consistently
using byte-array to store EDiv and Rand values.
Signed-off-by: Vinayak Kariappa Chettimada<EMAIL_ADDRESS>

Codecov Report

Merging #8526 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #8526      +/-   ##
=========================================
+ Coverage    63.8%   63.8%   +<.01%
=========================================
  Files         426     426
  Lines       40890   40890
  Branches     6921    6921
=========================================
+ Hits        26088   26089       +1
  Misses      11666   11666
+ Partials     3136    3135       -1

Impacted Files
Coverage Δ

boards/posix/native_posix/timer_model.c
95.16% <0%> (+1.61%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7e4f5...fdcf5bd. Read the comment docs.


Add concealing shimmer style to ShimmerView

Platforms Impacted

[x] iOS
[ ] macOS

Description of changes
Added ShimmerStyle to distinguish between revealing shimmer and concealing shimmer style. Concealing shimmer is a shimmer style where the gradient conceals parts of the subviews as it moves leaving most parts of the subviews unblocked. Revealing shimmer is a shimmer style where the gradient reveals parts of the subviews as it moves leaving most parts of the subview blocked.
The current ShimmerView is of the "revealing shimmer" style which works great when used on labels, ShimmeringLines etc. However, it does not work great on images as a shimmering effect because the image contents are mostly blocked under the "revealing shimmer" style.
Verification
Added ShimmerStyle related tests to the test app and made sure the shimmering effects are as expected.
A screenshot of the test app showcasing the two different shimmer styles side by side:

Pull request checklist
This PR has considered:

[ ] Light and Dark appearances
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)

Microsoft Reviewers: Open in CodeFlow

Fixing white spaces in the next commit.


Fix multi thread  bug in memory pool

LGTM

Is this case (IndexError) really possible, or just a defensive programming?  I tried to reproduce this issue but I couldn't.
As far as I know, there are no chance of self._free[size] being changed between if free: and free.pop(), as the thread calling malloc should have a GIL.

Thank you for your report of experiment result.
It is defensive programming.
CPython has a instruction counter for multi-thread.
I think that if free consume very few time. In other words, this python thread has a very low possibility of contest switching. But, if two thread want to get same size memory, old code raises error very low probability.

Oh, I did not consider about Cython.
Cython do not release GIL between that two lines.
This fixing is redundant...
Is this opinion correct? @kmaehashi

@okuta Yes, I think so.

OK.
I will send revert PR.


fix(postgraphql): allow meteor-login-token request header when using enableCors option

If you start a PostGraphQL instance using vanilla HTTP within a meteor server the addCORSHeaders function needs to allow the meteor-login-token request header.  Otherwise the request fails using a GraphQL client (I am using apollo-client).
Here is how I started the instance in Meteor.
http.createServer(postgraphql(POSTGRES_CON_STRING, schema, {
  enableCors: true,
  graphiql: Meteor.isDevelopment,
  bodySizeLimit: '20MB'
})).listen(5000);

This is what I see when the meteor-login-token is now allowed -

I am considering using PostGraphQL in node.js as explained here without going through HTTP but I think there are features that I would lose because I'm using apollo-client.

Hi Ross, thanks for the pull request! Sorry you're having this trouble.
I don't think we should be adding framework-specific overrides to the source code like this; if necessary it should be provided by a command line (or in your case, library) option. I'm not sure why Apollo is sending this header? Or is Meteor intercepting it somewhere?
One option is to override this with an express middleware (literally remove this header before it hits postgraphql); but you'll have to be careful!
Another option is to stop Apollo sending this header in the first place.
Failing both of these, we'll happily accept a pull request to add additional CORS headers:

Add an option to PostGraphQLOptions: https://github.com/postgraphql/postgraphql/blob/d4fd6a4009fea75dbcaa00d743c985148050475e/src/postgraphql/postgraphql.ts#L11
Pass options to addCORSHeaders: https://github.com/rossmartin/postgraphql/blob/454ecb1d426278a08b7641e9a5d2bb029c4c8210/src/postgraphql/http/createPostGraphQLHttpRequestHandler.js#L127
Using the new option, add additional headers (e.g. with an object splat).

Good luck!

@benjie Thanks for all the info and options.  I'll see if I can stop Apollo/Meteor from sending this header in the first place.  The applyMiddleware for apollo-client might be what I can use to solve this.

@rossmartin Good luck! If you come up with a solution, please share for anyone that comes across this in future :)

Update with an easy solution -
If you are using apollo-client you can prevent the meteor-login-token from being sent by setting the useMeteorAccounts option to false for createMeteorNetworkInterface -
const networkInterface = createMeteorNetworkInterface({
  ...
  useMeteorAccounts: false
});

Excellent, thanks for sharing the solution @rossmartin!


Can't build due to "Argument list too long" error

When trying to run my app using react-native run-ios, I receive the following error:
=== BUILD TARGET RNAdMobManager OF PROJECT RNAdMobManager WITH CONFIGURATION Debug ===

Check dependencies

Argument list too long: recursive header expansion failed at /Users/gilad/MyProject/node_modules/react-native-admob/ios/../../../ios/Pods/React/node_modules/fsevents/node_modules/ajv/dist.

** BUILD FAILED **

I have the following in my package.json:
    "react-native-admob": "^2.0.0-beta.2",

And inside my Podfile:
  pod 'Google-Mobile-Ads-SDK'

I've tried to clean my build folder, as well as XCode's DerivedData - but it doesn't help...

Same here.
Argument list too long: recursive header expansion failed at /Users/patw/Projects/news/node_modules/react-native-admob/ios/../../../ios/Pods/Target Support Files/Pods-news.

same issue here
Argument list too long: recursive header expansion failed at /Users/dantecervantes/Documents/react-native/FinanceApp/node_modules/react-native-admob/ios/../../../ios/Pods/React/node_modules/react-tools/src/isomorphic.

Same error here :
Argument list too long: recursive header expansion failed at /Users/username/Documents/work/repos/Mobile/node_modules/react-native-admob/ios/../../../ios/Pods/React/node_modules/react-tools/src/renderers/dom/client/__tests__.
any solution ?

same issue

the same issue, I even uninstalled the Xcode, but the issue still hangs there.

Same issue
Argument list too long: recursive header expansion failed at /Users/USERNAME/Documents/work/repos/APPNAME/node_modules/react-native-admob/ios/../../../ios/Pods/React/node_modules/react-tools/src/renderers/dom/client/__tests__.


Add plugin for moonrepo (moonrepo.dev)

If you're OK with this, I'll merge it!

Odd, those commits after rebase, no worries about that btw.

Yup, merge away! Thanks.

:rocket: This pull request is included in v5.9.0. See Release 5.9.0 for release notes.
Using Knip in a commercial project? Please consider sponsoring me.


Broken links created with Links module

I have the same issue as #108 and #126 (perhaps #180 ?) when using the quickstart guide with Saturn 0.80.
I think it might come from the ctx.Request.Path.Value (I am not sure how it's handled behind the scenes by the router or otherwise).
In the books example :
After adding forward "/books" Books.Controller.resource in the browserRouter, http://localhost:8085/books/ yields /books// for the ctx.Request.Path.Value, and thus even if Links.add doesn't add a slash between the Links.index and "add", the generated path is erroneous.

I had the same problem and I believe it is because the template installs Saturn 0.7.3, updating to Saturn 0.8 via .paket/paket.exe update fixed it for me, however you also need to change renderXml to renderHtml in BooksController.fs.

Duplicate of #152


Youtube Music

https://music.youtube.com/watch?v=eBShN8qT4lk&list=RDAMVMz5rRZdiu1UE
Theres a link that doesnt work with your addon.
I tried casting from the popup.
Works in another addon.
Loving the new update :P

@PAEz The new version 4.1.0 supports YouTube Music.


autorandr: add --match-edid

It is useful when outputs change, but EDIDs do not. See upstream PR for more details.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

cc module maintainer @Alexnortung


fix(notes): correct some typos of the class notes

What's being changed:

Register $st8 does not exist, the correct one is $t8
The ld instruction should be lw

Agradeço a contribuição!


Unminified plain-draggable.min.js

Hi Anseki,
npm i plain-draggable
cd node_modules/plain-draggable
npm i
Got quite a few errors.  Really speaking I just need the unminified version of plain-draggable.min.js.  Typically the only file on GitHub that does not have an unminified version.  Is there any chance that you could push this to GitHub?  The work I'm doing is just a prototype in vanilla and doesn't even need a build system. Best David

Hi @David-Carty, thank you for the comment.
I don't know why you failed the installing because you didn't tell about the errors.
Anyway, the .min in a file name means minified file. That is, a file name that doesn't include .min is not minified.
You can get all files of PlainDraggable at this repository. And you can do git clone to get data of the repository.

The error message from npm is huge, so I didn't include it.  Its related to babel and I'm just so busy at mo, to analyse.  Unfortunately, there is only a minified version of this file: https://github.com/anseki/plain-draggable/blob/master/plain-draggable.min.js
So, none of the unminfied files run in the browsers because they contain imports relevant to the build, which I can't run on my local machine.   I need to work on an unminified version because it doesn't support a feature that I need.  Any chance that you can transpile but not minify so there is an unminified version that runs in the browser? Thanks again for your time. David.

If you want the unminified code for test, you can find the test version in test directory.

Thanks again Anseki works a treat.  Really appreciate that. Best David.

:smile:


ROX-10935: stop using custom helm library

Description
Removed the replace and ran go mod tidy, to revert one part of https://github.com/stackrox/stackrox/pull/2373/files that is no longer needed.
This custom version had a few changes compared to upstream:

Agressive pre-delete logging. - helped a lot in tracking down the root cause, but is somewhat verbose and has done its job
Fix loopclosure mistake in batchPerform(). + revert - misguided attempt to fix the issue
Explicitly log problematic resource name. - this I still consider beneficial, but probably not worth keeping a fork for this alone at this point. I will try to upstream this, tracking in https://issues.redhat.com/browse/ROX-12102.

Checklist

[ ] Investigated and inspected CI test results
[x] ~Unit test and regression tests added~
[x] ~Evaluated and added CHANGELOG entry if required~
[x] ~Determined and documented upgrade steps~
[x] ~Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)~

Testing Performed
Relying on CI.

/test gke-nongroovy-e2e-tests

Thanks @misberner !


Add support for tca95xx i/o extenders.

:thumbsup:
n/a
:thumbsup:

Things of note

I am able to test the TCA9534 and TCA9535 chips using a RPI4.  I included chips that were nearly identical as to reduce the likelihood of introducing a bug.
I added a conn.Conn interface and implemented that for the extender to allow access to the entire port as a byte.
This code is based on the mcp23xxx code pretty heavily.

Hi! Thanks for the contribution! It's really appreciated.
Would you mind fixing the staticcheck warning? It helps code readability overall.

Can I add https://github.com/stretchr/testify to help me clean up a bunch of cruft in the unit tests?

While I understand the value for those who are familiar with this kind of library, a package like https://pkg.go.dev/github.com/stretchr/testify/assert is not what I call a great design. It's so large that it cannot fit in my head, which means that I have to look up every single function when I use it, or try to guess what it does based on the name. Feel free to create a one-off local function in the test file to reduce copy pasting.

Codecov Report

Merging #51 (4c598f2) into main (600c8cc) will increase coverage by 0.2%.
The diff coverage is 70.3%.

@@           Coverage Diff           @@
##            main     #51     +/-   ##
=======================================
+ Coverage   64.4%   64.6%   +0.2%
=======================================
  Files         56      60      +4
  Lines       6824    7060    +236
=======================================
+ Hits        4397    4562    +165
- Misses      2283    2343     +60
- Partials     144     155     +11

Impacted Files
Coverage Δ

tca95xx/pins.go
60.4% <60.4%> (ø)

tca95xx/variants.go
63.6% <63.6%> (ø)

tca95xx/tca95xx.go
78.2% <78.2%> (ø)

tca95xx/registers.go
87.2% <87.2%> (ø)

lepton/lepton.go
86.2% <0.0%> (-1.0%)
:arrow_down:

videosink/handler.go
86.4% <0.0%> (+0.6%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Is there anything else I need to do before you can merge?

Thanks a lot for the PR. Apologies for the delay, work was busy this week.


FIX error: Invalid JSON Patch

+1 , I still have the same problem, as of today (26/10/2020)  is this issue open for the last 18 months ?


Bump resolve-url-loader version

Currently, npm audit fails because of react-scripts > resolve-url-loader > adjust-sourcemap-loader  > object-path.
See https://github.com/facebook/create-react-app/issues/9840 for details.
This PR bumps the resolve-url-loader version from 3.1.1 to 3.1.2

Up!

UP

+1 🙏

only you can save us johann

UP

+1

The discussion is happening on the linked issue. You’re welcome to participate in it if you have something substantial to add. But spamming the thread with “+1”s makes it less likely to be merged soon, not more.

I've included this into<EMAIL_ADDRESS>(but without the unpinning because I think we need to have CI fixed before we can risk unpinning in past majors).


[monorepo-builder] PHP config throws TypeError when using with monorepo-builder-prefixed

This may be replicated with the following config
<?php

declare(strict_types=1);

use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use Symplify\MonorepoBuilder\ValueObject\Option;

return static function (ContainerConfigurator $container) : void {
};

then
ptomulik@tea:$ vendor/bin/monorepo-builder.phar merge
PHP Fatal error:  Uncaught TypeError: Argument 1 passed to _HumbugBox8ca267772241\Symfony\Component\DependencyInjection\Loader\ProtectedPhpFileLoader::{closure}() must be an instance of Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator, instance of _HumbugBox8ca267772241\Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator given, called in phar:///home/ptomulik/projects/korowai-framework/vendor/symplify/monorepo-builder-prefixed/monorepo-builder/vendor/symfony/dependency-injection/Loader/PhpFileLoader.php on line 43 and defined in /home/ptomulik/projects/korowai-framework/monorepo-builder.php:8
Stack trace:
#0 phar:///home/ptomulik/projects/korowai-framework/vendor/symplify/monorepo-builder-prefixed/monorepo-builder/vendor/symfony/dependency-injection/Loader/PhpFileLoader.php(43): _HumbugBox8ca267772241\Symfony\Component\DependencyInjection\Loader\ProtectedPhpFileLoader::{closure}()
#1 phar:///home/ptomulik/projects/korowai-framework/vendor/symplify/monorepo-builder-pref in /home/ptomulik/projects/korowai-framework/monorepo-builder.php on line 8

Simply the anonymous function requires its argument to be Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator while the phar provides an instance of prefixed type _HumbugBox8ca267772241\Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator.
A workaround (solution?) is to remove the type hint from argument. An appropriate update to README would be helpful.
Also note, that Symplify\MonorepoBuilder\ValueObject\Option may be unavailable in general (instead a prefixed version is provided, but it's name is not known when writting the config).

Hi,
thanks for reporting. This is related to phar scoping.
The Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator should be left untouched without any prefix.
In real code:

this line https://github.com/symplify/symplify/blob/19abf05f86637f385c56b7497c132650004e13b9/packages/easy-coding-standard/compiler/build/scoper.inc.php#L43

is missing here https://github.com/symplify/symplify/blob/19abf05f86637f385c56b7497c132650004e13b9/packages/monorepo-builder/compiler/build/scoper.inc.php#L16-L19

Resolved by https://github.com/symplify/symplify/commit/8cf529f3f993ea42643363d182a7c667c2e7862e


FFI deprectation warnings in knife

These started when we updated FFI
C:/opscode/chef-workstation/embedded/lib/ruby/gems/2.6.0/gems/ffi-1.12.1-x64-mingw32/lib/ffi/struct.rb:207:in `layout': [DEPRECATION] Struct layout is already defined for class Windows::ServiceStructs::SERVICE_STATUS_PROCESS. Redefinition as in C:/opscode/chef-workstation/embedded/lib/ruby/gems/2.6.0/gems/win32-service-2.1.4/lib/win32/windows/structs.rb:72:in `<class:SERVICE_STATUS_PROCESS>' will be disallowed in ffi-2.0. (StructuredWarnings::StandardWarning)

It's fixed on this PR: https://github.com/chef/win32-service/pull/71, so we can close this issue.


Global profiles and profiles hierarchies

I would like to have a more flexible use of the profiles.
I would like to be able to activate certain settings for all profiles at the same time.
I would like to have certain properties set to default values, but in such a way that I can overwrite them in the individual profiles.
Two suggestions on how this can be implemented in a practical way:
Global profile
Both suggestions include a global profile. The global Profile overwrites all entries from other profiles.
A setting made in profile python is therefore not valid if the setting in profile global specifies otherwise.
Suggestion 1: default profile
In addition, in the simple case, there is a complementary default profile that behaves in exactly the opposite way:
It specifies default values that apply in every profile, but these values can be overwritten by the individual profiles.
Suggestion 2: profile inheritance
I would prefer this suggestion, but it is much more complex.
It provides for the possibility of inheritance of profiles.
A profile can get a property 'inherit from profile': profile name.
So it inherits all properties of the profile, but can overwrite these properties.
This could be used to build profile hierarchies.
Although suggestion 1 is the much simpler one, it can be irritating for users to distinguish between default and global profiles.
In a self-created hierarchy, it might be more logical to have an additional global profile, which can override all settings of the profiles.

/duplicate
https://github.com/microsoft/vscode/issues/156144

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Figure out how to get proper stacktrace in release builds for Sentry

Currently stack traces in release builds on Sentry look like this

Naturally this information is not very useful. At the very least the corresponding line in the source code would be nice to know to debug the crash.

Uploading corresponding pdb as suggested in Sentry docs has no effect as such I made an upstream issue now at https://github.com/getsentry/sentry/issues/45116

Debugged in:

https://github.com/getsentry/sentry/issues/45116

Closed by:

#192
#195
#191


apr_socket_recv: Connection reset by peer (104)

Hello maintainer, I try http-server example in https://github.com/revoltphp/event-loop/blob/main/examples/http-server.php,
But when using ab tool to benchmark, it result in
This is ApacheBench, Version 2.3 <$Revision: 1901567 $>
Copyright 1996 Adam Twiss, Zeus Technology Ltd, http://www.zeustech.net/
Licensed to The Apache Software Foundation, http://www.apache.org/

Benchmarking <IP_ADDRESS> (be patient)
apr_socket_recv: Connection reset by peer (104)

AFAIK, this is not the problem with ab tool it self, but with the webserver, I'm using default ubuntu server to test it.

Hi @kocoten1992, what's the exact command you're running?

Hi, the exact command is:
ab -t 5 -c 4 http://<IP_ADDRESS>:8080/

for php http-server, I run it as is https://github.com/revoltphp/event-loop/blob/main/examples/http-server.php.


Using aws-role-to-assume causes start to fail

Hi,
When I use aws-role-to-assume I get:
"Error: Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers"
This appears to be related to https://github.com/aws-actions/configure-aws-credentials/issues/271 which has apparently been fixed in v1.6.0. Is it possible for you to update "start" to point to the fixed version?

To see for myself, I've forked this repo and updated it myself and I'm getting the same error, so this may not be the issue.

@andycockerill-cpi Are you attempting to use OIDC in the workflow, or simple role assumption using IAM user access keys?

I quickly tested role assume with static access keys (IAM user who can assume the role) using this kind of config (some details omitted for brevity and redacted):
- id: runner
  name: Start runner
  uses<EMAIL_ADDRESS>  with:
    aws-region: <aws region>
    aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
    aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
    aws-role-to-assume: arn:aws:iam::<account ID>:role/<path/to/role>
    ...

This worked okay.
I will next test OIDC-based role assume, as that would allow us to skip the static AWS access keys alltogether (so its safer and less verbose).

Hi,
I'm attempting to use OIDC without access-key-id and secret-access-key. Because it's so new, I'm finding the documentation quite difficult to read, but that's probably just me.
jobs:   start-runner:     runs-on: ubuntu-latest     permissions:       id-token: write       contents: read     steps:       - name: Start EC2 runner         id: start-runner         uses: andycockers/ec2-actions-runner/start@main         with:           aws-region: us-west-2           aws-role-to-assume: arn:aws:iam::xxxxxxxxxxxxxx:role/the-role           aws-launch-template: LaunchTemplateName=the-template           github-token: ${{ secrets.GH_ACCESS_TOKEN }}
This is what's returned:
Error: Not authorized to perform sts:AssumeRoleWithWebIdentity
Which I think is a problem with my AWS role.

If you are able to share your working AWS OIDC role/policy combo that would be really useful.

A bit more info:
I made some changes to my role and trust policy according to this article:
https://blog.tedivm.com/guides/2021/10/github-actions-push-to-aws-ecr-without-credentials-oidc/
The use case is not quite the same as what we are doing here, but the basics are relevant.
I now get:
`Starting EC2 instance ...
An error occurred (UnauthorizedOperation) when calling the RunInstances operation: You are not authorized to perform this operation. Encoded authorization failure message:`
There follows an encrypted message which I can't share here as it's got project specific info in it.

Here's a start for the ec2-actions-runner code/documentation changes, making AWS access keys optional: https://github.com/superblk/ec2-actions-runner/pull/11.
Other than that, this procedure appears to work for me:

AWS: Configure IAM IDP as described in GitHub docs
AWS: Create the assumed role (that can start and stop runner EC2s as part of the workflow), and is assumable thru the IAM IDP we created in step 1. Make sure you configure the role trust policy condition to properly check the token.actions.githubusercontent.com:sub claim!
Adjust your workflow per the new Simple (OIDC) section from #11

I believe you are now hitting the permissions in your assumed role, so try adding permissions there (e.g. ec2:RunInstances and ec2:TerminateInstances). I have not yet documented the exact required permissions, but let's try and fix that as part of this effort, too.

Are you able to share the AWS IAM policy you are using?
Here's mine:
{     "Version": "2012-10-17",     "Statement": [         {             "Effect": "Allow",             "Action": [                 "ec2:RunInstances",                 "ec2:TerminateInstances",                 "ec2:DescribeInstances",                 "ec2:DescribeInstanceStatus",                 "ec2:ReplaceIamInstanceProfileAssociation",                 "ec2:AssociateIamInstanceProfile",                 "ec2:CreateTags",                 "ec2:DescribeLaunchTemplates",                 "ec2:DescribeLaunchTemplateVersions"             ],             "Resource": "*",             "Condition": {                 "StringEquals": {                     "ec2:CreateAction": "RunInstances"                 }             }         },         {             "Effect": "Allow",             "Action": "iam:PassRole",             "Resource": "*"         }     ]     }

@andycockerill-cpi I will have another look at this today, hopefully I then have a shareable-quality IAM policy at hand

Here's what worked for me (NB: I'm not configuring an IAM instance profile, so I don't need the instance profile stuff):
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
                "ec2:RunInstances",
                "ec2:TerminateInstances"
            ],
            "Resource": "*"
        },
        {
            "Effect": "Allow",
            "Action": [
                "ec2:CreateTags"
            ],
            "Resource": "*",
            "Condition": {
                "StringEquals": {
                    "ec2:CreateAction": "RunInstances"
                }
            }
        }
    ]
}

NOTE: ec2:TerminateInstances you might be able to  scope better by using conditions (e.g. by EC2 tags).

I think it might also make sense to create a CloudFormation template to set up the IAM OIDC provider and role, that'd help users adopt it.

Looks like here's such a template already: https://github.com/aws-actions/configure-aws-credentials#sample-iam-role-cloudformation-template

Yes, I saw that. I use Terraform to create the infrastructure.

Did the IAM policy snippet I posted above work for you?

No, it didn't, I'm still getting:
An error occurred (UnauthorizedOperation) when calling the RunInstances operation: You are not authorized to perform this operation. Encoded authorization failure message:

Here's the trust policy for the assumed role that I'm using:
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Effect": "Allow",
      "Principal": {
        "Federated": "arn:aws:iam::<account>:oidc-provider/token.actions.githubusercontent.com"
      },
      "Action": [
        "sts:AssumeRoleWithWebIdentity",
        "sts:TagSession"
      ],
      "Condition": {
        "StringLike": {
          "token.actions.githubusercontent.com:sub": "repo:<owner>/<repo>:*"
        }
      }
    }
  ]
}

Other than that, I'd double check that you are successfully assuming the expected role, and that the role has either inline or managed policies that allow the necessary actions (these may vary depending on what you are specifying in your launch template) and that e.g. organization SCPs are not blocking the actions.
You may find CloudTrail and this useful in debugging IAM permissions.

If you can share which parameters you are setting in your launch template, that might also help me help you

Will do, thanks for all your help.

I've now updated the documentation somewhat, let me know if that makes any sense

Feel free to give https://github.com/superblk/ec2-actions-runner/releases/tag/v0.9.0 a spin, too

Here's the Terraform that we are using to create the launch template:
resource "aws_launch_template" "template" {
  name = "${var.prefix}-github-template"
  disable_api_termination = false
  iam_instance_profile {
    name = var.iam_instance_profile
  }
  image_id = var.image_id
  instance_initiated_shutdown_behavior = "terminate"
  instance_type = var.instance_type
  vpc_security_group_ids = var.vpc_security_group_ids
  network_interfaces {
    subnet_id = var.subnet_id
  }
  update_default_version = true
  cpu_options {
    core_count = var.core_count
    threads_per_core = var.threads_per_core
  }
  tag_specifications {
    resource_type = "instance"
    tags = {
      Name = "${var.prefix}-github-runner"
    }
  }
  instance_market_options {
    market_type = "spot"

    spot_options{
      max_price = var.max_price
      spot_instance_type = "one-time"
    }
  }
}

Here's the json output from the encrypted error message. I think this means it's having issues with the instance profile.
{
    "allowed": false,
    "explicitDeny": false,
    "matchedStatements": {
        "items": []
    },
    "failures": {
        "items": []
    },
    "context": {
        "principal": {
            "id": "AROA5IBV2GP76MOAM4PMU:ec2-actions-runner-start",
            "arn": "arn:aws:sts::xxxx:assumed-role/cp-embedded-ore-global-github-runner-assume-role/ec2-actions-runner-start"
        },
        "action": "iam:PassRole",
        "resource": "arn:aws:iam::xxxx:role/cp-embedded-ore-global-github-runner",
        "conditions": {
            "items": [
                {
                    "key": "aws:Region",
                    "values": {
                        "items": [
                            {
                                "value": "us-west-2"
                            }
                        ]
                    }
                },
                {
                    "key": "aws:Service",
                    "values": {
                        "items": [
                            {
                                "value": "ec2"
                            }
                        ]
                    }
                },
                {
                    "key": "aws:Resource",
                    "values": {
                        "items": [
                            {
                                "value": "role/cp-embedded-ore-global-github-runner"
                            }
                        ]
                    }
                },
                {
                    "key": "iam:RoleName",
                    "values": {
                        "items": [
                            {
                                "value": "cp-embedded-ore-global-github-runner"
                            }
                        ]
                    }
                },
                {
                    "key": "aws:Type",
                    "values": {
                        "items": [
                            {
                                "value": "role"
                            }
                        ]
                    }
                },
                {
                    "key": "aws:Account",
                    "values": {
                        "items": [
                            {
                                "value": "xxxx"
                            }
                        ]
                    }
                },
                {
                    "key": "aws:ARN",
                    "values": {
                        "items": [
                            {
                                "value": "arn:aws:iam::xxxx:role/cp-embedded-ore-global-github-runner"
                            }
                        ]
                    }
                }
            ]
        }
    }
}

@andycockerill-cpi You need to add this statement to your policy
{
    "Effect": "Allow",
    "Action": "iam:PassRole",
    "Resource": "arn:aws:iam::<account>:role/<role for EC2>
}

This then allows RunInstances to pass that role to the EC2 instance when its launched.

I will amend the documentation in this regard, and also look into if it'd make sense to rename the aws-role-to-assume input to better describe that is used for starting/stopping the instance (and, in particular, is not assigned to the EC2 instance itself)

Thank you, once I added:
{
            "Effect": "Allow",
            "Action": "iam:PassRole",
            "Resource": "*"
        }

Then the instance launched as expected.

@andycockerill-cpi Cool :+1:
I've now amended the docs for release v0.9.1.
Let me know if you need anything else, otherwise I will close this issue.

@andycockerill-cpi I assume this is sorted out, so closing this issue


Create a ReadOnly user per Database.

In some cases it's could be handy to have a read only user to give some access to non-technical people.
In the company I'm currently working, we could use such a user per database. I'd say it could be an optional field.
kind: Database
spec:
  readOnlyUser: true

The password could be stored in the database secret as:
PG_PASSWORD: ***
READ_ONLY_PG_PASSWORD: ***
READ_ONLY_PG_USERNAME: ${username}-readonly

It can be closed because of #13


explicitely state that enums must use correct casing

in the latest version we state that parsing must be done case sensitively, b
but let's also clearly state that enum values (like alarm states) must use the exact casing stated in the spec.

Fixed in b5c7c32d46698825796cb09a5c3253e459704749

done


Add the ability to traffic Router to customize default https cert

This PR closes #7089
This PR adds the ability to provide customized attributes to the HTTPS default certificate.

Which Traffic Control components are affected by this PR?

Documentation
Traffic Router

What is the best way to verify this PR?

Make sure all the tests pass.
Try putting in different values for the properties in the https.properties file and make sure that the resulting default cert shows the right attributes.
If this is a bugfix, which Traffic Control versions contained the bug?

master

PR submission checklist

[x] This PR has tests
[x] This PR has documentation
[x] This PR has a CHANGELOG.md entry
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

From the logs, there is a PMD error:
2022-10-13T22:00:23.5876488Z [INFO] PMD Failure: org.apache.traffic_control.traffic_router.secure.CertificateRegistry:155 Rule:AvoidPrintStackTrace Priority:3 Avoid printStackTrace(); use a logger call instead..


Aggregation bucket results have wrong keys or are not returned at all

NEST/Elasticsearch.Net version: 7.17.5
Elasticsearch version: 8.6.2
.NET runtime version: .NET 6.0
Operating system version: Fedora 38, elasticsearch is running in Docker
Description of the problem including expected versus actual behavior:
Here's a simple query I am running:
var someDescriptor = new SearchDescriptor<MyModel>(Indices.Index(new[] { "someindex" }))
            .Aggregations(ag => ag
                .Terms("some_term_agg", term => term
                    .Field(m => m.CityCode)
                    .Size(10)));

var someResult = await _client.SearchAsync<PrecomputedPackage>(
    someDescriptor,
    cancellationToken);

The corresponding REST API request JSON is as follows:
{
  "aggs": {
    "some_term_agg": {
      "terms": {
        "field": "cityCode",
        "size": 10
      }
    }
  }
}

(The above JSON was generated with _client.RequestResponseSerializer.SerializeToString(someDescriptor))
The response I'm getting with NEST contains 8 buckets:

However, each bucket is empty:

When I execute my query with elasticsearch's REST API, I get:
  "aggregations": {
    "some_term_agg": {
      "doc_count_error_upper_bound": 0,
      "sum_other_doc_count": 0,
      "buckets": [
        {
          "key": "BCN",
          "doc_count": 134
        },
        {
          "key": "ROM",
          "doc_count": 134
        },
        {
          "key": "LCJ",
          "doc_count": 132
        },
        {
          "key": "LIZ",
          "doc_count": 130
        },
        {
          "key": "WAW",
          "doc_count": 126
        },
        {
          "key": "WRO",
          "doc_count": 120
        },
        {
          "key": "BER",
          "doc_count": 115
        },
        {
          "key": "LON",
          "doc_count": 109
        }
      ]
    }
  }

(I skipped the documents, they are alright in both NEST and REST API responses)
Expected behavior
I should get the same buckets values using NEST, as I do when using REST API.
This issue occurred to me while I was trying to prepare a simple reproduction example for another issue where buckets have values, but their keys are wrong - all keys have the same values equal to the name of the aggregation (e.g, "some_term_agg") instead of the value being aggreagated (like city codes).

Hi, I'll keep this as a NEST bug until I have time to check in detail. NEST does not have the highest priority at the moment.
In the meantime I would suggest to evaluate if it makes sense for you to use the new 8.x client side-by-side with NEST in your project.


Kubernetes: Services not working

If you install Flannel as Kubernetes Networking Plugin using https://raw.githubusercontent.com/coreos/flannel/master/Documentation/kube-flannel.yml on a simple single node cluster on a baremetal Fedora 30 Minimal server with containerd (from Fedora) created by kubeadm init --pod-network-cidr=<IP_ADDRESS>/16, then the kubedns pods (shown by kubectl get pods -n kube-system) remain in Status CrashLoopBackOff forever.
I've debugged this, and figured that it's because kubectl logs -n kube-system coredns-... hits Get https://<IP_ADDRESS>:443/api/v1/namespaces?limit=500&resourceVersion=0: dial tcp <IP_ADDRESS>:443: connect: no route to host ... here <IP_ADDRESS> is the IP which kubectl get services shows as the CLUSTER-IP for kubernetes - the apiserver service.
FYI when I install kube-router instead of Flannel using kubectl apply -f https://raw.githubusercontent.com/cloudnativelabs/kube-router/master/daemonset/kubeadm-kuberouter.yaml this this works.

@vorburger Can you also list the endpoints for the services?
kubectl get endpoints --all-namespaces```

Just to rule out the fact that kube-flannel.yml has a different network cidr than the one provided to kubelet.

Last few days I had (roughly) the same problem.
In my case the solution was to disable the firewalld .

I've encounter the same, it need manual delete coredns pod ( so coredns restart ok ).


Reading empty lines not possible

Description:
I have empty lines like ",,,,," in my csv file and want to read them using doc.GetColumn<double>("...");. Empty lines should have a default value or need to be skipped. I tried using rapidcsv::LineReaderParams(true /* pSkipCommentLines */, ',' /* pCommentPrefix */, true /* pSkipEmptyLines */) but rapidcsv still tries to read the line and fails. How do I skip lines like this?

Such lines cannot be ignored currently. One can however use ConverterParams and specify pHasDefaultConverter = true to have those empty cells interpreted as default values (which may be customized using pDefaultFloat and pDefaultInteger). By default they would be 0 for integers and std::numeric_limits<long double>::signaling_NaN() for floats.

I will proceed to close this issue, feel free to re-open it if above suggestion did not help. In this case, please provide a small code sample and CSV file example.


Can we auto check Physics when a subcategory is selected in adv search?

On the advanced search, if a user selects one of the Physics sub archives can we automatically check the Physics box?

Yes. Should we also auto-check date options, eg specific year, when there is input to the corresponding field?

The short answer to that question (should we auto check any field that has data entered) is yes from a UX perspective.
We chose to take a shortcut and not do the autochecking explicitly in this round because it would add ajax features that we weren't ready to support, if I recall correctly.

ARXIVNG-298 - When user enters data in linked fields, their parent checkbox should be automatically checked.


show progress on rsync

Is this now closed @jshrake ?

No. The above commit was optimistic, but unfortunately, not a fix.

How do you show multi-destination rsync progress, anyway?

If there is a mode where rsync will print out progress in lines, instead of as a progress bar (pv has an option like this), then you could conceivably interleave them.  It wouldn't be perfect but it would be some info.


💡[Feature]:  Customer Segmentation Analysis

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I will be analyzing the shopping behaviour of the customers based on demographic characteristics.
Use Case
It can be used to produce a better strategy for marketing.
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

hello ,I want to contribute in this project .Can you assign me ?
@sanjay-kv


Print total run time in the summary

Print total run time in the summary (on success). Useful for getting an idea of the performance of the harness, especially when runtime is long (minutes-hours)

Thanks!


Microsoft.OperationalInsights: Typo, upper case and other minor corrections.

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

/azp run automation - sdk

@MyronFanQiu How i can over come the breaking changes stuff, property was removed with intention.

Can one of the admins verify this patch?

hi @MyronFanQiu, how i can overcome the "breaking changes" issue:
message: "The new version is missing a property found in the old version. Was 'dataSourceType' renamed or removed?",
the property was removed with intention, it shouldn't be with in the request content in the context of Linked Storage Accounts upsert operation.

@Dudi119 Can you share the context with us? You just want to remove the data source type since it's already provided through another parameter. Is it correct? I think using a special create model for put method is not best practice. The response should be same with the input.

If you don't need to send data source type, you can mark it read_only

/azp run automation - sdk

Just to comment - there are no users to this feature, its still under integration, the official document is not even visible to customers.

Just to comment - there are no users to this feature, its still under integration, the official document is not even visible to customers.

Hi @akning-ms. This field is redundant since there is a separate parameter to set it. And service team confirm that no users are using it. So it's not a real breaking changes. Could you please help force merge this one?


[alembic] Alembic fails to build when Debug mode is manually turned off.

Host Environment

OS: Windows
Compiler: revision

To Reproduce
Steps to reproduce the behavior:
Add: set(VCPKG_BUILD_TYPE release) to the x64-windows triplet.
Failure logs
CMake Error at ports/alembic/portfile.cmake:51 (file):
  file must be called with at least two arguments.
Call Stack (most recent call first):
  scripts/ports.cmake:79 (include)

Additional context
Inelegant patch I used to get around it:
diff --git ports/alembic/portfile.cmake ports/alembic/portfile.cmake
index 6c9a2b57d..1348c8b38 100644
--- ports/alembic/portfile.cmake
+++ ports/alembic/portfile.cmake
@@ -46,22 +46,23 @@ file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/share)

 if(VCPKG_TARGET_IS_WINDOWS)
     file(GLOB EXE ${CURRENT_PACKAGES_DIR}/bin/*.exe)
-    file(GLOB DEBUG_EXE ${CURRENT_PACKAGES_DIR}/debug/bin/*.exe)
     file(REMOVE ${EXE})
-    file(REMOVE ${DEBUG_EXE})
-
     file(RENAME ${CURRENT_PACKAGES_DIR}/lib/Alembic.dll ${CURRENT_PACKAGES_DIR}/bin/Alembic.dll)
-    file(RENAME ${CURRENT_PACKAGES_DIR}/debug/lib/Alembic.dll ${CURRENT_PACKAGES_DIR}/debug/bin/Alembic.dll)
-
-    file(READ ${CURRENT_PACKAGES_DIR}/share/${PORT}/AlembicTargets-debug.cmake DEBUG_CONFIG)
-    string(REPLACE "\${_IMPORT_PREFIX}/debug/lib/Alembic.dll"
-                   "\${_IMPORT_PREFIX}/debug/bin/Alembic.dll" DEBUG_CONFIG "${DEBUG_CONFIG}")
-    file(WRITE ${CURRENT_PACKAGES_DIR}/share/${PORT}/AlembicTargets-debug.cmake "${DEBUG_CONFIG}")
-
     file(READ ${CURRENT_PACKAGES_DIR}/share/${PORT}/AlembicTargets-release.cmake RELEASE_CONFIG)
     string(REPLACE "\${_IMPORT_PREFIX}/lib/Alembic.dll"
                    "\${_IMPORT_PREFIX}/bin/Alembic.dll" RELEASE_CONFIG "${RELEASE_CONFIG}")
     file(WRITE ${CURRENT_PACKAGES_DIR}/share/${PORT}/AlembicTargets-release.cmake "${RELEASE_CONFIG}")
+
+    file(GLOB DEBUG_EXE ${CURRENT_PACKAGES_DIR}/debug/bin/*.exe)
+    if (DEBUG_EXE)
+        file(REMOVE ${DEBUG_EXE})
+        file(RENAME ${CURRENT_PACKAGES_DIR}/debug/lib/Alembic.dll ${CURRENT_PACKAGES_DIR}/debug/bin/Alembic.dll)
+        file(READ ${CURRENT_PACKAGES_DIR}/share/${PORT}/AlembicTargets-debug.cmake DEBUG_CONFIG)                       +        string(REPLACE "\${_IMPORT_PREFIX}/debug/lib/Alembic.dll"                                                      +                       "\${_IMPORT_PREFIX}/debug/bin/Alembic.dll" DEBUG_CONFIG "${DEBUG_CONFIG}")                      +        file(WRITE ${CURRENT_PACKAGES_DIR}/share/${PORT}/AlembicTargets-debug.cmake "${DEBUG_CONFIG}")                 +    endif()                                                                                +                                                                                else()                                                                                file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/bin)                                                                        file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/bin)

Hi @alister-chowdhury
Thanks for posting this issue.
Sorry for the long delay.
Since vcpkg will build all ports with both debug type and release type by default.
You can use overlay to build alembic if you just want to build release type. Please see the doc https://github.com/microsoft/vcpkg/blob/master/docs/specifications/ports-overlay.md


Update character section of the application form

Background
A review of the Good Character Guidance has recently taken place, the resulting impact is that there will be amendments required to some of the questions asked of candidates in the character section of the application form to align with the changes. The changes should apply only to exercises opening on or after 15 October 2024, i.e. historic and current applications prior to that date should use the existing character questions. The deadline for changes to the character section to be tested and live
A companion tickets for application view/edit has also been created.
User Story
As JAC, I would like the Character section of the Application form to be updated so that it is in line with the changes agreed by the board.
Feature(s) Description

[ ] Changes to copy as per the document attached

[ ] In Admin, specify the character guidance options according to when the exercise was launched:

For exercises launched, i.e. Open for applications date is, on or after 15/10/24, the 2024 guidance is presented

For exercises launched, i.e. Open for applications date was, before 15/10/24, the 2020 guidance is presented

[ ] Whichever radio button is selected, the content of the tickboxes selected appears in the SCC Annex download and on screen

Acceptance Criteria
It's done when:

All exercises launching on or after 15/10/24 feature the updated Character questions on Apply
All prior exercises feature the current Character questions
Historic (completed) applications on Apply conform with the above

Definition of Done

[ ] User stories/acceptance criteria met
[ ] Internal reviews passed (feedback actioned)
[ ] User testing passed
[ ] Relevant technical documentation updated
[ ] User guidance updated
[ ] Deployed and merged without errors

User Testing Steps
Test the new questions.
Feature Champion
Joanne Dixon

Hey team! Please add your planning poker estimate with Zenhub @drieJAC @HalcyonJAC @tomlovesgithub @warrensearle

@drieJAC I have changed the request here following your suggestion - much less hassle that way. Thanks for the suggestion!

@nickaddy Should we also update the Welsh translation?

@HalcyonJAC I've just submitted the text for Welsh translation; it usually takes a few days to come back. I'm going to add this as a task on the ticket - pls feel free to re-estimate accordingly.

@HalcyonJAC I have shared with Joanne Dixon (Secretariat and customer) for feedback.


List out the Special Rules and/or Objectives

List out the Special Rules and/or Objectives: not necessarily the full text, but just the names could be helpful

https://www.reddit.com/r/shadowsofbrimstone/comments/7mptca/brimstone_random_mission_picker/drwijtw/


Website build for Heron 0.14.1

See http://lucperkins.github.io/heron/ for a running version

looks good to me!

Looks good, will merge. Totally unrelated, but I think it's too hard for users to find the mailing list currently. I think it's only hidden in the nav bar. As a result we get tons of questions as github issues and very little mailing list traffic. We should more prominently steer people to the list for help somewhere.


Fixes #34 - Ubuntu Xenial and up support

Instead of adding every newer release of Ubuntu, let's assume the su_group will remain the same, until the next change is necessary.

@robinbowes All test a passing.  I think its time for official Xenial support?

Thanks for fixing the tests.


Can't promote proxy after node failure

I have a test setup of 3 nodes running v20161114.0 with one app. I powered off one node and the app kept alive, but some internal apps kept failing / recovering. For some time the dashboard was unavailable.
I added one node as replacement (with flynn-host init --peer-ips). After that the internal apps are running stable again. But I cannot promote the new node to peer (host.go:157: unknown_error: Something went wrong).
Debug Info:
peer 1: https://gist.github.com/a98daa3b188f74cfdf5e8a7e43d66d6e
peer 2: https://gist.github.com/431c9368e5fef8bcab849a5a32ae3006
proxy (new node): https://gist.github.com/6329b20e43b2aede192f8c195bb84aa5

Looks like the issue here is the current process requires the failed node to be demoted first.
I think it might be possible to make a promotion work in this case though which would be less confusing. You could try demoting the failed node first and before promoting the replacement and confirm that works that would be great.

I forced demotion and it seems to work (Forcefully removed peer).
but promotion doesn't work yet (host.go:157: unknown_error: Something went wrong).
logs: https://gist.github.com/cce809b16b49b9753cd7b6b673059dee

For some reason <IP_ADDRESS> doesn't seem to be reachable from ubuntu4. But if these logs are correct then a leader has been elected and the discoverd cluster should be working.

yeah. <IP_ADDRESS> is the dropped node.


Try to fix Travis jobs

awesome, thanks @XVilka

for future reference, see example error here: https://travis-ci.org/williballenthin/python-idb/jobs/370421930


[lexical] Bug Fix: lines were being deleted with deleteLine

Description
When I pressed ⌘ + Delete, the line was deleted. This is different from the behavior of other editors (such as textarea), so some users may find it to be a bug. Please see the video for more information about the behavior.
Before
https://github.com/user-attachments/assets/c03a4503-4ab6-4639-afbc-3ec17d2089ce
After
https://github.com/user-attachments/assets/34cd5c7b-5865-4d33-97fa-f9dd89679cc5

I think the logic might also not be correct, it seems to me that this extend behavior only happens in other editors (I tested VSCode and Chrome's textarea on github) when the selection is collapsed at offset 0.

@etrepum What does that mean? Please explain in more detail.

A collapsed selection is where the focus and anchor are the same node and offset. It displays as a cursor, no text is highlighted.


Hot module replacement not working on the todos example

I'm using the todos example app as a quick boilerplate for some Redux testing and I found out that the hot module replacement isn't working.
I'm trying to modify the Header component.

Hi @andrerpena, I'm not able to reproduce the problem, it is working as expected for me. Can you provide further details?

Please provide a way to reproduce.


bgp: BGP Control Plane modularization

This work converts the BGP Control Plane controller and BGP Route Manager into hive cells, leaving as much of the existing code intact. These cells are now hooked into the agent hive directly. The daemon now takes the Controller as parameter both to preserve the behavior of setting the controller as a field value on the daemon and so the BGP controllers lifecycle events are invoked.
This is the first PR in a series of prep work for SVC announcements. Future PRs will break up the single cell into more granular pieces which should improve the test ability and extensibility of the BGP Control Plane.

/test

/mlh new-flake Cilium-PR-K8s-1.25-kernel-net-next

Alright got 2 approvals. Ignoring doc-structure for now since they were added due to a doc commit added to the wrong branch on accident (since been resolved).
Almost all tests are green, except for some flakes:

ConformanceAKS is failing in a test to connect to cloudflare to-fqdns/pod-to-world/https-to-one-one-one-one-index-1: cilium-test/client-769787f6f8-n9flc (<IP_ADDRESS>) -> one-one-one-one-https-index (one.one.one.one:443) which is a trend at the moment.
TravisCI is hitting #22224
test-1.16-4.9 and test-1.25-net-next are both hitting #22404. This is a new flake related to TLS policy which seems unrelated to this work.
runtime (test-runtime) hits the same flake as travis #22224

@dylandreimerink @joestringer Unfortunaltely this broke Travis CI like below, not sure why I did not see this before merging:
=== RUN   Test
level=info msg="Creating etcd client" ConfigPath= KeepAliveHeartbeat=15s KeepAliveTimeout=25s RateLimit=20 subsys=kvstore
level=info msg="Connecting to etcd server..." config= endpoints="[http://<IP_ADDRESS>:4002]" subsys=kvstore
level=error msg="Invoke failed" ="cmd.glob..func2 (daemon_main.go:1627)" error="could not build arguments for function \"github.com/cilium/cilium/daemon/cmd\".glob..func2 (/home/ubuntu/go/src/github.com/cilium/cilium/daemon/cmd/daemon_main.go:1627): failed to build promise.Promise[*github.com/cilium/cilium/daemon/cmd.Daemon]: could not build arguments for function \"github.com/cilium/cilium/daemon/cmd\".newDaemonPromise (/home/ubuntu/go/src/github.com/cilium/cilium/daemon/cmd/daemon_main.go:1642): failed to build *agent.Controller: missing dependencies for function \"github.com/cilium/cilium/pkg/bgpv1/agent\".NewController (/home/ubuntu/go/src/github.com/cilium/cilium/pkg/bgpv1/agent/controller.go:188): missing type: *option.DaemonConfig" subsys=hive

----------------------------------------------------------------------
FAIL: daemon_test.go:223: DaemonEtcdSuite.SetUpTest

daemon_test.go:224:
    e.DaemonSuite.SetUpTest(c)
daemon_test.go:157:
    c.Assert(err, IsNil)
... value dig.errArgumentsFailed = could not build arguments for function "github.com/cilium/cilium/daemon/cmd".glob..func2 (/home/ubuntu/go/src/github.com/cilium/cilium/daemon/cmd/daemon_main.go:1627): failed to build promise.Promise[*github.com/cilium/cilium/daemon/cmd.Daemon]: could not build arguments for function "github.com/cilium/cilium/daemon/cmd".newDaemonPromise (/home/ubuntu/go/src/github.com/cilium/cilium/daemon/cmd/daemon_main.go:1642): failed to build *agent.Controller: missing dependencies for function "github.com/cilium/cilium/pkg/bgpv1/agent".NewController (/home/ubuntu/go/src/github.com/cilium/cilium/pkg/bgpv1/agent/controller.go:188): missing type: *option.DaemonConfig

As you see this has to do with the new hive thing that I don't know much about, but apparently some of the changes made on the production code would also need to be reflected in the test suite.
To reproduce this locally, you can:
make start-kvstores
cd daemon/cmd
go test -v -tags=integration_tests ./...

I verified this by reverting this commit and trying again, and the test passes.


Actually store results in results folder

A results folder is created initially when the server starts up: https://github.com/e7d/speedtest/blob/master/packages/server/server.js#L15-L17
But it's never actually utilized. Thus, attempting to bind /app/results to the host in docker does nothing.

Hm... nm... it appears the "results" dir is injected manually each time:
https://github.com/e7d/speedtest/blob/master/packages/server/src/resultWritter.js#L45