Add a way to merge and or inherit styles

The class argument of the view macro only accepts one class name, so there is no way to modularize the styling of components with the stylers macro, instead having to re-declare a style that we want to reuse for a single change (in a highly component-based project this becomes especially unwieldy). This is exacerbated by the fact that the generated stylesheets have class markers like "l-123456" attached to the html they are styling, so they only work in the views they are attached to, making it impossible to define a global stylesheet and have per component style overrides with the macro alone. It would also be nice if the macro optionally propagated and merged classes defined in a parent view to a child component's view, but maybe that's better handled upstream.

Yeah it is good idea to add modularization to increase the resuability. I am thinking some way to achieve this since we are creating css file for each macro usage and storing the corresponding css in that file. we need some way to coordinate between these things. can we use some macro like style_str!{} which will retrurn the style string instead storing it in file. then we can embed that string using  tag.

First of all @gbj thank you for fixing that issue. Now I have added two new macros to get the style string directly instead of saving it to the file. I think this will solve the modularization problem reported by @WafflePersonThing. It will look something like below code snippet. the working example is here.

use leptos::*;
use stylers::{style, style_str};

#[component]
pub fn GreenButton(cx: Scope) -> impl IntoView {
    let (local_class, style_val) = style_str! {
        button{
            background-color: green;
        }
        button:hover{
            background-color: yellow;
            color: green;
        }
    };
    let common_class = button_style();
    let class_name = format!("{} {}", common_class, local_class);

    view! {cx, class = {class_name.clone()},
        <style>{style_val}</style>
        <button>"I am green button"</button>
    }
}

#[component]
pub fn BlueButton(cx: Scope) -> impl IntoView {
    let (local_class, style_val) = style_str! {"BlueButton",
        button{
            background-color: blue;
        }
        button:hover{
            background-color: yellow;
            color: blue;
        }
    };
    let common_class = button_style();
    let class_name = format!("{} {}", common_class, local_class);

    view! {cx, class = {class_name.clone()},
        <style>{style_val}</style>
        <button>"I am blue button"</button>
    }
}

pub fn button_style() -> String {
    //note: we can even use style_str and get the style string wherever we use this style
    // but that will populate same style in multiple places at the DOM.
    style! {"ButtonStyle",
        button {
            background-color: #EA4C89;
            border-radius: 8px;
            border-style: none;
            box-sizing: border-box;
            color: yellow;
            cursor: pointer;
            display: inline-block;
            font-family: r#"Haas Grot Text R Web"#, r#"Helvetica Neue"#, Helvetica, Arial, sans-serif;
            font-size: 14px;
            font-weight: 500;
            height: 40px;
            line-height: 20px;
            list-style: none;
            margin: 0;
            outline: none;
            padding: 10px 16px;
            position: relative;
            text-align: center;
            text-decoration: none;
            transition: color 100ms;
            vertical-align: baseline;
            user-select: none;
            -webkit-user-select: none;
        }
        button:hover{
            background-color: yellow;
        }
    }.to_string()
}

For that second problem I think if we want child componets to use styles declared in a parent component that can be achieved by passing the class_name to the child componet view macro.  the code will look something like below. Working example is here.

use leptos::*;
use stylers::{style, style_str};

#[component]
pub fn Parent(cx: Scope) -> impl IntoView {
    let class_name = style! {"Parent",
        button {
            background-color: green;
            border-radius: 8px;
            border-style: none;
            box-sizing: border-box;
            color: yellow;
            cursor: pointer;
            display: inline-block;
            font-family: r#"Haas Grot Text R Web"#, r#"Helvetica Neue"#, Helvetica, Arial, sans-serif;
            font-size: 14px;
            font-weight: 500;
            height: 40px;
            line-height: 20px;
            list-style: none;
            margin: 0;
            outline: none;
            padding: 10px 16px;
            position: relative;
            text-align: center;
            text-decoration: none;
            transition: color 100ms;
            vertical-align: baseline;
            user-select: none;
            -webkit-user-select: none;
        }
        button:hover{
            background-color: yellow;
            color: green;
        }
    };

    view! {cx, class = {class_name},
        <button>"I am green button"</button>
        <Child class_name={class_name.to_string()}/>
    }
}

#[component]
fn Child(cx: Scope, class_name: String) -> impl IntoView {
    let (local_class, style_val) = style_str! {
        button{
            background-color: blue;
        }
        button:hover{
            background-color: yellow;
            color: blue;
        }
    };
    let class_name = format!("{} {}", class_name, local_class);
    view! {cx, class = {class_name.clone()},
        <style>{style_val}</style>
        <button>"I am blue button"</button>
    }
}

Check out these examples. Please feel free to add your comments.

Thank you for your suggestion, As you are saying we can use formatcp macro in examples. I will update them.

Fixed this issue in version v0.3.0.


Person-detection Transformer

Hello,
I've read the PRTR paper and the issue #3. However, I am still not 100% clear about how to fine-tune DETR for person detection by myself. Can you please share more details about it, e.g., how to adjust DETR as well as data loading of COCO for only detecting persons?
Btw have you also fine-tuned deformable DETR for person detection?
Thanks in advance!

We didn't try to fine-tune the deformable DETR for person detection.
For the two-stage variant, you can use any off-the-shelf detector, or fine-tune the DETR. You can
make it only focus on person detection by training it on COCO human pose dataset.


Update jackson-databind to <IP_ADDRESS>

Fix #1854

I'm going to merge this so I can rebase it into my build system update.


Merge Single- and MultiLabelClassifyResult

Resolves #30089

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.AI.TextAnalytics

/azp run net - textanalytics - ci

/azp run net - textanalytics - ci

LGTM. Were there no instances on the README.md to update?

No samples in a README that needed updating, no. We don't want to make READMEs to large. Linking to all the samples at the top like we did with CLU might be a better option for a less-overwhelming README, IMO.

LGTM. Were there no instances on the README.md to update?

No samples in a README that needed updating, no. We don't want to make READMEs to large. Linking to all the samples at the top like we did with CLU might be a better option for a less-overwhelming README, IMO.

Yeah I think all languages intentionally linked out to the samples in the README to not overcrowd it, but IIRC we had a few instances of calling it "category" instead of "label" on the README.


Crash when calling TodoReview while it's tab is already open

Hi,
Whenever I run one of the TodoReview commands and the TodoReview tab is already open (I ran the command before), instead of switching to that tab or refreshing it, Sublime text  (and my whole computer) freezes for a minute until plugin_host crashes.
I am using ST3 on Windows by the way

+1 yep. can confirm

Is there a new sublime build causing this? Never had this issue before.
Away from an environment where I can test this. Any console output? OS? Sublime version?

Just to clarify.. I see a similar issue but my pc does not freeze. (Windows 7 ST3 Build 3083).
The problem I've noticed is when TodoReview tab is already open and I run the command to execute again, It doesn't switch to TodoReview tab and I see a blank page as well.

Has this functionality ever worked for your @diego1araujo?

I am using ST build 3083 on Windows 8

+1 same here ;(

Fixed by #133 and 5105f7133883f3522c1b417fd231d49adae0de06
Thanks for the report.

You are welcome, unfortunatly, I am sorry to say that  v3.0.7 has not fixed this issue, I still get the huge  freeze when running TodoReview while its tab is still open.

Still experiencing similar issue:
Traceback (most recent call last):
  File "C:\Program Files\Sublime Text 3\sublime_plugin.py", line 550, in run_
    return self.run(edit, **args)
  File "C:\Users\Fichte\AppData\Roaming\Sublime Text 3\Packages\TodoReview\TodoReview.py", line 233, in run
    self.draw_header()
  File "C:\Users\Fichte\AppData\Roaming\Sublime Text 3\Packages\TodoReview\TodoReview.py", line 292, in draw_header
    date = datetime.datetime.now().strftime(datestr)
TypeError: strftime() argument 1 must be str, not None

Only occurs when the TodoReviw view is open already. Trying again works.

@FichteFoll Just fixed that in 636914b for you, seems like it was the same issue as #133, i'm not sure why the sublime settings objects stop working out of the blue.

Thanks. I looked into the code briefly but couldn't spot an obvious flaw during that time.
The fact that it is so reliably reproducable and I haven't had any problems with settings objects recently whatsoever leads to the thought it might be an error in TodoReview's code, however.


New Menu Look

Coverage decreased (-0.03%) to 94.506% when pulling 1acdac32d8198fac61185f84bba3ab96209be2ef on dev into d8fba3be94e4259a2528c2a9ce7633586a150fb6 on master.


Add MLPerf logging

This PR contributes a callback MLPerfCallback, which will create a submission directory and results file that is compliant with the MLPerf rules for Training v1.1 (e.g. it passes the mlperf logging's package checker).
Upon usage, a submission folder structure will be created with the root_folder as the base and the following directories:
    root_folder/
        results/
            [system_name]/
                [benchmark]/
                    results_0.txt
                    results_1.txt
                    ...
        systems/
            [system_name].json

For each training run, a results file will be created, e.g.
:::MLLOG {"namespace": "", "time_ms":<PHONE_NUMBER>286, "event_type": "INTERVAL_START", "key": "cache_clear", "value": null, "metadata": {"file": "/composer/composer/callbacks/mlperf.py", "lineno": 109}}
:::MLLOG {"namespace": "", "time_ms":<PHONE_NUMBER>438, "event_type": "INTERVAL_START", "key": "init_start", "value": null, "metadata": {"file": "/composer/composer/callbacks/mlperf.py", "lineno": 110}}
...

The entire directory can then be submitted to mlperf, and checked with the package_checker in https://github.com/mlcommons/logging.
Currently this callback only supports the OPEN division benchmark.
This PR is gated by:

[ ]  https://github.com/mlcommons/logging/issues/218
[x] https://github.com/mosaicml/composer/issues/830

TODO:

[ ] generate and validate ResNet-50 run on 8x A100 GPUs.
[x] create Hparams object

Thanks for the comments, this is ready for another review! I did not accept all the suggested changes, so please take a look. A few opens:

Not sure I implemented file_artifact properly
since cache clearing usually done with sudo /sbin/sysctl vm.drop_caches=3, is system-specific, I decided to accept a cache_clear_cmd that is run with os.system at the appropriate time. However, this seems dangerous to accept running arbitrary commands; I am open to other suggestions.


Add ReSharper settings file to the repository

What was the problem/requirement? (What/Why)
To make the ReSharper settings file available to all contributors of the Ambit plugin.
What was the solution? (How)
Added the ReSharper settings file and a relevant README with the installation and usage instructions.
What artifacts are related to this change?
Issues:  P56990807
What is the impact of this change?
N/A
Are you adding any new dependencies to the system?
No
How were these changes tested?
Locally

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Currently blocked. Pending investigation upon @brhook-aws return

PR is ready for review again. @brhook-aws @kris-work


Fix jetpack fuel bug

Fixes https://github.com/space-wizards/space-station-14/issues/19666
Not tested, but seems like an obvious bug.

Draft until I can test this


Add Incident model

resolves #25

Looks good! Moving forward, here's what we have to do:

Add validation to incident model input (and MESSAGE_CONSTRAINTS otherwise). @Yoshi275 to follow up.
Add JavaFX support to Incident model, while not removing Person GUI links. @Yoshi275 to follow up.


@chainlit/react-client is outdated on npmjs.com

The most recent version of the package on npm appears to be 0.1.2.  There are several new features that are not supported by that version of the react client (Chain of thought display config, display name) so attempting to build a custom frontend with those features and the client package from npm causes errors due to missing properties (eg error TS2339: Property 'cot' does not exist on type '{ name: string; description?: string | undefined; default_collapse_content?: boolean | undefined; github?: string | undefined; theme: any; custom_css?: string | undefined; custom_js?: string | undefined; custom_font?: string | undefined; custom_meta_image_url?: string | undefined; }'.
It appears that the version of the client has been incremented to 0.1.3 with a recent Chainlit release.  Would it be possible to get the most recent version of the react client published to npm?  I would prefer to just use the package in my project instead of having to built it myself.

@willydouhard Happy to facilitate the publication if you tell me how and/or give access.

Same problem here. Could you please release the react client @willydouhard ?

Same here. Could you please release the latest react client @willydouhard ?


Error starting hass 0.34

Home Assistant release (hass --version):
0.34
Python release (python3 --version):
3.4.2
Component/platform:
Core
Description of problem:
Home Assistant had trouble connecting to the server. I cannot access to the web.
Expected:
No problems
Traceback (if applicable):
6-12-04 07:29:04 homeassistant.core: Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.4/asyncio/tasks.py", line 237, in _step
    result = next(coro)
  File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/homeassistant/components/http/__init__.py", line 153, in start_server
    yield from server.start()
  File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/homeassistant/components/http/__init__.py", line 282, in start
    self.cors.add(route)
  File "/home/homeassistant/.homeassistant/deps/aiohttp_cors/cors_config.py", line 407, in add
    routing_entity, config)
  File "/home/homeassistant/.homeassistant/deps/aiohttp_cors/cors_config.py", line 136, in add
    routing_entity, self._preflight_handler)
  File "/home/homeassistant/.homeassistant/deps/aiohttp_cors/urldispatcher_router_adapter.py", line 331, in add_preflight_handler
    preflight_route = route.resource.add_route(
AttributeError: 'StaticResource' object has no attribute 'add_route'

Remove your env and build it new. I think you have a wrong depensy install.

I am having the same issue after pulling the docker image.
Steps I did:

Removed current image
docker pull homeassistant/home-assistant
docker run -d --name="home-assistant" -v /haconfig:/config -v /etc/localtime:/etc/localtime:ro -v /etc/ssl:/etc/ssl --net=host homeassistant/home-assistant

I see the following error in the console:
16-12-04 09:13:35 INFO (MainThread) [homeassistant.core] Bus:Handling <Event homeassistant_start[L]>
16-12-04 09:13:35 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "uvloop/future.pyx", line 372, in uvloop.loop.BaseTask._fast_step (uvloop/loop.c:105885)
  File "/usr/src/app/homeassistant/components/http/__init__.py", line 153, in start_server
    yield from server.start()
  File "/usr/src/app/homeassistant/components/http/__init__.py", line 282, in start
    self.cors.add(route)
  File "/usr/local/lib/python3.5/site-packages/aiohttp_cors/cors_config.py", line 407, in add
    routing_entity, config)
  File "/usr/local/lib/python3.5/site-packages/aiohttp_cors/cors_config.py", line 136, in add
    routing_entity, self._preflight_handler)
  File "/usr/local/lib/python3.5/site-packages/aiohttp_cors/urldispatcher_router_adapter.py", line 331, in add_preflight_handler
    preflight_route = route.resource.add_route(
AttributeError: 'StaticResource' object has no attribute 'add_route'

Could you help me debug this issue?

Same issue here.
Have removed venv and renamed deps folder.  Using original config leads to the same issue.
ERROR:homeassistant.core:Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/local/Cellar/python3/3.5.2_3/Frameworks/Python.framework/Versions/3.5/lib/python3.5/asyncio/tasks.py", line 239, in _step
    result = coro.send(None)
  File "/srv/hass/lib/python3.5/site-packages/homeassistant/components/http/__init__.py", line 153, in start_server
    yield from server.start()
  File "/srv/hass/lib/python3.5/site-packages/homeassistant/components/http/__init__.py", line 282, in start
    self.cors.add(route)
  File "/Users/Keymaster/.homeassistant/deps/aiohttp_cors/cors_config.py", line 407, in add
    routing_entity, config)
  File "/Users/Keymaster/.homeassistant/deps/aiohttp_cors/cors_config.py", line 136, in add
    routing_entity, self._preflight_handler)
  File "/Users/Keymaster/.homeassistant/deps/aiohttp_cors/urldispatcher_router_adapter.py", line 331, in add_preflight_handler
    preflight_route = route.resource.add_route(
AttributeError: 'StaticResource' object has no attribute 'add_route'

Same issue after removing deps folder.

try
pip install aiohttp_cors

try
pip install aiohttp_cors

Nope. No joy. Same error.

Same error. aiohttp_cors is installed.

Can confirm the bug. For now work around is to remove the cors config option.


Configure Superset in an AWS EC2 instance using docker

Hello everyone,
I'm asking for your help because I need to configure apache Superset in a production environment (on an AWS EC2 instance) using docker.
I've looked everywhere but can't find anything, so if you have any ideas on how I can do this.
Thanks in advance

Closing this since it's not a bug (and it's also old) but I would encourage you to ask deployment/config questions in #deploying-superset on Superset Slack


Editor getting stuck if I upload 6 Images together. Just drag and drop 6 Images together

Is it possible that one of those images is really huge? Are you able to narrow it down to just one image that's causing a problem while the other 5 are irrelevant?


[Docs] Inconsistent casing between cleanupIds plugin name and cleanupIDs parameter name

Describe the bug
To preserve the original IDs one is supposed to disable the plugin cleanupIds (Pascalcase Id). However, in order to disable this plugin, one has to use the parameter named cleanupIDs (uppercase ID).
To Reproduce
Steps to reproduce the behavior:

Go to the README.md file and look up how to preserve original ids.
Check plugin name - cleanupIds

{
  name: 'preset-default',
  params: {
    overrides: {
      ...
      cleanupIds: false,
      ...
    },
  },
},

Observe rendered SVGs with custom ids.

Expected behavior
The casing between the plugin (cleanupIds) and the parameter (cleanupIDs) is consistent.
Desktop (please complete the following information):

SVGO Version 6.5.1
NodeJs Version 18.12.0
OS: macOS Monterey 12.6

Additional context
This is not really a bug, but more about improving the documentation.

Hi, could you please point exact places where docs using cleanupIDs? I can't find any.

@TrySound I just noticed this also. It's in the list of built-in plugins in the ReadMe.

cleanupIds - all is correct, still don't understand the issue

Btw the plugin was renamed cleanupIDs -> cleanupIds in https://github.com/svg/svgo/releases/tag/v3.0.0
So it's now consistent with prefixIds.

{
  "plugins": [
    {
      "name": "preset-default",
      "params": {
        "overrides": {
          "inlineStyles": false
        }
      }
    },
    {
      "name": "cleanupIDs",
      "active": false
    }
  ]
}

When I tried using cleanupIds as the name under plugins in my config file it did not work. When I changed it to cleanupIDs then it did work. I'm using svgo via parcel, which may still be using an older version and maybe what's causing confusion here.
That's great that there's an update to make these consistent across the board. Thanks!

Yep, sounds like transitive version indeed. You can try o remove svgo from your lockfile and install deps again.

Indeed, pretty sure this was just an issue with having an old version installed.
The term cleanupIDs doesn't even exist in the repo anymore outside our CHANGELOG.
I'm guessing the README was outdated back in November 2021, but today it's fine at least.


Tag a release (candidate)?

I plan to package n2 for Gentoo Linux to  provide support for all build systems that can build Anki.
Is there any plan to tag a release (candidate) any time soon? That would simplify versioning the ebuild.

We're still figuring out some core stuff so I don't think we're ready to support a release.  Feel free to grab a git version if that works for you though.


To be able to include a multiple line Github Commit Message in a payload. Currently gives an error: Need to provide valid JSON Payload

Description
I'm unable to use the Payload if I use a multiple line or otherwise JSON Breaking string. I would like to include a git commit message in an action ( for example ${{ github.event.head_commit.message }} ), but it will break with new lines or formatting in there.
What type of issue is this? (place an x in one of the [ ])

[ ] bug
[x] enhancement (feature request)
[ ] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
package version: 1.21.0
node version: 14
OS version(s): MacOS 12.5
Steps to reproduce:

Create an action that uses a multiple line output, using the readme.md example:
`- name: Post to a Slack channel
id: slack
uses<EMAIL_ADDRESS>with:
Slack channel id, channel name, or user id to post message.
See also: https://api.slack.com/methods/chat.postMessage#channels
channel-id: 'CHANNEL_ID'
For posting a simple plain text message
slack-message: "Git commit example: ${{github.event.head_commit.message }}\n it will be broken after here in the shell output"
env:
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}`

The output in the shell will look off. In the blocks example, I have this:

 {
        "type": "section",
        "fields": [
          {
            "type": "mrkdwn",
            "text": "*Type:*\nAndroid 🤖"
          },
          {
            "type": "mrkdwn",
            "text": "*Build place:*\nBretts-MBP"
          }
        ]
      },
      {
        "type": "section",
        "text": {
          "type": "mrkdwn",
          "text": "*About this build*:\nCommit header

  This is a multiple line
  commit message
  that might have some nice formatting?"
        }
      },

The error will be: Error: Error: Need to provide valid JSON payload

Expected result:
What you expected to happen.
To be able to somehow put a commit message in the payload and show it to the user when posting a slack message.
Actual result:
What actually happened
Error: Error: Need to provide valid JSON payload
Attachments:
Logs, screenshots, screencast, sample project, funny gif, etc.

For what it's worth, I think I found it :)
                    "type": "mrkdwn",                     "text": ${{ toJSON(github.event.head_commit.message) }}                   }
See the toJSON wrapper. because toJSON includes a double quote, you need to not have anything else in the text in that example. This will add \n for new lines, and make it otherwise sanitise for being in a JSON.
Happy days!

Glad to hear that you've figured out your way to deal with the pattern! Just for your reference, here is a similar issue discussed in the past. You can find a a bit different way to make the whole JSON data valid. https://github.com/slackapi/slack-github-action/issues/82
Let me close this issue now 👋


Errors on embedded machine

Hello,
I'm trying to run REMI on the ATSAMA5D27-SOM1 board. REMI and all the OS is built with Buildroot tool.
I try to run python widgets_overview_app.py. Firstly it shows messages that the server is running, but just try to open on browser http://<IP_ADDRESS>:8091 and these errors came up..
What I'm missing? :)
login as: root
# uname -r
4.14.73-linux4sam_6.0
# python -V
Python 2.7.15
# python widgets_overview_app.py
remi.server      INFO     Started websocket server <IP_ADDRESS>:40223
remi.server      INFO     Started httpserver http://<IP_ADDRESS>:8091/
remi.request     INFO     built UI (path=/)
remi.update      ERROR    error updating gui
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/remi/server.py", line 337, in run
    client.idle()
  File "widgets_overview_app.py", line 25, in idle
    self.counter.set_text('Running Time: ' + str(self.count))
AttributeError: 'MyApp' object has no attribute 'counter'
remi.request     ERROR    error processing GET request
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/remi/server.py", line 809, in do_GET
    self.client.root = self.main(*self.server.userdata)
  File "widgets_overview_app.py", line 36, in main
    self.img.onclick.do(self.on_img_clicked)
AttributeError: 'function' object has no attribute 'do'

Hello @dovydasz ,
Could it be possible you are using an older remi version? The "do" instruction is a recent update (1 April 2019). Try to update the remi version to the laster one. There are no reasons that can prevent remi to run on embedded devices.

Buildroot uses this package for remi
https://github.com/buildroot/buildroot/blob/master/package/python-remi/Config.in
Isn't the 'master' newest?

The buildroot master version uses the remi version 1.1.
There were several updates to remi since that version.
Refer to this page for that specific version (examples from this page will work for sure): https://github.com/dddomodossola/remi/tree/v1.1

Yes, you were right. My mistake. Thanks!

@dovydasz you are welcome


Fix issue [gh-8309]

Change authenticationManager to getAuthenticationManager() to prevent inappropriate assertion error. [gh-8309]

Mistake


Invite users to register on platform

Homepage - User provides their email address and click on Join button
An email invitation is sent with token and email address to register.
Users without invitation should not be able to register

We'll return to this when we're ready to get workers to spread the word.


⚠ TiendaEnLinea has degraded performance

In 19f85db, TiendaEnLinea (https://www.fahorro.com/) experienced degraded performance:

HTTP code: 200
Response time: 5604 ms

Resolved: TiendaEnLinea performance has improved in 81f9659.


fix: fix create-vite without packageName

Description
fix create-vite without packageName
Additional context
isValidPackageName judgment

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

The current code is doing what we intended, if the targetDir is a valid packageName, then the next question is ignored because it will be reused. We are only using that prompt if it is invalid.
@Spencer17x would you create an issue to describe what problem did you run into?

@patak-js Now when it is created, although the project name is valid, the name of package.json is still empty. When the type is null, the problem is skipped directly, resulting in packageName being undefined

Good catch @Spencer17x. The condition is still fine, I think we should modify this line https://github.com/vitejs/vite/blob/0316f14eddb6854321ed0c1bbeb29c2668c6f08c/packages/create-vite/index.js#L253 to fallback to targetDir if packageName is undefined.

@patak-js I think so too, but considering that if the user expects the name of package.json to be inconsistent with the directory, this method requires the user to manually modify the name of package.json, so you think the method is better

@patak-js I think so too, but considering that if the user expects the name of package.json to be inconsistent with the directory, this method requires the user to manually modify the name of package.json, so you think the method is better

We discussed this with the team last time, and it was decided that we should enable people to chose a directory name that is not a valid package.json name. We also don't want to ask too many prompts, only the questions that are strictly needed. So the current approach is fine, but you found a bug. You could use this PR if you would like to fix it as we discussed 👍🏼

@patak-js So that's it, I understand, I modified it


Add spreadsheet summary to version bundle software

Produce a spreadsheet  that is a summary of the ontology. It has 3 tabs:

Concept names and annotations, arranged by ontology
Restrictions
Categories

In the comments below, I include sample SPARQL that I used for Platts Enterprise Ontology (PLEO).. It will need tweaking.

#   Find concept names and annotations
--
# Returns every resource of one or more   specified types in the ms risk and
# core namespaces along with their   selected annotations.

# To use this, comment out the line per   your needs.
SELECT DISTINCT ?Ontology ?Resource   ?Parent ?Label ?Type ?Def ?Note ?ScopeNote    ?Comment
WHERE {?Resource rdf:type ?Type .
OPTIONAL {?Resource rdfs:isDefinedBy ?Ontology . }
FILTER(?Type in (owl:Class,   owl:DatatypeProperty,owl:ObjectProperty ))
OPTIONAL {?Resource rdfs:subClassOf   ?Parent.
FILTER   (!(isBlank(?Parent)))
FILTER (?Parent !=   owl:Thing)}
OPTIONAL {?Resource rdfs:subPropertyOf   ?Parent}
OPTIONAL {?Resource skos:definition   ?Def. }
OPTIONAL {?Resource (skos:prefLabel \|   rdfs:label) ?Label. }
OPTIONAL {?Resource rdfs:comment   ?Comment. }
OPTIONAL {?Resource skos:note ?Note. }
OPTIONAL {?Resource skos:scopeNote   ?ScopeNote. }

# FILTER(STRSTARTS(STR(?Resource), # use   this to get URIs ONLY in the pleo namespace
#   "https://ontologies.platts.com/pleo/") )
# FILTER(STRSTARTS(STR(?Resource), # use   this to get URIs ONLY in the pleox namespace
#   "https://taxonomies.platts.com/pleo/") )
FILTER(!(STRSTARTS(STR(?Resource), #   ignore things in owl namespace
http://www.w3.org/2002/07/owl#) ))
FILTER(!(STRSTARTS(STR(?Resource), #   ignore things in gist namespace
http://ontologies.semanticarts.com/gist/)   ))
}

#   Find all restrictions on all (non-deprecated) classes
--
SELECT distinct ?class  ?property ?r_type ?n ?filter
WHERE {?restriction rdf:type   owl:Restriction .
?restriction owl:onProperty ?property .
?class a owl:Class.
FILTER (!isBlank(?class))
FILTER NOT EXISTS{ ?class owl:deprecated "true"^^xsd:boolean   }
{?restriction ?r_type ?filter .
?class rdfs:subClassOf ?restriction.
FILTER (?r_type IN (owl:someValuesFrom , owl:allValuesFrom ,   owl:hasValue )) }
UNION
{?restriction ?r_type ?n.
?class rdfs:subClassOf ?restriction.
FILTER NOT EXISTS{ ?class owl:deprecated "true"^^xsd:boolean   }
FILTER (?r_type IN (owl:minCardinality, owl:minQualifiedCardinality,
owl:maxCardinality, owl:maxQualifiedCardinality,   owl:qualifiedCardinality))
?restriction owl:onClass ?filter.}
UNION
{{?class owl:intersectionOf ?intersection.} UNION
{?class owl:equivalentClass/owl:intersectionOf ?intersection.}
FILTER NOT EXISTS{ ?class owl:deprecated "true"^^xsd:boolean   }
?intersection rdf:rest/rdf:first* ?restriction.
?restriction ?r_type ?filter .
FILTER (?r_type IN (owl:someValuesFrom , owl:allValuesFrom ,   owl:hasValue )) }
UNION
{{?class owl:intersectionOf ?intersection.} UNION
{?class owl:equivalentClass/owl:intersectionOf ?intersection.}
FILTER NOT EXISTS{ ?class owl:deprecated "true"^^xsd:boolean   }
?intersection rdf:rest/rdf:first* ?restriction.
?restriction ?r_type ?n.
FILTER (?r_type IN (owl:minCardinality, owl:minQualifiedCardinality,
owl:maxCardinality, owl:maxQualifiedCardinality,   owl:qualifiedCardinality))
?restriction owl:onClass ?filter. }
}
order by ?class ?r_type ?filter   ?property

#   Find all instances of subclasses of Category
--
select ?Class ?Instance where
{?Instance a ?Class.
?Class rdfs:subClassOf* mscore:Category
FILTER NOT EXISTS{ ?Class owl:deprecated   "true"^^xsd:boolean }
FILTER NOT EXISTS{ ?Instance owl:deprecated   "true"^^xsd:boolean }
}
order by ?Class ?Instance

This can now be accomplished by using the sparql bundle action - see documentation.


Accept GeometryCollection

Changed the filter to avoid errors with missing coordinates of GeometryCollection.
Added a rule to push the coordinates of GeometryCollection like it was done for type='MultiPolygon' and 'Polygon'

This is a fix for issue #9350
https://github.com/apache/incubator-echarts/issues/9350

I use this pr in production, it's working. Please solve this issue.

why is this logic missing in v5.3.3, there still have problem with issue #9350.

Any updates?


Implement stopping strategy for Publisher SDK

The new stopping strategy makes the stop() method work in an asynchronous way. Now it accepts a callback that returns either a success or failure. Whatever the result is,after calling stop() no further action should be called on the Publisher. Additionally, we're handling multiple calls to stop(), each of the callers will receive an appropriate callback.
In order to stop the publisher we're performing 3 major actions:

leaving all trackable channels (asynchronous, but we're blocking queue until it's done)
stopping Mapbox (synchronous)
stopping Ably (asynchronous)

Calling stop() sets a flag isStopping which signalizes that the stopping process is ongoing and no events that aren't connected to the stopping procedure should be processed. In order to not lose track of those events we're logging each of the ignored event.
When stopping is finished then the isStopped flag is set.
Those flags help us react to stop() calls when the stopping procedure is ongoing or finished.
I've spotted a problem (which is fixed in this PR) with Mapbox not stopping the location updates after stopping our SDK. There was always a notification on the device that was saying that the trip is ongoing.  Currently, the whole Mapbox is being cleaned and this fixes that issue.
FYI: I've started this branch on top of the new interface PR in order to be able to use that interface. The new interface is almost done and needs just some minor adjustments that shouldn't affect that PR.

I'm closing this PR since it's obsolete and irrelevant after landing of https://github.com/ably/ably-asset-tracking-android/pull/203


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-24-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2279

Questions ?
Please refer to the Backport tool documentation


[Release 1.3.5] Added common-utils and job-scheduler to the manifest.

Description
[Release 1.3.5] Added common-utils and job-scheduler to the manifest.
Issues Resolved
Part of: https://github.com/opensearch-project/opensearch-build/issues/2348
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2461 (fa9f8d6) into main (a9eff05) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2461   +/-   ##
=========================================
  Coverage     94.63%   94.63%
  Complexity       27       27
=========================================
  Files           211      211
  Lines          4322     4322
  Branches         29       29
=========================================
  Hits           4090     4090
  Misses          226      226
  Partials          6        6

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Waiting on for common-utils and job-scheduler version increment PR's to be merged.
Thank you


Firehose v22 moved ete to a different position

Small fix to modify the expected output for connector test to match new firehose field ordering

BCK-5391

For posterity: this is actually BCK-5392


Fix documentation so that it would proper render

What type of PR is this?
/kind documentation
[skip ci]
What does does this PR do / why we need it:
We need it so that bullet points and sections of document would properly render.
Which issue(s) this PR fixes:
NA
How to test changes / Special notes to the reviewer:
Compare the rendered document against current master and proposed PR. This can be done by clicking "Display the rich diff" when reviewing the PR.

flake tracked on issue : https://github.com/openshift/odo/issues/2878
/retest

/approve


Rendering half stars

Hello!
Thanks for sharing this, it comes in handy. I have a problem though: we would also like to render half star ratings and I don't know how to get it to work. The renderStarIconHalf prop doesn't seem to do anything for me. Here's what I have (taken from the examples):
<StarRatingComponent
    name="rating"
    editing={false}
    starCount={5}
    value={stars}
    renderStarIcon={(index, value) => {
              return <span className={index <= value ? 'fa fa-star' : 'fa fa-star-o'} />;
            }}
    renderStarIconHalf={() => }
/>

Any ideas?

See the example, it sets the state to rating_half_star: 3.5.
The StarRatingComponent value is then set to rating_half_star.
Does this solve your issue?

Thank you, but that was not my issue. In the example rating_half_star is just passed as the value props to the StarRatingComponent, and my stars value is a float as well.
However, I found my problem: I was using version 1.0.0. It is working with 1.2.2. My bad.


Cosmos DB | Update for Az.CosmosDB 0.1.4 | SQL

Description
Update samples to reflect changes in Az.CosmosDB 0.1.4 release. This PR is for SQL-specific samples.
Checklist

[X] This pull request was tested on both of:

[X] PowerShell 5.1 (Windows)
[ ] PowerShell 6.x
[X] PowerShell 7.x (Latest PowerShell)

[X] Scripts do not contain static passwords or other secret tokens.
[X] All Azure resource identifiers which must be universally unique are guaranteed to be so.

Testing information
Windows 10.0.18363, Powershell 5.1, Az 3.8.0
Windows 10.0.18363, Powershell 7.0.0, Az 3.8.0

#sign-off


Computed properties template string

Resolves #15

Codecov Report

Merging #16 (0dc0586) into master (86b5d79) will decrease coverage by 0.21%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   60.97%   60.76%   -0.22%
==========================================
  Files           1        1
  Lines         205      209       +4
  Branches       59       61       +2
==========================================
+ Hits          125      127       +2
  Misses         21       21
- Partials       59       61       +2

Impacted Files
Coverage Δ

src/classnames.macro.js
60.76% <50.00%> (-0.22%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b5d79...0dc0586. Read the comment docs.

Thanks. 💖


moved directory up a level

Thanks for this movement. But since we have made a lot changes in the QRConnect directory, we might experience a lot merge conflicts later, my suggestion is just emoving the ourside .gitignore file and add google-services.json in the QRConnect to solve google-services.json sycn up issue which is more strightforaward.


All cluster together

I was finding it difficult to track the patient location and travel history. So added an other tab to track all the details in one cluster.

Thanks, though this looks quite chaotic. Two suggestions:

Merge latest changes from master that links stateless patients in city filter
Increase edge size/change edge style so that it looks less chaotic

Thanks, though this looks quite chaotic. Three suggestions:

Merge latest changes from master that links stateless patients in city filter
Increase edge size/change edge style so that it looks less chaotic
Making it generic enough so that new filters in the future can be included in the all filter
Add legends of all filters
done

hold it for sometime. I guess instead of showing every patient, let me restrict this to only the selected pID. I think will name it search. So only one patient and it's connected network.


Strange Matches error (InnerTemplateStartLine and InnerTemplateStartLine) when linting a specific arm.

I'm running the ARM-TTK linter for a azuredeploy.json listed below and getting this strange error
json-file:
{
    "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
    "contentVersion": "<IP_ADDRESS>",
    "parameters": {
      "privateDnsZones": {
        "type": "Array"
      },
      "virtualNetwork": {
        "type": "String"
      },
      "registrationEnabled": {
          "type": "Bool",
          "defaultValue": false
      },
      "location": {
          "type": "String",
          "defaultValue": "global"
      }
    },
    "resources": [
      {
        "copy": {
          "name": "privateDnsZones",
          "count": "[length(parameters('privateDnsZones'))]"
        },
        "type": "Microsoft.Network/privateDnsZones",
        "apiVersion": "2020-06-01",
        "location": "[parameters('location')]",
        "name": "[parameters('privateDnsZones')[copyIndex()]]",
        "properties": {
        },
        "resources": [
          {
            "dependsOn": [
              "[resourceId('Microsoft.Network/privateDnsZones', parameters('privateDnsZones')[copyIndex()])]"
            ],
            "type": "SOA",
            "apiVersion": "2020-06-01",
            "name": "@",
            "properties": {
              "ttl": 3600,
              "soaRecord": {
                "email": "azureprivatedns-host.microsoft.com",
                "expireTime": 2419200,
                "host": "azureprivatedns.net",
                "refreshTime": 3600,
                "retryTime": 300,
                "serialNumber": 1,
                "minimumTtl": 300
              }
            }
          },
          {
            "dependsOn": [
              "[resourceId('Microsoft.Network/privateDnsZones', parameters('privateDnsZones')[copyIndex()])]"
            ],
            "type": "virtualNetworkLinks",
            "apiVersion": "2020-06-01",
            "location": "[parameters('location')]",
            "name": "dnsforwarder",
            "properties": {
              "registrationEnabled": "[parameters('registrationEnabled')]",
              "virtualNetwork": {
                "id": "[parameters('virtualNetwork')]"
              }
            }
          }
        ]
      }
    ]
  }

Result form the ARM-TTK linter:
2021-12-06 10:32:18 [INFO]   File:[/tmp/lint/Policies/PrivateDNSZone/templates/azuredeploy.json]
MethodInvocationException: /usr/lib/microsoft/arm-ttk-master/arm-ttk/Test-AzTemplate.ps1:332
Line |
 332 |                              $InnerTemplateStartLine =
     |                              ~~~~~~~~~~~~~~~~~~~~~~~~~
     | Exception calling "Matches" with "2" argument(s): "Start index
     | cannot be less than 0 or greater than input length. (Parameter
     | 'startat')"

MethodInvocationException: /usr/lib/microsoft/arm-ttk-master/arm-ttk/Test-AzTemplate.ps1:336
Line |
 336 |                              $InnerTemplateEndLine =
     |                              ~~~~~~~~~~~~~~~~~~~~~~~
     | Exception calling "Matches" with "2" argument(s): "Start index
     | cannot be less than 0 or greater than input length. (Parameter
     | 'startat')"

2021-12-06 10:32:31 [ERROR]   Found errors in [arm-ttk] linter!
2021-12-06 10:32:31 [ERROR]   Error code: 1.  I am facing the same error after upgrading to the latest ARM-TTK files.

Yes I am still having this issue, for now I excluded the linter for that specific file.

@spoelly @MattLeach25 - which version are you using? I tried to repo with the template in the op and do not see the error.

@bmoore-msft i've tested the latest release downloaded form here :
Still got the error, ARM-TTK does not see it as a error but GitHub Superlinter does. But never the less this kind of errors should not popup in a linter scan.

   Are you seeing the same error on the template in the OP?

This is the same template mentioned on top of this issue.

Ok, so must be related to superlinter - I thought we had a workaround for that... will take another look
@StartAutomating

Any news on this issue?


GCP-BillingAccountID

Added https://github.com/finopsfoundation/focus_converters/blob/dev/focus_converter_base/focus_converter/conversion_configs/aws/billing_account_id_S001.yaml.

Added in https://github.com/finopsfoundation/focus_converters/commit/0e8450d6dd0bc025768fd9b1460b05cbee63691f.


Add starship integration running vanila stride and simple e2e tests

Closes: #5

awesome! @srph this will add end to end testing and simulate the chain so we can test messages on the real chain in a local dev environment
@Anmol1696 is there anything we need to do in order to enable CI here?

@pyramation once this is merged, CI will be enabled automatically. I have added the github workflow that will run in the gh-action runner itself.

@srph you want to take a look? this will allow you to write tests with the StrideJS client with the latest Stride binaries, in a local environment w/o having to worry about internet or connectivity, UI, etc.
here is an example of a governance test to give you an idea

👋🏼 Hey folks, thanks for working on this. I just came back from vacation. I'll try to look into it this week - seems like there's some fire to put out as Keplr transactions stopped working at Stride due to recent upgrades.

Sounds good. No hurries here, firefighting first.
Let us know we can help.

Thanks @Anmol1696! Sorry for the late response - it's been one thing after another, but I have some time this week. I'll definitely look into this.

Hey @Anmol1696 & @pyramation , I really appreciate all your work here. Apologies for the last response!
I'm curious, do you guys have an example where Starship is used extensively for a telescope-generated library? Stride has some e2e tests which covers things from the Frontend-side, so I'm not sure if we'll get value out of this at the moment. However, I am willing to know more how Starship can become valuable for Stride in the near future.

@srph sorry for late reply. But we have been expanding useage and capabilties of Starship. It is extensively used in Osmojs https://github.com/osmosis-labs/osmojs/tree/main/packages/osmojs/starship, and Telescope itself as well.
We are also expanding it to Cosmjs as well for testing it. We have found a whole set of bugs from testing Osmojs, some of which we have raised even to Cosmos-sdk.
The idea here for StrideJS is to make sure any version of Stridejs or any other libraries used for frontend testing can use Starship to spin up the underlying infra, and then have e2e tests against this a setup with multiple chains. We will also have a frontend testing support being built for MeshSecurity that might be something that could also be used for testing all sort of frontend features as well.
If you already have a more comprehensive testing environment and test cases which you are satisfied by, then we can close the PR as well. If you have any features or requests for us, please let us know as well.

@srph it's good to use for testing flows, e.g.:

do an IBC TX to send tokens from CosmosHub to Stride
create the ATOM stride token (minting?)
then stake the token, for example

then developers wanting to use Stride can look at the tests, and know how to properly do it, and you can know that your proto and amino encoders are working properly, with an integration test


Won't install together with Office 365 ProPlus

Downloaded ProjectPro2019Volume as part of the benefits from the MS Partner program. Installer stops with the message 'We can't install: To install this product, first uninstall the following product(s) and try again".
I already have the Office Suite installed as part of Office 365 ProPlus and also Visio 2016 for Office 365. As per this guide: https://docs.microsoft.com/en-us/DeployOffice/install-different-office-visio-and-project-versions-on-the-same-computer?toc=/deployoffice/office2019/toc.json#example-installation-scenarios I should be able to install Project Professional 2019 (see second to last example installation scenario in the list) because my existing Office installation is at version 1811 where at least 1808 is required.
Please assist.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 626ac155-c2df-20a5-a23f-14921c0c72ae
Version Independent ID: 63a9307c-d246-bd15-9a2b-178b8a49580b
Content: Deploy Office 2019 (for IT Pros)
Content Source: DeployOffice/office2019/deploy.md
Product: office-perpetual-itpro
GitHub Login: @DHB-MSFT
Microsoft Alias: danbrown

I encounter a similar problem: I have some Office (2016) ProPlus programs installed, without Visio/Project - I was trying to combine these with Visio/Project Professional 2019, but I also get the uninstall message, although there are only click-to-run Office versionz on my machin, no MSI...
Any useful info regarding this is welcome.

Just encountered this.
I have the following currently installed:

Office 365 Pro Plus
Project for O365 1903

Trying to install the following ODT:

VisioPro2019Volume

Received error:

UPDATE! Looks like I've resolved my issue. The key config in the xml was to match whatever my ProPlus update channel is. As I am in the the Targeted channel, i updated the xml from "Monthly" to "Targeted" and boom - VisioVolume installed! :)
<Configuration>
  <Add	OfficeClientEdition="64"
	Channel="Targeted" >
    <Product	ID="VisioPro2019Volume".......

@githubsteveb -- Yep, that's correct. Sorry I didn't reply sooner with that info. We do mention that info in the 4th paragraph here -- Update channel for Office 2019, but admittedly that's probably hard to find. We'll see if we can put that info in a more prominent place. Thanks.

@githubsteveb -- Yep, that's correct. Sorry I didn't reply sooner with that info. We do mention that info in the 4th paragraph here -- Update channel for Office 2019, but admittedly that's probably hard to find. We'll see if we can put that info in a more prominent place. Thanks.

Thanks! I think it was the original error message that threw me - about uninstallng pro plus etc! Perhaps a slight update to that would be beneficial/or a error detection catch. Cheers.

I've got a similar error, and the issue doesn't seem to be an incorrect update channel. I've currently got Office Professional Plus 2019 installed, but it is not the volume licensed version, it is the version that comes from Microsoft's HUP. When I try to install VisioPro2019Volume, with the update channel set to PerpetualVL2019, I get an error similar to the one shown above: "To install this product, first uninstall the following product(s) and try again. Microsoft Office Professional Plus 2019 - en-us". I don't see anything in the docs that shed light on this issue. Thanks.

Closing due to the age of the issue report. Feel free to re-open or open new issue if problem persists.


Update Get Resources web-view UI to Phase 1 UX design

Design spec found here

This change is

please still fix the issue of the wrong filed used for filtering the type popover


spec: don't push tests into Fedora

koji-osbuild-tests is dependent on osbuild-composer-tests but this package
is not shipped into Fedora because it provides zero value to users.
Let's do the same for koji-osbuild. koji-osbuild-tests will be built only
in our upstream CI but not built in the official Koji.

I added a small clean-up on top. My past mistake basically ;)

Fixed, I guess Github cannot rebase?


glali

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.1
logical conflict every: 100
sleep for: 300s
close stale after: 4 hours
[pullrequest]
requests per hour: 50
deps=[g]

/trunk merge


Some upgrades!

PHP 7.0 has already reached EOL. 7.1's security fixes are until Dec 2019 only. While 7.4 is around the corner, I think the min. we should consider now is 7.2 which is good enough for quite some time and in sync with Laravel as well.
I would also suggest we consider dropping Laravel 5.5 entirely and have new packages be Laravel 6 supported only. Thoughts?

PHP 7.0 has already reached EOL. 7.1's security fixes are until Dec 2019 only. While 7.4 is around the corner, I think the min. we should consider now is 7.2 which is good enough for quite some time and in sync with Laravel as well.

Agreed.

I would also suggest we consider dropping Laravel 5.5 entirely and have new packages be Laravel 6 supported only. Thoughts?

I would disagree here. There's plenty of applications on 5.x still (5.5 & 5.8 are still in support).
In most of the channels the changes to support both 5.5 and 6.x were minimal (usually just arr_ and str_ helpers). I don't think there's that much more overhead to support the older versions, and I don't see any advantages to locking it to 6.x (which is a pretty big upgrade from 5.8 even, esp for large apps).

Alright, that makes sense!


Add prd (python generated directory) to PYTHONPATH

  "containerEnv": {
    "PYTHONPATH": "/workspaces/STIR2PETSIRD/PETSIRD/python"
  }

The aboce. should be added to the .devcontainer/devcontainer.json file.
Example implementation and use case.
https://github.com/ETSIhackers/STIR2PETSIRD/blob/52d21ad78533a2905766f16219ab4ad3caac2da4/.devcontainer/devcontainer.json#L126-L128

Problem is it needs the project-name. I think one of the .bashrc methods could be easier to, although even there people will have to rename presumably. (don't want to do an ugly find ~ -d -name PETSIRD).
I've created https://github.com/microsoft/yardl/issues/108 which is probably the way forward.


Support numeric/binary hash comparison for floats derived from Variants (as well as existing semantic comparison)

~Hash scalar compare for Variants which are floats no longer considers two NaN values as equal.~
Hash comparison for Variant continues to perform semantic/logical comparison with NaN's considered equal by default (to prevent #16114, #7354, #6947, #8081, #16031), but now optionally allows for numeric comparison that does not consider NaN's equal to support proper value comparison (for #72222)

Added a semantic_comparison argument to existing hash_compare implementation(s) that is set to true by default.
Added a hash_comparison_base macro to support existing hash_compare values with default semantic comparison.
Dictionary value and arrays use non-semantic/numeric/binary comparisons for floats.

Closes #72222

CC @hpvb who introduced this code back in 2017 with #7815 (+ #8393).
The behavior for Dictionary with NAN keys was then later changed with #16114 to fix #16031. Would this PR reintroduce that bug?

Because of macros I would keep the parentheses around the values, just to be safe

Maybe we should add a hash compare that treats NaN as equal and use it for dictionary, where we technically care about binary equality

I believe this will reintroduce the bug as it is.

Looks like this was quite a controversial series of bugs and decisions 🙂
It does look like to support both the best way I can think of is two functions. I pushed a change that addresses this with I think the least code duplication as possible and doesn't break compatibility.
I tested with the original target issue (#72222) and previous issues (#16114, #7354, #6947, #8081) and all cases seem covered.

PS: In the future, when posting a screenshot of code, please include it in Markdown as well between triple backticks so that other people can test it easily. (This is also more accessible to screen readers.)

I'm not sure if the memory error is a problem with the workflow. Especially because all I changed was the order of the if conditions and it seems to be connected to Vulkan, plus I'm not able to reproduce it.

That's a race condition unrelated to this PR, it happens every now and then. I restarted the build.

I see. Thanks!

Thanks!


Exporting doesn't finish and loads forever

I tried exporting a model with 60k faces, around 60 morph targets and something like 20 materials.
I left my pc there for an hour but the export never finished. It stopped on the folder view like it usually does when exporting is taking a long time.
This was with the default settings.
Is it supposed to take this long or is there something wrong?
I'm running Blender 2.78, don't know if that matters.

Deleting all the morph targets reduces the wait to literally zero so it's definitely that, however I do need morph targets,

Providing this Blender model would help to investigate this.

Here's the model sorry for the late response.
It's originally an MMD model and was the only complex free model with morph targets and rigging I could find online.
http://creativiii.com//threejs/testing-model.blend

Code has been substantially refactored in glTF-Blender-IO, and it appears there have been some performance improvements. I think we can consider this closed, and open new issues if problems are found.


Add get endpoint for a list of attachment metadata #25

Description
Has optional query parameter entity_id that filters results
TO DO: add tests
Testing instructions
Add a set up instructions describing how the reviewer should test the code

[ ] Review code
[ ] Check Actions build
[ ] Review changes to test coverage
[ ] {more steps here}

Agile board tracking
Resolves #25

Codecov Report
Attention: Patch coverage is 15.78947% with 16 lines in your changes missing coverage. Please review.

Project coverage is 94.04%. Comparing base (005e416) to head (6dea9d8).
Report is 6 commits behind head on develop.

Files with missing lines
Patch %
Lines

object_storage_api/repositories/attachment.py
9.09%
10 Missing :warning:

object_storage_api/services/attachment.py
25.00%
6 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #73      +/-   ##
===========================================
- Coverage    98.09%   94.04%   -4.06%
===========================================
  Files           21       21
  Lines          368      386      +18
===========================================
+ Hits           361      363       +2
- Misses           7       23      +16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

As referenced in my last commit, the get request would fail because AttachmentPostResponseSchema was missing the upload_info argument. Did I fix this the correct way?

tests to be added

As referenced in my last commit, the get request would fail because AttachmentPostResponseSchema was missing the upload_info argument. Did I fix this the correct way?

It needs a new schema for the get request as the one you mentioned is for the post response which includes a url to upload the attachment to. Similar to https://github.com/ral-facilities/object-storage-api/pull/69 I would recommend calling it AttachmentMetadataSchema and inherit from AttachmentPostSchema, add the id and then inherit AttachmentMetadataSchema in AttachmentPostResponseSchema to add the upload_info.

like this @joelvdavies?

Yes exactly.

What to do about the failing Linting check?

What to do about the failing Linting check?

I would put
# Expect some duplicate code inside tests as the tests for the different entities can be very similar
# pylint: disable=duplicate-code

at the top of the image and attachment repo unit test files under the first comment like we have done in test_catalogue_category.py on ims-api.

Currently an invalid entity_id returns a 422 status_code and an error message saying it received an Invalid ID. In other endpoints we have moved to returning a 404 and an error message saying BLANK was not found when an ID is invalid. I believe it's for security reasons, and not letting outsiders figure out our ID formatting?
Also, for more recent endpoints like the get singular for images , we've moved the error handling to the repo layer, so I think you should implement it there, unless @joelvdavies has other ideas?

Currently an invalid entity_id returns a 422 status_code and an error message saying it received an Invalid ID. In other endpoints we have moved to returning a 404 and an error message saying BLANK was not found when an ID is invalid. I believe it's for security reasons, and not letting outsiders figure out our ID formatting?

Yes in this case if you get a route with a non existent ID it makes sense for it be a 404 anyway as the code signifies that the route and entity wasn't found, normally a 422 would be used if something in the request body schema itself is invalid. Like Anikesh said I believe it was also because you could figure out which ids were valid and invalid by looking at the error messages.

Sorry, I have thought about it a bit more and realised I made a mistake here 🤦♂ . Given these are query parameters and not path parameters it does make sense to be that they are 422s and not 404s. So the current behaviour is fine, the only thing we could do in reference to this is return an empty [] list like ims-api does in such cases. I would just create another issue to potentially do that afterwards, no need to do it here.

Also, for more recent endpoints like the get singular for images , we've moved the error handling to the repo layer, so I think you should implement it there, unless @joelvdavies has other ideas?

Hi @joelvdavies and @asuresh-code, I've implemented what I think you mean with this and error status codes, but i'm not sure! If what I've done is correct, it needs doing for images too, as there is no error handling in the repositories layer for list images.

Also, for more recent endpoints like the get singular for images , we've moved the error handling to the repo layer, so I think you should implement it there, unless @joelvdavies has other ideas?

Hi @joelvdavies and @asuresh-code, I've implemented what I think you mean with this and the error status codes, but i'm not sure! If what I've done is correct, it needs doing for images too, as there is no error handling in the repositories layer for list images.

Sorry as I mentioned above I think what you had before for the error was fine, so I would just go back to that for now, then we can have another separate issue to change it to be like ims-api, the only difference there that there we return [], while the list response for images and here returned a 422 saying its an invalid id. So I would just revert the last commit above.


update-ca-certificates doesn't concatenate properly certificates if trailing newline is missing

Description
update-ca-certificates blindly concats certificates without concern for a newline at the end of the file.  This is concerning in environments where certificates are provided by enterprise teams that may not always have a newline.  This issue was fixed in Debian 13 years ago and in Alpine 6 years ago.
Impact
ca-certificates bundle will be invalid, which breaks a number of services.
Environment and steps to reproduce

Set-up: create a valid pem file in /etc/ssl/certs with no newline at EOF
Task: execute update-ca-certificates, then attempt a curl
Action(s):
a. write an valid x.509 PEM file into /etc/ssl/certs with no new line before EOF
b. Execute sudo /usr/sbin/update-ca-certificates
c. curl https://flatcar.org
Error: curl: (77) error setting certificate file: /etc/ssl/certs/ca-certificates.crt

Expected behavior
We would expect curl to complete and show a 301 Moved Permanently.
Additional information
Bugs in Debian & Alpine:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=635570
https://gitlab.alpinelinux.org/alpine/aports/-/issues/8379

Flatcar's implementation of update-ca-certificates.
It should be changed to a for loop with sed (https://github.com/ClusterHQ/gentoo/blob/master/usr/sbin/update-ca-certificates#L80C3-L80C15) or cat+echo.


unguarded headers

There are still some unguarded headers, like aedis/impl/error.ipp and few others.

error.ipp is an implementation file and not a header. You are probably misusing #include <aedis/src.hpp>, it should be include in a single .cpp in your application. The easiest way to do this is to include it in the file where you define the main function. Alternatively, you can also create a file called aedis.cpp with the content
#include <aedis/src.hpp>

and add it to your build system.

yey, thats is inproper misusing of impl files


AccessViolationException from SQLitePCL.NativeLibrary.TryLoad on 2.0.2+

We're seeing an AccessViolationException (via telemetry, no local repro so far) at this callstack across many of our apps:
SQLitePCLRaw.nativelibrary!SQLitePCL.NativeLibrary
SQLitePCLRaw.nativelibrary!SQLitePCL.NativeLibrary.TryLoad
SQLitePCLRaw.nativelibrary!SQLitePCL.NativeLibrary.Search
SQLitePCLRaw.nativelibrary!SQLitePCL.NativeLibrary.MyLoad
SQLitePCLRaw.nativelibrary!SQLitePCL.NativeLibrary.Load
SQLitePCLRaw.batteries.v2!SQLitePCL.Batteries_V2.MakeDynamic
SQLitePCLRaw.batteries.v2!SQLitePCL.Batteries_V2.DoDynamic_cdecl
SQLitePCLRaw.batteries.v2!SQLitePCL.Batteries_V2.Init
It's happening in sqlitepclraw.nativelibrary.dll versions <IP_ADDRESS>9, <IP_ADDRESS>6, and <IP_ADDRESS>5.

That is unfamiliar, and there's not much here to go on.  Do you have any additional information?  Platforms?  Versions?  Environment?

It has only happened on Windows 10 (various sub-versions).  Every single hit (16,522 in total) is from an x64 machine, which may be a clue.


Command for fetching Hacker News threads for a specific domain

I want to be able to fetch every item for a domain, e.g. https://news.ycombinator.com/from?site=simonwillison.net

That page doesn't have an API but does look easy to scrape.
The other option here is the HN Search API powered by Algolia, documented at https://hn.algolia.com/api

https://hn.algolia.com/api/v1/search_by_date?query=simonwillison.net&restrictSearchableAttributes=url looks like it does what I want.
https://hn.algolia.com/api/v1/search_by_date?query=simonwillison.net&restrictSearchableAttributes=url&hitsPerPage=1000 - returns 1000 at once.
Otherwise you have to paginate using &page=2 etc - up to nbPages pages.
https://www.algolia.com/doc/api-reference/api-parameters/hitsPerPage/ says 1000 is the maximum.

Prototype:
curl "https://hn.algolia.com/api/v1/search_by_date?query=simonwillison.net&restrictSearchableAttributes=url&hitsPerPage=1000" | \
  jq .hits | sqlite-utils insert hn.db items - --pk objectID --alter

I'm going to build a general-purpose hacker-new-to-sqlite search ... command, where one of the options is to search within the URL.


Remove bluebird

Hi! Thanks a lot for the package!
Any chance to avoid to use bluebird? You use it as the native Promise. -1 dependency.

Happy to accept a pull request!
On Tue, Sep 3, 2019 at 7:12 AM Andrew Zaikin<EMAIL_ADDRESS>wrote:

Hi! Thanks a lot for the package!
Any chance to avoid to use bluebird? You use it as the native Promise. -1
dependency.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sibnerian/electron-promise-ipc/issues/12?email_source=notifications&email_token=AAW3BRF7CSZB67NP545NDHDQHZBATA5CNFSM4ITFAJH2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HI6R4JQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAW3BREB4JRQY437M2MKHPDQHZBATANCNFSM4ITFAJHQ
.

Fixed in #13


Documentation Issues

Generally, the documentation of this great community lacking behind a bit and I feel the solution here is ;
Solutions

There should be an announcement on this from the team
The community should be more active than before
More people should be involved, if possible admitting more members
The team should collaborate with people to give them the right information on things pertaining to the community

and many more!

Thank you for your suggestions. You're right, and we will work on bringing our documentation up to speed with the help of our community and contributors.


.toLocaleString breaks Season with Years

Shows like Running Man have the Year as the Season, which gets displayed as S2,018 instead of S2018 because of the string locale

@Menturan Oh it does work. Thanks


dmp-506 : Hearing Media Association Table

Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[x] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DMP-506
Change description
New Association table between Hearing & Media
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

This table looks very different to what's in Barry's latest script, maybe we can chat about it @hemantasharma1129 ?

This table looks very different to what's in Barry's latest script, maybe we can chat about it @hemantasharma1129?

Which table @davet1985 ?


404 during installation

Summary
Not sure if this is intended but I get this error on 'npm install'.

node-pre-gyp ERR! Tried to download(404): https://github.com/wadey/node-microtime/releases/download/v2.1.5/node-v57-linux-x64.tar.gz

node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v57 ABI) (falling back to source compile with node-gyp)

Had to install build-essential on Ubuntu to get going with the compilation.
Steps to Reproduce

Follow the installation guide.
Run 'npm install'

Additional info

Postleaf version: 1.0.0-beta.1
Node version: 8.9.4
Affected browsers:
Operating system: Ubuntu 16.04

I had the same problem, but it disappeared after downgrading to Node v7.


pkgsMusl.stdenv: fix build on aarch64

Description of changes
As identified in https://github.com/NixOS/nixpkgs/pull/168207, the musl stdenv has been broken on aarch64 for a very long time (more than three years!).  The main problem is that the bootstrap tarball is severely outdated.  But in order to have Hydra generate a new one, we need to give it something it can build with the old one as a starting point.
To do that, downgrade patchelf to a version that can be compiled with the current aarch64+musl bootstrap C++ compiler, and disable the tests for coreutils since they run into a problem with the bootstrap tarball's diff program.
Once Hydra has generated an up to date bootstrap tarball, we can update the aarch64+musl stdenv to use that, and then revert these hacks.
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

(Another part of this will be getting Hydra to actually build bootstrap tarballs for Musl, but that's for another PR.)

Woohoo, time to fix it :)


Add important callout in README for colima users

Description

Update the "Adding a new SDK" section README to include a critical note for developers using Colima to run docker.
References

Review Checklist

[x] I have clicked on "allow edits by maintainers".
[x] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[x] I have added tests to validate that the change in functionality is working as expected

@drewble - may I ask if you can sign the Linux Foundation's/CNCF's EasyCLA above? https://github.com/openfga/sdk-generator/pull/458#issuecomment-2521203046


ECDSA exportKey method implementation

Implementation of ECDSA exportKey method as per W3C specification at https://www.w3.org/TR/WebCryptoAPI/#ecdsa-operations

Merged with #2


Update GPG keyring

To fix the missing key failures on CI.

@bot-gradle test and merge

Your PR is queued because #17240 is being built.

OK, I've already triggered a build for you.

Pre-tested commit build failed.

I have tested on several broken servers, seems to be fixed.


Separate miniservice to templates

3 type of templates that we need to support:

No storage
EntityFramework (SQL Serv, MySQL, and SQLite)
NoSQL (MongoDb)

We need one more refactor for AppBuilderExtensions in each templates

TODO: Remove NetCoreKit.Infrastructure.AspNetCore.Miniservice physically.


Add Azure Key Vault config provider

This PR adds Azure Key Vault as config provider to spin as suggest in #1737
Authentication
Authentication is implemented using ClientCredentialFlow leveraging clientId and clientSecret  of an Azure Service Principal (SP).
The SP must have the Key Vault Secrets User role assigned on the scope of the desired Azure Key Vault instance. Additionally, RBAC must be enabled on the Azure Key Vault instance.
Loading Secret Values
Although Azure Key Vault supports multiple versions per secret, this implementation loads the latest version of a particular secret.
Runtime Configuration File
Once necessary SP and Azure Key Vault have been provisioned and Role Assignment is in place, users must provide a corresponding runtime config file:
[[config_provider]]
type = "azure_key_vault"
url = "https://mysecrets.vault.azure.net/"
client_id = "00000000-0000-0000-0000-000000000000"
client_secret = "SomeSauce"
tenant_id = "00000000-0000-0000-0000-000000000000"

@melissaklein24 I'll close this one and will come up with a new PR


iphone mobile    edge very vague

Maybe my suggestion could help

I know it's not the perfect solution, but it works.
I will keep your request in mind for future to implement automatic pixel-ratio detection (maybe using this)
But I'm resolving the issue for now.


Fix HEVCd EntryPoint/disp_win_offset/PredWeightTable parsing issues

Fix HEVCd EntryPoint/disp_win_offset/PredWeightTable parsing issues.

These 3 changes have been merged into close source repo, this is just for open-source porting to make close-source and open-source code align.


Update Link and Document sources to prevent confusing editing of entities without text selected

See https://github.com/springload/draftail/issues/85. Until there is a new API there, those two sources need to either:

Bail out of the entity adding workflow if the selection is collapsed.
Insert the text the entity is to be applied upon, and the entity.

I like option 2 better because it's closer to the behavior of other editors, and the text can always be edited / reverted afterwards. For links, we could go with the the page title for pages, and full URL (external or email links). For documents, the document title seems like a good link text.

Assigning to @vincentaudebert like https://github.com/springload/draftail/issues/85.


Support snapshot uploading to s3 for every build

Description
The current jenkins workflow only updates the release candidates after merging #1378
This PR supports uploading snapshots to below location for every build too:
snapshots/core/opensearch/1.2.3-SNAPSHOT/opensearch-min-1.2.3-SNAPSHOT-linux-x64-latest.tar.gz
snapshots/core/opensearch/1.2.3-SNAPSHOT/opensearch-min-1.2.3-SNAPSHOT-linux-arm64-latest.tar.gz

Issues Resolved
#1442
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1472 (e658c64) into main (fa1f6f2) will decrease coverage by 7.86%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1472      +/-   ##
============================================
- Coverage     94.45%   86.58%   -7.87%
  Complexity       12       12
============================================
  Files           141       22     -119
  Lines          3084       82    -3002
  Branches          8        8
============================================
- Hits           2913       71    -2842
+ Misses          164        4     -160
  Partials          7        7

Impacted Files
Coverage Δ

tests/jenkins/jobs/uploadSnapshotsToS3_Jenkinsfile
100.00% <100.00%> (ø)

src/system/console.py

src/system/os.py

src/assemble_workflow/bundle_locations.py

src/manifests/input_manifests.py

src/run_checkout.py

src/assemble_workflow/bundle_file_location.py

...est_workflow/test_result/test_component_results.py

src/sign_workflow/signer.py

src/ci_workflow/ci_check_manifest_component.py

... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa1f6f2...e658c64. Read the comment docs.

Can we add a test for jenkins/opensearch/distribution-build.jenkinsfile

Can we add a test for jenkins/opensearch/distribution-build.jenkinsfile
Thanks!

Out of the scope of this issue. We can create new issue and follow up on that.


Add FlatVoxelViewer for DREAM

Simple voxel diagnostics tool that can show all voxels and does not require summing or slicing.

Does the flattening scheme only apply to dream, or could we make this a generic tool for other instruments like the MaskingTool in scippneutron?

The code may need to be updated when #92 is merged. So I propose to wait for that PR.


Add PromptEngine

WORK IN PROGRESS
NOTE: I have not added docs for PromptEngine. Will do that if the discussion gets more serious
Changes:

Add a PromptEngine class:

Has a prompt driver.
Publishes prompt events.
Retries when prompt driver fails.
Branches run logic based on value of stream for use in a structure.

Edit BasePromptDriver responsibilities:

Remove event publishing.
Remove retry logic.
Remove stream branching logic.

Edit consumers within the framework to use PromptEngine rather than BasePromptDriver

Required for behavior parity (event publishing + retry logic)
TODO: list the consumers, (there weren't that many...)

Next Steps:

Add an engine for each driver, which will have the event publishing, retry logic, and any other fancy thing.
Update driver consumers to use engines instead.
Edit StructureConfig:

Remove references to event listeners and structure.
After making the other (non-prompt) drivers "stateless", you'll be able to use the same structure config instance across multiple structures without conflicts. (Though you should still avoid mutating the structure config after doing so, this PR doesn't solve that issue. Making structure config immutable would though)

To summarize the main idea:

Keep drivers "stateless".
Allow engines to be "stateful".
Client framework code should use engines rather than drivers, so that event publishing continues to work by default.

In our case, this means moving event publishing logic from drivers into engines.

Note: When I say "stateless", I don't actually mean no state; I actually mean "stateless" w.r.t. a specific piece of client code. I think its fine if say a driver has for example an s3 client, just as long as that wouldn't prevent a single instance of the driver from being used simultaneously in multiple contexts, like multiple structures.

Note: There are some alternative options to this, that I'd like to quickly explore before making any decisions. Publishing this for discussion purposes only.

This has been superseded by @collindutter 's work on adding an EventBus


Archive handles are not thread safe

The HANDLE type used by SFileOpenFile() et al is actually a pointer to a context structure of type TMPQArchive.
I have an application where the user can specify an arbitrary number of worker threads, which each will try to read from MPQs.  I was having very strange failures where opening of random files would return ERROR_FILE_CORRUPT but only on Linux.  I'm not sure if I was silently having this problem on Windows too, but I never saw an error on Windows.
The problem went away when I protected my open file function which uses stormlib with a mutex, ensuring only one thread at a time was trying to read from the open MPQs.
Is there perhaps documentation somewhere about thread safety with stormlib?  I have looked but haven't found it.
If I have to keep my current mutex solution then so be it, but if I can be more precise then that would be preferable.

StormLib is not thread safe.

Okay.  Do you think it would work to open each MPQ once per thread to avoid the lock contention?

Yes, or you can lock every file open on a particular archive.

Thanks!  Using a thread_local manager solved my performance problem.

Is it only OpenFile that is thread-unsafe, or ReadFile as well?

It'd be great to have a thread-safe API. Diablo opens multiple audio files that it streams from.


Docfx- https://docs.microsoft.com/en-us/aspnet/core/data/ef-mvc/intro,Getting started with ASP.NET Core MVC and Entity Framework Core using Visual Studio

Url : https://docs.microsoft.com/en-us/aspnet/core/data/ef-mvc/intro
( This url is just a sample page. this is applicable to entire documents)
In responsive mode the section "In This article " is being displayed under the author pic .
please see the screenshot. If this is intentional... please ignore this bug.

@tdykstra  can you fix this? cc @rick-anderson

@Rick-Anderson As noted, this applies across the board to all of docs.ms.com, not just to ef mvc tutorial.


from_str_radix panicking with decimal

let P = Bn::<u8, 64>::from_str_radix(
    "115792089237316195423570985008687907853269984665640564039457584007908834671663",
    10,
)
.unwrap();

// thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ParseIntError { kind: InvalidDigit }'

hex, or base 16 works just fine though. I'm lookig at fixeduint.rs and in the examples radices of { 2, 8, 16 } are being tested. Is 10 supported too, or is this a bug?

Uh, sorry for delayed response. No, base 10 or any other radix besides power of twos aren't implemented at all, i should have put a more explicit error in there.
The TODO list mentions:

Decimal string to/from conversion, currently only binary and hex strings are supported.

To be honest, i wrote this crate as a Rust learning exercise and trying to study how compact BigInt can be on Cortex-M0 and other low-end MCUs. I've since found that crypto-bigint pretty much does everything that this crate does, only better: https://github.com/kaidokert/fixed-bigint-rs/issues/26. It actually produces more compact code for RSA calcs and such.

Ah, I see.
Well, first thanks for this crate. Yours is one of the two options which compile for Arduino target (8-bit), crypto-bigint doesn't support that atm.
In my case, I'm implementing ecdsa and got a working solution using your code, and easy to read, however couldn't get memory usage down due to new allocation on every operation, so imagine you allocate another 64-byte number every time you do an addition, etc on Arduino Uno which has only 2048-byte ram.
Later I found awint, which might also be interesting to you as well, however the code is now way more verbose, yet memory's much more controllable.

Thanks for the pointer to awint, hadn't come across it, i'll take a look at their implementation.
Strictly speaking this crate doesn't allocate, e.g. no heap, but it does probably trash a lot of stack yes. The ops that could trivially be done in-place ( e.g. addition ) are, but not everything is ( shl , multiply , div ). With 2k RAM that runs out quick


elasticsearch fails due to IPv6

Intermittent failures occur when starting elasticsearch masters (and possible other components). The failures occur when the local network interface has both IPv4 and IPv6 addresses and elasticsearch attempts to bind to the IPv6 address first. If the IPv4 address is chosen first elasticsearch starts correctly.
Attached are two sets of logs, one showing a successful startup and the other showing a failure. The line of interest contains 'binding server bootstrap to' -- note the order of the IPs.
The workaround was to set NETWORK_HOST to _eth0:ipv4_ so only IPv4 is considered. You may want to add this note to the README.

Sounds reasonable. Care to open a PR?


feat: update golang-github-okzk-sdnotify to 0.0_git20180710.d9becc3

systemd's service notification protocol (sd_notify)
Issue: https://github.com/deepin-community/sig-deepin-sysdev-team/issues/552
Log: update repo

/lgtm
/approve


feat: add two opensource cdk tools

Issue #, if available:
Description of changes:
Adding 2 AWS CDK tools to the resource section of the cdk website:

AWS CDK Starterkit is a repository to get an AWS CDK app up and running in your AWS account in less than 5 minutes, leveraging GitHub Actions for seamless CI/CD.
CDK Construct Snippets for VS Code is an extension that adds L1 construct snippets from AWS CDK into Visual Studio Code.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks for submitting!


[MacOS] - standard dmg icon not entirely draggable

Slightly annoying is the fact that in the finder, if your icon has pure transparency (like the empty space of the tauri logo) - you will have difficulty dragging it. What happens is that MacOS thinks you want to select a draggable area - instead of simply dragging. On HiDPI screens this is quite literally super annoying.
Fix: create new standard icons (with at least a 0.1% transparent background).
Docs: add info about this "known behavior" to the identity page.

Others options would be to give the Tauri a 3px white border or follow others app by placing it into an white rounded rectangle. I do prefer the second over all three options (including yours) because for a fast "build and try" example is the easiest.

I would love to close this issue. @AlveLarsson - what are your thoughts here?

Peww, never had a mac so can't tell the behaviour. If it fits see if a drop shadow helps increasing the hitbox

Is this something I could take a look at to pick up?

Absolutely @lorenzolewis every help is welcome!

Are there any vectors available for the logo that I can build on? If not then I can just go based off the existing raster images

Below is a draft that I have so far using a standardised script I use for all my icons for a quick POC. Once I get the vectors I'll just run it through again (should get rid of the artefacts around the edges as well).

Draft apps now match the other rounded icons in my dock :)

@lorenzolewis got the logo here, Github don't support SVG uploads for some reason and I'm short on time, so here is the raw svg dump
<svg width="151" height="168" viewBox="0 0 151 168" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M105.46 60.95c0 8.78-7.23 15.9-16.14 15.9a16.03 16.03 0 0 1-16.15-15.9c0-8.79 7.23-15.91 16.15-15.91 8.91 0 16.14 7.12 16.14 15.9Z" fill="#FFC131"/><path d="M46.01 106.5c0-8.79 7.23-15.91 16.15-15.91 8.92 0 16.15 7.12 16.15 15.9 0 8.8-7.23 15.91-16.15 15.91A16.03 16.03 0 0 1 46 106.5Z" fill="#24C8DB"/><path fill-rule="evenodd" clip-rule="evenodd" d="M122.78 111.95a62.15 62.15 0 0 1-21.27 8.53 42.03 42.03 0 0 0 2.06-19.23 43.57 43.57 0 0 0 9.26-4.46 42.87 42.87 0 0 0 15.99-18.31 42.1 42.1 0 0 0 3.33-23.93 42.4 42.4 0 0 0-10.39-21.88A43.42 43.42 0 0 0 101 19.84a43.95 43.95 0 0 0-24.52.35 43.37 43.37 0 0 0-22.36 15.88c-8.25.9-16.25 3.2-23.64 6.77A60.47 60.47 0 0 1 42 22 61.72 61.72 0 0 1 71.03 2.94a62.55 62.55 0 0 1 34.9-.49 61.79 61.79 0 0 1 29.56 18.25 60.34 60.34 0 0 1 14.78 31.14 59.91 59.91 0 0 1-4.74 34.05 61 61 0 0 1-22.75 26.06Z" fill="#FFC131"/><path fill-rule="evenodd" clip-rule="evenodd" d="M28.59 55.49a62.18 62.18 0 0 1 21.44-8.56 42 42 0 0 0-2.4 19.33 43.6 43.6 0 0 0-9.1 4.4 42.87 42.87 0 0 0-15.98 18.3 42.1 42.1 0 0 0-3.33 23.94 42.4 42.4 0 0 0 10.39 21.88 43.42 43.42 0 0 0 20.77 12.82 43.95 43.95 0 0 0 24.52-.34 43.37 43.37 0 0 0 22.37-15.9 72.76 72.76 0 0 0 23.65-6.81 60.47 60.47 0 0 1-11.55 20.89 61.72 61.72 0 0 1-29.03 19.06 62.55 62.55 0 0 1-34.9.49 61.78 61.78 0 0 1-29.56-18.25A60.35 60.35 0 0 1 1.1 115.6a59.92 59.92 0 0 1 4.74-34.05A61 61 0 0 1 28.59 55.5Z" fill="#24C8DB"/></svg>

Thanks @AlveLarsson
Btw, is there any specific place in the repo where static reference assets that don't necessarily get bundled in a release go? I'm thinking this would be a good item to put in there.

@AlveLarsson that one is a slightly different version than what currently exists. The one you sent looks to be the logo that's on tauri.studio so it might make more sense to use this version to align the visual design anyway.

Dock shot:


Allow some accessing properties of string and other primtives

I haven't encountered any yet.
On Tue, Aug 21, 2018 at 7:32 PM Arjun Guha<EMAIL_ADDRESS>wrote:

@arjunguha commented on this pull request.
Do numbers and booleans have any properties that are worth accessing? I'm
curious because I haven't thought it through.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/plasma-umass/ElementaryJS/pull/35#pullrequestreview-148288432,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADP5vUPMUMfy29E72s8n13X_IkuRP5f_ks5uTJiCgaJpZM4WGd2P
.

I included booleans and numbers out of completeness, as far as properties worth accessing, I don't think so. Numbers only have some convenient functions that return formatted strings (which can be pretty easily implemented by hand). Booleans has toString() and valueOf and they aren't that useful.

OK, merge anyway. The principle is that no harm is done by invoking these methods.


adding a new example

This example, tho simple, i believe can be interesting.

It looks like this PR was opened by mistake perhaps?

It looks like this PR was opened by mistake perhaps?

Yes, it was a duplicate of an unready pull request that i forgot to delete, Sorry.


A couple of enhancements

Currently retrieving the tokens returned by the authorisation process and applying authentication scopes to the authorization request are a pain and require overriding methods on the OAuth2 strategies prototype.
This passes the accessToken & refreshToken into the constructors callback so that authenticated CREST resources can be used after authentication.
scope query parameters can also be defined for the authorisation request in the constructors options object.
Usage:
new EveOnlineStrategy({
  "clientID": "xxx",
  "clientSecret": "xxx",
  "callbackURL": "http://localhost",
  "scope": "characterAccountRead characterAssetsRead characterBookmarksRead"},
function(access, refresh, charInfo, done) {
  charInfo.access = access;
  done(null, charInfo);
});

@psykzz If this pr doesn't get merged, it's pretty simple to do something similar with passport-oauth2. See this gist: https://gist.github.com/sjt88/fee741c77e6332e17214601a6e3c8271

These commits are interwoven with each other and aren't independent.  It's probably best to either split them out separately or squash them into one commit.

I'm assuming this PR is dead? Scope support would be excellent.


Improve AOT snapshot input verification + cleanup

Bugfix: Moves AOT snapshot input verification past where the last input
is added to the inputs list.
Cleanup:

Extracts _isValidAotPlatform method.
Moves non-platform-specific logic to the top.
Moves variable declaration closer to first use, and inlines to a
narrower scope where possible.

This relands #17136, which was reverted in #17142 due to breakage in
on-device iOS debug builds.

RSLGTM

Related #2089

Looks like this is still problematic in iOS debug builds. Fixed in #17145 where we eliminate the iOS debug snapshotting step altogether (since the data in question is already present in Flutter.framework).


Gutter sync issues

The line number gutter fails to stay in sync with the editor when the editor is zoomed, or sometimes when it is scrolled. It also goes out of sync when moving to the end of the document by the Control-End shortcut.

This seems to have been mostly fixed with the updated codebase for AHKv2. However, there still seems to be some issues relating to zoom.


README.md Instruction Update Recommendation for WSL

The README.md instructions didn't get me to the finish line.  I had to change the path variables.  Not sure if it was because of my setup or because I am on WSL v 14.04.5 LTS.
Propose a feature:
Add instructions for WSL:
export PATH="$~/.linuxbrew/bin:$PATH"
export MANPATH="$~/.linuxbrew/share/man:$MANPATH"
export INFOPATH="$~/.linuxbrew/share/info:$INFOPATH"

or
export PATH="$HOME/$username/.linuxbrew/bin:$PATH"
export MANPATH="$HOME/$username/.linuxbrew/share/man:$MANPATH"
export INFOPATH="$HOME/$username/.linuxbrew/share/info:$INFOPATH"

vice:
export PATH="$HOME/.linuxbrew/bin:$PATH"
export MANPATH="$HOME/.linuxbrew/share/man:$MANPATH"
export INFOPATH="$HOME/.linuxbrew/share/info:$INFOPATH"

This should work:
export PATH="$HOME/.linuxbrew/bin:$PATH"

Did it not work for you?
Please report
echo x ~ x
echo x $HOME x
echo "$HOME/.linuxbrew/bin:$PATH"


[BUG] Only root can see the set password backend page

When logged in as root:

When logged in as admin (the role of my client):

I've tried to set a permission:  in the config, however this did not work. I also tried to set a permission in the extensions getDefaultConfig() however this did not work either.
Not quite sure what is stopping the menu entries from being added.

Fixed in #17


I use Chinese and English mixed dataset  and a another custom 7B model to train eagle，but the performance in Chinese is not good enough

I had modified the preprocess_function.And the used data is the sft data of the model.
The pictures are the results of the training and testing in training:

but I use Spec-Bench project to test on Chineses dataset, the Mean accepted tokens is only 2.5994782086414654, not good enough.
Anything else to pay attention, Can you give some advice?Thanks!

I noticed that your top-3 accuracy on the training set is only about 0.8, which is relatively low. What is your training accuracy on the English dataset? If it is close to the accuracy on the Chinese dataset, it could be that the structure or size of the draft model is not suitable. If the English accuracy is significantly higher than the Chinese accuracy, it is possible that your base model is not sufficiently trained on Chinese, and its features cannot effectively capture the semantic information of Chinese.


changed some instructions, add sudo back into instructions

Just going to merge this since there weren't too many changes, and I think the students should be able to work on this lab asap without as much confusion