Add configurable scaling behavior for Istiod's HPA in helm chart

This PR fixes #42634
Please provide a description of this PR:
Users can optionally specify scaling behavior for the autoscaling/v2 HPA for istiod in the istio-discovery helm chart.
The behavior was stabilized in Kubernetes 1.23, and is therefore only applied for the autoscaling/v2 apiVersion, not for autoscaling/v2beta1.
Here is an example configuration for the helm values.yaml:
pilot:
  autoscaleEnabled: true
  autoscaleBehavior:
    scaleUp:
      stabilizationWindowSeconds: 30
      policies:
        - type: Pods
          value: 1
          periodSeconds: 30

Hi @oliviermichaelis. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@oliviermichaelis: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test unit-tests-arm64

release-notes_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test unit-tests-arm64

release-notes_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test release-notes

gencheck_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test unit-tests-arm64

release-notes_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test release-notes

gencheck_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test gencheck

unit-tests_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test unit-tests-arm64

release-notes_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test release-notes

gencheck_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test gencheck

unit-tests_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test unit-tests

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test release-notes

gencheck_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test gencheck

unit-tests_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test unit-tests

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test release-notes

gencheck_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test gencheck

unit-tests_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test unit-tests

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test release-notes

gencheck_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test gencheck

unit-tests_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test unit-tests

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test gencheck

unit-tests_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test unit-tests

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test gencheck

unit-tests_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test unit-tests

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test gencheck

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test gencheck

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test gencheck

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
d881aa8b8157ab685efba0e65fd7882ae7f8777b
link
true
/test gencheck

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-multicluster

gencheck_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-multicluster

gencheck_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test gencheck

integ-telemetry_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-multicluster

gencheck_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test gencheck

integ-telemetry_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-multicluster

gencheck_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test gencheck

integ-telemetry_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-istiodremote

integ-security_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-multicluster

gencheck_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test gencheck

integ-telemetry_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-istiodremote

integ-security_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security

integ-ipv6_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ipv6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-multicluster

gencheck_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test gencheck

integ-telemetry_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-istiodremote

integ-security_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security

integ-ipv6_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ipv6

analyze-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test analyze-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-multicluster

gencheck_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test gencheck

integ-telemetry_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-istiodremote

integ-security_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security

integ-ipv6_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ipv6

analyze-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test analyze-tests

lint_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-multicluster

gencheck_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test gencheck

integ-telemetry_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-istiodremote

integ-security_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security

integ-ipv6_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ipv6

analyze-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test analyze-tests

lint_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test lint

integ-helm_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-helm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-multicluster

gencheck_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test gencheck

integ-telemetry_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-istiodremote

integ-security_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security

integ-ipv6_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ipv6

analyze-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test analyze-tests

lint_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test lint

integ-helm_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-helm

integ-ds_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-multicluster

gencheck_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test gencheck

integ-telemetry_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-istiodremote

integ-security_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security

integ-ipv6_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ipv6

analyze-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test analyze-tests

lint_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test lint

integ-helm_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-helm

integ-ds_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ds

integ-cni_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-multicluster

gencheck_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test gencheck

integ-telemetry_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-istiodremote

integ-security_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security

integ-ipv6_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ipv6

analyze-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test analyze-tests

lint_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test lint

integ-helm_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-helm

integ-ds_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ds

integ-cni_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-cni

integ-operator-controller_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-operator-controller

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-multicluster

gencheck_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test gencheck

integ-telemetry_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-istiodremote

integ-security_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security

integ-ipv6_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ipv6

analyze-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test analyze-tests

lint_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test lint

integ-helm_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-helm

integ-ds_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ds

integ-cni_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-cni

integ-operator-controller_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-operator-controller

integ-security-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-multicluster

gencheck_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test gencheck

integ-telemetry_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-istiodremote

integ-security_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security

integ-ipv6_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ipv6

analyze-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test analyze-tests

lint_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test lint

integ-helm_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-helm

integ-ds_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ds

integ-cni_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-cni

integ-operator-controller_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-operator-controller

integ-security-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security-istiodremote

integ-security-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-notes_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-notes

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-multicluster

gencheck_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test gencheck

integ-telemetry_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-istiodremote

integ-security_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security

integ-ipv6_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ipv6

analyze-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test analyze-tests

lint_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test lint

integ-helm_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-helm

integ-ds_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ds

integ-cni_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-cni

integ-operator-controller_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-operator-controller

integ-security-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security-istiodremote

integ-security-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security-multicluster

integ-pilot-istiodremote-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-basic-arm64

integ-distroless_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-distroless

integ-pilot_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot

release-test_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test release-test

unit-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test unit-tests

integ-telemetry-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-mc

integ-telemetry-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry-istiodremote

integ-pilot-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-multicluster

integ-telemetry_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-istiodremote

integ-security_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security

integ-ipv6_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ipv6

analyze-tests_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test analyze-tests

integ-helm_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-helm

integ-ds_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-ds

integ-cni_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-cni

integ-operator-controller_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-operator-controller

integ-security-istiodremote_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security-istiodremote

integ-security-multicluster_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-security-multicluster

integ-pilot-istiodremote-mc_istio
4aa783fa3ed96114dfeb8a2490ae0c2808f55d06
link
true
/test integ-pilot-istiodremote-mc

gencheck_istio
c72297eeb767d0e6c930443b24c09ec7efba9c8b
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Can this PR be reviewed and pushed further?

Thanks for the reviews! Is there anything I can do to help get this PR reviewed by the right people?

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oliviermichaelis: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
7735aa243cf825308715878fb3f0ff90b2e24b82
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@oliviermichaelis: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
7735aa243cf825308715878fb3f0ff90b2e24b82
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oliviermichaelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
7735aa243cf825308715878fb3f0ff90b2e24b82
link
true
/test integ-ambient

integ-security-multicluster_istio
333069e802c90f9b8a2e040b98cec46c3e4462d5
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oliviermichaelis: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
333069e802c90f9b8a2e040b98cec46c3e4462d5
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I haven't had time or access to a suitable machine to rebase the PR, but will do so soon.
I can imagine that reviewer's resources are scarce, but I would highly appreciate if one of the missing code owners could review the PR to prevent the frequent required rebases :)

/reopen

reopen

/retest

cc @craigbox

A test comment


[CLARITY] Should not be forced to source setup_env.sh to run Makefile infrastructure

In general, we should avoid using sh scripts in favor of makefile to be consistent with the rest of our infrastructure code. But we should especially avoid requiring that a sh script be sourced for the makefiles to work. Common environment variables should be put in a common location for makefiles to include.
I personally find it cumbersome to have to source a script every time I login or open a new shell... but beyond that, sourcing is also shell specific unlike makefiles (ie. setup_env.sh only works with bash, it won't work with other common shells like csh). The other thing is that sourcing has this really bad persistence issue when developing infrastructure. When writing infrastructure code you basically want to make as few assumptions about the environmental state of the machine as you can. But when sourcing is part of your setup it become real tedious to get back to that near-0 assumption state (you need to close your shell, open a new one and re-source). If you don't then you can get into really silly issues... for example: if you want to change the name of a variable in setup_env.sh, if you don't shutdown your shell then when you re-source the script both the old and new variables will exist in your environment which can hide dependencies on the old name that were not updated.

Sounds good.  I originally did it because I couldn't figure out how to get flists to respect environment variables (but I guess you can just .export from Makefiles).  I'll refactor into a Makefile.common that sets the environment variables

(Probably should do this for the regression scripts, too, although I'm kind of waiting to see how CI will interact with them)

Fixed in 82dda501d5dd12a8d3d31cd1bc7302058693e950


Update to vert.x 3.4.1

Update to vert.x 3.4.1 (currently on the 3.3.x version)

Do you plan to do that before the release?

Doesn’t matter, it won’t affect the pac4j release. We should not release vertx-pac4j without it though, but there will (and should) be a short time lag between the two releases, which should give me time to accommodate vert.x changes between 3.3 and 3.4.
Don’t delay the pac4j release for it.

On 2 May 2017, at 08:32, LELEU Jérôme<EMAIL_ADDRESS>wrote:
Do you plan to do that before the release?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/pac4j/vertx-pac4j/issues/106#issuecomment-298527396, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQfzq4M7QvbgO_CBKOBMDDC-Qc7EANZks5r1twKgaJpZM4NNy4k.

Are they both major versions (I mean v3.3 and v3.4)? Because in that case, it would certainly be better to release:

vertx-pac4j v3.0.0 based on pac4j v2.0.0 + Vert.x 3.3
vertx-pac4j v3.1.0 based on pac4j v2.0.0 + Vert.x 3.4

?

They are major versions, but we have already seen on the google group someone trying to use 3.4.1 of vert.x (although in a particularly ill-advised manner). I would suggest i make the attempt tomorrow and if it looks as though I can get everything passing by the weekend, we plan to release 3.0.0 next week with 3.4. If not, then we release sooner. Worst case, we release 3.0.0 early next week with 3.3 and 3.1.0 soon afterwards.

OK. Ping me when you'll be ready for the release.

Just ran a build against 3.4.1 and it looks promising. I’ll try and do some testing for the demo this evening as well :) If all looks ok I’ll push tomorrow.

On 2 May 2017, at 08:50, LELEU Jérôme<EMAIL_ADDRESS>wrote:
OK. Ping me when you'll be ready for the release.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/pac4j/vertx-pac4j/issues/106#issuecomment-298535241, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQfzhP1_xebbRcm9IbVDSJ2mYy8Ikrwks5r1uBFgaJpZM4NNy4k.


Roll engine f200ee13aa37..ba909c79bbd8 (2 commits)

git@github.com:flutter/engine.git/compare/f200ee13aa37...ba909c79bbd8
git log f200ee13aa37..ba909c79bbd8 --no-merges --oneline
2019-08-08<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from 8mNHG... to 5c9q-... (flutter/engine#10710)
2019-08-07<EMAIL_ADDRESS>Revert "Remove semi-redundant try-jobs. (#10485)" (flutter/engine#10705)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jimgraham@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5726705975558144

Commit queue failed; closing this roll.


Ta activity stats

Current stats provided for admins and graders in the submission status column providing info on assignments completed and average number of annotations per submission that has been marked as having been 'completed' marking.
See https://slack-files.com/T0AGA2MQX-F0CPFN7QE-cabb89d8c8 for details.
Also see https://slack-files.com/T0AGA2MQX-F0DMA2NRX-5d7dc9c897 for more details on TA grade distribution

@finnergizer I'm quite happy with this pull request now. I've made a couple of comments, but once those are done I'm confident about merging this in.

Thanks for the help @david-yz-liu. Made the suggested logic change and added a check for an edge case. I also refactored the assignment stat methods to be in the assignment model only, as well as removed the one vendor prefix suggested.

Great work, @finnergizer!


Unable to enter Name when now cc add

Full Name input becomes terminal input again for some reason

I can reproduce 😩 Thanks a lot for reporting – will fix it ASAP!

Closing because I can not reproduce using the latest version of Now CLI. Let us know you are still experiencing this.


latency due to daemon threads getting created on every event in slackclient 2.5

im using slackclient 2.5, while using rtm.start(), every time we receive an event from slack, it opens a new daemon thread, since a daemon thread wont stop until main thread is terminated, these threads keep adding up and ultimately result in high cpu utilization.

Hi @rish-lab , we've fixed the CPU usage issue in version 2.6.0. https://github.com/slackapi/python-slack-sdk/issues/569
Could you consider upgrading to 2.6.0+? Using the latest - 2.9.3 is highly recommended. All 2.x versions do not have any breaking changes.

@rish-lab Was my previous comment helpful for you? Let me close this issue after waiting for your response for a few more days.


Feature Request - Support tabs in hashrocket alignment

The first version of the hashrocket alignment feature only supported space based indentation.
Need to add support for tab-based indentation.

Won't do.  Puppet lint syntax is two space indentation


Occasional crash on CI because the activity service is not running

Logs:
⠋ Artifacts are not present, downloading...
✓ Downloaded artifacts (7.6s)
No device specified, using the first one (emulator-5554)
⠋ Forwarding ports...
✓ Forwarded ports (53ms)
⠋ Installing server...
✓ Installed server (16.2s)
⠋ Installing instrumentation...
✓ Installed instrumentation (8.7s)
> Running example_test.dart on emulator-5554...
glTexImage2D: got err pre :( 0x506 internal 0x8058 format 0x1908 type 0x[140](https://github.com/leancodepl/patrol/actions/runs/3388890817/jobs/5631381258#step:10:144)1
glTexImage2D: got err pre :( 0x506 internal 0x8058 format 0x1908 type 0x1401
Warning: You are using these overridden dependencies:
! flutter_driver 0.0.0 from git https://github.com/jakubfijalkowski/flutter.git at 496ca2 in packages/flutter_driver
pl.leancode.automatorserver.ServerLoop:
INSTRUMENTATION_ABORTED: System has crashed.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
cmd: Can't find service: activity
Error: ADB exited with exit code 1
Performing Streamed Install

adb: failed to install /Users/runner/work/patrol/patrol/packages/patrol/example/build/app/outputs/flutter-apk/app.apk: cmd: Can't find service: package
Application failed to start on attempt: 1
cmd: Can't find service: activity
Error: ADB exited with exit code 1
Performing Streamed Install

adb: failed to install /Users/runner/work/patrol/patrol/packages/patrol/example/build/app/outputs/flutter-apk/app.apk: cmd: Can't find service: package
Application failed to start on attempt: 2
cmd: Can't find service: activity
Error: ADB exited with exit code 1
Performing Streamed Install

adb: failed to install /Users/runner/work/patrol/patrol/packages/patrol/example/build/app/outputs/flutter-apk/app.apk: cmd: Can't find service: package
Application failed to start on attempt: 3
Application failed to start. Will not run test. Quitting.
✗ example_test.dart failed
flutter_driver exited with code 1
See the logs above to learn what happened. If the logs above aren't useful then it's a bug – please report it.

Might be worth to tell our users to set the -delay-adb flag when booting the AVD.
$ emulator --help | grep 'delay-adb'
    -delay-adb                                                          delay adb communication till boot completes


The canal_json_storage_basic test failed

Which jobs are flaking?
canal_json_storage_basic test
Which test(s) are flaking?
canal_json_storage_basic test
Jenkins logs or GitHub Actions link
None
Anything else we need to know
None

/remove-severity minior

/severity critical


<EMAIL_ADDRESS>Package Install Error Any Solution ?

I try to update my package in Go-Lang project... why this error came.. I use several go-lang version.. Any Solution ?
 Try re-running with the following command:
CGO_ENABLED=1 go run main.go

If it works, check your environment to see who set CGO_ENABLED to 0.

yheee...its right after C package Install problem solved


Add scraper for Mass Land Court

This was added and merged.

Although we still need to add it to courtlistener.


Steamvr bindings not working

Hey, I have made all configuration for input in unity. everything works in editor and in build on local PC, but when opening on new pc controllers does not work and bindings are unbound. can anyone help how to force steam to use set actions and bindings from the build ?

+1 same issue here

Figured out how to make it work :)
IDK if it should work like this, but i have deleted all bindigns and created new one and named it in my case "VRTestInput"(as i can see if you will leave it on default its not working).
configured and now its working on any PC :)


Fix README blind tilt indentation

:recycle: Current situation
Indentation in the README was missing for the information about blinds tilt.  Accidentally missed this when getting my blinds tilt, completely missing that I needed the hub 🙃
:bulb: Proposed solution
Simple fix to add indentation.
:gear: Release Notes
N/A
Testing
N/A
Reviewer Nudging
N/A

Thanks


Add Oculus support

I also tried Oculus over Steam VR. Running exokit.sh -h and pressing ctrl-1 to enter VR mode results in a crash.

This is the error I get when launching node index.js -h after pressing ctrol-1 and Oculus present via SteamVR:
Error: Compositor error: VRCompositorError_TextureUsesUnsupportedFormat
    at _blit (C:\exokit\index.js:701:39)
    at Timeout._recurse [as _onTimeout] (C:\exokit\index.js:1151:5)
    at ontimeout (timers.js:427:11)
    at tryOnTimeout (timers.js:289:5)
    at listOnTimeout (timers.js:252:5)
    at Timer.processTimers (timers.js:212:10)
Bugsnag:  Encountered an uncaught error, terminating…
Error: Compositor error: VRCompositorError_TextureUsesUnsupportedFormat
    at _blit (C:\exokit\index.js:701:39)
    at Timeout._recurse [as _onTimeout] (C:\exokit\index.js:1151:5)
    at ontimeout (timers.js:427:11)
    at tryOnTimeout (timers.js:289:5)
    at listOnTimeout (timers.js:252:5)
    at Timer.processTimers (timers.js:212:10)

Thanks, this looks like the format of the texture is one oculus binding doesn't like. Needs some research.

Would be curious if the OpenVR example works in Oculus SteamVR, because that's pretty much what Exokit is doing.

Work on this issue might have conflicts with https://github.com/webmixedreality/exokit/pull/286.

Thanks for letting me know. I'm planning to get back to this after next week.

@dmarcos Is there a starting base here? I think @cmdrflexo wanted to dive in.

Not sure if he had too much, at least not NAN bindings. I think flexo could start. I was gonna start on the mobile SDK.

Just to throw in my two cents here, I have been able to use it on oculus through steam many times.
I usually start like this in the exokit folder:
Exokit version 0.0.482 - installed via git clone and npm install.
node . https://aframe.io/a-painter/

Is there any performance hit or gotchas when doing so? I'm glad it works either way, was a pleasant surprise to hear.

Not that i'm aware of, it just works. I actually used it quite a while ago around version 0.0.420 :smirk: and it worked just as well. Only issue i have was the movement-controls component had its axis' reversed but i don't think that was anything to do with exokit as it was already reported on their issue tracker.
Maybe we should all list the kit we have in a sticky location so we know what everyone has to test with.

Cool! Still will want native support, especially as headsets go standalone. I think there'd be some perf issues (we saw on WMR + Steam), perhaps as the app scales. Like does ATW work?

Agree, should aim for native on all desired platforms. I'm guessing there's no other option for Santa Cruz/Quest anyway.
Quest is Android though, so I'm not sure how much the binding would be Android vs how much OVR.

I'm not sure on the ATW, how do i check that?

Hi, I'm planning to start work on adding a native LibOVR binding. Just checking if anyone else has started work on this?

Would be much appreciated!
I don't think @dmarcos got very far, though there is a binary module at https://www.npmjs.com/package/native-oculus-deps

@dmarcos related to this, would you mind sharing collaborator status on npm/native-oculus-deps with @kazmer?

Done

Thanks!
On Thu, Jan 3, 2019 at 9:19 AM Diego Marcos<EMAIL_ADDRESS>wrote:

Done
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/webmixedreality/exokit/issues/146#issuecomment-451155823,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGmu6RWbJPKXA0HOvf6Ojmt4u4gPaYSqks5u_hFegaJpZM4U-qC5
.


Adding Kokkos profiling regions to Search

Fix #533.

With modified DTK_MARK_REGION (so as not to use BOOST_CURRENT_FUNCTION) this spits something like this (please ignore the numbers, as that was from multiple runs within google benchmark):
BEGIN KOKKOS PROFILING REPORT:
TOTAL TIME: 7.95467 seconds
TOP-DOWN TIME TREE:
<average time> <percent of total time> <percent time in Kokkos> <percent MPI imbalance> <number of calls> <name> [type]
===================
|-> 2.24e+00 sec 28.2% 100.0% 0.0% 59 DTK:BVH:spatial [region]
|   |-> 1.10e+00 sec 13.8% 100.0% 0.0% 59 DTK::BVH:first_pass [region]
|   |   |-> 1.10e+00 sec 13.8% 100.0% 0.0% 59 DTK_first_pass_at_the_search_count_the_number_of_indices [for]
|   |-> 1.07e+00 sec 13.4% 100.0% 0.0% 59 DTK::BVH:second_pass [region]
|   |   |-> 1.07e+00 sec 13.4% 100.0% 0.0% 59 DTK_second_pass [for]
|   |-> 7.62e-02 sec 1.0% 99.0% 0.0% 59 DTK:BVH:sort_queries [region]
|   |   |-> 2.45e-02 sec 0.3% 100.0% 0.0% 59 DTK_assign_morton_codes_to_queries [for]
|   |   |-> 1.97e-02 sec 0.2% 100.0% 0.0% 59 Kokkos::Sort::BinBinning [for]
|   |   |-> 1.25e-02 sec 0.2% 100.0% 0.0% 59 Kokkos::Sort::BinSort [for]
|   |   |-> 8.89e-03 sec 0.1% 100.0% 0.0% 59 Kokkos::Sort::BinCount [for]
|-> 1.54e+00 sec 19.4% 100.0% 0.0% 24 DTK:BVH:knn [region]
|   |-> 1.50e+00 sec 18.9% 100.0% 0.0% 24 DTK:BVH:traversal [region]
|   |   |-> 1.50e+00 sec 18.9% 100.0% 0.0% 24 DTK_perform_nearest_queries [for]
|   |-> 3.19e-02 sec 0.4% 98.9% 0.0% 24 DTK:BVH:sort_queries [region]
|   |   |-> 9.85e-03 sec 0.1% 100.0% 0.0% 24 DTK_assign_morton_codes_to_queries [for]
|   |   |-> 8.48e-03 sec 0.1% 100.0% 0.0% 24 Kokkos::Sort::BinBinning [for]
|-> 1.52e+00 sec 19.1% 99.8% 0.0% 186 DTK:BVH:construction [region]
|   |-> 5.31e-01 sec 6.7% 100.0% 0.0% 186 DTK:BVH:generate_hierarchy [region]
|   |   |-> 5.31e-01 sec 6.7% 100.0% 0.0% 186 DTK_generate_hierarchy [for]
|   |-> 5.22e-01 sec 6.6% 99.6% 0.0% 186 DTK:BVH:initialize_leaf_nodes [region]
|   |   |-> 2.30e-01 sec 2.9% 100.0% 0.0% 186 Kokkos::Sort::BinBinning [for]
|   |   |-> 1.04e-01 sec 1.3% 100.0% 0.0% 186 Kokkos::Sort::BinSort [for]
|   |   |-> 7.09e-02 sec 0.9% 100.0% 0.0% 186 Kokkos::Sort::BinCount [for]
|   |   |-> 6.72e-02 sec 0.8% 100.0% 0.0% 186 DTK_initialize_leaf_nodes [for]
|   |   |-> 1.33e-02 sec 0.2% 100.0% 0.0% 186 Kokkos::Sort::CopyPermute [for]
|   |   |-> 1.28e-02 sec 0.2% 100.0% 0.0% 186 Kokkos::Sort::BinOffset [scan]
|   |   |-> 1.04e-02 sec 0.1% 100.0% 0.0% 186 DTK_find_min_max_view [reduce]
|   |-> 2.51e-01 sec 3.2% 99.8% 0.0% 186 DTK:BVH:calculate_bounding_volumes [region]
|   |   |-> 2.46e-01 sec 3.1% 100.0% 0.0% 186 DTK_calculate_bounding_boxes [for]
|   |-> 1.77e-01 sec 2.2% 99.9% 0.0% 186 DTK:BVH:assign_morton_codes [region]
|   |   |-> 1.77e-01 sec 2.2% 100.0% 0.0% 186 DTK_assign_morton_codes [for]
|   |-> 4.01e-02 sec 0.5% 99.7% 0.0% 186 DTK:BVH:calculate_scene_bounding_box [region]
|       |-> 4.00e-02 sec 0.5% 100.0% 0.0% 186 DTK_calculate_bounding_box_of_the_scene [reduce]

Does this look OK?

Codecov Report

Merging #534 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
+ Coverage   96.22%   96.23%   +0.01%
==========================================
  Files         128      128
  Lines        9303     9332      +29
==========================================
+ Hits         8952     8981      +29
  Misses        351      351

Impacted Files
Coverage Δ

packages/Search/src/DTK_LinearBVH.hpp
100% <100%> (ø)
:arrow_up:

...details/DTK_DetailsBoundingVolumeHierarchyImpl.hpp
100% <100%> (ø)
:arrow_up:

...es/Search/src/details/DTK_DetailsTreeTraversal.hpp
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b2f264...dae4e86. Read the comment docs.

Moving this PR to arborx/arborx#11.


tests improvement

[x] add some performance tests, to compare expected runtime per test, and alert for new run with bad/unexpected performance.
[x] add some options to run tests per categories (e.g. istio / k8s / calico)
[ ] Add a list of all tests that failed

Shireen, this is also something to take a look at.
We can start with just measuring and reporting the time per test and per category.

* [ ]  add some options to run tests per categories (e.g. istio / k8s / calico)

Hi,
is adding a new --flag to choose the category of tests you want to run will be helpful?

* [ ]  add some options to run tests per categories (e.g. istio / k8s / calico)

Hi, is adding a new --flag to choose the category of tests you want to run will be helpful?

yes, a new flag sounds good.
It may be supported for tests of type 'general' or 'output'.
It's easier to start with 'general'. For the 'output' tests we may need to move the test files into relevant categories dirs.

* [ ]  Add a list of all tests that failed

How to output the list of failing file? into a new output file or to the existing log (stdout) under the summary ?

* [ ]  Add a list of all tests that failed

How to output the list of failing file? into a new output file or to the existing log (stdout) under the summary ?

To the existing log under the summary


Source file parse doesn't ignore '.'

I created a custom source file to parse BRO logs. By default BRO has key names containing dots like id.orig_h or id.resp_h. When I do the following destination_address = 'id.orig_h' and run eqllib it ignores this mapping. However, if I manually change id.orig_h to dest_addr in the JSON log file and change my source file statement to destination_address = 'dest_addr' it works.
bro-source.toml
name = "Bro events"
strict = true
domain = "bro-domain"
filter_query = true

[timestamp]
field = "ts"
format = "%Y-%m-%d %H:%M:%S.%f"

[fields.mapping]
ts = "ts"
uid = "uid"
destination_address = 'id.orig_h'

[events.bro_conn]
filter = "conn_state"

[events.bro_conn.mapping]
proto = 'proto'
conn_state = 'conn_state'
local_orig = 'local_orig'
local_resp = 'local_resp'

bro-domain.toml
name = "bro-domain"
fields = [
  # Common Fields
  "ts",
  "uid",
  "destination_address"
]

[events.bro_conn]
fields = [
  "proto",
  "conn_state",
  "local_orig",
  "local_resp",
  "missed_bytes"
]

hey @CptOfEvilMinions I think we've talked about this indirectly in other places but I haven't responded here. With EQL a . indicates a nested field, but I think with the bro logs the native fields were named "ip.orig_h" and "id.resp_h", which caused the problems.
This is an interesting scenario, because we currently require all field names to match a-zA-Z][a-zA-Z0-9_]*
https://github.com/endgameinc/eql/blob/aa55970fd57996aed7519a8eda94c3fe472d15c2/eql/etc/eql.ebnf#L231
Since . already means something in EQL, there are a few ways we could do this:

One option is to escape all characters that don't match that regex. id\.orig_h.
Another option is to use the string syntax and do something like this ["id.orig_h"].

Then your EQL queries would look like one of these
network where id\.orig_h == "<IP_ADDRESS>"
network where ["id.orig_h"] == "<IP_ADDRESS>"
network where .["id.orig_h"] == "<IP_ADDRESS>"

Also since your blog, it should be a lot easier to make your own schema, and EQL will autodetect it from your JSON file if you use the new interactive shell
Any preferences for the syntax?

See https://github.com/endgameinc/eql/issues/15

Resolved by https://github.com/endgameinc/eql/issues/19


Update package.json (introduce peerDependencies)

Move redux and redux-devtools-extension to peerDependencies to avoid versions conflicts.
Related to https://github.com/microsoft/redux-micro-frontend/issues/22

This is possible to validate this pull request or there are some problems that appear with this changes ?

Please it's possible to approve this pull request !?


I cannot specify the Values field on a new StructuredSnippetAsset becaus it is "get" only.

Describe the bug:
Steps to Reproduce:
Please provide a code snippet or steps to consistently reproduce the experienced behavior.
[DO NOT INCLUDE ANY PERSONAL OR SENSITIVE DATA IN YOUR SUBMITTED CODE]
Expected behavior:
Client library version and API version:
Client library version:
Google Ads API version:
.NET version:
Operating system (Linux, Windows, ...) and version (if the bug is platform-specific):
Request/Response Logs:

Anything else we should know about your project / environment

See https://github.com/googleads/google-ads-dotnet/issues/346 for a fix.

Hello. I do not believe #346 is a fix for my issue. #346 refers to a Mutate Request and the solution you provided is to use a different request (in that case, a Mutate Campaigns Request).
But my problem is that the StructuredSnippetAsset cannot be created in C# because the only field it needs (the Values field) is read only. It is not a Mutate Request problem, it is a class problem (the StructuredSnippetAsset would be created, in my routine, inside a Batch Request, which is working fine for the rest of the items I'm creating - campaign, adgroups, CalloutAssets, etc).
Could you please have a look at the StructuredSnippetAsset class?

Thanks!

It's the same thing; basically the question is how to populate a RepeatedField.
// Newer C# versions with collection initialization syntax.
StructuredSnippetAsset asset = new StructuredSnippetAsset()
{
    Values = { "foo", "bar" }
 };
 // Older C# versions.
 asset.Values.AddRange( {"foo", "bar"} );

Thanks!
On Tue, May 10, 2022 at 1:08 PM Anash P. Oommen @.***>
wrote:

It's the same thing; basically the question is how to populate a
RepeatedField.
// Newer C# versions with collection initialization syntax.StructuredSnippetAsset asset = new StructuredSnippetAsset()
{
Values = { "foo", "bar" }
};
// Older C# versions.
asset.Values.AddRange( {"foo", "bar"} );
—
Reply to this email directly, view it on GitHub
https://github.com/googleads/google-ads-dotnet/issues/389#issuecomment-1122598619,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABTGK4W6CYIRT7TCNF36ULTVJKCZLANCNFSM5U7OGY2Q
.
You are receiving this because you authored the thread.Message ID:
@.***>


coronal image data adjustments

@kkutten1 We need to discuss the coronal data I am assuming you uploaded. It needs a resolution hierarchy and a window, among other things. Topic for lunch tomorrow?
I would not upload any coronal annotations until we get this fixed.

OK I'll see you tomorrow.

I have uploaded the coronal images to the ARACoronal tokens listed here.  You can close this issue.


security: Gain root access in any machine which is running redis

Description:
According to https://redis.io/topics/security, The redis product is designed to be totally insecure if exposed to the outside world. Our systems are exposed it to the outside world through the default redis port

Gain telnet:
You can gain a telnet access by:

Gain root ssh access
You can gain a root access by adding your ssh public key to the redis memory. You can use the following script to test it
https://github.com/Avinash-acid/Redis-Server-Exploit

We no longer use redis, can u validate that this is not possible anymore


WIP: enable section indexes by default, allow deeper nesting in sidenav

refactor sidenav to use recursion
add option to allow for deeper sidenav nesting
doc reorganization
breaking change version bump

TODO:

[ ] consider: add back in feature where an active page does not display as a clickable link in the sidenav
[ ] review documentation that refers to ^
[ ] unit tests
[ ] fix or write up TODO issue for the bug where there is an empty ul element
[ ] consider: prefix config.extra variables with mkdocs-terminal

[ ] consider: do they need to be caps?

[ ] update docs so that "navigation.side.indexes" is standard
[ ] remove references to "navigation.side.indexes" in code

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.
Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, etc.
If the UI is being changed, please provide before/after screenshots.

References

Include any links supporting this change such as a:

GitHub Issue/PR number addressed or fixed
Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If there are existing unit and/or integration test suites, tests should be added for new functionality and existing tests should complete without errors.
Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.
Also include details of the environment this PR was developed in (language/platform/browser version).

[ ] This change adds test coverage for new/changed/fixed functionality

Checklist

[ ] I have added documentation for new/changed functionality in this PR or in mkdocs-terminal/documentation
[ ] All active GitHub checks for tests, formatting, and security are passing

relates to #137


Stave doesn't render dead-center

Summary
While the widget is behaving as expected (the bottom staff line renders at (0, 0) in the coordinate system), this causes issues when centering the widget within a container. Rendering dead-center would be useful for displaying figures for music theory education.
Example of the issue:

Example code:
@override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('Simple Sheet Music Example')),
      body: Center(
        child: Container(
          decoration: BoxDecoration(border: Border.all()),
          width: 200.0,
          height: 200.0,
          child: Align(
            alignment: Alignment.center,
            child: SimpleSheetMusic(
              initialClef: initialClef,
              height: 100,
              width: 100,
              staffs: [staff],
            ),
          ),
        ),
      ),
    );
  }
}

Update: I was able to "fix" this problem by changing the staffLineCenterY in built_staff.dart:
final measureOnCanvas = measure.placeOnCanvas(
    staffLineCenterY + staffLineCenterY / 2),
    currentX,
);

Not sure if this would break any other intended use cases.

I'm concerned that if the uppermost part were used as the origin then the staff would be off-center inside of its container. Are there any benefits conferred by the approach that I'm not seeing?
Here's a picture to go along with the code example that I modified:

I was a little mistaken. I thought it would cause problems with rendering multi-stage Stave, but your method will work. I will put out a revised version in a few more days.


Bump boringSSL version

This is the first step in an attempt to update lsquic.cr

The BoringSSL version depends on the LSQUIC version.
For example for LSQUIC version 2.23.1:

The LSQUIC commit is https://github.com/litespeedtech/lsquic/commit/f198a02df8d5629c9f40fff726081aeea0f1681c named Release 2.23.1. All LSQUIC release commits follow this pattern.
The BoringSSL commit is a2278d4d2cabe73f6663e3299ea7808edfa306b9, this can be found in the LSQUIC Dockerfile or LSQUIC Readme (note the LSQUIC commit in the links).

LSQUIC and BoringSSL commit ids must be updated at the same time.
For example to update to the latest LSQUIC Release 3.0.1:

Find the LSQUIC release commit: https://github.com/litespeedtech/lsquic/commit/d549a33b218c4cb5f5bc70248c0dd45e5a05db09
Find the corresponding BoringSSL commit in the LSQUIC Dockerfile: a2278d4d2cabe73f6663e3299ea7808edfa306b9

The result would be:
#!/bin/sh

BORINGSSL_COMMIT=a2278d4d2cabe73f6663e3299ea7808edfa306b9
   LSQUIC_COMMIT=d549a33b218c4cb5f5bc70248c0dd45e5a05db09

[...]


ENH: Increase Review module classes' code coverage

Increase Review module classes' code coverage:

Exercise the basic object methods using the
ITK_EXERCISE_BASIC_OBJECT_METHODS macro.
Test the Set/Get methods using the ITK_TEST_SET_GET_VALUE macro.
Test the boolean ivars using the ITK_TEST_SET_GET_BOOLEAN macro.

PR Checklist

[X] No API changes were made (or the changes have been approved)
[X] No major design changes were made (or the changes have been approved)

To be rebased on master once PR #2652 gets merged.

The coverage increase is not meant to be exhaustive. Further increases can be made in a separate PR.

/azp run ITK.macOS

A note on the CI checks: they do not test the Review module. I have not tested the PR locally. So let's hope one of the bots submitting to CDash does test the Review module.

I rebased and pushed to your branch. Also, I am doing a local build with legacy removed and review module on.

The force-push fixes unused variable warning, and wrong class name test failure. Both were uncovered by local testing.

If the CI comes back green, this is good to merge. I will do so, unless someone raises an objection or beats me to it 😄

The last force-push just rebases on current master.

:100: Thanks Dženan.

Looks like this introduced a regression failure in itkLabelGeometryImageFilterTest:
https://open.cdash.org/viewBuildError.php?onlydeltap&buildid=7354628
In file included from /home/kitware/DashboardsITK/Modules/Nonunit/Review/test/itkLabelGeometryImageFilterTest.cxx:26:0:
/home/kitware/Dashboards/src/ITK/Modules/Nonunit/Review/test/itkLabelGeometryImageFilterTest.cxx: In function 'int LabelGeometryImageFilterTest(std::__cxx11::string, std::__cxx11::string, std::__cxx11::string, std::__cxx11::string, std::__cxx11::string)':
/home/kitware/DashboardsITK/Modules/Core/TestKernel/include/itkTestingMacros.h:69:51: error: 'Superclass' has not been declared
   std::cout << "Name of Superclass = " << object->Superclass::GetNameOfClass() << std::endl;                           \
                                                   ^
[CTest: warning matched] /home/kitware/DashboardsITK/Modules/Core/TestKernel/include/itkTestingMacros.h:69:51: note: in definition of macro 'ITK_EXERCISE_BASIC_OBJECT_METHODS'
   std::cout << "Name of Superclass = " << object->Superclass::GetNameOfClass() << std::endl;                           \
                                                   ^~~~~~~~~~
/home/kitware/DashboardsITK/Modules/Core/TestKernel/include/itkTestingMacros.h:79:28: error: 'Superclass' has not been declared
   if (!std::strcmp(object->Superclass::GetNameOfClass(), #SuperclassName))                                             \
                            ^
[CTest: warning matched] /home/kitware/DashboardsITK/Modules/Core/TestKernel/include/itkTestingMacros.h:79:28: note: in definition of macro 'ITK_EXERCISE_BASIC_OBJECT_METHODS'
   if (!std::strcmp(object->Superclass::GetNameOfClass(), #SuperclassName))                                             \
                            ^~~~~~~~~~

I tried reproducing the issue locally but the test is passing on my Windows 10+VS 2019. The CDash Windows ryzenator site did not complain about it either; only Linux and Mac complain about it.
I was hesitant to submit a patch set adding an #include itkImageToImageFilter.h as a fix, since it should be already included when calling #include itkLabelGeometryImageFilter.h, so I'm wondering whether anyone has a better guess.

We already encountered this before:
https://github.com/InsightSoftwareConsortium/ITK/pull/2319
I think I was even able to reproduce it locally when I had Ubuntu 18.04. I
recently switched to 20.04.
On Thu, Jul 22, 2021 at 10:58 PM Jon Haitz Legarreta Gorroño <
@.***> wrote:

Looks like this introduced a regression failure in
itkLabelGeometryImageFilterTest:
https://open.cdash.org/viewBuildError.php?onlydeltap&buildid=7354628
In file included from /home/kitware/DashboardsITK/Modules/Nonunit/Review/test/itkLabelGeometryImageFilterTest.cxx:26:0:
/home/kitware/Dashboards/src/ITK/Modules/Nonunit/Review/test/itkLabelGeometryImageFilterTest.cxx: In function 'int LabelGeometryImageFilterTest(std::__cxx11::string, std::__cxx11::string, std::__cxx11::string, std::__cxx11::string, std::__cxx11::string)':
/home/kitware/DashboardsITK/Modules/Core/TestKernel/include/itkTestingMacros.h:69:51: error: 'Superclass' has not been declared
std::cout << "Name of Superclass = " << object->Superclass::GetNameOfClass() << std::endl;
^
[CTest: warning matched] /home/kitware/DashboardsITK/Modules/Core/TestKernel/include/itkTestingMacros.h:69:51: note: in definition of macro 'ITK_EXERCISE_BASIC_OBJECT_METHODS'
std::cout << "Name of Superclass = " << object->Superclass::GetNameOfClass() << std::endl;
^~~~~~~~~~
/home/kitware/DashboardsITK/Modules/Core/TestKernel/include/itkTestingMacros.h:79:28: error: 'Superclass' has not been declared
if (!std::strcmp(object->Superclass::GetNameOfClass(), #SuperclassName))
^
[CTest: warning matched] /home/kitware/DashboardsITK/Modules/Core/TestKernel/include/itkTestingMacros.h:79:28: note: in definition of macro 'ITK_EXERCISE_BASIC_OBJECT_METHODS'
if (!std::strcmp(object->Superclass::GetNameOfClass(), #SuperclassName))
^~~~~~~~~~
I tried reproducing the issue locally but the test is passing on my
Windows 10+VS 2019. The CDash Windows ryzenator site did not complain
about it either; only Linux and Mac complain about it.
I was hesitant to submit a patch set adding an #include
itkImageToImageFilter.h as a fix, since it should be already included
when calling #include itkLabelGeometryImageFilter.h, so I'm wondering
whether anyone has a better guess.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/InsightSoftwareConsortium/ITK/pull/2653#issuecomment-885364783,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANVQ6NJNPFI4D7ALYLFE2LTZDLDRANCNFSM5ASQRDIA
.

Because Superclass is an alias rather than the actual name of the base class, that could be causing trouble for some compilers.  For example, often we have to use the typename keyword to refer to an alias defined with using within a class so that the compiler knows that the alias is a type rather than a data member or member function.  So, instead of
object->Superclass::GetNameOfClass()

I might have written
static_cast<const typename decltype(*object)::Superclass *>(object)->GetNameOfClass()

with the explicit typename (and perhaps without the const if we are guaranteed that object won't be const).

@Leengit thanks for chiming in and for the explanation :+1:. I do not have a Linux machine on which I would be at ease developing ITK at the moment, so I cannot check whether your proposal would work. So it would be great if someone could check it and submit a PR.

I've tried my own suggestion static_cast<const typename decltype(*object)::Superclass *>(object)->GetNameOfClass() on my Linux machine with gcc-10.3.0 and it does not work.  The issue appears to be that decltype(*object) is not well defined during the declaration of object; for example when an (inline) method is defined within a class declaration rather than as a separate definition, which is quite common for ITK's templated classes.

@Leengit thanks for giving it a try. Unfortunately, I haven't got an alternative proposal. There is still something elusive in the issue to me given my previous comment about it not being present in virtually all tests.

I created #2676 to track this.


Adds a link to the Chris Celio style guide

Type of change: documentation

Impact: no functional change
Release Notes

* What other style suggestions do people have?

I think a lot of the variable naming comes down to "programmers" vs "hardware designers", i.e., do you name things like people would in Scala or as it is common in Verilog/VHDL?
Afaik Scala code normally does not use snake_case for example.

This is just a question of whether to link to Chris's document
His document is top search result on google.
There are really not any good alternatives
Chris is willing to accept PR's that improve it, or we could fork his and maintain our own
People are asking for style guide on SO and elsewhere.
I think this is worth merging now while noting that more work should be done

I'd prefer not to advocate a style guide that doesn't yet have consensus across the community, just so we can tick a box saying "we have this". I think releasing (and more importantly, expecting people to follow) a style guide that is going to see significant flux right after is not a great idea, since the whole point of a style guide is stability and consistency.
Like, this is a starting point to discuss on, and we can prioritize that discussion, but I think this is something that needs to be done as right as we can.
Also, wrt this being the top result on Google: the chisel2 cheatsheet also used to be the top result on Google, well into the chisel3 era. If this document truly reflects the currently dominant style (if one even exists) and best practices, then sure, but I'm not sure if that's the case.

* What other style suggestions do people have?

I think a lot of the variable naming comes down to "programmers" vs "hardware designers", i.e., do you name things like people would in Scala or as it is common in Verilog/VHDL?
Afaik Scala code normally does not use snake_case for example.

Chisel is for describing hardware designs; although the host language style guide can provide some guidance, users shouldn't be afraid to write code in a manner that improves understandability.
As such, though perhaps it betrays my C/C++ and Verilog origins, I have found camelCase does a poor job of providing visual distinctions between prefixes and suffixes which are commonly required for describing hardware.
In particular, this shows up in hardware's need to describe temporal behaviors within the code: across pipeline stages, the differing update semantics of Reg vs Wire, multi-cycle interface contracts of some I/Os, and more.
If you are lucky, you can write your RTL in a functional manner that lines up closely with Scala style. But for other modules, a more structural style with explicit pipelining lends itself closer to more C/Verilog-like naming conventions. Skimming through rocket-chip, I've found it changes style as needed depending upon how best to describe the Module in question.

I've gone back and forth on snake vs camel throughout my Chisel career and see merits to both. To add to @ccelio's snake_case pros, having snake_case for hardware values and camelCase for software values/functions can aid in differentiating between the two. OTOH, one relatively big pro for camelCase is that it is much easier to correlate emitted bundle hierarchies with their source scala if you can reliably use _ as a hierarchy delimiter (e.g. someReally_longNamed_bundleWith_lotsOf_hierarchy vs some_really_long_named_bundle_with_lots_of_hierarchy).

Dev meeting conclusion: we'd prefer to just point to the Scala style guide. If anyone feels differently we can re-open.


Syncserver compilation failed

Issue description
There is a problem when Nixos compile the serversyncstorage from mozilla. The problem is that syncserver use method .app of WSGIProxy2 but this method isn't available before 0.3
I will start to modified requirements.txt of mozservices and when it will be release, it would be great to change the version in :
https://github.com/NixOS/nixpkgs/blob/7ebb82e04f17d96313f1d60c748f32a7f7bee9f6/pkgs/top-level/python-packages.nix#L10496
Steps to reproduce
Enable syncserver in Nixos
You will have this output :
https://hydra.nixos.org/build/72124841/log
Technical details
 - system: `"x86_64-linux"`
 - host os: `Linux 4.14.32, NixOS, 18.03.131807.489a14add9a (Impala)`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.0`
 - channels(root): `"nixos-18.03.131807.489a14add9a"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`

I will start to modified requirements.txt of mozservices and when it will be release, it would be grate to change the version in :

So you're suggesting to wait until a new version of https://github.com/mozilla-services/mozservices is released?
How will this affect the use of WSGIProxy2 instead of WSGIProxy? The package requiring the latter is https://github.com/mozilla-services/server-syncstorage.

I still don't understand you. Please try to explain in French or just open a PR as soon as you have a fix.

I don't understand him either, but this is probably what he aims to achieve.

I don't understand him either, but this is probably what he aims to achieve.

However, it won't be enough because WSGIProxy also needs to be upgraded in https://github.com/mozilla-services/server-syncstorage/blob/149496f09b0ff8ba21cec1d107d2435cb1f584f7/setup.py#L11
@Vskilet Any progress?

Sorry guys for my bad explanation.
@t184256 Yes that's it.
@dotlambda Maybe. I'm a beginner in python development. I need to progress a bit

bump?
@Vskilet

I've not finish to do this ... but I'm on it

Any updates?

It's seems that my modifications aren't sufficient ... I don't known what we can do on this.


Controlling by RFID

Hi Micz,
yesterday and today  I installed twice your system with jessie to a new sd-card.
Now I can start a song by rfid without problems.
But when I prepare the rfid_trigger_play.sh to control
pause, shutdown, next etc with rfid
it does not respond.
With stretch and without webinterface everthing works well. So I am not sure where the problem is.
Best regards
Ulli

Hi Ulli,
just to make sure I understand the issue. You have added the IDs to this script:
https://github.com/MiczFlor/RPi-Jukebox-RFID/blob/master/scripts/rfid_trigger_play.sh.sample
Between line 31 and 40 you can add IDs to skip next previous, shutdown, etc.
You have to have the IDs within the "" characters (that is my first thought to find the problem).

Hi Micz,
the problem is solved.
I made two faults. First in the app the 50% Volume was simply to silent and my RFID Reader didn‘t work. He beeped but I had a wrong configuration.
Today I installed everything again and it works. Great job Micz, thanks a lot

Is this feature documented somewhere @MiczFlor ?
I think thats very useful as i was exactly for a function like that to control the box without doing the GPIO button stuff. For me this works pretty well.


Health-Check: Add network arguments to check

Provide an optional arg to health-check to filter by network, such as health-check mainnet (or health-check -n mainnet to maintain the same structure as make). It's only a minor nuisance though to see errors being thrown for networks you're not interested in, so it would be a low priority enhancement at best.
There was a monero-wallet-rpc that was really slow for some reason. The health check stalled for over 90 seconds multiple times then before returning connection error: Connection reset by peer (os error 104). Issue disappeared when I restarted monero-wallet-rpc.
Suggested by @Lederstrumpf

@Lederstrumpf is there a possibility that the monero wallet rpc was occupied by another RPC call in the meantime?


Bump up cli version to trigger staging cli release

Issue #, if available:
Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve


Build of Secvisogram failed

The GH pages version looks interesting:

I guess the problem is that it expects the to be directly at the domain and doesn't have a /path/ in between...

I was able to fix the missing translation part.

Split into two tickets. Translation issue solved for now...


Fix Typo

cc @denelon
Microsoft Reviewers: Open in CodeFlow

@mdanish-kh
There was a mistake in "greedy" :)

[Policy] Approve


Hi, I cannot find anything in the security advisory section of this project.

No, I'm not aware of such CVEs.


Use sbt-release plugin

Codecov Report

:exclamation: No coverage uploaded for pull request head (sbt-release-plugin@2c163ef).

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4ca66...2c163ef. Read the comment docs.


[Automation] Generate Fluent Lite from databricks#package-2023-05-01

[Automation] Generate Fluent Lite from databricks#package-2023-05-01

/azp run java - databricks - mgmt - tests

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-resourcemanager-databricks

/azp run java - databricks - mgmt - tests

/azp run java - databricks - mgmt - tests


For real time tracking

@ifzhang Can I use this BytrTrack for real-time vehicle tracking from Camera or WebCam

Same question.


Unit Converter using python GUI (tkinter)

@Siddhesh4501
Your PR has been successfully merged Thank you so much for your valuable contribution. Do give a follow if it helped you and star the repo and check other repo too for more contribution. Keep hacking