Postgres Scalar: Only password field works on TriggerAuthentication

#947  Expected Behavior
All other fields like host, database, username, ssl to work on reference to TriggerAuthentication object
Actual Behavior
Only password works now with TriggerAuthentication. Others produce the below error:
{"level":"error","ts":1603452295.4631653,"logger":"controllers.ScaledObject","msg":"Failed to ensure HPA is correctly created for ScaledObject","ScaledObject.Namespace":"minion","ScaledObject.Name":"aggregation-cache-feeder-scaled","error":"error getting scaler for trigger #0: error parsing postgreSQL metadata: no  host given","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128\ngithub.com/kedacore/keda/controllers.(*ScaledObjectReconciler).Reconcile\n\t/workspace/controllers/scaledobject_controller.go:141\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:235\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:209\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:188\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\t/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/util/wait/wait.go:155\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\t/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/util/wait/wait.go:156\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/util/wait/wait.go:133\nk8s.io/apimachinery/pkg/util/wait.Until\n\t/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/util/wait/wait.go:90"}
{"level":"error","ts":1603452295.4708138,"logger":"controller","msg":"Reconciler error","reconcilerGroup":"keda.sh","reconcilerKind":"ScaledObject","controller":"scaledobject","name":"aggregation-cache-feeder-scaled","namespace":"minion","error":"error getting scaler for trigger #0: error parsing postgreSQL metadata: no  host given","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:237\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:209\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:188\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\t/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/util/wait/wait.go:155\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\t/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/util/wait/wait.go:156\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/util/wait/wait.go:133\nk8s.io/apimachinery/pkg/util/wait.Until\n\t/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/util/wait/wait.go:90"}

Steps to Reproduce the Problem

Create a postgres scalar with authenticationRef.
Define parameter other than password on the TriggerAuthentication using either secretTargetRef/env
Check operator logs for error.

Specifications

KEDA Version: v2
Platform & Version: AKS
Kubernetes Version: 1.17
Scaler(s): Postgres

Hello,
i can confirm the behavior with keda 2.2:
apiVersion: keda.sh/v1alpha1
kind: TriggerAuthentication
metadata:
  name: trigger-auth-postgres
spec:
  secretTargetRef:
    - parameter: userName
      name: app-user-creds-secret
      key: APP_USER
    - parameter: password
      name: app-user-creds-secret
      key: APP_PASSWORD
    - parameter: host
      name: app-user-creds-secret
      key: APP_DB_HOST
    - parameter: dbName
      name: app-user-creds-secret
      key: APP_PA_DB_NAME
---
apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  name: app-batch-send-email-keda
spec:
  scaleTargetRef:
    name: app-batch-send-email
  pollingInterval: 30
  cooldownPeriod: 300
  minReplicaCount: 0
  maxReplicaCount: 1
  triggers:
  - type: postgresql
    metadata:
      port: "5432"
      sslmode: disable
      query: "select count(1) from table where BLAHBLAHBLAH OMITTED QUERY"
      targetQueryValue: "1"
    authenticationRef:
      name: trigger-auth-postgres

Error reported is:
2021-08-02T14:52:48.103Z ERROR controllers.ScaledObject Failed to ensure HPA is correctly created for ScaledObject {"ScaledObject.Namespace": "ke45c", "ScaledObject.Name": "app-batch-send-email-keda", "error": "error getting scaler for trigger #0: error parsing postgreSQL metadata: no host given"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.5/pkg/internal/controller/controller.go:244
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.5/pkg/internal/controller/controller.go:218
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.5/pkg/internal/controller/controller.go:197
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1
/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:155
k8s.io/apimachinery/pkg/util/wait.BackoffUntil
/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:156
k8s.io/apimachinery/pkg/util/wait.JitterUntil
/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:133
k8s.io/apimachinery/pkg/util/wait.Until
/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:90

We'd like to centralize parameters on a single secret, so we don't require to update several files when DB details is changed. Based on docs:
Every parameter you define in TriggerAuthentication definition does not need to be included in the metadata of the trigger for your ScaledObject definition.

i was supposed to move parameter from ScaledObject to TriggerAuthentication and have it parsed, but looks like is not true.
Same problem also with artemis amq plugin.

Has anyone managed to make it work?
I just encountered the same problem on keda 2.4.0 with MySQL scaler.
apiVersion: keda.sh/v1alpha1
kind: TriggerAuthentication
metadata:
  name: keda-trigger-auth-mysql-secret
  namespace: develop
spec:
  env:
    - parameter: host
      name: DB_HOST
    - parameter: port
      name: DB_PORT
    - parameter: dbName
      name: DB_SCHEMA
    - parameter: username
      name: DB_USERNAME
    - parameter: password
      name: DB_PASSWORD
---
apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  name: worker-scaler
  namespace: develop
spec:
  maxReplicaCount: 1
  scaleTargetRef:
    name: publisher-backend-worker
  triggers:
    - type: mysql
      metadata:
        queryValue: "4"
        query: "SELECT COUNT(*) FROM table WHERE TRUE"
      authenticationRef:
        name: keda-trigger-auth-mysql-secret

I presume the workload have the specified environment variables?

I presume the workload have the specified environment variables?

Yea, of course. I have also tried the secretTargetRef way as @remixtj mentioned because I'm mapping environment variables from secret initially which also doesn't work.
The only way I was able to make it work for MySQL scaler is to add a new key to the Secret for connectionString which basically duplicates and combines other variables that are already present in the Secret so it's not great. I have hundreds of namespaced deployments of the same app so creating and maintaining all those extra connection strings is a big chore.

Ok, I just wanted to verify - Thanks!
We will definitely have to fix this then, it is not maintainable to use that workaround for sure.
Is this something you are wanting to look in to @JorTurFer?

I have just taken a look at this and is truth, we are not taking more than password or connectionString from TriggerAuthentication, rest of parameters must be provided from trigger metadata. It's the same behavior for MySQL, Postgres, MS SQL and MongoDB.
Support getting parameters from TriggerAuthentication shouldn't be a problem, but is it really necessary? I mean, could be better if we support (for example) host and hostFromEnv like we are doing with password and passwordFromEnv?
Maybe we can support all the case, get value from trigger metadata, from environment variable without TriggerAuthentication and from TriggerAuthentication. We should maintain password and connectionString parameters as they are right now (both contain secrets), but we can extend others.
WDYT?

We should no longer use FromEnv for new things and rely on TriggerAuthentication since it allows you to pull it from various secret sources (secret, env var, HashiCorp vault, and more later on)
I will open issues to track these changes later today.

So basically we have to support getting the values from trigger metadata and trigger auth, right?
You can assign me directly in the issues, I will do them :)

So basically we have to support getting the values from trigger metadata and trigger auth, right?
In terms of trigger metadata we should not add FromEnvs but other than that, yes.

I will add to them today :)

All the PR are opened :)

I think that this can be closed because all the related issues are closed


GoogleScraper.scraping.SeleniumMisconfigurationError: Aborting due to no available selenium webdrive

Hi Nikolai,
in my Ubuntu 14.04.01 Server Edition I installed:
GoogleScraper
chromium-chromedriver - WebDriver driver for the Chromium Browser
chromium-chromedriver-dbg - chromium-chromedriver debug symbols
I also downloaded from http://chromedriver.storage.googleapis.com/index.html?path=2.13/ and installed chromedriver.
As suggested https://code.google.com/p/selenium/wiki/ChromeDriver, I symlinked with /usr/bin:
:/usr/bin$ ls -lah chromedriver
lrwxrwxrwx 1 root root 24 gen 21 12:06 chromedriver -> /home/marco/chromedriver
But when running the direct command line (https://github.com/NikolaiT/GoogleScraper):
marco@pc:~/crawlscrape$ GoogleScraper --keyword-file keywords.txt --search-engine bing --num-pages-for-keyword 3 --scrapemethod selenium
2015-01-21 15:07:45,339 - GoogleScraper - INFO - 0 cache files found in .scrapecache/
2015-01-21 15:07:45,339 - GoogleScraper - INFO - 0/11 keywords have been cached and are ready to get parsed. 11 remain to get scraped.
2015-01-21 15:07:45,624 - GoogleScraper - INFO - Going to scrape 10 keywords with 1 proxies by using 1 threads.
2015-01-21 15:07:45,624 - GoogleScraper - INFO - [+] SelScrape[localhost][search-type:normal][http://www.bing.com/search?] using search engine "bing". Num keywords=10, num pages for keyword=3
2015-01-21 15:07:45,640 - GoogleScraper - ERROR - Message: ChromeDriver executable needs to be available in the path. Please download from http://chromedriver.storage.googleapis.com/index.html and read up at http://code.google.com/p/selenium/wiki/ChromeDriver
Exception in thread Thread-2:
Traceback (most recent call last):
File "/usr/lib/python3.4/threading.py", line 920, in _bootstrap_inner
self.run()
File "/usr/local/lib/python3.4/dist-packages/GoogleScraper/selenium_mode.py", line 419, in run
raise SeleniumMisconfigurationError('Aborting due to no available selenium webdriver.')
GoogleScraper.scraping.SeleniumMisconfigurationError: Aborting due to no available selenium webdriver.
What do I have to do in order to make it work?
Looking forward to your help.
Marco

After removing and re-installing the driver:
marco@pc:/usr/bin$ ls -lh chromedriver
lrwxrwxrwx 1 root root 24 gen 26 10:55 chromedriver -> /home/marco/chromedriver
marco@pc:~/crawlscrape$ chromedriver –version
ChromeDriver 2.13.307649 (bf55b442bb6b5c923249dd7870d6a107678bfbb6)
it seems now correctly installed
But when trying to execute the command from the command line:
marco@pc:~/crawlscrape$ GoogleScraper –keyword-file keywords.txt –search-engine bing –num-pages-for-keyword 3 –scrapemethod selenium
2015-01-26 10:58:50,071 – GoogleScraper – INFO – 0 cache files found in .scrapecache/
2015-01-26 10:58:50,071 – GoogleScraper – INFO – 0/11 keywords have been cached and are ready to get parsed. 11 remain to get scraped.
2015-01-26 10:58:50,335 – GoogleScraper – INFO – Going to scrape 10 keywords with 1 proxies by using 1 threads.
2015-01-26 10:58:50,335 – GoogleScraper – INFO – [+] SelScrape[localhost][search-type:normal][http://www.bing.com/search?] using search engine “bing”. Num keywords=10, num pages for keyword=3
2015-01-26 10:59:51,404 – GoogleScraper – ERROR – Message: unknown error: Chrome failed to start: exited abnormally
(Driver info: chromedriver=2.13.307649 (bf55b442bb6b5c923249dd7870d6a107678bfbb6),platform=Linux 3.13.0-32-generic x86_64)
Exception in thread Thread-2:
Traceback (most recent call last):
File “/usr/lib/python3.4/threading.py”, line 920, in _bootstrap_inner
self.run()
File “/usr/local/lib/python3.4/dist-packages/GoogleScraper/selenium_mode.py”, line 419, in run
raise SeleniumMisconfigurationError(‘Aborting due to no available selenium webdriver.’)
GoogleScraper.scraping.SeleniumMisconfigurationError: Aborting due to no available selenium webdriver.
What do I have to do now?
Looking forward to your kind and patient help.
Marco

I experience the same problem with multiple sequential queries: it works OK at the beginning but after a certain number of queries it raises SeleniumMisconfigurationError(‘Aborting due to no available selenium webdriver.’)

any luck ?

having the same problem, would be great to know a fix

short term solution - close re-open python...


WebSocket server header keys should have correct capitalization

Upon trying to connect to rippled from several different websocket clients, I noticed that some clients refused to connect to rippled while having no problem connecting to other servers. Upon looking at the HTTP headers, the reason became clear: rippled is using a version of websocketpp that uses tolower on all the header keys.
0x0000:  4c72 b9b1 e460 108c cf28 fe40 0800 4500<EMAIL_ADDRESS>0x0010:  00d3 fcf1 4000 2b06 4d22 1717 882e b01f<EMAIL_ADDRESS>0x0020:  b5ac c821 de71 ecf1 2c63 8a25 b20b 8018  ...!.q..,c.%....
0x0030:  003d 210a 0000 0101 080a 2b66 d093 7274  .=!.......+f..rt
0x0040:  fa40 4854 5450 2f31 2e31 2031 3031 2053<EMAIL_ADDRESS>0x0050:  7769 7463 6869 6e67 2050 726f 746f 636f  witching.Protoco
0x0060:  6c73 0d0a 636f 6e6e 6563 7469 6f6e 3a20  ls..connection:.
0x0070:  5570 6772 6164 650d 0a73 6563 2d77 6562  Upgrade..sec-web
0x0080:  736f 636b 6574 2d61 6363 6570 743a 2032  socket-accept:.2
0x0090:  6b45 5348 4145 7662 3752 5055 6f33 354b  kESHAEvb7RPUo35K
0x00a0:  6644 6b55 7757 4547 756f 3d0d 0a73 6572  fDkUwWEGuo=..ser
0x00b0:  7665 723a 2057 6562 536f 636b 6574 2b2b  ver:.WebSocket++
0x00c0:  2f30 2e32 2e31 6465 760d 0a75 7067 7261  /0.2.1dev..upgra
0x00d0:  6465 3a20 7765 6273 6f63 6b65 740d 0a0d  de:.websocket...
If I understand rfc6455 page 18 correctly (http://tools.ietf.org/html/rfc6455#section-4.1), the HTTP header keys require correct capitalzation (Upgrade, not upgrade; Sec-WebSocket-Accept, not sec-websocket-accept; etc...) but the values are case-insensitive (i.e. in the server's response to the client's opening handshake, Upgrade: websocket is just as valid as Upgrade: wEbsoCKet).
Many websocket clients, nonetheless, do not care about the key capitalization (i.e. node ws/wscat/chrome/safari) and so will not cause problems. However, other websocket clients (i.e. some versions of websocketpp) will.

I don't think we're going to change this - feel free to reopen with more discussion...

Obsolete, our websocket implementation is rewritten.


update on 1000 genomes

@mamtagiri : Thanks for your contribution! The author(s) have been notified to review your proposed change. @peterclu

@cjgronlund. Can you review this PR? I can't locate the author. Thanks.

@JasonWHowell, can you approve this PR, or advise on whom to ask? Thanks.

@jborsecnik the author of the page is @samuel100 for now (see docfx.json or the HTML docs page)
#reassign:@samuel100
I don't know about sharing a SAS token in Docs. The blob doesn't allow for anonymous access?

@jborsecnik the public repo is way behind the private repo. Do you know if the repo-sync is down? I changed this page to fix the author 8 days ago, and its not reflected in azure-docs yet.

@jborsecnik never mind - it could be the contributor's fork is behind, since the azure-docs file is updated. https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/open-datasets/dataset-1000-genomes.md

#sign-off

@samuel100: I'm sorry - only the author of this article, @peterclu, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Update access-permissions-on-github.md

Corrected some typos.

Why:

What's being changed:

Check off the following:

[ ] All of the tests are passing.
[ ] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[ ] For content changes, I have reviewed the localization checklist
[ ] For content changes, I have reviewed the Content style guide for GitHub Docs.

https://smee.io/sBViUEhTHbNK7YMD

Thanks for opening a PR @reetika123987! In this sentence, members is plural, so it doesn't need an apostrophe.
I'm going to close this PR, but if you're looking for a way to contribute, there are quite a few available issues with the help wanted label 💖


Update Pekko Stream Circe to 1.1.0

(cherry picked from commit eb3ae26572c0659993af51d11ba71c176a81d504)

@pjfanning Do you mind reviewing this seeing as its a critical bug?


 Need clear instructions on config file. I have added api keys, i have renamed config to .mosint.yaml. i have moved config file to home directory.

I was doing steps incorrectly apologies.


i need help

can anyone show me how to update to acme v2 i have my own evilginx version but i can not update it to acme v2.
Please help!!!!

send me a mail and I will solve your issues<EMAIL_ADDRESS>

I have working evilginx version and gmail phishlet.
Contact me<EMAIL_ADDRESS>

I don't know id this will help but trying using the new version of evilginx


Upgrade linux CI from trusty to xenial

I'm going to upgrade all the machines, deploy the changes in this branch, and we can merge when the process is done.
I have successfully completed builds on both a new linux builder and a new linux cross builder that were upgraded from trusty.

This change is

[ ] servo-linux1
[ ] servo-linux2
[ ] servo-linux3
[ ] servo-linux4
[ ] servo-linux5
[ ] servo-linux6
[ ] servo-linux-cross1
[ ] servo-linux-cross2
[ ] servo-linux-cross3

Current status: all common update steps performed on all machines; highstate in progress.

I just noticed all of the linux bustage on travis, which is worrying!

Based on https://www.reddit.com/r/saltstack/comments/ae85xg/installingupdating_python_module/, it may be possible to downgrade the version of pip on TravisCI builds to avoid this error:
----------
          ID: buildbot-slave-dependencies
    Function: pip.installed
      Result: False
     Comment: An exception occurred in this state: Traceback (most recent call last):
                File "/usr/lib/python2.7/dist-packages/salt/state.py", line 1905, in call
                  **cdata['kwargs'])
                File "/usr/lib/python2.7/dist-packages/salt/loader.py", line 1830, in wrapper
                  return f(*args, **kwargs)
                File "/usr/lib/python2.7/dist-packages/salt/states/pip_state.py", line 681, in installed
                  out = _check_pkg_version_format(pkg)
                File "/usr/lib/python2.7/dist-packages/salt/states/pip_state.py", line 147, in _check_pkg_version_format
                  install_req = InstallRequirement.from_line(pkg)
              AttributeError: type object 'InstallRequirement' has no attribute 'from_line'

That leaves these PPA issues, which don't appear on our builders because the files are already present during the upgrade:
----------
          ID: /etc/apt/sources.list.d/openjdk-r-ppa-trusty.list
    Function: file.exists
      Result: False
     Comment: Specified path /etc/apt/sources.list.d/openjdk-r-ppa-trusty.list does not exist
     Started: 15:50:23.105446
    Duration: 0.825 ms
     Changes:
----------
          ID: cmake-ppa
    Function: pkgrepo.managed
      Result: False
     Comment: Failed to configure repo 'cmake-ppa': Unable to add PPA 'george-edison55/cmake-3.x'. '[u'apt-add-repository', u'-y', u'ppa:george-edison55/cmake-3.x']' exited with status 1: 'gpg: keyring `/tmp/tmpuj417wiv/secring.gpg' created
              gpg: keyring `/tmp/tmpuj417wiv/pubring.gpg' created
              gpg: requesting key 828AB726 from hkp server keyserver.ubuntu.com
              gpg: no valid OpenPGP data found.
              gpg: Total number processed: 0
              gpg: keyserver communications error: keyserver helper general error
              gpg: keyserver communications error: unknown pubkey algorithm
              gpg: keyserver receive failed: unknown pubkey algorithm'
----------
          ID: ffmpeg-ppa
    Function: pkgrepo.managed
      Result: False
     Comment: Failed to configure repo 'ffmpeg-ppa': Unable to add PPA 'jonathonf/ffmpeg-3'. '[u'apt-add-repository', u'-y', u'ppa:jonathonf/ffmpeg-3']' exited with status 1: 'gpg: keyring `/tmp/tmpwd7blizj/secring.gpg' created
              gpg: keyring `/tmp/tmpwd7blizj/pubring.gpg' created
              gpg: requesting key F06FC659 from hkp server keyserver.ubuntu.com
              gpg: no valid OpenPGP data found.
              gpg: Total number processed: 0
              gpg: keyserver communications error: keyserver helper general error
              gpg: keyserver communications error: unknown pubkey algorithm
              gpg: keyserver receive failed: unknown pubkey algorithm'
----------
          ID: ttf-mscorefonts-installer
    Function: debconf.set
      Result: False
     Comment: State 'debconf.set' was not found in SLS 'servo-build-dependencies'
              Reason: 'debconf.set' is not available.
     Changes:

It's greeeeeeeeeeeen!

r? @Manishearth

The salt upgrade works around https://github.com/saltstack/salt/issues/49967 which was fixed in 2018.3.4. The python upgrade works around https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings.

@bors-servo r=Manishearth

:pushpin: Commit 5cfa804 has been approved by Manishearth

:hourglass: Testing commit 5cfa8048cf6c22e724ab318e05d24f1ac3f278a7 with merge f24e048cfc29d7b7a9ebdbc3e328defabbf10466...

:sunny: Test successful - checks-travis
Approved by: Manishearth
Pushing f24e048cfc29d7b7a9ebdbc3e328defabbf10466 to master...


Enhancement: Playground interface for text completion

Contact Details
No response
What features would you like to see added?
Hi! I would like to request a feature that gives a text completion feature like it is on on OpenAI Playground and Claude console. This way we could continuously generate text, it would be tremendous help for writers and gives opportunity for more creative ways of text generation. I would like to request that it should continue text from the last character as it is available on Anthropic's Claude console. That way we could edit the full conversation and force the AI to continue from where it left off or make it produce longer responses or steer the responses in way we want.
Are you familiar with Claude Console? That way we can edit or have the conversation in a text format instead of just on the chat interface and when I press  "generate" it makes the ai continue exactly where it left off. Please kindly reconsider my recommendation!
More details
Example is claude console, picture included.
In this example I make it talk about cats then I delete part of it, add the word "dinosaur" and the AI is now forced to continue the text completion from there. This allows full control on the text, the direction where the AI will have to steer. I believe this would be crucial to give us full control over the conversation/text completion
Which components are impacted by your request?
General
Pictures

Code of Conduct

[X] I agree to follow this project's Code of Conduct

https://nat.dev/ has this functionality, this project is focused on cloning the UI/UX of ChatGPT.

It’s possible and I’m open to doing this. Will add it to the roadmap

Here's another reference on the subject:
https://docs.anthropic.com/claude/docs/ask-claude-to-think-step-by-step

@elinorgodzilla I am introducing the initial functionality for this very soon through a "continue regenerating" button, similar to chatgpt.
You can see my progress on discord here
This initial logic will release today. And then the next step is to edit the AI messages themselves, which a lot of the work for this is done now since it will use the same logic.
This is related to #639


Short solution needed: "Change background color" (vim)

Please help us write most modern and shortest code solution for this issue:
Change background color (technology: vim)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Change background color


Address already in use [reopening]

Hello,
Sorry for again posting this but the fix presented here:
https://github.com/stanford-futuredata/macrobase/issues/170
Did not work for me. Reposting the error after the fix:
* Failed to parse configuration at: server.applicationConnectors.[0]; Could not resolve type id 'http' into a subtype of [simple type, class io.dropwizard.jetty.ConnectorFactory]: known type ids = [ConnectorFactory]
 at [Source: N/A; line: -1, column: -1] (through reference chain: macrobase.conf.MacroBaseConf["server"]->io.dropwizard.server.DefaultServerFactory["applicationConnectors"]->java.util.ArrayList[0])

Can you rename the issue as the error produced is different from #170
You can try the solution here:
http://stackoverflow.com/questions/27543060/why-does-dropwizard-configuration-is-not-working

@kemathur please let us know if you still have this issue


Create vDNS container for Docker

Tasks:

[x]  Create Dockerfile for building CNF based on VNF
[x] Bring up CNF on Docker
[x] update install files to work with docker and vagrant
[x] Create a entrypoint.sh for vDNS to start bind9

leave DHCP service starting as is

[x] smoke test
[x] Determine solution for multiple network interface requirement
[x] Update and document process for creating and starting vDNS container

create 2nd network
create container and attach network with specific IP
start container

[x] Update container build to use mac address used by vpp in #26

Issues:

RESOLVED: Multiple network interfaces needed for testing based on vpp packet gen tests.

if optimization is needed in the future, we will open a new ticket. closing.


Monitoring for CI identity claims

Description

Extend identity monitor to check for specific CI identity claims

Dup https://github.com/sigstore/rekor-monitor/issues/158


Acceptance Criteria:
vehicle slows down smoothly  when detecting an obstacle until it comes close to it and then starts avoiding the obstacle.

The issue has been completed in terms of the acceptance criteria, can be enhanced at a later stage if needed.


Allow F.normalize function to use float and list of float as mean and…

Resolve issue https://github.com/pytorch/vision/issues/5046

Hi @datumbox @NicolasHug thanks for the comment! Yeah, I have just read the CI error and indeed I forgot to import Union...
@NicolasHug you are right about the test! I think we dont need the unit test.
@datumbox will check on https://github.com/pytorch/pytorch/issues/69434 and see if it can be somehow resolved, thanks!
Usually what is the best way to detect this import issue offline?
I have tried doing pytest test -vvv -k test_trasforms.py and flake8 torchvision/transforms/functional.py however both did not show the Union import related error.
After knowing this error, I tried to use pylint and it can detect this error, however it is too noisy as it shows quite a lot of other warnings and errors (is there any lint config used as standard?)

@datumbox @YosuaMichael I'm not sure we need to worry about https://github.com/pytorch/pytorch/issues/69434, at least for now. If mypy is happy with Union[float, List[float]], then I believe we're good. If mypy is not happy, then it's fine to close the issue as a no-fix.

pytest test -vvv -k test_trasforms.py

There's a typo, it should be test_transforms.py. If you ran exactly pytest test -vvv -k test_trasforms.py, the no tests actually got run.
Also, flake8 won't check types, only mypy does. So to make sure that mypy is happy with the changes, the best way is to locally write a basic file that calls F.normalize(img1, mean=0.5, std=0.5), and to check that mypy is happy with it

After knowing this error, I tried to use pylint and it can detect this error, however it is too noisy as it shows quite a lot of other warnings and errors (is there any lint config used as standard?)

Hmmmm. Maybe you got old dependencies or something?
Mypy should also catch this problem. You could run it from project root with mypy --config-file mypy.ini (see guide).

@YosuaMichael You need to update the method on functional_tensor.py as well. This is why the test is failing.

Hi @datumbox , thanks for your quick response!
Previously I am not sure how to debug on my local laptop and now thanks to @NicolasHug I am able to debug it locally.
After changing functional_tensor, it seems to still give error when it call torch.as_tensor.
As of now my fix is to use isinstance and make sure the mean and std is typed as List[float] before calling torch.as_tensor. It is working in my laptop, but I will wait the CI check first if there is anything that failed.

Noted the failed test on Tuple type, and will work to fix it

Take note that using Union[float, List[float]] as this PR suggest may have unexpected behaviour when called on torch.jit.script, for instance it will not accept tuple type as input. Here are example script to illustrate this:
import torch
import torchvision.transforms.functional as F

class TestClass_List(torch.nn.Module):
    def forward(self, img):
        return F.normalize(img, [0.5,0.5,0.5], [0.5,0.5,0.5])

class TestClass_Float(torch.nn.Module):
    def forward(self, img):
        return F.normalize(img, 0.5, 0.5)

class TestClass_Tuple(torch.nn.Module):
    def forward(self, img):
        return F.normalize(img, (0.5,0.5,0.5), (0.5,0.5,0.5))

class TestClass_Int(torch.nn.Module):
    def forward(self, img):
        return F.normalize(img, 1, 1)

img = torch.rand(3, 2, 2)
tc_list = TestClass_List()
tc_float = TestClass_Float()
tc_tuple = TestClass_Tuple()
tc_int = TestClass_Int()

# NOTE: Call to F.normalize without jit will work on float, int, list, and tuple
F.normalize(img, 0.5, 0.5)
F.normalize(img, 1, 1)
F.normalize(img, [0.5, 0.5, 0.5], [0.5, 0.5, 0.5])
F.normalize(img, (0.5, 0.5, 0.5), (0.5, 0.5, 0.5))

# Call with jit will work on both list and float
torch.jit.script(tc_list)
torch.jit.script(tc_float)

# Call with jit trigger error for tuple and float
try:
    torch.jit.script(tc_tuple)
except Exception as e:
    print("Tuple ERROR: {}".format(e))
try:
    torch.jit.script(tc_int)
except Exception as e:
    print("Int ERROR: {}".format(e))

As for the tuple, I think it should be resolved by using typing.Sequence instead of typing.List. However unfortunately, it is not supported as of now: https://pytorch.org/docs/stable/jit_language_reference.html#unsupported-typing-constructs.
**Note: if we use List[float] instead of Union[float, List[float]] as the type of mean in F.normalize, then it will accept tuple even when called with torch.jit.script. So I think the Union somehow remove the autocast from tuple to list in torch.jit.script.
For the int, I think it is reasonable enough not to support this because usually the value of mean and std should be floating point rather than int.

@YosuaMichael Thanks for the detailed analysis. The reasons you mentioned above are why I'm skeptical merging this. I feel the same for my own PR at #5568. It feels like we fix something but break something else. What are your thoughts on this?
BTW have you raised a ticket on PyTorch for the specific problem? It might be worth raising it to get it fixed as this way it will make merging this PR a no-brainer.

@YosuaMichael Thanks for the detailed analysis. The reasons you mentioned above are why I'm skeptical merging this. I feel the same for my own PR at #5568. It feels like we fix something but break something else. What are your thoughts on this?
BTW have you raised a ticket on PyTorch for the specific problem? It might be worth raising it to get it fixed as this way it will make merging this PR a no-brainer.

@datumbox ,I also feel like it should not be merged because of this since it is very likely people use Tuple on mean / std.
I will raise an issue on the pytorch github soon, will update here again.

@YosuaMichael Thanks for being an awesome contributor. Please stick around and send more PRs. :)
For exactly the same reasons you mention, I decided to also close the other PR. See https://github.com/pytorch/vision/pull/5568#issuecomment-1063981861
Let's close this PR, raise the issue to PyTorch core and reassess on the near future once the issue is patched.

@datumbox Raised this issue on Pytorch: https://github.com/pytorch/pytorch/issues/74030
Yeah, will close this PR for now.


Use the proj C-API to avoid errors being thrown in Julia

When Proj has an error, you can enquire using a ccall, meaning that we don't need to wrap each point transform in a try-catch block!

Is the error handler an issue? See also https://github.com/JuliaGeo/GDAL.jl/pull/153

I think this works now, haven't had any bad experiences this far.


Add documentation about the log streaming format

After spending two days on trying to figure out the undocumented pitfalls of the format required for streaming logs, I'd like to share the things I found out so other people won't have that much trouble with it.
Signed-off-by: Tobias Guggenmos<EMAIL_ADDRESS>

Request made against the wrong repo :man_facepalming:


Add files via upload

Assigned Issue Number ?
#1077
Language Opted ?
C++
Number of files added or updated ?
1
Name of these files ?
main folder => Data_structures => Tree => Binary_Search_Tree => BST_to_Binary_Tree
example :
Algorithm => Search_Algorithm => Linear_Search => Linear_Search.py
Checklist

[x] I've read the contribution guidelines.
[x] I've referred the correct issue number.
[x] I've fill up this entire template correctly.

Dijkstra


Correct extra bracket

Docs Build status updates of commit 02957ea:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Webcam not detected

Describe the bug
When I start a call with Jitsi from within RocketChat Desktop, the microphone works but the webcam is not detected. It does work from the web browser. Seems to be the same as #1903.
OS: Ubuntu Linux 18.04 LTS
Rocket Chat server: any
Rocket.Chat.Electron: 3.7.5
To Reproduce
Steps to reproduce the behavior:

Start a call
See the webcam button greyed out
Go to the Jitsi parameters, webcam says "none"

Expected behavior
The webcam should appear as it does in the web browser.
Screenshots

Same issue on Ubuntu 20.04 Rocket.chat 3.7.5. (Previous version was working)

What previous version was you using? I couldn't find whats going on yet.
Em qua, 2 de fev de 2022 12:56, Ben @.***> escreveu:

Same issue on Ubuntu 20.04 Rocket.chat 3.7.5. (Previous version was
working)
—
Reply to this email directly, view it on GitHub
https://github.com/RocketChat/Rocket.Chat.Electron/issues/2304#issuecomment-1028086718,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI7PCXCVAWJG2LUSG64CVTUZFH2VANCNFSM5NBHCKBQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

What previous version was you using? I couldn't find whats going on yet. Em qua, 2 de fev de 2022 12:56, Ben @.> escreveu:
…
Same issue on Ubuntu 20.04 Rocket.chat 3.7.5. (Previous version was working) — Reply to this email directly, view it on GitHub <#2304 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI7PCXCVAWJG2LUSG64CVTUZFH2VANCNFSM5NBHCKBQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.>

It was version 3.2.3.

Still same issue on Rocket.Chat 3.7.8 with a new Ubuntu 20.04 fresh install.

I found the issue.
It seems that the permission for the webcam is not granted when rocket.chat is installed using snap.
You've to allow it manually using:
sudo snap connect rocketchat-desktop:camera
Now it work like a charm !

Ah, yet another snap issue. I am at loss at how to create a seamless UX for newbies with countless access rights issues for so many softwares. Anyone working on this?!

@BenGrenoble thanks for figuring out.  Seems that something is out of place.

I dont know what changed, but now for default the permissions for audio and camera are disabled on the Snap Store. We didn't changed anything. I will investigate if we can solve that just on code, or is a new rule from Snap store.
For now you can solve that going in Permission and enabling them:


WSCHAT error accessing

Hi,
i've download your testapp for grails 2.4.4 but i don't find the version of wschat so idecided to put wschat1.31 on buildconfig after running it started but when i go to myapp:
http://localhost:8080/testwschat/wsChat i put a name and choose a room
but it open and give me and error immediately:
Error DOH
user1 disconnecting from server DOH

and there is no log in console.
Any idea ??
Tks
Windows 7
GGts 364
grails 244
jdk 1.7

The problem appears to be that on that specific site I must have been fiddling with wss
if you open up developer console you will see the problem:
chat:610 WebSocket connection to 'wss://localhost:8443/testwschat/WsChatEndpoint/fred' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED
wschat.js?compile=false:832 WebSocket is already in CLOSING or CLOSED state.
wschat.js?compile=false:833 WebSocket is already in CLOSING or CLOSED state.
In the config change:
wschat.hostname='localhost:8443'
wschat.wsProtocol='wss'
wschat.siteProtocol='https'
```
to

wschat.hostname='localhost:8080'
wschat.wsProtocol='ws'
wschat.siteProtocol='http'
take a look here the demo site has also now been updated to work from now on

https://github.com/vahidhedayati/testwschat/commit/be03f4314b2b1619ebbf3c2db8ae75844563a63e

ok let me try
tks

so it's working but with 8081 on the port .
i don't know why but 8080 don't start
thanks now i'll try to understand how it work
if u have any user guide (LOL) i will like it use

You must still have something running on port 8080 - from msdos prompt
try netstat -plant   then trace kill the java process alternatively look in you windows processes running and kill off all java processes start again to run on port 8080.
so far as documentation take a look through the various links provided and the wiki pages that are part of the links.
Sorry it is in bits and not a full documentation guide due to development over different stages of the plugin
Feel free to contribute happy to add you along if you want to improve documentation

it's fine for me i'll be very proud to contribute in documentation
i'll try to improve this tool really amazing believe me.
Congratulation

:) thank you for the compliment, in all honesty this was a plugin based on me also learning websockets, started from a very basic java application example and grew over time.
So far as understanding all of it, it is difficult since it tries to cover a lot of different things as part of a chat room system i.e. live chat, room booking conferencing. application events and also things like the addons such as tictactoe.
it all depends on what you are trying to learn out of it yourself for you to wish to understand that segment.
Feel free to browse through all the closed topics https://github.com/vahidhedayati/grails-wschat-plugin/issues?q=is%3Aissue+is%3Aclosed  which gives you insight into some of the additions / ideas and probably a little look in the code too.
The videos will also help, if you wish to understand something better and so long as i don't have to pull apart code to explain then email me direct i think my email address was sent as part of this communication

Ok fine i'll look for i'm a big user of videoconference tools and elearning like bigbluebutton, moodle cisco webex, dimdim,...
Usually i integrated these tools in my existing developpement cuz i never try to develop something like that.
But i'll try to follow doc after testing mailling list i've seen today also interesting.
By the way i cannot to acces to your mail it's<EMAIL_ADDRESS>who send me take mine<EMAIL_ADDRESS>

Was going to email you but then thought as it is here it may help others
In short if you reverse the BuildConfig to use wschat as the inline plugin as in the very last commented out line in buildConfig
then clone this plugin
git clone -b grails2 http://github.com/vahidhedayati/grails-wschat-plugin
outside of the testwschat folder it then becomes accessible in development mode
you can then look at this specific segment
and add custom println and output what is going on - also then add println to the socket end point file and figure out how messages are coming in.
Unsure what your scope / level is and what your goal is - if you wish to understand how that part of it as in conferencing works above is a good starting point,
Reason behind the feature was in my previous work place they were paying lots of money to third party companies to have something similar - obviously better. It never took off hence it probably is in the state it is in - working but not perfect or excelling


Templates for simple Resources Test infrastructure

Sets baseline code coverage at 67%
Basic fixtures for simple schema
Test support libs
Database/Service/Route Tests
Adds ResourceTests to generator index for installing these.

Verified by installing a service with one resource and running the tests/coverage.
I also noticed a couple other bugs (inability to create more than one resource/router/schema, and camelCase doesn't work when the first letter is capitalized) but I didn't include fixes here.

Looks good 👍


Crash when disabling the "color" Extension

Filament Version
v3.0.19
Plugin Version
v2.0.0
PHP Version
8.3.0
Problem description
Undefined property: stdClass::$color at FilamentTiptapEditor \ Extensions\ Extensions\Color:31
Expected behavior
No crash :D
Steps to reproduce
I am not using the color extension, so I don't know why the error occurs. This is the config that I am using for the editor:
['heading', '|', 'bold', 'italic', 'underline', '|', 'align-left', 'align-center', 'align-right', 'align-justify', '|', 'bullet-list', 'ordered-list', '|', 'link', 'media', 'oembed' , '|', 'source']
Adding the "code" extension to the array solves the issue.
Reproduction repository
No response
Relevant log output
No response

Let me know if the latest release resolves this for you. Please.

Looks just fine!


fix: SmsOtp should still send otp the first time when sms autoconfirm…

What kind of change does this PR introduce?

Fixes #265

Recap for own understanding, please ignore but feel free to correct if off: OTP generation is tied to logic in sendPhoneConfirmation and sendPhoneConfirmation doesn't get triggered when config.Sms.Autoconfirm is set to True. This PR ensures that the OTP still gets sent when config.Sms.Autoconfirm is True.
======
Comments:
LGTM, thanks!

Yup that's correct, for passwordless phone logins, we still need to send the otp when they first signup regardless of whether autoconfirm is true or false because the otp acts as the user's "password"


modbus: add user data for adu callback

add user data for adu callback, which helps in passing
socket and relevant application parameters.
Signed-off-by: Parthiban Nallathambi<EMAIL_ADDRESS>

Looks good for me. Ack for upstream PR


Bug: Setting concurrency=1 in OpenAI model params immediately crashes process with no error message on first call

This one was quite the bugger to find. Because of GPT4's rate limit, I set the concurrency param to 1 when instantiating the OpenAI model as you can see below:
const model = new OpenAI({
  openAIApiKey: <redacted>,
  modelName: 'gpt-4',
  temperature: 0.7,
  verbose: true,
  concurrency: 1,
  callbackManager: callbackManager,
  maxTokens: 1000,
  maxRetries: 5
})

Even with explicit callbacks, this causes the program to exit immediately upon making its first call. Values higher than one (including 2) work fine.

@kryptoklob I'm looking into this, thanks for reporting

This has been fixed in 0.0.39


Implement Packit to openssh-keys

This PR is about using Packit to automate releases for openssh-keys. We tested it in coreos-installer and found it effective. Now, we're working in an epic to add it in all coreos packages repos.
You can learn more about Packit in its documentation here.

Hmm, Can you squash the two commits into one?

Overall lgtm. Just need the commits squashed.

Overall lgtm. Just need the commits squashed.

I did a rebase with main and just let one commit here.
I think its ready to be approved now.


Non valid configuration attributes

Attributes such as "services" are not valid HTML attributes. HTML5 though allows the use of custom attributes as long as they're prefixed with "data-". Would it be possible to change the attributes and make this script rock even more with valid HTML5 syntax?
Instead of:
services
share-label
color-scheme
icon-size
panel-bottom
share-zindex
we would have:
data-services
data-share-label
data-color-scheme
data-icon-size
data-panel-bottom
data-share-zindex

Hiya,
yeah totally, and thanks for flagging this - great idea. I will have a go at this, and will let you know when I push a fix. Will make sure that it doesn't break and existing sites, will look up on the HTML5, and run it through a validator or something. Will get this done very shortly.

Awesome, thanks

Hiya,
I have made the fix which you asked for :)
https://github.com/mischat/shareNice/commit/984c2dc5001903a86fa868e6119ef78959a4e8a8
Are you going to be using shareNice, as I have no way of telling if people use it, due to the /dev/null'ing of logs ;)
I am going to close this issue

Definitely. The script being truly open is reason enough for me. If you ever visit Slovenia, drop me an email and I'll buy you a beer :)

Cool, I work with a couple of Slovenians and the plan is to come to Ljubljana, if you are there, i will definitely hit you up for a beer :)

Hi,
nice job, but don't forget to correct the demo on your site.
http://sharenice.org/demo
Lol, you just chage the host script because it's not good on the demo site.

Hi Jeckyl,
What do you mean, the demo looks fine to me ?

Hi,
yes its fine now.
juste the porblem with plus.google.com


[INLONG-11588][Agent] Modify the default cluster tag of the configuration file

Fixes #11558
Motivation
Modify the default cluster tag of the configuration file
Modifications
Change the default cluster tag to file_agent_common
Verifying this change
(Please pick either of the following options)

[x] This change is a trivial rework/code cleanup without any test coverage.

[ ] This change is already covered by existing tests, such as:
(please describe tests)

[ ] This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation
No doc needed

it's better not to change the default value.


Formatted Russian and Lithuanian phone number generated by react-intl-tel-input are considered not plausible

What I did
This is a cross reporting with https://github.com/patw0929/react-intl-tel-input/issues/237
Formatted phone number for Russian and Lithuanian generated by react-intl-tel-input are considered invalid when it's validated server side using this gem..
Sample phone number from the placeholder for those 2 countries are:

Russian: +7 8 (912) 345-67-89 ({ number: '8 (912) 345-67-89', countryCode: 'ru' })
Lithuanian: +370 (8-612) 34567 ({ number: '(8-612) 34567', countryCode: 'lt' })

which when being processed server side gives
> phone_number = '8 (912) 345-67-89'.phony_formatted(format: :international, normalize: 'ru')
=> "+7 891 23-456789"

> Phony.plausible? phone_number
=> false

> phone_number = '(8-612) 34567'.phony_formatted(format: :international, normalize: 'lt')
=> "+370 861 2 34 567"

> Phony.plausible? phone_number
=> false

What happened
Russian and Lithuanian numbers formatted by react-intl-tel-input are considered not plausible..
What I expected to happen and why
Russian and Lithuanian numbers formatted by react-intl-tel-input to be considered plausible.. the default formatter being used by react-intl-tel-input came from google libPhoneNumber, which I assume is a trustable source? :sweat_smile:

Upon further investigation, I noticed that the default formatting given by react-intl-tel-input default to National format, while phony expect International format.. closing this ticket, since adding nationalMode={false} solve the issue..


Add push-to-talk to video chats

Very frequently requested feature during ICSE: leave yourself muted, hold down spacebar to talk, release spacebar to go back to muted

This is relevant to the new UI and worth considering.


Add support for a psycopg backend

This is the other major postgresql DB engine in Python. As I've been seeing odd behaviour with asyncpg this will be quite helpful in tracking it down.
At the time of this commit psycopg 3.2 has not been released, and hence this has been tested against the development branch of psycopg.

Out of curiosity, which odd behaviors of asyncpg are known?

Merged manually.
@larsblumberg I was seeing memory leaks, but I no longer think that was due to asyncpg.


Support "rar" source compression

Overview
We'd like to extend support of compression algorithms adding rar.
Plan

[ ] pick a rar library to depend on (probably https://pypi.python.org/pypi/rarfile/?)
[ ] add rar to supported compressions - https://github.com/frictionlessdata/tabulator-py/blob/master/tabulator/config.py#L14
[ ] add rar decompression to the stream.open based on zip and gz examples - https://github.com/frictionlessdata/tabulator-py/blob/master/tabulator/stream.py#L161-L182
[ ] add tests for table(s) which is compressed using rar
[ ] update list of supported compressions in the readme

_From @jbothma _
Is that something that you'd be willing to have in tabulator? Our treasury has been publishing some files we'd like to use in fiscal data packages in rar archives.

Hey @jbothma sure! Do you want to do a PR? Just check with @roll on if this is part of core or installed as an extension.

Excellent. Sure, I can probably have a go at it soon and so a PR.

Hi @jbothma. It would be great! I've added an implementation plan to the issue.

Sorry - in the end I don't need it yet for my project and I'm struggling to find time for it outside the project. Should we close it for now then I can re-open if I get to it?

@jbothma no worries! Let's keep it open and perhaps someone else will pick it up sometime.


Can't change the default Controls

[ X] I have checked the known issues and searched Github to ensure this issue has not already been reported.
[ ] This is not a feature request, I know those belong on Discord/Github Discussions.

Description of the bug:
When i try change anything in The Controller Mapping Settings using my Laptop Keyboard the inputs won't register.
Altough sometimes when i keep pushing buttons it always registers i think the last one but that happens randomly.
Also all options(clear all/restore defaults) randomly choose to work.
Can you reproduce? If so please list the steps:

[ ] No, I cannot reproduce this bug
[x ] Yes, here are the steps to reproduce the bug:

Expected behavior:

to chnage Controller inputs.
Screenshots or videos:

System Information:

OS: Win 10
GFX Backend: DirectX
Game Version: ?
Rom Version:USA

Additional Information:

Update:
docking the window  Solves the issue but the inputs are buggy , sometimes it takes another input


Running in domain environment with user rights from Start menu

ℹ Computer information

PowerToys version: 0.31.2
PowerToy Utility:
Running PowerToys as Admin: works fine
Windows build number: [run "winver"] Win10x64  2004 1904.264 localized Russian

📝 Provide detailed reproduction steps (if any)

… To install software I use administrator account. Works fine as well as installation procces as well as usage of PowerToys
… Running under user account with limited right have issue. Shortcut in Start menu dosn't work properly. It's start some repeair I suppose action and Ive get results as on attached screenshots in the end.
… PowerToys runs well directly from program files only.

✔ Expected result
I awaiting running fine from Start menu
❌ Actual result
See screen shots
📷 Screenshots

@hooddy
please add your comments to https://github.com/microsoft/PowerToys/issues/7353 since it covers the same scenario. Thanks.


Seek for help.

 ERROR in ./node_modules/_babel-loader@7.1.5@babel-loader/lib!./app/views/editor/thang/AnimateImportWorker.js
    Module not found: Error: Can't resolve 'adobe-animate-parser' in 'C:\Codecombat\app\views\editor\thang'
     @ ./node_modules/_babel-loader@7.1.5@babel-loader/lib!./app/views/editor/thang/AnimateImportWorker.js 3:26-57

This is the error log.
And i don't know how to deal with it in every way i know.
So is there anyone who can help me?
Thank you very much!!!
System info:Microsoft Windows 10 2019 LTSC

After the error,the terminal got stucked.

+1

Infinite wait

@shrihari @soffes @torehaug

@pys078 报错那个可以通过直接安装解决
npm i https://github.com/codecombat/adobe-animate-parser.git

不过 sass-loader 编译无限等待就有点无解了。

Could you elaborate on what you were doing when you got this error? i.e. what you were trying to do before the error occurred.  Any screenshots would be helpful as well! Thanks!

It happened jus after this command
npm run webpack -- --watch
npm run proxy

Sorry for my replying so late


What is HTTP?

Description
Hyper-Text Transfer Protocol
Domain
Frontend Dev HTML/CSS/JS
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

/assign audio

@code-reaper08  @2024-SANDHYA please review my PR. thankyou :)

@code-reaper08 @2024-SANDHYA please review my PR. thankyou :)

Already exists!

@2024-SANDHYA you mean the HTTP video has already been created by someone?

@2024-SANDHYA you mean the HTTP video has already been created by someone?

I couldn't find any, btw, I've left a comment on your PR, have a look, and do the needful 😄

@2024-SANDHYA you mean the HTTP video has already been created by someone?

Not video, but documentation as here this issue is labeled with documentation.

@code-reaper08 , I will be doing the necessary changes in a day or two. Also,please add the VIDEO label in this issue.

@code-reaper08 , I have done the changes in my video. Also I am extremely sorry that I had to create a new PR as when I was merging changes in the same PR , I completely messed up. Please review my changes in the PR created above. Thanks.


Fail to boot riscv64 cuttlefish

I am currently attempting to build RISC-V Cuttlefish following the instructions from README.md
Here is my environment and build command:
$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 22.04.3 LTS
Release:	22.04
Codename:	jammy

$ qemu-system-riscv64 --version
QEMU emulator version 8.1.0
Copyright (c) 2003-2023 Fabrice Bellard and the QEMU Project developers

#build command
$ cd aosp
$ source build/envsetup.sh
$ lunch aosp_cf_riscv64_phone-trunk_staging-userdebug
============================================
PLATFORM_VERSION_CODENAME=VanillaIceCream
PLATFORM_VERSION=VanillaIceCream
PRODUCT_INCLUDE_TAGS=com.android.mainline mainline_module_prebuilt_nightly
TARGET_PRODUCT=aosp_cf_riscv64_phone
TARGET_BUILD_VARIANT=userdebug
TARGET_ARCH=riscv64
TARGET_ARCH_VARIANT=riscv64
TARGET_CPU_VARIANT=generic
HOST_OS=linux
HOST_OS_EXTRA=Linux-6.2.0-35-generic-x86_64-Ubuntu-22.04.3-LTS
HOST_CROSS_OS=linux_musl
BUILD_ID=MAIN
OUT_DIR=out
============================================
$ make -j8

When I run launch_cvd -cpus=4 --memory_mb=8192, I encounter the following issue:
/usr/bin/qemu-system-riscv64
qemu-system-riscv64: -display egl-headless: Parameter 'type' does not accept value 'egl-headless'
starting Rust KeyMint TA implementation in a thread
starting C++ KeyMint implementation in a thread with FDs in=32, out=31
KeyMint Rust TA running with fd_in=38, fd_out=37, security_level=TrustedEnvironment
Secure deletion data file found. Parsing.
Detected unexpected exit of monitored subprocess /usr/bin/qemu-system-riscv64
Subprocess /usr/bin/qemu-system-riscv64 (3605200) has exited with exit code 1
Stopping all monitored processes due to unexpected exit of critical process
11-01 17:00:19.291 3605220 3605226 I stop_cvd: main.cc:124 Requesting stop
Metrics host received: VMStop
Metrics posted to ClearCut
Exit request from parent process

QEMU is showing an "-display egl-headless" error, indicating that this parameter value is not supported. I'd like to know how to configure QEMU correctly to avoid the "-display egl-headless" error or if there are other factors affecting a successful boot.
I also attempted to use qemu-system-riscv64 8.1.2 and encountered an error with the following message:
/usr/bin/qemu-system-riscv64
2023-10-31T07:52:19.480170Z qemu-system-riscv64: can't apply global rv64-riscv-cpu.v=true: Property 'rv64-riscv-cpu.v' not found
Detected unexpected exit of monitored subprocess /usr/bin/qemu-system-riscv64
Subprocess /usr/bin/qemu-system-riscv64 (1712626) has exited with exit code 1
Stopping all monitored processes due to unexpected exit of critical process
starting Rust KeyMint TA implementation in a thread
starting C++ KeyMint implementation in a thread with FDs in=31, out=30
KeyMint Rust TA running with fd_in=37, fd_out=36, security_level=TrustedEnvironment
Secure deletion data file found. Parsing.
10-31 15:52:19.629 1712656 1712664 I stop_cvd: main.cc:124 Requesting stop
Exit request from parent process

Has anyone encountered a similar situation? I would like to understand what is causing these issues and how to resolve them, if possible. Thank you.

yeah, we've checked in new qemu prebuilts, but we're still working on having them actually used by default. i think it's only https://android-review.googlesource.com/c/device/google/cuttlefish_vmm/+/2810815 left to go? hopefully that should make things work "out of the box" for more people, regardless of what qemu your host OS has.

(i've update the instructions on the front page to show how to use the prebuilt qemu.)

Thank you for your previous response.
I rebuilt RISC-V Cuttlefish from scratch following the new guide README.md
My environment remains the same, and this time I used the AOSP prebuilt QEMU.
However, my command line has been consistently stuck at:
init: starting service 'adbd'...
proxy_fastboot] Stop event (11) received. Stopping proxy
proxy_adb] Start event (5) received. Starting proxy
proxy_adb] From: tcp: 6520
proxy_adb] To: vsock: 3:5555 vhost_user: false

But my launcher.log keeps updating with the following content:
kernel_log_monitor I 12-12 23:44:55 23186 23186 kernel_log_server.cc:140] init: starting service 'adbd'...
proxy_fastboot I 12-12 23:44:55 23178 23178 socket_vsock_proxy.cpp:182] Stop event (11) received. Stopping proxy
proxy_adb I 12-12 23:44:55 23177 23177 socket_vsock_proxy.cpp:175] Start event (5) received.

The process has been running for over an hour, and I eventually paused it.
I would like to inquire if anyone has encountered this issue and if there are possible solutions. Thank you.

what are the crashes in the tombstones?

it's all empty
file tombstone_2023-12-13-003915
tombstone_2023-12-13-003915: empty

I rebuilt RISC-V Cuttlefish again, and launch by
$ launch_cvd -cpus=4 --memory_mb=8192 --gpu_mode=none \
      --vm_manager=qemu_cli \
      --qemu_binary_dir=$ANDROID_BUILD_TOP/device/google/cuttlefish_vmm/qemu/x86_64-linux-gnu/bin

This time my launcher.log keeps looping this:
secure_env::kmr_ta I 12-29 00:56:02 17164 17481 lib.rs:581] Setting boot_info to BootInfo { verified_boot_key: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], device_boot_locked: false, verified_boot_state: Unverified, verified_boot_hash: [38, 18, 193, 72, 255, 153, 50, 28, 104, 215, 223, 108, 233, 17, 174, 108, 255, 33, 0, 115, 103, 254, 82, 224, 138, 73, 18, 170, 44, 68, 81, 123], boot_patchlevel: 20231205 }
secure_env::kmr_ta I 12-29 00:56:02 17164 17481 lib.rs:606] Setting hal_info to HalInfo { os_version: 140000, os_patchlevel: 202312, vendor_patchlevel: 20231205 }
secure_env::kmr_ta I 12-29 00:56:02 17164 17481 lib.rs:624] Set aidl_version to V3
secure_env::kmr_ta W 12-29 00:56:02 17164 17481 lib.rs:635] Setting attestation IDs directly
secure_env::kmr_ta::secret I 12-29 00:56:02 17164 17481 secret.rs:37] Setting HMAC key from 1 shared secret parameters
secure_env::kmr_ta E 12-29 00:56:02 17164 17481 lib.rs:1060] secure deleting all keys -- device likely to need factory reset!
secure_env::kmr_cf::sdd I 12-29 00:56:02 17164 17481 sdd.rs:180] Deleting all secrets
secure_env::kmr_cf::sdd I 12-29 00:56:02 17164 17481 sdd.rs:114] Generating new secret with slot ID: 1
secure_env::kmr_cf::sdd I 12-29 00:56:02 17164 17481 sdd.rs:65] No secure deletion data file found. Creating one.
secure_env::kmr_cf::sdd I 12-29 00:56:02 17164 17481 sdd.rs:147] Fetching secret with slot ID: 1
kernel_log_monitor I 12-29 00:56:22 17153 17153 kernel_log_server.cc:133] GUEST_BUILD_FINGERPRINT: generic/aosp_cf_riscv64_phone/vsoc_riscv64:VanillaIceCream/MAIN.2612c148/eng.bruce.20231228.222236:userdebug/test-keys
secure_env::kmr_ta::secret I 12-29 00:56:25 17164 17481 secret.rs:37] Setting HMAC key from 1 shared secret parameters
kernel_log_monitor I 12-29 00:56:30 17153 17153 kernel_log_server.cc:133] GUEST_UBOOT_VERSION: 2023.04-gc2f63e06296a-ab11193194 (Dec 05 2023 - 03:08:51 +0000)
kernel_log_monitor I 12-29 00:56:30 17153 17153 kernel_log_server.cc:140] U-Boot 20
secure_env D 12-29 00:56:30 17164 17486 secure_env_not_windows_main.cpp:129] secure_env detected guest reboot, restarting.
secure_env D 12-29 00:56:30 17164 17164 tpm_storage.cpp:39] Initializing secure index file
secure_env D 12-29 00:56:30 17164 17164 tpm_storage.cpp:45] Restoring index from file
secure_env I 12-29 00:56:30 17164 17164 secure_env_not_windows_main.cpp:289] starting Rust KeyMint TA implementation in a thread
secure_env I 12-29 00:56:30 17164 17164 secure_env_not_windows_main.cpp:304] starting C++ KeyMint implementation in a thread with FDs in=63, out=62
secure_env::kmr_cf I 12-29 00:56:30 17164 17632 lib.rs:66] KeyMint Rust TA running with infile=69, outfile=68, security_level=TrustedEnvironment
secure_env::kmr_cf::sdd I 12-29 00:56:30 17164 17632 sdd.rs:60] Secure deletion data file found. Parsing.
kernel_log_monitor I 12-29 00:56:31 17153 17153 kernel_log_server.cc:133] GUEST_KERNEL_VERSION: 6.6.0-mainline-gc387c4e84ce5-ab11047873 (build-user@build-host) (Android (10742551, +pgo, +bolt, +lto, +mlgo, based on r498229b) clang version 17.0.4 (https://android.googlesource.com/toolchain/llvm-project e34ed7d63863b45858e74126edaa738e75887800), LLD 17.0.4) #1 SMP PREEMPT Wed Nov  1 22:15:43 UTC 2023
kernel_log_monitor I 12-29 00:56:31 17153 17153 kernel_log_server.cc:140] ] Linux version
kernel_log_monitor I 12-29 00:57:10 17153 17153 kernel_log_server.cc:140] init: starting service 'adbd'...
proxy_adb I 12-29 00:57:10 17145 17145 socket_vsock_proxy.cpp:175] Start event (5) received. Starting proxy
proxy_fastboot I 12-29 00:57:10 17146 17146 socket_vsock_proxy.cpp:182] Stop event (11) received. Stopping proxy
proxy_adb I 12-29 00:57:10 17145 17145 socket_vsock_proxy.cpp:146] From: tcp: 6520
proxy_adb I 12-29 00:57:10 17145 17145 socket_vsock_proxy.cpp:147] To: vsock: 3:5555 vhost_user: false
kernel_log_monitor I 12-29 00:57:10 17153 17153 kernel_log_server.cc:133] GUEST_UBOOT_VERSION: 2023.04-gc2f63e06296a-ab11193194 (Dec 05 2023 - 03:08:51 +0000)
kernel_log_monitor I 12-29 00:57:10 17153 17153 kernel_log_server.cc:140] U-Boot 20
secure_env D 12-29 00:57:10 17164 17637 secure_env_not_windows_main.cpp:129] secure_env detected guest reboot, restarting.
secure_env D 12-29 00:57:10 17164 17164 tpm_storage.cpp:39] Initializing secure index file
secure_env D 12-29 00:57:10 17164 17164 tpm_storage.cpp:45] Restoring index from file
secure_env I 12-29 00:57:10 17164 17164 secure_env_not_windows_main.cpp:289] starting Rust KeyMint TA implementation in a thread
secure_env I 12-29 00:57:10 17164 17164 secure_env_not_windows_main.cpp:304] starting C++ KeyMint implementation in a thread with FDs in=63, out=62
secure_env::kmr_cf I 12-29 00:57:10 17164 17725 lib.rs:66] KeyMint Rust TA running with infile=69, outfile=68, security_level=TrustedEnvironment
secure_env::kmr_cf::sdd I 12-29 00:57:10 17164 17725 sdd.rs:60] Secure deletion data file found. Parsing.
kernel_log_monitor I 12-29 00:57:11 17153 17153 kernel_log_server.cc:133] GUEST_KERNEL_VERSION: 6.6.0-mainline-gc387c4e84ce5-ab11047873 (build-user@build-host) (Android (10742551, +pgo, +bolt, +lto, +mlgo, based on r498229b) clang version 17.0.4 (https://android.googlesource.com/toolchain/llvm-project e34ed7d63863b45858e74126edaa738e75887800), LLD 17.0.4) #1 SMP PREEMPT Wed Nov  1 22:15:43 UTC 2023
kernel_log_monitor I 12-29 00:57:11 17153 17153 kernel_log_server.cc:140] ] Linux version

Has anyone encountered a similar situation? Thanks.

We've managed to clean some things up in regards to this - I haven't been able to reproduce your exact issue, but I've uploaded some new prebuilts that work for me and removed the additional flags required to start them.
Can you simply try launch_cvd -cpus=4 --memory_mb=8192 --gpu_mode=none after re-syncing your tree?


Fix missing env

Updated profile script to add in missing environment variables.

Oops, sorry wrong branch.


Update README & Bump version

Codecov Report

Merging #62 (3df6dab) into main (47da004) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   96.12%   96.12%
=======================================
  Files          37       37
  Lines        1498     1498
=======================================
  Hits         1440     1440
  Misses         58       58

Impacted Files
Coverage Δ

src/ValidatableMethods/ValidatableMethods.Types.cs
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Usable in a modern VR headset?

Is it possible to use rustual-boy with a modern VR headset such as the HTC Vive and experience the 3D effects appropriately?

The current UI does not have support for this. The in-progress libretro core leans on retroarch/other frontends to implement this, but the emulator core itself should in theory be compatible.
That said, this is not a project that anybody is actively working on atm, so it may be a while :)


Feature request: Show breakpoints as a pane

Hi,
This idea came out of https://github.com/mfussenegger/nvim-dap/issues/185.
I think it would be very helpful to have a pane showing all active breakpoints. as far as I can tell this isn't available yet as an element. A desired solution would show me breakpoint file number and line and allow easy jumping to it, e.g. via enter/o key
local elements = {
  STACKS = "stacks",
  SCOPES = "scopes",
  REPL = "repl",
  WATCHES = "watches"
}

Hmm I quite like this idea actually, I'll have at a stab it. Will update once I have something usable

I've got a version that I think works quite nicely in #15, feel free to try it out and report any feedback. I'll probably merge in a day or two, just want to try it out with multiple servers to make sure I'm not missing anything

Awesome, works like a charm thank you!

Brilliant, merged!


An error occurred when entering the created world and when creating a new one.

When trying to enter the created world / create a new one, an error pops up:

Hello,
Please include a log. I will look into this shortly.

Nevermind, I believe I was able to figure this out without a log; I am releasing a (hopefully) fixed version, let me know if the issue persists with that version.


Make rooms.tpl to create room.html

When user Download the zip, a file room.html should be available.

Solved here #343

It's merged !!! Closing this.


Git Integration not working for private repositories

My actions before raising this issue

[X] Read/searched the docs
[X] Searched past issues

Steps to Reproduce (for bugs)

Went to create task window, added images, title and labels

However I receive this error message

My repository is private and I have added the ssh keys to my github account. Can anyone  please assist me with this.
Thank you so much for such a wonderful open source tool!!!
Context
I am trying to have data annotation version system for my organization using UI of CVAT
Your Environment

Git hash commit -  213bcf0b360d0e09fcfee1ff71ccf0d4e7a7b2b0
Docker version  24.0.6
Are you using Docker Swarm or Kubernetes? No
Operating System and version - Fedora 38

Hey Team! Hoping to hear from you soon!

Hi, seems to be similar issue to mine, also tested with ssh-keys too and had the same errors.

@bsekachev, can you please assist us in this issue. Thank you!

This feature was removed in #6904 as outdated.
Please, consider using cloud storages instead.


Current JAX release incompatible with numpy 1.21

Numpy 1.21 was released a few hours ago, and appears incompatible with the current jaxlib release.

https://github.com/numpy/numpy/issues/19305 is the source of one of the remaining errors.

I've done all I plan to do on this for now: remaining is to release a new jaxlib (in progress) and to do something to fix or work around the numpy bug.

Alright, I'll self-assign so I can close the issue after the next jaxlib release.

Note that we can't close it until we do something to work around the numpy problem. It could just be skipping those tests under NumPy 1.21 for now.
If you want to try running the tests before the new jaxlib lands, apply the following patch:
diff --git a/jax/__init__.py b/jax/__init__.py
index 17629466..caca87a4 100644
--- a/jax/__init__.py
+++ b/jax/__init__.py
@@ -12,6 +12,9 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.

+import numpy as np
+np.typeDict = np.sctypeDict
+
 # Set default logging level before any logging happens.
 import os as _os
 _os.environ.setdefault('TF_CPP_MIN_LOG_LEVEL', '1')

Part of the action item here may be to add a CI job to detect these kinds of breakages before release. @shoyer pointed out the approach that xarray uses, which is a github action that runs tests against upstream dev versions and opens a github issue in case of failure: https://github.com/pydata/xarray/blob/main/.github/workflows/upstream-dev-ci.yaml


[GraphSDK] Design doc

We would like to get a design doc started for the larger scope of GraphSDK.
Example/boilerplate:
https://github.com/Liberty30/graph-sdk
Spike needs:

design doc artifact / UML
mono repo approach

Open questions:

what other sdks would we need?
relationship with wallet?

uploading to share in design doc


Initial Draft of FaIR 2.0 OpenSCM runner

This PR creates a very preliminary draft of the FaIR 2.0 OpenSCM runner. It won't work at the moment, as (for one) it needs parameter sets etc adding. Excepting that it should make sense and hopefully would run properly, but it would be good to clean it up a bit from here.

[ ] Tests added
[ ] Documentation added
[ ] Example added (in the documentation, to an existing notebook, or in a new notebook)
[ ] Description in CHANGELOG.rst added (single line such as: (`#XX <https://github.com/openscm/openscm-runner/pull/XX>`_) Added feature which does something)

Great, Yeah I just wanted to get something written to work from - I suspect part of the difficulty I’m having is due to the ‘hacky’ nature of the FaIR 1.6 version, but once I have a hacky version working (with testing set up to check everything) I can condense it down.

On 8 Oct 2020, at 11:51, Zeb Nicholls<EMAIL_ADDRESS>wrote:
@znicholls commented on this pull request.
Good start. I'm hoping that by making FaIR2.0's pandas interface clever we can remove most of the hacks included here
In src/openscm_runner/adapters/fair2/_run_fair.py https://github.com/openscm/openscm-runner/pull/25#discussion_r501622993:

@@ -0,0 +1,366 @@
+"""
+Module for running FaIR
+"""
+import logging

+import numpy as np
+from fair.constants.general import EARTH_RADIUS, SECONDS_PER_YEAR
+import fair.version_two.emissions_driven as fair_scm
+from scmdata import ScmRun, run_append
+
+LOGGER = logging.getLogger(name)
+toa_to_joule = 4 * np.pi * EARTH_RADIUS ** 2 * SECONDS_PER_YEAR
let's use openscm_units https://github.com/openscm/openscm-units instead, these hard-coded numbers make me nervous
In src/openscm_runner/adapters/fair2/_run_fair.py https://github.com/openscm/openscm-runner/pull/25#discussion_r501623673:

unit : dict

   dict of units corresponding to data

nt : int

   number of timesteps modelled

"""

emissions_df = fair_output['emissions']
C_df = fair_output['C']
RF_df = fair_output['RF']
T_df = fair_output['T']
alpha_df = fair_output['alpha']

data = {}
unit = {}

data["Atmospheric Concentrations|CO2"] = C_df.loc["CO2"].to_numpy()
If you have dataframes already, there must be a cleaner way to do this...

In src/openscm_runner/adapters/fair2/_run_fair.py https://github.com/openscm/openscm-runner/pull/25#discussion_r501624003:

                                                                       RF_df.loc["CH3Br"].to_numpy() +\

                                                                       RF_df.loc["CH3Cl"].to_numpy()

#data["Effective Radiative Forcing|Aerosols|Direct Effect"] = RF_df.loc["CO2"].to_numpy()
#data["Effective Radiative Forcing|Aerosols"] = RF_df.loc["CO2"].to_numpy()

data["Surface Temperature"] = T_df.to_numpy()
data["Surface Temperature (GMST)"] = T_df.to_numpy() * factors["gmst"]
#data["Airborne Fraction"] = airborne_emissions
#data["Effective Climate Feedback"] = lambda_eff
#data["Heat Content"] = ohc
#data["Heat Content|Ocean"] = ohc * factors["ohu"]
#data["Net Energy Imbalance"] = heatflux
#data["Heat Uptake"] = heatflux * toa_to_joule
#data["Heat Uptake|Ocean"] = heatflux * toa_to_joule * factors["ohu"]

unit["Atmospheric Concentrations|CO2"] = "ppm"
as above, there must be a cleaner way to do this unit handling rather than hard-coding here (I was hoping units would be included in FaIR2.0's pandas interface)

In src/openscm_runner/adapters/fair2/_run_fair.py https://github.com/openscm/openscm-runner/pull/25#discussion_r501624347:

"""

res = []

for cfg in cfgs:

   scenario = cfg.pop("scenario")

   model = cfg.pop("model")

   run_id = cfg.pop("run_id")

   factors = {}

   factors["gmst"] = cfg.pop("gmst_factor")

   factors["ohu"] = cfg.pop("ohu_factor")

   data, unit, nt = _process_output(fair_scm(**cfg), output_vars, factors)

   data_scmrun = []

   variables = []

   units = []

   for key, variable in data.items():

if we keep everything in dataframes, we'll be able to get rid of this loop which will be way quicker
In src/openscm_runner/adapters/fair2/_run_fair.py https://github.com/openscm/openscm-runner/pull/25#discussion_r501624598:

   run_id = cfg.pop("run_id")

   factors = {}

   factors["gmst"] = cfg.pop("gmst_factor")

   factors["ohu"] = cfg.pop("ohu_factor")

   data, unit, nt = _process_output(fair_scm(**cfg), output_vars, factors)

   data_scmrun = []

   variables = []

   units = []

   for key, variable in data.items():

       variables.append(key)

       data_scmrun.append(variable)

       units.append(unit[key])

   tempres = ScmRun(

       np.vstack(data_scmrun).T,

You can pass a dataframe to ScmRun which makes things way quicker, quicker again if you include copy=False
In src/openscm_runner/adapters/fair2/fair2.py https://github.com/openscm/openscm-runner/pull/25#discussion_r501625126:

+import datetime as dt

+import os
+import numpy as np
+import pandas as pd
+from scipy.interpolate import interp1d
+
+from ..constants import molwt
+
+try:

from scmdata import ScmDataFrame, ScmRun
has_scmdata = True
+except ImportError:
has_scmdata = False

+class SSP245WorldEmms:
I would like to remove this class from the fair2 adapter, we shouldn't be doing infilling on the fly (the FaIR1.X solution is a hack solution because we needed it in a hurry). Can we instead either a) throw a warning and fill with zeros or b) throw an error if we don't get the emissions we need or c) fill with zeros silently?
In src/openscm_runner/adapters/fair2/fair2.py https://github.com/openscm/openscm-runner/pull/25#discussion_r501625242:

               continue

           if in_unit != fair_unit:

               ssp_df_hist = ssp_df_hist.convert_unit(fair_unit, variable=variable, context=context)

       self._values_fair_history = ssp_df_hist

   self._loaded_fair_history = True

   return self._values_fair_history

+# TODO: lazy load this and only load once
+ssp245_world_emms_holder = SSP245WorldEmms()
delete
In src/openscm_runner/adapters/fair2/fair2.py https://github.com/openscm/openscm-runner/pull/25#discussion_r501625488:

           if in_unit != fair_unit:

               ssp_df_hist = ssp_df_hist.convert_unit(fair_unit, variable=variable, context=context)

       self._values_fair_history = ssp_df_hist

   self._loaded_fair_history = True

   return self._values_fair_history

+# TODO: lazy load this and only load once
+ssp245_world_emms_holder = SSP245WorldEmms()
+
+
+EMISSIONS_SPECIES_UNITS_CONTEXT = pd.DataFrame((
this should be able to disappear too (again I was hoping the FaIR2.0 pandas interface would be able to handle units conversions)
In src/openscm_runner/adapters/fair2/fair2.py https://github.com/openscm/openscm-runner/pull/25#discussion_r501625549:

   ('|CCl4', 'ktCCl4 / yr', None),

   ('|CH3CCl3', 'ktCH3CCl3 / yr', None),

   ('|HCFC22', 'ktHCFC22 / yr', None),

   ('|HCFC141b', 'ktHCFC141b / yr', None),

   ('|HCFC142b', 'ktHCFC142b / yr', None),

   ('|Halon1211', 'ktHalon1211 / yr', None),

   ('|Halon1202', 'ktHalon1202 / yr', None),

   ('|Halon1301', 'ktHalon1301 / yr', None),

   ('|Halon2402', 'ktHalon2402 / yr', None),

   ('|CH3Br', 'ktCH3Br / yr', None),

   ('|CH3Cl', 'ktCH3Cl / yr', None),

),
columns=["species", "in_unit", "context"],
+)

+def _get_fair_col_unit_context(variable):
delete
In src/openscm_runner/adapters/fair2/fair2.py https://github.com/openscm/openscm-runner/pull/25#discussion_r501625762:

+def _get_fair_col_unit_context(variable):

row = EMISSIONS_SPECIES_UNITS_CONTEXT["species"].apply(lambda x: variable.endswith(x))

in_unit = EMISSIONS_SPECIES_UNITS_CONTEXT[row]["in_unit"]

assert in_unit.shape[0] == 1, in_unit

fair_col = int(row[row].index.values) + 1  # first col is time
in_unit = in_unit.iloc[0]
context = EMISSIONS_SPECIES_UNITS_CONTEXT[row]["context"].iloc[0]

return fair_col, in_unit, context

+def _scmdf_to_emissions_df(scmdf, include_cfcs=True, startyear=1765, endyear=2100):
It would be great to a) test this more thoroughly and b) write it in a much more flexible way than the current implementation
In src/openscm_runner/adapters/fair2/fair2.py https://github.com/openscm/openscm-runner/pull/25#discussion_r501626214:

       raise NotImplementedError("`output_config` not implemented for FaIR")

   fair_df = ScmRun(scenarios.timeseries())

   full_cfgs = self._make_full_cfgs(fair_df, cfgs)

   res = run_fair(full_cfgs, output_variables)

   res["climate_model"] = "FaIRv{}".format(self.get_version())

   return res

def _make_full_cfgs(self, scenarios, cfgs):  # pylint: disable=R0201

   full_cfgs = []

   run_id_block = 0

   for (scenario, model), smdf in tqdm(

       scenarios.timeseries().groupby(["scenario", "model"]),

can be replaced by scenarios.groupby(["scenario", "model"]) I think (and if it can't, scmdata is broken)
In src/openscm_runner/adapters/fair2/fair2.py https://github.com/openscm/openscm-runner/pull/25#discussion_r501626292:

   full_cfgs = self._make_full_cfgs(fair_df, cfgs)

   res = run_fair(full_cfgs, output_variables)

   res["climate_model"] = "FaIRv{}".format(self.get_version())

   return res

def _make_full_cfgs(self, scenarios, cfgs):  # pylint: disable=R0201

   full_cfgs = []

   run_id_block = 0

   for (scenario, model), smdf in tqdm(

       scenarios.timeseries().groupby(["scenario", "model"]),

       desc="Creating FaIR emissions inputs",

   ):

       smdf_in = ScmRun(smdf)

can be removed if the change above is made
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/openscm/openscm-runner/pull/25#pullrequestreview-504653278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQR67PHCCYKO3OSLP3KPH5TSJWKR3ANCNFSM4SIRZJWQ.

Yeah I just wanted to get something written to work from - I suspect part of the difficulty I’m having is due to the ‘hacky’ nature of the FaIR 1.6 version, but once I have a hacky version working (with testing set up to check everything) I can condense it down.

Good strategy (if you can write the tests first it can lead to better outcomes, depends how much of a rush you're in)

You probably also want to rebase this, it'll cause a bit of chaos potentially but needs to be done at some point

As an aside question:

Or, thinking about it more, will it even be possible to install both FaIR1.X and FaIR2 at the same time given their namespace clash?

Could one move FaIR 1.6 to a legacy subdirectory in the FaIR tree and keep it for a while?
from fair.legacy.forward import fair_scm

or
from fair.legacy.forward import fair_scam as fair1_scm

Nor sure if it would work without trouble but most imports should be relative.

Closing as stale, feel free to re-open if you're up and going again.


setIgnoreAttachedBody() not working

I have been trying to use the new setIgnoreAttachedBody() in the 1.4 snapshot and unfortunately it is not working.
light.attachToBody(ground);
light.setIgnoreAttachedBody(true);
System.out.println(light.getIgnoreAttachedBody());

This is returning false and shadows are still being cast on the ground body. I have tried putting setIgnoreAttachedBody() before attachToBody() as well. It appears it will work with a ConeLight but not a DirectionalLight.

Ohh... The Directional light is not a positional light type and thus doesn't support the attaching to the bodies. The methods you have used on DirectionalLight are marked as deprecated with comment that they are not applicable to that light type, so it's not the issue that they are not working...
I don't want to modify them to allow such behavior cause it could be a mess of the same methods doing quite different things. However, I'll think about adding the other specific for DirectionalLight method to make the setIgnoreAttachedBody() work...
Currently, you can achieve the same effect by setting the filters to ignore the ground body using the following method:
dirLight.setContactFilter(...)

Yeah I figured out that it wasn't supported, apologies. But yes would certainly like to request that something similar for them is implemented.

Should be available in next releases :)
/** To disable the body shadow **/
DirectionalLight sun = new DirectionalLight (...);
sun.setIgnoreBody(someBodyToIgnore);

/** To get the ignored body **/
Body ignored = sun.getBody();

/** To disable **/
sun.setIgnoreBody(null);

Thanks a lot!


Page freezes as first few characters entered

It would be nice if the search waited a second for you to type in your query otherwise it starts to lag as it searches for the first few characters which have thousands of results, especially noticeable on a mobile browser!

Thanks for the feedback! Currently the waiting time between input and search is set to 300ms. It may be a good idea to allow for a bit more time, especially for short inputs.

A workaround has been implemented in the PR linked above, and the issue should be addressed fully in #42. I will therefore close this PR. Thanks again for the feedback!


Overlay size settings

Would be nice to have an overlay size slider as well. The max size could be limited by screen size (it's ridiculous tho, but can find its usages).
Original: https://github.com/estorski/langlay/issues/32#issuecomment-204770528

Additional details.
It may be needed to scale the whole overlay, reasons are:

as a user I want to be able to glimpse the current language without paying specific attention to the overlay, that's why I may need a REAL big scale of it;
as a user, I may find the default overlay size too big and too distracting, so I may want to scale its size down.

So the proposition is to add a Scale setting with a slider, from something like 50% to something like 500%.


gnutls: dependency gnutls added

The missing dependency pkgconf has been added. See https://github.com/kiss-community/repo-community/issues/320
Sorry, I forgot to mention that I'm the maintainer. To ease your task, I choosed to close my first PR and to recreate one with
the mention that I'm the maintainer. But github still think it's my first contribution. I don't know why. Probably it's because of my first PR.
Existing package

[x] I am the maintainer of this package.

This change does not require a relver bump

You mean version should stay 3.6.15 2 ?

Yes, reason being that 1) if users already have gnutls installed, they don't need pkgconf, and 2) if they don't have pkgconf installed, they would've never built gnutls.
In general, adding a make depend wouldn't require a rebuild (primary case would be if foo were being built statically, and not including bar leaves out features) - since pkgconf just acts to help find dependencies, it serves no actual purpose for gnutls outside of building it.

That makes sense, thank you for this explanation! :+1:
Change done.


Fix for https protocol detection, and extended nginx tests

This PR contains a fix that performs checking for the MSG_PEEK flag on *recv-type functions. With this change, when the MSG_PEEK flag is set, AppScope will still call the libc functions interposed, but will no longer process the data captured in the buffer.
The downstream effect of this is that data is not processed more than once by AppScope due to an application (i.e. nginx) "peeking" at network buffer contents. This will allow things like protocol detection to function properly.
*We now perform checking for the MSG_PEEK flag in our interpositions of:

recvfrom
recvfrom_chk
recv
recv_chk
recvmsg
recvmmsg

Tests
Integration tests have been updated for nginx. Previously, there was an integration test that ran with the python test-runner app, that ran nginx and checked for the presence of net.tx and net.rx metrics.
Now, we have 4 new tests implemented in a bash script:

http1.1 plain
http1.1 tls
http2 plain
http2 tls

...with each test checking for the presence of all expected events and metrics (including http.req and http.resp events)
Closes #1017

I agree with @michalbiesek's comment above, but have no other comments.  When you've addressed his comment, feel free to merge away!


Update main.py

After downloading, the file name will be generated by AI (book title)

Code required two minor changes:
"self.title" could conflict with variable title used later in code, so it was changed to "self.book_title" for clarity.
Book title should only be added to the markdown content when the level = 1, since the function is recursive. Otherwise, duplicate book titles appear.

This feature is useful. It is now fully functional and will be merged.


Only war enhanced update/bugfix

Changes / Comments
-removed obsolete TODO or "coming up" lines
-ChtiKenny's hit counter (but different)
-Psykana rolls improved under the hood
-vehicle ranged weapons can switch stat used for shooting
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


feat: 支持 surname head 模式

close #237

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (83ad56e) to head (fc2047b).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main      #238   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           23        23
  Lines        13176     13211   +35
  Branches       417       424    +7
=========================================
+ Hits         13176     13211   +35

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fixed a suspected typo.

Changed the word process to possess.

Hi @wrightadrian, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, DNFBOT;

:shipit:

Thanks! 5177bd994834bb60a8c75f9bdd6a445c40c4a004


Nextjs 14.1 - Images not working

Reproduction repo: https://github.com/raducostea/opennext-sst-test
Images not working, getting
Cannot read properties of undefined (reading '0')
Deployed url:
https://d249bqopbtxz5m.cloudfront.net/
Image url: https://d249bqopbtxz5m.cloudfront.net/_next/image?url=%2Fimage.png&w=3840&q=75
Image Path: https://d249bqopbtxz5m.cloudfront.net/image.png
NextJs version: 14.1.1
SST version: 2.40.6

Missed https://github.com/sst/open-next/issues/374


WIP: Run tests with cert-manager 1.16.0-beta.0

Replaced by https://github.com/cert-manager/google-cas-issuer/pull/212


The sharable link is not getting copied when the user clicks on "Copy Application URL".

Create an application
On the top right, click on “Share”
Click on “Copy Application URL” on the Pop-Up.
Observe - The link is not copied

This is not reproducible, can you please share a video?


Vendoring latlong with godep

I'm trying to vendor latlong dependencies with Godeps. But when I run
$ godep save

I get the following error message:
godep: Godeps/_workspace/src/github.com/bradfitz/latlong/z_gen_tables.go:23:18: expected '}', found 'EOF'

Godep is truncating data, probably because the line being truncated is longer than 64k. If I'm right I may have a fix soon.

This should now be fixed by #231, so please go get -u github.com/tools/godep and re-open if this is still a problem (PS: You may need to cleanup your broken workspace first).


Issue40 - YT videos playing without giving responding to the Cookie consent Manager - Modifying embed block

…te YT Block
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fixes #40
Test URLs:

Original: https://www.sunstar-foundation.org/_drafts/meet/episode-1-draft-v1

Before: https://main--sunstar-foundation--sunstar-foundation.hlx.page/_drafts/meet/episode-1-draft-v1

After: https://issue40-yt-consent-v1--sunstar-foundation--sunstar-foundation.hlx.page/_drafts/meet/episode-1-draft-v1

[ ] New Blocks introduced in this PR
If yes, please provide details below

Block Name
Documentation

For e.g. cards
doc-link

[ ] New variations introduced in this PR

Variation Name
Documentation

For e.g. cards (grid)
doc-link

No need to -

First have a word file with embed block under fragments/modals/videos.
And then placing the URL & image int another block - YT-Videos

Simply enter the YT Video and the image under embed block - thats it. cc @ehrro


Analyze performance microbenchmarks

We need to analyze performance microbenchmark test results and identify areas that can be improved to meet release goals for EF7.

Clicked the wrong button

We have coverage and we are working thru improvements for areas that need work


az resource delete --resource-group $ResourceGroupName --ids $azCliIds fails

I'm trying to use delete command of az cli and pass it a list of ids built by powershell
This is the code
  $AzureResources = (az resource list --resource-group $ResourceGroupName | ConvertFrom-Json).where({ $_.name.contains($AzureResourcePrefix) })

  $ids = $AzureResources.ForEach({$_.id})
  $azCliIds = ""
  foreach ($id in $ids) {
    $azCliIds += $id + ' '
  }

  $azCliIds = $azCliIds.TrimEnd()

  az resource delete --resource-group $ResourceGroupName --ids $azCliIds --debug

I get this error
cli.azure.cli.command_modules.resource.custom: (ResourceNotFound) The Resource 'Microsoft.Web/serverFarms/xxxx-asp-rad-we ' under resource group 'xxx-rad-rg' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
Code: ResourceNotFound
Message: The Resource 'Microsoft.Web/serverFarms/pltfrm-asp-rad-we ' under resource group 'pltfrm-rad-rg' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix

The error is wrong because the ids are built from az itself.
If I take literally paste the results of $azCliIds then it works fine, i.e.
az resource delete --resource-group $ResourceGroupName --ids /subscriptions/xxxxxxxxxxxxxxx/resourceGroups/xxxxx-rad-rg/providers/Microsoft.Web/serverFarms/pltfrm-asp-rad-we /subscriptions/xxxxxxxxxxxxxxx/resourceGroups/pltfrm-rad-rg/providers/Microsoft.Web/sites/xxxx-wa-ocelot-rad-we /subscriptions/xxxxxxxxxxxxxxxxx/resourceGroups/pltfrm-rad-rg/providers/Microsoft.Web/sites/xxxxxx-wa-ocelot-rad-we/slots/slot1 --debug

It appears if ids contain any type of quote around it the cli doesn't like it.
If $azCliIds contains a single item then it works as well

@zhoxing-ms for awareness


Program Error Reorganization

reorganized every module's functions

program runs in distinct stages
stages run in distinct sub-stages
sub-stage errors are caught
each stage can be run independently
no information is lost

updated config to settings
updated settings structure
moved paths to settings
updated paths.yaml
updated examples
updated documentation
added catalogs
added histograms

TODO : test cataloguing on new, missing, and changed filters

LGTM!


Not to call IO#truncate to avoid too many IO flush

Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
IO#truncate call IO#flush internally. this cause heavy IO in case file buffer of fluentd.
so I change file buffer metadata format not to call IO#truncate.
Docs Changes:
Release Note*:
same as title.

Good.


Renew the application certificate for ODL Video production

The application certificate is expiring in 30 days so we need to get it renewed and updated.

The app cert is also being used on the discussions app. Generated csr and sent in request.

This has been updated on both apps.


Add PackedDataContainer data pointer check for non nullable

Fixes #46019.
In this class is 4 calls of data.read - two of them has been already protected, there are two more which one now have checking.

The same fix should also be done in the master branch (core/io/packed_data_container.cpp).

Thanks!

Cherry-picked for 3.3.1.


Custom Role Icon server boosting promo

Couldn't find a selector for this that doesn't use :has, but just hide the "Learn more" button

Closest i can get is this:
[class*="popoutContainer-"] > [class*="ctaButton-"]{
	display: none !important;
}

Let's hope ctaButton is not used anywhere else

For when we get Electron v21.0.0 in discord
button[class^=ctaButton]:has(div>svg[class^=boosterBadge]) {
  display: none;
}