Help needed to upload file using API

Not been able to upload files. I'm always getting an error message that says:
Fatal error</b>:  Uncaught exception 'Humantech\Zoho\Recruit\Api\Client\HttpApiException' with message 'Problem occured while processing the request' in .../vendor/humantech/zoho-recruit-api/src/Formatter/AbstractFormatter.php:128

Hey @rogeriotaques, first of all, my apologies for the delay in getting back to you. =/
Well, I'm a core member of this project anymore since I leave this company a few years ago. However, you can try to be in touch with @rluders, @tewald or @basask to try to solve your issue. If I need to support you guys with something just let me know.

Hi, @jpcercal! Thanks for letting me know. It was a few time ago already, but I have fixed it somehow. :) Cheers.

Hi. So, I think that this library is deprecated.

Thanks for answering @rluders. Any replacement for that library or it was just discontinued?

@rogeriotaques I think this will be just discontinued, but I'm not at the development team anymore.

@rluders thanks for the feedback! No worries.


SHOWCASE - TACTON

Temporary PR for showcasing tacton feature.

The used Tacton REST API is currently not working so no demo server is currently deployed.


fixed crop functions

TLDR: parLapply wasn't efficient on memory usage (that's why it was very visible in the monitoring interface)
foreach is the way to go.
Fixed the crop functions and generated the data


bug: Chips without reason are visible

Bug Definition
The Tweet placeholder chips are not filtering empty reasons
-- Please add discord contact information
** discord username: @isaozler#4498 **
## Bug environment
Describe the environment produces the bug:
afetharita.com
Describe how you are producing the bug step by step

Select a social media event in the filters
Click event with ID 769353
Bug appears, you can see the empty chip

Expected Behaviour
The expected behavior here is to hide the chip
Screenshots

i will handle this issue

components/UI/Drawer/components/channels/twitter/PlaceholderTweet.tsx

We tested we didn't encounter any problem you have mentioned. Also both prod and rc seem just fine. Congrats 👏


cancelled jobs do not stop main/run container

opening this issue as recommended by @toote in https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/pull/386#issuecomment-1536929277
some explanation about what is going on

First, when the job was cancelled as the agent running the job will send the whole process stack a stopping and then a termination signal.

the process group receives a SIGTERM immediately (SIGTSTP is never used):
https://github.com/buildkite/agent/blob/b9d4efd1/bootstrap/bootstrap.go#L118
https://github.com/buildkite/agent/blob/b9d4efd1/process/signal.go#L36

The main container should have received that and stopped itself then.

unfortunately, the process group that is signalled is bash, because that is what is running here https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/blob/7d2363cb0c228af195374e0c81b4f9dee649ab62/commands/run.sh#L426. bash creates a new process group for each command run, so the docker compose run ... process never receives any signal and never stops
$ bash
$ echo $$
33366
$ sleep 1000

$ pstree -p 33366
bash(33366)───sleep(34280)
$ kill 33366 # nothing happens
$ kill -- -33366 # nothing happens; this is equivalent to the above because sleep is in its own process group
$ kill -s KILL -- -33366 # bash exits
$ ps x | grep 34280
34280 pts/2    S      0:00 sleep 1000

you can see here that even though the bash process group was sent a SIGKILL, sleep is still running. you can see the process group behavior of bash with ps o pid,pgid,sid | grep 34280
so the agent is never able to stop the main/run container when using docker-compose-buildkite-plugin

If that was not enough, the code just above the lines you added should have also taken care of it by killing all containers associated to the project itself (the main container is part of the project as well).

this I don't have a good understanding of. I agree that that is what should be happening, but that is not what we are seeing, which is why running against my PR causes docker ps to output a container ID and why you see docker stop in the logs (in my PR's description)

@raylu thanks a lot for all the context!
How bash is run and the signals being used indeed have a lot to do with expected and actual behaviours. According to bash documentation:

When bash is interactive, in the absence of any traps, it ignores SIGTERM (so that kill 0 does not kill an interactive shell), and SIGINT is caught and handled (so that the wait builtin is interruptible).

As you correctly pointed out, SIGTERM is sent by the agent when a job is cancelled and the comment you pointed out does indicate that SIGINT would be a better one to use. If you want to test that behaviour, the signal to use can also be changed as an agent configuration.

you can see here that even though the bash process group was sent a SIGKILL, sleep is still running. you can see the process group behavior of bash with ps o pid,pgid,sid | grep 34280

This is quite interesting, but not sure what can be done about this as SIGKILL can not be trapped or reviewed. Behaviour for SIGKILL is completely outside the purview of this plugin.
Combining the previous two comments, an alternative that can actually be implemented in this plugin would be to add a trap on SIGTERM and do the cleanup or at least print out a message. Unfortunately, not only I'm not sure what else could be done that is not being done in the pre-exit hook cleanup already; but also, the cleanup itself would be highly dependent on the signal handling processes inside the docker containers being run (and their configurations).
Which leads me to...

If that was not enough, the code just above the lines you added should have also taken care of it by killing all containers associated to the project itself (the main container is part of the project as well).

this I don't have a good understanding of. I agree that that is what should be happening, but that is not what we are seeing, which is why running against my PR causes docker ps to output a container ID and why you see docker stop in the logs (in my PR's description)

The pre-exit hook runs docker stop or docker kill (depending on the graceful-shutdown plugin configuration) on all containers in the project corresponding to the current build. From the docker documentation on stop and kill they do what we expect them to do: send signals to the processes running inside the containers to handle and do what they see fit. What the related PR does is just send the signals a second time to the containers that are still left running around. If that is having an effect that the first round did not have, it points to an issue with your main container and how it is handling signals in the first place; I don't think that sending signals multiple times should be an expected behaviour.
In conclusion, it is my opinion that:

the command hook should add a SIGTERM handler to at least print out a message
your main app container is not handling signals correctly and needs further investigation/troubleshooting

When bash is interactive, in the absence of any traps, it ignores SIGTERM (so that kill 0 does not kill an interactive shell), and SIGINT is caught and handled (so that the wait builtin is interruptible).

SIGINT would be a better one to use. If you want to test that behaviour, the signal to use can also be changed as an agent configuration.

ah! though I don't think SIGINT would change anything if we're not stopping on a SIGTERM

you can see here that even though the bash process group was sent a SIGKILL, sleep is still running. you can see the process group behavior of bash with ps o pid,pgid,sid | grep 34280

This is quite interesting, but not sure what can be done about this as SIGKILL can not be trapped or reviewed. Behaviour for SIGKILL is completely outside the purview of this plugin.

oh the SIGKILL is just for demonstration. I don't think either the agent nor this plugin is managing to get a SIGKILL through to run.sh right now. but anyway, my testing in an interactive shell was wrong and the SIGTERM might be forwarded to docker compose run

The pre-exit hook runs docker stop or docker kill (depending on the graceful-shutdown plugin configuration) on all containers in the project corresponding to the current build. From the docker documentation on stop and kill they do what we expect them to do: send signals to the processes running inside the containers to handle and do what they see fit. What the related PR does is just send the signals a second time to the containers that are still left running around. If that is having an effect that the first round did not have, it points to an issue with your main container and how it is handling signals in the first place; I don't think that sending signals multiple times should be an expected behaviour.

we're not setting GRACEFUL_SHUTDOWN so it defaults to false so we're going straight to SIGKILL. kill can't be handled, so the issue isn't signal handling of our container
the problem is that our main container isn't even being picked up by docker compose kill. we define a docker-compose.yml with 6 containers and tell the agent to run one called "tests" that depends on the other 5. in cleanup, we see the 5 getting killed but not "tests". only with my change do we see the 6th "tests" conatiner being sent anything

@raylu I tested with the following docker compose file:
services:
  app:
    image: bash:5.2.15
    depends_on:
      - dep1
      - dep2
      - dep3
      - dep4
      - dep5
  dep1:
    image: bash:5.2.15
    command: sleep 10000
  dep2:
    image: bash:5.2.15
    command: sleep 10000
  dep3:
    image: bash:5.2.15
    command: sleep 10000
  dep4:
    image: bash:5.2.15
    command: sleep 10000
  dep5:
    image: bash:5.2.15
    command: sleep 10000

and a very simple pipeline:
steps:
  - label: test
    command: sleep 1000
    plugins:
      - docker-compose#v4.12.0:
          run: app
          config: compose.yaml

The sleep commands all over the place are to make sure that containers are up and running for me to debug things and using bash all around. And, after playing around for quite a while I found that we were both right.

your main container is not handling the cancellation signal correctly

When I cancel the job running I always get the following line in my logs:
# Received cancellation signal, interrupting
--
  | ERROR: 2
  | 🚨 Error: The command exited with status -1

Which means that the process group received the signal and the docker-compose run command exited with an error, which caused the command hook to print out the message. The fact that you are not seeing that message, is evidence that your container is swallowing up whatever signal is being sent to the process group and not doing anything with it.
Needless to say, a lot more investigation on this matter needs to happen, but it is probably outside the scope of this plugin.... except for:

docker compose does not kill the main run container

Just as you are experiencing, if the main container does not stop correctly it will not be stopped nor killed by the cleanup script in the pre-exit hook. While this should not happen as the main container should exit when the job is cancelled, I do believe this to be an oversight and a bug with the current implementation of the plugin.
From my investigations this bug stems from the fact that docker compose does not consider a container started with docker compose run as part of the services so no command will interact with it whatsoever :( Thus explaining why it is not stopped nor killed in the hook as I assumed it would.
Your PR does work for your particular case, but I have a few concerns with it that I'll address in my review of it :)

ah, thanks for doing the test (and reviewing my PR)! I was thinking of doing a similar test, so this definitely saved me some time
I don't think your "app" container is handling SIGTERM. you're not setting init: true so sleep is pid 1, which doesn't get any default signal handlers. you can see this by running it and then trying to docker stop the_container_id. it hangs for 10 seconds before exiting (because docker sends SIGTERM, waits 10 seconds, then SIGKILL)
I actually don't think sending a foregrounded compose process a SIGTERM does anything to the container, even if it handles SIGTERM:
$ docker compose version
Docker Compose version v2.3.3

$ cat test.yml
services:
  app:
    image: bash:5.2.15
    init: true

$ docker compose -f test.yml run app sleep 1000

$ ps x | grep docker
81253 pts/2    Sl+    0:00 /home/aurelia/.docker/cli-plugins/docker-compose compose -f test.yml run app sleep 1000

$ kill 81253 # I get my prompt back in the other shell

$ docker ps -a
CONTAINER ID   IMAGE       COMMAND                  CREATED          STATUS
eb155123e696   bash:5.2.15 "docker-entrypoint.s…"   32 seconds ago   Up 31 seconds

so even after sending my compose run a SIGTERM and watching it exit, the container is still running. I'm not sure why this happens; my reading of the code is compose run is just docker start without --detach by default
https://github.com/docker/compose/blob/0c1a691fa5b9b4a68ae00bf9d4b5120a1e2b87b4/cmd/compose/run.go#L246
https://github.com/docker/compose/blob/0c1a691fa5b9b4a68ae00bf9d4b5120a1e2b87b4/pkg/compose/run.go#L38
so it should forward signals. maybe there's something wrong with my test setup
it also looked to us like our tests were stopping when we cancelled a pipeline because the buildkite web interface stopped showing output. but our code spends 10+ minutes running tests and then uploads artifacts (via buildkite-agent artifact upload <path>). we noticed this problem when we saw that halfway through tests, we could cancel and then, a few minutes later, we'd still see the artifacts get uploaded

I will review what you are saying. Note, though, that the way the plugin works with the pipeline and setup I mentioned the sleep command is not pid 1 because it is run through a shell with /bin/sh -e -c 'sleep 1000'. The actual command in the log is docker-compose -f compose.yaml -p $PROJECT run --name $NAME --label $LOTSALABELS --rm app /bin/sh -e -c 'sleep 1000'. So /bin/sh is actually pid 1 and sleep a subchild and the signal appears to be handled correctly because it is not an interactive session.
The exact details on the process tree are a moot point because they do not reflect your particular scenario, they are just a basis for my experiment to understand the whole situation. They do point out, though, that the agent is sending the signal to the docker compose run process as it should and when it is handled, the container exits and an error is printed out by the plugin hook. Which was my original point: in your original bug report there is no such message, which means that the signal sent to the docker compose run process is getting swallowed up and ignored.

So /bin/sh is actually pid 1 and sleep a subchild and the signal appears to be handled correctly

I don't think so: https://github.com/mirror/busybox/blob/1_35_0/shell/ash.c#L10532-L10534
$ docker compose -f test.yml run --rm app /bin/sh -e -c 'sleep 1000'

$ docker ps
CONTAINER ID   IMAGE         COMMAND                  CREATED         STATUS
3de6714090a4   bash:5.2.15   "docker-entrypoint.s…"   3 seconds ago   Up 2 seconds

$  docker exec -it 3de6714090a4 ps x
PID   USER     TIME  COMMAND
    1 root      0:00 sleep 1000
[...]

$ docker stop 3de6714090a4 # hangs for 10 seconds before SIGKILL-ing

the agent is sending the signal to the docker compose run process as it should and when it is handled, the container exits and an error is printed out by the plugin hook.

the agent is signalling docker compose run, which exits with an error printed out by the plugin hook. however, no signal is ever sent to the container and it continues running. you can see this in my test above where directly signalling docker compose run leaves the container up. changing the test to some container with buildkite-agent installed and running sleep 30 && echo hello > /tmp/hello && buildkite-agent artifact upload /tmp/hello will hopefully show the same behavior we're seeing

@raylu this issue was closed automatically due to merging the corresponding PR, but feel free to either re-open it or continue the discussion on the underlying issue :)

| ⠿ Container buildkite0188080e66054253ab6ce4b3e3877dec_tests_build_287311  Error while Removing 0.7s
  | Error response from daemon: removal of container 2cbf7301d12f1cac79ca2e69da1d494d7b2d1c2863222487b3b5470d1695d455 is already in progress

@raylu from my understanding this would point out that the docker compose command is still "processing" the original stopping signal, but I could be wrong and am really interested in whatever your investigation turns up

We have continued to run some tests here and it would appear that there is indeed an issue where the signal is not being passed on correctly. So I'll reopen this bug and we'll take another look into it

so I looked through old builds that got cancelled and found something very interesting
all of our cancelled builds before 2023-01-31 have the behavior toote saw where ERROR: 2 gets logged and no artifacts are uploaded
all of the ones after that don't log that and artifacts get uploaded
on 2023-01-31, we upgraded elastic-ci-stack-for-aws from v5.11.0 to v5.16.1
v5.12.0 added docker compose v2: https://github.com/buildkite/elastic-ci-stack-for-aws/blob/master/CHANGELOG.md#v5120-2022-11-08
the old builds that cancelled successfully run docker-compose -f ...
the new builds that don't run docker compose -f ...
armed with this knowledge, I tried
$ cat test.yml
version: '3'
services:
  app:
    image: bash:5.2.15

$ docker-compose -f test.yml run --rm app sleep 1000

I had to add version and get rid of init since v1 doesn't support that. then, sending SIGTERM to the docker-compose run process does nothing for 10 seconds (since sleep isn't handling the signal) and then the container exits!

@raylu sorry for the delay but I think I have finally found a satisfying solution to this issue. I have created PR #392 adding signal handling to the command hook so that the main container is stopped appropriately.

I don't think this changes anything, but upstream claims to have fixed the underlying issue https://github.com/docker/compose/issues/10586
older versions of docker compose v2 will still have the problem though, so you probably still want your fix

actually, the PR I created changes 2 things:
1- it guarantees that the container will receive a stopping signal with a default plugin configuration.
Without the change the behaviour will be that the container will still be running and gets killed in the pre-exit hook (as per our latest changes) or stopped if you enable the graceful-termination option instead.
2- as this happens during the command step, its output will be visible in the step's build


Info graphic on Forecast tab needs to be brought forward

Describe the bug
When clicking the Info icon on the Forecast tab, the graphic is obscured by the other elements on the page.
To Reproduce
Steps to reproduce the behavior:

Open the report
Click on Forecast tab
Click on Info icon
Note bubbles are obscured by other elements on the report

Expected behavior
Info graphic is readable and not obscured by other elements.
Screenshots

Desktop (please complete the following information):

OS: Windows 11
Browser: Edge
Version: 126.0.2592.102

Thanks! This should now be fixed :)


Update Unit Testing Samples

aspnet1 feed is added to NuGet.config temporarily
final dotnet-test-xunit version is not determined

Hi @troydai, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

/cc @danroth27 @Rick-Anderson

:shipit:


Remove attrPrefix and run the expected check attrs

When my PR #4 was merged, I noticed that a build broke for my client repo, in which I was setting "attrPrefix". And I realised that either the intention of "attrPrefix" and the "githubActions.checks" attribute are not clear, or there was an error.
Specifically, I was setting attrPrefix to "", and then the generation Actions yml file was building .#${{matrix.attr}}, so it was trying to build .#x86_64-linux.emacs-24-3, for example, and of course that attribute doesn't exist. But what I expected, and what I think you probably planned, was that the githubActions.checks attribute is used both to generate the matrix, and to run those checks later. After all, I can't see why we'd look in one place for checks to run, and then look them up in a different place later — or perhaps I'm missing something.
Anyway, this suggested change makes everything match up: there's no longer an attrPrefix, and the Action steps run .#githubActions.checks.${{matrix.attr}}.
(Related to #4 and #7.)

Reading through the discussion in #4 I am wondering if the (full and uncofigurable) output path for the checks should be: .#githubActions.${{matrix.attr}} instead, dropping the checks part fully.

Tbh, in the end I rolled my own code for this, because the nix snippet with my own preferences is pretty trivial: it's the YAML workflow incantation for generating the matrix that's the tricky bit, and including this repo doesn't really help with that directly.

I am considering doing the same, since it is so little code and the workflow yaml must be copied over anyway (and kept in sync with potential changes to mkGithubMatrix, like in this PR).


Lint project template :sparkles: :cake: :sparkles:

Description
(hookshot) BOS-178551-C02X31K9JHD4:hookshot deepyaman$ kedro lint
2020-05-31 21:49:59,406 - blib2to3.pgen2.driver - INFO - Generating grammar tables from /anaconda3/envs/hookshot/lib/python3.8/site-packages/blib2to3/Grammar.txt
2020-05-31 21:49:59,437 - blib2to3.pgen2.driver - INFO - Writing grammar tables to /Users/deepyaman/.cache/black/19.10b0/Grammar3.8.3.final.0.pickle
2020-05-31 21:49:59,437 - blib2to3.pgen2.driver - INFO - Writing failed: [Errno 2] No such file or directory: '/Users/deepyaman/.cache/black/19.10b0/tmpjv92vcp_'
2020-05-31 21:49:59,437 - blib2to3.pgen2.driver - INFO - Generating grammar tables from /anaconda3/envs/hookshot/lib/python3.8/site-packages/blib2to3/PatternGrammar.txt
2020-05-31 21:49:59,441 - blib2to3.pgen2.driver - INFO - Writing grammar tables to /Users/deepyaman/.cache/black/19.10b0/PatternGrammar3.8.3.final.0.pickle
2020-05-31 21:49:59,441 - blib2to3.pgen2.driver - INFO - Writing failed: [Errno 2] No such file or directory: '/Users/deepyaman/.cache/black/19.10b0/tmpmb821hzj'
/anaconda3/envs/hookshot/bin/python -m black /Users/deepyaman/hookshot/src/tests /Users/deepyaman/hookshot/src/hookshot
reformatted /Users/deepyaman/hookshot/src/hookshot/run.py
All done! ✨ 🍰 ✨
1 file reformatted, 13 files left unchanged.
/anaconda3/envs/hookshot/bin/python -m flake8 --max-line-length=88 /Users/deepyaman/hookshot/src/tests /Users/deepyaman/hookshot/src/hookshot
/anaconda3/envs/hookshot/bin/python -m isort -rc -tc -up -fgw=0 -m=3 -w=88 /Users/deepyaman/hookshot/src/tests /Users/deepyaman/hookshot/src/hookshot
Fixing /Users/deepyaman/hookshot/src/tests/test_run.py
Fixing /Users/deepyaman/hookshot/src/hookshot/run.py
(hookshot) BOS-178551-C02X31K9JHD4:hookshot deepyaman$ git diff
diff --git a/src/hookshot/run.py b/src/hookshot/run.py
index 6d0b78d..6fd5c60 100644
--- a/src/hookshot/run.py
+++ b/src/hookshot/run.py
@@ -30,10 +30,12 @@
 from pathlib import Path
 from typing import Dict

-from hookshot.pipeline import create_pipelines
 from kedro.framework.context import KedroContext, load_package_context
 from kedro.pipeline import Pipeline

+from hookshot.pipeline import create_pipelines
+
+
 class ProjectContext(KedroContext):
     """Users can override the remaining methods from the parent class here,
     or create new ones (e.g. as required by plugins)
@@ -52,8 +54,7 @@ def run_package():
     # Entry point for running a Kedro project packaged with `kedro package`
     # using `python -m <project_package>.run` command.
     project_context = load_package_context(
-        project_path=Path.cwd(),
-        package_name=Path(__file__).resolve().parent.name
+        project_path=Path.cwd(), package_name=Path(__file__).resolve().parent.name
     )
     project_context.run()

diff --git a/src/tests/test_run.py b/src/tests/test_run.py
index 551ab8e..050cfd5 100644
--- a/src/tests/test_run.py
+++ b/src/tests/test_run.py
@@ -38,6 +38,7 @@ To run the tests, run ``kedro test``.
 from pathlib import Path

 import pytest
+
 from hookshot.run import ProjectContext

(hookshot) BOS-178551-C02X31K9JHD4:hookshot deepyaman$

Development notes

Checklist

[x] Read the contributing guidelines
[x] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added a description of this change and added my name to the list of supporting contributions in the RELEASE.md file
[ ] Added tests to cover my changes

Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Thank you! 🙌 I thought we had a test to lint the sample project somewhere in our codebase to protect us from this. 🤔

I thought so too...

Thank you! 🙌 I thought we had a test to lint the sample project somewhere in our codebase to protect us from this. 🤔

I thought so too...
edit: Found it! https://github.com/quantumblacklabs/kedro/blob/develop/features/test.feature#L41-L43 Let me see...

I think it's because we don't report the proper exit codes on kedro lint, need to add it to the backlog - unless you want to take it on?

Thank you! 🙌 I thought we had a test to lint the sample project somewhere in our codebase to protect us from this. 🤔

I thought so too...
edit: Found it! https://github.com/quantumblacklabs/kedro/blob/develop/features/test.feature#L41-L43 Let me see...

I think it's because we don't report the proper exit codes on kedro lint, need to add it to the backlog - unless you want to take it on?

I can try and take a look later this week. :)


Added defaultValue to Property

This is based on top of https://github.com/dart-lang/gcloud/pull/81 so feel free to ignore the first commit. It was just necessary for tests to have a change at passing.

I guess a possible downside is that this won't work well with indexing... Maybe we should force indexed: false when defaultValues are given.

/CC @isoos, I think we can do defaultValue, but I'm realizing it could be a foot gun, if users expects to be able to query properties with a default value... So maybe we shouldn't add it anyways?

I think it is still useful. We could provide a small utility class to scan the db and backfill properties without the set value.

@jonasfj – very stale, no?

Yeah, maybe one day we can revive it. But I think we should spend energy moving away from dart:mirrors before we add more features to datastore wrappers.


New package: particleMDI v0.1.0

Registering package: particleMDI
Repository: https://github.com/nathancunn/particleMDI.jl
Created by: @nathancunn
Version: v0.1.0
Commit: 07fb8dae5a0a7fb8751753ae04606bb7a7e2a49c
Reviewed by: @nathancunn
Reference: https://github.com/nathancunn/particleMDI.jl/issues/1

Needs some compat entries, at least on Julia itself.

Usually package names are uppercase, perhaps ParticleMDI?

That would be much more idiomatic for the Julia ecosystem. Note also that the name of the module in the package and the corresponding file names will need to have matching case in order to work.

#1461


⚠ Thumbnails API Endpoint has degraded performance

In d714142, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 3426 ms

Resolved: Thumbnails API Endpoint performance has improved in b0c452a after 3 minutes.


fix: Delete DEPRECATED ses_smtp_password in iam-user.

Description
iam-user's output ses_smtp_password is cannot access error.
Error: Unsupported attribute

  on .terraform/modules/iam_user_test/modules/iam-user/outputs.tf line 63, in output "this_iam_access_key_ses_smtp_password":
  63:       aws_iam_access_key.this.*.ses_smtp_password,

This object does not have an attribute named "ses_smtp_password".

Motivation and Context
Cannot create iam-user.
Breaking Changes

How Has This Been Tested?

#89

Thanks, @kty1965 !
v2.14.0 has been just released.


Updated CLI to use Salt 3005

Tested on both Focal and Jammy, no issues. Updated version to 1.0.0 to follow semantic versioning, however feel free to change it to whatever you need!

Great. Merging, will create a release shortly.


Feature request: handle overlapping annotations

I would love it if overlapping annotations could be handled though this would require substantial changes to annotation

Hmmm... yeah, that's a tough one API-wise. Any thoughts on how the API should look?

The way that would be most natural to me is if annotations could be nested
lowest_level_annotation_tuple = ("is", "verb", "#8ef")
overlapping_annotation = (["This", lowest_level_annotation_tuple, "annotated"], "example", "#afa")

So annotations could be constructed from a list of space separated tokens and annotations instead of just constructing them from strings.
I know it complicates things quite a bit but would be nice for my use case!


API limit

Describe the bug
A clear and concise description of what the bug is.
Sometimes when running this action, I get rate limited. I already have set the matrix to only 2 parallel jobs. I will switch to 1, but it would be nice if the action had a retry option to try again after a certain number of seconds or something.
Warning: Failed replicating files for this repo: Error: Unable to create a PR: GraphqlResponseError: Request failed due to following response errors:
 - was submitted too quickly

How to Reproduce
Steps to reproduce the issue. Attach all resources that can help us understand the issue:

Screenshots
Link to GitHub repository with project that has issues: https://github.com/LizardByte/.github/actions/runs/2767626170
Files that can help reproduce the issue, like your AsyncAPI file, either paste inside the issue in a code block or in a sharable gist

name: Global replicator

on:
  push:
    branches: [master]
    paths:
      - ".github/**"
      - "dependabot/**"
      - "gitignore/**"
  workflow_dispatch:
    inputs:
      repo_name:
        description: |
          You can specify the repository's name where workflows should be pushed manually, as long as workflow settings do not ignore the repository.
          If you do not specify the exact repository name, the workflow will try to replicate all missing changes to all repositories.
        required: false

jobs:
  replicate:
    runs-on: ubuntu-latest

    strategy:
      fail-fast: false  # false to run all, true to fail entire job if any fail
      max-parallel: 2  # jobs fail submitting PRs if run too fast
      matrix:
        include:
        - job_name: 'replicate workflows'
          patterns_to_ignore: ''
          patterns_to_include: '.github/label-actions.yml,.github/pr_release_template.md,.github/workflows/auto-create-pr.yml,.github/workflows/automerge.yml,.github/workflows/autoupdate.yml,.github/workflows/issues.yml,.github/workflows/issues-stale.yml,.github/workflows/pull-requests.yml'
          commit_message: 'ci: update global workflows'
          repos_to_ignore: ''
          topics_to_include: ''
          exclude_private: false
          exclude_forked: true
          branches: '^nightly$'
          destination: ''
        - job_name: 'replicate dependabot'
          patterns_to_ignore: ''
          patterns_to_include: 'dependabot/dependabot.yml'
          commit_message: 'ci: update dependabot'
          repos_to_ignore: ''
          topics_to_include: ''
          exclude_private: false
          exclude_forked: true
          branches: '^nightly$'
          destination: '.github'
        - job_name: 'replicate python'
          patterns_to_ignore: ''
          patterns_to_include: '.flake8,.github/workflows/python-flake8.yml'
          commit_message: 'ci: update global python'
          repos_to_ignore: ''
          topics_to_include: 'python'
          exclude_private: false
          exclude_forked: true
          branches: '^nightly$'
          destination: ''
        - job_name: 'replicate docker'
          patterns_to_ignore: ''
          patterns_to_include: '.github/ci-docker.yml'
          commit_message: 'ci: update global docker'
          repos_to_ignore: ''
          topics_to_include: 'docker'
          exclude_private: false
          exclude_forked: true
          branches: '^nightly$'
          destination: ''
        - job_name: 'replicate cpp'
          patterns_to_ignore: ''
          patterns_to_include: '.clang-format,.github/workflows_extra/cpp-clang-format-lint.yml'
          commit_message: 'ci: update global cpp'
          repos_to_ignore: ''
          topics_to_include: 'cpp'
          exclude_private: false
          exclude_forked: true
          branches: '^nightly$'
          destination: ''
        - job_name: 'custom issues'
          patterns_to_ignore: ''
          patterns_to_include: '.github/ISSUE_TEMPLATE/config.yml'
          commit_message: 'ci: update issue templates'
          repos_to_ignore: ''
          topics_to_include: 'replicator-custom-issues'
          exclude_private: false
          exclude_forked: true
          branches: '^nightly$'
          destination: ''
        - job_name: 'release notifier'
          patterns_to_ignore: ''
          patterns_to_include: '.github/workflows/release-notifier.yml'
          commit_message: 'ci: update release notifier'
          repos_to_ignore: ''
          topics_to_include: 'replicator-release-notifications'
          exclude_private: false
          exclude_forked: true
          branches: '^nightly$'
          destination: ''

    name: ${{ matrix.job_name }}

    steps:
      - name: Checkout repository
        uses: actions/checkout@v3

      - name: Replicating files
        uses: derberg/copy-files-to-other-repositories@v1
        with:
          github_token: ${{ secrets.GH_BOT_TOKEN }}
          committer_username: ${{ secrets.GH_BOT_NAME }}
          committer_email: ${{ secrets.GH_BOT_EMAIL }}
          patterns_to_ignore: ${{ matrix.patterns_to_ignore }}
          patterns_to_include: ${{ matrix.patterns_to_include }}
          commit_message: ${{ matrix.commit_message }}
          repos_to_ignore: ${{ matrix.repos_to_ignore }}
          topics_to_include: ${{ matrix.topics_to_include }}
          exclude_private: ${{ matrix.exclude_private }}
          exclude_forked: ${{ matrix.exclude_forked }}
          branches: ${{ matrix.branches }}
          destination: ${{ matrix.destination }}

Expected behavior
A clear and concise description of what you expected to happen.
Auto retry to recreate PRs if rate limited.

@ReenigneArcher sorry for the late response.
I already had issue with PR creation API in the past and already did retry there -> https://github.com/derberg/copy-files-to-other-repositories/blob/main/lib/api-calls.js#L157
So as you can see there are already 5 retires and 5sec delay before each. The problem is not solvable with more retires and larger delays. It is not a rate limit, at least I haven't found in the past the answer to that issue. Maybe it is kind of DDoS prevention or something. Dunno 🤷🏼
I'm afraid the only solution is to not do parallel execution really.
Side question is, why do you need this parallel execution? We you care so much on the speed of the action? Maybe issues you have I already solved in AsyncAPI, the project where we use this action on over 60 repos.

Side question is, why do you need this parallel execution?

I don't necessarily need it, just speeds up the workflow a bit as I have 6 scenarios. Not a big deal at all. I would be much happier to see #24 addressed. If a rebase could be done to a specified branch instead of opening multiple PRs, I think this action would be nearly perfect. It's okay if you want to close this. Thanks for all your efforts!

yeah #24 is tricky.
I'll close this one then as GitHub is really mysterious on this error. There is no clean solution for now


Easier to select just one date range

I'd like the user to be able to select only one date range
I can do this by returning NO from:
- (BOOL)calenderView:(GLCalendarView *)calendarView canAddRangeWithBeginDate:(NSDate *)beginDate
  return NO;

}
However, it's then quite difficult for the user to select a new range to replace the old without deleting.
What I'd ideally like to achieve, is when the user selects a date outside of the current range, the existing range is deleted, and a new range is started where they click.
Is that possible?
Thanks

You could achieve it by:
- (BOOL)calenderView:(GLCalendarView *)calendarView canAddRangeWithBeginDate:(NSDate *)beginDate
{
    for (GLCalendarDateRange *range in calendarView.ranges) {
        [calendarView removeRange:range];
    }
    return YES;
}

And you can find the demo here: https://github.com/Glow-Inc/GLCalendarView/tree/single-select


Issue with multi dot subdomains

Hi there,
thanks for this awesome project!
I just noticed that if you use multiple subdomains (multi dot subdomains) like this one:
dev.login.mydomain.com

You will get a cookie for .login.mydomain.com. I don't think this is intentional, since a cookie for .login.mydomain.com is not really useful ;)
Extracting a multidot subdomain from a domain is not trivial, since there are TLDs (or second level domains) like co.uk, that also contain a dot.
I googled around and found out that there is a public maintained list with all TLDs:
https://publicsuffix.org/
There are also tools that use the list to parse domain names, e.g.:
https://github.com/wrangr/psl
It looks like wrangr/psl does not have any dependencies and might be save for use. It uses MIT license as well.

Thanks for spotting that issue! I'd suggest to provide an optional env Parameter "LW_COOKIE_DOMAIN". When this is empty, the cookie domain will be "LW_SUBDOMAIN" skipping first sub (https://github.com/lipp/login-with/blob/6fc0726d0fdd7ac49f665f7d4023d499c958bb3f/src/opts.js#L10).
So in your case the env would be "LW_SUBDOMAIN=dev.login.mydomain.com" LW_COOKIE_DOMAIN=".mydomain.com".
I guess the additional config work can be forgiven and we don't depend on any other resource or would make things more complicated.
@feluxe What do you think?

I guess it makes a lot of sense to skip the complicated url-parser and the bit of extra control over the cookie domain might be useful in other situations as well. Looks like a fine solution to me!


[Bug]: V-Model binding to ref with string value breaks setup

Environment
Radix Vue version: 1.5.1
Vue version: latest
Browser: Edge Chromium

Link to minimal reproduction
https://codesandbox.io/p/devbox/radix-vue-datepicker-forked-kjvvnv?file=%2Fsrc%2FApp.vue
Steps to reproduce

Setup a ref value to use in v-model on DatePickerRoot component.
Set the initial value of the ref to a valid date string ie. '2021-01-01'
Observe that the datepicker component is not visible (broken)
Observe the console for errors;

index.js:8
 [Vue warn]: Unhandled error during execution of setup function
  at <DatePickerRoot id="date-field" modelValue="2021-01-19" onUpdate:modelValue=fn  ... >
  at <App>

  Uncaught TypeError: O.copy is not a function
    at setup (index.js:6837:47)
    at callWithErrorHandling (runtime-core.esm-bundler.js:195:19)
    at setupStatefulComponent (runtime-core.esm-bundler.js:7612:25)
    at setupComponent (runtime-core.esm-bundler.js:7573:36)
    at mountComponent (runtime-core.esm-bundler.js:5901:7)
    at processComponent (runtime-core.esm-bundler.js:5867:9)
    at patch (runtime-core.esm-bundler.js:5335:11)
    at mountChildren (runtime-core.esm-bundler.js:5583:7)
    at mountElement (runtime-core.esm-bundler.js:5490:7)
    at processElement (runtime-core.esm-bundler.js:5455:7)

Describe the bug
Just wanted to try out the DatePicker, however when assigning a string value to the initial ref model value, the DatePickerRoot breaks.
However, if the initial ref value is null, the v-model works as intended.
Expected behavior
The initial ref value used in v-model should accept a valid string date as the default value.
Speaking about defaultValue, that prop also does not work.
<DatePickerRoot default-value="2021-01-01">

Context & Screenshots (if applicable)
No response

This is not a bug ya @borovez .  modelValue accepts DateValue , do have a look at Dates section to understand more.
Example of how to use:
import { CalendarDate } from '@internationalized/date'
import { type Ref, ref } from 'vue'

const modelValue = ref( new CalendarDate(2024, 2, 20))


Parser does not handle FundsType code Z

On page 30 of the BAI2 file format specification (BAI2 Files) there is a "Funds Type" field which can take the value of Z, indicating that the type of funds specified by the transaction is "unknown".
Currently, the parser raises a ValueError when it encounters this value:
ValueError: Z is not a valid FundsType

The fix seems to be relatively simple (addition of that value to the FundsType Enum with an associated regression test).

should be resolved now


Can't start  node

Tomorrow I monit my node crashed, and the ran command is :
`coda daemon     -discovery-port 8303     -peer /ip4/<IP_ADDRESS>/tcp/8303/ipfs/12D3KooWHMmfuS9DmmK9eH4GC31arDhbtHEBQzX6PwPtQftxzwJs     -peer /ip4/<IP_ADDRESS>/tcp/8303/ipfs/12D3KooWAux9MAW1yAdD8gsDbYHmgVjRvdfYkpkfX7AnyGvQaRPF     -peer /ip4/<IP_ADDRESS>/tcp/8303/ipfs/12D3KooWCZA4pPWmDAkQf6riDQ3XMRN5k99tCsiRhBAPZCkA8re7     -propose-key keys/my-wallet
2019-10-26 15:35:02 UTC [Info] Coda daemon is booting up; built with commit "fff3b856476c4ac65cad48bbea15177935249f40" on branch "master"
2019-10-26 15:35:02 UTC [Info] Daemon will expire at "2019-11-05 14:00:00-07:00"
2019-10-26 15:35:02 UTC [Info] Booting may take several seconds, please wait
Secret key password:
2019-10-26 15:35:16 UTC [Info] Daemon started process of kind "Prover" with pid 6138
2019-10-26 15:35:17 UTC [Info] Daemon started process of kind "Verifier" with pid 6150
2019-10-26 15:35:17 UTC [Info] libp2p peer ID this session is $peer_id
peer_id: "12D3KooWR1nHo6WkPkbrBWhiNNoeD6TvuGBujEYe3WcNsQhMFR7Y"
2019-10-26 15:35:17 UTC [Info] Starting Bootstrap Controller phase
2019-10-26 15:35:17 UTC [Info] Coda daemon is now connecting
2019-10-26 15:35:17 UTC [Info] Pausing block production while bootstrapping
2019-10-26 15:35:17 UTC [Info] Attempted to turn on snark worker, but snark worker key is set to none
2019-10-26 15:35:17 UTC [Info] Daemon ready. Clients can now connect
2019-10-26 15:35:17 UTC [Info] Created GraphQL server and status endpoints at port : 3085
2019-10-26 15:35:20 UTC [Error] RPC call raised an exception: $exn
exn: "(src/connection.ml.Handshake_error.Handshake_error\n  (Eof ("Client connected via TCP" (<IP_ADDRESS> 8302))))"
2019-10-26 15:35:20 UTC [Warn] Retrieving chain ID failed: refusing to connect to [host : <IP_ADDRESS>, discovery_port : 8303, communication_port : 8302]: $error
error: "(src/connection.ml.Handshake_error.Handshake_error\n (Eof ("Client connected via TCP" (<IP_ADDRESS> 8302))))"
2019-10-26 15:35:20 UTC [Info] Connected to some peers []
2019-10-26 15:35:20 UTC [Info] Coda daemon is now listening
2019-10-26 15:35:20 UTC [Fatal] Failed to connect to any initial peers
☠  Coda Daemon failed to connect to any initial peers.
You might be trying to connect to a different network version, or need to troubleshoot your configuration. See https://codaprotocol.com/docs/troubleshooting/ for details.`
I already use this command successful make 2 block:
https://codaexplorer.garethtdavies.com/wallet/tdNDowo9QyHT1KnkQP4173GMona8MdrQ7UbG1E1BxdUgyxAMh9KK2w9tfcBcfxWgQzH29JtZpFZ7MekRtytfR5no6RjdnKdgrx5PByfEXhtZzX3HX74qVEL33qnDfdf6gqMpCxjjgLHECY
Today, I Multiple attempts to run commands will got same error. compute resource is idle.network is normal, I use nc command test every thing is ok.
nc -zv <IP_ADDRESS> 8303
Connection to <IP_ADDRESS> 8303 port [tcp/] succeeded!
nc -zv <IP_ADDRESS> 8302
Connection to <IP_ADDRESS> 8302 port [tcp/] succeeded!
nc -zv <IP_ADDRESS> 8303
Connection to <IP_ADDRESS> 8303 port [tcp/*] succeeded!
coda_crash_report_2019-10-25_06-09-19.397646.tar.gz
discord: niuniu#9001

Closing this issue as it is stale for a long time.


Remove unused vars in weave script

See https://github.com/weaveworks/weave/issues/1748#issuecomment-161342091

so really just CLIENT_TLS_ENABLED. But this in turn means DOCKER_CLIENT_TLS_VERIFY and the associated logic in docker_client_args() is unused.


Cannot update s3 published repo if created from snapshot

When attempting to publish a snapshot to s3 it appears only one snapshot can be published to a specific path:
I create a snapshot of a mirror and publish it to s3 using aptly publish snapshot some-snap-name s3:main:prefix/
Then a week later after testing we want to update the path in the bucket to contain the latest content from the mirror
I create a new snapshot after running a mirror update and attempt to publish this:
aptly publish snapshot new-snap-name s3:main:prefix/
I am greeted with the following:
ERROR: prefix/distribution already used by another published repo: s3:main:1.3.0-xenial-main/xenial [amd64] publishes {main: [snapshot-1490159920]: Snapshot from mirror [xenial-main]: http://us.archive.ubuntu.com/ubuntu/ xenial}
If I run
aptly publish update snapshot new-snap-name s3:main:prefix/
I get the error saying this operation is not possible. the docs seems to suggest the publish update command is only for local repositories.
Context

At our organization we have a need to host internal mirrors of the public ubuntu repos but with a few packages excluded or held back.
I'd like a flow like this:

Test on an internally available repository (published locally using aptly).
Testing finishes so I snapshot the local repository
publish this snapshot to a specific path in s3
repeat 1 & 2 and publish new snapshot to the same path in s3

This is useful because it means we never have to change the path in /etc/apt/sources.list on our machines in order to get the contents of the newly approved "snapshot".
Currently I end just making changes directly to the local repository and then running aptly publish update. But I lose the ability to have snapshots
Possible Implementation

Your Environment

Also this could totally be possible but I havent figured it yet. I've only been playing with aptly for two days.

@cpoole you need aptly publish switch (https://www.aptly.info/doc/aptly/publish/switch/)

beautiful! thanks @smira sorry for the spam


Getting this error even if i provide the token

have Error [401] => Data: {error: {message: You didn't provide an API key. You need to provide your API key in an Authorization header using Bearer auth (i.e. Authorization: Bearer YOUR_KEY), or as the password field (with blank username) if you're accessing the API from your browser and are prompted for a username and password. You can obtain an API key from https://beta.openai.com., type: invalid_request_error, param: null, code: null}}

Your Token have problem you can get new token for solve this problem.

I'm still having the issue.
Hang on a bit, must I pay for the token to work on my app?

You have error Log

Yeah, it says just like what @kahdichienja posted

I have generated new token about three times yet says same thing

In case I with this issue I create new token and it works , your may be problem limit ,your push code to me.

https://github.com/iampawan/ChatGPT-Flutter-AIChatBot

This the repo I used. I only just changed the Chatgpt package used to yours on the pubspec.yamal

Pls check it out and find out

Pls check it out and find out

your can geneate token give me ?

Doing that right away

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

you can my live here: https://youtu.be/mcr-ErvqyzU


Setting up TLOmodel for analysts (not installing the repo in editable mode)

The current instructions are geared towards developers of the TLOmodel i.e. cloning the respository, installing it in editable mode, and special treatment of the root TLOmodel directory e.g. in the writing of output files.
This is not necessary for those running scenarios: TLOmodel could be installed as a normal Python package & scenario scripts and outputs sit somewhere else.

Hi @tamuri, I have pushed a genanalysis.py file as a skeleton of the initial setup of the package. I wanted to check with you if this is also what you had in mind before I proceed. Below are some of the issues:

Every analysis would have a function in the genanalysis.py file. This means an analyst (user) would just have to call the function of interest after running a pip install of the tlo model. For instance, the analyst would just call the function run_lifestlye_calibration in the genanalysis.py file to run analyses for the lifestlye module. Analyses for other modules would be run in a similar way (I would have to create functions for them).
It seems there's another library on Pypi already called tlo. I thought it may not be able to deploy onto Pypi with a name already in use. Stumbled upon this while debugging.
I am sure my naming of the files may not also be up to standard

I hope it all makes sense


running infer_wild.py takes so much time

Hello author, first of all, thank you for your efforts. Your work is quite commendable. And then I run 'infer'_ Wild. py reasoned that a 30 second video would take 2.5 hours. I can be certain that my CPU, running memory, and GPU3070 do not occupy much performance. So come and ask if I need to change some parameters or take other measures to make my operation faster. Thank you again for your great contribution. I hope you can reply to me as soon as you see it

Rendering should be the bottleneck. Please check you matplotlib version or maybe turn off rendering.


adds keep-alive header for canvas and sws requests

Coverage remained the same at 85.408% when pulling 4e699ebcce07c0ac2d041fbbc386411e424650c6 on feature/connection-keep-alive-header into 23e0705f07b2e0cf8048aedc4bec3923b7c6aa27 on develop.


New version: prefix-dev.pixi version 0.24.0

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\pixi\bin\pixi.exe returned exit code: 2

(Automated response - build 885.)


Chatting with Roshan

Can you leave a comment Roshan?
I just found the part I did not know here
A few libraries are still not working for Arduino, fine now with Patform.io except for the IMU.

So everything seems to be working for me except the 9 axis accelerometer, gyro and magneto. Have you had any luck.
This is the include library.
ICM_20948.h

@Roshankattel  Did this work.

On my side, the compilation is successful but haven't tested this feature yet.

Great to touch base. I need to get the accelerometer working. Surprised from the factory that it is set off. That concerns me. If you find any working code why not put it in the first-code folder, or make your own folder. Check if you have access.

Okay

@Roshankattel I still get setupSensor Fail when trying to compile the full factory setup. I have made minor changes to make it try the accelerometer. My code is first-code/S76G-Factory02-try-imu
Note: The minor changes

Make sure your Lilygo Impulse device has an accelerometer sensor installed in the board.


Modal: Scrolling doesn't work properly

Steps

Open scroll modal
Scroll modal
Close scroll modal
Open scroll modal again
Scroll modal

Expected Result
Modal must be scrollable
Actual Result
Modal no longer scrollable
Version
0.74.2
Testcase
https://react.semantic-ui.com/modules/modal

There are no need to scroll this modal. In fact, error comes from this condition. After modal will be closed it should reset scrolling state as I think:
  handleClose = (e) => {
    debug('close()')

    const { onClose } = this.props
    if (onClose) onClose(e, this.props)

-    this.trySetState({ open: false })
+    this.trySetState({ open: false }, { scrolling: undefined })
  }


FLW-697 Remove "active era" label from "Your stake" widget

Codecov Report

Merging #261 (3b2348c) into develop (7920849) will increase coverage by 1.32%.
The diff coverage is 47.33%.


How to send the QAF execution summary as email ?

How to send the QAF execution summary report as email for the project team ? is there any provision through framework ? Do we have any documentation for this ?

You can enable default TestNG listeners which will generate emailable-report.html or write your custom implementation. You should utilize CI for that purpose.

Closing inactive issue. Please post question in user group.


Allow showing output above code

This PR adds a new setting show_output_above_code which allows showing the output of a code block above the code instead of below.
@MichaelHatherly I haven't added any styling for this case yet, but I guess you will be doing styling on your side anyway? I try to avoid hardcoding styling inside the HTML output because it could be hard to override for end-users. (But then again, maybe I should because CSS does allow !important annotations.)

but I guess you will be doing styling on your side anyway?

Yes, will probably need to. Thanks.


Correct the synced lyrics heuristically

This issue is a follow-on from this short thread in a related side-project; https://github.com/karaokenerds/python-audio-separator/issues/8#issuecomment-1685325394
Problem: lyrics-transcriber currently transcribes the given audio file using whisper-timestamped and writes the detected words to a lyrics file directly with no cleanup or modification.
This results in very variable accuracy for the lyrics output, as Whisper is far from perfect at correctly detecting lyrics from music audio.
For an example, compare these two synced lyrics videos:

Synced manually by me with correct lyrics and manual syncing using MidiCo. Manual synced .lrc file here for comparison.
Generated using lyrics-transcriber - pure Whisper transcription only, taking the output .lrc file and loading that into MidiCo

Fortunately, for the majority of songs, as long as we know the artist and title, we can download lyrics from the internet and hopefully use this to correct the detected lyrics from Whisper.
I've already implemented the fetch of lyrics from both genius and spotify.
This issue is to track the implementation of the hard part - using those lyrics to correct the detected lyrics.
Before discussing ways to approach this, it's worth being aware of the biggest limitations first:
1 - Lyrics from the internet are often wrong in various ways
Common examples include:

Missing repetitions of chorus/refrain or bridge sections of songs
Missing intro or outro sections
Wrong/incorrect words, e.g. where a person typing up the lyrics has misheard
Wrong/incorrect words, e.g. where the "official" lyrics don't match what ended up actually being sung by the artist in the commercial recording

2 - Whisper-timestamped transcriptions are almost always wrong in various places

It will almost always have some words which are wrong, depending on the singers style, accent, background music, recording quality, etc. This is especially likely when the lyrics include names or less common words, and are sometimes hilarious to read, e.g. mishearing "Whitehall" as "Phytol" in one song I recently created a karaoke version of 😄
While it usually gets the timestamps of words correctly (even if the word itself is wrong), there are still some issues with this which may need to be solved in the whisper-timestamped project itself, e.g. it commonly gets the timestamp of the very first word wrong, and occasionally starts sentences too soon.
Fortunately, it at least provides a confidence score for each detected word, which we can hopefully use to improve the transcription by replacing low confidence words with more-likely words from the internet lyrics

So, given these challenges, I'm holding out hope for the following approach (roughly):

Take the internet lyrics and split those up into lines (both genius and spotify if both were successfully fetched)
For each line returned from the whisper transcription, find a couple of "anchor words" which have a high confidence score
Attempt to match up the line with a lyrics line from the internet lyrics using these "anchor words"
Attempt to replace the low confidence (less than 50%?) words with words from the matched internet lyrics line, potentially replacing the entire line if there are multiple low confidence words in the line or if the number of words doesn't match up

This is a super rough set of thoughts though, and I'm sure the reality of this approach will become apparent when attempting to implement ;)

FYI @arsaboo I've now opened this issue to shift the focus onto solving this specific challenge in this repo.
If we can improve the quality of the transcribed lyrics as I've described above, that will be a huge win for the automated-karaoke challenge! 😀
However, I should also mention that there's some very recent (published 2 months ago) internal research work at Spotify demonstrating an approach to this which is much more exciting to me than my own rough algorithm described above: https://arxiv.org/pdf/2306.07744.pdf
It sounds like they've successfully trained a model specifically for lyrics syncing, and they've published a super helpful repo of royalty-free music (broad mix of genres) with lyrics and synced timestamps here: https://github.com/f90/jamendolyrics
That'll probably be useful to test the accuracy of pure whisper, vs. whisper + my primitive known lyrics-matching algorithm above.
I'm kinda hoping someone with more understanding of more of the words in this research paper will actually be able to reproduce their results and share their model training code and the actual trained model with the world as an open source project, potentially making this whole issue redundant!
Not gonna hold out hope for too long though, as Spotify most likely want to keep their model an internal secret to give them a competitive advantage (e.g. being able to provide accurate synced lyrics for any song in the Spotify app without needing to license them from musicxmatch any more)...
Just wanted to flag this in case it was of interest to you, or in case anyone else with more ML experience than I reads this and gets excited about training a model for lyrics syncing which could change the approach here!

If we assume that the lyrics downloaded from the internet are 100% correct (which are likely not, as you said), a better approach could be to directly sync those lyrics to the song. I have found this repo witch has the goal of enhancing Whisper capabilities. In this package, they've added a model.align() function that sync the transcript (here, the lyrics) to the audio (more info here). What do you think about it ?

@beveradb, @Turtle6665 another repo worth checking out is https://github.com/Japan7/yohane.  At command line, I was able to get a workable .ass file from it with "poetry run yohane -e None test.mp3 lyrics.txt" (-e None means no vocal separation, chose this to speed things up so I could check it out).  Using the .ass file that was created, I then I ran "ffmpeg -i test.mp3 -c:v libx264 -c:a libmp3lame -vf ass=test.ass -shortest test.mp4" to create the mp4 for viewing and the result for the song I selected was decent enough although it does require some tweaking of the .ass file.  You can then do this with an app called Aegisub (there are youtube videos on how to use it, not a huge learning curve) and although fairly old, it works pretty well in getting a polished .ass file that you can use with an instrumental.


Refactor shard-id into a parameter to support new API semantics

This should address the problem with #2. It does introduce a breaking change, but I consider this to be worthwhile until an official tagged and versioned release of this library is produced.
With a couple more changes and a full test suite, I think that could be achieved as well.

I don't understand why the ranked stats support got smashed inside this pull request as well. I'd like to yoink those back out but I am obviously not git-fluent yet.


indexer-common: Avoid using createdAt field for pagination

Changes

Update several NetworkMonitor functions to paginate by id instead of by createdAt. Functions updated: subgraphs(), subgraphDeployments() and disputableAllocations().

Background
On L2 networks, like arbitrum-one, createdAt is not necessarily unique, so paginating based on createdAt can lead to missing items.

Removing my approval as I've made changes now.

One of the comments was not addressed. GitHub won't let me explicitly select the piece of code....
So here's the issue: packages/indexer-common/src/indexer-management/monitor.ts:1139 $createdAt: Int! should be $lastId: ID!

Thanks for catching this.


refactor(transformer/class-properties): remove a branch from transform_call_expression_impl

Small optimization. transform_call_expression_impl does not require the Expression::CallExpression, only the CallExpression itself. So pass that into the function, instead of having to unwrap it (which is an unnecessary branch).

#7507  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Tiny change, so merging without review.

Merge activity

Nov 27, 6:19 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


Minor issue with JSON Decoding C#/F#

This is awesome, did you generate the guitar/ukulele json yourself?
Only small thing to fix is that in the guitar json, C# and F# are written as "CSharp" etc so when you select them in the dropdown, the fretboard doesn't update since the name isn't found in the json. Replacing them with C# and F# fixes the bug.
Thank you for this project, very useful!

Thank you @josueespinosa  for letting me know of the issue! This has been fixed in 0803c3432702c3ffbd925fd3d0a56024d9bffe22 🎉


How to compile from source in windows ?

I haven't tried yet :)  I  expect it should compile, the only hang-up might be some of the non-Rust libraries that some of Binwalk's build dependencies require. Have you tried compiling it on Windows? Are you getting a specific error?

cargo build --release seems to be working for me on Windows 11

I've made a note in the Wiki that building and running Binwalk on Windows should work, but is not officially tested.


Updating dapr to v1.7.0-rc.3

Description
Updating dapr to v1.7.0.-rc.3
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: NA
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

@pravinpushkar Can you update the upgrade path tests also to use 1.7.0-rc.3?


[WIP] Reduce duplication

This pull request resolves #427
The pull request is ready to be merged.
The details of the pull request:
Reduced duplications

@Evan-Choo It doesn't pass the CI. Please fix it. Thanks.


Add the reporting section of pom.xml

I would like to produce the maven site static html docs for the project
It is possible to add the reporting section in pom.xml files (compulsory since maven 3), like for example :

org.apache.maven.plugins
maven-project-info-reports-plugin
2.9

org.apache.maven.plugins
maven-site-plugin
3.7.1

org.owasp
dependency-check-maven
5.2.4

To make sure it works, simply run "mvn site" command
Thanks for your help

Hi, thank you for your feedback and your interest for ARA!
This is a good idea, but this cannot be shipped with the current version (4.1.0) because it is currently being finalized.
However, this will be taken into account for the next version, for which the development will begin next week. You can keep track of the updates from time to time.
The ARA team


grel: Prepare tests for modularization

Changes proposed in this pull request:

introduce a new base class for GREL tests, which extends our current RefineTest. This makes it possible to remove the test utilities that depend on GREL from the RefineTest class, in anticipation for it being in a core Maven module where GREL isn't available
also splits out some tests that were in EvalErrorTests but really belong to the test classes for the functions they actually test. This is also necessary because EvalError will live in the core Maven module (being part of the core data model, as they can be stored in Cell), whereas the corresponding functions will be in the GREL module

Merging this broke the build because of a missing import, so I am adding it directly to master with 6a86001


lxd/cluster: If raft node 1 gets remove during recovery, add it back

When running lxd cluster recover-from-quorum-loss, if your raft node 1 is still
around it wasn't added back to the raft configuration after recovery.
Signed-off-by: Free Ekanayaka<EMAIL_ADDRESS>

Testsuite passed


Issue using next command on Mac

What version of Delve are you using (dlv version)?

bash-3.2$ dlv version
Delve Debugger
Version: 0.12.1
Build: v0.12.1

What version of Go are you using? (go version)?

go version go1.8 darwin/amd64

What operating system and processor architecture are you using?

MacOS Sierra x64

What did you do?

https://gist.github.com/tylerlrhodes/b106963eeac76cf145d9405976a5e4d9
Basically just trying to step through some code, I've tried this using the command line and also from VS Code.  While breakpoints in VS Code seem to work, stepping over a line seems to generate a panic of some kind.

What did you expect to see?

The ability to step over a line / user the next keyword

What did you see instead?

(dlv) next
Command failed: Invalid address 0x0

There is a problem with 0.12.1 and go 1.8, upgrade to master.

I'm just starting out with Go and Delve, what's the easiest way to do that?
Is there another go get command to use besides the one in the install docs?
It does seem to work okay on windows with both of these versions

Try this:
cd $GOPATH/src/github.com/derekparker/delve
git checkout master
git pull
CERT=dlv-cert make install

I was able to build it with the latest from master, however the next command just hangs
bash-3.2$ CERT=dlv-cert make install
go install -ldflags="-s -X main.Build=28a0e5bd63d22340ecfaa2177a29e1c1f1b5d41c" github.com/derekparker/delve/cmd/dlv
codesign -s "dlv-cert"  /Users/tylerrhodes/go/bin/dlv
bash-3.2$

(dlv) break main.main
Breakpoint 1 set at 0x1088efb for main.main() ./bitvector.go:38
(dlv) continue
> main.main() ./bitvector.go:38 (hits goroutine(1):1 total:1) (PC: 0x1088efb)
    33: func (bv *BitVector) IsBitSet(x int) bool {
    34:         word, bit := x/64, uint(x%64)
    35:         return word < len(bv.bytes) && bv.bytes[word]&(1<  38: func main() {
    39:         var bitvec BitVector
    40:         bitvec.SetBit(0)
    41:         if bitvec.IsBitSet(0) {
    42:                 fmt.Printf("\nBit 0 is set!")
    43:         }
(dlv) next

Can you post the program you are trying to debug?

I put it in a gist for you:
https://gist.github.com/tylerlrhodes/359faba1f5817f5c54cc09fad5ca1d8d

I have the same issue, while debugging an application. I use however "OS X El Capitan x64" rather than "MacOS Sierra x64". All other info is similar for me. So I am going to try to help debug this issue, although I can't promise I will get anywhere with this, as I've never seen this codebase or contributed to it before.

Great, I would love to have this work on the Mac.
It does seem to work just fine on Windows using the same versions of delve
and go.  I'd be willing to help test it if needed.
On Sat, Mar 25, 2017 at 7:48 PM, Glen De Cauwsemaecker <
<EMAIL_ADDRESS>wrote:

I have the same issue, while debugging an application. I use however "OS X
El Capitan x64" rather than "MacOS Sierra x64". All other info is similar
for me. So I am going to try to help debug this issue, although I can't
promise I will get anywhere with this, as I've never seen this codebase or
contributed to it before.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/derekparker/delve/issues/776#issuecomment-289247717,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE6-rQW2lweEPl6KAxw5yaDjOV4TOEcKks5rpafkgaJpZM4MlhmG
.

I do have to say @tylerlrhodes that I can debug your gist fine, while I can't debug http://github.com/rivine/rivine/rivined without hanging when I use the next command in a dlv debug process.
So for me your gist works fine when I do the following:

start the process in the same dir as the gist is placed using dlv debug
add breakpoint to the main file: (dlv) b main.main
continue: (dlv) continue
next: (dlv) next

And for me that does just go next, and I can use whatever commands are available to me.

Hmmm... Weirdly enough the next command now also doesn't hang any longer when debugging my application mentioned earlier. So I'm not sure what's going on. For now I can use the dlv command fine... How curious.

That's strange.  I just did a pull from master and tried it again, but no luck here....

I had the same issue and solved it with brew install go-delve/delve/delve --HEAD.

Hadn't looked at it for a while.
I can confirm that this works on my end too on the MacOS
On Tue, Apr 11, 2017 at 7:32 PM, Taeho Kim<EMAIL_ADDRESS>wrote:

I had the same issue and solved it with brew install go-delve/delve/delve
--HEAD.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/derekparker/delve/issues/776#issuecomment-293430063,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE6-rUPYmjVTHXPTeS_cGSb8A2Kdg2axks5rvA2rgaJpZM4MlhmG
.


External diff command always launched when opening files instead of plain git diff

GitLens Version:
VSCode Version: 1.13
OS Version: Ubuntu 16.04 LTS

Steps to Reproduce:

Configure global git to use an external diff command in .gitconfig

[diff]
        external = external-diff-cmd

install vscode-gitlens
launch vscode, open git project
navigate to various files
when opening a file for the first time, the external-diff-cmd is always launched thus interrupting the editing flow

In my specific case I followed these instructions to configure meld as the diff viewer https://nathanhoad.net/how-to-meld-for-git-diffs-in-ubuntu-hardy.
[diff]
        external = /home/user/scripts/diff.py

where diff.py contains
#!/usr/bin/python

import sys
import os

os.system('meld "%s" "%s"' % (sys.argv[2], sys.argv[5]))

which is needed just to adapt the order in which git diff passes cli arguments to the order expected by meld
Proposed fix
Launch git diff with an option specifying to use the internal diff algorithm or plain diff

git diff --no-ext-diff
https://stackoverflow.com/questions/19936187/git-diff-overriding-gitconfig-external-tool

@carlobonamico Thank you so much for this awesome bug report! 4.1.2 is out now with your fix -- thanks again!


Indented continuation

I'm trying to build a DSL that is indentation-aware, but also has some flexibility in terms of how the code is arranged. Here's an example:
$revenue = sum(Quantity * UnitPrice) ::float @invoice_items
  > This is a description
    that can span multiple lines
  format: currency
  key:
    nested: value

The relevant part of the grammar looks something like this:
metric: "$" ID "=" expr [ "::" ID ] [ "@" ID ] _NL [ _INDENT (description | kv)+ _DEDENT ]

This works, but expressions can get quite long, so I also want to allow the first "header" line of the definition to span multiple lines, as long as it's also indented.
So I want something like this to also be valid:
$revenue = sum(
    Quantity
    * UnitPrice
  ) ::float
  @invoice_items
  > This is a description
    that can span multiple lines
  format: currency
  key:
    nested: value

This means that the grammar should be whitespace-aware, but ignore whitespace in some contexts. How can I achieve this with lark?

As long as the ignored whitespaces are only inside parentheses, the default Indenter postlexer can deal with that by specifying open and close parentheses, see the python example.
If there is no simple rule like that, then you probably need to create a fully custom postlexer and/or lexer and maybe lark is not suited for this at all. This kind of context dependency is by definition no longer Context-Free which makes CFG parsers like lalr and earley unsuitable.


Removes bad link

The reason the link is bad is I copied the section from python. I removed the link, as I did not base my style recommendations on an online style guide, but what I have seen in books, classes and tutorials.

@bendelonlee the PR has a merge conflicts, please resolve them and resubmit again, thanks.

Conflicts resolved


hsa_signal_wait_acquire() doesn't return on /opt/rocm/hsa/sample/vector_copy

cont. https://github.com/RadeonOpenCompute/hcc/issues/71
"verify-installation" step doesn't succeed because hsa_signal_wait_acquire() doesn't return.
Environment is following:

Ubuntu 14.04.4
Core i7-3770K
AMD Radeon R9 FuryX
DDR3-1600 2GBx4

Steps to reproduce are following:

Clean-install ubuntu 14.04.4 ("Erase disk and install ubuntu")
Boot normally, and I got "low level graphic mode" (this is expected for FuryX, right?).
Enter console mode with "Ctrl+Alt+F1".
Install hcc; following https://github.com/RadeonOpenCompute/ROCm#add-the-rocm-apt-repository
reboot
Enter console mode again
export PATH=${PATH}:/opt/rocm/bin
cp -r /opt/rocm/hsa/sample/ ~/sample
cd ~/sample
make
./vector_copy output following but doesn't finish.

Initializing the hsa runtime succeeded.
Checking finalizer 1.0 extension support succeeded.
Generating function table for finalizer succeeded.
Getting a gpu agent succeeded.
Querying the agent name succeeded.
The agent name is Fiji.
Querying the agent maximum queue size succeeded.
The maximum queue size is 131072.
Creating the queue succeeded.
"Obtaining machine model" succeeded.
"Getting agent profile" succeeded.
Create the program succeeded.
Adding the brig module to the program succeeded.
Query the agents isa succeeded.
Finalizing the program succeeded.
Destroying the program succeeded.
Create the executable succeeded.
Loading the code object succeeded.
Freeze the executable succeeded.
Extract the symbol from the executable succeeded.
Extracting the symbol from the executable succeeded.
Extracting the kernarg segment size from the executable succeeded.
Extracting the group segment size from the executable succeeded.
Extracting the private segment from the executable succeeded.
Creating a HSA signal succeeded.
Finding a fine grained memory region succeeded.
Allocating argument memory for input parameter succeeded.
Allocating argument memory for output parameter succeeded.
Finding a kernarg memory region succeeded.
Allocating kernel argument memory buffer succeeded.
Dispatching the kernel succeeded.

This seems hsa_signal_wait_acquire() doesn't return.
What's the problem and how can I fix this?
Note that I use Ivy Bridge CPU so ROCm doen't support the CPU according to @whchung .
Could you point me to the notice for the supported CPU on any wiki page or other documents etc?
Thanks.

   We only tested on Haswell or newer CPU.
Get Outlook for iOShttps://aka.ms/o0ukef
On Sun, Jun 5, 2016 at 11:51 PM -0700, "YOSHIFUJI Naoki" <notifications<EMAIL_ADDRESS>wrote:
cont. RadeonOpenCompute/hcc#71https://github.com/RadeonOpenCompute/hcc/issues/71
"verify-installation"https://github.com/RadeonOpenCompute/ROCm#verify-installation step doesn't succeed because hsa_signal_wait_acquire() doesn't return.
Environment is following:

Ubuntu 14.04.4
Core i7-3770K
AMD Radeon R9 FuryX
DDR3-1600 2GBx4

Steps to reproduce are following:

Clean-install ubuntu 14.04.4 ("Erase disk and install ubuntu")
Boot normally, and I got "low level graphic mode" (this is expected for FuryX, right?).
Enter console mode with "Ctrl+Alt+F1".
Install hcc; following https://github.com/RadeonOpenCompute/ROCm#add-the-rocm-apt-repository
reboot
Enter console mode again
export PATH=${PATH}:/opt/rocm/bin
cp -r /opt/rocm/hsa/sample/ ~/sample
cd ~/sample
make
./vector_copy output following but doesn't finish.

Initializing the hsa runtime succeeded.
Checking finalizer 1.0 extension support succeeded.
Generating function table for finalizer succeeded.
Getting a gpu agent succeeded.
Querying the agent name succeeded.
The agent name is Fiji.
Querying the agent maximum queue size succeeded.
The maximum queue size is 131072.
Creating the queue succeeded.
"Obtaining machine model" succeeded.
"Getting agent profile" succeeded.
Create the program succeeded.
Adding the brig module to the program succeeded.
Query the agents isa succeeded.
Finalizing the program succeeded.
Destroying the program succeeded.
Create the executable succeeded.
Loading the code object succeeded.
Freeze the executable succeeded.
Extract the symbol from the executable succeeded.
Extracting the symbol from the executable succeeded.
Extracting the kernarg segment size from the executable succeeded.
Extracting the group segment size from the executable succeeded.
Extracting the private segment from the executable succeeded.
Creating a HSA signal succeeded.
Finding a fine grained memory region succeeded.
Allocating argument memory for input parameter succeeded.
Allocating argument memory for output parameter succeeded.
Finding a kernarg memory region succeeded.
Allocating kernel argument memory buffer succeeded.
Dispatching the kernel succeeded.
This seems hsa_signal_wait_acquire()https://github.com/RadeonOpenCompute/ROCR-Runtime/blob/roc-1.1.0/sample/vector_copy.c#L409 doesn't return.
What's the problem and how can I fix this?
Note that I use Ivy Bridge CPU so ROCm doen't support the CPU according to @whchunghttps://github.com/whchung .
Could you point me to the notice for the supported CPU on any wiki page or other documents etc?
Thanks.

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/RadeonOpenCompute/ROCm/issues/13, or mute the threadhttps://github.com/notifications/unsubscribe/AD8DuU2DI9ueb_XgbE8Pk1P4CnvHs74-ks5qI8NsgaJpZM4Ium1u.

Hi,
Apologies for commenting on an old, closed ticket - just one question.
I have the same CPU/GPU combo, and see this is not supported (Fiji with Ivybridge).
Would you please clarify if that's; never to be supported, possibly supported or certain to be supported?
Thank you

If you have an Ivy Bridge that does not support PCIe atomics, then we do not currently have it on our roadmap to support gfx8 chips like Fiji for that CPU. Apparently some Ivy Bridge-E chips do support PCIe atomics, but others don't. I don't have a precise list on hand -- the main point is whether they support atomics), then we do not currently have it on our roadmap to support gfx8 chips like Fiji on that processor. As such, I would lean towards "most likely never supported". See this thread for more details.

thanks @jlgreathouse - your linked comment clarifies perfectly why it's "most likely never supported".
(I checked the aged i7-3770K's datasheet, and unsurprisingly there's no mention of PCIe* 3.0 atomic operation)


Gradle 5.4 upgrade

Welcome to Gradle 5.4!

Here are the highlights of this release:
 - Run builds with JDK12
 - New API for Incremental Tasks
 - Updates to native projects, including Swift 5 support

For more details see https://docs.gradle.org/5.4/release-notes.html

Mainly for JDK 12 support.


Bug: Hours is Not Ignored in Timeago

I coded to make 'time ago' readable and sensible for up to 5 years based on the existing comment date creation.
It works fine, EXCEPT:

I've noticed any comments which have been created within 'hours' and not 'days' still go through my code and then show the default 'over 5 years ago`

I was expecting the Kanboard '5h' or '~5h' as it is in the core but it seems ignored. I'd like to change the 'h' to 'hrs' or 'hours' but the code in the function is complicated to strip. Days is more important in workload anyway so i got that working.
I need help with the code to ignore the minutes and hours

The tooltip is the correct value in the picture
Commit: cfbf1fe

Still cant get it to work :(

now it does, ill leave the rest to you

Fixed by 77c76fe


add Ginkgo timeout for unit tests that do stream reads and writes

Read and Write are calls that are supposed to block under certain circumstances. Adding a timeout to the tests ensures that test actually fail when Read or Write doesn't unblock properly.
I wish there was a way to set a global timeout for each test with Ginkgo. We don't have any unit tests that is supposed to run longer than 1s.

Codecov Report

Merging #724 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #724   +/-   ##
=======================================
  Coverage   91.24%   91.24%
=======================================
  Files          81       81
  Lines        5653     5653
=======================================
  Hits         5158     5158
  Misses        310      310
  Partials      185      185

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3157e2d...61bfc5a. Read the comment docs.

I've opened https://github.com/onsi/ginkgo/pull/362 which I think is a nicer fix for this issue.

Following the discussion at ginkgo, I think we should do this without async tests. We can introduce a small helper function for io.Closer and io.Writer, and probably just use gbytes for the Reader. Thoughts?

Superseded by #742.


Restore URL focus handling

This change from this PR.
Later, in https://github.com/Kong/insomnia/pull/4299 I/we missed this change, which, appears to be the result of a bad merge conflict resolution that dropped all of the previous changes to this file.
The first commit in this PR, 811157aa73f897b76b652c373fa8225cf9fb5aa3, reverts to the prior state, exactly identical to before https://github.com/Kong/insomnia/pull/4299.  The second commit a7b8a4497ccc30ee560603ea1c209916dc79ab49, pulls the relevant changes out of https://github.com/Kong/insomnia/pull/4299.

update: upon self review, I noticed we can do a tiny bit better and remove some unused props 1834445e356ac61e07f19cdc11ebc1d46a6c9246


FAQ about deletion tombstones

Several users have recently been surprised by scan on seemingly small tables taking a long time. This happened because their tables had a large number of rows that have been deleted. For such rows, crdb leaves behind tombstones; these tombstones are skipped during table scans, but still add cost. The point of not simply wiping the data is the support for historical queries.
This scenario is common when users use a table as a work queue - tasks are enqueued and dequeued by inserting and deleting in a table. At any one time there are few "live" rows, but many tombstones.
This behavior may also be surprising for an operator that observes that their running low on disk space, deletes some data and then is surprised to see that nothing has changed (in fact, disk space might have increased due to the deletion :) ).
I think we should explain this, perhaps in an FAQ.
One solution is to lower the TTL on the table's zone
./cockroach zone set .default -f - --insecure <<EOF
gc:
  ttlseconds: 600
EOF

On the product side, we should consider whether our current TTL default of 24h makes sense; but that'll be a separate issue.

See https://github.com/cockroachdb/cockroach/issues/16252 and https://github.com/cockroachdb/cockroach/issues/16595


Feature request: Make Post Processing optional / Post Processing Features

Perhaps if we could turn Post Processing on / off via config or WebUI
If the Post Processing is turned on the user could perhaps choose what he wants for example:

remux to mp4
move finished recording
create screencaps
delete if shorter than x seconds
rename recording
create model directory

I think it could add a lot of flexibility for everyone
Cheers

I added some of the features:

remux to mp4 is now default
rename/delete recordings
Might add some more later


Doesn't get .htmllintrc from the root - After update 2.0.0

Hi!
After update to 2.0.0, the htmlint-loader does not use the .htmllintrc config from the root.
Before the update, this was working
{
  test: /\.html$/,
  use: ['raw-loader', 'htmllint-loader'],
},

Now, I had to fix with:
{
  test: /\.html$/,
  use: [
    'raw-loader',
    {
      loader: 'htmllint-loader',
      options: {
        config: '.htmllintrc',
      },
    },
  ],
},

In 2.0 the default config is loaded from within node_modules/htmllint-loader/.htmllintrc.
This means that if you are using a custom config you will need to declare it in the options.

Thanks @TheBlackBolt !, I think it's logic/nice to check first the .htmllintrc in the root, and if it does not exist, use the default config from the module.


update to zig 0.14.0-dev.1495+f29bdd674

After these changes zig build test passes with the noted zig version. Also, populated the minimum_zig_version metadata field in build.zig.zon.

Thanks, merged!


MarkerClusterer custom behaviour

Is it possible to change behaviour of clustering? For example don't group markers if markers are in different countries.

@DmitryDadeco this package is unmaintained over 4 years. please use @react-google-maps/api instead.