RDBMS support

@alexeyzimarev: I've got a very crude implementation of subscriptions using polling: https://github.com/claudiuchis/eventsourcing.sql. I have created tests to cover the event store, aggregate and subscriptions (all stream, single stream), for now using Postgresql. But this implementation can work with any SQL database with very little changes, including Sqlite. (Postgresql has a very basic notification mechanism to observe changes to a table, so that could be used for subscriptions using Postgresql to switch from polling to pushing). If you think this is worth adding to the contrib repo, let me know and I can add support for other SQL databases (MySql, SqlServer, Sqlite).
Originally posted by @claudiuchis in https://github.com/Eventuous/eventuous/issues/19#issuecomment-1133604168

I can take it to the core lib. I'd say that the first version can implement IEventReader and IEventWriter, and other things like stream deletion and truncation can be done later. I checked SqlStreamStore as well, and I see that they keep a separate table for streams. I'd also do the same, as well as extend it to keep the stream metadata (max age, max count, last known event number).
I see that some people might want to have the checkpoint to be updated in the same transaction as the read models, if both the sub, and its projections are using the same database. It only makes sense for non-idempotent projections, and I personally would not do it, but I can expect some demand for it. I assume it should be possible by passing the transaction as part of the context, but I need to check.

@claudiuchis I finished the PR if you want to review it. Found a couple of small unrelated bugs when making subscriptions work... There's a bit of a mismatch between what I expect to be in the checkpoint record (starting from 0) and what the first sequence element is (one), but it works.

It's the same way as, for example, NServiceBus SQL transport works. The database doesn't suffer from repeated calls that much when the query is so simple, I can see on a monitoring dashboard of the production MS SQL Server instance that a simple query that hits the database 2K times per minute uses very little CPU (as an example). It bothers people who look at query logs in the Management Studio, and they start to freak out, but in reality it's ok :)

Plus, although the connection is created, it comes from the pool anyway.

event store, aggregate and subscriptions (all stream, single stream), for now using Postgresql. But this implementation can work with any SQL database

Hello,
I really need for MS SQL database integration with eventStore for a project I am working based on Eventuous, when can this feature take place in Eventuous, please ?

MS SQL and Postgres are available. If anyone wants to pick up things like SQLite and MySQL - feel free. I might do MySQL as I want to try it with Aurora.


Add possibility of sliding with custom speed

Add customSpeed argument to methods slideTo(), next(), prev(), and
to private method slide().
Setting up a custom sliding speed is useful if you want frames to
move with natural speed wnen they are touch-sweeped, but more slowly
when sliding is caused by another reason (with next/prev/dots
controls or a timeout).

@nkudr Hey, first.... Thanks for contributing.
I'm just wondering how you feel about the slideSpeed option that already exists? Would it not be better to have an option for slide speed and an option for swipe speed? (If you really want to differentiate between the two speeds.) Thoughts?

@nstanard I thought about this approach. It may be suitable in some cases. But in my case (which has inspired me to make this pull request) custom speed (more slow) is needed only when next() is invoked by SetInterval when user doesn't interact with the slider. So I've preferred more flexible solution.

@nkudr Thank you for contributing!
I think we agree that this is special need that should not be implemented in the core of lory.js, therefore I will close this one.
Cheers Max


Question: meaning of the parameter MINHAPLEN

Following the title, I'm not sure of the meaning of this parameter, how it works, and if it have relation with SIZEMIN.
Could you please explain me a little bit better with an example?
Thank you Adam
Have a nice day
Leo

This is a parameter I wouldn't recommend you use. I've included a description of what it is doing below if you're curious. But in general as long as you don't provide --reference to bench or collapse, it will not use the --minhaplen parameter. The 'unroll' sequence comparison technique (i.e. not using --reference) is a more accurate measure of sequence similarity. details
Originally, truvari created a 'shared reference context' between variants to help improve the measurement of sequence similarity. However, this would inflate the sequence similarity between variants. For example, two non-overlapping deletions that are 100bp apart would have 100bp of reference sequence shared between their two haplotypes. This approach was designed to help deal with tandem repeats sequence contexts. The minhaplen would ensure that the sequences which were compared were of a minimum length. For example, consider these two deletions:
REF   ATCATCATC
D1     AT---CATC
D2    ATCAT---C

D1 Hap: CAT
D2 Hap: CAT

So each deletion leaves the same shared reference sequence. But what we found is that if there wasn't much sequence pulled from the reference, (in this example, just 3bp) the haplotype similarity became overly sensitive to small differences. So minhaplen would ensure that a minimum length from the variants' sequence context was being considered, which would inflate the above example from considering only 3bp to ±--minhaplen base pairs divided by 2 upstream/downstream.
The reference context method of variant sequence comparison (--reference) will be deprecated in a future version of Truvari has only been kept for backwards compatibility.

Thanks Adam!


Commit processing: handle for event “Device Was Disconnect”

May be we can postpone tests for this functionality to next release? I high loaded now.

Personally, I wont sign off on this PR without tests because Im scared of what is being added here could break the existing code and I want that reassurance. But if you can convince @ssteveli that they are not needed then Ill drop it.

Agreed, we need test coverage... there has been to much instability reported on the SDK from our customers.

Added some unit tests, details in description of 753ee5a114a476b9f59543b3d6c18f77cfc75543 commit.
Also, I have a question. Is it normal behavior when we are failing sync if payment device was disconnected?


Need to explicitly quantify minimum software levels for various features

Some of the APIs used in DCM Tools (and in some cases, particular features of the APIs) rely on certain OS levels.
We should:

Identify and document the minimum software requirements for the various features
Add code checks to provide proper errors if those requirements are not satisfied. For instance, if a user is running on IBM i 7.3 but IBM i 7.4 is needed for a certain operation, it should clearly say so at runtime.

Will definitely need @tlhaze's help with this!

The ability to "Renew" a certificate which calls the QycdRenewCertificate API was first available in IBM i 7.4.
Other tasks such as importing certificates via the QykmImportKeyStore API, assigning certificates via the QycdUpdateCertUsage API, and retrieving certificate details via the QycuRetrieveCertificateInfo API are possible on earlier releases.


Fix issue #324: Re-using the same dataset in another chart (for example, in tabs) causes a failure.

This pull request fixes issue #324.

Let me know if you have any questions.

Hi @jerairrest , I haven't heard anything back from you on my previous posts to review this pull request, so I'm getting the sense that you're not interested in it.
I'd consider it a personal favor if you would let me know either way, and I can stop sending requests to review the pull request which I'm sure you can appreciate.
Respectfully,
Brad

Hey Brad!
I apologise for being MIA from this project. :( I'll attempt to look at this pull request tonight.
Thanks for contributing
Jer

Thanks, Jeremy, for looking at my PR and merging it.
Brad


Add test cases for diffing changes to modules

I have implemented the test cases for Adding, removing and modifying a module.
Fixes #10
@NathanReb, @shonfeder, @dinakajoy

Remember to look at the CI checks to see if your PR builds correctly and is properly formatted.
When writing or editing tests you'll want to run dune runtest to see if it all works. You can read the relevant part of the contributing guide.
In particular here it should show an error, just as it did in #14. See https://github.com/NathanReb/ocaml-api-watch/pull/14#issuecomment-1982303593 for what to do with it!

The pull request has been open for an extended period, and @Dezzy12 hasn't been actively contributing to it. Would it be acceptable for me to take over and continue working on this pull request? @Dezzy12 @NathanReb @shonfeder
I would also get a chance to verify my work on https://github.com/NathanReb/ocaml-api-watch/pull/24.

Let's give a bit of time for @Dezzy12 to reply with whether they still have the time and energy to see this thru. Thanks, @harshey1103!

@harshey1103 please go ahead with it. Encountered some issues that I have to sort. So as not to hold down this issue for too long, you can have it if that's okay by @shonfeder

@harshey1103, could you please comment on #10 so I can assign that issue to you (GitHub doesn't let us assign issues to people who haven't commented on them).

Closing in favor of #25


Find processes hanging and piling up

Loading folders with many files (in my case loading the home folder with code .) leads to hanging find processes piling up. This seems to be related to the issues stated in #11181.
find -L . -not ( ( -name .git -o -name .svn -o -name .hg -o -name .DS_Store ) -prune ) -type f
Every process uses ~100% of the assigned CPU core which eventually leads to the whole CPU being used.

VSCode Version:
Version 1.8.1
Commit ee428b0
Date 2016-12-19T14:41:20.664Z
Shell 1.4.6
Renderer 53.0.2785.143
Node 6.5.0

OS Version:
Ubuntu 16.04 LTS

Steps to Reproduce:

Go to directory with many files
Run code .

Thanks

The processes shouldn't pile up, that needs to be investigated.
If the find command takes that long because there are so many files, you could add more exclusion filters in the configuration to speed things up.

Running the command manually gives me this error: bash: syntax error near unexpected token (
Without any braces the command executes but takes a long time.
http://explainshell.com/explain?cmd=find+-L+.+-not+(+(+-name+.git+-o+-name+.svn+-o+-name+.hg+-o+-name+.DS_Store+)+-prune+)+-type+f
There seems to be a problem with symbolic links in my .wine directory.
Even though the -type f option is provided to skip symlinks it takes very long (the process was still running after 10minutes).
Running tree tells me i have 60176 directories, 393080 files and that takes about 20-30s.
Would it be an option to scan more shallow? Maybe using find -maxdepth X?

What if you exclude the .wine folder in the search.exclude setting? I guess you don't need these files in the search results. Maybe that folder contains some special mount points that make find take very long?

This does help. I had to add the exclusion to the  files.exclude setting.
After that the find process exits after a few seconds.
I noticed that the watcherService was running long as well.
Adding the exclusion to files.watcherExclude seems to help a little.
I added it to search.exclude as well.
Thanks for the help!

files.exclude should affect both search and the file explorer. Closing as resolved. Thanks.

I ran into this with occasionally ending config scripts in the home folder on ubuntu 16.04 and I find the files.exclude impractical as there are so many folders to exclude. I noticed Atom editor does not have this issue with my home folder, it happily hums along at next to no CPU usage.

We have replaced find with ripgrep. Is this still an issue?

Just tried my home folder, and I got 2 rg processes each pulling 100% on different CPU core for 5 min and keeps going. On the other hand editing file seems to be fine. From a CPU usage perspective, I think it hasn't improved but vscode is responsive for editing files which is great. Testing is done on a dell precision 5520 laptop with quad-core i7 CPU.

How many files are in your home folder?

1607914 returned from find . type -f | wc -l in home folder.
Cheers,
Chris
+64279375686
On Fri, Dec 1, 2017 at 2:11 PM, Christof Marti<EMAIL_ADDRESS>wrote:

How many files are in your home folder?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/18033#issuecomment-348372114,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAaMC6X6TmKggkcP2p_3OdcwVS88cUsCks5s71JcgaJpZM4LZd4p
.


css doesn't reset back after pseudoClassStateChanged

I've created boolean bindings to lock and unlock the buttons, but after using the pseudoclass the css does not seem to be restored, how can I fix it?
before

after

I'm using this to customize css

.jfx-text-field:validation-error {
    -fx-background-color: #ffcccc ;
}
.jfx-date-picker:validation-error .text-field {
    -fx-control-inner-background: #ffcccc ;
}
.jfx-combo-box:validation-error {
    -fx-background-color: #ffcccc;
}
.jfx-time-picker:validation-error .text-field {
    -fx-background-color: #ffcccc;
}

and this in java
       nodo.pseudoClassStateChanged(PseudoClass.getPseudoClass("validation-error"), invalid);
where invalid is boolean
I fix adding this to css
.jfx-text-field, .jfx-date-picker .text-field, .jfx-combo-box, .jfx-time-picker .text-field {     -fx-background-color: transparent;     -jfx-focus-color: #1b75bc; }
but it's normal?

Hello,
if you are changing the pseudo state correctly in code then no it's not normal. will look into it, thanks for pointing out the issue 👍 .
Regards,


Show import paths in API docs

I often wish the API docs would show the import paths at the top, like
import {ToggleButtonGroup} from '@material-ui/lab/ToggleButton'

Because it would be faster than searching through the code examples in the demos for the paths.

@jedwards1211 The import path is always following the same convention. Why would you need such documentation?

I'm confused, what is the convention for ToggleButtonGroup then?

Or withStyles, which is under @material-ui/core/styles/withStyles instead of a root module, etc?  I'm not convinced there's that much of a convention.
In any case, explicit documentation of the import path can never hurt -- if you're mainly protesting against the time this would take to implement, you can always just ask me to make my own PR :wink:

To elaborate on this more, MuiThemeProvider is shown as a sibling of all other components in the documentation pages, which would suggest that it can be imported in the same way as the other components.  Yet it lives under @material-ui/core/styles rather than @material-ui/core.

This import path shouldn't be working:
import {ToggleButtonGroup} from '@material-ui/lab/ToggleButton'

It should be:
import ToggleButtonGroup from '@material-ui/lab/ToggleButtonGroup'

Yes, the styles folder is an exception to the rule. In the future. I want to explore the possibility of publishing it under it's own package @material-ui/styles.

In any case, explicit documentation can never hurt

Too much documentation can harm, creating noise. But in our case, I agree. It can be useful. Any idea how we could implement it?

This import path shouldn't be working
If that is the case, we need to fix the demo code, because I got it from one of the demos.

I want to explore the possibility of publishing it under it's own package
That makes sense, would make things more consistent

Any idea how we could implement it?
I'm looking through the code right now.  I've found where I could insert the import example in generateMarkdown, just have to write some code to intelligently figure out the import path (may use jscodeshift to examine the source files to determine this).


Mobile Nav Fixes

Pr closes #13.
I included a dependency update from running npm audix fix with this dev. Let me know if I should revert that back.
Changes are mostly css changes. Most notable functional change is that the mobile menu no longer supports hover to expand sub menu. This was done by implementing a mobile specific menu item. The items now have to be clicked to expand and show submenu. Hovering over submenus was clunky and a bad user experience when the submenu is long and drastically changes the overall menu height.

Everything looks great, but I might just modify handleShowSubMenu to check if it's coming through hover and decide on screensize whether or not to run the event handler. Having 2 separate DOM flows seems like a bit.

@psusmars Removed the multiple DOM flows and now check for the window width and do no op if on mobile menu size.


[DOCS]

Description
Hey I would like to update the README file so that It can give more information about the project.
I would also like to translate it in Hindi language for Hindi speakers to understand the project better.
Screenshots
No response
Additional information
No response

Hey @Anugyagupta43, it's a great thing to consider!
but for now, it's not what I want to focus on, maybe sometime in the future, when the product is ready to be rolled out.


Enable jira notifier

For details, please refer to the commit messages of the respective commits.

You probably don't want to have that merge commit in here, I guess...

You probably don't want to have that merge commit in here, I guess...

@sschuberth The "Require linear history" option is enabled in the branch protection rules. Do you happen to know how GitHub handles this with PRs? I never dared trying. I wonder why it does not report this as an issue here. It's the same in the ORT repository.

Do you happen to know how GitHub handles this with PRs? I never dared trying.

No, me neither. I guess it will simply get rid of the merge commit during "rebase and merge".


[1.20.1-Forge] Crash when loading server.

Title^
Seems its conflicting with mods.
Simple Discord Link Bot: 2.2.2 | https://legacy.curseforge.com/minecraft/mc-mods/simple-discord-link-bot-forge-fabric-spigot/files/4578593
CraterLib: 1.0.1 | https://legacy.curseforge.com/minecraft/mc-mods/craterlib/files/4609413
Logs: https://gist.github.com/Gbergz/2ab0bb39f76d92bdac3f80126f690f47
- Gbergz

This log gives absolutely no crash trace.  Please find the crash log.

There is no crash log.

what you just sent is the crash trace needed anyway

Gotcha, here's the text in raw form copied from console window.
https://gist.githubusercontent.com/Gbergz/20af525b58a2070068ed9868936d9f1e/raw/075286102dd5a144b5d16483a8be0bd411210e76/gistfile1.txt

as you can see, the conflict is rftools, which shares the same library as simplerpc.  due to a recent change in forge, two mods cannot share libraries.  one or the other will need to eliminate this dependency or agree to share a core mod.
(specifically the library fasterxml)

It gives a different mod as the cause each time I boot.

it's telling you a different wording because of thread race.  each mod can load whenever the hell they want and not in a specific order.  the error here is the same.  fasterxml is present in both mods, causing a crash

make sure your modloader is up to date or using the stable branch

This is a know issue with any mod that uses JACKSON. I have to go compare our new V3 alpha builds to V2 to figure out whats different, since V3 doesn't have this issue.
Also, you're the second one in two days using GModloader. What is up with that? Never even heard of it till yesterday

Gotcha.
Groovy Modloader is a library addon: https://legacy.curseforge.com/minecraft/mc-mods/gml
It's in the modpack because of this mod: https://legacy.curseforge.com/minecraft/mc-mods/eating-animation-forge
It has it as a dependancy.

I see. Was just wondering lol.
But yeah, in this case, the conflict is with Groovy Modloader. That was discovered yesterday, so forge is not really doing a good job of identifying the correct conflicts

So, I forgot Eating Animations is a client mod, So is the Groovy Modloader mod too apparently.
So I can remove it, and now it boots fine.

This issue should now be fixed with 2.2.3. I tested this myself and the server booted up without crashing


db2 Image build failed

I'm not able to build the db2 image. Process stopped at step 35;
Step 35/45 : RUN wget -q $url/$DB2_IMAGE   && bsdtar -zxpf $DB2_IMAGE   && ./server_awse_o/db2setup -r ./db2awse.rsp   && /opt/ibm/db2/V11.1/adm/db2licm -a ./server_awse_o/db2/license/db2awse_o.lic   && /opt/ibm/db2/V11.1/adm/db2licm -l   && rm -rf *
---> Running in<PHONE_NUMBER>a2
The command '/bin/sh -c wget -q $url/$DB2_IMAGE   && bsdtar -zxpf $DB2_IMAGE   && ./server_awse_o/db2setup -r ./db2awse.rsp   && /opt/ibm/db2/V11.1/adm/db2licm -a ./server_awse_o/db2/license/db2awse_o.lic   && /opt/ibm/db2/V11.1/adm/db2licm -l   && rm -rf *' returned a non-zero code: 4
Please help.
Thanks in advance

Also identical error when attempt to build installation manager image;
Step 9/10 : RUN mkdir /Install_Mgr && wget -q $url/$IM_IMAGE  && unzip -q -d /Install_Mgr $IM_IMAGE  && rm $IM_IMAGE  && /Install_Mgr/EnterpriseDVD/Linux_x86_64/EnterpriseCD-Linux-x86_64/InstallationManager/installc -log /tmp/IM_Install_Unix.xml -acceptLicense  && rm -rf /Install_Mgr
---> Running in 879f2f1a5442
The command '/bin/sh -c mkdir /Install_Mgr && wget -q $url/$IM_IMAGE  && unzip -q -d /Install_Mgr $IM_IMAGE  && rm $IM_IMAGE  && /Install_Mgr/EnterpriseDVD/Linux_x86_64/EnterpriseCD-Linux-x86_64/InstallationManager/installc -log /tmp/IM_Install_Unix.xml -acceptLicense  && rm -rf /Install_Mgr' returned a non-zero code: 4
Do I need to modify the docker file?
Thanks in advance

Hi,
This is a network related error in wget. Please make sure the nginx container has been started.
Thanks,

Hi,
Yes, the nginx container is running. However still get above error.

Hi,
Thanks for the clarification. Both containers are successfully built
Thank you.


Bot 4 not doing anything

Hey, when i run the Bot it isnt doing anything. I press start and nothing happens.

Screenshots/copy paste the log

thats all, where or how do i find logs?

ok i looked into the logs and it says key error 166

ok nvm disabling heavy scrape fixed it

ok now it has to verify everytime after i send one message, is there a way around that?

and my account got deactivated

Heard issues of being logged into the account at the same time as running the script gets the account banned.
Along with public proxies


feat(convert): add distributed format

Proposal of a new format for convert command. Possible things to address:

[ ] Mocking the env variables
[ ] compatibility with older kong versions

Codecov Report
Patch coverage: 21.31% and project coverage change: -0.08 :warning:

Comparison is base (3184491) 35.59% compared to head (a964bb6) 35.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #874      +/-   ##
==========================================
- Coverage   35.59%   35.52%   -0.08%
==========================================
  Files          92       92
  Lines       11273    11309      +36
==========================================
+ Hits         4013     4017       +4
- Misses       6867     6897      +30
- Partials      393      395       +2

Impacted Files
Coverage Δ

cmd/convert.go
0.00% <0.00%> (ø)

convert/convert.go
74.26% <23.07%> (-15.10%)
:arrow_down:

file/writer.go
14.86% <23.52%> (+0.32%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@zekth it seems a test is failing due to some nil reference:
=== RUN   Test_Convert/converts_from_distributed_to_kong_gateway_(no_deck_specific_fields)
--- FAIL: Test_Convert (0.24s)
    --- PASS: Test_Convert/errors_out_due_to_invalid_conversion (0.03s)
    --- PASS: Test_Convert/errors_out_due_to_invalid_conversion#01 (0.02s)
    --- PASS: Test_Convert/errors_out_when_a_nameless_service_is_present_in_the_input (0.01s)
    --- PASS: Test_Convert/errors_out_when_input_file_doesn't_exist (0.00s)
    --- PASS: Test_Convert/converts_from_Kong_Gateway_to_Konnect_format (0.09s)
    --- PASS: Test_Convert/converts_from_Kong_Gateway_2.x_to_Kong_Gateway_3.x_format (0.04s)
    --- PASS: Test_Convert/converts_from_Kong_Gateway_2.x_to_Kong_Gateway_3.x_format_(no__format_version_input) (0.04s)
    --- FAIL: Test_Convert/converts_from_distributed_to_kong_gateway_(no_deck_specific_fields) (0.01s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xb421ef]

Would you mind checking?

As per internal discussion, this functionality is to land in its own command "render", which is to be a subcommand of the new "file" command.
Since the "file" command is introduced in #939 , it makes sense to target that branch for now, instead of main.

closing in favour of #963


Update manifests/t/Tencent/QQ/<IP_ADDRESS>149/Tencent.QQ.locale.en-US.yaml

Fixes an issue where this package has multiple different monikers
Microsoft Reviewers: Open in CodeFlow

Needs Attention

@wingetbot run

[Policy] reset feedback

[Policy] Needs-Attention

@wingetbot run

@wingetbot run


Fix: Issue #845

@drnic @cppforlife in regards to issue #845 ::
If you sudo to root as using a login shell:
sudo su -

or
sudo su -l

then monit was not in the path.
If you sudo to root using a non-login shell:
sudo su

then monit was in the path.
The reason for this is that in bash for a login shell it only loads $HOME/.bash_profile and for a non-login shell it only loads $HOME/.bashrc.  The code only wrote a /root/.bashrc and not a /root/.bash_profile.
This patch adds the /root/.bash_profile file which sources /root/.bashrc which adds $bosh-dir/bin to $PATH and thus monit will now be in a root login shell's path.
~Wayne

Let's just do what Ubuntu does:
root@4f2e1302-9a4e-4996-6059-5519e7fa70e3:/home/vcap# cat /root/.profile
# ~/.profile: executed by Bourne-compatible login shells.

if [ "$BASH" ]; then
  if [ -f ~/.bashrc ]; then
    . ~/.bashrc
  fi
fi

merged into develop


Got a problem! Only one url have been scanned

Here is hosts.txt

It's hard for me to identify the problem with the host count when the hosts.txt file contents are blurred. A possible explanation could be that the file contains duplicate hosts which are de-duplicated by Aquatone when it extracts targets from the content.
As for the missing screenshots, try to increase timeouts with the -scan-timeout and -screenshot-timeout flags.

Thank you so much. -scan-timeout solved the problem.
By the way, the default value of -scan-timeout is so low. Hope you can optimize it.
Thanks again.


Use Kerl instead of Curl

This fix the GetUsedAddress function.
Most of the logic come from the JS library.

Hey, thank you for this!
Could you maybe try replacing as many of the numbers (6561, 243) with the respective constants? And I assume that some of the tests might have to be updated as well?


Default to an empty dictionary if the observable component hasn't return anything yet

I noticed when using this that a streamlit application will show an error how I cannot call get of NoneType. I realized that initially the observable component does not return a dictionary. I think it would be best to either return an empty dictionary or specify that it could be None. Based on the documentation, "If the observe parameter is empty, then the dict will be empty." An empty dictionary makes the most sense.
Let me know if you have any thoughts.

Thanks for the fix, looks great!


repair strange "echo   .... " lines

This is important step for further changes

These are escape sequences that simply colour the output. For example, this:
@echo off
echo Normal text
echo  Red text

Will output:

...Let's close this one?


Add better handling for not open source (fixes #189)

This removes the LICENSE file and omit badges and links for
ReadTheDocs, Travis and PyPI when project is not open source.
Looks good?

The rest all looks good!


Redirect stdout/stderr for fish command in fish configuration scripts

I am trying to migrate to fish and I found the fish configuration scripts for hishtory is buggy.
I always get some gabbage escape sequence after sourcing ~/.hishtory/config.fish

Upon investigation, it seems that sometimes hishtory print message to stdout/stderr, which confuse fish.
In this PR, I

redirect all the command to &> /dev/null
use fish_postexec to simplify code.
cleanup the style

Related issue https://github.com/ddworken/hishtory/issues/253

I have been using this config for a while and it is working well. @roland-5 You can try this by copying the file to ~/.hishtory/config.fish to try it without rebuild hishtory.

It's working. Thanks. <3

@ddworken https://github.com/ddworken/hishtory/pull/260 didn't repair for me https://github.com/ddworken/hishtory/issues/253
Would this will be accepted?


Add support for tag & group

Allow creation of notification defined with specific tag and group.

Hello @GitHub30
Did you get a chance to look at my PR ?

Thanks !


Update _cat/indices to new, paginated _list/indices API

Is your feature request related to a problem?
We should use the new _list/indices API instead of _cat/indices to better handle fetching of indices as current cat API consumes too many resources.
Issue for new _list/indices API: https://github.com/opensearch-project/OpenSearch/pull/15986
issue for context on limitation of CAT api: https://github.com/opensearch-project/OpenSearch/issues/15954
What solution would you like?
Changing to a paginated API means we need to potentially change our UI as well as we will either need a mechanism to make API calls to the next set of results or relay more so on our search functionality and only display a limited (1k) number of results on the frontend at a time.
Options:
Option 1: Make the changes to list/indices and we set default to 1k without implementing pagination.
Pros:

Quicker implementation and clusters with over 1k indices are less common
Users don’t usually scroll through 1k indices in drop down without search

Cons:

Users will only see up to 1k indices, They need to search to easily find their index if they have more then 1k but technically it also means search results will only show up to 1k results.

Option 2: Change index selection drop down to include pagination or other UI based mechanism to fetch the next page of results
Pros:

This means that the user has a way to view all indices through the drop down

Cons:

Viewing all indices through a drop down when we reach 10k+ indices might be less useful as the number of "pages" might get too high

I would recommend providing a drop down that can lazy load. Specifically, it will load the next batch of data once the user scrolls to the end of first batch. @virajsanghvi, does selectable or combobox OUI components support any sort of lazy loading?

Additionally @virajsanghvi I see that we have an example of a combo box utilizing react-window but I am not sure if the demo JS is correct: https://oui.opensearch.org/1.17/#/forms/combo-box#virtualized
Would this solution be good to use here for the paginated _list/indices API or should we have another lazy loading solution when we reach the bottom of the list.

I think the combo box virtualizes by default, which is why the demo js doesn't have anything called out. Virtualization assumes you have all the options though.
It looks like the component supports async search, https://oui.opensearch.org/1.17/#/forms/combo-box#async, but that doesn't handle loading.
I don't see a component that supports this out of the box, but maybe @AMoo-Miki may know of a component or example somewhere.

[Catch All Triage - 1, 2, 3, 4, 5]


Vagrant for cross-platform doc builds

@hamishwillee brought up the great idea of adding vagrant so any Windows user can help build our docs as well. #43
I left the Vagrantfile on project root mainly because we need to install the requirements.txt pip packages to be able to build the autodocs, this means your 1 liner needs to change to this:
vagrant ssh -c "cd /vagrant && make html"

@hamishwillee please add to this branch the contributing changes on the README, there are also lots of WARNINGS on the doc builds im not sure how to fix those, can you please help?
fixes #43

The file itself looks good.
IFF there might ever be a need for a different set of vagrant tools, it would be better to move this from the root to /tools/doc/
I'll look at the readme changes and build warnings on Tuesday.
Thanks!

the reason behind it being in root is because we need to install the pip requirements before we can generate the autodocs, also i think having many vagrant images is overkill, what do you think?, going forward we should try to incorporate everything into this vagrant image

Thanks for explanation.
I am completely supportive of the idea of a single vagrant file for "everything" if that is possible - provided we con't compromise on the ease-of-use of the system for different purposes. Would this be used for dronekit image VM too?
W.r.t. the pip requirements I don't really understand - maybe the vagrantfile could take relative file requirements inputs, and indeed you can include requirements in the vagrantfile itself. Given that we'll have only one vagrant file it is not really an issue, and I will assume you've looked into the limitations and know what will work. Thanks!
Will try look further into warnings and test this on Tuesday.

Hi Ramon
I have added "	Tidy heading levels and fix doc build warnings caused by errors in " above.
There were three sources of DOCS warnings

in getting_started, the heading underlines were shorter than the headings.
in init.py there were some errors in the text definitions read by sphinx (e.g. :returns instead of :return:)
Images are being imported by URL rather than by file system path

The change fixes the first two warnings. Is there any reason that files like https://github.com/diydrones/droneapi-python/raw/master/example/documentation/drone-delivery-splash.png cannot/should not be in the docs themselves?
The other changes were tidy up to the headings for consistency with our android docs.
There are lots of other warnings, but these are related to the code itself, and not the docs.
With respect to your above comments, to build the docs we need to do:
vagrant ssh -c "cd /vagrant/docs && make html"

Otherwise this is great. Would be good if this change went in master. I haven't created docs on how it is used yet. My thought was that I might do it in my own fork and then contribute back to master. This is less confusing to me than messing with the vagrant branch ....

PS Is that everything you needed from me?

@hamishwillee i rebased with master and fixed some conflicts, can you double check everything is in order before merge?

@mrpollo Looks good to me - thanks for rebasing (I think this might have been avoided if I had been more careful). Please do commit!

perfect!! :star: :star: :star:


TFM_PROFILE and TFM_ISOLATION_LEVEL

New TFM_PROFILE and TFM_ISOLATION_LEVEL configurations.
Change how Nucleo L552ZE Q sets the isolation level.
Required by: #30013 to set TFM_PROFILE on LPC55S69
Depends on: zephyrproject-rtos/trusted-firmware-m#29

FYI #30062 and https://github.com/zephyrproject-rtos/trusted-firmware-m/pull/21
This PR should work fine with the above, I added support for the new PROFILE and ISOLATION_LEVEL configs. With the above, the changes under samples/ are not needed.

FYI #30062 and zephyrproject-rtos/trusted-firmware-m#21
This PR should work fine with the above, I added support for the new PROFILE and ISOLATION_LEVEL configs. With the above, the changes under samples/ are not needed.

With the rebase on top of these changes, the samples/ commit was skipped.


[Nitpick] 24th notes are unreadable

Using the default theme, 12th notes are some kind of magenta / purple color, and 24th notes are the exact same shade.  It is really a challenge to read a 24th note snuck into a stream of 12th notes.  The editor shows a much darker purple color for 24th notes.  It would be great to use that color instead of the same magenta used for 12th notes.
Thanks!

I am changing the default noteskin to use the "note" standard colors.

Sounds great!  Thanks!


FAST: IAM cleanups to reflect PF changes

This PR retrospect-fixes a few IAM leftovers on the FAST networking stages.
In particular:

the service_project_network_admin custom role is assigned to the PF SA by 1-resman at folder level, so the project-level assignment done by 2-net is not needed
roles/dns.admin is not required anymore since the PF doesn't deal with DNS management anymore (even though it could arguably be configured to assign DNS roles to other principals)

Good points, I also tackle them in the resman-ng branch, if you're not in a hurry can we discuss this holistically next Mon? :)


Can't type spaces in input or textarea form fields nested inside the Modal element

Describe the bug
When I nest a form inside the Modal element from the react-modal library, the user input into the input (or text area) field do not allow spaces to be typed. So you can only enter a single word. When you type spaces, they don't register. It's like whitespace is automatically trimmed.
To Reproduce
Steps to reproduce the behavior:

Go to the form
Type "test this" and it will show up as "typethis"

Reproducable Example
import Modal from "react-modal";

<Modal
  isOpen={this.state.modalIsOpen}
  onRequestClose={this.closeModal}
  contentLabel="Example Modal"
  >
  <form
    action="/submit"
    method="POST"
    >
    <textarea
      name="Description"
      id="styled"
      required
      />
   </form>
</Modal>

what about providing the fiddle of the code.
you can use codepen.io/jsfiddle.net etc

Never mind, turns out it was due to interference from the react-accessible-accordion library, not react-modal. Thanks!


world edit not working

World edit is not working in 1.19.2 please fix it.
When I type in //paste command it is not working

Please report the bug to FastAsyncWorldEdit.
This is not the place to report bugs with 3rd-party plugins.


Revert makie version bump

Seems to be when this broke?

Codecov Report

Merging #417 (8a7b1fc) into main (d985cda) will increase coverage by 3.76%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
+ Coverage   50.96%   54.72%   +3.76%
==========================================
  Files          80       80
  Lines        7741     7733       -8
==========================================
+ Hits         3945     4232     +287
+ Misses       3796     3501     -295

Impacted Files
Coverage Δ

src/Geometry/Primitives/Curves/Bezier.jl
56.47% <0.00%> (+0.58%)
:arrow_up:

src/Optical/OpticalSystem.jl
39.25% <0.00%> (+0.62%)
:arrow_up:

src/Optical/LensAssembly.jl
73.07% <0.00%> (+0.64%)
:arrow_up:

src/Optical/Fresnel.jl
97.40% <0.00%> (+1.29%)
:arrow_up:

src/Geometry/AccelSurface.jl
97.29% <0.00%> (+1.35%)
:arrow_up:

src/Geometry/Primitives/NonCSG/Triangle.jl
75.00% <0.00%> (+1.38%)
:arrow_up:

src/Geometry/CSG/Interval.jl
83.39% <0.00%> (+1.84%)
:arrow_up:

src/Geometry/Surface.jl
69.69% <0.00%> (+3.03%)
:arrow_up:

src/Geometry/Primitives/Sphere.jl
92.59% <0.00%> (+7.40%)
:arrow_up:

src/Geometry/Primitives/Cylinder.jl
87.03% <0.00%> (+7.40%)
:arrow_up:

... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[FIX] Gray "compromised" appears blue on my ipad. cannot tell it from blue.

Description of your issue, suggested solution and other information
Gray "compromised" appears blue on my ipad. cannot tell it from blue.
Sent by Typeform by Toby
Referencing #97 and #125 this is becoming a real problem.
Make sure you are using the latest version: pull latest commits before reporting any issues.

[x] I've verified and I assure that I'm looking at the latest version of Trump Tracker.

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably the To Do List section.
[x] Searched the bugtracker for similar issues including closed ones

We could change it to #b5cede


Add seeds to new (and old) fuzzers in master

Add seeds to new (and old) fuzzers in master.

Merged with $ ./test/fuzz/test_runner.py --m_dir ../btc_qa_assets/fuzz_seed_corpus_ps5/ ../btc_qa_assets/fuzz_seed_corpus --export_coverage


chore(deps): update dependency rxjs-marbles to v6

This PR contains the following updates:

Package
Type
Update
Change

rxjs-marbles
devDependencies
major
5.0.6 -> 6.0.0

Release Notes

cartant/rxjs-marbles
v6.0.0
Compare Source
Breaking changes

Use strict equality - toStrictEqual - by default for Jest. (c12ce82)

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

:tada: This PR is included in version 5.0.9 :tada:
The release is available on:

v5.0.9
GitHub release

Your semantic-release bot :package::rocket:


Single failing unit test when run inside the Docker image

docker run -it -v `pwd`:/mnt datasetteproject/datasette:latest /bin/bash
root@0e1928cfdf79:/# cd /mnt
root@0e1928cfdf79:/mnt# pip install -e .[test]
root@0e1928cfdf79:/mnt# pytest

I get one failure!
It was for test_searchable[/fixtures/searchable.json?_search=te*+AND+do*&_searchmode=raw-expected_rows3]
    def test_searchable(app_client, path, expected_rows):
        response = app_client.get(path)
>       assert expected_rows == response.json["rows"]
E       AssertionError: assert [[1, 'barry c...sel', 'puma']] == []
E         Left contains 2 more items, first extra item: [1, 'barry cat', 'terry dog', 'panther']
E         Full diff:
E         + []
E         - [[1, 'barry cat', 'terry dog', 'panther'],
E         -  [2, 'terry dog', 'sara weasel', 'puma']]

Originally posted by @simonw in https://github.com/simonw/datasette/issues/695#issuecomment-595614469

pytest -k test_searchable is faster.

I tried this just now against Datasette 0.56 with the new Dockerfile from #1249 (that uses SQLite and SpatiaLite installed with apt-get install) and the tests all passed.


Enable Application Test mode from UI

A couple of things need to be taken care of while enabling the test mode.

[x] Test mode on saving the source data displays saved successfully multiple times

[x] Test mode output displays nested data incorrectly

Raised PR https://github.com/hortonworks/streamline/pull/854


CSS are not rewritten and combined

Using latest nginx and ngx_pagespeed verison css is not rewritten at all. Even the smallest file which contains almost nothing is like totally ignored. Nothing on /pagespeed_admin/message_history.
There is page to test - http://www.suzuki.sidormedia.pl
pagespeed RewriteLevel PassThrough;
	pagespeed EnableFilters rewrite_css;
	pagespeed MaxCombinedJsBytes 10485760;
	pagespeed ImageInlineMaxBytes 5120;
	pagespeed CssImageInlineMaxBytes 5120;
	pagespeed MemcachedServers "localhost:11211";
	pagespeed EnableFilters resize_rendered_image_dimensions;
	#pagespeed EnableFilters inline_preview_images;
	pagespeed InPlaceResourceOptimization on;
	pagespeed EnableFilters inline_google_font_css;
	pagespeed EnableFilters outline_javascript;
	pagespeed EnableFilters combine_css;
	pagespeed EnableFilters fallback_rewrite_css_urls;
	pagespeed EnableFilters rewrite_style_attributes;
	pagespeed EnableFilters rewrite_style_attributes_with_url;
	pagespeed MaxSegmentLength 2048;
	pagespeed EnableFilters flatten_css_imports;
	pagespeed EnableFilters make_google_analytics_async;
	pagespeed EnableFilters rewrite_javascript;
	pagespeed EnableFilters combine_javascript;
	pagespeed EnableFilters inline_css;
	pagespeed EnableFilters inline_javascript;
	pagespeed EnableFilters local_storage_cache;
	pagespeed EnableFilters rewrite_images;
	pagespeed EnableFilters convert_jpeg_to_progressive;
	pagespeed EnableFilters convert_png_to_jpeg;
	pagespeed EnableFilters convert_jpeg_to_webp;
	pagespeed EnableFilters convert_to_webp_lossless;
	pagespeed EnableFilters insert_image_dimensions;
	pagespeed EnableFilters inline_images;
	pagespeed EnableFilters recompress_images;
	pagespeed EnableFilters recompress_jpeg;
	pagespeed EnableFilters recompress_png;
	pagespeed EnableFilters recompress_webp;
	pagespeed EnableFilters strip_image_color_profile;
	pagespeed EnableFilters strip_image_meta_data;
	pagespeed EnableFilters jpeg_subsampling;
	pagespeed EnableFilters convert_gif_to_png;
	pagespeed EnableFilters collapse_whitespace;
	pagespeed EnableFilters remove_comments;
	pagespeed EnableFilters extend_cache;
	pagespeed EnableFilters in_place_optimize_for_browser;
	pagespeed EnableFilters insert_dns_prefetch;
	pagespeed EnableFilters dedup_inlined_images;
	pagespeed EnableFilters elide_attributes;
	pagespeed EnableFilters sprite_images;
	pagespeed EnableFilters inline_import_to_link;
	#pagespeed EnableFilters lazyload_images;
	#pagespeed EnableFilters defer_javascript;
	pagespeed CriticalImagesBeaconEnabled false;
	#pagespeed EnableFilters prioritize_critical_css;
	pagespeed EnableFilters remove_quotes;
	pagespeed EnableFilters trim_urls;
	pagespeed EnableFilters inline_google_font_css;
	pagespeed EnableFilters canonicalize_javascript_libraries;
	pagespeed ModifyCachingHeaders off;
	pagespeed RetainComment " created_by*";
	include pagespeed_libraries.conf;
	pagespeed RetainComment " Google Tag Manager ";
	pagespeed RetainComment " End Google Tag Manager ";
	pagespeed AvoidRenamingIntrospectiveJavascript off;

Those my filters

Looking at your page with ?PageSpeedFilters=+debug I do see the js being rewritten [1] which is good.  But you're right that it's strange that the css is not rewritten, and that there's not even a debug comment inserted.
Looking at the list of filters debug prints, I do see cf	Rewrite Css.
I was looking more, but it looks like you've just turned off pagespeed?
[1] http://www.suzuki.sidormedia.pl/js/dist/frontend.js.pagespeed.jm.x-o0qV8heX.js

I just tried to reproduce this, setting up an example server with a copy of the css file and this same config, and didn't see the same issue.

Oh, I see your problem!  It's the:
<base href="/">

Do you need that?  It's making PageSpeed be cautious and not rewrite things that appear before it, but it also looks like it doesn't do anything to change how urls on your page are resolved?

(I think <base href="/"> means "resolve the urls in this document exactly as you would if this tag was not present", so I'm not sure why you have it?)

Yea you right, removed base and it works, thanks :)


ReactiveCocoa 3.0+ support

I'd love to be able to use Overcoat with ReactiveCocoa Swift, are there any plans for the support?

Hi @startupthekid, I don't really use ReactiveCocoa, but I would try to add it to Overcoat.
You're welcome to submit a PR for this too. :smile:

Overcoat already comes with RC as a submodule doesn't it? And maybe I will ;)

yup, but it was added by original project owner.
I'm new owner since this summer. :)
But as you say, Overcoat has supported old version already, so it should not be too hard to convert it.

:+1:

notes for implementation: https://github.com/CocoaPods/CocoaPods/issues/4376

Tested. Dependency settings are updated by 7b16ac8 (Podspec)


Tensorflow failed due to error LNK2019 when build with MSVC

System information
•	Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
N/A
•	OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Windows server 2016
•	TensorFlow installed from (source or binary):
Source
•	TensorFlow version (use command below):
Master branch latest revison
•	Python version:
Anaconda 4.1.1 (Python 3.5 64-bit)
•	Bazel version (if compiling from source):
N/A
•	GCC/Compiler version (if compiling from source):
VS2017 15.5.7
•	CUDA/cuDNN version:
NVidia CUDA Toolkit 8.0
NVidia CUDNN 5.1
•	GPU model and memory:
N/A
•	Exact command to reproduce:
N/A
Describe the problem:
Tensorflow failed to build due to the error LNK2019 and error LNK1120. This should be tensorflow source issue, could you please help take a look at this? Thanks!
The failures like:
The whole log file please see attachment.
[log_x64_build.log](https://github.com/tensorflow/tensorflow/files/1942013/log_x64_build.log)
(Link target) ->
         c_api.cc.obj : error LNK2019: unresolved external symbol "public: __cdecl tensorflow::CppShapeInferenceResult_HandleShapeAndType::CppShapeInferenceResult_HandleShapeAndType(void)" (??0CppShapeInferenceResult_HandleShapeAndType@tensorflow@@QEAA@XZ) referenced in function "protected: class tensorflow::CppShapeInferenceResult_HandleShapeAndType * __cdecl google::protobuf::internal::RepeatedPtrFieldBase::Add<class google::protobuf::RepeatedPtrField<class tensorflow::CppShapeInferenceResult_HandleShapeAndType>::TypeHandler>(class tensorflow::CppShapeInferenceResult_HandleShapeAndType *)" (??$Add@VTypeHandler@?$RepeatedPtrField@VCppShapeInferenceResult_HandleShapeAndType@tensorflow@@@protobuf@google@@@RepeatedPtrFieldBase@internal@protobuf@google@@IEAAPEAVCppShapeInferenceResult_HandleShapeAndType@tensorflow@@PEAV45@@Z) [D:\Tensorflow\build_x64\tensorflow.vcxproj]
         c_api.cc.obj : error LNK2019: unresolved external symbol "protected: __cdecl tensorflow::CppShapeInferenceResult_HandleShapeAndType::CppShapeInferenceResult_HandleShapeAndType(class google::protobuf::Arena *)" (??0CppShapeInferenceResult_HandleShapeAndType@tensorflow@@IEAA@PEAVArena@protobuf@google@@@Z) referenced in function "protected: class tensorflow::CppShapeInferenceResult_HandleShapeAndType * __cdecl google::protobuf::internal::RepeatedPtrFieldBase::Add<class google::protobuf::RepeatedPtrField<class tensorflow::CppShapeInferenceResult_HandleShapeAndType>::TypeHandler>(class tensorflow::CppShapeInferenceResult_HandleShapeAndType *)" (??$Add@VTypeHandler@?$RepeatedPtrField@VCppShapeInferenceResult_HandleShapeAndType@tensorflow@@@protobuf@google@@@RepeatedPtrFieldBase@internal@protobuf@google@@IEAAPEAVCppShapeInferenceResult_HandleShapeAndType@tensorflow@@PEAV45@@Z) [D:\Tensorflow\build_x64\tensorflow.vcxproj]
         c_api.cc.obj : error LNK2019: unresolved external symbol "private: void __cdecl tensorflow::CppShapeInferenceResult_HandleShapeAndType::_slow_mutable_shape(void)" (?_slow_mutable_shape@CppShapeInferenceResult_HandleShapeAndType@tensorflow@@AEAAXXZ) referenced in function TFE_GetResourceHandleShapeAndType [D:\Tensorflow\build_x64\tensorflow.vcxproj]
         c_api.cc.obj : error LNK2019: unresolved external symbol "public: __cdecl tensorflow::CppShapeInferenceResult_HandleData::CppShapeInferenceResult_HandleData(void)" (??0CppShapeInferenceResult_HandleData@tensorflow@@QEAA@XZ) referenced in function TFE_GetResourceHandleShapeAndType [D:\Tensorflow\build_x64\tensorflow.vcxproj]
         c_api.cc.obj : error LNK2019: unresolved external symbol "public: virtual __cdecl tensorflow::CppShapeInferenceResult_HandleData::~CppShapeInferenceResult_HandleData(void)" (??1CppShapeInferenceResult_HandleData@tensorflow@@UEAA@XZ) referenced in function TFE_GetResourceHandleShapeAndType [D:\Tensorflow\build_x64\tensorflow.vcxproj]
         D:\Tensorflow\build_x64\Release\tensorflow.dll : fatal error LNK1120: 5 unresolved externals [D:\Tensorflow\build_x64\tensorflow.vcxproj]

Repro steps:

git clone https://github.com/tensorflow/tensorflow D:\Tensorflow\src
pushd D:\Tensorflow
set PreferredToolArchitecture=x64
set rel=Release
set CUDNN_HOME="C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v9.0\cuda"
set PY=C:\ProgramData\Anaconda3
set CL=/FS /permissive-
cmake D:\Tensorflow\src\tensorflow\contrib\cmake -A x64 -DCMAKE_BUILD_TYPE=Release -DPYTHON_EXECUTABLE=C:\ProgramData\Anaconda3\python.exe -DPYTHON_LIBRARIES=C:\ProgramData\Anaconda3\libs\python36.lib -DSWIG_EXECUTABLE=D:\Tensorflow\swigwin-3.0.12\swig.exe -Dtensorflow_BUILD_PYTHON_TESTS=ON -Dtensorflow_BUILD_SHARED_LIB=ON
MSBuild /m /p:Configuration=Release;Platform=x64 /p:WindowsTargetPlatformVersion=10.0.16299.0 tensorflow.sln /t:Rebuild

@gunan Can you take a look at this? I don't have a Windows device for reproductions.

There are some known build issues with visual studio 2017. It may just be those.
I dont have a better answer at the moment as we currently use VS 2015 update 3 to build TF on windows.

Hi @gunan. Thanks. I found that this issue can be reproduced from master revision f196351c. Hope it will help solve this issue.

Nagging Assignees @gunan, @angersson: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignees @gunan, @angersson: It has been 31 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

I sent a few fixes and was able to successfully build with vs 2017, but I forgot to close the issues.
Please reopen if you still run into the same problem.

Thank you for fixing this issue, @gunan. I tried your fix and Tensorflow works well.


3D pull request into main

Was keeping 2d stuff in main until 3d worked, have now moved it to another branch.

3D model is now the main branch and will continue to be worked on.
The 2D branch is just for safekeeping in case that additional functionality is desired later.


Prettier

Issue Type: Bug
Prettier not showing in status bar anymore
VS Code version: Code 1.40.0 (86405ea23e3937316009fc27c9361deee66ffbf5, 2019-11-06T17:09:34.601Z)
OS version: Darwin x64 18.2.0

/causedByExtension https://github.com/prettier/prettier-vscode/issues/1044


Disable public uploads

I'm looking to use this as a private tool for filesharing via ShareX, but it seems to me that anyone with the URL can upload files. I'm looking to only allow downloads.

There's an api_key setting in config.js - just set that to nothing and it'll prevent uploads on the web side. You'll still need to set the API key in ShareX though.

Ah. I see it now. I was confused because it still allowed me to download the files. I did not realize it was a cached copy.


-e flag doesn't work with some apps

https://user-images.githubusercontent.com/29358657/178109937-e0310b68-e647-4635-9ec3-267c24c61b08.mp4

found the cause of the problem:
I've changed this line:

like this:


Update huggingface_hub requirement version

System Info
peft 0.13.0
huggingface_hub 0.19.4 (due to other dependencies)
Who can help?
No response
Information

[ ] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder
[ ] My own task or dataset (give details below)

Reproduction
from peft import LoraConfig

The following error is raised:
File /dccstor/geofm-finetuning/francescmartiescofet/masters-thesis/.pixi/envs/default/lib/python3.12/site-packages/peft/utils/loftq_utils.py:26
     [24] import torch
     [25] from huggingface_hub import snapshot_download
     [26] from huggingface_hub.errors import HFValidationError
     [27] from huggingface_hub.utils import LocalEntryNotFoundError
     [28] from safetensors import SafetensorError, safe_open

ModuleNotFoundError: No module named 'huggingface_hub.errors'

Expected behavior
Import the library correctly.

Duplicate of #2097. LMK if you would be interested in creating a PR to implement the solution posted there.


Improve algorithm for reflection

Some parts of the code are using a reflection cache and some others are not. Also, we are splitting logic in many places when it seems that doing a single loop and saving results in a cache to be reused elsewhere in the code would be easier and more performant.
AB#2050309

I was researching this, and we can improve the speed by 10% or more by doing this, (this cuts the time time in reflection to half) by grabbing the collection of attributes once from assembly, class, and method. And pass them down where needed. This has impact especially on paths where we grab attributes with inheritance.
The implementation would replace the many calls to:
method.GetCustomAttributes<TestMethodAttribute>()
method.GetCustomAttributes<PriorityAttribute>()
method.GetCustomAttributes<TestCategoryAttribute>(inherit: true)

with
IReadOnlyCollection<Attribute> methodAttributes = method.GetCustomAttributes();
IReadOnlyCollection<Attribute> inheritedMethodAttributes = method.GetCustomAttributes(inherit: true);

methodAttributes.GetSingleOrNull<TestMethodAttribute>();
etc.

And similarly for Assembly, and Class, where we just need to grab the collection once and pass it down where needed.
Also calls retrieve the attribute and compare to null should be avoided, and replaced either with the api above, or with IsDefined.
More measurements need to be made, e.g. around allocation, but most of the changes are (crudely) implemented here:  https://github.com/nohwnd/testfx/tree/discovery-optimize-and-break

I did some measurements and benchmarks and this is my plan:

[ ] unify usage of reflection

Split the usage of reflection into 2 categories, cached and non-cached. All the places that touch all types to see if the class or method is a test will use reflection "directly".
All other places that are populating more info about a known test class or a test will use cached reflector helper. Or type cache, which uses cached reflector helper.
This will avoid lot of the time and cost of looking up attributes.

[ ] simplify ReflectHelper
Reflect helper is super convoluted and it is hard to see if we are doing things the best way and using the cache.

[ ] use cache everywhere in reflect helper

[ ] cache inherited and non-inherited attributes separately

[ ] use isAttributeDefined where appropriate.

is Attribute defined is allocation free and is cheap when used without inheritance. it is surprisingly more expensive then getCustomAttributes when used with inheritance

Split the usage of reflection into 2 categories, cached and non-cached. All the places that touch all types to see if the class or method is a test will use reflection "directly".
All other places that are populating more info about a known test class or a test will use cached reflector helper. Or type cache, which uses cached reflector helper.
This will avoid lot of the time and cost of looking up attributes.

Just to be sure I understand, the goal is to first to a "real" reflection call that will populate the cache and all subsequent calls would only read from the cache without really doing any call, right?

Yes. Right now ReflectorHelper is a mashup of direct reflection calls and cached reflection calls, and a jungle of calls in between the internal and public methods in that class, so I have no idea if the call I am making is cheap or expensive.
I want to untangle that to make the methods more independent, so we can know what they do exactly.
And split the api so it is easy to see where we are calling into data that are cached, and where we call reflection directly without cache.
Reflect helper will of course also internally call the reflection api to get the data, but then it will cache them.


fix(calendar-range): исправлено вычисление пропа minDate и maxDate

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 80.697%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
7314

Relevant Lines:
8264

💛  - Coveralls


Make the aspect chooser a dropdown

The aspect chooser takes up too much horizontal space and will make adding other
controls to the toolbar hard. We should make it a dropdown. Ideally I'd prefer it wasn't
a cheesy looking <select> control though.

I'm a bit sceptical about finding a good enough icon for each aspect, which would represent in an almost obvious way the aspect behind it. But I suppose after the initial UI discovery, the user would learn them easily enough. With maybe some help from tooltips?

I'm a bit sceptical about finding a good enough icon for each aspect, which would represent in an almost obvious way the aspect behind it. But I suppose after the initial UI discovery, the user would learn them easily enough. With maybe some help from tooltips?

What mpl said. The design consciously avoids icons to make it easy for non-designers to add features.


Bump CI runners to macOS-11

The issue was that 11 comes with Clang 13, for which there are no re-built packages on Conan. This adds automake tools so that Conan can build them locally. They should then be cached so hopefully this won't impact normal CI run times.

They should then be cached so hopefully this won't impact normal CI run times.

But first run of any PR, before the caching happens, will show

Tests / macos-11 (pull_request) Successful in **11m **

We already have #612 to look into better Github caching.

But first run of any PR, before the caching happens, will show

Ahh, I thought you had that clever cache fallback where it should re-use the cache from a previous PR?

But first run of any PR, before the caching happens, will show

Ahh, I thought you had that clever cache fallback where it should re-use the cache from a previous PR?

No don't think we added anything like that.  IIRC the cache will fall back to main's cache, but we don't do any building on main so there is no cache to fall back on.

Ahh, I thought you had that clever cache fallback where it should re-use the cache from a previous PR?

No don't think we added anything like that. IIRC the cache will fall back to main's cache, but we don't do any building on main so there is no cache to fall back on.

I thought that's what this was for - as it uses that mega unintuitive GitHub feature of sub-string matching.

Ahh, I thought you had that clever cache fallback where it should re-use the cache from a previous PR?

No don't think we added anything like that. IIRC the cache will fall back to main's cache, but we don't do any building on main so there is no cache to fall back on.

I thought that's what this was for - as it uses that mega unintuitive GitHub feature of sub-string matching.

That's a trick to simulate "overwriting" the cache within the same PR.  I think it's only really useful at the moment if you change Conan dependencies during a PR.  But will be useful if/when main has a cache that can be used as a fallback.


feat: add push notification builder

Closes: https://github.com/customerio/issues/issues/9591
Changes

Added CustomerIOPushMessaging  in react native to keep push messaging features in a single class
Registered RNCIOPushMessaging  as react native android module
Added support to generate notification locally using RemoteMessage for FCM

iOS currently doesn't implement CustomerioPushMessaging and resolves promise to true by default

For anyone receiving notifications outside Customer.io SDK, they can generate notifications locally using the following code snippet:
CustomerIO.pushMessaging().onMessageReceived(message).then(handled => {
  // handled is true if notification was handled by Customer.io SDK; false otherwise
});

where message contains payload received using FCM.
An example using React Native Firebase library would look like:
useEffect(() => {
  const unsubscribe = messaging().onMessage(async remoteMessage => {
    CustomerIO.pushMessaging().onMessageReceived(remoteMessage).then(handled => {
      // handled is true if notification was handled by Customer.io SDK; false otherwise
    });
  });

  return unsubscribe;
}, []);

Similarly, they can implement messaging().setBackgroundMessageHandler to handle notifications in the background

Thanks for pointing this out @levibostian. I have replied to your comments and added more details. I hope this gives clarity on the problem, if not, please feel free to ask more. We'll make sure not to move forward till we resolve our discussions.

I've added onBackgroundMessageReceived which is similar to how we handled both simple push and rich push in amiapp. This will not only make it more easier for customers, but will also help us explain this in our docs in slightly better way.


Add custom pages

Now supports 'pages' option, which can be any URL.
If specified, these replace the built in pages.
Example usage:
pages: {
  signin: 'https://example.com/signin',
  signout: 'https://example.com/signout',
  checkEmail: 'https://example.com/check-email',
  error: 'https://example.com/error'
}

Published as<EMAIL_ADDRESS>

This is awesome!

Hmm so I'm trying to set this up to get a feel for it, but I cant seem to get access to any of the provider variables like you do in your default signin page.
I have the pages object in the [...slug].js config pointing signin to a specific page. That seems to work. However, the signin page I land at then gets passed no props. Is that how its supposed to work?

Agree, we need to an example to document this and provide an example.
Created #165 to track documenting pages.
Basically if you had a rest API call to /api/auth/providers it will return all configured providers and you could loop over that to display a list of sign in providers and the URLs for sign in buttons to use for them.
v1 had a NextAuth.providers() function in the client to make this really easy, and we should probably add something like that (basically identical to the NextAuth.session() method, but calls /providers instead of /session).
PS: If you spot any bugs on this / if it doesn't work as expect would appreciate feedback!

Okay, thanks for the hint. Got it working ;)
I'll put up my example

BTW I think I've realised a possible future bug (ie not a bug now, but made me think about something that might be come an issue).
The sign up page should take a ?callbackURL=/page/user/was/on parameter if passed, so it can pass that same option on to the sign up buttons, so that the user is returned to the page they were on before they signed in.
This works right now but is a little messy, so might come back to it.
I am thinking of making a NextAuth.signin() and NextAuth.signout() functions to handle redirecting to whatever the sign in / sign out pages are, in the client, which could save the currently URL automatically before redirecting.
It could even take an argument, like NextAuth.signin('google') so it could be a simple onClick event for a sign in button to make them easy to create.
(This would be totally optional to use, but I assume people quite like an easy way to make pages that would ensure the current URL would be preserved after signing in.)

Ooo yeah I great idea. I actually had this issue in another project thats currently using nextauth v1 still. I ended up writing a cookie I think and checking that or local storage or something convoluted like that haha.

+1 for NextAuth.signin('provider') to redirect to the provider page directly.
Also I think it would be great if we could have a way of signing out without being redirected to the signout page. Now I understand it is currently required because we need a form with a CSRF token, but maybe we could retrieve csrfToken (perhaps with a hook like NextAuth.useSession()?) so we can build our own form and signout button anywhere (eg. in a navbar).
What do you think?

Absolutely! I was just thinking about getting round to this over lunch today actually.
While it needs to be a form submission - because to do it securely, it should have a CSRF token as you point out - this can absolutely be done by a NextAuth.signout() function!
I've been holding off on this until I had also created a NextAuth.csrfToken() method which it could use to fetch the token, though you are right we could also put it in the session object; but thought it might be useful to also expose - e.g. for people making their own email sign up forms.
I expect to add signin(), signout() and csrfToken() functions to the beta later this week. I don't think I'm tracking this is an issue, but I should be.

It's actually not very clear how to override the custom pages. I'm figuring out that I'm missing the CSRF and I guess it's in the cookies, however - am I expected to manually fetch it from cookies?

Made it work. Ended up having to request CSRF on the client:
  const [csrfToken, setCsrfToken] = useState();

  useEffect(() => {
    async function fetchToken() {
      if (typeof window !== "undefined") {
        const res = await fetch(`/api/auth/csrf`);
        const csrf = await res.json();
        setCsrfToken(csrf.csrfToken);
      }
    }
    fetchToken();
  }, []);

And then setting it inside the form:
<input type="hidden" value={csrfToken} name="csrfToken" />

Ah yes sorry that isn't documented yet (getting the CSRF Token to do a POST submission for email) but that is exactly right!
It's not intentionally obtuse, I'm just planning to add a NextAuth.csrfToken() and maybe actually just a signin(email) method similar to version 1, over the weekend and to document it then.
So this won't break but will get easier soon!


Touch area for the SwipeOpenView

Hello,
I'm having an scenario where I also have some other interactions on my ViewHolder which no longer work because the TouchListener of the SwipeOpenViewHolder intercepts all the touch events.
Is there an method with which I can reduce the area allowed for the swipe to open? I'm also thinking this area limitation could be taken into consideration only when the view is not open (this could also be another feature which can be combined with this flow).
Thank you.

What touch events are being intercepted? The listener used in the library should only start intercepting events once it's deemed a touch event as a swipe and has selected that view holder for swiping.
You can use the startSwipe(SwipeOpenViewholder) method to start a swipe on a view holder based off whatever you want (like a small handle view) -- this is carried over from Google's ItemTouchHelper.
I could possibly build in a way to disable the swipe-detection from the listeners, and only allow swipes to be started programmatically by using startSwipe() -- this would allow you to restrict the swipe area to whatever you define. I'm hesitant to alter the normal functionality further than that though.

Hello @alex-townsend,
I think giving the ability to override the default touch event interceptor should suffice for this as it will allow any developer to provide it's own flow for starting and ending an swipe.
Meanwhile I used AndroidSwipeLayout library as it provided an SwipeDenier listener. Maybe something like that could be combined also with this custom ItemTouchHelper (but I do not know if possible as I didn't had too much time to look at that implementation and it's dependencies).


Switch to libxslt for node v12

node v12 doesn not seems to like node_xslt.
So I am working to use another xslt tool.
Please tell me if you are interested?
And I will do deeper tests...

Yes, it looks like node_xslt has been abandoned, so this seems like a good idea. Let me know when it is ready to go.


VSCode

VSCode Version: Code - Insiders 1.11.0-insider (4db944bc08e34fb15c5805927d9cb67470776606, 2017-03-02T07:10:18.838Z)
OS Version: Windows_NT ia32 10.0.14393
CPUs: Intel(R) Core(TM) i5-3337U CPU @ 1.80GHz (4 x 1796)
Memory (System): 9.82GB (4.86GB free)
Memory (Process): 125.48MB working set (125.48MB peak, 94.95MB private, 34.12MB shared)
Load (avg): 0, 0, 0
VM: 0%
Initial Startup: yes
Screen Reader: no
Empty Workspace: no
Timings:

Component
Task
Time (ms)

main
start => app.isReady
47

main
app.isReady => window.loadUrl()
871

renderer
window.loadUrl() => begin to require(workbench.main.js)
693

renderer
require(workbench.main.js)
1406

renderer
create extension host => extensions onReady()
1836

renderer
restore viewlet
628

renderer
restore editor view state
1

renderer
overall workbench load
2510

main + renderer
start => extensions ready
5149

main + renderer
start => workbench ready
5555

:warning: Make sure to attach these files: :warning:
-C:\Users\Demo\6018_main.cpuprofile.txt
-C:\Users\Demo\6018_renderer.cpuprofile.txt

closing because files are missing


float:left issue with infinite scroll

Hi,
I am using this plugin with bootstrap. If i use

           ........

its loading all posts without scrolling. I have tested and issue is with float:left css property only otherwise its working fine.
Any idea?
Thanks

Just found solution in previous issue. overflow: auto; in container fixed it.
Thanks


The variable SELF is unbound.

Hi. I am trying to load that code into my repl:
(ql:quickload  :cl-actors)
(use-package :cl-actors)
                                        ;create the actor template
(defactor print-actor () (val) (print val) next)
                                        ; initialize a new instance
(setf printerr (print-actor))
                                        ;send values for printing
(send printerr "hello, world")
                                        ;create the template

                                        ;create the template
(defactor fact ((temp 1)) (n cust)
  (if (equal 1 n)
      (progn (send cust (* temp 1))
             (setf temp 1) next)
    (progn (setf temp (* n temp))
           (send self (- n 1) cust) next)))
                                        ;create a new instance
(setf f (fact))
                                        ; send a value
(send f 4 printerr)

I am using SBCL in version SBCL 1.5.7

I guess this repo is a toy library.
Your code, and other examples in README.md do not work because of https://github.com/naveensundarg/Common-Lisp-Actors/blob/master/actors.lisp#L91 .  defactor introduces symbol self in cl-actors package.  This is not good way in common lisp, I think.
Replacing (use-package :cl-actors) in your code with (in-package :cl-actors) makes it work in my environment. (SBCL 1.5.7)  But it is useless in practice.

@the-man-with-a-golden-mind there is a simple fix. Replace self with cl-actors::self.
I will fix the code and push a new version to QuickLisp that will make your original code with just self work. I just need to export self from the cl-actors package.
Please don't use @kenoss (in-package :cl-actors)


Set jenkins+build uri as the reason on build request

now that we can set a cause on a buildrequest, we should set jenkins as the cause with the job uri (same value we are annotating on the build object itself).
https://github.com/openshift/origin/blob/master/pkg/build/api/v1/types.go#L789
@spadgett
Message should be something like "Jenkins job URI https://blahblah/blah"
the ui will then be able to filter on this value.

This will necessitate a change to openshift-restclient-java (which I can do and then submit a PR for @jcantrill 's review) and invariable upgrade in that dependency.
@bparees @spadgett - I'm assuming we want this prior to 3.3 going out.  Correct?

@gabemontero ideally.  @spadgett says he can live w/o it.

@bparees @spadgett I have a prototype of this that is working.  Given the amount of additional changes needed to upgrade the openshift-restclient as well as make the modifications to the restclient to set the cause (where I still have to submit a pull for that), I'm not ready to produce a publicly consumable plugin to try, but I can provide a locally built version if you want to try sooner rather than later.
I hope to have the thing ready for public consumption by sometime tomorrow at the latest .... maybe EOB today, but I'm betting that is optimistic.

Quick update - still waiting for the openshift-restclient-java PR to merge.  Not much contention in the PR - just some lag time.

@gabemontero PR merged and 5.0.0-SNAPSHOT deployed

thanks @jcantrill !!

OK @spadgett here is a pre-release version of the plugin that registers a build cause for build triggered from the plugin.
When you get the chance please give it a try, and if we need to make tweaks, let's iteration over them.
I'll leave the issue open for bit in case you get a chance to try in the short term.  Otherwise I'm going to close this out as a result of https://github.com/openshift/jenkins-plugin/commit/070689c63b233529cfa52d60f145d7391e99e50b


allow BEN/CBEN to CC/CCC and update patch

Issue #: /bcgov/entity#24040
Description of changes:

allow BEN->CC and CBEN->CCC as per updated requirements (essentially reversing the original change)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

/gcbrun

Temporary Url for review: https://business-edit-dev--pr-595-f3rx2015.web.app


Shared disks for Azure VMs can't be used from containers in hyperv isolation

We are trying to use shared disks for Azure VMs and followed the instructions here https://techcommunity.microsoft.com/t5/failover-clustering/container-storage-support-with-cluster-shared-volumes-csv/ba-p/372140 to set them up. When we use them from process isolated containers, it works fine, so this comes up correctly:
docker service create --mount type=bind,src=C:\ClusterStorage\Volume1\249715c31f85\,dst=C:\data mcr.microsoft.com/windows/nanoserver:1809 ping -t <IP_ADDRESS>

If we try them same with hyperv isolation we get the following error:
docker service create --isolation=hyperv --mount type=bind,src=C:\ClusterStorage\Volume1\249715c31f85\,dst=C:\data mcr.microsoft.com/windows/nanoserver:1809 ping -t <IP_ADDRESS>
...
hcsshim::CreateComputeSystem 0ac1262a583e97022b0fb02ad2ae473b4f4e7a6e8df88264e002d2249a7c336e: More data is available. (extra info: {"SystemType":"Container","Name":"0ac1262a583e97022b0fb02ad2ae473b4f4e7a6e8df88264e002d2249a7c336e","Owner":"docker","IgnoreFlushesDuringBoot":true,"LayerFolderPath":"F:\\dockerdata\\windowsfilter\\0ac1262a583e97022b0fb02ad2ae473b4f4e7a6e8df88264e002d2249a7c336e","Layers":[{"ID":"fb75a699-7695-5c66-91e5-bdd716a033f3","Path":"F:\\dockerdata\\windowsfilter\\6a3862a401c067c8409c662acacedc1f4074691c7608bd0d112d39e9e17b38ab"}],"HostName":"0ac1262a583e","MappedDirectories":[{"HostPath":"C:\\ClusterStorage\\Volume1\\249715c31f85","ContainerPath":"C:\\data","ReadOnly":false,"BandwidthMaximum":0,"IOPSMaximum":0,"CreateInUtilityVM":false}],"HvPartition":true,"EndpointList":["FD122255-ED8D-4E46-A50D-2E29A094BF25"],"HvRuntime":{"ImagePath":"F:\\dockerdata\\windowsfilter\\6a3862a401c067c8409c662acacedc1f4074691c7608bd0d112d39e9e17b38ab\\UtilityVM"},"AllowUnqualifiedDNSQuery":true})

The result is the same on both Windows Server 2019 (1809) and Windows Server 2019 (2004). We also tried to set the permissions as open as possible for testing, but that didn't help
Invoke-Expression "icacls.exe $($driveLetter):\ /grant 'Everyone:(OI)(CI)(F)'"

@vrapolinario Does this mean that this is accepted as bug?

@vrapolinario Does this mean that this is accepted as bug?

Apologies for not replying earlier when I trigged this issue.
I'm contacting the appropriate teams internally and checking with them. I'm not sure at this point if this is a bug or if this is just not a supported scenario. We'll update soon.

Hi @tfenster, sorry for the delay on this. Can you please confirm this issue still repro with the latest update?
We had a similar bug fixed and wanted to ensure this is still happening before I go back to the devs on it.
Thanks!

@lippertmarkus do you still have a repo?

@vrapolinario @tfenster tried again but now I can't even create a default container with process isolation on the shared disk. Tried to set the permissions for the shared disk as open as possbile but that didn't help:
PS C:\> docker run -v C:\ClusterStorage\Volume1\test1:C:\data  --rm -it --user ContainerAdministrator mcr.microsoft.com/windows/nanoserver:2004 ping -t <IP_ADDRESS>
docker: Error response from daemon: hcsshim::CreateComputeSystem 81ca314552eebbc1f7b58137ffbe8af3eaa3f3f0c5f8678242046911b133da4b: The system cannot find the path specified.
(extra info: {"SystemType":"Container","Name":"81ca314552eebbc1f7b58137ffbe8af3eaa3f3f0c5f8678242046911b133da4b","Owner":"docker","VolumePath":"\\\\?\\Volume{f4e977ec-6ee4-4407-9da4-b5156b639f1f}","IgnoreFlushesDuringBoot":true,"LayerFolderPath":"C:\\ProgramData\\docker\\windowsfilter\\81ca314552eebbc1f7b58137ffbe8af3eaa3f3f0c5f8678242046911b133da4b","Layers":[{"ID":"0a8544ea-fbd1-5c13-9a8f-cbd88af3449f","Path":"C:\\ProgramData\\docker\\windowsfilter\\ed2dbb96ecf730bd2e9b4974c907e287b185e516ee901382897d75a25c8e075f"}],"HostName":"81ca314552ee","MappedDirectories":[{"HostPath":"c:\\clusterstorage\\volume1\\test1","ContainerPath":"c:\\data","ReadOnly":false,"BandwidthMaximum":0,"IOPSMaximum":0,"CreateInUtilityVM":false}],"HvPartition":false,"EndpointList":["30bc6084-c113-4f7b-84a0-bde12f961aee"],"AllowUnqualifiedDNSQuery":true}).

To confirm that this is indeed an issue with a drive letter, can you assign a drive letter to the CSV volume using mountvol and attempt to start container using that drive letter?

When assigning a drive letter to the CSV it works with process isolation but only party with hyperv isolation:
PS C:\> mountvol "Z:" "\\?\Volume{33b99261-3cff-4e42-af84-7722c711a562}\"

# process - root path - works
PS C:\> docker run -v Z:\:C:\data  --rm -it --isolation process mcr.microsoft.com/windows/nanoserver:2004 ping -t <IP_ADDRESS>

# process - subdir - works
PS C:\> docker run -v Z:\test1:C:\data  --rm -it --isolation process mcr.microsoft.com/windows/nanoserver:2004 ping -t <IP_ADDRESS>

# hyperv - root path - works
PS C:\> docker run -v Z:\:C:\data  --rm -it --isolation hyperv mcr.microsoft.com/windows/nanoserver:2004 ping -t <IP_ADDRESS>

# hyperv - subdir - doesn't work
PS C:\>  docker run -v Z:\test1:C:\data  --rm -it --isolation hyperv mcr.microsoft.com/windows/nanoserver:2004 ping -t <IP_ADDRESS>
docker: Error response from daemon: hcsshim::CreateComputeSystem 45aa6e2381ad6fec16b98631ec52a2168e0c76e4e579d7a2d259b5a04833318e: More data is available.
 (extra info: {"SystemType":"Container","Name":"45aa6e2381ad6fec16b98631ec52a2168e0c76e4e579d7a2d259b5a04833318e","Owner":"docker","IgnoreFlushesDuringBoot":true,"LayerFolderPath":"C:\\ProgramData\\docker\\windowsfilter\\45aa6e2381ad6fec16b98631ec52a2168e0c76e4e579d7a2d259b5a04833318e","Layers":[{"ID":"0a8544ea-fbd1-5c13-9a8f-cbd88af3449f","Path":"C:\\ProgramData\\docker\\windowsfilter\\ed2dbb96ecf730bd2e9b4974c907e287b185e516ee901382897d75a25c8e075f"}],"HostName":"45aa6e2381ad","MappedDirectories":[{"HostPath":"z:\\test1","ContainerPath":"c:\\data","ReadOnly":false,"BandwidthMaximum":0,"IOPSMaximum":0,"CreateInUtilityVM":false}],"HvPartition":true,"EndpointList":["f6d4cb3a-535e-4f63-aec9-d927611dce59"],"HvRuntime":{"ImagePath":"C:\\ProgramData\\docker\\windowsfilter\\ed2dbb96ecf730bd2e9b4974c907e287b185e516ee901382897d75a25c8e075f\\UtilityVM"},"AllowUnqualifiedDNSQuery":true}).

Cluster shared volumes are only supported for specific workload types, including Hyper-V virtual machines and Scale-Out File Servers (Use Cluster Shared Volumes in a failover cluster | Microsoft Docs). While CSV may function for other applications including process isolated containers it is not a scenario we have designed for, regularly validate, or have integrated with container orchestrators/clustering – as such it is not recommended/supported for production environments at this time. I did submit a change to our documentation (Clarifying support on cluster shared volumes (CSV)) to better clarify this support.
We recommend customers use persistent volumes in Kubernetes for an orchestrated and fully supported experience (https://docs.microsoft.com/en-us/azure-stack/aks-hci/persistent-volume).

@thecloudtaylor that means that there is no supported way to have shared storage across Windows hosts for process isolated workloads outside of AKS? Or am I missing an option?

@tfenster - SMB would be an out of the box option (that's likely what I would use). You could also imagine doing something like what K8 block PVs do in mounting the storage to the node running the container but that would require some doing. If I recall swarm does have hooks for such things but it's been a while since I looked at that code.

@thecloudtaylor thanks for the feedback. We indeed initially looked at SMB but as we want to run SQL databases on it, we had concerns about performance. Would you expect that to work?

@tfenster - I think it would depend on the configuration and of course the load but the same could be said about managed disks... You might benefit from adding an additional NIC to the hosts for the storage path, this might also be good from a network isolation perspective.

Interesting idea, will give that a try. Thanks!


[RFC] Remove csp_thread support

This is a RFC PR to show how we can gracefully remove csp_thread support from libcsp.  It's not complete yet, but hope this shows some idea.  After this PR, only user is the UDP interface driver.  I'd be nice if you can help me removing csp_thread from it.
After removing csp_thread, we can either remove csp__thread_create() or leave simplified version in-tree, especially for POSIX.  Because we need it anyway for Python bindings as well as arch dependent drivers.
WDYT?

BTW, this PR includes #283.

Added csp_if_udp refactoring. csp_thread_create() is not touched yet and csp_if_udp_rx_loop() and csp_if_udp_init() are still i the file.  But, it's much easier to see how it goes.  I wanted to show this in order to ask you for feedbacks.

I like what i see :)

The UDP interface is POSIX only for now. So we can do the same as with zmqhub.
You added a arch specific csp_bridge_start() into /arch. Should we do the same with csp_router_start() in order to be consistent? - Also perhaps i think these should be put into examples, and not be part of the API. To "force" users to copy them into their project, and actually use the real _work() API. What do you think? For example, with FreeRTOS the user has to decide on a stack size. But on Posix that's not necessary.
The timeout on work() functions i think we should keep, and then pass it along to the qfifo instead of the define. So it could be used in non-blocking mode.

That's good to hear :smile:. I'll keep working on it.

OK
We can certainly move _start() to examples, yes.  And I agree that for the real apps, we call _work() from platform specific way.
you want to modify csp_qfifo_read() by adding timeout as a new param, right?  If so, I'll do that for the last commit of this series, or after the merge (because that's nothing to do with csp_thread removal.  How does that sound?

Yes, exactly.

There is no user of csp_bridge_start() in examples.  Do you have any plan to implement a new sample using it?

Just did a checkout and build of our software, and it works for me :+1:


1.7.2 release missing /index.php

Hi,
Not sure whether it is intentional, but I just downloaded the 1.7.2 release files (checked in both tar.gz and zip) and they are missing the /index.php for yourls.  And no further information about installation to generate an index.php from template or alike.
I had a previous 1.7.0 version running, so I just copied the index.php from there.

http://yourls.org/#FAQ

I would be good to have further information on README.md or even an INSTALL mentioning it. index-template.php would be super.


using Kahip for graph-clustering

Having trouble using Kahip for clustering. Managed to do graph splitting. Any pointers/documentation?

Can you explain your use case? KaHIP is for balanced graph partitioning not clustering. If you want to cluster a graph to find communities please have a look at github.com/VieClus

please have a look at github.com/VieClus

The VieClus notes suggest using an older openmpi (or Intelmpi). For newer openmpi, I'd reasonably assume that you would want to avoid a multi-thread (with a dedicated progression thread). Is there anywhere in your algorithm that you could sprinkle in the occasional Testany call to progress things? Or does that not provide enough and/or have other negative consequences?

Thanks for answer. Works with dumping graph out and using label_propagation app. I've hacked bits of label_propagation app into my code but it always uses cluster size 1 (i.e. does not cluster). The only thing I'm missing is the parse_arguments call which seems to modify the config struct. Any pointers to which fields I need to set?

Got it working by setting the partition_config.cluster_upperbound to the wanted cluster size. Or do I have to set partition_config.k? Say if I want coarsening by a factor 8 on average but don't mind anywhere from 6 to 10. Any pointers as to what knobs to turn?

Is the problem solved or do you need more input?

Not yet solved. I've set partition_config.cluster_upperbound to e.g. 5 but it does seem to obey this (I assume this is the max size of the resulting cluster). Where does the cluster_coarsening_factor come into it? Or 'k'?

can you post the current version of your code?

It didn't allow me to attach file ("We don't support that file type") so I'll just paste the relevant source file. It is a bit of OpenFOAM source code so will not compile on its own. I've taken relevant bits out of your argument parsing routine and spliced them in.
/*---------------------------------------------------------------------------*\
  =========                 |
  \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
   \\    /   O peration     |
    \\  /    A nd           | www.openfoam.com
     \\/     M anipulation  |
-------------------------------------------------------------------------------
    Copyright (C) 2023 OpenCFD Ltd.
-------------------------------------------------------------------------------
License
    This file is part of OpenFOAM.

    OpenFOAM is free software: you can redistribute it and/or modify it
    under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    OpenFOAM is distributed in the hope that it will be useful, but WITHOUT
    ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    for more details.

    You should have received a copy of the GNU General Public License
    along with OpenFOAM.  If not, see <http://www.gnu.org/licenses/>.

Description
    Agglomerate one level using the kahip algorithm.

\*---------------------------------------------------------------------------*/

#include "kahipGAMGAgglomeration.H"
//#include "fvMesh.H"
#include "OFstream.H"

#include "random_functions.h"
#include "graph_io.h"
#include "configuration.h"
//#include "parse_parameters.h"

// * * * * * * * * * * * * * Private Member Functions  * * * * * * * * * * * //

void Foam::kahipGAMGAgglomeration::
makeCompactCellFaceAddressingAndFaceWeights
(
    const lduAddressing& fineAddressing,
    List<int>& cellCells,
    List<int>& cellCellOffsets,
    const scalarField& magSi,
    List<scalar>& faceWeights
)
{
    const label nFineCells = fineAddressing.size();
    const label nFineFaces = fineAddressing.upperAddr().size();

    const labelUList& upperAddr = fineAddressing.upperAddr();
    const labelUList& lowerAddr = fineAddressing.lowerAddr();

    // Number of neighbours for each cell
    labelList nNbrs(nFineCells, Zero);

    forAll(upperAddr, facei)
    {
        nNbrs[upperAddr[facei]]++;
    }

    forAll(lowerAddr, facei)
    {
        nNbrs[lowerAddr[facei]]++;
    }

    // Set the sizes of the addressing and faceWeights arrays
    cellCellOffsets.setSize(nFineCells + 1);
    cellCells.setSize(2*nFineFaces);
    faceWeights.setSize(2*nFineFaces);

    cellCellOffsets[0] = 0;
    forAll(nNbrs, celli)
    {
        cellCellOffsets[celli+1] = cellCellOffsets[celli] + nNbrs[celli];
    }

    // reset the whole list to use as counter
    nNbrs = 0;

    forAll(upperAddr, facei)
    {
        label own = upperAddr[facei];
        label nei = lowerAddr[facei];

        label l1 = cellCellOffsets[own] + nNbrs[own]++;
        label l2 = cellCellOffsets[nei] + nNbrs[nei]++;

        cellCells[l1] = nei;
        cellCells[l2] = own;

        faceWeights[l1] = magSi[facei];
        faceWeights[l2] = magSi[facei];
    }
}

Foam::tmp<Foam::labelField> Foam::kahipGAMGAgglomeration::agglomerate
(
    label& nCoarseCells,
    const label minSize,
    const label maxSize,
    const lduAddressing& fineAddressing,
    const scalarField& V,
    const scalarField& magSf,
    const scalarField& magSb
)
{
    const label nFineCells = fineAddressing.size();

    // Compact addressing for cellCells
    List<int> cellCells;
    List<int> cellCellOffsets;

    // Face weights = face areas of the internal faces
    List<scalar> faceWeights;

    // Create the compact addressing for cellCells and faceWeights
    makeCompactCellFaceAddressingAndFaceWeights
    (
        fineAddressing,
        cellCells,
        cellCellOffsets,
        magSf,
        faceWeights
    );

    if (debug)
    {
        const label nFineFaces = fineAddressing.upperAddr().size();
        const fileName graph_filename("graph_"+Foam::name(nFineCells)+".grf");

        OFstream os(graph_filename);
        Info<< "Dumping Metis graph file for nCells "
            << nFineCells << " to " << os.name() << endl;

        os << "% Metis graph format" << nl
            << nFineCells << ' ' << nFineFaces << nl;

        for (label celli = 0; celli < nFineCells; celli++)
        {
            const label start = cellCellOffsets[celli];
            const label end = cellCellOffsets[celli+1];

            // First nbr
            os << cellCells[start]+1;

            // Rest of nbrs
            const SubList<label> nbrs(cellCells, end-start-1, start+1);

            for (const label nbr : nbrs)
            {
                os  << ' ' << nbr+1;
            }
            os << nl;
        }
    }

    PartitionConfig partition_config;
    //partition_config.k = 1;        // wanted cluster size
    configuration cfg;
    cfg.standard(partition_config);
    //cfg.fast(partition_config);

    partition_config.cluster_upperbound =
        std::numeric_limits< NodeWeight >::max()/2;

    graph_access G;
    //internal_build_graph
    //(
    //    partition_config,
    //    nFineCells,
    //    nullptr,    // vertex weights
    //    cellCellOffsets.begin(),    // offsets
    //    nullptr,    // adjcwgt,
    //    cellCells.begin(),  //adjncy,
    //    G
    //);
    G.build_from_metis(nFineCells, cellCellOffsets.begin(), cellCells.begin());
    //G.set_partition_count(partition_config.k);
    //if(vwgt != NULL) {
    //        forall_nodes(G, node) {
    //                G.setNodeWeight(node, vwgt[node]);
    //        } endfor
    //}
    //
    //if(adjcwgt != NULL) {
    //        forall_edges(G, e) {
    //                G.setEdgeWeight(e, adjcwgt[e]);
    //        } endfor
    //}

    std::cout <<  "graph has " <<  G.number_of_nodes() <<  " nodes and "
        <<  G.number_of_edges() <<  " edges"  << std::endl;

    partition_config.cluster_upperbound = 5;    // wanted cluster size
        //std::numeric_limits< NodeWeight >::max()/2;

    if( partition_config.cluster_upperbound == std::numeric_limits< NodeWeight >::max()/2 ) {
            std::cout <<  "no size-constrained specified" << std::endl;
    } else {
            std::cout <<  "size-constrained set to " <<  partition_config.cluster_upperbound << std::endl;
    }

    partition_config.upper_bound_partition =
        partition_config.cluster_upperbound+1;
    partition_config.cluster_coarsening_factor = 1;
    partition_config.k = 1;
    srand(partition_config.seed);
    random_functions::setSeed(partition_config.seed);

    //configuration cfg;
    //cfg.fast(partition_config);     // use 'fast' algo

    NodeID no_blocks = 0;
    std::vector< NodeID > cluster_id(G.number_of_nodes());
    size_constraint_label_propagation sclp;
    sclp.label_propagation( partition_config, G, cluster_id, no_blocks);

    DebugVar(no_blocks);

    forall_nodes(G, node)
    {
        Pout<< "    node:" << node << " cluster:" << cluster_id[node] << endl;
        G.setPartitionIndex(node, cluster_id[node]);
    }
    endfor
    G.set_partition_count(no_blocks);

    nCoarseCells = no_blocks;
    List<int> finalAgglom(nFineCells);
    forall_nodes(G, node)
    {
        finalAgglom[node] = cluster_id[node];
    }
    endfor

//    {
//        label nNewCoarseCells = 0;
//        labelList newRestrictAddr;
//        bool ok = checkRestriction
//        (
//            newRestrictAddr,
//            nNewCoarseCells,
//            fineAddressing,
//            finalAgglom,
//            nCoarseCells
//        );
//
//        if (!ok)
//        {
//            nCoarseCells = nNewCoarseCells;
//            finalAgglom.transfer(newRestrictAddr);
//        }
//    }

    return tmp<labelField>::New(finalAgglom);
}

// ************************************************************************* //

When you say "it does seem to obey this" (cluster upperbound), can you explain what you mean by this? The way the code is shown in your code the clusters should be bounded by 5, but not higher. It can however be that there are many clusters with less than 5 nodes.

Just re-compiled & re-ran and it keeps to the cluster_upperbound! Sorry for the false alarm. Q: do I set the coarsening_factor or the upper_bound or the k?

For the clustering you can not set k explicitly (it is clustering, not
partitioning) ;) you can only somewhat implicitly control it via the
cluster bound that you have set, ie the smaller the bound the larger the k.
On Wed, 24 May 2023, 21:47 mattijsjanssens, @.***>
wrote:

Just re-compiled & re-ran and it keeps to the cluster_upperbound! Sorry
for the false alarm. Q: do I set the coarsening_factor or the upper_bound
or the k?
—
Reply to this email directly, view it on GitHub
https://github.com/KaHIP/KaHIP/issues/128#issuecomment-1561837009, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLP7SSYNSHBURJGMVHS5NTXHZQT3ANCNFSM6AAAAAAWVNNMPY
.
You are receiving this because you commented.Message ID:
@.***>


Date ranges for meals report

Promised to Yi-Miau by May 8

Originally created by Tom Smyth at 2018-04-18 09:31, migrated from redmine-#8318

Status changed from New to Closed

By Tom Smyth at 2018-04-21 18:20

Version set to 6.0

By Tom Smyth at 2018-04-28 18:41