ES6 - Use getters and setters to Control Access to an Object: Confusing?

Describe your problem and - if possible - how to reproduce it
The exercise can pass with just one line of code.
  /* Alter code below this line */
  class Thermostat {}
  /* Alter code above this line */

It doesn't test what it should be testing.
I think the instructions can be made clearer. This is what I have in mind:

Use the class keyword to create a Thermostat class. It should have a constructor that accepts a temperature in degrees Fahrenheit.
Now create a getter and a setter called temperature [or celsius, or tempCelsius, or temperatureC; they're clearer, but changing to any of these needs changes in the last few lines of the code as well] in the class. The getter should return the temperature in degrees Celsius. The setter should accept a temperature in degrees Celsius.
Remember that °C = 5/9 * (°F - 32) and °F = °C * 9/5 + 32.
Note that while the constructor requires a temperature in Fahrenheit, you can store the temperature internally in either Fahrenheit or Celsius. What's important is that the getter returns the temperature in Celsius and the setter accepts a temperature in Celsius.
This is the power of getters and setters - you are creating an API for another user, who would get the correct result, no matter how you implement them.
In other words, you are abstracting implementation details from the consumer.

Add a Link to the page with the problem
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/es6/use-getters-and-setters-to-control-access-to-an-object/

I encountered the same problem. The test passes even without having to create the getter or setter, even the constructor.  The only code that is needed for the test to pass appears to be the class declaration.

Same here.

I think is not very clear what the expectations are either.  I have been trying to actually do it with declaring getters and setters, but I'm not really sure if I am not able to pass the test because my declarations are wrong, or this bug that's discussed.
I believe the description could be modified as in reading it, the understanding is to make an object that takes the temp in F and then you are able to access the temp in C by using the getter function.  That being said, other parts of the instruction make it seem like you should be able to assign the temperature in either F or C and then the setting function would turn that into the opposite.  At this point I'll just do what everyone else did to get it clear and assume I know what I'm doing...

I found this one really easy.
function makeClass() {
"use strict";
/* Alter code below this line */
class Thermostat {
constructor(Fahrenheit) {
this.Fahrenheit = Fahrenheit;
}
get temperature (){
return this.temp;
}
set temperature (thermos) {
this.temp = 5/9 * (thermos - 32);
}
}
/* Alter code above this line */
return Thermostat;
}
const Thermostat = makeClass();
const thermos = new Thermostat(76); // setting in Fahrenheit scale
let temp = thermos.temperature; // 24.44 in C
thermos.temperature = 26;
temp = thermos.temperature; // 26 in C
Just have to read the bottom variables and walk through the flow

The same here, I have passed the challenge only writing:
  class Thermostat{
    constructor (temperature){
      this.temperature = temperature;
    }
  }

I think you should repair it, because the challenge is about Getters and Setters.
Thanks!

This is still an issue, I just 'passed' with this:
function makeClass() {
"use strict";
/* Alter code below this line /
class Thermostat {
constructor(fahrenheit){
this._fahrenheit = fahrenheit;
}
get b(){
return this._fahrenheit;
}
set b(a){
this._fahrenheit = a;
}
}
/ Alter code above this line */
return Thermostat;
}
const Thermostat = makeClass();
const thermos = new Thermostat(76); // setting in Fahrenheit scale
let temp = thermos.temperature; // 24.44 in C
thermos.temperature = 26;
temp = thermos.temperature; // 26 in C

It is still happening. This code passed the test (it's wrong because the setter doesn't set anything):
/* Alter code below this line */
class Thermostat{
   constructor(fahrenheit){
    this._fahrenheit = fahrenheit;
  }

  get temperature(){
    return (5/9 * (this._fahrenheit - 32));
  }

// This doesn't set the temperature:
  set temperature(celsius){
    return celsius * 9.0 / 5 + 32;;
  }
}
  /* Alter code above this line */

The issue still persists.

I have no clue what this challenge description is even trying to have the user complete.
Why is there even code being used to set the temperature property when getter and setter are supposed to be used to avoid doing such things?
let temp = thermos.temperature; // 24.44 in C
thermos.temperature = 26;
temp = thermos.temperature; // 26 in C

The description seems to want the user to convert between C and F, but fails to provide any implementation details about method names

Hello)
function makeClass() {
  "use strict";
  /* Alter code below this line */
class Thermostat {
    constructor (F) {
      this.celsius = 5/9 * (F - 32);
    }

    get temperature() {
      console.log(`${this.celsius} in C`);
      return this.celsius;
    }

    set temperature(newTemp) {
      this.celsius = newTemp;
    }
  }
  /* Alter code above this line */
  return Thermostat;
}
const Thermostat = makeClass();
const thermos = new Thermostat(76); // setting in Fahrenheit scale
let temp = thermos.temperature; // 24.44 in C
thermos.temperature = 26;
temp = thermos.temperature; // 26 in C

Describe your problem and - if possible - how to reproduce it
The exercise can pass with just one line of code.
  /* Alter code below this line */
  class Thermostat {}
  /* Alter code above this line */

The issue still exists.

@pantteri The issue is still open, so yes the issue still exists.

After a year, this issue still exists?  I was able to pass this test with the following code, knowing it was not following the instructions:
function makeClass() {
  "use strict";
  /* Alter code below this line */
class Thermostat{
  constructor(temp) {
    this._temp = temp;
  }
  get thermos(){
    return this._temp;
  }
  set thermos(updateTemp){
    this._temp = updateTemp;
  }
}
  /* Alter code above this line */
  return Thermostat;
}
const Thermostat = makeClass();
const thermos = new Thermostat(76); // setting in Fahrenheit scale
let temp = thermos.temperature; // 24.44 in C
thermos.temperature = 26;
temp = thermos.temperature; // 26 in C

Hello all. How could one test the output for various temperature values using console.log? Thank you!

After a year, this issue still exists? I was able to pass this test with the following code, knowing it was not following the instructions:
function makeClass() {
  "use strict";
  /* Alter code below this line */
class Thermostat{
  constructor(temp) {
    this._temp = temp;
  }
  get thermos(){
    return this._temp;
  }
  set thermos(updateTemp){
    this._temp = updateTemp;
  }
}
  /* Alter code above this line */
  return Thermostat;
}
const Thermostat = makeClass();
const thermos = new Thermostat(76); // setting in Fahrenheit scale
let temp = thermos.temperature; // 24.44 in C
thermos.temperature = 26;
temp = thermos.temperature; // 26 in C

How would you test this using console.log? Thanks

same here i passed the test only by when i thought i'm just starting . it got me so confused, so i'm not the only one . it's 2019 and they still didn't fix that problem ...
class Thermostat {
    constructor(Fahrenheit_temperature){
      return this.Fahrenheit_temperature = Fahrenheit_temperature;
    }
  }

@IssamAth it should have been fixed by https://github.com/freeCodeCamp/freeCodeCamp/pull/36620.  That's live on https://www.freecodecamp.dev/learn/javascript-algorithms-and-data-structures/es6/use-getters-and-setters-to-control-access-to-an-object if you want to try it out.

@ojeytonwilliams thanks i'll give it a try !

The old issue is gone but there'are some new.
Here is my code :
class Thermostat {
    constructor(temperature){
      this._temperature = temperature
    }

    get writer() {
        return this._temperature;
      }

    set writer(f) {
        this._temperature = (5/9 * (f - 32));
      }

  }

  const thermos = new Thermostat(76);
  let temp = thermos.temperature;
  thermos.temperature = 26;
  temp = thermos.temperature;

got my test fails because of these errors.

[ ] Thermostat should be able to be instantiated.
[ ] A getter should be defined.
[ ] A setter should be defined.

But my code works on vs code.

@certilremy Please use our forum for debugging the code of your projects.  If the forum members determine there is nothing wrong with your code, you can request this issue to be reopened.  GitHub issues are meant for reporting bugs and not troubleshooting the code in your projects.
Thank you for understanding.


ending an email secure caused a crash

[11/17/2020, 1:36:45 PM] [Messenger] Washing Machine has finished : Message sent to<EMAIL_ADDRESS>[11/17/2020, 1:36:46 PM] Error: Error:<PHONE_NUMBER>:error:1408F10B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:332:
at /usr/local/lib/node_modules/homebridge-messenger/lib/email.js:66:17
at /usr/local/lib/node_modules/homebridge-messenger/node_modules/nodemailer/lib/mailer/index.js:226:21
at SMTPConnection.<anonymous> (/usr/local/lib/node_modules/homebridge-messenger/node_modules/nodemailer/lib/smtp-transport/index.js:175:24)
at Object.onceWrapper (events.js:422:26)
at SMTPConnection.emit (events.js:315:20)
at SMTPConnection._onError (/usr/local/lib/node_modules/homebridge-messenger/node_modules/nodemailer/lib/smtp-connection/index.js:764:14)
at TLSSocket.SMTPConnection._onSocketError (/usr/local/lib/node_modules/homebridge-messenger/node_modules/nodemailer/lib/smtp-connection/index.js:190:45)
at TLSSocket.emit (events.js:315:20)
at emitErrorNT (internal/streams/destroy.js:100:8)
at emitErrorCloseNT (internal/streams/destroy.js:68:3)
at processTicksAndRejections (internal/process/task_queues.js:84:21)

{             "name": "Messenger",             "services": {                 "email": {                     "recipient"<EMAIL_ADDRESS>                    "smtpServer": "smtp.office365.com",                     "smtpPort": 587,                     "smtpSecure": false,                     "smtpUsername"<EMAIL_ADDRESS>                    "smtpPassword": "my correct password"                 }             },             "messages": [                 {                     "name": "Dryer Has finished",                     "type": "email",                     "text": "The Dryer seems to have Finished",                     "priority": 0,                     "sound": "pushover"                 },                 {                     "name": "Washing Machine has finished",                     "type": "email",                     "text": "The Washing Machine seems to have Finished",                     "priority": 0,                     "sound": "pushover"                 }             ],             "accessory": "HomebridgeMessenger"         }
When I turned secure off, everything is OK.

I get this exact same error. Mine did not help just by turning off the secure. Is yours still working?

This is bug. I will look into this.

This is bug. I will look into this.

@Ghitafjorback : Were you able to make it work with secure=false ? It appears to be a problem with your server. I also have the same problem on my setups.

@Ghitafjorback : Were you able to make it work with secure=false ? It appears to be a problem with your server. I also have the same problem on my setups.

No, I did not get it to work. Unfortunately.

No, I did not get it to work. Unfortunately.

@Ghitafjorback and @siobhanellis  : Solved in new version 0.0.7. It's published and available now.

@Ghitafjorback and @siobhanellis  : Solved in new version 0.0.7. It's published and available now.


No Server Component Support in React / Next 13?

Is your feature request related to a problem? Please describe.
I can not seem to use react server components with next 13 when using the flowbite react library. When using a simple button component I get this error.
"You're importing a component that needs flushSync. It only works in a Client Component but none of its parents are marked with "use client", so they're Server Components by default."
Describe the solution you'd like
Support for server components, theres no need to not be able to use server components when using something as simple as a button.

Hey @rluders @tulup-conner,
Can you please check this out? Recently I've made an update to the main library to support SSR rendering by adding a check flag for the window object.
Cheers,
Zoltan

I'm closing this on 'cause, this is duplicated with #448


Modify ImportMetadataViewConstraint to accept a Resolver

This gives added flexibility to the implementation to work with TypeRef more natively instead of Type. I'm preparing some subsequent changes that will leverage this to avoid loading assemblies/types when evaluating metadata constraints.

Codecov Report

Merging #86 into master will decrease coverage by <.01%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   85.86%   85.85%   -0.01%
==========================================
  Files          67       67
  Lines        5582     5586       +4
  Branches      865      866       +1
==========================================
+ Hits         4793     4796       +3
- Misses        552      553       +1
  Partials      237      237

Impacted Files
Coverage Δ

...lStudio.Composition/Configuration/CachedCatalog.cs
97.52% <100%> (ø)
:arrow_up:

...Studio.Composition/ImportMetadataViewConstraint.cs
83.07% <85.71%> (-0.53%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d13f14f...2002b02. Read the comment docs.


full-text snippets: better phrase search snippet selection

Originally on 2010-10-17
When users search for a phrase in the full-text index, a Boolean word query combination is currently performed.  Example: higgs mechanism in the demo site.  When showing fulltext snippets for the query, it will be useful to first grep for the phrase and offer those snippets, if available, and only fall back to grepping individual words when there is no phrase.
BTW, beware of stemming when grepping for a phrase, e.g. one can stem individual words and look for those with a wildcard and a space between, kind of like higgs mechanism -> higg\w*\smechan\w*. Note also that some sites may not have enabled stemming in full-text, so this wildcard game should not be performed then.

Closed via 51f54e7 and #836.


[composer] Undefined index: extra

Image service-cli 2.11 is build with global composer package zaporylie/composer-drupal-optimizations using this line in Dockerfile for example:
composer global require zaporylie/composer-drupal-optimizations:^1.1 >/dev/null; \
The version of this package shipped in those images are the 1.1.1 which is broken (Issue)
Images impacted (as far as i know) :

2.11-*
2.10-*

Workaround : fin composer global require zaporylie/composer-drupal-optimizations:1.1.2
Proposition : Rebuild new version of image (2.12) to shipped the fixed version of this package (1.1.2)

2.9-* seems to be impacted too...

@Klee-scoisne @vaza18 the images have been rebuilt, this should be all set. Run fin update to get the latest images, or fin update --project-images to pull images based on project usage.

And then run fin reset cli for each project.

Update done flawlessly on my side. (fin update + fin reset cli)
Thank for the bump

To be clear, we rolled out a 2.11.1 hotfix release.
Anyone using the default Docksal stack with Docksal v1.14.0+ (fin v1.97.0+) can get it by running fin update (one time, global) and fin reset cli (in each project) as was mentioned above.
For projects using customized stacks with older docksal/cli versions the solution is to bump the image version to 2.11.
If this becomes a problem for anyone, ping me. cc @vaza18


SPOTAUT-16188-Gpu types

This is the default pull request template. You can customize it by adding a pull_request_template.md at the root of your repo or inside the .github folder.
Jira Ticket
https://spotinst.atlassian.net/browse/SPOTAUT-16188
Include a link to your Jira Ticket
Example: JIRAISS-1234
Demo
Please add a recording of the feature/bug fix in work. if you added new routes, the recording should show the request and response for each new/changed route
Checklist:

[ ] I have filled relevant self assessment (NodeJS, Frontend, Backend)
[ ] I have run ESlint on my changes and fixed all warnings and errors (NodeJS & Frontend Services)
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have validated all the requirements in the Jira task were answered
[ ] I have all neccessary approvals for the design/mini design of this task
[ ] I have approved the API changes and granular permission patterns (documentation subtask) (For public services only)

Please fix review comments.


Marathon failed to deploy in loop with docker image pull, no errors

Docker version 1.8.2, build 0a8c2e3
DOCKER_APP_VERSION            1.8.2-0~trusty
MESOS_APP_VERSION             0.23.0-1.0.ubuntu1404
MARATHON_APP_VERSION          0.11.0-1.0.425.ubuntu1404

I cannot deploy a simple image.
The image I want to install was tested in local and in server
docker pull secretrepo/registry
docker run -p 5000:5000 -v srv/docker/registry:/var/lib/registry secretrepo/registry
"listening on [::]:5000"

Marathon return no logs about the error
Mesos UI display a lots of application started and finished
Mesos task stderr
I1023 18:10:21.162006  8509 exec.cpp:134] Version: 0.25.0
I1023 18:10:21.164427  8512 exec.cpp:208] Executor registered on slave 7c948886-744c-4a21-a2f5-27ba3ded7fd4-S0
WARNING: Your kernel does not support memory limit capabilities. Limitation discarded.
WARNING: Your kernel does not support memory swappiness capabilities, memory swappiness discarded.

Mesos task stdout
--container="mesos-7c948886-744c-4a21-a2f5-27ba3ded7fd4-S0.054cdabd-3419-4ed3-8e58-aa432873ac38" --docker="/usr/local/sbin/docker" --docker_socket="/var/run/docker.sock" --help="false" --initialize_driver_logging="true" --logbufsecs="0" --logging_level="INFO" --mapped_directory="/mnt/mesos/sandbox" --quiet="false" --sandbox_directory="/tmp/mesos/slaves/7c948886-744c-4a21-a2f5-27ba3ded7fd4-S0/frameworks/f1d1c38f-b267-4a59-bb97-688b1f15f8c3-0000/executors/registry.52d85650-79b1-11e5-a5a5-eebffa311d4a/runs/054cdabd-3419-4ed3-8e58-aa432873ac38" --stop_timeout="5secs"
--container="mesos-7c948886-744c-4a21-a2f5-27ba3ded7fd4-S0.054cdabd-3419-4ed3-8e58-aa432873ac38" --docker="/usr/local/sbin/docker" --docker_socket="/var/run/docker.sock" --help="false" --initialize_driver_logging="true" --logbufsecs="0" --logging_level="INFO" --mapped_directory="/mnt/mesos/sandbox" --quiet="false" --sandbox_directory="/tmp/mesos/slaves/7c948886-744c-4a21-a2f5-27ba3ded7fd4-S0/frameworks/f1d1c38f-b267-4a59-bb97-688b1f15f8c3-0000/executors/registry.52d85650-79b1-11e5-a5a5-eebffa311d4a/runs/054cdabd-3419-4ed3-8e58-aa432873ac38" --stop_timeout="5secs"
Registered docker executor on prod-02
Starting task registry.52d85650-79b1-11e5-a5a5-eebffa311d4a

Marathon image configuration
{
  "type": "DOCKER",
  "volumes": [
    {
      "containerPath": "/var/lib/registry",
      "hostPath": "/srv/docker/registry",
      "mode": "RW"
    }
  ],
  "docker": {
    "image": "secretrepo/registry",
    "network": "BRIDGE",
    "portMappings": [
      {
        "containerPort": 5000,
        "hostPort": 0,
        "servicePort": 5000,
        "protocol": "tcp"
      }
    ],
    "privileged": false,
    "parameters": [],
    "forcePullImage": false
  }
}

Not a single logs in marathon, don't know if this is a marathon issue.

Do you have port 5000 opened in mesos slave configuration ?
eg.
cat /etc/mesos-slave/resources
ports(*):[4000-4500, 7000-7001, 7199-7199, 8000-9500, 31000-32000]
on Marathon 11.0/1 if docker info entered from the UI has to have cmd stated otherwise it starts the docker with /bin/sh -c " " - (I think there's a issue reported on that already) so try adding actual cmd to it.
I would first try those two.

This was solved by upgrading my config to latest version of marathon


Using scrollRef.current with promises throwsTypeError: null is not an object (evaluating 'scrollRef.current.scrollToBottom')

related issues #196 #185
Both of these issues have resolution should be fixed in 4.2.1
from package.json: "react-custom-scrollbars": "^4.2.1",
how to reproduce
working version
const aFunctionName = async (data: any) => {
  anotherFunction();
  scrollRef.current.scrollToBottom();
}

buggy version
const aFunctionName = async (data: any) => {
  await aPromiseFunction();
  scrollRef.current.scrollToBottom(); // throws error now
}

@malte-wessel tagging you since you responded on the related threads

I'm having issues with this as well


Please always provide a Diagram for better understanding

[Enter feedback here]
It will be super useful for readers if you could provide a full visual diagram of each security component , how and where it fits into the overall architecture. All AWS documents are pretty clear on this area, and easy to understand. While, Azure has been pretty good documentation, there is lack of visualization elements for better understanding for readers who are new or may not be aware of all components.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ce94e95d-f2df-72de-66d0-56930547ee98
Version Independent ID: 8d258a24-3bd7-dd4e-db41-9cfea8d077ee
Content: Introduction to Azure security
Content Source: articles/security/fundamentals/overview.md
Service: security
Sub-service: security-fundamentals
GitHub Login: @TerryLanfear
Microsoft Alias: TomSh

@knssub - Thank you for your feedback! We will soon publish a diagram that meets your request. The diagram differentiates the Azure security services and features.
#please-close

@knssub - please see diagram in here: https://docs.microsoft.com/en-us/azure/security/fundamentals/end-to-end.

Thanks a ton for considering this feedback and really love the diagrams. Fantastic work :-).It definitely makes it easier for one to understand the exact mapping across security domains.
If not asking for more, if possible, could you please provide the visio there, so that partners like us could edit to build our own mapping of Microsoft solutions as well.


centos7.9 执行《pip install aiohttp aiofiles miservice》命令，安装miservice 2.1.2版本报错呢？

Getting requirements to build wheel ... error
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [19 lines of output]
Traceback (most recent call last):
File "/usr/local/python3/lib/python3.7/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in
main()
File "/usr/local/python3/lib/python3.7/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
File "/usr/local/python3/lib/python3.7/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
return hook(config_settings)
File "/tmp/pip-build-env-ozpd4sii/overlay/lib/python3.7/site-packages/setuptools/build_meta.py", line 341, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=['wheel'])
File "/tmp/pip-build-env-ozpd4sii/overlay/lib/python3.7/site-packages/setuptools/build_meta.py", line 323, in _get_build_requires
self.run_setup()
File "/tmp/pip-build-env-ozpd4sii/overlay/lib/python3.7/site-packages/setuptools/build_meta.py", line 488, in run_setup
self).run_setup(setup_script=setup_script)
File "/tmp/pip-build-env-ozpd4sii/overlay/lib/python3.7/site-packages/setuptools/build_meta.py", line 338, in run_setup
exec(code, locals())
File "", line 17, in
File "/tmp/pip-install-fpnkp8z8/miservice_ab36a529de144f429e8703e5104b8a60/micli.py", line 2, in
from aiohttp import ClientSession
ModuleNotFoundError: No module named 'aiohttp'
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.

如图是python版本号，aiohttp都已经安装了的！

同

# requirements
COPY ./requirements.txt /code/requirements.txt
RUN pip install --no-cache-dir --upgrade -r /code/requirements.txt -i https://pypi.tuna.tsinghua.edu.cn/simple
RUN pip install miservice -i https://pypi.tuna.tsinghua.edu.cn/simple

分开安装可以

先把项目git clone到本地 /tmp/MiService：
git clone git clone https://github.com/Yonsm/MiService.git /tmp/MiService

如图，编辑里面的/tmp/MiService/setup.py文件第 17 和 22 行：
17行 前面加#注释掉
22行 =后改成'2.1.2'

保存后安装：
pip3 install /tmp/MiService


Header and Fields in codeunit 5054 out of sync [AL #1620]

Issue moved from AL repo, where the full thread can be found.
https://github.com/Microsoft/AL/issues/1620
As mentioned in the code example in Microsoft/AL#1057, the header and fields in codeunit 5054 are out of sync now.
in function
[External] CreateHeader(VAR WordMergefile : DotNet "Micr....... AddNewEntry(Text015,''); <------ this is the FaxEmailValue and is the last header field.

but in function
[External] AddFieldsToMergeSource(VAR WordMergefile AddField(FaxMailToValue); <------ this value must come last and isn't now!

Thank you for your request. We are currently setting up the process around handling of issues in this new GitHub repository and you should hence expect a short delay in the processing of this request. But we will be on your case shortly!

We are having problems understanding the issue. We can't seem to find any issue. Could you elaborate?
If you believe you've found a product bug, please follow the below instructions:
This GitHub repository is dedicated to handling issues with published apps and extensibility requests for the latest release of Business Central. If you run into an issue, open a support case. You can open a Support Request to CSS through PartnerSource portal or by contacting your Service Account Manager (SAM) in the local subsidiary, to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company.
Another option would be to file this bug in Collaborate and include details on your Business Central build number and country. Quick link: https://developer.microsoft.com/en-us/dashboard/collaborate/engagements/1173/feedback/wits/Bugs/create.

Hi Jesper, I'm not moving this issue again, it was already moved from Microsoft/AL#1620
Please see this issue as I elaborated here.
The problem is, that the FaxEmailValue must come as the last mergefield in CreateHeader AND AddFieldsToMergeSource functions. Now the both functions are out of sync, and when you try to extend the both functions, the merge will fail.

So, the only change you need to do is the following:
In function AddFieldsToMergeSource, switch the following 2 lines:
AddNewEntry(COPYSTR(FaxMailToValue,1,MAXSTRLEN(Name)),'');
OnAddFieldsToMergeSource(TempNameValueBuffer,Salesperson,Country,Contact,CompanyInfo,SegLine,InteractLogEntry);
to:
OnAddFieldsToMergeSource(TempNameValueBuffer,Salesperson,Country,Contact,CompanyInfo,SegLine,InteractLogEntry);
AddNewEntry(COPYSTR(FaxMailToValue,1,MAXSTRLEN(Name)),'');

Thanks for clarifying! It wasn't clear to us what exactly you proposed - it is now :-)
But I'm afraid that is only part of the solution. While investigating, we found more issues than that. I've created a new bug for the correct team, which will look into it. We're on it. Finally.

And yes, there are more "bugs". If you extend the functions with too many fields (total more than 64, including standard NAV fields) it will fail. This is because of a bug in merging HTML tables in office. Solution for this might be the use of CSV tables.
See the original issue https://github.com/Microsoft/AL/issues/1057 for this solution.


Unable to approve pr in the netlify-cms gui

- Do you want to request a feature or report a bug?
Feature
- What is the current behavior?
If the publish branch is a protected branch on GitHub, the content owner is unable to approve the pull request within the netlify-cms gui. Instead they have to go to GitHub and approve the pr there, which breaks their workflow experience.
- What is the expected behavior?
As most content teams are not developers or even tech savvy people, they should not be required to go into github to approve a pr, there should be a way to approve the changes within netlify-cms workflow itself.

Potential solution discussed in #1669.

Agreed, the GitHub backend should account for this.

Additionally to what @ArcaneTSGK mentioned above, as it wasn't clear for me, I believe the user dragging the changes to the "Ready" column should be the user approving the PR in GitHub (through the backend).
@erquhart Any news on this? This is currently blocking our content team from managing their work themselves and relying on a team of developers to manually approve their content changes on GitHub insert sad kitten

Hi @pmpinto, we're open to contributions for this issue. I would say it's a medium size effort to add an approve button to an editorial workflow entry that's only enabled for users that didn't author the entry


Fix: TableValued Function returns complex type with nested enum

Fix: TableValuedFunction with nested enum type in Return type did not work

Thanks for the PR! I will try to publish a new version of the package on NuGet over the weekend.

@Amberg - https://www.nuget.org/packages/EntityFramework.CodeFirstStoreFunctions/1.1.1

Thx for this fast release.


Add new plugin for NestJS

Description
Add a new plugin for @nestjs/graphql
Related #547
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as
expected)
[x] This change requires a documentation update

How Has This Been Tested?
Duplicated testing structure of TypeGraphQL.
Checklist:

[ ] I have followed the
CONTRIBUTING doc and the
style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Published<EMAIL_ADDRESS>


Remove channel conversion from read_image function

Description

This PR removes cv2.COLOR_RGB2BGR conversion from images. This is instead left as optional.

Add draw_contours function to replace mark_boundaries function from skimage.

Fixes #1218

Changes

Describe the changes you made

[ ] Bug fix (non-breaking change which fixes an issue)
[x] Refactor (non-breaking change which refactors the code base)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Checklist

Ensure that you followed the following

[ ] I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas (If applicable)
[x] I have made corresponding changes to the documentation (If applicable)
[] I have added tests that prove my fix is effective or that my feature works (If applicable)

Closing this since the API has now significantly changed. We'll need to revisit this.


On mobile devices (iPad, Android phone), progress bar doesn't update on first song

Issue description
Use an iPad (Safari or Chrome) or Android phone (Samsung browser or Chrome) and navigate to:
https://521dimensions.com/open-source/amplitudejs/docs/examples/
Play the first song loaded in any of the examples. Note that the song will play, but the progress bar will not update. The current time will also not update. Tapping on the progress bar will change the position on the song, but you will not see any indication of the new song position on either the current time nor the progress bar. Once you change songs, everything mentioned previously will work.
This is a particular problem for me because I would like to use the single song player. Because there is only one "song", I am unable to get the current time & progress bar to work properly on the mobile devices I've tested on.
Environment

What's My Browser Support link: https://www.whatsmybrowser.org/b/C3A20
https://www.whatsmybrowser.org/b/YQMFU
https://www.whatsmybrowser.org/b/SJTQE
https://www.whatsmybrowser.org/b/4KKMB

Amplitude.js Version: whatever version you use on your examples page.

Steps to reproduce the issue

Use one of the device/browsers listed.
Navigate to https://521dimensions.com/open-source/amplitudejs/docs/examples/
Play the song (for single song player) or first song (for all others)

What is expected?
Current time updates while song plays. Progress bar updates while song plays.
Link to where issue can be reproduced
https://521dimensions.com/open-source/amplitudejs/docs/examples/
Additional details / screenshots

I am having the same issue. Additionally, I can reproduce the issue on desktop (using Firefox 71 64bit for Linux) in Responsive Design Mode (RDM) if (and only if) I reload the page using any preset device settings. All examples work as expected on desktop otherwise, even in RDM when not using a preset.
The only difference I observe from OP's description is that I can't count on these features to start working when I play the second song. Sometimes, I have to switch between songs several times before it begins to work as expected, at which point it continues to work as expected indefinitely. I cannot discern a pattern as to why it begins to work sometimes and not other times.
A couple of observations that may be helpful -

If, when playing the first song, I invoke Amplitude.bindNewElements() in dev console, the current time, progress bar, etc. immediately update and work as expected. However, upon switching songs, the issue persists and the elements remain broken (unless they don't, as described above).
Something screwy seems to be going on with events here. I have attempted to add a play callback as shown below.
In this case, "play" is not logged after reloading and pressing play while in RDM—but just as before, it works as expected in other circumstances.

Amplitude.init({
  /* songs here, etc. */
  callbacks: {
    initialized: function() {
      Amplitude.getAudio().addEventListener('play', function() {
        console.log('play');
      });
    }
  }
});

I am able to replicate this on the main site too: https://521dimensions.com/open-source/amplitudejs
I am escalating this to @danpastori for further review.

Ugh, never mind. I'm now using jPlayer, which works flawlessly.

Sorry that our FREE software with FREE support offended you. Glad that you found a solution that works for you.

First off, I wouldn’t categorize myself as being offended, but whatever. Hey, we are all software engineers here, so I do appreciate your attempts to provide work free of charge. I’d be glad to pay for your work, if it did work. My mistake was that I went in with the assumption that it would work reasonably well, especially on mobile devices, but it does not. That’s OK; I’m sure you’ll figure out the problem. Meanwhile, I spent quite a bit of time integrating your work into my project and when my stuff didn’t work on iOS, I spent quite a bit more time with my code thinking I had bugs preventing your player from working properly. I had never expected you to fix the problem immediately after I reported it, but 2 weeks to acknowledge that the problem exists? Whenever developers make their work available for free, they do so knowing that they get something in return: they get free feedback and QA. Like I said, I spent a lot of time trying to pinpoint problems in your work, and it looks like  mrhanna spent a heck of a lot more time than me. Hopefully, you’ll put my efforts and especially mrhanna’s efforts to good use. Meanwhile, the bug I submitted sat idle for 2 weeks and when you did reply you did not specifying an expected fix timeframe. Yes, I’m frustrated that your library isn’t ready for prime time. That’s my problem. But you seem to imply that awful response timeframe is justified by labeling as “free”, and I don’t know if that’s helping your cause.

So I've definitely narrowed this down to the native timeupdate event not being fired on mobile. This is really unique since it's able to be replicated in the browser as well but only in responsive testing mode. I am doing some more research, and will hopefully have a fix soon.
@mrhanna The play() callback has been fixed in the dev branch if you want to give that a try. That had to do with rebinding events after clearing out the audio. I assume this is what we are looking at with the timeupdate as well, but it's tricky to narrow down.
Fix hopefully coming soon 🤞

I have found One Temporary Fix for this .... Load the Player in Paused State... Just after Amplitude.init, call Amplitude.paused(); ... Now player will be in paused state, so whenever you play a song, it will fix that issue of time and progressbar.

Thank you @kartikcool15 ! This will work for until a fix is in place for sure!

@danpastori : Thanks, I am using amplitudejs since long, So mostly familiar with most of the issues

You're a rockstar @kartikcool15, thanks!

I have found One Temporary Fix for this .... Load the Player in Paused State... Just after Amplitude.init, call Amplitude.paused(); ... Now player will be in paused state, so whenever you play a song, it will fix that issue of time and progressbar.

One typo in the solution above. Amplitude.paused() should be Amplitude.pause() (so "paused" => "pause")
Thank you so much for the fix! It saved me🎉

With the release of Amplitude 5.3, this has been fixed. The issue stemmed from re-binding events on song changes which was caused by creating a new Audio object. Let me know if any more bugs come up!


[jvm-packages] Repair spark model eval

In the refactor to add base margins, #2532, all of the labels were lost
when creating the dmatrix. This became obvious as metrics like ndcg
always returned 1.0 regardless of the results.

Somewhat related, although I didn't look too closely because I don't use base margins, but it seems if you did train a model using base margins then you will also need to use them when evaluating the model or the results will be incorrect? It could be they are making it through and i simply didn't notice though.

Codecov Report

Merging #2841 into master will increase coverage by 0.65%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2841      +/-   ##
============================================
+ Coverage     43.08%   43.73%   +0.65%
============================================
  Files           151       91      -60
  Lines         11519     8656    -2863
  Branches       1167      725     -442
============================================
- Hits           4963     3786    -1177
+ Misses         6225     4723    -1502
+ Partials        331      147     -184

Impacted Files
Coverage Δ
Complexity Δ

...c/main/scala/ml/dmlc/xgboost4j/scala/XGBoost.scala

...a/ml/dmlc/xgboost4j/scala/flink/XGBoostModel.scala

...lc/xgboost4j/scala/spark/params/CustomParams.scala

...dmlc/xgboost4j/scala/example/CrossValidation.scala

...c/main/java/ml/dmlc/xgboost4j/java/XGBoostJNI.java

...xgboost4j/scala/spark/XGBoostRegressionModel.scala

.../dmlc/xgboost4j/java/example/BasicWalkThrough.java

.../src/main/java/ml/dmlc/xgboost4j/java/Booster.java

...main/java/ml/dmlc/xgboost4j/java/XGBoostError.java

...st4j/scala/rabit/handler/RabitTrackerHandler.scala

... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91af8f7...d4fcab7. Read the comment docs.

[...] if you did train a model using base margins then you will also need to use them when evaluating the model or the results will be incorrect.

I think in that case you'd need access to the model which produced the base margins, otherwise, the output would be miscalibrated. Wdyt @CodingCat?


⚠ Bofrost.at has degraded performance

In aed17e3, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1019 ms

Resolved: Bofrost.at performance has improved in 4a847e2 after 7 minutes.


ValueError: cannot find context for 'fork'

Description
When importing aiomultiprocess, I got this error.
Details
from aiomultiprocess import Pool
Traceback (most recent call last):
File "", line 1, in
from aiomultiprocess import Pool
File "C:\Users\patlo\Anaconda3\lib\site-packages\aiomultiprocess_init_.py", line 11, in
from .core import Pool, Process, Worker
File "C:\Users\patlo\Anaconda3\lib\site-packages\aiomultiprocess\core.py", line 35, in
context = multiprocessing.get_context("fork")
File "C:\Users\patlo\Anaconda3\lib\multiprocessing\context.py", line 238, in get_context
return super().get_context(method)
File "C:\Users\patlo\Anaconda3\lib\multiprocessing\context.py", line 192, in get_context
raise ValueError('cannot find context for %r' % method)
ValueError: cannot find context for 'fork'

OS:
Python version:3.6.3
aiomultiprocess version:0.4.0
Can you repro on master? Yes
Can you repro in a clean virtualenv? NO

Apparently python doesn't support any multiprocessing contexts except "spawn" on Windows.  It probably makes sense to just use the default context rather than specifying one in specific.

Apparently python doesn't support any multiprocessing contexts except "spawn" on Windows. It probably makes sense to just use the default context rather than specifying one in specific.

Sir,  is there any solution or suggestion for this error in Windows now?

Sorry for the delay on this.  Windows should be correctly supported (but mostly untested by me) on the master branch now (and tag v0.5.0), and will be available on PyPI soon.  If there are further problems with Windows on v0.5.0, please open new issues.


Overlay documentation

closes #2807
documentation for #2735

closing this draft PR, new PR here: https://github.com/jpmorganchase/salt-ds/pull/2860


Common VSCode settings

How to setup the cod editor is a rather personal thing, but it is useful to have a common set of settings or tools adding the coding. For the .vscode/settings.json file, I would suggest to have the following:
{
    "python.linting.pylintEnabled": true,
    "python.linting.flake8Enabled": true,
    "python.linting.mypyEnabled": true,
    "python.linting.enabled": true,
    "python.formatting.provider": "black",
    "editor.formatOnSave": true,
    "workbench.tree.indent": 24,
    "editor.rulers": [
        88
    ],
    "files.autoSave": "afterDelay",
    "python.testing.unittestEnabled": false,
    "python.testing.pytestEnabled": true,
    "python.testing.pytestArgs": [
        "-s",
        "tests"
    ],
    "workbench.editorAssociations": {
        "*.ipynb": "jupyter-notebook"
    },
    "rewrap.autoWrap.enabled": true,
    "editor.wordWrapColumn": 88,

The suitability of these options should be discussed and some of them might need further configuration in VSCode, like installing another extension or a dev-dependency.

For any additional extensions needed, you can also consider adding them to
extensions.json so they'll be recommended to developers.


Collect all the accounts and data for the demo

Accounts documented here: https://github.com/keyko-io/odyssey-dashboard#nevermined-integration
All of them having ETH in Rinkeby


How to determine version or date/time stamp of currently used FSC.exe, FSI.exe and other F# tools in Visual Studio

More of a question than an issue, but I often find myself wondering what the current version is that I am using in Visual Studio. With multiple branches, nightlies vs RTM releases, multiple PR's often being switched/build all the time and one VS Preview installation, I wonder how I can check this. Thinking of:

version/date of used FSC.exe, FSI.exe
version/date of compiler / language service (syntax highlighting, error squigglies)
anything else

I deliberately mean date here, as I believe version is not updated on each build. I wouldn't mind writing a little script that can be copy/pasted in FSI to query this info, just need to know where to find it by hand.
Showing the logo would perhaps get me closer, but --nologo is the default in VS and cannot be changed I believe.
(edit) this is interesting (but only resolves this for FSI):
File.GetCreationTime(Assembly.GetEntryAssembly().Location);;
val it : DateTime = 23-9-2017 14:55:27 {Date = 23-9-2017 0:00:00;
                                        Day = 23;
                                        DayOfWeek = Saturday;
                                        DayOfYear = 266;
                                        Hour = 14;
                                        Kind = Local;
                                        Millisecond = 721;
                                        Minute = 55;
                                        Month = 9;
                                        Second = 27;
                                        Ticks =<PHONE_NUMBER>77215120L;
                                        TimeOfDay = 14:55:27.7215

After doing a VSIXInstaller.exe release\net40\bin\VisualFSharpOpenSource.vsix, I saw the date changing, so that's good. But how to do the same for FSC.exe? I checked internal compiler switches, but nothing yet.

I think we would normally want this https://github.com/Microsoft/visualfsharp/issues/2323?

@dsyme, that thread (and its related threads) suggest to somehow lock the github SHA in the metadata of the assemblies. While I think that is a good idea, it wouldn't fully resolve this issue:

The SHA won't be clear for "normal" users, adding a timestamp would certainly be beneficial
You cannot access whatever is inside FSC.exe from your code, because your code does not know what FSC.exe is used and cannot magically access it.

The first is easy to solve, just add some more metadata. The second is a tad harder. I would think about a primitive (though not a keyword) which, when used, will return some info of the fsc.exe. This could be the version string, the assembly build date or creation date, or could even be configurable.
But to keep things easy, consider you'd have a primitive compilerVersion() and it would return you an AssemblyName with enough data, then I'd guess that suffices, given that we expand the AssemblyName with something specific for debug builds (i.e., fill the build-number field, for instance).
Even if we expose such member only during development, it would already be beneficial. It took me a week to find out that I wasn't compiling against the new fsc.exe from Visual Studio, and perhaps I was ignorant, but I might not be the only one.
Just a suggestion, perhaps there's an easier way or magic trick.

The File Version field from the details tab is the "official version number".
It doesn't tell what source branch or hash originated it.
The nightlies do not deliver an updated compiler.
The CSC command displays the version number like this, with a detailed version number and the SHA.
Microsoft (R) Visual C# Compiler version <IP_ADDRESS>019 (b7354608)
Copyright (C) Microsoft Corporation. All rights reserved.
warning CS2008: No source files specified.
error CS1562: Outputs without source must have the /out option specified
We should do this for fscd fsi.

@KevinRansom, yes, that would be great, and thanks for the summary!
But that would be only half way, as still, it would be beneficial to know "from code" what compiler was used (even if it were only to know that running the tests uses the compiler you intended the tests for). Compare, for instance, phpInfo() from PHP (and I still remember that after years not using PHP :p ), though PHP is of course interpreted, so we need to bake it into the compiler with an intrinsic (or what is the word).


Translate README.md

Translate README.md into Japanese

I'll run through this on my branch. Thank you for your help.


docs: Clearer instructions on where the .continue directory lives

In the current docs, it's not clear where .continue lives. Since most vscode extensions live inside of ~/.vscode, it's not obvious to look in ~.

there is also an open issue at the moment about the location of the .continue folder

#558

do you have an opinion on the matter ?
so the maintainers get a bit of feedback and can 'solve'  the matter in one swing

@mhkeller Thanks this is great! Sorry it took me a minute to see it
@LangLangBart Will most likely be adding an option to allow selecting of a different location, which I don't think should affect this documentation - those who set the location of .continue will likely know where to find it

Fwiw I added a comment on the other issue


[SPARK-16475][SQL] Broadcast Hint for SQL Queries

What changes were proposed in this pull request?
This PR aims to achieve the following two goals in Spark SQL.
1. Generic Hint Syntax
The generic hints are parsed and transformed into concrete hints by SubstituteHints of Analyzer. The unknown hints are removed, too. For example, Hint("MAPJOIN") is transformed into BroadcastJoin and other hints are removed currently.
SELECT /*+ MAPJOIN(t) */ * FROM t
SELECT /*+ STREAMTABLE(a,b,c) */ * FROM t
SELECT /*+ INDEX(t emp_job_ix) */ * FROM t

Unlink Hive, NEWMAPJOIN(t) is allowed for accepting new Spark Hints.
2. Broadcast Hints
The followings are recognized. Technically, broadcast hints are matched UnresolvedRelation to support Hive MetastoreRelation. The style of database_name.table_name is not allowed in this PR.

How was this patch tested?
Pass the Jenkins tests with new testcases.

Test build #63048 has started for PR 14426 at commit ee8bb14.

Test build #63048 has finished for PR 14426 at commit ee8bb14.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63048/
Test PASSed.

Why creating a new pull request? All the discussions were in the other pull request.

Oh, it's just because the previous PR page with 363 comments becomes too slow to view in my laptop. Since the most recent discussion was ended two days ago with implementations. I think it's safe and better for being review again here. I can move some summary of the previous discussion decision into here, too.

Test build #63348 has started for PR 14426 at commit 79c91be.

Test build #63348 has finished for PR 14426 at commit 79c91be.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63348/
Test PASSed.

Merged build finished. Test PASSed.

Rebased to resolve conflicts on SqlBase.g4.

Test build #63639 has started for PR 14426 at commit 67330a7.

Test build #63639 has finished for PR 14426 at commit 67330a7.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63639/
Test PASSed.

Test build #63756 has started for PR 14426 at commit ff4f428.

Test build #63756 has finished for PR 14426 at commit ff4f428.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63756/
Test PASSed.

Merged build finished. Test PASSed.

Hi, @cloud-fan .
Could you review this PR about HINT when you have some time?

Test build #64042 has started for PR 14426 at commit d722be2.

Test build #64042 has finished for PR 14426 at commit d722be2.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64042/
Test FAILed.

Merged build finished. Test FAILed.

Test build #64108 has started for PR 14426 at commit 71954e2.

Test build #64108 has finished for PR 14426 at commit 71954e2.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64108/
Test PASSed.

Resolve conflicts.

Test build #64132 has started for PR 14426 at commit 351dfef.

Test build #64132 has finished for PR 14426 at commit 351dfef.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64132/
Test PASSed.

Do this PR support multiple JOINs(SELECT * FROM t1 JOIN t2 ON t1.key = t2.key JOIN t3 ON t1.key = t3.key)?

Oh, sorry for late response, @watermen . I missed your message. Yes. This supports multiple joins.

For your testcase, I will check again locally and add as a test case to ensure that.

Hi, @watermen . You can try that like this.
scala> spark.range(1000000000).createOrReplaceTempView("t1")
scala> spark.range(1000000000).createOrReplaceTempView("t2")
scala> spark.range(1000000000).createOrReplaceTempView("t3")
scala> sql("SELECT * FROM t1 JOIN t2 ON t1.id = t2.id JOIN t3 ON t1.id = t3.id").explain
== Physical Plan ==
*SortMergeJoin [id#0L], [id#8L], Inner
:- *SortMergeJoin [id#0L], [id#4L], Inner
:  :- *Sort [id#0L ASC], false, 0
:  :  +- Exchange hashpartitioning(id#0L, 200)
:  :     +- *Range (0,<PHONE_NUMBER>, splits=8)
:  +- *Sort [id#4L ASC], false, 0
:     +- ReusedExchange [id#4L], Exchange hashpartitioning(id#0L, 200)
+- *Sort [id#8L ASC], false, 0
   +- ReusedExchange [id#8L], Exchange hashpartitioning(id#0L, 200)

scala> sql("SELECT /*+ MAPJOIN(t1) */ * FROM t1 JOIN t2 ON t1.id = t2.id JOIN t3 ON t1.id = t3.id").explain
== Physical Plan ==
*SortMergeJoin [id#0L], [id#8L], Inner
:- *Sort [id#0L ASC], false, 0
:  +- Exchange hashpartitioning(id#0L, 200)
:     +- *BroadcastHashJoin [id#0L], [id#4L], Inner, BuildLeft
:        :- BroadcastExchange HashedRelationBroadcastMode(List(input[0, bigint, false]))
:        :  +- *Range (0,<PHONE_NUMBER>, splits=8)
:        +- *Range (0,<PHONE_NUMBER>, splits=8)
+- *Sort [id#8L ASC], false, 0
   +- Exchange hashpartitioning(id#8L, 200)
      +- *Range (0,<PHONE_NUMBER>, splits=8)

scala> sql("SELECT /*+ MAPJOIN(t2) */ * FROM t1 JOIN t2 ON t1.id = t2.id JOIN t3 ON t1.id = t3.id").explain
== Physical Plan ==
*SortMergeJoin [id#0L], [id#8L], Inner
:- *Sort [id#0L ASC], false, 0
:  +- Exchange hashpartitioning(id#0L, 200)
:     +- *BroadcastHashJoin [id#0L], [id#4L], Inner, BuildRight
:        :- *Range (0,<PHONE_NUMBER>, splits=8)
:        +- BroadcastExchange HashedRelationBroadcastMode(List(input[0, bigint, false]))
:           +- *Range (0,<PHONE_NUMBER>, splits=8)
+- *Sort [id#8L ASC], false, 0
   +- Exchange hashpartitioning(id#8L, 200)
      +- *Range (0,<PHONE_NUMBER>, splits=8)

scala> sql("SELECT /*+ MAPJOIN(t3) */ * FROM t1 JOIN t2 ON t1.id = t2.id JOIN t3 ON t1.id = t3.id").explain
== Physical Plan ==
*BroadcastHashJoin [id#0L], [id#8L], Inner, BuildRight
:- *SortMergeJoin [id#0L], [id#4L], Inner
:  :- *Sort [id#0L ASC], false, 0
:  :  +- Exchange hashpartitioning(id#0L, 200)
:  :     +- *Range (0,<PHONE_NUMBER>, splits=8)
:  +- *Sort [id#4L ASC], false, 0
:     +- ReusedExchange [id#4L], Exchange hashpartitioning(id#0L, 200)
+- BroadcastExchange HashedRelationBroadcastMode(List(input[0, bigint, false]))
   +- *Range (0,<PHONE_NUMBER>, splits=8)

Test build #64360 has started for PR 14426 at commit ef1abc7.

Test build #64360 has finished for PR 14426 at commit ef1abc7.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64360/
Test PASSed.

Test build #64529 has started for PR 14426 at commit 6461e41.

Test build #64529 has finished for PR 14426 at commit 6461e41.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64529/
Test PASSed.

Test build #64574 has started for PR 14426 at commit 377b625.

Test build #64574 has finished for PR 14426 at commit 377b625.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64574/
Test PASSed.

Merged build finished. Test PASSed.

Test build #64875 has started for PR 14426 at commit 2cc19b3.

Test build #64875 has finished for PR 14426 at commit 2cc19b3.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64875/
Test PASSed.

Test build #64966 has started for PR 14426 at commit 42248a1.

Test build #64966 has finished for PR 14426 at commit 42248a1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64966/
Test FAILed.

Test build #65023 has started for PR 14426 at commit 0d19e28.

Test build #65023 has finished for PR 14426 at commit 0d19e28.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65023/
Test FAILed.

Merged build finished. Test FAILed.

Test build #65142 has started for PR 14426 at commit 01105f5.

Test build #65142 has finished for PR 14426 at commit 01105f5.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65142/
Test PASSed.

Test build #65249 has started for PR 14426 at commit 47d98e7.

Test build #65249 has finished for PR 14426 at commit 47d98e7.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65249/
Test PASSed.

Rebased to resolve conflicts.

Test build #65432 has started for PR 14426 at commit b1f314c.

Test build #65432 has finished for PR 14426 at commit b1f314c.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65432/
Test FAILed.

Test build #65663 has started for PR 14426 at commit 5ac4457.

Test build #65663 has finished for PR 14426 at commit 5ac4457.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65663/
Test PASSed.

Test build #65927 has started for PR 14426 at commit e9ba01e.

Test build #65927 has finished for PR 14426 at commit e9ba01e.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65927/
Test PASSed.

Merged build finished. Test PASSed.

Test build #66220 has started for PR 14426 at commit b180019.

Test build #66220 has finished for PR 14426 at commit b180019.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66220/
Test PASSed.

Merged build finished. Test PASSed.

Hi, @rxin .
Could you give me some guide for this Broadcast Hint for SQL Queries if you have sometime?

Hi, @gatorsmile .
Could you review this PR when you have some time?

Test build #66515 has started for PR 14426 at commit 5290081.

Test build #66515 has finished for PR 14426 at commit 5290081.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66515/
Test PASSed.

Rebased to resolve the conflicts.

Test build #66546 has started for PR 14426 at commit 778cede.

Test build #66546 has finished for PR 14426 at commit 778cede.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66546/
Test PASSed.

Merged build finished. Test PASSed.

Test build #66619 has started for PR 14426 at commit 57adfd3.

Test build #66619 has finished for PR 14426 at commit 57adfd3.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66619/
Test PASSed.

Test build #67189 has started for PR 14426 at commit 7483889.

Test build #67189 has finished for PR 14426 at commit 7483889.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67189/
Test PASSed.

Test build #67425 has started for PR 14426 at commit dfe6a3e.

Test build #67425 has finished for PR 14426 at commit dfe6a3e.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67425/
Test PASSed.

Resolve the conflicts.

Test build #68088 has started for PR 14426 at commit 539782d.

Test build #68088 has finished for PR 14426 at commit 539782d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68088/
Test FAILed.

Retest this please

Test build #68092 has started for PR 14426 at commit 539782d.

Test build #68092 has finished for PR 14426 at commit 539782d.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Hint(name: String, parameters: Seq[String], child: LogicalPlan) extends UnaryNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68092/
Test PASSed.

Mind closing this for now? Let's open it once we've done the view canonicalization work. This pr will be much simpler. We should do both in 2.2.

Thank you for guide.

@dongjoon-hyun do you have time to update the pull request now the view canonicalization work is done? Basically we can remove all the SQL generation stuff.

Actually I have some time. I will submit a pr based on this.

Oh.


[Azure Cognitive Search] Add x-nullable: true to CorsOptions.maxAgeIn…

…Seconds
Fixes https://github.com/Azure/azure-rest-api-specs/issues/12377
Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[X] Other, please clarify

Fixing codegen issue by making Swagger consistent with actual REST API behaviour

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[X] SDK of .NET (need service team to ensure code readiness)
[X] SDK of Python
[X] SDK of Java
[X] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[X] I commit to follow the Breaking Change Policy of “no breaking changes
[X] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@anuchandy Please merge at your earliest convenience.

@anuchandy Please merge at your earliest convenience.


Add TGIS test for fetching model from Minio object storage

Covering RHOAIENG-3490.
PR validation (including regression): rhods-ci-pr-test/2529 PASS

 Quality Gate failed
Failed conditions  1 Security Hotspot
See analysis details on SonarCloud

not related to this PR. Will analyse and address in a different one


Hybrid dynamics with contact

Hi, I would like to ask how best problems of hybrid dynamics, arrising from contact, can be solved using mujoco.
As an example, let's say that I am controlling the "cheetah" from the dm_control suite and I want to position it's head while it is standing on the ground. One possible approach would be to prescibe its head some trajectory with continuous second derivatives and solve a problem that would be classified as hybrid dynamics (according to Featherstone).
Precisely, I would have some demands on the accelerations of root_x, root_z and root_y while the accelerations of other joints could be optimized along with actuators' inputs. In this case it would be a generalized problem of hybrid dynamics with over-actuation but similar exactly-actuated problems (number of desired accelerations equals the number of actuators) could also be formulated.
In rigid body dynamics without contact the exactly-actuated problem has an exact solution while the over-actuated problem can be solved using QP with a cost function such as u'Ru and equality constraints in the of EoM.
This leads me to think that an approach to finding a solution to exactly-actuated hybrid dynamics with contact should be compatible with the way mujoco handles contact (soft penalty).

This comment is rather confusing.
First, what is "hybrid dynamics"? I think perhaps you mean the approach whereby contact is represented as bilateral rather than unilateral constraints? Maybe you mean something else? Please clarify.
Second, you open your comment by saying that you would like to ask a question, but then there is no question. Do you have a question?

In Featherstone's book the hybrid dynamics' problem (of an exactly actuated mechanisms without kinematic loops) is loosely defined as finding m applied forces (in joint space) and n-m joint accelerations for given values of the remaining n-m forces and m accelerations (n is the number of DoF). So in effect it is a mix of the forward and inverse dynamics problem.
A very similar problem to this are the inverse dynamics of a system with any form of constraints (kinematic loops). Where we can set only a select number of desired joint accelerations as other must be calculated so that the constraints are satisfied.
I wanted to ask if/how mujoco can be used to solve this type of problems when the constraints are the result of contact.
I hope I explained it a bit better now.

I see, thanks for the explanation.
If I understand the setup correctly, I don't think it is directly doable in MuJoCo, except perhaps by some optimisation procedure.
Note however that inverse dynamics is well defined in MuJoCo in the presence of contacts. That is to say that given {qpos, qvel, qacc}, a call to mj_inverse will compute not just the applied forces qfrc_inverse, but also all contact/constraint forces in efc_force (and its projection – qfrc_constraint).
Take a look at our LQR colab (item 2 in the 2.3.0 changelog), where this property is explicitly made use of.

Sorry for the long delay, I didn't want to reply before I had time to read through the relevant documentation properly.
If I understand it correctly, mujoco's soft constraint model makes all qacc feasible along with other benefits. An example of a downside in comparison to rigid contact models is then that a "magic" force would have to hold up the humaniod in the colab you referenced.
From what I read in the paper, Goal-Directed Dynamics should be capable of solving a bigger family of problems, including the one that I described, in the future which I was glad to find out. For now I'll go back to exporing my options, thank you for your time.


Bugfix: gemsets didn't handle paths correctly

Motivation for this change
As I'm returning to a Ruby project, I discovered that gems with a "path" source (important for dev work) would crash nix-shell. This corrects the issue.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

thanks!


Mutli Level Inheritance in Cpp

Hackerrank problem link
Provide your hackerrank problem link here.
https://www.hackerrank.com/challenges/multi-level-inheritance-cpp/problem
Issue Checklist

[X] If you have previously contributed to this repo, you declare that you have not made a pull request for more than one issue in this repo till now.
[X] Your forked repo is up-to-date with the the origin remote.
[X] Have you checked that the hackerrank problem you are raising is not already present in the repo?
[X] Have you checked that the hackerrank problem you are raising is not raised by or assigned to another contributor?

Any other Changes?
If you are raising an issue with some more changes, please provide the details here.

@deepanshu-rawat6
Hey, Thanks for raising an issue!
Unfortunately, more than one issues cannot be assigned at a time.
Please complete the previous issue before claiming this issue.
Happy Coding😃!

@deepanshu-rawat6 Hey, Thanks for raising an issue! Unfortunately, more than one issues cannot be assigned at a time. Please complete the previous issue before claiming this issue. Happy Coding😃!

Hi, my previous issue has been completed so can you please assign this issue to me?


Fix settings panel #780

Possible fix for #780
Pull Request
📖 Description
Removed right styling from fluent-dialog-footer.
🎫 Issues
Issue reported in #780
👩💻 Reviewer Notes
📑 Test Plan
N/A
✅ Checklist
General

[ ] I have added tests for my changes.
[X my changes.
[ ] I have updated the project documentation to reflect my changes.
[X] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific
N/A
⏭ Next Steps

Already being worked on by @vnbaaij 😆


⚠ DesiTorrents has degraded performance

In 2277bf2, DesiTorrents ($DST) experienced degraded performance:

HTTP code: 200
Response time: 2012 ms

Resolved: DesiTorrents performance has improved in 32eda42.


Allow aliases to be used in health checks (https://www.consul.io/api/…

…agent/check.html#aliasnode)

Thanks for the PR!
I merged a slightly modified version in #95 and published to npm in<EMAIL_ADDRESS>

Perfect, thank you! Very fast :)


LibWeb: Make getComputedStyle(e).getPropertyValue() see custom props

A lot of WPT tests rely on this mechanism to test unrelated things.

Sorta related, I thought this may have been the fix for an issue on our LibJS per-file results page where custom properties dictate the progress bar colors. The property is defined in the :root element class, but this function still returns empty string.
Would that be fixed here or in another layer?
Basic repro (console should log the custom property value instead of blank):
<!DOCTYPE html>
<html lang="en">
  <head>
    <style>
      :root {
        --my-background-color: #19db6e;
      }
    </style>

    <script>
      document.addEventListener("DOMContentLoaded", function () {
        const style = getComputedStyle(document.body);
        console.log(style.getPropertyValue("--my-background-color"));
      });
    </script>
  </head>
</html>

That should be fixed by this change yeah :)


[OSB] Allows all potions to be decantable into any dose

Description:

Decant was lacking a lot of potions;
Added all in-game potions that have doses and ignored the potions that are unique and have only 1 dose.
Usage: +decant [dose|4] potion name

Changes:

Adds all in-game dose potions to potions.ts

Allows decant.ts to decant into any dose

[X] I have tested all my changes thoroughly.

Testing result + procedure: decantTest.txt

Try to encapsulate this into a standalone function, and write unit tests for it - please. Decanting potions (where youre removing and adding various items and doing math) is particularly prone to item loss/dupe bugs, and I'd feel much better if we had tests guaranteeing it works.

Added unit testing


TS typings

If you define StorageService<T>, shouldn't get() be get<K extends keyof T>(key: K) instead of get(key: string): T ?
Because now, when you get a key, it returns the entire object type.

Because now, when you get a key, it returns the entire object type.

That is actually by design :)
Basically it reads and writes whatever you put in the web storage:
storageService.put('myData', { greeting: 'Hi!', happy: true });

storageService.get('myData'); // returns { greeting: 'Hi!', happy: true }

The type parameter T allows you to be more specific about what type of data you're reading and writing. Where the transcoder will do the encoding/decoding.

But having these, no transcoder usage is needed:
     has<K extends keyof T>(key: K): boolean;      get<K extends keyof T>(key: K): T[K] | undefined;      set<K extends keyof T>(key: K, value: T[K]): void;     remove<K extends keyof T>(key: K): void;


Requested package contentful/laravel @beta is satisfiable by contentful/laravel[dev-master, 0.6.x-dev] but these conflict with project requirements

Hi,
I got "- The requested package contentful/laravel @beta is satisfiable by contentful/laravel[dev-master, 0.6.x-dev] but these conflict with your requirements or minimum-stability." when installing this package with "composer require contentful/laravel:@beta" command in Laravel 5.3 fresh installation.

@heruputra If you haven't figured this out yet you need to run
composer require contentful/laravel:@dev

Male sure that you have in your composer.json
{
    ...
    "prefer-stable": true,
    "minimum-stability": "dev"
}

I just tagged a beta so this should now work. Sorry for the long delay.


General Grievance: Watch i-store.org

General Grievance requests the watch of the watch_keyword i-store\.org. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

i-store\.org has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by VLAZ in Charcoal HQ


travis: turn cache off for coverage build

The 'cargo tarpaulin' command clear the cache on startup.

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   93.17%   93.17%
=======================================
  Files           2        2
  Lines         337      337
=======================================
  Hits          314      314
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0ce42d...61f31ea. Read the comment docs.


120 second time-out

i'm using php 5.6.15, apache 2.4.17, and mySql 5.7.9. (wamp 3.0.4; win7 64 bit)
I attempted to download again using the admin panel within grav.  I got a weird timeout error that is best explained with a screenshot.

now after i refreshed the admin panel, I noticed that the theme seemed to download in its entirety.  But it was version 1.0.2

As I told you here https://github.com/giansi/gravstrap-theme/issues/8 you have to increase the max_execution_time in your pho.ini file. I guess 300 could be a good value. I'm not confortable with windows, so I can't help you with this configuration.


Feature/deprecation

Adds a deprecated HOC
Marks Header and SupportingHeader components, plus withWhiteSpace and asAnchor HOCs as being deprecated.
GridCol now has custom code to indicate that columnOneQuarter style props are deprecated.
Addresses component part of #569
Builds on feature/heading branch, so currently this is a draft - once that feature has been merged we'll change the PR to go against master.
Checklist:

[x] Documentation
[x] Tests
[x] Ready to be merged

Codecov Report

Merging #572 into feature/heading will increase coverage by <.01%.
The diff coverage is 100%.

@@                 Coverage Diff                 @@
##           feature/heading     #572      +/-   ##
===================================================
+ Coverage            99.61%   99.62%   +<.01%
===================================================
  Files                   90       91       +1
  Lines                  523      527       +4
  Branches                53       55       +2
===================================================
+ Hits                   521      525       +4
  Misses                   2        2

Impacted Files
Coverage Δ

components/header/src/index.js
100% <ø> (ø)
:arrow_up:

components/supporting-header/src/index.js
100% <ø> (ø)
:arrow_up:

packages/hoc/src/withWhiteSpace/index.js
100% <100%> (ø)
:arrow_up:

packages/hoc/src/deprecated/index.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb69424...beef117. Read the comment docs.

Custom code added to warn of use of deprecated props in GridCol component.
Pondering similar custom code for use of body prop in Table component

Deploy preview for govuk-react processing.
Building with commit 3e9daa4546342e141c950c55784a0084f82af19c
https://app.netlify.com/sites/govuk-react/deploys/5c76765826bc1e000af40053


Issue with Log4J2 Compression/Decompression on the Mainframe

Discussed in https://github.com/apache/logging-log4j2/discussions/1794

Originally posted by JamesChambers-E11074 September 15, 2023
I'm using gzip on a RollingAppender but am not able to to uncompress (via TAR) files on the mainframe.  I get a message stating "tar: decompress: FSUM 6636 no in compress format".  My appender is using the IBM-1047 charset.  Could that have something to do with it?  Does anyone else have experience with this?

Hi @JamesChambers-E11074,
Could you provide an excerpt of your Log4j configuration file?

Thanks for the fast answer.
I am closing this issue then, since we are unable to reproduce it.

That works.  If you ever want to reproduce it, simply run the code on zOS add a compress step and then look at the final ZIP.
From: Piotr P. Karwasz @.>
Sent: Tuesday, April 23, 2024 9:32 AM
To: apache/logging-log4j2 @.>
Cc: James Chambers @.>; Mention @.>
Subject: [External] Re: [apache/logging-log4j2] Issue with Log4J2 Compression/Decompression on the Mainframe (Issue #1795)
Thanks for the fast answer.
I am closing this issue then, since we are unable to reproduce it.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/apache/logging-log4j2/issues/1795*issuecomment-2072333009__;Iw!!MjIf2fY!jPdwAmGEDMZ9IbSY9gTDzcksYfH3cN3EGahyUJOGHIZVMVZ0cp3C1WeJRTSzCIqc39g-yjcSUHHL5WJzxVTH8_eH-A$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ASRQ2MCMKZSUR5A4BQSNNJ3Y6ZPDVAVCNFSM6AAAAAA4ZZRYQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZSGMZTGMBQHE__;!!MjIf2fY!jPdwAmGEDMZ9IbSY9gTDzcksYfH3cN3EGahyUJOGHIZVMVZ0cp3C1WeJRTSzCIqc39g-yjcSUHHL5WJzxVS7mzw-zg$.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>
CAUTION: This email originated outside of Aflac. Do not click links or open attachments unless you recognize the sender and know the contents are safe.

Confidentiality Notice:
This e-mail and any attachments may contain confidential information intended solely for the use of the addressee. If the reader of this message is not the intended recipient, any distribution, copying, or use of this e-mail or its attachments is prohibited. If you received this message in error, please notify the sender immediately by e-mail and delete this message and any copies. Thank you.


Allow network-scoped alias to be resolved for anonymous endpoint

Fixes #871
Signed-off-by: Madhu Venugopal<EMAIL_ADDRESS>

LGTM


Fixes crash on B3DMs without batch tables

This is a small fix that adds a condition to check whether a batch table is present in a B3DM before calling parseBatchTable for ModelExperimental
Sandcastle

Thanks for the pull request @sanjeetsuhag!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

Looks good, thanks @sanjeetsuhag!


Expose method to get public key from private key like in FIPS 204

Hi,
As exposed in your FIPS 204 crate. A method to get the public key would be very helpful
Thanks.

This is a recent addition:
https://docs.rs/fips205/0.4.0/fips205/slh_dsa_sha2_128f/struct.PrivateKey.html#method.get_public_key
Is it what you need?

Yes. Thanks!
On Thu, 17 Oct 2024, 09:18 integritychain, @.***> wrote:

This is a recent addition:
https://docs.rs/fips205/0.4.0/fips205/slh_dsa_sha2_128f/struct.PrivateKey.html#method.get_public_key
Is it what you need?
—
Reply to this email directly, view it on GitHub
https://github.com/integritychain/fips205/issues/4#issuecomment-2418296251,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR5NNL2O3256FO6YYP4PVPTZ34F6TAVCNFSM6AAAAABQCTKLGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJYGI4TMMRVGE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Write payload with boot_only

Add an option to not clean (or better do write) the payload with boot_only

Good idea, but I'd prefer to add a separate flag for this.

someting like --boot-only-with-payload ?

Yes I think that would do nicely for now. Maybe we should add a --mode flag in the future to replace the ones we have now so we can easily add more modes


RuntimeError: storage has wrong byte size

My sequence of commands on 4 different Ubuntu 22 boxes below. I'm about to try on a lower version of Ubuntu.
sudo apt install ffmpeg python3.10
or sudo apt install ffmpeg python3.10-dev
sudo apt install pip
pip install backgroundremover
backgroundremover -i "/path/to/image.jpeg" -o "output.png"
or backgroundremover -i "/path/to/image.jpeg" -m "u2net" -o "output.png"
or backgroundremover -i "/path/to/image.jpeg" -m "u2net_human_seg" -o "output.png"
or backgroundremover -i "/path/to/image.jpeg" -m "u2netp" -o "output.png"
I got this error on all the boxes.
Traceback (most recent call last):
  File "/usr/local/bin/backgroundremover", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/dist-packages/backgroundremover/cmd/cli.py", line 239, in main
    remove(
  File "/usr/local/lib/python3.10/dist-packages/backgroundremover/bg.py", line 183, in remove
    model = get_model(model_name)
  File "/usr/local/lib/python3.10/dist-packages/backgroundremover/bg.py", line 171, in get_model
    return detect.load_model(model_name="u2net")
  File "/usr/local/lib/python3.10/dist-packages/backgroundremover/u2net/detect.py", line 82, in load_model
    torch.load(
  File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 815, in load
    return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
  File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 1051, in _legacy_load
    typed_storage._untyped_storage._set_from_file(
**RuntimeError: storage has wrong byte size: expected %ld got %ld-2384061055873887482048**

Why is there an or? Should first install python and then install
python3.10-dev
On Fri, Sep 8, 2023 at 11:41 PM Desmond Campbell @.***>
wrote:

My sequence of commands on 4 different Ubuntu 22 boxes below. I'm about to
try on a lower version of Ubuntu.
sudo apt install ffmpeg python3.10
or sudo apt install ffmpeg python3.10-dev
sudo apt install pip
pip install backgroundremover
backgroundremover -i "/path/to/image.jpeg" -o "output.png"
or backgroundremover -i "/path/to/image.jpeg" -m "u2net" -o "output.png"
or backgroundremover -i "/path/to/image.jpeg" -m "u2net_human_seg" -o
"output.png"
or backgroundremover -i "/path/to/image.jpeg" -m "u2netp" -o "output.png"
I got this error on all the boxes.
Traceback (most recent call last):
File "/usr/local/bin/backgroundremover", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.10/dist-packages/backgroundremover/cmd/cli.py", line 239, in main
remove(
File "/usr/local/lib/python3.10/dist-packages/backgroundremover/bg.py", line 183, in remove
model = get_model(model_name)
File "/usr/local/lib/python3.10/dist-packages/backgroundremover/bg.py", line 171, in get_model
return detect.load_model(model_name="u2net")
File "/usr/local/lib/python3.10/dist-packages/backgroundremover/u2net/detect.py", line 82, in load_model
torch.load(
File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 815, in load
return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 1051, in _legacy_load
typed_storage._untyped_storage._set_from_file(
RuntimeError: storage has wrong byte size: expected %ld got %ld-2384061055873887482048
—
Reply to this email directly, view it on GitHub
https://github.com/nadermx/backgroundremover/issues/97, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYACXFVN7DALWBUG36WQZ3XZPQP7ANCNFSM6AAAAAA4RFEAQA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Ah okay, might need more memory to run it?

can you remove the background from the image using
backgroundremoverai.com/image ?
On Sat, Sep 9, 2023 at 12:12 AM Desmond Campbell @.***>
wrote:

OK, I tried with the same Ubuntu 20 box with 32 GB and got the same error.
Weird, right?
—
Reply to this email directly, view it on GitHub
https://github.com/nadermx/backgroundremover/issues/97#issuecomment-1712408358,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYACXGJNR3DQXPXMB6WIVLXZPUDHANCNFSM6AAAAAA4RFEAQA
.
You are receiving this because you commented.Message ID:
@.***>

Just to clarify, you installed on what ever box python3.x-dev (what ever version, so say python3.8-dev if you have python3.8, or in the other python3.10-dev)

I just tried it with python3.10 after installing python3.10-dev it worked,

So you did not clarify.  First in stalled say python3.10, then you ran sudo apt install python3.10-dev or did you just run sudo apt install python3-dev?

Once again you must install python3.10-dev and you seem to gloss over the thing that is in the read me and repeated  in this thread.  Please run sudo apt install python3.10-dev or what ever version of python you are using.

So, as I said imideatly after you queston "Why is there an or? Should first install python and then install
python3.10-dev"  So I am unsure how else to make it clear that after installing python you have to install pythin3.10-dev and then install backgroundremover.

Or what ever version of python you installed, so say for example if you install python3.8 then you must install python3.8-dev, or in your case it showed python3.10 so then python3.10-dev

I'm gonna close the issue, reopen if its still an issue


Prime CLI can send data through the UP

User Story:
As a developer, I want to be able to use the Prime CLI to send data through the UP, so that I can easily test sending messages.
Description/Use Case
The Prime CLI currently has the ability to send messages through the Covid Pipeline using the Prime CLI. We need to make sure it can support the UP.
Risks/Impacts/Considerations
Dev Notes:

The Prime CLI can send messages using this command:
./prime data --input /path/to/file.hl7 --output-dir /path/to/output/dir --input-client medarbor.default --route
Test this command with a UP sender and check if it's able to process both HL7 and FHIR messages

Acceptance Criteria

[ ] Prime CLI data command can process UP messages

Because the UP uses a separate pathway for translations and transforms, that command won't work for UP. There is an existing ./prime fhirdata that appears to be meant to be the UP version but its functionality is inconsistent.

Will pull if needed

Not needed.


Unity 2017.1 AssetBundle exception

With Unity 2017.1 we get the following exception whenever Leanplum runs a request:
Failed to decompress data for the AssetBundle 'Memory'.
UnityEngine.WWW:get_assetBundle()
LeanplumSDK.<RunRequest>c__Iterator0:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)

It seems to me that the issue is here:
https://github.com/Leanplum/Leanplum-Unity-SDK/blob/master/LeanplumSample/Assets/WebPlayerTemplates/DoNotCompile/Leanplum/LeanplumUnityHelper.cs#L161-L162
String.IsNullOrEmpty(www.error) && !isAsset ? www.text : null,
String.IsNullOrEmpty(www.error) ? www.assetBundle : null));

should be
String.IsNullOrEmpty(www.error) && !isAsset ? www.text : null,
String.IsNullOrEmpty(www.error) && isAsset ? www.assetBundle : null));

Thanks for identifying the issue! When you have time can you make a PR to the develop branch?

Above PR fixes this issue. Will keep the issue opened until we make a public release.

I'm running into this issue as well after upgrading Unity to 2017.1.  Could you advise me on what the best course of action is?  i.e. let me know when this will be fixed in a public SDK or could you shoot me over a dev SDK that I could import to fix this issue in the meantime?

After upgrading to 2017.1.0f3 I'm also getting the above error running Leanplum Unity SDK 1.4.2
Failed to decompress data for the AssetBundle 'Memory'.
UnityEngine.WWW:get_assetBundle()
LeanplumSDK.c__Iterator0:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
I don't have the LeanplumSample folder installed so the above patch does not fix this problem. I see this error when dragging and configuring the LeanPlum prefab into an empty scene and pressing play.

@asaia My fix is to the LeanplumSDK.dll. Your issue should be fixed by the next SDK version.
@alexisoyama Can you guys release an update? It's been a month...

Tracking this internally here: https://leanplum.atlassian.net/browse/LP-5763 and https://leanplum.atlassian.net/browse/LP-5764

@Nezz We will soon. Sorry for the delay. We thought the next iOS and Android will come out very soon and wanted to package those with it. We got some hiccups along the way and those got delayed. So instead we will probably be releasing Unity with this fix without waiting for them.

Fixed by https://github.com/Leanplum/Leanplum-Unity-SDK/releases/tag/1.4.3